Fixes overactive and noisy brake pump during braking on Honda cars

Prior to this fix, supplied by @rbiasini at comma.ai, the brake pump would always be set to ON any time the braking value was non-zero while OP was active.  This created more braking pump noise than necessary during braking and possibly overworked the pump.  This fix mimics Honda's stock ACC behaviour, where the brake pump only turns on during times of increasing braking pressure.  The result is decreased pump activity (and noise) during braking.

I swear... I will send you n00dz if this actually works.

The BRAKE_PUMP_REQUEST signal is binary:  ON or OFF.  I haven't seen a pressure indicator signal.  Without the pedal the difference is massive, especially when the car is almost at a stop and creeping.  There is no pump sound at all during slow creeps.  In any case matching Honda's behaviour for stock ACC is probably better than just turning the pump on whenever there is a non-zero braking applied.

This PR is solid.  Restores brake noise back to factory.  And it also got rid of a rattle I was hearing while the car was running... like a ticking that was constant while the car was on.  Not sure if that is coincidence or not.

I'm also playing with having the pump turn off at a stop and the brake_stopping_target (put less pressure on the brake when the car comes to a stop).  OP puts a lot of pressure on the brake when the car comes to a stop causing the pump to activate and also is a bit jarring when the car starts up again.  We'll see how my experiments go.....  I'll report back.

Really really excited to see your findings...
On Oct 31, 2018, 8:07 PM -0400, kegman<EMAIL_ADDRESS>wrote:

I'm also playing with having the pump turn off at a stop and the brake_stopping_target (put less pressure on the brake when the car comes to a stop). OP puts a lot of pressure on the brake when the car comes to a stop causing the pump to activate and also is a bit jarring when the car starts up again. We'll see how my experiments go..... I'll report back.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

curious as to why you removed method documentation in this PR..

@dekerr not sure what you mean?

docstrings in hondacan methods were removed. I don't think they should have been.

@dekerr: code changes came from Comma....  I just submitted the PR as per @rbiasini suggestion.

merged into devel in 0.5.6


Check for disabled particle trail particle before initializing particle trail

Follow up to https://github.com/godotengine/godot/pull/70422
This fixes an case that wasnt fully resolved by https://github.com/godotengine/godot/pull/70422. When a particle trail is first initialized, it just copies the flags from the parent and then returns. An issue arose where particles that were just initialized would set themselves to active and return, but since the parent was not active, they should not have been set to active in the first place. The solution is to check if the parent is active first, so if the parent is in fact not active, the trail particle can be set to not active and return early.
This PR also has a more granular return when using trials. Trails run in two passes of size num_particles and num_particles * (trail_size -1) for a total of num_particles * trail size. Since we always process particles in groups of 64 we have a check to early return threads whose index is greater than or equal to num_particles * trail_size however, since the trail pass is in two passes that are much smaller than that we end up processing a lot of particles and writing to unallocated memory. With memory boundary checks on, this just wastes performance. However, we would like to eventually disable memory boundary checks as they greatly reduce performance on mobile devices. So this ensures that particles do not attempt to write outside of their allocated memory when using trails.
CC @unfa Who caught this bug and provided an MRP.

Thanks!


Github actions workflow

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] design request

What is the current behavior? / What feature/design would you like to implement
Implement GitHub Actions to have an automated creation of projects + events.
The plan would be to:

Workflow is triggered when the issue is labelled "Published" or similar.
the basic setup python action  to run the script the issue_to_pages.py
the basic hugo-deploy.yml to deploy the website from the master branch to the gh-pages branch.

Other info:
It would be cool to port he python script in Go so it requires only the second action, but very far from being high in priority.

Closed this issue, but still available here


fix(deps): update lnd to v0.6.1-beta-rc1-1-g83adaaa0

Description:
Update lnd to v0.6.1-beta-rc1-1-g83adaaa0
Motivation and Context:
Update lnd
How Has This Been Tested?
Manually
Types of changes:
Deps update
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at 20.119% when pulling 8907ecc6a65c188d4ab4f07a319042f9a38114ce on mrfelton:chore/update-lnd into 135c266b34ef0c49169f0f4d16554cdfd7d4b55f on LN-Zap:next.


CFF2 instanciation render wrong glyph shapes

Hello, I'm instanciating static fonts from both ttf and cff2 variable fonts, and I not getting the same glyphs shapes in these static fonts.
The ttf static fonts strictly follow the design of the sources, the stem of the letter are correctly on the x-height and baseline, diacritics correctly aligned etc. However in the otf the positions of the points can shift by 1 or 2 units.
Here's an image to illustrate the issue.

See #3481


docs: Move README translations to list

Makes the rendering a little longer but should be better for diffs

Thanks.


Demonstrate / Document Kerberos flow

If we can demonstrate a Kerberos authentication flow that is similar if not identical to the one used in the Kerberos auth plugin (https://github.com/irods/irods_auth_plugin_kerberos), we can archive that repository and point people to using this plugin.
The Kerberos PAM module most places use is called pam_krb5. Check out these resources:

https://www.oreilly.com/library/view/linux-security-cookbook/0596003919/ch04s17.html
https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/4/html/reference_guide/s1-kerberos-pam#s1-kerberos-pam
https://docs.oracle.com/cd/E53394_01/html/E54787/pam-32.html
https://linux.die.net/man/8/pam_krb5

If the auth flow can be successfully demonstrated, we need to document the process so that it can be reproduced by others, and add tests (perhaps just copy the tests from the Kerberos auth plugin repository?).

I found this tutorial: http://techpubs.spinlocksolutions.com/dklar/kerberos.html#intro
It was referenced in the "Additional references" of the official Kerberos documentation: http://web.mit.edu/kerberos/krb5-current/doc/admin/install.html
I was able to authenticate via iinit with pam_interactive and a PAM stack using pam_krb5. The short version is...

Set up Kerberos server and realm just like the tutorial says. I guess we don't need to worry about this part for documentation, but we will want to understand this for testing purposes. I think that the test hook for Kerberos plugin was based off this tutorial because the steps are uncanny...  https://github.com/irods/irods_auth_plugin_kerberos/blob/main/irods_consortium_continuous_integration_test_hook.py
Create an "unprivileged principal" for your user:

addprinc -policy user alan # This is going to prompt you for a password, this is the password you will use

Create a Linux user and lock the user account

useradd -s /bin/bash -m alan
# Give a different Linux password than the Kerberos password so you can be sure you're authenticating with Kerberos, not Linux
usermod -p apass alan

Modify the irods PAM stack to look like this:

# I took this from the tutorial's /etc/pam.d/common-auth example
auth    [success=2 default=ignore]      pam_krb5.so minimum_uid=1000
auth    [success=1 default=ignore]      pam_unix.so nullok_secure try_first_pass
auth    requisite                       pam_deny.so
auth    required                        pam_permit.so

Run iinit as the Linux user with pam_interactive as your auth scheme:

$ iinit # enter your Kerberos password
Password:

Try entering the Linux password instead of the Kerberos password and watch it fail.

Yep. I recognize those web pages. Good stuff.
So now that you've demonstrated success. What are we missing? Documentation? Tests? Or maybe that's unnecessary / out-of-scope because it's PAM?

Right, I think we should at least put the steps in the README like we did for the pam_password example. I think this demonstration is enough for this plugin to act as a drop-in replacement for the Kerberos plugin which was not released for 4.3.
It may behoove us to actually put these PAM stack files in the repository in addition to the documentation under an examples directory or something, but I'm not sure how helpful that would be.
As for testing, I was originally thinking of putting a suite of tests for Kerberos in this repo, but I think I agree that it may be unnecessary / out-of-scope. Maybe we just resolve this issue by documenting the steps and we can do more later if there is community demand. Thoughts?

After some discussion, we decided that documentation is good enough.
Please open an issue for considering the addition of kerberos tests.

I created #46 for consideration of adding Kerberos testing.


Where are POST data? It dissappeared, but ... where and why?

We reverted some commits removing license incompatible code in #59. It will return in a different form when #41 is chopped up in different PR's and merged. For now you can target dev-streaming-multipart instead of dev-master until those changes are in.

WTF? :D :D

Read up on #41 and target dev-streaming-multipart for now, I'll ping you here when that PR is chopped up, in master, and tagged for release :smile: .

we use "react/http": "dev-master#cd15204bd15d106d7832c680e4fb0ca0ce2f5e30",

That also work's :+1:

Thanks for filing this ticket, I can assure you we're working hard on this :+1:
This ticket currently targets an unstable development branch, so I've just filed #105 to keep track of the underlying feature request here. Please bear with us, we'll keep this ticket updated :+1:


sproc, trigger and udf property definitions mismatch online docs

https://docs.microsoft.com/en-us/azure/documentdb/documentdb-programming
name (docs) --> id (SDK)
body (docs) --> serverScript (SDK)

@1N50MN14 could you please elaborate more what the issue is here?
@mimig1 @emilylawton could you please take a look.

@moderakh It's just a small mismatch between the online documentation and actual SDK API for sprocs and triggers

@1N50MN14 - It looks like you know how to use git - are you interested in submitting a pull request to the doc page to make the fix? Just go to the article page, click the Edit button in the upper right corner, click the Pencil button in the upper right, make your change and click Create Pull Request a few times. We'll get the PR, review it and accept it if it all looks good.

@mimig1 Sure thing, https://github.com/Microsoft/azure-docs/pull/697

Thank you @1N50MN14 for reporting this and your patch for fixing the documentation. As this is an issue in the documentation, I am closing it here, let's track this in the azure docs repo.


Fix generation mangling when model entity has current module selected for name

Summary of Changes
Remove the leading period from representedClassName when parsing NSEntityDescription as it signifies the user has selected the current module for scope. If this is left in the generated class names get mangled, but it is important for core data to have this information when going back and forth between a swift module and an ObjC module, such as happens when your model is in a swift framework.
Addresses
#339

This behavior has been incorporated into master in other ways.


Redis SBOM is missing

Which image/versions are related to this issue/feature request?
cgr.dev/chainguard/redis
Issue/Feature description
Trying to download the SBOM fails for Redis while it works for NGINX.
$ cosign download sbom  cgr.dev/chainguard/redis --platform linux/amd64
WARNING: Downloading SBOMs this way does not ensure its authenticity. If you want to ensure a tamper-proof SBOM, download it using 'cosign download attestation <image uri>' or verify its signature using 'cosign verify --key <key path> --attachment sbom <image uri>'.

This multiarch image does not have an SBOM attached at the index level.
Try using --platform with one of the following architectures:
linux/amd64, linux/arm64

Error: no SBOM found attached to image index
main.go:74: error during command execution: no SBOM found attached to image index

The SBOMs are published as attestations.  For example this is the SBOM for the latest redis image (as of now).
You should be able to use cosign download attestation (as the warning recommends) to get the signed SBOM.

Just to follow-up on this, if you're using the latest cosign from source (e.g. via go install), you can do:
$(go env GOPATH)/bin/cosign download attestation --platform=linux/amd64 --predicate-type=https://spdx.dev/Document cgr.dev/chainguard/redis | jq -r .payload | base64 -d`


Update StringResources.nl.xaml

Updated for version 2.28

That was fast! Thank you :)

That was a LOT of new strings too!
Stephan
Stephan Paternotte
Amsterdam
Nederland

E: @.***

From: Nicke Manarin @.>
Sent: Wednesday, April 21, 2021 7:27:01 PM
To: NickeManarin/ScreenToGif @.>
Cc: Stephan Paternotte @.>; Author @.>
Subject: Re: [NickeManarin/ScreenToGif] Update StringResources.nl.xaml (#834)
That was fast! Thank you :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NickeManarin/ScreenToGif/pull/834#issuecomment-824231527, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACMLQF7OV76DT2YZ73QP673TJ4DGLANCNFSM43KU3ABA.


Update dsc-overview.md

removing unused PowerShell variable $location

@felickz : Thanks for your contribution! The author, @bobbytreed, has been notified to review your proposed change.

Close/reopen for fresh validation post-migration.

#sign-off

#sign-off

@georgewallace: I'm sorry - only the author of this article, @bobbytreed, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Network refactoring

Refactoring the network part. Maybe I got too carried away, so this PR is debatable.
So:

Added a timeout on the connection and write buffering (through the Base.buffer_writes)
Added the ability to partially read / write packets depending on the server revision
ClickHouseSock now stores the information required for connection and can be reconnected using connect!(sock; force = false)
Removed the dirty status. Instead, the socket now has 2 statuses- busy (doing some work) and connected (socket.io != nothing)
Added a ReentrantLock to the socket (cond field). Added function guarded(f, sock) and macro @guarded(sock, expr) for thread-safe access to socket
Added using_socket(f, sock) function and @using_socket(sock, expr) macro. The logic of it operation is as follows: if the socket is not connected or busy, an exception is thrown. The socket is set to busy status and a function or expression is executed, after which the busy status is removed. If an exception occurs during execution, the busy status is also removed. If the exception is not a ClickHouseServerException, the socket is also disconnected
Removed the inclusion of transport structures in business structures - now ClickHouseSocket does not contain the ClientInfo structure, ClickHouseServerException does not contain ServerExceptions. Motivation-reducing the dependence of business logic on a specific type of transport packets
Now when writing the string length, sizeof is used instead of length, which allows us to work correctly with Unicode

Please note there are 4 unaddressed items that GitHub hides in my review above. It's a bit confusing because you'd think that it'd only hide resolved items, however that isn't the case -- it hides anything above 10 comments.


Add OpenGOAL languages

Adds language IDs and icons for the languages used by the OpenGOAL VS Code extension.

Hi, thanks for your contribution, but the icon does not meet the requirements for adding a new language.
Please read > ADDING_LANGUAGE.md#adding-a-new-language-icon


Add couchdb clustering

This pr is to deploy couchdb cluster.
From the version 2.0, CouchDB officially supports clustering.
Notable changes are as follow:
Image of CouchDB is changed to the one from Apache.
klaemo/couchdb is superseded by apache/couchdb.
Accordingly version is also updated to 2.1
Coordinator node.
Since we need one coordinator node to setup CouchDB cluster, first host in db group becomes coordinator node.
New environment variables for cluster.
Important factors for CouchDB cluster are the number of shards and the number of quorums.
Corresponding environment variables are introduced.
Note: Please be informed that, current version of apache/couchdb:2.1 does not support these values, so I created a pull request for this.
Once this pr is merged, those environment variables will be available.
https://github.com/apache/couchdb-docker/pull/32
This pr also can address the problem reported by this issue: #2808

Any more thing to do for this pr?

@style95 as you shared on slack, the use of db_num_read_quorum and db_num_write_quorum I think is discouraged. Can you link the ansible related issue here and is there an update?

@rabbah Let me explain the issues here.
In this pr, apache/couchdb is being used.
That image does not support environment variables for n, q, r, w, and that's the reason why I initially created this PR(apache/couchdb-docker#32).
And I got comment from couchdb community that,

n will be automatically configured while setting up clustering.
q only matters when creating database and can be specified ?q=1 parameter.
Explicit r and w configurations are deprecated, instead couchdb will use half of the number of replicas for those two values.
(These can also be specified parameter)
After setting up clustering, cluster configurations will be stored in /opt/couchdb/etc/local.d, so couchdb community highly recommend to use volume mapping of that directory.

In short, we don't need any those configurations.
Instead, we need to add q param when creating a database.
I will update the code accordingly.
One question is, would it be required to add volume mapping for configuration directory as well?
For this, we need to keep configuration directory and files in OW repo such as etc/default.ini etc/default.d/*.ini etc/local.d because there will be no default configuration when volume is mapped.

@rabbah
Code is updated accordingly.
Regarding q value, default is 8.
I think it would be a good starting point, how do you think?

It seems Travis error is not related with this pr.
Could anyone trigger Travis build again?

@cbickel any comments on this?

This is a great Pull request.
The only thing, that should be there (if it is technically possible) is, that we should have the ability to deploy two instances on the same machine. With this feature, testing would be much easier. We have it for the controllers and invokers as well.
And I have an additional question. Is the intention of this PR only, to share data across multiple instances? Wouldn't it be great, if the requests against the database would be distributed across the instances? Or do you have in mind to do this later?

Agree. It would be great if we can deploy more than one instances on a single machine for testability.
Regarding the data sharing across multiple instances, do we need any further configurations to distribute data?
AFAIK, from CouchDB 2.0, the number of nodes who are in charge of specific shards will be decided based on n(normally recommended value is 3).
For example, if we have 5 nodes, and n is 3, and let's say node 1,2,3 are in charge of some data, and if client sent request to node 4, it will automatically redirect the request to one of node 1,2,3 and they will handle the requests properly.
Based on the value of w, r, it will respond to the clients.
So no matter who receives the request, client will get proper response.
Did I understand your question correctly?
If I misunderstood about couchdb, please rectify me.
If you are mentioning about load-balancing(using single endpoint address) among multi nodes for HA, currently i have no idea. We may locate load-balancer in front of them or, other components to use list of endpoints.

Ok, I didn't know yet, that if you send a request to instance 1, that it could be handled by instance2.
I think for HA we need one of your proposed ideas. I just wanted to ask, if you want to address that problem already in this PR, or maybe later.
But for this PR I'm totally fine without loadbalancing to the different nodes.

Yes I think it would be better to address load-balancing problem in separate pr.
Regarding epmd port, 4369, initially I thought we can change the port using ERL_EPMD_PORT: http://erlang.org/doc/man/epmd.html.
But for example, if we configure the port as 4369 on first node and 4370 for second node, first node will try to find other node using 4369 port but on second node, only 4370 is opened, so look-up will fail.
I am looking for the configuration to segregate its binding port(4369) and communication port(4370). But I am not sure it is feasible.

It seems, all Erlang nodes must use same epmd port.
https://stackoverflow.com/questions/40189097/erlang-epmd-connects-to-other-host-with-non-default-epmd-port
It means, we cannot run a couchdb cluster on a single machine.
As of now I am trying the following scenario.

use same epmd port(4369) for all couchdb nodes.
do not map that port to host (remove -p 4369:4369).
trying to form a cluster.

Since both nodes will be running on a single machine, they will be in the same subnet.
They might be able to communicate with each other using their container IPs.
So though port is not opened in host layer, they may be able to connect to other node using <IP_ADDRESS>:4369.
For this, when we deploy couchdb, we need to specify its container IPs.
(currently, we are specifying host IP).
Since it assumes nodes are running on same subnet, it won't work on distributed environments.
So we need to differentiate local deployment with distributed deployment.
Is it worth to take this approach?

Let me share the discussion with @cbickel.
It would be better for us to have test cases for HA or failover of CouchDB.
But it's not that simple and seems to require many dirty changes to run multiple couchdb on a single machine.
So it could be an option that running a test case in case there are more than 1 couchdb deployed(in distributed environment).
Same approach is already taken for controllers.
I will look into ShootComponentsTests.scala and apply similar way for couchdb as well.

One idea for one of the tests could be:

Write documents to the first DB
Shoot the first DB
Check that the documents are available (maybe also some view results) on the second db
Write some documents to second DB
Start first DB again and wait until the first DB is up again
Check that the new documents are replicated back to the first database

Do you have some more ideas?

@style95 What would be consistency support in clustered setup. Would it be possible to read-your-own-writes?
Reading here indicates that for reads and writes it would use quorum which should allow one to read its own write

The number of copies of a document with the same revision that have to be read before CouchDB returns with a 200 is equal to a half of total copies of the document plus one. It is the same for the number of nodes that need to save a document before a write is returned with 201

However its not clear what is the semantics for queries or view access. Per here it looks like queries would not be using quorum

The coordinator waits for a given number of responses to arrive from the nodes it contacted. The number of responses it waits for differ based on the type of request. Reads and writes wait for two responses. A view read only waits for one.

So in clustered setup it can happen that an action added in one step is not visible in query made in subsequent request?

Correct: views are subject to eventual consistency and may exclude a just added/modified action (for example) until all nodes have replicated and indexed.

Thanks @rabbah  for confirming the eventual consistent nature for queries.
Next question - Does Couchdb supports specifying the sharding key? Or it always shards on the basis of _id key only. In absence of sharding key all queries would need to query all shards which may have some impact on performance

@chetanmeh
AFAIK, there is no support to specify the custom sharding key.
What kinds of performance increment do you expect with custom sharding key?
If we do view query, we should access all relevant shards to create a combined result.
That's the reason why, it is generally recommended to have small q value for read-intensive DB and large value for write-intensive DB.
If I misunderstood, kindly correct me.

What kinds of performance increment do you expect with custom sharding key?

I am exploring support for running OW on Mongo and Cosomosdb which support specifying custom partition key. Looking at views used by Couchdb I see following types of queries

Activations

byDateWithLogs - [doc.start]
cleanUpActivations - [doc.start]
activations - [doc.namespace, doc.start]

Whisks

[root namespace, date] - For each of rules, packages, actions, triggers

From my understanding of flow the "whisks" are mostly read. In a sharded setup this may benefit by using "root namespace" as sharding (partition key). In such a case the query would only need to be evaluated on single shard and avoid hitting all the shards for the whisks access.
This would be specially useful for databases where sharded queries are done from client which may add higher latency. Compared to this Couchdb proxies the queries and talks to all the shards on behalf of client. As such calls happen within same data center they may incur less latency.
So I am interested in this PR to see how to model OW entities on other sharded storage systems

So you are thinking of assigning a shard per namespace, right?
Great idea. It would be great for small scale and latency.
But if there are huge number of data, one shard may not be enough.
Since shard is a unit of distribution and replication, too big shard is not good for performance.
As data grows, at some scale we need to rebalance shards but if we use namespace as a partition key, how can we rebalance the shards into small shards?
And accessing to shards are proceeded in parallel.
Generally recommended value for n is 3 as so, w and r will be 2.
That means the number of shards to access is 2.
Though we decrease the access time to 1, there might not be huge latency improvement.
And in my experience, storing activation has more huge impact on performance than reading whisk entity because there is cache layer in controller.

But if there are huge number of data, one shard may not be enough.
Since shard is a unit of distribution and replication, too big shard is not good for performance.
As data grows, at some scale we need to rebalance shards but if we use namespace as a partition key, how can we rebalance the shards into small shards?

Ack. But it depends on kind of data being stored. This scheme may be ok for whisks where one namespace may contain say 1M entities (which can be stored in single shard). This may not work fine for activations where number of activations may of the order of 10-100M. So use of sharding key would depend on type of objects being stored

And accessing to shards are proceeded in parallel.
Generally recommended value for n is 3 as so, w and r will be 2.
That means the number of shards to access is 2.
Though we decrease the access time to 1, there might not be huge latency improvement.

This is fine for read and write of single instance. However for queries all shards would need to be queried

The Query request handler must ask every node that hosts a replica of a shard in the database for their answer to the query. Depending on how the shard replicas are distributed across the cluster, this might be all nodes in the cluster, or only a subset.

And in my experience, storing activation has more huge impact on performance than reading whisk entity because there is cache layer in controller.

Is the cache layer used for queries also or its only used for individual entity access i.e. lookups by docId?

@chetanmeh
Yes. There might not be such huge number of data in one namespace.
But what if data grows by any possibility, how can we handle that?
And if there are not much data, do you expect it will cause any trouble in terms of performance with such small size of data?
Second, query is only used to list entities.
All other APIs, such as get/update/delete and even invoke an action uses normal document get/put api.(surely they can take advantage of cache.)
And I can't expect such huge number of list API calls.
As you mentioned, your approach can improve latency of list API.
But normally list API is called by user rather than any systematic call because list is to see what kinds of entities are there. So there may not be 10K or 100K TPS calls.
That's the reason why I think action invocation(which includes storing activations) will affect more on the performance and incline to scalable approach.

But normally list API is called by user rather than any systematic call because list is to see what kinds of entities are there. So there may not be 10K or 100K TPS calls.
That's the reason why I think action invocation(which includes storing activations) will affect more on the performance and incline to scalable approach.

Makes sense. Would keep that in mind when modeling for other dbs

And, I could not find any support for custom partition key.

Thanks for confirming. So for couchdb the partition key decision is moot!

The queries (list operations) are not cached today. They could be since we allow stale results and queue indexing operations in couch as configured. In general as already noted the bulk of the load isn’t on crud or query operations.

I have tested this pr is working with a couchdb cluster and a single couchdb setup.

Travis complains there is no db_local.ini, is it because of this PR?


Document recovery-rate and decay-rate attributes

I've seen this image here that was quite confusing.

@calcastor in https://github.com/PGMDev/PGM/pull/915 done a fix to this, documentation will prefer recovery-rate and decay-rate over recovery and decay.

https://github.com/PGMDev/PGM/pull/864/files

Documented in 09f4645.


Revised scoring mechanism based on registration of tests pre-test execution

This PR implements a revised scoring mechanism that requires tests to be registered before test execution. This will allow QuickFeed to become aware of all tests to be expected, avoiding the problem that some tests may be lost due to a panic or other failures that prevent tests from emitting their results. Tests that panic are not acceptable, and so students must fix such panics to get scores for tests that may follow a panicking test.
Resolves #283, resolves #27, resolves #374, resolves #433.

When reviewing this PR, please consider the examples in kit/score/testdata/sequence and other test cases within the score package itself.
The new API is mainly documented in doc.go, score.go and registry.go. The new API is slightly less convenient, in that:

a test must now be registered in either TestMain() or an init() function, and
that TestMain() must call score.PrintTestInfo() before executing the tests.

However, the benefit is that this new API should eliminate the problems related to panicking student code that causes some tests to not appear in the frontend, showing incorrect score results, because their JSON string is never emitted to stdout. Furthermore, obtaining a score object from within a test is easier.
The design of the API is based on the notion that

All test names in one test process execution are unique; that is, you cannot reuse the same test names across packages being tested from one test execution.
This is because there is a single registry of tests per execution of go test -v ./...

An alternative design was considered, where one would allow multiple registries, but this was deemed to add complexity for no good reason. However, I'm willing to discuss this, if anyone can show its merits.

When reviewing this PR, please consider the examples in kit/score/testdata/sequence and other test cases within the score package itself.
The new API is mainly documented in doc.go, score.go and registry.go. The new API is slightly less convenient, in that:

a test must now be registered in either TestMain() or an init() function, and
that TestMain() must call score.PrintTestInfo() before executing the tests.

However, the benefit is that this new API should eliminate the problems related to panicking student code that causes some tests to not appear in the frontend, showing incorrect score results, because their JSON string is never emitted to stdout. Furthermore, obtaining a score object from within a test is easier.
The design of the API is based on the notion that

All test names in one test process execution are unique; that is, you cannot reuse the same test names across packages being tested from one test execution.
This is because there is a single registry of tests per execution of go test -v ./...

An alternative design was considered, where one would allow multiple registries, but this was deemed to add complexity for no good reason. However, I'm willing to discuss this, if anyone can show its merits.

I've discovered a problem with the current design that has me rethinking the decision to use a single registry. Can others spot the problem too?

I've discovered a problem with the current design that has me rethinking the decision to use a single registry. Can others spot the problem too?

Have implemented a fix that should prevent non-test code from looking up the score object. This should fix my concern.

Have implemented a fix that should prevent non-test code from looking up the score object. This should fix my concern.

The only thing which is not quite working on the existing database is that the Members tab is empty for all courses, the reason is ERROR   web/autograder_service.go:347   GetEnrollmentsByCourse failed: submission missing build information, which is probably expected?
The rest seems to work just fine.

Note that I’m working on a grpc-based score service that I originally started this pr for. Still not pushed because it involves some more integration. So I’m holding off merging this pr for a few more days…

Note that I’m working on a grpc-based score service that I originally started this pr for. Still not pushed because it involves some more integration. So I’m holding off merging this pr for a few more days…

I'm starting working on converting json string based reviews/benchmarks to database entries and would rather work with the already updated database schema, do you think it is ok to base it off of this PR?

Yeah, that’s probably the best solution, since this already lays much of the ground work.


Documentation error under  "Get Started/Setup your Office 365 Developer Tenant/Setup document library/Create the new column"

The section titled "Create the new column" currently reads:
Follow the steps below to add the new field to the Documents library:
Click the gears icon on the top right and the click on Site settings to open the settings page.
Click on Site libraries and lists under the Site Administration category.
Click on Customize Documents
Now, click on Create column under Columns:
    Type ClientSideApplicationId as the column name and leave other fields as they are.
    Click OK button to create the column.

I believe it should read:
Click the gears icon on the top right and click on Site Contents.
Click the three dot icon next to the Document library you have created/chosen.
Choose Settings.
Now, click on Create column under Columns:
Type ClientSideApplicationId as the column name and leave other fields as they are.
Click OK button to create the column.

Actually both routes end on the same page. You can access Documents library settings also from site libraries and lists. It's matter of an opinion.

I don't have Site libraries and lists under the Site Administration category in my tenant.  It seems to me alternate instructions would be helpful for others in the same situaton.


Remove non-standard test_filter_<model_name>, test_forms_<model_name> and test_models_<model_name>

Environment

cookiecutter-nautobot-app version:  nautobot-app-2.3.2

Proposed Functionality
Remove the non-standard test_filter_{{ cookiecutter.model_class_name | lower }}.py, test_forms_{{ cookiecutter.model_class_name | lower }}.py and test_models_{{ cookiecutter.model_class_name | lower }}.py.
Replace these with the appropriate test_filters.py, test_forms.py and test_models.py

Use Case
Baked cookies follow our standards.

We should be on the lookout as to how Drift Manager handles this.


Duplicates

Write a program to remove duplicate elements from the array by accepting the values from the user.
Output:
Enter the no of elements in arr : 6
Enter the elements : 12 13 14 13 56 34
Arr after removing duplicate elements : 12 13 14 56 34

I would like to work on this.
Ahana Girish Agashe
SY COMP

@Tanishaclippy I would like to work on this issue.
Piyusha Ghodake.


Update README.md, additional backslash needed

JSHint will complain about ".jpg$", because JS will see that string as .jpg$, not .jpg$

test: "\.jpg$" should be test: /\.jpg$/ instead


Checksum fails for servicefabric_sdkcommon_1.4.2.deb

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I'm using Foreman/Katello to synchronize Microsoft packages within my organization. When syncing the repo for Ubuntu Bionic, I get this error:
A file located at the url https://packages.microsoft.com/ubuntu/18.04/prod/pool/main/s/servicefabricsdkcommon/servicefabric_sdkcommon_1.4.2.deb failed validation due to checksum.
Could you please check this repository for us?
Thanks in advance!
Expected behavior
A clean sync

Actual behavior
A failed sync due to checksum errors

Error details
`A file located at the url https://packages.microsoft.com/ubuntu/18.04/prod/pool/main/s/servicefabricsdkcommon/servicefabric_sdkcommon_1.4.2.deb failed validation due to checksum.`

Environment data
Not applicable

Visuals
No response

We do not own the package servicefabric_sdkcommon_1.4.2.deb. Resolving as external


shadow: fix collision with coreutils (man groups.1.gz)

The groups.1.gz collides with one from coreutils. The code to fix this
was already present in expression, but wrongly assumes that share/man/man1
directory will be copied to man output after installPhase.
It turned out, that man directory is set to man output at configure step, so we should
remove file from man output.

Works for me. Thank you


Feature Request: Guide for Buy Me a Coffee Experience

Describe the solution you'd like
We need to populate the Guide section of the Buy Me a Coffee experience page. Here are some requirements:

Use Figma as UI guide
Use the CodeBlock component
Implement three sections: overall goal, how the contract works and the main operations, and lastly how we interact with the contract on the frontend.

Describe alternatives you've considered.
No response

@arsood I can pick this one up

@arsood I can pick this one up

@kyhyco great, thanks! Looking forward to it.


added the cleanup section

Issue #, if available:
Description of changes:
m4_nb3_Inference_pipeline_lookup
and
m4_nb2_Inference_pipeline_lookup
added a clean up section.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

thank you for your contribution @RominaUQ !


New release to Maven?

@lviggiano It looks like there have been quite a few updates since the last release to Maven.  Do you have any plans to put out another official release?
For some background, I'm at The Broad Institute and we're considering using OWNER as the config library for one of our projects - the Genome Analysis Toolkit (GATK).  It looks really slick and seems to be able to do everything we'd need it to do.
Thanks a lot!

Hi.
I have some problems here:

new pull requests are missing documentation and some of them are not fully tested, but they should be ok, since all previous tests are fine. So having new undocumented feature, is not useful from my point of view, since only few people would discover and use them.
my health is not very good since some time and I have been away from coding since more than one year now. This I hope will be fixed, but I can't say when.
maven release process on SonaType, last time I did, was quite a hell and frequently failing. It's long time since my last release, so probably I should learn again how to release on SonaType. Hoping that this has been simplified and improved.
at the moment I am unemployed, so when I'll start coding again, possibly I should focus on some commercial project to have some sustaining source, and OWNER would not be my second choice for spending my coding time.

I am very sorry to say that, since this little project was very fun, but I may need to handover the codebase to some qualified volunteer to keep it living.

Hi @lviggiano - sorry to hear that you've been ill.
If releasing to maven is an issue maybe my team can help get it ready and pushed out (I'm not sure we can commit to taking over the codebase, though).  Would that be helpful?
Thanks again.

Hi @lviggiano There have been some new features added to the Owner API since the last release. Do you have any plans to release a new version anytime soon?

Sorry for the long wait.
Yesterday I managed to review the Maven releasing process, which was quite messy before, and today I wrote the v1.0.10 release notes here http://owner.aeonbits.org/news/2018/03/01/owner-1-0-10-released
Thanks for the patience.

Thank You.

Great!
Thanks a lot!

It was a long wait :) sorry guys


Replace all stdout prints with surge_println! which has the surge prompt

Or perhaps "overwrite" write! so that termimage can absorb the effect.

Without termimage this is no longer a problem.


Can't delete namespace; Possible cause is a ThirdPartyResource

Issue Report Template
Tectonic Version
1.5.1
Environment
What hardware/cloud provider/hypervisor is being used with Tectonic? AWS
Expected Behavior
When I delete a namespace, namespace will delete after some short period of time (maximum 3 minutes).
Actual Behavior
Resources in namespace are terminated (including an AWS loadbalancer). Namespace never deletes.
Reproduction Steps

Create 1.5.1 cluster, no operators
Create a sample application in its own namespace.

---
kind: Namespace
apiVersion: v1
metadata:
  name: applications
  labels:
    name: application-namespace
---
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: mydeployment
  namespace: applications
  labels:
    app: mydeployment
spec:
  replicas: 2
  template:
    metadata:
      labels:
        app: mydeployment
    spec:
      containers:
      - name: mydeployment
        image: brndnmtthws/nginx-echo-headers:latest
        ports:
        - name: my-http
          containerPort: 8080
          # hostPort will be a high level port
---
apiVersion: v1
kind: Service
metadata:
  name: mydeployment
  namespace: applications
  labels:
    app: mydeployment
spec:
  type: NodePort
  ports:
  - name: first-thing
    targetPort: my-http
    port: 7777
  selector:
    app: mydeployment

Delete the namespace
(Optional) Try and create the namespace again

Other Information
I have written a script to find ThirdPartyResources. Although I couldn't find any in the namespace I am trying to delete, I think it ThirdPartyResources may still be at fault.
Logs when service is created after deletion:
$ kubectl apply -f manifests/echoheaders-lb.yaml
namespace "applications" configured
Error from server (Forbidden): error when creating "manifests/echoheaders-lb.yaml": deployments.extensions "mydeployment" is forbidden: unable to create new content in namespace applications because it is being terminated.
Error from server (Forbidden): error when creating "manifests/echoheaders-lb.yaml": services "mydeployment" is forbidden: unable to create new content in namespace applications because it is being terminated.

Logs from API server:
E0215 19:01:02.356551       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:02.448434       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:03.147809       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:03.949282       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:04.747130       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:05.546798       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:06.357159       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:07.147471       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:07.946490       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:09.311655       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:11.957162       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:17.170309       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:27.492949       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:01:48.055772       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:02:29.105411       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:03:51.109742       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:04:34.096172       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:09:34.103264       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:14:34.093126       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:19:34.098490       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:24:34.101126       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:29:34.100087       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
W0215 19:31:38.269630       6 listers.go:69] can not retrieve list of objects using index : Index with name namespace does not exist
E0215 19:34:34.100316       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:39:34.100515       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"
E0215 19:44:34.102075       6 errors.go:63] apiserver received an error that is not an unversioned.Status: no kind "DeleteOptions" is registered for version "oidc.coreos.com/v1"

I have included most of the logs to the change in timestamp

Hey @jgensler8, thanks for filing this issue. I'll let @ivancherepov take it from here; he should be able to get back to you within a few days and will pull in any other members of our team as needed.

How did you delete the namespace - from UI or CLI? It's safer option to use kubectl delete.
Can you please provide the outcome of
kubectl get pods,deployments,svc,configmaps,secrets,ing --namespace applications -o wide --show-labels?
From looking at similar k8s issues #19317 and #37278, it looks like this issue has been fixed in 1.5.2.

@IvanCherepov looks like the upgrade from 1.5.1 to 1.5.2 has fixed this issue. We've replaced the old cluster because the UI was experiencing issues as well.
Thank you both for the help!


Error: Unsupported Terraform Core version

terraform 1.4 was released this morning:
❯ terraform init

Initializing the backend...
╷
│ Error: Unsupported Terraform Core version
│
│   on aws.tf line 2, in terraform:
│    2:   required_version = "~> 1.3.0"
│
│ This configuration does not support Terraform version 1.4.0. To proceed, either choose another supported Terraform version or update this version
│ constraint. Version constraints are normally set for good reason, so updating the constraint may lead to other errors or unexpected behavior.
╵

change committed to allow this - will transition to 1.4 fully after we get a point release or two

https://github.com/aws-samples/aws2tf/commit/074d3abf6e1dc42cf3acc0f7f2338dd16f3c7da9


Key definition with key reference

Expected Behavior

If we have a keydef element with a keyref to another key, the first key should pull resources from the second.
<keydef keys="product" keyref="product_aux">
  <topicmeta>
    <keywords>
      <keyword>product1</keyword>
    </keywords>
  </topicmeta>
</keydef>
<keydef keys="product_aux">
  <topicmeta>
    <keywords>
      <keyword>product_aux</keyword>
    </keywords>
  </topicmeta>
</keydef>

According to DITA Specification, if a resource is already present in the first key, it won't be pulled from the second. If the initial keydef has a topicmeta element containing a keyword and the second one has a topicmeta with a keyword as well, the first keydef should keep the first keyword.
Actual Behavior

The keyword element of the first keydef is replaced by the second keyword. Equivalent to
<keydef keys="product">
  <topicmeta>
    <keywords>
      <keyword>product_aux</keyword>
    </keywords>
  </topicmeta>
</keydef>

Steps to Reproduce

Download the following testcase: keydef-with-keyref.zip

Publish main_map.ditamap to PDF

Open the PDF. Chapter1 contains the word product_aux, but the first keydef already contains a topicmeta element with the keyword product1 which should be displayed instead

Environment

DITA-OT version: DITA-OT version:4.1
Operating system and version:
(macOS Big Sur Version 11.6)
How did you run DITA-OT?
(oXygen)
Transformation type:
(PDF)

This might be the same or similar to #4098.


Keep releases lean

Keeps unnecessary artifacts out of Composer package releases.

Thanks :+1:  The root files are actually never part of release
The file you're editing should be in: https://github.com/TomasVotruba/phpstan-bodyscan/tree/main/build/target-repository


Too old Homeassistent Version for newest Pyloxone

Describe the bug
From 10 days ago, my integration is failed... not sure if its because an update of the miniserver or the PyLoxone or the ha
Im pasting the log file
home-assistant_2024-11-26T22-08-08.620Z.log
Firmware of your Miniserver
<IP_ADDRESS>
HomeAssistant install method
Raspberry py via proxmox
Version of HomeAssistant
2024.9.1
Version of Pyloxone
0.7.1
Update pyloxone
Yes
Log
Settings for the log can be found on the main page under the section Log Configuration
home-assistant_2024-11-26T22-08-08.620Z.log

@jlmadrugac the newest pyloxone works only with the newest Homeassistent version.

@jlmadrugac any success?

Yes, I had problems with the update to the latest version of Homeassistant, but was related to the free space.
With the new version all works perfect.
Thanks!


Building yara inside bazel project

Hi, I have a project where I want to use the yara library but im having trouble building it.
This is how I have my project set up:
WORKSPACE file
...
git_repository(
    name = "com_github_virustotal_yara",
    remote = "https://github.com/VirusTotal/yara",
    commit = "d1ff3ecc465d7ed882943fd1278dd8981b704f02", # v4.3.2
)

load("@com_github_virustotal_yara//:bazel/yara_deps.bzl", "yara_deps")
yara_deps()
...

BUILD file
...
load("@com_github_virustotal_yara//:bazel/yara.bzl", "yara_library")
yara_library(
    name = "libyara",
    crypto_libs = ["@openssl//:crypto"],
    includes = ["@com_github_virustotal_yara//:libyara/include"],
    modules = [
        "hash",
        "macho",
        "tests",
        "string",
    ],
    modules_srcs = [
        "@com_github_virustotal_yara//:libyara/modules/hash/hash.c",
        "@com_github_virustotal_yara//:libyara/modules/macho/macho.c",
        "@com_github_virustotal_yara//:libyara/modules/tests/tests.c",
        "@com_github_virustotal_yara//:libyara/modules/string/string.c",
    ],
)
...

The problem comes when I try to build the libyara dependency and I get the errors shown below which indicate some problems with the visibility of the files. Is it possible to do this? Or is the current bazel config in yara only meant to be used to build the standalone yara lib. (Im a bazel noob so I apologize if Im not understanding something).
ERROR: /Users/santalvarez/Documents/mhunt/Sources/Agent/BUILD:30:13: in cc_library rule //Sources/Agent:libyara: target '@com_github_virustotal_yara//:libyara/modules/hash/hash.c' is not visible from target '//Sources/Agent:libyara'. Check the visibility declaration of the former target if you think the dependency is legitimate. To set the visibility of that source file target, use the exports_files() function
ERROR: /Users/santalvarez/Documents/mhunt/Sources/Agent/BUILD:30:13: in cc_library rule //Sources/Agent:libyara: target '@com_github_virustotal_yara//:libyara/modules/macho/macho.c' is not visible from target '//Sources/Agent:libyara'. Check the visibility declaration of the former target if you think the dependency is legitimate. To set the visibility of that source file target, use the exports_files() function
ERROR: /Users/santalvarez/Documents/mhunt/Sources/Agent/BUILD:30:13: in cc_library rule //Sources/Agent:libyara: target '@com_github_virustotal_yara//:libyara/modules/tests/tests.c' is not visible from target '//Sources/Agent:libyara'. Check the visibility declaration of the former target if you think the dependency is legitimate. To set the visibility of that source file target, use the exports_files() function
ERROR: /Users/santalvarez/Documents/mhunt/Sources/Agent/BUILD:30:13: in cc_library rule //Sources/Agent:libyara: target '@com_github_virustotal_yara//:libyara/modules/string/string.c' is not visible from target '//Sources/Agent:libyara'. Check the visibility declaration of the former target if you think the dependency is legitimate. To set the visibility of that source file target, use the exports_files() function

This is an example BUILD file that we use ourselves in VirusTotal, the only difference with yours is the absense of the  @com_github_virustotal_yara//: prefix in module source paths. So, you may try that.
load("@com_github_virustotal_yara//:bazel/yara.bzl", "yara_library")

yara_library(
    name = "libyara",
    modules = [
        # Standard open-source modules.
        "cuckoo",
        "elf",
        "hash",
        "magic",
        "math",
        "pe",
        "tests",
        "time",
        "dotnet",
    ],
    modules_srcs = [
        "libyara/modules/cuckoo/cuckoo.c",
        "libyara/modules/elf/elf.c",
        "libyara/modules/hash/hash.c",
        "libyara/modules/magic/magic.c",
        "libyara/modules/math/math.c",
        "libyara/modules/pe/pe.c",
        "libyara/modules/pe/pe_utils.c",
        "libyara/modules/tests/tests.c",
        "libyara/modules/time/time.c",
        "libyara/modules/dotnet/dotnet.c",
    ],
    deps = [
        "@jansson//:jansson",
        "@magic//:magic",
    ]
)

That works! Thanks


[SPARK-50441][SQL] Fix parametrized identifiers not working when referencing CTEs

What changes were proposed in this pull request?
Fix parametrized identifiers not working when referencing CTEs

Why are the changes needed?
For a query:
with t1 as (select 1) select * from identifier(:cte) using cte as "t1"
the resolution fails because BindParameters can't resolve parameters because it waits for ResolveIdentifierClause to resolve UnresolvedWithCTERelation, but ResolveIdentifierClause can't resolve UnresolvedWithCTERelation until all NamedParameters in the plan are resolved.
Instead of delaying CTE resolution with UnresolvedWithCTERelation, we can remove node entirely and delay the resolution by keeping the original PlanWithUnresolvedIdentifier and moving the CTE resolution to its planBuilder.

Does this PR introduce any user-facing change?
No

How was this patch tested?
Added a new test to ParametersSuite

Was this patch authored or co-authored using generative AI tooling?
No

@cloud-fan Failures seem unrelated, same test is failing in other PRs as well

The streaming failure is unrelated, I'm merging it to master, thanks!


Issue Cloning Repo: Permission Denied

git clone git@github.com:Unity-Technologies/obstacle-tower-env.git
Cloning into 'obstacle-tower-env'...
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

can you try git clone https://github.com/Unity-Technologies/obstacle-tower-env.git?

Whurps. That was a silly mistake. Sorry! That worked.


Revert "Revert "Add symmetric int16 support to tflu softmax reference kernel""

Reverts tensorflow/tensorflow#43127
#43180 removes std:vector from the reference implementation of int16 softmax so we should be all set to use it from TFLM. The continuous integration coverage has been increased with #43160 so having that pass will give us higher confidence that things are good to go.

@freddan80 @sicong-li-arm @yair-ehrenwald, let's try this again.


[BUG] Map Will Not load - OSX

Ever since version 0.1.4 the map will not load on OSX. Map does load on version 0.1.3. Thanks for a great Application!

i've been using OS X since v 0.0.6, and still do on latest version.  its up right now.
using safari.
sometimes i have to alternate between a PTC & google login.

@swimboy46163 Can you provide the console logs or screenshots for this?

This happens to me. Console log-

Python: Traceback (most recent call last):
File "./runserver.py", line 22, in
from flask_cors import CORS
ImportError: No module named flask_cors

Also this:

main.html:158 server up: null
main.html:146 Error getting location, trying second provider PositionError {code: 2, message: "Network location provider at 'https://www.googleapis.com/' : Returned error code 403."}
main.html:148 Found location [,] by ipinfo.io

Note: Removed my coordinates from the console log.


Adds 2018 Honda Fit support

https://github.com/commaai/opendbc/pull/100

@energee once conflicts are merged, is this good to go?

@energee would love to merge this in if somebody can confirm it works

Still testing needed?

I think its close, there is a user who has it working and he may have a diff for this branch with some further changes.

Side note, how is this PR a year old?

Time flies 🤷♂

Note: Variable names in interface.py are changed between 0.5 and 0.6. So it would need refactoring before merging.
I'm currently working with a fit owner to see if this works. Will update if we could get this working on 0.6.2

Can we test this, @AravindaDP ?

@energee @rbiasini
Apologies to bumping you again. Fit owner confirmed that this works on 0.6.3 as well subject to suggested changes I have marked above.
So would love if this gets merged in after accepting suggested changes. Let me know if any additional details are required.

@energee @rbiasini
Here is the cabana drive provided by fit user for this
https://my.comma.ai/cabana/?route=99e3eaed7396619e|2019-08-13--15-07-03&max=0&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F99e3eaed7396619e%2Fced4327cf0038699b7d1cbe59e5f8843_2019-08-13--15-07-03

@vanillagorillaa ^

Can we verify tire stiffness value on some turns? probably needs some adjustment

@energee Yes that variable needs more attention probably.
What indications we should be looking for on turns? Low torque compared to stock on curves? overshooting or any other indications?
I guess there was some tuning doc earlier on openpilot community site but I can no longer find it
Thanks for your time


Update cboden/ratchet since it's current dependency guzzle/http is abandoned

Should be updated since the version used now uses abandoned guzzle/http. Latest cboden/ratchet does not have that issue.

Thanks for this
I'll update all libs this week

Updated @ArtemGoutsoul
I'll close a patch now.
Thanks for this


Country Code :

Bonjour,
Pour des serveurs Europe ou France il faut choisir lequel en option ?
Hello,
For Europe or France servers, which one must be chosen as an option?

That depends on what server you have your devices on. If you do not know, then you can check that in the homebridge ui, use the "Discover" button on the plugin preferences and it will show you on what server your devices are located.

J’ai configuré mes ventilateur et autre sur les serveur européen.

I configured my fans and others on the European servers.

I suppose the European servers are "de"

Je vous remercie.
J’ai remarqué un comportement anormal du plugin pour mes ventilateur.
Je m’explique, si mon ventilateur est éteins et que j’active la veille celle-ci s’active et se désactive de suite. Sauf que, quand j’active ensuite le ventilateur la veille se réactive de nouveau. Cela est désagréable car j’ai une règle qui active la veille du ventilateur de mon fils pour l’été et sauf que quand la journée il activé le ventilateur et bien il s’éteint tout seul car la minuterie est resté en mémoire. Il faudrait quelle soit restable.
Thank you.
I noticed an abnormal behavior of the plugin for my fans.
Let me explain, if my fan is off and I activate the day before, it activates and deactivates immediately.  Except that when I then turn on the fan the standby comes back on again.  This is unpleasant because I have a rule that activates the standby of my son's fan for the summer and except that when the day he activates the fan and well it turns off on its own because the timer has remained in memory.  It should be stable.

Can you share what fan model are you using? I guess since you asked about micloud then you are using a micloud based fan. Unfortunately this might happen, depending on what moment you turn on the switch, this is due to the fact that the MiCloud has a slight delay which causes this. There is nothin really what can be done about it...

Since you already opened a new issue, I will be slowing this.


refactor(signal_processing): prefix package and namespace with autoware

Description
prefix package and namespace with autoware
Related links
Parent Issue:

https://github.com/autowarefoundation/autoware/issues/4569

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@SakodaShintaro I've submitted https://github.com/autowarefoundation/autoware_tools/pull/110, it should be merged after this PR is merged.

@esteve
Thank you for creating a pull request for autoware_tools.
Could you resolve the conflict in this pull request?

I'll rebase to main to test it with the latest autoware.


SuperPVxInfo & PlayerBasePvpZones: Implement TruePVE PVP delay API support

Nivex has published a TruePVE update incorporating my ideas for efficient cross-plugin PVP delay support.
SuperPVxInfo should be updated to listen to these hooks as another input to its PVP Delay state tracking.
PlayerBasePvpZones should be updated to optionally use these hooks in lieu of its own damage handlers (which also means making subscription conditional for the latter).

Fixed in PBPZ 1.1.0 & SPI 1.4.0


quick.js has been used by sciter-js-sdk

Those tis based examples don't work in the new SDK.
Do you have any plans to adapt the new SDK?

i cat find a way to call the rust func in the javascript file..
i  am try interop example
const view = Window.this
view. calc_sum()

the console tell me method undefined.

How did you solve this?

How did you solve this?
at the rust side impl

impl sciter::EventHandler for EventHandler {
  fn get_subscription(&mut self) -> Option<sciter::dom::event::EVENT_GROUPS> {
    Some(sciter::dom::event::default_events() | sciter::dom::event::EVENT_GROUPS::HANDLE_METHOD_CALL)
}

at the view side:
const view = Window.this
view.xcall("sum",1, 2);

detail at here #96
and the sciter.js doc at here doc

default_events() should be adjusted to cover JS. Will do.

default_events() should be adjusted to cover JS. Will do.

that's great, thank's a lot!

Might be nice to release the version with the fix on crates.io :)


[Bug]: The view, procedure, and function buttons in the mysql data source cancel the export button

ODC version
ODC 4.2.2
OB version
mysql data source
What happened?

mysql mode not support export view/function/procedure,should cancel the button.
What did you expect to happen?
cancle the export button
How can we reproduce it (as minimally and precisely as possible)?
Click the three points of the view in the structure tree.
Anything else we need to know?
No response
Cloud
No response

works for me

passed


Mistaken ESM as CJS when using svelte

Describe the bug
Although npm run dev/build works perfectly, npm run test throws out an error:

SyntaxError: Named export 'parse' not found. The requested module 'css-what' is a CommonJS module, which may not support all module.exports as named exports.

After some investigation, the offending code (deep in my dependency chain) turns out to be:
import { parse } from "css-what"

It seems that somehow vitest incorrectly considers a perfect es module (css-what) as cjs, thus refusing to import it.

However, commenting out svelte in vite.config can make the error go away in vitest (and obviously breaks my code):
export default defineConfig({
  // plugins: [svelte()],
  test: { globals: true, environment: 'happy-dom' },
})

Dependency chain:
My code:
import { generateJSON } from '@tiptap/html'

@tiptap/html:
import { createHTMLDocument, parseHTML } from 'zeed-dom';

zeed-dom:
import { parse } from "css-what"

Reproduction
https://stackblitz.com/github/andy1li/vitest-bug-report
npm run dev to see that vite and svelte work fine:

The root page should display some json, indicating that the miminal code works.

npm run test to reproduce the error msg:

SyntaxError: Named export 'parse' not found. The requested module 'css-what' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:
import pkg from 'css-what';
const { parse } = pkg;

System Info
Stackblitz:
  System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.10 - /bin/yarn
    npm: 7.17.0 - /bin/npm
  npmPackages:
    vite: latest => 3.0.4
    vitest: latest => 0.20.3

Mac:
  System:
    OS: macOS 11.6.7
    CPU: (4) x64 Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
    Memory: 18.48 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.16.0 - ~/.nvm/versions/node/v16.16.0/bin/node
    npm: 8.11.0 - ~/.nvm/versions/node/v16.16.0/bin/npm
  Browsers:
    Chrome: 103.0.5060.134
    Firefox: 102.0.1
    Safari: 15.5
  npmPackages:
    vite: latest => 3.0.4
    vitest: latest => 0.20.3

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Duplicate of https://github.com/vitest-dev/vitest/issues/1753

It seems that somehow vitest incorrectly considers a perfect es module (css-what) as cjs, thus refusing to import it.

css-what is not a perfect ES module, by the way. It doesn't have correct exports field or module flag.

Thank you, @sheremet-va, for the prompt reply!
My bad. I presumed too much, because run dev works...
Would you kindly give me some suggestions about how to make it work with vitest?
Much obliged.

Would you kindly give me some suggestions about how to make it work with vitest?

Workaround is described in linked issue:

Setting deps.registerNodeLoader to false (to skip the new Node logic) allows the test to run again.

We might disable in in the future by default, seeing that ecosystem still is not ready for ESM.

Got it. Works now!
Thank you so much, @sheremet-va!

https://github.com/vitest-dev/vitest/pull/1751
Ah, three days ago...
Please do set the default as false. Thanks a lot! 😂

Closed as duplicate


Authentification vs authentication

Why is it called "authentification" instead of the most common form of "authentication" used in the industry?
https://verdaccio.org/docs/en/authentification

Because I am not a native English speaker and make mistakes most of the time regarding docs.
But can be updated if you wish, no problem, feel free to PR.

I will close this, nothing else from my side


Instagram not working

Checklist

[x] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.05.18 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
I think Instagram changed something in their code. Image Max URL and other sites dont work properly aswell. A week ago it worked flawlessly.
Verbose log
[debug] Command-line config: ['-F', 'https://www.instagram.com/reel/Cd2vkWQKuR0/', '--cookies-from-browser', 'firefox', '-vU']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d523] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-10-10.0.19044-SP0
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: ffmpeg -bsfs
[debug] exe versions: ffmpeg 2022-01-10-git-f37e66b393-essentials_build-www.gyan.dev (setts), ffprobe 2022-01-10-git-f37e66b393-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2021.10.08, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[Cookies] Extracting cookies from firefox
[debug] Extracting cookies from: "C:\Users\USER\AppData\Roaming\Mozilla\Firefox\Profiles\aup5iws6.default-release-1641574058189\cookies.sqlite"
[Cookies] Extracted 3206 cookies from firefox
[debug] Proxy map: {}
Latest version: 2022.05.18, Current version: 2022.05.18
yt-dlp is up to date (2022.05.18)
[debug] [Instagram] Extracting URL: https://www.instagram.com/reel/Cd2vkWQKuR0/
[Instagram] Cd2vkWQKuR0: Downloading webpage
WARNING: [Instagram] unable to extract username; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
ERROR: [Instagram] Cd2vkWQKuR0: Unable to extract video url; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 642, in extract
  File "yt_dlp\extractor\instagram.py", line 415, in _real_extract
  File "yt_dlp\extractor\common.py", line 1340, in _og_search_video_url
  File "yt_dlp\extractor\common.py", line 1235, in _html_search_regex
  File "yt_dlp\extractor\common.py", line 1226, in _search_regex

Duplicate of https://github.com/yt-dlp/yt-dlp/issues/3077


Fix exports for bundle files

Coverage decreased (-0.03%) to 96.809% when pulling 5310edf51f8cb3c57760a29b909897653712d474 on fix-bundle-exports into 0f2b8b5110c9e0b54d30dcac72d790ea3e212787 on master.


Canonical links for tags and categories incorrect

Hi
Thanks for the great theme.
I have noticed that the tag and category Canonical links are incorrect.  They are https://sitename/category-categoryname instead of https://sitename/category/gategoryname (the canonical tag links are the same).  So it looks like the theme is stripping the / after category and replacing it with a -.
Thanks
Robert

Wow, that was fast ;)
Thanks so much


fix typos of dns resolver proposal

What type of PR is this?

What this PR does / why we need it:
typo fix
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag
Coverage Δ

unittests
36.98% <ø> (+4.96%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes


[$1000] File upload in Safari: changing the filename in the filesystem changes what file is going to be uploaded

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Prerequisites: Both images used in testing should be in the same folder.

Open Expensify
Open any chat
Click Attach button
Attach the first image you want to upload and stop at the preview step, do not click Send.
Go to your filesystem and rename the 2nd image to the filename of the image you chose in Step 4 and that is shown in the preview.
Click Send.

Expected Result:
The image displayed in the preview should be uploaded.
Actual Result:
The image we changed its filename to match the filename shown in the preview is uploaded instead.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Safari
[ ] MacOS / Desktop

Version Number: v1.2.61-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/9680864/215520323-821bbd5b-08fb-4f05-801d-c6e829495328.mov
Expensify/Expensify Issue URL:
Issue reported by: Slack oesayan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673424557657069
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f7cf66b7d484960a
Upwork Job ID:<PHONE_NUMBER>713012224
Last Price Increase: 2023-02-12

Unassigning myself since Youssef self assigned :)

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@youssef-lr Huh... This is 4 days overdue. Who can take care of this?

Investigating this, will probably make it external.

Job added to Upwork: https://www.upwork.com/jobs/~01f7cf66b7d484960a

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Current assignee @youssef-lr is eligible for the External assigner, not assigning anyone new.

Unable to look into this further at the moment as I need to finish up a few more priority tasks. This is open for porposals.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The file sent to a chat is wrong if we rename another file to the first file name. No issue on native.
What is the root cause of that problem?
The file is getting picked based on its path and this is only happening on Safari. On chromium web-based, if we rename the file that we are trying to upload, it will throw an error ERR_UPLOAD_FILE_CHANGED. On Firefox, it will throw a CORS error (idk why).
What changes do you think we should make in order to solve the problem?

We should make a copy of the file selected for both attachment picker and drag and drop. Currently, we already do that by this PR, but it will only make the copy if the file name and the name after cleaning is different. We can basically just remove the if.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The file sent to a chat is wrong if we rename or delete file from local storage.
What is the root cause of that problem?
Root cause of this problem is related to file Uri(local path) which we are accessing 2 time first when we showing image crop and second time we are access Uri to upload on server. so when we select file for crop and change name of file or delete then it cant access file Uri when uploading on server.
What changes do you think we should make in order to solve the problem?
We can solve this problem we can store the image data in-memory or device storage so while upload file on server we can access stored file.
What alternative solutions did you explore? (Optional)
None

@youssef-lr @parasharrajat @isabelastisser this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@youssef-lr @parasharrajat @isabelastisser this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@parasharrajat while looking into this issue, I was trying to find an official explanation/documentation about the ERR_UPLOAD_FILE_CHANGED, but I can't find one. I only able to find some reported issues related to the error and the other answered that the error will be thrown if the file they are trying to upload did get changed. I also find the chromium source code that possibly will throw the error when the file did change.
I can't find a source to why Firefox throw a cors blocked error and I just assume on Safari it picked the file by the path 😅.

for web we can use

@PankajAS How will you use that on the web? Did you face the same issue on native as well?

@parasharrajat for web we have to use FileReader which result data we can store in localstorage/sessionstorage as react-native-fs not support web.

Any updates, @parasharrajat ?

@youssef-lr @parasharrajat @isabelastisser this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

I think technically it's not a bug, but more like a bad UX? On every other site, I guess when we upload a file, it will immediately upload it to the server and show the preview afterwards, Slack for example. Copying the file means we are going to read a maximum of 24mb of file.

The original bug was that it is possible to upload unsupported files (e.g. 1x1px image, so there is no post-preview file check) - you can read the discussion here.
https://expensify.slack.com/archives/C049HHMV9SM/p1673424557657069

@youssef-lr , based on the comments above, should we do nothing and close this issue?

@isabelastisser I'm fine with closing this as well. Considering how unlikely a user run into this, and that it's only occurring on Safari.


XSRF-TOKEN cookie does not include appname or path

When two Lychee installations live in different subdirectories of the same domain, their XSRF-TOKEN cookies conflict (overwrite each other) and cause problems.
I'm not sure if it is actually a supported configuration to run Lychee in a subdir, but other than this issue, it has been running fine for me so far.
The observable problem is that when you open one instance, then another in a second tab, then navigate the first one to "Settings" and then "More", you get a 500 error on the Settings::getAll POST request.
I noticed that this issue does not occur for the login status, since that seems to be put into the session and the session cookie uses the APP_NAME to allow distinguishing multiple installations (it might still be better to use a path-based cookies, but that might require more info on how Lychee is installed and might get complicated when internal rewrites are involved). I wonder: Wouldn't it make sense to put the XSRF-token inside the session anyway?
As a sidenote: It took me a while to figure out what was wrong, since this situation did not produce any log message at all (not in the PHP log, nor in the Laravel log).

I guess here is the script to be fixed: https://github.com/LycheeOrg/Lychee-front/blob/master/scripts/csrf_protection.js

Yeah, I noticed that behavior (I have my production installation on the same server as the development ones) but I assumed it was an inherent limitation and learnt to live with it. Thanks for the hint about APP_NAME -- that will go a long way for me! If you figure out a foolproof solution, do not hesitate to submit a PR! For instance, would using APP_URL instead of APP_NAME work?


Set Up Workflow Management in Cloud Cockpit

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-1-setup.html
Step 2, number 7:
HISTFILE= && cf login -a <your trial account API End Point> -u <your trial email ID> -p <your trial user password> -o <your trial organisation name> -s <your trial space name>
It would be good to have a copy button for the command. The command here is quite long and I always need bit time to get it correctly selected with the mouse.

This is has changed now. Please check the updated Booster.
@MichaelCzcz - please close the ticket


Next steps? We are all stuck at "Go"!

Hey @billywhizz
Great project. I stumbled here (like many others) from the results on TechEmpower. As I look at your code, I see your genius at work. The challenge for many of us is to use Just in production. I understand you are doing this for fun, but the lack of documentation in your code (in addition to API docs) makes it hard for us to contribute. For example, to use Postgres in production, we need a solid API. We also need MariaDB, Mongo etc.
My summary is that you have created an (1) opinionated framework, that (2) gets around some of V8's notorious weaknesses (threads, garbage collection etc.), using (3) optimized C-libraries when available. What you have done is ideal for web services. We get native - like performance while being coder-friendly in JS. The weakness of NodeJS is what spurred people to look at Go, Rust, drogon etc.
This is a huge deal.
I know it's not as fun as coding, but you need to empower the community to help you, otherwise this amazing project will stay stuck in your "todos".
As a community, we need:

Docs for the modules / C-wrappers - so we can build our own
Docs for your "blessed modules" - so we can build our own
API docs and example starter projects - so we can start working
(Optional) Support for "imports" so we can use popular libraries like lodash etc. out-of-the-box

Once you do this, this project will fly and overnight dozens of developers will be contributing amazing modules to get this project to production-quality.

@ramezrafla would you want to help me to embedded a new Component System that replaces WASI and WASM ? and makes Imports Obsolute i am working on that at a bigger scale directly in chromium and v8 as also nodeJS
Just JS is already the implementation that comes most near to that goal but first of all let me enlighten you about the documentation and the current state.

@ramezrafla see:

[ ] - #53
[ ] - #54

hi @ramezrafla. i have got your DM and seen the above. apologies - am very busy with work right now but I will catch up with everything and get back to you over the weekend.

Thanks for the detailed write up on the internal implementation of Just. Still going through the nitty gritty. I still don't see the benefits. We are at 90% of the best framework. We have a large code-base (porting from Node etc.). We already have integrations with critical elements (a few missing).
From a business or development perspective, not sure why another framework or addition is needed. Sorry. Maybe I don't see it.

hi @ramezrafla. i have got your DM and seen the above. apologies - am very busy with work right now but I will catch up with everything and get back to you over the weekend.

Thanks so much @billywhizz
Looking forward! We are preparing what is needed to use in production. Would love to contribute as well.

glad you were able to figure out the postgres issue - i think should be easy enough to add scram support - to date i just did what was required for techempower - there's quite a lot of functionality missing.

The PG interface is very well-written. It's a great starting point for the community. We just need some guidance, will go a lot faster.

i am trying to writing a book about the core principles and terminologies and all that so we can build up a community on the right fundamentals i identified many educational issues around the committee members of core infrastructure projects like nodejs and w3c cloudflare microsoft and so on.
would love to get input and even examples written in the easy simple terminologie distinguished.
so maybe create a issue about your pg experience and just: so that i can see what your problems where and how we can improve the communication with the world.

https://github.com/lemanschik/simplicity-made-easy/blob/main/README.md


Add easy support for Datadog and possibly other observability solutions

Use case
I have played around with the Datadog and the AWS Powertools Lambda layers and as one that needs to integrate with Datadog, the Datadog Lambda layer is a good choice for getting that integration set up flawlessly.
But I also really enjoy some of the features that AWS Powertools have incorporated into their Lambda layer and as a developer I find it to be a very useful tool. Last time I checked (a while ago), the AWS Powertools layer was more lightweight as well.
Sadly, because both layers use similar packages (boto3 for example among other things), I believe they are not exactly compatible with each other. And either way, adding both would make our Lambdas' start times much worse as both layers are not exactly light either.
I have one collection of Lambdas using the Datadog layer and another collection using Poewrtools. I have thus noticed some of the differences that make Powertools tricky to easily integrate with Datadog despite being the more useful tool purely from a developer's perspective:

the log format is slightly different and it does not allow Datadog to easily query logs by things like request ID. It would be nice to be able to specify a Datadog log format that we can easily use within Powertools without having to create a custom one ourselves. I believe compatibility can be easily achieved here and all we need is a special logger format that mimics the one used by Datadog
Datadog does not ingest AWS CloudWatch metrics. I believe the easiest way to do a custom metric that gets interpreted by Datadog is to send logs in this format {"m": "Metric name", "v": "Metric value", "e": "Unix timestamp (seconds)", "t": "Array of tags"}. I know this is different from the embedded metrics format which AWS already provides - https://aws.amazon.com/about-aws/whats-new/2019/11/amazon-cloudwatch-launches-embedded-metric-format but maybe we can have a way to support both based on some configuration setting? Sadly the metrics that Powertools provides at the moment are not easily ingestible into Datadog
I have not tested it sufficiently, but if there is some incompatibility with the way Datadog handles traces, maybe someone else that has that knowledge can keep in mind that some adaptations would be useful there too? From what I can understand, there should be no problems there as traces are ingested straight from XRay but I have sadly under-utilised that functionality

Solution/User Experience
Provide a configuration or an option to define the format when setting up loggers, metrics and traces, which would allow for better integration with other ovservability solutions other than AWS' CloudWatch and XRay
Alternative solutions
It may be possible to do all these already. Maybe a separate package that adds this compatibility can be created that works well with Powertools, as long as Powertools already has easy methods to manipulate its behaviour in the required ways to allow for the requested integration.
Acknowledgment

[X] This feature request meets Lambda Powertools Tenets
[X] Should this be considered in other Lambda Powertools languages? i.e. Java, TypeScript

It is so rare to receive such a high quality feature request like this that I want us to take time to reply to you accordingly - please bear with us for an answer next week.
Until then, we're laying the ground work in E2E and Integ test framework to give us confidence to offer what you're asking -- either native support or expose the mechanisms we already have for customers to build them.
For anyone else reading this, please please add your +1 to the author to help us prioritise it.
Thank you for taking the time to share such rich detail.

Hey @petarlishov, our new (internal) E2E framework took a lot longer than I expected to refactor, so I'm replying tomorrow morning to address your questions and a few asks as we started v2 in parallel.

I'm removing the help wanted and need-customer-feedback labels because already have work in progress, so anyone can comment on these RFCs.

UPDATE: We're adding support in Logger for Datadog as a start. We're working on a POC for Metrics, and adding last refinements for Tracer Providers.
For Logger, Datadog was the only provider that required a custom timestamp so we've added a Formatter, and documented our recommendation to use Lambda Extensions to not impact in performance.
The only reason we're not adding OTel Log output now is because it's not Final yet - please feel free to open a feature request when that happens (whoever is reading and need that)

cc @leandrodamascena for an update on Metrics Providers

Hey everyone! Adding some new information here to keep everyone up to date on our work.
We are working to merge the Metrics Providers as soon as possible. Our current plan is to merge this PR by the end of July. We're taking the opportunity to address some tech debt in the Metrics utility and provide a great experience for customers who want to use a provider other than Amazon CloudWatch EMF.
I'll update this issue by mid-next week if anything changes.

We are about to merge PR https://github.com/aws-powertools/powertools-lambda-python/pull/2194 which will allow us to add external providers in the metrics utility. Our initial plan was to add Datadog to this PR, but we are waiting for Datadog to release a new version of their extension and fix an issue with a dependency: https://github.com/DataDog/datadog-lambda-python/issues/350.
Support for Datadog will likely be delayed for a few days, but we are working hard to add this support as soon as possible.

Quick update: Datadog made the bugfix release we needed, we're tentatively looking to launch Datadog Metrics Provider by the end of next week ;)
Then we move on to adding Observability Provider to Tracer (rinse and repeat).

Quick update -- @roger-zhangg is working on the last feature: Observability Provider for Tracer. Once that's done, we'll close this issue, and start investigating an alternative solution for OTel as cold starts haven't significantly improved.


Add EditorConfig file

EditorConfig is a dotfile which stores configuration that is supported by a wide variety of text editors and IDEs both natively and with plugins. The advantage of this is that it allows us to enforce some project standards such as the style of indentation and line ending used. I find this can help reduce git conflicts in some circumstances.

Yes, I think this is a good first step in getting it to where it needs to be.


does this package support standard crontab expr

according to README.md, this package support standard crontab expr
Howevery, I find some expr run error.
For example. expr * * * * * means run every minute in standard crontab expr. (you can check meaning of crontab expr on this website). But in this package, I find it run every second. I'am very confused.
test code (in v1.2.0)
package main

import (
	"fmt"
	"time"

	"github.com/robfig/cron"
)

func main() {
	job := cron.New()
	job.AddFunc("* * * * *", func() {
		fmt.Printf("run at %s\n", time.Now())
	})
	job.Start()

	select {}
}

@zhuliquan note that you are not using the latest version
Changing your import to import "github.com/robfig/cron/v3" should solve the problem


drivers: fixed div by zero when reading max17048

Under some cirscumstances the current rate is reported by the chip as 0 which affects to time to full and time to empty calculations. This commit handles this case to avoid a division by zero

After some time using this fuel gauge, this is the only problem I found. This is a very naive error but at least is the only one I suffered.


[branch-2.0]catalogpaimon catalog supports complex types

Proposed changes
from
#25364
#25834

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run Build Extensions

run buildall


Improve unparsing to handle aggregations with grouping set

Which issue does this PR close?
PR improves Aggregation unparsing logic to handle plans with grouping sets.  When Aggregation is created (below) grouping_set_to_exprlist is used to retrieve grouping set expressions and populate schema (qualified_fields)
https://github.com/apache/datafusion/blob/f54712d8c2545fc0dd60cdc693704992e9d82eef/datafusion/expr/src/logical_plan/plan.rs#L2953C9-L2977C6
        let group_expr = enumerate_grouping_sets(group_expr)?;

        let is_grouping_set = matches!(group_expr.as_slice(), [Expr::GroupingSet(_)]);

        let grouping_expr: Vec<&Expr> = grouping_set_to_exprlist(group_expr.as_slice())?;

        let mut qualified_fields = exprlist_to_fields(grouping_expr, &input)?;
..
        qualified_fields.extend(exprlist_to_fields(aggr_expr.as_slice(), &input)?);

        let schema = DFSchema::new_with_metadata(
            qualified_fields,
            input.schema().metadata().clone(),
        )?;

        Self::try_new_with_schema(input, group_expr, aggr_expr, Arc::new(schema))
    }

PR adds the same step/logic to correctly retrieve all aggregation expressions when unproject columns. W/o this logic current unproject logic fails as schema does not match agg.group_exp + agg.aggr_expr  (must be grouping_set_to_exprlist(agg.group_exp) + agg.aggr_expr) : can't get and then unwrap unprojected expression by index: https://github.com/apache/datafusion/blob/f54712d8c2545fc0dd60cdc693704992e9d82eef/datafusion/sql/src/unparser/utils.rs#L92
Concern
grouping_set_to_exprlist is used directly in find_agg_exp so invoked for each column to unproject (in case of grouping set). This could be optimized to do this only once. Decided to keep this logic this way as pre-calculating and passing such expressions as argument or changing find_agg_exp signature will make code less clean and grouping_set_to_exprlist does NOT create expressions copies (operates by Vec<&Expr>)

Created PR to datafusion combining this and previous improvement. Merged this PR to unblock TPC-DS queries, will add required changes based on review/feedback is any:
https://github.com/apache/datafusion/pull/12705