QG checks (Release 24.05)

QG checks
Please keep this issue open until QG is concluded and will be managed by the Issue Creator!
We will inform you about finding and proposals in separated issues, this issue here is for the Overview of the Checks!
Please keep this issue open until QG is concluded!
Product Owner:
Dev SPOC:
Helm Chart Version:
App Version:
Release Managemnet Reference Issue: eclipse-tractusx/sig-release#590
Check of Tractus-X Release Guidelines

Currently implemented automatic checks can be found under your product on our Release Guidelines Checks Board
This QG Check is depending on the mandatory information from our current Release Guidelines

TRG 1 Documentation

[x] TRG 1.01 appropriate README.md
[x] TRG 1.02 appropriate install instructions either INSTALL.md or in README.md
[x] TRG 1.03 appropriate CHANGELOG.md
[x] TRG 1.04 editable static files

TRG 2 Git

[x] TRG 2.01 default branch is named main
[x] TRG 2.03 repository structure
[x] TRG 2.04 leading product repository
[x] TRG 2.05 .tractusx metafile in a proper format

TRG 3 Kubernetes

[x] TRG 3.02 persistent volume and persistent volume claim is used when needed

TRG 4 Container

[x] TRG 4.01 semantic versioning and tagging
[x] TRG 4.02 base image is agreed   https://github.com/eclipse-tractusx/bpdm/issues/924
[x] TRG 4.03 image has USER command and Non Root Container
[x] TRG 4.05 released image must be placed in DockerHub, remove GHCR references
[x] TRG 4.06 separate notice file for DockerHub has all necessary information

TRG 5 Helm

[x] TRG 5.01 Helm chart requirements
[x] TRG 5.02 Helm chart location in /charts directory and correct structure https://github.com/eclipse-tractusx/bpdm/issues/925
[x] TRG 5.03 proper version strategy
[x] TRG 5.04 CPU / MEM resource requests and limits and are properly set
[x] TRG 5.06 Application must be configurable through the Helm chart
[x] TRG 5.07 Dependencies are present and properly configured in the Chart.yaml
[x] TRG 5.08 Product has a single deployable helm chart that contains all components
[x] TRG 5.09 Helm Test running properly
[x] TRG 5.10 Products need to support 3 versions at a time
[x] TRG 5.11 Upgradeability

TRG 6 Released Helm Chart

[x] TRG 6.01 Released Helm Chart

TRG 7 Open Source Governance

[x] TRG 7.01 Legal Documentation
[x] TRG 7.02 License and copyright header
[x] TRG 7.03 IP checks for project content
[x] TRG 7.04 IP checks for 3rd party content
[x] TRG 7.05 Legal information for distributions
[x] TRG 7.06 Legal information for end user content
[x] TRG 7.07 Legal notice for documentation
[x] TRG 7.08 Legal notice for KIT documentation

TRG 8 Security

[x] TRG 8.01 Mitigate high and above findings in CodeQL
[x] TRG 8.02 Mitigate high and above findings in KICS
[x] TRG 8.03 Mitigate high and above findings in GitGuardian
[x] TRG 8.04 Mitigate high and above findings in Trivy

Hints
Information Sharing

All items have been reviewed and checked off according to the eight-eyes principle by @nicoprow  @maximilianong @rybtim  @HeyHardy

@maximilianong the TRG 7.07 is done, we have all necessary approvals from involved participants. you can put it as done. thanks!

Hey @nicoprow and @hzierer who can resolve the TRG 5.02 issue or confirm if this is preventing us from approving the QG, pls?! Thx

As soon as #936 is merged, TRG 5.02 is fulfilled

Hey @nicoprow and @hzierer who can resolve the TRG 5.02 issue or confirm if this is preventing us from approving the QG, pls?! Once completed, may I ask you to add the final app and helmchart versions on top and check the relevant box in the reference issue. Thx

all TRG checks completed successfully


Our game is Sokoban-like game with a cute dragon player that pushes a flower to a green spot.
How do you play your game?
To play the game, you must use WASD to move a dragon that must push a flower to a green spot. Avoid red at all costs. Make sure to push crates out of the way, open doors by picking up keys, and use portals for difficult situations. The levels get progressively harder. Some other controls are "i" for information, like coordinates and level number, and "j" to restart the level if you get stuck.
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file.

Thanks for your PR!

This pull request is the updated version of the code.

Hey! There's conflict in PR, I think it's better close this PR, make a new fork and make a new PR

Closing this due to inactivity. Please let me know if you'd like this reopened.


Online docs search results takes to the superseded docs

ISSUE TYPE

Documentation

COMPONENT NAME
Search

Online docs search results send to the deprecated docs

Search a keyword
After results, choose any resultat
It will take the user to the 4.12 page showing Warning NOTICE: THIS DOCUMENTATION SITE HAS BEEN SUPERSEDED.

@abdelouahabb would you know why this is and how to solve it (for other users) ?

From the online documentation there is the PRE 4.11 DOCUMENTATION in the navbar, so if we take the example of the Installation Guide, there are two versions :

the old one who sends to http://docs.cloudstack.apache.org/projects/archived-cloudstack-installation
the other one (latest) stays in the latest docs http://docs.cloudstack.apache.org/en/latest/installguide/

So from here, the search results send to /project/ instead of the /latest/

@abdelouahabb would you know why this is and how to solve it (for other users) ?

Can you add screenshots and hyperlinks to the problamatic location, please.
at http://docs.cloudstack.apache.org/en/latest/index.html there is no PRE 4.11 :

where are you looking?

It is already in the sidebar :

@abdelouahabb sorry I can't reproduce your description:
Search a keyword
After results, choose any resultat
It will take the user to the 4.12 page showing Warning NOTICE: THIS DOCUMENTATION SITE HAS BEEN SUPERSEDED.

so trying to reproduce:

i went to the docs
and typed network,
choose the first entry: http://docs.cloudstack.apache.org/en/latest/adminguide/networking/basic_zone_config.html?highlight=network

can you add the precise reproduction steps of your problem please?

@abdelouahabb sorry I can't reproduce your description:
Search a keyword
After results, choose any resultat
It will take the user to the 4.12 page showing Warning NOTICE: THIS DOCUMENTATION SITE HAS BEEN SUPERSEDED.

so trying to reproduce:

i went to the docs
and typed network,
choose the first entry: http://docs.cloudstack.apache.org/en/latest/adminguide/networking/basic_zone_config.html?highlight=network

can you add the precise reproduction steps of your problem please?

Because it gives duplicate results, one from the latest docs, the other one from the archived :

yes, it does. This is intentional. What is it that you would want to see different?

yes, it does. This is intentional. What is it that you would want to see different?

Maybe if there is a big difference between the LTS and the normal release, it would be good to have two results, but i think having two results seems ambiguous ?

we changed the documentation method at 4.11 that's why. It is marked as from archived so I don't see a problem. as 4.11 is quite old we might considder phasing it out, but on the other hand I know of companies still at 4.7 and 4.9.

closing this @abdelouahabb . if you feel action is still needed please reopen and comment or create a new issue with specifics.


MSID: 90510 Version: 2 DOI: 2<IP_ADDRESS>6542

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=90510)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/90510/v2)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6542)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/90510/v2/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/90510)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/90510

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/90510

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/90510/v2/90510-v2.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/90510)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocations missing from the references


ci: change to deployment to maven central

:tada: This PR is included in version 1.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


kubeconfig fails

Hi
I have kubernetes-1.0.2-1.9.6 installed on a DC/OS 0.11 cluster.  The kubconfig command fails as follows...
[p3061@cuckoo-accessvm-p3061 ~]$ dcos kubernetes kubeconfig
failed to retrieve 'cluster.name'

Cheers
Daniel Sherwood

@hectorj2f please help here.

@daniel-sherwood This could happen when there isn't a cluster section in the dcos.toml configuration file of your cluster. Could you run dcos auth login to your cluster ? We need to be sure you're logged in the right cluster.
Could you also print the content of your dcos.toml file e.g ~/.dcos/clusters/CLUSTER_ID/dcos.toml ?

Tried that - still not working.
[p3061@cuckoo-accessvm-p3061 ~]$ dcos auth login
If your browser didn't open, please go to the following link:

    http://<IP_ADDRESS>/login?redirect_uri=urn:ietf:wg:oauth:2.0:oob

Enter OpenID Connect ID Token: <TOKEN>
Login successful!
[p3061@cuckoo-accessvm-p3061 ~]$ dcos kubernetes kubeconfig
failed to retrieve 'cluster.name'
[p3061@cuckoo-accessvm-p3061 ~]$ cat ~/.dcos/clusters/e5bc27d5-da21-46ce-9f56-a45320ff2361/dcos.toml
[core]
dcos_url = "http://<IP_ADDRESS>"
dcos_acs_token = "<TOKEN>"
[p3061@cuckoo-accessvm-p3061 ~]$

Remved ~/.dcos/ and re-ran 'dcos cluster setup' and it is now working.
Thanks.


Godep diff implementation

Implemented the  'godep diff' command which will output a unified diff between existing Godeps and what is now in $GOPATH.
Should close Issue #1 and maybe Issue #76 and Issue #119

Rad, looking at this now.

BTW, maybe I should write this up in a contributing.md file, but this project has a "rebase & squash" policy. It's fine for a pull request to have multiple commits, but to land it should be rebased on top of master and squashed into a single commit.

LGTM after the minor things above.

@kr and @freeformz Thanks for the comments/review. I've addressed those in my PR.


rPackages.gdalraster: add system deps

Description of changes
Added required system dependencies

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nix-shell -p 'rWrapper.override{packages = with rPackages; [ gdalraster ];}' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/f5b163970956a53d4b82fd052a4a6af22d9bdb3a.tar.gz

configure: CXX: /nix/store/6kpjydf9x7zqa1xq2qipnwr32ki3fs2n-clang-wrapper-16.0.6/bin/c++ -std=gnu++17
checking for gdal-config... no
no
configure: error: gdal-config not found or not executable.
ERROR: configuration failed for package 'gdalraster'
* removing '/nix/store/x3a9m4bxbrhl4yvyf69wxjf27316f3ip-r-gdalraster-1.7.0/library/gdalraster'
error: builder for '/nix/store/6kcwaixkg6qzda7zk7rw49nl2ifwb342-r-gdalraster-1.7.0.drv' failed with exit code 1;
       last 10 log lines:
       > * installing *source* package 'gdalraster' ...
       > ** package 'gdalraster' successfully unpacked and MD5 sums checked
       > ** using staged installation
       > configure: CC: /nix/store/6kpjydf9x7zqa1xq2qipnwr32ki3fs2n-clang-wrapper-16.0.6/bin/cc
       > configure: CXX: /nix/store/6kpjydf9x7zqa1xq2qipnwr32ki3fs2n-clang-wrapper-16.0.6/bin/c++ -std=gnu++17
       > checking for gdal-config... no
       > no
       > configure: error: gdal-config not found or not executable.
       > ERROR: configuration failed for package 'gdalraster'
       > * removing '/nix/store/x3a9m4bxbrhl4yvyf69wxjf27316f3ip-r-gdalraster-1.7.0/library/gdalraster'
       For full logs, run 'nix log /nix/store/6kcwaixkg6qzda7zk7rw49nl2ifwb342-r-gdalraster-1.7.0.drv'.
error: 1 dependencies of derivation '/nix/store/pjg56cbi2xrfw1x2cfm2b3y4h2skf2yn-R-4.3.2-wrapper.drv' failed to build

FWIW, I built it successfully on  x86_64-linux. @philipp-baumann I guess in your case some macOS-specific config is needed?

@philipp-baumann Could you or someone else check on darwin again? I rebased to current master and restructured a bit. We should find out what is missing on darwin

@ofborg build rPackages.gdalraster

> library(gdalraster)
code for methods in class “Rcpp_CmbTable” was not checked for suspicious field assignments (recommended package ‘codetools’ not available?)
code for methods in class “Rcpp_CmbTable” was not checked for suspicious field assignments (recommended package ‘codetools’ not available?)
code for methods in class “Rcpp_GDALRaster” was not checked for suspicious field assignments (recommended package ‘codetools’ not available?)
code for methods in class “Rcpp_GDALRaster” was not checked for suspicious field assignments (recommended package ‘codetools’ not available?)
code for methods in class “Rcpp_RunningStats” was not checked for suspicious field assignments (recommended package ‘codetools’ not available?)
code for methods in class “Rcpp_RunningStats” was not checked for suspicious field assignments (recommended package ‘codetools’ not available?)
GDAL 3.8.5, released 2024/04/02, PROJ 9.4.0
> sessionInfo()
R version 4.3.3 (2024-02-29)
Platform: aarch64-apple-darwin22.6.0 (64-bit)
Running under: macOS Sonoma 14.2.1

Matrix products: default
BLAS:   /nix/store/csam52q8ksy40sa4q7z5ijx7jixivrby-blas-3/lib/libblas.dylib
LAPACK: /nix/store/i2ddi7h4bn0qr1bms5bilccp0rd9fnm5-openblas-0.3.26/lib/libopenblasp-r0.3.26.dylib;  LAPACK version 3.12.0

locale:
[1] C/UTF-8/C/C/C/C

time zone: Europe/Zurich
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] gdalraster_1.9.0

loaded via a namespace (and not attached):
[1] compiler_4.3.3 cli_3.6.2      tools_4.3.3    Rcpp_1.0.12    xml2_1.3.6
[6] rlang_1.1.3


PHP Parse error:  syntax error, unexpected '[' in .../MakePotCommand.php on line 29

Summary
We have multiple web hosting accounts with the same web host, one of which has an installation of WP-CLI that is misbehaving.
Recently, I installed WP-CLI in a new hosting environment, but it failed to start, due to the following error...
PHP Parse error:  syntax error, unexpected '[' in phar:///[redacted]/wp/vendor/wp-cli/i18n-command/src/MakePotCommand.php on line 29
Steps to reproduce
The same error is generated regardless of what command is used...essentially, WP-CLI fails to start.
What's interesting is the fact that we have several other sites hosted at the same web host using the same hosting plan (same server specs, software, etc.).  Each hosting account is running PHP 7.0.30 with the default extensions loaded, and running WP-CLI version 2.0.0.  Each account is hosting a WordPress website with a custom built theme, but all relatively similar in development to the others.
I just can't for the life of me figure out why we have multiple instances of WP-CLI, each hosted in practically identical environments, but only the one is throwing a syntax error.
Environment
CentOS release 6.10 (Final)
Apache/2.2.34 (Unix) / PHP 7.0.30
Loaded extensions - apc, bz2, calendar,  ctype, curl, date, dom, ereg, exif, fileinfo, filter, ftp, gd, gettext, gmp, hash, iconvi magick, imap, intl, json, libxml, mbstring, mcrypt, memcache, mysqli, mysqlnd, openssl, pcntl, pcre, PDO, pdo_mysql, pdo_sqlite, Phar,  posix, pspell, readline, redis, Reflection, session
The only real difference between the hosting environments that I can find is on the affected server, which is running Phar 2.0.1, whereas on the other accounts where WP-CLI is functioning properky, are running Phar 2.0.2, and all are running the same API version (1.1.1).
TIA

@soupmagnet You need to check what PHP binary is being used to run WP-CLI, because the above issue results from the code being run on PHP 5.3. WP-CLI has bumped its minimum requirement to PHP 5.4+ from WP-CLI v2.0.0 on.

Thank you, @schlessera.  It turned out to be PHP-CLI that was still running the outdated version.  False alarm, but thanks anyway.


Cannot create new project

I cannot create a new project, if I run the command from Homepage or README. It doesn't matter, which template I choose, I always get "Template not found" and nothing happens.
❯ npx create-sst my-app
Need to install the following packages:
  create-sst
Ok to proceed? (y) y
? Select a template typescript-starter
✖ Template not found at presets/typescript-starter

Versions:

npm -v
8.5.5
node -v
v16.15.0

Same error output as @pitgrap , however I initiated with yarn create sst.
If successful, at this time we should be scaffolding new sst project with:
    "@serverless-stack/cli": "1.2.28",
    "@serverless-stack/resources": "1.2.28",

Same here tried a typescript, javascript and go starters all give this error

Same issue here using node 16.13.1
For me, npm init<EMAIL_ADDRESS>is successful, whereas<EMAIL_ADDRESS>and<EMAIL_ADDRESS>fail.

Sorry about this! It's fixed in the latest release 1.2.30


ZoneGrid should accept 'false' as a value for it's delimiter property

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[X] Caught up with develop branch as of last change.
[X] Added CHANGELOG entry, or determined not required.
[X] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[X] Updated doc comments / prop-types, or determined not required.
[X] Reviewed and tested on Mobile, or determined not required.
[X] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Hi @febbraiod  - this started throwing a TS error for ZoneMapperModel which had:
    get delimiter(): string {
        return this.zoneGridModel.delimiter;
    }

Due to incompatible return types.  Any ideas how that got through our pre-commit auto-run of tsc?
Fix was trivial - pushed https://github.com/xh/hoist-react/commit/a143cd2d7fec8e4ffbdf0153d9a4cfe36adce98d.
I'm confused though as ZoneGrid does not do too well with delimiter:false - looks like we need to adjust the styling or always insert a spacer element. Am I missing something here? What's the use case that prompted?


Video Freezes in Co-streaming When Muting/Unmuting and Moving App to Background/Foreground

Describe the bug
During a co-streaming session, the video freezes when muting and unmuting the remote user's video track. The issue also arises when the co-streamer moves the application to the background and then brings it back to the foreground
SDK Version

Livekit: 1.1.2
Livekit: 1.1.1
Livekit: 1.1.0

iOS Version

iOS 17
iOS 16.5

Steps to Reproduce

Start a co-streaming session with a remote user.
During the co-stream, mute and then unmute the remote user's video track.
Additionally, move the co-streamer app to the background and bring it back to the foreground.
Observe the video freezing behavior in both scenarios.

Expected behavior
The video should continue streaming seamlessly without any freezing when muting/unmuting or transitioning the app between the foreground and background
Screenshots

Are you using E2EE ?

No

Was this working in earlier versions but started happening recently ?

past I used 1.0.10 it worked at that time.

@hiroshihorie any update on this?


Does WGL4 really belong in the OT spec?

It doesn't seem appropriate to me that the OT spec would include data about some named character repertoires. That might have bearing for some vendor's font design requirements, or for support of particular scripts or languages. But it really has no bearing on specifying the font format.
Can WGL4 be removed from the spec? Does it need to be retained somewhere else instead (and, if so, where)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa41c886-9600-e8e8-22f9-df3c082d20ff
Version Independent ID: 1688414c-bda3-07e5-001f-d68a5550baeb
Content: WGL4.0 Character Set - Typography
Content Source: typographydocs/opentype/spec/wgl4.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: PeterCon

The MS-specific WGL4 content is now available elsewhere on the Microsoft Typgraphy site: https://docs.microsoft.com/en-us/typography/develop/wgl4. Hence, proposed draft for the next version will remove these pages from the OT spec.


Unauthorized Access to API Endpoint

I have encountered an issue where the API endpoint "/api/Counter" is accessible without proper authorization. I don't know if I am missing something. I have made minimal changes, just adding connection configuration to Entra ID.
Steps to Reproduce:
Ensure you are logged out of the Blazor web application.
Open a new browser window or an incognito mode session.
Navigate to the endpoint: https://localhost:44348/api/Counter
Expected Behavior:
Accessing the "/api/Counter" endpoint without authorization should result in an access denied error or redirect the user to a login page, preventing unauthorized access to API data.
Actual Behavior:
The "/api/Counter" endpoint is accessible without authentication.

Hi @moshali1
Thanks for reporting, this would be bad. I will look into this and validate.
Greetings Damien

yes is correct, this is this code:
´´´csharp
app.MapGet("/api/Counter", (HttpContext httpContext) => Results.Ok("Data from secure API"))
.RequireAuthorization();
´´´
The RequireAuthorization is not working. I switch to the controller model.

@moshali1 Fixed this now. Thanks for reporting.
The BlazorAuthorizationMiddlewareResultHandler broken everything.
The API can only be used in Web assembly mode, when server rendering is running, you can call the data directly. The API uses cookie authentication as so requires CSRF protection which is missing.
I would recommend using only Blazor Webassembly hosted in a ASP.NET core like the other example or Blazor Server. Blazor Web in server only mode seems to work, but you need the  nonce protection.
Still a lot of "special" stuff with the mixed mode.
Here's a Blazor Web (Server only) which I think is fairly solid:
https://github.com/damienbod/BlazorServerOidc/tree/main/BlazorWebFromBlazorServerOidc
But I need to fully validate the security.
Greetings Damien


Executor in Stopper plugin

We need to run the script that counts the pending jobs via SSH, therefore we need to use the SSHExecutor.
This pull request adds a new parameter to the Stopper plugin, executor, and uses the executor to run the script. The default is ShellExecutor, so the default behavior doesn't change.

Codecov Report

Merging #4 (aeb2cfe) into master (6d2cc78) will increase coverage by 1.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   92.52%   93.57%   +1.05%
==========================================
  Files           6        6
  Lines         107      109       +2
  Branches       20       20
==========================================
+ Hits           99      102       +3
+ Misses          6        5       -1
  Partials        2        2

Impacted Files
Coverage Δ

cobald_hep_plugins/stopper.py
85.18% <60.00%> (+5.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2cc78...aeb2cfe. Read the comment docs.

You're right, this can be removed. Done with most recent commit.

Is everything else ok or is there anything I should change? @maxfischer2781


Minimal Working Example?

Hey @Floppy thanks for adding this project! As stated in the @manyfold3d issue, I'm keen to give it a try for adding STP-file support. I'm not very familiar with Javascript, but I'm eager to learn. After trying some things with pure javascript, I made an attempt to get your sample working in react. at least it compiles correctly, but the model is not visible. The only thing I had to change was the  export part in the main.js file. Once this works, I can have a look after the STP library. If you have time, it would be great if you can point me to some thoughts I'm missing here:

seems like the loader works, but display fails?

The Viewer component is here
Thanks a lot for your help!

Take a look at the threejs example for actual usage: https://threejs.org/examples/#webgl_loader_3mf
This repo is more of an example of how to package it up with npm, which isn't really what you need right now, my mistake sorry!


Add documentation and RST linting

This adds some more documentation on releasing a new version. It also adds
a RST linting tool to ensure that the README is rendered correctly in PyPI.

Ah, the sweet smell of good documentation! 👍


Added k8s node map to cache and validation with other node maps

…etcd node map.

Coverage remained the same at 77.137% when pulling e43489d981aecfb3337da8450aa74639d76bd775 on omegaman123:contiv-crd into 53821d26221108f966830d4d23381afca70a4e22 on contiv:contiv-crd.


CANVAS-135 - Added support to configure client/server ports and path

Need to add the following new configs to your .env:
CLIENTPORT=3000
SERVERPORT=8080
LTI_APPROUTE=

@crystalrain125 When you check out the latest master you will need to add these configs to your .env file to make the app work.
CLIENTPORT=3000
SERVERPORT=8080
LTI_APPROUTE=


Mosquitto in path and with different port

It does not work when I try to connect to wss://my.host:9001/mqtt.
I get the following error:
PHP Fatal error:  Uncaught Mosquitto\Exception: Lookup error.

This extension doesn't support websockets, so that will fail.


Administrator panel changes

Is necessary to make some changes in the Administrator panel. These changes are:

[ ] Add resource button will split on two buttons.
[x] Remove add fine button.
[ ] Add BREMS logo into header.
[ ] Add a dashboard into index view.

Add fine button has been removed successfully.

Resource view has been changed. These are the changes:

Added some values in the table: author, number of copies, resource type.
Resource view still having one button. The form contains a checkbox which allows administrator to chose if the resource is a book or a magazine.

Dashboard finished.


Upgrade required vineyard version

What do these changes do?
Upgrade to v0.4.2 and re-enable the HDFS test.
Related issue number
N/A

Codecov Report

Merging #1655 (4421561) into main (59c85b0) will decrease coverage by 8.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
- Coverage   73.16%   64.92%   -8.24%
==========================================
  Files          89       89
  Lines        9736     9736
==========================================
- Hits         7123     6321     -802
- Misses       2613     3415     +802

Impacted Files
Coverage Δ

...aphscope/tests/kubernetes/test_resource_builder.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...on/graphscope/tests/kubernetes/test_demo_script.py
0.00% <0.00%> (-91.75%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
11.90% <0.00%> (-57.62%)
:arrow_down:

python/graphscope/tests/unittest/test_java_app.py
49.33% <0.00%> (-50.67%)
:arrow_down:

python/graphscope/deploy/kubernetes/cluster.py
23.55% <0.00%> (-50.20%)
:arrow_down:

python/graphscope/analytical/app/java_app.py
24.24% <0.00%> (-44.95%)
:arrow_down:

...thon/graphscope/tests/kubernetes/test_with_mars.py
0.00% <0.00%> (-44.83%)
:arrow_down:

python/graphscope/interactive/query.py
41.12% <0.00%> (-38.71%)
:arrow_down:

...n/graphscope/deploy/kubernetes/resource_builder.py
30.59% <0.00%> (-25.95%)
:arrow_down:

python/graphscope/client/rpc.py
76.85% <0.00%> (-15.75%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc256c1...4421561. Read the comment docs.


Event Parsing Crash fix

Fixes defect making it possible to crash the eventsource on an extra newline.
Adds several automated tests.

 Fix eventsource crash on parsing a string


chore: requirements changes

Dear all,
Here are a few business requirements changes that covers detailed requirements on customer's shopping flow. For detailed flow on each points will be specified later on repository issues.
Some points that have "Optionally" on them means it's optional and it's okay to not work at that requirements at all.
The phase 2 is created so that the phase 1 (everything above the word phase 2) don't have that much to do. I know we're all busy, so I guess it's better to limit everything and move things that are hard to create to a later stage. The date of phase 2 will be decided later, but it will surely start after everything on phase 1 is completed (or at least, nearly completed).
If you have suggestion on moving some points on phase 1 to phase 2 (or vice versa), please let me know.

Regarding

Merchant CANNOT sell items that are prohibited by the TokoBapak system
Will there be a moderation team to regularly check or do we use form validation to see if the product name has blacklisted words (e.g. "rokok") in it before submitting?

Regarding

Merchant CANNOT sell items that are prohibited by the TokoBapak system

Will there be a moderation team to regularly check or do we use form validation to see if the product name has blacklisted words (e.g. "rokok") in it before submitting?

Nice catch, both should be good.
Dedicated won't catch all of it.
Blacklisted word not gonna work, if you sell
"Detector asap rokok" then it will fail.
If we combine them, we have alerted word which will send to the team when have a blacklisted word.
Then the team can look at actual product and decide what next.

Regarding

Merchant CANNOT sell items that are prohibited by the TokoBapak system

Will there be a moderation team to regularly check or do we use form validation to see if the product name has blacklisted words (e.g. "rokok") in it before submitting?

Nice catch, both should be good. Dedicated won't catch all of it. Blacklisted word not gonna work, if you sell
"Detector asap rokok" then it will fail.
If we combine them, we have alerted word which will send to the team when have a blacklisted word. Then the team can look at actual product and decide what next.

Having a team to filter and block out blacklisted word will be something that we (as TokoBapak) can't afford as we probably won't maintain the application that much.
But, if we're just using some NLP tooling (which probably would work if we're just doing English texts), it will be a bit of a work since we're going to need tokenization and dictionary on Indonesian words. And it doesn't stops there, since Indonesian dictionary usually only covers formal words, not words that are made up by viral stuff or some slangs like South Jakarta made-up-words, or something similar.


Design Linting for OpenAPI Authoring

The ability to lint an OpenAPI using a common set of rules within API builder.

We are working on a set of rules to power linting.

Rules Project Site
Rules Project Repo

We have a workspace with collections that lint OpenAPI currently under development to allow for develop and build time linting.

Design time linting in the Postman API builder is currently under development, will be available in beta within a month, and we should have something for customers to use by the end of the year.

Added Action - https://apis.how/actions/lint-openapi-using-rules-in-api-builder/


Move correlation vector vcpkg consumption to central vcpkg if registry port is approved

Following #133
Move correlation vector vcpkg consumption to central vcpkg if registry port is approved. Then remove local custom port.
https://www.github.com/microsoft/vcpkg/pull/37282

Port has been merged to latest vcpkg.


Update/remove new model registration from utils.run_test()

Update utils.run_test() following changes in register_result().
See this: https://github.com/HumanBrainProject/hbp-validation-client/pull/2/commits/2dc2fb270f0ae155f6e8c4bedfba70766491ea75
No longer need to handle model registration within utils.run_test() as this is now done in register_result().

Closed via #28


Phil eval speedup2

The size of the olds/news list occurring in the Constr.eval function seems to be a major source of slowdown. One step towards correcting this is to use a map data structure. Because without looking deeper under the hood the Z3 ocaml api only accepts lists, It appears to be most efficient to still maintain olds/news as lists for the moment, but we can prune multiple occurrences of the same keys in the olds list. In addition, it appears that moving the most recently changed variables to the head of the olds list speeds things up by making it faster to find commonly used variables. One problem is that bap is generating virtual memory addresses which increase the sizes of the lists but cannot be easily garbage collected, despite being accessed very rarely (often only once or twice).
I believe every time Expr.substitute is called the olds/news list are traversed and unpacked into an array for z3 internal use.
The list processing and Expr.substitute functions are still the bottleneck in the slow examples I've looked at.
Possibilities for further improvements:

The new expression being processed in Subst(c, old, new) rarely contains more than a few variables. It is possible to traverse the expression and fill olds/news only with the variables needed for. This allows the use of efficient Map data structures. Doing this naively was found to be more complicated, of questionable correctness, and not much faster. Now instead of lots of time being spent in Expr.substititue a lot of time was spent in the variable collection pass. I think this could be made more efficient by peeking under the z3 api to the z3native module. The Map structures were not all that fast either compared to the simple most recently accessed element of list strategy discussed above as Expr.compare is not super cheap or too often used.

Tests are passing, so I have no problems with these changes. The logic makes sense to me, but having Cody take a closer look will make me feel better. Just a small nitpick, but can you keep the lines of code to about 80-90 characters long and run ocp-indent on this?
I'm excited for the speedup! 🎉

I'm sorry, but I feel that there are some small, but non-trivial structural issues with the code. As far as I can tell, it's correct, but there's code duplication and I feel like there might be some opportunity to use Core libraries to a fuller extent, though indeed there doesn't seem to be a generic "remove at positioni" function.
In the interest of maintainability, I'd suggest re-factoring things a bit further.
I can help if you feel frustrated by doing this yourself.


If an EDS update replaces all localities in a priority, go into CONNECTING

This fixes the problem whereby we were failing RPCs with "no ready locality map" errors during this transition.

Known failures: #22185 #22340 #22341 #20677 #13379
The Python MacOS failure is an infrastructure timeout.


Bench with multi-subject not multi publisher aware

When using multi-subject and bench to stress a KV, if you use multiple publishers they stomp on each other.
e.g. send 1M messages with 20 publishers only gives you 50k keys.

--multisubject in the bench command doesn't apply to KV testing, instead you should use the --kv flag which works even if you have multiple publisher.
e.g.
nats bench testkv --pub 20 --kv --msgs 1000000 --no-progress
12:59:03 KV mode, using the subject name as the KV bucket name. Publishers do puts, subscribers do gets
12:59:03 Starting KV benchmark [bucket=testkv, kv=true, msgs=1,000,000, msgsize=128 B, maxbytes=1.0 GiB, pubs=20, sub=0, storage=memory, replicas=1, pubsleep=0s, subsleep=0s]
12:59:03 Starting KV putter, putting 50,000 messages
etc...

nats kv info testkv
Information for Key-Value Store Bucket testkv created 2022-07-29T12:56:12-07:00

Configuration:

         Bucket Name: testkv
        History Kept: 1
       Values Stored: 1000000
  Backing Store Kind: JetStream
         Description: nats bench bucket
 Maximum Bucket Size:<PHONE_NUMBER>
  Maximum Value Size: -1
    JetStream Stream: KV_testkv
             Storage: Memory

When. you use --multisubject right now indeed each publisher has it's own subject generator starting at 0, so are you asking to have all of them to start at a different offset? (however --multisubjectmax would still apply 'overall')


underscore in operation id

input json file:
operationId": "sample_getInfo
expected output:
sample_getInfo
actual output:
sampleGetInfo
Please add option like "--allow-special-character".

I guess you can do it with using hooks or templates


Cache the list of files for "Go to file" / "Quick open" / "Search files by name"

Not sure what's the official name for this feature. The file picker that is bound to Ctrl+P.
Right now, it seems that the file picker does a ripgrep search every time to get the list of files in the repo — on my machine, it takes about 2 seconds. I have 100k files in the repo. I'm using Windows 10.
This is similar to the speed of git ls-files -o ("list files including untracked"), so it's probably not ripgrep's fault.
The repository changes very rarely and so caching the list of files would help a lot. I don't know if Windows supports folder watching, but if it does, the cache could be updated in realtime.

@TylerLeonhardt do we currently do any caching in the picker on your side? I thought I saw some code about caching there before.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

No we don't do any caching today. I worry that this would be very expensive to maintain in memory especially for larger repos.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

In my case, the repo isn’t that large (100k files), and there’s enough RAM (64gb), but file enumeration on Windows for whatever reason is rather slow. It’s much faster on Linux, but I’d like to keep using Windows for this project.
So if there was an option to enable caching of the file list, I would definitely use it. Of course, I can imagine that if I had less RAM and more files, I would want to keep it off.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

so there are a couple things at play here

editor history picks - super fast: https://github.com/microsoft/vscode/blob/ca19ca605b3a2f4e2a87f4d787905861be6ffd19/src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts#L432-L443
slow picks: we defer to search (but looks like we pass in a cache key): https://github.com/microsoft/vscode/blob/ca19ca605b3a2f4e2a87f4d787905861be6ffd19/src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts#L631-L639

So we do cache things... but in search land. So I'm passing this to you @andreamah.


Fix: API v2/paths/get with nested path always results in 404

Getting path information for nested paths always fails and gives a 404. This PR fixes this problem

Thanks for spotting and fixing this bug - could you do the same for these endpoints too?
/v2/config/paths/add/*name
/v2/config/paths/edit/*name
/v2/config/paths/remove/*name
/v2/hlsmuxers/get/:name

Only the /v2/hlsmuxers/get endpoint was affected, pushed the fix for that as well

merged, thanks!


Windows AD authentication and login screen

Configured the IdentityServer as per the documentation here , http://docs.identityserver.io/en/latest/topics/windows.html
Trying with asp.net mvc web client. Not seeing any button for windows authentication? Am I expected to see a button in the external authentication in http://localhost:5000/Account/Login?

Yes it should appear automatically if you are using our sample UI -

Also the virtual directory in IIS (or IIS Express) must have Windows and anonymous authentication enabled.

@sowsan : If you are using .Net Core 2.2, the default Kestrel server is replaced with IISHttpServer. Use the following code and run your project with IISExpress
services.Configure<IISServerOptions>(iis =>
{
iis.AuthenticationDisplayName = "Windows";
iis.AutomaticAuthentication = false;
});


Fixed name validation in Love Calculator

Fixes Issue🛠
Closes #367
Description👨💻
The calculator was calculating love percentage of numbers, but after validation now, it takes only characters and spaces between them.
Type of change📄

[x] Bug fix (non-breaking change which fixes an issue)

How this has been tested✅
Tested in my own editor.
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

Merged, Congrats on getting your PR merged to this repo under SWOC S4 🎉🎉 @student-aditipaliwal


First TLS implementation

First tokio modbus implementation to the new specification Modbus TCP Security, based on TLS.

Certificates (especially private keys) do not belong into the repo.
Heavy duplication of code for implementing a cross-cutting concern doesn't seem to be right.

If it works for your use case you may use a private fork until someone comes up with generic and extensible solution that is suitable for everyone.
I recommend to close this PR. Otherwise someone else please step in to review it.

I believe the project should have an implementation of the new Modbus Secure standard, because since 2019 new products with Modbus TCP are not recommended due the various security issues. Certificates were added for test purposes, but I can remove them. The implementations of the MODBUS TCP and RTU servers already have a lot of code duplication, so I followed the project pattern. If the project maintainers believe that my code is not generic enough, I recommend that there is soon an implementation of this standard which was disclosed in 2018.

TCP and RTU are different transport layers that require different frames and codecs.
TLS only affects the way how TCP connections are established, but otherwise both frame and codec are unaffected. Please eloborate if this is not the case. I don't see any difference in the code you submitted.

I got your point. I reduced code duplication considerably by removing the tls codec and frame implementation files, which really could be the same as tcp.

I removed the Certificates as well.

I beleive that now the code is 100% compatible with Modbus Security and has a minimal of code duplication.

The server-side implementation could now be provided as an example after #159 has been merged.
The client-side API modifications required for supporting TLS connections are an open issue, see #161.

Hint: Loading certificates from the file system is very limiting even without hard-coded paths. What works for your particular use case might not work for all other use cases.


python310Packages.mkdocstrings-python: 0.10.0 -> 0.10.1

Changelog: https://github.com/mkdocstrings/python/blob/0.10.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 231134 run on x86_64-linux 1

1 package marked as broken and skipped:

netbox_3_3

5 packages built:

netbox
python310Packages.mkdocstrings-python
python310Packages.mkdocstrings-python.dist
python311Packages.mkdocstrings-python
python311Packages.mkdocstrings-python.dist


Restructure code to make it pip installable

This PR changes the code structure to make it pip-installable . That way, it's easier to use and easier to package for others.
The change still keeps compatibility so AWS documentation is still valid.

cc @agraf

I tested this now with:

just downloading the repo and using directly ./uefivars.py (as documented by AWS):

$ ./uefivars.py -i none -o aws -O your_binary_blob.bin -P ~/tmp/kp/PK.esl -K ~/tmp/kp/KEK.esl --db ~/tmp/kp/db.esl --dbx /usr/share/secureboot/updates/dbx/dbxupdate_x64.bin
Read 0 variables
Writen 4 variables

installing it in a venv and execute it from there:

$ virtualenv venv && source venv/bin/activate && pip install -e .
$ which uefivars.py
~/devel/python-uefivars/venv/bin/uefivars.py
$ uefivars.py -i none -o aws -O your_binary_blob.bin -P ~/tmp/kp/PK.esl -K ~/tmp/kp/KEK.esl --db ~/tmp/kp/db.esl --dbx /usr/share/secureboot/updates/dbx/dbxupdate_x64.bin
Read 0 variables
Writen 4 variables

So both variants seem to work now.

@agraf I think this is now ready for review.

@agraf friendly ping...

@agraf @kernelmoja friendly ping ...

Thank you so much for the contribution and sorry for the delay in responses!


feat: make prometheus config startServer mandatory

Which problem is this PR solving?
There are a couple of reasons to leave the PrometheusExporterConfig.startServer false by default. First, it is async so we have another call that a user can do asynchronously so they can ensure it actually started. Second, it grabs a port on the host computer. This type of thing is best left explicit so the user is not surprised.
However, by most situations (and in examples), the startServer config was mostly set to true. And it is quite easy to forget to set the config and failed to find the Prometheus working as expected.
Short description of the changes

the config startServer is typed as a mandatory field of PrometheusExporterConfig so that typescript can complain about missing explicit startServer config.

By default anything what is boolean and is not defined is simply false

Maybe a better option is to rename startServer to preventServerStart or something?

I would argue that boolean parameter should be ever required. By default anything what is boolean and is not defined is simply false, we should not change it, In js if user doesn't define config we will have "an object undefined exception", I don't see any reason why we should have it. And just writing everywhere
startServer: false

doesn't look very intuitive why would you even want that

@legendecas what do you think about inverting the name to preventStartServer or similar?

By default anything what is boolean and is not defined is simply false

Maybe a better option is to rename startServer to preventServerStart or something?

Why the change? preventServerStart: false feels double negativish imho

By default anything what is boolean and is not defined is simply false

Maybe a better option is to rename startServer to preventServerStart or something?

serverless? 😄

@dyladan  what do you think about inverting the name to preventStartServer or similar?

I'm good with that, will do a quick update late today. But I'm wondering what the use case will be if we set preventStartServer: true?

@legendecas we could just remove the option entirely, but then there is no way for the user to stop the exporter from grabbing a port. The usecase is admittedly entirely theoretical, but one could imagine a user that wants to defer server start until some precondition is met like waiting for a port to become available.

@dyladan @obecny @naseemkullah the startServer option has been replaced by preventServerStart, which is false by default -- starting server by default. PTAL :)

is this still a breaking change now @dyladan  ?


7 byte UID support and some small quality of live improvements

Resolves:

#36: by moving version into setup.py, not nicest, but good enough for this library
#27: through the work from @cmur2 and some small improvements from me
#57: Makes the IRQ pin optional

It requires some small modifications in readme and setup.py (URLs), but should be fine to merge.

Would there be interest in merging this if I worked to fix the print statement?


[Question] Set currency symbol and decimal separator in money mask

Hi,
Is it possible to change the currency symbol and the decimal separator in money-mask?
I checked the release demo and commented the tag angular-locale_pt-br.js that uses the R$ symbol and now it is using just $ symbol.
But I also need colon decimal separator instead of dot, like this:
$ 1.234,56
Thanks in advance.
Greetings

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

You can set the currency symbol using the  currency-symbol="$" in your directive. Replace "$" with your symbol of choice. https://github.com/assisrafael/angular-input-masks/pull/203
Not sure of decimal separator

Hi @Yoshi9143,
Yes, I've changed this config file used in demo/index.html and set there currency symbol and the decimal separator.
Thanks 👍


Headline variable [Enhancement]

Could we add a headline variable?
Rename based on the headline?
That would be amazing, thanks 😊

Do you mean the first heading like # My heading in the markdown file?

Implemented in 1.6.0, check the release log for more details.


Property pane always gets opened once Tab is reloaded.

I am able to add an SPFx webpart as a 'tab application' in Microsoft Teams however, I am facing a strange issue with one of my tabs. Whenever the tab is reloaded (by clicking on the tab or 'Refresh' button), property pane gets opened. This is not happening with all of the tabs but just one particular tab. Is there some setting related to this in 'manifest.json' to prevent the property pane from getting opened on every reload, that i might be missing?
Any help is appreciated.
Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Property pane should be open just once while the tab is being added, on subsequent tab reloads it should not get opened.
Observed Behavior
Property pane always gets opened once Tab is reloaded. Just to check, I have also added the same Webpart on a page in SharePoint as well where property pane doesn't get opened upon page refresh/reload.

If the SPFx web part has settings to configure then they will be displayed when the tab is added, just like how a tab with a configuration option always shows it before adding the tab. But it shouldn't show every time.
However, I can't replicate what you describe... works as expected from my POV: add the tab, settings appear, then they don't show again unless you select the Settings context menu from the tab.
Suggest recording a screencast and pasting the video as a comment to show what you're seeing...

@andrewconnell Thanks for replying. One thing i missed here that i identified later was, this is always happening for the webparts that are configured to be hosted in an isolated domain. However, property pane for the wabparts with non-isolated domain, works fine for me as well.


(feature) Support multiple tags for Mailgun

I added a MailgunHelper with
a tag function (https://github.com/thoughtbot/bamboo/pull/490), but it currently only supports a single tag.
(aa4a22)
I believe https://github.com/thoughtbot/bamboo/issues/469 is a prerequisite. As far as I can tell, Mailgun only supports multiple tags via multiple o:tag values

#469 is indeed a prerequisite because the headers are stored as a map in %Email{}, meaning each key is unique.


Soft link causes doctoc to crash.

I have a valid soft link in my directory and when I run doctoc, it says there isn't a directory there and then quits. Let me know if you need anymore info!

Could you please provide a repo on github that reproduces this?
Make it so in order to repro all I'd have to do is clone the repo followed by:
npm install
npm test

Thanks.

Closing feel free to submit a PR that fixes that -- possibly upgrading readdirp and making it use graceful-fs could work.

Sounds good. Sorry. Been a bit busy :)
————
Daniel L. Polanco
Fledgling Programmer | Perl | C++
719-422-3765 | Website | GitHub | Twitter | Safe Email
————
On Feb 5, 2015, at 9:04, Thorsten Lorenz<EMAIL_ADDRESS>wrote:

Closing feel free to submit a PR that fixes that -- possibly upgrading readdirp and making it use graceful-fs could work.
—
Reply to this email directly or view it on GitHub.


[WIP][RFC] Remove validation of image_tlv_info

When using protected TLVs (for dependencies) the image validation was run over header + payload + tlv_info + protected TLVs. As a side-effect it was impossible to update the TLVs without rehashing (+ resigning) an image. This updates the validation routine to skip the tlv_info, so that hashing is run over header + payload + protected TLVs.
Fixes #539.
This is WIP, needs rebase after #549 is merged; imgtool and documentation changes in progress.

@tamasban @davidvincze This might interest you.

Now everything was updated to work with the new protected TLVs; I have not tested the updated imgtool in HW yet but the hexdumps look OK!

@d3zd3z @nvlsianpu @tamasban @davidvincze I tested a bunch of combinations of options on single image HW and now everything looks good. I'll try to do some testing of dependencies in multi image but if someone would be able to help, I'd be glad. Removing WIP.

The only suggestion I'd make is maybe being a little more consistent with the git subjects, e.g. starting the ones on the simulator with "sim: ", which I've been trying to be more consistent with.

The only suggestion I'd make is maybe being a little more consistent with the git subjects, e.g. starting the ones on the simulator with "sim: ", which I've been trying to be more consistent with.

Yes, that looks pretty good, I just updated the subject line of all commits (but design doc).


[SPARK-18274][ML][PYSPARK] Memory leak in PySpark JavaWrapper

What changes were proposed in this pull request?
InJavaWrapper 's destructor make Java Gateway dereference object in destructor, using SparkContext._active_spark_context._gateway.detach
Fixing the copying parameter bug, by moving the copy method from JavaModel to JavaParams
How was this patch tested?
import random, string
from pyspark.ml.feature import StringIndexer

l = [(''.join(random.choice(string.ascii_uppercase) for _ in range(10)), ) for _ in range(int(7e5))]  # 700000 random strings of 10 characters
df = spark.createDataFrame(l, ['string'])

for i in range(50):
    indexer = StringIndexer(inputCol='string', outputCol='index')
    indexer.fit(df)

Before: would keep StringIndexer strong reference, causing GC issues and is halted midway
After: garbage collection works as the object is dereferenced, and computation completes
Mem footprint tested using profiler
Added a parameter copy related test which was failing before.

Test build #68478 has started for PR 15843 at commit a493c19.

Test build #68482 has started for PR 15843 at commit f25b099.

Test build #68478 has finished for PR 15843 at commit a493c19.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68478/
Test FAILed.

Test build #68482 has finished for PR 15843 at commit f25b099.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68482/
Test PASSed.

cc: @jkbradley @davies @holdenk

Thanks a lot for finding & reporting this!  The fix should probably go in JavaWrapper, not JavaModel, right?
I tested this manually (in JavaWrapper), and it seems to fix the problematic case with StringIndexer.

@jkbradley yes I did it for JavaWrapper first, but try running tests with it gives https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68478/consoleFull

You're right!  It's another bug: copy should be implemented in JavaParams, not JavaModel.  I'm sending this PR to fix that: https://github.com/techaddict/spark/pull/1
Can you please check it out and merge it into your PR if it looks OK to you?  All pyspark.ml tests ran successfully with it.

@jkbradley looks good, merged 👍

Test build #68513 has started for PR 15843 at commit 3d858a2.

Test build #68514 has started for PR 15843 at commit dc5aee3.

Test build #68513 has finished for PR 15843 at commit 3d858a2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68513/
Test PASSed.

Test build #68514 has finished for PR 15843 at commit dc5aee3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
final class ParquetLogRedirector implements Serializable
  case class OutputSpec(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68514/
Test PASSed.

LGTM with minor doc comment.

Test build #68515 has started for PR 15843 at commit 01a80b9.

Test build #68516 has started for PR 15843 at commit a76a1fb.

Test build #68515 has finished for PR 15843 at commit 01a80b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68515/
Test PASSed.

Test build #68516 has finished for PR 15843 at commit a76a1fb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68516/
Test PASSed.

Merged build finished. Test PASSed.

So this change looks good to me, but it seems like it fixes more than just the bug described in the JIRA & PR description with @jkbradley's change integrated (namely the issue with param copy which we have). For people who are looking for what's changed between versions it might make sense to explain the copy related fix the PR description as well since that is what is used in the commit log.

@holdenk updated the description.

LGTM thanks for fixing this @techaddict :D :)

ping @davies if you have time for final review/merge?

Good point @holdenk --- @techaddict could you also please update the PR title to say "JavaWrapper" instead of "StringIndexer"?

I'm now wondering if __del___ should be in JavaParams instead of JavaWrapper since JavaWrapper does not override copy.  Do yall agree it will be safer if it's moved there?

@jkbradley Sounds making sense more.

I'm not so sure about that, we still would want to cleanup the underlying Java reference object on delete if it isn't needed anymore. I think the question is do we want to support shallow copy of javawrapper objects?

Oh. I thought JavaWrapper is only used on JavaParams. But there are also others like LogisticRegressionSummary which directly inherits JavaWrapper.

I don't see a need to do deep copies of model summaries, but I agree I don't like how JavaWrapper is ambiguous about whether it does shallow or deep copies.
I'd say the confusion comes from us having a mix of immutable Java types (like model summaries) and mutable Java types (like Params subclasses).  What do you think of these 2 options?

Distinguish mutability within Python wrappers: JavaWrapper is usable for immutable types.  JavaParams (or other subtypes, if needed) is usable for mutable types.  I.e., __del__ and copy go in JavaParams.
Distinguish mutability within Java only: Use the same wrapper types for both in Python, and Java copy methods can do deep or shallow copies.  I.e., in JavaWrapper, implement copy() which copies the Java instance, and implement __del__ to release that instance's handle.

I don't think either option does much for enforcing these semantics.  Barring GC issues, I'd pick option 1 since it's simpler.  But if option 2 is better for GC issues, then I'd vote for it.
Thoughts?

I'd prefer option2 for safety since the model summaries should be an issue for GC. And looks like Java model summaries don't have copy method.

From the Py4J documentation it seems like we could be leaking memory with the first option, although perhaps not a lot of memory, but if it was being used in an iterative Python algorithm for training many models it could start to have some impact. I'd be in favor of option 2, but that could be done as a follow up issue if the required copy methods aren't generally available.

@jkbradley @holdenk @techaddict Do we want to implement copy() in JavaWrapper in this PR too? Or separate it to follow ones with the required copy methods on JVM side?

Sorry for the slow response on this.  Given the time pressure for 2.1, let's go with option 1 for now with a follow-up task to implement option 2.  It would be great to include this fix in 2.1.
@techaddict will you have time to update your PR quickly?  Thank you!

I agree, for a follow up (so we don't lose track of it) - I've created SPARK-18630 but option 1 for now is a strict improvement over the current situation. Thanks for all of your work on this @techaddict

@jkbradley @holdenk will update the PR with changes today.

Test build #69476 has started for PR 15843 at commit 37e83e8.

Test build #69476 has finished for PR 15843 at commit 37e83e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69476/
Test PASSed.

@jkbradley @holdenk @viirya PR updated

LGTM

LGTM too
Thanks a lot!
Merging with master, branch-2.1, branch-2.0
Has anyone heard of complaints of this in current use cases of earlier branches?  If not, I won't backport it further than 2.0.


[Bug] Broken link in Frontend Roadmap

Description
The link of one of the communities is broken in the Join communities section.

Screenshots
https://user-images.githubusercontent.com/97666287/228747652-48406474-78be-42b3-91a1-694d846d6b55.mp4
Additional information
No response

Created  a PR for the same. Kindly Approve #493

Closing as fixed


1035-docs

WIP
#1035

[x] get all operations in list, split into two groups: preprocessing operations and models
[x] add the table with models/operations for class/regr/forecasting tasks

[x] determine the place for the table in the documentation
[ ] link selected sections in the documentation

[x] add available_operations list to fedot.api.builder.FedotBuilder.setup_pipeline_structure docstring (fd1db3dffabd2e9f328125c1b4b866bf27c29948)

Table of data processing operations

API name
Model used
Definition
Problem
Tags

scaling
ScalingImplementation
Scaling
Feature Scaling
['fast_train', ' ts', ' *tree']

normalization
NormalizationImplementation
Normalization
Feature Scaling
['fast_train', ' ts', ' *tree']

simple_imputation
ImputationImplementation
Imputation
Feature Imputation
['fast_train', ' *tree']

pca
PCAImplementation
Principal Component Analysis
Feature Reduction
['fast_train', ' ts', ' *tree']

kernel_pca
KernelPCAImplementation
Kernel Principal Component Analysis
Feature Reduction
['ts', ' *tree']

fast_ica
FastICAImplementation
Independent Component Analysis
Feature Reduction
['ts', ' *tree']

poly_features
PolyFeaturesImplementation
Polynomial Features
Feature Engineering
['']

one_hot_encoding
OneHotEncodingImplementation
Ohe-Hot Encoder
Feature Encoding
['']

label_encoding
LabelEncodingImplementation
Label Encoder
Feature Encoding
['fast_train', ' *tree']

rfe_lin_reg
LinearRegFSImplementation
Linear Regression Recursive Feature Elimination
Feature Selection
['']

rfe_non_lin_reg
NonLinearRegFSImplementation
Decision Tree Recursive Feature Elimination
Feature Selection
['']

rfe_lin_class
LinearClassFSImplementation
Logistic Regression Recursive Feature Elimination
Feature Selection
['']

rfe_non_lin_class
NonLinearClassFSImplementation
Decision Tree Recursive Feature Elimination
Feature Selection
['']

isolation_forest_reg
IsolationForestRegImplementation
Regression Isolation Forest
Feature Filtering
['']

isolation_forest_class
IsolationForestClassImplementation
Classification Isolation Forest
Feature Filtering
['']

decompose
DecomposerRegImplementation
Regression Decomposition
Decomposition
['fast_train', ' ts', ' *tree']

class_decompose
DecomposerClassImplementation
Classification Decomposition
Decomposition
['fast_train', ' *tree']

resample
ResampleImplementation
Resample features
Resampling
['']

ransac_lin_reg
LinearRegRANSACImplementation
Regression Random Sample Consensus
Feature Filtering
['fast_train', ' *tree']

ransac_non_lin_reg
NonLinearRegRANSACImplementation
DecisionTreeRegressor Random Sample Consensus
Feature Filtering
['fast_train', ' *tree']

cntvect
sklearn.feature_extraction.text.CountVectorizer
Count Vectorizer
Text Processing
['']

text_clean
TextCleanImplementation
Lemmatization and Stemming
Text Processing
['']

tfidf
sklearn.feature_extraction.text.TfidfVectorizer
TF-IDF Vectorizer
Text Processing
['']

word2vec_pretrained
PretrainedEmbeddingsImplementation
Word2Vec
Text Processing
['']

lagged
LaggedTransformationImplementation
Lagged Tranformation
Timeseries Tranformation
['fast_train', ' ts']

sparse_lagged
SparseLaggedTransformationImplementation
Sparse Lagged Tranformation
Timeseries Tranformation
['fast_train', ' ts']

smoothing
TsSmoothingImplementation
Smoothing Tranformation
Timeseries Tranformation
['fast_train', ' ts']

gaussian_filter
GaussianFilterImplementation
Gaussian Filter Tranformation
Timeseries Tranformation
['fast_train', ' ts']

diff_filter
NumericalDerivativeFilterImplementation
Derivative Filter Tranformation
Timeseries Tranformation
['fast_train', ' ts']

cut
CutImplementation
Cut Tranformation
Timeseries Tranformation
['fast_train', ' ts']

exog_ts
ExogDataTransformationImplementation
Exogeneus Tranformation
Timeseries Tranformation
['']

Table of operations that are models

API name
Model used
Definition
Problem
Tags

adareg
sklearn.ensemble.AdaBoostRegressor
AdaBoost Regressor
Regression
['fast_train', ' ts', ' *tree']

ar
AutoRegImplementation
AutoRegression
Forecasting
['fast_train', ' ts']

arima
ARIMAImplementation
ARIMA
Forecasting
['ts']

cgru
CGRUImplementation
Convolutional Gated Recurrent Unit
Forecasting
['ts']

bernb
sklearn.naive_bayes.BernoulliNB
Naive Bayes Classifier (multivariate Bernoulli)
Classification
['fast_train']

catboost
FedotCatBoostClassificationImplementation
Catboost Classifier
Classification
['*tree']

catboostreg
FedotCatBoostRegressionImplementation
Catboost Regressor
Regression
['*tree']

dt
sklearn.tree.DecisionTreeClassifier
Decision Tree Classifier
Classification
['fast_train', ' *tree']

dtreg
sklearn.tree.DecisionTreeRegressor
Decision Tree Regressor
Regression
['fast_train', ' ts', ' *tree']

gbr
sklearn.ensemble.GradientBoostingRegressor
Gradient Boosting Regressor
Regression
['*tree']

kmeans
sklearn.cluster.Kmeans
K-Means clustering
Clustering
['fast_train']

knn
FedotKnnClassImplementation
K-nearest neighbors Classifier
Classification
['fast_train']

knnreg
FedotKnnRegImplementation
K-nearest neighbors Regressor
Regression
['fast_train', ' ts']

lasso
sklearn.linear_model.Lasso
Lasso Linear Regressor
Regression
['fast_train', ' ts']

lda
LDAImplementation
Linear Discriminant Analysis
Classification
['fast_train']

lgbm
lightgbm.sklearn.LGBMClassifier
Light Gradient Boosting Machine Classifier
Classification
['']

lgbmreg
lightgbm.sklearn.LGBMRegressor
Light Gradient Boosting Machine Regressor
Regression
['*tree']

linear
sklearn.linear_model.LinearRegression
Linear Regression Regressor
Regression
['fast_train', ' ts']

logit
sklearn.linear_model.LogisticRegression
Logistic Regression Classifier
Classification
['fast_train']

mlp
sklearn.neural_network.MLPClassifier
Multi-layer Perceptron Classifier
Classification
['']

multinb
sklearn.naive_bayes.MultinomialNB
Naive Bayes Classifier (multinomial)
Classification
['fast_train']

qda
QDAImplementation
Quadratic Discriminant Analysis
Classification
['fast_train']

rf
sklearn.ensemble.RandomForestClassifier
Random Forest Classifier
Classification
['fast_train', ' *tree']

rfr
sklearn.ensemble.RandomForestRegressor
Random Forest Regressor
Regression
['fast_train', ' *tree']

ridge
sklearn.linear_model.Ridge
Ridge Linear Regressor
Regression
['fast_train', ' ts']

polyfit
PolyfitImplementation
Polynomial fitter
Forecasting
['fast_train', ' ts']

sgdr
sklearn.linear_model.SGDRegressor
Stochastic Gradient Descent Regressor
Regression
['fast_train', ' ts']

stl_arima
STLForecastARIMAImplementation
STL Decomposition with ARIMA
Forecasting
['ts']

glm
GLMImplementation
Generalized Linear Models
Forecasting
['fast_train', ' ts']

ets
ExpSmoothingImplementation
Exponential Smoothing
Forecasting
['fast_train', ' ts']

locf
RepeatLastValueImplementation
Last Observation Carried Forward
Forecasting
['fast_train', ' ts']

ts_naive_average
NaiveAverageForecastImplementation
Naive Average
Forecasting
['fast_train', ' ts']

svc
FedotSVCImplementation
Support Vector Classifier
Classification
['']

svr
sklearn.svm.LinearSVR
Linear Support Vector Regressor
Regression
['']

treg
sklearn.ensemble.ExtraTreesRegressor
Extra Trees Regressor
Regression
['*tree']

xgboost
xgboost.XGBClassifier
Extreme Gradient Boosting Classifier
Classification
['*tree']

xgbreg
xgboost.XGBRegressor
Extreme Gradient Boosting Regressor
Regression
['*tree']

cnn
FedotCNNImplementation
Convolutional Neural Network
Classification
['']

Hello @Lopa10ko! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file test/integration/models/test_model.py:

Line 508:1: E302 expected 2 blank lines, found 1

Думаю можно добавить в табличку информацию, в какой пресет какая операция попадает. А так очень полезная вещь - действительно был пробел в документации

Думаю можно добавить в табличку информацию, в какой пресет какая операция попадает. А так очень полезная вещь - действительно был пробел в документации

@Lopa10ko Тогда надо будет еще добавить тест на проверку что все существующие пресеты упомянуты в таблицах.

[x] get all operations in list, split into two groups: preprocessing operations and models
[x] add the table with models/operations for class/regr/forecasting tasks

[x] determine the place for the table in the documentation

[x] add available_operations list to fedot.api.builder.FedotBuilder.setup_pipeline_structure docstring (fd1db3dffabd2e9f328125c1b4b866bf27c29948)
[x] add a test that checks whether operations are documented (ba7bdbb6d591888025699374e7a5ef9645580af7)

Table of data processing operations

API name
Model used
Definition
Problem
Tags

scaling
ScalingImplementation
Scaling
Feature Scaling
['fast_train', ' ts', ' *tree']

normalization
NormalizationImplementation
Normalization
Feature Scaling
['fast_train', ' ts', ' *tree']

simple_imputation
ImputationImplementation
Imputation
Feature Imputation
['fast_train', ' *tree']

pca
PCAImplementation
Principal Component Analysis
Feature Reduction
['fast_train', ' ts', ' *tree']

kernel_pca
KernelPCAImplementation
Kernel Principal Component Analysis
Feature Reduction
['ts', ' *tree']

fast_ica
FastICAImplementation
Independent Component Analysis
Feature Reduction
['ts', ' *tree']

poly_features
PolyFeaturesImplementation
Polynomial Features
Feature Engineering
['']

one_hot_encoding
OneHotEncodingImplementation
Ohe-Hot Encoder
Feature Encoding
['']

label_encoding
LabelEncodingImplementation
Label Encoder
Feature Encoding
['fast_train', ' *tree']

rfe_lin_reg
LinearRegFSImplementation
Linear Regression Recursive Feature Elimination
Feature Selection
['']

rfe_non_lin_reg
NonLinearRegFSImplementation
Decision Tree Recursive Feature Elimination
Feature Selection
['']

rfe_lin_class
LinearClassFSImplementation
Logistic Regression Recursive Feature Elimination
Feature Selection
['']

rfe_non_lin_class
NonLinearClassFSImplementation
Decision Tree Recursive Feature Elimination
Feature Selection
['']

isolation_forest_reg
IsolationForestRegImplementation
Regression Isolation Forest
Feature Filtering
['']

isolation_forest_class
IsolationForestClassImplementation
Classification Isolation Forest
Feature Filtering
['']

decompose
DecomposerRegImplementation
Regression Decomposition
Decomposition
['fast_train', ' ts', ' *tree']

class_decompose
DecomposerClassImplementation
Classification Decomposition
Decomposition
['fast_train', ' *tree']

resample
ResampleImplementation
Resample features
Resampling
['']

ransac_lin_reg
LinearRegRANSACImplementation
Regression Random Sample Consensus
Feature Filtering
['fast_train', ' *tree']

ransac_non_lin_reg
NonLinearRegRANSACImplementation
DecisionTreeRegressor Random Sample Consensus
Feature Filtering
['fast_train', ' *tree']

cntvect
sklearn.feature_extraction.text.CountVectorizer
Count Vectorizer
Text Processing
['']

text_clean
TextCleanImplementation
Lemmatization and Stemming
Text Processing
['']

tfidf
sklearn.feature_extraction.text.TfidfVectorizer
TF-IDF Vectorizer
Text Processing
['']

word2vec_pretrained
PretrainedEmbeddingsImplementation
Word2Vec
Text Processing
['']

lagged
LaggedTransformationImplementation
Lagged Tranformation
Timeseries Tranformation
['fast_train', ' ts']

sparse_lagged
SparseLaggedTransformationImplementation
Sparse Lagged Tranformation
Timeseries Tranformation
['fast_train', ' ts']

smoothing
TsSmoothingImplementation
Smoothing Tranformation
Timeseries Tranformation
['fast_train', ' ts']

gaussian_filter
GaussianFilterImplementation
Gaussian Filter Tranformation
Timeseries Tranformation
['fast_train', ' ts']

diff_filter
NumericalDerivativeFilterImplementation
Derivative Filter Tranformation
Timeseries Tranformation
['fast_train', ' ts']

cut
CutImplementation
Cut Tranformation
Timeseries Tranformation
['fast_train', ' ts']

exog_ts
ExogDataTransformationImplementation
Exogeneus Tranformation
Timeseries Tranformation
['']

Table of operations that are models

API name
Model used
Definition
Problem
Tags

adareg
sklearn.ensemble.AdaBoostRegressor
AdaBoost Regressor
Regression
['fast_train', ' ts', ' *tree']

ar
AutoRegImplementation
AutoRegression
Forecasting
['fast_train', ' ts']

arima
ARIMAImplementation
ARIMA
Forecasting
['ts']

cgru
CGRUImplementation
Convolutional Gated Recurrent Unit
Forecasting
['ts']

bernb
sklearn.naive_bayes.BernoulliNB
Naive Bayes Classifier (multivariate Bernoulli)
Classification
['fast_train']

catboost
FedotCatBoostClassificationImplementation
Catboost Classifier
Classification
['*tree']

catboostreg
FedotCatBoostRegressionImplementation
Catboost Regressor
Regression
['*tree']

dt
sklearn.tree.DecisionTreeClassifier
Decision Tree Classifier
Classification
['fast_train', ' *tree']

dtreg
sklearn.tree.DecisionTreeRegressor
Decision Tree Regressor
Regression
['fast_train', ' ts', ' *tree']

gbr
sklearn.ensemble.GradientBoostingRegressor
Gradient Boosting Regressor
Regression
['*tree']

kmeans
sklearn.cluster.Kmeans
K-Means clustering
Clustering
['fast_train']

knn
FedotKnnClassImplementation
K-nearest neighbors Classifier
Classification
['fast_train']

knnreg
FedotKnnRegImplementation
K-nearest neighbors Regressor
Regression
['fast_train', ' ts']

lasso
sklearn.linear_model.Lasso
Lasso Linear Regressor
Regression
['fast_train', ' ts']

lda
LDAImplementation
Linear Discriminant Analysis
Classification
['fast_train']

lgbm
lightgbm.sklearn.LGBMClassifier
Light Gradient Boosting Machine Classifier
Classification
['']

lgbmreg
lightgbm.sklearn.LGBMRegressor
Light Gradient Boosting Machine Regressor
Regression
['*tree']

linear
sklearn.linear_model.LinearRegression
Linear Regression Regressor
Regression
['fast_train', ' ts']

logit
sklearn.linear_model.LogisticRegression
Logistic Regression Classifier
Classification
['fast_train']

mlp
sklearn.neural_network.MLPClassifier
Multi-layer Perceptron Classifier
Classification
['']

multinb
sklearn.naive_bayes.MultinomialNB
Naive Bayes Classifier (multinomial)
Classification
['fast_train']

qda
QDAImplementation
Quadratic Discriminant Analysis
Classification
['fast_train']

rf
sklearn.ensemble.RandomForestClassifier
Random Forest Classifier
Classification
['fast_train', ' *tree']

rfr
sklearn.ensemble.RandomForestRegressor
Random Forest Regressor
Regression
['fast_train', ' *tree']

ridge
sklearn.linear_model.Ridge
Ridge Linear Regressor
Regression
['fast_train', ' ts']

polyfit
PolyfitImplementation
Polynomial fitter
Forecasting
['fast_train', ' ts']

sgdr
sklearn.linear_model.SGDRegressor
Stochastic Gradient Descent Regressor
Regression
['fast_train', ' ts']

stl_arima
STLForecastARIMAImplementation
STL Decomposition with ARIMA
Forecasting
['ts']

glm
GLMImplementation
Generalized Linear Models
Forecasting
['fast_train', ' ts']

ets
ExpSmoothingImplementation
Exponential Smoothing
Forecasting
['fast_train', ' ts']

locf
RepeatLastValueImplementation
Last Observation Carried Forward
Forecasting
['fast_train', ' ts']

ts_naive_average
NaiveAverageForecastImplementation
Naive Average
Forecasting
['fast_train', ' ts']

svc
FedotSVCImplementation
Support Vector Classifier
Classification
['']

svr
sklearn.svm.LinearSVR
Linear Support Vector Regressor
Regression
['']

treg
sklearn.ensemble.ExtraTreesRegressor
Extra Trees Regressor
Regression
['*tree']

xgboost
xgboost.XGBClassifier
Extreme Gradient Boosting Classifier
Classification
['*tree']

xgbreg
xgboost.XGBRegressor
Extreme Gradient Boosting Regressor
Regression
['*tree']

cnn
FedotCNNImplementation
Convolutional Neural Network
Classification
['']


Document everything

Address #49.

Changes Unknown when pulling 8c6987b10e6b40a5d86498c325ff4ab1a9297eca on document-everything into ** on master**.


bug: Error during credential query, error message unhelpful

Describe the bug
I am trying to query for credentials using JSON-RPC API, here's my code:
import { createStore } from 'mipd'

const snapId = 'npm:@blockchain-lab-um/masca';
const store = createStore()
const provider = store.getProviders()[0].provider
const accounts = await provider.request({
  method: 'eth_requestAccounts',
});
const address = accounts[0];
console.log('Address: ' + address);
const snap = await provider.request({
  method: 'wallet_requestSnaps',
  params:
      {
        [snapId]: { }
      },
});
console.log('Snap: ' + JSON.stringify(snap));

const vcs = await provider.request({
    method: 'wallet_invokeSnap',
    params: {
        snapId: snapId,
        request: {
            method: 'queryCredentials',
            params: { },
        },
    },
});

console.log(vcs);

And the output of the logs are:
Address: 0xd9c9e2f655e23a379c1033ffd656723e66431a7f
App.js:20 Snap: {"npm:@blockchain-lab-um/masca":{"blocked":false,"enabled":true,"id":"npm:@blockchain-lab-um/masca","initialPermissions":{"endowment:ethereum-provider":{},"endowment:network-access":{},"endowment:rpc":{"dapps":true,"snaps":true},"endowment:webassembly":{},"snap_dialog":{},"snap_getEntropy":{},"snap_manageState":{}},"version":"1.2.2"}}
App.js:33 {success: false, error: '[object Object]'}error: "[object Object]"success: false[[Prototype]]: Object

So the snap is enabled and the provider is valid, while trying to fetch the credentials I get '[object Object]' error, which doesn't tell me much.
I've tried using Masca connector as well, same thing happens.
Have I run into a real bug or am I just not doing something correctly? If it's the latter, I apologize.
Versions:
├──<EMAIL_ADDRESS>// not used in this code snippt, but same issue
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
To Reproduce
No response
Expected behavior
No response

Hi @c4bade6fdec3d9cb86a281668cbab42b , thanks for reporting the issue.
Before you can use Masca RPC methods, you need to set your current account inside Masca, as switching MetaMask accounts does not change Masca accounts. This can be done like this:
// After your code here
console.log('Snap: ' + JSON.stringify(snap));

// Call this
const response = await ethereum.request({
  method: 'wallet_invokeSnap',
  params: {
    snapId: snapId,
    request: {
      method: 'setCurrentAccount',
      params: {
        currentAccount: address
      },
    },
  },
});

I am not sure if this is the main issue, as I couldn't replicate your error. The error I was getting with your code was:
{
    "success": false,
    "error": "Error: No current account set. Please call the `setCurrentAccount` RPC method first."
}

If I understand correctly you are developing your own dapp, right ? So you are probably testing things on localhost. May I ask which version of MetaMask you are using and which browser you are testing it with ?
Things to note that could help resolve your issue:

MetaMask had a bug on version 11.13.X (resolved in latest version 11.14.0) that broke our Snap.2
We normally test things using Chrome, Brave browser and Chromium, so we recommend you use one of those browsers if possible. We are also aware of some issue of Firefox that we are trying  to resolve, so it could be related to this.

Please report your findings after you try again, and I can try to help you further if the issue persists.

Thanks for pointing out the mistake in the documentation, we will fix 👍. I am also happy we resolved your issue.
Regarding the expired session, this is related to Ceramic (I forgot to mention this in my example, sorry). We handle this inside our Masca Connector and without it you would need to handle it through separate JSON RPC calls. It is easier using Masca Connector.
If you are interested in the details, this are the steps we do inside the Connector SDK:

Install Masca
JSON-RPC call for setCurrentAccount
JSON-RPC call for validateStoredCeramicSession
If Ceramic session is expired or missing we prompt the user to sign a SIWE message which is used for the Ceramic session creation.
JSON-RPC call for setCeramicSession with the session created in step 4

Steps 2 to 5 need to be repeated each time the user changes his MetaMask account.
May I ask what you are building with Masca ? 🚀


feat: preregister libhoney metrics

Which problem is this PR solving?

Fixes #691 by pre-registering metrics generated by libhoney.

Short description of the changes

Pre-register two instances of metrics, once for peers and once for upstream.

Accidentally clicked the wrong response lol


Setup releases for arm-ttk

It would be useful to set up releases for arm-ttk that did the following

Update module version
create a Zip of arm-ttk module
Publish module to PowerShell Gallery
Publish the zip as a release to this repository

This would be helpful as it would allow for organisations & individual developers to make use of arm-ttk much easier in their local & hosted build pipelines

Yes please!
Or at least made the zip file available that is available here come from a github release, so that we can be sure the zip file is updated with the latest from the master branch.

Certainly the gallery is the correct place (we have a task for that) - will take a look at option 4 above and see if we can automate that...


create a google storage bucket for 'android-arm-deploy' and populate it

Related to https://github.com/flutter/flutter/issues/2366, we'll need to create a android-arm-deploy google storage bucket and populate it with build artifacts (likely artifacts from https://github.com/flutter/flutter/issues/3263).

Presumably we'll just copy this function:
https://chromium.googlesource.com/chromium/tools/build.git/+/master/scripts/slave/recipes/flutter/engine.py#106
like we did for the emulators, just this time for --deploy.  We can refactor the functions to share more code as we add more of these.

fixed by @eseidel


Incorrect parameters printing

Often leads to repetition of the same pattern and as a result "too long value"

Happens when ObjectDumper encounters following pattern:
class SomeClass {
private static SomeClass instance = new SomeClass();
}
ObjectDumper starts to spin forever


Remove streamsPrivate usage

This was only ever useful for the Opera extension because the API requires a whitelisted extension ID. Opera ditched PDF.js from their extension gallery, so we don't need to keep this in the tree.
Nothing changed here, just some deletions + re-indented some code. This basically reverts cdadb0db4d5eaaa2d7bd62a5551d191eeb598ef4 from #4126.

Thank you for the cleanup! Verified using Chromium 50.0.2661.94 (64-bit) on Arch Linux.


cnidarium: 🪼 watch_changes regex parameters aren't options (review)

see discussion from #4361, here:
https://github.com/penumbra-zone/penumbra/pull/4361#discussion_r1595614864
NB: this is a PR based on 4360_regex_watch, not against main. because this is largely a subtractive diff when compared against that base branch, see also this diff when compared against main, here: https://github.com/penumbra-zone/penumbra/compare/main...kate/4360_regex_watch.review-24-05-09
diff --git a/crates/cnidarium/src/rpc.rs b/crates/cnidarium/src/rpc.rs
index 72bc796be..a8accb144 100644
--- a/crates/cnidarium/src/rpc.rs
+++ b/crates/cnidarium/src/rpc.rs
@@ -28,6 +28,7 @@ use crate::rpc::proto::v1::{
     WatchResponse,
 };
 use futures::{StreamExt, TryStreamExt};
+use regex::Regex;
 use tokio_stream::wrappers::ReceiverStream;
 use tonic::Status;
 use tracing::instrument;
@@ -127,7 +128,7 @@ impl QueryService for Server {
             .map_err(|e| Status::invalid_argument(format!("invalid key_regex: {}", e)))?;

         // Use the `bytes` regex to allow matching byte strings.
-        let nv_key_regex = regex::bytes::RegexBuilder::new(&request.key_regex)
+        let nv_key_regex = regex::bytes::RegexBuilder::new(&request.nv_key_regex)
             .size_limit(MAX_REGEX_LEN)
             .unicode(false)
             .build()

This seems to be the original behavior, where if you supply a regex for one of the storage types, you get all events for the other storage type unfiltered. This seemed undesirable to me when I was using the interface, typically if you're supplying a regex you want something to see something very specific so I made it exclude the other storage type. But I'm open to changing my mind on this.

This seems to be the original behavior, where if you supply a regex for one of the storage types, you get all events for the other storage type unfiltered. This seemed undesirable to me when I was using the interface, typically if you're supplying a regex you want to see something very specific so I made it exclude the other storage type. But I'm open to changing my mind on this.

that makes sense, i'll go ahead and close this out. thanks for elaborating, i'm glad a diff helped suss this out!


Define the IAM Task or Instance Role for Packer

See: https://www.packer.io/docs/builders/amazon.html#iam-task-or-instance-role
This should probably be a separate terraform project for setting up some sane AWS defaults.

Testing this manually for now: artisanal

This should probably be the image-builder-account-tf
This would be the thing that creates the AWS account under the OU for packer to build images.

[ ] Create the account (we can't do this yet... thanks NSD)
[ ] Create the policy
[ ] Create the user with the policy

This has been completed and is documented in the README.


Add ARP responder for both L2 and L3 neighbors

When ACA receives L2 and L3 neighbor configuration from Alcor controllers, it contains the IP and MAC mapping for each L2 and L3 neighbor. We can program the arp responder using openflow rule. The plumbing is being added using openflow table 51:
ovs-ofctl add-flow br-tun "table=0,priority=25,arp,arp_op=1,in_port="patch-int" actions=resubmit(,51)"
ovs-ofctl add-flow br-tun "table=51,priority=1,actions=resubmit(,22)"
The arp responder rule would look like:
ovs-ofctl add-flow br-tun "table=51,priority=50,arp,dl_vlan=1,nw_dst=<IP_ADDRESS> actions=move:NXM_OF_ETH_SRC[]->NXM_OF_ETH_DST[],mod_dl_src:02:42:ac:11:00:01,load:0x2->NXM_OF_ARP_OP[],move:NXM_NX_ARP_SHA[]->NXM_NX_ARP_THA[],move:NXM_OF_ARP_SPA[]->NXM_OF_ARP_TPA[],load:0x0242ac110001->NXM_NX_ARP_SHA[],load:0x0a000001->NXM_OF_ARP_SPA[],in_port"
To support cloud scale, we will not want to plumb down all the arp responder rules until it is needed. Therefore the logic would look like:

All the arp request packets sends to table 51
match existing arp responder on demand rule which has an idle timer of 60s
if no match, send to openflow controller, that's ACA for lookup
3a. ACA found correspond IP to MAC mapping, program the on demand matching rule for 2, send the packet back for normal switch processing
3b, ACA didn't find correspond IP to MAC mapping, program the on demand passthrough rule for 2, send the packet back for normal switch processing, need to handle the situation where the IP to MAC mapping got programmed into ACA when on demand rule is there, need to remove the on demand rule

@er1cthe0ne I don't clearly understand  what we need to do in 3b

need to remove the on demand rule

Could you explain it to me?

Could you explain it to me?

@lly00 I have updated the discription on this issue based on the current thinking. Please take a look.

@lly00 - I confirmed in the code that we have access to vlan of the packet. Please see the first session of the below function in aca_ovs_control.cpp:
void ACA_OVS_Control::parse_packet(uint32_t in_port, void *packet)
You may need to modify that function to extract the vlan and pass it into your new functions.

@lly00 - I confirmed in the code that we have access to vlan of the packet. Please see the first session of the below function in aca_ovs_control.cpp:
void ACA_OVS_Control::parse_packet(uint32_t in_port, void *packet)
You may need to modify that function to extract the vlan and pass it into your new functions.

Okay, I'll take a look

@lly00 - please focus on doing the ARP responder for L2 neighbors. When a port trying to ARP is L3 neighbor, it would simply ARP its default gateway.