[bug] Missing required param site_id

- Do you want to request a feature or report a bug?
Report a bug
- What is the current behavior?
running netlify deploy  and following the prompts to select an existing site raises an error.
Site id saved to D:\Web\itscosmas\.netlify\state.json

You can now run other `netlify` cli commands in this directory
Deploy path: D:\Web\itscosmas\.netlify\build
Deploying to draft URL...
√ Finished hashing 0 files
- CDN diffing files... »   Warning:
 »   {}
 »
\ CDN diffing files...Error: Missing required param site_id
    at Object.values.forEach.param (C:/Users/Cozy/AppData/Roaming/npm/node_modules/netlify-cli/node_modules/netlify/src/open-api/index.js:34:15)
    at Array.forEach (<anonymous>)
    at NetlifyAPI.createSiteDeploy (C:/Users/Cozy/AppData/Roaming/npm/node_modules/netlify-cli/node_modules/netlify/src/open-api/index.js:28:43)
    at module.exports (C:/Users/Cozy/AppData/Roaming/npm/node_modules/netlify-cli/node_modules/netlify/src/deploy/index.js:77:26)

**_ Additional information
on the .netlify/state.json file under I see the site id is set as {  "siteId":"<the id string>" }
*_ Suggestion

This could be an issue with camelCase and snake_case for the site_id param
Inside the .netlify folder there's a build folder, when deploying my reacts apps the netlify cli used to ask for the directory then I'd point it to my build to deploy but it doesn't ask in this latest update.

- What is the expected behavior?
Site should deploy normally without any issue
- Local Environment Information
This is on Node v10.16.3

Can you share the repo / directory structure of the site you are trying to deploy?
Also what operating system is this running on?
Thanks!

Using the create-react-app directory structure in this repo https://github.com/ItsCosmas/itscosmas.
Had this issue on Windows 10 Node v10.16.3 and on Ubuntu 18.04 LTS Node v10.17.0.
Also kindly notice that I'm able to reproduce this exact issue after removing the .netlify folder and running the netlify deploy command again.
However if I run the deploy command with the .netlify folder present this is log the error I get, Please Note it doesn't prompt me to enter the deploy path, also not sure if this comment exposes potential risky private data.

Deploy path: /home/cozy/projects/itscosmas/.netlify/build
Deploying to live site URL...
✔ Finished hashing 0 files
✔ CDN requesting 0 files
✔ Finished uploading 0 assets
└ Waiting for deploy to go live... ›   Warning:
 ›   {
 ›      "deploy": {
 ›        "id": "5deeb25d704548019e678c3b",
 ›        "site_id": "7caf2c76-ee2c-4dc0-a183-4720462ad346",
 ›        "build_id": null,
 ›        "state": "error",
 ›        "name": "itscosmas",
 ›        "url": "https://itscosmas.me",
 ›        "ssl_url": "https://itscosmas.me",
 ›        "admin_url": "https://app.netlify.com/sites/itscosmas",
 ›        "deploy_url": "http://5deeb25d704548019e678c3b.itscosmas.netlify.com",
 ›        "deploy_ssl_url": "https://5deeb25d704548019e678c3b--itscosmas.netlify.com",
 ›        "created_at": "2019-12-09T20:45:17.915Z",
 ›        "updated_at": "2019-12-09T20:46:19.371Z",
 ›        "user_id": "5d398431bf72167015602afc",
 ›        "error_message": "Deploy canceled",
 ›        "required": [],
 ›        "required_functions": null,
 ›        "commit_ref": null,
 ›        "review_id": null,
 ›        "branch": null,
 ›        "commit_url": null,
 ›        "skipped": null,
 ›        "locked": null,
 ›        "log_access_attributes": {
 ›          "type": "firebase",
 ›          "url": "https://netlify-builds3.firebaseio.com/deploys/5deeb25d704548019e678c3b/log",
 ›          "endpoint": "https://netlify-builds3.firebaseio.com",
 ›          "path": "/deploys/5deeb25d704548019e678c3b/log",
 ›          "token": "tdzrkqHD5fgw8tGRytePPiRpzfNivfSRx08xHYKm"
 ›        },
 ›        "title": null,
 ›        "review_url": null,
 ›        "published_at": null,
 ›        "context": "production",
 ›        "deploy_time": null,
 ›        "available_functions": [],
 ›        "summary": {
 ›          "status": "unavailable",
 ›          "messages": []
 ›        },
 ›        "screenshot_url": null,
 ›        "site_capabilities": {
 ›          "title": "Netlify Team Free",
 ›          "asset_acceleration": true,
 ›          "form_processing": true,
 ›          "cdn_propagation": "partial",
 ›          "build_gc_exchange": "buildbot-gc",
 ›          "build_node_pool": "buildbot-external-ssd",
 ›          "domain_aliases": true,
 ›          "secure_site": false,
 ›          "prerendering": true,
 ›          "proxying": true,
 ›          "ssl": "custom",
 ›          "rate_cents": 0,
 ›          "yearly_rate_cents": 0,
 ›          "cdn_network": "free_cdn_network",
 ›          "ipv6_domain": "cdn.makerloop.com",
 ›          "branch_deploy": true,
 ›          "managed_dns": true,
 ›          "geo_ip": true,
 ›          "split_testing": true,
 ›          "id": "nf_team_dev"
 ›        },
 ›        "committer": null,
 ›        "skipped_log": null,
 ›        "manual_deploy": false
 ›      }
 ›   }
 ›
Error: Deploy 5deeb25d704548019e678c3b had an error
    at loadDeploy (/usr/lib/node_modules/netlify-cli/node_modules/netlify/src/deploy/util.js:92:29)
├ Waiting for deploy to go live...

actually I have faced this issue with another app that was otherwise deploying okay through the cli since like 2 or 3 days ago after cli update.

Unfortunately this issue is very old. You need to run the command twice or run netlify link before deploy. I don't like it either, but that's what works for me.

Unfortunately netlify link or running the command twice doesn't work for me and thus I've resulted to using netlify CI/CD instead of the  cli for the moment.

Unfortunately this issue is very old. You need to run the command twice or run netlify link before deploy. I don't like it either, but that's what works for me.

Unfortunately netlify link or running the command twice doesn't work for me and thus I've resulted to using netlify CI/CD instead of the  cli for the moment.

We've just released a new version with a fix for this bug. Please update to the latest version of netlify-cli and let us know if it's still a problem.

We've just released a new version with a fix for this bug. Please update to the latest version of netlify-cli and let us know if it's still a problem.

Using the new cli version, 2.25.0:

it doesn't ask for the deploy folder
its stuck at Waiting for deploy to go live and eventually times out
This is the stacktrace :

(base) cozy@Cozy:~/projects/itscosmas$ netlify deploy --prod
This folder isn't linked to a site yet
? What would you like to do? Link this directory to an existing site

netlify link will connect this folder to a site on Netlify

? How do you want to link this folder to a site? Choose from a list of your recently updated sites
Fetching recently updated sites...

? Which site do you want to link? itscosmas

Directory Linked

Admin url: https://app.netlify.com/sites/itscosmas
Site url:  itscosmas.me

Site id saved to /home/cozy/projects/itscosmas/.netlify/state.json

You can now run other `netlify` cli commands in this directory
Deploy path: /home/cozy/projects/itscosmas/.netlify/build
Deploying to live site URL...
✔ Finished hashing 0 files
✔ CDN requesting 0 files
✔ Finished uploading 0 assets
Waiting for deploy to go live... ›   Warning:
 ›   {
 ›      "name": "TimeoutError"
 ›   }
 ›
TimeoutError: Promise timed out after 1200000 milliseconds
    at Timeout.setTimeout [as _onTimeout] (/usr/lib/node_modules/netlify-cli/node_modules/p-timeout/index.js:27:54)

Can you verify that your built site files are in /home/cozy/projects/itscosmas/.netlify/build
The deployment appears to be trying to deploy an empty directory

Can you verify that your built site files are in /home/cozy/projects/itscosmas/.netlify/build
The deployment appears to be trying to deploy an empty directory

My build files ain't there, they are here /home/cozy/projects/itscosmas/build , previously I use to be prompted to enter a  folder to deploy everytime I ran the deploy command. Since 2.24.0 I never get the prompt.

Can you set a build.publish directory in the netlify.toml file? https://docs.netlify.com/configure-builds/file-based-configuration/
This should solve the problem.
[build]
  publish = "build"

Alternatively, you can use netlify deploy --dir build to specific the correct deploy directory.

Can you set a build.publish directory in the netlify.toml file? https://docs.netlify.com/configure-builds/file-based-configuration/
This should solve the problem.
[build]
  publish = "build"

Alternatively, you can use netlify deploy --dir build to specific the correct deploy directory.

Hey both the netlify.toml file and netlify deploy --dir <your directory> command deploys correctly. Thanks that seems to solve the issue.


CD Revamp

Adding scroll event capture to trigger scrape
Adding Max Discovery repeat time (mdr). Default is set to 15. This
is a variable which can control the max scrape scrape per path.
(Repeated discovery happens when DRI or ENABLE_SCROLL_WATCH is enabled)
Adding switch to enable scroll based trigger for list view
discovery.bnc_esw, Enables scroll watch for collection views.
Provided as part of Collection view data JSON
The new data structure for content keys and content data are updated in the below document along with the new control keys
@aaustin @EvangelosG @E-B-Smith

my tests are passing. will move on to more complex UIs. 👍

thanks for making the changes 👍


Fix image positioning

#2 Fix bug in image positioning

That's great the align-self really didn't belong there. It seems to work fine. However, do you seem to know what makes this extra space occur below the image when we reduce the horizontal viewport?

I saw, that is the picture__box div, which holds the image tag. I think we need to declare some kind of height for the div?

Oh this fills the div with the image, great. 👍
By the way, I think we shouldn't give the grid-template-rows fractional values, 1fr as in this case, when the other layer (except the pictures) when gets compressed while changing the viewport, the height of fr increases and it makes the picture layer to get bigger to match with defination of 1fr.

Oh this fills the div with the image, great. 👍
By the way, I think we shouldn't give the grid-template-rows fractional values, 1fr as in this case, when the other layer (except the pictures) when gets compressed while changing the viewport, the height of fr increases and it makes the picture layer to get bigger to match with defination of 1fr.

That's right. Also, in order to make the layout responsive, maybe you can describe how you want it to be on a tablet or smaller phone? From that, we can get a more detailed requirement.

Finally, #2 seems to be solved. I am going to make this responsive soon and make this cooler.

Also, in order to make the layout responsive, maybe you can describe how you want it to be on a tablet or smaller phone?

I think I am gonna use some js to remove the not being edited image in the mobile view, and also make the layer below the pictures look one below the other. What do you think? Lemme merge this PR, first.
Btw, if you wanna add something sure, I can always put that up in a different branch!


META: reduce gas consumption

This issue affects everybody except Nick so I added all developers to the Assignees (except Nick)
Latest estimation from Tore on the gas consumption of elliptic math:

version without Pedersen Commtment: 15k gas
and with pedersen commitment it will be 40k gas

[x] BN curve (and consequently, Pedersen Commit)
[ ] Applying Barretts Reduction
[ ] Optimising asn:INTEGER to byte32 converstion
[x] Reduce transaction size: by not inclduing the EC parameter or include in a condensed
[ ] Reduce transaction size: by not including the signature in UseTicket
[ ] Reduce transaction size: reduce the size of proof by not repeating Pederson Commit
[ ] Reduce transaction size: by including compressed EC point (@jot2re @JamesSmartCell said that this unlikely leads to gas reduction)

Quote @JamesSmartCell on the progress:

I'll continue the integration and then update when I have his new algorithm

Results from removing elements of the smart contract:
Only EC math (ie no decoding of any kind): 58,977
EC math plus forming the Challenge (concatenate, hash and modulo): 68,114
EC math, form challenge plus decode coordinates from hardcoded bytes: 141,494
EC math, form challenge, decode coordinates from DER decode: 208,118
Looks like the optimisation that will payback the most is the coordinate decode function, I'll take a look at that first, followed by optimising the DER decode.

Results from removing elements of the smart contract:
Only EC math (ie no decoding of any kind): 58,977
EC math plus forming the Challenge (concatenate, hash and modulo): 68,114
EC math, form challenge plus decode coordinates from hardcoded bytes: 141,494
EC math, form challenge, decode coordinates from DER decode: 208,118
Looks like the optimisation that will payback the most is the coordinate decode function, I'll take a look at that first, followed by optimising the DER decode.

Quote @JamesSmartCell on the progress:

I'll continue the integration and then update when I have his new algorithm

Quote his update:
Current reality reported by @JamesSmartCell

Only EC math (ie no decoding of any kind): 58,977
EC math plus forming the Challenge (concatenate, hash and modulo): 68,114
EC math, form challenge plus decode coordinates from hardcoded bytes: 141,494
EC math, form challenge, decode coordinates from DER decode: 208,118

Quote @JamesSmartCell on the progress:

I'll continue the integration and then update when I have his new algorithm

Quote his update:
Current reality reported by @JamesSmartCell

Only EC math (ie no decoding of any kind): 58,977
EC math plus forming the Challenge (concatenate, hash and modulo): 68,114
EC math, form challenge plus decode coordinates from hardcoded bytes: 141,494
EC math, form challenge, decode coordinates from DER decode: 208,118

Good news, after hand optimising the less efficient code I was able to bring the whole function operation down to
120,213 Gas.
There's still a couple of areas left that can be optimised as when I wrote them I wrote them to be generic, since we know what data is expected that can be optimised a bit further.

Good news, after hand optimising the less efficient code I was able to bring the whole function operation down to
120,213 Gas.
There's still a couple of areas left that can be optimised as when I wrote them I wrote them to be generic, since we know what data is expected that can be optimised a bit further.

After further hand optimisation, 73,560 Gas.
This will be the final gas spend for this contract, with the 'biased' array hash (which is vulnerable). I will move onto the new implementation outlined by Tore.

After further hand optimisation, 73,560 Gas.
This will be the final gas spend for this contract, with the 'biased' array hash (which is vulnerable). I will move onto the new implementation outlined by Tore.

After further hand optimisation, 73,560 Gas.
This will be the final gas spend for this contract, with the 'biased' array hash (which is vulnerable). I will move onto the new implementation outlined by Tore.

You mean this is reduced to 73.5 K? Marvelous!

EC math, form challenge, decode coordinates from DER decode: 208,118

After further hand optimisation, 73,560 Gas.
This will be the final gas spend for this contract, with the 'biased' array hash (which is vulnerable). I will move onto the new implementation outlined by Tore.

You mean this is reduced to 73.5 K? Marvelous!

EC math, form challenge, decode coordinates from DER decode: 208,118

Correct, full verification 73.5K, down from the 208,118

Correct, full verification 73.5K, down from the 208,118


It is possible to crash out an app with a bad bit of image handling

![here](jafaapp://pushnotificationsettingspage) will crash out an app completely due to no image handler

fixed in 4.0.11


Add files via upload

https://udlondres.com/

@marioegc First stage of verification passed, official domain is udlondres.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@marioegc Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Introduce interface for data access

See individual commit messages for details. Overall, the changes are:

Introduce an interface for data access - currently implements the same methods that exist now
Put database and batching logic below the interface
Keep only register domain logic above the interface
Removed the concept of read/write domain objects
Make performing a read from the RecordIndex force all entry and item data to be flushed to the database. This means that we could remove register.commit() hack from the IndexDriver.

This is a work in progress and the next steps include:

remove concept of "on demand register" and "transactional register" - use the same db handle logic everywhere
simplify and consolidate the number of methods in the DataAccessLayer interface.

This is very exciting! All the changes look good, definitely a vast improvement from what we currently have. If I get some spare time I'll test it out and update this PR if no-one beats me to it.


Remove ISSUE_TEMPLATE

Remove ISSUE_TEMPLATE from .github directory.

The only thing to be done here is removing the ISSUE_TEMPLATE folder from .github? Can you assign to me?

Solved in #42

@shreyasbapat, reviewed it. 😉  Also, do ask for assignment before opening PR. Thank you.

Yeah! Changed!


[Enum Request] table "Document Sending Profile" - Field E-Mail Attachment

Could you change the Field "E-Mail Attachment" to enum?
Some places where an event would be needed then:

procedure SendToEMail
procedure SendToEmailVendor

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


liberio: init at unstable-2019-12-11

Motivation for this change
An optional dependency for uhd.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@timokau I was glad to see my inbox filled with your activity here on Nixpkgs :). Trying to "catch the wave", perhaps you could take a look at this PR? It's a somewhat blocker for a bigger PR I'm planning to open.

Sure, already had it open in a tab ;) I was actually skimming through your contributions in particular, since I noticed you're doing good work both reviewing and contributing. Kind of a shame so much of it got stuck in the final stage.

Thanks @timokau :).

You're welcome :)
If you think something is ready for merge now (either your own PR or something you reviewed), feel free to ping me.

Cool :). Besides the PR for picard, I'm not sure if you are only "in to" merging PRs, but I'd be glad to get an opinion on https://github.com/NixOS/nixpkgs/pull/83296 . Thanks again.


DEVOPS: Configure prettier for code consistency

We should configure prettier to consistently format the code cross-IDE and cross-contributor.

I've seen that the prettier is mentioned in readme but not configured in the project. Would be great to add prettier configs into it.

okay 👍


Compatibility with angular-material

Hi there,
great work by the way, neat stuff here!
I would like to use your library to animate angular-material components, but it's not working :(
I made a fiddle http://jsfiddle.net/leseulsteve/1v2r5p9L/
It seems to be the way those components are render..
Thanks for you time...

no such page...

Yea, I hade ngFx bundled with old versions of angular, just undbundled them now. You just have to make use you include ngAnimate and gsap/TweenMax.js


Scale factor for Grollemund et al. 2015

It seems, posterior.trees for Grollemund et al. 2015 mixes branch length and change rate in a composite data type à la<EMAIL_ADDRESS>If read this way, the scale factor for the branch lengths seems to be years, giving ~6,800 years root age for Atlantic-Congo.

Ok, we need to remove @... from these trees. What's the best way to do it? I can write some code/regex to do this, or should we use phyltr as discussed in https://github.com/lmaurits/phyltr/issues/16#issuecomment-453955556 ?

phyltr would be the right tool for the job, though. And it uses ete3 for the low-level nexus reading and writing, like pydplace - so it only adds the functionality we want without any overhead.

I just realised that the summary trees and the posterior trees have different scales for this dataset. This is annoying.
Should we standardise the scales?

phyltr cat < my.trees | phyltr scale -s 100 > out.trees


Wrap to margin on "Reformat code..."

Soft wrap support is good, but it'd be also nice if (at least with "wrap when typing reaches right margin" activated) a Ctrl-Alt-L would rewrap lines in idea-markdown. As it is, when I'm editing long documents, I often find myself opening them in Emacs just so I can Meta-Shift-Q to rewrap.

Notice: This plugin is no more maintained and it has been removed from Jetbrains plugins repository. There is a Markdown plugin officially supported by Jetbrains.


404 not found page design improved

404 not found page design improved

issue #202 solved

hi @Sayak-Bhunia thank you sir merging my PR ,can you make it level 2 ,coz i worked in 4-5 projects they give it to level 2


Use t3.micro for testing, since t2.micro is largely deprecated in most regions

Everytime cloud nuke selects a new region (e.g eu-north-1), the tests fail because they don't support t2.micro. This fixes that by using t3.micro for testing.

Thanks for review! Merging this in now.


feat: add on_application_command_completion event

Summary
This adds a new event that is dispatched whenever an application command callback finishes executing with no errors. Closes #676.
Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[ ] I have run task pyright and fixed the relevant issues.

[ ] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Looks fine? I haven't tested it, but the code portions look good.


Electric arc furnance integrity check issue

For example, when I put my engine here after completion, the arc furnace's gui will be bugged (not showing total power) but sometimes it can still smelt stuff, it no longer works after reenter the game

But if I put the engine like this it worked smoothly

So I guess it checks the integrity of air blocks beside the rf plug too?

Yes, but that's an oversight on my part, will fix for next release

it working now :3


crash due to unchecked fabric api internal implementation mixin

https://github.com/Keksuccino/Konkrete/blob/309c477fec7f9d58dafdb9a63e22b16b93cb804a/src/main/java/de/keksuccino/konkrete/mixin/mixins/client/MixinScreenEvents.java#L20
https://mclo.gs/vQNMvfY
Should mark the mixin as not required and null check.
Should also mark tested fabric api versions in fabric.mod.json to prevent issues on versions where implementation may change since you call internal methods that may change even in minor patch releases of fapi

You are using an old version of FancyMenu and Konkrete that had problems with this
That part of the API didn't change in like years, so it is unlikely they will start changing it frequently
Without this Mixin, FancyMenu and other mods of me would basically do nothing at all anymore, so a crash is better than making it optional

btw: I'm fully aware this Mixin can cause issues, which is why it isn't present in the 1.20.4 version anymore. I'm also planning to backport this change, but this also requires me to update the mods that have Konkrete as dependency, so it does not have very high priority right now.
The latest versions of Konkrete and FancyMenu (which triggered the NullPointer most of the time) are using this Mixin in a less aggressive way, so crashes related to that Mixin are very rarely happening in latest versions.


⚠ Bofrost.lu has degraded performance

In 6b9d13a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1771 ms

Resolved: Bofrost.lu performance has improved in 3fcd37d after 7 minutes.


[Queues] Add contentType support for sending Queues messages

This PR adds support for the contentType option for sending Queues messages. See here for the associated workerd PR and here for the documentation. The TL;DR is that you can do .send("Hello world!", {contentType: "text"}) and have the message not be v8-serialized when previewed from the Dashboard and (in the future) consumed from other consumer types.
I had some trouble coming up with the serializing to/from Buffers, so would appreciate any feedback on how this can be cleaner!
Also, npx changeset was failing and other recent PRs don't seem to include one, so I've left it out for now. Please let me know if/how I should add one.

Thanks for the review - TIL about the JSON.stringify replacers and the Buffer/ArrayBuffer fun!


Parallel machine transition resetting sibling states

Bug
When a transition is fired for a nested parallel machine, it changes the targeted state as expected but changes all sibling states to their initial value.
Code Sandbox

It's intentional, as dog is a parallel state node you can think of GO_WALKING: ".dog.walking" as transitioning the machine to {  pets: { dog: "walking", cat: undefined } }. undefined will get "converted" to the state node's initialState.
You can use multiple targets when working with parallel states (it's not live yet):
https://github.com/davidkpiano/xstate/commit/544dfb3246340c05a7643123035121f5ba3c9c0d

You're right, but I think this should be addressed for use-cases like:
{
  on: {
    GO_WALKING: {
      target: ['.dog.walking', '.cat.walking'],
      internal: true
    }
  }
}

But you can also handle each transition within the .dog or .cat states themselves as an idiomatic workaround.

@davidkpiano I think { target: ['.dog.walking', '.cat.walking'], internal: true } is a bit redundant, the machine already knows .someChildState is internal, I'd say the machine should know what to do when you omit interval: { target: ['.dog.walking', '.cat.walking'] }.

Closing as this is addressed.


Admin build fails

Version 4.1.0+
SyntaxError: /vendor/store.shopware.com/molliepayments/src/Resources/app/administration/src/module/mollie-payments/components/mollie-pluginconfig-section-order-lifetime-warning/services/OderLifeTimeLimitDetectorService.js: Support for the experimental syntax 'classProperties' isn't currently enabled (2:32):
      1 | export default class OrderLifeTimeLimitsDetector {
    > 2 |     maximumOrderLifeTimeKlarna = 28;
        |                                ^
      3 |     maximumOrderLifeTime = 100;
      4 |
      5 |     isOderLifeTimeLimitReached(orderLifeTime) {

Hi Melvin
oh ouch, yeah thats wrong, that should be done in the constructor
thanks a lot
i will create a fix :)


Occasional hangs at updating registry

I'm seeing cargo build and other cargo commands such as test and package start hanging sometimes at this step:
Updating registry `https://github.com/rust-lang/crates.io-index`

Example of cargo package:
Packaging rusoto v0.7.0 (file:///Users/matthewmayer/Documents/DualSpark/rust-aws)
   Archiving .gitignore
   Archiving .travis.yml
   Archiving AWS-CREDENTIALS.md
   Archiving Cargo.toml
   Archiving codegen/botocore_parser.py
   Archiving codegen/requirements.txt
   Archiving codegen/s3.json
   Archiving codegen/s3.rs
   Archiving codegen/sqs.json
   Archiving codegen/sqs.rs
   Archiving docgen.sh
   Archiving LICENSE
   Archiving README.md
   Archiving RELEASING.md
   Archiving s3-sample-creds
   Archiving src/bin/main.rs
   Archiving src/credentials.rs
   Archiving src/error.rs
   Archiving src/lib.rs
   Archiving src/params.rs
   Archiving src/regions.rs
   Archiving src/request.rs
   Archiving src/s3.rs
   Archiving src/sample-credentials
   Archiving src/signature.rs
   Archiving src/sqs.rs
   Archiving src/xmlutil.rs
   Archiving tests/sample-data/default_profile_credentials
   Archiving tests/sample-data/list_queues_with_queue.xml
   Archiving tests/sample-data/multiple_profile_credentials
   Archiving tests/sample-data/no_credentials
   Archiving tests/sample-data/s3_complete_multipart_upload.xml
   Archiving tests/sample-data/s3_get_buckets.xml
   Archiving tests/sample-data/s3_initiate_multipart_upload.xml
   Archiving tests/sample-data/s3_list_multipart_uploads.xml
   Archiving tests/sample-data/s3_list_multipart_uploads_no_multipart_uploads.xml
   Archiving tests/sample-data/s3_multipart_uploads_with_parts.xml
   Archiving tests/sample-data/s3_temp_redirect.xml
   Verifying rusoto v0.7.0 (file:///Users/matthewmayer/Documents/DualSpark/rust-aws)
    Updating registry `https://github.com/rust-lang/crates.io-index`

It was at the last line for 15 minutes, pinning a single core of my machine, until I gave up and ctrl-c'd it.  Rerunning the cargo command finishes instantly.
I'm also seeing this behavior with our Travis CI builds, sometimes.  Travis automatically cancels the build after 10 minutes of waiting.
I think the easiest way of reproducing this issue is to check out Rusoto (https://github.com/DualSpark/rusoto) @ be07f36 and running this command:
cargo clean && cargo package

This looks like resolution is going into a seemingly infinite loop... seems bad!

That could be it.  Is there other information I can provide, such as more detailed logging?  I'm not sure how to provide more info.
Another piece of information that may help: I don't recall this being an issue before we locked down to specific version of dependencies in our Cargo.toml file.

Dang, same issue.
$ rustc --version
rustc 1.4.0 (8ab8581f6 2015-10-27)

$ cargo --version
cargo 0.5.0-nightly (833b947 2015-09-13)

git checkout be07f36

cargo clean && cargo package
   Packaging rusoto v0.7.0 (file:///Users/matthewmayer/Documents/DualSpark/rust-aws)
   Verifying rusoto v0.7.0 (file:///Users/matthewmayer/Documents/DualSpark/rust-aws)
    Updating registry `https://github.com/rust-lang/crates.io-index`

Nah it's ok, I can reproduce locally with the latest nightly, so I'll try to get around to investigating soon!

Just thought I'd let you know we're getting this issue when trying to update and build glutin. Here is the error occuring within travis, for example:
0.00s0.00s0.00s$ rustc --version
rustc 1.4.0 (8ab8581f6 2015-10-27)
$ cargo --version
cargo 0.5.0-nightly (833b947 2015-09-13)
$ cargo build --verbose
    Updating registry `https://github.com/rust-lang/crates.io-index`
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

That's the output of the current stable osx build.
The nightly linux build also produced the same error.
Strangely however, the build passed without issues on both nightly osx and stable linux? :confused:
This is the PR in which I first noticed the issue.
I'm also currently hitting this trying to build glutin locally and haven't yet worked out a way around it.

Workaround: Change the dependencies to "x.y.z" (which is the same as "^x.y.z) instead of locking them at exact versions with "=x.y.z". This is probably a better practice for a library anyway.

Anything I can do to help work on this?  Is whatever fix https://github.com/rust-lang/cargo/issues/2064 will yield going to solve this?
Happy to do some investigation work if pointed in the right direction.

@matthewkmayer yeah I suspect that #2064 will likely yield a resolution for this, unfortunately other than that I'm not sure if there's an easy way to tackle this.
One idea @wycats had was to bail out after more than N instances of recursion (where N is something like 20k) which would cause Cargo to generate an error, but that unfortunately still wouldn't be the greatest because these graphs do have solutions which can be reached quickly via one traversal, just not another.

I seem to be hit with this. cargo is hanging on "updating registry" and pinning a core on stable(1.18) and the latest nightly on both linux and mac.

Update: I got it to work again by changing the newly added (to my Cargo.toml) crate version to *. After it updated, I was able to set it back to a partial version (0.7).

Hi. $ cargo search bidi hangs:
   Updating registryhttps://github.com/rust-lang/crates.io-index``
I'm using cargo 0.19.0.

It is back again :( got it on my Server and on TravisCI builds :/

Also happening here inside a Docker container, although it might just be taking a very long time.  It doesn't seem to take as long when running directly on the host system, though.  (No VMs are involved, just Docker.)

If you think you're hitting this issue then it'd be great to get assistance in debugging this. If Cargo's hogging CPU then you're probably running into https://github.com/rust-lang/cargo/issues/4066. If Cargo's not hogging CPU it'd be great if you could attach a debugger. The backtrace of the main thread will very likely indicate that https://github.com/rust-lang/cargo/issues/4261 is the actual issue here.

I'm not too keen on trying to attach a debugger inside a Docker container, but it's happening right now, and don't see any significant CPU usage, so it's probably #4261.  I'm on a janky workplace network, so it wouldn't surprise me if git operations sometimes take unreasonably long.

I have tried to attach a debugger to the cargo process when it hanged at Updating registry point.
Of course, I did not have debugging symbols in the binary so I could not get readable backtrace.
I have tried to get cargo from Github and build cargo with debugging symbols. Unfortunately, my cargo from Homebrew hanged at "Updating registry" while trying to build cargo with cargo build.
Inception.

gfx-rs is unstable so I attempted to switch one of my projects to Piston-Graphics. I encountered this issue of cargo being stuck updating the registry today while trying to compile with these Cargo.toml dependencies from the piston tutorials:
[dependencies]
piston = "0.35.0"
piston2d-graphics = "0.23.0"
pistoncore-glutin_window = "0.42.0"
piston2d-opengl_graphics = "0.49.0"

I suspect that one of the packages may be unavailable but cargo continuously tries to access it.


fix(test): fix testing-route

Coverage remained the same at 95.595% when pulling 8e927856d9217a5729e67e0b4d16c86877644b91 on fix-test into ed806114cebf2c207d3b037cf0b60d8c0d4b4165 on master.


Retreave document: need example

Hello!
I'm newbie in Swift and it is not clear how to retrieve document from collection after subscribing.
For example.
I have a subscription:
let users = MeteorCollection<UserDocument>(name: "users")
Meteor.subscribe("users")

and try to see the result
print("USER COLLECTION: \(users)")
but it returns strange message
USER COLLECTION: <_TtGC8SwiftDDP16MeteorCollectionC16smartworkout_ios12UserDocument_: 0x7ff6643eb240>
In console I can see the document from collection:
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7ff6644dcdd0 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    collection = users;
    fields =     {
        createdAt =         {
            "$date" =<PHONE_NUMBER>735;
        };
        services =         {
            email =             {
                verificationTokens =                 (
                );
            };
            password =             {
                bcrypt = "$2a$10$AphY6UWLl.tZl...........IJQOTCEhDSZocy";
            };

but I don't understand how to retrieve it.
I see one discussion about retrieving user document already done https://github.com/siegesmund/SwiftDDP/issues/22 but it is still not clear. Example in description would be very helpful.
Could you provide some example?
Thanks.

Try this:
print(users.sorted)

@ashmore11 print(users.sorted) returns empty array [].
I have collection:
import Foundation
import SwiftDDP

class Users: MeteorDocument {
    var _id: String?
    var username: String?
    var profile: [String: AnyObject]?
}

and function:
override func viewDidLoad() {
        super.viewDidLoad()

        let users = MeteorCollection<Users>(name: "users")
        Meteor.subscribe("users") {
            print("USER: \(users.sorted)")
        }

    }

and it returns me empty [].
But in console I can see the subscription with data:
[Info] [DDP] > smartworkout-ios Version: 1.0 Build: 1 PID: 6300
[Info] [DDP] > XCGLogger Version: 3.3 - LogLevel: Debug
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf3c108d0 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    "server_id" = 0;
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf3c0c640 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    msg = connected;
    session = ht6ugA94SW2fTCGKk;
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf621a4f0 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    msg = ready;
    subs =     (
<PHONE_NUMBER>423481369
    );
}
[Error] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf3c108d0 (QOS: BACKGROUND)] [336] ddpMessageHandler > Unhandled message: {
    "server_id" = 0;
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf6010100 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    methods =     (
        3b98f5a261f444f89E0373540Dc6Dc82
    );
    msg = updated;
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf3fe96a0 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    msg = ready;
    subs =     (
<PHONE_NUMBER>423481369
    );
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf6034de0 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    collection = users;
    fields =     {
        emails =         (
                        {
                address =<EMAIL_ADDRESS>                verified = 0;
            }
        );
        profile =         {
            firstName = User;
            lastName = 2;
        };
        username =<EMAIL_ADDRESS>    };
    id = QhKCfojmdC3Ep2oSz;
    msg = added;
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf631f560 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    id = 3b98f5a261f444f89E0373540Dc6Dc82;
    msg = result;
    result =     {
        id = QhKCfojmdC3Ep2oSz;
        token = "8955LTFvfW-sMMudc2Tq_DgxnIcM0s49bpjyncWaZWU";
        tokenExpires =         {
            "$date" =<PHONE_NUMBER>997;
        };
    };
}
email<EMAIL_ADDRESS>and password: [111]
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf3d15c50 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    msg = ready;
    subs =     (
<PHONE_NUMBER>358076214
    );
}
[Debug] [DDP] [DDP Background Data Queue :: NSOperation 0x7fbbf63b4380 (QOS: BACKGROUND)] [260] ddpMessageHandler > Received message: {
    collection = users;
    fields =     {
        createdAt =         {
            "$date" =<PHONE_NUMBER>113;
        };
        services =         {
            email =             {
                verificationTokens =                 (
                                        {
                        address =<EMAIL_ADDRESS>                        token = "Q9_dHLhn7qFiYsNS0mp8DPtzM1Gii_CSICszRqrKS9t";
                        when =                         {
                            "$date" =<PHONE_NUMBER>116;
                        };
                    }
                );
            };
            password =             {
                bcrypt = "$2a$10$MGa65IK.S0HEJb8f052VHuC42HaGtsMTQYUDHfweBKKSfoWVhZLQW";
            };
            resume =             {
                loginTokens =                 (
                                        {
                        hashedToken = "6xQnQjb58JN1uYgPz2DbuVMdjr9JCu07SNFTkdn9gxY=";
                        when =                         {
                            "$date" =<PHONE_NUMBER>120;
                        };
                    },
                                        {
                        hashedToken = "ZiMbc0eJyqaNFUtyhew3gCzYyLhUVvKkJVyfjiAX4Ps=";
                        when =                         {
                            "$date" =<PHONE_NUMBER>997;
                        };
                    }
                );
            };
        };
    };
    id = QhKCfojmdC3Ep2oSz;
    msg = changed;
}
USER: []

As I understand connection and subscribtion is OK. I know that data in MongoDB stored in JSON format and if I want to work with it in Swift I have to deserialize/serialize it. But how to get the data from server collection I don't understand.
And it is not only from users collection it is in general.

You're right, we do need better documentation for this.
If your collection is called Users and you have the user's id, you can get a single user with:
Users.findOne(id)
You can get an array of all of the users with:
Users.sorted

@siegesmund looks like it works but result prints in strange format.
For examle for Users.sorted:
USERS: [<smartworkout_ios.Users: 0x7ff1aabc6830>, ..., <smartworkout_ios.Users: 0x7ff1a87481c0>]

and for Users.findOne(id):
USERS: Optional(<smartworkout_ios.Users: 0x7f809635fc30>)

As I understand value like 0x7f809635fc30 it is something like address in memory? How to work with it?

In the first example, you're seeing an array of Users objects. Access the user using normal array methods, for example by index. Then you can access the user's properties just like any other object.
In the second, you're seeing an optional wrapped User object. Unwrap the optional, and then you have the user object.

@siegesmund thank you very much for this help. Yes, now I can get the properties of object(fields of document from collection) using dot notation:
let currentUser = Users.findOne(Meteor.client.userId())
let userName = currentUser.userName

Thanks!

Glad to hear you're up and running!

@siegesmund ... how can we get document id ? like user id.


suggest update README.md

In the README.md:

At the moment the performance difference is measurable, but too small to be human recognizable. But the leap will get bigger with more and more options coming, and on slow machines this might actually make a difference.

I would consider any difference to be statistically negligible, unless you could demonstrate otherwise (for instance, by referencing a file of output times for given configurations).
Also, consider fewer images in the README and potentially a screenshot of an OS other than Linux using fastfetch.

potentially a screenshot of an OS other than Linux using fastfetch.

Did it here: https://github.com/dylanaraps/neofetch/issues/2257

Will you choose to commit any change to the README regarding the screenshots?

See https://github.com/LinusDierheimer/fastfetch/wiki


vulnerability detected in express 4.17.3

we are getting  vulnerability in fortify scan sonatype issue when using express 4.17.3 version
currently am using node 12.14.0 version
Is there any recommendation node version or express version available to avoid this issue ?

Hello, we are not aware of any current vulnerabilities against express 4.17.3 . Please contact us with the details of the vulnerability using our security procedure https://github.com/expressjs/express/blob/master/Securi so ee can investigate.

Hi @vjram555 that issue is regarding the version of Node.js you are using it sounds like, not Express.


Add RTSP_SIP

Add https://github.com/tommyjlong/app_rtsp_sip to the Asterisk build.

Code needs a few changes, I'll post later

hey @TECH7Fox
In dockerfile i added this below, right before the compilation of asterisk:
## Install app_rtsp_sip
WORKDIR /usr/src/asterisk
COPY patches/rtsp_sip_links.sh /usr/src/asterisk
RUN ./rtsp_sip_links.sh
COPY patches/app_rtsp_sip.c /usr/src/asterisk/apps

For the 2 files, grab the ones from my github : https://github.com/pergolafabio/app_rtsp_sip
in the .sh file i removed the sudo commands, sudo doesnt work on your addon
in the .c file, i removed the "CheckHeaderValue" function, its not needed, can give issues
maybe you can include it in the 2.3.0 release?
anyway, you can use this dialplan to  watch an rtsp stream:
exten => 1,1,Answer()
 same => n,RTSP-SIP(rtsp://admin:XXXX@<IP_ADDRESS>:554/Streaming/Channels/102,0,Hikvision,5060)


[SPARK-50700][SQL] spark.sql.catalog.spark_catalog supports builtin magic value

What changes were proposed in this pull request?

This PR adds a magic value builtin(and sets it to the default value) for spark.sql.catalog.spark_catalog.
Why are the changes needed?

Currently, spark.sql.catalog.spark_catalog is optional and has None as the default value. When spark.sql.catalog.spark_catalog=a.bad.catalog.impl is wrongly set in spark-defaults.conf, the user has no way to overwrite it in spark-submit.
Note that, explicitly setting it to o.a.s.sql.execution.datasources.v2.V2SessionCatalog does not work either, because V2SessionCatalog does not have a zero-args constructor.
spark-submit \
  --conf spark.sql.catalog.spark_catalog=org.apache.spark.sql.execution.datasources.v2.V2SessionCatalog \
  ...

To fix the above issue, similar to what we did for spark.sql.hive.metastore.jars, just use "builtin" to represent the built-in V2SessionCatalog.
Does this PR introduce any user-facing change?

No change for existing behavior, and users are allowed to spark.sql.catalog.spark_catalog=builtin to set spark_catalog as the built-in V2SessionCatalog.
How was this patch tested?

TODO: add UT.
Was this patch authored or co-authored using generative AI tooling?

No.

@cloud-fan @yaooqinn @huaxingao please let me know if this approach makes sense, or do you have any other suggestions to allow users to set spark_catalog to the built-in V2SessionCatalog explicitly? thanks in advance.


Adding support for clients to add their own stage domain maps

Making stageDomainsMap configurable through consuming client

Resolves: MWPW-161164
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://stage-domain-config--milo--adobecom.hlx.page/?martech=off

QA:

https://adobecom.github.io/nav-consumer/navigation.html?navbranch=stage-domain-config

Validation done on the PR on below url
https://adobecom.github.io/nav-consumer/navigation.html?env=stage&navbranch=stage-domain-config&authoringpath=/federal/dev/souji/home&customlinks=home,apps,files,firefly,benefits,learn,discover&showUnavSectionDivider=true


Support for InfluxDB Fill('Linear') in QueryNode.Fill property

This is a Trivial change.
Required for all non-trivial PRs

[x] Rebased/mergable
[x] Tests pass
[x] CHANGELOG.md updated
[x] Sign CLA (if not already signed)

Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.

[x] TICKscript Spec updated

@SamuelToh Thanks! :tada:

@SamuelToh Can you rebase your changes and squash them into a single commit? I'll merge once that is done.


test: add a common test base class

Description: There's been a few cases where I wish I could get a global teardown/setup hook but Envoy lacked a common test base-class. This giant PR adds one. Sorry it's incredibly huge...I don't know if it's worth breaking up. This was mostly done with sed scripts with minor manual fixups where needed, and no functional logic was changed.
Currently in the common per-test teardown we just check that all the test-scoped singletons are freed. But there may be other uses for this hook.
Risk Level: low
Testing: //test/..., in fastbuild and tsan
Docs Changes: n/a
Release Notes: n/a

Note: after this PR there are still 879 instances of TEST( in 164 _test.cc files which would need to be cleaned up to make the global common TestBase actually work. That can be done in a follow-up PR (with appropriate check_format.py tweak to make sure that doesn't recur).

feel free to ignore the broken clang-tidy build, it is because the diff is too big (across too many files)

The new class is:
header: https://github.com/envoyproxy/envoy/blob/00f86e1d2f18864339d3ca0c99f1a19383cd8d5b/test/test_common/test_base.h
impl:
https://github.com/envoyproxy/envoy/blob/00f86e1d2f18864339d3ca0c99f1a19383cd8d5b/test/test_common/test_base.cc
This gets implicitly linked implicitly with envoy_cc_test_library via a new dependency in envoy_build_system.bzl:
  repository + "//test/test_common:test_base",

An example test change is in
https://github.com/envoyproxy/envoy/blob/00f86e1d2f18864339d3ca0c99f1a19383cd8d5b/test/common/buffer/owned_impl_test.cc#L18
The bulk of the changes are pretty simple like that. The other changes are almost 100% from a script that does a file-tree string-replacement. From my shell  history there were several of these:
sed_multi_rep '#include "gtest/gtest.h"' '#include "test/test_common/test_base.h"' cc h
sed_multi_rep " ::testing::Test" " TestBase" cc h
sed_multi_rep " testing::Test" " TestBase" cc h
sed_multi_rep  TestBaseParamInfo ::testing::TestParamInfo cc h
sed_multi_rep  TestBaseInfo ::testing::TestInfo cc h

After this there were a few tweaks required to deal with patterns like using testing::Test; which becamse using TestBase; which of course makes no sense.
@lizan you are right I think clang-tidy is really hard on this PR. I have been iterating on it locally and it takes hours. There were a lot of legacy clang-tidy violations which this PR awakened. I've fixed a bunch of them and committed them locally, but did not push the change yet. It'd be better to merge this first if you think this is worth it, as it's a real merge-conflict magnet :)
I'm not too invested in this; IMO it's a good hook to have.

For the record I went through all the clang-tidy warnings and fixed most of them. I could find no errors, so I guess in CI it just failed due to excessive size. Some of the clang-tidy suggestions are wrong: IMO:

executing the suggestions results in compilable errors: replacing {} with = default in constructors when there are arg-dependent initialization values.

Others are annoying:

changing a const std::string& arg to an rvalue ref with std::move, which seems not general to all call-sites which might not want to give up their ownership.

I will send a follow-up PR with the clang-tidy changes that made sense after this is merged.

@jmarantz thanks for the links. If you want to go with this and are willing to do the work to replace TEST somehow and also wire up the format checker, no objections from me. Do you want to go ahead and merge this?

Yup will merge but need approval I think per tool. Will follow up with ^TEST(  replacement. Should be pretty straightforward.


Fix wrong v value on ethereum signature

This pull request fixes the issue #6  with the calculation of the v value in the ethereum signature. The current implementation is returning v = 1 instead of v = 0, which is causing the end of the signature to be different. The fix involves updating the calculation of v to use a bitwise XOR operation with 1 when s is greater than half of the curve's order.
The pull request also includes a test case to ensure that the fix is working correctly.

@josher8a Thank you and your great team.  I have already merged the PR and published a new version on pub.dev https://pub.dev/packages/ecdsa/versions/0.1.1

Thank you, sir 🫡


Con 503 missing owner tag

Is there a reason that IAM is like this? I'm assuming it's just an error

Ah I see! It does mean that advise-iam-rollup will always be action nothing


Implement the APDL *GET shortcuts in PyMAPDL

Is your feature request related to a problem? Please describe.
Implement pymapdl versions of APDL *GET shortcuts.
See the APDL *GET documentation to see the exact values N can take in the examples below.
Inverse Get Functions:

[x] N=NODE(X,Y,Z) - get number of node nearest to coordinate X,Y,Z
[x] K=KP(X,Y,Z) - same but for keypoints

Alternative Get Functions:

[x] element_number = NELEM(n, npos)
[x] centroid_x = CENTRX(N) - plus CENTRY and CENTRZ
[ ] adjacent_element_number = ELADJ(N, face)
[ ] mat_ID_to_be_used_for_contact = SECTOMAT(Sect1, Sect2)
[x] real_constant_ID_to_be_used_for_contact = SECTOREAL(Sect1, Sect2)
[x] x_coord = KX(N) - and equivalent for KY and KZ
[x] select_status_kp_N = KSEL(N)
[x] element_N_select_status = ESEL(N)
[x] select_status_line_N = LSEL(N)
[x] select_status_node_N = NSEL(N)
[x] select_status_volume_N = VSEL(N)
[x] select_status_area_N = ASEL(N)
[x] x_coord = NX(N) - and equivalent for NY and NZ
[x] x_cosine = NORMNX(N) - and equivalent for Y and Z
[x] x_cosine = NORMKX(N) - and equivalent for Y and Z
[x] next_higher_area_in_selection = ARNEXT(N)
[x] next_higher_element_in_selection = ELNEXT(N)
[x] next_higher_kp_in_selection = KPNEXT(N)
[x] next_higher_line_in_selection = LSNEXT(N)
[x] next_higher_node_in_selection = NDNEXT(N)
[x] next_higher_volume_in_selection = VLNEXT(N)
[x] x_struct_displacement = UX(N) - and equivalent for UY and UZ
[x] x_struct_rot = ROTX(N) - and equivalent ROTY and ROTZ
[x] temp_at_node = TEMP(N) (also weird things happen with SHELL131 and SHELL132, whcih use TBOT, TE1, TE2,... etc)
[x] pressure_at_node = PRES(N)
[x] voltage_at_node = VOLT(N)
[ ] x_magnetic_vector_potential = AX(N) - and equivalent AY and AZ
[ ] x_fluid_velocity = VX(N) - and equivalent VY and VZ
[x]  x_coordinate_fraction_way_along_a_line = LX(L, LFRAC) - and LY and LZ
[x]  x_component_slope_fraction_way_along_a_line = LSX(L, LFRAC) - and LY and LZ
[x] distance_between_n1_n2 = DISTND(N1, N2)
[x] distance_between_keypoints_k1_k2 = DISTKP(K1, K2)
[ ] distance_between_element_centroid_and_node_e1_n = DISTEN(E, N)
[x] angle_between_3_nodes = ANGLEN(N1, N2, N3)
[x] angle_between_3_nodes = ANGLEK(K1, K2, K3)
[x] node_nearest_node_n = NNEAR(N)
[x] keypoint_nearest_keypoint_k = KNEAR(K)
[x] element_nearest_node_n = ENEARN(N)
[x] area_triangle_from_nodes = AREAND(N1, N2, N3)
[x] area_triangle_from_keypoints = AREAKP(N1, N2, N3)
[ ] ARNODE(N) - I am not sure what this does from the description
[x] element_conected_to_node_n = ENEXTN(N, LOC)
[ ] dofs_active_at_node = NODEDOF(N)
[ ] node_in_position_X_on_face_Y = NDFACE(E, FACE, LOC)
[ ] face_of_element_containing_selected_nodes = NMFACE(E)
[ ] area_of_face_of_element = ARFACE(E)
[ ] attribute_number_assigned_to_element = EATT(E, VAL)
[ ] RCON(R, LOC) - ?
[x] magnetic_scalar_potential_at_n = MAG(N)

Describe the solution you'd like
all of these (or most of them at least) are spin-offs, or alternatives to the *GET methods, like shorthand ways to call it. Additionally a number of them are named in tricky ways that class with existing functions (like ESEL and NSEL), or are very similar (like NODE vs NODES). I think it would make sense to make functions that explain what they are without ambiguity.
Here is my proposed list:

NODE(X, Y, Z)  - mapdl.get_node_at(x, y, z)
KP(X, Y, Z) - mapdl.get_keypoint_at(x, y, z)
NELEM(N) - ?
CENTRX(N) - mapdl.get_centroid(n, x_coord=True, y_coord=False, z_coord=True)
ELADJ(N) - mapdl.get_adjacent_element(n, face)
ESEL(N) - mapdl.get_element_select_status(n)
ELNEXT(N) - ?
SECTOMAT(Sect1, Sect2) - ?
SECTOREAL(Sect1, Sect2) - ?
KX(N) - mapdl.get_keypoint_coords(n, x_coord=True, y_coord=False, z_coord=True)
KSEL(N) - mapdl.get_keypoint_select_status(n)
KPNEXT(N) - ?
LSEL(N) - mapdl.get_line_select_status(n)
LSNEXT(N) - ?
NX(N) - mapdl.get_node_coords(n, x_coord=True, y_coord=False, z_coord=True)
NSEL(N) - mapdl.get_node_select_status(n)
NDNEXT(N) - ?
VSEL(N) - mapdl.get_volume_select_status(n)
VLNEXT(N) - ?
UX(N) - mapdl.get_node_structural_displacement(n, x_coord=True, y_coord=False, z_coord=True)
ROTX(N) - mapdl.get_node_structural_rotation(n, x_coord=True, y_coord=False, z_coord=True)
TEMP(N) - mapdl.get_node_temperature(n) (not sure what to do for the other options
PRES(N) - mapdl.get_node_pressure(n)
VOLT(N) - mapdl.get_node_voltage(n)
AX(N) - mapdl.get_node_magnetic_potential_vector(n,  x_coord=True, y_coord=False, z_coord=True)
VX(N) - mapdl.get_nodal_fluid_velocity(n,  x_coord=True, y_coord=False, z_coord=True)

Describe alternatives you've considered
we could just use the commands as they are but I think this will be more trouble than it's worth as the commands are not easy to read and clash with a number of existing commands. Some of these commands may already exist, but I couldn't find them at first. Additionally I am not sure what the commands should be for some of these because I  didn't fully understand the explanations in the docs.
#353 Suggests one way of implementing features like this, with a class containing the functions themselves

Perhaps some commands would be better off combined?
E.g.
combine UX and ROTX:
mapdl.get_nodal_displacement(n, rotation=True, x_coord=True, y_coord=True, z_coord=True)

is this better? There are other instances this could be done.

See #353

@natter1 There's definitely overlap with #353, but I don't like using similar sounding APDL commands like NSEL as it is likely to generate confusion over which is being called. I'd prefer to include descriptive function names like the ones suggested above because it would be more explicit about what's going on (as extensions of the command get) and more pythonic overall.

But really, I'm not completely sure. What do you think?

I'm also not sure. As I used a class Inline, there is no risk for confusion imho. But thats also not optimal. In APDL all these functions are meant to be called inline (you can't call them alone). I think it has an advantage to keep the APDL names at least for experienced APDL users. When changing the names it might be better to think about a completly Independent functionality - no reason to mirror the APDL inline functions when changing the names anyway.

I think having a variety of methods to make the *GET method more pythonic would be great.  A few caveats:
Getters and setters in python generally don't use get vs set.  It's generally non-pythonic and we could consider an alternative way of implementing this.  For example, (since it's a solution based approach), we would implement mapdl.get_node_temperature(n) as:
mapdl.solution.node_temperature(n)

or we can do this from parameters or create a new attribute.
Having this nested with another attribute would be ideal.  We already have ~1500 commands that are directly exposed at the mapdl.<root> level, exposing a ton of get commands would be an anti-pattern.
However, if done right, we can implement this in the right way, it will be really great to have something that looks like:
mapdl.<some attribute>.nodal_fluid_velocity(n, x_coord=True, y_coord=False, z_coord=True)

With documentation, this would make it much easier for users to access parameters without using the *GET commands.

I think it would be fine to do it this way but I'd disagree that it is more pythonic. In all the getter/setter examples that talk about the pythonic way to handle them, it is assumed that there is a property. Whereas, here we only have getters. Given that the getters in our situation additionally perform various actions and take arguments, they're better suited to behave as methods rather than attributes.
It is strange to see a property taking arguments! There's a good discussion of this scenario here.
One reason for keeping the word get in the commands is to draw association with the existing *GET (and mapdl.get) command, since these commands are all shortcuts for *GET, which is implemented already as mapdl.get. I'd argue that from a consistency standpoint it would make more sense to have these "shortcut" get methods in the same location as the existing mapdl.get, so that should a user type mapdl.get and use tab-completion, or similar, in their IDE they are automatically suggested all the different shortcuts that stem from the original command. Users go to use get and have better alternatives suggested to them, like putting similar products next to each other in the supermarket.
For example, here is a dummy mapdl example I made to demonstrate what a user might see (I left out the arguments and made the names up).

The downside to this would be that we would have to add to the ~1500 root commands, but then again there are already ~1500, so what's another 26? We are going to eventually have to refactor those 1500 anyway, so it might be better to leave that refactor until then and make sure the code we have to work with when that happens doesn't trip us up later. Basically, if we do some sort of new pattern, are we inadvertently locking the inevitable refactor into what we decide now?

Hm, I still think it would be worth to consider a completely independent (from get-functions) interface. I'm not sure if internally we still need to use the get-function, but for the user, it might be more intuitive to access information differently. E.g.:

mapdl..nodal_fluid_velocity(n, x_coord=True, y_coord=False, z_coord=True)

I'm not sure if I understand the boolean parameters. I would expect a float value or (imho better, but maybe with another method-name) a vector with x, y and z component. Also, if its a "solution", would it be possible to get e.g. a complete "time"-series (meaning all load-steps) as an ndarray (or a class object with additional options)? Or for mapdl.solution.node(n) - why not return all available results of this node? Or specify relevant load-step(s) in solution. What about n? Does it have to be only one node? Why not allow an list/array of nodes? Whats the difference to mapdl.post_process....? Why do I have to ask for individual nodes in the first place instead of having a python object representation of the curent model/results? Thats just a few ideas, nothing that I have considered carfully. But I think it shows what I mean with an independend interface that uses the power of python instead of just mimicing APDL-get-commands. When its simply the get-functionallity, thats mainly addressing experienced APDL-users anyway.
Also, in a way I see the addition of new method names as a larger question. Its not like only the get-function is unpythonic. The same is true for most if not all APDL commands. So do we want to create a seperate more pythonic interface? There are other ideas for that, e.g. #447. It might be a good idea to change this to a discussion instead of an issue.

@natter1 I agree! We absolutely should create a separate interface, we should lever all the benefits that Python brings to make the user experience with PyMAPDL as easy as possible. This will, however, mean that we'd have to stop almost all work on PyMAPDL as it is and focus on the refactor for as long as that takes, which would probably be quite a long time. But then again, this still needs to be done, and it's not going to be much better later, so some kind of compromise would be good maybe?
At the moment, however, I am trying to convert the verification APDL examples to PyMAPDL examples and have been blocked because they use a number of these get-shortcut commands that don't exist in PyMAPDL yet. I don't think these would be particularly difficult to implement as I go, with the main issue being how to name them. We should still do these in the best way we can within the limitations because they'll likely still be in use for some time before we can refactor everything properly. Does that make sense?

To address the confusion behind the boolean parameters. I think this is because the command is meant to be getting the fluid velocity component at node N but it looks like one is getting the fluid velocity as a vector at coordinate (x,y,z)?
The intended behaviour is actually that mapdl.nodal_fluid_velocity(n, x_coord=True, y_coord=False, z_coord=False) would return Vx for that node.

At the moment, however, I am trying to convert the verification APDL examples to PyMAPDL examples and have been blocked because they use a number of these get-shortcut commands that don't exist in PyMAPDL yet.

Ok, but in that case I would agree with @akaszynski to seperate them somehow. I would like to leave the mapdl-object for the original APDL commands. Something like mapdl.inline. ... or mapdl.get. ... or ... ?

I would like to leave the mapdl-object for the original APDL commands.

The number of methods/attributes available is already overwhelming, we're going to have to nest this within another attribute.  Since get is already taken, let's create a Query class and add in a query property that returns the instance of the Query class (as we did for mesh, post_processing, etc.)

So I've been thinking about this and I think I've changed my mind and I agree with you both. I'll come up with a draft implementation and see how it goes.

Stupid question - are these shortcuts implemented in a release version already? Couldn't find them ^^

Not a bad question.  Most of them are out in 0.59.5 and documented in https://mapdldocs.pyansys.com/api/inline.html
Let us know if there are any issues using these.

Nice work, thanks. I tried several of the *GET inline functions and they work well. One suggestion: it would be helpful to document all that have been implemented. For instance, the docs do not state that enextn(node,loc) has been implemented, but it appears to be working just fine.

Pinging @jgd10  to get some updates on this. Are you still working on this?


Improving TTA promo page

Trello card
https://trello.com/c/YjpbDshJ/4000-improve-teacher-training-advisers-page
Context
The TTA service is experiencing a reduction in sign-ups compared with last year, which in turn was worse than the year before.
Following user research insight, we should update the Teacher training advisers page.
Changes proposed in this pull request
In this PR I've:

added a section explaining how to contact an adviser
restructured the page by consideration stage
tweaked the quotes
removed predicted grades for students
removed the videos (these had barely any clicks in GA)
added blog links similar to in is teaching right for me at the bottom of the page
moved the 'Not a final year student or graduate?' section - having this before the blog links made it look to me like the blogs were about ETAs. I thought it might make more sense to make that section into a h3 under 'Can I get an adviser?' and move the CTA down (you can use the funnel to sign up for both TTAs and ETAs anyway).

Gary's going to tweak the blog link component for this page (and others) - I just added the current version in here for now to give a sense of how this might look. This is by no means what would actually go out (there are some issues with image sizing currently).
Update: Having discussed the blog links with Phil, we think we should aim to publish the updates to the rest of the page without these and revisit in the new year. Naeem said he'll start to recruit for some more case studies in the new year so might be a good idea to put a pin in this for now so we can consider these, too? Now that we've added more quotes throughout the page, having the extra quotes in the blog links at the bottom might actually be overkill - to discuss in UCD.
What I've not done in this PR:

updated the image (but will probably get Ross to do this in this PR?)

Guidance to review

@gazcarr @ethax-ross the new image kinda cuts off the top half of their faces - is there a way to fix this?


Projects beta parity with projects classic (milestone 2)

Summary
In order to help teams migrate over from projects classic, we have a number of areas where we are working towards feature parity. Following on from our work last quarter, in progress for this quarter are:

[ ] Project events are included in issue / pull request timelines
[x] Ability to delete a project

🚢 Partially shipped!

🚢 All of these features have shipped:

Issue/PR numbers: https://github.blog/changelog/2022-09-02-the-new-github-issues-september-2nd-update/
Linking projects to teams: https://github.blog/changelog/2022-09-27-the-new-github-issues-september-27th-update/


Implements minNumberOfItems

Implements https://github.com/Yummypets/YPImagePicker/issues/139#issuecomment-398556246
@cwestMobile Let me know if that looks good to you :)

@cwestMobile you're welcome sir! We'll wait for @NikKovIos to give it a look and we should be good then :)


Output update during the running

Instead of the output showing up at the end, it should be updated every character


ApplicationModuleTest in Nested JUnit Test fails

Hello,
i recognized a weired behaviour when executing JUnit tests using @ApplicationModuleTest. The following example is a simplified demo to reproduce the error. In this example i am using version 1.2.1 of the modulith project.
If i execute the tests the innner test within the nested class fails. If i uncomment the test case in the outer class both tests are successful. The demo is a simple project with just one module (link to the demo project at the end of the issue).
@ApplicationModuleTest
@Import(TestcontainersConfiguration.class)
public class AbstractCustomerTest {
}

@Sql(executionPhase = BEFORE_TEST_METHOD, scripts = {"classpath:sql/customer.sql"})
class CustomerServiceTest extends AbstractCustomerTest {

	@Autowired
	private CustomerService service;

//	@Test
//	void getCustomer() {
//		assertThat(service.get(1L))
//				.isNotNull()
//				.satisfies(c -> {
//					assertThat(c.id()).isNotNull();
//					assertThat(c.name()).isEqualTo("John Doe");
//				});
//	}

	@Nested
	class Slice {

		@Test
		void getCustomer() {
			assertThat(service.get(1L))
					.isNotNull()
					.satisfies(c -> {
						assertThat(c.id()).isNotNull();
						assertThat(c.name()).isEqualTo("John Doe");
					});
		}

	}

}

A complete sample application can be found here: https://github.com/chhorz/modulith-test-demo

My initial investigation shows that for @Nested classes, a different kind of ApplicationContext arrangement is in play. One is created for the main class. That will get the schema creation applied. For the @Nested class, a new ApplicationContext instance gets created, the schema gets applied to the new DataSource. The initializing script, however, is then executed against the DataSource instance of the first ApplicationContext. That makes sense to some degree, as the annotation lives on the class declaration the AC is created for.
In other words, I don't think this is a problem of Spring Modulith, but the question of how Spring's SQL initialization functionality interacts with nested ApplicationContext instances. On the other hand, I wonder if that second AC should be created at all, i.e., whether we need to fix something about the cache key created for @ApplicationModuleTest.
@sbrannen – Would you mind taking a look? Under what circumstances would you expect a new AC to be created for @Nested classes? If the additional AC creation is expected, how would one declare a SQL script to be executed against the DataSources created in these nested ACs?

I have not yet had a chance to look at / debug the running application, but I can provide a few pointers in the interim.

In other words, I don't think this is a problem of Spring Modulith, but the question of how Spring's SQL initialization functionality interacts with nested ApplicationContext instances.

The Javadoc for @Sql states: This annotation will be inherited from an enclosing test class by default. See @NestedTestConfiguration for details.

On the other hand, I wonder if that second AC should be created at all, i.e., whether we need to fix something about the cache key created for @ApplicationModuleTest.

My hunch is that the second ApplicationContext should not be created.

@sbrannen – Under what circumstances would you expect a new AC to be created for @Nested classes?

Only if the MergedContextConfiguration is different for the enclosing class and nested class.
Thus, I'd turn on DEBUG or TRACE logging for the TestContext framework to see what the cache keys are (i.e., the MergedContextConfiguration values).
It may be that Spring Modulith needs to makes use of TestContextAnnotationUtils to resolve the issue, but that's just a guess (without having debugged the code).
Let me know what you find out about the context cache keys and whether you still need me to dig deeper.
Cheers,
Sam

Thanks! That's been very helpful, Sam! I've diagnosed a broken equals(…)/hashCode() in some of the infrastructure feeding into the context customizers. Fix coming.

This is fixed for 1.3 now. Will be back-ported to 1.2 and 1.1 as well.

Thanks! That's been very helpful, Sam!

🙇

I've diagnosed a broken equals(…)/hashCode() in some of the infrastructure feeding into the context customizers.

Yep, those are often the cause for context cache hit/miss issues.
Glad you sorted it out!


Make Mutex 'name' required. Bunch of formatting changes, add test for custom extension

Related to #68

Codecov Report

Merging #72 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   96.54%   96.55%   +<.01%
==========================================
  Files          53       53
  Lines        4807     4814       +7
==========================================
+ Hits         4641     4648       +7
  Misses        166      166

Impacted Files
Coverage Δ

stix2/test/test_custom.py
100% <100%> (ø)
:arrow_up:

stix2/observables.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e3b3c...2b65f72. Read the comment docs.

Looks nice! Should we also check that the custom extension's properties arg is not an empty dict ({}) in addition to checking that it's not None?

That's right, we should also check is not empty. Good catch!

Could you add it, as part of merging with master?

Will do.


feat: custom template delimiter

default delimiter: {{ }}
set delims: yap.SetDelims("${", "}$") or setDelims "${", "}$"

YAP doesn't want to support custom delimiter since html/template doesn't support it.


Search field on v1.gorm.io redirects to gorm v2 documentation

We still use gorm v1 and its documentation, but unfortunately the search fields seems to search on the new documentation. Could you try to fix that?
Thanks!

the search is powered by other service, we can't make the change, maybe use google with site:v1.gorm.io


chore: remove css hash prefix

Addresses: https://github.com/atlassian-labs/compiled-css-in-js/issues/122

will reopen


Release attachments remain on disk after deleting the release

Gitea version (or commit ref): 1.2.0+rc3
Git version: 2.11.0
Operating system: Debian GNU/Linux 9 (stretch)
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Description
When deleting a release, the files attached to this release are not deleted from the data/attachments folder of Gitea.

Unstale

Quick question: If I have deleted some releases with attachments earlier, how do I remove them from disk as of now? Is there any way to "clean" the attachments folder?

Currently no tool to do that and I think we need a tool to clean that on admin panel or command line.

I should find time to complete https://github.com/go-gitea/gitea/pull/6068

IMO, when editing release draft, the uploaded attachment should be appeared in the list.
I want to know if I'm right if the api become stable?


iOS: ColorPicker does not respond to user interaction

When Interacting with the colorpicker under iOS, there is no response from UI, nor does the color actually change.
Only tested on Simulator, actual device behaviour may be different.

Fixed with Commit 62778f9


Nextcloud Theming Favicon Resets when nextcloud-update-plugins

Describe the bug
A custom favicon set in Nextcloud Admin > Settings > Administration > Theming resets itself regularly. My theory is that this occurs every time a plugin is updated through the nextcloud-update-plugins.service. Interestingly, the favicon is only reset to the default favicon on the landing page, as soon as you log in the custom favicon is displayed.
Steps To Reproduce
Steps to reproduce the behavior:

Install Nextcloud Module
Set up custom favicon in theming
Wait until it is reset to the default favicon automatically

Expected behavior
A custom favicon should stay the favicon on all pages constantly.
Additional context
When the problem occurs, on the landing page the browser developer tools shows this HTML
<link rel="icon" href="/core/img/favicon.ico">

When logging in it shows this HTML
<link rel="icon" href="/apps/theming/favicon/settings?v=28">

When again setting up the favicon in Settings, on the landing page it shows this HTML
<link rel="icon" href="/apps/theming/favicon?v=30">

Until it resets automatically again. This cycle continues...
Notify maintainers

Cannot reproduce, at least it doesn't reset when running nextcloud-update-plugins.service. Also, "Wait until X" isn't really helpful when having to reproduce something :)
It would be helpful to know which version of Nextcloud and which apps you're using. Also, are there any helpful logs? And would you mind sharing your config?
I'm also not really sure if that's an actual distro bug. Have you checked if there are similar issues reported in the upstream issue-tracker?

Cannot reproduce, at least it doesn't reset when running nextcloud-update-plugins.service. Also, "Wait until X" isn't really helpful when having to reproduce something :)

Hmm, I should have been more clear. You have to wait until an app update is executed through nextcloud-update-plugins.service. For this you have to wait until an app becomes outdated, no?

It would be helpful to know which version of Nextcloud and which apps you're using. Also, are there any helpful logs? And would you mind sharing your config?

Enabled:
  - activity: 2.15.0
  - calendar: 2.3.3
  - cloud_federation_api: 1.4.0
  - comments: 1.11.0
  - contacts: 4.0.2
  - dav: 1.18.0
  - federatedfilesharing: 1.11.0
  - files: 1.16.0
  - files_pdfviewer: 2.3.0
  - files_rightclick: 1.1.0
  - files_sharing: 1.13.2
  - files_trashbin: 1.11.0
  - files_versions: 1.14.0
  - logreader: 2.7.0
  - lookup_server_connector: 1.9.0
  - notifications: 2.10.1
  - oauth2: 1.9.0
  - photos: 1.4.0
  - privacy: 1.6.0
  - provisioning_api: 1.11.0
  - recommendations: 1.1.0
  - richdocuments: 4.2.2
  - serverinfo: 1.12.0
  - settings: 1.3.0
  - text: 3.3.0
  - theming: 1.12.0
  - twofactor_backupcodes: 1.10.1
  - twofactor_totp: 6.1.0
  - twofactor_u2f: 6.2.0
  - viewer: 1.6.0
  - workflowengine: 2.3.1
Disabled:
  - accessibility
  - admin_audit
  - circles
  - contactsinteraction
  - dashboard
  - deck
  - encryption
  - federation
  - files_external
  - files_videoplayer
  - firstrunwizard
  - nextcloud_announcements
  - password_policy
  - richdocumentscode
  - sharebymail
  - support
  - survey_client
  - systemtags
  - tasks
  - updatenotification
  - user_ldap
  - user_status
  - weather_status

{
    "system": {
        "apps_paths": [
            {
                "path": "\/var\/lib\/nextcloud\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/lib\/nextcloud\/store-apps",
                "url": "\/store-apps",
                "writable": true
            }
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "skeletondirectory": "",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "simpleSignUpLink.shown": false,
        "lost_password_link": "disabled",
        "log_type": "syslog",
        "log_level": "2",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "version": "<IP_ADDRESS>",
        "overwrite.cli.url": "http:\/\/localhost",
        "dbport": "",
        "dbtableprefix": "oc_",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "XX",
            "XX"
        ],
        "twofactor_enforced_excluded_groups": [],
        "memcache.local": "\\OC\\Memcache\\APCu",
        "loglevel": 2,
        "maintenance": false,
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "ssl",
        "mail_sendmailmode": "smtp",
        "default_phone_region": "XX",
        "trashbin_retention_obligation": "auto, 30",
        "trusted_domains": [
            "cloud.example.com",
            "www.cloud.example.com"
        ]
    }
}

I'll attach logs as soon as this issue occurs again.

I'm also not really sure if that's an actual distro bug. Have you checked if there are similar issues reported in the upstream issue-tracker?

Couldn't find anything similar upstream.
I disabled autoUpdateApps and will see if this issue also occurs on manual app updates.


mailspring: Disable trackerSupport for it's gtk3

I'd be delighted to know why this works. Asked @jtojnar for a review because you authored https://github.com/NixOS/nixpkgs/pull/101537 .
Motivation for this change
Fix this error:
mailspring: ../src/workers/open.cc:28: virtual void OpenWorker::Execute(): Assertion `sqlite3_db_mutex(db->db_handle) == __null' failed.

It's a (mostly) closed source software so perhaps it's not going to be easy to explain this.
Close #106732 .
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Now when I think about it, this might fix the issue because mailspring is compiled upstream without tracker support..


Scheduler

When i click done, it will error...

Hello!
Try setting the "dataSource" option. If this doesn't help, please provide us with an example or project where the problem is reproduced. We need more information to research the issue on our side.

I'm closing the issue. Please reopen in case of any questions.

Ok


Adaptive cards in Teams documentation first draft

Here's the first draft for the upcoming change to add support for adaptive cards. I've kept it fairly simple since a lot of the documentation exists on the adaptive card side already. Do let me know if this is enough or what other changes are required

:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/concepts/Cards/cards-actions.md
:warning:Warning

Details

msteams-platform/concepts/Cards/cards-reference.md
:warning:Warning

Details

msteams-platform/assets/images/Cards/adaptivecard.png
:white_check_mark:Succeeded

msteams-platform/concepts/cards/cards-format.md
:white_check_mark:Succeeded

msteams-platform/concepts/Cards/cards-actions.md

Line 216: [Warning] Invalid file link:(~/concepts/authentication/auth-flow-bot).

msteams-platform/concepts/Cards/cards-reference.md

Line 41: [Warning] Invalid file link:(~/concepts/cards/cards-actions).
Line 45: [Warning] Invalid file link:(~/concepts/cards/cards-format).
Line 223: [Warning] Invalid file link:(~/concepts/cards/cards-format).
Line 372: [Warning] Invalid file link:(~/concepts/cards/cards-format).
Line 384: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 470: [Warning] Invalid file link:(~/get-started/code#microsoft-teams-extensions-for-the-bot-builder-sdk).
Line 509: [Warning] Invalid file link:(~/concepts/authentication/auth-flow-bot).
Line 538: [Warning] Invalid file link:(~/concepts/cards/cards-format).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

FYI @billbliss @ninadara @NormSohl


Crouch and Slide Function

This script is great and I love running around my own levels. It does need the crouch and slide function to further encapsulate the feel of a mirror's edge movement system. Is this in the pipeline?

Hi, sliding and crouching is currently not in this example project. It can be implemented by changing the height of the capsule collider


(3.0.53) restart icon not displayed until mouse over ...

Before:

After:

@LisaAlmarode @ericwinger doesn't see this in his environment ...

This is worth reviewing in 3.1.0.  I suspect an toolbar button display problem in Dolphin that I don't see in the latest Dolphin code.

I see this icon in 3.2.12, and with the dophin port we might be okay; close.


next() resolves undefined on nested upsert

If I perform a nested upsert, then next() will always return undefined.
I expect that next() should return the upserted document, if it is available due to an include statement.
Below is minimal reproduction of the issue:
Schema:
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model User {
  id      Int      @id @default(autoincrement())
  email   String   @unique
  name    String?
  profile Profile?
}

model Profile {
  id     Int     @id @default(autoincrement())
  bio    String?
  age    Int?
  user   User?   @relation(fields: [userId], references: [id])
  userId Int?    @unique
  meta   Json?
}

Code
import { PrismaClient } from "@prisma/client";
import { createNestedMiddleware } from "prisma-nested-middleware";

const prisma = new PrismaClient();

prisma.$use(
	createNestedMiddleware(async (params, next) => {
		const result = await next(params);
		if (params.model === "Profile" && params.action === "upsert") {
			console.log("mdlwr Profile", result);
			console.log("mdlwr Params", params);
		}

		return result;
	}),
);

const run = async () => {
	const user = await prisma.user.upsert({
		create: {
			name: "Alice",
			email<EMAIL_ADDRESS>		},
		update: {
			name: "Alice",
			email<EMAIL_ADDRESS>		},
		where: {
			email<EMAIL_ADDRESS>		},
	});

	await prisma.user.update({
		where: {
			id: user.id,
		},
		data: {
			name: "Bob",
			profile: {
				upsert: {
					create: {
						bio: "I like turtles",
					},
					update: {
						bio: "I like turtles",
					},
				},
			},
		},
		include: {
			profile: true,
		},
	});
};

run();

When you run this code, the result value in the middleware is always undefined for Profile upserts.
Looking at the code, it seems that next() will always resolve to undefined if a write query is being performed.
If I comment out this line https://github.com/olivierwilkinson/prisma-nested-middleware/blob/main/src/lib/utils/targets.ts#L103 then the code behaves as expected, however I'm not 100% sure why this exists, and the prisma-nested-middleware unit tests fail if I remove it.

Heya,
Sorry for the slow response! 🙏
So this is actually the expected behaviour since v3, the reason for the change is that it's not always possible to match the included results for a relation with the nested write. For example if the relation was a toMany relation, say "posts", it's not possible to match the upsert with the post that was operated on.
There is a way to modify the included results however, by using the 'include' and 'select' action types, for your example above you should be able to replace "upsert" with "include" and find the result is returned. There are some more details to consider so have a look at the Modifying Results section of the readme, let me know if it's unclear or needs more info 👍
I hope that is helpful!

I'm going to close this but feel free to continue commenting on it if you want to talk about the above more! 👍


New Endpoint: <playlis_id>/analysis/keys

Create a new API endpoint to get the key data from Spotify for a playlist, parse the data and return it in proper formatting for easy Front-End Chart.JS integration.
Required Params: Spotify Playlist ID Number
Headers: Authorization: <access_token>
Route: <playlist_id>/analysis/keys
Return Type: JSON Object
Format: {major: {A: 3,                                 A#: 4,                                 B: 2,                                 ...},                   minor: {A: 6,                                 A#: 2,                                 B: 7,                                 ...}                      }
This will allow for easy plotting in Chart.JS as a bar chart

Route created and tested - closing issue


Add support for horizontal rule in markdown files

In markdown files using --- will have a line be created. This can be implemented in HTML by using a
 tag for when --- is seen in a file.
To implement this update the markdownfeat() function to also replace any standalone --- in markdown files with an
 element.

Added in commit https://github.com/ijacobs-cpa/textml/commit/c1e4bff3aa7c9be4f370bd1ef5c2ea5991bb8a86


Content Updates to About / Welcome

@croundy and I have made a pass through the text and have some minor suggestions. The main one is not using the term 'Eclipse Theia Blueprint product' andf replacing it with just 'Eclipse Theia Blueprint'.
PR to follow.

Thanks, sounds good to me, I already commented on the PR.

@brianking Issue can be closed, right? If so please go ahead and close the issue. Thanks!


1007 - Bedspace usage report endpoint

https://trello.com/c/GQxvkTmU/1007-download-a-report-on-all-bookings-voids-and-turnaround-times

 Download a report on all bookings, voids and turnaround times

@tahb requested a rereview as made some small fixes around date ranges being inclusive + turnarounds starting the day after departure


Should we add our list of partners (logos) to the Website

Given that we have signed contracts with some of our partners, we can add there logos and even think of adding there testimonials if required in the future.

Yes. We can start with logos atleast.

We're updating CDL's website and such changes will be taken care of in the updated version. Closing this now.


Fix setFilterValue with inexistent filter element

Fix bug described in #487:

make setFilterValue helper method more defensive to prevent js exception when filter DOM element does not exist

Codecov Report

Merging #489 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   87.54%   87.56%   +0.02%
==========================================
  Files          38       38
  Lines        4391     4392       +1
  Branches      334      333       -1
==========================================
+ Hits         3844     3846       +2
+ Misses        526      525       -1
  Partials       21       21

Impacted Files
Coverage Δ

src/tablefilter.js
91.94% <100%> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a878c9...f96166b. Read the comment docs.

:shipit:


Istio installation using IOP failed when hpaSpec for cpu utilization configured  for components

Installing istio with IOP(default profile) failed when hpaSpec for cpu utilization configured.
Error message -
- Processing resources for Istio core.
   ✔ Istio core installed
   - Processing resources for Istiod.2022-08-30T23:43:32.119129Z        error   installer       failed to update resource with server-side apply for obj HorizontalPodAutoscaler/istio-system/istiod: failed to create typed patch object (istio-system/istiod; autoscaling/v2beta1, Kind=HorizontalPodAutoscaler): .spec.metrics[0].resource.target: field not declared in schema

   ✘ Istiod encountered an error: failed to update resource with server-side apply for obj HorizontalPodAutoscaler/istio-system/istiod: failed to create typed patch object (istio-system/istiod; autoscaling/v2beta1, Kind=HorizontalPodAutoscaler): .spec.metrics[0].resource.target: field not declared in schema

Istio version - 1.14.3
Kubernetes version - 1.24.3
Attachments: Istio IOP file generated using istioctl profile dump
istio_1.14.3_default_profile.txt

Minimal reproducer:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  components:
    ingressGateways:
    - enabled: true
      k8s:
        hpaSpec:
          metrics:
          - resource:
              name: cpu
              targetAverageUtilization: 80
            type: Resource
      name: istio-ingressgateway
  values:
    pilot:
      cpu:
        targetAverageUtilization: 80

this should be some bug in manifest generate and server side apply, you can template workaround by running:
istioctl manifest generate -f istio/iop/hpa-not-working.yaml | k apply -f -

you can workaround by using:
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
spec:
  components:
    pilot:
      k8s:
        hpaSpec:
          metrics:
          - resource:
              name: cpu
              targetAverageUtilization: 80
            type: Resource
    ingressGateways:
    - enabled: true
      k8s:
        hpaSpec:
          metrics:
          - resource:
              name: cpu
              targetAverageUtilization: 80
            type: Resource
      name: istio-ingressgateway
  # values:
  #   pilot:
  #     cpu:
  #       targetAverageUtilization: 80


Add video to Markdown example

This commit adds a tutorial video to the Markdown example.  Styling is based on other video links within the docs.
The video uses the current example as a jumping off point and adds two common use cases: SSR compatibility and syntax highlighting.
Hopefully readers will find this useful as-is, but if there's anything you'd like me to change about the video, please let me know and I can do a "docs edit" based on those recommendations.

Thank you, but I don't think this is necessary.

Thanks for your feedback @phanan .
To help me contribute better in the future, and thus save us both time, could you help me pinpoint what the issue was - and therefore, what I can do better next time?
I can see five possible issues:
A) Markdown is so simple that users will not benefit from a video
B) The video expanded upon what was in the example, and you'd prefer it stuck to what's already in the text
C) There's something about my presentational style that needs to be modified before it's acceptable in the docs
D) The PR was unexpected, and given the relative low priority of this page it was not worth your time to watch the video and make a specific judgement
E) The video is hosted on YouTube, which is not available in all countries
Given your phrasing of calling it "not necessary", I'd assume it's either A or D, but I'd like to confirm - but if it was just you being polite, and the issue is something else, then that will be good to know.
Thanks so much, and I hope to be able to contribute better in the future!


python warning

Hi,
I am using python 3.8.10 and get following error

/home/matt/.local/lib/python3.8/site-packages/fxpmath/objects.py:597: FutureWarning: Conversion of the second argument of issubdtype from complextonp.complexfloatingis deprecated. In future, it will be treated asnp.complex128 == np.dtype(complex).type.   if original_vdtype != complex and not np.issubdtype(original_vdtype, complex):
That is only  awarning and not an issue for my work but that would be good to fix it when got time.
BWT, thanks for the library. helped with my project a lot!

Hello @mehdimolum
Thanks for reporting the warning. It will be taken into account in next release!
I'm very glad about the library is useful for your project.

It should be solved in version 0.4.3.
I'm going to close the issue. Feel free to reopen it if the problem was not solved.
Thanks!


Dependent hardware

Closes #18
This is an initial implementation paired with a change to yaqd-attune, which are the first (And so far only, to my knowledge) daemons to have dependency relations.
In the future this should likely become a trait and not be a special cased hasattr check, but going quick and dirty for now
I would like to put the keys (regardless of whether connection is successful) somewhere that shows up in the event descriptor doc, just not sure whether that should be in configuration or a custom hints field, maybe?
That will be what is used primarily by UIs/plans, such as for our tuning methods.
One question I have is should we make the dependent hardware dict public, rather than private (as currently implemented) to make it explicit that things like plans can reach in?

One question I have is should we make the dependent hardware dict public, rather than private (as currently implemented) to make it explicit that things like plans can reach in?

Yes, I think this should be public.

@ksunden is this worth testing? Maybe just open an issue to add tests later?

Testing is not super easy, involves setting up several daemons with interconnected configs... doable, but not super trivial... I say push off...


globals: add postgis version for 9.6

Simple patch to add the appropriate PostGIS version for 9.6.

Build is currently failing because of #803

Re-ran travis and all green 👍