💅 noUndeclaredDependencies - works fine during check, reports false-positives in WebStorm, VSCode and during precommit hook using lefthook

Environment information
CLI:
  Version:                      1.7.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.19.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.2.4"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Linter:
  Recommended:                  true
  All:                          false
  Rules:                        a11y/noSvgWithoutTitle = "off"
                                a11y/useKeyWithClickEvents = "off"
                                a11y/useKeyWithMouseEvents = "off"
                                a11y/useValidAnchor = "off"
                                complexity/noExcessiveNestedTestSuites = "error"
                                complexity/noUselessLoneBlockStatements = "error"
                                complexity/noUselessTernary = "error"
                                correctness/noInvalidUseBeforeDeclaration = "off"
                                correctness/noNewSymbol = "error"
                                correctness/noUnusedImports = "error"
                                correctness/noUnusedPrivateClassMembers = "error"
                                correctness/noUnusedVariables = "error"
                                correctness/useExhaustiveDependencies = "off"
                                correctness/useHookAtTopLevel = "error"
                                nursery/noConstantMathMinMaxClamp = "error"
                                nursery/noEvolvingAny = "error"
                                nursery/noFlatMapIdentity = "error"
                                nursery/noMisplacedAssertion = "error"
                                nursery/noUndeclaredDependencies = "off"
                                performance/noDelete = "off"
                                style/noNegationElse = "error"
                                style/noNonNullAssertion = "off"
                                style/noRestrictedGlobals = "error"
                                style/noShoutyConstants = "error"
                                style/noUnusedTemplateLiteral = "off"
                                style/useBlockStatements = "error"
                                style/useCollapsedElseIf = "error"
                                style/useForOf = "error"
                                style/useImportType = "error"
                                style/useNodejsImportProtocol = "error"
                                style/useNumberNamespace = "error"
                                style/useShorthandAssign = "error"
                                style/useShorthandFunctionType = "error"
                                style/useSingleCaseStatement = "error"
                                suspicious/noConsoleLog = "error"
                                suspicious/noRedeclare = "off"
                                suspicious/noSkippedTests = "off"

Workspace:
  Open Documents:               0

Rule name
noUndeclaredDependencies
Playground link
not applicable
Expected result
I don't really know what additional info to provide. I will try to create a reproducible repo, but for now this all I have.
Note that this is a monorepo. Dependencies are declared NOT in root package.json file.
/package.json
/apps
    /app-1
        /package.json      <- dependencies used in `File.tsx` are declared here
            /src
                /File.tsx

When running npx biome check I see no errors. But at the same time WebStorm and VSCode highlight imports as errors, and I see the same error during precommit hook.
npx biome check:

git commit:

WebStorm:

Let me know if I need to provide more info, thank you!
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

Within the monorepo setting include biome.json at the root of your monorepo. Third-party tools cannot into multi-root setups like monorepos and cannot read multiple biome config files.
It sucks, especially if you use different configs for different projects within the monorepo, but so far it is the least problematic setup.

I have single biome.json and it's is in the repo root. I don't have Biome configuration issue, it just reports things differently in IDE/precommit hook and from CLI

I think this is because the root directory detection (cwd) has different results in CLI, LSP and git hooks. I will look into this issue.

I did some debugging but couldn't find time to implement the fix, others are welcome to tackle it. Here is what I found:

The problem is not only about LSP, it also happens in CLI commands, see #3202
The reason is that we associate only one manifest file for each project. It will only resolve it once from the workspace root or working directory. However we can have many manifest files in a project like a monorepo in this issue. Relative code at https://github.com/biomejs/biome/blob/42bc279a7282be7bc11778204ec1bc8a822a3703/crates/biome_cli/src/commands/mod.rs#L555 and https://github.com/biomejs/biome/blob/42bc279a7282be7bc11778204ec1bc8a822a3703/crates/biome_lsp/src/session.rs#L552
To fix it we may need to revamp the structure of the project/workspace internal structure.

For me, it fails to detect dependencies in a pnpm monorepo workspace even from CLI. It also errors out in VsCode.


Add this repo to the admin team

@lgierth @RichardLitt @whyrusleeping @jbenet
Instead of having to ping you every time. It might be easier and totally worth it to just make me an admin of the org

totally agreed -- not sure why you haven't been so far

thank you @lgierth  <3


Fix to keep minimal backward compatibility with Camel 4.1-

it would throw this kind of exception otherwise: Caused by: java.lang.NoSuchMethodException: org.apache.camel.management.mbean.ManagedBacklogDebugger.dumpTracedMessagesAsXml(java.lang.String)

With Camel 4.1:


Fix to support subscriptions

Hello @insign thanks for the PR. Can you please add a description on this PR? Like, what has been changed and what's the purpose of the changes. Thanks.

Not applicable in the latest master. Thanks.


Update index - Copy (10).md

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/kimizhu/realtimeinsighttest, working directory: W:\wqv5-s, target branch: master, target branch commit: 31f9cf59dc650f2ead180e7bddabaa2d07828a20, source branch: master-pr, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/kimizhu/realtimeinsighttest, working directory: W:\yftl-s, target branch: master, target branch commit: 31f9cf59dc650f2ead180e7bddabaa2d07828a20, source branch: master-pr, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/kimizhu/realtimeinsighttest, working directory: W:\3xpo-s, target branch: master, target branch commit: 31f9cf59dc650f2ead180e7bddabaa2d07828a20, source branch: master-pr, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:cloud: Pending: waiting for processors (13 builds ahead you)

Note: You can also view OPS Portal for detail build statistics, or click here to report any potential performance downgrade issues.

:clock10: Preparing: avg. preparing time 1 min(s) 15 sec(s)

:x: Validation status: errors

File
Status
Preview URL
Details
Dependent Files

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/kimizhu/realtimeinsighttest, working directory: W:\d425-s, target branch: master, target branch commit: b0b81634bb60064ecab32cfce52d49211b979103, source branch: master-pr, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


A Java script error occurred in the main process

OS:
Windows 10 Pro x64
Issue Descriptions:
"
A Java script error occurred in the main process
Uncaught exception
SyntaxError: Unexpected Token
"

Steps to Reproduce:
Open app - from fresh install even... nothing works.
Google play works fine in browsers.

Delete your settings file at %APPDATA%/Google Play Music Desktop Player/json_store


Migrate Apple network stack to Go

Merges the iOS and macOS clients' Go network stack from the go-tun2socks feature branch at 813b66d (HEAD).

Starting from v1.3.0, Apple clients have been released from the go-tun2socks branch.
All code has been reviewed before merging into the go-tun2socks branch (see #789).
Tested that both the iOS and macOS clients build and connect.

Deprecates shadowsocks-libev, CocoaAsyncSocket, and PacketProcessor (badvpn-tun2socks) for iOS and macOS.
Imports outline-go-tun2socks v2.2.1 for all platforms.

\O/


It's not working on Manjaro

If you launch the setup on Manjaro you would see this error:
/src/utils/global.sh is missing
Also it doesnt find .cache returning another error:
cat: /home/user/Updater/src/utils/.cache: No such file or directory

@archetipico Maybe you know what is causing this problem
❓ ❔

It's not Manjaro-only, it's a setup.sh problem.
I'm working on it.

Found the bug: setup.sh is run, then it runs integrity_check.sh but integrity_check.sh checks for .cache existence, but if it's the first installation ever, that file doesn't exist. I'll PR a solution soon.


[Solves #55] Fixed the Backend CI

Fixes the CI problems caused by the premature merge of the other PR
For this Issue #55

another PR is tackling this, so this is a duplicate


uppercase filename creates a compilation error

If you copy/paste WordCount.Java as file name (like I did) it will not compile it and generate a compilation error

@MaurGi,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@MaurGi : Thanks for your contribution to the Azure documentation! The author, @Blackmist, has been notified to review your proposed change.

Thanks @MaurGi #sign-off


tiledbsoma 1.11.2

Following our established procedure

Surprisingly the osx-* builds passed but the linux-64 Python builds failed to obtain the version in this setup where RELEASE-VERSION is artificially created
https://github.com/TileDB-Inc/tiledbsoma-feedstock/blob/f537d2dbc8d7e195dac350578fd8b0ca031cd67a/recipe/build-tiledbsoma-py.sh#L7
Here's the traceback:
  File "/home/conda/feedstock_root/build_artifacts/tiledbsoma_1716331838735/work/apis/python/version.py", line 275, in get_version
    version = get_git_version()
              ^^^^^^^^^^^^^^^^^
  File "/home/conda/feedstock_root/build_artifacts/tiledbsoma_1716331838735/work/apis/python/version.py", line 223, in get_git_version
    latest_tag = get_latest_remote_tag(remote)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/conda/feedstock_root/build_artifacts/tiledbsoma_1716331838735/work/apis/python/version.py", line 133, in get_latest_remote_tag
    raise RuntimeError(f"No tags found in remote {remote}")
RuntimeError: No tags found in remote origin
error: subprocess-exited-with-error

This error is surprising given the recent updates to build from an sdist that led to closing https://github.com/single-cell-data/TileDB-SOMA/issues/2588

cc @ryan-williams

@jdblischak @ryan-williams I think this may be involved:

Here we raise RuntimeError https://github.com/single-cell-data/TileDB-SOMA/blob/1.11.2/apis/python/version.py#L133
Here we catch CalledProcessError https://github.com/single-cell-data/TileDB-SOMA/blob/1.11.2/apis/python/version.py#L227

I was able to build it locally from the 1.11.2 GitHub release tarball using Python 3.9:
mamba create --yes -n test-soma python=3.9 pip
mamba activate test-soma

wget https://github.com/single-cell-data/TileDB-SOMA/archive/refs/tags/1.11.2.tar.gz
tar xzf 1.11.2.tar.gz
cd TileDB-SOMA-1.11.2/

git status
## fatal: not a git repository (or any of the parent directories): .git

cd apis/python/
echo "1.11.2" >> RELEASE-VERSION
python -m pip install . -vv

This of course isn't identical to the conda build (since I didn't pre-install libtiledb or libtiledbsoma), but I don't think that should affect the logic of version.py.

Also, @johnkerl, how are you preventing the Python 3.12 variants from being added during the rerendering like they are in the nightly-build branch, eg 878194b1b6897a0f7a38c32c36a019b666e82799?

Also, @johnkerl, how are you preventing the Python 3.12 variants from being added during the rerendering like they are in the nightly-build branch, eg https://github.com/TileDB-Inc/tiledbsoma-feedstock/commit/878194b1b6897a0f7a38c32c36a019b666e82799?

@jdblischak I'm not aware that I'm doing any preventing -- am I doing something wrong that I'm not aware of? Am I doing something right that I'm not aware of?

am I doing something wrong that I'm not aware of?

My only guess was that maybe you edited conda_build_config.yaml like I had yesterday (https://github.com/TileDB-Inc/tiledbsoma-feedstock/issues/153#issuecomment-2123363407) but then didn't add and commit the file. A quick git status should confirm or deny this possibility

Am I doing something right that I'm not aware of?

If my above guess is wrong, then don't change anything! :-) You might have a slightly older conda-smithy installed locally, but we don't want those Python 3.12 variants anyways.

Previous build seems to have failed with:
RuntimeError: SHA256 mismatch: 'e3933c7d7b3d8df59a40ed7833fb20774917f531a915debc76abb569e958a421' != 'e3933c7d7b3d8df59a40ed7833fb20774917f531a915debc76abb569e958a421 - 0001-version-py-workaround-1-11-2.patch'

link
The SHA parts match, but the right side contains - 0001-version-py-workaround-1-11-2.patch 🤔

The SHA parts match, but the right side contains an extra - 0001-version-py-workaround-1-11-2.patch 🤔

@ryan-williams See my comment above, https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/157#discussion_r1612269225, about jinja2 not being that smart. This confirms my understanding. It has no understanding of the YAML sections, but is simply applied line by line. So what happened was that the field patches: was removed from the linux-64 builds (since [osx and not arm64] evaluates to false on a linux-64 build), so the following line with the path to the patch file looked like it belonged to the field sha256, and hence the failure.

about jinja2 not being that smart

For my future reference: this means operationally: if some yaml file has
foo: bar # [baz]
    quux # [xyzzy]

this is not good -- such lines need to be like
foo: bar #[baz]
  quux #[baz]

where the baz thing need to evaluate to true or false for each #-tagged line that the author thinks of as belonging together

Post-merge CI link FYI:
https://github.com/TileDB-Inc/tiledbsoma-feedstock/runs/25352784338

... success!! :)
Now I'll monitor
https://anaconda.org/tiledb/libtiledbsoma/labels
https://anaconda.org/tiledb/tiledbsoma-py/labels
https://anaconda.org/tiledb/r-tiledbsoma/labels
to verify in the next hour or two that 1.11.2 artifacts arrive. This will prove we've gotten the artifact-creation issue from this release, confined to this release.

✅ https://anaconda.org/tiledb/libtiledbsoma/files?version=1.11.2
✅  https://anaconda.org/tiledb/tiledbsoma-py/files?version=1.11.2
✅  https://anaconda.org/tiledb/r-tiledbsoma/files?version=1.11.2

Many thanks @jdblischak and @ryan-williams !!!


fix: Execution should halt if api error is detected

Description
I forgot to add a return here so once the error was logs (or not depending on the function configuration) we would try and access res.StatusCode causing a seg fault.
Screenshot

@medikoo This is some test flakeyness that I am trying to resolve in another branch. I haven't quite tracked down why this happens as I am not able to reproduce locally 😢

@medikoo I will go ahead and merge this since @czubocha approved and the tests passed after re-running 👍


add syntax_iterator.py

Could you please research the correct way to yield non-NP phrases such as VPs? @polm

Sure, it's late tonight but I'll work on it tomorrow.

I'll go ahead and merge this as a base to work on.


Improve GitHub templates.

This PR is inspired by @torn4dom4n and should fix #1336 and close #1335.
If you think that these proposed changes can be improved further or you believe that they require more changes, please feel free to discuss them here.

@JimiC I think you should remove example comment in issues templstes to contributing. Do you think that?

@torn4dom4n My opinion is that all this info inside the templates should be moved to the wiki and templates should only contain the scaffold plus the link to the wiki page.

It is a good idea!

I agree with you @JimiC :+1:

Are you willing to make the move before next release? Although, this is not affecting the deliverable so... no hurries!

Wiki pages have been added.


Parcellation // Supplementary data

For now, there is only one data resource (a brain parcellation) that does not belong to the FSL package and is used along the workflow.
I assume (@craigmoodie can correct me if I'm wrong) that the user should have the possibility to change this file, but generally, the default one will be used.
@chrisfilo: what do you think about having a data/ or resources/ folder where we keep and distribute these files. Right now we would place here a parcellation that is publicly available through neurovault. We would need to have a LICENSE file in that folder, indicating the appropriate licensing for each of the data files distributed.
Otherwise, a systematic solution to these data requirements should be defined.
Once this decision is made, we would close this issue when @craigmoodie places this file where we have decided.

Is this the template for brain extraction? IT's available here:
https://figshare.com/articles/ANTs_ANTsR_Brain_Templates/915436
We can make a fetcher (similar to those in nilearn) that downloads the
required templates from figshare.
On Tue, Mar 15, 2016 at 10:58 AM, Oscar Esteban<EMAIL_ADDRESS>wrote:

For now, there is only one data resource (a brain parcellation) that does
not belong to the FSL package and is used along the workflow.
I assume (@craigmoodie https://github.com/craigmoodie can correct me if
I'm wrong) that the user should have the possibility to change this file,
but generally, the default one will be used.
@chrisfilo https://github.com/chrisfilo: what do you think about having
a data/ or resources/ folder where we keep and distribute these files.
Right now we would place here a parcellation that is publicly available
through neurovault. We would need to have a LICENSE file in that folder,
indicating the appropriate licensing for each of the data files distributed.
Otherwise, a systematic solution to these data requirements should be
defined.
Once this decision is made, we would close this issue when @craigmoodie
https://github.com/craigmoodie places this file where we have decided.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/poldracklab/preprocessing-workflow/issues/8

Nope, it is a parcellation for the functional connectivity matrix. Am I correct, @craigmoodie ?
For those files supplied within other packages we will need to implement fetchers and a cache folder (btw, a nice new feature for nipype), but I think this is our file.

Calculating functional connectivity should not be part of this workflow. It
should only do preprocessing. Analysis pipelines (such as parcellation
based functional connectivity, but many others) should work on outputs of
the preprocessing pipeline as a separate package.
+1 for nilearn style fetcher as a nipype interface!
On Tue, Mar 15, 2016 at 11:09 AM, Oscar Esteban<EMAIL_ADDRESS>wrote:

Nope, it is a parcellation for the functional connectivity matrix. Am I
correct, @craigmoodie https://github.com/craigmoodie ?
For those files supplied within other packages we will need to implement
fetchers and a cache folder (btw, a nice new feature for nipype), but I
think this is our file.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/poldracklab/preprocessing-workflow/issues/8#issuecomment-196954167

I don't think this workflow computes any connectivity. I may be wrong, but I guess it resamples the parcellation into subject space to be used in the connectivity pipeline afterwards (@craigmoodie?).
Anyways, we potentially may see this situation with some other file, maybe in some other project. I think it is worth making a decision on how to redistribute these resources...

Hi Oscar,
Chris is right that the original vision for the standard implementation of the workflow does not include generating parcel or ROI time series. I think having this as an option would be nice, but for now you can just remove the nodes related to transforming the parcels to native space, as this is not a top priority.

I used to Oasis template but another user might want to use a different template that better fits their data. All ANTs templates can be found at the address Chris posted above.

I think resampling the parcellation into subject's space is ok for a preprocessing workflow. Moreover it is implemented, so I don't see a good reason to remove it.
What do you think we should do with this kind of resources? Package them with the workflow? Just provide a link and fetch/cache them?

There are many parcellation schemes people would like to use. There are
also connectivity analyses that do not use parcellation schemes (for
example see based connectivity). I think we should aim at building a set of
tools each doing one thing very well instead of many things poorly. This
tool should focus on preprocessing providing inputs to many different
higher level analyses. Think a set of precision tools instead of swiss army
knife. Think google instead of altavista/yahoo.
Eventually, we will also build a tool for doing parcellation based
connectivity analysis, but that tool will not do any preprocessing and be
based on the outputs of the preprocessing workflow. Maybe instead of
removing the parcellation resampling code we could just move it to a place
which would eventually evolve to a parcellation connectivity analysis tool.
In terms of resources I like the idea of putting them in a repository like
figshare or dataverse and accessing it programmatically during installation
or packaging for pypi.
On Tue, Mar 15, 2016 at 5:39 PM, Oscar Esteban<EMAIL_ADDRESS>wrote:

I think resampling the parcellation into subject's space is ok for a
preprocessing workflow. Moreover it is implemented, so I don't see a good
reason to remove it.
What do you think we should do with this kind of resources? Package them
with the workflow? Just provide a link and fetch/cache them?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/poldracklab/preprocessing-workflow/issues/8#issuecomment-197086470

Totally agree with this
Sent from my iPhone

On Mar 15, 2016, at 5:50 PM, Chris Filo Gorgolewski<EMAIL_ADDRESS>wrote:
There are many parcellation schemes people would like to use. There are
also connectivity analyses that do not use parcellation schemes (for
example see based connectivity). I think we should aim at building a set of
tools each doing one thing very well instead of many things poorly. This
tool should focus on preprocessing providing inputs to many different
higher level analyses. Think a set of precision tools instead of swiss army
knife. Think google instead of altavista/yahoo.
Eventually, we will also build a tool for doing parcellation based
connectivity analysis, but that tool will not do any preprocessing and be
based on the outputs of the preprocessing workflow. Maybe instead of
removing the parcellation resampling code we could just move it to a place
which would eventually evolve to a parcellation connectivity analysis tool.
In terms of resources I like the idea of putting them in a repository like
figshare or dataverse and accessing it programmatically during installation
or packaging for pypi.
On Tue, Mar 15, 2016 at 5:39 PM, Oscar Esteban<EMAIL_ADDRESS>wrote:

I think resampling the parcellation into subject's space is ok for a
preprocessing workflow. Moreover it is implemented, so I don't see a good
reason to remove it.
What do you think we should do with this kind of resources? Package them
with the workflow? Just provide a link and fetch/cache them?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/poldracklab/preprocessing-workflow/issues/8#issuecomment-197086470

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Thanks a lot, I guess this issue can be closed now.


Spyder do not start after installing (apt on ubuntu)

I have installed the default version (repo), and no problems on install.
Even all seems ok, (link in Developmen section of menu, etc), if I try to start it, the splash appear dor a second and close. No aplication is started.
If I try from console, the splash also appear for one or two seconds and close with this message
orlapalm  ~  spyder
Traceback (most recent call last):
File "/usr/bin/spyder", line 33, in
sys.exit(load_entry_point('spyder==4.2.1', 'gui_scripts', 'spyder')())
File "/usr/lib/python3/dist-packages/spyder/app/start.py", line 213, in main
mainwindow.main(options, args)
File "/usr/lib/python3/dist-packages/spyder/app/mainwindow.py", line 3624, in main
mainwindow = create_window(app, splash, options, args)
File "/usr/lib/python3/dist-packages/spyder/app/mainwindow.py", line 3482, in create_window
main.setup()
File "/usr/lib/python3/dist-packages/spyder/app/mainwindow.py", line 803, in setup
self.completions = CompletionManager(self)
File "/usr/lib/python3/dist-packages/spyder/plugins/completion/plugin.py", line 97, in init
plugin_client = Plugin(self.main)
File "/usr/lib/python3/dist-packages/spyder/plugins/completion/kite/plugin.py", line 50, in init
self.installer = KiteInstallerDialog(
File "/usr/lib/python3/dist-packages/spyder/plugins/completion/kite/widgets/install.py", line 287, in init
self._integration_widget = KiteIntegrationInfo(self)
File "/usr/lib/python3/dist-packages/spyder/plugins/completion/kite/widgets/install.py", line 58, in init
image = image.scaled(image_width, image_height, Qt.KeepAspectRatio,
TypeError: arguments did not match any overloaded call:
scaled(self, int, int, aspectRatioMode: Qt.AspectRatioMode = Qt.IgnoreAspectRatio, transformMode: Qt.TransformationMode = Qt.FastTransformation): argument 1 has unexpected type 'float'
scaled(self, QSize, aspectRatioMode: Qt.AspectRatioMode = Qt.IgnoreAspectRatio, transformMode: Qt.TransformationMode = Qt.FastTransformation): argument 1 has unexpected type 'float'

* Spyder version: 4.2.1
* Python version: 3.10.4qt
* Qt version: 5.15.3
* PyQt version: 5.15.6
* Operating System name/version:

Hi @orlapa, it seems that you are installing a very old and unsupported version of Spyder via an unofficial installation medium. We invite you to install Spyder via anaconda/conda-forge. Please refer to our installation guide, available on the official Spyder documentation: https://docs.spyder-ide.org/current/installation.html

Hi, thanks for your reply.
I have installed using pip and now is working Ok
Thanks a lot
Regards
El vie, 10 de jun. de 2022, 10:59 a. m., Edgar Andrés Margffoy Tuay <
@.***> escribió:

Hi @orlapa https://github.com/orlapa, it seems that you are installing
a very old and unsupported version of Spyder via an unofficial installation
medium. We invite you to install Spyder via anaconda/conda-forge. Please
refer to our installation guide, available on the official Spyder
documentation: https://docs.spyder-ide.org/current/installation.html
—
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/18222#issuecomment-1152510024,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE6PCJCDTQRZWRHM6G3NV3VONQ4RANCNFSM5YKQJNFQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Template parse errors when using the example template

Template:
`<input type="text" [(ngModel)]="field" name="field" #field="ngModel" [rangeLength]="[5, 9]"/>
error message`
Error:
`Error: Template parse errors:
Can't bind to 'rangeLength' since it isn't a known property of 'input'. ("<input type="text" [(ngModel)]="field" name="field" #field="ngModel" [ERROR ->][rangeLength]="[5, 9]"/>
error message"): LoginComponent@0:69`
Help, please.

Have you import CustomModule?

Hi, I have the same issue.
I imported CustomFormsModule in my module.ts and try to use [min] in my template but it throws a template parse error.
Did I miss something?

Hi I am facing same issue with latest version of ng2-validation. Can someone please suggest a solution?


Add menu bar

One line menu bar on top, which includes:

Logo (links to the product overview page)
Display mode (edit, split, view)

In future:

Pull down list to select a graph
User login

Also,

Move the existing buttons into the menu bar

0369ecf48d57cfb3563b8bbfd285481518a54e6f

Consider adding in future

Pull down list to select a graph
User login


NoComponentId error

I am trying to create modern page and add web parts programmatically through extensions. when i run the code for the first time page is getting created succesfully and webparts are added to it. however, when i delete that page and re-run the code i am getting NoComponentId error.

I am not sure what went wrong. Please let me know if you have any idea.

Maybe that error refers to the ClientSideApplicationId column in the library where the page is hosted.
It might get emptied during your process of recreating the page.

Check the URL parameters as well. This error is caused when using the URL parameters "List" or "ID".
ClientSidePages must not be called with these parameters in the URL (if you plan to make a custom form page where SharePoint redirects to your page, you need to have an intermediate page renaming those parameters, extremely stupid, this). They interprete this in a non-standard way as the page being in a different document library specified by List and being the document item with the specified ID (even though this mechanism exists, it is not possible to host ClientSidePages anywhere else but in the SitePages library, at least if you want to edit them, they always get published/saved there).

Closing this issue as frevds has provided steps to solving the problem and there has been no activity since then.


Edit in Github link support for any random repository directories

Fixes https://github.com/shuding/nextra/issues/39
Added a few fields on the config, I rename some of them from https://github.com/shuding/nextra/issues/39 to sync with package.json format and in the future if nextra supports git/svn/whatever we should manage to bring the package-json logic in here and be happy.

repository (defaults to https://github.com/shuding/nextra)
branch (defaults to master, but It might be a good idea to default to main)
path (defaults to /)

This PR moved some things around, tried to not be very opinionated and following whatever was on the repo. One substantial change was adding .vscode/ with prettier settings since my defaults were commissioning all the time and keeping the changes small were difficult. Happy to add prettier as a dependency as well.
Something that might be interesting is adding some unit testing since I want to make sure that the link doesn't break or any tiny logic here, and the other thing that I wanted to say was... once I'm running watch and dev:layout I'm never too sure about the changes being populated in my local, so apologies if there's any issue that I bypass, but would be great to have a stronger local setup.
This PR doesn't add documentation for the config change, so... It might be a good idea to revisit it once you want to merge core into master.
Let me know if anything doesn't make sense here, happy to modify it.
I believe this PR also fixes https://github.com/shuding/nextra/issues/30

Thank you!


Investigate slow binary

Continuation of the conversation in #9 to improve efficiency of binary arithmetic.

It is curious that you mentioned it now. This weekend I've been finalising patches to bitvec, adding a blazingly fast arithmetic of binary polynomials. Could you possibly give it a try before it is released? One can grab bitvec-HEAD from https://github.com/Bodigrim/bitvec and use Data.Bit.F2Poly.

I gave it a try, and benchmarked over several parameters, namely the leading power of the polynomials involved in the operations, the number of operations involved, and the leading power of the mod polynomial (which is relevant to BinaryField arithmetic). Keep it mind that our current implementation is purely manipulation of integers.
Results show that many multiplications of small polynomials (product [1 .. 10^6]) is initially slower for BinaryField than for F2Poly (by a factor of up to 3), but BinaryField scales better than F2Poly with increasing size of the mod polynomial (the former becomes faster than the latter when the mod polynomial has deg ~ 300 - our use cases vary from deg < 100 to deg > 500). On the other hand, multiplications of large polynomials (deg of polynomial ~ deg of mod polynomial) is significantly faster for F2Poly than for BinaryField (for a deg ~ 500 mod polynomial, it takes 1.2ms for BinaryField but only 0.06ms for F2Poly - great). Unfortunately, these are all multiplications - addition is always much faster for BinaryField (anywhere from a factor of 7 to a factor of 70). Arguably these operations are already very fast (in the nanosecond range), but they are used very often.
Additionally, I found a possible bug - doing fromInteger (0 :: F2Poly) returns a nonsensical Integral value, which also returns arithmetic underflow for Natural.

That’s interesting, thanks for investigation. Could you please point me to the source code of benchmarks?

I did them locally, but the code is exactly as follows:
module Main where

import Protolude

import Criterion.Main
import Data.Field.Galois -- change source code and rerun

main :: IO ()
main = defaultMain
  [ bench "Binary/sum" $
    nf sum z
  , bench "Binary/product" $
    nf product z
  , bench "Binary/addition" $
    nf (uncurry (+)) (x, y)
  , bench "Binary/multiplication" $
    nf (uncurry (*)) (x, y)
  ]

x :: Binary 0x80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000425
x =<PHONE_NUMBER>781519722635142596328196926911966227939046359094084536440568319715629280500715997622795290565075619575500349856402545234501339956177637642297104032840572435804027

y :: Binary 0x80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000425
y =<PHONE_NUMBER>349691279785996384838127547448114923541797426543534068992493058289537022289475955431649770234097149134032015677741886571782953737774719182732366741493639259919140

z :: [Binary 0x80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000425]
z = fromInteger <$> [3 .. 10^6]

Well, things like sum [3..10^6] are the very best scenario for Integer: values never can exceed a machine word, so it all boils down to xorI# and almost no boxing.
I made a patch, aiming to bring an addition of long F2Poly on par with Integer. Now both of them use a foreign call to mpn_xor_n.
The degradation of performance for product [3..10^6], when modulo grows, is surprising, especially while at the same time multiplication itself is much faster. Not sure what's going on here.

Right, thanks. I will have another go over the weekend.

I experimented a bit and it seems that product [3..10^6] is not a reliable benchmark for multiplication itself, because multipliers are so tiny in comparison to modulo, and depends a lot on a subtle interaction between Enum and Num instances. For example, at some point using z = [3..10^6] appeared to be 3x faster than z = fromInteger <$> [3..10^6].
Is product [3..10^6] a relevant computation for your domain? My understanding was that most of the time one multiplies a handful of polynomials, roughly of the same size with modulo.

Is product [3..10^6] a relevant computation for your domain? My understanding was that most of the time one multiplies a handful of polynomials, roughly of the same size with modulo.

You are right - I added this benchmark just to match the product [1 .. 10^8] I saw somewhere else, and this practically never happens.

 I cannot really guarantee that I did not mess up (however, tests are still green), but here are benchmarks:
Binary/Addition                  117.5 ns   (115.2 ns .. 120.1 ns)
Binary/Multiplication            34.89 μs   (34.50 μs .. 35.36 μs)
Binary/Inversion                 304.7 μs   (301.5 μs .. 307.6 μs)
Binary/Division                  357.6 μs   (353.3 μs .. 361.8 μs)
Binary/Frobenius endomorphism    13.55 μs   (13.38 μs .. 13.71 μs)
Binary/Square root               9.462 ms   (9.192 ms .. 9.814 ms)

So addition is slightly slower, multiplication is 60x faster, inversion and division are 20x faster, Frobenius endomorphism is 90x faster, square root is 70x faster.

Thank you! I will replace the functions here with F2Poly functions very soon.


Mechanism to narrow a ZiplineScope

I’d like to have a ZiplineScope that applies during a small number of calls to a service.
Consider this example:
val scope = ZiplineScope()
val stockPriceService = zipline.take<StockPriceService>("stockPriceService", scope)

fun latestStockPrice(symbol: String): Money {
  val flow = stockPriceService.priceFlow(symbol)
  return flow.first().price
}

Each invocation of latestStockPrice() should get its own scope. We know when to close the scope (when the latestStockPrice() returns), but no API with which to do it.
One option:
suspend fun latestStockPrice(symbol: String): Money {
  val childScope = ZiplineScope(scope)
  try {
    val flow = scope.push(childScope) {
      stockPriceService.priceFlow(symbol)
    }
    return flow.first().price
  } finally {
    childScope.close()
  }
}

Note that we only push for the duration of the service function. We don’t push during flow.first(), since that’s a suspending operation (and may compete with other calls to latestStockPrice().

I think I have a better design.
We create a function that lets you specify a different scope to apply to returned services:
fun <T : ZiplineService> T.withScope(scope: ZiplineScope) : T {
  ...
}

Which can be used like this:
suspend fun latestStockPrice(symbol: String): Money {
  val childScope = ZiplineScope(scope)
  try {
    val scopedStockPriceService = stockPriceService.withScope(childScope)
    val flow = stockPriceService.priceFlow(symbol)
    return flow.first().price
  } finally {
    childScope.close()
  }
}


Add codecov token

We're seeing some rate limiting from codecov. This might just be a hard limit of
the service, but thought adding in a codecov token might help.

[ ] Tests added for any new code
[ ] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entry added to UNRELEASED.md for any new functionality

Codecov Report

Merging #1271 (1fdf6f7) into unstable (130172e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           unstable    #1271   +/-   ##
=========================================
  Coverage     73.79%   73.79%
=========================================
  Files           332      332
  Lines         10749    10749
  Branches        515      515
=========================================
  Hits           7932     7932
  Misses         2817     2817

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130172e...1fdf6f7. Read the comment docs.


Weird UI interaction

Using "Confirm" on screen X_input causes some weird interactions, the worst being closing the whole save screen.

I've seen the Choose a name for the Playthrough close the whole menu, though it did successfully create the playthrough (which was visible upon re-entering the menu). I've seen the Rename the Playthrough successfully rename the playthrough - but leave the input screen open and responsive. I've seen using enter work (rare) but leave the input screen open. I've seen the Confirm button remain greyed out but clickable whether valid or not ("quick" and "auto" must remain invalid, ofc)


Highlighting specific dates (independent of mult. date selection)

Hello!  I am wondering if there is a way to initialize calendar with certain dates highlighted (while still allowing the user to select only one date).  For example, given some list of event dates, initialize the calendar with dates that are in a different color if the date corresponds to an event date.  The user should still only be able to select only one date at a time, and the highlighted dates should not change as a result of user selection...
Thanks!

Also wondering !


Provide API for getting the wall variant of blocks

Description
This adds an API for getting the wall / attachable variant of a block.
Unlike #117 it does not add convenience methods for orientation, and it does not modify the example to use this code.
Test Plan

The extractor is not tested.
The API has some tests in the test module.
Related

#115 - it does not fix this, as it doesn't modify the example, but it could lead to it.

Looks good to me.

https://github.com/valence-rs/valence/issues/115 - it does not fix this, as it doesn't modify the example, but it could lead to it.

Generally these things are known as "placement rules" which can become complicated from what I understand. We will probably need to provide a holistic solution.

Looks good to me.

#115 - it does not fix this, as it doesn't modify the example, but it could lead to it.

Generally these things are known as "placement rules" which can become complicated from what I understand. We will probably need to provide a holistic solution.

I've just been slowly adding to my ball of mud :laughing:
Things can only go downhill from here!
I think things like stair bending and fence connecting happen in a block update and can be ignored until then, as long as orientation, etc is right. I'm not sure how you would actually implement block updates in Bevy though (another stage?)


Support batched SVD

cusolverDn<t>gesvdjBatched() only supports m <= 32 and n <= 32.
cusolverDn<t>gesvdaStridedBatched() only supports full_matrices=False because it's a method for a tall skinny matrix.

Can we use the second one while a stands for "approximation"?  (I'd rather not.)
Should we implement the other cases using a trivial loop of cusolverDn<t>gesvd()?  I'm willing to work on it if it'll be better than a loop outside cupy.linalg.svd.

I don't think we want to use the approximation for obvious reasons such as outputs differing from naively looping over the batch with cupy.linalg.svd. It might be worth considering exposing this cuSOLVER API in CuPy through some different interface though, that doesn't exist in NumPy.
With that said, using gesvdjBatched when possible and otherwise loop sounds reasonable to me. That's probably "more or less" what this cuSOLVER routines does anyway.

gesvdjBatched performs gesvdj on each matrix. It requires that all matrices are of the same size m,n no greater than 32 and are packed in contiguous way,

(https://docs.nvidia.com/cuda/cusolver/index.html#cuds-lt-t-gt-gesvdjbatch)
Regaring if it's better than looping over cupy.linglag.svd, we should do some benchmarking along the way since it's difficult to tell beforehand?

By the way, I took a look at NumPy and it seems like they're looping manually too? Not really sure if this is of any interest but just leaving a reference. https://github.com/numpy/numpy/blob/master/numpy/linalg/umath_linalg.c.src#L2762-L2795

@toslunar Kindly ping.

With that said, using gesvdjBatched when possible and otherwise loop sounds reasonable to me. That's probably "more or less" what this cuSOLVER routines does anyway.

I agree with this idea (although documentation may necessary depending on how it affects the entire performance).

It's better to make the feature (gesvdjBatched) a different function like #3192.

It is supposed that now batched cupy.cusolver.gesvdj that uses cusolverDn<t>gesvdjBatched is merged in #3247 and remaining is to fix cupy.linalg.svd to support batched svd using cupy.cusolver layer.

I need to solve a large number of small symmetric/Hermitian Eigen problems.
Therefore, it would be very helpful to have support for batched Jacobian cuSolver routines as well:
([https://docs.nvidia.com/cuda/cusolver/index.html#cuds-lt-t-gt-syevjbatch])

I talked with @toslunar and agreed to close this. Let's continue the discussion in #3470.


Missing dependency on icub-main in the documentation

In the repo documentation (https://github.com/robotology/walking-controllers#page_facing_up-dependencies), icub-main is not mentioned, but it seems to be a required dependency.
cc @SimoneMic feel free to add here any detail

Yeah everything fine, did all the installation in https://icub-tech-iit.github.io/documentation/sw_installation/linux_from_sources_manual/

The dependency on whole-body-estimators is missing as well in case you want to run the simulation example (https://github.com/robotology/walking-controllers#computer-how-to-run-the-simulation), we could specify it in the documentation (also icub-models would be needed for running the example with iCub).


Failure when receiving data from the peer

Newsboat version (copy from newsboat -v):  2.10.2
I have here 7 feeds that are not loaded:
[2018-02-09 12:16:58] Fehler beim Abholen von http://www.mpg.de/de/forschung.rss: Failure when receiving data from the peer
[2018-02-09 12:17:02] Fehler beim Abholen von http://www.presseportal.de/rss/dienststelle_65843.rss2: Failure when receiving data from the peer
[2018-02-09 12:17:02] Fehler beim Abholen von http://www.presseportal.de/rss/dienststelle_58451.rss2: Failure when receiving data from the peer
[2018-02-09 12:17:03] Fehler beim Abholen von http://www.presseportal.de/rss/dienststelle_62459.rss2: Failure when receiving data from the peer
[2018-02-09 12:17:07] Fehler beim Abholen von http://www.presseportal.de/rss/dienststelle_104233.rss2: Failure when receiving data from the peer
[2018-02-09 12:17:08] Fehler beim Abholen von http://www.presseportal.de/rss/dienststelle_11811.rss2: Failure when receiving data from the peer
[2018-02-09 12:17:08] Fehler beim Abholen von http://www.presseportal.de/rss/dienststelle_7.rss2: Failure when receiving data from the peer
Any ideas?

By "not loaded", you mean "never worked", or "failed to load once"? I tried the first one and it loaded just fine. I think it's most likely that the server is blocking you because of too many concurrent requests. Are you using reload-threads? Also, how often do you reload the feeds?
Also, servers sometimes drop requests, so if you don't see this behaviour all the time, you shouldn't be worried.

No, I don't think the supplying server is blocking me. Other readers on the same system (NRSS, Liferea, QuiteRSS, Firefox) can access these feeds.
The feeds are also not retrieved if they are only updated once a day.

So, these feeds never worked for you in Newsboat, or do they fail intermittently?
What about reload-threads? Does it help if you set it to 1?

So, these feeds never worked for you in Newsboat,

Yes.

What about reload-threads? Does it help if you set it to 1?

No.

Running out of ideas here :( What if you set the user-agent to something
popular like latest Firefox? (It worked for me with the default
user-agent, though.)
What if backup your cache.db, clear your urls file, add just one URL and
try loading it? (Or just use separate urls and cache files with
--cache-file and --url-file)
Also, it might be useful to follow the advice from the issue template
and show your config.

I think the problem has to do with curl of my Debian installation (Debian GNU/Linux 9 (stretch) 64 Bit, Gnome version 3.22.2). If I install newsboat as a snap application (https://snapcraft.io/newsboat), the feeds will load properly.
Thanks for the help so far, this solves the problem for me.

What version did you get from the Snap store? The release channel there is still at 2.10.1, but beta is at latest master. I want to know that because it might mean we have a regression in 2.10.2.


Failing to build on nix due to <IP_ADDRESS> not being on hackage

<IP_ADDRESS> is on hackage as a candidate release, but not yet a proper release. Since <IP_ADDRESS> fails to build, it is now marked as ‘broken’ on nix and anything which depends on it will not compile.

Unfortunately I didn't identify issues with <IP_ADDRESS> package candidate before publishing it. I intend to move onto <IP_ADDRESS> which should fix all of your issues. The package candidate is here (https://hackage.haskell.org/package/docopt-<IP_ADDRESS>/candidate) it would be a huge plus if you can verify that referencing this package candidate fixes your problems. I will be testing the same.

Thanks! I can confirm that if I use the current master branch within nix (i.e. bdc4c679bf0185ab6c1895172f011193d9e9922c, which I believe is your release candidate), then things build properly.

Awesome, I tested out <IP_ADDRESS> package candidate as well and works as expected for me as well. Will publish the package candidate officially tomorrow.

Package has been published https://hackage.haskell.org/package/docopt


Add user type and allow research studies to be filtered by type

Options should include:

Student
Teacher

Fixed in 1.0.0.


mime/multipart: add (*Reader).NextRawPart to bypass automatic quoted-printable handling

What version of Go are you using (go version)?

$ go version
go version go1.11.1 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/abuchanan/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/abuchanan/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/abuchanan/projects/mailer/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/r8/1_92bxy977zcfcj2jpp5j2dc0000gn/T/go-build702584477=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
https://play.golang.org/p/7x85EhvIbZZ
What did you expect to see?
I expected the part headers to include the Content-Transfer-Encoding as-is, and for the part body reader to return content as-is.
What did you see instead?
I found that Part has special handling for parts with Content-Transfer-Encoding: quoted-printable, which as introduced in issue #4411.
GitHub has also just led me to issue #26803 (which I failed to find before) which also proposes a way to bypass this via Part.NextRawPart. Unfortunately, although that proposal was accepted, the issue was closed by the submitter before being implemented.
Having access to the raw part body and unmodified headers is useful. In particular, for an IMAP server, I need to be able to inspect the part headers and body, including the Content-Transfer-Encoding header, in order to build the BODYSTRUCTURE response.
I can think of a couple workarounds for my particular server but they're not great, and I think this deserves a fix in the std library.

To be clear, the signature would be func (r *Reader) NextRawPart() (*Part, error) and it would still decode the headers for you, it just wouldn't decode the body nor check the encoding header.

Still SGTM.

As far as I can tell, this is ready to go still. The issue has the labels "help wanted" and "needs fix". Might want to double check whether those are still valid.
Would love to take this off my todo list.


Returning output of action from a rule

Hi,
we are planning to use easy-rule in our project, we need to return value from a rule, below is the example:
SpELRule ageRule = new SpELRule()
.name("Xpath rule")
.description("XPath condition")
.priority(1)
.when(" #xpath1 == 'test' && #xpath2 == '2' && #xpath3 == '3' ")
.then("#person.getValue(#xpath1)");
in the above  rule,  action will return a value [person.getValue()] and i need to return the value as response [it will be rest api, stateless]
is it possible to do return a value from matching rule?
thanks
Kantesh

Please check Q2 in the FAQs section. Basically your rule should add a fact, then you can query the Facts object after rule execution to get the result.


⚠ ClamAV has degraded performance

In 960570b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 87 ms

Resolved: ClamAV performance has improved in 89e7667.


Remove deps of useSelector

As per @lukaszfiszer pointed out on #1252 it's better if we get rid of the dependencies of useSelector and we let the users to memoize the selectors themselves.

This is indeed my proposed solution, but I still would like to hear what other maintainers think about it. Let's not rush too much with this change :-)

Regarding the docs changes, since I have another PR open with docs changes, I would like to add those docs changes there, if that's okay with you.

Regarding the docs changes, since I have another PR open with docs changes, I would like to add those docs changes there, if that's okay with you.

Totally! I went to open that PR and then I noticed that there was another PR for docs. That's why I didn't open it. Although, I will probably add some comments into that PR because I don't fully agree with some of the comments that you made to my docs proposal. No worries, nothing important. Thanks @MrWolfZ!

What's your view on this PR @markerikson @timdorr ?

@lukaszfiszer I'm watching the discussion in #1273, because that encompasses this change plus some additional optimizations with caveats.

@lukaszfiszer I'm watching the discussion in #1273, because that encompasses this change plus some additional optimizations with caveats.

@timdorr ups! That is the opposite of what I intended, sorry! I initially thought that this PR was going to get merged quickly, but I wasn't sure about the other one, that's why the other one also has this commit. Sorry!
If you want I can close #1273 and re-open it once this PR gets merged or declined... (Or just leave it closed if you think that's better). Please, let me know if that would make things easier. Thanks!

I am a few days behind on the main feedback issue, so I need to catch up there too. I'll be able to look at this after I've read that novels worth of posts :)

FWIW our conclusion internally has been that custom Hooks should avoid dependency argument, and people should just memoize if it's necessary. You have to learn that pattern anyway.

I say we get this merged in now and rebase #1273 to get that just about the evaluations change.

No big objections? Cool, in it goes...


Neovim is culturally moving towards formatexpr

An excerpt from my dotfiles:
function Formatexpr()
    local lnum = vim.v.lnum;
    local count = vim.v.count;
    require("formatter.format").format("", "", lnum, (lnum + count + 1), { lock = true })
end

vim.o.formatexpr = "v:lua.Formatexpr()"

With this, I can just activate gq (including on visual selections) and it works as expected with no other configuration changes.
Something similar should either be documented or codified into formatter.nvim.

Not sure what you’re basing the claim that neovim is “culturally” moving towards formatexpr.
we could add docs, and would accept a PR if you’d like to make it.


Allow choice between MathJax or plain HTML

As mentioned in c96c57439ca5f6931b8ec1456f71e6361dd2476f we need to incorporate the ability to configure whether we want to use MathJax or plain HTML for rendering math in HTML.
Just posting this so it doesn't get forgotten. It will help with #273.

See #412

I'm going to close this one in favour of #479.


Remove serializeable isolation level from draft services

We noticed that when under high load, we were seeing some transaction
errors from psycopg when updating draft briefs:
sqlalchemy.exc.OperationalError:
(psycopg2.extensions.TransactionRollbackError) could not serialize
access due to read/write dependencies among transactions
DETAIL:  Reason code: Canceled on identification as a pivot, during
commit attempt.
HINT:  The transaction might succeed if retried.

We think this was due to specifying that the transactions were fully
serializeable, which put a lock on more resources than necessary. By
updating the query to use with_for_update we can make sure only the
row we're interested in is locked.
We also noticed that the query for the draft service was joined, and so
each time we fetched the draft service from the db we were pulling back
loads of stuff we didn't need. Frameworks, lots etc. Have chance to
lazy loading so we drastically reduce the cost of the query.

Just to dive in on this if you google 'flask set transaction level per view' or anything similar you actually find @robyoung s gist for this code:
https://gist.github.com/robyoung/68e2121c045f117bea78
So not sure it's that important that we keep it just for the sake of history

Shrug. It's one of those things that I'm amazed isn't provided out of the box.

I'm gonna keep it. It's a thing that works and might be useful, and I guess there's no guarantee that Rob's gist will be there in the future.


Absolute Urls

When there is an absolute url in the CSS it is altered without anything set to touch it.
.pipe(urlAdjuster({
    replace: ['../fonts/bootstrap', './css-lib/Bootstrap/3.3.1/assets/fonts/bootstrap']
}))

That will turn
background-image: url('http://www.google.com/someimage");

into
background-image: url('http:/www.google.com/someimage");

Which browsers then consider to be a relative url.

I have the same problem

As this package will replace all double slash with single slash, it will cause this problem.
As this package is inactive for two years, I forked it and add some features.
Check here: gulp-ex-css-url-adjuster


Allow administrator to view who is logged onto Stroom

It would be useful for an administrator to be able to see who is currently logged into Stroom.
Details to include

user
login time
login host/ip
last active
user group memberships (as a csv list perhaps)

do you mean like /sessionList.  ?

Perhaps a little more presentable (and correct) than the sessionList servelet. The following is my current action ... I thought I'd see my own login 'burn'

Perhaps expand on the servelet?

It would be good to be able to terminate user sessions from the screen also.

Screen should be protected with either admin or manage users perms.
sessionList servlet should be changed to use the same perms and deprecated for later removal.
Ability to filter on user display name, full name, unique id, node, agent.
Ability to sort by columns.
Add an action to revoke a user's session on a node.


support model export and import

as requested in https://github.com/googlecreativelab/teachable-machine/issues/3

relevant conversation https://github.com/PAIR-code/deeplearnjs/issues/33

@andrii-maglovanyi so I've worked on this in a branch and gotten close.  my strategy is to save all of the training weights as json, then load those weight and quickly re-train the model.  it's not exactly the same as exporting a trained model, but the user experience is pretty similar.

Nice ! @micahstubbs , More easier to learn if you add this too https://github.com/googlecreativelab/teachable-machine-boilerplate :D


App chooses wrong servant position to cast a skill on

Before opening an issue:

[x] I tested the latest release
[x] I looked at other issues (even the closed ones)
[x] I read the Troubleshooting Guide
[x] I'll fill this template properly

Your issue will get closed/locked by the bot in case proper info isn't provided
If you open unnecessary/dumb issues, you'll be rewarded with appropriate tags.

Describe the bug
I have a 3 turn farming set up with waver, a clasic one, but not only waver 1st skill but also suit NP up skill is casted onto the servant on the 3rd possition when is supposed to be casted onto the servant on 2nd possition.
Screenshots
If applicable, add screenshots to help explain your problem.
It is recommended that you at-least add one screenshot of FGO running on your device.
Video
If relevant, include a video of the script running on your device with Debug mode ON
Recording functionality is available within the app in More options.
Device Info (please fill at-least 'Device model'):

Device model: Samsung galaxy A42 5G
Screen size: diagonally 6,6" (I do not have a ruler)
Android Version: Android 11
RAM: 4GB

You didn't read the troubleshooting guide: https://github.com/Fate-Grand-Automata/FGA/wiki/Troubleshooting#uses-skills-on-wrong-servant-or-doesnt-use-skills-at-all


Typing indicator before text messages

Is there a better way to indicate that the bot is typing without having to place these activities before each message?

I am aware that this issue has already been raised in #4471 and it was partially answered here and in #4509.
I did not find a suitable solution in which it is not necessary to repeat the two activities (typing and delay) before each text message in the links that I mentioned.
Additional information: ShowTypingMiddleware is already set to true and I'm using the direct line as my main channel.

Hi @gabrielguarisa
Please help me understand your requirement/need. Are you just wanting the bot to send typing activities whenever it is 'thinking'?  Are you wanting to show the typing activity with less of a wait (less time between when bot receives message and sends typing activity)?
The typing middleware should send typing activities if the activity on the bot side takes longer than half a second, and will keep sending them every 2 seconds until an 'actual' response is sent from the bot. You can see more info here.
Sending a typing activity explicitly should be used for specific scenarios. Either where you don't want typing middleware enabled across-the-board, or when you need it for a very certain situation(s).

Are you sending the delay to trigger/test for a delay type scenario?
If you want to decrease the wait between bot receiving the message and sending typing activity; you can customize your runtime, override the ShowTypingMiddleware class and specify something less than 500ms.

Hello @dmvtech. Thanks for the reply.
From what you told me, I believe there are two different questions then:

Typing activity is not occurring on the direct line channel (and in azure web chat) if I do not explicitly place the typing activity on the composer (as shown in the image above).
Is there a way to put a delay on all messages, without explicitly sending the delay activity?

Typing activity is not occurring on the direct line channel (and in azure web chat) if I do not explicitly place the typing activity on the composer (as shown in the image above).

I am assuming this is because the bot is responsive enough (no real delay) so that it doesn't trigger a typing activity (response is happening less than half a second).

Is there a way to put a delay on all messages, without explicitly sending the delay activity?

You can extract the runtime and then modify it.

I had not thought about modifying the runtime. Thanks for the suggestion and attention. I'm closing this issue.

Hello @dmvtech how exactly do you modify the runtime? I tried creating a new project with a bot component that's supposed to send a delay activity on every message activity the bot receives. I then created a reference in my bot project to this new bot component and included it in the appsettings.json in the components array It seems to work well locally but when I deploy to Azure it keeps returning a bot encountered an error whenever it tries to webchat/join causing the entire conversation to crash.


Provide a reason when lock-file can't be opened or locked

Fixes https://github.com/newsboat/newsboat/issues/314.
Example output when the lock file is not writable:

Coverage decreased (-0.01%) to 57.927% when pulling 872710891a5055d34c91d56ca7a9cda0ee0a110f on dennisschagt:bugfix/issue-314 into 142873bad039b6110249f1c8fb7b2d6d4f5cdb3c on newsboat:master.

Sorry this took so long to review!

Getting a review 3 hours after creating the PR is fast. Thank you for the review!

Combined diff of the two force-pushes:
https://github.com/newsboat/newsboat/compare/872710891a5055d34c91d56ca7a9cda0ee0a110f..3046640c550a06d9ff4cfdae35c713bab638ed52


License findings should optionally list the file they're defined in

In CSV output, it would be handy if one could enable a column that names the package manager's file a specific dependency has been defined in. E.g. if a dependency comes from Gradle, <path_in_project>/build.gradle should be shown. This would make it a lot easier to debug where a specific dependency comes from in order to eliminate / replace it in the project's code in case of an unacceptable license.

I agree, LF needs to do a much better job at surfacing what it's doing and making its output's origins more discoverable.
Originally, I had intended for --debug to be this tool, but because of how LF was originally designed (with too much dependency injection, IMHO) this option needs to be implemented many places and has rotted a bit (and never made it into actions like report).

It looks like this is supported with the columns command line option. Closing this for now.


ERROR: schema "admin" does not exist

Prompt ERROR: schema "admin" does not exist when running the v_generate_tbl_ddl.sql script,How to create  admin schema?

you can use following to create 'admin' schema:
create schema admin;
for details see https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_SCHEMA.html


[Infra] Bugs in JavaScript lookbehind implementation

The implementation of TypeScript/JavaScript's lookbehind can't deal with some complex regexes.
Here is an example:
The regex for common number (((?<!\d+\s*)-\s*)|(?<=\b))\d+(?!(\.\d+[a-zA-Z]))(?=\b) extracts "123" and "123" and "0000" from utterance "123 00 and 123 and 0000" in JS which discards "00".
PR #539 #535 #487 #427 also have test cases being marked as not supported in JavaScript because of this issue.

Fixed in #1069.


Git available to build image on host ?

Hi !
I love rancher and rancher os so much :)
I'm experimenting some infrastructure configurations, and i would love to use rancher os on my hosts, but i'm stuck with one thing : i would like the ranchers os hosts to create the images from a git repository, because this is what i do now on the other hosts like debian 64.
May i ask if it is your will not to integrate git in the rancher os ?
Or is is possible to find a workaround to use git in a container when the agent is pulling the dockerfile from git ?
Is it possible to build a custom rancheros image with git support ?
Would you accept such a PR ?
Thanks again :)

The function is there from day one. Simply create a container with passing in /var/run/docker.sock and /usr/bin/docker, then you could do whatever you want inside the docker container.

We try to keep RancherOS as small as possible, so I don't think it's likely we'll include git by default. As @liyimeng suggested, running git inside of a container is probably the best solution. Depending on your use case you can also use a different console and install git with a package manager.

Thank you for your advice :)


Azure DNS ACME Solver Issue

Describe the bug:

I am trying to use the ACME DNS01 Solver as part of my ClusterIssuer.  My AKS cluster is setup with managedIdentities and the managed identity has the proper role permissions (verified by SysAdmin).   When I create  the certificate object,  the challenge gives me a status of
cert-manager  Error presenting challenge: error instantiating azuredns challenge solver: ClientID is not set but neither --cluster-issuer-ambient-credentials nor --issuer-ambient-credentials are set. These are necessary to enable Azure Managed Identities
So even though the default in the code for cluster-issuer-ambient-crednetials is true I set it the flag in the cert-manager deployment just to verify.    But obviously when cert-manager gets to that part of the code it is false still so either it is not getting passed in correctly or more likely I am missing something in my setup.  This is my only issuer in the cluster so it cannot be using a different issuer.
Steps to reproduce the bug:
Anything else we need to know?:
I did try to upgrade to the v1.6-alpha and use the managedIdentity field to see if that was the problem but I get the same exact error.
Environment details::

Kubernetes version: 1.20.9
Cloud-provider/provisioner: Azure
cert-manager version:  1.5
Install method: static manifests

/kind bug

@kstedman9 ,
Kindly try with principal ID instead of clientID


New header style for application

Context
Changes the header design to match that of the prototype.
Changes proposed in this pull request
Before

After

Guidance to review

is it too reliant in MoJ imports?
should the line under the heading match the colour of the environment tag?
does it look okay throughout the app?
does it collapse as you'd expect on smaller screens (I have removed the 'menu' button inline with the behaviour of the prototype.
does this look okay if someone is signed out:

Link to Trello card
https://trello.com/c/st1Mq1h6/2005-build-implement-the-new-header-for-manage-applications
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

should the line under the heading match the colour of the environment tag?

Yes, definitely!

does it collapse as you'd expect on smaller screens (I have removed the 'menu' button inline with the behaviour of the prototype.

Yep

does this look okay if someone is signed out

Yep

I've learnt from @adamsilver that we don't need to rely on the MoJ header styles and can instead configure the govuk styles to achieve the design we want. As this PR is becoming slightly convoluted I am going to close it and push up a separate cleaner PR.


swift: throw when setting restricted headers

Since we expose headers in the Request type, it's technically possible for consumers to set restricted headers that we will be setting internally within the library (any header starting with : in this case - :method for example).
To prevent this, we will throw an error when any of these headers/trailers is set manually.
Context: https://envoyproxy.slack.com/archives/CKQ2LK23G/p1563826656004700
Signed-off-by: Michael Rebello<EMAIL_ADDRESS>

Will likely close this PR instead of merging in order to prevent the poor ergonomics of having to try when using the builders. Instead, we can strip any headers that start with : before executing request(s). Discussing in the thread

Superseded by https://github.com/lyft/envoy-mobile/pull/288


Use latest earcut.hpp

Quite a few fixes went into earcut since our last checkout. Unfortunately one has now to handle which vertices are actually used oneself.

fixes some wrong triangulations
could be faster as well

Check Papua New Guinea on low zooms as an example

drawing water with 0.5 alpha and overlay blending

Whoa, nice example. Those water polygons must get pretty gnarly at the low zooms.
I'll make this the next thing I review, since there seems to be a potential for nasty rendering bugs.

Found another wrong triangulation both in earcut master and tangram-2 branch. Will look into it tomorrow. Tile 28/16/5

Can you revert the scene file changes?
Once done good to merge.

:+1:


Remove unnecessary configuration properties from checkstyle.xml

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[ ] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Is there any reason we need these properties? The default values are not overridden anywhere in our project and would lead to inconsistent style enforcement.

R: @kennknowles
This doesn't directly fix [BEAM-857], but I came across it while exploring the config. Removing these will simplify the IntelliJ setup I am documenting for that bug.


Better handle Ecobee API outages

I've had a number of instances where the script has crashed due to receiving non-200 status codes from Ecobee. My assumption is they've had outages (instead of the script having issues) since I've seen 403s and 500s.
Either way, the script doesn't seem to handle these outages very gracefully. Looks to me like it does instant retries 10 times before exiting. Seems like it would be preferable to do exponential back offs for the retries, possibly with a config variable for how many reties to do before exiting.
Here are the logs showing the instant reties. I've configured the container to automatically restart on exit, which is why you can see multiple sets of reties.

I've pushed a tweak for retry behavior in https://github.com/cdzombak/ecobee_influx_connector/commit/60aa72e3b632b50015ac83b575036b99d2e38905 . This commit:

Limits all Ecobee & InfluxDB operations to 3 retries
Sets the initial retry delay to 5s for the main update function (which calls the Ecobee API)
Sets the initial retry delay to 1s for InfluxDB writes

Please note that even prior to this commit, in the screenshot you've posted, retries are using exponential backoff. The code uses the avast/retry-go library, and its default behavior is to allow 10 retries, with an initial delay of 100ms, and a backoff + random delay strategy: https://github.com/avast/retry-go/blob/ce731f6114d3f1b81d16110b9f7d6a8637b1339b/retry.go#L83-L92

Finally, I don't currently have an Ecobee thermostat, so please report back if this change isn't working well for you.


nimble/ll: Add support for custom TX power configuration

This allows to provide custom TX power setting and rounding functions which can take into account FEM configuration. Since this is highly dependend on HW configuration (FEM type and mode, BPFs, PA power etc) there is no point in providing "default" implementation as this should be typically provided by BSP or application.

so I thought it over and I think it should work a bit different:

LL should always set TX power instead of relying on FEM to do this
we should have API to get PA/LNA gain, LL should call it and then calculate actual TX power or RSSI using that value and also RF path compensation, if set by host
optionally we can have syscfg to define constant gain for PA/LNA to have some build time optimizations possible

proposed names for APIs would be ble_ll_fem_(pa|lna)gain_get()
syscfg BLE_LL_FEM(PA|LNA)_GAIN - if set to 0 means LL has to call API to get actual gain, otherwise use that value

The thing is that FEM might not have fixed gain,  ie in SKY66112 TX gain depends on SKY configuration and input power, so LL will have to iterate (?) to match expected output power with whatever can be set by phy, alternatively we can add some output parameters where FEM returns also expected PHY tx power

The "current" solution will call FEM API which will set tx power via phy. Proposed solution will call FEM API to obtain tx power and set it via phy - I suspect this will be the same value, so what is the problem here?

"LL should call it and then calculate actual TX power or RSSI using that value and also RF path compensation, if set by host"
this is other way around, only FEM can calculate actual TX power since it (may) depends on input power and FEM (possibly runtime) configuration.
Also to cover all scenarios, like rounding, reading supported power ranges etc we need ble_ll_fem_pa_gain_set() which will configure FEM as needed (as oppose to get() which would just return values for rounding)
Than, ble_ll_fem_pa_gain_get() would return actually configured gain (compared to PHY tx power that was last "set")

this will be handled in https://github.com/apache/mynewt-nimble/pull/1374


BUG: Fix itk::STAPLEImageFilter test argument order

Fix itk::STAPLEImageFilter test argument order.
Set the maximumIterations and confidenceWeight arguments to the
wrong order in commit aa76dfb, which made it so that maximumIterations
was being set to 0, which in turn caused the code coverage to drop.
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

Weirdly enough, this was not causing a regression error. Maybe the filter is not working as expected. To be investigated separately.
The PR will need to be rebased on master once PR #3623 gets merged.


Fix ActionView::Template#new deprecation warning in Rails 6

In Rails 6 this method now requires the locals named argument [1].
[1] https://www.github.com/rails/rails/commit/d4015a7f06

Hello @sebjacobs
I am sorry I didn't see your commit and I just push similar one to 4-0-dev branch https://github.com/rspec/rspec-rails/pull/2071/commits/6061628910bcec6513d5f2fd9d91867388e66099
Closing for the already pushed similar commit.
Thanks for your contribution


RC Test: Molecule Polarity 1.3.0-rc.1

RC Test
Mentions: @arouinfar @kathy-phet @KatieWoe
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html
phet-io wrapper index
link to phet-io zip file

Test Matrices

General Test Matrix
PhET-iO Test Matrix

Features included

[x] PhET-iO (including migration from 1.2 to 1.3)
[ ] Alternative Input
[ ] UI Sound
[ ] Sonification
[ ] Description
[ ] Voicing

Focus and Special Instructions
Changes in this release:

the Options dialog was replaced with the Preferences dialog
dynamic locale support was added
the sim was brought up to the latest PhET-iO standards
includes migration support from the previous version (https://phet-io.colorado.edu/sims/molecule-polarity/1.2/).

Issues to Verify

[x] https://github.com/phetsims/studio/issues/308
(see instructions in https://github.com/phetsims/studio/issues/308#issuecomment-1593626537)
[x] https://github.com/phetsims/molecule-polarity/issues/138

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL
spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.
As the RC ends, please review the QA credits in the about dialog.  If the QA credits are complete and correct, please add a comment in the RC test issue indicating so.  If not, please open a new issue and specify what changes should be made.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Memory tests look mostly ok to me. The starting footprint on the PhET-iO brand seemed unusually large though.
PhET Brand:

PhET-iO Brand:

QA is done!

Thank you QA team.  We'll need another RC spot check.  I'll get that going as soon as all issue have been addressed.
Closing.


[SP-3723][PDI-16416]-Disconnect from a repository does not prompt the user to save the files before disconnect

-added prompt the user to save the files

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/spoon/Spoon.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.ui.spoon.Spoon

Instruction Change: -.00%:small_red_triangle_down:
Line Change: -.01%:small_red_triangle_down:


RFE: use autoscaling for workers

After some debugging my issue with Sentry being stuck processing events from a high traffic site where we use it for CSP reports and scaling Kafka, RDS and Redis during the process I found that the single worker was using 100% CPU. The template is not using autoscaling currently. What is the reason for this?
I propose the same scaling rules like for all other tasks. I am happy to send a pull request if you agree.
In my scenario I now temporarily scaled to 50 workers to let the queue be processed.

The workers were not scaling or the actual cron ?
The cron itself doesn't have scaling as there was a problem in the past for running more than one cron.
Might not be an issue now though, so I'll just add it

The workers were not scaling or the actual cron ?
The cron itself doesn't have scaling as there was a problem in the past for running more than one cron.
Might not be an issue now though, so I'll just add it

Oh, no, you're right. The actual workers don't have scaling. Seems I just missed that. Sorry. Adding it now.

Oh, no, you're right. The actual workers don't have scaling. Seems I just missed that. Sorry. Adding it now.

Released under 1.7.0

Released under 1.7.0


Add a standard README

Here is a sample minimal standard readme which one can refer sample
OR you can refer this sample2

#5

PR accepted, should be closed (I don't seem to have permission to do so)

@BrunoGomesCoelho your PR has been merged, you can check it in the commits for the project.


fix npm version

specify the npm version that corresponds to the Node.js version.
cf. https://qiita.com/hirorock/items/3a98a43f38aec39aab4f

use 6.14.11

I won't do it.


Log Top Level Npm Packages in Diagnostics Window

Issue #1116
Bug
To investigate perf issues with Typescript/Salsa, we would like to be able to request a list of installed node modules when a user reports a performance issue.
Fix
Adds installed node module information to the Diagnostic window. If a user is running into perf issues, we can request that they provide the output of the Diagnostics window to us in order to help with out investigations.
Testing
Tested with a few different project/solution types
Here's an example for a solution with two express projects:
Use Ctrl-C to copy contents

Projects:
    Project: ExpressApp17\ExpressApp17.njsproj
        Kind: Node.js
        StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp17\bin\www
        WorkingDirectory: .
        PublishUrl: <undefined>
        SearchPath: <undefined>
        CommandLineArguments: <undefined>
        Analysis Log:
        Analysis loading...
        Top Level Node Packages (9):
            body-parser 1.8.4
            cookie-parser 1.3.5
            debug 2.0.0
            express 4.9.8
            jade 1.6.0
            mocha 2.5.3
            morgan 1.3.2
            serve-favicon 2.1.7
            stylus 0.42.3

        Project Info:
            .js (included in project):
                Number of Files: 4
                Average Line Count: 22
                Max Line Count: 61
            .d.ts (included in project):
                Number of Files: 14
                Average Line Count: 418
                Max Line Count: 2557
            .js (excluded from project):
                Number of Files: 641
                Average Line Count: 194
                Max Line Count: 15226
            .html (excluded from project):
                Number of Files: 6
                Average Line Count: 106
                Max Line Count: 324

    Project: ExpressApp1\ExpressApp1.njsproj
        Kind: Node.js
        StartupFile: C:\Users\matb.REDMOND\documents\visual studio 2015\Projects\ExpressApp17\ExpressApp1\bin\www
        WorkingDirectory: .
        PublishUrl: <undefined>
        SearchPath: <undefined>
        CommandLineArguments: <undefined>
        Analysis Log:
        Analysis loading...
        Top Level Node Packages (8):
            body-parser 1.8.4
            cookie-parser 1.3.5
            debug 2.0.0
            express 4.9.8
            jade 1.6.0
            morgan 1.3.2
            serve-favicon 2.1.7
            stylus 0.42.3

        Project Info:
            .js (included in project):
                Number of Files: 3
                Average Line Count: 26
                Max Line Count: 61
            .d.ts (included in project):
                Number of Files: 13
                Average Line Count: 432
                Max Line Count: 2557
            .js (excluded from project):
                Number of Files: 430
                Average Line Count: 179
                Max Line Count: 15226
            .html (excluded from project):
                Number of Files: 3
                Average Line Count: 88
                Max Line Count: 188

closes #1116

:+1:


Support "individualization-request" message type

Encrypted Media Extensions defines "individualization-request" message type
https://www.w3.org/TR/encrypted-media/#idl-def-MediaKeyMessageType.individualization-request
For my use case, I would like to specify a URL to send the messages to, just like specifying a license server URL.

Since it seems easy, we will try to fit it into v2.5.  We just need to decide how the configuration will work.
We could create an additional URL field (per key-system) for this type of message.  Or we could create a map of message type to URL (per key-system).
Or, we could add message type to the Request object, and let advanced routing based on message type be handled by request filters.

I don't think it is the case that "individualization messages won't ever be destined for the same server as licenses". It just happens to be that my use case needs a separate URL. It feels more like an implementation detail or business logic.
What is going to be the default behavior if the user doesn't want to special case individualization-request messages, and just want to use the same URL?
I'm ok with shaka player propagating up the message type along with a Request object but I'm guessing that most use cases is simply sending the message somewhere else, rather than changing the content of the requests. Plus it requires extra network handling in the app.

I don't think it is the case that "individualization messages won't ever be destined for the same server as licenses". It just happens to be that my use case needs a separate URL. It feels more like an implementation detail or business logic.

I was thinking that most individualization requests would be going to some central location run by the DRM provider, and that licenses might be served by something specific to the application.  If everything can be handled by the app's servers, why do we need this feature?

What is going to be the default behavior if the user doesn't want to special case individualization-request messages, and just want to use the same URL?

If a separate URL is not provided, it would default to the one provided for licenses.

I'm ok with shaka player propagating up the message type along with a Request object but I'm guessing that most use cases is simply sending the message somewhere else, rather than changing the content of the requests. Plus it requires extra network handling in the app.

A URL string config is definitely easier for an app developer than writing a filter callback.  So there's that to consider.

I was thinking that most individualization requests would be going to some central location run by the DRM provider, and that licenses might be served by something specific to the application. If everything can be handled by the app's servers, why do we need this feature?

I think this will be the majority of the use cases. I was just replying to the "won't ever be" part.
If the default behavior uses the URL for licenses I'm not too worried about cases where they happen to be the same endpoint.
I think it's easiest for the app devs to be able to specify a separate URL for individualization requests, but I'll leave it up to you folks to design the API :)

Okay.  Then I think my gut says to offer a configurable URL string for the individualization requests, for simplicity, and to add the message type to DRM-related requests for generality.  Anybody who wants the common thing can do it easily, and anybody who wants more detailed routing can still get the info they need to do that.
Thanks for talking this out!

This feature was released in v2.5.0-beta2.