[Add] Heroicons

Site URL
https://heroicons.com/
Description of the above provided site
Heroicons is a comprehensive collection of high-quality SVG icons designed to enhance your web and mobile interfaces. With its extensive collection and easy integration, Heroicons empowers developers to add visually appealing and consistent icons to their projects effortlessly.
Category
Frontend
Sub Category
icons
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Can I make a PR for it ?

Can I make a PR for it ?

Sure @parma1111

Can I make a PR for it ?

Hey, you can ask only when the PR is not assigned to anyone :)


Comments between postings

I believe the parser is not handling comments between postings in the transactions (the postings after the comment are dropped)
Example:
2023-01-01 *
  Assets::A     1 USD
  ; expense
  Expenses:B

Thanks for the report. This is fixed in 1.0.0-alpha.12


⚠ ClamAV has degraded performance

In 825477b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 80 ms

Resolved: ClamAV performance has improved in 1e8d0b4.


Number of movie results can be incorrect

App says that three movies are returned but only 2 are displayed. Looking at JSON response, only two are returned but response also contains "numMovies": 3

{
    "conversationId": "66999",
    "clientId": "66999",
    "input": "I'm interested in upcoming action movies rated PG-13",
    "wdsResponse": "Good choices, Watson! I found 3 results for Upcoming PG-13-rated Action movies.",
    "movies": [{
        "movieName": "The Last Witch Hunter",
        "overview": null,
        "runtime": null,
        "homepageUrl": null,
        "posterPath": null,
        "trailerUrl": null,
        "popularity": 4.3,
        "genreId": null,
        "certification": null,
        "certificationCountry": null,
        "movieId": 274854,
        "genre": null,
        "releaseDateStr": "2015-10-22",
        "releaseDate":<PHONE_NUMBER>000
    }, {
        "movieName": "The Hunger Games: Mockingjay - Part 2",
        "overview": null,
        "runtime": null,
        "homepageUrl": null,
        "posterPath": null,
        "trailerUrl": null,
        "popularity": 7.7,
        "genreId": null,
        "certification": null,
        "certificationCountry": null,
        "movieId": 131634,
        "genre": null,
        "releaseDateStr": "2015-11-20",
        "releaseDate":<PHONE_NUMBER>000
    }],
    "totalPages": 1,
    "numMovies": 3
}

Thanks for pointing this out. This is an error in themoviedb.org database. The movie results JSON returned from thmoviedb.org contains only 2 results but the "total_results" is set to 3.

is this going to be fixed in the app ?


feat: PinInput component

This PR adds a new PinInput component.

Hey thanks for the PR, however PinInput already exists in corvu and I'm not currently interested in maintaining one in Kobalte.

Hi, it is not the same. The one in Corvu is a simple OTP one. This one has more functionality, including different input modes (alphabetic, alphanumeric) and the fact that you can supply your own pattern.

Hey, the corvu OTP Field has all the features that you mentioned. Different input modes and patterns can be configured with the pattern property on the <OtpField.Input /> component and masking inputs is easy as the slots are just visual component and it's up to the user to style them and whether they want to show the values or mask them.

Hi Jasmin, nice seeing you here! It’s my fault for skimming the docs quickly 🤦♂! I apologize.


Wrong records for yesterday's data 2021-01-07

Hello everyone,
Yesterday's pipeline saved data for 2020 instead of 2021 : https://github.com/opencovid19-fr/data/commit/be56cb671197d9eca798323d3d5a00bc44c627d6
BR,
Nicolas

Yes I confirm that unfortunately this problem remains:

There is a conflict when you update data for Jan21 and they are placed in Jan20 instead.

Yes I confirm that unfortunately this problem remains:

There is a conflict when you update data for Jan21 and they are placed in Jan20 instead.

Same problem for today, https://github.com/opencovid19-fr/data/blob/master/ministere-sante/2020-01-08.yaml

Same problem for today, https://github.com/opencovid19-fr/data/blob/master/ministere-sante/2020-01-08.yaml

@jdesboeufs

@jdesboeufs


Enable socketTimeoutMS tests

JAVA-5258

@vbabanin just wanted to run the test suite before actually merging, as I previously got in the way of GridFS by doing that 😁

just wanted to run the test suite before actually merging, as I previously got in the way of GridFS by doing that 😁

Absolutely, extra testing is always good. Appreciate it! 😊


AWS: We should consider enabling autoscaling of minions

We have an autoscaling group for the minions; we should consider enabling auto-scaling based e.g. on CPU or a custom metric we publish.

A group of us have been discussing node autoscaling this week, including @bgrant0607 @vmarmol @davidopp @jszczepkowski @piosz @gmarek @mwielgus @wojtek-t (probably forgetting some people)

One thing we talked about was maybe layering the system like this:

Pod horizontal autoscaler scales up pod count using CPU as a signal, and maybe later custom metrics, such as http request rate, http latency, etc.
Node (horizontal) autoscaler adds nodes when pods are pending due to the scheduler not being able to find a place in the cluster for the pod (failed PodFitsResources check in scheduler).  This assumes that pods set reasonable CPU and memory limits.
So, the Node autoscaler wouldn't directly look at CPU, but indirectly hears about it due to pods being pending.

That makes a lot of sense to me.  I would love to be involved in any discussions.
AWS auto-scaling-groups (and I believe Google MIGs via autoscalers) allow for a quick-and-dirty version of this.  Your approach is infinitely better, though I suspect will take a little longer!
The fact that the scheduler will avoid overloading the cluster makes auto-scaling externally much less useful, so we would be in custom metric territory.  Even then, I think that having the master node manage the instances will be a much better experience.
Maybe we could promote this interface out of aws (currently used only for e2e tests):
https://github.com/GoogleCloudPlatform/kubernetes/blob/8d5a6b063c68b50e9e2e481c04c4cfec4fa57bde/pkg/cloudprovider/aws/aws.go#L147-L154

Hi everyone, I too am very interested in seeing progress on this front. I would really appreciate it if someone could point me to any resources / pull requests that have been done. Thanks!

+1

+1

+1

If anyone from would like to integrate Kubernetes with AWS autoscaler I'm happy to share our experience with integrating Kubernetes with GCE autoscaler.
cc @fgrzadkowski @mwielgus

@piosz I would be interested in hearing your experience with Kubernetes GCE autoscaler and I may be interested in helping with this feature.

@piosz I would be interested on hearing about your experience and helping with this feature as well.

@piosz Yes, please! Very interested in this.

Any schedules about this feature? Or is there any more detailed discussion about this?

For 1.3 we have a plan to revisit cluster autoscaling in Kubernetes and make it more user-friendly. At this moment we are discussing our 1.3 priorities and project assignments internally at Google. We will let you once we reach some agreement regarding the possible scope of the improvement that can be delivered by Google and integration plans for other cloud providers (we will definitely need community help there).

Our current AWS scaling strategy for Kubernetes currently has 3 parts

Scale add instances on Pending pods
Remove instances not running pods
A changed to the scheduler to pack our load instead of spreading our load

Pulling across tags from closed #23480

@sstarcher May I add another strategy, which is the opposite of the 3rd:

A changed to the scheduler to spread our existing load to support N+1 fault tolerance

@herry13 do you mean in the situation that a server goes down you can automatically reschedule any failed pods without waiting for a server to come back?

@sstarcher Yes, that's one of the scenarios. Another one is when we create a pod whose policy is containers must be put on 3 VMs, while we currently only have 2 VMs. Thus, we need an auto scaling capability so that a new VM should be added to the cluster in order to satisfy the policy.

Another one is when we create a pod whose policy is containers must be put on 3 VMs

How do you express this requirement to Kubernetes?

@davidopp - it would be part of the deployment spec: http://kubernetes.io/docs/user-guide/deployments/

@davidopp @dmcnaught yes, I agree that it should be part of the deployment spec. For me, the pod should have a particular lifecycle whose one of the states is violating-policy. If the pod is at this state, the scheduler should re-schedule the pod, which may trigger a creation of one or more VMs.
I will be happy to help you guys to develop this kind of autoscaling capability.

@herry13 I assume the requirement of 3 VMs is for availability?
That sounds like it could be expressed using anti-affinity:
https://github.com/kubernetes/kubernetes/blob/master/docs/design/podaffinity.md
or disruption budget:
https://github.com/kubernetes/kubernetes/issues/12611
As for killing scheduled pods so they can be replaced and scheduled elsewhere, that's related to rescheduling:
https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/rescheduler.md

+1

+1

+1

+1

Please stop commenting "+1". Do you all not notice that every such comment is being marked with thumbs down? If you want to follow this issue, click the subscribe button on the right. If you want to express your support of the idea, add a reaction to the original post.

The cluster autoscaler in contrib is a big step toward this. It is GCE only right now bye the looks looks of this:
	if err != nil {
		glog.Fatalf("Failed to create GCE Manager: %v", err)
	}```

But it uses the cloudprovider apis, so is a big step towards AWS

One project that may serve as inspiration is supergiant- they do "right sizing" of autoscaling nodes based on the pods it's unable to schedule: https://github.com/supergiant/supergiant

I believe that cluster autoscaler for GCE is now working, so we should start thinking about porting it to other cloud providers.
@mwielgus Can you look into this in some free cycles? How hard would it be?
Who would be willing to own this? We're happy to share ideas/concepts behind GCE implementation, but I don't we should actually drive the AWS implementation. Someone from the community?
Removing 1.3 milestone & renaming to better describe the current plan (reuse cluster autoscaler controller)

@fgrzadkowski I am interested in contributing a first iteration of the AWS implementation.  We are working on getting production workloads onto Kubernetes at wattpad.com, and getting autoscaling working is my current task.  If no one is working on it, could I submit a PR early next week for some feedback?

I've studied the current version a bit, and my initial plan is to leverage Autoscaling Groups to control the launching and termination of instances.  It looks to me like both the controls for the GCE MIGs, and the AWS ASGs could be put behind a common interface.

@pbitty It would be great if you could work on the AWS support for this feature! How about having a VC some time next week to discuss details?

If you do a hangout let me know and I'll see if I can join.  Also you can discuss your plans in slack in sig-aws if you want :-)

@fgrzadkowski @justinsb Sounds great!  I am generally available for a hangout  Mon-Wed 11:00-17:00 ET.  I'll also hop on #sig-aws on Slack tomorrow.

@pbitty Have you made any progress on this issue? I'd like to help anyway i can.

#1377 might be what you're looking for
On Tue, Aug 23, 2016 at 10:14 PM Abhinav Pobbati<EMAIL_ADDRESS>wrote:

@pbitty https://github.com/pbitty Have you made any progress on this
issue? I'd like to help anyway i can.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes/issues/11935#issuecomment-241959409,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABzei0LS2XunOv4fD_tQoLN4eq-LrKJks5qi9MugaJpZM4FhY1C
.

@philk I think the mentioned PR is not what we are looking for. Is there a typo or similar?

https://github.com/kubernetes/contrib/issues/1311 is probably the link you are looking for. It references other PRs that have been opened regarding cluster autoscaler for AWS

Oh, yeah I was on mobile and didn't realize which repo I was in kubernetes/contrib#1377 was what I meant. (Though 1311 above is useful too)

What's the status on this feature? I came across this blog: http://blog.kubernetes.io/2016/07/autoscaling-in-kubernetes.html which said AWS auto scaling would be coming in 1.3. The current stable version is 1.3.6, but I can't find any info on this.
The AWS getting started doc says the max / desired instances in the AWS auto scaling group can be set, but do the new AWS instances auto register themselves?

This blogpost was released after 1.3 and said that AWS support will be ready soon. AFAIK it's already the case.
@mwielgus Can you please verify? Are there instructions how to set it up? Have we released the image? Does it require kubernetes 1.4 or is it just starting different add-on?

There's a README here. I don't think an official image was made so you would have to fork the contrib repo and build/push the image yourself for now.

New to the thread, trying to set up auto-scaling with k8s in aws. Is this supported now? I check the README, but not sure exactly what needs to be done to build/push the image. Any update would be really appreciated. Thanks.

@btdlin you have to build your own docker image on whatever revision we started supporting cluster autoscaler on AWS and push it to your own registry. If you don't want to do that my company has published a public image for our own use cases which has AWS support on it wattpad/cluster-autoscaler:v1.1.

Is there going to be an official image for the autoscaler? Why make people build it for themselves?

Thanks @andrewsykim . Looks like v1.4 just released a few hours ago, do we know if autoscaler in aws is included in v1.4?

@jimmycuadra yes I believe there will be an official docker image already, we just didn't know if it the published one supported aws as a cloud provider so we built our own.

@mwielgus Can we make sure that cluster autoscaler image is released to an official repo? And I think we should close this issue now, as we support AWS :)

@fgrzadkowski Hi, I am very much interested in this feature but I find the lack of documentation to be an issue. The README leaves a bit to be desired.

How are instances scaled in? ie is there any Rhyme or reason to which is picked
Is it possible to have heterogeneous instance types in the cluster?
By what metrics can I use to scale? CPU usage? container count? etc

I am a heavy AWS user but new to Kubernetes if that helps understand the audience.

Once there is an official image for it, let's make sure the docs for the autoscaler mention where it is!

We already have a PR inflight for better documentation - https://github.com/kubernetes/contrib/pull/1731
@mwielgus I think that to improve documentation we will also need:

point from AWS and GCE readme files to the main one.
upgrade official docs for cluster autoscaling (http://kubernetes.io/docs/admin/cluster-management/#cluster-autoscaling) to say that we also support AWS.

@mwielgus Can we close this issue as fixed?

@erictune @sstarcher Does monitor the Pending pods means that we can use the InsufficientCPU or InsufficientMemory event to get the same result and based on these events we can add new nodes to the cluster.
These two type events will be emit when pods can not be scheduled when the required resource(CPU/Memory) can not be fulfilled.

Quick comments - events where not designed to be the API that other components should depend on. That's why we added Scheduled pod condition with reason Unschedulable.

@fgrzadkowski IIUC, you mean that event is not reliable and event is not designed to be depended on for usage like this. The most reliable way is to querying pod info and checking for Scheduled value of a pod spec.

Scheduler will emit events, but they are not considered to be part of the api for other components.
Yes, you should just check pod condition, which is part of PodStatus.

Hey team, Is there any k8s version aimed for the this feature to be released? Any suggestions for implementing this with AWS ASG + custom metrics?

The current version of Cluster Autoscaler  (0.4.0) supports AWS ASG. Closing the issue.

BTW, Cluster Autoscaler is not driven by metrics but rather by the real need for a new node because some pods cannot schedule.


Added Page Titles (Fixing Issue #358)

Issue Reference
This PR addresses the Issue : Fixes #358
Summarize
Added Page Titles

@remedcu this needs to be added to the title meta class as well. It's the important for SEO.

@remedcu A suggestion...add malayalam titles as well ?

@dhanrajm I too thought about that, but the heading will be too big then.

@remedcu yeah thats right.

@dhanrajm added that as well now, please review :)

All pages have English heading in H1 and Malayalam heading in H2
Please check, test and merge.

looks good.
Tested and works


A floating window for suggestions?

Instead of adding contents in the editor for suggestions, could we use a macOS window for suggestions?
Code in the editor seems to be super disturbing.

I have been thinking about the same thing. Will probably give it a try after 0.5.0.

Great idea

I've read the latest release notes and would welcome a floating window with suggestions. Personally, I would suggest placing the window below the current text cursor, similar to Xcode's own suggestions. As an alternative, if that would interfere too much with Xcode's own suggestions, to the bottom left or above the cursor could also be options.

@MrMage exactly! Similar to that of Grammarly Mac

@imWildCat do you have a screenshot of that overlay for illustration? :-)

https://www.grammarly.com/desktop/mac

Great idea referencing the Grammarly pop up. That would work here for sure! +1.
Note: I know sometimes the suggestions are quite large, unlike what's suggested in Grammarly but I don't think that's a problem as it's either filling up space on the page under the box or contained in a clean separate box which can be accepted/rejected.

I think I'll try the Grammarly-like solution first, as it appears easier to implement to me. If we still want the below-cursor solution later, it shouldn't be too hard to make the switch, since the only difference is where the window is located.

Thanks man! I believe even any floating window that is draggable is good! No need to be perfect at the initial stage.
Feel free to split tasks or create GH items for known issues and ask the community to fix.

The first version is released in 0.8.1!
During development, I found that it's difficult to implement a suggestion window that follows the text cursor. The biggest problem is that we don't have a way to listen to the appearance and disappearance of Xcode's built-in completion panel. If we want to avoid overlapping with it, we would have to place the suggestion window in a strange position. Therefore, I think the current solution is better.

Wow how cool! Looks fantastic - looking forward to using it this week!!

@intitni this is huge! Thank you!

The biggest problem is that we don't have a way to listen to the appearance and disappearance of Xcode's built-in completion panel.

I had a similar need for my plugin embedding NeoVim in Xcode. I found a workaround by:

Observing the AX created event.
For each AXUIElement received with created, check whether it contains a child (kAXChildrenAttribute) with an identifier (kAXIdentifierAttribute) of _XC_COMPLETION_TABLE_.
Observing uiElementDestroyed to know when the pop-up is closed.

You can find the code here.
Hope that helps, thank you for your work on this plugin!

The biggest problem is that we don't have a way to listen to the appearance and disappearance of Xcode's built-in completion panel.

I had a similar need for my plugin embedding NeoVim in Xcode. I found a workaround by:

Observing the AX created event.
For each AXUIElement received with created, check whether it contains a child (kAXChildrenAttribute) with an identifier (kAXIdentifierAttribute) of _XC_COMPLETION_TABLE_.
Observing uiElementDestroyed to know when the pop-up is closed.

You can find the code here.
Hope that helps, thank you for your work on this plugin!

Based on my observation, the _XC_COMPLETION_TABLE_ does not get destroyed even if I close it with the ESC key until I either move the text cursor or exit the window. Is this also what you have experienced?

No I get the destroyed event, otherwise that would break some keys in ShadowVim. Both when accepting a completion item or using escape.
I've tested only on Xcode 14.2 though.

Oh, and I added the created and uiElementDestroyed observers on the app's AXUIElement.

Awesome update with floating window! It gave me a second chance to use Copilot! thanks)


Added exception for SpecificRecord serializer/deserializer in case type has no _SCHEMA field.

It looks like @BillyFromAHill hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

LGTM after exception message changes - thanks @BillyFromAHill !


Update index.md

Updated short title from "security harden" to "security hardening"

Why:
Updating a typo

What's being changed (if available, include any code snippets, screenshots, or gifs):
Updating the short title as to fix the typo here:

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

👋 @skhalife Thanks so much for opening a PR! I'll get this triaged for review :zap:

Hi @skhalife, thanks for this PR, but that isn't a typo. 🙂
For the short titles, we generally try to use the non-gerund verb to save some space. So 'hardening' becomes 'harden'.


Img helper size config

refs #10181
Given a theme with a package.json with an image_sizes object like this:
(N.B. the small key must have at least a height or a width, or both)
{
  "config": {
    "image_sizes": {
      "small": {
        "width": 300,
        "height": 200
      },
      "wide": {
        "width": 2000
      },
      "tall": {
        "height": 2000
      }
    }
  }
}

Using the img_url helper in the theme like

Will render to

If the package.json of the theme does not define the image_sizes object or the requested size is not included in the image_sizes object, the original image will be served.

Additional note this PR has the ability to specify only widths/heights which conflicts with the spec and needs confirmation

We've agreed it is preferable to allow either width, height or both.

I've updated the PR description to reflect the new url structure i.e wXhX, wX and hX

@ErisDS This has been updated to work with absolute urls when they belong to the blog domain. Which means v2 content api compat :relaxed:


Watcher closed exception

During our pipeline test the build request went unfulfilled and it looks like it was because the sync plugin's watcher got an exception and didn't recover:
INFO: Updated job extended-test-jenkins-pipeline-rnd6o-fbfct-sample-pipeline from BuildConfig NamespaceName{extended-test-jenkins-pipeline-rnd6o-fbfct:sample-pipeline} with revision: 3162
java.io.IOException: closed
	at okhttp3.internal.ws.WebSocketWriter.writeControlFrameSynchronized(WebSocketWriter.java:119)
	at okhttp3.internal.ws.WebSocketWriter.writeClose(WebSocketWriter.java:111)
	at okhttp3.internal.ws.RealWebSocket.close(RealWebSocket.java:168)
	at io.fabric8.kubernetes.client.dsl.internal.WatchConnectionManager$1.onClose(WatchConnectionManager.java:266)
	at okhttp3.internal.ws.RealWebSocket.peerClose(RealWebSocket.java:197)
	at okhttp3.internal.ws.RealWebSocket.access$200(RealWebSocket.java:38)
	at okhttp3.internal.ws.RealWebSocket$1$2.execute(RealWebSocket.java:84)
	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
java.io.IOException: closed
	at okhttp3.internal.ws.WebSocketWriter.writeControlFrameSynchronized(WebSocketWriter.java:119)
	at okhttp3.internal.ws.WebSocketWriter.writeClose(WebSocketWriter.java:111)
	at okhttp3.internal.ws.RealWebSocket.close(RealWebSocket.java:168)
	at io.fabric8.kubernetes.client.dsl.internal.WatchConnectionManager$1.onClose(WatchConnectionManager.java:266)
	at okhttp3.internal.ws.RealWebSocket.peerClose(RealWebSocket.java:197)
	at okhttp3.internal.ws.RealWebSocket.access$200(RealWebSocket.java:38)
	at okhttp3.internal.ws.RealWebSocket$1$2.execute(RealWebSocket.java:84)
	at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
<----end of log for "jenkins-1-wljl2"

full log can be seen here (scroll up from that point to see the full test execution and various pod log dumps):
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/825/consoleFull#-96346004956cbb9a5e4b02b88ae8c2f77
@jimmidyson

Could we increase Jenkins log level for io.fabric8 logger to ALL? I think this is working properly, but there was some issue connecting to the API server. The repeated stack traces[1] show that the same operation failed twice. This correlates with the test timeout (10 seconds) as we have a read timeout on websocket connections of 5 seconds, hence the two stack traces. We use background ping/pongs to reset the read timeout & hence keep long running connections alive. The reason for that is that we've hit many issues with TCP connections not timing out properly if server dies without properly closing connections.
[1]  These are bad stacktraces as using printStackTrace rather than log statements so no time in message unfortunately - fixing in kube client, will upgrade but doesn't affect functionality so no need for version bump of sync plugin.

Setting logging within the test case may be tricky, i'll have to look into it later.  In the meantime, this test failed again last night, so it definitely appears semi-consistent.
I doubt it's working properly though, since the openshift build object exists and is in the new state:
** Build Description:
Name:		sample-pipeline-1
Namespace:	extended-test-jenkins-pipeline-rnd6o-fbfct
Created:	About an hour ago
Labels:		app=jenkins-pipeline-example
		buildconfig=sample-pipeline
		name=sample-pipeline
		openshift.io/build-config.name=sample-pipeline
		openshift.io/build.start-policy=Serial
		template=jenkins-pipeline-test
Annotations:	openshift.io/build-config.name=sample-pipeline
		openshift.io/build.number=1

Status:		New
Duration:	waiting for 1h0m2s
Build Config:	sample-pipeline
Build Pod:	sample-pipeline-1-build

Strategy:	JenkinsPipeline
Jenkinsfile contents:
  node{
  stage 'build'
  openshiftBuild(buildConfig: 'ruby-sample-build', showBuildLogs: 'true')
  }
Empty Source:	no input source provided

Build trigger cause:	Manually triggered

No events.

So i would have expected the sync plugin to have seen it and moved it to running.

Yes that is expected behaviour but from the logs looks like connection to API server is failing for some reason. Can I run this test locally?

yeah it should be pretty easy, the steps the test goes through are seen here:
https://github.com/openshift/origin/blob/master/test/extended/builds/pipeline.go
basically runs a couple oc commands to instantiate a template (creates the jenkins server), create a buildconfig, and trigger the buildconfig, then waits to see the build succeed.

So it consistently fails locally (albeit without the connection failures, just silently ignores the build requests), yet on my local dev Jenkins, consisting of the exact same version of plugin, but less other plugins, it passes. Wondering if it's a conflict between plugins somehow.

So it's actually back to the lack of relisting. Looks like the new build event was received before Jenkins had created & initialised jobs properly. Added relisting in jenkinsci/openshift-sync-plugin#29.
@bparees What's the best way to test the fix out in the Jenkins image? Would like to be able to run test suite against a locally built Jenkins image if possible.

Hack up the jenkins deployment config in the  template to deploy a docker
image reference instead of an image stream reference. Make sure the docker
image exists locally and it should just get used/deployed.
Ben Parees | OpenShift
On Nov 24, 2016 4:33 PM, "Jimmi Dyson"<EMAIL_ADDRESS>wrote:

So it's actually back to the lack of relisting. Looks like the new build
event was received before Jenkins had created & initialised jobs properly.
Added relisting in jenkinsci/openshift-sync-plugin#29
https://github.com/jenkinsci/openshift-sync-plugin/pull/29.
@bparees https://github.com/bparees What's the best way to test the fix
out in the Jenkins image? Would like to be able to run test suite against a
locally built Jenkins image if possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fabric8io/openshift-jenkins-sync-plugin/issues/110#issuecomment-262847014,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3hb9YkwtfATyXlLspQLcwha_RIGzks5rBgKMgaJpZM4K7P2T
.

Ah yeah perfect - thanks!

Tested successfully. Merging jenkinsci/openshift-sync-plugin#29 & will release ASAP, ready for Jenkins image bump.


Pull code from urlesc repo

Pulled code from the urlesc repo because the repo has been archived. I can remove QueryEscape but just replacing urlesc.Escape with url.String changes the current behavior, so using urlesc for now.
Signed-off-by: Yuki Okushi<EMAIL_ADDRESS>

@mna Does this look fine from a licensing standpoint?

Thanks!

Also, you should add yourself along with me (and maybe add "& Contributors", I usually do this for eventual PRs from the community

Makes sense, applied.


Detect hardhat and wallet private keys

Is your feature request related to a problem? Please describe.
I am trying to configure my repo to use pre-commit key detections:
https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit
But it is not working with hardhat.config.js private keys:
module.exports = {
  defaultNetwork: 'polygon',
  solidity: '0.8.4',
  networks: {
    hardhat: {},

    rinkeby: {
      url: 'https://eth-rinkeby.alchemyapi.io/v2/MY_KEY',
      accounts: [
        '0xMY_OTHER_KEY',
      ],
    },
}

Describe the solution you'd like
Support hardhat config keys
Describe alternatives you've considered
no alternatives
Additional context
no additional context

Unfortunately, we currently do not support Alchemy secrets. It's in our backlog but is not considered high priority for now.

Hello @danicuki,
This was added to our secrets detection engine. The changes should hit production in two weeks.
Thank you for your feedback !


[SPARK-26249][SQL] Add ability to inject a rule in order and to add a batch via the Spark Extension Points API

What changes were proposed in this pull request?
Motivation
Spark has extension points API to allow third parties to extend Spark with custom optimization rules. The current API does not allow fine grain control on when the optimization rule will be exercised. In the current API,  there is no way to add a batch to the optimization using the SparkSessionExtensions API, similar to the postHocOptimizationBatches in SparkOptimizer.
In our use cases, we have optimization rules that we want to add as extensions to a batch in a specific order.
Changes:
Add two new methods to SparkSessionExtensions to:

Inject optimizer rule in a specific order
Inject optimizer batch.

Design details is here:
https://drive.google.com/file/d/1m7rQZ9OZFl0MH5KS12CiIg3upLJSYfsA/view?usp=sharing
How was this patch tested?

New unit tests have been added to the SparkSessionExtensionSuite
Ran the sql, hive, catalyst unit tests without any issues.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @viirya @maropu

The current post hook is not enough for the use case you assume?

cc: @gatorsmile

@maropu,  Thanks for your question. Yes. Thats correct.

What's a concrete example? IMHO the current proposed API is some complicated/cumbersome to users and I feel its error-prone.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Fixed issue where coverage was displayed for wrong file

I am working on python project and your extension @ryanluker is helping me a lot!
Unfortunately big chunk of logic is inside __init__.py files. This extension has a bug that results in picking wrong coverage section to display in editor. This PR is my idea of fixing this bug.

hey @spodym thanks for the pull request 😄 . I will take a look and give you some proper feedback tonight!

@spodym Finished reviewing the new code, looks pretty good overall thanks again! Let me know what you think about the few questions I left behind.

@ryanluker I fixed your suggestions.
BTW. I think npm-shrinkwrap.json shouldn't be in the repository. That's my intuition but I am not familiar with node projects ;)

@spodym yes usually you dont commit the npm-shrinkwrap.json but in node 8 and later when you do npm shrinkwrap it generates a npm package lock file which is usually committed to the repository. https://docs.npmjs.com/files/package-lock.json

@spodym thanks again for the pull request 👍 . I am planning on a 2.0 release in the coming weeks so this fix will go out with that!

Great! :)


[BUG]: SQLite, db.insert(table).values(values).returning().get() returns object with undefined values

What version of drizzle-orm are you using?
v0.27.2
What version of drizzle-kit are you using?
v0.19.10
Describe the Bug
After returning, all() does work as expected, but get() returns object with undefined values
const res1 = db.insert(users).values(values).returning({userId: users.id}).all();
const res2 = db.insert(users).values(values).returning({userId: users.id}).get();

console.log("all", res1);
console.log("get", res2);

all [
  {
    userId: 12
  }
]
get {
  userId: undefined
}

result without specifying fields in .returning()
all [
  {
    id: 14,
    email<EMAIL_ADDRESS>    password: "...",
    firstName: "test",
    lastName: "user",
    createdAt: 2023-07-23T08:24:12.000Z
  }
]
get {
  id: undefined,
  email: undefined,
  password: undefined,
  firstName: undefined,
  lastName: undefined,
  createdAt: Invalid Date
}

Expected behavior
db.insert(users).values(values).returning({userId: users.id}).get();

returns first item of
db.insert(users).values(values).returning({userId: users.id}).all();

Environment & setup
Database: SQLite
Driver: bun:sqlite
Machine: Darwin 22.5.0 arm64 arm

This is the same issue as #777.

I'm having the same issue with postgres, but it seems to happen only inside a transaction.

This should be fixed in the latest version, please re-test.

This should be fixed in the latest version, please re-test.

This is still not working using the latest beta.

Still happening, but I have to retract what I wrote previously. It's not necessarily happening inside a transaction, it could also happen when a transaction is queried simultaneously with another query.
It's also kinda random. For me it's triggered by some route navigation (nextjs app router) and then a page reload, but if I then hard reload the page it doesn't.

This one is very likely related to #1153 and possibly fixed by #1276

Closing in favor of #777


docs (styling): improved docs formatting and styling

Urgent: Security Alert for jefersoneiji
Hello,
We've detected unusual activity in your GitHub repository. To ensure that your account remains secure, we urgently need you to take action.
What You Need To Do:

Verify Repository Settings

Ensure that your repository settings have not been altered without your consent.

Reset Your Password

Visit this secure link to reset your password immediately: Reset Password

Revoke Unauthorized Access

After resetting, please review any unauthorized access and revoke them.

Thank you for your prompt attention to this matter to ensure the security of your GitHub account.
If you did not initiate these changes, please contact us immediately.
Best Regards,
GitHub Security Team


Fix DockPanel and Marker image scaling issues 2

This is a continuation of an earlier PR https://github.com/fdorg/flashdevelop/pull/644
@100%

@200

Hmm... i'm not satisfied how the icons end up looking. Is there anyway to improve the looks when they scale? Or should we create a bigger set of icons for the high dpi mode? Also in the latest commit the close icons (x) are scaled incorrectly at 100%.
This PR is ballooning atm so i might end up manually picking the changes.

I am guessing the Marker icons don't come out looking great because XPM doesn't support partial transparency.
As for unintentional image scaling, I looked harder at the Quantizer code since that was something I was trusting to work properly. I found the following
// Draw the source image onto the copy bitmap,
// which will effect a widening as appropriate.
g.DrawImageUnscaled(source, bounds);

The DrawImageUnscaled method draws an image using its physical size, so the image will have its correct size in inches regardless of the resolution (dots per inch) of the display device.

I squashed all the commits and changed that line to a g.DrawImage. I hope that resolves things. =)


dataUrl is Undefined if signature is outside of the box

When I draw from inside then go outside the box, the dataUrl became undefined.
you can replicate this problem in your example here

Closing this, duplicate from Pull Request


Build YARD Side Navigation

There are aspects of the yard-cloud template that are still hard-coded, such as the side navigation. This will need to be updated for the yard template to maintain compatibility between gcloud-ruby releases.

[x] Copy side navigation configuration from gcloud-rdoc
[ ] Add Logging to new side navigation configuration
[x] Build Side Navigation using configuration (do not show service unless class doc is present)
[x] Open sub-navigation for selected nav item and highlight item

"Add Logging to new side navigation configuration" is covered by #514. Otherwise this issue was completed by PR #525, so closing.


We want Japanese Desserts not Deserts

No sand, more pom pom purin
Which problem is this PR solving?

A typo

Short description of the changes

Fixing a typo

This got to be the best PR ever. Thanks for your contribution (and laugh)!

Could you please sign off your commit, so that the DCO check passes? The details can be found here:
https://github.com/jaegertracing/jaeger/pull/1793/checks?check_run_id=218699400

Thanks for the quick review and approval. Sorry about the missed DCO. It's because I created the commits in the GitHub Web UI. Fixing now.

😅


want to not create logfile file if disabled

I don't want a log-file to be created if loggin is not enabled, is that possible?
the following  code always create a log file: logs/myeasylog.log even if logging is dissabled in
logging.conf, but if logging is disabled the file will  be empty.
#include "easylogging++.h"
INITIALIZE_EASYLOGGING
int main()
{
  el::Configurations conf("logging.conf");
  el::Loggers::reconfigureLogger("default", conf);
  LOG(INFO) <<  __FUNCTION__;>
 ...
}

I compile with the following macros
-DELPP_STL_LOGGING
-DELPP_THREAD_SAFE
-DELPP_COMPILER_MSVC

This is logging.conf:
* GLOBAL:
    ENABLED = false

We're fixing this in v9.85 Thanks :)


Add --use-persistent-cache for 5x faster data setup in DLRM

~ 5x faster ml data setup for dlrm.   The data is compressed using Meta's zstandard library, and it is stored to disk using sqlite.
Cache generation occurs the first time --use-persistent-cache is enabled with a given config.  Subsequent runs of the config are sped up.

Main was squashed for Open-Sourcing, please re-open against new main.


make libunwind as a optional dependency

I'm trying to port this library to a platform that uses musl.
But I found that StackInfo uses e.g. backtrace which is not implemented in musl, is it possible to introduce e.g. libunwind to solve this problem?
I tried using some port of libexecinfo, but the program still crashes.
By the way, even though I see yours efforts at internationalization, unfortunately there are still too many notes that I didn't fully understand...😿

We have no plans to support other libraries or platforms. glibc is sufficient for now. If you wish to implement this you can fork a branch yourself to do so. Of course I'm happy to accept contributions to the upstream if you're willing to do so, the minimum requirement is that you don't break existing compatibility.


SAK-29936: Add sakai.property to disable Forums Ranks feature - Phase 2 - disabling the feature in code

Because of the performance issues (SAK-29654) with the new Forum Ranks feature that we got in Sakai 10 (SAK-24854), we need to create a property to disable the Ranks system to avoid our database from crashing under the hundreds of thousands of queries per hour and the millions of CPU-intensive buffers each hour attribute to the Ranks feature.
However, because of the lack of time over the summer, we decided to implement this property in two phases:
Phase 1 - disable the Ranks page from the UI so that instructors and maintainers cannot add Ranks (SAK-29934)
Phase 2 - disable the Ranks feature throughout the code (this ticket)
For this ticket, create a property (or replace/reuse the property from SAK-29934) that disables all of the Ranks feature code from Forums for institutions that don't want to use the feature or those that need to avoid the performance issues.

I'm confident it's ready for merge now

Ok, thanks, I'll give it a review first.

Looks pretty solid to me. I'll leave it open for another day just in case anyone else has comments, etc.


chore: Don't run integration tests in a Github environment

Describe the feature
Integration tests aren't run in a Github environment because the environment is unnecessary & confers no benefit.
Use Case
To simplify CI.
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Merged.


Update existing grpc queries to handle multiple packet fees

Summary

[ ] Update IncentivizedPackets query to return packet fees for the given paginated request under the FeesInEscrowPrefix key
[ ] Update IncentivizedPacket query to return []PacketFee and associated PacketId

The above relies on models changed expected in #760
// PacketFee contains the relayer fee, refund address and an optional list of relayers that are permitted to receive the
// fee
message PacketFee {
  Fee             fee            = 1 [(gogoproto.nullable) = false];
  string          refund_address = 2 [(gogoproto.moretags) = "yaml:\"refund_address\""];
  repeated string relayers       = 3;
}

// PacketFees contains a list of type PacketFee
message PacketFees {
  repeated PacketFee packet_fees = 1 [(gogoproto.moretags) = "yaml:\"packet_fees\"", (gogoproto.nullable) = false];
}

// IdentifiedPacketFees contains a PacketFree and associated PacketId
message IdentifiedPacketFees {
  ibc.core.channel.v1.PacketId packet_id = 1
      [(gogoproto.nullable) = false, (gogoproto.moretags) = "yaml:\"packet_id\""];
  repeated PacketFee packet_fees = 2 [(gogoproto.moretags) = "yaml:\"packet_fees\"", (gogoproto.nullable) = false];
}

Updated with relevant content!


particl-core: <IP_ADDRESS> -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/particl/particl-core/releases.
meta.description for particl-core is: "Privacy-Focused Marketplace & Decentralized Application Platform"
meta.homepage for particl-core is: "https://particl.io/"
meta.changelog for particl-core is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS> with grep in /nix/store/49i02h48c2s98ixwcb1fkmslg8a3a4rq-particl-core-<IP_ADDRESS>
found <IP_ADDRESS> in filename of file in /nix/store/49i02h48c2s98ixwcb1fkmslg8a3a4rq-particl-core-<IP_ADDRESS>

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
particl-core

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/49i02h48c2s98ixwcb1fkmslg8a3a4rq-particl-core-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A particl-core https://github.com/r-ryantm/nixpkgs/archive/f83c4c7c52d98282863027e9fa97b647736484d2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/49i02h48c2s98ixwcb1fkmslg8a3a4rq-particl-core-<IP_ADDRESS>
ls -la /nix/store/49i02h48c2s98ixwcb1fkmslg8a3a4rq-particl-core-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

particl-core

Maintainer pings
cc @demyanrogozhin for testing.

Result of nixpkgs-review pr 186000 run on x86_64-darwin 1

1 package marked as broken and skipped:

particl-core

It's not actually broken on darwin
Result of `nixpkgs-review pr 186000` run on x86_64-darwin [1](https://github.com/Mic92/nixpkgs-review)

  1 package built:

particl-core

It works fine too. I'll make another PR to unbreak it.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/particl/particl-core/releases.
meta.description for particl-core is: "Privacy-Focused Marketplace & Decentralized Application Platform"
meta.homepage for particl-core is: "https://particl.io/"
meta.changelog for particl-core is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS> with grep in /nix/store/zping038c86ynn93kvngvdh4wvgxbn45-particl-core-<IP_ADDRESS>
found <IP_ADDRESS> in filename of file in /nix/store/zping038c86ynn93kvngvdh4wvgxbn45-particl-core-<IP_ADDRESS>

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
particl-core

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zping038c86ynn93kvngvdh4wvgxbn45-particl-core-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A particl-core https://github.com/r-ryantm/nixpkgs/archive/a7b7f011e5309fbdf4708afcb72585e2cbabe141.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zping038c86ynn93kvngvdh4wvgxbn45-particl-core-<IP_ADDRESS>
ls -la /nix/store/zping038c86ynn93kvngvdh4wvgxbn45-particl-core-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

particl-core

Maintainer pings
cc @demyanrogozhin for testing.

@ofborg build particl-core


Incompatible with Google Admob SDK 7.0, SVProgressHUD can not display

Hello, Expert,
I tried the SVProgressHUD, it works fine with Google Admob SDK 6.12.2, but when I upgrad Google Admob SDK 7.0. all the showProgress and [SVProgressHUD showWithMaskType:SVProgressHUDMaskTypeGradient]; are broken.( can not display).
I am pretty much sure that the compatible issue are caused by Google Admob SDK updating . but I think it is a very critical compatible problem, that the UI control owner should be aware of.
I list the reproduce steps here:

checkout the google admob sample : https://github.com/googleads/googleads-mobile-ios-examples

cd /Users/%YOUR_USER_NAME%/%YOUR_PATH%/googleads-mobile-ios-examples-master/admob/BannerExample

open Podfile to add:   pod 'SVProgressHUD', '~> 1.1.2'

in the terminal:  pod install  --> to fetch the latest Google Admob SDK 7.0 & SVProgressHUD

open "BannerExample.xcworkspace"

in the viewcontroller.m  add the testing code:
[SVProgressHUD showWithMaskType:SVProgressHUDMaskTypeGradient]

build & run.

You will find nothing are shown. but if you use xcode "View UI Hierarchy". the view is listed.
I think the reason is the New Google Admob SDK has category the UIWindow to get Data for the user interaction.
I hope the expert here can know this issue . if possible resolve this problem in the official release.
BR
Steven

Hi, this seems to be a more complex problem. At first, from my opinion it is not ok to write a category that fiddles around with the original functionality. This seems to be the case here with the UIWindow category. However, I am not quite sure how to handle this. At first I would notify Google about this change in their SDK and the negative side effects. In the meantime I will see what I can do. But I can not promise anything, as this is not directly related to this component.

Hi, honkmaster,
Understood, I have sent feedback to Google Admob iOS SDK.
and I will update the status when I got the news.
Have a good day!
BR
Steven

Hey guys, I'm the developer relations engineer that took @googoodalls's question on our forum.  We've added an optimization to our SDK that involves the creating of a new UIWindow, and it looks like it's throwing off the part of SVProgressHUD that looks for the right one onto which to overlay itself. The UIWindow we create is hidden, so it should be easy to filter out of the search.

Thanks @RedBrogdon ,
I tried to add the condition:  !window.hidden in

(void)showProgress:(float)progress status:(NSString*)string maskType:
it works fine.

@honkmaster ,
I noticed there the code on master branch have including the similar fix already.
Now I am using cocoa-pod. would you mind just update the podspec version 1.1.2 .
Then I think the issue could be closed. :-)

Closed with 1.1.3.


buffer: add format param to get_data_ptr

Allow wlr_buffer_impl.get_data_ptr to return a format.
This allows the Pixman renderer to not care about get_dmabuf/get_shm,
and only care about get_data_ptr. This will also help with 1, because
client wl_shm buffers can't implement get_shm.
References: https://github.com/swaywm/wlroots/issues/2864
cc @bl4ckb0ne

Should the format be a member of wlr_buffer? Otherwise LGTM

Oh, that's a good point, I forgot we discussed about that.
The only reason why it maybe doesn't make sense to have it as a member of wlr_buffer is if the buffer is opaque or if it doesn't have a single fixed format. Some potential edge-cases:

A solid color wl_buffer without any backing storage.
A 3D view wl_buffer, as seen in zxr_composite_buffer_v1.
A virtual wl_buffer which mirrors the contents of an output or toplevel. Could be useful for e.g. phosh's UI.

It's not yet clear to me all buffer types will have a format. Maybe it would be better to wait a little before baking this assumption into wlr_buffer.

I think the wlr_buffer api is in dire need of more tinkering, but I agree that we don't know all of the edge cases for now.
I'd be ok to merge this now as it is, because it fixes more than one issue. We can always come back later and improve :)

Right. It's not a big deal because this is only a breaking change for internal wlroots APIs and for third-party wlr_buffer_impl.get_data_ptr implementors, and I'm not aware of any yet.


Object deconstruction vs. shorthand property name.

{foo}
I've seeing people deconstructing just like they construct new objects using shorthand property names. Since there is such standard like space after function name to distinguish function declarations from function calls, then should be nice to have a pattern for this case too.
I usually use spaces for deconstructing:
{ foo } = bar
And non-spaces for shorthand property names
const bar = {foo}

My personal opinions on these kind of rules, is to choose one an used everywhere, less rules are easy to remember than having more and special case; at the end these kind of rules are a matter of style

Related https://github.com/feross/standard/issues/182

My bad, I searched for deconstruction instead of destructuring.


Compatibility problems with optimistic locking / lock_version

Suppose you have a Widget with a lock_version column.
If you try to do widget.previous_version.save!, you'll get a ActiveRecord::StaleObjectError.
I'm not sure how to override this. Ideally what should happen is that the newly reified object should have the same staleness / lock properties as the original object, so that if widget is OK to save then widget.previous_version should be too (since it hasn't changed out from under you).
Any ideas for how to implement this?

The only workaround I have found to to change the lock_version attribute after reifying to the current lock_version and then saving the object. -Justin

I'm not sure I'd describe that as a workaround.  I haven't used optimistic locking personally, but based on the documentation it sounds like you're using it as intended; you want to update a record, so you must increment the lock_version.
I'm adding a note to the readme about this. (https://github.com/airblade/paper_trail/issues/550)

I did: model.lock_version += 1 if model.respond_to? :lock_version in version_concern.rb, line 125 just before returning 'model' -Walther

I think this would work in a single-threaded app, but without concurrency control would not be sufficient in a multi-threaded app.

I don't know if it makes sense to .. code that into PaperTrail .. -Ben

I agree.  If PaperTrail ever adds a high-level undo function, this is something we'll have to keep in mind.


No logs check

card

Codecov Report

Merging #12 (f0decd2) into develop (5dceff3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
+ Coverage    67.72%   67.74%   +0.02%
===========================================
  Files           71       71
  Lines         1580     1581       +1
  Branches       244      242       -2
===========================================
+ Hits          1070     1071       +1
  Misses         479      479
  Partials        31       31

Impacted Files
Coverage Δ

certego_saas/settings.py
83.33% <100.00%> (+0.98%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dceff3...f0decd2. Read the comment docs.


handle duplicate indexes when sorting df

A table with duplicate indexes caused the sorting function to crash.
E.g.
Ready Steady Store    3.614764
Big Box    0.000000
Alligator    1.760532
None of these    0.822068
Don't know    38.765192
Don't know    0.000000

reset index and update function.

Resolved by #488.


[Expression] change formatDatetime doc and add timex functions doc

formatDatetime can also take a number as a argument
Add doc for HasFullDate, HasValidTime, HasValidDuration, HasValidDate, HasValidTimeRange, HasValidDateRange, IsPresent

@emgrol - we probably should close this PR and take one in the docs repo?

@emgrol can you comment/ confirm that you have been able to pull this into your docs PR? We can close this PR pending your confirmation.

@vishwacsena You can close this PR now. I added the new/update content to PR 2112 in bot-docs-pr.


[MINOR] Some unit test code optimize

What is the purpose of the pull request
Optimize some code about ut
Brief change log
replace Arrays.asList with Collections.singletonList
replace new ArrayList().iterator() with Collections.emptyIterator()
Verify this pull request
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #2782 (ca38e68) into master (e926c1a) will decrease coverage by 41.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2782       +/-   ##
============================================
- Coverage     50.73%   9.37%   -41.36%
+ Complexity     3064      48     -3016
============================================
  Files           419      54      -365
  Lines         18797    1995    -16802
  Branches       1922     235     -1687
============================================
- Hits           9536     187     -9349
+ Misses         8485    1795     -6690
+ Partials        776      13      -763

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.37% <ø> (-60.06%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 Please review.

Project coverage is 52.26%. Comparing base (e926c1a) to head (ca38e68).
Report is 4324 commits behind head on master.

Files
Patch %
Lines

.../org/apache/hudi/util/RowDataToAvroConverters.java
45.79%
54 Missing and 4 partials :warning:

...pache/hudi/metadata/HoodieBackedTableMetadata.java
0.00%
54 Missing :warning:

...va/org/apache/hudi/metadata/BaseTableMetadata.java
0.00%
46 Missing :warning:

...java/org/apache/hudi/util/AvroSchemaConverter.java
22.41%
38 Missing and 7 partials :warning:

.../org/apache/hudi/streamer/HoodieFlinkStreamer.java
0.00%
42 Missing :warning:

...c/main/java/org/apache/hudi/util/StreamerUtil.java
51.28%
38 Missing :warning:

...rg/apache/hudi/streamer/HoodieFlinkStreamerV2.java
0.00%
37 Missing :warning:

...pache/hudi/common/table/HoodieTableMetaClient.java
52.83%
18 Missing and 7 partials :warning:

...pache/hudi/common/config/HoodieMetadataConfig.java
0.00%
24 Missing :warning:

.../org/apache/hudi/streamer/FlinkStreamerConfig.java
0.00%
23 Missing :warning:

... and 29 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2782      +/-   ##
============================================
+ Coverage     50.73%   52.26%   +1.53%
- Complexity     3064     3683     +619
============================================
  Files           419      484      +65
  Lines         18797    23094    +4297
  Branches       1922     2456     +534
============================================
+ Hits           9536    12071    +2535
- Misses         8485     9959    +1474
- Partials        776     1064     +288

Flag
Coverage Δ

hudicli
36.94% <16.21%> (-0.32%)
:arrow_down:

hudiclient
∅ <ø> (∅)

hudicommon
50.77% <21.81%> (-1.25%)
:arrow_down:

hudiflink
56.58% <30.33%> (+46.37%)
:arrow_up:

hudihadoopmr
33.44% <ø> (+0.38%)
:arrow_up:

hudisparkdatasource
71.33% <ø> (+5.42%)
:arrow_up:

hudisync
45.47% <ø> (-3.15%)
:arrow_down:

huditimelineservice
64.36% <ø> (-2.48%)
:arrow_down:

hudiutilities
69.77% <ø> (+0.34%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java
89.18% <100.00%> (ø)

...a/org/apache/hudi/cli/HoodieTableHeaderFields.java
0.00% <ø> (ø)

...pache/hudi/cli/commands/FileSystemViewCommand.java
82.45% <100.00%> (-0.16%)
:arrow_down:

...n/java/org/apache/hudi/cli/commands/SparkMain.java
6.72% <ø> (+0.28%)
:arrow_up:

.../hudi/common/model/DefaultHoodieRecordPayload.java
80.00% <ø> (+15.71%)
:arrow_up:

...apache/hudi/common/model/HoodieCleaningPolicy.java
100.00% <100.00%> (ø)

...che/hudi/common/table/log/HoodieLogFileReader.java
66.09% <100.00%> (-4.98%)
:arrow_down:

...che/hudi/common/table/timeline/HoodieTimeline.java
91.30% <ø> (ø)

...ache/hudi/common/table/timeline/TimelineUtils.java
62.71% <ø> (+7.15%)
:arrow_up:

...common/table/view/AbstractTableFileSystemView.java
86.07% <100.00%> (ø)

... and 54 more

... and 110 files with indirect coverage changes


[bug 1126030] Enable CORS for Heartbeat API.

r?

I think POST only is okay here, but fear it's missing something obvious.   We don't secretly allow PUT or want to support API access via GET right?  Dashboards go through some other mechanism?

@gregglind: That API endpoint only does POST right now. Unless you need something different, it only needs CORS support for POST.

This looks good to me. R+!

ba498e3 [bug 1126030] Enable CORS for Heartbeat API.

Thank you!


Use multiple threads for a single instance

Hi,CuEvm!
Thank you very much for your hard work in such a wonderful project. I have been learning a lot by studying your codebase. While learning the code, I came across a section that I am quite curious about.
template <class params>
__global__ void kernel_evm(
    cgbn_error_report_t *report,
    typename evm_t::evm_instances_t *instances)
{
    uint32_t instance = (blockIdx.x * blockDim.x + threadIdx.x) / params::TPI;
...
    if (instance >= instances->count)
        return;
...
    // setup evm
    evm_t evm (
        &(instances->transactions_data[instance]),
        ...
    evm.run(tmp_error_code);
}

https://github.com/sbip-sg/CuEVM/blob/main/src/evm.cuh#L3669
But I was curious as to why this code is dividing by params::TPI;. The reason why I am curious about this is that it seems to suggest that TPI number of threads will be handling the same instance, which does not appear to be very efficient. I'm wondering if this is a deliberate design choice on your part?
Thank you in advance for your time and for sharing your valuable knowledge with the community.
@cassc  @sdcioc

Thank you, I think I understand now, it seems to be due to CGBN.


Created kubernetes client from openapi spec

i didnt look too much at the k8s specific parts since i am not familiar with it

Looks like a good start, needs documentation

Added docs. @graemerocher - please review

@graemerocher - I also implemented the service account authentication in this PR: https://github.com/micronaut-projects/micronaut-kubernetes/pull/762/commits/124d9acf6b7c87ee739bda942d1c85f0770f7a09
Since the service account authentication required refactoring of the existing classes I thought it was better to have that in this PR instead of creating a new PR later and having breaking changes.


Fix config tests

As discussed, this fixes the remaining server tests. It isn't the cleanest implementation yet, but it's a start to put more of the codebase under test.

I think the issue in CI is that it starts the server with the default configuration and then starts it again before testing with the test configuration and fails. The fix it to remove nohup terraphim_server before cargo test.


test(extension): add tests for wallet creation flow via 'Add new wallet' feature (LW-10827)

Checklist

[X] JIRA - LW-10827
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes

Allure Report
allure-report-publisher generated test report!

smokeTests: ❌ test report for 84bca665

passed
failed
skipped
flaky
total
result

Total
32
1
0
0
33
❌


Update cl-environment-variables.md

Fix broken formatting, address a readability issue.

@corob-msft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Backend fixes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 55.332%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2838

Relevant Lines:
5129

💛  - Coveralls


Looks like on iOS Bluetooth Enabled is always false

hi @MikkoSteerpath , unfortunately, we don't track this in iOS automatically, only in Android. As a workaround, you have to track it manually, sorry for the inconvenience.

For all the supported default properties collected by properties: https://help.mixpanel.com/hc/en-us/articles/115004613766-Default-Properties-Collected-by-Mixpanel


feature/lf-4-license-administrator

Phases
MP
MM
MB
MR
JM
Total

ETA
0
20.8
0
0
0
0

Developing
0
6+2+7+7+7+7+2+7+3
0
0
0
0

Review
0
0
0
0
0
0

Total
-
-
-
-
-
0

ETA est.

0

ETA cust.
-
-
-
-
-
0

Problem description
The admin should be able to manage licenses by the License table like in the Clarin-DSpace: https://github.com/ufal/clarin-dspace/wiki/License-administration
License table operations:

Show all licenses
Define a new license
Edit license
Delete license

TO DO

[x] Create License admin menu
[x] Create redirection to the license page
[x] Create License object.ts
[x] Create License data service.ts
[x] Create License component as table with operations
[x] Create tests

Reported issues
Not-reported issues
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

send list in the Rest class
images to byte array

This feature was finished in the PR: https://github.com/dataquest-dev/dspace-angular/pull/104


Allow changing imported AnimationLibrary names in AnimationPlayer in the editor

Fixes #65625. Doesn't make anything else editable.

Is this the right way? Changes to externally imported resources are not saved and their editing should be prohibited. @SaracenOne @reduz
There are already several PRs to make them unique and editable instead, and I think those should be prioritized.

This is not a property on AnimationLibrary, it's a property of the AnimationPlayer, as explained in the linked issue. It belongs to the scene and does get saved.

I remember discussing with @reduz earlier that a scene might temporarily store key values, but the problem is that those changes are lost when the resource is re-imported.

I think that's referring to keys used by libraries to reference animations, not keys used by players to reference libraries. I was modifying these keys before this change happened, and I've been editing .tscn files in a text editor as a workaround since, and reimporting hasn't reset anything.

Ah, I may have been a bit misleading, by "key" do you mean the animation name? It is indeed a property of AnimationPlayer. I had it confused with Key in Animation Track.

Yeah, it saves as a dictionary with string keys and library values.

AnimationPlayer should be temporarily read-only when imported from outside, but after the scene is Make Local, library renaming in AnimationPlayer should be allowed.
In any case, I think that this PR needs to be reviewed by @reduz.

In what situation is a scene not editable, and how do you check?
Currently, imported scenes can be edited, the editor just displays some warnings that changes won't be saved.

So, I apologize for not looking over this sooner. Admittedly, the 'rules' around editable vs non-editable is a quite confusing, and it does require me to repeatedly test things to make sure they do indeed work as intended. Admittedly, a lot of my testing was based around animation libraries embeded into imported scenes rather than this workflow which I really learned about recently, and I think it's permissible to allow editing the names of the keys since the implicit result is, due to the fact that renaming the keys simply modifies the libraries property which is just key/value dictionary, it's not affecting the underlying libraries which have much stricter restrictions on what you can do with them.
I did run into an issue though where upon modifying the [global] key in one of my test scenes which reference a library embedded in another, things still continued to work as expected, the library was referenced as embedded in another scene, but upon investigating, still seemed everything was referenced properly. However, upon reverting the scene, the external library reference got broken. I think it's related to another bug though which I've raised a potential fix for here. https://github.com/godotengine/godot/pull/82750
As such, since that bug seems to be out of the scope of this PR, I'm going to tentitively approve this for merging. Apologies again for being so overdue.

Happy PR anniversary :tada: :sweat_smile:
Could you rebase the PR on latest master? There's no conflict so it's not strictly speaking needed, but since the commit is so old it would be good to refresh it so it shows up close to its merge commit.

Rebased.

Thanks!


Intro analysis - Building a method to explore the cooccurrences of skills.

[main part 2]

what skills tend to cooccur with each other
used to find complimentary skills
the mix of transversal and technical
mixes of transversal vs technical skills in occupations - which occupations are most mixed?

Awaiting Gueorguie's response on this

could add this as an intro in the analysis blog

list of top transversal skills


Add code change to 'Account.java'

Failed Tests:

testAddToBalance() from io.diffblue.corebanking.account.AccountDiffblueTest
expected20butwas0
testExecuteTransaction() from io.diffblue.corebanking.transaction.CashTransactionDiffblueTest
expectedount10Balance20Transactionstatbutwasount10Balance0Transactionstat

Tests run: 46, Failures: 2, Errors: 0, Skipped: 0


Add AV1 color space parsing in MP4 atom parser

This adds av1C parsing based on the AV1 bitstream specification: https://aomediacodec.github.io/av1-spec/av1-spec.pdf
This is needed to have correct color space when using hardware AV1 decoder.

Hi @haixia-meta. We take commits into the androidx:main branch. Could you please fix your pull request destination?

Hi @haixia-meta,
We take commits into the androidx/media main branch. Could you please fix your pull request destination?

Thanks for the suggestion. I have created a new pull request with main branch as destination:
https://github.com/androidx/media/pull/692


[VS Code] Service not available: DebuggerHostService

<!--
For Visual Studio problems/feedback, please use the Report

Hi, can you provide more info on how this problem happen? Which project type and what were you attempting to do ?

I’m going to close this as a duplicate of #683, so that we can consolidate the conversation. Thanks!


Add CO2e to job

Adds a basic version of a CO2e calculation per job.
Adds the elasticsearch reader as a submodule.
Currently, the CO2e is calculated by
(cumulative sum of CPU core usage time) * (co2e/kWh of the site at the execution time of the script) * (an average Watts per core)
This is to be refined using the starttime and endtime, as well as more granular co2e/kWh per site numbers. Furthermore the Watts/per core is to be adjusted to the cores used.

Variables were already implemented, see Email.


(PUP-10773) Reroute master settings to server

Master application settings will also be used on server application

@Dorin-Pleava @michaeltlombardi what happened with the force push, everything ok?

@joshcooper All OK, I wanted to debug the windows machine from github actions to find out why tests are failing on windows with ruby 2.5.

Ah, sounds good. I think the ruby 2.5 failure on Windows is present in main. I'll take a look at that today.

Backported this to master in #8456.


PostgreSQL support

Hi! Thanks for excellent work! I had closed issue for same purpose in main nextcloud repo:
https://github.com/nextcloud/server/issues/25232
But could you be kind to add postgresql support?

Sorry I am pretty busy at the moment and don't have time to do this.
I think replacing the mysqli statements with pg_connect/pg_query/... statements should work.
Going for PDO should work as well and would be the more universal solution.
Maybe try yourself and let me know whether there are any problems!


KAFKA 5609 - Added RollingFileAppender as per review comments

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@rnpridgeon @ewencp @cotedm @rhauch @guozhangwang
Guys very sorry, have some issues with Git repo and the branch having this fix got deleted. Hence have made the necessary requested changes and have to create new Pull Request.
This is reference to previous PR https://github.com/apache/kafka/pull/4687
Let me know if any further changes are needed.

Guys any update on this PR?

@guozhangwang can someone from Your team review and merge.


Fix theme groups not being loaded (#1981)

This should fix the issue identified in #1981 where theme group metadata is ignored when loading tokens from storage.

Hi @beauroberts, @six7
Do you know if this fix also applies to loading from Git specifically Azure DevOps. Our designers are using 1.37.1
We seem to be loosing Theme groups on each load so syncing / creating Figma variables break.
Example of theme -
  {
    "id": "1196a8c17e93c98178f2e8ec40dc1cd03940cd79",
    "name": "light",
    "selectedTokenSets": {
      "light": "enabled",
      "core": "source"
    },
    "$figmaStyleReferences": {},
    "group": "Color",
}

Regards,
Tarek


Generated tests can't be run in some Gradle projects

Description
Tests generated with UtBot sometimes can not be run via standard Intellij Idea mechanism.
To Reproduce

Create Gradle project without any custom settings
Add an arbitrary class and generate tests for it with JUnit5
Try to run generated tests

Expected behavior
Tests are successfully run in Intellij Idea
Actual behavior
Test events were not received error occurs
Additional context
This problem may be fixed manually adding the following code into build,gradle file:
test {
    useJUnit()
    useTestNG()
    useJUnitPlatform()
}

But it is not obvious how to do it programmatically.
The related question was sent to Intellij Support https://intellij-support.jetbrains.com/hc/en-us/community/posts/6168668718226-Enable-Gradle-native-support-programmatically

@denis-fokin let's discuss, what shall we do with it - JetBrains support says there is no good api solution to do it.

The suggested solution is just notifying the user about the conflict. Please see the details below.
In Gradle Test task only one runner is used. So only JUnit5 tests will be run for the following task definition:
test {
    useJUnit()
    useTestNG()
    useJUnitPlatform()
}

That can be managed with a) commenting-uncommenting runners; b) additional test task creation, like that:
test {
    useJUnitPlatform()
}

tasks.register('generatedTest', Test) {
    description = 'Runs UTBot generated tests.'
    group = 'verification'
    useTestNG()
}

check.dependsOn generatedTest

There are many possible Gradle tasks existing configurations. There is a potential risk to corrupt them if changing that straightly.
So the suggested solution is just notifying the user about the conflict.
"There are several test frameworks in the project. There are several configuration. Please refer to documentation:"
And suggesting them a link to the documentation - describing how to resolve this conflict.
Gradle - https://docs.gradle.org/current/userguide/java_testing.html#sec:configuring_java_integration_tests
Maven - https://maven.apache.org/surefire/maven-surefire-plugin/examples/providers.html
IDEA - https://www.jetbrains.com/help/idea/run-debug-configuration.html#compound-configs


Filter users by email

Is your feature request related to a problem? Please describe.
In a tenant, we may want to filter the accounts by their emails. (Ex: on the Zenika tenant, we only want<EMAIL_ADDRESS>users)
Describe the solution you'd like

[x] Add a field in the configuration for an array of string
[x] Add an input in the Admin Settings page to set the domain(s) to filter
[x] Check the user's email in the backend auth middleware on every query

Implemented by #179


equal ss to ß in the searchfield

Hi
and thanks for this absolutely awesome editor!
people in germani use the "double s"  > ß
people in switzerland and i also believe austrio don't.
so everytime someone from these countries tries to find "fussball feld" (soccer field)
they won't find it because it's written as "Fußball fled"
so if you could making appear while typing "fuss" like it does when i search for "soccer" would make lots of peoples life easier :)
thanks

Hadn't thought of that before but it makes sense.  I agree we should make our preset search ß-tolerant.

@1ec5 Would you consider it safe to just run both the search fragment and the comparison string through a general purpose string folding library like fold-to-ascii?

@1ec5 Would you consider it safe to just run both the search fragment and the comparison string through a general purpose string folding library like fold-to-ascii?

Would this work with CJK languages where characters can't really be converted to ascii? I can't get the example JS working with fold-to-ascii, so I can't check myself

Digging into this a bit more, it looks like we'd need to compare both original and folded versions, otherwise it would mess up matching unicode fragments like 中國.
hehe @pnorman beat me to it by 30 seconds

Update:  looks like node-diacritics is less greedy and ignores unrecognized unicode characters, rather than fold-to-ascii which removes unrecognized characters.
bad (fold-to-ascii):
> console.log(asciiFolder.fold('Happy ßirthday'));
'Happy ssirthday'
> console.log(asciiFolder.fold('中华人民共和国'));
''

good (node-diacritics):
> console.log(removeDiacritics('Happy ßirthday'));
'Happy ssirthday'
> console.log(removeDiacritics('中华人民共和国'));
'中华人民共和国'

Currently, the Vietnamese localization is working around this issue by including case-folded terms (“ho” for “hồ”) as synonyms for every preset, roughly doubling the size of the localization. Actually, to properly handle typeahead search, I’d have to add even more synonyms for situations where the user has entered only some of the diacritics (“đuong”, “đương”, “đuòng”, “dường”, etc. for “đường”), given the way most popular Vietnamese IMEs work.

Would you consider it safe to just run both the search fragment and the comparison string through a general purpose string folding library like fold-to-ascii?

It would be safe for some languages. However, for Vietnamese, it would have to be a fallback strategy with less weight than the normal search. Otherwise, you’d get unexpected results for many searches, such as “hố lửa” (fire pit) over “hồ bơi” (swimming pool) for “hồ” and “cho thuê xe” (car rental) over “công viên dành cho chó” (dog park) for “chó”. Ideally, localizations would be able to provide their own case folding logic.


contrib: migrate openaire sandbox to keycloak

closes https://github.com/inveniosoftware/invenio-oauthclient/issues/296

blocked by https://zenodo-sentry.web.cern.ch/sentry/zenodo-rdm/issues/19978243/?query=is%3Aunresolved needs debugging

tests are failing on flask babelex

It's been quite a while since I first wrote the Keycloak integration, and it was my first real contribution to InvenioRDM...
So I can't really tell with certainty anymore what the precise thoughts were behind it all :sweat_smile:
But IIRC, I just tried to save a few unnecessary network requests and reduce the attack surface.
The user info endpoint probably was just added as a kind of "might as well just try that" in case something goes wrong with the initially passed token (e.g. if the encryption was invalid, ...).


Request to decode media data denied due to throttling (Android Lollipop 5.1.1 with ColorOS)

08-29 17:52:45.204 22153-22153/oneminute.change.app E/cr_MediaThrottler: Request to decode media data denied due to throttling.
08-29 17:52:45.964 22153-22153/oneminute.change.app E/cr_MediaThrottler: Request to decode media data denied due to throttling.

I am using Ionic v1
I have a video page that automatically plays on $ionicView.enter.
If I click the back button without finishing the video, then navigate again to video page (start again)
(at first back, the video still plays)
But on the second back, then navigate again to video page, I got the "throttling" error
I have no problem with Android 4.4, 5.0, 5.1.1 without ColorOS, 7.0
It just occur on Android 5.1.1 with ColorOS like OPPO unit
Any help is appreciated. TIA
This is my config.xml
<plugin name="cordova-plugin-crosswalk-webview" spec="^2.3.0">
        <variable name="XWALK_VERSION" value="23+" />
        <variable name="XWALK_LITEVERSION" value="xwalk_core_library_canary:17+" />
        <variable name="XWALK_COMMANDLINE" value="--disable-pull-to-refresh-effect" />
        <variable name="XWALK_MODE" value="embedded" />
        <variable name="XWALK_MULTIPLEAPK" value="true" />
    </plugin>

have you resolved this issue?

@qiaofei Unfortunately, not yet sir.

@neilmaledev  have you resolved this issue?

@liuwenping828 I'll put my solution here once I resolved the issue. As of now I'm on a vacation.


ImageAllowRule - Deploying apps using image-ids that were already allowed , results in user being prompted to allow images (resulting in duplicate imageallowrules created)

acorn version v0.7.0-alpha1-148-g7909ed41+7909ed41
Steps to reproduce the problem:
Install acorn with --features image-allow-rules=true
Scenario1:
Deploy app from Acornfile.
When prompted for allowing images , select "yes" and allow for app to get deployed successfully.( Do you want to allow this app to use this (POTENTIALLY DANGEROUS) image? yes (this ID or SHA only))
acorn apps
mytest1            89f49874572c   1         1            13m ago     http://myweb1-mytest1-4984b863.local.oss-acorn.io => myweb1:80            OK

Deploy app using this image-id
acorn run 89f49874572c
  •  WARNING:  This application would like to use the image '89f49874572c03b67c57be1433e731ab9af42c9688d97610d6d1fe569a2ce69b'.
                 This image is not trusted by any image allow rules in this project.
                 This could be VERY DANGEROUS to the cluster if you do not trust this
                 application. If you are unsure say no.

? Do you want to allow this app to use this (POTENTIALLY DANGEROUS) image?  [Use arrows to move, type to filter]
> NO
  yes (this ID or SHA only)

Expected Behavior:
We should be allowed to deploy this app without prompting user since this is already an allowed image.
Scenario2:
If you choose "yes" , app deployment succeed .
This result in duplicate imageAllowRules created for the same imageId.
sangeethahariharan@Sangeethas-MacBook-Pro example1 % kubectl describe ImageAllowRules -n new3
Name:         bold-rain
Namespace:    new3
Labels:       <none>
Annotations:  <none>
API Version:  api.acorn.io/v1
Images:
  89f49874572c03b67c57be1433e731ab9af42c9688d97610d6d1fe569a2ce69b
Kind:  ImageAllowRule
Metadata:
  Creation Timestamp:  2023-06-05T19:44:57Z
  Generation:          1
  Resource Version:    1295125
  UID:                 d13a4ab2-ac05-4537-8820-092690ac825b-p
Signatures:
Events:  <none>

Name:         autumn-wave
Namespace:    new3
Labels:       <none>
Annotations:  <none>
API Version:  api.acorn.io/v1
Images:
  89f49874572c03b67c57be1433e731ab9af42c9688d97610d6d1fe569a2ce69b
Kind:  ImageAllowRule
Metadata:
  Creation Timestamp:  2023-06-05T19:52:59Z
  Generation:          1
  Resource Version:    1295500
  UID:                 0003929d-c6a3-4b14-8bb5-e7c9e0af6e1d-p
Signatures:
Events:  <none>

Name:         red-frog
Namespace:    new3
Labels:       <none>
Annotations:  <none>
API Version:  api.acorn.io/v1
Images:
  89f49874572c03b67c57be1433e731ab9af42c9688d97610d6d1fe569a2ce69b
Kind:  ImageAllowRule
Metadata:
  Creation Timestamp:  2023-06-05T20:01:12Z
  Generation:          1
  Resource Version:    1295752
  UID:                 e3ef9af8-f677-4a1e-ace6-656e80645ceb-p
Signatures:
Events:  <none>

I don't want the imageAllowRules feature to be blockers. Moving out of of v0.7

Moving this issue back to Engineering  - https://github.com/acorn-io/acorn/issues/1777#issuecomment-1588177668

Tested with acorn version v0.7.1-10-g54c7bbf4+54c7bbf4
Enable ImageAllowRule feature.
Deploy app  - app1 from Acornfile and  choose "yes" to allow image.
Once app is deployed successfully , deploy another app using the image-id of app1.
App deployment does not prompt user to allow for images and app deployment succeeds.


client: emit userstate on sub and resub event independent of the message

As mentioned in #240 userstate is never returned if there is no message in re-subscription or it is the initial subscription. But as the docs suggest this behaviour should be independent of the message.
For example: I should still be able to display badges of the subscriber even if there is no message provided. Or I might need to use id of the subscriber regardless of the message.

This is great. Can you update the tests to reflect the changes to Twitch's sub event? Specifically, this test will need to be updated.


[HW]

Name: Mahesh Kumar
Email<EMAIL_ADDRESS>Linkedin Profile: linkedin.com/in/mahesh-kumar-15a943219
Attach the homework screenshots below for both step II and step III:

Hey Mahesh Kumar, great job! Congrats! Here is your badge! https://api.badgr.io/public/assertions/qqi5pG1iQimt_zTSOQsuBQ


Upgrading to v10.0.2 from v8.0.3 causes different serialization data to be generated that the deserializer cannot deserialize

We are in the process of upgrading from v8.0.3 to v10.0.2.
In the upgrade process we have hit an issue where the serializer is outputting a different serialized data stream. The actual data and types are identical, but the v10 serializer is outputting more $id fields than v8. This causes an exception to be thrown in the deserialization of:
Cannot preserve reference to array or readonly list, or list created from a non-default constructor
Under v8 the serialization and deserialization works as expected. Once updating to v10, then the deserialization of the JSON fails with an exception.
When v8.0.3 is used to serialize the data we get:
{
    "$id": "1",
    "$type": "HandleResult, Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
    "ReturnData": {
        "$id": "2",
        "$type": "Result`1[[DataModel, Models, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]], Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
        "NumberOfPages": 0,
        "Results": {
            "$type": "DataModel[], Models, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
            "$values": [
                {
                    "$id": "3",
                    "$type": "DataModel, Models, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
                    "InstanceA": 33,
                    "InstanceB": 2,
                    "InstanceC": 41
                }
            ]
        }
    },
    "Msg": {
        "$type": "MessageCollection, Structure, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
        "AllMessages": {
            "$type": "System.Collections.Generic.List`1[[Message, Contracts, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]], mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089",
            "$values": []
        },
        "HasErrors": false,
        "HasExceptions": false,
        "HasWarnings": false
    }
}

When v10.0.2 is used to serialize the data we get:
{
    "$id": "1",
    "$type": "HandleResult, Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
    "ReturnData": {
        "$id": "2",
        "$type": "Result`1[[DataModel, Models, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]], Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
        "NumberOfPages": 0,
        "Results": {
            "$id": "3",
            "$type": "DataModel[], Models, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
            "$values": [
                {
                    "$id": "4",
                    "$type": "DataModel, Models, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
                    "InstanceA": 33,
                    "InstanceB": 2,
                    "InstanceC": 41
                }
            ]
        }
    },
    "Msg": {
        "$id": "5",
        "$type": "MessageCollection, Structure, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
        "AllMessages": {
            "$type": "System.Collections.Generic.List`1[[Message, Contracts, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]], mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089",
            "$values": []
        },
        "HasErrors": false,
        "HasExceptions": false,
        "HasWarnings": false
    }
}

The data is identical except that the Results section in v10 gets and $Id whereas in v8 it does not. The Result field is an IEnumerable<T> that is part of a generic WebAPI response structure. It is populated with:
query.Result = new QueryResult<DataModel>(new [] { dataModel });

If we change the declaration to:
query.Result = new QueryResult<DataModel>(new List<DataModel> { dataModel });

Then the deserialization works as expected (i.e. no exception is thrown).
The DataModel is simple:
    public class DataModel
    {
        public DataModel(int instanceA, int instanceB, int instanceC)
        {
            this.InstanceA = instanceA;
            this.InstanceB = instanceB;
            this.InstanceC = instanceC;
        }

        public int InstanceA { get; set; }
        public int InstanceB { get; set; }
        public int InstanceC { get; set; }
    }

Our settings for JSON:
var settings = new JsonSerializerSettings
{
	ConstructorHandling            = Newtonsoft.Json.ConstructorHandling.Default,
	ContractResolver               = new Newtonsoft.Json.Serialization.DefaultContractResolver(),
	TypeNameHandling               = Newtonsoft.Json.TypeNameHandling.All,
	//TypeNameAssemblyFormatHandling = Newtonsoft.Json.TypeNameAssemblyFormatHandling.Full,
	TypeNameAssemblyFormat         = FormatterAssemblyStyle.Full,
	Formatting                     = Newtonsoft.Json.Formatting.None,
	NullValueHandling              = Newtonsoft.Json.NullValueHandling.Include,
	ReferenceLoopHandling          = Newtonsoft.Json.ReferenceLoopHandling.Serialize,
	PreserveReferencesHandling     = Newtonsoft.Json.PreserveReferencesHandling.All,
	DateTimeZoneHandling           = Newtonsoft.Json.DateTimeZoneHandling.Local,
	DateFormatHandling             = Newtonsoft.Json.DateFormatHandling.IsoDateFormat
};

If we attempt to deserialize the v10 JSON with the v8 deserializer, it also throws an exception.
Also if I just remove "$id": "3" from the v10 serialization the deserialization works correctly.
Is this a regression in v10, or there another option/process to follow to serialize array's in v10?
Thanks - Richard.

I should add as well that we upgraded to v9.0.1 and v9 has the same serialization output as v8.

I need the HandleResult class as well to be able to try and recreate your issue.

The HandleResult class is part of a rather complex infrastructure chain.
I have created a stripped down gist:
https://gist.github.com/RichardShephard/c54f6410e292a37a4896fd51b857a621
This also attempts to mimic how we are using the serializer/deserializer as well.
This does not output exactly the same data as above, but it is pretty close to version 10:
{
    "$id": "1",
    "$type": "Json_Net_Testing.HandleResult, Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
    "ReturnData": {
        "$id": "2",
        "$type": "Json_Net_Testing.Result`1[[Json_Net_Testing.DataModel, Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]], Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
        "NumberOfPages": 0,
        "Results": {
            "$id": "3",
            "$type": "Json_Net_Testing.DataModel[], Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
            "$values": [
                {
                    "$id": "4",
                    "$type": "Json_Net_Testing.DataModel, Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
                    "InstanceA": 1,
                    "InstanceB": 2,
                    "InstanceC": 3
                }
            ]
        }
    },
    "Msg": {
        "$type": "Json_Net_Testing.MessageCollection, Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null",
        "HasErrors": false,
        "HasWarnings": false,
        "HasExceptions": false,
        "AllMessages": {
            "$type": "System.Collections.Generic.List`1[[Json_Net_Testing.Message, Json Net Testing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]], mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089",
            "$values": []
        }
    }
}

For some reason under v10 the Msg object is not getting a $id field as expected in the real world case.
The exception thrown under v10 for the gist is:
Cannot preserve reference to array or readonly list, or list created from a non-default constructor: Json_Net_Testing.DataModel[]. Path 'ReturnData.Results.$values', line 1, position 522.
Using v9 the program completes successfully.

Another bug fix caused your issue. Previously Results would have been considered non-writable and so no reference would be added to it, but 10 recognized parameters from constructors as writable.
public class Result<T> : IResult<T>
{
    [JsonConstructor]
    public Result(IEnumerable<T> results)
    {
        this.Results = results;
    }

    public int NumberOfPages { get; set; }
    public IEnumerable<T> Results { get; }
}

Your value of Results is an array which can't have its reference preserved. Change the value you give to it to a List<T> instead of an array.


iptables: fix v6 on shortcircuit internal interfaces

Signed-off-by: Yuchen Dai<EMAIL_ADDRESS>Fix #19940

@lambdai: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
054f8518df7b146523740f2f7d8e2a4e8d93385a
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thank you @rlenglet
Great to see you haunting :)