queries on APK architecture and roadmap

Description:
I have a few query on APK, especially because I have next week a few customer visits where I should present APK:

scalability: how can APK scale horizontally? I need to increase the number of replicas of envoy pods? is there anything automatic or can I control it?
scalability: how can I scale 'statically' deployment X APIs in one instance and Y APIs in another instance? I have to use 2 separate installations? or within the same, sharing the adapter for 2 separate envoy/enforcer pair
roadmap: (slide 12) what do you mean for "Gateway environment support (to support virtual environment)"
roadmap: (slide  12) would you mind clarifying "Semantic API versioning support for APIs"
in general: my understanding is that the next version will have the integration with APIM 4.3 CP, while the next a dedicated CP (initially APIs only, later with UI). Is it correct? Will next versions keep APIM CP support?

link to the roadmap I have: https://docs.google.com/presentation/d/1seMvlE3bckAkCRd6jzD2gzQgXmEgFAe7D3rddi1tcTw/edit#slide=id.g262cd9fa7fc_0_22
Suggested Labels:
Query

#1 - please refer to - https://apk.docs.wso2.com/en/latest/setup/configure-hpa/
#2 - We have concept of API partitioning where we allocate APIs for different partition based on the partition availability. But its mostly used when there are more than 1000 APIs and creation is dynamic. If this is a dev/prod kind of envirionments or multiple departments our recommendation is to have separate deployments. If we have multiple APK installations then deploying to them also an option here.
#3 - Its a Choreo specific feature which allows to deploy APIs for multiple virtual host addresses within same API gateway runtime.
#4 - Please refer to email with heading "Semantic Versioning Based Intelligent Routing for APIs for APK"
#5 - We hope to have same control plane for both APIM and APK. So we will evolve APIM control plane to make it more cloud native and be default CP for both APIM and APK gateways.
Hope this clarifies your questions.

perfect thank you


Windows + CMD hotkey

The hotkey for rotating (Command aka. Windows key) isn't optimal for Windows because if you release the key the start menu pops up.
Possible Solutions

Use CTRL instead of CMD

Thank you for reporting. I will look into this issue.
This lib was extracted from an OS X electron app, therefore Windows support can be buggy


Improve migration from previous versions (Chart history view period)

Default 10 days should be set only for clean installs. Other users should get 1-3 days according to their previous settings

QA passed


[FLINK-10135] The JobManager does not report the cluster-level metrics

What is the purpose of the change
This pull request fixed job manager does not report the cluster-level metrics
Brief change log

Fixed job manager does not report the cluster-level metrics

Verifying this change
This change is already covered by existing tests, such as TestingRestfulGateway#requestMultipleJobsOverview.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@GJL @tillrohrmann @dawidwys  can you review this PR?

@StefanRRichter thanks for your review suggestion, I have refactored the PR. I have tried to test requestOverviewForAllJobs in DispatcherTest, but always throw akka timeout :
Caused by: akka.pattern.AskTimeoutException: Ask timed out on [Actor[akka://flink/user/dispatcher_testJobRecovery#-798214439]] after [10000 ms]. Sender[null] sent message of type "org.apache.flink.runtime.rpc.messages.LocalFencedMessage".

I replace the method with requestClusterOverview, the result is the same exception. So I do not know how to test it. It seems there is not a case can be refer to.

@StefanRRichter I have tried to add a test case for reporting job manager metrics, can you review this?

@zentol updated the PR.

@StefanRRichter can you review it?

@zentol I have changed the test case, please review it again, thanks.

@zentol Thanks for your suggestion, I have updated the implementation, please review it again.

This looks a lot better, the majority of my comments are for minor things, but we've now run into a concurrency issue. All RpcEndpoints (i.e. DIspatcher, ResourceManager, etc) assume to run in a single thread (the "main-thread"), but metrics are accessed by another one. We have to either make sure that all operations are safe in this scenario, or somehow (@tillrohrmann?) defer the access to the main-thread.

@zentol I have already adopted your previous review suggestions. Does it still need other modifications?

I believe you haven't addressed my comments regarding the  JobManagerMetricsITCase.

oh wait you did, Ill take another look.

@zentol thanks, updated.

There is a merge conflict with ResourceManager.

@tillrohrmann fixed the conflicts.

I saw some errors not related to this PR change, from flink-s3-fs-hadoop. cc @tillrohrmann  and @zentol

There is currently a problem with the HadoopS3RecoverableWriterExceptionTest. @kl0u is fixing it. Once this is done, please rebase onto the latest master.

@tillrohrmann rebased and all checks have passed.

Ill merge this on monday and start looking into backporting this to 1.5 and 1.6.


The bg-size value must immediately follow position for shorthand background property

In the Pricing section's cards, the background images are given invalid CSS, causing the cards to be unreadable, since the background images are not displayed.
diff --git a/Section 006 - Project 3 - photoX/Lecture 011 - Footer/style.css b/Section 006 - Project 3 - photoX/Lecture 011 - Footer/style.css
index 7298514..c12e583 100644
--- a/Section 006 - Project 3 - photoX/Lecture 011 - Footer/style.css
+++ b/Section 006 - Project 3 - photoX/Lecture 011 - Footer/style.css
@@ -184,7 +184,7 @@ header {

 /* pricing */
 .card-1, .card-2, .card-3 {
-  background: linear-gradient(rgba(0, 0, 0, .6), rgba(0, 0, 0, .5)), url(images/pricing-card-bg.jpeg) center no-repeat /cover;
+  background: linear-gradient(rgba(0, 0, 0, .6), rgba(0, 0, 0, .5)), url(images/pricing-card-bg.jpeg) center/cover no-repeat;
   box-shadow: 7px 18px 50px #555;
   max-width: 400px;
 }

See the CSS standard for details (or the Mozilla documentation).

Here's what it looks like with the broken rule:

... and here it is fixed:


LICENSE

can you please add a standard BSD license.

Done ! https://github.com/fmassa/object-detection.torch/commit/5bb8368fe922cb2359a7a53ff2ff6be2e43ae9d7

thanks francisco!


Question: How do I avoid overfitting with ELMo finetuning

I finetune ELMo on our domain data which is 41,581,796 sentences and reach a train perplexity around 50 but validation perplexity is still high (around 105). How do I avoid overfitting while finetuning ELMo model?
I don't have enough resources to train our own ELMo models.

This is a very large dataset and would be difficult to overfit.  If you are concerned about overfitting, then I suggest evaluating on a held out set every epoch to determine when to stop tuning.
Also note that the training perplexity isn't directly comparable to test perplexity due to the sampled softmax, and will typically be much lower (during training, perplexity is computed with only a small set of negative samples instead of using the full vocabulary). To check for overfitting, you could take a small piece of your training set and check perplexity of that in testing mode (without sampling or dropout).


Patient who has a withdraw intention is loosing TP number in the trial participants list table

Have a look at TP4
Before withdraw intention

After withdraw intention

However, the TP number is till visible in the Consents page.

all good

This issue reappeared today only I was working with multiple consents


Update config for docsearch plugin

Reference:
https://v2.vuepress.vuejs.org/reference/plugin/docsearch.html#translations
https://docsearch.algolia.com/docs/api/#translations

Great job!

There is a question, I am translating #505 , where should I put the Fly entry in the menu? Just wait for this PR merged?

I suggest you put it in the same place as English and Indonesian do it right now, after Heroku and before GCF. Someone will deal with the merge conflicts for all languages at the same time.

Required sync with main again due to changes in config.ts merged @CikiMomogi

Please wait until https://github.com/grammyjs/website/pull/533 is merged.

Bot features link was missing, it's in other PR that probably will be merged before

Yes. That's something I'm aware of. That is why I am temporarily closing this PQ and will integrate them when they are ready.


TB3 isn't rendered correctly in Gazebo

Bug report

operating system: Ubuntu 20.04
ROS2 Galactic (binaries)

Steps to reproduce:

install aws-robomaker-small-warehouse-world and nav2-simple-commander ROS2 Galactic packages (binaries)
ros2 launch nav2_simple_commander inspection_demo_launch.py

Part of my .bashrc file:
source ~/ros2_ws/install/setup.bash
export TURTLEBOT3_MODEL=waffle
export GAZEBO_MODEL_PATH=$GAZEBO_MODEL_PATH:/home/ljaniec/ros2_ws/install/aws_robomaker_small_warehouse_world/share/aws_robomaker_small_warehouse_world/worlds:/home/ljaniec/ros2_ws/install/aws_robomaker_small_warehouse_world/share/aws_robomaker_small_warehouse_world/models:/home/ljaniec/ros2_ws/install/neo_simulation2/share/neo_simulation2/robots:/home/ljaniec/ros2_ws/install/neo_simulation2/share/neo_simulation2/models:/opt/ros/galactic/share/turtlebot3_gazebo/models:/home/ljaniec/.gazebo/models

Expected behavior
The simulation with one visible TB3 rendered and Nav2 stack + demo script start.
Actual behavior
The simulation doesn't have correctly rendered robot (screens below). Autonomy demo still works (robot moves, LiDAR can be seen etc).

Additional information
What I tried:

reinstall Gazebo and Nav2 packages

I have found a similar bug there

I checked URDF like there and it didn't show problems

this bug shows in this package too (nav2_rosdevday_2021, there ), one with MP 400 (the robot is invisible, in "Collisions" view in Gazebo too - unlike there with TB3) - maybe it is something connected with these meshfile changes mentioned in the first link above?

Am I doing something wrong there? Standard simulation (1 TB3 in TurtleWorld) is working fine - robot model loads etc.
The discrepancy between simulations with the same model (AFAIK) is surprising to me.

Hi @ljaniec
The turtlebot3_simulations package became independent from the turtlebot3 package and had to keep separate modeling files.
The modeling files in the simulations package has been extremely simplified in order to minimize the size of the package which had been requested from several developers.
In order to use more realistic design of the robot, you may use the mesh files in the turtlebot3_description package.
https://github.com/ROBOTIS-GIT/turtlebot3/tree/master/turtlebot3_description/meshes
I'll try to come up with a solution that can easily switch the modeling files without increasing the size of the default package.
Please let me know if you have any thoughts for this.
Thanks!

Hello,
I prepared a small set of commands to show, what I think the problem is.
TB3 case 1
Start Gazebo simulation with empty world
ros2 launch gazebo_ros gazebo.launch.py
Add TB3 SDF model to Gazebo (package turtlebot3_gazebo)
ros2 run gazebo_ros spawn_entity.py -file /opt/ros/galactic/share/turtlebot3_gazebo/models/turtlebot3_waffle/model.sdf -entity robot01
It spawns TB3 Waffle normally (visible model and LiDAR).
TB3 case 2-1
Start Gazebo simulation with empty world
ros2 launch gazebo_ros gazebo.launch.py
Add TB3 URDF model to Gazebo (package nav2_bringup)
ros2 run gazebo_ros spawn_entity.py -file /opt/ros/galactic/share/nav2_bringup/urdf/turtlebot3_waffle.urdf -entity robot01
Surprisingly, it spawns invisible TB3 Waffle. It is visible only in the 'Collision' view in Gazebo. No LiDAR too.
TB3 case 2-2
Start Gazebo simulation with empty world
ros2 launch gazebo_ros gazebo.launch.py
Generate TB3 SDF model from URDF
gz sdf -p turtlebot3_waffle.urdf > turtlebot3_waffle.sdf
Add TB3 SDF model to Gazebo (from package nav2_bringup)
ros2 run gazebo_ros spawn_entity.py -file ~/Desktop/turtlebot3_waffle.sdf -entity robot01
TB3 is invisible (but it's there, after launching 'Collision' view in Gazebo).
MP400 case
Start Gazebo simulation with empty world
ros2 launch gazebo_ros gazebo.launch.py
Add MP400 URDF model to Gazebo
ros2 run gazebo_ros spawn_entity.py -file ~/mp_400/mp_400.urdf -entity robot01
Robot is invisible, there are only blobs in the air and a LiDAR.
Generate SDF model from URDF
gz sdf -p mp_400.urdf > mp_400.sdf
Add MP400 SDF model to Gazebo
ros2 run gazebo_ros spawn_entity.py -file ~/mp_400/mp_400.sdf -entity robot01
Robot is again invisible, there are only blobs in the air and a LiDAR.
What is the problem there and how do I fix it?
Relevant issues and links I have found:

https://github.com/ros-planning/navigation2/issues/2157 - but it's is solved - there is /opt/ros/galactic/share/turtlebot3_gazebo already
https://answers.gazebosim.org//question/26073/cannot-spawn-urdf-into-gazebo-using-ros2/ and https://answers.gazebosim.org//question/2282/convert-urdf-to-sdf-or-load-urdf/ - these two
https://github.com/ros-simulation/gazebo_ros_pkgs/pull/1284 - it looks like this could be the problem addressed it this (unmerged yet) PR ("[gazebo_ros_factory]: Resolve package:// urls")

I have all used files there:

MP400 from Neobotix, branch galactic
TB3 from Nav2 repository, branch galactic

Relevant issue: https://github.com/ros-simulation/gazebo_ros_pkgs/issues/1272#issuecomment-857513366


api changes for UI

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho what steps do we need to do in order to get this revised and merged? We really should be freezing our data interfaces soon.

Closing, as we went forward with frontend plugin design


Enable highlighting for quickfix line & fix search

Hi @ishan9299, thank you for your work on this excellent port of modus themes.
While using this theme I noticed that the QuickFixLine syntax hadn't been enabled, specifically when doing a project wide search, the highlighting seemed a bit off. Notice the before/after screenshots below:
Before:

After (this change):

I thought I'd open a PR for this (although it's a pretty minor change :) )

Thanks !


Musicgen ONNX export (text-conditional only)

Exports Musicgen conditioned by a text prompt.
optimum-cli export onnx --model facebook/musicgen-small musicgen_onnx &> export.log

If we want to condition with audio, it is more tricky and we first need to be able to export EncodecModel.encode which requires a combination of jit.script/jit.trace as it has some unrollable loops, unfortuantely.
Only KV cache export is tested & supported.
The following subcomponents are exported:

text_encoder.onnx: corresponds to the text encoder part in https://github.com/huggingface/transformers/blob/v4.39.1/src/transformers/models/musicgen/modeling_musicgen.py#L1457.
audio_encoder_decode.onnx: corresponds to the Encodec audio encoder part in https://github.com/huggingface/transformers/blob/v4.39.1/src/transformers/models/musicgen/modeling_musicgen.py#L2472-L2480.
decoder_model.onnx: The Musicgen decoder, without past key values input, and computing cross attention.
decoder_with_past_model.onnx: The Musicgen decoder, with past_key_values input (KV cache filled), not computing cross attention.
decoder_model_merged.onnx: The two previous models fused in one, to avoid duplicating weights. A boolean input use_cache_branch allows to select the branch to use. In the first forward pass where the KV cache is empty, dummy past key values inputs need to be passed and are ignored with use_cache_branch=False.

Partially fixes https://github.com/huggingface/optimum/issues/1297
⚠ Depends on https://github.com/huggingface/transformers/pull/29913, please check out on this branch for now

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Need https://github.com/huggingface/optimum/pull/1780 for the CI

Will be great to do it with Musicgen Melody as well (where music conditioning is different, so could maybe work)

@ylacombe What are the main differences?

I've been testing this out in transformers.js and will report back when the output matches!

@xenova I need to add the attention_mask input in ONNX


Optional chaining support

Spec:
https://github.com/estree/estree/pull/204/files

https://github.com/acornjs/acorn/pull/891 merged, will back to this PR this weekend

Updated this PR

@michaelficarra :eyes:

@michaelficarra should we support node@4 in travis? I added chai-exclude package to deep compare  AST-trees without start and end properties, but looks like it doesn't support node@4.
I can remove node@4 from travis.yml and add node@10 instead

Ok. I removed node@4 from travis.yml file and added node@10 instead.
Also, I updated engines section with >=6.0 value.
Node 4 is few years as deprecated, so I think it's the time to forget its.

@michaelficarra also i created PR to the estraverse to support ChainExpression node.
https://github.com/estools/estraverse/pull/113
So it is best to merge estravserse PR first and after that, I'll update this PR with the use of Syntax.ChainExpression.

Any news?

Any ETA when this PR can be reviewed?

Hi guys! This PR is very important for me and many people in the world! Please, merge it

I upvote for fast merge

@Constellation can you check and merge this?

@michaelficarra re-ping

@michaelficarra re-ping

i support this re-ping

@michaelficarra please, re-check this

@michaelficarra re-ping

@michaelficarra re-ping

@michaelficarra ping

Still waiting...

@michaelficarra ping

@michaelficarra please check this. More than a month I'm waiting for your approval.

@michaelficarra it is insulting the feelings of contributors!

@michaelficarra !!!

I hope if this pr merged, it takes much less time to merge the PR with Nullish Coalescing support.
https://github.com/estools/escodegen/pull/417

@michaelficarra ping

@michaelficarra i really think that if you spend 5 minutes to re-check this PR with ALL your requested changes and merge it - all users who are using this package will happy.
 That way you won't be blocked on getting these PRs merged.

The fork is the last option in cases like that. I'll still try to avoid it.

Why try to avoid it? It’s a fairly easy thing to do even temporarily. It’s also very liberating to not be dependent on others.

@michaelficarra ping

@sanex3339 it's true - it is very easy to fork a project.
I guess you think its hard because you think you need to publish it in NPM, but in fact, you can declare your GitHub fork URL as a dependency in package.json. i know how to make it right. If you want you can contact me in telegram @bowzee - I'll help you with that.

@sanex3339 tests appear not to cover optional call (a?.())

@sanex3339 tests appear not to cover optional call (a?.())
https://github.com/estools/escodegen/pull/412/commits/f23abd632b16c610952af768d3060ab229309cac

Now looks like it's ok

@sanex3339 It seems like there ought to be tests that mix optional calls with member access  - that is, (a?.b)(), a?.b(), a?.().b, (a?.()).b, (a?.b.c)(), a?.b.c(), a.b?.().c, (a.b?.()).c, etc.

@bakkot Added more tests and fixed logic. Not sure that i did it right, but all tests are passed.

Simplified logic

With regards to the actual implementation, it seems like it would be better to introduce a new precedence level for optional chains just below Call, and have ChainExpression parenthesize its result at that precedence - something along the lines of
Precedence = {
        [...]
        Postfix: 15,
        OptionalChain: 16,
        Call: 17,
        New: 18,
        TaggedTemplate: 19,
        Member: 20,
        Primary: 21
}

[...]

        ChainExpression: function (expr, precedence, flags) {
            var expression = expr.expression;

            var result = this[expression.type](expression, precedence, flags);
            return parenthesize(result, Precedence.OptionalChain, precedence);
        },

Then you wouldn't need to mess around with precedence in MemberExpression and CallExpression. (I haven't tested this, but it seems like it should work.)

With regards to the actual implementation, it seems like it would be better to introduce a new precedence level for optional chains just below Call, and have ChainExpression parenthesize its result at that precedence - something along the lines of
Precedence = {
        [...]
        Postfix: 15,
        OptionalChain: 16,
        Call: 17,
        New: 18,
        TaggedTemplate: 19,
        Member: 20,
        Primary: 21
}

[...]

        ChainExpression: function (expr, precedence, flags) {
            var result = this[expression.type](expr.expression, precedence, flags);
            return parenthesize(result, Precedence.OptionalChain, precedence);
        },

Then you wouldn't need to mess around with precedence in MemberExpression and CallExpression. (I haven't tested this, but it seems like it should work.)

https://github.com/estools/escodegen/pull/412/commits/ac6361852f61f1fd3e0c16e3987c26f6272e396f

Some last things:

I'm pretty sure you should be using this.generateExpression rather than this[expression.type], just based on the rest of the file
The precedence to generate the things in the chain should be Precedence.OptionalChain, not precedence (sorry, I wrote the wrong thing in the previous comment)
In ChainExpression, when you're going to add parentheses (i.e. Precedence.OptionalChaining < precedence) you should set the F_ALLOW_CALL bit

The last couple of points are necessary so that new (a?.b().c) generates correctly and new (a?.b()) generates without additional parentheses and so on; you should add some tests for these and similar cases.
Putting that together, I think you want
ChainExpression: function (expr, precedence, flags) {
    if (Precedence.OptionalChaining < precedence) {
        flags |= F_ALLOW_CALL;
    }

    var result = this.generateExpression(expr.expression, Precedence.OptionalChaining, flags);
    return parenthesize(result, Precedence.OptionalChaining, precedence);
},

Thank you, i'll fix ot soon. Are you new maintainer of this repository? If no, it would be nice if you are.

No, just a passer-by.

@bakkot about new tests.
(a?.b().c) part of new (a?.b().c) expression is just a callee, without arguments. So escodegen WILL add empty brackets to it:
new (a?.b().c)();
So, parenthesis is necessary here, because optional chaining as part of new expressions is not supported by spec and AST parsers: https://github.com/tc39/proposal-optional-chaining#not-supported

Added more tests with new

@michaelficarra may you check it now, please

escodegen WILL add empty brackets to it:

Only when the parentheses option is set. They're not required, as you can see by the fact that they're not included in your minimal test.

So, parenthesis is necessary here

The parentheses around the (a?.b().c) are necessary, but the trailing () parentheses are not.

@michaelficarra we're still here. Ping.

@sanex3339 I strongly suspect that pinging the maintainers repeatedly is not going to get this merged faster.

I will happily merge and release as soon as @bakkot is done with his review. Also, what's the reason for dropping node 4 support and upgrading dependencies? It seems unrelated to this PR.

I will happily merge and release as soon as @bakkot is done with his review. Also, what's the reason for dropping node 4 support and upgrading dependencies? It seems unrelated to this PR.

I added chai-exclude package to deep compare AST-trees without start and end properties, but looks like it doesn't support node@4.

@bakkot are there any additional changes that you want?

@michaelficarra the implementation itself LGTM but I don't feel qualified to review the change to supported Node versions and the test harness.

@sanex3339 Can you extract the node/dependency changes to a separate PR? I agree that dropping node 4 support is reasonable.

@michaelficarra chai-exclude package requires node@6.
You asked me to add AST trees comparison, and chai-exclude is the easy way to remove start and end properties for AST comparison

I can extract AST-tree comparison and node version update into another PR. But it's a strange change because AST comparison helps me much with this PR.

@michaelficarra so, I need your decision.

@sanex3339 All I am suggesting is that we drop node 4 support in its own PR. I'll merge that, then you can rebase this PR on top of that one. You can leave the dependency changes in this one, since I see now that they're all related to this PR.

Lets keep it here

Ok, i'll create pr with node version update

PR with node update https://github.com/estools/escodegen/pull/418

@sanex3339 Please rebase.

@sanex3339 Please rebase.

@michaelficarra done

Published v2.0.0 (since I got yelled at last time I dropped support for an ancient node version in a minor release).

Thank you!


Trim buttons let you go into a short position (if youre long and visa versa)

Trim buttons should be able to sell no more than the shares you own. Even if you submit a trim order, it hasn't been filled, and you click the button again (for whatever reason). A scenario where this is critical is if someone accidentally double clicks and submits sell orders in total in excess of what they have available to sell

hmm damn I thought I'd protected against this already. Apparently I messed it up, but definitely need this!

Tested again:

I buy 14 shares
I rapidly click Trim 1/2 x 2 times, I have 0 shares, but a stop of -7 shares remains
I rapidly click Trim 1/2 x 3 times, then I end up with -14 shares
I rapidly click Trim 1/2 x 4 times, then I end up with -21 shares.


Add temperature profile to FlowProfiler

Small addition to the FlowProfiler to also be able to measure the temperature profile.
Not sure if this is the easiest way of doing it, also it does not take any shear flow gradients into account. Not sure that we want to take flow gradients into account, because they are highly specific to each single potential use case, probably better to leave this simple let the user take care of those cases individually?  Otherwise, pretty straightforward.
Should be merged before the tutorials pull request, as it will be needed in evaporation tutorial.

A test version of HOOMD 3.0 is now available. I'd like to merge this PR into develop, merge develop into master, and tag version 0.11.0. I propose that this should be the last minor version tag that we add for HOOMD 2.x, and we work towards making the tutorials & additional features compatible with HOOMD 3.x in a new branch based off this.
How does this plan sound to you?

Sounds good! I am going to be able to finish this up later today hopefully. For ''hoomd-3.x'', we should flip our major version number to ''1.x''.  "Open" features being worked on are: SLLOD, Dynamic bonding, and sine/cosine channels for mpcd. They should all transition to ''hoomd 3.x''.

Great, and agreed! Let me know if you need any help with this. I started to browse the new hoomd code, and it is a bit hard to follow because it is a preliminary release but I think we can start by getting things to compile and then start with the pair potentials. I will open a new issue to track this.

Also, I found out on another repo that because of the addition of the docker hub credentials, your PR may not automatically run through CircleCI anymore (security reasons). I can manually trigger the tests though when you request a review.

<x>/<y> vs <x/y> does make a difference for  extremely dilute systems. The latter will lead to many 0/0, which we set to 0 with np.divide(). When averaged, all those empty 0 bin-counts do contribute to the average.  For a "dense" system, e.g a minimum of a particle in each bin, it makes no visible difference.
I'm comparing:
# measuring
for dim in range(3):
    self._number_velocity[dim] += np.bincount(binids,v[:,dim],minlength=self.bins)
# output
result = np.zeros_like(self._number_velocity)
if self.samples > 0:
   for dim in range(3):
         result[dim] = np.divide(self._number_velocity[dim], self._counts, out=np.zeros(self.bins), where=self._counts > 0)

and
# measuring
for dim in range(3):
    vel = np.bincount(binids,v[:,dim],minlength=self.bins)
    counts = np.bincount(binids,minlength=self.bins)
    self._number_velocity[dim] += np.divide(vel, counts, out=np.zeros(self.bins), where=counts > 0)

# output
 result = np.zeros_like(self._number_velocity)
 if self.samples > 0:
      for dim in range(3):
          result[dim] = self._number_velocity[dim]/self.samples

Ah, that makes sense and what I was wondering. I would vote for using <x/y> because this is the instantenous value of these properties. For temperature, that is the one that would be used by a profile-unbiased thermostat, so I think it makes the most sense to log this. As you say, for a larger system with many samples, there should be essentially no difference between the two.

Happy new year! I'm following up on this now because I tried to use it and found a bug, which I think I made. :-)
Could you push whatever changes you have, and I will finish off this PR and fix the bug? I am motivated because I need to use this in the near future. Thanks!

Happy new year! I'm following up on this now because I tried to use it and found a bug, which I think I made. :-)
Could you push whatever changes you have, and I will finish off this PR and fix the bug? I am motivated because I need to use this in the near future. Thanks!

Hey @astatt: one more checkup on this. Do you have any commits that you haven't pushed yet? I will finish this one off myself and merge, but wanted to see if you had anything lying around. I am updating all of my repos now, trying to get a clean slate.


Expose reporter to running examples

Expose reporter to running examples and make the Reporter#message api public. Fixes #1851.

Think I've fixed this all up

LGTM, but let's make sure this meets @nyarly's needs before merging.

I think I can work with that - the reporter attribute is great, and I can either filter #message calls or build a parallel event dispatcher.


Need document count in the "browse documents" view

Right now it's impossible to know how many documents there are in a collection, either in the "browse documents" view or anywhere else.
It would be handy to have that information.

Fixed in 2.1.0


[FR] New 'emptyScrollbackBuffer' shortcut action with default corresponding mapping

Description of the new feature/enhancement
There should be a method of emptying the scroll-back buffer.
Proposed technical implementation details (optional)

This sounds like #1882.

It is indeed! /dup #1882. Thanks.

@j4james, @DHowett thanks for finding the dupe.  I did do a brief search as I really didn't believe I would be the first to raise this but none of my search terms were turning anything up.


UnifiVideoAPI.cameras includes cameras that are not managed by the system

Running the code:
self._uva = UnifiVideoAPI(api_key=api_key, addr=unifi_address, check_ufv_version=check_ufv_version) print(f'raw cameras: {[str(c) for c in self._uva.cameras]}')
Produces as output:
raw cameras: ["UnifiVideoCamera: {'model': 'UVC G3 Flex', 'name': 'testXcameraX1', 'platform': 'GEN3L'}", "UnifiVideoCamera: {'model': 'UVC G3 Pro', 'name': 'UVC-G3-Pro', 'platform': 'GEN3L'}", "UnifiVideoCamera: {'model': 'UVC G3 Pro', 'name': 'Camera4', 'platform': 'GEN3L'}", "UnifiVideoCamera: {'model': 'UVC G3 Pro', 'name': 'Camera3', 'platform': 'GEN3L'}", "UnifiVideoCamera: {'model': 'UVC G3 Pro', 'name': 'Camera2', 'platform': 'GEN3L'}", "UnifiVideoCamera: {'model': 'UVC G3 Pro', 'name': 'Camera1', 'platform': 'GEN3L'}"]
That structure lists 6 cameras.
However, this system only has 4 cameras on the local network and all 4 cameras are named "Camera1", "Camera2", "Camera3", "Camera4".
The other two cameras in the are:

"testXcameraX1" a camera that was once connected to this instance of Unifi Video NVR. The database may have been reset via the GUI after this camera was moved to a different nework.
"UVC-G3-Pro" is one of the 4 managed cameras from before I changed the names.

This result may suggest that the unifi-video-api call for get_cameras needs additional filtering to remove unmanaged cameras.

I fear there might be a user or two that have gotten use to the fact that UnifiVideoAPI.cameras includes every camera a UniFi Video instance is aware of. I opted for keeping a second collection for cameras that are both managed and connected: UnifiVideoAPI.active_cameras.
Please let me know if you think I missed something. I'll keep this open until there's a PyPI release that includes fab93f5.

That makes sense. I hadn't read into the code in detail. I assumed reading the examples that "cameras" mapped to "managed cameras in the NVR.
A few suggestions:

Update doc comment on UnifiVideoAPI to include active_cameras in list of attributes.
The booleans on the cameras are useful.
A collection of "managed_cameras" might be useful to maintain on the UnifiVideo API object.
Update the example in README.md to use active_cameras. (Or just add a comment there that explains that "cameras" contains all cameras ever seen by the NVR.

For my use, I am implementing two utilities.

a tool that downloads all recordings from the NVR matching certain time criteria and removes the recordings from the NVR.
a utility that checks that the camera settings for all cameras match expected settings for my deployments.

In the context of these utilities:

it is useful to compare whether all managed cameras are active. If not, raise a notification. Looks like I can achieve this with the new booleans.
it is useful to identify unmanaged cameras to raise a notification that system setup may not have been completed.

If you have access to the last time a camera was connected, that may be useful to include in the camera object. This way, if a camera is not active a developer could choose to only take action on the camera if the disconnect has exceeded some time-window.

Great suggestions, thanks.
Shortly after pushing fab93f5, it occured to me that refresh_cameras() now needs some logic to ensure it doesn't leave any stale cameras in active_cameras. I'll give managed_cameras more thought when I sort out the potential for stales.
Re the last connected timestamp, looks like UniFi Video does include it in the output for the /api/2.0/camera endpoint, for 3.10.13 at least. I'll assign it to UnifiVideoCamera.last_seen.
For reference, here's the full JSON for /api/2.0/camera (3.10.13).

Nice.

Finally managed to release a new version (should be in PyPI too). Here's hoping I didn't forget anything.


[DDW-16] Table comparison view for stake pools

This PR adds Table comparison view for stake pools. Also it adds 2 switch buttons on stake pools search component were user can switch between Grid and Table view.
Screenshots

Testing Checklist

Slack QA thread

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@DeeJayElly can you update list view in netlify?

@DeeJayElly can you update list view in netlify?

@a-rukin pls dont test it, its still WIP

@DeeJayElly can you update list view in netlify?

@a-rukin pls dont test it, its still WIP

@a-rukin storybook updated

flip this icon one more time, so lines would be left aligned

and

not sure how name ordering is working

and

not sure how name ordering is working

It works by ordering by ticker alphabet.

flip this icon one more time, so lines would be left aligned

I didnt quite understand you? Can you try to explain what needs to be rotated?

@DeeJayElly Here is a list of the issues I found so far:
Note: Screenshots are linked.
1 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column is incorrect.
2 - The sorting by "Name" (which should consider the ticker) is not working for me either.
3 - I found that the "ascending" icon on the grid is flipped horizontally. I think this is what @a-rukin was reporting before (please confirm). In my opinion it should look something like this.
I found this also affect the grid on "Rewards". Would a fix affect both grids or should I create a new card for this?

flip this icon one more time, so lines would be left aligned

I didnt quite understand you? Can you try to explain what needs to be rotated?

Icons should look like

and

and

not sure how name ordering is working

It works by ordering by ticker alphabet.

Y > F
Q < W > S
🤷

flip this icon one more time, so lines would be left aligned

I didnt quite understand you? Can you try to explain what needs to be rotated?

Icons should look like

and

Fixed

need to align title and content here

Use saturation colors from here https://zpl.io/2GvKrwW

Use saturation colors from here

I think those will be fixed once @DeeJayElly merges latest develop.

Or maybe not? 😕
Please check that @DeeJayElly

Can we add few pools examples to the storybook with retirement property (label)

@a-rukin @nikolaglumac All the requested changes have been implemented.

for pools which are not retiring there is no need in red pill

@DeeJayElly I still can reproduce these issues:

1 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column is incorrect.
2 - The sorting by "Name" (which should consider the ticker) is not working for me either.

As @nikolaglumac mentioned, the color of the saturation bar is still different from the original view.
Screenshots: Green (Tiles, table), Yellow (Tiles, table), Orange (Tiles, table), Green (Tiles, table).

for pools which are not retiring there is no need in red pill

Fixed

Hi @DeeJayElly . Here are my findings:
On Build 14523
Fixed
1 - Values on "Pledge" shown "K" instead of "000"
2 - The sorting by "Name" (which should consider the ticker)
3 - Color of the saturation bar is still different from the original view
New Issues
1 - The pledge amount is centre justify. It will look better when right justify.  See here
2 - Retiring in details got wrapped around when Daedalus made smaller See here

instead of two line headers and tiny columns I'd suggest to drop some columns as we reach some width

Got this netlify error here

@a-rukin can you re-test now?

@a-rukin can you re-test now?

no more error 👍

Can we add few pools examples to the storybook with retirement property (label)?

So can we? it would be possible to test this feature in netlify

https://zpl.io/2GvKrwW I forgot that we have a horizontal scroll !!!
@DeeJayElly let's set a min width for horizontal scroll to appear

https://zpl.io/2GvKrwW I forgot that we have a horizontal scroll !!!

@DeeJayElly let's set a min width for horizontal scroll to appear

Added @a-rukin

how is this possible -1 dayS
I'm botheres with Minus "-" and "S" ))

https://zpl.io/2GvKrwW I forgot that we have a horizontal scroll !!!

@DeeJayElly let's set a min width for horizontal scroll to appear

Added @a-rukin

Hm... Not it doesn't resize at all, just adds scroll. starting point for this scroll should be reduced -> Need to play with previous version of app to see exact point
Plus, In this case it's probably worth stick header to the top and bottom (to be visible) as in design, so only inner area is scrollable

Click on a row should open or regular stakepool overview popup

I think default sorting should be A->Z, not Z->A

how is this possible -1 dayS
I'm bothered with Minus "-" and "S" ))

Fixed

@DeeJayElly Here's a summary of the issues so far:
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - Saturation color were incorrect. Reported here and here.
7 - The pools that were not retiring shown a red pill. Reported here.
8- Alignment of "Pledge" values. Reported here.
9 - Retirement details got wrapped up on small resolutions. Reported here.
10 - Use a horizontal scroll to avoid two rows of headers Reported here.
11 - Insert a minimum width to display the scrollbar. Reported here.
12 - Remove "-" on retirement values. Also, show "day" instead of "days" when the value is 1. Reported here.
Pending:
1 - Default sorting should be ascending instead of descending. Reported here.
New:
1 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation.
2 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
3 - Is there a way to make the scrollbar more visible? It's not very clear that there is another column, even on the default size.

@gnpf regarding scroll bar and visibility:
I've already mentioned this -> we will see both scrollbars (at least one)

red area scrollable vertically, blue sticked to the top
both blue and red areas scrollable horizontally

Hi @DeeJayElly Here's a summary for the newest build 14585
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - Saturation color were incorrect. Reported here and here.
7 - The pools that were not retiring shown a red pill. Reported here.
8- Alignment of "Pledge" values. Reported here.
9 - Retirement details got wrapped up on small resolutions. Reported here.
10 - Use a horizontal scroll to avoid two rows of headers Reported here.
11 - Insert a minimum width to display the scrollbar. Reported here.
12 - Remove "-" on retirement values. Also, show "day" instead of "days" when the value is 1. Reported here.
Fixed in this build
13- The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
14 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
Pending:
1 - Default sorting should be ascending instead of descending. Reported here

Insert a minimum width to display the scrollbar. Reported here.

@ManusMcCole I think this scrolling UX is still to be implemented. Now it's not that user friendly

how "todo" could be sorted in this way before "WILLO" in descending order?

Pending:
1 - Default sorting should be ascending instead of descending. Reported here

@ManusMcCole fixed:
1 - Default sorting should be ascending instead of descending. Reported here

@DeeJayElly Here's a summary of the issues so far:
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - Saturation color were incorrect. Reported here and here.
7 - The pools that were not retiring shown a red pill. Reported here.
8- Alignment of "Pledge" values. Reported here.
9 - Retirement details got wrapped up on small resolutions. Reported here.
10 - Use a horizontal scroll to avoid two rows of headers Reported here.
11 - Insert a minimum width to display the scrollbar. Reported here.
12 - Remove "-" on retirement values. Also, show "day" instead of "days" when the value is 1. Reported here.
13 - Default sorting should be ascending instead of descending. Reported here.
14 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
Reincident:
1 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
Pending:
1 - Scrollbar is not visible. Reported here. Mentioned here, here and here.
2 - Alphabetical sorting should not be case sensitive. Reported here.

@ManusMcCole @gnpf @mioriohk , @a-rukin I have implemented stake pools row click thumbnail which opens our Thumb popup.

@DeeJayElly Good work, the table is looking better. Here's a summary of the issues for 14655:
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - Saturation color were incorrect. Reported here and here.
7 - The pools that were not retiring shown a red pill. Reported here.
8- Alignment of "Pledge" values. Reported here.
9 - Retirement details got wrapped up on small resolutions. Reported here.
10 - Use a horizontal scroll to avoid two rows of headers Reported here.
11 - Insert a minimum width to display the scrollbar. Reported here.
12 - Remove "-" on retirement values. Also, show "day" instead of "days" when the value is 1. Reported here.
13 - Default sorting should be ascending instead of descending. Reported here.
14 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
15 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
Pending:
1 - Horizontal scrollbar is not visible. Reported here. Mentioned here, here and here.
2 - Alphabetical sorting should not be case sensitive. Reported here.
New:
1 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
2 - The headers "name" and "pledge" are not centered as the rest of the them.
3 - When you shrink the window, a white square is visible on the bottom.
4 - The information on the popup is centered, in the original view, is aligned to the left.

@DeeJayElly this table header block appears to be above search (should be below, so we can see shadow)

Labels are not centered vertically

@DeeJayElly. Here's a summary of the issues for 14661:
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - Saturation color were incorrect. Reported here and here.
7 - The pools that were not retiring shown a red pill. Reported here.
8- Alignment of "Pledge" values. Reported here.
9 - Retirement details got wrapped up on small resolutions. Reported here.
10 - Use a horizontal scroll to avoid two rows of headers Reported here.
11 - Insert a minimum width to display the scrollbar. Reported here.
12 - Remove "-" on retirement values. Also, show "day" instead of "days" when the value is 1. Reported here.
13 - Default sorting should be ascending instead of descending. Reported here.
14 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
15 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
16 - Horizontal scrollbar is no longer needed. Reported here. Mentioned here, here and here.
17 - The headers "name" and "pledge" are not centered as the rest of the them.
18 - In "Produced block" header, sometimes the sorting icon drops to the second line. It doesn't look attractive. If I may suggest, I feel it should be attached to the word "block", so that when it drops down, both "block" and the icon will drop together. See here
Pending:
1 - Alphabetical sorting should not be case sensitive. Reported here. Build 14661 See here
2 - When you shrink the window, a white square is visible on the bottom.
3. - The information on the popup is centered, in the original view, is aligned to the left.
New
This isue popped up before but now it has changed
1 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
Now the search stake pool bar shows through the stake pool information pop up with a white rectangle beneath it.See here
2 - New issue with table header block appears to be above search. As reported by Sasha here
3 - New issue with Labels are not centered vertically. Reported here here

@DeeJayElly  Findings for build 14669
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - Saturation color were incorrect. Reported here and here.
7 - The pools that were not retiring shown a red pill. Reported here.
8- Alignment of "Pledge" values. Reported here.
9 - Retirement details got wrapped up on small resolutions. Reported here.
10 - Use a horizontal scroll to avoid two rows of headers Reported here.
11 - Insert a minimum width to display the scrollbar. Reported here.
12 - Remove "-" on retirement values. Also, show "day" instead of "days" when the value is 1. Reported here.
13 - Default sorting should be ascending instead of descending. Reported here.
14 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
15 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
16 - Horizontal scrollbar is no longer needed. Reported here. Mentioned here, here and here.
17 - The headers "name" and "pledge" are not centered as the rest of the them.
18 - In "Produced block" header, sometimes the sorting icon drops to the second line. It doesn't look attractive. If I may suggest, I feel it should be attached to the word "block", so that when it drops down, both "block" and the icon will drop together. See here
19 - When you shrink the window, a white square is visible on the bottom.
20 - The information on the popup is centered, in the original view, is aligned to the left.
21 - Saturation column is not aligned properly. See here
Pending:
1 - Alphabetical sorting should not be case sensitive. Reported here. Build 14661 See here
New
This isue popped up before but now it has changed
1 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
Now the search stake pool bar shows through the stake pool information pop up with a white rectangle beneath it.See here
2 - New issue with table header block appears to be above search. As reported by Sasha here
3 - New issue with Labels are not centered vertically. Reported here here
4 - When the table is sorted by "Pledge", the sorting is incorrect. See here
5 - The figures for saturation, cost, margin and produced block don't look nice when they are centred justify. They will be better right justify. See here

@DeeJayElly please merge latest develop...

@ManusMcCole @mioriohk @nikolaglumac @a-rukin All the requested changes with new UI updates on the table are implemented. I have fixed all pending issues and added new design changes according to @a-rukin new proposed design.
https://zpl.io/bJeMrYx
https://zpl.io/agjRwMM
https://zpl.io/bovpjWo
Feel free to review it.

@DeeJayElly Findings for build 14682
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - The pools that were not retiring shown a red pill. Reported here.
7- Alignment of "Pledge" values. Reported here.
8 - Retirement details got wrapped up on small resolutions. Reported here.
9 - Insert a minimum width to display the scrollbar. Reported here.
10 - Default sorting should be ascending instead of descending. Reported here.
11 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
12 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
13 - Horizontal scrollbar is no longer needed. Reported here. Mentioned here, here and here.
14 - The headers "name" and "pledge" are not centered as the rest of the them.
15 - In "Produced block" header, sometimes the sorting icon drops to the second line. It doesn't look attractive. If I may suggest, I feel it should be attached to the word "block", so that when it drops down, both "block" and the icon will drop together. See here
16 - When you shrink the window, a white square is visible on the bottom.
17 - The information on the popup is centered, in the original view, is aligned to the left.
18 - Saturation column is not aligned properly. See here
19 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
20 - Now the search stake pool bar shows through the stake pool information pop up with a white rectangle beneath it.See here
21 - New issue with table header block appears to be above search. As reported by Sasha here
Pending
1 - Alphabetical sorting should not be case sensitive. Reported here. Build 14661 See here(NOT FIXED)
2 - When the table is sorted by "Pledge", the sorting is incorrect. See here (NOT FIXED)
3 -  Labels are not centered vertically. Reported here here (NOT FIXED)
New issue
1 - Saturation colour is all in green See here
2 - When you shrink the window when developers tool is opened, a white square is visible on the bottom.
Invalid
6 - The figures for saturation, cost, margin and produced block don't look nice when they are centred justify. They will be better right justify. (Note: now invalid as design dictates the alignment)

@DeeJayElly @mioriohk @a-rukin @gnpf @ManusMcCole here's the saturation indicator color logic:
0 - 100 = green
100.01 - 105 = yellow
105.01 - 110 = orange
110.1 + = red

New issue
When table header sticks it goes out pf table, see here

@gnpf @ManusMcCole @mioriohk @a-rukin @DeeJayElly where are we at with this one?

@gnpf @ManusMcCole @mioriohk @a-rukin @DeeJayElly where are we at with this one?

UI issues are resolved. The only remaining one is sorting issue for numbers and strings which include ticker + name.

@yakovkaravelov @daniloprates please review this one today 🙏

UI issues are resolved. The only remaining one is sorting issue for numbers and strings which include ticker + name.

Remaining issues from my comment
2 - When switching between the views (grid/list) there is a strange behaviour like here
4 - Left and right paddings are not equal here
New issues
1 - Table header is shifted when becomes sticked - here
2 - Table header is not vertically centered - here. Should have 10px padding top/bottom as per design

@DeeJayElly Findings for build 14684
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - The pools that were not retiring shown a red pill. Reported here.
7- Alignment of "Pledge" values. Reported here.
8 - Retirement details got wrapped up on small resolutions. Reported here.
9 - Insert a minimum width to display the scrollbar. Reported here.
10 - Default sorting should be ascending instead of descending. Reported here.
11 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
12 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
13 - Horizontal scrollbar is no longer needed. Reported here. Mentioned here, here and here.
14 - The headers "name" and "pledge" are not centered as the rest of the them.
15 - In "Produced block" header, sometimes the sorting icon drops to the second line. It doesn't look attractive. If I may suggest, I feel it should be attached to the word "block", so that when it drops down, both "block" and the icon will drop together. See here
16 - When you shrink the window, a white square is visible on the bottom.
17 - The information on the popup is centered, in the original view, is aligned to the left.
18 - Saturation column is not aligned properly. See here
19 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
20 - Now the search stake pool bar shows through the stake pool information pop up with a white rectangle beneath it.See here
21 - New issue with table header block appears to be above search. As reported by Sasha here
Pending
1 - Alphabetical sorting should not be case sensitive. Reported here  See here(Not fixed)
2 - When the table is sorted by "Pledge", the sorting is incorrect. See here (Not fixed)
3 -  Labels are not centered vertically. Reported here here (Not fixed)
4 - When switching between the views (grid/list) there is a strange behaviour like here
5 - Left and right paddings are not equal here. They were changed, but still not equal
6 - When you shrink the window when developers tool is opened, a white square is visible at the bottom.
7 - Table header is shifted when becomes sticked - here
8 - Table header is not vertically centered - here. Should have 10px padding top/bottom as per design

Fixed:
4 - When switching between the views (grid/list) there is a strange behaviour like here
5 - Left and right paddings are not equal here. They were changed, but still not equal
6 - When you shrink the window when developers tool is opened, a white square is visible at the bottom.

@DeeJayElly there's a styling issue when changing grid/list views:

@DeeJayElly @nikolaglumac the list view is very slow, for me. Shouldn't we go for a virtual list, lazing load, pagination or something?

@DeeJayElly @nikolaglumac the list view is very slow, for me. Shouldn't we go for a virtual list, lazing load, pagination or something?

@daniloprates I think preloading technique that I have used on the tiles view will do: https://github.com/input-output-hk/daedalus/pull/2177/files - @DeeJayElly please try to apply this to the list view too 🙏

@nikolaglumac , @daniloprates guys if you examine my StakePoolsTable.js component you will see that i have already implemented the same logic for preloading of stake pools on my table. But apperently this implementation doesnt help a lot with larger amount of stake pools.

@DeeJayElly there's a styling issue when changing grid/list views:

@daniloprates can you recheck it again, as i have fixed the issue with loading of the list view.

@DeeJayElly @nikolaglumac the list view is very slow, for me. Shouldn't we go for a virtual list, lazing load, pagination or something?

@daniloprates I think preloading technique that I have used on the tiles view will do: https://github.com/input-output-hk/daedalus/pull/2177/files - @DeeJayElly please try to apply this to the list view too 🙏

@nikolaglumac , @daniloprates guys if you examine my StakePoolsTable.js component you will see that i have already implemented the same logic for preloading of stake pools on my table. But apperently this implementation doesnt help a lot with larger amount of stake pools.

Seems we need either lazy loading or virtual lists

@DeeJayElly @nikolaglumac the list view is very slow, for me. Shouldn't we go for a virtual list, lazing load, pagination or something?

@daniloprates I think preloading technique that I have used on the tiles view will do: https://github.com/input-output-hk/daedalus/pull/2177/files - @DeeJayElly please try to apply this to the list view too 🙏

@nikolaglumac , @daniloprates guys if you examine my StakePoolsTable.js component you will see that i have already implemented the same logic for preloading of stake pools on my table. But apperently this implementation doesnt help a lot with larger amount of stake pools.

Seems we need either lazy loading or virtual lists

I doubt that. Perhaps the structure of components and the rendering order is the issue. We will check it in another task.

@DeeJayElly @nikolaglumac the list view is very slow, for me. Shouldn't we go for a virtual list, lazing load, pagination or something?

@daniloprates I think preloading technique that I have used on the tiles view will do: https://github.com/input-output-hk/daedalus/pull/2177/files - @DeeJayElly please try to apply this to the list view too 🙏

@nikolaglumac , @daniloprates guys if you examine my StakePoolsTable.js component you will see that i have already implemented the same logic for preloading of stake pools on my table. But apperently this implementation doesnt help a lot with larger amount of stake pools.

Seems we need either lazy loading or virtual lists

I doubt that. Perhaps the structure of components and the rendering order is the issue. We will check it in another task.

@DeeJayElly @daniloprates don't get me wrong - I have nothing against lazy loading and virtual lists BUT I feel it could be that we just to tweak the rendering order here and make it working good without investing time into setting up new stuff.

@DeeJayElly Findings for build 14738
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - The pools that were not retiring shown a red pill. Reported here.
7- Alignment of "Pledge" values. Reported here.
8 - Retirement details got wrapped up on small resolutions. Reported here.
9 - Insert a minimum width to display the scrollbar. Reported here.
10 - Default sorting should be ascending instead of descending. Reported here.
11 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
12 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
13 - Horizontal scrollbar is no longer needed. Reported here. Mentioned here, here and here.
14 - The headers "name" and "pledge" are not centered as the rest of the them.
15 - In "Produced block" header, sometimes the sorting icon drops to the second line. It doesn't look attractive. If I may suggest, I feel it should be attached to the word "block", so that when it drops down, both "block" and the icon will drop together. See here
16 - When you shrink the window, a white square is visible on the bottom.
17 - The information on the popup is centered, in the original view, is aligned to the left.
18 - Saturation column is not aligned properly. See here
19 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
20 - Now the search stake pool bar shows through the stake pool information pop up with a white rectangle beneath it.See here
21 - New issue with table header block appears to be above search. As reported by Sasha here
22. Table header/Labels are not centered vertically. Reported here here and here. Should have 10px padding top/bottom as per design
23. When you shrink the window when developers tool is opened, a white square is visible at the bottom.
24 - Table header is shifted when becomes sticked - here
Pending
1 - Alphabetical sorting should not be case sensitive. Reported here  See here
2 - When the table is sorted by "Pledge", the sorting is incorrect. See here
4 - This issue below has now changed. The position of the Search Stake Pools box now changes to from above or below the slider as you switch between grid and table view as in this video
(When switching between the views (grid/list) there is a strange behaviour like here)
5 -For this one below Sashas report is now that right padding is missed and header titles are shifted.
His suggestion is to reduce “Name” column to nothing (except ticker), but show all other columns in a proper viewable way.See  screenshot
( Left and right paddings are not equal here. They were changed, but still not equal)

@ManusMcCole @a-rukin @gnpf @mioriohk Sorting is improved and it should include now all columns and values to be sortable in the correct way:
1 - Alphabetical sorting should not be case sensitive. Reported here See here
2 - When the table is sorted by "Pledge", the sorting is incorrect. See here

@ManusMcCole @mioriohk @gnpf
I agree on the suggestion to move the 'Back to top' button behind the Tooltip as it makes more sense to improve readablity.
These 2 are covered now:
4 - This issue below has now changed. The position of the Search Stake Pools box now changes to from above or below the slider as you switch between grid and table view as in this video
(When switching between the views (grid/list) there is a strange behaviour like here)
New*
1.The back to top label overlaps the stake pool information popup sometimes making it a little difficult to read.Me and Sasha think it should be moved behind.Or maybe the label width decreased slightly ? What do you think ? @nikolaglumac. screenshot

@DeeJayElly the jiggling issue is still happening:

@nikolaglumac TBH I don't see the point of releasing this screen if the UX is not actually good. @DeeJayElly did a great job, but the screen needs many improvements.
The overall experience - scrolling, opening/closing a tooltip - is very slow.
The scroll gets super tiny, because of the list size and it's hard to handle when switching on/off the sticky header. It would also make sense for the scroll to be aligned with the top of the list.

Such a huge list is not a common UI practice and it would work much better if this view was only enabled when some sort of filtering was applied.
If we do release it like it is, I'd suggest we had already some improvements in mind.

Hi @DeeJayElly. I updates my comment and the summary at the top of the page. I can confirm sorting by name and by pledge are working correctly now 👍

1.The back to top label overlaps the stake pool information popup sometimes making it a little difficult to read.Me and Sasha think it should be moved behind.Or maybe the label width decreased slightly ? What do you think ? @nikolaglumac.

Please leave it as is...

1.The back to top label overlaps the stake pool information popup sometimes making it a little difficult to read.Me and Sasha think it should be moved behind.Or maybe the label width decreased slightly ? What do you think ? @nikolaglumac.

Please leave it as is...

Hi @nikolaglumac . The fix was added by @DeeJayElly before you commented. It is now behind the Stake Pool Information Popup. Do you want him to revert that change now ?

1.The back to top label overlaps the stake pool information popup sometimes making it a little difficult to read.Me and Sasha think it should be moved behind.Or maybe the label width decreased slightly ? What do you think ? @nikolaglumac.

Please leave it as is...

Hi @nikolaglumac . The fix was added by @DeeJayElly before you commented. It is now behind the Stake Pool Information Popup. Do you want him to revert that change now ?

No. Leave it.

Hi @ @DeeJayElly. I added to my above comment and the QA testing report in the Pr Description. I can confirm that 4.The position of the Search Stake Pools box now changes to from above or below the slider as you switch between grid and table view as in this and 1.The back to top label overlaps the stake pool information popup sometimes making it a little difficult to read.Me and Sasha think it should be moved behind. have both been fixed

@DeeJayElly @nikolaglumac hey guys, I've done 2 small changes:

Increased the height of the scrollbar thumb, so it's easier to scroll through the huge list
Added a debounce to the function that determines whether the header should be fixed. It gets fixed when the scroll is stopped, which is a bit different, but it improves the performance in a simple way.

Feel free to tweak/remove it.

New issues
1 - Something went wrong with popup alignment, look here

@DeeJayElly @nikolaglumac hey guys, I've done 2 small changes:

Increased the height of the scrollbar thumb, so it's easier to scroll through the huge list
Added a debounce to the function that determines whether the header should be fixed. It gets fixed when the scroll is stopped, which is a bit different, but it improves the performance in a simple way.

Feel free to tweak/remove it.

Great work @daniloprates 🚀
Performance is already much improved - let's see if we can make it even better today 🙏
Reach out to me if you need ideas for that!
cc @DeeJayElly

New issues
1 - Something went wrong with popup alignment, look here

fixed

Hi @DeeJayElly and @daniloprates great work guys this is looking very good now.Heres the report for build 14803
New:
1 - Could there be further optimisation on positioning of Stake Pool Information Popup. For some stake pools when it initially pops up the Stake Pool Name and tooltip colorband is sometimes not in the frame and the user must scrollup. See
video
Fixed:
1 - The sorting icon is flipped horizontally. Reported here, here and here.
2 - The previous issue was also reproducible on the Rewards screen. Mentioned here and here.
3 - As the values on "Pledge" shown "K" instead of "000", the sorting by this column was incorrect. Reported here.
4 - The sorting by "Name" (which should consider the ticker) was not working. Reported here, here and here.
5 - Alignment of "saturation" column. Reported here.
6 - The pools that were not retiring shown a red pill. Reported here.
7- Alignment of "Pledge" values. Reported here.
8 - Retirement details got wrapped up on small resolutions. Reported here.
9 - Insert a minimum width to display the scrollbar. Reported here.
10 - Default sorting should be ascending instead of descending. Reported here.
11 - The "Cost" column has the same issue "Pledge" had before, the values are sorted incorrectly because of the abbreviation
12 - The margin at the right of "Retirement" is very small, the sorting icon is shown very close to the border.
13 - Horizontal scrollbar is no longer needed. Reported here. Mentioned here, here and here.
14 - The headers "name" and "pledge" are not centered as the rest of the them.
15 - In "Produced block" header, sometimes the sorting icon drops to the second line. It doesn't look attractive. If I may suggest, I feel it should be attached to the word "block", so that when it drops down, both "block" and the icon will drop together. See here
16 - When you shrink the window, a white square is visible on the bottom.
17 - The information on the popup is centered, in the original view, is aligned to the left.
18 - Saturation column is not aligned properly. See here
19 - Sometimes, the pop up is shown cropped and is not next to the item. Here is an example, when you click on the first stake pool.
20 - Now the search stake pool bar shows through the stake pool information pop up with a white rectangle beneath it.See here
21 - New issue with table header block appears to be above search. As reported by Sasha here
22. Table header/Labels are not centered vertically. Reported here here and here. Should have 10px padding top/bottom as per design
23. When you shrink the window when developers tool is opened, a white square is visible at the bottom.
24 - Alphabetical sorting should not be case sensitive. Reported here  See here
26 - When the table is sorted by "Pledge", the sorting is incorrect. See here
27 - 1 - This issue below has now changed. The position of the Search Stake Pools box now changes to from above or below the slider as you switch between grid and table view as in this video
(When switching between the views (grid/list) there is a strange behaviour like here)
28 - The back to top label overlaps the stake pool information popup sometimes making it a little difficult to read.Me and Sasha think it should be moved behind.Or maybe the label width decreased slightly ? What do you think ? @nikolaglumac. screenshot
29 - Table header is shifted when becomes sticked - here
30 -For this one below Sashas report is now that right padding is missed and header titles are shifted.
His suggestion is to reduce “Name” column to nothing (except ticker), but show all other columns in a proper viewable way.See  screenshot
31 -( Left and right paddings are not equal here. They were changed, but still not equal)

1 - Could there be further optimisation on positioning of Stake Pool Information Popup. For some stake pools when it initially pops up the Stake Pool Name and tooltip colorband is sometimes not in the frame and the user must scrollup. See
@ManusMcCole, this is not in the scope of this PR. Please post suggestions like this to #daedalus-feature-specifications

New issues on 14824:

The unranked items are misaligned. Here is a screenshot.
The "retirement" pill has no translation for "day/days" in Japanese. Here is a screenshot.

@daniloprates @DeeJayElly Issues on 14831:
Pending:

MAKU, LAND and MPN stake pools is incorrectly sorted by saturation. Here is a new screenshot.

Fixed:

The unranked items are misaligned in Japanese. Here is a screenshot.
The "retirement" pill has no translation for "day/days" in Japanese. Here is a screenshot.
The alignment of the headers Ticker and Pledge is incorrect. The data on Pledge look misaligned too. Here is a screenshot.

MAKU, LAND and MPN stake pools is incorrectly sorted by saturation

Saturation in the details is different from saturation in the table. That is the issue here.

@daniloprates @DeeJayElly Issues on 14833:
New:
The tooltip is now displayed below the row in some cases and looks like a good improvement. Maybe it's a minor detail, but sometimes the tooltip is still displayed to the side. Here is a recording.
Pending:

MAKU, LAND and MPN stake pools is incorrectly sorted by saturation. Here is a new screenshot.

Fixed:

The unranked items are misaligned in Japanese. Here is a screenshot.
The "retirement" pill has no translation for "day/days" in Japanese. Here is a screenshot.
The alignment of the headers Ticker and Pledge is incorrect. The data on Pledge look misaligned too. Here is a screenshot.

The testing summary was updated.

@gnpf fixed the issue with saturation sorting

The tooltip is now displayed below the row in some cases and looks like a good improvement. Maybe it's a minor detail, but sometimes the tooltip is still displayed to the side. Here is a recording.

@gnpf that is how it was intended to work. The default position is on the side, and only stake pools in top rows have it displayed below...


question: validate field if some other field == some value?

Package version v9:
Question

type Config struct {
	EncryptionMode      string                  `yaml:"encryptionMode" validate="oneof=disabled legacyAES"`
	SecretKey           *config.SecretKeyConfig `yaml:"secretKey"`
}

I want to add validate tags to the SecretKey field, but i only want that to be validated if EncryptionMode == legacyAES, is that possible with the built in funcs? Or even i it possible to build a custom validator to do that generically? or does it have to be done as a struct level validator?
Thanks

You can define a custom struct validator function.
Example: https://github.com/go-playground/validator/blob/v9/_examples/struct-level/main.go#L37

@lbyte00 thanks, we were hoping to avoid doing that. Unlike the example we have dozens of small structs (nested) all over the code, and we are using a singlton validator object (created without visibility to every nested struct) and code standard is pushing us away from using init funcs to register them all.
Alternatively I was thinking about pushing a patch to attempt to cast each struct to a StructLevelValifator interface type to automatically call the validator func without needing registrations,. It sure how that would be received though.

@jdgordon yeah, I don't like this approach of defining custom struct validation functions too, and currently that's the only way that I found (had the same question as yours).

Thanks for the info @jdgordon @lbyte00
currently no there is no built-in functions to do this beyond StructLevel validation at this time.
I'm investigating options to support more expressive validations that have been being requested, without creating a customer syntax or query language, it is a breaking change though:

Merge field and struct validations into one to consolidate the interface and be able to perform custom validations on struct themselves, not just their fields.

The honest truth is I don't know when I'll be able to get to these changes as my plate is pretty full.


Fix/jira tickets

Description
This fixes the Jira issues to allow releasing 1.6.1
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Chore: cleanup/renaming, etc
[ ] RFC

Notes

Acceptance

[x] I have read the Contributing guidelines
[x] I have read the Code of Conduct

I'm getting an infinite loading state. Is it working perfectly for you?
https://www.loom.com/share/4f38dfa2fa3c4b88b21e9b2954e9aad7

getting the same. Please look at Daily Summary while I debug.

I'm getting an infinite loading state. Is it working perfectly for you?
https://www.loom.com/share/4f38dfa2fa3c4b88b21e9b2954e9aad7

getting the same. Please look at Daily Summary while I debug.

What should I look for in Daily Summary, specifically?

I'm getting an infinite loading state. Is it working perfectly for you?
https://www.loom.com/share/4f38dfa2fa3c4b88b21e9b2954e9aad7

Ah, I see the error. It's a backend thing.

I'm getting an infinite loading state. Is it working perfectly for you?
https://www.loom.com/share/4f38dfa2fa3c4b88b21e9b2954e9aad7

getting the same. Please look at Daily Summary while I debug.

What should I look for in Daily Summary, specifically?

Any errors to be found, any code smells

I'm getting an infinite loading state. Is it working perfectly for you?
https://www.loom.com/share/4f38dfa2fa3c4b88b21e9b2954e9aad7

Ah, I see the error. It's a backend thing.

Fixed both in backend and frontend

I'm approving with the error described above. We'll polish this down the road.


Publish this in the marketplace

I'm not sure if it's ready yet, but I'll see

I'm not sure if it's ready yet, but I'll see

Publish it is a preview version

Or at least release vsix to make it easier to install

Publish it is a preview version
A preview version sounds like a great idea
I think I'll do it soon (maybe once Clue 2.2 is out)

The most important thing to make clue a usable would be making a language server (probably modifying and existing Lua language server)

The most important thing to make clue a usable would be making a language server (probably modifying and existing Lua language server)

I agree, I tried looking at Lua's language server a while ago but I couldn't figure it out
I'm not sure if I would be able to modify/make another myself

The most important thing to make clue a usable would be making a language server (probably modifying and existing Lua language server)

I agree, I tried looking at Lua's language server a while ago but I couldn't figure it out I'm not sure if I would be able to modify/make another alone

I took a look at the code and understood what had to be changed (the parser and the ast) though I wasn't able to understand how it should be changed either

The most important thing to make clue a usable would be making a language server (probably modifying and existing Lua language server)

I agree, I tried looking at Lua's language server a while ago but I couldn't figure it out I'm not sure if I would be able to modify/make another alone

I took a look at the code and understood what had to be changed (the parser and the ast) though I wasn't able to understand how it should be changed either

hm, maybe we could ask them for help, not sure tho


Add lint function to inspect input files

As some users have had some trouble with input file formats, it might be useful to have a small linting function that allows to check whether the input is correctly formatted, and if not points to the issues with it.

Decided that a lint function is not really necessary, and instead added more checks and better error messages to the input file reading.


Integration / replicated.sql placement

@doolse - Do you know the purpose for https://github.com/equella/Equella/blob/master/Source/Integration/replicated.sql  ?
Looks like a template to setup a Replicated Data Source for user auth in Equella.  If so, I think this should move over to the docs repo for user auth.  Do you agree?

 So yeah it's better off in the documentation.

Moved to https://github.com/equella/equella.github.io/blob/master/example-scripts/replicated.sql


File Upload as a Stream

Finatra currently does not support streaming files uploaded via a multipart HTTP request.
Expected behavior
The ability to stream the raw bytes of a file being uploaded using com.twitter.finatra.http.fileupload.FinagleRequestFileUpload
Actual behavior
As per the TODO inside of com.twitter.finatra.http.fileupload.MultipartItem: // TODO don't store file in memory; write to temp file and store file reference.
Currently, the entire file is read into memory inside of parseMultipartItems in FinagleRequestFileUpload
Steps to reproduce the behavior
Self-explanatory.
Attempted resolution(s)
To say I'm a beginner with Scala and Finatra/Finagle would be giving me too much credit... I tried to extend FinagleRequestFileUpload with my own class and create my own version of MultipartItem to get the behaviors that I want, but there must be some magic going on that I'm not aware of.
When I try:
  post("/upload") { request: MyRequestFileUpload =>
   // where `fromRequest()` is my version of `FinagleRequestFileUpload.parseMultipartItems()`
    request.fromRequest(request)
  }

I get the following compile time exception:
Error:(23, 25) type mismatch;
 found   : com.twitter.finatra.http.fileupload.MyRequestFileUpload
 required: com.twitter.finagle.http.Request
    request.fromRequest(request)

If there is any way at all that I can be of assistance, please let me know. I would love to use Finatra, as it's much higher-level than Finagle, but I am required to upload files that could be in excess of several gigabytes and don't really want to do anything too weird.
If you know of a work-around that I could do, please let me know.
Thank you all for the awesome library!
EDIT:
After some more digging, I found out that my implementation should be:
  post("/upload") { request: Request =>
   // where `fromRequest()` is my version of `FinagleRequestFileUpload.parseMultipartItems()`
    val map: Map[String, MyMultipartItem] = new MyRequestFileUpload().fromRequest(request)
  }

Now, the hard part... how to properly turn this into a stream  🙃
EDIT 2:
Maybe best to use this Netty 4 example for inspiration

@baughmann thanks for the issue. Have you taken a look at the Streaming documentation?
https://twitter.github.io/finatra/user-guide/http/streaming.html
We can probably do some more work to document and tie things together, but I believe you just want a Reader[Byte] or use a StreamingRequest.

@cacoco Thanks for your reply.
Yes I did, and in fact that was my first attempt. I was unable to successfully implement it, probably due the lack of familiarity I highlighted in my OP.
Yes, more documentation, or even just a brief and incomplete example, would certainly be appreciated. Do you have anything that might be able to serve as such an example?

Hi @baughmann , it seems finatra currently doesn't have the multipart requests supporting streaming. Right now the parseMultipartItems only parse the fully buffered requests. I think we might be able to let parseMultipartItems parse streaming requests as well, when request.isChunked, deal with request.reader. Let us know if you want to look into this support.

@yufangong I sure can! I had actually been playing with that idea of taking some features from this Netty 4 example.
I cannot promise that it will be quick, but it seems as though demand for this is limited for the time being. I'll post back here when I have implemented something.

It looks like it's gonna be a while longer. I still have the original need outlined in this post, but it's kinda gotten pushed down the priority list.


Cake's default tools / addins / modules paths are not so default as they seem.

What You Are Seeing?
Cake ist installing addins / tools and modules not relative to the build script.
What is Expected?
Cake should install addins / tools and modules relative to the build script - per default configuration.
What version of Cake are you using?
16.0.2
Are you running on a 32 or 64 bit system?
64 bit
What environment are you running on?  Windows? Linux? Mac?
Windows
Are you running on a CI Server?  If so, which one?
No
How Did You Get This To Happen? (Steps to Reproduce)
$> cd C:\
$> New-Item -Type Directory repo
$> cd repo
$> nuget install Cake -ExcludeVersion -OutputDirectory .\tools\foo
$> "#addin Cake.FileHelpers" > cake.build
$> .\tools\foo\Cake\Cake.exe .\cake.build
$> ls .\tools

    Directory: C:\repo\tools

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       04.11.2016     17:06                foo

$> ls .\tools\foo

    Directory: C:\repo\tools\foo

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       04.11.2016     17:07                Addins
d-----       04.11.2016     17:07                Cake

What is Expected?
$> ls .\tools

    Directory: C:\repo\tools\foo

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       04.11.2016     17:07                Addins
d-----       04.11.2016     17:07                foo

As already noted in the PR, only the addins folder was affected.

fixed by #1348

I'm trying to change the cake tools folder. I've changed this line in my build.ps1 to point to a cake-tools folder:
$TOOLS_DIR = Join-Path $PSScriptRoot "cake-tools"

However, NuGet addins are still downloaded to a tools folder. Will this PR fix that?

Cake's default folders can be changed thru configuration, read more about it at
http://cakebuild.net/docs/fundamentals/configuration
You can read more about the default values and how to override then at
http://cakebuild.net/docs/fundamentals/default-configuration-values


[FLINK-26851][metrics] Properly model reporter options as ConfigOptions

The first commit extends the SuffixOption to include a key prefix that is also written into the generated html file.
This allows us to use the same file for documenting the fully-qualified option (prefix + suffix) or just the suffix option (e.g., as a list of parameters that a reporter accepts).
The second commits consolidates generic reporter options as ConfigOptions in the MetricOptions. The previously used ConfigConstants have been deprecated.

Btw, @zentol the failure seems to be related to https://issues.apache.org/jira/browse/FLINK-26721

@flinkbot run azure


Update the run command to refer to pod creation

The "run" command refers to deployment creation and it should refer to pod creation

/check-cla

/assign @xiangpengzhao

Thanks.
/lgtm
/approve


Document elemental-operator and elemental-ui upgrade procedure

@aalves08 - can you provide some input on how to upgrade elemental-ui please ?

Hi @kkaempf .
What do you mean by how to upgrade elemental-ui?  Installing a newer version of the extension?
If so, you just go to the Extensions main menu entry in Rancher Dashboard -> go to the Updates tab -> click on the Update button on the card for the extension you want to upgrade -> Opens a new modal (by default it selects the latest version) and click install

Is this it? Thanks 🙏

Closing as we have operater in the marketplace now


Add alternative way to get install path

moving the install location by hand breaks the registry entry,
this commit fixes wishing well for users with this issue
by getting the install location from a running genshin process.
this adds the dependency "psutil".

I appreciate the PR, but I'm not going to merge it. First, I would rather not add more third party dependencies if it can be avoided. Also, I feel like manually moving the game someplace else is not something people usually do. I suppose I could consider pulling the location from the game's log file instead, like paimon.moe does it. But I think pulling it from the registry is fine.


Cookie::queue() not working

Laravel Version: 10.0.3
PHP Version: 8.2.1
Database Driver & Version:

Description:
Cookie::queue() it not working as intended.
Steps To Reproduce:
Route::get('/set', function () {             Cookie::queue('test', 'foo', 10);         });
Route::get('/get', function () {             dd(Cookie::get('test'));         });
/get endpoint return null on cookie value after set.
The cookie value is set in plain text, not encrypted.

Works for me on a fresh Laravel v10 install.

@driesvints  I have manage to pinpoint my particular issue, and reproduce it even on a fresh install.
Try add a throttle to the web group in kernel.
If the throttle is added as the first middleware in the group, you will reproduce the problem. If you add it after the EncryptCookies middleware, looks ok.

@AlinIonut can you try a support channel first please?

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC


Microsoft Login issue

After applying the STIG's, I've been unable to get Windows Update, Microsoft Store, or Office logins to connect. It seems like it is unable to connect to any Microsoft servers it needs to.  I've done some Googling and extensive testing with a test machine to narrow it down that a STIG requirement is breaking the connection.
Before I go through each STIG to figure out what is breaking it, I was wondering if anyone knows which STIG would be the culprit.
Thanks for your time!

I believe one of your issues is a CAT 3 control WN10-CC-000206 for the updates.

Thank you for the response!
I looked up your suggestion and it seems to have had no effect.
I will continue going through one by one and hopefully get it resolved.
Thank you again!

Just wanted to update this. After combing through the STIG's, it was found to be V-220805 version WN10-CC-000052.
Solution:

Open regedit
Make a backup of keys if necessary
Registry Path: HKLM\SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002
Delete Value Name: EccCurves
Reboot

I believe the value for EccCurves could also be modified to work, but haven't had a chance to test that yet.

Thanks for the feedback and i will also take a look at this as well.


I hope you to provide the final model for AFEW

Hello , Thanks for sharing updates on Emotion-FAN! I am studying FER and I was impressed by your paper.
I am trying to make demo system using your model, but failed to find the final trained model for AFEW8.0
I just found the weights of Resnet18_FER+_pytorch.pth.tar  and Resnet18_MS1M_pytorch.pth.tar which seems baseline trained model. I want to use your final model to produce a demo for my test. can you provide it?
Thanks so much!

hello , i also studying video-based FER and i am try to train this model on AFEW8.0 datasets, but it always overfiting . DId you get the final parameter? or you have any suggestion about that.
Thanks so much!

Unfortunately, I could not find the solution for AFEW. However, I found out other trained weights are working so well in real time condition, I utilized Resnet18_FER+_pytorch.pth.tar and Resnet18_MS1M_pytorch.pth.tar instead.


Feature request: Multiple connections

Hello,
Can you please add the option to have multiple connections? So we can quickly check multiple hosts?
Best regards

+1
/


Update the doc for Performance/Count

This pull request improves the doc for Performance/Count .

Removed almost duplicate sentences (left the latter one only):

ActiveRecord's count ignores the block that is passed to it.

ActiveRecord will ignore the block that is passed to count.

Added Rails version that fixed the described count method issue. Since it has been fixed in 2016, newer Rails users will not encounter this issue.

Fixed ActiveRecord::Relation#count to use Ruby's Enumerable#count for counting records when a block is passed as argument instead of silently ignoring the passed block. (Pull Request)

https://guides.rubyonrails.org/5_1_release_notes.html

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Can you squash your commits into one?

Thank you for your reviewing!
I squashed the commits and discarded the change of adoc file.


bug fix 819

…'url']['urls']['expanded_url'] arrays first element

fixes https://github.com/wevote/WeVoteServer/issues/819

👍


Make Counting Students easier

Support for #151
Need to make Students countable by sponsored event.

done,  but needs removing Old Sponsor References!


PNG output file is heavier than PNG input

Hi there, first of all thanks for developing and maintaining this awesome open source project. 🙏🏼
I noticed that sometimes after the resizing the PNG output file is actually larger than before.
For example:
Input - 2.5 MB png:
https://dv0xp0uwyoh8r.cloudfront.net/stacks/bbe18111-3568-42ca-93f6-830cab15cb5c/media
Output - 4.4MB png:
https://wsrv.nl/?output=png&url=https://dv0xp0uwyoh8r.cloudfront.net/stacks/bbe18111-3568-42ca-93f6-830cab15cb5c/media
I dont know what kind of png compressions are available that could help here, but it feels somewhat like a bug that the output is like 56% larger.
Thoughts?

Sorry about that, I didn't realize the input file is actually a jpeg! I should've tripled checked first :) closing

FWIW, https://wsrv.nl/docs/format.html#adaptive-filter could be helpful in this case. With that, the image in question is  3.2MiB in size.

thats great to know, thank you!