Hide buttons on smaller screens (mobile).

See #140, we might want to also add a warning dialog from Javascript as well in a subsequent PR.

Thanks!

Should we put this behind a jupyterlite-sphinx flag?

I don't think we should this can always be overridden with custom css, the same way we can change the buttons colors or position on the page.

Ok, sounds good!

@martinRenou After this gets in, can we do a new release?

Sure thing! You should have the rights to make releases. Feel free to make it if you want!
To do this you need to go at the Actions tab of the repo, then manually trigger the Step 1: Prep Release. This should publish a draft release in https://github.com/jupyterlite/jupyterlite-sphinx/releases once done. Then you can manually run the Step 2: Publish Release to finalize it.

Thanks @martinRenou! That's very convenient. I'll make one after things get settled.

It seems that the button is not hidden on my phone when I hold it horizontally

but is hidden when held vertically

@Carreau, could we use javascript to conditionally hide the button based on the area of the screen? Or would it be better just to use plain css and hide based on max-width and max-height? Also, should we take tablets into account?

Also, should we take tablets into account?

Often tablets will be used in school/university settings where it would be helpful to be able to try the code. It is a shame there is no "low data connection" indicator, this seems like it should be a solved problem.

Is it possible to, instead of tinkering with screen sizes, retrieve at the device settings and warn users with a pop-up / differently-coloured ~or greyed-out~ button that using the kernel will be slower on mobile devices?

Also, should we take tablets into account?

Often tablets will be used in school/university settings where it would be helpful to be able to try the code. It is a shame there is no "low data connection" indicator, this seems like it should be a solved problem.

@Carreau mentioned navigator.connection here which should work in principle, but isn't available on ios safari.. It seems like they don't want to implement it because of privacy concerns. This issue, https://bugs.webkit.org/show_bug.cgi?id=185697, has been open for almost 6 years now.

Is it possible to, instead of tinkering with screen sizes, retrieve at the device settings and warn users with a pop-up / differently-coloured ~or greyed-out~ button that using the kernel will be slower on mobile devices?

Not sure. I think the issue of having a pop-up or changing the color of the button is orthogonal to detecting if we're dealing with a device using mobile data. @Carreau mentioned adding a warning dialogue with javascript, so I think that is the plan eventually. I don't know much about web dev, so I'm not sure what you mean by retrieving at the device settings. Based on the research I've done this morning, I think the only things we have to go on are the user agent, screen width, screen height, and on some platforms navigator.connection.  We could probably come up with a good heuristic that takes all of these things into account, but for now its probably best to start simple.

we can likely implement a dialog we a "don't ask me again", and tweak the logic of when to show it later.

@martinRenou, it seems like I might not have the right permissions to make a release. I tried running the Step 1: Prep Release action like you described above, and the action failed. The logs say
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/actions/common.py", line 19, in setup
    return prepare_environment(fetch_draft_release=fetch_draft_release)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/util.py", line 618, in prepare_environment
    raise RuntimeError(msg) from None
RuntimeError: Could not get user permission level, assuming user was not admin!

@steppi can you try again?

It worked this time. Thanks!

@martinRenou, I just selected the default options, which created release 0.11.1, but I think this makes more sense as an 0.12.0, since there were a number of enhancements, and having the TryExamples directive no longer work on small screens could be seen as backwards incompatible.

Right, you can remove the release draft in https://github.com/jupyterlite/jupyterlite-sphinx/releases. Then I believe you can rerun with the version specifier "minor".

Yay!! Thanks for the release!!


NTI: Cannot extend class Foo and implement interface Foo.Bar

repro
class Foo {}
/** @implements {Foo.Bar} */
class Baz extends Foo {}
/** @record */
Foo.Bar = class {};

returns a cryptic error:
WARNING - Expected interface name but found Foo.Bar.
Foo.Bar = class {};
          ^^^^^^^^

As an extra data point, if I move the @record definition above the subclass, it works.  But the error also goes away if anything else is removed - i.e. if Bar is top-level rather than nested under Foo, of if Baz doesn't extend Foo.  So it's clearly legal for an interface definition to be below the @implements tag, but it causes problems in this case.  Maybe the fix is to just change the error message to more clearly say "don't use the interface before you define it", but in that case we should also enforce it for the other cases as well.


Remove babel from build configuration

Closed by https://github.com/vslinko/ripster/commit/19cb7f7002fed742120f10ebc54be69ce9b1222b


⚠ Bofrost.fr has degraded performance

In 70c2846, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1033 ms

Resolved: Bofrost.fr performance has improved in 0fcf897.


Unable to setup CoroutineLaunchedInTestWithoutRunTest rule

Expected Behavior
The following YAML configuration should enable the CoroutineLaunchedInTestWithoutRunTest rule:
coroutines:
  active: true
  CoroutineLaunchedInTestWithoutRunTest:
    active: false
  # ...

Observed Behavior
Enabling the CoroutineLaunchedInTestWithoutRunTest rule with the same YAML config as in here
https://github.com/detekt/detekt/blob/f8bf79b24baebd10fda01ffe2ef586cf8bc1fff1/detekt-core/src/main/resources/default-detekt-config.yml#L177
produces the following error:
Property 'coroutines>CoroutineLaunchedInTestWithoutRunTest' is misspelled or does not exist

The rule is pretty new
Steps to Reproduce
Happens both on v1.23.5 and v1.23.6
Your Environment
Detekt dependencies in use in libs.versions.toml:
[versions]
detekt="1.23.6"

[libraries]
detekt-api = { module = "io.gitlab.arturbosch.detekt:detekt-api", version.ref = "detekt" }
detekt-formatting = { module = "io.gitlab.arturbosch.detekt:detekt-formatting", version.ref = "detekt" }
detekt-test = { module = "io.gitlab.arturbosch.detekt:detekt-test", version.ref = "detekt" }

[plugins]
detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }

That's because the rule is available only on main and hasn't been released yet: f8d0942

Thanks for your answer @cortinico. I'm having a hard time at understanding why this rule is not already released, as PR #6692 was merged to main on Jan 26th and the latter release branch was created on Mar 25th
Can you help me understand this?

and the latter release branch was created on Mar 25th

Because the 1.23.x release are happening from the release/1.x branch: https://github.com/detekt/detekt/tree/release/1.x


[fix][broker] Log pulsar service config except sensitive info at startup

Motivation
Printing service configuration at startup can help us effectively troubleshoot problems, but after #14421, the configuration at startup is no longer displayed.
According to the analysis, #14421 is mainly to avoid printing private information, such as passwords, rather than the entire configuration
Modifications
Log pulsar service config except sensitive info at startup
Verifying this change

[x] Make sure that the change passes the CI checks.
[x] This change is a trivial rework / code cleanup without any test coverage.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

rerun failure checks

rerun failure checks

/pulsarbot rerun-failure-checks

@AnonHxy @codelipenghui This pr passes all the tests in my repo. Please have a look if you have time. Thanks

Codecov Report

Merging #18179 (228965c) into master (6c65ca0) will increase coverage by 35.65%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #18179       +/-   ##
=============================================
+ Coverage     34.91%   70.56%   +35.65%
+ Complexity     5707      437     -5270
=============================================
  Files           607       26      -581
  Lines         53396     2246    -51150
  Branches       5712      245     -5467
=============================================
- Hits          18644     1585    -17059
+ Misses        32119      489    -31630
+ Partials       2633      172     -2461

Flag
Coverage Δ

unittests
70.56% <ø> (+35.65%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...java/org/apache/pulsar/proxy/stats/TopicStats.java
58.82% <0.00%> (-41.18%)
:arrow_down:

...pache/pulsar/proxy/server/ProxyServiceStarter.java
60.66% <0.00%> (-1.34%)
:arrow_down:

...a/org/apache/pulsar/proxy/server/ProxyService.java
80.00% <0.00%> (-0.94%)
:arrow_down:

...apache/pulsar/proxy/server/DirectProxyHandler.java
63.63% <0.00%> (ø)

...apache/pulsar/proxy/server/ParserProxyHandler.java
91.86% <0.00%> (ø)

...ache/pulsar/proxy/server/BrokerProxyValidator.java
89.15% <0.00%> (ø)

...sar/proxy/server/TargetAddressDeniedException.java
100.00% <0.00%> (ø)

...in/java/org/apache/pulsar/PulsarBrokerStarter.java

.../org/apache/pulsar/PulsarClusterMetadataSetup.java

...g/apache/pulsar/PulsarClusterMetadataTeardown.java

... and 579 more


UP-4761: Label inputs in password manager portlet - master

https://issues.jasig.org/browse/UP-4761
Issue
This form field should be labelled in some way. Use the label element (either with a "for" attribute or wrapped around the form field), or "title", "aria-label" or "aria-labelledby" attributes as appropriate.
When a form control does not have a name exposed to assistive technologies, users will not be able to identify the purpose of the form control. The name can be provided in multiple ways, including the label element. Other options include use of the title attribute and aria-label which are used to directly provide text that is used for the accessibility name or aria-labelledby which indicates an association with other text on a page that is providing the name. Button controls can have a name assigned in other ways, as indicated below, but in certain situations may require use of label, title, aria-label, or aria-labelledby.
This text input element does not have a name available to an accessibility API. Valid names are: label element, title attribute.
Code Snippet
<input name="attributes['title'].value" value="Portal Administrator" class="form-control">

... all instances of text inputs.
Resolution
Update preferenceInput.tag to support ids and add <label>s.

Coverage increased (+0.004%) to 22.995% when pulling 388f92d719aee1f6706efea756eed5238aadbce5 on ChristianMurphy:UP-4761-label-inputs-password-manager-master into 8ade061db9601de6b32f65ea039e65b929832d65 on Jasig:master.


Repetitive Keyframe Declarations

Hi Dan, I tested these and they work. Did you know that you can place different easing properties within each @keyframe declaration? Allows for some pretty fine-tuned animation. Thats the next thing I'll be fine-tuning
:)

Great job dude. I look forward to more! =)


Plyr

Switched from VideoJS to Plyr

Fixed DASH playback
Improved YT support

Cleaned up source API

Updated ytsr
Improved DASH detection

LGTM (bypass branch protections)


Marker custom styles ignored in iOS

I'm submitting a ...  (check one with "x")
[ ] question
[ X] any problem or bug report
[ ] feature request
plugin version:  (check one with "x")
[ ] 1.4.x
[ X] 2.0.0-beta3
cordova information:  (run $> cordova plugin list)
cordova-plugin-googlemaps 2.0.0-beta3-20170803-1233 "cordova-plugin-googlemaps"

Current behavior:
Custom styles for Marker windows are not getting applied in iOS. Issue related to any style added.
Expected behavior:
Custom styles get applied to the Marker window.
Steps to reproduce:
Add a custom styles to the marker, e.g. 'text-align': 'center'
map.addMarker({
            'position': new plugin.google.maps.LatLng(43.230293, -87.984200),
            'disableAutoPan': true,
            'title': 'Test Marker',
            'styles': {
                'text-align': 'center'
            });

The problem is the property marker reference. The properties key for the dictionary is looking for the key:
"marker_property_6180629808" =     {
        disableAutoPan = 1;
        styles =         {
            "text-align" = center;
        };
    };

but the objects dictionary only has a key for
"marker_property_marker_6180629808" =     {
        disableAutoPan = 1;
        styles =         {
            "text-align" = center;
        };
    };

If I make these changes the issue is fixed.
// GoogleMapsViewController.m

// replace references of
NSString *markerPropertyId = [NSString stringWithFormat:@"marker_property_%lu", (unsigned long)marker.hash];

// with
NSString *markerPropertyId = [NSString stringWithFormat:@"marker_property_%@", marker.userData];

and
// PluginMarker.h

// replace references of
NSString *propertyId = [NSString stringWithFormat:@"marker_property_%lu", (unsigned long)marker.hash];
// with
NSString *propertyId = [NSString stringWithFormat:@"marker_property_%@", marker.userData];

The key with double "marker" in the name seems wrong to me, but it could be needed for some of the references to clustering i see. I can submit a pull request for the above fixes if thats how you want it fixed.

Thank you for letting me know, and your inspection.
The plugin does not use the marker.hash anymore, but it seems there were still remained.
So I replaced all marker.hash with marker.userData.


Fix IndexSet intersection and symmetric difference [SR-1818]

What's in this pull request?
Previously, IndexSet.isStrictSubset(of:) was found to emit incorrect results. Namely,
IndexSet([0,2]).isStrictSubset(of: IndexSet([0,1,2]))

evaluates to false. This issue arises from how the private helper type IndexSetBoundaryIterator has been implemented, causing IndexSet.intersection() to start and end intersecting ranges incorrectly with certain inputs.
This PR modifies that type to always return lower bounds or one-past-the-end upper bounds, then corrects the implementation of IndexSet.intersection() and IndexSet.symmetricDifference() to start and end ranges correctly for all (valid) inputs. The result initially reported to be incorrect is consequently fixed.
Additional tests have been added for intersection() and symmetricDifference().
Resolved bug number: (SR-1818)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@phausler @parkera Since you guys commented on the bug or have worked on IndexSet, would you mind reviewing?

Thanks! I'll take a closer look today.

@swift-ci please test

OS X failure seems unrelated?

Agreed. Thanks for your work on this @xwu .


Some tweaks to bot behavior.

desire: disable hunting desires if bots are now vip or have hostages.
bot: disallow item acquisition if we have a visible enemy.

desire: disable hunting desires if bots are now vip or have hostages. bot: disallow item acquisition if we have a visible enemy.


api/client/restart.go:Fix a typo in comment

The current comment is wrong and misleading.
close #15849
Signed-off-by: Yingqian Hu<EMAIL_ADDRESS>

LGTM, good catch!

LGTM


Windows compatibility

As far as I can tell your tool works wonderfully on windows as well, the only change necessary is to add the .exe extension to the file names in the get_rm_root method (rm_load.js).

I thought it might be good to let you know so you can maybe add this information to the readme.
Thanks for this useful tool.

Thank you so much for the information! I've pushed a change that should hopefully address this so it will work without modification.


being able to compile - almost out of the box.. feedback about my troubles with Xcode

it might be of use for someone also doing a first compile attempt following the steps in Build.md
When doing so with Xcode.. step by step as written
in Build.md is something written to compile glm first. That left me confused, i was searching for a folder according to the text to compile before i start. Turns out glm seems to be MGL which is the project target.. so i assumed glm==MGL and hmm i was right, i hope.  But first the other 3 issues found..
#include "spirv.h" was missing. so i dropped that file into the workspace MGL>SPIRV>SPIRV-Cross> folder making a reference for Xcode. Same for ...
#include "spirv_cross_c.h"
and short before the compilation would succeed it failed with missing symbols .. following the error message the symbol for
spvtools::val::RayTracingPass(... was missing.. which can only happen when the cpp file is not compiled at that stage.
turns out the function spv_result_t RayTracingPass(...) resides in validate_ray_tracing.cpp that had to be dropped manually to workspace MGL>SPIRV>SPIRV-Tools> and of course checkmarked for being part of the MGL target.
from there it compiled like a charm. Now sipping coffee and testing.. cheers

testing. tiny trouble shoot..
after fixing all developer ID issues via setting all libraries (MGL & GLFW) to Sign to run locally in Build Settings (in other words erasing/replacing the ID of the repository creator) they properly compile.
doing all this on a Xcode with 10.14.6 i had to switch all related library projects to compile for 10.14 first (both MGL & GLFW) to be able to run test_mgl_glfw (same for this test application) which then runs obviously as intended pretty well. Searching for some OpenGL framework linked - kidding! Of course i did not find such link.. exciting..
i thought i will be showerd with error messages, but nooo - amazing work. Really good!

it might be of use for someone also doing a first compile attempt following the steps in Build.md
When doing so with Xcode.. step by step as written
in Build.md is something written to compile glm first. That left me confused, i was searching for a folder according to the text to compile before i start. Turns out glm seems to be MGL which is the project target.. so i assumed glm==MGL and hmm i was right, i hope. But first the other 3 issues found..
#include "spirv.h" was missing. so i dropped that file into the workspace MGL>SPIRV>SPIRV-Cross> folder making a reference for Xcode. Same for ... #include "spirv_cross_c.h"
and short before the compilation would succeed it failed with missing symbols .. following the error message the symbol for spvtools::val::RayTracingPass(... was missing.. which can only happen when the cpp file is not compiled at that stage. turns out the function spv_result_t RayTracingPass(...) resides in validate_ray_tracing.cpp that had to be dropped manually to workspace MGL>SPIRV>SPIRV-Tools> and of course checkmarked for being part of the MGL target.
from there it compiled like a charm. Now sipping coffee and testing.. cheers

Ah the build instructions in the README are outdated. BUILD.md does not mention glm.
Updated instructions from BUILD.md:

Open the xcodeproj and build any of:

MGL: produces libMGL.dylib
GLFW: produces libMGL.dylib and a patched GLFW that uses MGL.
test_mgl_glfw: runs the tests

If you get errors such as No account for team "..." open the affected target and in the Signing and Capabilities tab select the correct team.
If there is no Signing and Capabilities tab open Build Settings, search for "signing", and select the correct team in Development Team.


Fixed and improved ./configure on Windows

Make the script work with path containing spaces (If users install python by Anaconda, the python path will probably contain space)
On Windows, disable bazel clean --expunge(it's broken)
Create junctions instead of copying python lib, include, numpy folders
fixed symlink creation in gen_git_source.py with python 3.5

Can one of the admins verify this patch?

@mrry Yes, I think it's a good idea to use is_windows to opt out GCP, HDFS, CUDA support on Windows for now.

@rohan100jain For example, if users install python using Anaconda(which is recommended in CMake build), the python path will probably contain spaces like this C:\Program Files\Anaconda3\lib\site-packages, so we have to add quotes to the variable.

@mrry Thanks for catching so many typos.. Please review again. :)

@tensorflow-jenkins test this please.

@tensorflow-jenkins test this please.

@tensorflow-jenkins test this please

The configure script does cause a bug on Mac, I'll look into it.

read -r -a python_lib_path <<< $(python_path) doesn't really split the string into a bash array on OSX, so switch to another way.
Please test again! :)

I install the tensorflow on windows via the cmake/README. It seems everything goes well. And after I "activate tensorflow" and "import tensorflow as tf". It says "No module named 'tensorflow'" . I do not know how to fix it.

@tensorflow-jenkins test this please.

Great, looks like I fixed it!


Adapt uninitialized_value_construct and uninitialized_value_construct_n to C++ 20

Adapted uninitialized_value_construct and uninitialized_value_construct_n to C++ 20 and added container overloads. (range and sentinel). Added container tests.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668

retest

launch perftests

retest

PR Merge order :- uninitialized_default_construct -> uninitialized_value_construct -> uninitialized_copy -> uninitialized_fill


Bump event-target-shim to v6.0.2.

Summary:

The version of event-target-shim is old,
If you are using a dependency that uses event-target-shim (ex: react-native-webrtc, @livekit/react-native-webrtc), the versions may not match and an error may occur in one of them at runtime.
The reason for this is that the version of event-target-shim used in react-native is v5.0.1, an older version, and is not compatible with v6.0.2, which is used in react-native-webrtc, etc.
Therefore, it upgrade event-target-shims used in react-native to v6.0.2.
I referred to the event-target-shim migration guide below for upgrade instructions.
https://github.com/mysticatea/event-target-shim/blob/master/docs/migrating-to-v6.md
Changelog:

[GENERAL] [CHANGED] - Bump event-target-shim to v6.0.2.
Test Plan:

I confirmed that the react-native application created with npx react-native@latest init TestProject starts correctly.
I included a dependency using event-target-shim of v6 or higher in the TestProject and confirmed that the react-native application started correctly. Specifically, I incorporated the code described in the README below using @livekit/react-native and @livekit/react-native-webrtc into the application and confirmed that it worked.
https://github.com/livekit/client-sdk-react-native

@dmytrorykun My apologies.
We found that event-target-shim also depends on abort-controller, including the point where the test fails.
The point that abort-controller has not been updated since 2019 (not maintained?) makes it hard to expect a fix for abort-controller, so a simple update of event-target-shim could cause major problems.
Issues related to this were also discussed in the following react-native-webrtc issue
https://github.com/react-native-webrtc/react-native-webrtc/issues/1466
Therefore, we felt that a simple solution would be difficult to achieve.
I would like to close this PR and create a separate issue or PR if necessary.


[solved] Can no longer authenticate to Gmail May 1 2021

Backup can no longer connect to Gmail.   I tried to disconnect and reauthenticate but get a message:
This app is blocked.
This app tried to access sensitive info in your Google Account.  To keep your account safe, Google blocked this access.
Are we able to set up an application password?
Hopefully this will get sorted out.   Has been a great app!

I have this issue as well, and my Ggl security settings do not give me an option to add an app password for SMSbackup+.
I do NOT have 2-factor enabled.
Is there another way to enable SMSbackup+ ?

Your problems are most likely due to a restriction that Google applied in June 2019. There are other issues that cover the problem extensively. See those issues for full details but essentially, the solution involves using an app password and IMAP.
Please checkout the other issues and consider closing this one if you find what you need.

I have this issue as well, and my Ggl security settings do not give me an option to add an app password for SMSbackup+.
I do NOT have 2-factor enabled.
Is there another way to enable SMSbackup+ ?

Something happend on May 1st.  Google changed something.  (Maybe only for Google workspace??) But otherwise I was able to get it going again with an app password.  You have the option of adding an app password in the advanced settings/Custom Imap server.   You need to enter imap.google.com:993 for the server and your email as username.  Enter the app password as you IMAP password.   Set security to TLS.

@ajhepple - thanks for info, i was reading post #970 but I wasn't able to set up app passwords in Gmail.  It turns out that this option is only available if 2-factor authentication is on.
@boydkelly - thanks for the details, exactly what I needed once 2factor was set up in Gmail.  One minor correction - it's imap.gmail.com (not google)
All working for me now.
A link to #973 should really be in the readme.md because this issue will affect all new users and installs on new devices and it's a showstopper.

I have this issue as well, and my Ggl security settings do not give me an option to add an app password for SMSbackup+.
I do NOT have 2-factor enabled.
Is there another way to enable SMSbackup+ ?

Something happend on May 1st. Google changed something. (Maybe only for Google workspace??) But otherwise I was able to get it going again with an app password. You have the option of adding an app password in the advanced settings/Custom Imap server. You need to enter imap.google.com:993 for the server and your email as username. Enter the app password as you IMAP password. Set security to TLS.

Had to set up SMS Backup+ on a new Device (Pixel) and can´t get it running at all.
Settings as told, using app password but still get the message that boydkelly mentioned.
Until now it´s the 5´th device I want to using SMS Backup+ with but it seems the journey ends here... And the only feature I´ve used in the last years is the call log calendar intgration.

@MysticMagican I believe that if you are getting the "tried to access sensitive data" message then it is still trying to use XOauth.
I would suggest going through the setup again carefully step by step, and maybe clearing your app cache first (google how to do this on your phone).
When I go into SMSbackup+, the 'Connect' setting is greyed out (just under the [backup] and [restore] buttons) but it shows [myemail]@gmail.com@imap.gmail.com:993 which confirms I am connecting with imap and not XOauth.
You could also try the 3 dots in the top right and 'view log'.  If I do this then I can see that sometimes it fails to connect, but usually it works.

d
At start after fresh (1´st time on that device) under "Legacy settings" is "XOAuth2 is no longer supported" written. Authentication shows "plain text" (hope so, my device setting is german^^)
Connect button is greyed out too, but shows no account.
IMAP Settings says
Server adress : imap.gmail.com:993
User name<EMAIL_ADDRESS>Password : the app password as usual
Security : TLS
Cert : not checked

When I hit the "Connect" button, the pop up shows the radio button pre selected with my gmail-adress.
Hit ok and get the error message.
Do I have to change my user name to match your syntax?
And Log: Check boxes are active but if i want to se it, it says that it´s empty.
Sadly I havn´t a device in place anymore with running/working app.
And: the device now is again since 4 years one with 2 active SIM cards. I hope if I get it running, that I can adress this in the call log.

I believe you have to enable 2 factor.   Then you are good to go.
On Tue, 4 May 2021 at 11:24, mjxyz @.***> wrote:

I have this issue as well, and my Ggl security settings do not give me an
option to add an app password for SMSbackup+.
I do NOT have 2-factor enabled.
Is there another way to enable SMSbackup+ ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jberkel/sms-backup-plus/issues/1061#issuecomment-831868538,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2BH3BRDIGJESQMDXHZESLTL7KONANCNFSM436HBWAQ
.

--
Boyd Kelly @.***>
www: http://www.coastsystems.net
Tel: +1<PHONE_NUMBER>

The app worked GREAT until today.  When I tried to setup my new Android 10 phone using the IMAP procedure and the same password that was working on my older Android 8 phone that would not work.  Then later I noted that the app is no longer working on my old Android 8 phone though I had not touched it.
SMS Backup+ did work on that old phone up until a few hours ago when I tried to use the same app on the new phone.  I have spent the whole morning working on this.  All attempts to get the app working again on the older Android 8 phone and the newer Android 10 phone have failed.   The app starts, but when I "Tap to connect to your Gmail account" the message says "This app is blocked. This app tried to access sensitive info in your Google Account. To keep your account safe, Google blocked this access."
When I try to setup using the IMAP servers that did work in 2019, and continued to work up until today, that also fails.
If you are reading this, it is probably too late... but it appears that the app will continue working on your phone unless you make ANY changes at google.com or try installing the app on a new phone.

Once you set up two factor authentication, then it will work with the app
password obtained from:
https://support.google.com/accounts/answer/185833?hl=en
On Mon, 24 May 2021 at 15:52, CharlesBMiller @.***>
wrote:

The app worked GREAT until today. When I tried to setup my new Android 10
phone using the IMAP procedure and the same password that was working on my
older Android 8 phone that would not work. Then later I noted that the app
is no longer working on my old Android 8 phone though I had not touched it.
SMS Backup+ did work on that old phone up until a few hours ago when I
tried to use the same app on the new phone. I have spent the whole morning
working on this. All attempts to get the app working again on the older
Android 8 phone and the newer Android 10 phone have failed. The app starts,
but when I "Tap to connect to your Gmail account" the message says "This
app is blocked. This app tried to access sensitive info in your Google
Account. To keep your account safe, Google blocked this access."
When I try to setup using the IMAP servers that did work in 2019, and
continued to work up until today, that also fails.
If you are reading this, it is probably too late... but it appears that
the app will continue working on your phone unless you make ANY changes at
google.com or try installing the app on a new phone.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jberkel/sms-backup-plus/issues/1061#issuecomment-847141915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2BH3ANZQBIJ6GXEO5ZPVTTPJY3DANCNFSM436HBWAQ
.

--
Boyd Kelly @.***>
www: http://www.coastsystems.net
Tel: +1<PHONE_NUMBER>

Sorry, but that is a no-go and enabling two-factor does NOT work.
Your advice was correct in 2019 but no longer.  It appears that so long as you make no changes to your "app passwords" in your Google account then SMS Backup+ will continue working... but as soon as you make any changes the app will stop working on all devices and it cannot be reactivated.

p.s. boydkelly
Thanks for your suggestion.  I respectfully urge you not to try testing it yourself.  I suspect you will find as I did that once Google kills your connection with the app that you can never start it again.

No that is not the case.  My connection was toasted with the message you
describe.  But using the app password fixed the issue.  On May 1st. Set up
2 factor authentication.  Get an app password and enter it as described
above.
On Mon, May 24, 2021, 16:40 CharlesBMiller @.***> wrote:

p.s. boydkelly
Thanks for your suggestion. I respectfully urge you not to try testing it
yourself. I suspect you will find as I did that once Google kills your
connection with the app that you can never start it again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jberkel/sms-backup-plus/issues/1061#issuecomment-847182986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2BH3DCXI22FP7YE7OVRHTTPJ6OHANCNFSM436HBWAQ
.

Don't get me wrong; I really want this to work, but it does not.  I have tried multiple times on two different phones, using the procedure described here and which DID work for me in 2019.  Google has changed something.  Or is it possible that only one phone can be used on an account, even if they have separate app passwords?

@CharlesBMiller - I have got this to work on a brand new phone in the last 6 month.  I DID have to enable 2-factor authentication, and I DID have to create a new app password specifically for SMSbackup+ and the new phone.  And then in SMSbackup+ I have to choose Advanced settings | Custom IMAP server | imap.gmail.com:993 for the server and<EMAIL_ADDRESS>as the IMAP account/e-mail address.  Enter the app password as your IMAP password. Set security to TLS.
(If I install SMSbackup+ on a different phone that will require another app password to be generated in my Security settings in my Google (not gmail) account).
Refer to post #970 as well

SOLVED!  Setting up a new phone using the same Google Account as an existing phone requires avoiding the message that says "This app is blocked. This app tried to access sensitive info in your Google Account. To keep your account safe, Google blocked this access."  If you encounter that message, several things seem to happen when Google blocks access:

The copy of the SMS Backup+ app you are installing will never connect to the IMAP server.
The copy of SMS Backup+ installed on the old phone will also stop working and will never again connect to the IMAP server, even though it was working fine before you encountered the message while installing on the other phone.
The app passwords created for use with SMS Backup+ are apparently blocked and can no longer be used.

After several frustrating hours the following procedure fixed this for me:

Uninstall SMS Backup+ from both the old phone and the new phone.
You should already have two-factor authentication enabled in your Google Account if you have previously use the IMAP procedure.  Likewise, you should already have IMAP enabled for your @gmail address.
Erase the app passwords created for SMS Backup+ in your Google Account.
Create new app passwords to use when you reinstall SMS Backup+.
Go to the PlayStore to download and install SMS Backup+.
Start SMS Backup+ / Advanced settings / Custom IMAP Server / Authentication.
Choose "Plain Text"
Enter your @gmail address.
Enter the app password you created in your Google Account for SMS Backup+.
Security = TLS
I did not have to enter the server address "imap.gmail.com:993" as this populated automatically for me.
Tap on the "back" error twice.  The "Connect" field should be greyed out, but should be populated with "IMAP yourname@gmail.com@nul".  If not, you probably need to enter "imap.gmail.com:993" on the Custom IMAP Server page.
Repeat from step #4 for any other phones you are setting up.

If at any time you stumble into the message that says "This app is blocked. This app tried to access sensitive info in your Google Account. To keep your account safe, Google blocked this access" you are screwed!  That message kills SMS Backup+ on both phones.  For me it was necessary to go back to step #1 to reinstall both phones from the beginning.

I wonder if this is because the same "app password" is being used from multiple sources concurrently, tripping some sort of alarm for that password.
I would urge people to make a separate app password for each device.
If anyone else has this issue, then I would like to hear whether simply revoking the app password and creating new one(s) is sufficient.

No, simply revoking the app passwords and creating new ones was not sufficient.  Not until I uninstalled the app from the phones and reinstalled using the new passwords did I get this to work.

@CharlesBMiller Thanks for the update.
This begs the question of "how does Google know that this installation of this app is using that app password?"
It suggests that there is some communication occurring outside the actual IMAP session.

We all know browsers announce "user agent" plus a ton of other identifying information.  It does stand to reason that apps must also be doing this to some extent.
From time to time I test a connection to a mail server by using Telnet.  I have never been able to make that work with pop.gmail.com.  Maybe that is because Google first needs to query the app, and of course a terminal would not respond.  Who knows?

You have the option of adding an app password in the advanced settings/Custom Imap server. You need to enter imap.google.com:993 for the server and your email as username. Enter the app password as you IMAP password. Set security to TLS.

I did this and am still being prompted for a username and password. Now what?

CharlesBMiller May 25, 2021 post, which was marked "
SOLVED!" - worked for me.... EXCEPT it only restored 500 texts when there were many more backed up on the old phone. I wonder what happened!


No visual cue in activity log when a file share snapshot is being created. It only shows up when the snapshot is created

The lack of the visual cue led me to wonder if the file share snapshot is being created or not after i initiated the job.
The experience for upload/download where the activity log is immediately updated upon the start of the job gives the better visual cue and experience.

We have added the in-progress activity for creating share snapshot.


Review black-list issues on build-fontmetadata script

originally posted at:

https://github.com/googlefonts/fontbakery/issues/783
https://github.com/googlefonts/fontbakery/issues/1021
https://github.com/googlefonts/fontbakery/issues/704

All blacklisted fonts on fontbakery-build-fontmetadata.py have issues with the OpenType hinting tables that trigger the check at https://github.com/felipesanches/fontbakery/blob/06945641497a642422a101d904420fda3eca9815/fontbakery-build-fontmetadata.py#L588-L607
See issue #704. I attempted to remove each of the blacklisted fonts in order to replicate the problem that originally caused them to be blacklisted. But instead all of those were auto-blacklisted by the all-or-nothing hinting tables criteria described at https://github.com/googlefonts/fontbakery/issues/705#issuecomment-244800828.

@davelab6 edited this issue to consolidate tasks from the discussion below.

[ ] IOError: execution context too long (issue #703) - Padauk

[ ] IOError: execution context too long (issue #703) - KumarOne

[ ] ZeroDivisionError: float division by zero - AdobeBlank

[ ] ZeroDivisionError: float division by zero - Phetsarath

[ ] IOError: invalid reference (reference) - Corben

[ ] IOError: stack overflow on text_width, text_height = font.getsize(TEXT) - Rubik

to be done after merging #10

The two float divisions by zero error are AFAIK not part of the two fonts, but part of fontbakery's python code. Already wrote to @davelab6 a while ago.

In https://github.com/google/fonts/pull/1330 I think I spotted a problem where Marc said,

We need the metadata.pb file regenerated with googlefonts/tools:bin/gftools-add-font.py@master

And in response I said (unfortunately ambiguously)

Marc, why did you request this? Did a tool not pick it up?

(I was referring only to the metadata thing :)
So, we regenerate a METADATA.pb file using the add_font.py script, then the date-added will change incorrectly, as demonstrated in the Barlow PR.
I believe this was already corrected in this tool, which looks for an existing METADATA file and if found pulls in existing manual values.
This tool started life with Jeremie in 2009 when it generated JSON files, maintained by various fontbakery devs, and most recently was ported to the new protobuf format by Felipe. However when the GF eng team made the transition to protobufs, they wrote a new tool, which is the one Marc mentioned.
So, we should probably port the things in this script that are not in add_font.py to it.

This tool is long gone.


fix micrositeGithubToken config

I looked at the sbt-microsites docs and the only difference i noticed between what they suggest and what we have set up is the value for micrositeGithubToken is getEnvVar("GITHUB_TOKEN"). We have sys.env.get("GITHUB_TOKEN"). So changing to match what they have. If that doesn't work we can dig deeper.

@britneywright I already tried getEnvVar the other day, but that wasn't recognized as a command. 47deg/sbt-microsites lists it as a way to retrieve environment variables from Travis, but that's what sys.env.get should be doing.

So i think we did need to add something to the travis.yml to publish the docs. I was reading the sbt-microsites gitter and someone mentioned using Github4s and also referenced this line https://github.com/47deg/sbt-microsites/blob/master/.travis.yml#L43

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   93.76%   93.76%
=======================================
  Files         103      103
  Lines        4765     4765
  Branches       75       75
=======================================
  Hits         4468     4468
  Misses        297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d0395...742769b. Read the comment docs.


add tests for installer.sh with preview versions

Description
This is currently missing

Seems like it's already tested here https://github.com/kumahq/kuma-website/blob/master/.github/workflows/ci.yml#L114

Yep this is done


Natural Language Processing

Language Modeling (forgot the ref)
Natural Language Inference (PROGRESSIVE MEMORY BANKS FOR INCREMENTAL DOMAIN ADAPTATION)
Topic classification

Closed by #19


Consider adding dawnscanner

https://github.com/thesp0nge/dawnscanner

I think I will just document dawnscanner's results, without adding the tool itself.
Dawnscanner is not a bad tool.  However, it adds a huge number of dependencies to our development environment (if added to the Gemfile), and has a number of unfixed bugs that produce false positives.  Neither point is a killer, however, our existing tools brakeman, bundle-audit, secureheaders, and our session timeout seem to cover basically the same ground.  It certainly doesn't find any new problems in our program.  I tend to prefer using multiple tools (in case one misses something), but in this case I think we have reached the point of diminishing returns.


artoolkit border labeling mode implementation

Note: This is the same pull request as #711, adapted to new dev branch as per https://github.com/jeromeetienne/AR.js/pull/711#issuecomment-581479973 comment.
⚠ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠
What kind of change does this PR introduce?
New feature
Can it be referenced to an Issue? If so what is the issue # ?
https://github.com/jeromeetienne/AR.js/issues/599
How can we test it?
I've created a simple aframe example under aframe/examples/white-region-marker.html. Different markers can be created and tested using this tool (make sure to select markers have white borders option).
Summary
Connects the parameter settings for underlying ARToolKit's border labeling modes. (AR_LABELING_BLACK_REGION and AR_LABELING_WHITE_REGION). Border labeling mode can be set from scene in the same way as detection mode or matrix code types.
Markers with black borders does not perform well (or at all without a white buffer zone) when they are put over a black background like a dark desk. Markers with white borders (which are literally inverted markers) solve that issue (but similarly they don't perform well on white desks).
I have been regularly using these markers for the last year with an old modified version of AR.js, I've just seen the issue and wanted to contribute. So I've tested with many different devices.
Does this PR introduce a breaking change?
No, it is at the very surface, superficial change. Only code that have been implemented are assertions and parameter bindigns. Underlying ARToolkit connection and the code to change parameters was already written, just not connected to the aframe and three.js endpoints.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
OS: Windows 10
Browser: Firefox, Google Chrome
OS: Android 10
Browser: Chrome for Android
Other information

@umutto i tested your code, it works perfectly! @nicolocarpignoli Just one thought: Maybe we can add also a Three.js example?

Can you also add a renderer='precision: mediump;' in the <a-scene> aframe example? Because in some Mobile devices the mesh is displayed without color.
Thank you !

@kawalt Good to know about the renderer settings, added. Also can create a Three.js example if you want, it should pretty straight forward (just adding labelingMode: "white_region" parameter to ArToolkitContext constructor call).

@kawalt Good to know about the renderer settings, added.

yes, it is an issue with Adreno cpu. thank you for adding!

Also can create a Three.js example if you want, it should pretty straight forward (just adding labelingMode: "white_region" parameter to ArToolkitContext constructor call).

yes, you are right, it should be easy to do.

@umutto if you can add it, it will be great, thanks! let me know when you did

have tested and works perfectly! thank you!

@umutto @nicolocarpignoli nice feature indeed !


Whatsapp notifications don't go to conversation

When i click to a Whatsapp notification, it switch to whatsapp service but it won't open the conversation of the notification...
Anyone has this problem? I'm on MAC

Same here on 5.5.0

Any news on this ?

We are constructing the logic of the service, message, etc for the notification in the same manner for all services. If WA does not behave this way, then I think its a problem on the WA side as opposed to something that we can control.

Does anyone know if e.g. Rambox handles this correctly and jumps to the conversation of the notification? If not then we can close this since we can't control it.

I think it's a Whatsapp problem, I tried Rambox, Ferdi, and another one I did not remember now and neither goes to the message, only the WHATSAPP APP!

thanks for confirming @lupus2k - I will close this ticket now.


How do I use C buttons for the right analog stick?

For reference, I need to use this controller with a game I'm playing (https://retrofighters.com/our-collection/brawler64-nextgen-n64-controller-original-v2/), the USB version, and I can't seem to map the C buttons to the right analog stick. It only detects 1 direction at a time. Is there any way to fix this?

I'm having this problem too, though I'm using the v3 adapter. But it works with the rumble pack and would probably be nicer than Steam Input which sees the adapter twice, and player 1 is a version where none of the buttons work.


Watermark images presented in App

see SAG for example

Carlos is working on a solution to get the watermark text from the SAG webservice, this way the figures would have a consistent watermark across SAG and online advice.


Angular MSAL.js 2.0 B2C sample needs to call a B2C-protected API instead of MS Graph API

Please follow the issue template below. Failure to do so will result in a delay in answering your question.
Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[x]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Documentation location

[ ] docs.microsoft.com
[ ] MSAL.js Github Wiki
[ ] README file
[x] Other (sample in b2c-e2e-sample2.0 branch)
[ ] Documentation does not exist

Description
I'm working through an Angular setup with MSAL.js 2.0 and B2C for a client, and found my way to the angular10-browser-sample in this PR. First, thank you for all the great work on this! :) Second, can you provide some guidance on how to call a B2C-protected API from Angular in that sample? The sample currently has:
protectedResourceMap.set('https://graph.microsoft.com/v1.0/me', ['user.read'])

This doesn't work since B2C tokens can't be used to make MS Graph API calls. I tried setting up my own but the following doesn't seem to work correctly, and instead I get an infinite redirect loop with B2C and the app -- I'm guessing the app doesn't consider the signed-in user to have the required scopes? I did grant admin consent to the app and ensured that the redirect URLs are configured with SPA, and that the implicit grant is disabled.
protectedResourceMap.set('https://[myapi]/hello', ['https://[myb2ctenant].onmicrosoft.com/api/demo.read'])

@tnorling FYI.

I should add that this does work when using InteractionType.POPUP, but we need to get this working with InteractionType.REDIRECT so we can support Safari without telling users they need to manually allow popups. I'm going to try to get a reproducible sample live that I can share here, still seeing if there is something else on my end that I need to fix. I did end up running npm update and bumping the version of @azure/msal-browser to 2.1.0 from what was included in the sample.

Hmm, looks like I may just have had something mixed up on my end between version/configuration updates and browser cache issues. This is working now, after updating the sample's version of @azure/msal-browser to 2.1.0 and following the B2C configuration guidance! Although I was able to leave the login scopes at their default values from what's in the sample, now that the offline_access fix has been rolled out.
Thanks again, and I'm looking forward to seeing this stabilized and an msal-angular 2.0 release soon!


Interrupt tree example (current Fig 2.3) does not show in PDF

The current Fig 2.3: Interrupt tree example is just blank in the PDF.
I am not sure how to fix it.

Note that it was fine in v0.3, but broken in main/v0.4-rc1.

I'd guess it is related to this (the only warning in the pdf build):
WARNING: dot code 'digraph tree {\nrankdir = LR\nranksep = "1.5"\nsize = "6,8"\nedge [ dir="none" ]\nnode [ shape="Mrecord" width="2.5" ]\n\nsubgraph cluster_devices {\n   label = "Devicetree"\n   graph [ style = dotted ]\n   "soc" [ ]\n   "device1" [ label = "device1 | interrupt-parent=\<&open-pic\>" ]\n   "device2" [ label = "device2 | interrupt-parent=\<&gpioctrl\>" ]\n   "pci-host" [ label = "pci-host | interrupt-parent=\<&open-pic\>" ]\n   "slot0" [ label = "slot0 | interrupt-parent=\<&pci-host\>" ]\n   "slot1" [ label = "slot1 | interrupt-parent=\<&pci-host\>" ]\n   "simple-bus" [ label = "simple-bus" ]\n   "gpioctrl" [ label = "gpioctrl | interrupt-parent=\<&open-pic\>" ]\n   "device3" [ label = "device3 | interrupt-parent=\<&gpioctrl\>" ]\n\n   edge [dir=back color=blue]\n   "soc":e -> "device1":w\n   "soc":e -> "device2":w\n   "soc":e -> "open-pic":w\n   "soc":e -> "pci-host":w\n   "soc":e -> "simple-bus":w\n   "pci-host":e -> "slot0":w\n   "pci-host":e -> "slot1":w\n   "simple-bus":e -> "gpioctrl":w\n   "simple-bus":e -> "device3":w\n}\n\nsubgraph cluster_interrupts {\n   label = "Interrupt tree"\n   graph [ style = dotted ]\n\n   "i-open-pic" [ label = "open-pic | Root of Interrupt tree" ]\n   "i-pci-host" [ label = "pci-host | Nexus Node" ]\n   "i-gpioctrl" [ label = "gpioctrl | Nexus Node" ]\n   "i-device1" [ label = "device1" ]\n   "i-device2" [ label = "device2" ]\n   "i-device3" [ label = "device3" ]\n   "i-slot0" [ label = "slot0" ]\n   "i-slot1" [ label = "slot1" ]\n\n   edge [dir=back color=green]\n   "i-open-pic":e -> "i-device1":w\n   "i-open-pic":e -> "i-pci-host":w\n   "i-open-pic":e -> "i-gpioctrl":w\n   "i-pci-host":e -> "i-slot0":w\n   "i-pci-host":e -> "i-slot1":w\n   "i-gpioctrl":e -> "i-device2":w\n   "i-gpioctrl":e -> "i-device3":w\n}\n\nsubgraph {\n   edge [color=red, style=dotted, constraint=false]\n   "open-pic" -> "i-open-pic"\n   "gpioctrl":w -> "i-gpioctrl"\n   "pci-host" -> "i-pci-host"\n   "slot0":e -> "i-slot0":e\n   "slot1":e -> "i-slot1":e\n   "device1" -> "i-device1"\n   "device2":e -> "i-device2":w\n   "device3":e -> "i-device3":e\n}\n}\n': dot exited with error:
[stderr]
b'Warning: flat edge between adjacent nodes one of which has a record shape - replace records with HTML-like labels\n  Edge i-device1 -> device1\nError: lost device1 i-device1 edge\n'

It looks like that diagram did not change between v0.3 and main tip so I assume the difference must be in the tools.
You have not rebuilt v0.3 pdf with the new flow right?

The edge in question device1 to i-device1 is missing in v0.3 pdf also.  I think the tooling is now deleting the whole image on any error.
I have stared at this for awhile.  I don't understand how pci-host to i-pci-host works and device1 to i-device-1 does not.

Maybe @glikely has some ideas as he got all the image stuff working.

I sent workaround 1 in a PR just in case.
Ignore it if your not ready to accept defeat as I am.

The current version of the website appears to still be on 0.3, which doesn't show the image:
You can still view it in the 0.2 version:
https://devicetree-specification.readthedocs.io/en/v0.2/devicetree-basics.html#example-interrupt-tree
But it doesn't appear for 0.3:
https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#example-interrupt-tree
Nor for latest:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#example-interrupt-tree


⚠ Bofrost.de has degraded performance

In 5e5c734, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1428 ms

Resolved: Bofrost.de performance has improved in 1d89cee after 20 minutes.


Omit empty parentheses from functions with no input or output

https://www.reddit.com/r/webdev/comments/585ghb/hi_rwebdev_im_the_developer_behind_lily_an/d8y624j
Quoted:

No worries, I'm probably confused. I'm just curious why we write:
define myfunc: Function() { ...
and not
define myfunc: Function { ...
since we're just declaring the return type and not invoking? Or can do we declare the arguments there too? The tutorial code doesn't have an example of this so I was a bit confused.

I plan to fix this before 1.0. Initially, this will be optional (the old way will be supported, and may possibly emit a warning too). In the later part of rolling over to 1.0, I'll cut that out and make this mandatory the same way as define prohibits empty parentheses.

I think I'm going to decline to do this after all. When using define and class, the shorthand for omitting parentheses/return type is consistent. But applying that to the Function type means that Function is a special case when it has no arguments. That brings up questions of if other type annotations should be special-cased as well (ex: [Integer] for List[Integer] or [Integer => String] for Hash[Integer, String], <[Integer, String]> for Tuple[Integer, String]. All of those, I'm not interested in doing. I also don't see a big value in doing this, a topic that I've been more interested in lately. I do appreciate the proposal though.


CI upload relevant artifacts for test job

Description

Closes/Fixes: #1979
Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 PR has a descriptive title for the changelog
[x] 🛠 Code follows the style guide
[ ] 🛠 YAML files pass pre-commit or yamllint checks
[x] 🛠 Circle/CI tests pass
[x] 🛠 Codacy code quality checks pass
[x] 🛠 Documentation builds successfully on readthedocs

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

cheers @bouweandela :beer:

cheers @bouweandela :beer:


logdet differentiation fails

The following example doesn't work on latest Enzyme release and Julia 1.10.
using LinearAlgebra
import Enzyme

f(x) = logdet([exp(x[1]);;])
f(rand(1))
Enzyme.gradient(Enzyme.Forward, f, rand(1))

The part of the error that I understand is:
No forward mode derivative found for dgetrf_64_
 at context:   call void @dgetrf_64_(i8* noundef nonnull %6, i8* noundef nonnull %8, i64 %23, i8* noundef nonnull %10, i64 %27, i64 noundef %bitcast_coercion42) #40 [ "jl_roots"({} addrspace(10)* null, {} addrspace(10)* %20, {} addrspace(10)* null, {} addrspace(10)* %2, {} addrspace(10)* null, {} addrspace(10)* null) ], !dbg !78

Stacktrace:
 [1] #getrf!#1
   @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lapack.jl:565

Stacktrace:
  [1] throwerr(cstr::Cstring)
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/VS5jo/src/compiler.jl:3066
  [2] #getrf!#1
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lapack.jl:565
  [3] getrf!
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lapack.jl:557 [inlined]
  [4] #lu!#158
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lu.jl:82 [inlined]
  [5] lu!
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lu.jl:81 [inlined]
  [6] #lu#164
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lu.jl:300 [inlined]
  [7] lu (repeats 2 times)
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/lu.jl:299 [inlined]
  [8] logabsdet
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/generic.jl:1676 [inlined]
  [9] logdet
    @ ~/.julia/juliaup/julia-1.10.0-beta2+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/LinearAlgebra/src/generic.jl:1701
 [10] f
    @ ./REPL[7]:1 [inlined]
 [11] f
    @ ./REPL[7]:0 [inlined]
 [12] fwddiffejulia_f_2643_inner_1wrap
    @ ./REPL[7]:0
 [13] macro expansion
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/VS5jo/src/compiler.jl:9774 [inlined]
 [14] enzyme_call
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/VS5jo/src/compiler.jl:9452 [inlined]
 [15] ForwardModeThunk
    @ Enzyme.Compiler ~/.julia/packages/Enzyme/VS5jo/src/compiler.jl:9418 [inlined]
 [16] autodiff(::EnzymeCore.ForwardMode{…}, f::EnzymeCore.Const{…}, ::Type{…}, args::EnzymeCore.BatchDuplicated{…})
    @ Enzyme ~/.julia/packages/Enzyme/VS5jo/src/Enzyme.jl:330
 [17] autodiff
    @ Enzyme ~/.julia/packages/Enzyme/VS5jo/src/Enzyme.jl:222 [inlined]
 [18] gradient(::EnzymeCore.ForwardMode{EnzymeCore.FFIABI}, f::Function, x::Vector{Float64}; shadow::Tuple{Vector{Float64}})
    @ Enzyme ~/.julia/packages/Enzyme/VS5jo/src/Enzyme.jl:866
 [19] gradient(::EnzymeCore.ForwardMode{EnzymeCore.FFIABI}, f::Function, x::Vector{Float64})
    @ Enzyme ~/.julia/packages/Enzyme/VS5jo/src/Enzyme.jl:862
 [20] top-level scope
    @ REPL[13]:1

Yeah we don't have a derivative rule for that, want to try adding it?

Here's a bunch of samples if you'd like to take a look to get started: https://github.com/FluxML/NNlib.jl/pull/536
I'd probably recommend writing the rule at the logdet function level

Looking at the documentation, defining Enzyme rules seems somewhat mechanical. I think it might be possible to create a macro that defines an Enzyme rule using ChainRulesCore.rrule or frule. We have a macro like this for ReverseDiff and ForwardDiff.


Top bar fails to render on refresh

When loading the code tab from a link or by doing a refresh the script fails to execute.
The log is basically that it could not find the DOM.
Fixer exception:  TypeError: Cannot read property 'querySelector' of null
    at x.isApplieble._createCommitsSummaryElement (github-defreshed.user.js:15)
    at x.isApplieble.apply (github-defreshed.user.js:15)
    at k (github-defreshed.user.js:15)

@An-dz, can not reproduce this. Can you provide a link to some problematic repos, please?

Also, it would be nice if you'll mention your browser and userscript engine, just in case :)

Ok, I've found the problem, I somehow changed the execution time of the script so it was firing too early. It's all good now.

@An-dz, oh, ok xD
Yeah, that kinda make sense, cause currently I need fully loaded DOM at startup. Will change it in nearest future


ACCUMULO-4391 Source deepcopies cannot be used safely in separate threads in tserver

Added synchronization around the available() call in the BoundedRangeFileInputStream to allow RFile.Reader deepcopies to be usable in separate threads.

What's the ticket number? ACCUMULO-4139 is ExistingMacIT doesn't wait long enough for ZK locks to disappear

Sorry, that is ACCUMULO-4391.  I will resubmit the request with an updated commit message....sigh

Note that this patch applies to 1.6 and 1.7 only.  In 1.8 this class does not even exist.

+1 LGTM.

@ivakegg I have a question that hope you can answer quickly from your recent looking the code.  If not I can go look myself.  Do you know if each deep copy ends up with its own instance of BoundedRangeFileInputStream for each block it reads?  I suspect this is the case, but not 100% sure.  It seems thats the way   BoundedRangeFileInputStream is intended to be used, each thread has its own instance wrapping a shared input stream.

@keith-turner I am pretty sure a new BoundedRangeFileInputStream is created each time getDataBlock or getMetaBlock is called on BCFile.  Its the underlying FSInputStream that is reused.

I am sad to report that this fix does not fix the underlying problem.  I does solve an issue when using the local file system as is tested by the test case, but does not solve the issue when using hadoop.  So I am back to debugging on my cluster......

I was finally able to reproduce the situation on my development box and I have managed to track a several issues related to using deepcopies across threads.  I will upload the changes later today.  The issues were:

The CachableBlockFile.Reader.close method needs to synchronize on the underlying FSDataInputStream when closing it.
BCFile.finish method needs be synchronized to avoid the same decompressor being returned multiple times.  This accounts for the majority of the issues.
BoundedRangeFileInputStream needs to ensure the stream is not closed once synchronized on the underlying FSDataInputStream.

Is this ready to be merged?

Is this ready to be merged?

A quick look shows that there are still things that Ivan said he would change.

Except for Josh's comments from today, I believe I had answered all of the comments.  I will upload changes as such this evening.

Also, not to further up the bar on you @ivakegg, but I think it might be good to run this through a quick perf test to make sure there aren't any obvious regressions. Sadly, I don't have a good way to recommend you do this. Could try to just launch a continuous-ingest ingest client to write a given amount of data into a pre-split table. If others are comfortable without such a test, I'm OK too. It was just something I thought I would mention.

Except for Josh's comments from today, I believe I had answered all of the comments. I will upload changes as such this evening.

Also, sorry Ivan. It didn't look like https://github.com/apache/accumulo/pull/134/files#r73361217 was addressed yet. Maybe I am just missing context.

Re: https://github.com/apache/accumulo/pull/134/files#r73361217
You may be right....I think I implemented that but did not push it up....

Resolved remaining comments and pushed.

@joshelser  I have been thinking about performance w.r.t these changes.  Looking over all of the changes, they are all in close methods which are called per block and not per key/value.  So given that they are called less frequently, I suspect it would not cause performance problems.  Also, in the normal case everything should be single threaded, so I am thinking we should not see performance problems caused by threads waiting on each other in the normal case.   But perf testing would still be nice if someone has the time.

I asked some questions on JIRA trying to better define what problem is being solved by this PR.

@keith-turner great example of why I deferred to you :). Thanks for the extra context. I have not looked closely enough to have understood that on my own.

I have been looking at the PR and I have come to two conclusions.   First, I don't think these change will negatively impact the normal single threaded case in any way.   Second, I can't come the conclusion that these changes are completely correct for the multi-threaded case because I don't have a good sense of what specific problems are happening in the multi-threaded case.  In order to reason if this PR solves the problems, I need to know what the problems are.
I do think these changes are a good improvement and are ready to merge. They definitely solve some subset of multi-threaded problems, just not sure if all.
One of thing I thought of that may be useful to try in the test is having threads close RFiles while other threads are reading from deep copies.   Doing this in a continuous manner with multiple RFile concurrently, such that some threads are opening and reading rfiles and other threads are closing those rfiles.  This would attempt to force multiple threads to use the same decompressor.

@keith-turner I added a good description in the jira ticket of the various issues related to multi threading that I discovered.

I will be happy to continue trying to reproduce the various problems as described (now in detail) within the jira ticket.  I vote however to get this merged in as I am confident these changes solve the issues.  @keith-turner is correct in that I cannot guarentee that this solves all multi-threading issues related to source deep copies.  For example @phrocker suggested that there are more issues when using the encryption stuff, however that is I believe only experimental currently.

How much logging is disabled by setting the CodecPool and NativeCodeLoader to off? If it is an issue, could it be set in the logging configuration instead of in this code in the static block?
This is adding a direct dependency to log4j1.x and will need to be changed to use log4j2 (or slf4j).
This is not enough for me to vote not to merge, but if convenient and setting the level can be avoided it would save a little work in the future,

I agree with @EdColeman that we should avoid the direct use of Log4J in code. It looks like we're just doing it in a test, which is probably fine. I'm certainly not concerned about that in the 1.6 branch, though. We can address it in newer branches.

I agree with @EdColeman that we should avoid the direct use of Log4J in code.

Hrm, I mentioned this earlier too. I guess it got lost..

@ya-all I already removed the static blocks that were setting the log4j levels and moved them into the log4j.properties for the tests.

Okay, I'm going to merge this in.

Okay, I'm going to merge this in.

Can you make sure we get some related tasks filed for some of the extra testing investigation we talked about previously, please? If Ivan can get to them fantastic. Otherwise, we can just won't fix after a burn-in period on these changes.

I will leave this issue open until the first 1.6.6 release candidate, to accommodate test additions. If none arrive before the RC, I'll create a new JIRA for adding new tests.

I will leave this issue open until the first 1.6.6 release candidate, to accommodate test additions. If none arrive before the RC, I'll create a new JIRA for adding new tests.

Coolio. WFM.


Markdown fenced blocks should be highlighted in a similar way to single line code blocks

When highlighting code inside markdown, single line code blocks are highlighted, but fenced blocks are not, unless they are a supported language, in which case only the contents are highlighted, which is inconsistent with single line blocks where the backticks are highlighted too:

For a more consistent view, I think the triple backticks should always be highlighted, and if no language is provided then the contents should also be highlighted, eg:

Closing this based on https://github.com/microsoft/vscode/pull/155057#issuecomment-1212596372
This is something a third party theme can easily customize (or you can even do it yourself with user settings). However it feels too drastic of a change as is for the built-in themes


fix: xArgs command update

Fixes #1538
A small update to use a default option instead of failing straight out if the maxArgs is reached.
Checklist

[x] Integration tests updated

@flank-it


[stable/oauth2-proxy] Add securityContext for container

Add securityContext for the oauth2-proxy container, allowing the user for setting the securityContext.runAsNonRoot: true, which forces the containers to run as a non-root user.
By default this feature is disabled, so that it does not result in a breaking change for any users of the chart.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test


Change cursor on sortable col and update search query param

smartcitiesdata/smartcitiesdata#220
co-authored-by: Kenny Drobnack<EMAIL_ADDRESS>

:fire:


Have @smogon/calc's interfaces match @pkmn/* interfaces

The calc package's Generations type is already very close to https://github.com/pkmn/ps/blob/master/data/index.ts (which is not a coincidence, the calc's interface was the inspiration for @pkmns), instead it should unify with it such that a @pkmn's Generations can be used drop in. Furthermore, @pkmn/client's Pokemon, Move and Field object should be possible to use without wrapping as arguments to calc.
"Why?" A better question is "why not?" - the calc doesn't really benefit much from having its own data layer, so matching its adaptable interface to that of its primary user makes sense., especially given that its so close. What this entails:

determining which field names and types make the most sense between the two data layers and harmonizing on the best (@pkmn is slightly more restricted here given its contraints based on being compatible with the PS Dexinterface)

It is important to note:

the calc UI in this repo will still depend on its own data layer
the calc package will continue to have 0 dependencies (ie. no deps of @pkmn/data)

This was done


WIP palemoon: 29.4.4 -> 30.0.0

Description of changes
https://www.palemoon.org/releasenotes.shtml

Updated various in-tree libraries: cubeb, sqlite, cairo, ...
Fixed an issue with the Linux desktop shortcut file to solve potential DE integration problems on common distributions.
Fixed an issue with page and iframe content margins not being applied properly when passed as attributes instead of CSS.
Ensured JavaScript and JSON files are always recognized as known MIME types so they can be opened appropriately from local sources.
Fixed an issue with rapid loading and unloading of js modules causing browser crashes.
Fixed an issue with tooltips being cut off at the end if containing exceedingly long unwrappable series of characters.
Fixed several application crash scenarios. DiD
Fixed a large number of thread locking/mutex issues. DiD
Fixed a leak of content types due to inconsistent error reporting. (CVE-2022-22760)
Fixed an issue with iframe sandboxing not being properly applied. (CVE-2022-22759)
Fixed a potential leak of bookmarks from the exported bookmarks file if it included a malicious bookmarklet.
Fixed an issue with drag-and-drop. (CVE-2022-22756)
Fixed a potential crash due to truncated WAV files.
Fixed a memory safety issue with XSLT. (CVE-2022-26485)

WIP. mach build & mach install complete but the rest of installPhase needs to be updated.
 1:59.39(B '/nix/store/by69zqgj36k242p9xkwr4l6pwfx6hlsf-palemoon-30.0.0/bin/palemoon' -> '/nix/store/by69zqgj36k242p9xkwr4l6pwfx6hlsf-palemoon-30.0.0/lib/palemoon-30.0.0/palemoon'
 1:59.39(B To run the installed application, execute: .//nix/store/by69zqgj36k242p9xkwr4l6pwfx6hlsf-palemoon-30.0.0/bin/palemoon .
 1:59.39(B make[1]: Leaving directory '/build/source/obj-x86_64-pc-linux-gnu/browser/installer'
 1:59.39(B make: Leaving directory '/build/source/obj-x86_64-pc-linux-gnu'
substitute(): ERROR: file './palemoon/branding/official/palemoon.desktop' does not exist
builder for '/nix/store/d36gz3wkl6lygkqlzdr588w7ggfid6fl-palemoon-30.0.0.drv' failed with exit code 1
error: build of '/nix/store/d36gz3wkl6lygkqlzdr588w7ggfid6fl-palemoon-30.0.0.drv' failed

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

After figuring out where the branding was moved to & what workarounds upstream deprecated, it seems to work.

@ofborg eval

After the infra outage, the v30 milestone was recalled: https://forum.palemoon.org/viewtopic.php?f=1&t=28044.

I think we need to revert this.


The latest release is no longer compatible with jQuery 3

After upgrading to new version (1.0.1) I noticed that jquery migrate plugin throws warnings because of using "bind" and "unbind" in following line:
$(window).unbind(eventName).bind(eventName, function() {
Bind/unbind are deprecated in jQuery 3. Use on/off to attach/detach event listeners.

Just made a PR for this. Thank you!

Fixed by #136. Will be included with 1.0.2

Thank you!

Thanks guys.


Add TextInput component

This PR is related to #21 .
Summary
This PR allows you to use TextInput component which has similar behavior of <input type="text">.

Features

React's controlled components model (when value prop is provided)
OnInput and OnChange callback
Some basic properties. fontSize, placeholder, maxlength, etc.
juce::TextEditor's properties. e.g. 'highlight-color' which can be set by
juce::Component::setColour() in original JUCE

Awesome work @utokusa thank you. I've looked briefly and the approach generally looks totally right. I want to review in closer detail before merge, will try to get to it in the morning!

Awesome work @utokusa thank you. I've looked briefly and the approach generally looks totally right. I want to review in closer detail before merge, will try to get to it in the morning!

Excellent work @utokusa. This looks pretty much ready to merge now. We'll need to publish a new version of the react-juce npm package for this and bump the example project etc. Very happy to pull down your branch to test and push the package changes etc.
@nick-thompson did you want to take a quick pass over this before merge?

Excellent work @utokusa. This looks pretty much ready to merge now. We'll need to publish a new version of the react-juce npm package for this and bump the example project etc. Very happy to pull down your branch to test and push the package changes etc.
@nick-thompson did you want to take a quick pass over this before merge?

@utokusa looks like we have a merge conflict here, would you mind rebasing your branch against the latest master and then force pushing? And then I'll go ahead and merge!

@utokusa looks like we have a merge conflict here, would you mind rebasing your branch against the latest master and then force pushing? And then I'll go ahead and merge!

@nick-thompson I have just rebased and force pushed.
Now the commit log is bit strange and my non-latest commits fails to build because of the namespace change.
So I think it might be better to squash them.
What do you think?
Either way, it would be helpful if you could check for the latest commit.

I noticed that the GitHub Action was failed.
Please wait and I will fix it.

I have just fixed it.
The CI really helped me :)

Excellent, thanks again @utokusa! 😃 🚀


Plugin ordering for Vuetify - merge of user's & iles vite config

Is your feature request related to a problem? Please describe.
When adding vite plugins via our own vite.config.js, there are some challenges when the user's vite config & iles config are merged. Specifically, the ordering of the vite plugins. For eg, when adding vuetify to Iles using enhanceApp api, it has to be added after vue plugin (@vitejs/plugin-vue), otherwise vuetify components won't compile correctly.

Describe the solution you'd like
May be something like what nuxt does - using custom module to insert plugins in the correct place - nuxt.hooks.hook('vite:extendConfig')?
(Or) implement a callback so that we can just .push() or .unshift() to the defaults?
Describe alternatives you've considered
I was able to insert the Vuetify plugin at the right spot by using my own custom plugin like below. May be this is how we could ideally do, instead of any other complex way (as suggested above)
	plugins: [
		{
			configResolved(config) {
				const idx_vue = config.plugins.findIndex(
					(plugin) => plugin.name && plugin.name === 'vite:vue'
				)
				config.plugins.splice(idx_vue + 1, 0, Vuetify()[0])
			}
		}
	],

Repo (that works with the custom plugin hack) - https://stackblitz.com/github/TechAkayy/my-iles-vuetify-app?file=vite.config.js
Additional context
Supporting vite plugins that enable usage of UI components library like vuetify is a great and must outcome that will tremendously boost Iles adoption across the large vue ecosystem as intented. Making this work could also open-up new avenues where vuetify-based custom theme-authoring for Iles could evolve. Thanks in advance!

Ordering plugins is one of the unsolved UX problems in Rollup and Vite.
Some plugins will automatically reorder themselves in Vite when they detect they are in the wrong spot.
That said, it's not unreasonable to have a callback to inject plugins. API suggestions are welcome!

See this related RFC:

https://github.com/vitejs/rfcs/discussions/13

Thanks bunch ✌🏾


AUTO_INCREMENT

Relates: #159

Quite yuck and not yet working for rows inserted without NULL but working nonetheless.
@panarch how do you feel about giving StoreMut to Execute::prepare and Row::new?

@KyGost

Execute::prepare
I actually think Execute::prepare is... not meaningful to keep, first intention was dividing Store uses and Store + StoreMut uses but now I'm not sure that is really meaningful.
It might be better to re-combine prepare and execute, how do you think?

Row::new
You mean that providing Store to Row::new? then I think it would be good to keep data modules not to depend on Store. making it lightweight, containing "data" and some useful utility methods.

@panarch

Execute::prepare
I actually think Execute::prepare is... not meaningful to keep, first intention was dividing Store uses and Store + StoreMut uses but now I'm not sure that is really meaningful.
It might be better to re-combine prepare and execute, how do you think?

That sounds like a good idea.

Row::new
You mean that providing Store to Row::new? then I think it would be good to keep data modules not to depend on Store. making it lightweight, containing "data" and some useful utility methods.

Yup. I agree, it felt off to give it. How would you suggest it be done?
I need to run a tree.get & tree.set for each row.

resolve #159


fix prometheus config to include haproxy metrics

What type of PR is this?

/kind bug

What this PR does / why we need it:

prometheus metric for the Arktos proxy is not picked up by the cluster api servers. this is a missing code in 330 code merged and fixed in 530 perf branch. Now merge the fix to master.

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None

/lgtm

/approve


How to import an Elm package before publishing to package.elm-lang.org?

How can I import a package in ellie before publishing it to package.elm-lang.org?
Do I need to publish a package before testing it in ellie?

There is not a way to do this, you would need to publish your package first. We rely on the standard Elm toolkit to fetch dependencies (from some elm.json) and compile, this makes use of https://package.elm-lang.org. There has been some thought around adding modules other the Main but I fear this will only add complexity to a service with simpler intent.

Thank you @tbash for the clarification!


Downgrade targetframework of GenexusSecurity modules

Downgrade from net471 to net462 to keep the same requirements as standard classes.

It is going to be deeply analyzed.


How do I add a watermark?

Hi, i read post on watermark but not resolve my problem. Until now have is it:
function waterMark() {
const image =   Jimp.read('./original.png');
const watermark =   Jimp.read('./watermark.png');

image.composite(watermark, 0, 0, {
  mode: Jimp.BLEND_SOURCE_OVER,
  opacityDest: 1,
  opacitySource: 0.5
})

image.writeAsync('originalwithmark.png');

}
Response : image.composite is not a function
Somebody could help me?

When using promises you must either await or use then.
async function waterMark() {
  const image = await Jimp.read("./original.png");
  const watermark = await Jimp.read("./watermark.png");

  image.composite(watermark, 0, 0, {
    mode: Jimp.BLEND_SOURCE_OVER,
    opacityDest: 1,
    opacitySource: 0.5
  });

  await image.writeAsync("originalwithmark.png");
}

The original post had the awaits too. You cannot just delete them and expect the code to work.


Update one-click-table.md

In Select Source Type, the title for first item and third item should be exchanged. More specifically, the first item describes using a container (this can be proved by what is filled in the photo's source type field) while the third item describes using a blob as you can directly reference it with a SAS URL.
Moreover, media/one-click-table/blob.png can be renamed to media/one-click-table/storage.png if necessary. Though this does not affect understanding.

@pengzhengyi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@pengzhengyi thanks so much for your feedback and for creating this PR. Merging it now.
We will make other relevant doc changes as suggested.


RDK-30867 : Adding Watermark api

https://jenkins.code.rdkcentral.com/job/github-triggered/5573/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25032/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/751/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/2884/ started.

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/70966/

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/70968/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/70967/

https://jenkins.code.rdkcentral.com/job/github-triggered/5709/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/5709/ started

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25340/ started.

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/25340/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/877/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/877/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/3110/ started.

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/3110/ started.

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71601/

Smoke tests for ['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-mc-wpe-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71601/

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71600/

Smoke tests for ['build-rpi-hybrid-refapp-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71600/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71599/

Smoke tests for ['build-qemux86-hyb-rdk-next'/'build-qemux86-mc-rdk-next'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/71599/

'['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-hybrid-wpe-rdk-next']' Smoke test FAILURE, investigation pending.
Flash MC [SUCCESS]
Flash HYB [SUCCESS]
MC - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
Video Streaming using rmfApp [FAILURE]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
getClients : Failed - [clients:[residentapp],success:true]
getZOrder : Failed - [clients:[residentapp],success:true]
getClients : Failed - [clients:[testapp2,testapp1,testapp,residentapp],success:true]
getZOrder : Failed - [clients:[testapp2,testapp1,testapp,residentapp],success:true]
add key intercept test failed
add key listener test failed
getClientsAfterKill : Failed - [clients:[residentapp],success:true]
Number of success test - 33
Number of failed test - 7
Video Streaming using rmfApp [SUCCESS]
HYB - Video Test [FAILURE]
Video HLS gst-launch [FAILURE]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
getClientsAfterKill : Failed - [clients:[residentapp],success:true]
Number of success test - 37
Number of failed test - 3
Video HLS gst-launch [SUCCESS]
https://jenkins.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/21133/

'['build-rpi-hybrid-wpe-rdk-next'/'build-rpi-hybrid-wpe-rdk-next']' Smoke test FAILURE, investigation pending.
Flash MC [SUCCESS]
Flash HYB [SUCCESS]
MC - Video Test [FAILURE]
Video HLS gst-launch [SUCCESS]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
Video Streaming using rmfApp [FAILURE]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
getClients : Failed - [clients:[residentapp],success:true]
getZOrder : Failed - [clients:[residentapp],success:true]
getClients : Failed - [clients:[testapp2,testapp1,testapp,residentapp],success:true]
getZOrder : Failed - [clients:[testapp2,testapp1,testapp,residentapp],success:true]
add key intercept test failed
add key listener test failed
getClientsAfterKill : Failed - [clients:[residentapp],success:true]
Number of success test - 33
Number of failed test - 7
Video Streaming using rmfApp [SUCCESS]
HYB - Video Test [FAILURE]
Video HLS gst-launch [FAILURE]
Video HLS rdkmediaplayer [SUCCESS]
Video Streaming using aamp-cli [SUCCESS]
Video local using gst-play-1.0 [SUCCESS]
RDKShell CI Tests [FAILURE]
checking thunder security
Thunder security is disabled
add key intercept test failed
add key listener test failed
getClientsAfterKill : Failed - [clients:[residentapp],success:true]
Number of success test - 37
Number of failed test - 3
Video HLS gst-launch [SUCCESS]
https://jenkins.cmf.code.rdkcentral.com/job/test-rdkv-raspberrypi-flow/21133/


Cleanup : 'for each' loops for arrays and removed unnecessary toLowerCase()

Motivation:

Make code easier to read with for each loops instead of for (int i ).
Simplify old code.

Modification:

for each loops introduced instead of for (int i ) for arrays only (no iterator allocation).
Removed unnecessary valueOf and toLowerCase in SslHandler.ignoreException as Pattern IGNORABLE_ERROR_MESSAGE is Pattern.CASE_INSENSITIVE.

Result:
Code easier to read. No unnecessary operations.

looks good to me.

Cherry-picked into 4.0 (d576fca0ddbf99d8d8ea928b8ca39efb8c604b68) and 4.1 (b9abd3c9fc90cda1781a6f2f181735460a13b75d).
Thanks!


How do you actually create an ARC file?

The documentation regularly references ARC files but I have no idea how to make them. The short term makes for unhelpful Google search results as well; I find tons of stuff on compression formats.

Hi @mtcjayne ,
Either ARC or WARC files can be written with the Internet Archive's web crawler Heritrix.
Because the WARC file became standard there are more tools for writing WARCs than ARCs (I am not sure what else writes ARC files). A couple of other tools for WARC writing are wget and warcprox.

Ok that's good to know. Thanks.


Accept failing of GetProperty

Accept an exception when executing GetProperty.
Try to get not only PR_EMS_PROXY_ADDRESSES but also PR_SMTP_ADDRESS.

Thanks!


fix(loader): side effect of manifest item

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.02 :warning:

Comparison is base (40290d8) 92.78% compared to head (599cc11) 92.76%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   92.78%   92.76%   -0.02%
==========================================
  Files          54       54
  Lines        1302     1300       -2
  Branches      226      225       -1
==========================================
- Hits         1208     1206       -2
  Misses         94       94

Impacted Files
Coverage Δ

src/loader/factory.ts
92.63% <100.00%> (-0.16%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Less docker commands

Users now only need to clone the repo and do:
docker-compose up

instead of building and running manually

I made this small change so that it's easier to use.
Users need to do one less command.
Thank you for your work btw!


Remove obsolete code

The removed line actually does not do anything / is never reached because the library does not even support Android 2.3.3
What are your thoughts.
Thanks in advance.

@daespark is this not valid or something else is wrong?


gunzip if necessary

closing, i'm not going to take compress as a dependency now that zlib is in core.

agreed, I have locally switched to such a model. This is no longer necessary
On Sat, Feb 18, 2012 at 6:50 AM, Mikeal Rogers
<EMAIL_ADDRESS>wrote:

closing, i'm not going to take compress as a dependency now that zlib is in core.

Reply to this email directly or view it on GitHub:
https://github.com/mikeal/request/pull/61#issuecomment-4030933


No such file or directory?

Hey there, excited to try out this tool, but I seem to be missing something.. any insight?
trusty ~ % uname -a
Linux trusty 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
trusty ~ % python --version
Python 2.7.6
trusty ~ % sudo pip install -U junos-netconify
Requirement already up-to-date: junos-netconify in /usr/local/lib/python2.7/dist-packages
Requirement already up-to-date: pyserial in /usr/local/lib/python2.7/dist-packages (from junos-netconify)
Requirement already up-to-date: lxml in /usr/local/lib/python2.7/dist-packages (from junos-netconify)
Cleaning up...
trusty ~ % locate netconify
/usr/local/bin/netconify
trusty ~ %netconify -/dev/ttyUSB0 -b 9600 -f host.conf
: No such file or directory
trusty ~ % ls | grep host
host.conf

I'm thinking this error is being thrown prior to the script actually executing.
Can you try: netconfiy --help and see if it prints the help message?

Thanks for the reply. Seems you're right..
trusty ~ % netconify --help
: No such file or directory
Ahh I think I got it. So, running it as python directly from the directory  lets the command run properly it seems.. py script not finding python..?
trusty ~ % cat /usr/local/bin/netconify
#!/usr/bin/env python2.7
import sys
from netconify.cmdo import *
nc = netconifyCmdo()
results = nc.run()
if results['failed'] is True:
print results['errmsg']
sys.exit(1)
trusty ~ % which python
/usr/bin/python
trusty ~ % which python2.7
/usr/bin/python2.7
Any suggestions? Did I break somthing in the install maybe?
Thanks again

You didn't break anything.  That file should have standard #!/usr/bin/python.
Try changing that and post back.
This library had a different focus prior to release.  It now is primarily focused on use with our Ansible modules.

@shermdog that did it! Thanks for the tip. All is well now (closing issue :) )
trusty ~ % cat /usr/local/bin/netconify
#!/usr/bin/python
import sys
from netconify.cmdo import *
nc = netconifyCmdo()
results = nc.run()
if results['failed'] is True:
print results['errmsg']
sys.exit(1)
trusty ~ % sudo netconify
TTY:login:connecting to TTY:/dev/ttyUSB0 ...
TTY:login:logging in ...


Add Dynaωo

Insert URLs to the project here:
https://github.com/dynawo/dynawo

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as 'Good First Issue' of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.

@rosiereflo @gautierbureau


Introduce ProxyConfigSelector

Motivation
Relates to #2739
Introduce a ProxyConfigSelector which is analogous to ProxySelector.
By doing so, users may be able to dynamically adjust which proxy server to connect to.
Additionally, add a bridge class WrappingProxyConfigSelector which may allow users to re-use ProxySelector implementations.
Modification

Introduce a ProxyConfigSelector interface which invokes callbacks select, connectFailed when appropriate.
Introduce Static, Wrapping utility variants of ProxyConfigSelector
Add ProxyConfig to PoolKey and enforce channels to re-use connections by ProxyConfig also.
Each connection remembers the corresponding PoolKey to invoke connectFailed

Breaking Changes

ClientFactoryOption[s] now accepts a ProxyConfigSelector instead of a ProxySelector

🎉:tada::tada:


In contrib/geoa factor out tileLayer(...).addTo(map) and update mapbox attributes

This change

updates the mapbox attributes at match https://docs.mapbox.com/help/troubleshooting/migrate-legacy-static-tiles-api/
Factors out the two calls to L.tileLayer into one
Fixes geom_formatter to no longer return <textarea data-tile-layer-url="None" ... when view.tile_layer_url is None.

Tested
Setup postgis and ran the demo app following examples/geo_alchemy/README.rst then created an object in the polygon table. Without this change http://<IP_ADDRESS>:5000/admin/polygon/ doesn't show tiles and with it tiles appear.

@mrjoes Please take a look. Thank you.


Suggestions for some new features

Suggestions for some new features

Automatically save game progress by date to prevent items in the storage box from disappearing after mod conflicts
Add - resetofflinemaps to refresh map parameters
Add - w - window to switch to window mode parameter

Add switch buttons for various parameters, etc
D2RMM can also be an excellent D2R starter

I agree D2RMM would be great as a D2R launcher/starter and support for parameters from within the GUI would be a cool addition. I always start my modded D2R using D2RMM.

I'm not going to handle 1 - that should be its own tool.
I didn't want D2RMM becoming a launcher either (I only added the Run D2R button because I got very tired of telling people to go read the description for how to add "-mod D2RMM -txt"), but it seems to have already inevitably become one, so I've given up on that battle. TLDR: 2 and 3 seem reasonable to me.
Fixed in 5d746597c590f07a5224e05e055d24c75db8ea70