Lost MiniCssExtractPlugin, do not parse scss files

What version of million are you using?
0.0.73
Are you using an SSR adapter? If so, which one?
None
What package manager are you using?
npm
What operating system are you using?
Mac
What browser are you using?
Chrome
Describe the Bug
Versions:
"webpack": "5.91.0",     "webpack-bundle-analyzer": "4.10.1",     "webpack-cli": "5.1.4",     "webpack-dev-server": "5.0.4", "mini-css-extract-plugin": "2.8.1", "react": "18.2.0",     "react-dom": "18.2.0",
After adding Million Lint, npm run start failed. It tells that I forgot to add MiniCssExtractPlugin in plugins section in webpack, but it exists there, and it build well after removing millionlint plugin.
`plugins: [
new ForkTsCheckerWebpackPlugin({
typescript: {
configFile: path.join(__dirname, '..', 'tsconfig.json'),
},
}),
// Combine all generated styles into a single bundle.css file
new MiniCssExtractPlugin({ filename: server ? '[name].css' : '[name].[contenthash].css' }),
new HtmlWebpackPlugin({
// Do not inject references to the webpack generatad js/css bundles. It will be done
// manually in the template
inject: false,
    // Add hashes to the bundle references to invalidate caching
    hash: true,

    // ejs template to use. Search following this order:
    // - a config/index.html.ejs file inside the project
    // - the framework's default template
    template: findFile('<root>/config/index.html.ejs', '<framework>/index.html.ejs'),

    // Name of the generated template file
    filename: 'index.html',

    // Initial application state set as global window variables. Only available in server mode.
    state: server ? requireFile('<root>/config/server/state.js', '<framework>/server/state.js') : {},
  }),

  // Generate a GO index.html.tmpl template for standalone deploys
  !server &&
    new HtmlWebpackPlugin({
      inject: false,
      hash: true,
      template: findFile('<root>/config/index.html.ejs', '<framework>/index.html.ejs'),
      filename: 'index.html.tmpl',
    }),

  // Tell webpack not to require jQuery. If a project uses jQuery it must include a
  // <script> tag in the template
  new webpack.ProvidePlugin({
    $: 'jquery',
    jQuery: 'jquery',
    // Node.js polyfills
    process: 'process/browser',
  }),

  // Prune from the bundle the unneeded validator-js locales.
  // Framework supported "es" and "en" locales are bundled by default
  new webpack.ContextReplacementPlugin(/validatorjs[\/\\]src[\/\\]lang/, /es|en/),

  // Output gzip version of the assets
  !server && new CompressionPlugin({}),
  new BundleAnalyzerPlugin(),
  MillionLint.webpack(),
],`

Errors:
ERROR in ./shared/modules/status-history/status-history.scss Module build failed (from ../node_modules/mini-css-extract-plugin/dist/loader.js): Error: You forgot to add 'mini-css-extract-plugin' plugin (i.e. { plugins: [new MiniCssExtractPlugin()] }`), please read https://github.com/webpack-contrib/mini-css-extract-plugin#getting-started
at Object.pitch (**/node_modules/mini-css-extract-plugin/dist/loader.js:77:14)
@ ./modules.tsx 11:0-86 19:104-139
@ ./main.tsx 25:0-36 42:238-245
webpack 5.91.0 compiled with 461 errors in 54839 ms`
What's the expected result?
Webpack build should be successful.
Link to Minimal Reproducible Example

Participation

[ ] I am willing to submit a pull request for this issue.

Hey there @mykhailokonst, do you think you can maybe provide a reproduction so I can help out? Thank you very much!

@tobySolutions , sure. You can comment/uncomment millio.webpack() line to check
Codesandbox link

@tobySolutions, any updates here?

@tobySolutions, any updates here?

Taking a look now, thank you very much @mykhailokonst.

I have taken a look and I think I need to inform the team of this issue so they can take a look. I'll pass on your reproduction to the team and I'll get back to you @mykhailokonst. Thank you.


Problems submitting issues after activation

Not sure it's a big deal because you can submit an issue directly here, but when clicking the report a bug link on the bottom of the home page (https://gitreports.com/issue/schneidmaster/gitreports.com) yields in:

I logged in and activated a repo as described in the instructions. I am not the owner of the repo but it's shared with me. From the profile page I click 'view' under the public url I get taken to the page to submit an issue the url is 'issue/xxJeevesxx/' as expected. However after submitting the issue it redirects to 'issue//'. Any thoughts?

I would gladly try to contribute but I don't know anything about ruby. For what that's worth...sorry. Thanks!

Looks like this is a duplicate, sorry I didn't look earlier.


n_easygit_d down invalid command

I use zsh, but I'm seeing this with bash and sh too.
Happens in down mode, in the git status. Up works.
Error output:
zsh:1: no matches found: [--version]
zsh:2: bad pattern: [--exec-path[=

Different error with bash:
/bin/bash: path: No such file or directory
/bin/bash: line 1: path: No such file or directory
/bin/bash: line 2: [-p: command not found
/bin/bash: line 2: --paginate: command not found
/bin/bash: line 2: --no-pager]: command not found
/bin/bash: line 3: path: No such file or directory
/bin/bash: line 4: command: No such file or directory

@SevereOverfl0w I've missed a space, so the command not working.


feat(time-picker): support millisecond

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[x] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

feat(TimePicker): 支持毫秒使用场景

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #1183 (09c8816) into develop (aaf0135) will decrease coverage by 0.00%.
The diff coverage is 10.00%.

@@             Coverage Diff             @@
##           develop    #1183      +/-   ##
===========================================
- Coverage    58.80%   58.80%   -0.01%
===========================================
  Files          405      405
  Lines        15051    15052       +1
  Branches      2844     2847       +3
===========================================
  Hits          8851     8851
- Misses        5927     5928       +1
  Partials       273      273

Impacted Files
Coverage Δ

src/table/hooks/tree-store.ts
10.39% <ø> (ø)

src/time-picker/panel/single-panel.tsx
8.78% <10.00%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d171ff4...09c8816. Read the comment docs.


Web App Version TagHelper

Should go into Detection or Webmaster project?

Added to Webmaster in PR https://github.com/wangkanai/Webmaster/pull/42


Cannot download model/data

Can you please share pretrained model through any other link?

#125

I tried the way you mentioned in the issue but it doesnot work anymore.
On Sat, Dec 10, 2022 at 4:48 AM Hao Ren @.***> wrote:

Closed #136 https://github.com/leftthomas/SRGAN/issues/136 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/leftthomas/SRGAN/issues/136#event-8002595381, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AM3XKCVESQSFAJTEOM3GR73WMO3FPANCNFSM6AAAAAASZFSWGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[WIP] Dynamic Interest Rate

This should close one of #1106 or #1132 or both. Should also address https://github.com/sbenthall/SHARKFin/issues/186#issuecomment-1410520453.

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[x] Update CHANGELOG.md with major/minor changes.

Can @wdu9 and @dedwar65 also review this?
With apologies to @dedwar65, this might affect #1219. (Going back to agent.Rfree without index in notebook).
The logic is as follows:
If Rfree is an int, float: it is time invariant.
If Rfree is a list of length 1: it is time invariant and recast as a float.
If Rfree is a list of length n>1: it is time varying and should be same length as T_cycle.
If Rfree is an array: it is time invariant (for Markov types)
Everywhere else where we want to use Rfree (as in calculations) we should first check the type then use appropriately (indexed if time varying).

Codecov Report
Base: 73.32% // Head: 73.30% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (5a47ed0) compared to base (69e0aa3).
Patch coverage: 81.25% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   73.32%   73.30%   -0.03%
==========================================
  Files          74       74
  Lines       12122    12122
==========================================
- Hits         8889     8886       -3
- Misses       3233     3236       +3

Impacted Files
Coverage Δ

...mptionSaving/tests/test_ConsPortfolioFrameModel.py
100.00% <ø> (ø)

HARK/ConsumptionSaving/ConsRiskyAssetModel.py
40.19% <66.66%> (-0.84%)
:arrow_down:

HARK/ConsumptionSaving/ConsIndShockModel.py
87.02% <84.61%> (-0.14%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This seems like a sound temporary fix.
But this problem illustrates why my strongly held view is that the default way of building models should be to define a terminal period, then define the problem for $T-1$, then define the solution for $T-2$, and so on.  Part of the "defining" would be to specify the value for $R$ that is period-specific.
My way of doing things would get rid of a lot of extraneous baggage (like this).
Wish we'd done it that way from the start.  (My fault that we didn't).

Hey Alan,
Just took a look at the PR. I think I understand what’s going on (w.r.t. the different cases for the time-varying interest rate).
Just to be clear though: does this mean I need to go back to the “ConsPortfolioModel” notebook and remove the subscript? The PR with that change still hasn’t been merged in yet, so I don’t think it should be much of a problem.
Let me know,
Decory
From: alanlujan91 @.>
Date: Wednesday, February 1, 2023 at 8:34 PM
To: econ-ark/HARK @.>
Cc: Decory Edwards @.>, Mention @.>
Subject: [econ-ark/HARK] Dynamic Interest Rate (PR #1221)
  External Email - Use Caution

This should close one of #1106https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fissues%2F1106&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598751282|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=fuLoDVfFM9yO0VOXE8rcTdvIlsZ%2F6pE5Le%2Fwn%2FmOMbw%3D&reserved=0 or #1132https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fissues%2F1132&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598751282|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=IrXIzMsVli924xB7PFKBHkpb8lmKPIRZ63doMFJO%2BiQ%3D&reserved=0 or both. Should also address sbenthall/SHARKFin#186 (comment)https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsbenthall%2FSHARKFin%2Fissues%2F186%23issuecomment-1410520453&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598751282|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qSPQoh371oU0e9KUQI04ivePpMkvNupciD7va61UBD4%3D&reserved=0.

Tests for new functionality/models or Tests to reproduce the bug-fix in code.
Updated documentation of features that add new functionality.
Update CHANGELOG.md with major/minor changes.

Can @wdu9https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwdu9&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=HbcctO0sgUrA6D8oE98fpHD%2BXApyGSbt2Q2c%2BwFMVZQ%3D&reserved=0 and @dedwar65https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdedwar65&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=JjblSvod%2FHFTZBPS79LW2JcOlkngiSyR%2FKnbHXvNwxA%3D&reserved=0 also review this?
With apologies to @dedwar65https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdedwar65&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=JjblSvod%2FHFTZBPS79LW2JcOlkngiSyR%2FKnbHXvNwxA%3D&reserved=0, this might affect #1219https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1219&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=RcxPX%2Fq7BDSVQODkKaWpdzCyz9Vu84QUEnFTPfThhJI%3D&reserved=0. (Going back to agent.Rfree without index in notebook).
The logic is as follows:
If Rfree is an int, float: it is time invariant.
If Rfree is a list of length 1: it is time invariant and recast as a float.
If Rfree is a list of length n>1: it is time varying and should be same length as T_cycle.
If Rfree is an array: it is time invariant (for Markov types)
Everywhere else where we want to use Rfree (as in calculations) we should first check the type then use appropriately (indexed if time varying).

You can view, comment on, or merge this pull request online at:
https://github.com/econ-ark/HARK/pull/1221https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=5aLDjBufpeIu6bTjAtDQ2Nbc0%2BSrvOcHNOzrBsO12CM%3D&reserved=0
Commit Summary

a6b6027https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Fcommits%2Fa6b60278453fd02522e38229703f4d4607ee098e&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=kJs2zfYFZBoV2DyZ0LWrsWrU8cW9%2Bq0WPal%2BXkHqUfw%3D&reserved=0 make update_Rfree more robust
5a47ed0https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Fcommits%2F5a47ed0f99424381a2e0b53b503300e318dfc366&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=z%2F%2Fc0m69fEqeUS8JoGe9%2FXXwTs9Hfx9faY6V0jlgv24%3D&reserved=0 update notebooks

File Changes
(5 fileshttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Ffiles&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=C5ZI1neTBmiwWJjcJX%2BjoPnfAWA8XVuk%2BjedB9CWE%2Bw%3D&reserved=0)

M HARK/ConsumptionSaving/ConsIndShockModel.pyhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Ffiles%23diff-7f09d28a3d4136ae35d8835cd1352f060da6e0114fe617c34374c8b57d41a57e&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2FPxMSbuaOqGFxBku4WAVMFsG7uRx7IcDGmbGo0doQs8%3D&reserved=0 (55)
M HARK/ConsumptionSaving/ConsRiskyAssetModel.pyhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Ffiles%23diff-f073beba06b2b2768c998126f4b5a017cb220d60ec4380315af6f13dab0ecea3&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=fVpL78hkZ%2BRkuj1FqOp5K%2FwfHk39LEUEDPmdzaJxXyg%3D&reserved=0 (22)
M HARK/ConsumptionSaving/tests/test_ConsPortfolioFrameModel.pyhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Ffiles%23diff-6909a7798437228fda4bbf3a9250af3236148d029a23c0f89c37994e3aa4b324&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=C2WC6Gw0Uzgt2vLmySaizVj5cPyuTkkifHDqxJD%2BngA%3D&reserved=0 (5)
M examples/ConsPortfolioModel/example_ConsPortfolioModel.ipynbhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Ffiles%23diff-6feb2c247382948eddf34cec2e650999475281e974b4f501cc58de2db4fa4484&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qY357%2BbXht3pKfNWqKshy7%2FXrOnoLsgwaghvnwx1Q38%3D&reserved=0 (237)
M examples/ConsPortfolioModel/example_ConsPortfolioModel.pyhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221%2Ffiles%23diff-82d972a720bc462b7f7be0c28699678252c3ecae545af4dcae8f50ffc0d66cb0&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=jBQvC%2B444LyVgy9XSdhXO6XJUIotYfnYVpy6exsZQtw%3D&reserved=0 (91)

Patch Links:

https://github.com/econ-ark/HARK/pull/1221.patchhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221.patch&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=K5KC2qUmJUx28hSDHbB4oLFfv3DZU7HQ%2BzJNCGCk3oA%3D&reserved=0
https://github.com/econ-ark/HARK/pull/1221.diffhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221.diff&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984598907523|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=MgHorIHBXE2aHjOv%2B%2FkZy2wpsjLE2Eh4g9tyTXAZZbk%3D&reserved=0

—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fecon-ark%2FHARK%2Fpull%2F1221&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984599063764|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=c3JtoKjfUKwPyUkKu%2FNKVs9kKxkpAnokXsHzKuw5tCI%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAR3YDSLDSWWJ7GSTLS57HSTWVMFJRANCNFSM6AAAAAAUONP7PM&data=05|01|dedwar65%40jhu.edu|cb1b0459915c4aa78b5d08db04bd996d|9fa4f438b1e6473b803f86f8aedf0dec|0|0|638108984599063764|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OBkK2271kVry9fOASKXjDP0mP7793PoV6Wd1ku5Sj4w%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@dedwar65 if this gets merged before yours, then the process should be to merge master back to your PR, then address any conflicts that come from that. Trying to preempt changes before they are on master might cause more issues. We can work on it together once it's needed.

@alanlujan91, this is not marked "Ready-To-Merge" but my sense is that you think it is?
I guess we still don't have a workflow to test a PR against DemARKs; but if I merge it, can you trigger a retest of the DemARKs and reverse my merge if problems crop up?

This is tagged as Ready to Merge. Not sure why you can't see it. But yes I can revert if needed.

Oh, I see the Ready-To-Merge label now.  Didn't know where to look.
Merging ...


[WIP] Create memphis client with custom options

Java doesn't allow default values for method parameters so I have used a builder class for that. I have also made the relevant changes to the method API mentioned in the README file.
Interacting directly with PEM files is quite cumbersome in Java, so I have used a third party dependency. Hopefully that won't be an issue.

Looking forward to some feedback before I proceed further.
Addresses issue #5 regarding TLS connections

@BOTbkcd thank you for the pull request.  Are you still interested in working on this?  If so, I can perform a review and provide some feedback.

@rnowling-memphis Sure, some feedback would be great!

@BOTbkcd, highly apologise it got missed! Thank you for your participation.
@rnowling-memphis is the lead. Adding @idanasulinmemphis and @Avitaltrifsik for the conversation as well

Hey @rnowling-memphis, did you get the chance to take a look? All good if not, I know how occupied are you.

Hey @rnowling-memphis @BOTbkcd can we rereview?

@rnowling-memphis @yanivbh1 Sorry to keep you waiting guys. I am currently on a business trip, that's why I couldn't make the requested changes. I will try to finish them by this weekend.

Thanks @BOTbkcd!  No rush.  We appreciate the effort.

@BOTbkcd Thank you for all this!  I'll plan to review in detail later tonight my time.
For the finally block: I was thinking of the case where something fails.  So, maybe a connection to the server is established but some later step in the initialization fails.  The connection to the server should be closed.  This may not be an issue -- I was just curious if we needed to consider that.


the window in the back is focused when an app has multiple windows

I was expecting that the last selected window would get the focus

This was actually my intention: if I had 3 windows open, I didn't want to have to use an alternate keyboard shortcut to open the window in the back (since it would always flip flop between the current and the most recent, and the last one would never be focused). I'm going to close the issue for now, but thanks for bringing it up!


Implement a keylogger

Changes this pull request makes :
This pull request implements a keylogger that register keystrokes using the multi-plataform pynput library. Then, the keylogger sends the keystrokes by email.
Usage: python vault.py -keylogger - interval  -sender  -destination  -host  -p  -username  -password
Where:

INTERVAL: Number of seconds to send the email with the registered keystrokes.
SENDER: Email to send to
HOST: SMTP Host to use
PORT: Port to connect to the SMTP server
USERNAME: Username to login into the SMTP server
PASSWORD: Password to login into the SMTP server

Checklist

[X] I have added the relevant documentation.
[X] My branch is up-to-date with the upstream master branch.
[X] I have fully tested the changes locally.

Development environment
OS: Linux
Python Version: 3.4.6

Exactly what I was looking for :)


Player stops when using next command

Can you provide steps to reproduce the bug please?

When going to a next song the player automatic pauses.

Are you on latest version? Could you check the output of this command
cat /usr/local/lib/node_modules/spotify-cli-mac/package.json | head -3
I can't replicate on v1.1.0

{   "_args": [     [

That's now that I expected to see. Could you post the full output please? cat /usr/local/lib/node_modules/spotify-cli-mac/package.json

{
  "_args": [
    [
      {
        "raw": "./spotify-cli-mac2",
        "scope": null,
        "escapedName": null,
        "name": null,
        "rawSpec": "./spotify-cli-mac2",
        "spec": "/Users/george/Desktop/NPM_PACKAGES/spotify-cli-mac2",
        "type": "directory"
      },
      "/Users/george/Desktop/NPM_PACKAGES"
    ]
  ],
  "_from": "../../Users/george/Desktop/NPM_PACKAGES/spotify-cli-mac2",
  "_id"<EMAIL_ADDRESS>  "_inCache": true,
  "_location": "/spotify-cli-mac",
  "_phantomChildren": {},
  "_requested": {
    "raw": "./spotify-cli-mac2",
    "scope": null,
    "escapedName": null,
    "name": null,
    "rawSpec": "./spotify-cli-mac2",
    "spec": "/Users/george/Desktop/NPM_PACKAGES/spotify-cli-mac2",
    "type": "directory"
  },
  "_requiredBy": [
    "#USER"
  ],
  "_resolved": "file:../../Users/george/Desktop/NPM_PACKAGES/spotify-cli-mac2",
  "_shasum": "0ce5a98b770bf6aef95655f760e9ef8a5da4380e",
  "_shrinkwrap": null,
  "_spec": "./spotify-cli-mac2",
  "_where": "/Users/george/Desktop/NPM_PACKAGES",
  "author": {
    "name": "Ersel Aker"
  },
  "bin": {
    "spotify": "./index.js",
    "sp": "./index.js"
  },
  "bugs": {
    "url": "https://github.com/ersel/spotify-cli-mac/issues"
  },
  "dependencies": {
    "bluebird": "^3.4.7",
    "chalk": "^1.1.3",
    "commander": "^2.9.0",
    "lodash": "^4.17.4",
    "lyricist": "git+https://github.com/ersel/lyricist.git",
    "moment": "^2.17.1",
    "moment-duration-format": "^1.3.0",
    "nconf": "^0.8.4",
    "node-emoji": "^1.5.0",
    "node-osascript": "^1.0.4",
    "progress": "^1.1.8",
    "prompt": "^1.0.0",
    "readline-sync": "^1.4.7",
    "spotify-web-api-node": "^2.3.6"
  },
  "description": "A nodejs app to control Spotify without leaving your terminal on Mac OS X.",
  "devDependencies": {
    "eslint": "^3.14.1"
  },
  "gitHead": "4b31128a5b14dea26537adba94aa241406d87608",
  "homepage": "https://github.com/ersel/spotify-cli-mac#readme",
  "keywords": [
    "spotify",
    "client",
    "mac",
    "os"
  ],
  "license": "MIT",
  "main": "index.js",
  "name": "spotify-cli-mac",
  "optionalDependencies": {},
  "readme": "# :notes: Spotify Client for Mac OS X :notes:\nA nodejs app to control Spotify without leaving your terminal. Only works with Mac Os as it relies on AppleScript behind the scenes to communicate with the Spotify app.\n\n# Installation\n    npm install spotify-cli-mac -g\nClient will be available under the alias `spotify`\n\n# Set-up\nIn order to use the client, you'll need to set Spotify Credentials. You can do this by going to https://developer.spotify.com/my-applications and then creating a new application.\n\nOnce you have created a new Spotify Application, edit the `config.json` file located at `/usr/local/lib/node_modules/spotify-cli-mac/` with your Client ID and Secret.\n\n# Demo\n[![asciicast](https://asciinema.org/a/ejbbvaa8833wq4xn4d2xuc9jx.png)](https://asciinema.org/a/ejbbvaa8833wq4xn4d2xuc9jx)\n\n# Usage\n    spotify\n  Commands:\n\n    search|s <type> [query...]  Search for a <track (t) | artist (ar) | album (al) | playlist (p) > (searches tracks by default)\n    info|i                      Display information about the current track along with player status\n    play [uri]                  Continue playing current track or play the track with the provided URI\n    pause                       Pause the current track\n    next|n                      Play the next track in the queue\n    back|b                      Play the previous track\n    mute|m                      Mute player\n    unmute|u                    Unmute player\n    volume|v                    Display player volume\n    + [deltaVolume]             Turn the volume up by given amount (0-100), default:10\n    - [deltaVolume]             Turn the volume down by given amount (0-100), default:10\n    p                           Toggle play/pause\n    replay|r                    Replay current track\n    position|pos [newPosition]  Get or set player position [mm:ss], e.g: pos 1:23\n    quit|q                      Quit Spotify :(\n    open|o                      Open Spotify :)\n    shuffle|ts                  Toggle shuffle on/off\n    repeat|tr                   Toggle repeat on/off\n    share|sh [type]             Display share <uri|url> and copy value to clipboard\n    lyrics|ly                   Display the lyrics of currently playing track\n\n  Options:\n\n    -h, --help     output usage information\n    -V, --version  output the version number\n\n# Displaying Lyrics\nIn order to be able to use the `lyrics` command, you will need to get a `Client Access Token` for the `Genius API`.\nSign up for API access here: https://genius.com/api-clients\n\nOnce you have your client access token, edit the `config.json` found under `/usr/local/lib/node_modules/spotify-cli-mac/`\n\n\n*Contributions and feedback are welcome and encouraged!*\n",
  "readmeFilename": "README.md",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/ersel/spotify-cli-mac.git"
  },
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "version": "1.0.0"
}

Seems like you are running 1.0.0. Could you please update to 1.1.0 and try again.
npm uninstall -g spotify-cli-mac
npm install spotify-cli-mac -g

aaah yes! worked than buddy :)


extractDrugOBFP4 or similar, consumes too much RAM

Hi there,
I'm trying to calculate fingerprints for ~50,000 molecules. However, I notice that the RAM usage only increases, to the point of completely depleting it. I don't understand how it is possible given that the matrix created by the function extractDrugOBFP4 to store the fingerprints is previously created, with the correct dimensions. Upon review, the size of the matrix is constant (~1.6gb) in each loop, however, the RAM usage by the R session increases as the loop continues. Furthermore, the process is sequential, molecule by molecule, which should not increase RAM usage.
This is the code of the function, and the section of the function that increases RAM usage. I know that this is the problematic section because when I change it to any vector of size 512 (not the fingerprint returned by ChemmineOB), the process does not consume more ram.
I'm not R expert, any help will be useful.
Thanks, and sorry about my english.
function (molecules, type = c("smile", "sdf"))
{
  check_ob()
  if (type == "smile") {
    if (length(molecules) == 1L) {
      molRefs = eval(parse(text = "ChemmineOB::forEachMol('SMILES', molecules, identity)"))
      fp = eval(parse(text = "ChemmineOB::fingerprint_OB(molRefs, 'FP4')"))
    }
    else if (length(molecules) > 1L) {
      fp = matrix(0L, nrow = length(molecules), ncol = 512L)
      for (i in 1:length(molecules)) {
        molRefs = eval(parse(text = "ChemmineOB::forEachMol('SMILES', molecules[i], identity)"))
###########################################################
####### This is the step which increases RAM usage in each loop step
        fp[i, ] = eval(parse(text = "ChemmineOB::fingerprint_OB(molRefs, 'FP4')"))
###########################################################
      }
    }
  }
  else if (type == "sdf") {
    smi = eval(parse(text = "ChemmineOB::convertFormat(from = 'SDF', to = 'SMILES', source = molecules)"))
    smiclean = strsplit(smi, "\\t.*?\\n")[[1]]
    if (length(smiclean) == 1L) {
      molRefs = eval(parse(text = "ChemmineOB::forEachMol('SMILES', smiclean, identity)"))
      fp = eval(parse(text = "ChemmineOB::fingerprint_OB(molRefs, 'FP4')"))
    }
    else if (length(smiclean) > 1L) {
      fp = matrix(0L, nrow = length(smiclean), ncol = 512L)
      for (i in 1:length(smiclean)) {
        molRefs = eval(parse(text = "ChemmineOB::forEachMol('SMILES', smiclean[i], identity)"))
        fp[i, ] = eval(parse(text = "ChemmineOB::fingerprint_OB(molRefs, 'FP4')"))
      }
    }
  }
  else {
    stop("Molecule type must be \"smile\" or \"sdf\"")
  }
  return(fp)
}

@tcaceresm Great question. I'm not exactly sure where the problem is coming from, but an educated guess is somewhere under the hood from ChemmineOB or Open Babel, something like a memory leak.
From the R perspective, I have an alternative solution, see this blog post on using callr to create more robust wrappers for similar batch processing tasks: https://nanx.me/blog/post/disposable-computing-with-callr/.
In brief, split up the fingerprint calculations into much smaller batches, and use callr to launch new, separate R processes to go through each batch. This can potentially eliminate runtime issues related to low-level code.

Yup, the solution was to split up the fingerprint calculations!
Thanks, I'll close this issue.


Set SELinux enforcing mode

SELinux enforcing mode was removed from green flavor in https://github.com/rancher/elemental-toolkit/pull/2170/commits/1114b12ab1e213aec5e2ed3dd3872ed65657dd6a while trying to get all tests working.
The goal is to reenable SELinux enforcing mode for green flavor.

Pausing this for now. Some key takeaways from debugging this issue:

The error encountered is Non unix-domain-socket passed as listener, in the dbus-broker service during boot.
When starting a service that depends on dbus-broker after logging into the machine, dbus-broker is started without any error.
The same error is found when trying to boot ubuntu 21.10 with selinux tools installed and booting in enforcing mode.
It works when booting into systemd-rescue first and then exiting and booting into the active system.


various telomere attachment and SPB PMID:17632059

PMID:17632059
NEW1:abnormal meiotic spindle pole body organization during meiosis I
child of
FYPO:0003560 | abnormal spindle pole body organization
standard def
NEW2: abnormal sporulation resulting in formation of two-spore ascus, DNA not encapsulated
child of
FYPO:0000681 | abnormal sporulation resulting in formation of two-spore ascus
(with DNA excluded from ascus)
NEW3 normal spindle pole body oscillation during meiotic prophase
child of
FYPO:0000535 | normal spindle pole body localization
NEW4 multiple meiotic spindles
sibling of
FYPO:0003754 | multiple mitotic spindles
(have V-shaped patterns indicating multiple spindles, apparently)
NEW5 meiotic spindle absent from cell during meiosis
parent of
FYPO:0003614 | meiotic spindle absent from cell during meiosis II
NEW6
meiotic spindle pole body detached from nucleus
child of
FYPO:0006365 | spindle pole body detached from nucleus
(are these all mitotic?)
NEW7
abolished protein localization to meiotic spindle pole body during meiosis I
FYPO:0003542 | abolished protein localization to meiotic spindle pole body
NEW8:  abnormal meiotic spindle localization
typo FYPO:0006365
Matching synonym | SPB detached from nucleuss

Q re new2:
From the text accompanying Figure 1, I got the impression that the asci in which some DNA is not enclosed in spores do not all necessarily have exactly two spores. Should the term be "abnormal sporulation resulting in formation of ascus containing non-uniform spores and unencapsulated DNA" (is_a FYPO:0000913)?
Q re new6:
FYPO:0006365 was added for #3223 (PMID:24954111), and is not specific for mitotic or meiotic SPB. I gather that paper is all about meiotic stuff. I could either add new terms or convert FYPO:0006365 to meiotic, depending on whether you think a mitotic term will also be useful. Which?
Q re new8:
GO doesn't have a term for meiotic SPB localization. Do you plan to request one? In the meantime, I can put the term in without a logical def.

update to Q about new8: I got spindle and spindle pole body confused, but it turns out not to matter - GO also doesn't have plain "meiotic spindle localization", although it does have "establishment of meiotic spindle localization". The same is true for mitotic terms, but we haven't needed to use them for FYPO defs so far.
So the question becomes: should I use the "establishment" term or wait for a new, less specific, term to do a logical def?

because it's attchment, I think you can use establishment...

New2- yes sure.
New 6.
You can change the existing term to meiotic, but I thought I had seen a very similar mitotic phenotype already (very recently)...I wonder what I used?

ignore, I was thinking of
mitotic spindle microtubules detached from spindle pole body (FYPO:0006351)

OK, got these in and will do the rest tomorrow:
abnormal mitotic spindle pole body organization FYPO:0006387
abnormal meiotic spindle pole body organization during meiosis I FYPO:0006388
normal meiotic spindle pole body oscillation during prophase I FYPO:0006389
multiple meiotic spindles FYPO:0006390
meiotic spindle absent from cell during meiosis FYPO:0006391
abolished protein localization to meiotic spindle pole body during meiosis I FYPO:0006392
localization phenotype during meiotic cell cycle FYPO:0006393
abnormal meiotic spindle localization FYPO:0006394
renamed FYPO:0000534 & FYPO:0000535 to refer to mitotic spindle pole body (consistent with existing placement and text defs)
edit file: 5d4ced20f8321089376ba5633daec7d24225c498
release: ade0dde1b374d759a0ac9dc602c0f7c66561f321

last one done
abnormal sporulation resulting in formation of ascus containing non-uniform spores and unencapsulated DNA FYPO:0006383
edit file: ebfb6bcd33a1dfd2b17dccfd1b087652671669b1
release: 91086f719b0e87a8f054e0f32980d65ca61873ff


Admin API

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 01880bed-a5f3-47d4-825a-7ab9339d37dc

58 of 82 (70.73%)  changed or added relevant lines in 4 files are covered.
36 unchanged lines in 11 files lost coverage.
Overall coverage increased (+0.03%) to 57.357%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

service/frontend/adminGrpcHandler.go
0
8
0.0%

service/frontend/adminHandler.go
44
52
84.62%

service/frontend/adminThriftHandler.go
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

client/history/client.go
2
38.1%

client/history/metricClient.go
2
45.3%

common/util.go
2
53.44%

service/history/handler.go
2
47.15%

service/history/task/transfer_standby_task_executor.go
2
86.93%

service/matching/matcher.go
2
89.57%

common/task/fifoTaskScheduler.go
3
84.54%

service/frontend/adminGrpcHandler.go
4
4.48%

service/frontend/adminThriftHandler.go
4
63.08%

service/frontend/workflowHandler.go
4
60.24%

Totals

Change from base Build 01880bdf-c38c-430f-8249-282c4e9cc3f9:
0.03%

Covered Lines:
86853

Relevant Lines:
151425

💛  - Coveralls


Removes swagger container

Removes swagger container in dev env
Exposes DB port in dev env

This is an automated message from CI:
Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1546
Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.


AMD GPU or CPU Support?

Hey great work!
Question: Is it possible to run this project with and AMD GPU or at least run it with an CPU? For any help or hints, i would be glad.

Program runnable on CPU.


Implement testing of settings

It would be nice if plugin had some "test settings" action that would try to send test notification (to check, that bot token and receiver ids are correct).

Hello.
This problem was fixed in new Sentry's versions. Try to update your instance to 8.19.0 or above.
I got it on 8.19.0.
In Telegram:

In Sentry:


Doesn't work with mobile links

The mobile app returns links with another schema, e.g. https://spotify.link/Lh6MLTOo2Bb.
I tried to get this working myself but couldn't figure out how best to structure it in this kind of app.
Here's a failing test.
  test('should return a song with a valid shortLink - Song', async ({ page }) => {
    const shortLinkSong = 'https://spotify.link/Lh6MLTOo2Bb';
    const searchCard = page.getByTestId('search-card');

    await page.fill('#song-link', spotifyLinkSong);
    await page.press('#song-link', 'Enter');

    const searchCardText = await searchCard.textContent() ?? '';

    expect(searchCardText).toContain('Do Not Disturb');
    expect(searchCardText).toContain('Drake · Song · 2017');
    expect(searchCardText).toContain('Listen on Youtube');
    expect(searchCardText).toContain('Listen on Deezer');
    expect(searchCardText).toContain('Listen on Apple Music');
    expect(searchCardText).toContain('Listen on Tidal');
    expect(searchCardText).toContain('Listen on SoundCloud');

    const youtubeLink = await page.getByText('Listen on Youtube').getAttribute('href');
    const deezerLink = await page.getByText('Listen on Deezer').getAttribute('href');
    const appleMusicLink = await page.getByText('Listen on Apple Music').getAttribute('href');
    const tidalLink = await page.getByText('Listen on Tidal').getAttribute('href');
    const soundcloudLink = await page.getByText('Listen on SoundCloud').getAttribute('href');

    expect(youtubeLink).toBe('https://www.youtube.com/watch?v=zhY_0DoQCQs');
    expect(deezerLink).toBe('https://www.deezer.com/track/144572248');
    expect(appleMusicLink).toBe('https://music.apple.com/us/album/do-not-disturb/1440890708?i=1440892237');
    expect(tidalLink).toBe('https://listen.tidal.com/search?q=Do%20Not%20Disturb%20Drake');
    expect(soundcloudLink).toBe('https://soundcloud.com/search/sounds?q=Do%20Not%20Disturb%20Drake');
  });

The regex needs updating:
export const SPOTIFY_LINK_REGEX = /^https:\/\/(open\.spotify\.com\/(track|album|playlist|artist|episode|show)|spotify.link)\/.*$/;

Unfortunately, after that it's not as simple as updating the fetch call to fetch(spotifyLink, { redirect: 'follow' }) as it redirects to a page that tries to open the app or show a button with a link to the correct URL. (I would use a[href^=https://open.spotify.com to get this)

I'll create a separate PR to address this issue :)


Drop Support for Py37

Python 3.7.x is just about end-of-life. A number of our dependencies have already dropped support, and I suspect many more will following the EOL date. Dropping will allow us to remove some of our work-arounds in the code, and update some of our syntax.

If folks here agree, I would propose we work through the existing PRs (the three active ones at least), release 0.9.0 as our last py37 supporting version, then drop support?


Add generate motion using torchio

Corrupt a CAPS by simulating motion artefact on MRIs. The image based motion simulation is made using the torchio implementation of Shaw's paper.

Tests and parallelized version have been added !


BUG: Fix login/signup button hover color along with more minor ux updates

Is there an existing issue for this?

[X] I have searched the existing issues

What went down?

The blue color of the login/signup page doesnt goes with the theme of the website. I will fix this along with more issues like:

the text 'New here' should be a normal text instead of a anchor link to another route
the 'forgot password' and 'sign up now' text should have some hover effects

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@vansh-codes go ahead


add authorizer field

What was changed

added authorization block to templates to specify Authorizer and ClaimMapper settings

Why?
This was done to allow overriding the noOp Authorizer and ClaimMapper when deploying via helm in the same way that the docker config_template.yaml handles overriding these values.
Checklist

Closes https://github.com/temporalio/helm-charts/issues/540

How was this tested:

TBD, working on this

Any docs updates needed?
I have updated the values file to include a commented example of the fields available. This matches what was implemented for tls field.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing in preference of a PR from an isolated branch: https://github.com/temporalio/helm-charts/pull/542


Extends custom token contract

Token contract may need additional requirements like adopting pos-controller. So ProjectNameToken extends ProjectNameCustomToken that implements its requirements.

solved (b768c5e212ec0d49193fb882832908c0e66e3a09, 29c9263b30939aeb9a3dcd4af65f906a25d595c4)
sampe project (04cb7b8ec9fa919b44d30b127bf023e09e0598e5)


[BEAM-2534] Handle offset gaps in Kafka messages.

KafkaIO logged a warning when there is a gap in offsets for messages.
Kafka also supports log compaction for topics some of the messages
are deleted leading to gaps in offsets. Log compaction removes earlier messages for key. This PR removes the log and accounts for offset gaps in backlog estimate.

+R @XuMingmin

Coverage increased (+0.02%) to 70.877% when pulling 15f6f7a591c8d430f2c18f725c60a7028bf98090 on rangadi:handle_offset_gaps into 1e16aa201ad0ab5bd12ab00deba044648074ca78 on apache:master.

+R @JingsongLi or @jkff

Reasonable. LGTM.

just one question that, as offsetGap is expected as the behaviour with Kafka compaction, is it needed to track it?

Not sure if it really matters in practice. If it doesn't, it will stay at zero.

Coverage decreased (-0.003%) to 70.857% when pulling cec89e7dc6cbb8fb2aea9fdc6cac0a09a6341d25 on rangadi:handle_offset_gaps into 1e16aa201ad0ab5bd12ab00deba044648074ca78 on apache:master.

@davorbonaci, please merge this when you get a chance.

Noting that @JingsongLi is a committer and has given LGTM, so can merge any time.

Thanks! @JingsongLi could you merge this? Thanks.

Sorry for delay. A few days ago on vacation. Merging.

np. Thanks @JingsongLi

@rangadi can you also open a cherry-pick PR to the release-2.1.0 branch? (if you haven't already)


Propagate errno for proper error messages

I'm using libE57Format through pye57 and noticed that E57_ERROR_OPEN_FAILED is raised for any error, including standard cases such as:

no such file or directory
permission denied
too many open files

Most software can point out these error reasons by consulting errno (e.g. via strerror()), or at least guaranteeing in the API docs to not mess with errno so that the caller can inspect errno themselves.
It would be great if libE57Format could do one of these so that users can get much better error messages along with E57_ERROR_OPEN_FAILED.

I'm not sure I can guarantee the state of errno, but what I can do is provide the errno & string in the exception context.
So instead of:
result=-1 fileName=./no-path/foo.e57 flags=1538 mode=438

We'd have:
errno=2 error='No such file or directory' fileName=./no-path/foo.e57 flags=1538 mode=438

I don't know what pye57 does with the exception context, but would this solve your issue?

Yes, that would solve the issue!


Fix question layouts

Recent changes to use the components for smart answers introduced a few question readability problems, specifically to do with the layout of questions - body text was appearing in the wrong place, hint text was sometimes not appearing.
Example of the problem (from this smart answer):

Solution:

Another problem was that suffixes (text immediately to the right of some value questions, e.g. "days") didn't make sense in the new layout, or repeated what was already said in the question.
This PR solves these problems by doing the following layout changes:

where components have a description field as well as a hint, body text is used for description and so included after the question label or legend (multiple choice question, date question)
where components do not have a description field, body text, hint text and suffix text are combined into a single element and used for the hint text (value questions)

This PR also includes some content changes to questions, where the above measures did not help with the text layout of the questions. These content changes are from this content spreadsheet and only those needed and marked as okay to do have been implemented.
This PR also fixes a bug with date questions, where if the year range started with a higher number (e.g. a range between 2019 and 1900) the range would return 0. This is fixed by using the smallest number as the start of the range (this happened in 'Calculate your married couples allowance' on the age of the husband question).
This PR also updates the 'all smart answer questions' test question to have more data in it, to improve the reliability of it when testing.

I'm seeing a missing line of text on the maternity/paternity/adoption checker:
Preview app:

Live:

This input is feels strangely wide - do you think it could be made less wide?
Page found on: https://smart-answers-preview-pr-4150.herokuapp.com/am-i-getting-minimum-wage/y/current_payment/not_an_apprentice/34/31
Currently:

Maybe:

I think the lists need extra spacing between each list item to mirror govuk-list govuk-list--bullet styling.
Extreme example from https://smart-answers-preview-pr-4150.herokuapp.com/landlord-immigration-check/y/GU7 2LN/yes/yes/somewhere-else/no/no/no/no/no/no
Without govuk-list govuk-list--bullet:

With govuk-list govuk-list--bullet:

I think the lists need extra spacing between each list item to mirror govuk-list govuk-list--bullet styling.
Extreme example from https://smart-answers-preview-pr-4150.herokuapp.com/landlord-immigration-check/y/SW1A 2AA/yes/yes/somewhere-else/no/no/no/no/no/no
Without govuk-list govuk-list--bullet:

With govuk-list govuk-list--bullet:

I gave feedback to Andy elsewhere which he has incorporated.
Just to explain the spreadsheet he linked in the description above...
When I was working on Smart Answer 3 years ago, I planned to implement the standard patterns. And when I tested that I discovered that there are a lot of content issues preventing this. The spreadsheet lists all of those issues (from 3 years ago):

The “suffix_label” tab lists questions that have something that is to the right-hand side of a label. That would cause trouble because we don't have such a pattern. The content designers back then agreed that it's best to remove all of them and, if necessary, incorporate their meaning into the question instead. This PR removes them.
The “label” tab lists questions which have a label. Because most input fields in smart answers don't actually have a label but the actual question should be one (or a legend), that would cause trouble because then you'd have two labels. The content designers back then agreed that it's best to just remove those labels as all of them just repeat what's already in the question/title. I believe this PR also removes those.
The “body” tab lists questions which have text between the title and the input. If the title became the label or legend, that would cause trouble because we have no pattern that has extra meaningful text after the label. Because that extra "body" text is usually important to the question and can be really long, it is very difficult to solve this so it still makes semantic sense. This PR fixes some of that.

There are still issues left with some of the "body" texts. This PR is definitely an improvement and to solve these issues is not in the remit of this PR. But I'd like to point this out just so it isn't forgotten.
One example of an issue that has now been created: This question has the question in the legend and the extra text underneath before the input. A screen reader users would go to the first radio button and get the legend read out in addition to the label but the legend doesn’t make sense without the additional text.
There are probably lots of similar issues left. (Best go through the spreadsheet to find out how many.) It's not a blocker as there are still ways for screen reader users to find the content. But ideally it should be on someone's radar to fix them.


Add newpax

Reasons for making this change:
The package newpax is new on CTAN. It creates .newpax for collecting information about the PDF.
Links to documentation supporting these rule changes:
https://github.com/u-fischer/newpax/blob/16e70917bc687f512bd54f574ebc9394b31c1b9e/doc/newpax.tex#L170

\pkg{newpax} writes the information to a file with the extension \texttt{pax} or \texttt{newpax}.

@shiftkey You accepted my last PR https://github.com/github/gitignore/pull/2663 - may I ask for merging this, too? That would also reduce the number of opened PRs 😇 🎉


⚠ Bofrost.at has degraded performance

In 68cea3b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 806 ms

Resolved: Bofrost.at performance has improved in 3234669.


⚠ Turnos 24x7 has degraded performance

In 956f84f, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 7261 ms

Resolved: Turnos 24x7 performance has improved in 8069141.


Use a ServiceLoader to discover WebEnvironments

The idea here is to lessen the touch points for frameworks when integrating with Shiro.  A property file and a WebEnvironment implementation should be all that is needed. The WebEnvironment can then provide additional defaults or customizations specific to that framework.
https://issues.apache.org/jira/browse/SHIRO-608

@leleuj added a couple tests and fixed a couple minor bugs.
It should be ready to go, but I still want input from buiji before merging

It looks good to me, yet the real implementation in buji-pac4j will be necessary to confirm everything is ok. I plan to release buji-pac4j v2.0.4 next week, but then I'll be able to handle that.

Great! keep me posted!

On my way to release buji-pac4j, I just saw that the latest Shiro version is 1.4.0-RC2. Is there any plan/date for a GA release?

Soon, I'd like to get this in first, and I there is another feature PR that
we migt be able to squeeze in. But no blockers.
On Mon, Jan 16, 2017 at 4:13 AM LELEU Jérôme<EMAIL_ADDRESS>wrote:

On my way to release buji-pac4j, I just saw that the latest Shiro version
is 1.4.0-RC2. Is there any plan/date for a GA release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/shiro/pull/53#issuecomment-272808652, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGGcllu5EJ5oojIgbA6AsB_fp_Z_zt9ks5rSzSygaJpZM4LPgxJ
.

OK. So I'm releasing a version 2.1.0-RC1 first (to accomodate wih 1.4.0-RC2).

@leleuj bump
Sorry to bug you, is there anything I can do to help move this along?

No problem, I'm done with pac4j version 2.0.0-RC1. I will work on that (maybe without upgrading to pac4j v2 though). I'll keep you posted.

Fairly straightforward!
Is this what you had in mind: https://github.com/bujiio/buji-pac4j/pull/54 + https://github.com/pac4j/buji-pac4j-demo/pull/12? Thanks

@leleuj defiantly the first step.
I'm not sure this works for that demo project but, hacked up the PR's you mentioned to give an idea what I'm talking about (these both depend on this PR):
First, define the service def:
https://github.com/bdemers/buji-pac4j/commit/dad7f345fafa3bf9f681f964559689b09bc57f54
The use it automatically:
https://github.com/bdemers/buji-pac4j-demo/commit/d51d550c310d996bf4d5ac797aabcfcf9d037548
I also swapped out the web.xml config for shiro's servlet fragment, but that is optional, just trying to demonstrate removing all of the basic config.
This should allow any framework to inject itself into the Shiro's configuration by just including a dependency.  Making it easier to get started with Shiro through another framework: Buji, Stormpath, Apache Zeppelin, Apache Geode, etc.
Thoughts?

OK. I see. But for sure, I tested it and it was working. But it's a lot better indeed to have this automatically detected. Is there some documentation somewhere? I couldn't find it.
Will update and test it again.

I updated the PR and tested your suggestions but it doesn't work, although it looks good. I tested everything with a local built Shiro and your PR merged in.
Am I missing something?

I'm not sure, the only thing that should be needed is the META-INF
service definition.  Try without the shiro-servlet-plugin, and just comment
out your web.xml init param for your Environment class.  I probably
shouldn't have mixed these two topics together, I was just trying to show
the ultimate goal of zero config.  Sounds like we should keep them
separate until we test them with Buji both in isolation.
On Wed, Feb 15, 2017 at 3:59 AM, LELEU Jérôme<EMAIL_ADDRESS>wrote:

I updated the PR and tested your suggestions but it doesn't work, although
it looks good. I tested everything with a local built Shiro and your PR
merged in.
Am I missing something?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/shiro/pull/53#issuecomment-279953491, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGGcjr5labgVoQ4u_PZE9NjJ8O1Oy7Xks5rcr5WgaJpZM4LPgxJ
.

OK. It's clearer now and the Pac4jIniEnvironment is automatically loaded (via the org.apache.shiro.web.env.WebEnvironment file).
I merged both PR: the new version buji-pac4j 2.2 is ready. I guess we said we would wait for the final 1.4.0 release of Shiro before releasing again buji-pac4j: what's the next step?

Great!
I'll clean this up a bit, check test coverage, javadoc etc, and merge it.

Yes! sorry I've been a bit slammed the past couple weeks, I'll get that in
today
On Wed, Mar 15, 2017 at 3:04 AM, LELEU Jérôme<EMAIL_ADDRESS>wrote:

Coming back on this. I don't see any recent snapshot in the Apache
repository. Can you merge this pull request?
When do you plan the 1.4.0 release? Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/shiro/pull/53#issuecomment-286658273, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGGchZRKosytzjOmzq44N8u-Pu45rwzks5rl42XgaJpZM4LPgxJ
.

Thanks. Keep me posted for the release as well.

@bdemers Can we merge that pull request? I'm flooded by complaints on the buji-pac4j-demo as it doesn't work, waiting for this PR. Thanks.
And plan a release...

@leleuj sorry about the wait, please feel free to yell at me if this happens again (or the wait is more then a weekend) I got caught up in some travel and forgot about this one.
I just pushed to the ASF, so it should sync here any minute

Great! I hate to yell a people doing open source for free ;-)

Ha, agreed, but I did said I would do this a while ago, so you would be will in your right to yell :D
Take a look through the open PR's, and see if there is anything that should be merged before we release, I know at least #62 should be, I can look at that tonight or tomorrow night.  (and lets move this portion of the conversation to the dev list)

I see 25 opened PRs: are they really? Because this one is still opened as well.
I don't see anything special, except: https://github.com/apache/shiro/pull/25 I guess we already merged it.
But this needs some cleaning ;-)

The github/ASF sync occasionally leaves issues PRs open if they are not tagged correctly.
We also don't have the ability to add labels to the PRs.  A while back I went through the JIRA's and converted patches into Pull Requests, but that probably adds confusion.  I'll go through them and mark the closed with a noticed to comment to reopen (they will still be linked to the original JIRA, so should still be valuable if anyone wants to pick them up)
That will leave a smaller handful for consideration.  If you see anything that you feel is more important then others please add comment in that issue.
(note: the ASF infra is working on support these Github issues, so it should not always be like this)

Given we already have a RC2, I would not add anything more for the final release.

Reminder: @bdemers the final release is expected very soon...

Already merged

@leleuj Sorry again about the wait.  I've been crazy busy
I took a quick look through the PRs and merged one that was a fix for new dev in 1.4, and another minor issue SHIRO-559
If you want to head up the next release, i can help with support

Is this the right process to follow: https://cwiki.apache.org/confluence/display/SHIRO/Performing+a+Release?


Hotfix 7.2.1

This adds some protective checks (not actual fixes) during the automatic update that is executed while the Tracker is open and running. As of 7.2.0 release, I have seen at least two people attempt to update shortly after starting up Bizhawk, only for it to fail. Not only does the update not complete, it also breaks halfway through the process of overwriting and removing files.
Goal of this PR
To be extra cautious during the parallel update process (while Tracker is running already). I don't want people corrupting their Tracker and stumbling to have to manually redownload the Tracker and lose files or settings.
So far I've witnessed two potential causes for this, both of which are included in this hotfix patch. As a note, this hotfix will be applied immediately to anyone attempting to use the Updater (v7.1.6+), as new code gets loaded after it's downloaded but before the update scripts run.

The Tracker files are kept inside a folder structure that includse OneDrive

This check identifies the folder path contains "OneDrive" and aborts the update process before any files are removed or replaced.

The Tracker files are kept on a separate harddrive that isn't the primary harddrive C:\

This is a simple check on the folder path.

To add to this, I was not able to reproduce either of this issues on my local machine.
While it's definitely possible that some users with Tracker files on OneDrive or a non-primary harddrive could still update without issue, there doesn't seem to be a good rhyme or reason for when it decides to break. This is really hard to pinpoint or even reproduce.
After Review
Please feel free to merge this in as soon as you want and create a new release. You can copy the release notes exactly from the old one (v7.2.0), as I want to keep showing that the major update includes the new Log Viewer.

Couldn't sleep, snuck in two additional fixes. One small one with icon colors, the other is larger and fixes a bug.
The Randomizer Log Parser failed for games/logs made with 4.4.0 Randomizer. This is because of the terrible method I chose to implement it, assuming the order of the log sectors remained consistent. Turns out, this isn't the case.
I fixed this by rewriting it to work purely on line number references instead of remove lines from a large table. This had a side-effect of greatly increasing the speed at which a log could be parse.


Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed

Describe the technical debt
Addressed a sonar qube issue that describes the cognitive complexity which is higher than 15  for a single method. Cognitive complexity needed to be reduced from 25 to 15 which is the allowed level of complexity.
Location : merge method OpenTracks\src\main\java\de\dennisguse\opentracks\stats\TrackStatistics.java

Proposed solution
I have used the 'Extract Function' method which is one of the methodologies usually implemented when there is high cognitive complexity present in a method.
This usually occurs when there is multiple nested if - else statements which increases the necessity of higher comprehensibility which needs to avoided. It emphasizes to keep things as simple as possible.
So, I have separated the number of if-else statements for each operation (eg : assigning value of start time) and enclosed it in separate methods which splits the nested if statements into individual methods which eventually reduces the cognitive complexity.
Side by Side Comparision Before Refactoring vs After Refactoring

Technical information

Device: Pixel_3a
OS: Android 12
OpenTracks version: v3.2.4
OpenTracks commit id

Issue resolved and added a detailed description regarding issue and fix


test/e2e: fix logging and namespace assignment

Fixes some inaccurate log statements. Also fixes a bug where
the default namespace for Contours was being inadvertently
reassigned during the two-Contour test, impacting other tests.
Signed-off-by: Steve Kriss<EMAIL_ADDRESS>

@skriss thanks for the PR, LGTM.


Update to most recent verson of jackson-databind

Signed-off-by: Peter Nied<EMAIL_ADDRESS>Description
Fixes https://www.whitesourcesoftware.com/vulnerability-database/CVE-2020-36518
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1679 (a0fbe1e) into main (920701e) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1679      +/-   ##
============================================
- Coverage     62.92%   62.44%   -0.49%
+ Complexity     3259     3232      -27
============================================
  Files           253      253
  Lines         18127    18126       -1
  Branches       3258     3249       -9
============================================
- Hits          11406    11318      -88
- Misses         5072     5160      +88
+ Partials       1649     1648       -1

Impacted Files
Coverage Δ

...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java
9.43% <0.00%> (-75.48%)
:arrow_down:

...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java
39.13% <0.00%> (-4.35%)
:arrow_down:

.../org/opensearch/security/support/ConfigHelper.java
80.39% <0.00%> (-1.97%)
:arrow_down:

...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java
49.18% <0.00%> (-1.64%)
:arrow_down:

...ic/auth/ldap/backend/LDAPAuthorizationBackend.java
57.57% <0.00%> (-0.38%)
:arrow_down:

...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java
28.35% <0.00%> (-0.38%)
:arrow_down:

...ecurity/ssl/rest/SecuritySSLReloadCertsAction.java
84.78% <0.00%> (-0.33%)
:arrow_down:

...a/org/opensearch/security/tools/SecurityAdmin.java
45.55% <0.00%> (-0.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920701e...a0fbe1e. Read the comment docs.

@cliu123 Yes we should

@peternied Good catch! Thanks for pointing this out!  : )  I'll wait for a bit to confirm if this will be backported to all the old branches for the next potential patch versions. If not, I'll revert it from 1.3 branch.

The decision hasn't been finalized yet. I'll revert this from 1.3 branch for now.


Trigger the deployment by matching the branch name instead of the tags

:v:
/cc @zendesk/vegemite
Description
Trigger the deployment by matching the branch name instead of the tags.
https://github.com/zendesk/zendesk_apps_tools/settings/environments/585835778/edit

Tasks

[ ] Include comments/inline docs where appropriate
[ ] Write tests
[ ] Update changelog here

References

JIRA: https://zendesk.atlassian.net/browse/VEG-2064

Risks

[low] GHA deployment update only

Has successfully triggered to published ruby gem: https://github.com/zendesk/zendesk_apps_tools/actions/runs/6181074791


markdown frontmatter using yaml (instead of codeblocks)

This fixes #92 using proposal 1 (see issue).
I simply change the comment string for markdown to ---.
As mentioned in the issue, I could also implement optional support for yaml frontmatter.
Just let me know.

Hi @skwde
I have checked markdown syntax for using three dashes --- as a comment header.
An example;
---
Some header
---

First three dashes are rendered as a seperator and next three dashes make above line a kind of header (title).
So I'm not sure this usage is correct for comment header.

Hi @alpertuna,
thanks for your quick response and sorry for my late one :).
Anyways, yes this looks fine to me.
I guess it depends on what renders markdown if the header is properly recognized.
In any case, I have never seen a fenced code block (as was used previously) being interpreted as a comment.


Fix bounds of generic argument parameters in methods

I did this already for Tuples which are invariant because they are final, e.g. instead of
interface Either<L, R> {
    <L2, R2> Either<L2, R2> bimap(Function<? super Tuple2<? super L, ? super R>, ? extends Tuple2<? extends L2, ? extends R2>> f);
}

we have
interface Either<L, R> {
    <L2, R2> Either<L2, R2> bimap(Function<Tuple2<L, R>, Tuple2<L2, R2>> f);
}

easier to read and no need for casting. However, the bounds in Tuple2<? super L, ? super R> where wrong though.

There are different cases that have to be hardened. E.g. there is the question, if a Monoid or Semigroup is covariant in general. E.g. can a Monoid<C> be used to combine B's if C extends B?
We find these cases in Foldable for example:
// can go wrong IMO, if the Monoid requires properties of U extends T, which T does not have
default T foldRight(Monoid<? extends T> monoid)

// should be like this IMO
default T foldRight(Monoid<T> monoid)

This is just an example. There are more method signatures which have to be fixed...

Here is another example of a bound that is currently suspicious:
interface Try<T> {
    <U> Try<U> flatMap(Function<? super T, ? extends Try<? extends U>> mapper);
    <U> Try<U> flatMapTry(CheckedFunction<? super T, ? extends Try<? extends U>> mapper);
}

When we follow the types (in the sense that @SuppressWarnings("unchecked") disappear, then this seems to be a better solution:
interface Try<T> {
    <U> Try<U> flatMap(Function<? super T, ? extends Try<U>> mapper);
    <U> Try<U> flatMapTry(CheckedFunction<? super T, ? extends Try<U>> mapper);
}

We had a similar issue before, please take a look at this:
Fix result bound of function argument of higher order functions #352

I think have we are fine for now.


question about  "loss_wrt_gt" keep rising while training

I use the same config as the author, but the "loss_wrt_gt" keep rising while training and the generate result just like random noise at about epoch10, I use tango pretrained model as the stage1 model as I don't train stage1 and only train stage2, is that the cause resulting in my situation?

How is the quality of your model's generation (FAD, etc)? IIRC loss_wrt_gt is not expected to decrease (that's not the goal of consistency distillation), and it stays at ~2 in my run. As long as loss_wrt_teacher decreases you're good.


Bundled postgresql does not survive chart upgrade

After a chart upgrade, the netbox pod crash-loops with the following output:
django.db.utils.OperationalError: FATAL:  password authentication failed for user "netbox"

It appears that the default database credentials generated with the bundled chart do not persist upgrade. This can be reproduced by added a noop annotation (or modifying the config map) and running helm upgrade

Issue is no longer present in 7e54108cf37cf7b77d7aaa5fb68d6ea59856135c. The postgres bundled dependency update in 741a664dab9457b3ded38b4a1c6fd3c438eec3f4 is the most likely explanation.

Hmm, yes, good catch. Do you have any thoughts about how to avoid this problem? I mean, aside from strongly recommending that an external PostgreSQL instance should be used, I guess...

I suspect the culprit is https://github.com/bootc/netbox-chart/blob/master/templates/configmap.yaml#L27.
postgresql-password seems like it is randomly generated when bundled chart is rendered (https://github.com/bitnami/charts/blob/master/bitnami/postgresql/templates/_helpers.tpl#L59), but it is likely only evaluated when the database is initialized on first run. It's ultimately fed in as POSTGRESQL_PASSWORD (https://github.com/bitnami/bitnami-docker-postgresql#setting-the-root-password-on-first-run), which "when running the image for the first time will set the password", according to the maintainer.
Given this, the best (read: simplest) course of action (aside from using an external instance, of course), is probably just to set postgresqlPassword for the user by default, to prevent the password from auto-generating every time Helm renders the postgres chart. Obviously users should override this password if they're going to use the bundled postgres chart for anything but development purposes.
postgresql:
  ## Deploy PostgreSQL using bundled chart
  # To use an external database, set this to false and configure the settings
  # under externalDatabase
  enabled: true

  postgresqlUsername: netbox
  postgresqlPassword: netbox
  postgresqlDatabase: netbox

I think the best approach is to make it clear in the README that the password must be supplied if you're using the bundled PostgreSQL: https://github.com/bootc/netbox-chart/commit/b851d9f9ee88bd5dde93d00253880f716b457ada
Are you happy that that covers this problem off?


Implement MyGrad

Not sure what the issue is - works on my computer and the x86 locally.

NumPy 2.0 was released yesterday (6/16) and has some updates that aren't supported. Fixed it by specifying last NumPy version (1.26.0)

Yeah I saw the NumPy 2.0 announcement pop up on Hacker News and immediately thought "oh shit, this is gonna break some things :("


Standardized sample code

Added braces in the sample code.
Summary
According tip "Through the rest of this tutorial, the code samples all include the braces, following accepted practices." in C# guide -> Get started -> Branches and loops -> Make if and else work together(https://learn.microsoft.com/en-us/dotnet/csharp/tour-of-csharp/tutorials/branches-and-loops?tutorial-step=2), the sample code should include braces if there are branches. However, there is no braces before this pull request. Braces have been added to this pull request to standardize the sample code.
Note: This is the first pull request I submitted. If there are any mistakes, please correct them, thanks.

@dotnet-policy-service agree


Setup notebooks to have a ToC

Expected Behavior

See this:
https://github.com/jupyterlab/jupyterlab-toc
Get this working on the template notebook with reasonable defaults

This seems to be a jupyterlab plugin rather than a project specific thing


Template for adding fan codes

Hi,
I want to add codes found from my ceiling fan (DCG brand) but I don't know how to do it.
I tried to modify an existing json file but I have more codes other than only speed:
speed: low, medium, high
timer: 1h, 2h, 4h
fan off
light on\off
So, how should I do?

I'm sorry but you can not add these extra codes. Only HA fan platform functions are allowed


comments section not working

I just uploaded the theme to my repo but it seems comments not working. Is there any setting for this?
Thanks

Comments rely on disqus, check it out and set up your disqus credentials in _config.yml file.


Add managed-ledger admin tool to access ml binary information

Motivation
After merging #394, broker will start storing managed-ledger data into binary format which can't be access by bin/pulsar zookeeper-shell anymore. So, incase of any data-corruption (eg. any human-error while accessing znode), we need a quick way to build a tool/script to access ml-data. therefore, adding python-admin tool which provides API and command-line tool access to access ml data.
Modifications
Added a tool which provides api to

get managed-ledger info
get managed-cursor info
update markDelete of managed-cursor
update ledger-list of ml

Result
No functional change.

We don't have doc for managed-ledger protobuf compilation instruction. If we think it will be helpful then I will create a separate PR to add ML-protobuf location, compilation and will add python protobuf generation instruction as well.??

@merlimat  addressed all the changes.


DocumentInsertError when executing the second example (insertion into graph)

I run the community edition of ArangoDB on Ubuntu 18.04 and the version 4.4.0 of the python-arango module with python3.6.
When executing the two examples in the README here, the first one is ok (i see the students are inserted in the students collection as expected). But when running the second example, where a graph is to be constructed, I get a DocumentInsertError: Interestingly enough only with the SECOND insert, that of 'Jake Clark' while the first one of 'Anna Smith' is ok and I can see here entry in the students collection afterward...
No idea where that comes from. I ran into similar issues before when working on my own ArangoDB with the python-arango interface where I also constantly got DocumentInsertErrors "document not found" when inserting into a vertex_collection. I then thought "ok, let's at least successfully run the examples on the github README page and voila, same error.
Is this a known issue?  For now I have no idea what that could mean that the first (Anna Smith) insert should pass while the second (Jake Clark) does not.

Hi @zwurgl,
What is the error message and the error code in the exception?

Thanks for the quick reply!!
I have started fresh and need to be more precise: When doing an insert of a vertex for the first time, it works. On a fresh ArangoDB, your code in the REAMDE works ok. Sorry for the confusion.
When accidentally doing an insert of a vertex again that is already in the DB, the error code below is returned: That is what confused me (why do I get "document not found" when in this case rather the opposite is true: Apparently an error is thrown when a doc had already been inserted in the past. Would it perhaps make sense to return a message that says "DocumentInsertError: document had been inserted before"?
So in essence: So far it was my error. I need to catch these cases.
Thanks again, Zwurgl
students.insert({'_key': '01', 'full_name': 'Anna Smith'})

File "/usr/local/lib/python3.6/dist-packages/arango/collection.py", line 2527, in insert
return self._execute(request, response_handler)
File "/usr/local/lib/python3.6/dist-packages/arango/api.py", line 58, in _execute
return self._executor.execute(request, response_handler)
File "/usr/local/lib/python3.6/dist-packages/arango/executor.py", line 81, in execute
return response_handler(response)
File "/usr/local/lib/python3.6/dist-packages/arango/collection.py", line 2520, in response_handler
raise DocumentInsertError(resp, request)
arango.exceptions.DocumentInsertError: [HTTP 404][ERR 1202] document not found

Hi @zwurgl,
Yes that misleading error is actually a bug on ArangoDB side. You get a "document not found" when in fact you should be getting a duplicate key error.
Perhaps you are just copy pasting the example too many times? The example assumes that your database is empty with no collection/document names taken.


MA Legislature API bugs

This issue tracks bugs in the MA Legislature API.

Details for some hearings return HTTP 500 errors (4233, 4230)
Details for similar bills for some bills return HTTP 400 errors with the below status (H4515, H4910):
Error: Could not locate any public Documents in General Court "{0}".

@alexjball still open or good to close?

@mvictor55 I think these are still an issue

I think this is explained by i) not all bills have hearings (99.9% do -- but there are some outliers that are just strange customs or governor-filed, etc. and ii) not all bills have "similar bills". I think similar bills captures identical bills intro'd in the other chamber, and identical bills intro'd in previous sessions.

It's helpful to track these bugs, but I don't think there's any work we can do on these.


Adding a decision record for SDKs.

Adding a decision record for SDKs. Updating other links and typos as well.

@msfussell  if it looks good, could you please approve it.


error when make command

with gcc 8.2.0
[ 25%] Building CXX object libvast/CMakeFiles/libvast.dir/src/meta_index.cpp.o
/usr/local/src/vast/libvast/src/meta_index.cpp: In instantiation of ‘vast::meta_index::lookup(const vast::expression&) const::<lambda(const vast::predicate&)>::<lambda(auto:9)> [with auto:9 = vast::meta_index::lookup(const vast::expression&) const::<lambda(const vast::predicate&)>::<lambda(const vast::attribute_extractor&, const vast::data&)>::<lambda(auto:12&)>]::<lambda(auto:10&, auto:11&)> [with auto:10 = const vast::uuid; auto:11 = const std::unordered_map<vast::record_type, std::vector<caf::intrusive_ptr<vast::synopsis> > >]’:
/usr/local/src/vast/libvast/src/meta_index.cpp:136:17:   required from ‘vast::meta_index::lookup(const vast::expression&) const::<lambda(const vast::predicate&)>::<lambda(auto:9)> [with auto:9 = vast::meta_index::lookup(const vast::expression&) const::<lambda(const vast::predicate&)>::<lambda(const vast::attribute_extractor&, const vast::data&)>::<lambda(auto:12&)>]’
/usr/local/src/vast/libvast/src/meta_index.cpp:146:31:   required from here
/usr/local/src/vast/libvast/src/meta_index.cpp:124:11: internal compiler error:in tsubst_decomp_names, at cp/pt.c:16557
for (auto& [layout, table_syn] : part_syn)
^~~
0x5ce1de tsubst_decomp_names
        ../../gcc/cp/pt.c:16557
0x6f2ab0 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16810
0x6f174b tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16918
0x6f174b tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16918
0x6f1868 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16621
0x6f174b tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16918
0x6f03d8 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16606
0x6f03d8 instantiate_decl(tree_node*, bool, bool)
        ../../gcc/cp/pt.c:24053
0x6696e3 maybe_instantiate_decl
        ../../gcc/cp/decl2.c:5181
0x66ab66 mark_used(tree_node*, int)
        ../../gcc/cp/decl2.c:5282
0x60f145 build_over_call
        ../../gcc/cp/call.c:8257
0x611856 build_op_call_1
        ../../gcc/cp/call.c:4569
0x611856 build_op_call(tree_node*, vec<tree_node*, va_gc, vl_embed>**, int)
        ../../gcc/cp/call.c:4598
0x71c437 finish_call_expr(tree_node*, vec<tree_node*, va_gc, vl_embed>**, bool,                                               bool, int)
        ../../gcc/cp/semantics.c:2554
0x700060 tsubst_copy_and_build(tree_node*, tree_node*, int, tree_node*, bool, bo                                              ol)
        ../../gcc/cp/pt.c:18498
0x6f21e1 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:17434
0x6f1fc5 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16635
0x6f1868 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16621
0x6f1daa tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16830
0x6f1868 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
        ../../gcc/cp/pt.c:16621
Please submit a full bug report,

with clang 7.0.1
[ 60%] Linking CXX executable ../bin/vast-test
CMakeFiles/vast-test.dir/test/address.cpp.o: In function `log<caf::term>':
/usr/local/caf/include/caf/test/unit_test.hpp:325: undefined reference to `caf::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, caf::term)'
/usr/local/caf/include/caf/test/unit_test.hpp:327: undefined reference to `caf::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, caf::term)'
...(many messages of undefined reference)
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/vast-test] Error 1
make[1]: *** [libvast/CMakeFiles/vast-test.dir/all] Error 2
make: *** [all] Error 2

I am using the following commands to install CAF:
git clone https://github.com/actor-framework/actor-framework.git
cd actor-framework/
./configure --with-clang=clang++
make
make test
make install
I have gcc 8 and clang 7 on my device.

with gcc 8.2.0
/usr/local/src/vast/libvast/src/meta_index.cpp:124:11: internal compiler error:in tsubst_decomp_names, at cp/pt.c:16557
for (auto& [layout, table_syn] : part_syn)
^~~

This is a known error that can be worked around by upgrading to gcc 8.2.1 or 8.3.

with clang 7.0.1
[ 60%] Linking CXX executable ../bin/vast-test
CMakeFiles/vast-test.dir/test/address.cpp.o: In function `log<caf::term>':
/usr/local/caf/include/caf/test/unit_test.hpp:325: undefined reference to `caf::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, caf::term)'
/usr/local/caf/include/caf/test/unit_test.hpp:327: undefined reference to `caf::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, caf::term)'
...(many messages of undefined reference)
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/vast-test] Error 1
make[1]: *** [libvast/CMakeFiles/vast-test.dir/all] Error 2
make: *** [all] Error 2

I am using the following commands to install CAF:
git clone https://github.com/actor-framework/actor-framework.git
cd actor-framework/
./configure --with-clang=clang++
make
make test
make install
I have gcc 8 and clang 7 on my device.

Can you try to set the environment variables CC=clang and CXX=clang++ instead of --with-clang when building CAF? I'm not sure if that will help though.

The gcc 8.3.0 is working, and the environment variables CC=clang and CXX=clang++  still have problems.
Thanks.

Glad that it works for you now.
Another guess for the clang problem might be that CAF gets built with libstdc++ and VAST with libc++, which can lead to this kind of linker problems.
I will close this but feel free to reopen in case you want to try again with clang and still run into issues.


feat: Decode MSI Stream names

Please fill out the following checklist:

[x] Added tests for any new behavior
[x] All unit tests are passing (please make sure all tests are passing for your branch/PR at https://ci.appveyor.com/project/activescott/lessmsi/history )

Preview:

Thanks @learn-more! Can you please fix the few "Codacy Static Code Analysis" points above to get that check to pass and then I'll merge it and publish a release.

@activescott force-pushed the fixes.

:tada: This PR is included in version 1.10.0 :tada:
The release is available on:

v1.10.0
GitHub release

Your semantic-release bot :package::rocket:


Include a basic topic status

Include topic statuses we want to surface for MVP:

In-sync- Topic is available and all partition replicas are in-sync (see under-replicated definition)
Under-replicated: A partition is under-replicated if some replicas are not 'in sync'. A replica is 'in sync' if the follower has fetched records up to the log end offset within replica.lag.time.max.ms.

The topic status will surface in the following places:

Cluster overview: Show an aggregated number of in-sync/ Under-replicated topics with the ability to click and drill down to a pre-filtered topic list.
Topic list: Status column, provide a tooltip when the status is under-replicated with the number of under-replicated replicas, filter list by "All statuses, In-sync, Under-replicated."

@katheris

This is mostly completed (via #219) with the exception of tool tips and the cluster overview, which is a draft PR currently, #206.


What license is this released under?

Which license is this provided under? I've made NixOS/nixpkgs#250556 but the question has been raised regarding which license this provider uses, as in my original commits for the PR I had assumed it was under MPL. If I could get some clarification it'd be much appreciated, thank you.

Thanks for asking, @srounce, and thank you for adding that Nix package! This was definitely an oversight on our part. Our team is reviewing this PR currently to add a LICENSE file: #55

Lovely thank you very much, I'll update the Nixpkgs PR once that's merged.

Merged! Thanks again for letting us know about this!

@nmanoogian Sorry to keep on at this, but would it be possible to cut another release with the license included as it doesn't apply retrospectively to already released versions.

No worries! terraform-provider-doppler v1.2.4 is now live with the updated license 👍


Update table_printer.py

Previously if we added more elements in the first sublist, it raised an "index out of range" error.
So I added try and except.
If we added more elements in other sublists, it didn't print those elements.
I added a block of code(lines 20 to 23 and line 29) that solves this issue.

Hi sorry for the late response on this.
I appreciate the Pull Request and agree that the changes make the code more flexible. However, the project specifies that we can make the assumption that each list has the same number of items so the original code is adequate.
This repository is more of a historical document of what I did back when I was working through AtBS that I hope others find useful. Some of the latter projects are for services that have changed or no longer exist and every script would be significantly different if I were to write it again today. As such, I am going to leave the script as it is. Hope you understand why and are enjoying working your way through the book.

Yes, I understand and I, do appreciate you taking the time to check it and respond.


How to get Call of Duty WaW working and black ops working

Can't delete issue so...
Randomizing steam ids and deleting profile data seems to not work with dll, I just needed a way to import dlls automatically, but recently found out about code caves. I'll be implementing this myself to some degree.

Hi,
Were you able to get it to work? Is the problem just profile stuff? How can I help?
Thanks.


Agent cleanup

Routines to deassign tasks claimed by inactive agents and to delete lost agents
Updated ForeignKey onupdate and ondelete constraints to enable agent deletion
a hack to automatically enable foreign key constraints in SQLite

The log output (stdout) of the tests are quite verbose... Any way to tune it down?
See: https://travis-ci.org/SLAMon/slamon-agent-fleet-manager/jobs/81385213#L348 Those stacktraces etc. are quite distracting + it feels like the tests are failing even though the behavior is expected.

(venv)jami@debian:~/workspace/slamon-agent-fleet-manager$ flake8 --max-line-length=120 slamon_afm/
slamon_afm/app.py:2:1: F401 'datetime' imported but unused
slamon_afm/app.py:2:1: F401 'timedelta' imported but unused
slamon_afm/app.py:9:1: F401 'Agent' imported but unused
slamon_afm/app.py:9:1: F401 'Task' imported but unused
slamon_afm/tests/agent_routes_tests.py:136:110: E502 the backslash is redundant between brackets
slamon_afm/tests/agent_routes_tests.py:138:110: E502 the backslash is redundant between brackets
slamon_afm/tests/agent_routes_tests.py:140:110: E502 the backslash is redundant between brackets
slamon_afm/routes/dashboard_routes.py:35:104: E711 comparison to None should be 'if cond is None:'

Fix these please

Were you planning on updating this PR further or?

Yes, later today

there.


Missing package.json file in drupal installation

After running yarn run dev, I'm getting this error:
error Couldn't find a package.json file in "/var/www/drupal/public_html/backend/web"
Does the Drupal installation need a packages file?

The answer is no, I was in the wrong directory.


.NET 8 Warning NETSDK1206 and not loading version/distribution specific lib *.ubuntu.22.04-x64

I'm using the <PackageReference Include="EphemeralMongo6.runtime.ubuntu.22.04-x64" Version="1.1.3" Condition="$([MSBuild]::IsOSPlatform('Linux'))" /> as mentioned in #36 but my CI pipeline cant find the lib internal files. The pipeline runs on mcr.microsoft.com/dotnet/sdk:8.0 image.
Bellow its the first error message on my pipeline:
/usr/share/dotnet/sdk/8.0.300/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(284,5): warning NETSDK1206: Found version-specific or distribution-specific runtime identifier (s): ubuntu.22.04-x64. Affected libraries: EphemeralMongo6.runtime.ubuntu.22.04-x64. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.
As far as I understand, .NET 8 won't load this library because it has a specific distribution on its name, which causes a second error message:
System.IO.FileNotFoundException : Could not find mongod in the following paths: '/github/workspace/tests/***.IntegrationTests/bin/Debug/net8.0/runtimes/linux-x64/native/mongodb/bin/ mongod'
Maybe suffixing it with "linux-x64" would make .NET 8 build include this lib correctly for linux, but im not sure. Nobody had this error like me?

Actually the lib files are ben included, just not in the right folder, so the workarond proposed by @wcgomes in #48 did the trick just by coping the file to the right folder. I will close this issue.

Do you mind to reopen it? Because we have the same issue.


Improve interface for running evaluation diagnostics

This should allow you to apply an operator chain to a model data dump, producing a plot.

First need to figure out what we want it to look like

Question not well defined. I don't know what I was asking.


Modified methods to throw NOTFOUNDEXCEPTION instead RuntimeEror in ne…

…o4j_proxy (metadata_service)

Summary of Changes

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely, including a title prefix.
[ ] PR includes a summary of changes.
[ ] My commits follow the guidelines from "How to write a good git commit message"

Try block in _put_resource_description & put_column_description method in neo4j_proxy in metadata service throws RuntimeError when table or column doesn’t exist. I have changed it to throw NotFoundException with 404 status code.

Hey, @dorianj  I think there is one more step of approval required. I am not sure, once approved then why need extra approval.

Hey, @dorianj Can you please look at this PR once?? I think your approval is required again.


Cannot re-enter game after exiting game and clicking "Single Player" again

Clicking "Single Player" after exiting the game and returning to the main menu crashes the game.
Message caused by exiting the game:
thread 'thread '<unnamed><unnamed>' panicked at '' panicked at 'thread 'called `Result::unwrap()` on an `Err` value: "SendError(..)"called `Result::unwrap()` on an `Err` value: "SendError(..)"<unnamed>', ', ' panicked at 'C:\Users\ed223\voxel-rs\common\src\debug.rscommon\src\network\dummy.rs:called `Result::unwrap()` on an `Err` value: "SendError(..)":104', 51::common\src\debug.rs1438
:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
69:14
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', C:\Users\ed223\voxel-rs\common\src\debug.rs:104:14

Message caused by trying to re-enter the game:
[2020-12-28T09:13:57Z ERROR gfx_memory::heaps] Heaps not completely freed before drop. Utilization: MemoryHeapUtilization { utilization: MemoryUtilization { used: 124979200, effective: 113232384 }, size:<PHONE_NUMBER> }
[2020-12-28T09:13:57Z ERROR gfx_memory::heaps] Heaps not completely freed before drop.


Integrate trusted builder wrappers with endorsement generation policy

For example, make an executable program that can be given a few command line options to wrap the relevant trusted builders, combine this with a supplied endorsement generation policy, run this on the outputs of the trusted builders, and either throw an error or produce an endorsement file accordingly.

Similar story as #93, since all we actually had to do was parse a new field in the provenance wrappers this was also fixed when #98 was fixed.


Update validate.c

Fixes false negative when checking that a tank's min/max levels fall within its volume curve.

@LRossman, please try creating a new commit to trigger the appveyor build again. Find below the link to my test when I manually triggered appveyor , and looks good! It might be a connection issue. We can update the before-test.cmd like:
curl -fsSL --retry 3 --retry-delay 5 -o examples.zip %TESTFILES_URL%
https://ci.appveyor.com/project/Mariosmsk/epanet-v0m0d/builds/49436000
https://github.com/OpenWaterAnalytics/EPANET/pull/759#issuecomment-2004843968


Stdlib UI controls

As mentioned in #27, WidgetManager will only handle text and container widgets, and everything else will be built from those externally. Controls such as radio buttons and check boxes and scrollbars should be handled by an stdlib ui library. The menu builder in #135 will utilize this library.

No longer relevant to this repository.


What about the users that are already exists?

Hey there! Thanks for the package
What happens with the existing users? The id is only generated when you create an user?
Otherwise, I don't understand where to put the middleware

@mgarcia96 see UserReferral Trait


Add plugin from file/folder

While I am developing my templates/plugins I'd like to be able to add/load them from a local folder so I don't have to push my changes to GitHub for each minor change

as a workaround I can manually copy plugins to the local monokle-plugins folder and reload Monokle;

Windows: C:\Users[UserName]\AppData\Roaming\monokle\monoklePlugins
Mac: /Users/[username]/Libray/Application Support/monokle/monoklePlugins


Enhance the Beautiify heading

Fixes Issue🛠

Closes #
Description👨💻

Type of change📄

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

[] My code follows the style guidelines of this project
[] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have added demonstration in the form of GIF/video file
[] I am an Open Source Contributor

Screenshots/GIF📷

i have completed the task of Enhance the Beautiify heading even push also pls look into it

Pls mention the issue number for this PR, edit the PR description above and fill all the details properly.
Also, attach the screenshots of your work @sheetal-81

Done @Rakesh9100 pls do check and let me know what else i can do

I am asking the issue number which you are assigned to @sheetal-81

can i assume it is complete now ? Or do i have to apply more changes .
@Rakesh9100