Build error while compiling the examples with raylib-cpp

Hi,
Thanks for providing this cpp wrapper for raylib.
I'm getting the following build errors during "make" stage:
Scanning dependencies of target multiple [  2%] Building CXX object examples/CMakeFiles/multiple.dir/multiple/main.cpp.o In file included from /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:5:0,                  from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:38,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/././Vector3.hpp: In member function ‘raylib::Vector3& raylib::Vector3::DrawGizmo()’: /home/goksan/Downloads/raylib-cpp/include/././Vector3.hpp:295:11: error: ‘::DrawGizmo’ has not been declared          ::DrawGizmo(*this);            ^~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/././Vector3.hpp:295:11: note: suggested alternative: ‘DrawGrid’          ::DrawGizmo(*this);            ^~~~~~~~~            DrawGrid In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:38:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp: In constructor ‘raylib::Camera3D::Camera3D(Vector3, Vector3, Vector3, float, int)’: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:24:9: error: ‘type’ was not declared in this scope          type = typeValue;          ^~~~ /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:24:9: note: suggested alternative: ‘GetType’          type = typeValue;          ^~~~          GetType In file included from /home/goksan/Downloads/raylib-cpp/include/./AudioDevice.hpp:5:0,                  from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:34,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp: In member function ‘int raylib::Camera3D::GetType() const’: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:33:29: error: ‘type’ was not declared in this scope      GETTERSETTER(int, Type, type)                              ^ /home/goksan/Downloads/raylib-cpp/include/././raylib-cpp-utils.hpp:17:46: note: in definition of macro ‘GETTERSETTER’      inline type Get##method() const { return name; }  \                                               ^~~~ /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:33:29: note: suggested alternative: ‘GetType’      GETTERSETTER(int, Type, type)                              ^ /home/goksan/Downloads/raylib-cpp/include/././raylib-cpp-utils.hpp:17:46: note: in definition of macro ‘GETTERSETTER’      inline type Get##method() const { return name; }  \                                               ^~~~ /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp: In member function ‘void raylib::Camera3D::SetType(int)’: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:33:29: error: ‘type’ was not declared in this scope      GETTERSETTER(int, Type, type)                              ^ /home/goksan/Downloads/raylib-cpp/include/././raylib-cpp-utils.hpp:19:43: note: in definition of macro ‘GETTERSETTER’      inline void Set##method(type value) { name = value; }                                            ^~~~ /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:33:29: note: suggested alternative: ‘GetType’      GETTERSETTER(int, Type, type)                              ^ /home/goksan/Downloads/raylib-cpp/include/././raylib-cpp-utils.hpp:19:43: note: in definition of macro ‘GETTERSETTER’      inline void Set##method(type value) { name = value; }                                            ^~~~ In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:38:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp: In member function ‘void raylib::Camera3D::set(const Camera3D&)’: /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:159:9: error: ‘type’ was not declared in this scope          type = camera.type;          ^~~~ /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:159:9: note: suggested alternative: ‘GetType’          type = camera.type;          ^~~~          GetType /home/goksan/Downloads/raylib-cpp/include/./Camera3D.hpp:159:23: error: ‘const Camera3D {aka const struct Camera3D}’ has no member named ‘type’          type = camera.type;                        ^~~~ In file included from /home/goksan/Downloads/raylib-cpp/include/./AudioDevice.hpp:5:0,                  from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:34,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Material.hpp: In member function ‘float* raylib::Material::GetParams() const’: /home/goksan/Downloads/raylib-cpp/include/./Material.hpp:42:34: error: invalid conversion from ‘const float*’ to ‘float*’ [-fpermissive]      GETTERSETTER(float*, Params, params)                                   ^ /home/goksan/Downloads/raylib-cpp/include/././raylib-cpp-utils.hpp:17:46: note: in definition of macro ‘GETTERSETTER’      inline type Get##method() const { return name; }  \                                               ^~~~ /home/goksan/Downloads/raylib-cpp/include/./Material.hpp: In member function ‘void raylib::Material::SetParams(float*)’: /home/goksan/Downloads/raylib-cpp/include/././raylib-cpp-utils.hpp:19:50: error: incompatible types in assignment of ‘float*’ to ‘float [4]’      inline void Set##method(type value) { name = value; }                                                   ^ /home/goksan/Downloads/raylib-cpp/include/./Material.hpp:42:5: note: in expansion of macro ‘GETTERSETTER’      GETTERSETTER(float*, Params, params)      ^~~~~~~~~~~~ In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:44:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Material.hpp: In member function ‘void raylib::Material::set(const Material&)’: /home/goksan/Downloads/raylib-cpp/include/./Material.hpp:71:27: error: invalid array assignment          params = material.params;                            ^~~~~~ In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:45:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp: In member function ‘raylib::Matrix& raylib::Matrix::SetProjection()’: /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:93:11: error: ‘::SetMatrixProjection’ has not been declared          ::SetMatrixProjection(*this);            ^~~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:93:11: note: suggested alternative: ‘SetProjection’          ::SetMatrixProjection(*this);            ^~~~~~~~~~~~~~~~~~~            SetProjection /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp: In member function ‘raylib::Matrix& raylib::Matrix::SetModelview()’: /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:101:11: error: ‘::SetMatrixModelview’ has not been declared          ::SetMatrixModelview(*this);            ^~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:101:11: note: suggested alternative: ‘SetModelview’          ::SetMatrixModelview(*this);            ^~~~~~~~~~~~~~~~~~            SetModelview /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp: In static member function ‘static raylib::Matrix raylib::Matrix::GetModelview()’: /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:109:18: error: ‘::GetMatrixModelview’ has not been declared          return ::GetMatrixModelview();                   ^~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:109:18: note: suggested alternative: ‘GetModelview’          return ::GetMatrixModelview();                   ^~~~~~~~~~~~~~~~~~                   GetModelview /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp: In static member function ‘static raylib::Matrix raylib::Matrix::GetProjection()’: /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:116:18: error: ‘::GetMatrixProjection’ has not been declared          return ::GetMatrixProjection();                   ^~~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Matrix.hpp:116:18: note: suggested alternative: ‘GetProjection’          return ::GetMatrixProjection();                   ^~~~~~~~~~~~~~~~~~~                   GetProjection In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:46:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Mesh.hpp: In static member function ‘static std::vector<raylib::Mesh> raylib::Mesh::Load(const string&)’: /home/goksan/Downloads/raylib-cpp/include/./Mesh.hpp:32:26: error: ‘LoadMeshes’ was not declared in this scope          ::Mesh* meshes = LoadMeshes(fileName.c_str(), &count);                           ^~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Mesh.hpp:32:26: note: suggested alternative: ‘LoadModel’          ::Mesh* meshes = LoadMeshes(fileName.c_str(), &count);                           ^~~~~~~~~~                           LoadModel /home/goksan/Downloads/raylib-cpp/include/./Mesh.hpp: In member function ‘raylib::Mesh& raylib::Mesh::NormalsSmooth()’: /home/goksan/Downloads/raylib-cpp/include/./Mesh.hpp:183:11: error: ‘::MeshNormalsSmooth’ has not been declared          ::MeshNormalsSmooth(this);            ^~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Mesh.hpp:183:11: note: suggested alternative: ‘NormalsSmooth’          ::MeshNormalsSmooth(this);            ^~~~~~~~~~~~~~~~~            NormalsSmooth In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:49:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Mouse.hpp: In static member function ‘static int raylib::Mouse::GetCursor()’: /home/goksan/Downloads/raylib-cpp/include/./Mouse.hpp:75:18: error: ‘::GetMouseCursor’ has not been declared          return ::GetMouseCursor();                   ^~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Mouse.hpp:75:18: note: suggested alternative: ‘SetMouseCursor’          return ::GetMouseCursor();                   ^~~~~~~~~~~~~~                   SetMouseCursor In file included from /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:8:0,                  from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:55,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Texture.hpp: In constructor ‘raylib::Texture::Texture()’: /home/goksan/Downloads/raylib-cpp/include/./Texture.hpp:22:15: error: ‘::GetTextureDefault’ has not been declared          set(::GetTextureDefault());                ^~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Texture.hpp:22:15: note: suggested alternative: ‘GetTextureData’          set(::GetTextureDefault());                ^~~~~~~~~~~~~~~~~                GetTextureData In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:55:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp: In constructor ‘raylib::Shader::Shader()’: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:26:13: error: ‘GetShaderDefault’ was not declared in this scope          set(GetShaderDefault());              ^~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:26:13: note: suggested alternative: ‘GetFontDefault’          set(GetShaderDefault());              ^~~~~~~~~~~~~~~~              GetFontDefault /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp: In static member function ‘static Shader raylib::Shader::LoadCode(const string&, const string&)’: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:44:18: error: ‘::LoadShaderCode’ has not been declared          return ::LoadShaderCode(vsCode.c_str(), fsCode.c_str());                   ^~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:44:18: note: suggested alternative: ‘LoadShader’          return ::LoadShaderCode(vsCode.c_str(), fsCode.c_str());                   ^~~~~~~~~~~~~~                   LoadShader /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp: In member function ‘TextureCubemap raylib::Shader::GenTextureCubemap(const Texture2D&, int, int) const’: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:138:18: error: ‘::GenTextureCubemap’ has not been declared          return ::GenTextureCubemap(*this, panorama, size, format);                   ^~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:138:18: note: suggested alternative: ‘TextureCubemap’          return ::GenTextureCubemap(*this, panorama, size, format);                   ^~~~~~~~~~~~~~~~~                   TextureCubemap /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp: In member function ‘TextureCubemap raylib::Shader::GenTextureIrradiance(const Texture2D&, int) const’: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:142:18: error: ‘::GenTextureIrradiance’ has not been declared          return ::GenTextureIrradiance(*this, panorama, size);                   ^~~~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:142:18: note: suggested alternative: ‘GenTextureMipmaps’          return ::GenTextureIrradiance(*this, panorama, size);                   ^~~~~~~~~~~~~~~~~~~~                   GenTextureMipmaps /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp: In member function ‘TextureCubemap raylib::Shader::GenTexturePrefilter(const Texture2D&, int) const’: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:146:18: error: ‘::GenTexturePrefilter’ has not been declared          return ::GenTexturePrefilter(*this, panorama, size);                   ^~~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:146:18: note: suggested alternative: ‘SetTextureFilter’          return ::GenTexturePrefilter(*this, panorama, size);                   ^~~~~~~~~~~~~~~~~~~                   SetTextureFilter /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp: In member function ‘Texture2D raylib::Shader::GenTextureBRDF(int) const’: /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:150:18: error: ‘::GenTextureBRDF’ has not been declared          return ::GenTextureBRDF(*this, size);                   ^~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./Shader.hpp:150:18: note: suggested alternative: ‘GetTextureData’          return ::GenTextureBRDF(*this, size);                   ^~~~~~~~~~~~~~                   GetTextureData In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:62:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp: In member function ‘void raylib::VrSimulator::Init()’: /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp:26:25: error: too few arguments to function ‘void InitVrSimulator(VrDeviceInfo)’          InitVrSimulator();                          ^ In file included from /home/goksan/Downloads/raylib-cpp/include/././raylib.hpp:10:0,                  from /home/goksan/Downloads/raylib-cpp/include/./AudioDevice.hpp:4,                  from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:34,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /usr/local/include/raylib.h:1102:12: note: declared here  RLAPI void InitVrSimulator(VrDeviceInfo device);        // Init VR simulator for selected device parameters             ^~~~~~~~~~~~~~~ In file included from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:62:0,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp: In member function ‘raylib::VrSimulator& raylib::VrSimulator::Set(VrDeviceInfo, Shader)’: /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp:64:11: error: ‘::SetVrConfiguration’ has not been declared          ::SetVrConfiguration(info, distortion);            ^~~~~~~~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp:64:11: note: suggested alternative: ‘GetVrConfig’          ::SetVrConfiguration(info, distortion);            ^~~~~~~~~~~~~~~~~~            GetVrConfig /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp: In member function ‘raylib::VrSimulator& raylib::VrSimulator::Toggle()’: /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp:72:11: error: ‘::ToggleVrMode’ has not been declared          ::ToggleVrMode();            ^~~~~~~~~~~~ /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp:72:11: note: suggested alternative: ‘Toggle’          ::ToggleVrMode();            ^~~~~~~~~~~~            Toggle /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp: In member function ‘raylib::VrSimulator& raylib::VrSimulator::BeginDrawing()’: /home/goksan/Downloads/raylib-cpp/include/./VrSimulator.hpp:80:26: error: too few arguments to function ‘void BeginVrDrawing(RenderTexture2D)’          ::BeginVrDrawing();                           ^ In file included from /home/goksan/Downloads/raylib-cpp/include/././raylib.hpp:10:0,                  from /home/goksan/Downloads/raylib-cpp/include/./AudioDevice.hpp:4,                  from /home/goksan/Downloads/raylib-cpp/include/raylib-cpp.hpp:34,                  from /home/goksan/Downloads/raylib-cpp/examples/multiple/main.cpp:1: /usr/local/include/raylib.h:1106:12: note: declared here  RLAPI void BeginVrDrawing(RenderTexture2D target);      // Begin VR simulator stereo rendering (using provided fbo)             ^~~~~~~~~~~~~~ examples/CMakeFiles/multiple.dir/build.make:62: recipe for target 'examples/CMakeFiles/multiple.dir/multiple/main.cpp.o' failed make[2]: *** [examples/CMakeFiles/multiple.dir/multiple/main.cpp.o] Error 1 CMakeFiles/Makefile2:1044: recipe for target 'examples/CMakeFiles/multiple.dir/all' failed make[1]: *** [examples/CMakeFiles/multiple.dir/all] Error 2 Makefile:140: recipe for target 'all' failed make: *** [all] Error 2
Am I missing something here?
Thanks in advance

: ‘::GenTextureBRDF’ has not been declared return ::GenTextureBRDF(*this, size); ^
makes me think that raylib wasn't found. Have you built raylib before?

Hi,
Yes the problem was due to having the latest version of the raylib installed in the system path.

Ah, nice find! I've created a next branch which targets raylib master. Could likely do with an update!


Add Cyrilex to Regex / Sed

@all-contributors please add @cyr1l0u  for content

Thanks for the addition! Merging ;)


Make Quarto Multi-lingual or German only

We need:

Document language codes as German
Labels as German - Inhalt, etw
etc

Here are some resources:
https://docs.ropensci.org/babeldown/articles/quarto.html
This might be overkill - but lets see.
Please keep a record here of changes made in the system to either change to German or make multilingual.
Being multilingual would be best.

Quarto has its own ways of setting up multiple languages, but LaTeX has some kind of conflict with that. The lang: de bit loads the babel package, which breaks the entire thing because it's already being loaded by something else prior.
Not sure if that is worth figuring out or too time-consuming. I'll do the styling first and then take another look. Alternatively we might be able to use a custom language file that lists all the labels and their translations.

Yep lets leave the multilingual parts on the side. I'll log your note as an issue its self. These can be things we go to the Quarto community with.
@calnfynn - does Quarto allow us to set the single language as DE?

DE changes:
If possible you should take updates from the Main Repo on https://github.com/TIBHannover/semantic-glosar/ to your AR repo - if possible.
The changes on Main /TIBHannover/semantic-glosar that are important are:
guide.md
cosite001.ipynb
DE Translation changes needed.

Change the left menu items to German - where needed
Translate page content on: About and Imprint
Note also change _quarto.yml title and author to: Semantic Glosar; Team Co-Site

When ready on AR ping me and once I check you can pull request to Main /TIBHannover/semantic-glosar/

Please go ahead with the lang: de changes


Validation: Fix multiple issues

This PR address metadata and absolute links.

Docs Build status updates of commit eb6a5ab:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(2,8), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(13,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 059823c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/data-appconfiguration-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md

Line 0, Column 0: [Warning: h1-missing - See documentation] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(2,8), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(13,1)'. Titles must be unique within a docset.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

docs-ref-services/latest/data-appconfiguration-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 29, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6c424d6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:warning:Warning
View (azure-java-stable)
Details

docs-ref-services/latest/data-appconfiguration-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md

Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'Azure Cosmos DB OLTP Spark 3 connector' is duplicated in: 'docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md(2,8), docs-ref-services/latest/cosmos-spark_3-2_2-12-readme.md(13,1)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2a80fe1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

docs-ref-services/latest/data-appconfiguration-readme.md
:white_check_mark:Succeeded
View (azure-java-stable)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@kushagraThapar, @shafang
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!

Docs Build status updates of commit 7636239:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyVaultId.yml
:warning:Warning
View (azure-java-stable)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyVaultId(method).yml
:warning:Warning
View (azure-java-stable)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyVaultId(method).yml
:warning:Warning
View (azure-java-legacy)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyVaultId.yml
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyVaultId(method).yml
:warning:Warning
View (azure-java-stable)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyVaultId.yml
:warning:Warning
View (azure-java-stable)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyVaultId(method).yml
:warning:Warning
View (azure-java-legacy)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyVaultId.yml
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadSecret.yml
:warning:Warning
View (azure-java-stable)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadSecret(method).yml
:warning:Warning
View (azure-java-stable)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadSecret(method).yml
:warning:Warning
View (azure-java-legacy)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadSecret.yml
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.volumeType(method).yml
:warning:Warning
View (azure-java-stable)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.volumeType.yml
:warning:Warning
View (azure-java-stable)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.volumeType(method).yml
:warning:Warning
View (azure-java-legacy)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.volumeType.yml
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyURL(method).yml
:warning:Warning
View (azure-java-stable)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyURL.yml
:warning:Warning
View (azure-java-stable)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyURL(method).yml
:warning:Warning
View (azure-java-legacy)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.keyEncryptionKeyURL.yml
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadClientId(method).yml
:warning:Warning
View (azure-java-stable)
Details

docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadClientId.yml
:warning:Warning
View (azure-java-stable)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadClientId.yml
:warning:Warning
View (azure-java-legacy)
Details

legacy/docs-ref-autogen/com.microsoft.azure.management.compute.VirtualMachineEncryptionConfiguration.aadClientId(method).yml
:warning:Warning
View (azure-java-legacy)
Details

This comment lists only the first 25 files in the pull request.

Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'docs-ref-autogen/com.microsoft.azure.eventhubs.extensions.appender.yml' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'docs-ref-autogen/com.microsoft.azure.management.monitor.yml' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'docs-ref-autogen/com.microsoft.azure.sdk.iot.deps.ws.yml' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'legacy/docs-ref-autogen/com.microsoft.azure.management.batch.implementation.yml' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'legacy/docs-ref-autogen/com.microsoft.azure.management.monitor.implementation.yml' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'legacy/docs-ref-autogen/com.microsoft.azure.management.monitor.yml' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: redirected-file-not-removed - See documentation] Redirected file 'docs-ref-services/latest/batch-ai.md' are still in the repo. After adding a file to the redirection JSON file, you must delete the original file from the repo.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.frontdoor.FrontDoorManager.FrontDoorManager*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.frontdoor.FrontDoorManager.Configurable.Configurable*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.analytics.synapse.monitoring.MonitoringAsyncClient.MonitoringAsyncClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.baremetalinfrastructure.BareMetalInfrastructureManager.BareMetalInfrastructureManager*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.analytics.synapse.monitoring.MonitoringClient.MonitoringClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.baremetalinfrastructure.BareMetalInfrastructureManager.Configurable.Configurable*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.ai.documenttranslator.BatchDocumentTranslationRestClient.BatchDocumentTranslationRestClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.digitaltwins.core.DigitalTwinsAsyncClient.DigitalTwinsAsyncClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.digitaltwins.core.DigitalTwinsClient.DigitalTwinsClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.datamigration.DataMigrationManager.DataMigrationManager*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.mobilenetwork.MobileNetworkManager.MobileNetworkManager*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.iot.modelsrepository.DtmiConventions.DtmiConventions*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.microsoft.azure.sdk.iot.provisioning.service.EnrollmentGroupManager.EnrollmentGroupManager*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.iot.modelsrepository.ModelsRepositoryAsyncClient.ModelsRepositoryAsyncClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.microsoft.azure.sdk.iot.provisioning.service.IndividualEnrollmentManager.IndividualEnrollmentManager*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.resourcemanager.mobilenetwork.MobileNetworkManager.Configurable.Configurable*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.azure.security.attestation.AttestationAdministrationAsyncClient.AttestationAdministrationAsyncClient*'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'com.microsoft.azure.sdk.iot.provisioning.service.RegistrationStatusManager.RegistrationStatusManager*'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Removed changes that addressed absolute links and preserve-view issues.

Docs Build status updates of commit 9318018:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/data-appconfiguration-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/cosmos-spark_3-1_2-12-readme.md

Line 15, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/cosmos-db/sql-api-sql-query' will be broken in isolated environments. Replace with a relative link.
Line 16, Column 1: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/cosmos-db/' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/latest/data-appconfiguration-readme.md

Line 23, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration' will be broken in isolated environments. Replace with a relative link.
Line 30, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 30, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 32, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/quickstart-dotnet-core-app#create-an-app-configuration-store' will be broken in isolated environments. Replace with a relative link.
Line 80, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 104, Column 9: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 139, Column 6: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 168, Column 30: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/rest-api-authorization-azure-ad#roles' will be broken in isolated environments. Replace with a relative link.
Line 421, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/quickstart-java-spring-app' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@kushagraThapar, @Shafang
This PR was updated and ready for final review and merge. Thanks.

Abandoning this PR as all content is autogenerated.


Removed a space that broke one of the cmdlets

Remove-AzsDBAdapterLog was written as Remove- AzsDBAdapterLog.

@calcobia : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Jd dev

implement simple user context to allow for conditional rendering of components based on auth state

I was forced to delete the package-locks in order to deal with a conflict between npm and pnpm.  That accounts for the scary-looking number of deletions


Fix critical bug in LIF synaptic forward dynamics

When a LIF layer was used with synaptic dynamics (tau_syn not None) and normalization of membrane potentials (norm_input True), the synaptic current would be wrongly scaled by the normalization, resulting in incorrect simulation results during forward propagation.
This bug fixes it.

amazing find, thank you @bauerfe


A clang-diagnostic warning:'int' to 'size_type'  [clang-diagnostic-sign-conversion]

I use clang-tidy to check my code :
grpc-v1.4.0/include/grpc++/impl/codegen/service_type.h:109:40: warning: implicit conversion changes signedness: 'int' to 'size_type' (aka 'unsigned long') [clang-diagnostic-sign-conversion]     server_->RequestAsyncCall(methods_[index].get(), context, stream, call_cq,
grpc-v1.4.0/include/grpc++/impl/codegen/service_type.h:127:40:..  the same.
index is int ;  methods_[?] need  'size_type'

@vjpai : Is this worth fixing? (i.e std::vector indexes are supposed to be size_t but we are using int)- The code will look messy with too many typecast statements :)


 Straightened it out.

Hard to review. Please separate commits to:

renaming variables
reduction of copy/pasta code
logic improvements

I appreciate the sentiment, but I think you'll find in this case that one doesn't work without the other, because the logic had to be fixed to make the refactoring work, and vice versa.

As far as I see, there's bunch of unrelated changes to the "logic improvement" - updating copyright comment, variable renaming (result -> sresult), int to bool conversion, changing scanVar return type to void. Why do you think they should be done at once?
I really know, such the code refactoring is - even if it's trivial renaming - necessary for further improvements. But such the squashed one big commit is unfriendly for the reviewers.
If you want to do multiple things in one PR, they should be separated in the same number of commits. I think considering to the reviewability is the duty of contributors.

Consider things in proportion. The result->sresult is one character on one line (all the other lines with result were replaced for other reasons). This is not 500 lines of refactoring and 10 lines of bug fixing. scanVar returning void is necessary to fix a bug where eresult erroneously depended on it, and all the logic that set the return value was utterly broken and had to be removed. The int to bool change affected one line of code in logic that was redone anyway.
I know I've complained to you about refactorings mixed up with bug fixes. I have good reason to believe that those instances did impede review, due mostly to the size of them. I think you'll agree, though, that this is not the case here, and changing the file comment at the top hardly impedes understanding.

Walter, you made the changes so of course you understand them.  Others reading your PRs do not immediately know which parts are related, and which aren't.  Splitting up commits is so much easier than arguing about it.

Of course the refactoring changes are so small in this PR. But it was actually obstacle to my quick reviewing.
And I've reviewed this PR beyond the obstacles. The total change looks good to me.

After the review, I've found four improvements for the inline.d code.

Extract inlineScan on CallExp.e1 and arguments out of visitCallExp function.
-> I'm not sure why it's necessary to "logic improvement", but not a problem.

Add asStatements parameter to visitCallExp function, and then remove one copy/pasta code block.
-> Looks good.

Move the position of "verbose" message printing
-> It's another removing of copy/pasta code. Good.

scanVar returns void, and expandInline will return null when ps !is null
-> "scanVar returning void is necessary to fix a bug where eresult erroneously depended on it,  and all the logic that set the return value was utterly broken and had to be removed. "

If you had separated those changes (and refactorings) into independent commits, the review would have quickly finished. Especially, the #4 is difficult to understand from the diff view. I'd really prefer to record it as a commit log in the git history.

They are connected, @yebblies. The changes to visitCallExp caused scanVar's setting of eresult to break things. How was I supposed to make that a separate commit? Replace the return value with null and then ignore it? If I did that, I'd get (properly) dinged in code review.
Notice that visitCallExp now handles both inlining for statements and inlining for expressions. Trying to keep the original logic in scanVar did not work with that. Having visitCallExp do double duty now required rewriting the logic that triggered the verbose message printing, moving it outside the { } solved that.
The logic before was almost impossible to follow, particularly how eresult was set, because the save/restore of it implied recursion when it actually worked quite differently, and the save/restore was a hack somebody put in to work around scanVar setting eresult. Both functions need to be redone to untangle it.
I changed result to sresult because I tired of all the false positives when grepping for result. It's still only one line of additional change. I don't believe one line with a one character change causes anyone difficulty.
Again, it's about proportion. This is NOT a 500 line refactoring. It's a decent shrink, more than the line count suggests because I added many lines of comments.
This PR is a necessary step towards fixing the inlining issues everyone gripes about. Please pull it. If there's anything else you don't understand about it, I'll be happy to explain.

BTW, the git diff view makes things look more complex than they are. Just use that as a guide to where the changes are, and bring up the file separately, and you'll see that the logic flows better and is much simpler. You'll also find that searching for sresult is much more practical than searching for result - it will save time reviewing, not cost :-)

I wish you'll open a more reviewer-friendly PR in the next time.

Auto-merge toggled on

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=15296


Add assist player

Add assist player to game_events.
https://github.com/dcaribou/transfermarkt-scraper/pull/71

Hey @LarchLiu,
I think you also need to upgrade the transfermarkt-scraper depedency, so the latest changes you made are available. You can do so by running
poetry update transfermarkt-scraper

that should update the poetry.lock file, with the latest scraper changes.
Also, you'd ideally want to run the dbt project as well with the new data and ensure it works as you expect. I've recently added a template for codespaces, so it should be quite easy to spin up a dev environement (just click here).
Once the codespace has started, all you need to do is

Activate the poetry environment → Run command poetry shell
Initialise the data directory → Run command dvc pull
Run the scraper → Run command make acquire_local ARGS="--asset games --season 2023"
Run the dbt project → Run command make prepare_local

Ah, nice.
Then all that's missing then is the dependency upgrade then I think.
poetry update transfermarkt-scraper

Sorry, I'm not familiar with python and poetry. Pls check if the lock file is correct.

No problem 😄
I think you somehow got way more changes than necessary. All it's needed is this change

This basically tells poetry to use the latest commit from the master branch in transfermarkt-scraper.
You can remove everything else.


How to redraw elements after stage scale?

When i scale the stage (like app.stage.scale.x = 2), the rectangles and TilingSprites I drew become blurry.
How do I make sure they redraw on scale so that this won't happen?
thanks!

It shouldn't work like that. Please give more information.

I have an issue supplying working code because I use data that is dynamically generated in a complex piece of code.
but the point is that, I'm trying to do sort of Gantt:

and when I zoom in, I set the scale of the stage (only on X axis) and it looks bad:

The Tiling Sprites are blurry and the lines that border the primitive rectangle become very thick.
How can I handle redrawing so that the tiling sprite will re-render the repeating background and perhaps also handle the rectangle line border thing?

'tilingSprite.texture.baseTexture.scaleMode = PIXI.SCALE_MODES.NEAREST'
As for graphics there is nativeLine param in constructor, it works only for lineWidth=1. If you need bigger line width, you have to refill graphics according to scaling and pixi will re-create the mesh.
Adding dynamic line scaling in graphics is a huge problem, we are waiting for hero who solves it :)

If you need bigger line width, you have to refill graphics according to scaling and pixi will re-create the mesh.

How do I do that?
Can you guide me with a code snippet?

≈

'''tilingSprite.texture.baseTexture.scaleMode = PIXI.SCALE_MODES.NEAREST'''

also, I used this and this isn't the result I meant, I should have been more clear.
I wanted the background to repeat in its original resolution, not the stretched out one

tilingSprite.tileScale = 0.5 to compensate scale 2 on stage.

Can you guide me with a code snippet?

graphics.clear();
// now do everything again

The problem is that pixi Graphics does not have operation that re-calculates the whole mesh. Theoretically, its possible to do if you dig inside the code and figure out how to drop all graphicsData and redo it.
In practice, either people make it and don't report us back, either its too difficult. That's one of things that I'm waiting community to take care of.

tilingSprite.tileScale = 0.5 to compensate scale 2 on stage
For some reason this doesn't work, I'm not seeing the tiling sprite at all after applying this method:

Also:

As for graphics there is nativeLine param in constructor,

How do I provide this param?
I'm not seeing anything about it in the docs.
Thank you for your help, as you can tell, I'm new to Pixi :)

Never mind, I managed to figure it out.
I had to use tileScale.x instead of just tileScale.
Also, I figured that to use NativeLines I need to simply pass true or false to the Graphics constructor. Wish the docs made it more clear.
Thank you @ivanpopelyshev !


Typescript Support

Hey, i'd love to use this extension but with typescript.
Is there a way to make it possible?

Implementing metadata highlight in typescript files should be easy, but other (completion, hover hints) features may require interaction with typescript language service or building our own language service, which will be a hard work.
I position this extension as a small tool for viewing userscript code and writing simple userscripts, hence it only supports javascript.
If you prefer writing userscripts in typescript, maybe you can try this https://github.com/lisonge/vite-plugin-monkey.

If you prefer writing userscripts in typescript, maybe you can try this https://github.com/lisonge/vite-plugin-monkey.

Thats what i ended up using - thank you


typo: powerbi-docs/sql-server-analysis-services-tabular-data.md

adminsitrator -> administrator
swtiched -> switched

@nschonni : Thanks for your contribution! The author, @markingmyname, has been notified to review your proposed change.

Verified editorial corrections.

@rjagiewich : Thanks for your contribution! The author, @markingmyname, has been notified to review your proposed change.

@rjagiewich : Thanks for your contribution! The author, @markingmyname, has been notified to review your proposed change.


fix v2 drawer scrolling issues

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6293
Description (What does it do?)
This PR fixes various scrolling related to the new learning resource drawer. Firstly, clicking the "Show more" link on the description or the start dates were causing the main window to scroll to the top. This is caused by the scroll property on NextLink: https://nextjs.org/docs/pages/api-reference/components/link#scroll. It defaults to true, so whenever you click a NextLink, nextjs scrolls the window to the top. scroll can now be passed as a boolean argument to our Link component, which passes it on to the NextLink component. For the links inside the drawer, we pass false which prevents the scroll to the top from happening.
The second scrolling option here has to do with the cards in the recommendation carousel. Currently clicking them reloads the drawer, but does not scroll the drawer to the top. In order to fix this, code was added to LearningResourceExpandedV2 to reset the scroll position if the resource ID in the query string has changed.
How can this be tested?

If you have Posthog set up locally, enable the lr_drawer_v2 flag
If you don't have Posthog set up locally, you can force drawerV2 to be true in LearningResourceDrawer.tsx
Ensure that you have backpopulated some courses into your local database for testing
On line 119 of LearningResourceDrawerV2, temporarily set carousels={[similarResourcesCarousel, similarResourcesCarousel, similarResourcesCarousel]} to create enough scrollable content to demonstrate the second issue detailed above
Spin up this branch of mit-learn
Visit the search page at http://localhost:8062/search
Search for a course with a long description and many start dates, such as "Global Manufacturing Leadership Program"
When the search result is returned, scroll to the bottom of the page and then click the card to bring up the drawer
Click "Show more" both below the description and near the start dates, verifying that the page behind the drawer does not scroll to the top
Scroll down within the drawer and click one of the cards in the recommendation carousels, verifying that the drawer is scrolled to the top

@ChristopherChudzicki Thanks, this is ready for another look now


Specifying 'QueryTimeout' issues a LOCK_TIMEOUT on the server

In the pdo_sqlsrv and sqlsrv drivers it looks like setting 'QueryTimeout' actually issues a LOCK_TIMEOUT command on the server. Here's an example with PDO:
$pdo = new PDO(...);
$pdo->setAttribute(PDO::SQLSRV_ATTR_QUERY_TIMEOUT, 30);
$pdo->exec(
  '
    WAITFOR DELAY \'00:00:40\'; SELECT 1
  '
);

This likely isn't what we want as read queries that don't take any locks and exceed this timeout won't be killed.
Is there a recommended approach to ensure that read queries don't exceed a user specified query timeout?

It also looks like every statement will produce a command to SET LOCK_TIMEOUT resulting in an extra roundtrip to the server. Is it possible to make this part of the DSN so that the command need only be issued once but can be overridden by an individual statement?

Hi @gjdanis, where did you see that LOCK_TIMEOUT was used?

Hey @yitam I opened up SQL Server Profiler - you should see it executed before each query.

hi @gjdanis
Using your repro script, I could see that the query took roughly 40s to return. It seems that query timeout has no effect on PDO::exec().
That being said, if using a prepared statement, then query timeout works. For example,
$t0 = microtime(true);

$options = array(PDO::SQLSRV_ATTR_QUERY_TIMEOUT => 2);
$query = 'WAITFOR DELAY \'00:00:40\'; SELECT 1';

$stmt = $conn->prepare($query, $options);
echo $stmt->getAttribute( constant( "PDO::SQLSRV_ATTR_QUERY_TIMEOUT" ) ) . PHP_EOL;
$result = $stmt->execute();

$t1 = microtime(true);

$elapsed = $t1 - $t0;

echo "Time elapsed: $elapsed secs with result:\n";
var_dump($result);

print "Done\n";

The output I got was
2
Time elapsed: 2.0018880367279 secs with result:
bool(false)
Done

Will investigate some more and get back to you on this.

Hey @yitam any update on this?
I can confirm that statement options seem to work. Here's the trace I ran and it looks like we issue this setting prior to running the query.

Thanks @gjdanis for your patience. We have confirmed it's a bug with our implementation for PDO::exec().

hi @gjdanis if you have time please test again with our new release 5.7.1-preview.

Closing this issue as this should have been fixed in the latest release 5.8.0. Please feel free to reopen if you have any questions concerning this.

@yitam thank you for your work on this - I can confirm the issue is fixed.

@yitam just FYI - opened up a similar issue here: https://github.com/microsoft/msphpsql/issues/1100