decide which file to use at compile time - allows for web support

The dependencies were resolved at runtime, not at build time.
This leads to ActionSheetIOS getting loaded on all platforms, avoiding this allows for the use of react-native-web.

Can we revive this and hopefully get this in?

I tried testing on web. It looks like ActionSheetCustom uses modal and react native web doesn't support modal. Need a different solution for now to support web.

@smithydll You can use this to enable modals:
https://github.com/necolas/react-native-web/issues/1020#issuecomment-416227930

Calling @xiaoyann  :)


[Question]: How to invalidate MiniDriver cache?

Is there an existing issue for this?

[X] I have searched the existing issues

What is your question?
How can I make sure that I get the new certificate from a Yubikey via MiniDriver when I call ImportCertificate?
How can we invalidate the MiniDriver cache?
We're doing something like this to read the certificate:
var privateKey = IntPtr.Zero; CryptAcquireContext(ref smartCardContext, containerName, providerName, PInvoke.PROV_RSA_FULL, PInvoke.CRYPT_VERIFYCONTEXT) CryptGetUserKey(smartCardContext, PInvoke.AT_KEYEXCHANGE, ref privateKey); CryptGetKeyParam(privateKey, PInvoke.KP_CERTIFICATE, null, ref certificateBufferSize, 0) CryptReleaseContext(smartCardContext, 0)
We receive the 'old' certificate not the new imported one.
We also have this kind of issue when we switch between multiple Yubikeys.
Context
No response

Hi @bplatypus ! The YubiKey SmartCard Minidriver is a separate YubiKey product.
Here are the docs for the minidriver.
https://docs.yubico.com/software/yubikey/tools/minidriver/index.html
If you can't find your solution there then I suggest you start a ticket here and pick the best option, I will get routed to the support channel.

Just for anyone else stumbling over this problem:
Make sure to change the card holder unique id, after updating the certificate:
var chuid = new CardholderUniqueId();
chuid.SetRandomGuid();
pivSession.WriteObject(chuid);
And use CNG (ncrypt.h) instead of wincrypt.h (deprecated) to read the certificates.
Side note: Using wincrypt.h with yubikey also doesn't detect switching between plugged yubikeys.


feat: add Go to message action in search popup

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description
When searching a message, one might want to see it in context to other messages in chat. That's why this PR adds a Go to message action to the search context menu.
Questions/Further Work

Should the popup close after clicking the action?
Should this be added to the usercard/reply-threads/other places in this PR as well?
To help users find the message, the message should be highlighted like e.g. on Discord (probably in a future PR).

Quick immediate thought(s) based on title alone:

How will this handle multiple splits of the same channel? (global search)

Would the fixing of #3861 allow for the approach where the currently focused tab is prioritized, but not cause issues when the duplicate tab is freshly opened.
e.g: Using /mentions context (maybe noticing it after 5min), opening a new tab with a duplicate split of said channel. attempting to use that new split to search for the message and ending up with a blank search.

It would be great to add this functionality to user cards and reply threads, too.
One small problem that I noticed: if you open a split with not enough messages to scroll, selecting "Go to message" will force scroll the channel view to scroll. Mousing over/doing something to update the channel view will then make it realize that it shouldn't be scrolled, making it jump back.

How will this handle multiple splits of the same channel? (global search)

All channels that contain this message will scroll to the message. ChannelView::scrollToMessage should probably include a check that early-outs if the message cannot possibly be in the channel to avoid searching the entire history.

Would the fixing of #3861 allow for the approach where the currently focused tab is prioritized, but not cause issues when the duplicate tab is freshly opened?

There could be a check to only go to a message if the tab is focused if I understand the question correctly.

if you open a split with not enough messages to scroll, selecting "Go to message" will force scroll the channel view to scroll.

Fixed in 4a9ecb4a85a84fdf83f80d07ad84b2ed994de449.

It would be great to add this functionality to user cards and reply threads, too.

I agree; added reply-threads to my original comment. Though I don't know if that should happen in this PR.


init;wip

I just stumbled over this PR, and we really shouldn't merge this. While in general it is a good idea to avoid such strings, in this specific case it's a huge mistake. This is because error codes are part of our public API. This means that changing an error code is always a breaking change, because users of the runtime and the connector may check for these error codes.
This PR makes accidental changes to error codes way too likely, because the developer may not notice that by changing the method name he also changes the error code.

I understand so we should reject this issue? https://js-soft.atlassian.net/browse/NMSHDR-15

I understand so we should reject this issue? https://js-soft.atlassian.net/browse/NMSHDR-15

IMO yes. @slavistan Did you think of what I described above when you created the task?

I disagree with your points* but I don't have a strong enough opinion on this topic to warrant any discussion. The idea here was more to provide an instructive task for somebody to get their hands dirty with our codebase and the typescript fundamentals while at the same time doing something arguably useful.
* If you're interested in the details: Apropos

breaking changes: We're introducing a lot of breaking changes at the moment across a lot of our libraries, so now is the time.
changes to a public api: We're the only ones using the consumption library. If anything, the runtime lib api may be considered public in a sense, but that wouldn't necessarily be affected by the changes here, as the runtime exports its own errors.
mistakes: Mistakes are possible everywhere, this isn't specific in any way to the changes suggested here. Plus, changes introduced to the error codes would be caught by our tests.

But again, no strong opinion. Yeet it, if you don't like it, all good 👍

We're introducing a lot of breaking changes at the moment across a lot of our libraries, so now is the time

I'm not saying it's a breaking change right now. Instead, the changes increase the likelihood that breaking changes will be introduced inadvertently in the future.

We're the only ones using the consumption library.

First of all: the runtime is an open source project. So in theory, there can be others using it as well. But more important: the Connector passes the error code it receives from the transport or consumption library on to the caller. This means that everybody integrating the Connector into their environment is affected by changes to the error codes.

changes introduced to the error codes would be caught by our tests.

If you can prove that all error codes are covered by tests, I'm fine with the changes ;) But the truth is that we're far from 100% test coverage - at least back then when I was developing for the runtime.

I second @tnotheis opinion and therefore close this.


Adding solo commands for PL and WebPack

This adds bolt pattern-lab (alias: bolt pl) and bolt webpack (alias: bolt wp) to the build tools.
Just a little tip for you personally Salem, run this to get a global bolt:
cd apps/pattern-lab--workshop/node_modules/.bin/
ln -s `pwd`/bolt /usr/local/bin

Now you can run bolt commands anywhere... and yes, if you ran that in apps/example_drupal_theme it'd still work and only run there.

@EvanLovely you read my mind 😉

Thoughts on a standalone serve command to compliment these? IE. I just built my code for production and want to do some local smoke tests before doing a release.

Thoughts on a standalone serve command to compliment these?

Already there; here's all available commands (you can see these with bolt --help BTW):
bolt serve
bolt wp
bolt pl
bolt build
bolt watch
bolt start
bolt clean
bolt img


Document how to create a WC on thor and thunder

Task
Document how to create a WC on thor and thunder.
Public documentation  exist for CAPA clusters but since thor and thunder have specific configurations, it would help a lot to have documentation for those 2.

maybe we should  follow the structure with examples like here
https://github.com/giantswarm/cluster-cloud-director/tree/main/examples/cluster-default

I tried the latest instructions and the first control plane node got stuck in cloud-init with 429 Too Many Requests error for pulling critical kubelet images from Docker registry. This is fatal at that point. We should document how to set registry credentials (or automatically use the MC's credentials?).

I can add example secret config to the current manifests.


Implement Tic-Tac-Toe in Java.

This code is the implementation of the famous game Tic-Tac-Toe in Java.

follow rules


Image file suffix case issue

Function data_partition in file utils/partition_utils.py hardcodes image file suffix as .jpg, which will cause problem when the image file suffix in the COLMAP images.bin file is uppercase .JPG.

This is a relatively minor issue, which I will try to fix later


Feature 1291 develop gaussian to goes

Howard, please review these tweaks for point2grid.
Include the threshold in the output NetCDF probability variable names.
Redirect unit_point2grid.xml output into a new point2grid output directory.
The newly updated output from unit_point2grid.xml can be seen in kiowa:/d1/projects/MET/MET_pull_requests/met-9.1_beta1/feature_1291/MET-feature_1291_develop_gaussian_to_GOES/test/test_output/point2grid.
Added a note to the Google doc to update the Sphinx documentation:
https://docs.google.com/document/d/1nCPBzu0eYognWWDHyocF3riuzydkF01N87cDWG3Bu0g/edit

Resolved a conflict and merged into develop branch


Connecting the Multiminer to a pool or coin wallet

Hi,
This is probably answered somewhere but how can I participate in a pool with Multiminer?  Also, if I mine something, where does it go?  How would I know and transfer it to my wallet?
Sorry, I do not see any details in the documentation on how to do this.
Thanks?

Exactly someonehelp us please!

We need help


Fix comment formatting

cc @iposva-google

Fixed with https://github.com/dart-lang/sdk/commit/d71110f31fbfe1c17fbd516a111968e06dfffd7d


Implement banning of users

There are going to be 2 types of bans, soft and hard bans.
Banned users behaviour

~A banned user cannot post a comment or story~
~Banned users cannot invite other users~
Stories by banned users remain on the board (overridden by flag status)
Comments by banned users remain on board (overridden by flag status)
User profile will show if a user is banned
Banned users cannot upvote

Soft bans

~A user can still login~
~The ban has an expiry date~ determined by mod/admin at time of banning
Email is sent to user stating ban and reason
User profile shows ban, ban reason and expiry date

Hard bans

~Never expires~ determined by a mod/admin at time of banning
~User cannot login~
Email sent to user stating ban and reason
Stories and comments by user has username replaced for "[banned]" (or something similar)

Ban order

~Admins cannot be banned~
~Only admins can ban moderators~
~Admins and moderators can ban users~

Added/Created the views and service methods required for banning.

Commit 983bd2a8507e04c7445c87d434d65f5276ef29d4

Added validations for banned users when Create/Update/Delete of comments
Added validations for banned users when Create of stories
Added validations for banning a user (Moderator cannot ban admin or moderators)

An admin/mod who bans a user will determine whether it is a hard ban or soft ban by setting or not setting an expiry date.
All code requiring different behaviour between a hard ban and soft ban will be determined by the ExpiryDate property (null == hard ban)

After further review, a user who is soft banned cannot login. This is the same behaviour for all bans now.

Commit 3811e890e3d3a38be3f34343be33295ae34e8745

User profile shows if user is banned.


segfault when trying to build simple-raytracer

Sysroot built in release mode and simple-raytracer built in release mode.
It does build with sysroot built in release mode and simple-raytracer built in debug mode.

It doesn't segfault anymore.


[WIP] WinJS 4.0

Update declaration file (.d.ts file) of WinJS for version 4.0.

[ ] Added the AutoSuggestBox control
[ ] Added the ContentDialog control
[ ] Added Pivot custom header areas
[x] Added the SplitView control
[ ] Added the ToolBar control
[ ] Added the XYFocus utility
[ ] Added the ability to zebra stripe ListView items
[ ] Added granular ListView virtualization options
[x] Added the SplitViewPaneToggle control
[ ] Added a new ListView selection model
[ ] The WinJS.Utilities.isPhone property will return undefined
[ ] Changes on AppBar

[ ] Removed the disabled property
[ ] Removed the hideCommands method
[ ] Removed the layout property
[ ] Removed the showCommands method
[ ] Removed the sticky property
[ ] Removed the .win-commandlayout CSS class
[ ] Renamed the commands property to data
[ ] Renamed the hidden property to opened
[ ] Renamed the hide method to close
[ ] Renamed the onafterhide event to onafterclose
[ ] Renamed the onaftershow event to onafteropen
[ ] Renamed the onbeforehide event to onbeforeclose
[ ] Renamed the onbeforeshow event to onbeforeopen
[ ] Renamed the show method to open
[ ] Renamed the .win-appbar-hidden CSS class to .win-appbar-closed

[ ] Changes on NavBar

[ ] Removed the disabled property
[ ] Removed the layout property
[ ] Removed the sticky property
[ ] Renamed the onafterhide event to onafterclose
[ ] Renamed the onaftershow event to onafteropen
[ ] Renamed the onbeforehide event to onbeforeclose
[ ] Renamed the onbeforeshow event to onbeforeopen
[ ] Renamed the hide method to close
[ ] Renamed the show method to open
[ ] Renamed the hidden property to opened

and so on...

See: https://github.com/winjs/winjs/wiki/Changelog

I found there is official declaration file!!!

https://github.com/winjs/winjs/blob/master/typings/winjs/winjs.d.ts


UI Customization missing

Is there a way to customize textfield's UI?
At the moment, I don't think there's a simple way to do this

This is one of the desired features I want to add, however I'm not sure what properties will be customizable. Any suggestions?

I think you should leave to the user the possibility to set decoration property totally free
Maybe if you want, you can leave two type of style:

Your custom style with animation
Custom style provided by user

In the second case, you can try to develop other way to see the results. For example in a modal or in a separate page

Customizing the current textfield I provide would be very limited, since slight changes would add bugs to the box being animated.
I'm thinking about adding an API that allows the user to create his own textfield, but easily access the results from the Autocompletion API.
However this would be so low level that I'm not sure if it would be worth implementing since it would be pretty much a dart wrapper for the google maps APIs used in the package.

@Bernardi23 – it would certainly be good to be able to supply own text styles for the search input, both hint and input.

@Bernardi23
I like to could customize UI too, I want to customize the search text style, height of the search box, height of the result box,
costume decoration of search and result box (radius, shadow, color, border, borderRadius and ...)
(not just dark and light theme)
thanks.


Be able to embed images in a post, not have them appear at the top only

Requested by Jordan Hosmer-Henner on Intercom

We can do this ... means adding a button somewhere. Since the top row of buttons is crowded, I'll do the following:
User hits returns to create a new, blank line. A "+" icon appears just to the left of the line. If the user clicks it, it disappears and buttons pop up in the line to add an image, a file, or a video. However, if the user starts typing on this line, the "+" icon goes away.

I would like the ability to embed YouTube videos are part of this issue. Do we have a video icon or can you make one?


Add getEditorBranches to ApiClient

Add ability to get a list of all branches.
getEditorBranches and getCurEditorBranch allow to get information about current editor branch. For example, a user can check the current branch of Editor and the current git branch by name to prevent unexpected overwriting content in Editor just because a user forget to switch branches in Playcanvas Editor and Git.
Here is a link to REST API

Side note: I'm prioritising this ticket for the team to help more of the syncing between local version control and playcanvas version control


integrations: Add webhook code, API endpoint, and tests for FourSquare.

integrations: Add webhook code, API endpoint, and tests for FourSquare by 540KJ

Automated message from Dropbox CLA bot
@540KJ, it looks like you've already signed the Dropbox CLA. Thanks!

I would like to avoid this pattern of hard coding three different venues.  What happens if we only get two returned?
I would prefer to make a function that can format the results for any single venue, and then do something like '\n.join(format(venue) for venue in venues[:3]`
+BODY_TEMPLATE = '''
+Food nearby {displayString} coming right up:
+{name_0}
+{formattedAddress_0}
+{descrip_0}
+
+{name_1}
+{formattedAddress_1}
+{descrip_1}
+
+{name_2}
+{formattedAddress_2}
+{descrip_2}'''

@540KJ just to understand, are you abandoning this integration?  It seems like you've done a lot of implementation work on this...

I've substituted this with the FourSquare bot. Makes more sense to have bot, rather than a webhook.


Add "Not In" Comparison operator

Currently, we have the "In" comparison operator:

Could we get the "Not In" operator as well?
Use case:
Do a database filter where items IDs are not in a list of items.
Example: """Id !^^ [23, 21, 20]"""

Yeah, this slipped through the cracks. Good call. New release just pushed that includes it.


Spotify connect needs an updated librespot - Thanks

Thanks @kingosticks
I just tried, and unless something has changed since, it doesn't work for me. I'll open a ticket with librespot if it makes sense. I now get the following:
INFO:librespot: librespot aeb205d (2018-03-22). Built on 2018-05-21. Build ID: gB1rceMk
INFO:librespot_core::session: Connecting to AP "guc3-accesspoint-b-m84k.ap.spotify.com:4070"
INFO:librespot_core::session: Authenticated as "___________" !
INFO:librespot_core::session: Country: "CA"
INFO:librespot_playback::audio_backend::alsa: Using alsa sink
thread 'main' panicked at 'called Result::unwrap() on an Err value: WireError(InvalidEnumValue(14))', /checkout/src/libcore/result.rs:916:5
stack backtrace:
0:   0x939d17 - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::h280c621ec0336843
at /checkout/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
1:   0x943f73 - std::sys_common::backtrace::print::h5bb167d48668dac9
at /checkout/src/libstd/sys_common/backtrace.rs:68
at /checkout/src/libstd/sys_common/backtrace.rs:57
2:   0x93259f - std::panicking::default_hook::{{closure}}::hccf3b2e1cc48596f
at /checkout/src/libstd/panicking.rs:381
3:   0x93207b - std::panicking::default_hook::h338b1189515ccc69
at /checkout/src/libstd/panicking.rs:397
4:   0x51f763 - librespot::main::{{closure}}::h36f160aa49878201
5:   0x932a3f - std::panicking::rust_panic_with_hook::h5d950fb4a856fba5
at /checkout/src/libstd/panicking.rs:578
6:   0x9328ef - std::panicking::begin_panic::h7a5157aecf168062
at /checkout/src/libstd/panicking.rs:538
7:   0x93281b - std::panicking::begin_panic_fmt::hc44606ee40e9a98e
at /checkout/src/libstd/panicking.rs:522
8:   0x9327c3 - rust_begin_unwind
at /checkout/src/libstd/panicking.rs:498
9:   0x99b87b - core::panicking::panic_fmt::h68e7715928be641f
at /checkout/src/libcore/panicking.rs:71
10:   0x5b2017 - core::result::unwrap_failed::hc8e405a7d6f5e105
11:   0x58a9a3 - core::ops::function::impls::<impl core::ops::function::FnOnce for &'a mut F>::call_once::h550fb1c59c949344
12:   0x5a985b - <futures::stream::map::Map<S, F> as futures::stream::Stream>::poll::h6f4042a85363f6fe
13:   0x5944ff - <librespot_connect::spirc::SpircTask as futures::future::Future>::poll::h2ae68a0a355e9093
14:   0x51d107 - <librespot::Main as futures::future::Future>::poll::ha34952329266c131
15:   0x51568f - futures::task_impl::std::set::haa73a9ee0a468b94
16:   0x52e1a3 - tokio_core::reactor::Core::run::h8b40cb76d6ebd0af
17:   0x51ec83 - librespot::main::hf84f741837bd497f
18:   0x52ec2b - std::rt::lang_start::{{closure}}::h369662dc239e3883
19:   0x9326f3 - std::panicking::try::do_call::h9cb586bd57bb9d3d
at /checkout/src/libstd/rt.rs:59
at /checkout/src/libstd/panicking.rs:480
20:   0x95930b - __rust_maybe_catch_panic
at /checkout/src/libpanic_unwind/lib.rs:101
21:   0x9399a3 - std::rt::lang_start_internal::h104139376fdb9ead
at /checkout/src/libstd/panicking.rs:459
at /checkout/src/libstd/panic.rs:365
at /checkout/src/libstd/rt.rs:58
22:   0x51f79b - main
23: 0xb6dbe81b - __libc_start_main

Hmm, that's weird. I don't think there's any need to open an issue with librespot just yet, they did fix exactly this. I need to check the build I uploaded../

Confirming that the original fix didn’t work on my end either. Thanks!

New one is up:
service librespot stop
cd /opt/librespot
wget https://github.com/pimusicbox/librespot/releases/download/v20180529-1e69138/librespot-linux-armhf-raspberry_pi.zip
unzip librespot-linux-armhf-raspberry_pi.zip
rm librespot-linux-armhf-raspberry_pi.zip
service librespot start

I realise how I did this: forgot you have to also rebuild the docker container so that it picks up the new source code. Not fool-proof enough for me.

Solved here as well, thanks.

Works for me, thanks.

 Have I got to do anything else?

This fixes the librespot issue which is the software for providing Spotify connect. The general Spotify support (accessed through the Webclients/mpd clients) is provided by mopidy-spotify which is still broken.

Yup, this fixed it on mine as well... which is AWESOME! This is probably by far the single most used part of MusicBox for me! Thanks!

@kingosticks somehow I get the message:
'librespot: unrecognized service'
both when I try 'service librespot stop' and 'service librespot start'. Did I install something incorrectly?

Sounds like it but I don't know how you managed that. The service file lives in /etc/init.d/librespot but the upgrade commands I gave above do not touch that file.

Hmm..  /etc/init.d/librespot does not exist

librespot only provides Spotify Connect support. Everything else comes from mopidy-spotify so (perhaps surprisingly) they are entirely unrelated issues. If you want to start a more appropriate separate issue for spotify playlists on here you are welcome to.
The fix for latest mopidy-spotify is almost done. It may even get released into pimusicbox first due to the fact I won't bother fixing the tests when backporting it to pimusicbox's old version of mopidy-spotify...  But I don't have an ETA.

@JorritBootsma Are you using the latest RC at https://github.com/pimusicbox/pimusicbox/releases/tag/v0.7.0RC6 ? It doesn't sound like you are...

I got that impression too so I formatted my SD-card and and made sure that I installed the right image so I should be now. However I am having some issues ssh-ing into my MusicBox now (I recognize having them before). Please hold.

This clearly illustrates the problem:
root@MusicBox:~# service librespot
Usage: /etc/init.d/librespot {start|stop|status|restart|force-reload|run}
root@MusicBox:~# service librespot status
[FAIL] librespot is not running ... failed!
root@MusicBox:~# service librespot start
[ ok ] Starting Spotify Connect : librespot.
root@MusicBox:~# service librespot status
[FAIL] librespot is not running ... failed!
root@MusicBox:~# service librespot restart
[ ok ] Restarting Spotify Connect: librespot.
root@MusicBox:~# service librespot status
[FAIL] librespot is not running ... failed!
root@MusicBox:~# service librespot force-reload
[ ok ] Restarting Spotify Connect: librespot.
root@MusicBox:~# service librespot status
[FAIL] librespot is not running ... failed!

Did you enter your Spotify credentials in the Spotify section of settings.ini?
If you did enter your credentials properly, what does the log say in /var/log/librespot.log

Yes I have, including Client ID and Client Secret.
This is the librespot.log file:
error: Required option 'name' missing
Usage: /opt/librespot/librespot [options]
Options:
-c, --cache CACHE   Path to a directory where files will be cached.
--disable-audio-cache
Disable caching of the audio data.
-n, --name NAME     Device name
--device-type DEVICE_TYPE
Displayed device type
-b, --bitrate BITRATE
Bitrate (96, 160 or 320). Defaults to 160
--onevent PROGRAM
Run PROGRAM when playback is about to begin.
-v, --verbose       Enable verbose output
-u, --username USERNAME
Username to sign in with
-p, --password PASSWORD
Password
--proxy PROXY   HTTP proxy to use when connecting
--disable-discovery
Disable discovery mode
--backend BACKEND
Audio backend to use. Use '?' to list options
--device DEVICE Audio device to use. Use '?' to list options if using
portaudio
--mixer MIXER   Mixer to use
--initial-volume VOLUME
Initial volume in %, once connected (must be from 0 to
100)
--zeroconf-port ZEROCONF_PORT
The port the internal server advertised over zeroconf
uses.
--enable-volume-normalisation
Play all tracks at the same volume
--normalisation-pregain PREGAIN
Pregain (dB) applied by volume normalisation
--linear-volume
increase volume linear instead of logarithmic.

Initializing MusicBox...

Setting sound configuration...
Probing sound devices:

Found internal device: card0
Found internal device: card0
Selected card=0  (i2s=  output=analog  usb=  intc=0)
Using audio card0 (analog)
MusicBox name is MusicBox
ifup: interface wlan0 already configured
Running /etc/init.d/networking restart is deprecated because it may not re-enable some interfaces ... (warning).
Reconfiguring network interfaces...Internet Systems Consortium DHCP Client 4.2.2
Copyright 2004-2011 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/

Listening on LPF/wlan0/b8:27:eb:ca:e7:b6
Sending on   LPF/wlan0/b8:27:eb:ca:e7:b6
Sending on   Socket/fallback
DHCPRELEASE on wlan0 to <IP_ADDRESS> port 67
Reloading /etc/samba/smb.conf: smbd only.
RTNETLINK answers: No such process
Internet Systems Consortium DHCP Client 4.2.2
Copyright 2004-2011 Internet Systems Consortium.
All rights reserved.
For info, please visit https://www.isc.org/software/dhcp/
Listening on LPF/eth0/b8:27:eb:9f:b2:e3
Sending on   LPF/eth0/b8:27:eb:9f:b2:e3
Sending on   Socket/fallback
done.
Stopping Samba daemons: nmbd smbd.
Starting Samba daemons: nmbd smbd.
Starting Dropbear SSH server: dropbear.
Starting daemon monitor: monit.
Scanning music-files, please wait...
INFO     Starting Mopidy 1.1.2
INFO     Loading config from builtin defaults
INFO     Loading config from /etc/mopidy/mopidy.conf
INFO     Loading config from command line options

My IP address is <IP_ADDRESS>
Connect to me in your browser at http://MusicBox.local or http://<IP_ADDRESS>

And, you surely did this but I need to check you actually enabled the Spotify Connect service in settings.ini ? YOu do that by setting enable_connect = true....

No.. I feel embarrassed.
Did learn how to check log files, though... Sorry for wasting your time.

I am a little late to this tread, but I just installed pi MusicBox to my RPI zero w.
In my spotify app I can see the MusicBox between the devices to connect. When I try to connect it says "connecting.." and then after a while it stops and the MusicBox does't show up in the list anymore.
I tried the command lines above but when I type in the   wget "link"   error 404 NOT FOUND is stated.
Can I stream sporify music from my phone to MusicBox without singing in in the config file? Or do you have to sign in into the config file?
Sorry for my bad English it's not my first language.
best regards.

@kingosticks Could I just build librespot myself (following their instructions) and use it as drop-in replacement for the version PiMusicBox provides? I'm asking because there's been another issue which doesn't seem to be fixed yet in the version you uploaded.

Yes you can do that. However, I'm pretty sure I picked up that fix in the build I already made available on May 29th.

I assume you're talking about this build? Maybe I made a mistake somewhere but I downloaded precisely this build and followed your instructions and the librespot log ended up saying "build on 2018-03-11". I'll double-check when I'm home again on Sunday.

@kingosticks I checked again and you're right, I must have made some mistake along the way. It's working beautifully, now! Thanks again!

The new build fixes Spotify Connect for me (able to see MusicBox in Spotify and able to start playing music). However, it doesn't automatically stop whatever is playing on Modipy, so if you already have something playing on Modipy and start a song with Spotify Connect it plays the two simultaneously. Do I have to manually stop Modipy before I can use Spotify Connect or can this be done automatically?
Would there be a way to better integrate Modipy and Spotify Connect? (ideally I would like to be able to also see and control the song I am playing through Spotify Connect in Modipy)

Mopidy.
Librespot is configured to send a stop command to Mopidy when playback starts. I wonder why this is not working. If you enable the Mopidy debug log (in settings) can you check if Mopidy is receiving a stop command via its MPD interface?
Unfortunately integrating the two systems is not at all simple in their current states. I do agree it would be good to have.

@kingosticks : I've reinstalled piMusicBox twice recently, went on this thread twice and downloaded the wrong archive twice, while copy-pasting your first answer. :sweat_smile:
Maybe you can edit your first answer and add something like "EDIT: wrong link, see next answers".

Just downloaded the latest release and unfortunately it is still not letting me switch to a new song and instead restarts the current song. What can I do?


chore: Spelling

closes #1071
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/autocomplete/actions/runs/3815423602#summary-10380894959
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/autocomplete/actions/runs/3815423664#summary-10380895022
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
I'm skipping the commit style. I'm happy to fix the commit style to match convention once people determine which change(s) they'd like to keep and whether they want a single commit or multiple commits.

I checked and none of these changes would be breaking for customers. Thanks for this PR!


Random idea: take inspiration from http4s Headers?

Just a random idea I've been brewing, feel free to tell me I'm being dumb
It seems to me a lot of the trickiness with scalacOptions is that in userland we want to operate (add/remove) with a higher-level DSL (which is what this library provides) but the underlying representation is a raw Seq[String].
I assume this has motivated the approach in sbt-tpolecat where tpolecatScalacOptions is defined in terms of the DSL and it is intended that all operations are done on that setting, and the plugin then writes it into scalacOptions. Unfortunately this has shortcomings as well e.g. https://github.com/typelevel/sbt-tpolecat/issues/60 or https://github.com/typelevel/sbt-tpolecat/issues/102.
While reviewing an http4s PR I realized that the Headers model is super similar to maybe what we want here. Notably, Headers is represented as a raw sequence of CIString -> String  tuples but users are able to interact with it elegantly using the various model classes. I wonder if we could adopt a similar design pattern here.
I haven't fully worked out how it would actually work in sbt, but the rough idea would be that all interactions should be done by applying DSL-based operations directly to the scalacOptions setting. I think this would get us the wins while avoiding the traps.
Thoughts?

This sounds really interesting - sounds like I need to read up about http4s Headers. typelevel/sbt-tpolecat#102 is driving me absolutely nuts so any improvement on the status quo would be extremely helpful. 😆

@DavidGregory084 heh, sorry if I wasn't so clear.
Besides the fact that in sbt scalacOptions is represented as a Seq[String], let's forget about sbt for a minute.
My observation is essentially that in http4s Headers is just a fancy wrapper for a List[(String, String)]. So even though there is a fancy DSL for working with modeled headers, they are fundamentally represented in their raw form and not as e.g. List[Header]. The raw form is the single, canonical representation.
Circling back to sbt and sbt-tpolecat, IIUC the way you are doing things now is:

Introducing a setting Seq[ScalacOption], and claiming this is the canonical way of interacting with your options.
Users happily manipulate the Seq[ScalacOption] with the DSL, in every scope.
sbt-tpolecat attempts to load the contents of Seq[ScalacOption] into the raw Seq[String] correctly per-scope, which is when bad things are happening.

Instead I am proposing this:

Users happily manipulate the raw Seq[String] with the DSL, in every scope.

Let me know if that makes more sense 😅


fix: Remove device serial restriction

#48

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (854c738) compared to base (41056b9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           15        15
  Lines          419       418    -1
  Branches        89        88    -1
=========================================
- Hits           419       418    -1

Impacted Files
Coverage Δ

src/platform.ts
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Disabling sidebar or toc for a page doesn't work

Updated Nextra to 2.2.14.
Now the sidebar is showing and the toc is showing anywhere, regardless if I set them to false or not (they behaved as I wanted them to before).
Bug reproduction: https://ankr-docs-9eodsjax5-ankr-docs-team.vercel.app/advanced-api/specification/ (should have no sidebar or toc).
Proof that the params are set correctly: https://github.com/Ankr-network/ankr-docs/blob/DOCS-529-update-nextra-to-latest-version/pages/advanced-api/_meta.json

Tried it with Nextra 2.2.5 — same result.
Disabling only works for 1st level _meta.json in the "pages" folder. Any level deeper, in a subfolder, it stops working and the toc and sidebar are always there.

I singled out the problem cause: the layout gets Fd up with the "trailingSlash: true" param in the nextConfig.
Unfortunately, I need this param on.
How can I fix the issue? Is there any way to do it right now? Or do you, guys, fix it in the next Nextra update?

This is the layout without trailingSlash: true

And this is the layout with trailingSlash: true

This is the layout without trailingSlash: true

And this is the layout with trailingSlash: true

@B2o5T

Also, breadcrumbs disappear because of trailingSlash: true

Please fix these in the next version of Nextra

@shuding

also, the prevPage and nextPage bottom navigation is broken because of trailingSlash: true

Or tell me how I can fix it on my side please

I see the trailingSlash issue has been addressed here: https://github.com/shuding/nextra/pull/1443 2 weeks ago.
The last 2.2.14 release was 3 weeks ago.
I hope https://github.com/shuding/nextra/pull/1443 fixes all three issues I found in 2.2.14 with trailingSlash: true:

page theming not working in _meta.json
breadcrumbs disappear
prevPage-nexPage navigation is stuck showing always only the main page in the nextPage.

really looking forward to a new release that includes https://github.com/shuding/nextra/pull/1443

Please stop spam ⚠
related issue https://github.com/shuding/nextra/issues/1425 seems it was already fixed and will be included in the next release

@B2o5T I spend a whole bloody day trying to find the cause of the issue. Found 3 bugs on the way. Found the cause of the issue. Reported it here. And only after found the pr that fixed it.
a day of my time, a lot of effort, 3 bugs reported. Don't you date call it spam!

@raproid Sorry for this, but this was true spam with many messages, you just made a noise


Fix heredoc/nowdoc formatter regex for multiple code snippet in single php file

using msU fix the multiple snippet, but seems cause a bug on trimming code:
There was 1 failure:

1) Symplify\EasyCodingStandard\Tests\HeredocNowdoc\HeredocNowdocPHPCodeFormatterTest::test with data set #5 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
packages/easy-coding-standard/tests/HeredocNowdoc/Fixture/trim.php.inc
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
     public function getDefinition(): string
     {
         return <<<'PHP'
+
 <?php
 class Definition
 {
     public function getResult(): array
     {
-        return ['test' => 'data'];
+        return array('test' => 'data');
     }
 }
+
 PHP;
     }
 }
 '

/Users/samsonasik/www/symplify/packages/easy-coding-standard/tests/HeredocNowdoc/HeredocNowdocPHPCodeFormatterTest.php:51

All checks have passed 🎉 @TomasVotruba it fixed now.

@TomasVotruba it need to be merged first before move to #2143

Merged, thanks :+1:

I've sent you access to Symplify repository, so you can manage pull-requests more effectively without updating the fork.


Broken NavBar

Description
The links on the navbar for all pages are not clickable assuming to be because of the addition of the announcement component.

Chrome version 83.0.4103.97

Hi @neil-lobo, this problem has been reported earlier in issue #1976. Deploy with the fix is in progress.


Define the onErrorResume stage.

This stage is the first error recovery stage. It allows supplying a value when a stream encounters an error.

One question, in onErrorResumeWith, if the returned publisher emits an error, should onErrorResumeWith be invoked again to handle it? Akka streams, by default, does this indefinitely, it also has a recoverWithRetries variant to control how many times it will retry (passing 1 to that implements the behaviour as currently specified).
Which one makes sense really depends on the use case. If I'm using this to restart a stream in the event of failure, then I want the retries. If however I'm using this to switch to an alternate stream in the event of failure, then I don't want retries.
It's possible to implement both with either behaviour, if I want to keep retrying and the API offers the non retry version, then I just need to return a publisher that has the retry it (using recursion to create it). If I want to retry a limited number of times, I simply take in a retries parameter in my recursive builder and decrement it. If however retries are automatic, then to not retry I need to maintain some state, eg a count down or a boolean, and when I don't want to retry anymore, I can either return a completed publisher, or throw the exception if I wanted it propagated. I think the former is easier/cleaner, so potentially the best option is to offer the not retrying option.
The docs should make it clear which behaviour is done though.

The documentation of the stage right now is around these lines:
 Returns a stream containing all the elements from this stream. Additionally, in the case of failure, rather than invoking `#onError(Consumer)`, it invokes the given method and emits the returned `PublisherBuilder` instead.

By default, when a stream encounters an error that prevents it from emitting the expected item to its subscriber, the stream (publisher) invokes its subscriber's `onError` method, and then terminate without invoking any more of its subscriber's methods. This operator changes this behavior. If the current stream encounters an error, instead of invoking its subscriber's `onError` method, it will instead relinquish control to the `PublisherBuilder` returned from given function, which invokes the subscriber's `onNext` method if it is able to do so. In such a case, because no publisher necessarily invokes `onError`, the subscriber may never know that an error happened.

So, if the returned stream emits a failure the onErrorResumeWith won't be called again as the returned stream is used as source for the rest of the pipeline starting just after the onResumeWith stage. That's, obviously, debatable. I actually think that retries should be covered in another issue as they are pretty important but can be hard to handle especially in a streaming application using "windows of data".


Revert "Fix cilium to use k3s paths for binPath and confPath"

@prehor I need to revert this change. People are reporting issues in Discord https://discord.com/channels/673534664354430999/1221220838812946523
As I know this works with the previous paths I feel it's safe to revert and maybe debug what is the root cause
Reverts onedr0p/cluster-template#1381

Thanks for confirming!


Improvement to ssh_keys, gemspec

This patch provides support for maintaining the ssh_keys of other users. The existing implementation is not consistent in its use of user-id as a parameter; this is corrected when fetching keys. For these call implementations, pseudo-function-overloading is implemented with variable argument lists.
Also, a prior version introduced the use of yaml.safe_load, which is available only in psych +2.2, so that dependency is coded into the Gemspec.
It is so far still possible to build and deploy on Ruby 2.0 system (ie, RHEL). Let's keep it that way please.

Closing since we support only Ruby >= 2.3.0 now.


Mongodb memory

I was using this repo for a test NodeJS app to test GitHub Actions, when I realized that I need MongoDB running during tests. While possible to do, it's a dependency I did not see as a hard requirement, so I removed it.
"npm test" will now use mongodb-memory-server to spin up a in-memory mongodb instance during test (see app.js).
A sample GitHub Actions workflow is included too.
I understand this is all not required for a Hackathon starter repo, but if you do include the CD part of CI/CD via GitHub Actions, adding the ability to do consistent tests will make the CD steps easier.

Works for GitLab too. This is more a confirmation that the mongodb-memory-server works on both GitHub as well as GitLab CI/CD's runners. And it does!

Not sure how to remove the package-lock.json change. I often wipe it out to get the latest updates but that edits that file completely.

Canceling this. I'll make a nicer one.


Comment Threading author_id return whitelist error

Hi Team,
Awesome Api, but unfortunately i am facing a small issue, scenario is when end user create ticket it works perfectly but on the same ticket when he reply or comment, it shows as message is send from the author i registered the API,
by googling it, i found i need to add author_id with comment like
ticket.comment = {:value => "some message", :author_id => 1232} but it shows "Removed restricted keys ["author_id"] from parameters according to whitelist"
currently i am using trail version, is it due to trail version or i missed something?

Hm, you should definitely be allowed to post comments with a different author_id. Can you send an email to api at zendesk.com with more detailed information?

@steved thanks,
i have sent email to api at zendesk.com


Notary0.1 fixture fix - delay metadata and certificate expiry to occur far far in the future

@diogomonica Fixes https://github.com/docker/notary/pull/540#discussion_r51945423 and adds a test to ensure this doesn't happen again if we re-check in.
Hopefully will have a script to generate these fixtures at some point in the future.

LGTM!


[question] do we have a plan to revendor libnetwork to the latest version or stable one

Ⅰ. Issue Description
We have vendor libnetwork to take advantages of libnetwork's ability on network management. While I am afraid that currently we met several serious issues ever which are not so easy to handle, so we did some tricky work to handle this:

use a very strange way to vendor libnetwork in extra(https://github.com/alibaba/pouch/tree/master/extra/libnetwork);
log package logrus brings so much inconvenience.

I think we should take more things into consideration whether to use latest or stable version of libnetwork to bring more convenience.
ping @rudyfly

I found this is not easy with govendor. Have you considered migrating to dep?

Hi @idealhack，could you mind to explain the special thing in dep? Thanks

@fuweid dep is a better package manager in general and it is maintain by Go team.

In fact, I encounter some problems with pouch and govendor, for example:

setting up new dependencies in a fresh environment is somehow difficult.

some packages in are not direct dependencies of pouch currently in vendor.json.

why does so many different packages use a same revision 2b8ed96d2a422bf205adcdfa05272dc12c81613b?


Can I run multi-gpu pretraining?

Hello, I am trying to get my hands dirty with training bert from scratch etc. and I have 4 gpus at my disposal. I want to see if there is a way that I can distribute the training across all of them. Thanks.

Are you thinking about pre-training from scratch With your own custom vocabulary  ?

No, just pre-training from scratch from existing vocabulary.

Hello @PrudhviRaj12,
Have you tried distributed training?


ts-loader v9.2.8 is breaking

Seems ts-loader v9.2.8 is breaking
Will add to renovate ignore till then
Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/2652#issuecomment-1079079741

I actually removed this in https://github.com/kodadot/nft-gallery/pull/2677


Make user guides translatable

The .md files in the raw directory: https://github.com/kylecorry31/Trail-Sense/tree/master/app/src/main/res/raw
I believe you can create new directories for raw-lang with the translated files inside. I'm not sure at this moment how to get them into Weblate. Once I figure that out I can get them up there, in the meantime if anyone wants to provide translations directly, you can submit a pull request or just send me the translated .md file(s) and I'll add them.

@kylecorry31
Yes, you can create directories raw- + language code to translate them.
Getting this on Weblate is not as easy as the app store listing (fastlane metadata, https://github.com/kylecorry31/Trail-Sense/issues/538#issuecomment-836659684), but you could take a look at (I don't know much about Weblate) https://docs.weblate.org/en/latest/formats.html#text-files. The site linked there says:

The Translate Toolkit can process simple Text files. This is very useful for translating installation files and READMEs. The processing of these files is performed by the txt2po converter.

If it supports putting the translated files into the directories, this could work.

A Chinese translated user guide by Mellvie via email (this guide is likely to change before this issue is resolved, but it may be a good starting point).
photo maps.txt

The guides are a lot longer than regular text, what happens if it is only partially translated?
Maybe there should be a way to indicate that it is fully translated, or the guides can be automatically translated for the initial pass so that way they are complete.
Maybe add a button to switch to the English version of the guide in app?

It does not appear weblate supports translating markdown files in an android resource directory.
Options are:

Only allow translations via GitHub
Move all guides into a separate folder. That will contain subfolders for each guide which contain markdown files with the language (ex. guides/guide-tool-navigation/en.md). Then create a python script to convert these to raw resources. Downside is I'll need a component for each guide which doesn't sound sustainable.
Get weblate to recognize these files as app store metadata (it might require a specific format for that though) - maybe combine this with the separate guides folder above.

I will experiment with 3, and if that doesn't work I'll have to go with 1 until weblate has a better solution.

User guides can be translated here: https://hosted.weblate.org/projects/trail-sense/trail-sense-user-guide/
I need to add a build step to get them included in the actual APK, and I can add a check for completion there as well (ex. number of new lines is roughly equal).


SharpDox repository is it still actual?

The Documentation/SharpDox repository has been archived for almost 3 years. Is it still actual? Its http://sharpdox.de site is not accessed and one of link in README file is broken.

PR to fix it?

PR to fix it?

Yep: https://github.com/quozd/awesome-dotnet/pull/988

Yep: https://github.com/quozd/awesome-dotnet/pull/988


Test 4.2: use the max frame size from the server's SETTINGS frame

The test now does a settings handshake and uses the server's settings
to determine the max frame size (then sends a frame 1 byte longer).
Previously the test used the value of the default setting.

Thank you for your PR!
Looks good to me.


Chore/fix setup conflict

changes

oof, we had a conflict on main due to a description update that develop was missing. This fixes that.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.671%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
512

Relevant Lines:
584

💛  - Coveralls


Map Zoom - Maintain zoom level when opening the map and centering on my location

A very frustrating part of Exploring services is the map first centers on Central Park, then (if I have enabled my location) centers on my location, then zooms out (rather jerkily) to a very high position which mean I have to zoom in again to have any sense of my local services.
It also delays any subsequent searches when I choose filters and the map reloads

[ ]  Maintain the map zoom height when first landing on the map
The only reason to automatically zoom out further is if a search needs to encompass results outside of the existing map window

Uploading Screen Recording 2024-04-25 at 18.01.43.mov…

The initial position zooms variously but there doesn't appear to be a consistent logic, with different numbers of locations provided by the Zoom depending on the category you choose from the homepage - same issue as #11

@jbeard4 I do not think it is fixed


Add Chinese translation of the README.md

Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the commit for DCO to be passed.
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:
Chinese translation for the README document. @prithvi1307.

Thanks, @hanlins for sending a PR 🎉
Please wait for our maintainers to review this in order to get this merged as soon as possible. Thank you for your valuable contribution. 🥇

@hanlins Can you please share your email id for us to reach out and send you swags?

@hanlins Can you please share your email id for us to reach out and send you swags?

Sure @prithvi1307, thanks for involving me! I've PMed my contact on k8s slack.


Dynamic size of canvas

🚀 Feature
Input height and width from user, and set the dimensions as such to the canvas.
Is your feature request related to a problem? Please describe.
This is a feature request which can increase functionality.
Describe the solution you'd like
Adding bootstrap number field and using the same input as dimensions of canvas.

I want to work on this issue under JWOC if anyone is not working on it

I want to work on this issue under JWOC if anyone is not working on it

try next year


Problem converting from .docx to image formats

Hi. First time user of unvconv and of this docker image (that I pulled rather than building).

Conversion form docx to pdf worked like a charm.
Conversion from docx to tiff/png/jpg failed with the error below

Error: Traceback (most recent call last):
  File "/usr/bin/unoconv", line 1030, in convert
    document.storeToURL(outputurl, tuple(outputprops) )
uno.IOException: SfxBaseModel::impl_store <private:stream> failed: 0xc10

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/unoconv", line 1275, in <module>
    main()
  File "/usr/bin/unoconv", line 1191, in main
    convertor.convert(inputfn)
  File "/usr/bin/unoconv", line 1032, in convert
    raise UnoException("Unable to store document to %s (ErrCode %d)\n\nProperties: %s" % (outputurl, e.ErrCode, outputprops), None)
  File "/usr/lib/python3/dist-packages/uno.py", line 397, in _uno_struct__getattr__
    return __builtin__.getattr(self.__dict__["value"],name)
AttributeError: ErrCode

    at ChildProcess.<anonymous> (/unoconvservice/node_modules/unoconv2/index.js:58:29)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
/unoconvservice/uploads/63783fde-81a3-4f41-8ea6-f7db8af76f28.docx deleted

Is this a bug, or am I misunderstanding unoconv capabilities

Looks like it is not related to this project
If I jump into the container's bash,
root@1352d2fb4cf2:/unoconvservice# unoconv --output=/adv5.png /adv5.docx
Traceback (most recent call last):
  File "/usr/bin/unoconv", line 1030, in convert
    document.storeToURL(outputurl, tuple(outputprops) )
uno.IOException: SfxBaseModel::impl_store <file:///adv5.png> failed: 0xc10

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/unoconv", line 1275, in <module>
    main()
  File "/usr/bin/unoconv", line 1191, in main
    convertor.convert(inputfn)
  File "/usr/bin/unoconv", line 1032, in convert
    raise UnoException("Unable to store document to %s (ErrCode %d)\n\nProperties: %s" % (outputurl, e.ErrCode, outputprops), None)
  File "/usr/lib/python3/dist-packages/uno.py", line 397, in _uno_struct__getattr__
    return __builtin__.getattr(self.__dict__["value"],name)
AttributeError: ErrCode

I don't think you can convert from a document format to an image format.
This project is just a convenience wrapper/service around unoconv and it says "Not all formats that can be imported can be exported and vice versa" on the label :-)

https://github.com/dagwieers/unoconv/issues/167 seems to indicate that it should be possible: the project owner says that it used to work. And also that the problem is clearly not caused by this project's wrapping. My apologies for the noise :-)

@xverges activity is not noise :-)
If it "used to work" and you know how to build your own images you could try to create another base image with older versions of libreOffice and/or unoconv.

If it "used to work" and you know how to build your own images you could try to create another base image with older versions of libreOffice and/or unoconv.

Might try, thanks. This is getting into a serious case of yak shaving :-)

btw this works from the terminal (if you have Libre Office installed) soffice --convert-to png myfile.pdf --headless


passing client_options to S3 object store

Hi @roeap
I came here after reading this ticket on the arrow-datafusion-python repo. I have a question on the S3 ObjectStore and whether it is possible to pass ClientOptions struct to Rust through the python bindings?

Good questions! It's probably a question of what is the most pythonic approach. In my case I wish to pass a map of arbitrary headers down to ClientOptions, and for that a dict is the most natural route I believe.
Regarding retry, I think this is also necessary. Does it make sense to follow the same signature as the Rust api, as a nested dict?
retry_config = {
  "max_retries": int,
  "retry_timeout": int ms,
  "backoff": {
    "init_backoff": int ms,
    "max_backoff": int ms,
    "base": float
  }
}

I think logically this would mean if it were to follow the Rust api, for headers:
default_headers: {
   "x-amz-meta-...": string,
   ...
}


How to redirect page to login page?

ok, this is very very nice front end with webpack
but what i need is simple. how to redirect page to login page when user do not have a token?
how to set default route to login page if the token is blank?

I have the same problem

@arisandy @6miramira check out this https://github.com/vuejs/vuex-router-sync/issues/3


copy library code, extend bubble service, and use bubble builder to test it worked

having trouble adding this library module. Reading build system docs now.

there is a build.graddle.kts file on every module and in the root project. I can use gradle's version catalog to have a centralized place for all dependencies and plugins used across the whole project.

ok, it works!


Create icons

[ ] images for maps
[ ] images for providers
[ ] icon for application
[ ] splash screen for application

Closed by pr #109


upgrade version

forgive my dumb question.. but the latest version is 2.25. i am running 2.24.. how do you upgrade to the latest version?

Same as the installation.
source /opt/netbox/venv/bin/activate
pip install netbox-contract --upgrade
cd /opt/netbox/netbox/
python3 manage.py migrate


Write a Java program to convert hexadecimal to binary

Description
Write a Java program to convert hexadecimal to binary
Hexadecimal is a base-16 number system. It uses sixteen digits: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, and F. The digits are called hexits. A hexit is the smallest unit of information in a computer. A hexit can be used to represent a single value, such as 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, A, B, C, D, E, or F, or it can be used to represent a single state, such as on or off.
Binary is a base-2 number system. It uses only two digits: 0 and 1. The digits are called bits. A bit is the smallest unit of information in a computer. A bit can be either 0 or 1. A bit can be used to represent a single value, such as 0 or 1, or it can be used to represent a single state, such as on or off.
To convert a hexadecimal number to binary, we can use the following algorithm:

Convert the hexadecimal number to decimal.
Convert the decimal number to binary.

Input  : A
Output : 1010

How to contribute

Save the solution in ConvertHexadecimalToBinary.java file
Add ConvertHexadecimalToBinary.java file in convert-hexadecimal-to-binary folder

!assign


python311Packages.pyoutbreaksnearme: 2023.10.0 -> 2023.12.0

Diff: https://github.com/bachya/pyoutbreaksnearme/compare/refs/tags/2023.10.0...2023.12.0
Changelog: https://github.com/bachya/pyoutbreaksnearme/releases/tag/2023.12.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 276661 run on x86_64-linux 1

4 packages built:

python310Packages.pyoutbreaksnearme
python310Packages.pyoutbreaksnearme.dist
python311Packages.pyoutbreaksnearme
python311Packages.pyoutbreaksnearme.dist


[BUG] max_tokens seems to have no effeect on the output

running on latest main commit (local build)
setting max_tokens to something low like 20 will still output long text
name: openai
api_key: <redacted>
model: gpt-4-turbo-preview
max_tokens: 20
role: You are a developer
temperature: 1
top_p: 1
frequency_penalty: 0
presence_penalty: 0
thread: default
omit_history: false
url: https://api.openai.com
completions_path: /v1/chat/completions
models_path: /v1/models
auth_header: Authorization
auth_token_prefix: 'Bearer '

Hi @nopeless! The problem I initially tried to solve is the fact that I was running into request limits by having too many tokens in my outgoing request. This would happen for example when I would "cat" a file and pipe it to the CLI or when my history would grow too large.
I addressed the issue by calculating the tokens of the outgoing request. When they exceed the max tokens allowed by the model, I would trim the outgoing request.
This is how I implemented max_tokens.  Definitely confusing looking back. GIven the max_tokens parameter and all in the API call. The problem I was having when I was only setting the parameter on the call to OpenAI was that I would still run into token limits due to the size of my request. So I had to solve it at the outgoing side as well.
Anyway, let me see if I can combine the two (applying the limit on both sides). I will look into your PR later today. Thank you so much!!

@nopeless Before I cut a release I am going to have to rename the original max_tokens and call it context_window. I was just reading up on the documentation, and this is the term OpenAI is using. So that's the token size of the context you send to chatgpt. We can use the new max_tokens for the output. It's a little confusing :). This is a bit of a bigger change than I anticipated. I will find some time over the weekend.

context_window is clear in the wording. looking forward to the release

Just released 1.5.0. Had to add a migration method to make sure folks move from the old to the new config as expected.


Use From field in a PING packet when creating a peer table entry

PR description
This PR uses the From field of a PING packet when creating a local entry in the peer table, unless the From field is not available in which case it reverts to the existing behaviour of using the UDP source address.
Since (as far as I can tell) all PING packets include a From field (with <IP_ADDRESS> in the case where the user hasn't specified a custom value) the PR is coded to ignore a From field of <IP_ADDRESS> and use the UDP source address instead. The reality is that on a localhost system the UDP source will be <IP_ADDRESS> anyway but it provides a little extra protection from this change/fix causing issues on existing systems that might be working just fine using the UDP source address in peer's enode URL. The main aim of this fix is that if something has specified a custom value it is honoured by the PING recipient.
Fixed Issue(s)
Fixes https://github.com/hyperledger/besu/issues/6224

@fab-10 would you be happy to put a review on the PR?

@macfarla , @pinges - would one of you be able to take a look at this as well to see what you think?

The devp2p discv4 docs for PING (https://github.com/ethereum/devp2p/blob/master/discv4.md#ping-packet-0x01) seem to only say that it's a field in the packet:
packet-data = [version, from, to, expiration, enr-seq ...]
version = 4
from = [sender-ip, sender-udp-port, sender-tcp-port]
to = [recipient-ip, recipient-udp-port, 0]

and that the recipient should send a PONG packet in reply, without being specific about where to reply to:
When a ping packet is received, the recipient should reply with a [Pong](https://github.com/ethereum/devp2p/blob/master/discv4.md#pong-packet-0x02) packet. It may also consider the sender for addition into the local table. Implementations should ignore any mismatches in version.

The docs for PONG (https://github.com/ethereum/devp2p/blob/master/discv4.md#pong-packet-0x02) don't seem to say much about where a PONG packet has to reply to either:
Pong is the reply to ping.

ping-hash should be equal to hash of the corresponding ping packet. Implementations should ignore unsolicited pong packets that do not contain the hash of the most recent ping packet.

The enr-seq field is the current ENR sequence number of the sender. This field is optional.

Interestingly the ethereum discovery overview wiki (https://github.com/ethereum/devp2p/wiki/Discovery-Overview#discovery-v4) says this:
Certain specified packet fields such as the "From" field in a Ping are ignored by implementations.

It's not completely clear to me whether that means "must be ignored by" or "are often ignored by"? If it's the case that it should be ignored (and that this PR/issue isn't valid) I'm a bit confused as to the purpose of the --p2p-host option.

With your change I think we would run in to problems with nodes that do not correctly set the FROM field in the PING message.

Yes I agree, it's difficult to know if fixing this is going to break existing setups that rely on the current behaviour.
I think running a mainnet node for a period of time like you describe would be a useful way of getting some more data to base a decision on. I'm not sure if I'm able to do that personally (I need to look into what I have available re. a public-facing system) but I think it would be a useful test.
I also wonder if there's any convention within Besu for a "fallback to previous behaviour" env-var or similar (something that doesn't require a first-class config option, but gives any user a way of reverting to the old behaviour if their environment doesn't suit the new behaviour). I think a first-class config option (e.g. something like --p2p-honor-from-addr) is probably too heavy weight just to provide a way of reverting the behaviour, particularly if the consensus that the new behaviour is correct.
Finally, maybe a look at what options Geth & Nethermind offer and what they do in code with that field would be useful input to the discussion?

For Nethermind, based on NethermindEth/nethermind...PingMsgSerializer, I think they honor the From field of the message. For go-ethereum, it's a bit more tricky to say b/c the deserialization occurs in ethereum/go-ethereum...v4wire.go but using reflection forgery to match the order in the rlp list with the position of the fields of every struct but, in a nutshell, I think they also use the From from the packet

That's really useful context @diega
@pinges - do you think based on that we would be comfortable releasing the change in behaviour without an option to disable/revert to the old behaviour?

@pinges, wondered if you had any more thoughts based on the comment from @diega?

Merging for now as this would appear to be in keeping with how other clients work.

I see a huge amount of error message  after merging main banch today . Is it related to this PR ?
{"@timestamp":"2024-01-19T11:31:39,831","level":"ERROR","thread":"vert.x-eventloop-thread-3","class":"ContextBase","message":"Unhandled exception","throwable":" java.lang.IllegalArgumentException: Invalid ip address.\n\tat org.hyperledger.besu.ethereum.p2p.peers.EnodeURLImpl$Builder.ipAddress(EnodeURLImpl.java:405)\n\tat org.hyperledger.besu.ethereum.p2p.peers.EnodeURLImpl$Builder.ipAddress(EnodeURLImpl.java:380)\n\tat org.hyperledger.besu.ethereum.p2p.discovery.PeerDiscoveryAgent.handleIncomingPacket(PeerDiscoveryAgent.java:312)\n\tat org.hyperledger.besu.ethereum.p2p.discovery.VertxPeerDiscoveryAgent.lambda$handlePacket$10(VertxPeerDiscoveryAgent.java:298)\n\tat io.vertx.core.impl.future.FutureImpl$3.onSuccess(FutureImpl.java:141)\n\tat io.vertx.core.impl.future.FutureBase.lambda$emitSuccess$0(FutureBase.java:54)\n\tat io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)\n\tat io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)\n\tat io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:413)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat java.base/java.lang.Thread.run(Thread.java:1583)\n"}

yes during checkpoint on mainnet, directly at the beginning

Just started a thread on discord if it's easier to discuss on there? https://discord.com/channels/905194001349627914/905205502940696607/1197868266635407410

I've raised https://github.com/hyperledger/besu/pull/6439 which validates the From address as a valid IP before attempting to use it, and reverts to the previous behaviour of taking it from the UDP source IP if it is invalid.


Particules from explosion are offset

The particules from the explosion from a TNT in Bomberman is like offset 1 block in diagonal

Basically the center of the particules are offset from the tnt


Clear vi.mock calls when clearMocks is enabled

Clear and concise description of the problem
The clearMocks config option currently only clears spies (which the documentation does state). I was expecting it to also clear mocks via vi.mock as the option does in Jest.
Suggested solution
Clear both spies and mocks when clearMocks is enabled.
Alternative
I can manually clear the mocks as a workaround, would just be nice to have a global option.
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

You mean it resets values or just clears spies inside a mock?
test('1', async () => {
  const mocked = await import('./path')
  expect(mocked.object.deep).toBe(1)
  mocked.object.deep = 3
  expect(mocked.object.deep).toBe(3)
})
test('2, async () => {
  const mocked = await import('./path')
  expect(mocked.object.deep).toBe(1) // right now will fail here
  mocked.object.deep = 3
  expect(mocked.object.deep).toBe(3)
})

I am meaning for call counts. So:
test('1', async () => {
  const mocked = await import('./path')
  expect().toBe(1)
  mocked.object.deep = 3
  expect(mocked.object.deep).toBe(3)
})

test('2', async () => {
  const mocked = await import('./path')
  expect(mocked.object.deep).toBe(1) // right now will fail here
  mocked.object.deep = 3
  expect(mocked.object.deep).toBe(3)
})

Cannot reproduce it. Can you confirm it is still broken?

@sheremet-va Seems to be fixed now thanks: https://stackblitz.com/edit/vitest-dev-vitest-ichkoe?file=src/code.test.ts


Booking block | Widget, block and form

(Resolving 2 Issues together as they are closely related)
#3

[x] Title and Subtitle settable via props
[x] Book a free initial meeting is a separate component pulled in as a child
[x] Background settable via props (defaults to video of Adam pressing the screen)
[x] Downwards chevron bounces
[x] Downwards chevron - click scrolls screen to "benefits" section

#4

[x] Component has modal when button is clicked
[x] Can submit form content to existing endpoint
[x] Block styling before button clicked
[x] Form styling after button clicked
[x] Resolve comments

looks like it needs a rebase to clean up the conflicts

looks like it needs a rebase to clean up the conflicts

✅ Done


How to run react native custom library inside react native project without publishing to npm? Local setup steps are not working.

Description
I have followed all the steps to create a native custom library using 'create-react-native-library' but its example app is not running. To check this locally I have created a new React-native app and then followed local library setup to check package changes. But getting the following errors when implemented local library setup:
error: Error: Unable to resolve module react/jsx-runtime from /Users/archanasharma/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/react-native/Libraries/Components/ActivityIndicator/ActivityIndicator.js: react/jsx-runtime could not be found within the project or in these directories:
node_modules/react-native/node_modules
node_modules

1 | /**
| ^
2 |  * Copyright (c) Meta Platforms, Inc. and affiliates.
3 |  *
4 |  * This source code is licensed under the MIT license found in the
at ModuleResolver.resolveDependency (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:138:15)
at DependencyGraph.resolveDependency (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/node-haste/DependencyGraph.js:231:43)
at /Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/lib/transformHelpers.js:156:21
at resolveDependencies (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:42:25)
at visit (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:83:30)
at async Promise.all (index 2)
at async visit (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:92:5)
at async Promise.all (index 1)
at async visit (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:92:5)
at async Promise.all (index 0)

And to do this I have followed the following steps:

created react native library using 'create-react-native-library' command
after this complete library build I run : 'npm link'
created new react native app
npm install inside app
start run on android : its running and working
npm link my-library
added this inside dependencies of my react native app::
"my-library": "file:../myLibrary"
npm install
npm start : then "a" for android
Then I am getting this error. Also sometimes I get that can't resolve import{...} from 'my-library'

Please suggest the accurate custom library building steps using npm and how to link locally.
Steps to reproduce

created react native library using 'create-react-native-library' command
after this complete library build I run : 'npm link'
created new react native app
npm install inside app
start run on android : its running and working
npm link my-library
added this inside dependencies of my react native app::
"my-library": "file:../myLibrary"
npm install
npm start : then "a" for android
Then I am getting this error. Also sometimes I get that can't resolve import{...} from 'my-library'

React Native Version
0.74.1
Affected Platforms
Runtime - Android, Runtime - iOS, Build - MacOS
Output of npx react-native info
System:
  OS: macOS 13.0
  CPU: (10) arm64 Apple M1 Max
  Memory: 89.13 MB / 32.00 GB
  Shell:
    version: 5.8.1
    path: /bin/zsh
Binaries:
  Node:
    version: 21.7.3
    path: /opt/homebrew/bin/node
  Yarn:
    version: 3.6.4
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.5.0
    path: /opt/homebrew/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods: Not Found
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.2
      - iOS 16.2
      - macOS 13.1
      - tvOS 16.1
      - watchOS 9.1
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11668458
  Xcode:
    version: 14.2/14C18
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /usr/bin/javac
  Ruby:
    version: 2.7.6
    path: /Users/archanasharma/.rvm/rubies/ruby-2.7.6/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.1
    wanted: 0.74.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

Stacktrace or Logs
error: Error: Unable to resolve module react/jsx-runtime from /Users/archanasharma/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/react-native/Libraries/Components/ActivityIndicator/ActivityIndicator.js: react/jsx-runtime could not be found within the project or in these directories:
  node_modules/react-native/node_modules
  node_modules
> 1 | /**
    | ^
  2 |  * Copyright (c) Meta Platforms, Inc. and affiliates.
  3 |  *
  4 |  * This source code is licensed under the MIT license found in the
    at ModuleResolver.resolveDependency (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:138:15)
    at DependencyGraph.resolveDependency (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/node-haste/DependencyGraph.js:231:43)
    at /Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/lib/transformHelpers.js:156:21
    at resolveDependencies (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:42:25)
    at visit (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:83:30)
    at async Promise.all (index 2)
    at async visit (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:92:5)
    at async Promise.all (index 1)
    at async visit (/Users/myuser/Documents/Workspace/reactjs/MyApps-Apps/package-practice/rnTest/node_modules/metro/src/DeltaBundler/buildSubgraph.js:92:5)
    at async Promise.all (index 0)

Reproducer
test
Screenshots and Videos
not having right now

Hi,
Thanks for reporting this issue.
It seems like this issue is actually unrelated to React Native core. Please open this issue against this other repository:
https://github.com/callstack/react-native-builder-bob/issues
I'll be closing this but feel free to reopen if the other repo points back to us as a issue in the core of React Native.

But how can we resolve this? You are also suggesting to create a custom library using 'create-react-native-library' and it is using'react-native-builder-bob' under the hood.Is there any other way to create custom library without using this package for compiled code?


hcl grammer fix to allow for loops with open and close brace/bracket in new line

This PR fixes HCL grammar to allow for loops with braces in a new line
For loop with bracket on same line:
a = [ for v in ["a", "b"] : v ]

vs new line:
a = [
  for v in ["a", "b"] : v
]

fixes #2078

@rmadamanchi can you rebase your pr on the latest master, this should fix the broken tests.

@rmadamanchi can you rebase your pr on the latest master, this should fix the broken tests.

done - build is green now. thx


Add documentation on how to position context menu items

I'm trying to add a menu item to the editor title context menu (which I have done), but I would like my command to be in an existing group of commands. I can't see how this can be done looking at the documentation:
https://code.visualstudio.com/api/references/contribution-points#contributes.menus
There is a group option which seems to change my menu item's position but I can't see how to add an item to an existing group. Maybe provide a list of groups in the documentation too

these the editor context menu groups, @bpasero can help with the title context menu


Add envs.py to mitol-django-common

Fixes #19

Added envs.py (sourced from xPro since that's pretty recent)
Added generate_app_json management command
Added feature flag parsing to envs.py
Added BaseApp to mitol.common.apps so we can have apps assert on required settings
Moved tests into their own tests/ directory so they're not included in the distributed package (in line w/ https://docs.python-guide.org/writing/structure/#sample-repository)

In practice, there's not much to test here, but it's more or less a copy/paste of functional code from xPro.

Codecov Report

Merging #20 (348221c) into main (1406dea) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           25        11   -14
  Lines          567       600   +33
  Branches        56        66   +10
=========================================
+ Hits           567       600   +33

Flag
Coverage Δ

mitol-django-common
100.00% <100.00%> (ø)

mitol-django-digital-credentials
?

mitol-django-mail
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mitol-django-common/tests/test_models.py
100.00% <ø> (ø)

mitol-django-common/mitol/common/apps.py
100.00% <100.00%> (ø)

mitol-django-common/mitol/common/envs.py
100.00% <100.00%> (ø)

mitol-django-common/mitol/common/pytest.py
100.00% <100.00%> (ø)

mitol-django-common/tests/test_apps.py
100.00% <100.00%> (ø)

mitol-django-common/tests/test_envs.py
100.00% <100.00%> (ø)

mitol-django-common/tests/test_pytest.py
100.00% <100.00%> (ø)

mitol-django-common/tests/test_utils.py
100.00% <100.00%> (ø)

mitol-django-mail/mitol/mail/defaults.py

...gital-credentials/mitol/digitalcredentials/apps.py

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1406dea...348221c. Read the comment docs.


[GOBBLIN-1993] Add iceberg-distcp config to exclude copying 'manifest.json' files

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1993

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Not all iceberg replication schemes require copying 'metadata.json' files, perhaps because the dest-side catalog will generate its own, rather than reusing those from source.  moving these files nonetheless add the requirement to manage their lifetime on the replication side, which did not actually create them.  Provide config to skip the copy altogether... and default it to skip.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

updated existing tests
Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (24894f5) 47.71% compared to head (81e10d7) 46.03%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3869      +/-   ##
============================================
- Coverage     47.71%   46.03%   -1.69%
+ Complexity    11109     2188    -8921
============================================
  Files          2160      417    -1743
  Lines         85513    18054   -67459
  Branches       9478     2199    -7279
============================================
- Hits          40805     8311   -32494
+ Misses        41028     8859   -32169
+ Partials       3680      884    -2796

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remove embedded-hal 0.2.x impls and dependency from esp-lp-hal package

Pull Request Details 📖
Description
closes https://github.com/esp-rs/esp-hal/issues/2597
For LpI2c we need to implement the embedded_hal::i2c:I2c trait instead of embedded-hal 0.2.7 ones.
Due to the fact that esp-lp-hal is not a priority at the moment, I did some quick draft that builds, but for the most part it's copy-paste from the HP driver 😅 .
If anyone wants to work on this - you're welcome, otherwise I'll come back to it a bit later, probably next year already.
Testing
I made a couple of changes to the test examples to be able to test the implementation. By no means do not think it is 100% correct though 👺
examples/bin/lp_core_basic.rs changes:
//! This shows a very basic example of running code on the LP core.
//!
//! Code on LP core uses LP_I2C initialized on HP core. For more information
//! check `lp_core_i2c` example in the `esp-lp-hal`.
//!
//! Make sure to first compile the `esp-lp-hal/examples/i2c.rs` example
//!
//! The following wiring is assumed:
//! - SDA => GPIO6
//! - SCL => GPIO7

//% CHIPS: esp32c6

#![no_std]
#![no_main]

use esp_backtrace as _;
use esp_hal::{
    gpio::lp_io::{LowPowerOutputOpenDrain, LowPowerOutput, LowPowerInput},
    i2c::lp_i2c::LpI2c,
    lp_core::{LpCore, LpCoreWakeupSource},
    prelude::*,
    uart::{lp_uart::LpUart, Config, Uart},
};
use esp_println::println;

#[entry]
fn main() -> ! {
    let peripherals = esp_hal::init(esp_hal::Config::default());

    let mut uart1 = Uart::new_with_config(
        peripherals.UART1,
        Config::default(),
        peripherals.GPIO6,
        peripherals.GPIO7,
    )
    .unwrap();

    let lp_sda = LowPowerOutputOpenDrain::new(peripherals.GPIO2);
    let lp_scl = LowPowerOutputOpenDrain::new(peripherals.GPIO3);

    // Set up (LP) UART:
    let lp_tx = LowPowerOutput::new(peripherals.GPIO5);
    let lp_rx = LowPowerInput::new(peripherals.GPIO4);
    let lp_uart = LpUart::new(peripherals.LP_UART, lp_tx, lp_rx);

    let lp_i2c = LpI2c::new(peripherals.LP_I2C0, lp_sda, lp_scl, 100.kHz());

    let mut lp_core = LpCore::new(peripherals.LP_CORE);
    lp_core.stop();
    println!("lp core stopped");

    // load code to LP core
    let lp_core_code =
        load_lp_code!("../esp-lp-hal/target/riscv32imac-unknown-none-elf/release/examples/i2c");

    // start LP core
    lp_core_code.run(&mut lp_core, LpCoreWakeupSource::HpCpu, lp_i2c, lp_uart);
    println!("lpcore run");

    loop {
        let read = nb::block!(uart1.read_byte());

        match read {
            Ok(read) => println!("Read 0x{:02x}", read),
            Err(err) => println!("Error {:?}", err),
        }
    }
}

esp-lp-hal/examples/i2c.rs changes:
//! Uses `LP_I2C` and reads calibration data from BMP180 sensor.
//!
//! This example dumps the calibration data from a BMP180 sensor, to view them,
//! logic analyzer or oscilloscope is required.
//!
//! The following wiring is assumed:
//! - SDA => GPIO6
//! - SCL => GPIO7

//% CHIPS: esp32c6

#![no_std]
#![no_main]

use core::fmt::Write;

use embedded_hal::i2c::I2c;
use embedded_hal::delay::DelayNs;
use esp_lp_hal::{i2c::LpI2c, uart::LpUart, prelude::*, delay::Delay};
use panic_halt as _;

#[entry]
fn main(mut i2c: LpI2c, mut uart: LpUart) -> ! {
    let _peripherals = esp32c6_lp::Peripherals::take().unwrap();

    loop {
        let mut data = [0u8; 22];
        i2c.write_read(0x77, &[0xaa], &mut data).ok();
        writeln!(uart, "Sensor data: {:02x?}", data).unwrap();
    }
}

Yeah, this package is not worth investing any time into right now IMO.


Listview is opened as popup when clicking on app logo (web version)

If OpenDetailViewAsPopup ist set for the default navigation item, a click on the application logo opens the listview as a
popup. Here is a short screencast  demonstrating this behaviour. You can easily reproduce it by setting OpenDetailViewAsPopup to true for the ActionsObject_ListView in the model editor of the SystemTester project.

Installer lab build 18.2.301.34 includes commit Listview is opened as popup when clicking on app logo (web version) #272 that relate to this task. Please test if it addresses the problem. If you use nuget add our NugetServer as a nuget package source in VS

Works like a charm. Thank you!

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.

Closing issue for age. Feel free to reopen it at any time.
.Thank you for your contribution.

I think there is still/again a problem with your code: On my side the code is also executed for ListViews, therefore new ListViews also open in a Popup.
I replaced else if (_listViewShowViewStrategy.OpenDetailViewAsPopup) with
else if (_listViewShowViewStrategy.OpenDetailViewAsPopup && createdView is DetailView)
and it seems to be working fine now.
How can I repro this bug in eXpand? There are no web sample/demo projects anymore.

Unfortunately I cannot re-open the issue

thnks for the fix!

There are no web sample/demo projects anymore.

having projects with no tests makes no sense, if eXpand is in your GAC you can use eXpand NewProject Wizard to fast create a soltion, else create a xaf empty project and install the related module.
the bot will notify u once fixed thnks again

eXpand.lab release 19.1.602.4 includes commit that relate to this task:

inconsistent behavior of OpenDetailViewAsPopup #272

Please test if it addresses the problem. If you use nuget add our LAB NugetServer as a nuget package source in VS.
Thanks a lot for your contribution.

Finally working!


Stoch

Add Stochastic indicator and tests ported over from talipp.

Thanks @g-gundam
Merry Christmas 🎅

I did some fixes in https://github.com/femtotrader/IncTA.jl/commit/4b5f9974756be753f8d91b9df218d9f52214c402 because I'm planning to use more OnlineStats (and types from OnlineStatsBase)
So you can notice the use of fit! function (but that's just a cosmetic change currently)
I changed output fields to value field in all indicators and put this field as first field (that will be required by OnlineStats)
I'm aware that currenly the lib is only able to "push" new data,  not to update latest data... but I think this is something which can be tackle a bit later.

Thanks for the explanation.  Merry Christmas to you too.  I'll do StochRSI next.


Glitches in IE11 / Win7

Multiple users have reported glitches with multires-panoramas in Internet Explorer 11 on Windows 7. Unfortunately I don't have good screenshots, but they roughly look as if tiles were wrongly/randomly referenced/mapped (which they were not) - like in level 1, you see the tile x0_y1 instead of x1_y1 etc. I guess this means that pannellum is in non-fallback/WebGL-mode, and not in IE11's weird fallback software rendering mode.
It looks different than #267, and textures are power-of-two-sized, so not #45, I guess.
Even more unfortunately I can't reproduce it in a VM, so I guess it's another almost-impossible-to-fix WebGL/driver/graphics card bug...
Since this issue was critical in our case, I applied the same workaround as in #267 (forcing fallback/non-multires cubemap) with adjusted Browser / OS sniffings:
var ua = navigator.userAgent.toLowerCase(),
  isWin7 = ua.indexOf('windows nt 6.1') > -1,
  isIE11 = (ua.indexOf('trident') > -1) && (ua.indexOf('rv:11') > -1);
if (isWin7 && isIE11) // then forceCubeMap() ...

I tried and failed to reproduce this.


[BUG] Noble value dropping on main screen

Describe the bug
The value of tokens held on Noble gets dropped after a few seconds on main screen.
To Reproduce
Steps to reproduce the behavior:

Have USDC on Noble
Go into token detail screen
Go back to main screen
Wait a few seconds and see error

Expected behavior
Keeps value of noble chain on main screen
Screenshots
https://github.com/user-attachments/assets/8ed3277b-de35-46e6-95e9-3fa4eb4874db
Smartphone (please complete the following information):

Version 35

QA done.


ReadMe and code level doc for tkey ios

Hi @hqjang-pepper
I am looking at your documentation, may I ask where tkey creates the device share and how I can access it and store it to keychain?
Asking because I guess I have to store the device share somewhere that persist in the app.


Postgres -of -p command does not generate semicolons after Update/Create statements

We have need to use the sql generated by fluentmigrator for other purposes but the -preview command does not generate ';' after Create/Update/Alter statements.  It does generate correctly after INSERT statements.
Script fails if using the output .sql file.  See attachment for example.

Closed by merge


enhancement: add checkstyle file

Proposed changes
Issue Number: related #8985
Problem Summary:
add checkstyle file
Checklist(Required)

Does it affect the original behavior: (Yes)
Has unit tests been added: (No Need)
Has document been added or modified: (No Need)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

It's a base file. We can add more rule for it.

PTAL @EmmyMiao87 @morrySnow @wangshuo128

Hi @jackwener, it is not a good idea to add checkstyle file with so many rules directly. The project will always build failed.

Yes, it,s just for review.
Charles @.***> 于 2022年4月19日周二 09:05写道：

Hi @jackwener https://github.com/jackwener, it is not a good idea to
add checkstyle file with so many rules directly. The project will always
build failed.
[image: image]
https://user-images.githubusercontent.com/86483005/163899937-60582d3f-81a5-45a6-840b-0de7c63a4bf8.png
—
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-doris/pull/9089#issuecomment-1101894409,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHI4SLMJ7SZPU5BRXI4ORPLVFYBD3ANCNFSM5TWFDKWA
.
You are receiving this because you were mentioned.Message ID:
@.***>

LGTM

Hi @EmmyMiao87, it is not a good idea to add checkstyle file with so many rules directly. The project already build failed, why you approved these changes?

@cody195 Your consideration is right.
I made a draft #9113, I found there are some problem need to consider.
We should continue pushing this job in #8985.
If you'd like take part in it, you can care it in #8985


Contact email is bouncing

There is no documentation yet, but please contact<EMAIL_ADDRESS>in order to get help.

The<EMAIL_ADDRESS>email address doesn't work :cry:

@henare now is working !!

@jdgarrido thanks! :tada:


Seen all message from group chat

I'm sorry, but I don't really see the point in demonstrating this. This is not a required step to make a "keepbot". Perhaps you could elaborate on your reasoning, and maybe include some comments where you feel necessary. Other than that, I'd like to thank you for trying to improve the documentation, it's a long way from finished ;)

This PR make the bot more real to the user, he will "seen" all when have new message and make me feel I'm not alone when programming at night, jdk. By the way your bot is awesome, me and my friends have a lot of fun time will KeepBot :P

It's nice to see that you're enjoying the bot ;)
But adding this is probably a bad idea, as it makes it seem like it's required to maintain the basic functionality, which it is not.
If you feel like an example of how markAsDelivered and markAsRead is used is needed, make a new one instead :)
Besides, both markAsDelivered and markAsRead are currently undocumented, and unreliable. If possible, It'd be nice if this was fixed before anything else! ;)


FDP-131 Update POMs to get rid of some maven build warnings

Updates POMs to get rid off warnings in the maven site build concerning
potential future build stability issues.
Updates some versions to the currently most recent value and makes sure
some versions are explicitly set in plugin management.

retest this please