阅读统计有点问题

Expected behavior (预期行为)
点击进入博客标题，进入博客详细内容阅读数对应加1，刷新首页页面阅读数不变
Actual behavior (实际行为)
刷新首页，阅读数也会加1
Steps to reproduce the behavior (重现步骤)
NexT Informations
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:

Master
Latest Release
Old version -

NexT Scheme:

All schemes
Muse
Mist
Pisces

Other Informations (Like Browser, System, Screenshots)

是不是只有一篇文章呢？

我也遇到了同样的问题，阅读统计不对，但是后台看leancloud的信息是有的，在首页展示都是0，而在具体的每篇文章的页面，都没有显示，直接展示 ‘阅读次数’

@wozien dont understand u, write in English if not solved. If solved, close it please. Thank's!

@ivan-nginx
I have the same issue.
translation
Expected behavior (预期行为)
点击进入博客标题，进入博客详细内容阅读数对应加1，刷新首页阅读数不变
Click into the posts title, number of views plus 1.
Refresh the home page, number of views will not increased.
Actual behavior (实际行为)
刷新首页，阅读数也会加1
Refresh the home page, number of views will plus 1
NexT Version:  v5.1.2

@conupefox can u show live demo with this bug?

@ivan-nginx
http://blog.d2okkk.net/

http://blog.d2okkk.net/
Click into the posts title, number of views: 28.
Refresh the home page, number of views will increased: 29.
Click into the posts title, number of views: 30.
Refresh the page, number of views will increased: 31.

Google Chrome, cache enabled.


Warn about "impossible" downs

Warn and confirm before migrating if any of the up migrations have an "impossible" down. Ask them to be sure they have a current db backup.

How would one programmaticly determine that a down is impossible? I would think that almost any operation that modifies data would be irreversible?


Sequence contains more than one element

When trying to connect to a server using get-scp, new-sftpsession or any other command I get a "Sequence contains more than one element". An example command might be:
new-sftpsession -computername $server -Credential (Get-Credential)
The server is on a different domain, so my credentials are passed as DOMAIN\username if that helps.

That is because Posh-SSH does not work with Kerberos or NTLM so the the DOMAIN\User format does not work for creds

On May 1, 2015, at 5:54 PM, christianBoman<EMAIL_ADDRESS>wrote:
When trying to connect to a server using get-scp, new-sftpsession or any other command I get a "Sequence contains more than one element". An example command might be:
new-sftpsession -computername $server -Credential (Get-Credential)
The server is on a different domain, so my credentials are passed as DOMAIN\username if that helps.
—
Reply to this email directly or view it on GitHub https://github.com/darkoperator/Posh-SSH/issues/46.

Thanks, that makes sense. Weird thing is that I still get the same error if I leave off the domain from my username. I pass credentials using get-credential or by creating a new PSCredential object. I can get to other servers using password/key auth just fine so something with the configuration of this server must be causing problems.
I apologize if this is not the appropriate place to post this issue as it might not be an issue with your code. Am wondering if you can tell from the error message where in the source this error is occurring and if maybe I'm just doing something wrong. Thanks!

Your logs on the Linux server should be able to provide a clue on what is wrong with the configuration
Sent from my iPhone

On May 4, 2015, at 2:43 PM, christianBoman<EMAIL_ADDRESS>wrote:
Thanks, that makes sense. Weird thing is that I still get the same error if I leave off the domain from my username. I pass credentials using get-credential or by creating a new PSCredential object. I can get to other servers using password/key auth just fine so something with the configuration of this server must be causing problems.
I apologize if this is not the appropriate place to post this issue as it might not be an issue with your code. Am wondering if you can tell from the error message where in the source this error is occurring and if maybe I'm just doing something wrong. Thanks!
—
Reply to this email directly or view it on GitHub.

Actually this is because of how the username retrieved from the credential object in the Posh-SSH code.  I added a different issue since I didn't read the details of this first.  But the problem is that it is using _credential.GetNetworkCredential().UserName, which doesn't include the domain.  Problem goes away if you use _credential.UserName.

Yes, the Linux server that I am trying to connect to is on a different domain so that makes sense.

Download the latest version from Github and test to see if it now fixes the issue.

Yes, this appears to be resolved. Thank you!


_disabed doesn't work properly

Description
according to documentation, the _disabled condition should work with data-disabled attribute. but _disabled styles are rendering in both data-disabled={true} and data-disabled={false}. Just by passing  data-disabled={undefined}, it stops rendering _disabled styles.
Link to Reproduction
https://stackblitz.com/edit/vitejs-vite-fma4fa?file=src%2FApp.tsx
Steps to reproduce

define data-disabled attribute
define _disabled style condition
check data-disabled={true} and data-disabled={false}. in both the _disabled is rendered.
See the error

JS Framework
TS
Panda CSS Version
0.22.0
Browser
chrome
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Additional Information
No response

@Kimzify To css there's a difference between
 and
 in your html
data-disabled={true} in jsx will compile to data-disabled="true" in your html BTW.
Now the equivalent of
 is
 i.e. A value of empty string.
So the right way to use boolean data attributes is to either pass empty string or undefined.


Tooltip cleanup

Conflicts:
app/assets/stylesheets/ui/_tooltip.scss

@nummi Freshened the branch for you guys.


[feature request] create Device, Instance, etc. from raw vulkan handles

I am trying to create a OpenXR application that renders with vulkan. To do so, I have to create vulkan devices and instances using an OpenXR API, as specified here: https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#XR_KHR_vulkan_enable2
I can get raw vulkan handles from these APIs, but I then need to create vulkano Devices and Instances out of those. There is currently no way to do that.

duplicate of #1935


Multiple loaders trouble :)

I've just noticed that if you want to have more than one of these loaders on your page you'll have to make them in the reverse order that the divs which will hold them appear. This is really weird and I couldn't figure it out but who will ever use more than 1 of these, right? :)
(If the need arises I will come back and fix it of course)

Figured it out, fixed :+1:


Restrictive default paths

Maybe you can squash all the commits into one and the use the Signed-off by https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git commit --amend -s --no-edit
$ git push -f

Closing. Superseded by #12


NativeDB#load initialization is racy

I understand that if multiple threads manage to get to this method, the writes to isLoaded and loadSucceeded will be racy. Some synchronization should be performed around these variables.
See https://github.com/xerial/sqlite-jdbc/blob/ddd8fd3294cb3a8eea5f3e003702dbeb52d3327a/src/main/java/org/sqlite/core/NativeDB.java#L59-L66.

Seems like SQLiteJDBCLoader.initialize() is synchronized, so shouldn't be a problem, no?

Closing this as no feedback was received.


Add addOnRPCNotificationListener method to SdlManager

This PR is ready for review.
Risk
This PR makes no API changes.
Summary
This PR adds addOnRPCNotificationListener to SdlManager so developers can register to receive specific notifications. For example when the HMI level changes or when OnVehicleData update is received.
CLA

[x] I have signed the CLA

Codecov Report

Merging #857 into feature/issue_782_Android_Managers will increase coverage by 0.04%.
The diff coverage is 0%.

@@                           Coverage Diff                            @@
##             feature/issue_782_Android_Managers     #857      +/-   ##
========================================================================
+ Coverage                                 44.57%   44.61%   +0.04%
  Complexity                                 3355     3355
========================================================================
  Files                                       415      415
  Lines                                     19441    19441
  Branches                                   1948     1948
========================================================================
+ Hits                                       8666     8674       +8
+ Misses                                    10349    10338      -11
- Partials                                    426      429       +3

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/com/smartdevicelink/api/SdlManager.java
44.6% <0%> (ø)
25 <0> (ø)
:arrow_down:

...rtdevicelink/streaming/video/SdlRemoteDisplay.java
63.23% <0%> (-5.89%)
5% <0%> (ø)

...smartdevicelink/encoder/VirtualDisplayEncoder.java
30.45% <0%> (+1.14%)
8% <0%> (ø)
:arrow_down:

...com/smartdevicelink/api/VideoStreamingManager.java
55.29% <0%> (+4.6%)
14% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ded3f8...2c78236. Read the comment docs.


Fix typo in notification docs

Couple of quick fixes here:

Fixing a typo here from our example that uses an unknown value status rather than build state.
This also fixes an error about the passed value not being a variable.

Oopsie!! Thanks for picking up @jayco !!!


Override browserify version using a new createBrowserify option

This plugin uses browserify 10 which is unable to parse my project. Browserify 12 does work.
Instead of having to update this plugin whenever a new major browserify version is released, it would be easier to let me specify the browserify version I would like to use. This would also let me pin browserify to a specify patch version in case of regressions (which I've actually suffered from using browserify a few times).

Would be a lot easier to just use a peer dep -- this is what they're intended for

Sure. I was going for backwards compatibility with this solution. Want a new PR? Should be released as a new major version.
One downside of this is that if someone were to upgrade to that new major version, without clearing their node_modules directory, they will not notice that their package.json configuration is now broken. On their machine everything will keep working because browserify is still in their node_modules directory, and npm will not warn about a missing peer dependency even though they have not listed browserify as their own dependency. So if they checkout their project on a different machine, npm install will only then fail with a missing peer dependency. Maybe I should post a NPM issue about this.

+1 for the peer dependency solution and a new major version.
I do not worry about backwards compatibility too much as people will eventually clean node_modules / reinstall after updating the dependency to a new major version.
Before we do the peer dependency stuff we should make sure this is properly working including:

compatibility with the latest version of browserify
proper version ranges for the peerDep (needed, right?)

We had peer dependencies before and I removed them because it was a whole mess for users and us maintainers. Might be better now, as browserify stabilized.

Well, a week ago the latest browserify did not work properly with this plugin. I had to patch a regression: https://github.com/substack/module-deps/issues/105 https://github.com/substack/module-deps/pull/106
As for the version range we could either:

Specify a wildcard: browserify: "*"
Only specify a minimum version: browserify: ">= 10"
Specify a range which has tested: browserify: ">= 10 <= 12" or browserify: "^12". A peer dependency failure is only a warning, so a user could use a newer version at their own risk

Let's do a range

Great work @Joris-van-der-Wel on the module-deps fixes. These bugs were the reason we did not upgrade for ages.
Can you prepare another PR with the peerDependency changes + bumped browserify / watchify in dev dependencies? Will make up for a great new karma-browserify release.


Update README code examples

Changes:

Update readme examples that did not work when followed.

Codecov Report

Merging #112 (0774af4) into main (fd7adf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   68.15%   68.15%
=======================================
  Files          18       18
  Lines        2179     2179
=======================================
  Hits         1485     1485
  Misses        694      694

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add section on community pipeline

@willingc and I collaborated on this based on the discussion on community pipeline at the dev meeting.

Cross linking the project overview map I made a start on:
https://github.com/jupyter/jupyter/pull/127

Thanks @takluyver.

/cc @ellisonbg

Should we link issues/pr with the effective implementation?
For instance, @takluyver started some work in the mapping stuff as it was linked above...


Add in stub MDA dihedral casting convention.

Hello @hmacdope! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file distopia/tests/test_distopia.py:

Line 346:80: E501 line too long (97 > 79 characters)


[Server] INFO TO USERS: YES this is a BUG in the mod Factorization report it to them!

I found this on the logs, if you are interested in it
http://pastebin.com/eFfPhunY

https://github.com/purpleposeidon/Factorization/commit/c161e065f7ed93b1785d5d2fd40bc07831b2a964


data set logistic regression Classification

Hello Ashwin
Thank you for your articles. I am reading one of your articles related to logistic regression for clasification. However, I don´t find the dataset that you used in that example.
Can you share us this dataset?
Best regrads,
Orlando

Hi Orlando,
Really appreciate you taking out time to read the article.
You can download the dataset for building the logistic regression model from here
If you have any more doubts, feel free to reach out.
Best and Regards,
Ashwin


Refactoring collection names

Renames ArchiveIndex -> Episodes, CleanedIndex -> CleanEpisodes.

I'm pretty sure, but not certain I've renamed every instance of a collection.

Closing because something is wrong with the remote location. Will resubmit.


Timestamps processing for CDL sources over HTTPS is not correct

Describe the bug
All CDL sources map to an expected sourcetype of pan:firewall_cloud.   This means that Splunk uses a consistent set of rules for all log events sent.  Either ingestion time, the first timestamp found.
types sent by CDL include
Traffic
Threat
GlobalProtect
USERID
HIPMATCH
SYSTEM
(probably more)
Expected behavior
More useful fields for timestamp by log type are likely
For Traffic: SessionStartTime
SYSTEM: EventTime
All others: TimeGenerated
Possible solution
assume different sourcetypes for CDL Traffic and system logs to allow for different time stamp processing.
I currently have and Admin OnDemand request with Splunk to see if an appropriate TIME_PREFIX will allow selecting timestamp by finding a prioritized list of field names
TIME_PREFIX = (SessionStartTime: |EventTime: |TimeGenerated: )
based on a Splunk Answers post by Woodcock
https://community.splunk.com/t5/Splunk-Search/How-to-write-regex-to-identify-and-use-time-field-B-for-event/m-p/129562
Steps to reproduce

Install latest Splunk add-on for Palo Alto Networks to Splunk
Set up Splunk HEC with endpoint defined to index=pan_logs sourcetype=pan:firewall_cloud
Configure CDL to sent log streams over HTTPS the the Splunk HEC endpoint
on log ingestion note that they all use the same rule to determine timestamp

Your Environment
Splunk Enterprise 8.0.7
Splunk_TA_paloalto 6.6.0

More on this:
Splunk AoD gave this config to pull event time between event types from CDL:
SHOULD_LINEMERGE = false
LINE_BREAKER = ([\r\n]+)
KV_MODE = JSON
TIME_PREFIX = (SessionStartTime":"|EventTime":"|TimeGenerated":")
TIME_FORMAT =
MAX_TIMESTAMP_LOOKAHEAD = 27
TRUNCATE = 50000

Basically if SessionStartTime is found, use what follows; otherwise if EventTime is found, use what follows; otherwise if TimeGenerated is found, use what follows

The only problem with this is that it does not automatically work on a Splunk HEC endpoint.
I've since learned that Splunk has HEC endpoints for HTTPS sent JSON events or _raw logs.  When sending JSON events to the event endpoint, Splunk does not honor any config.  It just sets JSON ingestion time
If events are sent to the _raw log endpoint, Splunk will honor config, but the _raw log endpoint cannot handle multiple logs being sent in one HTTPS request (which I have to imagine CDL would want to do)
I don't have a good answer for this.  Does PA have any ideas on how to best handle it?
reference on the HEC endpoints for event vs _raw
https://medium.com/adarma-tech-blog/splunk-http-event-collectors-explained-2c22e87ab8d2
https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/FormateventsforHTTPEventCollector

Hi @MonkeyKa Thanks for creating this issue and bringing it to our attention. I will investigate this further and see if we can come up with a solution.

I would like some clarification on what you are expecting. From what I've read it seems you are interested in having different fields be used as the timestamp in Splunk.

Traffic logs should use SessionStartTime.
System to use EventTime.
Others to use TimeGenerated.

Currently, we have configured HTTPS logs to use "TimeGenerated" as this is the timestamp the log was actually created. You are welcome to customize this. You would have to create a props.conf file in your local directory and add the changes you recommended. This should essentially give you timestamps you are looking for in Splunk.

Hello @paulmnguyen
I am observing the same issue that @MonkeyKa described here.
Yes, the "TimeGenerated" is extracted as _time in the PA addon, But it looks like it doesn't work when we use the HTTP event endpoint.
when the events are formatted in JSON array from CDL, it's having another field called "time" appended before the event array.
Pls refer to the Example event in the below URL,
https://docs.paloaltonetworks.com/cortex/cortex-data-lake/cortex-data-lake-getting-started/get-started-with-log-forwarding-app/forward-logs-to-an-https-server.html

So as per the Splunk HEC documentation, HEC honors the timestamp in the JSON envelope and that's what is happening here.
https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/HECRESTendpoints

let me add a screenshot of the logs from my end, You can see the difference between TimeGenerated and _time in the screenshot below.

For testing the parser, I extracted the logs and manually added the data into Splunk, then the "TimeGenerated" value is getting mapped properly. So this issue is happening only the events are sent view HEC event endpoint.
From my view, if the time is removed from the JSON array schema and auto_extract_timestamp is enabled in the HEC URL, then the HEC should be able to honor that TimeGenerated from the event array.
I also tested the same in my environment, I sent 2 events to the Splunk HEC, one with "time" in JSON array, another without "time" in the JSON array. The same can be tested In any environment.
Event sample:
{"time":<PHONE_NUMBER>,"host": "stream-logf-111-111-11-1111-11","source": "Palo Alto Networks FLS AA","event":{"TimeReceived":"2021-11-15T07:50:26.000000Z","DeviceSN":"no-123","LogType":"USERID","Subtype":"login","ConfigVersion":"10.0","TimeGenerated":"2021-11-29T07:55:21.000000Z","VirtualLocation":"abc11111","SourceIP":"<IP_ADDRESS>","User":"rajkumar_with_time_in_json_array","MappingDataSourceName":"aaa","EventID":"0","CountofRepeats":1,"MappingTimeout":2700,"SourcePort":0,"DestinationPort":0,"MappingDataSource":"aaaaaa","MappingDataSourceType":"","SequenceNo":1234567,"DGHierarchyLevel1":453,"DGHierarchyLevel2":461,"DGHierarchyLevel3":0,"DGHierarchyLevel4":0,"VirtualSystemName":null,"DeviceName":"bbbb","VirtualSystemID":1,"MFAFactorType":null,"AuthCompletionTime":"2021-11-15T07:50:17.000000Z","AuthFactorNo":1,"UGFlags":"123","UserIdentifiedBySource":"xyz","Tag":null,"TimeGeneratedHighResolution":"2021-11-15T07:50:11.550000Z"}}
{"host": "stream-logf-111-111-11-1111-11","source": "Palo Alto Networks FLS AA","event":{"TimeReceived":"2021-11-15T07:50:26.000000Z","DeviceSN":"no-123","LogType":"USERID","Subtype":"login","ConfigVersion":"10.0","TimeGenerated":"2021-11-29T07:55:21.000000Z","VirtualLocation":"abc11111","SourceIP":"<IP_ADDRESS>","User":"rajkumar_WITHOUT_time_in_json_array","MappingDataSourceName":"aaa","EventID":"0","CountofRepeats":1,"MappingTimeout":2700,"SourcePort":0,"DestinationPort":0,"MappingDataSource":"aaaaaa","MappingDataSourceType":"","SequenceNo":1234567,"DGHierarchyLevel1":453,"DGHierarchyLevel2":461,"DGHierarchyLevel3":0,"DGHierarchyLevel4":0,"VirtualSystemName":null,"DeviceName":"bbbb","VirtualSystemID":1,"MFAFactorType":null,"AuthCompletionTime":"2021-11-15T07:50:11.000000Z","AuthFactorNo":1,"UGFlags":"123","UserIdentifiedBySource":"xyz","Tag":null,"TimeGeneratedHighResolution":"2021-11-15T07:50:21.550000Z"}}
Both events reached Splunk, below are the _time field mapping in Splunk for both events
( Just run the query to the get the events, index=* time_in_json_array )

1st event has TimeGenerated mapped to the _time field properly because it doesn't have a "time" field when we sent to event to HEC
2nd event took the "time" field mapped to _time field because there was a "time" field in the JSON array which was sent to HEC.
From my point of view, it's very clear that PA has to remove the "time" from the JSON array as the "TimeGenerated" is the actual timestamp of the event.
Palo Alto team, pls correct me if I am wrong in this OR if there is a way to overcome this issue.
Thanks,
Raj

As called out by Raj, by default Splunk will use the time field for each event as sent to the HEC.  This time field is not the same as any other time field for the record --I am guessing that it is either time received at CDL or time that the record was sent.
Neither of these is useful for analysis.  We'll leave aside what the best timestamp is for a moment to focus on what Splunk is doing
If HTTPS events are sent to the Splunk HEC event endpoint, per Splunks documentation
https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/FormateventsforHTTPEventCollector

if available event metadata time is used -- and as Raj has shown, the time metadata field is sent

However if event metadata for time is not available on the HEC event endpoint, the Splunk admin-on-demand consultant who I spoke to says Splunk does not parse the JSON to look for a next best time,   He told me that Splunk would just set ingestion time for the event and ingests the data as JSON, ignoring any inputs.conf because it knows the data is JSON.  This explanation is different than Raj's.  And Raj's explanation includes an example, so I am inclined to believe that Splunk does parse the record somehow in that case.  If it uses TimeGenerated as he shows, it must be using some kind of config because that is the second timestamp in the raw record.
Now, what is the best timestamp to use?
I think that for most events Generated time is good enough.
But for traffic events the session start time is far more useful as it allows for

much better analysis of the connection frequency.  That is if I were looking for a beacon (and I have looked for beacons), consistent duration between session start times is a very good tell.
much better correlation with the host events related to the network traffic

Event time for system events also allows for better correlation with host events, but in this case high precision is not as important.

Hi @paulmnguyen,
I am also facing the exact same issue. Do you have patch planned for this?


How to create BGP in master node (<IP_ADDRESS>) and worker node (<IP_ADDRESS>) using calico

Hi I'm trying to run calico on my cluster. Currently I'm having two nodes -

master (<IP_ADDRESS>)
worker (<IP_ADDRESS>)

Current Behavior
What I'm having in error -
From master - Readiness probe failed: 2020-08-14 07:59:53.966 [INFO][163] confd/health.go 180: Number of node(s) with BGP peering established = 0 calico/node is not ready: BIRD is not ready: BGP not established with <IP_ADDRESS>
From worker-
Readiness probe failed: 2020-08-14 07:56:19.092 [INFO][140] confd/health.go 180: Number of node(s) with BGP peering established = 0 calico/node is not ready: BIRD is not ready: BGP not established with <IP_ADDRESS>
Working fine if -
If my nodes are in 192.168.Y.X/24 then they can create the BGP connection.
Steps to Reproduce
Not working if -
If my nodes are <IP_ADDRESS>, <IP_ADDRESS> ...
Context
But in real scenario I have different IPs in production VMs.
How can I achieve BGP connection with calico with all of the VMs with different IPs. Example - [<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>].
My Environment

Calico version : v3.15.1
Orchestrator version : Kubernetes-v1.18.6
Operating System and version: Ubuntu-18.04

Sounds like your network might be dropping the BGP traffic that Calico needs. Double check that your network meets these requirements: https://docs.projectcalico.org/getting-started/kubernetes/requirements#network-requirements

Hi @caseydavenport looks like that is only working only /24 cidr blocks.
But I need /8 and /16 also. Is there anything that I need to configure in calico?

I'm not sure what you mean - the size of the network that your hosts are in doesn't matter to Calico.

But I need /8 and /16 also. Is there anything that I need to configure in calico?

From your description, I guess you are deploying calico across subnets. So you should choose the appropriate network mode according to the actual scenario, refer to the document: https://docs.projectcalico.org/networking/determine-best-networking

Going to close this for now, please open another issue if you're continuing to have issues, thanks!


helm chart default container tag values are inconsistent with build target defaults

Expected Behavior

Using helm charts directly should use sensible default values.  The default tag value of master is inconsistent with the docker build machinery's default of latest.
NSM shouldn't assume users are using make targets to do NSM installation.  Many users have tooling that integrates directly with helm.
Current Behavior

If my workflow is...

Modify NSM infra
make k8s-build
make k8s-save
for img in $(ls scripts/vagrant/images/*.tar); do echo $img; docker load -i $img; done
Use helm to install without modifying tag, ie. helm template deployments/helm/nsm --namespace nsm-system --set global.JaegerTracing=true | kubectl apply -f -

...NSM would not run with the images I just built because the default tag value in the helm chart has changed to master.
Failure Information (for bugs)

Steps to Reproduce

See current behavior section above.
Context

The issue is potentially reproduced for anyone who uses helm directly, rather than the new make helm-* targets.
Failure Logs

@tiswanso well the charts that we publish should fetch the images from dockerhub, hence master. Our make targets helm-install-nsm etc, do incorporate the right machinery to deploy with helm and set the images tags to latest unless specified otherwise in CONTAINER_TAG env.
Maybe we need to document it better?

I also had this issue, after speaking to @edwarnicke I understand why the images are tagged with master. If the releases are semantically versioned then production deployments should be pinned against this version number.
In the quickstart guide, if you do make make helm-install-nsm without  doing  make k8s-save and make k8s-load-images then helm will pull images tagged latest from dockerhub
when you do 'make helm-install-nsm' it spits out the following helm command
helm install --name=nsm \
        --wait --timeout 300 \
        --set org="networkservicemesh",tag="latest" \
        --set forwardingPlane="vpp" \
        --set admission-webhook.org="networkservicemesh",admission-webhook.tag="latest" \
        --namespace="`cat "k8s/conf/namespace-nsm.yaml" | awk '/name:/ {print $2}'`" \
        deployments/helm/nsm

which gives you an image 3 months old.
I can attempt to fix this but need some direction, so some options:

Make circleci tag latest on every push to Dockerhub, change helm charts tag to latest
Rework the quickstart guide to not use make to deploy helm resources and be explicit about the tag being master.
set the CONTAINER_TAG to master in the makefile, Could be problematic for people building images locally as these are tagged as latest in the local docker build.


RequestPermissionsAsync crash on iOS for cossplatform Xamarin.Forms app

Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On:  iphone 6s (iOS 11.4)
Simulator Tested On:  none
Version of VS: VS community 7.6
Version of Xamarin: Xamarin.Forms <IP_ADDRESS>9530-pre
Versions of other things you are using: Xamarin.iOS <IP_ADDRESS>
Steps to reproduce the Behavior

Install app
try to access the camera
permission popup will be shown deny camera permission
and then try code given in code snippet

Expected Behavior
The app should not crash after calling RequestPermissionsAsync, it must show request permission popup and then allow a user to select permission option
Actual Behavior
The app is crashing after calling RequestPermissionsAsync
Code snippet
var status = await CrossPermissions.Current.CheckPermissionStatusAsync(Permission.Camera);
if (status == PermissionStatus.Denied)
{
if (await CrossPermissions.Current.ShouldShowRequestPermissionRationaleAsync(Permission.Camera))
{
await DisplayAlert("Need camera", "camera", "OK");
}
     var results = await CrossPermissions.Current.RequestPermissionsAsync(Permission.Camera);
     status = results[Permission.Camera];

}
Screenshots

I can confirm this issue. My app crashes when calling RequestPermissionsAsync. It seems like the plugin also always returns PermissionStatus.Unknown when using CheckPermissionStatusAsync on iOS.
Log:
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	1   libsystem_platform.dylib            0x00000001bebaaa20 <redacted> + 56
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	2   libsystem_kernel.dylib              0x00000001beb2d838 <redacted> + 100
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	3   libsystem_kernel.dylib              0x00000001beb2d868 fcntl + 0
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	4   TCC                                 0x00000001c1df0b80 <redacted> + 0
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	5   TCC                                 0x00000001c1df0ab4 <redacted> + 0
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	6   TCC                                 0x00000001c1df4c5c <redacted> + 276
2018-10-11 15:58:54.760 App.iOS[1082:135356] critical: 	7   libxpc.dylib                        0x00000001bebfe514 <redacted> + 60
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical: 	8   libxpc.dylib                        0x00000001bebf1b3c <redacted> + 88
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical: 	9   libdispatch.dylib                   0x00000001be9d8504 <redacted> + 16
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical: 	10  libdispatch.dylib                   0x00000001be9908c4 <redacted> + 320
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical: 	11  libdispatch.dylib                   0x00000001be988874 <redacted> + 1288
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical: 	12  libsystem_pthread.dylib             0x00000001bebba100 _pthread_wqthread + 328
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical: 	13  libsystem_pthread.dylib             0x00000001bebbcd00 start_wqthread + 4
2018-10-11 15:58:54.761 App.iOS[1082:135356] critical:
=================================================================
Got a SIGABRT while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

In my case it was the Permission.MediaLibrary permission that caused the SIGABRT error. I see that this permissions has been removed in the latest commit (90ca6ccee22b2e4feb42917fcc99b22bb33d4ce7). Would it be possible to update the Nuget-package?

I am facing this issue with Permission.Camrea

Yes, all settings are done as per the instructions given in the readme

Same, crash on RequestPermissionsAsync without possibility to catch the error. Tested Camera and Microphone permissions.
Version Number of Plugin: 4.0.1-beta, <IP_ADDRESS>
Device Tested On: iPhone SE
Version of VS: VS Community for Mac, 7.6.9 (build 22)
Version of Xamarin: Xamarin.Forms <IP_ADDRESS>7442-pre1

I am also getting this problem (or a similar one) with the Camera permissions on Xamarin.iOS. If the permissions have been Denied, then the RequestPermissionsAsync does not return and the app hangs or crashes. I do not have this problem with the Photos permission.

I am facing the same issue. I can retrieve all permissions that I have tried, but I cannot retrieve permissions with for the camera. The problem exists on iOS, but everything seems to work correctly for Android. To be clear, I have added the required plist permissions per this article: https://blog.xamarin.com/plugin-permission-changes-ios-11/

Further to the above, here are the keys I am using the Info.plist:
NSCameraUsageDescription
This app needs access to the camera to take photos.
NSPhotoLibraryAddUsageDescription
This app needs access to save photos to your library.
NSPhotoLibraryUsageDescription
This app needs access to read photos from your library.
NSBluetoothPeripheralUsageDescription
This app needs access to read photos from your library.
NSMicrophoneUsageDescription
This app needs microphone for video

Update...
So here is a way that I have discovered that makes it work. The failure was on
await CrossMedia.Current.Initialize();
It failed on iOS only. However, if on iOS, I force Intilalize() to run on the UI thread, it works. Here is an example:
`            switch (Device.RuntimePlatform)
{
            /* The following is a workaround for CrossMedia.Current.Initialize()
             * When using iOS, the Initialize call must be forced to the UI thread.
             * Failing to do so will cause the call to silently fail and boot the
             * processing flow out to the calling method. This is an undocumented hack. */
            case Device.Android:
                {
                    await CrossMedia.Current.Initialize();
                    IsCameraEnabled = await CheckPermissionStatusAsync(Permission.Camera);
                    break;
                }
            case Device.iOS:
                {
                    Device.BeginInvokeOnMainThread(async() =>
                    {
                        await CrossMedia.Current.Initialize();
                        IsCameraEnabled = await CheckPermissionStatusAsync(Permission.Camera);

                    });
                    break;
                }
        }

`
This was a last-ditch effort before I abandoned the entire CrossMedia approach and looked for another solution.
Hopefully this will help others.

I met the same problem but requesting Location Permission :(
but totally success when request the camera permission.
I had added
Location When In Use Usage Description and also Location Always Usage Description.
It still can't go through the
await CrossPermissions.Current.RequestPermissionsAsync(new[] { Permission.Location });
Are there any solution or suggestion?

Thanks Michael, Your suggestion will help us all, but now I have updated Xamarin.Forms version of My application to 3.4.0 and now I am not able to reproduce this issue any more with my App. May be this issue was related to Xamarin.Forms so I will suggest to upgrade Xamarin.Forms version to 3.4 and try whether it solves this issue in your respective projects. If you have any other stable solution for getting device permission please share it with us

Hi Akshay,
Thanks for the feedback. I am using Xamarin Forms <IP_ADDRESS>569-pre3, so I am already ahead of the 3.4.0 release that you are suggesting. It could be that whatever was the problem that was resolved in 3.4.0 was reintroduced in 4.0.

Great, closing this issue as I am not able to reproduce this anymore, thank you guys for your support.

update plist with following
 <key>NSLocationWhenInUseUsageDescription</key>     <string>This app needs access location when open.</string>     <key>NSLocationAlwaysUsageDescription</key>     <string>This app needs access to your location.</string>     <key>NSLocationUsageDescription</key>     <string>This app needs access to your location.</string>     <key>NSLocationAlwaysAndWhenInUsageDescription</key>     <string>This app needs access to your location.</string>      <key>NSLocationAlwaysAndWhenInUseUsageDescription</key>     <string>This app needs access to your location.</string>

What helped me solving this issue (in <IP_ADDRESS>) :

Ensure that the Permission I request matches Info.plist (read Permission description)
(very odd one) Remove break point on CrossPermissions.Current.RequestPermissionsAsync as stepping with debugger (iOS real device + Visual studio macOS up to date) causes this bug. (You can still use break points before this call or after status is returned).

Other info :

I was using Xam.Plugin.Media, so I removed reference to this plugin as Xam.Plugin.Media already bundled it. (not sure if it solved anything, but worth mentioning it)
My code is in runned on MainThread via Device.BeginInvokeOnMainThread its more related to my needs than to this problem.

PS I was working with Location permission.

Thanks a lot @MarcAlx . Using break points and stepping through my code is what was breaking it :/


Feature request: dialog box shadow (dark mode)

Dialog elements having a box-shadow of 0 0 0 1px var(--border) will be helpful in dark mode. See attached image for comparison:

Or, the backdrop colour can be updated in dark mode:
@media (prefers-color-scheme: dark) {
	dialog::backdrop {
		background: rgba(255, 255, 255, 0.61);
	}
}

hey can you assign this issue to me!


Does not build with Expo EAS

Likely one or more dependencies which need to be updated:
[stderr] e: Incompatible classes were found in dependencies. Remove them from the classpath or use '-Xskip-metadata-version-check' to suppress errors
1464
[stderr] e: /home/expo/.gradle/caches/transforms-3/5d5c005847cf8de15717b495cdeb2994/transformed/jetified-kotlin-stdlib-jdk7-1.6.10.jar!/META-INF/kotlin-stdlib-jdk7.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.6.0, expected version is 1.1.15.

The example app using release 1.1.0 builds on EAS now. However I cannot get it to work. (It threw from react-native-document-picker.) I don't have the resources to address this. Please feel free to fork and make a fix.


Compile error using latest OpenSSL

I get this error while compiling with the latest version of OpenSSL
src/event/ngx_event_openssl.c: In function ‘ngx_ssl_connection_error’: src/event/ngx_event_openssl.c:2048:21: error: ‘SSL_R_NO_CIPHERS_PASSED’ undeclared (first use in this function)              || n == SSL_R_NO_CIPHERS_PASSED                          /*  182 */                      ^~~~~~~~~~~~~~~~~~~~~~~ src/event/ngx_event_openssl.c:2048:21: note: each undeclared identifier is reported only once for each function it appears in objs/Makefile:1092: recipe for target 'objs/src/event/ngx_event_openssl.o' failed make[2]: *** [objs/src/event/ngx_event_openssl.o] Error 1
Version of OpenSSL:
Package: libssl-dev
Source: openssl
Version: 1.1.0e-1
Is there anyway I can compile using the older version which is supported?

Yes. I had similar issue with latest openssl being pushed to official repositories.
Usually installing this package will resolve the problem:
apt-get install libssl1.0-dev
This should install OpenSSL version 1.0.2 and the compilation will succeed. Don't forget to do make clean before you compile with new libssl.

Thanks a lot, that worked.

Perfect! Closing issue.

Index: src/event/ngx_event_openssl.c
--- src/event/ngx_event_openssl.c	(revision 7318)
+++ src/event/ngx_event_openssl.c	(revision 7319)
@@ -1194,4 +1194,8 @@
} else {
SSL_set_accept_state(sc->connection);
+
+#ifdef SSL_OP_NO_RENEGOTIATION

   SSL_set_options(sc->connection, SSL_OP_NO_RENEGOTIATION);

+#endif
}


Uncaught exception: Max call stack exceed

🤷🏽♂ Current Behaviour

App opens when system boots up with an error message.
🎯 Expected Behaviour

No error.
👟 Steps to Reproduce (S2R)

boot the system, wait for app to open
error message

🏡 Environmental Context

App Version
v8.1.1
Installation Type
Setup
Operating System
Windows 10 Pro x64 (17763.00)

@HankAviator
Thank you for your feedback. Was this issue resolved with one of the recent releases?
Cheers,
S

Hi Sidneys,
Unfortunately I already switched to official Pushbullet since I didn't get timely response on this issue.

@HankAviator
Okay - thanks anyways for your input nonetheless.
If you are to give PB4D another go in the future, you are more than welcome.
Cheers, S


onlyoffice-bin: 7.2.0 -> 7.4.1

Description of changes

Bumped version to 7.4.1 (changelog)
Added libgbm (mesa) as a dependency for the newly-bundled libcef
Wrapped in buildFHSEnv because the plugin download feature directly references /usr/bin/curl (I am new to Nix, this seemed like the best solution to me but I may be wrong)

Maintainers: @nh2 @GTrunSec
Closes: #225249
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2513

I tested this PR on Wayland env, which is pretty slow when opening a tab(even crashed after a few seconds).

@GTrunSec Is that a regression / is it fine on Wayland in the current version?

@nh2  Based on my testing, the experience under Wayland is inferior and nearly unusable. Do I need some special args for the wayland desktop?

It seems to work perfectly fine for me on Wayland, just as good as on X11.

It seems to work perfectly fine for me on Wayland, just as good as on X11.

@fin444  Did you enable the QT_QPA_PLATFORM=wayland with onlyoffice-bin?
Are you running that app on hyprland/sway ?

@GTrunSec running with QT_QPA_PLATFORM unset or set to wayland produces no issues. I am using Plasma.

It seems this is a problem with 7.3+ on all wlroots environments
https://github.com/ONLYOFFICE/DesktopEditors/issues/1208

How about keeping two versions here?  the 7.2 is still to be a default, but the latest version would be in passthru.latest.

Something like this?

@nh2 The latest 7.4+ version has been placed in the bin.latest as an alternative while still retaining 7.2 as the default version.

@fin444 @GTrunSec Looks good overall and both work in X11 (I didn't test wayland), but a request:

The explanatory contents of the commit message of the previous commit in this PR (https://github.com/NixOS/nixpkgs/commit/0d5de6501c043803ce7736f3a7af3ba2eff7d832) should be retained in comments. There should never be non-obvious code that's "just there" without explanation.

And a question:

It seems a bit weird to add another package into passthru.latest (though I couldn't find anything technically wrong with it). Most packages in pkgs/top-level/all-packages.nix add an independent package with _latest suffix. Maybe this package should do it as well?

@nh2 My bad, I explained it in the commit but not in the comments. Will fix. Which version naming would be preferable?
onlyoffice-bin_latest and onlyoffice-bin
or
onlyoffice-bin and onlyoffice-bin_7_2?

Based on the above report that on Wayland only the old version works, I propose:
onlyoffice-bin_7_2 = ...
onlyoffice-bin_7_4 = ...

onlyoffice-bin = onlyoffice-bin_7_2;
onlyoffice-bin_latest = onlyoffice-bin_7_4;

Looks good, merging. Thanks @fin444 for your contribution!

For reference, 7.4 works fine on Plasma (Wayland) for me too.  There's definitely some bugginess (e.g. I opened a second spreadsheet and the tab was blank; this fixed itself when I closed and repopened the tab), but it's about the level of bugginess I've come to expect from OnlyOffice.

@scvalex The problem does not occur on all Wayland systems, only on wlroots-based compositors.


Allow for custom component sources in .bowerc

I have a fork of the bower-angular and bower-angular mock repositories, with extra tags for the pre-release versions so that I can install them using bower. I attempted something like the following:
{
  "dependencies": {
    "angular": "git://github.com/dancras/bower-angular.git#~1.1.3",
    "angular-mocks": "git://github.com/dancras/bower-angular-mocks.git#~1.1.3"
  }
}

Angular mocks has its own dependency on angular, and currently it ignores the already installed angular version in favour of the one in the heroku registry. It will attempt to install a second version of angular which doesn't have my extra tag.
The ability to replace a third party library with your own fork is quite useful, for example for an urgent fix or feature while waiting for it to be added to a release. The new multiple endpoint functionality could be used to achieve this, but that seems more suitable for maintaining a large number of permanent dependencies.
My current solution is to add a registry to my .bowerrc:
{
  "registry": {
    "angular": "git://github.com/dancras/bower-angular.git",
    "angular-mocks": "git://github.com/dancras/bower-angular-mocks.git"
  }
}

Then modify the Source API so that endpoints defined in this local registry take highest priority:
exports.lookup = function (name, callback) {

  if (config.registry && config.registry[name]) {
    callback(null, config.registry[name]);
    return;
  }

  // ... search endpoints

In my components.json I can go back to simply using:
{
  "dependencies": {
    "angular": "~1.1.3",
    "angular-mocks": "~1.1.3"
  }
}

Thoughts appreciated. Thanks

It can be now achieved with locate method of Pluggable Resolvers feature :) You can implement custom resolver that looks at the sources field in .bowerrc, returns true from match function when resolved dependency matches one of the sources, and write locate method that returns custom source. Hope you'll have time to implement it.


Add ESP32-S2 CopyDMA and CryptoDMA

Based on the ESP32-S2 TRM v1.1. PAC is not yet generated to make it somewhat reviewable.

I'm really not sure why you'd want to see a thousand lines of pure additive definitions be merged with 400 lines of random small changes, especially that the main patch file includes a bunch of other things anyway. This way the actual patches are separated from the new functionality instead of being mixed with them.

if those peripherals are mostly identical you could just "_copy" them from another SVD file by file_path:per_name

if those peripherals are mostly identical you could just "_copy" them from another SVD file by file_path:per_name

What are you suggesting, exactly? Copy from where, these peripherals don't exist in SVD files.

sorry. just saw "copy" word from phone and big add and decided this a copy from other file

Alas, no, the peripheral is called Copy DMA :(

My plan is to try and implement crypto dma in esp-hal, iterate on the PAC if I need to, then merge the new additions back to esp32s2.yaml after I'm confident I don't have to change them.

@bugadani
I agree with you, having changes for each peripheral in a separate file is quite convenient, I, for example, sometimes get tired of searching through a huge .yaml patch for the section I'm interested in, but then we should take the time to do the same for all patches of all peripherals.
Now, to maintain consistency (and not to make an even bigger mess of this repo 😅 ), I would still insist that these changes should be made in that one huge chip-wide file


[SPARK-43858][INFRA][FOLLOWUP] Restore the Scala version to 2.13 after run benchmark

What changes were proposed in this pull request?
This is a followup of https://github.com/apache/spark/pull/41358, this pr change to restore Scala version to 2.13 after running benchmark to avoid containing changed pom.xml in the results tarball.
Why are the changes needed?
After running benchmark, should restore Scala to default version to results tarball includes changed pom.xml.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

To check result https://github.com/LuciferYang/spark/actions/runs/5113029827

Before this pr, I found there are many changed pom.xml in result tarball:


python3Packages.deezer-python: 2.2.4 -> 2.3.0

Motivation for this change
Update to latest upstream release 2.3.0
Change log: https://deezer-python.readthedocs.io/en/stable/changelog.html#v2-3-0-2021-06-27
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129017 run on x86_64-linux 1

2 packages built:

python38Packages.deezer-python
python39Packages.deezer-python

Result of nixpkgs-review pr 129017 at 74f807d9 run on aarch64-linux 1

2 packages built successfully:

python38Packages.deezer-python
python39Packages.deezer-python


chore: set max SDK version to <3.0.0 upgrade test and remove browser …

I didn't update the version in pubspec.yaml yet. If somebody provides me with the proper version, I'll add this to the PR and add an entry within the changelog.

@eredo – you need to update .travis.yml to remove 1.23.0 SDK – then we'll be good!

@kevmoo - sorry for the delay, time difference ;) . I removed 1.23.0.

@kevmoo any schedule on when this version will be published?

@nex3 – would you help w/ this?


Use Symfony Command constants for return of execute

With https://github.com/rectorphp/rector-symfony/blob/main/docs/rector_rules_overview.md#consoleexecutereturnintrector we got explicit return type int but it is even nicer to use Symfony Command constants they also use it as example in there documentation see https://symfony.com/doc/current/console.html#creating-a-command
Example:
 use Symfony\Component\Console\Command\Command;

 class SomeCommand extends Command
 {
    public function execute(InputInterface $input, OutputInterface $output): int
     {
-        return 0;
+        return Command::SUCCESS;
     }
 }

If you say its a nice addition a new rule should be added as its not part off ConsoleExecuteReturnIntRector right?

This would be great addition :+1:

Okay i will work on this

Fixed with https://github.com/rectorphp/rector-symfony/pull/256


Phosphor Icons Themes not Working

When using the theme property on icons from the Phosphor Icons pack it doesn't provide any other style except for the default.
You can reproduce this with the following code:
import { Pizza } from '@steeze-ui/phosphor-icons';
<Icon src={Pizza} theme="fill" />

I realized that the issue I raised was actually caused by a problem in my own code. Apologies for the confusion and any inconvenience caused. I’m closing this issue now. Thanks for all your hard work on this project!


security: remove regexp vulnerable to DOS in cast option

Updated to include the commit b329a6d2466778a3d042c68f745ebe5d3cf71d17 which updates the tests. This would make adding more patches easier.


[KARAF-5178] Use lambdas where appropriate

Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

R: @jbonofre


Update FAQ section in User Guide

added some frequently asked questions and information about CLI applications that are missed out in the user guide.
included unique ids to headers to allow linking. Sections can now be hyperlinked from other parts of the user guide.

Some typos to amend, other than that, FAQ section is concise and informative. LGTM.

Other than the aforementioned changes suggested by @hyc17003, LGTM.


Feature/command line bandwidth cap

Allows capping of throughput for upload, download and S2S.
The S2S implementation is relatively coarse-grained (at block level) while the upload and download implementations are finer-grained (because we can see the actual data).
As discussed, there's no dynamic rate-seeking here. It just takes and optional mbps cap on the command line.

How is this cap ingested? I only see changes inside ste. Is this an environment variable or something?

  case <-p.done:

Which of these suicide channels goes unused? Is it possible we could cut one and convert everything to the other?

Refers to: ste/pacer-tokenBucketPacer.go:138 in d20ee4a. [](commit_id = d20ee4a89e4b4674c0571b7a5f374cca49becf25, deletion_comment = False)

Note to @zezha-msft when you get around to reviewing this, it'll look like a scary amount of code touched. However, the bulk of this PR actually lives inside of the following few files. Everything else is mostly function signature changes:

main.go
cmd/root.go
ste/jobsAdmin.go
ste/pacedReadSeeker.go
ste/pacer-tokenBucketPacer.go

More info for @zezha-msft to have a bit speedier a review: Roughly the way that I can tell this works is that an STE startup function gets passed from main.go to cmd/root.go, gets baked into the root pre-run function w/ the new parameter in cmd/root.go.
Then, in STE, if the maximum megabits per second is above 0, it uses the new tokenBucketPacer. If not, it uses nullAutoPacer, which doesn't limit throughput. tokenBucketPacer basically treats throughput as a replenishing currency, and semi-queues requests by delaying them up to 150% of the maximum wait time, depending on how many waits are currently happening (modulo 10). on

I say semi-queues because it doesn't actually create a queue, but it more or less just layers transfers X seconds into the future.

case <-p.done:
Which of these suicide channels goes unused? Is it possible we could cut one and convert everything to the other?

Actually, both are used.  The Close based one (p.done) is used when this code is used by the page blob pacing code (file-specific pacing, has been in place since before GA).  I left the context-based one in place because we don't currenly have a place to call Close for JobsAdmin, so the global (command-line cap) pacer won't have Close called on it.
One alternative would be to simply get rid of the context-based cancellation, and rely on the fact that JobsAdmin runs until the app exits anyway, and so it doesn't really matter if this routine is still running at that time.  I.e. we simplify the code as Adele suggests, and just never shutdown the global pacer. What do you think, @adreed-msft  and @zezha-msft ?

delaying them up to 150% of the maximum wait time, depending on how many waits are currently happening (modulo 10). on

There is no limit to how long it will make them wait. (The 150% limit applies only to a single iteration; but there is no limit to how many iterations there may be).

A rather important one is the comment on ste/pacer-tokenBucketPacer.go:102. In theory, AzCopy could bust past the user-suggested limit with enough transfers.

It can't bust past. (If I'm wrong, please give me a little more help to see that ;-)

Moreso code cleanliness oriented, a comment unrelated to your changes about having two suicide channels for ste/tokenBucketPacer.go:136.

Awaiting reply from you and Ze to comment above.

Finally, another code cleanliness oriented suggested change would be to try to move the ste initialization into cmd/root.go rather than having part of it live in main.go, and then just go along a sort of assembly-line for it to finally be placed into the root pre-run function.

Awaiting reply from you and Ze to comment above.

@JohnRusk Sorry for the delay, I'll review on Monday (Redmond time).

Ping @zezha-msft  for Wednesday

One alternative would be to simply get rid of the context-based cancellation, and rely on the fact that JobsAdmin runs until the app exits anyway, and so it doesn't really matter if this routine is still running at that time. I.e. we simplify the code as Adele suggests, and just never shutdown the global pacer. What do you think, @adreed-msft and @zezha-msft ?

This would probably work just fine. I don't think there's anything too important perf wise after a transfer is over, so it doesn't particularly hurt to keep the routine alive here.

One alternative would be to simply get rid of the context-based cancellation, and rely on the fact that JobsAdmin runs until the app exits anyway, and so it doesn't really matter if this routine is still running at that time. I.e. we simplify the code as Adele suggests, and just never shutdown the global pacer.

Sounds good to me, the global pacer and live/die with the whole application.

@adreed-msft thanks a lot for the insights, they made it super easy to CR this change.
@JohnRusk really sorry for the delay in review! 😢

No prob, @zezha-msft  :-)

@zezha-msft thoughts on the way we're baking a lambda from main.go into the root pre-run function? It feels like a bit of a wild goose chase to find the actual function there when it could've just as easily been a part of root.go.

@JohnRusk I'm merging now to get a full build into perf testing. Please address the comments on your Monday. 😄

Lambda is fixed, can ctx removed. Both changes are here: #472


Shop front footer ui issue fixed #7355

Issue Reference
#7355

Footer ui issue fixed while toggle footer text.

@mayank-webkul
Getting different-2 views of the footer section, on mobile and desktop. Please find the below screenshot.

Mobile view
Desktop view

@mayank-webkul
This is working fine. please find the screenshot Here


build: set up binary compatibility validator

For better API compatibilities check.
https://github.com/Kotlin/binary-compatibility-validator

CC @KengoTODA


Error when building on Windows with MinGW with LTO enabled

Operating system or device, Godot version, GPU Model and driver (if graphics related): Windows 10 Fall Creators Update, Godot Git https://github.com/godotengine/godot/commit/ad85224ebcf7bbad5565457d355c429b02190c58
Issue description: Using MinGW-w64 from MSYS2, the build fails when use_lto=yes is used. However, it works when using use_lto=no (or when leaving it out, which defaults to no).
See the error log below (using Python 2.7.13):
scons: warning: No version of Visual Studio compiler found - C/C++ compilers most likely not set correctly
File "C:\Users\hugol\Documents\Git\godotengine\godot\SConstruct", line 4, in <module>
MSVC not detected (no VCINSTALLDIR environment variable), attempting MinGW.
KeyError: 'use_llvm':
  File "C:\Users\hugol\Documents\Git\godotengine\godot\SConstruct", line 300:
    detect.configure(env)
  File "./platform/windows\detect.py", line 267:
    if not env['use_llvm'] and env.GetOption("num_jobs") > 1:
  File "C:\Python27\Scripts\..\Lib\site-packages\scons-2.5.1\SCons\Environment.py", line 410:
    return self._dict[key]

Steps to reproduce: Build Godot with use_lto=yes with a MinGW-w64 compiler in the PATH.

I'm sure you can fix that yourself with a little nudge in the right direction: https://github.com/godotengine/godot/blob/master/platform/windows/detect.py#L265-L270

Hint: We don't support clang on Windows for now.


Have Validate take in data that tells what constraints to check for

Would be nice to generalize Validate so that we can use it to check for whatever constraints are relevant at whatever point in the compiler we're at. Right now it is implemented for check for issues that might arise in monomorphization, but for example we could have it check for things like bundle elimination, and so on.

I actually don't think that we should parameterize the Validate pass anymore and just make it check everything all the time. The basic idea is that Validation should be cheap to use and enforce strong constraints.


PlatformIO tasks doesn't work

VSCode Version: 1.30 insider
OS Version: macOS 10.14.1 Mojave
PlatformIO IDE 1.4.3

I'm using platformIO for development, with the insider version most of the task doesn't work anymore.

The problem has nothing to do with the other issue (I now about the problem with Arduino plugin from MS). The problem occurs with the new insider version (1.30) and works PlatformIO works without a problem with 1.29 insider and release.

@Ivankravetz from PlatformIO knows about it.

Seems to be related to #63104, which I'm looking into now.

Duplicate of #63104


doNotTrack property not present on Navigator

TypeScript Version:  2.5.3
Code
if(navigator.doNotTrack.substr(0, 1) === '1') { }

Expected behavior:
No problems as long as the lib compiler option includes dom. I'm not sure if Working Drafts are sufficient to add it to the type definitions, but it's implemented in most modern browsers and according to MDN is the property that should be checked for whether DoNotTrack is enabled.
Actual behavior:
error TS2339: Property 'doNotTrack' does not exist on type 'Navigator'.

Docs at https://www.w3.org/2011/tracking-protection/drafts/tracking-dnt.html#widl-Navigator-doNotTrack

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

Thanks for the link, PR here: https://github.com/Microsoft/TSJS-lib-generator/pull/307


Update sonic-pi to 3.0.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

FYI, I followed the instructions to upgrade from my personal branch, and got an error:
You can upgrade the cask right now from your personal branch:
  brew cask reinstall https://raw.githubusercontent.com/bhrutledge/homebrew-cask/cask_repair_update-sonic-pi/Casks/sonic-pi.rb

Submitted (https://github.com/caskroom/homebrew-cask/pull/39921)

$ brew cask reinstall https://raw.githubusercontent.com/bhrutledge/homebrew-cask/cask_repair_update-sonic-pi/Casks/sonic-pi.rb
==> Downloading https://raw.githubusercontent.com/bhrutledge/homebrew-cask/cask_repair_update-sonic-pi/Casks/sonic-pi.rb.
######################################################################## 100.0%
==> Satisfying dependencies
==> Downloading http://sonic-pi.net/files/releases/v3.0.1/Sonic-Pi-for-Mac-v3.dmg
Already downloaded: /Users/brian/Library/Caches/Homebrew/Cask/sonic-pi--3.0.1.dmg
==> Verifying checksum for Cask sonic-pi
==> Uninstalling Cask sonic-pi
==> Removing App '/Applications/Sonic Pi.app'.
==> Installing Cask sonic-pi
Error: Uh oh, could not figure out how to unpack '/Users/brian/Library/Caches/Homebrew/Cask/sonic-pi--3.0.1.dmg'

Thanks for the PR!


send proximity_out in proximity in for tablet_v2

When the proximity_in event is sent for tablet_v2 and there's already a
surface that currently has tablet (tool) focus, it should be told that
this is no longer the case, so we need to send the proximity_out event.

Thanks!


App.cable.subscriptions.create

What is  this problem?
The error occurs after refreshing the page

i'm using rails 6


unable to set up pump.io

I have installed pump.io globally but am unable to set it up. There is no /etc/pump.io.json config file that was created. I have nodejs installed in home folder. Is it similar to mean/express modules that generate project files on initializing the project? pumpio documentation isn't clear about this.

there is a pump.io/pump.io.json.sample that needs to be renamed.
https://github.com/e14n/pump.io/blob/master/pump.io.json.sample
there are more configuration specifics in the readme:
https://github.com/e14n/pump.io/blob/master/README.md

Closing given that an answer has been provided and there hasn't been activity in this issue in many months.


Error when running commands in Python 3

When I try running any command in Python 3.6, I get the following error:
python -m nlppln.commands.ls .
Traceback (most recent call last):
  File "/home/dafne/anaconda2/envs/adh/lib/python3.6/runpy.py", line 183, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/dafne/anaconda2/envs/adh/lib/python3.6/runpy.py", line 153, in _get_module_details
    code = loader.get_code(mod_name)
AttributeError: 'Py2Fixer' object has no attribute 'get_code'

More details of the problem (no solution yet):

When running a module with python -m <module> the script runpy.py tries to access get_code from the module loader.
The loader is Py2Fixer and this loader does not have the get_code function
The commands probably get the Py2Fixer loader because they import click, and click also has this loader

Correction, the problem lies in the package salad:
~/anaconda2/envs/nlppln3/lib/python3.6/site-packages/cwltool/load_tool.py in <module>()
     17 from six.moves import urllib
     18
---> 19 import schema_salad.schema as schema
     20 from avro.schema import Names
     21 from ruamel.yaml.comments import CommentedMap, CommentedSeq

~/anaconda2/envs/nlppln3/lib/python3.6/site-packages/schema_salad/__init__.py in <module>()
     29                 exit(1)
     30
---> 31     from past import autotranslate  # type: ignore
     32     autotranslate(['avro', 'avro.schema'])

ModuleNotFoundError: No module named 'past'

the autotranslate function 'hooks' the Py2Fixer loader into sys.meta_path.  That only happens after scriptcwl is imported, and through it cwltool and salad.
The reason it only happens for the modules in commands is that runpy.py loads the parent module, and in nlppln/__init__.py the dependencies are loaded.

I created a pull request in schema_salad:
https://github.com/common-workflow-language/schema_salad/pull/165

Fixed in schema_salad version 2.7.20180322174040.


Don't require a space before the # in an ignore comment.

This is important for file-level ignores which go on line 1 for now. We should have a better comment system for file-level ignores but this is a stop-gap at least.

@tas50 Finally green. I r gud at code.


Add disk_size_gb option to DataflowBakery

I would like to be able to specify larger attached disks (see https://github.com/pangeo-forge/pangeo-forge-recipes/issues/722) using runner.

LGTM!

I just tested this on Dataflow and got the expected HDD size:


Added customMessage optional param to ReportGUID

I would like to offer a GUI to ask the user to give a brief description on why they are reporting a player (is it for harassment, doxxing, adult content). So I added a third optional parameter to AddOn_Chomp.ReportGUID to let addons provide a custom message for the report.

Merged in 7838f5036eeefa73015d65 with a small cosmetic change to the code.


Writing readonly in variable in GLSL

When converting an HLSL shader that does something like this:
PSInput Main(VSInput input)
{
  input.Position.y = 0;
  ...
}

it is converted to glsl that looks something like this:
layout(location = 0) in vec4 Position;
...

void main()
{
  Position.y = 0.0;
}

The driver does not accept this because Position is readonly. To fix this I can simply change the hlsl to introduce a temporary local variable which is used further in the function (float3 tempPos = input.Position). However, I think this should be done by the cross compiler or it should be an error caught by the cross compiler.

Do you have the full source of the HLSL shader? This sounds like a glslang bug to me.

The example below modifies the x coordinate of the input. It generates invalid GLSL because it modifies the in variable Position.
HLSL:
cbuffer Camera
{
    float4x4 ViewProjection;
};

struct InVsSprite
{
    float4 Position : POSITION;
    float4 Color : COLOR0;
    float2 TexCoord : TEXCOORD0;
};

struct InPsSprite
{
    float4 Position : SV_POSITION;
    float4 Color : TEXCOORD0;
    float2 TexCoord : TEXCOORD1;
};

InPsSprite Main(InVsSprite input)
{
    InPsSprite result;
    input.Position.x += 1.0f;
    result.Position = mul(float4(input.Position.xyz, 1), ViewProjection);
    result.Color = input.Color;
    result.TexCoord = input.TexCoord;
    return result;
}

The generated GLSL (for version 4.1)
#version 410
#ifdef GL_ARB_shading_language_420pack
#extension GL_ARB_shading_language_420pack : require
#endif

struct InPsSprite
{
    vec4 Position;
    vec4 Color;
    vec2 TexCoord;
};

layout(binding = 0, std140) uniform Camera
{
    layout(row_major) mat4 ViewProjection;
} _27;

layout(location = 0) in vec4 Position;
layout(location = 1) in vec4 Color;
layout(location = 2) in vec2 TexCoord;
layout(location = 0) out vec4 Color_1;
layout(location = 1) out vec2 TexCoord_1;

void main()
{
    Position.x = (Position.x + 1.0);
    InPsSprite result;
    result.Position = (_27.ViewProjection * vec4(Position.xyz, 1.0));
    result.Color = Color;
    result.TexCoord = TexCoord;
    gl_Position = result.Position;
    Color_1 = result.Color;
    TexCoord_1 = result.TexCoord;
    gl_Position.z = 2.0 * gl_Position.z - gl_Position.w;
}

Note that the above HLSL works on Windows.

Hm, which glslang commit are you on and which command line arguments did you use?
I can't get valid SPIR-V for this HLSL file.
I'm on e19e68d4313617b8f and I get this validation error from spirv-val.
Function end cannot be called in blocks.
          %4 = OpFunction %2 None %3
          %5 = OpLabel
               OpFunctionEnd <-- This is wrong.

Similar error is found in spirv-cross and exception is thrown:
terminate called after throwing an instance of 'spirv_cross::CompilerError'
  what():  Cannot start a block before ending the current block.
zsh: abort (core dumped)  ./spirv-cross /tmp/test.spv

Strange .. When I run this:
glslangValidator -D -V -e Main hlsl.vert -o hlsl.spv
spirv-cross --version 410 hlsl.spv

With the hlsl as above it outputs the glsl as above.
glslang is at e19e68d4313617b8fe8bb68578d2de51507e603f
SPIRV-Cross is at 8199986c0e21af2c1a25d9e527bf51497ed43e7c
spirv-val also reports no error with the generate hlsl.spv.

Oh, you're using -e ... Ye, now I see what you mean.
This is indeed a glslang bug, SPIR-V spec says.
StorageClass:
1 Input
Input from pipeline. Visible across all
functions in the current invocation. Variables
declared with this storage class are read-only,
and cannot have initializers.

and the SPIR-V contains
         %13 = OpTypePointer Input %6

         %14 = OpAccessChain %13 %9 %12
         %15 = OpLoad %6 %14
         %16 = OpFAdd %6 %15 %10
         %17 = OpAccessChain %13 %9 %12
               OpStore %17 %16

The InVsSprite here is mapped to Input, so it tries to store to it. Not even spirv-val catches this it seems. I'll file some bugs for those tools instead.

Thanks, I'll track that. This can be closed then.


Create RefundList.cs

https://github.com/morpher-ru/Yandex.Checkout.V3/pull/57
https://github.com/morpher-ru/Yandex.Checkout.V3/pull/59

This PR doesn't seem to make much sense on its own. Can you provide a complete implementation of a feature in one PR?

please look into referenced pr https://github.com/morpher-ru/Yandex.Checkout.V3/pull/57
https://github.com/morpher-ru/Yandex.Checkout.V3/pull/59

Added missing files  waiting for nuget updated

GetRefunds() has been implemeted already. Sorry for front-running you.


Feature request: Set figure width (in LaTeX, at least)

As far as I can tell, it's hard-coded to \linewidth right now.

More support for this added in #64.


SARAALERT-888: Monitoring status refactor

Description
Jira Ticket: SARAALERT-888
Refactor of the MonitoringStatus component.  This includes:

Create a parent MonitoringActions component
Break out MonitoringStatus into separate components for each piece. If there are pieces that can use a general dropdown component, do so.
Clean up code, comment, reduce any duplication/confusion, etc.
Add frontend tests for all of these.
Two special cases regarding LDE section of the monitoring status modal (see JIRA)

Important Changes
Please list important files (meaning substantial or integral to the PR) along with a list of the general changes that should be highlighted for reviewers.
There are A LOT of changes here, so I'm going to break this down by each change and what files are effected by those changes

Created a parent Monitoring Actions component: MonitoringActions.js, show.html.erb

Broke each Monitoring Action into child components: AssignedUser.js, Jurisdiction.js, GenericAction.js

Simplified existing child components of Monitoring Actions: MonitoringStatus.js, CaseStatus.js

Only display the LDE update section in the Monitoring Status component IF the monitoree has a household member that is in the exposure workflow with continuous monitoring: MonitoringStatus.js, patients_controller.rb, show.html.erb

Updated the "this monitoree and all household members” option in the Monitoring Status to include "This monitoree and household members (this will turn OFF continuous exposure for all household members)" and hide the LDE section IF this option is selected: MonitoringActions.js

Updated @group_members and @all_group_members backend variables to be @dependents_exclude_hoh and @household_members respectively to be much more clear: patients_controller.rb, show.html.erb, edit.html.erb

Modified has_group_members props variable name to has_dependents for clarity: show.html.erb, edit.html.erb, new.html.erb, new_group_member.html.erb, MonitoringActions.js, AssignedUser.js, CaseStatus.js, GenericAction.js, Jurisdiction.js, MonitoringStatus.js, Enrollment.js, Exposure.js, PatientPage.js (dependents instead of has_dependents)

Modified in_a_group props variable name to is_household_member for clarity: show.html.erb, LastDateExposure.js

Added @household_members_with_ce_in_exposure variable to the backend to serve the very specific case of #4 above: MonitoringStatus.js, patients_controller.rb, show.html.erb

Changed name = jurisdictionId or assignedUser to id = jurisdiction_id or assigned_user to be consistent with the rest of the monitoring actions:  AssignedUser.js, Jurisdiction.js,  Exposure.js, PatientPage.js, PatientsTable.js plus the tests modified in #15

Removed unused code for isolation and pause notifications: MonitoringActions.js, MonitoringStatus.js, show.html.erb

Fixed datepicker styling: MonitoringStatus.js, ExtendedIsolation.js

Added react component tests for all new components: MonitoringActions.test.js, AssignedUser.test.js, GenericAction.test.js, Jurisdiction.test.js,  MonitoringStatus.test.js

Updated react component tests/mocks for clarity and additional use cases as well as fixed tests that broke from these changes: CaseStatus.test.js, PatientPage.test.js, MockPatients.js

Fix system tests that broke in the process of this refactor: jurisdictions_controller_test.rb, dashboard_verifier.rb, form_validator.rb, dashboard_verifier.rb, actions.rb, public_health_import_export_test.rb

Testing
This fix was tested on the following browsers (submitter must check all those that apply):

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] IE11

Please describe the tests needed to verify your changes. Provide instructions for reproducing these tests. List any relevant details for your test configuration.

@holmesie @kylietmo @timwongj @DPC15038 I was hoping to get as many eyes on this as possible before I start writing the tests.  Please review to make sure none of the functionality changed or is broken, as well as for additional improvements that should be made during this refactor.  This only includes the first two bullets listed above, but you'll see it's already pretty significant.
@timwongj - can you take a look at the failing tests as well?

This should be good for review now! @holmesie @kylietmo @timwongj @DPC15038

@sgober I noticed you removed the GenericAction test file, I think those tests were still valuable - can you salvage it and break it up for each new component that you broke the GenericAction component into?

@sgober I noticed you removed the GenericAction test file, I think those tests were still valuable - can you salvage it and break it up for each new component that you broke the GenericAction component into?

@kylietmo I saved it locally, just haven't had time to split it up yet.  will do that tomorrow

@kylietmo @DPC15038 I think I addressed all your comments now.  Also SARAALERT-948 is now included in this PR


[PROJECT] Support & Operations

As a member of the support team I want to fix issues for users

As a member of the engineering team I want to reduce the amount of time I spend supporting users

As an organisation we want to ensure we do not treat support as an excuse for excessive tech debt

Support tasks
Below are a selection of common support ops tasks:

#5771
#5651
#5374
#5000
#4848
#4841
#4805
#4714
#4684
#4648
#4627
#3981
#5935
#6272
#5946

to which I would like to add

#5907

It helps to have one issue that we can reference in conversation around sprints (and general direction/strategy) so I'm reopening this.

Adding a link to the support issue tracker https://github.com/orgs/opencollective/projects/5/views/30
and a link to the work from design to update the help/support page https://github.com/opencollective/opencollective/issues/4800

To summarise the conversation held on Friday, there are many problems that need to be addressed here. Some are process-driven and others are product driven.
I'm inclined to leave the process-driven work to @alinamanko when she takes on her new role, but for the moment I'll describe all the problems here as best I can:
Addressing the top of funnel

Lots of our user support requests are RTFMs

Last year we prioritised improvements to our help pages https://opencollective.com/help
We incorporated direct links to sections of our documentation. The design also incorporated a search which was discounted due to limitations with GitBook #5022. We'll take a look again at that and, if it continues to be a blocker, we may look at migrating our docs to a better provider.

[ ] look again at implementing docs search as designed #5022

I cannot go without saying that, as part of this workstream we must review our platform documentation in the round. Our docs are inconsistent and arguably platform-centric (that is, they concern features) rather than user centric (that is, they concern user's behaviour) and that might be worth reviewing. We may need to hire in someone as a consultant or full time member of staff to do this. I'll leave the decision to @alinamanko as someone heading up the support and ops in the near future.

[ ] review documentation at docs.opencollective.com

### Increasing the efficiency of the support team
Firstly, it is obvious that we are abusing Freshdesk as a catch-all for email that does not belong in a single-person's inbox. Invoices, contracts, vendor agreements and much worse are routed through our freshdesk and this causes added strain on the team. If we're going to scale our support capacity we need to streamline the information that's coming into it.

[ ] review emails routed to FreshDesk and remove all non-support notices

secondly it's not obvious how tickets are routed, and who's responsibility support is. Much of the support that's routed to @poohlaga is based on an understandably quick triage process based on the user, the collective and who their host is. We should make it patently clear when we expect the host to pick up a support request, and when it's the responsibility of the platform provider.

[ ] establish platform support policy for hosts

@shannondwray is currently triaging tickets in Freshdesk, adding the users profile and other information before assigning it to someone else in the team (see this workflow). We previously looked at attaching pertinent information (username, profile link, collective they're a member of, most recent transaction etc) to a support request #5023. We'll look again at this from a product perspective.

[ ] look again at #5023 and decide on information that would be useful to accompany a freshdesk ticket automatically

Finally the development support for ops and user support is limited to @SudharakaP. It's obvious from speaking that Suds has very little time for prospective (as opposed to reactive) work in this area. It's important that we allow time for Suds to work on automating the tasks that he frequently, manually, addresses such as resetting a users access. Thsi may require the rest of the team offloading some support elsewhere. Finally @SudharakaP and I will review the outstanding support issues in GitHub and prioritise based on where he would free the most of his time

[ ] review support issues with @SudharakaP and prioritise based on time dedicated at the moment.

From my knowledge Alina is taking a step back from Support and this is an area I’ve been asked to step up in and take some ownership rather than following Alinas lead.

@carolineawoolard and I have gone into depths surrounding my role and part of this is handing off Documentation to someone who is more skilled, has more capacity. We would need to touch base with Caroline to see what the timeline looks like for this and what I can do to prepare for the new Documentation person.

Here is the Docs issue about finding a new documentation provider: https://github.com/opencollective/opencollective/issues/2595
I am going to visualise out all of the automations that happen through freshdesk so we can see what is coming through freshdesk and where it is being sent etc
I will also try and create a clear distinction between what is platform support and what is host support - putting things in the middle so we can clearer ensure we debate and clearer define the scope

Thanks @shannondwray and apologies if I got that wrong. @carolineawoolard and I are already picking up the discussion on hiring someone to dig into docs.

So @SudharakaP and I went through the support and ops section of the project board https://github.com/orgs/opencollective/projects/5/views/30 and removed anything that's not a support engineer scale.
We prioritised issues that will reduce the burden on @SudharakaP's time for the moment, namely:

#5771
#5651
#4714

These are our immediate focus. Issues that are 'support and operations' but not a support engineer scale (that is, can be worked by @SudharakaP alone) are moved to the 'support and operations product area for prioritisation.
FYI @shannondwray: for the moment I have also asked that @SudharakaP take a selfish approach to handling tickets rejecting anything that can be done without direct database access.

Amazing!! Please send things back my way so I can ensure I know how to do them and can reflect this in the support how to/visualisation flow

From my knowledge Alina is taking a step back from Support and this is an area I’ve been asked to step up in and take some ownership rather than following Alinas lead.

@shannondwray you are correct that she is taking a step back from frontline support but she will be taking a higher level view in terms of support processes and technical improvements.
This means:

working in categorizing the type of support that is platform related to the one that should be sent to the host,
looking into technical improvements such as a support chat or AI service to filter incoming support tickets,
working with engineering to use freshdesk's API to connect to platform.
mentoring support / ops people from the different host.

You will be working together with Alina in this tasks I believe - @carolineawoolard please add here if you have any additional comments.

@BenJam thank you so much for this summary and apologies for missing the capacity to join the conversation in person.
Just to add to what @shannondwray commented and to offer an extension to what @piamancini said and what I commented during our support ops meeting the other day. I will be indeed focusing more on the support and ops aspects from the platform perspective and working with the frontline support to improve the functionality we are now starting to focus more now with the incredible work the support focused team is already doing.
My stepping back in an immediate term is due to some personal circumstances and the need to regroup in the hope of returning with much more capacity to give when I move to the new role in March.

[ ] some comments to resolve on https://github.com/opencollective/opencollective-api/pull/8470

@shannondwray @natehn could we run through the list above and update our current position on improvements for support and operations before the end o the year?

Hello! We are reviewing all of the outstanding issues and will put forward a proposal from the Support team based on our prioritization


Give users advice what to do when immutable workspace allocation fails

Followup after https://github.com/gradle/gradle/pull/26970.
When an immutable workspace cannot be allocated, or when it gets tampered with, currently we only throw an ImmutableStateException with some minimal information about the nature of the problem. Instead, we should use the Problems API to give the user more context and some advice about what to do in such a situation.

cc: @gradle/bt-execution

Currently we say Workspace has been changed: .... We should add some context, like this is a global immutable workspace (cache?) and that it should not be modified after it was populated by the original unit of work executed here.

Fixed as part of https://github.com/gradle/gradle/pull/27851.


Wrong language

Terminal appears in the wrong language.
In a default Dutch language Terminal appears in German. German is not Dutch.
However as I'm in Switzerland it might be that Terminal is using the wrong language settings.
I know internationalisation is difficult. But if you cannot solve this at least let the user select the language.

https://stackoverflow.com/a/27642206/718960

I don't think the Terminal is translated into Dutch. We're tracking additional languages in https://github.com/microsoft/terminal/issues/10667. Thanks!


Display an icon with sync state

Motivation
As of right now, the user does not know when the notes are synced or not. Having an indicator will allow the user to know if his notes are sync and can exit the tab safely.
Description
Display an icon when notes are not synced and vice versa.

Technically, the sync icon will become a loading icon already during syncing, but it happens to fast to see since it's not hooked up with an API yet. Putting the date of "last synced" somewhere would be helpful.


Sync kibana_system password with AWS secretsmanager secret.

The secret it read from AWS secret stored in the puppet fact $facts['elasticsearch']['kibana_system_secret'].

The password needs to be set only after the data nodes are provisioned.


Prefix the bazel rules of app_image to allow specifying multiple apps inside the same directory

What this PR does / why we need it:
This PR helps to deal with the problem from  https://github.com/pipe-cd/pipe/pull/1959 in an easier way.
Don't have to create a new cmd directory.
So you can add something like this into the same cmd/piped directory.
app_image(
    name = "piped_okd_app",
    base = "@piped-base-okd//image",
    binary = "//cmd/piped:piped",
    repository = "piped-okd",
    visibility = ["//visibility:public"],
)

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

that's what I was seeking out

/lgtm

Nice 👍
/approve


🌱 remove kubesec workflow

Kubesec action has not been maintained for years and is broken. Kubesec itself is maintained, and we'll see if we reintroduce it as prow test instead of action later, or if we have enough coverage from existing tools.

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

/lgtm

/approve


update download and lock ava version

Had to lock down ava version due to breaking changes to see the tests pass.

Ok, I realize this require Node >= 4.0.0 so maybe not mergable :(

Fixed in sindresorhus/got#193.
Thanks for the PR anyway, @hedefalk.


ninja: build stopped: subcommand failed.

Same issue as this: ubprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

same problem

I know the reason, it is the problem of cuda version. I originally thought my cuda version was 11.3, but I found it was 10.1 after nvcc-V. After correcting it, this error will not be reported

I tried changing ['ninja', '-v'] to ['ninja', '--version'] in lib/python3.10/site-packages/torch/utils/cpp_extension.py but I had another exception:
File "/home/.../lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1847, in _import_module_from_library
module = importlib.util.module_from_spec(spec)
ImportError: /home/.../.cache/torch_extensions/py310_cu113/fused/fused.so: cannot open shared object file: No such file or directory
And i cannot solvet it yet


make:model with -a doesn't generate directory structure correctly?

Laravel Version: 8.48.1
PHP Version: 7.4.20
Database Driver & Version: MySQL 8.0.25

Description:
Bug or needs improvement when make:model with -a parameter?
Steps To Reproduce:
Who will explain to me where is the logic?
First
a)
$ php artisan make:model Blog/Category -r
Model created successfully.
Controller created successfully.

I am getting the following files:
Models/Blog/Category.php                    // It's ok!
app/Http/Controllers/CategoryController.php // It's not ok!

In case php artisan make:model Blog/Category -r and if I need create php artisan make:model Shop/Category -r I will get the error: Controller already exists! The model will be created correctly Models/Shop/Category.php
I would like to see Http/Controllers/Blog/CategoryController.php and Http/Controllers/Shop/CategoryController.php
b)
$ php artisan make:controller Blog/Category -r
Controller created successfully.

I am getting the following:
Http/Controllers/Blog/Category.php

I would like to see Http/Controllers/Blog/CategoryController.php
Do we need a suffix  Controller or not if I using make:controller?
To get a suffix - you need to write it explicitly php artisan make:controller Blog/CategoryController -r
Second
The same situation will be with migrations.
$ php artisan make:model Blog/Category -m
Model created successfully.
Created Migration: 2021_06_25_040809_create_categories_table

I would like to see 2021_06_25_040809_create_blog_categories_table
$ php artisan make:model Shop/Category -m
Model created successfully.

InvalidArgumentException
A CreateCategoriesTable class already exists.

If we use two parameters -rm at once, then we will not even get to the error with migrations due to a controller error.
Third
It turns out in this case we can't create controllers and migrations -rm. Let's try a flag -f for the factory, everything is logical here.
$ php artisan make:model Blog/Category -f
Model created successfully.
Factory created successfully.

$ php artisan make:model Shop/Category -f
Model created successfully.
Factory created successfully.

database/factories/Blog/CategoryFactory.php  // It's ok!
database/factories/Shop/CategoryFactory.php  // It's ok!

Fourth
Let's try seeder and getting a warning
$ php artisan make:model Blog/Category -s
Model created successfully.
Seeder created successfully.

$ php artisan make:model Shop/Category -s
Model created successfully.
Seeder already exists!

I am getting the following:
database/seeders/CategorySeeder.php

I would like to see something like this database/seeders/Blog/CategorySeeder.php
Further more interesting:
$ php artisan make:seeder Blog/Category
Seeder created successfully.

$ php artisan make:seeder Shop/Category
Seeder created successfully.

I am getting the following:
database/seeders/Blog/Category.php
database/seeders/Shop/Category.php

But there is generally strange behavior:
<?php

namespace Database\Seeders;

use Illuminate\Database\Seeder;

class Blog/Category extends Seeder
{
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        //
    }
}

If you create via make: seeder, it is fine, but as in the case with the controller, you need to add the suffix Seeder
$ php artisan make:seeder BlogCategory
Seeder created successfully.

$ php artisan make:seeder BlogCategorySeeder
Seeder created successfully.

database/seeders/BlogCategory.php
database/seeders/BlogCategorySeeder.php

What do we have for such a case?
I need to do this can be done manually in this order:
$ php artisan make:model Blog/Category -f
Model created successfully.
Factory created successfully.

$ php artisan make:model Shop/Category -f
Model created successfully.
Factory created successfully.

$ php artisan make:seeder BlogCategorySeeder
Seeder created successfully.

$ php artisan make:seeder ShopCategorySeeder
Seeder created successfully.

$ php artisan make:migration CreateBlogCategoriesTable
Created Migration: 2021_06_25_043557_create_blog_categories_table

$ php artisan make:migration CreateShopCategoriesTable
Created Migration: 2021_06_25_043606_create_shop_categories_table

$ php artisan make:controller Blog/Category -r --model=Blog/Category
Controller created successfully.

$ php artisan make:controller Shop/Category -r --model=Shop/Category
Controller created successfully.

Total
I think it would be logical to create directories for the namespace when creating
php artisan make:model Blog/Category -a

and get something like this structure
Model created successfully:      app/Models/Blog/Category.php
Factory created successfully:    database/factories/Blog/CategoryFactory.php
Created Migration:               2021_06_25_055915_create_blog_categories_table (!)
Seeder created successfully:     database/seeders/BlogCategorySeeder.php (!)
                                 or database/seeders/Blog/CategorySeeder.php
Controller created successfully: app/Http/Controllers/Blog/CategoryController.php (!)

And added to the model property protected $table = 'blog_categories;
There will be more than one controller in the Shop or Blog directory - this would better separate the structure and tables with prefix shop_ or blog_

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

I don't know where to suggest an improvement. This is either a mistake or a flaw.
What I wanted from php artisan make: model Blog/Category -a is detailed here.
You can do it step by step in another way, but what's the point in the make:model command with the -а parameter if it does not work quite correctly?
Maybe you should pay attention to this and fix/modify it in the next versions of Laravel?

I have the same problem and think this worked in older laravel versions (8.x).
I also think this is a bug, because in my eyes the behaviour in the namespace resolution of
make:model Blog/Category -a
should be the same as
make:controller Blog/Category
which is not the case.


Master

Jenkinsfile master

@akshaygirpunje Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Thanks but we’re using concourse as a CI for this application. See https://ci.spring.io/teams/sagan/pipelines/sagan and the concourse folder in the repository.


Initialize tests, modify some stuffs

Changed log

To support the python3 version at least, using the print(...) function.
Split the hackertarget_api from hackertarget.py file.
Add the hackertarget_api test.
raw_input function is undefined in python-3.x versions. Using the input function instead.
Using the mock tests because we don't need to test the external API service.
We can assume that external API service is expected successfully.

You keep doing good things. Thanks for the everything !