[WIP] i18n(fr): Add French tutorial

What kind of changes does this PR include?

Translated content

Description
Tutorial translation to French.

Arrrg I approved, but this is a mistake, only comment and to be notified of any changes. 😶

Thanks for the reviews @sdp971 & @thomasbnt, this is a "collection" PR that merges other folks translations, I particularly don't spreak French so I can't really discuss or know if what you proposed is appropriate, could you make a separate PR making these specific changes to this branch and then I can merge them here?

Thanks for the reviews @sdp971 & @thomasbnt, this is a "collection" PR that merges other folks translations, I particularly don't spreak French so I can't really discuss or know if what you proposed is appropriate, could you make a separate PR making these specific changes to this branch and then I can merge them here?

Hi @Yan-Thomas, ok I'll make the PR tonight. I might need some guidance during the process.

Hi @Yan-Thomas, ok I'll make the PR tonight. I might need some guidance during the process.

Hello! Thanks @sdp971 !

Hi @Yan-Thomas, ok I'll make the PR tonight. I might need some guidance during the process.

Hello! Thanks @sdp971 !

You're welcome 🙂

Thanks for the reviews @sdp971 & @thomasbnt, this is a "collection" PR that merges other folks translations, I particularly don't spreak French so I can't really discuss or know if what you proposed is appropriate, could you make a separate PR making these specific changes to this branch and then I can merge them here?

@Yan-Thomas it's done  here. Hope it's fine.

What is the status of this PR ?

What is the status of this PR ?

This PR is just to allow people to see a deploy preview of the translation as it is translated in other, individual, PRs tackling certain pages of it. Some people have been translating the pages with time, so it is being actively maintained.

I sure did mistake haha, thank's for the help on the translation !

Hello! Seems an old MR since https://github.com/withastro/docs/pull/4688 was created for tutorial part.

Yes, it appears that the other PR is the complete one! We will review it for merging this week! :rocket:

Just closing this PR in favour of the full French tutorial being merged in the other PR! :partying_face:


require impl generic parameters be constrained by the trait def

Rust prohibits type parameters in a trait impl that don't appear in the trait definition:
impl<T> Iterator for () { type Item = (); } // ERROR

and unconstrained lifetime parameters that appear in a trait value
impl<'a> Iterator for () { type Item = &'a (); } // ERROR

We need to extend the rules to cover these. Careful, though, some uses of a generic parameter don't count as constrained:
impl<T> Iterator for <T as Iterator>::Item { type Item = (); } // also an ERROR

Probably we want some kind of "well-formed decls" check analogous to well-formed-mir? It could also check that e.g. all TraitId are defined somewhere (which current results in assertion failures).

In other words, I would just define these rules using redex type judgments, not try to make logical predicates.


Change problem/error underlines?

Is it possible to change the red sguiggles used for problems/errors to a straight line and different color?
Can't seem to find a setting for it.

That would be a really good feature. For color blind people the red underline is really hard to see.

https://github.com/Microsoft/vscode/issues/9819


Why is mimalloc-redirect closed-source?

While searching the definition of MIMALLOC_DISABLE_REDIRECT, I realized this part of the project isn't open-sourced and resides just in the form of a binary in bin/ dir, why is that?
I reverse engineered the file and found out PDB path at C:\Users\daan\dev\mimalloc-redirect\out\msvc-x64\Release\mimalloc-redirect.pdb which points at @daanx being its author. Could you please possibly open source its code? The reason is that I want to analyze how it performs the hooks and which functions it exactly hooks (even though I can mostly see it form decompilation). And again the reason for that is that some binaries out there are compiled with static CRT, I want to find out if it's viable to reverse engineer them to find the same functions and hook them up manually to mimalloc...
Having that part closed-source also prevents users from doing any kind of customization there...

Seconded, I'm tired of microsoft's closed source nonsense


Refactor - NodePublishVolume will do the mount instead of NodeStage

Suggestion for moving the mount operation from the nodestage to the nodepublishvolume.

nodestage will do the discovery and also mkfs (and testing mount to nodestage, but after testing it will unmount it).
nodestage creates the nodeinfo file to the stagingTarget directory (which is not mounted!).
Nodepublish volume will get the dm device from the nodestage info file (on the stagingPath) and will mount it to the targetPath(the final path of the pod)
Nodeunpublishvolume will do the same as before, just unmount the targetPath.
nodeunstage will read the stage info file and then delete the dm devices and the sdX devices. (no need to unmount the stagingPath because its never mounted to the staging path with this proposal)

Pros:

stageinfo file stored on the node filesystem and not inside the PV mount point. So we don't mass with customer volume data and that way we can also support RO mount (because the staging info file is not storing on the PV it self).
Only one mount point on the host, which is simpler.
Less idempotancy issues because nodeunstage node will delete the stage info file at the end of the nodeunstage method (without risking of loosing this info file).

Cons:

Added mount for checking inside the nodestage because i wanted to use k8s mounter tool FormatAndMount, so after success we unmount it.

This change is

node/pkg/driver/node.go, line 167 at r1 (raw file):

	}

	err = d.mounter.FormatAndMount(device, stagingPath, fsType, nil) // TODO: pass mount options

Are you resilient to a previous error in this new way? If you try to mount and it is already mounted? (could happen if the function failed between the "mount test" and "unmount".

node/pkg/driver/node.go, line 176 at r1 (raw file):

	if err != nil {
		return nil, status.Errorf(codes.Internal, "Could not unmount target %q: %v during NodeStage mount check.", stagingPath, err)
	}

Consider to put the "preparation phase" (makedir, mkfs, mount) in a separate function.

node/pkg/driver/node.go, line 361 at r1 (raw file):

	mountList, err := d.mounter.List()
	for _, mount := range mountList {
		klog.V(5).Infof("mount device : {%v}, path : {%v} is equel to targetPath {%s}", mount.Device, mount.Path, targetPath)

The info message is misleading, you mean that you are checking if mount device is equal to target path.

node/pkg/driver/node.go, line 361 at r1 (raw file):
Previously, ranhrl (Ran Harel) wrote…
The info message is misleading, you mean that you are checking if mount device is equal to target path.

Means that you should write to the log: Checking if target path is already mounted on mount point.

node/pkg/driver/node.go, line 369 at r1 (raw file):

	}

	// Read staging info file in order to find the mpath device for mounting.

"reading from file", consider to log it instead of comment it


Tweak ResponseObject to let bucket.delete_keys work with s3bucket_path.

Add ResponseObject.is_delete_keys, so _bucket_response_post also recognize delete_keys response with s3bucket_path: The response path is /bucket/?delete, not /?delete.

Awesome, thank you!


Warps outside of loaded area

23.06 22:04:44 [Server] Server thread/EMERGENCY Please upload the "/CrashDump_Tue_Jun_23-22.04.44-CDT_2015.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.
23.06 22:04:44 [Server] Server thread/EMERGENCY An unrecoverable error has occurred and the server has crashed. Creating a crash dump
23.06 22:04:44 [Server] INFO Fatal error: Call to a member function saveAll() on null in phar:///plugins/SimpleWarp_v2.phar/src/falkirks/simplewarp/SimpleWarp.php on line 41
23.06 22:04:44 [Server] Server thread/INFO Disabling SimpleWarp v2
23.06 22:04:44 [Server] Server thread/NOTICE ArrayOutOfBoundsException: "Undefined index: address" (E_NOTICE) in "/SimpleWarp_v2.phar/src/falkirks/simplewarp/WarpManager" at line 173
23.06 22:04:44 [Server] Server thread/CRITICAL A warp with the name week2a is attached to a level which isn't loaded. It will be removed automatically when your server stops.
23.06 22:04:44 [Server] Server thread/INFO Enabling SimpleWarp v2
23.06 22:04:44 [Server] Server thread/INFO Loading...

Try with the v2.0.1

28.06 13:29:22 [Server] Server thread/EMERGENCY Please upload the "/CrashDump_Sun_Jun_28-13.29.22-CDT_2015.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.
28.06 13:29:22 [Server] Server thread/EMERGENCY An unrecoverable error has occurred and the server has crashed. Creating a crash dump
28.06 13:29:22 [Server] INFO Fatal error: Call to a member function getName() on null in phar:///plugins/SimpleWarp_v2.0.1.phar/src/falkirks/simplewarp/Destination.php on line 102

Your trying to view a warp to a level which isn't loaded. This is a new bug see #7


Customize registration params

The revise_auth:model generator allows you to add additional attributes to the User model. However, if you want to change your sign up form or profile form, those additional attributes are not permitted. To allow this, we need to allow customizing the registration params (sign_up_params and profile_params). I followed the same idea as the after_login_path. Also added some tests as the registration controller had none.

I never really liked adding methods to ApplicationController that are only used in the registrations controller.
Another option could be doing this in an initializer?
ReviseAuth.configure do |config|
  config.sign_up_params += [:first_name, :last_name]
  config.update_params += [:first_name, :last_name]


Bad SSL certificate on https://ciscobinary.openh264.org

ciscobinary.openh264.org uses an invalid security certificate.
The certificate is only valid for the following names:
*.akamaihd.net , *.akamaihd-staging.net , a248.e.akamai.net
(Error code: ssl_error_bad_cert_domain)

Please re-evaluate this decision. People might not do this out of laziness / ignorance (count me in!). Making sure they at least have something from the owner of openh264.org might prevent a lot of harm.
Checking the checksum is definitely needed for true safety, but why not make the worst case a little less worse?

By the way, where can I find the fingerprint Mozilla uses?

@dminor do you know if we store the current fingerprints in tree somewhere?

I'll reopen for discution

These should be the current fingerprints: https://searchfox.org/mozilla-central/source/toolkit/content/gmp-sources/openh264.json. However, that file is only used as a fallback when we can't reach the normal update server. The update server sends Firefox a url and a fingerprint to use. The intention is to make it easy to roll out updates to a portion of the population, but obviously does not make it easy to trace what is being downloaded. @Callek would know more about that side of things.

Ok, so the issue in https://github.com/cisco/openh264/issues/909#issue-34658985 looks like its a cert issue on the domain itself...

I'm not sure what https://github.com/cisco/openh264/issues/909#issuecomment-500594569 is asking specifically, though Mozilla is downloading the binaries from http://ciscobinary.openh264.org/ and not https://... so we don't encounter the certificate issue. We do however have code that validates that our update service is the correct service (via cert) and that the urls it sends over are validated once downloaded with a sha512 algorithm, so we never invoke untrusted code (even if a MITM struck and gave the user unexpected content)
Finally we codesign the binaries on windows, and gpg sign on linux (note the gpg sig is harder to verify since we don't expose this anywhere officially, nor is it fully guaranteed to exist in the future) e.g. http://ciscobinary.openh264.org/openh264-linux64-2e1774ab6dc6c43debb0b5b628bdf122a391d521.zip.asc
So I think this issue comes down to @fluffy and Cisco in general for if they want the ciscobinary.openh264.org to have a valid https cert.

Can this issue be revisited?  The FreeDektop sdk used in flatpak app packages downloads from this URL, so this is a potential security issue for anyone using flatpak.

This is not just potential but real security vulnerability. The GPG that was there seems to be gone. Cisco binaries are at this point not safe to use without locally reproducing same binary so you can collect sha256.

Hi @fluffy, could somebody from Cisco help fix this please?
There are two related issues above that can be closed as duplicates.

HTTPS is not supported for this. We think a better approach is to check the fingerprint of the downloaded files.

@fluffy then can you please start providing strong hashes for the files from GitHub releases? Download server only has weak hashes which are useless by modern standards and they are untrusted since you are not supporting TLS or providing GPG scheme.

@fluffy Is there a secure way to get the fingerprints?

Mozilla is the group that is securely publishing the hashes. They actually compile the code to.  I'me feeling guilty I can not point you at the exactly location.
Even if we did move to https from github, the whole process by which the executables get to github is not very secure thus the realiance on the hashes.

Few places Mozilla takes on stuff for this plugin [context I used to be a release engineer there, and one of the primary people responsible for delivering this]
https://searchfox.org/mozilla-central/source/taskcluster/ci/openh264-plugin/kind.yml
https://searchfox.org/mozilla-central/source/taskcluster/ci/openh264-signing/kind.yml
https://searchfox.org/mozilla-central/source/testing/mozharness/configs/openh264
https://searchfox.org/mozilla-central/source/testing/mozharness/scripts/openh264_build.py
Some more results:
https://searchfox.org/mozilla-central/search?q=openh264&path=openh264&case=false&regexp=false
But yes, Mozilla builds them for Cisco [at least used to, but I think still does] and then Cisco published the binaries on their own server.  Mozilla publishes update information to point Firefox at the binaries and at the related file hashes, this update information is protected much the same way actual Firefox updates are protected.

Let's also post instructions for how to verify the hashes somewhere prominent (like the toplevel README.md).

And probably also instructions explaining that ciscobinary.openh264.org is not intended to be accessed via HTTPS.
And close #3662

Hi, I'm a current engineer on Mozilla's Release Engineering team (hi @Callek!), and I just want to clarify one point.

I'm not super familiar with the Mozilla codebase or infrastructure, so I could be wrong about this, but it appears like this is the script that is being used to generate the hashes for the openh264 plugn: https://searchfox.org/mozilla-central/source/dom/media/tools/generateGmpJson.py

That script may be used to generate the in tree hashes (I'm not sure - I'm checking with the folks that update them), but it is definitely not used to generate the hashes served by our update server. Those are generated by hand by Release Engineers, who pull the builds securely from our CI system.

Unfortunately, I can't find any CI tasks in Mozilla-Central that invoke generateGmpJson or that upload the artifacts to Cisco, so I can't tell whether the script is being used securely or not (or at all). The fact that the insecure behavior is the default one reduces my confidence.

As @Callek alluded to in an earlier comment - we do not use that script as part of builds, signing, or update publishing. Most of the build task is described in stanzas like this, which uses mozharness/scripts/openh264_build.py to make the builds, and pulls the source via https from a pinned revision in a github repository.
My belief is that the checked in hashes may be used in the update server cannot be contacted - but I'm still working to confirm that. If they are, we obviously need to do better here.

@bhearsum okay, so what is the right way to discover the hashes? It doesn't seem like it can be https://searchfox.org/mozilla-central/source/toolkit/content/gmp-sources/openh264.json as it is about OpenH264 <IP_ADDRESS> which is at this point ancient. https://aus5.mozilla.org/update/3/GMP/120.0/20200518093924/WINNT_x86_64-msvc-x64/en-US/release/Windows_NT <IP_ADDRESS>.18363.1016 (x64)/default/default/update.xml does indeed point to more modern release (2.3.2) but not latest either (2.4.0).

@bhearsum okay, so what is the right way to discover the hashes? It doesn't seem like it can be https://searchfox.org/mozilla-central/source/toolkit/content/gmp-sources/openh264.json as it is about OpenH264 <IP_ADDRESS> which is at this point ancient. https://aus5.mozilla.org/update/3/GMP/120.0/20200518093924/WINNT_x86_64-msvc-x64/en-US/release/Windows_NT <IP_ADDRESS>.18363.1016 (x64)/default/default/update.xml does indeed point to more modern release (2.3.2) but not latest either (2.4.0).

As far as I know, we're still only pointing Firefox users at 2.3.2. You can find the complete list of hashes for all platforms in https://aus-api.mozilla.org/api/v1/releases/OpenH264-2.3.2. (And you can find out the latest OpenH264 that we're shipping via the mapping field on https://aus-api.mozilla.org/api/v1/rules/17820.)

@bhearsum okay, so what is the right way to discover the hashes? It doesn't seem like it can be https://searchfox.org/mozilla-central/source/toolkit/content/gmp-sources/openh264.json as it is about OpenH264 <IP_ADDRESS> which is at this point ancient. https://aus5.mozilla.org/update/3/GMP/120.0/20200518093924/WINNT_x86_64-msvc-x64/en-US/release/Windows_NT <IP_ADDRESS>.18363.1016 (x64)/default/default/update.xml does indeed point to more modern release (2.3.2) but not latest either (2.4.0).

As far as I know, we're still only pointing Firefox users at 2.3.2. You can find the complete list of hashes for all platforms in https://aus-api.mozilla.org/api/v1/releases/OpenH264-2.3.2. (And you can find out the latest OpenH264 that we're shipping via the mapping field on https://aus-api.mozilla.org/api/v1/rules/17820.)

Also https://bugzilla.mozilla.org/show_bug.cgi?id=1619988 tracks the 2.4 rollout for Firefox

@mcatanzaro okay. So I would say flatpak updates should be using ^ to get the hashes. If it's not present there (like 2.4.0), then we should wait. @bhearsum is there an API call to get latest version?

@mcatanzaro okay. So I would say flatpak updates should be using ^ to get the hashes. If it's not present there (like 2.4.0), then we should wait.

I would rather ship the latest release and rely on trust-on-first-use, even though it's not very secure. We shouldn't have to wait for Firefox to adopt the new version before we can update.

I'd really like to see the GitHub releases fixed. E.g. https://github.com/cisco/openh264/releases/tag/v2.4.0 says "All the binaries have been digitally signed" but in fact they are just MD5 hashes, not digital signatures, and any man-in-the-middle attacker who can change the binaries can also just as easily change the hashes. And even if the hashes were delivered securely, MD5 hasn't been safe for nearly 20 years now.

The thing is though that as we have learned, Mozilla runs the show with OpenH264 (after tags). They are the only party you can trust for ensuring your browser users are not MITM'able. If their metadata system doesn't contain the build, then we should consider it not formally released.

Well you're not wrong, but this is really unfortunate. The Mozilla APIs are designed to be used by computers, not by humans.

I'd really like to see the GitHub releases fixed. E.g. https://github.com/cisco/openh264/releases/tag/v2.4.0 says "All the binaries have been digitally signed" but in fact they are just MD5 hashes, not digital signatures, and any man-in-the-middle attacker who can change the binaries can also just as easily change the hashes. And even if the hashes were delivered securely, MD5 hasn't been safe for nearly 20 years now.

Well, yes, that is true. It would be totally awesome if Mozilla could ship GPG signatures next to every file delivered to Cisco so we could simply trust those to prove the files originate from Mozilla. But this is something to request from Mozilla, not Cisco.

@mcatanzaro okay. So I would say flatpak updates should be using ^ to get the hashes. If it's not present there (like 2.4.0), then we should wait. @bhearsum is there an API call to get latest version?

Our update server does not contain the data yet, and won't until we've been asked to get it ready for testing. (I have no idea when this will happen...I'm not even sure if we've produced 2.4.0 builds yet in fact...

Well, yes, that is true. It would be totally awesome if Mozilla could ship GPG signatures next to every file delivered to Cisco so we could simply trust those to prove the files originate from Mozilla. (this would potentially also increase security with the handover) But this is something to request from Mozilla, not Cisco.

Please feel free to file a bug for this over in https://bugzilla.mozilla.org/enter_bug.cgi?product=Release+Engineering&component=General. I can't make any promises, but at the very least it's good to have such things on file.

@bhearsum I think you have and they have been handed over to Cisco. They are just missing from metadata service. See https://gitlab.com/freedesktop-sdk/openh264-extension/-/merge_requests/46/diffs

I think it's probably fine @mcatanzaro integrates them before they land in Firefox QA as they are handling them being tested in the context of another browser. As long as we can prove to users these are authentic Mozilla binaries.

@bhearsum can you confirm whether the binaries linked to on Cisco's github releases page were built by Mozilla?  The URLs on that page are not the same as the ones on aus-api.mozilla.org/api/v1/releases/OpenH264-x.x.x
For example, let's compare the 2.3.1 binaries, since 2.3.2 doesn't appear on the github releases page and 2.4.0 isn't on aus, but 2.3.1 exists in both places...
on https://aus-api.mozilla.org/api/v1/releases/OpenH264-2.3.1 we see the following:
"Linux_x86_64-gcc3": {
                    "fileUrl": "http://ciscobinary.openh264.org/openh264-linux64-0a48f4d2e9be2abb4fb01b4c3be83cf44ce91a6e.zip",
                    ...
                }

And on https://github.com/cisco/openh264/releases/tag/v2.3.1 we have:
http://ciscobinary.openh264.org/libopenh264-2.3.1-linux64.7.so.bz2
To check this isn't simply a case of renaming and recompressing, I decompressed both archives and hashed the .so files.  The two produce different results:
flossposse@flossposse:~/Downloads/openh264$ sha512sum libopenh264-2.3.1-linux64.7.so
cbeb89f41db289deccbfa5a3d448ea978490bc22e40cc0e23069594578f4dd886fe6b95c6bf905c7745ba95e31fae6c13fd354e50dee87e033512bc49d3dc3e4  libopenh264-2.3.1-linux64.7.so
flossposse@flossposse:~/Downloads/openh264$ sha512sum libgmpopenh264.so
9d1defc632ceb6dca5997a623f682673d75c6541ab4309f4464ab2213c6cce50fddd95088d510a151e123705057c351774ed344517e92e43dab7de777fdfc56c  libgmpopenh264.so

@bhearsum If the `.bz2` files that show up on the github release page _are_ in fact built by Mozilla, could you point us toward a source for hashes?

@bhearsum can you confirm whether the binaries linked to on Cisco's github releases page were built by Mozilla? The URLs on that page are not the same as the ones on aus-api.mozilla.org/api/v1/releases/OpenH264-x.x.x

I have no knowledge on what happens with our builds after we hand them off to Cisco, but based on a comparison of the files from https://aus-api.mozilla.org/api/v1/releases/OpenH264-2.3.1, and the 2.3.1 release on https://github.com/cisco/openh264/releases, it certainly does not seem like they upload what Mozilla builds.
The only place I can point you for hashes for the builds we produce are the aforementioned links like https://aus-api.mozilla.org/api/v1/releases/OpenH264-2.3.1.

Okay, then what fluffy said is clearly bogus and this issue should be open.

I think the issue is a little two fold: for Mozilla this isn't really a big issue as they simply know the hashes of the binaries they build and bake them either into Firefox or put them on secured/trustworthy server for Firefox to download from.
But for everybody else who hasn't build the binary them self it's a little bit more tricky.

@nils-ohlmeier no, the problem is Cisco says Mozilla builds the binaries but binaries differ from what Mozilla builds.

So for avoidance of doubt, fluffy seems to be mistaken with regards to the release process. The binary releases appear to most likely be built by Cisco, not by Mozilla. Certainly there doesn't appear to be any known way to download hashes for them from Mozilla.

@mcatanzaro @bhearsum provided the URL for downloading the hashes which Mozilla uses. It is https://aus-api.mozilla.org/api/v1/releases/OpenH264-2.3.2 (and that is a HTTPS URL and the hashes are using modern, stronger hash algorithms).
Now Mozilla isn't always using the latest version of OpenH264. That is a completely different problem.
I don't know who build the 2.4.0 binaries. Maybe the more secure solution would be then for Cisco to not publish any binaries, until Mozilla builds them and provides them to Cisco?
@bhearsum I'm pretty sure from when I used to work on this that Bryce told me that the build in hashes in Firefox are only used if the update services are not reachable. So who ever did OpenH264 updates recently forgot to update these internal hashes (which if I remember it correctly is a pretty common issue).

Even for older releases like 2.3.1 Cisco doesn't present those mozilla builds anywhere but only shows their own. The binary difference as checked with diffoscope is massive.
Is the recommendation to use those mozilla builds instead of ones listed at https://github.com/cisco/openh264/releases ? The filename doesn't match so everyone would need to rename them. Does this comply with Cisco binary license?

Even for older releases like 2.3.1 Cisco doesn't present those mozilla builds anywhere but only shows their own. The binary difference as checked with diffoscope is massive.
Is the recommendation to use those mozilla builds instead of ones listed in openh264 github release page? Does this comply with Cisco binary license?

(We are now pretty confident that the binaries produced by Mozilla for Firefox simply do not correspond to the binaries released by Cisco.)

I guess who's binaries you trust more depends on your individual perspective. The Mozilla binaries do have better hashes which can be fetched from an HTTPS URL.
My personal guess is that Cisco in general pays the MPEG royalties for all it's encoders. So as long as the encoders are distributed by Cisco they should be covered. But I'm neither a lawyer nor do I speak for Cisco.

I don't mean I don't trust the Mozilla binaries. I just mean they are not the binaries that Cisco is releasing. I think we've established this by now. :)

I'd really like to see the GitHub releases fixed. E.g. https://github.com/cisco/openh264/releases/tag/v2.4.0 says "All the binaries have been digitally signed" but in fact they are just MD5 hashes, not digital signatures, and any man-in-the-middle attacker who can change the binaries can also just as easily change the hashes. And even if the hashes were delivered securely, MD5 hasn't been safe for nearly 20 years now.

We have detected that the OpenH264 2.4.1 binaries have unexpectedly changed after release for at least x86_64 and aarch64. The binaries that I downloaded on February 2 do not match the binaries distributed today, February 8. I don't know when they changed. Here are sha256sums and sizes for the files distributed on February 2. The x86_64 libopenh264-2.4.1-linux64.7.so.bz2 that I downloaded on February 2 was 633714 bytes and had a SHA-256 hash of 47107cfc244f2d4c87d1f360f682024d7d50322d8c66fb4a1ae69bd976675285. The same file downloaded today, February 8, is 633796 bytes and has a SHA-256 hash of ca413853d99d960ebcd5ae5b4c65a85bb2b5598e9042e64700a9f4b737ca3a3f.
Needless to say, this should never happen without some sort of official announcement telling people to expect it. I'm assuming Cisco has intentionally changed the binaries and that there is no attacker, but absent some sort of announcement, there's no way for us to know.
This incident further reinforces the importance of supply chain security. I was worried about theoretical issues; I certainly didn't expect it to be a real problem in practice. Properly supporting TLS would be the bare minimum to restore confidence; adding GPG signatures would be better. Please stop using MD5 hashes and certainly stop referring to them as "digital signatures."

I'm assuming Cisco has intentionally changed the binaries

I'm assuming it has to do with this, maybe: https://github.com/cisco/openh264/issues/3728

Properly supporting TLS would be the bare minimum to restore confidence; adding GPG signatures would be better. Please stop using MD5 hashes and certainly stop referring to them as "digital signatures."

100% agree.

About MD5:
https://twitter.com/DiscussingFilm/status/1770198014319026436

Here is a 72-byte alphanum MD5 collision with 1-byte difference for fun:
md5("TEXTCOLLBYfGiJUETHQ4hAcKSMd5zYpgqf1YRDhkmxHkhPWptrkoyz28wnI9V0aHeAuaKnak")
=
md5("TEXTCOLLBYfGiJUETHQ4hEcKSMd5zYpgqf1YRDhkmxHkhPWptrkoyz28wnI9V0aHeAuaKnak")

🤡🚨

About MD5:

I was about to report you as a spammer, but you don't look like a spammer. Did you just paste the wrong link there?

What, yes, sorry, how did that end up in my clipboard? 😂

Okay, now I know. Fixed the link. 😅

The more I read on this more concerned I get.  If cisco had compiled these or changed them, the binaries hash would not be in FF and FF fox would fail to load the binaries.  Perhaps that is happening.
I wonder if we could get a call together with the people at Mozilla and Cisco and verify all of this was going as expected. I am also sure that if mozilla wants to change to better hashes, GPG, post quntum, whatever, Cisco is in favour of better security and glad to post them.

nils-ohlmeier has this right.  The goal was to set this up so that you only had to trust Mozilla, not Cisco, yet Cisco could cover the MPEG-LA royalty fees for people that wanted to use this. Here is a video that explains how this was set up https://vimeo.com/79578794
It is certainly possible things have migrated from this along the way but I think the goals remain the same.

Trusting Mozilla may be ok although there is a catch - there is a time lag (counted in months) between Cisco making release and Mozilla added it in their setup. For example Mozilla is still at OpenH264 2.3.1.
That means when someone wanted a bugfix then they need to fix it in source code, wait for Cisco release then wait for Mozilla adding it which is many months of delay even for high priority bugfixes (from user perspective). If Cisco used stronger verification for released binaries then nobody would face dilemma between trust and time.

Mozilla builds, presumably built by Mozilla and kindly hosted by Cisco? (not relevant to this thread)

Yes, mozila builds are hosted on Cisco servers. With few adjustments it should be technically possible to use them in flatpak runtime but there is release delay catch I mentioned.

Official Cisco releases hosted here on GitHub (these are what we're discussing in this thread)

On GitHub there are just links posted, everything is hosted on ciscobinary.openh264.org

Than you @Erick555  and @mcatanzaro - I was not understanding the problem. Sorry.
Can someone summarize the problem and we are on this and what it is Cisco ( or Mozilla ) should do. I do not think I can get significantly more Cisco people working on this but I can get Cisco to help make the right thing happen.  I would also add that I think we could add more/other external maintainers for this as long as that person was acceptable to both Mozilla and Cisco.

That does not seem to deal with the problem reported above of "We have detected that the OpenH264 2.4.1 binaries have unexpectedly changed after release for at least x86_64 and aarch64."   At this point it is not clear to me who is making the builds or who uploaded the ones that changed.  That should deeply concern everyone and gets to why we do not view they way this is working as a secure build chain.

The changed binaries problem was discussed here. Yes, such accidents combined with lack of secure verification make the trust case even worse.

At this point it is not clear to me who is making the builds or who uploaded the ones that changed.

The 2.4.0 and 2.4.1 releases were created by Benzheng Zhang, who I presume works for Cisco. He would know who is making the builds.
The unexpected change to the binaries turned out to be an innocent mistake to fix the version number. The original 2.4.1 binaries improperly reported their version as 2.4.0, and the replacement binaries correctly report 2.4.1. Benzheng has already agreed to avoid replacing previously-released binaries in the future; a better solution would have been to just release 2.4.2.

I don't mind on which issue this gets fixed, as long as it gets fixed. :blush:
Browsers are more and more reluctant to connect with plain http sites (like it or not) and there is really, really no point at all in using a TLS certificate for a webserver that is not matching the identity of that server.
So please fix the invalid TLS certificate on https://ciscobinary.openh264.org/, so that web browsers can load that link without security warnings.

Seeing as this issue is closed, I understand the TLS certificate for the webserver will not get fixed here.
So please fix it in #3748.
Browsers are more and more reluctant to connect with plain http sites (like it or not) and there is really, really no point at all in using a TLS certificate for a webserver that is not matching the identity of that server.

This should be reopened because the problem is clearly not fixed.


How to do with a custom next.config.js

How can i use next-compose-plugins here?
/* eslint-disable no-param-reassign */
/* eslint-disable no-console */
const {
  PHASE_DEVELOPMENT_SERVER,
  PHASE_PRODUCTION_SERVER,
  PHASE_PRODUCTION_BUILD
} = require('next/constants');

const withPWA = require('next-pwa');
const optimizedImages = require('next-optimized-images');
const withVideos = require('next-videos');
const withBundleAnalyzer = require('@next/bundle-analyzer')({
  enabled: process.env.ANALYZE === 'true'
});

const nextConfig = (phase) => {
  const isDev = phase === PHASE_DEVELOPMENT_SERVER;
  const isProd = phase === PHASE_PRODUCTION_SERVER;
  const isProdBuild = phase === PHASE_PRODUCTION_BUILD;
  let assetPrefix = `${process.env.ASSET_PREFIX}${process.env.SERVER}`;
  let PUBLIC = `${assetPrefix}/_next`;
  if (isDev || !process.env.SERVER) {
    assetPrefix = '';
    PUBLIC = '';
  }

  return {
    assetPrefix,
    analyzeServer: ['server', 'both'].includes(process.env.BUNDLE_ANALYZE),
    analyzeBrowser: ['browser', 'both'].includes(process.env.BUNDLE_ANALYZE),
    optimizeImagesInDev: true,
    removeOriginalExtension: true,
    assetDirectory: 'static',
    bundleAnalyzerConfig: {
      server: {
        analyzerMode: 'static',
        reportFilename: '../bundles/server.html'
      },
      browser: {
        analyzerMode: 'static',
        reportFilename: '../bundles/client.html'
      }
    },
    pwa: {
      disable: isDev,
      register: true,
      dest: 'public',
      sw: 'sw.js'
    },
    env: {
      isDev,
      isProd,
      isProdBuild,
      APP_ENV: process.env.APP_ENV,

    },
    webpack(config, { isServer }) {
      if (!isServer) {
        config.resolve.alias['@sentry/node'] = '@sentry/browser';
      }
      return config;
    }
  };
};

module.exports = (phase) =>
  withBundleAnalyzer(withPWA(optimizedImages(withVideos(nextConfig(phase)))));

@rahul3103 rahul3103 You can achieve this by extending the next.config you posted.
I ran across this because I was trying to use the same type of isDev logic in my next-compose-plugins driven next.config, and extending a base config was the solution I settled on.  However, I feel there's likely a better option for simply exposing the phase.
@cyrilwanner Could you clarify how to reproduce the phase logic detailed in this next example using next-compose-plugins syntax?
Thank you!

The extending thing didn't quite work for me so I ended up writing my config like another plugin
const withPlugins = require('next-compose-plugins');
const optimizedImages = require('next-optimized-images');
const withBundleAnalyzer = require('@next/bundle-analyzer')({
  enabled: process.env.ANALYZE === 'true',
});
const siteMap = require('./scripts/sitemap'); // this is just a plain node script

function ourConfig(nextConfig = {}) {
  // can do logic that doesn't depend on webpack config or options here
  return Object.assign({}, nextConfig, {
    webpack(config, options) {
      // logic that depends on config/options here
      if (options.isServer) {
        siteMap({
          // use globby patters to full path inside `/src`
          exclude: ['!pages/temp-page.js'],
        });
      }

     // I needed to add a way to raw load markdown files so I can process them with remark
      config.module.rules.push({
        test: /\.md$/,
        loader: 'raw-loader',
      });
      if (typeof nextConfig.webpack === 'function') {
        return nextConfig.webpack(config, options);
      }
      return config;
    },
  });
}

module.exports = withPlugins([
  [withBundleAnalyzer({})],
  [ourConfig()],
  [
    optimizedImages,
    {
      responsive: {
        adapter: require('responsive-loader/sharp'),
      },
      pngquant: {
        speed: 10,
      },
    },
  ],
]);

I wanted to find a way to use the phase inside my nextConfig and i came up with this:
function getNextConfig(phase) {
  return {
    // ...
  }
}

module.exports = (phase, ...rest) => {
  const nextConfig = getNextConfig(phase);
  return withPlugins(plugins, nextConfig)(phase, ...rest);
};

I wanted to find a way to use the phase inside my nextConfig and i came up with this:
function getNextConfig(phase) {
  return {
    // ...
  }
}

module.exports = (phase, ...rest) => {
  const nextConfig = getNextConfig(phase);
  return withPlugins(plugins, nextConfig)(phase, ...rest);
};


Update dlib.

Thanks!
I'll publish the new version as soon as I have the occasion.

@Ms2ger published. :smile:


[Enterprise] Problems to configure the Cluster using the WebConsole

URL for relevant page?
http://docs.influxdata.com/enterprise/v1.1/production_installation/web_console_installation/
What products and version are you using?
# dpkg -l | grep influx
iF  influx-enterprise                1.1.1-1                            amd64        InfluxData's on-premise TICK stack management.
ii  influxdb-data                    1.1.1-c1.1.1-1                     amd64        Distributed time-series database.
ii  influxdb-meta                    1.1.1-c1.1.1-1                     amd64        Meta service for InfluxDB, a distributed time-series database.
#

Where did you look before opening the issue?
After following all steps, I can't create the cluster using the webadmin interface http://<myip>:3000/, below some information.

Executing in foreground mode.

$ /usr/bin/influx-enterprise run -c /etc/influx-enterprise/influx-enterprise.conf
2017/01/20 20:01:49 Loading config at /etc/influx-enterprise/influx-enterprise.conf
[jobs]2017/01/20 20:01:49 Starting service. Checking jobs every 5s.
2017/01/20 20:01:49 Fetching and validating license: XXXXXXXX-XXXXXXXX-XXXXXXXX-XXXXXXXX-XXXXXXXX
2017/01/20 20:01:49 Starting on port :3000...
[metaclient] 2017/01/20 20:01:49 opened client
Saving license locally to: /tmp/influx-enterprise.key.json
2017/01/20 20:01:49 License XXXXXXXX-XXXXXXXX-XXXXXXXX-XXXXXXXX-XXXXXXXX is valid.
[metaclient] 2017/01/20 20:01:49 opened client
[metaclient] 2017/01/20 20:01:50 opened client
[metaclient] 2017/01/20 20:01:50 opened client
[metaclient] 2017/01/20 20:01:51 opened client
[metaclient] 2017/01/20 20:01:51 opened client
Started GET "/" for <IP_ADDRESS> 2017-01-20 20:02:03.040596064 +0000 UTC
Completed 302 in 323.022µs (Size: 0B | POP: 175.239µs)
Started GET "/signup/admin/1" for <IP_ADDRESS> 2017-01-20 20:02:03.244288623 +0000 UTC
  Rendered react/entry.html 59.915µs
  Rendered layouts/application.html 3.11383ms
Completed 200 in 3.495814ms (Size: 1.4KB | POP: 244.028µs | Views: 3.173745ms)
Started GET "/api/int/v1/me" for <IP_ADDRESS> 2017-01-20 20:02:04.110861988 +0000 UTC
Started GET "/api/int/v1/config" for <IP_ADDRESS> 2017-01-20 20:02:04.111541957 +0000 UTC
  Rendered _errors.html 289.537µs
  Rendered _errors.html 290.208µs
  Rendered _routes.html 424.862µs
  Rendered 401.html 1.031614ms
  Rendered layouts/application.html 2.431068ms
Completed 401 in 2.926599ms (Size: 1.7KB | POP: 0s | Views: 4.177081ms)
  Rendered _routes.html 406.723µs
  Rendered 401.html 1.149672ms
  Rendered layouts/application.html 2.482015ms
Completed 401 in 2.635277ms (Size: 1.7KB | POP: 0s | Views: 4.328618ms)
Started GET "/api/int/v1/clusters" for <IP_ADDRESS> 2017-01-20 20:02:04.288539642 +0000 UTC
Completed 200 in 2.108112ms (Size: 2.4KB | POP: 336.776µs)
Started POST "/api/v1/setup/cluster_user" for <IP_ADDRESS> 2017-01-20 20:02:29.389077712 +0000 UTC
ERROR	2017-01-20T20:02:29Z /home/ubuntu/.go_workspace/src/github.com/influxdata/enterprise/actions/api/v1/setup/admin.go:79 : Cluster Not Found
  Rendered clusters/missing_cluster.html 523.425µs
  Rendered layouts/application.html 1.377169ms
Completed 404 in 1.770297ms (Size: 2.5KB | POP: 147.728µs | Views: 1.900594ms)

I have used the input values.

ClusterName: ClusterLombrado
AccountName: ClusterJorge
Password: Caipirinha

I can get the below error.

Started POST "/api/v1/setup/cluster_user" for <IP_ADDRESS> 2017-01-20 20:08:41.456371294 +0000 UTC
ERROR	2017-01-20T20:08:41Z /home/ubuntu/.go_workspace/src/github.com/influxdata/enterprise/actions/api/v1/setup/admin.go:79 : Cluster Not Found
  Rendered clusters/missing_cluster.html 604.604µs
  Rendered layouts/application.html 1.521906ms
Completed 404 in 1.879867ms (Size: 2.5KB | POP: 147.489µs | Views: 2.12651ms)

@jpereira, we generally try to reserve this repo for docs-specific issues. Because you're using the Enterprise product, please email support about this issue with the email provided to you when you signed up. I know they'll be able to help you out!

I've also removed some of the details from your original issue for privacy purposes.


further distill matrix, following @camptocamp's example

an attempt at fixing #10

let's see what travis thinks of this.
we also still need to fix our rspec issue

well, this looks fine, but i have no idea which puppet version we're testing :s

oh! i have to uncollapse bundle install to see.
we're testing puppet 3.6.2 (for facter 1.7.x), and puppet 3.7.4 (latest) for the others.
@daenney do you think that's "enough"?

lgtm

next up, fixing 1.8.7 builds, and as soon as that's done, we can release again


Repo dependency not found

When requirements.txt is being installed, it reports:
Command "git clone -q git://github.com/andyhd/python-logstash-formatter.git /tmp/pip-kUKo47-build" failed with error code 128 in None

Repo appears to have gone.
Is it possible to use another version, e.g. https://github.com/ulule/python-logstash-formatter ?

@andyhd please can you add any info on what the forked python-logstash-formatter was for and why your fork is missing now?

Sorry, I haven't worked on postcodeinfo since 2015 and I can't remember what the fork was for. I didn't realise my fork was still a dependency and since my pull request on the original logstash-formatter repo was not merged after 2 years, I deleted it.
I suggest trying replacing the dependency with a more recent version of python-logstash-formatter.

Looks like my patch was accepted in python-logstash-formatter 0.5.17, so you could change the dependency to that


Set a variable both as local as well as output.

Version of your agent? 2.213.2
OS of the machine running the agent? Windows
Azure DevOps Type and Version
dev.azure.com
If dev.azure.com, what is your organization name? https://dev.azure.com/jessehouwing-dev
I have a variable that I set in a task Extension.Version. When I pass the isOutput=true, I expect it to register an output variable. When I pass isOutput=false I expect it to register a local variable. When I run both commands in succession, I expect both the output and the local variable to be set.
This scenario is important to support backwards compatibility when introducing output variables to a task that previously didn't have one, without breaking my users.
The Bug
This doesn't work, however, when the task explicitly declares the output variable in the task.json, which completely seems to make the isOutput=false to be ignored.
    console.log("Setting local variable 'Extension.Version'.");
    tl.setVariable("Extension.Version", version, false, false);
    console.log("Setting output variable '{{StepName}}.Extension.Version'.");
    tl.setVariable("Extension.Version", version, false, true);

##[debug]setBuildNumber=false
##[debug]setOutputFlag=false
##[debug]outputVariable=MyExtension.Version
##[warning]Using of deprecated 'outputVariable' parameter. Remove this parameter and use 'setOutputFlag: true' and 'name: {{Stepname}}' on this step and reference '{{StepName.Extension.Version}}' in a future step instead.
##[debug]Processed: ##vso[task.issue type=warning;]Using of deprecated 'outputVariable' parameter. Remove this parameter and use 'setOutputFlag: true' and 'name: {{Stepname}}' on this step and reference '{{StepName.Extension.Version}}' in a future step instead.
##[debug]set MyExtension.Version=3.0.11
##[debug]Processed: ##vso[task.setvariable variable=MyExtension.Version;isOutput=false;issecret=false;]3.0.11
##[warning]Using deprecated variable conversions. Use 'setOutputFlag: true' and 'name: {{Stepname}}' on this step and reference '{{StepName.Extension.Version}}' in a future step instead.
##[debug]Processed: ##vso[task.issue type=warning;]Using deprecated variable conversions. Use 'setOutputFlag: true' and 'name: {{Stepname}}' on this step and reference '{{StepName.Extension.Version}}' in a future step instead.
Setting variable 'Extension.Version'.
##[debug]set Extension.Version=3.0.11
##[debug]Processed: ##vso[task.setvariable variable=Extension.Version;isOutput=false;issecret=false;]3.0.11
##[debug]task result: Succeeded
##[debug]Processed: ##vso[task.complete result=Succeeded;]tfx exited with return code: 0

Results in:
Direct $(Extension.Version)
Output 3.0.11 // $(Query.Extension.Version)

Removing the OutputVariables section from the task.json results in:
Direct 3.0.11 // $(Extension.Version)
Output 3.0.11 // $(Query.Extension.Version)

Hi @jessehouwing, thanks for reporting! We are working on more prioritized issues at the moment but will get back to this one soon.

Still issue

Still an issue

Still valid


Builds are failing

Builds are all failing because of phpschool.io

Pull requests welcome.

@josegonzalez Opened an issue on the failing repo and fixed the problem


Add name to user sites

This PR will add names to user sites.
Issues
Out of habit I used "name" as user facing terminology and "label" in the code, but should I simplify things and just use "name" everywhere?

Out of habit I used "name" as user facing terminology and "label" in the code, but should I simplify things and just use "name" everywhere?

I think it's fine to refer to it as "label" in the code.

Branch was squashed and fast-forward merged


Use the csp-report endpoint in addons-nginx

:bomb: Don't land until addons-nginx PR has landed and is built on the docker hub. :bomb:
Fixes #1304

r+


Implementation of Backwards Equations for T(p,h) & T(p,s)

[x] Backward equations implemented as T_phmass(p,h) and T_psmass(p,s)
[x] Found and corrected bug in backward T23(p) boundary equation (indices not zero based)
[x] Added more general comments to code...
[x] Updated Mathcad wrapper to provide T(p,h) & T(p,s) as well as some test boundary functions
[x] Updated Stand-alone check program IF97.cpp to print verification tables for backward eqs.

Verification tables from Mathcad shown below:

Whoah, that's awesome...

All set.


Update go directive to 1.21 instead of 1.21.0

Having 1.21.0 and using newer version, e.g. 1.21.4, go mod tidy adds toolchain go1.21.4 to my project. However, some people working on a project might be using 1.21.3 or 1.21.2 and so on. So let's not be so strict and set it to 1.21 without patch

Thank @pjarmalavicius for your contribution

@orandin can you please bump the release version?

done 😉


Cannot install nestedtensor: error: ‘class at::Tensor’ has no member named ‘is_pinned’

Here is the full log. Do i have to install the nightly version of pytorch to install this package?
https://gist.github.com/justanhduc/d5fbf2d6eeca92a660b3db2c2898faef

closing as installing the nightly version of pytorch removes the error.


Bug Report: Game crashes when week finishes

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.
If you are playing a downloaded version of the game, what operating system are you using?
Windows 10 64-Bit
What version of the game are you using? Look in the bottom left corner of the main menu.
KE v1.6.2
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.

Open Story Mode Menu
Try any unlocked week
Finish the week's songs

Please describe your issue. Provide extensive detail and images if possible.
After completing a week's songs, the game closes. I'm using the unedited and built version of KE.

Which week have you tried? And do you get this error when building from master's source?

I get this same exact issue myself, running it on Windows 64-bit with KE v1.6.2, and I'm not sure if this happens with every unlocked week as I just downloaded KE v1.6.2 straight from Github, I'm only left with the Tutorial week and the crash as described prevents me and most likely the original poster from unlocking future weeks


Simplified file-retrieval support using HTSGET and SDA protocols

Overview of changes:

Added support for file-retrieval using protocol: sda://<dataset_id>/path/to/file

Bearer token is implicitly re-used from the "create-task" request.
The "create-task" request without a Bearer token will fail immediately.
It is possible to provide explicit Bearer token at the end of the URL after hash-sign; for example: sda://<dataset_id>/file#token-here
Supports downloading both Crypt4gh files (over /s3-encrypted/... path; decrypting *.c4gh files locally) and decrypted files (over /s3/... path)
Configuration just specifies the ServiceURL for the SDA to be used.

Simplified support for file-retrieval using HTSGET htsget://{reads|variants}/path/to/file-without-extension

Bearer token is implicitly re-used from the "create-task" request.
The "create-task" request will NOT fail without a Bearer token or credentials. (HTSGET may support non-authenticated requests.)
It is possible to provide explicit username:password or Bearer token at the end of the URL after hash-sign; for example: htsget://.../file#user:pass
Configuration just specifies the ServiceURL for the HTSGET to be used.

Refactored type names (simpler) in crypt4gh and htsget.
Updated documentation about HTSGET and SDA protocols.

PR has been updated with a fix for retrieving non-encrypted content from SDA.


Material count selector

Adding selector

Selector is needed for easy display of needed amount to get this material

All code have been added to repo


Changeset Inverses Brain Dump Doc

Adds a document containing a brain dump on inverse changes and undo.

TODOs:

Mention how rebasing over inverses works differently in undo vs. rebase cases
Add "Blob + Changes" as a way of describing repair data


Can't connect to subscription endpoint on desktop app

I am using Graphql Playground 1.8.10 version on Mac OS. It works fine when I send query to my graphql server. But it can't find the subscription endpoint URL when I send a subscription event.
In below screenshot, the url I used is http://localhost:8080/quote but the error message says Could not connect to websocket endpoint ws://localhost:8080. Please check if the endpoint url is correct.. It seems it uses localhost:8080 which doesn't exist. It works fine for query only happens on subscription.

+1 Any update on this issue?
Same issue is reproduced using express-server and nexus-prisma.

any update on this? met the same problem

+1


Split coins for Observer

allow the option to split coins for observer permission, as I don't want the player to be able to edit the item within the loot / merchant with permission from the owner.

Came here to ask for exactly the same thing. Could take a stab at it and do a pull request too. Basically need a permission level (the default?) that means the loot belongs to the party, but they can't change it; they can only take items and currency, including the auto-split.


problem with quick replies in ask method

BotMan Version: 1.5.5
PHP Version:7.0
Messaging Service(s): Facebook Messenger
Cache Driver:file

Description:
After upgrade Botman to 1.5.5 version (from 1.4) code below stop working
$question="Send (write YES or NO)?";
      $this->ask($question,function (Answer $answer) {
           $this->say( $answer->getValue());
           $this->answerText= $answer->getText();
            if (strtoupper($this->answerText) =='YES'){
                $this->say('OK');
            }elseif($this->answerText=='NO'){
                $this->say('BYE');
            }else{
                $this->repeatFunction();
            }
        },['message' => json_encode([
                'text' => 'Choose',
                'quick_replies' => json_encode([
                    [
                        'content_type' => 'text',
                        'title' => 'YES',
                        'payload' =>'1',
                    ],
                    [
                        'content_type' => 'text',
                        'title' => 'NO',
                        'payload' =>'2',
                    ]
                ])
            ])
        ]
        );

log is clear
Steps To Reproduce:

sorry, my mistake

I think you can just remove the json_encode and it will work

thanks Marcel
i found this one when test this array_merge_recursive  so i close this pull
, next time i will first try more searching in Botman Code :) before add a
pull
great work with Botman!
Robert
2017-05-09 14:26 GMT+02:00 Marcel Pociot<EMAIL_ADDRESS>
I think you can just remove the json_encode and it will work
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/mpociot/botman/issues/372#issuecomment-300147202, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AXvUhEHxbw-5vIp4ssrP9Y_Y7UM1tvNOks5r4Ft2gaJpZM4NVNHG
.

--
Pozdrawiam
Bartosz Wroński, tel kom +48737482363
Lokalna Platforma Handlowa *VTown *- więcej na biznes.vtown.pl


fix: bump node-gyp for hoek fix

Closes #2355
Think this might be worth a 4.9.3

:+1:
On Thu., 9 Aug. 2018, 3:23 pm Nick Schonning<EMAIL_ADDRESS>wrote:

This might not actually be necessary since it is in the version range
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/pull/2472#issuecomment-411640435, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjZWNrYy1buLqIBFhHh3PmsMTKdisw-ks5uO8dugaJpZM4V1DuS
.

Thanks! Released v4.9.3


Convert codebase to typescript

Closes #3
Closes #7
This PR converts the codebase to using TypeScript throughout. I've tried to make as minimal as necessary changes to the codebase beyond adding types to keep the same semantic meaning throughout. Future PRs can definitely be landed to simplify certain things now that types are in-place.
As part of this work, I've removed babel, and with it, its backwards transpiling it was doing. Notably, this means that the codebase now targets ES6 instead of ES5 (minimally, we use array.prototype.includes). While this means in-theory that the codebase will work on Node >= 6, I've set the minimum version at >=10 since that's what's required for multiple of the dev dependencies, and that 8.x line has been end of life for a bit over a year and 6.x for a little under two years. All downstream users of this library either only aim for Node 10+ or do not seem to be actively maintained. In any case, the 1.x line remains available for those who do not upgrade. While we could include babel as a transpile step (and so just use tsc for typechecking), it adds some amount of complexity that I'd like to avoid unless there's some great reason to support EOL versions.

This looks pretty solid honestly. It will help the library be easier to use, and hopefully get us closer to it being a full-fledged SQL-parser


Table to Line of Bearing fails with single coordinate inputs in Pro 1.3

Table to Line of Bearing fails with single coordinate inputs in Pro 1.3
**Start Time: Thursday, December 08, 2016 10:44:33 AM
Running script TableToLineOfBearing...
Adding LONG field JoinID
Adding unique row IDs...
Formatting start point...
Creating lines as GEODESIC...
Joining fields from input table to output line features...
Start Time: Thursday, December 08, 2016 10:44:35 AM
Failed to execute. Parameters are not valid.
ERROR 000308: Invalid field type
Failed to execute (JoinField).
Failed at Thursday, December 08, 2016 10:44:35 AM (Elapsed Time: 0.06 seconds)
Completed script TableToLineOfBearing...
Failed to execute (TableToLineOfBearing).
Failed at Thursday, December 08, 2016 10:44:35 AM (Elapsed Time: 2.66 seconds)
**

Need more info:

What input file?
What input field?
Please provide steps to reproduce the problem.

What input file? Use the TableToLineOfBearing_single.csv that comes in the testdata folder
What input field? Any single coordiante input will cause the failure.
Below is a screen caputure of input dialog with outputs that failed.

On a second attempt, features are generated but tool shows as failed.  Same error as above.

Parameters
Input Table	\ncamposdt\Shared_Folder\military-tools-geoprocessing-toolbox-dev\military-tools-geoprocessing-toolbox-dev\testdata\CSV\TableToLineOfBeaing_single.csv
Input Coordinate Format	GEOREF
X Field (longitude, UTM, MGRS, USNG, GARS, GEOREF)	GEOREF
Y Field (latitude)
Bearing Units	DEGREES
Bearing Field	Orientation
Distance Units	KILOMETERS
Distance Field	Distance
Output Lines	C:\Users\nata7004\Documents\ArcGIS\Projects\testing\testing.gdb\outputLines5
Line Type	GEODESIC
Spatial Reference	GEOGCS['GCS_WGS_1984',DATUM['D_WGS_1984',SPHEROID['WGS_1984',6378137.0,298.257223563]],PRIMEM['Greenwich',0.0],UNIT['Degree',0.0174532925199433]];-400 -400<PHONE_NUMBER>;-100000 10000;-100000 10000;8.98315284119522E-09;0.001;0.001;IsHighPrecision
Messages
Start Time: Thursday, December 08, 2016 11:17:51 AM
Running script TableToLineOfBearing...
Adding LONG field JoinID
Adding unique row IDs...
Formatting start point...
Creating lines as GEODESIC...
Joining fields from input table to output line features...
Start Time: Thursday, December 08, 2016 11:17:55 AM
Failed to execute. Parameters are not valid.
ERROR 000308: Invalid field type
Failed to execute (JoinField).
Failed at Thursday, December 08, 2016 11:17:55 AM (Elapsed Time: 0.06 seconds)
Completed script TableToLineOfBearing...
Failed to execute (TableToLineOfBearing).
Failed at Thursday, December 08, 2016 11:17:55 AM (Elapsed Time: 3.95 seconds)

fix verified


feat(EVM): CW-13788 update jest test result

Checklist:

README.md includes:

[ ] The details of signing data and transaction data, this includes parameters.
[ ] Official docs or white paper.
[ ] Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Task linked: CW-13788 修正SDK的初始建置問題


Serial

This is an in-progress PR - see my email for details

@caitlin-hennessy,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Could you add some screenshots if there are UI changes included?


"Movila Ruptă", "Popoaia", "Ripicenii Vechi" and "Râșca" are listed in the drop-down menu

Description:
"Movila Ruptă", "Popoaia", "Ripicenii Vechi" and "Râșca" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Movila Ruptă" in the search bar.

Expected results
The location is listed in the drop-down menu as "Movila Ruptă, Botoșani (Ripiceni)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Popoaia" in the search bar.

Expected results
The location is listed in the drop-down menu as "Popoaia, Botoșani (Ripiceni)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Ripicenii Vechi" in the search bar.

Expected results
The location is listed in the drop-down menu as "Ripicenii Vechi, Botoșani (Ripiceni)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Râșca" in the search bar.

Expected results
The location is listed in the drop-down menu as "Râșca, Botoșani (Ripiceni)".


runner_windows.go:43:47: undefined: findEdgePath

why edge ？

The windows build was fixed in master, like @sloppycoder mentioned.

@mvdan would you you consider cutting a new release that has the fix? If API's haven't changed, a patch release like 1.2.1 would be great.


About the observation.

Congratulations! I think LAMBDA is a pretty good work!
I wonder if you have tested LAMBDA in tasks with sensor-based observations, instead of the pixel-based ones used in the paper.

Hi @Zarzard!
Thanks for reaching out! I haven't tried it with sensor-based observation but I think it shouldn't be that hard to try. The idea is to replace the CNN encoder and decoder in World Model with dense layers. I think it should definitely work, with the main gotcha being normalizing the observations to be between [-1, 1].
Feel free to make a PR with that, we can try it out if you want!

Thanks for the response! It will be very nice for you to provide the sensor-based results!

Yes, I agree but I'm working on other projects now. If you feel like contributing this, I'd be happy to accompany you with a PR.
Closing for now.

Okay, I'll try myself then. Thanks!

@yardenas Thanks for sharing the code!
I want to use LAMBDA on sensor observations instead of images, and I was a bit confused by this issue. If I understand correctly, the code already uses an MLP as an encoder/decoder for the observations if the observation type is set to "dense" here, right?


make ThrottleCacheItem serializable

so that I can persist it using a Ovicus.Caching Sql implementation of ObjectCache

Thanks for the PR. Version 1.0.2 has this fix and was just uploaded to NuGet. Give it some time to get indexed by search. I also added a unit test at https://github.com/gopangea/BrakePedal/blob/4eb12d3d90afffd763a262ae3b778b5f692f91f8/src/BrakePedal.Tests/MemoryThrottleRepositoryTests.cs

Great, thanks Omar.


Not able to use configuration via Fronted

Installed everything via Hacs. Restarted HA but under Configuration -> Integration Adaptive lightning was not visible. Only way to get it there is via the YAML configuration for me.
Any idea how to solve this?

I have the same issue, I added the repo to HACS but after that I cant find adaptive lighting under Integration (or under add Integration). Only when I add a yaml config do I see the integration, but then I cant see or edit anything through the frontend.
This is the first time I'm using HACS with a custom integration so I could be doing something wrong...
I'm running the latest HA as a docker container on a synology.

Unfortunately I will be AFK for the next month. If anyone can make an attempt at fixing this, I will merge it.


feed.segments

Thank you very much for this package.
I have a issue when using feed.segments. I have a bus line (from trips) with constant route_id but 4 different shape_id, two of them with direction_id = 0, the other two with direction_id=1. The output of feed.segments includes only two of the four shape_id (one with direction_id = 0 and one with direction_id = 1).
When using a less recent version (<2.0), with the function cut_gtfs, I am able to obtain all shape_id for each route_id. In that case I am allowed to pass to the cut_gtfs stop_times, stops, and shapes, in the new version I haven't understood if I can force any parameter.
Is there anything I can do to force segments to provide outputs for all shape_id, even if route_id and large part of the stops are duplicated?
Thank you very much again,
Matteo Corazza

I apologize for writing back on this issue. In fact even if setting busiest_date = False results significantly improve, it still seems that some fields are missing. In fact in the GTFS fixing route_id, from_stop_id, and to_stop_id, there are multiple shape_ids. In the segments output I have only one shape_id. Is there any optional argument to force segments to provide all shape_ids? Thank you

hi @corazzamtt thanks a lot for the detailed explanation. I think your problems should be solved with the latest version that brings functionality to take into account all the different patterns of a route.
Try with feed = Feed(gtfs_path, busiest_date=False, patterns=True)


Add optional opentelemetry file export tracing

This is an alternative implementation of #705.
This PR adds opt-in functionality (with the trace feature) that writes OpenTelemetry File Export tracing information during build and compile. The tracing data includes buildpack attributes (like buildpack id, name), spans for build and detect, events for build-success, detect-pass, detect-fail, and also sets errors and span status in the case of errors.

@joshwlewis It looks like there were new versions of the opentelemetry crates released in the last couple of days:
https://github.com/open-telemetry/opentelemetry-rust/releases/tag/v0.21.0
Maybe worth picking those new versions up now?
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-stdout/CHANGELOG.md

It looks like there were new versions of the opentelemetry crates released in the last couple of days

@edmorley thanks. Brought them in with 54f8fe4.


Error on gridsome develop - @apply cannot be used with .transition-color

I got
 WAIT  Compiling...                                                                                1:25:31 PM

 ERROR  Failed to compile with 1 errors                                                                                1:25:32 PM

 error  in ./src/assets/css/main.css?vue&type=style&index=0&lang=css&

Syntax Error: SyntaxError

(37:5) `@apply` cannot be used with .transition-color because .transition-color is included in multiple rulesets.

  35 |
  36 |   a {
> 37 |     @apply text-blue-500 transition-color;
     |     ^
  38 |
  39 |     &:hover {

It was a conflict between tailwindcss v1.2.0 and the tailwindcss-transitions plugin that Bleda was using. I've updated Tailwind CSS and removed that plugin, all should be good now - feel free to reopen if you're still encountering issues 👍

Thanks @cossssmin I will check it out.


Add kubewatch client for watching k8s events

This PR will add kubewatch client, which will watch the k8s events through events watch API and applying handler for each message. For now, it will send the events to slack channel.
Some limitations (to be improved):

The client only watch for kube-apiserver running on localhost only
No testing involves (need to find an easy way to mock some objects)

@Gnouc Congrats for the first PR

@Gnouc let's put this in https://github.com/skippbox/kubewatch brand new repo.
I will keep this kubewatch in runseb org for the bot version...


⚠ Bio Links has degraded performance

In 8068218, Bio Links (https://bio.rheinklang.events/links) experienced degraded performance:

HTTP code: 200
Response time: 4536 ms

Resolved: Bio Links performance has improved in f4d66e6 after 11 minutes.


Feature Request: Add Featured Image to Blog Posts

Hello,
I noticed that there's no functionality for adding a featured image to blog posts. This would be a useful feature for posts and readers.

Hey @Esmaeli,
Thanks for asking. Well, I am not sure if I fully understand your request.
In the current state, you can provide two images: A preview image and a fallback preview image.
They are not only used for the blog post itself but also for social media posts (OG Data tags) and also for RSS Feed Reader.
The difference between the non-fallback and fallback is that it is a priority between them.
The normal way is to have a modern image format like webp/avif as "preview" image and "jpeg" as fallback. For example LinkedIn can't cope with avif/webp images, therefore you have to provide a jpg/png image as fallback.

Hi @linkdotnet
Thank you for the answer, but in the preview that you published on GitHub as a GIF file, when publishing the post, I did not see a place to select the image as the preview image or the fallback preview image, and for this reason, I sent this request, and when I checked your personal blog and I was surprised to see that there is a preview image.
If we only need to add a photo inside the post itself so that it can be shared on social networks, maybe it is better to include an option to attach a preview image and consider it specifically.

Yeah, that preview is roughly 2 years old - I really have to adapt and renew it. You might see a "Preview Url" in the GIF as well - that is used for all that stuff.
Here a newer "picture":

Currently, you have to provide the URL to the image itself - there is no way of uploading because that would mean you need something like an Azure Blog Storage or so. And I did not build this abstraction until now.


Augment target audience: support net7.0

Quoting your Medium article:

I don’t believe that people will switch the framework in their
existing projects anyway, and for the new projects newer .NET is
an obvious choice.

Obvious choice? Well, is newer always better? In general, yes, but this is not a black&white scenario. Newer is good, especially if you are starting from scratch, but how new? bleeding-edge new? pre-release new? nightly new? There's many shades of grey here.
And that's why we have qualifiers for releases: for example, Ubuntu 23.04 might be newer than Ubuntu 22.04, however the latter is an "LTS" release and that's why many business stick to it and only upgrade to the next LTS release: so that they upgrade to a more battle-tested platform and avoid all the bugs (that other early adopters can catch on behalf of them).
And this is why changing the target framework here from net8.0 to net7.0 might increase your target audience: there may be sysadmins out there that are hesitant, or simply cannot, upgrade to .net8.0 yet. An example is that if you install Ubuntu22.04.3 (LTS) today and try to install the package dotnet8 (with apt), it doesn't exist. However, dotnet7 does exist.
So why limit Oxpecker to only early adopters that can consume net8.0 today instead of increasing the target audience to potential adopters by supporting net7.0? Especially given that Oxpecker isn't really making use of any feature of .net8.0 so it is essentially not a requirement. Let the consumers of your library update their .net runtimes at their own pace.

@knocte Thank you for the suggestion! Have you checked this link https://learn.microsoft.com/en-us/dotnet/core/install/linux-ubuntu#install-net, it describes how to install dotnet on Ubuntu 22.04, which is LTS. Moreover, the .NET 8.0 is also LTS, thus is why I chose it as target and not .NET 7.0. Adding support of the new framework is easy, however dropping support is not, so I don't want to have this problem in future. I also don't have a goal of having as many early adopters as possible, simplicity of maintenance has a higher priority for me.

I'm talking about Ubuntu-native packages here, which means that they truly come from the opensource codebase (vetted by Canonical), so that you don't need to install external software sources manually, increasing your potential risks.

I understand that, but specifically for Microsoft and .NET 8 it's not a security question, but rather political (knowing that 23.10 already has support of .NET 8). With .NET6 packages in LTS became available in August, I expect it to happen much earlier with .NET 8. And if you don't trust microsoft servers with packages, you shouldn't trust Nuget (microsoft server) and me (3d party publisher) as well.

The day you start depending on some new .net8.0 feature, for example, you simply increase a major version (e.g. from 1.x to 2.x) and call it a day.
It will still disappoint people that for some reason got stuck on .net7.0 and used the project (I've had such experience already). So from my experience it's better not to step into that at all. Moreover, I don't believe that you can build Oxpecker sources with .net7.0 sdk today, since it's already using some newest F# 8 features.

If I cannot consume Oxpecker libs myself from our companies' servers, I doubt I will continue contributing.
I understand and I'm very sorry for that, but having less maintenance is a top priority for me and will allow me to maintain project and contribute for a long time. As a workaround you could just maintain your own fork with .NET 7 support for a few months, till Canonical starts supporting .NET 8 on LTS, publish it to Nuget or private feed and then just easily switch to Oxpecker nuget once the support is there.

and me (3d party publisher) as well.

Funny you say that because I was planning my next contribution to be CI steps to upload the nuget package automagically.

I don't believe that you can build Oxpecker sources with .net7.0 sdk today, since it's already using some newest F# 8 features.

Oh which ones? Anyway, this PR is not changing how the proj is built, but how it can be consumed.

It will still disappoint people that for some reason got stuck on .net7.0

So the logic goes like this? "As I may break up with you in the future and I don't want to make you suffer, then let's rather not start dating at all" lol!

I was planning my next contribution to be CI steps to upload the nuget package automagically.

I'll appreciate that, if you make your own fork, it will work for you as well, just the name of the package will be different.

Oh which ones?

For example this line, haven't searched further.

Anyway, this PR is not changing how the proj is built, but how it can be consumed.

Yes, I understand, but building with one OS and consuming with another can be an issue for your CI anyway

So the logic goes like this? "As I may break up with you in the future and I don't want to make you suffer, then let's rather not start dating at all" lol!

Unfortunately, we all have to deal with the trade-offs, in my case this is the tradeoff I decided to make. I understand if you decide to not contribute anymore, life is life.

Closing as not planned (.NET 7 end of life is May 14, 2024)


Errors with Subcollections initialization

Problem
To be able to query SubCollections of an entity, the entity must contain at least one field in firestore (without counting the subcollection).
Why?
Because Fireorm is using firestore-admin's collection.get(id) to get the User collection and it returns ``collection.exist === false``` for collections that doesn't contain any fields
How to reproduce:
class Message {
  id: string;
  text: string;
  date: Date;
}

@Collection()
class User {
  id: string;
  @SubCollection(Message)
  messages?: ISubCollection<Message>
}

const userRepository = GetRepository(User);
const user = await userRepository.findById('id');
const messages = await user.messages.find();

/*
if `user` doesn't contain any fields, firestore-admin will set user.exists = false
and subcollections won't be initialized due to this line: https://github.com/wovalle/fireorm/blob/master/src/BaseFirestoreRepository.ts#L60-L62

*/

Aceptance Criteria:

We should be able to use subcollections of entities that don't contain any field
Unit tests are added

Note: for collections created with fireorm, this won't ever happen since fireorm's automatically set's an id field to every document.

Did a couple of tests creating multiple documents in firestore:
Empty document (vacio)
Document with fields and no SubCollection (con-campo)
Document with SubCollection and no fields  (con-subcollection)
Document with SubCollection and fields  (con-sub-campo)
Unexistent document (unexistent)
And ran the tests with individuals findById and with find.

All the documents returned exist = true (but the unexistent one, as expected), so this issue won't happen.
Closing without a fix, is not relevant anymore. Feel free to re-open if issues are found.


Convolution2D for same border_mode on GPU reduces data size

#Run this code. I have modified the mnist_cnn.py file to have the "same" border_mode. At the end, #it displays the size of first layer output. It should be same as the input i.e (28, 28) but it is ( 27, 27)
from keras.datasets import mnist
from keras.models import Sequential
from keras.layers.core import Dense, Dropout, Activation, Flatten
from keras.layers.convolutional import Convolution2D, MaxPooling2D
from keras.utils import np_utils
import theano
batch_size = 10
nb_classes = 10
nb_epoch = 0
img_rows, img_cols = 28, 28
nb_filters = 32
nb_pool = 2
nb_conv = 2
(X_train, y_train), (X_test, y_test) = mnist.load_data()
X_train = X_train.reshape(X_train.shape[0], 1, img_rows, img_cols)
X_test = X_test.reshape(X_test.shape[0], 1, img_rows, img_cols)
X_train = X_train.astype("float32")
X_test = X_test.astype("float32")
X_train /= 255
X_test /= 255
print('X_train shape:', X_train.shape)
print(X_train.shape[0], 'train samples')
print(X_test.shape[0], 'test samples')
Y_train = np_utils.to_categorical(y_train, nb_classes)
Y_test = np_utils.to_categorical(y_test, nb_classes)
model = Sequential()
model.add(Convolution2D(nb_filters, nb_conv, nb_conv,
border_mode='same',
input_shape=(1, img_rows, img_cols)))
model.add(Activation('relu'))
model.add(Convolution2D(nb_filters, nb_conv, nb_conv))
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(nb_pool, nb_pool)))
model.add(Dropout(0.25))
model.add(Flatten())
model.add(Dense(128))
model.add(Activation('relu'))
model.add(Dropout(0.5))
model.add(Dense(nb_classes))
model.add(Activation('softmax'))
model.compile(loss='categorical_crossentropy', optimizer='adadelta')
layer_id = 0
model.extract_features = theano.function(
[model.layers[0].input],
model.layers[layer_id].get_output(False),
on_unused_input='ignore', allow_input_downcast=True)
output = model.extract_features(X_test[0:1, :])
print("output size of layer : "+str(layer_id)+" has shape "+str(output.shape))

You should check your layers' shapes by using print_layer_shapes function, found in keras/utils/layer_utils.

check nb_conv=3 if @jocicmarko suggestion doesn't work

@EderSantana  it works as expected if the size of a filter is odd. Not for even.
So, I think the same border_mode implementation on gpu is right for odd kernel size.

@MinhazPalasara here is where we calculate the output size https://github.com/fchollet/keras/blob/master/keras/layers/convolutional.py#L16-L26
Do you mind giving suggestions for what your mean?

@EderSantana The problem seems to be here: https://github.com/fchollet/keras/blob/master/keras/layers/convolutional.py#L247 since symmetric padding is being applied to the input image, the same amount on each side of the image.
For a kernel that is even-sized along a dimension when using the "same" mode, it is necessary to have one more pixel of padding on one side of the image along this dimension in order to ensure that the output is of the correct size (currently, the image incorrectly shrinks in size along this dimension after the operation).
This problem seems to be only present in the GPU implementation, since the CPU implementation does ensure that the output has the correct size: https://github.com/fchollet/keras/blob/master/keras/layers/convolutional.py#L266


Feature/raz

Somehow the DCO signed commits are giving me headaches. Retrying.

Wow, it worked :). Took me a moment to realize that the Author name and Signed-off-by field need to be the same. Github should document that feature better.

Handled by #55


Revert freertos_kernel submodule change for SPIRAM change

Description
https://github.com/aws/amazon-freertos/pull/3355 fixed SPIRAM with ESP32.
However, a crash is observed in OTA demos with the freertos_kernel update.
Most likely, https://github.com/FreeRTOS/FreeRTOS-Kernel/commit/6bf3a75c6a46c1b6b38f5b55751ec4cfa6333fdd is the root cause of the crash.
Fix for SPIRAM will be reintroduced once the root cause for the crash is fixed.
Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

@aggarg @divekarshubham Closing this PR. I'll open new PR with proper fix.


Add top level var support

Note - Merge to master once the next-release is synced to the master.
Purpose
This PR allows global level variable declarations using var.
Resolves #12394

Temporary closing the PR until the master is merged and LS is updated.


Ensure that IDF_PATH and IDF_TOOLS_PATH are exported to subshell

Resolves #3737. This is a naïve approach in that any other environment variables that might need to be exported to the Python tool will need to be added here manually, but it gets the job done.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Error setting a value on a 1:1 model instance

I've got a several types (Route, RouteLeg, etc) that have a 1:1 mapping to a CheckState model.  I'm trying to do a series of parsing/processing steps while loading data from the server.  I first initialize all my models from the loaded data, after which I need to calculate the values for these CheckState objects based on the related data.
During this process, I'm calling a function on a model instance to update itself, which tries to assign an updated value to a property on the CheckState instance attached to it.  This crashes down in Backend.update() when it tries to call idArr.reduce(), but idArr is undefined.
I see that payload.idArr is defined in forwardManyToOneDescriptor() and Model.update().  However, my use case appears to be hitting the property setter defined in Model._initFields(), and THAT code path does not appear to be defining an "idArr" field on the payload.
Here's the current relevant definition of my model class:
class RouteLeg extends Model {
  static backend() {
    return {
      idAttribute : "legID"
    }
  }

  static get fields() {
    return {
      start : oneToOne("Node"),
      subpoints : many("Node"),
      checkState : oneToOne("CheckState")
    }
  }

  updateCheckState() {
    let childNodes = [this.start].concat(this.subpoints.objects());
    let nodeCheckStates = childNodes.map(nodeModel => nodeModel.checked);
    let newCheckState = determineCheckStateFromChildren(nodeCheckStates);

    // Crashes here
    this.checkState.value = newCheckState;
  }
}

Thanks for opening the issue! You got it right, the problem was in Model._initFields. Looks like it regressed after I changed the internal update action format from two update actions (update a single instance, update many instances) to a single one (update many instances).


OAuth - supported or not?

The limitations section of this documentation says that "OAuth isn't a supported authentication scheme with the on-premises data gateway."
However, this blog post:
https://powerbi.microsoft.com/en-us/blog/on-premises-data-gateway-october-update-is-now-available-2/
says that OAuth support was added in October 2018.
Does anyone know which is correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce758c1b-c94e-3fbb-2310-fa888c6640d8
Version Independent ID: 0c647a13-fd95-ae03-1a15-5f5da162091d
Content: Manage your data source - Import/scheduled refresh - Power BI
Content Source: powerbi-docs/service-gateway-enterprise-manage-scheduled-refresh.md
Service: powerbi
Sub-service: powerbi-gateways
GitHub Login: @mgblythe
Microsoft Alias: mblythe

Thanks for your comment, @Matthew-Lewis . We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

The term "shortly" is relative here :D

Thank you for submitting feedback on our documentation. This article has been recently updated and the referenced section no longer exists. If your feedback isn’t addressed, please feel free to submit additional feedback for the page.


Update memory-scroll.js

[[memory-scroll] Title: fix perPage]
Description
In listFor, when perPage is given after the first render, it is dismissed.

@GuenoleK to test


fix "File not found" when use relative uri path

when I exec:
tilelive-copy omnivore://./a.geojson mbtiles://./b.mbtiles

./a.geojson is resolved as /a.geojson, cause File not found

This is a obvious bug. Node-mbtiles have handle this edge case, check here: https://github.com/mapbox/node-mbtiles/blob/master/lib/mbtiles.js#L47-L51

This PR fails tests because the line it adds doesn't end with a semicolon.

fixed simicolon


support retail ThreeSlice

Our story begins with this stacktrace:
error: [string "SharedUIPanelTemplates.lua"]:1217: attempt to concatenate field 'atlasName' (a nil value)
stack traceback:
        ./wowless/api.lua:47: in function <./wowless/api.lua:45>
        [string "SharedUIPanelTemplates.lua"]:1217: in function 'GetLeftAtlasName'
        [string "SharedUIPanelTemplates.lua"]:1233: in function 'InitButton'
        [string "SharedUIPanelTemplates.lua"]:1330: in function '?'
        ./wowless/loader.lua:184: in function 'script'
        ./wowless/api.lua:59: in function <./wowless/api.lua:59>

The GetLeftAtlasName call looks like this:
ThreeSliceButtonMixin = CreateFromMixins(UIButtonMixin);
function ThreeSliceButtonMixin:GetLeftAtlasName()
	return self.atlasName.."-Left";
end

The InitButton call is happening via OnLoad of the controller.
-- Allows inheriting buttons to override OnLoad and OnShow
ButtonControllerMixin = {};
function ButtonControllerMixin:OnLoad()
	if self:GetParent().InitButton then
		self:GetParent():InitButton();
	end
end

The error is being triggered by the instantiation of AddonListCancelButton:
<Button name="$parentCancelButton" inherits="SharedButtonSmallTemplate" parentKey="CancelButton" text="CANCEL">

which is a
<Button name="SharedButtonSmallTemplate" inherits="BigRedThreeSliceButtonTemplate" virtual="true">

which is a
  <Button name="BigRedThreeSliceButtonTemplate" inherits="ThreeSliceButtonTemplate" virtual="true">
    <Size x="441" y="128"/>
    <KeyValues>
      <KeyValue key="atlasName" value="128-RedButton" type="string"/>
    </KeyValues>
    <PushedTextOffset x="-2" y="-1"/>
  </Button>

which is a
  <Button name="ThreeSliceButtonTemplate" mixin="ThreeSliceButtonMixin" motionScriptsWhileDisabled="true" virtual="true">
    <!--
    atlasName: The art kit to use for the 3 sections of the button.
            * The left textures will be "atlasName-Left", "atlasName-Left-Disabled" and "atlasName-Left-Pressed"
            * The right textures will be "atlasName-Right", "atlasName-Right-Disabled" and "atlasName-Right-Pressed"
            * The center textures will be "_atlasName-Center", "_atlasName-Disabled" and "_atlasName-Pressed"
            * The highlight texture will be "atlasName-Highlight"
    tooltip: This can be either a string or a function which returns a string

    <KeyValues>
      <KeyValue key="atlasName" value="128-RedButton" type="string"/>
      <KeyValue key="tooltip" value="MyTooltipFunction" type="global"/>
        or
      <KeyValue key="tooltip" value="REFRESH_BUTTON_TOOLTIP" type="string"/>
    </KeyValues>
    -->
    <Size x="20" y="20"/>
    <Layers>
      <Layer level="BACKGROUND">
        <Texture parentKey="Left">
          <Anchors>
            <Anchor point="TOPLEFT"/>
          </Anchors>
        </Texture>
        <Texture parentKey="Right">
          <Anchors>
            <Anchor point="TOPRIGHT"/>
          </Anchors>
        </Texture>
        <Texture parentKey="Center" horizTile="true">
          <Anchors>
            <Anchor point="TOPLEFT" relativeKey="$parent.Left" relativePoint="TOPRIGHT"/>
            <Anchor point="BOTTOMRIGHT" relativeKey="$parent.Right" relativePoint="BOTTOMLEFT"/>
          </Anchors>
        </Texture>
      </Layer>
    </Layers>
    <Frames>
      <Frame parentKey="Controller" mixin="ButtonControllerMixin">
        <Scripts>
          <OnLoad method="OnLoad"/>
          <OnShow method="OnShow"/>
        </Scripts>
      </Frame>
    </Frames>
    <Scripts>
      <OnMouseDown method="OnMouseDown"/>
      <OnMouseUp method="OnMouseUp"/>
      <OnShow method="UpdateButton"/>
      <OnDisable method="UpdateButton"/>
      <OnEnable method="UpdateButton"/>
      <OnEnter method="OnEnter"/>
      <OnLeave method="OnLeave"/>
      <OnSizeChanged method="UpdateScale"/>
    </Scripts>
  </Button>

which has the dependency on atlasName, the controller, and the mixin where this all started.
The problem appears to be that the controller's OnLoad is running after its parent, AddonListCancelButton, has had its mixins applied (which brings in InitButton) but before its parent has had all its keyvalues applied (which brings in atlasName). The controller's OnLoad should probably run after the keyvalues are applied. This means that the keyvalues, which live on BigRedThreeSliceButtonTemplate, need to be applied before the children of ThreeSliceButtonTemplate (from which it inherits) are built.
In summary it seems that certain frame children (like keyvalues) must be applied through the entire inheritance chain before others (like frames).

Meo confirms that "static stuff" needs to be applied before dealing with child frames.

fixed in 52b40a1132f749a7be068767c806d139e858190b


[WFLY-18743] Change NoAuditLogTestCase class to use the system default encoding to read the log file

https://issues.redhat.com/browse/WFLY-18743

Have we seen issues with this somewhere?

@jamezp Haven't found any issues of it for linux since UTF-8 is the default file encoding for it, but the test tends to fail for older versions of windows and also recently it started failing on CI (again for windows test runs) for jboss as per these issues issue1 and issue2

Thanks @Dkafetzis and @jamezp


Error running rule disallowParenthesisAroundArrowParam

The stack trace is below (this is the only instance of this issue in my entire Ember CLI app):
TypeError: Cannot read property 'type' of undefined
  at /samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/jscs/lib/rules/disallow-parentheses-around-arrow-param.js:62:59
  at Array.forEach (native)
  at Object.JsFile.iterateNodesByType (/samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/jscs/lib/js-file.js:488:42)
  at Object.module.exports.check (/samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/jscs/lib/rules/disallow-parentheses-around-arrow-param.js:57:14)
  at null.<anonymous> (/samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/jscs/lib/string-checker.js:165:22)
  at Array.forEach (native)
  at StringChecker._checkJsFile (/samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/jscs/lib/string-checker.js:161:31)
  at StringChecker.checkString (/samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/jscs/lib/string-checker.js:106:14)
  at JSCSFilter.processString (/samba/ember-workspace/csa/node_modules/broccoli-jscs/index.js:72:31)
  at /samba/ember-workspace/csa/node_modules/broccoli-jscs/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:33:42 at pods/account/controller.js :
  1 |import Ember from 'ember';

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26856680-error-running-rule-disallowparenthesisaroundarrowparam?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Thanks for the report @CrshOverride! This is the same as https://github.com/jscs-dev/node-jscs/issues/1754. I have a fix in master.
Sorry we haven't released yet, should be soon.


Issue with using function as className with react

I haven't dived into this yet, but wanted to see if you were aware of the issue, or if I'm just doing something incorrectly!
Given:
import React from 'react';
import { render } from 'react-dom';
import css from 'yocss';
import Hello from './Hello';

const styles = {
  fontFamily: 'sans-serif',
  textAlign: 'center',
};

const rootClassName = css(styles);

const App = () => (

    <Hello name="CodeSandbox" />

Start editing to see some magic happen {'\u2728'}

);

render(<App />, document.getElementById('root'));

I get

Warning: Invalid value for prop className on  tag. Either remove it from the element, or pass a string or number value to keep it in the DOM. For details, see https://fb.me/react-attribute-behavior
in div (created by App)
in App

I can manually call toString on the className function, but that doesn't jive with what's documented, so just wanted to make sure that was correct.
Here's a Code Sandbox demonstrating the issue. You'll note it should be a sans-serif font, and you're seeing serif. If you open up the full view, you can see the error in the console.
Also, unrelated, but I added this lib to the CSS in JS Playground, but I had to use the toString manual way :/
Thanks for a great library!

Yeah, that doesn't help. I was testing this with Preact, to be honest, and was wondering if this would trip anything else up and didn't have time to check.
I think I should revert that change to be a function and expose a different way to get the CSS string as the least friction way to use this is to return a class name.

Yeah, looks like Preact allows for a function as className (which is pretty cool!), but does not seem like that same approach will work with React :/

Released 0.3.0 that should fix your issue here! Please re-open if you're still having problems. Thanks!


fixed current region selection in AWS

https://github.com/crate/elasticsearch/commit/0c8a0ee395d2a980e48f680a7dced439208ced01

lgtm


Grunt Error on clean repo clone

Thanks for this demo ! The demo works but :
info: Starting app...
error: Grunt :: module.js:340
throw err;
      ^
Error: Cannot find module '/Users/philippe/Documents/workspace/even-more-passport/node_modules/sails/node_modules/grunt-cli/bin/grunt'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:906:3

Tried to re-install SailsJS and Grunt-Cl but it didn't do anything.

Can you please explain the steps you took? I am looking into the issue by cloning the repo and doing a fresh installation.

The accepted answer didn't work, but as the second answer point out :
"I had to go into my_project_directory/node_modules/sails and run npm install grunt-cli"

No error message now, thanks for the support !