📍 META: Redesign springwolf-ui: Feedback, Discussion & Participation

springwolf-ui is getting a new design, share your feedback and participate.
Check the latest demo at https://demo.springwolf.dev (by clicking the feature toggle in the toolbar header)
How to code

Clone this repository and go to the springwolf-ui folder
Install dependencies: npm ci
Start the ui: npm start
The ui is ready at http://localhost:4200 - including live refresh
Start changing code, i.e. the new sidebar is at springwolf-ui/src/app/components/new/sidenav

I think the new UI is very nice for quick navigation. What's mainly lacking is IMHO the very "clean/tidy" look of the old one. We are using it also to communicate with non-developer stakeholders, where this is not unimportant 😉
For example the current sidebar

in comparison to something like (spacing, auto-width, no line breaks, icon alignment)

Thank you @hirth-abi for the feedback.
I see the improvements in the second screenshot. In case these were code changes, do you mind putting them on an branch and opening a PR? i.e. the styling for the sidenav is located at springwolf-ui/src/app/components/new/sidenav
Regarding your users and stakeholders: you do you mainly think about spacing, etc. (clean/tidy) as in the sidebar or also a different way to present the information?

I've just hacked the changes in https://github.com/hirth-abi/springwolf-core/tree/css-playground but those are probably not clean and the auto-width does not really work, since I have too little CSS experience currently.
What would be also nice - for our way we use it - is a possibility to hide unused/empty sections. In the old UI the operation bindings were not visible by default (tab) which we don't use, and some information is basically clutter:

message binding is not used
content-type is always application/json, so redundant at each message
server is always the same, so redundant at each message

Sure @hirth-abi, can you open an enhancement issue for this feature request?
You are also very welcome to contribute this feature. Initial thought regarding implementation is a new endpoint that returns (validated) configuration (application.properties is mapped by Spring into SpringwolfConfigProperties.java). The ui queries the new endpoint - similar like the publishing functionality and shows/hides the parts in the ui.

@hirth-abi I opened an enhanchement issue in https://github.com/springwolf/springwolf-core/issues/1001 for your request.

As the ui is available for some time and the default now, I close this issue.
For any feature requests/issues/contributions/etc, please open a new issue


Fix count issue

change mapping into function-based interface
Pass counter in normal call
Replace count with count1

This fixes the the issue with count, I also replaced the other usages of vim.v.count I can remove the commit if it feels inappropriate to you.

Sorry for the late reply, I will merge.


Add null byte as hard context separator

Pull Request
Related issue
Fixes https://github.com/orgs/meilisearch/discussions/744
What does this PR do?
Adds \0 as context separator.
This allows one to use \0 as artificial separator, for example when concatting lots of small strings into a large string. See this discussion for context: https://github.com/orgs/meilisearch/discussions/744
PR checklist
Please check if your PR fulfills the following requirements:

[ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[ ] Have you read the contributing guidelines?
[ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Hello @LukasKalbertodt,
Thank you for your PR,
I just let you know that the CONTEXT_SEPARATOR list is a promoting list of the separator, which means that if we categorize a token as a separator AND this token is part of the CONTEXT_SEPARATOR list, then it will be considered a hard separator.
However, if the token is categorized as a separator first, it will never be promoted, even if it is part of the CONTEXT_SEPARATOR list.
If you want to consider \0 as a separator by default, you have to add it to the DEFAULT_SEPARATOR list as well!


Increased memory footprint using renderImage

Hello,
Does renderImage internally cache texture (in a texture pool)? Calling this function noticeably increases memory footprint, any best known method to avoid such memory use?
Thanks.

Yes. And you can call MTIContex.reclaimResources() after render.
If you are rendering images in a tight loop, e.g. a for loop, you'll need to wait for each render or you may end up queuing too much job on the GPU.
for .... {
    let image = filter.outputImage
    var cgImage: CGImage?
    let task = context.startTask(toCreate: &cgImage, from: image, sRGB: false)
    task.waitUntilCompleted()
    context.reclaimResources()
    ....
}

Thanks much @YuAo.
This might be a feature request. To avoid starving GPU, is it better to create an async call that allows reclaim resource at complete?

No, you do not need to wait for the GPU to reclaim resources. The reclaimResources call can be before the waitUntilCompleted call. They have the same effect. Because the GPU also tracks the usage of the resources.
And there is an optional asynchronouscompletion block parameter in the startTask... method.


Bump cri-tools to v1.0.0-beta.0

/assign @Random-Liu

LGTM with one comment. Feel free to self apply the label and merge after you address the comment.

/lgtm


Link to clarify DTUs vs vCores

It will be useful at the top of the article to add link https://docs.microsoft.com/en-us/azure/sql-database/sql-database-service-tiers  to clarify DTUs vs vCores

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94c33577-a694-bd91-d0fa-791ff3cbee13
Version Independent ID: 449ad3ed-7959-aca2-07aa-e4e43d333ec7
Content: Azure SQL Database DTU-based resource limits single databases
Content Source: articles/sql-database/sql-database-dtu-resource-limits-single-databases.md
Service: sql-database
GitHub Login: @sachinpMSFT
Microsoft Alias: sachinp

@MNF
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Fixed and merged. Thanks for the input @MNF
Carl

#please-close


Curl proxy configuration is not used by Httpful

Hi.
We are using Httpful library to do some REST requests. All of them are to other internal systems in the same network so those request does not require the use of a proxy.
Now, we need to do a request to a system that requires the proxy. This proxy has been set into the $HTTPS_PROXY  environment variable and using curl all is working fine.
The problem is that Httpful is not working, the response is "Unable to connect to *************** : 56 Received HTTP code 400 from proxy after CONNECT"
We have also tried to set the proxy with useProxy function but the result is the same.
Could you help us?

The version we are using is 0.2.19.


Implement support of chrome.certificateProvider.requestPin in the C++ client example

A new Chrome extensions API was added recently that provides a standard way to request PIN: http://crbug.com/612884 . Apart from providing a way to run a system-styled dialog, the API can be used in environments where otherwise UI is disallowed - e.g. the Chrome OS login screen.
We need to add support of this new API into the C++ client example that we provide, so that the middleware developers can adopt the new API faster.
Note that the required change is not just a trivial function renaming. The new API has more possibilities (e.g. showing an error message, keeping the dialog during PIN processing, repeating the request in the same dialog). And, what is more important, the API has a new requirement: a request ID from certificateProvider.SignRequest has to be passed when requesting a PIN (and this is the required parameter).
/cc @dskaram

Was done in pull request #76.


feat(golang): introduce Golang code generation

A new Golang code generation handler was added. It is a very early
work-in-progress. Further development should happen mostly within
lib/targets/golang, adding new classes and completing the emit
handler to handle the element types.
Disclaimer: some of the currently generated code may not be valid Go...
Relates to #83

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 75988da046b51e43d0871260e21b66184e89a13e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: ffbaf86b117ccf74c0555c46298a629507c144c0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 48337aec3612975d81a0038626b0633c4eed4e3c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 4e8977c1bddf0dca595ca6167a4dd3595639a7a2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 20f1e88181b6cb629783b9c269c858366d7b97cd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID:<PHONE_NUMBER>f1657d89ef1ea61ca61b2215161afd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: e311dcd9543aff2153480741b29d827ff0cd0121
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 3f269972c16ea650b9e06e64c8fe932e6fdabaa1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: a5f7a054f6427bbbc05841da08b00cdef5ff8d8f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 871a768e185ece2f702b39d73d4f7814fde5c709
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: ad0487818a9ab6a9003e887fb8925d52f671865c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: ef1a36b549f5364ccea720b78771be9baee31ef9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 99b0aea4758ca32869acf332b146c7184375958c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 344be72820f224dfb7b25d8f0c48fb364a535fd3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: cf6927d2167a0330cad50f352ab848b44b930bd0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 9f1583b3aa6ade5f74fee81058e33314d2de5a58
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: beff382f7938e9249d2bf98c1ce0e435ab507593
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 6e26d1ca51e66153d99edb61de9bb8320fa532e1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: abb52ec236b0cb20c05bc8c2bab6477df24d07e9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 0b18bcaba44470a5902c7b853b0a66396a48a39e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 20ab90cb60df3fd7fadd18144f71c1f280928f15
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: d5f0e917f87ac88f6bc98718316ac2ec034766eb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 61dc2f2fb6d623a8f05f999a9b4adb001363a11f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: cfe43085950bf564153daaafa568d03149b6967a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 98d1838a7ea36170a83a5d099552bfa22816f9fe
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 6a8ff76d1a0693b06aa0027d9136bb8c3ab0c188
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 4997976c9313d955097beda19261b465c53ecc5c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 572f1514c8cc67c075f0cf807510b02e3ea728d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 20043852a1088703582607bbe47bc2fb4c3a5238
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: cc350c19ccb4e9777649a30a1287e18a42a4920c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 2234cb172d17f5f4d3edb85e32d99c91a5e83a39
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 4784aa8823ceeff945b35507097f1b2909725ede
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 1b6baafd560efd33b90188db9bc02de679097dbd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 34ca6ef20d7c5aab87055490192fa609cc60bbcd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: cc389416787a614585e0e284069928af203f3e65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 917fac91ecbf6d09b63e61c6dcbc36a8a5dba271
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 0e2102168a2b78fa618eb41aa70bb27dc71c421a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 4238e2a5a0efea2f066459b3c2e8d36535dbd4f6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 541d7140d6b10f060beadb60834a57e5122aa98c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Implemented basic route planing

I implemented basic route planing functionality as described in issue #5 .
Closes #5

Cool!
 That could be easily 100+ lines and not readable anymore. Could you eventually print the individual nodes instead?

Thanks for your feedback! So you mean I should not print the stops?

Okay, I think I understand what you mean. I will fix it in the evening.


[Run-Plugin] Divide into parse and convert

Summary of the Pull Request
What is this about:
Parse and convert logic was not divided well enough. Also, there was access to elements of an array(e.g. split[3]). Obviously, it is not a robust solution and will be probably hard to maintain.
What is include in the PR:

Divide convert and parse logic. Added ConvertModel as an intermediate structure between parse and convert
Updated tests. Added negative cases

How does someone test / validate:

Test allowed conversions

Quality Checklist

[ ] Linked issue: #xxx
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

@ThiefZero
I moved the code around a little bit. Any concerns?
Also, it is a good idea to test only InputInterpreter.Parse and UnitHandler.Convert all other methods in InputInterpreter and UnitHandler should be private and not tested as it's implementation details and something that is going to change often. Feel free to pick it up. Anyway, I think we can merge microsoft:user/ThiefZero/unitConversion into master without it.


Replace bincover with built-in Go coverage profiling tool

This PR makes the shift from the deprecated bincover package to Golang built-in coverage profiling tool.

@antoninbas Is it fine if I add more commits to a PR or should one PR be only one commit?

@antoninbas Is it fine if I add more commits to a PR or should one PR be only one commit?

it's better if you add a new commit for each review cycle, then squash all commits at the very end

@antoninbas flow-aggregator images build are failing: https://github.com/antrea-io/antrea/actions/runs/8301256864/job/22720993922?pr=6090#step:3:30
I don't understand why pull access would be denied.

@antoninbas flow-aggregator images build are failing: https://github.com/antrea-io/antrea/actions/runs/8301256864/job/22720993922?pr=6090#step:3:30
I don't understand why pull access would be denied.

antrea-build is an intermediate build image that doesn't exist outside of the build process. I think you meant to use flow-aggregator-build there.

What is the use of this function? I don't think any coverage files are being written there.

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

@antoninbas I made a fix in the yaml files, can you run the mc test again?

/test-multicluster-e2e

/test-multicluster-e2e

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-kind-ipv6-all
/test-kind-ipv6-only-all
/test-vm-e2e

/test-e2e
/test-conformance

/test-kind-ipv6-conformance
/test-kind-ipv6-networkpolicy

/test-kind-ipv6-conformance

@shikharish There was a failure for test-e2e:
I0509 01:02:38.404207 3997474 framework.go:2650] Sending SIGINT to 'antrea-controller-coverage'
I0509 01:02:38.442389 3997474 framework.go:2656] Copying coverage files from Pod 'antrea-controller-69fcfb59c6-vrmzc'
I0509 01:02:38.480172 3997474 framework.go:2801] Copying file: covmeta.a1399e60736fc7fe1549a02ca9db368d
I0509 01:02:38.517180 3997474 framework.go:2801] Copying file: covcounters.a1399e60736fc7fe1549a02ca9db368d.7.1715216558441681329
I0509 01:02:38.603880 3997474 framework.go:2650] Sending SIGINT to 'antrea-agent-coverage'
I0509 01:02:38.646002 3997474 framework.go:2656] Copying coverage files from Pod 'antrea-agent-dks7w'
I0509 01:02:38.688258 3997474 framework.go:2801] Copying file: covcounters.1f1c9ccedabce8e7cede1b046270cea0.7.1715216558648518891
I0509 01:02:38.733519 3997474 framework.go:2801] Copying file: covmeta.1f1c9ccedabce8e7cede1b046270cea0
I0509 01:02:38.814148 3997474 framework.go:2650] Sending SIGINT to 'antrea-agent-coverage'
I0509 01:02:38.856019 3997474 framework.go:2656] Copying coverage files from Pod 'antrea-agent-p7kv7'
I0509 01:02:38.895236 3997474 framework.go:2801] Copying file: covmeta.1f1c9ccedabce8e7cede1b046270cea0
I0509 01:02:38.939382 3997474 framework.go:2801] Copying file: covcounters.1f1c9ccedabce8e7cede1b046270cea0.7.1715216558853888561
I0509 01:02:39.017115 3997474 framework.go:2650] Sending SIGINT to 'antrea-agent-coverage'
I0509 01:02:39.062101 3997474 framework.go:2656] Copying coverage files from Pod 'antrea-agent-tmgf6'
I0509 01:02:39.101936 3997474 framework.go:2801] Copying file: covcounters.1f1c9ccedabce8e7cede1b046270cea0.7.1715216559068671262
I0509 01:02:39.141413 3997474 framework.go:2801] Copying file: covmeta.1f1c9ccedabce8e7cede1b046270cea0
I0509 01:02:39.181917 3997474 framework.go:2750] Copying coverage files from Node: jenkins-antrea-e2e-for-pull-request-2796-w8n4r
I0509 01:02:39.653446 3997474 framework.go:2835] Copying file: covcounters.3422adf0c3cf821515e34c70b6862df6.63.1715213900486935592
2024/05/09 01:02:39 Error when collecting antctl coverage files from control-plane Node: error when copying coverage files for antctl from Node 'jenkins-antrea-e2e-for-pull-request-2796-w8n4r' to coverage directory '/var/lib/jenkins/workspace/antrea-e2e-for-pull-request/e2e-coverage/jenkins-antrea-e2e-for-pull-request-2796-w8n4r-coverage': cannot retrieve content of file 'covcounters.3422adf0c3cf821515e34c70b6862df6.63.1715213900486935592' from Node 'jenkins-antrea-e2e-for-pull-request-2796-w8n4r', stderr: <cat: covcounters.3422adf0c3cf821515e34c70b6862df6.63.1715213900486935592: No such file or directory
>, err: <<nil>>
FAIL	antrea.io/antrea/test/e2e	2692.437s
FAIL
=== TEST FAILURE !!! ===

@luolanzone would that be related to the changes to ci/jenkins/test-vmc.sh?

@antoninbas The error is not from the test-vmc.sh script. I have made a small change which I think should fix the issue.

/test-e2e

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-kind-ipv6-all
/test-kind-ipv6-only-all
/test-vm-e2e

/test-kind-ipv6-conformance
/test-kind-ipv6-only-e2e
/test-vm-e2e

/test-kind-ipv6-only-e2e

@luolanzone Is the coverage number (74.24%) as expected?

@luolanzone Is the coverage number (74.24%) as expected?

Yeah, the result looks good.  I checked the coverage trend chart in this page https://app.codecov.io/gh/antrea-io/antrea, it's around 74%.

@shikharish Things are good on the testing side. Can you push a new commit to fix the merge conflict? After that, we should be good to merge.

/test-all

/test-multicluster-e2e

@luolanzone The coverage on my branch is around 65%, significantly less that that of the main branch. https://app.codecov.io/gh/antrea-io/antrea/tree/remove-bincover

Oh it increased to 72% with the latest commit.

@antoninbas The tests still failed but this time due to TestConnectivity/testOVSRestartSameNode.

@antoninbas The tests still failed but this time due to TestConnectivity/testOVSRestartSameNode.

So I would not worry about this failure. I don't think it was introduced by this PR. As a matter of fact I was able to reproduce with the latest Antrea release (v2.0). I tried several combinations and I was able to reproduce in each case:

using your PR, with -coverage=true
using your PR, with -coverage=false
using Antrea v2.0, with -coverage=true

I think that the previous version of the coverage image had some issue, and the Pod was probably taking a few seconds to terminate. It seems that it may have had an impact on the outcome of the test, but I have to dig deeper. Given that in CI we only run the test with coverage enabled, we could have missed the issue. My suggestion would be to skip the test for now, so that it doesn't block this PR. You can add the following at the beginning of the sub-test: t.Skip("Skipping test for now as it fails consistently"), and I will investigate more later.

/test-all
/test-multicluster-e2e

/test-windows-containerd-e2e

Thanks for your hard work @shikharish and congrats on getting this PR merged!


Cache results of allSoftwareVersions and friends

See suggestion from CW and @belforte here: https://hypernews.cern.ch/HyperNews/CMS/get/crabDevelopment/2222/1/2.html

Doing a little bit of cleaning in WMCore (I am checking the ticket I opened). This is not needed anymore since we decided to skip the check of software versions if the function fails: https://github.com/dmwm/CRABServer/blob/5caac0d379f5e4522f026eeaf3621f7eb5ced98e/src/python/CRABInterface/RESTUserWorkflow.py#L241-L246


Ensure auth provider can find multiclusterapp member's principal

A user could have turned on external auth and added some user from that external auth
provider as a member of a multiclusterapp. After this when user logs back in as local
user, searching and adding new members from the external auth provider to the existing
multiclusterapp will fail. But even upgrading the multiclusterapp is failing, because
during upgrade, there is a call to getPrincipal of the members and set their displayNames
This call can be skipped if the current auth provider found in token is for local auth,
whereas the principalIDs of the members are from an external auth provider
Addresses: https://github.com/rancher/rancher/issues/18252

LGTM


Is this library still maintained or do I need to switch to Dialogflow API: Node.js Client?

I've been researching this library for a while and I'm not sure if I can launch it in production without the certainty that it won't stop working?
I've been doing tests with the In-line Editor on DialogFlow but I realized that when I changed the Cloud Functions the version from Node 8 to Node 10, because Firebase says that the support for Node 8 will end, I thought about changing the version, however I had a lot of problems when doing Deploy in the In-line Editor so I thought if the problem of the library itself that still uses Node 6 in package.json?

I would love to know this too.

What alternatives are there?
Do you suspect using the JSON workflow will be better?


flutter build bundle only one bundle can exist at a time

Split of https://github.com/flutter/flutter/issues/41352#issuecomment-537709454
I make heavy uses of build bundle and have found out an issue that appears on Flutter 1.10.7-pre.123  and leads to the same "could not resolve the kernel binary" error.
This issue appears when using the --asset-dir flag.
flutter version:
Flutter 1.10.7-pre.123 • channel master • http://github.com/flutter/flutter
Framework • revision bedf46d06e (6 minutes ago) • 2019-10-02 15:21:45 -0700
Engine • revision aa8fcbb652
Tools • Dart 2.6.0 (build 2.6.0-dev.4.0 98b286de21)

Steps to reproduce:
$ flutter build bundle --asset-dir /tmp/test
$ tree /tmp/test # looks good
/tmp/test
├── AssetManifest.json
├── FontManifest.json
├── isolate_snapshot_data
├── kernel_blob.bin
├── LICENSE
├── packages
│   └── cupertino_icons
│       └── assets
│           └── CupertinoIcons.ttf
└── vm_snapshot_data
$ flutter build bundle --asset-dir /tmp/test2
$ tree /tmp/test2 # also looks good
/tmp/test2
├── AssetManifest.json
├── FontManifest.json
├── isolate_snapshot_data
├── kernel_blob.bin
├── LICENSE
├── packages
│   └── cupertino_icons
│       └── assets
│           └── CupertinoIcons.ttf
└── vm_snapshot_data
# BUT
$ tree /tmp/test # gets deleted
/tmp/test
└── packages
    └── cupertino_icons
        └── assets

Pinging @jonahwilliams as I think it is related to tooling.

The default behavior of assemble is to clean outputs from old builds automatically, provided it thinks they are the same build. In this case, changing the output directory should likely qualify as a "different build" so they should not be deleted. It should be straightforward to update the rules so that output-dir is treated as an input


Gazebo crashes in specific worlds

Environment

OS Version:Ubuntu 20.04
Source or binary build:Tried Fortress source and binary and Citadel source
Rendering plugin: [ogre2]- ogre2.log

Running on a dual GPU machine (integrated GPU(Radeon™ Vega graphics) + discrete GPU(VIDIA® GeForce® GTX 1650 (4 GB GDDR6 dedicated)
Rendering system info: https://user-images.githubusercontent.com/78502324/156880698-327a3da2-bbf5-443b-8dad-413a81b94e2d.png
Description-
I source build igniton fortress and it works fine in simple worlds but crashes with models and complex worlds like auv_controls.sdf.I also tried citadel source build and faced same error.Then I tried binary build with docker and it worked but when I source something from my main os into docker and then try to run same world crashes(same error).I thought it could be clashing with some of my libraries hence I reinstalled Ubuntu and tried it in clean OS but faced same error.I have been facing this error from a good many days and I tried asking it on http://answers.gazebosim.org  but got no reply. Any help will be much appreciated
Steps to reproduce
 ign gazebo auv_controls.sdf
Output-

Complete Log-
ign gazebo auv_controls.sdf -v4.log

Hey Harsh which version of GCC are you using. This looks like an issue with the verable std::filesystem . Looks similar to ://github.com/ignition-tooling/release-tools/issues/639

Hey, @arjo129 I am using gcc (Ubuntu 8.4.0-3ubuntu2) 8.4.0.
Also I tried changes you did in https://github.com/ignitionrobotics/ign-gazebo/pull/1346 and https://github.com/ignitionrobotics/ign-common/pull/312 but insted of  https://github.com/ignitionrobotics/ign-common/blob/9d0b0683030b96b7042d46de491aa1171693a9ed/src/Filesystem.cc#L77 I used
 if (ignition::common::absPath(_path)==_path)
   return false;
 else
   return true;

as std::filesystem is not used here in ignition fortress and everything works.Thanks for the help

You might want to use GCC 9 for everything then the std::filesystem issue should go away without code changes.


Is navigation feasible using D435i & T265 together,  without wheel encoders.

I am working with a 4 wheeled skid-steered rover which has no wheel encoders available.
The T265 section of the ros/realsense front page has the following notice:
"Important Notice: For wheeled robots, odometer input is a requirement for robust and accurate tracking."
https://github.com/IntelRealSense/realsense-ros#using-t265
Is the above still relevant in the case of using D435i & T265 together, rather than a single T265 camera?
I am trying determine if I can avoid the installation of wheel encoders which may be very difficult to setup on my platform.

It is really hard to give a definite answer for that, since it depends on your requirements. From my experiences it is surely possible to achieve "pedestrian navigation" out of the box with a certainty of +-50cm indoors in an  area of 100 x 100 m. But even this depends on a lot of parameters: Number of features, lighting conditions, quality of mapping. But I would give it a try. I'm not even using a D435 as companion device; I'm just playing around with the T265 and I'm not too disappointed for now. I would encourage you to try by yourself with a stand-alone T265 first in order to see, if it meets your requirements.

Just to add a bit to what @neilyoung said.   If your platform doesn't have a lot of vibrations and can avoid passing jolts from the ground to the T265, then you might be able to get away without wheel encoders.  The setup is significantly easier without them.


Un-pub the writer module and expose InflateWriter

This small patch just exposes InflateWriter on top-level instead of exposing the the writer module as suggest by @nwin in #12.

Thank you. 🙂


[x86] Changes to executable not updating in ghidra

Describe the bug
I have made some simple c programs to test this. But it seems when I import the same executable after I change a parameter and recompile it's not reflected in the analysis.
To Reproduce
Steps to reproduce the behavior:

Import executable and analyze in code browser

Take note of a function you're about to change

Exit out of code browser
Go to program and add parameter recompile a before
Import executable again and analyze

Take note of the same function as before

Expected behavior
Changes should be reflected in the new import
Screenshots
Before Change

Imported file after recompilation

After change analysis

Environment (please complete the following information):

OS: Ubuntu 16.04.6 VM on macOS10.14.5
Java Version: 12.0.2
Ghidra Version:  9.0

Additional context
I'm wondering if there's some sort of cache or preference to toggle. Has this been mentioned before at all?  any ideas why this is happening?

Could you do another test where you change the name of the function to see if the new version still has only one parameter but the new name?  That will help to narrow down the problem.

Sure thing!
So here's I changed the name of the function above from toggle_lsb to just toggle.

And here I imported it after recompilation.

it doesn't seem to reflect the change

Can you try using your 2nd parameter in the function (in a meaningful way)?  It might be optimizing it out.

Adding a function parameter which is never used will not be reflected in the decompiler auto-generated function signature.  The decompiler is limited to parameter detection based upon data flow analysis.  Alternatively, in the presence of debug information (e.g., DWARF, PDB) or mangled function names, analysis may be able to establish a function signature from such data.

Not sure what you mean by "meaningful" since it is a relative and subjective term.
So here I didn't change the function signature but incremented the second parameter:

Notice it doesn't seem to show the new change. But again, I recompiled it and imported it as a new file Though the function does get called by another function which then is called in main.
Then I decided to change the return type, hence, changing the function signature and then it seems to reflect.

I appreciate the detailed description @ghidra1  .


husky updated to 7.0.4

.husky/.gitkeep to provide Node 8 support and avoid error
ENOENT: no such file or directory, mkdir '.husky/_'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>prepare: `husky install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@yurloc my fault!

both hooks (pre-commit and pre-push) created
.gitignore changes reverted
package.json adapted


Feature request - OATH Authentication

This issue was originally filed by<EMAIL_ADDRESS>
I'm looking for a package/library for OATH. Ideally the library should support multiply services e.g Facebook, Google Accounts, Twitter, etc.
The library should at least support desktop an mobile devices e.g. redirect a mobile user to m.facebook.com/dialog/oauth and a desktop user to www.facebook.com/dialog/oauth
Ideally a functionality like meteor's accounts where you do something like "import accounts-facebook" then put {{loginButtons}} in your template and you are good to go would be great.

Search seems to be working now.


Adding youtube channel and twitter account to SoS homepage

Now that we have a yutube channel and twitter account for SoS, we should add their icons to SoS homepage.

No way to get a customized URL to youtube channel before we get 100 subscribers (see this.

Done. No customized URL but a general URL is available.


[ios] Datadog SDK usage error: Datadog.initialize() must be called prior to Logger.builder.build().

Thanks for taking the time for reporting an issue!
Describe what happened
Upgraded Flutter from 3.3.10 to 3.7.0 after which upgraded datadog_flutter_plugin: ^1.2.1 and ran our app. Android version runs fine, ios version throws the following exception
Datadog SDK usage error: `Datadog.initialize()` must be called prior to `Logger.builder.build()`.

Steps to reproduce the issue:
I think just using latest flutter 3.7.0 and latest datadog version 1.2.1 should be able to reproduce the exception shown above.
Describe what you expected:
Luckily its a non app boot blocker, but ideally no exception would be thrown so that the logger can send the logs over to datadog servers.
Additional context

Dart/Flutter version: 3.7.0
Android/iOS OS version: io16
Device Model: iphone 14 pro
Datadog SDK version: 1.2.1

@bgenidy I can't reproduce this with a simple case -- can you send over your initialization code so I can take a closer look?
Just so I can judge severity, are you seeing logs get dropped or not sent to Datadog? Or are just getting the warning?

Hi @fuzzybinary this is what my init code looks like
WidgetsFlutterBinding.ensureInitialized();
  await environmentSettings.initialize();
  await setupDataDog();

...

Future<void> setupDataDog() async {
  final originalOnError = FlutterError.onError;
  FlutterError.onError = (details) {
    FlutterError.presentError(details);
    DatadogSdk.instance.rum?.handleFlutterError(details);
    originalOnError?.call(details);
  };

  await DatadogSdk.instance.initialize(loggerConfiguration);
}

It also repros when using await DatadogSdk.runApp
It only happens during app startup but subsequent logs get collected fine, and given it happens twice or so, it seems like just the bootup code for iOS might be calling logger once or twice a bit earlier in the flow.
(FYI Im using an emulator iOS 16 not an actual device)

Do you have any code that attempts to create loggers using DatadogSdk.createLogger? Something that maybe isn't waiting for initialization to complete?
"Failed to build Logger" definitely comes  from the Flutter side, so I'm worried there some race condition where some of your created loggers are not being created properly.

@fuzzybinary I stepped through the code and I think I have a small piece of code that has consistent repro for you
import 'package:path_provider/path_provider.dart';
import 'package:datadog_flutter_plugin/datadog_flutter_plugin.dart';

Future main() async {
  WidgetsFlutterBinding.ensureInitialized();
  final originalOnError = FlutterError.onError;
  FlutterError.onError = (details) {
    FlutterError.presentError(details);
    DatadogSdk.instance.rum?.handleFlutterError(details);
    originalOnError?.call(details);
  };

  await DatadogSdk.instance.initialize(loggerConfiguration);
  await getApplicationDocumentsDirectory();
}

It only happens on iOS (Android is fine). I was able to repro on datadog 1.1.1 package so it doesn't seem like its a recent change of code on datadog sdk side that would have caused it. Subsequent calls to getApplicationDocumentsDirectory() does not throw that exception so it might be the first call or so that causes this to happen.
Haven't dug too deep inside the path provider code to see where exactly this is happening, but I suspect it might have to do with some method call that datadog is trying to intercept that causes the issue.

I still can't reproduce with this example (at least on the iOS 16.2 simulator).  Here's my full main with v1.2.1
void main() async {
  DatadogSdk.instance.sdkVerbosity = Verbosity.verbose;

  final datadogConfig = DdSdkConfiguration(
    clientToken: '<redacted>',
    env: 'prod',
    trackingConsent: TrackingConsent.granted,
    site: DatadogSite.us1,
    loggingConfiguration: LoggingConfiguration(
      sendLogsToDatadog: true,
      printLogsToConsole: true,
    ),
    rumConfiguration: RumConfiguration(
      applicationId: '<redacted>',
    ),
  )..enableHttpTracking();

  WidgetsFlutterBinding.ensureInitialized();
  final originalOnError = FlutterError.onError;
  FlutterError.onError = (details) {
    FlutterError.presentError(details);
    DatadogSdk.instance.rum?.handleFlutterError(details);
    originalOnError?.call(details);
  };

  await DatadogSdk.instance.initialize(datadogConfig);
  final directory = await getApplicationDocumentsDirectory();
  DatadogSdk.instance.logs?.info('Directory is ${directory.path}');

  runApp(const MyApp());
}

That error message should really only come from a call to DatadogSdk.createLogger. If you can you may want to temporarily turn on package debugging (In in VS Code it's under User Settings → Extensions → Dart → Run and Debug) and put a breakpoint on in that method (around datadog_flutter_plugin.dart:219). Then see if anything is calling it before initialize does.

@fuzzybinary can you see if it works with the following configuration (locally I don't send info to DataDog). I just copied the above code you have and swapped the configuration to the one shown below in a new hello world flutter project created using flutter 3.7
final datadogConfig = DdSdkConfiguration(
    env: 'local',
    trackingConsent: TrackingConsent.granted,
    site: DatadogSite.us1,
    loggingConfiguration: LoggingConfiguration(
      sendLogsToDatadog: false,
      printLogsToConsole: true,
    ),
    clientToken: '',
  )..enableHttpTracking();

@bgenidy Yes, I can duplicate now. There's an error message that's being printed to the XCode console during initialization that you're not seeing because of some late biding to the Flutter console:
🔥 Datadog SDK usage error: `clientToken` cannot be empty.

Even if you're not sending to Datadog, you should still supply your client token, or a least a good fake.
I'll fix the timing of the console binding so this error gets printed properly.
Thanks for the report!

Thanks @fuzzybinary much appreciated!


Move from Util::Mem to ByteOrder

Ughhhhhhh, fine, I'll do it.

This now completely resolves issue #135 .


GOV.UK Frontend v5.0

Testing currently blocked by https://github.com/surevine/govuk-frontend-diff/pull/97 and ongoing discussions on https://github.com/alphagov/govuk-frontend/discussions/4389


Illuminate\Foundation\Testing\TestResponse::assertJsonFragment(array $data) not working correctly.

Laravel Version: 5.5.14
PHP Version: 7.1.8

Description:
Illuminate\Foundation\Testing\TestResponse::assertJsonFragment(array $data) not working correctly.
My guess is, that the Illuminate\Support\Arr::sortRecursive($array) not really sorting revcursive.
I think the sort is wrong, because if you look at the error message, the properties of the created_at field are NOT in the same order in the fragment and the response JSON, that is why the assertJsonFragment method's substr cannot find the fragment JSON string in the reponse content JSON.
Steps To Reproduce:
Response JSON:
{
  "data": [
    {
      "id": 1,
      "name": "Dillon Moen",
      "email"<EMAIL_ADDRESS>      "phone": "(209) 977-2469 x650",
      "role": [
        {
          "id": 3,
          "name": "\u00c1ldoztat\u00f3"
        },
        {
          "id": 4,
          "name": "Pap"
        },
        {
          "id": 2,
          "name": "Beteg-l\u00e1togat\u00f3"
        }
      ],
      "created_at": {
        "date": "2017-11-26 13:58:37.000000",
        "timezone_type": 3,
        "timezone": "UTC"
      },
      "updated_at": {
        "date": "2017-11-26 13:58:37.000000",
        "timezone_type": 3,
        "timezone": "UTC"
      }
    },
    {
      "id": 2,
      "name": "Helmer Little",
      "email"<EMAIL_ADDRESS>      "phone": "(480) 464-6620 x1155",
      "role": [
        {
          "id": 4,
          "name": "Pap"
        }
      ],
      "created_at": {
        "date": "2017-11-26 13:58:37.000000",
        "timezone_type": 3,
        "timezone": "UTC"
      },
      "updated_at": {
        "date": "2017-11-26 13:58:37.000000",
        "timezone_type": 3,
        "timezone": "UTC"
      }
    }
  ],
  "links": {
    "first": "http:\/\/localhost\/api\/v1\/user?page=1",
    "last": "http:\/\/localhost\/api\/v1\/user?page=1",
    "prev": null,
    "next": null
  },
  "meta": {
    "current_page": 1,
    "from": 1,
    "last_page": 1,
    "path": "http:\/\/localhost\/api\/v1\/user",
    "per_page": 10,
    "to": 2,
    "total": 2
  }
}

JSON fragment:
{
  "id": 1,
  "name": "Dillon Moen",
  "email"<EMAIL_ADDRESS>  "phone": "(209) 977-2469 x650",
  "role": [
    {
      "id": 3,
      "name": "\u00c1ldoztat\u00f3"
    },
    {
      "id": 4,
      "name": "Pap"
    },
    {
      "id": 2,
      "name": "Beteg-l\u00e1togat\u00f3"
    }
  ],
  "created_at": {
    "date": "2017-11-26 13:58:37.000000",
    "timezone_type": 3,
    "timezone": "UTC"
  },
  "updated_at": {
    "date": "2017-11-26 13:58:37.000000",
    "timezone_type": 3,
    "timezone": "UTC"
  }
}

Fail message:
Unable to find JSON fragment:

["created_at":{"date":"2017-11-26 14:00:01.000000","timezone_type":3,"timezone":"UTC"}]

within

[{"data":[{"created_at":{"date":"2017-11-26 14:00:01.000000","timezone":"UTC","timezone_type":3},"email":"hettinger.harmony@example.com","id":2,"name":"Mrs. Ebony McCullough","phone":"1-802-513-1580 x93652","role":[{"id":1,"name":"K\u00e9relmez\u0151"},{"id":4,"name":"Pap"},{"id":5,"name":"Diszp\u00e9cser"}],"updated_at":{"date":"2017-11-26 14:00:01.000000","timezone":"UTC","timezone_type":3}},{"created_at":{"date":"2017-11-26 14:00:01.000000","timezone":"UTC","timezone_type":3},"email":"macejkovic.dante@example.org","id":1,"name":"Danial Walker","phone":"+1.534.674.8264","role":[{"id":5,"name":"Diszp\u00e9cser"}],"updated_at":{"date":"2017-11-26 14:00:01.000000","timezone":"UTC","timezone_type":3}}],"links":{"first":"http:\/\/localhost\/api\/v1\/user?page=1","last":"http:\/\/localhost\/api\/v1\/user?page=1","next":null,"prev":null},"meta":{"current_page":1,"from":1,"last_page":1,"path":"http:\/\/localhost\/api\/v1\/user","per_page":10,"to":2,"total":2}}].
Failed asserting that false is true.

Running Arr::sortRecursive on your fragment seems can parse to right array.
Can you provide your test case code?


[FEATURE] Diffrent calcs and settings (for ca) if you..

i think that having some settings changed for diffrent healthes in ca would be nice and unique
phobos ca is known to have the most amount of setting and i belive this setting could help on some situitations
Also PLEASE add descriptions for BowKiller settings

You could try override place and break

You could try override place and break

i made another issue about override place where it just keeps multiplacing while calculating a pos without reaching maxselfplace value which sucks
also its not costumizeable

ok zane2b2t


Filtering with by ignores the group by condition

Creating a blaze expression that filters with by omits the GROUP BY in the final expression.
Example:
create table orders (
    id integer primary key,
    product text,
    timestamp time
);

>>> from blaze import data, by, compute
>>> url = "postgresql:///testdb"
>>> db= data(url)
>>> orders = db['orders']

pairs = by(orders['product'], max_timestamp=orders['timestamp'].max())

# computing the above produces the following sql
SELECT orders.product, max(orders.timestamp) as max_timestamp
FROM orders
GROUP BY orders.dataset limit 10001

expression = orders[(orders['product'] == pairs['product']) & (orders['timestamp'] == pairs['max_timestamp'])]

# computing the above produces the following sql
SELECT orders.id, orders.product, orders.timestamp FROM orders
WHERE orders.product =  orders.product
AND  orders.timestamp = max(orders.timestamp) limit 10001

^ GROUP BY is missing above

from blaze import data, by, compute, Symbol
from odo import discover
from odo.backends.sql import SQL
url = "postgresql:///testdb"
db = data(url)
orders = db['orders']
pairs = by(orders['product'], max_timestamp=orders['timestamp'].max())
Explicitly define a Symbol to reference the 'pairs' result
pairs_symbol = Symbol(pairs, discover(pairs))
Create a filtering expression using the pairs_symbol
expression = orders[
(orders['product'] == pairs_symbol['product']) &
(orders['timestamp'] == pairs_symbol['max_timestamp'])
]
Compute the result using SQL backend
result = compute(expression, SQL(url, compute=False))
Display the result
print(result)


dragon-prince-fanmade

This is a fan made sheet for the upcoming Cortex Prime game set in the Dragon Prince universe. It will support play of the test material as well as sandbox play.
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.
There is one new sheet, dragon-prince-fanmade. It is intended to work with both the playtest material that is available as well as sandbox play.  There is no user data to preserve as this is a new sheet.  I followed the building character sheets standards and found them very helpful.
All of the images needed by this character sheet are included in the request.

Character Sheet Info Roll20 Internal Use only.

Missing a comma.  Will fix.


Token wrapper balance and events

Closes #67 and closes #71

add /tokens endpoint
add /tokens/:tokenAddress/users/:userAddress/balance endpoint
add /tokens/:tokenAddress/users/:userAddress/events endpoint
add events Deposit, Transfer, Withdrawal, Approval to existing /events endpoint

I removed some unused imports. Looks good to me know. To be sure that everything works, we need the e2e tests in the clientlib.


Error when running with defaults.

I'm having a little bit of trouble getting started. I'm running this project on Ubuntu 16.04 and I believe that I have all the required dependencies. When I try to run python3 dataset_generator.py  I am met with File "dataset_generator.py", line 151     print "%s not found. Using empty mask instead."%mask_file                                                   ^ SyntaxError: Missing parentheses in call to 'print'
Any idea why. I am probably missing something really simple, but any help would be very much appreciated.

The code in the repository was tested with Python 2 only. You need to call print as a function in Python 3 for this code to work. This fork https://github.com/yueweiyang/syndata-generation/blob/master/dataset_generator.py makes the required changes for the code to run with Python 3.

Thanks for that. I get a new error.
 from pb import * ImportError: No module named 'pb'
Do you by chance know whats going on here? I cant find a module named "pb" on google.

pb refers to the Poisson blending library: https://github.com/yskmt/pb

I really appreciate the help with that, and sorry for the late reply. I fixed the issue with pb and made the necessary changes to run pyblur on python3.
When I run python3 dataset_generator.py root exp i just get Number of background images : 2.
When I run python dataset_generator.py [-h] [--selected] [--scale] [--rotation] [--num NUM] [--dontocclude] [--add_distractors] root exp
I get  usage: dataset_generator.py [-h] [--selected] [--scale] [--rotation]                             [--num NUM] [--dontocclude] [--add_distractors]                             root exp dataset_generator.py: error: unrecognized arguments: [--scale] [--rotation] [--num NUM] [--dontocclude] [--add_distractors] root exp
Am I missing something?

Thanks

Hi,
I wanted to try your code and I have the same problem.
python dataset_generator.py ~/code/self/libs/syndata-generation/demo_data_dir ~/code/self/libs/syndata-generation/output_dir
Number of background images : 2
List of distractor files collected: []
While it does run, it does not write any images in output_dir/images
I tried a few print outs in function create_image_anno, but it seems the method is not entering that function, maybe its because of partial() or some problems with threading?
Any suggestions?
Thanks

Ok now I got it, with this command it runs.
python dataset_generator.py demo_data_dir/objects_dir output_dir


fix(challenge): Change javascript basic comment challenge

Changed RegEx in order to accept '*' inside a multi-line comment
Closes #17619

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17619
Description

Hi @gforce2k5
Thanks a lot for this pull request. We sincerely appreciate the time and efforts put into this.
However can you please make the same changes once again on the https://github.com/freeCodeCamp/curriculum repository?
I would like to apologise for the inconvenience, but at this point it has become very difficult to carry over commits into the other repo, to which we have moved over the entire curriculum package.
Thanks once again.
Please reach out to us in the Contributors Chat room for any assistance.
Happy contributing!


Add rust support

Description

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

You are right, cargo should be installed as part of the test suite, adding that in.


Alignment brings everything to far left

When I use the shortcut to align arrays it always pulls all of the data to the left but leaves 1 space between the beginning of the line and the first character. Shouldn't it keep all the values in the same starting position as they are often following indentation from classes or functions.

Hmm, works fine here. Are you using tabs or spaces for indentation ? What are your package settings ?

Atom-alignment v0.11.0 no custom settings. Just as default when installed.
Here are some of my settings. Tell me if you want any more.

Setting
Set / Value

Soft Tabs
True

Soft Wrap
False

Tab Length
2

Ok, after having another look I think I can reproduce it. Looks like is has something to do if spaces and tabs are mixed on the same row. Can you please try my fork https://github.com/papermoon1978/atom-alignment ? Just replace the aligner.coffee

I've been running with this fork for a few hours and yes it seems to fix the issue I had completely!
Thank you!

Thanks for testing. Looks I've overseen something while doing the rewrite. Sorry. But glad it's working now. I'll create another pull request so this should be part of the next patch.


is_calleable assertion

It would be useful to have an is_calleable assertion that tests whether is_function(argument) or is_function(debug.getmetatable(argument)._call).

Feel free to make a PR and reference this issue

luassert has its own implementation btw; in luassert.util, see https://github.com/Olivine-Labs/luassert/blob/master/src/util.lua#L274

luassert has its own implementation btw; in luassert.util, see https://github.com/Olivine-Labs/luassert/blob/master/src/util.lua#L274

Technically, that impl is incorrect. See here: https://github.com/neovim/neovim/pull/29536

wouldn't an object with  metatable that has another metatable with a __call method be callable? iirc those lookups are chained.

wouldn't an object with metatable that has another metatable with a __call method be callable? iirc those lookups are chained.

Not for Lua 5.1 and Luajit. Maybe this has changed since 5.1 though, not sure.
You can see the tests here: https://github.com/neovim/neovim/pull/29536/files


Copy: Refactor variant report code and remove old functions

Copy of 'Refactor variant report code and remove old functions' (link: https://github.com/broadinstitute/gnomad_methods/pull/575) with only changes to relevant files to clear up some very odd problems with Git History.

general comment, rename "gnomad_gks_batch" -> "gnomad_gks" and "gks_compute_seqloc_digest_batch" -> "gks_compute_seqloc_digest" to avoid confusion with these being associated with Hail Batch


Secure /metrics endpoints for components shipped with kube-prometheus

What is missing?
We ship only few components with protected /metrics endpoints. This should be a default for all of them.
Why do we need it?
To have secure by default solution
Environment

kube-prometheus version: latest

Anything else we need to know?:
PR for securing prometheus-operator endpoint: https://github.com/coreos/kube-prometheus/pull/453
List of components which need securing:

"alertmanager-main"
"prometheus-k8s"
"kube-dns"
"grafana"
When component is secured, it should be removed from e2e test exclusion list in TestTargetsScheme test.

Closing as a duplicate of https://github.com/prometheus-operator/kube-prometheus/issues/179


Move options related strings to resx.

Enable localization on the Windows Forms controls.
Remove some unused code, including a New Interpreter dialog.

👍


Property or method "debouncedValidate" is not defined on the instance but referenced during render

I've created a custom field for postcode. but I got error in console."Property or method "debouncedValidate" is not defined on the instance but referenced during render "
<template>
  <input
      class="form-control"
      type="tel"
      v-model="value"
      :disabled="disabled"
      :maxlength="schema.maxlength"
      :placeholder="schema.placeholder"
      :readonly="schema.readonly"
      :formmethod="schema.formmethod"
      :debouncedValidate="schema.validator"
      @input="onEnter($event)"
      >
</template>

<script>
  import { abstractField } from "vue-form-generator";
  import { getConfig } from '../utils/api'
  export default {
    mixins: [ abstractField ],
    methods: {
      onEnter(event){
        this.value = this.value.replace(/[^0-9-]+/,'')
      }
    }
  };
</script>

something i missed?

You didn't define it.  It's not a property defined in abstractField, it's part of the computed value.
When adding your custom field to the form, just provide a validateDebounceTime value in the field schema and it will create a debounce() function and call it for you.
Take a look at src/fields/core/fieldInput.vue for an example of a basic input[type=text] field.
Looks like you're trying to mask the input entered, which can be done using the formatValueToField and formatValueToModel methods, in a similar fashion to how src/fields/core/fieldInput.vue handles dates. You should remove the @input, and include the custom logic in the formatValueTo* methods.

I'll take a look on it. thank you!

I rewrite my custom filed in the following way with some console.log() to test.
but I still caught the same error.I did something wrong?
<template>
  <input
      class="form-control"
      :id="getFieldID(schema)"
  		:type="schema.inputType"
  		:value="value"
  		@input="value = $event.target.value"
  		:class="schema.fieldClasses"
  		@change="schema.onChange || null"
  		:disabled="disabled"
  		:accept="schema.accept"
  		:alt="schema.alt"
  		:autocomplete="schema.autocomplete"
  		:checked="schema.checked"
  		:dirname="schema.dirname"
  		:formaction="schema.formaction"
  		:formenctype="schema.formenctype"
  		:formmethod="schema.formmethod"
  		:formnovalidate="schema.formnovalidate"
  		:formtarget="schema.formtarget"
  		:height="schema.height"
  		:list="schema.list"
  		:max="schema.max"
  		:maxlength="schema.maxlength"
  		:min="schema.min"
  		:minlength="schema.minlength"
  		:multiple="schema.multiple"
  		:name="schema.inputName"
  		:pattern="schema.pattern"
  		:placeholder="schema.placeholder"
  		:readonly="schema.readonly"
  		:required="schema.required"
  		:size="schema.size"
  		:src="schema.src"
  		:step="schema.step"
  		:width="schema.width"
  		:files="schema.files"
      >
</template>

<script>
  import { abstractField } from "vue-form-generator";
  import { getConfig } from '../utils/api'
  export default {
    mixins: [ abstractField ],
    methods: {
      // onEnter(event){
      //   this.value = this.value.replace(/[^0-9-]+/,'')
      // }
      formatValueToField(value) {
        // return '22222'
  			if (value != null) {
          console.log(77777)
  				// let dt;
  				// switch (this.schema.inputType) {
  				// 	case "date":
  				// 		dt = this.schema.format ? fecha.parse(value, this.schema.format) : new Date(value);
  				// 		return fecha.format(dt, "YYYY-MM-DD");
  				// 	case "datetime":
  				// 		dt = this.schema.format ? fecha.parse(value, this.schema.format) : new Date(value);
  				// 		return fecha.format(dt, "YYYY-MM-DD HH:mm:ss");
  				// 	case "datetime-local":
  				// 		dt = this.schema.format ? fecha.parse(value, this.schema.format) : new Date(value);
  				// 		return fecha.format(dt, "YYYY-MM-DDTHH:mm:ss");
  				// }
  			}

  			return value;
  		},

  		formatValueToModel(value) {
        // return '22222'
  			if (value != null) {
          console.log(99999)
  				// let m;
  				// switch (this.schema.inputType) {
  				// 	case "date":
  				// 		m = fecha.parse(value, "YYYY-MM-DD");
  				// 		if (m !== false) {
  				// 			if (this.schema.format)
  				// 				value = fecha.format(m, this.schema.format);
  				// 			else
  				// 				value = m.valueOf();
  				// 		}
  				// 		break;
  				// 	case "datetime":
  				// 		m = fecha.parse(value, "YYYY-MM-DD HH:mm:ss");
  				// 		if (m !== false) {
  				// 			if (this.schema.format)
  				// 				value = fecha.format(m, this.schema.format);
  				// 			else
  				// 				value = m.valueOf();
  				// 		}
  				// 		break;
  				// 	case "datetime-local":
  				// 		m = fecha.parse(value, "YYYY-MM-DDTHH:mm:ss");
  				// 		if (m !== false) {
  				// 			if (this.schema.format)
  				// 				value = fecha.format(m, this.schema.format);
  				// 			else
  				// 				value = m.valueOf();
  				// 		}
  				// 		break;
  				// 	case "number":
  				// 		return Number(value);
  				// 	case "range":
  				// 		return Number(value);
  				// }
  			}

  			return value;
  		}
    }
  };
</script>

Can you provide a JSFiddle of this? I copied your custom field to my project and used it, ... I got an error about the "getConfig" as ../utils/api is the wrong path for a custom field (assuming you put the field in your project, and not in the node_modules/vue-form-generator/src/fields folder.  getConfig isn't being used, so I just removed it ... after that, your custom field showed up in my form and output "99999" to my console with no warnings/errors.

here is the jsfiddle:https://jsfiddle.net/egfkqt7a/
I found that if I wrote the custom field in this way:
Vue.component("field-postcode", {
    template: '<input class="form-control" :id="getFieldID(schema)" :type="schema.inputType" :value="value" @input="value = $event.target.value" :class="schema.fieldClasses" @change="schema.onChange || null" :disabled="disabled" :accept="schema.accept" :alt="schema.alt" :autocomplete="schema.autocomplete" :checked="schema.checked" :dirname="schema.dirname" :formaction="schema.formaction" :formenctype="schema.formenctype" :formmethod="schema.formmethod" :formnovalidate="schema.formnovalidate" :formtarget="schema.formtarget" :height="schema.height" :list="schema.list" :max="schema.max" :maxlength="schema.maxlength" :min="schema.min" :minlength="schema.minlength" :multiple="schema.multiple" :name="schema.inputName" :pattern="schema.pattern" :placeholder="schema.placeholder" :readonly="schema.readonly" :required="schema.required" :size="schema.size" :src="schema.src" :step="schema.step" :width="schema.width" :files="schema.files" />',
 mixins: [ VueFormGenerator.abstractField ],
 methods: {
 formatValueToField(value) {
  if (value != null) {
   console.log(77777)
  }
  return value;
 },

 formatValueToModel(value) {
  if (value != null) {
   console.log(99999)
  }

  return value;
 }
}

@gezichenshan how do I reproduce the error using your Fiddle? When I enter values into your Postcode field all I get is 99999 and 77777 output to the console depending on the input.  No errors about debounceValidate.

@zoul0813 Yes , in Fiddle there is no errors. I've explained in my last comment that if I use the Postcode field by importing it from another file, the errors will show.

@gezichenshan I copied everything over to a local project, and imported the "fieldPostcode.vue" file and am still unable to reproduce the issue you're reporting.  Without a JSFiddle/Plunker showing the error or a git repo that can be cloned and tested ... I can't help you.
Are you using the latest version of VFG (2.1.1) ?

[ ]

I'm still not able to reproduce the error.  However, you're Reg1.vue file is incomplete and I had to make some assumptions about how you declared the  ...
I went with ...
<vue-form-generator :schema="schema" :model="model"></vue-form-generator>

You shouldn't be getting errors about debouncedValidate unless you're trying to use the debounce validation ... the code that calls 'debouncedValidate' is located in abstractField's computed setter for 'value'.
/// VFG debouncedValidate logic
if (this.$parent.formOptions && this.$parent.formOptions.validateAfterChanged === true) {
    if (this.$parent.formOptions.validateDebounceTime > 0) {
        if (!this.debouncedValidate)
            this.debouncedValidate = debounce(this.validate.bind(this), this.$parent.formOptions.validateDebounceTime);

        this.debouncedValidate();
    } else {
        this.validate();
    }
}

Even when I pass a formOptions object as { validateAfterChanged: true, validateDebounceTime: 5000 } I still don't get an error ... unfortunately, without having an actual project that reproduces the error I can't help.  I'm going to close this issue for now, feel free to re-open it later if you can provide a complete project (something I can clone from github, or a JSFiddle/Plunker) that reproduces the reported error.

@zoul0813 Hi, I created a project on github to reproduce the error. You may check it out if it is convenient for you.
here it is: https://github.com/gezichenshan/vfg-custom-postalcode-field-demo :)

I can reproduce the error in your project, ... taking a look at it now.

Ok, I think I've tracked the issue down ... it looks like the older version of Vue that VFG was originally written against supported adding methods to the Vue components dynamically.  However, the newer version of Vue is throwing errors because "debouncedValidate" is not defined in the component, as it was being attached only in certain situations.  This seems to only occur if you're using a newer version of Vue than VFG was intended for.
Working on a fix now.

@zoul0813 Thank you very much!


PostgreSQL 17: ERROR:  commutator operator = is already the commutator of operator =

rdkit is not compatible with PG 17 yet:
**** /tmp/autopkgtest.Rnc5Gt/tree/Code/PgSQL/rdkit/regression.diffs ****
diff -U3 /tmp/autopkgtest.Rnc5Gt/tree/Code/PgSQL/rdkit/expected/rdkit-91_1.out /tmp/autopkgtest.Rnc5Gt/tree/Code/PgSQL/rdkit/results/rdkit-91.out
--- /tmp/autopkgtest.Rnc5Gt/tree/Code/PgSQL/rdkit/expected/rdkit-91_1.out	2024-05-23 12:10:12.000000000 +0000
+++ /tmp/autopkgtest.Rnc5Gt/tree/Code/PgSQL/rdkit/results/rdkit-91.out	2024-05-23 13:22:31.278341481 +0000
@@ -4,181 +4,160 @@
 --
 SET client_min_messages = warning;
 \set ECHO none
+ERROR:  commutator operator = is already the commutator of operator =

See https://github.com/postgres/postgres/commit/2b5154beab794eae6e624c162d497df927ec9d27
Full build/test log: https://pgdgbuild.dus.dg-i.net/job/rdkit-binaries-beta/architecture=amd64,distribution=sid/13/consoleText

This may be related to changes in the operators:
https://www.postgresql.org/message-id/flat/ZTfL1G1fBPQHVPWV%40msg.df7cb.de#ce3801c084bcf05b6b976cb2d0e25b2d

Maybe it is just about removing the NEGATOR from <> in :
CREATE OPERATOR = (
    LEFTARG = mol,
    RIGHTARG = mol,
    PROCEDURE = mol_eq,
    COMMUTATOR = '=',
    NEGATOR = '<>',
    RESTRICT = eqsel,
    JOIN = eqjoinsel,
    SORT1 = '<',
    SORT2 = '<'
);

CREATE OPERATOR <> (
    LEFTARG = mol,
    RIGHTARG = mol,
    PROCEDURE = mol_ne,
    COMMUTATOR = '<>',
    NEGATOR = '=',
    RESTRICT = neqsel,
    JOIN = neqjoinsel
);

Hello, is there any update on this?

Someone needs to decide which operators are the canonical ones, and either drop the rest altogether, or reduce the extra operators not to have conflicting commutators/negators.


[AutoDiff] Require same access level for original/derivative functions.

Require @derivative functions and their original functions to have the same access level.
Public original functions may also have internal @usableFromInline derivatives, as a special case. Diagnose access level mismatches.
This simplifies derivative registration rules, and may enable simplification of AutoDiff symbol linkage rules.
Resolves TF-1099 and TF-1160.

Example:
import _Differentiation

public func publicOriginal(_ x: Float) -> Float { x }

@derivative(of: publicOriginal)
private func privativeDerivative(_ x: Float) -> (value: Float, pullback: (Float) -> Float) {
  fatalError()
}

$ swift example.swift
example.swift:5:17: error: derivative function must have same access level as original function; derivative function 'privativeDerivative' is private, but original function 'publicOriginal' is public
@derivative(of: publicOriginal)
                ^
example.swift:6:14: note: mark the derivative function as 'public' to match the original function
private func privativeDerivative(_ x: Float) -> (value: Float, pullback: (Float) -> Float) {
~~~~~~~      ^
public

Future direction: anonymous func declarations (SR-12003) will enable public derivative functions without exposing them as public API.
public func bar(_ x: Float) -> Float { x }

@derivative(of: bar)
public func _(_ x: Float) -> (value: Float, differential: (Float) -> Float) {
  (x, { dx in dx })
}

This additional restriction will break users. Fix all @derivative usage errors caught by "community CI" before merging.
Done: https://github.com/tensorflow/swift-apis/pull/929

@swift-ci Please smoke test

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - a6bba14a2d7c6bee70e0da20c98bc65bdddd2082

Build failed
Swift Test OS X Platform
Git Sha - a6bba14a2d7c6bee70e0da20c98bc65bdddd2082


'Az.Resources' module is required for PowerShell script

Hi there,
Please add "'New-AzRoleAssignment' PowerShell cmdlet required to have 'Az.Resources' module installed"
Regards, Ilkin

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3a831056-b759-8539-ca86-9fbb84f331d7
Version Independent ID: 8fca63cc-bd36-d774-1f31-eca19502b006
Content: Activate Azure resource roles in PIM - Microsoft Entra
Content Source: articles/active-directory/privileged-identity-management/pim-resource-roles-activate-your-roles.md
Service: active-directory
Sub-service: pim
GitHub Login: @amsliu
Microsoft Alias: amsliu

@ctahok
Thanks for your feedback! We will investigate and update as appropriate.

@ctahok
I'm going to assign this to the document author so they can take a look at it accordingly
@amsliu
Can you please check and add your comments on this doc update request as applicable.

@ctahok Thank you for the feedback on our documentation. As part of ongoing updates, we have removed the PowerShell section from this article. Please refer to the new Graph PowerShell documentation for further instructions here: tutorial for PIM Graph PowerShell for Azure AD role assignments. #please-close


Terms of use box way too small

On my 30" screen the terms of use box use about 1/3 of the height of the screen.  The agree button is at the bottom leaving most of the available screen real estate unused.

wont fix.  hopefully fixed in upstream.


Remove params that are not being used in resource params

Redone #719, thanks to @jahammo2

Makes sense to me. We only need UID of some kind and reset password token to do the work of that endpoint. Merging.

If we still allow the user to pass in redirect_url as a param for the POST request to /auth/password, wouldn't we still need to permit the redirect_url parameter? Otherwise an unpermitted parameter error is thrown.
It's a bit confusing, since the docs for the endpoint still say to pass in redirect_url, which would be required if the user doesn't set a default in the initializer.