AssignReadGroupByBarcode: problem with doubly-barcoded reads

Trying to demultiplex recently sequenced pools with two barcodes, I get an

UNEXPECTED ERROR: null

Command line:
readtools AssignReadGroupByBarcode --splitSample --barcodeFile Info/barcodes_452.txt --maximumMismatches 1 --output Demul-452 --input Pool_452a_4k_1.fq --input2 Pool_452a_4k_2.fq > demultiplex-452.out 2>&1
What do you make of that? I am attaching small fastqs that should reproduce the error. I only use the first barcode because there seems to be another problem with using two barcodes, which I will report separately. Using only one barcode seems to work ok with two other pools from the same batch, the difference here is maybe that according to the metainfo I received, not all samples are in fact doubly-barcoded.
viola-452.txt
barcodes_452.txt
Pool_452a_4k_1.fq.gz
Pool_452a_4k_2.fq.gz
demultiplex-452.out.txt

By the way, apparently we can now have pools where  singly and doubly-barcoded samples are mixed in the same pool. This would mean an empty barcode_sequence_2 column for some samples in the barcode file, and readtools would have to apply the one or the other matching strategy depending on the sample. I am not sure this can currently be handled?

Thanks for reporting @robmaz - here are two different issues:

For the main error (first message), looks like a bug. Could you please run with --verbosity DEBUG and attach/report the log? I will also try to figure out with the data that you provided ASAP.
The second message is a different issue, and actually a new feature that it isn't supported at the moment. I can use that feature-request to push me to refactor the barcode detection methods, which I was planning for long time ago (see https://github.com/magicDGS/ReadTools/issues/113). You should anyway open another issue for that (and it will take more than a week to fix, even more taking into account how much work I have for other projects at the moment). Does the FASTQ files have at least a fake barcode for the second read (please, open the issue and less discuss that there instead of here -  I will edit this issue to keep only the related information afterwards).

More information about the issue (with DEBUG level):
java.lang.NullPointerException
        at org.magicdgs.readtools.tools.barcodes.dictionary.decoder.BarcodeMatch.getBestBarcodeMatch(BarcodeMatch.java:150)
        at org.magicdgs.readtools.tools.barcodes.dictionary.decoder.BarcodeDecoder.lambda$getBestBarcodeString$4(BarcodeDecoder.java:237)
        at java.util.stream.IntPipeline$4$1.accept(IntPipeline.java:250)
        at java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:110)
        at java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:693)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)        at org.magicdgs.readtools.tools.barcodes.dictionary.decoder.BarcodeDecoder.getBestBarcodeString(BarcodeDecoder.java:241)        at org.magicdgs.readtools.tools.barcodes.dictionary.decoder.BarcodeDecoder.assignReadGroupByBarcode(BarcodeDecoder.java:199)        at org.magicdgs.readtools.tools.barcodes.AssignReadGroupByBarcode.apply(AssignReadGroupByBarcode.java:175)        at org.magicdgs.readtools.engine.ReadToolsWalker.lambda$new$1(ReadToolsWalker.java:144)        at java.util.Iterator.forEachRemaining(Iterator.java:116)
        at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
        at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
        at org.magicdgs.readtools.engine.ReadToolsWalker.traverse(ReadToolsWalker.java:128)
        at org.magicdgs.readtools.engine.ReadToolsWalker.doWork(ReadToolsWalker.java:193)
        at org.broadinstitute.hellbender.cmdline.CommandLineProgram.runTool(CommandLineProgram.java:138)
        at org.broadinstitute.hellbender.cmdline.CommandLineProgram.instanceMainPostParseArgs(CommandLineProgram.java:183)
        at org.broadinstitute.hellbender.cmdline.CommandLineProgram.instanceMain(CommandLineProgram.java:202)
        at org.broadinstitute.hellbender.Main.runCommandLineProgram(Main.java:160)
        at org.broadinstitute.hellbender.Main.mainEntry(Main.java:203)
        at org.magicdgs.readtools.Main.main(Main.java:87)

@robmaz - I figure out that there is an errors in your input data and this is not a bug in the program itself: the barcode file has an extra tab between sample_name and barcode_sequence headers; thus, it is a bad formatted barcode file that produce the error (when removing, I was able to run the program normally). It is true that the error can be better, and I will open an issue to add a check for throwing a more informative exception.

I change this from bug to mainteinance, as it is related with a non-useful error message when a file is malformed.

Closing in favor of #512 and #513


[iomgr][EventEngine] Improve server handling of file descriptor exhaustion

Is there any chance this could be backported to the 1.2x series?

@glaubitz No, the 1.2x releases are 3 to 4 years old, it would be far more effort than it's worth for us to try to provide support going that far back. I highly recommend staying up to date with the most recent releases; numerous bug fixes and various improvements have landed in the past few years.

OK, thanks. I will have to update grpc itself then which requires some effort due to the target being an LTS distribution.


added ":true" to "X-Arango-Allow-Dirty-Read" header

see: https://github.com/arangodb/planning/issues/3198

is this really the only place in the docs ?

oh sorry, missed this one as well: https://docs.arangodb.com/3.4/Manual/Administration/ActiveFailover/#reading-from-follower
going to fix it now
Are you aware of any other places ?

@OmarAyo you can easily check for strings in a checked out github repository (documentation folder), for example
arangodb/Documentation$ ag  "X-Arango-Allow-Dirty"
Books/Manual/Architecture/DeploymentModes/ActiveFailover/Architecture.md
55:read requests are _only_ permitted if the requests is marked with the `X-Arango-Allow-Dirty-Read` header,
79:followers by adding a `X-Arango-Allow-Dirty-Read` header on each request. Responses will then automatically

Books/Manual/Administration/ActiveFailover/README.md
49:followers by adding a `X-Arango-Allow-Dirty-Read` header on each request. Responses will then automatically

line 55 in Books/Manual/Architecture/DeploymentModes/ActiveFailover/Architecture.md is still missing


How to set the maximum number of displayed item?

In the first demo, it appears there is a limited number of displayed completion items.
How to set it up?

You can set set pumheight=10


Select Dialog Box confirm event not triggered when search option is used to select object which is not loaded yet

OpenUI5 version:
1.126.0
Browser/version (+device/version):
Google chrome latest
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible):
https://snippix.only.sap/#669927
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

open google chrome using to prevent the cors issue
open -a Google\ Chrome --args --disable-web-security --user-data-dir=~/desktop
Click on Open Dialog box
Search For Krista and select it
Click On Select and you will see that the confirm event is not hit

The problem is that everything is working fine when I use a sap.ui.model.Filter but when I  use changeParamater and $ filter then on click on select the confirm event is not triggered.

line number 2216 is hit and the reset part is not hit because of which the confirm event is stopped from triggering.
This problem only happens when I use an OData model.
What is the expected result?
expected result is that the confirm event is hit
What happens instead?
the confirm event doesnot hit
Any other information? (attach screenshot if possible)

Hello @albertbolt1,
I’m unable to reproduce the behavior you described. Since there is no data, there are no items available for selection.
Could you please provide a different working example or a demo kit sample?
Kind regards,
Yana

Hello @yanaminkova ,
The data is available, kindly check the ways to reproduce the problem,
the items may not be loaded because CORS issue, you may have to run chrome in disable web security mode,

// more instructions on how to disable web security for various Operating systems
Yep. For OSX, open Terminal and run:
$ open -a Google\ Chrome --args --disable-web-security --user-data-dir
--user-data-dir required on Chrome 49+ on OSX
For Linux run:
$ google-chrome --disable-web-security
Also if you're trying to access local files for dev purposes like AJAX or JSON, you can use this flag too.
--allow-file-access-from-files
For Windows go into the command prompt and go into the folder where Chrome.exe is and type
chrome.exe --disable-web-security
That should disable the same origin policy and allow you to access local files.

Hello @albertbolt1,
Thank you for sharing this finding.
I've created an internal incident DINC0244678. The status of the issue will be updated here in GitHub.
Regards,
Yana

https://github.com/SAP/openui5/blob/04366de606f3004e5654e8bccd556a8975d9341c/src/sap.m/src/sap/m/SelectDialog.js#L1088-L1106
With the v4.ODataListBinding#changeParameters and the $filter, the list binding does not necessarily contain a Filter instance. I.e. when the fnOKAfterClose calls oBindings.filter while the binding had been not containing any Filter to begin with, no new request is sent expectedly. Without the request, updateFinished won't be handled either which leads to skipping that._fireConfirmAndUpdateSelection().
Whether the list binding contains a Filter or not can be checked with ListBinding#getFilters.

Hi @albertbolt1,
At present, our SelectDialog only supports data filtering using
binding.filter([filter]);
Alternative methods are not supported.
Best,
Teo


CSS: ref marker-icon-2x.png and marker-shadow.png

This enables automatic asset handling using webpack and its css-loader.
Relates to #4849, #4979

This is not needed, as .leaflet-default-icon-path class is used only in path detection heuristic.

In fact some treatment is needed. Either the relevant files (including marker-icon-2x.png and marker-shadow.png ) are referenced in the stylesheet, or the consumers have to adapt their build system (such as webpack) to copy the dangling, but needed files marker-icon-2x.png and marker-shadow.png

Ok. I have no webpack setup to check this.
Cound do provide sample webpack setup to test?

Here is a SSCCE: https://gist.github.com/simon04/3b89aa6ca858c72110bb80dd13b4f941

@simon04
With your PR all images are included, with random names.
But this is not enough for your sample to work properly.

So I can conclude that such approach makes sense.
But we do not actually need separate styles for that, so it's possible to use this:
/* Default icon URLs */
.leaflet-default-icon-path {
	/* used only in path-guessing heuristic, see L.Icon.Default */

	/* here are images that is accessed from js only */
	/* we need to list them explicitly to instruct webpack file-loader to include them */
	background-image: url(images/marker-shadow.png);
	background-image: url(images/marker-icon-2x.png);
	background-image: url(images/marker-icon.png);
	}

Still, I have some concerns.
AFAIK, in some other setup webpack may include images inline, with data-url, like here: https://github.com/Leaflet/Leaflet/issues/6496#issuecomment-524736021.
With your approach all 3 icons will be inlined into css, absolutely pointlessly increasing bundle's size.

Hey @johnd0e, I've updated this PR according to the discussion in https://github.com/Leaflet/Leaflet/pull/7092#issuecomment-724591326
To test bundling with esbuild, build leaflet, and run echo 'require("./dist/leaflet-src.js"); require("./dist/leaflet.css")' | npx esbuild --bundle --outdir=dist.esbuild/ --loader:.png=file
You should obtain the following files
$ find dist.esbuild/
dist.esbuild/
dist.esbuild/layers-2x.CUVBMIZT.png
dist.esbuild/layers.ZHTVFDSJ.png
dist.esbuild/marker-icon-2x.Z45FGZMW.png
dist.esbuild/marker-icon.MCUQXS5S.png
dist.esbuild/marker-shadow.PNVI35RZ.png
dist.esbuild/stdin.css
dist.esbuild/stdin.js

The stylesheet should reference the correct .png files
$ grep png dist.esbuild/stdin.css
  background-image: url(layers.ZHTVFDSJ.png);
  background-image: url(layers-2x.CUVBMIZT.png);
  background-image: url(marker-icon.MCUQXS5S.png);
  background-image: url(marker-icon-2x.Z45FGZMW.png);
  background-image: url(marker-shadow.PNVI35RZ.png);

@simon04
What if we have many markers with different icons?

What do you mean with "different icons"? Leaflet only ships one according to<EMAIL_ADDRESS>

But L.Marker is designed to support any user icon. And _getIconUrl will be used for any user-supplied image path, so that should be tested too.
For example: it is common practice - to put extra marker icons into Leaflet images directory (or to some relative path).

Is this a specified behaviour? https://leafletjs.com/reference-1.7.1.html#icon-iconurl defines iconUrl – "The URL to the icon image (absolute or relative to your script path)."

Perhaps this is.
But better to check if precise wording completely corresponds to actual behavior.

Icon.Default.imagePath only mentions the blue icon, "Icon.Default will try to auto-detect the location of the blue icon images.", see https://leafletjs.com/reference-1.7.1.html#icon-default-imagepath
You're suggesting to augment this in the following way: when the default marker-icon is in foobar/marker-icon.MCUQXS5S.png, then a different icon having iconUrl=baz.png should be taken from foobar/baz.png as well?

Icon.Default.imagePath only mentions the blue icon

This is how we can override image path manually, which may be needed if autodetection fails (for whatever reason).
But we still prefer to make autodetection to cover most cases without touching .imagePath manually.

You're suggesting to augment this in the following way

Perhaps. I am not sure about exact code (and unable to check right now), that is why you better to check yourself.

Before this change, on the markers test http://localhost:2015/debug/map/markers.html,

Icon.Default loads http://localhost:2015/dist/images/marker-icon.png
L.icon({iconUrl: 'custom-marker.png'}) loads http://localhost:2015/debug/map/custom-marker.png

This PR does not affect the loaded URLs. This makes sense, since imagePath is only used inside Icon.Default.

Let's celebrate the 1 year anniversary of this PR. :partying_face:
Any update?

I just applied this PR as a patch to leaflet 1.7.1 installed with npm, and it works perfectly with bundling using browserify with the browserify-css transform if I don't inline the images.
$ cd node_modules/leaflet

$ wget https://patch-diff.githubusercontent.com/raw/Leaflet/Leaflet/pull/6951.patch

$ patch -p1 < 6951.patch
patching file dist/leaflet.css
patching file src/layer/marker/Icon.Default.js

Here you see that my build script picks up all the files referenced by url() in the dependencies' CSS:
$ rm -rf build/ && gulp build
[03:30:47] Using gulpfile ~/code/myapp/gulpfile.js
[03:30:47] Starting 'build'...
[03:30:47] Starting 'files'...
[03:30:47] Starting 'html'...
[03:30:47] Finished 'files' after 100 ms
Bundling with browserify...
Including external file referenced by a dependency: leaflet/dist/images/layers.png
Including external file referenced by a dependency: leaflet/dist/images/layers-2x.png
Including external file referenced by a dependency: leaflet/dist/images/marker-icon.png
Including external file referenced by a dependency: leaflet/dist/images/marker-icon-2x.png
Including external file referenced by a dependency: leaflet/dist/images/marker-shadow.png
Including external file referenced by a dependency: font-awesome/fonts/fontawesome-webfont.eot
Including external file referenced by a dependency: font-awesome/fonts/fontawesome-webfont.eot
Including external file referenced by a dependency: font-awesome/fonts/fontawesome-webfont.woff2
Including external file referenced by a dependency: font-awesome/fonts/fontawesome-webfont.woff
Including external file referenced by a dependency: font-awesome/fonts/fontawesome-webfont.ttf
Including external file referenced by a dependency: font-awesome/fonts/fontawesome-webfont.svg
Minifying bundle...
[03:30:50] Finished 'html' after 2.94 s
[03:30:50] Finished 'build' after 2.95 s
Done in 3.53s.

Everything works as it should.
If I turn on image inlining, then it's the same as before. Leaflet improperly adds ")marker-icon-2x.png to the marker icon data URI which makes an invalid URI:
data:image/png;base64,iVBORw0KGgoAAAAN...UVORK5CYII=")marker-icon-2x.png

My current solution is just to apply the patch post-install by having this in package.json:
{
  "scripts": {
    "postinstall": "patch -d node_modules/leaflet/ -p1 --forward -r - < patches/leaflet-pr-6951.patch"
  },
  "dependencies": {
    "leaflet": "^1.7.1"
  }
}

I've just tested this PR applied as a patch to Leaflet 1.7.1 with esbuild, and it doesn't work. The source file looks like:
.leaflet-default-icon-path {
  background-image: url(./vendor/marker-icon-2V3QKKVC.png);
}
.leaflet-default-icon-path-2x {
  background-image: url(./vendor/marker-icon-2x-SP63CLEO.png);
}
.leaflet-default-icon-path-shadow {
  background-image: url(./vendor/marker-shadow-MEXDWUU7.png);
}

But the browser tries to access:
marker-icon-2V3QKKVC.png%22)marker-icon-2x.png

If I override the asset naming rule in the esbuild options to omit the hash in the file name, then it works:
{
  loader: {
    '.png': 'file'
  },
  assetNames: 'vendor/[name]-[hash]'
}

Here's a SSCCE based on the esbuild bundler: https://github.com/simon04/leaflet-esbuild/tree/leaflet-pr-6951. After running esbuild --bundle --outdir=dist/ --loader:.png=file index.js (via yarn build), the directory dist/ contains the following PNG files –
dist/layers-2x-TBM42ERR.png
dist/layers-55W3Q4RM.png
dist/marker-icon-2V3QKKVC.png
dist/marker-icon-2x-SP63CLEO.png
dist/marker-shadow-MEXDWUU7.png

The compiled CSS file correctly references the PNG files –
dist/index.css:  background-image: url(./layers-55W3Q4RM.png);
dist/index.css:  background-image: url(./layers-2x-TBM42ERR.png);
dist/index.css:  background-image: url(./marker-icon-2V3QKKVC.png);
dist/index.css:  background-image: url(./marker-icon-2x-SP63CLEO.png);
dist/index.css:  background-image: url(./marker-shadow-MEXDWUU7.png);


pid limiting documentation

Quickly combined info about pid limiting. It is a follow up from https://github.com/kubernetes/kubernetes/pull/94140#issuecomment-692720795
It also requires this PR https://github.com/kubernetes/website/pull/23883 as it adds the description of the feature flag that this PR refer to.
Related #23906 (issue can be closed once this branch is merged back to master)
/sig node
/assign @sftim
/assign @derekwaynecarr

node-to-pod PID isolation

What does this mean? I think it's about imposing a resource limit on Pods, where the resource is the number of host system PIDs that the Pod can use.
PIDs are always isolated between Pods. I don't think it's possible for two Pods in the same namespace hierarchy (ie, both running on one Node with a Linux namespaces-and-cgroups container runtime) to have the same host system PID, that just doesn't make sense.

node-to-pod PID isolation

What does this mean? I think it's about imposing a resource limit on Pods, where the resource is the number of host system PIDs that the Pod can use.
PIDs are always isolated between Pods. I don't think it's possible for two Pods in the same namespace hierarchy (ie, both running on one Node with a Linux namespaces-and-cgroups container runtime) to have the same host system PID, that just doesn't make sense.

This is isolation form attack perspective. I agree it worth re-phrasing. Looking...

@sftim thank you very much for review and rewrites!

@tengqm thank you for pointing all uncertainties in a language. PTAL - I rephrased

Preview: https://deploy-preview-23929--kubernetes-io-vnext-staging.netlify.app/docs/concepts/policy/pid-limiting/

@kubernetes/sig-node-pr-reviews Hello 👋, 1.20 docs lead here. Can we get a tech review?

Should there be a note that on windows these flags has no effect? I'm not sure what's the best practice here

@SergeyKanzhelev its hard to keep up with the delta among linux and windows nodes, but we could put a piece of text that says pid limiting only applies to kubelets running on linux hosts.

LGTM
Defer approval to @sftim to check if all the feedbacks addressed.

Relevant to #23906

Relevant to #23906

I think it is fixes the issue, correct? I can add to description for auto-closing the issue on PR merge

I think it is fixes the issue, correct? I can add to description for auto-closing the issue on PR merge

This PR targets the v1.20 release. I would hold off on closing #23906 given that the master branch (and live documentation) will not include documentation for this (existing) feature until the v1.20 release. Once this merges, though, we can drop the priority of #23906.

@annajung happy for this to land in dev-1.20?

Yes, that sounds good to me
/milestone 1.20

/milestone 1.20

/assign @annajung

Hi @SergeyKanzhelev
https://5f63963c9331a6000839477b--kubernetes-io-vnext-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/ also needs updating, to mark the related feature gates as graduated.
If you change that, I think this will be good to go.
/lgtm cancel
(tech review stands)

Looks good to me, thanks!
/lgtm
/approve


On older OS (Pie), top app bar is not visible

This is the view when used on a Pixel 2 XL running Q (29) or higher

But this is what I see when running a Pixel 2XL on Pie (28)

Is there a setting I can enable to resolve this issue quickly?

Just roll your own Activity and use CropImageView directly.


Parallelize each level of BFS in GetMatchingPaths

I have tried to submit a PR #44269 which parallelize the tf.gfile.Glob in Python, by multi-threaeds against multiple path patterns. This PR is going to optimize the GetMatchingPaths in C++, which brings PBFS into the progress, parallelizes every level of tree by a additional queue. The optimizion can bring considerable performance improvement when the number of files to match reaches a certain level.
Since the content of the change is different, I put this in another PR.  @mihaimaruseac  Could you please task a look at this? Thanks for your review!

@mihaimaruseac  Sorry for some careless compiling problems in the previous commit.. I have fixed them already. Could you please take a look and give any suggestions?

Hi, @gbaned  I noticed that there are some problems in the ci process, but it doesn't seem to be my cause. Could you please help me to check it? I would like to fix if there is something wrong.

First thing, the CI could crash because the Pr was approved by @SuperSaiyan-God who has no approval rights. @SuperSaiyan-God , please don't spam approve PRs, it goes against the code of conduct.
Second, I see you are using <mutex>, but TF has its own mutex wrapper. Can you use TF's synchronization primitives instead of those from the C++ lib?
Finally, this will also need to be replicated on the filesystem plugins side.

@mihaimaruseac Thanks for your advising! As you mentioned, I have turned mutex lib from C++ lib to TF's mutex wrapper in 299062c.
But I’m sorry I didn’t figure out the specific meaning of your last point... What do you mean that needs to be replicated, could you please explain it in more detail?  Thanks!

Finally, this will also need to be replicated on the filesystem plugins side.

@mihaimaruseac
I think this is not the case. Because all 3 cloud filesystems and posix, we have ops_->get_matching_paths == nullptr and it will fall back on this function internal::GetMatchingPaths
https://github.com/tensorflow/tensorflow/blob/79cdd9533a3566b4b84c374645bf9ccf752cb9f4/tensorflow/c/experimental/filesystem/modular_filesystem.cc#L191-L195
Beside, if there is a filesystem that has its own get_matching_paths, I think it will be quite different from internal::GetMatchingPaths so it is not the case either.

@mihaimaruseac Could you please check this again?

Do you have some benchmarks for the implementation?

Do you have some benchmarks for the implementation?

@mihaimaruseac  Thanks for leading the progress of this pr.
I haved made benchmarks against two file systems separately, those are local posix file system and remote hdfs file system. For each file system, I used 4 different directories for benchmarking, the first of which is an empty directory to measure the fixed overhead of the operation itself.
Each test is repeated 10 times and the average is taken as the result. The all benchmark results are as follows:
System environment: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz 88 threads
Local POSIX file system:

d1: an empty directory
d2: 7601 directories, 76354 files
d3: 64520 directories, 905496 files
d4: 113322 directories, 1317540 files

version
patterns
Duration (ms)

baseline
d1
448

baseline
d2
4257

baseline
d3
27527

baseline
d4
133951

opt
d1
475

opt
d2
3258

opt
d3
14128

opt
d4
74653

Remote HDFS file system:

d1: an empty directory
d2: 3 directories, 6000 files
d3: 10 directories, 35896 files
d4: 10 directories, 63212 files

version
patterns
Duration (ms)

baseline
d1
2,166

baseline
d2
955,592

baseline
d3
5,236,644

baseline
d4
8,102,354

opt
d1
2,234

opt
d2
104,478

opt
d3
648,057

opt
d4
1,002,565

P.S. The baseline is the implement of current tensorflow master and the opt is the implement of my parallelized version.
According to the results of the benchmarks, the effect of parallel optimization is quite obvious which approximately
speeded up 8 times in the current machine environment.

Hi, @mihaimaruseac  @gbaned
There seems to be some compilation errors that have nothing to do with the code I modified, and I would like to ask for advice how I should solve them to make the ci process run through?

There seems to be some compilation errors

The errors are not your fault ( They are caused by the some other parts of the baseline ) so I think you do not need to do anything.

The errors are not your fault ( They are caused by the some other parts of the baseline ) so I think you do not need to do anything.

@vnvo2409 Okay, Thanks for your reply!  : )

This is awesome. Thank you


Feature/winter drop

Winter Drop

[ ] Creaking Heart

[ ] Implementation
[ ] Documentation

[ ] Pale Oak wood type

[x] Implementation
[ ] Documentation

[ ] New foliage and vegetation blocks

[ ] Implementation
[ ] Documentation

[ ] Resin

[x] Implementation
[ ] Documentation

[x] Pale Garden biome

найди работу

I think it's fine to not implement creaking blocks since we do not have entity support. If you get the chance to do the other foliage/vegation then that would be appreciated!

I've cherry-picked 566d32bd3c88599d7080cd28ce9b8de9ba95c26c and 26c6f487c842f0f13de95b6721f0ee1a58e7e58a

I have cherry-picked and fixed-up the remaining two commits for Resin blocks/items. The Resin Clump item has been dropped for now as it needs additional work for the block.
Thanks for the contributions!


More broken docs links

http://holoviews.org/reference/elements/bokeh/Pandas_Conversion.html
http://holoviews.org/reference/elements/bokeh/Columnnar_Data.html

Thanks for reporting these.
Where did you find these broken links? I could download the website off S3 and grep but it is easier if I just ask. :-)

Bottom of here: http://holoviews.org/reference/elements/bokeh/Table.html

here's another:
http://holoviews.org/user_guide/Linked_Streams.html
linked to in http://holoviews.org/user_guide/Responding_to_Events.html
(I'm clearly your most avid documentation consumer here....)

That one (and many others!) was fixed in the PR referenced above. We haven't rebuilt the website to make the updates live just yet so until we do that, I would recommend you check that PR to see if the link has been fixed there.

Going to close this, the remaining broken links are listed in https://github.com/pyviz/holoviews/issues/1650


Please add on-screen controls for touch devices.

I believe most mobile phones and tablets could run this emulator right from the browser, so having on-screen controls would really help in that.
There's a javascript framework that does something similar to that, it's called Akihabara.

Please add! Great project ♥

I will be giving myself a try to add touch control on this project https://github.com/bfirsh/jsnes-web
I'll be doing a pull request when im done.


Publish chart to local index

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.
[ ] (Giant Swarm) If creating a release, bump the version and appVersion in Chart.yaml.

This approach creates additional releases on top of our automated ones. That isn't going to work. Dropping this and will potentially revisit as part of https://github.com/giantswarm/giantswarm/issues/21215


Extend documentation of CAP and CAP_NEW

This PR extends the documentation of the decision variables CAP and CAP_NEW.
Closes #48.
How to review

Read the diff and note that the CI checks all pass.
Build the documentation and look at "MESSAGE core formulation" > "Variable definitions" > "Decision variables".

PR checklist

[x] Continuous integration checks all ✅
[x] Update release notes.

Thank you for reviewing!


Normalize UFO with f64 floating point numbers

https://github.com/linebender/norad/issues/164
Areas where f32 changes to f64 are documented in this PR https://github.com/linebender/norad/pull/184

Requires new release of norad


Incorrect pip install statement in documentation for contributors

Description
The documentation in CONTRIBUTING.md states that all dependencies required for testing can be installed via pip install scanpy[test]. It should, however, be pip install "scanpy[test]".
Minimal code sample
pip install scanpy[test]
zsh: no matches found: scanpy[test]

I think this is a zsh issue.

I would suggest scanpy\[test\] . Works with BASH and ZSH.

Noglob turns off all globbing though. Would be great if one could turn off just Extended globbing for a command.
After all, pip install *.whl could be useful.


Support hero animation

Added ModalExprollableRouteBuilder class to support hero animation, which replaces the ModalExprollable class and showModalExprollable function in a future release
Added example for hero animation and ModalExprollableRouteBuilder
Mentioned in the README about the above things

Related issue: #36


feat/#4  creating the Cobra CLI cmd module

🚀 Cobra CLI Module for Wastrap
Overview
This pull request introduces the Cobra CLI module for Wastrap, enhancing its functionality. Below are the key changes made:
Changes Made
1. Main CLI Module

Added the Cobra CLI module with a main command and subcommands.

2. Welcome Message and Help Information

Implemented the root command to show a welcome message and display help information.

3. 'url' Command

Added the 'url' command to the CLI module.

4. Error Handling Improvements

Implemented the 'HandleWordPressError', 'HandleUrlError', and 'HandleOpenUrlError' methods in the 'defaultUrlHandler' struct for better error handling.

5. 'handleUrl' Function

Created the 'handleUrl' function to handle the 'url' command, including checking if the site is based on WordPress.

6. Supporting Functions

Added 'isWordPress', 'fetchPageContent', and 'openURL' functions to support the 'url' command's functionality.

7. Text Customization

Added the formatMessage function to customize text with ANSI escape codes for color styling.

8. Loading Animation

Introduced the loading function to display a loading animation during certain operations.

Usage
Running from Source
# 🛠 Build and run
go build
go run main.go

# 🚀 Run 'url' command
go run main.go url -u <your_wordpress_url>

Codecov Report
Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@2250645). Click here to learn what that means.

Files
Patch %
Lines

cmd/root.go
0.00%
17 Missing :warning:

cmd/url.go
0.00%
8 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #13   +/-   ##
======================================
  Coverage        ?   0.00%
======================================
  Files           ?       5
  Lines           ?     216
  Branches        ?       0
======================================
  Hits            ?       0
  Misses          ?     216
  Partials        ?       0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MessageSigner: Return some info about valid signatures

This is useful if we want to collect metrics on how old signatures are
when they are used, even if valid.
:eyeglasses: @MelissaCole @umbrae
cc: WEB-1622

:fish: lgtm

f5dd8522c609d8628ca90fedf5cd8b2ce67fe9be


The lost information in the documentation for Kafka engine

The lost information in the Kafka engine documentation (from commit: https://github.com/yandex/ClickHouse/pull/1654/files#diff-c9ba89e2414c83b5dcc579233c5c80b5) has been restored, modified and translated.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Thank you!


Feat: global statusline support

Requested feature
add configuration to allow users to use the new laststatus = 3 https://github.com/neovim/neovim/pull/17266

I think block needs to not set laststatus = 2
https://github.com/nvim-lualine/lualine.nvim/blob/88a44ade818f9ee7ba730aa4096250e22b243808/lua/lualine.lua#L266-L277
These are the only two instances of laststatus  in the code.

Commenting those lines and adding vim.opt.laststatus = 3 in my local configuration seems to do the trick:

I can submit a PR to remove those lines.

I was actually testing the pr well before it got merged. feat/add_opt/gs branch has support for it . It introduces a globalstatus option and sets laststatus according to that . @kdheepak I think that's a better approach then requiring users to setup laststatus by themselves .

Sounds good to me!

Works great!

This is not working for me on NVIM v0.7.0-dev+1269-g746a29c58, setting globalstatus to true prevents lualine from showing up at all.

@harrisoncramer Requires  https://github.com/neovim/neovim/commit/5ab122917474b3f9e88be4ee88bc6d627980cfe0. You are just a few commits behind.

Setting vim.opt.laststatus=3 is not working as I anticipated with lualine. I'm on neovim NVIM v0.7.0-dev+1275-g00effff56. When I explicity run :set laststatus=3 after neovim opens the global line works, but vim.opt.laststatus does not apply even when set after lualine is loaded. It's to my understanding though that I don't need to set laststatus at all as lualine manages that via the globalstatus option in the lualine config. Any pointers on what I've missed?
Here's my relevant configurations if that helps: lualine & options (see the end of the file).

@treatybreaker did you update lualine ?

Yep, on both my remote CentOS system & my local install.

Start neovim with -V1 flag like this
nvim -V1

then check what does this command say
:set laststatus?

@shadmansaleh very good advice, found my issue. Had a conflicting line in my configuration that was setting laststatus for dashboard incorrectly to 2 on non-dashboard files.
I have it working now; would recommend anyone else running into my issue to refer to @shadmansaleh advice above.
Thanks again @shadmansaleh :)

Sorry to bump this issue, but I don't know if this is a bug or I just forgot a setting. This is how it looks to me when using lualine:

which in my opinion is wrong! The statusline should be full width on the bottom instead of on a single buffer! When I start neovim without any plugins it looks like this:

which looks correct to me.

upgrade neovim to master, upgrade lualine to master. set globalstatus option to true.
require('lualine').setup({
  options = {globalstatus = true}
})

If still doesn't work follow this to figure out why you're laststation options in neovim isn't set to 3.

Thanks! That config-parameter was the missing piece


Release: 0.6.0a

Scalar records properly support const-ness. The Particle Patch load interface was changed, loading now all patches at once, and Python bindings are available. Numpy dtype is now a first-class citizen for Python Datatype control, being accepted and returned instead of enums. Python lifetime in garbage collection for containers such as meshes, particles and iterations is now properly implemented.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Pm mb 14811 adjust net weight by weight ticket status

Jira ticket for this change
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps

Access the
Login as a

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 72442382cbd3d16ce5294f38d81c2b8ae61bca93

@felipe-lee I believe everything is addressed now. And I think the test to ensure the final incentive gets updated is enough but if you feel otherwise I can try to add that in tomorrow

Awesome, thanks for making those updates. This lgtm!
Then only suggestion (non-blocking) I have is that I liked that you were setting explicit weights in the test before, since that makes the test not depend on the defaults set for weights in the Make functions. It's also not a huge deal to leave it as is though since if those defaults ever do change, the PR that changes them will flag any tests that fail and they can be updated accordingly.

That sounds worthwhile, I just pushed up changes for this

LGTM too! It looks like the test coverage decreased, you can do a quick type check and add it to the assertions for one of the tests to satisfy the coverage requirement.


Number of copies - does not affect the deposit price

Create NFT - add NFT to the collection. When adding more copies- it shows still the price of deposit for 1 NFT even though minting more copies I guess means paying more?
Tried on all chains its same. We need to show the real deposit price.
https://github.com/kodadot/nft-gallery/assets/104380776/74664e69-aa8a-4fe3-99c9-2ef9b2eccf3e

good one, thanks


Added Italian banks registry

Hi @mdomke,
I've created italian bank registry generator and generated with it the registry. With that I've removed manual_it.json which did not contain even fraction of registered Italian banks.
I'm using 2 sites to obtain banks list:

https://www.theswiftcodes.com/italy/ to get set of BICs
https://www.ibancalculator.com/blz.html to get full information - name, bic, bank code

There exists some probably official site with all banks, but it lacks some information, like BIC, hence I think I cannot be used - https://infostat.bancaditalia.it/GIAVAInquiry-public/ng/.
Please take look at it, in any case I'll follow up on any feedback Otherwise I'll ask you to make pip release after it's merged, if possible.
Thank you for this library. 🙏
Have a nice day,
@Krystofee

Hi @Krystofee, I'm sorry that I haven't been very responsive, and you had to wait so long for an answer. Is there any chance that you can resolve the merge conflict? I think we can merge your pull-request otherwise.


Remove context from client creation and add to each client function

I have read the CLA Document and I hereby sign the CLA


⚠ Ansible Galaxy API has degraded performance

In fb030b7, Ansible Galaxy API (https://galaxy.ansible.com/api/v2/) experienced degraded performance:

HTTP code: 200
Response time: 4630 ms

Resolved: Ansible Galaxy API performance has improved in de1de4a.


Parser doesn't show running balance or opening/closing balance at transaction level

I have tried couple of files but the code in the documentation doesn't seem to work. Not able to retrieve the balances on each transaction as the documentation promises. I have used the same code mentioned here but still the balances don't come under the transaction entry. All I can see in the transaction entry is as below.
With using the balances code snippet.
{'amount': <2000.00 INR>,
 'bank_reference': None,
 'currency': 'INR',
 'customer_reference': '2414920200712000',
 'date': Date(2020, 7, 12),
 'entry_date': Date(2020, 7, 13),
 'extra_details': '100369167',
 'funds_code': 'R',
 'guessed_entry_date': Date(2020, 7, 13),
 'id': 'NMSC',
 'status': 'C',
 'transaction_details': '211070869/019492400304/801915008565/BHARAT'}

Basic parsing code snippet:
{'amount': <2000.00 INR>,
 'bank_reference': None,
 'currency': 'INR',
 'customer_reference': '2414920200712000',
 'date': Date(2020, 7, 12),
 'entry_date': Date(2020, 7, 13),
 'extra_details': '100369167',
 'funds_code': 'R',
 'guessed_entry_date': Date(2020, 7, 13),
 'id': 'NMSC',
 'status': 'C',
 'transaction_details': '211070869/019492400304/801915008565/BHARAT'}

Doesn't seem to be much different or am I missing anything very trivial?

Oops... I didn't see this issue.
In any case, it depends on your file of course. You can try the example files to see some results that do work:
import mt940
import pprint

mt940.tags.BalanceBase.scope = mt940.models.Transaction

# The currency has to be set manually when setting the BalanceBase scope to Transaction.
transactions = mt940.models.Transactions(processors=dict(
    pre_statement=[
        mt940.processors.add_currency_pre_processor('EUR'),
    ],
))

with open('mt940_tests/betterplace/sepa_mt9401.sta') as f:
    data = f.read()

transactions.parse(data)

for transaction in transactions:
    print('Transaction: ', transaction, transaction.data.get('available_balance'))

Without knowing the structure of your file I can't tell you what the problem is


[XMonad.Layout.NoBorders] OtherIndicated Ambiguity + Fullscreen issues

I've been experiencing some issues with OtherIndicated Ambiguity and the Fullscreen layout, and I think I've narrowed down the issue.
All OtherIndicated does is prevents borders from being drawn on windows, if all other screens have borders drawn. This allows workspaces with a single window to have no borders, assuming there's other workspaces active with multiple windows open (since there's no reason to see a border on a full screened window if the other workspaces have an indicator for focus).
Assuming there's a focused Full layout, with more than 1 windows, and another active Full layout (on another screen) with more than 1 windows - borders are never drawn. This is due to the logic of OtherIndicated, which is not able to detect other screens shown windows after the layout is done building. See: here for the main code. The code is checking against "wrs" parameter, which is effectively the actively shown windows in the current screen after the layout is drawn. However, there is no "otherWrs" param (for lack of better name) which contains the actively shown windows on the other screens after those layouts are drawn.
This likely would involve some fair refactoring of the layout code for ConfigurableBorder, and of course refactoring of the SetsAmbiguous hidden method.
Not a huge deal but I thought I would report the issue in case anybody else is trying to track this down. Any suggestions on steps to fix/remedy this would be great as I'd love OtherIndicated borders, but am unable to use them since I use full screen windows fairly heavily.

I see two possible solutions:

Use a new (stateless) layout to track [(Window,Rectangle)] layout results in an ExtensibleState per-workspace map. This is a pretty specific (which other modules would need this new layout) and odd solution (usually ExtensibleState uses eventHook/logHook).

Use queryTree/XQueryTree in NoBorders.hs::redoLayout on the root window of every workspace except the current.

Then using the current stack and floating map to partition the results, per workspace, into floating windows, stackless tiled windows (i.e. decorations), and stacked tiled windows.
@geekosaur You've been pretty adamant about the performance penalties involved with XQueryTree, is it really worse than doing the same from within XMonad? You have a preference between 1/2?

Actually XMonad.Actions.UpdatePointer should be updated to use this information, to clip the focused window. Right now its very buggy.

Issue is still present as of today. I apologize if bumping is not allowed.


Move wildfly-openssl dependency management to root pom

Move wildfly-openssl dependency management to root pom

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (4ddb6ff).
Report is 88 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12597       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2375       -61
  Lines        133233   129980     -3253
  Branches      20636    20146      -490
=============================================
- Hits          82274        0    -82274
- Misses        44911   129980    +85069
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Toggle text case (lowercase/uppercase etc.)

Description of the new feature / enhancement
When writing (filling a form etc.) you could toggle the case (lowercase/UPPERCASE etc.) of the selected text, like in PowerRename.
Scenario when this would be used?
Sometimes when you copy/paste text somewhere, you would need to be able to change the case of the text. Now you have to paste it to MS Word and toggle the case in there, and then copy/paste it again.
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/907


Mesher crashes when run as a file upon exit

This is a non-critical issue since the crash occurs AFTER all of the script has run. I currently believe the crash occurs while resources are being freed up as the python interpreter exits. Here is a test-case e.g. crashtest.py:
from build123d import *

with BuildPart() as board:
    Box(1, 2, 3)

exporter = Mesher() # generates one exception
exporter.add_shape(board.part) # generates a second exception

Run like:
$ python crashtest.py
Exception ignored in: <function Base.__del__ at 0x7f0458f61120>
Traceback (most recent call last):
  File "/home/oem/miniconda3/envs/ocp_vscode2/lib/python3.11/site-packages/py_lib3mf/Lib3MF.py", line 4327, in __del__
  File "/home/oem/miniconda3/envs/ocp_vscode2/lib/python3.11/site-packages/py_lib3mf/Lib3MF.py", line 4091, in Release
  File "/home/oem/miniconda3/envs/ocp_vscode2/lib/python3.11/site-packages/py_lib3mf/Lib3MF.py", line 4026, in checkError
AttributeError: 'NoneType' object has no attribute 'SUCCESS'
Exception ignored in: <function Base.__del__ at 0x7f0458f61120>
Traceback (most recent call last):
  File "/home/oem/miniconda3/envs/ocp_vscode2/lib/python3.11/site-packages/py_lib3mf/Lib3MF.py", line 4327, in __del__
  File "/home/oem/miniconda3/envs/ocp_vscode2/lib/python3.11/site-packages/py_lib3mf/Lib3MF.py", line 4091, in Release
  File "/home/oem/miniconda3/envs/ocp_vscode2/lib/python3.11/site-packages/py_lib3mf/Lib3MF.py", line 4026, in checkError
AttributeError: 'NoneType' object has no attribute 'SUCCESS'

I currently suspect that some logic can be added to class Mesher that will solve this problem (such as to free up resources as the script exits somehow). It also could be a problem with the lib3mf python bindings.

And I just realized that this was in fact a PEBKAC issue, I missed the .part in the add_shape.
My apologies for polluting the thread.


Per-pallet child tries

There should be a variant of decl_storage that stores all items in a child-trie rather than the main trie.
Storage format/hashing should be equivalent, except that there should be no module prefix.
Additionally, there should be migration code allowing for modules using the existing system (e.g. Kusama) to migrate their modules' storage over to per-pallet child tries during an upgrade.
Change tries should be made to work on child tries as per the main trie.

I unassigned for two weeks but here is my current progress:
First idea:
I wanted to introduce a new structure: StorageSpace, this storage space should be an isolated space in the storage used by the modules storages.
it would implement the following trait:
/// An abstract storage. Can be used to generalize over a prefixed space in the top trie, or in a
/// child trie.
pub trait StorageSpace {
	type StorageSpaceIterator: Iterator<Item=(Vec<u8>, Vec<u8>)>;

	/// Get a Vec of bytes from storage.
	fn get(&self, key: &[u8]) -> Option<Vec<u8>>;

	/// Put a raw byte slice into storage.
	fn put(&self, key: &[u8], value: &[u8]);

	/// Check to see if `key` has an explicit entry in storage.
	fn exists(&self, key: &[u8]) -> bool;

	/// Ensure `key` has no explicit entry in storage.
	fn kill(&self, key: &[u8]);

	/// Ensure keys with the given `prefix` have no entries in storage.
	fn kill_prefix(&self, prefix: &[u8]);

	/// Iter over all (key, value) of the storage after the given `prefix`
	fn iter_prefix(&self, prefix: &[u8]) -> Self::StorageSpaceIterator;
}

This trait would be implemented for three structure:

Structure 1: in main trie after a module prefix and a storage prefix
Structure 2: in a module childtrie after a storage prefix
Structure 3: in a module_storage childtrie after no prefix.

I would imagine this space structure to implement migration from one to one another, just be iterating on them while removing their value and adding value to new space.
Also we could support lazy_migration by just having a partial migration at every block plus when getting a value (or iterating or else..) we would get from both space.
This is obviously costy but meant to be temporar.
Second idea:
(in this part we talk about StorageMap but this is generalizable to all 4 storage kind).
Note: such StorageSpace an ok idea to me, though we should notice that this doesn't cover everything. For example a migration between StorageMap<Hasher=twox_concat, Trie=MainTriePrefixed> to StorageMap<Hasher=blake2_256_concat, Trie=ChildTriePrefixed> is in principle doable but no implementable by this storage space structure as it doesn't have hash informations.
Considering this limitation maybe it is better not to introduce this intermediate abstraction and just create a new associated type to our StorageMap which would be:
trait StorageMap {
  type Trie: Trie;
  fn hashed_module_prefix() -> &'static [u8]; // make it empty if you are in a module unique child trie
  fn hashed_storage_prefix() -> &'static [u8]; // make it empty if you are in a module_storage unique child_trie
}

having these module_prefix hashed at compile time is doable, you can't import sp_core at compile time because it seems features are mixed by cargo but you can import twox-hash crate and reimplement twox_128 yourself. (though we might want to create a sp_core_compile_time crate or such thing)
So implementing all kind of migration from one StorageMap to one another should be possible.
Like we could do:
migration_same_hasher<Hasher, StorageMap1<Hasher=Hasher>, StorageMap2<Hasher=Hasher>>(..)

migration_hasher_concat<
  Hasher1: HasherConcat,
  Hasher2: HasherConcat,
  StorageMap1<Hasher1Concat>,
  StorageMap2<Hasher2Concat>
>(..)

But when it come to lazy migration, it is more difficult, the only thing I see it to crate a new trait StorageMapLazyMigration and which would have two associated type StorageMap1 and StorageMap2 and do a lazy migration between both.
Note that maybe lazy migration is not very interesting as is or should be done in some other way.
Current wip branch is gui-module-in-childtries: https://github.com/paritytech/substrate/compare/gui-module-in-childtries?diff=unified&expand=1

Yeah i figured i wasn't going to be the only one who's thought of this, I wonder if there's a tracking issue for custom keys for storage items 🤔

@thiolliere any updates on this one?


Code-first approach

Hey @pabloordonez @lbrugnara @bgrainger
First let me say BIG THANK YOU for the great work you did on the Paradigm ORM.
Are you planning on introducing a code-first approach for the ORM?
It would be very helpful to be able to generate the database schema for deploying new tables.
I don't mean the migrations where you would need to generate a diff script for the database.

Hey @turowicz thanks!
To tell you the truth, It wasn't on our plans, mostly because we started this as way or get back DbFirst, as stated in the documentation.
Originally (like 3 or 4 years ago) when we started this, we were most interested into design the database in the database and not the other way around. In our experience DbFirst stimulates bad coding practices, db without the proper structure, and a abuse of Linq where one should use Stored Procedures and Db objects.
But I definitely can see the advantage of being able to kickstart a quick project. We do have most of the information required in the form of Attributes decorating the types. We could use that to produce a valid script. We would also need to modify (add) each db format provider in order for us to get the proper DDL syntax for each database. As a quick example, creating a table in MySql could be as simple as:
CREATE TABLE IF NOT EXISTS `my:_table`  (...) ;

But in the case of TSQL, we should think on something like:
IF NOT EXISTS (SELECT * FROM [sysobjects] WHERE [name]='MyTable'')
    CREATE TABLE [MyTable](...);
GO

Also, we would need a new tool like DbFirst or DbPublish to open the assembly, extract the attributes and structure from the reflection AST and then produce (and even run) the publish script.
We could even think of a migration tool in the future, but that could take a lot of time, and we are not really using CodeFirst internally.
I'll give more thought to the idea, maybe there's a good solution that can be added relatively easy. At least for the most common scenarios.

Thanks for rapid answer, I see your point.
DbFirst is useful when migrating between systems, like I currently am switching from MS SQL to Cassandra.

I would like to hear how you were thinking this migration.
Take in mind that if db migration is what you had in mind, is not that simple. You'll need to adapt the Attributes from the MySql database to match cassandra types. Most of them can probably be used as it is.
But, In my experience (and I'm not an expert) is not that simple. Is not only that the paradigms are completely different, the inner works as well. Partition key are not mere primary keys, you need to think about you want to partition your data, how the data will be replicated, obtained or stored. Normally, with cassandra, you want to design your table based on your query, something that would be considered a bad practice in the formal sql world.  Even indices, produce duplicated SSTables or the like to store the same information but indexed by a different key.
Don't want to sound preachy, it's just friendly advice in case you're new to cassandra/scylla. If you are not, ignore all I said above 😄

I'm not new :) I was originally using Azure Table Storage which is more like Cassandra. Some clients required us to use an on-premise DB so we picked MS SQL. It doesn't make the cut so we are now replacing it with Cassandra.
We don't need any complicated migration, just to generate a database schema creation script.


Does one need a "Certificate" as well to build and use APO (Audio Processing Objects)?

I heard that if you want to create a driver e.g. test.sys and use it without restriction, it needs to be signed. I know that one can build driver and run in test mode, but that doesn't speak for me as a non-profit thing at all.

But what about APO? These COM things or whatever it is. Do custom APO also have to be signed or not?
Can someone please tell me?

@microsoft/windowsaudio can you please take a look

Audio processing objects load in audiodg.exe which runs as a child process of the audiosrv service in session 0, and therefore need to be signed. If you're installing on a test system, test-signing is okay. If you're installing a production system they need to be production-signed; Microsoft will production-sign your driver for you if you submit it to Hardware Dev Center.
Test instructions here: https://github.com/microsoft/Windows-driver-samples/tree/main/audio/sysvad
Submission to Hardware Dev Center instructions here: https://learn.microsoft.com/en-us/windows-hardware/drivers/dashboard/hardware-submission-create
More on signing drivers: https://learn.microsoft.com/en-us/windows-hardware/drivers/develop/signing-a-driver


lspsaga and/or lspconfig leaks memory

Description

Upon using using goto definition split and exiting memory is leaked. This can be checked with compiling neovim with ASAN. Instructions below.
Expected Behavior

No memory leak. Memory leaks indicate potentially broken behavior.
Actual Behavior

Output message:
nvim src/lib/pde.h
1 lua references were leaked!
Logs
=================================================================
==279920==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 3 byte(s) in 1 object(s) allocated from:
#0 0x55e93a7806d9 in malloc (/home/misterspoon/.local/asan_nvim/bin/nvim+0x5ba6d9)
#1 0x55e93abe7b3a in try_malloc /home/misterspoon/dev/git/c/neovim/build/../src/nvim/memory.c:73:15
#2 0x55e93abe7b3a in xmalloc /home/misterspoon/dev/git/c/neovim/build/../src/nvim/memory.c:107:15
#3 0x55e93ab66782 in nlua_ref /home/misterspoon/dev/git/c/neovim/build/../src/nvim/lua/executor.c:1022:47
#4 0x55e93ab60b70 in nlua_pop_Object /home/misterspoon/dev/git/c/neovim/build/../src/nvim/lua/converter.c:1211:22
#5 0x55e93ab5ff7b in nlua_pop_Dictionary_unchecked /home/misterspoon/dev/git/c/neovim/build/../src/nvim/lua/converter.c:1009:30
#6 0x55e93ab5ff7b in nlua_pop_Dictionary /home/misterspoon/dev/git/c/neovim/build/../src/nvim/lua/converter.c:1047:10
#7 0x55e93a7b9558 in nlua_msgpack_nvim_buf_attach /home/misterspoon/dev/git/c/neovim/build/src/nvim/auto/msgpack_lua_c_bindings.generated.c:63:37
#8 0x55e93b04b7ac in lj_BC_FUNCC (/home/misterspoon/.local/asan_nvim/bin/nvim+0xe857ac)
SUMMARY: AddressSanitizer: 3 byte(s) leaked in 1 allocation(s).

Neovim Built in Behavior

This question looks not relevant. Otherwise shortly elaborate.
Details

Reproduce

Compile neovim with asan as written here:

git clone https://github.com/neovim/neovim
CMAKE_EXTRA_FLAGS="-DCMAKE_C_COMPILER=clang -DCLANG_ASAN_UBSAN=1" make CMAKE_BUILD_TYPE=RelWithDebInfo CMAKE_INSTALL_PREFIX=$HOME/.local/asan_nvim install
alias asannvim='UBSAN_OPTIONS=print_stacktrace=1 ASAN_OPTIONS=log_path=/tmp/nvim_asan ${HOME}/.local/asan_nvim/bin/nvim'
asannvim -u init.lua

run :PackerSync
go over symbol with reference to another file
run :lua require'lspsaga.provider'.lsp_finder() or use the convenient keymapping
s (open as split)
:qa
have leak

Minimal reproducable files:
init.lua
vim.o.termguicolors     = true;
require('_packer');
require'lspconfig'.clangd.setup{}
local opts = { noremap=true, silent=true }
vim.api.nvim_set_keymap('n', 'gh',    [[<cmd>lua require'lspsaga.provider'.lsp_finder()<CR>]], opts) --i,o,s,

lua/_packer.lua
return require('packer').startup(
function()
  use { 'wbthomason/packer.nvim' }
  use { 'glepnir/lspsaga.nvim', branch = 'main', requires = { 'neovim/nvim-lspconfig' } } --gh: o,s,i,q,'<C-f>','<C-b>'
end)

Environment

nvim --version output: NVIM v0.5.0-dev+1469-ge8247bc73
Operating system: Linux Endeavour (Arch derivate)
lspsaga commit: cb0e35d2e594ff7a9c408d2e382945d56336c040

This neovim PR looks related: https://github.com/neovim/neovim/pull/11938. Associated reddit discussion here: https://www.reddit.com/r/neovim/comments/ofoz57/many_awesome_plugins_rely_on_floating_windows/.


use the correct workflow

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35

Relevant Lines:
35

💛  - Coveralls


Wheel is placed in the previous release rather than the newly registered one

When releasing pandaSDMX 0.8, the Wheel was erroneously uploaded to v0.7.0:
https://pypi.org/project/pandaSDMX/0.7.0/#files
The source distro is in the right place though. Trying to re-upload the Wheel yields an error msg as the file is already present.
Environment:
Win7x64, Py3.5 32bit, Wheel 29.0, twine 1.9.1.

@dr-leo How was this wheel generated? It's a little strange, because it contains metadata for both 0.7.0 and 0.8 which likely confused twine
$ tar -xvvf pandaSDMX-0.8-py2.py3-none-any.whl
x pandasdmx/agencies.json
x pandasdmx/api.py
x pandasdmx/model.py
x pandasdmx/remote.py
x pandasdmx/__init__.py
x pandasdmx/reader/sdmxjson.py
x pandasdmx/reader/sdmxml.py
x pandasdmx/reader/__init__.py
x pandasdmx/utils/aadict.py
x pandasdmx/utils/anynamedtuple.py
x pandasdmx/utils/__init__.py
x pandasdmx/writer/data2pandas.py
x pandasdmx/writer/structure2pd.py
x pandasdmx/writer/__init__.py
x pandaSDMX-0.7.0.dist-info/DESCRIPTION.rst
x pandaSDMX-0.7.0.dist-info/metadata.json
x pandaSDMX-0.7.0.dist-info/top_level.txt
x pandaSDMX-0.7.0.dist-info/zip-safe
x pandaSDMX-0.8.dist-info/DESCRIPTION.rst
x pandaSDMX-0.8.dist-info/metadata.json
x pandaSDMX-0.8.dist-info/top_level.txt
x pandaSDMX-0.8.dist-info/zip-safe
x pandaSDMX-0.7.0.dist-info/WHEEL
x pandaSDMX-0.8.dist-info/WHEEL
x pandaSDMX-0.7.0.dist-info/METADATA
x pandaSDMX-0.8.dist-info/METADATA
x pandaSDMX-0.7.0.dist-info/RECORD
x pandaSDMX-0.8.dist-info/RECORD

After bumping the version in setup.py to 0.8, I did the usual

python Setup.py build sdist bdist_wheel

However, the build subdir contained previous builds. And there was an
egg.info as usual. The upload with twine did not yield any error:

twine upload dist/*

The dist dir contained only the two mentioned files.
On 14/12/2017, Dustin Ingram<EMAIL_ADDRESS>wrote:

@dr-leo How was this wheel generated? It's a little strange, because it
contains metadata for both 0.7.0 and 0.8 which likely confused twine
$ tar -xvvf pandaSDMX-0.8-py2.py3-none-any.whl
x pandasdmx/agencies.json
x pandasdmx/api.py
x pandasdmx/model.py
x pandasdmx/remote.py
x pandasdmx/__init__.py
x pandasdmx/reader/sdmxjson.py
x pandasdmx/reader/sdmxml.py
x pandasdmx/reader/__init__.py
x pandasdmx/utils/aadict.py
x pandasdmx/utils/anynamedtuple.py
x pandasdmx/utils/__init__.py
x pandasdmx/writer/data2pandas.py
x pandasdmx/writer/structure2pd.py
x pandasdmx/writer/__init__.py
x pandaSDMX-0.7.0.dist-info/DESCRIPTION.rst
x pandaSDMX-0.7.0.dist-info/metadata.json
x pandaSDMX-0.7.0.dist-info/top_level.txt
x pandaSDMX-0.7.0.dist-info/zip-safe
x pandaSDMX-0.8.dist-info/DESCRIPTION.rst
x pandaSDMX-0.8.dist-info/metadata.json
x pandaSDMX-0.8.dist-info/top_level.txt
x pandaSDMX-0.8.dist-info/zip-safe
x pandaSDMX-0.7.0.dist-info/WHEEL
x pandaSDMX-0.8.dist-info/WHEEL
x pandaSDMX-0.7.0.dist-info/METADATA
x pandaSDMX-0.8.dist-info/METADATA
x pandaSDMX-0.7.0.dist-info/RECORD
x pandaSDMX-0.8.dist-info/RECORD

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pypa/warehouse/issues/2675#issuecomment-351786601

@dr-leo Thanks for the additional details. I'd recommend opening this issue in two other places:

https://github.com/pypa/wheel/issues/ (to determine how and why that wheel was built the way it was)
https://github.com/pypa/twine/issues/ (to determine if there is a way that twine can guard against this happening)

In this case, twine told Warehouse that this wheel was for version 0.7.0, so that's where it was put, and as such this doesn't seem to be an issue within the scope of Warehouse, so I'll close this issue.

Thanks. Done.

Am 15.12.2017 um 22:51 schrieb Dustin Ingram<EMAIL_ADDRESS>Closed #2675.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I firmly believe this issue should be re-opened because

Warehouse is the only Gatekeeper capable of preventing PyPI from being polluted by faulty wheels (with two sets of metadata) generated by Buggy Wheel tool and uploaded by twine versions that do not perform the integrity checks.
Even if twine and/or Wheel were fixed, old versions would still potentially pollute PyPI.

See the closed issue at https://github.com/pypa/twine/issues/284
The Wheel People have so far vainly tried to reproduce the error. I'll see if I can set up a repo on github making the Buggy build process reproducible.
It should be a matter of a few lines in Warehouse to check if a Wheel to be uploaded contains more than one distinfo items and reject it in the affirmative.
Leo

I think this is going to be more than "a few lines" because Warehouse does not do any introspection of the distributions it receives, it depends on the introspection that Twine has done and has provided as metadata along with the upload.
I think reproducing the issue is the first step here, though. I am not aware of any other similar occurrences, so fixing any original bug should probably be enough to resolve this.

I have set up a repo demonstrating the bug:
https://github.com/dr-leo/wheelbug
It contains the build and dist dirs as well as egg.info.
It has two commits: The first is a snapshot at v0.9. The wheel is
buggy as it also contains the distinfo for the previous v0.8.2. The
2nd commit captures the state after building v0.10. The new wheel
contains three distinfos, namely for 0.8.2, 0.9 and 0.10. It looks
like this appending business could continue forever.
Hope this helps to reproduce the bug or at least to add a sanity check
to warehouse.
That said, I would love to see the build toolchain fixed to avoid
building such insane wheels in the first place.
On 09/04/2018, Dustin Ingram<EMAIL_ADDRESS>wrote:

I think this is going to be more than "a few lines" because Warehouse does
not do any introspection of the distributions it receives, it depends on the
introspection that Twine has done and has provided as metadata along with
the upload.
I think reproducing the issue is the first step here, though. I am not aware
of any other similar occurrences, so fixing any original bug should probably
be enough to resolve this.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pypa/warehouse/issues/2675#issuecomment-379757072

I am afraid I am somewhat confused by multiple issues opened on the
same problem.
So I re-post my earlier messages in this thread.
Done. See the latest commit containing the newly created build and
dist dirs. - There is a single distinfo in dist.win32, as you can see.
So the wheel seems to be correct now.
I might add that the build process Ends with an "Access denied" error,
a known issue on Windows in other circumstances. I have no idea which
Operation fails if any. Maybe an attempt to remove some files in the
build dir which interfere with the next build...
On 14/04/2018, Leo<EMAIL_ADDRESS>wrote:

I have set up a repo demonstrating the bug:
https://github.com/dr-leo/wheelbug
It contains the build and dist dirs as well as egg.info.
It has two commits: The first is a snapshot at v0.9. The wheel is
buggy as it also contains the distinfo for the previous v0.8.2. The
2nd commit captures the state after building v0.10. The new wheel
contains three distinfos, namely for 0.8.2, 0.9 and 0.10. It looks
like this appending business could continue forever.
Hope this helps to reproduce the bug or at least to add a sanity check
to warehouse.
That said, I would love to see the build toolchain fixed to avoid
building such insane wheels in the first place.
On 09/04/2018, Dustin Ingram<EMAIL_ADDRESS>wrote:

I think this is going to be more than "a few lines" because Warehouse
does
not do any introspection of the distributions it receives, it depends on
the
introspection that Twine has done and has provided as metadata along with
the upload.
I think reproducing the issue is the first step here, though. I am not
aware
of any other similar occurrences, so fixing any original bug should
probably
be enough to resolve this.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pypa/warehouse/issues/2675#issuecomment-379757072


Mutate response body

We are writing a go plugin to transform the body of the response, we can obtain the body via kong.ServiceResponse.GetRawBody() but it seems we have no way of setting the response body?

the ServiceResponse is what you get from the target, you can't modify it.  But you can definitely change what it's sent back to the client with the  argument of kong.Response.Exit()

Please open a Discussion in Kong/kong/discussions if you have more questions!


Add the other two Dominican Republic area codes.

We have reports that Dominican Republic has three area codes in the country now.
Dominican Republic: +1-809, +1-829, +1-849
I suppose there are two ways to accomplish this, set the country code to +1 and allow the users to enter the area code by changing min and max length. Or adding duplicate country entries for the area codes. I opted for the latter initially. However, I reconsidered, and made this more line how Canada is defined, and allow people to enter their own area code.

Thanks for contributing, but I just merged this from #244

Thanks for your help marcaureln

You're welcome :wink: Thank you all for using the package and also contribute :+1:


What 'Type is 'application/json;charset=UTF-8', It does not test except customized payload (custom/blind)' mean?

Question
What I understand from the output message is that the target is receiving JSON inputs and I need to create a custom payload to attempt a XSS attack?
How can I do this?
[*] Static analysis done ✓
[*] Parameter analysis  done ✓tines
[*] BAV analysis done ✓ing routines
[I] Content-Security-Policy is frame-ancestors 'self'
[I] X-Frame-Options is SAMEORIGIN
[I] Strict-Transport-Security is max-age=31536000
[I] Content-Type is application/json;charset=UTF-8
[*] Generate XSS payload and optimization.Optimization.. 🛠
[*] Type is 'application/json;charset=UTF-8', It does not test except customized payload (custom/blind).
[*] Start XSS Scanning.. with 0 queries 🗡
[*] Finish :D

Environment

Dalfox Version:
Installed from: (e.g go-get/snapcraft/homebrew)

Hi @pdelteil
Sorry for late reply and thank you for submit issue!
dalfox check at content-type and scans only for types that can be triggered XSS. Typically, if the content-type is application/json, it is not possible to trigger on the actual browser.

Hi @pdelteil
Sorry for late reply and thank you for submit issue!
dalfox check at content-type and scans only for types that can be triggered XSS. Typically, if the content-type is application/json, it is not possible to trigger on the actual browser.


How is the performance boost achieved?

Would be great to include how did you achieve the performance boost in the README, especially if the performance boost comes at the cost of something else - otherwise I wonder why python-ecdsa couldn't do the same thing if it's better in every way (perhaps just because it's less maintained?), if it's too good to be true...
Of course if the perf boost comes at no cost, would help to state that explicitly as well so it's clear.
Thanks!

python-ecdsa is written in pure python, this package is written using GMP, a C library specifically for big integer arithmetic. That's where the performance increase comes in. In general, C code is going to run a lot faster than python is.

Gotcha, thanks.


README.md example incorrect

Last example in README.md Command Line Usage section,

python3 -m collidoscope -c 5 -cursive yourfont.otf

This just runs an area test for two-character sequences across the basic Arabic range.

the command appears to be the same as the previous example (the one which "may take a number of years to compute").

This was fixed locally, but not pushed. Should be OK now!


Error processing url in static directory.

I created a directory "img" in the static directory, added pictures there. But the file index.html did not create. When i navigate to the \img\ url, the browser waits for the page indefinitely. On the node server it gives an error:
07:52:22  W1   error   unhandledRejection: RangeError [ERR_OUT_OF_RANGE]: The value of "end" is out of range. It must be >= 0 && <=<PHONE_NUMBER>740991. Received -1
new ReadStream (node:internal/fs/streams:201:5)
Object.createReadStream (node:fs:3060:10)
Static.serve (\node_modules\impress\lib\static.js:76:32)

Fixed in https://github.com/metarhia/impress/pull/1897


API endpoint to classify an emotion

I would like to: Build an API endpoint to classify a emotion (using the demo project files)
So that I can: Test the deployment of the sample demo project

The following API endpoint being developed should conform to test-driven development (TDD) using Mocha.js and Chai.js. It should accept an input audio file with speech and output the emotion classified from that file.

Done in endpoint-classify-emotion branch.


Set up a devcontainer as part of the Rust template

This is very closely based on the Spin codespace/devcontainer work by @craiglpeters, and it's possible that some bits could be refined (e.g. the Dockerfile uses the Rust baseline but then there is a Rust feature in the devcontainer.json as well).
With this change, when a user creates a Spin application using the http-rust templates, they will be able to build it in a devcontainer right off the bat, or in a GitHub codespace once they have committed it to GH.  spin up and spin deploy work fine, though spin up now auto-opens the browser (I assume based on the port forwarding settings) which I'm a bit doubtful about.  Also the user would need to tweak the port settings if they wanted to listen on a non-default port, but hopefully that wouldn't be an issue in a devcontainer.
With the current setup, the GH codespace takes a while to build - I do wonder if it would be faster if we created images with Spin and the appropriate tools - but that's harder to scale across multiple languages.
One thing I haven't figured out yet is how to make this play nicely with multiple components.  Like if I do a spin new http-empty and then add two components, I should be able to have a codespace with both of them in it.  And if one component is in Go and the other in Rust, the devcontainer declaration should be modified to include both languages' toolsets.
But anyway here's something to play with and provide feedback on.
Signed-off-by: itowlson<EMAIL_ADDRESS>

I can't seem to get the GitHub UI to choose the devcontainer configuration in this PR, only the one in the root, but I assume it can run locally.
 And to easy build time, we could consider a common image, which could be the same we would use for regression testing of the templates.
I think there's a larger conversation about how to organize all of this, as there's a direct dependency between SDKs, templates and devcontainer definitions.

Closing as pretty much stale at this point.

@itowlson I would appreciate a chat to help me understand better how we can better meet your use case

@craiglpeters I think part of the issue is that we're not sure what our use case is.  This was an exploration of having our template system generate devcontainers as part of new apps (when the user ran spin new).  It stalled on:

You couldn't use the devcontainer as a Codespace until you pushed the code to GitHub, so it didn't help people getting over the initial "how do I build this thing without weird errors" hump which is important to us.  (I know they can run devcontainers locally.)
@mikkelhegn raised a the issue of a devcontainer that would contain Spin itself together with the required toolchain so the user could do spin new within the devcontainer instead of doing spin new on the host and then entering an app-specific devcontainer (which is probably more economical).

Then we got distracted onto other things and hit the holiday break, and this PR languished and grew stale.
I think we need to clarify in our own minds what a good use case is for this, and then we can pick this up again in a more "here is a thing we know will make users happier" manner, rather than this PR which, in retrospect, was a bit "OMG CODESPACES ARE SO COOL LET ME TRY."


Can't add new properties to SetProperties action

Describe the bug
You can't add new properties to the SetProperties action in the nightly build. You can click add and the new fields show up but the moment you click into them they disappear.

Version
https://github.com/microsoft/BotFramework-Composer-Nightlies/releases/tag/v1.1.1-nightly.178300.83c0804

I can confirm this.  I had to switch to code view and manually add properties on Friday.

This is addressed on the main branch. Closing


pull request for e2e test at 12/20/2016 15:26:22

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding a GDScript inner class makes inspector tooltip for exported variables not work

Godot version
master
System information
W11
Issue description
This issue is present in master and 4.0.2 at least.
Without an inner class:

With an inner class:

Steps to reproduce
Drop this script onto a node and mouse-over the inspector exported variable.
extends Node

## This doc works
@export var my_var : int

class InnerClass:
	pass

Minimal reproduction project
N/A

Working on a fix for this one :)


Fix formating

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awsdunc  can you merge this one? 🙏


Request: Gitlab integration

Integrate with the popular Gitlab application.
API Docs: https://github.com/gitlabhq/gitlabhq/tree/master/doc/api

+1

I've posted #63 to address this issue. We're working to get this merged as soon as possible.

GitLab support has been merged! Please let us know if you run into any issues.

Hi, I'm not able to integrate crashlytics into our company's gitlab. It always says "Could not access project....". Do you know what could be the problem? Also do I need to set up something inside gitlab (other than to get the private key)?

Hey @xbezdeka , Mike here. Send me a note at support@ with the URL you're adding and I'll take a look.

I not sure what you mean by "support@", is it an incomplete email adress or some kind of nick to use on github conversation?:)

It's the shortened version of our contact. The full one is support (at) crashlytics (dot) com


Typo in document "Using Armeria with Spring WebFlux"

In the document Using Armeria with Spring WebFlux, the dependencyManagement of Gradle example seems wrong:
AS-IS:
dependencyManagement {
    imports {
        mavenBom '0.99.8'
        mavenBom '4.1.50.Final'
    }
}

TO-BE:
dependencyManagement {
    imports {
        mavenBom 'com.linecorp.armeria:armeria-bom:0.99.8'
        mavenBom 'io.netty:netty-bom:4.1.50.Final'
    }
}

This typo is fixed by https://github.com/line/armeria/pull/2874.

Oh, thank you 😃


Merging back to main.

Merging back.

Seems to be working.
Hello darkness my old friend.... Shoo away.