[CP Staging] Use isMultiLevelTags instead of isSingleLevelTags

cc @roryabraham @ikevin127
Details
Old logic: Tag lists is considered multi level if the list length is not 1
New logic: Tag lists is considered multi level if the list length is greater than 1
In the old logic if the list length is 0 (which happens when a workspace is created offline) we considered it a multi level list which is wrong. This PR fixes that
Fixed Issues

$ https://github.com/Expensify/App/issues/42092
PROPOSAL:
Tests

Go offline
Create a new workspace
Click on More features and enable tags
Go to the tags page
Verify that the "Add tag" button is displayed at the top

[X] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Same as Tests

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/16493223/b08422ec-1bcf-4811-9007-beea20087941

Android: mWeb Chrome

Networking issue

iOS: Native

https://github.com/Expensify/App/assets/16493223/a7428240-b047-4a3e-b4a2-9e5c1888e862

iOS: mWeb Safari

https://github.com/Expensify/App/assets/16493223/75f903e7-ef6f-4fff-a4bb-b8d5c41f6632

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16493223/07691061-fdab-49d5-9781-6658cff7e46b

MacOS: Desktop

https://github.com/Expensify/App/assets/16493223/79416def-e450-49f0-94e2-5c5a9ece6444

@s77rt Should I be C+ reviewing here ?

Yes since it's a regression

Cool, I'll complete the reviewer checklist and will ✅ Approve when I get assigned.

@ikevin127 assigned you.

@roryabraham did you want to take a look here?

Thanks for the quick fix @s77rt. Requested CP cc @Beamanator

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

CPing 👍

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 1.4.73-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Looking good in staging 👍

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.73-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[POST MATCH]

Good morning, I wanted to know if it is for sale or you can work on the post match to be able to add it to our transmissions and if so, how to contact it. Thanks a lot!

Post Game is TODO, I'll do it at some point. If you wish to help, feel free to create a pull request.


Requires assimp

Can be found in the package assimp on ArchLinux

Hi! Thanks again for the issue, but like with cl-devil this is provided by another system. In the longer term I'm gonna spin the image loading stuff out of cepl into helper libraries but for now cepl does require it.
Regards
Baggers

:+1:


feat: add fips and kata abe2e scenarios

What type of PR is this?

/kind feature
What this PR does / why we need it:
adds FIPS and Kata AgentBaker E2E scenarios
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.334%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2000

Relevant Lines:
2521

💛  - Coveralls

lgtm, how are we doing in run time? still pretty reasonable?

yeah we're still pretty good, in most cases < ~10 mins - though I've noticed that sometimes vmss deletion can hang and cause tests to run for a while. I feel that's more an issue with CRP rather than anything we're doing in the test itself


weights for non-leaf nodes

Is it possible to compute weights for non-leaf nodes as well?
This will enable interpreting results according to their decision paths: http://blog.datadive.net/interpreting-random-forests/

Purity scores are provided in the dump of the model

hey @pommedeterresautee , I don't understand - are "purity scores" the same as weights?

http://xgboost.readthedocs.io/en/latest/model.html

Thanks for your patience and sorry to keep on insisting, but I don't think that is what needed to implement the above approach for interpreting XGB results in terms of value changes along the prediction path, as described in the interpreter blog.
The purity score you provide in the model is the gain in splitting the node, and it includes the regularization term! What I need is a weighted average of the weights of the leaf nodes, assuming the tree structure is constant. How do you suggest I'll get that from the dump of the model?

@ihadanny If you really need those, they can be relatively easily computed using covers as weights when averaging values of branches for each node. There is a function within core framework which computes them, but the text dump is for it is not implemented.
BTW, the datadive-like interpretation of predictions was already implemented #2003 , and there is a better option in the works #2438 .


Function or Array of Variable Card values

Issue type:

:heavy_plus_sign: Feature request

Short description:
Either a function:
     return Value
}

Or an array:
```VariableCard["ID"]

Either of these would return the value of the variable card with the ID passed to it.  In the case of the array, the ID would be the index.

The same rules for Integrated Dynamics variable cards would still apply:  Have the variables contained in the network in order to be valid.

This opens the door for declaring variables within scripts that represent the values of variable cards directly.

Thanks for the suggestion!

Related to https://github.com/CyclopsMC/IntegratedDynamics/issues/839

my voice for this feature and it's still in the IntegratedDynamics logic

if we have our Scripting Drive with inserted Scripting Disk in the network where there are VariableStorages - why we can't queue them for a list of variables or for one with specific ID to return it's value?
Waiting for this feature to be implemented.


filter pill menu include / exclude logic doesn't match design

Noticing that the semantics around the filter pill menus w/ include + exclude are not what was in the design.
The filter pill menu should have the following behavior:

when I click on an entry, it should automatically apply that filter to the dashboard. The entry should remain in the menu for the duration of the menu being open so the user has a chance to toggle the filter back on. If this isn't a good idea, I think it'd be good to add back the apply button and use that to explicitly apply.
the include button on the bottom left of the menu should not be "apply" but instead should switch all the available menu items to whatever it's toggled to.

It appears that the include / exclude button in the menu actually is equivalent to "apply", which isn't quite right here. It needs to toggle the behavior, not serve as an affirmative action.
@magorlick @djbarnwal what do y'all think?

I agree with this note.
I would like each selection to change the dashboard in filter pills. As a user it will feel much more like "feedback with every click/keystroke". I would like the values I had selected to remain in the menu in case I want to revisit different combinations of values.
Then it does make sense to have that include/exclude button be the toggle and feel very similar to the one in the detail tables.

Moving this into 0.13, further discussion w/ Dhiraj. This should be pretty straightforward to land I think

reopening this issue @hamilton & @djbarnwal, because I think the behavior here is still not quite right: the text label should be static; it should always just say "Exclude". By default, we want users to be in Include mode (i.e. exclude mode turned off) and to opt in to Exclude mode (as is done in the legacy product). see https://www.notion.so/rilldata/using-toggle-switch-for-exclude-b0b9033394384443870b0c32372b355b for more details

@hamilton , what is the status of this work? I thought we changed it to a toggle is this still relevant?

@magorlick  -- it has been updated to a toggle, but the semantics is still wrong/confusing: the text should not change when the toggle does.

Why don't we add this note to the work on improving the gestalt of include and exclude filters instead of reopening this mostly-completed issue.
https://github.com/rilldata/rill-developer/issues/1038


Registering enum instances during read

Hi,
I saw a lot of (identical) enum instances in the org.nustaq.serialization.FSTObjectRegistry#idToObject map during reading.  And then I noticed the comment on this line: https://github.com/RuedigerMoeller/fast-serialization/blob/master/src/main/java/org/nustaq/serialization/FSTObjectInput.java#L474  After a brief inspection of FSTObjectOutput, I don't see any attempt at reusing the enum instances in the code.  It looks like they are always written with the tag ENUM and never as a HANDLE. So is there any other reason to store them in the idToObject map?
Thank you,
Eduard

Hm .. seems like the comment is right :). With growing user base I have become very careful in modifying things as in conjuction with JDK-ser emulation ("compatible mode") there are really obscure edge cases to break ..

..Addition: Note at read time registering id is not a hash put but an array store for most cases. In addition the array is accessed linear such that cache prefetch can be assummed (=> very little cost)

My use case is a bit different as the input stream is .5 GB and the reuseMap in FSTObjectRegistry runs out of space quickly, so I get quite a lot of hash puts/lookups.
A minor one, but this line should probably return: https://github.com/RuedigerMoeller/fast-serialization/blob/master/src/main/java/org/nustaq/serialization/FSTObjectRegistry.java#L86  As it stands this is doing the lookup twice.

oops, nice find. Thanks a lot :). I consider removing the put for enums, however need have a close look before .. it's also that json/minbin codec might work different and ignore the ENUM tag and treat them as regular objects.

Many thanks!  Looking forward to the next release.

By the way.  I have just upgraded from 2.33 to 2.35 and the deserialization is 40% faster!!  It was about 20 seconds and is under 12 seconds now.  Brilliant, that's absolutely great stuff, thanks a lot!

Thanks, however the credits belong to yourself for spotting this. You seem to have  a lot of enums in your structures ..


Feature/login fix

Fixes ga4gh/dockstore#911
Gives Read:Org access for GitHub
Handle when user was logged in but is no longer logged in error
Remove a few console logs

Codecov Report

Merging #83 into develop will decrease coverage by 0.07%.
The diff coverage is 55.55%.

@@             Coverage Diff             @@
##           develop      #83      +/-   ##
===========================================
- Coverage    74.03%   73.95%   -0.08%
===========================================
  Files           81       81
  Lines         1837     1843       +6
  Branches       225      226       +1
===========================================
+ Hits          1360     1363       +3
- Misses         327      330       +3
  Partials       150      150

Impacted Files
Coverage Δ

src/app/shared/dockstore.model.ts
100% <100%> (ø)
:arrow_up:

src/app/loginComponents/user.service.ts
86.2% <50%> (-9.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e128e...4640596. Read the comment docs.


Update s3, sdk-core, sqs to 2.17.112

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.104 to 2.17.112.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #399.


cds_hide_user_named_servers available in qhub-config.yaml and true on qhub init

Default and recommended settings are now:
cdsdashboards:
  enabled: true
  cds_hide_user_dashboard_servers: false
  cds_hide_user_named_servers: true

This means that the user doesn't get a 'Named Server' section on their home page, so can only start their single JupyterLab 'My Server'.
Dashboard servers will be displayed.
Please note it is still possible to start a named server through the API, or it is conceivable that one appears if there is a faulty dashboard start (perhaps due to misconfigured QHub), in which case the user will never be able to see that named server. It would only be listed to the admin.
Upgrades to existing QHubs should include the above settings in the qhub-config.yaml.
Closes #461

Since the options are already namespaced could we make it shorter by removing the cds_?


Add alpha 3 changelog.

I don't see that we now extract constants from EdgeQL and GraphQL queries mentioned anywhere.

I suppose that constant extraction can go into "Sever" section rather than EdgeQL/GraphQL since fundamentally it's not so much about the languages as it is about more efficient caching for the server.

Will Migrations be part of alpha3 ?

Will Migrations be part of alpha3 ?

Alas, the implementation isn't ready yet.  We decided to cut a release and not wait until RFC1000 is fully implemented to give other features and fixes the opportunity to get tested.  That said, we'll be switching to time-based 6-week release cadence for the alphas, betas and rcs from now on.

Thanks Victor!


Escape special characters in SimpleReport Subject section only

Discussed in https://github.com/selenide/selenide/discussions/2279

Originally posted by Au6ojlut May 10, 2023
In case of  multi-line text condition the report looks a bit ugly
+----------------------------------------------------+-------------------------------------------------+------------+------------+
| Element                                            | Subject                                         | Status     | ms.        |
+----------------------------------------------------+-------------------------------------------------+------------+------------+
| open                                               | about:blank                                     | PASS       | 100        |
| #any-long-ugly-selector-should-be-entirely-visible | should have(text "Not big
but
multiline")       | PASS       | 100        |
| close                                              |                                                 | PASS       | 100        |
+----------------------------------------------------+-------------------------------------------------+------------+------------+

so, the idea is to escape all special characters in report, so it become smth like
  +----------------------------------------------------+---------------------------------------------------+------------+------------+
| Element                                            | Subject                                           | Status     | ms.        |
+----------------------------------------------------+---------------------------------------------------+------------+------------+
| open                                               | about:blank                                       | PASS       | 100        |
| #any-long-ugly-selector-should-be-entirely-visible | should have(text "Not big\nbut\nmultiline")       | PASS       | 100        |
| close                                              |                                                   | PASS       | 100        |
+----------------------------------------------------+---------------------------------------------------+------------+------------+

The replace rule is very simple
\n -> \\n
\t -> \\t
\r -> \\r
\f -> \\f
and so on
```</div>

Fixed in PR https://github.com/selenide/selenide/pull/2284


fmIDE: Layout objects are not processed correctly

If you specify a layout_name and a child thing, such as layout_field_name or an object_name, the child thing is ignored.
Need to come up with a neat method of dealing with hierarchical, multi step actions. (The current implementation (for scripts) is a bit of a hack and missing for layouts)
If both parameters are passed two actions should be generated:
layout_name -> Go to Layout
layout_field_name -> Go to Layout Field
The first thought is not enough, since Go To Layout Field does not incorporate a Go to Layout:
not IsEmpty ( $layout_field_id ) or
not IsEmpty ( $layout_field_name ) or
not IsEmpty ( $layout_field_number ) ; JSONSetElement ( "[]"
; ["[0].action_name" ; "Go To Layout Field" ; JSONString]
; ["[0].layout_id" ; $layout_id ; JSONString]
; ["[0].layout_name" ; $layout_name ; JSONString]
; ["[0].layout_number" ; $layout_number ; JSONString]
; ["[0].layout_field_id" ; $layout_field_id ; JSONString]
; ["[0].layout_field_name" ; $layout_field_name ; JSONString]
; ["[0].layout_field_number" ; $layout_field_number ; JSONString]
);

Fixed in version 0.29


Update installation to OpenCV 3.1.*

Specifically, make sure that the .travis.yml is updated.

Solved!
Now compatible with OpenCV 3.4.*


Add installer

Install script worked well for me, but the "one liner" command in the README didn't work quite right. I ended up cloning the repo, making the script executable, then executing install.sh and su.

Install script worked well for me, but the "one liner" command in the README didn't work quite right. I ended up cloning the repo, making the script executable, then executing install.sh and su.


Accelerate EC Group initialization

This pair of patches enables EC group methods to customize their initialization sequence and then uses that to replace an expensive calculation for P256. Our measurements indicate a slight but worthwile speedup in tasks with much handshaking, but there are lies, damned lies, and benchmarks.

<EMAIL_ADDRESS>is my work email address, so it should be trivial to add to the CLA list as an alias (or I can go git amend if that would be cleaner)

Failures look relevant.

Thanks for the thorough review: it also emerges I need to add some more tests because we don't check for consistency and the method doesn't use this data. Will be a few days before I get to it. As for speedup group initialization goes from taking about as much time as the actual NIST P-256 calcuation to about half.  Will do a microbenchmark of EC P256 creation (openssl speed should see it) hopefully tomorrow.

Benchmarking will be a bit tricker: seems like we need to actually do the handshake to trigger the path that's reinitializing the EC group over and over.

It would be great if you could also provide the benchmarking tool so it could be added to the set we currently have

@beldmit alas the way we validated this patch's performance internally was by executing performance test against our entire server in a rather manual setup rather than a small benchmarking tool that we can release.

The fact that BN_MONT_CTX leaks memory when called on a BN_MONT_CTX returned from BN_MONT_CTX_new is inconsistent with other functions of that form, but once I figured that out the memory leaks went away. Will get performance numbers tomorrow most likely.

I have no idea how to fix the fips and ktls change if the EC_METHOD type is exposed in a way that makes it not extensible 😞 Is this an error that is blocking, or just overzealous comparisons?

I have no idea how to fix the fips and ktls change if the EC_METHOD type is exposed in a way that makes it not extensible 😞 Is this an error that is blocking, or just overzealous comparisons?

@nhorman ?

This abi check in the fips/ktls job is just a comparison of the current PR against the recorded abi from the merge base.  The failure just means that you added/removed/changed symbols in our library export symbols list, and is meant to catch unwanted abi changes.  If the intent was to add these symbols (which clearly it was), the approach is to re-generate the libcrypto-abi.xml and libssl-abi.xml files as part of the PR.  This can be done by building with the same config that the fips/ktls build uses (including -g) and running abidw --out-file .github/workflows/libcrypto-abi.xml ./libcrypto.so.3 .  Repeat for libssl and commit the changes to the PR and the fips/ktls job will pass

This abi check in the fips/ktls job is just a comparison of the current PR against the recorded abi from the merge base. The failure just means that you added/removed/changed symbols in our library export symbols list, and is meant to catch unwanted abi changes. If the intent was to add these symbols (which clearly it was), the approach is to re-generate the libcrypto-abi.xml and libssl-abi.xml files as part of the PR. This can be done by building with the same config that the fips/ktls build uses (including -g) and running abidw --out-file .github/workflows/libcrypto-abi.xml ./libcrypto.so.3 . Repeat for libssl and commit the changes to the PR and the fips/ktls job will pass

Thank you! Currently on an arm64 machine, so I'll have to fiddle around with an amd64 machine to get that done, but that should be straightforward. Looks like there's also a funny case in CI the memory safety test checks, so after I fix that I'll fix the fips test.

My fix for the memory build failing was to only check when the field_data1 is not NULL. This assumes that all methods only use it for montgomery data, which seems true so far (and in CI).

ABI files pushed. Seems like the checks haven't run again for whatever reason. Getting perf numbers hopefully soon.

ABI files pushed. Seems like the checks haven't run again for whatever reason. Getting perf numbers hopefully soon.

You need to rebase and recreate the ABI files.
I wonder if we aren't complicating things with these ABI check files too much. Perhaps the examination could be somehow limited as I do not see why this PR should trigger an ABI change as it modifies only completely internal structures.

 Not a very interpretable number, will get that after the holiday.

The one fail seems to be due to the VM I regenerated the files on not quite matching where github generates them: don't think there is an easy resolution to doing that automatically vs. manually bashing the result of the generation.
Other than an intrepretable performance result, what else do you need from me on this PR?

Testing on 100,000 iterations of producing an PKEY_CTX_GEN and creating an ECDH key the patch takes the time from 2.46 seconds on master to 1.76. I think this is worth it.

Can you resolve the comments when you fix them please.

Is this using the constant time flag BN_FLG_CONSTTIME where it was before this new code was added?
@romen can you review this PR if you have time

It should be: the code in full_init is mostly a copy of the initialization routine that then uses precomputed results. I'll double check that constant timeness is respected when setting up the BN_MONT contexts: could be part of the setting internal API.

Is this using the constant time flag BN_FLG_CONSTTIME where it was before this new code was added?
@romen can you review this PR if you have time

It should be: the code in full_init is mostly a copy of the initialization routine that then uses precomputed results. I'll double check that constant timeness is respected when setting up the BN_MONT contexts: could be part of the setting internal API.

I am referring to the flags field in the mont_ctx.. If you are setting things directly into this object then possibly it bypassed something it used to do..

Addressed latest round of comments and think I'll just push commits on top and rebase down to two commits, one for the code and one for the ABI file changes (which I'm not sure if I can actually recompute correctly, but can at least regenerate).
As far as I can tell no flags are set in the existing code, but I'm not sure we don't need CONSTIME somewhere but as this method avoids all the montgomery stuff actually happening I think it might be ok?

@nhorman If every change like this needs a update of the abi .xml files this is going to be real painful.. (In the same way libcrypto.num is painful).

I agree, we need to do something with this. IMO this is unacceptable.

@t8m @slontis I'm not sure what to say, the ABI changed here, so we need to update the abi reference.  That said, I can understand the difficulty in doing so.
What I can tell you is that the abigail xml isn't really designed to be human readable (or more specifically no more readable than any xml ever is).  That file was really meant to be opaque and simply a reference for abigail to do a diff against when checking to see if the ABI has changed.
Ideas for managing this:

don't store an xml file of the last known good abi.  This eliminates the need for an xml file at all, but in order to provide the abidiff tool a reference to diff against, it would require a second build in the FIPS/ktls job to build openssl with the commits in a given PR reverted.  Its certainly doable but comes at the cost of an extra build cycle

Truly treat the last good abi as opaque data - i.e. don't require that a user update the xml at all, and do the update as part of the merge process.  Acceptance on a PR would have to be gated on a flag in the PR, i.e. if the abidiff in fips/ktls fails, review it, set a label in the PR ("abi-change-approvided" or some such), and skip the abidiff if that label is set on the PR.  This is actually nice in that the abi xml would be re-generated in a predictable manner using the same environment that does the checking, but would of course require some additional automation during the merge.

Don't use abigail.  If its truly untenable to have to manage the abi reference xml, we can just remove the test.

Of the options, I think I like (2) the best.  The notions of validating changes in the ABI is a useful test, and while we don't usually have problems with that, catching abi changes in review can be tricky, and failures to do so can be quite problematic to revert once in the wild.  Option 2 lets us treat that xml is opaque and something we never really have to look at during reviews (assuming we trust the tools and merge process to maintain that file for us).
Thoughts?

Maybe a discussion to raise during OTC..

I'll fix up the remaining comments and do the debugging bit to look at the structures sometime: stuff has popped up so I haven't had the time i expected to have for this recently, but I shall get to it soon hopefully.

Please also remove the ABI .xml files - they are no longer relevant.

Checked the flags in the debugger and they are the same as what is produced by current master. Hopefully this week I shall clean out nits, remove the .xml, and then squash down for merge once things look good. Does that sound like the right plan?

When you get to review stage , you can use
git log

To find the id of a commit you want to apply fix ups to
Then use
git add files...
git commit --fixup commitid
git push

This makes it easier to see what you have changed.
It can then be squashed when a committer merges your PR.

You will still have to rebase to get to this point now probably :)

Ended up being lazing and squashing it all to one big commit. I think I addressed all outstanding comments, but give it another look and from now on I think I can just do fixups.

I've gone and I think addressed all remaining comments: sorry for the delay

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

I'm hoping we can get this patch in soon: it matters for busy servers and keeping out of tree if more EC changes happen sounds unfun.

I think I've  addressed all the nits and added a CHANGES.md entry.

@slontis please reconfirm your approval

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

Just did the rebase resolving the CHANGES.md conflict.

Ok, looks like the rebase pulled in some commit that while not conflicting broke the change. Will investigate. Any ideas on what it might be?

Ok, looks like the rebase pulled in some commit that while not conflicting broke the change. Will investigate. Any ideas on what it might be?

Known issue #24463 will fix it

@slontis please reconfirm

Freebsd failure seems a bit odd at this point: it looks pretty high level but the changes to the PR haven't touched code.

That's a known intermittent failure that despite some effort spent we were not able to fix yet.

Is there anything else I need to do before we can merge, given the known intermittent failure?

Your last rebase may be on a broken version of master.
A new rebase of a master version where CI are greens will give you an hint.

Revised to fix the last few nits (maybe there are still more!) and pushed rebased on master.

Some odd failures: will investigate

Seems like only SM2 uses that particular branch, so have now fixed the conditional that was causing problems. Oddly SM2 seems to be the only curve that goes that way and I do not know why.

Pushed a fix for the nit in the change that @t8m discovered

ping @slontis to reconfirm the approval

Pushed the fix to that nit.

This pull request is ready to merge

Squashed and merged to the master branch. Thank you for your contribution.

Thanks for putting up with fixing all the style violations!

Thanks for being patient :)


UAI : Animation takes few seconds to load

@Raheel1258 Looks good but we can improve
When CTA is pressed it stucks for a while
https://github.com/bithyve/bitcoin-keeper/assets/107177634/a7349e7d-9614-4b37-822c-e774595a8ce3

Completed


Master -> Main Rename

Part of https://github.com/Islandora/documentation/issues/1595

Build locally everything working.


no such backup file?

i've just installed the add-on and all but i get this error. what did i do wrong or did i forget something?
starting version 3.2.4
[Info] Files will be uploaded to: /hasssio-backups/
[Info] Saving OAUTH_ACCESS_TOKEN to /etc/uploader.conf
[Info] Listening for messages via stdin service call...
{"command": "upload"}
[Info] Received message with command upload
[Info] Uploading all .tar files in /backup (skipping those already in Dropbox)

No such file or directory: /backup/*.tar
Some error occured. Please check the log.

Just eliminating the obvious first, do you have any backups?

That's a good one... I don't think i have. Do you have to do this manually?

No worries! I'd read a little about hass.io backups and then how to automate backups with timed service calls, then automate this add-on (again with a service call, see the README) if you're interested.


WIP: adjusted temp & wind chill

working on figuring out adjusted temperature and wind chill

Merge #28 first, then use RH directly


Duplicate selected text or area

VSCode Version: 1.6.1
OS Version: Windows 8.1 Enterprise 64-bit

Steps to Reproduce:
Hi,
This feature is best to speed up programming. (Please see below gif)

in vs code we can only duplicate lines by Shift + Alt + Arrow up Or down. But on this feature you can duplicate all things (selected characters, text , lines and ...)
What's benefits?

Do not use clipboard and you can save other things on clipboard and duplicate selected text or area.
Speed up programming.
Many developers previously worked with notepad++ and now use VS Code. This feature is on notepad++ and good to add this on vs code.

@isidorn Please see this. Thank you

Closing as extension candidate. Please checkout these extensions already in the marketplace: https://marketplace.visualstudio.com/search?term=duplicate&target=VSCode&category=All categories&sortBy=Relevance


Update suggestions for the library to be used by another project via the Zig package manager

Hi there! I needed a simple serial reader application today and was very happy to find your library. I noted that some features are missing for the library to be used by other projects via the Zig package manager. For now, I have forked the repo and made some changes there. That works fine for me. If you're interested, here's a couple of suggestions:

add a zon file (required)
set a git tag (not required but convenient, for referencing the lib in the client's zon file)
use std.fs.max_path_bytes instead of std.fs.MAX_PATH_BYTES (Zig 0.14-dev requirement; the lower-case variant also works with Zig 0.12 and 0.13 stable)

Those are probably maintenance updates, but if you'd like, I can also make a PR.

Always happy to receive PRs for such chores :)

btw. after adding the test step, I noted that the tests only work if you actually have a serial port available ^^ I didn't notice this on my other machine where I happen to have a USB-to-Serial device attached, and the tests passed.


Feature Request: Support for Additional vLLM Configuration Settings

Description
I would like to inquire if there are any plans to support more configuration settings for vLLM, specifically related to RoPE scaling and theta adjustments.
Background
vLLM currently provides some configuration options such as --rope-scaling and --rope-theta, as documented in the vLLM documentation.

--rope-scaling: RoPE scaling configuration in JSON format. For example, {"type":"dynamic","factor":2.0}.
--rope-theta: RoPE theta. Use with rope_scaling. In some cases, changing the RoPE theta improves the performance of the scaled model.

Request

Are there any plans to expand the support for more configuration settings related to RoPE scaling and theta adjustments?
If so, could you provide a timeline or any relevant details about the upcoming features?

Thank you for considering this feature request. I look forward to your response.

Hi, thank you for your questions.

Yes, there are plans currently to expand context lengths up to 32K using YaRN and/or Dynamic Scaling across vLLM/TGI/direct Transformers usage. For vLLM, we will need to evaluate vLLM's YaRN/Dynamic NTK Scaling/LongRoPE/etc. via the extended model's performance before we can officially include the configuration settings.
Unfortunately, I cannot give a specific timeline regarding this but I can assure you that we are working on it right now and this is one of the highest priority task currently.

Hi,
Thank you for your detailed response and for sharing the plans for expanding context lengths using YaRN and/or Dynamic Scaling. I appreciate the insight into your current priorities and the efforts being made to evaluate these features.
Given the importance of extended model capabilities for my current work, I would greatly appreciate it if you could provide instructions on how to support RoPE scaling in vLLM. Having this information will allow me to proceed with my work, and perhaps I could contribute to the evaluation and development process.
Thank you again for your assistance.

Hi, thank you for your questions.

Yes, there are plans currently to expand context lengths up to 32K using YaRN and/or Dynamic Scaling across vLLM/TGI/direct Transformers usage. For vLLM, we will need to evaluate vLLM's YaRN/Dynamic NTK Scaling/LongRoPE/etc. via the extended model's performance before we can officially include the configuration settings.
Unfortunately, I cannot give a specific timeline regarding this but I can assure you that we are working on it right now and this is one of the highest priority task currently.

I believe that engine_args.rope_scaling and engine_args.rope_theta were only brought back/implemented recently. Our vLLM dependency version is older. Therefore, you can try migrating the vLLM version to the latest and test server_vllm.py without grammar sampling with the rope-scaling and/or rope-theta command line arguments respectively.
I haven't tested whether there are any problems with migrating the vLLM version but the chances should be low without grammar sampling as our vllm monkey patch will not be used. Do let me know if you encounter any issues when migrating.

Thank you for your reply. I just test when migrating the vLLM version to v5.0.0, and run the following command:
CUDA_VISIBLE_DEVICES=1,2 python3 server_vllm.py --model "meetkai/functionary-small-v2.5" --host <IP_ADDRESS> --max-model-len 8192
The error information is below:
Traceback (most recent call last):
  File "/data1/user/functionary/server_vllm.py", line 29, in <module>
    from vllm.entrypoints.openai.protocol import (
ImportError: cannot import name 'LogProbs' from 'vllm.entrypoints.openai.protocol' (/home/user/miniconda3/envs/functionary/lib/python3.10/site-packages/vllm/entrypoints/openai/protocol.py)

It seems the LogProbs has been changed in latest version of vllm. I'm just trying to fix it. And I think maybe it's more easier to migrate quickly if disabling grammar sampling and just setting tool choice 'auto'. I will appreciate it if you could explain the importing of  LogProbs and the function def create_logprobs .

Hi, thank you for pointing this out. It turns out that the vLLM community did many revamps big and small on the codebase in the 2-3 months since we pinned the dependency version to v0.4.1 so i just raised #215 for review. It migrates the vllm dependency version to v0.5.0 and should work both with and without grammar sampling now.
Additionally, you can pass in rope scaling now. Here's an example:
python server_vllm.py --model meetkai/functionary-small-v2.5 --rope-scaling '{"type": "yarn", "factor": 4.0, "original_max_position_embeddings": 8192}' --rope-theta 500000.0

Make sure to not pass in --max-model-len as it will overwrite the rope scaling. This keeps the context window to whatever --max-model-len is set to.
The PR will be merged soon. Alternatively, you can hop on to this branch if you want to start evaluating before the PR is merged.

Thank you for your help in resolving the issue! It seems to be running normally now with updated vllm. I will keep you posted with any feedback.

You're welcome, looking forward to any interesting findings! Do pull from the latest main as there are some more small bug fixes regarding running longer context lengths on server_vllm.py implemented.


Fix bug in NativeEngine.setAlphaMode

What was the effect of this bug?

Anything that calls getAlphaMode() will get a wilding incorrect value, then when setAlphaMode is called with that value, _getNativeAlphaMode will throw an exception.
The specific features that I'm aware of which use these function are: EffectLayer and OutlineRenderer.

@bghgary - I will let you merge this one.


fbstatus does not render correctly on all monitor resolutions

Platform
I’m using:

[x] gokrazy/rpi4b

Observed behavior
A couple hiccups with the Quickstart guide, but finally managed to boot the new image.  I see maybe a page and a half of small text fly up the left side of the screen, and then my dell monitor says there is a timing issue, and requests a change to 1920x1200@60Hz.  Same thing on Pi400.  Not sure where to check/change the resolution, and cant see anything obvious in the various repos or docu.  Also not sure how this is gonna connect to my wifi network, since it seems to expect ethernet?
Expected behavior
some kind of successful boot (just the 'hello' app installed)

Let me know if there is anything I can do to help/test.  e.g. I was trying to see if the boot sequence for the Pi4 was logged somewhere, but I am guessing I would need to setup the writable partition first?  I had a look at the fb code, but couldn't see anything obviously different with the logo rendering, apart from maybe it takes longer than a frame to render, but dont see why that would impact it.

I was trying to see if the boot sequence for the Pi4 was logged somewhere, but I am guessing I would need to setup the writable partition first?

With -serial_console=disabled, all boot output ends up on the HDMI console (if you include fbstatus, that will obviously clear the screen).
As the HDMI console can scroll past pretty quickly, my preferred solution to see (and potentially capture) the full logs is to use a USB-to-serial adapter connected to the Raspberry Pi’s RX/TX pins (remove the -serial_console=disabled flag of course).
The permanent partition won’t help, as nothing is logged to it by default.
You can optionally enable remote syslog, but that only covers application logs, not kernel logs.

I had a look at the fb code, but couldn't see anything obviously different with the logo rendering

I’m pretty certain the relevant difference is the screen resolution. Maybe best for development would be to render to some other place (a PNG file?) and try a couple of typical screen resolutions.

ok I managed to get an old Arduino FTDI and the arduino 'serial monitor' running and connected to the Pi4, phew!  The video config looks good:
[    0.000000] Kernel command line: video=HDMI-A-1:1920x1200M@60 dma.dmachans=0x37f5 bcm2709.boardrev=0xc03111 bcm2709.serial=0xd3b8fa7c bcm2709.uart_clock=48000000 bcm2709.disk_led_gpio=42 bcm2709.disk_led_active_low=0 smsc95xx.macaddr=xxxx vc_mem.mem_base=0x3ec00000 vc_mem.mem_size=0x40000000  console=tty1 console=ttyS0,115200 root=PARTUUID=xxxx/PARTNROFF=1 init=/gokrazy/init rootwait panic=10 oops=panic
which is the same as my monitor is requesting when the display fails.  1920x1200@60
The good news is I can see the device continues to post, and I can actually access the 'hello' service via the web interface, yay!
PS When I create the image using the Pi4, I keep forgetting to umount /dev/sda2  The process stops saying it is mounted, but it is not clear this is a failure message requiring the umount.  Not sure if that is just a quirk of the way I am creating the sdcard image, or something that might trip up others.


make sure context processors are called

👍

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.

Coverage increased (+0.2%) to 82.184% when pulling f6482cc3b5374b9026c344a135367cc10f6deb0a on fixes/make-sure-context-processors-are-called into 4a3a42df67b111981fecec0824ac5fe7285a43aa on master.


Missing documentation for CS8421

CS8421: "A static local function can't contain a reference to ."

The CS8421 doesn't have a documentation currently. While it's already mentioned in docs in what's new in C# 8.0 article, There should be a separate article for it in docs/csharp/language-reference/compiler-messages.

Closing this.. There is an already open issue for missing compile warning and errors docs. (#5410)


Fixes failing phpunit and runscope tests

What's this PR do?
Fixes failing phpunit and runscope tests
Where should the reviewer start?

UserController.php: previous logic would only save values that were null
CampaignTest.php and UserTest.php: route to GET user data was previously modified to /users/{term}/{id}. This updates the tests to match that.

How should this be manually tested?

$ vendor/bin/phpunit
and Runscope tests should pass

@angaither

:+1: oy. :grimacing:


Support mlflow model in sklearn pre-packaged server

@qrtt1  LGTM. Please resolve the conflict and merge on your own.


Remove apollo

we don't need apollo anymore because we don't make gql requests from client, so we don't need it's cache.
Replace all usages of apollo with SSR.API.graphql calls.

cognito vs api_key auth mode

done with #37


Add support for custom scrollbars in Grid and MultiGrid

Hi !
The issue of having custom scrollbars with react-virtualized is a pending issue https://github.com/bvaughn/react-virtualized/issues/1275 .
It may be possible to do it today with Lists but it's kind of impossible/hacky to do it for Grid or MultiGrid (by subclassing Grid and using React.cloneElement for instance).
This PR solves this.

checklist:

[x] The existing test suites (npm test) all pass
[x] For any new features or bug fixes, both positive and negative test cases have been added
[x] For any new features, documentation has been added
[ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[x] Format your code with prettier (yarn run prettier).
[x] Run the Flow typechecks (yarn run typecheck).

Closing this as it hasn't been reviewed since its creation (9 months)

Closing this as it hasn't been reviewed since its creation (9 months)


"Find" filter issues

I think this is @Podshot and maybe @LaChal area?

Running the filter at all adds 1 unsaved edit even when it doesnt edit anything.

The "Find Next" operation gives a "list index out of range" error and doesn't work at all anymore.

The undo/redo stuff for this filter (and maybe some other) need to be reworked, apparently.

The 'Find Next' option is outdated. It will be removed since double clicking on a tree item in the 'Results' panel does the same thing.

Ehhh Find Next provided a way to cycle through every command block with the tag I searched for nice and easily without adding the need to double click on every single one in the NBT tree, and sometimes getting lost on which one I last clicked on if the list is kinda long. I guess it's not a big deal, but adding two mouseclicks to that process for every command block found sounds like a downgrade to me.

This still an issue?

There's actually a few filters that have an "issue" similar to the first one I reported here. I guess it would be up to the filter to compare and decide whether there was an edit or not.

Well, even if the filter didn't do anything, it was still an operation, even photoshop adds an entry if you delete an empty area or crop after using ctrl+a. Was more asking relating to the second part.

Removing the feature wasn't much of a fix, but ya I guess.


Prompt Weighting Toggle for sd_tag_batch.py

Added a toggle to enable or disable the interrogator prompt weighting. Prompt weighting is enabled by default, which is the vanilla behavior.
I found that interrogator prompt weighting sometimes caused problems and thought that it would be nice if users could choose whether interrogator prompts were weighted or not.

good idea, thanks

No problem!


[BUG]: Import of Solution 1.70.2 CoECoreComponents

Describe the bug
We try to upgrade the CoE Installation. But we are facing an issue with upgrading the solution from 1.45
Component (please tell us which flow or app you are experiencing issues with):

CenterOfExcellenceCoreComponents
Version 1.45 to upgrade with 1.70.2
Entity RPA
seems like the datatype of the field admin_rpamodifiedon changed from string to datetime
ErrorMessage in import-log: Attribute admin_rpamodifiedon is a String, but a DateTime type was specified.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
To change the datatype of a field we would need to delete the field first in the target and than recreate it. As it is managed, this is not possible without completely uninstalling the solution and the dependecies.
Screenshots
Screenshot is also in bug #483
Additional context
Is there a a solution before, that remove that field? So maybe we just need to update to an earlier version, before we can get to 1.70.2.

I created one for you, based on current bits, which just deleted this field. Can you see if this will work as an intermediate step?
 Thank your the quick response.
Kind regards,
Lars

Hi @JeneferM-MSFT
the provided solution did the trick. We will continue to upgrade our CoE instance. Thank you for the quick help.
Kind regards,
Lars

Thanks for using CoE!


Add new Lint/TripleQuotes cop

Follows https://github.com/rubocop-hq/rubocop/issues/9394#issuecomment-763899981.
Looks for instances of triple (or quintuple, or septuple, etc.) quotes and registers an offense for them as they do not have a special meaning in Ruby but could cause confusion that they do.
The case of useless implicit concatenation (ie. 'a' 'b' 'c', '' '', etc.) is not registered by this cop to keep things simple (but I'm going to look at adding a cop for that as well).

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

On further thought, maybe it might be worthwhile to handle triple quotes and other implicit string concatenation in the same Lint/ImplicitStringContatenation cop...

On further thought, maybe it might be worthwhile to handle triple quotes and other implicit string concatenation in the same Lint/ImplicitStringContatenation cop...

On further thought, maybe it might be worthwhile to handle triple quotes and other implicit string concatenation in the same Lint/ImplicitStringContatenation cop...

Either way works for me. Separate cop makes sense though as ImplicitStringContatenation could be disabled, for example, but triple quotes is kind of different.

On further thought, maybe it might be worthwhile to handle triple quotes and other implicit string concatenation in the same Lint/ImplicitStringContatenation cop...

Either way works for me. Separate cop makes sense though as ImplicitStringContatenation could be disabled, for example, but triple quotes is kind of different.

Nicely done!

Nicely done!


ngx-restanular error in angular 8

After upgrading my project to Angular 8, I am getting the following error from ngx-restangular:
ERROR in node_modules/ngx-restangular/lib/ngx-restangular-http.d.ts(3,27): error TS2307: Cannot find module '@angular/common/http/src/response'.
It would be nice if you fix the Issue so that ngx-restangular can be used with angular 8

I have upgraded ngx-restangular to angular 8 in the branch:
https://github.com/kamaruzzaman/ngx-restangular/tree/Issue_168_angular8

Is there a merge and an npm publish planned ?

working on it

Thank you !

I have upgraded ngx-restangular to angular 8 in the branch:
https://github.com/kamaruzzaman/ngx-restangular/tree/Issue_168_angular8

After installing from this branch the module import fails:
import { RestangularModule } from 'ngx-restangular'; -> error TS2307: Cannot find module 'ngx-restangular'.

Same issue here..

Is this fixed.
I am getting as well.
ERROR in node_modules/ngx-restangular/lib/ngx-restangular-http.d.ts(3,27): error TS2307: Cannot find module '@angular/common/http/src/response'.
How get I can updated ngx-restangular.

Any resolution on this issue using with latest angulr 8.
ERROR in node_modules/ngx-restangular/lib/ngx-restangular-http.d.ts(3,27): error TS2307: Cannot find module '@angular/common/http/src/response'.

Any resolution on this issue using with latest angulr 8.
ERROR in node_modules/ngx-restangular/lib/ngx-restangular-http.d.ts(3,27): error TS2307: Cannot find module '@angular/common/http/src/response'.

Try with 5.0.0-rc1

You mean change in my package.json
"ngx-restangular": "^5.0.0-rc1",
I tried out. still same error.

I installed
npm install<EMAIL_ADDRESS>--save
but now getting different errors.

Maybe you need to update your Angular Cli.
My package.json looks like this
"dependencies": {
    "@angular/animations": "^8.0.0",
    "@angular/cdk": "^8.0.0",
    "@angular/common": "^8.0.0",
    "@angular/compiler": "^8.0.0",
    "@angular/core": "^8.0.0",
    "@angular/forms": "^8.0.0",
    "@angular/material": "^8.0.0",
    "@angular/material-moment-adapter": "^8.0.0",
    "@angular/platform-browser": "^8.0.0",
    "@angular/platform-browser-dynamic": "^8.0.0",
    "@angular/pwa": "^0.800.3",
    "@angular/router": "^8.0.0",
    "@angular/service-worker": "^8.0.0",
    "core-js": "2.5.1",
    "ngx-restangular": "5.0.0-rc1",
    "rxjs": "6.5.2",
    "rxjs-compat": "6.3.0",
    "zone.js": "~0.9.1",
    ...
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.800.2",
    "@angular/cli": "^8.0.2",
    "@angular/compiler-cli": "^8.0.0",
    "@angular/language-service": "8.0.0",
    ...
    "tslint-language-service": "^0.9.9",
    "typescript": "3.4.5"
  }

any idea?

any idea?
how to fix it.
Should I move back to angular 6 or 7.

Finally I found a solution to work with ngx-restangular 5.0.0-rc1, angular 8.2.3 and core-js 3.2.1. First of all, to resolve the error
"Can't resolve 'core-js/es7/reflect'"
I had to change in my polyfill.ts the import to "core-js/es/reflect".
Next, I got a similar error in ngx-restangular
Module not found: Error: Can't resolve 'core-js/fn/object' (same as @snahmad)
and had to change the line
import { assign } from 'core-js/fn/object'; to
import { assign } from 'core-js/features/object';
in ngx-restangular/fesm5/ngx-restangular.js
This worked for me ... but how to have the correction inside the ngx-restangular package?

Hi, thanks to the @bal3no PR I published a new version under rc tag. To install use npm install ngx-restangular@rc

Published 5.0.0 version. Please notify me if there are any issues

I am getting this error ERROR in ./node_modules/ngx-restangular/fesm2015/ngx-restangular.js Module not found: Error: Can't resolve 'core-js/features/object'

@akvaliya please update your ngx-restangular to 5.0.0 (not 5.0.0-rc1) and core-js to 3.2.1. I saw this issue as well on August 29 and solved it by doing so.

I have moved to ngx-restangular latest version.
using now ngx-restangular": "^5.0.0-rc1",
now getting
Module not found: Error: Can't resolve 'core-js/es7/reflect' in 'C:\Work\Actisense\W2K1\angular\webApp\src'
ERROR in ./node_modules/ngx-restangular/fesm5/ngx-restangular.js
Module not found: Error: Can't resolve 'core-js/fn/object' in 'C:\Work\Actisense\W2K1\angular\webApp\node_modules\ngx-restangular\fesm5'

solved the issue by installing the running npm i core-js@3

Is there still support in this issue for the latest versions of angular?
   "ngx-restangular": "^5.0.0-rc3",


PR Pointing for PAY-5841

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Not required. PR pointing is uncessary now that the dependancy apps are built within the Preview environment.


Deploy with --max-concurrent-builds or --build-sequential does not apply to concurrent dependency builds

What happened?
I have a monorepo with API gateway. The gateway project depends on multiple service projects. Each project, including gateway, has at least one image to build.
When I run either devspace deploy --build-sequential or devspace deploy --max-concurrent-builds 1 , devspace kicks off builds for mulitiple dependency projects at once, resulting in heavy parallelism, high memory usage by docker and recurring build failures.
What did you expect to happen instead?
I expected both devspace deploy --build-sequential and devspace deploy --max-concurrent-builds 1 to kick off 1 build at a time. I would like developers to choose concurrency with devspace deploy --max-concurrent-builds X,  to control CPU load and memory usage on their machine.
How can we reproduce the bug? (as minimally and precisely as possible)
I have prepared a reproduction repo, just follow the steps from the readme.
https://github.com/gustaff-weldon/devspace-build-concurrency
Local Environment:

DevSpace Version: 6.1.1
Operating System: mac
ARCH of the OS: x86_64

Kubernetes Cluster:

local Docker Desktop cluster, but builds happen outside of it

Anything else we need to know?

/kind bug

Hello @gustaff-weldon ! Thanks for creating this issue, right now the flag only applies to images within a single devspace.yaml and having this coordinated across dependencies is currently not supported. As a workaround you can deploy dependencies sequentially, like this:
pipelines:
  dev: |-
    run_dependencies --all --sequential
    ensure_pull_secrets --all
    build_images --all
    create_deployments --all
    start_dev --all

Hello, @gustaff-weldon !
Thanks again for reporting this issue!
We will look into it and analyse if it makes sense for us to add such a feature.
Obviously, we'll come back and let you know!
Let's keep in touch!


Remove the return before abort. http://flask.pocoo.org/docs/0.12/api/…

…#flask.abort

Thanks Patrick.
In Dockerfile the line COPY ./uwsgi.ini /uwsgi.ini should be removed.
When testing the deployed version, the error message accompanying the error where too many images are sent is not showing up.
I'm unable to run this locally - get an error (maximum retries reached / cannot connect) trying to reach the endpoint. From the server side, it receives the images, sends it through the model, but then the node dies and the process restarts itself (a new pid).


REDIS HOST, PORT & DB are configurable env vars

Make local Redis cache configurable via environment variables REDIS_HOST, REDIS_PORT, and REDIS_DB with the defaults matching the current behavior.
This addresses the issue: https://github.com/mailgun/flanker/issues/92

Can one of the admins verify this patch?

@kellyob Thanks for this PR!  I'll test it and merge it hopefully today.

Bump?  This would be pretty cool to have.


getFileInfo call failed with FATAL_INVALID_RPC_HEADER (org.apache.hadoop.ipc.RpcServerException)

When I use this library to operate hdfs, the program is always error, the error is
2018/06/20 10:16:09 create /user/tnt/abc.txt: getFileInfo call failed with FATAL_INVALID_RPC_HEADER (org.apache.hadoop.ipc.RpcServerException)
the code is as follow
func main() {
        os.Setenv("HADOOP_NAMENODE","<IP_ADDRESS>:8020")
	os.Setenv("HADOOP_KRB_CONF","krb5.conf")
	os.Setenv("HADOOP_KEYTAB","xue.keytab")
	os.Setenv("HADOOP_SNAME","ds")
	client :=getClient()
	fw,err:=client.Create("/user/tnt/abc.txt")
	if err != nil{
		log.Fatal(err.Error())
	}
	fw.Write([]byte("hehehe"))
	fw.Close()
}
func getClient() *Client {
	nn := os.Getenv("HADOOP_NAMENODE")
	if nn == "" {
		log.Fatal("HADOOP_NAMENODE not set")
	}

	hadoopCfg := LoadHadoopConf("")
	krbClient := GetKrbClientIfRequired(hadoopCfg)

	options := ClientOptions{}

	options.Addresses = []string{nn}
	options.KerberosClient = krbClient
	options.ServicePrincipalName = GetServiceName()

	c, err := NewClient(options)
	if err != nil {
		log.Fatal(err)
	}

	return c
}

Hello, and thanks for the feedback.
This error is frequent when the client uses the wrong RPC header, generally the non-Kerberos one.
We have a known issue where a problem in the krb5.conf will not trigger any warning (presumably because of a missing check somewhere.), yet will cause the hdfs client to not attempt a Kerberos connection.
This is most likely due to a nil being returned by GetKrbClientIfRequired(hadoopCfg) above: that  is where I would start my investigation.
(I'm sorry I can't provide more insight, we currently don't have as much time as we would like for this)

The error you mention refers to the exchange with the ticket granting service: you need to pass the correct strings and be able to authenticate to the Kerberos server to proceed.
This seems more like an issue linked to your Kerberos setup and/or Kerberos access right.

I have solved the problem of Server not found in Kerberos database. It is really due to the problem of SPN format. But still get the error getFileInfo call failed with FATAL_INVALID_RPC_HEADER (org.apache.hadoop.ipc.RpcServerException) , I found that debugging is due to an error in the doKerberosHandshake function, which readAuthReply function return an error, the error is wrong Token ID. Expected 0504, was 6030, I guess because the handshake did not succeed, so the back of the request will also be a problem.Do you have ideas now?

We only support a specific token type (identified by 0x0504, in this particular case. I can't remember the specific name from the RFC. If I recall correctly, this type of token is sent in clear text and only authenticated through a signature):
Your server might use a different type if it is configured to use SASL in an encrypted mode (vs authenticated only).
I'm sorry if I can't be more helpful right now. The RFC's linked at the bottom of https://medium.com/sqooba/a-close-look-at-a-kerberos-handshake-authenticate-to-a-hadoop-namenode-via-hrpc-c56746ddb290 might help you: at least one of them should reference the 0504 constant, and this might give you more pointers regarding your situation.
Ultimately, if my hunch is correct and another type of token is used, we'll need to patch the lib to support it as well.


Davinci tech architecture both backend and frontend?

No file describe the tech architechture both backend and frontend in detail, could you please provide the doc? thx!

back-end: Java Spring Boot
front-end: React + TypeScript + Webpack
If you have any specific problems, please leave your comment.


Cocoapod update problems.

Currently trying to upgrade from v1.0 to v1.1. When I try do a build, I get the following error: Could not build module 'PullToMakeSoup'. I am trying to import into an Objective-C controller. When I inspect the selectors, it does reveal the appropriate -Swift.h file, but the build continues to fail. I am using use_frameworks! in my .Podfile.
Any ideas or suggestions? I have tried to clean, rebuild, and clear out Derived Data to no avail.

@laud I tried to reproduce it but didn't reveal any problems. Check your Podfile and Podfile.lock for right version (v.1.1) of Pod. Also check how you import it into your Objective-C controller - #import "PullToMakeSoup.h"


cant install on windows 10 Version 20H2 OS Build 19042

Description
i cant install files on windows 10 Version 20H2 OS Build 19042
Files installation failed. App Installer failed to install package dependencies. Ask the developer for  package
Steps To Reproduce

download ffile
https://github.com/files-community/Files/releases/tag/v2.4.33
install files

Steps to fix
I can't install app any way I know and I don't know where the problem is
Files installation failed. App Installer failed to install package dependencies. Ask the developer for  package
Files Version
<IP_ADDRESS>
Windows Version
Edition	Windows 10 Pro Version	20H2 Installed on	15/09/2022 OS build	19042.1706 Experience	Windows Feature Experience Pack 120.2212.4170.0
Log file
log.log

Download from https://files.community/download


Request body incorrectly parsed

Hello there,
I have implemented a Mercure Hub with ReactPHP and I'm having troubles with request bodies.
I'm currently trying to achieve this:
POST /.well-known/mercure
Content-Type: application/x-www-form-urlencoded

topic=/foo&topic=/bar&data=foobar

Indeed, the Mercure protocol specification states that a topic /foo can have alternate IRIs such as /bar. The payload to be sent is not in the PHP format topic[]=foo&topic[]=bar but topic=/foo&topic=/bar which means that PHP, by default, considers that topic is a string with the only value /bar, which is not what I want.
And so is the React\Http\Middleware\RequestBodyParserMiddleware which internally relies on PHP's parse_str function.
So, I'd like to implement my own logic to parse the body payload by myself, but:

It looks like ReactPHP removes any trace of the original body at some point ($request->getBody() returns an empty string), when Content-Type is application/x-www-form-urlencoded (could not reproduce with a random content type)
It looks like the only way to short-circuit the RequestBodyParserMiddleware to introduce my own is to set an empty value for enable_post_data_reading in php.ini, but I cannot assume people who will use my project have this tricky tweak in their configuration.

Could we either:

Not remove the original body of the request
Introduce an interface for RequestBodyParserMiddleware so that we could optionally replace it in Server's constructor
Introduce an array $config of options into Server's constructor so that we could pass an option to prevent parsing request bodies and let our own middlewares take care of this?

Thank you,
Ben

@bpolaszek Thanks for bringing this up!
I agree that clearing the request body for some requests is somewhat inconsistent, so I've just filed #395 to make sure you can always read the raw request body and apply your own custom parsing rules.
I consider this a new feature rather than a bug fix. IMO the request body is not "incorrectly parsed" because it follows PHP's default handling and I don't see anything that contradicts this.
With the above change in place, you can use your own parser to override this behavior. If you feel this is something that more people could benefit from, perhaps share this as a middleware implementation or consider filing a PR in this repo and I'm happy to take another look!
BTW, love your Mercure protocol implementation, keep it up! :muscle:
I believe this has been answered, so I'm closing this for now. Please come back with more details if this problem persists and we can always reopen this :+1:

Hello @clue,
Thanks a lot for having worked on this!
Regarding the Mercure hub, it highly depends on your work on clue/redis-react, clue/block-react and clue/reactphp-eventsource, so let's seize the opportunity for thanks and congrats! 🙏
I'll keep an eye on the PR merge to test this ASAP.
Thanks again,
Ben


Update link to point to wiki

Description
Please explain the changes you made here.
Release notes
The title of the pull request will be used as the default release notes description. If more detail is needed to communicate to partners the scope of the PR's changes, use this release notes section.
Checklist
General
Read the full guidelines for PRs here

[ ] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release | database >
[ ] Created unit and/or browser tests which fail without the change (if possible)
[ ] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Followed steps to internationalize new strings
[ ] Wrote browser tests using the validateAccessibility method
[ ] Tested on mobile view. See mobile device mode
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/helper/feature-flags.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Instructions for manual testing
If instructions are needed for manual testing by reviewers, include them here.
Issue(s) this completes
Fixes #<issue_number>; Fixes #<issue_number>...

Current dependencies on/for this PR:

main

PR #5855   👈

This comment was auto-generated by Graphite.


H2 DATABASE_TO_UPPER=FALSE

Not sure who's problem it is.
I connecting to just downloaded H2 Version 1.3.176 (2014-04-05), Last Stable using code from your tutorial with adjusted settings
  url = "jdbc:h2:tcp://localhost/test;DATABASE_TO_UPPER=FALSE",
  initMode = InitMode.DropAllCreate

Then I open jdbc:h2:test in H2 built-in web-GUI and see
 artist
 artist$genres
 artist$names
 artist$names$v
 genre
 genre$names
 genre$names$v
 locale

Then I rerun the same program and see
 ARTIST
 ARTIST$GENRES
 ARTIST$NAMES
 ARTIST$NAMES$V
 GENRE
 GENRE$NAMES
 GENRE$NAMES$V
 LOCALE
 artist
 artist$genres
 artist$names
 artist$names$v
 genre
 genre$names
 genre$names$v
 locale

If I run program twice and only then login to GUI then I'll see only lowercased tables. If I login to GUI and only then run program - there will be only uppercased tables.

From H2 docs:

Setting this to "false" is experimental.

I'd like to see this fixed, this feature is clearly buggy.

@javalama It's not a bug of SORM however.


augments func explanation

Previous sections in the "Ultimate Go Tour" had more thorough explanations. This PR adds an explanation for the function section. Modify this to your liking. 😃

Yay!! 🎉


liquid.css files are messed my whole code,

Type: Performance Issue
before 8 to 10days I have suffering with this issue when I hit ctrl+s for save my whole file code is automatically formatted and I know about your all documentation and I have set code formatter as a default code formatter couple of time but it doesn't work and my code is always messed when i saved my file specially in the liquid tags when we write code of css it will always doesn't work.
I have remove most of the extra extensions but this issue is still in it.
Please help me. me and my all teammates are facing this same problem.
what we should do.
we all need your help Immediately.
you can see in screenshot below

VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4310U CPU @ 2.00GHz (4 x 2594)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
15.90GB (8.36GB free)

Process Argv
--crash-reporter-id 9f2feb82-88c9-4e44-8a4c-493d1cb8612f

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    86	 14540	code main
    0	    38	  1600	   utility-network-service
    0	   109	  2136	   extension-host
    0	    77	 14452	     "C:\Users\HP\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node c:\Users\HP\.vscode\extensions\redhat.vscode-yaml-1.10.1\dist\languageserver.js --node-ipc --clientProcessId=2136
    0	    84	 16428	     "C:\Users\HP\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Users\HP\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\node\htmlServerMain" --node-ipc --clientProcessId=2136
    0	    72	 16844	     "C:\Users\HP\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Users\HP\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=2136
    0	    21	  3440	   crashpad-handler
    2	    93	 10668	   issue-reporter
    0	   196	 15492	   window (subscription-tabs.liquid - axiuscore-staging - Visual Studio Code)
    0	   140	 15524	   gpu-process
    0	    99	 16288	   shared-process
    0	    68	 12000	     fileWatcher
    0	    69	 13308	     ptyHost
    0	     1	  4604	       C:\WINDOWS\System32\cmd.exe
    0	     2	  9508	       console-window-host (Windows internal process)

Workspace Info
|  Window (subscription-tabs.liquid - axiuscore-staging - Visual Studio Code)
|    Folder (axiuscore-staging): 284 files
|      File types: liquid(240) mp4(10) json(9) jpg(5) js(4) css(4) ogg(2)
|                  png(1)
|      Conf files: settings.json(1);

Extensions (11)

Extension
Author (truncated)
Version

atlascode
atl
2.10.12

vscode-html-css
ecm
1.13.1

html-slim-scss-css-class-completion
gen
1.7.8

vscode-pull-request-github
Git
0.56.0

vscode-liquid-snippets
kil
2.0.3

silverfin-liquid
Nic
0.2.12

vscode-yaml
red
1.10.1

LiveServer
rit
5.7.9

shopify-liquid
sis
3.2.2

highlight-matching-tag
vin
0.10.1

JavaScriptSnippets
xab
1.8.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
282f8724:30602487
3d0df643:30613357
f6dab269:30613381
fim-prod:30623723
vscup:30628656

/needsMoreInfo
Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add FinalClassFixer

Closes #3923 #3902
Two notes:
1. No exception and no configuration are intentional
Beside Doctrine entities (and there are rumors that Doctrine 3 will allow final entities), and of course abstract classes, there is no single reason not to declare all classes final.
If you want to subclass a class, mark the parent class as abstract and create two child classes, one empty if necessary: you'll gain much more fine grained type-hinting.
If you need to mock a standalone class, create an interface, or maybe it's a value-object that shouldn't be mocked at all.
If you need to extend a standalone class, create an interface and use the composite pattern.
If you aren't ready yet for serious OOP, go with FinalInternalClassFixer, it's fine.
Further reading: When to declare classes final
2. Doctrine entities detection is brittle as of yet

[x] Please point me out how to improve import and use detection for Doctrine Entities: https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/basic-mapping.html
I don't have the full picture on how they can be marked as such, and how this projects handles import detections

Thank you @Slamdunk.

@Slamdunk started experimenting with this rule. What about Doctrine repositories that are extending EntityRepository?
Anotating as @ORM\EntityRepository to let the csfixer rule ignore that class does work, but as EntityRepository() does not exist as anotation the application thereafter will not run.
Any suggestions aside of anotating as @final?

I'm sorry as far as I remember entity repositories are not affected by the proxy issue needed for entities, why would you need them non-final?


add raid data tracker to the pluginhub

For now, the plugin only adds all the raid data to a log file stored in runelite_home/loots/user/cox (as inspired by stonedturtle).
Will add a ui and config in the near future

Please license your repository. The code looks fine aside from that.

Thanks! I've just added the license!


Added top, left, right and bottom border color CSS properties to system

[x] I have followed (at least) the PR section of the contributing guide.

Related issue
The problem:

When specifying borderColor using @material-ui/system, values aren't properly applied if the borderColor prop appears before the border<Position> prop.

Example:
// the color for border-top is `#000000` in this example
<Box borderColor="green" borderTop={1} />

Existing workarounds:
// we have to specify every property
<Box
  border={1}
  borderColor="background.default"
  borderBottom={0}
  borderLeft={0}
  borderRight={0}
/>

// *OR* ensure that `borderColor` is ordered after the target border property
<Box
  borderTop={1}
  borderColor="background.default"
/>

Changes in the PR:

Added borderTopColor, borderRightColor, borderBottomColor, and borderLeftColor CSS properties to @material-ui/system borders.
Updated markdown tables in border docs to reflect the addition of these properties.

With this PR, the previous workaround is no longer necessary.  Instead, users can specify the exact border<Position>Color property, like so:
<Box
  borderTop={1}
  borderTopColor="background.default"
 />

Changes look good, let’s also add tests that will ensure this new scenario would break again. Also, please revert the changes in the translated md files. Only the changes in borders.md are enough

Sounds good.  Where do you recommend I add these tests?  I think it'd need to involve some mock rendering.  The existing borders.test.js only tests the borderRadius conversion.

We’ve added the other border tests in https://github.com/mui-org/material-ui/blob/next/packages/material-ui-system/src/Box/Box.test.js I propose we add these there too.

@mnajdova I've added tests and they've passed, but test_browser-1 is failing on ci/circleci.  I just checked some other recent PRs and the same test is failing for those as well.

Would this PR fix this issue?
https://codesandbox.io/s/border-color-issue-nqzrz?file=/demo.js


Add a DirectCasClient

If a service ticket exists on the url, the validation occurs; otherwise, the user is redirected to the CAS server with the current url as the CAS service

PR: https://github.com/pac4j/pac4j/pull/620


chore: add benchmark test for merge queue

Summary
Benchmark performance when pushing a pr to merge queue

Test Plan

!jerry-test

!jerry

!jerry

Let's obverse how PR benchmarks behave before adding this to the merge queue. The merge queue will get overloaded if there are a lot of false positives.


Revert "release-service update (#2252)"

This reverts commit d30c946f714bd0f220efc8e30d22e6e52870b025.
The change in release service introduced a race condition that happens often when creating a subpath during
release pipelinerun creation.
See Jira for more details:
https://issues.redhat.com/browse/RHTAPBUGS-691
This is also being reverted in release-service:
https://github.com/redhat-appstudio/release-service/pull/235

/lgtm

/lgtm

/lgtm
/approve

This is no longer needed - the same was achieved by https://github.com/redhat-appstudio/infra-deployments/pull/2261


Exec libexec/sub from bin/sub instead of symlinking

While trying to provide a tool built with sub as a gem, I learned that symlinks aren't maintained while building gems. This meant that bin/sub would be flattened into a copy of libexec/sub rather than remaining a symlink. This was problematic because the bin file within a gem must be a ruby script.
This change execs libexec/sub instead of symlinking, which removes a roadblock when gemifying sub projects.

I got bitten by this today after copying the file directory via scp. I hadn't ran into the problem with rsync or tar, so I wasn't expecting a problem with scp, but the version of scp I have didn't support symlinks, resulting an "command not found" error on the other end, because the top level command was found, but none of the sub-commands were found.
Short of avoiding symlinks, it would nice if this issue was detected-- the main script should be able to detect the right symlink is in place and throw a more helpful message if the symlink is expected but has been flattened.


feat: Added isEmpty() for Singly Linked List

closes #24

Closes #24

Great job @bhaveesarna! Could write a unit test for this function's implementation?
Taking reference from this dummy test, implement the container tests for a Singly Linked List.
First step
Search, read, and understand information about lists, linked lists, and singly-linked lists, and how they are implemented.
Second step
Open a pull request with the data structure implementation, and wait for comments from @code-sherpas/kollections-maintainers.
Minimum acceptance criteria

The implementation must be well documented with proper Javadoc at Class and function levels.
The implementation must be tested with automatic tests that cover all relevant cases and situations.
The implementation must be generic.
The implementation must have the expected time complexity according to Computer Science. Here you can find a very helpful cheat sheet.

Related resources:

https://medium.com/swlh/a-different-look-at-api-tests-with-rest-assured-junit-5-and-kotlin-590789f31097

@ashikka I've implemented a test case for the function

Great job @bhaveesarna! I think we can merge this PR. Woohoo :tada:


stop panic on nil value

We have files that we are processing that have nil values inside of a list somewhere, that when casted via
 value.([]byte)

Causes a panic.
This change will instead append the nil value and seems to fix our problem.  I am not privy to whether or not this is allowed in parquet, or a good suggested change for the lib.

Hi Mike, thanks for your PR. I'm able to reproduce the issue, and it seems to be more widespread. In particular, we can't even produce files with repeated binary fields that contain null values. We're currently investigating how to best fix this, both the read and write side of it.

@akrennmair :+1:

@akrennmair I was playing around with this library and I found a bunch of issues in parsing/floor library.
Especially, optional lists, with empty/nil values throw the error:
sub-group list or bag not found, which I believe is because func (e *unmarshElem) List (UnmarshalList, error) doesn't account for empty lists.
I also found another issue which throws errors element not found in current list element. Would you be open to accepting PRs fixing these issues?

Hi @mmacdermaid, sorry that this took so long. Can you retry this with parquet-go's latest release (v0.7.0)? I've been trying to reproduce this, and really couldn't. There's a unit test (TestRepeatedBinaryWithNil) that should trigger this issue, and it seems to at least return something somehow reasonable.

@akrennmair If I get the time I can try, but it's going to be a while.  I think we made a fork and moved on and I'm not even sure what file was originally causing this.


Can't use mouse in custom

Hi men, I would like to use this as a full cam for stream buuuut, i succeed to attribute all keys of my keyboard to an actions but not to toggle the mouse for custom config, I saw that in your data.cpp you set the default value of mouse for custom on false. I think this override the json file so we can't use mouse with the custom mode.
Kind Regards

The default values in src/data.cpp get overwritten with your values from config.json if they are at the correct position.
Your config.json might be malformed, would you mind sharing a unedited version here?
(dont forget to use codeblocks)

I am having the same issue rn, doing "mouse": true doesn't give you a mouse in the custom mode.
 {
    "mode": 5,
    "resolution": {
        "letterboxing": false,
        "width": 1920,
        "height": 1080,
        "horizontalPosition": 0,
        "verticalPosition": 0
    },
    "decoration": {
        "leftHanded": false,
        "rgb": [255, 255, 255],
        "offsetX": [0, 11],
        "offsetY": [0, -65],
        "scalar": [1.0, 1.0]
    },
    "osu": {
        "mouse": true,
        "paw": [255, 255, 255],
        "pawEdge": [0, 0, 0],
        "key1": [90],
        "key2": [88],
        "smoke": [67],
        "wave": [86]
    },
    "taiko": {
        "leftCentre": [88],
        "rightCentre": [67],
        "leftRim": [90],
        "rightRim": [86]
    },
    "catch": {
        "left": [37],
        "right": [39],
        "dash": [16]
    },
    "mania": {
        "4K": true,
        "key4K": [68, 70, 74, 75],
        "key7K": [83, 68, 70, 32, 74, 75, 76]
    },
	"custom": {
		"mouse": true,
		"paw": [255, 255, 255],
		"pawEdge": [0, 0, 0],
		"background": "img/osu/mousebg.png",
		"keyContainers": [
			{
				"defaultImage": "img/osu/up.png",
				"keys":[
				{
					"image": "img/osu/left.png",
					"keyCodes": [81]
				},
				{
					"image": "img/osu/right.png",
					"keyCodes": [87]
				},
				{
					"image": "img/mania/left1.png",
					"keyCodes": [69]
				},
				{
					"image": "img/mania/left2.png",
					"keyCodes": [82]
				},
				{
					"image": "img/osu/wave.png",
					"keyCodes": [67]
				}
				]
			},
			{
				"defaultImage": "img/osu/empty.png",
				"keys":[
			{
					"image": "img/osu/smoke.png",
					"keyCodes": [86]
			}
			]
			}
			]

}
}

I've had a look through the source code, and just realised that custom.cpp doesn't have the mouse support, aka it's just not implemented.

In the current Master branch mouse support is definetly supported in custom mode (at least for linux). @kuroni has not yet made a Release that includes that functionality. The latest Release was done on the 13. Aug. and the PR #84 was made on 27. Sep.
It should be possible if you build it yourself from master.
Your JSON does not work with my build because the image for your mouse is missing. The default json from data.cpp also does not have a default entry for that. I fixed this in #88 wich is not (yet) merged.
This is how that should look like:
"custom": {
    "mouse": true,
    "paw": [255, 255, 255],
    "pawEdge": [0, 0, 0],
    "background": "img/osu/mousebg.png",
    "mouseImage": "img/osu/mouse.png",
    "keyContainers": [ "..." ]
}

I can provide a Linux binary if you want, but I cannot build for Windows.
Hope this helped.

Never mind, I got cross-compiling working.
Here are the Linux and Windows binaries with my own config.json that uses custom mode with mouse.
I tested it with wine and on real Windows 10, both work.
bongocat-osu_win64.zip
bongocat-osu_linux64.zip

As I said, the latest release is missing the mouse functionality.
The config.json you provided earlier works as long as you add the key mouseImage with the value being the path to a image as string.
Happy to be of help <3

Sorry, mouse is now available in custom mode now. Really sorry I've been away for a while :(


Drop old typos

That were missed in the setup for #61

/wordlist

Urgh the wrong credentials are being cached in the wordlist update so CI isn't being kicked off. Will fix separately.


MIlestones with 2/29 due date display as 2/28

Description
As simple as it sounds. Create a milestone with due date 2/29/2024, and it will display as 2/28/2024.

Gitea Version
1.21.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
2.40.1
Operating System
Gentoo
How are you running Gitea?

See https://try.gitea.io/janie314/SDFSDF/milestones @yardenshoham

Looks ok on my side

What's your timezone?

Yup. This is based on timezone. The value is stored as a date in the db, but then the time library displays it as a datetime and due to midnight utc being different it shows as a different day.

I see- thanks all!
Looks like there is no per-user timezone setting for Gitea. I suppose we can either close this or leave this issue open as an enhancement request for that.

I'd suggest keeping this open, as the due date should probably be treated as a date.

How to reproduce? Should I set a different timezone in my OS? Currently on GMT+2

@yardenshoham yeah, likely changing your timezone to any one lower than UTC-0. As then "midnight" utc will a different day.

Thanks, I was able to reproduce. How should we handle this? Maybe parse the user's timezone and set the milestone to the user's midnight?

Hmhm. Currently, Gitea does not have an default timezone setting and uses its server's timezone, as I understand.
I suggest:

Next to this date input (and other similar date inputs), we note the Gitea server's timezone (America/Chicago, UTC, etc.)

Because with the original issue submitted- the issue was that the date I chose was secretly converted to a date in the server's timezone. So- server-timezone dates are the dates we use, in reality, so just making a small note of that will be a straightforward resolution.

Or we can have a timezone selection near the date.

issue also have dealine, maybe have same problem.

Imho we should reduce this datetime in the database to date via migration.


Can't see media after install to DigitalOcean

Laravel Version: 5.5
Voyager Version: latest
PHP Version: 7.14
Database Driver & Version: MySQL

Description:
After I deployed my project to Digital Ocean, I can't longer see images that should be in media folder in admin panel.
No posts media, no user media etc. Media from public direction shows well. Screenshot: http://joxi.ru/EA4j7e9TD7wMvm
Folder now has link icon: http://joxi.ru/52aEq08TGj4Wq2 comparing to localhost
Have no more ideas how to figure out it.
Everything else works great.
Any one had the same problems and how to solve?
I'm using local disk. (Tried to change to public but, doesn't help)

First, what are the urls for your site and the broken image? Feel free to change your domain to example.com if you don't want it public.
I'm assuming you pushed your site to the server via FTP/FTPS/SFTP.  These services don't understand symlinks, and instead will copy it as a regular folder.  If the URLs seem correct, and the file exists at /path/to/laravel/storage/app/public/[image_path], the you should delete the folder at /.../public/storage, then run artisan storage:link

File I can't see in back-end.
https://overwatch-seasons.com/storage/teams/1518029671.png
File I can't see in front-end:
https://overwatch-seasons.com/teams/February2018/OyxJZdPF1oGqLNmWEHPg.png
Different path.
My disk is local (for laravel and for voyager)
my disks:
` 'disks' => [
    'local' => [
        'driver' => 'local',
        'root' => storage_path('app/public'),
    ],

    'public' => [
        'driver' => 'local',
        'root' => storage_path('app/public'),
        'url' => env('APP_URL').'/storage',
        'visibility' => 'public',
    ],`

up, still need help guys with urls

@Philword, patience. It's been 21 hours, including overnight for most of us.  We'll get to your issue, but it sometimes takes a little while.
For your issue, you'll want to look at the laravel documentation on assets. I have absolutely no idea how it worked locally, but it's impossible to truly troubleshoot from here without seeing your configuration and code.

@fletch3555 Sorry, I'm that person who just can't wait, my bad)
According the issue. Actually I'm using basic configuration, and my disk is public as I noted before. Maybe git url could help? https://github.com/Philword/overwatch-seasons

What does your .env file look like on your server?  I noticed you have a .env.example but I'm only assuming that you have an exclude for your git site.  I would make sure your .env app url matches your own live domain.
APP_URL=http://www.myexamplewebsite.com

I believe this has been fixed in v1.1, can someone test it?

Closing due to inactivity


Added support for dependency keywords with full issue/PR url

What we're fixing
Github supports linking with issue/PR url, so I wanted to write dependency like Depends on https://github.com/alvarocavalcanti/pierre-decheck/pull/72.
I usually use this style for linking to issues in external repo, because it's easier to copy and paste :)
see: https://help.github.com/en/github/writing-on-github/autolinked-references-and-urls#issues-and-pull-requests
What we've done here

support dependency keywords with full issue/PR url
some improvements to regex pattern

How to verify these changes
Run tests.

@mosheeshel @alvarocavalcanti Thanks for the review 😃  I've just updated the README.