Request for a "How to JSON with Flutter?" article

We've received many requests for opinions, examples, and best practices for using JSON (usually with REST) with Flutter.

What JSON libraries exist, and what are their trade-offs?
How do I minimize hand-coding boilerplate encoding/decoding code?
Can I annotate my Dart objects and give them to some JSON encoder?
What are the performance implications?

There may be solutions for the above, but it's not clear to a Flutter developer what's available, what's recommended, or how to start.

We'd love for someone in our community to write a post about this. This article doesn't necessarily have to come from the Flutter team.

I could write an article on flutter.rocks about this if you like.
AFAIK, there's two ways for handling JSON in Flutter:

manually, using the JSON.encode (and JSON.decode) methods from dart:convert library
using built_value, which I actually have a draft article on.

And the reason for dartson and similar JSON libraries not working with Flutter is because dart:mirrors isn't supported, due to interfering with tree-shaking.
Am I correct? Wouldn't want to give false information to anyone :)

https://pub.dartlang.org/packages/json_serializable (which is maintained by the Dart team) is also based on code generation like built_value and therefore works with Flutter.
built_value is more opinionated (deep immutability)
There are others (jaguar, ...?)

@roughike sounds like a great start! (and yes, dart:mirrors doesn't work in Flutter)
@kevmoo is working on making json_serializable easy to use. We can add that to @roughike 's article later.

Making good progress on docs
https://github.com/dart-lang/json_serializable/pull/83
https://github.com/dart-lang/json_serializable/tree/more_readme_fun/example

Awesome! I have a busy weekend, but I'll ping you when I have something :)

@roughike something is better than nothing, so don't aim for perfection right away :) and thank you!

@kevmoo I am standing by to be your UX study. Can't wait to give it a try!

@sethladd see https://github.com/dart-lang/json_serializable/tree/master/example
Give it a try!
...and try to make some progress on https://github.com/flutter/flutter/issues/13607

I have the base for the article and samples in place for the manual dart:convert way and json_serializable way.
I'm pretty sure it's best to leave built_value out of this, and focus on those two ways, the pros and cons, and what to choose in which situation and why. Otherwise I'm afraid the article will become too heavy to read through.
Since my site now exists in GitHub, I'll make a Pull Request to it and notify you here when I'm done. That way you can have a chance for reviewing it before it goes public :)
I'll wrap up my work in the next couple days.

You could add a link to this article from the author of built_value https://medium.com/dartlang/darts-built-value-for-serialization

Wonderful! Happy to review!
On Mon, Dec 18, 2017 at 10:36 AM, Iiro Krankka<EMAIL_ADDRESS>wrote:

I have the base for the article and samples in place for the manual
dart:convert way and json_serializable way.
I'm pretty sure it's best to leave built_value out of this, and focus on
those two ways, the pros and cons, and what to choose in which situation
and why. Otherwise I'm afraid the article will become too heavy to read
through.
Since my site now exists in GitHub, I'll make a Pull Request to it and
notify you here when I'm done. That way you can have a chance for reviewing
it before it goes public :)
I'll wrap up my work in the next couple days.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/13520#issuecomment-352518552,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCit8UktkxCvafRlc0flqhId1fhYvZks5tBrCjgaJpZM4Q_eiT
.

@roughike thanks for the head's up! Looking forward to the draft.

@sethladd Sure!
Was planning on doing a blog post about it, but if it fits better in the flutter.io site then why not. Kinda busy with work and the New Year celebrations (doing both simultaneously), but I'll make a PR directly to the Flutter site then :)

Cool. Let's take a look at the article. Please write it with the goal of being included in the main website. Worst case, you can publish as blog post. But, I suspect this is an area relevant to pretty much everyone so we should aim for the website. Thanks!

It's currently kind of my own writing style, and it's not quite there just yet.
I'll rework it a bit to be more of the writing style that the main website has. Give me a couple days into the next year and I'll have something then.

@sethladd I think it might be worth adding this link to the existing page on the website
https://javiercbk.github.io/json_to_dart/
Reduces the need to manually write the code, seems to cover the scenario covered at https://flutter.io/json/#serializing-json-inside-model-classes and can be used as a starting point to use the code generation libraries

@MaikuB  It's a great tool why this is not mention any where ??


Add Gui

Requested Feature
Add Gui
Possible implementation
No response

Im not a part of the spotDL team. But I have a WIP on desktop GUI app. It's in early development stage.

Mhh okay thanks but why you have such strange name?


Fixing date and time for Zurich

LGTM.
PS. Please capitalize your PR titles and commit messages.
Thanks!

@baryluk Thanks for the comment. I will make sure the PRs and commit messages are more descriptive in the future.

Thanks for the fixes.
@metaodi Please merge ;)


Support kind env with different names in gen_pki.sh

What type of PR is this?

Bug fixes
What this PR does / why we need it:
Support environments with multiple kind clusters, and use the currently selected cluster context.
Which issue(s) this PR fixes:
Special notes for your reviewer:
The script is no longer compatible with dash. bash is required.

lgtm


Session not saved

Hey Ingo ( @chillu )
(assigning to you as you were on the blame here: https://github.com/silverstripe/silverstripe-framework/blame/3/control/Director.php#L192)
Some session variables are not persistent in my SS 3.1.2 set up.
I've traced this back to the commented inst_save() call in Director.php:
https://github.com/silverstripe/silverstripe-framework/blob/3/control/Director.php#L192
Are you able to shed some light into this?
Thanks

Whew, 8 years ago ;) inst_save() is called after handleRequest() here, which seems to be the desired behaviour. If a custom RequestProcessor is further modifying the session via postRequest(), it needs to take care to save session data itself. I'm not sure which context your issue is coming from, sorry.

Meh just close it I'll file a proper report when I get the chance.
8yrs... We are getting old!

How's things with you? Any more trips planned south?

Hey Tim, same old over here in Wellington. No trips planned, sorry - going to EU three summers in a row, damn weddings! :D


Cloud data storage support for embedding

🚀 The feature
We have pdf and videos stored on Google Firebase, can we have a feature that gets the data from firebase for embedding and get the answers for various types of content like pdf, video, audio content
Motivation, pitch
This feature will significantly help to reuse the content (video, audio, pdfs etc) already stored on Google Cloud.

Does firebase give you a direct link for each file? Is it publicly accessible?

Yes, we do get direct link of each file. But thinking if we can folder access so that multiple files can be used.ThanksOn Sep 10, 2023, at 3:56 PM, cachho @.***> wrote:
Does firebase give you a direct link for each file? Is it publicly accessible?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Dev 2020.1 sanity check

Here are changes that reverted in dev, but brought into dev-2020.1.
These reverts were done in:

#336
#337
#357

Closed – sanity has been checked.
Branch not deleted because we want dev-2020.1 😄


exception 31

I have installed everything, but i keep getting exception 31.
Please help me.
Greetings,
Rob Peters.

MobiFlight Module not installed or not correctly installed:
https://github.com/Fragtality/Fenix2GSX#requirements

Assumed solved since no further Feedback was received.


Events won't fire and drag elements don't respond to touch

Hi, I'm having a rather frustrating problem here.
I'm trying to make it so the client can drag certain rows in a table around to sort them numerically, and then once they are done sorting I need to be able to get the order of the sorted elements so I can AJAX them to the server and update the database.
I've got my initialization code set up like this:
$(".table-sortable").sortable({
	accept: ".drag",
	forcePlaceholderSize: true,
	items: "tr.drag",
	handle: ".drag-handle"
}).on("sortable:update", function(event, ui) {
	alert("hi!");
});

The table rows with the class .drag are indeed sortable and that much works great, the only problem is that I never get that "hi!" alert.  I've been using the documentation at http://www.jqueryrain.com/?ovZdy1dF but I can't seem to get anywhere.
And then when I try to drag things by touch, nothing happens.
What am I doing wrong?

Hi, your code seems to work fine: http://codepen.io/rkusa/pen/mVwxvq?editors=101
If this does not work for you, which browser are you using?
However, touch-dnd hides/collapses the currently dragged element using a negative margin-bottom. This unfortunately does not work for tr elements. As long as you are fine with having some whitespace where the dragged element comes for, this is not a problem. If you don't like this whitespace, I am afraid touch-dnd is not a good fit for your use case.

Yeah, the drag method works fine, so that's not an issue.
Yeah, the pen works just great.  I'm using it in a project with bootstrap and a whole bunch of other javascript, so I'm thinking I must have a conflict somewhere.  I don't need the Zepto.js library, do I?
Thanks for your help, and I'll let you know what is causing the problem, once I figure it out... :wink:

Yes you don't. Zeptojs could be used as a replacement for jquery. Do you get the "Hi!" alert in the  codepen example above, but you don't get the alert in your project?

OK, that's what I thought.
I'm using Google Chrome, the code pen works great, I get the alert and it responds to touch, but the only thing that works in my project is the mouse dragging and the methods like $(".tabe-sortable

Yes, sounds like some kind of conflict between different JS libraries. If you are able to reproduce it in a minimal example, I could take a look.

It's a complicated administrative control area, so I couldn't really reproduce it very easily.
I'm using jQuery (obviously), jQuery UI, bootstrap, and then a few more jQuery plugins.

Sorry for the late answer. It really sounds like inferences between plugins, e.g, some plugin preventing the propagation of an event. That is, I am not able to help out :-/

That's fine, I've had to put it on the back burner for a while anyway, but I'll let you know when I get it figured out.

OK, jQuery UI turns out to be the culprit!  I removed it from the project because I decided to use other plugins instead, and presto!  I could drag & drop with touch and all the events fired like they're supposed to! :)


AzureDataStudio Crashes when saving or opening files

Describe the bug
I'm using azuredatastudio 1.33.1. The Application will terminate whenever I try to open a file.
Steps To Reproduce
Steps to reproduce the behavior:

be using nixos, and a window manager. (not a desktop environment)
install azuredatastudio with "nix-env -iA azuredatastudio"
Attempt to save or upload a document.

Expected behavior
A dialog will pop up asking where to save/open the file.
Actual behavior
Program terminates
Screenshots
If applicable, add screenshots to help explain your problem.
Notify maintainers

@avdv
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.16.2, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.16`
 - channels(root): `"nixos-21.11.335526.6c4b9f1a2fd, nixos-unstable-22.05pre349657.5bb20f9dc70"`
 - channels(matt): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

@avdv
Thank you very much! I've been living with this bug for several months!
The workaround that you shared also worked for me, I only had to source my own copy of gschemas.compiled from the nix store.
find /nix/store -type f -name gschemas.compiled -print -quit
Being that this issue appears to be cause by elements outside the azuredatastudio derivation I'll close this issue.
Thanks again!


Adds "rowspan" attribute management in fixed columns

Makes it work when there is a "rowspan" attribute in one the cell in the fixed columns.
Here is an example : https://jsfiddle.net/3v7h5erL/2/

There are useless '-' at the end of some rows, but this is a problem from bootstrap-table.
It has been corrected by @wenzhixin in https://github.com/wenzhixin/bootstrap-table/commit/468169cde5bdbf2178a9299d288622fe93777aaa and should make it work.

Thanks: https://jsfiddle.net/wenyi/3v7h5erL/3/


InfluxDB will be replaced in next release

I'm really tired of InfluxDB!
From my experience, is very unstable, highly resource usage(CPU, disk IO), and the java client is not developer friendly. Since DCMonitor is mean to be a light weight tool, it should be easy to use, maintain and resource restraint. But relying on InfluxDB makes things difficult.
Luckily the history metric storage is only used like a k-v storage with time range and group by, there are lots of storage system can handle this.
Maybe the good old mysql is a nice option.

Hi,
I agree with you that InfluxDB even than potentially interesting has so many issues that make us loose time.
My personal experience on using Redis is very positive but thinking about DCMonitor that is strictly connected to Druid, why not using Druid itself as storage?
Moreover Druid allow to have HTTP Metrics emitter and should be nice that future version of DCMonitor can show Kafka graphs and Druid too :-)
Unfortunately I'm not a Java developer, but everything I can do to help you ... just ask
Thanks
Maurizio

Since druid is not easy to deploy and most users of this tool are  just to monitor the kafka producer  rate and consumer rate, to make DcMonitor to be a light weight tool, we like use common and easy database.


J

Hi, you might have created this out of error? If not, feel free to re-open and add some details around the issue you wanted to create. Thanks. Ditto for #81


How to get the super_index_raw_to_level0?

Hello,
I find in demo.ipynb: "If we want to do full-resolution predictions, we need to set the parameter to true ."
I want to get the 'sub' to obtain the "sub_level0_to_raw" parameter. I have set "load_full_res_idx: true". When I load the .h5 file to see if the P0 has the key 'sub', there isn't a sub but have these below:

1. I want to obtain the sub_level0_to_raw, so the 'pointers' is what I want(i.e. sub_level0_to_raw=pointers)?
2. I want to assign the P0's index to the point in the raw data, what can i do based on 'pointers' and 'points'?

Thank you!

If I understand well: the 'sub' key is indeed present in your HDF5 and load_full_res_idx=True ? This should normally work then.  After which, make sure your dataset.point_load_keys contains 'sub', this is what load_full_res_idx=True should trigger. To this end check:
# Make sure 'sub' is among the point_load_keys
print(datamodule.val_dataset.point_load_keys)

I experimentally make sure that the 'sub' key is the In the 'cluster' as showed in the first questions I posted where I can get the 'points' and the 'pointers'. Provide some explanations for this question. I solved my problem and I'll close this issue.


[1.3] Disable TensorRT

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Disable TensorRT in OpenCE1.3 as it doesn't fit dependency-wise.
Will re-enable in 1.4 with TRT8.
Also - update the submodule git hash for ONNX to one that matches 1.7.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

Need to update the build number


The confidence scores of the part affinity field for bone-GCN

Thank you for sharing such amazing work. I have gone through the code and I have a question about how to get the confidence scores of the PAF for bone-GCN.
In the current eval_gt_h36m.py, I understand that we assume the confidence score of each joint is 1 in this case. So we get the
affpts = torch.ones(bsize,17,17).cuda() / 17. If we want to test our own custom images, we should use the real confidence scores of each joint from OpenPose.
However, when I looked at the outputs data from OpenPose, I couldn't find where we can get the confidence scores of the PAF. I assume this part: affb = torch.ones(bsize,16,16).cuda() / 16 is where we should put the actually scores. It would be great if you can share details about how to generate the confidence scores of the PAF.
Thank you so much for your time and help.

The confidence score of PAF is the cosine similarity between PAF and the vector and the bone vector.
You can refer to the following implementation:
https://github.com/spmallick/learnopencv/blob/bac974ac5043c387d5de1a8736e9c94719876bee/OpenPose-Multi-Person/multi-person-openpose.py#L111

Thank you so much for your reply. Now I know how to compute the confidence score of PAF. But I'm still confused about the shape of affpts and affb. For each joint and bone,  we get a confidence score, I'd like to know why the shape of affpts is (bsize,17,17) instead of (bsize,17,1).
Thank you so much for your time and help.

The shape of confidence score should be (bsize, 1, 17) for affpts and (bsize, 1, 16) for boneaff, and you need to repeat it into shape (bsize, 17, 17) and (bsize, 16,16), respectively.

Thank you so much for your reply. I'd like to make sure that I understand it correctly, The shape of confidence score for all joints is (bsize, 1, 17), but we want to make the shape to be (bsize, 17, 17). So we just repeat it into shape (bsize, 17, 17)?

After repeating it into shape (bsize, 17, 17), you may also need to multiply it with the exponential term as described in equation 1 in the paper. For example, for the entry (bsize, i, j), you need to multiply it by exp(-order(i,j)). The order is the number of hops required to reach joint i from joint j.
You can try either adding it or not adding it.


[NETBEANS-54] Module Review - Resolves #65 - html.editor.lib

Replaces license header with apache standard.
If there is a problem with the formatting changes caused by my text editor let me know and I can adjust any of those files.

@martypowell If you come from @emilianbold 's repo (https://github.com/emilianbold/incubator-netbeans), please send your PR there. i.e. not apache:master but emilianbold:master

@junichi11 thanks wasn't paying attention...will do


When will the 72b model release?

Thank you for your work! Any plan to release the 72b model?

+1

@jinze1994

@jinze1994

Yes, we will release Qwen2-VL-72b, and it is coming soon!!!


Errors and warnings seen on screen when black cache is absent

Describe the bug
Our code that calls trestle functions reports errors and warnings about failing to write grammar tables.
To Reproduce

Remove black or it's cache directory from your machine
Run trestle

The datamodel-code-generator that trestle depends on uses black (19.10b and < 20). The black 19.10b has a bug that creates the cache a bit too late if it is invoked via it's library (blib2to3). Issue references (#1143 and #1223). #1223 fixes it but in 20.x of black.
Not sure if this affects its operation in anyway. I found this when I had cleaned up some of the software on my mac (not virtual env). I had removed black
Expected behavior
No errors / warnings appear.
Screenshots
[INFO] :: blib2to3.pgen2.driver :: Generating grammar tables from /Users/saikiran/src/cdil/venv/lib/python3.8/site-packages/blib2to3/Grammar.txt
[INFO] :: blib2to3.pgen2.driver :: Writing grammar tables to /Users/saikiran/Library/Caches/black/19.10b0/Grammar3.8.0.final.0.pickle
[INFO] :: blib2to3.pgen2.driver :: Writing failed: [Errno 2] No such file or directory: '/Users/saikiran/Library/Caches/black/19.10b0/tmpurc39jo_'
[INFO] :: blib2to3.pgen2.driver :: Generating grammar tables from /Users/saikiran/src/cdil/venv/lib/python3.8/site-packages/blib2to3/PatternGrammar.txt
[INFO] :: blib2to3.pgen2.driver :: Writing grammar tables to /Users/saikiran/Library/Caches/black/19.10b0/PatternGrammar3.8.0.final.0.pickle
[INFO] :: blib2to3.pgen2.driver :: Writing failed: [Errno 2] No such file or directory: '/Users/saikiran/Library/Caches/black/19.10b0/tmpdqzih1yx'

Desktop (please complete the following information):

OS: MacOSX

Additional context
None

@aNebula  - we ran into this issue before with some users. I believe you introduced datamodel-code-generator for some of the alias / case handling functionalities in the library.
Lets sync with @fsuits on #233 I think when that issue is completed it may allow us to avoid the issue (by using the latest version of datamodel code generator).


using latest sonatype image

works fine with latest release from sonatype 3.19.1-01
Tested using the Docker scripts.

@avnertzur Thank you very much. I will check the changes in couple of days.

@avnertzur Thanks, it's merged.


Docs: Inter font is not applied

Until a few days ago, the font(inter) was applied well, but now the basic font is applied.
Accessing the ark.ui.com page in ignito mode is the same.
Screenshot

It fixed by https://github.com/chakra-ui/ark/commit/4b626849e2ecd299f44469ac0eb10af9c4f4e25b
thx!


feat: added text overrides on StripePaymentCheckoutAction

Signed-off-by: Haris Spahija<EMAIL_ADDRESS>Part of: #409
Impact: minor
Type: feature
Component
StripePaymentCheckoutAction now has overrides when i18next will be implemented (see #409)
Breaking changes
No breaking chances, all added fields are optional
Testing

Add a new prop billingAddressTitleText to <StripePaymentCheckoutAction />
Add the value "test" to billingAddressTitleText
Button should display "test" when test is given as a value to the prop. When the prop billingAddressTitleText is not added, it should default to the values given in default props

Added props:
billingAddressTitleText: PropTypes.string,
secureCaptionText: PropTypes.string,

@aldeed these items should be translated aswell but are they part of the component? Should I add overrides in the same way?
const billingAddressOptions = [{
  id: "1",
  label: "Same as shipping address",
  value: "same_as_shipping"
},
{
  id: "2",
  label: "Use a different billing address",
  value: "use_different_billing_address"
}];

@HarisSpahijaPon Yes, I would move it down into the component and add sameAddressLabelText and differentAddressLabelText props or something similar.

🚀 Preview deployed
Built with commit 1aef6f5c0ba1d023fb4d21ecbf56d4f0fb5dcf24
https://deploy-preview-461--stoic-hodgkin-c0179e.netlify.com

I currently have very little time to do this one, I opened it to the community in the story. Maybe someone can fix this for a new release.

It works as is and billingAddressOptions can be done in a future PR

:tada: This PR is included in version 0.69.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


When deposit an NFT, automatically detect the ones in my wallet

When I deposit an NFT it would be great to automatically detect the NFTs in my wallet from the collection and get a list view with an image preview to select them as I don't know the IDs without having to look at my wallet in Gamma. Maybe Gamma API can be used for this feature?

This would be a nice and useful feature. Let's see what data source we can use for it.

#26 added this feature. NFT holdings appears under the input and clicking on them autofills the input.


feat: #2030 - added logo to 5 preference pages

New files:

contact.svg
contribute.svg
faq.svg
login.svg
main.svg

Impacted files:

login_page.php: added logo
pubspec.yaml: added asset folder
user_preferences_connect.dart: added logo
user_preferences_contribute.dart: added logo
user_preferences_faq.dart: added logo
user_preferences_page.dart: added logo

What

Added logo to 5 preference pages

Screenshot

Fixes bug(s)

Closes: #2030 #2031 #2032 #2033 #2034

Have you stumbled into trouble to tint the children they are in, and ensure they are vertically/horizontally centered within it ?

Otherwise, really great, we can potentially refine that later.

@M123-dev @teolemon Thank you for your review!
Of course there can be improvements - if you want to avoid a heart attack I suggest that you don't try with tab devices for instance.
In an ideal world there would be a distinct project in flutter that matches figma mocks, and that would care about the sizes , proportions and colors in light and dark mode. Or some MVC.


pyenv not recognising system 3.5.1 on ubuntu 16.04

Pyenv cannot see the system installed python version of 3.5.1 on ubuntu xenial.
sayth@sayth-E6410:~$ pyenv versions
* system (set by /home/sayth/.pyenv/version)
  miniconda3-latest
  miniconda-latest
sayth@sayth-E6410:~$ python --version
Python 2.7.11+
sayth@sayth-E6410:~$ pyenv global 3.5.1
pyenv: version `3.5.1' not installed
sayth@sayth-E6410:~$ pyenv global 3.5
pyenv: version `3.5' not installed
sayth@sayth-E6410:~$ PYTHON3 --version
PYTHON3: command not found
sayth@sayth-E6410:~$ python3 --version
Python 3.5.1+
sayth@sayth-E6410:~$ pyenv global 3.5.1+
pyenv: version `3.5.1+' not installed
sayth@sayth-E6410:~$ pyenv update

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32709590-pyenv-not-recognising-system-3-5-1-on-ubuntu-16-04?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github).

You cannot use pyenv global 3.5.1 since it is clearly not a version of Python managed by pyenv. You can however do pyenv global system.
If you want to be able to use your original command, you'll have to install 3.5.1 via pyenv install 3.5.1 first.

The issue is that by using system I get python 2.7.11 not 3.5.1
sayth@sayth-E6410:~$ pyenv global system
sayth@sayth-E6410:~$ python --version
Python 2.7.11+
sayth@sayth-E6410:~$

No way to choose which system I want

There's only one "system". It basically means that pyenv does nothing. It's shims just point directly whatever is the "system level" Python distribution. That essentially boils down to your PATH environment variable, and whatever the python (and python2, python3 etc) executable/alias points to on your machine.
To see what the pyenv python shim points to, run pyenv which python.

Thanks


[BUG]Cant load my world a second time

Version of Advanced Rocketry
AdvancedRocketry-1.16.5-2.0.0-16-universal
Have you verified this is an issue in the latest unstable build

[x] Y

Version of LibVulpes
LibVulpes-1.16.5-1.0.2-26-universal
Version of Minecraft
1.16.5
Does this occur without other mods installed

[x] N/A

Crash report or log or visualVM (if applicable)
https://paste.ee/p/FlxQq <--- leaving world
https://paste.ee/p/7bQuB <--- world is not listed
https://paste.ee/p/UiFpi <--- try to load world after restart
Description of the problem
I create a world and play a few minutes.
Save the world. (first log)
Try to list my world and it does not work. (second log)
Restart the game, world is listed but i cant load. (third log)

I can confirm this, I get the exact same errors when it comes to loading the world after loading it once. Nothing shows in my list of saved worlds, and when starting it on a server it shows failed to load world such as it does in that last log.

sounds like the same bug where having

It looks like this pull request is supposed to help.

I have this issue as well, and reverting to AdvancedRocketry-1.16.5-2.0.0-12-universal will resolve it until the fix is released.

Me too. It shows up on my list, but when I try to load ANY world after quitting one, it shows up for a split second and then the world shuts down and says "Fatal Error This connection is terminated" and sends me to the server select screen. Restarting minecraft fixes it.

I can confirm this as well. It's very disappointing cause I was looking forward to this. Been working for several hours trying to figure out what was wrong because there's not even much to go on in the log file.


fix(protect-2575): fix black screen at the end of stax flow

📝 Description
To the last step of onboarding stax, we need to set hasCompletedOnboarding to true
❓ Context

Impacted projects: ledger-live-desktop
Linked resource(s): protect-2575

✅ Checklist

[ ] Test coverage
[x] Atomic delivery
[x] No breaking changes

📸 Demo
https://github.com/LedgerHQ/ledger-live/assets/118977988/bd0c428b-435a-48f2-8f91-90068e31832d

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Implemented on this PR
https://github.com/LedgerHQ/ledger-live/pull/5027


perf: common.(first/last)In2dArray are not used

Can one of the admins verify this patch?

ok to test

ok to test

Please respect our issue template form.


Bad generalization ability on testing dataset?

Hi guys,
I am getting really good results on KITTI 2015(images are all in gray) testing set which looks like below:

later I decided to test on other stereo datasets and got results like what follows below:

Is there any way to improve the result?
Looking forward to any suggestion.
Thanks

Hi, @Doodleshr
Generalization is always a big problem to deep learning.
If you have ground truth, you can finetune the model to your dataset.
If not, there is also another way to generalize deep learning approach for stereo matching.
You can refer to this paper: https://arxiv.org/pdf/1803.06641.pdf.

@JiaRenChang
Thanks, before closing the issue, do you think introducing classic MVG based depth estimation result to the existing system will be feasible?

@Doodleshr
Are you talking about something similar to this https://arxiv.org/abs/1804.00650 ?

Hi，
Now, I want to test on KITTI 2015 testing set using the mages in gray like you ,but when I run submission.py, It showed that "ValueError: axes don't match array",can you tell me how to change the code.
Looking forward to any suggestion.
Thanks


Scalameta inserting parenthesis

I'm using scalameta to generate a function and I notice its inserting some redundant parentheses. Note that this isn't a breaking issue, its just about aesthetics.
The quasiquote is something like this:
q"def someFunction(args1: Option[Int]) = args1.map{ case args1 => args1.map(_.toString) }"

and the generated Scala looks like this:
def someFunction(args1: Option[Int]) = args1.map({
    case args1 =>
        args1.map(_.toString)
})

whereas I'd want it to not have that extra set of parentheses as they are redundant, to keep things cleaner and more closely matching the original quasiquote:
def someFunction(args1: Option[Int]) = args1.map{
    case args1 =>
        args1.map(_.toString)
}

Wasn't sure if this was a scalameta thing or an interaction with scalafmt or if there is any way round this? I tried playing around with the RedundantParenthesis config option in scalafmt but it didn't seem to have an effect. Am quite new to scalameta so sorry if it's something obvious. I notice when I remove the case statement from the map, it just gives me:
def someFunction(args1: Option[Int]) = args1.map{ }

so no extra parentheses, wasn't sure if these are being caused by the case statement or the line breaks?

@q-danpryer i made the change but please keep in mind that syntax printing in scalameta is not designed nor intended to be  beautiful, aesthetic or even human-readable. usually people don't read generated code.
as to scalafmt, it should remove them if you configure correctly, but how (and why) do you run scalafmt on generated code?

Hey @kitbellew , thanks for the very speedy turnaround/fix on that one! Appreciate that its just generated code that people don't usually look at, it was more of a nice to have.
I didn't think scalafmt was necessarily involved, I was just scratching my head a bit as to why this was happening or what could be the cause.


Investigate why test_013_cli_labels is non-deterministically failing

Investigate why test_013_cli_labels is non-deterministically failing

@jeremyfowers for vis


Support/776 RM858 and RM3710 changes to dw export

RM858 and RM3710 changes to DW export
Expand the AdditionalN fields from 1-8 to 1-24.
Add 15 and 9 new framework-specific mappings to RM858 and RM3710 respectively with the space that this creates.
Also (first two commits), take the opportunity to delete unused constants and an empty sheet_mappings.rb file.

Looks good to me, and very readable commits, thanks! My only question is: is it possible/sensible to specify how many additional fields each framework has? e.g. RM858 has NUMBER_OF_ADDITIONAL_FIELDS set to 23, whereas RM3710 has it set to 17 (and I guess some others to 0?)

@james unfortunately it's not really possible. The export requires a fixed number of slots to go to. While we could say "number_of_additional_fields 17" in a framework it wouldn't get us much – perhaps checksumming that we'd got as many exports_to calls as we'd said we'd got fields?

Blimey, that was quick. Thanks 🙏


/app/public/icons dont exists

Environment
Docker
Version
homarr:latest
Describe the problem
# cd /app/public/icons
bash: cd: /app/public/icons: No such file or directory

the folder is not in the image provided
Logs
No response
Context
docker run  \
  --name homarr \
  --restart unless-stopped \
  -p 7575:7575 \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -v <your-path>/homarr/configs:/app/data/configs \
  -v <your-path>/homarr/data:/data \
  -v <your-path>/homarr/icons:**/app/public/icons \**
  -d ghcr.io/ajnart/homarr:latest

[x] I confirm that I will sacrifice my firstborn to Homarr gods

Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

me2

me3

🤔

I assume the ** are not actually there, but you added them to mark what you mean?
Did you execute the cd within the container?
When you execute ls -lha within /app/public, what does it show?

Me4
File not found with volume mount
`
volumes:

./icons:/app/public/icons
`

Did you restart the container?
https://homarr.dev/docs/customizations/icons#using-your-icons


do xlog switching when running piped basebackups for postgresql 9.6+

I belatedly noticed that the end time and end wal segment metadata naming format does not match the existing start-time and start-wal-segment, ive adjusted the MR as a result.

I belatedly noticed that the end time and end wal segment metadata naming format does not match the existing start-time and start-wal-segment, ive adjusted the MR as a result.


ng-drag-scroll does not, ehm... scroll, on touch devices

Vertical scroll works on a mouse-based event, but it doesn't on a touch based device. Verified using Chrome and Safari. It just doesn't scroll.

+1 is there an easy fix?


Restore graph and data after crash ?

Hey Joe,
My Raspberry has just crashed, I just rebuild my station with the last maj v2.6.1 it's all OK.
Now I would like to reintegrate the history of the graphs but that gives nothing (no history)
I do not use SQL database. I back up the folders automatically:
Graph Data
/ Var / lib / collectd / rrd /
XML & SQLite Portal Data
/ var / www / html / data / except for settings.xml
by restoring the files below I can not find the history of the two years :(
How to do thank you !!!

If you backed up the rrd database files using the backup utility you should have ended up with a file named adsb-receiver_data_<DATE_OF_BACKUP>.tar.gz file. If you did you should be able to restore things by running the following commands within the directory you placed the backup archive.
tar -vzxf adsb-receiver_data_<DATE_OF_BACKUP>.tar.gz
sudo cp var/lib/collectd/rrd/ /var/lib/collectd/rrd/

If you backed up the rrd files manually...
sudo cp <PATH_TO_BACKUP_RRDS>* /var/lib/collectd/rrd/localhost/

Thank you for your answer, I'm using your backup script which is in the folder /home/pi/adbs/tools/portal_backup.sh. Everything works fine every day, but when I restore the data by the commands:
1- tar -vzxf adsb-receiver_data_ <DATE_OF_BACKUP> .tar.gz
2- sudo cp var / lib / collectd / rrd / / var / lib / collectd / rrd /, I do not find the history of the measures idem after a reboot, do I have to launch other commands?

For your information, the backup script is running every day at 4am. The data is in portal version 2.5, while I try to reload with the new version 2.6.1, is this the origin of the problem?

This is great news, and it will make it easier to restore and especially not lose data and graphs.
Do you have an idea for the commands rrdtool to backup the data to XML, I managed to repair the micro sd (provisionally)

This should do the trick:
rrdtool dump /path/to/rrdfile.rrd /path/to/backup.xml

I did this in the / var / lib / collectd / rrd / localhost / dump1090-localhost folder
*for f in .rrd; do rrdtool dump ${f} > ${f}.xml; done
but I would like to make all the folders and sub folder from / var / lib / collectd / rrd / localhost /

This is not tested and written here first...
for RRD_FILE in `find . -type f -name "*.rrd"`
do
    XML=`echo $RRD_FILE | sed 's/.rrd//g'`
    rrdtool dump $RRD_FILE > $XML.xml
done

Currently working on the v2.6.2 release this evening so have not have time to test it.

It is functional for the creation of rdd files for each folder, I will write directly on my synology to avoid the corruption of the micro SD

So I take it the dump/restore worked? If so good to hear. Will be sure to adjust the backup script to use said method from now on if so.

With a compression because the size is much larger, I was able to restore the graphs and data on my new raspberry

With a compression because the size is much larger, I was able to restore the graphs and data on my new raspberry

Hi Joe,
I've written a script just for the purpose, maybe it can be useful meanwhile backup/restore functions are better integrated in future releases...I hope you don't mind about it, feel free to copy or modify as you like.
backman.sh.txt

Hi jhonnymonclair
Thank you for the script, I like it. I will modify it to make it work manually with a scheduled task.
Thank

if error /bin/bash^M: bad interpreter: No such file or directory -> sed -i -e 's/\r$//' backman.sh

The backup script has been fixed.
I will be working on a restore option for 2.7.0 next.
BTW Thanks @jhonnymonclair for the script. I used a somewhat modified version of what you created to fix the backup process in my backup script. I am sure it will come in useful when working on the restore script as well.


User leaves the workshop

As a user (parent role) I can leave Workshop so that to attend another one
Role
user (parent role)
Precondition
Workshop is created by service provider;
Users profile is created and logged in
User added his children to the profile
User (parent role) applied to Workshop for himself
User (parent role) applied to Workshop for his children
User (parent role) wants to leave from the Workshop by himself
User (parent role) wants to take his child out from the Workshop
Postcondition
Users can apply 2 applications per week, per person.
Example 1: parent wants to apply by himself - he can apply 2 times per week
Example 2: parent wants to apply with his children - each person can apply 2 times per week (7 days) (1 parent + 2 children = 6 applications per 2 week)
If the limit of applications exceeded - parent will see an error on the screen:
{{Перевищено ліміт заявок
Спробуйте ще за тиждень}}

Acceptance Criteria
SCENARIO #1 Parent wants to leave from the Workshop by himself
GIVEN parent is logged in
AND enters “Кабінет користувача”
AND clicks tab “Заяви”
AND selects application with the status “Очікує підтвердження” appeared in the cabinet of the user that he wants to to take out from the workshop

AND clicks button “Залишити гурток”
AND confirmation pop-up appears on the screen

WHEN parent clicks “Надіслати”
THEN chosen user is removed from the workshop
AND system message is shown on the screen {{Дякуємо! Користувач {{User Name}} було успішно видалено з гуртку {{Workshop name}} }}

AND application with the status “Гурток залишено” appeared in the cabinet of the user

AND notification with the changed status is sent to the user who submitted the application

Business rules
Has statuses:

Очікує підтвердження (присвоюється відразу після відправки до ЗПО);
Прийнято до конкурсного відбору
Зараховано;
Навчається {{ number years}} років
Відмовлено (з вказаною причиною.)
Гурток залишено

1)Display By filing date:
first goes the old ones
next, go the new ones
from up to down
2)Display alphabetically
https://docs.google.com/document/d/1lz9ekFqhQ8wfqW-eEUFWJNz65IWbhR4dXGg9mE118h8/edit

https://github.com/ita-social-projects/OoS-Backend/issues/572 Include rules


add feloy as reviewer/approver

Add @feloy to OWNERS file.

/hold for review
@feloy has contributed the new resources generator and is a core reference documentation contributor.

/hold for review
@feloy has contributed the new resources generator and is a core reference documentation contributor.

/approve cancel

/approve cancel

Looks like I am missing a step in this process.

Looks like I am missing a step in this process.

@kbhawkey 👋🏻

Looks like I am missing a step in this process.

Based on the bot reply, I think @feloy needs to join the kubernetes-sigs org before he can be an OWNER.

@kbhawkey 👋🏻

Looks like I am missing a step in this process.

Based on the bot reply, I think @feloy needs to join the kubernetes-sigs org before he can be an OWNER.

@zacharysarah @kbhawkey can you sponsor me to join the kubernetes-sigs org?

@zacharysarah @kbhawkey can you sponsor me to join the kubernetes-sigs org?

@zacharysarah @kbhawkey can you sponsor me to join the kubernetes-sigs org?

@zacharysarah @kbhawkey can you sponsor me to join the kubernetes-sigs org?

@feloy

can you sponsor me to join the kubernetes-sigs org?

Gladly. 👍🏻

@feloy

can you sponsor me to join the kubernetes-sigs org?

Gladly. 👍🏻

can you sponsor me to join the kubernetes-sigs org?

@feloy, Yes, that's great!

can you sponsor me to join the kubernetes-sigs org?

@feloy, Yes, that's great!

I've created the issue to join kubernetes-sigs: https://github.com/kubernetes/org/issues/2404

I've created the issue to join kubernetes-sigs: https://github.com/kubernetes/org/issues/2404

/hold cancel

/hold cancel

/verify-owners

/verify-owners

My approval here created a conflict, sorry @kbhawkey. Once conflict is resolved this is good to go!
/lgtm
/approve

My approval here created a conflict, sorry @kbhawkey. Once conflict is resolved this is good to go!
/lgtm
/approve

/lgtm

/lgtm


GSS_ID

Forgive me if this is somewhere I missed- it is NOT an issue with nflgame.  I find about 270 RB, QB, TE, WR, K, positions on NFL.com without a gss-id (or so says the player update program).  These are mostly new players in the league. I know it is up to the NFL to assigned them but I was wondering if anyone has experience from years past as to when they get assigned... people building their draft lists are missing new players like Manzeil since he has no gss-id (my program maps gss-id to RaysFFL playerid)... I can add code to put these players in my database but if the NFL generally assign a gss-id, say by the first game of the preseason (Sunday, 8/3), then I will just wait.
Ray

Stumbled across this.  Appears to be occurring again this year.  Rookies have not been assigned a GSIS_ID, at least from the source I'm pulling from (Sleeper Apps API).  I see they are assigned if you look at the source code on NFL.com, but perhaps not through the JSON yet....Hopefully it fixes itself like in the years past.

@gullo this project is unmaintained/stale, please see the readme for the active fork.


Add texture's data to be set

This helps avoid a copy when users overwrite the data.
I'm not sure if this is allowed, but it seems to "work".

i can add checks for continuity and same shape if you want.

I'm a bit hesitant, because currently the array that's passed to the texture stays the data placeholder. We even mention that in the docs "Note: the data is the same reference that was given to instantiate this object". It also says "but this may change", but I don't know what code in pygfx and downstream libs assume that the array does not change.
This relates to #19, which lists some possibilities for buffers, but some also apply to textures. Also relates to #600. If we are to change it, it'd probably be best to do it together with other (possibly breaking) changes to buffer/texture.
I assume the main point is speed by avoiding data copies?

I assume the main point is speed by avoiding data copies?
Yes the main point is to avoid data copies.

To be precise, when working with "4k" sized images this has a very noticeable effect on performance for me.
Thank you for pointing me to both those issues. I've subscribed and will try to contribute to those discussions however I can.
From my leanings this past week:

Changing the size of the data should not be allowed, at least not without other logic.

NB. This was possible with vispy / opengl (though it is unclear if this was a bug we took advantage of).

I haven't really tested with anything other than just Intel integrated graphics + linux. So I too fear that there may some things that aren't OK with other processing pipelines.

Memory copies are really important to consider. So hopefully I can learn more about GSL and WGPU to be able to better contribute.
Thank you for the discussion. I'll close this and discuss on the aforementioned issues.

AFAIK the size of a texture in OpenGL is fixed, but I think we handled size changes in vispy at a relatively low level. In pygfx we opted (for now) to more "closely" wrap the GPU texture.
Do you think there are use-cases where being able to change the size has advantages? Under the hood a new texture object will have to be created anyway, so in terms of performance it won't differ from creating a new gfx.Texture.

Do you think there are use-cases where being able to change the size has advantages?

I don't really think so.
Personally, my biggest challenge right now is dealing with the "-0.5" offset in the images that seems to be occuring from somewhere in the pipeline ;) it will take me some time, but i'll figure it out. Your examples have been tremendously helpful.
I think that overtime, we got better at managing things between vispy and now pygfx so the advantages that seemed good 5 years ago when we first built our display pipeline are not actually useful.
For "changing the texture size" (that is the number of bytes) isn't so useful since removing and adding textures seems very very fast in pygfx.

Personally, my biggest challenge right now is dealing with the "-0.5" offset in the images

The gfx.Image indeed has an offset so that the pixel center's are aligned with the grid, i.e. the bottomleft pixel is on top of the origin. This is hard-coded in the shader:
https://github.com/pygfx/pygfx/blob/329586c59e1dd98519794b0ef6159552ccd19ef6/pygfx/renderers/wgpu/imageshader.py#L63-L76
But you should be able to undo it by doing image.local.position = 0.5, 0.5, 0.

[...] removing and adding textures seems very very fast in pygfx.

Yes it should be pretty fast. The bindings will be updated, and therefore the pipeline object recomposed, but there is no shader recompilation, which would be much more expensive.

I should say that
             let pos1 = vec2<f32>(-0.5);

is probably the right way to interpret images. it is just a little annoying to do this change at the visualization level in our codebase.

I've been listening and reading alot about WGPU and why it was created over vulkan.
Their primary desire was to ensure safety for the web, and rust really prides itself on  being memory safe.
I would be surprised if, given the little code I wrote that the proposed operation was not safe. It mostly avoids a python side copy in the data transfer chain.

I agree. My main reason from being hesitant is related to expectations about how the pygfx Texture object relates to the data it holds. I also agree we should probably support a path to avoid data copies when updating all data. I added a note to the top post of #19.

A small question. Is the whole _rev stuff supposed to be a unique global counter? or just "each object's rev should be different when updating a particular object"

The id of a worldObject is globally unique. The _rev's are per-object and should be monotonously increasing at each update.


Make sentry_logging JS friendly

https://pub.dev/packages/sentry_logging/score
the extension class imports import 'package:sentry/sentry_io.dart';

@ueman was the import a mistake or intentional?

It's by mistake :( I've already seen it, too. I'll hope to find some time in the next few days to fix the logging issues.


Device Tests Sync and Async

Currently each test file has 2 tests that test sync and then async.
Connections also has 2 types of named Clients/APIs getting connected meant for the Sync Client (from Sync API) and another meant for Async Client (from Async API). This happens for both device and module.
Some abstract APIs have been included. The signature of functions in these abstract APIs have been marked with async def making async default . We have plans later to convert to 1 single test with 1 single client (either coming from Sync Or Async) and that 1 test will test synchronous functionality or asynchronous functionality.  When the test runs on synchronous functionality the async def portion would be unused.
Included the module_under_test_has_device_wrapper on some connect disconnect tests,

Check
https://github.com/Azure/iot-sdks-e2e-fx/pull/8


Rss feeds

I haven't reviewed this yet, but let's make the autodiscovery meta tags part of this PR too? I also don't see a route for the feeds? Are they exposed yet?

This is WIP - just an easy view for me to see the PR diffs :)


Quote text and attachment missing

Are there any related issues?
Possibly #2537
What operating system are you using?
macOS Sierra (10.12.4)
What version of Nylas Mail are you using?
2.0.15
Bug?
Do you have any third-party plugins installed? If so, which ones?
None
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
Gmail (no other provider available to compare)
Is the issue reproducible with a particular attachment, message, signature, etc?
An email in a thread is missing:

The quoted email contents
The PDF attachment

The thread has multiple back-and-forth quotes, and previous emails in the chain show up properly.
The same email shows up properly in Nylas N1 (v1.5.0).
I can't post the whole email, but here's a redacted version lacking headers:
--Apple-Mail=_854913B1-91AF-432B-B4EC-7CD79AAB8A3A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

REDACTED PLAINTEXT EMAIL - NEW BODY AND QUOTE CHAIN

--Apple-Mail=_854913B1-91AF-432B-B4EC-7CD79AAB8A3A
Content-Type: multipart/mixed; boundary="Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4"

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

REDACTED HTML EMAIL - NEW BODY (NO QUOTE CHAIN)

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4
Content-Disposition: inline; filename="REDACTED WITH ONLY ASCII CHARACTERS.pdf"
Content-Type: application/pdf; x-unix-mode=0644; name="REDACTED WITH ONLY ASCII CHARACTERS.pdf"
Content-Transfer-Encoding: base64

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

REDACTED HTML EMAIL - JUST QUOTE CHAIN

--Apple-Mail=_6B98F2A6-AAC7-4FA8-AA9E-09BCD8ABB0D4--
--Apple-Mail=_854913B1-91AF-432B-B4EC-7CD79AAB8A3A--

And a simpler case with more details that happens to trigger the missing attachment case:
Delivered-To<EMAIL_ADDRESS>Received: by IP_REDACTED with SMTP id o139csp371908itc;
        Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
X-Received: by IP_REDACTED with SMTP id m7mr3228250ywf.20.1492627255645;
        Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
Return-Path<EMAIL_ADDRESS>Received: from DNS_REDACTED (DNS_REDACTED [IP_REDACTED])
        by mx.google.com with ESMTPS id t3si1414783ywd.456.2<IP_ADDRESS>.40.55
        for<EMAIL_ADDRESS>        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
Received-SPF: pass (google.com: domain of<EMAIL_ADDRESS>designates IP_REDACTED as permitted sender) client-ip=IP_REDACTED;
Authentication-Results: mx.google.com;
       dkim=pass<EMAIL_ADDRESS>       spf=pass (google.com: domain of<EMAIL_ADDRESS>designates IP_REDACTED as permitted sender<EMAIL_ADDRESS>       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com
Received: by mail-yb0-x232.google.com with SMTP id 6so10887123ybq.2
        for<EMAIL_ADDRESS>Wed, 19 Apr 2017 11:40:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=from:mime-version:subject:message-id:date:to;
        bh=UZCmb73u2zZf4gunLNPY4rkeXxyfhM8EMx83Rm0tQcM=;
        b=hjHoNUZGwULjdd7iSKnCPNYxucYlxWf0Umlj+ae9rqqT4tUbwKxw/g/W7grfuUQPgP
         c+bSy5lpvxn6cHiD6Vi6faa1rsRtDB+NF6nXCQDYPSHWbYBgSrfmjbpqq01iDL60nIjO
         mISJDFzb+wjy2i15d33jpm6fDonmb4sJ4wcKv0MhJJ74jUN+pAUuI5dUHl+A+agTtyqR
         2LKKcZZD06SVOyihNTLXaYVmZwfK4Mra4mLdJPlCUHquZ8DDF2Ac3sBp88hlo4ZfTvPY
         zEfx9JSy16cqmBIZ/jvG7INsIKvgO/9Fe4m2M7yOj9Fn7XBpubpOKlHu4exRkC+Tno6A
         wZ3A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:mime-version:subject:message-id:date:to;
        bh=UZCmb73u2zZf4gunLNPY4rkeXxyfhM8EMx83Rm0tQcM=;
        b=ge07v0qbcqBC5kvn+9D3+Kdo3XyD/MjXKfA3G6VJPVZ4iCIgV4gEWkzhvZ6sbZ3gWB
         l4wn1nvvdwWr87w4may/Z182fPtxLAZp1+mMLyjNegZyEzwTt0T8EL3T970PH2IMwKyy
         pyakzetlQjAmR4w/WrGabxrZGVBAoiSeMAgxm2Dd8Evrdhb5adctlBLZGwgIoB/k5Nc6
         sW9s+FV+cDb99sYL7Rci9/PN55f5Vne3LF8G2ihSwYGEyeskSu1aI+E4KunyYmbqplv8
         Up4vuEKOWFFfbAhDqFefI07RE4Zxy6o0pC/dF7TjRaDu3rI+YozLScs8oNRjYGhdNi0z
         Adxg==
X-Gm-Message-State: AN3rC/5pNY3FxmFKZMEVk1/VkSOx5AWklpGtvuAjiPL318J+B82jEpbn njBHk2X4CHuS710e+hc=
X-Received: by IP_REDACTED with SMTP id d84mr4279832pfk.7.1492627254119;
        Wed, 19 Apr 2017 11:40:54 -0700 (PDT)
Return-Path<EMAIL_ADDRESS>Received: from [IP_REDACTED] (DNS_REDACTED [IP_REDACTED])
        by smtp.gmail.com with ESMTPSA id v13sm1967418pgo.44.2<IP_ADDRESS>.40.52
        for<EMAIL_ADDRESS>        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 19 Apr 2017 11:40:53 -0700 (PDT)
From: SENDER REDACTED<EMAIL_ADDRESS>Content-Type: multipart/mixed; boundary="Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Demonstrate Nylas bug
Message-Id<EMAIL_ADDRESS>Date: Wed, 19 Apr 2017 11:40:51 -0700
To: RECIPIENT REDACTED<EMAIL_ADDRESS>X-Mailer: Apple Mail (2.3273)

--Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii

Please see attached PDF below:

--Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA
Content-Disposition: inline; filename=pipeline_line_map-630x420.pdf
Content-Type: application/pdf; x-unix-mode=0600; name="pipeline_line_map-630x420.pdf"
Content-Transfer-Encoding: base64

--Apple-Mail=_443BABAC-4940-4351-9ECA-3672950C7BBA--

The more I look at this the more I'm convinced it's a duplicate of at least the Mac Mail bits of #2537. My quote text is disappearing because it's being placed below the inline attachment in the message structure.


Map interaction - Jukebox

Support for jukebox actions

Moving back to V1 milestone since sounds need to be implemented before this


[Slang VK CTS] UBO subset

UBO subset https://docs.google.com/spreadsheets/d/1J-gLbTbLNytr8tqJeUWGrNyA3p-kvJncMz3PRAlQF7o/edit#gid=390018280

Closing; work to enable failing tests is captured in #3998


Starter kit or Cookiecutter

anyone willing to create a cookiecutter or starter kit version of this? would be very cool, the other cookiecutter that this codebase is basing on has too much for apis

This is a nice idea, I would be glad to see something like this.

I'm working on it


[CCXDEV-10875] Trigger PR_Checks

Trying to trigger PR checks after @epapbak warned us that it may not be working.

Commenting the export job caused [insights] io-gathering-service pr-check to fail but didn't impact [insights] io-gathering-conditions pr-check

Codecov Report
Patch and project coverage have no change.

Comparison is base (6af8cce) 89.43% compared to head (982b729) 89.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   89.43%   89.43%
=======================================
  Files          14       14
  Lines         388      388
=======================================
  Hits          347      347
  Misses         31       31
  Partials       10       10

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Closing pull request, tests are working as expected


Support importing CA public key from a file

It would be nice to support loading a CA certificate from a file (e.g. by mounting a ConfigMap in Kubernetes) instead of manually baking it into the docker image.
Thanks!

Thanks for the feature request.
What is end purpose of this CA, is this solely to make the oidc discovery endpoint work?

For now it is indeed to make the OIDC discovery endpoint work, as I'm getting this error during startup of the controlplane pod:
panic: failed to create OIDC authenticator: Get "https://hostname/realms/Chainloop/.well-known/openid-configuration": tls: failed to verify certificate: x509: certificate signed by unknown authority


Does not respond to other bots' comments

Hi @jakebolam and other maintainers!
I have a question about how the All Contributors bot operates.
Right now I am using Ranger to create my All Contributor comments, as shown here: https://github.com/carbon-app/carbon/pull/858#issuecomment-531336464; however, the All Contributors bot doesn't respond.
I assume this is because Ranger isn't an owner or something, but Ranger does have write access to this repo.
In my opinion, Ranger should be treated almost equivalently to other maintainers, especially when they have the valid permissions.
Really appreciate your time helping me understand this issue.

Ah I see, it is because you are only listening to User requests:
https://github.com/all-contributors/all-contributors-bot/blob/master/src/serverless-webhook.js#L83
if (payload.sender.type !== 'User') {
  return {
    statusCode: 201,
    body: 'Not from a user, exiting',
  }
}

Is this intentional, or would you be open to extending this to payload.sender.type !== 'Bot'

I'm not sure why it was added. Could you try to find out with git blame? Maybe there was a good reason?

Yes, the bot only listens to humans and it was intentional (not sure why tho).

Here is where the change was introduced: https://github.com/all-contributors/all-contributors-bot/commit/1d143321295fd25f900cc78c568b3471b2e1dfbf#diff-4dfd399fabf3b052cceb02a3d7d4750fR31
Would you be open to me adding 'Bot' in a PR?

Hey @gr2m would you be open to me adding a PR to allow @all-contributors to respond to other bots?

Yes. I'm just a bit nervous deploying right now, but let's try

No rush no deploying! I'll push the PR, and we can discuss there. Maybe others in the community have other qualms that I am not aware of.

Thanks! Let's leave it open for a week and if there are no objections let's merge it in.


Add information about the location of the first changeset

Mappers more confidence of mappers to welcome users that are closer to their area of mapping, so could be helpful to insert an approximate location of the area of interest where the changeset has been done.
The location could be something at the level of osm admin_level 4 or 6 or similar for EU countries NUTS1 or NUTS2.

That's indeed a good idea!
I'll need to check if OSMCha provides such information.
If not, we could reverse geocode the centroid of the changeset (won't be perfect if the changeset is quite large but I don't see another way to do this).

As a possible additional improvement connected to this, it would be great if zooming in the map allows to filter the list of changesets/contributors selecting only the ones inside the visible area.

@alesarrett I've split your request to a new issue: #134


Compressing seq2seq

Hey,
We've recently written a tutorial on compressing a PyTorch language model using the element-wise AGP pruner.
We're seeking community help to add an example of pruning a PyTorch seq2seq model (for example).
Thanks,
Neta

Hi Neta, Sure, I will make an attempt at adding this example.

Cool - please tell me if you need anything.

Hi Neta,
I had a basic question related to the pruning flow, in particular, the point at which the mask which can be set by _ParameterPruner.set_param_mask() is applied to the model parameters.
Here was my question.
In pruner.py , i notice this method
https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/distiller/pruning/pruner.py#L32 that seems to be responsible for actually applying the mask that could be set by set_param_mask of the child classes of _ParameterPruner but from a static search I did not find a singe usage of this method anywhere.
So if this https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/distiller/pruning/pruner.py#L32 method is not used, I wanted to find out where are the masks applied to the model parameters ?
The best answer I could come up is looking at https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/distiller/scheduler.py#L36 .
I am little confused as to why you decided to have this ParameterMasker class https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/distiller/scheduler.py#L29 with the apply_mask method

Hi Vinu,
To properly answer you, I would need to write-up something longer to explain the design, but until then, here's my answer.
Function threshold_model is indeed not used, and perhaps I should remove it.
https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/distiller/pruning/pruner.py#L32
The pruning flow is this:
For each epoch:
compression_scheduler.on_epoch_begin(epoch)
train()
validate()
save_checkpoint()
compression_scheduler.on_epoch_end(epoch)
train():
For each training step:
compression_scheduler.on_minibatch_begin(epoch)
output = model(input_var)
loss = criterion(output, target_var)
compression_scheduler.before_backward_pass(epoch)
loss.backward()
optimizer.step()
compression_scheduler.on_minibatch_end(epoch)
compression_scheduler.on_epoch_begin(epoch)
==> pruning_policy.on_epoch_begin()
====>pruner.set_param_mask(...)
This tells the pruner associated with this instance of PruningPolicy to compute and set the pruning mask.  There is a binary mask (0/1) for each parameter tensor.  When the mask is applied, each tensor coefficient is either turned to zero (mask for that coefficient is 0) or kept unchanged (mask is 1 for that coefficient).
So the Pruner computes the mask, at the beginning of each epoch (if the compression_scheduler determines that this PruningPolicy should be scheduled in this epoch).
Note that so far, we only prepared the mask - we have not applied it yet.
Now we start training the epoch and we invoke:
compression_scheduler.on_minibatch_begin(epoch)
==> pruning_policy.on_minibatch_begin()
====>zeros_mask_dict[param_name].apply_mask(param)
This last line is responsible for applying the binary mask (we do this by multiplying the tensor with its mask).
To summarize, at the beginning of each epoch, the CompressionScheduler checks if we are supposed to schedule (i.e. invoke the Pruner).  If yes, then we call into the Pruner and ask it to prepare the mask.
Then, at the beginning of each epoch, we mask the weights tensors.
I hope this helps,
Neta

Thank you for the explanation.

Hi Neta,
I have a few follow up queries.
[1]
Unless one really wants to test these pruning functions like in https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/tests/test_pruning.py#L153
or really remove/modify the network architecture like in https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/examples/automated_deep_compression/ADC.py#L306 , one need not worry about thinning functions.
[2] Pruning is just setting zeros in the 4D weight tensors without modifying the network architecture in any manner. In some sense, it is a simulation of the thinning process.  Whereas thinning is the real effect of pruning a network.
[3] If one wants to study the effect of pruning on a DNN, we need not be using the thinning utilities, just masking the weights, is a good estimate for sparsity studies ?
To be very specific, if we take https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/tests/test_pruning.py#L110 and look at the snippets commened as # Remove filters and # Test Thinning
these codes are not necessary unless we are actually wanting to changes the network architecture.
    for pair in config.module_pairs:
        # Test that we can access the weights tensor of the first convolution in layer 1
        conv1_p = distiller.model_find_param(model, pair[0] + ".weight")
        assert conv1_p is not None
        num_filters = conv1_p.size(0)

        # Test that there are no zero-filters
        assert distiller.sparsity_3D(conv1_p) == 0.0

        # Create a filter-ranking pruner
        reg_regims = {pair[0] + ".weight": [ratio_to_prune, "3D"]}
        pruner = distiller.pruning.L1RankedStructureParameterPruner("filter_pruner", reg_regims)
        pruner.set_param_mask(conv1_p, pair[0] + ".weight", zeros_mask_dict, meta=None)

        conv1 = common.find_module_by_name(model, pair[0])
        assert conv1 is not None
        # Test that the mask has the correct fraction of filters pruned.
        # We asked for 10%, but there are only 16 filters, so we have to settle for 1/16 filters
        expected_cnt_removed_filters = int(ratio_to_prune * conv1.out_channels)
        expected_pruning = expected_cnt_removed_filters / conv1.out_channels
        masker = zeros_mask_dict[pair[0] + ".weight"]
        assert masker is not None
        assert distiller.sparsity_3D(masker.mask) == expected_pruning

        # Use the mask to prune
        assert distiller.sparsity_3D(conv1_p) == 0
        masker.apply_mask(conv1_p)
        assert distiller.sparsity_3D(conv1_p) == expected_pruning

        # Remove filters --> THIS IS NOT MANDATORY FOR PRUNING STUDIES ?
        conv2 = common.find_module_by_name(model, pair[1])
        assert conv2 is not None
        assert conv1.out_channels == num_filters
        assert conv2.in_channels == num_filters

    # Test thinning --> THIS IS NOT MANDATORY FOR PRUNING STUDIES ?
    distiller.remove_filters(model, zeros_mask_dict, config.arch, config.dataset, optimizer=None)
    assert conv1.out_channels == num_filters - expected_cnt_removed_filters
    assert conv2.in_channels == num_filters - expected_cnt_removed_filters
    return model, zeros_mask_dict

Hi Vinu,
[1] Correct
[2] True, except for a big exception when removing channels/filters (this needs to be fixed).  When pruning channels, in the current implementation: I set the corresponding channels to zero (i.e. prune).
When "thinning" channels: I remove those (output) channels, but I also look if there are convolutions feeding the pruned convolutions.  If there are, then I remove their corresponding filters (and biases).  And if there are BN layers between the convolutions, I adjust their parameters, too.  The same is true when we prune/thin filters, with the details being somewhat different.  I'll write-up a tutorial about this sometime later.  If you are doing fine pruning (element-wise pruning), then there is no such thing as thinning - only pruning.
[3] Again, if you want to study channel/filter pruning, I think the best way is to do thinning.  There might be positive correlation between the behavior of channel-pruned and a channel-thinned network.  By which I mean that perhaps the best performing channel-pruning configuration is also the best performing channel-thinning network.  This is a hunch, and I haven't studied this.
[3b] Correct, the code blocks you marked with
    # Remove filters --> THIS IS NOT MANDATORY FOR PRUNING STUDIES ?

are indeed not necessary if not thinning.
Cheers,
Neta

Thanks Neta !
Another query related the most basic magnitude pruner  the
https://github.com/NervanaSystems/distiller/blob/9374732d4993ef23b2e28433422fafd4b1cdab12/distiller/pruning/magnitude_pruner.py#L20
Could you please help me understand the usage of this pruner with an example.
particularly how to set these threshold values either one for entire network or the ability
to set one per layer. and how to pass it using the **kwargs . Basically I am having trouble
[1] understanding the usage of self.threshold[*]
[2] zeros_mask_dict[param_name].mask should we call this method for all param_names in a loop
class MagnitudeParameterPruner(_ParameterPruner):
    def __init__(self, name, thresholds, **kwargs):
        super(MagnitudeParameterPruner, self).__init__(name)
        self.thresholds = thresholds

    def set_param_mask(self, param, param_name, zeros_mask_dict, meta):
        threshold = self.thresholds.get(param_name, self.thresholds['*'])
        zeros_mask_dict[param_name].mask = distiller.threshold_mask(param.data, threshold)

A test case for this pruner using small vgg or resnet would be ideal.

Hi Vinu,
[0] **kwargs is not currently used - it's there to "absorb" extra keywords that the compression schedule parser might pass it.  But that's kind of a silly reason to have it there, and we might remove it from the function signature sometime.
[1] Regarding self.threshold[*]:   I think that the test code and new documentation I committed should explain it best now.
[2] Yes, you can call this in a loop if you want to prune all of the parameters of a model.  But be careful: because the default self.threshold[*] threshold will be used on any parameter that doesn't have an explicit threshold.  You can use a pruner directly, no issue with that, but remember that in general, like in the compress_classifier.py example, the CompressionScheduler will invoke a PruningPolicy which will invoke the Pruner (see for example).
MagnitudeParameterPruner is not used by any example code currently, besides the new test code, but you can look at SparsityLevelParameterPruner which is used in this example, because the two pruners are very similar.
I found magnitude pruning to be pretty hard to use directly because you really need to know the threshold values for each tensor you want to prune.  This value changes per tensor and it's hard to get it right (requires a lot of trial and error and is sensitive to the training duration).  Therefore, I prefer using a level-pruner.


State based classNames require className

For activeClassName or rejectClassName to work, className must be set.

So what's the issue here?

It seems clunky to require className to use activeClassName. I don't need a generic className on my implementation, just an activeClassName.

@jking90 Open for PRs!

Sounds legit. Please submit a PR!


Excel error (in Dutch) in unimod.csv

This is a very minor issue, but there is a Dutch-language Excel error "#NAAM?" in the third column on line 68 (corresponding to Unimod_id 107, FormylMet) in unimod.csv.

Hi Magnus!
Thanks for spotting, this is fixed now.


Infinite loop -> OOM in SampleBuilder edge case

If the s.buildSample call inside of purgeBuffers happens to find a complete packet, s.active is updated to s.consume.tail https://github.com/pion/webrtc/blob/d625f6f6373b6e7140baee0957777035f67b02da/pkg/media/samplebuilder/samplebuilder.go#L227, but then the loop condition is triggered again in purgeBuffers and s.active is reset back to s.filled, causing the same packet to be unmarhsaled over and over in a tight loop. I changed the continue to return which seems to fix this behavior for me, but there might be a more correct solution
Your environment.

Version: webrtc master https://github.com/pion/webrtc/commit/d625f6f6373b6e7140baee0957777035f67b02da
Browser: Chrome
Using samplebuilder in ion-avp

What did you do?
Saw this issue in SampleBuilder used in ion-avp connected to ion-sfu, caused by a vp8 stream sent from chrome specifically when some minor packet reordering occurred.
What did you expect?
Reconstruct packets even with reordering
What happened?
Infinite loop + OOM

Nice catch @kcking ! Sorry about hitting this bug
@robin-raymond you have the bandwidth to look into this? If not I can grab?
@kcking if you are interested in contributing a unit test that fails would be a really great first contribution. Would love to work together on this. Would be nice if @robin-raymond has a quick fix, but if not this could be ours to take.

I will take a look.

Hi @kcking and @robin-raymond. Thank you for your contributions!  I believe I ran across the same issue.  The program panics on line 246 with an "out of memory" error occasionally.
https://github.com/pion/webrtc/blob/d625f6f6373b6e7140baee0957777035f67b02da/pkg/media/samplebuilder/samplebuilder.go#L246
webrtc Version: v3.0.29
Browser: Chrome
Here is the trace if you are interested:
`

: fatal error: runtime: out of memory
: runtime stack:
: runtime.throw(0x17f1101, 0x16)
: /usr/local/go/src/runtime/panic.go:1117 +0x72
: runtime.sysMap(0xc1bc000000, 0x4000000, 0x2613130)
: /usr/local/go/src/runtime/mem_linux.go:169 +0xc6
: runtime.(*mheap).sysAlloc(0x25f9780, 0x400000, 0x42c2b7, 0x25f9788)
: /usr/local/go/src/runtime/malloc.go:729 +0x1e5
: runtime.(*mheap).grow(0x25f9780, 0x9, 0x0)
: /usr/local/go/src/runtime/mheap.go:1346 +0x85
: runtime.(*mheap).allocSpan(0x25f9780, 0x9, 0x100, 0x7f6af2ae8d38)
: /usr/local/go/src/runtime/mheap.go:1173 +0x609
: runtime.(*mheap).alloc.func1()
: /usr/local/go/src/runtime/mheap.go:910 +0x59
: runtime.systemstack(0x0)
: /usr/local/go/src/runtime/asm_amd64.s:379 +0x66
: runtime.mstart()
: /usr/local/go/src/runtime/proc.go:1246
: goroutine 1334506 [running]:
: runtime.systemstack_switch()
: /usr/local/go/src/runtime/asm_amd64.s:339 fp=0xc00f37b6a0 sp=0xc00f37b698 pc=0x46f860
: runtime.(*mheap).alloc(0x25f9780, 0x9, 0x7f6af2d00001, 0x7f6af2ae8d38)
: /usr/local/go/src/runtime/mheap.go:904 +0x85 fp=0xc00f37b6f0 sp=0xc00f37b6a0 pc=0x427f65
: runtime.(*mcache).allocLarge(0x7f6b2a424108, 0x12000, 0x100, 0x7f6af2ae8d38)
: /usr/local/go/src/runtime/mcache.go:224 +0x97 fp=0xc00f37b748 sp=0xc00f37b6f0 pc=0x4185d7
: runtime.mallocgc(0x12000, 0x0, 0x9d00, 0xc1bbff0000)
: /usr/local/go/src/runtime/malloc.go:1078 +0x925 fp=0xc00f37b7d0 sp=0xc00f37b748 pc=0x40e165
: runtime.growslice(0x151db20, 0xc1bbff0000, 0xddd0, 0xe000, 0xe26f, 0x49f, 0x5a4, 0x0)
: /usr/local/go/src/runtime/slice.go:224 +0x154 fp=0xc00f37b838 sp=0xc00f37b7d0 pc=0x4507f4
: github.com/pion/webrtc/v3/pkg/media/samplebuilder.(*SampleBuilder).buildSample(0xc01b880000, 0x681a6701, 0xc0e4f95700)
: /Users/dj/go/pkg/mod/github.com/pion/webrtc/v3@v3.0.29/pkg/media/samplebuilder/samplebuilder.go:246 +0x30b fp=0xc00f37b8d8 sp=0xc00f37b838 pc=0
: github.com/pion/webrtc/v3/pkg/media/samplebuilder.(*SampleBuilder).purgeBuffers(0xc01b880000)
: /Users/dj/go/pkg/mod/github.com/pion/webrtc/v3@v3.0.29/pkg/media/samplebuilder/samplebuilder.go:135 +0x106 fp=0xc00f37b900 sp=0xc00f37b8d8 pc=0
: github.com/pion/webrtc/v3/pkg/media/samplebuilder.(*SampleBuilder).Push(0xc01b880000, 0xc015bd63f0)
: /Users/dj/go/pkg/mod/github.com/pion/webrtc/v3@v3.0.29/pkg/media/samplebuilder/samplebuilder.go:167 +0xa5 fp=0xc00f37b920 sp=0xc00f37b900 pc=0x
: my_package/pion.(*WebmSaver).PushVP8(0xc00e8df4d0, 0xc015bd63f0)
: /Users/dj/go/src/my_package/pion/saver.go:136 +0x58 fp=0xc00f37b9a0 sp=0xc00f37b920 pc=0x1272958
: my_package/pion.(*StreamService).runMain(0xc0007bf830, 0xc01ce3b830, 0xc018e34c00, 0xc01533b200, 0x4, 0x4, 0x0, 0x0, 0x0, 0x0, ...)
: /Users/dj/go/src/my_package/pion/stream.go:728 +0x166f fp=0xc00f37bf48 sp=0xc00f37b9a0 pc=0x1278eaf
: runtime.goexit()
`

Ok, I understand what's happening. Active becomes "empty" after consuming the packets, but instead of the "filled" getting purged by "purgeConsumedBuffers", it doesn't because active is now empty and empty buffers cannot cause any purging. So the solution is to purge the "consumed" area first, then "active". That will resolve the issue. I'm going to link a PR to give this a test if you like since you've been hitting this issue.

@danj565 You might want to check if your issue is related or not. I'm uncertain how it would cause memory overflow, unless the infinite loop causes a backlog in the builder which indirectly causes it.

@robin-raymond Thanks again for your contribution. I will replicate and report back if I hit the OOM issue again.

I can confirm the samplebuilder fix works in production!  Thanks again @robin-raymond .. @Sean-Der I noticed this was not apart of any release.  Let me know what I can do to help. Thank you for the great library!

@Sean-Der sorry for the delayed response.  I would love to contribute.  Please add me to the organization.

@danj565 done!


Updates for Guzzle 6

This repo is not maintained anymore. However my fork is kept up to date and has Guzzle 6 - https://github.com/threesquared/laravel-wp-api

Thank you for information. Will know. I needed in one project supporting of
this package with Guzzle 6, so I have made these changes.
On Wed, Mar 23, 2016 at 11:28 PM, Ben Speakman<EMAIL_ADDRESS>wrote:

This repo is not maintained anymore. However my fork is kept up to date
and has Guzzle 6 - https://github.com/threesquared/laravel-wp-api
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Cyber-Duck/laravel-wp-api/pull/6#issuecomment-200394712


"Unterminated regular expression" Error

I keep getting an "Unterminated regular expression" error on simple XML code.

Here is my gulpfile.js:

Where...

babel is require("gulp-babel");
src is require("gulp").src;

It might be related to the XML parser again. Does it happen if your change <header></header> to <header />?

And also... please check the latest version (1.1.1) - it might solve the issue. I have replaced the XML parser with the original Vue template parser.


Incorrect values in COVID-19 Malta - Vaccination Data.csv

Python code:
import pandas as pd
df = pd.read_csv('https://raw.githubusercontent.com/COVID19-Malta/COVID19-Data/master/COVID-19 Malta - Vaccination Data.csv')
df.iloc[378]
Output:
Date of Vaccination                    30/01/2022
Total Vaccination Doses                    1210946
Fully vaccinated (2 of 2 or 1 of 1)       464023.0
Received one dose (1 of 2 or 1 of 1)      450420.0
Total Booster doses                       329806.0
Name: 378, dtype: object
Remark:
You exchanged [Fully vaccinated (2 of 2 or 1 of 1)]  with [Received one dose (1 of 2 or 1 of 1)] for 30/01/2022.

Thanks for noticing. Corrected the swapped values. Sorry for the delay but didn't receive notice of the issue.


ADR 003 Project Structure

My input: I'd like to avoid git submodules at all costs. Some git clients can't handle them properly and it's confusing when it comes to stuff like directory.build.props.
Independent pieces of code should be in separate repos so that contributing to one feature/platform/module does not involve cloning the whole universe.

Agree on avoiding submodules. I'm planning to write about Directory.Build.props/targets and Dependencies.props for the .NET piece in this document mostly.

@Sly1024 @kruplm let's agree what to say about the frontend part

I agree with having separate repos for each component.
For the front-end, I would not constrain the project structure just yet. It will depend on the best practices for the chosen UI framework (Angular, React, etc.).
However, I think using the Node/NPM ecosystem for building the UI and dependency management is definitely advantageous, and it's the de facto standard in most open source web apps. But I'm not sure if this should be in an ADR about project structure.

As we discussed I think we need ADRs for the frontend (web/UI) parts, about language, frameworks, build infrastructure before we can decide on the project structure. This looks good for the .net projects though.

Than let's do a quick review on it and I'll merge

Can someone from @morganstanley/compose-developers provide a final review before merge?


SdkResolverService thread should have a name

Duplicate of #3962 ?

Duplicate of #3962

Shame, shame . . . (on me)


Fix bower install

This is a quick fix, but @stefanpenner and I agree the old way should still work. With that said, this will fix the issue for those trying to use this project with today's flavor of ember-cli.

Thanks @blimmer!
Published in v0.9.2.

this fix works, but only the source for `ember-cli-shims' needs to be specified since it is not published to bower (yet)

If someone wants to publish shims to bower, we can drop the source here too.


Fix order of lat/lon for generating markers

I just fell into that trap, while copying from this example. Here's the relevant leaflet code which is clear on this: https://github.com/Leaflet/Leaflet/blob/0f904a515879fcd08f69b7f51799ee7f18f23fd8/src/geo/LatLng.js#L123

fixed in 13.0.1


Updated the screenshots page

Describe your request
Can we get an update on the screenshots page? There are several themes without a screenshot.
Briefly explain its use-case
It would be helpful for deciding on a theme.

Bump this. Only found my preferred theme --- doom-ir-black --- because I happened on its issue and PR.


Refactor components for best practices

Is your feature request related to a problem? Please describe.
The currently made components in the database were hastily made by me with a React Native bias -- React Native (mobile) and React js (web) are not the same! Refactor the code to comply with React js best practices and (optional) redesign them to make it look better!
Additional Context
Things to keep in mind:

Which is better?

Components vs. PureComponents vs. Constants/Functional Programming
In-line styling vs. css stylesheets
Using component folders + index.html vs. standalone components
Repo organization

Very helpful articles to start off (highly suggest reading all of them -- and do your own research after!):
Flexbox in CSS: https://css-tricks.com/snippets/css/a-guide-to-flexbox/
Components vs. Functional Components: https://programmingwithmosh.com/react/react-functional-components/
React hooks: https://www.telerik.com/kendo-react-ui/react-hooks-guide/
Different ways of styling: https://blog.bitsrc.io/5-ways-to-style-react-components-in-2019-30f1ccc2b5b

I've added examples of each type of styling/code practice in the repo for you guys to examine, once you've decided which practice is best feel free to change all of the components to comply accordingly, and reach out if you have any questions for my opinion! We'll go over these together next meeting


Include Dashboard Link and Port-Forward for Slackernews in KOTS

https://github.com/slackernews/slackernews/pull/56


Don't extract decorators with names matching the 'data_key' of defined schema fields

@sklump Re: Aries#36 support

Codecov Report

Merging #85 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   70.98%   71.02%   +0.04%
==========================================
  Files         177      177
  Lines        7524     7535      +11
==========================================
+ Hits         5341     5352      +11
  Misses       2183     2183

agent_message.py line 64 check is still wrong: should test against non, not falsiness. All DecoratorSet descendants passed in are empty (false-ish), since they are instances not classes.

Unless I've misread the intent, this approach still needs about 20 lines of boilerplate per descendant to replace one parameter, skip_attrs, in AgentMessageSchema.extract_decorators() call to self._decorators.extract_decorators().
Could taking skip_attrs into extract_decorators itself, like this:
@pre_load
def extract_decorators(self, data, skip_attrs: Sequence[str] = None):
"""..."""
processed = self._decorators.extract_decorators(data, self.class, skip_attrs if skip_attrs else None)
then in descendant
@pre_load
def extract_decorators(self, data):
return super().extract_decorators(data, ["skip", "these", "attrs"])
work OK? Apart from the one line delta, I think the rest of the processing ought to be identical in descendants.

I will also propagate this change into my Aries#0036 PR by tomorrow morning.

Unless I've misread the intent, this approach still needs about 20 lines of boilerplate per descendant to replace one parameter, skip_attrs, in AgentMessageSchema.extract_decorators() call to self._decorators.extract_decorators().
Could taking skip_attrs into extract_decorators itself, like this:
@pre_load
def extract_decorators(self, data, skip_attrs: Sequence[str] = None):
    """..."""
    processed = self._decorators.extract_decorators(data, self.__class__, skip_attrs if skip_attrs else None)
    ...
    return processed

then in descendant
@pre_load
def extract_decorators(self, data):
    return super().extract_decorators(data, ["skip", "these", "attrs"])

work OK? Apart from the one line delta, I think the rest of the processing ought to be identical in descendants.

@sklump I didn't mean to clobber your comment -
I do like the idea of keeping things declarative. @andrewwhitehead right now, the intent is that the sub-class of agent_message would override @pre_load and pass in skip_attrs?
What about something declarative like Stephen's approach, but checking skip_attrs in a Meta class  variable?

It's not meant to be necessary to override extract_decorators, I just added skip_attrs as an optional parameter there in case somebody's using it on non-Schema'd content. It should be sufficient to declare fields like the one in the test case: handled_decorator = fields.Str(required=False, data_key="handled~decorator") and have them automatically skipped when the decorators are loaded, to be parsed by the Schema itself.

OK, I will try to get it to work and adapt accordingly by tomorrow morning.


"consumers" example doesn't behave as expected

Not all consumers are created, and messages aren't received

Last commit doesn't solve everything but at least it seems things are getting further

Using the consumers branch it works as expected... but eats 100% of 1 CPU.
Not sure what the compromise could be there.
@Geal Maybe you'll have an idea? Basically, we need notify the consumer task somehow when async messages queue is non-empty.
Maybe we could keep a list of tasks inside transport and notify them after polling the socket if the queue is not empty?


Variables showing up as flat empty lines at the start of the game until they get updated.

I believe this happens when a variable is empty or empty for the first time. It happens when clicking a reporter in ettiques too.

you can hide your variable until the first update, or, start your code with [set var () to (0)] block!

add https://utterdonkey.github.io/theme/fix.js to custom javascripts, I shall try to create a PR for it


"Download All Lyrics" doesn't work for tracks, only for albums

You can see in this video that the "Download All Lyrics" doesn't work when on Tracks section, but does in Albums section.
The folder here is about 120 000 tracks
https://youtu.be/FGNivVkh7ZY?si=Y4cJQSC5IsGBNLdt

@tangsgod I'm looking into it, but it doesn't seem to be related to a performance issue.
Could you help me check the console log to see if there is anything wrong?

Click the spider button
In the developer tool, choose tab Console
Try clicking "Download all lyrics" button
See if there is anything strange or error log shown in console
Send me the screenshot or text of the error if any

Thank you for your help
Here is the screenshot of the console after hitting the Download button for
90 000 songs
Le mer. 22 mai 2024 à 17:51, tranxuanthang @.***> a
écrit :

@tangsgod https://github.com/tangsgod I'm looking into it, but it
doesn't seem to be related to a performance issue.
Could you help me check the console log to see if there is anything wrong?

Click the spider button
In the developer tool, choose tab Console
Try clicking "Download all lyrics" button
See if there is anything strange or error log shown in console
Send me the screenshot or text of the error if any

image.png (view on web)
https://github.com/tranxuanthang/lrcget/assets/15942946/98db39a5-1a54-4147-ac42-5ff3005921a2
—
Reply to this email directly, view it on GitHub
https://github.com/tranxuanthang/lrcget/issues/81#issuecomment-2125136339,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AULQLFMATSUFZHXA6Y457R3ZDS5J5AVCNFSM6AAAAABICIMHQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGEZTMMZTHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@tangsgod I'm not seeing any image uploaded, could you reupload it?

Of course, here it is
Le ven. 24 mai 2024 à 11:13, tranxuanthang @.***> a
écrit :

@tangsgod https://github.com/tangsgod I'm not seeing any image
uploaded, could you reupload it?
—
Reply to this email directly, view it on GitHub
https://github.com/tranxuanthang/lrcget/issues/81#issuecomment-2129033216,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AULQLFIUD7AHNUHIMXBACI3ZD4AC7AVCNFSM6AAAAABICIMHQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGAZTGMRRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

The image is in the mail
Le ven. 24 mai 2024 à 12:23, Gaëtan Yorfeddog @.***> a écrit :

Of course, here it is
Le ven. 24 mai 2024 à 11:13, tranxuanthang @.***> a
écrit :

@tangsgod https://github.com/tangsgod I'm not seeing any image
uploaded, could you reupload it?
—
Reply to this email directly, view it on GitHub
https://github.com/tranxuanthang/lrcget/issues/81#issuecomment-2129033216,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AULQLFIUD7AHNUHIMXBACI3ZD4AC7AVCNFSM6AAAAABICIMHQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGAZTGMRRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@tangsgod Maybe GitHub doesn't reupload your attachment to GitHub issue, and I also cannot see it in my inbox. If you prefer emails, could you send it directly to my email address?
My email<EMAIL_ADDRESS>

It is probably resolved in commit https://github.com/tranxuanthang/lrcget/commit/0ec12966a521a40801a795c70e241be514b4dd22, released in v0.3.2. If you have any problems, feel free to leave a comment and I will reopen this, thank you!


Skipping issues that are already assigned.

There is not need to re-assign assigned issues. Further more in case a random approver is chosen, we don't want to keep assigning random approver each time the command is triggered.
Signed-off-by: Yoni Bettan<EMAIL_ADDRESS>

Codecov Report

Merging #34 (f6d9823) into main (c56bf40) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   45.79%   45.99%   +0.20%
==========================================
  Files          17       17
  Lines         808      811       +3
==========================================
+ Hits          370      373       +3
  Misses        399      399
  Partials       39       39

Impacted Files
Coverage Δ

internal/gitstream/assign.go
61.84% <100.00%> (+1.56%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[DE597167] Fix Gateway Helm installation failure due to incorrect indentation in secret.yaml file

Description of the change
When the User has additionalAnnotations custom_values, the Gateway Helm installation fails due to incorrect indentation in secret.yaml file.
Annotations are enabled when "additionalAnnotations" are passed from custom_values. By default "additionalAnnotations" are not set. When additional annotations are passed, the annotations section is enabled and fails due to incorrect indentation.
Benefits
Users can successfully add "additionalAnnotations" as required

Covered in #303


Fix: change error code in function isAccessDenied to AccessDenied

Signed-off-by: Xun Jiang<EMAIL_ADDRESS>
What does this PR change? What problem does it solve?

It's used to fix issue #4085
Was the change previously discussed in an issue or on the forum?

Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[ ] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

I've rebased the PR and slightly shortened the title of the changelog entry to fix the test failure.


Minor fix - readme.md handle example

handle example in the readme.md has the wrong options object. looks like copy/paste snafu.
thanks for the awesome work!
`<div use:draggable={{ cancel: '.cancel' }}>
You shall not drag!!🧙♂
This will drag 😁
`
Should be:
`<div use:draggable={{ handle: '.handle' }}>
You shall not drag!!🧙♂
This will drag 😁
`

Oh crap!! 🥵🥵
Thanks for reminding. I just went through whole readme, and it's full of such stuff, I'll fix it right away!
Thanks for the heads up!

Fixed!


Timeline event bubble can't handle certain characters

Clicking a timeline event generates rendering errors if an event field value contains a newline or a double-quote.  This is the root cause of https://bugzilla.redhat.com/show_bug.cgi?id=1388040.  The hawkular provider events ran into this regression when the new timeline widget was introduced. A workaround has been supplied for the provider but to protect all events this is likely an issue to be handled in the timeline itself.

@miq-bot add-label bug