Method WebDriverRunner.isFirefox() (and same) is not work correct when you implement WebDriverProvider

Hi,
We have an interesting situation. We create FirefoxBambooDriver with specific setting and implement WebDriverProvider for use this driver.
Run our tests with property :
-Dbrowser=webdrivers.FirefoxBambooDriver

In case we need check is this Firefox or Chrome browser and do corresponding actions. Call WebDriverRunner.isFirefox(), but this method return  false.
Maybe it because selenide check value from property:
FIREFOX.equalsIgnoreCase(System.getProperty("selenide.browser", System.getProperty("browser", FIREFOX)););

If I'm right, I think selenide should check instance of current WebDriver:
 public static boolean isFirefox() {
    return webdriverContainer.getWebDriver() instanceof FirefoxDriver;
  }

@apanashchenko Why do you need method isFirefox()? Initially it was created inside Selenide to use in its own purposes: to create a webdriver instance. That's why it cannot use webdriver instance :)

@asolntsev I need isFirefox() for run FF on our CI with specific settings. I think this is non good if you don't know which browser run, if you us WebDriverProvider.

@apanashchenko I still don't understand why you need to use method isFirefox(). Control is in your hands. When use set property -Dbrowser=webdrivers.FirefoxBambooDriver, you already know that you are going to use Firefox. You don't need method isFirefox() to know it.

@asolntsev for example:
mvn test -Dbrowser=webdrivers.FirefoxBambooDriver
@Step
    public void importDashboard(String pathToFile) {
        if (WebDriverRunner.isFirefox()) {
            FileSelectingHandler.setStyleDisplay($(Locators.IMPORT_DASHBOARD));
        } else {
            FileSelectingHandler.unHide($(Locators.IMPORT_DASHBOARD));
        }

        FileSelectingHandler.attachFile($(Locators.IMPORT_DASHBOARD), pathToFile);
    }

This method doesn't work, because WebDriverRunner.isFirefox() == false. This work only if you use selenide browsers firefox, chrome and etc.
I can read property browser, but i think it's not very useful if you have several custom browser.

@apanashchenko ok, now I understand why you need this.
But your suggested algorithm also will not always work because class webdrivers.FirefoxBambooDriver probably will not extend FirefoxDriver. User can create any Provider or Webdriver class that does not extend FirefoxDriver, but uses firefox under the neath.
Briefly, Selenide cannot guess which driver you are using.  Closing the issue.


Overwrite Readiness and Liveness config

Hi, alex,
I've encounterd one problem that the pgserver pods was reporting readiness/liveness probe failed. And this lead to frequent failovers. I try to login to the shell of the pod and try executing the readiness/liveness probe command:
sh -c exec pg_isready -U postgres -h $POD_IP
it always succeed with out any error. I guess it might failed only occassionally due to timeout probably. So I use
kubectl edit sts pgserver-x-x
to set a larger number for the timeout value of Readiness/Liveness probe. This seemed to work out fine, I can see it came back  ready since the change had been made, and it's stilling working fine now.
However, I went through the docs but didn't find a way to overwrite these configs, Could you support overwriting the Readiness/Liveness configuration for the statefulsets?

I opened an PR for this issue:
https://github.com/reactive-tech/kubegres/pull/75

Hi Owen,
Thank you for submitting a PR. I am going to review it this Tuesday and let you know on the same day.

I added a comment about your PR, under the "Conversation" tab.

I added a comment about your PR, under the "Conversation" tab.

I've updated the PR. It should be ready to merge now. Please check.

Thank you!
I merged your changes in the main branch.
This Thursday, I will run some tests locally and if everything is working fine, Kubegres version 1.15 will be released in prod with your changes.

Thanks

@owenchenxy  Kubegres version 1.15 is available with the changes that you implemented.
Please see the release page:
https://github.com/reactive-tech/kubegres/releases/tag/v1.15
Thank you @owenchenxy for reporting and implementing this feature!
To install Kubegres 1.15, please run:
kubectl apply -f https://raw.githubusercontent.com/reactive-tech/kubegres/v1.15/kubegres.yaml

I am closing this issue.

@owenchenxy I made few minor changes to your initial commit.
I moved the properties 'livenessProbe' and 'readinessProbe' under the property 'probe' as follows:
apiVersion: kubegres.reactive-tech.io/v1
kind: Kubegres
metadata:
  name: mypostgres
  namespace: default
spec:
...

  probe:

     livenessProbe:
        exec:
          command:
            - sh
            - -c
            - exec pg_isready -U postgres -h $POD_IP
        failureThreshold: 10
        initialDelaySeconds: 60
        periodSeconds: 20
        successThreshold: 1
        timeoutSeconds: 15

      readinessProbe:
        exec:
          command:
            - sh
            - -c
            - exec pg_isready -U postgres -h $POD_IP
        failureThreshold: 3
        initialDelaySeconds: 5
        periodSeconds: 5
        successThreshold: 1
        timeoutSeconds: 3

In the StatefulSets, I slightly increased the values in the default livenessProbe and readinessProbe, as follows:
         livenessProbe:
            exec:
              command:
                - sh
                - -c
                - exec pg_isready -U postgres -h $POD_IP
            failureThreshold: 10
            initialDelaySeconds: 60
            periodSeconds: 20
            successThreshold: 1
            timeoutSeconds: 15

         readinessProbe:
            exec:
              command:
                - sh
                - -c
                - exec pg_isready -U postgres -h $POD_IP
            failureThreshold: 3
            initialDelaySeconds: 5
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 3

I updated Kubegres documentation by adding an example of the new properties probe.livenessProbe and probe.readinessProbe: https://www.kubegres.io/doc/properties-explained.html


Record count

Data Portal record count is incorrect - only showing 3 million, but it was 4m?

The counts are wrong because index lots are no longer being included - investigating why this has suddenly changed...


select renders as input type='text' only

I'm using materialize with autoform with meteor.  For the most part, the two work very well together, well done guys!
I did notice an issue with the div wrapper materialize adds to a select box. Essentially it always assume that the input type is text, whereas the field could be boolean, number etc.
Any suggestions on how to pass a parameter for the input type (or can one remove it altogether?)

The input that is added is only for keyboard control purposes. What problem is this causing?

The issue relates to how autoform renders the input.  Because materialize renders the select box as a text input, Autoform expects that the values of the options should be strings as well.
But if the model is a boolean, number or anything other than a string, the select box doesn't render at all.  I had to add the class browser default in order to render non-string select boxes.
I 'solved' the issue by changing the schema of all of the affected fields to strings (data-validation isn't very important in my case) but over the long-term, allowing us to configure the select box would be very helpful.

The fact that just a text input is present also makes it impossible to bind to any object in ember.  Between this and the default display: none on select elements makes it less than desirable in an ember app as well.
It would be fantastic if these two frameworks played nicely together in regards to select inputs. Thanks for all the hard work.

I still don't understand why the select box would not render. in regular <select> a type is not specified and the input that is created by our function doesn't get submitted, our dropdown propagates the change to the original  element.


Include "remote_addr" in Zed lake log messages about requests/responses

Repro is with GA Zed tagged v1.8.0.
Consider the attached zed serve log zlake.txt that was generated during a repro of #4446 by connecting to the service as a remote lake from Zui and opening a new Query Session as described in https://github.com/brimdata/zui/issues/2775.
A community zync user recently reported seeing the #4446 log message in their environment and assumed it was severe due to it being an HTTP 500 and having a stack trace. The intent of #4446 is to turn that into an HTTP 400, so that will help ensure the message is not misinterpreted in the future. However, when trying to explain it to the user in the moment, one of the shortcomings in the message is that there's a lack of context about what may have triggered it.
$ zq -Z 'status==500' zlake.txt
{
    level: "warn",
    ts: 1.6855728930280771e+09,
    logger: "core",
    msg: "Error",
    request_id: "2QZtNmA0Bwzkq63F5Ct51KXK1Bl",
    status: 500,
    error: "pool name missing",
    stacktrace: "github.com/brimdata/zed/service.(*ResponseWriter).Error\n\t/home/runner/work/zed/zed/service/request.go:258\ngithub.com/brimdata/zed/service.handleQuery\n\t/home/runner/work/zed/zed/service/handlers.go:61\ngithub.com/brimdata/zed/service.(*Core).handler.func1\n\t/home/runner/work/zed/zed/service/core.go:188\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/rs/cors.(*Cors).Handler.func1\n\t/home/runner/go/pkg/mod/github.com/rs/cors@v1.8.0/cors.go:219\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/brimdata/zed/service.panicCatchMiddleware.func1.1\n\t/home/runner/work/zed/zed/service/middleware.go:92\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/brimdata/zed/service.accessLogMiddleware.func1.1\n\t/home/runner/work/zed/zed/service/middleware.go:72\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/brimdata/zed/service.requestIDMiddleware.func1.1\n\t/home/runner/work/zed/zed/service/middleware.go:28\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/home/runner/go/pkg/mod/github.com/gorilla/mux@v1.7.5-0.20200711200521-98cb6bf42e08/mux.go:210\ngithub.com/brimdata/zed/service.(*Core).ServeHTTP\n\t/home/runner/work/zed/zed/service/core.go:234\nnet/http.serverHandler.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2947\nnet/http.(*conn).serve\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:1991"
}

For instance, if that log message had included the IP address of the client that sent the request, it would have helped us divide & conquer, i.e., we could have seen the IP of their zync server or of a known Zui desktop client and then look for corresonding logs at that location.
As it turns out, it's possible to piece this together today in an environment with default log settings, in that we could search for the request_id in this message, which pairs it up with the Request completed message that does include the remote_addr field for the client IP (<IP_ADDRESS> in this case).
$ zq -Z '"2QZtNmA0Bwzkq63F5Ct51KXK1Bl"' zlake.txt
{
    level: "warn",
    ts: 1.6855728930280771e+09,
    logger: "core",
    msg: "Error",
    request_id: "2QZtNmA0Bwzkq63F5Ct51KXK1Bl",
    status: 500,
    error: "pool name missing",
    stacktrace: "github.com/brimdata/zed/service.(*ResponseWriter).Error\n\t/home/runner/work/zed/zed/service/request.go:258\ngithub.com/brimdata/zed/service.handleQuery\n\t/home/runner/work/zed/zed/service/handlers.go:61\ngithub.com/brimdata/zed/service.(*Core).handler.func1\n\t/home/runner/work/zed/zed/service/core.go:188\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/rs/cors.(*Cors).Handler.func1\n\t/home/runner/go/pkg/mod/github.com/rs/cors@v1.8.0/cors.go:219\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/brimdata/zed/service.panicCatchMiddleware.func1.1\n\t/home/runner/work/zed/zed/service/middleware.go:92\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/brimdata/zed/service.accessLogMiddleware.func1.1\n\t/home/runner/work/zed/zed/service/middleware.go:72\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/brimdata/zed/service.requestIDMiddleware.func1.1\n\t/home/runner/work/zed/zed/service/middleware.go:28\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2109\ngithub.com/gorilla/mux.(*Router).ServeHTTP\n\t/home/runner/go/pkg/mod/github.com/gorilla/mux@v1.7.5-0.20200711200521-98cb6bf42e08/mux.go:210\ngithub.com/brimdata/zed/service.(*Core).ServeHTTP\n\t/home/runner/work/zed/zed/service/core.go:234\nnet/http.serverHandler.ServeHTTP\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:2947\nnet/http.(*conn).serve\n\t/opt/hostedtoolcache/go/1.19.9/x64/src/net/http/server.go:1991"
}
{
    level: "info",
    ts: 1.6855728930282407e+09,
    logger: "http.access",
    msg: "Request completed",
    request_id: "2QZtNmA0Bwzkq63F5Ct51KXK1Bl",
    host: "<IP_ADDRESS>:9867",
    method: "POST",
    proto: "HTTP/1.1",
    remote_addr: "<IP_ADDRESS>:53588",
    request_content_length: 79,
    url: "/query?ctrl=true",
    elapsed: 0.00536952,
    response_content_length: 55,
    status_code: 500
}

However, I see two limitations with this:

It requires the user to know how to do this pairing on their end, or have them send us their entire log so we do the pairing on our end. Yes, we could augment our docs to teach users how to do these things. However, since many users will often send just the one "bad-looking" log message as the first step in their debug, packing the extra context into the more severe error reduces the number of debug round-trips with us (and increases the likelihood that they could figure it out on their end without reaching out to us.)

In the case of this community zync user, they have their log level set to warn rather than the default info, so they'd never have had the Request completed message to pair with. They changed from the default log level precisely because their zync workload caused such an excessively high number of these chatty messages like Request completed that are benign for the myriad healthy executed queries, so once again, rather than having them go through a debug iteration where they turn the info logging back on just to get this detail, it'd be great if it could be provided up front.

I don't think remote_addr belongs in the log error message here and the access log is the appropriate place. If we're going to add remote_addr why not include proto or host or url to every log message? The reason is that if you have too many fields in your log message it becomes increasingly difficult to visually parse.
In the case of this particular zync user worried about the chattiness of their logs (which I totally get), I'd suggest that they use a custom logger configuration and write the access logs to a separate file and keep the warn level logs in their console output.
EDIT
I just checked a we don't currently have a way of writing separate loggers to different paths using a logger yaml config. IIRC we used to have this but the feature seems to have disappeared in one of the refactors. I think we should add this feature back.


problem with results

Hello,
After successfully running the program, how can I get signature for each variant?
Thank you,
WangZheng

Hi @WZo0o,
I think the following videos will be helpful to you:
https://www.youtube.com/watch?v=30JmjvJ-DtI
https://www.youtube.com/watch?v=BiBYZz_khIY
https://www.youtube.com/watch?v=BchtNeaQlv0

Hi @mishugeb,
I have seen the videos that you recommended but I am still confused.
For example, I am  interested in a variation chr19：58864357- A-G，how can I get a signature for this variant?

Hi @WZo0o,
The tool is not able to detect a signature that is associated with a specific variant.

Hi @mishugeb，
Do you mean that the tool only can detect a signature for a patient, but this tool is  not able to match the signature  with a variant?


BUG: pool_class.py

currently line 85:
elif other.role in ['disable']:
should be
elif other['role'] in ['disable']:

fixed.


user cannot be used as a SageMaker execution role

What
When try to run scripts/1-1_hello_sagemaker_trainig.py, following error happened.
% poetry run python3 scripts/1-1_hello_sagemaker_trainig.py

Couldn't call 'get_role' to get Role ARN from role name <USER_NAME> to get Role path.
Traceback (most recent call last):
  File "/home/gatheluck/Scratch/SageMakerSdkSandbox/scripts/1-1_hello_sagemaker_trainig.py", line 14, in <module>
    role=sagemaker.get_execution_role(),
  File "/home/gatheluck/Scratch/SageMakerSdkSandbox/.venv/lib/python3.10/site-packages/sagemaker/session.py", line 5432, in get_execution_role
    raise ValueError(message.format(arn))
ValueError: The current AWS identity is not a role: arn:aws:iam::XXXXXXXXXXXX:user/<USER_NAME>, therefore it cannot be used as a SageMaker execution role

https://github.com/aws/sagemaker-python-sdk/issues/300#issuecomment-1431539831

Inside SageMaker we can have multiple notebook instances and each notebook instance can have a different IAM role. When running your code locally get_execution_role will not work since there might be several roles dedicated to different SageMaker notebook instances. Therefore, you have to choose which is the right role to use.
In order to make your code work in both local and remote modes, you could instantiate a variable containing the specific value of IAM role, and implement a try block like here below.

local_variable_for_sm_role = “arn:aws:iam::XXXX:role/service-role/XXXXX”
try:
    role = sagemaker.get_execution_role()
except ValueError:
    role = local_variable_for_sm_role

Offical AWS docs explain how to create role for SageMaker: https://docs.aws.amazon.com/sagemaker/latest/dg/sagemaker-roles.html


Starting container failed...

I get "Starting VirtualDSM... add bridge failed..." and container stops.
any help?

I tried it on MacOS (Intel)
docker run -it -p 5000:5000 --cap-add NET_ADMIN -v $(PWD)/syno:/storage kroese/virtual-dsm:latest

But as soon as the prompt to login appears and the browser loads http://localhost:5000/ the system shuts down.
On a native Ubuntu machine everything is working fine. Great work.

I have no Mac myself, so I cannot fix any issue with MacOS. On some machines it works.

I can give a look. I own a old Macbook.


update required metadata

replaces #47 . please review

:+1: on this.
Looks like the coverage really didn't change. Deleting some irrelevant pushed the coverage down by half a percent. We should boost test coverage in general, but this 'failure' shouldn't block a merge.


Fix renovate auto update

It's not working. Problem due to branch rules

Definitely not working at all now

Got it working!!! Notice the lack of squashes - i.e. on pushing to the main branch

Config/CI changes
Required config settings:

See #160 for some further thoughts

@stefpiatek I had another look at the logs (turns out I was looking at older ones). There were errors saying that 3 of the 6 status checks were passing. Realised that they were only running on pull requests - i.e. not branches. So have changed to running on PRs, and on pushes to main or renovate/xx


Will Microsoft.Bot.Builder.Solutions nuget package become available from official nuget repository?

Is your feature request related to a problem? Please describe.
Currently we need to add the myget feed to download Microsoft.Bot.Builder.Solutions (according to https://github.com/Microsoft/AI/issues/901)
Describe the solution you'd like

Download Microsoft.Bot.Builder.Solutions from nuget without having to add myget source
Describe alternatives you've considered
Move functionality like the background task functionality to the core Bot Framework nuget packages

It's currently under development hence on myget, plan is to have this and other packages published ready for Build next week.


/sethome causes nullpointer exception in 1.16.1

Information

Minecraft Version: 1.16.1
Fabric API Version: fabric-api-0.14.1+build.372-1.16
OS: Windows client, unknown server host OS (Server.pro)
Other installed mods:

Describe the issue
/sethome command results in NullPointerException
Crash/Error logs
If the game crashes or console errors are present, please attach the log here using a text paste service (such as gist or hastebin):
https://hastebin.com/halevijiqo.sql
To Reproduce
Steps to reproduce the behavior:
Run /sethome dragonhold (This is the name I used, but I doubt it matters)
it gives the "Unexpected error occured" and the above console message
Expected behavior
I was expecting it to return some feedback that wasn't an error message.
Additional context
If you need any just ask.

@martmists for some reason the home model handler happens to be null
kotlin.KotlinNullPointerException: null

at io.github.nyliummc.essentials.entities.EssentialsRegistry.getModelHandler(EssentialsRegistry.java:113) ~[essentials-base-0.2.0+1.16.1.jar:?]


Added rough draft of Parallel Data Loader

Tested on real data and this code now properly generates a HDF5 file using multiple threads in parallel.


SqlCe Exception: Table name not valid

Hi, there!
I've installed your EntityFramework.Extended library via NuGet package on last thursday for my needs to perform batch updates against some tables on my SqlCe database.
Unfortunately, on my very first try I got this error:
[SqlCeException (0x80004005): The table name is not valid. [ Token line number (if known) = 1,Token line offset (if known) = 16,Table name = ItensDoEstrutural ]]
System.Data.SqlServerCe.SqlCeCommand.ProcessResults(Int32 hr) +48
System.Data.SqlServerCe.SqlCeCommand.CompileQueryPlan() +700
System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options) +542
System.Data.SqlServerCe.SqlCeCommand.ExecuteNonQuery() +21
EntityFramework.Batch.d__15`1.MoveNext() +3207
The line that caused the error is the following:
db.ItensDoEstrutural.Where(it => it.Exercicio == ano & it.VersaoCod == versao).Update(i => i.VersaoCod == versao, i2 => new ItemDeEstrutural { VersaoCod = novaVersao });

Am I doing something wrong or is there any issue with this library with SqlCe?
Is there any chance that I'll be able to use your library with SqlCe databases?
Thanks for your time.
Paulo Ricardo Ferreira

I think that I'm experiencing exactly the same problem now. Anyone a soltuion? @PauloRic perhaps?


Build fails on Java 9

If using Java 9, "mvn install" fails with the following error:
A required class was missing while executing org.apache.aries.blueprint:blueprint-maven-plugin:1.5.0:blueprint-generate: javax/annotation/PostConstruct
I got around this by setting JAVA_HOME to point to JDK 1.8.

Java 9 is not yet supported. I wait a bit until the OSGi community has a common approach to java 9.


Memory mapping support

It would great if cnpy supported memory mapping of files similar to how numpy.load() does it. (This would be useful for reading small portions of very large files.)

re


Text from the scripture pane should be copied/pasted as plain text

When the user copies and pastes text from the scripture pane the text should be pasted as unformatted text. Otherwise, the text should remain formatted when it is copied.
This issue came out of a previous attempt to fix this #251 and spike #438
This is to be fixed by #424
DoD: Copying formatted or highlighted text from scripture pane won't retain highlighting or other HTML styles on paste. Pasting text copied from source in preview mode to target in preview mode will preserve formatting.

Katalon tests in tCC tN Test Copy OrigLangQuote

Confirmed issues working here:

Text from the scripture pane should be copied/pasted as plain text

@RoyalSix
@elsylambert
I still see HTML paste in v1.0.5-rc.7
not sure I understand DOD here
https://deploy-preview-488--tc-create-app.netlify.app/

Pasting with preview mode on removes formatting @ancientTexts-net
That is the behavior I am seeing in the preview

Works with yalc in tc-create-app

compare to PROD

Looks good in v1.1.0-rc.3 on Mac. Need to test in Windows.
Not seeing highlighting now in OrigQuote.
Not seeing weird formatting when doing copy/paste into OrigQuote.

Looks good in v1.1.0-rc.3 on Mac. Need to test in Windows.
Not seeing highlighting now in OrigQuote.
Not seeing weird formatting when doing copy/paste into OrigQuote.

Looks good in translationCore Create - v1.1.0-rc.3. Able to paste unformatted text from scripture pane to Original Quote box. In Preview mode, pasting preserves the formatting. Works as expected.

Looks good in translationCore Create - v1.1.0-rc.3. Able to paste unformatted text from scripture pane to Original Quote box. In Preview mode, pasting preserves the formatting. Works as expected.


Test Suite for sdf-tests

Summarize the feature in question.
Professionally test the sdf-tests jinja macros.

validate jinja render as intended (and document explicit intentions)
validate as sql queries

The sdf tool already excels at validating sql queries are correct, but I don't know how to wire it up.
What team(s) will benefit from this feature request?
Anybody who needs to test the jinja macros. Developer confidence in sdf-labs.
Is this an enhancement to an existing feature? If so, briefly describe the update.
Proposed tasks:

Add rust crate "sdf-tests" to the repository

add sdf-tests/src/unique.jinja and copy the unique macro to it. Repeat for all the macros in the sdf-tests workspace.

like this example:
https://github.com/mitsuhiko/minijinja/blob/670b67b967f273eab608ef1697e181dd5cfdc787/minijinja/tests/inputs/hello.txt

in rust-project/tests/test_templates.rs, create a test harness inspired by this file (especially test_single at line 230)
https://github.com/mitsuhiko/minijinja/blob/670b67b967f273eab608ef1697e181dd5cfdc787/minijinja/tests/test_templates.rs

build the crate

migrate test.jinja in the sdf project to 1 jinja file per macro

add a build script that exports from the txt files to jinja files in the sdf project. Are post-test scripts a thing in Cargo?

enhance the github workflow by adding a new step/s between git-clone and sdf-compile:
-- test the rust crate
-- run the build script to export the jinja to sdf-workspace.
-- sdf compile for all supported integration providers?

Describe alternatives you've considered if applicable.
Yee-haw!!
Additional context
Add any other context or screenshots about the feature request here.

@wolfram-s I messsaged this to @dbrtly in the Slack, but wanted to echo and start the thread here:

You are spot-on, this is an underinvested part of our ecosystem. We have loads of internal tests which run when the SDF Rust binary is compiled, and these run workspaces with jinja materialization as well. However, we don't have unit tests on the jinja itself. Mostly because the long term vision for materialization is certainly not to use Jinja at all :) That doesn't mean in the meantime we shouldn't introduce a jinja unit testing framework. I love your pitch on minijinja and datafusion

@dbrtly Realizing your ideas are overdue! Thnaks for bringing them to the forefront! We could maybe do this in order:
(0) Reorganizing macros/tests per file might make it easier to find/coordinate things. Was there any deeper reasoning to split them up like that?
(1)  Leveraging Minjinja's (snapshot/golden file) test framework is a great idea. We could adopt the minjinja test runner to run all those macros. Given a snowflake macro (e.g. in a macros/snowflake directory).
{% macro format_date(date_column) %}
 TO_DATE({{ date_column }}, 'YYYY-MM-DD')
{% endmacro %}

A a simple unit test (adopting the minjinja test fwk) could be:
<context>
---
{{format_date(abc)}}
---
 TO_DATE(abc, 'YYYY-MM-DD')

(3) Running all macros for all dialects is an interesting extension. Suppose we organize all macros per dialect as suggested above.
We could then generate a (dialect indepdendent) SQL statement like so (below should work for most dialects, except maybe Bigquery, but you know better:-)
SELECT
    date_string,
    {{ format_date('date_string') }} AS formatted_date
FROM (
    SELECT * FROM VALUES
    ('2023-10-01'),
    ('2023-12-25'),
    ('2024-01-01')
) AS dates_table(date_string)
---
<intended output>

We can conpile/run tests like this using run the existing sqllogictest fwk (see e.g. https://github.com/risinglightdb/sqllogictest-rs ). In fact, internally we already use sqllogictest for testing our execution semantics across platforms. But we never made our adoption of the framework public. Maybe time to reconsider:-)
Does that reflect what you had in mind?

Yes this sounds like fun.
Maybe we could start by adding a cargo project to this repo and migrating the jinja to that. I can help with this part.
And then we might be ready on the decision on the sqllogictest logic. TIL about sqllogictest.
Most of these tests seem so fundamental that they could work on any provider. Would be nice to write the test once and use a tool to migrate the code to target dialect as needed. Would scale better to a large number of providers.


Rjf/unit create by ref

this PR makes it so any units functions take references to their arguments instead of pass-by-value semantics, which should reduce a bunch of unnecessary allocations in our core floating point operations.
still, looking at the bottom of the call stack at the code in routee-compass/src/model/unit/builders.rs, i'm not convinced that we have made these operations as fast as they can be. some additional work could be done to ensure we're not allocating temp objects and perhaps bypassing a conversion to the base units too.

Didn't run a test to see, I kinda just whipped this up while on a call with tech support for the VPN problems I've been having, and assumed it would help things. 🤷


Allows h1/h2/h3/h4/h5/h6 tags to preserve their dom id

e.g.:
# h1

## h2

### [h3](/already/linky)

#### h4

##### h5

###### h6

# h1 foo bar 中文 no-ascii should be ok_-/

=>

h1

h2

h3

h4

h5

h6

h1 foo bar 中文 no-ascii should be ok_-/

Should I implementation this with syntax extensions?

OK, I try locally first.

I've structured prelimibary info in https://github.com/markdown-it/markdown-it/issues/28
Anchors are required - no question. Just don't know what to do by default, to protect users from obvious security holes.

mv to #28


[Bug Report] Enhanced Duty Start/End(Auto Leave) and Auto Queue

Describe the bug
Enhanced Duty Start/End AutoLeave triggering when entering into a new duty before time has elapsed causing a lockout
and
AutoQueue triggering when not all members have loaded in from a duty (causing Y*sAlready to fail to autocommence on duty pop)
To Reproduce
Steps to reproduce the behaviour:
--Enhanced Duty Start/End AutoLeave

Have AutoLeave, AutoQueue enabled
2, Queue into guildhest "Under The Armour" as a healer at peak.
Complete guildhest
Somebody uses the battlewarden twice in quick succession, causing the instance to end for everybody.

Enter the new instance
AutoLeave triggers, causing a 30min lockout.

--Auto Queue triggering early while in party

Have enabled AutoQueue enabled
2, Queue into guildhest "Under The Armour" as a party
Complete guildhest and leave
Autoqueue immediately puts you into a duty, and it pops instantly.
Member who is still in loading, gets duty pop while in loading screen, causing  Y*sAlready's autocommence to fail.

Expected behaviour

AutoLeave should not trigger if the current instance is different from the one that just ended.
AutoQueue should not trigger while party members are still in the loading screen.

Additional context
Both issues are caused by getting a duty pop almost immmediately after a duty ends. Perhaps both issues could be partially resolved by adding an optional delay into the config of AutoQueue.

I don't think I really understand what you mean in the first scenario. Why is someone interacting with the battlewarden?
Autoleave hooks the duty state so if that is somehow triggering falsely then there's bigger problems.

AutoLeave should not trigger if the current instance is different from the one that just ended.

There's no way to know what instance you're in, but even if you could, that behaviour would just mean you'd only ever be able to auto leave once, which if you're farming under the armour you wouldn't want that.

AutoQueue should not trigger while party members are still in the loading screen.

I unfortunately do not really have a way to check the status of party members, much less ones that could be in different zones from you. All I can (and do) check is their territory. Only thing else I could do is add a customisable delay

I don't think I really understand what you mean in the first scenario. Why is someone interacting with the battlewarden?

Ok, let me try to explain again.  The first time you interact with him, you pickup the reward for the guildhest. If you interact with him again, it ends the instance and kicks everybody in the instance out. This behaviour is the same for all guildhests afaik.
What I think is happening, is the following:

Duty Starts
Boss "Bockman" is killed, this is the trigger for the duty to be 'complete'. If you have a message set in Enhanced Duty Start/End, it will say it the second the boss dies.
AutoLeave timer begins (for example set to 20s)
NPC battlewarden becomes interactable, and is interacted with twice, causing the instance to end for everybody
Auto Queue triggers and you commence the next duty
You enter the duty
20 seconds have elapsed, causing AutoLeave to trigger
AutoLeave leaves the instance, causing a 30min lockout.

As for another possible solution, I replaced the Automaton Auto Leave with a lua script in S*methingNeedDoing. Maybe this will give you some idea of what to do, so that I could switch back to Auto Leave. The idea is that if the script detects the zoneId changing, it aborts leaving the duty.
local i = 0
while i < 15 do
    if GetZoneID() == 190 then
        i = i + 1
        yield("/wait 1")
    else
        zone_changed = true
        yield("/e Zone Change Detected!")
        return
    end
end

if GetZoneID() == 190 and zone_changed ~= true then
    yield("/pdfleave") -- From P*ndora'sBox
    yield("/e Manually Left instance: " .. instance)
elseif GetZoneID() == 190 and zone_changed == true then
    yield("/e New instance detected!")
else
    yield("/e Instance shutdown by somebody else!")
end
zone_changed = false

I unfortunately do not really have a way to check the status of party members, much less ones that could be in different zones from you. All I can (and do) check is their territory. Only thing else I could do is add a customisable delay

We were in the same zone. but one person had not fully loaded. I know that in S*methingNeedDoing you can check if you are inbetweenzones with GetCharacterCondition(), though I have no idea if this is possible to do with party members. Otherwise a delay would be nice, thank you.

Ohh... you had a delay on auto leave
I assume you're comm farming and not mentor roulette farming then

you can check if you are inbetweenzones with GetCharacterCondition(

Other players do not have Conditions. Some info about other players is checkable, but very few relative to all the conditions that you the local player have. Being in between zones isn't one of them. I can add a check for targetability but it'll require all the members of the party to be relatively close to each other

new version has the zone check for the first issue and targetability check for the second


Write out csv in addition to SHP with full-length variable names

Added as an option using bool flags: data_to_csv and data_to_dbf
https://github.com/wsp-sag/client_met_council_wrangler_utilities/blob/b06dd68bd2858b7b273e3da2504540cab60bdfef/lasso/Roadway.py#L858-L868


lists of books/schools/street names/etc

I have a repository that has organized lists of schools (public, private, and colleges), street names, and book titles that might be a useful addition to this repository - I did not see such lists in your repository already.
I collected the information from publicly available sources for the purpose of targeting "security questions" when testing a web application. The repository contains both the scraped/organized data, as well as the raw sources of information that the data was scraped from. You would probably not need the raw sources of information.
There are also other categories: cities, dates, names, pet names, and zip codes, but I believe this repository has at least some of these categories covered already.
If you would like to include any of this information in your repository, please let me know how you would like it organized. You can examine the data here.

Its a great idea!
Would love to see it added in (somehow).
Think you could do a PR?

Done, the relevant pull request is here


Add view counter

Add view counter component similar to https://leerob.io/blog/real-time-post-views

Implemented in 249e0bd1c42930bc


Translation For Persian/Farsi Language

I did a translation for language files and I will send my first PR about translations
Thanks

Thanks but we have no plans for a multilingual version of the portal atm.


Migrate @shopify/cli theme language-server to @shopify/liquid-language-server-node

All this needs to do is listen to STDIN/STDOUT for JSON messages.
The UI kit should be careful NOT to pollute STDOUT with logging as this will break code editor integration.

Still relevant.

Still active.

Still active.....


Discord invite link is expired

Use this if you need https://discord.gg/PMhRHQxtXp

updated

updated

Then close this issue ?


Build error: error: Build input file cannot be found: '/Users/kurt/GitHub/rem/rem/SettingsManager.swift'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'rem' from project 'rem')

Steps to reproduce:

Install Xcode on a Mac M1
Add GitHub account
Add Apple account and enable signing for personal team; let Xcode manage it
Fork rem repo (kurtseifried/rem)
Open project, clone git repo kurtseifried/rem
Import SQLite from https://github.com/stephencelis/SQLite.swift
Clean build folder to be on the safe side
Hit build, get error:

error: Build input file cannot be found: '/Users/kurt/GitHub/rem/rem/SettingsManager.swift'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? (in target 'rem' from project 'rem')
Am I missing something obvious here?

@kurtseifried - sorry... tried to get that settings feature in too quickly. should be fixed

Marking as fixed... let me know if it doesn't work after that.

This part works but now I'm getting a consistent SQLite error (which it wasn't doing before, weird).
swift xcode /Users/kurt/GitHub/rem/rem.xcodeproj This Copy Files build phase contains a reference to a missing file 'SQLite.framework'.

Oh I appear to have broken my code signing again. nevermind.

Do feel free to open a PR and improve my shoddy instructions! Apologies for not including any and all key steps


Extension does not work in Code - Insiders

https://github.com/tylim88/VS-Code-Folder-HIde/blob/445038af8a3821a82e258bd8b56757d8574dce4b/src/extension.ts#L45
The location of the the Code - Insiders config file is .config/Code - Insiders/User/settings.json

please try version 0.2.0

I assumed it is working, please let me know if it is not


Calling TryUpdatePositionWithAdditionalVelocity while animation in progress breaks Resting points

Hi,
I'm working on a Carrusel control using the InteractionTracker & RestingValues and i'm facing a problem using TryUpdatePositionWithAdditionalVelocity to animate the carrusel when the user is using the keyboard/mouse... basically, if i call TryUpdatePositionWithAdditionalVelocity when an animation is still runing, it braaks the restingvalues behaviour and the animation doesn't stop at any of the resting values configured...
I've recorded a small video to show the behaviouer:
https://youtu.be/em13tdfcT9s
Basically, everytime the user clicks on the next / previous button i try to set up a new position:
    private void BttnRight_Tapped(object sender, TappedRoutedEventArgs e)
    {
        e.Handled = true;
        _tracker.TryUpdatePositionWithAdditionalVelocity(new Vector3(2500f, 0f, 0f));
    }

Is this behaviour by design or is it a bug?
Should i try to animate the position to the new value using animations directly without the _tracker or try to use the _tracker.TryUpdatePositionWithAnimation() instead?
Thank you.

Hey @jmvillagra!
Thanks for reaching out with your question. In general, if you want to make sure your resting values get applied, you'll want to use TryUpdatePositionWithAdditionalVelocity(). TryUpdatePositionWithAnimation() will put InteractionTracker into a different state (custom animation) and won't use consider your resting values when considering where InteractionTracker lands.
I took a look at your video, and i'm wondering if you can help me understand with two things:

Can you put a copy of your Expressions that define both the Condition and the RestingValue?
Confirm that for both your left and right button clicks you are using TryUpdatePositionWithAdditionalVelocity??

Thanks!

Hi @patsiu
I've created a test repo with the control:
https://github.com/villagra/CarruselWinUI
It's a bit messy as i'm still testing things but all the animations configuration is here: https://github.com/villagra/CarruselWinUI/blob/master/Carrusel/Controls/Carrusel.xaml.cs

Thanks @jmvillagra!
I downloaded and have been playing with your project but haven't been able to repro the behavior you showed in the video. I followed the same order of button clicks but the motion seems to land correctly on one of the carousel images.
What build # are you seeing this issue happen on? Do you have another set of steps that repros the problem consistently?
Thanks!

Hi,
I've updated the speed in the example to 1500 and now it's easier to reproduce....  i can "easilly reproduce it" selecting one of the items on the sides, then tapping on the button to select the center item and before the animation ends tapping on the button again... it doesn't happens all the time but it's how i can repdouce it...
I'm using the "release build" 1703, 15064.483
Thank you!

I changed to use TryUpdatePositionWithAnimation instead of TryUpdatePositionWithAdditionalVelocity and it's working pretty well:
Still lots of details and animations tweaks to do, but it's starting to look great ;)
https://www.youtube.com/watch?v=mdQIRA-terQ&feature=youtu.be
Thanks

@jmvillagra looks great, thanks for sharing the video! Closing this as it appears there is a workaround, and we'll take internal action item to look into this more. Please re-open if this is still an issue.


fixed moment date parsing deprecations

Howdy partner, I fixed those moment issues and also, just for fun .. fixed up usage of resolver and load-initializer to resolve warnings ..

Awesome! Thank you for the contribution! :smile_cat:

You welcome @offirgolan .. thanks for the great work on this addon!

And do you think you can slap together a new patch version so I can more easily start using my cp-validations with the fewer warnings? :)

Hiya @offirgolan, you think you can get a path version going today? My kids are refusing to write more code for me unless they get new version of this addon without the moment warnings.  :(

Lolol yeah no problem. Just release v2.6.1


Purchase Order Lines Not in Order

Whoops. I meant to have this be the secondary sort.
On Sat, Dec 21, 2024, 3:46 PM Siouxxanne @.***> wrote:

image.png (view on web)
https://github.com/user-attachments/assets/5329b9f2-70cc-44ca-9d08-2b9207089bee
—
Reply to this email directly, view it on GitHub
https://github.com/Comics-Games-and-Things-LLC/openCGaT/issues/148, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2LKZHLS4AKHQX7PUCNGYT2GXOT7AVCNFSM6AAAAABUA7LKWGVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TIMZXGUZDGNA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Broken links due to directory renaming from apps/www/** to sites/docs/**

Change Type
Correction
Proposed Changes
Hey!
I've noticed that the directory apps/www/** was recently renamed to sites/docs/**, which has resulted in broken links across the site.
This affects the Component Source links on component pages in /docs, as well as the View Code links for examples.
For instance:

The Component Source button for the Accordion component still leads to
https://github.com/huntabyte/shadcn-svelte/tree/main/apps/www/src/lib/registry/default/ui/accordion
instead of the correct
https://github.com/huntabyte/shadcn-svelte/tree/main/sites/docs/src/lib/registry/default/ui/accordion

The Tasks example View Code link still points to
https://github.com/huntabyte/shadcn-svelte/tree/main/apps/www/src/routes/(app)/examples/tasks
instead of the correct
https://github.com/huntabyte/shadcn-svelte/tree/main/sites/docs/src/routes/(app)/examples/tasks

Hope it helps

The correct previews are now live. I believe this can be closed.


System-wide search on HAPI doesn't work, so --delete-all is broken

Does that mean we would need to search for the tag several times, once for each resource type?

Yes, and then to sort properly within resources, because some Locations depends on others. I'm working on this...


Documentation error or maven error

The github pages list the below as the way to use material3:
api("com.bumble.appyx:utils-material3:$version")
But it is listed as in maven repos
api("com.bumble.appyx:material3:$version")

Hey @brh @AleksejB thanks for flagging! I believe it was an error that we released the new artifact id to the documentation earlier than we released the latest version to Maven. In the latest 2.0.0-alpha10 it should be under the documented id now.


[stable/prometheus-operator] prevent nodePort from constantly changing

Prevent nodePort from constantly changing when using a nodePort service on AlertManager and Prometheus and not specifying a fixed port number.
Signed-off-by: Mickaël Le Baillif<EMAIL_ADDRESS>Chart maintainers:
@vsliouniaev
@bismarck
@gianrubio

Is this a new chart
No.
What this PR does / why we need it:
Avoid assigning a new nodePort number when applying the "Service" manifests for prometheus and alertmanager. This is especially noticeable when these manifests are handled with a GitOps method, such as with FluxCD, because manifests are applied on a regular basis.
Why is the nodePort number modified when applying the generated manifest ? Because when prometheus.service.type is NodePort, or the same with alertmanager.service.type, and prometheus.service.nodePort (respectively alertmanager.service.nodePort is unassigned, the generated service manifest contains a key service.spec.ports.nodePort and with an empty value.
This PR remove this key from the manifest if the port number is unassigned.
Which issue this PR fixes
No related issue found.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @bismarck @vsliouniaev @gianrubio

I believe this is a non-backwards compatible change, since removing the nodePort entry from the service will cause an error on an upgrade. Are you able to confirm this isn't the case?
/ok-to-test

I have tested that the following workflow doesn't trigger any error :

using Helm to generate this manifest (removed labels and annotations for better readability) from template:

---
apiVersion: v1
kind: Service
metadata:
  name: my-service
spec:
  ports:
    - port: 8000
      targetPort: 80
      nodePort:
      protocol: TCP
  selector:
    app: myapp

applying such a manifest in a running cluster, resulting in (random nodePort choosen) :

---
apiVersion: v1
kind: Service
metadata:
  name: my-service
spec:
  ports:
    - port: 8000
      targetPort: 80
      nodePort: 32134
      protocol: TCP
  selector:
    app: myapp

modify the generated manifest to remove the nodePort entry:

---
apiVersion: v1
kind: Service
metadata:
  name: my-service
spec:
  ports:
    - port: 8000
      targetPort: 80
      protocol: TCP
  selector:
    app: myapp

apply this new manifest:

NO ERRORS
the previously assigned nodePort stays the same (32134)

/hold
Let’s hold PRs to stable/prometheus-operator chart for a short time until https://github.com/prometheus-community/community/issues/28#issuecomment-672933972 is resolved. If you want to help with that effort, to test etc, that would be great!

🚧 This chart is now deprecated.
Further development has moved to prometheus-community/helm-charts. The chart has been renamed kube-prometheus-stack to more clearly reflect that it installs the kube-prometheus project stack, within which Prometheus Operator is only one component.
If applicable, please re-open this PR there. Thanks!


[Browser] Load button not clear

Users don't understand the difference between Load and Import. Load could be renamed "Temporary Load", something like that.

Maybe "Temporary Import" to be consistent. What is the name of the temporary database?

Temporary Import is good indeed. Concerning the tempo database name, i don't know


nodejs 18 support

Does this library or recent builds (v108) support nodejs 18? I'm using lambda function with nodejs 18 runtime and a lambda layer to deploy the chromium build.
Running into

Failed to launch the browser process! /tmp/chromium: error while loading shared libraries: libnss3.so

Downgrading the lambda runtime to v16 solves this problem.

@BrianHung my build works perfectly fine with nodejs18 runtime.


Implement subscriptions for paypal

After we released PayPal for one time donations to collectives under the Open Source Collective, we need to implement PayPal in our subscription system.
The one time donations were implemented using the v1/payments path of the PayPal API. And unfortunately that isn't really possible to store an authorization token in a vault like we could in the Braintree API. With that in mind, we might need to implement their entire subscription flow instead of using our charge_subscriptions script.
Also, here's a note about PayPal requiring credit cards for subscriptions that might make our lives a lil harder:
https://patreon.zendesk.com/hc/en-us/articles/115001917686-Why-do-I-need-to-add-a-credit-card-for-PayPal-

You mention that it's possible for people to donate via PayPal. How does this work exactly? Is there something I need to do to enable it?

Hi @mojavelinux! Right now it's available for one time payments for all collectives hosted by the Open Source Collective. If you click the link "Or make a one time donation" underneath all the subscription tiers, you'll be directed to the /donate page of the collective. In that page, you need to choose "Paypal" under "Payment Methods" and then the paypal button will show up.

Thank you! That worked!

We still need this. It's a regularly requested feature when we ask for user feedback.

Hi! It's not clear to me how much work this would be, but the Dokku collective would be willing to sponsor/co-sponsor a bounty for this issue. Feel free to reach out to me via email/slack (I'll re-add the OC slack tomorrow).

People still request this constantly. Would it be possible to at least scope it out so we can see how big a job it would be? @kewitz do you know how recurring payments work on paypal?

I was looking to do this today :+1:  My card declined as it expired and I feel safer with PayPal. :)

It's so time to get this going. We need this feature!!!

@TLWebdesign This is actually coming very soon, initial specifications are planned for this week and implementation should follow. If everything goes as expected, you can expect a release in less than a month.

Wow thats wonderful news :D THanks!

@TLWebdesign My initial estimation of 1 month was too optimistic, I'm sorry for sharing this misleading date.
Our constraints (more especially, the fact that we need to support multiple fiscal hosts in different countries and with different accesses to PayPal's APIs) are making this more complex than expected and we are still researching and experimenting to make sure we implement this in the best way possible.
To everyone following this issue, I can however ensure that the project is now officially kickstarted and will be a priority for the upcoming weeks. I will share updates along the way to keep you up to date with our progress.

Project update: https://github.com/opencollective/opencollective/issues/3986#issuecomment-809282461
TLDR ; project was delayed because the initially chosen approach (Braintree) ended up being too complex for hosts to setup live, but we now have a working MVP relying on PayPal's Subscription API ready to be pushed to the next step. There are still some important paths to update (like the one to edit/cancel your recurring contribution) but the public release is getting closer!

We're currently doing some final tests internally, the feature should be released publicly next week. There's nothing to do on the host side if they already have a PayPal account connected, they will be migrated automatically.

The feature is now released and enabled for all hosts with a PayPal account. See https://github.com/opencollective/opencollective/issues/3986#issuecomment-828308074 for a full project update.

What are the ways to see this?
Clearly, in our OC instance, we cannot collect with PayPal, The only offered tools are bank account and stripe.
Both are very destructive - bank account is something no one will use to make a small donation, and stripe is extremely selective, if not even discriminating. The Stripe system will only accept you as a citizen of certain countries and only if you have a company UID or a TAX ID in one of those countries.
To be precise, stripe is available in 47 countries out of ca. 200 (https://stripe.com/global).
Paypal is available in 200 countries and regions, see https://www.paypal.com/vn/webapps/mpp/country-worldwide
It is of crucial importance to anyone outside the "privilege zone" to have access to Paypal as a donation option. As this ticket states it was implemented, do we miss something in our OC instance, as we do not see it as an option?
Thanks.

@smileBeda we can usually turn on Paypal for any Host that requests it. Which Host are you with? @Betree can you turn it on for them?

Hi @alanna - thanks for your prompt feedback
Indeed I already communicated with support, and they did enable PayPal... for payouts! That is not what is meant to be implemented by this very GitHub task, as far I understand. Please correct me if I am wrong!
There is little point in having PayPal payouts if all you can do is receive donations with a Bank Account 😓
That only starts making sense once you can receive donations with PayPal too
I also scanned the documentation, which is lacking PayPal in the section of "receive money", but mentions it in the "organisation settings", however doesn't mention it to be a donation possibility
Thus... I am (and others too) very confused as of how we can activate PayPal to receive donations. As said, Stripe is a very selective, dare I say almost discriminating-by-origin tool. Only 43 countries have access to it, and only if they are basically companies.
Thank you for understanding, and perhaps making it more clear on the documentations (or even the admin dashboards) about what a community can do in order to activate this!

Hi @smileBeda, sorry that was a mistake from our support. PayPal should now be enabled correctly on your account, you can follow this documentation for the next steps: https://docs.opencollective.com/help/fiscal-hosts/fiscal-host-settings/connected-accounts#receiving-contributions-through-paypal.
Let's continue in the email thread if you need assistance or have any other questions.


Adapt to GraalVM deprecation of @AutomaticFeature

Previously, GraalVM Feature classes could be picked up automatically by annotating them with @AutomaticFeature. We had taken advantage of this.
Since @AutomaticFeature is now deprecated, GraalVM Feature classes should now be explicitly specified on the native-image command line via the --features option.
For existing users upgrading to graal-build-time v1, this means adding --features=clj_easy.graal_build_time.InitClojureClasses to their native-image command lines.
Changes:

Renamed our package-less InitAtBuildTimeFeature class to clj_easy.graal_build_time.InitClojureClasses.
Moved clj-easy.graal-build-time ns to clj-easy.graal-build-time.packages to deal with package/class name collision.
Asked javac to fail on lint warnings when compiling our java sources. This should strongly alert us to any future deprecations.
Bumped major version to 1

Also snuck in:

README clarifications/elaborations
Refined single segment namespace warning message

Closes #25

Before I squash and merge, do you wanna have a peek @borkdude?

OK, I'll peek tomorrow!

I just did a sanity test by locally updating rewrite-clj native-image tests.
:+1: Works as advertised.


[gtest] Remove -Werror

Describe the pull request

What does your PR fix?
Warnings should not be errors.

Which triplets are supported/not supported? Have you updated the CI baseline?
Yes

Does your PR follow the maintainer guide?

Yes

This change came from the upstream https://github.com/google/googletest/commit/f7902802f1a61140e188223fb6d1c95925cbec4a.

Thanks!


Use boost::asio::io_service::stop

The legacy_manager does not shut down correctly. Killing the process with SIGINT leaves zombie processes. Using boost::asio::io_service::stop might solve this.

Might be solved by 3f0c4bd8f66818c66e3597b8ae1a643daa754a0a (can't reproduce with multiple attempts).


Electron Release Server - support release names with channels

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
I am using electron-release-server to host my application, and the integration with electron-forge has been great so far. One thing I would like to do is be able to release on the staging channel (in ERS) with merges into my develop branch and release to the stable channel with merges to master. I got it working in appveyor, except that I can't specify the name of a release from electron-forge (because it is currently coded to packageJSON.version. I would like to either be able to pass in a name config, in which case I can construct it myself, or append the channel to packageJSON.version kind of like
const { version } = packageJSON;
if (!version.includes(channel)) {
  name: `${packageJSON.version}${channel === 'stable' ? '' :`-${channel}`}}`
}

I would be happy to submit a PR if you would be willing to accept it.

A couple of things:

I'm not sure how this is specific to Electron Release Server?
You should be able to do this yourself in forge.config.js, by setting packagerConfig.name programmatically.

https://js.electronforge.io/publisher/electron-release-server/interfaces/publisherersconfig#channel
You can configure the channel directly in the ERS publisher config

This is the name on Electron Release Server, not the actual name of the file. On electron release server this is usually the version e.g. 1.0.0, but they recommend for channels to add the channel e.g. 1.0.0-alpha. Names must be unique on ERS, so if I push 1.0.0 to the staging channel, I can't push 1.0.0 to the stable channel

Seems to me like you would just adjust the version to be something that's not 1.0.0, like 1.0.0-rc.1, since you need to publish a different name anyway.

Our workflow is develop on feature branch, merge to develop, deploy to staging, verify fixes on staging, merge to master for a release. Everything is handled via appveyor uploading to ERS.
Perhaps this isn't what the channels were meant for, but for us it's a nice way to get an app build that we can easily install and test. So in this case we don't care about the published installer name having rc.1 for instance, because the channel is internal.

@MarshallOfSound what do you think about adding another configuration option to the ERS publisher?


[chore] Refactor so FactStore handles returning default value instead of Engine

Topic has a defualt value field, so it makes sense for us to handle it at the DB level ...
Or does it? It is different if a user explicitly writes "use default" vs if the user writes "save this value who just happens to be the same as the default value" ... Okay...

Need to investigate if such a change is a good idea/the implications of such a change

I don't think it is good to make this change. There is indeed a difference between "this assistant is by default public" and "I want to change this assistant to always play public audio" ... when the assistant's programatic default changes to private, scenario 1 should change to private but scenario 2 should remain as public.
I think I made this revelation some time ago as well, but not sure where it is documented? Oh well. Closing issue as won't fix


Significant refactor

Change log:

Updated to 2022.3.24f1
Switched to URP
Addressables packaged added for async asset loading. Remember to build Addressables (Windows->Asset Managment->Addressables->Groups->Build button) before builing an EXE.

//TODO: will write more details here, soon
Some words of advice:

Prefer [SerializeField] over public for field declarations. Use private as a default.
Concentrate related data into state objects. Don't use static fields to host player basic player/enemy values in random places (like ui componenets). This is lazy programming that for 5 minutes of programming less buys you hours of debuging horrors later on.
Changing tags on a single gameobject based on some game logic means you made tags into an implicit State Machine. Try replacing it with an explicit one - it will be much easier to maintain and debug
Aim for a codebase where entire UI layer visualizes game state changes and listens for player input. Hiding core game logic among UI components will make your game/life much more complicated that it needs to be
PlayerPrefs are not meant to be used every frame. Store game settings there (current player, highscore, quality, screen settings) not game state.
Be careful where you put the game logic and it's states. Is spreading gameplay logic and states among gameobject tags, countless and duplicating bool fields and TriggerEvent calls a really good idea? Wouldn't it be much more transparent and easy to understand/change/fix if you could read it all in a singular format (code for example) instead?
Putting 90% of game logic code in Update as >100 LOC of ifs statements renders your code completely mentally impenetrable, very brittle and irreplaceable (99% resistant to refactor). Embrace events, FSM and command buffer patterns instead.

Ok, I think that will be enough commits from me. Most things should work again and things that I broke should be easier to fix now with this improved structure.

You're welcome :)


image_import: debian: install sdk with apt

sdk post script is working again, use apt to install it instead of
skiping the post install script with dpkg

/ok-to-test


Kafka source occasionally gets stuck

Describe the bug
Occasionally a Kafka source gets stuck in a state that the vreplicas do not get scaled down. And the kafka source swings between setting up handler and clean up handler
Expected behavior
Allow kafka source to move on
To Reproduce
It happens occasionally and randomly
Knative release version
Additional context
Add any other context about the problem here such as proposed priority

This is a serious issue. I still have a Kafka source in stuck state since last night with 150Million messages and it's been 9 hours and only less than 10000 messages were consumed. Kafka source seems to be stuck inside Sarama library.

I have done similar tests (not 150 million messages) and haven't seen this problem.
It is either a new one, or it is an edge case. Which version are you using @steven0711dong ? Any other hints to reproduce this?

continue to monitor. So far I do not see stuck problem ever since the stuck fix was merged. Keep this issue open for a while until we don't see stuck issue for a while.

hi @steven0711dong we seems encountered a similar problem, can you help support which PR fixed this problem

The latest PR related to this issue is this one: https://github.com/knative-sandbox/eventing-kafka/pull/649
@runzexia Let's know if this fixes your stuck issue.


Join battle request

Codecov Report

Merging #73 (bb93bcc) into master (8450880) will decrease coverage by 0.02%.
The diff coverage is 43.18%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   31.76%   31.74%   -0.03%
==========================================
  Files          62       62
  Lines       12118    12180      +62
  Branches      197      197
==========================================
+ Hits         3849     3866      +17
- Misses       8072     8117      +45
  Partials      197      197

Impacted Files
Coverage Δ

src/clj/skylobby/fx/players_table.clj
4.33% <ø> (ø)

src/clj/skylobby/fx/welcome.clj
65.71% <ø> (ø)

src/clj/skylobby/fx/mod_sync.clj
3.26% <3.92%> (+1.05%)
:arrow_up:

src/clj/spring_lobby/http.clj
23.91% <13.79%> (-0.87%)
:arrow_down:

src/clj/spring_lobby/client/handler.clj
33.41% <20.00%> (-0.16%)
:arrow_down:

src/clj/spring_lobby.clj
12.37% <25.00%> (-0.71%)
:arrow_down:

src/clj/skylobby/fx/channel.clj
21.58% <50.00%> (+1.14%)
:arrow_up:

src/clj/skylobby/fx/battle.clj
63.65% <77.27%> (-0.14%)
:arrow_down:

src/clj/skylobby/resource.clj
62.16% <84.61%> (+2.16%)
:arrow_up:

src/clj/skylobby/fx/download.clj
52.60% <100.00%> (+0.22%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8450880...bb93bcc. Read the comment docs.


--write-index not a valid command

In the filter.sh script, there is a step that calls for samtools sort --write-index. However, for newer versions of samtools sort, --write-index is not a valid option and the samtools manual says to use samtools index to create an index. I just removed the --write-index options in the filter.sh script and added a samtools index step right after that. It ran successfully after that.
I'm creating an issue regarding this in case anyone else runs into the same problem as me. Maybe the filter.sh script can be changed to reflect this. If not, it is a simple enough fix on the users end.
Thanks for the great pipeline. Much appreciated.

Hi RogueRussell , and thank you for your report on MitoHPC.
I've just installed and tested the latest version of samtools (1.17)
It looks like "samtools sort --write-index" is still a valid option, though for some reason is not documented in the official online manual : http://www.htslib.org/doc/samtools-sort.html
##################################################################################################
$ samtools  --version | head -1
samtools 1.17
$ samtools sort
Options:
...
--write-index
Automatically index the output files [off]
$ samtools index
Options:
-b	   Generate BAI-format index for BAM files [default]
-c	   Generate CSI-format index for BAM files
...
##################################################################################################
"samtoosl sort --write-index" only generates CSI-format indexes, so, as you said, it is better to run "samtools index" afterwards.
I will implement the change in the next release.

You are absolutely correct. The new samtools does have that option. I did a little digging and realized I have an older version of samtools (1.9) which did not have the --write-index option. I assumed that since 1.9 is higher than 1.17, that it was a newer version - but apparently they changed the numbering after version 1.9, and 1.9 is actually relatively outdated (2018). You're right, it isn't in the manual, but they did add in --write-index after 1.9. My apologies! So this is still a good lesson for anyone running this on an older version of bedtools and runs into this issue. Thanks again!


Possible conflict in definitions for uncheckable property

This page has the following definition for uncheckable:
uncheckable - auto	-  Setting to true/false will determine whether an input will allow no selection. Auto will set disallow this behavior only for radio boxes

This page has the following seemingly conflicting explanation:
One-Way Choices
To make a user able to check a box, but unable to uncheck it, use the uncheckable setting.
These seem like conflicting definitions for uncheckable.  Perhaps more explanation in the docs would clarify this?

Moving this issue to Semantic-UI-Docs

Moving this issue to Semantic-UI-Docs


[v1alpha2] Add Create/GetRecord.

Implements CreateRecord and GetRecord v1alpha2 RPC methods
Enforces foreign key constraints for local sqlite3 testing.
Updates v1alpha1 to also write Results due to foreign key constraints
(since we are getting rid of this soon, this was not done in a
transactionally safe way).

Fixes #6, #7

/lgtm


feat: Upgrade Cosmos Kit

What is the purpose of the change
Upgrade cosmos-kit to enable Wallet iframe pass-through wallets.
Brief Changelog

Upgrade cosmos-kit and wallets
Upgrade chain registry

Testing and Verification
We should test all available wallets

[ ] Allows connecting to wallets and persists sessions
[ ] Allows sending transactions
[ ] Allows signing for notifications

Hey, you can test whether or not this is working at this link:
https://dapp-mainnet-git-noah-fullscreen-browser-da0da0.vercel.app/dao/osmo1xxf82kcpjkmsua9r5hvh6nwmg5s0pmp2u77xnczc6yqy8uztp4xspcn6t6/apps?url=https%3A%2F%2Fosmosis-frontend-git-jose-upgrade-cosmos-kit-osmo-labs.vercel.app%2F
This is our preview branch using your preview branch URL 😁 it seems to be causing some client-side error still.

@NoahSaso Thank you! This will make it much easier to debug.

@NoahSaso Thank you! This will make it much easier to debug.

No problem :) stoked you are on top of this so quickly 🤝
Also, you should be able to use http://localhost:3000 in that URL field for real time development.

It appears that there have been breaking changes from Cosmos-Kit, making this more than the simple bump I anticipated. Due to urgent development tasks, I must delay addressing this until I have more availability. However, if you have the capacity, I'm certainly willing to assist you in completing this task.

It appears that there have been breaking changes from Cosmos-Kit, making this more than the simple bump I anticipated. Due to urgent development tasks, I must delay addressing this until I have more availability. However, if you have the capacity, I'm certainly willing to assist you in completing this task.

Gotchu.

It appears that there have been breaking changes from Cosmos-Kit, making this more than the simple bump I anticipated. Due to urgent development tasks, I must delay addressing this until I have more availability. However, if you have the capacity, I'm certainly willing to assist you in completing this task.

Can you point me to the breaking changes? It seems to build fine.

@JoseRFelix the iframe wallet seems to work after this fix: #2552


webpack removes files specified in package.json sideEffects

Bug report

What is the current behavior?
Files specified in package.json sideEffects is removed
If the current behavior is a bug, please provide the steps to reproduce.
Minimum reproduction: https://stackblitz.com/edit/node-thpmrj?file=dist%2Fwebpack.js
Note that src/lib/package.json has sideEffects: ["./injectDevTools.js"], but injectDevTools.js does not show up in final result dist/webpack.js
Interesting findings while debugging:
I added console logging in SideEffectsFlagPlugin.js, it returns true when checking 'injectDevTools.js' against the sideEffects flag

What is the expected behavior?
Files specified in sideEffects should be kept.
In the above example, injectDevTools.js should be included in final result dist/webpack.js

Other relevant information:
webpack version:  5.70.0
Node.js version: 16.14.2
Operating System:
Additional tools:

webpack does not track transitive sideEffects ( in your case it technically should be since index.js depends on injectDevTools.js), so you should mark all files by yourself.
In other words sideEffects flag does not have transitive state, so in your case index.js is side effects free.

Thanks for the answer, it worked when I have both index.js and injectDevTools.js in the sideEffects array

@vankop I have a similar issue in an Angular app (See SO question for more details).
My index.ts imports 2 modules (abstract-control.ts and abstract-control.directive.ts) for side effects, and exports another module (custom-control-status.directive.ts) therefore also acting as a barrel file. custom-control-status.directive.ts is imported through the barrel file (index.ts), therefore I thought index.ts and the 2 modules imported for side effects would be included in the bundle, but they're removed in the tree shaking process. Despite specifying index.ts, abstract-control.ts and abstract-control.directive.ts in my package.json's "sideEffects", they are all excluded from the bundle.
How do I get abstract-control.ts and abstract-control.directive.ts to be included in the bundle? What am I doing wrong?

@amitbeck please create a small reproducible repo I will take a look

please create a small reproducible repo

@vankop Here you go: https://github.com/amitbeck/ng-webpack-sideEffects-repro
You should get the following error: TypeError: this.formGroup.controls.text.setWarnings is not a function. That means that the files abstract-control.ts, abstract-control.directive.ts and index.ts in src/app/utils/forms/ were not included in the bundle.
Thanks in advance!


[Azure Bot Service] Moving Bot Service from one Resource Group to another result in error message in Azure portal

System Information
This bot is only accessed/used in Azure Portal as well as in https://qnamaker.ai/
Bot Info

Bot name: OSMvab
Bot handle: OSMvab
App ID: b8f171f4-488f-41bb-8be2-eb38916562d5
Connected channels: Currently connected to Skype. But this error happens in Azure Portal.

Issue Description
When selecting the OSMvab bot service in Azure portal, I get an error message while the service loads: "The Resource 'Microsoft.Web/sites/OSMvab' under resource group 'OSMbots' was not found." The same error message is repeated three times before the code page shows. Besides this, everything seems ok. OSMvab is running ok in Skype, we can adjust in qnamaker, etc. I do not get the same error message on dev.botframework.com.
I assume this is related to me adding an OSMbots resource group at first, but moving it to OSM-Developers-Manila later. I did the move by using functioanlity availble in the Azure portal, but there seems to be one operation that either failed, or wasn't executed properly.
Code Example
n/a
Steps to Reproduce the Issue
Steps to reproduce for me is to click on the bot on the dashboard and wait for it to load.
Expected Behavior
Page loads with no error message
Actual Results

Can you try deleting and recreating the bot in Azure?

What happens then with the Q and A stuff we have already added?

@ivarsonstabo QnA Maker is not part of your bot. Any changes to the bot won't affect the QnA Maker instance.

I can try and delete it; since the problem occurred on the move-operation I assume the problem will be resolved. But isn't that just taking care of a symptom and not the root cause which should be some part of the move-ops.?

@ivarsonstabo did you get this working?

I created a new bot and linked everything. Tried to access the old one afterwards in the portal, and got this error:

Clicking OK results in an endless "initializing" process.

For your original issue, I have an explanation.  Bot Framework stores the resource group id as part of an identifier, so when you switched to a new resource group the identifier changed in azure, but not in Bot Framework.  So the behavior you saw was expected.  Not saying it's ideal, but that is just the way it is at least for now.
If you still have the old resource group and have not deleted it, in theory, you could move the bot back to that resource group and it should fix the problem.  This does not mean make a new resource group with the old name, I'm talking about using the actual old resource group from before you moved the bot.  If you deleted it this will not be possible.
For the new issue, since you recreated your bot is the new bot working? Do you still need the old one for anything?  If not I suggest you just get rid of it and not look back 👍.  However, if you still need the old bot for some reason we can look into this further for you to try to get it resolved.

Jason, I will go ahead and delete it in botframework.com.

@ivarsonstabo Good luck!


how to update marker color with outout clearLayers?

I have some popup on the marker. I want to highlight the current clicked marker without clearLayers (since it would stop the popup event). Here is my code to create clusters
function createClusters(data){
    $.each(data, function(){
        var popUp = L.popup(popupOptions)
            .setContent(
                '
'

                + 'No text'

                + 'No text'

                + 'No text'
                +'
'
            );
        // console.log('feature', this);
        featureLayer = L.mapbox.featureLayer(this, featureLayerOptions);
        if (this.properties['name'] == $.cookie('city')) {
            currentMarker = featureLayer;
        }
        // popUp = this.properties['name'] + popUp;
        featureLayer.bindPopup(popUp);
        markers.addLayer(featureLayer);
    });
    map.addLayer(markers);
}

What should I do?!

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com/questions/tagged/leaflet or stackoverflow.
Having said that: http://leafletjs.com/reference.html#marker-seticon


"Transform: Unique Lines" duplicates row following the selection

I select multiple lines leaving the cursor on the next line which is not part of the selection.
Then I run "Transform: Unique Lines" and the line on which the cursor was becomes duplicated.
It happens every time I launch the action.

The operation works on all lines of the selection.  In this case, the selection extends to the next line, but it does not include the contents of that line.
So, the line gets included because it is part of the selection, then when the replace is done it is replacing the selection and not the lines of the selection.  So we get a duplicate.
Will include a fix with next update.

So after actually trying to change this behavior, I've decided against it.
The reason is that it would just create another edge case where I can not know for sure if the beginning or ending line was not intended to be included if they are empty.
This is somewhat just a subtle nuance of how vscode behaves in that it is actually vscode that is not showing you what you have selected.  If you select multiple blank lines, vscode shows you those in the selection, but does not include the last line or beginning depending on the direction.  This is somewhat a visual error from vscodes representation of the selection.
If I were to make changes here, I think it may introduce some odd behaviors in other scenarios.
For now, just be aware that when creating a selection, it will include the lines where the cursor starts and cursor ends regardless if they are blank and the selection is highlighted by vscode.


Quake mode visible in Alt+Tab

Windows Terminal version (or Windows build number)
1.10.1933.0
Other Software
No response
Steps to reproduce

Open Quake window.
Alt+Tab.
Quake window is visible among other windows.

Expected Behavior
Accoring to this: https://docs.microsoft.com/en-us/windows/terminal/tips-and-tricks#quake-mode
Quake mode: "The window will be hidden from the taskbar and from Alt+Tab."
Actual Behavior
Quake window is visible among other windows.
Same on Win10 and Win11.

Sorry, that should more correctly read

"When minimized, the window will be hidden from the taskbar and from Alt+Tab."

When the window is open, it's definitely still going to appear in alt+tab - not sure there's any way to disable that behavior.

#10197 may also be related

Closed in https://github.com/MicrosoftDocs/terminal/pull/454

When the window is open, it's definitely still going to appear in alt+tab - not sure there's any way to disable that behavior.

I'm using  WinSet, ExStyle, % +0x80 in AHK to achieve that and it seems to not have any side effects


fix(dashboard): domain validation for ecosystem partner domains

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

PR-Codex overview
The focus of this PR is to update the regex pattern for domain validation and fix styling issues in the AddPartnerForm component.
Detailed summary

Updated domain regex pattern for validation
Fixed styling issues in error message display for domains, bundleIds, and permissions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#3701  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on  Graphite


Documentation builds are failing

https://readthedocs.org/projects/duqtools/builds/18215223/

Closed by: 3fe98f3


Gunicorn GPFs in production syslog

In the docker-compose host /var/log/messages, I'm seeing a lot of gunicorn general protection faults. Example below.
These seem to be happening somewhat regularly and I haven't observed them causing any issues for users, but I don't believe we should be seeing this kind of a crash.
Possibly some error in the gunicorn setup? Might also be related to the sodar-docker-compose repo, if so I'll move the issue.
Nov 17 12:27:08 sodar kernel: traps: gunicorn[1191000] general protection fault ip:7ff8cb39674c sp:7fff5ca33060 error:0 in libpython3.8.so.1.0[7ff8cb26d000+1e9000]
Nov 17 12:27:09 sodar systemd[1]: Started Process Core Dump (PID 1193279/UID 0).
Nov 17 12:27:10 sodar systemd-coredump[1193281]: Process 1191000 (gunicorn) of user 0 dumped core.#012#012Stack trace of thread 4773:#012#0  0x00007ff8cb39674c n/a (/usr/local/lib/libpython3.8.so.1.0)
Nov 17 12:27:10 sodar systemd[1]<EMAIL_ADDRESS>Succeeded.

This isn't apparently happening with e.g. Varfish. One difference in the SODAR setup is that we use --worker-class gevent, which was previously required for the separate SODAR Taskflow microservice. Sure enough, searching for gevent together with GPFs returns a bunch of results.
Gevent should not be required anymore, now that SODAR does not receive API callbacks from SODAR Taskflow. I'll try to switch to the default working class in staging and see if this still happens.

I've updated the docker entrypoint to the default worker and tested this in staging. Everything seems to be working ok and I see no weird crashes in the host log. I will deploy this in production later this week and observe the results.

I have observed zero such crashes in the last 24h+, considering this closed.


fix comic title validations

Modified files :
checkpoints/comic_title_validations.yml
expectations/comic_title_validations.json
I am using this as RuntimeDataconnector and runtime_parameter to filter out the articles for newsletter_id is null
And  updated the .json row_condition to category_id=1
To test the suite:
Run: great_expectations checkpoint run comic_title_validations
https://github.com/qxf2/newsletter_automation/issues/146

Good to merge


feat(performance): Enable prefetching on enter for logged in

The type of this PR is: Feat
Description
We've let prefetch-on-enter run for a bit for logged out and things are looking good! So lets enable it for logged-in users as well.
cc @artsy/diamond-devs

closing this because we merged the review app!


CVE-2019-15052 and CVE-2019-16370 fix with gradle update

The PGP signing plugin in Gradle before 6.0 relies on the SHA-1 algorithm, which might allow an attacker to replace an artifact with a different one that has the same SHA-1 message digest, a related issue to CVE-2005-4900.
The HTTP client in Gradle before 5.6 sends authentication credentials originally destined for the configured host. If that host returns a 30x redirect, Gradle also sends those credentials to all subsequent hosts that the request redirects to. This is similar to CVE-2018-1000007.

Build fail is unrelated


[FEATURE] Custom Column Types in TableFormField

Describe the solution you'd like
Allow specifying different cell editors on columns of TableFormField.
Is your feature request related to a problem? Please describe.
Not really
Describe alternatives you've considered
None
Additional context
N/A
Changes TODO

[x] Allow specifying a cell editor for a single column using a FormField or just a component
[x] Allow specifying multiple cell editors for the table overall using a Form (match form field names to table column names)
[ ] Create SimpleCustomCellEditor to allow for more flexibility for cell editors of different types (might be more complex than "simple", but need something since only a few types are really supported by default Java)

Moved over to Tadukooverse/TadukooForm#11


Update ic_cdk crate dependency to > 0.5.2

We need a new version of the IC CDK to be able to implement some features such as #462. At time of writing the latest version of that crate is 0.5.2 but we should update to the latest version when we get to this card.

Implemented with #462.


Binding pojo field named "timeout" causes exception when generating schema

When upgrading from 2.0.10 to 2.1-rc4 I discoverer that when I try to generate schema for a pojo with a field named timeout I get a nasty exception. I am still in development phase, so I can rename my field with minimal effort, but this may be a serous issue for someone in production. I am running OrientDB as an embedded server in distributed mode.
I am opening or creating my database with the following code and updating the schema to my pojos.
try(OObjectDatabaseTx db = new OObjectDatabaseTx (localProperties.get(LocalProperty.DB_URL))){
    ...
	db.getMetadata().getSchema().generateSchema(MState.class);
    ...
	db.commit();
}

Here is my pojo
public class MState implements MRecord{
	@Id
	private Object id;
	@Version
	protected Object version;
	...
	private long timeout;
	...
	public long getTimeout() {
		return timeout;
	}
	public void setTimeout(long timeout) {
		this.timeout = timeout;
	}
	...
}

Running the code "db.getMetadata().getSchema().generateSchema(MState.class);" produces the following exception when trying to create the timeout field.
com.orientechnologies.orient.core.sql.parser.ParseException: Encountered "" at line 1, column 37.
Was expecting one of:

	at com.orientechnologies.orient.core.sql.parser.OrientSql.generateParseException(OrientSql.java:12285)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.jj_consume_token(OrientSql.java:12158)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.NotBlock(OrientSql.java:4949)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.AndBlock(OrientSql.java:4845)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.OrBlock(OrientSql.java:4795)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.WhereClause(OrientSql.java:4760)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.SelectStatement(OrientSql.java:659)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.Statement(OrientSql.java:415)
	at com.orientechnologies.orient.core.sql.parser.OrientSql.parse(OrientSql.java:87)
	at com.orientechnologies.orient.core.sql.OCommandExecutorSQLAbstract.preParse(OCommandExecutorSQLAbstract.java:227)
	at com.orientechnologies.orient.core.sql.OCommandExecutorSQLSelect.parse(OCommandExecutorSQLSelect.java:209)
	at com.orientechnologies.orient.core.sql.OCommandExecutorSQLSelect.parse(OCommandExecutorSQLSelect.java:89)
	at com.orientechnologies.orient.core.sql.OCommandExecutorSQLDelegate.parse(OCommandExecutorSQLDelegate.java:76)
	at com.orientechnologies.orient.core.sql.OCommandExecutorSQLDelegate.parse(OCommandExecutorSQLDelegate.java:42)
	at com.orientechnologies.orient.server.distributed.ODistributedStorage.command(ODistributedStorage.java:234)
	at com.orientechnologies.orient.core.command.OCommandRequestTextAbstract.execute(OCommandRequestTextAbstract.java:63)
	at com.orientechnologies.orient.core.metadata.schema.OClassImpl.checkPersistentPropertyType(OClassImpl.java:1905)
	at com.orientechnologies.orient.core.metadata.schema.OClassImpl.addPropertyInternal(OClassImpl.java:1600)
	at com.orientechnologies.orient.core.metadata.schema.OClassImpl.addProperty(OClassImpl.java:2292)
	at com.orientechnologies.orient.core.metadata.schema.OClassImpl.createProperty(OClassImpl.java:773)
	at com.orientechnologies.orient.object.metadata.schema.OSchemaProxyObject.generateSchema(OSchemaProxyObject.java:361)
	at com.orientechnologies.orient.object.metadata.schema.OSchemaProxyObject.generateSchema(OSchemaProxyObject.java:271)
...

Hi @zig158
TIMEOUT was declared as a reserved word in the new parser because it could drive to ambiguous statements in some cases. I'm checking if I can allow it in some circumstances, but I cannot ensure this to be fixed.

I suspected that this may be the case.  The current message is not all that helpful.

I added a better error message.
Sorry, at this stage this cannot be supported. In next releases we will introduce full support to quoted property and class names (backtick quoting) that will allow any string as a property name


GDScript 2.0: In a inheritance + @onready the variable is created, but it is not initialized

Godot version
v4.0.dev.calinou.795cd2eb3
System information
Windows 10
Issue description
In an inheritance, the @onready creates the variable, but it is not initialized. This doesn't happen, for example, with the export annotation or creating variables with no annotations.
Steps to reproduce
Just create a script using the class_name for the Parent, create a variable using the @onready, initialize it with some data and try to use this Parent variable in a extended Child.
Minimal reproduction project
inheritance_annotation_bug.zip

Duplicate of #52223
Your child has @onready variable, which is treated like _ready() and prevents parent from initializing. You'd need to add
func _ready():
    super._ready()

to your child.


Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Function
Expected behavior
npm exec -- shopify app function build should build successfully. Was working earlier, suddenly stopped working.
Actual behavior
Error coming from `npm exec -- javy compile -d -o extensions/product-discount/dist/function.wasm dist/function.js`

Reproduction steps

npm exec -- shopify app function build in a typescript function directory

Operating System
macOS Ventura
Shopify CLI version (check your project's package.json if you're not sure)
3.48.2
Shell
iterm2
Node version (run node -v if you're not sure)
v19.0.0
What language and version are you using in your application?
Typescript

+1 - I thought this was an issue within the shopify function runner (https://github.com/Shopify/function-runner/issues/181). I also had no issues several hours ago but suddenly stopped working. Upgrading to 3.48.3 also made no difference.

npm exec -- shopify app function build works okay on my end but running cat input.json | npm run shopify app function run no longer works since yesterday evening


Incorrect mount point

The instance keeps crashing. Here's the log:
22-04-26T03:57:09.859446558Z + '[' -d /var/www/mediawiki/w/extensions ']'
2022-04-26T03:57:09.859549480Z + echo 'WARNING! /var/www/mediawiki/w/extensions is an incorrect mount point, please re-mount to /var/www/mediawiki/w/user-extensions'
2022-04-26T03:57:09.859560579Z + exit 1
2022-04-26T03:57:09.859579083Z WARNING! /var/www/mediawiki/w/extensions is an incorrect mount point, please re-mount to /var/www/mediawiki/w/user-extensions
I also noticed that the canasta image pulled is always latest. Shouldn't it be a specific version at least for a particular Canasta-DockerCompose release?

The relevant line to be fixed is https://github.com/CanastaWiki/Canasta/blob/cedce118826e3ebeb1d667b36d28c35a825005da/_sources/scripts/run-apache.sh#L134


Added support for default-value on item insert

I've added support for default field values when inserting new items, for text/number and select fields.
This is different from e.g. the select field's selectedIndex in that it only takes effect when inserting new items, whereas selectedIndex also applies to filtering (defaultValue has precedence over selectedIndex).
It would be nice implementing this as a general feature in core, instead of per-fieldtype, but given the documentation of insertTemplate I get the impression it's allowed to return arbitrarily complex element, not necessarily an input element you can directly set a value for.

Thank you for the PR.
I agree, that it perfectly makes sense to put it on the fields level.

I am not very good at js but I wonder what if defaultValue is set as 0 (zero) or false, is it handled correctly?


feat: Support search for params common to all resources.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #481
Description
Clear and concise code change description.
add profile , tag , security to indexing code.
Also add relevant tests.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
NA
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@jingtang10 I can't add security and tag to the search since search for tokens haven't been implemented yet. Should I add the rest or should can I handle that in another pr and change the issue and pr title accordingly?

why is language added when it's not specified in the standard as a search parameter?
in general - i'm not so certain how these fields are used. would like to see some real examples from implementers. @fredhersch

I only across it in the IAnyResource class. It's marked as a search parameter. I tested it on HAPI and it supported language so I added it. I can remove it if it's not required. As for the rest, I honestly don't see a use case either I only added them because that's what the standard specifies. I'll try to come up with a few use cases.

Codecov Report

Merging #488 (2816946) into master (edc6810) will decrease coverage by 0.79%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #488      +/-   ##
============================================
- Coverage     52.80%   52.00%   -0.80%
  Complexity      196      196
============================================
  Files            47       47
  Lines           981      996      +15
  Branches        136      141       +5
============================================
  Hits            518      518
- Misses          380      393      +13
- Partials         83       85       +2

Impacted Files
Coverage Δ

...a/com/google/android/fhir/index/ResourceIndexer.kt
41.81% <0.00%> (-4.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc6810...2816946. Read the comment docs.


Multi-Linguistic?

It's not able to provide correct extraction for Urdu and Bengali. It's working fine for English. Is it not multi-lingual?

What I meant is in your UI, for english it’s fine but when I upload Urdu or Bengali docs, the results are not correct. Just let me know that can your tool support multi-lingual docs at the moment?

@tylermaran, what is the model in the backend that we are using in the demo ui?

to fix your trouble check this solution click
maybe this will solve your problem.

@harshit-raizada, please don't follow the INSTRUCTIONS ON THE ABOVE LINK SHARED BY ummm288
@tylermaran, @annapo23 please block the previous comment, the link contains a malware.


When will you deploy on Optimism Mainnet?

We need to launch our product in a few days on Optimism Mainnet, and our product depends on EAS. When will you deploy on Optimism Mainnet? Or can we deploy it on our own?
However, I don't think deterministic deployment will be a problem for users as they usually use UI not directly interact with the smart contract.  The developer is responsible for testing their code properly. However, it's still a problem for code upgrades.

Hey @Chomtana,
We are actually planning to deploy on Optimism Mainnet in the next couple of days, so stay tuned 😎

Feel like possible redeployment due to #64 and #65?

Potentially, yeah. We are currently working on this with Optimism's team.

In case of a contract upgrade, if the attestation is done on the old contract, what will happen in the explorer? It will show the old data or not show it at all?

Yeah, definitely. If an upgradeable variant of EAS is deployed, the explorer will always show any attestations made using the previous implementaation.