non-matching lineage table and treeview for certain peptides

For these two sequencues (possibly more, only tested sample7) TNTILQSAFFR and MIIGGGSAYSR, the firmicutes are listed as a child of the bacteria in the lineage table, but according to the tree they are a child from Bacteroidetes/Chlorobi group which is also incorrectly calculated as their LCA.
See http://unipept.ugent.be/sequences/TNTILQSAFFR/equateIL or the following screenshots:

Original issue by @silox on Wed Dec 10 2014 at 17:52.
Closed by @bmesuere on Thu Mar 26 2015 at 20:38.

The origin of this bug is in the invalidation step. If a taxon is invalidated, its complete upstream lineage is temporarily set to invalid (-1). The reason for this is to also invalidate any gaps between the invalid taxon and the next valid one in the lineage. If we don't do this, something like undefined bacteria with only its superkingdom set to bacteria would still have a huge impact on the results.
The problem is that all gaps in the lineage are invalidated, and not only till the next valid taxon. For example:
+----------+--------------+---------+------------+-------------+--------+-----------+------------+--------+----------+------------+------------+--------+----------+------------+-----------+-------------+--------+-----------+-------+----------+-------+----------+---------------+------------------+---------+------------+----------+-------+
| taxon_id | superkingdom | kingdom | subkingdom | superphylum | phylum | subphylum | superclass | class  | subclass | infraclass | superorder | order  | suborder | infraorder | parvorder | superfamily | family | subfamily | tribe | subtribe | genus | subgenus | species_group | species_subgroup | species | subspecies | varietas | forma |
+----------+--------------+---------+------------+-------------+--------+-----------+------------+--------+----------+------------+------------+--------+----------+------------+-----------+-------------+--------+-----------+-------+----------+-------+----------+---------------+------------------+---------+------------+----------+-------+
|   944564 |            2 |      -1 |         -1 |          -1 |   1239 |        -1 |         -1 | 909932 |       -1 |         -1 |         -1 | 909929 |       -1 |         -1 |        -1 |          -1 |  31977 |        -1 |    -1 |       -1 | 29465 |       -1 |            -1 |               -1 | -671229 |         -1 |       -1 |    -1 |
+----------+--------------+---------+------------+-------------+--------+-----------+------------+--------+----------+------------+------------+--------+----------+------------+-----------+-------------+--------+-----------+-------+----------+-------+----------+---------------+------------------+---------+------------+----------+-------+

should be
+----------+--------------+---------+------------+-------------+--------+-----------+------------+--------+----------+------------+------------+--------+----------+------------+-----------+-------------+--------+-----------+-------+----------+-------+----------+---------------+------------------+---------+------------+----------+-------+
| taxon_id | superkingdom | kingdom | subkingdom | superphylum | phylum | subphylum | superclass | class  | subclass | infraclass | superorder | order  | suborder | infraorder | parvorder | superfamily | family | subfamily | tribe | subtribe | genus | subgenus | species_group | species_subgroup | species | subspecies | varietas | forma |
+----------+--------------+---------+------------+-------------+--------+-----------+------------+--------+----------+------------+------------+--------+----------+------------+-----------+-------------+--------+-----------+-------+----------+-------+----------+---------------+------------------+---------+------------+----------+-------+
|   944564 |            2 |   NULL  |       NULL |        NULL |   1239 |      NULL |       NULL | 909932 |     NULL |       NULL |       NULL | 909929 |     NULL |       NULL |      NULL |        NULL |  31977 |      NULL |  NULL |     NULL | 29465 |       -1 |            -1 |               -1 | -671229 |         -1 |       -1 |    -1 |
+----------+--------------+---------+------------+-------------+--------+-----------+------------+--------+----------+------------+------------+--------+----------+------------+-----------+-------------+--------+-----------+-------+----------+-------+----------+---------------+------------------+---------+------------+----------+-------+

Also note that this is an explanation for the wrong LCA, but not for the error in the tree. I'll look into that next.
@ninewise I presume you also copied this error in your rewrite?
Original comment by @bmesuere on Wed Jan 14 2015 at 14:42.

The error in the tree is related: The tree construction algorithm first adds everything from root till LCA, and then starts adding the other nodes.
Original comment by @bmesuere on Wed Jan 14 2015 at 14:46.

@ninewise I think these lines inserted before https://github.ugent.be/unipept/unipept/blob/e0e079f3ed55fff04ec7864ed743ed764d64e307/backend/java/src/main/java/org/unipept/storage/PeptideLoaderData.java#L357 will fix the problem. Can you check if this seems correct and commit it in your branch?
int rankIndex = rankIndices.get(rank);
if (lineage[rankIndex].equals("-1") && taxons.get(parentId).validTaxon) {
        for (int i = rankIndex; rankIndex > 0; i--) {
                lineage[i] = null;
        }
}

Original comment by @bmesuere on Wed Jan 14 2015 at 15:01.

I did indeed copy this error, I'll look into it.
Original comment by @ninewise on Thu Jan 15 2015 at 12:47.

I think I'll just have to modify this to mark only a part.
Original comment by @ninewise on Thu Jan 15 2015 at 12:57.

Scratch that, @bmesuere approached seems better. However, is it possible that there are invalid parents (closer to the root than some valid taxon), and if so, shouldn't the missing ranks above this be ranked as invalid, too?
Original comment by @ninewise on Thu Jan 15 2015 at 13:09.

This seems to be fixed:
$ diff <(zcat lineages.tsv.gz) <(zcat lineages_old.tsv.gz) | head -22
30c30
< 30    27  2   -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -1  -27 -1  -1  -1
---
> 30    27  2   \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  \N  -27 -1  -1  -1
129c129
< 129   232 2   -1  -1  -1  1224    -1  -1  1236    -1  -1  -1  135622  -1  -1  -1  -1  72275-1 -1  -1  226 -1  -1  -1  -232    -1  -1  -1
---
> 129   232 2   \N  \N  \N  1224    \N  \N  1236    \N  \N  \N  135622  \N  \N  \N  \N  72275\N \N  \N  226 \N  \N  \N  -232    -1  -1  -1
141,144c141,144
< 141   239 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -239    -1  -1  -1
< 142   240 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -240    -1  -1  -1
< 143   241 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -241    -1  -1  -1
< 144   242 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -242    -1  -1  -1
---
> 141   239 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 \N  \N  \N  -239    -1  -1  -1
> 142   240 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 \N  \N  \N  -240    -1  -1  -1
> 143   241 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 \N  \N  \N  -241    -1  -1  -1
> 144   242 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 \N  \N  \N  -242    -1  -1  -1
162c162
< 162   261 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -261    -1  -1  -1
---
> 162   261 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 \N  \N  \N  -261    -1  -1  -1

Original comment by @ninewise on Tue Jan 20 2015 at 16:26.

@ninewise nope sorry, there's still a small error. Everything up until the first valid taxon should be -1:
129   232 2   \N  \N  \N  1224    \N  \N  1236    \N  \N  \N  135622  \N  \N  \N  \N  72275\N \N  \N  226 -1  -1  -1  -232    -1  -1  -1

Original comment by @bmesuere on Tue Jan 20 2015 at 19:40.

Got it:
 $ diff <(zcat lineages2.tsv.gz) <(zcat lineages.tsv.gz) | head -23
129c129
< 129   232 2   -1  -1  -1  1224    -1  -1  1236    -1  -1  -1  135622  -1  -1  -1  -1  72275-1 -1  -1  226 -1  -1  -1  -232    -1  -1  -1
---
> 129   232 2   \N  \N  \N  1224    \N  \N  1236    \N  \N  \N  135622  \N  \N  \N  \N  72275\N \N  \N  226 -1  -1  -1  -232    -1  -1  -1
141,144c141,144
< 141   239 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -239    -1  -1  -1
< 142   240 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -240    -1  -1  -1
< 143   241 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -241    -1  -1  -1
< 144   242 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -242    -1  -1  -1
---
> 141   239 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 -1  -1  -1  -239    -1  -1  -1
> 142   240 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 -1  -1  -1  -240    -1  -1  -1
> 143   241 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 -1  -1  -1  -241    -1  -1  -1
> 144   242 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 -1  -1  -1  -242    -1  -1  -1
162c162
< 162   261 2   -1  -1  68336   976 -1  -1  117743  -1  -1  -1  200644  -1  -1  -1  -1  49546-1 -1  -1  237 -1  -1  -1  -261    -1  -1  -1
---
> 162   261 2   \N  \N  68336   976 \N  \N  117743  \N  \N  \N  200644  \N  \N  \N  \N  49546\N \N  \N  237 -1  -1  -1  -261    -1  -1  -1
180c180
< 180   275 2   -1  -1  -1  1297    -1  -1  188787  -1  -1  -1  68933   -1  -1  -1  -1  188786-1    -1  -1  270 -1  -1  -1  -275    -1  -1  -1
---
> 180   275 2   \N  \N  \N  1297    \N  \N  188787  \N  \N  \N  68933   \N  \N  \N  \N  188786\N    \N  \N  270 -1  -1  -1  -275    -1  -1  -1

Original comment by @ninewise on Tue Jan 20 2015 at 22:57.

:+1:
Original comment by @bmesuere on Wed Jan 21 2015 at 11:40.

fixed as of 2.5.2
Original comment by @bmesuere on Thu Mar 26 2015 at 20:38.


Specification of expectations for English itwêwina search (single terms)

When crkeng.xml is imported, each token/word in the English translations should be indexed as follows:
a. as-is, without any initial or final punctuation: Edmonton -> Edmonton
b. transformed into lower case, without any initial or final punctuation: Edmonton -> edmonton
c. transformed into lower case and with token-internal punctuation as well as initial/final punctuation removed: beaver-berries -> beaverberries
d. stemmed using whatever algorithm we have available: beaver-berries -> beaver-berry (or beaver-berri or beaver-berrie)
e. For compound words, i.e. ones with hyphens, the components should be indexed according to steps a-e: beaver-berries -> beaver + berries -> ...

Input
Processing
Index

Edmonton
as-is
Edmonton

beaver-berries
as-is
beaver-berries

Edmonton
lower-case
edmonton

beaver-berries
no punctuation
beaverberries

beaver-berries
compound components
beaver, berries

beaver-berries
stemming
beaver-berri

beaverberries
stemming
beaverberri

beaver
stemming
beaver

berries
stemming
berri

When an English search is initiated, the search string should be processed as follows:
a. as-is: Calgary matches Calgary; beaver-berries matches beaver-berries
b. transformed into lower case: Calgary -> calgary matches calgary (which co-indexes Calgary)
c. transformed into lower case and with token-internal punctuation removed: beaver-berries -> beaverberries matches beaverberries (which co-indexes beaver-berries)
d. stemmed: beaver-berries -> beaver-berri matches beaver-berri (which co-indexes beaber-berries)
e. prefix search: any of b, be, bea, beav, beave, and beaver match beaver-berries + beaverberries + beaver (which co-index for beaver-berries); berries -> any of b, be, ber, berr, and berri match beaver-berri (co-indexing with beaver-berries); BUT I don't know how we would get from berry to beaver-berries without a proper stemmer that is able to stem berries as berry (of course berr will match berri).

Search
Processing
Index
Match

Calgary
as-is
Calgary
Calgary

beaver-berries
as-is
beaver-berries
beaver-berries

Calgary
lower-case
calgary
Calgary

beaver-berries
strip punctuation
beaverberries
beaver-berries

beaver-berries
stemming
beaver-berri
beaver-berries

b, be, bea, beav, beave, beaver
prefix search
beaver
beaver-berries

b, be, ber, berr, berri, berrie
prefix search
berries
beaver-berries

[edit -- added this bridging case]
As a bridge case combining this issue with #589, searching with the word pair working together, the following is what would be expected.
a. as-is: working together matches working and together.
d. stemmed : working together is stemmed as work and together, and should match the intersection of matches with these stems searched separately.
e. prefix search: the last space-separated word might allow for prefix search (perhaps after the first 2-3 letters).

Search
Processing
Index
Match

working together
stemming
work + together
work AND together

w, wo, wor, work
prefix search
work
working

worki, workin
prefix search
working
working

work t, work to, work tog, work toge, work toget, work togeth, work togethe
prefix search
work + together
work AND together

@Madoshakalaka The above behavior is what I'd expect to happen when crkeng.xml is imported and its English translations are used to index the Cree dictionary entries, as well as how the English search component will process the search string.

Here's some GAWK code that would seem to implement 1. Indexing above. The stemmer is the crappiest ever, but perhaps good enough for our purposes.
echo "-beaver-berries'" |
gawk '{ sub("^[[:punct:]]*","",$0); sub("[[:punct:]]*$","",$0); nw=split($0,w,"[- ]"); print $0; for(i=1; i<=nw; i++) print w[i]; }' |
gawk '{ print $0; if(tolower($0)!=$0) print tolower($0); }' |
gawk '{ stem=$0; sub("(((e)?s)|(ed)|(n)|(ing)|(er)|(est))$","",stem); print $0; if(stem!=$0) print stem; }'

beaver-berries
beaver-berri
beaver
beav
berries
berri

Addressed via #784.


default init-peer-count is off-by-one when launch args include self

We currently presume that if only one peer is passed to weave launch, that this peer won't be itself.
When automating provisioning, It is often convenient to write less logic possible and just pass a list of all know peers, which works just fine except for the case when this length of this list is 1.
There exists logic to prevent connection to itself, it shouldn't be impossible to correct IPAM expectations on the basis of ErrConnectToSelf, given only one peer is expected.

Sure it's possible, but it is completely hideous to implement.

init-peer-count can be set explicitly; to implement this feature we need to remember whether that was done, or the init-peer-count was derived from the arg count, since we only want to "correct" it in the latter case
the list of destinations to connect to changes dynamically - both through weave connect|disconnect and peer discovery; to implement this feature we need to remember what the original launch arguments are, so that when we do detect that we have connected to ourself, we only "correct" the init-peer-count if the destination address was in the original launch args.
we must perform the correction once only. somehow.

There are probably others.
Seems to me that by far the easiest and reliable way to fix this issue is for the user to set --init-peer-count to the length of args minus one. After all, they (usually) know when they are feeding the peer's own address into that.

I think if #1721 were implemented then the desired semantics would fall out.

I think if #1721 were implemented then the desired semantics would fall out.

I don't see how that addresses any of the points I raised.

I don't see how that addresses any of the points I raised.

It says to do it only in the absence of a specified count.
It says to pick the count at the time of consensus, which addresses the issue of dynamic changing and performing it only once.

I see. How would we ensure that consensus is only initiated after we have (potentially) connected to ourself and discovered that we should exclude that IP from the init-peer-count calculation?

ensure that consensus is only initiated after

That is harder.

Closed by #2070.

#2070 was incorrect, sadly.  See https://github.com/weaveworks/mesh/pull/57

Filed #2481 to cover


A.07.IR10.title.abstract

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
Coverage: This test case does not fully tests the IR10 requirement: 'An INSPIRE View service shall contain the INSPIRE metadata elements set out in the Metadata Regulation [INS MD] as shown in Table 3.'
Proposed Change
Change the test or change the requirement only to cover keyword.
It may be better to merge this test case with A.04, A05, A07, and A11-A21.

Confused as what the issue is here.  Elements that are mandatory (and conditional related to scenario 2 responses) are covered in other IR tests.  Only service title and abstract need to be tested in this IR 10 test.
Not sure if the test should be merged with any others


Feature Request: Gravatar Implementation

Desired Feature: It is better to have the Gravatar implementation in Voten to make the profile more attractive at the beginning like GitHub does!

it's *Voten.

Sorry, Fixed Typo! What is the reason for not implementing!

I intend to make "avatar update" easier in the future. Maybe add some pre choices; maybe generate avatars from their username, etc.


Replace peer dependency

Replace peer dependency with the @linaria/webpack-loader due to the splitting linaria packages to @linaria scope from v3.0

Thank you! 🙂


Rename "Popochiu" example game

This is trivial/low priority, but the example game inside the popochiu-dev repository is itself named "Popochiu" and sports the same string everywhere. This makes things a bit confusing for first-time contributors. It also makes it harder to search inside the repo (even if excluding the game folder is actually an easy solution).
The fact that  the engine's logo also matches the characters' apperance makes it worse :)
We can rename the example game and try to exclude the work "Popochiu" in it.

There is one thing that worries me about this. I'm using that popochiu folder to check if the plugin is ready to be used. When it is installed, the plugin creates the folder and put some files there (including PopochiuData.cfg, PopochiuSettings.tres, and PopochiuGlobals.gd). Then when Godot starts the plugin checks if the folder exists, and if it does, then it continues with all the logic for the Popochiu dock.
One option is to get rid of the popochiu folder and make all those configuration files and the folders for rooms, characters, inventory items and dialog trees to be in the project's root: res://.
Maybe another option is to ask devs how they want to name the folder and store that in the PopochiuData.cfg for later validations.

The game folder has been long renamed game and this is no more an issue. Closing


investigate performance degradation at scale, with api/v1/vulnerability and api/v1/product

loadtest revealed
 Slowest page load within specified percentile of requests (in ms):
 ------------------------------------------------------------------------------
 Name                     |    50% |    75% |    98% |    99% |  99.9% | 99.99%
 ------------------------------------------------------------------------------
 GET /advisories          |      1 |      2 |      3 |      4 |      6 |     11
 GET /api/v1/advisory     |      5 |      5 |      9 |      9 |     10 |     10
 GET /api/v1/importer     |      3 |      4 |      6 |      7 |      9 |      9
 GET /api/v1/organization |      4 |      5 |      9 |     10 |     13 |     13
 GET /api/v1/product      |     73 |     80 |     97 |    100 |    120 |    120
 GET /api/v1/purl         |      5 |      5 |      8 |      9 |     19 |     19
 GET /api/v1/purl?q=curl  |      5 |      6 |      9 |     10 |     11 |     11
 GET /api/v1/sbom         |      4 |      5 |      9 |     11 |     11 |     11
 GET /api/v1/vulnerabil.. |  1,000 |  1,000 |  1,000 |  1,000 |  1,000 |  1,000
 GET /importers           |      1 |      2 |      3 |      4 |      6 |     10
 GET /index               |      1 |      2 |      3 |      4 |      6 |     10
 GET /openapi             |      3 |      4 |      6 |      7 |     10 |     16
 GET /packages            |      1 |      2 |      3 |      4 |      6 |     11
 GET /sboms               |      1 |      2 |      3 |      4 |      6 |      9
 POST query advisory wi.. |      4 |      5 |      7 |      8 |     12 |     18
 -------------------------+--------+--------+--------+--------+--------+-------
 Aggregated               |      2 |      4 |      6 |      7 |  1,000 |  1,000
 ------------------------------------------------------------------------------

we should perform code/data analysis why api/v1/product and api/v1/vulnerability degrade

For sure. They are very complex queries, and definitely are succumbing to a 1+N queries that we could probably optimize a bit.

it looks like we are looping through some queries, for example with api/v1/product
    pub async fn from_entities(
        products: &[product::Model],
        tx: &ConnectionOrTransaction<'_>,
    ) -> Result<Vec<Self>, Error> {
        let mut summaries = Vec::new();

        for product in products {
            summaries.push(ProductSummary::from_entity(product, tx).await?);
        }

        Ok(summaries)
    }

even if from_entity takes advantage of find_related, the top level ensures multiple calls and pushes.

same with api/v1/vulnerability
impl VulnerabilitySummary {
    pub async fn from_entities(
        vulnerabilities: &[vulnerability::Model],
        tx: &ConnectionOrTransaction<'_>,
    ) -> Result<Vec<Self>, Error> {
        let advisories = vulnerabilities
            .load_many_to_many(advisory::Entity::find(), advisory_vulnerability::Entity, tx)
            .await?;

        let mut summaries = Vec::new();

        for (vuln, advisories) in vulnerabilities.iter().zip(advisories.iter()) {
            let cvss3 = cvss3::Entity::find()
                .filter(cvss3::Column::VulnerabilityId.eq(&vuln.id))
                .all(tx)
                .await?;

            let total_score = cvss3
                .iter()
                .map(|e| {
                    let base = Cvss3Base::from(e.clone());
                    base.score().value()
                })
                .reduce(|accum, e| accum + e);

            let average_score = total_score.map(|total| Score::new(total / cvss3.len() as f64));

            summaries.push(VulnerabilitySummary {
                head: VulnerabilityHead::from_vulnerability_entity(vuln, tx).await?,
                average_severity: average_score.map(|score| score.severity().to_string()),
                average_score: average_score.map(|score| score.value()),
                advisories: VulnerabilityAdvisoryHead::from_entities(vuln, advisories, tx).await?,
            });
        }

        Ok(summaries)
    }

same with api/v1/vulnerability

This is currently on my plate relating to #411

the past few weeks of work have addressed  - will open a new issue based on more testing if required


VSCode SCM has to be case sensitivity

VSCode Version: 1.18.0
OS Version: Windows 10 1709 b16299.19

Steps to Reproduce:

Create file "foo/test.txt" and commit it to git repository
Rename directory "foo" to "FOO"

Expected: Source Control tab show this modification, as "git status" in WSL terminal
Actual: Source Control tab did not see this modification, but "git status" (in WSL terminal) see. In result we can't fix directory/file letter case bugs via VSCode. Only by command line. But our most sites are on *nix OSes where big/small letters matter...
Reproduces without extensions: Yes

If you change the casing of a file in the Explorer, are you sure git status sees it?
I just tried in macOS and Windows, and git status doesn't see it. If I change the casing of a file, git status won't report that the file has changed.
Can you show me a screen recording?

Missed additional information: I use WSL in terminal. "git status" in WSL terminal is case sensitivity...
Looks like problem is more complex :)

#29812


Add mozilla to open source org list

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

I was looking through the list if orgs and their OSS projects and noticed that Mozilla was missing.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Hi @kenyonj , can you please have a look?

Thanks for the approval @ssbarnea :green_apple:

@ssbarnea can we merge this one?


Add optional "lazy evaluation" of documents.

This is a solution (from Jonathan) that doesn't assemble the documents until you click the link:
attachment:
  variable name: helloworld
  content: |
    Hello, world.  It is ${ current_datetime().format_datetime() }.
---
mandatory: True
question: |
  Your document
subquestion: |
  [Click here](${ interview_url_action('get_document', temporary=True) })
---
event: get_document
code: |
  reconsider('helloworld')
  response(file=helloworld.pdf,

We've been getting quite a bit of timeout reports from the students on their interviews, and given how progress is going on speeding up assembly, we should prioritize this IMO.

@BryceStevenWilley we should return to this issue--noticing some significant slow downs with multi-weaver feature that feel addressable

I had the same conversation with Matt when working with e-filing and the Appearance + Fee Waiver forms. Would we want to do the background assembly option?

Could we do two-stage processing of the template - is it worth caching the "preview" version of the template with mostly rendered contents--or is it going to take the same time either way? [Probably not a good time saving feature]


Add metadata to pipelines/repos

What is the goal / desired outcome?
Add custom metadata to pipelines/repos at creation time (for example with a metadata field array in the pipeline def  JSON file).
One of the use-case is to design a GUI that adapts to the underlying workflow. For instance let's assume the pipeline expects an input string called name, we could embed this piece of information in the metadata and the GUI could build a page including this a field name.
Another use-case is to store information about the sw running in the pipeline and so on.
If there is a way to accomplish this today via workaround, what does that require?
It is just a matter of being able to store a couple of custom fields.
(Optional) What is your proposal for a feature to solve this?

Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

Both repos and pipelines have an optional text field called description which could serve this purpose to describe the data structure/format of the repo or the expected input data format for a pipeline.
Would this work for your purposes?

@JoeyZwicker Yes that does the trick, thanks!

I think it could be quite useful to have custom metadata fields. Some examples off the top of my head:

linking to the URL I got the data from
referencing the paper that I found the algorithm I'm using in a pipeline
contact information for the person who created the pipeline
organizational unit that manages the data
categorizing by project

Any chance something like this might be on the horizon?

@OliverEvans96 We are discussing this internally. There are several interesting use cases and problems to solve here. We will spend some time thinking of a potential design before we can give you an idea about the timeframe.

@nitinjainsj - great to hear!
Since you're in the brainstorming phase, I'll throw out something else I've been thinking of lately as food for thought. Take what you will :)
Pachyderm is great. Buggy at times, but the concept is great. You can track the full provenance of all of your data in no uncertain terms. But it can be tedious and slow to write, test, and debug code, build docker images, figure out the correct way to organize my datums, etc. If I'm transforming lots of data or writing a crucial production pipeline, then spending the energy to go through the whole process of creating a proper pipeline is worthwhile.
But I'm less likely to expend the same amount of effort on the many small data transformations I perform on a daily basis, e.g. splitting/renaming CSV columns, restructuring JSON, cropping/resizing images. Because of the large variety of these small tasks, it's a lot easier to use jq or vim or imagemagick, or open up a IPython REPL, than to create a formal pipeline. So I'm missing out on a lot of potential provenance.
Two ideas that would significantly reduce friction here:

Predefined language environments that would allow allow me to just write small scripts instead of generating whole images. Think AWS Lambda/serverless for pipelines.
Interactive REPL sessions in the image of my choosing with data from PFS mounted to my container. The commands are recorded and a pipeline is retroactively generated to track provenance, possibly with the option to remove extraneous commands from the recording.

Furthermore, plenty of data wrangling tasks are much easier done by hand or through a GUI than running through a predefined pipeline. e.g. extracting data from a PDF, digitizing a plot from a jpg, reshaping inconsistently formatted data. In these situations, it's not feasible to really have proper reproducible provenance, but it would still be very useful to have something indicating the data lineage.
In this totally unstructured situation, the best I can think of it to allow the creation of "manual relationships" between datums, which are basically pipelines that cannot be run automatically, but do have a description and custom metadata fields. This would at least allow a human-readable description of how the data was derived, and you would have a clear links between the input datums and output datums of the manual process.
Hopefully something here sparks some thought. Even if it's not right for Pachyderm, I'm looking forward to a world where we can clearly and easily document and visualize relationships between all kinds of data, structured and otherwise.
Oliver


Cannot read properties of undefined (reading runs)

I only just heard about this library and I don't quite understand the usage. I see GetListByKeyword and it returns a list based upon the key word (obviously). I am more interested in a particular video however. So I tried to call: youtubesearchapi.GetVideoDetails() assuming that the ID was the Youtube video ID.
Trying several different IDs (that exist) has resulted in the following error. Looking at the library code I can see it is trying to access runs but clearly it didn't find a matching object. I don't know if any existing Video ID will work or if it has to be part of playlist, channel or some such.
Would someone clarify this please? Thanks.
TypeError: Cannot read properties of undefined (reading 'runs')
at Object.GetVideoDetails (D:\Repos\tube-api\node_modules\youtube-search-api\index.js:273:46)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async D:\Repos\tube-api\src\app.ts:178:22

Can also confirm I'm getting the same error, using .GetVideoDetails(). Any help would be appreciated 🙂.

Can you guys provide the Id you tested before?

I tested some videos on youtube, it did not prompt any error. Please provide me with the Video ID.

I am also getting an error on some video IDs when calling .GetVideoDetails(). Specifically, this ID wiH2oJu1XZY.
Error:
TypeError: Cannot read properties of undefined (reading 'twoColumnWatchNextResults')
    at Object.GetVideoDetails ({my_project}\node_modules\youtube-search-api\index.js:259:49)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

I'm also getting same error when on initdata.contents.twoColumnWatchNextResults it occurred if same request sent again.


⚠ Jenkins Plugins Artifactory has degraded performance

In 23462aa, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1606 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 570c23b after 12 minutes.


[nrf fromtree] scripts/dts: Fix for PyYAML 5.1 Loader changes

CI is broken without this patch so we cherry-pick it from upstream while we wait for the regressions in the upmerge to be resolved.
NB: I have not tested this patch to make sure that it fixes the downstream CI issues.

Example of CI being down: http://jenkins-ncs.nordicsemi.no:8080/blue/organizations/jenkins/fw-nrfconnect-nrf/detail/PR-555/1/pipeline#step-58-log-2023

The upmerge PR is now merged, can we close this one?

Yes


Fix zero symbol test

Issue #, if available:
11 Symbol test is failing in IonHashTest.ion
Description of changes:
Currently the implementation is based on JS and zero symbols are not supported. Modified serializer logic to handle zero symbol like java impl
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing this PR because the fix is related to fix failing struct IonHashTest PR: https://github.com/amzn/ion-hash-dotnet/pull/21


Maximum Product of Three Numbers solution in cpp

Please assign me to this issue

@Vanshika2063  To maintain the code structure, I will make separate branches and PRs for each issue

I would like to solve this issue. so, please assign me this issue.

you can work on this with java or other language as i have assigned this to @bishalshaw-164

I can work with python.


README: add note about how to build icedtea with symbols on Gentoo

This commit adds a brief yet not-completely-obvious note about how to get symbols into the
'icedtea' OpenJDK package on Gentoo Linux. The approach worked for me when I
tried async-profiler last night and (of course) initially had no symbols;  after rebuilding icedtea
with "nostrip" I got perfectly good profiles.

I removed "OpenJDK" from the title and also rephrased the PR message slightly.

Thanks


Need mutable parameters for building a test case for borrowing a Lineartype

mod LinearExampleStub {

	struct Linear {
	    x: i32,
	    y: i32,
	}

	fn main() -> i32 {
		let mut xy: Linear =
                    Linear {
                        x: 0,
                        y: 1,
                    };
		// linear value is written/consumed
		consume_x(&xy);
		return xy.x;
	}

	fn consume_x(value: & mut Linear) {
		value.x = value.x + 1;
	}

}

$cargo r build linearExample02.con --ir
   Compiling linearExample02 (linearExample02.con)

thread 'main' panicked at crates/concrete_ir/src/lib.rs:475:38:
not yet implemented
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Lines 474-475 of lib.rs
            TyKind::Param { .. } => todo!(),
            TyKind::Struct { .. } => todo!(),

Changing parameter as non mutable yields an expected error conducting to make the parameter mutable. So this new feature (checking mutable types) should implement mutable parameters for being able to cover borrow checking part of LinearityCheck
mod LinearExampleStub {

	struct Linear {
	    x: i32,
	    y: i32,
	}

	fn main() -> i32 {
		let mut xy: Linear =
                    Linear {
                        x: 0,
                        y: 1,
                    };
		// linear value is written/consumed
		consume_x(&xy);
		return xy.x;
	}

	fn consume_x(value: & Linear) {
		value.x = value.x + 1;
	}

}

$cargo r build linearExample02.con --ir
   Compiling linearExample02 (linearExample02.con)

[NotMutable] Error:
    ╭─[linearExample02.con:22:3]
    │
 21 │     fn consume_x(value: & Linear) {
    │                  ──┬──
    │                    ╰──── variable declared here
 22 │        value.x = value.x + 1;
    │        ──────────┬──────────
    │                  ╰──────────── can't mutate this variable because it's not mutable
────╯

This requirement was motivated by PR #124

Can you try with &mut on the function call?

You are correct, it runs when rewriting to
consume_x(&mut xy);
The first example panics the compiler, it is better if it gives a compilation error than panic.

Changed issue title. Will convert the panic case into a testcase


Add lint rule for copyright headers

@mmuckley This is surprisingly tricky! I could not find a Python package that does this flexibly. Internally this is performed by the FBSource Linters but that is, unfortunately, not open source.

@mmuckley I went ahead and did the initial fixes. #148


[Card] add childrenStyle prop

[ ] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

add childrenStyle prop to have the ability to customize the inner div styles.
i needed this to give the div width of 100% then i can align the header to center and the body to left.

@oliviertassinari i did this changed

@RahavLussato can you squash?

@nathanmarks i did some clumsy squash, can you squash on merge ?

@RahavLussato - git rebase -i HEAD~3 and 'f' to flatten. Please could you also 'r' (reword) the commit to match the PR title?
Thanks.

@mbrookes @nathanmarks is it ok now ?

@RahavLussato Nearly, you still need to reword the commit fro "[Card] add childrenStyle prop: to "[Card] add containerStyle prop

@mbrookes @nathanmarks done :)

@RahavLussato Thanks for your contribution! 👍


[BUG] - Setting toolbar color to white does not work

Lib Version 4.3.1

Bug
Setting the toolbar color to Color.WHITE doesn't work.
This happens because of a condition checking if toolbar color is -1 assume it's not set. Unfortunately -1 is also the value of Color.WHITE.
PS: I had made this feature. Will fix it

Hey welcome 👋 to the library and thanks for the Issue.
Can you please follow the template we have for issues? 🙏
There are many points on the template that will help me to help you.
I will close 🔴  this issue so you can reopen following the template
Is important to remember that my work here is a volunteer and to save time and have better answer help me that people use the templates.
Thanks!! 🎉


Correct typo in dates.py

Traceback (most recent call last):
File "date_example.py", line 10, in
day = service.convertDay(now, weekday=True)
File "/usr/local/lib/python2.7/dist-packages/semantic/dates.py", line 410, in convertDay
if sameDay(day, self.now):
File "/usr/local/lib/python2.7/dist-packages/semantic/dates.py", line 405, in sameDay
y = d1.year == d2.yaer
AttributeError: 'datetime.datetime' object has no attribute 'yaer'

Thanks!


"Error: Cannot read property 'state' of undefined"

No errors in Webpack, none in React, none in the console. I can only surmise that Storybook doesn't like some data it's getting.

Can I get more info about this? When this is happening? Any way I can test this out?

The example:

Now this is fixed right? :)

Yeah totally.

Well, maybe. Not sure if this is Webpack, or Storybook. Error only appears in the Storybook UI, but nowhere else.

I feel like the URL has something to do with it.

We had source maps supports in the error message. That package seems to give some weird errors on FF. So, we removed it.
We'll try to add it back in after they've fixed the issue.
Then we can easily find out the root cause of the error.

Thanks, I'm all of a sudden seeing this issue almost every time I refresh now. :/

Here's how I fix this locally: comment out the first story, let the browser refresh, uncomment, let the browser refresh. Works consistently.

Can I have a sample repo for this issue. Then I can debug the issue.

[Sent privately]

Working on this.

Please provide a reproduction path if you still experience this issue 👍


Made it optional to orient a body around its center of mass

For an application of mine I wanted to randomly build a 2D terrain, made up by some trapezoids, one next to another. Because the bodies got automatically translated around their center of mass, it wasn't straightforward to achieve that.

I was finally able to do it making optional to orient bodies around their center of mass, so that I could just position them at my will. I couldn't see any side effects. Let me know if there was a better way to do it, or feel free to integrate this if you think it could be useful to others.

Thanks for raising this, sorry for the delayed response - I like the idea but I'm considering implementing it in a slightly different way, I'll update this when I decide how to do it. Cheers!

Good, thank you. Sorry, I didn't mean to close this but I realized it would have been better to create the pull request from a branch rather than the master on my fork.


Bad score for answer_correctness metric

[ ] I have checked the documentation and related resources and couldn't resolve my bug.
Describe the bug
The answer generated by my model is similar to the ground_truths, but my answer_correctness score is very poor eventhough I have good score in the other metrics like context_recall, precision and faithfulness.
Ragas version:0.1.18
Python version:3.12
Code to Reproduce
scores = evaluate(
eval_dataset,
metrics=[context_recall, context_precision, faithfulness, answer_correctness],
llm = llm,
embeddings=GoogleGenerativeAIEmbeddings(google_api_key="AIzaSyCJFrruyyyuuuytuuiysJnFcQZJa-E-QJOxyjK_X8rpBkIQ", model="models/embedding-001"),
)
Error trace
No error but poor answer correctness metric score
Expected behavior
To get a good score for the answer_correctness like I got for the others

Additional context
Add any other context about the problem here.

@Simeon-Krah can you show me a couple of examples in the following format

generated_answer
ground_truth
answer_correctness score


Spring Cloud commons how to change ServiceInstanceMetadata

Spring Cloud commons how to change ServiceInstanceMetadata

That depends on the Service Discovery tool you use. For example, for Eureka, you can set eureka.instance.metadata-map.property=value via properties.

If it depends on Service Discovery, I would feel that this is a behavior made by Service Discovery independently and whether it is necessary to put it in Spring Cloud Commons for unified processing

Yes, it does - it depends on particular SD implementations. We allow using it, but the metadata values belong to service instance data, which is something managed by Service Discovery. In Spring Cloud, we use this data for load-balancing, routing, etc., but the source of truth is always SD.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Ok, you can close this, I think the discussion here is more valuable


dockerfile error

Dockerfile errror.
There is no /detectron/lib directory. It should just be /detectron/
This :
WORKDIR /detectron/lib
RUN make
Should be this:
WORKDIR /detectron
RUN make

Because you didn't clone the specific version of detectron.
Change the following line:
https://github.com/ronghanghu/seg_every_thing/blob/master/docker/Dockerfile#L19
Roll back version to the previous one:
RUN git clone https://github.com/facebookresearch/detectron /detectron \
	&& cd /detectron \
	&& git reset --hard 3c4c7f67d37eeb4ab15a87034003980a1d259c94

What about seg_every_thing/lib make? It looks like detectron files are included in seg_every_thing/lib/core, etc.   Are there additional instructions for make/install of seg_every_thing after Caffe2 and Detectron are installed?


MM-36932: reconnect websocket on wakeup

Summary
Upon wake-up we try to reconnect to the websocket after ~5min,
this PR makes it instant.
Ticket Link
https://mattermost.atlassian.net/browse/MM-36932
Release Note
NONE

/update-branch

@koox00 Note that this PR is the difference between 6.2 and 6.4 that causes issues with the reconnect logic shown in the R&D meeting today. There may be some subtle issues that come up if this code and another piece of code tries to create a new socket at the same time.

thanks for letting me know @mickmister


Feature/pb 304 support fo global effects

Past PR related to global gradients should be merged first

Depends on #95 from PBDL


Not able to send more than 20 bytes

I tried to send a more than 20 byte(25 bytes) ,it removed after 20 byte values .

Which service did you use and how did you send more than 20 bytes?

It's BluetoothGattCharacteristic service and when I set value more than 20 bytes(U_029E5_X0000_+0000_X1090) in mBatteryLevelCharacteristic.setValue(constantValue) . It removed value after 20 bytes once reach at 20th position(_X1090).

This is not an issue with the app.
Hopefully http://stackoverflow.com/a/24178409/422957 will help you there.


make plplot an optional dependency

Hello!
Do you think that where is possibility to make plplot dependency optional?
Currently, installation of plplot OCaml module (and, thus, owl) terminates with an error if the user does not have plplot software installed.
plplot pre-build packages aren't provided for many of the popular distros (for example, in Archlinux the package is provided in AUR only), so it might be troublesome to ask the users to perform an extra step.

Hi @soupault , my apologies for the late reply. This is definitely doable since there are no core components in Owl really depend on Plot module. Having Plot module included is because we aim to provide a more integrated and complete environment for fast prototyping for numerical developers.
I think one possible solution can be conditional build, which I will look into later. Currently, you have to edit _oasis manually to remove owl_plot by yourself if you don't want this module.

@ryanrhymes Thanks, I see. From my point of view, applying conditional build will be the best choice.
In the meantime, I'd suggest to enrich README.md with the link to plplot installation guide (as it is not as simple as opam install plplot). This one should do - http://plplot.sourceforge.net/downloads.php . Would you agree?

I agree. I will add some explanation in readme about this later.

Tried installing owl and got blocked because of this. I'm further confused because I installed plplot using opam depext plplot.5.11.0 on OSX 10.12.6, and running that a second time returns with All required OS packages found. However, when trying to install just plplot afterwards I get Failure: No valid installation of plplot or plplotd found. I do see that it install plplot version 5.13.0_5. Is that the problem?
Running depext for conf-openblas (which also initially caused the installation to fail) seemed to work.

Owl Plot module has been taken out as a separate lib.


Nuxt 3: Objects are not valid as a React child

Even with SSR disabled, the same error Objects are not valid as a React child appears in Nuxt 3 projects using Veaury. Is there a minimal working Nuxt 3 template project available somewhere?

same issue

Hey! Faced the same problem, and I think I figured this out.
The problem is veaury initialized vite vue plugin inside veauryVitePlugins function, and Nuxt 3 do the same under the hood. I don't know exactly how, but seems they are conflicting. The vite vue plugin is the first element of the array which is returned by veauryVitePlugins function. The solution is simple, just to remove first element of the array and then pass it to the vite plugins.
// nuxt.config.ts
import veauryVitePlugins from 'veaury/vite/index.js'

const veaury = veauryVitePlugins({
  type: 'vue',
});
veaury.shift();

...

vite: {
    plugins: [
      veaury
    ],
    ...
},
...

@futurfuturfuturfutur Would you mind explaining how did you make it work? I'm right now facing the same problem, trying to render a very simple component in nuxt 3.12.4. I followed your install and my component looks like this:
<template>
  <ClientOnly>
    <TestComponent />
  </ClientOnly>
</template>

test/test-react-component.jsx
import React from 'react'

export default function TestReactComponent() {
  return (

Test React Component

  )
}

@ekkaiasmith @futurfuturfuturfutur @Jesus82
Try<EMAIL_ADDRESS>https://github.com/gloriasoft/veaury?tab=readme-ov-file#using-veaury-in-the-ssr-projects


ModelicaUtilities.h misses ModelicaVFormatMessage / ModelicaVFormatError

Reported by anonymous on 24 Jan 2013 15:33 UTC
Should new MLS 3.2 functions ModelicaVFormatMessage and ModelicaVFormatError be part of ModelicaUtilities.h? Currently they are missing.

Migrated-From: https://trac.modelica.org/Modelica/ticket/973

Comment by anonymous on 28 Jan 2013 12:58 UTC
Dymola 2013 FD01 does not support ModelicaVFormatMessage and ModelicaVFormatError:
Compiling and linking the model (Visual C++).

Setting environment for using Microsoft Visual Studio 2008 x86 tools.
dsmodel.c
c:\users\john.smith\documents\dymola\TestModelicaV.c(7) : warning C4013: 'ModelicaVFormatMessage' undefined; assuming extern returning int
c:\users\john.smith\documents\dymola\TestModelicaV.c(15) : warning C4013: 'ModelicaVFormatError' undefined; assuming extern returning int
   Creating library dymosim.lib and object dymosim.exp
dsmodel.obj : error LNK2019: unresolved external symbol _ModelicaVFormatMessage referenced in function _MVFM
dsmodel.obj : error LNK2019: unresolved external symbol _ModelicaVFormatError referenced in function _MVFE
dymosim.exe : fatal error LNK1120: 2 unresolved externals

Error generating Dymosim.

Model:
model Unnamed
	function F1
		input Real x;
		output Real y;
		external "C" annotation(Include="#include \"TestModelicaV.c\"");
	end F1;
	algorithm
		F1(time);
end Unnamed;

/* TestModelicaV.c */
#include "ModelicaUtilities.h"

void MVFM(const char* format)
{
	va_list ap;
	va_start(ap, format);
	ModelicaVFormatMessage(format, ap);
	va_end(ap);
}

void MVFE(const char* format)
{
	va_list ap;
	va_start(ap, format);
	ModelicaVFormatError(format, ap);
	va_end(ap);
}

double F1(double x)
{
	if (x > 0.5) MVFM("Testmessage ModelicaVFormatMessage");
	if (x > 0.5) MVFE("Testmessage ModelicaVFormatError");
	return x;
}

Comment by sjoelund.se on 31 Jan 2013 08:11 UTC
Replying to [comment:1 anonymous]:

Dymola 2013 FD01 does not support ModelicaVFormatMessage and ModelicaVFormatError

That might be true, but MSL is not about Dymola. For the record, the ModelicaUtilities.h shipped with OpenModelica has ModelicaUtilities with working VFormat:
extern void ModelicaVFormatMessage(const char*string, va_list);
extern void ModelicaVFormatError(const char*string, va_list);

(ModelicaUtilities.h is specified in the specification anyway; I don't know why it's shipped with MSL)
Also note that your test code is not valid C:
TestModelicaV.c: In function ‘MVFM’:
TestModelicaV.c:7: error: ‘va_start’ used in function with fixed args
TestModelicaV.c: In function ‘MVFE’:
TestModelicaV.c:15: error: ‘va_start’ used in function with fixed arg

Comment by anonymous on 31 Jan 2013 12:09 UTC
Thanks for your reply. I guess ModelicaUtilities.h is provided with the MSL for sake of completeness as other resource files include it.

Comment by otter on 30 Mar 2013 21:26 UTC
Fixed in e7b9ccdc1e9dec8043f49557f02168790c607469 by adding the missing functions to ModelicaUtilities.h.
(They had been introduced in Modelica Specification 3.2. They are supported in the upcoming Dymola 2014).

Modified by otter on 30 Mar 2013 21:26 UTC

Comment by anonymous on 31 Mar 2013 11:41 UTC
Can you please remove the static declaration of ModelicaVFormatMessage and ModelicaVFormatError in lines 32 and 54. Thanks!

Comment by anonymous on 31 Mar 2013 15:57 UTC
Replying to [comment:6 anonymous]:

Can you please remove the static declaration of ModelicaVFormatMessage and ModelicaVFormatError in lines 32 and 54. Thanks!

Sorry. "Static" now removed.

Comment by anonymous on 2 Apr 2013 15:25 UTC
The ticket component should be changed from Resources to C-Sources.

Modified by dietmarw on 2 Apr 2013 15:33 UTC


support for a6100

Loading app list
Found 11 apps
Using drivers Windows-MSC, Windows-MTP
Looking for Sony devices
No devices found. Ensure your camera is connected.
Using drivers Windows-MSC, Windows-MTP
Looking for Sony devices
Querying mass storage device
Sony DSC is a camera in mass storage mode
Model:              ILCE-6100
Product code:<PHONE_NUMBER>
Serial number:      06176973
Firmware version:   1.00
Lens:               Model 0x12a08019 (Firmware 1.09)
Loading app list
Found 11 apps
Using drivers Windows-MSC, Windows-MTP
Looking for Sony devices
Querying mass storage device
Sony DSC is a camera in mass storage mode
Switching to app install mode
Traceback (most recent call last):
File "C:\projects\sony-pmca-re\pmca-gui.py", line 74, in do
File "C:\projects\sony-pmca-re\pmca\commands\usb.py", line 239, in installCommand
File "C:\projects\sony-pmca-re\pmca\commands\usb.py", line 35, in switchToAppInstaller
File "C:\projects\sony-pmca-re\pmca\usb\sony.py", line 306, in switchToAppInstaller
File "C:\projects\sony-pmca-re\pmca\usb\sony.py", line 244, in sendCommand
File "C:\projects\sony-pmca-re\pmca\usb\sony.py", line 67, in sendSonyExtCommand
File "C:\projects\sony-pmca-re\pmca\usb_init.py", line 36, in _checkResponse
pmca.usb.InvalidCommandException: Mass storage error: Sense 0x5 0x20 0x0

You have to connect the camera with the USB Connection setting set to Auto or MTP, I think that should resolve the issue.


How to run examples in the develop branch?

What command should we use to run an example in the develop branch?
What is wrong?
Examples are throwing errors in the develop branch.
Where does it happen?
In the develop branch.
How do we replicate the issue?
When I try to run any example in node, it's throwing an error in the develop branch:
$ node examples/javascript/which-letter-simple.js
.../brain.js/examples/javascript/which-letter-simple.js:1
(function (exports, require, module, __filename, __dirname) { import brain from '../../src';
                                                              ^^^^^^

SyntaxError: Unexpected token import
    at new Script (vm.js:51:7)
    at createScript (vm.js:136:10)
    at Object.runInThisContext (vm.js:197:10)
    at Module._compile (internal/modules/cjs/loader.js:618:28)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
    at Function.Module._load (internal/modules/cjs/loader.js:498:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:695:10)
    at startup (internal/bootstrap/node.js:201:19)

$ node --version
v9.11.2

Expected behavior
It works fine in the master branch:
$ node examples/which-letter-simple.js
iterations: 10, training error: 0.23317416631428975
iterations: 20, training error: 0.210598456317468
iterations: 30, training error: 0.17436649541030716
iterations: 40, training error: 0.13409059488488398
iterations: 50, training error: 0.10131207107612829
iterations: 60, training error: 0.07420014998226022
iterations: 70, training error: 0.0518410705540017
iterations: 80, training error: 0.03558307536025094
iterations: 90, training error: 0.025044735270968704
iterations: 100, training error: 0.018431227715397347
iterations: 110, training error: 0.014178778824250277
iterations: 120, training error: 0.011323259386754258
iterations: 130, training error: 0.009319155256412576
iterations: 140, training error: 0.007856361954302204
iterations: 150, training error: 0.0067525114866180585
iterations: 160, training error: 0.005895903210432278
iterations: 170, training error: 0.005215334626081061
a

You have to change import (not suported in nodejs environment) statement to require, like:
const brain = require('../../src')

Thanks, I just changed that line in which-letter-simple.js, but now it breaks in index.js.  Should I be using a different version of node, or is there some other runtime besides node that you're using to run these examples?
$ node examples/javascript/which-letter-simple.js
brain.js/src/index.js:1
(function (exports, require, module, __filename, __dirname) { import activation from './activation';
                                                              ^^^^^^

SyntaxError: Unexpected token import
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:616:28)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (brain.js/examples/javascript/which-letter-simple.js:1:77)

Yes, you right. This is the correct one: https://github.com/BrainJS/brain.js/blob/develop/dist/index.js

I was thinking of converting all those import statements to make it so we don't have to build it.  Thoughts?

Thanks @mubaidr, after changing that line and running a fresh dist build, it is now running without any errors.
@robertleeplummerjr I would support that because it takes 30+ seconds to build (the develop branch) on my old macbook, so running example scripts without rebuilding could save a lot of time for anyone getting ready for a PR, like myself.  I could take a crack at that if you want, so that you can focus on the more complex stuff like gpu support, etc.

@massaroni If you could do that, I would be very grateful.  I've been very active getting GPU.js v2 working for NodeJS, React Native for both Android and iOS, and even RaspberryPi support!  I'm solving an issue that crept up when converting https://github.com/hanbollar/Odin right now, after that, I believe we have all current projects and tests passing, and Brain.js will finally have full on stable GPU support everywhere.
Going to go ahead and close this as I believe the original answer was covered.

@massaroni That would be great. looking forward!

Thanks guys, I'm happy to help out.  This is an awesome project and you guys are super busy.  I found a way to keep all the es6 import/export statements and still run examples in node without running a build, and I just submitted a PR for that.

Actually this is fine. But the conversion is still required, since most of the nodejs programs are written & run without the experimental esm flag enabled. And this conversion will enable users to be able to use this lib out of the box without any modification to their script or run command.

Sure thing, I can convert all those imports to require's.

Another solution is to use babel-core/register while running the examples. If you edit an example to start with const brain = require('../src').default; or import brain from '../src';, then you can run the example with node -r babel-core/register examples/learn-math.js. (This also means you can use imports and ES6+ stuff inside of the examples too.)

If there was some massive gain to be had, I'd be for it, but it is a level of indirection that isn't nessisary for sugar.  Plus it makes the gpu layer more tedious.  I'd rather have the control till there is some amazing gain.


Drop jquery dependency

This is just an interrogation. I use parsley for months and find it really cool. However, I target IE11+ and last Firefox and Chrome browsers, so I don't need JQuery and would love to not use it. Is there a plan to create a separate version of parsley for modern browsers which doesn't depend of JQuery? ES6 is here we almost all we need :)

Glad you can target IE11+, that's not everyone's case though.
Removing jQuery is not in the foreseeable future, sorry.

I guess there is too much code to rewrite and to maintain two separate versions is too much code for a too small goal. ES6 is the future though, we will come there one day. Thanks for your work anyway. :)

Yeah, if there's ever a transition out, it would be one way I think (i.e. remove jQuery completely except for a thin wrapper).
BTW, we have moved to ES6, although the codebase can still use a bunch of features we haven't used.

More details in #1100

FYI, there's a possibility that we will go forward at some point with this, subscribe to 1100 if interested...


Display syntax errors in a separate window

Currently, the playground displays the AST and tokens even if it contains syntax errors. It would be useful to have a separate window to display all the syntax errors in a pretty format like the one used in parser snapshots. For example:
  |
1 | x: int =
  |         ^ Syntax Error: Expected an expression
  |

The design would be something like:

Alternative
An alternative design would be to actually have a diagnostics window similar to https://biomejs.dev/playground/ and https://pyright-play.net/.

This is not a priority but something which is good to have.

I think the new diagnostics window is good enough to not do this.


Floating editor window

Individual floating editor window that can be pinned on top.
Like what Visual Studio can do and most other IDEs.
This feature will be very useful for peeking code that does not need to be on a splitted editor and for multiple monitors.

Duplicate of https://github.com/microsoft/vscode/issues/10121


add_body docstring does not match function

There seems to be some missing arguments in the docstring
https://github.com/NVIDIA/warp/blob/fc7d3255435fc2fe6b54300e689f74e6d67418ca/warp/sim/model.py#L652

Thanks, fixed in 34f2e79c2fb1e7bc9c72fa5e8704d9a6883b94a4


Dexcom environment switch without app release

Provide an option to switch the environment for the test user (or provide a hidden option to switch the environment)

@lijogeorgep change the message to "Dexcom environment has been changed successfully"

@josmilan Done the recommented changes. ref: #248


how to propagate edge features

❓ Questions & Help
I am new to gnn and I am trying to realize some model.Now my model is described as:h_l=u(h_l,sum(m(h_l,h_k))over all k),where h_k is the feature of edge k which is the adjacent edge of edge l,m denotes the message function and u is the update function.The models I have looked have a fundamental difference from my model.so the problem is how to realize the propagation of edge features through node.thanks.

This is usually done by converting your graph into a line graph, where edges are now represented as nodes. You can do this via torch_geometric.transforms.LineGraph.

Thanks,But while my model is being trained,LineGraph always fail to work.In the beginning of the traning,the output of LineGraph is linegraph: Data(edge_index=[2, 72], x=[22, 8]) this is ok,but after some steps of training ,the output of LineGraph is
linegraph: Data(edge_index=[2, 234]) ,this is not what i want cause my input graph has 'edge_attr',the corresponding linegraph should have 'x'.So I do not know why sometimes it works but sometimes it doesn't work.
Also,I found sometimes dim of the ouput linegraph is not always the same for the graph in same topology.
Thanks for your reply.

well,there may be something wrong with my data i guess.now it works well and thanks for your reply.


Add service to push data to Google Fit

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I would like to call some services to update some data from Home Assistant to Google Fit.
For example get  weight for a MiScale and push it to Google Fit.
Or use my bed sensor to provide sleep information in Google Fit
Describe alternatives you've considered
I don't think there is other options.
Additional context
I've not tested this custom integration as only read sensors from Google Fit is not my current need. So maybe I've made a mistake with this feature request.

Hi @HydrelioxGitHub,
Right now (and I can't see this changing anytime soon) this integration is just focused on reading data from Google Fit.
Writing data in the way you've asked for has a number of challenges:
Data needs to be pushed to Google Fit in an exact format.

Using your example of Mi Scales, it's very unlikely the data from Mi is in the exact format required to push to Google so some conversion would be required.
So for each data source we would need to do some sort of conversion for every provider.
This is well beyond the scope of this integration.

The only feasible way I can see this happening is if some barebones services were provided and it is up to the user to format the data in the correct way
Update existing scopes
Currently all permission scopes are read-only, and updating them to read/write would be a breaking change that would require all users to re-authenticate the integration. Where possible I try to avoid these (with the exception of adding new sensors).
This could be mitigated by adding a configuration option where a user needs to opt-in to enable write permissions for services.
Code Churn + Testing
Adding this would lead to a lot of reworking the existing code base. Everything seems pretty stable now without any major issues and I wouldn't want to break this functionality. So before this could ever be done I would want some decent testing in place so I could be confident things weren't going to break before releasing it.
Amount of effort
Finally, this sort of change would require a fair amount of time and effort which I don't have right now.
TLDR
There is no definite reason why this couldn't be done in some minimal way but right now it's not a priority. If enough people are clamouring for it, then this can be revisited.

Would like this feature. Not sure I can help for the "core" way to implement it. But if it happens to be done and like for sensor there is a way to help with PR to extend with extra data to send, I will help. ie, when there is for exemple "push weight", I can help to extend with "push activity, push xxx"


Block drops from explosions still merge

From my testing, blocks seem to drop fine from explosions if they are enabled to drop seperate items. Nonetheless, the next release should have an explosion override. It is quite satisfying!


Add documentation in "More complicated POST requests" (Quickstart) to resolve #2686

As suggested in #2686, I added a snippet about requests.post(json=...) to Quickstart#More complicated POST requests.

\o/ Beautiful, thankyou so much! :cake: :sparkles:

Feel free to open a PR that adds you to AUTHORS as well. =)


what is the meaning of valid_category_weight

https://github.com/OpenPerceptionX/PersFormer_3DLane/blob/8d70aa431d9acd67484310299c2208bf98a0ef6c/models/networks/Loss_crit.py#L252
valid_category_weight = torch.sum(gt_category_onehot[:, :, :, 1:], dim=-1).unsqueeze(-1)
Why gt_category_onehot  start adding from 1 instead of 0 ？
How should I understand this  valid_category_weight ？

The first position stands for invalid. valid_categroy_weight includes all valid lanelines to calculate other losses.


OrderCloud provider: ordercloud.cart cookie is not cleaned up after checkout

I am not sure if this is by design for all commerce providers or just with the OrderCloud provider. What I found is that the "ordercloud.cart" cookie (which is the cart/order ID from OC) is still left after the cart has been converted into an order (after a successful checkout). This causes problem for new cart operations because it still re-uses the same OC cart (now it's an order). Some operations are allowed like add/remove lineitems (which is still wrong/dangerous to change the lineitems from an placed order) while others are not (like re-calculate the cart total).
So should the cookie(s), at least the ordercloud.cart, be cleaned programmatically after checkout?

Hey there! Thank you for opening this issue. We have decided to take Next.js Commerce in a new direction and will be closing out current PRs and issues due to this change. Please see this PR for more details: https://github.com/vercel/commerce/pull/966


Update docs page

Setup a nice and comprehensive documentation page.
Closes #24.
Required before publishing first release.

Codecov Report
Base: 54.64% // Head: 54.64% // No change to project coverage :thumbsup:

Coverage data is based on head (5b866db) compared to base (5a3a9ff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   54.64%   54.64%
=======================================
  Files          18       18
  Lines         527      527
=======================================
  Hits          288      288
  Misses        239      239

Impacted Files
Coverage Δ

src/xie.jl
3.92% <ø> (ø)

src/model.jl
95.83% <100.00%> (ø)

src/rotations.jl
95.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adding HA role and tests

1.Adding HA role and tests
2.Removing duplicate task from snmpTraps tests

Besides Chris's comments, it looks okay to me. The READMEs need to be updated, but we've merged the others so far.

I made a changes

@csibbitt Thank,Chris. I will change that.


Subset tab: Reduce precision on the mouseovers on histograms

Example: Plasmodium asexual stages, by microscopy result in PRISM2 Border Cohort. The default bin width is 35919.2, and so if you mouseover, some bins (like the 3rd one in this case) have a lot of digits after the decimal point. The mean in the stats above is being truncated to 4 decimal places, so recommend doing the same here.

For reference, the live site truncates to 2 decimal places, and this may be even better

Discussed with Ryan, Danielle, and Dave on 9.7.21 and decided that the bin ranges on the histogram should have the same precision as the bin width the user specifies.

It seems ok now. closing ticket.

Replicated and tested the issue with the same variable in both PRISM2 Border Cohort and other study.
Instead of truncating decimal, the display format has been changed into scientific (exponential) notation.


pinpoint_force_end_trace() will stuck in infinite loop if node is E_INVALID_NODE

Describe the bug
Function pinpoint_force_end_trace() defined here keep calling pinpoint_end_trace() until E_ROOT_NODE is received. The logic doesn't consider that pinpoint_end_trace() can also output E_INVALID_NODE and make pinpoint_force_end_trace() stuck in infinite loop.
To Reproduce
Steps to reproduce the behavior:

Execute pinpoint_force_end_trace() for invalid node

Actual behavior

Agent stuck in infinite loop

Expected behavior

Output failure and agent should not stuck

Agent Version:
v0.4.11

fixed by v0.4.12


Fix small GUI bugs

Fix scroll bar rounding issue @115
Fix bug of not empty lists just showing small empty space without indication @121

Codecov Report

Merging #191 (a21e1d1) into master (9b52f03) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
- Coverage     34.43%   34.38%   -0.05%
  Complexity      615      615
============================================
  Files           105      105
  Lines          4365     4371       +6
  Branches        719      719
============================================
  Hits           1503     1503
- Misses         2629     2635       +6
  Partials        233      233

Impacted Files
Coverage Δ

...ain/java/unibook/ui/util/CustomPaneListFiller.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b52f03...a21e1d1. Read the comment docs.


Add NLP Cloud API

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks for the contribution @juliensalinas!
Can you please resolve the conflict and squash all your commits?

Thanks @marekdano !
I just resolved the conflict, but I'm unable to squash the commits... I perfectly followed your rebase guide here: https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
But for some reason it's not working for me. I have 6 commits to squash but when doing git rebase -i HEAD~6 I can only see my 3 first commits...
Could you maybe help?
Thanks a lot!

Thanks @marekdano !
I just resolved the conflict, but I'm unable to squash the commits... I perfectly followed your rebase guide here: https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
But for some reason it's not working for me. I have 6 commits to squash but when doing git rebase -i HEAD~6 I can only see my 3 first commits...
Could you maybe help?
Thanks a lot!

Please squash the commits that you can see.

Done @marekdano !
Thanks!
(and if something is still wrong please don't hesitate to let me know).

@juliensalinas can I ask you to create a new PR for NLP Cloud API?
I found that this PR has an extra record of
[Sentim-API](https://sentim-api.herokuapp.com) | Text sentiment analysis | No | Yes | Yes |

which causes Validation_link script to fail because the record is already in README.

Sure, no problem.
Here it is: https://github.com/public-apis/public-apis/pull/1663
Thanks @marekdano !


Need someone to help us improve the front-end, because I am new to front-end.

As title mentioned.

html and css and js need to be refactored.


Can't enter zap amount or enter zap comments anymore

When I click the zap button on the music player, it opens my wallet instead of letting me enter a zap amount and make a comment. Using build 41.

We modified the zap button to support one-tap-zaps (similar to how Damus does it). To reach that amount + comment screen, you can long press the zap button.

this UX seems backwards to me. one tap zaps is more like a power user move, so long press to do that makes more sense imo.

Agreed, added an opt-in toggle for one tap zaps, that way its off by default and power users can enable it ⚡


[Question] Can  we support CNNVD  ?

CNNVD is China's National Information Security Vulnerability Database [3], full name as "China
National Vulnerability Database of Information Security", hereinafter referred to as "CNNVD",
China's Information Security evaluation center is to earnestly implement the functions of Vulnerability
collection and risk assessment, and responsible for the construction of National Information Security
Vulnerability Database operations, providing the basic services to Information Security in China.

CNNVD is larger and more comprehensive, and many CVE does not cover several domestic
manufacturers in China. For example, many Chinese router manufacturers do not have contact
information on CVE, which means the loopholes they encountered are very less likely to be included
in CVE. Most of the medium and small business would choose to report to CNNVD oftentimes. China
has developed rapidly in the field of information security, and the number of enterprises engaged in
network, information and technology has been surging. The influence of them cannot be overlooked.
Therefore, a more comprehensive conclusion can be obtained by combining the two databases for
analysis.

If the anwser is NO. What's the basic steps to implement it myself ?
here is a sample CNNVD data:
<vulnerability>
<number>CNVD-2024-37348</number>
<cves>
<cve>
<cveNumber>CVE-2022-33869</cveNumber>
<cveUrl>https://nvd.nist.gov/vuln/detail/CVE-2022-33869</cveUrl>
</cve>
</cves>
<title>Fortinet FortiWAN操作系统命令注入漏洞（CNVD-2024-37348）</title>
<serverity>高</serverity>
<products>
<product>Fortinet FortiWAN 4.5.0</product>
<product>Fortinet FortiWAN  4.4.0</product>
<product>Fortinet FortiWAN  4.3.0</product>
<product>Fortinet FortiWAN  4.2.5</product>
<product>Fortinet FortiWAN  4.2.1</product>
<product>Fortinet FortiWAN  4.1.1</product>
<product>Fortinet FortiWAN  4.0.0</product>
<product>Fortinet FortiWAN >=4.0.0，<=4.0.6</product>
<product>Fortinet FortiWAN >=4.5.0，<4.5.10</product>
</products>
<isEvent>通用软硬件漏洞</isEvent>
<submitTime>2023-02-20</submitTime>
<openTime>2024-09-04</openTime>
<referenceLink>https://nvd.nist.gov/vuln/detail/CVE-2022-33869</referenceLink>
<formalWay>厂商已发布了漏洞修复程序，请及时关注更新：
https://www.fortiguard.com/psirt/FG-IR-22-157</formalWay>
<description>Fortinet FortiWAN是美国飞塔（Fortinet）公司的一个用于在不同网络之间执行负载平衡和容错的网络设备。Fortinet FortiWAN存在安全漏洞，远程攻击者可以利用该漏洞提交特殊的请求，可以应用程序上下文执行任意命令。</description>
<patchName>Fortinet FortiWAN操作系统命令注入漏洞（CNVD-2024-37348）的补丁</patchName>
<patchDescription>Fortinet FortiWAN是美国飞塔（Fortinet）公司的一个用于在不同网络之间执行负载平衡和容错的网络设备。

Fortinet FortiWAN存在安全漏洞，远程攻击者可以利用该漏洞提交特殊的请求，可以应用程序上下文执行任意命令。目前，供应商发布了安全公告及相关补丁信息，修复了此漏洞。</patchDescription>
</vulnerability>

You would be able to add it with an additional analyzer.
The primary extremely difficult task, based on what you quote here would be linking a given library and its version to the free text 'product' of the CNNVD data.
For some basic references see https://jeremylong.github.io/DependencyCheck/dependency-check-plugin/index.html for the project-starter (maven-archetype) for a DependencyCheck plugin library project in case you build with Maven.
And see the wiki for a quick intro into creating your own analyzer: https://github.com/jeremylong/DependencyCheck/wiki/Making-a-new-Analyzer (you can also cross-reference the various analyzers of the project at
https://github.com/jeremylong/DependencyCheck/blob/main/core/src/main/java/org/owasp/dependencycheck/analyzer
You would likely need something similar to
https://github.com/jeremylong/DependencyCheck/blob/main/core/src/main/java/org/owasp/dependencycheck/analyzer/CPEAnalyzer.java in order to somehow decide on the 'Product(s)' of CNNVD that should be associated to a discovered library (if any) as well as an analyzer similar to NVDAnalyzer or OssIndexAnalyzer to resolve all the vulnerabilities registered against the identified product.
Given the very informal text-based 'product' attribution of affected products in CNNVD I do not see a benefit on adding it in the core (it's likely to either cause even more false-positive product-matches that our current logic that attempts to link to the known products (CPEs) of the NVD or have a high risk of false negatives (if matching is so strict (to avoid false positives) that true matches also don't match in various cases))

Also note that 'router manufacturers' would for this project in any case be irrelevant, as those concern hardware device vulnerabilities and this project only scans for vulnerabilities in software dependencies (it also skips any CPEs in the NVD data that do not denote an application (it filters that data to only use the CPEs having an 'a' (Applications) for 'part' (skipping 'h' (Hardware devices) and 'o' (Operating systems))

to my little understanding, I feel a bit confused that the start point you mentioned was "additional analyzer".
basically CNNVD is NVD + China domestic data, so I was thinking the best way is to  add the extra data from CNNVD to dependency-check's database and lucence index, then anything should work as is.
to make this work, I need:

identify overlaps between NVD and CNNVD, and exclude them
exclude irrelevant data, such as hardware vulnerabilities
lode filtered CNNVD data into dependency-check's database

@aikebah need more comments from you.

Deo

You're likely misunderstanding 'the CVD DB' as 'the source from which ODC gets its vulenrabilities'. Now in the distant past that would've been true, as NVD back then was the only source of vulnerability information.
But conceptually the database is 'simply' a cache for the NVD data (besides a few pieces of meta-information).
Nowadays we have multiple vulnerability repositories, each with their own caching mechanisms:

NPM (NodeAuditAnalyzer, NodePackageAnalyzer, PnpmAuditAnalyzer, YarnAuditAnalyzer) - uses the Node Audit API
RetireJS (RetireJsAnalyzer) - uses a locally cached RetireJS.json
OSSIndex (OssIndexAnalyzer) - uses the OSSIndex provided client library with caching function
Ruby Advisory Database (RubyBundleAuditAnalyzer) - uses the ruby bundler audit command
NVD (NVDCveAnalyzer, with some preparatory work by the CPEAnalyzer to massage the raw evidences into CPEs) - lookups are done at the local cache of the NVD API data which is cached in the CveDB database.

Each of the mentioned analyzers is responsible for determining which (if any) registered vulnerabilities in its backing repository are relevant to a dependencies being analysed. And each analyzer specializes in building the correct representation of the software libraries being analyzed targeted at getting the data from that vulnerabilities repository in the best possible way (based on how software components are identified in the given repository).
You also appear to misunderstand the role of the NVD with respect to the CVE process by stating that CNNVD is NVD plus some more. The CNNVD is not 'the NVD + China domestic' but ,similar to OSSINDEX, 'CVE list public vulnerabilities + own research/reporting without CVEs' (the NVD is listing only 'public CVE list vulnerabilities').
The CVEs as such are not what the NVD holds, those are under the governance of the CVE program (https://www.cve.org/) and governed by MITRE corporation. The NVD holds the enrichment of the published CVEs with affected configuration coordinates using the NIST-governed Common Platform Enumeration and the NVD reviewed/validated (potentially adjusted from the original reported vector) CVSS scoring.

thanks, that's very helpful.


Small improvements in command-line and ActionInstance creation

This PR adds some small improvements:

Fix(command-line): Now when using just the up command it's equal to up -h (instead of NotImplementedError)
Added-check(ActionInstance): Added check where the actual parameters of an ActionInstance must be constants

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (12ae998) 85.02% compared to head (ef69564) 85.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   85.02%   85.02%   -0.01%
==========================================
  Files         198      198
  Lines       26071    26073       +2
==========================================
+ Hits        22168    22169       +1
- Misses       3903     3904       +1

Files
Coverage Δ

unified_planning/io/pddl_writer.py
85.15% <100.00%> (ø)

unified_planning/cmd/up.py
9.61% <0.00%> (ø)

unified_planning/plans/plan.py
92.10% <66.66%> (-1.14%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Change Group Add and Remove API

Changing the Group add and remove API to accept a connectionId instead of a ConnectionContext. This lets you remove any connection from a group.

@mikaelm12,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

IMHO the group functionality needs wider discussion around the process of allowing/granting a connection to a group, which may/may not be via a SignalR message/reponse to the owner/creator of group or some claims based logic prior to adding the connection.


Json diff

It would be really handy for debugging and error reporting to have the possibility to compute the difference between two Json values.
I would love to migrate to Circe but I need this feature, therefore I am still using Json4s which has a diff API returning:
Diff(changed: JValue, added: JValue, deleted: JValue) see implementation here
Maybe there is already a way of achieving this easily?
Thank you for this nice library.

I've been meaning to provide something similar to this powered by delta, which already includes a module for Argonaut that should be fairly straightforward to adapt for circe.
It doesn't provide exactly the same kind of diff as Json4s, though, but it has support for both JSON Patch and a compressed representation, and I'd guess it shouldn't be too hard to adapt one of those formats to do what you need.

Just wanted to share for the people interested in this feature that I was able to port the Json4s implementation to Circe.

Check this PR for some code.

There's https://github.com/gnieh/diffson which will support circe very soon.

There's https://github.com/gnieh/diffson which will support circe very soon.

Support for circe was just merged. Version 2.1.0 with this support will be released next week.

diffjson looks great, I will definitely try it 👍

Coming back to you guys with some update.
I have been using successfully diffson as alternative and it is working great for me so far.
From my perspective this issue can be closed from the time being.
Thanks @satabin for the sweet lib 👍

Glad it helps. Do not hesitate to report bugs or ask for enhancements if you find anything.


Remove FAQ from www.jabref.org/FAQ

The FAQ is now part of the help pages (https://help.jabref.org/en/), so:

[x] the link in the Help section of the website (https://www.jabref.org/#help) should be updated
[x] the URL http://www.jabref.org/faq/ should redirect to the help page index (https://help.jabref.org/en/)

I removed the FAQ from the Website section and added a redirect link to http://help.jabref.org/


siad crashes whenever trying to unlock wallet

I'm running siad headless on a Digitalocean 512MB RAM node and every time I try to unlock the wallet it crashes siad.
curl -A "Sia-Agent" "localhost:9980/wallet/unlock" --data "encryptionpassword=mypassword"
The message siad gives before exiting:
Rescanning consensus set...
Scanned to height 46039...Killed

Increase ram or swap

jul. 2016 3:42 p.m. skrev "Bitcoin Co. Ltd."<EMAIL_ADDRESS>

I'm running siad headless on a Digitalocean 512MB RAM node and every time
I try to unlock the wallet it crashes siad.
curl -A "Sia-Agent" "localhost:9980/wallet/unlock" --data
"encryptionpassword=mypassword"
The message siad gives before exiting:
Rescanning consensus set...
Scanned to height 46039...Killed
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NebulousLabs/Sia-UI/issues/356, or mute the thread
https://github.com/notifications/unsubscribe/ABfjO9FutyHD9Ay2UraznuFa6dYd6wBCks5qS7DbgaJpZM4JGF1O
.

Killed means that the kernel killed the process for using too much memory.
Sia needs a machine with at least 4 GB of RAM and 4 GB of swap.

4GB of RAM and 4GB of swap is insanely high for a headless daemon...

bitcoind uses more iirc

This will likely be addressed when we make improvements to the wallet. Still 512MB of RAM may cause issues since we use multiple mmap'd Bolt databases.

I would say 2 & 2 is plenty, even when running the explorer. Which reminds
me: Check the -M switch for siad and disable modules you dont need.

jul. 2016 3:49 p.m. skrev "Bitcoin Co. Ltd."<EMAIL_ADDRESS>

4GB of RAM and 4GB of swap is insanely high for a headless daemon...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NebulousLabs/Sia-UI/issues/356#issuecomment-230776858,
or mute the thread
https://github.com/notifications/unsubscribe/ABfjO1DOijTW85qqoJGuyOw6VsqG9eOVks5qS7KHgaJpZM4JGF1O
.

If you really want to run it on a digitalocean droplet you may get away with setting up 5 GB of swap. But remember that that will make Sia very slow.
https://www.digitalocean.com/community/tutorials/how-to-add-swap-on-ubuntu-14-04

Added a 6GB swap and that works to unlock the wallet (looking at the memory usage 1GB of swap would probably have been enough)

When you start uploading files it will start using more.
Back with version 0.5 I added 6 GB of swap too and it still ran out of memory, but that may have improved since then. I have not personally tried to run 1.0 on digitalocean yet

Closing since the issue doesn't really concern the Sia-UI and appears to have a work around.


Cannot set or change a profile photo only

Description
Save button is disabled if just set or change a profile photo and don't change any other account info.
Steps to reproduce
Have a registered account
Steps to reproduce

Go to My profile -> Edit profile
Change or set a photo

Actual result: Save button is disabled and you cannot save the changed photo without changing any other information
Expected result: The Save button should be enabled if a photo was changed.
Supporting data
https://screencast.com/t/ovJOmnEXgv
Alpha2 https://dapp.gooddollar.org
Chrome 75.0.3770.142

@Nordwhale this is not a bug, once you set the image it is saved, you don't need to press the save button


Multiple Nuimo devices

It would be useful if the nuimo that emitted a certain event would include itself as the sender in emit to identify which nuimo sent the e.g. rotate event.
Using the new ES6 syntax, this does not work anymore:

It is possible to use ES6 Arrow Functions as listeners, however, when doing so, the this keyword will no longer reference the EventEmitter instance

Hi @wind-rider,
Thanks for that, and good point. I don't want to break compatibility however, so would having a pointer as the last argument in the list suffice? This way people don't need to change their scripts. Although it does somewhat hinder future compatibility.

I would say that people not wanting to change their scripts can simply stick to the current version of the package?
So you can update your package and people can decide whether they want to update.

Can you provide an example where you have no access to scope that contains sender information?
eg. In the provided examples (ie. emit.js), the listeners are attached inside a scope which contains a "device" object, which refers to the emitting device.

Closing due to inactivity.


Added code to make init.py, so python client libraries work

If init.py is not created in /kb/deployment/lib/biokbase/AbstractHandle/, python will complain about not being able to find the library when you try to import it.

Has this been tested on a fresh clone? My concern is that under certain conditions, the lib/biokbase directory will not exist when the system call to touch occurs.

Put differently, when is the biokbase directory created?

You're right, I fixed it so touch is done after compile_typespec (which makes the dir).  Tested on a fresh clone.

Thanks for checking it out.


chore: project addition by AdityaLahane-2003

Add a new project to the list
Add new Full stack project and API based project to the list.
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

This issue has been closed because it has not received any activity in the last few days


perform firmware update for all shelly devices at once

Is your feature request related to a problem? Please describe.
no <!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
--> no issue
Describe the solution you'd like
I would like to see a button in HA to perform Firmware Updates of all shellys on a single click
Additional context

You can create a script to trigger update for all update entities, this feature will not by implemented in the script.


rooch move run --dry-run flag did't work

Rooch version
rooch 0.7.6 (git commit e5ba2429862ad18b84e283cffa13ac99b49a71d7)
What did you do?
❯ rooch move run --function $PKG::gold_miner::start --args "object:$TREASURY" --args "address:$SENDER" --dry-run
What did you see happen?
Error: Parse error: missing field da_server_status at line 1 column 1687
missing field da_server_status at line 1 column 1687
What did you expect to see?
正常返回输出信息

The mainnet need to be upgrade. cc @popcnt1 @steelgeek091

fixed


Sharing computing power in a decentralized P2P network

To have a feature built into Ollama to join the Ollama P2P network. When you join this network, you can use computing power from others in the network and also share your computing power.
Privacy should be in mind by using E2EE, choosing which models on your system is apart of the P2P network, settings to disable and enable the use of the P2P network and if the users feature becomes a thing, to allow users the setting on weather to be apart or use this P2P network when working with models.
Twinny Symmetry Project
https://twinny.dev/symmetry

ollama is already listed as an Inference provider in twinny.

It would be also an good idea to share computing power in a private LAN.


Text ill-aligned when emojis are present

Description
- Without emoji.
- With emoji #emoji.thumb.down
- Without emoji.

In the web app it's subtle:

Locally, compiling to pdf (the emoji is not there, I don't know why, but anyway the alignment problem is visible):

Locally, previewing with VSCode + tinymist:

My environment: typst 0.11.1 and macOS Sonoma 14.4.1
Reproduction URL
No response
Operating system
macOS
Typst version

[X] I am using the latest version of Typst

Another local combinations:
#set text(font: ("Helvetica", "Apple Color Emoji"))

- Without emoji.
- With emoji #emoji.thumb.down
- Without emoji.

#set text(font: ("Helvetica", "Noto Color Emoji"))

- Without emoji.
- With emoji #emoji.thumb.down
- Without emoji.

Neither of them correctly exports the emoji to pdf.

The alignment problem is probably due to similar cause as the motivation here: https://github.com/typst/typst/issues/4224
The PDF export doesn't work in 0.11.1, but should work on main.

In combination, this is a mix of:

https://github.com/typst/typst/issues/1204
https://github.com/typst/typst/issues/4224
https://github.com/typst/typst/issues/144

I've reading the linked issues and I agree. Interesting reading, BTW, but what a rabbit hole...
pdf output of typst 0.11.0 (d84a7e42):

With Apple Color Emoji:

With Noto Color Emoji:

So:

Alignment is off as expected per https://github.com/typst/typst/issues/1204, but for Noto this is subtler.
pdf output is fixed.
The weird clipping of Noto is fixed.


feat: Update markdown editor to render md live in editor

Can switch between preview/edit mode

Hey @liuhuapiaoyuan what we're looking for here is instead to have a single view where users can edit and view the rendered markdown, like in Notion (included video below). What you put up is a little different, where it displays the editing and viewing state at the same time.
https://www.loom.com/share/e30a816d9391450e925f67c7a47125db?sid=c6c0c8a9-77b2-4765-ba32-05989f51b79a

You can try : https://templates.tiptap.dev/TFcjrd9thK

@liuhuapiaoyuan yes that would work!!

@liuhuapiaoyuan yes that would work!!
I am going to implement this feature, is that okay?

Closing in favor of #65


Implement HCA

https://github.com/apple/foundationdb/blob/master/bindings/go/src/fdb/directory/allocator.go
Implement HCA(high contention allocator), which is a building block for directory layer. There is a hca test on bindingtester[1] so we can test our implementation with the tester.
[1] https://github.com/apple/foundationdb/blob/master/bindings/bindingtester/run_tester_loop.sh#L12-L13
related: https://github.com/bluejekyll/foundationdb-rs/issues/27

We can start working on this after following PR: #54, #50

This can be closed now

Cool, thanks.