Test documented builds

Test build modes that we document.
I believe that with this PR, we're testing all the non-debug build modes that we document in README.md or configs/README.txt.

-DMBEDTLS_CONFIG_FILE="…"
Shared library build with cmake (we were only testing a shared library build with make)

I just noticed that CI on -merge failed with a relevant error. Demoting to "needs work".

The new tests revealed a bug in code recently added to development, so I rebased on top of development and fixed that bug.


Binding custom function fails to compile if function has more than three arguments

For instance adding the following to test/test_functional_bind.cpp causes a compiler error:
BOOST_AUTO_TEST_CASE(bind_more_than_four)
{
    int data[] = { 1, 2, 3, 4 };
    compute::vector<int> vector(data, data + 4, queue);

    BOOST_COMPUTE_FUNCTION(int, add_four_nums,
                           (int first, int second, int third, int fourth),
    {
        return first + second + third + fourth;
    });

    compute::transform(
        vector.begin(), vector.end(), vector.begin(),
        compute::bind(add_four_nums, _1, 2, 3, 4),
        queue
    );
}

The full error and build log can be found here: https://pastebin.com/MnHi2WZs. I am using ubuntu 18.04 with libboost1.65-dev and g++ 7.4. This reproduces for a variety of different argument types etc.
As far as I know, the best work around is to adapt a struct which contains to arguments.

This occurs because in this section, the number of arguments only go up to three.

Can you try enabling C++11 for Boost.Compute by defining BOOST_COMPUTE_USE_CPP11? This should enable the variadic template version from line 221. If you need C++03 version you can create PR to add versions with more arguments, or do in your code.

I was incorrect about the code causing this issue. The actual issue is in this section: https://github.com/boostorg/compute/blob/master/include/boost/compute/functional/bind.hpp#L145. The issue isn't resolved by enabling c++11 because there is no variadic template version of apply_invoked_bound_function. I don't know how to use variadic templates to generalize apply_invoked_bound_function, but I would be happy to make a pr to add additional versions of the function up to some larger number of arguments.


Shutdown cluster cleanly when SIGTERM or SIGINT is received

Previously, if a developer working with Wallaroo sent a SIGINT via
ctrl-c in the terminal, Wallaroo would exit but wouldn't gracefully
shutdown. This could lead to errors on the next application startup as
recovery files weren't dispose of properly.
With this commit, sending SIGTERM or SIGINT will shut down Wallaroo
gracefully in the same fashion that the external "shutdown cluster"
command work.
Once we have "shrink to fit" in place, the plan would be to have SIGTERM
and SIGINT remove that individual worker from the cluster rathter than
shut the entire cluster down. Once we have shrink to fit in place, we
might change our mind and go in a different direction and leave this
functionality as is.
Closes #1701

To test, use the Python alphabet partitioned and alphabet examples.
Start up each, verify recovery files exist in /tmp
Do ctrl-c to shutdown
verify that files no longer exist.
In the case of alphabet partitioned, you should test by doing ctrl-c on different workers.


Implement universal notification mechanism (NEW)

Without this patch, kured can only notify via slack.
This patch gives the possibility to send notifications
across different technologies. Also, this patch makes
slack-hook-url, slack-username and slack-channel
deprecated (informed by a warning).
Also, updated the documentation (Readme).

Added to a kind ds:
          command:
            - /usr/bin/kured
            - --period=15s
            - --notify-url=rocketchat://<my_local_rc_instance>:3000/<tokenA>/<tokenB>/general

this was the result after triggering a reboot on the first kind worker:
kured-bot
Bot
12:17 PM
Draining node kind-worker

kured-bot
Bot
12:17 PM
Rebooting node kind-worker

I can volunteer to do some manual testing of this next week. Ping me @atighineanu if you don't hear back.

@atighineanu can you add more detail about the fact that this PR proposes to replace the slack-specific notification implementation with a generic notification interface built upon the shoutrrr project?
It would help to provide some detail on the state of that project, including any supporting evidence that it is healthy and committed to sticking around for the long haul.
Thanks!

@atighineanu can you add more detail about the fact that this PR proposes to replace the slack-specific notification implementation with a generic notification interface built upon the shoutrrr project?
It would help to provide some detail on the state of that project, including any supporting evidence that it is healthy and committed to sticking around for the long haul.
Thanks!

I am keeping an eye and I am among the maintainers over there. The team is chill and last time @dholbach found some issue for one of the messaging technologies - I fixed it and it was merged on the same day.
Also, this specific PR IS NOT replacing the slack-specific notification method. First, I thought it would make sense to make a warning about deprecation. IF both flags are used - then notify-url has priority. But one can still use the slack-url flag.
Next step would be to actually replace the slack-url flag in the flagcheck function (and remove the obsolete slack package).

I rebased on master and pushed to docker.io/weaveworks/kured:atighineanu-master-4d715b8. Will test it in our Dev env.

docker.io/weaveworks/kured:atighineanu-master-e95953b is up for testing.

^ This was with 4d715b8.

In Dev using the latest.

@atighineanu Thanks for your work on this! The PR looks good to me - can you git pull --rebase one more time and fix the conflict?


Add a Gitter chat badge to README.md

Septima/fikspunktsregister now has a Chat Room on Gitter
@bjornharrtell has just created a chat room. You can visit it here: https://gitter.im/Septima/fikspunktsregister.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Hmm not sure why this is not triggering build on CI.


Add next aarhus meetups

Thanks for letting me know @luxas!
I didn't catch that the generator was already online.
I will fix accordingly.


opam-nix does not error out when pinning dependencies failed, making debugging difficult

I would like there to be better error handling when pinning dependencies. I had added a *.opam.template file and the opam file was updated after running dune build. The OCaml environment built successfully, but the pinned dependency was not at the specified version. It turns out that there was an error when pinning the dependency which I only discovered when trying to build the repository with vanilla opam. The error was caused by the fact that the repo that I pinned contained multiple packages which my project depended on, so there was a bounds issue until I added a pin-depends entry for each package in the repo.
I hope I managed to explain what happened clearly enough.
Describe the solution you'd like
Vanilla opam actually fails in this scenario, so at the very least I would like there to be a message that pinning the dependencies failed

Can you provide an example?

https://github.com/kentookura/opam-nix-pins

Note that pinning ppx_irmin is necessary even though the project has no explicit dependency on that library.


problem with switch camera during live stream with the RTMP

when I live stream with the RTMP link it's successful but when I switch the camera to front it also has a disconnected stream.

This is working fine for me.
I need know more to find the error.

Device model and Android API used.
Did you tested with my app in my last commit? If not, share me a code example to reproduce the problem
Which mode are you using? (camera1, camera2, fromfile or display)
Which view are you using (openglview, lightopenglview, surfaceview, textureview, only context)
Can you share me a full logcat when you have the problem?

Thank brother for your reply but now it's work that mistake by me has a modifier some code on camera1 that effect to function switch camera.


Remove unnecessary files from the conda installation.

The .pyc and .a files take up approximately 32MB of space in the initial installation. The initial installation also contains __pycache__ directories. Deleting these will save some space.
https://github.com/conda-forge/miniforge-images/blob/master/ubuntu/Dockerfile

Use find /opt/conda -follow  -name '__pycache__' -delete && find /opt/conda -follow  -name '*.a' -delete.

Also add the force flag to package cleaning. This may or may not be useful.

Not worth the effort. Caches are included in newly installed packages as well. Also, a few dozen MB is small compared to the many GB that even the smallest CUDA images have.


[Perf] Avoid Service Provider lookups when activating common Singleton properties of a Razor Page

Fixes #4244
Some of the common singleton properties that are activated on a Razor Page for every request are of types IJsonHelper, HtmlEncoder, DiagnosticSource, IUrlHelperFactory. For every request, these properties are activated by looking up in the service provider. The cost of these lookups can be avoided by special casing their activation in RazorPageActivator.
Scenario: https://github.com/aspnet/Performance/tree/dev/testapp/HelloWorldMvc
bottom up sampling of Hello World MVC app
Before optimization

After optimization

:watch: for slight cleanup

In your after measurement, there's still a significant chunk of time spent in <CreateActivateInfo>__b_5 - can you include the rest of the data? What is that doing?

They are for IViewComponentHelper and IHtmlHelper  which are transient services.

:up::date:

:shipit:


WIP: Add travis build to lint and package Helm chart

let's add the discussed (type != pull_request) AND ((branch = master) OR (tag IS present)).


[local_auth] Fix getEnrolledBiometrics returning non-enrolled biometrics on Android.

This PR fixes the issue where the Android implementation of getEnrolledBiometrics returned biometrics that have present hardware on the device, but are not enrolled. This brings it in line with the behaviour on iOS.
Relevant issue:

Fixes flutter/flutter#45497

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Shouldn't the README be changed?

@RafaRuiz This PR has already been submitted, so cannot be changed; if there are other changes to make please file an issue.


Please clarify the sense of tasks.named { ... } opposed to tasks.matching { ... }, also in release notes, resp. actually make them behave different

Current Behavior
I know that you usually do not modify published release notes, but the release notes for 8.6 are plainly wrong.
They state that tasks.matching { it.name.contains("pack") }.configureEach { ... } does realize all tasks which is not true.
And that due to that tasks.named { it.contains("pack") }.configureEach { ... } was introduced in 8.6 to mitigate that problem.
But these statements are plainly wrong.
tasks.matching { it.name.contains("pack") }.configureEach { ... } did never and still does not realize any additional tasks.
tasks.matching { it.name.contains("pack") }.forEach { ... } causes all tasks to be realized.
But so does tasks.named { it.contains("pack") }.forEach { ... }.
tasks.matching { it.name.contains("pack") }.all { ... } causes all tasks to be realized.
But so does tasks.named { it.contains("pack") }.all { ... }.
val packs by tasks.registering { dependsOn(tasks.matching { it.name.contains("pack") }) } causes all tasks to be realized.
But so does val packs by tasks.registering { dependsOn(tasks.named { it.contains("pack") }) }.
I would have hoped tasks.named { ... } can actually work without realizing tasks in situations where tasks.matching cannot, for example when using forEach or all or dependsOn, as there only the name should be necessary and not the whole element like with matching.
But as it is currently, as far as I have seen both behave exactly identical and you just have two ways now to do exactly the same with exactly the same sideeffects.
Expected Behavior
The release notes should not state the false fact that confuses users reading that.
Optimally, the named { ... } would be reworked to not force-realize any unmatched tasks even if eager APIs like all or forEach or dependsOn are used, as this should be totally unnecessary and then actually be a significant improvement over tasks.matching.
Gradle version
8.6

Here is another user wondering about the same: https://discuss.gradle.org/t/question-regarding-8-6-release-notes-tasks-named/47865

@mgroth0 I think any attempt to use TaskContainer iteration "default" method , like size(), iterator() causes realization of tasks.
So in your example, even simple line like(groovy):
def filtered = tasks.named { itn ->
        println("$itn:\tNamed referenced in `named`")
        return itn.contains("subPack")
    }

println "filtered=${filtered.size()}"

So the only way to correctly iterate this Iterbale is by
configureEach

But the later can't be used in register context
tasks.register("packs") { it->

    println("$it:\tregistering")

    filtered.configureEach { f ->
        t.dependsOn f
    }
}

throws an exception:
A problem occurred configuring root project 'kotlin-registering-gradle'.
> Could not create task ':packs'.
   > DefaultTaskCollection#configureEach(Action) on task set cannot be executed in the current context.

Seems like a deadend or desisgn  hole  :worried:

Yes, as I said, it behaves exactly identical to matching as far as I have seen.

Thank you for raising this, we are investigating the issue.

@Vampire, you are correct, the release notes are wrong. I've written a fix and will try to fix the already released documentation.
In a nutshell, yes, when you just call matching() or named(), they behave the same way, until you iterate the filtered task container they produce. Once you do that matching() has unpleasant side-effects, because it triggers the creation of ALL lazy tasks in the original container, regardless if they have been filtered out or not. named() doesn't have this flaw.
Please let me know if you still have issues with the fixed version of the release notes.

@jbartok as I said, in 8.6 both behave identical while I hoped for the behavior / difference you described which unfortunately is not the case.
For example:

do gw init --use-defaults
add to the build scripttasks.configureEach { println("configured $path") }
tasks.named { it == "help" }.all {}

run gw -m

Output:
> Configure project :
configured :help
configured :projects
configured :tasks
configured :properties
configured :dependencyInsight
configured :dependencies
configured :buildEnvironment
configured :components
configured :model
configured :dependentComponents
configured :outgoingVariants
configured :resolvableConfigurations
configured :javaToolchains
configured :prepareKotlinBuildScriptModel
configured :init
configured :wrapper
configured :kotlinDslAccessorsReport
:help SKIPPED

Same if you change the build script content to
tasks.configureEach { println("configured $path") }
val foo by tasks.registering {
    dependsOn(tasks.named { it == "help" })
}

and do gw foo.
Output:
12:14:48: Executing 'foo'...

configured :foo
configured :help
configured :projects
configured :tasks
configured :properties
configured :dependencyInsight
configured :dependencies
configured :buildEnvironment
configured :components
configured :model
configured :dependentComponents
configured :outgoingVariants
configured :resolvableConfigurations
configured :javaToolchains
configured :prepareKotlinBuildScriptModel
configured :init
configured :wrapper
configured :kotlinDslAccessorsReport

> Task :help

Welcome to Gradle 8.6.
[...}
> Task :foo

Also same with 8.7-rc-2.
I can not see any difference in behavior between using matching or named.

@Vampire, you are correct in everything you said, I'm sorry that it took me so long to reach the same conclusion. In my defense, we have tests for the behavior we aimed for, but apparently we shot ourselves in the foot with them, because they are broken in subtle ways... That's not really an excuse, just saying. We will strive to fix the situation as soon as we are able.


⚠ Bofrost.de has degraded performance

In 4af5613, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1552 ms

Resolved: Bofrost.de performance has improved in 56b0b42 after 36 minutes.


Upload pretrained model to run inference

It would be great if anyone could upload a pretrained model so that we could try this model/project without needing to train the model. It is quite a big commitment to wait a week for training (as mentioned in #10 ) if you primarily just want to check out the performance on some .wav files.
And I would also like to say this repo is very well written and educational. Thanks!

It would be great if anyone could upload a pretrained model so that we could try this model/project without needing to train the model. It is quite a big commitment to wait a week for training (as mentioned in #10 ) if you primarily just want to check out the performance on some .wav files.
And I would also like to say this repo is very well written and educational. Thanks!

Hi, please try this one, trained for 500,000 iterations on the MAESTRO dataset.
I haven't touched the model in a while, but torch.load('model-500000.pt’) should be able to load the PyTorch model.

The provided file works great, thanks a lot! I didn't need to use torch.load('model-500000.pt’) since both evaluate.py and transcribe.py has the model file as an argument.

However, after I first got this error message when trying the run the scripts:

Traceback (most recent call last):
  File "transcribe.py", line 101, in <module>
    transcribe_file(**vars(parser.parse_args()))
  File "transcribe.py", line 74, in transcribe_file
    predictions = transcribe(model, audio)
  File "transcribe.py", line 53, in transcribe
    onset_pred, offset_pred, _, frame_pred, velocity_pred = model(mel)
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
    result = self.forward(*input, **kwargs)
  File "/Users/greenbech/git/onsets-and-frames/onsets_and_frames/transcriber.py", line 87, in forward
    onset_pred = self.onset_stack(mel)
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
    result = self.forward(*input, **kwargs)
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/container.py", line 100, in forward
    input = module(input)
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
    result = self.forward(*input, **kwargs)
  File "/Users/greenbech/git/onsets-and-frames/onsets_and_frames/lstm.py", line 29, in forward
    output[:, start:end, :], (h, c) = self.rnn(x[:, start:end, :], (h, c))
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
    result = self.forward(*input, **kwargs)
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/rnn.py", line 558, in forward
    result = _VF.lstm(input, hx, self._flat_weights, self.bias, self.num_layers,
  File "/Users/greenbech/.pyenv/versions/3.7.5/lib/python3.7/site-packages/torch/nn/modules/module.py", line 576, in __getattr__
    type(self).__name__, name))
AttributeError: 'LSTM' object has no attribute '_flat_weights'

Downgrading to torch==1.2.0 fixed it for me.
It is also quite cumbersome to resample to the audio file to 16kHz before hand, so I added this locally to transcribe.py:
def float_samples_to_int16(y):
  """Convert floating-point numpy array of audio samples to int16."""
  # From https://github.com/tensorflow/magenta/blob/671501934ff6783a7912cc3e0e628fd0ea2dc609/magenta/music/audio_io.py#L48
  if not issubclass(y.dtype.type, np.floating):
    raise ValueError('input samples not floating-point')
  return (y * np.iinfo(np.int16).max).astype(np.int16)

def load_and_process_audio(flac_path, sequence_length, device):

    random = np.random.RandomState(seed=42)

    audio, sr = librosa.load(flac_path, sr=SAMPLE_RATE)
    audio = float_samples_to_int16(audio)

    assert sr == SAMPLE_RATE
    assert audio.dtype == 'int16'
    ...

There might be elegant ways of doing this, but I was not able to convert to uint16 with librosa or resample with soundfile.read.
I also think the the model you provided should be available in the README for others to try out without going to this issue. I was thinking either directly in ./data/pretrained since this it the easiest setup but increases the repo size unnecessarily or with the drive url you provided.
Would you mind a PR with this?

Yeah! I'll need some housekeeping to make the checkpoint work cross-version. PR is welcome! Thanks :D


Rails query generator not found

Bug report:

Expected Behavior:
rails generate query [e.g. User] should generate a UserQuery object in app/queries.
rails generate --help should confirm the existence of the query generator

Actual Behavior:
bundle exec rails generate query User => Could not find generator 'query'.
rails generate --help | grep query shows nothing

Steps to Reproduce:

Create or open a Rails 6 application
Install the gem using bundle add arqo or gem install arqo
Run rails generate query [e.g. User]

Version of the repo:
0.2.0

Ruby and Rails Version:
Ruby 2.6.3
Rails 6.0.0

Hey @Joseph-Burke thanks for the detailed report! I think #19 fixes it in case you want to try it out

Thank you!


Slight lag after tapping segment?

@xaviermerino , it seems for some reason that I have a bit of a lag after tapping a segment. Do you have any idea what could be causing this?  No heavy lifting is being done through this transition on the app's end so it shouldn't be slow. I used to have a tab bar controller in its place and it was instantaneous. I LOVE your controller so I want to make it work :). I have included a video below.

I've never seen such a thing. Although I've noticed that you have changed the highlight bar's dimensions. (Or is the frame that is not as wide as the parent controller?) Could you send me a code example where you isolate the issue? I'm really intrigued.

Not quite, its actually a bit weird because I wanted it in my navigation bar so i literally set the titleView to it:
`let segmentedControl = XMSegmentedControl(frame: CGRectMake(0, 0, navigationController!.navigationBar.frame.width, navigationController!.navigationBar.frame.height - 2), segmentTitle: ["Services","Appointments"], selectedItemHighlightStyle: XMSelectedItemHighlightStyle.BottomEdge)
segmentedControl.backgroundColor = UIColor.clearColor()
segmentedControl.highlightColor = kPrimaryColor//UIColor.lightGrayColor()
segmentedControl.tint = UIColor.darkGrayColor()
segmentedControl.highlightTint = kPrimaryColor
    segmentedControl.delegate = self
    navigationItem.titleView = segmentedControl`

I've used it in the navigation bar before without any issues. You can see from the picture I'm attaching.
If you let me see a portion of the code in which you are embedding it into the navigation bar I could help you figure it out.
Sent from my iPhone

On Jun 22, 2016, at 4:31 PM, aerose2012<EMAIL_ADDRESS>wrote:
Not quite, its actually a bit weird because I wanted it in my navigation bar so i literally set the titleView to it:
`let segmentedControl = XMSegmentedControl(frame: CGRectMake(0, 0, navigationController!.navigationBar.frame.width, navigationController!.navigationBar.frame.height - 2), segmentTitle: ["Services","Appointments"], selectedItemHighlightStyle: XMSelectedItemHighlightStyle.BottomEdge)
segmentedControl.backgroundColor = UIColor.clearColor()
segmentedControl.highlightColor = kPrimaryColor//UIColor.lightGrayColor()
segmentedControl.tint = UIColor.darkGrayColor()
segmentedControl.highlightTint = kPrimaryColor
segmentedControl.delegate = self
navigationItem.titleView = segmentedControl`

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I think I included that code in the last comment. Its just one line of code to embed it
navigationItem.titleView = segmentedControl

Is there something else that would be helpful? I am happy to provide it, I super appreciate your willingness to help!

I used something like self.navigationController?.navigationBar.addSubview(segmentedControl)
I apologize for the crappy image. Hopefully this will help.
Sent from my iPhone

On Jun 22, 2016, at 5:19 PM, aerose2012<EMAIL_ADDRESS>wrote:
I think I included that code in the last comment. Its just one line of code to embed it
navigationItem.titleView = segmentedControl
Is there something else that would be helpful? I am happy to provide it, I super appreciate your willingness to help!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Interesting, I added it the way you just said and now it spans the entire width of the navigationbar but the lag still exists. So strange, i have NO idea what could be causing this :/.

Hmm I'll give it a try again and see if I get a lag. Because I can't get to replicate your issues.
Sent from my iPhone

On Jun 22, 2016, at 5:40 PM, aerose2012<EMAIL_ADDRESS>wrote:
Interesting, I added it the way you just said and now it spans the entire width of the navigationbar but the lag still exists. So strange, i have NO idea what could be causing this :/.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@xaviermerino It seems that the segmentedControl might be receiving the touch event slowly. Is it possible that in the navbar, the touch event is taking a while to be passed to the control?

I have never heard of such a thing. and I'm guessing you haven't played with the user interaction properties and stuff like that in this project, so this shouldn't be an issue. I have my segmented control embedded there just fine. Is there a way for you to send me a small demo of the problem. Like a small project that has that problem. So I can try and figure it out
Sent from my iPhone

On Jun 24, 2016, at 10:13 AM, aerose2012<EMAIL_ADDRESS>wrote:
@xaviermerino It seems that the segmentedControl might be receiving the touch event slowly. Is it possible that in the navbar, the touch event is taking a while to be passed to the control?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Tune resource assignment based on observed use.

Addresses https://artsyproduct.atlassian.net/browse/PLATFORM-2657
Prod
For Web:

Reduce CPU request due to lower usage.
Reduce memory limit due to lower usage.

For Sidekiq:

Reduce CPU request due to lower usage.
Memory request/limit has not been specified. Here we are going to specify 256M/512M.

Staging
Similar changes.
Resources
Tuning guideline:
https://www.notion.so/artsy/Guidelines-on-tuning-an-app-s-CPU-and-memory-consumption-in-a-Kubernetes-cluster-797977be895643af84015a7d4b60a5dc
Prod Web usage dashboard (please change filters to see other prod deployments or staging deployments).
https://app.datadoghq.com/dashboard/2n5-6tr-ypp/kubernetes-cpumemory-usage-by-deployment?from_ts=1594840342055&live=true&to_ts=1595013142055&tpl_var_container=convection-web&tpl_var_deployment=convection-web&tpl_var_env=production&tpl_var_hpa=convection-web&tv_mode=false

Updated PR description. No change to code.

LGTM!!

Thanks @jonallured. I made you the only assignee. Updated PR description. Linked a fresh doc that has some guidelines on resource tuning. Also linked a datadog dashboard for checking past usage. They are a work in progress. Please let me know if you have questions.

This is wonderful, thanks @artsyjian!! ❤
I'm going to merge this one and then do a library update PR in a bit and then later I'll deploy to production and keep an eye on things but this feels safe to me! 👍

Thanks @jonallured .


NPM versus YARN - please move to yarn

The devcontainer.json for Node and Node + Mongo still has yarn as the commented out install step. When can this change to NPM?

Yarn and npm are both are in the image.  That is just illustrating one thing you can do.

Thanks for opening @diberry. Closing out this issue as it's still labeled needs-more-info, but please let us know if you have other thoughts on the above, and happy to reopen.


Fix credentials bugs as noted in jenkinsci/ghprb-plugin#117

Actually use the new path generated as a fix in
jenkinsci/ghprb-plugin#122
Use URIRequirementBuilder instead of manually building a requirements
list
Add logging around accessing credentials to debug failures, and give
better error messages when something is wrong
General refactoring of a few methods to reduce code duplication

I've tested this on my Jenkins instance, and it seems to fix the issues I addressed, as well as providing helpful debugging messages in the logs.
It seems that anonymous requests are still occasionally being used; I'm not sure if the github-api library is occasionally falling back on failures.
Fully fixes #117.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

I will check this out tomorrow night, and see if i can release it then

Could you please take a look at this ASAP? Half of GHPRB isn't working because of this problem when OAuth credentials are used.

could you cut a release as well?

released as 1.24.4

Thanks so much, you're awesome!


Add validation logic for github source attributes as object metadata in e2e test

TL;DR
In real case, https://github.com/abcxyz/pmap/blob/main/.github/workflows/snapshot-file-change.yml#L65-L69 here we put github source attributes as object metadata.
But in this integration test, we don't check if we have read these metadata and put them into the github source fields.
We should write fake github source attributes when we upload the test object so we cover this part of logic.
Detailed design
No response
Alternatives considered
No response
Additional information
No response

close, as https://github.com/abcxyz/pmap/pull/100 fixed this.


Future / Nice to Haves list

These should be broken down to other tickets as things.
Future

[ ] Authentication Setup
[ ] custom css for page content width
[ ] Dropbox integration
[ ] test security concerns with search fix
[ ] A generalized workflow document

diagrams and documentation

[ ] Add SubPages

This will require an upgrade to Gollum v4.2.2+

TOC not rendering properly in _Sidebar · Issue #1161 · gollum/gollum
Fix subpage lookup bug. Fixes #214. by bartkamphorst · Pull Request #215 · gollum/gollum-lib

[ ] Header
[ ] Footer
[ ] Sidebar

[ ] do video tutorial
[ ] integrate time tracking

Nice to haves:

[ ] custom css and javascript ?

not sure what I'll want to add but it's an option
skins? / themes?
see Can gollum integrate with flowchart.js ? · Issue #1080 · gollum/gollum

[ ] Docker image
[ ] Mobile device integration
[ ] Online vim editor replacement
[ ] how to change the margins for gollum pages

[ ] if no sidebar, etc.
[ ] what are the ramifications of this

[ ] a vim helpfile?
[ ] a vimwiki fork for gollum?

TODO Specifics:
Vim macro's to document

[ ] file add/checkin to git
[ ] change filetype mode (for views)

closing. future options are being removed from project for now


scale: curry descale_mask and reupscale for ease of use

This allows callers of descale() to modify parameters without having to manually partial.

Shouldn't you document this somewhere?

Not entirely sure how I'd describe currying in a way that makes sense for most use-cases. I imagine most people will still call the modules separately anyway. Add a short explanation to the docstrings, maybe?

Function is curried to allow parameter tuning when passing to :py:func:`lvsfunc.scale.descale`

Works. Will write a commit for that in a min.


Untighten format validation of image version

The version of the Alertmanager is configurable via .spec.image.tag in VMAlertmanager.
The controller parses this version to handle the command-line options of the Alertmanager according to its version.
Unfortunately for me, the version parser requires the version should comply with Semantic Versioning and rejects slightly modified versions like "<IP_ADDRESS>."
It would be convenient if the parser could accept such versions.
FYI
I add the fourth number to the version of the Alertmanager in order to distinguish container images with different configurations.
The first image I built for Alertmanager 0.21.0 is named "<IP_ADDRESS>."
The second image built with a modified Dockerfile is named "<IP_ADDRESS>."

will be included into next release.


Force delete containers and images when test finished

Force delete containers and images when test finished
Delete containers only when docker cp finished
related #915
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1113/console
system fails may need to be exclude. openjdk8_hs_externaltest_x86-64_linux passed as those tests are group as system so they won't run in the Test_external. See #919


Update code example to not use undefined variable.

The example code declares a variable HINST hinst but later uses an undefined variable hinstance. Presumably this should have been the previously defined hinst variable.

@Shipleaves : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Good catch, thank you!


add TickTok widget

https://developers.tiktok.com/doc/embed-videos/
it would be nice to add support of ticktok

Sure! Get it in there 😊
I think there's one in MDX Embed already (what this package is based off of) if you need an idea of the implementation
Otherwise I'll add it when I get round to working on it again 😅

closed with 8c9361fa04907c1f8f1a2c3e46d19f0cb6ebadb3


Visually hidden text is not hidden from screen readers

Description
There are many instances of visually hidden text that is not hidden from screen readers on https://clarity.design/documentation/color. This text is styled with the CSS class "copied-indication" and each instance contains the word "Copied!". This text is visually hidden with "opacity: 0;"  but screen readers can still access it. Screen reader users are not getting the benefit of having this text hidden from them as intended for sighted users.
See the relevant HTML/CSS below.
Copied!
li.card-swatch[_ngcontent-c4] .card-swatch-content[_ngcontent-c4] .rgb-value[_ngcontent-c4] .copied-indication[_ngcontent-c4] {
    display: inline-block;
    -webkit-transform: translateX(-24px);
    transform: translateX(-24px);
    opacity: 0;
    transition: all .2s ease-in-out;
}

Location
https://clarity.design/documentation/color
Priority
Medium
Recommended fix
If the instances of the word "Copied!" are necessary content than they should be accessible to all users and should not be visibly hidden with "opacity: 0;". If they need to be hidden from all users then they should be removed from the DOM. If this is not possible, aria-hidden="true" should be used on all of them as seen below.
Copied!
LOE
Medium

hello @chlane ! Are there any conclusions on this issue?
It is possible to eliminate those spans from the DOM, but i think you cant control the transitions by using this approach. However, you can change the visibility property which can be modified through transitions. I find that elements with visibility:hidden, will not be seen nor heard by screen readers. I can implement either this alernative or yours, by adding aria-hidden on true;

@chlane im gonna pr with this change today. please assign this issue to me

Thanks Alex. We will leave feedback on the PR.


Nimp link on read me directs to wrong website

Expected Behavior
 to go to the nimp pqge
Current Behavior
 it's currently redirecting to a fyp game
Failure Information (for bugs)

Steps to Reproduce

Screenshots

Context

Jimp Version:
Operating System:
Node version:

Failure Logs

:rocket: Issue was released in v1.0.2 :rocket:


Split link flags and link libraries lists to make gold happy.

gold is more strict than lld about the order of the arguments, that's
why CMake offers two different properties for the linker: LINK_FLAGS and
LINK_LIBRARIES. The former _add_variant_link_flags was adding the
libraries to LINK_FLAGS, when the correct thing is to add them to
LINK_LIBRARIES.
The change adds a new output variable for _add_variant_link_flags which
will containt the linked libraries, and CMake will be able to generate
the correct command line invocation for when gold is used.
This should fix the Android CI build.
/cc @compnerd

@swift-ci please test


Bug: the menu bar sound icon does not change to an airpods icon when eqmac is running

Disclaimer:
Please go through existing issues to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

[x] I have checked for a similar issue and sure it hasn't been reported before.

Describe the bug
In the menu bar in Mac OS Monterey, the sound icon indicates the output device for system sound. Without EQMac running, it will change from a generic speaker to an AirPods icon once AirPods are connected. However, when EQMac runs, that icon reverts to a generic speaker even when AirPods are connected, in addition to that menu not indicating that the AirPods are connected.
Steps to Reproduce
Steps to reproduce the behaviour (feel free to change the placeholder as you need):

Connect AirPods to Mac
Open EQMac and run the program by enabling "EQMac Bypass"

Expected behaviour

Setup information:

Audio device used for playback: AirPods Pro 1
Audio transmission interface: Bluetooth
macOS Version: 12.5.1
eqMac Version: 1.5.1
eqMac UI Version: 4.2.0 (Remote)

There's no public API available to developers to change this :(

I've messaged Apple about this and they refused to help.

As Apple does not allow this at the moment, I would close this issue for now. Please track issue #812, this would make eqMac display a custom icon for devices, but it is not easy to implement.


Enable PerfView To Export SpeedScope Data Not Per Thread But All Threads Aggregated

I have whipped together a small change to export SpeedScope Data not thread wise but as an aggregate.
That makes it much easier to find CPU bottlenecks which happen in the same methods split accross many threads.
Currently the Speedscope output is not that useful if you have many threads in your application.

You loose then the timeline view which is not that useful anyway if you can check only one thread at a time.
Left Heavy and Sandwich work as expected

For the export menu we would then need an additional option or should that become the new default?

Speed Scope (*.speedscope.json)
Speed Scope All Threads (*.speedscope.json)

Any opinions?

@adamsitnik

Hi @Alois-xx
As you have pointed out, speedscope does not support showing data from multiple threads using a single view mostly due to the Time Order view limitations (https://github.com/jlfwong/speedscope/issues/117). But, if you are not interested in Time Order, why would you use Speedscope while you can see the aggregated data in PerfView?

That makes it much easier to find CPU bottlenecks which happen in the same methods split accross many threads

You should be able to see these methods in the "By Name" view in PerfView (the data is always aggregated).
If you want to have "aggregated" Flamegraph you can use the [fold threads]            Thread -> AllThreads grouping (please see #980 for more)
If you want to have something like "Time Order" view, but with all threads, you can use the "Chromium" trace file exporter (https://github.com/microsoft/perfview/pull/1113).
Please let me know what you think about the existing options.

Actually I am not using PerfView but a command line tool which automates the loading of an ETL, selecting a process, loading symbols or using cached ones. By adding a Thread xxxx at the bottom of each stack I get a view which shows e.g. how much threads have been spinning or if only one thread did all the work which is pretty useful in heavily multithreaded applications.
What I am most interested is the Left Heavy graph:

By doing this I also get a nice per Thread Cost View in Sandwich

When I click on that Thread there I get all methods called in this thread and their costs. That is a much more useful
view on a multithreaded application.

I understand if you want to keep the view as is. It is just a suggestion. I am going to keep my code anyway because PerfView has not yet long path support which makes it unusable to reliably load symbols from deep path names and I find a command line extraction tool easier to work with my existing tool chain.


fixed: https://github.com/Sublime-Instincts/BetterTwig/issues/10

Added scopes for endif and endfor

Also, please change the respective test case for the scope change. Just open the syntax file and ctrl + shift + b, then go to Syntax Tests. Since the scopes have changed, there should be a 1 or 2 failing tests. Just correct/update them & ensure that the tests pass.

I think now is ok. I'm kind new on sublime stuff, I didn't know that the sublime had a function to test syntax


Release 0.1.51

Signed-off-by: Yuki Okushi<EMAIL_ADDRESS>

@bors r+

:pushpin: Commit ebbe7c57b901be067eecbb6ffd0c53b9d5f40fbd has been approved by JohnTitor

:hourglass: Testing commit ebbe7c57b901be067eecbb6ffd0c53b9d5f40fbd with merge 21d566154601c6bba71929c1c7a4eb4921e78800...

:sunny: Test successful - checks-actions
Approved by: JohnTitor
Pushing 21d566154601c6bba71929c1c7a4eb4921e78800 to master...


update mainnet VRT vault address

update  VRT vault address
open the entry on UI

Please don't release until we have the funding


Clear Recent List only take effect after close and relaunch the application

It should take effect immediately.

Thanks for report, will fix it on next release.

This bug was fixed in v1.9


Ensures we can use FQDN in ceph.yml playbook

Until now, there was an inconsistency between the 06-deploy-edpm.yml and
06-deploy-architecture.yml playbooks when it comes to ceph
configuration:
in the first one, ceph.yml play was instructed to use FQDN (via
ansible_fqdn fact), while the latter was using shortnames (via
ansible_hostname).
This leads to issues whenever we want to set FQDN on the various nodes
and in the inventory, since some stages of the ceph configuration is
checking for name consistency.
As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running

This might be sufficient. cephadm's hostname handling is complex. Let's make sure delta and delta-ipv6 can pass with this before merging.

Seems we can remove all of those *_spec_fqdn and leverage inventory_hostname and its variations (item in loop).
This is implemented in #2164 . Closing this one.


Ping downloads contents (and uses lots of data)

I have set up the my host to ping using PingConfig.setHostsList("myUrl") at this url is my web pages home page which is around 500KB.
After getting a complaint from a user that my app was using lots of data in the background, I have tracked down the issue to this library. Instead of a real ping to check for connectivity it's downloading the entire HTML page and validating it. Before looking at the detail I assumed a ping would use a tiny amount of data and the data usage would not vary based on what I was pinging.
As an experiment I set the host list to empty using the following code:
PingConfig.setHostsList(arraySetOf())
After a little testing the library seems to be still working ok and doing what I need (without any extra data usage). This leads me to two questions.

Is this going to cause problems as presumably the whole connectivity monitoring will no longer work.
What exactly is the point of this connectivity monitoring? Why does this library even care if I'm online or not?

Thanks again for this great library and thanks in advance for your response!

With recent changes - Ping/Connection - related code is not used anymore and will be removed soon.
Thank you for bringing the problem to attention.

Published version 2.1.84
Ping/Connection classes now deprecated and not used anymore, I'll remove it in next releases.


Refactoring + fixes

Problem addressed

get_all_watchlists returns None
warnings that Option is not a Security
if option strike is used as Decimal, got error that is_integer is not available
type checking: some return types do not correspond to what is actually returned, eg. List[Option] instead of OptionChain
example is using hardcoded date, after this date the Option will not be available
option DX symbol must be prefixed with '.'

Solution

Fixed
Option extends Security
using decimal % 1 == 0 to determine if it is an integer
fixed return types to match al return values
using closest third friday
option DX symbol is now  prefixed with '.' - fixed
streamer did not work for my without the dot, it works with the dot.

you also have it in your example.py:
sub_values = {
     "Greeks": [
         ".VIX180718C21",
         ".YUM180518C95"
     ]
}

Checklist

PR commits have been squashed
All tests pass
Code adheres to contributing guidelines

Thanks for this!


Optionally build example.c with "make example"

Makefile.am modified to create Makefile that automatically compiles example.c locally but does not install it

Hmm, see libbase58's tool for how to do this correctly.

How's the latest commit?

How's this? Did I get the logic right?

How's this? Did I get the logic right?

I almost wonder if perhaps it shouldn't be a configure option at all, and simply shouldn't get built unless the user explicitly does a make example

@luke-jr @laanwj This latest commit might be a good balance between both your views.

Looks good to me.
utACK

I set the min version to 0. I'm not sure which libgycrpt version first had GCRY_MD_SHA256.

How's this look?

corrected


All champions are frozen in replays

Hi, I'm testing this service on my Macbook.  It seems to be able to download replays just fine, but when I launch the replays, all champions are frozen in place even though the clock is ticking.
Here's the command I'm running to launch the replay, as well as the output from the command, if that helps:
~ if test -d  /Applications/League\ of\ Legends.app/Contents/LoL/Game/ ; then cd /Applications/League\ of\ Legends.app/Contents/LoL/Game/ && chmod +x ./LeagueofLegends.app/Contents/MacOS/LeagueofLegends ; else cd /Applications/League\ of\ Legends.app/Contents/LoL/RADS/solutions/lol_game_client_sln/releases/ && cd $(ls -1vr -d */ | head -1) && cd deploy && chmod +x ./LeagueofLegends.app/Contents/MacOS/LeagueofLegends ; fi && riot_launched=true ./LeagueofLegends.app/Contents/MacOS/LeagueofLegends "spectator localhost:9000 5uO4AZUN1kvR2vLU1nmLkStfiKbAiNYV<PHONE_NUMBER> NA1" "-UseRads" "-Locale=en_US" "-GameBaseDir=.."

<unknown>(0x117a76dc0): ALWAYS|   CFG| CrashHandler(Bugsplat)
2020-09-11 16:25:47.859 LeagueofLegends[43704:1027993] BugSplatFramework: initWithDatabase: defaultExceptionHandler is set
<unknown>(0x117a76dc0): ALWAYS|   CFG| Command Line:  "spectator localhost:9000 5uO4AZUN1kvR2vLU1nmLkStfiKbAiNYV<PHONE_NUMBER> NA1" "-UseRads" "-Locale=en_US"
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Bootstrap.wad.client
<unknown>(0x117a76dc0): ALWAYS|   CFG| Build Version: Mac Beta Version 10.18.333.8889 (Aug 31 2020/10:49:44) [PUBLIC] <Releases/10.18> ChangeList: 3338889
<unknown>(0x117a76dc0): ALWAYS| Live Profiling enabled. Will overwrite old RPD.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Initializing Renderer
<unknown>(0x117a76dc0): ALWAYS| r3dRenderLayer::Init enter
<unknown>(0x117a76dc0): ALWAYS| r3dRenderLayer::Init() exit successfully
<unknown>(0x117a76dc0): ALWAYS| rr3dRenderLayer::InitDevice(XRes = 1440, YRes = 900, BPP = 32) enter
<unknown>(0x117a76dc0): ALWAYS| rr3dRenderLayer::InitDevice: Creating X3D device
<unknown>(0x117a76dc0): ALWAYS| Initializing new X3D API...
<unknown>(0x117a76dc0): ALWAYS| Attempting to choose valid window presentation settings...
<unknown>(0x117a76dc0): ALWAYS| Window presentation mode:        3
<unknown>(0x117a76dc0): ALWAYS| Framebuffer width:               1440
<unknown>(0x117a76dc0): ALWAYS| Framebuffer height:              900
<unknown>(0x117a76dc0): ALWAYS| Framebuffer format:              0
<unknown>(0x117a76dc0): ALWAYS| Depth-stencil format:            8
<unknown>(0x117a76dc0): ALWAYS| Multisample type:                0
<unknown>(0x117a76dc0): ALWAYS| Vertical retrace sync enabled:   0
<unknown>(0x117a76dc0): ALWAYS| X3D hardware renderer: Intel(R) Iris(TM) Plus Graphics OpenGL Engine
<unknown>(0x117a76dc0): ALWAYS| 8 cores detected. Enabling kCGLCEMPEngine.
<unknown>(0x117a76dc0): ALWAYS| Attempting to apply window presentation settings...
<unknown>(0x117a76dc0): ALWAYS| Window presentation mode:        3
<unknown>(0x117a76dc0): ALWAYS| Framebuffer width:               1440
<unknown>(0x117a76dc0): ALWAYS| Framebuffer height:              900
<unknown>(0x117a76dc0): ALWAYS| Framebuffer format:              0
<unknown>(0x117a76dc0): ALWAYS| Depth-stencil format:            8
<unknown>(0x117a76dc0): ALWAYS| Multisample type:                0
<unknown>(0x117a76dc0): ALWAYS| Vertical retrace sync enabled:   0
<unknown>(0x117a76dc0): ALWAYS| Using X3D Platform: OpenGL 3.2 Core
<unknown>(0x117a76dc0): ALWAYS| r3dRenderLayer::RecreateOwnedResources
<unknown>(0x117a76dc0): ALWAYS| r3dRenderLayer::InitResources exit successfully
<unknown>(0x117a76dc0): ALWAYS| AudioManager: Wwise Version v2018.1.1 initialized.
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Bootstrap.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Global.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Scripts.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/UI.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Shaders/Shaders.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/ShaderCache.glsl.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/DATA.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Localized/Global.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/UI.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| GameStartData::GameID=3571266298
<unknown>(0x70000931b000): ALWAYS| Started ReplayDownloadManager thread.
<unknown>(0x70000931b000): ALWAYS| ReplayDownloader: ==== Fetch MetaData Phase ====
<unknown>(0x117a76dc0): ALWAYS|  CONN| Game Info Received ServerSimTime(0.000) PreviousDisconnectCount(0)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamOrder 0) BlazedNova  - Champion(Camille) SkinID(10) TeamBuilderRole(TOP) PUUID(46921291-1481-560f-9fbb-e34fc7a9e5f3) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamOrder 1) Gullible  - Champion(Shyvana) SkinID(0) TeamBuilderRole(JUNGLE) PUUID(646f5a30-96c1-5814-9766-4a714900f5f7) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamOrder 2) hªtred  - Champion(Graves) SkinID(25) TeamBuilderRole(MIDDLE) PUUID(8f1a62a2-6eb6-5373-9740-45b840539e12) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamOrder 3) Shorthop  - Champion(Caitlyn) SkinID(11) TeamBuilderRole(BOTTOM) PUUID(73e3008a-3a81-597e-ab5a-b863557c2737) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamOrder 4) Fatal Feeling  - Champion(Lux) SkinID(17) TeamBuilderRole(UTILITY) PUUID(0939beeb-36e5-59c9-9030-230ac014d9ba) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamChaos 0) BestRengarAfrica  - Champion(Rengar) SkinID(0) TeamBuilderRole(TOP) PUUID(e42c4aea-77c1-5178-9728-a67fd52d70b1) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamChaos 1) Blazze  - Champion(Lillia) SkinID(0) TeamBuilderRole(JUNGLE) PUUID(d4ed8dda-ca8e-58aa-a4db-2416a1a97a35) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamChaos 2) 3ofSpades  - Champion(Yone) SkinID(0) TeamBuilderRole(MIDDLE) PUUID(719eff92-6534-5357-a3df-eda7c7ee8043) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamChaos 3) ArkySummons  - Champion(Ashe) SkinID(0) TeamBuilderRole(BOTTOM) PUUID(b1840323-e6f2-5fa3-9abe-0da334ebc256) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS|  ROST| CONNECTION READY | TeamChaos 4) Borb  - Champion(Senna) SkinID(0) TeamBuilderRole(UTILITY) PUUID(258db36c-2688-503e-af6c-9cced460dcbd) ConnectionState(Disconnected)
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Maps/Shipping/Common.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Maps/Shipping/Common.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Maps/Shipping/Map11.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Maps/Shipping/Map11.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Maps/Shipping/Map11LEVELS.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/DATA2.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Camille.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Camille.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Shyvana.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Shyvana.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Graves.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Graves.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Caitlyn.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Caitlyn.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Lux.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Lux.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Rengar.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Rengar.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Lillia.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Lillia.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Yone.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Yone.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Ashe.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Ashe.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Senna.wad.client
<unknown>(0x117a76dc0): ALWAYS| WadFile mount: DATA/FINAL/Champions/Senna.en_US.wad.client
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Replay grid connection ready
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Waiting for loading info
<unknown>(0x117a76dc0): ALWAYS| Set focus to app
<unknown>(0x117a76dc0): ALWAYS|   CFG| OS Version: MacOSX Version 10.15.5 CPU: Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz, 2300Mhz (8 cores) Instruction Set Level 7Physical memory:<PHONE_NUMBER>8Display info: Graphics/Displays:

    Intel Iris Plus Graphics:

      Chipset Model: Intel Iris Plus Graphics
      Type: GPU
      Bus: Built-In
      VRAM (Dynamic, Max): 1536 MB
      Vendor: Intel
      Device ID: 0x8a53
      Revision ID: 0x0007
      Metal: Supported, feature set macOS GPUFamily2 v1
      Displays:
        Color LCD:
          Display Type: Built-In Retina LCD
          Resolution: 2560 x 1600 Retina
          Framebuffer Depth: 30-Bit Color (ARGB2101010)
          Main Display: Yes
          Mirror: Off
          Online: Yes
          Automatically Adjust Brightness: No
          Connection Type: Internal
        U2790B:
          Resolution: 3840 x 2160 (2160p/4K UHD 1 - Ultra High Definition)
          UI Looks like: 1920 x 1080 @ 60 Hz
          Framebuffer Depth: 30-Bit Color (ARGB2101010)
          Mirror: Off
          Online: Yes
          Rotation: Supported
          Automatically Adjust Brightness: No
          Connection Type: Thunderbolt/DisplayPort

 Driver: UNKNOWN
<unknown>(0x117a76dc0): ALWAYS| PlayGame Started
<unknown>(0x117a76dc0): ALWAYS| LCURemotingClient: Initializing on port 0
<unknown>(0x7000094a4000): ALWAYS| LCURemotingClient: Initializing on port 0
<unknown>(0x117a76dc0):   WARN| RemotingClientTransport: Couldn't connect to host, connect() returned: -1 with errno: 49: Can't assign requested address
<unknown>(0x7000094a4000):   WARN| RemotingClientTransport: Couldn't connect to host, connect() returned: -1 with errno: 49: Can't assign requested address
<unknown>(0x117a76dc0):  ERROR| LCURemotingClient: Unable to connect to app process.
<unknown>(0x117a76dc0):  ERROR| LCUVoiceChatClient: Unable to connect to LCU.
<unknown>(0x7000094a4000):  ERROR| LCURemotingClient: Unable to connect to app process.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Begin Async Loading
<unknown>(0x700009527000): ALWAYS|  LOAD| LOADING: Begin Game Object Update
<unknown>(0x700009527000): ALWAYS|  LOAD| LOADING: End Game Object Update
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'fiddlestickseffigy' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'slime_riftherald_mercenary' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_lootgoblin' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_lootgoblin' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_lootgoblin' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_shopkeeper' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_nexusrooted' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_jungleguardian' and skinID '0'
<unknown>(0x700009527000):  ERROR| Unable to load character data for 'nexusblitz_nexuswalking' and skinID '0'
<unknown>(0x700009527000): ALWAYS| PreloadGlobalEffects
<unknown>(0x700009527000): ALWAYS| PreloadGlobalEffects Finished
<unknown>(0x700009527000):   WARN| Duplicate key/value pair ([OnKilledUnitOnKillingSpreeUnrealKill_YOffset3, 8] in DATA/CFG/defaults/Announcements_CLASSIC.ini
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Async Loading Complete
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Data Load Complete
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Start Main Loop
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Switching Game State from GAMESTATE_PREGAME to GAMESTATE_SPAWN for reason Received StartSpawn packet.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-BC89AC41
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-6671BCAD
<unknown>(0x117a76dc0): ALWAYS| ReplayDataManagerClient: Stopped throttling chunk fetching
<unknown>(0x117a76dc0): ALWAYS| Clock Pause During Replay End 1860.561
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-AB67B010
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Switching Game State from GAMESTATE_SPAWN to GAMESTATE_SPAWN for reason Received StartSpawn packet.
<unknown>(0x117a76dc0): ALWAYS|  CONN| Game Info Received ServerSimTime(0.000) PreviousDisconnectCount(0)
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0): ALWAYS| BannerUserComponent Init
<unknown>(0x117a76dc0):  ERROR| Unable to load character data for 'iverntotem' and skinID '0'
<unknown>(0x117a76dc0):  ERROR| >>> BuffHashMap::HashToName - Match not found for hash 08065431
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: -1304347988
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: -1953012651
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: 493636430
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: -635357395
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: -1215422396
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: -94215803
<unknown>(0x117a76dc0): ALWAYS| SummonerBannerComponentClient spawned banner at map locator: 262661373
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Spawning completed
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Switching Game State from GAMESTATE_SPAWN to GAMESTATE_GAMELOOP for reason Received Game Start Packet.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-8711AB1A 1860.56
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-9651ACAB
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-B2890C00
<unknown>(0x117a76dc0): ALWAYS| GAMESTATE_GAMELOOP UpdateVis
<unknown>(0x117a76dc0): ALWAYS| GAMESTATE_GAMELOOP AudioUpdate
<unknown>(0x117a76dc0): ALWAYS| GAMESTATE_GAMELOOP EndRender & EndFrame
<unknown>(0x117a76dc0): ALWAYS|  FLOW| SEJ-891ACC45
<unknown>(0x7000094a4000):   WARN| RemotingClientTransport: Couldn't connect to host, connect() returned: -1 with errno: 49: Can't assign requested address
<unknown>(0x7000094a4000):  ERROR| LCURemotingClient: Unable to connect to app process.
<unknown>(0x117a76dc0): ALWAYS| Scaleform handling game exit request.
<unknown>(0x117a76dc0): ALWAYS| Scaleform quit game dialog opened.
<unknown>(0x117a76dc0): ALWAYS| Scaleform handling game exit confirmation.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Switching Game State from GAMESTATE_GAMELOOP to GAMESTATE_PRE_EXIT for reason OptionsFoundaryCallback: Quit Game Confirmed.
<unknown>(0x117a76dc0): ALWAYS| Scaleform quit game dialog closed.
<unknown>(0x117a76dc0): ALWAYS|  CONN| Requesting disconnect (21)
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Switching Game State from GAMESTATE_PRE_EXIT to GAMESTATE_EXIT for reason PreExit Game State is Complete.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Finished Main Loop
<unknown>(0x117a76dc0): ALWAYS| =================== Perf Stats (all in ms) =========================
<unknown>(0x117a76dc0): ALWAYS| Average Frame Time:    10.58
<unknown>(0x117a76dc0): ALWAYS| Average FPS:           94.51 fps
<unknown>(0x117a76dc0): ALWAYS| StdDev Frame Time:     2.76
<unknown>(0x117a76dc0): ALWAYS| Max Frame Time:        172.18
<unknown>(0x117a76dc0): ALWAYS| Ave GPU Frame Time:    6.55
<unknown>(0x117a76dc0): ALWAYS| StdDev GPU Frame Time: 7.48
<unknown>(0x117a76dc0): ALWAYS| Max GPU Frame Time:    550.44
<unknown>(0x117a76dc0): ALWAYS| Histogram Buckets:     [0.0,1.0,2.0,5.0,7.5,10.0,18.0,35.0,50.0,75.0,100.0,500.0,1000.0,340282346638528859811704183484516925440.0]
<unknown>(0x117a76dc0): ALWAYS| Frame Time Histogram:  [0,0,1,0,1,1176,4169,16,3,0,1,1,0,0]
<unknown>(0x117a76dc0): ALWAYS| GPU Time Histogram:    [0,0,0,63,5165,124,10,5,0,0,0,0,1,0]
<unknown>(0x117a76dc0): ALWAYS| Max Memory Allocated = 0.000MB
<unknown>(0x7000094a4000):   WARN| RemotingClientTransport: Couldn't connect to host, connect() returned: -1 with errno: 49: Can't assign requested address
<unknown>(0x7000094a4000):  ERROR| LCURemotingClient: Unable to connect to app process.
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Cleanup Complete
<unknown>(0x117a76dc0): ALWAYS|  FLOW| ALE-8SDFH23F
<unknown>(0x117a76dc0): ALWAYS| {"exit_code":"EXITCODE_NONE","messageType":"riot__game_client__connection_info","message_body":"Game exited"}
<unknown>(0x117a76dc0): ALWAYS| AudioManagerWwise::Finit
<unknown>(0x117a76dc0): ALWAYS| r3dRenderLayer::Close() enter
<unknown>(0x117a76dc0): ALWAYS| r3dRenderLayer::Close() exit
<unknown>(0x117a76dc0): ALWAYS|  FLOW| Destroying the renderer

By the way I'm aware that this project may no longer be maintained and I'm fully down to investigate the issue myself.  I was just wondering if you could provide some pointers as to what the issues may be.


Avoid loading GermanNounNormalizer when it is not used

The CommonRulesRewriter loads a querqy.rewrite.lookup.preprocessing.GermanNounNormalizer instance regardless of whether it is being used (via the list of predefined LookupPreprocessorFactories see https://github.com/querqy/querqy/blob/main/querqy-core/src/main/java/querqy/rewrite/lookup/preprocessing/LookupPreprocessorFactory.java#L7)
As GermanNounNormalizer loads a huge trie structure for lookup (ca. 50 MB) we should avoid loading it if it is not used. The problem becomes worse in Solr if each core loads Querqy from its own classpath (default) as this results at num cores x 50 MB memory consumption. As a workaround, the Querqy jar could be loaded from <solr-home>/lib (which should work without any reference from solrconfig.xml)

Implemented by #940


Get rid of easily removable uses of const_cast

depends on https://github.com/godotengine/godot/pull/94864
gets rid of 138 instances of const_cast (greping for "\Wconst_cast\W" in all folders except thirdparty gave 282 instances before and 144 after)
these were the simplest ones i could get rid of. its the reason its in a bulk commit

This looks like a great thing. What are the downsides?

I haven't checked every case detailedly, but I can say this is reasonable. I mean, if a statement needs const_cast, it's usually true that the non-const function needed to write to the object because the relevant data was working as a cache. And in those cases I believe it's better to use mutable as a clearer way to signal intent.

And in those cases I believe it's better to use mutable as a clearer way to signal intent.

I needed to educate myself on the meaning of mutable, but it seems way clearer to use this than const_casting each time. Using const_cast screams "this is a hack".

I asked @rune-scape to rebase the PR. If they aren't available, I'll rebase the PR myself in a few days.

Thanks!


decrease padding from the hero section

Decrease padding from the hero section of the homepage #105

Nice work @rishipurwar1 . We will merge it on or after 1st October

I think hackoctober is already started.  1 October is already there is some countries

Sorry my bad.
Its started.
Thanks for the info @rishipurwar1

No problem☺
Keep Contributing...


COMPRESS-632: Fixes for dump file parsing

This PR adds a few fixes and unit tests for dump file parsing, related to fuzzing work in COMPRESS-632.

Please hold off creating PRs while I add checkstyle to the build, it will just cause conflicts; -)

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fa1b16d) 80.55% compared to head (f7e6955) 80.63%.
Report is 1 commits behind head on master.

Files
Patch %
Lines

...ompress/archivers/dump/DumpArchiveInputStream.java
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
+ Coverage     80.55%   80.63%   +0.07%
- Complexity     6764     6775      +11
============================================
  Files           342      342
  Lines         24860    24864       +4
  Branches       4017     4018       +1
============================================
+ Hits          20027    20049      +22
+ Misses         3298     3285      -13
+ Partials       1535     1530       -5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adventure Game Biege license

https://sourceforge.net/projects/biege/ does not seem to have a clear indication of the license next to the sourcecode.
Contact the author(s) and ask for clarification / possibility to add (a suitable) license information.

I sent a message to Nick Miller (https://sourceforge.net/u/lalunia/profile/) via Sourceforge.

I didn't receive a reply for almost two months. Repeated the message and sent it to the email adress in the readme (...uwaterloo.ca).

The address is not functional anymore. Will give up for now.


Add a dev script to set up the local cases db and populate it with sample data

(Also a small fix to tsconfig in the scripts dir that I noticed when testing the new script)
TESTED=Dropped my covid19 database, ran the script, and confirmed that:

covid19 db exists
it has a cases collection
the collection has a validator
the collection has 100 documents in it

@attwad LMK if you think we should call this script from run_stack.sh -- on the one hand it would ensure that everyone's db was up to date, but on the other hand it drops data (and it's easy enough to get into the habit of doing setup-db.sh && run_stack.sh)

 Add a script for fully setting up a local db with validation, indices, and more sample data


Toolbar issue

Hi,
I just installed the new python TweenMachine version 3.0.0, on Windows, Maya 2017. I tried to place it as a toolbar but I couldn't find a way to get back to a window again, then I tried to move it and TweenMachine just disappeared. Now I can't see the TweenMachine script even if it is found when I try to reinstall it
Is there a way to reset the settings ?

Sorry for the delay in answering, I never got a notification for this issue.
I can reproduce the behavior, but I don't think the original author ever fully fledged out the tool bar portion.
It looks the easiest way is just to restart Maya and rerun the import script. I'm reworking the UI for version 3.1.0, I'll make sure to fix this. Thanks for reporting it.

That's ok, I'm not rushing ;)
It worked, thank you very much. Is it possible to snap the script into
another window, as the Graph Editor, than the main one ?
2018-04-06 5:09 GMT+02:00 Alex Widener<EMAIL_ADDRESS>
Sorry for the delay in answering, I never got a notification for this
issue.
I can reproduce the behavior, but I don't think the original author ever
fully fledged out the tool bar portion.
It looks the easiest way is just to restart Maya and rerun the import
script. I'm reworking the UI for version 3.1.0, I'll make sure to fix this.
Thanks for reporting it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexwidener/tweenMachine/issues/23#issuecomment-379136287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AkQGlRUZFJNEQ5-G1PQdDUvVeKxJpFXuks5tltx6gaJpZM4TDypG
.

--
Cordialement,
M. HAV Thierry
http://thebigfatanim.blogspot.fr/
http://thebigfatanim.blogspot.fr/https://www.facebook.com/pages/The-Bigfat-Anim/241836912627369
http://thebigfatanim.blogspot.fr/https://twitter.com/Thebigfatanim
http://thebigfatanim.blogspot.fr/

No, but that has already been changed in what I've rewritten. There is an initial docking location, but you can redock it as needed.


Add semicolons

Yup, that's it.

This Pull Request has been closed by GitConsensus.
Vote Totals

Yes
No
Abstain
Voters

8
4
0
12

Vote Breakdown

User
Yes
No
Abstain

lurr
✔

TheRealMaxion
✔

ags131

✔

tedivm

✔

daboross
✔

Graham42

✔

pathurs
✔

FNCxPro
✔

gary600
✔

JestDotty

✔

ezolenko2
✔

anisoptera
✔

Vote Results

Criteria
Result

Has Quorum
True

Has Votes
False


Make Script Errors from Northstar Callbacks Fatal

Read Title.
Why
Because:

Errors are incredibly confusing when non-fatal - there is no indicator that an error is happening
The error is unknown without a try/catch block
Errors cannot be tracked to a line, or file, and its location has to be figured out manually
They can throw a game into an unexpected state with no indicator, confusing both players AND developers

here is the function definition for other reviewers:
SQRESULT sq_call(HSQUIRRELVM v, SQInteger params, SQBool retval, SQ-
Bool raiseerror);

code looks good, unsure if this will affect any existing mods (though if they are affected they already have an error so perhaps breaking already broken mods even more is best)

played 30 minute of Attrition with a lot of mods installed that make use of scripts and thus far I've seen no problems.
I think its fine to merge as is but it would be cool if there an example mod that would silently error before this for the sake of testing.

100% agreed with this PR. I'll put it into v1.26 release o7


Session validation to check for session expiry.

Previously Utopia::Session relied only on the client's user agent honoring the Expires= directive in the Set-Cookie header. This could mean that an expired session cookie can possibly still be treated by the backend as valid which could be a minor security issue.
This PR fixes that by adding an extra validation check to Utopia::Session.validate_session!, an expired session is just as invalid as a session with the wrong UA string.

Coverage increased (+0.02%) to 84.608% when pulling 638430dac7d00a3e480a667d826f6c74d4e41e06 on huba:session-expiry into 7fc93879954c453924ac316ec20781a966850263 on ioquatix:master.


--with-milestone=fcs not valid for JDK11

All JDK11 build logs currently have:
configure: WARNING: Option --with-milestone is deprecated and will be ignored.

Should probably be removed for JDK11 from https://github.com/AdoptOpenJDK/openjdk-build/blob/master/sbin/build.sh#L134 (Use is in https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/master/common/autoconf/spec.gmk.in#L179)
Based on the openj9 release document, the --without-version-pre --without-version-opt options may serve a similar purpose.

This looks like it was done via #917 @gdams can this be closed?


⚠ GitLab Server has degraded performance

In 9913261, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11731 ms

Resolved: GitLab Server performance has improved in c33901c.


[CCFPCM-497] file ingestion

CCFPCM-497
Note: I'm not quite sure why SQ is detecting so many duplicates on the migration file.
The GarmsTransaction duplication is a little bit by design. I think the TransactionDTO is partly deprecated, but need to have a discussion before removing it.
Objective:

The process goes:

Need to manually add rules for each program on what file names to expect
When the parser is run (manually for now), it creates a "daily" upload to denote the day's uploads
It uploads each file that needs it, the same as before
If there is a validation error, we (will eventually) send an alert for it, but for now we do an error log in the lambda
After all files are uploaded, it POSTs to the alert endpoint to see if it needs to send out an alert based on which files have been uploaded and if it has passed the retry threshold

Still to clean up before merging:

A possible timezone bug when creating a new file past 5pm PST (creates the file for tomorrow I think)

Future PRs:

Migration to move all the file names from transactions / deposits to the new file upload system, and check that new table instead
Testing for Parse Service
Very very proper error handling (this should probably be a ticket itself)

Problems that might warrant discussion:

This is really only good if the parser is just run "for today". Doesn't take into account any past uploads, or what happens if the flow is blocked up.

I think we need to specify the env var in docker compose and docker-compose.ci


How to install linux release?

I'm excited to use the editor, but I don't know how to install it. Sorry to be so daft.

Hey @daniel-wescott,
Glad you're excited to use it. I am not totally sure how to install it because I haven't actually used a Linux machine much.
I think the general idea is to go to this repo's release page and download the Linux release. Maybe try double clicking the downloaded file?
Maybe @beeltetun could help us out with some more specifics on how he went about installing it on Linux?
I can ask some other co-workers on how the install should go

Hi,
download the file and open a terminal. Then
chmod +x Open-Vector-Editor-0.1.5.AppImage
./Open-Vector-Editor-0.1.5.AppImage
That's it.

Thanks for the instructions @beeltetun ! @daniel-westcott let me know if that works for you. If so I'll add these instructions to the readme

Thanks @beeltetun! It works!

I've added clearer install instructions to the readme here: https://github.com/tnrich/ove-electron/blob/master/README.md#installation-instructions
@daniel-westcott and @beeltetun if either of you have a moment, I'd love to hear what you think of the tool
Any feedback from real users is always appreciated :)
Thanks!


UI cleanup

Includes updates for these cards:

https://trello.com/c/YUynepPP/254-2-summit-ui-cleanup
https://trello.com/c/qTssJc8J/255-1-summit-update-header

Updates are intended to remove contents that are not related to the app, and to remove any instances of a product name from the UI. These updates are for the purposes of demo-ing at Summit.

Hi Jenn,
One more thing I found:

The Users page has title "Patternfly React Boiler | Users". It should be "Users".

The Overview page tile is "Home". It should be "Overview" if follow the same name standard.

Thanks,
Xiaofeng

Thanks for catching that, @bcl! I made updates so that the tooltip is hidden on click, and fixed the text that displays so that it matches.
@henrywang, thanks for reviewing! I updated the title for the Users page. That's a good point about the Overview page title. I left it as is for now, and we can finalize the title when we start finalizing the contents on the page.

Test passed. Thanks Jenn!


URL paths that contain - (dash/hypen) character don't work

The test code is attached below. The observation is

If path ="/flat-url", server responds to the request (http://localhost:9001/test/flat-url?param1=PARAM1&param2=PARAM2) with 404 error code

If path= "/flat_url", the request (http://localhost:9001/test/flat_url?param1=PARAM1&param2=PARAM2) succeeds

Not a major issue but an inconvenience that perhaps can be fixed quickly.
local copas = require("copas")
local restserver = require("restserver")
local dkjson = require("dkjson")

local server = restserver:new():port(9001)
local DATA_TYPE_JSON ="application/json"

server:add_resource("test",{
    {
        method="GET",
        path="/flat-url",
        produces=DATA_TYPE_JSON,
        handler = function(params)
            local ret_json ={}
            local param1 = params["param1"]
            local param2 = params["param2"]
            local ret_json = {
                ["ret0"]="val0",
                ["ret1"]="val1",
                ["ret2"]="val3"
            }

            return restserver.response():status(200):entity(ret_json)

        end,
    },
})

server:enable("restserver.xavante"):start()

Sorry, I missed this bug report! It's fixed now, better late than never! :)


Android: custom fonts

Same as on the iOS app. Fonts are in the repo under clients/ios/Resources/fonts.

Where would custom fonts be used in the app? Only for the text when reading stories?

Once we have the font in a spot we can access, it coud optionally be used all over the place - story bodies, list text, even menu text.  Each is just another sub-task.  First we have to build a system that will let users get the fonts if they like (since most good international fonts are huge and would increase the size of the app by almost an order of magnitude).

On the web (and I assume iOS) the user can pick from a defined set of fonts. On Android we want the user to be able to load and choose any font they wish?

we want the user to be able to load and choose any font they wish?

No, that sounds like a security and support nightmare.  We just need to figure out a system by which our selected fonts are fetched by the app if the user wishes to use them.

So the set of font files will be hosted somewhere and when a user selects that font for the first time it is downloaded into the apps cache area?
And from that point on we can then go ahead and use it (handling that we might need to download again if the cache was wiped but the font is still selected).

Sounds about like how I had envisioned.  Once you have the ttf/otf file, using it in TextViews is rather straightforward.  Using it in the WebView requires some trickery with CSS we'll have to explore, though.

I have a license for all of the fonts used on iOS. Do you have access to them? Try embedding those: whitney, chronicle, gotham narrow, etc.

All I have seen are the ones in\clients\ios\Resources\fonts, which look too small to be global fonts, unless I am missing something somewhere?
The number one requested font we've had in Android feedback is NoTo, which I certainly support, but it is about 4x the size of our whole app.

Yeah, those are it. Why won't they work on Android?

Almost any font certainly should work, they just seemed too small in size to be global like most default mobile platform fonts.  I figured that we would want fonts that maintain the good i18n compatibility we have worked to provide.

Any conclusion on which fonts we will support?

I wouldn't worry about i18n compatibility with those fonts. If a user is using non-latin characters, they can use other fonts. Let's use the ones we have available: whitney, chronicle, gotham, and sentinel, as well as the 2 or 3 android specific fonts (noto).

A couple of questions:

Would you want all font changes in a single update? Or would you be happy with an initial PR to change the font on story views only then build from there?
Is there a use case for a user selecting a different font for the story view vs the rest of the app?

We don't have font options for feed and story titles, only font sizes which are already supported across the 3 platforms. So there should only be one font change: to the story detail.

Noto Sans UI from here is about 900k.
Is that the correct font as it doesn't seem as large as mentioned above.

Ah, looks like they finally released a version with the 2+MB of emoji stripped out!  That takes the unzipped size of the core font down to 299kB.  Seeing as our current APK size is roughly 700kB, I think that swings me in the direction of including it in the install rather than as a fetch-on-demand option.

OK. For an initial PR I'll include Noto and the iOS fonts.

deployed to Prod.


Krushkal Algorithm

Write a Program to implement Krushkal Algorithm for minimum Spanning Tree in C Programming language

@DankIndianCoders please assign me

pls contribute. would love to see your PR. also follow the contributing guidelines..

ADDED PR #11


add require opa env

Description
Add the check of an env variable.
Checklist

[x] I have read the policy contribution guidelines.
[x] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.

We also require DCO sign-off on all contributions.

We have to approve for first-time contributors, but yes they do run automatically.

We have to approve for first-time contributors, but yes they do run automatically.

In the test logs, I do not see my tests getting executed for the policy "validate-env-vars". Do I need to add the integration somewhere?

@wurstbrot will you please help to close this PR out?

Accepting as-is to fix in my fork.


[Cordova] Add Cordova4.x support for AppSecurityApi cases

It's fine to pack cordova 4.x privateNotes

Please provide the UT result.

LGTM


输出图像为黑色图像，使用的是官方工作流

Hi, I cant see your uploaded screenshot. Btw, we refer you to similar issues #14 or #15.

Hi, I cant see your uploaded screenshot. Btw, we refer you to similar issues #14 or #15.嗨，我看不到您上传的屏幕截图。顺便说一句，我们建议您参考类似的问题 #14 或 #15 .

好的，我将尝试


Costs statistics: use cost items or invoiced amount

default?

cost items have net and vat values, invoiced amout already includes vat

currently, net values are used


[$500] iOS - LHN - Conversation disappears from LHN when creating an IOU with a new user in offline mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open New Expensify app
Log in to your HT account
Going to offline mode
Complete the IOU with a new user
Navigate to LHN

Expected Result:
The conversation should not disappear from the LHN when creating an IOU with a new user offline
Actual Result:
Conversation disappears from LHN when creating an IOU with a new user in offline mode
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/92e3429f-1e87-454c-bf18-d79cd39d900b
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019835c6161c3d6b2f
Upwork Job ID:<PHONE_NUMBER>795932672
Last Price Increase: 2023-11-24

Waiting for proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
When in offline mode, new IOU's do not appear in the LHN area until the network connectivity is restored.
What is the root cause of that problem?
The problem lies in this section of SidebarLinksData:
https://github.com/Expensify/App/blob/a0b219711080751d6826bb2330ddd85c1641d7bf/src/pages/home/sidebar/SidebarLinksData.js#L70C1-L83
As a resolution in in PR #24596, the optionListItems are restricted to update only once the report data is completely loaded. However, if the user goes offline at any point when the report data is loading, isLoadingReportData never gets a chance to resolve to "false". It remains stuck as "true".
This means that in this line below, isLoading always resolves to true (save when the user's auth session expires) until the WiFi is connected again:
const isLoading = SessionUtils.didUserLogInDuringSession() && isLoadingReportData;
Which means that based on the lines below, the new optionsListItems are blocked from populating:
if (!isLoading || !reportIDsRef.current) {
    reportIDsRef.current = reportIDs;
}

This is the source of the problem.
What changes do you think we should make in order to solve the problem?
The simplest solution is to have SidebarLinksData have the network.isOffline prop like some other components do. And update the code area referenced above to something like:
if (!isLoading || !reportIDsRef.current || props.network.isOffline) {
    reportIDsRef.current = reportIDs;
}

This will ensure that the new optionsListItems are shown even when isLoading is stuck as "true". Additionally, it won't have the risk of the lots-of-reRendering issue from PR #24596 since isLoading should technically remain stuck while network.isOffline.
What alternative solutions did you explore? (Optional)
Another solution is to update isLoadingReportData appropriately but handling its state based on a wifi connection is significantly more complex than the solution above.

Proposal from @talhajavedmukhtar looks good to me https://github.com/Expensify/App/issues/31822#issuecomment-1832411065
I think that we should also track when user may fall in offline mode and should not block populating optionsListItems
🎀 👀 🎀 C+ reviewed

I will create the PR latest by 11:59 PM PST on 5th December.
@narefyev91 Just to confirm, you mean that we should instantly update the optionsListItems as soon as the user goes offline, instead of waiting for the next useMemo call, right?

Contract extended to @talhajavedmukhtar !
@narefyev91 could you apply to the upwork job?

Hey @talhajavedmukhtar any updates on the PR?

@narefyev91 I have been stuck trying to build the native android version of the app…
Bug is resolved on the other platforms; just need to test it on Android too before creating the PR.
Sorry for not sharing an update at the time of my proposed deadline. I made a typo; I had meant 6th December and had that time logged elsewhere.
It will be at max 17 more hours (11:59 PM PST 6th December) till I create the PR.

@narefyev91 I have been stuck trying to build the native android version of the app…
Bug is resolved on the other platforms; just need to test it on Android too before creating the PR.
Sorry for not sharing an update at the time of my proposed deadline. I made a typo; I had meant 6th December and had that time logged elsewhere.
It will be at max 17 more hours (11:59 PM PST 6th December) till I create the PR.

Cool - appreciated !

@narefyev91 finally managed to build and test the native android version. Compiling all the recordings now for the PR. Will create the PR any minute now.

Payment summary for @talhajavedmukhtar:
500 USD for C+ role in reviewing prosposal.


Nightly builds for calendar add-on

I guess that the calendar add-on will go live in next major release.
Nightly builds are made for the main application.
There are currently no way to get some (or latest) version calendar add-on!
(Please tell me if there is a way to get it without building it myself. I don't find it on Market or on NB-page)

The add-on is build every night but it seems that it's not moved to the webpage.

It's uploaded to webpage (should be), just link is missing. Give me a day or two. I currently have some other adjustments to make.

@mucek4: Can you provide the link here ?

I think this is it
http://www.cgeo.org/c-geocalendar-nightly.apk (it is an APK modified yesterday)

Just downloaded and installed, but it seems not to work:

There is no icon after having it installed (but this might be intended)
If I try to add a calendar entry from c:geo I just got the toast-message that the calendar-addon is not installed.

There is no icon after having it installed

Why should there be one?! There's no app you can launch, so there's also no launcher. ;)

I guessed so already, but what about my second point. Maybe I did something wrong, but I just installed the add-on after installing c:geo itself.

Somebody added the required add-on-check, maybe the implementation is wrong.

@blafoo: You fixed #1017 for detecting the addon availability. Can you check if there is some problem with it (see above) ?

I'll have a look.

Hudson isn't able to build the nightly. The proguard-config causes some problems:
[proguard] Warning: cgeo.geocaching.CacheDetailActivity$DescriptionViewCreator$3: can't find referenced method 'cgeo.geocaching.cgCache access$1200(cgeo.geocaching.CacheDetailActivity)' in class cgeo.geocaching.CacheDetailActivity
 [proguard] Warning: cgeo.geocaching.CacheDetailActivity$DescriptionViewCreator$3: can't find referenced method 'android.content.res.Resources access$9800(cgeo.geocaching.CacheDetailActivity)' in class cgeo.geocaching.CacheDetailActivity
 [proguard] Warning: cgeo.geocaching.CacheDetailActivity$UserActionsClickListener$1: can't find referenced method 'java.lang.CharSequence access$1400(cgeo.geocaching.CacheDetailActivity)' in class cgeo.geocaching.CacheDetailActivity
 [proguard] Warning: cgeo.geocaching.cgeoinit$35$1: can't find referenced field 'android.app.ProgressDialog val$dialog' in class cgeo.geocaching.cgeoinit$35
 [proguard] Warning: cgeo.geocaching.cgeoinit$35$1: can't find referenced field 'java.util.concurrent.atomic.AtomicReference val$fileRef' in class cgeo.geocaching.cgeoinit$35
 [proguard] Warning: cgeo.geocaching.cgeoinit$36$1: can't find referenced field 'android.app.ProgressDialog val$dialog' in class cgeo.geocaching.cgeoinit$36
 [proguard] Warning: cgeo.geocaching.cgeoinit$36$1: can't find referenced field 'java.util.concurrent.atomic.AtomicReference val$fileRef' in class cgeo.geocaching.cgeoinit$36
 [proguard] Warning: there were 7 unresolved references to program class members.
 [proguard]          Your input classes appear to be inconsistent.
 [proguard]          You may need to recompile them and try again.
 [proguard]          Alternatively, you may have to specify the option
 [proguard]          '-dontskipnonpubliclibraryclassmembers'.

Sounds more like a temporary compile issue. BTW, there is another silent change in the live-map JSON... #1216

Not temporary, no calendar nightly for the last 7 days. ;)

@Lineflyer My pull request should solve the problem of getting the error message of add-on not installed.

@campbeb: Now its working normal ! Thanks !

This error seems to be caused by the update to latest android support package (SHA: a0a3ebf78cdecbcb221a61ab94891a2007fcfbb9)
Can you edit the proguard.cfg using some of the suggestions here:
http://stackoverflow.com/questions/6560244/proguard-error-when-exporting-signed-app-using-android-support-v4-app-honeycomb
Another helpful solution:
http://stackoverflow.com/questions/7993608/i-am-getting-error-while-export-my-android-application-from-eclipse-which-use-an

No, that's not the problem. The problem is, that the calendar-add-on-build compiles the main-project with the proguard-configuration for the calendar-add-on because of the dependencies.


Pipeline fix

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.72%.  Consider uploading reports for the commit 3123dc8 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   79.72%   79.72%
=======================================
  Files          10       10
  Lines         439      439
=======================================
  Hits          350      350
  Misses         89       89

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Opts magic does not work with dictionaries with string keys and values

The parser seems to be adding extra commas, which means you can't specify font sizes in bokeh
%%opts Curve [fontsize={'title': '10pt'}]
hv.HoloMap({(i): hv.Curve(np.random.rand(10,2)) for i in range(10)})

WARNING:root:Warning: Ignoring keyword pair that fails to evaluate: 'fontsize={'title':,'10pt',}'

How does the fontsize parameter work with matplotlib? The idea is to keep the interfaces the same if possible. If this parameter no longer works with matplotlib (which seems unlikely) then there is a real issue with the parser.
Alternatively, feel free to try and improve the parser! Personally, I wouldn't immediately attempt this as I know that the  code is rather involved and fairly tricky. It would probably take a fair bit of effort to fix in a solid and general way. :-)

In matplotlib font sizes are always defined as numbers, so the parser doesn't end up adding the extra commas. It's only if the dictionary is all strings that you get this problem.

Ok, that's what I thought!
In that case why not make the bokeh backend behave in the same way as the matplotlib one? There are obvious reasons why this would be a good idea anyway and helps avoid having to spend time trying to improve the parser.

I've implemented the suggestion by @jlstevens to allow specifying the fontsizes as integers in bokeh. I've also opened #270 as a more general issue to gather examples where the OptsSpec parser fails. I'll close this issue now.

Ok great! I agree that a new issue for improving the parser is appropriate.

I don't know how much it is related but also with standard backend following works perfectly
%opts Path [fontsize={'ticks':14, 'labels':15}]

when
%opts Path [fontsize={'ticks': 14, 'labels': 15}]

throws also warning
WARNING:root:Warning: Ignoring keyword pair that fails to evaluate: 'fontsize={'ticks':,14,'labels':,15}'