Backport: HBASE-24256 When fixOverlap hits the max region limit, it is possible…

… to include the same region in multiple merge request (#1584)
Signed-off-by: stack<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m  3s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 16s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m  6s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
checkstyle
1m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 55s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

42m 27s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1695

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 7fa121eb67cc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / eb805b2f66

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 21s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
branch-2.3 passed

+1 :green_heart:
compile
1m  6s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m  9s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 27s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m  2s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
182m 10s
hbase-server in the patch passed.

210m 26s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1695

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e7c20d34fd26 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / eb805b2f66

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/testReport/

Max. process+thread count
2647 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 40s
branch-2.3 passed

+1 :green_heart:
compile
1m  5s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
5m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
192m 12s
hbase-server in the patch passed.

218m 56s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1695

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 79e6b46f3836 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / eb805b2f66

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/testReport/

Max. process+thread count
2252 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1695/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


CompactBlockProcessor - address TODOs from code base

Is your feature request related to a problem? Please describe.
Filling an additional issue to provide a link to the code base TODO occurrence. This should be ideally split into several more detailed issues once we're on solving it.
TODOs overview:

[x] updateRanges: rethink this and make it easier to understand what's happening. Can we reduce this so that we only work with actual changing info rather than periodic snapshots? Do we need to calculate these derived values every time?
[x] we still need a way to identify those transactions that failed to be enhanced
[x] refreshUtxos: cleanup the way that we prevent this from running excessively. For now, try for about 3 blocks per app launch. If the service fails it is probably disabled on ligthtwalletd, so then stop trying until the next app launch.

I am closing this as all these ad hoc issues in the code base have been resolved or moved to a separate issue.


Replace individual IdConverters for entities with a generic one

The main purpose of this PR is to replace individual IdConverters for entities with a generic one. It reduces a lot of almost the same code for each entity with a TypedId

Great, I very like this improvement.


Find a way to connect HEIR parameters to API parameter settings

Right now when heir-translate emits code for OpenFHE and tfhe-rs, the parameters expressed in the HEIR IR are ignored in the generated code.
E.g., in binops.mlir, I have set arbitrarily
#encoding = #lwe.polynomial_evaluation_encoding<cleartext_start=30, cleartext_bitwidth=3>
#params = #lwe.rlwe_params<cmod=7917, dimension=1, polyDegree=16384>

And the generated code has none of these values. Instead the test writer must manually set parameters as in binops_test.cpp.
For tests this is merely annoying, but for real production use cases we will need a way for the compiler to emit code that the client and server can use to configure their "CryptoContext" objects (or similar for other library backends) so that they use the right parameters.

Another example specific to OpenFHE, we hard-code Ciphertext<DCRTPoly> regardless of what encoding the mlir specifies.

One concern I have regarding this issue is how to safely set the HEIR parameter when it cannot be represented through a library API.
For example, in OpenFHE, the ciphertext moduli (referred to as cmod in rlwe_params) are internally and automatically calculated based on various parameters. As far as I know, it may not be feasible to explicitly set them to the 'cmod' values specified by HEIR.
In this case, should we simply ignore the cmod and proceed with code generation, or might there be a more suitable solution?

I think in the very long term we would bypass the libraries. In the medium term we could work with the OpenFHE developers to support overriding their calculations (perhaps by exposing a lower level API), and in the short term, yes I think we would just ignore our manual calculations and hope for the best.

Also, I have heard that other backends like lattigo support more fine-tuned parameter settings, so choosing a different backend is also a workaround.

I recently discussed with the OpenFHE devs and @ZenithalHourlyRate, and the OpenFHE folks seem open to this, if we wanted to do the work (with guidance) to update their API.
Meanwhile, we're adding a Lattigo backend which supports custom parameter settings already.


Updating some params of use command

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/saurabsa/azure-cli-extensions.git@saurabsa/DevSpacesParamUpdate#subdirectory=src/$EXT&egg=$EXT"

@saurabsa address static checks in CI


waypoint beacon stuck in world

I have a waypoint I removed but the rendered beacon is still present in the world and I don't know how to get rid of it.
1.20.1 Fabric.

Check that you are on the latest XaeroPlus version
A similar bug to this was fixed in July https://github.com/rfresh2/XaeroPlus/commit/6aa488773b9e245dde1140677f549dfdc0ce2723

I am.  I did have the mod removed for a while when it had the bad fps drops in caves.  Even with xaero plus removed the beacon was still there.  I deleted the waypoint then hoping that would clear it and it did not.  I then later reinstalled it all latest versions and that particular beacon is still there.

if XaeroPlus is removed and your unexpected beacon was still present that means your issue is being caused by another mod.
I'm unable to replicate your problem, all waypoint beacons are removed when waypoints are deleted for me.

I feel like a goof.  FTB Chunks is also loaded for claims, but I don't use it's map.  Well It had mapped a death location automatically.  Sorry for being a nuisance.


Announcement: RealSense self calibration webinar replay now available

Hi everyone,
An on-demand recording of the Intel RealSense webinar "Self-Calibration for Intel RealSense Depth Cameras" has been added to the RealSense webinar archives.  Please follow the steps below to view the replay.

Visit the webinar registration page at the link below:

https://webinar.intel.com/self-calibration-for-depth-cameras-webinar

Select the tick-box for the 9am or 6pm session and then fill in the registration form on the page and click the 'Register' button at the base of the form.

On the next page that states that you have successfully registered for the webinar, click the 'watch the replay' button.

On the next page, click the 'launch the presentation' button to launch the replay of the webinar.

@MartyG-RealSense @dorodnic What is the minmum SDK version and firmware version requirement for performing self calibration?

@kafan1986   The self calibration white paper recommends having at least firmware version: <IP_ADDRESS> and Librealsense version 2.33.
You can receive feedback on the depth image quality by using the SDK's Depth Quality Tool.

@MartyG-RealSense
I am using realsense SDK 2.34.1 in ubuntu 16.04 with firmware 5.12.3 connecting two D415 cameras.
I am using the following compilation flags.
cmake ../ -DBUILD_EXAMPLES=true -DENFORCE_METADATA=false -DBUILD_PYTHON_BINDINGS=true -DFORCE_LIBUVC=false -DBUILD_WITH_CUDA=true -DIMPORT_DEPTH_CAM_FW=false -DBUILD_WITH_TM2=false -DCMAKE_BUILD_TYPE=Release
When i open realsense viewer enable one of the cameras to perform onchip calibration the whole window freezes and turns grey. Any idea?
Later i ran the Depth Quality tool it opened the realsense viewer with less options and i was able to run and get some scores but it works only with first camera i am not sure if this is correct.
Could you please confirm what is the best way to perform onchip-calibration?

There was a known problem with On-Chip Calibration freezing in SDK version 2.34.0 for some users.  If you are affected, as far as I know the only thing you can do is upgrade to the latest 2.35.0 SDK version or downgrade to 2.33.1.

Dowgrading worked for me. Thanks @MartyG-RealSense

@malapatiravi   You are very welcome.  I'm pleased that it worked for you!


rewrite to rust

Go from a wrapper to a C++ library to a rust native implementation

There's one test (corresponding to WobbleSmoothed in the original ink_stroke_modeler repo that fails). Haven't figured out yet what's happening there

Ok, it finally passes tests. Not all tests are reimplemented though. Notable things missings are written in the todo.md file

It would be nice to have the steps for regenerating the docs documented or even put into a justfile / script. Ideally this would then be added to the docs CI so we ensure the hosted github pages cargo docs are always up-to-date. And the generated intermediary html/pdf files should probably be not checked in, only the source typst?

Okay, found out the reason for the panic : that was me messing up the API change and inverting pressure and time fields resulting in inputs that aren't in chronological order.
Might as well add checks on the time parameters in the modeler to catch this

From a code structure perspective this looks good to me now. Do you want to complete the rest of the tasks in the todo here or should they be done at a later time?
One other thing left to do: the README needs an update, mentioning that ink-stroke-modeler-rs is a rust reimplementation now.

I don't know. I think I can do them now relatively quickly.

changing settings might be done later (cause that'd be dependent on the document opened and dpi settings) and that might not be quick
API changes would be to change everything to f64 and use rust durations for times to have less conversions going on between rnote and the modeler
change error types to be strongly typed (at least in the ink stroke modeler and maybe later changing the code in the rnote side)

I'm finishing up changing the error types for the update calls only, the rest will probably be in a follow-up (for the API change, going from f32 to f64 seems fine although some tests fail, and I need to double check that I haven't done anything weird and come up with new tests if these fails are f32/f64 related)

Ok, I'll stop there for today

I've changed the readme as you asked
I've changed the error types for the update calls and changed the relevant code in the rnote part.

I'll do the rest of the things as a follow-up

Alright, the change to f64 also looks good to me.
I pushed one last improvement for the cpp-bindings and created the archive branch archive-cpp-bindings.
Once the new conflicts are resolved I'll squash-merge riir

Okay, conflicts are finally resolved

Awesome. Thank you so much again for doing this huge amount of work. :)


[Bug]: Text parser showing 0 as amount in LN invoice payment attempts

Describe the bug
If I scan a QR code of a LN invoice, it shows the correct amount and I can attempt to pay it.
If I paste in a text version of the same invoice instead, it shows the amount as zero (amount is also not editable).
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
iOS
Bitkit version
33
Log output
No response

I'm not able to reproduce this one. Could you do a retest or provide more detail?
https://user-images.githubusercontent.com/8538369/217229939-8b289ab4-d903-4ebb-90e8-385443b96387.mp4

Try generating an invoice from Wallet of Satoshi, that is where Reza was providing the ones that gave me trouble.


ADOT Lightstep OTLP Support

Lightstep has verified OTLP support using the ADOT collector v0.12.0.
Lightstep customers using public satellites can send traces to Lightstep using the OTLP exporter with the following configuration using a Lightstep Access Token:
...
exporters:
  otlp:
    endpoint: ingest.lightstep.com:443
    headers:
      "lightstep-access-token": "${LS_ACCESS_TOKEN}"
...

There are newer releases of upstream collector and contrib (v35) which might have breaking changes. Please rerun your tests with these weekly releases and publish your results per guidance here. We expect to have another release v36 (mid next week) which we aim to align with the stable release of tracing components. Please rerun tests for v36 version as well. We will notify you when v36 is ready for testing.

Verified OTLP exporter support with v35 collector and contrib.
As other vendors have also noted, this is testing using the native/built-in OTLP exporter.

Confirmed for the OTLP exporter in v0.36.

Closing this issue as the expected results are submitted. Please reopen the issue for any questions/concerns


Edges with UUID primary key

I'm trying to create schema objects to replicate an existing Postgres database which uses UUID primary keys and a M2M relationship between two large tables. I've found that when I create a UUID field, named id, attempting to build the project results in errors.
Profile schema:
// Fields of the Profile.
func (Profile) Fields() []ent.Field {
	return []ent.Field{
		field.UUID("id", uuid.UUID{}),
		field.UUID("uuid", uuid.UUID{}).Default(uuid.New),
		field.String("name"),
	}
}

// Edges of the Profile.
func (Profile) Edges() []ent.Edge {
	return []ent.Edge{
		edge.To("files", File.Type),
	}
}

File schema:
// Fields of the File.
func (File) Fields() []ent.Field {
	return []ent.Field{
		field.UUID("id", uuid.UUID{}),
		field.UUID("uuid", uuid.UUID{}).Default(uuid.New),
		field.String("name").Nillable().Optional(),
	}
}

// Edges of the File.
func (File) Edges() []ent.Edge {
	return []ent.Edge{
		edge.From("profiles", Profile.Type).Ref("files"),
	}
}

Error output:
pkg/testproject/database/file_update.go:184:17: cannot use eid (type uuid.UUID) as type int in append
pkg/testproject/database/file_update.go:187:44: cannot use ids (type []uuid.UUID) as type []int in argument to "github.com/facebookincubator/ent/dialect/sql".InInts
pkg/testproject/database/file_update.go:198:35: cannot use id (type uuid.UUID) as type int in array or slice literal
pkg/testproject/database/file_update.go:198:39: cannot use eid (type uuid.UUID) as type int in array or slice literal
pkg/testproject/database/file_update.go:386:17: cannot use eid (type uuid.UUID) as type int in append
pkg/testproject/database/file_update.go:389:44: cannot use ids (type []uuid.UUID) as type []int in argument to "github.com/facebookincubator/ent/dialect/sql".InInts
pkg/testproject/database/file_update.go:400:35: cannot use id (type uuid.UUID) as type int in array or slice literal
pkg/testproject/database/file_update.go:400:39: cannot use eid (type uuid.UUID) as type int in array or slice literal
pkg/testproject/database/profile_update.go:165:17: cannot use eid (type uuid.UUID) as type int in append
pkg/testproject/database/profile_update.go:168:44: cannot use ids (type []uuid.UUID) as type []int in argument to "github.com/facebookincubator/ent/dialect/sql".InInts
pkg/testproject/database/profile_update.go:168:44: too many errors

Is there a solution for this, or are UUID primary keys just not supported with edges?

Hey @forestlovewood, and thanks for raising up this issue.
I'm aware about this limitation, and it's part of my effort to allow custom-id fields (see #127).
We're working on refactoring some of the SQL storage layer, and after I finished that, this issue (and eager-loading) will be easier to fix.
I'm closing this issue because it's duplicate of #127, but I'll update this issue once it's done.


[core] Added rescu Interceptor(s) support

Added rescu Interceptor(s) support - added the possibility to use custom Interceptors.
Relates to #3272
Added rescu Interceptor(s) support to XChange library.
Based on Java ServiceLoader mechanism, so Interceptors can be easily added in client app by adding content to file:
META-INF/services/si.mazi.rescu.Interceptor

Is this something worth adding an example to the wiki/documentation for future reference?

@earce  I am going to add an example to wiki, after PR will be merged to develop

I have a few questions about this.

What are you planning on using this for?
Wouldn't this allow for a general tool for all exchange implementations for better automating collecting raw JSON responses, header values and possible errors compared to the "old way" of using logback as described on the wiki here: https://github.com/knowm/XChange/wiki/New-Implementation-Best-Practices?

For reference, here's the mmazi docs on Interceptors: https://github.com/mmazi/rescu/wiki/Interceptors

It can be used for various purposes. E.g. to record and replay HTTP requests and responses to create API mocks, for auditing purposes, custom logging requests and responses (because logging in si.mazi.rescu.HttpTemplate is not configurable, and you can log everything or nothing), to customize payload or headers - a lot of use cases for interceptors.
Sure, you can write an interceptor which collect some data and store it in the preferred format.

After https://github.com/knowm/XChange/pull/3703 all exchanges are build in the same way, so this PR is adding the possibility to use interceptors for each exchange, and it can be configured very easy.


Convert KeyboardLayout to a value type?

KeyboardLayout is currently a class, and as a reference type, it's passed by reference and not as a copy.
This has some negative side-effects. For instance, when using a layout as a template for another layout, you must copy the layout before modifying it, to avoid making unwanted changes to the original layout.
KeyboardKit 9 will convert KeyboardLayout to a struct, to avoid these potential problems.

This is done and can be tested in the v9 branch.


Runtime error when loading custom extension

Description
After installing a custom extension, Foxglove Studio generates a ReferenceError: exports is not defined (ExtensionRegistryProvider.tsx:71).

Version<EMAIL_ADDRESS><EMAIL_ADDRESS>Platform: macOS 11.6

Steps To Reproduce
$ npx @foxglove/fox create myExtensionName
$ cd myExtensionName
$ npm run build
$ npm run local-install

Open Foxglove Studio and toggle Developer Tools to see the error.
Expected Behavior
Extension should load successfully and the custom panel should be visible in the "Add panel" view.
Actual Behavior
An error is generated in the console output and the custom panel is not visible in the "Add panel" view.

To aid in debugging can you paste the bundled JS code that was generated for your custom extension? (Feel free to remove any sensitive information — just interested in the overall structure of the JS bundle)

Interesting – I can't reproduce the problem on my machine. Can you also zip up the extension from ~/.foxglove-studio/extensions/ and include that?

@stefan-pdx can you try the following steps (after uninstalling any custom extensions previously installed to rule those out):
$ npx @foxglove/fox@latest create myExtensionName
$ cd myExtensionName
$ npm run build
$ npm run local-install

Note: the change to the npx command line to ensure you run the latest @foxglove/fox version

Ah. After removing ~/.foxglove-studio/ and reinstalling Foxglove, I'm not able to recreate the issue.
Looking back at the old folder, I had what appears to be the @foxglove/fox package installed as an extension which I believe could have been the culprit. As to how that package got installed there in the first place... must've been user error.
I'm able to successfully load extensions at this point! Sorry for the false alarm. ❤


firebase-messaging-sw.js is not updated in browser

Hi, I updated the firebase-messaging-sw.js file and I had to unregister it manually in browser to update it, but I can't ask the users to do that it should be done programmatically, is there any way to solve that.

@anasbakro
I think your problem is not the scope of this repository, please ask firebase community.


"Null check operator used on a null value" during update.replace call

Hi. I use a custom row class. The only null value that I see during debug is the id(because we do copyWith)
There's a problem with the dao part where I call update(tasks).replace(task);
Exception has occurred.
_TypeError (Null check operator used on a null value)

Does this look like a bug to you? Am I missing something?
Thank you!
row class
class Task implements Insertable<Task> {
  final int? id;

  @ja.JsonKey(name: 'order_id')
  final int orderId;

  final bool finished;

  Task({this.id, required this.orderId, required this.finished});

  factory Task.fromJson(Map<String, dynamic> json) => _$TaskFromJson(json);

  bool get isNew => id == null;

  Map<String, dynamic> toJson() => _$TaskToJson(this);

  @override
  String toString() => toJson().toString();

  TasksCompanion toCompanion(bool bool) {
    if (isNew) {
      return TasksCompanion.insert(orderId: orderId, finished: Value(false));
    } else {
      return TasksCompanion(
          id: Value(id ?? 0), orderId: Value(orderId), finished: Value(finished));
    }
  }

  @override
  Map<String, Expression<Object>> toColumns(bool nullToAbsent) {
    return TasksCompanion(orderId: Value(orderId), finished: Value(finished)).toColumns(nullToAbsent);
  }

  Task copyWith({int? orderId, bool? finished}) => Task(
      orderId: orderId ?? this.orderId, finished: finished ?? this.finished);
}

dao
  Future<void> updateReplace(Task task) => update(tasks).replace(task);

call
await db.tasksDao.updateReplace(task.copyWith(finished: isFinished));

https://github.com/simolus3/drift/blob/fc7e2ab1e6d0cb793a78728a48fcb77f7f24335f/drift/lib/src/runtime/query_builder/statements/query.dart#L418

Thanks for the report! Do you have an empty primary key? Could you post the definition of the Tasks table as well?

I slightly updated the table names but the structure is basically the same
During task.copyWith the original task has the id
@UseRowClass(Task)
class Tasks extends Table {
  IntColumn get id => integer().autoIncrement()();

  IntColumn get orderId => integer().references(Orders, #id, onDelete: KeyAction.cascade)();

  BoolColumn get finished => boolean().withDefault(const Constant(false))();
}

@ja.JsonSerializable()
class Task implements Insertable<Task> {
...

The "tasks" are fetched from api and saved like this
final Set<TasksCompanion> tasksCompanions;

tasks.forEach((taskJson) {
        tasksCompanions.add(Task.fromJson({
          'order_id': orderJson['id'],
          'finished': false
        }).toCompanion(true));
      });

I checked the state. The items are being saved with no issues

The only null value that I see during debug is the id(because we do copyWith)

So to be sure, you're calling replace with a Task object that has its id field set to null? That would explain the error, but I don't think drift can do much against that (except for giving a better error message). Tasks are identified by their id and we need to know which task to replace, but we can't do that if id is null.

There were no row classes in moor and originally the code worked :)
Sorry for not providing more details. I'll try to experiment with it
oldTask = oldTaskWithIdThatIsPersisted.copyWith(finished: isFinished)
newTaskWithNoId = db.tasksDao.updateReplace(oldTask);

This is needs to be replaced with something different then
Future<void> updateReplace(OrderBlank orderBlank) => update(orderBlanks).replace(orderBlank);

You're right. This works. Thank you!
    return update(tasks)
        .write(TasksCompanion(finished: state));
  }```

Be careful with that, I think it would update all tasks and apply the finished: false column to every row. If the task has a non-null id then the copyWith/replace call should work.
You could also do (update(tasks)..whereSamePrimaryKey(task)).write(TasksCompanion(finished: state)) - but again, only if task.id is not null.


Reagent Grinders have 1000x negative inertia and are FUCKED

Description
Reagent grinders become quantum objects when unwrenched and pulled. The grinders push other entities so hard they take damage, go through walls and just teleport randomly.
Reproduction
-Find reagent grinder.
-Unwrench it.
-Pull it into other character entities.
-Chaos.
Screenshots
Screenshots are not needed to reproduce this bug.
Additional context
TurboTracker helped confirm the bug and saved multiple people I accidentally flung into walls IM SO SORRY TO WHOEVER YOU ARE!!

The electrolyzer does the same thing, I would bet the centrifuge and hot plate do it to

The electrolyzer does the same thing, I would bet the centrifuge and hot plate do it to

You beat me to saying the same thing.

The bounds aren't centered around 0 but needs checking so it might just be that.

dupe of #28028

dupe of #28028

Superseded for having better details, though?

dupe of #28028
That bug report is more worthy of deletion than anything else. It does not...
-Follow the bug report guidelines
-Give enough detail to bug fixers to triage or even properly understand the issue.
-Doesn't even use a single word like at all? No wonder it's been ignored for nearly two months.


[Android][Linux] react-native init freeze

I am using Arch Linux with Node.js v0.12.7. Installed the cli package react-native. When I run the command react-native init some-random-name, the so called spinner never stops and does nothing. Besides this the project directory gets created with 2332 files and size about ~53MB. Inside the project directory there are node_modules and package.json file. Only module that's installed is react-native.
Is there any binary run after the package installation which might be OS specific ?
How to add more debugging/verbose output for the cli commands ?

@riston please check getting started instruction for iojs version you should install instead of node. We don't support linux for now as we still have a bunch of scripts that calls applescript directly (see https://github.com/facebook/react-native/issues/2684).
One of those scripts is responsible for launching packager dev server which seems like you haven't started. To start manually you can do react-native start in your app directory

Closing this one in favor for other tasks that rely on linux support https://github.com/facebook/react-native/issues/2684

@kmagiera Why the iojs requirement? Aren't iojs and `node merged now?

@satya164 as of the latest release Node 4 is supported. The main thing is that legacy Node (0.10 and 0.12) are not supported.

@ide Ah, ok. Thanks for the clarification.


running nbqa from command-line

throws an exception:
Traceback (most recent call last):
  File "/Users/amichayoren/venv/algo/lib/python3.8/site-packages/nbqa/cmdline.py", line 127, in parse_args
    args, cmd_args = parser.parse_known_args(raw_args)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/argparse.py", line 1800, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/argparse.py", line 2034, in _parse_known_args
    self.error(_('the following arguments are required: %s') %
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/argparse.py", line 2520, in error
    self.exit(2, _('%(prog)s: error: %(message)s\n') % args)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/argparse.py", line 2507, in exit
    _sys.exit(status)
SystemExit: 2

Hi @amor71
Thanks for the report! Could you please share which command you ran?

Just typed ‘nbqa’ in the command-line . Thank you for the quick response

On Nov 1, 2020, at 4:55 PM, Marco Gorelli<EMAIL_ADDRESS>wrote:

Hi @amor71
Thanks for the report! Could you please share which command you ran?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Happy to help!
In the future, please include the full traceback when reporting an issue.
In the README there are some examples of how to run nbqa from the command-line, see https://github.com/nbQA-dev/nbQA#command-line
Closing then as it doesn't look like there's anything we need to do here, but please do let us know if you run into issues!

I suggest to show usage message(/error message if needed) and not an
exception w/ traceback... but ur call. .
On Sun, Nov 1, 2020 at 5:03 PM Marco Gorelli<EMAIL_ADDRESS>wrote:

Closed #412 https://github.com/nbQA-dev/nbQA/issues/412.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nbQA-dev/nbQA/issues/412#event-3945265158, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALTIHBD7EUPR2WHQIUOULHLSNV2ERANCNFSM4TGR5ECQ
.

That's a good point, maybe the traceback is too long and not helpful...reopening then, thanks for the feedback!

Maybe we can get some inspiration from tools like grep or git.
$ grep
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.

$ git
usage: git [--version] [--help] [-C <path>] [-c <name>=<value>]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]

These are common Git commands used in various situations:

start a working area (see also: git help tutorial)
   clone             Clone a repository into a new directory
   init              Create an empty Git repository or reinitialize an existing one

work on the current change (see also: git help everyday)
   add               Add file contents to the index
   mv                Move or rename a file, a directory, or a symlink
   restore           Restore working tree files
   rm                Remove files from the working tree and from the index
   sparse-checkout   Initialize and modify the sparse-checkout

examine the history and state (see also: git help revisions)
   bisect            Use binary search to find the commit that introduced a bug
   diff              Show changes between commits, commit and working tree, etc
   grep              Print lines matching a pattern
   log               Show commit logs
   show              Show various types of objects
   status            Show the working tree status

grow, mark and tweak your common history
   branch            List, create, or delete branches
   commit            Record changes to the repository
   merge             Join two or more development histories together
   rebase            Reapply commits on top of another base tip
   reset             Reset current HEAD to the specified state
   switch            Switch branches
   tag               Create, list, delete or verify a tag object signed with GPG

collaborate (see also: git help workflows)
   fetch             Download objects and refs from another repository
   pull              Fetch from and integrate with another repository or a local branch
   push              Update remote refs along with associated objects

'git help -a' and 'git help -g' list available subcommands and some
concept guides. See 'git help <command>' or 'git help <concept>'
to read about a specific subcommand or concept.
See 'git help git' for an overview of the system.

So there are 2 ways:

Just show usage and tell the user to call --help for more information
Show usage + a list of subcommands (supported tools in our case) and refer to help.

Either of the two options would be fine (and better than the current behavior), with the grep variant probably a bit easier on the development side and the git one a bit more comfortable for the user.

Thanks all for your feedback - how about this?
$ nbqa
usage: nbqa <code quality tool> <notebook or directory> <flags>

Please specify:
- 1) a code quality tool
- 2) some notebooks (or, if supported by the tool, directories)
- 3) (optional) extra flags

Examples:
    nbqa black notebook.ipynb
    nbqa black notebook.ipynb --line-length=96
    nbqa black notebook_1.ipynb notebook_2.ipynb

If you want to let `nbqa` modify your notebook(s), also pass `--nbqa-mutate`:
    nbqa black notebook.ipynb --nbqa-mutate

See https://nbqa.readthedocs.io/en/latest/index.html for more details on how to run `nbqa`.
nbqa: error: the following arguments are required: command, root_dirs

@all-contributors please add @amor71 for ideas

The latest release (0.4.0) shows
$ nbqa
usage: nbqa <code quality tool> <notebook or directory> <nbqa options> <code quality tool arguments>

Please specify:
- 1) a code quality tool (e.g. `black`, `pyupgrade`, `flake`, ...)
- 2) some notebooks (or, if supported by the tool, directories)
- 3) (optional) flags for nbqa (e.g. `--nbqa-mutate`)
- 4) (optional) flags for code quality tool (e.g. `--line-length` for `black`)

Examples:
    nbqa flake8 notebook.ipynb
    nbqa black notebook.ipynb --line-length=96
    nbqa pyupgrade notebook_1.ipynb notebook_2.ipynb

Mutation: to let `nbqa` modify your notebook(s), also pass `--nbqa-mutate`, e.g.:
    nbqa black notebook.ipynb --nbqa-mutate

See https://nbqa.readthedocs.io/en/latest/index.html for more details on how to run `nbqa`.
nbqa: error: the following arguments are required: command, root_dirs

along with several other improvements.
Next big to-dos are:

automatically detect when cell magics can be skipped, so we can extend support to custom cell magics defined via %load_ext
add --nbqa-diff, which would make demoing the tool a whole lot easier

Daniel I know you're keen on the latter feature, we'll let you know when it's available, and now that some other issues have been resolved, the path is clear to do start implementing it!
Thanks all for your help in improving nbqa!


Incorrect service listed in warning banner at top of page

Issue in ./help/troubleshooting/database/mysql-high-load-bottleneck-in-magento-commerce-cloud.md
This should be listed as MySQL or Database, not Redis, as Redis is not applicable in this context

jira ticket: https://jira.corp.adobe.com/browse/MSKB-1888

@nlh-ddunn Thanks for submitting this update suggestions. I will find a SME to confirm this update.

@nlh-ddunn Hi - that you so much for your contribution. One of our SMEs confirmed that the note is indeed in the wrong place but would be fine to be moved to under the solution which I have done in the published article here https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/troubleshooting/database/mysql-high-load-bottleneck-in-magento-commerce-cloud.html?lang=en
Closing this issue now


require.resolve for 'babel-preset-react'

https://github.com/boopathi/react-svg-loader/blob/d3623e97a65214a626a7fb7f7b72f368f387388f/packages/react-svg-core/src/index.js#L24
current babel-preset-react is not require.resolve
try this
presets: jsx ? [] : [require.resolve('babel-preset-react')],

why is this required? is it causing a bug for you?

like this:
https://github.com/boopathi/react-svg-loader/blob/master/packages/react-svg-core/src/index.js#L25
when react-svg-loader is a devDependencies , require.resolve can help to find module correct

now presets should be because babel upgrade
presets: jsx ? [] : [require.resolve('@babel/preset-react')],


Console log is hard to read

I try to check my log on startup every time I update a mod for errors. This is pretty minor, but it's pretty hard to read the title here when using a dark theme.

<3


Add 'default response' to API Response Type

Also some cleanup and unit tests.

@pranavkm updated in case you want to look. I'll probably merge when CI is done

Looks like the build is failing somehow, I will figure that out and then merge.


Revise install instructions

Update README.md with revised instillation instructions - docker listed as the first option.
Add/update troubleshooting section to capture gcc+mac issue, Python version, etc
Update pipeline tests to test docker on Ubuntu, Mac, Windows. Misguided
Update Devito instillation documentation under docs to point at README.md (ie enforce single source of truth). Done

The first task on this: "Update pipeline tests to test docker on Ubuntu, Mac, Windows." is on @tmbgreaves

Could you fill me in a bit more on this please? I don't think I entirely understand the question.
Docker ought to be host-independent - ie, the container the tests run in shouldn't have any knowledge of the system the container is running on, and indeed I don't think we get an information about what the host OS is for the Pipelines runs. The container itself as far as I know doesn't have any ability to have Windows or OS X on the inside -- OS X licensing would preclude this as I understand it, and I have no idea how you would implement Windows-in-a-container :-)

Perhaps we are talking past each other. According to https://azure.microsoft.com/en-gb/services/devops/pipelines/ we should be able to "Run in parallel on Linux, macOS and Windows".

Docker ought to be host-independent - ie, the container the tests run in shouldn't have any knowledge of the system the container is running on

I think the idea is to verify this assumption so that we can s/ought to/is, s/shouldn't/doesn't

Perhaps we are talking past each other. According to https://azure.microsoft.com/en-gb/services/devops/pipelines/ we should be able to "Run in parallel on Linux, macOS and Windows".

I have no idea how they do that, but will figure it out!

Docker ought to be host-independent - ie, the container the tests run in shouldn't have any knowledge of the system the container is running on

I think the idea is to verify this assumption so that we can s/ought to/is, s/shouldn't/doesn't

If that breaks, Docker is in trouble :-)

Looking into this a bit more, from:
https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml
we can run with either Ubuntu or Windows pools for docker. I'm assuming they're running Docker Enterprise there to allow both to co-exist. What's not clear to me at the moment is how they deal with the duality, as I'd understood one of the key benefits to containers was not having to replicate any of the OS-level processes (in particular, the kernel). I'd thought that to run Docker on Windows you did have to replicate the kernel in as much as you ran a Linux VM which then had a single kernel instance for all containers, but a first look at the documentation suggests that's no longer the case and somehow they're running natively -- and somehow can run both linux and windows nodes on the same host.
If that's the case I'm marginally less confident that there wouldn't be any problems switching between them, but only marginally. Docker regularly push the line that the container will never see any difference arising from changing the host, and I would expect any issues that did come up there would be both a docker problem, not a devito problem, and caught well before anything moved into production. Yes, we could test for it, but I think we'd be both needlessly increasing our testing burden and vanishingly unlikely to ever catch a problem.
The option to run a Windows container sounds far more useful to Devito, but since I've not run anything in Windows for a long time I would have quite a long spin-up time investing in learning to make it happen. I can do it if there's nobody else with the requisite skills, but I don't use windows anywhere else from a user or service perspective so it would be a fairly expensive single-use investment.
The OS X option appears to be non-container, just installing directly onto the node. I'm marginally more clued up with OS X than Windows but haven't used it in some five or six years and then only as a graphical terminal so would have a fairly steep learning curve again, plus I don't have an OS X system to test on, so it would probably be a lot more efficient to get someone who's installing on OS X already to write a script for pipelines. Again, if there's nobody available I can figure out how to do it but it seems like I would be an inefficient choice of person :)

Ok my earlier understanding might have been mistaken. I think a critical issue is that the docker image we are using for testing is different from the docker image we use for the "recommended install". Can we make it consistent?

I think that's achievable, but needs a little bit of post-testing tweaking -- changing the entrypoint and adding Jupyter in the case of the existing pipelines container.

I understand when you talk about changing the entry point -> the two purposes probably need two different entry points. It is not clear to me whether you think there any other (required) differences between the two?

I've revised the initial issue. In particular I concede that we just want to test with a ubuntu pool and docker should "just work" on other systems (ie we shouldn't have to test that Docker works).
However, user install instructions based on docker should be using a tested docker configuration. Therefore, there is still a strong motivation to having a single tested/trusted docker file rather than the current situation. @tmbgreaves @navjotk can we look at merging these?

Sorry - this got shunted off my list and just realised I haven't replied. I'll look at a merge.

First attempt at this pushed to the dockerfile-merge branch. This is using conda-supplied jupyter, running as a non-root user, and at the moment has the full devito repo exposed to jupyter, which probably needs some trimming -- though still needs to be enough for the full install-test cycle in pipelines.
Some thought may also need to be given to the default build-time parameters in the Dockerfile.
I've tried building this then running examples in the notebook, which seem to run as expected.
Feedback requested :-)

Can be related to PR #959.

can we close this now @navjotk @mloubout ?


.exe file is missing from the versions after v1.31.2

In the OpenShift tools Installer action we support the installation of CRC on the Windows platform.
For Windows OS this works using .exe file but it seems after version 1.31.2 .exe is replaced with MSI files.
To be able to support installation in Windows we definitely need exe files as we need to run this action without admin permissions and the MSI file needs admin permissions.
By any chance, can we get exe file back?
Ref: https://github.com/redhat-actions/openshift-tools-installer/issues/50
cc @jduimovich @tetchel

@divyansh42 How did you perform  the crc setup then before running crc  start for those action because even in case of exe file we do need to run the setup for administrator privilege to perform like enabling hyperV or usermode networking side.

Unfortunately we will not be offering phat-binaries anymore. The install process as mentioned before crc setup was too involved and made the binary bloated. While it allows to easily move files around, it leaves a multitude of large files on the disk (eg. 2+ GB binary, 2+ GB bundle, 3+ GB disk image, etc).
The MSI is a single time affair. Or use the msi from the command line with msiexec ?

Did you manage to integrate the new installation process in your tools? Or do you need more help from our side for this?
@divyansh42 @tetchel @jduimovich ?

Due to some other priorities, we were not able to devote much time to this.
I'll update this issue in case some help is needed from your side.
Thanks!


Spending staking balance #1294

Closes #1294
If wallet has just 1 UTXO -> start Staking -> make transaction => Staking will be temporary stoped till new UTXO get enough depth(20/50 without "activation").
If within that time call GetStakingInfo() it will return old invalid values for "weight" & "ExpectedTime". That's what this PR will fix.
If stop Staking => rpcGetStakingInfoModel will be reseted.

@kogot can you please write Closes https://github.com/stratisproject/StratisBitcoinFullNode/issues/1294 at the top of the page in your first comment? This way the issue will be closed automatically when this PR is merged.
Thanks!

Currently reviewing, I am happy to run the whole unit testing suite and try staking on that PR if people think it is needed :)

@monsieurleberre I did many different tests in testnet, staking-spending-staking...
You're more than welcome to try staking and run all unit tests ;)

Just tried the staking, and yes it does work :) but I think I shot myself in the foot by spending a big coin during the test and now I only have 10 strats mature enough to stake. I will wait for the 499,990 other strats to mature again and update you :) I'm sure it's all good though 👍

@Aprogiena @monsieurleberre please check.

I'm okay with that. I would prefer not having the pause method at all because I don't see any benefit of having it and I would always call the stop one.

I'm just hoping that one day people will learn to write good comments, LOL


Kong with consul dns to query SRV (consul dns) records

#1095
Kong will be out in 0.1.0 SRV query support?
I now through the allocation
dns_resolver: server
dns_resolvers_available:
   server:
   address: "<IP_ADDRESS>:53"
Configuration, how do I fill in 'upstream_url'?
Now whether kong support SRV query?
kong version:0.9.7

This will be supported in 0.10.0. There is an RC1 available that you can try to use now if you want, but it's not stable yet.

Is there more than one instance of the same service name that is also supported in version 0.1.0?
RC1 Do you have an address ？

@huyifanstar here's a description of how it works; https://github.com/Mashape/kong/issues/157#issuecomment-238205952

@thefosk   I have seen version 0.10.0rc1. Is there a dockerfile?

not that I know of


Implement uninstall command [BW-783]

Tested by repeatedly installing and uninstalling jupyter. I can't speak for its efficacy against any other apps.
Note: to avoid whitespace noise, this depends on #14

@cjllanwarne this works for me? Shall we merge this PR?


how to reload cells in Embedded collection view using ListCollectionViewLayout

is there any way to reload cells or whole section using EmbeddedCollectionViewCell using  ListCollectionViewLayout . this peice of code isnt reloading cells or sections...?
 let controller = adapter.sectionController(forSection: 0) as! ListSectionController
                 controller.collectionContext?.performBatch(animated: false, updates: { (batchContext) in
                  batchContext.reload(controller)
          })

Info : 'IGListKit','~> 3.4.0'
Xcode : 9.4.1, iOS 11

Well need a lot more info to help out here. Reloading only happens when the cells data changes (isEqualToDiffableObject: returns NO). Is your data changing?
A sample project would go a long way to us helping.
Sent with GitHawk

@rnystrom  I'm creating brand new structs for the child controllers, and just like the person who opened this issue, my nested controllers are not updating the cells properly, the only way it's working is if I perform a batch update


feat: mirgate desktop_device.dart to null safety

migrate desktop_device.dart to null-safe
List which issues are fixed by this PR. You must list at least one issue.
https://github.com/flutter/flutter/pull/88081
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Hixie  this pr need an test exemption

@jmagman null safe mirgate pr


[KYUUBI #1263] Kyuubi auxiliary UDF failed on Spark Yarn mode

Why are the changes needed?

Closes https://github.com/apache/incubator-kyuubi/issues/1263
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @zhaomin1423 @yaooqinn @pan3793

Can we add this case in Yarn test?

Thanks, merging to master/1.3


[Windows] Why the initial project call Destroy() inside Win32Window::CreateAndShow, that's not make sense

Run flutter create test
Check the win32_window.cpp under runner folder
Check the CreateAndShow() method
It calls Destroy() at the beginning and that makes OnDestroy() running. It does not meet the semantic.

Imagine that we want to do something only while user closes the app. We put the code inside OnDestroy(), but BOOM it just came out as soon as the app is launched. It's not make any sense.
bool Win32Window::CreateAndShow(const std::wstring& title,
                                const Point& origin,
                                const Size& size) {
  Destroy(); //<----  That's not meet the semantic.

  const wchar_t* window_class =
      WindowClassRegistrar::GetInstance()->GetWindowClass();

  const POINT target_point = {static_cast<LONG>(origin.x),
                              static_cast<LONG>(origin.y)};
  HMONITOR monitor = MonitorFromPoint(target_point, MONITOR_DEFAULTTONEAREST);
  UINT dpi = FlutterDesktopGetDpiForMonitor(monitor);
  double scale_factor = dpi / 96.0;

  HWND window = CreateWindow(
      window_class, title.c_str(), WS_OVERLAPPEDWINDOW | WS_VISIBLE,
      Scale(origin.x, scale_factor), Scale(origin.y, scale_factor),
      Scale(size.width, scale_factor), Scale(size.height, scale_factor),
      nullptr, nullptr, GetModuleHandle(nullptr), this);

  if (!window) {
    return false;
  }

  return OnCreate();
}

void Win32Window::Destroy() {
  OnDestroy();

  if (window_handle_) {
    DestroyWindow(window_handle_);
    window_handle_ = nullptr;
  }
  if (g_active_window_count == 0) {
    WindowClassRegistrar::GetInstance()->UnregisterWindowClass();
  }
}

[✓] Flutter (Channel stable, 2.10.5, on macOS 12.4 21F79 darwin-x64, locale en-CN)
    • Flutter version 2.10.5 at /Users/shaowensu/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (3 months ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

Hi @ShaowenSu, thanks for filing the issue.
On master, the Destroy() is called on CreateAndShow method:
https://github.com/flutter/flutter/blob/2f0a25257e485e724f0daa4af99e63fd04a8fc5d/packages/flutter_tools/templates/app_shared/windows.tmpl/runner/win32_window.cpp#L105-L109
This looks like a proposal. Could you please describe what you would like Flutter to be able to do?

Hi @ShaowenSu, thanks for filing the issue. On master, the Destroy() is called on CreateAndShow method:
https://github.com/flutter/flutter/blob/2f0a25257e485e724f0daa4af99e63fd04a8fc5d/packages/flutter_tools/templates/app_shared/windows.tmpl/runner/win32_window.cpp#L105-L109
This looks like a proposal. Could you please describe what you would like Flutter to be able to do?

Hi @huycozy, I am thinking, calling Destroy() on CreateAndShow is not making any sense. It doesn't  meet the semantic. For example, I would put something inside OnDestroy() such like Closing the file, Disconnecting the network, Cleaning the systray, etc., but since Destroy() is called on CreateAndShow, which would be called every time the application is launching, then OnDestroy() will be called at the same time, this mess up everything.
What do you thing?

@ShaowenSu thanks for your update. Labeling the issue for further opinion from the team.

This is definitely a valid criticism.  We should see what happens if we just don't call Destroy, and if necessary, refactor OnDestroy into OnCreate and OnDestroy.

This is definitely a valid criticism. We should see what happens if we just don't call Destroy, and if necessary, refactor OnDestroy into OnCreate and OnDestroy.

Yes, I have tried to remove the Destroy() call from CreateAndShow(). Nothing happens.


Syntax error due to records even when records aren't enabled

Consider this snippet:
// @dart = 2.12
@MyAnnotation
(

)
void main() {

}

This parses correctly with the current stable SDK (for reference, I'm on 2.18.6). Running it with Dart 3.0.0-89.0.dev prints this error, however:
test.dart:4:1: Error: Expected a declaration, but got '('.
(
^
test.dart:6:1: Error: Expected a declaration, but got ')'.
)

I assume this is due to the ambiguity records have around annotations, so this is rightly a syntax error if records were enabled. They aren't though, and so I'd still expect newer Dart versions to be able to parse that snippet.
This affects not only the CFE but also the analyzer, which means that analyzer versions using _fe_analyzer_shared version 0.52.0 are unable to parse what's currently valid Dart.

@jensjoha

This is expected as it's a breaking change. From the specification that was also linked above:

Breaking change: Existing metadata annotations with whitespace before their argument lists will no longer parse correctly. In a corpus of 18,672,247 lines of code containing 409,825 metadata annotations, 46,245 had argument lists and none of those had whitespace before the argument list. Note that this analysis only captures code that has been committed. Code being written may be less well formatted, but we expect problems from this to be rare.
Because this change does not seem to break a significant fraction of code in the wild and our parser is currently not aware of language versioning, we make this grammar change unconditionally when parsing a Dart library targeting any language version.


March Trustnet report

To be published before end April.

Report now published.

It's here!
https://trustnet.wellcome.org/news/march-2021-report-wellcomecollectionorg


Improve test coverprofile

Description
The current default for the test --coverprofile flag is coverage.json, i.e. creating a non-standard JSON-based coverage file. (@m-Peter or does the JSON format follow a particular "standard"?).
Switch the default to the LCOV file format, which is widely supported by tools, in particular the common file name lcov.info. Note that LCOV files are info files. To make this work, also add support for .info extension.
For example, this allows using Visual Studio Code extension Coverage Gutters:

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (606ca7a) to head (977fd87).

Files with missing lines
Patch %
Lines

internal/test/test.go
0.00%
5 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1801   +/-   ##
=======================================
  Coverage   28.47%   28.47%
=======================================
  Files          95       95
  Lines        6490     6490
=======================================
  Hits         1848     1848
  Misses       4462     4462
  Partials      180      180

Flag
Coverage Δ

unittests
28.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Description
The current default for the test --coverprofile flag is coverage.json, i.e. creating a non-standard JSON-based coverage file. (@m-Peter or does the JSON format follow a particular "standard"?).
Switch the default to the LCOV file format, which is widely supported by tools, in particular the common file name lcov.info. Note that LCOV files are info files. To make this work, also add support for .info extension.
For example, this allows using Visual Studio Code extension Coverage Gutters:

@turbolent Good catch :clap:
The JSON format does not really follow any established standard out there, it was just the first type of format which was added.


Expose more information to enable pan/zoom/rotation

This module is very useful. Together with mouse-event, it got me pretty far toward solving my interaction goals. I had to tack on additional features though to get it to pan and pinch smoothly (e.g. you pinch but then one finger leaves and it turns smoothly into a pan).
You can see an example here (enabled if Modernizr.touchevents === true): http://rickyreusser.com/grid-generation-experiments/
The code for panning/pinching is here: viewport.js#L97-L179
My code is mostly garbage, but the pattern is pretty straightforward and self-contained and with lots of cleanup seems like it has a home somewhere. Specifically, I found that distance between fingers wasn't quite enough information for me, so I had to dig a little and expose a bit more. It seems to me that a transform event that exposes translation, scaling, and optionally rotation would be a natural addition that could be easily be plugged into a transformation matrix.
So my question is this: Does a module like this already exist? I'd be glad to submit a PR if you think there are reasonable additions to this module, but I also don't want to fall into feature creep for what's otherwise a perfectly useful and straightforward module. Thanks!

Thanks for testing it out. :smile:
How do you think the API would look? I'd be willing to accept a PR for transform.
Myself and @tatumcreative will be using this module for panning/zooming/etc in orbit-controls, it looks like your PR would help move things along. :+1:

Gotcha. Yeah, my concern at the moment is 2D-oriented. orbit-controls is exactly what I was wondering about though. It felt like this was getting plugged into something, but I wasn't sure what. I'll put some thought into this and see if I can isolate the minimal additional amount of info I'd need to expose to get what I need out of it.
Things I'm interested in exposing:

one finger panning
two finger pinching (yields information about pan, zoom, and rotation)
inertia (not as part of this; would look like a wrapper that plugs into position and velocity and continues triggering view changes, perhaps…)

Of course although it's 2D information, its usefulness would not be limited to 2D.
I'll think about this and see if I can clean up these thoughts. Thanks for the feedback!


order creator buttons a-z

Do we really want to make it alphabetical?  Does it make more sense to mirror the folder display order in directory (keeping "Property" next to "Datamodel", and "Cohort Query" next to "Dataset Query" for example)?


Fix wrong rotation matrix for orbit z velocity

Closes https://github.com/godotengine/godot/issues/84033
Closes https://github.com/godotengine/godot/issues/84035

I'm not an expert, but comparing to this image from Wikipedia, X and Y are also incorrect:

Is this true?

Maybe this difference is about clockwise and counterclockwise?

I just tested on top of this PR and it seems to all work fine, so i'm not sure if matrices should change ..?

@QbieShay What I am certain of is:

The old code is wrong.
The change in this PR is also wrong (because it's not consistent with the other cases).

Or is this because of the coordinate system that we use?

@YuriSizov Fortunately, all coordinate systems agree on rotation: X to Y around Z (not Y to X), Y to Z around X (not X to Z), and Z to X around Y (not X to Z). This is a matter of correctness. The only tricky part is to remember if we are working with rows or columns. Usually code works with columns since it's more geometrically intuitive. I referenced this wiki page which indicates mat3 uses columns (see // first column (not row!) and mat3 n = mat3(column0, column1, column2); // sets columns of matrix n).

Thanks y'all. I think it's fixed now.

Thanks Clay! Updated and tested.

Oof, I just realized that checking the type of the texture won't update the MaterialKey as the MaterialKey only checks for the existence of the texture. So we need to add a new flag :(

Updated!

Thanks!


Bugfix 924 token inconsistent

What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #924
Special notes for reviewers:

Please check the following list before waiting reviewers:

[ ] Already committed the CRD files to the Helm Chart if you created some new CRDs
[ ] Already added the permission for the new API
[ ] Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

fix the bug that pipelinerun not run created by a new user

/cherrypick release-3.4

/lgtm
/approve


Do not generate inputs when PC has PHI

WIP

needs a refresh to fix conflicts
also again I want you to use the "draft pull request" feature in github for things like this

what's status of this PR @manasij7479 ?


Not working on ARM64

Although I found closed issues that claim there is multi arch support I ran into this problem:
I ran the command
gitup beta run ...

The K8s cluster is on Raspberry Pi.
The command created a deployment run-dev-bucket that created a pod.
This pod fails with exec /gitops-bucket-server: exec format error
gitops version
Current Version: 0.28.0
GitCommit: 3ad24e719c66f01efa755072476e3aa5efb3e1c9
BuildTime: 2023-07-19T18:04:30Z
Branch: releases/v0.28.0

@guidoffm thanks for opening this! We already have another ticket open for it. So I'll link it below and close this one.
Duplicate of #2971


Critical Bug: "Release" Button should apply only to Admins

When a work type is claimed, the "Claim" button should change to a "Request" link for every other user except for Admin users. Admin Users should see a "Release" button.
Bug: Currently non-admin users see the "Release" button. This is a critical bug.

Correction: This is an incident setting. It is expected behavior.


Try to download audiobook, error : Skipping subscribtion entity

I get an error when I try to download an audiobook through the kobodl downloader.
The error is:
Skipping subscribtion entity
I printed the content of the bookMetaData, and the data looks valid. Maybe not yet implemented support for those type of subscriptions?
Nice project btw!

Try getting the book directly by its identifier.
kobodl book get <RevisionID>


[DOCS] Explain aliased imports like '@' and '@theme'

It is not clear from the documentation what '@' and '@theme' mean.
When overriding / copying a component from the base theme it is confusing what import like this actually do
import SwTopNavigation from<EMAIL_ADDRESS>import SwTopNavigation from<EMAIL_ADDRESS>@import "@theme/assets/scss/variables";
I found some of the code that makes these imports happen, but it would be nice to have some proper documentation for this.
https://github.com/vuestorefront/shopware-pwa/blob/master/packages/nuxt-module/src/module.ts#L84
Acceptance criteria

[ ] Explain the different available options for importing componentsn / oode;
[ ] Update the Cookbook: https://shopware-pwa-docs.vuestorefront.io/landing/cookbook/

Hello! we are still working on the documentation, thanks for pointing an unclear area of that.
Basically, it can be described as:
@theme - alias that points the directory, where the theme is configured in shopware-pwa.config.js file under theme property. so by default it's @shopware-pwa/default-theme, and it's inside your node_modules, unless the value for theme option i provided.
@  - alias always points the files in your local project files (where nuxt.config.js and shopware-pwa.config.js files are located) %project_dir%/src/
Basically that's it. Now, see a working example.

Let's override some component from @shopware-pwa/default-theme, to do so, run shopware-pwa override command and pick up the SwLogin component from the list.

✔ Type or select component to override · /SwLogin.vue
[CLI > override] Component overrided. You can edit it in src/components/SwLogin.vue

do some customization in the recently created file.
create some page, like src/pages/test.vue which may look like:

<template>
    <div>
        <ProjectSwLogin /> this will display a customized local one
        <DefaultThemeSwLogin /> this will display a default one
    </div>
</template>
<script>
import ProjectSwLogin from<EMAIL_ADDRESS>import DefaultThemeSwLogin from<EMAIL_ADDRESS>
export default {
    components: {
        ProjectSwLogin, // your local component, created within override CLI command - customized
        DefaultThemeSwLogin // base component, still in @shopware-pwa/default-theme - untouched
    },
    setup() {
        return {

        }
    }
}
</script>

Thanks to the aliases, you can mix imports and use both, from theme you inherit and the local project you are currently working on.

Thanks for the clarification!
If I can find the time, I will try to use the provided explanation and make a merge request to update the docs!


How can i add cross hair sign on images in crosshair feature.

Prerequisites

[ ] Which version are you using? (Is it latest?)yes
[ ] Are you reporting to the correct repository?yes
[ ] Did you search existing issues? (Were any related?)yes

Description
I am working on to implement the crosshair feature using cornerstone library so how can i draw a crosshair sign on images and how can i know the location of matching pixel  on other images.

What have you tried? We have a number of tools that either accomplish this, or implement or portion of the features you're describing. I recommend looking at their source for inspiration.

I took the code reference for cross hair functionality as mentioned in Cornerstone Tools examples.
It is working but there is no cross hair sign on images so my question is how i can achieve this.
// Init cornerstone tools
cornerstoneTools.init()
// ...
// Enable our elements
const scheme = 'wadouri'
const baseUrl = 'https://mypacs.com/dicoms/'
// Create our Stack data
const firstSeries = [
'image_1.dcm'
]
const secondSeries = [
'image_11.dcm',
'image_22.dcm',
'image_33.dcm',
'image_44.dcm'
]
const firstStack = {
currentImageIdIndex: 0,
imageIds: firstSeries
.map(seriesImage => ${scheme}:${baseUrl}${seriesImage});,
};
const secondStack = {
currentImageIdIndex: 0,
imageIds: secondSeries
.map(seriesImage => ${scheme}:${baseUrl}${seriesImage});,
};
// Create the synchronizer
const synchronizer = new cornerstoneTools.Synchronizer(
// Cornerstone event that should trigger synchronizer
'cornerstonenewimage',
// Logic that should run on target elements when event is observed on source elements
cornerstoneTools.updateImageSynchronizer
)
// Add and activate tools
cornerstoneTools.addTool(cornerstoneTools.StackScrollTool);
cornerstoneTools.addTool(cornerstoneTools.StackScrollMouseWheelTool);
cornerstoneTools.setToolActive('StackScroll', { mouseButtonMask: 1 });
cornerstoneTools.setToolActive('StackScrollMouseWheel', { });
// load images and set the stack
const firstLoadImagePromise = cornerstone.loadImage(firstStack.imageIds[0])
.then((image) => {
cornerstone.displayImage(firstElement, image)
// set the stack as tool state
synchronizer.add(firstElement)
cornerstoneTools.addStackStateManager(firstStack, ['stack', 'Crosshairs'])
cornerstoneTools.addToolState(firstElement, 'stack', firstStack)

})
const secondLoadImagePromise = cornerstone.loadImage(secondStack.imageIds[0])
.then((image) => {
cornerstone.displayImage(secondElement, image)
// set the stack as tool state
synchronizer.add(secondElement);
cornerstoneTools.addStackStateManager(secondElement, ['stack', 'Crosshairs']);
cornerstoneTools.addToolState(secondElement, 'stack', secondStack);

})
// After images have loaded, and our sync context has added both elements
Promise.all([firstLoadImagePromise, secondLoadImagePromise])
.then(() => {
const tool = cornerstoneTools.CrosshairsTool;
cornerstoneTools.addTool(tool);
cornerstoneTools.setToolActive('Crosshairs', {
  mouseButtonMask: 1,
  synchronizationContext: synchronizer,
});

});

did you get some progress?


Addition // on syntax as comment

I add one alias that as --, but i can't add one more allias /* */ that as --[[ ]]

for gmod.


SSL/TLS support

Hi, I'm trying to publish to a rtpms url and getting this error "ERROR: PILI_RTMP_Connect1, no SSL/TLS support". You have intentions to do so in the near future.

https://github.com/LaiFengiOS/LFLiveKit/issues/237

@danimirb Hi, how did you resolved this issue? I tried as #237, but I can't config the podspec correctly. Could you please share your solutions?  Thanks.


Contribute to Airbyte docs

Issue description

“Orchestrate Airbyte syncs with XXX" - add a PR here https://github.com/airbytehq/airbyte
also add PR here https://github.com/airbytehq/airbyte-platform

completed in https://github.com/airbytehq/airbyte-platform/pull/262


Handle special characters in modular model name

For example:
model *BIOMD0000000001()

Implemented in https://github.com/sys-bio/vscode-antimony/commit/2b9c90c93a13285fc08cf4b121053e334f98ce11
Allowing at most one "*" character in front of model name, will revisit if there's additional special characters in BioModels.


Update README.md

add project setup step to readme

Good point.

super appreciative of the repo btw!

I'm glad if you get some use out of it :)


Add HashMap::get_key_value_mut

This new API exposes a way to modify a value of an HashMap while keeping
a reference to the relative key. The other safe way of doing this is
using the RawEntryMut API, which could easily lead to an
inconsistent state of the map if misused.
Closes #144

@bors r+

:pushpin: Commit 1e7bf4064b33976e69d3dd2d5589b5fab24c1df2 has been approved by Amanieu

:hourglass: Testing commit 1e7bf4064b33976e69d3dd2d5589b5fab24c1df2 with merge 6f8703de856993dd89dbf0239e6fb87b7f384b83...

:sunny: Test successful - checks-travis
Approved by: Amanieu
Pushing 6f8703de856993dd89dbf0239e6fb87b7f384b83 to master...


Add functionality to roll up all NHS charges into a single invoice

Sort of done - we can display the total turnover from only NHS patients in a period, but not in an invoice format

Sort of done - we can display the total turnover from only NHS patients in a period, but not in an invoice format


Update types to fix build on ppc64le

[x] I agree to follow the project's code of conduct.
[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

libc::c_char is a u8 on ppc64le. Using the type definition from libc fixes it (maybe for other archs too).

Thanks! Can you also add the changelog entry?

bors r+


Remove unintended comment in BeamFnLoggingClient

This commented out line seems to have been accidentally left in. Creating this PR to see if it can be un-commented.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

R: @robertwb
This line was commented out in #4214, so adding you for context just in case it was intentional.

Run Java PreCommit

R: @lukecwik


Not able to use Mediapipe as external dependency with commit b6e680647cebf925ebc6a3f82b469d57c1c68da9.

Hello guys,
I've been trying to use MP as external dependency based on this example from @mgyong by setting up my WORKSPACE like this
(@hadon coomit) and setting Mediapipe's mos recent third_party folder in my project. When I build bazel build //helloworld:hello_world_calculator_test, I get internal dependency conflicts like:
ERROR: /home/luis/.cache/bazel/_bazel_luis/227c0b8a664619321580c767b709fd29/external/org_tensorflow/third_party/py/python_configure.bzl:271:27: in call to repository_rule(), parameter 'remotable' is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_repo_remote_exec ERROR: error loading package '': in /home/luis/.cache/bazel/_bazel_luis/227c0b8a664619321580c767b709fd29/external/org_tensorflow/tensorflow/workspace.bzl: Extension file 'third_party/py/python_configure.bzl' has errors INFO: Elapsed time: 0.099s INFO: 0 processes. FAILED: Build did NOT complete successfully (0 packages loaded)     Fetching @io_bazel_rules_closure; fetching
Thanks in advance.

As the error message suggested, you can append --experimental_repo_remote_exec to the Bazel build command.

My bad. Thanks a lot!


Charts Break when data is not available

Describe the bug
I am using Chart component to render my timeseries data.
The source for timeseries data is iot-sitewise.
When I choose a timerange where data is not available for some timeslots, I can see the Chart populated with the data points when available as below:

However, as soon as the chart is rendered, I get the aggregate error as shown below.

I tried setting the aggregationType to 'AVERAGE' and resolution to "0", "1m", "1h" to see if I can resolve this error, but it does not seem to help.
Below is the timeseries data query :
{
  assets: [
		{
		  assetId: assetId,
		  properties: [
					{
					  propertyId: property.id,
					  refId: property.id,
					  aggregationType: AggregateType.AVERAGE,
					  resolution: "0"
					},
				],
		},
	    ]
}

To Reproduce
Steps to reproduce the behavior:

Choose a time range where data is not available from iot-sitewise source
See the error in UI.

Expected behavior
Error should not be seen in the UI.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 10 Pro
Browser: Edge
Version:  122.0.2365.59 (Official build) (64-bit)

Additional context
I can see a similar error in the issue: https://github.com/awslabs/iot-app-kit/issues/2605

thank you for your report! we have assigned this bug and are working on a fix

Hello! Can you help me with reproduction steps, what are the version numbers you are using?


The rouge highlighter UI breaks when linenos option turned ON

Preview:

Live Demo: http://java.ramswaroop.me/2015/06/30/constructors.html

Thanks for the report.
This is caused as table is forced to 100% width, and Rouge uses the table for the line number feature.
I'll add in this work-around, since I normally want full-width tables:
/* Work-around for Rouge highlighter */
pre table {
    width: inherit;
}

Great! Thanks for such quick response.


Add Gateway status to enable more integrations

What does this PR do?
Looks up the LoadBalancer Status of a configured Service Ressource and adds the appropriate Gateway Status
Motivation
Use external-dns with Traefik v3 and Gateway API
More

[ ] Added/updated tests
[ ] Added/updated documentation

Additional Notes

Superseded by https://github.com/traefik/traefik/pull/10582


Add support for FAKE image provider

What would you like to be added:
It would be nice to provide a FAKE image provider to deal with the rate limit from the container registry.
The FAKE container registry is deployed at the control-plane, and you can store the metadata about newly updated images whenever you want to (e.g. on your CI).
https://pipecd.dev/docs/operator-manual/piped/configuring-image-watcher/#fake
What we actually need:

[ ] New pipectl sub-command to upload the core of image manifest (repoName and tag are enough) by @nghialv
[ ] gRPC API to store the manifest sent by the above command by @nghialv
[ ] Piped API to give back the latest tag so that the FAKE image provider works properly by @nakabonne
[ ] FAKE provider implementation that meets the imageprovider.Provider interface by @nakabonne

/assign @nghialv

/assign @nghialv

Just an idea, we may don't have to require users to install pipectl if we could implement Docker Registry HTTP API V2:
docker login --username pipecd --password ${{ secrets.PIPECD_ACCESS_TOKEN }} https://PIPECD_SERVER_ADDRESS

docker push gcr.io/foo/bar:v0.1.0

Not sure it's possible to use different hosts between using when login and using when pushing, but I feel like it's worth adding to the future roadmap.

Just an idea, we may don't have to require users to install pipectl if we could implement Docker Registry HTTP API V2:
docker login --username pipecd --password ${{ secrets.PIPECD_ACCESS_TOKEN }} https://PIPECD_SERVER_ADDRESS

docker push gcr.io/foo/bar:v0.1.0

Not sure it's possible to use different hosts between using when login and using when pushing, but I feel like it's worth adding to the future roadmap.

It's a good idea to eliminate the dependency on pipectl.
Although there are some concerns about authentication and the complexity of the API,
but it looks interesting to dig deeper later.

It's a good idea to eliminate the dependency on pipectl.
Although there are some concerns about authentication and the complexity of the API,
but it looks interesting to dig deeper later.

No longer needed this issue due to https://github.com/pipe-cd/pipe/issues/1381
/close

No longer needed this issue due to https://github.com/pipe-cd/pipe/issues/1381
/close


Cookie dismiss button contrast

Hi. Not sure if this is the right way/place to report it, but the hover style on the cookie banner on blog pages is black on very dark grey when hovering:
https://user-images.githubusercontent.com/128088/141995025-a912b8eb-660b-4104-bbf9-3d8e4722c067.mp4

Hi Peter, thanks for raising this. I can replicate the issue on production - I've raised a ticket in our internal system to get a fix for this put in place, and we'll update you here once that is deployed.

Hi Peter. That has been fixed and is deployed to the live site (it may need a hard refresh to view the updated style). Thanks for raising this.


Nano Powers

Added enums related to nano skills.
All nano powers excluding recall and revive work.
Players can now be buffed/debuffed via iBitConditionFlag.

Merged.


chore: bumps version to v0.2.5.

Description
Changes the artifacthub-pkg.yml file bumping the version to v0.2.5. Releasing the latest dependencies updates.

ship it! :rocket:


Can we have js-expression hilighting inside {{ }}?
Something like htmldjango but for vue templates.

I've wanted to do this for quite some time. I also tried it locally:
syntax region vueMustache start=/{{/lc=2 end=/}}/me=e-2 contains=@htmlJavaScript contained
syntax match vueMustacheStart /{{/ nextgroup=vueMustache
syntax match vueMustacheEnd /}}/
highlight link vueMustacheStart Delimiter
highlight link vueMustacheEnd Delimiter

But the above only works reliably with pangloss/vim-javascript.
I'll try some more things, until I find something that works with both pangloss/vim-javascript and the default javascript syntax shipped with Vim.

How do i test this locally?

Add it to syntax/vue.vim, wherever that is located. For me it's in ~/.vim/plugged/vim-vue/syntax/vue.vim

Nice, it works with yajs.vim


updated dependencies, changed component to pure function using hooks

Updated dependencies to latest versions
Changed class component to pure function
Change states and lifecycles to hooks

Duuuuude yes! @balloob, @markusenglund anyway we can get this merged in?

Would be so awesome to get this merged!

I haven't really had the time to review PRs or maintain the library unfortunately. Maybe we could give commit access to someone else if people think it's important that it gets updated.


Writing documentation

It's can helps us to know how to use this package and give us more examples

Content
Getting Started

[ ] Introduction
[ ] Framework guide

Components

[ ] Accordion
[ ] auto resize area
[ ] collapse
[ ] custom range
[ ] dark mode
[ ] dismissible
[ ] dropdown
[ ] modal
[ ] offcanvas
[ ] popper
[ ] tabs
[ ] tooltip/popover


feat(lang): update messages.po(t) and add missing German translations

SUMMARY
This PR

updates messages.pot file and derived language dependent *.po files (generated via ./scripts/babel_update.sh)
adds missing German translations to the .../de/.../messages.po file

NOTE: this PR does not (yet) include the messages.json files, as I'm hesitant to include them with this PR. They could be generated in the build process and probably should not be checked in anyway. Please let me know, if the de/.../messages.json or all languages files should be part of this PR.
NOTE FURTHER, that there remain some not-yet-localized messages, e.g. the last-modified times in the following screen shot, which are not created localized via helpers.py/changed_on_humanized and created_on_humanized
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

CI is failing, can you please address?

Babel generates unnecessary empty lines just before EOF (see https://github.com/python-babel/babel/issues/799). For now, I removed them manually.
Either a comment should be added to CONTRIBUTING.md or scripts/update_babel.sh be enhanced to chop off this EOF newline, as long as the above cited issue is not fixed.

messages.json should be part of this PR FYI.

Either a comment should be added to CONTRIBUTING.md or scripts/update_babel.sh be enhanced to chop off this EOF newline, as long as the above cited issue is not fixed.

That sounds reasonable, can you do one of those?

This PR now

updates messages.pot file and derived language dependent *.po files (generated via ./scripts/babel_update.sh), as well as messages.json files (generated via ./scripts/po2json.sh)
adds missing German translations to the .../de/.../messages.po file
fixes wrongly named pt/messages.po file
in .scripts/babel_update.sh chops off  at EOF for po/pot files

@nytai I see the latest failing tests as not related to my changes. Could you confirm, please? In case tests are flaky, is there anything which could be done about this?

I'm currently a bit disappointed by flaky tests blocking review/merging. Please correct me, if I'm wrong @rusackas, but the failing test is not related to this PR, is it?

@hbruch I restarted the flaked tests, 🤞 they'll pass this time

Restarted the python integration tests... we'll get this thing through!!!


Selenoid allows less sessions than specified with -limit

I have both Selenoid & Selenoid-UI deployed via Docker with the command "-limit 10" in my docker-compose.yaml file, yet I'll later run my application and when it attempts to request more than 3 browsers at a time the connection refuses. To verify I navigate to http://<IP_ADDRESS>:4444/status in my browser with the total value correctly reading 10, is there any reason for this or a simple fix?

@khaelou if you are running everything on your workstation and having Mac \ Windows - then check that your Docker instance has sufficient resources allocated. For every browser you need to have 1 CPU and 1 Gb RAM. Refused connections could be just because of overloaded machine.

That makes sense, thank you.


Add installation instructions in README file

pip install -r requirements.txt
python -m spacy download en_core_web_sm # depend on which language you want to you: https://spacy.io/usage/models

Hi.What are the things you want to be added in the file?

I've made a fork and pull request to fix this and will put it up for review unless something goes wrong.


Doctors appointment Kanban board

This is the link to the repository:
https://github.com/Ol-create/Doctors_Appointment
We are a group of 3 members
And here is a screenshot of the current Kanban board:

Hi @mullenlucas
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To highlight:

All tasks have been assignged✔

Required Changes ♻

[ ] According to the project requirements:

However, since issue #1 is not a task, does not have any points, making it impossible to meet this requirement:

Kindly remove it from your kanban for the purposes of this review, and to meet the particular requirement.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @mullenlucas,
Wow, you did it 🎉

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗
Well done!
Congratulations! 🎉
To highlight

All tasks now meet the requirements✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Add indexes to workflows and workflow runs

There are some queries that can be improved in terms of performance by adding some indexes, for example the retrieval of workflow runs based on a workflow, currently, the SQL plan looks like to retrieve last 3 workflows runs of a workflow:
SELECT "workflow_runs"."id",
               "workflow_runs"."created_at",
               "workflow_runs"."finished_at",
               "workflow_runs"."state",
               "workflow_runs"."reason",
               "workflow_runs"."run_url",
               "workflow_runs"."runner_type",
               "workflow_runs"."attestation",
               "workflow_runs"."attestation_digest",
               "workflow_runs"."attestation_state",
               "workflow_runs"."contract_revision_used",
               "workflow_runs"."contract_revision_latest"
        FROM "workflow_runs"
        WHERE EXISTS (SELECT "workflows"."id"
                      FROM "workflows"
                      WHERE "workflow_runs"."workflow_workflowruns" = "workflows"."id"
                        AND "workflows"."id" = 'f09a517b-6975-489b-956e-14446b30b0d5')
        ORDER BY "workflow_runs"."created_at" DESC
        LIMIT 3

Limit  (cost=1970.54..1970.55 rows=3 width=229)
  ->  Sort  (cost=1970.54..1970.55 rows=3 width=229)
        Sort Key: workflow_runs.created_at DESC
        ->  Nested Loop  (cost=0.00..1970.52 rows=3 width=229)
              ->  Seq Scan on workflows  (cost=0.00..6.28 rows=1 width=16)
                    Filter: (id = 'f09a517b-6975-489b-956e-14446b30b0d5'::uuid)
              ->  Seq Scan on workflow_runs  (cost=0.00..1964.21 rows=3 width=245)
                    Filter: (workflow_workflowruns = 'f09a517b-6975-489b-956e-14446b30b0d5'::uuid)

Just by adding an index on the workflow_workflowruns, improves:
Limit  (cost=18.43..18.44 rows=3 width=229)
  ->  Sort  (cost=18.43..18.44 rows=3 width=229)
        Sort Key: workflow_runs.created_at DESC
        ->  Nested Loop  (cost=0.29..18.40 rows=3 width=229)
              ->  Seq Scan on workflows  (cost=0.00..6.28 rows=1 width=16)
                    Filter: (id = 'f09a517b-6975-489b-956e-14446b30b0d5'::uuid)
              ->  Index Scan using workflowrun_workflow on workflow_runs  (cost=0.29..12.10 rows=3 width=245)
                    Index Cond: (workflow_workflowruns = 'f09a517b-6975-489b-956e-14446b30b0d5'::uuid)

Great find @javirln, could you point out to the code that's making these calls? I'd also like to review that those queries are properly formed. wdyt?

btw, since foreign keys do not mean indexes, we should probably look into some other potential indexes.
Anything related to organizations should probably be indexed, especially the tables that have a lot of entries, like casbackend_mappings
make -C app/controlplane visualize-data-model

should we spend some time evaluating the relationships we have here and creating indexes accordingly?

Totally, I would go through the queries and try to identify low hanging fruits to improve


Migrate to Github Actions

Description
https://github.com/kyma-project/telemetry-manager/pull/467 proved how nice GH actions could be leveraged for the actual testing of the software.
So let's apply it to all by moving all testing to github actions which are waiting for the actual prow build job. On prow side only the pre- and post- build of images should stay.
To stay in prowjob (everything needed for building):

pull-telemetry-manager-build
post-telemetry-manager-build
post-telemetry-manager-release-module

To write in GH:

pull-telemetry-manager-e2e-test-logging-release
pull-telemetry-manager-e2e-test-logging
pull-telemetry-manager-e2e-test-metrics
pull-telemetry-manager-e2e-test-tracing-release
pull-telemetry-manager-e2e-test-tracing
pull-telemetry-manager-integration-test-istio
pull-telemetry-manager-lint
pull-telemetry-manager-unit-test
pull-telemetry-manager-verify-module
pull-telemetry-manager-upgrade-test

Reasons

Attachments

All migrated as outlined


Smartphone

Merging final version of the smartphone sub-project

Merging final version of the smartphone sub-project


despawning pets despawns all npcs/monsters for a second, until they respawn

despawning pets despawns all npcs/monsters for a second, until they respawn.
most likely because pet is owned by player now, so removing pet removes player connection from them until rebuildobservers is called again.
video: https://youtu.be/djKP3hhQmCM

my guess is some place in despawn needs to only remove self from observers if connection.identity==this, or in other words, only if the main player despawns, not if a pet etc. despawns

how to reproduce:
ummorpg ce
editor=server-only
build=client
client spawns pet, unspawns pet


Remote Code Execution Vulnerability to address.

Library Affected:
workbox-webpack-plugin and workbox-build
Browser & Platform:
Just npm so far
Issue or Feature Request Description:
The workbox-webpack-plugin package v.5.1.3 (latest stable) depends on v.5.1.3 of workbox-build, which depends on v.^5.2.0 of rollup-plugin-terser, which depends on serialize-javascript  v.^2.1.2.
There was a high-severity vulnerability announced last week recommending bumping serialize-javascript to >=3.1.0.
Request: Release a new version of workbox-webpack-plugin and workbox-build that uses to rollup-plugin-terser at least version 7.0.0 (first version with serialize-javascript >=3.1.0), so that the vulnerability is not exposed to users of workbox.

Please see https://github.com/GoogleChrome/workbox/issues/2601#issuecomment-674084452

I acknowledge the bind that you all are in - tension between:

v5 seemingly needing to support Node 8
expectations of very high quality and reliability for release of v6
seemingly insufficient use of v6 alphas to confidently to beta and GA

FWIW, I've got pretty good confidence based on our test suite that the v6 alpha should work as expected. At this point, though, there are still some breaking changes that @philipwalton plans on implementing for v6 related to workbox-precaching, and we don't want to progress out of alpha to a beta or release candidate until we feel confident that the public interfaces are locked in.