make trace and stop_trace take the same arguments

starting a filtered trace is easy enough, one would expect the stop_trace to receive the same arguments.
for example, starting a trace:
lager:trace(lager_console_backend, [{module, users_serv}, {function, is_client_update_available}], debug).
to stop the trace, one must issue the following (non-intuitive) command:
lager:stop_trace({{all,[{module,'=',users_serv},{function,'=',is_client_update_available}]},{mask,255},lager_console_backend}).
with this PR the stop_trace now becomes:
lager:stop_trace(lager_console_backend, [{module, users_serv}, {function, is_client_update_available}], debug).

This breaks one of the tests, it is documented that you can pass the result of start_trace into stop trace, so you should fix start_trace to return the 3-tuple. This is as simple as changing line 193 of lager.erl to return {ok, Trace0} rather than {ok, Trace}.
I think this is fine once that change is made.

Ah, you also need to export stop_trace/1 as well, to make the tests pass.

ah, that isn't right either, let me just rework this and make a new pull request.

This is superceded by #251

closing, #251 should be focused on instead


[GSSOC'23]: adding Electromagnetism to PhysiTech using C++

Describe the Feature you want to end
adding Electromagnetism to PhysiTech
Expected behavior
Features-:

Laws of Electromagnetism
Explanation of Key Concepts
Applications of Electromagnetism
Calculation of Electric Current, Resistance, using Ohm's Law
Calculation of capacitance and inductance.
Calculation of electric field and electric potential.

@MohitGupta121 sir kindly assign me this issue


bash completion not working out of the box

Since the dev containers' main purpose is to provide an interactive development environment, I think that shell autocomplete should be enabled by default in dev containers. The bash-completion package should be included with common-utils feature.
The bash-completion package could be included conditionally, if INSTALL_ZSH is not set.

Thanks for your request.
The bash-completion package provides programmable completion features for the Bash shell, which can significantly enhance your command-line experience by providing context-sensitive completions for commands, options, and arguments.
As it generally safe to install the bash-completion package on a Linux system, we can add it to the common-utils Feature.
Before adding, we should validate that the disk space is minimal


Specification for quantized  AddOp

Summary
The PR proposes the specification for quantized add op.
A few details
At some point we decided to drop the introduction of the specification of this op mainly because we were unsure about the fate of https://github.com/openxla/stablehlo/issues/1406.
Please have a look at my revised proposal on https://github.com/openxla/stablehlo/issues/1406 and let me know if I am missing something. Otherwise, let us review this op  and let me know your feedback.
Side note: For those who are already aware of the context of prior introduction of this op, please note that the current proposal is almost same as before except that it does not have any additional constraint imposed by the op's semantics on storage_min or storage_max.

LGTM
As mentioned by others, our implementation will be done in int-space rather than via dequantization + quantization and hence the numerics will be different. Likely, the StableHLO reference implementation will also reflect that?

@nutsiepully

Likely, the StableHLO reference implementation will also reflect that?

I can see the how the integer implementation will help match the numeric closely. Will keep that in mind while implementing that.


add color correction for eon

What is this color correction for?

It's just for people who have color blindness / weakness.
On Thu., Mar. 18, 2021, 10:33 p.m. Adeeb Shihadeh, @.***>
wrote:

What is this color correction for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/pull/20401#issuecomment-802547733,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APGQQWHXMBD3X27FGOKAW7LTELH2HANCNFSM4ZNZBIFQ
.

This is super exciting wasn’t expecting accessibility features to be added till 0.9
He means color vision deficiency(color blindness isn’t a medical term). These are just filters for people with Anomalous trichromatism.
Because openpilot relays on so heavily on its colored boarders for relaying information to the user we need make sure the user actually see them. This become even more import when your team added traffic lights which aren’t standardize throughout the US.

We're not going to merge this for a couple reasons: it relies on android, and it's another setting in the UI. That being said, we're working on some new designs and will take this into consideration.

Interesting,  geo wants to sell overpriced hardware because of the software.... okay, yet you guys cannot even merge this to master because of one more things in the settings? lame. how are you going to sell the hardware to people who are visually impaired? where is the support for i18? why do people have to look "fork" but yet geo out here saying "we're upping the price because of the software" should be shame. you cannot even add simple little thing that could be a big thing. just because you are not visually impaired does not mean its a silly thing. classic comma.

This is consistent with our historical position on toggles and settings. We intend to address the issue in a design rework, and accessibility will be a goal in the new design.

An accessibility feature is always going to need a toggle, I don't understand why that is a gateway to improving the accessibility of openpilot

We are working towards a design that accommodates for vision deficiency. If the design alone is not sufficient, then we will add a toggle. @ReFil an accessibility feature is not always going to need a toggle. Often times designs are too complex or too rigid that a toggle becomes the easiest solution (hence, its popularity). openpilot is optimized for stability/longevity and that includes mitigating maintenance costs; meaning as few dependencies as possible which is why we are going to pass on this PR, but not this feature, at this time.

@rav4kumar GitHub is for development, not a public forum for feedback (maybe reddit?). Going forward, if your comments are not subject related, they may be deleted. It's 2021, everything is controversial, but our focus is working with those that believe in what we are doing and how we are doing it.


Need additional Time Blocks

Users need to be presented with time blocks for standard business hours of 9am to 5pm

Now the user will see time slots from 9-5


More opinionated substitutions

Interrobang: ?! (in either order) -> ‽
Inverted interrobang: ¿¡ (in either order) -> ⸘
Ellipsis: ... -> …

Asciidoc features a whole list of substitutions too: https://asciidoctor.org/docs/asciidoc-writers-guide/#replacements Should we consider borrowing some of those?


edsl.md: add uint16 ABI calldata type

Not sure what the policy on ABI type inclusion is, but this is a solidity type that came up in a spec we are working on.

@livnev you'll have to sign the CLA (click the "Details" button next to the red X).

@ehildenb done


Using a unified alignment method in egress yaml as other yaml files

Using a unified alignment method in egress yaml as other yaml files
Signed-off-by: Wenqi Qiu<EMAIL_ADDRESS>

/skip-all


After running authorize_security_group_egress, calls to describe_security_groups fails

After running authorize_security_group_egress to allow ALL (protocol, port, destination), trying to retrieve the same security group with describe_security_groups will fails. You can see equivalent configuration at AWS Console like this:

Sample code to reproduce error
import json
import boto3
from moto import mock_ec2

@mock_ec2
def reproduce():
    ec2 = boto3.client('ec2')
    resp = ec2.create_security_group(
        Description='MY-SG',
        GroupName='MY-SG',
        VpcId='vpc-12345',
        DryRun=False
    )
    SG_ID = resp['GroupId']

    ec2.authorize_security_group_egress(
        GroupId=SG_ID,
        IpPermissions=[
            {
                "IpProtocol": "-1",
                "IpRanges": [
                    {
                        "CidrIp": "<IP_ADDRESS>/0"
                    }
                ],
                "Ipv6Ranges": [],
                "PrefixListIds": [],
                "UserIdGroupPairs": []
            }
        ]
    )

    resp = ec2.describe_security_groups(GroupIds=[SG_ID])
    print(json.dumps(resp, indent=4))

if __name__ == "__main__":
    reproduce()

Expected result
Method describe_security_groups of boto3 ec2 return detail of specified Security Group.
Actual result
ValueError: invalid literal for int() with base 10: 'None'
Full stack trace
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/moto/core/models.py", line 71, in wrapper
    result = func(*args, **kwargs)
  File "medmon/reproduce.py", line 33, in reproduce
    resp = ec2.describe_security_groups(GroupIds=[SG_ID])
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/client.py", line 599, in _make_api_call
    operation_model, request_dict)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/endpoint.py", line 148, in make_request
    return self._send_request(request_dict, operation_model)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/endpoint.py", line 175, in _send_request
    request, operation_model, attempts)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/endpoint.py", line 256, in _get_response
    response_dict, operation_model.output_shape)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 242, in parse
    parsed = self._do_parse(response, shape)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 497, in _do_parse
    parsed = self._parse_shape(shape, start)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 295, in _parse_shape
    return handler(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 365, in _handle_structure
    member_shape, member_node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 295, in _parse_shape
    return handler(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 348, in _handle_list
    return super(BaseXMLResponseParser, self)._handle_list(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 303, in _handle_list
    parsed.append(self._parse_shape(member_shape, item))
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 295, in _parse_shape
    return handler(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 365, in _handle_structure
    member_shape, member_node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 295, in _parse_shape
    return handler(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 348, in _handle_list
    return super(BaseXMLResponseParser, self)._handle_list(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 303, in _handle_list
    parsed.append(self._parse_shape(member_shape, item))
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 295, in _parse_shape
    return handler(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 365, in _handle_structure
    member_shape, member_node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 295, in _parse_shape
    return handler(shape, node)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 175, in _get_text_content
    return func(self, shape, text)
  File "/MY-PROJECT/venv/local/lib/python3.6/dist-packages/botocore/parsers.py", line 454, in _handle_integer
    return int(text)
ValueError: invalid literal for int() with base 10: 'None'

Hmm, this works for me. Can you confirm your versions of boto3, botocore, and moto?

Going to close this due to a lack of response. Do let me us know if this is still an issue.


Add local documentation webserver

This PR reorganizes the documentation into the directory structure consistent with all other projects documented at https://grafana.com/docs/.
It adds a Makefile in the docs/ directory that has targets for running a local webserver to view the generated Hugo site at http://localhost:3002/docs/ebpf-autoinstrument/latest/. A workflow is added to automatically update the Makefile and supporting files from the centralized source in Writers' Toolkit. I've added myself as a CODEOWNER and will ensure that I promptly validate, review, and merge those update PRs.
It also adds a doc-validator workflow that lints technical documentation. The tool is still a work in progress but it provides useful guidance for correct use of the Hugo relref shortcode, checking link anchors exist in destination pages, as well as other linting checks. It provides comments to PRs automatically and for trivial fixes, it even provides suggestions. Please report any bugs to me in #docs-squad on Slack or as a GitHub issue in https://github.com/grafana/technical-documentation/issues.
You can run doc-validator locally with make doc-validator. It has structured JSON output that can be made more human readable using something like: make -s doc-validator | jq -r '"ERROR: \(.location.path):\(.location.range.start.line // 1):\(.location.range.start.column // 1): \(.message). Suggestion: \(.suggestions[0].text // "")"
TO DO (team):

Some questions about website publishing:

At what URL do we want documentation to be published?
Do we want to publish versioned documentation at this point in time? I don't see any tags or long lived version branches so I'm expecting that we are happy to just publish whatever is in main.

Mermaid charts need to be rendered and embedded. We don't yet have Mermaid support in the website (https://github.com/grafana/website/pull/9196).
All pages need a description. Requires either maintainer or technical writer to perform. For some guidance, refer to https://grafana.com/docs/writers-toolkit/writing-guide/front-matter/#description-required.
Need consistent name, I've seen each of the following throughout the docs.

eBPF autoinstrument
eBPF autoinstrumenter
eBPF Autoinstrument
Auto-instrumenter

Indeed there is, this is doc-validator complaining that we don't have descriptions on the pages. These are required for published documentation and need someone familiar with the content to write them or for a technical writer to come in and write them. Some brief guidance is available in https://grafana.com/docs/writers-toolkit/writing-guide/front-matter/#description-required.

OK, great, I can do that work. I'll make a PR with the required changes on top of this branch, so we can merge that before we merge this PR fully. Thanks!

Great plan!

I made a PR with these changes: https://github.com/grafana/ebpf-autoinstrument/pull/170

Hm, my PR still fails with this error:
reviewdog: parse error: failed to unmarshal rdjsonl (Diagnostic): proto: syntax error (line 1:1): invalid value docs

Thanks! I'll take a look and see what's going wrong between doc-validator and reviewdog.

Codecov Report

Merging #169 (f4b045d) into main (72938d7) will decrease coverage by 42.39%.
The diff coverage is n/a.

:exclamation: Current head f4b045d differs from pull request most recent head 574966d. Consider uploading reports for the commit 574966d to get more accurate results

@@             Coverage Diff             @@
##             main     #169       +/-   ##
===========================================
- Coverage   81.46%   39.08%   -42.39%
===========================================
  Files          35       34        -1
  Lines        2466     2410       -56
===========================================
- Hits         2009      942     -1067
- Misses        337     1410     +1073
+ Partials      120       58       -62

Flag
Coverage Δ

integration-test
?

unittests
39.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 27 files with indirect coverage changes

I'm going to merge this so that any future docs work doesn't cause conflicts. Hit me up if you need any follow up PRs to fix if you spot anything that's not right.


Rating Widget don't work on Firefox

Hello,
I'm trying to use the rating widget on Firefox (33 and 34) on Windows and OSX and it doesn't work on any combination of OS and Browser. The hover effect don't happen and if i click on a star it does not fill them correctly, instead the browser just select the stars.
Here is a quick gif showing what happens when i move the mouse and click on the stars.

Thanks for pointing that out and illustrating with a gif. This is fixed and live now.


How to activate this feature in the Azure Portal?

I'm not sure about this: you must explicitly enable it when creating the database and where to enable it.  I don't think it is the same thing because the ReadScale setting was still Disabled. Did I miss something?
I was able to activate by the PS commands but I want to know where to activate this feature in the Azure Portal.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a2961d1-4448-11b7-2dc2-3b738bd70939
Version Independent ID: 206eb022-25c4-66d7-7285-0d53a84956e3
Content: Azure SQL Database - read queries on replicas
Content Source: articles/sql-database/sql-database-read-scale-out.md
Service: sql-database
GitHub Login: @anosov1960
Microsoft Alias: sashan

@franzzegarra Thanks for the feedback. We are actively investigating and will get back to you soon.

@franzzegarra Enabling this functionality is not available in the Azure Portal. The documentation describes the Powershell and the SQL REST API methods for enabling this functionality. You can make feature enhancements via the Azure SQL Database User Voice.
I am going to forward this on to the documentation content owner to possibly add a note that this configuration cannot be enabled via the Azure Portal.

Yes, as mentioned, I already enabled the feature with PowerShell. Thank you for your quick response.

@franzzegarra We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Update manifest.json

Added support for HA 110.0

homeassistant key no longer support in HACS and i will update msmart version.
thank you


Enabling postgresql on macOS

Hi! I don't know if this question belongs in home-manager, but it's worth a shot. Disclaimer: still relatively noob at nix.
I've successfully installed postgresql_11 via this project, but I am not sure how to enable the postgresql service. Am I just doing this wrong? Here's what I'm working with:

home.nix
{ pkgs, ... }:

let
  nixpkgsConfig = import ./nixpkgs/config.nix;
  user = import ./user.nix;
  xdg = import ./xdg.nix;

in {
  nixpkgs = {
    config = nixpkgsConfig;
  };

  xdg = xdg;

  home.packages = with pkgs; [
    postgresql_11
    # ...other packages
  ];

  programs.home-manager = (import ./programs/home-manager.nix { });
  # ...other programs

  home.file.".psqlrc".source = ../conf/.psqlrc;
  # ...other dotfiles
}

nixpkgs/config.nix
{
  allowBroken = true;
  allowUnfree = true;

  packageOverrides = pkgs: rec {
    # ...package overrides
  };

  services.postgresql = pkgs: rec {
    enable = true;
    package = pkgs.postgresql_11;
    port = 5432;
  };
}

I have all of the CLI tools, but it doesn't seem like it's getting enabled, and I can't find any of the relevant files/services that should be created as per https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/databases/postgresql.nix.
λ psql
psql: could not connect to server: No such file or directory
	Is the server running locally and accepting
	connections on Unix domain socket "/tmp/.s.PGSQL.5432"?

Any help or guidance would be super helpful!

The modules in Home Manager are separate from the ones in NixOS and unfortunately they are incompatible with each other. Second, NixOS modules are only for NixOS, i.e., would not work under macOS. All services in HM and NixOS are run through systemd so they will not work under macOS.
Fortunately, the nix-darwin project seems to have a postgresql module that you could try.

Okay, thanks for looking at it and explaining!


Azure Event Hub Data Receiver should be Azure Event Hubs Data Receiver

The role Azure Event Hub Data Receiver should be Azure Event Hub Data Receiver, this is a typo I believe.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b1302a36-d75f-2c77-0da1-333f81689805
Version Independent ID: 8fd7095a-926c-6b12-07b4-0e50094bfba1
Content: Configure your Event Hub
Content Source: microsoft-365/security/defender/configure-event-hub.md
Product: m365-security
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@RHooijer Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8484
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @RHooijer Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


feat(model-api-gen): allow generating typescript barrels

This merge request adds a new optional property to the model api gen called includeTypescriptBarrels . When enabled it adds barrelling to the generated index.ts file as a convience feature. Example
// index.ts (generated)
import { LanguageRegistry } from "@modelix/ts-model-api";
import { L_org_modelix_entities } from "./L_org_modelix_entities";
export function registerLanguages() {
  LanguageRegistry.INSTANCE.register(L_org_modelix_entities.INSTANCE);
}
export * from "./L_org_modelix_entities";

// test.ts
import {N_Entity} from './index.ts'

// instead of
import {N_Entity} from './L_org_modelix_entities.ts'

To be verified by reviewers

[ ] Relevant public API members have been documented
[ ] Documentation related to this PR is complete

[ ] Boundary conditions are documented
[ ] Exceptions are documented
[ ] Nullability is documented if used

[ ] Touched existing code has been extended with documentation if missing
[ ] Code is readable
[ ] New features and fixed bugs are covered by tests

:tada: This PR is included in version 8.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(Topology/Constructions): add continuous_bool_rng

Provide continuity criteria for functions X → Bool
and, more generally, X → Y, where Y has discrete topology.

Cleaning up old branches.

Thanks for the changes: I like the Bool lemmas!
maintainer merge

maintainer merge


spring.zipkin.discoveryClientEnabled=false is not work

Bug report
@Configuration
@ConditionalOnClass(LoadBalancerClient.class)
static class DiscoveryClientZipkinUrlExtractorConfiguration {

@Configuration
@ConditionalOnProperty(value = "spring.zipkin.discoveryClientEnabled", havingValue = "true", matchIfMissing = true)
static class ZipkinClientLoadBalancedConfiguration {

    @Autowired(required = false)
    LoadBalancerClient client;

    @Bean
    @ConditionalOnMissingBean
    ZipkinLoadBalancer loadBalancerClientZipkinLoadBalancer( ZipkinProperties zipkinProperties) {
        return new LoadBalancerClientZipkinLoadBalancer(this.client, zipkinProperties);
    }

  }

  @Configuration
  @ConditionalOnProperty(value = "spring.zipkin.discoveryClientEnabled", havingValue = "false")
  static class ZipkinClientNoOpConfiguration {

    @Bean
    @ConditionalOnMissingBean
    ZipkinLoadBalancer noOpLoadBalancer(final ZipkinProperties zipkinProperties) {
      return new NoOpZipkinLoadBalancer(zipkinProperties);
    }

  }
}

if I set spring.zipkin.discoveryClientEnabled=false，can’t  create noOpLoadBalancer，still is loadBalancerClientZipkinLoadBalancer. Then I modify this code like this, it work
@Configuration
  @ConditionalOnProperty(value = "spring.zipkin.discovery-client-enabled", havingValue = "false")

Can you create a test and a PR that fixes this?

Can you create a test and a PR that fixes this?

ok, I'll take care of it in a day or two


Hexadecimal number not correctly highlight in function arguments

Just a little bug during passing an hexadecimal number to a function argument

The hexadecimal number is not correctly highlight.

Looks like this was resolved 3 days ago: https://github.com/Microsoft/vscode/commit/145310aea5e41c6af8de4aaf7910bdb90f0e4fea. The Lua grammars are built into vscode, so you'll need to either use an insider's build or wait for the next release.

Ok, thank you. I'll wait the next release.


Add checksum support

Description of the new feature / enhancement
Generate a checksum for a file and either copy it to your clipboard or provide a window where you can paste the expected checksum to verify a file.
Scenario when this would be used?
This would be useful when the integrity of downloaded files is crucial to their operation.
Supporting information
No response

/dup #57


Enable macOS CI again with faster runner

Try for https://github.com/kachick/ruby-ulid/pull/223#issuecomment-1190947115
https://github.blog/changelog/2023-04-24-github-actions-faster-macos-runners-are-now-available-in-open-public-beta/

https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners#machine-specs-for-larger-runners

Note: The larger runners do not use included entitlement minutes, and are not free for public repositories.

😭


examples: add RBAC sandbox

Signed-off-by: Xie Zhihao<EMAIL_ADDRESS>Commit Message: examples: add RBAC sandbox
Additional Description: Envoy does not have a RBAC example currently and there are some issues (e.g., #22336) about how to use the RBAC filter. The patch adds a RBAC sandbox with generic matching.
Risk Level: Low
Testing: N/A
Docs Changes: Sandbox
Release Notes: N/A
Platform Specific Features: N/A

hmm
envoy_1    | [2022-07-28 08:37:06.877][1][warning][misc] [source/common/protobuf/message_validator_impl.cc:35] field 'envoy.extensions.filters.http.rbac.v3.RBAC.matcher' is marked as work-in-progress. API features marked as work-in-progress are not considered stable, are not covered by the threat model, are not supported by the security team, and are subject to breaking changes. Do not use this feature without understanding each of the previous points.

altho, im not sure above warning is the cause of the failure

Ah, Sign off and commit suggestion by GitHub breaks the DCO. It is sad and I have to force push them.

one thing im wonder is where "roles" come into it if we are just matching a header

In generic matching, we have HTTP headers and trailers, source and destination, server name, protocols and TLS cert fields. I am worried that adding more policies would make the example too complicated.

I am worried that adding more policies would make the example too complicated.

i think it could tolerate a little more complexity - and i guess im just concerned that it doesnt demonstrate too much the things i would expect/hope for
that said - i would be happy to land and iterate with just this example so far, esp as it is addressing an issue that has caused confusion

cc @phlax status on this one?  it got flagged as stalled and your last comment was you're happy to land?

/docs


BUG: pre-render version placeholder

Coverage remained the same at 78.947% when pulling cdf149215e2b61a5920ebd91726baa7870bef1df on ebolyen:placehold into 987993350bd71cd5814ef2f6b67640d4e1abce9e on nervous-laughter:master.


CC release notes

Closes #6540

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/2073440df0a893e5dfc4799824d28a2c5d8cc8f9/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8be7c24e7eca8b06dfdde2e53b5234c1065bae51/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e53ce5a78845827ca8f6a31201ef2a6ef9715fa7/
Edited pages:

releases/cockroachcloud-02022020.md

This LGTM! Yay to getting our first release notes out!!

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d54ed2494534a87a172fa3e30c43461d4e936ef9/
Edited pages:

releases/cockroachcloud-02022020.md

The first bullet should not indicate that minor upgrades are optional. I would change to say something like "the supported minor version of CRDB 19.2 changed from v19.2.2 to v19.2.4. Clusters have been automatically upgraded to the latest supported version and all new clusters are created on v19.2.4"

The first bullet should not indicate that minor upgrades are optional. I would change to say something like "the supported minor version of CRDB 19.2 changed from v19.2.2 to v19.2.4. Clusters have been automatically upgraded to the latest supported version and all new clusters are created on v19.2.4"
That way you can combine bullets 1 & 2 :)

Hmm..minor/major versions seem internal jargon-y to me. Can we say "Upgraded CockroachCloud clusters running CockroachDB 19.2.2 to v19.2.4. All new clusters will now be created with CockroachDB V19.2.4."

lgtm

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5762993fc25c6f1666b79116d43b3e0a7d142192/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5a3c601c451a8aec8c1d353d322322fc14bd07ef/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e8540b0fe12a9896b1f8bf67dd5d8f72c4630352/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/38e4ae1a2872be1d2baf958c1775a7216069afc9/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/38e4ae1a2872be1d2baf958c1775a7216069afc9/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/38e4ae1a2872be1d2baf958c1775a7216069afc9/
Edited pages:

releases/cockroachcloud-02022020.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d3149018af27a03dbe4c04860cd70e30c5289c71/
Edited pages:

releases/cockroachcloud-02022020.md

Closed via https://github.com/cockroachdb/docs/pull/6718


Added clear command

Added clear command for ease of use
Closes #989

Yes Ctrl+L would definitely be preferred here as it's standard in most terminal environments. @tommyneu thank you so much for an otherwise super clean and simple PR!


Adding modules to netbox

Hello,
I would like to install modules using pip to enable SSO/SAML authentication on netbox. (django3_saml2_nbplugin)
REMOTE_AUTH_BACKEND: 'django3_saml2_nbplugin.backends.SAML2CustomAttrUserBackend'
But, I can't figure where can I install modules ? I've looked on all the files and I can't find anything with pip, I understood I need to create on the chart to do it myself, but anyone has done this on this chart before ?
Thanks

Update:
As found on netbox documentation:
Once installed, add the package to local_requirements.txt to ensure it is re-installed during future rebuilds of the virtual environment
So, what I've tried:
configmap.yaml
data:
  local_requirements.txt: |
    netbox-bgp

deployment.yaml
          volumeMounts:
            - name: config
              mountPath: /etc/netbox/config/configuration.py
              subPath: configuration.py
              readOnly: true
            - name: requirements
              mountPath: /opt/netbox/local_requirements.txt
              subPath: local_requirements.txt

      volumes:
        - name: config
          configMap:
            name: {{ include "netbox.fullname" . }}
        - name: requirements
          configMap:
            name: {{ include "netbox.fullname" . }}

I can see the file within /opt/netbox, but:
I have no name!@netbox-lr8-5cdcfc8fc9-p5lfn:/opt/netbox$ source venv/bin/activate
(venv) I have no name!@netbox-lr8-5cdcfc8fc9-p5lfn:/opt/netbox$ pip list | grep netbox
WARNING: The directory '/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.

[notice] A new release of pip available: 22.2.2 -> 22.3
[notice] To update, run: pip install --upgrade pip
(venv) I have no name!@netbox-lr8-5cdcfc8fc9-p5lfn:/opt/netbox$ pip install -r local_requirements.txt
WARNING: The directory '/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you should use sudo's -H flag.
Collecting netbox-bgp
  Downloading netbox_bgp-0.8.1-py3-none-any.whl (47 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 47.7/47.7 kB 2.3 MB/s eta 0:00:00
Installing collected packages: netbox-bgp
ERROR: Could not install packages due to an OSError: [Errno 30] Read-only file system: '/opt/netbox/venv/lib/python3.10/site-packages/netbox_bgp'

[notice] A new release of pip available: 22.2.2 -> 22.3
[notice] To update, run: pip install --upgrade pip
(venv) I have no name!@netbox-lr8-5cdcfc8fc9-p5lfn:/opt/netbox$

Package is not installed when the pod is creating
It seems that:

Volume is read-only ?
No permissions for this user

Just a thought - would it be simpler for you to create a custom image based off a given netboxcommunity/netbox image, with your own customisations?

That's a possibility, but it would be easier for me to maintain a plugins list within the helm chart, then to recreate the docker package each time I want to implement/test a netbox plugin

Thanks,
I've done it the way you told me to.
I have a custom docker image in my company repositories for with the plugins we need.


update external test to run with docker images provided by adoptium

For external tests we support images defined by following variables. That is 10 * 2 * 8 * 2 * 2 * 20=12800. That is a huge number. As we moved to adoptium official adoptium images  of the Eclipse Temurin Distribution has been adjusted we will also adjust our supported images.
# Supported versions
supported_versions="8 9 10 11 12 13 14 15 16 17"

# Supported JVMs
supported_jvms="hotspot openj9"

# Supported distros
supported_os="alpine debian debianslim ubi ubi-minimal centos clefos ubuntu"

# Supported packges
supported_packages="jdk jre"

# Supported builds
supported_builds="slim full"

# Supported tests
supported_tests="external_custom camel derby elasticsearch jacoco jenkins functional-test kafka lucene-solr openliberty-mp-tck payara-mp-tck quarkus quarkus_quickstarts scala system-test thorntail-mp-tck tomcat tomee wildfly wycheproof netty spring"

For now we will adjust to
# Supported versions
supported_versions="8 11 17"

# Supported JVMs
supported_jvms="hotspot" (add openj9 later?)

# Supported distros
supported_os="ubuntu" (add alpine, windows, ubi later?)

# Supported packges
supported_packages="jdk jre"

# Supported builds
supported_builds="full"

# Supported tests
supported_tests="external_custom camel derby elasticsearch jacoco jenkins functional-test kafka lucene-solr openliberty-mp-tck payara-mp-tck quarkus quarkus_quickstarts scala system-test thorntail-mp-tck tomcat tomee wildfly wycheproof netty spring"

The definition is in https://github.com/adoptium/aqa-tests/blob/master/external/common_functions.sh.
Along with this test.properties under each third party application directory will need to update. For example test.properties in camel https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties
debian_packages="git maven"
 alpine_packages="bash git maven"
 centos_packages="git maven"
 ubi_packages="git maven"

will be replaced by
ubuntu_packages="git maven"

Function function set_test_info()  and set_external_custom_test_info() in https://github.com/adoptium/aqa-tests/blob/master/external/common_functions.sh will also need to update to make this work.

hi @sophia-guo i would like to give this a spin

I would like to work on this too as it gives a better understanding to another issue I've been working on. @sophia-guo @ShelleyLambert

Hi @sophia-guo @smlambert  here is the PR for the cleanup as required https://github.com/adoptium/aqa-tests/pull/3131


Update classifiers

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   98.70%   98.70%
=======================================
  Files          31       31
  Lines        2008     2008
=======================================
  Hits         1982     1982
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b63a4...6464282. Read the comment docs.


Method of running evaluation on MSR-VTT dataset

Thanks for the paper and the open sourcing the code base.
I would like to know how evaluation is performed on the MSR-VTT dataset for zero shot text to video retrieval.

Are the metrics reported for MSR-VTT for the entire test split (~ 2990 videos, 59800 captions) or for 1kA subset (~ 1000 videos or 20000 captions)?
Are each of the caption (20 for each video) used to perform retrieval and find the recall metrics?
Are errors being accounted for?

As the captions are not too descriptive and similar types of videos / captions exists, how are errors adjusted? For example, one of the caption for video7960 is a band performing in a small club but video8978 fits the same profile. Another caption for the same video video7960 is a group of boys and girls are dancing but video9957 also can be considered correct if retrieved. I will be happy to provide more such examples.

Looking forward for your clarification. Thanks!

Hi! In the latest version, we follow Unmasked Teacher to conduct the evaluation. Please check the code and meta data~
For Q1, we use 1k subset for testing. For Q2, only one caption for each video.

Thanks @Andy1621. Will look at the link you pointed and get back to you if I have any doubts. Thanks.


Don’t strip ExternalStructure class>>#’offsetOf:’.

A recent commit (619963bb3261408afc6a821ce8c540a94f7b9cc5) changed BasicImageStripper>>#prepareExternalStructuresNotifying: to remove #'offsetOf:' from ExternalStructure class. Unfortunately it is still sent by NMLVDISPINFO class>>#'itemFromNMHDR:' so we get a runtime error on certain operations.
{1A791118: cf 1A7910F1, sp 1A79112C, bp 1A791114, ip 4, NMLVDISPINFO class(Object)>>doesNotUnderstand:}
receiver: NMLVDISPINFO
arg[0]: Message selector: offsetOf: arguments: #(lvItem )
{1A7910F0: cf 1A7910CD, sp 1A79110C, bp 1A7910EC, ip 7, NMLVDISPINFO class>>itemFromNMHDR:}
receiver: NMLVDISPINFO
arg[0]: a ExternalAddress
{1A7910CC: cf 1A7910AD, sp 1A7910E4, bp 1A7910C8, ip 5, ListView(IconicListAbstract)>>nmGetDispInfo:}
receiver: a ListView
arg[0]: a ExternalAddress
{1A7910AC: cf 1A791089, sp 1A7910C0, bp 1A7910A4, ip 27, ListView>>nmNotify:}
receiver: a ListView
arg[0]: a ExternalAddress
stack temp[0]: -150

@jgfoster, I'm not sure I understand why this would work. The structure templates are normally removed in a deployed app, so offsetOf: will still fail, although not in the same way. It will just return -1. Actually this could well explain why the other problem with empty lists occurs in deployed apps. NMLVDISPINFO class>>itemFromNMHDR: is missing a ##, i.e. it should be:
itemFromNMHDR: anExternalAddress
	^LVITEM fromAddress: anExternalAddress yourAddress + ##(self offsetOf: #lvItem)

Can you please try adding the ## and seeing if both problems go away?

As mentioned in my comment on PR #342, I've repro'd the problem with the Video Library sample and the underlying problem is the missing ## in front of the (self offsetOf: #lvitem) in the NMLVDISPINFO class>>itemFromNMHDR: method. I've pushed commit f6122bb to fix both issues. However the ExternalStructure class>>#offsetOf: should not be stripped if unless compiling external structures (the default), so I'll modify your PR if I can push changes to it.


dxvk v1.9.4 released, please release v1.9.4L

https://github.com/doitsujin/dxvk/releases/tag/v1.9.3

Along with DXVK (which is 1.9.4 by now), also Wine builds not yet up to 7.x series, dxvk-nvapi is outdated (version 0.5.2 by now), lutris winetricks outdated (git updates)
Only that seem to be on latest version is vkd3d (2.5 release from October 2021, not surprised if update soon)

Appears fixed now.


why we use *string as field value rather than string

It's not convenient to set value as *string, like:
NetworkType *string

so what's the reason that we don't directly use string?
Thanks.

For basic types, such as int, if its value is 0, we don't know if it is just set to 0 or not set, using pointers can allow us to check it. For string type, it is same for "" case (it is rare but still a valid case).
An alternative choce is add a flag to each attribute, we check the flag then use the value or not, it is not convenient as well and needs more lines of code.


Clarify the meaning of max_temp_directory_size

Hello,
could you please clarify the meaning of max_temp_directory_size mentioned here?
I see the default size is 0. But it's not clear to me whether this default setting means "there's no limit" or "the limit is 0, if you want to enable offloading to disk, you have to set it to >0".

Thanks for opening the issue, I agree this is something we should document
https://github.com/duckdb/duckdb/pull/10978 is the source for this option

Thank you for the reference PR, the description answers most of my questions for now.


add option for CycloneDX format

The two leading formats for SBOM are

CycloneDX
SPDX

Both these are ISO approved so it would be great if this tool could provide the option to generate both. I do note the discussion here: https://github.com/microsoft/sbom-tool/discussions/48, but I do feel this tool would have an advantage if it can be format agnostic.
An advantage of generating CycloneDX format would be the ease of integrating with a tool like DependencyTrack whom are strongly against SPDX which a rival format to their own (OWASP) developed CycloneDX  https://github.com/DependencyTrack/dependency-track/discussions/1222

Thanks for your feedback. However, we have decided to focus on SPDX format for the SBOM generation, and as Aasim mentioned you can extend our tool to generate a CycloneDX format SBOM. But please feel free to leverage the component detector to build a CycloneDX format SBOM generator yourself.


Transform scale issue

Steps to Reproduce

Here's a sample dart file and screenshot that shows the bug: https://gist.github.com/silverbuggy/e191e449b1076b215db742267a5392ac

The scale is 0.5, and child dimensions are 800 width by 1000 height.

Render that widget in a page

Expected:
The child container should be scaled by 0.5 to 400 width by 500 height, in effect filling out the device width and more than half of the device height.
Actual:
The child container is scaled to exactly half of the device width and half of the device height, because the scale factor is 0.5.
If you set the container width and height to values smaller than the screen width and height, respectively, then scaling works correctly. It appears that the scaling is bounded by the screen dimensions. If I use big enough width and height for the container, I would expect for the blue widget to fill the screen entirely but the max it will go is half width and half height.
This bug repros for other values of scale < 1.0. It also repros if using Matrix4 format such as:
transform: Matrix4.diagonal3Values(0.7, 0.7, 1.0),
It also repros if I use an Image instead of a Container for the child to transform.

Hi @silverbuggy
are you still experiencing this issue with the latest version of Flutter?
If so can you please provide your updated flutter doctor -v?
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


update RGB values for default bg color

Update the default RBG vaules for background color to values that make sense for a Color4

Also included a fix for the memory leak introduced in my preview area pop up PR.
It was bothering me.


Github preview check fixes

Fixes URLs were being generated incorrectly
Fixes incorrect then/catch ordering when handling webhooks
Adds additional logging when receiving webhooks

Fixes #684

Thank you for fixing this so quickly! 🙏


Missing credentials.py

On 01-Load-Data-ACogSearch.ypynb it mentions a credentials.py on the directory app:
"Create a data source
You should already have a blob container that contains the sample data, see app/credentials.py"
That file doesn't seem to be present anywhere.

Good catch, this is an old comment left behind.
app/credentials.py doesn't exists anymore


Change status graphs

Elapsed time: not as useful anymore.
We should have a graph of contents by progress (right now we have just a list), and either scores by progress or progress by scores. Scores by elapsed time is okay and kind of interesting.

Maybe we could add a graph of which states have been processed, so we can see where the focus is.


APP-286 [Android] Review/update "Cell Monitor" app

APP-286: Fixed crashes on Android API 23 because of permission issues, added permissions handling. Added ability to work without GPS. Reviewed code.

Can one of the admins verify this patch?

@kaa-leeroy add to whitelist

Fixed code after review, @maxml please check

@kaa-leeroy test this please

@kaa-leeroy test this please


.desktop file for linux

Hi,
what do you think about creating a multibit.desktop and a multibit script for correct linux installation?
The multibit script should contain something like:
#!/bin/sh
exec "$JAVA_HOME/bin/java" -jar /usr/share/java/multibit/multibit-exe.jar "$@"

And the multibit.desktop should contain something like:
[Desktop Entry]
Encoding=UTF-8
Type=Application
Name=Multibit
Comment=A lightweight Bitcoin desktop client powered by the BitCoinJ library.
Exec=multibit
Icon=multibit
Terminal=false
StartupNotify=false
Categories=Application;

The Linux installation guide shows how to build a suitable .desktop file for MultiBit HD. Closing.


onboarding: Use dictionary comprehension for dict initialization.

Initializing a dictionary from an iterable requires the each item to be
a tuple containg a key and a value. mypy_django_plugin cannot infer
the number of items in an queryset with annotated values, so we have to
explicitly unpack each row with a dictionary comprehension here.
Affected errors:
2c2
< Found 82 errors in 29 files (checked 1406 source files)
---
> Found 80 errors in 28 files (checked 1406 source files)
45,46d44
< zerver/lib/onboarding.py error Need type annotation for "bot_counts" (hint "bot_counts Dict[<type>, <type>] = ...")  [var-annotated]
< zerver/lib/onboarding.py error Argument 1 to "dict" has incompatible type "_QuerySet[WithAnnotations[zerver__models__UserProfile], Tuple[Any, ...]]"; expected "Iterable[Tuple[<nothing>, <nothing>]]"  [arg-type]

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @PIG208!  This CI failure was an unrelated puppeteer flake.


Add docs for different string include method

Yup exactly. Every line will get x number of spaces prepended so it aligns with the rest of the yaml


feat(tensorrt_yolo): extension to 8 cameras

Description
This feature creates the node to improve the 8 cameras module performance.
It creates a node that two or three cameras share a single model in tensorrt_yolo.
Multiple cameras share a single model that can decrease GPU usage and improve model performance in a PC.
How to run:
ros2 launch tensorrt_yolo yolo_eight_cameras.launch.xml

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I think almost ok.
@miursh Can I ask for a detailed review?

@amtommy @yukkysaito  I think it is better to create a node with dynamic number of callbacks than one with specific number of callbacks. What do you think?

@amtommy @yukkysaito @miursh I think it is better to create a node with dynamic number of callbacks than one with specific number of callbacks. What do you think?

That's a good idea. But the message_filters also have the same issue.
I wanted to do it, but I don't have any experience with it.
Do you have any examples or information could share with me?

@amtommy I think you can refer image_projection_based_fusion.
https://github.com/autowarefoundation/autoware.universe/blob/main/perception/image_projection_based_fusion/src/fusion_node.cpp

@amtommy I'm wondering is your 8 cameras have almost same timestamp? Since as long as you are using message filter, they should have approximately same time.

@amtommy I'm wondering is your 8 cameras have almost same timestamp? Since as long as you are using message filter, they should have approximately same time.

Yes, our cameras have the same timestamp.

Hi @amtommy, firstly thank you for contribution. Is there any update at this PR?  As mentioned by @wep21,  image_projection_based_fusion node uses dynamic parameter for ROI number. Maybe doing it similarly, could offer use between 1 and 8 cameras.

Sorry for the late reply. Since I am processing another project, it will be processed later.

Hi @amtommy, firstly thank you for contribution. Is there any update at this PR? As mentioned by @wep21, image_projection_based_fusion node uses dynamic parameter for ROI number. Maybe doing it similarly, could offer use between 1 and 8 cameras.

Sorry for the late reply. Since I am processing another project, it will be processed later.

@amtommy
this is just a friendly reminder that this PR is not active for more than 8 months.


modularized read_hic_header script

Motivation:
There is some code duplication between read_hic_header.py and straw.__readcstr and straw.read_header. Maybe a modularized version of the code would make it easier to maintain and update? If this PR is accepted (could use feedback for modifications), straw's Python API could be made more concise.
Changes:

replaced argv with argparse functionality
refactored script code under main() function
code now raises explicit exceptions instead of sys.stderr.write+sys.exit
described 'silent' mode
filled out docstrings

Awesome, should be good now but let me know if there's something else that would be a nice feature


Adding new repository for indexing: tb3_tools

Developing some extended packages for monitoring and controlling turtlebot3 robot and enrich this repository in the near future.

@xuyuan-ict There seem to be no changes in this PR.  I'm going to go ahead and close it out, but feel free to open a new one that has the changes you want in it.

We want to add tb3_tools repo to rosdistro.
Does it success ? or anything else we need to do ?
Thanks

@xuyuan-ict your commit didn't have any changes so whatever you wanted to change didn't happen. https://github.com/ros/rosdistro/pull/27536/files
You'll need to resubmit your pull request to get a chnage.


what is the envoy config of gateway mode passthough

apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  name: bookinfo-gateway
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 443
      name: https-443
      protocol: HTTPS
    hosts:
    - "nginx.example.com"
    tls:
      mode: PASSTHROUGH

mode is PASSTHROUGH,I can not find any config in envoy config,that indicate this is passthough?

Filterchain without TLS context is generated for pass through

These kind of questions are better asked in https://discuss.istio.io/. I am closing this

discuss nobody answer me


HBASE-28988 Enhance WALPlayer for restore of BulkLoad

Enhance WALPlayer for restore of BulkLoad WAL entries
https://issues.apache.org/jira/browse/HBASE-28988

Need to update for newly suggested backup directory structure

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ HBASE-28957 Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  8s

HBASE-28957 passed

+1 :green_heart:
compile
1m  4s

HBASE-28957 passed

+1 :green_heart:
checkstyle
0m 20s

HBASE-28957 passed

+1 :green_heart:
spotbugs
0m 54s

HBASE-28957 passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 59s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed

-0 :warning:
javac
0m 34s
/results-compile-javac-hbase-mapreduce.txt
hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 10s
/results-checkstyle-hbase-mapreduce.txt
hbase-mapreduce: The patch generated 13 new + 1 unchanged - 0 fixed = 14 total (was 1)

-0 :warning:
checkstyle
0m  9s
/results-checkstyle-hbase-it.txt
hbase-it: The patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20)

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
hadoopcheck
11m 25s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 38s

patch has 65 errors when running spotless:check, run spotless:apply to fix.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

32m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6523

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux b3087804891f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28957 / ff90ac91ffe9554802d98d53351a4deda5c655bb

Default Java
Eclipse Adoptium-17.0.11+9

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-mapreduce hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ HBASE-28957 Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 47s

HBASE-28957 passed

+1 :green_heart:
compile
0m 50s

HBASE-28957 passed

+1 :green_heart:
javadoc
0m 37s

HBASE-28957 passed

+1 :green_heart:
shadedjars
6m 16s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed

+1 :green_heart:
shadedjars
5m 43s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
27m 48s
/patch-unit-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
1m  1s

hbase-it in the patch passed.

52m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6523

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 1e184da7deae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28957 / ff90ac91ffe9554802d98d53351a4deda5c655bb

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/testReport/

Max. process+thread count
3361 (vs. ulimit of 30000)

modules
C: hbase-mapreduce hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ankitsol You need to run mvn spotless:apply to fix code style issues.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ HBASE-28957 Compile Tests _

+0 :ok:
mvndep
0m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s

HBASE-28957 passed

+1 :green_heart:
compile
1m  6s

HBASE-28957 passed

+1 :green_heart:
checkstyle
0m 23s

HBASE-28957 passed

+1 :green_heart:
spotbugs
0m 59s

HBASE-28957 passed

+1 :green_heart:
spotless
1m  7s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  0s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed

-0 :warning:
javac
0m 33s
/results-compile-javac-hbase-mapreduce.txt
hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 24s

the patch passed

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
hadoopcheck
9m 55s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 39s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s

The patch does not generate ASF License warnings.

30m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6523

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 68382c610f0a 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28957 / 12fdd6dbdcfea1ce8b0721ea708212fc0079d5b6

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-mapreduce hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ HBASE-28957 Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 34s

HBASE-28957 passed

+1 :green_heart:
compile
0m 49s

HBASE-28957 passed

+1 :green_heart:
javadoc
0m 31s

HBASE-28957 passed

+1 :green_heart:
shadedjars
7m 27s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  7s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
javadoc
0m 25s

the patch passed

+1 :green_heart:
shadedjars
5m 37s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
27m 20s
/patch-unit-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

+1 :green_heart:
unit
0m 39s

hbase-it in the patch passed.

53m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6523

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux b92f4b8e2b6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28957 / 12fdd6dbdcfea1ce8b0721ea708212fc0079d5b6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/testReport/

Max. process+thread count
3286 (vs. ulimit of 30000)

modules
C: hbase-mapreduce hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

As discussed internally we need to add this enhancement outside of the WALPlayer class. Perhaps we could try to extend WALPlayer and the mapper to create a new MR job with the two functionality mixed together.
One thing I don't understand reading this patch: how the original code skipped BulkLoad edits and how the new code enabled them?


[Bug]: To give an extension access to this site Click it

Bug description
Test code is available at https://github.com/s16h/puppeteer-tab-capture-repro

Run the repo.
Try the code from the docs under Working with Chrome Extensions -> https://pptr.dev/#?product=Puppeteer&version=v13.0.1&show=api-working-with-chrome-extensions
BUG: No background page targets are returned

What is happening?
Background page is only returned after clicking the extension. Look at the screenshot below:

Expectation
Since extension was whitelisted, it should be automatically enabled and have access to all sites.
Puppeteer version
13
Node.js version
14
npm version
6.14.7
What operating system are you seeing the problem on?
macOS
Relevant log output
No log available as background_page is not available.

I am also facing this issue after update to puppeteer version 14.1.0 .
The previous puppeteer version I used was 1.11.0, which able to get target background_page.

I think it's basically the same issue as the feature request https://github.com/puppeteer/puppeteer/issues/5001 The extension testing/debugging story is not great currently.


[ARM] az deployment: Prettify error output for ARM deployment

Issue: #19213
Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

ARM


Fix many bugs and delete function

fix #1 Delete feature addes + bugs patched

Please implemente the new delete feature into the menu


NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR

complete SNMP refactor
restructured with factories, builders, configuration objects
refined error handling, validation
unit tests by SNMP version

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Reviewing

I changed the SNMPUtils::getAuth and SNMPUtils::getPriv because according to the snmp4j documentation the auth and priv protocols can be null. The map had already contained the empty string-null key value pair but the optionals threw exception instead of returning the null value.


HEXA-GONE!

The Hexagon interface below Out goals and objectives section here is not mobile responsive, and doing that will be another task itself. So instead we can work another way around.
For desktop/laptop/tablets:- try to improve the alignment of the present hexagon and its components.
for mobile view:- Get rid of this code and display a single non-interacting image.
We can create a hexagon.png. This will contain an exact replica of the present view. It will have a hexagon and six objectives at each vertex. In hexagon, there will be a fixed text Our mission

I will work on this.

@supzi-del  please submit a PR by today

Check the below video, as you can see the issue was not only the hexagon but also the box1 which was messing up the entire layout and responsiveness.
Hence I decided to add hexagons like this and also fixed the box1. So now it is completely responsive and clutter-free.
Please let me know if I should make a PR for the same.

https://user-images.githubusercontent.com/78655439/126040537-0a20e83d-1f23-4b6c-ad56-17bd18f8c8fc.mp4

Your solution is impressive, but we need to keep the same layout as earlier.
For pc/laptop we need a hexagon with values on edges. When a value is  hovered , text in hexagon changes.
Can you try to improve upon the previous one?
Also for mobile view, just create an image of hexagon with values on edges. Thats all.
And thanks for pointing the isse of box. I hope you understood the requirements 😊
Waiting for you to work other way around

Okay but I tried doing that and everything is getting messed up! (like I tried changing the values of media query for laptop/PC)

Yeah I know😐 we would really appreciate if you can make this happen🙂


Dilato: LOC: JPN/FRA: String "Recent Files" is not localized.

Launch Brackets.
File->Open Recent...
Observe string "Recent Files" in dialog.

Result:String "Recent Files" is not localized.
Expect: String "Recent Files" should be localized.

New issue for this 1.7 release

Hi All! Please note that the strings are localized in the TM database. Please retake the screens. Thank you!


Align naming DbClient and WebClient

The following code is from a service that wants to use metrics in DbClient and WebClient (removed lines that are OK):
        dbClient = DbClient.builder()
                .addInterceptor(DbCounter.builder()
                                        // %1$s - statement name, %2$s - statement type
                                        .nameFormat("db.counter.%1$s.%2$s")
                                        .build())
                .build();

        webClient = WebClient.builder()
                // %1$s - method; %2$s - host; %3$d - status code
                .register(WebClientMetrics.counter().nameFormat("counter.%1$s.%2$s.%3$d").build())
                .build();

We can see the approach differs

In order of parameters - in DB, type is second, in WebClient, "type" is first (considering HTTP method is similar to statement type)
In naming DbCounter.builder() vs. WebClientMetrics.counter()
In interface names - Interceptor vs. ClientService
In builder method names - addInterceptor vs. register

For each of these points we should find a solution and fix both implementations (and see if this is applicable anywhere else).
Note that tracing configuration should be consistent as well (not just metrics).

My recommendation:

Create DbClientMetrics that would have the same methods as WebClientMetrics
In name format, use "type"/"method" as the first parameter
Use WebClientService and DbClientService as the names
Method addInterceptor would be changed to addClientService
Method register would be changed to addClientService


feat: add a pre-commit config file

do module developers need anything special installed in their development environment in order to use pre-commit? if so, that should be documented in a README.md or CONTRIBUTING.md

do module developers need anything special installed in their development environment in order to use pre-commit? if so, that should be documented in a README.md or CONTRIBUTING.md

Yes, a Contributing Guide section in README.md is added


Add files extensions in imports/exports to make the lib fully compatible with ESM

Hey 👋,

cli-testing-library version: 1.0.2
Testing Framework and version<EMAIL_ADDRESS>
DOM Environment:

Problem description:
When using ES modules, the types definitions aren't correctly generated so types are missing:

Suggested solution:
For the types to be seen in a ESM environment, you need to import all the local files with their full path, including the extension of the file:

./foo -> ./foo.js (.js also in TypeScript, I know it's weird but I don't make the rules 😄)
./bar -> ./bar/index.js

Your code will be compatible with both CJS + ESM that way! 🥳
For references: https://www.typescriptlang.org/docs/handbook/esm-node.html (this is no longer experimental as of TypeScript 4.7)
Especially this part:

So in fact it wasn't related to file extensions in imports statements (I won't have to patch the whole ecosystem yay 😂) but a wrong type definition, explanations here: https://github.com/crutchcorn/cli-testing-library/pull/15#issuecomment-1142120041
I'll open a PR fixing the types, but could you confirm first that the types aren't generated by rollup but maintained by hand?


startSketchOn should be a valid place to extrude/edit

pulled out from https://github.com/KittyCAD/modeling-app/issues/1016 so as not to confuse the thing fixed versus not fixed

should be solved as a part of https://github.com/KittyCAD/modeling-app/issues/2931


WIP: Fix Signs

A work in progress to fix #352
It works a lot better now, but sometimes it just doesn't work yet. Suggestions and idea's are welcome how to make it better & make it work 100%
The problem:
In some cases the Sign packet get sent earlier then the chunk packet, that'd in 1.8 give 'Unable to locate sign at x,x,x'. Too bad that got removed when you need it. :disappointed:

Closing for now.


fix: for once and for all

Current dependencies on/for this PR:

main

PR #18   👈

This comment was auto-generated by Graphite.


Add support for anyOf keyword

Description

Add support for anyOf sub-schemas.
Motivation and Context

When #561 was merged to add support for oneOf properties, it looks like it was also intended to support anyOf sub-schemas as well, but there was no anyOf keyword in the example schemas, so it was merged with a bug.
The createOneOfProperty function is called if a schema has either anyOf or oneOf properties, but the function also assumes that it should read schema.oneOf.
https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/blob/3e8d8ccd9f7294154b04af7031865d792366c176/packages/docusaurus-plugin-openapi-docs/src/markdown/createResponseSchema.ts#L602
This leads to exceptions when passed a schema with anyOf.
Example Error:
[ERROR] TypeError: Cannot read properties of undefined (reading 'map')
    at createOneOfProperty (docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:503:59)
    at createEdges (docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:569:16)
    at docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:110:16
    at Array.map (<anonymous>)
    at createProperties (docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:109:46)
    at createNodes (docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:640:24)
    at docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:774:67
    at Array.map (<anonymous>)
    at createResponseSchema (docusaurus-plugin-openapi-docs/lib/markdown/createResponseSchema.js:710:33)
    at docusaurus-plugin-openapi-docs/lib/markdown/createStatusCodes.js:290:91

How Has This Been Tested?

I replaced a oneOf keyword in the example petstore schema with anyOf, then tested by building the demo website and viewing it.
If you'd prefer that we alter a different portion of the schema, or if you prefer that a new property be added, that would be fine.
Screenshots (if appropriate)

Before
**After

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have updated the documentation accordingly. (I don't think any doc updates are appropriate)
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate. (I don't see any tests, if I missed them, let me know, and I'll be happy to write one)
[ ] All new and existing tests passed. (again, I don't see any tests)

@sserrata @blindaa121 Hello! I would like to request a review from you both as this PR is related to #561 which you both worked on. Thank you!

Thanks for the PR @jordanstephens! Also, I agree that we can apply more DRY principles in this case - I think the original rationale of keeping request/response separate didn't bear out and they ended up being mostly identical. That said, I was thinking a good first step would be moving the following to a single/common module:

createNodes()
createEdges()
all other helper functions

Thoughts?

@sserrata At a glance, that sounds reasonable to me. I'd be happy to contribute. Would you like to couple that refactoring to this bugfix, though? Or would you like to try to resolve this issue and then refactor in a dedicated followup?

Hi @jordanstephens see https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/582

Hi @jordanstephens see https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/pull/582

Thanks @sserrata, sorry I missed this. That looks great! Let me know if I can help with anything, and feel free to close this when you're ready.


Is it possible to diff column comments?

Would anybody need this feature?
Sometime I need to see column comments when I use phpMyAdmin.
It's good to check the difference of comments, and update the new comments.
I had tried to add some code for the column comment diff, it works with MySQL.
But I'm not sure it works on the other platforms.
I will send a PR for my implementation later.

Is someone able to make a PR here with suggested changes?
Or shall we close?


Lepiter: Add support to create SmaCC parsers from Pharo snippets

We want to be able to create SmaCC parsers from lepiter pages. Currently, we can create only regular classes.

New fix-it context menu option:

Classes that do not end with Parser do not have the Create SmaCC parser... menu option:

There are some inconsistencies in GtParserCreationForm Magritte descriptions. It expects values to be String kind, but uses BlText instances.


Read Sequelize configuration

Follow the next steps to configure the project and to check witch sequelize version is the user having:

Read .sequelizerc file
Read sequelize version
2.1 Version 6 >= load index in ./db/models (lookup at sequelize cli doc)
2.2 Version 6 < load index in ./models

./db/models is an example configuration provided at the docs. Default value remains at ./models


sentence tokenizer drops punctuation

An input like
Hello world! I love you.
Turns into:
['Hello World', 'I love you']
Fix incoming! Opening here for tracking.

Fixed in last PR


Missing Prometheus datasource variable for Grafana dashboards

Version

Karpenter Version: v0.28.0

Kubernetes Version: v1.27.0
Expected Behavior
The Grafana dashboards from the website/content/en/v0.28/getting-started/getting-started-with-karpenter directory should work out of the box with the default Prometheus datasource configured in the Grafana instance.
Actual Behavior
For the karpenter-controllers.json and the karpenter-controllers-allocation.json dashboards, loading the dashboards on Grafana 9.5.3 fails with Failed to upgrade legacy queries Datasource ${DS_PROMETHEUS} was not found.
However, the other two dashboards work because of a dashboard variable named datasource  that queries for the default Prometheus datasource: https://github.com/aws/karpenter/blob/63f76f3f3871f22eb9768285ba5290370e29ccd6/website/content/en/v0.28/getting-started/getting-started-with-karpenter/karpenter-capacity-dashboard.json#L1410-L1427
The datasource is then used throughout the dashboard to reference the queried datasource:
https://github.com/aws/karpenter/blob/63f76f3f3871f22eb9768285ba5290370e29ccd6/website/content/en/v0.28/getting-started/getting-started-with-karpenter/karpenter-capacity-dashboard.json#L29-L32
The two "broken" dashboards in question use the DS_PROMETHEUS variable to resolve the datasource.
Steps to Reproduce the Problem
Provision the dashboards on a recent Grafana version and load the dashboard.
Resource Specs and Logs
As it doesn't really affect Karpenter, I don't have any logs or other resources
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Nice find! Would you be willing to cut a PR to fix @oliviermichaelis?

Yeah SGTM.

Same error appearing on using dashboard from https://grafana.com/grafana/dashboards/18862-karpenter/ . Is there any workaround to mitigate this ? Thanks in advance.

@stars693 I don't think the dashboards you linked are "officially" by the karpenter project. Feel free to try out the dashboard JSON files from my PR and check whether they solve the problem for you :)


unable to build due to pycurl

looks like system used to build the image is RHEL based, hence pycurl installation is failing, please refer to the solution in this link and install libraries accordingly.
fail build: https://github.com/GEM-benchmark/NL-Augmenter/pull/113/checks?check_run_id=3026110664
reference link: https://stackoverflow.com/questions/66419978/could-not-install-pycurl-7-43-0-6-on-python-3-8-8-rhel-8-3

not required as of now as i used the wptools without pycurl version.


Change all imports to github.com/... format

It looks like we need to start adding the linux dependencies, otherwise the whole thing won't compile in the travis environment

https://travis-ci.org/maxfish/gojira2d/builds/366887650 finally green


Mavenized the project

We use the memory-measurer a lot in our project. But to integrate it into our maven build we need a maven version with a valid pom.xml.
So I removed the ant based build, created an appropriate pom.xml file and reranged the file to meet the maven requirements.
As it stands know it uses Guava 18.0 which requires at least JKD 1.6.

hi there
so how to get that maven project ???

Just the clone the fork that is waiting to be pulled. In this case its https://github.com/pluess/memory-measurer

Just the clone the fork that is waiting to be pulled. In this case its https://github.com/pluess/memory-measurer

@pluess Do you guys use it with Java 17?  how do you build object-explorer.jar ?

Well it's a wile since I used this code. I I remember correctly, it has been working fine with JDK 1.8. Since we are no longer using it, I don't plan to put any efforts into it.


Fix setting level based on the format

properly set level to 50 if VGC
immediately set proper level upon selecting set, to prevent useless
"level changed" popups when switching sets

:+1


Rewire fs options to use different sizes for different file types

We were using a single buffer size for readers of all the different file types, despite 3/5 files being significantly smaller than the other two. This PR addresses that.
/cc @robskillington @richardartoul

Coverage decreased (-0.08%) to 78.318% when pulling 9c51d89a9973d4cd81502af84badb11f20790f7d on prateek/explicit-buffer-size into caa283a70486c9d414bdfe3f075f36c81d503864 on master.

Coverage decreased (-0.06%) to 78.338% when pulling a4bb4da3f25ab02bce43ed5b0dd7bf82102c8525 on prateek/explicit-buffer-size into caa283a70486c9d414bdfe3f075f36c81d503864 on master.

Coverage decreased (-0.06%) to 78.338% when pulling a4bb4da3f25ab02bce43ed5b0dd7bf82102c8525 on prateek/explicit-buffer-size into caa283a70486c9d414bdfe3f075f36c81d503864 on master.

Coverage decreased (-0.08%) to 78.321% when pulling a4bb4da3f25ab02bce43ed5b0dd7bf82102c8525 on prateek/explicit-buffer-size into caa283a70486c9d414bdfe3f075f36c81d503864 on master.


[1/N] Ludii fix for big merge branch

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Primary change is the correct implementation of operator= for LudiiStateWrapper, necessary to make Ludii games work correctly again with the big branch to be merged into master at a later date.
Minor changes:

Added "-XX:+HeapDumpOnOutOfMemoryError" to the JVM args, which means we'll now produce a heap dump whenever Java runs out of memory (might be useful for debugging)
Switched to calling new static factory methods instead of constructors in Java for constructing Java's LudiiGameWrappers. On the Java end, these factory methods now keep track of a cache of previously-instantiated game objects and recycle those if possible.

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[ ] All tests passed, and additional code has been covered with new tests.

Merged in https://github.com/facebookincubator/Polygames/commit/6419e985e18d79bfd6384455ef69db0c6bf3beaf

Merged in https://github.com/facebookincubator/Polygames/commit/6419e985e18d79bfd6384455ef69db0c6bf3beaf


broker not clean ledger from metastore successfully

Describe the bug
In our cluster, some ledger disks are used up(data4) but others are not.
Filesystem      Size  Used Avail Use% Mounted on
/dev/sdb1       1.8T   14G  1.7T   1% /data1
/dev/sdc1       1.8T   13G  1.7T   1% /data2
/dev/sdd1       1.8T   13G  1.7T   1% /data3
/dev/sde1       1.8T  1.7T   13G 100% /data4
/dev/sdf1       1.8T  316G  1.4T  19% /data5
/dev/sdg1       1.8T  329G  1.4T  19% /data6
/dev/sdh1       1.8T  486G  1.3T  28% /data7
/dev/sdi1       1.8T  316G  1.4T  19% /data8
/dev/sdj1       1.8T  319G  1.4T  19% /data9
/dev/sdk1       1.8T  323G  1.4T  19% /data10
/dev/sdl1       1.8T  383G  1.4T  22% /data11
/dev/sdm1       1.8T  1.1G  1.7T   1% /data12

After list the ledger file, the oldest file are created two monthes ago.
-rw-r--r-- 1<PHONE_NUMBER> Jun 15 19:02 367.log
-rw-r--r-- 1<PHONE_NUMBER> Jun 15 19:03 368.log
-rw-r--r-- 1<PHONE_NUMBER> Jun 15 19:15 36e.log

Then read the first file by bin/bookkeeper shell readlog 367.log and only on ledger 1110144 in this file. This ledger can be also found on the metastore.

And, I wrote a util to read data from zk and got the meta info for this ledger
meta key pulsar/managed-ledger  and meta value infosec/InterfaceGroup/persistent/gj630_msgcloud_delay_1-partition-18

This means the ledger belongs to topic  infosec/InterfaceGroup/gj630_msgcloud_delay_1-partition-18.
The internal stats for this topic
{
  "entriesAddedCounter" : 0,
  "numberOfEntries" : 1099,
  "totalSize" : 3108981,
  "currentLedgerEntries" : 0,
  "currentLedgerSize" : 0,
  "lastLedgerCreatedTimestamp" : "2021-09-22T09:00:52.171+08:00",
  "waitingCursorsCount" : 0,
  "pendingAddEntriesCount" : 0,
  "lastConfirmedEntry" : "1444577:1098",
  "state" : "LedgerOpened",
  "ledgers" : [ {
    "ledgerId" : 1444577,
    "entries" : 1099,
    "size" : 3108981,
    "offloaded" : false
  }, {
    "ledgerId" : 3525781,
    "entries" : 0,
    "size" : 0,
    "offloaded" : false
  } ],

This topic only contains two ledger 1444577 and 3525781, 1110144 is not included.
Additionally, the TTL for the topic is 14400 seconds(1 day)
Retention size is -1 and retention time is 240 minutes(6 hours)
Expected behavior
Ledgers in metastore should be removed if  retention policy meet.

@codelipenghui @hangc0276 PTAL, thx.


Binary seems to open at root directory of user directory (macOS)

code-server version: code-server-1.32.0-310-darwin-x64
OS Version: 10.14.3 (18D109)

Description
The binary seems to open at the root of the user folder with no working directory specified. It seems as though the default behavior should be for the binary to open in the directory that it resides in.
Watching all of these files also seems to dramatically reduce responsiveness.
Additional Info
Nothing stored in local storage besides an entry for colorThemeData

Steps to Reproduce

Download binary
Right click on binary - open
Observe file tree

Has anyone noticed this behavior on any other platforms?

The default at the moment is to use the current working directory, so it should default to wherever you are when you run the command.

Don't forget to specify location on the binary/run script
code-server <initial directory to open>


feat(plugin) add session plugin

Adds session plugin to bundled plugins:
Relevant Session Plugin PR: https://github.com/Kong/kong-plugin-session/pull/9

The plugin seems to be tested against Kong's master branch (https://github.com/Kong/kong-plugin-session/blob/master/.travis.yml#L51) - could we run a sanity job against Kong's next branch to make sure it won't be broken in 1.2.0?

Given that the plugin's version was bumped to 1.0, and assuming that other environments depending on this plugin have pinned it to a 0.x version, we should consider removing the BasePlugin inheritance (and :new() implementation along with .super parent calls) in this plugin's 1.0 version (see https://github.com/Kong/kong-plugin-session/blob/master/kong/plugins/session/handler.lua#L9-L16). The pattern is not required anymore in Kong 1.2 (next branch) and plays a role in the 1.2 performance improvements. It is a very minor change to the plugin, see https://github.com/Kong/kong/commit/a29c3553f43dd53cfc78d618e653e3e7ae484dbb for an example on this repository's plugins.
We should also consider updating the plugin to use the PDK, which is a relatively easy task and brings a number of improvements to the plugin (e.g. abstracted req/resp getters/setters, prefixed logs or namespaced ctx tables, etc...), but that wouldn't be a blocker on my end.

@thibaultcha thanks for the great feedback. I have a working PR with pdk updates and removing the BasePlugin inheritance: https://github.com/Kong/kong-plugin-session/pull/9
WRT the version, will removing the base plugin constitute a minor bump of the plugin version to 1.1.0-1? As I understand, the plugin inheritance is a breaking change so the new<EMAIL_ADDRESS>will not work with Kong < 1.2?

WRT the version, will removing the base plugin constitute a minor bump of the plugin version to 1.1.0-1? As I understand, the plugin inheritance is a breaking change so the new<EMAIL_ADDRESS>will not work with Kong < 1.2?

I noticed yesterday that the plugin was recently bumped to 1.x. My suggestion would be:

If no other component requires version 1.x of this plugin, consider the BasePlugin class removal part of the 1.x release, and re-tag the release
If another component already bumped its dependency on this plugin to 1.x, then release 2.x (since we follow semver in our bundled plugins' versioning, we should bump the major version number).

What do you think?

@darrenjennings Minor bump is alright, if it doesn't get into EE or some older version that requires BasePlugin.

It is currently tagged in EE with explicit "kong-plugin-session == 1.0.2-3" so not a big deal for us. The breaking change is due to the Kong 1.2 peer dependency, so would be best if we could specify peer dependency version in luarocks, but we cannot. In npm you can specify peer dependency and it will error during install. So I am OK with minor bump as well per @bungle's suggestion, and updating the comment https://github.com/Kong/kong-plugin-session/blob/1bb43edc52357903e54e939655d20cd0af3afb16/kong-plugin-session-1.0.2-3.rockspec#L21

@darrenjennings I'd strongly advise against shipping breaking changes in a patch/minor release.

@darrenjennings Along with this change, we also need a docs update to this page (note the document linked to points to the 1.2.x version of this page, which is where the change should be pushed to).

thanks for the link. I've bumped the session plugin to 2.x per your advice and latest changes for session PR is back up here: https://github.com/Kong/kong-plugin-session/pull/9
Also added a PR for the session docs:
https://github.com/Kong/docs.konghq.com/pull/1318

Also, the tests are passing on the next branch:
https://github.com/Kong/kong-plugin-session/runs/142688711

Great! Since the 2.0 version of the plugin is not published yet, it seems like CI is failing, otherwise this looks good!

If we're adding this in 1.2.0, let's hold from merging it here and I'll cherry-pick it into release/1.2.0

The breaking change is due to the Kong 1.2 peer dependency, so would be best if we could specify peer dependency version in luarocks, but we cannot. In npm you can specify peer dependency and it will error during install.

Fun fact: LuaRocks does in fact have "peer dependencies" since 2008(!). The syntax is prepending the operator with @ (as in kong @> 1.2) and this was added back in the day for Sputnik plugins: http://lists.luaforge.net/pipermail/luarocks-developers/2008-July/000759.html
It seems we just never documented the feature!? I can't find it in the LuaRocks wiki, at least. We do not have dependency alternatives, though (i.e. or operator in dependencies), so adding the above might not be advisable for plugins if we end up having different version constraints for Kong and Kong Enterprise.


Update README to Reflect New Build Process and Test Compatibility Check

In PR #13, the build process has undergone significant changes, but the README files have not yet been updated to reflect these modifications. Additionally, it's unclear whether the current tests are fully compatible with the updated build version. The scope of this issue includes manually verifying the functionality of the development and build processes and ensuring that the tests work as expected. Once confirmed, the README instructions should be updated to provide accurate guidance for both development and build environments.
Tasks:
Manually check

[ ]  the development and build process based on the changes introduced in PR #13.
[ ] Verify the compatibility and proper functioning of existing tests with the updated build.
[ ] Update the README with clear instructions for setting up the development environment and executing the build process.
[ ] Document any changes or new steps required for running tests.

i would like to solve this issue..u can assign me this ..thanks

okay, make sure you make it look good in the end.

Here are some commands you can use to set up the project and handle the build process (please verify these as well)

Dev Mode (Editable): pip install -e.[test]
Make Build: pip install .
Test: pytest -v
Run from Project Root Folder


mustPayToPubKeyAddress and mustPayWithDatumToPubKeyAddress have misleading docstring

The two functions above use the following docstring:
-- | Lock the value with a payment public key hash and (optionally) a stake
-- | public key hash.

however the argument they take is a StakePubKeyHash rather than a Maybe StakePubKeyHash.
I noticed older version of ledger-constraints used to have the same wording, but they have recently updated it (crf. https://github.com/input-output-hk/plutus-apps/blob/main/plutus-ledger-constraints/src/Ledger/Constraints/TxConstraints.hs#L310-L312)

Doesn't apply already:

"public key address" for address with stake keys (base)
"public key" or "public key hash" for address without stake (enterprise)

Officially these are called base and enterprise addresses, but noone uses these names.

Is there any reason this can't be closed?
Perhaps we could add the below just for clarity.
-- | Lock the value with a public key address. (Base Address)
-- | Lock the value with a public key. (Enterprise Address)

closed by #1303


Implement Interface layer between GraphQL and Connector

Implement a representation for (local) graph queries that will be created by the GraphQL resolver, and executed by an Connector.

[ ] Represent queries (selections  & conditions)
[ ] Represent results

Surpassed by the new design.


docs: Document create_database_subnet_group requiring database_subnets

Description
I ran into the same issue as https://github.com/terraform-aws-modules/terraform-aws-vpc/issues/126 because there's nothing in the documentation making it clear that create_database_subnet_group only has an effect if you also specify database_subnets.

Thank you, @acdha !

Thank you for such a handy module!

@antonbabenko @acdha Any idea is if the new db subnet group name that gets created can be an output from the vpc module? I need this as an input to an rds instance. Not seeing any docs on output availability from vpc module.

https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/23b0a02d2a3225a05ddf5f31d9a32728bf5505c3/outputs.tf#L131-L134