_relative_symlink_target depends on the host filing system

See original issue on GitLab
In GitLab by [Gitlab user @jmacarthur] on Dec 19, 2018, 17:31
Summary
The function _relative_symlink_target attempts to turn absolute symlinks into relative ones (relative to a particular directory passed as 'root'). It also attempts to resolve any symlinks which are present in the target of the symlink. It uses os.path.realpath to do this. This introduces a dependency on the host file system.
Further, any modification of the symlink target is undesirable; we should leave absolute symlinks as is, and change our resolution of them, if we ever have to.
Example
This is theoretical; no reproduction case has been found yet. However, see #647 which demonstrates that paths containing symlinks could be resolved by this.
This is an example call:
_relative_symlink_target('/home/jimmacarthur/.cache/buildstream/build/acl-5o7v8tlb/artifact/buildtree', '/home/jimmacarthur/.cache/buildstream/build/acl-5o7v8tlb/artifact/buildtree/bst_build_dir/include/acl',
'/buildstream/freedesktop-sdk-bootstrap/acl.bst/bst_build_dir/../include')

Both the first and second argument are passed into realpath. Anything in the path up to 'buildtree' could be a symlink, and can change between two calls to realpath, so the results could be completely changed by the host's file system.
Note that there are two separate issues here: one is the conversion of the symlink's target from absolute to relative, and the second is the resolution of any further symlinks which are found in the path of the target.
What is the expected correct behaviour?
We should never ask the host operating system to resolve absolute symlinks. It is possible to turn an absolute symlink into a relative one using os.path.relpath, which we already do. We just need to remove the calls to realpath. If we decide that we need to resolve symlinks in the target, we should do our own resolution rather than using realpath. However, we may decide that we don't need to do that at all.
There is a further argument that we should not convert absolute symlinks to relative ones at all; this is not part of this issue.
Possible fixes
Valentin's MR !862 already includes a host-independent symlink resolver, and CASVirtualDirectory has its own internal resolver.

In GitLab by [Gitlab user @jmacarthur] on Dec 19, 2018, 17:31
changed the description

In GitLab by [Gitlab user @LaurenceUrhegyi] on Dec 20, 2018, 10:38
marked this issue as related to #787

In GitLab by [Gitlab user @jmacarthur] on Dec 21, 2018, 10:51
mentioned in commit 0881297b891137242edc22348b639a284f0a6152

In GitLab by [Gitlab user @jmacarthur] on Dec 21, 2018, 10:59
mentioned in merge request !1023

In GitLab by [Gitlab user @jmacarthur] on Dec 21, 2018, 10:59
assigned to [Gitlab user @jmacarthur]

In GitLab by [Gitlab user @juergbi] on Feb 9, 2019, 11:49
mentioned in commit 63635ee27e87b56870df9655091aee306554b616

In GitLab by [Gitlab user @juergbi] on Feb 9, 2019, 11:58
mentioned in merge request !1140

In GitLab by [Gitlab user @juergbi] on Feb 9, 2019, 12:03
mentioned in commit e57fb7cc8bec64c4efb0942e7d39acf92effd6f7

In GitLab by [Gitlab user @juergbi] on Feb 11, 2019, 07:18
mentioned in commit 244b80cd054a2a58dbae143477f3cfff3bcb0c19

In GitLab by [Gitlab user @juergbi] on Feb 12, 2019, 16:56
mentioned in commit 5f928aeea246d6e6242f04c53f32bd1bda28c1d9

In GitLab by [Gitlab user @juergbi] on Feb 12, 2019, 16:57
mentioned in commit 4e450529ff0b07b308ddc30bc1ea110d8741e563

In GitLab by [Gitlab user @juergbi] on Feb 13, 2019, 12:45
mentioned in commit 097209abd08bff060ad1151612dd604ee6448344

In GitLab by [Gitlab user @juergbi] on Feb 13, 2019, 14:55
mentioned in commit<PHONE_NUMBER>cf9b87b4f81562ce3681333c99660f

In GitLab by [Gitlab user @juergbi] on Feb 14, 2019, 08:41
mentioned in commit 2604b239260b9525503346069d1d56d7766f795c

In GitLab by [Gitlab user @juergbi] on Feb 14, 2019, 14:31
mentioned in commit d3b7728a213a20bc28788763ee076f8b0004c721

In GitLab by [Gitlab user @juergbi] on Feb 14, 2019, 15:05
mentioned in commit e7e4086e293722bfe556c8e6ef07b0f37821cb38

In GitLab by [Gitlab user @juergbi] on Feb 14, 2019, 16:29
!1140 is now merged and _relative_symlink_target() has been completely removed. Absolute symlinks are no longer mangled.

In GitLab by [Gitlab user @juergbi] on Feb 14, 2019, 16:29
closed


Expressing query params as arrays with a single element

Hi, before history switched from qs I used array-value params:
{ // query object
  paramName: ['firstValue']
}

Which was serialized to:
?paramName[]=firstValue

So when it was re-parsed we'd end up with the same query object. It doesn't look like the query-string stringifier has a way to express array values with a single element, as a result the re-parsed query object is different than the original query object:
{
  paramName: 'firstValue'
}

Is there any way to achieve transitive stringify/parse behavior with this lib or is that out of scope? I can write my own custom parser/stringifier if needed.

Out of scope. There are no specced or consistent way of doing nested query params. Different backends handle it differently.
See: https://github.com/sindresorhus/query-string#nesting


Auto left-click when use right-click to open the context menu

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.77.3
OS Version: Fedora 37

Steps to Reproduce:

Right-click to open menu in code area
If the pointer is inside the menu,  an automatic left-click will occur when you release the mouse button, selecting the option over which the mouse is hovering.
If you drag the pointer out of the menu the mouse pointer and release the button, a left-click will not occur
The same problem occurs in the Insiders version.

/duplicate of #167941

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Jax requires jaxlib

close https://github.com/huggingface/datasets/issues/5666

I self-assigned #5666 and I was working on it... without success: https://github.com/huggingface/datasets/tree/fix-5666
I think your approach is the right one because installation of jax is not trivial...
Next time it would be better that you self-assign an issue before working on it, so that we avoid duplicate work... :sweat_smile:

Oh sorry I forgot to self assign this time


How do I start training the ALIGN model？

Thanks for the interest, please see README for more details.


New Crowdin translations

Enjoy!

Had to partially revert this : some generated files have a length of 0, which makes build fail.


Colored usernames in @mentions in chat

What should be added?

Under miscellaneous settings you can make usernames bold and give them a different font weight. (also for usernames without an @) It would be handy if those bold usernames also took on the color of the specific user.
Why should it be added?

This would make it easier to follow conversations in a chat.
Also, to be clear, I'm not talking about the username that is before a message, but a username that someone mentions when talking to someone.

Duplicate of #2121
There's always the nightly version available here on github releases https://github.com/Chatterino/chatterino2/releases/tag/nightly-build if you want to try the feature out before the next stable release is available for any feedback you might have.


Enable cross env compatibility

Currently, the library is not working on Windows, as Windows handles variable environments differently.
The issue is about the line:
"build:js": "NODE_ENV=production webpack build",

It has been checked on node versions 16.14.2 and 18.12.1.

Introducing cross-env library as dev-dependency would solve that issue.

Good change. Merged.


Enable archiving

I was not enable to archive package without this configuration. (RN 0.21)

Thank you.


Fix ore bag not picking up artifact fragments

About the PR
Removed the whitelist from MagnetPickupComponent. Changed it so that it refers to the Storage component's whitelist when deciding which items to magneticly pickup. The only item which has the MagnetPickup system is the ore bag (at this time).
Why / Balance

This was supposedly implemented in #19562 but due to a hardcoded whitelist in the MagnetPickupComponent, the ore bag did not actually pickup anything but ore.
Technical details

Media

https://github.com/space-wizards/space-station-14/assets/8052856/da020c0b-7784-4734-90d9-e31dfd451c02

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Ore bags now pickup artifact fragments as well as ores

good first pr


[FEATURE REQUEST] Non-linear volume control

should be implemented in https://github.com/duzda/deezer-enhanced/commit/83970df46849fadf3cc7881aa5ad282556c8e833
volume 0.0 to 0.1, step = 0.01
volume 0.1 to 0.2, step = 0.02
volume 0.2 to 0.3, step = 0.03
and so on...
The feature not fully implemented, as dynamic volume should be implemented not only in the tray icon, but also in the deezer's inbuilt controls https://github.com/duzda/deezer-enhanced/issues/4


Unite types LedgerDiff & AccountBalanceUpdate

One requirement I would add is the ability to easily track Accounts created from the staged ledger diff


Dynamic policy mapping

Implementation of dynamic policy mapping idea from https://github.com/svagner/vault-auth-chef/issues/10

Sorry for long review and thanks for contributing!


Whisper pipeline: reset decoder with past state for each chunk

reset decoder_with_past state for each chunk
set transformers>=4.43 as it's required for whisper export with cache_position input
add streamer tests
remove streamer from samples. Timestamps extraction can drop segments in case of audio cut of in the middle of the word. Or if max_new_tokens stops generation in the middle of segment. This could cause streamer output and generate function result mismatch. Fix to be discussed.

@ilya-lavrenov I added tests to check if streamer output matches pipeline result. The distil-small.en model fails tests.  Not finished segment tokens excluded from the result. But were sent to the streamer right after argmax.
For the moment I added assert to forbid streamer with return_timestamps=True and thus long-form audio.
As a fix we can 'stream' the whole chunk tokens after timestamps extraction.


Add API calls to SecretStoreClient needed for future PRs

Add a number of API calls to the SecretStoreClient
that will be needed to implement Geneva release
security features. These calls support revokation
of previously issued tokens, revokation of the root
token, and generation of new root tokens from
the Vault master key.
Signed-off-by: Bryon Nevis<EMAIL_ADDRESS>

These changes are needed for #1928, #1927, and #1929.
Since no calls have been added to security-secretstore-setup, the testing instructions for this PR are to run the unit tests (go test) in secretstoreclient and secretstoreclient\mocks.

Codecov Report

Merging #2203 into master will increase coverage by 0.61%.
The diff coverage is 82.51%.

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
+ Coverage   39.22%   39.83%   +0.61%
==========================================
  Files         179      180       +1
  Lines       12743    12926     +183
==========================================
+ Hits         4998     5149     +151
- Misses       7477     7498      +21
- Partials      268      279      +11

Impacted Files
Coverage Δ

internal/security/secretstoreclient/vault.go
93.63% <100%> (+4.61%)
:arrow_up:

internal/security/secretstoreclient/mocks/mock.go
100% <100%> (ø)
:arrow_up:

internal/security/secretstoreclient/roottoken.go
67.67% <67.67%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9431f...38fbb54. Read the comment docs.

rebased


[BUG] Exponentiations with function parameters return double as result

Describe the bug
When using a function parameter as an exponent the type is not correctly inferred even if it is statically typed.
Code to reproduce the behaviour:
Code:
cdef main(int n):
  cdef int iterations = 2**n
  for _ in range(iterations):
    ...

Compiler Output:
cdef main(int n):
    cdef int iterations = 2**n
                           ^
------------------------------------------------------------

binary_trees.pyx:17:27: Cannot assign type 'double' to 'int'

Fix:
cdef main(int n):
  cdef int iterations = int(2**n)
  for _ in range(iterations):
    ...

Expected behaviour
It should not be necessary to add the int() cast
OS
Linux
Python version
3.11
Cython version
3.0.2
Additional context
No response

The is working as intended (and a breaking change in Cython 3). If n is negative then the result won't be integer, therefore the result can't be integer.
You can restore the old behaviour using the cpow directive (https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#compiler-directives).
I think we were a bit cleverer about guessing user intent with double**double exponents (which now become complex) - in this case we'd assume you wanted the old behaviour because of what you assigned it to. In hindsight we possibly should have done the same for int, but I don't think we want to go back and start adding new cases - it's complicated enough already.

we'd assume you wanted the old behaviour because of what you assigned it to. In hindsight we possibly should have done the same for int

The question is whether we'd hide bugs on user side that way. If someone called main(-3) above, we'd have to raise a runtime exception, or do something else that would avoid returning an unexpected value from the computation. It's easy to forget that something as ubiquitous and innocent as int can trigger an invalid computation on exponentiation.


Update bug template to match with others

Pull Request
What does this PR do?
Fixes #110

bors merge


Make sure we trim tags from cli

Describe the bug
A clear and concise description of what the bug is.
Make sure we trim tags from cli
To Reproduce
Steps to reproduce the behavior:
./nb run type="cql" alias="ebdse_mostly_writes" yaml="https://gist.githubusercontent.com/.../simple_compaction_schema_v2.yaml" cl="LOCAL_ONE" showcql="false" interval="1" tags="phase: main" cycles="0..20000000" threads="100" host="<IP_ADDRESS>" maxtries="10" cbopts=".withSocketOptions(new SocketOptions().setReadTimeoutMillis(20000)) .withPoolingOptions(new PoolingOptions().setConnectionsPerHost(HostDistance.REMOTE, 16, 64))" errors="histogram" keyspace="density" key-count="100000000" ckey-count="100000" blob-len="19040" --log-histograms '/home/automaton/fallout_artifacts/ebdse_mostly_writes.hdr::5m' --log-histostats '/home/automaton/fallout_artifacts/ebdse_mostly_writes.csv::5m' --report-graphite-to <IP_ADDRESS>:2003 --metrics-prefix client_node0 2>&1 | tee /home/automaton/fallout_artifacts/ebdse_mostly_writes.log
note the space tags="phase: main"
errors with There were no unfiltered statements found for this activity.

Fixed in master


no makefile in zephyr/samples/bluetooth/mesh examples

no makefile in zephyr/samples/bluetooth/mesh examples
in this https://github.com/zephyrproject-rtos/zephyr/releases/tag/v1.10.0-rc1

That is intentional.
Zephyr version 1.10 has migrated to CMake. See https://lists.zephyrproject.org/pipermail/zephyr-users/2017-November/000772.html

Thanks for reply !!
http://docs.zephyrproject.org/boards/arm/nrf52840_pca10056/doc/nrf52840_pca10056.html
cd $ZEPHYR_BASE/samples/bluetooth/mesh
Make a build directory, and use cmake to configure a Make-based build system:
$ mkdir build && cd build
$ cmake -DBOARD=nrf52840_pca10056 ..


Update package.json and docs for release

Codecov Report

Merging #118 (46bb7ea) into main (7e630a7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   98.89%   98.89%
=======================================
  Files          63       63
  Lines         999      999
  Branches      201      201
=======================================
  Hits          988      988
  Misses         11       11


Split useIdiomaticEndpoints into useIdiomaticGrpc and useIdiomaticScala

This PR addresses sbt-mu-srcgen #93 along with an upcoming code-change PR for sbt-mu-srcgen and a documentation update PR for mu-scala.
It does so by splitting the useIdiomaticEndpoints source-generation flag (created in mu-scala #599 to control service method capitalization and package prefixes), into 2 distinct flags with different defaults:

useIdiomaticGrpc which controls the namespace prefix and defaults to true;
useIdiomaticScala which controls the endpoint capitalization and defaults to false.

More formally, if useIdiomaticScala is true and if all the RPC call definitions in an input IDL are capitalized, the Scala methods in the services generated from this IDL will be de-capitalized, while the gRPC endpoints derived from those will be re-capitalized to match the original IDL. For example, a Protobuf IDL rpc GetBook definition becomes a Scala def getBook method inside a methodNameStyle = Capitalized service, which then generates a GetBook gRPC endpoint. A getBook IDL definition (for example from Avro) would remain unchanged (methodNameStyle = Unchanged, def getBook, and getBook gRPC endpoint).
The reason for the limitation that all RPC calls must be capitalized for the option to apply, is that we do not annotate individual methods, only the top-level @service annotation. Thus if we were to de-capitalize a mixed-capitalization group of calls and apply methodNameStyle = Capitalized to the service, some of the originally-lowercased methods would be incorrectly re-capitalized which is part of the issue we're addressing here (for example, getBook and GetBook would both become def getBook Scala and GetBook endpoints).
Note that the PR also updates the documentation, moves some test resources into the resource root, splits and renames tests between Schema, Protocol, and Cats laws classes, and normalizes the tests a bit between the Avro and Proto cases.
I'm happy to provide some more background on the "idiomatic" flag's history as I understand it, in case it helps in reviewing this change. Feel free to ask about this or anything else unclear.

Maybe a silly question, but do we really need these flags?
I don't see any reason to ever disable useIdiomaticGrpc. As I understand it, including the namespace in the service name is not just "idiomatic", it's de-facto standard. I'd say the fact that Mu didn't do this originally was probably a bug.

if useIdiomaticScala is true and if all the RPC call definitions in an input IDL are capitalized, the Scala methods in the services generated from this IDL will be de-capitalized, while the gRPC endpoints derived from those will be re-capitalized to match the original IDL

This seems like an awful lot of work just to avoid a capital letter at the start of a method name. Do we have any evidence that our users actually care about this?
Maybe we can reduce complexity by being a bit more opinionated and less configurable?

Maybe a silly question, but do we really need these flags?

@cb372 After some reflection I agree about both flags. For useIdiomaticGrpc, keeping it around could help legacy services that may have grown dependent on the non-standard gRPC endpoints when calling them from outside Mu, but that should be a rare case and anyway we decided to allow a breaking change here.
As for useIdiomaticScala and the methodNameStyle flag it controls, they're mostly holdovers from when we had an IDL-generation-from-source feature and we often had idiomatic Scala methods as a source and idiomatic Protobuf as a destination. (See mu-scala #599.) It's a bit more awkward to implement in reverse as we're seeing, and perhaps a user insisting on idiomatic method names could just add a layer of indirection to the calls. If we do get rid of that flag we may as well get rid of the methodNameStyle annotation parameter as well since there's no longer a use case where it would have a value of Capitalize.
Thoughts?

So to summarise,

keep useIdiomaticGrpc, only for the sake of legacy users who might need it
lose useIdiomaticScala
but keep the underlying methodNameStyle flag in Mu, for people who use Mu but don't use sbt-mu-srcgen and might want the method names capitalised in gRPC

Sounds good to me, assuming my understanding is correct.

@cb372 I removed useIdiomaticScala and kept the name useIdiomaticEndpoints for the gRPC package prefixes for maximum compatibility, and made it true by default for clarity. Please let me know if that makes sense.


Bug: Unpublished Events Showing in Calendar

@bogdankharchenko
I did a test by unpublishing a Tech After Five's Charlotte, NC event on August 13th on the stage site.
It dropped off the Events page, but it's still on the calendar

I'll PR a fix for that in sec


kube-prometheus: TargetDown alert is not working

Alert definition from kube-prometheus:
alert: TargetDown
expr: 100
  * (count(up == 0) BY (job) / count(up) BY (job)) > 10
for: 10m
labels:
  severity: warning
annotations:
  description: '{{ $value | printf "%.2f" }}% or more of {{ $labels.job }}
    targets are down.'
  summary: Targets are down

It won't work as expected:

for the first 5 minutes alert is in PENDING state (waiting 10 minutes)
after 5 minutes there are no results of count(up == 0), failing job is just not present at all
alert is resolved despite failing job

I think it affects all alerts based on up metric.
Is there a better way of doing such alert?

This is just a general alerting rule, you will want to write an extra rules if you have more knowledge about your target. The up metric goes away if a target disappears.


Fix undefined class if className is undefined

Section will get 'undefined' class if no className is provided as property

This commit fixes the issue

Great spot!


add release workflow for keda connectors

The release workflow will be triggered when:

there is a merge at the master branch and **/version file is changed.
Following things are achieved in the workflow:
builds the docker image and pushes it to the respective docker hub repository of the connector
tags the image as latest, version no. mentioned in the file

@suramya-shah I think it would be nice if you add a new section around this in the https://github.com/fission/keda-connectors/blob/master/CONTRIBUTING.md file .

Also, we added a new connector for GCP recently. We should include that in this in PR too


onEndReached for SpatialNavigationVirtualizedGrid

Is your feature request related to a problem? Please describe.
I need to implement backend pagination for a very large grid using the SpatialNavigationVirtualizedGrid component.
Describe the solution you'd like
I propose adding an onEndReached prop to the component. This prop would be triggered when the last row is reached, enabling the loading of additional data from the backend.
Additional context
If there is an existing way to achieve this with the current components that I may have overlooked, I would appreciate guidance on that as well.

Hey, the property already exists. It's true that I haven't tested it in a long time, but it should be present and effective for your need 🤔

thanks for the answer, actually this is available from the component level, it's just not in the documentation


Android Build Error

Hello.
When project build, the code change in BuildConfig.java

you're not supposed to touch this file, it's autogenerated.


Add token attribute to HfApi

Fix https://github.com/huggingface/huggingface_hub/issues/1104 and https://github.com/huggingface/huggingface_hub/issues/796.
TODOs:

[x] implement attribute
[x] adapt test suite :tada:
[ ] documentation

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


A couple of questions and feedback

I have tried to set this up following your self-hosting docker instructions, and have come across some issues and have a couple of questions and feedback. I'm opening an issue about them, since I could not find any information about these in the documentation or in other issues, so could be good to get it documented here.

In the generated management.json file, this row exists: "Secret": "secret". I tried to figure out what that does, and maybe it is not used at all, but it gives the impression of a value that should be changed or else insecure, right?
docker-compose file uses host network for coturn container. That is usually bad practice. Should it not be possible to avoid that and rely on docker network where you just expose needed services to the host instead of using the host network layer?
Setting up OIDC provider usually requires both client id and secret together with the discovery endpoint. But I can't find anywhere to add the secret?
Is there any documentation how to run this behind a regular nginx reverse proxy? I'm not a fan of having docker-compose files that "includes everything", since that will mess up other web services running on the same host. I think most people that self-host run some kind of reverse proxy in front of their docker stuff, so some documentation or alternative docker-compose file for those cases would be awesome.
After following the guide, I ended up with this error from docker-compose up, which indicates some permission issues:

ERROR: for infrastructure_files_coturn_1  Cannot start service coturn: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: errCreating infrastructure_files_management_1 ... done

ERROR: for coturn  Cannot start service coturn: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: open /proc/sys/kernel/domainname: permission denied: unknown
ERROR: Encountered errors while bringing up the project.

Since you support OIDC standard, I guess this would work with any such provider, right? Documentation seems to indicate that it does not. Also, callback url is hard to find any information about which needs to be provided when configuring the OIDC on the provider side.

I think this project is really cool and hope it gets good traction, so the above points are meant in good faith in hope to improve some current pain points.
Thanks!

Hello @tvarsis, thanks for opening this issue and giving us feedback. It is true that many things are lacking documentation, we are continuously improving them, and feedback like yours always help.
I will try to address your points below:

We have two modes for configuring Turn credentials and checking now; none have been documented yet. The first case is the Username and Password; these have a direct map to the credentials we generate and update the Coturn config file when you run configure.sh. We also support time-based credentials, which with a shared key between Coturn and the secret you set here, it will be generated and rotated based on the CredentialsTTL you set. This second mode is global, and all Turn servers you configured must share the same secret. See use-auth-secret and static-auth-secret descriptions in the template config file for more info.

That is correct, and the main reason for us to use the host network here is that Coturn can potentially listen to thousands of ports(defaults to ~/16K). These ports are allocated based on need, and we can't limit this too low to avoid connection issues.
One can map the ports and ranges from listening-por, min-port, and max-port in your turnserver.conf, but if you go with defaults port ranges, that might take up to 60 minutes in a 2 cores 7GB VM.

Our system is set to use PKCE flow, which doesn't require a secret for most IDP providers. Unfortunately, Google's OAUTH2 clients aren't supported as they need a fake secret.

another point needing documentation, I am working with another user on that now in the issue #536 but we will have other options on our getting started with nginx, traefik, and caddy.

Can you check if the path /proc/sys/kernel/domainname exists (might need sudo), and can you test running Coturn without the domainname key in the docker-compose.yml?

Regarding the callback urls, you can use 2 environment variables to change them, see the example here. We are using a generic OIDC library which covers many IDP providers that support OIDC with PKCE flow. Some providers we know that doesn't work:

Google oauth2 (requires a secret)
Gitlab (incompatible access token)

Let us know which provider you are using, and we can have a look at which settings might be required on our side. If they are simple enough, we might be able to include a fix in the next releases.

Wow, thank you @mlsmaycon for the detailed answers! I will answer on the ones where you had questions and you explained the other things well already.

So if I would like to map up the port ranges in the docker-compose file, do you know how many ports should be available per connected client? Is it 1:1 value here?

That is a nice thread and I will follow it and see if I can get it working behind nginx. Thanks!

Yes, that file exists but I'm running rootless docker so I think that gives that error. I removed the line from docker-compose file as you suggested and that fixed the error. But would that lead to other issues?

I played around a lot more with this and can't get it to fully work. I'm trying to set it up with Azure AD OIDC but I have not been able to get it fully working. I got to the point where I can successfully login after removing "api" from scopes since that does not exists as default in Azure and gives error. But when I then login to netbird it gives 500 errors with empty error message for all endpoints from API and I only see 3 menu options instead of all of them. I tried to create custom API scope in Azure as well for that app, but couldn't get it to work. And not sure what the api scope is used for and if it is actually needed, and do you know if anyone has got it working with Azure AD? I think Azure AD is pretty flexible when configuring the OIDC applications, so it is probably just me who does something wrong here.

Thanks!

@mlsmaycon I tested a lot of more things and got coturn to work without host network by setting these props in turnserver.conf file.
min-port=49160
max-port=49200
Also commented out the "domain" part from coturn section in docker-compose file as mentioned earlier, and all seems to be working fine now. I guess limiting the ports as I did might give issues with a larger number of clients, but for my use case I think it should be fine.
Just documenting that here if others search for the same thing.
I tested to set it up with Auth0 and then I got everything running correctly, but I could not get it working with Azure AD. Do you have any documentation around how to get it running with Azure AD, since that is what I use for my other apps? It feels like it is the "api" scope that is missing since I can see that being part of the AUD array in the token from Auth0 where in Azure token i just points to an app id if I try to add i manually, or I add it in the wrong place (tried a lot of different ways).
Thanks!

Hi @tvarsis, thanks for getting back and testing the settings.
You are correct; limiting the turn port might be an issue if you need it to connect more peers. Most of the time, peers on a non-restrict NAT can connect without it.
Azure AD has some caveats for PKCE that I have to document and publish. I plan to do that this week as it is a topic that interests more users.

Azure AD has some caveats for PKCE that I have to document and publish. I plan to do that this week as it is a topic that interests more users.

Hello, I'm trying to use Azure app registration as the OpenID provider.  Anything you can provide to help set this up?
Thanks!

I'm very close to getting this working with what I found on your slack discussion.  Looking forward to complete steps.

@tvarsis @cirrusflyer in case you missed, we've added Azure integration here: https://docs.netbird.io/selfhosted/identity-providers#azure-ad


Add special_holidays_observed support

Proposed change

Add special_holidays_observed support (similar to special_holidays, but only works when self.observed == True). Relevant holidays in Albania, Bahamas, Cameroon, Saudi Arbia, Singapore, South Africa refactored. In Azerbaijan, case is a bit more complicated.
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[x] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've added references to all holidays information sources used in this PR
[x] The code style looks good: make pre-commit command generates no changes
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 14 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.978%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10067

Relevant Lines:
10067

💛  - Coveralls


[qcheck-stm] Incomplete computation warning

There seems to be a problem with printing of return values:
$ cat > incomplete_comp.mli << EOF
> type 'a t
> (*@ model contents : 'a list *)
>
> val make : unit -> 'a t
> (*@ t = make ()
>    ensures t.contents = [] *)
>
> val size : 'a t -> int
> (*@ s = size t
>   ensures s = List.length t.contents *)
> EOF
$ cat > incomplete_comp_config.ml << EOF
> open Incomplete_comp
> let init_sut = make ()
> type sut = int t
> EOF
$ ortac qcheck-stm incomplete_comp.mli incomplete_comp_config.ml > /dev/null
File "incomplete_comp.mli", line 8, characters 0-81:
 8 | val size : 'a t -> int
 9 | (*@ s = size t
10 |     ensures s = List.length t.contents *)
Warning: Incomplete computation of the returned value in the specification of size. Failure message won't be able to display the expected returned value.

Thanks!
I believe the problem comes from here
Gospel sometimes add an fs_apply symbol in the AST that is not handle here.


cameras in stealth

radius is in yellow (compared to the red that the guards are in)
when player steps in radius, "!" appears above camera and bar begins filling up
as soon as player steps inside, nearest guard is alerted and starts to go to the camera
so player has to run
meanwhile this wholetime, the bar is filling up (while the player is still in the field of view of the camera). if it fills up completely then the player is exposed and loses

Resolved in b71d9ca0c5d999e233a2f5aa5b974366a90dde87


Where is the documentation about  kong 1.0 grpc ?

Where is the documentation about  kong 1.0 grpc

the same question.

Kong 1.0 is using openresty <IP_ADDRESS> Source 1, Source 2 implying Nginx 1.13.6 is being used. But grpc support was introduced in Nginx 1.13.10.
Unless I'm missing something...

See here for answer:
https://discuss.konghq.com/t/kong-1-0-is-now-generally-available-1-0-0-released/2496/7
As far as L7 routing there are no plugins or support yet for gRPC with Kong.


Failed to execute example add-vertex-by-query

When I try to execute this example I am getting this error:

json: cannot unmarshal string into Go struct field<EMAIL_ADDRESS>of type model.ID}

The json generated is this:
{
    "@type": "g:List",
    "@value": [
        {
            "@type": "g:Vertex",
            "@value": {
                "id": "78b774f6-e7a0-26bf-2fb8-fb25d413aea5",
                "label": "person",
                "properties": {
                    "name": [
                        {
                            "@type": "g:VertexProperty",
                            "@value": {
                                "id": {
                                    "@type": "g:Int32",
                                    "@value":<PHONE_NUMBER>
                                },
                                "label": "name",
                                "value": "damien"
                            }
                        }
                    ]
                }
            }
        }
    ]
}

Looking at the code the VertexValue struct has an ID that does not support String but instead a struct

type ID struct {
Type  string `json:"@type"`
	Value int64  `jjson:"@value"`
}

That's why the error, not able to convert the ID: "78b774f6-e7a0-26bf-2fb8-fb25d413aea5" to the mentioned struct.
I am using version grammes v1.1.1

What database are you using?
What are the steps used to recreate this?

I am using AWS Neptune. Just notice one issue closed, that reports the same error.
Closing this one


[Enhancement] i  would like to suggest something  about green screen

I would like to suggest an idea, give the possibility to put a full green screen except for the focus of a champion
so you can follow your champion with everything in green around and  follow his movement when you click on him

i'm for it too


Onboarding - Feature Validators with lowest number of times reported offline

Since our UI is targeted at nominators I think it'd be important to really hand hold them through this stage. the alternative right now would be for them to look through the telemetry and maybe try to contact known validators and make a judgement call but that's very nerve wracking to do for non-power users.

Agree - as a nominator atm, it's hard to make an informed decision.
Some additional datapoints for consideration:

Uptime
Validator location
Voting stake
Validator payment preference
Slashing reason
Bond duration (remaining)
Previous rewards collected

Nice to have (but requires a lot more work):

Validator alias (name)


Numbering of ISOColor's by Haddock.

The rendered documentation starts number from 1 as we can see here. Perhaps it is worth to add the real value (for example between brackets).
https://github.com/jtdaugherty/vty/blob/fa74b0ae1ca2883e9c4fbfe55abc9253dc7b9841/src/Graphics/Vty/Attributes/Color.hs#L61-L75

That makes sense to me, thanks for spotting that!

That makes sense to me, thanks for spotting that!

I also created an issue in the Haddock repository (https://github.com/haskell/haddock/issues/1406), and apparently this will be fixed by haddock itself.

Oh, great!

This is now fixed and will go out in an upcoming release. Thanks!


alternative model for xgboost

replace xgboost.XGBRegressor by sklearn.ensemble.GradientBoostingRegressor when xgboost is not an feasible option (for Windows users)
Performance is comparable.

Updated the PR with two more changes:

move the importance and construction of ensemble boosting models to initial set up, and add instructions.
move the importance of geopandas to initial set up, and add instructions.


Added babyAndkids page

Fixes #(10)
Describe the changes you've made
I have added the babyAndkids page.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
Yes, I am not able to set the correct padding and margin in the footer section.
Preview of home page -

Preview of babyAndkids page -

Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[X] I have mentioned related issue number in PR description.
[ X] I have added screenshots and related demo links of my changes..
[ X] The title of my pull request is a short description of the requested changes.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

Share website link.
In screenshot in doesn't look proper.

Hey, I have made the changes. Can you check it?
The footer looks okay from my side.

Share a link for review.

Share a link for review.

https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

Navbar is still wrong.
Fix it,

Navbar is still wrong.
Fix it,

You mean the logo right ? What about the footer , is it correct?
I have updated this page in my own repository and shared the link, so that's why the logo is not appearing.

Yes logo and search bar button.
And why only the baby page is working in your link?

Yes logo and search bar button.
And why only the baby page is working in your link?

Because I have uploaded only the baby page in my own repository and shared the deployed site. That's why other things are not working.

Previews of the website, when I view it from the local repo -

Compare your page with other pages.
The search button is larger on your page.

My cart link is also not present.

The first half is of the baby page and the other half is of home page,

@satyampgt4 review this PR and help in resolving the issue.

Okay, I will make the changes in my own repo and show it to you.

I have added the changes in my repo.
https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

I have added the changes in my repo.
https://baba-yaga-1.github.io/DevIncept/babyAndkids.html

Search button!!!

I am facing the same issue again, the search button appears to look this way when I view it from the local repo. Even I have copied the same css code and same html code for the navbar.

I suggest close this PR.
Fetch upstream. Clone the project again. Do necessary changes, Then push the code and make PR.


chore(master): release 0.19.0

:robot: I have created a release beep boop
0.19.0 (2023-02-23)
Features

upgrade to bee-dashboard v0.23.0 (#319) (32fd306)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-desktop/releases/tag/untagged-ce2b2ad0a288201599fc :sunflower:


Support repositories prefixed by datasets/ and spaces/ on Hugging Face

See https://github.com/tiged/tiged/issues/59#issuecomment-1276668320

This fix breaks the support for repos on GitHub, like https://github.com/datasets.
Possibly we need to add more custom code for Hugging Face, not sure if it's worth it or if it's better to remove support for it instead.
cc @julien-c what do you think?


protobuf.bzl outdated making build with TF_SYSTEM_LIBS=com_google_protobuf fail

Describe the current behavior
When using TF_SYSTEM_LIBS=com_google_protobuf to configure TensorFlow 2.1 the build fails with
ERROR: /dev/shm/s3248973-EasyBuild/TensorFlow/2.1.0/foss-2019b-Python-3.7.4/TensorFlow/tensorflow-2.1.0/tensorflow/core/profiler/BUILD:51:1: in proto_gen rule //tensorflow/core/profiler:profiler_service_proto_py_genproto:
Traceback (most recent call last):
        File "/dev/shm/s3248973-EasyBuild/TensorFlow/2.1.0/foss-2019b-Python-3.7.4/TensorFlow/tensorflow-2.1.0/tensorflow/core/profiler/BUILD", line 51
                proto_gen(name = 'profiler_service_proto_py_genproto')
        File "/tmp/easybuild-tmp/eb-NQjKjm/tmp8LJdGE-bazel-build/external/com_google_protobuf/protobuf.bzl", line 110, in _proto_gen_impl
                ctx.actions.run(inputs = inputs, outputs = ctx.out..., <4 more arguments>)
Found tool(s) 'bazel-out/k8-opt/bin/external/grpc/grpc_python_plugin' in inputs. A tool is an input with executable=True set. All tools should be passed using the 'tools' argument instead of 'inputs' in order to make their runfiles availa
ble to the action. This safety check will not be performed once the action is modified to take a 'tools' argument. To temporarily disable this check, set --incompatible_no_support_tools_in_action_inputs=false.

Reason is seemingly a very outdated protobuf.bzl which is used with system_libs. It might be enough to update it from the current protobuf repo. Maybe even download that single file only when using system libs

@Flamefire
please share simple stand alone code before which this error was encountered

Sure:

Compile and install protobuf into /usr (or install system package where available)
TF_SYSTEM_LIBS=com_google_protobuf ./configure
bazel build //tensorflow/tools/pip_package:build_pip_package

@Flamefire
can you please let us know what OS are you facing this issue in

Linux Mint 19.1, but this is a Bazel (code) issue, not dependent on the system. The error is

Found tool(s) 'bazel-out/k8-opt/bin/external/grpc/grpc_python_plugin' in inputs.

The code mentioned is:
https://github.com/tensorflow/tensorflow/blob/6609461732729e9e60567b13d5345bc19fead5d1/third_party/systemlibs/protobuf.bzl#L112-L119
No mention of a "tools" parameter, only "inputs". Upstream code has "tools": https://github.com/protocolbuffers/protobuf/blob/dec4939439d9ca2adf2bb14edccf876c2587faf2/protobuf.bzl#L141-L149
Hence my suggestion to update it in the initial post.

This seems to be fixed in 2.3.0 by https://github.com/tensorflow/tensorflow/commit/9cee90ac957f2575da2415242c5c127c0dd61430


Metatype 'int' not recognized in Compiler Specification after Ghidra version upgrade

Describe the bug
The following pentry specification:
<pentry minsize="1" maxsize="8" metatype="int">

Works in Ghidra 10, but results in an error in Ghidra 11.0.3.
The error is as follows:
Open failed: ghidra.program.model.lang.CompilerSpecNotFoundException: Exception reading [NAME]/default(file.cspec:123): Unknown type class: int

To Reproduce
Steps to reproduce the behavior:

Edit a cspec file to include the offending attribute in a pentry node
Open a file in Ghidra 11.0.3 using the modified cspec

Expected behavior
The cspec is parsed and the file is loaded for analysis.
Screenshots
N/A
Attachments
N/A
Environment (please complete the following information):

OS: Debian Linux 11
Java Version: 17
Ghidra Version: 11.0.3
Ghidra Origin: GitHub release

Additional context
I looked at the documentation of the latest release (I uploaded the generated docs here ) and confirmed that the metatype attribute of pentry should accept "int" as a value:

metatype 		(Optional) Restriction on datatype: unknown, float, int, uint, or ptr

Yeah, doc is wrong (hasn't been updated since forever).  "int" type does not exist.
The code that parsed that value was looser, and used to ignore unknown values, but was changed 5/2023 in commit 191371675ae5906093f501461138e364f732487a.

This clarifies the behavior, thank you!
I suggest to keep this issue open until the documentation is updated (I'll try to open PR, but the linked commit is non-trivial so won't promise anything).


Import Debezium BOM once it is available

Blocked by https://issues.redhat.com/browse/DBZ-2145

There is a PR https://github.com/debezium/debezium/pull/2223 we should review & try.

Debezium BOM is available with newer Debezium versions https://repo1.maven.org/maven2/io/debezium/debezium-bom/


Install Script Fails to Download?

Operating system and version:
Ubuntu 20.04 LTS
I'm trying to install NVM on a new system.  I can use wget to download images ... etc. but when I try to run the NVM script this happens:
ole@ole-ThinkPad-T470:~/im$ wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
=> Downloading nvm as script to '/home/ole/.nvm'
Failed to download 'https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/nvm.sh'

Failed to download 'https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/bash_completion'
Failed to download 'https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/nvm-exec'
=> nvm source string already in /home/ole/.bashrc
=> bash_completion source string already in /home/ole/.bashrc
main: line 433: /home/ole/.nvm/nvm.sh: No such file or directory
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

Any ideas?
If I wget the install script without piping through bash it works fine:
ole@ole-ThinkPad-T470:~/im$ wget https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh
--2021-05-25 12:05:26--  https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 14926 (15K) [text/plain]
Saving to: ‘install.sh’

install.sh            100%[=======================>]  14.58K  --.-KB/s    in 0.001s

2021-05-25 12:05:26 (28.4 MB/s) - ‘install.sh’ saved [14926/14926]

The issue isn't downloading the install script, it's failing to download the things the install script needs. If you bash install.sh I'd expect you to see the same errors.
Why those errors occur, though, I have no idea, since they're from the same site.

Yeah it's pretty weird.  For example if I run the install script I get this:
ole@ole-ThinkPad-T470:~/Temp/nv$ wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
=> Downloading nvm as script to '/home/ole/.nvm'
Failed to download 'https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/nvm-exec'
Failed to download 'https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/nvm.sh'

=> nvm source string already in /home/ole/.bashrc
Failed to download 'https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/bash_completion'
=> bash_completion source string already in /home/ole/.bashrc
main: line 433: /home/ole/.nvm/nvm.sh: No such file or directory
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"  # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"  # This loads nvm bash_completion

And then test the downloading of one of the install scripts:
ole@ole-ThinkPad-T470:~/Temp/nv$ wget https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/nvm-exec
--2021-05-25 18:39:08--  https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/nvm-exec
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 344 [text/plain]
Saving to: ‘nvm-exec.1’

nvm-exec.1                       100%[========================================================>]     344  --.-KB/s    in 0s

2021-05-25 18:39:08 (4.25 MB/s) - ‘nvm-exec.1’ saved [344/344]

ole@ole-ThinkPad-T470:~/Temp/nv$ ls
nvm-exec

It does work ... Thoughts?

Is there a chance you have and alias of proxy settings or something, that would make your command-line wget different from the one the script runs? What does type wget print out?

type wget prints out:
/usr/bin/wget

Do you have curl installed? curl will always be preferred over wget, if available. If so, what happens if you curl the nvm_exec file instead of wgetting it?
Do you perhaps have curl installed via snap?

I also have curl installed.  I tried both.  I get the same result ...

Meaning, both curl and wget work standalone, but not inside the install script?
What's your current shell?

Meaning, both curl and wget work standalone, but not inside the install script?

Yes.
ole@ole-ThinkPad-T470:~/Temp/nv$ echo $0
bash

I'm very confused as to what's going on here.
If you could download the install script, and edit it locally, then cat install.sh | bash might help us debug.
Specifically, add some echos inside nvm_download to be sure precisely what command it's running, and then see if those exact same commands on your shell still work.

I'm very confused as to what's going on here.

Yes echo that! :)
I'll see if I can debug per your suggestions.

I could reproduce this bug by installing the snap version curl on my VM Ubuntu. Looks related to #2504.

Ooooh - That must be what it is ... I have never had this problem on earlier systems and I just put ubuntu 20.04 on this one.

OK.  Good Observation @j0n4t .  Here's what I did to get it to work:
sudo snap remove curl
sudo apt install curl
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash
nvm install node

And it works!  Thanks Guys!!  You ROCK!!

In that case, closing as a duplicate of #2504.


fix: resolve #15 avoid throw error if branch dose not exists

as title

See the issue on why I'm closing this PR.

See the issue on why I'm closing this PR.


How to handle unparseable/incorrect code

Moving this out from #145 so it can be merged. I'll make it 1 for now for simplicity of implementation
What should the program/plugin do when encountering the following code:
for _ in range(1, 10, 0):
  ...

Note that this is only when all parameters are literals, so there should literally be no way this is correct - other than when somebody is intentionally writing incorrect code in a test.
None of the linters of ours catches it (could be added to bugbear I suppose, but it doesn't seem worth given how rare it is), but we happen to be able to catch it as a side-effect of checking whether loops are guaranteed to run.
Options:

Treat it as not guaranteed to iterate

Not Our Business:tm: to warn about it. Program will crash at runtime as expected.
I've been bitten in the past when developing this when I've wrapped stuff in except Exception and mistyped code inside the try: - so I somewhat dislike it for that reason. But that should not really be a thing here, and I rewrote it to have minimal code within the try.

Add error code that can be used in the future for various clearly incorrect code that's checked as a side effect of the plugin.

Needs an extra error code, and might actually need some added infrastructure since it's bound to a helper - not a visitor/error class.

Print to stdout

Should be rare enough that sidestepping the proper error infra and just printing to stdout should be fine. Will warrant a separate test, but that's easy to write. Downside is that you can't ignore it, nor will affect return status of the check.

Example implementation of 3:
try:
    evaluated_range = range(*values)
except Exception:
    parameters = ", ".join(map(str, values))
    print(f'Malformed range expression: `range({parameters})` crashes.')
    return False
return len(evaluated_range) > 0

I'm not coming up with any other similar cases in other helpers that this could also apply to, but I could imagine similar cases coming up again. But it's really minor and this case should be exceedingly rare, only real reason would be if somebody is messing up the order of the parameters in a 2/3-parameter range expression.

raise RuntimeError(explanation) or print-and-ignore both seem fine to me.


Warning when using via ADO pipeline for older node version

When using the task via ADO pipeline it gives a warning about using node version 6
Also show a way to fix it
##[warning]This task uses Node 6 execution handler, which will be deprecated soon. If you are the developer of the task - please consider the migration guideline to Node 10 handler - https://aka.ms/migrateTaskNode10. If you are the user - feel free to reach out to the owners of this task to proceed on migration.

Hey, the warning is still there, is there any plan to update it? @StefanKert

Came here for this.


systemvm: Update novnc

Description
Updating noVNC
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

FullScreen mode

Paste into console

Additional keys

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1972

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1973

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1974

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1975

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-1976

third time's a charm
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-1979

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos7 ✖centos8 ✔debian. JID-1995

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2002

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2747)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 76448 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4323-t2747-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 79 look OK, 6 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80
Failure
429.33
test_internal_lb.py

test_03_vpc_internallb_haproxy_stats_on_all_interfaces
Error
584.27
test_internal_lb.py

test_04_rvpc_internallb_haproxy_stats_on_all_interfaces
Error
477.06
test_internal_lb.py

test_01_add_delete_kubernetes_supported_version
Error
1809.44
test_kubernetes_supported_versions.py

test_02_vpc_privategw_static_routes
Failure
419.58
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
395.43
test_privategw_acl.py

test_router_dhcphosts
Failure
188.92
test_router_dhcphosts.py

ContextSuite context=TestRouterDHCPHosts>:teardown
Error
202.83
test_router_dhcphosts.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
562.03
test_vpc_redundant.py

test_hostha_kvm_host_fencing
Error
9.32
test_hostha_kvm.py

@davidjumani can you check the issue of missing icons?

@rhtyd there are couple of more issues (Chrome incognito, clipboard characters). Already discussed with @davidjumani

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian.  I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2055

Manually testing and verifying against VMware env

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2059

Tested against VMware, LGTM
Screenshot looks like this:

Button/clipboard options work as expected:


Stand alone button.

Hi,
I am using the stand alone button and only one is working per page.
Both of them open the iframe except when you select an image they both open in the first button.

Thanks in advance.

Initialize each button by a unique id. That should do the trick.

Hi @eqxDev. Was this issue resolved?

Please take a look at src/views/demo.blade.php.


Error when using Utf8::strlen() function.

I'm using php 5.5.19.
I don't have mb_string, iconv or intl extensions enabled.
I get the following error when using Utf8::strlen(..):
Fatal error:  Call to undefined function Patchwork\grapheme_strlen() in ....\vendor\patchwork\utf8\src\Patchwork\Utf8.php on line 234

According to the documentation, there is a fallback implementation, but when trying Utf8::strlen() no fallback implementation is active.
Am I doing something wrong, or does Utf8::strlen() require intl extension to be enabled?
By what other means can I get the length of a utf8 string?
Thanks in advance.

Okay, my mistake.
I should have called the following at the top of my test file:
\Patchwork\Utf8\Bootup::initAll(); // Enables the portablity layer and configures PHP for UTF-8
\Patchwork\Utf8\Bootup::filterRequestUri(); // Redirects to an UTF-8 encoded URL if it's not already the case
\Patchwork\Utf8\Bootup::filterRequestInputs(); // Normalizes HTTP inputs to UTF-8 NFC


Feature - return data matched.

byteseek currently only says at what position a match was found in a stream or a file, it doesn't return the data.
Add a feature to return data at positions in a WindowReader (byte[], char[]?) including using longs, search and match results as parameters.

The upcoming byteseek 3 (currently in the v2.1 branch) already has a feature to read any data out of a window reader into a supplied byte array.


test-branch/execute-job/quoted-authorization/fe1c4117-c01e-4499-a8b9-86accf258590

PR for testing d1411a0509bab2fbc0f0f3f64e9af786ac85c207

/canonical/self-hosted-runners/run-workflows d1411a0509bab2fbc0f0f3f64e9af786ac85c207


Removal of variable in August resulted in invalid PowerShell code

From this Stack Overflow question.
The current version of has several instances of:
= $Yes

Or:
= $No

And one instance of:
= $Revert

https://github.com/Sycnex/Windows10Debloater/blob/1d25c80dda5ecf90e9b2f35ab7fb76cdbd3aa8a0/Windows10Debloater.ps1#L683
It appears to trace back to this change in August when the $PublishSettings variable was removed.
Appears on lines 685, 688, 696, 699, 712, 721, 729, 735, 738, 751, and 760. There may be others.

I removed all of the unused variables listed in your issue.


Add code documentation

Added typedoc and tsdocs to code

Yeah, it would. I can make so it does not


Remove version: SAGAUserGroupAssociation.SAGAGIS version 8.2.2

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Package still available.;


Install4J installer support

Description of the new feature/enhancement
Support for Install4J installer, so that we can use apps like BiglyBT
https://www.ej-technologies.com/products/install4j/overview.html
Proposed technical implementation details (optional)
Id: biglysoftware.biglybt
Version: 6.9.1
Name: BiglyBT
Publisher: BiglySoftware
License: GNU General Public License v2.0
LicenseUrl: https://github.com/BiglySoftware/BiglyBT/blob/master/LICENSE
AppMoniker: biglybt
Tags: BitTorrent client
Description:
  Feature-filled Bittorrent client based on the Azureus open source project
Homepage: https://www.biglybt.com/
InstallerType: Install4J
Installers:
  - Arch: x64
    Url: https://github.com/BiglySoftware/BiglyBT/releases/download/v<IP_ADDRESS>/Github_BiglyBT_Installer64.exe
    Sha256: 60f2c8cb74deaded9d31656c353163b574b9a7114e1cdea9143a454eb7b1dbc3

Install4J uses -q for silent installation.

You don’t need any special support in winget itself for this use-case. You can simply specify the install type as EXE and pass the -q flag in the Switches/Silent field in the YAML manifest.

We can look at metadata associated with Install4J to see if there are attributes the winget.exe client can take advantage of.


Added in Dummy Data and Explore page

Added in a way to generate images in the explore and added in Dummy data scripts

PLEASE LET US ALL MEET BEFORE APPROVE OF THIS PR


Suggestion: allow to skip origin checks

We are planning to use this service i a dynamic environment where we can not foresee the origin URLs upfront. Would it be possible to allow skipping the origin checks altogether, if, for example, an environment variable is set? Obviously the service would then be publicly available, but in our case, we are fine with this or can handle it through origin checks in the network infrastructure.
I suggest something to the extend of replacing https://github.com/NFDI4Chem/nmrium-react-wrapper/blob/1f1530cad7886b9b1d45f2650629dd70f899ef42/src/events/event.ts#L50
with:
const skip_origin_check = "SKIP_ORIGIN_CHECK" in process.env && process.env.SKIP_ORIGIN_CHECK == 1
if (!skip_origin_check && !ALLOWED_ORIGINS.includes(parseOrigin(origin)) ) {
...

Hm, wait, this seems to be client side code. Of course process.env is not available then. So then, the ALLOWED_ORIGIN check is probably not for security anyway?
Can we get a build flag to disable it or maybe load the ALLOWED_ORIGINS list from a json file that I can simply clear before building?
How does this look to you:
// src/allowed_origins.json
[
    "https://nmrxiv.org",
    "http://nmrxiv.org",
    "http://localhost",
    "http://localhost:3000",
    "http://<IP_ADDRESS>:",
    "http://<IP_ADDRESS>:3000",
    "http://test.nmrxiv.org",
    "http://<IP_ADDRESS>",
    "http://<IP_ADDRESS>:3000",
    "https://nodejsdev.nmrxiv.org"
]

// in your events.ts
import ALLOWED_ORIGINS from '../allowed_origins.json';
...
const skipOriginCheck = ALLOWED_ORIGINS.length == 0 || ALLOWED_ORIGINS.includes('*');
if (!ALLOWED_ORIGINS.includes(parseOrigin(origin))) {
    throw new Error(`Invalid Origin ${origin}`);
}
...

@ptrxyz
Thanks for your suggestions


replica endpoint address broken hyperlink?

Describe the bug
broken hyperlink
Screenshots

Service Fabric version:  9.1.1653.9590
OS(for browser not SF): MS Edge
Browser/ Browser version [e.g. chrome, safari] Version 112.0.1722.68 (Official build) (64-bit)

Additional context
Add any other context about the problem here.

@skyiky this should be fixed with 9.1 cu5


Use Dir.foreach instead of Dir.glob to fix a performance regression

When a queue has a large backlog, Dir.glob performs much more poorly than Dir.foreach.  I had originally switched to glob to simplify the code, but the performance regression is way more than its worth.  See below for a directory with 200k jobs:
2.3.0 :015 > Benchmark.measure { index = 0; Dir.glob('/mnt/chore_fs_queue/development_web_requests/new/*.job') {|f| index += 1; break if index >= 1000 } }
 => #<Benchmark::Tms:0x0000000214cb50 @label="", @real=0.5653504389993032, @cstime=0.0, @cutime=0.0, @stime=0.2999999999999998, @utime=0.26000000000000023, @total=0.56>
2.3.0 :016 > Benchmark.measure { index = 0; Dir.foreach('/mnt/chore_fs_queue/development_web_requests/new/') {|f| index += 1; break if index >= 1000 } }
 => #<Benchmark::Tms:0x000000031ef318 @label="", @real=0.0012892550003016368, @cstime=0.0, @cutime=0.0, @stime=0.0, @utime=0.0, @total=0.0>

As you can see, Dir.foreach can be over 500x faster.  This is pretty critical so that the majority of your time isn't spent just listing files off the filesystem.
/to @gregorysabatino @dankleiman @geoffreyclark

You'll note that this is basically a revert of fix/fs_performance_regression


Added Test Unit Bundle

Now we need some tests ;)

@rivera-ernesto So can this be merged as a starting point for TDD?

I would like to have some actual tests, just to make sure it doesn't sit idle (where a pull request to remove it would also make sense!).

@colemancda I appreciate you working on this unit tests setup, but I'm not sure I follow the multitude of changes made here. Could you please detail them? Or take a look at my simpler approach (which I'm not yet sure it works): #474

PR replaced by #474. Thanks for the contribution, @colemancda


Investigate unification of secrets handling

the certs and keys for the idp / sp were previously brought in via secrets in the docker compose file
the auth service currently expects some of these certs / keys to be set directly as environment variables
investigate --> do we need to make the keys available under docker compose secrets as they were before?

1.0.0

@jaredgalanis to review and see if part of this is complete, and update ticket accordingly


feat(dialog): Add validation functionality for cancel event

Copies the validation for accept button clicks and applies it to cancel. Useful to prevent the
dialog from closing when using the dialog for more complex actions.

looks good. will merge next release


call propertyHiddenChanged synchronously

Property might no longer exist when event is triggered
fixes #1657

I'm not sure why a queued connection was used here. But instead of changing the connection type (which might have other side effects), what about changing the argument from Property* to QPointer<Property>?
This way, we would notice any invalidation of the held Property and you could easily check this in PropertyTreeWidget::propertyHiddenChanged.

I'll test QPointer as well, didn't have it in my mind.

I didn't observe any difference between the QueuedConnection variant with QPointer and the synchronous version with the raw pointer.

@simonschmeisser, could you please revert the 2nd commit? Thanks.


Fix Cocoapods version injection

Updates Project.injectedVersion to check if 'version' is defined before using it.

Surely it should always have a version?


Update zio, zio-test, zio-test-sbt to 2.0.10

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 1.0.18 to 2.0.10.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #233.


LLM Error: ['Stop'] not used

Across multiple models (for example WizardLM/WizardCoder-1B-V1.0), both inference, using the model name and with my own depoyment I get the error:
[LLM] The following 'model_kwargs' are not used by the model: ['stop'] (note typos in the generate argument will also show up in this list)
I can't work out what to do to fix this....

Hello @gdnaesver, I've recently changed the stop token parameter from stop_token: "a string" to stop: ["a", "list", "of", "strings"] and that may be it.
If you feel like fixing it feel free to submit a PR or I'll get to it at some later point.

Here : https://github.com/huggingface/llm.nvim/blob/main/lua/llm/hf.lua#L40

Do you have the full list of models for which you're having an error?
FYI, I've tested WizardLM/WizardCoder-Python-34B-V1.0 and had no issues.

So, transformers and TGI don't have the same API, stop_tokens for transformers & stop for TGI (api inference has workloads with both).
For now I'll just set the default to nil to not send anything, as there is, most of the time, a default EOS token.
I guess we could also infer EOS from the tokenizer file, but that's more something to implement in llm-ls.


Middleware usage with extra arguments

On the optional arguments to an Express.js middleware , probaly a fourth one apart from being an error handling middleware and at ideal many arguments without any Express.js specific limit, I have a logic where it comes useful. It may be achieved by a different way, but anyways. But this is not data passing between middleware, maybe this question should have its own post. I have already suggested some solutions for this, and osme what I was guessed of, however, this can be taken as a design suggestion for bettering the Express.js middleware use pattern. Thanks in advance.
I want to make some api routes permission checked, the middleware I wish to write should look up database for a requesting user for how many reputation points (integer) he/she has. I defined an object to hold privileges and reputation points required as key value pairs. Later, middleware should look up this privileges object to see if the user has greater than or equal reputation points for a corresponding action. I want to pass this corresponding action name which is a key in the privileges object as a different string for each route.
By the way, apparently I also need route based (not Router based) middleware mounting, I am not sure if Express.js supports, but this is another story.
Maybe one can describe and ask this use case as can I parametrize a middleware function with my parameters, not just by incoming req and res objects?
/// Privilege Check middleware
// used per route with corresponding actionName
// signature function (request, response, next, actionNameOneOfKeysInPrevilegesObject::String)
var privilegeCheck = function (req, res, next, actionName) {
	db.one(
		`
			SELECT reputation FROM users WHERE id = $(id)
		`,
		{id: req.user.id} // remember req.user was set by jwt.sign(data) during login or signup with demanded data; here it is {id:, name:, username:,}
	)
		.then(function (data) {
			if(data >= privileges[actionName]) {
				next();
			}
			else {
				res.status(403).json({errorMessage: "You need to have " + privileges.questionUpvote + " reputation to upvote."});
			}
		})
		.catch(function (error) {
			console.error(error);
		})
};

// reputations needed for privileged actions
var privileges =
{
	questionAsk: 5,
	answer: 15,
	acceptAnswer: 0,
	comment: 5,
	questionEdit: 20,
	answerEdit: 20,
	commentsEdit: 0,
	postsUpvote: 30,
	postsDownvote: 30,
	commentsUpvote: 5,
	questionUpvote: 10,
	questionDownvote: 125,
}

I don't think this is a valuable use-case, you should probably be treating req as the application "context" for passing things onward. In what case do you need this? I can't tell from your example where actionName comes from.

No, it simply comes from nowhere from the code, and needs not to. actionName just comes form the neccessity and form my head. I write it there depending on in which route I am using it.
someApprouter.someHTTPMethod('/some-route', someMiddleWare, someRouteHandlerFunction(){...})

You need to provide a larger demonstration of what you're doing because I can't quite understand what you wrote, but I'm pretty confident the code example I shared above would be more useful to you. There's no reason to use middleware to hard-code values that you pass around through requests when you can just write a function.

this is not logic he is not understanding anything he needs a javascript course
function firstMid(req,res,next) {
  var Extra1 = 'WOW'
  //call the next middelware via directly using it as function
  customMidExtraArguments(req,res,next,Extra1)
}

function customMidWithExtraArguments(req,res,next,Extra1){
   Extra1 += '!' // Lets give it a ! to make sure its extra ;)
   finalMidWithExtra(req,res,next,Extra1)
}

function finalMidWithExtra(req,res,next,Extra1) {
  console.log(Extra1)
  res.end(Extra1)
}

this can be closed now i think


Invalid email address

Backtrace
line 969 of [PROJECT_ROOT]/vendor/ruby-2.6.1/lib/ruby/2.6.0/net/smtp.rb: check_response
line 937 of [PROJECT_ROOT]/vendor/ruby-2.6.1/lib/ruby/2.6.0/net/smtp.rb: getok
line 865 of [PROJECT_ROOT]/vendor/ruby-2.6.1/lib/ruby/2.6.0/net/smtp.rb: rcptto

View full backtrace and more info at honeybadger.io

This was caused by an invalid email address. We may have some email address validation already, but it appears it should be more strict.

I resolved this today.


[Attestation] Update attestation to use the new recorder

Packages impacted by this PR
attestation
Issues associated with this PR
#19859
Describe the problem that is addressed by this PR
Migrating attestation to the new recorder
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
N/A
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

Attestation LGTM but it's been a while.


Bug with cmdline and

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Issues

[X] I have checked existing issues and there are no open or closed issues with the same problem.

Neovim Version
NVIM v0.7.0-dev+725-g439336079
Minimal reproducible config
if has('vim_starting')
  set encoding=utf-8
endif
scriptencoding utf-8

if &compatible
  set nocompatible
endif

let s:plug_dir = expand('/tmp/plugged/vim-plug')
if !filereadable(s:plug_dir .. '/plug.vim')
  execute printf('!curl -fLo %s/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim', s:plug_dir)
end

execute 'set runtimepath+=' . s:plug_dir
call plug#begin(s:plug_dir)
Plug 'hrsh7th/nvim-cmp'
Plug 'hrsh7th/cmp-path'
Plug 'hrsh7th/cmp-buffer'
Plug 'hrsh7th/cmp-cmdline'
Plug 'hrsh7th/vim-vsnip'
call plug#end()
PlugInstall | quit

" Setup global configuration. More on configuration below.
lua << EOF
local cmp = require "cmp"
cmp.setup {
  snippet = {
    expand = function(args)
      vim.fn["vsnip#anonymous"](args.body)
    end,
  },

  mapping = {
    ['<CR>'] = cmp.mapping.confirm({ select = true })
  },

  sources = {
    { name = "buffer" },
    { name = "path" },
  },
}

-- cmp.setup.cmdline(':', {
--     completion = {
--         autocomplete = false,
--     },
--     sources = cmp.config.sources({
--         { name = 'path' },
--     }, {
--         { name = 'cmdline' },
--     }),
-- })
EOF

Description
First of all, I am not entirely sure if this is a bug with cmdline or cmp itself. It's related to cmdline, but since the main logic for the most part is in cmp, I figured I open the issue here. If it's cmdline issue, then I can move it.
I have a problem with trying to complete the suggestions with cmdline. They are not working like I would expect them to work after using the built-in menu ever since trying cmdline out.
In this video, you can see when I have cmdline configured. That is the minimal config I pasted above, only with the commented lines not commented out. I commented them out to also show you how it work with the built-in one.
cmdline:
https://user-images.githubusercontent.com/5160701/147834723-c7d393c7-9f31-4f6d-9fb4-9ec9fe92ca51.mov
built-in
https://user-images.githubusercontent.com/5160701/147834765-212339c7-149b-4cab-831c-f173d43c7b88.mov
Here you can see that I start typing and tab to complete. Then I want to confirm the option so I can either tab to get the next options up.
 If I type the entire word it also won't always dissapear since the trailing / is a part of the completion.
Steps to reproduce
Use the minimal config, and try to tab to complete, and then press  to confirm.
Expected behavior
I would want the menu to go away when I press , so that I can then tab to get the next options up to cycle through.
Actual behavior
It actually inserts the characters for
Additional context
No response

Sorry. I can't understand the expected behavior...

Sorry. I can't understand the expected behavior...

Sorry I wasnt't clear enough... I will try to explain better.
The following video is showing when I use the built-in menu. Here you can see my keypresses as well. Notice when I press ^Y which is <C-y>. Then the menu disappears and that keypress is like a confirm. I can then start pressing tab again to see items inside /lib.
https://user-images.githubusercontent.com/5160701/147849346-84331e05-c150-4e34-b38b-f3272086cc2c.mov
The following here is with cmdline enabled.
https://user-images.githubusercontent.com/5160701/147849406-386b5b54-5827-4a61-9295-cd3053869655.mov
Here you can see that it literally inserts ^Y instead of closing the menu and inserting the item so I can press tab again.
So the intended behaviour that I would like from cmdline is to behave in the same way as the built-in menu when pressing <C-y>.

Sorry I wasnt't clear enough... I will try to explain better.
The following video is showing when I use the built-in menu. Here you can see my keypresses as well. Notice when I press ^Y which is <C-y>. Then the menu disappears and that keypress is like a confirm. I can then start pressing tab again to see items inside /lib.
https://user-images.githubusercontent.com/5160701/147849346-84331e05-c150-4e34-b38b-f3272086cc2c.mov
The following here is with cmdline enabled.
https://user-images.githubusercontent.com/5160701/147849406-386b5b54-5827-4a61-9295-cd3053869655.mov
Here you can see that it literally inserts ^Y instead of closing the menu and inserting the item so I can press tab again.
So the intended behaviour that I would like from cmdline is to behave in the same way as the built-in menu when pressing <C-y>.

So I found a workaround for the problem. By using the newly merged api for calling a lua function with keymaps I was able to do this and get the correct behaviour. So I will close this issue as I can live with this workaround
vim.api.nvim_set_keymap('c', '<C-y>', '', {
    callback = function()
        cmp.confirm({ select = false })
    end,
})


Qubino ZMNHJD1 not working

Describe the bug
Two of my 3 Qubino ZMNHJD1 are not working. They are visible on the network but the entities (lights and switches) are reported "Unavailable" in my Home Assistant installation.
Device information
Device working as expected: Node 10 - Qubino ZMNHJD1, firmware version reported 1.1
Devices not working: Node 12 and 13 - Qubino ZMNHJD1, firmware version reported 2.0
Last Known Working Configuration

[x] Previously working device (other platform)

OpenZWave 1.4 (deprecated Home Assistant integration)

Installation information

Z-Wave JS Home Assistant add-on
Z-Wave JS to MQTT Home Assistant add-on (for getting the log files)

To Reproduce
Start network, include devices, after everything is ready, the entities are unavailable in Home Assistant for 2 of the 3 nodes, even after restarting everything and healing network.
Additional context
Could it be related to the differences between firmware 1.1 and 2.0?
The working node is reporting a temperature sensor (value is -999.9 because there is no sensor connected), whereas the two others are not reporting it.
Logfile:
zwavejs2mqtt.log
zwavejs_377.log

I can't speak for the "unavailable", that is something specific to HASS. /cc @marcelveldt
What I can say however is that the nodes 12 and 13 don't respond to most queries, so many of the application values are simply empty (✔= response, ❌= no response):

CC
Node 10
Node 12
Node 13

Multi Channel
✔
✔
✔

Association
not supported
invalid
invalid

Multi Channel Association
✔
✔
✔

Basic
✔
❌
❌

Binary Switch
✔
❌
❌

Binary Sensor
✔
❌
❌

Configuration
✔
❌
❌

Multilevel Switch
✔
❌
❌

Multilevel Sensor
✔
❌
❌

I can't tell why that is, because the commands are the same for all three nodes.

An entity will render as unavailable if Home Assistant if something is wrong:

the node does not have the "ready" state yet
the value is missing

So exactly what @AlCalzone is describing, the values are not there

Hm, IMO you should at least be able to control the thing, even if it has no values.

@AlCalzone I just tried to set [12-38-0-targetValue] Target value from the Control Panel and it works.
The entity became "available" in Home Assistant after I called "Refresh Values" on that node and reloaded the integration.
However, when I switched back from the Z-Wave JS to MQTT add-on to Z-Wave JS, they're again showing as unavailable.

That's a HASS issue, nothing I can do about it.

Thanks for your help @AlCalzone, I'll report on HASS side 👍

Thanks for your help @AlCalzone, I'll report on HASS side 👍

No need, we're already on it ;-)

Nice @marcelveldt! Can you link me to an issue I can keep an eye on?


Change import to delayed job

Import people using an asynchronous/background job. This is required because anymore than ~200 records per CSV file will cause a server timeout on any of the environments - see RACK_TIMEOUT and WEB_TIMEOUT env vars

Looking good :+1:


Make saveBot required in the InstallationService interface

Make saveBot required in the InstallationService interface.
I had to read the source code to understand why token rotation was not working and it was because in the InstallationService that i built, it didn't implement the saveBot which is used in the MultiTeamsAuthorization for token rotation. Hence it shouldn't have a default implementation.
Category (place an x in each of the [ ])

[x] bolt (Bolt for Java)
[ ] bolt-{sub modules} (Bolt for Java - optional modules)
[ ] slack-api-client (Slack API Clients)
[ ] slack-api-model (Slack API Data Models)
[ ] slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
[ ] slack-app-backend (The primitive layer of Bolt for Java)

Requirements
Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. :bow:
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

hi, @Moh-inc! thanks for submitting this! 😄
I took at look at the InstallationService interface and saw that saveBot is supposed to throw an error if not implemented correctly:

"To run this app, your InstallationService must implement this method properly."
Just wanted to verify if you ran into this error when you were missing an implementation of saveBot in your custom InstallationService.

On my end, I'll reach out to a member of my team internally to see if there's any historical context behind saveBot being made default! This question will be updated once we get a clearer answer about whether this is something that should remain the same or not. 🙌

Thank you for getting back to me, I do think it's a little misleading especially when it's needed in oauth token rotation and can only be found when testing out the application rather than be more convenient and have it implemented by default.

Hi @Moh-inc, thank you so much for taking the time to share this feedback and we are sorry for the confusion you've faced when enabling token rotation for your app.
Indeed, having the default implementation for saveBot in the interface can lead to inconsistency and confusion with the requisites of other methods. However, modifying this now could bring breaking changes for a large number of existing apps that don't use token rotations. For this reason, we are unable to consider the improvement in the short term. We may revisit this as necessary when releasing the next major version (the major release won't come in the short term though).
Thanks again for the feedback. We will keep this issue open to hear from other developers for the future.

Thank you for taking it into consideration!


Make network inference speed faster

Hi,
I am a student studying deep learning.
First of all, thank you for your implementing.
I did some experiments by changing the base network from your code.
I trained through my own training dataset, and in my first trial I only change the base network and didn't change loss, global configuration.
Some Nan issues came up, and I modifed the discriminative loss error using clip-by-value.
Training was carried out normally and the tests were carried out when the loss was converged near a certain value.
For VGG model, the results of binary segmentation and instance segmentation were neat and lean.
Some similar results, but when replaced by MobileNet binary segmentation results are looks thick and representation of lane will be combined in vanishing point. In addition, as a result of instance segmentation, the output is also thick and unclear, sometimes leading to the same embedding for different lanes.
Output images are shown as below:
VGG -

MobileNet -

I saw your code and the loss function organized with weight update through heuristic value.
Should I find a suitable weight value for my network model and training dataset ? or should a new loss function be configured for troubleshooting?
Would it be helpful to increase the predictive dimension in instance loss, or adjust the delta distance and variance value?
I would like to know how did you specified the certain values.

@BenBaek If you want to get a more lean and neat binary segmentation result. You may simply test enlarge your input image size:)

@BenBaek If you want to get a more lean and neat binary segmentation result. You may simply test enlarging your input image size:)

Thanks for your reply,
I have already trained both 'VGG' and 'MobileNet' for 256x128 and 512x256 inputs.
VGG with 256x128 input shows more clear results than MobileNet with 512x256 input.
VGG instance loss converges to near 0.2, and MobileNet instance loss converges to near 2.0, so
I suspect that this phenomenon is mired in the local minima problem.
How do you think about this problem?
Should I change some parameter about loss function?

@BenBaek What I mean is that if you train the model with input size [256, 512] you may test it with input size [512, 1024] you may get lean and neat binary segmentation result. As for the loss problem you mentioned above that's mainly caused by the different feature extractor performance by two different base net. I think you need to adjust some params in instance loss function:)

@BenBaek What I mean is that if you train the model with input size [256, 512] you may test it with input size [512, 1024] you may get lean and neat binary segmentation result. As for the loss problem you mentioned above that's mainly caused by the different feature extractor performance by two different base net. I think you need to adjust some params in instance loss function:)

I'll try to experiment and find the proper parameters as you say.
Thanks!

@BenBaek Wish you good luck and welcome to share your result with us if you're willing to:)


Introspection data providers must be OOTB enabled

To inject UMA permissions to introspect response, the following PR introduced "Introspection DataProvider" concept.
https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/1009
In order to use this, the following configuration should be present in identity.xml
      <Introspection>
          <EnableDataProviders>true</EnableDataProviders>
      </Introspection>

This configuration should be OOTB available in the identity.xml rather having someone to manually modify the identity.xml...
Without this, UMA flow breaks when the resource server introspects the RPT.
Ex:
Introspection response without above configuration:
{
  "nbf":<PHONE_NUMBER>,
  "active": true,
  "token_type": "Bearer",
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "client_id": "JfTSiJ24gh8sYHTQVuOl5RoftkAa",
  "username": "oliver.uma.demo"
}

Introspection response with above configuration:
{
  "nbf":<PHONE_NUMBER>,
  "permissions": [
    {
      "resource_scopes": [
        "view"
      ],
      "resource_id": "08e69621-e418-4914-b85f-164e127c20de"
    }
  ],
  "active": true,
  "token_type": "Bearer",
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "client_id": "JfTSiJ24gh8sYHTQVuOl5RoftkAa",
  "username": "oliver.uma.demo"
}

Further, (migration?) docs should mention the impact on both having the configuration and not having the configuration, and the vendor recommendation.

Updated doc:
https://docs.wso2.com/display/IS580/User+Managed+Access+with+WSO2+Identity+Server

This property impacts introspection for bearer tokens issued for any other grant type as this triggers the UMA handler which does a DB call and grabs permissions to be included in the introspection response.
Refer [1].
As UMA is a special use case and the fix for the above mentioned issue incurs some complexity, setting up the respective config to 'false' by default as the flow impacts the common introspection use cases.
[1] https://github.com/wso2/product-is/issues/5150

Created [1] to capture doc impact.
Reducing the severity as there is a configuration to enable the behavior if required
[1] https://github.com/wso2/product-is/issues/5175

Added to the migration doc of IS 5.8.0 (https://docs.wso2.com/display/IS580/Understanding+What+Has+Changed)


Corrected PBEWithMD5AndTripleDES decryption to account for historical bug in JCE salt-inversion routine

The description of PBEWithMD5AndTripleDES in the OpenJDK sources says to invert the first salt half if the two halves are the same. Turns out that the original JCE implementation way back for JDK 1.2 had a bug in the code for inverting that salt half, causing a different result. At least the bug has been consistently carried along through all JRE versions though.
Interestingly, the OpenJDK sources give a hint as to what the cause of the bug might have been:
for (i=0; i<2; i++) {
    byte tmp = salt[i];
    salt[i] = salt[3-i];
    salt[3-1] = tmp;     // <-- typo '1' instead of 'i'
}

This commit fixes the decryption routine to correctly decrypt PBEWithMD5AndTripleDES when such a salt with identical halves was used.

Holy cow, nice detective work.


Release Script should set the Helm Chart Version

Once the version is set, the script should also set the non-nightly version in the Helm chart. It should then also generate the manifests from that (if it is left to the github action, it will make a new commit and it will not be set for the tag that the release script creates. So after the Helm chart version is set, run make generate-manifests)

This is now implemented a long time ago. The create-release-tag.sh updates the version in Cargo.toml and then regenerates the chart with the new version.


Add inheritance diagrams to reference page

Changelog / Overview

Added inheritance diagrams to the reference page as a quick navigation method.

Motivation
These diagrams give a good overview of the library structure and allow for quick navigation.
Explanation for Changes
Have a look at the changed reference page. For each group of modules a single inheritance diagram is added. Some look a bit crowded, but I compressed the diagram as good as I could. This is how the mobjects diagram looks in both color schemes:

The images are embedded SVGs whose color scheme gets changed with js when the user changes it's prefered color scheme (even without page reload). This doesn't increase build time or file size in a significant way.
However, Graphviz is required to build the docs.
Checklist

[x] I have read the Contributing Guidelines
[x] I have written a descriptive PR title (see top of PR template for examples)
[x] I have written a changelog entry for the PR or deem it unnecessary
[ ] My new functions/classes either have a docstring or are private
[ ] My new functions/classes have tests added and (optional) examples in the docs
[x] My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

[ ] The PR title is descriptive enough
[ ] The PR is labeled correctly
[ ] The changelog entry is completed if necessary
[ ] Newly added functions/classes either have a docstring or are private
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

Absolutely amazing!
I haven't looked at the JavaScript in detail, but there might be some problem: locally, my preferred color scheme is dark, but the SVGs still have a light background:

Interesting. What browser are you using, and are there any errors in the console?

Absolutely amazing!
I haven't looked at the JavaScript in detail, but there might be some problem: locally, my preferred color scheme is dark, but the SVGs still have a light background:

~Interesting. What browser are you using, and are there any errors in the console?~
Silly me, I had the same problem. Due to security reasons local svg files embedded as object tag cannot be accessed. You need to serve the docs on a local http server (run python3 -m http.server from the build/html directory)

Chrome 90.0.4430.93, no additional errors in the console.
I am looking at the RTD-generated page.

Chrome 90.0.4430.93, no additional errors in the console.
I am looking at the RTD-generated page.

Oh, ok. In that case I have to look into cross-browser accessibility. I am using Firefox.

I can confirm that it works for me when using Firefox.

Chrome seems not to continue the background under svg images. I added a background color to fix that.


Show error and timed out probes in samples chart

When a probe times out (does not respond before a round ends) or fails to send (due to a local network error) the samples chart shown it as the absence of a value (a blank vertical bar).  For example:

It is desirable to show Awaited (i.e. timed out) and Failed probes as solid vertical lines of different colours to make the distinction clearer.

Yeah I think that would be more intuitive when reading the chart and would make nodes that never responded have a full bar instead of an empty bar which might be better. I think a full bar is better but I guess that's subjective.

I actually did this in an early version of Trippy (red vertical bar for 0), but I had to vendor and modify tui-rs (as it was then) in place.  I'll have to upstream the change to the widget.

WIP:

Feature request: https://github.com/ratatui-org/ratatui/issues/1325
PR to implement it: https://github.com/ratatui-org/ratatui/pull/1326


Can I use my own model?

If so, are there any requirements for the model?

Hi @zxupstar,
FlashTorch is fairly agnostic to various model architectures.
For creating saliency maps, your model needs to have at least one conv2d layer as it will find the first conv2d layer and grabs gradients from it.
For activation maximisation, you have the control to specify which layers/filters to visualise.
Let me know if you encounter any problems.

Hi @MisaOgura I am having problems using activation maximization on my own model. Have mentioned the details in a new issue. Can you please have a look ?

I'm closing this for now - @zxupstar please re-open this if/when needed.
Thanks @SarfarazHabib I will reply on the thread in #34