Error when dragging text on page with animation on different element

Bug Description
This was a weird one to debug and reproduce, but I narrowed it down to the below reproduction steps.
Expected Behaviour
Text element should be dropped without an error occurring.
Steps to Reproduce

Create a new story
Add a shape element to the page and apply an animation to the shape
Add a new text element
Start dragging the text element around and observe that the text field jumps around, the safe-zone is stuck, and an error is reported in the console.

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Verified in QA


Suppurt hebrew number

Made the changes in the files, but at the moment it is still not working. I tried running the tests for Hebrew, but ava returns an error:
Recognizers-Text\JavaScript>npm test test/runner.js --match='*Hebrew*'

><EMAIL_ADDRESS>test E:\WORK\ML\develop\NLP\Recognizers-Text\JavaScript
> ava "test/runner.js"

  × No tests found in test\runner.js, make sure to import "ava" at the top of your test file

@hershkoy, can you remove the duplicate cases in the specs, so the build can go through?

I removed the duplicates and now I see there are regex syntax errors in the Hebrew files.
I will check that and I will update (it can take some time though)
Thanks for the help

Thanks for keeping pushing this, @hershkoy! I'll try to take a closer look and see if I can help you a bit.
We can start by merging partially the pieces that are already good. Especially the specs.
How many of the total English Number specs have you localized into Hebrew?

I am currently working only on Specs\Number\Hebrew\NumberModel.json. I localized all specs inside it, and currently about half of the cases are failing (mainly the Fraction phrases still require work).
If you want to merge, maybe I should add:
 "NotSupported": "javascript, java, python",

On the failing tests?


Add inkscape-open-symbols to the Symbols gallery on the Inkscape website

Hi @Xaviju !
Could you please add a link to your repository at https://inkscape.org/gallery/=inkscape-symbol-set/ ? It would be great if the set could be found more easily by users.
I could do it myself, but I'd prefer if the real owner did it.
Not sure what to use for the license, though. We could add a new one, if needed.

Cannot upload just a link, it actually requires an SVG file (a symbol set). This repositiory has too many symbol sets to upload and maintain each of them. Is there an alternative to just link an external resource instead of uploading it?

See #136


darkplaces: init at unstable-2022-05-10

Description of changes
A quake 1 engine implementation by LadyHavoc, as seen here: http://www.icculus.org/twilight/darkplaces/
Originally I had added a .desktop as well as icons, but since this is ONLY a game engine and NOT a real game, it was removed again, as it only caused the game engine to start up and display and error and never actually loading any games.
Regardless, this is akin to QuakeSpasm, that is to say this is another quake 1 engine port. I have of course also tested this with the actual Quake 1 game to ensure that this works as intended, but feel free to verify this.
Note that I was unable to run nixpkgs-review rev HEAD on this, as it returned errors relating to other packages as of the time of PR creation.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1099


Remove error popup when users try to sign up or logout

Description:
When users try to sign up or log out in yorkie house, users get an error message from the popup.
But I'm not sure this repository is the right place to discuss this issue.

Why:
I think this error message is not suitable for upper cases and we need to separate different cases for authentication.

@gollumnima Thanks for the report.
It's probably an unintended popup. So I added a label as a bug.


pie charts  label  overlapping and label hidden

the issues regarding pie charts  label overlapping and label hidden
help me if it is not issue and how i can fix it

Interesting problem! I will try to reproduce it and find a fix. Probably have to change the labeling code.

Hi codesuki
you can change the labeling code.

Sorry, not yet :( I am totally swamped by work.

Could you solve the problem by making the pie chart bigger?
The only solutions that come to mind are hiding overlapping labels or making the chart bigger.

just told me can i  do this change  in which file

making the chart bigger is not good solution

You could fork and play around with src/PieChart.jsx to see if you get some better results.

ok Thank You..

@viveknaragude @codesuki  is there a fix for this ?

Maybe here:
https://github.com/thomasdashney/react-d3-components/commit/c1486eb4b54e2554ef773297583dd02c0f9c5c68
@thomasdashney any chance for a pull request?

I pushed the fix. Version 0.6.7.

@codesuki :+1: I don't think it's a great solution, but I do think it's better than having no safeguard

@thomasdashney good job! I hope it's okay I integrated your idea there.

is there a JsFiddle @codesuki  @thomasdashney available ?

That would be a good thing to have. I personally always play around in the example file.

https://jsfiddle.net/3a7s0r1q/1/

thanks for the fiddle :+1:

It's still using the old version. Will update it in a second.

@MDB-20  please update your version its fix (thomasdashney/react-d3-components@c1486eb)

@viveknaragude it's fixed now in 0.6.7

Can we look into this again? Related to https://github.com/codesuki/react-d3-components/issues/172, this doesn't seem like the optimal behavior in pie charts in which visually there is clearly enough space for multiple labels to appear close to each other.


Connection is based on array,is this a design style guide for design a relay server?

In connection/arrayconnection.js,  It seems all the function is tend to work with array.
For example offsetToCursor is the only way to generate Cursor. Does this mean its a design pattern i must follow, or imply that i should generate Cursor by myself when using something other than array.If im planning to use Mongodb,should i make the database interface like an static array ?
BTW:
As a newbie to web develop, im a bit confused how to implement a qualified relay server.
Are there some guide for design a graphql-relay server, should i follow all the way in graphql-relay-js, which Database Facebook used with relay-server ? mysql or ?
Im not sure ask this here is appropriate or not,but the topic for graphql-relay-js is rarely on the web.
Thanks a lot, forgive my impolite.
var PREFIX = 'arrayconnection:';
/**
 * Creates the cursor string from an offset.
 */
export function offsetToCursor(offset: number): ConnectionCursor {
  return base64(PREFIX + offset);
}

Maybe i get some idea from developers.facebook.com/docs/graph-api.
Seems should do an array style cache for pagination lookup.
But graph-api looks a bit different from graphql-relay-js ,What is the relationship between graph-api and graphql-relay-js ? Is graphql-relay-js a common design guide for design a graphql server in facebook?
Thanks a lot! please give me some hints

Thanks for the questions, @iamchenxin. I have some answers for you, but we want to make sure to keep signal strong in the GitHub issue tracker (to make sure that it remains the best place to track issues that affect the development of Relay).
Questions like yours deserve a purpose-built Q&A forum. Would you like to post these questions to Stack Overflow with the tag #relayjs? We'll be happy to answer there. Post a link to your Stack Overflow question here, so that we can find it:
https://stackoverflow.com/questions/ask?tags=relayjs

@wincent Thank you so much,you are very kind.
here is link

@wincent can you create a graph-relay-js tag in stackoverflow.com,i have not enough reputation to create it.

@wincent can you create a graph-relay-js tag in stackoverflow.com,i have not enough reputation to create it.

I think we prefer to keep everything under #relayjs; makes it one less place to look.
Going to look at your question now.


Function for Text style text

Why can the text of a Text not be created with a function(Feature) or function(Feature, resolution)?
This would

simplify styling: we don't need a styling function for the layer, but only a text function for the label
it is cleaner:
** the current approach seems to be to have one instance of the Text style and set the text in the style function. Then it must be used, before the style function changes it for the next feature.
** It seems impossible to process styles asynchonously, e.g. in a web worker

Why don't you use a style function like this:
const style = new Style({
  text: new Text({
    font: '16px Arial',
    fill: new Fill({
      color: 'black'
    })
  })
});
layer.setStyle(function(feature, resolution) {
  style.getText().setText(feature.get('text'));
  return style;
});

Yes, I know how I can circumvent it.
I'm just suggesting to allow a function,

as this would be cleaner, the code would be local to the style instead of in the style function
it would be easy to just assign and forget the layer styles
other map libraries like Mapbox and Luciad Lightspeed have the concept of immutable styles and a function for the actual label

Or, if there is a reason for not having a function, I would like to know it.
I suppose, I could also create a subclass of Text that allows passing a function.

If you want to work on this, I think a function like the GeometryFunction on ol/style/Style would be fine, i.e. one that is called with the Feature as argument. So ol/style/Text's text property would then take a string, a string array or a TextFunction as argument. Looking forward to your pull request.

See #13686

Hi, are you still opened to a PR for this feature request? As i need something like this, i could handle this

@ahocevar has reviewed the PR now, I changed the code based on his comment, but I won't find time to merge the branch with the current main.
(We are currently not using openlayers, but instead maplibre)

@DavidHequet Feel free to fork @cns-solutions-admin's branch and complete it, or start from scratch with a new pull request.


Using php's 8.1 first class callable method leaves an xdebug in limbo

When a closure is passed via a first class callable method xdebug doesn't know where it is.
<?php
namespace Foo;
include_once '/path/to/laravel/vendor/autoload.php';

use Laravel\SerializableClosure\SerializableClosure;

class Bar {
    public function __construct(public int $x = 0) {

    }

    public function foo(int $a) {
        $y = $a + $this->x;
        xdebug_break();
    }
}

$bar = new Bar();
$closure = new SerializableClosure($bar->foo(...));
$x = serialize($closure);
echo $x;
$z = unserialize($x);
$z->getClosure()(2);

When a closure is passed via a first class callable method, maybe serialize the given class, then call the method on the deserialized class?
Currently we need to use string references instead of these first class callable features we have now available.

Please recreate this issue with a filled out issue template. Thanks


Issue #736 Mbot Simulation Support added

Implementation of Mbot Simulation. No support for the mbot button or the display.

merged with c82d755aa71ea5302e5a81ab6379f7888486a3d3, thank you!


Support session timer

Is your feature request related to a problem? Please describe.
Since the server uses the session timer to handle the session timeout but seems SIP.JS doesn't support this will cause the call not to hang up after the user uses F5 to refresh the web page.
Describe the solution you'd like
Implement the RFC 4028.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Closing as duplicate of #18. Also note, we have a branch where we believe this was working: https://github.com/onsip/SIP.js/tree/session-timers
The branch has not been updated for the new API, but was built in a way that it may port fairly cleanly, if you have the time to put a PR together.


PostgreSQL Errors in api.log

Getting the following error from api.log
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/views/decorators/csrf.py", line 56, in wrapper_view
    return view_func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/django/views/decorators/http.py", line 43, in inner
    return func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/code/rconweb/api/views.py", line 143, in public_info
    config = RconServerSettingsUserConfig.load_from_db()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/code/rcon/user_config/utils.py", line 95, in load_from_db
    conf = get_user_config(cls.KEY(), default=None)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/code/rcon/user_config/utils.py", line 145, in get_user_config
    res = _get_conf(sess, key)
          ^^^^^^^^^^^^^^^^^^^^
  File "/code/rcon/user_config/utils.py", line 138, in _get_conf
    sess.rollback()
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/orm/session.py", line 1931, in rollback
    self._transaction.rollback(_to_root=True)
  File "<string>", line 2, in rollback
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/orm/state_changes.py", line 139, in _go
    ret_value = fn(self, *arg, **kw)
                ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/orm/session.py", line 1338, in rollback
    raise rollback_err[1].with_traceback(rollback_err[2])
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/orm/session.py", line 1303, in rollback
    t[1].rollback()
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 2599, in rollback
    self._do_rollback()
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 2718, in _do_rollback
    self._close_impl(try_deactivate=True)
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 2701, in _close_impl
    self._connection_rollback_impl()
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 2693, in _connection_rollback_impl
    self.connection._rollback_impl()
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1121, in _rollback_impl
    self._handle_dbapi_exception(e, None, None, None, None)
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 2344, in _handle_dbapi_exception
    raise sqlalchemy_exception.with_traceback(exc_info[2]) from e
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 1119, in _rollback_impl
    self.engine.dialect.do_rollback(self.connection)
  File "/usr/local/lib/python3.11/site-packages/sqlalchemy/engine/default.py", line 692, in do_rollback
    dbapi_connection.rollback()
sqlalchemy.exc.DatabaseError: (psycopg2.DatabaseError) error with status PGRES_TUPLES_OK and no message from the libpq
(Background on this error at: https://sqlalche.me/e/20/4xp6)

I've never seen that one before. Do you have any more details, what you were doing when it happened, what version of CRCON were you on at the time? Are there any steps you can take to reliably reproduce it?


Unique URLS for tabbed content

Incorporate Unique URLS (even if just hashtags) for the following:
Browse Sustainability Topics
Browse Content Types
Under Sustainability Topics:
Toolkit
Resources
Stars

This is in, it works throughout all (bootstrap3) tabs on all pages.

Perhaps not yet deployed on dev server? I'm not getting unique urls yet.

https://aashe-hub-dev.herokuapp.com/#topics loads to start part way down the page (i.e. below the Campus Sustainability Hub text) while https://aashe-hub-dev.herokuapp.com/#contenttypes loads at the top.  Both should load at the top.

@juliandsmith do you mean that the page is jumping down to the end of the document, when you load the #topics tab? I can see that too.

Yep, exactly.
--
Julian Dautremont-Smith
Director of Programs
Association for the Advancement of Sustainability in Higher Education
www.aashe.org |<EMAIL_ADDRESS>|<PHONE_NUMBER>
On Mon, Nov 16, 2015 at 4:04 PM, Martin Mahner<EMAIL_ADDRESS>wrote:

@juliandsmith https://github.com/juliandsmith do you mean that the page
is jumping down to the end of the document, when you load the #topics
tab? I can see that too.
—
Reply to this email directly or view it on GitHub
https://github.com/AASHE/hub/issues/44#issuecomment-157169675.

--
Connect with us:   Website http://www.aashe.org/ | Facebook
https://www.facebook.com/aasheorg | Twitter
https://twitter.com/AASHENews | LinkedIn
http://www.linkedin.com/company/aashe
http://www.aashe.org
Email Confidentiality Notice
http://www.aashe.org/email_confidentiality_notice

Hrm, that is a drawback of the #hash logic we use there. The browser loads the page, and it automatically jumps down to that id:hash in the document. The makes the page jump up again.
Think we need to rename those hashes in the URL so they don't match the document hash.


dev-cmd/bump: don't use Repology version if livecheckable

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This should fix issues like one seen in https://github.com/Homebrew/homebrew-core/pull/116956 when the Repology version is greater than the one we get from Livecheck and the strategy is different than GithubLatest.
Basically if we define a livecheck block, I think we want the Livecheck to be the top priority over Repology.
If we don't define the livecheck block, then Repology data should be equal to what Livecheck returns.

Review period will end on 2022-12-01 at 07:33:37 UTC.

Review period skipped due to critical label.


teamspeak_client: 3.5.6 -> 3.6.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I don't really use wayland with ts3 anymore because global hotkeys don't work but I could test that I guess.

Result of nixpkgs-review pr 242531 run on x86_64-linux 1

1 package built:

teamspeak_client


Can I use it as a radio player and how?

Hello,
I like this player and I want to use it as a radio player, can i do that?!
Thank you

Sorry, I've never done it before.


WIP: api: Add cache keys and a way of filtering on them in subscription requests

Signed-off-by: Mark D. Roth<EMAIL_ADDRESS>Commit Message: api: Add cache keys and a way of filtering on them in subscription requests
Additional Description: This provides a cache key mechanism for use in dynamic resource selection.  For context, see https://docs.google.com/document/d/11XyabQ9mgdXil7ssRTKyovxUWIjj1CzJmgTAwmRqJx0/edit?usp=sharing.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A
CC @htuch @stevenzzzz

assigning @htuch for when he is back.
/wait-any

@markdroth @htuch looks like this may have gotten lost. should we stale it out or mark as waiting?

/wait

Closing this, since this approach won't work for caching xDS proxies.


Constant Refreshing

Hi,
As other user has noticed in the community page thread, this card seems to be continously resfreshing.
I think the problem can be here, as this comparison will always evaluate to false if attributes is an object (which I think it is):
this._oldHass.states[entity_id].attributes !== this._hass.states[entity_id].attributes

I'm also not sure about this other comparison, as I think the hass object always contains all entities whenever one of them changes:
this._oldHass.states[entity_id] !== this._hass.states[entity_id]

I've trying this card and is awesome, but this continous refresh is causing performance issues in my wall panels which are always showing the dashboard. Would be nice to have it fixed :)
Maybe it would be simpler watching only entities in the entity and entities fields, not looking into the content to find them.
Thanks for your great work!
PS: if you add some steps about how to compiling and testing this card I can give it a try :)

Hello there! Thanks for posting this issue and thanks for your analysis!
I actually thought at first that i had fixed it :v
But obviously that's not the case.
Since my last contribution on this project, i learned a lot about how useContext affects React performance causing re-renders and i am pretty sure that's the culprit, together with some other minor errors like comparison of objects (i am used to Python's behavior, which is far different from JavaScript's behavior).
I'll do a huge refactor on tailwindcss-template-card today, putting together everything that i learned in the recent months.
I'll keep you posted about it!

Hello! Can you try v3.1.1 and check if the constant refreshes persist?
For me, it seems that it works just fine now, not refreshing on every state change
https://github.com/usernein/tailwindcss-template-card/assets/29507335/eeba590d-8768-46da-819b-3e8a3196998e


Added system font recognition for xfce-terminal

It's a little beefy perhaps. I can't but help wish we had an xml  solution to use for XFCE and Openbox files. Would tidy this up quite a bit. XFCE WM Theme is also in this file, which I had plans to do next.
XFConf is an option too:

Funny thing, i just  pushed XFCE theme detection.

I see it. So this could be done a lot simpler.

Yes i'm just at reviewing your PR

Quite happy with this one, apart from the string.h requirement. I couldn't think of an elegant solution.

This seems fine. There is no problem with including string.h, just with using some dangerous functions out of it. Good resource for this is the commit history of https://github.com/git/git/blob/master/banned.h. I don't see a problem with strcasecmp.


GPUImageRawDataOutput with Swift

I am trying to get the color of a cgpoint within a GPUImageView in swift. I read that we could use GPUImageRawDataOutput to achieve this. How could I go about doing this?

A GPUImageRawDataOutput will give you the raw bytes of whatever stage you attach it as a target of. Set it as a target of the stage right before your view, and set the newFrameAvailableBlock to get a callback whenever a new image is available. You can then access the rawBytesForImage to grab whatever bytes you want from the processed image.
This is used in the ColorObjectTracking example to do just what you describe.


Applinks with custom scheme not working on iOS

I have added the custom scheme in my CFBundleURLTypes and I have added support to handle app links in my flutter code.
My custom scheme applink URL in this instance is, myapp://search?TSLA
When I invoke the link manually, it opens the app and goes to search as expected.
But when I send a notification from dashboard, and try opening the app via notification, it just opens the app and nothing happens after that. All the deeplink data is lost.  Here's how I send the notification.

I'm using custom FCM implementation btw.

I am using Firebase cloud messaging and I have my code in place to handle the reading of the notification data and route the user to specific place.
I said I'm using FCM, because thought it would be relevant for you to get context of my architecture.

@Imgkl can you please share how you are handling push data?

@Shahroz16 , Nothing fancy. Usual stuff.
  _firebaseMessaging.getInitialMessage().then(_processNotification);

    FirebaseMessaging.onMessage.listen(_processNotification);

    FirebaseMessaging.onMessageOpenedApp.listen(_processNotification);

    FirebaseMessaging.onBackgroundMessage(_processNotification);

@Imgkl I am a bit confused here, apologies for that. If you are handling the push notifications yourself using FlutterFire it seems, how is our SDK is supposed to help you with the deep links?
You should be getting the payload yourself and managing deep links.

I am experiencing this same issue when cold starting iOS app from push notification which as applink defined. When tapping push while app is open, it works normally. @Imgkl did you figure it out how to make it work?

@nikorehnback, sorry that you're experiencing this issue with push notification deep links.
Besides the help that you receive in this GitHub issue from others, I suggest sending our support team an email<EMAIL_ADDRESS>with the following information:

A URL referencing this github issue.
A description of the issue. A list of steps you use to reproduce the issue would also be helpful.
A copy of your ios/Podfile file
A copy of your ios/AppDelegate.swift file
A copy of your pubspec.yaml file. I am mostly interested in seeing the dependencies block in this file. Remove any sensitive information from this file, if needed.

While you send that information, I suggest double-checking the documentation for enabling push notification metrics in your app. Even if you're not planning on using push notification metrics, these metrics and deep link handling are implemented the same in the SDK. By confirming opened metrics work in your app, we can feel more confident in deep link handling in your app as well.
Hope this helps kick-start your troubleshooting. Have an awesome day!


remove useless transaction from createNotionConnector

It's not useful since there is only one DB query
it's actually pretty bad because the connector need the connector object in the DB

There's a Github ESLint alert on sequelize_conn (see files changed)

Good catch ! Fixed @lasryaric @spolu


psql version

「Peloton has been tested to work with psql version 9.5.4.」
So terrier ?
My pg version is 12.3. When I connected to terrier, I got the following error.
psql: error: could not connect to server: server closed the connection unexpectedly
	This probably means the server terminated abnormally
	before or while processing the request.

matt@Matts-MBP ~ % psql --version
psql (PostgreSQL) 12.3
matt@Matts-MBP ~ % psql -h localhost -p 15721 -d terrier
psql (12.3, server 9.5devel)
Type "help" for help.

terrier=#

12.3 works okay here. Can you describe a bit more about your setup (OS, compiler, etc.) and the psql command that you're using?

OS*
Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro15,4
      Processor Name: Quad-Core Intel Core i7
      Processor Speed: 1.7 GHz
      Number of Processors: 1
      Total Number of Cores: 4
      L2 Cache (per Core): 256 KB
      L3 Cache: 8 MB
      Hyper-Threading Technology: Enabled
      Memory: 16 GB
      Boot ROM Version: 1<IP_ADDRESS>.0 (iBridge: 17.16.13050.0.0,0)

compiler
llvm@8
Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.3.0
Thread model: posix

my operator is following:
after terrier is running:
[2020-05-16 20:45:30.651] [network_logger] [info] Listening on port 15721
I used this psql command: psql -h localhost -p 15721 -d terrier   and got  an error.
but if I connect the default port 5432, it's ok
psql -h localhost -p 5432 -d terrier
psql (12.3)
Type "help" for help.

terrier=#

How are you starting the terrier server?

mkdir release
cd release
cmake -DCMAKE_BUILD_TYPE=Release ..
make -j4

then found a terrier binary under the release folder: ./terrier
but this time I found a strange warning when I executed make -j4
ld: warning: directory not found for option<EMAIL_ADDRESS>
however, I only have /usr/local/opt/postgresql@12/lib

psql connected the terrier successfully on my ubuntu system.
Thanks for your reply!


Server Variables are only supported on Azure Front Door Standard/Premium

As Server Variables are only supported on Azure Front Door Standard/Premium, in the URL redirect scenario you cannot use Azure Front Door classic to utilize server variables to dynamically change the request/response headers or URL rewrite paths/query strings

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5c4578c-9d10-1331-9927-69055613448b
Version Independent ID: 59c63d40-dd83-6139-04eb-e5a6b7c474f2
Content: Configure Azure Front Door rules actions
Content Source: articles/frontdoor/rules-actions.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: yuajia

I have made a PR which will add a note regarding Server Variable support to this document. It is currently under doc author's review.


Add prettier to mitmweb

Description

Closes #5984
This simple change adds prettier as a dev dependency, a .prettierignore file and a change to autofix.ci to run a prettier check.
Checklist

[x] I have updated tests where applicable.
[ ] I have added an entry to the CHANGELOG.

I'm not sure what kind of environment GitHub actions run prettier under, not sure if I should call to it using npx or prettier directly.
Also, this would also require a commit with linting changes (as CI check will currently fail), but I might do that after an initial code review.

Awesome, thanks!
Is npx installing the prettier version from package-lock.json, or is it just getting whatever is latest? I would really like to pin the version in CI to avoid random breakage on prettier updates.

Awesome, thanks!
Is npx installing the prettier version from package-lock.json, or is it just getting whatever is latest? I would really like to pin the version in CI to avoid random breakage on prettier updates.
Seems like one of the snapshot tests needs to be updated after pretty-printing. :)

Yeah, npx will be getting the latest prettier, I'm really unfamiliar with GitHub actions, so I don't know what kind of environment npx runs in (I'm kind of surprised npx just works out of the box). My CI experience is from Azure, and we have to do an explicit environment set-up there (install node & any other binaries you want to use in your tasks).
I'll do a bit of reading, but I'm open to suggestions :)

@mhils Making python tests generate valid formatted JS can be an issue of it's own I think. I've spent some time looking into it, but I don't think I have the time available to do it properly, at this time. Besides, I didn't really realise that it was in the scope of this issue.
My suggestion: Ignore these files for now, capture a new issue to re-write the python tests to generate proper JS.
But do tell me, how you want me to proceed with this.

Yeah, npx will be getting the latest prettier, I'm really unfamiliar with GitHub actions, so I don't know what kind of environment tasks run in (I'm kind of surprised npx just works out of the box). My CI experience is from Azure, and we have to do an explicit environment set-up there (install node & any other binaries you want to use in your tasks).

GitHub CI is Azure Pipelines under the hood, so you can assume most things are the same. The GHA runner just has more stuff preloaded I think? Back to the question, I guess the most straightforward approach would be to run npm ci first and then call the prettier binary directly. :)

My suggestion: Add these files to .prettierignore, capture a new issue to re-write the python tests to generate proper JS.

I'm happy with two approaches:

Fix the file generation - from the diff it looks like we only need to add semicolons and that's it?
Add it to .prettierignore and that's it. I don't think we should create an issue for this, realistically speaking there is no reason to believe someone wants to tackle this in the future if you don't want to do it now.

I'm happy with two approaches:

Fix the file generation - from the diff it looks like we only need to add semicolons and that's it?
Add it to .prettierignore and that's it. I don't think we should create an issue for this, realistically speaking there is no reason to believe someone wants to tackle this in the future if you don't want to do it now.

It's not that I don't want to do it, It would just require a lot more work. 😄
There are 3 test files which require changing:
mitmproxy/web/src/js/ducks/_options_gen.ts - Straightforward, just add the semicolons.
mitmproxy/web/src/js/__tests__/ducks/_tflow.ts
mitmproxy/web/src/js/__tests__/ducks/_tbackendstate.ts
The two above are trickier, as they parse their respective data (python dict), and output a JSON, which then just gets written into a javascript file.
I'm not going to go into exhaustive detail of what's different between the JSON and the JS code prettier expects. Long story short, json.dumps() doesn't give us the formatting we need.
I have tried replacing json.dumps() with json5.dumps() from JSON5 library. That has worked, and gives us a result closer to what we want, but still not quite.
I have searched far and wide to output the format we want, but I don't see any libraries that would do that for us. Writing my own implementation for formatting just seems excessive.
I think at this point, I will push the remaining changes I have, and add the problematic tests to .prettierignore.

Ah yes - I was only looking at the _options_gen.ts diff, which I guess was the trivial part where just fixing it is the right approach. I think we can generously put the rest into prettierignore :)

Ah yes - I was only looking at the _options_gen.ts diff, which I guess was the trivial part where just fixing it is the right approach. I think we can generously put the rest into prettierignore :)

I've also been meaning to ask, shouldn't we just put prettier --check into main.yml ci? I think tox linting task runs as part of that CI.
(Note the difference between prettier --check and prettier --write)
I know the issue mentioned putting it into autofix.ci.
In my opinion, contributors should be fixing linting errors before committing, rather than CI doing that automatically + pushing a commit on top of their changes. I'm happy to be proven wrong, just want to double-check. :)

I've also been meaning to ask, shouldn't we just put prettier --check into main.yml ci? I think tox linting task runs as part of that CI. (Note the difference between prettier --check and prettier --write) I know the issue mentioned putting it into autofix.ci.

The autofix.ci task already updates the pull request if it's not formatted correctly, so adding a second check into main.yml feels redundant. I do however think it would be good to add a note about prettier in web/README.md.

In my opinion, contributors should be fixing linting errors before committing, rather than CI doing that automatically + pushing a commit on top of their changes. I'm happy to be proven wrong, just want to double-check. :)

I think that makes sense for a project with a stable set of contributors, but that approach does not work as well for FOSS. Yes, ideally everyone does format their code before sending a pull request, but in practice we regularly had pull requests that were blocked on failing CI due insignificant minutiae, which is highly annoying. Having these things auto-fixed by CI is much easier. We squash small PRs anyways, so it does not end up in the git history. :)

I've also been meaning to ask, shouldn't we just put prettier --check into main.yml ci? I think tox linting task runs as part of that CI. (Note the difference between prettier --check and prettier --write) I know the issue mentioned putting it into autofix.ci.

The autofix.ci task already updates the pull request if it's not formatted correctly, so adding a second check into main.yml feels redundant. I do however think it would be good to add a note about prettier in web/README.md.

In my opinion, contributors should be fixing linting errors before committing, rather than CI doing that automatically + pushing a commit on top of their changes. I'm happy to be proven wrong, just want to double-check. :)

I think that makes sense for a project with a stable set of contributors, but that approach does not work as well for FOSS. Yes, ideally everyone does format their code before sending a pull request, but in practice we regularly had pull requests that were blocked on failing CI due insignificant minutiae, which is highly annoying. Having these things auto-fixed by CI is much easier. We squash small PRs anyways, so it does not end up in the git history. :)

Alright! Thank you for all of your help, I really appreciate it.

That's all the changes I had, let me know if I have missed anything!

Awesome, thanks! 🍰

This was my first ever PR to an open source project, I will now be forever chasing this high of having my pull request approved.

You're welcome back to seek that any time! 😃


[6.0] DomCrawler and CssSelector are actually browser-kit deps

Unless you require https://github.com/laravel/browser-kit-testing this is not needed by any developer to use the Framework.

Can we maybe get rid of the dependencies in require-dev as well?

@driesvints
Should be possible, can't find any code referring both namespace.
https://github.com/laravel/framework/search?q=CssSelector&unscoped_q=CssSelector
https://github.com/laravel/framework/search?q=DomCrawler&unscoped_q=DomCrawler

@crynobone I hijacked your PR 😬

That's odd. It didn't re-trigger the build.

I  hijacked your PR

No problem

That's odd. It didn't re-trigger the build.

Travis running the build at the moment https://travis-ci.org/laravel/framework/builds/575089816


migration guide 404

https://master.sdk.operatorframework.io/docs/golang/project_migration_guide/ 404s
That link is provided on this page https://sdk.operatorframework.io/docs/migration/v0.19.0/

Updated latest branch so that sdk.operatorframework.io now points to v0.19.2 docs. That fixes the broken link.
Also filed #3648 to fix the duplicate link that's on that site.
Closing since it at least no longer 404s


Is this possible to generate data on non-inputted data put

C3 version: 0.57.0
D3 version: 3.5.0
Browser: Chrome Version 65.0.3325.162 (Official Build) (64-bit)
OS: macOS 10.13.3

Consider the following chart, but the user select on the red arrow pointed area....Is this possible to show that point value? Not only the data point can give the value.

I do not know.sorry.

If its not a "data-point" it is not possible yet

No this is not possible, there are no "data point" here to select.


sfdx force:source:retrieve doesn't retrieve CSS Library components

Summary
It's not possible to retrieve lwc component without *.js file
Steps To Reproduce:

I create and deploy CSS Library component:
cssLibrary
├──cssLibrary.css
└──cssLibrary.js-meta.xml
(https://releasenotes.docs.salesforce.com/en-us/summer20/release-notes/rn_lwc_css_share.htm)
Retrieve this component

sfdx force:source:retrieve -m LightningComponentBundle:cssLibrary
Expected result
Component should be retrieved
Actual result
ERROR running force:source:retrieve:  Cannot read property 'fileName' of undefined
Additional information
Feel free to attach a screenshot.

SFDX CLI Version(to find the version of the CLI engine run sfdx --version):
sfdx-cli/7.70.1-3d8a6229fc win32-x64 node-v12.18.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core)
salesforcedx 49.6.1 (core)
├─ salesforcedx-templates 49.2.0 (core)
├─ salesforce-alm 49.6.0 (core)
├─ custom-metadata 1.0.8 (core)
└─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)

I confirm the problem, even with latest stable cli package
sfdx-cli/7.74.1 win32-x64 node-v12.18.4
salesforcedx 49.10.0 (core)
├─ templates 49.9.1 (core)
├─ custom-metadata 1.0.10 (core)
├─ @salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
├─ apex 0.0.9 (core)
└─ salesforce-alm 49.11.0 (core)
sfdx-cli 7.74.1 (core)

Same result with latest pre-release version
salesforcedx 50.0.5 (pre-release)
├─ salesforcedx-templates 49.5.0
├─ salesforce-alm 50.0.5
├─ @salesforce/sfdx-plugin-lwc-test 0.1.5
└─ custom-metadata 1.0.10
sfdx-cli 7.74.1 (core)

This will be fixed in the next CLI patch release.  ref: W-7868812

FYI, this is almost fixed in 7.75.0, but I'm still seeing one issue with it. It's not pulling down the component's meta.xml file when the style-only LWC component is retrieved.

Thanks @SCWells72 - It's being retrieved but just not copied to the project properly.  I'll get it fixed asap.  Probably not this Thursday but the following.  Sorry about that.

@shetzel that's totally fine. Just trying to make sure you're all aware of any remaining loose ends. Thanks for the update!

the internal ticket we are tracking W-7868812

I'm trying to get the fix for this into the next latest-rc.  It's very close, and I'll let you know when you can try it in the RC.

The fix for this will be in the release this Thursday.  salesforcedx v50.6.0, sfdx-cli v7.81.0.  You can try it early using the release candidate.  sfdx plugins:install salesforcedx@latest-rc.  Thanks for your patience!

This is now fixed with CLI v7.81.0 and salesforcedx v50.6.0


check localConfiguration is null

Now I am using the media3 do a music software. I have a function to save the last playlist, so the next time I launch the app, I load the last playlist and index directly. But I found that in Media3 mediaLibrarySession must set the MediaItemFiller, leaving it blank will also cause the check to be empty.
The official demo reads like this:
    inner class CustomMediaItemFiller : MediaSession.MediaItemFiller {
        override fun fillInLocalConfiguration(
            session: MediaSession,
            controller: MediaSession.ControllerInfo,
            mediaItem: MediaItem
        ): MediaItem {
            return itemTree.getItem(mediaItem.mediaId) ?: mediaItem
        }
    }

So when I start up my app, I go to the database and retrieve the list and I go to setMediaItems, and it jumps to the MediaItemFiller, which looks from the ItemTree first, but some of my songs are going to be in the album, and they're not going to scan for them when they first load. But the mediaItem that was returned is the mediaItem that was passed in, and I see that its Uri is already empty, which will cause the localConfiguration to still be empty when I check.
    inner class CustomMediaItemFiller : MediaSession.MediaItemFiller {
        override fun fillInLocalConfiguration(
            session: MediaSession,
            controller: MediaSession.ControllerInfo,
            mediaItem: MediaItem
        ): MediaItem {
            return MediaItem.Builder()
                .setMediaMetadata(mediaItem.mediaMetadata)
                // I need to reset the Uri，but why?
                .setUri(mediaItem.mediaMetadata.mediaUri)
                .setMediaId(mediaItem.mediaId)
                .build()
        }
    }

When you are calling mediaController.setMediaItems(items) in a UI component like an Activity or a Fragment,  the argument that you pass to the method is sent to the service and under the hood marshalled in a Parcel and then unparceled back to a MediaItem when arriving at the service. In this process the localConfiguration is removed for security/privacy reasons. It may contain information like uri and DRM keys an app doesn't wants to share. This restriction applies in both directions of communications between client and service.
The MediaItemFiller then adds the data that is validated and often read from a database by using the mediaId as the key.
What you are doing is a different, but equally reasonable approach to provide that data. If you are sure only your application is using the service this is perfectly fine. I think you probably do so to not be required to read from the database from the service also which is probably a reasonable decision.

We have similar question in #8 . I'm closing this issue. Please re-open if you think there needs to be something added.


out_forward errors on shutdown with require_ack_response enabled

Describe the bug
When we stop td-agent service, out_forward sometimes throws
an unhandled exception.
The exact exception varies, but it always occures in ack_handler.rb.
Here is a few examples:
# case 1
unexpected error while receiving ack error_class=IOError
error="closed stream"

# case 2
unexpected error while receiving ack message error_class=IOError
error="stream closed in another thread"

# case 3
unexpected error while receiving ack error_class=NoMethodError
error="undefined method `disable!' for nil:NilClass"

It suggests that out_forward's shutdown sequence is racy i.e.
multiple threads can process the same ack message concurrently.
To Reproduce

Run out_foward with require_ack_response
Stop Fluentd during actively transmitting records.

Expected behavior
No error.
Your Environment
- Fluentd version: v1.15.2
- TD Agent version: -
- Operating system: -
- Kernel version: -

Your Configuration
<match **>
  @type forward
  require_ack_response true
  ...
</match>

Your Error Log
See above.

Additional context
No response

I note how to reproduce this.

Launch 2 Fleuntd (Aggregator and Forwarder)

Config of Aggregator
<source>
  @type forward
</source>

<filter test.**>
  @type record_transformer
  enable_ruby
  <record>
    hoge ${ sleep(1); "hoge" } # Insert `sleep` to stack the ack check
  </record>
</filter>

<match test.**>
  @type stdout
</match>

Config of Forwarder
<source>
  @type sample
  tag test
</source>

<match test.**>
  @type forward
  require_ack_response true
  <buffer tag,time,file>
    @type file
    path /test/fluentd/forwarder/buffer
    timekey 24h
    flush_mode immediate
    flush_at_shutdown true
  </buffer>
  <server>
    host localhost
    port 24224
  </server>
</match>

Wait a while and we can see some chunk files staying in the Forwarder.
Then stop the Forwarder and check the log of Fluentd.

This is a little difficult.
It doesn't seem that storing many chunks makes it easier to reproduce.
Increasing the sleep time seems to make it harder.
It may depend on the machine specs, but if I stop Fluentd when 2 chunk files accumulate, it is easy to reproduce.


Added pause resume functions Fixes #2

Pause/Resume functionality added. More Info

I'm not sure if pausing the CAAnimation is a good approach. The Apple implementation of it simply puts the bars down. I made a second branch with a similar behavior. Can you check if it fits the requirements?

I checked the new branch. Its awesome now. Thank you :)
On Sunday, December 13, 2015 12:09 AM, Dennis Oberhoff<EMAIL_ADDRESS>wrote:

I'm not sure if pausing the CAAnimation is a good approach. The Apple implementation of it simply puts the bars down. I made a second branch with a similar behavior. Can you check if it fits the requirements?—
Reply to this email directly or view it on GitHub.

As far as the approach for pausing the CAAnimation is concerned, I think its good approach as it is documented way of pausing the animation. See this:
Apple's technical note QA1673!

Yes indeed. I didn't feel it would be the right approach in this case, because it would break the reusability of a TableViewCell. (The state needs to be restored when the cell if configured.)


Bump assay crate for security fix

PR Checklist

[x] I've built the code cargo build. For major changes, cargo build --workspace --release is recommended.
[x] I've run the automated unit tests cargo test. This executes our automated unit tests.
[x] I've not broken any existing tests or functionality. In addition to cargo test, I've run cargo clippy
[x] I've not introduced any new known security vulnerabilities. I've run cargo audit

[x] I've included a brief description and a good title of the proposed changes and how to test them.
[x] I've read the contributing guidelines.
[x] I've associated an issue with this Pull Request.
[x] I've checked that the code is up-to-date with the pyrsia/main branch.
[x] I've read "What is a Good PR?"
[x] I've assigned this Pull Request to "pyrsia/collaborators"

Description
Fixes #397
This PR fixes the security warning generated due to "assay" crate  using deprecated "tempdir" crate. Since i had raised PR with assay with updated codebase using "tempfile"and it got released so we can upgrade
Screenshots (optional)

Can you please link to the upstream PR you submitted I would love to keep track of these!

Can you please link to the upstream PR you submitted I would love to keep track of these!

I already have upstream PR mentioned in the linked issue #397 "https://github.com/mgattozzi/assay/pull/6", but i am not sure if i can link any other repo PR here.

I already have upstream PR mentioned in the linked issue

Ahh I didn't look there, thanks for sharing ☺


Dropdown not properly horizontally aligned

I'm attempting to put a dropdown in my navbar, but it doesn't properly align horizontally. Here's a fiddle. Not sure if I'm doing something wrong or if this is a bug.

Well, I guess that this button was not designed to be used as a dropdown activator
a quick workaround could be
nav ul a.btn{
    margin-left: 0;
    margin-right: 0;
}


Move TokenPoolCreated handler into AssetManager

Codecov Report

Merging #210 (61f12cc) into main (1932273) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 61f12cc differs from pull request most recent head 80eece5. Consider uploading reports for the commit 80eece5 to get more accurate results

@@            Coverage Diff            @@
##              main      #210   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          203       203
  Lines        11026     11033    +7
=========================================
+ Hits         11026     11033    +7

Impacted Files
Coverage Δ

internal/events/event_manager.go
100.00% <ø> (ø)

internal/assets/manager.go
100.00% <100.00%> (ø)

internal/assets/token_pool_created.go
100.00% <100.00%> (ø)

internal/orchestrator/bound_callbacks.go
100.00% <100.00%> (ø)

internal/orchestrator/orchestrator.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1932273...80eece5. Read the comment docs.


purescript: unbreak package by fixing imports for new mtl

mtl decided to un-export Control.Monad and Data.Monoid, which in itself is fine, but of course it breaks everything.
ATTN: this is based on 24.05, I have no clue how this stuff gets integrated into stable. staging-next? I haven’t yet tried to upstream it.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

upstream PR: https://github.com/purescript/purescript/pull/4547

Ah, the correct branch to merge this into is release-24.05. We can merge it directly there I don’t expect this change to need staging. (Make sure to convert to draft before redirecting the PR, just to be sure.)

Actually this change should go on master as well, cause it’s broken there just the same.

Well, then the usual workflow is to figure that change out on the haskell-updates branch first and then do a backport.

@maralorn this applied without merge conflicts on haskell-updates: https://github.com/NixOS/nixpkgs/pull/329200


tool/contain: Needs a README.md and a .tellfile

All directories should have, at least, a README.md and a .tellfile. Even if they're short.

6f7117a
9ba3e43


Explicitly state the hourly timeframe for pull rate limits

Signed-off-by: Usha Mandya<EMAIL_ADDRESS>State the rate limits timeframe for pull requests

@binman-docker Could you PTAL?

@binman-docker  ptal


Make the table row consistent

Business contact table

Participant Requests table

Sharing Permission table

Team members table

@alex-yau-ttd  I took the change out of https://github.com/IABTechLab/uid2-self-serve-portal/pull/120
Regards to the table width, I found so far the width is not consistent. I will leave a comment ask for that

hmm the approvals error is still showing on two lines for me


train rework, introduce --backend flag

Changes
added --backend flag for ilab train allowing users to switch their training backend between pytorch and mlx.
changed what was linux_train.py to work for both macos and linux depending on some new flags like fp16, bfp16, etc.
Which issue is resolved by this Pull Request:
resolves #1108
Description of your changes:
ilab train on macos and linux are really different just for MLX support.
It turns out pytorch supports an mps device enabling hardware accleration on macos. This allows us to use 99% of the codepath for linux train with less storage and memory used. the mlx method requires adapters files, and a whole -fused dir that almost doubles the storage used in this whole process
This backend is also more maintainable as mlx is written in a way that lead us to need some heavy infrastructure to run it.
In testing, the pytorch train code takes roughly the same amount of time on comparable hardware and yields a better result with a model that appears to learn the new skill/knowledge in a better manner with less hallucinations.
I will note, 18gb of ram is the minimum to run this backend. When you have 32/38 train takes less than a quarter of the amount of time that 18gb does, and produces better results.
ilab train now defaults to --backend=pytorch but --backend=mlx is still available
added a few more enhancements:

--train-style lets the user choose quick or full. Quick does not do eval in between epochs. full does. I added this because without eval, if you do multiple epochs, the most recent one is chosen randomly
the --backend flag lets users choose pytorch or mlx
I got rid of the multiple flags referencing "model" and just made a --model-repo flag since train should always pull the full safetensors from HF
I got rid of a few bad flags people should probably never use like gguf-model-path gguf models for training yield horrible results most of the time
--dtype takes fp16, bf16, ftp32, and auto. This sets the dtype to user in pytorch. bf16 and fp16 were hardcoded in the past.

Nice work, Charlie! I have left a few inline comments.
The current state of the PR breaks Intel Gaudi support. It may also cause problems for AMD ROCm. We don't have CI runners for these accelerators, so you probably haven't noticed it.
I also suggest to rename the module like the --backend argument. from instructlab.train.pytorch import pytorch_train is more descriptive than linux_macos_train.

thanks for the review @tiran I had a feeling gaudi support might be impacted by this. I will try to clean everything up.

@tiran if I ran make quantize on linux, that bin will be for linux, right? if so, I would really opt to get this in and then follow up with #1017

@tiran I don't think we should block on only having x86 linux support in this PR. as long as you have a follow up that fixes it, we should be fine. Blocking this PR on that is blocking some pretty urgent work for upstream users getting a demo.
It seems like #1017 has a bunch of sub tasks that may be a longer term thing.
In the short term, I can build on a rpi if that counts as aarch? I can add that to the list of binaries lol

or @tiran I guess I could add some sort of check for "if not x86" then we can do the old convert method?

@cdoern It's not just the lack of aarch64 support. As I mentioned before, it's more complicated than just CPU arch. Your Linux binary does not run on RHEL 9. I guess you have built it on Fedora 39 or 40.
./quantize
./quantize: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by ./quantize)
./quantize: /lib64/libstdc++.so.6: version `CXXABI_1.3.15' not found (required by ./quantize)
./quantize: /lib64/libc.so.6: version `GLIBC_2.38' not found (required by ./quantize)

@tiran I approved your PR, it looks really clean. Thanks for doing that.
Will see if we can get it in before I get this working!

holding because of https://github.com/instructlab/instructlab/actions/runs/9114567829/job/25058839214

@cdoern please add a log line so we know which model we are downloading for training - currently there is no indication as to whether it's merlinite or granite

@cdoern Is this work tracked in a design document? What's the status? Thanks!

@cdoern do you still want to keep this open?


add new exit flag to gymkhana channel scoring plugin

Depends on osrf/vrx#233
Fixes problem:
When boat passes the last set of navigation gates in the gymkhana task, shutdown signal is issued to Gazebo.
A new SDF parameter flag per_plugin_exit_on_completion is added.
After these two PRs are merged, we will need to test vrx-docker with ghostship solution and make sure Gazebo no longer shuts down prematurely.
It's a tiny bit hacky, because now we have two flags for "exiting upon completion." One specified from the environment variables, and another from the SDF parameter. This is because we are chaining multiple scoring plugins for a single task.
They are slightly different in that, the env var is for all the plugins in the current shell, and the SDF parameter is just for one specific plugin.
The dilemma is how to resolve the two when one is true, the other is false.
Currently, I have the env var overwrite the SDF parameter.
Alternatively, we can do an AND or OR, but that might make the vrx-docker evaluation more complicated, because the evaluation run_trial.bash issues VRX_EXIT_ON_COMPLETION=true for all tasks. We currently don't say, issue it on all tasks except gymkhana.
In the overwrite behavior, we can set VRX_EXIT_ON_COMPLETION=false, and explicitly specify the SDF parameter flag in each world xacro file. This I think is the cleanest way, though it adds a few lines of SDF.
To test:
Keep this running in a terminal:
rostopic echo /vorc/gymkhana_channel/task/info

For all cases below, once the topic state field changes to running, move the boat by keyboard / mouse / rostopic pub straight forward. Observe what happens when it passes the last set of gates.
Case 1: Original behavior
Comment out the new line <per_plugin_exit_on_completion>false</per_plugin_exit_on_completion>.
roslaunch vorc_gazebo gymkhana.launch

Expected: When boat passes last gates, gzserver is killed in terminal. gzclient will still be open but no further steps are simulated. No new messages in the rostopic echo above.
Case 2: Added behavior
Uncomment the new line <per_plugin_exit_on_completion>false</per_plugin_exit_on_completion>.
roslaunch vorc_gazebo gymkhana.launch

Expected: When boat passes last gates, Gazebo continues running. The state field in rostopic echo above changes to finished, score remains the same for all subsequent messages.
Additionally, I tested by echoing the two tasks in two separate terminals
rostopic echo /vorc/gymkhana_blackbox/task/info
rostopic echo /vorc/task/info

and saw that when the top-level task "finished" with 0 second left, sub-task blackbox "running" with 1 second left (due to small differences in transport maybe), shutdown was still issued to gazebo, by design.
That verifies that the top-level scoring plugin's time is respected (<per_plugin_exit_on_completion> is false for the two sub-tasks, true for the top-level task.)
Case 3: Original environment variable overwrites added behavior
Uncomment the new line <per_plugin_exit_on_completion>false</per_plugin_exit_on_completion>.
VRX_EXIT_ON_COMPLETION=true roslaunch vorc_gazebo gymkhana.launch

Expected: Same as case 1.
I hope nothing else is broken, but more thorough tests to find bugs are welcome.

Hey @mabelzhang, were you able to get this working with vrx-docker? I managed to reproduce the functionality described above, but having the same gate exit results with a fresh clone. My theory was either I was being dense and missed something, or perhaps the task generation isn't generating the files correctly?

Yes, you would need to use the branch in this PR https://github.com/osrf/vrx-docker/pull/25

Thanks for testing it! Yes, you would need to use the branch in this PR osrf/vrx-docker#25

Ah, density it is! Test/scores indicate to me that it's working. Thank you!


Friendly message when netcat is not installed

Hi Guys,
I've added friendly message when Netcat is not installed.
It shows e.g.:
17:14:17 Port testing: hostname1 -> hostname2:50505: FAIL: [hostname1] Netcat not installed
Would be nice to have such info. Now it shows:
17:14:17 Port testing: hostname1 -> hostname2:50505: [UNKNOWN] UNKNOWN: ksh: -v: not found
Best regards,
Robert L (ladrob)

Looks great, thanks!  I wrote some tests and just merged it into the master branch, and gave you credit in the README. :-)
-- Doug

Hi Doug,
Great to hear. Really appreciate it. Thanks!
Robert
sob., 2 lis 2019 o 21:23 Douglas Muth<EMAIL_ADDRESS>napisał(a):

Looks great, thanks! I wrote some tests and just merged it into the master
branch, and gave you credit in the README. :-)
-- Doug
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Comcast/snowdrift/pull/5?email_source=notifications&email_token=ABTMCQTL273TMXA5H7YQZTTQRXOS7A5CNFSM4JFCYPAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5EGWQ#issuecomment-549077850,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTMCQTJD37VU6PYWZSVAJTQRXOS7ANCNFSM4JFCYPAA
.


Text hint in CI output contains incorrect operator name

@J0zi Here's an issue to track the incorrect operator name issue that you identified.

there is no openebs operator involved. It is just text hint, which should contain variable with the name of your operator. I will fix it.

Originally posted by @J0zi in https://github.com/redhat-openshift-ecosystem/community-operators-prod/issues/1777#issuecomment-1293440913

fixed


add macOS mount flags

#1688 add macOS mount flags according to Apple sys/mount.h

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Since I just added bunch of flags, do these flags have to be used?

Because MNT_FORCE is already defined in:
https://github.com/rust-lang/libc/blob/8ba9ba2bc6055ec123e56864173b557e68278a32/src/unix/bsd/mod.rs#L326
You can just remove that const from your defined.
Hm, we may be able to move the consts to bsd/mod.rs (I thought they were defined as c_ulonglong)... But it's out of scope, I can follow-up later if you don't.
And you should comment on this PR, not the issue so that we don't have to come and go :)

Also, you should resolve style failure.

Should I move these flags to libc/src/unix/bsd/mod.rs?

Should I move these flags to libc/src/unix/bsd/mod.rs?

I guess we can but we may need additional investigation so the answer is "if you like" :)
Also, CI will fail because of apple 32-bit targets, I fixed CI on master so could you rebase? And it'd be great if you could squash commits into one after finishing the work.

I did rebase and squash, I also moved the flags to libc/src/unix/bsd/mod.rs, but still some errors.

Thanks!

I also moved the flags to libc/src/unix/bsd/mod.rs, but still some errors.

Heh, that's "we may need additional investigation" point. It seems some BSDs don't have some flags (therefore use of undeclared identifier error occurs). We should move them to under /bsd/apple. And MNT_AUTOMOUNTED should be defined as ulonglong in some BSDs.

BTW, should I move MNT_FORCE from src/unix/bsd/mod.rs to src/unix/bsd/apple/mod.rs?

BTW, should I move MNT_FORCE from src/unix/bsd/mod.rs to src/unix/bsd/apple/mod.rs?

You don't have to.

Thanks!

Thanks @JohnTitor! This is my first commit to Rust~


test: links: fix failures

fix dead links detected by #958

see daily workflow builds on https://circleci.com/gh/iterative/dvc.org (e.g. https://circleci.com/gh/iterative/dvc.org/2264) for an up-to-date list
[x] fix/replace https://en.wikipedia.org/w/skins/Vector/images/external-link-ltr-icon.svg

do we really need this link? It's in a code comment
from 59e399dcc1f4f0f by @iAdramelk

[x] fix links in exclude-links.txt
[x] sort exclude-links.txt

[ ] should warnings (status codes 0xx, 3xx etc) be counted as errors instead?
fixes #974
continues #978

What's the logic behind the sorting?

er just piped though sort. Makes it easy to see diffs in future changes.

yay re-ran daily and succeeded: https://app.circleci.com/jobs/github/iterative/dvc.org/2292

I'm thinking if we should create an exclusion list on file level? (don't analyze tests?). To avoid adding a lot of links to the existing file? what do you think @casperdcl @jorgeorpinel ?

Well we could do comments both in js and markdown similar to # noqa in py/flake8

You mean this sort of thing?
[md]http://dead.link

'http://dead/link' // noqa

more like specify somewhere that I would like to exclude tests/** ... .gitinore-like interface I would say?

exclusion list on file level... specify somewhere that I would like to exclude tests/** ... .gitinore

Yes, only certain js and the md files really matter here, so I would even make it a white list with a pattern to match (similar to what prettier accepts, maybe hard to implement though). The existing list could be scripts/.link-ignore and the path list in scripts/.link-config or even sent as arguments to link-check.sh from package.json

Ideally if it could actually render all web pages and only look at actual <a href=" and <img src=" URLs, that would be great, but probably overkill to do a separate yarn build just for this.

p.s. Would also be nice if these files can ignore # comments (and blank lines) to make them self-documenting.


Intuitive Response to clicking on JSON Viewer Icon

Clicking on the JSON Viewer Extension Icon pops up a list of Menu Items. When I click on JSON Viewer I would expect it to take me to the Viewer itself (the extension part), however it takes me to the Github website.
What is the expected User Stories for this extension? This is what I expected:
1. As a User I want to Format a JSON Object while debugging an application:

Set a breakpoint inside a Web App
Add a Watch Variable for my object
JSON.stringify object (ignoring that I can indent print it)
Copy string into Clipboard
Open Google Chrome
Click on JSON Viewer
Paste Clipboard into Scratch Pad that automatically opened and see auto-formatted and syntax highlighted JSON

Clicking on the JSON Viewer Extension Icon pops up a list of Menu Items. When I click on JSON Viewer I would expect it to take me to the Viewer itself (the extension part), however it takes me to the Github website.
What is the expected User Stories for this extension? This is what I expected:
2. As a User I want to hand create a quick JSON Object / File by hand

Open Google Chrome
Click on JSON Viewer
Begin typing my JSON into Scratch Pad with simple syntax highlighting and formatting automatically working.
Save in-memory JSON into Scratch Pad Workspace ala 'jsfiddle-style'

I mainly wish to use JSON Viewer to syntax check and autoformat JSON. Is this atypical for this extension? Having to type 'json-viewer' TAB 'scratch pad' seems a bit much. How else is this extension used? I must be missing how other's use this exension and bet it's something simple I've overlooked.

Hi @afinnell, your use case makes complete sense. I usually use the flow navigation bar -> json viewer -> tab -> scratch pad a hundred times a day and sometimes I caught myself clicking on the extension icon as well.


Remove deprecated methods

Modify the deprecated .hover() method in src/deprecated/event.js so that it does not rely on other deprecated methods: .mouseenter() & .mouseleave(). Use .on() instead.

Developed the solution

Generated the commit messages

Created a new branch

Added/Updated file: src/deprecated/event.js

commited changes to new branch named bugfix/update-hover-to-on44315

Generated PR documentation

Pulled Repository content

Developed the solution

Generated the commit messages

Generated the new branch name

Created a new branch

Added/Updated file: src/deprecated/event.js

commited changes to new branch named bugfix/update-hover-to-on28740

Generated PR documentation

Pulled Repository content

Identified the files that needs to be modified and solution plan is created

Developed the solution

Generated the commit messages

Created a new branch

commited changes to new branch named bugfix/update-hover-to-on75271

Pulled Repository content

Identified the files that needs to be modified and solution plan is created

Developed the solution

Generated the commit messages

Generated the new branch name

Created a new branch

Added/Updated file: src/deprecated/event.js

commited changes to new branch named bugfix/update-hover-to-on20399

Generated PR documentation

Pulled Repository content

Identified the files that needs to be modified and solution plan is created

Developed the solution

Generated the commit messages

Created a new branch

Added/Updated file: src/deprecated/event.js

commited changes to new branch named bugfix/update-hover-to-on95980

Generated PR documentation

Pulled Repository content

Identified the files that needs to be modified and solution plan is created

Developed the solution

Generated the new branch name

Created a new branch

Added/Updated file: src/deprecated/event.js

Generated PR documentation

Pulled Repository content

Identified the files that needs to be modified and solution plan is created

Developed the solution

Generated the commit messages

Generated the new branch name

Created a new branch

Added/Updated file: src/deprecated/event.js

commited changes to new branch named bugfix/update-hover-to-on51537

Generated PR documentation

Identified the files that needs to be modified and solution plan is created

Developed the solution

Created a new branch

Added/Updated file: src/deprecated/event.js

commited changes to new branch named bugfix/update-hover-to-on10779

Generated PR documentation


"Fărcaș", "Amărăști", "Golumbelu" are listed in the drop-down menu

Description:
When user writes "Fărcaș", "Amărăști", "Golumbelu" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Fărcaș"

Expected results
The location appears in the drop-down menu as "Sat Fărcaș, DOLJ (Fărcaș)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Amărăști"

Expected results
The location appears in the drop-down menu as "Sat Amărăști, DOLJ (Fărcaș)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Golumbelu"

Expected results
The location appears in the drop-down menu as "Sat Golumbelu, DOLJ (Fărcaș)".


mod_proxy: Allow override Host header and SSL SNI in ProxyPass

This patch adds 2 optional parameters, override_http_host and override_ssl_sni for ProxyPass directive.
override_http_host allows setting custom HTTP Host: header. This may be done by utilizing ProxyPreserveHost On and RequestHeader set Host.
override_ssl_sni allows setting custom SSL server name (SNI). This seems could not be done without this patch.
This patch could be helpful in the scenario described below:

A HTTPS server on <IP_ADDRESS>:443 hosting a site domain.tld, with strict HTTP Host header check and TLS SNI check.
Apache HTTPd, running on <IP_ADDRESS>, is being used to reverse proxy https://domain.tld hosted on <IP_ADDRESS>:443
There is no (type A) DNS record pointed to <IP_ADDRESS>, which forced us to use IP address in ProxyPass
Administrator adds ProxyPass / https://<IP_ADDRESS> to Apache's configuration
Reverse proxy fails, because SNI and HTTP host was <IP_ADDRESS> instead of domain.tld
Administrator adds ProxyPreserveHost On and RequestHeader set Host domain.tld to Apache's configuration
Reverse proxy still fail, because only HTTP host header was set correctly, SNI is still incorrect.

With this patch ...

Administrator adds a single line ProxyPass / https://<IP_ADDRESS> override_http_host=domain.tld override_ssl_sni=domain.tld
It works

Besides, this patch introduce no breaking change. (i.e. incompatibility against current configurations)

Can't the same be achieved by adding an <IP_ADDRESS>:443 domain.tld entry in /etc/hosts and simply using ProxyPass / https://domain.tld ?

@ylavic Yes, this could be done by appending <IP_ADDRESS> domain.tld to /etc/hosts, theoretically.
But in case we could not modify /etc/hosts, says, doing so could break other software running on same host which httpd lives on, (<IP_ADDRESS> in our sample scenario) then this patch would help to address such dilemma.


Add Qlik

https://github.com/ambster-public/awesome-qlik
Qlik is a leading business intelligence platform delivering solutions for data visualization, analytics, and reporting. Running on the same engine, its main products are QlikView (for guided analytics) and Qlik Sense (for self-service BI). This list is a curated collection of guides, blogs, extensions, and resources to make it easier for developers and analysts to make sense of data using Qlik.
By submitting this pull request I confirm I've read and complied with the Creating Your Own List and List Guidelines requirements 🖖
PRs Reviewed:

#1605 (comment)
#1606 (comment)

Thanks.

unicorn

It's a company product 😹

It's a company product

Company named Qlik. Still software whose resources are searched and should be better grouped.

Seems deserving and complying with the requirements, would probably research for some more good extensions if there are some but these already look as really fitting awesomeness rules, no lint mistakes found.

This is nice! It seems a little short compared to most lists I've looked at, but I don't know if it really matters since the idea for awesome lists is quality over quantity. It might be nice to add a description to each extension. I'm not familiar with Qlik but this looks like a useful repo.

@ambster-public ⬆

I agree with the other comments re: format, but the amount of content does appear too thin. If I was trying to get started with Qlik, I would probably start with the official help pages first, so including them here is helpful but not doesn't connect me to a resource I wouldn't find otherwise. The blogs are nice to know about, as are the subreddits.

Yeah, I am going to work on the content some more once I've come to know some new best things. I also hope for a help from the community which will definitely come once this awesome list gets its way into the main all-embracing awesome list. For the time being, I've added another awesome Qlik blog. As far as the official help is concerned, well, I would not be so sure that it is not needed to be mentioned; I just do not think that's not really too obvious; moreover, I believe the links to these particular official sources should be present here if we want to help beginners.

Are there other resources out there for learning about Qlik? Online courses? Books? Prominent use cases? I don't know much about the resource ecosystem out there for this platform, so it's possible that there either isn't a lot of material out there outside what you've included in the list, or perhaps much of what's out there isn't truly "awesome". Either way, with a list this short it's difficult to tell.

I've partially answered that above, and yes, I am just trying to put only truly awesome stuff on the list, hoping to get help from the community once the list becomes kind of official in terms of its awesomeness. Your suggestion about books was what I was going to do by myself, and now I've finally completed that planned work and added the "best books" list. Check it out.

Also may be nice to extend "BI" out to "business intelligence" - I know this is common usage to some but it's not universal.

Everyone looking for resources about Qlik or any big data things knows what BI stands for as it is already too common. Not really sure this is critical indeed anyway.

Would love to see more additions! (I didn't even know what Qlik was, beforehand!)

Thank you so much for your comments! You are welcome to check out the updated list.

This is nice! It seems a little short compared to most lists I've looked at, but I don't know if it really matters since the idea for awesome lists is quality over quantity. It might be nice to add a description to each extension. I'm not familiar with Qlik but this looks like a useful repo.

Thank you for the comments. My purpose is including only the best, most awesome resources whose awesomeness can hardly be put in doubt. I am going to work on that more, for sure, and I also hope for a help from the huge Qlik community once the list is added and gets more kind of publicity. Anyway, it is already updated and longer, so don't miss out on that. Thanks again!

Seems deserving and complying with the requirements, would probably research for some more good extensions if there are some but these already look as really fitting awesomeness rules, no lint mistakes found.

Thanks for your feedback! I am currently testing a few new ones and will consider adding more afterward. Thanks again!

@ambster-public

@sindresorhus Hi, thanks for your attention. Looking forward to seeing the list included. Please let me know if there's anything else I should add or change from your point of view. Thank you!

Glad to see the updates - the list looks much more informative now.

I agree it looks even better now. Thank you so much for your participation!

While not specifically outlined in the guidelines, I would also add urls for the books listed. I don't want to single out any booksellers specifically but a clickable link to a table of contents for a book would help usability of the list.

While not specifically outlined in the guidelines, I would also add urls for the books listed. I don't want to single out any booksellers specifically but a clickable link to a table of contents for a book would help usability of the list.

Yeah, links to those awesome books could be helpful, so I've added them, thanks.

@sindresorhus Does it look good enough now or what else should I do about it so it can get added to your awesome list of awesome lists? Please advise. Thanks.

❯ awesome-lint https://github.com/ambster-public/awesome-qlik
✖ Linting

  README.md:36:154
  ✖  36:154  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  37:116  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  38:125  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  39:125  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  40:131  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  41:110  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  42:123  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  46:115  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  48:2    List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  49:117  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  50:111  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  51:100  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  52:123  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  53:113  List item link and description must be separated with a dash  remark-lint:awesome-list-item
  ✖  54:135  List item link and description must be separated with a dash  remark-lint:awesome-list-item

  15 errors

@sindresorhus Missed that, sorry. Now it's passed.
✔ Linting

Tweet: https://twitter.com/awesome__re/status/1195615855863726081


Cannot start on arch linux

Logs as follows
Traceback (most recent call last):
  File "main.py", line 196, in <module>
  File "asyncio/runners.py", line 44, in run
  File "asyncio/base_events.py", line 649, in run_until_complete
  File "main.py", line 152, in main
  File "twitch.py", line 630, in __init__
  File "gui.py", line 2020, in __init__
  File "gui.py", line 2228, in set_theme
  File "tkinter/ttk.py", line 522, in theme_use
_tkinter.TclError: can't find package ttk::theme::vista
[25710] Failed to execute script 'main' due to unhandled exception!

Thanks for telling me this, as I can't test that. It's an issue with the themes I added as I added dark mode. Will fix.

@wray-lee Should be fixed, can you please try out the dev build to see if it works, and if switching to dark mode as well as back applies everything correctly? Thanks!

Ubuntu 24 works.

Ubuntu 24 works.

Was v15.2.0 broken for you before? Does going from dark to light again work correctly?

v15.3.0 has the same problem, the dev version works fine.

Ubuntu 24 works.

@9ikj Was v15.3.0 broken for you before? Does going from dark to light again work correctly?

v15.3.0 has the same problem, the dev version works fine.

v15.3.0 has the same problem, the dev version works fine.

Great! I'll make the release. Thanks @wray-lee for reporting the problem and providing logs, and thanks @9ikj for the quick replies confirming the fix.


Update docs with LRP equations

Codecov Report

Merging #41 (f29fdc2) into master (a6161bc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   94.52%   94.50%   -0.03%
==========================================
  Files           9        9
  Lines         201      200       -1
==========================================
- Hits          190      189       -1
  Misses         11       11

Impacted Files
Coverage Δ

src/lrp.jl
96.00% <0.00%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6161bc...f29fdc2. Read the comment docs.


Make DataReport fields optional because clients send so

According to specs the values and supporessResponse fields are mandatory in a DataReport sent by a subscription.
The reality is that chip-tool apps sometimes send the reports without these fields, so we make them optional and add Code to handle this

Converted this to draft in favor of the fallback PR ... Once merged and releaed there I will update/redo this PR


tortoise: recompute verification window when switching into full mode

Motivation
verifying has a large verification window (think 1_000_000) and if it failed to verify layer the threshold will be computed according to that window. if we won't reset the threshold full tortoise will have to count votes for 1_000_000 layers before
any layer can be expected to get verified. this is infeasible given current performance of the full tortoise and may take weeks to finish.
closes https://github.com/spacemeshos/go-spacemesh/issues/3009
Changes

compute thresholds according to the full tortoise configuration when in full mode

Test Plan
TestRerunDistanceVoteCounting

bors merge

bors merge

bors try

bors merge


Cannot work in Node.js

Hi BTC,
Thanks for this amazing plugin.
Somehow I cannot get it to work under Node.js.
It does show up in the Plugins in the side panel,
and I can drag the tiddlers,
but when I click the 1, which should change the number of columns, nothing happens.
I also do not have the grid tab.

I have tried the single file method.
It behaves the same and does not work.
I notice that my tiddlywiki version is 5.1.22.
Do I need 5.1.23 for this plugin to work?
Thank you.

Hi @linwaytin , thanks for the issue report.
I thought that the modifier variable within the Button action-strings was already present in 5.1.22 but it isn't - and therefor this plugin is not fully compatible with 5.1.22. You would need version 5.1.23 for the columns Button to work.
The Grid Tab is only a Demo on the Demo-page, but I'm thinking about adding it to the plugin
best wishes

Hi @BurningTreeC ,
Yes, the problem is gone after I upgrade to 5.1.23.
Thank you! Great work!


Inherit from Box

I'd like to inherit from Box so that I can add some attributes during creation, particularly with init - are there any examples of doing this out there, or is this verboten?
When I do the following, I get the following errors:
class MLBox(Box):
    def __init__(self, semantic_version, schema_type: MLSchemaTypes, **kwargs):
        self.__version = SemVer.parse(semantic_version)
        self.__schema_type = schema_type

        super().__init__(**kwargs)

Error:
TypeError: __init__() missing 1 required positional argument: 'schema_type'

That should be working if you are passing both required arguments in as listed:
from box import Box

class MLBox(Box):
    def __init__(self, semantic_version, schema_type, **kwargs):
        self.__version = semantic_version
        self.__schema_type = schema_type

        super().__init__(**kwargs)

a = MLBox('3.2.1', 'test')

print(a)
# {'_MLBox__version': '3.2.1', '_MLBox__schema_type': 'test'}

Are you sure you didn't mean to do schema_type=MLSchemaTypes ?

Hmmm... I think I see the issue, but not sure how to deal with it. The problem actually comes when I merge_update, because it appears that box is attempting to do a new instantiation of a Box without the parameters. Here's the stack trace:
Traceback (most recent call last):
  File "/home/aronchick/mlspec-lib/tests/test_mlobject.py", line 18, in test_create_ml_object
    ml_object = MLObject(schema_version='0.0.1', schema_type=MLSchemaTypes.DATAPATH)
  File "/home/aronchick/mlspec-lib/mlspeclib/mlobject.py", line 37, in __init__
    self.create_stub_object()
  File "/home/aronchick/mlspec-lib/mlspeclib/mlobject.py", line 78, in create_stub_object
    self.merge_update(this_key_dict)
  File "/home/aronchick/mlspec-lib/env/lib/python3.6/site-packages/box/box.py", line 502, in merge_update
    convert_and_set(key, __m[key])
  File "/home/aronchick/mlspec-lib/env/lib/python3.6/site-packages/box/box.py", line 488, in convert_and_set
    v = self.__class__(v, **self.__box_config())
TypeError: __init__() missing 1 required positional argument: 'schema_type'

Am I misreading it? If so, what are my options here?

Ah the error you are running into is that Box has so far been designed to have sub-boxes be the same type of box as the parent. Which in this case means a MLBox would have children MLBoxes. Which would mean every sub box has to have the values schema_version and schema_type.
To make inheritance easier, I will have to replace the calls like v = self.__class__(v, **self.__box_config()) to take a variable of what the sub-class should be. That way you could set an argument such as box_class to Box so all sub-boxes would take that type instead of an MLBox.
This will kinda tie into #150 where I will need to take careful care of how such inheritance is handled.

No worries then - it looks like i'll just need to leave init alone, and anywhere I instantiated it, I'll just have to have a partner function that I call with all the details. Not terribly Pythonic, but that's ok :)

I am starting to cut pre-releases for 5.0.0, if you are feeling adventurous please test it out and let me know if it solves your issues!
pip install --upgrade "python-box[all]>=5.0.0a0"

Details on the new wiki


fix: DomValidator is overly restrictive for attributes

Description

@schultek I am getting the following server error emitted from DomValidator in an SSR app.
Invalid argument(s): "x-transition:enter" is not a valid attribute name.

This is being produced because I am using Alpine.js to generate some components and it has "non-standard" attributes (at least according to jaspr validator)
https://alpinejs.dev/directives/transition#applying-css-classes

    <button @click="open = ! open">Toggle</button>

Hello 👋

Doctor Output
Using the latest main branch revisions of all jaspr apps.
Discussion
Line in question:
https://github.com/schultek/jaspr/blob/a6fbb30d95362723304cded037eb6f22212110bf/packages/jaspr/lib/src/server/markup_render_object.dart#L165
The following modification should resolve the issue:
  static final _attributeRegExp =
      RegExp(r'^[a-z](?:[a-zA-Z0-9\-_:]*[a-z0-9]+)?$');

This modification permits the inclusion of colons within the string while maintaining the requirement that the string must start with a lowercase letter and optionally end with a lowercase letter or a digit, assuming there are characters following the initial letter.

@schultek out of curiosity, any reason this attribute validation only happens on the server? What is the protection for here? Just to protect from sending malformed HTML to the client?


bower.json

Unable to use module using bower. After fixing bower.json it works fine.
from: "main": "src/angular-piwik.js",
to: "main": "build/angular-piwik.js",

You're right ! Thank you for opening this issue.


Add Info

Description:
describe your pr here
Tasks:

[ ] Build CI Runs
[ ] Code Analysis up to standards

Tank you, but you first have to merge the new develop into your fork, before creating new commits, to avoid merge conflicts. Have a look at #26 to see what I mean.

@leonlatsch Done. I changed pic upload site as I dislike spreading political belief online.


Some bites not downloading

I've had no issues for many bites. Now just today bite 257 and 270 failed to download. 262 successfully downloaded in between these two.

Now I'm wondering if it's something to do with me. 278 would also not download today. Missing ZIP archive. :(

Workaround: Create the folder and files (named as they are named on the site) and they will submit properly when  you're done

I just attempted to download bite 257 and got the same thing. I copied the link address and saw the url pointing to the zip archive contains the wrong bite number, but downloads the correct bite. That looks like an issue that has to be fixed on @bbelderbos's end.
For now, manually downloading and keeping the naming convention should still let you submit via eatlocal until we can get it resolved. I'll message Bob in the slack and see how he wants to proceed/track the problematic bites.
Have you had any other bites that you are unable to download?

Great catch, thanks @Se7enSquared.
This was a bug with how the eatlocal endpoint on our platform tried to match the Bite object by the number provided.
It should work now as demonstrated below:
(venv) √ eatlocal (main) $ python -m eatlocal download 270
https://codechalleng.es/bites/api/eatlocal/270
Extracted bite 270 @ /Users/bbelderbos/code/eatlocal/270
(venv) √ eatlocal (main) $ lt 270
total 32
-rw-r--r--  1 bbelderbos  staff   387B Apr 12 14:58 README.md
-rw-r--r--  1 bbelderbos  staff   471B Apr 12 14:58 bite.html
-rw-r--r--  1 bbelderbos  staff    42B Apr 12 14:58 freq.py
-rw-r--r--  1 bbelderbos  staff   279B Apr 12 14:58 test_freq.py

Thanks @bbelderbos! I'm going to close this issue.

Yw, let me know if any issues. I think it should all work as expected now (I tested quite a few).
The only thing is for Newbie Bites you would use the id (primary key), not the Newbie Bite sequence number, did you try those?

I have never tried Newbie Bites with eatlocal. There isn't an option on the site to solve them offline. I just double checked and there is an option for the intro bites which are bites 101-110.
I think it makes sense to not worry about solving the newbie bites locally. Just the bites themselves are challenging enough let alone worrying about setting up chromedriver and learning git.

OK thanks, then I think we're good, Intro Bites work with their ids:
$ python -m eatlocal download 109
https://codechalleng.es/bites/api/eatlocal/109
Extracted bite 109 @ /Users/bbelderbos/code/eatlocal/109


Add equipment type "any"

Sometimes I don't care about the gears' type, I just want the proper affixes & aspects.

Add equipment type "any"
Add setting "UseAny".
When "UseAny" is checked,will ignore the type of equipment, to compare affixed & aspects saved in the "any" type

Thank you for the pull request but I would like to hold off with the merge for now. Working on a new GUI for affixes.
I'll add some comments in changes if you would like to improve it for yourself.
When the new GUI is ready we can look into how we can make an Any category.

That was everything for now.
Just started gathering the required data from the game files for the new GUI so it can still take a while. Maybe 1-2 weeks from now.

Thank you for the pull request but I would like to hold off with the merge for now. Working on a new GUI for affixes. I'll add some comments in changes if you would like to improve it for yourself.
When the new GUI is ready we can look into how we can make an Any category.

Thanks for the reply. It's completely fine to not merge this. I'm glad the "any type" thing is under radar. Looking forward to the new updates!


Account Creation - Step 3 (Wallet)

Summary:
As a new user I would like to be able to create a profile inside the DHO.
Acceptance Criteria:

[ ] Headline
[ ] Description Copy
[ ] BTC icon, Address Field, Toggle to make BTC preferred payment method, Help text with link to documentation
[ ] ETH icon, Address Field, Toggle to make BTC preferred payment method, Help text with link to documentation
[ ] EOS icon, Memo Field, Address Field, Toggle to make BTC preferred payment method, Help text with link to documentation
[ ] Next Button

Design:
https://xd.adobe.com/view/27bc7fff-1845-449c-913a-4ecfb3c9461c-72ef/screen/3e5fe52c-f34f-4089-a005-d0c2b57cd1de

@arsenijesavic this step should not be mandatory. you can leave all 3 fields empty. Can you update that please?

@arsenijesavic this step should not be mandatory. you can leave all 3 fields empty. Can you update that please?

@leonieherma1 Done ✅ ! https://github.com/hypha-dao/dho-web-client/commit/30e7274bcaa718157d7e77132ac68ccba294a723


Set umask in linux_test.go

Hi there.  This particular test fails in my environment as my umask is set to 0022.  This patch sets the umask for the test to be something that will allow the test to pass.

This is not really the best fix for the problem.  Setting umask in the code is kind of a no-no.  I think the problem is actually that the tests are trying to create a directory with too lax permissions... all they need is 0600, and they're getting created with 0777: https://github.com/natefinch/lumberjack/blob/v2.0/lumberjack_test.go#L638
So, I think just changing that code to use 0600 should fix it for you.  You're welcome to give it a try, or I will when I get a few minutes.

Would be great to get this test fixed as it currently fails builds for me also.

crud, thanks for pinging me about this. I'll get it fixed ASAP.