Fix: Handle HttpClient Interruption on connection close

…ssage in case the netty chanel is getting closed due to a unhandled exception

Codecov Report

Merging #1039 (3557ea3) into main (9f2fa84) will increase coverage by 1.34%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   57.01%   58.36%   +1.34%
==========================================
  Files          73       75       +2
  Lines        2261     2805     +544
  Branches       62       72      +10
==========================================
+ Hits         1289     1637     +348
- Misses        972     1168     +196

Impacted Files
Coverage Δ

...la/zhttp/service/client/ClientInboundHandler.scala
85.71% <50.00%> (ø)

...io-http/src/main/scala/zhttp/service/Handler.scala
72.72% <0.00%> (-7.28%)
:arrow_down:

.../main/scala/zhttp/http/headers/HeaderGetters.scala
28.37% <0.00%> (-3.59%)
:arrow_down:

...http/service/server/ServerChannelInitializer.scala
92.85% <0.00%> (-0.90%)
:arrow_down:

...io-http/src/main/scala/zhttp/http/PathModule.scala
77.35% <0.00%> (-0.77%)
:arrow_down:

...main/scala/zhttp/http/headers/HeaderModifier.scala
14.52% <0.00%> (-0.77%)
:arrow_down:

zio-http/src/main/scala/zhttp/service/Server.scala
45.53% <0.00%> (-0.62%)
:arrow_down:

zio-http/src/main/scala/zhttp/http/Status.scala
100.00% <0.00%> (ø)

...c/main/scala/zhttp/service/server/ServerTime.scala
33.33% <0.00%> (ø)

zio-http/src/main/scala/zhttp/html/Template.scala
100.00% <0.00%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2fa84...3557ea3. Read the comment docs.


Receive message in the same window

Hello, is it possible to support receiving message in the same window? I'm looking at a scenario where a browser window also receives the same message that it sends/broadcasts out. Thank you!
This workaround seems to work OK.
https://stackoverflow.com/questions/47543856/does-broadcastchannel-work-on-the-same-page

By default, this is standard behavior the connection send message to other contexts. This is how localStorage and broadcastChannel work. There was a bug in IE that was sending the message to itself.
I think it will be very easy to create you don't need any workaround with two broadcast Channels (that BTW will probably be broken if you open 10 tabs). You only need to call a function that was registered in same window.
Peduo code
sysend.broadcast = function(event, data) {
  sendData(event, data);
  callSelf(event, data);
};

I can work on this, but I need to came up with nice API that will fit with correct code.

There is no place for options with current API, but I can name the function emit that will also send to self.

Sounds like a plan. Thank you!

The API was added in version 1.5.0

Thanks for making it happen so efficiently. Awesome!


[TableRow] Fix persistent background when clicked

Fixes https://github.com/callemall/material-ui/issues/6262

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@sajal50 Thanks 😄

😊


Fix Select not opening when unmountOnHide is true

Closes #3147
When the select popover was mounted by default, the external/context store was only initialized as part of the internal store, not the host/provider component. As a result, if the popover were unmounted, it would be destroyed, leaving the external/context store uninitiated.
This PR modifies the store logic to enable a store to be initialized again before it's destroyed.

Hey @diegohaz, thanks for the quick fix.
I was wondering, if we have any plans for releasing this fix? It seems like this issue is quite critical.


CHORE: Bump release 0.35.dev0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.48%. Comparing base (faf9064) to head (14d85dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   82.48%   82.48%
=======================================
  Files         160      160
  Lines       20987    20987
=======================================
  Hits        17311    17311
  Misses       3676     3676

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


python311Packages.angr: 9.2.133 -> 9.2.134

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

x86_64-linux

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:white_check_mark: 20 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.claripy
python312Packages.claripy.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.claripy
python313Packages.claripy.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist

nixpkgs-reviewd workflow started
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12495774179

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12495774179
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

x86_64-darwin

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:x: 4 packages failed to build:

python312Packages.claripy
python312Packages.claripy.dist
python313Packages.claripy
python313Packages.claripy.dist

:white_check_mark: 16 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

aarch64-darwin

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:x: 4 packages failed to build:

python312Packages.claripy
python312Packages.claripy.dist
python313Packages.claripy
python313Packages.claripy.dist

:white_check_mark: 16 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

x86_64-linux

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:white_check_mark: 20 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.claripy
python312Packages.claripy.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.claripy
python313Packages.claripy.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist

Claripy had empty logs somehow

nixpkgs-reviewd workflow started
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12496274287

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12496274287
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

x86_64-darwin

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:x: 4 packages failed to build:

python312Packages.claripy
python312Packages.claripy.dist
python313Packages.claripy
python313Packages.claripy.dist

:white_check_mark: 16 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

aarch64-darwin

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:x: 4 packages failed to build:

python312Packages.claripy
python312Packages.claripy.dist
python313Packages.claripy
python313Packages.claripy.dist

:white_check_mark: 16 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368085

x86_64-linux

:fast_forward: 6 packages marked as broken and skipped:

python312Packages.angr
python312Packages.angr.dist
python312Packages.angrcli
python312Packages.angrcli.dist
python312Packages.angrop
python312Packages.angrop.dist

:white_check_mark: 20 packages built:

python312Packages.ailment
python312Packages.ailment.dist
python312Packages.archinfo
python312Packages.archinfo.dist
python312Packages.claripy
python312Packages.claripy.dist
python312Packages.cle
python312Packages.cle.dist
python312Packages.pyvex
python312Packages.pyvex.dist
python313Packages.ailment
python313Packages.ailment.dist
python313Packages.archinfo
python313Packages.archinfo.dist
python313Packages.claripy
python313Packages.claripy.dist
python313Packages.cle
python313Packages.cle.dist
python313Packages.pyvex
python313Packages.pyvex.dist


Added the 6d contact model + updated the bipedal example + benchmark for quadruped and biped - [merged]

In GitLab by @cmastalli on Aug 29, 2019, 14:07
Merges topic/contact-6d -> cpp_devel
In this PR, I solved the following issues #230, #234 and #235. I have additionally solve a bug in the DDP solver (i.e. Vxx symmetric).

In GitLab by @cmastalli on Aug 29, 2019, 14:15
added 2 commits
58cbdaac - [format] Removed useless variable5063447a - [benchmark] Removed soft-link
Compare with previous version

In GitLab by @cmastalli on Aug 29, 2019, 14:16
enabled an automatic merge when the pipeline for 5063447ae2ed1de0b1e71da53779b1ab8676a59b succeeds

In GitLab by @cmastalli on Aug 29, 2019, 14:27
merged

In GitLab by @cmastalli on Aug 29, 2019, 14:27
mentioned in commit 0e6565515c06ab551a5d4f2344499af188415d81


[FLINK-20425][runtime] Change exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard

What is the purpose of the change
FatalExitExceptionHandler and JvmShutdownSafeguard use the same exit code (-17), making it impossible to distinguish the cause of an unexpected Flink JVM exit based on the exit code alone.  Enum ExitCode should be introduced that defines all possible exit codes in Flink. The exit codes are different for FatalExitExceptionHandler and JvmShutdownSafeguard.
Brief change log

Add ExitCode enum to indicate the associated process exit code.
Change the exit code in FatalExitExceptionHandler to be different from JvmShutdownSafeguard.

Verifying this change
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I'm closing this PR because of inactivity and it having diverged from the code-base.

I'm closing this PR because of inactivity and it having diverged from the code-base.


Implement "Active Mode" in DP

As part of this task, please implement functionality defined in the spike, to handle a new TR069 device and initiate communication with SAS on its behalf.
Please also include additions to existing python services (like extension of RC API, etc)
Also please revise the existing stories/tasks that are already on the board regarding Active Mode, and connect them to this issue as possible subtasks/clarifications.

worklog: https://docs.google.com/document/d/1BVzCU7ymE2rFUzZaYzBT4aAltC4L0a0-c4TNK2oh46s/edit


Drop down menu hard to read in dark mode

Describe the bug
The drop down menus in dark mode have a white background and light grey font making it hard to read.
To Reproduce
Steps to reproduce the behavior:

Go to https://www.openweightlifting.org/
Tilt the theme rocker switch to dark mode (moon symbol)
Expand Federation drop down menu
Try reading names

Expected behavior
The background of the drop down menu should follow the theme's background color
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 22
Browser Chrome
Version  104.0.5112.79 (Official Build) (64-bit)

@EdBuilds - We'll add it to the backlog.

@euanwm hiya please assign this to me

hey @EdBuilds can you assign this issue to i can work on it

@EdBuilds i was able to fix the issue. Can I be assigned ? The result is shown in the attached image.


Fix looseMatches is undefined error

Overview
This PR adds an empty array fallback when initializing the variable looseMatches in the decentLocaleMatch function, to prevent it from having the undefined value.
How to test/reproduce
Before this fix:

Open the dummy app
Set the browser locale to an unsupported language (e.g. french)
Observe the looseMatches is undefined error

After this fix:

Open the dummy app
Set the browser locale to an unsupported language
The error should no longer show up, the language shown is the default language (english)

Argh, it's been a while since this one got me. Damn Record<string, T> types. I don't think a typescript flag exists for this and I don't know of an eslint rule... I should also not make last minute tweaks and not re-test everything...

no worries :)
I think adding "noUncheckedIndexedAccess": true to the tsconfig.json might help.


feat(axios): Add route pre hook that provides axios client to request

Adds axiosFactory method with interceptors for errors that add helpful custom data that we use within our services.
Adds exported addAxiosRoutePreHook that will provide request.pre.axios on the route handler
Adds exported addAxiosRoutePreHookFactory that will provide request.pre.<input alias> on the route handler
Updated README

Example route prehook
const { addAxiosRoutePreHook } = require('@goodwaygroup/lib-hapi-good-tracer');

const routes = [{
    method: 'GET',
    path: '/proxy/google',
    config: {
        tags: ['proxy'],
        pre: [ addAxiosRoutePreHook ]
    },
    handler: async (request) => {
        const { axios } = request.pre;
        return axios.get('https://google.com')
    }
}];

exports.routes = server => server.route(routes);

Pull Request Test Coverage Report for Build 58c2fcb2-9fb7-4039-b3dc-bae52c21155d

28 of 28 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 76b0145e-d4a0-4859-a2b6-f7f199017503:
0.0%

Covered Lines:
94

Relevant Lines:
94

💛  - Coveralls

Fixes #6


Failed to pack sql to nxd

Hi,
Thanks for the quick release of the new version.
But with new version, I encountered an error when packing sql database into nxd file. Error message is
[00:08:59] [Fatal] Unable to import from SQLite System.IO.InvalidDataException: Column 'AccessHoldParamId' for table 'access' does not exist in sqlite table
   at FF16Tools.Files.Nex.Exporters.SQLiteToNexImporter.FillTables() in C:\Users\nenkai\source\repos\FF16Unpacker\FF16Tools.Files\Nex\Importers\SQLiteToNexImporter.cs:line 131
   at FF16Tools.Files.Nex.Exporters.SQLiteToNexImporter.ReadSqlite() in C:\Users\nenkai\source\repos\FF16Unpacker\FF16Tools.Files\Nex\Importers\SQLiteToNexImporter.cs:line 56
   at FF16Tools.CLI.Program.SqliteToNxd(SqliteToNxdVerbs verbs) in C:\Users\nenkai\source\repos\FF16Unpacker\FF16Tools.CLI\Program.cs:line 420

It seems it is due to similar error before that it is refering your windows username "C:\Users\nenkai"
Thanks,

And for example if I try to pack "euipitem" table into nxd, it returns an error:
[09:42:01] [Fatal] Unable to import from SQLite System.IO.InvalidDataException: Column 'DLCFlags' for table 'equipitem' does not exist in sqlite table
   at FF16Tools.Files.Nex.Exporters.SQLiteToNexImporter.FillTables() in C:\Users\nenkai\source\repos\FF16Unpacker\FF16Tools.Files\Nex\Importers\SQLiteToNexImporter.cs:line 131
   at FF16Tools.Files.Nex.Exporters.SQLiteToNexImporter.ReadSqlite() in C:\Users\nenkai\source\repos\FF16Unpacker\FF16Tools.Files\Nex\Importers\SQLiteToNexImporter.cs:line 56
   at FF16Tools.CLI.Program.SqliteToNxd(SqliteToNxdVerbs verbs) in C:\Users\nenkai\source\repos\FF16Unpacker\FF16Tools.CLI\Program.cs:line 420

Would you please help on this?
Thanks,

My apology. It seems after using latest tool release, and unpack the nxd.
The error is gone.
This ticket can be closed.

problem solved by latest release


[Request for comment] Update gemspec to not support Ruby 2.4.0

I was able to install fastlane in Ruby 2.4.0 using the source code, but I'm unsure if everything is fixed already. This should be merged if we really don't support 2.4.0
I'm not sure how to best test this tbh

I'm unsure if everything is fixed already

what do you mean by that? Was there any breakages during the upgrade to 2.3.?
I think that everybody upgrading the runtime platform should be aware of the risks.
I see 2 issues applyinh this:

it will prevent users from installing newer versions of fastlane and testing for potential issues
not sure if this change is retroactive or not (i.e. affects the whole gem or that particular version). If it affects the version, it might restrict users of ruby 2.4 to download fastlane version 2.9.0 or earlier. Causing more problems.

Sounds legit, let's close it. There was an issue with the JSON gem, but it was fixed according to @orta 👍


Add HZ_PROFILE_FUNCTION()?

In the recent commits, it seems that we did not use HZ_PROFILE_FUNCTION() for a long time. Do we need to add it in the functions we create in the new .cpp files?

Yes and no, Yes we should provide the ability to profile the engine, however performance is only of interest during the runtime (starting from loading a game, playing the game and closing the game), this does not include the stuff inside hazelnut. But we might have to review parts of the scene and so on, as that might require profiling during runtime. Since we're actively developing it, I might suggest to hold off on that just yet, once we have the scene stuff wrapped up, it might be more of interest to see where this is required exactly

Thx, bro.


[SPARK-46249][SS] Require instance lock for acquiring RocksDB metrics to prevent race with background operations

What changes were proposed in this pull request?
Require instance lock for acquiring RocksDB metrics to prevent race with background operations
Why are the changes needed?
The changes are needed to avoid races where the statefulOperator tries to set storeMetrics after the commit and the DB instance has already been closed/aborted/reloaded.
We have seen a few query failures with the following stack trace due to this reason:
        org.apache.spark.sql.streaming.StreamingQueryException: Job aborted due to stage failure: Task 3 in stage 531.0 failed 1 times, most recent failure: Lost task 3.0 in stage 531.0 (TID 1544) (ip-10-110-29-251.us-west-2.compute.internal executor driver): java.lang.NullPointerException
	at org.apache.spark.sql.execution.streaming.state.RocksDB.getDBProperty(RocksDB.scala:838)
	at org.apache.spark.sql.execution.streaming.state.RocksDB.metrics(RocksDB.scala:678)
	at org.apache.spark.sql.execution.streaming.state.RocksDBStateStoreProvider$RocksDBStateStore.metrics(RocksDBStateStoreProvider.scala:137)
	at org.apache.spark.sql.execution.streaming.StateStoreWriter.setStoreMetrics(statefulOperators.scala:198)
	at org.apache.spark.sql.execution.streaming.StateStoreWriter.setStoreMetrics$(statefulOperators.scala:197)
	at org.apache.spark.sql.execution.streaming.StateStoreSaveExec.setStoreMetrics(statefulOperators.scala:495)
	at org.apache.spark.sql.execution.streaming.StateStoreSaveExec$$anon$2.close(statefulOperators.scala:626)
	at org.apache.spark.util.NextIterator.closeIfNeeded(NextIterator.scala:66)
	at org.apache.spark.util.NextIterator.hasNext(NextIterator.scala:75)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4.hashAgg_doAggregateWithKeys_0$(Unknown Source)
	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4.processNext(Unknown Source)
	at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
	at org.apache.spark.sql.execution.WholeStageCodegenEvaluatorFactory$WholeStageCodegenPartitionEvaluator$$anon$1.hasNext(WholeStageCodegenEvaluatorFactory.scala:43)
	at org.apache.spark.sql.execution.datasources.v2.WritingSparkTask.$anonfun$run$1(WriteToDataSourceV2Exec.scala:498)
	at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1743)
	at org.apache.spark.sql.execution.datasources.v2.WritingSparkTask.run(WriteToDataSourceV2Exec.scala:552)
	at org.apache.spark.sql.execution.datasources.v2.WritingSparkTask.run$(WriteToDataSourceV2Exec.scala:482)
	at org.apache.spark.sql.execution.datasources.v2.DataWritingSparkTask$.run(WriteToDataSourceV2Exec.scala:557)
	at org.apache.spark.sql.execution.datasources.v2.V2TableWriteExec.$anonfun$writeWithV2$2(WriteToDataSourceV2Exec.scala:445)
	at org.apache.spark.scheduler.ResultTask.$anonfun$runTask$3(ResultTask.scala:82)
	at com.databricks.spark.util.ExecutorFrameProfiler$.record(ExecutorFrameProfiler.scala:110)
	at org.apache.spark.scheduler.ResultTask.$anonfun$runTask$1(ResultTask.scala:82)
	at com.databricks.spark.util.ExecutorFrameProfiler$.record(ExecutorFrameProfiler.scala:110)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:62)
	at org.apache.spark.TaskContext.runTaskWithListeners(TaskContext.scala:196)
	at org.apache.spark.scheduler.Task.doRunTask(Task.scala:181)
	at org.apache.spark.scheduler.Task.$anonfun$run$5(Task.scala:146)
	at com.databricks.unity.EmptyHandle$.runWithAndClose(UCSHandle.scala:125)
	at org.apache.spark.scheduler.Task.$anonfun$run$1(Task.scala:146)

Does this PR introduce any user-facing change?
No
How was this patch tested?
Modified existing unit tests
[info] Run completed in 1 minute, 31 seconds.
[info] Total number of tests run: 150
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 150, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

Was this patch authored or co-authored using generative AI tooling?
No

cc - @HeartSaVioR - PTAL, thx !

This only failed in docker integration test suite which is unrelated.

Thanks! Merging to master.


Set all builds to have UPNP disabled by default

this at least builds in gitian (1 hour) and partly addresses #264

Why would you want upnp disabled by default? I think this will just cause problems for normal users...

https://github.com/PaycoinFoundation/paycoin/issues/264
You'll find that even though they've updated the UPNP version for bitcoin they have disabled it be default on bitcoin as well to avoid possible issues like the above mentioned in the future.

Does disabling UPNP require users to perform additional steps, such as adding excepts to their firewalls and opening ports on their routers?

Possibly in some cases, otherwise they may not need to as that will only effect incomming connections. A wallet can function with nothing but outgoing connections (I've done that with a few daemons at different points).
If a user finds they have issues with the connections with UPNP disabled they can either open ports or enable UPNP in their conf or when starting the wallet. This doesn't remove UPNP it just changes it from being Opt-Out (which is potentially unsafe) to being Opt-In (requiring at least some minor education and responsibility on the users part).

We've had scenarios in support where we have had to help or direct users to open their firewall ports even when UPNP enabled. If it's still going to only impact the occasional or a small % of users it makes sense to set the default to UPNP disabled.
I'd rather see something a little more inherently secure be the default and it require a user action to change that status.

This has been rebased over master do to merge conflicts

utACK to making it disabled by default


Reconcilation and Active sync

From<EMAIL_ADDRESS>on January 18, 2011 16:29:39
Must be implemented reconciliation and active sync
Original issue: http://code.google.com/p/syncope/issues/detail?id=73

From chicchiricco on January 20, 2011 00:32:38
Summary: Reconcilation and Active sync

From chicchiricco on April 11, 2011 03:38:01
Labels: Milestone-Release-2011Q2

From chicchiricco on April 12, 2011 09:27:51
Labels: -Milestone-Release-2011Q2 Milestone-Release-201112

From chicchiricco on July 27, 2011 02:49:36
Status: Started
Owner: chicchiricco

From chicchiricco on August 22, 2011 03:03:53
Also consider Sync (conflict resolution) policy.

From chicchiricco on August 24, 2011 01:07:25
Blockedon: 146

From chicchiricco on September 01, 2011 07:50:42
Blockedon: 132

From chicchiricco on September 19, 2011 04:46:07
Blockedon: 164

From chicchiricco on September 19, 2011 05:00:06
About Synchronization policy, a "correlation" must be defined in order to let Syncope match users on the resource with internal users.
Once such match is found, the policy must specify what to do ("ignore", "merge", "delete on resource", "delete on Syncope", ...).
Blockedon: 165

From chicchiricco on September 19, 2011 05:02:38
Blockedon: 166

From<EMAIL_ADDRESS>on November 10, 2011 06:28:35
Owner<EMAIL_ADDRESS>

From<EMAIL_ADDRESS>on November 14, 2011 04:09:07
This issue was closed by revision r1246 .
Status: Fixed


react-redux Provider error

What version of React, ReactDOM/React Native, Redux, and React Redux are you using?

React: 18.2.0
ReactDOM/React Native: 18.2.0
Redux: using redux toolkit
React Redux: 8.0.5
@reduxjs/toolkit: 1.9.1

What is the current behavior?
I'm using Next.js, Redux-toolkits, React-redux all are in the latest versions.
After importing Provider from react-redux
import { Provider } from "react-redux";
it gives this error in my VS Code terminal (I'm using SSR)-
error - C:\Users\Shatadal Das\Desktop\My All Program Files\NEXT\my-blog-website\node_modules\react-redux\es\exports.js:1
import Provider from './components/Provider';
^^^^^^

SyntaxError: Cannot use import statement outside a module

I've the default tsconfig file, generated by create-next-app
What is the expected behavior?
Didn't expected any like that to happen.
Which browser and OS are affected by this issue?
No response
Did this work in previous versions of React Redux?

[ ] Yes

This appears to be some kind of an issue with Next and its build/import configuration somehow.  I don't know why it would be having a problem, but we know that the current published package  configuration works correctly.  So, I'd recommend filing an issue with the Next repo.


Added Python Weather Scraping project

This is my Hacktoberfest contribution.
I have followed all the steps, mentioned in the Contribution guidelines.

Merging, Star the repo if you like it.


Fixes

+1 for the series.
But what about the problem caused when the button sends a false as soon as it starts? Is it fixed?

Thanks.
The problem was already fixed, The fix is in the commit 8d156efad81a9678a7e0c00b1e7d565a1cbcce98


Allow multiple views to show at the same time

Would be nice to be able to have both a left and right sidebar i,e file tree in left and VSC in right.
Kinda vibing off the multi panel layout of atom with github / git integration
Something like this

I was going to open an issue for that. It would be very handy for the Code Outline extension.

Multi-sidebar setups would be awesome, especially now with the Code Outline and GitLens 5.0+ Extensions!

Was just wishing for the same :)

+1

While I'd like to see two sidebars, I would like much more a tiled window manager like in Eclipse IDE.

+1

I want this because I want some panes on a right sidebar and the rest on the left sidebar...

It's hard to see the code outline while also navigating my file tree.

Going to post my mockup from https://github.com/Microsoft/vscode/issues/45283 as well:

+1

+1

+1

+1

+1

Everybody, who adds redundant +1 comments. Please don't.
This will lead only to other people will unsubscribe from this and/or this issue will be locked out from comments. Both things are bad for the further development of this issue.
Please, consider adding :+1: to the original description. Just click the icon.
Thank you!

+1

Hi there, I was just wondering, are there any (distant) plans on implementing this?

Giving that extensions now can create its own buttons and explorer panel, this would be a big deal for us as users.

I think 4+ viewlet icons on the left(or right if configured) is what gives vscode the "Iconic" look. Even if two viewlets are enabled, one on left another on right, I think only one side should have the icons. The other side can have text only vertical tabs. And then it can be configurable to enable icons on both side, or text on both side.

Any progress on that? Generalizing the great new grid layout to manage all components, including viewlets, is the one thing I am really missing on VSCode. File and code browsing, git, debugging - all would be much easier without having to switch the viewlets every time. I strongly suggest looking at Atom as inspiration. It's nearly perfect.

Another example position could be:

As #49755 has been closed for being a duplicate, which isn't, we may need to discuss first if we should introduce a second activity bar.
The activity bar is the column of icons, shown at the left of the sidebar by default.
I suggest to introduce a second activity bar. Icons in the activity bar are already movable by the user. We can allow the user to move icons to the second activity bar on the right, which can become visible while holding an icon (keeping the mouse button pressed). Each clicked icon can show up in its respective sidebar. So clicking an icon in the left activity bar will open the element in the left sidebar; clicking an icon in the right activity bar will open the element in the right sidebar.
Both the right sidebar and activity bar could be hidden by default, only showing up while moving icons to not force the user to use it and reduce clutter.
What do you think?

+1

I think the activity bar should only be on the left. That way you can right click on an icon to open the view on the right side.

@nealot That is an interesting suggestion. Could work and would be flexible if you want to have the views on different sides often. But I can also imagine that users might not even try right-clicking the icons. Or me just clicking on it, without thinking about the mouse button I should press. Touch users might need another way to open it on the right side as well.

@gersilex

But I can also imagine that users might not even try right-clicking the icons. Or me just clicking on it, without thinking about the mouse button I should press.

Currently, to hide an activity bar icon you must use the context menu -- why would this action be any different? Although I do think this should be supplemented by a drag-and-drop functionality.

Touch users might need another way to open it on the right side as well.

As I mentioned above, I think drag-and-drop would be beneficial here. I use a touchscreen and while the context menus aren't unusable, they are difficult to work with.
Having two activity bars not only looks pretty uncomfortable, but it also wastes a lot of screen space; I'm completely against the idea of adding it.

@nealot

this should be supplemented by a drag-and-drop functionality
Completely agree here.

Currently, to hide an activity bar icon you must use the context menu
I think I misunderstood your first comment. I thought you wanted the view to open instantly, without showing a context menu. The idea with the context menu sounds good, though.

So we would add another entry to the context menu of the icons. Should the entry be for toggling the location (like Pin to right activity bar)? That sounds good to me.
Talking about drag-and-drop. We could also just drag the view to the right and display the right sidebar. This would comply with the look-and-feel of the editor windows and the grid. Maybe we can do both.
I do not insist in using a second activity bar at all. You got a strong point there and I agree that we should not introduce a second activity bar.

@gersilex My bad, I should have worded my original comment better. I like your idea about toggling the position.
Maybe we could do something like this:

User right clicks on an icon
Selects context menu option Pin to right
Clicking on the icon from that point on opens it on the right
Option changes to Pin to left

Hi there, is there any development going on in this area? Perhaps there is a similar feature already being worked on? If that is the case I would appreciate if someone could provided related tickets pleae. From the UI point of view this is the biggest issue for me right now.

Code Outline really needs it's own window. Having Explorer and Outline open at the same time is really the best way to navigate Quick in the Code. I would even say, drop the minimap and put the outline there (or on the left side ;-)
Since a few years, the most common screen format is 16:9 with more horizontal space than vertical space, but source code did not grow horizontal, so more screen space is wasted with a lot of whitespace on the right side of the editor.

Curious what the status of this is. It seems really overly opinionated to force all of these elements into one pane. IntelliJ handles this much better, modularizing each component into its own pane that can be moved wherever.

@bpasero do you guys have any plans for this?

Adding my desire for this feature, I'm trying to use vs-code in a vertical monitor setup, and it would be neat to have the freedom to stack the panel, activity bar, and view (sidebar?) on the bottom of the screen. This would give me all of the horizontal space for editing, and move all of the "extra" stuff above or below. Obviously not all of the views will behave as well/effectively in a short and wide widget, but that's my problem to deal with I think :P

@matthewess I wouldn't hold my breath. They have loads of other requests and bugs to fix and perhaps this one would require quite a lot of work. However, we don't know any of it for sure as there has been a dead silence from the devs about it. If I am not mistaken there isn't a single comment from any VSC developer since when the request was created, which is over 2 years ago. .

Specifically regarding the sidebar, this is what I would like to achieve:

YES! I'd like to be able to do that as well.

I miss this for debugging. I have a very wide monitor, but not so high (5120x1440). However I can't double up the debug sidebar, needing constant scrolling and most of my screen space just being wasted.  I easily would have the real estate for 10 sidebars, but I can't reorganize anything other than collapsing things.

I would like to also point that users who use monitor in portrait mode (vertical), would also benefit from a "Sidebar" that is not on the side (as space to the side is limited), but instead being able to configure sidebar to open top or bottom (a.k.a., splitting the editor and the sidebar vertically). When I have to make a complex search or debug, I have to change vscode to a landscape monitor, and when done, move it back to the portrait monitor. I understand that detachable windows for sidebar is complex to implement, but perhaps this here would not be easier in the short term.

I very happily using and loving Intellij's approach of preserving the core of your perspective whether you are writing, analyzing, or debugging. I cannot really achieve that without multiple sidebars at the moment. Having to switch between explorer, tools, and debugging info is a real pain.

Intellij is an IDE. This is a text editor. That's like comparing a Chevy and a Mustang because you can take a ride in both.

But Atom has the feature, and it's also just a text editor.

From: Michael De Abreu<EMAIL_ADDRESS>Sent: Thursday, April 2, 2020 1:28:25 PM
To: microsoft/vscode<EMAIL_ADDRESS>Cc: b-fuze<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] Allow multiple views to show at the same time (#26777)
Intellij is an IDE. This is a text editor. That's like comparing a Chevy and a Mustang because you can take a ride in both.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/26777#issuecomment-607985051, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACQEV7PY2T43BFI3KMSXYDDRKTDLTANCNFSM4DLUT4IA.

As I already mentioned in #92786 (comment), another good inspiration is Theia, which uses the same concept and extensions as VSC.

Intellij is an IDE. This is a text editor. That's like comparing a Chevy and a Mustang because you can take a ride in both.

The same killer argument as always. Please draw the line between an IDE and an editor, especially when it comes to the UI. What is missing to make VSC a "real" grown up IDE? Maybe we should apply duck typing for the definition of IDEs and editors.
Thea looks interesting.

@bpasero, @sbatten
https://github.com/Microsoft/vscode/issues/10121#issuecomment-345497635
About "isolated context" and Electron...
Just add a one new panel, "additional panel" (for example) and add item "move to Additional panel" to the "right-click" menu, such as already implemented "move to Panel" for "outline", "variables" and others (workbench.action.moveFocusedView and others, couldn't find a link to the function's implementation, but I hope you'll understand).
In this case, it doesn't require to share the same memory to the "main" window.
It's lightweight.
p.s. Everyone will be happy, especially the users of the wide and two monitors.
And yes, thank you for your work!

Will this be added? If so, any eta?

Perhaps we need a new widget/component/control to this. Visual Studio essentially uses the TableLayoutPanel from .NET. It might be worth the effort to port that over to Web.
If you need UI guidance, you can look at Visual Studio:

Funny.
Just had an ear-bashing from a colleague about browser based apps being the way of the future.
I'm slightly dubious since they seem unable to cope with bleeding edge UI features like dockable windows and toolbars?

I miss having everything in one view. In Atom you can open files, edit them, and commit changes, without switching to different views. That workflow is way more superior to what vscode offers when you need to make small changes that require frequent commits.

This is certainly the missing link to making VSCode feel less like a toy and more like a grown up editor.
VS Studio, Unity, ItelliJ all allow you do dock multiple panels, in any configuration you need, customizing your workspace and use the full size of your display.
Working on VSCode on an Ultra-wide feels a bit silly with one small 400px menu hiding 8 pages of data, and no way to view more than one at a time.
It's a shame, because other than this one major flaw, it's really an excellent IDE.

Yes I really want this... I really want to have the option to put say the debugger on the right side visible all the time rather than having to switch view.

At least, the sidebar is mentioned in the "Workbench-Roadmap" for 2020: https://github.com/microsoft/vscode/wiki/Roadmap#workbench

Support a more flexible workbench layout such as allow sidebars on the left and the right. For example, you could have your outline on the right and the file explorer on the left.

I'm brand new to VS Code, so forgive if the following has misperceptions (if it does, please feel free to correct me).
The first thing I wanted to after about 10 minutes of using VS Code (and being very impressed) was the capability to open another sidebar.  So I searched the internet and found this request.... asking for two sidebars. And while that would be far better than one, I'm not sure why it should be limited to just two.
Indeed, in Visual Studio or most any other IDE you can have any view opened and docked somewhere. But in VS Code, many views seemed to be limited to the sidebar, of which there is only one. So I can't, for instance, have search results and the explorer open at the same time. I'm not sure why we wouldn't want to be able to do that in VS Code - that is, to be able to dock any view anywhere we want.

Specifically regarding the sidebar, this is what I would like to achieve:

This is really what I would like to see, too. But I also want to mention that the File Explorer (first icon) has several sub sections like Open Editors and Outline. This is the reason why it's important to be able to open the File Explorer on both sides instead of moving it. So your consideration is right, because it allows to show all files on the left and the outline on the right, which is what I am after.

code outline is hard to use right now...

.@mjbvz: would this be possible for the sidebars with your new api described in #46585

Maybe it's time to include this improvement in the road map?
Please :)

Yes please!

I see that this thread has been going on for over two and a half years, so it's probably a waste of time to even comment here.
Since I am such a procrastinator and am great at wasting my time, I'll go ahead and throw in my two cents and my vote for this feature.
VSC is not a full-fledged IDE, it is a text editor at heart.  As a text editor it is the best text editor you will find, for the price, ever.  It is not a basic, low footprint editor, like Notepad++ is intended to be.  It has all the bells and whistles any text editor could ever have.  It's as advanced as Sublime, but without the $80 price tag.  It far exceeds Atom, which has a huge community base.  While it'll never beat VIM, it leaves all the others in the dust.
I've just starting checking out Komodo, and it looks like it could be a little bit of competition in the Gabteide, or the "Grey Area Between Text Editor and IDE, landscape.
Even though VSC is not a 'real' IDE (whatever that means), it is most certainly an advanced piece of software.  More advanced than any of the other editors listed above.  And you know the one thing it is missing?  It is missing something that all those other editors have.  Even Notepad++ has the ability to do it (though not well implemented).
Multiple Activity Bar Side Panels (not multiple activity bars)  There's absolutely no reason you couldn't get this in there.  There are at least a hundred viable use cases for this feature.
Oh yea, except VIM.  No panels at all in that one.  Nope, none.  Not much UI to speak of.  And you'll still never beat VIM!
Sadly, the lack of this feature will keep VSC at the bottom of my toolbox.  I need to be able to take in a lot of information at once.  Those extra panels allow me to do that, which can be more important than any number of editor features in terms of convenience and efficiency.
Multiple Activity Bar Side Panels (not multiple activity bars) could keep VSC at #2 though, instead of #3, #4 or maybe even #5 (tentative on how Komodo works out for me).
I'd really like to keep you VSC, but when you're only the 5th or occasionally the 4th tool choice for editing my text files, I may as well just uninstall you.

I've been waiting for eons for the second sidebar as described in the 2020 roadmap.
Most monitors are probably operated in landscape view, so there is plenty of space on the sides. I too would love to use the extra sidebar for the outline view, other users for GitLens.
Moving the outliner to the panel and then moving the panel to the side is not really a viable substitution. Since the panel size in this case is probably mostly set to fit a tree view, it's hardly possible to read terminal output in those dimensions. And constantly switching the panel between bottom and right is hardly a usable workflow.
Oh well, there are still 10 days left in 2020, Christmas is coming and I'm still hoping for a miracle.
Merry Christmas, Happy New Year and stay healthy!

@hmcclungiii Remove the false references to the issues #2, #3, #4 and #5, please. If you want to rank VSC, do it without using the # character.

Wow, really disappointing that such an obvious need is not solved.  Modern displays are 1:1.78 aspect ration, which means there is roughly 3/4 more horizontal space than vertical (e.g., 1920x1080).  vscodium is wasting this space by not allowing outlines, which consume a great deal of vertical space, to be put next to other views that also consume a great deal of vertical space.

Wow, really disappointing that such an obvious need is not solved.  Modern displays are 1:1.78 aspect ration, which means there is roughly 3/4 more horizontal space than vertical (e.g., 1920x1080).  vscodium is wasting this space by not allowing outlines, which consume a great deal of vertical space, to be put next to other views that also consume a great deal of vertical space.

If you are complaining that this feature should have been implemented yesterday I suggest you check your expectations. VSCode is made available for free. It's already a fantastic editor, arguably one of the best, and you don't have to pay for it. The devs that are working on it are extremely skilled, and it shows. Good faith feedback is great, but I see a lot of comments here that are rude and seem to come from a perspective of entitlement, I can guarantee you that this has the opposite effect than what you are looking for. Rather than the devs reading this and feeling motivated, it probably makes them less likely to want to work on this feature.

If you are complaining that this feature should have been implemented yesterday I suggest you check your expectations. VSCode is made available for free. It's already a fantastic editor, arguably one of the best, and you don't have to pay for it. The devs that are working on it are extremely skilled, and it shows. Good faith feedback is great, but I see a lot of comments here that are rude and seem to come from a perspective of entitlement, I can guarantee you that this has the opposite effect than what you are looking for. Rather than the devs reading this and feeling motivated, it probably makes them less likely to want to work on this feature.

I think people just want that highly demanded features (like this one) to be taken into account by project managers when making roadmaps, and not lying around for years in the backlog, that's all.

I think people just want that highly demanded features (like this one) to be taken into account by project managers when making roadmaps, and not lying around for years in the backlog, that's all.

I think people just want that highly demanded features (like this one) to be taken into account by project managers when making roadmaps, and not lying around for years in the backlog, that's all.

As I've stated before in this thread: those people should read the project guidelines, and realise that the way to promote their favourite features is not through complaining, but through upvoting. The "comments section" is for adding relevant information, not to act out as if you're confused about the difference between an issue tracker and Twitter.
Meanwhile, everyone trying to follow actual progress on this issue is constantly bombarded with these useless complaints.

I think people just want that highly demanded features (like this one) to be taken into account by project managers when making roadmaps, and not lying around for years in the backlog, that's all.

As I've stated before in this thread: those people should read the project guidelines, and realise that the way to promote their favourite features is not through complaining, but through upvoting. The "comments section" is for adding relevant information, not to act out as if you're confused about the difference between an issue tracker and Twitter.
Meanwhile, everyone trying to follow actual progress on this issue is constantly bombarded with these useless complaints.

If you are complaining that this feature should have been implemented yesterday I suggest you check your expectations. VSCode is made available for free. It's already a fantastic editor, arguably one of the best, and you don't have to pay for it.

This is a peculiar attitude to hold towards OSS. If you build a tool, release it to the world for free, and it becomes so popular as to become integral to the workflow of a significant number of professionals, the maker has gained something very valuable (at the least, influence & goodwill).
The question of price (it's "free") doesn't absolve Microsoft of some responsibility to maintain it, if they still value that goodwill.

The "comments section" is for adding relevant information, not to act out as if you're confused about the difference between an issue tracker and Twitter.

It can be both things.
Look, this is a 3.5+ year old issue. If you don't wish to hear from folks frustrated by its continued lack of attention, you can always unsubscribe (or maybe just ignore 'em).

If you are complaining that this feature should have been implemented yesterday I suggest you check your expectations. VSCode is made available for free. It's already a fantastic editor, arguably one of the best, and you don't have to pay for it.

This is a peculiar attitude to hold towards OSS. If you build a tool, release it to the world for free, and it becomes so popular as to become integral to the workflow of a significant number of professionals, the maker has gained something very valuable (at the least, influence & goodwill).
The question of price (it's "free") doesn't absolve Microsoft of some responsibility to maintain it, if they still value that goodwill.

The "comments section" is for adding relevant information, not to act out as if you're confused about the difference between an issue tracker and Twitter.

It can be both things.
Look, this is a 3.5+ year old issue. If you don't wish to hear from folks frustrated by its continued lack of attention, you can always unsubscribe (or maybe just ignore 'em).

Devs gave an explanation on why this specific task is hard to accomplish: https://github.com/Microsoft/vscode/issues/10121#issuecomment-345497635

Devs gave an explanation on why this specific task is hard to accomplish: https://github.com/Microsoft/vscode/issues/10121#issuecomment-345497635

@mattlubner I'm not going to unsub from this issue, but thanks for your suggestion. I'm subscribed in order to observe good-faith conversations around this issue and any progress that may occur. I stand by what I said, and to clarify, unless you are paying for someone's time you are not entitled to it. That said, as I understand it significant time has already been spent looking into how to achieve this feature. It just so happens that it requires very large and difficult changes. As for conversations about what stakeholders get in value for the privilege of being used in your development workflow, I'm sure that conversation would be fascinating, but this isn't really the venue for it. I think most people subbed to this conversation just want to be notified about this issue specifically, not that someone has a grievance with the development team or management.

@mattlubner I'm not going to unsub from this issue, but thanks for your suggestion. I'm subscribed in order to observe good-faith conversations around this issue and any progress that may occur. I stand by what I said, and to clarify, unless you are paying for someone's time you are not entitled to it. That said, as I understand it significant time has already been spent looking into how to achieve this feature. It just so happens that it requires very large and difficult changes. As for conversations about what stakeholders get in value for the privilege of being used in your development workflow, I'm sure that conversation would be fascinating, but this isn't really the venue for it. I think most people subbed to this conversation just want to be notified about this issue specifically, not that someone has a grievance with the development team or management.

Devs gave an explanation on why this specific task is hard to accomplish: #10121 (comment)

That comment seems specific to multiple Electron windows sharing the same context. Without diving into the source myself, I can't be certain, but it seems unrelated to rendering an additional sidebar within the same Electron window.

Devs gave an explanation on why this specific task is hard to accomplish: #10121 (comment)

That comment seems specific to multiple Electron windows sharing the same context. Without diving into the source myself, I can't be certain, but it seems unrelated to rendering an additional sidebar within the same Electron window.

@RobertWHurst Let's keep this civil. Remember, everyone is coming with their own personal context. No need for confrontation.
I happen to mostly agree with you, especially on a more broad discussion about OSS being fascinating, and that this isn't the proper venue for it. It wasn't my intent above to broach that discussion, but rather to illustrate it isn't without depth/complexity.
No one benefits from the complaining (meta or otherwise), but we have all certainly been there ourselves.

@RobertWHurst Let's keep this civil. Remember, everyone is coming with their own personal context. No need for confrontation.
I happen to mostly agree with you, especially on a more broad discussion about OSS being fascinating, and that this isn't the proper venue for it. It wasn't my intent above to broach that discussion, but rather to illustrate it isn't without depth/complexity.
No one benefits from the complaining (meta or otherwise), but we have all certainly been there ourselves.

Devs gave an explanation on why this specific task is hard to accomplish: #10121 (comment)

@MuellerSeb You seem to assume that floating windows are the only solution to this particular issue. In fact multiple views can be implemented without such requirement. There were some excellent suggestions (even in the very first comment of this issue) how the devs could improve the situation without forcing to have a new window for each view.
All it takes is a 2nd side bar on the right side and the ability to move side bar menu entries to the right or left. Also the ability to show the outline on the right while showing the file browser on the left, so maybe showing the explorer on both sides and allowing its sub sections like "open editors", project files, "outline" and others to move to the right or left explorer section, too.
In my opinion that would resolve this issue, so it could be closed. Everything beyond that would require floating windows and I agree that this is not possible without changing fundamentals.

Devs gave an explanation on why this specific task is hard to accomplish: #10121 (comment)

@MuellerSeb You seem to assume that floating windows are the only solution to this particular issue. In fact multiple views can be implemented without such requirement. There were some excellent suggestions (even in the very first comment of this issue) how the devs could improve the situation without forcing to have a new window for each view.
All it takes is a 2nd side bar on the right side and the ability to move side bar menu entries to the right or left. Also the ability to show the outline on the right while showing the file browser on the left, so maybe showing the explorer on both sides and allowing its sub sections like "open editors", project files, "outline" and others to move to the right or left explorer section, too.
In my opinion that would resolve this issue, so it could be closed. Everything beyond that would require floating windows and I agree that this is not possible without changing fundamentals.

Instead of just a second sidebar, which is still quite limiting, I would rather suggest to generalize all views to use the existing and excellent layout system for tabs and splits. See Theia, which is based on VSCode and has such a generalized layout system.

Instead of just a second sidebar, which is still quite limiting, I would rather suggest to generalize all views to use the existing and excellent layout system for tabs and splits. See Theia, which is based on VSCode and has such a generalized layout system.

Personally I would like to see all panels dockable/undockable - and make them dockable anywhere within a window so that one can customize the layout of the editor to ones needs without restrictions

Personally I would like to see all panels dockable/undockable - and make them dockable anywhere within a window so that one can customize the layout of the editor to ones needs without restrictions.

That would be the icing on the cake. Until then I would be happy with a simple second sidebar for the outliner.

Personally I would like to see all panels dockable/undockable - and make them dockable anywhere within a window so that one can customize the layout of the editor to ones needs without restrictions.

That would be the icing on the cake. Until then I would be happy with a simple second sidebar for the outliner.

And allow the "panel" to go below the sidebars instead of the text editor window - it would save you quite a bit of vertical space.

First time trying out VS Code. Of course, first thing I wanted to change in the layout was to have sidebars both left and right like any other IDE and only find this issue. Great, I'll try again in another 4 years.

+1

Hey guys. I just made a rough implementation here and need time to polish it.
Let me know what you think. ;) Hope this helps.

Hey guys. I just made a rough...

Ah, looks great 👍
This will end up in the releases from Microsofts website eventually right? If so, I would appreciate if someone could send another message here to let us know of when I out.

Thumbs up 👍

A demo here.
https://user-images.githubusercontent.com/12122021/125544451-ed03cd41-f551-4355-8100-00590e5fdcb7.mp4
I will send a pull request soon.

A demo here.
thirdpanelPart.ts.-.vscode.-.Code.-.OSS.Dev.2021-07-14.09-01-30.mp4
I will send a pull request soon.
BTW. Third panel doesn't look like a good name. Any idea?

please show the experience when the panel and the third view at the same time,(even user move the exit panel to right)

do not use ctrl+shift+b because it's the default shortcut of build task. maybe we can use ctrl+alt+b instead

I still believe that the three panel or view should have the icon or title, maybe small then the the side bar or only titles.

we should also be able to move any other views to the three panel

by the way, the visual studio float panel is very useful and powerful, we could use for reference

there is the float panel(FP) of vs2019, and some of those features are yummy

when the FP is hide, there are titles standing by side.
when click the of title of FP, the FP show, we can do something like navigation, but  after lost the fource, the FP automatically hide in order to maximize the editor view
we could also PIN those FP for persist view.

maybe the float panel is what i want 🐶

Thanks for you suggestions! I will add more screenshots later.

Ctrl + Alt + B is a good idea. 😄
Another activity bar (perhaps only texts) seems reasonable to me. But so far I have not implemented yet. Will do in the upcoming next days.
Flowing panel is another thing. It deserves another issue I guess? Since the main sidebar could be float as well.

@heartacker Thanks for your suggestions! I will add more screenshots later.

Ctrl + Alt + B is a good idea. 😄
Another activity bar (perhaps only texts) seems reasonable to me but I have not implemented yet. Will do in the upcoming days.
Floating panel is another thing. It deserves another issue I guess? Since the main sidebar could be floating as well.

now the side bar can't automatically hide when lost focus, and I hope that the new panel can show when user click or longtime hover and hide when lost focus, also can PIN.
maybe the float panel is another thing. but if we can  implement this feature of float panel, I think we have no necessary to implement the  another sidebar*.

@hmcclungiii Remove the false references to the issues #2, #3, #4 and #5, please. If you want to rank VSC, do it without using the # character.

Oh, my apologies, @martin-braun, I can't believe I forgot this was Github flavored Markup!

@wendellhu95, it looks pretty decent!
The sidebar, instead of the "third panel", can simply be called "additional panel".
We are looking forward to the appearance of this functionality!

@wendellhu95 I'm loving it!  I actually pulled your PR into my fork and built it.  I'll be using the custom build until it is added to the actual product, as long as I can!

BTW, Third panel doesn't look like a good name. Any idea?

This beautiful panel shows only Outline and Timeline? Both are sub-sections of the Explorer Panel within the Activity Bar, but they are File-centric (meaning, they show only information relevant to the file). I think we could call it "File Panel" or "Additional File Panel" (expecting that Outline and Timeline are both still available in the Explorer window on right click).
If you can show whatever panel you want, that can be shown in the Explorer, it should rather be called "Additional Explorer", "Secondary Explorer" or "Separate Explorer" (since it's not part of the "Activity Panel". We could also call it "Explorer Panel", because it is a dedicated panel for the "Explorer", instead of being a child of the Panel that is shown by the "Activity Bar".

Navigation Panel?

I haven't had any problem dragging and dropping windows from the activity
bar over to the new panel.
On Sat, Jul 17, 2021, 5:50 PM eazrael @.***> wrote:

Navigation Panel?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/26777#issuecomment-881964274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTW3BBKOSZFCOIYGZ4CLITTYH3JLANCNFSM4DLUT4IA
.

dock panel, floating panel

I don't think it's very useful to pollute this issue with crowdsourced names when the VS Code team will want to come up with the name themselves.

If you are complaining that this feature should have been implemented yesterday I suggest you check your expectations. VSCode is made available for free. It's already a fantastic editor, arguably one of the best, and you don't have to pay for it. The devs that are working on it are extremely skilled, and it shows. Good faith feedback is great, but I see a lot of comments here that are rude and seem to come from a perspective of entitlement, I can guarantee you that this has the opposite effect than what you are looking for. Rather than the devs reading this and feeling motivated, it probably makes them less likely to want to work on this feature.

I don't mind making such a complaint at all.  Do I feel entitled?  I've contributed at least a man year or two into open source software that you are probably using right now.  When I overlook something, I need honest feedback.  Yes, it should have been in the ORIGINAL implementation.  But nothing is a mistake if we can learn from it, and to me, that is the blessing.  As the investors say, "never waste a good crisis."
Trying to approach our computing problems where we keep our mind open to the possibilities, avoid tight coupling, and explore the consequences of design decisions can help us to see when we may be "painting ourselves into a corner", and it seems like this is precisely what happened for this issue (and likely other related issues).  In short, if you design a widget to be in a single place all of the time, you're almost certainly thinking of your software design in too narrow of terms.
Frankly, I have been forced to use this software for a Go project by my employer.  After working with KDevelop, I find it quite lacking in many areas and also very helpful in many others.  So it's not "free" for me, it's a responsibility.

@wendellhu95 Looking great, good work!

I would call it right panel, anything related to explorer is wrong since all views can be dragged out to any where you want. (activity bar, terminals panel). Just because the mockup shows explorer related views does not mean views from other view containers will not be put there

Frankly, I have been forced to use this software for a Go project by my employer.

@daniel-santos Frankly, you should question your employer and your current position more than the VSCode team in regards of this issue.

this feature has been exists for years, while the vscdoe-huawei from huawei has add it for one year. Maybe they cannot publish it to github.

How this still an issue after 4 years ... seriously!

It takes volunteers to implement such features...
https://bugs.eclipse.org/bugs/show_bug.cgi?id=58945
This feature request had it's 10th anniversary in 2014 and is still open. So 4 years is quite fast.

How this still an issue after 4 years ... seriously!

There are far more pressing features and issues that need addressing. This one is I agree nice to have but does not really impede being productive with VSCode.

There are far more pressing features and issues that need addressing. This one is I agree nice to have but does not really impede being productive with VSCode.

Speak for yourself, my friend.  When working in Go, I'm ever clicking to change views when I have the horizontal space for most of those views to be on the screen at the same time.  I'm either hiding and expanding the "Outline", or going back and forth between the explorer and debug views, or expanding and shrinking various panes within the debug view to either see some value or change the stack frame.
Don't assume that everyone is doing the same tasks with this editor that you are.

@daniel-santos Frankly, you should question your employer (and maybe your current position) more than the VSCode team.

lol! I'm just spoiled on mature IDEs.  VSCode is a young project.  I agree with my employer's decision and I think it's currently the best option for Go development.  But mostly, I need it to work for our customers.
My primary criticism lies with Microsoft's decisions in the early phase of the project.  These lessons should have been learned from the prior decades of IDEs as well as GUIs, and widgets of every sort.  It's a basic tenent to not paint ones self into a corner, which the early project management most certainly did.  Perhaps they themselves were young and inexperienced.
I haven't dug into the sources yet, but given my project goals, I presume that I will be later this year.  I sure know that it's a lot more work to retrofit such changes than to have designed and built it that way from the start.
It's a very powerful IDE and a great challenge to fit the needs of a wide swath of languages, debuggers, programming paradigms, etc. in addition to add-ons that alter the behavior -- which vscode seems to succeed at more than it fails.

Just right now at work and though VSCode already had that, would be a cool feature to have, still, thank you all for the great efforts you put to make this software, perhaps this feature could take time, but you always surprise us with great features we never thought we needed. Keep up the good work.

To everybody who wants to comment here:
How about simply upvoting the comments here (incl. the first comment that is most important) instead of commenting yourself without adding something new to the conversion, please? With each comment you notify everybody who is subscribing to this issue. A lot of people just subscribed to get notified by news regarding this issue. Simply commenting that you want the feature adds really nothing to the conversion and notifies a lot of people for no good reason. Scroll up and read the countless comments and I am sure you will find plenty of people who expressed your option already.
Thank you.

I assume this would help a lot for extension development. While it wouldn't solve my current issue directly, it would be a good workaround to get a customized Outline view in conjunction with a custom Side Bar and other viewlets.
Related to: https://github.com/Microsoft/vscode/issues/49923#issuecomment-907573485

@martin-braun After your repeated comments on this issue, I don't think you have room to talk. As one of the people subscribed to this issue, I have no problems seeing new comments, It lets me know people are interested in this topic still. So don't think your opinion is the only one out there.

Hey everyone, big thanks to @wendellhu95 for working on a PR that will provide a 2nd side bar in VSCode to us. He is looking for people to test his build and report any bugs before requesting the PR, right now. You still have to build it yourself, but a Windows build is on the way.
@Smugger21 You are free to have your opinion, but nobody forbids anybody to comment here, you should neither. If someone wants to comment, it's fine, but it would be nice to comment responsibly to reduce clutter, please.

the new side bar is available now with insider,
enable it by:
"workbench.experimental.sidePanel.enabled": true,

thank you @sbatten  & @wendellhu95


Fix for issue #614

Proposed changes
This pull request fixes issue 614.
The exception from the issue is thrown because the SoftAssert listener is added in the onTestStart() method, which is executed before all methods marked with @Test annotation. To be able to add that listener before configuration methods(e.g. @BeforeSuite, @BeforeMethod etc.) I added
beforeConfiguration() method from which  addSelenideErrorListener() method is called. I also modified the addSelenideErrorListener() method  a bit so th the SoftAssert listener would be added before executing any testng configuration methods and skip adding if that listener was already added.
Checklist

[x ] Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
[x ] I have added tests that prove my fix is effective or that my feature works
[x ] I have added necessary documentation (if appropriate)

Coverage decreased (-0.07%) to 64.265% when pulling d27308b2add93ad575731bcee396626184211268 on ostap-oleksyn:614_fix into 72bfa946287b896d984523ab5dbc87bff47d0101 on codeborne:master.

Codecov Report

Merging #615 into master will decrease coverage by 0.16%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #615      +/-   ##
============================================
- Coverage     60.55%   60.38%   -0.17%
+ Complexity      765      763       -2
============================================
  Files           148      148
  Lines          2728     2734       +6
  Branches        264      265       +1
============================================
- Hits           1652     1651       -1
- Misses          973      977       +4
- Partials        103      106       +3

Impacted Files
Coverage Δ
Complexity Δ

...ava/com/codeborne/selenide/testng/SoftAsserts.java
59.45% <50%> (-5.06%)
14 <2> (ø)

...e/selenide/impl/WebDriverThreadLocalContainer.java
77.93% <0%> (-2.07%)
30% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bfa94...d27308b. Read the comment docs.


[BE] add feature to change customer description

Coverage increased (+0.06%) to 92.019% when pulling 30185d8cb940bd15591809a66cc23b0d59fc1658 on feature/change-description into bf8636e0949ed8b0c6de7f718b2af6668292e544 on master.


Fix mill script for parameter starting with -i

Context
There is an issue in the build pipeline the following job is falling:
./mill --import ivy:io.chris-kipp::mill-github-dependency-graph::0.2.5 showNamed io.kipp.mill.github.dependency.graph.Graph/generate
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  0 5[7](https://github.com/com-lihaoyi/mill/actions/runs/8752465078/job/24020171634#step:5:8).3M    0 19288    0     0   9993      0  1:40:23  0:00:01  1:40:22  9993
 94 57.3M   94 54.1M    0     0  22.1M      0  0:00:02  0:00:02 --:--:-- 22.1M
[10](https://github.com/com-lihaoyi/mill/actions/runs/8752465078/job/24020171634#step:5:11)0 57.3M  100 57.3M    0     0  23.3M      0  0:00:02  0:00:02 --:--:-- 23.3M
Preparing Java 17.0.10 runtime; this may take a minute or two ...
[info] compiling 3 Scala sources to /home/runner/work/mill/mill/out/mill-build/compile.dest/classes ...
[info] done compiling
Parsing exception Position 1:[14](https://github.com/com-lihaoyi/mill/actions/runs/8752465078/job/24020171634#step:5:15), found "=./mill"
Error: Process completed with exit code 1.

The issue is coming from the ./mill sh script here:
 # first arg is a long flag for "--interactive" or starts with "-i"
if [ "$1" = "--bsp" ] || [ "${1%"-i"*}" != "$1" ] || [ "$1" = "--interactive" ] || [ "$1" = "--no-server" ] || [ "$1" = "--repl" ] || [ "$1" = "--help" ] ; then
  # Need to preserve the first position of those listed options
  MILL_FIRST_ARG=$1
  shift
fi

If you pass -i or --import it will match the if statement and more precisely the [ "${1%"-i"*}" != "$1" ] part of the if statement.
Solution
Looking at the POSIX documentation of the: POSIX shell variables and parameter substitution

${parameter%pattern}
${parameter%%pattern}
If the POSIX shell pattern matches the end of the value of parameter, then the value of this substitution is the value
of parameter with the matched portion deleted; otherwise, the value of parameter is substituted. In the first form,
the smallest matching pattern is deleted; in the second form, the largest matching pattern is deleted.

It sounds like % matches and substitutes the end of the parameter which explains the issue.
While the following approach uses the beginning of the parameter:

${parameter#pattern}
${parameter##pattern}
If the POSIX shell pattern matches the beginning of the value of parameter, then the value of this substitution is the
value of parameter with the matched portion deleted; otherwise, the value of parameter is substituted. In the first
form, the smallest matching pattern is deleted; in the second form, the largest matching pattern is deleted.

So by replacing  [ "${1%"-i"*}" != "$1" ] by [ "${1#"-i"}" != "$1" ] it should solve it :crossed_fingers:

Can you write a proper PR description explaining what you believe the problem is and why this is the correct solution?

Hi @lihaoyi
Sorry for this PR hope it's better now :hugs:

@romain-gilles-ultra thanks! Can you verify that passing in flags like ./mill -i -j 4 __.compile and ./mill -ij4 __.compile continues to work


Feature request: Get usable memory from cgroups, etc.

As cgroups (and possibly other kernel-level resource limits) may specify a limit on the amount of memory a process can consume, it would be useful for this library to expose an API like uv_get_usable_memory (in addition to total and free). Node.js would be able to then use this to set a memory limit for V8 isolates (see https://github.com/nodejs/node/pull/27508).
I've put something together for linux/cgroups here. I wanted to get feedback before taking time to flesh it out more. In particular, I think if we introduce this API, that we could iteratively implement it for other OS's besides Linux, and in the meantime just return a very high value as a place holder (cgroups itself uses a value of 0x7FFFFFFFFFFFF000 to represent no memory limit).

cc/ @ofrobots, @bnoordhuis, @mscdex

I'm not opposed to such an API. If we do add it, we might want to label it as experimental for a few releases though.


Website access issue

Every time I use the url: https://www.pathfinder-w.space/ I am greeted with the first screenshot.
But when I used the url: https://pf.ap0.space/# I am greeted with the 2nd screenshot.

The second link you linked (pf.ap0.space) is a private installation of Pathfinder, only for selected corporations/alliances.  Also it's not a subject to issue reports here since it's not an "official".
The official one - "www.pathfinder-w.space" - well, I can only say I see it the same way as you :)
You would probably have to wait for @exodus4d to sort this issue for you.

Interesting, I can´t see any problems on https://www.pathfinder-w.space (Chrome 68).
Regarding your screenshot:

Pages itself loaded and CSS failed to load -> Could you check the Chrome Dev-Tools (F12) -> "Network" Tab for any errors and post a screenshot of it here?
Have you checked your Chrome extensions (e.g. Add Blocker) if resources are blocked by any Chrome extension?

I have uBlock Origin but it says it did not block anything. Disabling it changed nothing.

@BeatByATaLi Do you have "Bitdefender" active on your Browser?  Someone else reported that problem and an active "Scan SSL" option caused the problem:
Possible problem: https://www.bitdefender.com/support/what-to-do-when-security-certificates-cannot-be-verified-installed-1090.html

Deactivating that option is of course not a solution but it might help me to hunt that problem down.


Speeds Tool v2

This supersedes #52 and #12.
UI Tab

[ ] Requires #51 (toolbar -> build bar)
[ ] Icon for "speeds" tab
[ ] Resize speed icons to fit build bar?

Toggle between segment vs. lane mode:

[ ] New UI "side" button for persistent toggle
[ ] Ctrl+whatever = temporary toggle current state of button
[ ] In segment mode, speed is set for both directions

Apply speed changes:

When applying to a road segment, speed only gets applied to road lanes:

Monorail tracks get their own set of icons
Tram tracks, if separate from road lane, get own icons

If part of road lane, they get same speed as road lane

Rail tracks: Treat same way as tram tracks

[ ] Highlight segment/lane that will be affected - requires #33
[ ] Click = set speed for a segment/lane
[ ] Shift+Click = Like Click, but propagates to nearest junction / dead-end
[ ] Click+Drag = Applies Click to all segments/lanes dragged over
[ ] Facilitate mph vs. km/h? See: #13
[ ] Some way to quickly set 'gradient of slow outer to fast inner' lane speeds

Clear speed changes:

[ ] Eraser tool (done as part of #51?)
[ ] Right-click (plus any of the modifiers above) as a shortcut to eraser

Default speeds:

After setting desired speeds for a segment, rubber stamp it to set as defaults

[ ] Rubber stamp tool (appears in icon bar along with speeds)
[ ] Alt+Click as a shortcut to rubber stamp
[ ] Store default speeds in global settings rather than savegame

After setting desired speeds for a segment, rubber stamp it to set as defaults

Could there also be a shortcut like shift + click (sets all speeds along a segment) to set the same speed for all existing roads of that type? So if you have a bunch of roads already placed, you could do something like ctrl + shift + click and it'll set all roads in the city of type X to be that speed. Or will setting a default speed automatically set all existing roads of that type?

Yes, see Alt+Click near end of opening post.


Use huggingface modified pickler to fix path-dependent caching

Similar to https://github.com/bespokelabsai/curator/issues/215, this is causing a ton of cache misses in DCFT since the runtime path changes depending on the ray package name when a job is submitted to the Ray remote cluster.
the Ray package name changes whenever there is a change in the local github repository.
HuggingFace pickler overcomes this problem by modifying the filename: https://github.com/huggingface/datasets/blob/2049c00921c59cdeb835137a1c49639cf175af07/src/datasets/utils/_dill.py#L252

Tested that this fixes the behavior.
BEFORE:
Two jobs with the same config but different package writes to different hash in curator cache
http://<IP_ADDRESS>:8265/#/jobs/78000000
(_Completions pid=3532927, ip=<IP_ADDRESS>) INFO:bespokelabs.curator.request_processor.base_request_processor:Wrote 110 requests to /home/ray/.cache/curator/evol_instruct_gpt-4o-mini_test_batch__evolve_instruction/8c2067c93ddf83b5/requests_0.jsonl.

http://<IP_ADDRESS>:8265/#/jobs/79000000
(_Completions pid=3534054, ip=<IP_ADDRESS>) 2024-12-09 08:43:14,924 - bespokelabs.curator.request_processor.base_request_processor - INFO - Wrote 110 requests to /home/ray/.cache/curator/evol_instruct_gpt-4o-mini_test_batch__evolve_instruction/d66bad863d1b8bbd/requests_0.jsonl.

AFTER:
Two jobs with the same config but same package writes to the same hash in curator cache
http://<IP_ADDRESS>:8265/#/jobs/7c000000
(_Completions pid=3539787, ip=<IP_ADDRESS>) 2024-12-09 08:50:37,417 - bespokelabs.curator.request_processor.base_request_processor - INFO - Wrote 110 requests to /home/ray/.cache/curator/evol_instruct_gpt-4o-mini_test_batch__evolve_instruction/f44a6e60a24c7619/requests_0.jsonl.

http://<IP_ADDRESS>:8265/#/jobs/7d000000
[36m(_Completions pid=3540802, ip=<IP_ADDRESS>) 2024-12-09 08:51:25,717 - bespokelabs.curator.request_processor.base_request_processor - INFO - Using cached requests. If you want to regenerate the dataset, disable or delete the cache.
(_Completions pid=3540802, ip=<IP_ADDRESS>) INFO:bespokelabs.curator.request_processor.base_request_processor:Using cached requests. If you want to regenerate the dataset, disable or delete the cache.
(_Completions pid=3540802, ip=<IP_ADDRESS>) INFO:httpx:HTTP Request: GET https://api.openai.com/v1/batches/batch_67571fdf8e908191a03131c7deb1e769 "HTTP/1.1 200 OK"
(_Completions pid=3540802, ip=<IP_ADDRESS>) 2024-12-09 08:51:25,910 - bespokelabs.curator.request_processor.openai_batch_request_processor - INFO - 1 out of 1 remaining batches are already submitted.


Allow passing custom projectRoot option

Hi! Thanks for making & publishing this project, works very well! Just running into one issue - could you add an option for passing a custom projectRoot (single one would work for me)?
I'm using it in a monorepo for a sub-sub-package, so the process.cwd is deeper than the root of most modules. This means that most imported packages have the absolute path, which is a bit distracting when publishing the output in CI. The project structure is something like this:
/package.json                              <--- empty root
/node_modules/...                          <--- shared packages are here (e.g. typescript)

/packages/a/package.json                   <--- indirect dependency through b
/packages/a/node_modules/...               <--- most modules are here

/packages/b/package.json                   <--- implementation
/packages/b/node_modules/...               <--- some modules are here

/packages/b/examples/example1/             <--- project.cwd for vite-bundle-visualizer
/packages/b/examples/example1/package.json <--- Vite project

Calling the command from the root directory and passing in --config / --entry doesn't work either, as the visualizer can't import Vite.
If you'd like me to create a PR, I can gladly do so! :)

Currently it's import vite from cwd and goes down in trees directly, maybe sometimes it cannot import indirectly vite from another tree. It's great if you would make a PR.
You might want to revise the line that mentions Vite being imported from the current working directory (cwd). I’m uncertain whether importing Vite from a different root directory will allow the build correctly, given that the entry file is located in a different root.
https://github.com/KusStar/vite-bundle-visualizer/blob/713be97f57b891efea9367dc048eceda145130f8/index.js#L10

I looked into this issue further today and tried to build a reproduction case (as a test fixture). The simplest case didn't work, so I looked further into my specific problem case.
Somehow the issue seems to be that the Vite-generated source maps contain transformed source code, but not the finished version - some in-between version with dynamic imports of absolute module paths for workspace dependencies. This didn't occur in the bundle itself. What worked to "fix" the issue was adding:
build: {
  sourcemap: true,
  rollupOptions: {
    output: {
      sourcemapExcludeSources: true,
    }
  }
}

to my Vite config - this removes that half-transformed source from the source map, which makes the bundle visualizer output the correct (short) path.
If you want to see the example yourself, I can give you access to the private repo where this happened. Other than that, this issue is resolved - might be worth to add the resolution to the README, in case someone else has the same issue.
Thanks again for this package!


Performance issue

The package is so slow when it comes to adding filters or cropping the image.
When you click on crop or filters it takes 3 seconds minimum to push the page

add a layer check if its one dont take a screen shot thats a massive performance increase also add overlay when waiting for any screen shot

thanks added.


Modem and Ublox Sara r4 minor tweaks

Here are few commits that we are using above zephyr 2.3 ublox-sara-r4 modem driver.
Some are necessary fix, some are just useful tools for some specific adaptation too match our use case (including mostly power management).
I already know that commit logs should be improved to match zephyr coding guide rules, but I rather wait for the reviewers firsts remarks as this might result in removing some of the commits.

@hwilmers Can you have a look at this PR? Thanks

Interesting, I look forward to using these changes in the future.
Billy..

@WilliamGFish @hwilmers @mike-scott
I've added another commit that change the implementation of offload_sendmsg().
I really think this one should be merged as it definitively speed up things when offload_sendmsg() is used (for exemple in mqtt with TCP sockets).

@jukkar Maybe you know someone that could have a look ?

@jukkar Thank for your comment, I've made the requested changes. Compliance tests should also pass now.

ping @bwasim would this cause changes to #29453 as the bg9x modem driver is quite similar to ublox one?

I don't think this PR cause changes to the bg9x drivers. This PR add some features that could be used, but there should be no mandatory change nor any break in compatibility.

I don't think this PR cause changes to the bg9x drivers. This PR add some features that could be used, but there should be no mandatory change nor any break in compatibility.

Sure, I was just seeing changes to generic modem functions which might be useful to have in bg9x. Also perhaps @bwasim could give a look to the PR in the same go.

@jukkar @mniestroj I've update the PR following the last remarks.
The build seem's to have fail due to space problem on the running server? OSError: [Errno 28] No space left on device
Is there anything that can be done ?

The build seem's to have fail due to space problem on the running server?

I have seen this many times before. Dunno what is the root cause. I usually just force push a new version or close/reopen the PR to retrigger the tests. Lets try the latter...just a sec.

I usually just force push a new version or close/reopen the PR to retrigger the tests. Lets try the latter...just a sec.

I guess that worked with shippable, but it does not retrigger buildkite nowadays. I guess some core members have access to "restart" button in buidkite.

@XavierChapron
Odd conflict with these changes in the command_handler (modem: verify send semaphore before taking any action and fix race condition waiting on reply #30146)
There is a check for semaphores being sent to the _modem_cmd_send which throws an exception, therefore never writes to the socket.
Billy..

@WilliamGFish Are you sure this is related to this PR?
To me it seems that it fails here:
ret = modem_cmd_send_nolock(&mctx.iface, &mctx.cmd_handler,
				 NULL, 0U, send_buf, NULL, K_NO_WAIT);

Calling modem_cmd_send_nolock() with no semaphore.
But this call is legit, and has not been introduced by this PR.
The real problem is the cehck you mention here: https://github.com/zephyrproject-rtos/zephyr/pull/30146#discussion_r536260925

@WilliamGFish Are you sure this is related to this PR?
To me it seems that it fails here:
ret = modem_cmd_send_nolock(&mctx.iface, &mctx.cmd_handler,
				 NULL, 0U, send_buf, NULL, K_NO_WAIT);

Calling modem_cmd_send_nolock() with no semaphore.
But this call is legit

You are right, your code is just fine. I noted that the previous PR stops your changes from working.
Didn't want others attempting to use one of the modern drivers and think they don't work.
Billy..


Allow configuration of saml signature parameters

Closes https://github.com/pac4j/pac4j/issues/321

Thanks
Can we update the documentation: the "SAML support" on the wiki: https://github.com/pac4j/pac4j/wiki/Clients?

Sure


Bug fix: Fixed problem with vehicle attribute dialog in the AddVehicl…

…eActivity where the index of the selected item was saved regardless of whether the user clicked 'cancel' or 'ok'

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):
Can you also look into a reported bug from iOS? There was an issue that the textbox allowed you to enter a space character into the license plate field. Does Android let you do that currently?

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):
Previously, romrell4 (Eric Romrell) wrote…
Can you also look into a reported bug from iOS? There was an issue that the textbox allowed you to enter a space character into the license plate field. Does Android let you do that currently?

Yes that was already taken care of. Also, just merged with dev, everything is working as it should.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Ubuntu 20.04 Support

After updating my ubuntu vps to 20.04 the ServerHub can't be launched due to a libssl error i suspect this is due some compatibility issue.(Already tried to install libssl-dev but it did not help)

Try running this:
wget http://archive.ubuntu.com/ubuntu/pool/main/o/openssl1.0/libssl1.0.0_1.0.2n-1ubuntu5.3_amd64.deb
sudo dpkg -i libssl1.0.0_1.0.2n-1ubuntu6.2_amd64.deb

Or try installing dotnet and running the dll file:
sudo apt-get install dotnet
dotnet ServerHub.dll

reinstalling libssl-dev and using your first method fixed the issue. Thanks

The link for the libssl changed btw,
wget http://archive.ubuntu.com/ubuntu/pool/main/o/openssl1.0/libssl1.0.0_1.0.2n-1ubuntu5.4_amd64.deb
sudo dpkg -i libssl1.0.0_1.0.2n-1ubuntu5.4_amd64.deb


Activate more features in clippy CI and fix new warnings

Continuing #288 (@Amanieu, you were too quick with the merge xD)

Add raw feature to clippy-tested features but exclude clippy::mising_safety_doc and clippy::missing_errors_doc for now.
These documentation lints require some nontrivial fixes, I guess I’ll open an issue.

I’ve got the fixes ready already, but let’s first test if CI failure works properly with the new lints activated…

Looks good! Let’s add the fixes now…

Should pass CI now.

@Amanieu FYI, I’m done fixing clippy lints here for today, this can be merged :-)

@bors r+

:pushpin: Commit 33eedbdb2c69aed1be467f535b847f42e020943b has been approved by Amanieu

:hourglass: Testing commit 33eedbdb2c69aed1be467f535b847f42e020943b with merge 25632834c2f2613bd4978b522d0ab78ade2e4056...

:sunny: Test successful - checks-actions
Approved by: Amanieu
Pushing 25632834c2f2613bd4978b522d0ab78ade2e4056 to master...


Add fallbacks for mandatory fields

chip-tools doesn't populate some mandatory fields in some cases.
See: https://github.com/mfucci/node-matter/pull/222

Cool, Then I would be so free and merge :-)

@mfucci I also fixed the merge conflict after merging my PR, so please do final check and merge. Then a new release on npm would be awesome


Getting Started guide does not work

Describe the bug:
If you follow the instructions in the Getting Started section, then the resulting generated files are not compatible with Flux.  This is because when you run the command to add simple-service, you are actually referencing the fabrikate-istio definition. The cloud-native definition also references fabrikate-istio as a subcomponent, as is stated in the guide. This is a problem for Flux because now you have duplicate YAML files for istio. See screenshot below.
To Reproduce:
Run the fab commands from the guide in your cluster directory.
fab add cloud-native --source https://github.com/microsoft/fabrikate-definitions --path definitions/fabrikate-cloud-native
fab add simple-service --source https://github.com/microsoft/fabrikate-definitions --path definitions/fabrikate-istio

Create the config/prod.yaml file as stated in the guide.
Run:
fab install
fab generate prod
Expected behavior:
I expect the generated files for simple-service to include YAML files describing that service but not istio.
I guess the YAML files existed at some point in the fabrikate-definitions repo, but were moved and the Getting Started guide was not updated to reflect those changes.
Screenshots:

Additional context:
I am going through the Bedrock tutorial and creating a High Level Fabrikate description is part two of that tutorial. I am new to all of this, but as I understand it the generated files from Fabrikate are the files that should be added to the manifest repository, which Flux monitors for changes. Please correct me if I am wrong about this part.
Desktop (please complete the following information):

OS: Windows Subsystem for Linux (Ubuntu 18.04)

In addition to above, during fab installstep I get:
INFO[22-12-2020 13:11:08] 🚁  Updating helm chart's dependencies for chart in '/home/admir/Projects/Azure/my-fabrikate/mycluster/components/simple-service/definitions/elasticsearch-logstash-kibana/helm_repos/logstash/stable/logstash'
Error: exit status 1: Error: repo "https://kubernetes-charts.storage.googleapis.com/" is no longer available; try "https://charts.helm.sh/stable" instead

Usage:
  fab install [flags]

Flags:
  -h, --help   help for install

Global Flags:
  -v, --verbose   Use verbose output logs

$ fab versoin
INFO[22-12-2020 13:16:07] fab version 1.0.0-alpha1