Require python3.9 in 'develop' target

Required for pre-commit to run with predictable Python version
Pull Request Checklist

[x] implement the feature

Without 3.9 available pre-commit fails with
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/python3', '-mvirtualenv', '/home/lzachar/.cache/pre-commit/repozpix4xlc/py_env-3.9', '-p', '3.9')
return code: 1
stdout:
    RuntimeError: failed to find interpreter for Builtin discover of python_spec='3.9'
stderr: (none)


Feature #190 - Add translation support for the navbar.

Current coverage is 58.18%

Merging #191 into master will not affect coverage as of 8209c1f

@@            master    #191   diff @@
======================================
  Files           32      32
  Stmts          617     617
  Branches         0       0
  Methods         89      89
======================================
  Hit            359     359
  Partial          0       0
  Missed         258     258

Review entire Coverage Diff as of 8209c1f

Uncovered Suggestions

+1.94% via ...enViewController.php#124...135
+1.78% via ...ackendController.php#243...253
+1.62% via .../CloudController.php#33...42
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Training Error. Could you provide some guidance on how to fix this error?

FileNotFoundError: [Errno 2] No such file or directory: '/qfs/projects/mage/watk681/DIV2K_train_HR/DIV2K_train_HR/002116_s044.png'
However, DIV2K/DIV2K_train_HR/ uses 0001.png, 0002.png, ..., 0800.png.
Any guidance on how to generate the compatible meta_info_DF2Ksub_GT.txt to work with DIV2K/DIV2K_train_HR/ uses 0001.png, 0002.png, ..., 0800.png.?

Follow the Preparation Steps.


Parse Directory method returns empty dictionary

Describe the bug
The parse_directory method in the Alias class returns an empty dictionary under certain circumstances. I have not figured out what those circumstances are yet. It works for one directory with LAS files but will not parse any subfolders of the directory when the path is changed to the subfolder.
To Reproduce
from alaska import Alias
a = Alias(dictionary=False, keyword_extractor=False, model=True, prob_cutoff=0.9)
PATH = 'E:path\to\data\'
new_mne, not_found = a.parse_directory(other_path)

Expected behavior
The a instance to parse the directory
Screenshots
n/a
System (please complete the following information):

OS: [Windows 10
Python version 3.7
AlasKA Version current main branch
PyTorch Version 1.8

Additional context
n/a

Seems to only be on a subset of the LAS files that I have. Not sure if it is something in lasio or elsewhere that is having the issue.

@jessepisel,
If we can identify one or more Las files that are causing the problem, I can check if the issue is in Lasio.
Can you move half your files to a separate directory and see if one of the directories passes and one fails?
DC

I tried:
from alaska import Alias
import glob
a = Alias(dictionary=False, keyword_extractor=False, model=True, prob_cutoff=0.9)
files = glob.glob(PATH+'*las')
for file in files:
    a.parse(file)

where PATH is the absolute path to the directory. When I run it this way it parses through the files without any issues. Using the same instance of Alias if I try:
a.parse_directory(PATH)

it returns an empty dict ({}, [])
I am not sure if this is lasio based or if this is inside alaska but I am guessing so.

@dcslagel I tracked down the issue in alaska. It was not parsing capitalized .LAS file extensions. Should be fixed with PR #63


remove the unsupported default value in v1beta1 crds

The related issue: https://issues.redhat.com/browse/ACM-12647

/lgtm

/cherry-pick backplane-2.6


Switch Docker Graph driver to overlay2 or aufs

I just ran into this (related to #1307) - since overlay has a severe bug that causes it to run out of inodes far before it runs out of space. Combined with /var/lib/docker being on rootfs, this doesn't end well.

We've resorted to doing the following on all our nodes:
#!/bin/bash
set -ex
sudo service docker stop
#sudo umount /var/lib/docker/overlay
sudo sed -i 's_/mnt_/var/lib/docker_' /etc/fstab
sudo mount -a
sudo sed -i 's/overlay /overlay2 /' /etc/systemd/system/docker.service.d/exec_start.conf
sudo systemctl daemon-reload
sudo service docker start
sudo service kubelet restart
sudo reboot

@vdice @lrdcasimir @jordanr86 @skuda PR #1433 delivers this change, would love any remarks as to your experiences with overlay2 (or pain points with existing overlay) so we can gather a consensus risk assessment of this change.

The biggest painpoint with overlay is that it exhausts inodes far more quickly than it exhausts disk space. So your disk will end up being full despite you have a lot of 'space' left, since you run out of inodes. https://github.com/coreos/bugs/issues/264 has more info, and the doc page for 'overlay' explicitly recommends against using it https://docs.docker.com/engine/userguide/storagedriver/overlayfs-driver/
This is particularly problematic on azure, since the base disk / is only 30G by default, and that's where /var/lib/docker is mounted. I had to mount /var/lib/docker in the 'data' disk to give it more space as well.


Fix container CreatedAt and UpdatedAt.

Currently container CreatedAt and UpdatedAt are not properly exposed:
    "CreatedAt": "0001-01-01T00:00:00Z",
    "UpdatedAt": "0001-01-01T00:00:00Z",

This PR fixes it:
    "CreatedAt": "2017-09-22T05:54:41.351119711Z",
    "UpdatedAt": "2017-09-22T05:54:41.351119711Z",

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #1543 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1543   +/-   ##
=======================================
  Coverage   42.61%   42.61%
=======================================
  Files          24       24
  Lines        3318     3318
=======================================
  Hits         1414     1414
  Misses       1581     1581
  Partials      323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709d34f...5452112. Read the comment docs.

LGTM


Add Cesium split view

This adds a new Cesium split view for comparing two different raster files - note that this does not currently let users select bands/colormaps and they must compare two separate files

I'll see if I can make time to implement this so that a user can select bands for each file but that might get a bit complex

Codecov Report

Merging #47 (745fc6f) into main (8086ad9) will decrease coverage by 1.09%.
The diff coverage is 39.13%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   82.91%   81.81%   -1.10%
==========================================
  Files          19       19
  Lines         960      979      +19
==========================================
+ Hits          796      801       +5
- Misses        164      178      +14


Permissions do not work

Despite me having permissions the bot forbids me to execute !bye

It does work sometimes. Maybe because the roles are not cached?

It does work sometimes. Maybe because the roles are not cached?

At bot startup, the bot fetches the roles once and writes them into the cache. In order to get updated roles you currently have to restart the bot. Thus, fetching roles every time the permissions get checked is required

After some testing this bug was not reproducible at all. After renaming the role the bot instantly applies the correct permissions to the user


If config_parser is a package, it should live in its own directory [phab:D2254]

Created by zarko at 2018-04-14 00:01:12:
This seems to be the convention elsewhere (and the current state
of the repo breaks certain tooling).

schroederc commented inline (context lost during migration) at 2018-04-14 01:33:15:
Run buildifier --mode=fix on this file.

schroederc commented inline (context lost during migration) at 2018-04-14 01:33:15:
If you have time to fix this, this shouldn't be renamed on import: s/cp //.  It also should be in an import section above the github.com import section.

schroederc accepted this revision at 2018-04-14 01:33:15

zarko wrote at 2018-04-16 15:52:53:

Address comments

craigbarber wrote at 2018-04-16 17:02:01:
Out of curiosity, what tooling was broken be the previous approach?
A follow up question, is there a pre-submit check we can put in place to ensure that said tooling isn't broken again by future submissions?

craigbarber wrote at 2018-04-16 17:46:43:
Discussed this offline with zarko, the root of the issue was the fact that the name of the BUILD target for the go_library was different than the package name. This was interfering with one of the import tools. The name of the package was "config" not config parser.
It seems like a more surgical fix for this issue would be rename the build target so it matches the package name. The name of the package and its contents were intentional, I would prefer to preserve them in their original form.

zarko wrote at 2018-04-16 22:28:27:
This was committed in 1dcd23b6519cff5937a33ba15fe5c359f9bfdc41

zarko closed via commit 1dcd23b6519cff5937a33ba15fe5c359f9bfdc41 at 2018-04-16 22:28:27


Fix failing tests on CAS 4.1.x branch

The 4.1.x is configured to disable checkstyle, tests and findbugs. Enable them and fix any failing tests.
This might be more difficult to do as there may be a number of dependencies out there, specially for radius whose repos have gone dead. We'll need to account for those too.

For tests, I say yes, but for Checkstyle and Findbugs, is it worth it (as the 4.1.x branch is the oldest maintenance branch)?

You may have a point there. I'd say findbugs is more important than checkstyle, but I shall experiment and see how long each phase takes.

This is done. 4.1 and 4.2 fully building as well as master/4.3


tes: Fix integration test run script to avoid exposing service principal secrets

…pal secrets

What type of PR is this?
/kind test

What this PR does / why we need it:
Adds back an inadvertently omitted backslash in the command to install the Helm chart for the driver. This prevented to the output of Helm for being redirected to /dev/null and results in the Azure credentials file contents being written to the log exposing the service principal password.
Which issue(s) this PR fixes:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.232%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3538

Relevant Lines:
5874

💛  - Coveralls


when we are done we should make a tag release to go with the pip version.

I think we are ready now as soon as we close #27. Do you want me to create the tag?

quick look i think we need to update the read me with the sting name

Yes, in general we tend to make it the "very last thing" (ie, after the package is uploaded to pip, and everything else is 100% ready) - this way each release of pip is ensured to contain the same sources as the corresponding github release.

All is ready, pip versions uploaded for Windows, Mac, Linux. Tagged version 0.1.1


zlib: 1.2.13 -> 1.3

Changes: https://github.com/madler/zlib/releases/tag/v1.3
Description of changes

Pending fixes

[x] openssh: https://github.com/NixOS/nixpkgs/pull/250184#event-10136058476
[x] python3Packages.pillow: https://github.com/NixOS/nixpkgs/pull/250252

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Version change itself broke openssh:
       > configure: error: *** zlib too old - check config.log ***
       > Your reported zlib version has known security problems.  It's possible your
       > vendor has fixed these problems without changing the version number.  If you
       > are sure this is the case, you can disable the check by running
       > "./configure --without-zlib-version-check".
       > If you are in doubt, upgrade zlib to version 1.2.3 or greater.
       > See http://www.gzip.org/zlib/ for details.
       For full logs, run 'nix log /nix/store/r2bivy4mdyrzxjs76k7pxim50a0xi69d-openssh-9.4p1.drv'.

openssh was fixed upstream with https://github.com/openssh/openssh-portable/commit/cb4ed12ffc332d1f72d054ed92655b5f1c38f621

Another casualty is python3Packages.pillow, also checks for version specifics:
    def test_sanity(self, tmp_path):
        # internal version number
>       assert re.search(r"\d+\.\d+\.\d+(\.\d+)?$", features.version_codec("zlib"))
E       AssertionError: assert None
E        +  where None = <function search at 0x7ffff74c5c60>('\\d+\\.\\d+\\.\\d+(\\.\\d+)?$', '1.3')
E        +    where <function search at 0x7ffff74c5c60> = re.search
E        +    and   '1.3' = <function version_codec at 0x7ffff6896680>('zlib')
E        +      where <function version_codec at 0x7ffff6896680> = features.version_codec

pillow has a fix pending upstream inclusion: https://github.com/python-pillow/Pillow/pull/7344

Tried finding another package on macos 10.15 that this caused problems with, failed to do so after ~10h building.

Both fixes reached staging. Rebased the branch against staging.
I tried to build a few thousands of packages with direct zlib dependency and saw no failures so far.
We could do one of two things:

just merge it to staging (ready)
have a hydra jobset (should wait for fixes to reach master and then rebase again)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2612

pigz will also need an update. Proposed as https://github.com/NixOS/nixpkgs/pull/252892

pillow has a fix pending upstream inclusion: python-pillow/Pillow#7344

Pillow 10.0.1 has now been released with this fix.

Thank you! Proposed pillow update to 10.0.1 as https://github.com/NixOS/nixpkgs/pull/255858

zsnes failed zlib version check. Proposed the fix as https://github.com/NixOS/nixpkgs/pull/263444


Would like to see Cilium CRDs recognized by Kubescape/rego.

Overview
I would like to have the ability to run kubescape scan control C-0260 -v and have kubescape recognize the CiliumNetworkPolicy CRD.
Here's a sample YAML:
apiVersion: "cilium.io/v2"
kind: CiliumNetworkPolicy
metadata:
  name: deny-all
  namespace: default
spec:
  endpointSelector:
    matchLabels: {}
  ingress: []
  egress: []

Problem
Kubernetes offers a simple NetworkPolicy CRD but is limited in functionality and doesn't completely provide all the necessary controls and policy capabilities that most CNIs would. This is a base functionality. If a Platform Engineer leverages the Cilium CNI, and uses its native CRDs, Kubescape won't recognize this configuration.
Solution
If Kubescape's rego configuration can honour the CiliumNetworkPolicy CRD, this will allow for C-0260 to pass, with a simple Deny-all policy.
Alternatives
Additional context

Hi @distributethe6ix , thanks for raising the problem. We should definitely start supporting Cilium and Calico network policies as well, since they are widely used.
WDYT @dwertent, @matthyx?

I have no problem with this.
@YiscahLevySilas1 Can you work on this? Please make sure to add the cilium.io/v2.ciliumnetworkpolicies to the Kubescape RBAC.

Ahh this would be great please.. I just added a bunch of CNPs because of the kubescape report and was dismayed when nothing changed after I added them all lol :D

@dwertent maybe a mentee can work on this?

Definitely sounds like an interesting project :)

@slashben Yossi has generating cilium and calico NP up his sleeve. Maybe we should add the controls support as part of that epic.

Yes, but I am not sure what controls. Do you mean those that check if a
workload has a bound network policy?
On Mon, Feb 12, 2024 at 7:34 AM David Wertenteil @.***>
wrote:

@slashben https://github.com/slashben Yossi has generating cilium and
calico NP up his sleeve. Maybe we should add the controls support as part
of that epic.
—
Reply to this email directly, view it on GitHub
https://github.com/kubescape/kubescape/issues/1397#issuecomment-1938087336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODLOPXKG2MAIRMBIZJ3BW3YTGSWLAVCNFSM6AAAAAA473GK7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGA4DOMZTGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

I think this closes it https://github.com/kubescape/regolibrary/pull/639


Update readme to reflect new project name

Literally just saw it's been updated.  As you were.


chore: fix typo

Signed-off-by: Andrea Bonanno<EMAIL_ADDRESS>
What type of PR is this?
Any specific area of the project related to this PR?

What this PR does / why we need it:
Typo fix
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andreabonanno
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreabonanno: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Welcome @andreabonanno! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

Hi @andreabonanno. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/kind documentation

LGTM label has been added.  Git tree hash: ac1d8cbe88eab28c3aa2daedd0fa616d8b2d797c

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreabonanno, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


thunderbirdPackages.thunderbird-102: remove

Things done

Build-related checkboxes: N/A
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

As pointed out, maybe someone could consider it a breaking change, even if the package was marked as insecure.  In that case we'd need to wait with the merge.


Clean _clean_inputs in optimize.linprog

Clean _clean_inputs(...)  as listed in #9671.
This PR:

Remove catching BaseExceptions for unspecified errors.
Remove nested try statements
Refactor duplicate behaviour into functions.
Group related checks into try..except..else statements.
Minor tweaks to documentation and error messages.

This PR does not make any changes to how bounds is handled. I've been looking to rewrite the bounds as arrays which will change that part significantly.
@mdhaber @rgommers All of the (500+) tests in test_linprog pass as well as the tests in test__linprog_clean_inputs. The tests for clean inputs could be more comprehensive, but, I'm going to trust the passing tests. Maybe reveiwing the test suite should be added to #9671?

I think relying on comprehensive tests of the public interface is fine; separately testing utilities is not per definition necessary.

Thanks very much for tackling this @kai-striega. I'll try to take a look this afternoon.

@ilayn you noted the nonstandard checks in #9145 and suggested using misc.utils.  I thought you might like to see this.

Thanks @mdhaber,
I'll have more free time over the next few week(s) so I'll make a start on the rest of #9671.
The failing comes from either circleci or NumPy  and isn't related to these changes. Maybe someone who understands the NumPy side of it better could take over this?

I think there is no need to nitpick further since it is quite readable and the rest is a matter of taste. If you are happy with the content, +1 for merge from me.

@mdhaber I've fixed the spelling. :+1: from me to merge this.

Curious why you needed to force push?
I'll squash and merge when checks are done.

@mdhaber It's that I want to avoid having too many small commits in the commit history. e.g. adding a single letter shouldn't need to be its own commit.

@mdhaber do you know if we can revert squashing the commit history before merging? For many of the commits I've put work into ensuring the commit messages describe why each change occurs, squashing destories the individual commits history which decouples a comits messages from their changes.

@mdhaber It's that I want to avoid having too many small commits in the commit history. e.g. adding a single letter shouldn't need to be its own commit.
Edit: I expected the commits to not be squashed to preserve the commit history to use git bisect (or sometimes blame) more accurately, so each commit serves as a distinct group of (related) changes.

This is the right thing to do. When commits are logically grouped and have a good commit message, we normally want to do do a regular merge not squash-merge. Squash-merge is only for cases of really messy PRs.

@mdhaber do you know if we can revert squashing the commit history before merging?

You can't revert by pushing to the branch from which this PR was opened. But we can just do a straight revert, and re-merge the original commits.
This is still the most recent change in master, so I'll revert now.

Reverted in commit cc3a99cb8.
@Kai-Striega can you open a new PR with these commits rebased on current master?

@rgommers. Thanks that should do the trick. I'll go do it now.

Oops. I noticed how clean it looked. I'm taking notes. Glad this could be fixed.

@mdhaber we couldn't have a messy history for a PR about clean code, could we now?

@kai-striega haha, no, especially not after #10026. Pact to save one another from our own commit messages, please?

@mdhaber done.

A small bug: if you run linprog with bounds 2 x n instead of n x 2, you hit
_linprog_util.py lines 340-341:
   elif (len(bounds) == 2 and np.isreal(bounds[0])
   and np.isreal(bounds[1])):

which raises a cryptic ValueError. Changing isreal to isscalar gets further
but the whole page of bounds code around that with nested try s, ouch.
Lines 1218-1220 say
# Patch for bug #8664. Detecting this sort of issue earlier
# (via abnormalities in the indicators) would be better.
bounds = np.array(bounds) # again, this should have been the standard form

but that's in _postsolve not in _clean_inputs ??

I'd suggest requiring bounds to be either n x 2 array-like, or None, nothing else:
stamp out corner cases ! Then to normalize bounds, how about
def bounds_nx2( bounds, n ):
	""" n x 2 array-like -> ndarray with None -> +- inf
		None -> n x 2 [zeros, infs]
	"""
	if bounds is None:
		return np.c_[ np.zeros(n), np.inf * np.ones(n) ]
	bounds = np.asarray( bounds, dtype=float )  # None -> NaN
	if bounds.shape != (n, 2):
		raise ValueError( "bounds should have shape (%d, 2), not %s" % (
						n, bounds.shape) )
	lb, ub = bounds.T
	lb[ np.isnan(lb) ] = - np.inf
	ub[ np.isnan(ub) ] = np.inf
	return np.c_[ lb, ub ]

@denis-bz thanks for finding that. Yeah, changing bounds to a NumPy array has been on the maintenance list for a long time! (I've always wondered why list of tuples was the required format! )


Convert DeleteCommandTest to a system test #551

Part of #551.
Proof of concept for system tests. Once this is good to go, the rest of the tests will also be converted to system tests (and the common methods refactored out).

v1
@yamgent submitted v1 for review.

[v1 1/5] TestApp: Add readStorageAddressBook()
[v1 2/5] TestApp: Add getStorageSaveLocation()
[v1 3/5] AddressBookGuiTest: Expose testApp
[v1 4/5] AddressBookGuiTest: Add DisabledEventStorageManager class
[v1 5/5] DeleteCommandTest: Convert to system test

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

As discussed, will also add the rememberState() and confirmStateNotChanged() to each of the handles.

v2
@yamgent submitted v2 for review.

[v2 1/13] TestApp: Add readStorageAddressBook()
[v2 2/13] TestApp: Add getStorageSaveLocation()
[v2 3/13] TestApp: Add getModel()
[v2 4/13] AddressBookGuiTest: Expose testApp
[v2 5/13] Add WebViewUtil#getLoadedUrl()
[v2 6/13] BrowserPanelHandle: Add getLoadedUrl()
[v2 7/13] BrowserPanelHandle: Add rememberUrl() and assertUrlNotChanged()
[v2 8/13] StatusBarFooterHandle: Add remember*() and assert*NotChanged()
[v2 9/13] Add DeleteCommandTest
[v2 10/13] AddressBookGuiTest: Add helper methods for verification purposes
[v2 11/13] DeleteCommandTest: Remove injected clock logic
[v2 12/13] Add DeleteCommandTest#assertRunCommand()
[v2 13/13] DeleteCommandTest: Use assertRunCommand() inside assertDeleteSuccess()

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

TODO: Might as well just create a new package.

v3
@yamgent submitted v3 for review.

[v3 1/12] TestApp: Add readStorageAddressBook()
[v3 2/12] TestApp: Add getStorageSaveLocation()
[v3 3/12] TestApp: Add getModel()
[v3 4/12] AddressBookGuiTest: Expose testApp
[v3 5/12] Add WebViewUtil#getLoadedUrl()
[v3 6/12] BrowserPanelHandle: Add getLoadedUrl()
[v3 7/12] BrowserPanelHandle: Add rememberUrl() and assertUrlNotChanged()
[v3 8/12] StatusBarFooterHandle: Add remember*() and assert*NotChanged()
[v3 9/12] AddressBookGuiTest: Add helper methods for verification purposes
[v3 10/12] AddressBookGuiTest: Add assertRunCommand()
[v3 11/12] AddressBookGuiTest: Add getDefaultBrowserPanelUrl()
[v3 12/12] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc on a side note, if we are constantly deleting codacy's comments, shall we just remove using codacy totally then :P

Having all the assertion methods in AddressBookGuiTest really bloats up the class imo. I would prefer to have them inside a separate class (maybe something like SystemTestAsserts). I think it's fine that we have assertRunValidCommand (maybe can be better named) though since the cons of shifting this out as well is too high (having to pass in 1337 parameters). But shifting the rest of the assertion methods out seem to be fine.

Codacy uses checkstyle but more tools such as findbugs. We can go to codacy and disable specific rules or ignore specific violation of the rule.  But yes, we can simply disable the whole thing too.

Added @yamgent and @Zhiyuan-Amos to Codacy. You can go there and set it to ignore specific patterns or violations.

v4
@yamgent submitted v4 for review.

[v4 1/11] TestApp: Add readStorageAddressBook()
[v4 2/11] TestApp: Add getStorageSaveLocation()
[v4 3/11] TestApp: Add getModel()
[v4 4/11] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v4 5/11] StatusBarFooterHandle: Add remember*() and is*Changed()
[v4 6/11] Add AddressBookSystemTest
[v4 7/11] SystemTestAsserts: Add helper methods for verification purposes
[v4 8/11] SystemTestAsserts: Add assertRunValidCommand()
[v4 9/11] SystemTestAsserts: Add assertRunInvalidCommand()
[v4 10/11] SystemTestAsserts: Add assertStartStateCorrect()
[v4 11/11] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/4/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

For [6/11] once you are done fixing it, you can remove the commit message that it is a duplicate of AddressBookGuiTest

v5
@yamgent submitted v5 for review.

[v5 1/10] TestApp: Add readStorageAddressBook()
[v5 2/10] TestApp: Add getStorageSaveLocation()
[v5 3/10] TestApp: Add getModel()
[v5 4/10] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v5 5/10] StatusBarFooterHandle: Add remember*() and is*Changed()
[v5 6/10] Add AddressBookSystemTest
[v5 7/10] SystemTestAsserts: Add assertOnlySyncStatusChanged(...)
[v5 8/10] SystemTestAsserts: Add assertRunValidCommand(...)
[v5 9/10] SystemTestAsserts: Add assertRunInvalidCommand(...)
[v5 10/10] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v4 and v5)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/5/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

[4/11] & [5/11] header comments for public methods

v6
@yamgent submitted v6 for review.

[v6 1/10] TestApp: Add readStorageAddressBook()
[v6 2/10] TestApp: Add getStorageSaveLocation()
[v6 3/10] TestApp: Add getModel()
[v6 4/10] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v6 5/10] StatusBarFooterHandle: Add remember*() and is*Changed()
[v6 6/10] Add AddressBookSystemTest
[v6 7/10] SystemTestAsserts: Add assertOnlySyncStatusChanged(...)
[v6 8/10] SystemTestAsserts: Add assertRunValidCommand(...)
[v6 9/10] SystemTestAsserts: Add assertRunInvalidCommand(...)
[v6 10/10] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v5 and v6)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/6/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v7
@yamgent submitted v7 for review.

[v7 1/10] TestApp: Add readStorageAddressBook()
[v7 2/10] TestApp: Add getStorageSaveLocation()
[v7 3/10] TestApp: Add getModel()
[v7 4/10] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v7 5/10] StatusBarFooterHandle: Add remember*() and is*Changed()
[v7 6/10] Add AddressBookSystemTest
[v7 7/10] SystemTestAsserts: Add assertOnlySyncStatusChanged(...)
[v7 8/10] SystemTestAsserts: Add assertRunValidCommand(...)
[v7 9/10] SystemTestAsserts: Add assertRunInvalidCommand(...)
[v7 10/10] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v6 and v7)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/7/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v8
@yamgent submitted v8 for review.

[v8 1/10] TestApp: Add readStorageAddressBook()
[v8 2/10] TestApp: Add getStorageSaveLocation()
[v8 3/10] TestApp: Add getModel()
[v8 4/10] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v8 5/10] StatusBarFooterHandle: Add remember*() and is*Changed()
[v8 6/10] Add AddressBookSystemTest
[v8 7/10] SystemTestAsserts: Add assertOnlySyncStatusChanged(...)
[v8 8/10] SystemTestAsserts: Add assertRunValidCommand(...)
[v8 9/10] SystemTestAsserts: Add assertRunInvalidCommand(...)
[v8 10/10] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v7 and v8)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/8/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v9
@yamgent submitted v9 for review.

[v9 1/8] TestApp: Add readStorageAddressBook()
[v9 2/8] TestApp: Add getStorageSaveLocation()
[v9 3/8] TestApp: Add getModel()
[v9 4/8] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v9 5/8] StatusBarFooterHandle: Add remember*() and is*Changed()
[v9 6/8] Add AddressBookSystemTest
[v9 7/8] Add SystemTestAsserts
[v9 8/8] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v8 and v9)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/9/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@yamgent will review tmr morning.

BTW, is this the architecture review?

For [6/8] and [7/8], the preconditions check and the system tests checks contain different checks. We need to think through this ba. :)

@damithc I think this isn't architecture review, but we forgot to update it >< @yamgent

v10
@yamgent submitted v10 for review.

[v10 1/8] TestApp: Add readStorageAddressBook()
[v10 2/8] TestApp: Add getStorageSaveLocation()
[v10 3/8] TestApp: Add getModel()
[v10 4/8] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v10 5/8] StatusBarFooterHandle: Add remember*() and is*Changed()
[v10 6/8] Add AddressBookSystemTest
[v10 7/8] Add AppStateAsserts
[v10 8/8] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v9 and v10)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/10/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v11
@yamgent submitted v11 for review.

[v11 1/8] TestApp: Add readStorageAddressBook()
[v11 2/8] TestApp: Add getStorageSaveLocation()
[v11 3/8] TestApp: Add getModel()
[v11 4/8] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v11 5/8] StatusBarFooterHandle: Add remember*() and is*Changed()
[v11 6/8] Add AddressBookSystemTest
[v11 7/8] Add AppStateAsserts
[v11 8/8] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v10 and v11)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/11/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

May be @Zhiyuan-Amos can help out in converting the rest.

@yamgent @damithc that's a lot :O When does this need to be done by?

When does this need to be done by?

Week 4 (with one week buffer) :-)

v12
@yamgent submitted v12 for review.

[v12 1/8] TestApp: Add readStorageAddressBook()
[v12 2/8] TestApp: Add getStorageSaveLocation()
[v12 3/8] TestApp: Add getModel()
[v12 4/8] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v12 5/8] StatusBarFooterHandle: Add remember*() and is*Changed()
[v12 6/8] Add AddressBookSystemTest
[v12 7/8] Add AppStateAsserts
[v12 8/8] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v11 and v12)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/12/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v13
@yamgent submitted v13 for review.

[v13 1/9] TestApp: Add readStorageAddressBook()
[v13 2/9] TestApp: Add getStorageSaveLocation()
[v13 3/9] TestApp: Add getModel()
[v13 4/9] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v13 5/9] StatusBarFooterHandle: Add remember*() and is*Changed()
[v13 6/9] Add AddressBookSystemTest
[v13 7/9] Add AppStateAsserts
[v13 8/9] TestUtil: Add model utility methods
[v13 9/9] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v12 and v13)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/13/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v14
@yamgent submitted v14 for review.

[v14 1/11] TestApp: Add readStorageAddressBook()
[v14 2/11] TestApp: Add getStorageSaveLocation()
[v14 3/11] TestApp: Add getModel()
[v14 4/11] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v14 5/11] StatusBarFooterHandle: Add remember*() and is*Changed()
[v14 6/11] PersonListPanelHandle: Add select(int)
[v14 7/11] PersonListPanelHandleHandle: Add remember*() and is*Changed()
[v14 8/11] Add AddressBookSystemTest
[v14 9/11] Add AppStateAsserts
[v14 10/11] TestUtil: Add model utility methods
[v14 11/11] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v13 and v14)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/14/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v15
@yamgent submitted v15 for review.

[v15 1/11] TestApp: Add readStorageAddressBook()
[v15 2/11] TestApp: Add getStorageSaveLocation()
[v15 3/11] TestApp: Add getModel()
[v15 4/11] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v15 5/11] StatusBarFooterHandle: Add remember*() and is*Changed()
[v15 6/11] PersonListPanelHandle: Add select(int)
[v15 7/11] PersonListPanelHandle: Add remember*() and is*Changed()
[v15 8/11] Add AddressBookSystemTest
[v15 9/11] Add AppStateAsserts
[v15 10/11] TestUtil: Add model utility methods
[v15 11/11] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v14 and v15)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/15/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v14 contains a typo in a commit message, so I resubmitted a new iteration.

will take a look by noon tmr :)

Sorry that the review commits are rather jumbled up; was at a place with limited connectivity, and while I was reviewing halfway, the connection cut off. So I just re-read through the code again and again to see what else can be improved :P

v16
@yamgent submitted v16 for review.

[v16 1/11] TestApp: Add readStorageAddressBook()
[v16 2/11] TestApp: Add getStorageSaveLocation()
[v16 3/11] TestApp: Add getModel()
[v16 4/11] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v16 5/11] StatusBarFooterHandle: Add remember*() and is*Changed()
[v16 6/11] PersonListPanelHandle: Add select(int)
[v16 7/11] PersonListPanelHandle: Add remember*() and is*Changed()
[v16 8/11] Add AddressBookSystemTest
[v16 9/11] Add AppStateAsserts
[v16 10/11] TestUtil: Add model utility methods
[v16 11/11] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v15 and v16)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/16/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

targetPerson = getPerson(expectedModel, selectedIndex);
command = getUserInput(String.valueOf(selectedIndex.getOneBased()));
expectedResultMessage = getSuccessMessage(targetPerson);
expectedModel.deletePerson(targetPerson);

These lines of code are repeated. I’m not sure whether we can eliminate this issue by importing Pair classes or something like that, which allows us to return multiple values in a particular order.

How are we resolving this? :)

targetPerson = getPerson(expectedModel, selectedIndex);
command = getUserInput(String.valueOf(selectedIndex.getOneBased()));
expectedResultMessage = getSuccessMessage(targetPerson);
expectedModel.deletePerson(targetPerson);
These lines of code are repeated. I’m not sure whether we can eliminate this issue by importing Pair classes or something like that, which allows us to return multiple values in a particular order.

How are we resolving this? :)

See https://github.com/se-edu/addressbook-level4/pull/555#discussion_r130511400.

v17
@yamgent submitted v17 for review.

[v17 1/11] TestApp: Add readStorageAddressBook()
[v17 2/11] TestApp: Add getStorageSaveLocation()
[v17 3/11] TestApp: Add getModel()
[v17 4/11] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v17 5/11] StatusBarFooterHandle: Add remember*() and is*Changed()
[v17 6/11] PersonListPanelHandle: Add select(int)
[v17 7/11] PersonListPanelHandle: Add remember*() and is*Changed()
[v17 8/11] Add AddressBookSystemTest
[v17 9/11] Add AppStateAsserts
[v17 10/11] TestUtil: Add model utility methods
[v17 11/11] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v16 and v17)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/17/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

v18
@yamgent submitted v18 for review.

[v18 1/11] TestApp: Add readStorageAddressBook()
[v18 2/11] TestApp: Add getStorageSaveLocation()
[v18 3/11] TestApp: Add getModel()
[v18 4/11] BrowserPanelHandle: Add rememberUrl() and isUrlChanged()
[v18 5/11] StatusBarFooterHandle: Add remember*() and is*Changed()
[v18 6/11] PersonListPanelHandle: Add select(int)
[v18 7/11] PersonListPanelHandle: Add remember*() and is*Changed()
[v18 8/11] Add AddressBookSystemTest
[v18 9/11] Add AppStateAsserts
[v18 10/11] TestUtil: Add model utility methods
[v18 11/11] Convert DeleteCommandTest to DeleteCommandSystemTest

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v17 and v18)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/555/18/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.


AttributeError: 'UserManager' object has no attribute 'find' with GOOGLE_SSO_AUTO_CREATE_USERS = False

UserManager has no method find.  This is used with GOOGLE_SSO_AUTO_CREATE_USERS = False via django_google_sso/views.py(98)callback().
https://github.com/chrismaille/django-google-sso/blob/79ba9869ddb2dcf66ae62174ad3e71da046427dc/django_google_sso/main.py#L152
Maybe filter was meant to be used there?
The following patch fixes it, using a single query always:
diff --git i/django_google_sso/main.py w/django_google_sso/main.py
index c749c7a..d4b75a2 100644
--- i/django_google_sso/main.py
+++ w/django_google_sso/main.py
@@ -149,6 +149,7 @@ def check_for_permissions(self, user):

     def find_user(self):
         user_model = get_user_model()
-        query = user_model.objects.find(email=self.user_email)
-        if query.exists():
-            return query.get()
+        try:
+            return user_model.objects.get(email=self.user_email)
+        except user_model.DoesNotExist:
+            return None

Note that there is no user message in case a user is not found (and not auto-created) - should there be a hint in this case?

Good catch. It is indeed a typo - find did not exists in default django Manager. 👍🏾


Go binaries don't run on the VMWare ESXi shell

According to wikipedia ESXi runs a modifed Linux kernel which provides the ESXI shell and ssh services.
Some rclone users have been attempting to run go binaries on that kernel which seems reasonable since it supplies a Linux OS.
However the binaries segfault immediately.
What version of Go are you using (go version)?
go version devel +123fd4640a Sun Jul 9 19:23:41 2017 +0000 linux/amd64

What operating system and processor architecture are you using (go env)?
The target OS is VMWare ESXi  6.5
I compiled the binary on Ubuntu 17.04 amd64
What did you do?
I compiled a hello world program  and ran it on VMWare ESXi 6.5
What did you expect to see?
Hello, World!

What did you see instead?
It produced this
[root@localhost:~] ./hello
Segmentation fault (core dumped)

I tried compiling with CGO_ENABLED=0 and  CGO_ENABLED=1 with no difference.
I copied a binary (xz) from the ESXi platform and it ran fine on my Ubuntu 17.04 amd64 laptop indicating that the platforms aren't a million miles apart.
I tried to statically compile gdb but failed, and the coredumps I could make are in zdump format which I haven't managed to decode, so I haven't made any progress debugging this.
The desire for this originally came from https://github.com/ncw/rclone/issues/1578 where some rclone users were wanting to use it on ESXi.
The whole idea of running go on ESXi may be out of scope for the Go project as the VMWare linux kernel is clearly heavily customized.
I managed to set up VMWare ESXi on VirtualBox if anyone wants to have a go.  Here are some hints..

Install VMWare latest in Virtualbox
Make sure you give it 2 CPUs and 4 GB of ram
Disable USB otherwise it panics - you'll have to change the default pointing device to PS/2 from tablet
Start it in Virtualbox with host networking
When installed

Press F2, log in with the password you put in during the installation process
Enable ssh so you can log in from your laptop under Troubleshooting options

It may be possible to get a Go binary to run on ESXi since some statically linked Linux binaries do, but according to VMware the kernel is proprietary and not based on Linux.

Also, the Service Console was a sort of hidden Linux VM used in ESX. ESX was discontinued years ago. The Service Console doesn't exist in ESXi which instead provides users a BusyBox shell running directly on vmkernel.

@vcabbage wrote:

It may be possible to get a Go binary to run on ESXi since some statically linked Linux binaries do, but according to VMware the kernel is proprietary and not based on Linux.

The binaries I looked at (specifically /bin/xz) were dynamically linked.  /bin/xz worked on my ubuntu laptop, but the one from my ubuntu laptop didn't work on ESXi complaining about GLIBC versions.

Also, the Service Console was a sort of hidden Linux VM used in ESX. ESX was discontinued years ago. The Service Console doesn't exist in ESXi which instead provides users a BusyBox shell running directly on vmkernel.

Yes it seems to be called "ESXi Shell" in the config options - I'll update the issue with that name.  I know nothing about ESXi so thanks for the note!

To the best of my knowledge the ESXi hypervisor is based on kernel
2.4.something and probably lacks the expected 2.6.27 or later syscalls.
On Wed, 9 Aug 2017, 17:37 Nick Craig-Wood<EMAIL_ADDRESS>wrote:

@vcabbage https://github.com/vcabbage wrote:
It may be possible to get a Go binary to run on ESXi since some statically
linked Linux binaries do, but according to VMware the kernel is proprietary
and not based on Linux.
The binaries I looked at (specifically /bin/xz) were dynamically linked.
/bin/xz worked on my ubuntu laptop, but the one from my ubuntu laptop
didn't work on ESXi complaining about GLIBC versions.
Also, the Service Console was a sort of hidden Linux VM used in ESX. ESX
was discontinued years ago. The Service Console doesn't exist in ESXi which
instead provides users a BusyBox shell running directly on vmkernel.
Yes it seems to be called "ESXi Shell" in the config options - I'll update
the issue with that name. I know nothing about ESXi so thanks for the note!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/21347#issuecomment-321178033, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAcA7o411pAicZCFjquYJjeujoeY0tbks5sWWGcgaJpZM4OxDxK
.

If @davecheney is correct then there is nothing we can reasonably do here.  Sorry.


How can I control the non-player vehicles so that the vehicles can form into columns/teams controlled by some policy.

Can I control the other non-player vehicles?
How can I control the non-player vehicles so that the vehicles can form into columns/teams controlled by some policy (formation driving)?

Hi @tjuHaoXiaotian,
This is not yet possible but we are working on it (see #184), we expect to have it ready in the coming months.


Issue 13589: tesseract-ocr/fuzzer-api: Undefined-shift in IntegerMatcher::UpdateTablesForFeature

Issue reported by OSS Fuzz:
intmatcher.cpp:824:59: runtime error: left shift of negative value -18
 #0 0x609e27 in IntegerMatcher::UpdateTablesForFeature(INT_CLASS_STRUCT*, unsigned int*, unsigned int*, int, INT_FEATURE_STRUCT const*, ScratchEvidence*, int) tesseract/src/classify/intmatcher.cpp:824:59

The same issue is also reported when code is built with GCC sanitizers (for example when running the stringrenderer_test), see Wiki for build instructions.

This issue is addressed in pull request #2309.

Is this fixed?

This issue is fixed, see https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13589.


Terminal process stat failed

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:1.62.3
OS Version:Win11 10.0.22000

Steps to Reproduce:
1.open integrated terminal
2.start failed and report error
error code is 15700
And I searched it, here it is
Error code 15700
I tried to change my default terminal to "Windows Terminal" and roll back, doesn't works

Do you have anti-virus software that could be blocking the terminal? If so try following the instructions in https://code.visualstudio.com/docs/supporting/troubleshoot-terminal-launch
/label "needs more info" terminal

@meganrogge
Hi, I don't have any anti-virus software and windows defend was also disabled
Can't get any useful info from this help doc
Any more info if you need please tell me and I'll reply soonly

Can you share your settings.json file and also do a trace log while creating a terminal? https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-trace-logging

What hell, I uninstalled Power Shell, and everything became fine.
This might be caused by PowerShell Not Windows Power Shell
I don't understand that PowerShell was not my default terminal.


Change login username from admin to<EMAIL_ADDRESS>

Is some content missing, wrong or not clear?
By merging #16817, we should use only email address as a username for login.
However, there are some documents using admin as a username.
Describe the solution you'd like
Replacing from admin to<EMAIL_ADDRESS>Additional context
These are documents to have to might be fixed.

https://docs.open-metadata.org/v1.4.x/quick-start/local-docker-deployment
https://docs.open-metadata.org/v1.4.x/quick-start/local-kubernetes-deployment
https://docs.open-metadata.org/v1.4.x/deployment/security/basic-auth

Some contents are fixed by #16935


fix-cdu2 corrige senha na edição de usuário

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage     78.87%   78.87%
  Complexity      136      136
=========================================
  Files            30       30
  Lines           374      374
  Branches          4        4
=========================================
  Hits            295      295
  Misses           77       77
  Partials          2        2

Impacted Files
Coverage Δ
Complexity Δ

...m/ufg/listaplic/converter/StudentConverterDTO.java
94.11% <0%> (ø)
3 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0f376...53a1fa7. Read the comment docs.


tx parse error

Request URL: https://dex.binance.org/api/v1/broadcast?sync=true
Response:
code: 400
failed_tx_index: 0
message: "tx parse error"
success_tx_results: []
function:
await this.client.initChain();
await this.client.placeOrder(address,symbol,side,price,quantity,sequence,timeinforce );
parameters: side=2,sequence=null,timeinforce=1,price=0.0031,quantity=21.75

Please read the examples on how to set sequence: https://github.com/binance-chain/javascript-sdk/blob/4e32be6d263b869622e5384133a3a6db1b3ff9de/tests/client.test.js#L168

same for me

Please read the examples on how to set sequence:
https://github.com/binance-chain/javascript-sdk/blob/4e32be6d263b869622e5384133a3a6db1b3ff9de/__tests__/client.test.js#L168

Thankyou for your reply.
i have another problem, it says:-
code: 400
failed_tx_index: 0
message: "quantity(2175000000) is not rounded to lotSize(100000000)"
success_tx_results: []
where quantity is same as previous one i.e. quantity=21.75
what does it mean and how to deal with it while placing orders?
thankyou

Please read the examples on how to set sequence:
https://github.com/binance-chain/javascript-sdk/blob/4e32be6d263b869622e5384133a3a6db1b3ff9de/__tests__/client.test.js#L168

Thankyou for your reply.
i have another problem, it says:-
code: 400
failed_tx_index: 0
message: "quantity(2175000000) is not rounded to lotSize(100000000)"
success_tx_results: []
where quantity is same as previous one i.e. quantity=21.75
what does it mean and how to deal with it while placing orders?
thankyou

The error message means that your order quantity needs to be multiple of 100000000

Please read the examples on how to set sequence:
https://github.com/binance-chain/javascript-sdk/blob/4e32be6d263b869622e5384133a3a6db1b3ff9de/__tests__/client.test.js#L168

Thankyou for your reply.
i have another problem, it says:-
code: 400
failed_tx_index: 0
message: "quantity(2175000000) is not rounded to lotSize(100000000)"
success_tx_results: []
where quantity is same as previous one i.e. quantity=21.75
what does it mean and how to deal with it while placing orders?
thankyou

The error message means that your order quantity needs to be multiple of 100000000

After i figure out this problem "quantity needs to be multiple of 100000000" again i reached to https://github.com/binance-chain/javascript-sdk/issues/184#issue-472220891
same issue, where this time parameters are : side=2,sequence=6,timeinforce=1,price=0.002990795,quantity=20
sequence is generated as explained in https://github.com/binance-chain/javascript-sdk/blob/4e32be6d263b869622e5384133a3a6db1b3ff9de/tests/client.test.js#L16
two sell order was placed but now again its not working.
error in console:-
POST https://dex.binance.org/api/v1/broadcast?sync=true 400
error in HttpRequest#request Error: Request failed with status code 400
at createError (createError.js:16)
at settle (settle.js:17)
at XMLHttpRequest.handleLoad [as __zone_symbol__ON_PROPERTYreadystatechange] (xhr.js:59)
at XMLHttpRequest.wrapFn (zone.js:1166)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:425)
at Object.onInvokeTask (core.js:4620)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:424)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.runTask (zone.js:192)
at ZoneTask.push../node_modules/zone.js/dist/zone.js.ZoneTask.invokeTask [as invoke] (zone.js:499)
at invokeTask (zone.js:1540) undefined
ERROR Error: Uncaught (in promise): Error: tx parse error
Error: tx parse error
at request.js:69
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:392)
at Object.onInvoke (core.js:4629)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:391)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.run (zone.js:142)
at zone.js:873
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:425)
at Object.onInvokeTask (core.js:4620)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:424)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.runTask (zone.js:192)
at resolvePromise (zone.js:824)
at zone.js:746
at rejected (main.js:3960)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:392)
at Object.onInvoke (core.js:4629)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:391)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.run (zone.js:142)
at zone.js:873
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:425)
at Object.onInvokeTask (core.js:4620)
Response in network:-
code: 400
failed_tx_index: 0
message: "tx parse error"
success_tx_results: []

@saurabBajgain
how did you send your tx,
Here is an example:
curl https://testnet-dex.binance.org/api/v1/broadcast -d "<your tx in hex>"  -H "content-type:text/plain”

transaction is broadcasting right after calling placeOrder method of instance of BncClient

@saurabBajgain
how did you send your tx,
Here is an example:
curl https://testnet-dex.binance.org/api/v1/broadcast -d "<your tx in hex>"  -H "content-type:text/plain”

as @magmel48 said this is done by calling placeOrder method, isn't it?
after calling BncClient.pllaceOrder(..........); do we need to send tx manually as you said? if so can you please give me one example..
and same problem, sometime https://dex.binance.org/api/v1/broadcast?sync=true returns 200 with responce:-
code: 0
data: "{"order_id":"802ED92ECB2A9E73EA7BEFE4E6D0FA00D1A452AA-63"}"
hash: "7F677ABACCF6DDF2C4A185AAECCF9EF6D3D03348CEAB81828E5BB5829CE2983E"
log: "Msg 0: "
ok: true
and sometime returns
code: 400
failed_tx_index: 0
message: "tx parse error"
success_tx_results: []
with same parameter values.
Thankyou..

@saurabBajgain
You should increase the value of sequence in your transaction by one.

thankyou i got it.
for example:-in my case i am placing  sell order first and then buy order, after 15 second i want to cancel that previous sell order and buy orders, you mean here sequence for sell is 1, for buy 2 and so on, to cancel sell order sequence needs to be same as 1 (which is same for placing sell order) or it needs to be 3 (sell-1,buy-2,cancel sell-3,cancel buy-4).
please correct me if i am wrong.

@huangsuyu
successfully placed sale order :-

sucessfully placed buy order:-

but after reload browser and selecting same setting and on press of trade button:-

what might be the reason behind this kind of situation?,
where sequence is generated as explained here   https://github.com/binance-chain/javascript-sdk/blob/4e32be6d263b869622e5384133a3a6db1b3ff9de/tests/client.test.js#L168  , price and quantity is same as successfully placed order.

why it's closed if still not resolved?


Something wrong with power up initialisation

Often the internal scan controller doesn't start at power on.
Is reset ok?
Pull-ups/ downs by caravel won't work until after reset.
So either need to be added to the board or might be resolved by some firmware?

Takes 260 led flashes for board 2 to start

missing pulldowns on design select and wrong setting in the firmware led to the scan chain state machine getting confused
fixed with firmware


KerasNLP : Semantic similarity tutorial

Issue : KerasNLP/#726
Kaggle Tutorial Link
This PR ports Keras-io's existing Semantic Similarity with BERT to KerasNLP. Now the tutorial is pure Keras + tensorflow. It doesn't depend on Tensorflow at all.

cc: @mattdangerw

Thanks for the ping! Need to get better at checking keras.io PRs. Will review today!

Hi @mattdangerw !
I tried to address all comments. Please review & let me know if anything else needs to be changed. Thanks.

Hi @mattdangerw ! I tried to address all comments. Please review & let me know if anything else needs to be changed. Thanks.
Corresponding Notebook can be found here. Also you might find this thread interesting 😄 .

@mattdangerw  btw instead of just tf.data.Dataset, I used tensorflow_datasets library, totally eliminating need to download explicitly. Now the stack is pure tf :)

Hi @mattdangerw @fchollet  !
I tried to address all comments. Please review & let me know if anything else needs to be changed. Thanks.
Corresponding Notebook can be found here. Also you might find this thread interesting 😄 .

Hey @mattdangerw, The CI looks green. I think it's ready for another round of review.

Hi @mattdangerw , I tried eliminating usage of pandas entirely, and making entire workflow with tf.data only
https://www.kaggle.com/code/shivanshuman/kerasnlp-semantic-similarity-with-bert
but for some reason, it's showing nan loss everywhere. I can't seem to figure out why. Can you please take a quick look?

Left a comment https://github.com/keras-team/keras-nlp/issues/880#issuecomment-1477245047, hope that helps.

Hey @mattdangerw , it's ready for review, Phewww 😌
Sorry for delay !

Addressed the commits, @fchollet could you review and let me know if any comments?

Hi @fchollet , I would request your review on this PR, Thanks.

My git is messed up. Probably I need to uninstall and reinstall. Closing this PR from here, I have addressed the comments and opened a new PR #1299
Sorry for the inconvenience.


Many small improvements

Minor menu cleanup
Added ESP color override for the rest of the priorities
Notification customization (you can disable/enable the gradient and line)
Added an option to turn off Death and Freezecam (thanks baan) as well as an option to change static speclist height

Sorry, but #1122 caused conflicts

@lnx00 finally fixed the conflict (i couldnt help myself to press the big blue commit button)


Quoting problems on Windows

I have the following script (reduced for brevity):
set windows-shell := ["cmd.exe", "/c"]

clang := if `where clang 2>NUL || exit 0` == "" {
    error("cannot find clang compiler")
} else {
    trim(replace(`where clang`, "\\", "\\\\"))
}

test:
    {{clang}} --version

Running just test fails with the error message: 'C:\\Program' is not recognized as an internal or external command, operable program or batch file.. This is expected as that is how cmd normally operates.
Changing {{clang}} to {{quote(clang)}} fails with the error message: The filename, directory name, or volume label syntax is incorrect.. This is because quote() uses single quotes which has a specific use case on Windows, rather than double quotes which works universally.
Changing {{clang}} to "{{clang}}" fails with the error message: '\"C:\\Program Files\\LLVM\\bin\\clang.exe\"' is not recognized as an internal or external command, operable program or batch file.. I'm not entirely sure what's going on here, but the most I could conclude is that the quotations from the command are being escaped for some reason.
With these issues in mind, what is the right way to go about running executables with spaces in the file path?

I'd target PowerShell over command as I believe the quoting issues are a little easier to manage there. Either way quoting on Windows is a nightmare for many reasons. See How Command Line Parameters Are Parsed and Quotes, Escape Characters, Delimiters - Windows CMD - SS64.com for all the horror. Sorry, I'd normally figure it out for you but my Windows laptop isn't available currently.

I've tried switching to PowerShell but the errors are still present, if not worse because PowerShell doesn't seem to have the concept of a quoted file path being indicative of an executable file like with cmd.
set windows-shell := ["powershell.exe", "-NoLogo", "-Command"]

clang := if `if (Get-Command clang -ErrorAction SilentlyContinue) { Write-Host 0 }` == "" {
    error("cannot find clang compiler")
} else {
    trim(`(Get-Command clang).Source`)
}

test:
    {{clang}} --version


Removed destructors per wlroots PR 1915

This fixes issue #89.
Per pull request #1915 for wlroots (https://github.com/swaywm/wlroots/pull/1915), these destructor functions can be removed as the resources will be destroyed with the wl_display by libwayland.

Thanks @dswalla ! I hope to get around to updating Cage to the latest wlroots over the Christmas break, then I'll get around to merging this one as well :)


Fix Esaml ETS initialisation issue

Attempt to use Samly in umbrella app leading to error in config initialization:
[error] [Samly] Failed load SP certfile ["apps/itulink_web/priv/cert/selfsigned.pem"]: %{certfile: "apps/itulink_web/priv/cert/selfsigned.pem", id: "link-itu-edu", keyfile: "apps/itulink_web/priv/cert/selfsigned_key.pem"} %ArgumentError{message: "errors were found at the given arguments:\n\n  * 1st argument: the table identifier does not refer to an existing ETS table\n"}     lib/samly/sp_data.ex:67: Samly.SpData.load_provider/1
    (elixir 1.13.4) lib/enum.ex:1593: Enum."-map/2-lists^map/1-0-"/2
    lib/samly/sp_data.ex:47: Samly.SpData.load_providers/1
    lib/samly/provider.ex:70: Samly.Provider.refresh_providers/0
    (stdlib 3.17.1) gen_server.erl:423: :gen_server.init_it/2
    (stdlib 3.17.1) gen_server.erl:390: :gen_server.init_it/6
    (stdlib 3.17.1) proc_lib.erl:226: :proc_lib.init_p_do_apply/3

It can be mitigated with this change, which is not affecting anything if ETS is already running for Esaml.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@k-cross as the current maintainer for both Samly and Esaml, can you take a look over this one? Does it make sense?

Thank you, I'll need to verify a few changes soon and I'll look into this one also.

I ran into this very recently.


Fix tests failures in grouping_sets_test.py

FAILED ../../../../integration_tests/src/main/python/grouping_sets_test.py::test_nested_grouping_sets_rollup_cube

Some context: This test passes when ANSI mode is disabled.


Use interchaintest hermes tag/image instead of duplicating it in e2e tests

Summary
This is already present in interchaintest but bumping interchaintest requires bumping cosmos/proto to 1.4.10 which requires a manual bump of the sdk, reference https://github.com/cosmos/ibc-go/pull/3592.
Similar issue for rly: https://github.com/cosmos/ibc-go/issues/3615

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Talked with @chatton about this, decided its best if we explicitly manage the image/tag ourselves and explicitly bump as required.


Provide dependencies at right scope

Is your feature request related to a problem? Please describe.
Currently every dependencies is provided at @Singleton scope. This is not a good approach. Some components like UseCase can be provided only when we need to use it in ViewModel
Describe the solution you'd like
Provide UseCases at ViewModelScope instead of Singleton
Describe alternatives you've considered
None

Hi @hieuwu,
Can I try for this issue?


Is it OK for Handler to Send/Publish

Hi,
Is is OK from design PoV for Handlers to Send() or Notify() more Commands / Queries. If not, what would be the alternative to Handler needing to notify of some event or access a service that is normally accessed by Send()ing a query?

We do it but jimmy has indicated that it can get messy and is not ideal.  Shared functionality between handlers can still be abstracted as you normally would with an interface and shared service.  This may end up that a mediator query or command simply passes through to the shared service, but you still are tied into the shared pipeline behaviors that you don't get by calling the service directly.

here is another issue where it is discussed https://github.com/jbogard/MediatR/issues/434

I am implementing caching and I was wondering about the same thing.
Id like to notify multiple re-caching notifications in my command handler when updating, deleting or adding something to the database.
But seeing as it is not recommended I am not sure how to approach this.

I wouldn't say it is "not recommended". As Jimmy points out in the linked thread, his personal experience with nested handlers was not too good. (note: I think he's talking about nested request handlers, not a Request handler sending out notification).
My advice would be to go with what you (or the team) feel most comfortable with. In your caching use-case, I personally would go that route. (Controller sends a request, request handler does the main work and sends a "invalidate cache" notification).
This is pretty simple structure and if you and your colleagues feel good about it, go with it!

Yes - this is nested request handlers. Notifications are fine inside a request handler.


Tablet initialization on aarch64 Linux throws NullReferenceException

When attempting to run osu!lazer on aarch64 NixOS through NIXPKGS_ALLOW_UNFREE=1 NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix shell --impure nixpkgs#osu-lazer-bin (which builds version 2023.511.0) followed by running the osu! binary, the following error is thrown and the game crashes:
Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at osu.Framework.Input.Handlers.Tablet.OpenTabletDriverHandler.Initialize(GameHost host)
   at osu.Framework.Platform.GameHost.initialiseInputHandlers()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at osu.Desktop.Program.Main(String[] args) in /build/source/osu.Desktop/Program.cs:line 120

It seems to potentially be related to #5423.
It would of course be best to fix the underlying issue for aarch64 Linux systems (works on the same machine on aarch64 Darwin/macOS), but it could temporarily be worked around by disabling only the built-in tablet drivers if they fail to initialize instead of preventing osu! from launching.

It's the same issue, please make a post in that issue thread with your added details.


Help! Strict Parsing Does not work

why is strictParsing not working? If I turn it to true, I can type in whatever numbers and alphabetical characters I want.
Codepen below for reference. Does anyone have any idea on how to fix this?
http://codepen.io/anon/pen/RVxdMx

Sorry, I'm not sure exactly what the issue is.  Can you provide more detail?  I would suggest following the issue template.
If I had to guess though I'd offer that moment's strictParsing requires a format to be specified.  Also, I don't believe using the strictParsing prop (react-datetime) restricts what is typed in the input (only what is accepted).


Stalling HelpWindowTest

Current minimal reproduction:
package seedu.address.ui;

import org.junit.Test;
import org.testfx.api.FxRobot;
import org.testfx.api.FxToolkit;

import javafx.scene.Scene;
import javafx.scene.web.WebView;
import javafx.stage.Stage;

public class HelpWindowTest {
    @Test
    public void test() throws Exception {
        FxToolkit.registerPrimaryStage();
        FxRobot fxRobot = new FxRobot();
        fxRobot.interact(() -> {
            Stage stage1 = new Stage();
            stage1.setScene(new Scene(new WebView()));
            Stage stage2 = new Stage();

            // Order in which stages are shown does not matter
            stage1.show();
            stage2.show();
        });

        // May or may not stall here depending on your luck
        fxRobot.interact(() -> {});
    }
}

The factors are as follows:

Headless mode
Two stages, one with a WebView, one with no scene.
~The WebView must be loading a web page with custom fonts~ (WebView does not need to be loading anything at all)
Show stage1 and stage2

The factors are as follows:

Headless mode
Two stages, one with a WebView, one with no scene.
Show stage1 and stage2

fwiw, I still don't know the exact cause of this issue. However this issue is annoying enough that I'll submit a PR to fix this by removing one of the above factors.


v10.5.2 pod not found

My question is simple , I just can not find the latest pod of v10.5.2 . Sorry , I don't know if I am too early to update because it has been 14 hours since it released .
[!] CocoaPods could not find compatible versions for pod "RealmSwift":
  In Podfile:
    RealmSwift (= 10.5.2)

None of your spec sources contain a spec satisfying the dependency: `RealmSwift (= 10.5.2)`.

@sacredsoul the issue is on our end, we are working on a fix.

Issue has been resolved, closing.


not sure how to use sign and verify methods

trying to use hyperlog with @substak signing example and i am not really sure how to use it.
once i include a identity: keys.publicKey in the log options, what does that do with the stored keys ?
When does the verify method is invoked to check the signature ?

identity is just a value that will be added as a key/value to every hyperlog node that's created. It's then your responsibility to write the functions sign and verify that use that value to sign and verify node, respectively. verify gets invoked as new nodes are added (either locally or remotely via replication), which can be at any time.

@noffle thanks for your kind reply. i have been digging into hyper[*] and getting a better undertanding of the merkle tree and it's DAT implementation's as well.


separate count-buttons from project img

heyhey, nice start
some of repos have this buttons, which is more "statuses" then "img shown what pkg do"

will be better to group them by camo.githubusercontent.com (and exclude from main list) and show in separate view

@rohozhnikoff great suggestion!! We'll do this :D

We no longer show images on the directory (after the redesign). In the future we may add this feature back, but for now I'm going to close this issue.


Merge refs/heads/update-dependencies into alpha

Merge refs/heads/update-dependencies into alpha

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308311004. Thanks for your contribution!


[Bug Fix]   SIGINT-1578:  No error messages are displayed, if mandatory fields are empty in the Jenkins Freestyle script

Form validations added for the mandatory fields of the freestyle UI.

change changelist to -SIGQA3 in pom.xml


uptimekuma - fix typo

Description
fixes a typo

All Submissions:

[x] Have you ensured there aren't other open Pull Requests for the same update or change?
[x] Have you created a new branch for your changes and PR from that branch and not from your master branch?

New Image Submissions:

[ ] Have you added your image to the Github workflows?
[ ] Have you updated the README list to contain your new image?

This builds for arm64. So make the cloudflared logic adapt to that please. You can use the base logic that is in the debian image.

This builds for arm64. So make the cloudflared logic adapt to that please. You can use the base logic that is in the debian installer image.

which Debian Image you mean?

This builds for arm64. So make the cloudflared logic adapt to that please. You can use the base logic that is in the debian installer image.

which Debian Image you mean?

Debian installer one. Has some basic logic to only install some things on amd64

ah ok. i'll check it later

RUN         if [ "$(uname -m)" = "x86_64" ]; then \
                curl -L https://github.com/cloudflare/cloudflared/releases/latest/download/cloudflared-linux-amd64 -o /usr/bin/cloudflared \
            else \
                curl -L https://github.com/cloudflare/cloudflared/releases/latest/download/cloudflared-linux-arm64 -o /usr/bin/cloudflared \
            fi

RUN          chmod +x /usr/bin/cloudflared

Should work but please test

closed because of https://github.com/parkervcp/yolks/pull/189


bottomNavigationBar selectedLableStyle color property not working

//this is the code
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      bottomNavigationBar: BottomNavigationBar(
          currentIndex: _selectedIndex,
          selectedLabelStyle: TextStyle(
              fontWeight: FontWeight.bold,
              color: Color.fromRGBO(55, 32, 104, 1.0),
              fontSize: 10),
          onTap: _bottomNavBarNavigator,
          type: BottomNavigationBarType.fixed,
          items: [
            BottomNavigationBarItem(icon: Icon(Icons.home), label: 'home'),
            BottomNavigationBarItem(icon: Icon(Icons.camera), label: 'scan'),
            BottomNavigationBarItem(icon: Icon(Icons.bookmark), label: 'saved'),
            BottomNavigationBarItem(icon: Icon(Icons.person), label: 'profile'),
          ]),
      body: pages[_selectedIndex],
    );
  }

tarekteshome@192 project_samaritan % flutter doctor -v
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.5.1 21G83 darwin-arm, locale en-ZA)
    • Flutter version 3.0.5 at /Users/tarekteshome/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (3 months ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/tarekteshome/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/tarekteshome/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8815526/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Android Studio (version 2021.2)
    • Android Studio at /Users/tarekteshome/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8815526/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.1)
    • IntelliJ at /Users/tarekteshome/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/222.3739.54/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.2)
    • IntelliJ at /Users/tarekteshome/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/222.3345.118/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        • android-arm64  • Android 13 (API 33) (emulator)
    • iPhone 13 Pro Max (mobile)  • EC54A57B-FA18-439F-A60C-61583E4012D2 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)             • macos                                • darwin-arm64   • macOS 12.5.1 21G83 darwin-arm
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @tarik350, you appear to be on an older version of flutter.
Kindly upgrade to the latest version of flutter to see if you still experience this issue. If you do, please provide the updated output of flutter doctor -v.
Thank you

actually it worked when i set the selectedItemColor property of bottomNavigationBar. initially i was trying to set the color from selectedLableStyle. I still don't understand why it won't work in this way, but I'll upgrade and see if it does.

@tarik350 i feel you should use the selectedItemColor property since it does the work. I would also want to know if you would love to set the color for the text differently?


Release v3.6.7

Features

Allow Safe apps to request Safe balances (#2316)
Improve error handling for Safe apps (#2340)

Fixes

Fix typo in queue list (#2335)
Fix address array was printed in one line on transaction details (#1758)

Chores

Cleanup truffle left files (#2333)
Add additional context property to CodedException (#2334)
Add ETHGasStation API key (#2328)

Didn't find any issues during regression.
Also the tickets listed were checked, except "Cleanup truffle left files (#2333)" and "Add additional context property to CodedException (#2334)" since are not functional and can't be checked from the user's side
Tests on xdai and volta were ignored for this regression
Looks good to me


希望能有顺序标注，这样减少下拉时间。有截图文档说明。

VSCode Version:
OS Version:

Steps to Reproduce:

Reproduces without extensions: Yes/No

希望能有顺序标注.docx

I cannot understand the issue. @octref can you please help and assign to the right person.

I think he means the lino in the suggestion list like the input method.

@HaibaraAi5 这是你的图，请解释什么是“顺序标注”和“减少下拉时间”。谢谢。


Use SelfSubjectAccessReview to check ODLM's permission on getting catalog

What this PR does / why we need it:

ODLM will check its get permission on resource catalogsources in catalog namespace

hasCatalogPermission := m.CheckResAuth(ctx, pm.Status.CatalogSourceNamespace, "operators.coreos.com", "catalogsources", "get")

ODLM will create object SelfSubjectAccessReview to validate its permission on certain resources

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65427
Test

Deploy SC2 dev build with global catalog in openshift-marketplace namespace
Update ODLM CSV to update ImagePullPolicy to Always, change the verbosity from -v=1 to -v=2 and patch image quay.io/daniel_fan/odlm:1b6ff4cb-dirty
Create an OperandRequest to deploy ibm-im-operator
IBM IAM Operator should be deployed successfully
Review ODLM logs, the operator has permission to get catalog in openshift-marketplace namespace.I1129 22:02:03.727047 1 reconcile_operator.go:49] Reconciling Operators for OperandRequest: cs4-data/ibm-iam-request
I1129 22:02:03.755976 1 manager.go:248] Operator get permission in namespace openshift-marketplace for Kind: catalogsources, Allowed: true, Denied: false, Reason: RBAC: allowed by ClusterRoleBinding "operand-deployment-lifec-4K9igqY0bHgV6bQIglRyJ3RqddvJ8xuUotaKnq" of ClusterRole "operand-deployment-lifec-4K9igqY0bHgV6bQIglRyJ3RqddvJ8xuUotaKnq" to ServiceAccount "operand-deployment-lifecycle-manager/cs4-control"
I1129 22:02:03.757168 1 manager.go:248] Operator get permission in namespace openshift-marketplace for Kind: catalogsources, Allowed: true, Denied: false, Reason: RBAC: allowed by ClusterRoleBinding "operand-deployment-lifec-4K9igqY0bHgV6bQIglRyJ3RqddvJ8xuUotaKnq" of ClusterRole "operand-deployment-lifec-4K9igqY0bHgV6bQIglRyJ3RqddvJ8xuUotaKnq" to ServiceAccount "operand-deployment-lifecycle-manager/cs4-control"
I1129 22:02:03.757183 1 manager.go:248] Operator get permission in namespace openshift-marketplace for Kind: catalogsources, Allowed: true, Denied: false, Reason: RBAC: allowed by ClusterRoleBinding "operand-deployment-lifec-4K9igqY0bHgV6bQIglRyJ3RqddvJ8xuUotaKnq" of ClusterRole "operand-deployment-lifec-4K9igqY0bHgV6bQIglRyJ3RqddvJ8xuUotaKnq" to ServiceAccount "operand-deployment-lifecycle-manager/cs4-control"
I1129 22:02:03.759136 1 manager.go:222] Found 1 CatalogSources for PackageManifest cloud-native-postgresql in the namespace cs4-control has channel stable-v1.22
I1129 22:02:03.759156 1 manager.go:226] The 0th sorted CatalogSource is ibm-operator-catalog in namespace openshift-marketplace with priority: 0

/retest


feat(protocol-kit): add short name for peaq Network

What it solves
Adds short name for peaq Network
Chainlist:
https://chainlist.org/chain/3338
peaq 1.4.1 safe deployment:
https://github.com/safe-global/safe-deployments/pull/709

I have read the CLA Document and I hereby sign the CLA

Added in #936


user can't download data even if logged in

This is a bug that pops up every now and then for Facebase: https://github.com/informatics-isi-edu/facebase-project/issues/104
We haven't figured out how to reproduce it and sometimes it resolves on its own.

User is logged in
User tries to download data file
User gets Authentication error saying they need to be logged in to download data.

Based on my tests, the error occurs when the hostname from the URL is just facebase.org.
It works as expected when the hostname is specified as www.facebase.org.

This is being fixed in https://github.com/informatics-isi-edu/facebase-project/issues/105 via new .htaccess rules

I think this issue was fixed and tested on facebase production now, so this issue can be closed?

this bug is fixed. however, I just noticed a new bug. when you are not logged in and try to download, instead of getting the "Authentication Required" page, you get a generic Internal Server error:
Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.
Please contact the server administrator at root@localhost to inform them of the time this error occurred, and the actions you performed just before this error.
More information about this error may be available in the server error log.
I'll close this issue but open a new one for this bug

On which server are you seeing this internal server error?

production


[DNM] Test global CI for #13952

Didn't want to interrupt running CI in https://github.com/firebase/firebase-ios-sdk/pull/13952
#no-changelog

Results look satisfactory to me.


pull request for e2e test at 01/08/2017 02:26:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Empty Uncaught Exceptions are flooding my test results

What is your Test Scenario?

I'd like my tests to pass without the test results spamming me with empty uncaught exceptions
What is the Current behavior?

Test results say my tests failed due to uncaught exceptions, but the videos show the test runs all the way through and passes on the front end.
What is the Expected behavior?

TestCafe reports back that the test passed OR it provides information on the uncaught exceptions.
What is your web application and your TestCafe test code?

Your website URL (or attach your complete example):

Your complete test code (or attach your test files):

 fixture `editor`
  .page `reborncf.com/users/sign_in`
  .beforeEach(async t => {
    await t
      .maximizeWindow()
    await LoginPageObjects.login_with_password(data.users.account_owner.user_email, data.users.account_owner.user_password)
  })

test
  .meta({ createdOn: '08/10/21', createdBy: '', updatedOn: '09/28/21', updatedBy: '' })
  .meta({ scope: 'functional', priority: 'low', showstopper: 'no' })
  .meta({ ptOriginalId: '', ptAutomationId: '' })
  .after(async t => {
    await PagesPageObjects.delete_existing_page(page_name_1)
  })
  ('user_is_able_to_add_a_section_column_row_and_element_to_editor', async t => {

    // Purpose: To check that a section, row, and element can be added in the editor

    // Global variable to pass to the .after steps
    globalThis.page_name_1 = 'Add section row and element'

    await WorkspaceMainNavPageObjects.navigate_to_workspace_sites()
    await SitesPageObjects.navigate_to_pages_page()
    await PagesPageObjects.create_new_page(page_name_1)
    await HelperObjects.choose_existing_link(page_name_1)

    while(EditorPageObjects.iframe_edit_page().visible == false){
      await t
        .wait(.250)
    }

    await t
      .switchToIframe(EditorPageObjects.iframe_edit_page())

    await EditorPageObjects.add_full_page_section_to_page()
    await EditorPageObjects.add_1_column_row_to_page()
    await EditorPageObjects.add_headline_element_to_page()

    // Asserts the headline was added to the page
    await t
      .expect(EditorPageObjects.txt_call_to_action_headline_in_page.visible).ok()
  })

Your complete configuration file (if any):

{
    "assertionTimeout": 5000,
    "browsers": [
        "chrome --window-size=1920,1159"
    ],
    "concurrency": 7,
    "filter": {
        "testGrep": []
    },
    "pageLoadTimeout": 30000,
    "reporter": {
        "name": "spec",
        "output": "artifacts/reports/test_suite_results"
    },
    "screenshots": {
        "path": "artifacts/screenshots",
        "pathPattern": "${TEST}_${DATE}_${TIME}.png",
        "takeOnFails": true
    },
    "selectorTimeout": 15000,
    "skipJsErrors": true,
    "src": "tests",
    "videoEncodingOptions": {
        "aspect": "16:9",
        "framerate": 30
    },
    "videoOptions": {
        "failedOnly": true,
        "pathPattern": "${TEST}_${DATE}_${TIME}.mp4",
        "singleFile": false
    },
    "videoPath": "artifacts/recordings"
}

Your complete test report:

editor
 ✖ user_is_able_to_add_a_section_column_row_and_element_to_editor

   1) - Error in test.after hook -
      Uncaught exception:

      Error:

      Browser: Chrome 94.0.4606.71 / macOS 10.15.7

 ✖ pop_up_element_displays_during_page_preview

   1) Uncaught exception:

      Error:

      Browser: Chrome 94.0.4606.71 / macOS 10.15.7

 ✖ clicking_button_shows_hides_elements

   1) Uncaught exception:

      Error:

      Browser: Chrome 94.0.4606.71 / macOS 10.15.7

 ✖ user_is_able_to_save_when_adding_a_video

   1) Uncaught exception:

      Error:

      Browser: Chrome 94.0.4606.71 / macOS 10.15.7

 ✖ user_is_able_to_save_when_leaving_video_embed_blank

   1) Uncaught exception:

      Error:

      Browser: Chrome 94.0.4606.71 / macOS 10.15.7

Screenshots:

Video attached of test passing

https://user-images.githubusercontent.com/87319403/136227489-2124fe67-5b68-40f5-bb11-b8100d3289d4.mp4

Steps to Reproduce:

Go to my website ...
Execute this command...
See the error...

Your Environment details:

testcafe version:                   1.15.2
node.js version:                    14.18.0
command-line arguments:
browser name and version: See test results
platform and version:          See test results
other:

Thank you, @Farfurix. I have sent an email to<EMAIL_ADDRESS>to get this moving forward.

@jbradenclickfunnels
Hello,
I reproduced a lot of errors in headless/non headless mode under Windows 10. Your project is quite complex and I suggest starting with this socket error. Please reply to my comment here: https://github.com/DevExpress/testcafe/issues/6558#issuecomment-940823659.

I'm not sure if this is related, or if you need me to open a separate ticket.
We're experiencing an uncaught exception for our Safari based tests (Safari desktop, and using BrowserStack iPhones):
Uncaught object "[object Object]" was thrown. Throw Error instead. I can provide some example tests, which result in this failure

@rob4629
Hello,
It's better to create a new one with your example and a link to this issue. While fixing, we will check all usage cases.

Hi @jbradenclickfunnels,
Please check if the issue is still reproduced in the latest version. I cannot do it since it is not possible to download files with imported page models. If it is still reproduced, please attach the code for page models to this thread. You can remove the credentials from them as we already have them.

My comment is no longer relevant. I created a separate ticket #6624 which has subsequently been fixed. Thanks


CI: switch from Travis CI to GitHub Actions

Achieved by running github-actionify.sh.

ping @tinevez I'm not sure if you had seen this.
Deployment with Travis doesn't work any more because of discontinued credentials for maven.scijava.org. This pull request migrates mastodon over to GitHub actions.

Indeed I forgot about it. Thank you Jan!

I need to do the same for all other mastodon deps.


File glob not working for climo years formatted 00XX

ADF run type
Model vs. Model
What happened?
Expected behavior
In the config yaml file when working with climo years in the format 00XX (ie 0001 or 0010, etc.) the glob should only grab the range of years specified by the start_year and end_year.
Bug behavior
It seems for this climo year format for start_year and end_year, the ADF is grabbing all available files.
Example
For test case b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.011 with h0 files located at:
/glade/scratch/hannay/archive/b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.011/atm/hist/
for climo years:
start_year: 0001

end_year: 0009

The actual years grabbed when creating time series are 0001-0021
case ts files at: /glade/scratch/richling/adf-output/climo_yrs_bug/case-ts/
Similarly for baseline case: b.cesm3_cam058_mom_c.B1850WscMOM.ne30_L58_t061.009 at:
/glade/scratch/hannay/archive/b.cesm3_cam058_mom_c.B1850WscMOM.ne30_L58_t061.009/atm/hist/
with the same start and end climo years, the actual years grabbed are 0001-0063
baseline ts files at: /glade/scratch/richling/adf-output/climo_yrs_bug/baseline-ts/
Tested config yaml
/glade/u/home/richling/adf_config_files/tests/config_climo_yrs_bug.yaml
ADF Hash you are using
2ea95d0
What machine were you running the ADF on?
CGD machine
What python environment were you using?
NPL (CISL machines only)
Extra info
This was run from one of my branches, as well as the main branch of the ADF. I have not checked if this only happens w/ 00XX formatted climo years.
I will look into this and will request assistance if I can't find the problem.

Closing this, issue has been taken care of in PR #205


patch nodejs examples

The generated examples (imported from terraform) are using a wrong package assuming in some cases that it belongs to the organization pulumi. In some cases it imports it correctly but then references it with equinix instead of the generated alias pulumi_equinix. Identifying/fix this error in the pulumi code is quite complex, because as I explained, it doesn't even act uniformly, so patching them is a short-term solution.
Many of these examples are not even being generated for other SDKs and at the moment it seems that it would be better to use overlays for these, and be able to continue taking advantage of the terraform bridge, instead of creating a native provider. I will open a new issue to work on improving the examples / documentation, but them aren't mandatory for a first release

How can I test this?

@ctreatma here's a good list of prerequisites https://github.com/pulumi/pulumi-tf-provider-boilerplate#prerequisites
Then:
make cleanup
make clean
make provider
make build_nodejs

The generated sdk/nodejs content should look like the one included in this PR
There shouldn't be any line in the *.ts files containing:
import * as pulumi_equinix from "@equinix/pulumi-equinix
Or duplicated imports
import * as equinix from "@equinix/pulumi-equinix";
import * as equinix from "@equinix/pulumi-equinix";

Is there a way to run the examples in-place, or do I need to copy the code for an example to a separate file in order to run it?

You need to copy them to a separate folder/file. Those examples are encoded in a comment and somehow https://github.com/pulumi/docs/ consume them to generate the documentation in the portal
So if you want to run one those typescript examples checkout this guide https://github.com/pulumi/pulumi-tf-provider-boilerplate#sample-program


Update To Support 0.23.4

i have updated the admin_service.py file to support the newest version of pocketbase

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
319 unchanged lines in 18 files lost coverage.
Overall coverage decreased (-35.5%) to 52.876%

Files with Coverage Reduction
New Missed Lines
%

pocketbase/stores/base_auth_store.py
1
87.18%

pocketbase/services/health_service.py
3
78.57%

pocketbase/models/utils/base_model.py
3
85.29%

pocketbase/models/backups.py
4
71.43%

pocketbase/models/file_upload.py
4
53.85%

pocketbase/services/collection_service.py
4
66.67%

pocketbase/services/settings_service.py
5
52.94%

pocketbase/services/files_service.py
7
40.0%

pocketbase/services/log_service.py
8
54.84%

pocketbase/client.py
9
84.16%

Totals

Change from base Build<PHONE_NUMBER>5:
-35.5%

Covered Lines:
591

Relevant Lines:
991

💛  - Coveralls