Correction for raw affiliation Artemis; Department of Ophthalmology, University Eye Hospital of Wuerzburg, Wuerzburg, Germany;; Eye Centers of Frankfurt, Hanauer Landstraße, Frankfurt, Germany,

Correction needed for raw affiliation Artemis; Department of Ophthalmology, University Eye Hospital of Wuerzburg, Wuerzburg, Germany;; Eye Centers of Frankfurt, Hanauer Landstraße, Frankfurt, Germany,
raw_affiliation_name: Artemis; Department of Ophthalmology, University Eye Hospital of Wuerzburg, Wuerzburg, Germany;; Eye Centers of Frankfurt, Hanauer Landstraße, Frankfurt, Germany,
new_rors: 03pvr2g57;01bv0ma93;03e2b2m72
previous_rors: 03pvr2g57;031ah7413;01bv0ma93;03e2b2m72
works_examples: W4376155234
contact: cdd9895b8fa0a2007ffddf959294d2b0:a5130f5e466ce674044c00b33f @ univ-cotedazur.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


App "AboutAndHelp" dialog not working in Android 10

For that Android version (API 29), the WebView for the dialog about_and_help_dialog appears empty.

Workaround: just convert it to a dialog with a custom layout and load things there in various TextViews. Do not use WebView loading HTML. This will do fine.

Update: this seems to start happening because of the inline CSS style added when working on #22.


onchange event not dispatched

Hello,
In recent browser (ex: Chrome 69) select2 doesn't trigger onchange event (when use vanillaJS addEventListener) of linked select element.
The documentation states that onchange event is dispatched when user clicks and not necessary on set value by JS.
https://developer.mozilla.org/en-US/docs/Web/Events/change#Description

I was about to open a new issue to report the exact same problem, so +1 on this one for me too.

I face this issue too, a fix would be great.

I created a new issue for this bug with details and sample.


Don't specify webauthn transports

Fixes #13062.
Since we're not restricting the transport options at registration time, or storing the transport used during registration, we don't actually know what transports should be used at assertion time. Instead, we should just omit this restriction and allow all transport types.
Per https://github.com/duo-labs/py_webauthn/blob/c3c6c21f76937b08aed089897fe595f8b9232cdf/webauthn/helpers/structs.py#L271 these are optional.

This will present users with all webauthn transports their browser supports, but if they try to use one they haven't registered previously, they'll see something like this dialog:

that transport kwarg was just copy pasta from the library docs during the last major upgrade, and doesn’t serve a specific purpose as far as I recall. 👍


dora now points to revrand/legacygp

small changes to the legacygp code to allow dora to point to it correctly

please accept this pull request first before the corresponding pull request for dora

Current coverage is 56.17%

Merging #44 into master will increase coverage by +0.02% as of b216ab8

@@            master     #44   diff @@
======================================
  Files           32      32
  Stmts         1658    1659     +1
  Branches         0       0
  Methods          0       0
======================================
+ Hit            931     932     +1
  Partial          0       0
  Missed         727     727

Review entire Coverage Diff as of b216ab8

Powered by Codecov. Updated on successful CI builds.


Road to release:  Cleanup folder naming / structure

Recorder needs to entirely live under a single folder if possible so people can move/clean/manage it easily.  Currently it makes a 'Unity' and a 'UTJ' folder in the root which is not typical asset behavior

Create a 'Recorder' root folder

Rename the UTJ folder into something more obvious / clear and put that in the Recorder folder

note: UTJ is NOT part of the Recorder, it's a separate github project.
At the moment, I'm bundling it in for convenience.

moved everyting FrameRecorder related to /Assets/FrameRecorder


Quake 2 Port: Slow, wrong resolution selected as standard

ArkOS 1.4 (lastest online update) -> Quake 2 Port
When starting Quake 2, you'll notice that it's really slow.
I looked into the core options and found that the resolution is set to 960 x something.
Setting the resolution back to 320 x something fixes that.
Maybe set the lower resoultion as new standard, people MIGHT think that the RG351p is not powerful enough to play Quake 2 ;)

Good point.  I will do that with the next update.

This has been resolved in the update released earlier today.


The repository cache of the created PR page was not cleared, resulting in an error

Version: main
UI: dev-c6aa521
Commit ID: f514ec2420f872bc122787a9da4766ed261577ce
Env: MacOS 13.1, Apple M2
Test Steps:

Add a version control connector.

Click Cancel and do not refresh the page. Click Create a PR again.
Select a repository when no connector selected.

Test Result:

In step4, returned an error.

View the api request.

Environment

Walrus version: v0.5.1

Test Result: Fixed.


Support query profile persist

Firstly, thanks for your contribution. @ikaruga4600
Could you please create an issue to discuss this feature? In the issue, you can tell tell the feature's background. And others should know how to use this feature and developers should know how you implement it.

.

Thanks for your reply, i have aleady create an issue for this PR #319

Firstly, thanks for your contribution. @ikaruga4600
Could you please create an issue to discuss this feature? In the issue, you can tell tell the feature's background. And others should know how to use this feature and developers should know how you implement it.

Thanks for your reply, i have aleady create an issue for this PR #319


revert: "Merge pull request #1791 from budde377/feature-adding-no-col…

…ors-to-run-command"
Fixes #1894, #1895
This reverts commit 56073fc3f72a88aac3d748ef02030af1a9b20da3, reversing
changes made to b7d591f2545cc24cf621dbc4a12652bec346ffaf.

Thank you for your contribution. We detected an issue with your commit message though and would ask you kindly to fix it.

Commit: 94b6f8c6dfeecbc379cf04696b6889d15ca5be29
Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html and please do not hesitate to ask if you have any questions.

This message was auto-generated by https://gitcop.com

Thank you for your contribution. We detected an issue with your commit message though and would ask you kindly to fix it.

Commit: 334a5dba3c5bfb19646de6b4fa5b18f43f349a5c
Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html and please do not hesitate to ask if you have any questions.

This message was auto-generated by https://gitcop.com

Thank you for your contribution. We detected an issue with your commit message though and would ask you kindly to fix it.

Commit: 96ebdc458f9e4ea8bc96d7461183d13826394ba9
Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html and please do not hesitate to ask if you have any questions.

This message was auto-generated by https://gitcop.com


copr: shouldn't check invalid dates when using chunk format. (#7218)

Signed-off-by: wshwsh12<EMAIL_ADDRESS>
What problem does this PR solve?
Cherry-pick https://github.com/tikv/tikv/pull/7218

@iosmanthus @breeswish PTAL

/run-all-tests

/merge

/merge

/run-integration-tests


Update version to 0.0.18

Current dependencies on/for this PR:

main

PR #444   👈

This stack of pull requests is managed by Graphite.


Comparison with Viewhance

How does BetterViewer compare with Viewhance? I am looking for a robust, feature rich image viewer to replace Viewhance which has been removed from the Chrome extension store for a couple of years now.
If this issue thread isn't the right place for my question, please move/delete accordingly.
Thanks!

Thank you @Bamajon1974 for your question.
I don't know about Viewhance
I've tried it and It's very cool extension 😮 I don't know why it's deleted from Chrome extension store...
This is my honest comparison:

Feature
BetterViewer
Viewhance

Zoom in / Zoom Out / Reset
✅
✅

Fullscreen
✅
❌

Rotate Left / Rotate Right
✅
✅

Flip Horizontal / Flip Vertical
✅
✅

Crop Image
✅
❌

Paint
✅
❌

Download Image
✅
❌

Upload Image to imgBB
✅
❌

Color picker
✅
❌

Image Details
✅
❌

Change background color (Dark / Light / Blurred)
✅
✅

Print Image
✅
❌

Extract Text from Image
✅
❌

Edit in Photopea (Thanks to @bbbenji)
✅
❌

Reverse Image Search (using TinEye)
✅
✅

QR Code Scanner
✅
❌

Settings to customize Toolbar
✅
✅

Default sizing modes and switching between them via shortcuts or with mouse clicks
✅
✅

Custom CSS (background color for the page or media, hidden scrollbars...)
⚠(Not CSS Modification but you can modify the background)
✅

Custom information about the media in the tab title
❌
✅

Floating menu (mouse cursor over the top-left)
❌
✅

Mouse wheel zooming (off by default)
✅
✅

Centering content (default)
✅
✅

Rotate/Flip (via shortcuts or from the menu)
✅
✅

Sending the address of the media to different services (such as reverse image search)
⚠ Not customizable but exists
✅

Frame extraction for animated images (GIF, APNG, WEBP)
❌
✅

Handling SVG and data:URIs
⚠ Working on it (Available in the next version)
✅

Forced inlining (show media instead of download)
❌
✅

Native DASH, HLS, MSS streaming (if the browser can support it)
❌
✅

Customizable media attributes (autoplay, loop, controls, mute, volume)
❌
✅

Opening images from regular web-pages with right long-press or with shortcut (off by default)
❌
✅

Try BetterViewer and Viewhance! They are both great


[Joy] Accordion component

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Joy UI is missing the Accordion component family. It is one of the common components that have all the accessibility specs.
Examples 🌈

Mantine Accordion
Chakra Accordion
Bootstrap Accordion

Motivation 🔦
Please upvote this issue if you need this component. It will help us prioritize the next component that we should work on!

@siriwatknp  One of the components that I think is also in high demand specially for dashboards, I include myself, is the Drawer.

@siriwatknp One of the components that I think is also in high demand specially for dashboards, I include myself, is the Drawer.

Hey, thanks for the feedback! Would you mind open an issue to like this one for the Drawer component?

@siriwatknp Sure! Here is it #36292

Joy UI is just so amazing. An active development of the accordion component is very necessary.

@ekabeblessed In the meantime, you can integrate Radix with Joy UI. Here is an example https://mui.com/joy-ui/react-accordion/#integration-with-headless-ui-libraries


Tweak the Record an Exchange page

Cool. Rebased (was 9869b2972d3da32f3e2d75659ff8fcb581011bd0) and ready to merge when you are @nobodxbodon! 👍


don't schedule sending when stream.Write is called after the deadline

Fixes #1045. Should be merged after #1043.

Codecov Report

Merging #1046 into master will decrease coverage by 0.04%.
The diff coverage is 95.53%.

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage    90.8%   90.75%   -0.04%
==========================================
  Files         104      106       +2
  Lines        7192     7222      +30
==========================================
+ Hits         6530     6554      +24
- Misses        428      432       +4
- Partials      234      236       +2

Impacted Files
Coverage Δ

packet_packer.go
90.35% <ø> (-0.17%)
:arrow_down:

streams_map.go
92.22% <100%> (ø)
:arrow_up:

stream_framer.go
96.88% <100%> (-0.63%)
:arrow_down:

internal/flowcontrol/base_flow_controller.go
100% <100%> (ø)
:arrow_up:

crypto_stream.go
100% <100%> (ø)
:arrow_up:

server_tls.go
73.83% <100%> (ø)
:arrow_up:

session.go
83.33% <75%> (-0.48%)
:arrow_down:

stream.go
88.24% <88.89%> (-7.71%)
:arrow_down:

send_stream.go
95.71% <95.71%> (ø)

receive_stream.go
97.26% <97.26%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0eb12b...bd3d9fa. Read the comment docs.


move: support automated address management

Description
This PR adds automated address management support for sui client publish and sui client upgrade. Note sui move build invocations will now also make a network request to determine the chain_id to resolve addresses in the Move.lock. The chain_id is resolved early in sui commands and propagated down where published ID resolution is needed.
High-level:

If a package contains a Move.lock that contains info to support a package upgrade, then that is used, and a user does not have to (nor should they) maintain a published-at address in their Move.toml.

If a package does not have any Move.lock information to support a package upgrade, we will still fallback to Move.toml as we do today. Nothing changes.

If a package has both a Move.lock and Move.toml, then the Move.lock will be used (the user is free to delete published-at in their Move.toml). Caveat: If a published address is in both of these files, they must be the same (we will raise a Conflict error message otherwise).

Note: docs to follow and merge at the same time as this PR, particularly this section on upgrades

Note after this PR it is still required to set [addresses] to 0x0 in Move.toml. This requirement will be removed after publish support is added (which also requires setting to 0x0 still). I didn't want to meddle with that logic all at once.

Test plan
How did you test the new or updated feature?
We cover three cases:

Upgrade with Move.toml only (existing package upgrade test)

Upgrade with Move.lock only (extension of existing package management test)

Upgrade with Move.lock and Move.toml with conflicting addresses error condition (new test)

Existing e2e tests pass

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Overall looks good but keeping off-line execution of Move commands seems important

Move commands aren't entirely offline though? We need to check for and pull in dependendencies. Caching helps but it doesn't remove the general online requirement.
There may be some rationale to keep some of the build process offline but whatever that looks like I suspect it is not going to be smooth once we introduce .move resolvers and compiling on-chain deps.
I'll pull in more discussion here from slack, but it seems somewhat unavoidable in the long run. A fallback to None effectively disables the ability to automatically manage addresses (we will never know which chain's dependencies to use). So it will only be useful in a testing / debug / local setting (for which we need a connection to some network in most contexts already). For example there was only one sui move test in the repo that needed to be updated to use a local network for testing.

The reasoning makes sense. Do we run sui move build during cargo build for Sui, right? Loosing the ability to build Sui off-line would (selfishly) be rather inconvenient.

@awelc fair, I think there might be some ways to help with that. I'll fold it into the discussion.

@awelc fair, I think there might be some ways to help with that. I'll fold it into the discussion.

Thank you! I am sorry to be a bit (?) picky about this, but I am also not going to stand in the way of progress if it's decided that sacrifices need to be made

@amnn yes, accurate! Working on fixing up the sui move build case. Will re-request when ready!

Please take another look!
@hayes-mysten could you throw an eye on the TypeScript changes? I think I addressed your feedback here (using a tmpt folder and other nits).
@awelc @amnn it looks like we don't need to populate any published IDs for the move build case after all, that code path is (silently) resilient to the case where published IDs are not resolved (as with Move.toml before). I don't love that it's silent and might prefer that we explicitly resolve published IDs only when we need to, but that comes at the expense of more complicated changes. I may revisit in future if we think it's worth separating those concerns.

My understanding was that automated address management would also supplant this, using the original IDs for all packages as their [address]

Yes indeed! I put a note in the PR description, expect this to be up soon.


Missing website file

@Linda-Editor I'm not sure where else to post this issue
I'm getting a 404 response on this file
/en-us/_themes/docs.theme/master/en-us/_themes/global/js/fetch.min.js.map
when viewing:
https://docs.microsoft.com/en-us/Office/VBA/Language/Glossary/VBE-Glossary#Null
Which is causing a long delay in on the site load time. It will eventually scroll to the correct glossary term; however I have to wait forever for the page to load fully.
it looks like this script:
/_themes/docs.theme/master/en-us/_themes/global/js/highlight.pack.js?v=10.11.2017
is waiting for the file before it finishes loading the page.
is there someone on the website team who can check to make sure the file is hosted in the correct path with the correct visibility permissions?

if it helps here's my IE network traffic from the F12 dev menu
(note: as seen on row 18)

Row
URL
Protocol
Method
Result
Type
Received
Taken
Initiator
Wait??
Start??
Request??
Response??
Cache read??

@Kagre can you please confirm that you can reproduce the bug in a modern browser, such as Edge?

If this error is still occurring when using Edge browser, not IE, please reopen and will investigate further.

It shouldn't matter(much) which browser was used as this was a server side issue; however it appears to be resolved now and I see no need to reopen.
also the link changed:
VBE-Glossary: Null


Render chaperone behind character models.

Running from the small room size, the chaperone is always overly sensitive, as you may guess we tend to spend most of the time on the floor, where the controllers or headset will trigger the grid; or by the computer keyboard, which tends to be on a corner of the chaperone. A grid covering the waifu creates a confusing depth problem with the closer models rendering behind the far grid.
Can you please make the chaperone render behind player models? If possible i can help debug as i been studying Unity, and just a little bit in Unity VR mythology.

You can turn chaperone off using openvr advanced settings. Or set trigger distance to minimum.

I guess we must work within our means. That openvr advanced settings program works ok for the situation, i am surprised it never turn up when searching results about chaperone visibility control. Thank you.
Still, controlling rendering order for this Unity hack should be considered. I'm going to close my issue as i can work with the new settings.


Add: Partition Array Into Three Parts With Equal Sum

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #460   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         157    158    +1
  Lines        1562   1574   +12
=====================================
+ Hits         1562   1574   +12

Impacted Files
Coverage Δ

...partition_array_into_three_parts_with_equal_sum.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54bdeaa...dc41201. Read the comment docs.


Goerli sync Receipt root is different than expected

Describe the bug
Reth cannot sync Goerli, with a Lighthouse CL connected
Steps to reproduce
reth compiled from main April 23rd, exact commit unsure. Lighthouse v4.1.0-693886b
Sync Goerli on a fresh DB
Node logs
reth-test-execution-1  | 2023-04-24T14:25:52.640781Z  INFO Executing stage stage=TotalDifficulty from=8884001
reth-test-execution-1  | 2023-04-24T14:25:52.640861Z  INFO Stage finished executing stage=TotalDifficulty checkpoint=8884002
reth-test-execution-1  | 2023-04-24T14:25:52.640922Z  INFO Executing stage stage=Bodies from=8884001
reth-test-execution-1  | 2023-04-24T14:25:52.704371Z  INFO Stage finished executing stage=Bodies checkpoint=8884002
reth-test-execution-1  | 2023-04-24T14:25:52.704782Z  INFO Executing stage stage=SenderRecovery from=8884001
reth-test-execution-1  | 2023-04-24T14:25:52.711751Z  INFO Stage finished executing stage=SenderRecovery checkpoint=8884002
reth-test-execution-1  | 2023-04-24T14:25:52.711873Z  INFO Executing stage stage=Execution from=945000
reth-test-execution-1  | 2023-04-24T14:25:52.855889Z  INFO Wrote network peers to file peers_file="/home/reth/.local/share/reth/net/goerli/known-peers.json"
reth-test-execution-1  | Error: A stage encountered an irrecoverable error.
reth-test-execution-1  |
reth-test-execution-1  | Caused by:
reth-test-execution-1  |    0: Stage encountered a execution error in block 949580: Receipt root 0xb27f1dc67592ce2ebb787e69d69828f9d132b34c8e30a21172e648c6b3b4f810 is different than expected 0x16ff1d39c31524e19c5733ef03e7a4502a3b377a74cbe9f4b2de5eb494b0568c..
reth-test-execution-1  |    1: Receipt root 0xb27f1dc67592ce2ebb787e69d69828f9d132b34c8e30a21172e648c6b3b4f810 is different than expected 0x16ff1d39c31524e19c5733ef03e7a4502a3b377a74cbe9f4b2de5eb494b0568c.
reth-test-execution-1  |
reth-test-execution-1  | Location:
reth-test-execution-1  |     bin/reth/src/node/mod.rs:341:9
reth-test-execution-1  | 2023-04-24T14:25:54.065988Z  INFO reth 0.1.0 starting

### Platform(s)

Linux (x86)

### What version/commit are you on?

April 23 commit built around 21:00 UTC, unsure which exact commit would have been pulled

### Code of Conduct

- [X] I agree to follow the Code of Conduct

Full debug-level logs for Reth
reth-goerli-exec-fail.log.gz

Ah. @rkrasiuk I think related to #2255.

Repro'd with reth node --debug.tip 0xf6afd080f96ec307e4e94e0d30999cc60dac084a0cdfca1b24ce5f3a82461f11. Investigating - thanks!

it's the transaction in block https://goerli.etherscan.io/txs?block=949580
which reth determines to be out-of-gas

cast run 0xa8ce86c5ce681f4ecd40f25d70d044a3ec5099ca3453ab6c91fadbe896745487 -v
Executing previous transactions from the block.
Traces:
  [126749] 0x2d079CEaAB6B09b2BF209Afa0D13Ba2e2a097f27::bid{value:<PHONE_NUMBER>00000000}()
    ├─ [0] 0xC2A4db14F797A6dB12f6a8fa52B17b7a2597F736::fallback{value:<PHONE_NUMBER>0000000}()
    │   └─ ← ()
    ├─ [0] 0x0000000000000000000000000000000000000000::fallback{value:<PHONE_NUMBER>000}()
    │   └─ ← ()
    └─ ← "EvmError: OutOfGas"

Transaction failed.
Gas used: 148996

cc @rakita this seems like a REVM issue?

We have pinned this down - relating to https://eips.ethereum.org/EIPS/eip-225 & Clique on Goerli. The COINBASE opcode during the execution of this transaction is paying 0xe0a when the block was mined by 0x8b2. So we need to extract the extraData from the header and use that.

Hey @rakita ! The dream of a Rust EL is not dead :)


linkedIn

trying out linkedin with abap2UI5 content at the moment, eg:
https://www.linkedin.com/posts/abap2ui5_abap-sapui5-opensource-activity-7210630218036752384-couW
or here:
https://www.linkedin.com/pulse/abap2ui5-integration-sap-business-technology-platform-13-installation-lf1re
probably will post from time to time more abap2UI5 stuff there, so everyone feel free to follow:
https://www.linkedin.com/company/abap2ui5
@choper725 if i post something about the topics you PR (eg. Chart.js) - if you want to be mentioned as the contributor, just let me know your linkedIn name (here or via PM). if this is not your wish, of course no problem, just want to make sure having asked

not on there :) go at it, its fine !


fp, p, p1 and p2 are instrumental and planetary parameters

This PR makes the following parameters both instrumental and planetary parameters: fp, p, p1 and p2.


Merge into upstream

@makash @riyazwalikar
Do you have objections to merging this work back into the upstream for other users of Threat Dragon? I can probably do it myself but I'd like to get your approval first.
https://github.com/OWASP/threat-dragon/issues/9

@kuwv I have given you some more permissions on the Threat Dragon repo, and can assign https://github.com/OWASP/threat-dragon/issues/9 to you once you accept
Personally I think you should go ahead with this work +1

Too divergent. Clossing.


interface bug

top of page is hidden by the top bar:
https://sli.mg/EC35XO

Just made a fix, is it better ?

Yep, it's fixed now, thanks.

Hi, again, similar problem: https://s4.postimg.org/40ozvb55p/rea_de_Transfer_ncia01.jpg


Error handling/testing

Need to think about the different parts of our application and how to return out useful errors to the user- need to account for the different libraries like our fastify/redis and how to inform the developer of it.


[PALOMABOT] As a user, I want to see the Palomabot for Aave Yield so that I am able to deposit a token to start the bot

As a user, I want to see the Palomabot for Aave Yield so that I am able to deposit a token to start the bot.
Acceptance Criteria

Implement UI for the Aave Yield Chaser Bot.
Change the name of the bot to Paloma Aave High Yield Bot.
Add to Palomabot UI page of bots.
Add Deposit transaction Fee as the currrent Price of a Paloma LightNode
Add / Complete Payment of LIghtNode with successful deposit and payment of transaction fee.

@joycehermosilla will you add the Figma link for the Ui here?

https://discord.com/channels/987730379182051408/1065140873811218532/1303072725375516766
(There's no epic. It's very simply. Just add the Lightnode purchase fees as the bot transactionf ee.
When you star the bot, you are also buying  a Paloma LightNode
Folks prefer getting it as a bonus vs. paying for it first.
So we just make it the transaction cost to start the bot)

Shipped.


change wording

gets rid of contraction to make more formal

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

changed wording


[Bug]: Check Airtime balance

Description
For checking the airtime balance, the wait is too long, shows an error before the actual balance message, and when you click the continue button, the status is pending.
Steps to reproduce

Open the Stax app
Tap on the SIMs option
Select a sim card
Tap the Check balance button

Expected result
Balance message
Actual result
Error message and a pending status
Link to screenshots/screen recordings
https://drive.google.com/file/d/1CTTLSC0o_w61BUiG8QOBSwlWOTZW252V/view?usp=sharing
Device name
No response
Android OS
No response
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
b300f70d67ca4412

This has been reported before, will close it for now and track as previously reported.


make all DATETIME-related functions microsecond-aware

Feature request
here is a checklist from gensrc/script/functions.py

[ ] least
[ ] greatest
[ ] year
[ ] year
[ ] month
[ ] month
[ ] quarter
[ ] dayofweek
[ ] to_date
[ ] date
[ ] day
[ ] dayofmonth
[ ] dayofmonth
[ ] day
[ ] dayofyear
[ ] weekofyear
[ ] week
[ ] week
[ ] hour
[ ] hour
[ ] minute
[ ] minute
[ ] second
[ ] second
[ ] years_add
[ ] years_sub
[ ] months_add
[ ] months_sub
[ ] add_months
[ ] weeks_add
[ ] weeks_sub
[ ] days_add
[ ] days_sub
[ ] date_add
[ ] date_sub
[ ] adddate
[ ] subdate
[ ] hours_add
[ ] hours_sub
[ ] minutes_add
[ ] minutes_sub
[ ] seconds_add
[ ] seconds_sub
[ ] microseconds_add
[ ] microseconds_sub
[ ] years_diff
[ ] months_diff
[ ] weeks_diff
[ ] days_diff
[ ] hours_diff
[ ] minutes_diff
[ ] seconds_diff
[ ] datediff
[ ] timediff
[ ] now
[ ] current_timestamp
[ ] localtime
[ ] localtimestamp
[ ] str_to_date
[ ] date_format
[ ] unix_timestamp
[ ] dayname
[ ] monthname
[ ] convert_tz
[ ] utc_timestamp
[ ] date_trunc
[ ] timestamp
[ ] time_slice
[ ] time_slice
[ ] if
[ ] ifnull
[ ] nullif
[ ] coalesce
[ ] array_avg
[ ] array_min
[ ] array_max
[ ] array_distinct
[ ] array_sort
[ ] reverse
[ ] array_slice
[ ] array_concat
[ ] arrays_overlap
[ ] array_intersect
[ ] array_slice
[ ] array_sortby

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Hi @kateshaowanjou , can you assign this function to me？ I will make it, Thank you. it's me, reapply :)

May I know more about what this issue is trying to do?

@iiiuwioajdks Hi, let me give you more context.
The current DATETIME type of StarRocks is only accurate to the second level. Next we need support down to the microsecond level.  The existing DATETIME-related function implementations do not consider how to deal with microseconds.
To do this we need to make sure that each function handles microseconds correctly by doing the following:

Sort out the functions currently involved in the datetime type, which I have listed in the description
You can go to gensrc/script/functions.py to find the implementation of each function on BE
If this function cannot handle microseconds, make corresponding changes to make it work
Whether or not you modify the function itself, you need to add enough unit tests for it to ensure correctness. you can refer to be/test/exprs/time_functions_test.cpp to add a unit test case.

If you have any questions, please feel free to contact me, I will reply you in time

嗨，让我给你更多的背景。
StarRocks目前的DATETIME类型只精确到第二级。接下来，我们需要微秒级的支持。现有的与 DATETIME 相关的函数实现不考虑如何处理微秒。为此，我们需要通过执行以下操作来确保每个函数正确处理微秒：

整理日期时间类型中当前涉及的函数，我在描述中列出了这些函数
你可以去 查找 BE 上每个函数的实现gensrc/script/functions.py
如果此函数无法处理微秒，请进行相应的更改以使其正常工作
无论是否修改函数本身，都需要为其添加足够的单元测试以确保正确性。可以参考添加单元测试用例。be/test/exprs/time_functions_test.cpp

如果您有任何问题，请随时与我联系，我会及时回复您

I don't seem to see anything in the documentation about how to do unit tests for sr, I run . /run-be-ut.sh to compile, it gives me an error and takes a long time

嗨，让我给你更多的背景。
StarRocks目前的DATETIME类型只精确到第二级。接下来，我们需要微秒级的支持。现有的与 DATETIME 相关的函数实现不考虑如何处理微秒。为此，我们需要通过执行以下操作来确保每个函数正确处理微秒：

整理日期时间类型中当前涉及的函数，我在描述中列出了这些函数
你可以去 查找 BE 上每个函数的实现gensrc/script/functions.py
如果此函数无法处理微秒，请进行相应的更改以使其正常工作
无论是否修改函数本身，都需要为其添加足够的单元测试以确保正确性。可以参考添加单元测试用例。be/test/exprs/time_functions_test.cpp

如果您有任何问题，请随时与我联系，我会及时回复您

I don't seem to see anything in the documentation about how to do unit tests for sr, I run . /run-be-ut.sh to compile, it gives me an error and takes a long time

@iiiuwioajdks what kind of error did you encounter? let me help you take a look

Like this, I'm on a mac m1 system, using the centos container provided by sr

@iiiuwioajdks thanks for your feedback, I will try it on my own env and reply you later

Can you assign array_avg task for me? @kateshaowanjou

Hi, @silverbullet233 ,and I use starrocks 3.1 in docker. But it seem that datetime data can not be generated through datetime(varchar) as specificd: https://docs.starrocks.io/en-us/2.1/sql-reference/sql-statements/data-types/DATETIME

I am working on this now, and please assign more task such as now() and timestamp() to me.

@silverbullet233 It seem that the array_avg`s output is abnormal.

@SilvaXiang thanks for your feedback. actually, array is not supported in array_avg/array_sum function, here it is cast to array before computing agg function, which is a little confusing. we will fix it later.

Hello @silverbullet233  , what is the query evaluation process? I changed TimeFunctions::now function, and I also insert some file-writing functions(OStream) to make myself aware that the TimeFunctions::now is be invoked. But I add the microsecond awareness, I query select now(). But the result is also as pervious. And the file is also not be writed.

Hello @silverbullet233 , It also seem that the code execution path of select now() and select now(int) is different?
What is the meaning of now(int) ???

@kateshaowanjou I am working on this now, and please assign more task such as current_timestamp(), localtime(), localtimestamp() to me. Thanks!

wow, I feel your enthusiasm! Thanks for working on these issues. If you have any questions you can also join our Slack or wechat group for discussion: https://853921.ma3you.cn/articles/b12e90J/

@kateshaowanjou I am working on this now, and please assign more task such as current_timestamp(), localtime(), localtimestamp() to me. Thanks!


pytest 6 support

When using this plugin against pytest 6.1.0, I get the following error:
INTERNALERROR> Failed: Direct construction of BanditItem has been deprecated, please use BanditItem.from_parent.
INTERNALERROR> See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.

Is this plugin compatible with the 6.x versions of pytest?

Thanks for the fix, @tomdottom. Closing this out with the release of 0.6.1


Removing 278260, it's a duplicate of 278259

It looks to me like recipe 278260 is a duplicate of 278259. Hence removing it.

Got spot, yes identical.


Refactor overlay and world chat view

I wanna to work on normal chat view but end up cleaning bunch of code in overlay, world-preview-card, and renamed the chat to world-chat (so it does't conflict with normal chat).

WorldChat view scrollback and incoming message works (scrollback problem was with styling), but sending message doesn't seems to work in world rooms. (Enable to check if it doesn't work in normal room)

LGTM, WorldPreview cleanup looks great and separating WorldChat sounds good as well.


Quasar Framework

Overview of the feature request
Be able to generate the app using vuejs together with quasar framework

Give the possibility of generating the app with quasar as an alternative option to boostrap
Motivation for or Use Case
Quasar framework is a very good option which allows the creation of apps made with vuejs that compile any architecture using electron and cordova. It also has a set of components based on material design that are very attractive.

With quasar framework we can program using our graphic interface once and compile it both for a web application, such as PWA, as a Desktop application for Windows, Linux and MacOS using electron. It also allows us to compile for mobile platforms such as Android and IOS using cordova
Related issues or PR

[+] Checking this box is mandatory (this is just to show you read everything)

Hi @yuniel-acosta,
all our frontends are based on bootstrap and maintaining multiple templates depending on the frontend framework is way too much effort as we all do this in our freetime. So sorry there won't be a quasar option.


Angular 9 - "Cannot read property 'element' of undefined" with the example

Hi, I am trying to use viser-ng (2.5.2) in my angular 9 project. I moved the example of Line chart to my project but got
Cannot read property 'element' of undefined"
"stack": "getViewType (webpack:///node_modules/viser-ng/__ivy_ngcc__/es/Chart.js:270:)\nChart (webpack:///node_modules/viser-ng/__ivy_ngcc__/es/Chart.js:92:)\nfac (webpack:///node_modules/viser-ng/__ivy_ngcc__/es/Chart.js:471:40)\nsetIncludeViewProviders (webpack:///node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:3919:43)\nisComponentDef (webpack:///node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:8325:24)\ncreateDirectivesInstances (webpack:///node_modules/@angular/core/__ivy_ngcc__/fesm5/core.js:7704:4)\nisDirectiveHost

My HTML code is
    <div fxLayout='column' fxFlex.gt-sm='47%'>
      <v-chart [height]="height" [data]="data" [scale]="scale">
        <v-tooltip></v-tooltip>
        <v-axis></v-axis>
        <v-line position="year*value"></v-line>
        <v-point position="year*value" shape="circle"></v-point>
      </v-chart>
    </div>

and data in Component is
  height = 400;

  data = [
    { year: '1991', value: 3 },
    { year: '1992', value: 4 },
    { year: '1993', value: 3.5 },
    { year: '1994', value: 5 },
    { year: '1995', value: 4.9 },
    { year: '1996', value: 6 },
    { year: '1997', value: 7 },
    { year: '1998', value: 9 },
    { year: '1999', value: 13 },
  ];

  scale = [{
    dataKey: 'value',
    min: 0,
  }, {
    dataKey: 'year',
    min: 0,
    max: 1,
  }];

Can anyone please help and see what could be wrong.

+1

me too!


Audio change causes bitrate change

Have you read the FAQ and checked for duplicate issues: Yes
What version of Shaka Player are you using: v2.1.3
Can you reproduce the issue with our latest release version: Yes
Are you using the demo app or your own custom app: Yes
What browser and OS are you using: Chrome 58/ macOS 10.12
What are the manifest and license server URIs: Angel One stream in the demo
What did you do?  Load, switch to the lowest bitrate and switch to 'de' audio language
What did you expect to happen?
The video should play with the lowest bitrate.
What actually happened?
The video switched to the highest bitrate.

I can reproduce this easily, but we need to investigate more to decide how we could solve this.

@yairans Do I understand correctly that by "switch to the lowest bitrate" you mean "manually select a variant that has low bitrate"?
I don't think we currently have an assumption that when a new variant is selected due to a language change it should take current variant's bandwidth as a guideline.
This is something we can introduce, but it isn't an obvious conclusion.
If it's something we'd like to have, I can think of two ways of approaching it:

Implicit: when new variant is chosen due to a language change, treat current variant's bandwidth as a guideline.
Explicit: introduce a way to explicitly set bandwidth guidance (we have bandwidthUpgradeTarget and bandwidthDowngradeTarget configs, but may be we need something more explicit).
@joeyparrish let me know what you think!

Explicit sounds like too much effort for the app developer.  If we can do it at all, I believe in this case it should be implicit.
If the app selects a specific variant (low res, for example) and disables ABR (as the demo does when you select a variant), then it is a surprise to the app developer (and therefore end user) when the res changes to something higher on language change.  Even though the user has enough bandwidth, this change in res is essentially an automated one, which is surprising when ABR is turned off.  We should, as much as we can, avoid surprising devs & end-users.
This could be a little tricky to fix, since the system behaves very generically today.  If there's a language change, AbrManager is given new things to choose from and makes a choice.  It all follows from simple rules.
To fix it, we may have to give AbrManager some guidelines or restrictions, or perhaps even cut AbrManager out of the loop entirely on language changes if ABR is disabled.  This means more complex rules for this action.  Hopefully, we could avoid surprises while also avoiding undue complexity.  We'll have to see what we can do.

BTW, I'm not sure is relevant here, but when I switch any track (video, audio and text) I get the 'adaptation' event, unlike the documentation 'AdaptationEvent
Fired when an automatic adaptation causes the active tracks to change. Does not fire when the application calls selectVariantTrack() selectTextTrack(), selectAudioLanguage() or selectTextLanguage().'

There is a similar issue for multi-Period content.  If someone manually selects a track, when it switches to the next Period, AbrManager will select the tracks for the new Period. This can result in bandwidth changes.

This is complicated.
With ABR disabled, we could try to maintain the previous resolution or bitrate whenever we are forced to select new streams.  This would apply both to language changes as in @yairans's scenario, and to period changes as described by @TheModMaker.  But this will not always produce good results.
Assume the following perfectly reasonable-looking periods, in which not all resolutions are available across periods:
period 1 - TV show: 1080p (selected by user), 720p, 480p
period 2 - ad break: 480p only
period 3 - TV show: 1080p, 720p, 480p
When switching to period 2, we can only choose 480p.  There are no other streams.  When switching to period 3 with ABR disabled, we would stick with 480p in period 3, even though we might have been forced into 1080p by the user during period 1.
This solution could be as surprising to the user as the bug, but at least now we will not ever choose a resolution for which we don't have enough bandwidth.  Imagine the inverse of the above periods:
period 1 - TV show: 1080p, 720p, 480p (selected by user)
period 2 - ad break: 720p only
period 3 - TV show: 1080p, 720p, 480p
Here we would wind up at 720p in period 3, even though the user forced the player into 480p in the first period.  In period 3, we may end up buffering a lot and never switching down to 480p.  This is clearly worse than choosing new streams at the period transition based on current bandwidth.
I feel as though this applies to language transitions as well as period transitions, but I'm not certain.

In the multi-period scenarios, fundamentally, there seems to be a conflict between what you intend to do (choose a particular resolution) and what the API says (choose a particular track).  Tracks do not extend across periods, and we don't have a "choose resolution" method.
For languages, it may be easier to resolve.  The best-effort "maintain bitrate" goal I suggested above may be good enough if applied solely to selectLanguage().  I will experiment with this.

If the user has selected a particular resolution, it may be a reasonable work-around for applications to listen for TracksChangedEvent and then call selectVariantTrack() with the best match to the user's selection in the app's UI.  This would work for both language and period transitions.
It would still be best for the Player to handle this, but it's complicated by the lack of a clear intent to stick to a given resolution.  Again, because selectVariantTrack() does not mean "select resolution", and tracks don't extend to other periods or languages.


Version 1.49.8 install broken (Missing VERSION file)

Don't know when this happened, but we fixed our pip-req file on version 1.49.8, and installing that now drops an error:
pip install "TileStache==1.49.8" --upgrade

File "/srv/env/build/TileStache/setup.py", line 8, in
version = open('VERSION', 'r').read().strip()
IOError: [Errno 2] No such file or directory: 'VERSION'```

It's 2018!

It's 2018!


Style/OptionHash is possibly overeager

First, I know this is disabled by default, so it's not super critical. However, I'd love to enable this cop by default in my projects.
I have the following function signature:
def get_unique_photo(photo_size = :large, used_photos = {})

used_photos isn't an option hash - it actually stores data that we use to calculate certain properties. I could change this to keyword arguments to get around this cop (or locally disable), but it doesn't seem like the right solution.
What do you think of changing this so it only errors out for options = {}, args = {}, or some other whitelist of acceptable names?
@maxjacobson - this was originally added in https://github.com/bbatsov/rubocop/issues/2030

hey @wli!
I did consider that...
What would the list be? I started thinking about people programming Ruby using non-English words for variable names and got dizzy

Curious to hear from @yob and @bbatsov on this

I can see how maintaining a list can be a nightmare. Maybe you can make an option on the cop for individual projects to specify their own whitelist/blacklist? Then rubocop-the-project doesn't care, but it'll work for more use cases.

I'm OK with having a list of param names that would trigger the offense.

@wli I think that's a great idea.  Maybe with some safe defaults: options and args makes sense.  Maybe look at rails/rails to get some more ideas?

Just throwing out more ideas for defaults: rest, params, parameters...

Sounds reasonable.
On 6 August 2015 at 12:10, Jeff Felchner<EMAIL_ADDRESS>wrote:

Just throwing out more ideas for defaults: rest, params, parameters...
—
Reply to this email directly or view it on GitHub
https://github.com/bbatsov/rubocop/issues/2106#issuecomment-128300870.

--
Best Regards,
Bozhidar Batsov
http://www.batsov.com

I took a stab at this: https://github.com/bbatsov/rubocop/pull/2114

Fixed by https://github.com/bbatsov/rubocop/pull/2114


config(engine): remove deprecated session-ttl config from executor

What problem does this PR solve?

Issue Number: ref #6849
What is changed and how it works?
session-ttl is used in etcd based session, it is no longer used after #6949
Since it is break compatibility, we also need to update template in tiflow-operator.
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-engine-integration-test

/merge

/run-integration-test

/run-integration-test


Update identity governance and basic authenticator versions

$subject

We don't need the PR builder for this, as each of these updated components has verified with the PR builder.


Hack grammar contains invalid Oniguruma token \xff

This line in the Hack grammar is an invalid Oniguruma pattern. When vscode-textmate encounters an invalid patter it silently fails until the end of the line or file. So whatever it's intended to do is not happening.
The error in this pattern is the use of [^...\\x7f-\\xff]. From context, it's easy to figure out that the author meant for this to exclude, among other things, the range from code point U+007F to U+00FF. And although that's what it would do in nearly every modern regex engine, that's not what it's doing in Oniguruma.
In Oniguruma, \xHH matches an "encoded byte value", not a code point value like \x{...} does. That means for values from 0 to 7F, \xHH and \x{HH} work the same, but they diverge for hex values 80 to FF. With \xHH above 7F, the token must be part of a valid encoded byte sequence. So e.g. the three-byte sequence \xEF\xBB\xBF in Oniguruma is equivalent to the single code point \uFEFF in JavaScript (NOT the same as the three code points \xEF\xBB\xBF in JavaScript) and the same as \x{FEFF} in Oniguruma. \xFF, on it's own, is not a valid encoded byte sequence, so it is an error in Oniguruma.
To fix this, the \\xff should be replaced with \\x{ff}. It will then run in Oniguruma.

After testing this more in Oniguruma 6.9.8 via vscode-oniguruma 2.0.1, I'm closing this while I investigate further. There is most likely a bug on the line I highlighted, but it is not throwing as I described. I've confirmed that Oniguruma indeed does not match U+00FF using just \xFF, and e.g. [^\x7f-\xff] does not match U+0100, while [^\x7f-\x{ff}] does. However, I want to be more confident about exactly what Oniguruma is doing in this case before re-opening.

Re-opening after additional research and editing my comment to add more clarifying details.

In addition to causing edge case bugs, this issue is also preventing the Hack grammar from running in Shiki when using its JS engine (which transpiles Oniguruma regexes to JS using Oniguruma-To-ES). Oniguruma-To-ES intentionally doesn't reproduce Oniguruma's bugs related to handling of unenclosed \xF5 through \xFF, and instead throws for them (as Oniguruma does for \x80 through \xF4).


New rounded-square icon in macOS 11+ style for macOS build

After macOS 11 Big Sur Apple redesigned the icons in the operating system, they all became more like squares with rounded corners (I'm not a graphical designer, so I might be wrong in terminology).
I think that it would be nice if macOS version of Elephicon would be with more square-like icon to match the general style of new macOS releases.

@whitebear60
Thank you for the suggestion.
If you have a good alternative, could you send it to me as a PR?

@whitebear60
Please vote.
https://github.com/sprout2000/elephicon/discussions/222


bugfix

If anyone got error undefined is not an object (evaluating 'this.props.data[this.props.sections[index]].length') error, this PR will fix it. Or you can manually update  detectAndScrollToSection by adding  || index < 0 to the if statement below:
if (index >= this.props.sections.length) {
  return;
}

So, the final result is:
if (index >= this.props.sections.length || index < 0) { //  only added ` || index < 0`
  return;
}

I've console.loged the index value, and it goes below 0, so this addition to the if statement clearly fixes the problem.
Here is the full stack trace of the SectionList undefined is not an object error:
undefined is not an object (evaluating 'this.props.data[this.props.sections[index]].length')

detectAndScrollToSection
    SectionList.js:58:88
invokeGuardedCallback
    ReactNativeRenderer-dev.js:39:15
invokeGuardedCallback
    ReactNativeRenderer-dev.js:221:34
invokeGuardedCallbackAndCatchFirstError
    ReactNativeRenderer-dev.js:245:48
executeDispatch
    ReactNativeRenderer-dev.js:572:4
executeDispatchesInOrder
    ReactNativeRenderer-dev.js:603:20
executeDispatchesAndRelease
    ReactNativeRenderer-dev.js:761:29
forEachAccumulated
    ReactNativeRenderer-dev.js:740:16
runEventsInBatch
    ReactNativeRenderer-dev.js:927:6
runExtractedEventsInBatch
    ReactNativeRenderer-dev.js:952:19
<unknown>
    ReactNativeRenderer-dev.js:2703:6
batchedUpdates
    ReactNativeRenderer-dev.js:13724:16
batchedUpdates
    ReactNativeRenderer-dev.js:2565:27
_receiveRootNodeIDEvent
    ReactNativeRenderer-dev.js:2701:17
receiveTouches
    ReactNativeRenderer-dev.js:2777:28
__callFunction
    MessageQueue.js:351:47
<unknown>
    MessageQueue.js:116:26
__guardSafe
    MessageQueue.js:314:6
callFunctionReturnFlushedQueue
    MessageQueue.js:115:17

@AleksandarSavic95 Thanks for your contribution!


FR: rename managed_vms directory to flexible

Must coordinate w/ internal docs.  IT WILL HAPPEN THIS WEEK - THIS IS A WARNING!

Done a long time ago.


Two Card Components

Im Currently using MDL v1.3 and I'm experiencing a small problem.
The problem has to do with the Card components. I'm trying to place more than one Card component on my html page but the background photo is the same for all Cards?
I cant seem to figure out how to distinguish the styles so that each card can have a different photo as the background? Please see code below:
www.rajko.com.au/code.html

I can't see any cards on your page.
But i guess: set individual class to each card and modify your css.


Add tar and gzip to the image.

What this PR does / why we need it:
This PR adds the tar and gzip utilities to the kuttl image, so users could run installation scripts for other tools (e.g., https://helm.sh/docs/intro/install/#from-script) needed in their tests.
Follow-up question: is it necessary to have vim in the image?

vim should be everywhere :).   good question!    thanks for the PR and raising the questions.   I will follow up on this shortly.


Better generic utils

This PR improves the way of obtaining values of generic type arguments. Before this PR we relied on a fact that immediate ancestor of the passed class has generic parameters. This did not allow for building type hierarchies neither for entities nor for repositories.
Now to obtain a type argument value for a class it is needed to pass the class and its ancestor which has a generic parameter of the interest.

@armiol, PTAL.


Couple of questions regarding Custom Goals

Hello,
My first question is - what is the variable for innate/passive physical draw?  I vaguely recall finding one somewhere on the FFBraveExvius subreddit at some point, but I can't recall it and it's not in the list of variables on the Custom Goal page of the Builder.  Additionally, could you please add this to that page?
For my second question - is there a variable for chance to not be targeted?  If so, could it also be added to the Custom Goal page?
Thank you very much, and I really appreciate the effort put into this project.  It's hugely helpful, especially when you have your units & inventory recorded.

Hello,
There is no custom goal for passive draw attack yet, simply because there are not enough source of Draw attack make it needed, I think. All the sources can be found here : https://ffbeequip.com/index.html#eyJzZWFyY2giOiJJbmNyZWFzZSBjaGFuY2Ugb2YgYmVpbmcgdGFyZ2V0ZWQifQ==
I intends to add that as a search criteria for the unit search page.
The same answer is also valid for camouflage. The list of items that produce that effect : https://ffbeequip.com/index.html#eyJzZWFyY2giOiJSZWR1Y2UgY2hhbmNlIG9mIGJlaW5nIHRhcmdldGVkIn0=


feat: add type stubs for the example package

Closes #54 and adds PEP 561 compatible type stubs so that mypy is able to check code which imports this package correctly.
I’ve tested this by creating an external test venv and pip installed this cookiecutter template package. Without the changes of this PR I get
(TEST) savage@pooh ~/opt/dev/TEST > mypy test.py
test.py:1: error: Skipping analyzing "package.something": found module but no type hints or library stubs
test.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
test.py:1: error: Skipping analyzing "package": found module but no type hints or library stubs
Found 2 errors in 1 file (checked 1 source file)

whereas with this change
(TEST) savage@pooh ~/opt/dev/TEST > mypy test.py
Success: no issues found in 1 source file

Note: black picked up the *.pyi files, but I am not sure whether pylint did (see issues https://github.com/PyCQA/pylint/issues/2873), and it looks like flake8 did not (see flake8-pyi plugin).

@behnazh, I agree. Also, I just opened this question https://github.com/pre-commit/pre-commit/issues/2147

OK, so looks like the type stubs in this case are redundant.

Thanks @asottile for your comment, I’ve updated this PR accordingly.


IterativeRefinement to improve EqualityConstrainedQP speed

What is new ?
The class IterativeRefinement is a wrapper to increases the precision of linear system solvers: by minimizing the residuals iteratively a high accuracy solution can be obtained from a low accuracy solver, which is useful in float32 for ill-posed problems.
This functionnality is also available through a function in linear_solve, that mimic the interface of solve_gmres,solve_bicgstab etc...
Iterative Refinement solves Ax=b with the following recursion:

Where x_0=0 and r_0=b. The matrix A_bar can be any (regularized) approximation of A. The linear solver on the first step can be inaccurate, as long as computing the residuals b-Ax is accurate.
The user can specify its own A_bar; otherwise we take A_bar=A.
Link with EqualityConstrainedQP
This allows EqualityConstrainedQP to solve badly scaled problems (see new test).
The following attributes have been added to EqualityConstrainedQP:

refine_regularization: (optional) a positive float specifying the strength of regularization.
refine_maxiter: maximum number of refinement steps when refine_regularization is not None.

Question
Under which section should we document the class IterativeRefinement ? Do we need a Linear Solvers section ? Or under constrained optimization ? Finding a feasible point (constrained problem, without objective) can be turned into an optimization problem (unconstrained minimization of residuals).

Fixup commit; ready for merge after final review.

Commits squashed + modifications made as suggested.


EO-Hamcrest version up to 0.2.12

Added several changes and removed todo

@yegor256 please, have a look

@Graur thanks!


Reduce URI parsing

Resolves https://github.com/CesiumGS/cesium/issues/11197.
I put console.count calls inside URI.parse, and tested loading a detailed photogrammetry tileset. The number of calls to URI.parse in main was 1,134,036. With this PR, that number drops to 310,761.
There were several places where URIs were being parsed unnecessarily:

The Request constructor was not reading options.serverKey (even though Cesium3DTile.prototype.requestContent was sending a key with every request). This meant that the serverKey had to be re-generated in RequestScheduler every time, even for re-tries of a previous request for the same tile.
RequestScheduler.getServerKey re-constructed the URI if the supplied URL was relative (instead of re-using the existing URI object)
Resource.prototype.clone re-parsed the URL for query parameters. However, the URL stored in a Resource already has the query parameters stripped off and stored in an object
Resource.prototype.getUrlComponent re-parsed the URL to add the query string back, rather than adding it via a simple template literal

This PR includes 2 public API changes:

Added a parseUrl flag to the Resource constructor options object. This can be set to false if the supplied URL already has the query string and fragment removed (as when cloning an existing Resource).
Added a a serverKey property to the Request constructor options object

Thanks for the pull request @jjhembd!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Thanks @jjhembd! I ran some tests on imagery and terrain, and found very little variance between this branch and main– Both with cache enabled and cache disabled. While the benefits here are generally isolated to 3D Tiles, it's still good to know it didn't negatively affect performance in other areas of the code.

Thanks again @ggetz! I cleaned up one of those helper functions you flagged. Sorry for the confusing diff: these were old functions, just rearranged in https://github.com/CesiumGS/cesium/pull/11202/commits/37ca5ea44882206ace971b9b916e81eeafffa0f0 so I could put the constructor at the top of the file.
I think the other helper could be cleaned up later when we resolve https://github.com/CesiumGS/cesium/issues/11168.


Error: can't resolve L0 - go1

Hi!
I try to use it on Ubuntu 22.04 and I have an errors.
First I installed golang-go, gccgo-go and gcc-multilib for working with Golang :
sudo apt install golang-go
sudo apt install gccgo-go
sudo apt-get install -y gcc-multilib

Then I cloned quic-go:
git clone https://github.com/lucas-clemente/quic-go.git
cd quic-go

When I try to tests this by go test ./... I got :
# github.com/lucas-clemente/quic-go/internal/qtls
/tmp/ccmMiGeB.s: Assembler messages:
/tmp/ccmMiGeB.s:5529: Error: junk `.cipherSuiteTLS13ByID ' after expression
/tmp/ccmMiGeB.s:5529: Error: invalid operands (*UND* and *UND* sections) for `/'
/tmp/ccmMiGeB.s:5529: Error: invalid operands (*UND* and *UND* sections) for `/'
/tmp/ccmMiGeB.s:5529: Error: can't resolve L0 - go1
FAIL	github.com/lucas-clemente/quic-go [build failed]
FAIL	github.com/lucas-clemente/quic-go/benchmark [build failed]
ok  	github.com/lucas-clemente/quic-go/fuzzing/internal/helper	(cached)
FAIL	github.com/lucas-clemente/quic-go/http3 [build failed]
FAIL	github.com/lucas-clemente/quic-go/integrationtests/self [build failed]
FAIL	github.com/lucas-clemente/quic-go/integrationtests/tools/proxy [build failed]
FAIL	github.com/lucas-clemente/quic-go/internal/ackhandler [build failed]
FAIL	github.com/lucas-clemente/quic-go/internal/congestion [build failed]
FAIL	github.com/lucas-clemente/quic-go/internal/flowcontrol [build failed]
FAIL	github.com/lucas-clemente/quic-go/internal/handshake [build failed]
FAIL	github.com/lucas-clemente/quic-go/internal/logutils [build failed]
ok  	github.com/lucas-clemente/quic-go/internal/protocol	(cached)
FAIL	github.com/lucas-clemente/quic-go/internal/qerr [build failed]
# github.com/lucas-clemente/quic-go/internal/qtls [github.com/lucas-clemente/quic-go/internal/qtls.test]
/tmp/cce9EfyB.s: Assembler messages:
/tmp/cce9EfyB.s:13309: Error: junk `.cipherSuiteTLS13ByID ' after expression
/tmp/cce9EfyB.s:13309: Error: invalid operands (*UND* and *UND* sections) for `/'
/tmp/cce9EfyB.s:13309: Error: invalid operands (*UND* and *UND* sections) for `/'
/tmp/cce9EfyB.s:13309: Error: can't resolve L0 - go1
FAIL	github.com/lucas-clemente/quic-go/internal/qtls [build failed]
ok  	github.com/lucas-clemente/quic-go/internal/utils	(cached)
FAIL	github.com/lucas-clemente/quic-go/internal/wire [build failed]
FAIL	github.com/lucas-clemente/quic-go/interop/http09 [build failed]
FAIL	github.com/lucas-clemente/quic-go/logging [build failed]
FAIL	github.com/lucas-clemente/quic-go/qlog [build failed]
ok  	github.com/lucas-clemente/quic-go/quicvarint	(cached)

When I try to run example/main.go:
cd example
go run main.go

I got :
# github.com/lucas-clemente/quic-go/internal/qtls
/tmp/ccnS0Q07.s: Assembler messages:
/tmp/ccnS0Q07.s:5529: Error: junk `.cipherSuiteTLS13ByID ' after expression
/tmp/ccnS0Q07.s:5529: Error: invalid operands (*UND* and *UND* sections) for `/'
/tmp/ccnS0Q07.s:5529: Error: invalid operands (*UND* and *UND* sections) for `/'
/tmp/ccnS0Q07.s:5529: Error: can't resolve L0 - go1

What I doing wrong and what I need to do for working with quic-go? Where I can read documentation about this?
Thanks!

We currently support Go from version 1.16.


``category:Ideas @3022819432= [category:Ideas @3022819432= ](category:Ideas @3022819432= )

          ``category:Ideas @3022819432= [category:Ideas @3022819432= ](category:Ideas @3022819432= )

Originally posted by @Montyc666 in https://github.com/software-mansion/react-native-reanimated/issues/4177#issuecomment-1457740545

This seems unrelated to this project. Please post in https://github.com/software-mansion/react-native-reanimated


Support for .phpbrewrc

This is a proof-of-concept which works with Bash on Ubuntu 14.10 x64. I didn't test any other configurations.
The echo statements may be useful for testing, but I believe they are worth removing after the implementation is approved.
The original idea was borrowed from https://github.com/phpbrew/phpbrew/pull/233.

Thanks a lot @morozov :+1:


Edge AI Benchmark: add “leaderboard/forum”

In a future version, I suggest to add “leaderboard/forum” for academic and industrial users to publish their latest progresses and discuss feedbacks/questions/concerns about data, metrics, benchmarks, and algorithms, etc. This may attract more interests about Cloud-Edge AI, Sedna , related learning schemas and scenarios.

Good point. Will have this issue considered in coming versions.


add index support

PR-Codex overview
This PR focuses on adding the ability to add indexes to collections in the document database.
Detailed summary

Added AddIndexMutation message in the db3_mutation_v2.proto file
Implemented addIndex function in database_v2.ts to add indexes to collections
Updated createCollection function in doc_store.rs to use add_index instead of create_collection
Added tests for the addIndex function in client_v2.test.ts

The following files were skipped due to too many changes: src/storage/src/db_store_v2.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report

Merging #573 (91e980a) into main (8c41779) will increase coverage by 0.60%.
The diff coverage is 84.61%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   63.97%   64.57%   +0.60%
==========================================
  Files           9        9
  Lines         433      446      +13
  Branches       64       66       +2
==========================================
+ Hits          277      288      +11
- Misses        156      158       +2

Flag
Coverage Δ

rust
64.57% <84.61%> (+0.60%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

sdk/src/account/db3_account.ts
62.50% <ø> (ø)

sdk/src/provider/storage_provider_v2.ts
76.92% <ø> (ø)

sdk/src/store/document_v2.ts
86.95% <ø> (ø)

sdk/src/store/database_v2.ts
81.92% <84.61%> (+0.49%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix: flaky test fix 2

Description

Fixed below flaky tests
Templates/Fork_Template_To_App_spec.js
Templates/ForkTemplateToGitConnectedApp.js
Templates/Fork_Template_Existing_app_spec.js
Templates/Fork_Template_spec.js
Onboarding/CreateNewApp_spec.js
IDE/MaintainContext&Focus_spec.js
Onboarding/GuidedTour_spec.js
ThemingTests/Theme_MultiSelectWidget_spec.js
Widgets/Tab/Tab_spec.js
BugTests/Autocomplete_JS_spec.ts

Type of change

Flaky test fix

How Has This Been Tested?

Cypress test runs

Checklist:
QA activity:

[x] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=3aa7571

/ok-to-test sha=dcb9e75

/ok-to-test sha=b23ccbb

/ok-to-test sha=787a151


bugfix: removing unexpected parameter from generateCfiFromDomRange call

In generateCfiFromDomRange() function value range.commonAncestorContainer is passed as 5th parameter to EPUBcfi.generateRangeComponent, but in https://github.com/readium/readium-cfi-js/blob/develop/js/cfi_API.js generateRangeComponent 5th parameter is expected to be classBlacklist.
Non-obvious thing is that it leads to false positives inside cfiInstructions.applyBlacklist and invalid cfi calculation for some trivial htmls.

Well spotted!
For reference:
https://github.com/readium/readium-cfi-js/blob/develop/js/cfi_API.js#L85
        generateRangeComponent : function (rangeStartElement, startOffset, rangeEndElement, endOffset, classBlacklist, elementBlacklist, idBlacklist) {
            return cfiGenerator.generateRangeComponent(rangeStartElement, startOffset, rangeEndElement, endOffset, classBlacklist, elementBlacklist, idBlacklist);
        },

@JCCR is that because of a fix / improvement in readium-cfi-js that is specific to your local copy, or just a typo?

The generateRangeComponent implementation in a private fork of the epub cfi lib took the commonAncestor as an optional parameter if it was known and if it wasn't or not passed in then it would create a range from the info provided so the commonAncestor could be inferred. The open source implementation of the CFI library doesn't require the commonAncestor and uses a range to figure it out. There's no particular reason as to why it wasn't allowed to be passed in. It is more efficient if we pass it around if it's already known (it is so in this case), but it's a minor optimization.

@pmstss
Sorry I missed this PR (I blame the winter holiday time). It could have helped prevent this bug from being filed for the viewer: https://github.com/readium/readium-js-viewer/issues/460
Without knowing about this PR, I traced down the bug to this and committed it here on a different branch:
https://github.com/readium/readium-shared-js/commit/c94516915ea9033ccb87f5e2c7b47708fa3cbf70

@pmstss
Thanks by the way.
I'll merge this in and cherry pick it to develop because the intel-cfi-improvements branch was merged in now. Please work against develop as we are deleting the intel-cfi-improvements branch like it should have been when it was merged in.

Not sure how c945169 ended up on develop already. I committed it to feature/intel-cfi-improvements-vwm-fix only...


simplejson

having issues with king-phisher...upgraded kali got this issue...
Traceback (most recent call last):
File "./KingPhisher", line 49, in
from king_phisher.client import application
File "/usr/share/king-phisher/king_phisher/client/application.py", line 61, in
from king_phisher.client.windows import main
File "/usr/lib/python3/dist-packages/pluginbase.py", line 439, in plugin_import
fromlist, level)
File "/usr/share/king-phisher/king_phisher/client/windows/init.py", line 33, in
from .main import *
File "/usr/lib/python3/dist-packages/pluginbase.py", line 439, in plugin_import
fromlist, level)
File "/usr/share/king-phisher/king_phisher/client/windows/main.py", line 40, in
from king_phisher.client import export
File "/usr/lib/python3/dist-packages/pluginbase.py", line 439, in plugin_import
fromlist, level)
File "/usr/share/king-phisher/king_phisher/client/export.py", line 54, in
import geojson
File "/usr/lib/python3/dist-packages/pluginbase.py", line 439, in plugin_import
fromlist, level)
File "/usr/lib/python3/dist-packages/geojson/init.py", line 1, in
from geojson.codec import dump, dumps, load, loads, GeoJSONEncoder
File "/usr/lib/python3/dist-packages/pluginbase.py", line 439, in plugin_import
fromlist, level)
File "/usr/lib/python3/dist-packages/geojson/codec.py", line 11, in
class GeoJSONEncoder(json.JSONEncoder):
AttributeError: module 'simplejson' has no attribute 'JSONEncoder'

What version of simplejson are you using? Check with python3 -m pip freeze | grep -i simplejson. Looks like another upstream compatibility error.

Can you please check geojson too?

simplejson==3.15.0
geojson==2.4.1
those are the versions and thank you for helping

Well I'm confused because I installed both of those versions and can not reproduce this. The error seems to be complaining that simplejson does not have simplejson.JSONEncoder which from what I can tell it does:
Python 3.6.6 (default, Jul 19 2018, 14:25:17)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import simplejson

In [2]: simplejson.__version__
Out[2]: '3.15.0'

In [3]: simplejson.JSONEncoder
Out[3]: simplejson.encoder.JSONEncoder

From what I can tell from glancing through geojson the simplejson module isn't necessary. We don't even require it in King Phisher. I'd propose you take one of two solutions to fix this:

You could just uninstall it with python3 -m pip uninstall simplejson and that should fix your King Phisher issue, but that package won't be available for whatever else you might need.
We've actually taken steps to address these kinds of dependency problems and they're live in the dev branch. We're a couple of weeks from merging them into master, but if you don't want to uninstall simplejson system-wide, you could opt into Beta Testing.

is it possible to send to me to direct download of the beta since git fetch is being a pain to me

@TheUnable  How is it being a pain? Can you provide an output of you trying to switch to the dev branch?

here you go my friend
fatal: not a git repository (or any of the parent directories): .git

ok that means either you installed via apt on kali or you download a compressed release.
I would recommend backing up your server configuration file ( server_config.yml ) to another location.
Then clone down the King Phisher project then switch over to dev.
cd #to directory of choice normally /opt/
git clone https://github.com/securestate/king-phisher.git

follow the wiki to changing to the dev branch
Copy your server_config.yml backup into the king-phisher directory.
run the tools\install.sh

@wolfthefallen is right. Once you're done though you should be able to verify you're on the right version by running ./KingPhisher --version and you should see ... Version: 1.12.0-beta2... in the output.

So that should be fixed when your run sudo tools/install.sh --update from the beta-testing branch (version "1.12.0-beta2"). Is there a chance you forgot that step? That should have installed that missing package. I don't think Parrot OS was one we tested (@wolfthefallen can you chime in here) but it should be fine since it uses the same packages as Ubuntu or Kali or whatever which we do test.

We do not support Parrort OS..
please provide the output of
apt search gir1.2-webkit

serious thank you guys for your time and help..
here is the output
gir1.2-webkit2-4.0/kali-rolling,stable,now 2.22.2-1 amd64 [installed,automatic]
Web content engine library for GTK+ - GObject introspection data

thank you, give me a few minutes and i'll update the dev branch with a fix

ok the fix has been added in commit f486c26352b06648cbee6e2c20c1f191397b1245 into the dev branch.
Do a git fetch and git pull to update your King Phisher, then do a git log and the top entry should be
commit f486c26352b06648cbee6e2c20c1f191397b1245 (HEAD -> dev, upstream/dev, origin/dev)
Author: Erik Daguerre<EMAIL_ADDRESS>Date:   Thu Oct 25 11:50:05 2018 -0400

    Added gir1.2-webkit-4.0 to install.sh

Once you have that confirmed, run tools/install.sh and you should be good to go.

says no module named gi but i have pygobject installed

It would be cool if u guys did remote fixes like being allowed to enter someones computer and seeing the issue itself...
ok im going to try this again step by step :) give me a sec

after typing
sudo tools/install.sh --update
then choosing
kali
i get this error again my friends
E: Unable to locate package gir1.2-webkit-3.0
E: Couldn't find any package by glob 'gir1.2-webkit-3.0'
E: Couldn't find any package by regex 'gir1.2-webkit-3.0'
ERROR: Failed to install dependencies with apt-get

please provide me the output of cat /etc/debian_version

says stable

please provide the whole out put of both files

what do u mean? :(

oh crap since my brother upgraded using parrot repos it went from kali to this now..
stable
Parrot 4.3 \n \l

Should we close this issue if the resolution is to use a version of King Phisher that's supported?

yes sir


Synapse new release Jun 2024

update changelog
Packages impacted by this PR
synapse-artifacts
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/synapse-artifacts


Word wrap long menu names

Yikes, how about a variable sized menu instead?

Can we insert a zero-width space after each . so it doesn't break in the middle of each word?

Can we insert a zero-width space after each . so it doesn't break in the middle of each word?

That's a good idea.  Please give me 24 hours to modify.

Can we insert a zero-width space after each . so it doesn't break in the middle of each word?

How about omitting the std prefix?
Also std.container should be another submenu IMO, but that's a bit more work.

Also std.container should be another submenu IMO, but that's a bit more work.

We should avoid nesting things too deeply, as that's more clicks and complexity.

Added zerowidth breaking space.

I will submit another pull request to experiment with some of @MartinNowak 's ideas.

How about omitting the std prefix?

Sorry @MartinNowak, I tried to do that, but it turned out to be a little more difficult than I anticipated due to the way the DDoc macros were written... and I'm not that invested.

I'll pull this because it's useful regardless of later improvements.


Feat:adding a new page to display all contributors✨

Describe the feature
I want to add a page to showcase all the contributors of this website
Add ScreenShots
@RamakrushnaBiswal can you assign me this issue,
Record

[X] I agree to follow this project's Code of Conduct
[X] I have starred the repository
[X] I'm a gssoc-24-extd contributor
[X] I want to work on this issue

Ok go for it @T-Rahul-prabhu-38
In footer create a link name - our contributors then redirect to that page

Hey @RamakrushnaBiswal can i work on this task, as it is already been a week, i can raise PR by today, infact within in 1hr of assignment, actually my PR is ready

@shubhagarwal1 go for it rise a PR asap


Do not wrap PersistentThrowable types as it alters the serialized data upon reserialization

Fixes https://github.com/vigoo/desert/issues/325

Codecov Report
Base: 56.85% // Head: 56.88% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (f064b46) compared to base (4f21125).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   56.85%   56.88%   +0.02%
==========================================
  Files          35       35
  Lines        1750     1751       +1
  Branches      221      221
==========================================
+ Hits          995      996       +1
  Misses        755      755

Impacted Files
Coverage Δ

...src/main/scala/io/github/vigoo/desert/Codecs.scala
97.04% <100.00%> (+0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Getting error TS2339: Property does not exist on type for a valid ES6 class

I have the following ES6 class
class MyClass {
    constructor(){
        this.myclassvar = 'abc';
    }
}

When compiled/transpiled through TypeScript it generates error TS2339: Property 'myclassvar' does not exist on type 'MyClass'.
If the above code snippet is valid ES6 then TypeScript should not generate the error. The generated javascript it valid. It's just that the error scares the developers trying to use ES6 without typings.
The same ES6 class transpiles properly in BabelJS.
I know I can fix the error by declaring the variable.
class MyClass {
    myclassvar;
    constructor(){
        this.myclassvar = 'abc';
    }
}

Since TypeScript is a superset of Javascript, it should be able to handle valid ES6 without errors.
My compiler settings are
"compilerOptions": {
        "target": "es5",
        "module": "amd",
        "declaration": true,
        "noImplicitAny": false,
        "noResolve": true,
        "removeComments": true,
        "noLib": false,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true
    }

tsc should still compile this, so it can technically handle the ES6. Errors in typescript do not actually stop code being transformed and emitted.

Yes. As I mentioned the generated JS is a valid JS file. The issue here is developer experience. The error shows up in IDEs and also in the build output through GruntJS/GulpJS.
This error breaks the notion of TypeScript being a superset of Javascript and any valid JS is a valid TS.

Duplicate #766

Can it surely be a duplicate of the ticket called "Allow declaring class members within a constructor"?
It is my understanding that in ES6, we do not declare data properties of classes. The problem introduced here (and causing troubles as early as step 2 in angular2 tutorial) is that for some reason TS requires data property declaration meanwhile stating it is a superset of ES6.

@RyanCavanaugh any chance of reopening this issue?
I agree with @mrnagydavid that this issue is not the same as #766 which proposes different methods for declaring class members within a constructor while the current one is about making a valid JavaScript code to work in a TypeScript project without generating any errors.
The idea is to solve the problem of 'my ES6 code is an error in TypeScript' mentioned by @danquirk here: https://github.com/Microsoft/TypeScript/issues/766#issuecomment-90204645 without introducing new syntax but instead:

inferring from this.foo assignments in the constructor to implicitly infer the shape of your type

The Typescript Specification describes Typescript as superset of ECMAScript 2015 (ES2015) which supports all ES2015 features.
So it should definitely not error on valid JS-Code.

Quote: "Every JavaScript program is also a TypeScript program."

This is true of syntax and runtime semantics, but it is obviously not that TypeScript cannot add semantic errors. By your argument, we could not issue an error on things like [] * 42.

I believe that this at least need be clarified in spec. When one reads "Every JavaScript program is also a TypeScript program" he/she can erroneously conclude that every program will run without any noticable additional effort which is not always the case.

I am currently converting an ES6 project to typescript and in ES6 we can easily write this.name = 'xyz' but in the typescript this will throw error. How can we fix this error I have such errors a lot so cannot manually declare the variable everywhere.

hi gents.
I was just passing by in a search for different TS problem but I made you a small sample what should work for you.
basically TS will generate you the same code that you did (is using the same JS pattern so object will have prob and behaves like class) :
http://www.typescriptlang.org/play/index.html#src=class MyClass {
	myclassvar%3A string %3D "abcd"%3B
}

var a %3D new MyClass()%3B
alert(a.myclassvar)%3B

or a bit different version here :
https://jsfiddle.net/amgLbk6s/

Anyone managed to get Array.from to work?
http://stackoverflow.com/a/36719911/1339087
I'm still getting:

use --lib es6 or --lib es6,dom

Thanks, I won't bother with that interface now thx

This one is really annoying. Sometimes I want to have a class without cluttering it with type information.
Maybe adding something like "noImplicitAnyForClassMembers": false in tsconfig?


Transactions: Helper method to check tx status

It is very likely that every developer broadcasting txs will also check the status of a transaction. We should provide helper methods to do so (either API calls or WebSockets)

There is not endpoint on the stacks node for the tx status. It is only available through stacks-node-api. There we have a subscribe for tx as well a get tx by id.
I'd say: "won't fix"


new(chisel): Allow chisels to be loaded from memory

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:
These changes allow for simple chisels to be loaded directly from a string stored in memory. For complicated use cases, this might make much sense, but imaging your chisel looks as follows:
args = {}
function on_event()
    return true
end
function on_init()
    filter = "not container.id = 'host'\n"
    chisel.set_filter(filter)
    return true
end

You could create a file, store the script, then distribute the file along your application for it to be loaded at runtime, or you could define a string and pass it directly:
static constexpr char chisel[] = R"(
args = {}
function on_event()
    return true
end
function on_init()
    filter = "not container.id = 'host'\n"
    chisel.set_filter(filter)
    return true
end
)";

sinsp_chisel(inspector, chisel, true);

As is, the change should not introduce any changes in behavior to existing code, but would allow adopters to use this functionality if needed.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Molter73
To complete the pull request process, please assign fededp after the PR has been reviewed.
You can assign the PR to them by writing /assign @fededp in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @Molter73. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Molter73
To complete the pull request process, please ask for approval from fededp after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f9ff8b1d2d47eba1beed3f404f96cc402eff797d

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test

/test build-libs-with-chisels

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, leogr, Molter73
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Testapp Dockerfile not working

When trying to run this in my wundergraph app, I get this error:
 => ERROR [build 6/6] RUN npm exec wunderctl generate                                                                                0.7s
------
 > [build 6/6] RUN npm exec wunderctl generate:
0.588 /usr/src/app/node_modules/@wundergraph/wunderctl/download/wunderctl: 1: Syntax error: "(" unexpected
------
Dockerfile.wundergraph:101
--------------------
  99 |
 100 |     # generate your wundergraph application
 101 | >>> RUN npm exec wunderctl generate
 102 |
 103 |     # Image layer for production
--------------------
ERROR: failed to solve: process "/bin/sh -c npm exec wunderctl generate" did not complete successfully: exit code: 1

Here might be a pointer into the right direction: https://stackoverflow.com/a/55418120/18188271

Nervermind, forgot the .dockerignore


Column attrs does not work with ajax

I'm trying to use attrs like this:
class MyTable(Table):
    field1 = Column(field='field1', header='field 1', attrs={'class': 'danger'})

    class Meta:
        model = MyModel
        ajax = True

and the attrs field is not added, but if I comment ajax = True in class Meta, it works.

I can confirm this issue.


Argument validation errors (custom validators) do not show the correct error message

Change #1037 broke the logic to show error message if a validator fails.
Incorrect/incomplete error message:
$> az vm show
(--name --resource-group | --ids) are required
The problem is that CliError exceptions simply bypass the call to parser/error when validation is run in application.py.
@tjprescott, what was the reason for this change?

The reason is that not every error that originates in a validator is a validation error (since validator itself is a misnomer) and thus printing the usage string is either completely inappropriate or misleading (when the usage string doesn't actually convey the usage). In the case of change #1307 this was the first case, where the error was such that printing a usage string made no sense.
If you want the usage string printed, you can raise a ValueError instead of a CLIError.


fusermount: entry for /run/user/1000/keybase/kbfs not found in /etc/mtab

I've installed the keybase-gui package for Arch.  Everything in the GUI works just find (logging in, adding computer, browsing files, chatting, etc.).  However, the file system integration is broken.  It complains about a missing /etc/mtab entry.  My understanding is that this file should not be edited manually.  Please advise.

That fusermount command shouldn't be fatal, it's just trying to unmount an existing mount if there is one, before it tries to mount the new one.  The error code should be ignored (it's prefixed with a - in the service definition).
If the FS really isn't working, there's probably something else going on later in the logs.  You can try keybase log send and we can see if it's obvious from there.

I just sent my logs: 8006b217a7e06d16c361701c.

The error is:
stat /run/user/1000/keybase/kbfs: no such file or directory

Looks like you might have the environment variable $XDG_RUNTIME_DIR set to /run/user/1000, but the OS didn't actually create that directory for you.  Perhaps you are using su or sudo in an unusual way, and don't have a proper login session.
You can always change the mount directory with something like:
keybase config set mountdir /home/you/keybase

/run/user/1000/keybase/kbfs is the location I've come to expect.  The /run/user/1000/keybase folder got created just fine.

Is setting the keybase mountdir to /home/me/keybase the recommended approach?  Before switching from keybase-bin to keybase-gui, the "official" package was still using /run/user/1000/keybase.

@miztroh2 did you start it with run_keybase?  Or were you trying to start it purely via the service stuff?  For now, run_keybase is required.

run_keybase doesn't seem to be included with the keybase-gui package (or its dependencies keybase and kbfs).
https://www.archlinux.org/packages/community/x86_64/keybase-gui/

I'm not familiar with that package.  @eli-schwartz ?

#1669

That's obviously not done yet.  I thought the package included run_keybase.  Did you take it out?

The run_keybase script is not very useful considering that it hardcodes the binary to start in /opt, whereas I package it in /usr/share and start it via /usr/bin/electron. And it also tries to run a redirector which I don't install, which runs as setuid root.
I'd need to reimplement the script, which I have not done since the only thing it currently does not do (to my knowledge) is mkdir -p "$(keybase config get -d -b mountdir)" -- hence my issue #1655 and corresponding PR.
If you create the directory by hand this works fine though.

I stopped keybase.gui, keybase, and kbfs user services.  I then manually created the kbfs folder inside of /run/user/1000/keybase and restarted said services.  Everything checked out and I could access the kbfs mount through GNOME Files.  However, once I restarted my computer, the kbfs directory was gone.  Not sure what would cause that.  Any ideas?

/run is a tmpfs and will be recreated from scratch at boot.
BTW my mountpoint is still set to ~/.local/share/keybase/fs (you can use keybase config set mountdir /path/to/custom/mountdir to relocate it)

OK, I've updated my mountdir to the one you specified and that seems to work, even after reboot.  Thanks!


Forced online license activation

As a long-term user and customer of Poedit, I'm very critical of the fact that Poedit now requires online activation. This is hostile DRM that should be encouraged or supported. I urge you to reconsider @vslavik

This is not an appropriate place — please use<EMAIL_ADDRESS>for Pro-related stuff. First, this is the bug tracker for the Open Source version of Poedit, second, it is for tracking bugs, not exaggerated ideological arguments.
You will note that v1 did not use activation (because of, yes, the same ideological reasons). Unless you think I'm an irrational moron (thanks for that), you should suspect, if not be reasonably certain, that there might be some reasons for the change. And oh boy, indeed there are.
In theory, I agree with you — again, see v1 (or my track record in OSS).  Hence activation, which I'm sure you're well aware is a common practice nowadays.
Contrary to your mischaracterization of it as "hostile", Poedit's activation is minimally invasive, only requiring being online at the very moment you purchased a license online. And that's not to mention that major Pro functionality requires internet access anyway, so requiring it more frequently wouldn't be a big deal either — but I didn't do it that way, because I didn't want activation to be invasive. There are more aspects of it that I won't discuss here that were driven purely by the desire to be non-invasive and non-annoying (and not like e.g. the somewhat popular strict DevMate activation).
In short: I consider it necessary for the time being. I also consider it necessary to tweak it, and continue to tweak it, to ensure it won't be annoying in practice. But fix humanity to be 100% decent and I'll gladly roll it back.


Redoc - loading googefont from web instead from local path

Hello, maybe something is wrong in my env or this point is missing in staticfile with drf spec sidecar:
my system has no connection to the internet, thats why I deploying my project offline with sidecar.
swagger-ui is working fine, all of the required files a loaded from local (static) path, but redoc not does not for one specific file:
the /redoc loads very long, the browser debug console shows this file causes the timeout:
https://fonts.googleapis.com/css2?family=Montserrat:wght@300;400;700&family=Roboto:wght@300;400;700&display=swap
the html head is this for /redoc:
<head>
    <title>REST API</title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="preconnect" href="https://fonts.googleapis.com">
    <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin="">
    <link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Montserrat:wght@300;400;700&family=Roboto:wght@300;400;700&display=swap">
</head>

compared to /swagger-ui
<head>
    <title>REST API</title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <link rel="icon" href="/static/drf_spectacular_sidecar/swagger-ui-dist/favicon-32x32.png">
    <link rel="stylesheet" href="/static/drf_spectacular_sidecar/swagger-ui-dist/swagger-ui.css">
</head>

I have no idea where to fix it, because I have not found a options for this.

Hi, interesting point. Yes, we do not host the google font, so it makes sense. Not entirely sure if we should honestly.
You have 2 choices currently. Override the template via the default django template override mechanism: https://docs.djangoproject.com/en/4.2/howto/overriding-templates/ That should be pretty simple. Just make sure your app is above drf-spectacular.

Just copy the our template https://github.com/tfranzel/drf-spectacular/blob/master/drf_spectacular/templates/drf_spectacular/redoc.html and remove the googlefont parts
edit as above but replace googlefonts domain with your own hosting

hey thank you alot for the hint with template overrides, thats solves my issue with redoc.


feature: which-key keymaps configurable

Did you check the docs?

[X] I have read all the LazyVim docs

Is your feature request related to a problem? Please describe.
The keymaps are local to "which-key" config function, so overriding the settings is not possible.
Describe the solution you'd like
Would be nice to make the keymaps part of the option.
Describe alternatives you've considered
My alternative for removing/changing the keymaps is to copy the code from Lazyvim into my own config and edit them in place.
Additional context
No response

I just made some changes to make this configurable, but in the end it's not really worth the added complexity.
Overriding the config for which-key like you do now is the easier and better way I think.


Add AvgPool1D layer

Resolves #61. This PR adds support for AvgPool1D layer.

[x] Implement layer class
[x] Add unit tests for layer implementation
[x] Add support for importing models containing this layer from JSON config files
[x] Add support for exporting models containing this layer to JSON config files

@zaleslaw I just merged it with master branch and updated it with recent changes.

@zaleslaw I changed the strides type and default value per your request.