LogstashLogbackSink: Replace log.trace with call to HttpLogWriter.write()

Being able to provide a custom HttpLogWriter for the LogstashLogbackSink and calling the respective write methods instead of log.trace would increase the configurability.
Detailed Description
Replace log.trace in LogstashLogbackSink with calls to a provided HttpLogWriter or the default one
Context
This change enables logging of requests on other levels, such as DEBUG, INFO, etc.
Your Environment

Version used: 2.2.0

My knowledge of logstash-logback is pretty limited, tbh. I had the impression that it's pretty much bound to Logback, hence the direct dependency to a logger. Technically we can introduce a writer there, similar to the DefaultSink implementation.
@skjolber What's your take on this?

I guess he wants to control the log level - was not that possible before? I would prefer to do the same, so we can continue to use the same log level as in v1.
But passing in HttpLogWriter is probably not the best approach (?), as it supports just a single argumet, and we're adding two sibling fields to the log statement (the String message and the Marker http).

I guess he wants to control the log level - was not that possible before (at least some other place in the lib)?

Actually, I removed that ability and now it's always TRACE. One can control whether TRACE is enabled or not using their logging framework of choice, but it's always TRACE. (Unless some frameworks allow to rewrite levels using configurations, but I'm not aware of that.)

I do not understand why it should always be logged to trace? Doesn't it make sense to have it configurable?

Would you consider making it configurable again? If someone already is doing a lot of logging and want to add request-/response logging, they might want another level than trace (i.e. info is fair) so it fits in with their current global log level (which is usually debug or info).

If someone already is doing a lot of logging and want to add request-/response logging, they might want another level than trace (i.e. info is fair) so it fits in with their current global log level (which is usually debug or info).

One can configure different levels for different loggers. No need to change the level in the code or configure it there.
I removed it because it doesn't add any value over having the logging framework just enable/disable TRACE. The effect is the same.

I understand you viewpoint, both approaches will result in the statement being printed. But the perception of request-/response-logging might differ from the classic trace level, in some apps the right value might be info.
Image I've got an app with a lot of trace messages, most of which adds low informational value, and request-/response-logging. So I go to the log accumulation tool and it just lets me set a minimum level. So then it is not possible to get the request-/response statements without those other trace messages.

Exactly my point. I don't want it be logged as trace but info.

and it just lets me set a minimum level

Sounds like the problem to me 😜
Jokes aside, how do you deal with this issue with other libraries? I have not seen any library or framework out there that allows to configure the log level they are using to log messages.
We're just trying to reinvent what good logging frameworks should already give you anyway.
Side note: Request/response logging is all about tracing calls within your system, i.e. TRACE is by far the most logical level to use.

Side note: Request/response logging is all about tracing calls within your system, i.e. TRACE is by far the most logical level to use.
Sometimes you need information about which calls go into your system, but it doesn't have to be as detailed (e.g. body can be omitted, when running on info and added when running on trace).

A quick google and I found CXF logging at INFO, fegin logging at DEBUG. Some libraries seem to check which log level is enabled, and include more or less details based on that. I guess the issue here is that the correct log level for request-/response-logging is not universially agreed upon.

My argument was solely based on the implied semantics of the levels, given their name. Tracing traditionally refers to very detailed inspection of entry and exit points, e.g. functions or procedures.

A quick google and I found CXF logging at INFO, fegin logging at DEBUG. Some libraries seem to check which log level is enabled, and include more or less details based on that. I guess the issue here is that the correct log level for request-/response-logging is not universially agreed upon.

And nobody makes it configurable, or do they?

CXF and Fegin it seems not, but in addition to the other arguments, you could argue that all request-response-logging should be on the same level. And that level is not known in advance, aparently.
I see the lack of log-level customization elsewhere is more like a change for Logbook to shine, the use-case is fair.

But passing in HttpLogWriter is probably not the best approach (?), as it supports just a single argumet, and we're adding two sibling fields to the log statement (the String message and the Marker http).

Since this was the answer to the original issue, I'll close it now.
We can continue the log level discussion here or create a new issue to track it.


distinguish devices

[Enter feedback here]

We are not aware of an API where we can see the input and which device it came from.

LuaMacros is somehow able to do that. Its predecessor HidMacros, too, if I recall correctly.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b7635bf3-62fb-b9b7-7a2c-286dc108ab17
Version Independent ID: 890589e7-751b-9a0e-bda9-c7b1aa3f5102
Content: PowerToys Keyboard Manager utility for Windows
Content Source: hub/powertoys/keyboard-manager.md
Product: dev-environment
Technology: powertoys
GitHub Login: @mattwojo
Microsoft Alias: mattwoj

Ping @crutkas ?

Ping @crutkas ?

Close as not a doc issue

This feels not so much like feedback specifically about the documentation, but rather like a question, or feedback, about the PowerToys product. I don't have any additional content for your scenario, over and above what's in the documentation. So, it might be worth pursuing this as a question or feedback about the product. If you visit the PowerToys repository, then you'll be able to create an issue to leave product questions/feedback.

There is already a PowerToys issue https://github.com/microsoft/PowerToys/issues/1460 (which also mentions LuaMacros).
But IMHO this is still a documentation issue: "We are not aware of an API where we can see the input and which device it came from" (emphasis mine) may be right. But 1460 shows that PowerToys devs are aware of a way (maybe hack? I haven't read much of that PowerToys issue).
The average user probably doesn't know or care whether PowerToys achieves something via a proper API or otherwise. It would be more useful for the docs to reference and summarize the state of 1460.


add feature to cleanup docker registry storage:remove history images

add feature to cleanup docker registry storage:remove history images
The blow script work fine for me :)
#!/bin/bash
# script for delete history images
d="";
if [ -z "$1" ] ; then
 echo "please input your docker registry store location:";
 read d;
else
 d=$1;
fi
echo "docker registry store location:$d";
echo "ready go ... ?  [ press any key to continue]";
read o;
if [ -d "$d"  -a -d "$d/images" ]  ; then
  images=$( ls -l $d/images | awk '{print $9}') ;
  c=0 ; c1=1; l="";
  for x in $images ;
  do
      let c+=1 ;
      echo "checking image $c:$x";
      b1=$( find $d/images  -type f \( -name "json" -o -name 'ancestry' \)  -path "./$x" -prune   -exec grep "\\s*$x\\s*"  -l {} \;) ;
      b2=$( find $d/repositories  -type f \( -name "json" -o -name 'ancestry' -o -name '_index_images' \)    -exec grep "\\s*$x\\s*"  -l {} \;);
      if [ -z "$b1" -a -z "$b2" ] ;  then
         let c1+=1;
         echo "no references images$c1:$x";
         if [ -n "$l" ] ; then l="$l "; fi;
         l=$l$x;
      fi ;
  done ;
  if [ -n "$l" ] ; then
   for x in $l ; do echo $x; done;
   echo "found images : $c1";
   echo "Are you sure for delete these images?[Y=yes]"; read input1;
   if [ "$input1" = "Y" ] ; then
      echo "before cleanup du -sm $d/images:$(du -sm $d/images)";
      for x in $l ; do echo $x ; rm -r "$d/images/$x" ; done ;
      echo "after cleanup du -sm $d/images:$(du -sm $d/images)";
   fi
  else
    echo "found nothing to cleanup."
    echo " du -sm $d/images:$(du -sm $d/images)";
  fi
else
 echo "dir:$d not exists!"
fi

layout in docker registry v2 has changed... this doesn't work anymore.
Has there been improvement in the registry v2 to support this feature now?


Adding d-math with innerhtml doesn't render

element.innerHTML = "<d-math>x</d-math"; renders empty.

Fixed with missing super.connectedCallback()


GEODE-8688: Fix flaky C++ native client integration tests

The following integration test cases under
integration/test (new integration tests)
ar flaky (do not
fail normally when run locally but fail very often
when run in CI).

PartitionRegionOpsTest.getPartitionedRegionWithRedundancyServerGoesDownSingleHop
PartitionRegionOpsTest.putPartitionedRegionWithRedundancyServerGoesDownSingleHop

There were two reasons that can make them fail.
One of them is that sometimes the connections to the server have expired
before the server is restarted and therefore, when traffic is sent
to the restarted server, no errors are found. To fix this,
the pool configuration for the test client
has been changed so that connections do not expire.
The other reason is that sometimes the error in the connection is
found by the ping thread that is invoking the
ThinClientPoolDM::sendRequestToEP() method and in this method,
when the IO error or TIMEOUT error are encountered,
the endpoint is not removed from the metadata (by means of the
removeBucketServerLocation method).
The code has been updated to remove the metadata also in this
case.
With these two changes, the test cases are not flaky anymore.

Codecov Report

Merging #686 (ad2984f) into develop (52c8c16) will decrease coverage by 0.25%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop     #686      +/-   ##
===========================================
- Coverage    74.27%   74.01%   -0.26%
===========================================
  Files          644      644
  Lines        51187    51187
===========================================
- Hits         38017    37885     -132
- Misses       13170    13302     +132

Impacted Files
Coverage Δ

cppcache/src/ThinClientPoolDM.hpp
88.70% <ø> (ø)

cppcache/src/ThinClientPoolDM.cpp
76.27% <90.00%> (+0.46%)
:arrow_up:

cppcache/src/MapSegment.cpp
68.06% <100.00%> (+2.25%)
:arrow_up:

cppcache/src/PutAllPartialResult.cpp
0.00% <0.00%> (-47.62%)
:arrow_down:

cppcache/src/VersionedCacheableObjectPartList.hpp
52.70% <0.00%> (-27.03%)
:arrow_down:

cppcache/src/CacheableObjectPartList.hpp
62.50% <0.00%> (-25.00%)
:arrow_down:

cppcache/src/ReadWriteLock.cpp
62.50% <0.00%> (-18.75%)
:arrow_down:

cppcache/src/ThinClientRegion.cpp
56.04% <0.00%> (-4.67%)
:arrow_down:

cppcache/src/PutAllPartialResult.hpp
0.00% <0.00%> (-4.55%)
:arrow_down:

...tion-test/testThinClientRemoteQueryFailoverPdx.cpp
85.48% <0.00%> (-4.04%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0791032...ad2984f. Read the comment docs.


Integration of Knative Adapter for Enhanced Logging in Tekton Results API

Feature request
This issue proposes the integration of a Knative adapter to enhance logging capabilities within the Tekton Results API component. This transition aims to address the limitations and lack of uniformity in logging across the API and watcher currently observed with the zap logger.
Original Issue  - #272
Use case
The Tekton Results API employs a zap logger, which has demonstrated limitations and inconsistencies, particularly in uniformity across the API and watcher components. Adopting a Knative-based logging approach, inspired by its successful use in Tekton Triggers and Pipelines-as-Code projects, promises enhanced flexibility, integration, and customization.
Benefits

Standardized and uniform logging across different components.
Enhanced configurability using Kubernetes ConfigMaps, allowing dynamic adjustments at runtime.

Potential Drawbacks

Dependency on the Kubernetes client.
We'll still need a middle-ware in cases like fetching context in the RBAC pkg of Results API.

Preliminary configuration of adapter with Tekton-Results API
https://github.com/ramessesii2/downstream-tektoncd-results/blob/RAMESSESII2/results-api-knative-adapter-2/cmd/api/main.go

cc @khrm @enarha @sayan-biswas @avinal

Few things here i would like to mention..

Using the adapter would require us to change the current way of parsing config (which is currently handled by viper), if we want to use the configmap handler provided by knative.
This approach won't provide the benefit of injecting the logger and configurations in the context, as with the current  code the same context is not propagated in the handlers. Although we can use a middleware to insert that context in the chain, but that we can can simply do that without using the knative adapter complexities, since we know that knative also uses zap logger underneath.

Agreeing with the @sayan-biswas's feedback, I'm closing this issue.
The integration of a Knative adapter doesn't align with our current viper-based config parsing and context propagation needs in Tekton Results API . The complexities added by this approach, given our reliance on the zap logger, outweigh the benefits.


Create tests for AddProject use case

Use JEST to test the that projects get added to the DB

Hey! Are planning to create the tests for the front end or the back end for this use case?

Front-end!

Perfect! I will be working on creating back-end routing tests for the project and transcript data objects.


Push Up to Heroku Failing for New Applications

Via @thesunak, it was discovered that creation of new applications using Swoonatra is not allowing for database pushes up to Heroku.
Here is the error that is seen when trying to use git push heroku master:
remote:        Bundle complete! 15 Gemfile dependencies, 24 gems now installed.
remote:        Gems in the groups development and test were not installed.
remote:        Bundled gems are installed into ./vendor/bundle.
remote:        Bundle completed (31.50s)
remote:        Cleaning up the bundler cache.
remote:        Could not detect rake tasks
remote:        ensure you can run `$ bundle exec rake -P` against your app with no environment variables present
remote:        and using the production group of your Gemfile.
remote:        rake aborted!
remote:        PG::ConnectionBad: could not connect to server: Connection refused
remote:        Is the server running on host "<IP_ADDRESS>" and accepting
remote:        TCP/IP connections on port 5432?

Need to address this issue and any others that may arise.

Fixed issue by:
329a0b597d93404dbef02078440f8285103c13d9 => updating instructions for creating Heroku DB.
8b61507dab7bf4f396cedd33745ffbf3a7134499 => adding a Procfile per Heroku update.
Closing.


Infinite loop and latch contention

Development environment used

Z Open Editor version:
Editor Platform

[ x ] Visual Studio Code
[ ] Red Hat CodeReady Workspaces
[ ] Eclipse Che
[ ] Standalone Theia

Editor Platform Version:
Operating System (on which VS Code runs such as Windows 10 2004, otherwise name and version of platform such as OpenShift v4.3):
Java Version (when using VS Code or Theia, execute java -version and paste the details here):
[ ] Related to RSE API?

RSE API Plugin version:
Zowe CLI version: v2.15.0
Node.js version: v18.20.4

Logs attached (see here how to get them): yes/no

Problem Description
Detailed steps for reproducing the problem:

First step

Observed behavior
We noticed that a user had over 15,000 dead address spaces. We contacted the user and saw a very large number of get requests coming from their zopen editor. We determined that the issue was from the editor looking for a nonexistent copybook on the LPAR. We created the missing copybook and watched the issue stop.
Afterwards we recreated the issue by removing the copybook and watching it go into an infinite loop again. This is related to this issue. https://github.com/IBM/zopeneditor-about/issues/445
This is a problem with zopen editor interacting with z/osmf, we explored the recommended system settings in the tuning blog; however we feel that if a copybook is misssing 15,000 dead address spaces should not be created. Maybe only one lookup would be appropriate behavior

Expected behavior
We would expect that if a lookup failed it would not retry without the user clicking or something like that.

Did the ticket you opened with z/OSMF tech support not help? They pinged me for background and I pointed them to these issues and described the problem to them once again.

We believe there are two issues right now.
One is that the zopen editor client is making way too many requests. We don't believe it's good behavior if an engineer is sitting there idle with an open dataset that tens of thousands of requests would be going out and repeatedly failing to retrieve includes. Instead it should probably not retry at all, unless the developer hovers over it or something like that.
The second issue is that we don't believe z/osmf should be deadlocking the system when there are errors.
We opened a ticket with them and sent them logs for the second issue.

It will stop downloading when you close the file. If a file was not found it should stop looking for it again after it searched in all the property group locations. Let me verify that again.
I also discuss with the team if "zopeneditor.cobol.disableProblems": true should also not download include files.

Where does zopen editor store logs from outbound requests and where can I upload them? I will contact the engineer and get those to you.
When you say download all the files, do you mean the files in the dataset that the engineer is viewing and the includes, copybooks, etc. correct? Not the entire PDS?
What we are seeing in SDSF is the result of 16,000 requests to z/osmf from having one pdse member open, there are nowhere near that many includes in it.

Z Open Editor has a log that can be switched to the DEBUG level to provide a detailed output for how it tries to resolve include files showing you all the outgoing requests and Not Found errors when they happen as well as how it then continues searching in other locations or stop searching. See details here: https://ibm.github.io/zopeneditor-about/Docs/locating_local_client_logs.html
Yes, we only search for the include files that are used by a program currently opened in the editor: the language server tries to parse the program, finds an copy or include statement and then asks the editor to fetch it. The editor then uses the search order as defined in the zapp file. Our integration tests run with the default 5 parallel requests and can resolve programs with 1000 (small) copybooks in under a minute.
As mentioned in the other issue we have settings to control parallel execution of these requests as each concurrent request will create a new address space, but once finished the space should be reused by the next request. If that does not happen then z/OSMF tech support needs to help.

Turning this item into a bug as we found an issue with the listBeforeDownload setting that it would only run the list for data set members, but not the data sets themselves first.

I'm just commenting to you let you guys know what this is also a problem we encounter.
Additionally, we also noticed when our users were editing the copybook names in their file it would start looking for the copybook before the user stopped typing. For example if the user wants to type "COPY DATACPY".
When you finish typing copy if there is another word after COPY on another line it will start looking for that word as a copybook. Then afterwards it would start looking for a copybook called D, then DA, then DAT, then DATA. For every character that was written.
We will see if listBeforeDownload and adjusting the parallel requests will help, but would using RSE also fix this issue?

Thanks @TommyTechh. We are fixing the data set issue. Configuring the delay for requesting the file and deciding when the language should give up requesting the file we need to discuss internally first.
The listBeforeDownload setting was added mainly for z/OSMF. RSE API logs differently and a 404 is not much of a problem there.

We revised the behavior of the listBeforeDownload setting as discussed. It will now check also of the existence of the data and then the existence of the member. It will cache the data set existence result for 5 minutes to minimize traffic to the z/OS system.


Slicing bug with xarray

I found a subtle bug when slicing Images created with xarray, where an incorrect position is returned. Unfortunately, I am unable to demonstrate this with synthetic data, but the following notebook illustrates the problem:
https://gist.github.com/drs251/f97801aa7d6f92b11c9c71c6a7c4085a
EDIT: I found out how to reproduce it: the key is that the frames have to be non-square:
import numpy as np
import xarray as xr
import holoviews as hv
hv.notebook_extension()

x = np.linspace(-3, 7, 533)
y = np.linspace(-5, 8, 894)
z = np.exp(-1*(x**2 + y[:, np.newaxis]**2))
p = np.arange(5)
zz = np.dstack([z, z, z, z, z])
array = xr.DataArray(zz, coords=[y, x, p], dims=['x', 'y', 'p'])
array.name = "intensity"

image = hv.Dataset(array).to(hv.Image, kdims=["x", "y"])
image[0, -1:1, -1:1]

The slice should be nicely centered on the maximum, but it's not.

Probably I can have a look this week.

Glad we found the root issue. At this point I think we should close this issue and open a new one with a more accurate title regarding the real problem (something like 'Ignore origin setting in matplotlibrc') ?


Copy ingredients for shopping list

Is your feature request related to a problem? Please describe.
When I cook a certain recipe, I go through the ingredients. And when one is missing in my household, I want to write down the ingredient on my shopping list (that is a simple txt note).
Describe the solution you'd like
It would be great if I could copy all ingredients with one tap. And also single ingredients with one tap. Maybe it could also make sense to mark the ingredients by availability, and then copy the unavailable ones with one tap.
Describe alternatives you've considered
Alternative so far is writing down manually, which works. But sometimes you have also measures, and then it gets sometimes difficult. Other alternative is to go into edit mode, mark the ingredient and copy through context menu after long tap.

Hi @feinmann, thank you for your feature request.
I've already added a button to copy all ingredients to the clipboard. That feature will be shipped with the next release!
Inspired by your request, I'll also added the option to copy ingredients one by one by long pressing the desired ingredient in the future.


Usage of AES encryption is not possible for connect-cluster grantees (who are not owner)

Describe the bug
The issues concerns connect-clusters objects and, more specifically, permissions management.
Owners of Connect clusters can authorize other namespaces to deploy connectors on their own Connect clusters by giving an ACL with the WRITE permission to the grantees.
But grantees cannot use AES 256 encryption.
To Reproduce
Steps to reproduce the behavior:

Create a namespace (firstNamespace) with :

One connect-cluster (with AES configuration)
ACL to declare that the namespace is the owner of the connect-cluster

Create another namespace (secondNamespace)
On firstNamespace: Create ACL to give WRITE permission to connect-cluster of secondNamespace
On secondNamespace:
It's possible to deploy a connector in the connect-cluster of firstNamespace but it's not possible to use AES256 encryption.
So the secondNamespace can't secure your secrets.

Expected behavior
Owners of Connect clusters can authorize other namespaces to deploy connectors on their own Connect clusters by giving an ACL but now as a grantees I want to be able to encrypt secret on a connector with the configuration AES of the connect-cluster.
Environment (please complete the following information):

Kafkactl distribution and version v1.11.3

If known:

Ns4Kafka version: v1.11.9
Kafka broker type and version [Confluent Platform, v7.5.4]

Sorry, that was a mistake on my part
(my bad)


oceanspy using background_patch (and other) deprecated cartopy properties

OceanSpy version:
0.2 and 0.3.2

Description
I ran the notebooks within the docs folders (as well as those in binder) with the new environment. All run fine except Particles.ipynb. The problem is that the newer versions of cartopy (version > 0.20.2) have deprecated properties that oceanspy still currently uses. Particularly:
background_patch
xlabels_top
ylabels_right

Running Particles.ipynb in Sciserver with current compute image Oceanography (Integrated Viewer), you can see get a deprecated warning. See the snapshot below:

Starting with Cartopy version 0.21 (and matplotlib 3.5.2), Particles.ipynb already fails to complete.
Solution
As you can see in the snapshot above, we need to replace, the above properties by
GeoAxes.patch
.top_labels
.right_labels

I will work on this in the next couple of days. Then make a new (patch) release with these changes so that we can properly update the image in Sciserver.

There is a small chance that only the documentation notebook needs to change. I'm looking into this..

Ok. just making the change in the notebook (replace background_patch with .patch), gets you the following plot:

which does not have ticks nor labels on the axes. You can compare it against the snapshot above (first comment), which uses an older version of cartopy (it does have the ticks and labels).
There is no import error, because oceanspy only tries to use the deprecated axes properties from cartopy. The relevant code is on oceanspy.plot, lines 758-762, and it reads like:
                try:
                    gl = ax.gridlines(crs=transform, draw_labels=True)
                    gl.xlabels_top = False
                    gl.ylabels_right = False

This is the only place these deprecated properties are used.
Solution
I will make the change to the notebook and the above snippet of code, and get a PR going in a minute.

Turns out that the issue of ticks and labels not appearing, is because by default
add_labels=False

when plotting with od.plot.horizontal_section()
It used to be that add_labels=True by default, and so tick lines and labels appeared without the need to set this argument True (see here https://oceanspy.readthedocs.io/en/latest/Particles.html). Now, you have to specify them as an argument.
So now, in the example above,. we have to set it manually true as follows
    fig = plt.figure(figsize=(10, 5))
    ax = od_eul.plot.horizontal_section(varName="masked_Depth", cmap="bone_r", add_labels=True)
    land_col = (253 / 255, 180 / 255, 108 / 255)
    ax.patch.set_facecolor(land_col)
    ax.set_extent([-40, -19, 63, 68])

which produces the following plot

It is still true about the need to address the deprecation errors (specially in the notebooks!). But these do not need to happen before updating the Oceanography image in SciServer.
I will continue to work on the PR. But there is no need to make a new release inmediately after the PR.

Thanks @Mikejmnez !  All looks good.

I wasn't finished... but it is OK I guess. This turned out not to be critical.


Doc files are outdated

Describe the bug
Doc files (readmes) does not contain relevant information about valkey 8 support. We need to update it.
Expected Behavior
.
Current Behavior
.
Reproduction Steps
.
Possible Solution
No response
Additional Information/Context
No response
Client version used
1.1
Engine type and version
N/A
OS
N/A
Language
TypeScript, Python, Java
Language Version
N/A
Cluster information
No response
Logs
No response
Other information
No response

@Yury-Fridlyand is it done?

Yes, by #2299


Add hide_relativenumbers option

Turns off relativenumber in the current window while peeking.
The relativenumber option is useful for jumping around a file with 5j or 7k and requires less math in one's head to use. However if one is using :<number> they are switching to a mode where they only care about absolute line numbers, so it would be useful for the number line to also switch to absolute line numbers.
A new option hide_relativenumbers option is added so that users who don't like this behavior can easily turn it off. However, I left it on by default since I think it provides the best user experience to the most users.
https://user-images.githubusercontent.com/1505923/193432804-aba708e5-89f7-4408-8713-d483721c3e30.mp4

This is a nice improvement. I'll merge it. Thanks for your contribution ❤


Creating posts checklist

[ ] Create text post
[ ] text limit
[ ] Add hastags
[ ] Add mentions
[ ] Add hyperlinks
[ ] Add embeds
[ ] Add images
[ ] Add alt text to images
[ ] Add video
[ ] Open emoji
[ ] Add languages
[ ] post interaction settings

more:

[ ] create post threads
[ ] reply to post
[ ] quote posts

Might have forgotten some


Display image

Attachement is link but not displayed correctly in the message ....

Hover over it and make sure the domain is correct (it probably isn't - https://github.com/jk1/youtrack-idea-plugin/issues/157)

Hover over it and make sure the domain is correct (it probably isn't - https://github.com/jk1/youtrack-idea-plugin/issues/157)

Nop, the url seem fine ...
If i clic on the attachements file, that open a new tab in my browser and display the right img ...

Nop, the url seem fine ...
If i clic on the attachements file, that open a new tab in my browser and display the right img ...

@andrelec1 hi, is it still reproducible for you with 1.1.5 or 2.0.1?


Could I use this for git gist?

I want to insert git gist into markdown it...
And find this...

Currently this only supports Codepen, but if you want to add support for Gist go ahead and submit a pull request.


CARE-228: Update Microsoft.CodeAnalysis.CSharp.CodeStyle and remove dependency on netstandard

CARE-228

As usual, open a PR for this in OSOCE too.

Of course! Why wouldn't I?


No longer works on AWS Glue Python shell job

Describe the bug
Starting on 8/22/20, I started seeing the following exception when using aws-data-wrangler from a Python shell Glue job:
 File "/glue/lib/installation/awswrangler/__init__.py", line 10, in <module>
    from awswrangler import athena, catalog, cloudwatch, db, emr, exceptions, quicksight, s3, sts  # noqa
  File "/glue/lib/installation/awswrangler/athena/__init__.py", line 3, in <module>
    from awswrangler.athena._read import read_sql_query, read_sql_table  # noqa
  File "/glue/lib/installation/awswrangler/athena/_read.py", line 14, in <module>
    from awswrangler import _utils, catalog, exceptions, s3
  File "/glue/lib/installation/awswrangler/_utils.py", line 16, in <module>
    import s3fs  # type: ignore
  File "/glue/lib/installation/s3fs/__init__.py", line 1, in <module>
    from .core import S3FileSystem, S3File
  File "/glue/lib/installation/s3fs/core.py", line 14, in <module>
    import aiobotocore
  File "/glue/lib/installation/aiobotocore/__init__.py", line 1, in <module>
    from .session import get_session, AioSession
  File "/glue/lib/installation/aiobotocore/session.py", line 11, in <module>
    from .credentials import create_credential_resolver, AioCredentials
  File "/glue/lib/installation/aiobotocore/credentials.py", line 15, in <module>
    from botocore.credentials import EnvProvider, Credentials, RefreshableCredentials, \
ImportError: cannot import name '_get_client_creator'

To Reproduce
Using awswrangler-1.8.1-py3-none-any.whl
import awswrangler as wr

Hi @mkwatson, Thanks for reaching out!
This error seems to be related with the last major update on s3fs on 8/21/20 (one of Wrangler's dependencies).
But Wrangler keeps all dependencies versions pinned on fixed versions and only allows micro updates related to bug fix and w/o breaking changes. And it extends to our Glue artefacts (whl/egg).
So if you are using awswrangler-1.8.1-py3-none-any.whl it should install s3fs==0.4.2 and not 5.0.0 (The new version that you probably have there).
Just to double check we've run several tests here on Glue and we were not able to reproduce your issue.

Do you have others dependencies that relies on s3fs?
Could you check your logs on Glue to see what version of s3fs are being installed?

It should be something like:

Successfully installed SQLAlchemy-1.3.19 awswrangler-1.8.1 boto3-1.14.48 botocore-1.17.48 docutils-0.15.2 fsspec-0.8.0 jmespath-0.10.0 numpy-1.19.1 packaging-20.4 pandas-1.1.1 psycopg2-binary-2.8.5 pyarrow-1.0.1 pymysql-0.10.0 pyparsing-2.4.7 python-dateutil-2.8.1 pytz-2020.1 s3fs-0.4.2 s3transfer-0.3.3 six-1.15.0 sqlalchemy-redshift-0.8.1 urllib3-1.25.10

@igorborgest thanks for addressing this so quickly. My library that uses datawrangler, in fact, did have an unpinned version of s3fs listed under install_requires. I resolved that and all seems to be working now! Thanks so much!


fix WorkspaceSource's issues with rename and default-features

Motivations and Context
As talked about in #10685, there were some issues with the cargo_add::Dependency methods. They revolved around setting a source to a WorkspaceSource from another Source. They would leave remnants of the other source that conflicts with a WorkspaceSource (rename and default-features). This fixes that issue by making sure you cannot set rename or default-features if the source is a WorkspaceSource. Additionally, it clears the conflicting fields in a Dependency so they cannot show up even if you switched the Source.
Changes

Made set_rename and set_default_features return a CargoResult

They also return an error if the method is called on a WorkspaceSource

Made set_source clear conflicting fields when called with a WorkspaceSource

r? @epage

My first thought with this is: is this important enough that we should be focusing on this right now?

I could go either way on the importance of this right now. I think it is a change that should be made at some point but it is not needed right at this moment. If it should be closed until a better time just let me know!

I could go either way on the importance of this right now. I think it is a change that should be made at some point but it is not needed right at this moment. If it should be closed until a better time just let me know!

For me, the issue is this jumps straight to solving it one way when there are multiple ways without any discussion of the trade offs.  Having the discussion on which way to go was what I didn't feel was important enough to have right now.


Incorrect scale factor used by default

Hello,
I've noticed a mismatch between histology pixel coordinates and spots (spatial coordinates) when using the tg.plot_cell_annotation_sc function, which went away when I manually supplied the scale_factor argument. If I understand correctly, when adata_st.uns['spatial'] exists, the idea is to use that information, which should include scale factor, to accurately overlap the histology and spatial coords. In particular, my spatial AnnData had the scale factor stored in adata_st.uns['spatial'][sample_name]['scalefactors']['tissue_hires_scalef'], which I believe is a standard location where it should be found (rather than needing to specify scale_factor explicitly).
I traced the source of the "mismatch" to the default assignment of scale factor as 0.1, which is passed to sc.pl.spatial even when adata_st.uns['spatial'] exists. I imagine the default of 0.1 only makes sense when adata_st.uns['spatial'] doesn't exist.
I believe the same issue exists for the tg.plot_genes_sc function, though I haven't explicitly checked this. Apologies if I'm misunderstanding, and I've stored the scale factor in a non-standard location. Note that I'm using tangram 1.0.2 as installed through pip, and am following along the squidpy tutorial.
Thanks for providing the Tangram software!
Best,
-Nick

@gaddamshreya Could you also look at this please?

@Nick-Eagles thank you for identifying this issue!

@Nick-Eagles I've removed scale factor's default value for the plotting functions and updated the tutorial; thank you for bringing this to our attention!

Great! I appreciate you looking into this.


Issue triaging bot should tag service owners no matter which order the labels are applied

Currently as implemented (https://github.com/Azure/azure-sdk-tools/blob/main/tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/EventProcessing/IssueProcessing.cs#L164) the service attention rule will only trigger when the "Service Attention" label is applied. So in a case where the "Service" label is applied after this rule will not correctly tag users in the comments.
cc @jsquire @JimSuplizio

This is by-design and fits the current triage process.   Service Attention is the trigger to alert service teams that an issue is their purview.   Service is just a classification and is not considered as part of triage.   Once the CODEOWNERS changes are complete and we can enable fully automated triage, the initial process would identify that a service team should that library be owned by a service team.
As additional context, we should not be keeping pure service issues open in our repository, as these are not actionable.  If we receive an issue that is unrelated to an SDK - such as for a service or the portal, we should be guiding the issue author towards opening an Azure Support ticket.   The only Service issues that we should have in our repository are those that we use for tracking changes that we need to make to the SDK which are blocked by a service feature.
I'll leave this open for Jim to weigh in, but I don't see action here.

@weshaggard :  I'm re-reading this and wondering if I initially interpreted the intent wrong.    When you mention "service" above, are you talking about the literal Service (yellow) label or one of the pink labels that represent a service area?   My initial read was based on the former.   If it's the latter, then my opinion is different.

I'm talking about the Service Area label that is paired with the Service Attention (ex: https://github.com/Azure/azure-sdk-for-net/blob/main/.github/CODEOWNERS#L69) There is always a pair of labels that need to be present, and I believe the order of applying them shouldn't matter we don't want to make this that fragile and force folks to know they have to apply "Service Attention" last.

Ah, apologies.   I misinterpreted.   I agree that we should be able to add Service Attention and then add pink area labels to trigger notifications.  This was something that Fabric Bot couldn't do, so we overlooked it when porting rules.
@JimSuplizio :  I like this suggestion and would like to take it.   Any thoughts?

@jsquire @weshaggard @kurtzeborn
I'll make the necessary changes when I'm updating this to remove the old codeowners parser.


Code review comments (#2)

@mernst I have addressed all of the TODOs here. Take another look and then I will go ahead and merge these changes.

@Calvin-L This looks great.  Thanks for all the improvements.


Weird issue with Truncated SVD and NumericStringConvertor

So it took me ages to figure out the WHY, but I finally pinpointed some extremely weird behavior.
Namely, here's the simples code that reproduces the issue:
$dataset = \Rubix\ML\Datasets\Labeled::build([
    [5.1, 3.5, 1.4, 0.2],
    [4.9, 3, 1.4, 0.2]
], ['setosa', 'variosa'])->apply(new NumericStringConverter());

$transformer = new \Rubix\ML\Transformers\TruncatedSVD(2);

$dataset->apply($transformer);

var_dump($dataset);

Output
object(Rubix\ML\Datasets\Labeled)#2 (2) {
  ["labels":protected]=>
  array(2) {
    [0]=>
    string(6) "setosa"
    [1]=>
    string(7) "variosa"
  }
  ["samples":protected]=>
  array(2) {
    [0]=>
    array(2) {
      [0]=>
      float(0)
      [1]=>
      float(0)
    }
    [1]=>
    array(2) {
      [0]=>
      float(0)
      [1]=>
      float(0)
    }
  }
}

As you can see - it's all zeros.
Now, removing the NumericStringConverter:
$dataset = \Rubix\ML\Datasets\Labeled::build([
    [5.1, 3.5, 1.4, 0.2],
    [4.9, 3, 1.4, 0.2]
], ['setosa', 'variosa']);

$transformer = new \Rubix\ML\Transformers\TruncatedSVD(2);

$dataset->apply($transformer);

var_dump($dataset);

Gives following output:
object(Rubix\ML\Datasets\Labeled)#2 (2) {
  ["labels":protected]=>
  array(2) {
    [0]=>
    string(6) "setosa"
    [1]=>
    string(7) "variosa"
  }
  ["samples":protected]=>
  array(2) {
    [0]=>
    array(2) {
      [0]=>
      float(-6.3431263560806)
      [1]=>
      float(-0.1573150685585)
    }
    [1]=>
    array(2) {
      [0]=>
      float(-5.9145190147327)
      [1]=>
      float(0.16871521675666)
    }
  }
}

Now, it took me hours to figure out WTF is happening, because, apparently, nothing spectacular is ... BUT ... BUT! I pinpointed the issue to the following line in NumericStringCoverter:
    protected function convertToNumber(array &$sample) : void
    {
        foreach ($sample as &$value) {
            if (is_string($value)) {
                if (is_numeric($value)) {
                    $value = (int) $value == $value
                        ? (int) $value
                        : (float) $value;

                    continue;
                }

This foreach loop that passes reference to $value is the culprit! By replacing it with:
        foreach ($sample as $key => $value) {
            if (is_string($value)) {
                if (is_numeric($value)) {
                    $sample[$key] = (int) $value == $value
                        ? (int) $value
                        : (float) $value;

                    continue;
                }

all works as expected really!
This leads me to conclusion that for whatever WEIRD reason, something happens internally that messes up the SVD process. Now the problem is that SVD is written as C extension and I honestly have no clue how to debug that :)
My question is -- do you see this as a bug in NumericStringConverter or in C extension? If it's former, I'd be happy to submit a bugfix really!

Hey @MihailoJoksimovic yeah I've run into this problem before with SVD, unfortunately, I have not had the time to debug the issue. Maybe create an issue in the Tensor repo and see if someone can fix it. Thanks!


NotebookPanel refactor and tests

Allows the context on the notebook panel to change and updates the API to match other classes.
Changes the IDocumentContext to take a type argument and makes resulting changes
Fixes active cell tracking on the notebook widget.
Provides convenience signals on the notebook and the notebook panel to make it easier to follow the
current kernel and model.
Factored some completion behavior out of the notebook panel.
Updated the example in tuturial/notebook.md

@jasongrout, I changed the context to explicitly contain the model and be generically typed on the model type.  We were throwing away some type safety otherwise.  See 80dd8b2.

The cell selection logic isn't quite working yet.

This is ready for review.

Looking at this now...

I looked at the code, and it looks good, modulo some inline comments above.

The changes look great; thanks. One last thing on the image widget, and I'll merge.

Ready to roll.

The code looks good to me; thanks! Needs rebasing, though.

Rebased and good to go.

Thanks!


hashlimitexpire default changed and tests/docker fixes

Coverage increased (+0.7%) to 62.031% when pulling c8082b88be25e1d0662bc17e13eb690206875f01 on dev into 5a019df91c0538188955a90960cc75521387990a on master.


Decouple the managers from the engine

Currently the manager instantiates the Factories and Mouse managers internally.
Having the ability to receive custom managers implementing the Manager's interfaces will allow us better flexibility, decoupling and testability.
Suggestion:
constructor(public managers: EngineManagers, public canvas$: ValueState<HTMLElement | null> = createValueState<HTMLElement | null>(null)) {
 // handle missing managers and set defaults if needed
}

#96


colon in footnote refs and backrefs introduces js error

clicking on a footnote forward link or backlink results in the following javascript error:
Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo:

seems related to semantic tab module; see Semantic-Org/Semantic-UI#6750

Fixed in https://github.com/fomantic/Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/499


HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes

Description of PR
Test Script used by ABFS to validate changes has following two issues:

When there are a lot of test failures or when error message of any failing test becomes very large, the regex used today to filter test results does not work as expected and fails to report all the failing tests. To resolve this, we have come up with new regex that will only target one line test names for reporting them into aggregated test results.
While running the test suite for different combinations of Auth type and account type, we add the combination specific configs first and then include the account specific configs in core-site.xml file. This will override the combination specific configs like auth type if the same config is present in account specific config file. To avoid this, we will first include the account specific configs and then add the combination specific configs.

Some tests were reported to be failing on OSS trunk including those reported via following Jira:
https://issues.apache.org/jira/browse/HADOOP-19110
https://issues.apache.org/jira/browse/HADOOP-19106
For details of the failing tests and their fixes please refer to the Jira Description:
https://issues.apache.org/jira/browse/HADOOP-19129
How was this patch tested?
Test Suite was run involving different combinations of Auth type and Account type.
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 14 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 14s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  4s

trunk passed

+1 :green_heart:
shadedclient
38m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 4 unchanged - 3 fixed = 5 total (was 7)

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  7s

the patch passed

+1 :green_heart:
shadedclient
38m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 12s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

142m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 9695c9c472e8 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aaed50fda0ac1aa2e9ad27cf7894c9842248a75a

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/2/testReport/

Max. process+thread count
593 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  1s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 25s

trunk passed

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  4s

trunk passed

+1 :green_heart:
shadedclient
34m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 5 unchanged - 3 fixed = 6 total (was 8)

+1 :green_heart:
mvnsite
0m 30s

the patch passed

+1 :green_heart:
shellcheck
0m  1s

No new issues.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  7s

the patch passed

+1 :green_heart:
shadedclient
35m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 30s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

131m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 7e518f87f2f7 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cb18c94fa838f0800f3df5bf0e33a69c62f64139

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/3/testReport/

Max. process+thread count
559 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

============================================================
HNS-OAuth
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2
[WARNING] Tests run: 620, Failures: 0, Errors: 0, Skipped: 73
[WARNING] Tests run: 340, Failures: 0, Errors: 0, Skipped: 57
============================================================
HNS-SharedKey
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 620, Failures: 0, Errors: 0, Skipped: 42
[WARNING] Tests run: 340, Failures: 0, Errors: 0, Skipped: 41
============================================================
NonHNS-SharedKey
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 9
[WARNING] Tests run: 604, Failures: 0, Errors: 0, Skipped: 268
[WARNING] Tests run: 340, Failures: 0, Errors: 0, Skipped: 44
============================================================
AppendBlob-HNS-OAuth
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2
[ERROR] Tests run: 620, Failures: 0, Errors: 0, Skipped: 74
[WARNING] Tests run: 340, Failures: 0, Errors: 0, Skipped: 81

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
51m  0s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  5s

trunk passed

+1 :green_heart:
shadedclient
39m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

hadoop-tools/hadoop-azure: The patch generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 17s

the patch passed

+1 :green_heart:
shadedclient
38m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 12s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

146m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 511f1ace037f 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c1427b1992a314bde601d389c54bcc183c4658fd

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/4/testReport/

Max. process+thread count
590 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 10s

trunk passed

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 35s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  6s

trunk passed

+1 :green_heart:
shadedclient
33m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

hadoop-tools/hadoop-azure: The patch generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)

+1 :green_heart:
mvnsite
0m 30s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  3s

the patch passed

+1 :green_heart:
shadedclient
32m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 29s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

127m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle

uname
Linux 3bd0be518c10 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bf0e3fb42cc2f7636ca1d3c48d14be5645810413

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/5/testReport/

Max. process+thread count
553 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 14s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 22s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  3s

trunk passed

+1 :green_heart:
shadedclient
38m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 26s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 10 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 19s

hadoop-tools/hadoop-azure: The patch generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  2s

the patch passed

+1 :green_heart:
shadedclient
39m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 12s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

160m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle markdownlint

uname
Linux a342f076ada8 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 675f113ca96267f73f4ac82efb79594d4f12004f

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/6/testReport/

Max. process+thread count
540 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 19s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  3s

trunk passed

+1 :green_heart:
shadedclient
38m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 26s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 10 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 19s

hadoop-tools/hadoop-azure: The patch generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  3s

the patch passed

+1 :green_heart:
shadedclient
39m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 20s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

145m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle markdownlint

uname
Linux 09f53fceb400 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c899c903f58fce170bdac8e966e635d9d898ef38

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/7/testReport/

Max. process+thread count
528 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

============================================================
HNS-OAuth
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2
[ERROR] Tests run: 620, Failures: 0, Errors: 0, Skipped: 73
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 54
============================================================
HNS-SharedKey
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 3
[ERROR] Tests run: 620, Failures: 0, Errors: 0, Skipped: 28
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 41
============================================================
NonHNS-SharedKey
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 9
[ERROR] Tests run: 604, Failures: 0, Errors: 0, Skipped: 269
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 44
============================================================
AppendBlob-HNS-OAuth
[WARNING] Tests run: 137, Failures: 0, Errors: 0, Skipped: 2
[ERROR] Tests run: 620, Failures: 0, Errors: 0, Skipped: 75
[WARNING] Tests run: 380, Failures: 0, Errors: 0, Skipped: 78

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
54m 29s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  5s

trunk passed

+1 :green_heart:
shadedclient
39m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 26s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 7 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
0m 19s

hadoop-tools/hadoop-azure: The patch generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  3s

the patch passed

+1 :green_heart:
shadedclient
39m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 12s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

150m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle markdownlint

uname
Linux 6f769bac7907 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 86df6337a51c14728f49fa3e03b8b807e80c5e14

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/8/testReport/

Max. process+thread count
528 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 16 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 10s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  4s

trunk passed

+1 :green_heart:
shadedclient
38m 35s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

hadoop-tools/hadoop-azure: The patch generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
shellcheck
0m  2s

No new issues.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  3s

the patch passed

+1 :green_heart:
shadedclient
38m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 13s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

144m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle markdownlint

uname
Linux bda84a54ba1e 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c54a297bd8724fa00069aecd8c4a5854d7e6d4d0

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/9/testReport/

Max. process+thread count
579 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 12 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 29s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 33s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  6s

trunk passed

+1 :green_heart:
shadedclient
33m 33s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
33m 53s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

hadoop-tools/hadoop-azure: The patch generated 0 new + 4 unchanged - 3 fixed = 4 total (was 7)

+1 :green_heart:
mvnsite
0m 30s

the patch passed

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  5s

the patch passed

+1 :green_heart:
shadedclient
33m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 32s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

139m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6676

Optional Tests
dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall shadedclient spotbugs checkstyle markdownlint

uname
Linux a9a7e15ecad3 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / abb6c113befda6fb2e94bd91b4aaec63ab69520c

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/10/testReport/

Max. process+thread count
553 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6676/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@anujmodi2021 can you do a PR for this for branch-3.4?


Add Django rest framework

https://www.django-rest-framework.org/

Endpoint of the API is: /platform/rest/


Content pipeline version mismatch between csproj and Content.mgcb files

On a new clone and build, I get about 35 "Failed to create importer" errors.
I noticed that all the Content.mgcb files reference this package:
"/reference:.........nuget\packages\monogame.extended.content.pipeline\3.9.0-alpha0001\tools\MonoGame.Extended.Content.Pipeline.dll"
Whereas the actual projects reference the latest stable version 3.8.0, not 3.9.0-alpha0001.
Fixing that path fixes the build for me.

OK; yes, this was my mistake.


Upgrade coteditor to v2.1.6

Needs conflict fix.

Looks like I was a little slow on updating this one. I'll submit another PR later with just the version changes.


[Bug]: GraphQL: installation to few workspace has failed

Is there an existing issue for this?

[X] I have searched the existing issues

Description
It seems that the GraphQL plugin installation to few workspaces has failed due to few interruptions in the migration run when prod clusters were coming up. Re-attempting to install the plugin should fix the issue.
Steps To Reproduce
https://theappsmith.slack.com/archives/C03HF7YJ6RF/p1663132345464659
Public Sample App
No response
Version
cloud

Verified the issue and looks good to be merged


Hide "dev flags" --show-ssa, --show-brillig, and --print-acir from showing in CLI help

Problem
The --show-ssa, --show-brillig, and --print-acir are not hugely useful for most users of Nargo, mainly for us on the Noir team which need to use them for debugging the Noir compiler itself.
While they should exist, we don't need to document them for end users.
Happy Case
These flags should be hidden from the CLI help output. One exception on this is that we should potentially allow printing ACIR on the nargo info command.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response

What's the harm to leaving them as is? Noise?

Yeah, 90% of developers never need to use these flags. I'm also planning on restricting which commands they apply to (they currently apply to prove just because it implicitly compiles Noir code if we don't provide ACIR).

Makes sense.
I guess I don't have a strong opinion for this case specifically, but in general we might want to have one "source of truth" (whether it being nargo help, docs, or other places) where people that want to dig deep can count on.

While certain things would be available (but hidden) we can state in documentation that they are there but we believe they're not useful for wider population and therefore we do not think about continuing support for them; they might be exposed in some other ways...

@kobyhallx certainly!
Do check the doc needs box on the PR if docs are where the info should live 🙌


Create jackcviers/cp-kerberos image for tests

Use cp-docker-images/tests/kerberos as a base.

[x] Create jackcviers/cp-kerberos on Dockerhub
[x] Create cross-platform image for jackcviers/cp-kerberos:7.0.0 (5.3.6 was the latest version on cp-docker-images upstream)

Closed by #49


Fix message of travis build commit

Coverage remained the same at 99.272% when pulling bbac38efbfe96ac6ff593efd23403ac279a67e37 on travis-fix into aca094ad60fb5b6c80509253390154b82b39c3de on master.

Coverage remained the same at 99.272% when pulling bbac38efbfe96ac6ff593efd23403ac279a67e37 on travis-fix into aca094ad60fb5b6c80509253390154b82b39c3de on master.


Pymcon branding

Added PyMCon folder -> README.md contains branding guide for PyMCon.
Added PyMCon color swatches. Colors and swatches pulled from website and logos.
Multiple commits here are dealing with organization and formatting.

cc @cuchoi for approval

These .DS_Store files should not be included in the PR

Fixed both!

Thank you much!


Adding flag --external-driver-addr to allow the kontainer-engine to communicate with external driver clusters.

Adding flag --external-driver-addr to allow the kontainer-engine to communicate with external driver clusters.

Moving this back to nextup. Waiting for a new PR in the master repo.

Moving to the backlog until a new master repo PR is created.


Rename Tab component "style" property

[x] I have searched the Issues to see if this bug has already been reported
[x] I have tested the latest version

Summary
I would like Flowbite Tabs component to respect the established styling related properties from native html elements, namely "style" and "className".
In the case of the Tabs component, the "style" html property is Omitted in favor of Flowbite React's own style attribute:
export interface TabsProps extends Omit<ComponentProps<'div'>, 'ref' | 'style'> {
  onActiveTabChange?: (activeTab: number) => void;
  style?: keyof TabStyles;
  theme?: DeepPartial<FlowbiteTabsTheme>;
}

Unnecessary styling solution narrowing
I think this is an unnecessary narrowing of the component interface. Tabs is still exposing className so why can't we apply styles through the native style-property?
Eslint problem
<Tabs style="underline"/>
also results in
Style prop value must be an object eslint[react/style-prop-object](https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/style-prop-object.md)
Codebase cleanliness
In my codebase I am wrapping each Flowbite component and disabling className and style properties with a utility type so that other developers in the company don't override our style system. The Tabs component's style property not being of type React.CSSProperties causes unnecessary complications in this pattern.
Proposed solution
Stop omitting 'style' from the Tabs component interface and rename the current style-property to something else.

This totally makes sense, will mark it as "to fix" for the upcoming releases.

Fixed in<EMAIL_ADDRESS>release.


Update for property define renaming in SDL3

Update for SDL3 changes in https://github.com/libsdl-org/SDL/pull/9049.

Merged, thanks!


Button Clickability Issue

The buttons contain a button-shaped area, clicking on the entire button doesn't trigger the intended action. Instead, the "try now" text needs to be clicked explicitly for the button to work as expected
This behavior may cause confusion.
So I'd like to work on this issue under JWoC

@this-is-yaash go for it!


Update OMERO sidebar for proposed navigation

This implements the change proposed on https://github.com/openmicroscopy/www.openmicroscopy.org/pull/195
Doing this now so I don't forget about it but also applying an exclude label for now as it'll break the linkchecker and also the website proposal hasn't been approved yet.

Proposal accepted so I'll remove the exclude label once it's deployed live - we can let the redirects handle this until the OMERO release

Deployed live, removing the exclude label for inclusion in tomorrow's build

This might have been mentioned on https://github.com/openmicroscopy/www.openmicroscopy.org/pull/195 but when I click on the Features link from docs, I go to https://www.openmicroscopy.org/omero/features/ which looks like "New Features" page, so I was going to suggest that the link be titled "New Features". But then I read the PR and noticed that that's the home page of ALL features.
I think it's confusing because the main title "New with OMERO" comes above the line of links, so it maybe feels like they are sub-sections of "New with OMERO". I can see the same approach is used on other pages too, and I don't think I've found it confusing before, so maybe it's just when landing at the website or that section for the first time?
Maybe the home page for a section, e.g. features, should have a main title that applies to the whole section. E.g. "New with OMERO" -> "OMERO features" ?

At the moment, the text in the headers is set for all the features page as 'xxx with OMERO' but i could open a PR to change it.
In the meantime though, I assume you're happy for this to be merged?

Yes, good thanks


♻ Refactor internal imports to reduce redundancy

There's a redundant import which can be fixed with either of these:
from sqlalchemy import CHAR, types

Or:
from sqlalchemy.types import CHAR, TypeDecorator

Cool, thanks @aminalaee! :cake:


Moved IME upstream deletion in empty nodes to Editor requests instead of direct implementation, for the purpose of extensability (Resolves #1259)

Moved IME upstream deletion in empty nodes to Editor requests instead of direct implementation, for the purpose of extensability (Resolves #1259)

@miguelcmedeiros  let me know if this approach to deleting upstream at the beginning of nodes works for your needs. The PR includes 3 examples of request -> command pairs that respond to upstream deletions at the beginning of nodes. Those should give you an idea about how to add your own.

@miguelcmedeiros @angelosilvestre this is the real PR for this change. It's ready for review.


Graphics glitch in Maui windows and iOS

ScottPlot 5.0.42 in Maui
Has anyone else observed a graphics glitch when panning in Windows and iOS? Android does not appear affected. When panning is started, the plot momentarily jumps off screen and comes back on screen again. The only method that corrects the behavior is to "autoscale" after app loads using context menu. Autoscale and Refresh in the program will not correct the behavior, it has to be autoscale in the plot window.
The maui app is simple. In the XAML
<Grid ColumnDefinitions="*" RowDefinitions="*" Padding="30,20,30,20">
    <ScottPlot:MauiPlot x:Name="MauiPlot1" />
</Grid>

In the code behind, call this method after app initialization
private void SimpleDrawPhasorPlot()
{

    //Create arrow base coordinates used for all vectors
    Coordinates arrowBase = new(0, 0);

    // create arrow 1
    Coordinates arrow1Tip = new(5, 0);
    CoordinateLine arrow1Line = new(arrowBase, arrow1Tip);
    // add a simple arrow
    var arrow1 = MauiPlot1.Plot.Add.Arrow(arrow1Line);
    arrow1.ArrowFillColor = Colors.Red;
    arrow1.ArrowLineWidth = 0;
    arrow1.ArrowWidth = 5;
    arrow1.ArrowheadLength = 20;
    arrow1.ArrowheadAxisLength = 20;
    arrow1.ArrowheadWidth = 20;
    var dl1 = MauiPlot1.Plot.Add.Text("T(1)", arrow1Tip);
    dl1.LabelFontSize = 36;
    dl1.LabelFontColor = Colors.Black;

    //Enable touch
    MauiPlot1.EnableTouchEvents = true;

    //Autoscale
    MauiPlot1.Plot.Axes.AutoScale();

}

Without Touch enabled, the behavior is even more erratic. Feel free to add Refresh, it doesn't change anything.

Hi! I just published a PR here, fixing the glitchs you mentioned. I have corrected them, and now everything should work well.
It is no longer necessary to call MauiPlot1.EnableTouchEvents = true; it is set according to the platform in the constructor. Also, if the plot appears too large, it can be corrected by adjusting MauiPlot1.Plot.ScaleFactor = 0.9, for example, and refreshing, or by reducing the sizes of the objects to be displayed. I hope it will be available in the next update.
Thank you for pointing out this glitch!"

@KosmosWerner

I have corrected them, and now everything should work well.

Just got the update, works very well indeed!

Ported the update using the example plot above to iOS and Android.
Zoom sensitivity on both platforms is (too) high. Android on the order of 2 or 3. iOS on the order of 20 to 30 (maybe more). Max zoom can be set on iOS but even at setting = 1, the plot zooms in/out too much. In fact, I lost the plot completely at one point.
I also have a need to use
            MauiPlot1.Plot.HideGrid();
            MauiPlot1.Plot.Layout.Frameless();

on some plots. In addition to the zoom issue, the above commands disable right/left panning. Windows does not have this behavior and works fine in all cases. I have not ported to MacOS though, which is another target platform for my app, so i can't comment on that.
Any suggestions on how to proceed?

Hi, I think this issue is due to the part I modified: IgnorePixelScaling = true; because panning and zooming were not working properly before.
A temporary solution would be to set MauiPlot.IgnorePixelScaling = false when initializing the plot. If you could attach an image of the issue, I could look into it later to see what is happening
I hope this temporary solution works!

...good points about zoom sensitivity though! I started #4443 to track progress toward adding this feature. It may take me a while to get to it, but if someone gets to it before I do and creates a pull request I would be happy to review it in good time 👍

Adding MauiPlot1.IgnorePixelScaling = false; has no effect on zooming or right/left panning

I spent quite some time searching for the issue because the touch controls use UserInputProcessor the same way as the mouse, so it didn't make sense that there was only vertical panning
By default, MAUI only returns relative movement, from (0,0) to a position (x,y), and that's where the problem lies. When the screen is pressed (equivalent to a left mouse click), I use Interactivity.UserActions.LeftMouseDown(Pixel.Zero). For some reason, it only moves along the Y-axis, but making a small change like Interactivity.UserActions.LeftMouseDown(new(1,1)) makes it work, and it moves as expected. This suggests that starting from the origin fails for some reason
Regarding zoom, MAUI returns the scale factor, which indicates the current distance between my fingers compared to the previous one, returning values like 1.04, 1.07, 0.98, etc., which are more natural. Interactivity.UserActions.MouseWheelUp(pixel) and MouseWheelDown adjust by approximately 1.15 and 0.85. So, if MAUI detects even a slight change, like 1.01, the zoom will increase by 1.15
I'm making the modifications and will submit a PR soon.

In the next release, click-drag zoom sensitivity can be changed like this:
foreach (var response in formsPlot1.UserInputProcessor.UserActionResponses)
{
    if (response is ScottPlot.Interactivity.UserActionResponses.MouseDragZoom zoom)
    {
        zoom.SensitivityX = 10;
        zoom.SensitivityY = 10;
    }
}

#4443


permission fail

Hi
[2022.08.23 20:04:26.537] [0077] DEBUG Receiving
[2022.08.23 20:04:26.538] [0033] TRACE relaying data from transactionID<PHONE_NUMBER>2f724254316f61 to IPV4://x.x.x.x:52983
[2022.08.23 20:04:26.591] [0077] DEBUG Receiving
[2022.08.23 20:04:26.591] [0033] TRACE relaying data from transactionID 472f76575569542b34744774 to IPV4://y.y.y.y:52983
[2022.08.23 20:04:26.639] [0077] DEBUG Receiving
[2022.08.23 20:04:26.640] [0033] TRACE relaying data from transactionID 2f546b56597239494650795a to IPV4://s.s.s.s:63111
[2022.08.23 20:04:26.640] [0035] TRACE permission fail for IPV4://s.s.s.s:59123 at s.s.s.s:63111
...

RTCIceConnectionStateFailed
please help me.
what should I do?

hi,
need some code to reproduct issue

https://github.com/flutter-webrtc/flutter-webrtc-demo