Update index.md

Thank you for contributing! Please confirm this pull request meets the following requirements:

[ ] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Videos p************ today's Yankees
On Sat, Feb 16, 2019, 5:28 PM dhewya<EMAIL_ADDRESS>wrote:

Thank you for contributing! Please confirm this pull request meets the
following requirements:

I followed the contributing guidelines:
https://github.com/github/explore/blob/master/CONTRIBUTING.md
I have no affiliation with the project I am suggesting (as a
maintainer, creator, contractor, or employee).

Which change are you proposing?

Suggesting edits to an existing topic or collection
Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

Image (and my file is *.png, square, dimensions 288x288)
Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these
changes should be made.
Curating a new topic or collection

I've formatted my changes as a new folder directory, named for the
topic or collection as it appears in the URL on GitHub (e.g.
https://github.com/topics/[NAME] or
https://github.com/collections/[NAME])
My folder contains a *.png image (if applicable) and index.md
All required fields in my index.md conform to the Style Guide and
API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic
or collection should be curated.

Please note: we will close your PR without comment if you do not check
the boxes above and provide ALL requested information.
You can view, comment on, or merge this pull request online at:
https://github.com/github/explore/pull/573
Commit Summary

Update index.md

File Changes

M topics/indieweb/index.md
https://github.com/github/explore/pull/573/files#diff-0 (1)

Patch Links:

https://github.com/github/explore/pull/573.patch
https://github.com/github/explore/pull/573.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/explore/pull/573, or mute the thread
https://github.com/notifications/unsubscribe-auth/AtHQXqlGwiw9FIEEcb9p_wKxkzEyG3Gzks5vOLAzgaJpZM4a_TJL
.


<EMAIL_ADDRESS>remove babel transform runtime

Pull Request Test Coverage Report for Build 801478089

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.476%

Totals

Change from base Build 786730214:
0.0%

Covered Lines:
53

Relevant Lines:
57

💛  - Coveralls


Preprint info sheet

Make an info page about preprints and their contribution to advancing scientific discovery.

We haven't started a Google doc for this yet, but if you would like to work on this please feel free to create a Google doc. It would be helpful if you could share the file with the PreprintJC google account and change the settings so anyone with the link can access it (then post the link here). Thank you so much for your help!

Updated info sheet can be found here. Please let us know if it's helpful or not. Thanks!


URL Cleanup

This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).
Fixed URLs
Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

http://www.apache.org/licenses/ with 1 occurrences migrated to:
https://www.apache.org/licenses/ (https result 200).
http://www.apache.org/licenses/LICENSE-2.0 with 430 occurrences migrated to:
https://www.apache.org/licenses/LICENSE-2.0 (https result 200).

Closed via 8d5f4c2


fixing DictionaryAdapterObj so we can iterate multiple times.

This change is

@mukhole is added to the review. #Closed

:shipit:


generate Pypi/conda packages

Good example would be the MRD repo, see https://github.com/microsoft/yardl/issues/108#issuecomment-2135292040 for some info.
It looks like for MRD, the generated code is added to the repo, presumably via some actions etc. Usually I don't like adding generated code to a repo, but otherwise we probably need 2 different repos (the model, and the generated code). Suggestions welcome!

@KrisThielemans it seems like they have a the following actions

Create the environment necessary for using yardl: https://github.com/ismrmrd/mrd/blob/main/.github/actions/configure-mrd-build-environment/action.yml
Build the source code for cpp/python/matlab using yardl https://github.com/ismrmrd/mrd/blob/main/.github/workflows/mrd_build.yml
Then some code for (a) publishing to pypi https://github.com/ismrmrd/mrd/blob/main/.github/workflows/mrd_pypi.yml and (b) publishing to conda https://github.com/ismrmrd/mrd/blob/main/.github/workflows/mrd_conda.yml

I'll play around with a forked version of the repository and test-pypi to see if I can get something similar to what they have.

@KrisThielemans here are my initial thoughts: let me know if you think there's an issue with this though:

We add a pyproject.toml file to the /python  directory which acts as the requirements file for all code generated by running yardl. e.g., after yardl has been ran, there will be a /prd  folder with a correpsonding pyproject.toml file inside the python folder.
We build the code inside the python directory using python -m build, which will read the pyproject.toml file and create a build version of the /prd file. Then we publish to pypi
When users download this, they'll only have access to the code that was generated in the /prd folder. Which I suspect is what they want. Then they can, for example, run pip install prdpy and then from prdpy.binary import BinaryPrdExperimentWriter and etc...


Admin UI fails to load after upgrade

As noted in the Google group, I've now had several instances where the Admin UI fails to load after updating the node modules using npm update.
The list of nodes in the template sidebar does not load, neither do the flows themselves. Debug messages do appear & the rest of the interface works.
Clearly one of the node modules that is being loaded is failing but there are no obvious errors and it appears very difficult to be able to disable/delete nodes anyway, especially if they are in use.
Reference to the Google Group message: https://groups.google.com/forum/#!topic/node-red/AZFjgc31CGE
I am seeing some errors in the browser so I'm not sure if that is pointing to the issue:
In Chrome:
Node-RED: 0.13.4
red.min.js:16 Uncaught TypeError: Cannot set property 'added' of undefined
   e.registerNodeType @ red.min.js:16
   (anonymous function) @ VM2353:2
   (anonymous function) @ vendor.js:2
   m.extend.globalEval @ vendor.js:2
   m.fn.extend.domManip @ vendor.js:4
   m.fn.extend.append @ vendor.js:4
   $.ajax.success @ red.min.js:16
   j @ vendor.js:2k.fireWith @ vendor.js:2
   x @ vendor.js:5
   b @ vendor.js:5

And in IE11:
HTML1503: Unexpected start tag.
red (23,1)
HTML1508: Unmatched end tag.
red (39,1)
HTML1512: Unmatched end tag.
red (44,195)
SCRIPT5007: Unable to get property 'splice' of undefined or null reference
vendor.js (427,426)
Node-RED: 0.13.4
SCRIPT5007: Unable to set property 'added' of undefined or null reference
red.min.js (16,23936)

And the startup log (verbose):
Apr 16 00:16:56 pi2 NR-Live2[16440]: Welcome to Node-RED
Apr 16 00:16:56 pi2 NR-Live2[16440]: ===================
Apr 16 00:16:56 pi2 NR-Live2[16440]: 16 Apr 00:16:56 - [info] Node-RED version: v0.13.4
Apr 16 00:16:56 pi2 NR-Live2[16440]: 16 Apr 00:16:56 - [info] Node.js  version: v4.4.2
Apr 16 00:16:56 pi2 NR-Live2[16440]: 16 Apr 00:16:56 - [info] Linux 4.1.19-v7+ arm LE
Apr 16 00:16:56 pi2 NR-Live2[16440]: 16 Apr 00:16:56 - [info] Loading palette nodes
Apr 16 00:17:16 pi2 NR-Live2[16440]: 16 Apr 00:17:16 - [info] UI started at /ui
Apr 16 00:17:18 pi2 NR-Live2[16440]: { [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
Apr 16 00:17:18 pi2 NR-Live2[16440]: js-bson: Failed to load c++ bson extension, using pure JS version
Apr 16 00:17:25 pi2 NR-Live2[16440]: 16 Apr 00:17:25 - [warn] ------------------------------------------
Apr 16 00:17:25 pi2 NR-Live2[16440]: 16 Apr 00:17:25 - [warn] [twitter] Error: Cannot find module 'request'
Apr 16 00:17:25 pi2 NR-Live2[16440]: 16 Apr 00:17:25 - [warn] ------------------------------------------
Apr 16 00:17:25 pi2 NR-Live2[16440]: 16 Apr 00:17:25 - [info] User directory : .nodered
Apr 16 00:17:25 pi2 NR-Live2[16440]: 16 Apr 00:17:25 - [info] Flows file : .nodered/flows_pi2.json
Apr 16 00:17:27 pi2 NR-Live2[16440]: 16 Apr 00:17:27 - [info] Starting flows
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:c67f9a9d.f73f58] repeat = 60000
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:ee17c8c9.3af858] repeat = 60000
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:f9b6b21.776805] repeat = 60000
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:5e86a8f6.46cdd8] repeat = 60000
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:F.Hall (03) Off 9am M-F] crontab = 00 9 * * 1,2,3,4
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:Landing (04) Off 9am Mo-Th] crontab = 00 9 * * 1,2,3,4
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:R Hall (02) Off 9am M-F] crontab = 00 9 * * 1,2,3,4
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:Tree (05) On 3pm Mo-Su] crontab = 00 15 * * *
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:Tree (05) On 1:12am Mo-Su] crontab = 12 01 * * *
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:F Hall (03) Off M-Su/1am] crontab = 00 01 * * *
Apr 16 00:17:29 pi2 NR-Live2[16440]: 16 Apr 00:17:29 - [info] [inject:R Hall (02) Off M-Su/1am] crontab = 00 01 * * *
Apr 16 00:17:30 pi2 NR-Live2[16440]: 16 Apr 00:17:30 - [info] [inject:Once an Hour] repeat = 3600000
Apr 16 00:17:31 pi2 NR-Live2[16440]: 16 Apr 00:17:31 - [info] Started flows
Apr 16 00:17:32 pi2 NR-Live2[16440]: 16 Apr 00:17:32 - [info] [rfx-lights-in:Listen to RFX: Lights] connecting to /dev/rfxtrx433e
Apr 16 00:17:32 pi2 NR-Live2[16440]: 16 Apr 00:17:32 - [info] serial port /dev/ttyAMA0 opened at 9600 baud 8N1
Apr 16 00:17:32 pi2 NR-Live2[16440]: 16 Apr 00:17:32 - [info] serial port /dev/arduino opened at 9600 baud 8N1
Apr 16 00:17:33 pi2 NR-Live2[16440]: 16 Apr 00:17:33 - [info] [mqtt-broker:3b2726f7.c4d8da] Connected to broker: Pi2_NR-Live@mqtt://localhost:1883
Apr 16 00:17:38 pi2 NR-Live2[16440]: 16 Apr 00:17:38 - [info] [rfx-lights-in:Listen to RFX: Lights] connected: Serial port /dev/rfxtrx433e

Is there a node-red-node-twitter/node_modules/request directory under the /usr/lib/node_modules/node-red/node_modules directory?

Sorry Dave, I can't tell now because I decided to wipe and rebuild all the modules. I removed node_modules and did a cache clear then a fresh install of all the modules. In doing so I found that the default npm was 1.4, I had an old version stuck somewhere. So I fixed that and rebuilt again. Now the Twitter error has gone away but I still cannot bring up the Admin UI.

Stop Node-RED, take a copy of ~/.node_red/.config.json, then delete it and restart Node-RED. If that works, please send me a copy of the original .config.json and a copy of the version after you restarted.

Sorry, did that, still the same problem.

Current and previous config files:
config.zip

Attached is an alternative red.min.js. Please could you drop that over the top of the one in your node-red install (node-red/public/red/red.min.js) and reload the editor. You'll still hit the error, but it will provide some additional debug in the browser console to help us understand what node-type is triggering the error.
red.min.js.zip

As seen in the google group, it was the alsql node causing the problems + my lack of attention letting that node come back into my config. Thanks for pointing it out.
Please also see the comments in the group on possible improvements to startup debugging and control though.


error mysql 8.0.20 bagisto v 1.1.2

This repository is only for reporting bugs or issues. If you need support, please use:

Create support ticket on https://bagisto.uvdesk.com

Thanks!

Hi @marcelowu
Kindly make sure that your database user has SUPER privileges on the database and triggers were created.

root and user

HI @marcelowu
They will have to SUPER privileges.

What's SUPER privileges?

i got this error using the php artisan migrate

CREATE DATABASE bagisto;
CREATE USER 'wpdbuser'@'localhost' IDENTIFIED BY 'new_password_here';
GRANT ALL ON bagisto.* TO 'wpdbuser'@'localhost' WITH GRANT OPTION;
Finally, save your changes and exit.
FLUSH PRIVILEGES;

how do you do SUPER privileges

CREATE DATABASE bagisto;
CREATE USER 'wpdbuser'@'localhost' IDENTIFIED BY 'new_password_here';
GRANT ALL ON bagisto.* TO 'wpdbuser'@'localhost' WITH GRANT OPTION;
FLUSH PRIVILEGES;

Whats migration result when using this user name and password, we also use the same way.

CREATE DATABASE bagisto;
CREATE USER 'wpdbuser'@'localhost' IDENTIFIED BY 'new_password_here';
GRANT ALL ON bagisto.* TO 'wpdbuser'@'localhost' WITH GRANT OPTION;
FLUSH PRIVILEGES;

Whats migration result when using this user name and password, we also use the same way.

CREATE DATABASE bagisto;
CREATE USER 'wpdbuser'@'localhost' IDENTIFIED BY 'new_password_here';
GRANT ALL ON bagisto.* TO 'wpdbuser'@'localhost' WITH GRANT OPTION;
FLUSH PRIVILEGES;

Whats migration result when using this user name and password, we also use the same way.

I tested it in the mysql version 5.7 I get the same thing

resolved..
sudo mysql -u root -p
set global log_bin_trust_function_creators=1;
FLUSH PRIVILEGES;
EXIT;


add security audit and provide info in README

@kenodressel @benhus as discussed

@hanssv do you mind providing a PR with your audit? :)

@hanssv do you mind providing a PR with your audit? :)

I think that was more a legal matter of how to incorporate this into the repo. I took an attempt back then for the multisig contract 😅
see https://github.com/aeternity/ga-multisig-contract/pull/23
but I would be happy to finally see this stuff published in the repos 🙏

Yeah, we've "sold" the report, so I don't feel 100% comfortable putting it here 🤔

the readme in general needs to be improved @kenodressel @bogdan-manole - there is absolutely no background info about anything instead of running the scripts


updates for lint/goreleaser/dependabot

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

updates for lint/goreleaser/dependabot
/assign @Issif

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c858c8a5f0b34195f81db2d6c35c9ace4d2f353c

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update beust-jcommander to version 2.0

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

Updates beust-jcommander to current upstream release. This required increasing the java version from 1.7 to 8 due to hard dependencies on java 8 language features.
Change Log

Affected packages: beust-jcommander
bumped package version

Does this affect the toolchain?

NO
Associated issues

N/A

Links to CVEs

N/A

Test Methodology

Local build

I have verified the License and reflected that change in my changelog entry. Still learning how this all works out, thanks for your patience.


[Setup] Clarify when to call setup.bat

For this URL:
https://wiki.ros.org/Installation/Windows
Please include a shortcut screenshot of the shortcut dialog which shows how to add setup.bat.

May I suggest to not use screenshots to show the content of a file?
The support guidelines (admittedly, for ROS Answers and Discourse) explicitly request to not use screenshots for anything that is text.
If "screenshot" here is meant to mean an actual image, then it might be good to just show the context of setup.batch with the appropriate formatting (ie: code block).

@gavanderhoorn Thank you for the feedback. We've had lots of support requests which boil down to not sourcing the setup.bat file.
Instead of a screen shot, perhaps we should change the document to delay creating the Windows shortcut until after ROS is installed?

I may have misunderstood this sentence:

Please include a shortcut screenshot to demonstrate what the setup.bat should look like.

If the intent is to just show a screenshot of the windows desktop with a screenshot, that would be completely fine.
If the intent is to show the contents of a file with a screenshot, then just copy-pasting the file contents would be preferable.

@gavanderhoorn Oh, thanks for the clarification. I edited the original comment. Since Windows is UI heavy, sometimes trying to describe what should go where is problematic. However, there are also issues with localization of screens, so I think some combination of reordering might be the best option anyway.

I reordered the getting started guide. Hopefully this is clearer about the setup.bat need.


Add bookinfo with VMs example

Adds an example project of deploying Istio/bookinfo/kiali on GCP. This is helpful in testing kiali with Istio deployments using WorkloadEntry or ServiceEntry.
Most of this large diff is due to the istio helm charts being directly imported/used in this project.

P.S. the branch this PR is from is not in your own private fork - after you merge, remember to delete that branch so we don't pollute the kiali repo with obsolete PR branches. (remember to avoid creating branches directly in the kiali repos)

P.S. the branch this PR is from is not in your own private fork - after you merge, remember to delete that branch so we don't pollute the kiali repo with obsolete PR branches. (remember to avoid creating branches directly in the kiali repos)

:man_facepalming: I'll re-open from my fork and delete this branch.


Add media type x-javascript and Typescript

I have an executable JS inscription it is similar to x-python from PR https://github.com/ordinals/ord/pull/2538.
Currently it doesn't display.
I think we should also add Typescript as well as x-typescript. I think a more generalized approach to deal with x-mediatype
if (language.startsWith("x-")) {
    language = language.substring(2);
}

The MIME type of javascript should be text/javascript. Typescript doesn't have an official MIME type and is normally transpiled to javascript anyways. An inscription that contains typescript can't be executed by the browser. Why do you want to inscribe typescript files?

I started exploring storing executable code as inscriptions for immutable storage. I haven't used the meta protocol tag but I imaged it would be DAPP. We added support for x-python which can't be run in the browser either. The explorer would be a good way to view the code as a digital artifact.
See this inscription that is a basic ord server and parser. Since its x-javascript it is only viewable in the /content route. Which is fine for distribution however not for viewablity.
https://ordinals.com/content/c5942064bea79672efc5d8331d84171ad2ebb086873e4eb24f7184b159702b87i0
Unfortunate TS isn't a mime type with bun you can run it without transpiling it I guess however that wont play nice with the code preview.
If this isn't in scope with ord I could just make a dedicated explorer that maybe uses autohighlight to cover executable code people might inscribe.


ProdREQ - Processes data to show 1-2 day predictions at XY accuraccy

ID: ProdREQ-03
Break down

Implements a ML model for prediction (Azure)
accuracy > 55%
Store predictions in DB

Notes
need:
ML techniques
MC techniques
Actions

[x] @NiaX84 prepare a MC that injects into real time series
[x] @mareklinka Azure machine learning - try to prepare in advance
[x] @mareklinka Azure ML did not pan out, replace with custom solution

To be done before or during the event

[x] before
[x] during

As I mentioned in #33 and #34, we are basically finished with the initial model. The last step is to deploy the docker image. I will talk to the ops guys on Monday but I don't see this as too complicated. I'm confident we will have this running early next week.

@mareklinka Great :)


Expose opacity control for a feature layer

allow an API to set opacity at the level of an individual layer

Added in PR #410.


Warn of limitation for CDN-managed certificates on apex domains

Explain that CDN-managed certificates are not supported for apex domains.
This explanation is the same as for https://learn.microsoft.com/en-us/azure/cdn/cdn-custom-ssl?tabs=option-1-default-enable-https-with-a-cdn-managed-certificate, but increased visibility on the docs for apex onboarding would have helped me avoid a CDN-managed certificate which ended up expiring(!) due to this limitation.

@duongau
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Run parallel speculations with reasonable resource limits.

Addresses https://github.com/PolymerLabs/arcs/issues/705
Seeking initial feedback on approach before adding tests.

see TODO I added around the async tracing, maybe it was already incorrect, or maybe we'd be better off adding a second Trace instance rather than continuing to fiddle the outer one in the inner async function, open to thoughts.
maybe there's a util already to chunk an array into groups? Also, @dstockwell would probably write it with yield and maybe I should have, too.
I just top-of-head sketched my thought in _speculativeThreadCount on how we could constrain based on cpu/memory, also, I'm not sure how/if this interacts with the number of workers we spin up. And I'm mostly winging it on 0.125 GB per thread, but, hey, it seemed a reasonable starting point based on my time glancing at Task Manager, is there a way to actually view a more accurate value?

I added a test, I'm going to merge this and work on the approach feedback in another patch, or let me know if that's crazy.


请问能否增强对中文的支持？

希望能更好的支持中文语义检索

引入，中文嵌入模型就可以了，例如：semantra --transformer-model shibing624/text2vec-base-chinese

“semantra --transformer-model shibing624/text2vec-base-chinese “

引入，中文嵌入模型就可以了，例如：semantra --transformer-model shibing624/text2vec-base-chinese ”filenames“（使用时去掉引号）

试过了，也试了large的模型，效果依然不是很理想。。。没关系，继续期待更好的

Would anyone be interested in contributing a guide written in Chinese on using Semantra with Chinese models?

I'm exploring different models. I will post some results here soon.

@cloudtuotuo @hiflychat 你们试过openai的ada 02吗？效果怎么样？

Would anyone be interested in contributing a guide written in Chinese on using Semantra with Chinese models?

Just translate README.md or write a new one like this (https://zhuanlan.zhihu.com/p/624842644) ?

我的本地机性能很普通（12代i7），显卡都是集成的，所以大型模型都没有尝试

我的本地机性能很普通（12代i7），显卡都是集成的，所以大型模型都没有尝试

了解。我昨天大概看了一下，现在中文还没有特别好的嵌入模型。E5最近可能会出一个多语言版本。到时候我争取部署一个和openai api兼容的服务。
@freedmand there’s no particularly strong Chinese embedding model yet. Existing models are probably unusable for semantra’s purposes.  E5 might release a multilingual version soon. Can you keep this issue open? I’ll keep following up here.

Sounds good, thanks for looking into it! Wow, multilingual E5 will be great!

It seems E5 quietly released the multilingual weights the same day we were talking about it.
https://huggingface.co/intfloat/multilingual-e5-base
will look into it and write up an update here.

Short update:
It works out-of-the-box with semantra --transformer-model intfloat/multilingual-e5-base [files] and the querying results are reasonably well with the file I tested (see below for a few examples).
Speed might be a drawback. A 63-page Chinese document took just about 1 minute to embed in Debian via OrbStack on M1 Pro. But I think it's a workable solution for most users.
<img width="682" alt="Screenshot 2023-05-24 at 16 44 13" src="https://github.com/freedmand/semantra/assets/43839115/f2325a16-0

228-4da3-97e5-e4dba4839250">

简短更新： 使用 semantra --transformer-model intfloat/multilingual-e5-base [文件]，它可以开箱即用，并且我测试的文件查询结果相当不错（如下面的一些示例所示）。
速度可能是一个缺点。在 M1 Pro 的 OrbStack 上，一份 63 页的中文文件在 Debian 中嵌入大约需要 1 分钟。但我认为这对大多数用户来说是一个可行的解决方案。
Short update: It works out-of-the-box with semantra --transformer-model intfloat/multilingual-e5-base [files] and the querying results are reasonably well with the file I tested (see below for a few examples). 它开箱即用，查询结果与我测试的文件相当好（见下面的几个例子）。
Speed might be a drawback. A 63-page Chinese document took just about 1 minute to embed in Debian via OrbStack on M1 Pro. But I think it's a workable solution for most users.速度可能是一个缺点。通过 M1 Pro 上的 OrbStack 将一份 63 页的中文文档仅用了大约 1 分钟的时间嵌入到 Debian 中。但我认为这对大多数用户来说是一个可行的解决方案。

感谢，使用该模型后，效果的确可以

@freedmand Since e5 seems to work well, I will add a Chinese guide to semantra. I'm thinking about just translating the readme.md. Do you think there's something else I should translate? You can remove the help wanted tag from this issue and assign it to me!
Also, I would love to contribute to v0.2. Are you planning to set up something like a Slack channel for contributors? I can help with that too. Or I can just create an issue and tag you to assign it to me 😄

Thanks, @yych42! I really appreciate all the help on this. Translating the README.md would be fantastic. I was originally thinking a separate guide document would be easier showcasing good settings for running Semantra in Chinese, but README is great if it's not too heavy a lift.
For v0.2, I'm in a pretty exploratory phase at the moment. I think a lot of Semantra will have to be rebuilt, but in a way that's much more modular, maintainable, testable, etc. I'm close to being ready for help and contributions. I'll probably set up a feature branch soon once I've nailed down a few things on the strucutre. I haven't thought about a channel for contributors but that's a really good idea! I'll look into setting something up this weekend.

semantra --transformer-model intfloat/multilingual-e5-base [files]

@yych42 没用过hf的模型，请问这条命令的[files]要替换成什么？

semantra --transformer-model intfloat/multilingual-e5-base [files]

@yych42 没用过hf的模型，请问这条命令的[files]要替换成什么？

单个或者多个文件的本地地址，或者某个目录+通配符
比如
semantra --transformer-model intfloat/multilingual-e5-base /users/yych/desktop/some.pdf /users/yych/downloads/another.pdf
或者
semantra --transformer-model intfloat/multilingual-e5-base /users/yych/documents/*.txt


Add activestorage signatures

Added signature for activestorage v6.0.
APIs that are likely to be used in practice have been added.
There are no changes on the activerecord side, and ActiveRecord::Base is extended only when the signature of activestorage is read.
The reason why I changed the way to divide the files into rb files is because I consider it easier to find the files and to investigate the differences between versions.

Thank you for reviewing.
I applied your suggestion code.


Kubeconfig file reference is not helpful

In the Quickstart under prereqs, this line is not helpful: A kubeconfig file and context pointing to your cluster.
For a beginner walking through the Quickstart, I don't know where to go, how to update this, or what the format should look like. It would be useful to have a step-by-step or example of what this should look like.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df16df9a-a855-2512-5e26-baec15e3be88
Version Independent ID: c77f255b-57c9-7e2d-2b10-98a8fe538376
Content: Quickstart: Connect an existing Kubernetes cluster to Azure Arc - Azure Arc
Content Source: articles/azure-arc/kubernetes/quickstart-connect-cluster.md
Service: azure-arc
Sub-service: azure-arc-kubernetes
GitHub Login: @JnHs
Microsoft Alias: jenhayes

@wayneme75 Thanks for the feedback.
Assigning to @JnHs for visibility, review and document enhancement consideration as appropriate.

Hi @wayneme75 - A kubeconfig file holds the context to access a Kubernetes cluster. This file is sometimes created by default, depending on how the cluster was provisioned. See https://kubernetes.io/docs/concepts/configuration/organize-cluster-access-kubeconfig/ for more info. I'll plan to add a link to this into the doc, and then I'll close this GitHub Issue unless you still have questions - if so please let me know.

Thank you @JnHs . adding the link is good, I think there is value in perhaps giving an example of the kubeconfig file so that the reader has some expectation of what should be in the file.

@wayneme75 I've updated the prerequisites so will close this issue now. More details on the kubeconfig file is outside of the scope of this quickstart (since it's not specific to Azure Arc scenarios) but the link should be helpful. Thanks again for taking the time to share your feedback.
#please-close


addimage always timeout , used the local http server

AddImage name=VIRTUAL-ROUTER format=qcow2 mediaType=RootVolumeTemplate platform=Linux url=http://<IP_ADDRESS>:8089/zstack-virtualrouter-0.9.0.qcow2 backupStorageUuids=9b574c3a7287468d81b7c13cb29b4378
API call[org.zstack.header.image.APIAddImageEvent] failed because [code: SYS.1002, description: Unable to create a resource, details: Failed to download image[name:VIRTUAL-ROUTER] on all backup storage[9b574c3a7287468d81b7c13cb29b4378].
error code for backup storage[uuid:9b574c3a7287468d81b7c13cb29b4378]: ErrorCode [code = SYS.1001, description = A message or a operation timeout, details = Message[org.zstack.header.storage.backup.DownloadImageMsg] timeout after 1800 seconds]]
API call[org.zstack.header.image.APIAddImageEvent] failed because [code: SYS.1002, description: Unable to create a resource, details: Failed to download image[name:VIRTUAL-ROUTER] on all backup storage[9b574c3a7287468d81b7c13cb29b4378].
error code for backup storage[uuid:9b574c3a7287468d81b7c13cb29b4378]: ErrorCode [code = SYS.1001, description = A message or a operation timeout, details = Message[org.zstack.header.storage.backup.DownloadImageMsg] timeout after 1800 seconds]]

I used the local http server and addimage image-ttylinux succeed , but when addimage(zstack-virtualrouter-0.9.0.qcow2), it always timeout failed , I test write on the backupStorage, it's ok.
why set the timeout is 1800s?
how can avoid this problem? thank you

On Thu, Nov 19, 2015 at 4:20 PM, cenxinxing<EMAIL_ADDRESS>wrote:

http://<IP_ADDRESS>:8089/zstack-virtualrouter-0.9.0.qcow2

It shouldn't be slow, if you put it in local http server.
Can you try to run "wget
http://<IP_ADDRESS>:8089/zstack-virtualrouter-0.9.0.qcow2" in backstorage
server?
--
Yongkang You

The problem is solved.
just restart the local http server like nginxl.
thank you

why you don't support the local image when addimage.
like file=/home/xxx.qcow2

Will support in  1.0. ;)
On Fri, Nov 20, 2015 at 11:09 AM, cenxinxing<EMAIL_ADDRESS>wrote:

why you don't support the local image when addimage.
like file=/home/xxx.qcow2
—
Reply to this email directly or view it on GitHub
https://github.com/zstackorg/zstack/issues/154#issuecomment-158266278.

--
Yongkang You

when i add the secend Backup Storage,  it was failed. what is the mean?
the path which i add to Backup Storage is a dir with ext3 .
REQUEST
{
"org.zstack.storage.backup.sftp.APIAddSftpBackupStorageMsg": {
"hostname": "<IP_ADDRESS>",
"username": "root",
"password": "root",
"type": "SftpBackupStorage",
"resourceUuid": "01153b288b214d41a76b7521e9ab3052",
"name": "BACKUP-STORAGE2",
"description": null,
"url": "/home/BACKUP-STORAGE2/aa",
"session": {
"uuid": "982ac4c8d723463783ee52b2d7c92220"
}
}
}
RESPONSE
{
"org.zstack.header.message.APIEvent": {
"success": false,
"apiId": "3e630b76cacd45f29eb13b0ad8773e71",
"headers": {
"schema": {}
},
"error": {
"code": "SYS.1007",
"description": "One or more API argument is invalid",
"details": "existing SimpleHttpBackupStorage with hostname[<IP_ADDRESS>] found"
},
"id": "6e9f4f1a1eb44beeb6e94fa427126e9b",
"creatingTime":<PHONE_NUMBER>639
}
}

the dir which add to  Backup Storage must support nfs?

The same backup storage server can not be added twice.
SimpleHttpBackupStorage with hostname[<IP_ADDRESS>] found
On Fri, Nov 20, 2015 at 11:36 AM, cenxinxing<EMAIL_ADDRESS>wrote:

the dir which add to Backup Storage must support nfs?
—
Reply to this email directly or view it on GitHub
https://github.com/zstackorg/zstack/issues/154#issuecomment-158269656.

--
Yongkang You


Automate Point Release process

There's already a script. The todo here is:

Configure travis to be able to run the script

Mostly this is setting up credentials for:

AWS keys (for uploading the deb package to the corp site)
dockerhub keys (to upload the images)
GH keys (to tag / do other modifications)

Provide a 'button' for any internal dev to kickoff the release process

Probably the easiest thing would be to tag a commit, e.g. 'do_a_point_release'
Then travis detects the tag, validates the user has the rights to do the release, and performs the release

But I'm open to other ideas for a 'button' if something else seems like it makes more sense

We also got a PR for submitting our brew formula's to the core tap:
https://github.com/pachyderm/pachyderm/issues/598
And if we're overhauling releasing, it would be a good time to look at supporting the other changes needed for that PR

The script we have now is good enough. And now I think most of the team has used it to push. So I'm closing this.


fix overflow in FileInput file's name

on small screens, when the file name was too long, it would overflow instead of break into next line
before:

after:

Hi, thank you for the PR. I merged it and added the same class to the wind preset. We will have a release this week🌟


Get Verified

I would not consider this a high priority but wanted to suggest making this a "Verified" plugin.

Good idea! I submitted the plugin for review: https://github.com/homebridge/verified/issues/57

Verified :)


[PbЁS2 problem] Broken firefox module

it seems that the structure of asn1, which is used to store the master password, has changed
Working on a fix
Broken structure: link

Okay, guys, the problem was a lot harder to solve.
More info can be read here https://github.com/louisabraham/ffpass/issues/49#issuecomment-586023952.
TL;DR;
FF is now using pbes2 to encode your passwords instead of pbeWithSha1AndTripleDES-CBC

@kerbyj do you want to work together on a fix?


Font styles not being applied (or, I'm doing it wrong :D)

Hey there, thank you for this awesome library! We are using it and it's great.
I'm having one issue though, while trying to change the fontFamily of the text portions of the <PINCode />:
const primaryFont = 'Avenir-Book';
const fontWeight = '400';

<PINCode
  colorPassword={CommonUtils.uiColors.success}
  numbersButtonOverlayColor={CommonUtils.uiColors.success}
  styleMainContainer={{
    backgroundColor: 'white',
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center'
  }}
  styleLockScreenText={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  styleLockScreenTextButton={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  styleLockScreenTextTimer={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  stylePinCodeViewTitle={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  stylePinCodeTextButtonCircle={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  stylePinCodeTextTitle={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  stylePinCodeTextSubtitle={{
    fontFamily: primaryFont,
    fontWeight: fontWeight
  }}
  storedPin={this.props.pin}
  maxAttempts={3}
  textButtonLockedPage="Log In with email/password"
/>

None of these seem to be taking effect, am I doing this incorrectly? Thank you!

Hi :).
Thanks for the feedback.
I tried to reproduce your bug but managed to change the font.
I tried using a bold font and a font size:
        <PINCode
          status={'enter'}
          colorPassword={colors.valid}
          numbersButtonOverlayColor={colors.valid}
          styleMainContainer={{
            backgroundColor: 'white',
            flex: 1,
            justifyContent: 'center',
            alignItems: 'center'
          }}
          stylePinCodeTextTitle={{
            fontFamily: 'Roboto-Bold',
            fontSize: 20
          }}
          storedPin={'1234'}
          maxAttempts={3}
          textButtonLockedPage="Log In with email/password"
        />

and a font weight:
        <PINCode
          status={'enter'}
          colorPassword={colors.valid}
          numbersButtonOverlayColor={colors.valid}
          styleMainContainer={{
            backgroundColor: 'white',
            flex: 1,
            justifyContent: 'center',
            alignItems: 'center'
          }}
          stylePinCodeTextTitle={{
            fontFamily: 'courier',
            fontWeight: '800'
          }}
          storedPin={'1234'}
          maxAttempts={3}
          textButtonLockedPage="Log In with email/password"
        />

and both worked.
If you're using a font with fixed weight (like the roboto one I'm using), trying to change the weight won't do anything. Maybe it can be related to your issue?
If not, I really don't know what to do...I'll try testing again with different fonts.
Cheers :)


Update sbt-github-actions to 0.14.2

Updates com.codecommit:sbt-github-actions from 0.13.0 to 0.14.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.codecommit", artifactId = "sbt-github-actions" } ]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor

The direct dependency on this plugin has been removed in https://github.com/circe/circe-config/pull/361.


Workspaces change order on application window updates.

I originally searched for this issue and commented on #1785. These issues are probably related but I am not using any additional monitors personally, so I figured I would open a new issue with more info.
I am running:
Mac OS Monterery 12.6 (Intel)
yabai-v5.0.4
skhd-v0.3.7
spacebar-v1.4.0
It seems this issue is reproducible by having an application open a new window or update a window, that is in a separate workspace. For example, I open GIMP in workspace 5. I move to workspace 1 and go to finder, then open an image from finder in GIMP. The GIMP program will suddenly be sitting in workspace 2 with a new tab for the image I opened. My other workspaces are shifted to 3+ and/or jumbled. Very aggravating to workflow. Teams application also causes these problems, and I believe I have experienced this with Excel.

Hah, of course. After posting this I had an idea that it might be Mac OS changing workspaces around under yabai's nose. Seems this is true.
Go to System Preferences > Mission Control. Uncheck "Automatically rearragange Spaces based on recent use". Just tested this with GIMP and it seems to be working


read: add Object::relative_address_base

Fixes #314

Looks good!

I forgot to make the PE addresses consistent, so I've done that now. I decided it would be less of a breaking change to keep ObjectSymbol::address absolute, so the others have changed to that. I'll do a bit more validation of this with mingw too though.


refactor: remove slidetoggle component

BREAKING CHANGE:
The SlideToggle has been removed and is no longer available for use.

Testing

Trade-offs

Dependencies

Screenshots

Checklist for PR creator

[ ] If any new components were added, there are exported from packages/index.ts
[ ] If this PR is associated with a JIRA, it is mentioned in commit message footer ("Closes …")
[ ] If this PR contains breaking changes, is stated in commit message body ("BREAKING CHANGE: …")
[x] Info for applicable sections above is provided

@nataliepina can we create a release branch for version 12 and try and batch a bunch of our breaking changes together? I am guessing there will be several in quick succession.

I've created a release-next branch for our next major release and set this branch to merge into it 👍


Add a parameter to control whether an ipa automount should be cached

In order to actually make use of cachefilesd, autmount mappings must include the fsc option. This PR adds the fsc option where appropriate based on the value of a parameter called cached.

This automount-maps config currently does not work and is not applied. Cf. main.yml#L34
But the idea is good anyway. Thanks!


ERROR Frame Data as String byte[] in UTF-8

We need the ability to convert an ERROR to a message readable by humans ... such as an Exception in Java. Thus, the byte[] being sent in an ERROR frame needs to be String bytes so it can be turned back into a String.
This means we must also define the encoding type: UTF-8
Why not support the MimeType encoding for ERROR?
a) because the error could have been caused by the encoder trying to encode into the MimeType
b) because the thing processing the error may have no knowledge of the MimeType or processor
c) because this would require a consistent MimeType to always deliver the error in the same way, which goes against the principle of allowing the MimeType to be defined by the application tier.

Will update the spec to reflect this.


Export Data Package

Desired Behaviour
Export a data package as described at https://relishapp.com/odi-australia/data-curator/docs/tools/export-data-package

Released in v0.5.0


Remove a mixin from RenderListWheelViewport that was never used

Gentle ping

Sorry about the delay. This looks reasonable to me.
LGTM


A working Matter docker container in a macvlan network, am I in for trouble later?

Have spent the last day+ getting my first Matter device working, a Nuki Smart Lock Pro 4.0.  I don't run any other containers with network_mode=host so wanted to avoid it.
My HA is a docker container with a macvlan network attached.  I found this repo quickly whilst reading the docs on how to setup Matter.  My container host is an unraid server which has net.ipv6.conf.iface.forwarding=1 by default which I left unchanged.  I updated .accept_ra=2 and .accept_ra_rt_info_max_plen=64 as per the readme here and a few other posts and articles I found.  My Thread network is running off a Google Nest Hub, I made sure HA knew about this and that HA, Matter and the Nest Hub are all in the same IPv4 subnet.  After the changes mentioned my unraid server saw an IPv6 route via my Google Nest Hub which I took as a positive sign.
On the Matter container side I made the same changes as per the host but additionally I set net.ipv6.conf.eth0.forwarding=1.  This then enabled my Matter container to successfully establish a secure connection to the Nuki lock and complete provisioning directly into HA.  I can sometimes take some minutes for the routes to fully populate, think my worst case was 15 minutes or typically its much quicker.
Given I haven't found any other reference to this, coulped with my lack of experience with IPv6 networking and Matter in general I'm concerned that whilst everything seems stable and functional that I may have issues in the future.  I'd appreicate any critique of my solution here to better educate me as necessary.
  matter:
    container_name: matter
    hostname: matter
    restart: unless-stopped
    networks:
      mynetwork:
        ipv4_address: <IP_ADDRESS>
    volumes:
      - /etc/localtime:/etc/localtime:ro
      - /mnt/cache/docker/infrastructure_apps/matter/data:/data
    healthcheck:
      test: ["CMD", "curl", "-f", "http://healthchecks.mylocaldomain:8015/ping/bebed870-47c2-4957-bb84-1e78d11ae838"]
      interval: 1m
      timeout: 5s
      retries: 3
      start_period: 30s
    sysctls:    # Necessary for the container to receive the routes from the remote Thread network managed by my Google Nest Hub.
      net.ipv6.conf.eth0.accept_ra: 2
      net.ipv6.conf.eth0.accept_ra_rt_info_max_plen: 64
      net.ipv6.conf.eth0.forwarding: 1
    image: ghcr.io/home-assistant-libs/python-matter-server:stable

Running Matter server in docker is unsupported and completely at your own risk. We provide a docker image just to be helpul for those willing to take the plunge to make it working but we do not provide any support here, sorry.


P0722R3 Efficient sized delete for variable sized classes

https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0722r3.html

destroying_delete_t


Landing page sidebar updates

Added

Multiple categories of links to the sidebar
New links and copy coming from /mortgages page
Document download icon to PDFs (since the PDF icon has been deemed not-accessible)

Removed

Arrows from links in sidebar—they were giving them too much emphasis, and arrows on links is an unresolved issue right now (rules aren't totally defined, some people arguing for no arrows at all, some for using to create emphasis)

Changed

Description for "Know the process" to @mthibos' latest update

Screenshots

Notes

One weird thing I noticed was that the links in the middle of the page are Regular, and the links in the sidebar are Medium. I think we'd want the links in the middle of the page to also be Medium. (Similarly to the arrows issue, the font weight of links is not totally resolved yet. It seems like the decision will end up being Regular for links in paragraphs, Medium for links outside of paragraphs, but that hasn't been stamped as a "final" decision yet, and hasn't been incorporated into the design manual or capital framework.)
Other weird thing: Lack of space between download icon and link text in main body. I don't know why this is happening in the main body of the page, but not in that sidebar link. Dev help appreciated.

Review
@sonnakim for link accuracy + copy
@virginiacc or @cfarm

I don't think I can review these. I can only access build right now. My dev environment's not ready for prime time!

Okay! Maybe you can double-check the copy in the screenshots, then check the actual links once they're merged on build?

One copy tweak
For the fifth link, can we make it "the CFPB"?
"Learn how the CFPB is protecting mortgage borrowers"
One formatting tweak
In the resources section, can we include a line break before each link?

With line breaks (yay!)
Without (boo)

@stephanieosan The links that are Medium weight are jump-links which makes them easier to tap on touch and small screens.
Can you include some small and medium screen width screenshots too?

Incorporated your feedback, @sonnakim!
Mobile screenshots

We probably want those "Key tools" links to be jump links so that they have the appropriate mobile style. Do I just add that class? Are there any classes I need to remove?
Medium, tablet-ish screenshots

Sweet—thanks @stephanieosan!

These link changes will also require updating the browser tests, FYI - let me know if you want help with that.

Yes, I definitely don't know how to do that yet!

Okay, so I fixed the weird download icon spacing issue with well-placed nonbreaking spaces. I turned all of the main body links into jump links so that they'd be Medium instead of Regular weight and be more mobile-friendly.
Still working on updating the browser tests, but in the mean time...I found another css issue.
Our lists of links were looking pretty janky on mobile:

What they look like (boo)
What want them to look like (yay!)

So, I realized list_link is there to make your lists of links stack nicely on mobile, but it's not activated unless you have list__links as a class for your ul. Which, is easy enough to do, but that also happens to affect the way the links look on desktop, making the spacing too tight.

What they currently look like (yay!)
What they'd look like if I added list__links (boo)

Should we make some kind of css override so that we can get the nice mobile list properties without the too-tight desktop spacing?

@stephanieosan  you are turning into such a developer!
Also, for my knowledge, what do y'all mean by "jumplinks"?  Because you don't seem to mean /#something, which is the only definition I know for the term.

Yes, the terminology is confusing in this case.
"jump-link" is what the flapjack devs have named one of the common css classes for links. That class creates a fancy mobile link with dotted lines above and below.
The thing you know as "jumplink" (/#something) should probably be referred to as "anchor link", to ease confusion.
(Apparently this mix-up is why everyone was giving you blank stares in sprint planning earlier!)

Also, note to self: we are still missing the URL for the realtors pages, so I will need to:

[ ] Add link and updated corresponding browser test

Once we hear back from the Design Ops crew. Thanks for emailing them, @sonnakim !

@stephanieosan
Well that is mighty confusing of the flapjack devs, isn't it.  :confounded:

I've removed the realtors link for now, as discussed in scrum, and updated the browser tests accordingly. This is ready for review!

Travis build failed because of this commit https://github.com/amymok/owning-a-home/commit/35746b43b622b5e38ae4ab01f0d93b3a45b8f1f4
As noted, all tests passed.
Everything should be fine after https://github.com/cfpb/owning-a-home/pull/490 is merged in.

@stephanieosan I think for the link spacing issue we could add a rule so that when you use .list__links and .list__spaced together, the list items get the increased margin value on desktop.
It looks like there's already an entry for .list__links.list__spaced in the index.less file -- we can add this list_item rule to it:
.list__links.list__spaced {
  .list_item {
      .respond-to-min(@tablet-min, {
        margin-bottom: unit(24px / @base-font-size-px, em)
      });
  }
}

Okay, I updated the less file and added all the appropriate classes. Check it out!

Looks awesome! :+1:


Windows builds

Any possibility of getting windows support for the Pulsar python package?
I've tried building it localy and got pretty far, but ran into issues with matching the python version between boost-python and pulsar-client-python, which I've been unable to resolve.
The C++ client itself builds fine on windows, so I don't think there should be any serious blockers for this?

I don't think there should be any serious blockers

Actually yes. The CMakeLists.txt needs some fixes. I was working on this issue a few days ago and will continue the fix after backing to work. The core issue is about the static linking.
Here is my working branch: https://github.com/BewareMyPower/pulsar/commits/bewaremypower/cpp-static-link. Please note that it doesn't work currently (I forgot to push latest commits in my Windows laptop).

The binary suffix should be .pyd on Windows (in my branch it's .dll, which is wrong)
The Python library should not be linked statically when building _pulsar.pyd.


[✨] Qwik City: navigating to current/same url using <Link> should got to top of the page.

Is your feature request related to a problem?
No
Describe the solution you'd like
navigating to current/same url using <Link> should got to top of the page.
Describe alternatives you've considered
I can add a logic in main layout to check if url is the same. But would be nice to have this on Qwik City by default.
Additional context
No response

@Varixo is it implemented in v2?


Make Transform class

A transform holds the position and scale of an object, and maybe more.
Estimated time: 30 m.

Fixed by 8b7c94d.


Add team information to AboutUs.md

Rebased doc-aboutus branch to master branch.

Same applies to all other team files actually; see https://raw.githubusercontent.com/AY2122S1-CS2103-W14-2/tp/master/docs/team/johndoe.md which had the correct metadata.


Done adding Catch with return of Promise

Hi @RoryDungan!
Since the Promises/A+ spec is pretty hard to read, I'll pose the question: am I right in assuming that this feature is actually required, as per the combination of point <IP_ADDRESS> and 2.3.2, to be Promises/A+-compatible?
It's something I've noticed we actually need in one of our projects, so if this is actually the case, I'm willing to work on this pull request if you can tell me what needs to be done - aside from making it mergeable - to get it approved and added to the library.
(As an aside, many thanks for all the hard work on this library, it has helped us out a lot!)

Hey, sorry letting this branch go stale for so long. Reading through the A+ guide it I agree it would seem like this is needed. I just tested and this functionality does work in standard JS promises so would definitely be good to have.
I think in terms of getting this ready to merge again, there are a few things that would need to be done:

There's a merge conflict that would need to be resolved
The implementation is only for the generic promise, but would need to be done for the non-generic one too.
Two tests have been added but none of them actually test that the promise returned by Catch is getting executed or that the value returned from the promise returned by catch is passed to the next Then. I've made some comments on the code explaining this in more detail.

I've started to work on it a bit in my own fork, but I have a judgment call to make and I wanted to ask you for your opinion.
If we add an overload for Catch, some existing code will become ambiguous. For example:
promise.Catch(e => throw new Exception("This shouldn't happen"));
can no longer be resolved, since - because the return type needs to be implied since there is no return in the throw-only body - both Catch(Func<Exception, IPromise<PromisedT>> onRejected) and Catch(Func<Exception, PromisedT> onRejected) would suffice - and thus the code won't compile anymore, making this a backwards-incompatible change.
OTOH, I could add it as a method with a signature like public IPromise<PromisedT> Recover(Func<Exception, PromisedT> recoveryHandler) and the change would be backwards-compatible, but there would be another method added and the user would need to know just a bit more about how the library is supposed to be used again.
How do you feel about this?

Since (I think) I have no way of updating this pull request, see #109 for a new version of the code that should be mergeable and fixes the aforementioned issues.


Added setting for calculating offer discounts over the price including tax.

This makes offers including tax accessible.
The incl_tax parameter used to be hardcoded to False in apply_discount. ?
In creating the tests for this thing, I found the current calculation, over
the price excluding tax to be incorrect. I added the test and
marked it as skipped.

@specialunderwear I don't know what lint errors you are getting, but suggest you ignore the ones from Codacy, as it is currently using daft rules. As long as the Travis lint build passes you're fine.
I would also add that this sort of change will need documentation.

Please have a look at the skipped test I added. I don't know if you want me to fix these issues in this PR as that would change the behaviour of the way discounts work now. I do need them fixed though ...

I would write documentation, but it would be very hard to describe what oscar does with OSCAR_OFFERS_INCL_TAX=False (this is the current default settings). So I could describe what I think it SHOULD do, but the tests show there are some issues there.

Yeah, it looks like there are several issues with the offer logic which need to be fixed. If you have time to dig into this particular tax-related issue that would be great. Oscar 2 is going to be making various breaking changes, so now is a good time to change behaviour if it needs changing.

Ok I will add that to this PR and make the tests pass.

@solarissmoke I made the skipped test pass. Some more accuracy could be gained by not computing _tax_ratio and instead storing it on purchase_info, but let's start here.


Sentinel-1 list task error for first half of 2022 in some locations

When trying to run the SpaceEye workflow for a location near Esperance in Western Australia (bounding box centre point: 121.4734,-33.19117 ), I encountered the following error, terminating the workflow.
This error did not occur when providing a date range of 2022-3-1 to 2022-12-31, though this only returned SpaceEye outputs for 2022-8-1 onwards.
The error seems to occur only when a date range fully contained by March and August of 2022 is specified at this tile.
'preprocess.s1.list': RunDetails(start_time=datetime.datetime(2023, 2, 15, 3, 27, 13, 915573), submission_time=datetime.datetime(2023, 2, 15, 3, 27, 13, 770448), end_time=datetime.datetime(2023, 2, 15, 3, 27, 26, 732284), reason='RuntimeError: Received unsupported message header=MessageHeader(type=<MessageType.error: \'error\'>, run_id=UUID(\'9dd85457-e49e-44c5-b9bf-7fa995c25d9c\'), id=\'00-9dd85457e49e44c5b9bf7fa995c25d9c-f1305ea3e004f272-01\', parent_id=\'00-9dd85457e49e44c5b9bf7fa995c25d9c-bba3b24cf8250e46-01\', version=\'1.0\', created_at=datetime.datetime(2023, 2, 15, 3, 27, 26, 702399)) content=ErrorContent(status=<OpStatusType.failed: \'failed\'>, ename="<class \'RuntimeError\'>", evalue=\'Traceback (most recent call last):\
  File "/opt/conda/lib/python3.8/site-packages/vibe_agent/worker.py", line 121, in run_op\
    return factory.build(spec).run(input)\
  File "/opt/conda/lib/python3.8/site-packages/vibe_agent/ops.py", line 111, in run\
    stac_results = self._call_validate_op(**{**items, **raw_items})\
  File "/opt/conda/lib/python3.8/site-packages/vibe_agent/ops.py", line 75, in _call_validate_op\
    results = self.callback(**kwargs)\
  File "/app/ops/list_sentinel1_products/list_sentinel1_products_pc.py", line 28, in list_sentinel1_products\
    raise RuntimeError(\
RuntimeError: No product found for time range (datetime.datetime(2022, 4, 1, 0, 0, tzinfo=datetime.timezone.utc), datetime.datetime(2022, 6, 30, 0, 0, tzinfo=datetime.timezone.utc)) and 35 geometries\
\', traceback=[\'  File "/opt/conda/lib/python3.8/site-packages/vibe_agent/worker.py", line 306, in run_op_from_message\
    out = self.run_op_with_retry(content, message.run_id)\
\', \'  File "/opt/conda/lib/python3.8/site-packages/vibe_agent/worker.py", line 404, in run_op_with_retry\
    raise RuntimeError("".join(ret.format()))\
\']). Aborting execution.', status='failed'),

Hi @NicholasBerryman, this error indicates that there is not Sentinel-1 data available for this time range. I just checked the Planetary Computer API and we only have products for the following dates:
[datetime.datetime(2022, 12, 21, 10, 35, 9, 711619, tzinfo=tzutc()),
 datetime.datetime(2022, 12, 2, 10, 43, 18, 4437, tzinfo=tzutc()),
 datetime.datetime(2022, 11, 8, 10, 43, 18, 241944, tzinfo=tzutc()),
 datetime.datetime(2022, 10, 27, 10, 43, 18, 820429, tzinfo=tzutc()),
 datetime.datetime(2022, 10, 15, 10, 43, 19, 63514, tzinfo=tzutc()),
 datetime.datetime(2022, 10, 3, 10, 43, 18, 648094, tzinfo=tzutc()),
 datetime.datetime(2022, 9, 28, 10, 35, 11, 753346, tzinfo=tzutc()),
 datetime.datetime(2022, 9, 16, 10, 35, 11, 421601, tzinfo=tzutc()),
 datetime.datetime(2022, 8, 16, 10, 43, 17, 485506, tzinfo=tzutc())]`

I also checked the response from ESA's Scihub API and there were similar dates (from middle of August onwards), so I don't think it's an issue with Planetary Computer specifically.
I wonder if this is related to the issue with Sentinel-1B (which now out of commission). Now that the constellation only has one satellite, the capture regions and revisit rates were changed, see this link for some information about it https://sentinel.esa.int/web/sentinel/missions/sentinel-1/observation-scenario.
This is the previous coverage and revisit rate map

This is the new one

Regardless, it seems like there is no Sentinel-1 data for that region in that time range, so there isn't much we can do about that. As an alternative, you could try the interpolation-based SpaceEye workflow, which only uses Sentinel-2 data. Let me know if there is something else I can do for you.

Thanks for the explanation. I hadn't realised that coverage was affected by the Sentinel-1b outage, not just frequency.


[BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

What is the purpose of the change
This reverts commit 0cf9c2846ad1b293b91059d172dd68dd0ffbf803.

Manually merged via 7a87aa415ef7a3cf6d2845e0e9fe5f4b8234503f


Issue17 jet data reader

@bubibubi We can't verify that this is indeed an issue in EF Core. Please provide tests that would fail without this fix. Thanks!

@lauxjpn probably just close. This issue is from 4 years ago and probably ef core 2 or 3. Might already be fixed a different way

@bubibubi Feel free to provide a test that fails without this PR. We will reopen this PR then.


Add border collapse default styles and utilities

Adds border-collapse: collapse as a default table style in Preflight
Add new border-collapse and border-separate utilities

If you'd like to PR docs for this too that would be 👌


[EFR32] Fix/matter support pointer update

Update the submodule reference to the main branch with latest commit
Tested locally and verified

@Thirsrin it seems this needs conflict resolution.


[Feature][Module Name] Some suggestions on password setting

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Add strong password verification during user password setting, and prompt strong password rules for the set weak password, such as the minimum length of 8 digits, and the character types include lowercase letters, uppercase letters, numbers, special characters, etc
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi:

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to<EMAIL_ADDRESS>

Hi：
Version：1.3.9
There are 3 places to change the password，The password can be set to any value without strong password verification ：

admin set password
admin change user password
user change password


fix: tweak severity of some sonarjs rules

the following rules now error out:

sonarjs/no-clear-text-protocols
sonarjs/no-misused-promises
sonarjs/different-types-comparison

and the following will throw a warning:

sonarjs/no-nested-functions (with a nesting threshhold of 5)

and added comments explaining why other rules have been turned off

Merging to pull in today's work


Validation based on other field's value

I have a form where n fields are only required if one other field is true. I basically need this from laravel required_if.
If you fill out the form without checking the checkbox, the field should only validate the fields that are not dependant on the checkbox value.
If you fill out the form with checking the checkbox, the field should validate all the fields.
What I tried so far
I tried adding my own RequiredIfValidator class:
class RequiredIfValidator extends Validator<dynamic> {
  const RequiredIfValidator(
    this.requiredIfControlName,
    this.condition,
  ) : super();

  final String requiredIfControlName;

  final bool Function() condition;

  static const String requiredIf = 'requiredIf';

  @override
  Map<String, dynamic>? validate(AbstractControl<dynamic> control) {
    if (control is! FormGroup) {
      // Maybe throw an exception is better
      return <String, dynamic>{RequiredIfValidator.requiredIf: true};
    }

    final requiredIfControl = control.control(requiredIfControlName);
    final error = {
      ValidationMessage.compare: <String, dynamic>{
        'requiredIfControl': requiredIfControl.value,
        'condition': condition,
      }
    };

    if (requiredIfControl.value == condition()) {
      requiredIfControl.removeError(RequiredIfValidator.requiredIf);
    } else {
      requiredIfControl.setErrors(error);
      requiredIfControl.markAsTouched();
    }

    return null;
  }
}

class CustomValidators {
  static Validator<dynamic> requiredIf(
      String requiredIfControlName,
      bool Function() condition,
      ) {
    return RequiredIfValidator(requiredIfControlName, condition);
  }
}

And then in your form:
FormGroup buildForm() => fb.group(<String, Object>{
  'a': FormControl<bool>(
    value: false,
  ),
  'b': FormControl<String>(
    validators: [
      Validators.composeOR([
        CustomValidators.requiredIf('a', () => true),
        Validators.required,
      ]),
    ],
  ),
});

But this doesn't work as expected as the form is valid, even though the value of field a is true (so checkbox is checked). The form should then be invalid as b is empty.
It seems that the form validation logic doesn't get rechecked after every field change, which causes my issue, but let me know if anyone else knows a way to implement this feature.

Duplicate, sorry #284


UIBULKED-315 Group holdings record properties using optgroup component

Purpose

https://issues.folio.org/browse/UIBULKED-315
After this PR we will have holdings notes in select + grouping:

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.

[ ] I've added appropriate record to the CHANGELOG.md
Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Don't have an idea why it's possible merge without approval..

I'll follow up with DevOps on that one. I'm curious about it too!


Tests for management command generate_secret_key

Thanks !

Coverage increased (+0.01%) to 65.299% when pulling 040a1da1cbb3af0015bd23380bf7c3901fb28a19 on kuter:tests-for-management-command-generate_secret_key into b139cc6297985ba075934653cadf3ad21b71b222 on django-extensions:master.

Coverage increased (+0.01%) to 65.299% when pulling 040a1da1cbb3af0015bd23380bf7c3901fb28a19 on kuter:tests-for-management-command-generate_secret_key into b139cc6297985ba075934653cadf3ad21b71b222 on django-extensions:master.

Coverage increased (+0.01%) to 65.299% when pulling 040a1da1cbb3af0015bd23380bf7c3901fb28a19 on kuter:tests-for-management-command-generate_secret_key into b139cc6297985ba075934653cadf3ad21b71b222 on django-extensions:master.

Coverage increased (+0.01%) to 65.299% when pulling 040a1da1cbb3af0015bd23380bf7c3901fb28a19 on kuter:tests-for-management-command-generate_secret_key into b139cc6297985ba075934653cadf3ad21b71b222 on django-extensions:master.

Coverage increased (+0.01%) to 65.299% when pulling 040a1da1cbb3af0015bd23380bf7c3901fb28a19 on kuter:tests-for-management-command-generate_secret_key into b139cc6297985ba075934653cadf3ad21b71b222 on django-extensions:master.

Coverage increased (+0.01%) to 65.299% when pulling 040a1da1cbb3af0015bd23380bf7c3901fb28a19 on kuter:tests-for-management-command-generate_secret_key into b139cc6297985ba075934653cadf3ad21b71b222 on django-extensions:master.


Consider: AppContextChangeHandler to call current value upon subscription.

This would de-couple the need to init with a value and then to monitor for changes. When subscribing to changes, the closure is called immediately with the initial value.

The AppContextChangeHandler has been deprecated and is removed from the app. Closing.


Fix bug in gpt-service.js that happens in function calls

The order of parameters was wrong, causing OpenAI API to give an error because the function name was being passed instead of the role. Simply reordering the parameters would fix this issue (currently only happens in the transferCall function)
Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[X] I acknowledge that all my contributions will be made under the project's license.

Thank you for the fix!


Update Owners

Update Owners
Signed-off-by: Pablo Iranzo Gómez<EMAIL_ADDRESS>

/assign ptrnull

/lgtm
/approve
bye bye @jparrill , hello @alosadagrande

This is not a goodbye, just a see you later xD
/lgtm

It's Tide aware of this repo to manage self-merging?

It's Tide aware of this repo to manage self-merging?

No, the prior mantainer didn't worked on this :joy:

@jparrill https://github.com/kubevirt/project-infra/pull/250  ;-)


Add support for Go

This PR adds support for Go support.
Currently, only compiled WASM modules using TinyGo is supported. This comes as a result of TinyGo supporting WASI whereas the original Go compiler emits WASM that needs to be accompanied with a wrapper JS file.
To compile
tinygo build -o my_worker.wasm -target wasi my_worker.go

Resolves https://github.com/vmware-labs/wasm-workers-server/issues/95

Hello @mnafees ,
Thank you for this amazing contribution! I added two minor comments. The code looks great and all the examples work perfectly.
Apart from the examples, we should include a new documentation page for Go. It's not a blocker for merging this, so we can work on it in a separate PR. If it's fine for you, I would add a note in that documentation page mentioning you as the original author of the Go kit.
Thank you! 🎉

I am going to add code comments as well as the docs for the new Go support kit and update the PR accordingly :)

Hey @mnafees!
This is just a check on the status of this PR :). I believe the current Go kit is in a great shape to included in the project.
If you are more busy lately, I can do a final review, merge it and create an issue to work on the documentation in a separate PR. If you prefer to complete the documentation on this PR, feel free to add it too.
No rush for it. I just wanted to to do a check since the latest comment was from a few days ago.
Thanks!

Hi @Angelmmiguel, apologies for being AWOL for a while. I got busy with other work. I am updating the PR with the docs. I also went ahead and chose to use the sjson library as suggested by you. Will update with a new comment once the PR is ready for your re-review. Thank you for the patience!

@Angelmmiguel I have updated the PR with all of my changes to the documentation :)

Btw, no worries about the issue on the CI. It's a flaky test I need to fix in main and it's not related to your changes. I will retry it after other builds finish.

Awesome contribution @mnafees! 🚀


Change to code for ctrb and obsv

This is not a bug fix.  It's a minor speed improvement to statefbk.ctrb and statefbk.obsv.
[It's the first time I have contributed to someone else's project so welcome feedback and advice if I'm not doing this correctly]
Summary
I noticed that you can avoid multiple hstack operations by creating a list first.
I've done some testing and I think the behaviour of these methods is unchanged.  See my test outputs below.
I realise this is a very minor improvement so feel free to ignore.
1. Testing ctrb()
Python 3.7.3 | packaged by conda-forge | (default, Mar 27 2019, 15:43:19)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.5.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import numpy as np

In [2]: import control

In [3]: np.random.seed(1)

In [4]: cum = 0

In [5]: for i in range(10):
   ...:     A = np.random.randn(i, i)
   ...:     B = np.random.randn(i, 1)
   ...:     cum += control.ctrb(A, B).sum()
   ...:

In [6]: cum
Out[6]: -10066.24518631401

In [7]: control.__file__
Out[7]: '/Users/billtubbs/python-control/python-control/control/__init__.py'

Results with official control package for comparison
Python 3.6.7 | packaged by conda-forge | (default, Feb 28 2019, 02:16:08)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.3.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import numpy as np

In [2]: import control

In [3]: np.random.seed(1)

In [4]: cum = 0.

In [5]: for i in range(10):
   ...:     A = np.random.randn(i, i)
   ...:     B = np.random.randn(i, 1)
   ...:     cum += control.ctrb(A, B).sum()
   ...:

In [6]: cum
Out[6]: -10066.245186314005

In [7]: control.__file__
Out[7]: '/Users/billtubbs/anaconda3/envs/torch/lib/python3.6/site-packages/control/__init__.py'

2. Testing obsv()
In [1]: import numpy as np

In [2]: import control

In [3]: control.__file__
Out[3]: '/Users/billtubbs/python-control/python-control/control/__init__.py'

In [4]: np.random.seed(1)

In [5]: cum = 0.

In [6]: for i in range(10):
   ...:     A = np.random.randn(i, i)
   ...:     C = np.random.randn(1, i)
   ...:     cum += control.obsv(A, C).sum()
   ...:

In [7]: cum
Out[7]: -7589.3515984634905

Results with official control package for comparison
In [12]: np.random.seed(1)

In [13]: cum = 0.

In [14]: for i in range(10):
    ...:     A = np.random.randn(i, i)
    ...:     C = np.random.randn(1, i)
    ...:     cum += control.obsv(A, C).sum()
    ...:

In [15]: cum
Out[15]: -7589.351598463492

In [16]: control.__file__
Out[16]: '/Users/billtubbs/anaconda3/envs/torch/lib/python3.6/site-packages/control/__init__.py'

3. Speed Tests (In Python 3.7 on a 2013 MacBook Pro)
In [8]: def ctrb1(A, B):
   ...:      amat = np.mat(A)
   ...:      bmat = np.mat(B)
   ...:      n = np.shape(amat)[0]
   ...:      ctrb = bmat
   ...:      for i in range(1, n):
   ...:          ctrb = np.hstack((ctrb, amat**i*bmat))
   ...:      return ctrb
   ...:

In [9]: def ctrb2(A, B):
   ...:      amat = np.mat(A)
   ...:      bmat = np.mat(B)
   ...:      n = np.shape(amat)[0]
   ...:      ctrb = np.hstack([bmat] + [amat**i*bmat for i in range(1, n)])
   ...:      return ctrb
   ...:

In [11]: np.random.seed(1)

In [12]: A = np.random.randn(8, 8)

In [13]: B = np.random.randn(8, 1)

In [14]: %timeit ctrb1(A, B)
456 µs ± 18 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

In [15]: %timeit ctrb2(A, B)
378 µs ± 13.2 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

In [16]: 1-378/456
Out[16]: 0.17105263157894735

@billtubbs Thanks for the contribution to python-control!
Your proposed changes are not pass the Travis CI unit tests. Can you fix those and then resubmit?  The problem could be in your code or could be in the unit tests, but something is not right.
Also, I wonder whether it might not be faster by using the fact that each iteration of the computation just needs to pre-/post-multiple the last col/row of the matrix by A, rather than computing A**i.

I see I made an error.  I checked out your unit tests and realised my mistake.  I will make the change shortly and test it with your tests this time...
Sorry about that.

I fixed the error and it seems to pass the unit tests now:
In [1]: from control.tests.statefbk_test import TestStatefbk

In [2]: tests = TestStatefbk()

In [3]: tests.testCtrbSISO()

In [4]: tests.testCtrbMIMO()

In [5]: tests.testObsvSISO()

In [6]: tests.testObsvMIMO()

Coverage decreased (-0.02%) to 78.205% when pulling 9309259f4824f2126629b168521b41c1afa84915 on billtubbs:bt-statefbk into c0092e088f8626fc31dd0c0287e7eb517c460fb7 on python-control:master.

Changes look good.  More pythonic and if we get some speed up as well, that's great.

Cool, thanks.  It's only a minor speed improvement of 13-17% on something that wasn't exactly computationally demanding...
Anyhow, I am interested in this project.  If there is any way I can help let me know.  I'd say I'm an intermediate/good python programmer and currently learning control engineering.

Also, I wonder whether it might not be faster by using the fact that each iteration of the computation just needs to pre-/post-multiple the last col/row of the matrix by A, rather than computing A**i.

Ah yes, good idea.  I'll look into that.

Places that could use help: https://github.com/python-control/python-control/issues

I worked on some faster versions.  Turns out converting the arguments to np.mat was wasting a lot of time.  However, the fastest two solutions are not that pretty and hardly as readable as ctrb2.
What do you think?
Setup:
In [1]: import numpy as np

In [2]: np.random.seed(1)

In [3]: A = np.random.randn(8, 8)

In [4]: B = np.random.randn(8, 1)

In [47]: def ctrb1(A, B):  # Original
    ...:     amat = np.mat(A)
    ...:     bmat = np.mat(B)
    ...:     n = np.shape(amat)[0]
    ...:     ctrb = bmat
    ...:     for i in range(1, n):
    ...:         ctrb = np.hstack((ctrb, amat**i*bmat))
    ...:     return ctrb
    ...:

In [48]: %timeit ctrb1(A, B)   # Most recent improvement
227 µs ± 24.8 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

In [49]: def ctrb2(A, B):
    ...:      amat = np.mat(A)
    ...:      bmat = np.mat(B)
    ...:      n = np.shape(amat)[0]
    ...:      ctrb = np.hstack([bmat] + [amat**i*bmat for i in range(1, n)])
    ...:      return ctrb
    ...:

In [50]: %timeit ctrb2(A, B)
175 µs ± 783 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [51]: def ctrb3(A, B):   # Eliminating np.mat conversion
    ...:     n = A.shape[0]
    ...:     ctrb = np.hstack([B] + [np.linalg.matrix_power(A, i).dot(B) for i i
    ...: n range(1, n)])
    ...:     return ctrb
    ...:

In [52]: %timeit ctrb3(A, B)
70.5 µs ± 690 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [53]: def ctrb4(A, B):    # Eliminating the matrix power operation
    ...:     n = A.shape[0]
    ...:     items = [B]
    ...:     x = np.eye(n)
    ...:     for i in range(1, n):
    ...:         x = x.dot(A)
    ...:         items.append(x.dot(B))
    ...:     ctrb = np.hstack(items)
    ...:     return ctrb
    ...:

In [54]: %timeit ctrb4(A, B)
26.6 µs ± 212 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [56]: np.isclose(ctrb1(A, B), ctrb3(A, B)).all()
Out[56]: True

In [57]: np.isclose(ctrb1(A, B), ctrb4(A, B)).all()
Out[57]: True

In [58]: def g(A, B):   # Using a generator function
    ...:     n = A.shape[0]
    ...:     x = np.eye(n)
    ...:     yield B
    ...:     for i in range(1, n):
    ...:         x = x.dot(A)
    ...:         yield x.dot(B)
    ...:

In [59]: %timeit np.hstack(tuple(g(A, B)))
27 µs ± 268 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [60]: np.isclose(ctrb1(A, B), np.hstack(tuple(g(A, B)))).all()
Out[60]: True

In [61]: def ctrb5(A, B):
    ...:     return np.hstack(tuple(g(A, B)))
    ...:

In [62]: %timeit In [61]: def ctrb5(A, B)
Traceback (most recent call last):

  File "/Users/billtubbs/anaconda3/envs/pctest/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3296, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)

  File "<ipython-input-62-69192e74f91d>", line 1, in <module>
    get_ipython().run_line_magic('timeit', 'In [61]: def ctrb5(A, B)')

  File "/Users/billtubbs/anaconda3/envs/pctest/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 2307, in run_line_magic
    result = fn(*args, **kwargs)

  File "</Users/billtubbs/anaconda3/envs/pctest/lib/python3.7/site-packages/decorator.py:decorator-gen-60>", line 2, in timeit

  File "/Users/billtubbs/anaconda3/envs/pctest/lib/python3.7/site-packages/IPython/core/magic.py", line 187, in <lambda>
    call = lambda f, *a, **k: f(*a, **k)

  File "/Users/billtubbs/anaconda3/envs/pctest/lib/python3.7/site-packages/IPython/core/magics/execution.py", line 1090, in timeit
    ast_stmt = self.shell.compile.ast_parse(transform(stmt))

  File "/Users/billtubbs/anaconda3/envs/pctest/lib/python3.7/site-packages/IPython/core/compilerop.py", line 100, in ast_parse
    return compile(source, filename, symbol, self.flags | PyCF_ONLY_AST, 1)

  File "<unknown>", line 1
    def ctrb5(A, B)
                   ^
SyntaxError: invalid syntax

In [63]: %timeit ctrb5(A, B)
27.1 µs ± 147 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

In [64]: np.isclose(ctrb1(A, B), ctrb5(A, B)).all()

ctrb4() looks like the best for speed.

The numpy matrix class is being deprecated, so eventually the np.mat will have to go away.  Check out PR #292 for a refactored version and perhaps build off of that?
The PR is now merged, so if you want to make additional changes it will have to go in a new PR.

Understood.  Seems like a good idea to replace np.mat but looks like a big job...
I'll have to add things like the following to ctrb and obsv:
def ctrb(A, B):
    amat = np.array(A, ndmin=2)
    bmat = np.array(B, ndmin=2)
    ...

I'll maybe work on this next weekend and make sure it's working before starting a new PR.

Current changes are better than what was there.  OK to keep tweaking, but there are lots of other things to work on that could use work, if you have time.


Add custom icons to unity atoms assets

Wouldn't this library be soooo much better with gizmos? :D
Investigate if it is possible to just use one image / icon and use it for all script icons in the inspector and all unity atom assets created (like the Post Processing Stack is doing - https://github.com/Unity-Technologies/PostProcessing)

I think I hear what you're saying, although I think there might be a bit of confusion between Gizmos which are intended for visual debugging and setup in the Scene View versus overriding the default ScriptableObject icon so that unity-atom assets are visually distinguished.
This is pretty easy to setup. Given the number of distinct ScriptableObject derived types it would probably help to create a table/spreadsheet of each of the types we want to assign an icon to. That way we can infer a semantic or general intent thats easily visualized for each one and then create/assign an icon for it.

Got you! Was a little bit lazy and didn't do enough research before making the issue (just wanted to create it to keep track of it). Changed the name of the issue sto make it less confusing.
A spreadsheet / table sounds like a good idea 👌My first initial thought is to create an icon per type, Variable, Event, Listeners, MonoHooks, Functions and Actions. How does that sound to you? Wouldn't mind if you start on a table.
Another suggestion would be to use the icon that I used for my blog post here (first picture). Then we could just change the color for each type. But again, would like some input on this.

@jeffcampbellmakesgames How do you add custom icons to scripts / assets? From looking at your repo it seems like meta data is pointing to the guid of the icon. However, do one need to manually set this guid in the meta file(s) manually or is there some other way?

You can either add that yaml section manually through the meta file or finding the script in the Unity Editor and manually assigning it through the inspector.
In the screenshot below, selecting the script's icon in the inspector and then selecting Other will allow you to manually select the icon to use.

You can create a folder "Gizmos" and in there an image: <NameOfYourClass> Icon.png
(note the space between the class name and "Icon").
Assets of this class type should automatically use this icon
source

You can create a folder "Gizmos" and in there an image: <NameOfYourClass> Icon.png
(note the space between the class name and "Icon").
Assets of this class type should automatically use this icon
source
edit: reading further in this thread, it seems in newer versions you need to take the namespace into account, see this post: https://forum.unity.com/threads/custom-scriptableobject-icons-thumbnail.256246/#post-3654346

Just to help clarify, Gizmos are for in-sceneview icons while the types of icons these would be for would be on the ScriptableObjects in the project view or wherever they are assigned as a serialized reference.
This reply goes into more detail.
https://github.com/AdamRamberg/unity-atoms/issues/23#issuecomment-482926060

I opened the unity atoms project. Created a file at Assets/Gizmos/UnityAtoms/FloatVariable Icon.png
and as you can see in this image:

it obviosly works for assets created from scriptable objects. its not in the scene view, it does not have to be manually assigned

Thanks @jeffcampbellmakesgames and @soraphis for the input!
Implemented a solution in cb6280a2554c9ac536d17485865fc4ae4ea85138 and bcdb8f16ea356fde0966260c9c4d60d7f56e2eb0.
I actually ended up doing something a bit more complicated, but more robust when it comes to assigning icons to generated atoms (using the Generator.cs). I took some inspiration from this post on StackOverflow and did some adjustments to make it more flexible and general. It uses AssetPostprocessor to assign icons after assets are imported. Will probably break this out into its own repo, since I think that others could find it pretty nifty.
Think we are good for know if comes to the icons. Might come back to this later, but closing the issue for now.


[sophora-server]: add persistent volumes to chart (#114)

solves https://github.com/subshell/helm-charts/issues/114

@hehu80 extraDeploy is not an option?

@tom-schoener extraDeploy is an option. I will close this PR.


Memoize with hack to pass-through new values, fixes #12

Well this is kinda hacky-hacky solution.
Simply memoize is not working since you cannot pass new updated values (selectedValue), so you need to somehow pass it.
Instead of hacky callback it could be done with events or flux/redux. Not a clean component, side-effecty.... But actually works.
I tried messing with factories and react elements, but no luck =(.
If you want to keep the api - this kind of solution will work.
PS: quite difficult stuff tbh

To fix #12

Closing in favour of #32


More syntax restrictions

From @Bakkot:

I think you want spec text in https://tc39.github.io/ecma262/#sec-static-semantics-static-semantics-isvalidsimpleassignmenttarget prohibiting import.meta as an LHS

In general I should audit new.target and copy other things it does along these lines.

After an audit I think that is the only one that applies. The other places NewTarget is dealt with have to do with Contains restrictions, which we cover in one fell-swoop by prohibiting it outside module code.


[Errors] error recovery with illegal modifiers inside function bodies

export function foo() {
       export var x = this;
}

Expected:
!!! Modifiers cannot appear here.
Actual:
    export function foo() {
       export var x = this;
!!! Statement expected.
    }
!!! Declaration or statement expected.

See also:
tests/cases/conformance/parser/ecmascript5/ErrorRecovery/parserModifierOnStatementInBlock2.ts
tests/cases/conformance/parser/ecmascript5/ErrorRecovery/parserModifierOnStatementInBlock3.ts
tests/cases/conformance/parser/ecmascript5/ErrorRecovery/parserModifierOnStatementInBlock4.ts

This appears to be fixed


Getting Null on @BindView

Hi, I am getting null object reference on bind view as shown below
Gradle Dependencies:
compile 'com.jakewharton:butterknife:8.7.0'
annotationProcessor 'com.jakewharton:butterknife-compiler:8.7.0'

Packaging Options:
exclude 'META-INF/services/javax.annotation.processing.Processor'

Proguard:
# Retain generated class which implement Unbinder.
-keep public class * implements butterknife.Unbinder { public <init>(**, android.view.View); }
-keep public class * implements butterknife.internal.ViewBinder { public <init>(); }

# Prevent obfuscation of types which use ButterKnife annotations since the simple name
# is used to reflectively look up the generated ViewBinding.
-keep class butterknife.*
-keepclasseswithmembernames class * { @butterknife.* <methods>; }
-keepclasseswithmembernames class * { @butterknife.* <fields>; }
-keep class **$$ViewBinder { *; }
-keep class **$ViewHolder { *; }
-keep class butterknife.**$Finder { *; }

Code Snippet for initializing Activity:
*****

@BindView(R.id.username_activity_login)
public EditText et_username;

@Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_login);
        ButterKnife.setDebug(true);
        ButterKnife.bind(this);
*****

Gradle version:
distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip

By using above code and configuration @BindView doesn't work, Please help to resolve this issue.
Thanks.

The ProGuard rules and packaging options can be deleted in their entirety.
Is there generated code in the build/ folder? Without a representative sample it's impossible to know what's going on.

Only DataBindingInfo class found in build/dataBinding
package android.databinding.layouts;

import android.databinding.BindingBuildInfo;

@BindingBuildInfo(buildId="ef51ef81-e3ba-45df-9e6b-5cf48e3a5201")
public class DataBindingInfo {}

And also found data-binding-compiler, data-binding-info, data-binding-layout-out in the intermediates
And here are the ButterKnife debug logs

The compiler is not running and generating the code. Without a representative sample project it's impossible to know why, but it's a build problem and not a problem with this libary.

Hi @JakeWharton
Here is the Sample Application that contains the issue
https://github.com/goyalzz/ButterKnifeDemo.git
And here is the invite for this repo
https://github.com/goyalzz/ButterKnifeDemo/invitations

Hi @JakeWharton,
Please help me to resolve this issue.

This is not a support forum. When I get time, I'll look at your sample and
determine if it's a bug or not.
On Wed, Aug 2, 2017 at 11:37 AM Ankush Goyal<EMAIL_ADDRESS>wrote:

Hi @JakeWharton https://github.com/jakewharton,
Please help me to resolve this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JakeWharton/butterknife/issues/1030#issuecomment-319710276,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEdLo4v2KHfv7p8itV59GbpFLqm_Jks5sUJergaJpZM4OoX7I
.

@goyalzz You're trying to use apt and annotationProcessor at the same time, which isn't supported. Remove the dependency on apt and change your Dagger dependency to:
annotationProcessor 'com.google.dagger:dagger-compiler:2.11'
compile 'com.google.dagger:dagger:2.11'

Thanks @colinrtwhite, It's working fine.


Trait calls to overloaded members

For example if a class defines overloaded (+) operators, WebSharper currently can't look up which one to call, as it translates trait calls based on names only and not signatures. (Gives error Ambiguity at translating trait call: op_Addition)

Macros for F# basic arithmetic operators currently only look at first type argument. This is wrong when you have a type CustomNumber with a static member (+) (a: int, b: CustomNumber), because 1 + CustomNumber(1) translates to the JavaScript + operator (because only int is checked) instead of a call to the correct implementation.


Manual upgrade project with JHipster v4.5.3

Use version at 1dede4ccfd62e3979d2538042f936f98b3dd0ea1

Codecov Report

Merging #52 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage      83.5%   83.59%   +0.09%
- Complexity      544      548       +4
============================================
  Files            71       72       +1
  Lines          1819     1823       +4
  Branches         93       94       +1
============================================
+ Hits           1519     1524       +5
  Misses          266      266
+ Partials         34       33       -1

Impacted Files
Coverage Δ
Complexity Δ

...imaud/qualitoast/config/SecurityConfiguration.java
97.26% <ø> (-0.04%)
10 <0> (ø)

...imaud/qualitoast/web/rest/ApplicationResource.java
100% <ø> (ø)
9 <0> (ø)
:arrow_down:

...pascalgrimaud/qualitoast/web/rest/vm/LoggerVM.java
92.3% <ø> (ø)
6 <0> (ø)
:arrow_down:

...imaud/qualitoast/config/DatabaseConfiguration.java
81.25% <ø> (-1.11%)
2 <0> (-1)

...algrimaud/qualitoast/web/rest/AccountResource.java
98.55% <100%> (+1.53%)
32 <0> (+2)
:arrow_up:

.../pascalgrimaud/qualitoast/service/UserService.java
96.24% <100%> (+0.02%)
26 <0> (ø)
:arrow_down:

...rimaud/qualitoast/config/JacksonConfiguration.java
100% <100%> (ø)
3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7332c2...0fa9f38. Read the comment docs.


Can't seem to get heart rate reading

Hi, I can't seem to get any heart rate reading from the app. And I'm not too sure what's that yellow lightning bolt with a strike is at the right side.

That means it's disconnected. Did you try the troubleshooting steps?

I had this issue until I realized I needed to delete the port from the settings on the watch following one of the recent updates.  I hadn't been aware until I read through several of the other issues on GitHub.

Did you ever get this figured out?

If you need more help let me know


[Bug Report] there will be a problem if i send the json from python client

Description
I create the node.js express server as backend. When I get the request with json data from httpie, there will be a little different between java, javascript.
Expected Behavior
what I get on my server
{"hello":"world"}

Actual Behavior
what I get on my server
{"hello": "world"}
---------^--------- trailing whitespaces here

and throw the error
Error: Unterminated string
    at parseString (eval at line.toFunction (/Users/tzu-yen/Documents/TonJS/node_modules/generate-function/index.js:172:21), <anonymous>:3:23)
    at parse (eval at line.toFunction (/Users/tzu-yen/Documents/TonJS/node_modules/generate-function/index.js:172:21), <anonymous>:11:17)
    at Object.readJSON (/Users/tzu-yen/Documents/TonJS/packages/catapult/src/index.ts:33:10)
    at /Users/tzu-yen/Documents/TonJS/example/single.ts:8:18
    at /Users/tzu-yen/Documents/TonJS/packages/ton/dist/index.js:298:28

There will be a problem, when I use the parser from third party parser such as turbo-json-parse.
Environment

Node.js v14.2.0
express v4.17.1
httpie v2.1.0
macOS (Catalina v10.15.4)

MacBook Pro (Retina, 13-inch, Early 2015)
2.7 GHz Core x2
8 GB DDR3 Ram x1

httpie command
http post :3000 hello=world

my source code
const express = require('express')
const bodyParser = require('body-parser')
const turbo = require('turbo-json-parse')
const parser = turbo(  {
  type: 'object',
  properties: {
    hello: { type: 'string' }
  }
})

// create server
const app = express()

// add middleware
app.use(bodyParser.raw())
app.use(function (req, res, next) {
  console.log(req.body.toString()) // print the body from client

  parser(req.body.toString())

  next()
})

Any Update @mafintosh

Thanks for the issue, let me have a look

Set prettyPrinted: true in the options for json with whitespace support