appVersion defaults to chartVersion, it shouldn't

Hi,
Your library is used by helmfile, in the following code:
https://github.com/variantdev/chartify/blob/7c61f46c183ff9c83e1fd4164ea4317ab8089502/chartify.go#L214-L215
The appVersion is defaulted to the same value as the chartVersion.
This is often not the case, and it's better not to add it to Chart.yaml if not set.
Thanks in advance

@yelhouti Ah that's good point! Probably I didn't know that the appVersion was optional when I wrote the initial version of chartify. I'll try to fix it

https://github.com/variantdev/chartify/commit/8ff30374cb2a65af5167f3d47df81fe45d37b01d#diff-1c094adc4e7175fd1ea951f9fcb450a85b1dd5a86b4090ae3512364018f81464R275 fixes the issue in chartify (I unexpected mixed the another change into the same commit but anyway...

The above change is included in Helmfile since https://github.com/roboll/helmfile/pull/1803. Closing as resolved!


How to do filter nearby?

I want to filter 5 location nearby log, lat how do I do that?

@iraycd Please let me know if you got any solution as I am also facing similar issue. Thanks

You should be using 2 different fields for latitude and longitude.


Unauthenticated error handling with json request

Laravel Version: 5.7
PHP Version: 7.1
Database Driver & Version: doesn't affect issue behavior

Description:
I have Laravel 5.7 app as API service. I'm trying to get json response while trying to access auth guarded route.
My route:
Route::group(['prefix' => 'auth'], function () {
    Route::get('me', 'AuthController@me');
});

method:
public function me()
{
    return auth()->user();
}

When I make get request to endpoint described above, I got 500 error:

"message": "Route [login] not defined.",
"exception": "InvalidArgumentException",

Because I use Laravel app as API only service, I don't have any web routes. Let's take a look on handling AuthenticationException:
protected function unauthenticated($request, AuthenticationException $exception)
{
    return $request->expectsJson()
                ? response()->json(['message' => $exception->getMessage()], 401)
                : redirect()->guest($exception->redirectTo() ?? route('login'));
}

If we send request with Accept: application/json header, we might get this response: response()->json(['message' => $exception->getMessage()], 401).
I'm using axios on client for making xhr requests, so Accept: application/json header is present. By the way, I don't get json response back.
expectsJson():
public function expectsJson()
{
    return ($this->ajax() && ! $this->pjax() && $this->acceptsAnyContentType()) || $this->wantsJson();
}

Since my request has Accept: application/json header, $this->wantsJson() might be satisfied... What's wrong?

Could you share your application on GitHub?

@TBlindaruk yes, here it is
php artisan jwt:secret is required (I'm using jwt-auth)

@TBlindaruk changed. This doesn't affect anything by the way.

Commenting (or removing) this line results correct response:
{
	"message": "Unauthenticated."
}

But I can't confirm if this is right solution.

Looks like 2 separate issues to me;

$request->expectsJson() is returning false, so it was hitting your web route
This was throwing an error 500, since no route('login') exists.

You'll need to investigate why $request->expectsJson() is returning false?

@laurencei about 1st issue: can I debug it somehow? Can custom FormRequest be suitable in my case? I guess, I can try isJson() to check whatis the type of request.
Totally agree with 2nd issue as it is an aftereffect of the 1st one.

Commenting (or removing) this line results correct response:

Instead of removing the line, replace it with dd($request); and check the headers.

@AegirLeet thank you!
So far:

looking through dd($request):

#json: null
...
#acceptableContentTypes: null
...
#headers: array:3 [▼
      "host" => array:1 [▶]
      "user-agent" => array:1 [▶]
      "accept" => array:1 [▼
        0 => "application/json"
      ]
    ]

dd($request->ajax()) returns false
dd($request->isJson()) returns false

Seems a bit strange for me... I thought this
      "accept" => array:1 [▼
        0 => "application/json"
      ]

is enough to satisfy json request.

OK, I've looked into this and I'm pretty sure it has nothing to do with JSON or the handling of the AuthenticationException, because the AuthenticationException is never even thrown. Try dumping $request->expectsJson() - does this return true? It probably does.
This line is indeed the problem. It's called when the parent tries to construct the Exception:
throw new AuthenticationException(
    'Unauthenticated.', $guards, $this->redirectTo($request)
);

But the login route doesn't exist by default, so the route('login') throws an InvalidArgumentException.
This bug is present even in a fresh Laravel install:
laravel new auth-test
cd auth-test
php artisan serve

and then
curl -H "Accept: application/json" http://localhost:8000/api/user

and you will see the same Exception.
This bug seems to have been introduced in https://github.com/laravel/laravel/commit/a14e62325cbe82a615ccd2e80925c75cb0bf1eaf.
Workaround: Add a route named "login" or remove the call to route('login') from the Middleware.

@AegirLeet
dd($request->expectsJson()) returns true
Going to remove route('login') call for now.

I'll be closing this, as Taylor has said in the PR that you are free to change this in your own application.
Let me know if there is another reason to keep this ticket open. Thanks.

You should use Accept header set to application/json in your request.


[cairo:x86-windows-static] build failure

Host Environment

OS: GH Actions windows-2019
Compiler: Visual Studio 2019

To Reproduce
./vcpkg install cairo:x86-windows-static
Failure logs
error LNK2019: unresolved external symbol __imp__cairo_script_interpreter_destroy referenced in function _main
(many of these, see log file)
7.txt
Additional context
vcpkgGitCommitId: a3db16a4475b963cacf0260068c497fb72c8f3c0
It fails compiling the executables under static library configuration. It looks like as if it tries linking the DLL symbols.
Also I'm not interested in building these programs, only library, I'd skip these if possible.

This was caused by the cairo version update #17620

Thanks for posting this issue. Now cairo:x86-windows-static can install succeed on latest VCPKG. If it is still an issue, please reopen this issue.


gtk-rs examples in a flatpak

I spend a couple of days figuring out how to these examples distributed via a flatpak. It is working. I'll probably record another screencast and put it up on YouTube. Here are some quick notes.
Install Flatpak if not installed. On Fedora, this is:
sudo dnf install flatpak

Install the gtk-rs-examples:
sudo flatpak install https://s3.amazonaws.com/ctaggart/flatpak/gtk-rs-examples.flatpakref

See what is installed and run it:
flatpak list
flatpak run org.gtkrs.GtkTest

try the other examples:
flatpak run --command=sh org.gtkrs.GtkTest
cd /app/bin

https://twitter.com/cmr0n/status/897069438918381572
https://youtu.be/ReMj_c1EEGM

we have a basic example of how to use Flatpak to package a GTK application here https://github.com/flatpak/flatpak-builder-tools/tree/master/cargo
I can add the same example to this repository as well, not sure if it's worth it as it's more related to Flatpak than GTK-rs


SFA compatibility

Solution for the issue https://github.com/gaearon/redux-thunk/issues/131.
Added SFA(standard flux actions) compatibility.
P.S. Probably it's a duplicate of https://github.com/gaearon/redux-thunk/pull/105 but with unit-test  and without dependencies 😎

https://github.com/gaearon/redux-thunk/pull/68#issuecomment-210674472

I think you can just put SFA middleware before redux-thunk and keep redux-thunk pure and simple.


Winter Finals exceptions

added winter finals exceptions and exceptions for the week of conferences(2016-03-07).

I just realized this also incorporates fixes done in #246.

Moved your changes over to #249 and made added exceptions for EBC week. Thanks for your help!


Add to Home Screen Pop up

(This is an edited image just for illustration)
When user visits this web App from mobile, this popup must come.

Can I work on this as part of GSSOC'21 ?

Feel free to ask your doubts, if any

Read

Hello, can I work on this issue?Is it still open?

Hello, can I work on this issue?Is it still open?

I am working on it.

Can you please make me clear When the Pop up will show, as I am viewing this site from Mobile but no pop-up comes

When viewed in mobile device, it should be visible.
I'll recheck again.

But the manifest.json file is validated successfully. Service worker also is registered.

Open the site in your phone

It is not showing up now.

@AishwaryaKaranth  do you want to solve this bug?

Can I try fixing it till tomorrow?
If I am unable to fix it by tomorrow, I'll let you know?

Sure!


Fix CLI TestRunner initialization error grammar

Summary
There's a minor grammatical typo in the process termination error; this fixes that typo.
Test plan
I didn't create any additional tests for this since it is only modifying an error message.

Can't believe we never noticed ;) Thank you.


manta file doesn't open

I am the maintainer of the supernote-typescript library and supernote Obsidian plugin. I regularly cross test between my library and yours to test things.
Anyways, the new Supernote manta came out and someone provided a file that breaks both our tools. Just FYI.
https://github.com/philips/supernote-obsidian-plugin/issues/37

Here is my fix: https://github.com/philips/supernote-typescript/commit/57a5f2ffa1b92808f539f9a3204f860038f643e4

@philips thank you for sharing the information.
It seems there is a resolution change in Manta.  I will fix my tool soon.

Added the fix b6b4441c98770f0bea5607d8b0dc65bb44c9f512


Does not support quotes around fields

Embedded commas in a quote delimited field does not work.

Could you provide an example (the URL of your test)?

Just do a save and copy the URL in this issue.

I had a question about this too - in a few of my CSV fields I had added backslashes to escape double quotations (in my case they were being used frequently in product descriptions to specify inches). The JSON output frequently came out with multiple backslashes  - three in most cases. Was wondering what to do so that I don't have to go through and clean them manually in my MongoDB afterwards?
Does the converter automatically add backslashes? Was it mistake to add my own, pre-conversion?
Thanks!

Hi Jonas,
Could you provide a sample example? Run it through csv2json, save it and
copy the URL here.
Thanks,
--Martin
On Wed, May 27, 2015 at 9:07 AM, Jonas Clark<EMAIL_ADDRESS>wrote:

I had a question about this too - in a few of my CSV fields I had added
backslashes to escape double quotations (in my case they were being used
frequently in product descriptions to specify inches). The JSON output
frequently came out with multiple backslashes - three in most cases. Was
wondering what to do so that I don't have to go through and clean them
manually in my MongoDB afterwards?
Does the converter automatically add backslashes? Was it mistake to add my
own, pre-conversion?
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/martindrapeau/csvjson-app/issues/1#issuecomment-105900000
.

Hi Martin -
Thanks for the response!
If it's okay I'll just copy it in here:
CSV Input:
source	source_url	catalog_num	category	listing_num	title	description	price	price_realized	original_date	image_urls					Archive_Year
Martin Keane		91	Bamboo Fly Rod	7	Tim Zietak Quad 6'6" 2/2 DF	Well known nationally  for his artistic Quad Rods TIM ZIETAK.  We offer this 6 1/2' , 2/2,  light  DF  action;  with  dark  richly  flamed  shafts,  silks  are  dk.  red  with  black tipping & it has a red agate stripping guide & beautifully blued ferrules & cap & band on the fine mahogany reel seat. Tim's rods continue to please & amaze veteran expert fly fishermen;  this little "sleeper" awaits your discovery; it's brand  new, unused with a superb varnish finish.  	1350		2006						2006
Martin Keane		91	Bamboo Fly Rod	8	Orvis Caenis 6'9" 2/2 #4	ORVIS  Caenis  6'9",  2/2,  absolutely  new  for  #4  line,  cork  seat  with  2  thin  sliding    bands,  2 1/4 oz., chrome  guides,  perfect  ferrule blue, very  handsome  with  new  cond. bag & label on tube, ser. #80,3XX.  	680		2006						2006
JSON Output:
[
{
"source": "Martin Keane",
"source_url": 0,
"catalog_num": 91,
"category": "Bamboo Fly Rod",
"listing_num": 7,
"title": "Tim Zietak Quad 6'6\" 2/2 DF",
"description": "Well known nationally  for his artistic Quad Rods TIM ZIETAK.  We offer this 6 1/2' , 2/2,  light  DF  action;  with  dark  richly  flamed  shafts,  silks  are  dk.  red  with  black tipping & it has a red agate stripping guide & beautifully blued ferrules & cap & band on the fine mahogany reel seat. Tim's rods continue to please & amaze veteran expert fly fishermen;  this little \"sleeper\" awaits your discovery; it's brand  new, unused with a superb varnish finish.",
"price": 1350,
"price_realized": 0,
"original_date": 2006,
"image_urls": 0,
"": 0,
"Archive_Year": 2006
},
{
"source": "Martin Keane",
"source_url": 0,
"catalog_num": 91,
"category": "Bamboo Fly Rod",
"listing_num": 8,
"title": "Orvis Caenis 6'9\" 2/2 #4",
"description": "ORVIS  Caenis  6'9\",  2/2,  absolutely  new  for  #4  line,  cork  seat  with  2  thin  sliding    bands,  2 1/4 oz., chrome  guides,  perfect  ferrule blue, very  handsome  with  new  cond. bag & label on tube, ser. #80,3XX.",
"price": 680,
"price_realized": 0,
"original_date": 2006,
"image_urls": 0,
"": 0,
"Archive_Year": 2006
}
]

PS - interestingly, though the copy above (which was taken directly from the output) shows two backslashes resulting from the CSV, the actual visual display of the output shows three backslashes. I'm stumped as to why that might be the case but I've attached a screenshot in case that's helpful.

For reference, here is the test case.
http://www.csvjson.com/csv2json/d142bb375cd6b9240661ff543e6fcc71

Duh, gotcha - just saw the "save" button in the upper right! :)

Hi Martin - just wanted to see if you had any updates about the backslashes in conversion. No pressure, just eager to know! -Jonas

Give it a go how. Double quotes should no longer appear.
And I've made changes to support commas in quotes.


signal 11 on nvidia hardware using primusrun/optirun

https://github.com/godotengine/godot/issues/67
^ is similar but old,I am on arch linux with all fresh install of stable.

**Godot version:** v3.0.3.stable.official.e649ec7

**OS/device including version:**
OpenGL renderer string: GeForce GTX 960M/PCIe/SSE2
uname -a
Linux flux.thalhalla.net 4.17.3-1-ARCH #1 SMP PREEMPT Tue Jun 26 04:42:36 UTC 2018 x86_64 GNU/Linux

glxinfo --> https://gist.github.com/joshuacox/d975af591f5c14e007e633e33d3e6a2e
Issue description:
running from intel card works fine, but it crashes with primusrun (*even from primusrun bash)
OpenGL ES 3.0 Renderer: GeForce GTX 960M/PCIe/SSE2
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x368f0) [0x7f6c981798f0] (??:0)
[2] /usr/lib/dri/i965_dri.so(+0x1c8081) [0x7f6c8e0ee081] (??:0)
[3] /usr/lib/dri/i965_dri.so(+0x3d5c5d) [0x7f6c8e2fbc5d] (??:0)
[4] /usr/lib/primus/libGL.so.1(+0x26425) [0x7f6c96e8c425] (??:0)
[5] /usr/lib/libpthread.so.0(+0x7075) [0x7f6c96c4f075] (??:0)
[6] /usr/lib/libc.so.6(clone+0x3f) [0x7f6c9823b53f] (??:0)
-- END OF BACKTRACE --
Aborted (core dumped)

Steps to reproduce:
start godot with primusrun/optirun on latest nvidia drivers in arch (maybe specific to my hardware
Minimal reproduction project:
no project necessary this problem is evident at boot if using primusrun/optirun, works fine using intel without primusrun/optirun.

Have you tried other 3D applications using primusrun on your system?

Indeed, I did have some issues with primusrun and bumblebee that had cropped up unbeknownst to me, at the moment using optirun is the workaround (also reinstall nivida bumblebee bbswitch).  Closing as this is definitely not a godot issue.


Roll engine 6bc33b5e1442..ce7c21ce9b7a (5 commits)

https://github.com/flutter/engine/compare/6bc33b5e1442...ce7c21ce9b7a
git log 6bc33b5e144254ceab274298dd61d9d9ed0dcc8f..ce7c21ce9b7a992c0991db489293a7064f7c9ae9 --no-merges --oneline
ce7c21ce9 Log the correct function on error in the embedder. (flutter/engine#8461)
e10d46421 Improve path metrics tests and docs (flutter/engine#7851)
424045c3f Enable shutting down all root isolates in a VM. (flutter/engine#8457)
816e3dc0f Roll src/third_party/dart 907c514c89..1ad11facec (7 commits)
45dc353ee Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5410803820789760 , https://cirrus-ci.com/task/5762647541678080 , https://cirrus-ci.com/task/6677441215987712 , https://cirrus-ci.com/task/4636747634835456 , https://cirrus-ci.com/task/5199697588256768 , https://cirrus-ci.com/task/6325597495099392

Commit queue failed; closing this roll.


Table Column Configuration

introduce a way to programmatically print table data. Each column get's a formatter and as we iterate the portfolio entries we use just call the formatter for the given column.
individual cell color
row highlighting

Nice refractor, those additional features (like by-column coloring) are a good addition - even if we arn't using them right now.
BTW, sorry for slow responses this week (I'm on vacation). Regular updates from me returning this weekend...

@ConradSelig no worries dude - enjoy your vacation and I appreciate the feedback!
I've got two more PRs planned

populate stocks from portfolio ini independent of the market data sync
a more interactive experience where we basically present a running terminal with a recognized set of commands i.e. (sync market data, print a graph, print a summary table, enter a buy/sell order, etc)


feat: add multiple levels of headings to the sidebar

Currently, we’re looking for Markdown headings in the info.description field and only add the lowest level (eg. h1) to the sidebar.
This PR adds the 2nd lowest level (eg. h2) to the sidebar, too.

If there’s only one level of headings, they are all just added to the sidebar.
If there’s two levels of headings, they will be added to the sidebar. The 2nd lowest level (eg. h2) will be nested under the lowest level (eg. h1).
If there’s more than two levels (eg. h1, h2, h3), the highest level (eg. h3) will be ignored (for the sidebar).

See #906 for more context.

Incredible!
One problem I think I just noticed, though... I see the sub-items in the sidebar are linking appropriately, but the IDs they're linking to aren't being rendered in the description. Only the top-level headings are getting an ID via the markdown renderer, so only the top-level links in the sidebar are working. Here's a simple reproduction...
https://jsfiddle.net/gazugafan/xhw8u61a/40/
If you click on the Heading in the sidebar, that works fine. If you click on the Sub-heading, though, the page doesn't scroll anywhere. If you inspect the HTML, you can see that the sidebar Sub-Heading is linking to #description/sub-heading, which makes sense, but there's no matching ID near the sub-heading in the content.


DatabaseConfig Package Mismatch

I'm trying to set up Floodgate on my Fabric Server. At the moment, I'm downloading Floodgate-Fabric-2.2.4-b38 from Modrinth (floodgate:Mf2wV7re), and manually putting floodgate-mysql-database.jar into my /data/config/floodgate/ folder. However, I keep getting errors as below:
java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'floodgate' at 'org.geysermc.floodgate.platform.fabric.FabricFloodgateMod'!
        at net.fabricmc.loader.impl.FabricLoaderImpl.lambda$invokeEntrypoints$2(FabricLoaderImpl.java:403) ~[fabric-loader-0.16.9.jar:?]
        at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) ~[fabric-loader-0.16.9.jar:?]
        at net.fabricmc.loader.impl.FabricLoaderImpl.invokeEntrypoints(FabricLoaderImpl.java:401) ~[fabric-loader-0.16.9.jar:?]
        at net.fabricmc.loader.impl.game.minecraft.Hooks.startServer(Hooks.java:63) ~[fabric-loader-0.16.9.jar:?]
        at knot/net.minecraft.server.Main.main(Main.java:111) [server-intermediary.jar:?]
        at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
        at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
        at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [fabric-loader-0.16.9.jar:?]
        at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) [fabric-loader-0.16.9.jar:?]
        at net.fabricmc.installer.ServerLauncher.main(ServerLauncher.java:69) [fabric-server-mc.1.21.3-loader.0.16.9-launcher.1.0.1.jar:1.0.1]
Caused by: org.geysermc.floodgate.shadow.google.inject.ProvisionException: Unable to provision, see the following errors:

1) [Guice/ErrorInCustomProvider]: NoClassDefFoundError: org/geysermc/floodgate/database/config/DatabaseConfig
  at CommonModule.playerLink(CommonModule.java:137)
  at FloodgatePlatform.init(FloodgatePlatform.java:60)
      \_ for 2nd parameter link
  while locating FloodgatePlatform

Learn more:
  https://github.com/google/guice/wiki/ERROR_IN_CUSTOM_PROVIDER

1 error

======================
Full classname legend:
======================
CommonModule:         "org.geysermc.floodgate.core.module.CommonModule"
FloodgatePlatform:    "org.geysermc.floodgate.core.FloodgatePlatform"
========================
End of classname legend:
========================
...

From what I can tell, the MysqlConfig class searches for DatabaseConfig in org.geysermc.floodgate.database.config, as indicated by the logs. However, downloading the Mondrinth jar shows the class at org/geysermc/floodgate/core/database/config/DatabaseConfig (note the core package). This is not reflected in the package name of the source code in GitHub, so I suspect that a misconfigured build tool may be moving the class.
minecraft.log

Hey! Thanks for reporting the issue. Floodgate-Fabric is indeed using a different branch than other platforms are; namely the "core-repackage" branch.
Can you try the new floodgate build found here? It should resolve this issue.

That seems to have fixed it! Thanks, chris!

Glad to hear it. Thanks for reporting the issue!


as_toon shader fails to load in Max 2019

2018/08/25 10:01:40 ERR: [04484] [12380] [appleseed] OSL shader query for shader C:\Program Files\Autodesk\3ds Max 2019\Plugins\appleseed\shaders\appleseed\as_toon.oso failed, error = foundation::Exception.

related to PR:
Add classid to toon shaders #2145

Found the bug. There is a typo in the metadata fro Max in as_toon.osl
line 52  string as_max_class_id = "163266005,<PHONE_NUMBER>", needs to be replaced with:
string as_max_class_id = "163266005<PHONE_NUMBER>",

fixed with https://github.com/appleseedhq/appleseed/commit/3fd6dae6c12d5b1ac4d4333e638845345235688f


unzip problem

When I unzip a .bundle file from zip.  My bundle file was damaged, couldn't load anymore.  "Reason: no suitable image found.  "
But if I click to unzip the zip file, the .bundle file can be loaded in my program.

I just upgrade minizip. Can you verify that this is still an issue?

Hi Sam,
I notice that you update minizip. But this symbolic link problem still there, cause I think this feature is not included in minizip. If you wrapper around it, you have to handle it in your code.


Interaction between errors and counters results in crashing the VM on exit

Firstly, I stumbled onto this bug due to my own extreme stupidity, so it is perhaps not an urgent issue to fix. Still a crash is a BAD thing, so worth fixing.
I have narrowed down the repro to this:
    public static void main(final String[] args) throws Exception
    {
        loadPropertiesFiles(args);
        MediaDriver.Context driverCtx = new MediaDriver.Context();
        try (MediaDriver driver = MediaDriver.launch(driverCtx))
        {
            final Aeron.Context ctx = new Aeron.Context();
            ctx.aeronDirectoryName(driver.aeronDirectoryName());
            try (Aeron aeron = Aeron.connect(ctx))
            {
                AgentRunner runner = new AgentRunner(driverCtx.conductorIdleStrategy(),
                        driverCtx.errorHandler(),
                        driverCtx.countersManager().newCounter("Errs"),
                        new Segfault());

                AgentRunner.startOnThread(runner);

                new ShutdownSignalBarrier().await();
                System.out.println("Shutdown Driver...");
            }
        }
    }

    public int doWork() throws Exception
    {
        throw new NullPointerException();
    }

See full class here:
https://gist.github.com/nitsanw/e6da9bb9817ff12f25e2c882639cb87c
So we have a bad agent producing a high rate of errors. When we shut down we crash the VM.
The crash location seems a bit random at first, because it crashes in compiled code and due to inlining the method will change potentially from run to run or just be a method a few frames up the stack from actual issue. Running the sample with inlining disabled(-XX:-Inline) reliably causes the following crash:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f4c8120b699, pid=30193, tid=0x00007f4c725ce700
#
# JRE version: Java(TM) SE Runtime Environment (8.0_92-b14) (build 1.8.0_92-b14)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.92-b14 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# J 591 C2 org.agrona.concurrent.status.AtomicCounter.increment()J (16 bytes) @ 0x00007f4c8120b699 [0x00007f4c8120b660+0x39]

Using an onheap counters manager still produces a crash:
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f09d51ff170, pid=31358, tid=0x00007f09bc5e1700
#
# JRE version: Java(TM) SE Runtime Environment (8.0_92-b14) (build 1.8.0_92-b14)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.92-b14 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# J 586 C2 org.agrona.concurrent.UnsafeBuffer.getAndAddInt(II)I (31 bytes) @ 0x00007f09d51ff170 [0x00007f09d51ff120+0x50]
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/yak/git/Aeron/hs_err_pid31358.log
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#

For the error report:
Stack: [0x00007f717feff000,0x00007f7180000000],  sp=0x00007f717fffe8e0,  free space=1022k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
J 603 C2 org.agrona.concurrent.UnsafeBuffer.getAndAddInt(II)I (31 bytes) @ 0x00007f71cd207870 [0x00007f71cd207820+0x50]
J 601 C2 org.agrona.concurrent.errors.DistinctErrorLog.record(Ljava/lang/Throwable;)Z (137 bytes) @ 0x00007f71cd207f88 [0x00007f71cd207ee0+0xa8]
J 600 C2 io.aeron.driver.MediaDriver$Context.lambda$conclude$0(Ljava/lang/Throwable;)V (27 bytes) @ 0x00007f71cd208c24 [0x00007f71cd208be0+0x44]
J 599 C2 io.aeron.driver.MediaDriver$Context$$Lambda$13.onError(Ljava/lang/Throwable;)V (9 bytes) @ 0x00007f71cd208f20 [0x00007f71cd208ee0+0x40]
J 621% C2 org.agrona.concurrent.AgentRunner.run()V (97 bytes) @ 0x00007f71cd212db8 [0x00007f71cd212c20+0x198]
j  java.lang.Thread.run()V+11

This suggests the error log is being unmapped prematurely before the runners have been brought to heel.

This is my bad, code needs to close runner before letting Aeron/Driver close.


New cop: Use String#include? instead of String#match? with /literal-only-pattern/

Is your feature request related to a problem? Please describe.
String#include? is faster than String#match? with a simple regexp.
https://gist.github.com/pocke/eeffeaa58ddcc35f862f6e1aca593b21
I wrote a few benchmarks, and I got the result.
The difference is small in simple cases (str1 and str2).
But there are clear differences if the string is long.
Describe the solution you'd like
Add a cop to detect String#match? with simple regexp.
And I guess the cop also can detect String#match and String#=~ if it is used as a condition.
Describe alternatives you've considered
nothing
Additional context
We already have Performance/StartWith and EndWIth. We can refer the cops to help to implement it.

And I guess the cop also can detect String#match and String#=~ if it is used as a condition.

It's very hard to tell if people are using the global variables stored by String#match, but perhaps can include a configuration option for this?

Agreed. Generally the use of the globals has been on the decline, so I guess we can also advise people not to do it. I guess the only thing the globals have for them is that they are  more compact than the alternative.


Update freqgame to avoid  empty parentheses in the "me" command

Note: The logic for the entire "me" command  has been moved to a new function "RunMeCommand".

Resolved conflicts


Improve grib support

[x] Add netcdf4 and cfgrib as dependencies
[x] add .grib file extension to a new eodag-cube constant of accepted raster file extensions, as it not known by GDAL and rasterio.drivers.driver_from_extension() (only .grb and .grb2 are recognized)
[ ] update https://eodag.readthedocs.io/en/latest/tutos.html using eodag-cube, see https://github.com/CS-SI/eodag/issues/1385 for more details

See https://github.com/CS-SI/eodag/issues/1385 for more details about the docs update

@sbrunato As far as this repo is concerned, my work is ready for review. Do you mind if we remove the bullet point about docs from this issue since there's a dedicated issue in eodag repo?


Sql error using parquet file in c++

I get the following error when using a SQL query using Parquet
Catalog: Table Function with name parquet_scan does not exist!
Here is my query "CREATE TABLE table1 AS SELECT * FROM PARQUET_SCAN('/path/to/parquet/file')";
What could be the issue?

Parquet support is added as an extension. It is automatically bundled in the shell and the external clients, but needs to be manually enabled in the C++ layer by including parquet-extension.hpp and loading it, e.g.:
#include "parquet-extension.hpp"

DuckDB db;
db.LoadExtension<ParquetExtension>();

Thanks @Mytherin. I will do that

I have compiled the duckdb source code and copied the libparquet_extension.a to the project. Also added the library in my project. Yet I get the following error (although its compiler specific but its somewhat dead end for me).
libparquet_extension.a(parquet-extension.cpp.o):-1: error: Undefined symbols for architecture x86_64:
  "duckdb::Function::CallToString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::vector<duckdb::LogicalType, std::__1::allocator<duckdb::LogicalType> >, std::__1::unordered_map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, duckdb::LogicalType, std::__1::hash<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::equal_to<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const, duckdb::LogicalType> > >)", referenced from:
      duckdb::SimpleNamedParameterFunction::ToString() in libparquet_extension.a(parquet-extension.cpp.o)
  "duckdb::Timestamp::FromEpochMs(long long)", referenced from:
      duckdb::arrow_timestamp_ms_to_timestamp(long long const&) in libparquet_extension.a(parquet_reader.cpp.o)
      duckdb::ParquetReader::PreparePageBuffers(duckdb::ParquetReaderScanState&, unsigned long long) in libparquet_extension.a(parquet_reader.cpp.o)
      duckdb::ParquetReader::ReadChunk(duckdb::ParquetReaderScanState&, duckdb::DataChunk&) in libparquet_extension.a(parquet_reader.cpp.o)
      duckdb::impala_timestamp_to_timestamp_t(duckdb::Int96 const&) in libparquet_extension.a(parquet_timestamp.cpp.o)
  "duckdb::Timestamp::FromEpochMicroSeconds(long long)", referenced from:
      duckdb::arrow_timestamp_micros_to_timestamp(long long const&) in libparquet_extension.a(parquet_reader.cpp.o)
      duckdb::ParquetReader::PreparePageBuffers(duckdb::ParquetReaderScanState&, unsigned long long) in libparquet_extension.a(parquet_reader.cpp.o)
      duckdb::ParquetReader::ReadChunk(duckdb::ParquetReaderScanState&, duckdb::DataChunk&) in libparquet_extension.a(parquet_reader.cpp.o)

Am I missing any other library @Mytherin apart from libduckdb.dylib and libparquet_extension .a?

That could be a mismatch in libraries, those functions are relatively new so them being missing is suspect. Try doing a clean rebuild of both libraries and replacing both libraries again.

Indeed.  I had to replace the latest duckdb.hpp file as well. And it worked perfectly


Show warning when no attributes for EditInstance page (#2989)

Pull request opened by the merge tool on behalf of #2989

Merged in d4564348c96c33373ce8e0b5e7f645eef95bd10b


blender: use numpy 1.x

Build failure with numpy 2:
cc1plus: warning: /nix/store/ap7rx876aby0nya3g5s8c1hg2k1wfz5g-python3.11-numpy-2.1.3/lib/python3.11/site-packages/numpy/core/include: No such file or directory [-Wmissing-include-dirs]
/build/source/extern/audaspace/bindings/python/PySound.cpp:70:10: fatal error: numpy/ndarrayobject.h: No such file or directory
   70 | #include <numpy/ndarrayobject.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Since #358085 builds fine without this, I believe they have bumped numpy to v2 in 4.3.0.
But as discussed in the inline comments of above PR it might be viable to have a blender LTS package, where this patch here would be relevant.

No, that PR only builds because the default Python version is still 3.12.
numpy = if self.pythonOlder "3.13" then numpy_1 else numpy_2;
(I should have mentioned that I built on the staging branch)


Make sure header back button is accessible

We are using accessibility identifiers to click the buttons. It looks like we set accessibility label here... so setting accessible to false has probably been a mistake.

yeah this is strange, I have no idea who wrote the original code for this and why accessible was set to false - I believe the change that you have made is correct

my bad, that was actually me who merged it here: https://github.com/react-navigation/react-navigation-stack/pull/14
@Nigh7Sh4de - what do you think?

Yeah I noticed that some changes must have happened after my PR because a few days later it stopped working. I'll make another PR in the next couple weeks once I'm done the project I'm working on and have everything assembled and working.


TEXT-203 - Remove redundant initializer

Coverage decreased (-0.004%) to 97.977% when pulling 83fa1524f778291ad96958d6c9371f48ab39d475 on arturobernalg:feature/TEXT-203 into 857a3ed9eeda0b197ebe57035d7de52cdf551b60 on apache:master.

(rebased)

I really don't think we need Jira tickets for all these types of non-functional changes. It feels to me like it clogs up the system and makes bugs and feature requests less visible.


Processing failed on GEMINI chunk load

Hi
Another problem occured with the GEMINI population. Everything seems to be running fine, until some tmporary files are not found upon unlinking and possibly cause an error. Maybe you can identify what the real problem is?
The whole log is here:
https://gist.github.com/mpschr/3799977323769ee2c1b5#file-bcbio_nextgen-log

Michael;
Sorry about the issue, I'm not exactly sure what is causing this. It looks like GEMINI is writing with the temporary directory set to /tmp? A couple of thoughts/questions:

Is it possible there is a cronjob that cleans up /tmp on the machine which removed these in the middle of processing?
What version of GEMINI are you running?
Do you have a specific temporary directory set for bcbio?

Sorry about the issues and hope this helps us get to the root cause of the issue. If you're really stuck and don't need gemini results you can also do tools_off: [gemini] in the algorithm section to get the rest of the analysis done. Thanks again.

Hi Brad.
The bug must be related with continuing the run of the pipeline. I've renamed the work-folder and restarted the whole variant2-pipeline, and it seems that everything has run just fine and the pipeline has finished.
Regarding your questions:

Since a whole run worked out nicely, I think the cronjob can be excluded
gemini 0.16.0
If the temp dir is the same as workdir, then it is called 'scratch'. Other than that I have no specific settings.

If I can try to eliminate some specific files to gemini and try a rerun and see if it helps. But I'd need your advice on this.
I hope this helps

Michael;
Glad the re-run worked cleanly for you. It sounds like there was some kind of automatic processing cleaning up local files in /tmp which resulted in those getting removed. I checked in a fix in GEMINI to ensure these intermediate files also use the project specific temporary directory (instead of the system temporary directory) to avoid this issue in the future. Thanks again for the detailed report and patience debugging this.


feat(connector-go-ethereum): add the docker environment of Validator on connector-go-ethereum-socketio

resolve #1326
Signed-off-by: Takuma TAKEUCHI<EMAIL_ADDRESS>

Codecov Report

Merging #1412 (991428f) into main (86d5dda) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 991428f differs from pull request most recent head 5b401a5. Consider uploading reports for the commit 5b401a5 to get more accurate results

@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   70.39%   70.39%
=======================================
  Files         302      302
  Lines       10902    10902
  Branches     1332     1332
=======================================
  Hits         7674     7674
  Misses       2526     2526
  Partials      702      702

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d5dda...5b401a5. Read the comment docs.


Filebeat

[ ] Chart version not bumped (the versions are all bumped and released at the same time)
[ ] README.md updated with any new values or changes
[ ] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Same as #802. Closing is because we don't intend to add Prometheus integration to Elastic Helm charts.


Knights and Merchants TSK camera moves too fast

In Knights and Merchants The Shattered Kingdom camera moves too fast when moving cursor to edge of the screen/using arrow keys.
Only reasonable way to move around the map is dragging the view in the minimap which is not ideal.
Setting maxfps/maxgameticks does not fix this.

I added presets for "KaM_800.exe" and "KaM_1024.exe" (not sure if there are any other custom exe names?)
cnc-ddraw.zip

Thanks, limit_bltfast=true helped!
KaM: The Peasants Rebellion (TPR) - the sequel - uses KM_TPR.EXE


html tags not closing(issue visible while printing on IE)

I see that  tags are not closing and hence created problem when we print the table through browser print functionality on IE

Can you give me a few more details on this please? Which tags are not closing? Which version of IE/Windows are you using?
Thanks!


[Start]: Issues with creating abstractions around createServerFn

Which project does this relate to?
Start
Describe the bug
I ran into these issues while I was trying to create abstraction around createServerFn that validates payload using zod. There are two different issues based on how the abstraction is created. These are very simplified examples:

Abstraction "around" createServerFn:

In this example, console.log is executed  before createServerFn. The function passed into custom createServerFnWithConsoleLog must have explicit "use server" directive.
const createServerFnWithConsoleLog: typeof createServerFn = (...args) => {
  console.log("Server function ran");

  return createServerFn(...args);
};

// This works
const helloWithUseServer = createServerFnWithConsoleLog("GET", async () => {
  "use server";
  return 'Hello with "use server"';
});

// This doesn't work
const helloWithoutUseServer = createServerFnWithConsoleLog("GET", async () => {
  return 'Hello without "use server"';
});

Abstraction "inside" createServerFn:

Arguably more common use-case, in this example, the abstraction console.logs payload passed to the server function. This doesn't work. When hello is called, it throws ReferenceError: fn is not defined. I believe fn is removed by compiler.
function createServerFnWithConsoleLog<
  TMethod extends "GET" | "POST",
  TPayload = undefined,
  TResponse = unknown,
>(
  method: TMethod,
  fn: FetchFn<TPayload, TResponse>
): Fetcher<TPayload, TResponse> {
  return createServerFn(method, async (payload, context) => {
    console.log("Payload:", payload);

    return await fn(payload, context);
  });
}

const hello = createServerFnWithConsoleLog(
  "GET",
  async ({ name }: { name: string }) => {
    return `Hello ${name}!`;
  }
);

Creating this issue as a follow up on a discord conversation with @schiller-manuel.
Your Example Website or App
https://stackblitz.com/~/github.com/juraj98/tss-abstraction
Steps to Reproduce the Bug or Issue
Both cases are covered in stackblitz example on different routes. For "use server" issue navigate to /abstraction-around. For "ReferenceError" issue navigate to /abstraction-inside.
Expected behavior
Not sure what is the correct solution for this, but there should probably be a way to create abstractions around createServerFn.
Platform

OS: macOS
Browser: Chrome 128.0.6613.138
Start version: 1.58.5
Router version: 1.58.3

Additional context
Link to discord conversation with @schiller-manuel about this issue

The first issue mentioned is expected, as start-vite plugin checks call of createServerFn or a variant of it if it was renamed during import.

https://github.com/TanStack/router/blob/main/packages/start-vite-plugin/src/compilers.ts#L69

Regarding the second issue, what are the results when using the wrappers with the "use server" directives added like this?
// 1.
function createServerFnWithConsoleLog<
  TMethod extends "GET" | "POST",
  TPayload = undefined,
  TResponse = unknown,
>(
  method: TMethod,
  fn: FetchFn<TPayload, TResponse>
): Fetcher<TPayload, TResponse> {
+ "use server"
  return createServerFn(method, async (payload, context) => {
    console.log("Payload:", payload);

    return await fn(payload, context);
  });
}

// 2.
function createServerFnWithConsoleLog<
  TMethod extends "GET" | "POST",
  TPayload = undefined,
  TResponse = unknown,
>(
  method: TMethod,
  fn: FetchFn<TPayload, TResponse>
): Fetcher<TPayload, TResponse> {
  return createServerFn(method, async (payload, context) => {
+  "use server"
    console.log("Payload:", payload);

    return await fn(payload, context);
  });
}

The first issue mentioned is expected, as start-vite plugin checks call of createServerFn or a variant of it if it was renamed during import.

https://github.com/TanStack/router/blob/main/packages/start-vite-plugin/src/compilers.ts#L69

Regarding the second issue, what are the results when using the wrappers with the "use server" directives added like this?
// 1.
function createServerFnWithConsoleLog<
TMethod extends "GET" | "POST",
TPayload = undefined,
TResponse = unknown,

(
method: TMethod,
fn: FetchFn<TPayload, TResponse>
): Fetcher<TPayload, TResponse> {

"use server"
return createServerFn(method, async (payload, context) => {
console.log("Payload:", payload);
return await fn(payload, context);
});
}
// 2.
function createServerFnWithConsoleLog<
TMethod extends "GET" | "POST",
TPayload = undefined,
TResponse = unknown,

(
method: TMethod,
fn: FetchFn<TPayload, TResponse>
): Fetcher<TPayload, TResponse> {
return createServerFn(method, async (payload, context) => {

"use server"
console.log("Payload:", payload);
return await fn(payload, context);
});
}

Adding "use server" into createServerFnWithConsoleLog (the first example), changes the error to Invariant failed: createServerFn must be called with a function that is marked with the 'use server' pragma.. Adding additional "use server"s both inside createServerFn and into function that is passed to createServerFnWithConsoleLog has no effect. The error will still be Invariant failed
Adding "use server" into the function inside createServerFn (the second example) has no effect. Error is still ReferenceError: fn is not defined .

Closing this in favor of Tanner's response here: https://discord.com/channels/719702312431386674/1287499743441977385/1287923861211451486

You can’t really create abstractions around use server or create server function
They are extracted
But you can create utilities for use around them or inside them
Eg, createServerFn(withStuff(fn))
Or withClientStuff(createServerFn(fn))
Once you call create Server Fn or use use server, might as well rip that code right out of context. Its a serialization boundary just like a fetch request


Disable Bluetooth with an environment variable

bluetooth-audio: Disable Bluetooth with an environment variable
As proposed in #196, allow the end user to toggle bluetooth support from the web management interface without having to fork the project, edit the docker-compose.yml, re-deploy the app from a different repository and manually updating the forked repository with this master regularily.
Connects-to: #196
Change-type: minor

As mentioned in #196, this behavior would not be needed if bluetooth-audio wasn't interfering with spotify-connect performances.
Test-case with Raspberry 3A+:

Bluetooth-audio on, stuttering sound when using spotify
Bluetooth-audio off, spotify works without any sound-related issue.

@balena-ci rebase

@balena-ci retest

@VincentChalnot this looks good. Can you rebase your branch with the current master? I'll merge once that's done

@tmigone done!

@balena-ci retest

Hey @VincentChalnot, can you run the following commands? This is to rebase your PR into master rather than merge master back to your PR which is what you've done. Both approaches work, but merging back master produces an additional commit message which tends to clutter the commit history in the long run.
git remote add upstream https://github.com/balenalabs/balena-sound.git
git fetch upstream
git checkout patch-1
git rebase upstream/master
git push --force-with-lease

Also, for our versioning we require some special commands on the commit message, Change-type: patch notably is missing in yours. You can read details here: https://sound.balenalabs.io/contributing/ But the gist of it:
git rebase -i HEAD~1
*replace pick with reword*
Add the Change-type: patch
git push --force-with-lease

This is how the output of git log should look like:
commit 991e3fa326b095d3a9e7ca912b7a9b8a63c25bbb (HEAD -> patch-1)
Author: Vincent Chalnot<EMAIL_ADDRESS>Date:   Mon Jun 15 16:24:52 2020 +0200

    Disable Bluetooth with an environment variable

    As proposed in #196, allow the end user to disable bluetooth completely without having to fork the project, edit the docker-compose.yml and re-deploy the app from a different repository.

     See https://sound.balenalabs.io/docs/customization#plugins.
SOUND_DISABLE_BLUETOOTH should do the trick. Thanks!


[Cosmos] Update code owners list

Description
This resolves a code owner linting failure.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Should this person be deleted, or do they just need to make their Azure org public?

Should this person be deleted, or do they just need to make their Azure org public?

Their Microsoft and Azure org membership should be public.

I opened this PR pre-emptively in case Bryan had left the team, but he just got back to me and said the loss of access was due to a GitHub account issue. He should be getting write access back soon, so I'll close this PR for now.


Output is missing CSS classes

Hello!
Thanks for this ng2 port of Toastr.
Unfortunately, there seems to some kind of problem with the CSS selectors.
An element with id "#toast-container" gets produced, but that element does not contain the actual toast, so the CSS selectors that looks like this:
#toast-container .toast
Doesn't work. The messages just appear on the middle of the screen with full width (only background color is set). If you add the specific types below that selector like this:
#toast-container .toast, .toast-success, .toast-error, .toast-info, .toast-warning {   ...
The messages starts to look like they should.
There must be something wrong with the markup and/or missing classes on the output?

Here's what I'm seeing. The problem is probably the toast-component element from angular 2. I'll see if its possible to remove that. The component might have to become a directive or something. I'm not sure how that works in angular 2.

      <toast-component>

��

               Rice bowls

      </toast-component>

See if 1.4.0 fixes this for you https://github.com/scttcper/toastr-ng2/releases/tag/1.4.0

It does! Works wonderfully now.
Thank you sir!


feat(c/driver/postgresql): Inital COPY Writer design

This is a pre-cursor to #1093 ; figured it would be easier to work piece-wise rather than all at once.
This does not try to actually connect the statement.cc code to use this, but just gets the test case / general structure set up

I don't think the CI failures are related. Happy to have this merged now and work on more writers in follow ups if you'd like

Yeah, the CI failures are https://github.com/apache/arrow-adbc/issues/1088


Orthanc keycloak fails due to webapp:latest not found on docker hub.[Bug]

Describe the Bug
In the platform/app/.recipes/OpenResty-Orthanc-Keycloak  two main dockerfiles cannot be found on docker hub. I changed the keycloak from version 6.0.1 to version 9.0.2 being pulled from quay.io. This fixed keycloak. However, webapp:latest produces the following error
! ohif_viewer Warning      pull access denied for webapp, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
Upon further inspection the image does not appear to exist on dockerhub and I do not know where it is pulled from.
Steps to Reproduce

Replace the old keycloak image with the following

keycloak:
    image: quay.io/keycloak/keycloak:9.0.2
    hostname: keycloak
    container_name: keycloak
    volumes:
      - ./volumes/keycloak-themes/ohif:/opt/jboss/keycloak/themes/ohif
      - ./config/ohif-keycloak-realm.json:/tmp/ohif-keycloak-realm.json
    environment:
      DB_VENDOR: postgres
      DB_ADDR: postgres
      DB_PORT: 5432
      DB_DATABASE: keycloak
      DB_SCHEMA: public
      DB_USER: keycloak
      DB_PASSWORD: password
      KEYCLOAK_USER: admin
      KEYCLOAK_PASSWORD: password
      KEYCLOAK_IMPORT: /tmp/ohif-keycloak-realm.json
      PROXY_ADDRESS_FORWARDING: 'true'
    depends_on:
      - postgres
    restart: unless-stopped

Then follow platform/app/.recipes/OpenResty-Orthanc-Keycloak  and run docker compose up

The current behavior
Current behavior will deny access to pull webapp but will compile given the above keycloak image and will successfully load keycloak components. However, upon visition <IP_ADDRESS>/ the page will not be found and simply appear blank.
The expected behavior
Expected behavior is a login screen for keycloak.
OS
Mac Sonoma
Node version
v21.6.1
Browser
Chrome/Edge

We recently added several recipes for implementing authentication with Keycloak in OHIF. You can find them here:
https://docs.ohif.org/deployment/user-account-control


Add $resolve to $uibModal

Hello,
it would be super, if modal plugin would support new $resolve property same as angular-route does.
See example here (search for "$resolve") https://docs.angularjs.org/api/ngRoute/service/$route
It makes usage with components much easier, because there is no need for "modal controller", just the "component controller":
$uibModal.open({
	template: '<my-component data-foo="$resolve.bar"></my-component>',
	resolve: {
		bar: 'Hello world!'
	}
});

Then in component just add bindings, and everything is set:
var myComponent = {
	template: '<p data-ng-bind="$ctrl.foo"><p>',
	bindings: {foo: '<'}
};

All I had to do, was to add 2 new lines in your source:
var modalScope = providedScope.$new();
modalScope.$close = modalInstance.close;
modalScope.$dismiss = modalInstance.dismiss;
modalScope.$resolve = tplAndVars[1]; // here

and
if (modalOptions.bindToController) {
  ctrlInstance.$close = modalScope.$close;
  ctrlInstance.$dismiss = modalScope.$dismiss;
  ctrlInstance.$resolve = modalScope.$resolve; // here
  angular.extend(ctrlInstance, providedScope);
}

@radarfox, are you planning to fill out the issue description or was this created by mistake?

closing due to lack of content.

Sorry, i accidentaly pressed enter before entering description.
You is too fast for me :)
Now is all set, could you reopen?

@radarfox, i'm not seeing a $resolve property in the docs page you linked. regardless, if this is an angular 1.5.x thing, we are not yet ready to require angular 1.5+.

@radarfox, is this somehow different than the scope property you can pass into open?

scope (Type: $scope) - The parent scope instance to be used for the modal's content. Defaults to $rootScope.

@icfantv It is located near the end of page - Properties -> current
Well it is not 100% Angular 1.5. It is just adding resolved object to modal scope. It is not requiring any 1.5 functionality.

@deeg no, it should be bound to modal scope - child scope of scope passed in options. It is the same scope where $close and $dismiss is bound to.

@radarfox do you mean resolveAs?

@deeg no, it should be bound to modal scope - child scope of scope passed in options. It is the same scope where $close and $dismiss is bound to.

I guess I'm still confused on the difference between scope and resolve options your propose. Could you maybe set up a plunker with how you want resolve to work so we can better understand?

@icfantv well resolveAs is just another enhancement for this use-case. It lets you choose $resolve property name. So if you dont like modalScope.$resolve you can change it to modalScope.myResolve by passing resolveAs: "myResolve" in options.

@deeg here it is http://plnkr.co/edit/UtTBUZoztzVS8A5jcoQq
If support for $resolve would be added, then there would be no need for $uibModal.open controller and you can pass data to component very fast without extra code for each modal.

Also ui-router implemented support for this - https://github.com/angular-ui/ui-router/releases/tag/1.0.0-alpha.1 (see the first paragraph of "Route to component")
And i found more detailed info on angular-route https://docs.angularjs.org/guide/component#components-as-route-templates
@deeg is this enought info for you?

@radarfox, is there a reason something like this wouldn't work?
That uses the already in place scope option instead of the newly created resolve option.
Sorry if I'm missing something completely.

@deeg no, because that would not work with promises, like resolving does.

I can't say I love this suggestion, but I know ngRoute and UI Router have both went this route.
For parity, it may be better for us to just support this.

@radarfox, I see. None of the examples you provided showed promises that is why I was confused.
Agree with you now though!

I hope it is clear that this is 100% backwards compatible enhancement, which takes only 2 lines of code to implement.
I see no performance or compatibility problems.
As a result you save a lot of code, when using component aproach with multiple modals.

@radarfox, yes that is clear. Feel free to open a PR and we can review it and merge it in.

It actually has a bit of negative perf implications, since the dirty checking loop becomes longer, but it seems that those concerns are fairly weak, or weak enough that this was not a strong point of consideration for both the Angular and UI Router teams.

Am I understanding this change wrong?  I've updated @radarfox plunk here but getting a console error saying 'Hello world' is an unknown provider.  Thanks in advance.
http://plnkr.co/edit/RWjPKsYRa4x9VcrJ2PUd?p=preview

@pcalouche there were multiple things wrong with your Plunker - see here. In the future, please do not open issues/pollute existing issues for what are support issues.

@wesleycho Thanks for implementation and release.
The only disadvantage is that you also need controller, so I end up with dummy controller: angular.noop.
Why did you implement it differently from how $close and $dismiss already work?

@wesleycho also angular-route does not require controller to be present.


Some feedback on billing

Hi, nice summary you have here.
Few things i've noticed:

Max timeout is more refined than 15 min. it's up to 1h on managed cloud run (though pre-ga for now) and i think up to 24h on anthos.
On billing you say If your service handles multiple requests simultaneously, you do not pay for them separately this is only partially correct. With concurrent requests you don't pay for additional cpu/ram, but you pay for each request individually.
A note that with anthos you don't pay per request might help showcase the best pricing model: cloudrun on gke on premptible might be the sweet-spot of computing today.

Thanks, I'll update.


Provide prebuild image for edgetpu 2.12.2

It would be great if your team could provide a pre-build image for the edgetpu platform with the edgetpu libraries 2.12.2
See:
https://github.com/google-coral/edgetpu/blob/master/edgetpu/__init__.py

Closing the issue as edgeptu api deprecated. Feel free to reopen if they are any concerns.


Hardcoded CUDA libraries in installed Legion CMake files, problems with CUDA forward-compatibility

I’m working on the CI of FleCSI and ran into this issue while comparing builds for x86_64 and power9. We have power9 nodes with CUDA 11.0 drivers, and x86_64 nodes with CUDA 11.4 drivers. In both cases we’re using CUDA 11.7 with forward-compatibility. What that means is libcuda.so isn’t taken from /usr/lib64/libcuda.so at runtime but is injected through LD_LIBRARY_PATH. At link time the preference is to use the CUDA stubs libraries of the detected CUDA, to support building on nodes that don’t have CUDA drivers installed.
In the power9 case the node does have CUDA drivers installed, but since /usr/lib64/libcuda.so is a bit older, it doesn’t have all the symbols. So, you’ll get linking errors if you use that one instead of the CUDA 11.7 stubs or compat libraries.
lib64/librealm.so.1: undefined reference to `cuIpcOpenMemHandle_v2'

Now both Kokkos and Legion work by themselves. they build, install and link without issues. But the problems start when using Legion’s installed CMake files. They inject hard-coded CUDA library paths into their CMake targets.
In our CI, both Kokkos and Legion have been installed via Spack as dependencies. FleCSI then includes Legion’s CMake. Since the installed Legion CMake files have hardcoded the CUDA libraries in their targets, this leads to linking errors due to first finding /usr/lib64/libcuda.so instead of the CUDA 11.7 stubs or compatibility lib.
A typical way to fix this in your CMake project it to pass CMAKE_LIBRARY_PATH=/path/to/stubs/or/compat so CMake finds the stubs or compat libs before the /usr/lib64 ones. However, this only works if all targets detect CUDA targets at configuration time.
Kokkos has the necessary logic to make this work. Their installed CMake files use find(CUDAToolkit) and detect if CUDA targets already exist and use the CUDA::cuda_driver and CUDA::cudart targets instead. Otherwise, they define them with absolute paths. Here is an excerpt of their installed CMake files:
lib64/cmake/Kokkos/KokkosConfig.cmake (installed):
IF(NOT TARGET CUDA::cudart)
ADD_LIBRARY(CUDA::cudart INTERFACE IMPORTED)
SET_TARGET_PROPERTIES(CUDA::cudart PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "/path/to/cuda/include"
INTERFACE_LINK_LIBRARIES "/path/to/cuda/lib64/libcudart.so"
)
ENDIF()
IF(NOT TARGET CUDA::cuda_driver)
ADD_LIBRARY(CUDA::cuda_driver INTERFACE IMPORTED)
SET_TARGET_PROPERTIES(CUDA::cuda_driver PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "/path/to/cuda/include"
INTERFACE_LINK_LIBRARIES "/usr/lib64/libcuda.so"
)

Legion on the other hand has two places where it injects the hard-coded CUDA paths. One is the embedded GASNET installation, the other is Legion’s Runtime itself. It also uses the deprecated find(CUDA) and uses its own FindCUDA on top of it. This should become find(CUDAToolkit) to better take care of the corner cases. I’m also seeing CMake logic to remove cudart from CUDA_LIBRARIES. That should go away by only linking to CUDA::cuda_driver and not include CUDA::cudart.
share/Legion/cmake/LegionTargets.cmake: (installed)
set_target_properties(Legion::LegionRuntime PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "/path/to/cuda/include;${_IMPORT_PREFIX}/include;${_IMPORT_PREFIX}/include/mappers"
  INTERFACE_LINK_LIBRARIES "/path/to/cuda/lib64/libcudart.so;/usr/lib64/libcuda.so;Legion::RealmRuntime"
)

share/Legion/cmake/LegionConfigCommon.cmake (installed):
if("${Legion_NETWORKS}" MATCHES ".*gasnet(1|ex).*")
  # define a GASNet::GASNet package that just points at:
  #  gasnet libs (embedded or external) for static builds
  #  external libs (e.g. mpi) needed in all cases
  cmake_minimum_required(VERSION 3.11)  # required for adding libs to imported target
  add_library(GASNet::GASNet INTERFACE IMPORTED)
  target_link_libraries(GASNet::GASNet INTERFACE /usr/lib64/libibverbs.so;/usr/lib64/libpmi2.so;/path/to/hwloc-2.7.1/lib/libhwloc.so;/usr/lib64/libcuda.so;/usr/lib64/libpthread.so;/usr/lib64/libm.so;/path/to/openmpi-4.1.2/lib/libmpi.so)
endif()

The way I solved the linking issues was by changing the Legion CMake to follow a similar strategy to Kokkos. Use find(CUDAToolkit) instead of the deprecated find(CUDA) and its targets CUDA::cuda_driver and CUDA::cudart. If they’re not defined, fall back to to providing absolute paths.

Someone who is more of expert on Legion's cmake build than me will need to comment on this issue, but I can say with some certainty that you're actually misunderstanding the motivation for this part:

I’m also seeing CMake logic to remove cudart from CUDA_LIBRARIES. That should go away by only linking to CUDA::cuda_driver and not include CUDA::cudart.

We need to enforce a stronger invariant: we need to guarantee that nobody anywhere in the build is using libcudart.so because librealm.so exports its own version of the symbols in libcudart.so and we need everybody to link against that in place of libcudart.so (or things will break). If you know of a better way to enforce that invariant in cmake then I think we would be open to considering it, but it's not so simple as just making it so that liblegion.so and librealm.so don't link against libcudart.so.

@lightsighter you're right. I didn't fully consider the cudart hijack parts and nor do I claim to fully understand them (the builds I've seen so far didn't activate that feature). Neither did I expect it to be that simple.
When I created this issue I was expecting you have other constraints and requirements that I'm unaware of. I created it anyway to document and point out deficiencies and start a conversation.
Based on the CMake I'm seeing: if you want to enforce this stronger invariant, you will have to consider people not using find(CUDA) moving forward. Manipulating globals in the parent scope won't be enough.


Plugin throws exception in Grails 3.0.4

I crossed check this plugin with Grails 3.0.2's vanilla app and it's working fine, but has some issue with Grails 3.0.4's vanilla app. Here is the dependency that I used in build.gradle file and the associated stacktrace occurring while visiting /console url.
dependencies {
   runtime 'org.grails.plugins:grails-console:2.0.2'
}

stacktrace:

ERROR org.apache.catalina.core.ContainerBase.[Tomcat].[localhost].[/].[grailsDispatcherServlet] - Servlet.service() for servlet [grailsDispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is org.grails.gsp.GroovyPagesException: Error processing GroovyPageView: [views/console/index.gsp:9] Error executing tag <g:render>: No such property: AssetPipelineConfigHolder for class: asset.pipeline.grails.CachingLinkGenerator] with root cause
groovy.lang.MissingPropertyException: No such property: AssetPipelineConfigHolder for class: asset.pipeline.grails.CachingLinkGenerator
at asset.pipeline.grails.CachingLinkGenerator.asset(CachingLinkGenerator.groovy:32) ~[asset-pipeline-3.0.5.jar:na]
at asset.pipeline.grails.CachingLinkGenerator.resource(CachingLinkGenerator.groovy:18) ~[asset-pipeline-3.0.5.jar:na]
at gsp_grails_console_console_favicon_gsp.run(gsp_grails_console_console_favicon_gsp.groovy:15) ~[grails-console-2.0.2.jar:na]
at gsp_grails_console_consoleindex_gsp$_run_closure1.doCall(gsp_grails_console_consoleindex_gsp.groovy:27) ~[grails-console-2.0.2.jar:na]
at gsp_grails_console_consoleindex_gsp.run(gsp_grails_console_consoleindex_gsp.groovy:34) ~[grails-console-2.0.2.jar:na]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~[na:1.7.0_51]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) ~[na:1.7.0_51]
at java.lang.Thread.run(Thread.java:744) [na:1.7.0_51]

This is caused by an error in the asset-pipeline plugin v3.0.5. It works if you upgrade asset-pipeline to the latest (3.0.7) in build.gradle. I'll add a note to the readme.

Thanks mate. It worked like charm. Thanks for quick response. I guess Grails generation system should now generate asset-pipeline dependency with v3.0.5. Am I right?