Not able to configure correctly due to deleted slashes

Brief Issue Summary
Extension is not able to correctly configure. The path to compiler has its slashes removed.
Expected:

Press configure in extension tab
CMake is able to configure

Apparent Behavior:

Press configure in extension tab
CMake is not able to configure due to missing slash characters in compiler paths.

CMake Tools Log

[cmake] The C compiler identification is GNU 9.2.0
[cmake] The CXX compiler identification is GNU 9.2.0
[cmake] Check for working C compiler: D:/Programming/_.devenv/msys2_64/mingw64/bin/cc.exe
[cmake] Check for working C compiler: D:/Programming/_.devenv/msys2_64/mingw64/bin/cc.exe -- broken
[cmake] CMake Error at C:/devenv/_.Tools/Build_System/CMake/share/cmake-3.14/Modules/CMakeTestCCompiler.cmake:60 (message):
[cmake]   The C compiler
[cmake]
[cmake]     "D:/Programming/_.devenv/msys2_64/mingw64/bin/cc.exe"
[cmake]
[cmake]   is not able to compile a simple test program.
[cmake]
[cmake]   It fails with the following output:
[cmake]
[cmake]     Change Dir: D:/Programming/_Repos/lua-rtmidi/lua-rtmidi/build/CMakeFiles/CMakeTmp
[cmake]
[cmake]     Run Build Command(s):D:/Programming/_.devenv/msys2_64/usr/bin/ninja.exe cmTC_91c3f
[cmake]     [1/2] Building C object CMakeFiles/cmTC_91c3f.dir/testCCompiler.c.obj
[cmake]     FAILED: CMakeFiles/cmTC_91c3f.dir/testCCompiler.c.obj
[cmake]     D:\Programming\_.devenv\msys2_64\mingw64\bin\cc.exe    -o CMakeFiles/cmTC_91c3f.dir/testCCompiler.c.obj   -c testCCompiler.c
[cmake]     /bin/sh: D:Programming_.devenvmsys2_64mingw64bincc.exe: command not found
[cmake]     ninja: build stopped: subcommand failed.
[cmake]
[cmake]
[cmake]
[cmake]
[cmake]   CMake will not be able to correctly generate this project.
[cmake] Call Stack (most recent call first):
[cmake]   CMakeLists.txt:3 (project)
[cmake]
[cmake]
[cmake] Configuring incomplete, errors occurred!
[cmake] See also "D:/Programming/_Repos/lua-rtmidi/lua-rtmidi/build/CMakeFiles/CMakeOutput.log".
[cmake] See also "D:/Programming/_Repos/lua-rtmidi/lua-rtmidi/build/CMakeFiles/CMakeError.log".
[cms-driver] Error during CMake configure: [cmake-server] Configuration failed.

Platform and Versions

Operating System: Windows 7 Pro x64
CMake Version:  3.14.3
VSCode Version: 1.40.0-insder
CMake Tools Extension Version: 1.1.3
Compiler/Toolchain: GCC 9.2.0 (via MSYS2)

Other Notes/Information
MinGW-w64 (thru MSYS2) and MSYS2 are added to path in that order.
It does not matter if I select a kit or not. I have tried to edit the paths in the cmake-tools-kits.json files but it does not affect anything.
I can configure normally when using commandline tools.

Apparently there was a problem with ninja that caused the misbehavior. Installing and using the mingw-w64-x86_64-ninja version is the way to go.

Glad you were able to solve this!


Fix for Python 3.9's AST changes

cc @JelleZijlstra

CI is a bit unhappy (https://travis-ci.org/github/ambv/flake8-pyi) but it looks like false positives. Not sure why we don't see the same failures in typeshed's CI.

I could repro one of the failing tests when I tested with tox. Typeshed has moved past old versions of flake8 (https://github.com/python/typeshed/pull/4158), so we should drop this test. We still run unit tests with flake8<3.8.
I couldn't repro the test that failed on typeshed with flake8 3.8, even though all the version numbers seemed to line up. We'll see what Travis has to say now.
It's also a little unfortunate that flake8 version numbers currently very much coincide with Python version numbers....

Oh fun, now it looks like it only fails with Python<3.8.

Weird, I checked the logs and all the versions of deps that I would expect to matter (flake8, pycodestyle, etc.) match across the two runs. The pip versions are a little different but I'm not sure why that should matter.
Maybe just suppress F811 on 3.6/3.7 and be done with it?

I think the line numbers are different. I'll do something like that; the Python version isn't a part of the tox environment name which makes things a little annoying.

It works!


Highlight link for registration

Currently the link to registration (http://www.cvent.com/d/knqpjz) can be difficult to spot. Consider replacing with a larger centered button that says "Register" and in turn links through to the cvent page.

Stephanie added more prominent badges in https://github.com/acm-chil/acm-chil-website/pull/13. See the new register button on the front page for example: https://www.chilconference.org/

This is exactly what I had in mind! Thanks @corcra.


Improving format of enviroment_variables.md file

Coverage remained the same at 70.273% when pulling 6782fd042e7057ea399d4a4237917373d7e64936 on docs/env-var-md into 0cbf545602fd7c9dd165d15c3ac580463dd2c811 on master.


Package create time relative path issues using imports

Environment
Device and OS: Linux
App version: 0.27.0
Kubernetes distro being used: k3s, but really N/A here
Other: test works with 0.26.1
Steps to reproduce

Look at attached tar.gz for complete working example that completes successfully on 0.26.1 but fails on 0.27.0
Copy this to some arbitrary directory and extract
Run zarf package create

Expected result

Expect a package to be created

Actual Result
Failed to create package: unable to compose component test-component: unable to get child component: unable to fix composed filepaths (see visual proof for more details)
Visual Proof (screenshots, videos, text, etc)
0.26.1
[root@node1 ztest]# ./zarf_v0.26.1_Linux_amd64 package create --confirm

Using config file /root/ztest/zarf-config.toml

Saving log file to /tmp/zarf-2023-05-26-12-47-06-857083603.log

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

kind: ZarfPackageConfig
metadata:
  name: test-wrapper
  description: test outer wrapper
components:
- name: test-component
  required: true
  actions:
    onCreate:
      before:
      - cmd: tar czvf file.tar.gz -C "import" file.txt
        description: Process that ends up with a tar.gz
      after:
      - cmd: rm -rf file.tar.gz
        description: Cleans up
  files:
  - source: import/../file.tar.gz
    target: /tmp/remote_file.tar.gz
  ✔  Create Zarf package confirmed

  📦 TEST-COMPONENT COMPONENT

     file.txt
  ✔  Completed "Process that ends up with a tar.gz"
  ✔  Completed "Cleans up"
  ✔  Creating SBOMs for 0 images and 1 components with files.

0.27.0
[root@node1 ztest]# ./zarf_v0.27.0_Linux_amd64 package create --confirm

Using config file /root/ztest/zarf-config.toml

Saving log file to /tmp/zarf-2023-05-26-12-47-20-3120995904.log
     ERROR:  Failed to create package: unable to compose component test-component: unable to get child component:
             unable to fix composed filepaths: imported path import/###ZARF_PKG_TMPL_RELATIVE_DIR###/file.tar.gz
             does not exist

Severity/Priority
Additional Context
I know that this would work if I collapsed it into the wrapper. However, in the actual usage of this, we like to have a separate package created as well that doesn't include the other parts that get added to the outer wrapper that mainly imports. So this is a behavioral change and I am not certain if it is a bug or not but it also might be a teaching moment since maybe I am going about it wrong, please let me know if there is a better way. Bottom line, would like to have an imported zarf package create something that didn't previously exist and still have it be copied properly honoring any "before" actions that should take place before the files are looked at.
I have attached the setup for easy recreation.
zarf_test.tar.gz

You are correct @WeaponX314 . Before 0.27 you would have to use path hacking and variables (like your example) in order to use certain from imported components. In 0.27 this is no longer the case as actions and all imported resources are now properly relatively pathed from their source zarf.yaml. The following is how this behavior should work:
kind: ZarfPackageConfig
metadata:
  name: test-wrapper
  description: "test outer wrapper"

components:
  - name: test-component
    required: true
    import:
      path: import
      name: my-import-test

and
kind: ZarfPackageConfig
metadata:
 name: test-pkg
 description: "test creating something before copy"

components:
 - name: my-import-test
   actions:
     onCreate:
       before:
         - cmd: tar czvf file.tar.gz file.txt
           description: Process that ends up with a tar.gz
       after:
         - cmd: rm -rf file.tar.gz
           description: Cleans up
   files:
     - source: file.tar.gz
       target: /tmp/remote_file.tar.gz

However, you have properly identified that onCreate.before actions are run after import composition has run. During composition the filepaths of all resources are checked, and your example errors because the filepath is created after it is checked.
There are 2 paths forward I will bring up to the team:

Disable path checking during composition and wait for the copy operation to fail during create
Run onCreate.before actions during composition and ignore duplication of that action during create

I personally would advocate for #1 in this case.  It would be a faster fix and would have less of a chance to break other behavior.  I also updated the release notes to be more explicit about the change in behavior here.


Run python file from .tag file

Hi, is there an option to run python file from .tag file? Instead of writing the entire python code inside py begin and py finish tag.

Got the solution from issue #898.

Hi George, yes from below there are a few ways to run Python code from TagUI -
https://github.com/kelaberetiv/TagUI/issues/898#issuecomment-752827600
If most of the work to be done is already in Python, you can also use the RPA for Python package (wrapper for TagUI) -
https://github.com/tebelorg/RPA-Python

Hi George, yes from below there are a few ways to run Python code from TagUI -
https://github.com/kelaberetiv/TagUI/issues/898#issuecomment-752827600
If most of the work to be done is already in Python, you can also use the RPA for Python package (wrapper for TagUI) -
https://github.com/tebelorg/RPA-Python


http3: implement server idle timeout support

This update introduces the ability for an HTTP/3 server to enforce an idle timeout on connections. This timeout will trigger when no new requests are received on a connection, irrespective of any PING frames received at the QUIC level.

Is there anything analogous in HTTP/1.1 or HTTP/2?

Both http.Server and http2.Server have the exact same feature.

@marten-seemann what's your take on this PR?

I'll review this after the IETF week.

I'll give it a try. I'm not familiar with the test framework in use.

I'll give it a try. I'm not familiar with the test framework in use.

Sorry for that. We're planning to move away from Ginkgo (https://github.com/quic-go/quic-go/issues/3652), but it's a lot of work...
What I'm imagining is a test in integrationtests/self/http_test.go, where the server applies a short idle timeout. We can then verify that the client's second request fails (or is sent on a newly established connection). lmk if you run into any issues.

@marten-seemann I added an integration test, but I’m a little perplexed. The client connection being closed by the server should not be surfaced to the client’s caller, in my opinion. Isn’t this a bug in the client implementation?

@marten-seemann I added an integration test, but I’m a little perplexed. The client connection being closed by the server should not be surfaced to the client’s caller, in my opinion. Isn’t this a bug in the client implementation?

Good question. I think there might be a bug. We have some redialing logic here: https://github.com/quic-go/quic-go/blob/42f04d4e02205ee796d1fdec12bd2b46166e7cde/http3/roundtrip.go#L173-L187
But it doesn't take into account the HTTP/3 error at all. Maybe we need to allow automatic redialing on H3_NO_ERRORs? What do you think would be the right behavior?

I think any error or closing of the connection should be hidden from the client if it does not directly impact an existing stream.
I don’t think it should auto-redial on close/error. Otherwise, a long-running client would keep redialing connections to domains it interacted with once, without any guarantee it will interact again soon.
Rather, on stream creation, if the connection is unhealthy but still in the pool, it should then be redialed.
By the way, regarding the code you highlighted, I don’t understand how the connection would be closed if the returned error did not result in the connection being closed. Wouldn’t this lead to leaked connections being kept alive if keepalive is enabled at the QUIC level?

I think any error or closing of the connection should be hidden from the client if it does not directly impact an existing stream.

That depends on the type of error. If it's a protocol violation, either at the QUIC or the HTTP layer, we should definitely surface this error. The only errors we should hide are errors that are expected to happen in normal operation, such as idle timeouts, stateless resets, etc.

I don’t think it should auto-redial on close/error. Otherwise, a long-running client would keep redialing connections to domains it interacted with once, without any guarantee it will interact again soon.
Rather, on stream creation, if the connection is unhealthy but still in the pool, it should then be redialed.

That's how the code works. In the code I linked above, calling RoundTrip on a connection that has seen an idle timeout (for example), would return a net.Error.Timeout error, and we'd dial a new connection right away. All we need to do is extend this logic to also cover H3_NO_ERROR errors.

Sorry if I was not clear. Let me rephrase. By an error not impacting an existing stream, I mean an error that occurred before the stream was created. If the client discovers it later (i.e., at the next stream creation), it may retry without surfacing the error to the caller, but only if it is guaranteed that the request wasn’t written on the previous connection.
The existing condition to retry the request on net.Timeout is, in my opinion, dangerous. You have no way of knowing if the request was received by the server and then timed out, or if the connection had already timed out. This runs the risk of performing the request twice, which in some cases might be unexpected and dangerous if the request is not idempotent.
Regarding my question on the removeClient, can you please help me understand how the removed connection is ensured to be closed?

I think I agree with your argument. I opened #4612.
What do we still need to do here to get this PR across the finish line?

To me, the PR is good to go.
Let me know if I should open another issue or if there is another way to discuss removeClient behavior. I believe there is a potential issue here that is different from the issue you just opened. I might be missing something, so I’d love to pick your brain on this.

Let me know if I should open another issue or if there is another way to discuss removeClient behavior. I believe there is a potential issue here that is different from the issue you just opened. I might be missing something, so I’d love to pick your brain on this.

Please do!


Dynamic NeuroDesk badge

Discussed in https://github.com/orgs/NeuroDesk/discussions/372

Originally posted by marcelzwiers October 19, 2023
In my README file (which is shown as the entry point on GitHub, PyPi, and RTD) I display a few dynamic badges that inform the user about the status of the project, such as the CI status, the RTB build, but also the latest PyPi version (see here). The project is also included in NeuroDesk, and I would like to advertise that with a badge, showing the version of the most recent neurocontainer (and in green if it passes the tests or so). So something like this, but then dynamically:
https://img.shields.io/badge/NeuroDesk-v4.2.0-green

I know it's not very important, and as you can see I can do it statically myself. It's just a rainy afternoon task, and a nice PR goody :-)

Idea for implementing:

bage could be created automatically from Neurocontainers repository: https://github.com/NeuroDesk/neurocontainers/blob/master/.github/workflows/build-apps.yml


Adding .NET 6 installation to pipeline tasks to solve for Arcade builds

Arcade builds are failing .NET 6 Integration tests because they are now installing .NET 7 onto boxes instead of .NET 6. So, we need to forcefully (and side-by-side) install .NET 6 so these ITs can still execute.
This change adds a new build task that does this and so should unblock arcade builds.

This is fine for now to unblock arcade updates. @brandonh-msft could you file an issue in the backlog to get rid of hard-coded sdk installations in the build.yaml?


Extract common Icon  attributes

All <svg> elements shared five common attributes, which can be extracted into a common object using v-bind – except that the Search type didn’t have a fill=none attribute before. I assume this wasn’t intentional (or at least, there’s no discussion of it in #371), so it should be okay to add the attribute with this change. (There’s no snapshot to update for this case because there’s no snapshot specifically for the Search type.)

(There’s no snapshot to update for this case because there’s no snapshot specifically for the Search type.)

That feels like right the next thing we should fix. Probably by merging all those snapshot tests into a parametrized one that iterates over all the item types from iconProps.ts

Done in #578.


switch GEE backend to mmmgee

Use mmmgee::geem2() to fit GEE models instead of geeM::geem(), as it looks marginally faster based on simulations & includes a utility to perform a global Wald or score test based on a provided contrast matrix using mmmgee::mmmgee.test()

Actually not gonna do this, using mmgee::mcgee.test() is no faster / better than the current implementation I wrote in waldTestGEE() & I'd rather not add another dependency


Can Franz Become Portable App？

Sometimes i use WTG System Because im very care about my own privacy , also i want my own data on my control.
So can Franz provide portable setting？
I think if Franz can add portable mode maybe more people willing to try franz.
It is only my opinion , just a suggestion.

all good Windows utilities should be portable by default.


Tabs - Add possibility to display one tab

It would be nice to align them a little better. Tabs should fulfil wrapper, or when there are two of them should have the width for 50% of the wrapper.

It would be nice to align them a little better. Tabs should fulfil wrapper, or when there are two of them should have the width for 50% of the wrapper.

This task is the bugfix, needed in overwatch to show one tab properly.


Add Hoobs config schema for easy config

Add a configuration schema for Hoobs. Without this, editing JSON is required.

Hey - I'd be happy to add this config file to the repo. I don't run HOOBS myself, but if it works, feel free to re-raise or update the Pull Request.


c++ assignment willing to PAY

need a assignment done and will pay 15 bucks for anyone who can code this by midnight. Must follow the output .
Assuming there are no deposits other than the original investment, the balance in a savings account after one year may be calculated as,
amount = Principal  * (1 + Rate / T ) T
Principal is the balance in the savings account, Rate is the annual interest rate, and T is the number of times the interest is compounded during a year ( for example, T is 12 if the interest is compounded monthly), amount is the end balance in the savings account, interest is the different of principal from the amount
Write a program that asks for the account number, the full name of the account holder, the principal, the interest rate, and the number of times the interest is compounded. Then display the account information in a table format.
Hint: use setw() and setprecision() to display the output in a table format. All currency should be in two decimal digits. Include  library to use pow() function to calculate the amount.
Interest = amount - principal;

spam.


Create TaskBuilder and TypicalTasks for testing purposes

Codecov Report
Base: 49.80% // Head: 49.73% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (9bebb44) compared to base (c3b00d3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #167      +/-   ##
============================================
- Coverage     49.80%   49.73%   -0.08%
  Complexity      449      449
============================================
  Files           108      108
  Lines          2062     2065       +3
  Branches        228      228
============================================
  Hits           1027     1027
- Misses          981      984       +3
  Partials         54       54

Impacted Files
Coverage Δ

.../java/seedu/address/model/util/SampleDataUtil.java
16.66% <0.00%> (-3.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix dep warnings

This is mostly upgrading a couple of gems to silence deprecation warnings issued while running specs.  We also take the opportunity to modernise the rspec infrastructure (spec_helper vs rails_helper, don't allow monkey-patching, etc).

:+1:


Show function name when prompting user for sql binding type

This PR fixes https://github.com/microsoft/azuredatastudio/issues/19325

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 42.075%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/book/bookTreeView.ts
2
38.21%

Totals

Change from base Build<PHONE_NUMBER>:
-0.004%

Covered Lines:
27931

Relevant Lines:
62082

💛  - Coveralls


Change authentication type from email password to o auth

close #44

⚠ Caution
Jacoco is also including AuthRepository in its coverage report. Because of which, instead of getting coverage as 1, it is giving coverage ratio 0.4.  Because of which, I remove coverage ratio rule.


Update winit to 0.29.4

This PR updates our winit fork with the latest changes in 0.29.4.
Fixes #2113.
Fixes #2138.

Posting here for visibility:
This also fixes the reentrant mutex issue I reported a while ago.
However, after switching to this commit, requesting redraw/redrawing an image constantly makes the window redraw really slow. It's slower the bigger the window is. The Iced debug overlay doesn't show increased times when the issue happens so it's likely something outside of iced rendering.

I believe it's some sort of scheduling issue. There are no outliers in the flamegraph which corrosponds with iced's debug overlay not having increased times. Even the spinner example gets choppy sometimes now on the winit branch and it doesn't on the latest master.

Yeah please do this gets the window shadow drawn

No, in cargo tree it shows  sctk-adwaita is at 0.7.0.
sctk-adwaita at v0.8.0 has shadows.

No, in cargo tree it shows sctk-adwaita is at 0.7.0.
sctk-adwaita at v0.8.0 has shadows.

winit 0.29.4 depends on sctk-adwaita 0.8, so not sure what has happend in your case, perhaps try cargo update to bump your cargo lock

Nevermind that, I forgot that iced is using a fork of winit (that does not use 0.8 yet): https://github.com/iced-rs/winit/blob/3bcdb9abcd7459978ec689523bc21943d38da0f9/Cargo.toml#L163

Updating winit to work with sctk-adwaita > 0.8.0 require adding only 1 arguments like so


Xcoder as parser

I recently made some additions on the Xcoder gem to provide support for reading the remaining entities within a project file. I then added write support. Xcoder provides the functionality to generate everything up to and including targets. @rayh mentioned that you were interested in removing the parsing and saving functionality out of Vendor. This would be an answer.
Some examples of using Xcoder to add to an existing project:

Source
Source with System Framework
Source, Custom Framework, Build Settings

I don't believe my implementation of integration is absolutely thorough in providing the same experience the previous work performed. I likely have neglected to remove files when you previously felt that was necessary or made some other assumption. I would love for you to take a look at this pull and see what may be missing or absolutely necessary. I will make any of the necessary changes.
Until @rayh and I finish any conversations about the current merge, https://github.com/rayh/xcoder/pull/9, the commit in my repository burtlo/xcoder @ de183eeaf12fcd911ef6ad9c8df40d0af33d20dc, would likely be how you would need to verify it against a working Xcoder. Afterwards, another version of Xcoder would need to be released to coincide with a release of Vendor.

I noticed that there are some pull requests open that provide new features. I will attempt to include that functionality.
I also realized that the installation of any build settings of a library will automatically override any existing build settings.

I updated Xcoder to have support to append the build_settings information specified as of Xcoder version 0.1.7
I also made Xcoder configuration more aware of most of the common configuration settings to make it more intelligent with regard with setting, getting, and appending values. This would solve what pull #7 is attempting to resolve.


Add a notification to the start script to change the superpassword

This information is now included in the config and a "link" is written in the override_config. From my point of view this is sufficient.
Do you agree @dafoxia?


Unhandled promise rejection - due to domain change

Hi,
From few days I've got this exception while using node-red-satellites
"Unhandled promise rejection"
Ive solve it in loadRemoteTLEData - and change https://www.celestrak.com to  https://www.celestrak.org. After the change the problem has been solved.
Thanks

fixed in v0.7.5


[improve-#13053] in method of  execProcessInstance check startNodeList

Purpose of the pull request
in method of  execProcessInstance check startNodeList
Brief change log

#13053

Verify this pull request
This pull request is code cleanup without any test coverage.
this close :# 13053

Codecov Report

Merging #13057 (64d8212) into dev (2792c45) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #13057      +/-   ##
============================================
- Coverage     39.32%   39.31%   -0.02%
- Complexity     4275     4277       +2
============================================
  Files          1069     1069
  Lines         40180    40146      -34
  Branches       4611     4595      -16
============================================
- Hits          15801    15782      -19
+ Misses        22600    22584      -16
- Partials       1779     1780       +1

Impacted Files
Coverage Δ

.../org/apache/dolphinscheduler/api/enums/Status.java
100.00% <100.00%> (ø)

...cheduler/api/service/impl/ExecutorServiceImpl.java
44.46% <100.00%> (+1.06%)
:arrow_up:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-5.36%)
:arrow_down:

...eduler/api/dto/schedule/ScheduleCreateRequest.java
83.33% <0.00%> (-2.39%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/service/queue/TaskPriority.java
51.31% <0.00%> (-1.25%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.34% <0.00%> (-0.69%)
:arrow_down:

...he/dolphinscheduler/plugin/task/java/JavaTask.java
58.50% <0.00%> (-0.69%)
:arrow_down:

... and 26 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

useA and useB open same process definition，then useA delete a node and save。use b run the node that had been deleted。in method of buildflowdag will throw npe。above cause  master print a lot of log，The hard drive  ran out of space。finally you start any process instance will failed
---Original---
From: "Aaron @.>
Date: Sun, Dec 4, 2022 20:43 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [apache/dolphinscheduler] [improve-#13053] in method of execProcessInstance check startNodeList (PR #13057)
@Radeity commented on this pull request.
I wonder whether this check is needed? If userA delete a node, a new version of process is created. Meanwhile, userB want to execute the deleted node, if he runs the old version, there's no errors. So i think the right logic should be: if user do not update process instance, he should run the old version, instead, run the new version.
Also, this check brings additional overhead. WDYT?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

@caishunfeng @Amy0104 PTAL

LGTM of the backend part. Some nip:

done


Expo.Google.logInAsync error 12501 for release

I'm getting an error trying to authenticate with Google using my Android standalone app.
The error message is the following:
Status(statusCode=unknown status code: 12501, resolution=null)

I'm using
    "expo": "^15.0.2",
    "react": "~15.4.0",
    "react-native": "https://github.com/exponent/react-native/archive/sdk-15.0.0.tar.gz"

All other configurations work, except Android standalone.
I followed the steps for https://docs.expo.io/versions/v15.0.0/sdk/google.html this in my current app and in a fresh new one as well, obtaning the same result.
Some people is fixing the problem by creating a Web Client Id, which doesn't make any sense to me http://stackoverflow.com/questions/33583326/new-google-sign-in-android/37657942#37657942
Any advice? Things to try?
Thanks,
JM

Are you passing androidClientId to logInAsync? It needs to be a web client id (I know it's weird).

Hi @janicduplessis,
Yes, I'm passing androidClientId, and androidStandaloneAppClientId as well for release. The only scenario that doesn't work is androidStandaloneAppClientId.
If I use a web client id for androidStandaloneAppClientId, do I have to provide Authorized JavaScript origins and Authorized JavaScript origins?
I'm still debugging the issue. I'm trying to get OAuth to work in a standard Android App, signing it for release. I'm having some issues but I expect it to work and use the google-services.json to verify what I suppose Expo is generating (looking at the code that reads exp.json).
Is there a way to see the google-services.json Expo is generating?
Thanks you so much!
JM

Found the solution, after so much time spent.
behavior only works with web, and not with the default value system.
It's easy to reproduce, just follow the steps to configure a standalone android app. You'll see that only works for behavior equals web.
The documentation should be changed to reflect this fact.
Cheers,
JM

Moved to https://github.com/expo/expo/issues/69 to consolidate issues


Unable to bind to attached property on pointerover

<Style Selector="Button:pointerover /template/ ContentPresenter">
	<Setter Property="Background"
		Value="{Binding Path=(local:ButtonHelper.HoverBackground), RelativeSource={RelativeSource Self}}"/>
</Style>

<Button Content="Button"
	local:ButtonHelper.HoverBackground="Blue" />

I might be wrong, but "{RelativeSource Self}" in this binding will refer to the styled element - ContentPresenter.
If you want to bind to the button, the use {Binding $parent[Button].(local:ButtonHelper.HoverBackground)} (shorten syntax with $parent).

The code works, thanks.


settings_test is imported too late in the test suite

This is partially a django-nose bug, partially a Playdoh bug.  Currently, settings_test gets imported in setup_test_environment (the django-nose plugin) but settings / settings_local were imported earlier in manage.py.  This can lead to subtle bugs when Django is imported using settings_local.  For example, the cache backend timeout will be configured and settings_test cannot override this.  Ideally, settings_test should be imported in manage.py somehow before Django is imported.

I don't think this is an issue any more, is it? To confirm, I put a print statement in settings_test.py and settings/local.py
(pto)peterbe@mpb:~/pto$ ./manage.py test
SETTINGS/LOCAL
SETTINGS/LOCAL
nosetests --verbosity 1
SETTINGS_TEST
Reusing old database "test_pto". Set env var FORCE_DB=1 if you need fresh DBs.
..................................................................
----------------------------------------------------------------------
Ran 66 tests in 5.783s

OK

Now, why it imports settings/local.py is still an issue I haven't figured out yet.

Now, why it imports settings/local.py is still an issue I haven't figured out yet.

That's the 'imported too late' part ;)
local settings shouldn't be imported at all -- this causes subtle side effects like the cache backend configuration I mentioned.

I remember the discussion now. It's tricky. I use settings_test.py to assure that the cache is locmem and settings/local.py to set up the password to mysql. It'd be a shame if I had to configure the database twice. Ie. if we managed to NOT use settings/local.py during testing.
Don't mean to sound lazy but keeping your settings sane for predictable settings feels almost like a "people problem" rather than a hacking problem. And also, I fear the debugging if it's not obvious that anything you change in settings/local.py affects your breaking tests.


Why edit file once but emit workspace.onDidChangeTextDocument event twice

Reproduce:

reset all settings
run extension with following code
open chrome devtools
open a file and press a space
you will see two log

import vscode from 'vscode';

export async function activate(context: vscode.ExtensionContext) {
    const { subscriptions } = context;

    vscode.workspace.onDidChangeTextDocument(async ({ document, reason, contentChanges }) => {
        console.log('changeText', document.fileName, reason, contentChanges);
    }, subscriptions);
}

https://user-images.githubusercontent.com/41773861/201415979-64dcd17d-0d24-48f8-8cbb-822140206654.mov
Version: 1.73.1 (Universal)
Commit:<PHONE_NUMBER>f055b99068d3688932416f2346dd3b
Date: 2022-11-09T02:08:38.961Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.1.0
Sandboxed: No

Check the docs:
https://github.com/microsoft/vscode/blob/e2ad6b5e3bb41b009fe00a8846c319b32b9d7000/src/vscode-dts/vscode.d.ts#L12404-L12406

I think it would be more useful to provide a event named onDidChangeTextDocumentContent


Menu bar icon colors

Could we get an update to make the menu bar icon more in line with other defaults?

Thanks!

I believe the answer is something like:
image?.isTemplate = true


Fix npm warning on latest node

Remove engines setting as per angular-strap to squelch the following warning:
npm WARN engine<EMAIL_ADDRESS>wanted: {"node":"^0.10"} (current: {"node":"4.2.1","npm":"2.14.7"})

Not tested nor am I aware of whether this "engines" setting is useful at all.

Tried to work out the Travis failure, but I failed. Error is:
[00:45:24] 'ng:dist/styles' errored after 4.54 s
[00:45:24] Error: no writecb in Transform class
    at afterTransform (/home/travis/build/mgcrea/angular-motion/node_modules/factory-angular-channels/node_modules/gulp-less/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:95:33)


NO-JIRA: docs/openstack: clarify CLI

What this PR does / why we need it:
Add missing hypershift CLI and clarify why we need it.

/assign mandre

/approve


feat(web-terminal): impr README, add isWebTerminalAvailable util and fix some other small bugs

While fixing some sonarcloud warnings in #1023, I've tested the web-terminal plugin and found some small issues I would like to fix/improve with this PR:

Extend the README:

With information that an entity needs the kubernetes.io/api-server so that the Web Terminal work fine. It just does nothing before for entities that doesn't have this annotation.
Added more verbose information how to install the plugin (yarn add and some tsx examples)
Used the new isWebTerminalAvailable util in the examples.
Updated the app-config.yaml to the right path /webterminal/rest.

Added a isWebTerminalAvailable util function that test if the current entity has the kubernetes.io/api-server annotation so that it easy to hide the web terminal route or card.
In TerminalComponent:

The UI checked in an endless loop if the DevWorkspace is ready (Running). I've added a sleep between each retry to reduce the number of network calls. The sleep time goes a little bit up, but not above 5 seconds at the moment and stops after 5 minutes.
Added a warning message if the kubernetes.io/api-server annotation isn't used and the new gate keeper isWebTerminalAvailable isn't used. As said before, it just does nothing in that case.

Fixed a crash in TerminalComponent/utils/requests.ts because tries to access status but at least once it wasn't there, because the resource was just created.

https://github.com/janus-idp/backstage-plugins/assets/139310/c5e152ae-7645-492a-8860-78ef30c25f17
(I tested also that the terminal still starts.)

/cc @mimotej if you want to take a look

LGTM thanks!


Remove double spacing in rustdocs

Fixes #3761

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.925%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
20295

Relevant Lines:
24474

💛  - Coveralls

Needs rebase.

Might want to wait till the api files thing is sorted @jamillambert to save your self having to rebase this multiple times.


As editors we need to use Sanitys DAM to host PDF/EXCEL and certain illustration files (JPG/SVG)

Acceptance criteria

Editors can easily upload files to use in templates
Need to have a way to structure the assets to make it easy to find for editors when they are bot saving/uploading and navigating to the relevant file(s)
Sanity has smart folders. How does this work in practice? Tagging? Editors should have ability to fine grain 'file structure'

In order to ensure good quality we should (Keep the ones we need for this US)

[ ] Perform integration testing
[ ] Perform functional testing
[ ] Extra focus on usability
[ ] Test for portability
[ ] Test for accessibility
[ ] Create automated acceptance test/smoke test
[ ] Perform performance and load test
[ ] Perform user testing
[ ] Perform security testing

Set up a meeting with Sanity to figure out what is possible

Try out media plugin

@adneforslund @wenche
Comments from further testing:

No warning when uploading a new file with the same file name as an existing file – should be able to replace with a new updated file, or choose to keep both, or as version
File name on hover in preview doesn’t show the uploaded pdf's filename e.g. sustainability-report-2020-pdf https://cdn.sanity.io/files/h61q9gi9/production/ef021e175cd8561245314bf1fcf264d4e8a57bd3.pdf
Seems like file name isn’t what’s unique, but Sanity gives a new “internal url” per upload no matter what the file name is. Can we then replace a file?
Uploading in an article you don’t choose where to upload to (smart folder) and can’t see other files when uploading (e.g. editors wouldn't know if the file already exists, leading to duplication)
No version history or upload version
Drag and drop not working – even if it seems to be possible
No pdf preview – which is useful both for adding description and confirming it’s the correct file
No published time, only Last updated
No info on which user that has uploaded/published
No options to publish a file from Media view (nice to have, useful when replacing a file that is in use on several pages)

closing and created #536


Please invite me to the GitHub Community Organization

Name
Arnab Dey
Discord Username (if applicable)
No response
Additional Context
I want to join as a contributor of this Github open source community.

It's great having you contribute to this project
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Invitation sent for the GitHub Organisation. Welcome to the community 🎉#
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/jaidevstudio/people
Like this

Tips for practising:
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps

#Please check your email or organisation page


Select Operator By CRA Number

Currently Dashboard > Select Operator\Search by Canada Revenue Agency (CRA) Business Number has the following issues:

Error after clicking "Select Operator" causes radio button to default to Search by Business Legal Name
Return to Dashboard > Select Operator from Dashboard > Select Operator > ID  causes radio button to default to Search by Business Legal Name
IMO, I think the cra search should work as text search (experience with past users searching on ids)

Side note: We might consider refactoring the operator.py file as it currently has two endpoints named get_operator_by_legal_name_or_cra that are very similar. It would be better if we could merge them into one endpoint and return the value conditionally. Additionally, we need to ensure that each endpoint checks for the user's authorization before proceeding.

I think this is the same as https://github.com/orgs/bcgov/projects/122/views/2?pane=issue&itemId=53174092

Fixed. Closing as discussed during refinement.


Remove OapIndexInfo HeartBeat report

What changes were proposed in this pull request?
We collect OapIndexInfo and report it to driver as a HeartBeat,  then only print a log at driver side and no other use.  We need to consider other ways of collect index usage information.
How was this patch tested?
mvn test

@LuciferYang
LGTM overall

@zhixingheyi-tian thx for ur review


[CORE][MINOR] Correct the comment to show heartbeat interval is configurable

What changes were proposed in this pull request?
Executor heartbeat interval is configurable by "spark.executor.heartbeatInterval". But in a comment, heartbeat interval is presented as a constant 10s. This pr tries to correct the description.
How was this patch tested?
Existing unit tests.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8942/
Test PASSed.

Test build #103531 has started for PR 24101 at commit b629da6.

Test build #103531 has finished for PR 24101 at commit b629da6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103531/
Test PASSed.

Merged to master

Thanks for view and merging. @srowen


Introduce ninechronicles-staked-and-dcc [ninechronicles-staked-and-dcc]

This PR adds a new strategy using Nine Chronicles's staked assets.

Since Nine Chronicles has its own mainnet other than Ethereum or other evm-compact chains, it needs some GrpahQL requests, and a block hash as a parameter to specify the point of snapshot time on that chain. [^1]
I'm pretty new to snapshot strategies. so, there may be wrong codes or additional corrections to be made. please let me know.

[^1]: I also think it's a little bit weird and I might revise this version with a snapshot mapper in near future. :sweat_smile:

@ChaituVR Thanks for the fixings! I updated this branch by merging. PTAL.


[WIP] Manifest

Motivation and context

Reducing task creation time for some case
Unified way of working with different data types with prepared meta
Helps to work with remote sources in the future:

validity of the received data
reducing of traffic between data storage and server

How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage decreased (-0.2%) to 70.844% when pulling cbe10667b11d20ca6751a4c65211eb16e81a8676 on mk/manifest into 6f1246bcd59f036262be94e5ec40cd3702c4cedc on develop.

@dvkruchinin Could you please take a look at pylint check? It was failed for a reason.

Could you please take a look at pylint check? It was failed for a reason.

Sure. I`ll take a look.

@azhavoro I have prepared a PR #2858 to solve this error.

Please also update .coveragerc at line 8

@Marishka17 , comments about the command line:

Let's make dataset_directory positional arugment as an option --output-dir with the current directory as its default value.
Don't analyze the whole video to print a warning about force. Need to adjust the strategy.
Need a progress bar. For long videos users will not understand what is going on. Let's do that in the PR. Let me know if it takes too much time to implement.

tqdm library can help with progress bars.


webdav file system requires context to open files

After this commit https://github.com/golang/net/commit/4bb47a1098b37d69980d96237e2ae4ff56bb5a95 it's going to be required to send context. At the very minimum opening files needs to be sent context.Background().

Updated, thanks for the notice.
https://github.com/UnnoTed/fileb0x/commit/ef153a030ac18be8597c1387b6dbf62b06c21ebe


Added contextual menu scene

This adds the base for a contextual menu. It has to be extended to work both in combat and in other contexts (i.e. open the inventory and what not)
Still does not close #65 because it's not working on the combat scene yet

Merging straight this time as I'm looking to finish this + the battle end UI by the end of the week


Build error around RTCRtpTransceiver

Hi, I've been trying to use this plugin on iOS and then I got error like shown below.
Even when I run example code, I got same error.
Are there any solutions for this??
How to reproduce
Run example code of the repo.
What I tried, but it didn't work

Delete caches

Delete .pub-cache/hosted folder
flutter clean
Delete Pod folder and Podfile.lock

Error
Xcode's output:
↳
    /Library/flutter/.pub-cache/git/flutter_janus_client-00ce6cd96969ee654b9aaa9e2dbfaa54ca4eb384/lib/janus_client.dart:334:18: Error: The method 'firstWhere' isn't defined for the class 'Future<List<RTCRtpTransceiver>>'.
     - 'Future' is from 'dart:async'.
     - 'List' is from 'dart:core'.
     - 'RTCRtpTransceiver' is from 'package:flutter_webrtc/src/interface/rtc_rtp_transceiver.dart' ('/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_webrtc-0.5.8/lib/src/interface/rtc_rtp_transceiver.dart').
    Try correcting the name to the name of an existing method, or defining a method named 'firstWhere'.
                    .firstWhere((element) => element.receiver.track == event.track);
                     ^^^^^^^^^^
    /Library/flutter/.pub-cache/git/flutter_janus_client-00ce6cd96969ee654b9aaa9e2dbfaa54ca4eb384/lib/janus_client.dart:344:18: Error: The method 'firstWhere' isn't defined for the class 'Future<List<RTCRtpTransceiver>>'.
     - 'Future' is from 'dart:async'.
     - 'List' is from 'dart:core'.
     - 'RTCRtpTransceiver' is from 'package:flutter_webrtc/src/interface/rtc_rtp_transceiver.dart' ('/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_webrtc-0.5.8/lib/src/interface/rtc_rtp_transceiver.dart').
    Try correcting the name to the name of an existing method, or defining a method named 'firstWhere'.
                    .firstWhere((element) => element.receiver.track == event.track);
                     ^^^^^^^^^^
    /Library/flutter/.pub-cache/git/flutter_janus_client-00ce6cd96969ee654b9aaa9e2dbfaa54ca4eb384/lib/Plugin.dart:321:50: Error: The getter 'length' isn't defined for the class 'Future<List<RTCRtpTransceiver>>'.
     - 'Future' is from 'dart:async'.
     - 'List' is from 'dart:core'.
     - 'RTCRtpTransceiver' is from 'package:flutter_webrtc/src/interface/rtc_rtp_transceiver.dart' ('/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_webrtc-0.5.8/lib/src/interface/rtc_rtp_transceiver.dart').
    Try correcting the name to the name of an existing getter, or defining a getter or field named 'length'.
            if (transceivers != null && transceivers.length > 0) {
                                                     ^^^^^^
    /Library/flutter/.pub-cache/git/flutter_janus_client-00ce6cd96969ee654b9aaa9e2dbfaa54ca4eb384/lib/Plugin.dart:322:24: Error: The method 'forEach' isn't defined for the class 'Future<List<RTCRtpTransceiver>>'.
     - 'Future' is from 'dart:async'.
     - 'List' is from 'dart:core'.
     - 'RTCRtpTransceiver' is from 'package:flutter_webrtc/src/interface/rtc_rtp_transceiver.dart' ('/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_webrtc-0.5.8/lib/src/interface/rtc_rtp_transceiver.dart').
    Try correcting the name to the name of an existing method, or defining a method named 'forEach'.
              transceivers.forEach((t) {
                           ^^^^^^^
    /Library/flutter/.pub-cache/git/flutter_janus_client-00ce6cd96969ee654b9aaa9e2dbfaa54ca4eb384/lib/Plugin.dart:385:52: Error: The getter 'length' isn't defined for the class 'Future<List<RTCRtpTransceiver>>'.
     - 'Future' is from 'dart:async'.
     - 'List' is from 'dart:core'.
     - 'RTCRtpTransceiver' is from 'package:flutter_webrtc/src/interface/rtc_rtp_transceiver.dart' ('/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_webrtc-0.5.8/lib/src/interface/rtc_rtp_transceiver.dart').
    Try correcting the name to the name of an existing getter, or defining a getter or field named 'length'.
              if (transceivers != null && transceivers.length > 0) {
                                                       ^^^^^^
    /Library/flutter/.pub-cache/git/flutter_janus_client-00ce6cd96969ee654b9aaa9e2dbfaa54ca4eb384/lib/Plugin.dart:386:41: Error: The type 'Future<List<RTCRtpTransceiver>>' used in the 'for' loop must implement 'Iterable<dynamic>'.
     - 'Future' is from 'dart:async'.
     - 'List' is from 'dart:core'.
     - 'RTCRtpTransceiver' is from 'package:flutter_webrtc/src/interface/rtc_rtp_transceiver.dart' ('/Library/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_webrtc-0.5.8/lib/src/interface/rtc_rtp_transceiver.dart').
     - 'Iterable' is from 'dart:core'.
                for (RTCRtpTransceiver t in transceivers) {

Environment
flutter doctor -v
    • Flutter version 2.0.0 at /Library/flutter
    • Framework revision 60bd88df91 (13 hours ago), 2021-03-03 09:13:17 -0800
    • Engine revision 40441def69
    • Dart version 2.12.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/wakkihaya/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • iPhone SE (2nd generation) (mobile) • DB2D7F50-F4A9-4D90-819E-76BBC6BB51C4 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 89.0.4389.72

Yes i am aware of this issue for the time being i would advise you to try development_st branch since master isn't in stable state also work is in progress for development of version 2 of the Janus client which would be more organized more testable and maintainable

Or alternatively you could try release 0.04

Thank you for the quick reply! I see. I'll try it in the different branch.

https://github.com/shivanshtalwar0/flutter_janus_client/issues/11#issuecomment-744073823
Check this

Got it. Thanks!


validation fails - file transform source cannot be resolved

why is the validation failing in this case? what am I missing?
import os
import PyOpenColorIO as OCIO

os.environ['SHOT_CDL_PATH'] = 'c:/temp/a.cdl'
os.environ['SHOT_LUT_PATH'] = 'c:/temp/a.lut'

config = OCIO.Config.CreateRaw()

config.addSearchPath('search_path')

config.addEnvironmentVar('SHOT_CDL_PATH', '${SHOT_CDL_PATH}')
config.addEnvironmentVar('SHOT_LUT_PATH', '${SHOT_LUT_PATH}')

config.addColorSpace(OCIO.ColorSpace(name='foobar', family="Project", bitDepth=OCIO.BIT_DEPTH_F32, isData=False,
            description='test', allocation=OCIO.ALLOCATION_UNIFORM, allocationVars=[-0.249136, 1.468],
            fromReference=OCIO.GroupTransform([
                OCIO.FileTransform(src='${SHOT_CDL_PATH}', cccId='0', direction=OCIO.TransformDirection.TRANSFORM_DIR_FORWARD),
                OCIO.FileTransform(src='${SHOT_LUT_PATH}', interpolation=OCIO.Interpolation.INTERP_TETRAHEDRAL, direction=OCIO.TransformDirection.TRANSFORM_DIR_FORWARD)
            ])
        ))

config.validate()

it fails to resolve the env var for some reason:
Exception: Config failed validation expanding file transform paths. The file transform source cannot be resolved: '${SHOT_CDL_PATH}'.

It looks like when config.addEnvironmentVar is called, the internal environment variable lookup is reset with the default value provided (here the syntax to indicate none), so that later validate call can’t see the original value assigned with os.environ. You could do this before calling validate to refresh the lookup map:
config.setEnvironmentMode(OCIO.ENV_ENVIRONMENT_LOAD_PREDEFINED)
config.loadEnvironment()


C#: Introduce RemoteFlowSink class

This PR adds the class RemoteFlowSink as an abstraction of any data flow node that can be read by an external user. This currently means:

Any node that is also an XSS sink (including unencoded HTML output).
Emails contents.
Writes to cookies.
Writes to (Inner)Text properties of objects belonging to System.Web.UI, that is, possibly implicitly HTML encoded output (which, in particular, is not relevant for the XSS queries).

RemoteFlowSink is used as sinks for the queries cs/sensitive-data-transmission and cs/information-exposure-through-exception.
Note for review: I moved some existing sources and sinks into security/dataflow/flow{sinks,sources} to keep things consistent, so this PR is best reviewed commit-by-commit.

Differences job: https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/69/


Actually use the cache service

@nvdk I'm not sure about hitting the cache for file entries, in GN we don't do that for example, can you verify?

merged and bumped mu-cl-resources bugfix version
also bumped mu-auth as that is required for mu-cl-resources 1.22
seems we have a broken config on master
HOWEVER: this setup also doesn't work, getting 500s when trying to publish statements, I'll investigate for a little bit


PgAdmin and server mode

I've been working on setting up a postgres+jupyterlab image, and this repo has been the gift that keeps on giving, so thanks for all the hard work @psychemedia and @manics!
I'm looking at some of the archaeology of your efforts to get pgadmin4 running, and I see that at some point you stopped trying to disable SERVER_MODE. As I'm going through the same contortions right now, I thought I'd ask about it here. Is there a reason you couldn't get SERVER_MODE=False working? I'd like to avoid an additional user login if at all possible. Also, why did you start serving the application with gunicorn rather than its built-in server?
Any insight would be appreciated.

All I remember is that the obvious things that you've mentioned didn't work.
This was a while ago though, the current pgadmin release is v4.12 so things might have improved

The heavy lifting was all done by @manics so I can't really add anything... I note the update of pgadmin though and will try to check that this repo / build gets updated to reflect that.

Thanks for the info @manics and @psychemedia.
I spent some time running this down yesterday -- I was able to get past most of the issues with running the application in desktop mode, but then found this code to be a blocker. The logic around customizing the base URL for server requests is only enabled in SERVER_MODE.
I can see two possible ways around this:

Figure out some way to pre-authenticate the webapp to bypass the login screen. A brief look through the codebase didn't furnish an obvious way to do this.
Patch the above code so that the logic is also available in non-server mode. Not sure if that would work, but worth a shot.

@ian-r-rose is your code public yet?

The work is going on here, though I haven't pushed the branch with pgadmin yet. I think I can get option (2) above working, and when I do I'll also submit a PR here.

Option (2) also has the big, blinking caveat that it is a workaround for a real security feature, so should only be used with a local server, or if there is another authentication method in the mix (such as JupyterHub).

I also have a spin on this repo that sets up PostGIS: https://github.com/ian-r-rose/binder-postgis

Okay, here is a PR that adds pgAdmin support to a JupyterLab image:
https://github.com/CityOfLosAngeles/citywide-jupyterhub/pull/53/files

A couple of other comments about tricky parts:

Here is the part where I tricked pgadmin into using the base URL of the notebook server. It's unfortunate that this is not configurable, but here we are.
This was very tricky to figure out, and took some time in the browser debugger setting breakpoints and de-minifying code: you cannot have window.opener set, as pgAdmin makes some (terrible, IMHO) assumptions about who referred the link. So any link that you set pointing to the application must have rel='noopener' set.

A couple of other comments about tricky parts:

Here is the part where I tricked pgadmin into using the base URL of the notebook server. It's unfortunate that this is not configurable, but here we are.
This was very tricky to figure out, and took some time in the browser debugger setting breakpoints and de-minifying code: you cannot have window.opener set, as pgAdmin makes some (terrible, IMHO) assumptions about who referred the link. So any link that you set pointing to the application must have rel='noopener' set.


python3: plugin transmission: 'bytes' object has no attribute 'encode'

Just realized its not downloading anything because transmission is also crashing.
2016-04-22 07:40 CRITICAL task          download-series-rss BUG: Unhandled error in plugin transmission: 'bytes' object has no attribute 'encode'
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/flexget/task.py", line 443, in __run_plugin
    return method(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/flexget/plugins/plugin_transmission.py", line 298, in on_task_output
    self.add_to_transmission(self.client, task, config)
  File "/usr/lib/python3.5/site-packages/flexget/plugins/plugin_transmission.py", line 402, in add_to_transmission
    filedump = base64.b64encode(f.read()).encode('utf-8')
AttributeError: 'bytes' object has no attribute 'encode'

are you running from git?

no, from pip
2.0.0b8

ok, i just pushed a new version. give that a go

2016-04-22 13:33 CRITICAL task          download-series-discover BUG: Unhandled error in plugin transmission: endswith first arg must be bytes or a tuple of bytes, not str
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/flexget/task.py", line 443, in __run_plugin
    return method(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/flexget/plugins/plugin_transmission.py", line 298, in on_task_output
    self.add_to_transmission(self.client, task, config)
  File "/usr/lib/python3.5/site-packages/flexget/plugins/plugin_transmission.py", line 403, in add_to_transmission
    r = cli.add_torrent(filedump, 30, **options['add'])
  File "/usr/lib/python3.5/site-packages/transmissionrpc/client.py", line 392, in add_torrent
    if torrent.endswith('.torrent') or torrent.startswith('magnet:'):
TypeError: endswith first arg must be bytes or a tuple of bytes, not str

yeah, fixing that. I made a mistake.

try now.. upgrade

Same thing :(
Even uninstalled and installed, checked no pyc files in install dir and deleted db
2016-04-22 14:20 CRITICAL task          download-series-rss BUG: Unhandled error in plugin transmission: endswith first arg must be bytes or a tuple of bytes, not str
2016-04-22 14:20 CRITICAL manager       download-series-rss An unexpected crash has occurred. Writing crash report to /home/kurushi/.flexget/crash_report.2<IP_ADDRESS>032030564.log. Please verify you are running the latest version of flexget by using "flexget -V" from CLI or by using version_checker plugin at http://flexget.com/wiki/Plugins/version_checker. You are currently using version 2.0.0b11
2016-04-22 14:20 DEBUG    manager       download-series-rss Traceback:
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/flexget/task.py", line 443, in __run_plugin
    return method(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/flexget/plugins/plugin_transmission.py", line 298, in on_task_output
    self.add_to_transmission(self.client, task, config)
  File "/usr/lib/python3.5/site-packages/flexget/plugins/plugin_transmission.py", line 403, in add_to_transmission
    r = cli.add_torrent(filedump, 30, **options['add'])
  File "/usr/lib/python3.5/site-packages/transmissionrpc/client.py", line 392, in add_torrent
    if torrent.endswith('.torrent') or torrent.startswith('magnet:'):
TypeError: endswith first arg must be bytes or a tuple of bytes, not str

i'll take another look, don't have transmission to check..
feel free to join us at http://github.com/Flexget/Flexget

hmm, what version are you on?

it says there in the log
2.0.0b11

Hmm, i think this might be a bug with transmissionrpc
https://bitbucket.org/blueluna/transmissionrpc/issues/81/py3-typeerror-endswith-first-arg-must-be

I took a peek, looks like transmissionrpc is expecting text for that parameter, no mater whether it's a filename or a dump. That doesn't really make sense to me.... but it does explain the behavior.


Pet stats cleanup

This PR cleans up pet-stats, using getValue() everywhere and also:

Fixes wrong maxTier for flying fish
Removes modifyArmor, modifyWeapon and modifyStats (backend stats deprecated in frontendstats PR)
Adds a generateDebugPets(type) function very useful when adding new pets or debugging them (every time I have to add a new pet I had to write temp code for this so this time I just decided to write a function for it)
Fixes plenty of outdated pet perks like:

Bat 2nd perk had inverted intel and speed values
Bingo stats health and strength changed
Lion 1st perk was missing strength part
Magma Cube 2nd perk had wrong mult
Turtle first perk multiplier/formula
Zombie all perks multipliers
Flying Fish 1st perk multiplier
Jerry multipliers
Skeleton epic multiplier
and more...

Updated getValue() function so that now it takes the rarity (int) as first argument and an object of rarity: value as second parameter.
So now you can do stuff like getValue(this.rarity, { rare: 0.8, epic: 1 }) and it will return:
0.8 for rare
1 for epic
1 for legendary
0.8 for common and uncommon (if a lower rarity value is missing it takes the first value in the object)
FYI: I tried to test this as much as possible with in-game pets I have or from /ah, but I couldn't find ALL the pets... for some of them I'm trusting hypixel wiki values (which are wrong in some cases)...
Especially for Bingo pet I'm trusting hypixel wiki, but next time Bingo comes up I'll double check with in-game screenshots

bump 👀


Sign released binary

Please kindly sign released binary.
It seems that textlint.app has no missing sign (I used https://github.com/textlint/textlint-app/releases/download/v1.4.1/textlint-app-1.4.1-mac.zip).
Because of this, I cannot install it by Gatekeeper to my machine due to the firm's security policy.

I don't have an account for Apple Developer Program.
So, I can't sign to this app.

Code Signing | Electron

From the security point of view, it is generally necessary that the application of macOS be one of the following settings.

App Store
App Store and indicated developers

https://support.apple.com/ja-jp/HT202491
Because you take cost, I can not say it, but I think it is a very useful application.
Therefore I hope that you sign if possible.


no items defined to be installed

which ends a build for my rpm package with:
 make: *** No rule to make target 'install'.  Stop.

Please advice which targets should be installed where. Thank you in advance

as a small addition:
definition so versions for all the shared libraries that are being build would be awesome

This is probably a duplicate of https://github.com/abseil/abseil-cpp/issues/111, but I let @JonathanDCohen, who is working on cmake support, and @mbxx who is working on the LTS release comment. It seems like solving this should have been a prerequisite for the LTS release.

I'm afraid I don't understand what being requested here, probably because I haven't worked on cmake which I'm inferring this has something to do with, but I'm happy to comment on the LTS branch.
Abseil is looking into adding support for shared libraries, but that's not something our code was designed for, so we don't officially support it yet.  The most likely outcome is we'll support building shared libraries from the LTS branches as long as those libraries are loaded once and not unloaded.  In this case, we'd add .so build targets to future LTS branches (but not to Abseil at head).

It seems like the initial comment was cut off at the beginning.  Installation support hasn't been added yet, but it will come soon.

Even if you dont have shared libraries yet: things that could be installed
headers and needed source files to /usr/include/abseil-cpp
maybe a cmake finder installed into /usr/share/cmake.
pkgconfig files might also be good. for support finding with non cmake build systems.

Hi darix

headers and needed source files to /usr/include/abseil-cpp

Shouldn't it be /usr/include/absl?

I have no preference regarding the path. I will just query it via the pkg-config file and be done with it.

It is generally a good idea to put them so that they are NOT picked by default unless you actually specify their path via -I/-isystem.

@LebedevRI Why?
I think cmake has defaults for this.

Same reason why some buildsystems have airgapped mode, with all the explicitly specified dependencies being copied into special 'chroot' to ensure that all the deps are explicitly specified,
and nothing not specified is not being used. (the strictness may wary)

If you don't want the standard include path, specify another include path...

Circling back after a while, https://github.com/abseil/abseil-hello has the supported way to use abseil with cmake.  This is also a duplicate of #111, so I will close it and direct everyone there.


init.py is handled differently than python files in the same path

Environment data

Language Server version: 2022.6.0
OS and version: Win 10 Pro 21H2
Python version: Python x64 3.9.12 (from python.org)

Code Snippet
\\someserver\someshare\someworkspace\someproject\.vscode\settings.json
{
    "python.analysis.extraPaths": [
        "\\\\someserver\\someshare\\someworkspace\\someproject\\pythonlibs",
        "\\\\someserver\\someshare\\someworkspace\\pythonlibs",
    ],
}

\\someserver\someshare\someworkspace\someproject\pythonlibs\somepackage\__init__.py
from mymodule import myfunction

\\someserver\someshare\someworkspace\someproject\pythonlibs\somepackage\somemodule.py
from mymodule import myfunction

Note: mymodule lives in: \\someserver\someshare\someworkspace\pythonlibs
Repro Steps
If I add a workspace specific extrapaths statement in settings.json (as above), the __init__.py throws a reportMissingImports error, but the somemodule.py in the same path does not throw the reportMissingImports error.
Workaround
When I add the extraPaths statement to the user profile settings.json, the reportMissingImports error for __init__.py goes away, but ultimately, I only want to add this specific extraPath for the workspace I am working on.
I wouldn't have assumed that __init__.py would be treated differently than other python files in the same folder.
P.S. I love pylance, and thank you for all the work that's been done on it!!!

I'm not able to repro the problem you're seeing.
Are you using a multi-root workspace? If so, what are the root directories? I'm assuming that someproject and pythonlibs are the roots.
Let me make sure I have the repro steps correctly. I've created a new workspace. Within that workspace, I create the following:
# someproject/pythonlibs/somepackage/__init__.py
from mymodule import myfunction

# someproject/pythonlibs/somepackage/somemodule.py
from mymodule import myfunction

# pythonlibs/mymodule.py
def myfunction():
    pass

// .vscode/settings.json
{
    "python.analysis.extraPaths": [
        "../someproject/pythonlibs",
        "../pythonlibs"
    ]
}

Note that you should generally not use absolute paths when defining extraPaths. They should typically be relative to the project. You also don't need to use backslashes. Regular slashes are translated as required for the platform and file system you're using.
Let me know if I've replicated the setup correctly. I'm not able to repro any errors, as you can see in this screen shot.

Apologies as I tried to abstract this from a real example while hiding the server names, shares, modules, etc but I believe I have recreated it based on your example of the relative paths.
Note:  Because I am accessing this all from UNC paths (a share on another server -- not through a mapped drive), I believe that pylance doesn't like the relative path notation, and instead wants the fully qualified UNC paths in extraPaths but I could totally be wrong -- however, my minimal testing seems to indicate that this is correct).
Also note that I use pylint and pylance, and in order to get pylint to correctly parse everything, I Needed to add this to settings.json, and it correctly identifies imports in __init__.py and somemodule.py.
    "pylint.args": [
        "init-hook=import sys; sys.path.append('\\\\someserver\\someshare\\someproject\\pythonlibs');",
    ],

Further, in substituting the full UNC path in the settings.json above for the relative path notation, all the imports complete correctly (no errors).

Lastly, after mucking around with all this to recreate the example in the way I described it here, the actual __init__.py that I was having problems with is NOT throwing the reportMissingImports error anymore, which has me baffled, and I can only assume that there is something else at play here, because clearly, my initial success in adding extraPaths to the user profile settings.json file did squash the reportMissingImports error (for pylance) while at the same time, pylint didnt show any issues, and now I don't need the user profile settings.json extraPaths entry for pylance to work correctly for the 2 files in the same directory.  :( :)
From a further debugging perspective, should I be looking through the trace logs if this happens again? is there something in particular I should be looking for?
I'm totally fine with closing this as not reproducible, but would love the further debugging thoughts.
Please and Thank You for your time.

and here's another screenshot since I never gave you one with the actual problem...  This is backwards from the other day..  __init__.py working and the module not working...  :(

HTH

adding the verboseOutput to pyrightconfig.json doesnt seem to add anything to the output tab.
If I followed correctly, I could just close vscode completely, and then it should read the config change upon reopen.
I also closed all the open file windows, and then reopened then and nothing changed.
Lastly, I changed to another workspace by pressing Ctrl-R and selecting a new project, and then doing the same to move back to this project, and there was no change.

pythonlibs lives at the unc path specified as extraPaths
\\servername\f$\inetpub\pythonlibs
and the workspace is defined like this (there are a few other folders for different websites in there, but for brevity, this should suffice):
{
	"folders": [
		{
			"path": "pythonlibs"
		}
	],
	"settings": {}
}

OK..  I didnt follow your last point until I clicked send on the last comment.
--> removing the extraPaths for this directory has gotten rid of the error.  However, putting it back in didnt recreate the error either.  :(
I will remove the extraPaths for this folder and continue to monitor.  Thanks for the thoughts!!!

P.S. based on what I know about UNC paths, there is no "current directory", I.E. you can't "cd \server\share\folder"
I'm going to try all this with mapped drives and see if that makes things work better ...
However, none of this explains why pylint worked the whole time that I was having problems with pylance.

can you provide us complete repro steps with sample project, that will make much easier for us to figure out what is going on.
"can't resolve import" can be affected by many things such as extra path, python search path, project root, multiple workspaces and etc.
it will make much easier for us to figure out if we can have full picture.

I am still not sure how I recreate the issue. your zip file only contains 1 folder and no multiroot workspaces. and description on the above and below doesn't use same folder name.
and Most of all, can you provide us some logs as described in the troubleshooting guide?
if you provide that log, it will make us a bit more context to understand your environment. and please, provide us the full log as it is without any edit.

@smanross figured out the repro steps. it was due to how we handle uri to path conversion when the given uri is UNC.

I'm sorry this was so difficult to figure out the reproduction steps and am glad we are on the same page now!!!
Thank you for sticking with this issue and I will look forward to seeing a fix!

This issue has been fixed in prerelease version 2022.11.21, which we've just released. You can find the changelog here: CHANGELOG.md


Poor quality animations code

https://github.com/webaverse/app/pull/3286/files added a lot of poor quality animation code hacks in swimming, such as:

referencing animations by case sensitive file name instead of logical name
inline constant hacks
adding dead variables

This shouldn't have been merged in this state @gonnavis
Additionally, other developers have been copying this code, making surrounding code worse.

I see, sorry, I wanted to ship water related codes quickly that time.
I'll improve it with the help of patriboz.


add sampels-seen and ema decay

wait a sec, lemme fix something (will update)

okay, this is better


MM-39199 Fix permissions for reactions buttons

This fixes some weirdness with the permissions around emoji reactions. The following weird cases are fixed:

Non-admins weren't able to click on existing reactions to add them in the Town Square with a license. This seems to be a side effect of https://github.com/mattermost/mattermost-webapp/pull/8541
Users without the permission to react to a post wouldn't be able to click on existing reactions, but they would see the + button with the emoji picker.

Ticket Link
https://mattermost.atlassian.net/browse/MM-39199
Release Note
Fix emoji reaction buttons on posts not respecting user permissions

Thanks @hmhealey
Seeing one issue, +emoji icon is missing after first reaction has been added. This is reproing in all cases, even when all channel permissions are enabled.

@jgilliam17 That should be fixed now. It turns out I was mixing up things called canAddReaction and canAddReactions when passing around permissions.

/update-branch

/update-branch


cffi 2.0b1 not running on Linux with Tcl9

On Linux cffi compiles using Tcl 8.6.15 and Tcl 9.
Test suite runs fine with 8.6.15.
Using Tcl 9 the following errors occur:
Test file error: couldn't load file "/home/obermeier/poSoft/BawtBuild-9.0.0-9.0.0-Release/Linux/x64/Release/Build/cffi/libtcl9cffi2.0b1.so": /home/obermeier/poSoft/BawtBuild-9.0.0-9.0.0-Release/Linux/x64/Release/Build/cffi/libtcl9cffi2.0b1.so: undefined symbol: mp_clear
while executing
"load /home/obermeier/poSoft/BawtBuild-9.0.0-9.0.0-Release/Linux/x64/Release/Build/cffi/libtcl9cffi2.0b1.so Cffi"

This again sounds like a tommath configuration error as the Github CI runs without failures. That is Ubuntu 20.04 but I've also tested against Ubuntu 22.
I need to get clarity on how extensions need to link against tommath given that Tcl may be built either way (--with-system-tommath) option.

Fixed by removing depending on libtommath. Please verify and if getting failures, what version of Linux.

Now builds fine and all tests succeed on various Linux systems.
A build error using gcc 14 came up with your changes in tclhUuidImpl.c when replacing ckalloc/ckfree with Tcl_Alloc/Tcl_Free.
Example:
./tclh/include/tclhUuidImpl.c: In function ‘SetUuidObjFromAny’:
./tclh/include/tclhUuidImpl.c:133:11: error: assignment to ‘Tclh_UUID *’ from incompatible pointer type ‘char *’ [-Wincompatible-pointer-types]
133 |     uuidP = Tcl_Alloc(sizeof(*uuidP));
If adding appropriate casts, cffi compiles and runs fine with gcc 14 (ex. Fedora 40).


Static files not working when deployed

Static files are not served on Deno Deploy; images are corrupt locally and when deployed.
I've created a sample project to reproduce this issue: https://github.com/wezm/repro-sift-static
In Deno Deploy it's linked to https://github.com/wezm/repro-sift-static/blob/main/src/index.ts, accessible at https://quiet-owl-61.deno.dev/.

When running locally with deployctl run --watch --libs=ns,fetchevent --addr :8888 src/index.ts the style sheet loads properly (somtimes) but when deployed it does not. The image does not load locally or when deployed.

When I run   https://quiet-owl-61.deno.dev/
Open the chrome-develop-tools select the network tab, then refresh the page,
I see that the image.png is loading as 'type json'
If you click on the file in the list you can examine the headers.
image,png should have a content type of ' image/png ', not 'application/json'
Also, there is an error message for response that says {"error":"Headers are immutable."}
This had to happen in sift.
Perhaps Sift is trying to mutate the contentType header instead of replacing it.

@satyarohith  looks like sift may be trying to mutate the contentType header. see above.

@satyarohith
The browser will reject a mutated headers object
// in line 76 you are trying to mutate the existing header
for (const [key, value] of newHeaders) {
   existingHeaders.set(key, value);
}

Instead, build a fresh set of headers from the existing
and the browser will accept them.
// replace with the following
// first place the existingHeaders in a new headers object
const newHeaders = new Headers(existingHeaders);
// do any housekeeping with this set...
 if (newHeaders.has("x-github-request-id")) {
    newHeaders.delete("content-security-policy");
  }
// then add you contentType header...
  for (const [key, value] of headers) {
    newHeaders.set(key, value);
  }
// finally, return the newHeaders object in a new Responce object
// line 80
  return new Response(res.body, {
    headers: newHeaders,
    status: res.status,
    statusText: res.statusText,
  });

Thanks for looking into it, @nhrones! That's the root cause. Are you interested in opening a PR?

I'm a total noob on GitHub. I've tried to help in DenoCtl but so far no
luck.  I'm an old retired C# developer and i've fallen in love with
Typescript/Deno.
I can try again with a little hand holding.
a. clone repo
b. make changes
c. pull request
??
On Thu, Jul 15, 2021 at 11:31 PM Satya Rohith @.***>
wrote:

Thanks for looking into it, @nhrones https://github.com/nhrones! That's
the root cause. Are you interested in opening a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/satyarohith/sift/issues/29#issuecomment-881150425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZAPQ6Z367NGO72NFE35MTTX6R2LANCNFSM5ABUUD7A
.

I'm sorry, but the crap that is showing up in my Gmail web client is
impossible to work with.
It's so sad to see such crappy technology in this day and age.
On Thu, Jul 15, 2021 at 11:59 PM NickD Hrones @.***> wrote:

I'm a total noob on GitHub. I've tried to help in DenoCtl but so far no
luck.  I'm an old retired C# developer and i've fallen in love with
Typescript/Deno.
I can try again with a little hand holding.
a. clone repo
b. make changes
c. pull request
??
On Thu, Jul 15, 2021 at 11:31 PM Satya Rohith @.***>
wrote:

Thanks for looking into it, @nhrones https://github.com/nhrones!
That's the root cause. Are you interested in opening a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/satyarohith/sift/issues/29#issuecomment-881150425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZAPQ6Z367NGO72NFE35MTTX6R2LANCNFSM5ABUUD7A
.

a. clone repo
b. make changes
c. pull request

These are the only steps to get started. It's similar to how you opened https://github.com/denoland/deployctl/pull/67. :)

How do I stop getting these emails on Gmail?  Whatever Git is sending is
Way too hard to use on Gmail-WebPage.
On Fri, Jul 16, 2021 at 12:15 AM Satya Rohith @.***>
wrote:

a. clone repo
b. make changes
c. pull request
These are the only steps to get started. It's similar to how you opened
denoland/deployctl#67 https://github.com/denoland/deployctl/pull/67. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/satyarohith/sift/issues/29#issuecomment-881163102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZAPQYQUVORBWEI43OK7GLTX6W5HANCNFSM5ABUUD7A
.

@satyarohith  please forgive my rants.  I fixed my Gmail (had a bad theme that mangled everything from Github)..
Are you still interest in help?

Thanks for the patience, @wezm! I fixed the issue and released a new version 0.3.4. Please try it out and let me know if you face any issues.

The image does not load locally or when deployed.

There's a tracking issue (https://github.com/denoland/deployctl/issues/60) on deployctl. But you'll soon be able to run sift using deno without the need for deployctl, which should fix the local static assets issue.

Wonderful, confirming that that image and stylesheet now work.

Hi, i'm having a similar issue. I'm using sift 0.3.4 and deployctl 0.3.0. (also tried with main)
my code: https://github.com/sylc/test_sift/blob/main/server.ts.
deployment: https://old-donkey-81.deno.dev/

with deploctl, the style file is loaded but the png file is not showing (the response is noted as 200 in devTools)
when deployed, neither the styling or the png is loaded (there is no response)

I also cloned wezm code to test with my local deployctl. The image is not loading correctly.
I have deno version  1.12.1

@sylc. See note above with the link to https://github.com/denoland/deployctl/issues/60. Images won't load properly locally but as of 0.3.4 they are now loading when deployed (for me).

@sylc, the website seems to be working fine for me on Chrome and Safari.

@wezm @satyarohith Thanks for the feedback.
It seems that i was facing 2 issue:

the local issue is due to the deployctl bug.
the deno deployment issue is a csp issue. I'm normally using chrome. in devtools console there is Refused to load the stylesheet 'https://old-donkey-81.deno.dev/assets/styles.css' because it violates the following Content Security Policy directive: "style-src 'unsafe-inline'". Note that 'style-src-elem' was not explicitly set, so 'style-src' is used as a fallback.

I tried in edge and firefox and the image was loaded successfully at first. But then I open the devtools and disable the cache and reload and I get the same error in both browser.  I guess i can try to set a meta tag in the head but i would expect the server to handle this by a header in the response. It is unclear why this is not happening on  @wezm repro site.

@sylc @satyarohith  I get the same errors as you. On  https://old-donkey-81.deno.dev/.
Both the stylesheet and the img are rejected. Windows 10/ Chrome browser.  I had set up a test app after 0.3.4 and for several
hours testing the error I was getting just went away?  I looked on Discord but could see no reason for that to have happened.
The error I was testing for was a header mutation error in chrome.  I first saw it on @wezm app from  to denoland/deployctl#60.  My test was producing the mutated header rejection, and after a few hours, it changed to a content-type error???

In my test case I'm retrieving the index.html from github.
If I instead replace it with a baked in response in serve eg: '/':  () => new Response(html, { headers: { "content-type": "text/html; charset=UTF-8", } }), (similar to @wezm initial site),  then it is working.
I can see that any files retrieved from github has a content-security-policy header set, which does not allow to load further files
It seems that that there is an attempt in the code to remove this header. ref https://github.com/satyarohith/sift/blob/2088f39cd35e7ade542abb5fde3ecc308d11839c/mod.ts#L74     This does not seem to work as intended

@satyarohith @sylc
Please note that in line#74, the case may be that you are not actually removing the header. Often, as was the case with content-type header, mutation is blocked on original header but not on NEW header.
Consider  ...
// here originalResponse.headers will be the init values of a new headers object
const newHeaders = new Headers(originalResponse.headers)
// now you may be able to make changes.  Worth a try.
newHeaders.delete("content-security-policy");

As with the content-type issue, the newHeaders object should allow mutations.

You might just log out the original headers after the delete attempt, just to verify the deletion.

@sylc @satyarohith
I'm wrong again.  Did some testing.  I forgot that the new Response object on line#65 also returns a new Headers object.  So yes the header delete will happen.  What confused me was the reuse of the param 'response' to new.  I saw the name at params and thought it was what was referenced at line#74  response.headers.delete.
Sorry!


MP Rest Client SSL support

To be able to get a successful build, I added exclusions for tests that verify features that are not yet implemented.

The PR for 3.8: https://github.com/resteasy/Resteasy/pull/2047
This one can be closed, right?

Turns out this should be done in 3.8 only, closing.


No expected response in Puppeteer, but response visible when tested manually

Steps to reproduce
Tell us about your environment:

Puppeteer version: 5.4.1
Platform / OS version: Linux Manjaro 20.2 Nibia
URLs (if applicable): https://alpinepro-outlet.cz/
Node.js version: 15.0.1

What steps will reproduce the problem?
const puppeteer = require('puppeteer');

const baseUrl = 'https://www.alpinepro-outlet.sk/';
const searchTerm = 'detská';

(async () => {
    const browser = await puppeteer.launch({
        headless: false,
        args: [
            "--start-maximized"
        ],
        defaultViewport: null
    });
    const page = await browser.newPage();
    await page.goto(baseUrl);
    await Promise.all([
        page.type('#fulltext-search-input', searchTerm),
        page.waitForResponse(
            response => response.status() === 200
                && response.url() === encodeURI(baseUrl
                    + 'Product/Suggest?query=' + searchTerm + '&pageSize=10')
        )
    ]);

    await browser.close();
})();

What is the expected result?
I expect the script to pass, that is to see the response I'm awaiting with waitForResponse().
What happens instead?
It seems puppeteer doesn't type the last "á" into the search field. If I launch a browser with devtools: true I never see a request for such a search term. But when, while waiting, I manually delete "á" and input the character again, the request is immediately there and the whole script passes.
I've tried changing the searchTerm, it goes like this:

"šport" => script runs till the end with no error
"detská" => no request-response, timeout eventually
"detská " => script runs till the end with no error
"š" => no request-response, timeout eventually
"š " => script runs till the end with no error

I've also asked the same question on Stackoverflow here, but havent's received any comment and/or answers for about 3 days now. That's why I'm eventually posting it here.

I wonder if your search term variable needs to be encoded with a particular UTF encoding?  It's acting like it's expecting another character to follow your one unicode character.
You might be able to use Buffer.from().toString() to generate an output string with a UTF character encoding that will work.


Make chatbot view more concise for very long conversations

Currently for very long conversations, the chatbot display can be extremely long and take up too much screen space.
It might be nice if only the final N utterances were shown by default (e.g. N=6 or so), but then the full context could be expanded with a button click or something.

This is probably one for https://github.com/zeno-ml/instance-views. I copied your issue over as https://github.com/zeno-ml/instance-views/issues/5


Include location data sent to Bot

This PR includes locations sharing from the user to the bot.
The workflow: when clicking Send my current location a new message
is sent to the bot with latitude and longitude accessed via
my_message.location.
To get the coordinates in an array, use my_message.location.full.
Original api discussion here.
This PR does not implement sharing of live locations, which are
implemented in a wholly different manner by nesting
the information within edited_message. To include live locations we
would also need to bring in the edited_message functionality. I will
be approaching this with my next PR.

Commit incoming for spec passing :)


Set info plist output

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
From the same plist file as template, I want to generate different plist files with different configurations without doing any change at all in the template.
Description
Add a new output parameter to set_info_plist to allow setting a different output for the resultant plist file.
The changes are backward compatible. The new parameter is optional and the current behaviour is kept in case of not providing it.

I signed it!

Documentation added to fastlane/docs in this pull request:
https://github.com/fastlane/docs/pull/371

@KrauseFx Thanks a lot for your feedback and your time reviewing this PR. The requested changes were applied to the code.


Remove myself from react components and add wallet team

Description
I dont think myself or rossy knows much about the react components anymore

@aaronmgdr thanks for making this!


Permit custom direction to dialog

Create a custom dialog in diferent postion
I want use a dialog to a sidebar

I want to use the dialog as a sidebar, and modified the component so that the user can send css to it.
Do you think it would be a good functionality?

If you think it would be a good functionality, I can do a PR.
He also thinks we should create a position variable so that we don't have to send css

Yes, this would be awesome. I think the original library supports this too. Go for it, I'll review.