handle Oracle Linux yum server changes

With the current version of ol7-latest.box (as of 31-Jan) and the announced Oracle Linux yum server changes, the install.sh script fails.  One can see this in the output from vagrant up:
oracle-18c-vagrant: IMPORTANT: A legacy Oracle Linux yum server repo file was found. Oracle Linux yum server repository configurations have changed which means public-yum-ol7.repo will no longer be updated. New repository configuration files have been installed but are disabled. To complete the transition, run this script as the root user:
oracle-18c-vagrant:
oracle-18c-vagrant: /usr/bin/ol_yum_configure.sh
A quick fix is just to check for the existence of the yum repo script post update (insert the below after line 20)
if [ -f /usr/bin/ol_yum_configure.sh ]; then
  echo 'INSTALLER: updating Oracle Linux yum server repo file'
  /usr/bin/ol_yum_configure.sh
  echo 'INSTALLER: updating Oracle Linux yum server repo file, done!'
fi

This allows the install to run to completion successfully.

@gregrahn,
When you say that the install.sh script fails, do you mean that the rest of the script doesn't run? When I build the 18c box (or any of the other Oracle Database boxes), I see the message about the yum repository transition, but it doesn't halt script execution. The database is successfully installed and configured, and the box works correctly.
If the script isn't running to completion, it would help if you could provide the output that appears after the yum repository transition message, along with the versions of VirtualBox and Vagrant that you're using.
If the script is running to completion, then one way to address the yum repository transition is to add a shell script in the userscripts directory before running vagrant up for the first time. The installer runs any shell and/or SQL scripts in the userscripts directory after the database is set up. For example, you could add a script called complete_yum_transition.sh in the userscripts directory with the following content:
#!/bin/bash
#

if [ -f /usr/bin/ol_yum_configure.sh ]; then
  su -l -c /usr/bin/ol_yum_configure.sh
fi

This would ensure that the yum repository configuration is correct until a new version of ol7-latest.box is released.
I hope this helps!
Paul

@PaulNeumann - the script runs to finish, but the Oracle install and beyond fails.  You can see the errors starting after the oracle-18c-vagrant: INSTALLER: System updated line.
https://gist.github.com/3d1481906947f764c957596d1d8f3aaa

@gregrahn Can you still ssh to this box? If so, what does the following show:
yum repolist
ls -l /etc/yum.repos.d

@gregrahn,
Thanks for providing the log. This helps.
I've built the Oracle Database boxes in this repository many times since the yum repository transition, using the latest version of ol7-latest.box, and I haven't seen the There are no enabled repos. message (lines 704 and 710 of the log) before. That's not how the process is "supposed" to work. Since there are no enabled repos, yum can't install the oracle-database-preinstall-18c rpm. Without the preinstall rpm, the rest of the installation and configuration fails.
I'll look at this some more and see what I can figure out.
Thanks,
Paul

@totalamateurhour In case it helps, I built this box after the original poster reported the issue, and it worked fine for me. I was wondering whether I hit a different CDN node and got different rpm versions, but that doesn't appear to be the case.
[vagrant@oracle-18c-vagrant ~]$ yum list installed oraclelinux-release-el7 yum-utils
Installed Packages
oraclelinux-release-el7.x86_64                         1.0-4.el7                                 @ol7_latest
yum-utils.noarch                                       1.1.31-50.0.1.el7
[vagrant@oracle-18c-vagrant ~]$ ls -l /etc/yum.repos.d
total 28
-rw-r--r--. 1 root root  3354 Jan 31 22:28 oracle-linux-ol7.repo.disabled
-rw-r--r--. 1 root root 14602 Nov 14 08:20 public-yum-ol7.repo
-rw-r--r--. 1 root root  2116 Jan 31 22:28 uek-ol7.repo.disabled
-rw-r--r--. 1 root root   226 Jan 25 15:35 virt-ol7.repo.disabled

I deliberately haven't run ol_yum_configure.sh yet.

@PaulNeumann Thanks - this is what I would expect. Like you, I'm puzzled by the There are no enabled repos message.

I'm not sure what has changed, but I destroyed my vm and started clean again, reverting my changes, and it succeeded this time.  Looking back at yesterday's log in the gist and comparing it to the successful one, this is the thing that stands out:
oracle-18c-vagrant: mv: cannot stat ‘/etc/yum.repos.d/public-yum-ol7.repo.20190201’: No such file or directory
    oracle-18c-vagrant: grep: /etc/yum.repos.d/public-yum-ol7.repo: No such file or directory

So not sure what caused that, but that seemed to set the course for the mishap with the repo.
My speculation would be something related to time zones in the script and the potential mismatch of the dated file name and the expected name, but not sure what may do that.

@gregrahn,
Excellent! I'm glad it's working for you now.
Unfortunately, I don't have an explanation for what went wrong the first time. I doubt that running the ol_yum_configure.sh script would have helped, because it doesn't do anything if /etc/yum.repos.d/public-yum-ol7.repo is missing (which apparently it was).
I don't know whether time zone was the problem. The date referenced in the log would have been in UTC, because the VM time zone isn't set to the host's time zone until a little later in the install.sh script. So, if you created the VM after 4:00 PM in your host's time zone yesterday, 20190201 would have been correct.
If I learn more, I'll let you know.
Thanks,
Paul

@gregrahn @PaulNeumann Oracle Linux 6.10 and 7.6 boxes on yum.oracle.com/boxes are updated. It could take a while to trickle through the CDN (akamai). These use the new modular yum repo approach.

@totalamateurhour Nice! Thanks for letting us know.

@totalamateurhour, I believe we can close this issue now that the boxes have been updated, correct?

Correct.


[5.8] Change navbar-laravel class for bootstrap classes

Bootstrap >=4.1 includes a shadow-sm class which looks pretty close to the one in the navbar-laravel class https://getbootstrap.com/docs/4.3/utilities/shadows/
You could then remove the .navbar-laravel class here:
https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13

Neat. This way we can also remove the code here: https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13
We'll have to update the minimum version of bootstrap here as well: https://github.com/laravel/laravel/blob/master/package.json#L14


Implement Get and Prewrite

Also refactors the raw commands to use the Command interface.
cc https://github.com/pingcap-incubator/tinykv/issues/38
PTAL @Connor1996

It's really weird that when implementing the rawGet, it even needs an MvccTxn.

This is just for uniformity. By making each command have the same structure it means we can share more code and make each command stand alone.

And I'm wondering how we can remove the Scheduler in the final?

I don't think it is difficult - we can just move the implementation of handleTask from scheduler to server and replace the channels with regular function calls.

As I understand, the tests are added to make sure the implementation correct, and we'll add the integration tests from the perspective of outer API(Prewrite/Commit/Get... in server.go). Is that right?

Yes.

Comments addressed. PTAL @Connor1996


Rename Curseforge to CurseForge

Forgetten from https://github.com/Fabulously-Optimized/fabulously-optimized/commit/e4601f3bebbdeb981ae9b1de785cfa7ce6d9ad2f

Fix any scripts that mention it as well then :grin:

Huh, seems like the scripts were already updated, guess they weren't case-sensitive.


Tensor/group deletion perf fix + corruption proofing

🚀 🚀 Pull Request
Checklist:

[ ]  My code follows the style guidelines of this project and the Contributing document
[ ]  I have commented my code, particularly in hard-to-understand areas
[ ]  I have kept the coverage-rate up
[ ]  I have performed a self-review of my own code and resolved any problems
[ ]  I have checked to ensure there aren't any other open Pull Requests for the same change
[ ]  I have described and made corresponding changes to the relevant documentation
[ ]  New and existing unit tests pass locally with my changes

Changes

Avoid flushing for each chunk deletion.
Delete meta before chunks, so worst case scenario is unaccounted chunks instead of corrupt dataset.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Failed to render form in v3.0.0-beta1 due to the use of array.includes()

The compiled babel code within the npm module that is using the new JS feature array.includes() is breaking redux-form functionality in my setup. The line in question seems to be here:
https://github.com/erikras/redux-form/blob/master/src/readFields.js#L35
There might be other instances though. I do use this in my own code just fine as I transpile using Babel stage 0, but I do not transpile npm modules of course.

Very strange. I was assuming babel-loader would transpile that down for me. I'm going to try and collect a few more bugs before another release if you don't mind. Thanks for catching that.

Yes I understand. Thanks for looking into it Erik.


Regarding user agent

Hello, this looks like an awesome app, thank you very much.
Just one little question. Since my default user agent shows device and build info and this app gets facebook notifications from m.facebook.com, I'm wondering if it uses the same UA string as my browser. There are some user agent switchers on the Play Store but they are just for Chrome, so I don't know what else to do other than ask if you can shed some light about it. I really want to hide my device info from UA string. Can you edit it to show some common UA string instead? Thank you mate.

The app always uses a custom user-agent: the app name.
If you open the Facebook security settings, you can see the sessions opened to your account. The app currently shows up as "Device type: Unknown" and when hovering the [?], it shows "Facebook Notifications". I don't know it they can guess what kind of device it is using with other metadata, though.


Remove -k and --name required flags - 52

[Auto generated]
Number: [#52]

must-gather-explorer[pull_request][c90248c0-b2f0-11ef-8bb5-0b1c824458cb][PR 52]: Closing issue for PR: Remove -k and --name required flags.
PR was closed.


Updated version of dependency-check-maven to 6.2.2

Updated pom.xml

Running "mvn site" with version 5.3.2 generates the following error :
"[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project parent: Error generating dependency-check-maven:5.3.2:aggregate report: One or more exceptions occurred during dependency-check analysis: One or more exceptions occurred during analysis:
[ERROR]         Unable to resolve system scoped dependency: com.sun:tools:jar:1.8.0:system"
Updating to 6.2.2 resolves that.


Fix idempotency/recurrence of download and preinstall

Don't push containers if not changed
Do preinstall role only once and redistribute defaults to
corresponding roles

Signed-off-by: Bogdan Dobrelya<EMAIL_ADDRESS>

@mattymo @ant31

-1 this breaks etcd standalone because it will skip etcd role kubernetes/preinstall

+1 and shifting of var locations looks ok to me too


Makefile: add make minimal

Should it include the lima wrapper as well ?

No, it should be just minimal

I consider it to be (minimal), but I don't know what this will be used for

I consider it to be (minimal), but I don't know what this will be used for

For local testing I don't want to compile guestagents for non-native archs

I found doing something similar for qemu to be useful, for a new project/repository.

I found doing something similar for qemu to be useful (for a new project).

Do you have that code in a repo somewhere? It might be useful for the lima-and-qemu repo used by Rancher Desktop (and possibly by finch; they do run a fork of it).
Bonus question, since this just came up on lima-and-qemu: is it possible to cross-compile qemu for aarch64 on amd64 (for Linux)? (because Github still don't have aarch64 runners).

Do you have that code in a repo somewhere?

It was more of a configure line for the qemu build, and I didn't do any work of packaging the result up either...
Just thinking it could be alternative to the default build in for instance brew, which weighs in at a gigabyte or so
But yeah, adding a "qemu-lima" repo could be done

s it possible to cross-compile qemu for aarch64 on amd64 (for Linux)?

I think it should be enough to set the compilers, i.e.  CC and CXX, with the arch
Can't see any special other mentions on : https://cblfs.clfs.org/index.php/QEMU


Please help me [BUG]

Please make a apktool for arch64 i requested you please

Not in my control. I use native binaries/tools from Android Build System, like aapt2. If AOSP supports official cross compiling to arm - I'll consider it.


Account Plugin: Add ability to copy local profile settings to synced settings

Currently when logging into a Google account to sync your RuneLite settings you are reverted to the default settings. This is a big headache when you've done things like set up a lot of bank tags/tweaked a lot of settings.
I'd like to request the ability to copy the local settings onto the new profile. For example this could be done during the creation of a profile(first time logging in), potentially prompting the user to either copy the current settings or start with the default.
Currently the local settings are stored at .runelite/settings.properties and settings synced to a Google account are stored at<EMAIL_ADDRESS>I attempted to manually overwrite the profile-specific settings.properties file but it seems the synced settings will just overwrite the changes.

Yeah it's bad for bank tags. Also I hate having to type email each time to log in diff accounts.

This was added in #7410


How to input protein data to ProteinCNN model to predict PPI

I want to predict the protein affinity of two proteins. After training a model, I load two sequences from PDB. However, I have problem in prediction phase.
`
import torch
import torchdrug
from torchdrug import datasets
from torchdrug import transforms
truncate_transform_ = transforms.TruncateProtein(max_length=200, keys=("graph1", "graph2"))
protein_view_transform_ = transforms.ProteinView(view="residue", keys=("graph1", "graph2"))
transform_ = transforms.Compose([truncate_transform_, protein_view_transform_])
dataset = datasets.PPIAffinity("~/protein-datasets/", atom_feature=None, bond_feature=None, residue_feature="default", transform=transform_)
train_set, valid_set, test_set = dataset.split()
from torchdrug import tasks, models, core
model = models.ProteinCNN(input_dim=21, hidden_dims=[1024, 1024],kernel_size=5, padding=2, readout="max")
task = tasks.InteractionPrediction(model, task=dataset.tasks,
criterion="mse", metric=("mae", "rmse", "spearmanr"),
normalization=False, num_mlp_layer=2)
optimizer = torch.optim.Adam(task.parameters(), lr=1e-4)
solver = core.Engine(task, train_set, valid_set, test_set, optimizer, batch_size=64)
solver.train(num_epoch=10)
solver.evaluate("valid")
pdb_file = utils.download("https://files.rcsb.org/download/1NSK.pdb", "./")
p1 = data.Protein.from_pdb(pdb_file, atom_feature=None, bond_feature=None, residue_feature="default")
pdb_file_2 = utils.download("https://files.rcsb.org/download/1EJ4.pdb", "./")
p2 = data.Protein.from_pdb(pdb_file_2, atom_feature=None, bond_feature=None, residue_feature="default")
item = [p1, p2]
pred = task.predict(item)    ## ERROR `

Hi, maybe you can try the code below.
...
from torchdrug import data
pdb_file = utils.download("https://files.rcsb.org/download/1NSK.pdb", "./")
p1 = data.Protein.from_pdb(pdb_file, atom_feature=None, bond_feature=None, residue_feature="default")
pdb_file_2 = utils.download("https://files.rcsb.org/download/1EJ4.pdb", "./")
p2 = data.Protein.from_pdb(pdb_file_2, atom_feature=None, bond_feature=None, residue_feature="default")

item = {"graph1": p1, "graph2": p2}
item = dataset.transform(item)
batch = data.graph_collate(item)
pred = task.predict(batch)

However, I suggest to write a test dataset following the style of HumanPPI.


Multiple minor changes

Pass on CI
Rename BlFFIDoubleArray -> SpartaCairoFFIDoubleArray
Moved containsPoint extension to Bloc-Sparta

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 29 (0.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Sparta-Cairo/SpartaCairoFreetypeFontFace.class.st
0
1
0.0%

src/Sparta-Cairo/SpartaCairoStrokePainter.class.st
0
2
0.0%

src/Sparta-Cairo/SpartaCairoFFIDoubleArray.class.st
0
3
0.0%

src/Sparta-Cairo/SpartaCairoPath.class.st
0
8
0.0%

src/Sparta-Cairo/SpartaCairoGlyph.class.st
0
15
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
18477

💛  - Coveralls


moveit: 0.9.4-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository moveit to 0.9.4-0:

upstream repository: https://github.com/ros-planning/moveit.git
release repository: https://github.com/ros-gbp/moveit-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.23
previous version for package: 0.9.3-0

moveit

No changes

moveit_commander
* [fix] issue #373 <https://github.com/ros-planning/moveit/issues/373> for Kinetic (#377 <https://github.com/ros-planning/moveit/issues/377>) (#385 <https://github.com/ros-planning/moveit/issues/385>)
* [fix] typo in moveit_commander (#376 <https://github.com/ros-planning/moveit/issues/376>)
* Contributors: Dave Coleman, Shingo Kitagawa

moveit_controller_manager_example
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman

moveit_core
* [fix] PlanningScene: Don't reset color information of existing objects when new entries are added (#410 <https://github.com/ros-planning/moveit/issues/410>)
* [fix] update link transforms in UnionConstraintSampler::project (#384 <https://github.com/ros-planning/moveit/issues/384>)
* [capability Addition of Set Joint Model Group Velocities and Accelerations Functions (#402 <https://github.com/ros-planning/moveit/issues/402>)
* [capability] time parameterization: use constants (#380 <https://github.com/ros-planning/moveit/issues/380>)
* [enhancement] multiple shapes in an attached collision object #421 <https://github.com/ros-planning/moveit/pull/421>
* [maintenance] Use static_cast to cast to const. (#433 <https://github.com/ros-planning/moveit/issues/433>)
* [maintenance] ompl_interface: uniform & simplified handling of the default planner (#371 <https://github.com/ros-planning/moveit/issues/371>)
* Contributors: Dave Coleman, Maarten de Vries, Michael Goerner, Mike Lautman, Ruben

moveit_fake_controller_manager
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman

moveit_kinematics
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman

moveit_planners

No changes

moveit_planners_ompl
* [enhancement] ompl_interface: uniform & simplified handling of the default planner (#371 <https://github.com/ros-planning/moveit/issues/371>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman, Michael Goerner

moveit_plugins

No changes

moveit_ros

No changes

moveit_ros_benchmarks
* clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman
* [enhancement] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman

moveit_ros_control_interface
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman, Michael Goerner

moveit_ros_manipulation
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* [fix] race conditions when updating PlanningScene (#350 <https://github.com/ros-planning/moveit/issues/350>)
* Contributors: Dave Coleman, Robert Haschke

moveit_ros_move_group
* [fix] race conditions when updating PlanningScene (#350 <https://github.com/ros-planning/moveit/issues/350>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman, Robert Haschke

moveit_ros_perception
* [maintenance] Remove custom cmake modules (#418 <https://github.com/ros-planning/moveit/issues/418>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman, Jochen Sprickerhof

moveit_ros_planning
* [fix] race conditions when updating PlanningScene (#350 <https://github.com/ros-planning/moveit/issues/350>)
* [maintenance] Use static_cast to cast to const. (#433 <https://github.com/ros-planning/moveit/issues/433>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman, Maarten de Vries, Robert Haschke

moveit_ros_planning_interface
* [fix] move_group.cpp: seg fault bug (#426 <https://github.com/ros-planning/moveit/issues/426>)
* [fix] mgi: show correct include path in doxygen (#419 <https://github.com/ros-planning/moveit/issues/419>)
* [fix] fix race conditions when updating PlanningScene (#350 <https://github.com/ros-planning/moveit/issues/350>)
* [fix] issue #373 <https://github.com/ros-planning/moveit/issues/373> for Kinetic (#377 <https://github.com/ros-planning/moveit/issues/377>) (#385 <https://github.com/ros-planning/moveit/issues/385>)
* [capability] PSI: add apply* functions that use ApplyPlanningScene.srv (#381 <https://github.com/ros-planning/moveit/issues/381>)
* [maintenance] Fix test file issues (#415 <https://github.com/ros-planning/moveit/pull/415>, #412 <https://github.com/ros-planning/moveit/issues/412>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Bastian Gaspers, Dave Coleman, Isaac I.Y. Saito, Jorge Santos Simon, Michael Goerner, Robert Haschke

moveit_ros_robot_interaction
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman

moveit_ros_visualization
* [fix] race conditions when updating PlanningScene (#350 <https://github.com/ros-planning/moveit/issues/350>)
* [enhancement] Add colours to trajectory_visualisation display (#362 <https://github.com/ros-planning/moveit/issues/362>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Bence Magyar, Dave Coleman, Robert Haschke

moveit_ros_warehouse
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman

moveit_runtime
* Added a new metapackage as a minimum set of moveit-related packages that can be installed on a robot (eliminating development packages).
* Contributors: Isaac I.Y. Saito

moveit_setup_assistant
* [fix] Qt4/Qt5 compatibility #413 <https://github.com/ros-planning/moveit/pull/413>
* [fix] show disabled collisions as matrix  (#394 <https://github.com/ros-planning/moveit/issues/394>)
* Contributors: Dave Coleman, Robert Haschke, Michael Goerner

moveit_simple_controller_manager
* [fix] assertion error when result not returned (#378 <https://github.com/ros-planning/moveit/issues/378>)
* [maintenance] clang-format upgraded to 3.8 (#367 <https://github.com/ros-planning/moveit/issues/367>)
* Contributors: Dave Coleman, Michael Ferguson

Please hold. I need to apply the change from #13767

Please hold. I need to apply the change from #13767

Nevermind. No need for applying manual change for kinetic. Ready for the review and merge.


KubeDeploymentGenerationMismatch is never triggered - could it be?

It seems that the KubeDeploymentGenerationMismatch out-of-the-box alert is never triggered.
To my understanding, this alert should fire when the kube_deployment_metadata_generation metric does not match the kube_deployment_status_observed_generation metrics, but these two metrics are always the same
What did you do?
I tried simulating this alert to fire by deploying a failing deployment.
When a deployment was syntactically incorrect it just failed, not causing any change to the metrics above.
When a deployment succeeded but started some faulty application [Incorrect image, or non existing port] it was still successful, but  showing 0 in READY.
Is it possible this alert never fires? Or did I misunderstand its usecase?
 I tend to agree that in the case of the Deployment object it's not extremely useful. Essentially the generation tells us whether the state reported can be believed, so it usually fails when for example the StatefulSet controller is in a state where it cannot decide and (probably) needs human intervention.

I'm going to close this since the actual alert is pulled in via kubernetes-mixin
I also think it is worth keeping based on @brancz explanation regardless


Open Modal from Javascript

What would the best way be to open the modal programmatically from within a javascript function (ie. instead of clicking a link to open the modal, you could tell it to open from within your javascript code)?

+1 for this. Currently it seems that you set a callback on an existing dom element which then opens the modal in the future. It'd be nice to be able to just do so directly.

+1

This requires that the caller ( $("#demo01").animatedModal(); in the demo) actually returns the bound target object which is something I also vote for.

@mamute @natecox @murray484 I've opened up a PR #15 and that branch is available in my fork.
Please test it and review. If you guys like, I can try to find the time to compile the js and updated my repo


Fix integration tests issue 201

Fixing issues reported in https://github.com/WebOfTrust/signify-ts/issues/201
Implements client side fix for https://github.com/WebOfTrust/keria/issues/147 when checking status of operations that have dependencies

Looks good to me! It would be really nice to get this in. But build is currently complaining about missing unit tests for the added methods in coring.ts.

Thanks. I added unit tests. Coverage is looking better now.

Thanks @lenkan. I don't have write access so can you please merge


Allow Configurable Login Type

This fails since my users have a login type of 'ldap'. Would love an option to configure the login type.

Darn - that's sad to hear,


Issue edit

See discussion in #76. I skipped the title and edit flags, and removed the shorthand for unlabel and unassign.
This is fully functional, but before it goes further we should confirm the naming of the flags, and specifically the assign & unassign flags. They pair nicely, of course, and I like how they feel in use but they're inconsistent with other commands: lab issue create uses --assignees (even though it only takes one) and lab mr create uses --assignee. If I change this to use assignee, then unassign feels out of place, but changing unassign to something like remove-assignee feels overly verbose.  Feedback or opinions would be helpful.
$ ./lab issue edit -h
Edit or update an issue

Usage:
  lab issue edit [remote] <id> [flags]

Aliases:
  edit, update

Examples:
lab issue edit <id>                                # update issue via $EDITOR
lab issue update <id>                              # same as above
lab issue edit <id> -m "new title"                 # update title
lab issue edit <id> -m "new title" -m "new desc"   # update title & description
lab issue edit <id> -l newlabel --unlabel oldlabel # relabel issue

Flags:
  -a, --assign strings     Add an assignee by username
  -h, --help               help for edit
  -l, --label strings      Add the given label(s) to the issue
  -m, --message strings    Use the given <msg>; multiple -m are concatenated as separate paragraphs
      --unassign strings   Remove an assigne by username
      --unlabel strings    Remove the given label(s) from the issue

Codecov Report

Merging #245 into master will increase coverage by 1.02%.
The diff coverage is 84.55%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   68.22%   69.25%   +1.02%
==========================================
  Files          42       43       +1
  Lines        2219     2387     +168
==========================================
+ Hits         1514     1653     +139
- Misses        550      565      +15
- Partials      155      169      +14

Impacted Files
Coverage Δ

internal/gitlab/gitlab.go
42.63% <50%> (+0.15%)
:arrow_up:

cmd/issue_edit.go
86.71% <86.71%> (ø)

cmd/root.go
72.93% <0%> (-0.66%)
:arrow_down:

cmd/issue_list.go
93.93% <0%> (+1.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ce4cf...fc75df4. Read the comment docs.

I just updated this use to use --assignee instead of --assign to be more consistent with mr create. Anything else I can do to help move this along?

@claytonrcarter Sorry I'm just looking at this again since last time. I think --assign make more sense here, because issues support multiple assignees while merge requests only support 1. When merge requests get updated to support multiple (I think still pending?) I figured we'd update merge requests to use --assign as well.
Do you think it makes sense to change back with that in mind? Read to merge this when I hear back.

@claytonrcarter forgot I added you as a collaborator. Approved the PR, feel free to merge at your discretion.

Makes sense! I reverted the last commit and will merge later today. Thanks!


Error from using regex::internal::Input in code

httpmock version: 0.6
rust version:  rustc 1.73.0-nightly (39f42ad9e 2023-07-19)
Current Behavior:

Work around: Removing use regex::internal::Input from src/server/mod.rs file fixed the problem

Thanks. It’s fixed in the newest version, v0.6.8


loadFromBiom fix

remove taxa prefixes only from taxa columns by default
Fix the parsing of taxonomy

This is good to go


Links to Other Projects from a Project Page

I would like to start a discussion for the best way to navigate from one project page to others. Generally speaking I do like the idea of having such navigation. However an alphabetical listing, as seen in current Compass prototypes, results in a very long list that creates a kitchen sink feeling and scrolls off the screen. If you expand a composite project (like Spring Cloud), it gets worse.
To start, it's worth asking if there is any evidence from user interviews, that we need a direct link to every existing project from all project pages? Either way we need to come up with something more helpful than this but it's worth knowing what the goal is.
The current http://spring.io/projects has a list of projects in curated order. So a simple improvement would be to make a limited, curated list, and trail off with a "Browse all..." link at the bottom.
A second idea is smart linking. The Compass proposals already have a "Spring Boot Config" box (which I think should be renamed to just "Spring Boot"), is a natural place to link to Spring Boot. It's true that not every project has Boot integration but perhaps we can still use the box to state that (?) Right below the "Spring Boot" box there should also be a "Spring IO Platform" box, that extends the idea with the Spring Boot box, applies to every project, and is a natural place to link to Spring IO Platform. We can further add "Related Projects" that would have to be chosen by each project lead, along with a "Browse all..." for completeness. Personally I would enjoy this way of navigation where the presence of more projects becomes something interesting to discover, vs a daunting list to wrestle with.

Taking the second idea a step further, what about the left-hand side menu? I think having a "Related Projects" box is mutually exclusive and would significantly overlap with a left-hand side menu. That's not bad necessarily. Not having a left-hand side menu creates more space. That said the left-hand side could still be used to list "peer" projects in a composite project (e.g. Spring Data and Spring Cloud). In other words left-hand side is for first-order relations and the "Related Projects" is for relations of interest.

I think the idea of replacing the left nav with additional "related" boxes is worth pursuing. On the other hand I don't think the long alphabetic list is a show stopper (we should go live with it and be prepared to remove it if we find a better way).
Note that "Spring IO Platform" has no link whatsoever with quite a few projects (e.g. all of Spring Cloud). And the relationship between Spring Boot and the other project is inverted for Spring Cloud projects (they provide features to Boot users not the other way round).

I don't think the long alphabetic list is a show stopper

Okay, I agree..

Note that "Spring IO Platform" has no link whatsoever with quite a few projects

I didn't know that. I guess smart linking makes even more sense. It's not relevant to link to Spring IO Platform from there.

the relationship between Spring Boot and the other project is inverted for Spring Cloud projects

True, in that case Spring Boot becomes just one of the related projects I guess? Just like every project would probably list the Spring Framework.


Output errors are not handled properly

https://github.com/aquasecurity/postee/blob/main/msgservice/msghandling.go#L111

#192


update README.md and fix index.js in nlp-with-luis (#630)

Fixes #630

@stevengum while you are in there, you should clean up that readme a bit more. there are some typos, and we should make the same type of changes I made to the other LUIS samples to link to the .bot format, etc.

Oh nevermind, I already made these changes in this PR:
https://github.com/Microsoft/BotBuilder-Samples/pull/715


panic when stopping service when duplicate routes are registered

After the updating to v1.2.15 we started getting the panic below. I erroneously was registering multiple handlers for the same route. This panic seems to be when the arpc.Server is stopping.
My architecture was calling srv.Handler.Handle("duplicated/route", func...) with the same route string a few times because of a copy paste error on my part.
The improper registration was my fault but the panic didn't seem the best way to realize this. I would prefer to have a panic immediately result from the Handle call with a duplicate route. If you support multiple handlers at the same route then there may be a different bug.
panic: handler exist for method /order/subscribe
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x105147154]

goroutine 1 [running]:
github.com/lesismal/arpc.(*Server).Stop(0x14000147650)
	/Users/kevm/go/pkg/mod/github.com/lesismal/arpc@v1.2.15/server.go:113 +0x54
gitlab.com/neomantra/nimble/internal/stream.(*WebSocketServer).Stop(0x1400047db00)
	/Users/kevm/neomantra/nimble/internal/stream/websocket_server.go:25 +0x2c
panic({0x10557aa00?, 0x1400003d430?})
	/opt/homebrew/Cellar/go/1.22.1/libexec/src/runtime/panic.go:770 +0x124
github.com/lesismal/arpc.(*handler).handle(0x14000000b40, {0x105337336, 0x10}, 0x14000199530, {0x0, 0x0, 0x1?})
	/Users/kevm/go/pkg/mod/github.com/lesismal/arpc@v1.2.15/handler.go:594 +0x3c4
github.com/lesismal/arpc.(*handler).Handle(0x1400045a280?, {0x105337336?, 0x2?}, 0x0?, {0x0?, 0x0?, 0x140000180d0?})
	/Users/kevm/go/pkg/mod/github.com/lesismal/arpc@v1.2.15/handler.go:565 +0x28
gitlab.com/neomantra/nimble/internal/stream.RegisterStreamWithWebSocket[...](0x14000147650, {0x105703d00, 0x14000016168}, 0x1400045a280)
	/Users/kevm/neomantra/nimble/internal/stream/stream.go:45 +0x268

Thank you for your feedback!
Would you please provide the full example that can reproduce the panic?

According to the panic log, I guess it's like this:
package main

import (
	"os"
	"os/signal"
	"syscall"

	"github.com/lesismal/arpc"
)

func handler(ctx *arpc.Context) {
	ctx.Write("hello")
}

func main() {
	server := arpc.NewServer()
	defer server.Stop() // This will be called before main func exit

	// register this method first time.
	server.Handler.Handle("/yourMethod", handler)

	// Register for the same method and cause that panic,
	// then the main func will return and the server.Stop() will be called before the main func exit.
	// Because the server haven't called server.Run(addr) or server.Serve(ln), it doesn't have a listener,
	// so it panic again because the server.Stop() has a log using the listener.Addr
	server.Handler.Handle("/yourMethod", handler)

	go server.Run("localhost:8888")

	quit := make(chan os.Signal, 1)
	signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM)
	<-quit
}

And I got the same panic log:
server.go:10:2: no required module provides package github.com/henrylee2cn/goutil/graceful; to add it:
	go get github.com/henrylee2cn/goutil/graceful
lesismal@192 server % go run ./server.go
panic: handler exist for method /yourMethod
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x100c19084]

goroutine 1 [running]:
github.com/lesismal/arpc.(*Server).Stop(0x1400013e000)
	/Users/lesismal/dev/gopath/pkg/mod/github.com/lesismal/arpc@v1.2.15/server.go:113 +0x54
panic({0x100c61f20?, 0x1400011a130?})
	/Users/lesismal/dev/go/src/runtime/panic.go:914 +0x218
github.com/lesismal/arpc.(*handler).handle(0x1400013a120, {0x100c1c533, 0xb}, 0x100c86d00, {0x0, 0x0, 0x1400013a120?})
	/Users/lesismal/dev/gopath/pkg/mod/github.com/lesismal/arpc@v1.2.15/handler.go:594 +0x3c4
github.com/lesismal/arpc.(*handler).Handle(0x14000062ec8?, {0x100c1c533?, 0x140000526e8?}, 0x100b34750?, {0x0?, 0x140000021a0?, 0x14000062f28?})
	/Users/lesismal/dev/gopath/pkg/mod/github.com/lesismal/arpc@v1.2.15/handler.go:565 +0x28
main.main()
	/Users/lesismal/Desktop/lesismal/arpc/examples/graceful/server/server.go:26 +0xc4
exit status 2

Please fix your handler registration and try it again, if the problem is still there, please try the previous version of arpc you used. If the problem not gone, please provide me a full example that can reproduce it and I will try it.

Ah I see that I didn't follow the stack trace well enough. Sorry to waste your time. Everything seems fine. I have an elaborate handler setup because I have an abstraction layer over ARPC to supporting plugging in different stream sources. I was assuming my problem was novel because of this. I guess it was not.


bazel: update to Xcode 10.3

Signed-off-by: Michael Rebello<EMAIL_ADDRESS>

Looks like we need to wait on Azure to update their images to include Xcode 10.3: https://github.com/microsoft/azure-pipelines-image-generation/blob/master/images/macos/macos-10.14-Readme.md
May also want to use the 12.4 simulators instead of 12.2

CI passed except for 1 test which is red on master - looks like a flake with the simulator.


cmd+Q should not be used as hotkey on mac

With the new version, cmd+Q seems to be used as default hotkey. This should be avoided, since cmd+Q is the default macOS keybinding for quitting an app. (equivalent to alt+f4 on windows)

Thank you for bringing this to my attention! I will avoid using the cmd+Q hotkey in future versions.
Do you have any suggestions for alternative hotkeys that we could use?

Not sure. Afaik, most bindings which only use cmd have some macOS function. If you avoid those, you should be good?

Update: Removing Default Hotkeys to Improve User Experience
I'm releasing an update (0.1.19) that removes the new default hotkeys that were introduced in version 0.1.x. These hotkeys caused conflicts with the system hotkeys used by Mac users. The following default hotkeys have been removed:
Alt + (1,2,3,4)
Ctrl/Alt+Q
Ctrl/Alt+Shift+Q
I apologize for any inconvenience this may have caused and I hope this update will improve your user experience.
Thank you for your continued support and feedback.
Sincerely,
Noureddine


feat(prettier) print ?. when a printing an optional call expression

Current dependencies on/for this PR:

main

PR #1438

PR #1439

PR #1440   👈

This stack of pull requests is managed by Graphite.

Merge activity

Nov 19, 8:32 PM: @Boshen started a stack merge that includes this pull request via Graphite.


Export to a JSON list rather than an object

This PR is no longer useful as JSONListWriter has been removed.


TOX (code -11) failing on CI

Describe the bug
py38 run-test: commands[1] | stestr run
ERROR: InvocationError for command /home/travis/build/PyCQA/bandit/.tox/py38/bin/stestr run (exited with code -11)
___________________________________ summary ____________________________________
ERROR:   py38: commands failed
The command "tox" exited with 1.

To Reproduce
Run the CI over a PR
Expected behavior
Python 3.8dev must works or not be required for merge.
Additional context
I have check some PR (not just me own ones) and all the same error:

https://travis-ci.org/PyCQA/bandit/jobs/563541361
https://travis-ci.org/PyCQA/bandit/jobs/561584410
https://travis-ci.org/PyCQA/bandit/jobs/559360165
https://travis-ci.org/PyCQA/bandit/jobs/564234072
https://travis-ci.org/PyCQA/bandit/jobs/559998302

Appears fix in latest builds


x/crypto/ssh: unexpected empty user field for client conn

What version of Go are you using (go version)?

$ go version
go version go1.15.6 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
It's not necessary here.

What did you do?
After using golang.org/x/crypto/ssh to connect to server successfully, unable to retrieve username used to connect to server.
sshCfg := &ssh.ClientConfig{
    User: "root",
    Auth: []ssh.AuthMethod{
	    ssh.Password("testpw"),
    },
    HostKeyCallback: ssh.InsecureIgnoreHostKey(),
    Timeout: 3 * time.Second,
}

sshClient, _ := ssh.Dial("tcp", "test.server:22", sshCfg)

fmt.Println(sshClient.User())
// gives empty string

What did you expect to see?
fmt.Println(sshClient.User())
// should print "root"

What did you see instead?
Server-side connection does not have this problem. The username at client-side seems to be dropped by accident here.
https://github.com/golang/crypto/blob/0c34fe9e7dc2486962ef9867e3edb3503537209f/ssh/client.go#L79-L81
I will open a pull-request to fix it later.

The reason why I opened this issue is that this bug blocks me from getting the user from existing SSH client.
Without running commands on remote (e.g: whoami), it's not possible to know which user is attached to the existing connection.

cc @FiloSottile


Facing issues while using the bump-version.rb file

[dependabot-core-dev] ~/dependabot-core/bin $ ruby bump-version.rb minor|patch 1
patch: **** Only garbage was found in the patch input.

I think there's some confusion here... This script is used for creating/tagging releases of dependabot-core itself... it's not intended to be used by end users.


[BUG] A link not working in Readme.md

Description
A link under GitHub Ui in readme.md file that is redirecting user to LinkFree quickstart guideline is not working.
I can fix it easily, can i work on that ?
Screenshots
No response
Additional information
No response

Hey, go ahead. The correct link is - https://linkfree.io/docs/quickstart-json. As it's part of the GitHub Section.

 The correct link is - https://linkfree.io/docs/quickstart-json. As it's part of the GitHub Section.

Ahm... when i got assigned this issue, it was 12:00AM in my country. So, at that time i went to sleep, in hope i will get assigned this issue, and i will fix it tommorow morning. but now it is already fixed by someone :(

Ahm... when i got assigned this issue, it was 12:00AM in my country. So, at that time i went to sleep, in hope i will get assigned this issue, and i will fix it tommorow morning. but now it is already fixed by someone :(

Hey,
Ya. someone fixed the issue by mistake.Please look for different issues


[dataset] Remove label data

[dataset] Remove label data

Before this patch, label.dat was only used to get number of classes,
unfortunately, it was clashing with how databuffer_generator is getting
the number of classes and creating some inconsistency. This patch fixes
the issue by deprecating label data.

* Checked TCT and there is no critical issue that makes tests fail with
this PR.

**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1372. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @zhoonit, nntrainer/dataset/databuffer.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1372-202107141627560.89647793769836-43de16152bf543290f2e75725f952a0e98f4f7ec/.


Installation error @OA/PathItem

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Desktop
OS: Win10 20H2
Wamp: Laragon 5.0.0 21053 (php 7.4.19)
npm: 6.14.8
node: 14.15.1
laravel: 8.0(fresh install)
stuck on
i just install new laravel (8.0) and then install badaso, but that error appear
php artisan badaso:setup

i have same issues , are you have done with this issues? @rizkiheryandi

i have same issues , are you have done with this issues? @rizkiheryandi

Fixed on latest release, please update.
Thank you 😊


Hey there.

We are doing a survey on globally distributed software engineering focused on open source projects. If you have some spare time we would really appreciate your response. The form takes about 10 minutes. Thanks in advance!
Survey can be found here

Hey there @tvheems !
Unfortunately, this issue tracker is not a suitable place for running survey advertisements; dealing with stuff like this takes away from our precious hobby time spent on maintaining the project.
If you wish to collaborate or get help from the framework's maintainers on your private project that is not directly related to Falcon, please consider at least Gold Membership. Thanks!


INVALID_DIR_NAME

Ran oao for the first time.
oao status
Error: INVALID_DIR_NAME
    at validatePkgName (/Users/burdon/.config/yarn/global/node_modules/oao/lib/utils/readSpecs.js:88:11)
    at readOneSpec (/Users/burdon/.config/yarn/global/node_modules/oao/lib/utils/readSpecs.js:75:3)
    at /Users/burdon/.config/yarn/global/node_modules/oao/lib/utils/readSpecs.js:46:25
    at Array.forEach (native)
    at _callee$ (/Users/burdon/.config/yarn/global/node_modules/oao/lib/utils/readSpecs.js:45:22)
    at tryCatch (/Users/burdon/.config/yarn/global/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/Users/burdon/.config/yarn/global/node_modules/regenerator-runtime/runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (/Users/burdon/.config/yarn/global/node_modules/regenerator-runtime/runtime.js:117:21)
    at step (/Users/burdon/.config/yarn/global/node_modules/oao/lib/utils/readSpecs.js:24:191)
    at /Users/burdon/.config/yarn/global/node_modules/oao/lib/utils/readSpecs.js:24:361

Could you please give more details (monorepo structure, basically)?

I had the same error, it happened to me because the dir name of one of the packages didn't match the package name (as defined in package.json)

Is it a scoped package?

I saw this error when ./packages/my-pkg/package.json:name !== 'my-pkg'.
This error message needs to be more explicit -
https://github.com/guigrpa/oao/blob/master/src/utils/readSpecs.js#L63,
since the previous mainStory.error does not get logged to console.

Made the error more explicit. Thanks for the suggestion!

Shipped in v0.10.3 (published with oao publish --single, by the way!)


Disaggregated TiFlash support encryption at rest

What problem does this PR solve?
Issue Number: close #8351
Problem Summary:
What is changed and how it works?
https://github.com/pingcap/tiflash/pull/8566 need to merge first.
The main changes in https://github.com/pingcap/tiflash/pull/8585/commits/e2b450ce1082f1797195d6911ff965bda9ee8518

Only encrypt user data (DMFile/data Page)
Get the master key from tikv through FFI
Get whether one keyspace enable encryption from tikv through FFI
Each keyspace has its own encryption key, all data in the keyspace will be encrypted by the encryption key.
Blobfile will not be encrypted, since we will encrypt each page instead.

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/run-all-tests

/run-unit-test


Switch from MD5 to BLAKE3?

The BLAKE3 is a far more faster and better security. It will be a good replacement for MD5.

Holy shit, RustCrypto as library is very ancient and currently deprecated so I definetely take care of this.

MD5 was selected specifically because Erlang (and therefor pleroma) can do it natively. The security really doesn't matter that much here, because these are only alive for about a minute before becoming invalid, while using MD5 makes it easy to implement for whoever is using the service.

Alright, I will keep MD5 then.

What about something like SHA-256?

What about something like SHA-256?

Seems that erlang does support this one, but the change has to be backwards compatible somehow.

What about something like SHA-256?

Seems that erlang does support this one, but the change has to be backwards compatible somehow.


feat: add tmpl function required

Resolves #572
Force error test with this values.yaml.gotmpl and without any environment variables CLUSTER_NAME  and DNS_ZONE has been set
# values.yaml.gotmpl
dnsZone: {{ required "Either DNS_ZONE or CLUSTER_NAME required" (coalesce (env "DNS_ZONE") (env "CLUSTER_NAME")) }}

error message will be shown as:

in helmfile.yaml: in .helmfiles[23]: in helmfile.yaml: failed to render values files "values.yaml.gotmpl": failed to render [values.yaml.gotmpl], because of template: stringTemplate:2:12: executing "stringTemplate" at <required "Either DNS_ZONE or CLUSTER_NAME required" (coalesce (env "DNS_ZONE") (env "CLUSTER_NAME"))>: error calling required: Either DNS_ZONE or CLUSTER_NAME required

Well, I don't know why CircleCI didn't trigger build, maybe my branch has been already built in CircleCI https://circleci.com/workflow-run/964cd5ac-0929-4434-9dbf-85c1df4053e1


Start web server

Instructions state :
pi@raspberrypi:~ $ sudo cp -R /tmp/Roomberry-1.0.0/web-app/ /var/www/
cp: cannot stat '/tmp/Roomberry-1.0.0/web-app/': No such file or directory
pi@raspberrypi:~ $ sudo cp -R Roomberry-1.0.0/web-app/ /var/www/
This should be sudo cp -R Roomberry-1.0.0/web-app/ /var/www/
Can you please elaborate on the next steps needed to start and reach the webserver ?
THANK YOU !!!

Tony,
You will need a Raspberry Pi (not the Zero) running apache2 with PHP enabled. I think in this link you can find a good guide on how to do this.
Once the server is up and running, place the web-app in the WEB_ROOT path (usually /var/www/). You will probably need to install some additional libraries (php5-curl for instance), but this will depend on what linux distribution you are using. Have a look at the errors logged by apache to find out what libraries you need.
Some further explanations can also be found in my blog.
Thanks!
Dani

Okay thank you Dani !! Would you mind documenting the apache2 config file for use with Roomberry ?


.gql files not supported

There are two types of valid file extensions for GraphQL files: .graphql and .gql
The code generators on android only supports .graphql extensions and will not find .gql extensions.
Android Studio 3.3
Apollo-Android v1.0.0-alpha5

Pr welcome. I don't consider this a high priority item


Forestry farm on the moon crashing

Forge Version
<IP_ADDRESS>60
Galacticraft Version
e0aaa31
Log or Crash Report
https://mclo.gs/9CmcoFx
Reproduction steps
First reported over https://github.com/xJon/Tekkit-2/issues/45, seems to be caused by operating a Forestry farm on the moon.

Not sure if this incompatibility should be resolved on Forestry's or Galacticraft's end.


EOS-22429: Added Alex workflow

Signed-off-by: Venkatesh K<EMAIL_ADDRESS>Use of Inclusive words are harmful such as gender favoring, polarizing, race related, religion inconsiderate, or other unequal phrasing in text. Alex is the tool to scan the inclusive words and post the results in PR annotations.

hi @venkuppu-chn ,
Can you please add description to commit message and PR summary please?
Regarding the changes :
As I understand, this tool addition is for catching the contentious keywords automatically.
I believe we already used to have periodic flexera scans for catching such keywords and generating Jenkins reports for the same.
Are we replacing that flexera scanning with this?

hi @venkuppu-chn ,
Can you please add description to commit message and PR summary please?
Regarding the changes :
As I understand, this tool addition is for catching the contentious keywords automatically.
I believe we already used to have periodic flexera scans for catching such keywords and generating Jenkins reports for the same.
Are we replacing that flexera scanning with this?

Flexera scan only for security vulnerabilities. It will not scan a any inclusive word (Problematic words) and report it in PR.

@venkuppu-chn ,
Thanks for adding PR description.
Can you confirm if commit message is also added?
Also please make a single commit.
Thanks!

@venkuppu-chn, please post a link to some document or confluence page regarding approval of this tool for its usage in Seagate, if you can post some details (documentation) regarding the decision making about incorporating this tool then it would be good.


NS dataset question

Hi,
In the PDE datasets page, the NS dataset(viscosity: 1e-4) has shape of [50, 64, 64, 1000] and for the first index i know this is total time step.
In your code, I saw this comment

T=40 for V1e-3; T=20 for V1e-4; T=10 for V1e-5;

Why are you only using 30 time steps despite there being a total of 50 time steps?

@zongyi-li

This is due to the chaotic nature of the NS equation. For large Reynolds number, the Lyapunov exponents get large and the predictable time interval will be shorter. In general we can only match the statistics of highly chaotic systems.


Updates the split title when the discussion title is renamed

added a quick fix for #8 to update the split title after discussion title is changed . added all changes to one single pull request.

Thanks for the comments and instructions . I'll see what I can do :)

You rock @prestorondo thank you!
🙇

Let me know when I can take another look 👍

it's ready sir, please have a look at the latest commit 😀

Thanks I made a few changes in my commit, I will review the workings before tagging soon!


Clean up

@nini-faroux there are no descriptions in this PR, so unless I read the code or the commit messages there's no way to tell what its intention is, and no way to verify that the PR is doing what it says it's doing. I will include a PR template to follow as a guide for future PRs.

Thanks @Randy1Burrell - I gave just a short overview of the PR on Slack beforehand, but good point I'll add a more detailed overview here and do so for all the future ones too

Sure, in terms of the style I'm using this file - https://github.com/yaadlabs/DAO/blob/nf/clean-up/fourmolu.yaml - to format it automatically (using fourmolu -i src for example). It just makes it so that it will always be consistent, and I'm using the recommended settings from the MLabs style guide (https://github.com/mlabs-haskell/styleguide#code-formatting).


Change license to MIT

#127

Coverage remained the same at 74.76% when pulling a8783bf5d4dfd3838c5206dfc5e02b67648ee61c on change_license into 402bc031b424923b89feea390a84a2c15a9b1fdb on develop.

Coverage remained the same at 74.76% when pulling a8783bf5d4dfd3838c5206dfc5e02b67648ee61c on change_license into 402bc031b424923b89feea390a84a2c15a9b1fdb on develop.

This is great! Thank you!


OSM File Loader (Load only) tool falsely loads elements with osmSupportingElement='yes'

Hi @ThomasEmge,
I have noticed an issue specific to the new OSM File Loader (Load only) tool. The issue may be specific to the processing of buildings, but may also be a more general issue related to multipolygons and their tagging and processing.
What I am seeing is that in cases where the outer way of a multipolygon has the same building=yes tag as the multipolygon itself, that it still gets inserted in the Polygon table, even though this element would  be assigned osmSupportingElement=yes had it been loaded with the Load OSM File tool. This leads to an undesirable stacking of a false building contour of the outer way combined with the correct multipolygon.
CORRECTION to the above paragraph:
The specific example multipolygon shown here is this one:
http://www.openstreetmap.org/relation/357082
It actually turns out this feature does not have a building=yes tag on the multipolygon relation, which in fact has no tags. It just has building=yes on the outer, which, according to the changes related to #72, now get properly transferred to the multipolygon.
However, in the context of the OSM File Loader (Load only) tool, all osmSupportingElement=yes features of the Polygon and PolyLine table should be discarded, as this tool no longer creates the osmSupportingElement field showing the difference between the features, so features can no longer be distinguished or removed by using a Definition Query. In this case this means discarding the Polygon based on the outer way.
@ThomasEmge:
Is this issue possibly related (and maybe even solved but not yet released) in issue #117?
The following images show the issue:
The first image shows the outer way with the building=yes tag as created by the OSM File Loader (Load only) tool selected in ArcMap, this feature should have been discarded. Notice it overlaps with the multipolygon which sits on top:

The second image shows the relation with building=yes tag as created by the OSM File Loader (Load only) tool selected in ArcMap, this feature is correct:

The third image shows the outer way with ID 45671472 correctly set to osmSupportingElement=yes by the Load OSM File tool:

The fourth image  shows the mulitpolygon with ID 357082 correctly set to osmSupportingElement=no by the Load OSM File tool:

Well, the tool works as designed but I do see the issue of 'overlapping rings' for the building. Deleting the geometry is not really an option as I can't determine at loading time if the geometry (like the outer way) is involved in several other features.

Quote by @ThomasEmge:

"Since there is no longer an osmSupportingElement on polygons or lines, everything with an ‘attribute’ will be rendered. Which in this case, because the outer way has a key-value pair of “building=yes” it is rendered. "

I agree there is some ambiguity here, but this is a quite clear case:

The multipolygon doesn't have any tag itself
The outer way has (a) tag(s)
Tags are now transferred to the multipolyon, as per the solution for #65 "Option needed to automatically move tags from outer way to multipolygon relation (Load OSM File tool)", which mimics the behaviour of osm2pgsql.

I really think that in these cases where tags are transfered, that the multipolygon presentation overrides the outer, and the outer should be removed.
There is no other way, the bad consequence of not removing the outer, is that we now end up with two features having the same tag set. This is really not how it should be. With the Load OSM File tool, this was easy to overcome, as the "osmSupportingElement" field allowed to distinguish the features. Any feature having osmSupportingElement=yes could be hidden using a Definition Query.
This is no longer the case with the new tool. While the absence of the osmSupportingElement field by itself is not bad, the only logical conclusion is that in case tag transfer takes place, the outer should be ditched.

Well, the tool works as designed but I do see the issue of 'overlapping rings' for the building. Deleting the geometry is not really an option as I can't determine at loading time if the geometry (like the outer way) is involved in several other features.

@ThomasEmge
In the specific case there is tag transfer, you must be able to determine if the feature is part of a multipolygon, because otherwise you wouldn't have been able to implement #65, and wouldn't have been able to build the multipolygons. Or am I missing something?

as I can't determine at loading time if the geometry (like the outer way) is involved in several other features.

Could you delete them at the end of the process, by adding some field keeping track of "involvement with other features". If none, ditch them at the end?

The tool would be able to tell that the transfer is supposed to happen but it is does require an update to an existing row like setting the osmSupportingElement attribute to true. For the tool is means that I have at least 2 types of cursors open on the feature class and with the new tool bringing it down to one cursor brings a nice performance gain.
Let try some options for tracking "involved features".


TC - Create list of data cleanup requirements for Mismo team

See work done by Shelby in #2 . We need to create a comprehensive list of data quality corrections that need to be done before data is sent to Mismo. Here is a start to generate discussion:

Baby, test, and junk names need to be removed or replaced with standard value.
Invalid phone number need to be removed
Address should be correctly formatted
If addresses are not a real address, it should be removed
Date of Birth should be a valid Date of Birth

Here is an additional list of items that will need to be cleaned up before Mismo.

Remove +4 from Zip Code

I have also included a file from Shelby that include placeholder data.
WIR Placehold Data .docx


Simple and Advanced search bar to comb through timelines, characters, etc.

We need a search bar that allows users to search for specific lines of text, event names, character names, etc. - basically anything.
Can use Discord as reference which lets you filter what you're searching - such as "in:textevent I ma poo" to search ONLY in text events for the sentence "I ma poo".
Dunno about the search markup yet for advanced tags, but for simple search it should be able to look through legit anything - in my head it's a simple search with a filter for the resource files associated with the plugin.

Seems pretty complex for now, but is a good idea.


Implement windows stack tracing

Thanks very much for this I'll take a look tomorrow

Wow awesome!

Perhaps the major concerns with windows stack traces is that we should make people aware that in order to resolve names for windows stack traces the pdb files associated with each node module or executable must be included in the project.

LGTM :+1:
@raymondfeng Do you want to give it the once over or should I just get on and push it?

Now this has landed and we have windows support also suggesting we semver the release and go for 1.0.0? @raymondfeng

Hi , when the marge  will be doing ?

@Drillyus OK I think no news is good news from @raymondfeng
Will push today.

ok thanks , i need that to finalize a Node module :)

@Drillyus that is now in NPM as 1.0.0 as we are using semantic versioning from this point on

Thanks you :)


require third argument.

I have a project which uses require.js and r.js for bundling. Now I make migration to webpack. Require.js support third argument in require, for example:
require(['thirdparty/js/jqwidgets/globalization/globalize.culture' + culture], function() {
      // success. module exists and is loaded. do something
      }, function() {

        // if locale not supported load DEFAULT_LOCALE
        culture = DEFAULT_LOCALE;
        require(['thirdparty/js/jqwidgets/globalization/globalize.culture' + culture], function() {

        });
      });

but when I use webpack i get error:
 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
What can I do in this situation? I use "webpack": "2.1.0-beta.25"

found the same issue https://github.com/webpack/webpack/issues/2641


Add tests of vendor management view pages

Next step as part of #332 is to set up tests of the vendor index page in the vendor_loads plugin. I have some (non-passing) starting code on this draft PR: https://github.com/sul-dlss/libsys-airflow/pull/376

I figured out that the reason for the 308 HTTP error is the URL needed a / on the end. But now the test is failing because of a database error:
FAILED tests/apps/vendor_app/test_vendor_management_view.py::test_vendor_views - airflow.exceptions.AirflowNotFoundException: The conn_id `vendor_loads` isn't defined

Maybe the vendor_loads isn't being set up for the tests to work?


We need to constrain the view extents of the user map to the world

When zooming out we should see only one world!

Currently if you zoom out a long way, you see several copies of the earth map side by side. We should limit zoom level to prevent this some how.

See https://www.mapbox.com/mapbox.js/example/v1.0.0/disable-world-wrapping/

world wrapping is now disabled.,


Add navigator bar to the BookList page

Is your feature request related to a problem? Please describe.
The booklist page does not have a navigation bar.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
I want to add the one present on the main website on booklist page as well.

A clear and concise description of what you want to happen.

Someone work on this issue already


Brought togehter the latest changes in script generation

merged the latest changes to atlas scripts and brainatlas-api
I've moved atlas_gen out of brainatlas_api though as there's no need to have these one-off scripts as part of the pip-isntallable package.
If that's a problem we can move it back in.

Things left to do:

Using @vigji 's latest code to make sure that ratatlas.py conforms to the structure and standards of the other atlas generating scrips.  (@FedeClaudi )
Making sure that mouseatlas.py and fishatlas.py use the metadata_utils.py functions to create the .txt and .csv files (@vigji )
Adding the cration of structures.csv to metadata_utils.py (@adamltyson )

I've moved atlas_gen out of brainatlas_api though as there's no need to have these one-off scripts as part of the pip-isntallable package.

I'm not sure, but I think the current form will:

Install two packages (atlas_gen and brainatlas_api)
Break the tests

I've fixed the tests in master, could you merge master, and see if they can be fixed?

Ops, my ignorance of how this stuff works shows.
I will close this, merge from master and move atlas_gen back into brainatlas_api, then submit again

no need to have these one-off scripts as part of the pip-isntallable package.

I think we can do this by adding the directories to be ignored for installation to here:
https://github.com/brainglobe/brainatlas-api/blob/1945eb4294c12d112f3b77cd62e7b06b0bad1519/setup.py#L27


error MT2001: Could not link assemblies, xamarin.ios lib based on Microsoft SignalR

Embedinator return error "MT2001: Could not link assemblies" without any description while creating obj-c lib from xamarin.ios class library project(compiles in .dll) that uses Microsoft SignalR nuget package
Steps to Reproduce

Create Xamarin.iOS class library project
Add nugget package "Microsoft.AspNetCore.SignalR.Client" version "1.0.0-preview1-final"
nuget.config produces error, so decided to delete it and use more stable
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client">    <Version>1.0.0-preview1-final</Version>  </PackageReference>
inside .csproj file.
In lib method use some code from SignalR package
Compile project succesfuly, so we have .dll file
Downloaded embedinator (from another project by nuget.config) and used as
Embedinator-4<IP_ADDRESS>/tools/objcgen ../MySignalRCoreWrap.dll --target=framework --platform=iOS --output=output -c --debug
This gives an error that cannot find references
I review all errors after each try and find library names that project can not fint.
I put all .dll files in root. I found .dll's by delete contents of ~/.nuget/packages/ and restore packages only for current project, so thare are dll versions only for my project.
After all errors associated with library names finished there are new error apears
error MT2001: Could not link assemblies. Reason: Error while processing references of 'SignalRCore, Version=1.0.6828.32368, Culture=neutral, PublicKeyToken=null'
If remove code from step 4, so SignalR will not be used it is all okey

So I do not know what to do now, any suggestions?
Environment
Mac OS 10.13.3
Embeddinator-4000 v0.1 (0.4: 7664197)
Build Logs
Full log you can see in attached file:
embedinator_full_log.txt
Sample project
SignalRCore.zip

Can you try running this command manually (this is from your log), and then add -v -v -v -v at the end to make the output more verbose?
/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/bin/mtouch --dev /Users/morozov/Documents/qq/output/iPhoneOS/SignalRCore --abi=armv7,armv7s,arm64 --sdkroot /Applications/Xcode.app --targetver 8.0 --dsym:false --msym:false --embeddinator /Users/morozov/Documents/qq/SignalRCore.dll -r:/Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/mono/Xamarin.iOS/Xamarin.iOS.dll --sdk 11.4 --linksdkonly --xml=output/bindings.xml --registrar:static --cache /Users/morozov/Documents/qq/output/iPhoneOS/build-cache --debug<EMAIL_ADDRESS>--target-framework Xamarin.iOS,v1.0 "--gcc_flags=-force_load /Users/morozov/Documents/qq/output/iPhoneOS/SignalRCore.a"  -v -v -v -v

Hi @crash481,
Have you had a chance to try what Rolf asked in the previous comment:
https://github.com/mono/Embeddinator-4000/issues/706#issuecomment-421059583?

I could not find solution and use another lib, thanks


[ENHANCEMENT] Reranker image support

Is your feature request related to a problem? Please describe.
Reranking using an image query results in an error.
Describe the solution you'd like
Reranker for search results should support image queries.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Can you please add more detail? Like code snippets, desired results, and suggestions.


Adding Israeli holidays

I'd like to suggest adding Israeli holidays.
Note that Israel has a few different calendars for holidays: they are not different between states (no states in Israel) but rather between religions: Jewish, Christian and Muslim holidays are all different.
Furthermore, they don't all follow the Georgian calendar. Libraries such as pyluach might be convenient in implementing these holidays.
I will try to address the issue, and update accordingly.

Hi,
contributions are welcome!
I'll be waiting for yours, thank you very much


Waterfall

This is the first pass at a waterfall series -- hopefully the style of inheriting from bar a new bar base class is okay.
There was a suggestion of a generic floating bar series: that is not what I've done here. If that's still interesting then that can be extracted from the waterfall series and refactored.

As per our discussion in Slack, I think this needs a bit of re-working. The waterfall concept should be introduced via a non-visual component in the same way that d3 stack layout works.

relpaced by #772


Travis CI building failure due to upstream bug

The travis CI build is failing. It's even failing for a previous commit that successfully passed all the checks. So I think something is up with Travis-CI.
@knikolla @henn
Here's a portion of the job log:

2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 247, in loadapp
2016-10-31 19:06:58.614 5399 ERROR keystone     return loadobj(APP, uri, name=name, **kw)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 272, in loadobj
2016-10-31 19:06:58.614 5399 ERROR keystone     return context.create()
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 710, in create
2016-10-31 19:06:58.614 5399 ERROR keystone     return self.object_type.invoke(self)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 144, in invoke
2016-10-31 19:06:58.614 5399 ERROR keystone     **context.local_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/util.py", line 55, in fix_call
2016-10-31 19:06:58.614 5399 ERROR keystone     val = callable(*args, **kw)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/urlmap.py", line 31, in urlmap_factory
2016-10-31 19:06:58.614 5399 ERROR keystone     app = loader.get_app(app_name, global_conf=global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 350, in get_app
2016-10-31 19:06:58.614 5399 ERROR keystone     name=name, global_conf=global_conf).create()
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 362, in app_context
2016-10-31 19:06:58.614 5399 ERROR keystone     APP, name=name, global_conf=global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 450, in get_context
2016-10-31 19:06:58.614 5399 ERROR keystone     global_additions=global_additions)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 559, in _pipeline_app_context
2016-10-31 19:06:58.614 5399 ERROR keystone     APP, pipeline[-1], global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 454, in get_context
2016-10-31 19:06:58.614 5399 ERROR keystone     section)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 476, in _context_from_use
2016-10-31 19:06:58.614 5399 ERROR keystone     object_type, name=use, global_conf=global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 406, in get_context
2016-10-31 19:06:58.614 5399 ERROR keystone     global_conf=global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 296, in loadcontext
2016-10-31 19:06:58.614 5399 ERROR keystone     global_conf=global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 328, in _loadegg
2016-10-31 19:06:58.614 5399 ERROR keystone     return loader.get_context(object_type, name, global_conf)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 620, in get_context
2016-10-31 19:06:58.614 5399 ERROR keystone     object_type, name=name)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 640, in find_egg_entry_point
2016-10-31 19:06:58.614 5399 ERROR keystone     pkg_resources.require(self.spec)
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/pkg_resources/init.py", line 952, in require
2016-10-31 19:06:58.614 5399 ERROR keystone     needed = self.resolve(parse_requirements(requirements))
2016-10-31 19:06:58.614 5399 ERROR keystone   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/pkg_resources/init.py", line 844, in resolve
2016-10-31 19:06:58.614 5399 ERROR keystone     raise VersionConflict(dist, req).with_context(dependent_req)
2016-10-31 19:06:58.614 5399 ERROR keystone ContextualVersionConflict: (amqp 1.4.9 (/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/lib/python2.7/site-packages), Requirement.parse('amqp<3.0,>=2.1.1'), set(['kombu']))
2016-10-31 19:06:58.614 5399 ERROR keystone
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***
*** uWSGI is running in multiple interpreter mode ***
spawned uWSGI master process (pid: 5399)
spawned uWSGI worker 1 (pid: 5421, cores: 1)
spawned uWSGI http 1 (pid: 5422)
Using cached python_glanceclient-2.5.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): keystoneauth1>=2.10.0 in ./.venv/lib/python2.7/site-packages (from python-openstackclient)
Collecting python-novaclient!=2.33.0,>=2.29.0 (from python-openstackclient)
Using cached python_novaclient-6.0.0-py2.py3-none-any.whl
Collecting python-cinderclient!=1.7.0,!=1.7.1,>=1.6.0 (from python-openstackclient)
Using cached python_cinderclient-1.9.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): python-keystoneclient!=2.1.0,>=2.0.0 in ./.venv/lib/python2.7/site-packages (from python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): stevedore>=1.17.1 in ./.venv/lib/python2.7/site-packages (from osc-lib>=1.0.2->python-openstackclient)
Collecting os-client-config!=1.19.0,!=1.19.1,!=1.20.0,!=1.20.1,!=1.21.0,>=1.13.1 (from osc-lib>=1.0.2->python-openstackclient)
Using cached os_client_config-1.22.0-py2.py3-none-any.whl
Collecting simplejson>=2.2.0 (from osc-lib>=1.0.2->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): funcsigs>=0.4; python_version == "2.7" or python_version == "2.6" in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): iso8601>=0.1.11 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): debtcollector>=1.2.0 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): pyparsing>=2.0.1 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): netifaces>=0.10.4 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): pytz>=2013.6 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): monotonic>=0.6 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): netaddr!=0.7.16,>=0.7.13 in ./.venv/lib/python2.7/site-packages (from oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): PrettyTable<0.8,>=0.7 in ./.venv/lib/python2.7/site-packages (from cliff>=2.2.0->python-openstackclient)
Collecting unicodecsv>=0.8.0; python_version < "3.0" (from cliff>=2.2.0->python-openstackclient)
Collecting cmd2>=0.6.7 (from cliff>=2.2.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): PyYAML>=3.1.0 in ./.venv/lib/python2.7/site-packages (from cliff>=2.2.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): requests>=2.10.0 in ./.venv/lib/python2.7/site-packages (from python-glanceclient>=2.5.0->python-openstackclient)
Collecting warlock!=1.3.0,<2,>=1.0.1 (from python-glanceclient>=2.5.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): positional>=1.1.1 in ./.venv/lib/python2.7/site-packages (from keystoneauth1>=2.10.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): oslo.serialization>=1.10.0 in ./.venv/lib/python2.7/site-packages (from python-novaclient!=2.33.0,>=2.29.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): oslo.config>=3.14.0 in ./.venv/lib/python2.7/site-packages (from python-keystoneclient!=2.1.0,>=2.0.0->python-openstackclient)
Collecting requestsexceptions>=1.1.1 (from os-client-config!=1.19.0,!=1.19.1,!=1.20.0,!=1.20.1,!=1.21.0,>=1.13.1->osc-lib>=1.0.2->python-openstackclient)
Using cached requestsexceptions-1.1.3-py2.py3-none-any.whl
Collecting appdirs>=1.3.0 (from os-client-config!=1.19.0,!=1.19.1,!=1.20.0,!=1.20.1,!=1.21.0,>=1.13.1->osc-lib>=1.0.2->python-openstackclient)
Using cached appdirs-1.4.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): wrapt>=1.7.0 in ./.venv/lib/python2.7/site-packages (from debtcollector>=1.2.0->oslo.utils>=3.16.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): jsonschema<3,>=0.7 in ./.venv/lib/python2.7/site-packages (from warlock!=1.3.0,<2,>=1.0.1->python-glanceclient>=2.5.0->python-openstackclient)
Collecting jsonpatch<2,>=0.10 (from warlock!=1.3.0,<2,>=1.0.1->python-glanceclient>=2.5.0->python-openstackclient)
Using cached jsonpatch-1.14-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): msgpack-python>=0.4.0 in ./.venv/lib/python2.7/site-packages (from oslo.serialization>=1.10.0->python-novaclient!=2.33.0,>=2.29.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): rfc3986>=0.2.2 in ./.venv/lib/python2.7/site-packages (from oslo.config>=3.14.0->python-keystoneclient!=2.1.0,>=2.0.0->python-openstackclient)
Requirement already satisfied (use --upgrade to upgrade): functools32; python_version == "2.7" in ./.venv/lib/python2.7/site-packages (from jsonschema<3,>=0.7->warlock!=1.3.0,<2,>=1.0.1->python-glanceclient>=2.5.0->python-openstackclient)
Collecting jsonpointer>=1.9 (from jsonpatch<2,>=0.10->warlock!=1.3.0,<2,>=1.0.1->python-glanceclient>=2.5.0->python-openstackclient)
Using cached jsonpointer-1.10-py2-none-any.whl
Installing collected packages: unicodecsv, cmd2, cliff, requestsexceptions, appdirs, os-client-config, simplejson, osc-lib, openstacksdk, jsonpointer, jsonpatch, warlock, python-glanceclient, python-novaclient, python-cinderclient, python-openstackclient
Successfully installed appdirs-1.4.0 cliff-2.2.0 cmd2-0.6.9 jsonpatch-1.14 jsonpointer-1.10 openstacksdk-0.9.8 os-client-config-1.22.0 osc-lib-1.2.0 python-cinderclient-1.9.0 python-glanceclient-2.5.0 python-novaclient-6.0.0 python-openstackclient-3.3.0 requestsexceptions-1.1.3 simplejson-3.10.0 unicodecsv-0.14.1 warlock-1.2.0
+source ../keystonerc
++export OS_USERNAME=admin
++OS_USERNAME=admin
++export OS_PASSWORD=s3cr3t
++OS_PASSWORD=s3cr3t
++export OS_PROJECT_NAME=admin
++OS_PROJECT_NAME=admin
++export OS_USER_DOMAIN_ID=default
++OS_USER_DOMAIN_ID=default
++export OS_PROJECT_DOMAIN_ID=default
++OS_PROJECT_DOMAIN_ID=default
++export OS_IDENTITY_API_VERSION=3
++OS_IDENTITY_API_VERSION=3
++export OS_AUTH_URL=http://localhost:5000/v3
++OS_AUTH_URL=http://localhost:5000/v3
+ADMIN_PASSWORD=s3cr3t
+./tools/sample_data.sh
Config file not found, using default configs.
2016-10-31 19:07:02.563 5435 WARNING keystone.assignment.core [req-368e24c4-a757-4159-bb84-45eb752a76d3 - - - - -] Deprecated: Use of the identity driver config to automatically configure the same assignment driver has been deprecated, in the "O" release, the assignment driver will need to be expicitly configured if different than the default (SQL).
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications [req-368e24c4-a757-4159-bb84-45eb752a76d3 - - - - -] Failed to construct notifier
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications Traceback (most recent call last):
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/keystone/notifications.py", line 309, in _get_notifier
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications     transport = oslo_messaging.get_notification_transport(CONF)
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/oslo_messaging/notify/notifier.py", line 172, in get_notification_transport
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications     allowed_remote_exmods, aliases)
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/oslo_messaging/transport.py", line 192, in get_transport
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications     invoke_kwds=kwargs)
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/stevedore/driver.py", line 46, in init
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications     verify_requirements=verify_requirements,
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/stevedore/named.py", line 69, in init
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications     verify_requirements)
2016-10-31 19:07:02.726 5435 ERROR keystone.notifications   File "/home/travis/build/CCI-MOC/hil/ci/keystone/keystone/.venv/local/lib/python2.7/site-packages/stevedore/extension.py", line 171, in _load_plugins

This is related to upstream bug https://bugs.launchpad.net/oslo.messaging/+bug/1638263
Patch that fixes the issue https://review.openstack.org/#/c/392135/

This is a bug from upstream, we are waiting the upstream to fix the bug and then remove our temporary workaround.

I'll leave this issue open until the bug from upstream is fixed and we have a permanent workaround.

Upstream bug is fixed, we removed the tmp fix in #681 .


SHAKE documentation updates for default output length.

Fixes #18586
In order to not break existing applications the OpenSSL documentation
related to SHAKE has been updated.
The openssl dgst commandline app will log a warning to stderr if
SHAKE128 is used without the -xoflen option.
Background:
All digests algorithms (including XOF's) use the bitlen as the default output length.
This results in a security strength of bitlen / 2.
This means that SHAKE128 will by default have an output length of 16
bytes and a security strength of 64 bits.
For SHAKE256 the default output length is 32 bytes and has a security
strength of 128 bits.
This behaviour was present in 1.1.1 and has been duplicated in the
provider SHAKE algorithms for 3.0.
The SHAKE XOF algorithms have a security strength of
min(bitlen, output xof length in bits / 2).

Checklist

[x] documentation is added or updated
[x] tests are added or updated

I think the failure of the external oqs provider test is relevant. I do not see it anywhere else and re-running the test reproduces it. I suppose it uses SHAKE256 and it breaks with the digest len check and the warning.

I would revert ed775de as IMO that causes the oqs provider test failure.

I would revert ed775de as IMO that causes the oqs provider test failure.

Not sure if this is a good idea - I expect this was probably not the expected behaviour?
Do have any thoughts on this @baentsch

Do have any thoughts on this @baentsch . Does your provider have its own xof algorithms?

No(t that I would have implemented them): The oqsprovider only uses SHA256...SHA512 internally (when doing hybrid, classic/quantum-safe signatures), no SHAKE. There are constituent QS-algorithms using XOFs, though... The one failing right at the start (dilithium) is one of them. Will do some digging to understand the change/failure as I don't immediately understand it by reading the code in the PR...

Ah, it is not the ed775de change that breaks this as the failure in the test was there from the beginning commit of this PR. So probably any warning for XOF breaks the test.

Will do some digging to understand the change/failure as I don't immediately understand it by reading the code in the PR...

I will remove the line that caused the issue. If you are not using the SHAKE algorithm then everything is ok on your end.. If you are make sure to set the xoflen

@mspncp please reconfirm

@mspncp ping

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@mspncp ping again for reconfirmation

This pull request is ready to merge

Merged to master and 3.0 branches. Thank you.


Add automated validation check for API

One way this could be done is through github actions. A way of doing this via the swagger editor is described in a blog post: https://swagger.io/blog/api-design/validate-openapi-definitions-swagger-editor/
Accordingly, it would look something like this
on: [push]

jobs:
  test_swagger_editor_validator_remote:
    runs-on: ubuntu-latest
    name: Swagger Editor Validator Remote

    steps:
      - uses: actions/checkout@v2
      - name: Validate OpenAPI definition
        uses: char0n/swagger-editor-validate@v1
        with:
          definition-file: docs/openapi.yaml

Perhaps a badge could also be added to the repository's README.md to show that it has been validated as well.

I'm not sure I understand the value in this, why do we want to do this. If we are just wanting to make sure the swagger complies with the openapi standard wouldn't it be better to do that with linting? At this point the swagger is strictly a design artifact that is used internally as the contract between the UI and API dev. It's validity will not have any impact on the function or performance of the API.

There is also a good VSCode plugin that let's you preview the swagger that provides as-you-edit validation. On GitLab the web ui also renders the swagger API explorer, unfortunately GitHub does not appear to be implementing this.
My only concern is putting an un-necesary validation step in the deployment pipeline. Think about a hot-fix that needs to get through CI as quickly as possible. Do we want to put a requirement in that workflow that serves no performance or functional purpose.
If we had a "public" API that we were documenting for users outside of our organization, and using an API explorer view to support them, then this becomes a valid concern.
Having said all of that I see no reason why we shouldn't put that in place, if we can use over-ride features in GitHub when needed, it is a good quality measure.


cgo argument has Go pointer to Go pointer with Go v1.6.1

It seems that the rules of passing pointer between C and Go changed golang/go#12416.

Thanks.
So the problem now is that Go code may pass a Go pointer to C provided that the Go memory to which it points does not contain any Go pointers.. In Go 1.6 this is checked at runtime.
The only way I see this implemented for Go1.6 is to have a (global) array/map of callbackData. Then C callback wrapper would receive an identifier of callback, and call a corresponding likelihood function. This was also suggested on their github at some point.
Today it's possible to use the trick of passing pointer as an uintptr to hide it from runtime checks. But this workaround might stop working in the future, since the idea behind this restriction is to be able to move go objects in memory freely, so it might happen that by the time C callback is called, the pointer to callbackData is not valid anymore.

An example of doing more or less what I described: https://github.com/golang/go/wiki/cgo#function-variables

Hi, what do you think about #7?
I used the approach described from the golang wiki; this should be thread safe.
Functions registerCallback, unregisterCallback and lookupCallback are quite universal. It's possible to move them to a separate library; but I don't think it's a good idea to create an external dependency.

There are two possible workaround for those who are affected by the bug.

You can use idavydov/go-lbfgsb.  You would need to change your imports and reinstall go-lbfgsb.
Or you can run your software with GODEBUG=cgocheck=0 environment variable.

I hope eventually this gets fixed in the mainstream.

There are two possible workaround for those who are affected by the bug.

You can use idavydov/go-lbfgsb.  You would need to change your imports and reinstall go-lbfgsb.
Or you can run your software with GODEBUG=cgocheck=0 environment variable.

I hope eventually this gets fixed in the mainstream.

I have use  idavydov/go-lbfgsb.

D:/Go/src/go-lbfgsb/lbfgsb.go:341 +0x5b
go-lbfgsb.(*Lbfgsb).Minimize(0xc00010fe88, 0x4c9bb0, 0xc000042260, 0xc00000c2b0, 0x2, 0x2, 0x0, 0x20, 0x0, 0x0, ...)
D:/Go/src/go-lbfgsb/lbfgsb.go:341 +0x546
main.main()
D:/Go_prj/src/go-lbfgsb/example/example.go:103 +0x5c5
So I have to use  GODEBUG=cgocheck=0 environment variable. Then all seems good.

Hi @hiok2000 ,
According to your error, you are using in fact afbarnard/go-lbfgsb, not idavydov/go-lbfgsb. (E.g., see the line numbers; in idavydov version there are no functions call at line 341).
Could you try to make sure you are using  idavydov/go-lbfgsb? Worst case, delete the directory manually or something similar.
If you still observer this error in idavydov/go-lbfgsb, could you open a ticket there with a reproducible example ideally?

Hi @hiok2000 ,
According to your error, you are using in fact afbarnard/go-lbfgsb, not idavydov/go-lbfgsb. (E.g., see the line numbers; in idavydov version there are no function calls at the line 341).
Could you try to make sure you are using idavydov/go-lbfgsb? Worst case, delete the directory manually or something similar.
If you still observer this error in idavydov/go-lbfgsb, could you open a ticket there with a reproducible example ideally?

I am sorry. You are right. I still use afbarnard/go-lbfgsb. I still got error in .f90 file in idavydov/go-lbfgsb. I replace .f90 and make file in idavydov/go-lbfgsb by .f30 and makefile afbarnard/go-lbfgsb. Everything is fine. I have get a good result using in my holtwinters forecast projects. Thank you both.