Bluetooth: Controller does not inform host about CIS establishment failure

Describe the bug
The CIS that has been accepted by Host, gets rejected by Controller with Unsupported Link Layer Parameter Value. The controller does not generate LE CIS Established event to the host, thus Host keeps the reference to the connection that has not been established.
Expected behavior
The parameters should be validated before LE Accept Connected Isochronous Stream Request is sent to host.
On the other hand, in case the Host accepts the CIS, but the CIS was not created for some reason, the LE CIS Established event shall be generated to inform the host, so that it can release it's resources.
e.g.

Logs and console output
The Host accepts the CIS Request:
< ACL Data TX: Handle 0 flags 0x00 dlen 12                                                                    #467 102.477800
      ATT: Handle Value Notification (0x1b) len 7
        Handle: 0x0014
          Data:<PHONE_NUMBER>
        ASCS: Audio Stream Endpoint Control Point (Handle: 0x0014)
        Operation response: Enable
        Number of ASEs: 1
         ASE ID: 1
          Response code: Success
< ACL Data TX: Handle 0 flags 0x00 dlen 16                                                                    #468 102.478300
      ATT: Handle Value Notification (0x1b) len 11
        Handle: 0x0017
          Data:<PHONE_NUMBER>03020600
        ASCS: Audio Stream Sink Endpoint (Handle: 0x0017)
        ASE ID: 1
        Enabling
          CIG: 1
          CIS: 1
          Metadata: 0x03020600
> HCI Event: LE Meta Event (0x3e) plen 7                                                                      #471 102.805300
      LE Connected Isochronous Stream Request (0x1a)
        ACL Handle: 0
        CIS Handle: 6
        CIG ID: 0x01
        CIS ID: 0x01
< HCI Command: LE Accept Connected Isochronous Stream Request (0x08|0x0066) plen 2                            #472 102.805500
        CIS Handle: 6
> HCI Event: Command Status (0x0f) plen 4                                                                     #473 102.805700
      LE Accept Connected Isochronous Stream Request (0x08|0x0066) ncmd 1
        Status: Success (0x00)
> HCI Event: Disconnect Complete (0x05) plen 4                                                                #474 104.443600
        Status: Success (0x00)
        Handle: 0
        Reason: Remote User Terminated Connection (0x13)

The controller rejects the LL_CIS_REQ

The parameters look as follows

LL_CIS_REQ_rejected.btt.zip
BAP_USR_STR_BV_367_C_2023_08_08_13_48_46.zip
To Reproduce
Steps to reproduce the behavior:

Execute PTS test case BAP_USR_STR_BV_367_C

zephyr-v3.4.0-2075-g32bd3aa781

Duplicate of https://github.com/zephyrproject-rtos/zephyr/issues/59173?

@MariuszSkamra Is this a duplicate of https://github.com/zephyrproject-rtos/zephyr/issues/59173? Can it be closed? If not, please respond and remove the Stale label.


Consider upgrading to a component-based API

This library is awesome for the breath it provides for components and interactions and accessibility. Everything is clearly very well considered. And the goal of it being completely customizable is admirable and why I'd use it.
But as a user, the majority of my time using it is spent in very frustrating to debug "glue code" between the many hooks. It may not feel confusing as maintainers because you know the ins and outs of every hook, but let me tell you as a user, this is an extremely confusing library.
A big part of this is because of the decision to only provide hooks as the main API. The existing hooks are great for low-level use cases where some hyper-specific customization is required. But 90% of use cases don't need this.
I think this library would greatly benefit from taking an approach similar to Headless UI, which is based around components. With smart use of internal context to connect things together they are able to eliminate all of the tedious glue code, allowing you to focus purely on the components, state, and events. It's wonderfully simple to reason about. (And the existing hooks API could still be available for the 10% of cases that need extreme customization.)

For context, take a look at how implementing a Listbox differs between React ARIA's current API, and how HeadlessUI does it...

React ARIA
import React from "react";

import {
  useSelect,
  HiddenSelect,
  mergeProps,
  useFocusRing,
  useButton,
  useListBox,
  useOption,
  useOverlay,
  DismissButton,
  FocusScope
} from "react-aria";
import type { AriaListBoxOptions } from "@react-aria/listbox";
import type { AriaSelectProps } from "@react-types/select";
import type { Node } from "@react-types/shared";
import { ListState, Item, useSelectState } from "react-stately";

const animals = [
  { id: "red panda", name: "Red Panda" },
  { id: "cat", name: "Cat" },
  { id: "dog", name: "Dog" },
  { id: "aardvark", name: "Aardvark" },
  { id: "kangaroo", name: "Kangaroo" },
  { id: "snake", name: "Snake" }
];

export function ReactAria() {
  return (
    <Select label="Favorite Animal">
      {animals.map((animal) => (
        <Item key={animal.id}>{animal.name}</Item>
      ))}
    </Select>
  );
}

function Select<T extends object>(props: AriaSelectProps<T>) {
  let state = useSelectState(props);
  let ref = React.useRef(null);
  let { labelProps, triggerProps, valueProps, menuProps } = useSelect(
    props,
    state,
    ref
  );
  let { buttonProps } = useButton(triggerProps, ref);
  let { focusProps, isFocusVisible } = useFocusRing();
  return (

        {props.label}

      <HiddenSelect
        state={state}
        triggerRef={ref}
        label={props.label}
        name={props.name}
      />
      <button
        {...mergeProps(buttonProps, focusProps)}
        ref={ref}
        className={`p-1 pl-3 py-1 relative inline-flex flex-row items-center justify-between rounded-md overflow-hidden cursor-default shadow-sm border-2 outline-none ${
          isFocusVisible ? "border-pink-500" : "border-gray-300"
        } ${state.isOpen ? "bg-gray-100" : "bg-white"}`}
      >

          {state.selectedItem
            ? state.selectedItem.rendered
            : "Select an option"}

      </button>
      {state.isOpen && (
        <Popover isOpen={state.isOpen} onClose={state.close}>
          <ListBox {...menuProps} state={state} />
        </Popover>
      )}

  );
}

function ListBox(
  props: {
    listBoxRef?: React.RefObject<HTMLUListElement>;
    state: ListState<unknown>;
  } & AriaListBoxOptions<unknown>
) {
  const ref = React.useRef<HTMLUListElement>(null);
  const { listBoxRef = ref, state } = props;
  const { listBoxProps } = useListBox(props, state, listBoxRef);
  return (

      {[...state.collection].map((item) => (
        <Option key={item.key} item={item} state={state} />
      ))}

  );
}

function Option(props: { item: Node<unknown>; state: ListState<unknown> }) {
  const { item, state } = props;
  const ref = React.useRef<HTMLLIElement>(null);
  const { optionProps, isDisabled, isSelected, isFocused } = useOption(
    { key: item.key },
    state,
    ref
  );

  let text = "text-gray-700";
  if (isFocused || isSelected) {
    text = "text-pink-600";
  } else if (isDisabled) {
    text = "text-gray-200";
  }

  return (

      {item.rendered}

  );
}

function Popover(props: {
  popoverRef?: React.RefObject<HTMLDivElement>;
  children: React.ReactNode;
  isOpen?: boolean;
  onClose: () => void;
}) {
  const ref = React.useRef<HTMLDivElement>(null);
  const { popoverRef = ref, isOpen, onClose, children } = props;
  const { overlayProps } = useOverlay(
    {
      isOpen,
      onClose,
      shouldCloseOnBlur: true,
      isDismissable: false
    },
    popoverRef
  );
  return (
    <FocusScope restoreFocus>

        {children}
        <DismissButton onDismiss={onClose} />

    </FocusScope>
  );
}

HeadlessUI
import React, { useState } from "react";

import { Listbox } from "@headlessui/react";

const animals = [
  { id: "red panda", name: "Red Panda" },
  { id: "cat", name: "Cat" },
  { id: "dog", name: "Dog" },
  { id: "aardvark", name: "Aardvark" },
  { id: "kangaroo", name: "Kangaroo" },
  { id: "snake", name: "Snake" }
];

export function HeadlessUi() {
  const [selectedAnimal, setSelectedAnimal] = useState<
    typeof animals[number] | null
  >(null);
  return (
    <Listbox value={selectedAnimal} onChange={setSelectedAnimal}>
      <Listbox.Label className="block text-sm font-medium text-gray-700">
        Favorite Animal
      </Listbox.Label>

        <Listbox.Button className="bg-white relative w-full border border-gray-300 rounded-md shadow-sm pl-3 pr-10 py-2 text-left cursor-default focus:outline-none focus:ring-1 focus:ring-indigo-500 focus:border-indigo-500 sm:text-sm">
          {selectedAnimal?.name ?? "Choose…"}
        </Listbox.Button>
        <Listbox.Options className="absolute z-10 mt-1 w-full bg-white shadow-lg max-h-60 rounded-md py-1 text-base ring-1 ring-black ring-opacity-5 overflow-auto focus:outline-none sm:text-sm">
          {animals.map((animal) => (
            <Listbox.Option
              key={animal.id}
              value={animal}
              className={({ active }) =>
                `
                  cursor-default select-none relative py-2 pl-3 pr-9
                  ${active ? "text-white bg-indigo-600" : "text-gray-900"}
                `
              }
            >
              {({ selected, active }) => (
                <>

                    {animal.name}

                </>
              )}
            </Listbox.Option>
          ))}
        </Listbox.Options>

    </Listbox>
  );
}

The HeadlessUI code is much easier to reason about because all of the glue code is handled under the covers by the library using context. Whereas the React ARIA code is full of hooks and refs and state that needs to be connected together just right to get things to work.

Edit: Unfortunately I wasn't super clear, but I'm advocating for both hooks and components APIs. Obviously the hooks are low-level and useful for edge cases. But I think adding components alongside them would be nicer to use for 90% of cases.

Hey, thanks for the feedback! React Aria is certainly low level. Our goal when releasing it was that it could accommodate the widest possible number of use cases. This includes the ability to fully customize the appearance, DOM structure, behavior, etc. We aim to let you have just as much control as if you were building the component from scratch with the raw DOM APIs as you might have before, but also provide a lot of behavior and a11y for you. Our hope was that higher level libraries like Headless UI would be built on top of React Aria. It's only possible to do this one way: the lower level hooks have to come first.
We did look at component and render-props based APIs when designing React Aria. In fact, we started thinking about this problem long before Hooks even existed. However, we never found the right way to do this that offered enough customization potential. Our goal was to build something that we could build React Spectrum (our design system) off of, and I don't think we could have done that without lower level access in some areas.
A few considerations:

The components are mainly designed to be used as part of a larger design system. Headless UI is definitely simpler to use when you only use one component, but you may find yourself duplicating some things in a larger project. For example, in the React Aria code you showed above, the ListBox and Popover components can be reused for other things, like standalone lists, and menus. This can be hard for us to show on the documentation site for components that compose several pieces together like this, because you need all pieces first before you can put them together. Perhaps there's more we can do to improve this.
Custom styling often requires extra DOM elements, or access to internal state. For example, a Tabs component with an animating line to indicate the selection requires an extra element and access to the DOM nodes for each tab to measure their sizes. Or perhaps you want to enable virtual scrolling for long lists, but still enable keyboard navigation even when all of the elements aren't rendered. Coupling components to a pre-defined DOM structure and relying on context definitely has limitations.
Another goal is to share as much as possible across platforms. For example, the react-native-aria project is reusing our React Stately hooks to build equivalent versions for React Native. This type of sharing wouldn't have been possible with monolithic components.
Customizing the behavior sometimes requires overriding properties returned by React Aria. For example, if you wanted to override some keyboard behavior for a specific case, you could override the onKeyDown prop returned from a hook and call it conditionally from within your own implementation. Doing this with a component API that renders the DOM elements for you would be tricky.
There's a tradeoff between functionality and bundle size. Some components might have a lot of functionality that might not be useful across all products. For example, tables could have column resizing/reordering, drag and drop, multi-selection, etc. and not all of this may always be needed. We could include all of that in a single component with props to turn things on or off, but the tradeoff is that you're always paying the bundle size cost for code that's not actually used. Hooks provide a clean way to share small pieces of functionality that can be composed together within a single component, with the downside being, as you said, some glue code.

That being said, I do think there is a lot we can do to improve here without compromising on these goals. We've started at the lowest level layer possible, and are slowing working our way up the stack to provide higher level abstractions. Here are some ideas we have been thinking about:

Combine some hooks that are very commonly used together. For example, buttons almost always need a focus style. We could combine the call to useFocusRing into useButton and return an isFocusVisible state so you don't need to do that yourself. useOverlay could have a focus scope built in for focus trapping. useSelect could potentially have useButton builtin, etc. The tradeoff is that if you're using the native :focus-visible, a different focus trapping library, or something else you get a bit of code you don't use, however, for some things this may be worth it. Figuring out where to draw that line is an interesting challenge.
Expose more states from the hooks that could be used for styling. We've started doing this already – the isSelected/isFocused/etc. values returned from useOption were recently added. This avoids you needing to compute this yourself. We plan to continue adding more of these across the hooks.
Reduce the amount of things you need to pass between hooks, e.g. between parents and children. We can often attach multiple things to the state object that you pass down rather than needing to pass a bunch of other options to child hooks.
Create higher level hooks that combine more things together. This is related to the first one, but in some cases, rather than merging everything into one hook and causing larger bundles for everyone, we could keep the lower level hooks and also provide some higher level wrappers for common combinations.

Overall, the goal should be to reduce the number of different hooks you need to call for common cases, while retaining flexibility to drop down to lower level APIs where needed.
We don't currently have plans to offer an official component-based wrapper around our hooks, mainly for lack of time, but we would encourage and assist the community in such an effort. Personally, I would love to see multiple libraries with different takes on such an API built on top of React Aria, e.g. integrating with or optimizing for specific styling methodologies (e.g. tailwind, css-in-js, etc.). If you or anyone else is interested in working on such a library, we'd be happy to assist in any way we can. 😄

Hey @devongovett, thanks for the thoughtful response!
I totally agree that hooks provide more control for certain edge cases where you need to get really custom (although some of those examples are solvable by components). I think hooks would still be key as the tiny building blocks, but an additional component-based layer would solve 90% of use cases without the current complexity.
It's hard to overstate how much simpler the Headless UI approach is. Even if this library is for UI kits, I'd be willing to bet that a lot of people come to it when first implementing a specific component that isn't well handled by browser defaults. (In my case this was trying to add an autocomplete component to a fairly simple UI kit.)
Totally makes sense if it's a lack of time concern though. Hopefully Headless UI adds more components over time and the mismatch in breadth will be reduced. I could definitely see a useful library that aimed to do what they're doing but with React ARIA under the hood—I'll hold out hope that it's React ARIA itself one day!

I think it's difficult to directly compare React Aria and Headless UI because to me it seems that they serve slightly different purposes (I personally use both). I would say that the purpose of React Aria—and @devongovett can correct me if I'm wrong—is to effectively create your own flavor of a Headless UI, either for your own internal design system or for an open source project built on top of it.
The components that you create with React Aria can have any API you want. So instead of building a one-off components with React Aria like in your example, you can create a general purpose one with a reusable API. That means you could technically take your Headless UI example and change the import from import { Listbox } from "@headlessui/react" to import { Listbox } from "./listbox-built-with-react-aria" and use them the exact same way, render props included if you are so inclined! 😀
So to me it's more about the level of control you have over the abstraction. Headless UI comes out of the box ready to go, but offers less customization. React Aria requires some assembly, but you can build any API you want.

🙌  I'm glad this was raised, btw hi @ianstormtaylor, I'm currently building a text editor with Slate, great lib!
I've been thinking about this for a long time. In our org, we are using a combination of react-aria and Radix UI, and it's been on my mind to build a bunch of Radix-like primitives on top of react-aria / react-stately. I think that, while nothing beats hooks when it comes to extensibility, they have achieved a really good balance between having a high-level and easy to use abstraction, and making it extensible. I see two interesting patterns for this:

Their recently simplified component extension API: asChild prop for slottable components.
Optionally controlled state, making it possible to have uncontrolled components that still work correctly.

I bet it wouldn't be too hard to build primitives with a similar approach, on top of react-aria and react-stately.
One point where Radix and react-aria diverge is that Radix is designed around native HTML components like , while react-aria sometimes wraps these elements with custom APIs like the press events API. In fact, this has been a little troublesome for us when combining Radix and react-aria. I guess it'd be a challenge to make something that works well for both react-aria based components and native HTML ones.
Anyway, that's just my two cents. If I had more time I'd definitely try to start a project like this! :)

PD: this thread by @diegohaz (reakit creator) seems relevant too: https://twitter.com/diegohaz/status/1229499924062048260
Seems like Reakit is the most similar to what a react-aria based component library would look like. It has low-level hooks and high-level components, and you can use whatever you want depending on your needs. It basically bridges the gap between the two worlds, and it's similar to how I'd envision a react-aria based component library.
Relevant Reakit docs: https://reakit.io/docs/composition/#props-hooks

@sandren thanks for the response. I totally get that, I definitely appreciate the flexibility of the hooks from React ARIA, and I'm very glad this library exists. I know you could theoretically build all of Headless UI on top of React ARIA—I'm definitely not arguing for eliminating them.
My point is more that I'd bet the majority of users of this library don't require the granularity (and added complexity) that hooks provide. Just look at the difference in imports between the two examples:
// Headless UI
import { Listbox } from "@headlessui/react";

// React ARIA
import {
  useSelect,
  HiddenSelect,
  mergeProps,
  useFocusRing,
  useButton,
  useListBox,
  useOption,
  useOverlay,
  DismissButton,
  FocusScope
} from "react-aria";
import type { AriaListBoxOptions } from "@react-aria/listbox";
import type { AriaSelectProps } from "@react-types/select";
import type { Node } from "@react-types/shared";
import { ListState, Item, useSelectState } from "react-stately";

With the current state of things... if it's ever possible for me to avoid React ARIA's APIs when adding a new component to my UI kit I will do that. And only when a nicer component-based package doesn't exist will I use React ARIA's hooks.
So I opened this issue to bring this up, because I think the library would go from useful to amazing if it provided both hooks and components. (Imagine a @react-components or something to complement the existing packages.)
@DaniGuardiola thank you! That is awesome. Radix UI seems like exactly what I was looking for—similar to Headless UI but with a larger collection of components. The asChild pattern is very smart. And looks like it can replace the majority of my uses of React ARIA—the only big one that's missing for my use case is autocomplete/combobox.

looks like it can replace the majority of my uses of React ARIA

Yep, we're using Radix everywhere it fits for its simplicity, and Aria in places where we need more customization or for things that Radix hasn't covered yet, like the awesome press interactions. I think it's possible to have the best of both worlds, although it doesn't come without complications when you have to combine the two :laughing:
Hit me up when you try and fail to use a react-aria based button as a Radix trigger, I'll help and save you a world of pain :)

Hey all, thanks for your comments, this is a good discussion. I agree that having both higher level components and lower level hooks would be great. All of the libraries mentioned are good, but I think they are optimized for different use cases. As far as I can tell, all of them could be built on top of React Aria internally if their authors desired.
Here are some tradeoffs with various component-based APIs:

Headless UI is clearly optimized for usage with Tailwind (makes sense). The className prop allows passing a function which receives an object containing various states like active, selected, etc. This can be used to generate classes on demand based on state, which is required for usage with Tailwind since it doesn't rely on custom CSS selectors. However, using Headless UI with another styling framework might be challenging because it doesn't expose states when you aren't using class names.
Radix and Reakit (and also Reach UI) are optimized for use with plain CSS or CSS-in-JS. For styling, they expose states as attributes (e.g. data-state="active" or aria-selected="true") on their DOM elements, which can be styled using CSS selectors. This makes it difficult to use with something like Tailwind, where you aren't writing CSS selectors, and need to conditionally apply classes instead. Same would be true for some CSS-in-JS libraries that don't use CSS selectors. It's also challenging to use if the component doesn't expose whatever internal state you need as a data attribute.

These also tend to get complicated very quickly as soon as you want to do something even a little custom. Animated tabs is a good example. In order to do this, you need to take ownership of the state so you have access to the selection beyond just DOM attributes. Here's how Reach UI shows to do it: https://reach.tech/tabs/#animation. And here's an example using React Aria: https://codesandbox.io/s/practical-monad-punzo?file=/src/App.js. Because you already own the state, it's trivial to add a useEffect and an extra DOM element to render the selection.
I think it will be hard to design a single component-based API around React Aria that works for a wide number of use cases. That's why I hope the community will begin to explore different APIs for this that are optimized for specific use cases, e.g. react-aria-tailwind, react-aria-styled-components, etc. We would love to help wherever we can here! 😄

I briefly prototyped an example of what this could look like using the Select component in your example above, but moving all of the styling to be passed in with an API similar to what Headless UI offers: https://codesandbox.io/s/intelligent-wright-7wi39?file=/src/App.js.
It uses functions passed to className for styling, which receive various states to apply conditional classes. It also uses render props to customize item elements and trigger contents. State is shared between all of the components via context, along with props returned from React Aria's useSelect hook.
This type of API does have a couple limitations though. Rather than passing <Item> elements as children, as React Aria currently expects, this type of API needs to allow passing any elements you want. Normally, React Aria uses the Item children to determine what items are in the collection. These are used to implement keyboard navigation, typeahead, etc. When there are arbitrary children, and the items could be at any nesting level, this is more challenging.
Headless UI and other libraries solve this using either a registration system using context, or by querying the DOM tree. Both of these require all of the items to be rendered to the DOM to work. You can't implement virtualized scrolling because keyboard navigation wouldn't be able to access items that are out of view and not rendered. That's why React Aria queries the JSX tree for Item elements instead, but it can't do this at arbitrary nesting.
For this demo, I instead relied on an items prop being an array of objects with a specific shape (id and name properties). This provides React Aria enough information to implement keyboard navigation, and we can pass those objects back to a render prop to render the actual Option elements. It's a little less ergonomic of an API than providing <Item> children, but it's the only other way to work with React Aria's existing hooks and support virtualized scrolling.
Anyway, hopefully this example shows that it's possible to build an API like Headless UI on top of React Aria, and what the implementation could look like. 🙂

@devongovett thanks for the follow ups!
Thing is though, those examples are sort of proving my point. The underlying logic in the <Select> example is very convoluted to follow. I can't imagine anyone (but a maintainer of React ARIA themself) writing that code without lots of time spent debugging things they hooked up incorrectly. And if you modified it to include TypeScript typings—like many would need—the confusion would increase another 2-3x.
It just reinforces my belief that React ARIA is great because it can do all these things, but I personally hope to touch it as little as possible, because its current abstractions just don't match what most people need. I'd feel irresponsible recommending people base a new UI Kit on it because of the complexity it would force on them, and instead I'd recommend it as a way to fill the gaps as a last resort.


don't install libevdev-dev for travis build

Don't need that anymore, as the dependancy on it has been removed.

Indeed.


Package request: Synology Hyper Backup Explorer

Project description
A desktop tool for browsing, decrypting, and extracting different versions of backup data in Hyper Backup repositories
Metadata

homepage URL: https://www.synology.com/en-global/releaseNote/HyperBackupExplorer
source URL: -
license: unknown
platforms: linux, darwin

Download URLs
Linux: https://global.synologydownload.com/download/Utility/HyperBackupExplorer/3.0.1-0156/Linux/x86_64/HyperBackupExplorer-3.0.1-0156-linux.tar.bz2
Darwin: https://global.synologydownload.com/download/Utility/HyperBackupExplorer/3.0.1-0156/Mac/x86_64/HyperBackupExplorer-3.0.1-0156-mac.dmg

Add a :+1: reaction to issues you find important.

Nice to have!


Add missing prototypes

Is your feature request related to a problem? Please describe.
Enable -Wmissing-prototypes and observe warnings
Example identified in code review:
https://github.com/nasa/cFE/blob/e80aae94e0f56b868657daba965c590766a4dc57/modules/es/fsw/src/cfe_es_apps.c#L1589
Describe the solution you'd like
Add prototype
Describe alternatives you've considered
None
Additional context
Code reivew, specific case related to #1307
Requester Info
Jacob Hageman - NASA/GSFC

Note there's 51 missing prototypes flagged by gcc in the main source code, 742 with unit tests enabled.  Vast majority are really static (but not declared as such).  Removing 7.0.0 milestone (future work).

What is the preferred solution here?

Do nothing (i.e. if prototypes are not needed, nothing needs changing here)
Make functions not required outside file scope static
Add missing prototypes to header file  (let's say only for code for now, not test functions)

I like option 1 for it's simplicity, elegance, and economy.  I'm not aware of any benefits to adding an unnecessary prototype would be.  Could close (up to @dmknutsen @dzbaker).

I guess adding static would make it clear to the reader/reviewer, so no harm in that option.

I like option 1 for it's simplicity, elegance, and economy. I'm not aware of any benefits to adding an unnecessary prototype would be. Could close (up to @dmknutsen @dzbaker).

I like option 1 as well, although I don't feel strongly about it.

It certainly doesn't get any simpler, elegant or economical than doing nothing...
I guess unless @dmknutsen disagrees, this can be closed with no changes required.

Option 1 sounds great!


SpeedTest times out / Fast does not

Hi, I am used to using Speedtest.net for my testing but when I select it with a 60000 timeout it does not complete. But the Fast.com speed test does work with 60000 timeout.
I am measuring Upload and Download.
I am not 100% sure, maybe the Speedtest.net integration is not working properly? Or is Fast.com just faster… no pun intended

Hello,
I would like to inform you that a beta version of Universal Speedtest v2 has been released, which contacts measuring servers without using Puppeteer (chromium browser) and should solve most problems.
For this reason, I am now closing this issue, but if you find a problem, do not hesitate to open a new problem.
Thank you for understanding

Nice work, I was able to test now and it was great. Love the update.

I have updated my scripts and it works great. Thank you for the update.
Chris Spiegl
ChrisSpiegl.com | Consulting https://ChrisSpiegl.com/consulting | What I
am doing /now https://ChrisSpiegl.com/now
YouTube Channel https://ChrisSpiegl.com/youtube | Macher.Cafe (German
Podcast) https://ThatMaker.Life
PGP Public Key https://ChrisSpiegl.com/chrisspiegl.asc fingerprint: 6646
6F22 1B88 A080 7748 E6F9 318B A27E 4ACD 1AC9
On Fri, Dec 10, 2021 at 6:39 PM Karel Krýda @.***>
wrote:

Hello,
I would like to inform you that a beta version of Universal Speedtest v2
has been released, which contacts measuring servers without using Puppeteer
(chromium browser) and should solve most problems.
For this reason, I am now closing this issue, but if you find a problem,
do not hesitate to open a new problem.
Thank you for understanding
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/karelkryda/universal-speedtest/issues/7#issuecomment-991165491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAILVQALBRZIPKHVU5NB3P3UQI3MJANCNFSM5H5KSMNA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


 not binding to formControlName property

Bug, feature request, or proposal:
Bug
What is the expected behavior?
and an <md-radio> component. However when I wire it up like I would with a standard <md-input> if throws an error. For example
component.html
    <form [formGroup]="myFormGroup (ngSubmit)="doSomething()">
    <md-input #birthday formControlName="birthday" placeholder="Birthday"></md-input>
    <md-radio-group formControlName="gender" align="end">
        <md-radio-button value="m">Male</md-radio-button>
        <md-radio-button value="f">Female</md-radio-button>
    </md-radio-group>
    </form>

component.ts
    export class Component {

        myFormGroup: FormGroup;

        constructor(formBuilder: FormBuilder) {
            this.myFormGroup = formBuilder.group({
                birthday: [this.myModel.birthday, Validators.required],
                gender: [this.myModel.gender, Validators.required]
            });
        }
    }

Even if I change the formgroup to:
this.myFormGroup = formBuilder.group({
                 birthday: [this.myModel.birthday, Validators.required],
                 gender: new FormControl()
             });

I still receive the same error.
What is the current behavior?
The error message this gives me is:

ngModel cannot be used to register form controls with a parent
formGroup directive.  Try using
formGroup's partner directive "formControlName" instead.  Example:
<div [formGroup]="myGroup">
  <input formControlName="firstName">
</div>

In your class:

this.myGroup = new FormGroup({
   firstName: new FormControl()
});

  Or, if you'd like to avoid registering this form control, indicate that it's standalone in ngModelOptions:

  Example:

<div [formGroup]="myGroup">
   <input formControlName="firstName">
   <input [(ngModel)]="showMoreControls" [ngModelOptions]="{standalone: true}">
</div>

What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
angular: 2.0.2
material: 2.0.0-alpha.9-3,
Is there anything else we should know?

Have you tried to create the form in ngOnInit() instead of in the constructor?

grr....developer error. Thanks @feloy


[MM-48380] ARM build for Windows/Linux

Summary
Attempting to add an ARM64 build for Windows/Linux.
Ticket Link
https://mattermost.atlassian.net/browse/MM-48380
NONE

The files scripts/cp_artifacts.sh, scripts/cp_artifacts.sh, scripts/generate_release_markdown.sh, scripts/generate_release_markdown.sh are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/25339
https://circleci.com/gh/mattermost/desktop/25338
https://circleci.com/gh/mattermost/desktop/25337

The files .circleci/config.yml, scripts/cp_artifacts.sh, scripts/cp_artifacts.sh, scripts/generate_release_markdown.sh, scripts/generate_release_markdown.sh are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/25354
https://circleci.com/gh/mattermost/desktop/25353
https://circleci.com/gh/mattermost/desktop/25352

Artifact links:
https://output.circle-artifacts.com/output/job/cd2a31f7-68cc-40a2-a1c1-969582f5a183/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-linux-arm64.tar.gz
https://output.circle-artifacts.com/output/job/cd2a31f7-68cc-40a2-a1c1-969582f5a183/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-linux-x64.tar.gz
https://output.circle-artifacts.com/output/job/1d610116-f60d-406e-b9b0-e4dab4ada379/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-mac-m1.dmg
https://output.circle-artifacts.com/output/job/1d610116-f60d-406e-b9b0-e4dab4ada379/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-mac-x64.dmg
https://output.circle-artifacts.com/output/job/0c54641a-e878-4bd6-8f25-3dff4ea6f4fc/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-arm64.zip
https://output.circle-artifacts.com/output/job/0c54641a-e878-4bd6-8f25-3dff4ea6f4fc/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-ia32.zip
https://output.circle-artifacts.com/output/job/0c54641a-e878-4bd6-8f25-3dff4ea6f4fc/artifacts/0/tmp/artifacts/mattermost-desktop-5.3.0-develop.1-win-x64.zip

Cherry pick is scheduled.


Why you pull packages from the testing repository?

Is there any reason for that? I would expect something like for drupal image:
RUN echo 'http://alpine.gliderlabs.com/alpine/edge/main' > /etc/apk/repositories && \
    echo 'http://alpine.gliderlabs.com/alpine/edge/community' >> /etc/apk/repositories && \
    echo 'http://alpine.gliderlabs.com/alpine/edge/testing' >> /etc/apk/repositories && \

The new 2.0 images now inherit official php images


#903: Ensure transaction ID is passed through to connection during commit.

Fixes #903.

LGTM. Seems leakier than need be (i.e. we could put the ID in the commit signature and Batch wouldn't need to know about the ID)
Pretty scary that was happening

Having transaction_id in the signature of Transaction.commit would be pretty silly.
My initial pass gave Batch.commit() an optional _transaction_id parameter, documented as "for use only by Transaction.commit(), but pylint put the kibosh on it (it doesn't want the subclass to have a different signature than the superclass.

Changes Unknown when pulling 164e1d8a3b04eca190ed848ab3ed04753778f6b8 on tseaver:903-pass_xact_id_during_commit into ** on GoogleCloudPlatform:master**.


[hotfix][docs] add missing bracket for cli.md

What is the purpose of the change
This pull request add missing bracket for cli.md
Brief change log
add missing bracket for cli.md
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

@tillrohrmann


Fix invalid per user config file name for SSH.

Configuration file names for SSH are:

~/.ssh/config (per user)
/etc/ssh/ssh_config (system wide)

"~/.ssh/ssh_config" is invalid and ignored.

Hi @ksasagit, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

This looks good to me. Thank you for the correction!


Upgrade Ruby to 3.3.0

Context
We want to use the new chars keyword argument in the SecureRandom#alphanumeric method introduced in Ruby 3.3.
Changes proposed in this pull request
Gemfile
Dockerfile
Github actions
Guidance to review
If you're using asdf, you will need to update the ruby plugin asdf plugin update ruby

 Update Ruby to 3.3


FDK test kit

As an FDK author I want to know whether i've done everything I need to to implement a Good FDK.
Write a test suite that drives a consistent set of tests for FDK implementations, to ensure:

FDKs support a given set of features (e.g. Hot/cold etc..)
FDKs respect the current container contract (and verify that changes are supported)

Things to test OTOMH:

http/json/default contract

empty/large/small bodies

handles multiple events
Streaming http (accepts more data than fn memory)
Differ

For implementation I think having a single runner that executes the tests against a container that that uses the FDK and is coded to supply specific responses to each test case?
This would allow matrix/regression testing of FDK and Container contract changes.

So, per our discussion, we need to document list of validation tests to pass (design them as part of API validation tests). Not sure cold mode matter, because it'll go away eventually. I don't like the idea to run tests against the container, we can run them against Fn server with deployed functions.
In addition to things to test is multipart types.


http error

Hi, everything working fine but I am seeing so many errors in the portainer log
2019/04/21 14:24:40 Instance already has defined endpoints. Skipping the endpoint defined via CLI.
2019/04/21 14:24:40 Starting Portainer 1.20.2 on :9000
2019/04/21 14:26:46 http error: No administrator account found inside the database (err=Object not found inside the database) (code=404)
2019/04/21 14:26:47 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2019/04/21 14:26:47 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2019/04/21 14:26:47 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2019/04/21 14:26:47 http error: No administrator account found inside the database (err=Object not found inside the database) (code=404)
2019/04/21 14:26:49 http error: No administrator account found inside the database (err=Object not found inside the database) (code=404)
2019/04/21 14:26:49 http error: No administrator account found inside the database (err=Object not found inside the database) (code=404)
2019/04/21 18:01:25 Templates already registered inside the database. Skipping template import.
2019/04/21 18:01:25 Instance already has defined endpoints. Skipping the endpoint defined via CLI.
2019/04/21 18:01:25 Starting Portainer 1.20.2 on :9000
2019/04/21 18:03:13 Templates already registered inside the database. Skipping template import.
2019/04/21 18:03:13 Instance already has defined endpoints. Skipping the endpoint defined via CLI.
2019/04/21 18:03:13 Starting Portainer 1.20.2 on :9000
2019/04/21 18:04:51 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2019/04/21 18:04:51 http error: Invalid JWT token (err=Invalid JWT token) (code=401)
2019/04/21 18:04:51 http error: Invalid JWT token (err=Invalid JWT token) (code=401)

Thank you

Hi there,
This is normal behaviour and relates to creating a new instatnce of Portainer and not finding existing admin credentials as well as authentication for your session expiring at some point thus Portainer needed a new JWT token.
We will consider altering these messages to give more info and make it clear that they are just warnings/notifications and not errors.

Hi William,
Thank you for your response that would be greatly appreciated.
Have a great day
Hassan
On Mon, 22 Apr 2019, 23:57 William<EMAIL_ADDRESS>wrote:

Hi there,
This is normal behaviour and relates to creating a new instatnce of
Portainer and not finding existing admin credentials as well as
authentication for your session expiring at some point thus Portainer
needed a new JWT token.
We will consider altering these messages to give more info and make it
clear that they are just warnings/notifications and not errors.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/portainer/portainer/issues/2843#issuecomment-485581185,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKT4DLJZYUTXVDI7E7U2YDTPRY7G7ANCNFSM4HHMEBSQ
.

Hi,
Any update on this please :)
Thank you

@mouzzampk2014 this is not on our priority list at the moment and as we've informed you, this is "normal" behavior of Portainer. You don't have to worry.

@deviantony thank you so much for the update. I was just curious trying to understand the logs :)

How should it be fixed?

@745719408 these http error responses aren't actually http errors so I think the solution would be to change them to info as I believe as this is actually what they are. This would require a custom handling of the response instead of relying on the generic error handler
These cases where info is reported as error could include the following:

When Portainer is first run you will see  http error: Invalid JWT token (err=Invalid JWT token) (code=401) as no JWT will be present. You will also see http error: No administrator account found inside the database (err=Object not found inside the database) (code=404) as an admin account has not yet been created.
When a session is expired, you may also see http error: Invalid JWT token (err=Invalid JWT token) (code=401) again this is just info
If you enter the wrong credentials you will see http error: Invalid credentials (err=Unauthorized) (code=422) when really this is info and not a networking error

@itsconquest  Thank you for your response that would

Sorry, this is not true answer @itsconquest . It's a not first start, because I have successfully login, I have no expired session, I have no swarm, but I have no opportunity to connect with local docker.

Everybody is good, now I want to in portainer kubenertes management, but when link to the "HTTP error: Unable to initiate communications with the endpoint (err = open/var/run/secrets/kubernetes. IO/serviceaccount/token:No such file or directory). Have you ever encountered a similar error?Or is there a good solution?Ask for your help

@qinzhiben11 I don't think this is the good issue to comment, could you open a new bug report and give us more details about your environment? (Kubernetes version, Kubernetes platform...)

The error is that kubernetes lacks the token and ca. CRT file. But I don't quite understand how the token file is generated here

I am currently using version 1.18.5 of Kubernetes, which is installed on AMD64

@qinzhiben11 it would be easier for us to diagnose/track this item if you open a separate bug report.

@deviantony When I successfully add Kubernetes, click "Get the data of K8S" and the following error message will be reported. Please take a look
2021/02/18 03:13:11 http: proxy error: net/http: invalid header field value "Bearer eyJhbGciOiJSUzI1NiIsImtpZCI6Ik9pOXNRUDJ5Zy1HZk00bGtoM2VCZ2FsZERmX2VzcWxCc0pvZzBLdjlIUHcifQ.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJrdWJlLXN5c3RlbSIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VjcmV0Lm5hbWUiOiJhZG1pbi10b2tlbi03djhtYiIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50Lm5hbWUiOiJhZG1pbiIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VydmljZS1hY2NvdW50LnVpZCI6ImRmMjY1YmQxLTg2MjMtNGUzYi05NWExLTI2NmE3YmFlNmNlMCIsInN1YiI6InN5c3RlbTpzZXJ2aWNlYWNjb3VudDprdWJlLXN5c3RlbTphZG1pbiJ9.pWZ5o5WrPkllBoh5WDNr6fdeQdRT2AF2SW-3yVTw0HB5BWejfot_QVVvyIsm3mRvY7GxpKWYhUoKln-GrGBkK_HESpE65UVDto8tIqWahg_hGtCY6h1FyKyJU1KGydjWnnMHpD5HmqGfGMkrbG9ZswYf4F1JTB9qRgQtAi8xE4i_kR9meSXoR5L8hrlxNYaHpqt6HBUBgYUELzOgaaGhlmsPfBBM7zO0bMP1fkgUOkeE0wQ1K2UidaDR7IMr0I0pw4UCw_tQt-sfaSsrzDyiYyV2Pz7WAfSud5ac3UramtKh-2W-h9_fPJqoW-Ey72BXw-TSBVge0EGG3TpFZsxpSg\n" for key Authorization


New package DutyCycles: 0.1.0

Registering: DutyCycles
Repository: https://github.com/Quantum-Factory/DutyCycles.jl
Version: v0.1.0
Commit: 9da896e2b2720e97b624a0ff73d84bd10cc57022
Proposed by: @steinQF
Reviewed by: @steinQF
Reference: https://github.com/Quantum-Factory/DutyCycles.jl/commit/9da896e2b2720e97b624a0ff73d84bd10cc57022#commitcomment-33339054

This update was tested with Julia version 1.0.

@fredrikekre Sorry to bother you but is there anything I need to do, seeing that you added the "waiting for author" label and haven't removed that or added this package yet?

No, we just usually leave new package registration open for a little longer.


Added type text/rtf

currently .rtf extension is mapped as "application/text", but there is the mime type "text/rtf" that is not mapped so it has been identified as .bin

It would be nice if you could update the https://github.com/hey-red/Mime project with that.


[BUG] Change storage size to use quantity instead of int64

Describe the bug
Should consider change size to use Kubernetes Quantity or block size check.  Otherwise, the current implementation will incorrectly compare '2G' and '2Gi' as equal.
To Reproduce
Steps to reproduce the behavior:

Apply Command:

PVC=test
kubectl patch -p '{"spec":{"resources": {"requests": {"storage": "2G"}}}}' persistentvolumeclaim ${PVC}

Since patch is not a block size of 4Kb, this will cause error.

E0603 04:22:49.047869       1 engine_controller.go:693] failed to update status for engine test-e-821ce098: Failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-master-head/longhorn [--url <IP_ADDRESS>:10000 backup restore-status], output , stderr, time="2021-06-03T04:22:49Z" level=fatal msg="Error running restore backup command: failed to list replicas for volume <IP_ADDRESS>:10000: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial tcp <IP_ADDRESS>:10000: connect: connection refused\""
, error exit status 1
time="2021-06-03T04:22:49Z" level=info msg="All replicas are failed, set engine salvageRequested to true" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=centos-master-0 owner=centos-master-0 state=detaching volume=test

Apply command

PVC=test
kubectl patch -p '{"spec":{"resources": {"requests": {"storage": "2Gi"}}}}' persistentvolumeclaim ${PVC}

See error

time="2021-06-03T03:58:15Z" level=info msg="Event(v1.ObjectReference{Kind:\"Volume\", Namespace:\"longhorn-system\", Name:\"test\", UID:\"61670bda-95df-4aee-b8b0-28651fbc2f5f\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"7961\", FieldPath:\"\"}): type: 'Normal' reason: 'SucceededExpansion' Succeeds to expand the volume test to size<PHONE_NUMBER>, will automatically detach it if it's not DR volume"
time="2021-06-03T03:58:19Z" level=info msg="Event(v1.ObjectReference{Kind:\"Engine\", Namespace:\"longhorn-system\", Name:\"test-e-bab1fe3e\", UID:\"57a15169-0890-4dbd-9b93-249e893da80e\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"7962\", FieldPath:\"\"}): type: 'Warning' reason: 'Faulted' Detected replica test-r-081e6bf3 (<IP_ADDRESS>:10000) in error"
time="2021-06-03T03:58:19Z" level=info msg="All replicas are failed, set engine salvageRequested to true" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=centos-worker-2 owner=centos-worker-2 state=attached volume=test

Expected behavior
expect size will increase from<PHONE_NUMBER> to<PHONE_NUMBER>
Log
If applicable, add the Longhorn managers' log when the issue happens.
You can also attach a Support Bundle here. You can generate a Support Bundle using the link at the footer of the Longhorn UI.
Environment:

Longhorn version: v.1.1.1
Installation method (e.g. Rancher Catalog App/Helm/Kubectl):
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:

Number of management node in the cluster:
Number of worker node in the cluster:

Node config

OS type and version:
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context
Currently, when this happens, the user needs to increase size to 3Gi to return normal state.

I notice that Longhorn stuck in the expanding loop whenever the user changes PVC size in the format nG. From a quick look at the code, I am not sure why yet. Need more investigation.

Seem related to https://github.com/longhorn/longhorn-manager/blob/master/csi/controller_server.go#L675.  Will fix with https://github.com/longhorn/longhorn-manager/pull/888 by remove equestedSize > existingSize.

Issue resolved along with https://github.com/longhorn/longhorn-manager/pull/888


Add doc and go mod

Hi, this PR contains following changes:

Added documentation to the code
Added go.mod file

@isacikgoz thank you!


More advanced translations

Hi!
We need to translate blocks content and set the different set of blocks for each translation.   Furthermore we need to translate browser fields and media.
After brief code research:

it seems like a quite bulk piece of work
it may cause problems with updates in future

Maybe you have any recommendations how to do it with less pain or maybe plans to implement it in nearest future?

@newvladimirov did you finally find an alternative solution to your issue ?

@bastienrobert yes, we did. We have solutions for all these issues in a different degree of readiness. We did it with some changes in the build script and a bunch of overrides in PHP, so it doesn't looks like a final solution yet.
We will be glad to help you if you have some specific questions!

@newvladimirov do you want to be able to create fully different layouts? Or only exclude/hide some elements in a translation?
If it's only about hiding an element it should be possible and not this hard to add a hide flag and use this or check for existing translation and only render translated blocks.
But a whole different layout would be more work to do.


TS 2.4 regression in --declaration in the presence of optional field

TypeScript: 2.4.2
// result.d.ts
export declare class VideoResult {}
export declare type Result = VideoResult;

// user.ts
import {Result} from './result';
export class X {
  constructor(private x?: Result) {}
}

Compile fails with:
"Parameter 'x' of constructor from exported class has or is using name 'VideoResult' from external module ".../result" but cannot be named."
Changing the x? to just x makes it work.  But then the generated .d.ts is also wrong:
  constructor(private x?: number) {}

generates
    private x;
    constructor(x?: number | undefined);

Both of these scenarios are correct in TS 2.3.

@mhegazy The first issue,

"Parameter 'x' of constructor from exported class has or is using name 'VideoResult' from external module ".../result" but cannot be named."
happens under strict null checks mode as when we resolve the type within the union with undefined, we follow the alias symbol to its target when creating the union type in the checker, and since it is a class type (and not a union, intersection, mapped type, etc) it has no alias symbol registered to attempt as a secondary target for writing its name. Recording a single alias symbol for the type isn't even technically a full fix, as it would be defeated simply by having two aliases and only importing the one which was not recorded.

looks like we can lump this under https://github.com/Microsoft/TypeScript/issues/9944. if the emitter generates module imports for missing types, it would write something like import {VideoResult} from './result'; and avoid the whole issue.

closing in favor of #9944.


Windows 2012 R2, Powershell V4 and a SharePoint Foundation 2010

Hi,
Are you able to tweak this script to work on Windows 2012 R2, Powershell V4 and a SharePoint Foundation 2010?
I've tried running it in Powershell V2 but it won't allow import of active directory module under V2. :(

Hi,
i don't seen your issue. It's big work to check and adapt script for Powershell and i don't have time for this now. Do you want to contribute t projet ?
Regards,
Florent


Server-side syntax highlighting for all code

This PR does a few things:

Remove all traces of highlight.js
Use chroma  library to provide fast syntax highlighting directly on the server
Provide syntax highlighting for diffs + code comments
Re-style code view and unified/split diffs views to try and look a bit more 'modern'
Add custom syntax highlighting styling for regular theme and convert previous arc-green highlighting best I could

Fixes #7729
Fixes #10157
Fixes #11825
Fixes #7728
Fixes #3872
Fixes #3682
And perhaps gets closer to #9553
Suggestions welcome for styling
New Diff:

I think you still need to run npm uninstall highlight.js and commit the results.

I think you still need to run npm uninstall highlight.js and commit the results.

Thanks! fixed

Oh, and npm uninstall domino as well and remove this line.

Oh, and npm uninstall domino as well and remove this line.

fixed

Those suggestions above fix some of colors that are definitely too dark in arc-green for sufficient contrast. Are there any themes for Chroma we could maybe use as a baseline?

This looks to work quite nice. I wonder if we need a mechanism to stop highlighting big files if they take too long, either based on processing time or line count. I think GitHub just stops highlighting around line 20k in a single file.

@silverwind I tried a few but they looked weird on dark green as-is so I tried to just copy the values that were present before. I  don't use/enjoy dark themes so I'm certainly not the best judge probably (I think he current one is difficult to look at too).
If you want to try and test how some look on dark green, I think the quickest way would be to set this to false so it uses inline styles for the moment:
https://github.com/go-gitea/gitea/blob/1bb78a013d55767d80d732bbd9ea752b8f1d2416/modules/highlight/highlight.go#L85
and then you can try different themes here (where it says styles.GitHub now).
https://github.com/go-gitea/gitea/blob/1bb78a013d55767d80d732bbd9ea752b8f1d2416/modules/highlight/highlight.go#L116
Heres a list
https://github.com/alecthomas/chroma/tree/master/styles
I'll commit the changes above as well

Will check the themes later. I'm thinking we could probably use these colors, at least as the baseline:
Light: https://github.com/alecthomas/chroma/blob/master/styles/github.go
Dark: https://github.com/alecthomas/chroma/blob/master/styles/solarized-dark.go

I used the Github one as a baseline for light but I think it is either too old or was just bad because it looks nothing like Github does (as you can tell I still tried my best to just copy what Github does in all of the light sections).
I'll add file size limit to rendering later too -- I thought we already had a limit for this but it is just the general UI display limit which is 8MB so that isn't helpful here.

GitHub at one time used pygments so I assume that theme is based on it. They're now the Prettylights highlighter (closed source), but I found this which may be of use:
https://github.com/primer/github-syntax-theme-generator

Noticed we don't need the worker-loader either now, so you can npm uninstall worker-loader, then remove these lines:
https://github.com/go-gitea/gitea/blob/b918609acc11d2deb1dd2182597c7cbb3624dbdb/webpack.config.js#L116-L129
And finally remove the first entry here:
https://github.com/go-gitea/gitea/blob/master/.eslintrc#L31

@silverwind limited size to 25kb and made those js changes thanks

@silverwind made a few tweaks to light theme based on the link you gave above -- think it is pretty good for now. Pygments doesn't have quite the level of detail that pretty lights does in some areas but is pretty close.
Also raised the threshold for highlighting to 1MB based on https://help.github.com/en/github/creating-cloning-and-archiving-repositories/limits-for-viewing-content-and-diffs-in-a-repository

Will likely need to undo to worker-loader removal (part of https://github.com/go-gitea/gitea/pull/12047/commits/901ce59785e65bd21c83d189cb3d111d7e3254d2) because https://github.com/go-gitea/gitea/pull/12095 will depend on it.

Will likely need to undo to worker-loader removal (part of 901ce59) because #12095 will depend on it.

Do I need to do any special commands to properly add it back to npm, or just add the line back to package.json and run make frontend?

Run npm install worker-loader and add back the two removed sections in webpack.config.js and .eslintrc. npm install will take care of package-lock.json.

Syntax looks good on light and dark. I have not encountered some of the more exotic identifiers in the files I was looking at but we should be good with those brighter color on arc-green.

:rocket:

Thanks all : )


[wip] eliminate no-longer-necessary metaconfig version split

fixes #737

test run queued: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/3055/ (404 for now)

well this is weird, several projects are failing with java.lang.NoClassDefFoundError: scala/reflect/api/TypeCreator, with the top of the stack trace looking like
[sbt-util] [error] com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: scala/reflect/api/TypeCreator
[sbt-util] [error] 	at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2212)
[sbt-util] [error] 	at com.google.common.cache.LocalCache.get(LocalCache.java:4053)
[sbt-util] [error] 	at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4057)
[sbt-util] [error] 	at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4986)
[sbt-util] [error] 	at com.lucidchart.sbt.scalafmt.ScalafmtCorePlugin$$anon$1.$anonfun$load$3(ScalafmtCorePlugin.scala:239)
[sbt-util] [error] 	at com.lucidchart.sbt.scalafmt.ScalafmtCorePlugin$autoImport$.$anonfun$scalafmtCoreSettings$26(ScalafmtCorePlugin.scala:154)
[sbt-util] [error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:44)
[sbt-util] [error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:39)

I guess no longer having scalafmt segregated in its own subspace is causing the freshly built scalafmt to be used at the build level. we don't want to be running scalafmt in the community build (except when running its own test suite), so I should probably just disable it in the failing projects.

thanks @olafurpg, this will ease community build maintenance going forward


Atom installation become corrupted after a while and doesn't start.

Atom on Windows 10 x64 seems very unstable It's the third time that I'm forced to reinstall everything because something goes wrong and corrupt installation causing problems in Atom load that remains with a background process with very high CPU usage without opening.
Honestly I don't use Atom standalone but with many plugins since the base features are too limited, however after this strange corruption, sometimes is enough to run Atom in safe mode, and after closing and launch normally with all plugin loaded run correctly, other times no cache clean or safe mode start seems able to allow the correct Atom execution and the only way is completely remove Atom and install again (this usually happens when a new update is released, so in this case seems something related to update process).

Thanks for reaching out!  This sounds like a tough one to debug but It would be helpful if you can fill out the issue template so it makes it easier for people see all the baseline information.  I'll go ahead and close this one but please create a new issue and fill out the template and we can go from there.

We require the template to be filled out on all new issues and pull requests so if you can open a new issue with the template filled out, that would be helpful for us. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:

I have experienced this same issue for much of 2017 and at this point I have no choice but to ditch this software. Free to download but costs a fortune!


HAL support for multiple link objects per relationship?

I am trying to capture multiple item link objects in a HAL representation. Something like:
{
  "person": {
    "name": "Oaty",
    "_links": {
      "item": [
        {
          "type": "address",
          "href": "/people/1/address/1"
        },
        {
          "type": "address",
          "href": "/people/1/address/2"
        }
      ]
    }
  }
}

The HAL adapter seems to need an :href key on the link hash (e.g. opts[:href]) to set the link object for the relationship (lib/oat/adapters/hal.rb:6).
Is there another way to set an array of link objects for a single relationship? HAL supports this (spec reference).

Hi.
Thanks for this. The current HAL implementation needs to be brought up to date with the current spec in order to cover this. Happy to accept pull requests for this specific feature.


Investigate attack failure on lab environment

Known prefix/candidate fails during lab tests
Confidence is building up slowly

Depends on #163
Sometimes scapy misses packets that are observed on the network with wireshark, so perhaps consider changing the sniffer module to something more precise.

Sometimes scapy misses packets that are observed on the network with wireshark. In a notable case, it lost the first packet of the flow.
Perhaps consider changing the sniffer module to something more precise.
Refer to: http://stackoverflow.com/questions/16279661/scapy-fails-to-sniff-packets-when-using-multiple-threads


Implement the CfnStack resource

The following functionalities are implemented:
Actions

destroy: deletes the stack

Resources

Locate a stack from its arn

destroy cfn_stack '<stack arn>'

Locate stacks by their stack name or id using RegExps

destroy cfn_stacks stack_name: /stack_nam.*/
destroy cfn_stacks stack_id: %r{^arn:aws:cloudformation:.*:.*:stack/test-stack}

This is probably a good time to start filling out the usage section of the README.


Update vm image for track1 pipeline job

Add VM image

/azp run js - dataplane - pr

@ramya-rao-a This will resolve pipeline errors found in new pipeline for track1 dataplane packages. I will create release pipeline once changes are merged.

@azure/graph 5.0.3 was released from feature/v4 unintentionally. Updating the version here to 5.0.3 on main as well so new data plane pipeline for track1 package will not attempt to release 5.0.2 due to version conflict against version on npm.


Monthly ESMValTool meeting July

The next monthly ESMValTool meeting will be in July. The result of the poll is that it will be on
Thursday, July 1 at 14:00 CEST (13:00 BST).
The duration will be one hour. Join the zoom meeting.
Calendar invitations to the meeting are sent to the mailing list, join it here.
@ESMValGroup/esmvaltool-developmentteam
Format and agenda

Anyone with an interest in ESMValTool is welcome to join and ask questions
We start the meeting by doing a round where everyone gets one minute to introduce themselves and tell what they will be working on in the next month or what they would like help with.
Using the input from the introduction round, we can decide to talk about specific topics with the entire group or make smaller breakout groups to continue the discussion there.
If you already know that you would like to bring up a particular topic in the meeting, you can mention the GitHub issue on the topic in a comment in this issue. That will make it easy to find for other people in the meeting and we can already start discussing there before the meeting. Just create a new GitHub issue about your topic if there is no open issue yet.
GitHub issues are our preferred way to communicate outside the meeting and keep track of work, so any feature requests/action items/etc discussed in the meeting should ideally result in a GitHub issue.

Notes from the June meeting can be found here: https://github.com/ESMValGroup/ESMValTool/issues/2173#issuecomment-855940263

It would be good to have a discussion about cases like #1812:

If merged now, #1812 the old cmorizer script (i.e. WOA13) would be erased and replaced by the latest one (WOA18) which differs from the previous one. Do we rather want to keep one cmorizer script per dataset version? Or do we only want to have a cmorizer for the latest version of the obs data?
Also the recipe recipe_ocean_bgc.yml relies on WOA13. Unless this recipe is modified to use the latest dataset version, merging #1812 means that we don't have the cmorizer for the obs data of that recipe.
See also this comment on the topic.

I think it might be best to keep all versions of the CMORizers, because

even if we update the recipes in the ESMValTool repository, we're not sure if someone is keeping more recipes somewhere else
this would be useful for reproducing or comparing results with different versions of the same dataset

Only when the data for an older version is no longer available anywhere it makes sense to delete the cmorizer script.

I think it might be best to keep all versions of the CMORizers, because
* even if we update the recipes in the ESMValTool repository, we're not sure if someone is keeping more recipes somewhere else

* this would be useful for reproducing or comparing results with different versions of the same dataset

Only when the data for an older version is no longer available anywhere it makes sense to delete the cmorizer script.

Fully agreed. Another question is whether we keep one config file and one script per dataset version or if we try to have everything in one config file and one script. See this comment for another cmorizer update.

I'd like to bring forth two topics of discussion:

retiring support for Python 3.6 in ESMValCore https://github.com/ESMValGroup/ESMValCore/pull/1200
temporary revert to v2.2.0 multimodel model while the new multimodel module goes through shakedown https://github.com/ESMValGroup/ESMValCore/issues/1201

I'd like to give an update from the recently held User Engagement Team meeting.

Thank you for attending everyone! Here is a summary of the topics we discussed in the meeting:
User engagement update by @rswamina

2 new members @ehogan and @SarahAlidoost
the team will make introductory talks to ESMValTool available on www.esmvaltool.org, please share any ESMValTool related talks with @ESMValGroup/userengagementteam
Slides are available for re-use if you would like to introduce ESMValTool to a new audience, get in touch with the @ESMValGroup/userengagementteam to request access
There are plans to improve tutorial over the coming months, based on user feedback
2 new projects are using ESMValTool: LaunchPad (climate diagnostics for Africa) and Acclimate (climate diagnostics for Brazil)
The next user engagement team meeting will be held in September

Different versions of CMORizer scripts

we discussed the topic and agreed to keep at least older versions of CMORizer scripts. We need to write some contribution guidelines explaining that old versions should not be replaced, but a new version should be added. It is important that reviewers check this. @remi-kazeroni Would you be willing to write the guidance?

Multimodel statistics

The multimodel statistics preprocessor uses iris instead of numpy since https://github.com/ESMValGroup/ESMValCore/pull/1150 was merged and this is included in ESMValCore v2.3.
Because of the more strict handling of metadata by iris, some recipes do no longer run with ESMValCore v2.3. In some cases, the more strict checks on metadata may indicate a true scientific problem, while in other cases this may be too pedantic.
Because we aim to release ESMValTool with all recipes working, a patch release of ESMValCore v2.3 seems likely.
Several options have been proposed to solve the issue of recipes not working that should actually work in ESMValCore v2.3.1:

Keeping the new implementation and addressing the any problems with preprocessor functions that come before multimodel statistics
Keeping both multimodel statistics preprocessor
Reverting back to the old multimodel statistics preprocessor

@zklaus Will make an overview discussion, linking to individual issues that describe cases where recipes fail. If you have an opinion on this topic or a problem to report, please go to this discussion.
Several people reported that they found it difficult that they only found out about changes in the ESMValCore when a release is made and then have very little time to adjust. Maybe it would help to publish a release candidate on conda, to avoid having to do a patch release immediately after ESMValCore is released. For previous releases of ESMValCore we asked the @ESMValGroup/esmvaltool-developmentteam to test the ESMValCore after the feature freeze, but in this case that did not happen. Some streamlining and better documentation of the release process might be needed.

Python 3.6 support

Python 3.6 is end of life in September, so ESMValCore v2.3 will be the last release that supports it.

Here I am tagged as a new member :bowtie: but "Tamzin Palmer" is one of the new members of the user engagement team.

Sorry, I must have been sleeping when I was taking the notes :zzz: :zzz: :zzz:

The discussion about multi-model issues is now available at #2218, though a few issues are still missing.


ci: leverage caching in azure devops pipelines

@stevengum can definitely look over it again. If anything, I need to remove a comment regarding the MyGet token that was left in, since we're no longer using that in the E2E Streaming tests pipeline 😞

Also--maybe we need a conversation offline, but there's also the question of whether or not we want to change the streaming E2E test build to encompass running the changes in the PR directly or leave it as is.
Currently:
DL that gets installed uses bf-streaming@next version
Consider:
DL using bf-streaming that's in the PR
The benefit of the current strategy that's implemented is that it "matches" the version that's used for other SDK packages--as in botbuilder@next, which is used in the bot. I know sometimes we get weird behavior when we mix and match SDK versions...
However, I think the current trigger for the E2E streaming tests is to run nightly as well as to run if there are any changes in bf-streaming (if I recall what Steven said corrently)--then if that's the case, maybe it'd make sense to actually pack and use the bf-streaming folder that's in the PR.

The cache key is actually pretty tricky to compute deterministically so I'm going to hold off on this while I work on some monorepo updates.


Replaced duplicate definitions of the method testRuntime in UntertowSubsystemTestCase classes

WFLY-6296:
Created a new class UndertowSubsystemTest that contains the definition of the method testRuntime.
Removed the duplicate definitions of this method in the classes:
UndertowSubsystem10TestCase, UndertowSubsystem11TestCase, UndertowSubsystem12TestCase,
UndertowSubsystem20TestCase, UndertowSubsystem30TestCase and UndertowSubsystemTestCase.
These classes now extend UndertowSubsystemTest
Location within the repository:
wildfly\undertow\src\test\java\org\wildfly\extension\undertow

Can one of the admins verify this patch?

Linux with security manager Build 4314 outcome was FAILURE using a merge of 087c1f626710d9935b165a2387163a0c675c2b6d
Summary: Tests passed: 589, ignored: 80; compilation error: Compiler (new) Build time: 00:03:31

Linux Build 9507 outcome was FAILURE using a merge of 087c1f626710d9935b165a2387163a0c675c2b6d
Summary: Tests passed: 589, ignored: 80; compilation error: Compiler (new) Build time: 00:04:09

Windows Build 4529 outcome was FAILURE using a merge of 087c1f626710d9935b165a2387163a0c675c2b6d
Summary: Tests passed: 589, ignored: 80; compilation error: Compiler (new) Build time: 00:06:14


Replace all instances of "Account Manager" with "Wallet"

Since we are rebranding the "Account Manager" to "Wallet" we can replace all instances on the website. For example:

Hi, I will be working on this if it is alright. Thanks :)

Requesting the bounty to be increased since it's a lot of work for 250 TNBC.

PAID


[FEATURE]: Support AWS Data API v2

Describe what you want
The AWS Data API was redesigned for Aurora Serverless v2 and for provisioned Aurora, with no rate limit: https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-aurora-postgresql-rds-data-api/
Will Drizzle support it as a driver?

we already have a data api https://orm.drizzle.team/docs/get-started-postgresql#aws-data-api, but we did not check it with v2 yet

https://github.com/drizzle-team/drizzle-orm/releases/tag/0.29.2
I assume this is good to go per release notes here

Related issue: https://github.com/drizzle-team/drizzle-orm/pull/1172/files

Aurora Serverless v2 is compatible with the previous version, and after a few tests, it worked the same with drizzle.
https://github.com/drizzle-team/drizzle-orm/pull/1172/files -> this PR will be reviewed and merged, but it's not related to this feature request, so we are closing this one

https://github.com/drizzle-team/drizzle-orm/issues/1823 plugging this issue here

https://github.com/drizzle-team/drizzle-orm/pull/1911 also this one!


Prevent accidental user selection of any text on the website

Accidently selecting any text playing the game annoyed me and some friends quiet some times. Merging this pull request will prevent accidental selection of any text on the website.

aimedThanks, great idea! I will merge it sometime this weekend.


Do not poll non-pipeline builds

Fixes fabric8io/openshift-jenkins-sync-plugin#95

LGTM

LGTM

Released in 0.0.11 - available from https://repo.jenkins-ci.org/releases/io/fabric8/jenkins/plugins/openshift-sync/0.0.11/


Support for Java Spring boot/security

I was wondering: does identity server also integrate with e.g. java spring boot applications?
Including the webhooks/redirects for login, password reset, registration, ...?
Or is this solution only compatible with .net (core) applications?
I'm looking for an alternative to Keycloak and was wondering if identityserver could cover my needs :)

IdentityServer is an OpenID Connect/OAuth framework. You can integrate anything that is compatible with these protocols.

That said - anything that is outside of these protocols (like login UI or user management) is not part of IdentityServer - so you have to implement it yourself and thus can make it compatible with whatever you want.

Thanks for the reply @leastprivilege
When reading this: https://identityserver4.readthedocs.io/en/latest/quickstarts/3_interactive_login.html => am I wrong in assuming that, if I e.g. create a separate .net core project with identity server, drop in these UI-components and run it in a separate docker container, that I could get identity server to offer these user management/login GUI components?
So basically redirecting back and forward during the authentication flow between my own app and identitserver?

Yes of course.


Remove illegal Items

An option to remove illegal items they have or maybe when they go to jail they lose their illegal items.

What do you understand under "illegal" items?

It is items like drugs.
I don't know if we'll implement this on the cops's core, maybe an addon (as the feature depend on the invetory system used by the server)


Native dependencies are missed

Native dependency detection appears to be breaking in v2.0.2.
electron-rebuild no longer correctly identifies all the native dependencies needed to be rebuilt.
Reverting back to v2.0.1 fixes the issue.
I will do some more digging into the problem, but the issue is probably related to the changes in 9d166a83bd557084993832c8270f16c688f6ee45

It would be great if you could provide a minimal testcase for this that we could add to the testsuite, to avoid any regressions in the future.

I have the same issue when rebuilding native module 'serialport'.
Look at this:
https://stackoverflow.com/questions/63794519/serialport-for-electron-node-module-version-error-and-rebuild-does-not-fix#

Can confirm @malept 2.0.2 is not working correctly.  Had to downgrade to 2.0.1

Proposed fix in https://github.com/electron/electron-rebuild/pull/409, please test.
For those using yarn, use dependency resolutions to point to the branch name.

I can confirm that #409 fixes our build. 🎉

For some reason I can't confirm the fix. Here is a reproducible build with the latest version to compile nodegit:
https://github.com/Githubber2021/node_module_version-issue
git clone https://github.com/Githubber2021/node_module_version-issue
cd node_module_version-issue
npm i
npm run rebuild
...Error

Not sure what you're trying to show in your repro instructions, that makes sense since you're trying to use s native module compiled for Electron 10 with AVA running with whatever Node.js version, which will never have the same  ABI version number.

Thanks! Just a few minutes ago I noticed that Electron has a different ABI version than node.js and I don't understand why. If Electron uses nodejs 14.15.0 it has a different ABI version than the actual nodejs 14.15.0. Is that correct? I just opened a question for this on SO. Sorry if this doesn't fit here, but I have to give it a shot since it's really difficult to grasp https://stackoverflow.com/questions/64815484/why-is-there-a-mismatch-of-module-versions-between-electron-and-node-js

My understanding is that Electron uses BoringSSL instead of OpenSSL, which changes the ABI surface.


Fails to comment when editor is 'emacsclient -nw'

When I try to use the 'c' command to post a comment, I get the message 'Could not open file with emacsclient -nw'. This works elsewhere (such as mutt) normally.

Thanks, this is probably failing because the python subprocess call doesn't allow flags in the first argument.
https://github.com/michael-lazar/rtv/blob/master/rtv/terminal.py#L555
p = subprocess.Popen([editor, filepath])

It should be pretty easy to fix using something like shlex.split.

I was able to replicate your error and I just pushed a fix to the master branch. Hopefully this should resolve your issue!


Where do you set the tps probability?

Hi,
Great work with the repo. I was wondering where you set the TPS probability, in most of the config files it is set to 0.

Thank you for your interest in this work!
You can refer to this script file, which contains the configuration for the results in table 1, but without TPS.
To add TPS, you can include ++train.tps_prob in the command. The TPS is set to 0.5.
For example, the SliceParam model with TPS:
python main.py -m -cp configs/morphem70k -cn morphem70k_cfg model=sliceparam tag=slice ++optimizer.params.lr=0.0001 ++model.learnable_temp=True ++model.temperature=0.15 ++model.first_layer=pretrained_pad_dups ++model.slice_class_emb=True ++train.tps_prob=0.5


I'm looking forward to updating version 1.1.0

I'm looking forward to updating version 1.1.0

Take a look at dev branch. :)
We did a lot of new features.

So many of them that in fact it will take some time to document them all :)


Bugfix: Pass size to np.random.uniform so it does not return a single value

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, thank you very much for spotting and fixing this bug. I replaced x.size with x.shape to make this also work for n-dimensional arrays. I'll merge this and we will make a new release in the next days, containing this bugfix.
Thanks for contributing to ibicus!


0.8.0 rc1 branch

Please see the relevant pre-release (currently in draft):  https://github.com/open-quantum-safe/oqs-provider/releases/tag/untagged-e8b2d0985929c684a8d5
This PR makes the following changes:

Bumps the version string,
stores a copy of generate.yml as generate.yml-0.12.0,
Updates SECURITY.md,
Updates RELEASE.md,
Points CI to liboqs 0.12.0, and
Points CI to OpenSSL 3.4.0.

Checks done:

Stable under generate.py and do_code_format.sh,
CI is green,
'LIBOQS_BRANCH=0.12.0 OPENSSL_BRANCH=openssl-3.4.0 ./scripts/fullbuild.sh -F && ./scripts/runtests.sh -V` runs OK,
release-tests.sh with liboqs 0.12.0 and openssl 3.4.0 runs OK,
nginx, curl, and httpd docker images build OK, and
OpenSSL external test integration passes when run locally with gh act --job external-tests-providers. (Logs attached: logs.txt. Note that the external-tests-providers jobs fails because the tests for pkcs11-provider fail but oqs-provider passes.).

This PR will not land; once approved, a new 0.8.0-release PR will be made.

Thank you for the suggestions @baentsch! I've included the changes here and on the draft pre-release: https://github.com/open-quantum-safe/oqs-provider/releases/tag/untagged-0fb2ad16a1ba976ea75a

@baentsch @SWilson4 @ghen2 @fwh-dc Thank you for you suggestions, I've updated README.md to include them and updated the draft pre-release as well: https://github.com/open-quantum-safe/oqs-provider/releases/tag/untagged-d43fdf73a30644bc1820

Following guidance in https://github.com/open-quantum-safe/oqs-provider/wiki/Release-process this removed "rc1" tags and waits for approval to land. Final release will be cut on the landed (squashed) commit.

Following guidance in https://github.com/open-quantum-safe/oqs-provider/wiki/Release-process this removed "rc1" tags and waits for approval to land. Final release will be cut on the landed (squashed) commit.

Thank you for finishing up the final release steps @baentsch! The pre-release is still in draft, is that intentional? Please let me know if that is becuase the GitHub web UI won't let you publish it and I shall do the same.
I'm linking a discussion related to the 0.7.0 release to see if we'd like to wait for a little bit before proceeding with the final release after appropriate approvals since I have not been able to automate the release process yet: https://github.com/open-quantum-safe/oqs-provider/pull/534#discussion_r1796918305

Thanks for the reminder to move rc1 out of Draft, @praveksharma . Just done. And sure, 0.8.0 will sit un-merged for a day before I squash, commit, and release (as agreed in the call yesterday) - just in case :)

Looking at https://github.com/open-quantum-safe/boringssl/pull/130 I wonder whether we should also at least announce removal of Dilithium with the next release (along the lines of Kyber)?
fwiw, I very much like the approach taken by @pi-314159 for oqs-boringssl: Just yank the stuff that's outdated... Or maybe it's just envy :-) @open-quantum-safe/oqs-committers do you know of anyone still relying on Kyber and Dilithium still being supported? May it be an idea to mark them "disabled" already now in the generate.yml? This would functionally align oqsprovider and oqsboringssl and still allow anyone to enable those algs again if they absolutely must.

I've updated openquantumsafe.org with info about the release.


properties typings tools

There is a difference between three forms of types of a component's props:

the JSX signature
the external javascript signature (like JSX but may need to address 'data-' and 'aria-' differently)
the internal javascript signature (like the external but with less optional fields because it's post injection and defaults)

In addition there is a "right way" to define a generic component's properties, inheriting from React.HTMLProps for example (see here)
need to collect use cases of component patterns around this issue, and provide a helpful tool to define these types.

@giladgrush @tobich I'd appreciate some input on the subject when possible

needs further discussion before it is ready for processing


Installation too fast

When I tried installation on shared hosting, table generation stopped in the middle (something like "podium_config not found"). Inserting a sleep() statement helped.

This is unusual. Queries are processed one after another so installation waits until previous query finishes before starting new one.
Could you give me more information about this? Maybe how to reproduce it? Error log and so on.

Podium 0.6 on Yii 2.0.10, installed by composer, One.com Starter hosting, podium/install/run.
2017-02-04 22:50:08 [<my_ip>][-][-][error][bizley\podium\PodiumConfig::getStored] [     'msg' => 'SQLSTATE[42S02]: Base table or view not found: 1146 Table \'<mydomain>.podium_config\' doesn\'t exist The SQL being executed was: SELECT * FROM podium_config',     'model' => null, ]     in /customers/5/4/5/<mydomain>/httpd.www/AppYii206/Yii2/vendor/bizley/podium/src/log/Log.php:54     in /customers/5/4/5/<mydomain>/httpd.www/AppYii206/Yii2/vendor/bizley/podium/src/PodiumConfig.php:166     in /customers/5/4/5/<mydomain>/httpd.www/AppYii206/Yii2/vendor/bizley/podium/src/PodiumConfig.php:146
With this addition installation succeeded (I didn't try 1 second)
        sleep(2);

        $this->table = $this->steps[$currentStep]['table'];
        $result = call_user_func_array([$this, $this->steps[$currentStep]['call']], $this->steps[$currentStep]['data']);

This error should not stop installation (at least I think so). I will modify the code to not trigger this into logs during installation because people think something is wrong.
Let me make some additional tests and get back to you in few hours.

I checked what was in the db after the installation stopped. Last table generated was podium_config.

I can not reproduce it. Please try again with new 0.7 installation and let me know if there are any errors (log, on screen etc.).

Feel free to open this issue in case this happen again.


adding expo docs for jsmono

🚀 Deployed on https://65ff6c7f89da71674a192d43--cozy-fox-0defec.netlify.app


Update PostHog events in monitor bundle

@shahafa Could you re-open the PR to the tracking branch?
If not, just let me know and I'll do it.

@shahafa Please close this PR, opened a new one.


Region missing for SQS so failing to upload messages

Describe the bug
Line 1231 of stream-producer.py instantiates the SQS connection
self.sqs = boto3.client("sqs")
But this is missing region_name, for example:
self.sqs = boto3.client("sqs", region_name="eu-west-2")
To Reproduce

Start Docker container and set all environment variables
Connect to running container and run python3 /app/stream-producer.py csv-to-sqs

Expected behavior
Should connect to SQS and upload messages into queue based upon rows in a CSV file
Headless server:

OS: Linux AMI (but using Docker 19.03.4, build 9013bf583a)

Additional context
Suggest extracting the region from environment variable SENZING_SQS_QUEUE_URL or adding another environment variable so the user specifies the region

Thank you for pointing this out.  I will correct early in the week.

@davdasil The boto3 library respects values placed in Environment variables and ~/.aws.config  See https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html
AWS_DEFAULT_REGION can be set and used.
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html#using-environment-variables
Rather than "re-inventing the wheel" by adding more code,  I'd like to improve the documentation for this repository to highlight the existing methods of configuring boto3.
Would that satisfy the issue you raised?

@davdasil I added information in:

https://github.com/Senzing/stream-producer#examples-of-docker
https://github.com/Senzing/stream-producer#aws-configuration

If you think that is sufficient, go ahead and close the issue.  If there's something more that you'd like please let me know.

Many thanks @docktermj .  Very elegant solution

@davdasil  Thank you again for raising the issue.


'NoneType' object is not callable - when performing query on trino database

When performing the update to version 1.4.0 from version 1.3.0, the queries stop working with 'NoneType' object is not callable error.
This also happens with version 2.0 and 1.5.0.
How to reproduce the bug

Go to 'https://superset.cilabs.com/superset/sqllab' (query lab)
Fill the dataset with a standard query
Click "RUN"
See error

Expected results
Query results should appear as normal query.
Actual results
UI shows:
Trino Error
'NoneType' object is not callable

This may be triggered by:
Issue 1002 - The database returned an unexpected error.

See less

Logs show:
2022-07-19 14:05:50,063:WARNING:superset.views.base:[SupersetError(message="'NoneType' object is not callable", error_type=<SupersetErrorType.GENERIC_DB_ENGINE_ERROR: 'GENERIC_DB_ENGINE_ERROR'>, level=<ErrorLevel.ERROR: 'error'>, extra={'engine_name': 'Trino', 'issue_codes': [{'code': 1002, 'message': 'Issue 1002 - The database returned an unexpected error.'}]})]
Traceback (most recent call last):
  File "/app/superset/views/base.py", line 203, in wraps
    return f(self, *args, **kwargs)
  File "/app/superset/utils/log.py", line 242, in wrapper
    value = f(*args, **kwargs)
  File "/app/superset/views/core.py", line 2462, in sql_json
    command_result: CommandResult = command.run()
  File "/app/superset/sqllab/command.py", line 104, in run
    raise ex
  File "/app/superset/sqllab/command.py", line 96, in run
    status = self._run_sql_json_exec_from_scratch()
  File "/app/superset/sqllab/command.py", line 138, in _run_sql_json_exec_from_scratch
    raise ex
  File "/app/superset/sqllab/command.py", line 133, in _run_sql_json_exec_from_scratch
    return self._sql_json_executor.execute(
  File "/app/superset/sqllab/sql_json_executer.py", line 111, in execute
    raise SupersetErrorsException(
superset.exceptions.SupersetErrorsException: [SupersetError(message="'NoneType' object is not callable", error_type=<SupersetErrorType.GENERIC_DB_ENGINE_ERROR: 'GENERIC_DB_ENGINE_ERROR'>, level=<ErrorLevel.ERROR: 'error'>, extra={'engine_name': 'Trino', 'issue_codes': [{'code': 1002, 'message': 'Issue 1002 - The database returned an unexpected error.'}]})]

Environment
(please complete the following information):

superset version: superset version

superset --version
Loaded your LOCAL configuration at [/app/pythonpath/superset_config.py]
Loaded your LOCAL configuration at [/app/pythonpath/superset_config.py]
Python 3.8.12
Flask 1.1.4
Werkzeug 1.0.1

python version: python --version: Python 3.8.12

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

@fabioaraujopt we are also facing this issue in our version of 1.5.1 superset, we're upgrading to 2.0 soon and will report back with if we are still facing it.  Have you discovered any sort of root cause to the bug?

Hello, I had this issue in 1.5.1, it might be correlated to your issue. However it should work in 1.5.0
https://github.com/apache/superset/issues/20428

Updating to 2.0 and updating our config parameters to the one specified in this file fixed the issue for us - https://github.com/apache/superset/blob/master/superset/config.py @Thelin90 @fabioaraujopt

Closing this since it sounds like it was fixed in 2.0, and we're on the verge of 4.0 now :) Please open a new/updated issue if warranted. Thanks!


Can we get single file with all contents

I am writing chrome extension, so i'm trying to keep footprint as small as possible. Currently need to include multiple js files, can we get a single umd to include instead of the multiple for this directive?

hi @golear91
the bundle includes all files - https://github.com/orizens/angular2-infinite-scroll/blob/master/bundles/angular2-infinite-scroll.js.
however, if you use typescript for the chrome extension - you can use webpack or browserify to bundle all js files anyways into one file.

When I try to load from that file I get the following error:

I changed systemjs packages config from 'angular2-infinite-scroll': { main: 'angular2-infinite-scroll.js', defaultExtension: 'js' } to 'angular2-infinite-scroll': { main: 'bundles/angular2-infinite-scroll.js', defaultExtension: 'js' }
and it goes from working correctly to that error above.

hi.
I'm not sure of how to use the bundle.

hi @golear91
this has been resolved, isn't it?

a umd version is available via npm package.


Unable to validate information for artifact

Inventory Kamera works for weapons & characters but when says Unable to validate information for artifact when it scans artifacts

Hi there, this issue is hopefully resolved in the v1.1.1 prerelease. If it has been, please let us know so we can close this issue.


Feature resource javax validation annotations

It looks like the value in message() get stored reflectively in the buildAnnotationParameterMap(Annotation annotation) of the ConstraintDescriptorImpl. Then if you haven't called disableDefaultConstraintViolation() on the ConstraintValidatorContext, when the violation message gets build in the ConstraintValidatorContextImpl, it uses the stored message() value.


404.md doesn't give a 404

If I open a page that doesn't exist, the 404 page is opened. But the server does not give a 404 response but a 200. Is this a problem in my installation?

Are you using @rewdy's Pagination plugin by any chance? In this case, see my comment here https://github.com/picocms/Pico/issues/551#issuecomment-652521872

Are you using @rewdy's Pagination plugin by any chance? In this case, see my comment here #551 (comment)

Actually, I do. The problem disappeared with your version. Thank you very much! I think that your fork should be listed on the plugin page instead of the original.

I still think the plugin page should be changed

A pull request is welcome :+1:

No need to change anything as the MR is now merged. This issue should be closed.


New version: Cloudflare.cloudflared version 2024.10.1

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-10-24 03:58:33.408 [FAIL] Installer failed security check. Url: https://github.com/cloudflare/cloudflared/releases/download/2024.10.1/cloudflared-windows-amd64.msi Result: 0x80004005
2024-10-24 03:48:24.616 [FAIL] Installer failed security check. Url: https://github.com/cloudflare/cloudflared/releases/download/2024.10.1/cloudflared-windows-386.msi Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 897.)

@wingetbot run