Revert "sched/spinlock: remove nesting spinlock support"

Summary
This reverts commit 5aa13bc490ea2e5a0d7462dd0131f9218a35f56a, Related to https://github.com/apache/nuttx/issues/14167
I found that this submission would cause ci warning, So should we revert it first?
machine/arch_atomic.c: In function ‘__atomic_load_2’:
machine/arch_atomic.c:51:22: warning: infinite recursion detected [-Winfinite-recursion]
   51 |   type weak_function __atomic_load_##n (FAR const volatile void *ptr, \
      |                      ^~~~~~~~~~~~~~
machine/arch_atomic.c:354:1: note: in expansion of macro ‘LOAD’
  354 | LOAD(2, uint16_t)
      | ^~~~
In file included from /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/atomic.h:84,
                 from /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/fs/fs.h:40,
                 from /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/sched.h:47,
                 from /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/arch.h:89,
                 from /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:38,
                 from machine/arch_atomic.c:31:
In function ‘spin_lock_wo_note’,
    inlined from ‘spin_lock_irqsave_wo_note’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:531:7,
    inlined from ‘spin_lock_irqsave’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:586:11,
    inlined from ‘__atomic_load_2’ at machine/arch_atomic.c:354:1:
/home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:244:10: note: recursive call
  244 |   while (atomic_load((FAR atomic_ushort *)&lock->tickets.owner) != ticket)
      |          ^~~~~~~~~~~
In function ‘spin_lock_wo_note’,
    inlined from ‘spin_lock_irqsave_wo_note’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:535:7,
    inlined from ‘spin_lock_irqsave’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:586:11,
    inlined from ‘__atomic_load_2’ at machine/arch_atomic.c:354:1:
/home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:244:10: note: recursive call
  244 |   while (atomic_load((FAR atomic_ushort *)&lock->tickets.owner) != ticket)
      |          ^~~~~~~~~~~
machine/arch_atomic.c: In function ‘__atomic_fetch_add_2’:
machine/arch_atomic.c:120:22: warning: infinite recursion detected [-Winfinite-recursion]
  120 |   type weak_function __atomic_fetch_add_##n (FAR volatile void *ptr,   \
      |                      ^~~~~~~~~~~~~~~~~~~
machine/arch_atomic.c:450:1: note: in expansion of macro ‘FETCH_ADD’
  450 | FETCH_ADD(2, uint16_t)
      | ^~~~~~~~~
In function ‘spin_lock_wo_note’,
    inlined from ‘spin_lock_irqsave_wo_note’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:531:7,
    inlined from ‘spin_lock_irqsave’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:586:11,
    inlined from ‘__atomic_fetch_add_2’ at machine/arch_atomic.c:450:1:
/home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:243:5: note: recursive call
  243 |     atomic_fetch_add((FAR atomic_ushort *)&lock->tickets.next, 1);
      |     ^~~~~~~~~~~~~~~~
In function ‘spin_lock_wo_note’,
    inlined from ‘spin_lock_irqsave_wo_note’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:535:7,
    inlined from ‘spin_lock_irqsave’ at /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:586:11,
    inlined from ‘__atomic_fetch_add_2’ at machine/arch_atomic.c:450:1:
/home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/spinlock.h:243:5: note: recursive call
  243 |     atomic_fetch_add((FAR atomic_ushort *)&lock->tickets.next, 1);
      |     ^~~~~~~~~~~~~~~~

Impact
None,it just fix CI warning
Testing
Build Host(s): Linux x86
Target(s): sim/smp
After that, there will be no warnings for compilation
╭─crafcat7@hp-prodesk-680-g4-mt ~/SSD/vela/nuttx.git/nuttx ‹master›
╰─$ ./tools/configure.sh -l sim:smp                                                                                130 ↵
  Copy files
  Select CONFIG_HOST_LINUX=y
  Refreshing...
CP: arch/dummy/Kconfig to /home/crafcat7/SSD/vela/nuttx.git/nuttx/arch/dummy/dummy_kconfig
CP: boards/dummy/Kconfig to /home/crafcat7/SSD/vela/nuttx.git/nuttx/boards/dummy/dummy_kconfig
LN: platform/board to /home/crafcat7/SSD/vela/nuttx.git/apps/platform/dummy
LN: include/arch to arch/sim/include
LN: include/arch/board to /home/crafcat7/SSD/vela/nuttx.git/nuttx/boards/sim/sim/sim/include
LN: drivers/platform to /home/crafcat7/SSD/vela/nuttx.git/nuttx/drivers/dummy
LN: include/arch/chip to /home/crafcat7/SSD/vela/nuttx.git/nuttx/arch/sim/include/sim
LN: arch/sim/src/chip to /home/crafcat7/SSD/vela/nuttx.git/nuttx/arch/sim/src/sim
LN: arch/sim/src/board to /home/crafcat7/SSD/vela/nuttx.git/nuttx/boards/sim/sim/sim/src
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/audioutils
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/benchmarks
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/boot
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/canutils
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/crypto
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/database
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/examples/mcuboot
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/examples
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/fsutils
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/games
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/graphics
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/industry
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/inertial
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/interpreters/luamodules
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/interpreters
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/logging
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/lte
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/math
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/mlearning
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/netutils
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/sdr
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/system
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/testing
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/videoutils
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/wireless/bluetooth
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/wireless/ieee802154
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps/wireless
mkkconfig in /home/crafcat7/SSD/vela/nuttx.git/apps
Loaded configuration '.config'
Configuration saved to '.config'
╭─crafcat7@hp-prodesk-680-g4-mt ~/SSD/vela/nuttx.git/nuttx ‹master›
╰─$ make -j
Create version.h
LN: platform/board to /home/crafcat7/SSD/vela/nuttx.git/apps/platform/dummy
Register: hello
Register: nsh
Register: sh
Register: getprime
Register: smp
Register: ostest
Register: taskset
CP:  /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/config.h
CP:  /home/crafcat7/SSD/vela/nuttx.git/nuttx/include/nuttx/fs/hostfs.h
LD:  nuttx

@anchao

I sorted out the reasons for the compilation warning.
If we use NuttX atomic, then there is in the process
spin_lock_irqsave->spin_lock_irqsave_wo_note->spin_lock_wo_note

and the atomic function is also used in spin_lock_wo_note

I sorted out the reasons for the compilation warning. If we use NuttX atomic, then there is in the process
spin_lock_irqsave->spin_lock_irqsave_wo_note->spin_lock_wo_note

and the atomic function is also used in spin_lock_wo_note

@crafcat7 let's fix the warning instead reverting the patch.

I wrote the following comments in
https://github.com/apache/nuttx/pull/14079#issuecomment-2408714889
===
I noticed that spresense:wifi_smp causes a deadlock with this PR.
I think this PR would affect some SMP configurations that use real hardware.
So I suggest we revert this PR until all the issues have been resolved.


check_syntax: Include is syntax checked but surrounding context is unknown

Issue:
./src/nw_shared/#jcs#nw_shared_f95.prog.abap[10, 5]                              - c_msgid not found, findTop (check_syntax) [E]

This abap is a central include. It works together with another include that is part of the function groups TOP. The Function Group is syntax wise correct.
In my opinion an include should not be checked by itself and only in the context of it's usage.

After further analysis, i found out that indeed another function group (that i missed) was missing the extra top-include.
In case of an include, can the original context also be shown in the message?


Bug: fix path helper method name

Currently in Organizations::Staff::PageTextsController in the update action, if @page_text does not update we redirect to edit_page_text_path, this causes an error, it needs to be edit_staff_page_text_path

To reproduce, upload two About Us images, and save. Then try to upload a third image and save. You will get an error.
Expected behaviour, on attempt of uploading a third image you should get an alert message saying only 2 images allowed.

@kasugaijin , can you please assign this one to me?

@Hassaan68 all yours!

@jmilljr24 fixed and tested


Build a Microprofile Rest Client with Mutual TLS Authentication

Article checklist
Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes
This closes #3462

@katungi, I'll be waiting for any pings from you soon!

Hello @justusmbuvi , thanks for this amazing article. I loved it and followed it through to the end. Just a small tip, when asking the reader to edit a file, be sure to help the reader find exactly where the file is. If there are any differences in maybe project structure, be sure to warn the reader. I personally had a hard time finding the application.properties file in the resources folder.

plagiarism check done heavy_check_mark

@katungi, all is good to go

plagiarism check done heavy_check_mark

@katungi, all is good to go

Will be waiting @katungi


0.30.0 release

Will update your perms....

I should say, added the gfx-rs/wgpu team so everyone who can publish can push to main.


[FLINK-35282][python] Upgrade Apache Beam > 2.54

What is the purpose of the change
Based on #24908, upgrade Apache Beam dependency to >2.54.
Brief change log
Changes flink-python code and tests for compatibility with new version, updates licenses and relevant documentation in other components.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@dianfu , @HuangXingBo could you please have a look here, I think you are more experienced with python in Flink

Any update on this? @dianfu @HuangXingBo @snuyanzin ?


Add Markdown column using Illuminate\Mail\Markdown

Add markdown column type (to be used in CRUD show view).
No extra package dependencies as it uses Illuminate\Mail\Markdown

Totally! So simple, so useful. Thank you @ziming , merged!

Also just added it to the docs.

I think the docs may want to say that it is best used only for the show view.


Unresolved placeholder in message text after install of an extension

VSCode Version: 1.4.0
OS Version: OSX 10.11.5 El Capitan

Steps to Reproduce:

Locale German
Manually install a .vsix extension with File / Open
Message "{0} wurde erfolgreich installiert. Führen Sie zur Aktivierung einen Neustart aus." is displayed.

It is expected that {0} is replaced by the extension name.

Looks like the extension name is not fill in / passed.

Already fixed:
https://github.com/Microsoft/vscode/blob/master/i18n/deu/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchExtension.i18n.json#L11


RFC: Improvements to drivers/sensors for light sensors

RFC: Improvements to drivers/sensors for light sensors
Introduction
This RFC details a number of issues and potential improvements to the handling
of 'light' in the current sensor API.
An explanation of radiometric versus photometric units is presented,
as well as some options to make the current system more practical in
real-world applications.
Problem Description
The current solution for 'describing' light-related sensor data is
fundamentally flawed at the unit level (lux for IR, etc.), and has some
unnecessary limitations in terms of what type(s) of light-related
data can be stored or conveyed with the current API.
Proposed Changes

The current value types assigned to existing light channels should be
changed from erroneous photometric types (lux) to an appropriate radiometric
value type.
Support for multiple instances of a channel -- with appropriate minimal
meta-data -- should be added to support classes of sensors that
respond with a range of data samples in a single fetch event.
A wavelength-neutral light channel should be introduced for
less rigidity when working with non RGB or IR light sensors.
A new dedicated 'lux' channel should be added to correctly accommodate
the measurement of human vision as a scientifically important photometric
value.

Detailed RFC
At present, sensor.h has the following photometric value types defined
for light sensors:
/** Illuminance in visible spectrum, in lux. */
SENSOR_CHAN_LIGHT,
/** Illuminance in infra-red spectrum, in lux. */
SENSOR_CHAN_IR,
/** Illuminance in red spectrum, in lux. */
SENSOR_CHAN_RED,
/** Illuminance in green spectrum, in lux. */
SENSOR_CHAN_GREEN,
/** Illuminance in blue spectrum, in lux. */
SENSOR_CHAN_BLUE,

There are a number of problems and limitations with the current approach, which
are detailed below.
Key Technical Concepts
Before detailing the problems with the current sensor API, an explanation of
radiometric versus photometric units may be useful.
Radiometric vs. Photometric Units
Radiometric Units
Electromagentic radiation is characterised by radiometric units, which
describe the physical properties of light (the number of photons, photon
energy, or radiant flux). These units have no relation to human vision.
Infrared radiation, for example, is not visible to the human eye (>780 nm) but
it definitely exists as a radiometric phenomenon and can be accurately
measured, described and analysed for scientifically significant purposes.
Photometric Units
To characterise light relative to the human eye, we need to use
photometric units such as luminous intensity, which represents the
light intensity of a source as perceived by the human eye, measured in
candela (cd).
Since photometric measurements are limited to what the human eye can
perceive, these measurements are restricted to the visible spectrum
of 380 nm to 780 nm wavelengths.
One of the most common photometric units is luminous flux, which is
measured in lumens (lm). It's even more common derivative is illuminance
(used in this RFC and the current API), which is the luminous flux incident per
a specific area. Illuminance is measured in lux (which is equal to
lm/m^2).

It should be noted that all photometric units are based on a theoretical
model of human vision, and thus are not entirely accurate (compared to
radiometric units). Anything dealing with 'lux' or photometric units will
always, by definition, be an approximation, even if it's a reasonably
good one!

Photometric Units and Radiometric Equivalents
The two unit families have the following relationships:

Photometric Unit
Dimension
Radiometric Unit
Dimension

Luminous Flux
lm
Radiant Flux
W

Luminous Intensity
lm/sr=cd
Radiant Intensity
W/sr

Illuminance
lm/m^2=lux
Irradiance
W/m^2

Luminance
cd/m^2
Radiance
W/(sr m^2)

Key Problems
Some of the key limitations of the current approach to capturing light samples
are listed below:

Lux is a photometric unit. Photometric units are used to represent
light as perceived by the human eye. Radiometric units would be
preferable since they are based on an actual physical model, not a
theoretical estimation, and you can easily convert from radiometric to
photometric units. (The radiometric equivalent of illuminance or lux is
irradiance, which is measured in W/m^2.)
Lux, by definition, has no meaning in the IR, RED, GREEN, or BLUE
spectra since it can't be isolated to these narrow wavelengths, but is
a calculation based on a curve representing a model of 'normal' human
vision. Lux should be it's own inferred value type, based on raw
radiometric data capture and the response of the photodiodes used.
IR, Red, Green and Blue are common components of the light spectrum, but
there is currently no way to account for other (visible or non-visible)
wavelengths which are scientifically important, such as UV, or narrow
bandwidths that can be captured by speciality light sensors or photodiodes.
Ideally, it should be possible to return a radiometric sample that indicates
the wavelength(s) of the light sample, and it's relative strength, without
an arbitrary limitation to the IR/R/G/B ranges.

Real World Example: Spectrometer
An easy to understand example of the limitations of the current API is
trying to design a spectrometer.
A spectrometer works by capturing a number of samples at fixed wavelengths or
wavelength ranges, with all of the spectral data in that range making up one
dataset (capture in a single 'fetch' event).
A spectrometer might measure light in the human-visible-range, for example
(380-780nm), and in 10nm intervals, meaning that each 'fetch' operation
consists of 40 samples, each associated with either a fixed wavelength
(ex. 420 nm, 430 nm, etc.) or a range of values (385-395 nm).
At present, there is no obvious mechanism to support either of these
requirements:

Multiple instances of a channel
Appropriate meta-data per channel instance

Proposed Changes/Solutions

Converting between radiometric and photometric units is done via the
luminous efficiency function, of which several versions exist (CIE 1931,
CIE 1988, etc.). Since lux is a commonly used value type, conversion
from irradiance to illuminance should be provided via an appropriate
function, taking radiometric data as an input and lux as an output.
Radiometric units should be preferred, with support added for converting
between the two unit families.
A new SENSOR_CHAN_LUX channel should be added, or the current
ambiguously-named SENSOR_CHAN_LIGHT channel should be renamed to clearly
identify this as a photometric unit (lux) describing an estimation of
human vision related to the capture light sample(s).
Changes should be made to enable multiple instances of a channel per fetch
operation, and the addition of meta-data to distinguish each of these
channel instances.

Concerns
These modifications would obviously be a significant breaking change to the
current sensor API, and require changes to any drivers using the current API.
Memory usage is also a critical concern, particularly when you need to maintain
a large number of data samples in memory.
Unresolved Questions

How can we best support multiple instances of a channel per fetch event,
without unnecessarily increasing memory usage per data sample or complicating
the sensor API?
How can we minimize breaking changes to the existing API to avoid having to
modify all existing sensor drivers and related application code?
Is a mechanism for returning 'raw' sensor data (lower memory requirements)
useful?

Related Issues
#1387: Lack of a performant sensor API

An initial attempt to address some of the weaknesses and errors in the current light sensor API is visible in PR https://github.com/zephyrproject-rtos/zephyr/pull/14245

I'm interested in this given the need to support the detection of being indoor or outdoor for a digital contact tracing application. Current sensor we are looking at are in this family: Broadcom APDS-9250 - Has components for IR,R,G,B.

Proposal for better sensor channel specifiers #63830 would perhaps atleast address the issue of the type of data (LIGHT) subtype (R/G/B/IR/UV/CUSTOM) and channel index in the sensor (N) to deal with light spectrometer sensors for example.


Identified memory bug in ColorChangingTimerButton

What happens:
It has been seen that the covmatic_lws.gui module fills the available memory (e.g. 2GB) and than throws the error "cannot start a new thread" trying to press every button.

Steps to reproduce
keep the LWS open for some hours. The memory keep growing in a linear manner at a rate of 0.1MB/s

In this PR a decorator is added that wraps the function inside a while loop;
I think the problem is that for some reason the old threads are not garbage-collected, since they're all inside a nested call loop maybe.
Creating this PR just to keep trace of the problem

Verified that this PR creates some delay in the execution of operations, expecially seems to slow down OT because log reading is slow

Resolved in ef242f4 v.2.3.2


Box Metadata Query Support

Is your feature request related to a problem? Please describe.
Please support Box Metadata Query. Customers want to be able to export the results to a CSV file.
Describe the solution you'd like
Execute Box Metadata Query and export results to CSV file
Describe alternatives you've considered
Custom development
Additional context

Thanks @jacquesvandermerwe!  This is on our roadmap (SDK-1418) and we will prioritize it in the next sprint or two.


(Error) assertion failed (see ~/fstar/ulib/FStar.ST.fst(37,44-37,49))

I get the error in title when running this code:
module Ex

open FStar.Heap
open FStar.ST

type state =
  | Open
  | Closed

type file = {name: string; state: ref state}

type isClosed file heap = (sel heap file.state) == Closed
type isOpen file heap = (sel heap file.state) == Open

val openHelper : file:file -> ST unit
    (requires (isClosed file))
    (ensures (fun heap s heap' -> isOpen file heap'))
let openHelper file =
    file.state := Open

let file1 = {
    name = "file1";
    state = alloc Closed;
}

(** EDIT: computeBase should have access to file1 *)
let computeBase () =
    12

(** EDIT: Missing precondition - should only be able to read open files *)
let read file =
    13

val readFromFile : file:file -> ST unit
    (requires (isClosed file))
    (ensures (fun heap s heap' -> isClosed file heap'))
let readFromFile file =
    openHelper file;
    let x = computeBase () + read file in
    file.state := Closed

let nil =
    readFromFile file1

Sorry I couldn't make the example shorter. The error disappears if I place file1 in local scope, but the point was exactly to experiment around variables and state in a wider scope, especially if function computeBase has a reference to file1.
My version of F*:
~/kod/fstar$ ./bin/fstar.exe --version
F* <IP_ADDRESS>
platform=Linux_x86_64
compiler=OCaml 4.03.0
date=2017-02-02T11:54:08+01:00
commit=9fc07cf

Any more info I need to provide?

Before that error you should have got a warning saying that toplevel effects are not supported and that top-level let binding should be total (which is exactly what you seems to be trying to achieve). Just modifying slightly your last toplevel declaration makes it verify
let nil () =
    readFromFile file1

That change will make F* ignore the Closed/Open pre-conditions - the status of file1 does not longer matter for readFromFile.

I find the behavior of F* here indeed counterintuitive.
First, what exactly is the restriction on top-level effects, and why does Olle's original example fail? The error message provides little explanation, and the example seems intuitively fine. What's probably happening is that F* forces the precondition of nil (and other top-level effects) to be trivial, but in this case it's not. For a start, the error message should make this clear.
Second, when thunking nil not only readFromFile file1 works, but also readFromFile file2 where file2 did state = alloc Open instead of state = alloc Closed, which seems to be inconsistent. Pollack inconsistent, since if one digs a bit deeper one realizes that what's actually happening here is that F* is computing and accepting a non-trivial precondition for nil that is nowhere seen in the program. Adding an annotation on nil:
val nil : unit -> St unit
makes the (Error) assertion failed return though, but that irrespective whether one uses file1 or file2. The problem here is that not only are top-level effects required to have trivial preconditions, but also they are given trivial postconditions, so the fact that file1/2 is open or close is completely forgotten. The solution here is to also thunk file1:
let file1 () = {
    name = "file1";
    state = alloc Closed;
}

which will make the last warning go away and F* keep the strong postcondition it computed for file1 and use it when verifying nil:
val nil : unit -> St unit
let nil () =
    readFromFile (file1 ())

So this finally works! Hope it explains things a bit :)
PS: Another was to see the original trivial type of file1 and the non-trivial precondition on nil () without an annotation is  by using the --log_types --print_effect_args flags.
let file1 : file
...
let nil : (uu___:unit -> ST (unit) (isClosed file1), (fun heap s heap' -> (isClosed file1 heap'@0)) (attributes ))

Hi @catalin-hritcu, thanks for your extensive answer!
Changing file1 into a function destroys again part of the purpose of this test - that function computeBase has access to file1 (meaning that we don't know if file1 is closed or open after the call to computeBase).

It seems that what you need for this example is this enhancement:
https://github.com/FStarLang/FStar/wiki/Top-level-effects
https://github.com/FStarLang/FStar/issues/143
While this was discussed about 1 year ago, I'm not aware on progress on that since then.
Until this better solution is implemented one thing you can try is move all your effectful top level definitions and all things that depend on them within your main() function. It ain't pretty, but it might work.

I will try that, thank you.

@catalin-hritcu What's the correct syntax to define both val and let within function scope?

You cannot define a val in function scope, these are declarations which only makes sense at toplevel (and  are not needed unless you are writing a signature file). if you want to be precise about your type you can always annotate the let directly, e.g.
let f (x:t1) (y:t2) : tresult = ...```

@kyoDralliam Thanks!

This is related to top-level effects for which we have discussed a design (https://github.com/FStarLang/FStar/wiki/Top-level-effects), but since this is not on the roadmap right now, closing it as wontfix.


Feature edges connect to top of nodes

Made some minor changes to themes and core to align images to the top of nodes and adjust padding logic so that labels are located at an appropriate distance beneath the image.

Here is the new result based on changes to the code.

Here is the new result based on changes to the code.

Here is the new result based on changes to the code.

Here is the new result based on changes to the code.


Implement Unified Endpoint Discovery

This issue currently tracks the work that needs to be done to complete the implementation of the Unified Endpoint Discovery, so that the usage of endpoint flag can be recommended by default instead of the current state of flags in Thanos, which can cause confusion.
A/C:

This PR has to be completed: https://github.com/thanos-io/thanos/pull/4785
This issue needs to be addressed: https://github.com/thanos-io/thanos/issues/4683
Proposal needs to be implemented: https://thanos.io/tip/proposals-accepted/202101-endpoint-discovery.md/

This is planned to be proposed as a mentorship topic with @bwplotka! 🙂

Hi mentors, I am Sandipan, an undergrad and open source enthusiast. I am interested to take this opportunity of mentorship and to contribute to Thanos by helping in fixing this issue. I am going through the linked issues, pull requests, proposal, and docs.

Hi @saswatamcode! 👋🏻
I am really interested in working on this project. And have even started exploring thanos project and trying to fix bugs. 🙇🏻

Hello @saswatamcode, I applied through LFX and was curious is there anything else except sending resume and cover letter to the application? Maybe some challenge that I missed? Otherwise I'm pretty stocked about the project and looking forward to contributing to these proposal.

Excited for working on this issue :)


Merge fix code from 1.1.0 branch back to master

Merge fix code from 1.1.0 branch back to master

Coverage remained the same at 56.116% when pulling 4d2a2363a73b6b53402f4fa3766f03c9a5d639a8 on steven-zou:master into 3ebd4758c1470719f22bb7a95ad651527cd06acc on vmware:master.


Makes amp-form uses ampstart

@sebastianbenz PTAL

Can you fix the html validation errors?

Applied all changes, @sebastianbenz PTAL

Looks great! Noticed a few minor alignment issues:
Can you align submit button with first radio button?

add margin below submit button (might make sense to check all form samples for this)

Add margin left to paragraphs

@sebastianbenz PTAL

@sebastianbenz you are right, just fixed it

Somehow this change seemed to made it worse:

@sebastianbenz PTAL

Noted this sample for "Hotel Listing Page" is not visible on ampbyexample.com, not sure if a link needs to be added to the menu bar - sample?


[CRASH] when I click on workbench

Hi,
I use Forge 2239
I use biom bundle for gen
I crash when I click on workbench
This is my crash log http://pastebin.com/9Swnykpv
Thx

More info please. What versions of my rftools dimensions?

RFTool dimm 1.1x 4.54
RFTool 1.1x-5.86
mcjtylib 1.1x-2.3.9
compact layer 1.10 0.2.2

I will check it out

BTW, in the future please post to the correct github. This is about RFTools but this bug is in RFTools Dimensions

Fixed next release


add debug.saveBeforeRun setting

This PR fixes #114890 and #117080

@isidorn I made the change you asked :)
Although I'm not sure what you mean by "EditorsInActiveGroup" so hopefully this is what you had in mind. The code saves all open non-untitled editors plus the current focused editor if it is untitled (this is the logic regardless of this PR), but "allEditorsInActiveGroup" implies non-focused untitled files being saved as well, which is not the case (and was also not requested by any issue I've seen).
I've enabled the "Allow edits and access to secrets by maintainers" checkbox if you want to modify my code tomorrow - if you want me to do any changes it will be at this time tomorrow. Thanks!

This looks good.
Two minor changes still needed - I have commented in the code

This works nicely. Thanks for working on this. Merging in ☀


npm install ?

$ npm install Ink --save
npm ERR! Linux 3.13.0-55-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install" "Ink" "--save"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code E404
npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/Ink
npm ERR! 404
npm ERR! 404 'Ink' is not in the npm registry.
npm ERR! 404 Your package name is not valid, because
npm ERR! 404
npm ERR! 404  1. name can no longer contain capital letters
npm ERR! 404 It was specified as a dependency of '...'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

We're currently using https://www.npmjs.com/package/foundation-emails
V2 takes care of most of the setup for you. Check it out here: http://foundation.zurb.com/emails/getting-started.html


%(playlist_index) pads neither by playlist size nor to 5 digits

The man page states that %(playlist_index)s should pad to 5 digits and according to an issue here it is supposed to pad to playlist size but it does neither.
--playlist-start 1 --playlist-end 9 -o "%(playlist_index)s"  starts with 1,
--playlist-start 1 --playlist-end 10 -o "%(playlist_index)s" starts with 01,
--playlist-start 2 --playlist-end 10 -o "%(playlist_index)s" starts with 2,
--playlist-start 2 --playlist-end 11 -o "%(playlist_index)s" starts with 02.
Looks like it uses the number of videos in the current job which results in duplicates when overlapping ranges.
Any of the supposed behaviours would be fine to get consistent lexical sort names when downloading parts of a playlist. Or maybe a flag to specify the size as with $(autonumber)s.

Duplicate of #5185.


Web interface stability issues

Currently the ooni-explorer is very unstable and will often times be stuck in a state where it will not show any measurements and all the API endpoints will timeout.
I made some changes to collect better debug level information and it seems like the issue is with connecting to the database:
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at Timer.listOnTimeout [as ontimeout] (timers.js:121:15)
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: Error in GET /reports/count?where=%7B%22probe_cc%22:%22ET%22%7D: errorName=Error errorMe
ssage=Timeout in connecting after 5000 ms
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: errorStack=Error: Timeout in connecting after 5000 ms
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at null.<anonymous> (/home/ooni-api/ooni-api/node_modules/loopback-datasource-juggler/li
b/datasource.js:2121:10)
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at null._onTimeout (/home/ooni-api/ooni-api/node_modules/loopback/node_modules/continuat
ion-local-storage/node_modules/async-listener/glue.js:188:31)
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at Timer.listOnTimeout [as ontimeout] (timers.js:121:15)
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: Error in GET /reports?filter=%7B%22fields%22:%7B%22test_name%22:true,%22input%22:true,%2
2probe_cc%22:true,%22test_start_time%22:true,%22id%22:true,%22probe_asn%22:true%7D,%22where%22:%7B%22probe_cc%22:%22ET%22%7D,%22offset%
22:0,%22limit%22:100,%22order%22:%22test_start_time+DESC%22%7D: errorName=Error errorMessage=Timeout in connecting after 5000 ms
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: errorStack=Error: Timeout in connecting after 5000 ms
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at null.<anonymous> (/home/ooni-api/ooni-api/node_modules/loopback-datasource-juggler/li
b/datasource.js:2121:10)
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at null._onTimeout (/home/ooni-api/ooni-api/node_modules/loopback/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:188:31)
Aug  6 14:36:23 ip-172-30-2-158 node-ooni-api: at Timer.listOnTimeout [as ontimeout] (timers.js:121:15)
Aug  6 14:36:28 ip-172-30-2-158 node-ooni-api: Error in GET /nettests: errorName=Error errorMessage=Timeout in connecting after 5000 ms
Aug  6 14:36:28 ip-172-30-2-158 node-ooni-api: errorStack=Error: Timeout in connecting after 5000 ms
Aug  6 14:36:28 ip-172-30-2-158 node-ooni-api: at null.<anonymous> (/home/ooni-api/ooni-api/node_modules/loopback-datasource-juggler/lib/datasource.js:2121:10)
Aug  6 14:36:28 ip-172-30-2-158 node-ooni-api: at null._onTimeout (/home/ooni-api/ooni-api/node_modules/loopback/node_modules/continuation-local-storage/node_modules/async-listener/glue.js:188:31)
Aug  6 14:36:28 ip-172-30-2-158 node-ooni-api: at Timer.listOnTimeout [as ontimeout] (timers.js:121:15)
Aug  6 14:37:17 ip-172-30-2-158 node-ooni-api: Connection fails:  { [Error: connect ETIMEDOUT] code: 'ETIMEDOUT', errno: 'ETIMEDOUT', syscall: 'connect' }
Aug  6 14:37:17 ip-172-30-2-158 node-ooni-api: It will be retried for the next request.
Aug  6 14:37:17 ip-172-30-2-158 node-ooni-api: Error: connect ETIMEDOUT
Aug  6 14:37:17 ip-172-30-2-158 node-ooni-api: at errnoException (net.js:905:11)
Aug  6 14:37:17 ip-172-30-2-158 node-ooni-api: at Object.afterConnect [as oncomplete] (net.js:896:19)

While in this state I can confirm that the issue is indeed the database as trying to connect to it also via another client times out.
cc @anadahz

It seems that the network connectivity issue occurred (according to logs) only in Aug 6.
The web interface still seems to be randomly in an unresponsive state.

I think this has been resolved (at least I am no longer seeing stability issues in the statuscake monitoring logs)


:art: Refactored code to improve maintainability

Refactored most code into separate classes to improve project maintainability.

This looks beautiful! I am going to test it now to make sure all the functionality works.

There are a lot of changes here, so this code review is going to take a little while.

@smashling Yeah, I started with "let's move this method" and then I couldn't stop. Thanks for looking at it!

I dont think .okta should be in the .aws folder, as that creates a new profile store for users that are already using the tool, forcing them to move and breaking current functionality.

@mraible wanna take a look at this since you're the Java dude?

@andreihava-okta I overall really like the direction this change has taken the code in. The increased modularity will make it much easier to maintain.

@AlainODea if you're cool with it I say let's merge! =D

@rdegges the moving of the .okta folder into .aws will break things for existing users.
The authentication re-attempt crash @smashling found is also fatal.
Can those be fixed prior to merge? We'll have a broken release otherwise.

@AlainODea I’ll look into this early tomorrow and modify the code according to your comments.
Thanks for looking into this and for the great feedback!

@andreihava-okta thank you! I'm looking forward to it.

@AlainODea @smashling I've adapted the code to the reviews you've left on it.
Most notable changes:

Moved .okta back to user home
Fixed re-authentication crash
Fixed multiple account logout issue caused by a FileReader not being closed
Made OktaAwsCliEnvironment a constructor param for most classes, making them no longer static

@AlainODea The multiple profiles not being used bug has been fixed in the latest commit! 😺

@mraible this is ready to merge.


pydeck: Add pydeck release checklist

For #3640

Background
Documents how to publish pydeck

Change List

Add release checklist for pydeck

Coverage remained the same at 83.331% when pulling 3c2caf7590f37c36768345dcfc049ee452de5f81 on ajd/release-next into e2b76a3fe23e43cb6a516b065a762d72b6a40b2c on master.


prev/next sometimes jumps to the wrong location

Discussed in https://github.com/LazyVim/LazyVim/discussions/3349

Originally posted by dusty-phillips May 28, 2024
I have the trouble-v3 extra enabled, so I'm not 100% sure if this is a bug report against trouble or against the lazyvim configuration of trouble-v3. Since @folke owns both, I just flipped a coin as to which project to post in.
A flow I like to adopt is:

use space-/ to search for some text in telescope
hit ctrl-t to open the search results in trouble
navigate between search results using ]q and [q

In my current (latest lazyvim with all plugins synced recently) setup, the last bullet point isn't work because trouble automatically moves the "selected" element to the list. So when I hit ]q, it selects the next element as expected. But it moves it to the top of the list, so when I hit ]q again, it simply alternates between the top-two elements instead of navigating down the list.
Workaround for now is to not use trouble, so I hit ctrl-q from the telescope window to put the items in quickfix instead of trouble.

@dusty-phillips @dpetka2001 this should be fixed now. Would be great if you can confirm!

Also working for me. ❤

Great!!


potential for black-holing log messages via transitive dependency on gulplog

gulp-util.log checks for hasGulplog on module initialization and if present, defers logging to gulplog.info, which in turn will eat any messages below error (I believe) unless there is explicitly an event handler for the other levels (info, warn, etc.).
This can happen 'accidentally' if a transitive dependency uses gulplog.
It seems like the reasonable thing to do is to use gulplog.error to ensure all logging is output properly.

gulplog.info is the default log level for gulp-cli, which is why we used it (aligns with console.log).  The only messages that aren't logged by default is gulplog.debug.  However, I think you might actually be saying that some dependency is using gulplog, which makes it available in the global scope but you aren't using the new gulp-cli, so no logs are being logged.  Is that correct?

However, I think you might actually be saying that some dependency is using gulplog, which makes it available in the global scope but you aren't using the new gulp-cli, so no logs are being logged. Is that correct?

Correct and I can verify that using the gulp executable from gulp-cli produces the desired behavior, i.e. gulp-util.log produces output even when gulplog is present.
This is fine longer term, but it seems like a potential problem for the unaware - case in point: me and my time lost :(
Super simple example
require('gulplog');
require('gulp-util').log('foobar');

When run using global gulp, no 'foobar'. When using locally installed gulp from gulp-cli, 'foobar' is logged.
Thanks :smile:

Is the solution for gulp-util.log to check (the yet-to-be created) hasGulpCli, instead of hasGulplog?

Is the solution for gulp-util.log to check (the yet-to-be-created) hasGulpCli, instead of hasGulplog?

It could be? Unfortunately, I've moved on and no longer use gulp in my day-to-day work.

Yes, this is still a gulplog issue, I've created an SSCCE at https://gist.github.com/bdukes/5d3d48321ba96f035311ee9f63aace70

This problem won't be solved until we get the community transferred off gulp installed globally ☹


Remove eks go postsubmits not related to the golang-debian image

Issue #, if available:
Description of changes:
For the below prow jobs, they created the EKS Go source code with patches, or generated the RPM images. These are not being used moving forward, and not needed for builder-base, eks-distro-base/golang-compiler, or golang-debian images.
templater/jobs/postsubmit/eks-distro-build-tooling/golang-1-X-postsubmits.yaml
templater/jobs/postsubmit/eks-distro-build-tooling/golang-1-X-PROD-postsubmits.yaml
templater/jobs/postsubmit/eks-distro-build-tooling/golang-1-X-ARM64-PROD-postsubmits.yaml
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


Possible noob with ImportError: No module named ffmpeg

I've gone through the instructions on medium, googled, and reviewed these issues but am lost.
I'm receiving the error
ImportError: No module named ffmpeg when attempting to perform the helloworld.py test. From goggling it seems it may be something in regards to differing python versions but I'm honestly a noob in this domain. I've wiped the pi and performed the install twice now with the same results.
Any tips to resolve?

Hi, sorry to hear that.
Did you use a NOOBS pre-built SD card?:
"If you used NOOBs, then ffmpeg and PIL are already installed. Ffmpeg is slightly fiddly to install, but there are plenty of tutorials out there. If you struggle, use NOOBS."

Tom, thanks for the quick reply. I had previously used the RaspberryPi installer. I started fresh with the NOOBS installer and performed the steps as listed. The first issue begins when attempting to install FF
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-WYSSVj/ffmpeg-python/
pi@raspberrypi:~/SlowMovie $ python helloworld.py
Traceback (most recent call last):
File "helloworld.py", line 15, in
import ffmpeg
ImportError: No module named ffmpeg-python.
Based on this StackOverflow article (https://stackoverflow.com/questions/64095094/command-python-setup-py-egg-info-failed-with-error-code-1-in-tmp-pip-build-rn) pip and setuptools needs an upgrade.
Upon following this article and running the following commands the install for FFMPEG-PYTHON appears successful.
sudo python3 -m pip install -U pip
sudo python3 -m pip install -U setuptools
From the looks of things at this point we should be okay -
Output:
_```
pi@raspberrypi:~/SlowMovie $ sudo python3 -m pip install -U pip
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting pip
Downloading https://files.pythonhosted.org/packages/fe/ef/60d7ba03b5c442309ef42e7d69959f73aacccd0d86008362a681c4698e83/pip-21.0.1-py3-none-any.whl (1.5MB)
100% |████████████████████████████████| 1.5MB 287kB/s
Installing collected packages: pip
Found existing installation: pip 18.1
Not uninstalling pip at /usr/lib/python3/dist-packages, outside environment /usr
Can't uninstall 'pip'. No files were found to uninstall.
Successfully installed pip-21.0.1
pi@raspberrypi:~/SlowMovie $ sudo python3 -m pip install -U setuptools
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Requirement already satisfied: setuptools in /usr/lib/python3/dist-packages (40.8.0)
Collecting setuptools
Downloading https://www.piwheels.org/simple/setuptools/setuptools-54.0.0-py3-none-any.whl (784 kB)
|████████████████████████████████| 784 kB 290 kB/s
Installing collected packages: setuptools
Attempting uninstall: setuptools
Found existing installation: setuptools 40.8.0
Uninstalling setuptools-40.8.0:
Successfully uninstalled setuptools-40.8.0
Successfully installed setuptools-54.0.0
pi@raspberrypi:~/SlowMovie $ sudo pip install ffmpeg-python
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting ffmpeg-python
Downloading https://www.piwheels.org/simple/ffmpeg-python/ffmpeg_python-0.2.0-py3-none-any.whl (25 kB)
Collecting future
Downloading https://www.piwheels.org/simple/future/future-0.18.2-py3-none-any.whl (491 kB)
|████████████████████████████████| 491 kB 411 kB/s
Installing collected packages: future, ffmpeg-python
Successfully installed ffmpeg-python-0.2.0 future-0.18.2

However, the error persist... I've read this could be due to the instances of python being different but I really don't understand that.

pi@raspberrypi:~/SlowMovie $ python helloworld.py
Traceback (most recent call last):
  File "helloworld.py", line 15, in <module>
    import ffmpeg
ImportError: No module named ffmpeg

Any other thoughts?

You;re installing ffmpeg for python3, then running it with python2. Try python3 slowmovie.py

I'm thinking I'll need to reinstall using "sudo python3 setup.py install" as I'm receiving the below waveshare error. Would that make sense?
pi@raspberrypi:/ $ cd ~/SlowMovie
pi@raspberrypi:~/SlowMovie $ python3 helloworld.py
Traceback (most recent call last):
  File "helloworld.py", line 30, in <module>
    from waveshare_epd import epd7in5_V2
ModuleNotFoundError: No module named 'waveshare_epd'

Yes, you night also need sudo pip3 install pillow for PIL

Man, this is a trip - if only I didn't need the Python3 lol. So I got past the waveshare error by doing the install again with python3. That said, now I've got a missing file with PIL even though it's showing within Python3.  I'm assuming there's not a way to simply install a FFMPEG-PYTHON version that doesn't need PYTHON3 as that seems to be the hiccup here.
pi@raspberrypi:~/SlowMovie $ python3 helloworld.py
/home/pi/SlowMovie/Videos/test.mp4
Traceback (most recent call last):
  File "helloworld.py", line 69, in <module>
    pil_im = Image.open("grab.jpg")
  File "/usr/lib/python3/dist-packages/PIL/Image.py", line 2634, in open
    fp = builtins.open(filename, "rb")
FileNotFoundError: [Errno 2] No such file or directory: 'grab.jpg'
pi@raspberrypi:~/SlowMovie $ sudo pip3 install pillow
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Requirement already satisfied: pillow in /usr/lib/python3/dist-packages (5.4.1)
pi@raspberrypi:~/SlowMovie $ python3 helloworld.py
/home/pi/SlowMovie/Videos/test.mp4
Traceback (most recent call last):
  File "helloworld.py", line 69, in <module>
    pil_im = Image.open("grab.jpg")
  File "/usr/lib/python3/dist-packages/PIL/Image.py", line 2634, in open
    fp = builtins.open(filename, "rb")
FileNotFoundError: [Errno 2] No such file or directory: 'grab.jpg'

That error means it cant find the extracted frame.
You don't necessarily need python3, you can install it all using python2 instead.

If I stick with Python2, what are your thoughts on the initial error I'm seeing even with NOOBS?
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-WYSSVj/ffmpeg-python/
pi@raspberrypi:~/SlowMovie $ python helloworld.py
Traceback (most recent call last):
  File "helloworld.py", line 15, in <module>
    import ffmpeg
ImportError: No module named ffmpeg-python.

Try updating pip and setuptools as you did before, but use python instead of python3.
sudo python3 -m pip install -U pip setuptools

YOU SIR ARE AMAZING. Hello World is a go. I'm working on a last-minute anniversary gift so you are literally saving the day for me.  That makes complete sense though that I simply needed to update the setup tools.
Thank you very much! Now to see if I can get our anniversary video in there lol


Update amqp-0-9-1-quickref.css

@SudershanSharma Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@SudershanSharma Thank you for signing the Contributor License Agreement!

Would you mind explaining what this comment is meant to improve?

This is a Hacktoberfest PR spam as far as we can tell. Reporting as such.


Missing properties: minecraft:behavior.tempt

from strider

[ ] can_tempt_while_ridden
[ ] can_tempt_vertically
[ ] sound_interval
[ ] tempt_sound

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e51786d3-85e3-4283-5580-7739600ae4e4
Version Independent ID: c7dabf7f-6ed6-da68-967f-00ac4db74dec
Content: minecraft:behavior.tempt
Content Source: creator/Reference/Content/EntityReference/Examples/EntityGoals/minecraftBehavior_tempt.md
Product: gaming
GitHub Login: @v-josjones
Microsoft Alias: v-josjones

Found the additional properties as well and updated the main post

sound_interval
tempt_sound

These changes are live! https://docs.microsoft.com/en-us/minecraft/creator/reference/content/entityreference/examples/entitygoals/minecraftbehavior_tempt


Full Sklearn pipeline as External Model

Hello,
I am trying to register a custom sklearn in a PiML experience, but I am getting this error:
File "/tmp/ipykernel_35500/19077422.py", line 76, in objective     exp.register(piml_pipeline, "pipeline")   File "piml/api.py", line 2691, in piml.api.Experiment.register   File "piml/workflow/model_train_api.py", line 61, in piml.workflow.model_train_api.ModelAPI.register_model   File "piml/workflow/pipeline.py", line 123, in piml.workflow.pipeline.ModelPipeline.get_data ValueError: could not convert string to float: 'DUMMY STR'
It seems like the get_data expect the input data to be preprocessed, however all my preprocessing steps are included in the sklearn pipeline. I want to have the entire pipeline as single object as I am going to test multiple pipelines with distinct preprocessing methods. The point here seems to be that the is a categorical column, that should be a problem I think.
Here is the code I used:
  # Define model
  model_pipeline = Pipeline([("model", CatBoostClassifier(verbose=0, cat_features=cat_features_idxs))])

  pre_processing_pipeline = Pipeline([
    ('inmputers',
        ColumnTransformer(transformers=[
            ('numerical_imputer', SimpleImputer(missing_values=np.nan, strategy='mean'), NUMERICAL_COLS),
            ('categorical_imputer', SimpleImputer(missing_values=None, strategy='most_frequent'), CATEGORICAL_COLS)
           ])
       ),
   ])

  # Concat Pipelines
  pipeline = Pipeline([
      ('pre_processing', pre_processing_pipeline),
      ('model', model_pipeline)
  ])

    # Fit the pipeline, predict and evaluate
    pipeline.fit(X_train_, y_train_)

    exp = Experiment()
    piml_pipeline = exp.make_pipeline(pipeline, task_type="classification", train_x=X_train_, train_y=y_train_, test_x=X_val_, test_y=y_val_)
    exp.register(piml_pipeline, "pipeline")

Is there a way for me to make it work?
Thanks 😄

Hi @jp-varela
The issue is not likely related to Sklearn's pipeline. Basically, any form of models can be wrapped and registered into piml, see the example here https://selfexplainml.github.io/PiML-Toolbox/_build/html/auto_examples/1_train/plot_2_register_2_arbitrary.html#sphx-glr-auto-examples-1-train-plot-2-register-2-arbitrary-py.
The current version of PiML still assumes the data is float or integer. If the data has string values, you need to convert it to float or integer before registering it into PiML.


OpenSSL 1.1.x: static inline issue with Solaris Studio compiler (and GCC)

Hi OpenSSL-Team,
while porting an internal library to the OpenSSL 1.1 API, we are facing an issue when trying to build a debug-version (-g) of our library. The library itself loads libcrypto via dlopen(), only when it is actually needed. But in the sources we do of course include the OpenSSL-headers. When building our library without optimization and with debug-symbols (-g) the linker complains about undefined symbols. It turns out these are all from ...

the openssl/lhash.h macro definition DEFINE_LHASH_OF, if openssl/ssl.h is included, or
the openssl/safestack.h macro definition SKM_DEFINE_STACK_OF, if just openssl/crypto.h is included.

I constructed a small example C source (inline.c) and will attach it to this issue. To see the errors you may compile this with GCC, like ...
$ gcc -std=c99 -fkeep-inline-functions -g -o inline -I/path/to/openssl-1.1/include -ldl inline.c
/tmp/ccL4XtZc.o: In function `sk_OPENSSL_STRING_num':
/path/to/openssl-1.1/include/openssl/safestack.h:151: undefined reference to `OPENSSL_sk_num'
[...]
/tmp/ccL4XtZc.o: In function `sk_void_set_cmp_func':
/path/to/openssl-1.1/include/openssl/crypto.h:94: undefined reference to `OPENSSL_sk_set_cmp_func'
collect2: error: ld returned 1 exit status

... or the Oracle Developer Studio 12.5 compiler (Linux) ...
$ c99 -g -o inline -I/path/to/openssl-1.1/include -ldl inline.c
inline.o: In function `sk_OPENSSL_STRING_num':
inline.c:(.text+0x31): undefined reference to `OPENSSL_sk_num'
[...]
inline.o: In function `sk_void_set_cmp_func':
inline.c:(.text+0x1c29): undefined reference to `OPENSSL_sk_set_cmp_func'

... or Oracle Developer Studio 12.5 compiler (Sparc Solaris) ...
$ c99 -g -o inline-sparc -I/path/to/openssl-1.1/include inline.c
Undefined                       first referenced
 symbol                             in file
OPENSSL_sk_pop_free                 inline.o
[...]
OPENSSL_sk_find_ex                  inline.o
ld: fatal: symbol referencing errors

We have a solution on Linux, where we use GCC. There it is enough to just remove -fkeep-inline-functions. Although this switch was probably added for a reason.
On Solaris, however, we have to use the Studio compiler. There is no way (we know of) to instruct this compiler to drop unused static functions other than to switch on the optimizer. This is, however, not acceptable for the debug-version of our library.
Do you have any suggestions or ideas, how to get around this?
Thanks!
-- Matthias Kraft

I am somehow unable to attach this file, so here are the few lines:
#include <stdio.h>
#include <dlfcn.h>

#include <openssl/crypto.h>

const char* (* fOpenSSL_version) (int) = NULL;

#define CALL_F(F) (f##F)
#define LOAD_F(F) if ((load_fct( ossl_h, #F, (void*)&f##F )) == 0) return 2

int load_fct( void *h, const char *fn, void **fp ) {
    if ((*fp = dlsym( h, fn )) == NULL)
        return 0;
    return 1;
}

int main(int argc, char *argv[]) {
    void *ossl_h;
    if ((ossl_h = dlopen( "libcrypto.so.1.1", (RTLD_GLOBAL|RTLD_LAZY) )) == NULL)
        return 1;
    LOAD_F(OpenSSL_version);
    printf( "%s\n", CALL_F(OpenSSL_version)( OPENSSL_VERSION ) );
    dlclose( ossl_h );
    return 0;
}

Example doesn't have to be that elaborated,
#include <openssl/crypto.h>
int main(){}

is sufficient...

What you apparently can do in mean time is to compose .h file of own and list those unresolved function as following:
#pragma weak OPENSSL_sk_num
...

Thanks! This gets us going again.

On note related to your user identity, Matthias, and not to this problem. You had AIX-specific modifications to dso_dlfcn.c that allow to load modules from .a. Could you resubmit it as separate request (for master)?

Yes, I still have that on my todo list. I am short on time, however. Will have look to expedite things and push it through it test cycle next week ...

Is this issue still current or should it be closed?

(I've labeled it 'after 1.1.1', because I don't think this is important enough to fix for the 1.1.1 release)

I understand that you want to get the version out. Just to make it obvious for everyone looking at this issue: The mentioned workaround means you have to create a header file with a line
#pragma weak <symbol>
for every symbol mentioned by the compiler and include that header file after
#include <openssl/crypto.h>

Now, having some time to work with OpenSSL again, I come back to this issue. Actually I come back here, because I believe that this issue now makes it impossible to build a debug version of OpenSSL 1.1.1a on a Solaris box :
19:10:48 cc  -Iinclude -xarch=generic64 -xstrconst -Xa -g -D_REENTRANT   -c -o test/rsa_complex.o test/rsa_complex.c
19:10:48 cc: Warning: -xarch=generic64 is deprecated, use -m64 to create 64-bit programs
19:10:49 /usr/ccs/bin/makedepend -f- -Y --  -Iinclude -xarch=generic64 -xstrconst -Xa -g -D_REENTRANT  -- test/rsa_complex.c 2>/dev/null \
19:10:49     > test/rsa_complex.d
19:10:49 rm -f test/rsa_complex
19:10:49 ${LDCMD:-cc} -xarch=generic64 -xstrconst -Xa -g -L. -mt -R '$ORIGIN/../lib'  -R '/opt/.../openssl/lib' \
19:10:49 	-o test/rsa_complex test/rsa_complex.o \
19:10:49 	 -lsocket -lnsl -ldl -lpthread -lm
19:10:49 cc: Warning: -xarch=generic64 is deprecated, use -m64 to create 64-bit programs
19:10:49 Undefined			first referenced
19:10:49  symbol  			    in file
19:10:49 OPENSSL_sk_pop_free                 test/rsa_complex.o
19:10:49 OPENSSL_sk_dup                      test/rsa_complex.o
19:10:49 OPENSSL_sk_pop                      test/rsa_complex.o
19:10:49 OPENSSL_sk_num                      test/rsa_complex.o
19:10:49 OPENSSL_sk_new                      test/rsa_complex.o
19:10:49 OPENSSL_sk_set                      test/rsa_complex.o
19:10:49 OPENSSL_sk_free                     test/rsa_complex.o
19:10:49 OPENSSL_sk_find                     test/rsa_complex.o
19:10:49 OPENSSL_sk_push                     test/rsa_complex.o
19:10:49 OPENSSL_sk_sort                     test/rsa_complex.o
19:10:49 OPENSSL_sk_zero                     test/rsa_complex.o
19:10:49 OPENSSL_sk_is_sorted                test/rsa_complex.o
19:10:49 OPENSSL_sk_shift                    test/rsa_complex.o
19:10:49 OPENSSL_sk_value                    test/rsa_complex.o
19:10:49 OPENSSL_sk_delete_ptr               test/rsa_complex.o
19:10:49 OPENSSL_sk_unshift                  test/rsa_complex.o
19:10:49 OPENSSL_sk_new_null                 test/rsa_complex.o
19:10:49 OPENSSL_sk_set_cmp_func             test/rsa_complex.o
19:10:49 OPENSSL_sk_reserve                  test/rsa_complex.o
19:10:49 OPENSSL_sk_new_reserve              test/rsa_complex.o
19:10:49 OPENSSL_sk_delete                   test/rsa_complex.o
19:10:49 OPENSSL_sk_insert                   test/rsa_complex.o
19:10:49 OPENSSL_sk_deep_copy                test/rsa_complex.o
19:10:49 OPENSSL_sk_find_ex                  test/rsa_complex.o
19:10:49 ld: fatal: symbol referencing errors
19:10:49 *** Error code 2
19:10:49 make: Fatal error: Command failed for target `test/rsa_complex'
19:10:49 Current working directory /.../build/openssl-1.1.1a
19:10:49 *** Error code 1
19:10:49 make: Fatal error: Command failed for target `all'

Just a side note: The issue title has become a little bit outdated by now. Would you mind removing the OpenSSL 1.1.0h: prefix, or replacing it by OpenSSL 1.1.x: or OpenSSL 1.1: (whichever you prefer)?

I have built the openssl binary executable using openssl-1.1.1c on a Solaris 64-bit system with an AMD processor, using the Sun Studio C 12.4 C compiler.
The configuration was:
./Configure solaris64-x86_64-cc -static no-ec no-mdc2 no-rc5 no-idea no-asm -fPIC --openssldir=
The 1.1.1c files lhash.h and safestack.h already contain the pragma shown here.
I still get the following error.
$ ./openssl
ld.so.1: openssl: fatal: relocation error: file openssl: symbol OPENSSL_sk_new_null: referenced symbol not found
Killed
$
Is there a code change I can make that will eliminate this?
I have already looked at about a half a dozen other pages in this forum and tried rearranging link order and playing with compiler options to no avail.
$ ./openssl
ld.so.1: openssl: fatal: relocation error: file openssl: symbol OPENSSL_sk_new_null: referenced symbol not found
Killed
$

I have built the openssl binary executable using openssl-1.1.1c on ...

I think you are commenting in the wrong place.
Please see https://github.com/openssl/openssl/issues/8102


List construction with ActionsSDK 2.0

I am trying to construct a list response type using the snippet of code posted on the website as a reference - https://developers.google.com/actions/assistant/responses#list.
There seems to be a mismatch between the node JS example and the JSON example for Image. Is the expected key in the Image() supposed to be alt or accessibilityText ?
JSON -

Node js SDK -

SDK version -<EMAIL_ADDRESS>

Hi, the Image class here is a wrapper for the raw image JSON.
The wrappers have a separate API and sometimes simplify naming to be easier for development purposes but still result in the underlying JSON to be the same as the raw API.
For the complete list of options for the Image wrapper, you can check the reference docs for the library for ImageOptions.
Any time you see new Class({ besides transactions related APIs, it's probably a wrapper and you can search for the corresponding wrapper options like ClassOptions in the reference docs.

Thanks, When I use the key alt instead of accessibilityText when using Image  , I get the following error -
API Version 2: Failed to parse JSON response string with 'INVALID_ARGUMENT' error: "(list_select.items[2].image) alt: Cannot find field.".
Changing it to accessibilityText seems to solve the problem.
I think it was because I was not invoking new Image(), instead constructing the JSON directly. Switching to new Image has resolved the issue


[FEATURE] Better Bolt intergration

Is your feature request related to a problem? Please describe.
While it's not so difficult to make Bolt and Atoms work together, certain things seems a little bit off.
Few examples:

You can't make an Atom Reference node, you can only make an Atom Constant or an Atom Variable node. Nor have a Atom Reference as a Bolt Variable

Atom Events can't be directly listened in a graph. You have several ways to achieve this, like add to your GameObject an EventListener which will trigger an UnityEvent which will call an UnityEvent node on the chart. It is not the most user friendly

There are no icons on nodes

Describe the solution you'd like
It might be a good idea to have an other Atoms module for a natural Bolt integration, as I thing the two plugin try to achieve a similar goal (give better tools to game designers) and could work perfectly together.
Additional context
In may 2020 Unity acquired Bolt and stated they are working on a V2 and since july they release it for free for everyone.
It's clear that Bolt will be an important part of Unity workflow as a direct competitor of UE blueprint.

Hi @bguyl! Sounds definitely like a nice thing to add to Atoms! Not sure if I will have the time to do this myself, but if you or someone else is up for a PR is most welcomed.

The current Bolt API is sparsely documented (read, not documented at all officially). There are some community tutorials and user made extensions and asset's source that can be studied but it's not a lot to go on.
Unity plan to implement a new, parallel API for custom node coding which will be documented and easier to work with once it's ready. So it might be worth waiting until that's done.

I started working on this topic in a separate package: https://github.com/bguyl/unity-atoms-vs

I started working on this topic in a separate package: https://github.com/bguyl/unity-atoms-vs

Added this to Backlog milestone as v4 won't have new features and it's uncertain if this will be in v5.

Added this to Backlog milestone as v4 won't have new features and it's uncertain if this will be in v5.

I'll close this since
a) bguyl has created an own repo for this as an addon - which is perfectly fine to do.
b) there is no much traction on this issue (january 2021)
c) it currently does not look like one of us maintainers will work on it.


Don't include art_series cards they break things.

Hey @bakert,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: d7b1edc0-e303-11e9-8d2a-9fae2038ad51


Intermittent 502 errors when running release tests on testnet.

Description
The following errors occur intermittently when running the release tests:
 1) RPC Server Acceptance Tests
       Acceptance tests
         @api-batch-2 RPC Server Acceptance Tests
           eth_getBalance
             @release should correctly execute "eth_getBalance" with block number in the last 15 minutes with several txs around that time:
     Error: server response 502 Bad Gateway (request={  }, response={  }, error=null, code=SERVER_ERROR, version=6.9.1)
      at makeError (packages/server/node_modules/ethers/src.ts/utils/errors.ts:694:21)
      at assert (packages/server/node_modules/ethers/src.ts/utils/errors.ts:715:25)
      at FetchResponse.assertOk (packages/server/node_modules/ethers/src.ts/utils/fetch.ts:939:15)
      at JsonRpcProvider._send (packages/server/node_modules/ethers/src.ts/providers/provider-jsonrpc.ts:1232:18)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at /Users/user/projects/hedera-json-rpc-relay/packages/server/node_modules/ethers/src.ts/providers/provider-jsonrpc.ts:537:40

  2) RPC Server Acceptance Tests
       Acceptance tests
         @api-batch-2 RPC Server Acceptance Tests
           eth_getCode
             "before all" hook for "should execute "eth_getCode" for hts token":
     Error: transaction execution reverted (action="sendTransaction", data=null, reason=null, invocation=null, revert=null, transaction={ "data": "", "from": "0x711d96bd029A74C785804B268fa4eD2F9EdD1cC1", "to": "0xa2E6265E6fCFD8A3424B7E6119F0E84A6B3596AE" }, receipt={ "_type": "TransactionReceipt", "blockHash": "0x83dcb032f6acf32fbd0ea4dea882616fc30127d99d2e60b862e13b5afbc6af6a", "blockNumber": 6763889, "contractAddress": null, "cumulativeGasUsed": "4000000", "from": "0x711d96bd029A74C785804B268fa4eD2F9EdD1cC1", "gasPrice": "960000000000", "gasUsed": "4000000", "hash": "0x30503905fbfcf39f4bc021cd298dd4f7a6e1387c6ca0acab65a99d3be7171bee", "index": 0, "logs": [  ], "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "root": null, "status": 0, "to": "0xa2E6265E6fCFD8A3424B7E6119F0E84A6B3596AE" }, code=CALL_EXCEPTION, version=6.9.1)
      at makeError (packages/server/node_modules/ethers/src.ts/utils/errors.ts:694:21)
      at assert (packages/server/node_modules/ethers/src.ts/utils/errors.ts:715:25)
      at checkReceipt (packages/server/node_modules/ethers/src.ts/providers/provider.ts:1469:19)
      at ContractTransactionResponse.wait (packages/server/node_modules/ethers/src.ts/providers/provider.ts:1486:24)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at ContractTransactionResponse.wait (packages/server/node_modules/ethers/src.ts/contract/wrappers.ts:136:25)

  3) RPC Server Acceptance Tests
       Acceptance tests
         @web-socket Acceptance Tests
           Subscribes to log events
             "before all" hook for "Subscribes for debug":
     Uncaught Error: server response 502 Bad Gateway (request={  }, response={  }, error=null, code=SERVER_ERROR, version=6.9.1)
      at makeError (packages/server/node_modules/ethers/src.ts/utils/errors.ts:694:21)
      at assert (packages/server/node_modules/ethers/src.ts/utils/errors.ts:715:25)
      at FetchResponse.assertOk (packages/server/node_modules/ethers/src.ts/utils/fetch.ts:939:15)
      at JsonRpcProvider._send (packages/server/node_modules/ethers/src.ts/providers/provider-jsonrpc.ts:1232:18)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at /Users/user/projects/hedera-json-rpc-relay/packages/server/node_modules/ethers/src.ts/providers/provider-jsonrpc.ts:537:40

[2024-01-04 17:10:32.166 +0000] INFO (rpc-acceptance-test/23450 on Admins-Laptop.hsd1.co.comcast.net): Acceptance Tests spent 1730.60724683 ℏ
[2024-01-04 17:10:32.166 +0000] INFO (rpc-acceptance-test/23450 on Admins-Laptop.hsd1.co.comcast.net): Stop relay
npm notice
npm notice New patch version of npm available! 10.2.4 -> 10.2.5
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.2.5
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice
➜  hedera-json-rpc-relay git:(1986-tests-are-flaky-gas-fees) ✗

Steps to reproduce

Point to testnet.
Run the release tests: npm run acceptancetest:release

Additional context
No response
Hedera network
testnet
Version
v0.39.0
Operating system
macOS

Could not reproduce.


ANDROID presentPaymentSheet issue

hi!
the method "presentPaymentSheet" works fine in iOS, it returns all data correctly.
BUT on Android it doesn't work the very first time. It works fine from the second time on.
So I cannot have the result the first time I call the function.
Why?!

I'm have the same problem, any solution?

Hi!
Is it possible to share the error log about the issue?
Or does not error happen? (Just not showing the modal)
Thanks.

It does not generate an error, the payment modal is not lifted, the second time the modal is opened it opens correctly.

It does not generate an error, the payment modal is not lifted, the second time the modal is opened it opens correctly.

can you paste a code snippet from your app?
(ciao Giuseppe, se vuoi scrivimi un messaggio privato, diamo un'occhiata al codice)

Has this problem been resolved? No action taken, so this Issue is closed. If you continue to have problems, please create a new Issue.


Fix android build

Build on Android did some crashes, so this is an attempt to fix it.

Already fixed in #128 .


Implement %{ }%

%{ stmts }% allows the program to recover the capabilities for arrays and imply that a sequence of statements are executed on a different clock cycle. Implementing this for now requires changing the capability checking and type checker.
This program is valid:
%{ a[i] := c[i] + 1 }%
%{ b[i] := 2 * a[i] }%

Hi, unsure in which issue I should request this clarification.
I presume this is the initial discussion on the serial operator ---
Is the serial operator intended to sequence memory operations into different clock cycles?
It's not the same notion of sequencing between the combine operator scopes I presume?
let x = 1;
let y = x;

This doesn't need sequencing with ---, does it?

Yes.


Assert Xcode version when building fbsimctl

Provide better error message if somebody installs via Homebrew and does not have Xcode 8 installed.

Awesome! Thanks for making this generic, will be handy for migrations in the future


Install all missing dependencies, not just the first level in the tree

can we add a unit test for this to avoid regressions?

Sure. The reproduction step is super-simple.


"cf push" is consistently reporting "panic: runtime error" on Windows 10 Home 32-bit version

Experiencing "runtime error: invalid memory address or nil pointer dereference" with cf-cli-installer_6.22.2_win32.zip on Windows 10 Home 32-bit version.
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x52330b]
goroutine 908 [running]:
panic(0xaf1900, 0x11d2e030)
/usr/local/go/src/runtime/panic.go:500 +0x331
sync/atomic.LoadUint64(0x12134e5c, 0x11f51cf8, 0x12134dc0)
/usr/local/go/src/sync/atomic/asm_386.s:159 +0xb
code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer.(*Consumer).retryAction(0x12134dc0, 0x11dbf380, 0x121332c0)
/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer/async.go:269 +0xa2
code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer.(*Consumer).streamAppDataTo(0x12134dc0, 0x11f4c780, 0x1207c3f0, 0x24, 0x11f44700, 0x326, 0x12137c58, 0x121332c0, 0x79f401)
/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer/async.go:188 +0x10c
code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer.(*Consumer).tailingLogs.func2(0x121332c0, 0x12133280, 0x12134dc0, 0x11f4c780, 0x1207c3f0, 0x24, 0x11f44700, 0x326, 0x12137c58, 0x1)
/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer/async.go:163 +0xae
created by code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer.(*Consumer).tailingLogs
/tmp/build/80754af9/gopath/src/code.cloudfoundry.org/cli/vendor/github.com/cloudfoundry/noaa/consumer/async.go:164 +0x106

Duplicate of  #991. This issue has been resolved in cf CLI 6.23.0.
https://github.com/cloudfoundry/cli#downloads
Regards,
Dies Koper
CF CLI PM


fix read and write I/O timeout.

If the connected pop3 server port is not open, the timeout option will not take effect.

Thanks for the PR. This should ideally be new params called opt.ReadTimeout and opt.WriteTimeout. In addition, the timeouts should be reset on encountering ErrDeadlineExceeded.

By reset do you mean when the io.Reader or io.Writer encounters os.ErrDeadlineExceeded? I don't understand, thanks！

After a deadline has been exceeded, the connection can be refreshed by setting a deadline in the future.

It is explained in the comments here: https://pkg.go.dev/net#Conn
Basically, if a connection times out, if it has to be reused, its deadlines have to be set again.

Thank for reply!


Qdt-Component Dynamic height for objects ?

I want to give the objects a constantly changing Height.But Angular 6  only once renders inside the qdt-component.ts
Ex:
this . qdtComponent . render ( this . Component ,  this . props ,  this . elementRef . nativeElement );
Is there any way to redraw the same object when the height changes ?

the simplest way is to just call window.resize(). both QdtPicasso and QdtViz will resize on a window resize.


Runaway feedback loop when displaying multiple views of a vtk pane

Description of expected behavior and the observed behavior
When a VTK pane is displayed multiple times in a notebook, rotating one of the views often results in some sort of unstable feedback loop.  I've been trying to debug a similar issue (or at least apparently a similar issue) in https://github.com/pyviz/panel/pull/549 for the plotly pane.
ALL software version info (Panel, bokeh, python, notebook, OS, browser, any other relevant packages)
python 3.7
bokeh 1.3.0
panel 0.6.0
notebook 6.0.0
Complete, minimal, self-contained example code that reproduces the issue
import panel as pn
pn.extension('vtk')

dragon = pn.pane.VTK('https://raw.githubusercontent.com/Kitware/vtk-js/master/Data/StanfordDragon.vtkjs',
                     sizing_mode='stretch_width', height=400)
dragon

[first view]
dragon

[second view]

After rotating one of the views for a few seconds (sometimes is takes longer), the other view starts jittering and the notebook's process indicator shows that the there is continued feedback from the JavaScript side to the Python side.  The only way to break out of this state is to restart the kernel.
The VTK pane has logic already that seems like it should help prevent this kind of thing (See usage of the _setting property in panel/models/vtk.ts).  And after debugging this kind of issue in the Plotly pane in https://github.com/pyviz/panel/pull/549, I've been unable to pinpoint the source of the feedback.  So I'm wondering if there is something going on in a layer below the pane itself.
And here is the JavaScript console error the appears at the same time that the feedback loop starts:
Chrome:

Interestingly, the console error looks very different in Firefox (same behavior though)

Here are the results of another experiment.  This time I placed two references to the dragon pane in a Column layout.
import panel as pn
pn.extension('vtk')

dragon = pn.pane.VTK('https://raw.githubusercontent.com/Kitware/vtk-js/master/Data/StanfordDragon.vtkjs',
                     sizing_mode='stretch_width', height=400)
pn.layout.Column(dragon, dragon).servable()

In the notebook I get the same error as above (Cannot read property 'content' of null), but I don't see the runaway feedback behavior.  After the error is raised the first time, the two views are no longer linked.
Here's what I see when I serve this notebook with panel serve:

When I drag the top view, everything is synchronized perfectly, with no runaway feedback state.  But when I drag the bottom view, the top view does not respond.

I think this is an issue with updates arriving from python triggering a JS change event which then bounces back to python. I thought this was fixed a while ago but I recently saw an indication that this can still happen in certain scenarios so I'll have to investigate.

I think I found the issue 🤞 PR forthcoming ...

PR https://github.com/pyviz/panel/pull/553


broken link

To create your own custom SecretProviderClass object with provider-specific parameters for the Secrets Store CSI driver, use this template. This object will provide identity access to your key vault.
current link: https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/examples/v1alpha1_secretproviderclass_service_principal.yaml
should be: https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/examples/service-principal/v1alpha1_secretproviderclass_service_principal.yaml

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eee999c1-32dd-d014-40df-8027adee1258
Version Independent ID: 19a29c09-79f8-580a-841f-873e2801da56
Content: Integrate Azure Key Vault with Kubernetes
Content Source: articles/key-vault/general/key-vault-integrate-kubernetes.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@fkucuk
Thank you for pointing this out!
I've created a PR to update the documentation and it's currently waiting for the author(@msmbaldwin) to review and sign off.
We are currently tracking the issue on this thread - #71076
I will now close out this issue. Please allow some time for the author to review and the changes to reflect.
Thank you for your time and patience!


security

Build 'algo' is failing!
Last 50 lines of build output:
[...truncated 44 lines...]

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (audit)
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] withEnv
[Pipeline] {
[Pipeline] dir
Running in /var/jenkins_home/workspace/algo/app-devops-bootcamp/api-store
[Pipeline] {
[Pipeline] sh
+ npm audit
# npm audit report

webpack  5.0.0 - 5.75.0
Severity: high
Cross-realm object access in Webpack 5 - https://github.com/advisories/GHSA-hc6q-2mpp-qw7j
fix available via `npm audit fix`
node_modules/webpack
  @nestjs/cli  7.5.1-next.1 || 7.5.2-next.2 - 9.2.0
  Depends on vulnerable versions of webpack
  node_modules/@nestjs/cli

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] deleteDir
[Pipeline] step

View full output

Build 'algo' is failing!
Last 50 lines of build output:
[...truncated 44 lines...]

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (audit)
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] withEnv
[Pipeline] {
[Pipeline] dir
Running in /var/jenkins_home/workspace/algo/app-devops-bootcamp/api-store
[Pipeline] {
[Pipeline] sh
+ npm audit
# npm audit report

webpack  5.0.0 - 5.75.0
Severity: high
Cross-realm object access in Webpack 5 - https://github.com/advisories/GHSA-hc6q-2mpp-qw7j
fix available via `npm audit fix`
node_modules/webpack
  @nestjs/cli  7.5.1-next.1 || 7.5.2-next.2 - 9.2.0
  Depends on vulnerable versions of webpack
  node_modules/@nestjs/cli

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] deleteDir
[Pipeline] step

View full output

Build 'algo' is failing!
Last 50 lines of build output:
[...truncated 44 lines...]

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (audit)
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] withEnv
[Pipeline] {
[Pipeline] dir
Running in /var/jenkins_home/workspace/algo/app-devops-bootcamp/api-store
[Pipeline] {
[Pipeline] sh
+ npm audit
# npm audit report

webpack  5.0.0 - 5.75.0
Severity: high
Cross-realm object access in Webpack 5 - https://github.com/advisories/GHSA-hc6q-2mpp-qw7j
fix available via `npm audit fix`
node_modules/webpack
  @nestjs/cli  7.5.1-next.1 || 7.5.2-next.2 - 9.2.0
  Depends on vulnerable versions of webpack
  node_modules/@nestjs/cli

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] deleteDir
[Pipeline] step

Changes since last successful build:
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
View full output
View full output

Build 'algo' is failing!
Last 50 lines of build output:
[...truncated 44 lines...]

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (audit)
[Pipeline] tool
[Pipeline] envVarsForTool
[Pipeline] withEnv
[Pipeline] {
[Pipeline] dir
Running in /var/jenkins_home/workspace/algo/app-devops-bootcamp/api-store
[Pipeline] {
[Pipeline] sh
+ npm audit
# npm audit report

webpack  5.0.0 - 5.75.0
Severity: high
Cross-realm object access in Webpack 5 - https://github.com/advisories/GHSA-hc6q-2mpp-qw7j
fix available via `npm audit fix`
node_modules/webpack
  @nestjs/cli  7.5.1-next.1 || 7.5.2-next.2 - 9.2.0
  Depends on vulnerable versions of webpack
  node_modules/@nestjs/cli

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] deleteDir
[Pipeline] step

Changes since last successful build:
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
No changes
View full output
View full output


More html id's in views

Coverage remained the same at 92.632% when pulling 248507d8265d3568160f563fc08301265d47637c on nimmo-more-ids into 9f5708c39ec6e19ddf22824eef7fdf663ff86d62 on master.


Providing DICOM metadata from Workflow Usage.

Parent Ticket #96
To support the Workflow manger's ability to have conditional workflows we need to be able to expose the DICOM metadata dictionary.  This is Json files saved at the series and study level of the DICOM folder structures.
These file need to be loaded into a Dictionaries, and have appropriate methods exposed for access data from the Series And data from the Study.
This DICOM Data can be address either by the DICOM TAG ‘(0018,0050)’ or the DICOM TAG Name ‘SliceThickness’
Folder structure
The following structure should be used within MinIO:
BUCKET
- {{PAYLOAD_ID}}
-- dcm
--- series1
--- series2

File Structure

To be confirmed by Victor.

Acceptance criteria

GIVEN that the DICOM meta data Json files exist WHEN parsed THEN this should create the required data dictionaries.
GIVEN that the DICOM meta data has been parsed WHEN a TAG/NAME is requested which exist within the Data THEN the string should be returned.
GIVEN that the DICOM meta data has been parsed WHEN a TAG/NAME is requested which doesn't exist within the Data THEN A NULL should be returned.

Notes:
inside series,
there is image file
and metadata json file
id-.dcm.json
for metadata file, either
we store dicom tags as "0000", "0000". They are stored without comma in json file.
Any
grab first json file from first series and look for the tag.
If tag doesn't exist, go to the next series etc, until one is found.
If nothing found return null.
All
If its not found in any, return null

Example Tags
context.dicom.series.any('0010','0040')
first series folder has a null look at series 2 if it has a value use that.
no value 'null'
context.dicom.series.all('0010','0040')  'null' ""
value has to be same across all series. if its not return null if it is return value.
if first is a null break out loop and return null.

@lillie-dae can we close this as complete?

Closed


Fix memory leak in init_term().

Output of valgrind --leak-check=full build/src/demo/keyboard and pressing a few keys:
Before:
==86608== HEAP SUMMARY:
==86608==     in use at exit: 29,236 bytes in 377 blocks
==86608==   total heap usage: 492 allocs, 115 frees, 138,145 bytes allocated
==86608==
==86608== 3,322 bytes in 1 blocks are definitely lost in loss record 78 of 78
==86608==    at 0x66BB: malloc (in /usr/local/Cellar/valgrind/3.10.1/lib/valgrind/vgpreload_memcheck-amd64-darwin.so)
==86608==    by 0x10664: read_file (in /Users/.../termbox/build/src/libtermbox.dylib)
==86608==    by 0x105A5: terminfo_try_path (in /Users/.../termbox/build/src/libtermbox.dylib)
==86608==    by 0x10111: load_terminfo (in /Users/.../termbox/build/src/libtermbox.dylib)
==86608==    by 0xDA9C: init_term (in /Users/.../termbox/build/src/libtermbox.dylib)
==86608==    by 0xD802: tb_init (in /Users/.../termbox/build/src/libtermbox.dylib)
==86608==    by 0x100001A3A: main (in build/src/demo/keyboard)
==86608==
==86608== LEAK SUMMARY:
==86608==    definitely lost: 3,322 bytes in 1 blocks
==86608==    indirectly lost: 0 bytes in 0 blocks
==86608==      possibly lost: 0 bytes in 0 blocks
==86608==    still reachable: 0 bytes in 0 blocks
==86608==         suppressed: 25,914 bytes in 376 blocks
==86608==
==86608== For counts of detected and suppressed errors, rerun with: -v
==86608== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 17 from 17)

After:

==86465== HEAP SUMMARY:
==86465==     in use at exit: 25,914 bytes in 376 blocks
==86465==   total heap usage: 492 allocs, 116 frees, 138,145 bytes allocated
==86465==
==86465== LEAK SUMMARY:
==86465==    definitely lost: 0 bytes in 0 blocks
==86465==    indirectly lost: 0 bytes in 0 blocks
==86465==      possibly lost: 0 bytes in 0 blocks
==86465==    still reachable: 0 bytes in 0 blocks
==86465==         suppressed: 25,914 bytes in 376 blocks
==86465==
==86465== For counts of detected and suppressed errors, rerun with: -v
==86465== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 17 from 17)

Note that I'm not 100% sure if this patch is correct. :)

Looks correct.


Prepare the module for publishing on NPM:

Build all TypeScript file into the build/ folder
Set main in package.json to point to the build/ folder
Set test script in package.json
Update module dependencies

:wave:
Can you publish this module on NPM?

Published here https://www.npmjs.com/package/epcis-js
Let me know if you want me to add you as an owner.

Thanks @matgnt !
BTW, I noticed something weird. With this change you have to include the separate files in the module like this:
var epcisparser = require('epcis-js/build/lib/epcisparser')

Is there any way to export all sub modules from the index.js instead of relying on relative path? I'm not that familiar with TypeScript.

Sorry @simov  , I'll be travelling for the next 7 weeks and can't really look into this.


Empty state file gives error

gitlab-ci-local
gitlab-ci-local [job]
Runs the entire pipeline or a single [job]
Positionals:
job  Jobname to execute                                               [string]
Options:
--help        Show help                                              [boolean]
--version     Show version number                                    [boolean]
--manual      One or more manual jobs to run during a pipeline         [array]
--list        List jobs and job information                           [string]
--cwd         Path to a gitlab-ci.yml                                 [string]
--completion  Generate bash completion script                         [string]
--needs       Run needed jobs, when executing a single job           [boolean]
TypeError: Cannot read property 'pipelineIid' of undefined
at Object.incrementPipelineIid (/snapshot/gitlab-ci-local/dist/predefined_variables.js)
at Object.handler (/snapshot/gitlab-ci-local/dist/default_cmd.js)
at Object.runCommand (/snapshot/gitlab-ci-local/node_modules/yargs/lib/command.js:240:40)
at Object.parseArgs [as _parseArgs] (/snapshot/gitlab-ci-local/node_modules/yargs/yargs.js:1182:35)
at Object.get [as argv] (/snapshot/gitlab-ci-local/node_modules/yargs/yargs.js:1088:21)
at Object. (/snapshot/gitlab-ci-local/dist/index.js)
at Module._compile (pkg/prelude/bootstrap.js:1320:22)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
at Module.load (internal/modules/cjs/loader.js:1000:32)
at Function.Module._load (internal/modules/cjs/loader.js:899:14)

I don't know how on earth that would ever become empty. But i'll implement a check for it

@moberghammer I don't know if this is actually fixed. But I'm closing this, since I haven't heard any complains the last 2 months.
We can always open a new open, if the problem reappears.


TasksContent Component Refactor

Related Issue:

#896

Description
TasksComponent has become hard to maintain due to having too many states, causing unnecessary re-renders and also making an unnecessary api call for fetching tasks with previous query states. When implementing multiple assignee tasks search, these problems are causing unwanted side effects (eg, fetching tasks for old assignees value when searching for multiple assignes until unless refreshed). So the component has to be refactored before completing issue #896 .
This refactor will also help future feature implementations by simplifying the component.
Screenshots

The above screenshot shows two same api calls made when searching tasks for assignee 'ajoy-kumar' after pressing search button.

Design Doc: Google Docs Link

LGTM :+1:

Closed by pull #915


Clarifying the behaviour of "callee-save" floating point registers in the soft-float ABI

This document should clarify whether fs0-fs11 should be considered callee-save when compiling for the soft-float ABI. e.g. -march=rv32imaf -mabi=ilp32.
I would suggest that all floating point registers must be considered temporaries when compiling for the soft float ABI. Consider linking object file F.o compiled with -march=rv32imaf -mabi=ilp32 and D.o compiled with -march=rv32imafd -mabi=ilp32. If code in D.o stores a double in fs0 and code in F.o attempts to spill it, the value would obviously be corrupted. We could of course define new bits in e_flags and linker behaviour to try catch these problems at link time (ensuring code compiled with FLEN=0 is only linked with code compiled with one other FLEN value, e.g. a mix of objects with flen=0 and flen=32 is fine, but not flen=0 and flen=32 and flen=64).

I think we are already doing this: "For the purposes of this section, FLEN refers to the width of a floating-point register in the ABI. ... Floating-point registers fs0-fs11 shall be preserved across procedure calls, provided they hold values no more than FLEN bits wide."
So it follows that when the ABI FLEN is 0 that fs0-fs11 are not preserved across calls at all.  Do you think we need to add a sentence clarifying this fact?
(FYI, GCC is doing something overly conservative here: it disallows holding values wider than the ABI FLEN in fs0-fs11 altogether.  In the RV32D + ILP32F case, I'm not sure how to tell GCC that the registers are callee-saved for F values but call-clobbered for D values, so I think we will keep this conservative implementation.  But in the ILP32 case, GCC should just treat fs0-fs11 as temporaries.)

The GCC behavior has been fixed to allow use of fs0-fs11 as call-clobbered registers in the ILP32 case.  This doesn't break the ABI because, as I mentioned, the implementation previously disallowed the use of fs0-fs11 in soft-float code. https://github.com/riscv/riscv-gcc/pull/103

And even more explicit under the "base" integer calling convention: "No floating-point registers, if present, are preserved across calls." Sorry for the noise, I'd thought the tables under the "register map" were the only reference on callee-save registers and didn't re-check that assumption.
I think it is handy for the register tables to indicate which registers are callee-save. What do you think of a patch that changes the entry in the FPR tables to "Yes*" and an explanation:
"*: Values are only preserved if they are no larger than the width of a floating-point register in the targeted ABI. Therefore, these registers can always be considered temporaries if targeting the base integer calling convention."
There is obviously some repetition vs the other sections, but it seems if we're going to duplicate some information (which registers are preserved), we might as well add in the extra couple of sentences that explicitly clarify the situation.

Makes sense to me.  I've made the change; make sure it doesn't clobber with the large refactoring PR gets merged :)

Thanks, closing this issue.


IMN-842 - Removing uuid and using crypto

Closes IMN-842
Why?

crypto is integrated in node and it is now the standard way to do it in node/JS
we remove an unnecessary external dep
crypto.randomUUID() is faster

See:

https://stackoverflow.com/a/40191779
https://medium.com/@matynelawani/uuid-vs-crypto-randomuuid-vs-nanoid-313e18144d8c

@taglioni-r thanks! Merging this one as well, just a reminder to apply the same changes to your PRs that scaffold new services 🙏


Installation in Freebsd (Jail)

Hi there,
I am trying to go get go-face on freebsd 1202000 (well, it is used as a dependency in photoview but I guess that does not matter).

First I tried to install dlib via a pkg install dlib-cpp which installs version 19.21_1 in /usr/local.
Second I built it myself from master, which also installed fine to /usr/local.

However, in both cases I am getting the following:
go get github.com/Kagami/go-face
# github.com/Kagami/go-face
classify.cc:2:10: fatal error: 'dlib/graph_utils.h' file not found

Maybe somebody has an idea. Unfortunately my go experience is in the range zero + search engine.
(This pointed me to #19 but I could not solve anything from there...)

I ran into this same issue while building something else which depends on go-face. I don't know if cgo is meant to use pkg-config (or similar) somehow automatically but really all that was missing was the specification of where the includes and libs are.
Manually adding -I/usr/local/include to the CXXFLAGS comment and adding -L/usr/local/lib to the LDFLAGS comment in face.go got it compiling for me, although I expect that is not the intended workflow.

@jacquesh : thanks, that worked for me, too.

For anyone hitting the same issue, using the following env works without needing to modify any source files.
Here I was building photoview which uses go-face as a dependency:
env CGO_CFLAGS="-I/usr/local/include/" CGO_CXXFLAGS="-I/usr/local/include" CGO_LDFLAGS="-L/usr/local/lib" go build -v -o photoview .

Since FreeBSD installs all extra libraries in /usr/local it would make sense to add the above flags to CGO in go package on FreeBSD by default for better user experience.
I'll check if it's possible and open a PR for the go package.

Thanks for the env line - that just saved me a lot of time!