@conda-forge-admin, please add bot automerge

Additional comment:
@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/defcon-feedstock#2.


TranslationLayer Intellisense

Filled in the gaps in documentation for TranslationLayer code.
Generate xml file and place them in Nuget Packages so as for IntelliSense to work.

Hi @singhsarab, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Sarabjot Singh). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


How to disable Extra Authorization with NFC Share

I am very grateful to Don and contributors for making this plugin. It works beautifully reading tags.
In attempting the nfc.write method on two Android phones (Huawei P20 Pro and Samsung S5 Neo), it seems that the default Android Beam functionnality is kicking in. I am asked on both phones to touch the screen to initiate the transfer. If I do, I am asked to bring the phones back together (with a timeout of only a few seconds).
If I do all this (and it took me a dozen times to get it right), I believe the share works. The receiving phone shows that it received the data as a regular tag. The sending phone, however doesn't show the alert message I have inserted in the successful callback function... weird!
My question is : Is there a way to disable to touch screen additional action to authorize the transfer? The users running my app would already has consented to share data.
Thanks!

"Is there a way to disable to touch screen additional action to authorize the transfer?"
Unfortunately no. Early version of Android would beam without this confirmation and it worked great. Unfortunately share is clunky.


Use fixtures for XPRESS tests, instead of C-style macros

Instead of macros, use fixtures for XPRESS tests.

can you re-create against the main branch ?

can you re-create against the main branch ?

Done


"Updating will not be possible to prevent deleting AppData on Update"

I see the folder structure for Sonarr includes the settings and other files in the "bin" directory, but Radarr seems to use the same directory for most all files.
Any way to change this?

Radarr and sonnar should be installed in different directories.

Yea. And they are. What I mean is Radarr is throwing the "Updating will not be possible..." error, and upon investigating, I noticed all Radarr settings files are in the root Radarr directory (C:\ProgramData\Radarr) while my Sonarr installation has more subfolders, namely for the configuration files, seemingly preventing this error (C:\ProgramData\NZBDrone\Bin).
Is there any way to change the directory of these files in Radarr to remedy this error?

This should be on the Radarr git. Doesn't seem to have anything to do with the script
Sent from my iPhone

On Feb 18, 2017, at 20:19, squeakygreens<EMAIL_ADDRESS>wrote:
Yea. And they are. What I mean is Radarr is throwing the "Updating will not be possible..." error, and upon investigating, I noticed all Radarr settings files are in the root Radarr directory (C:\ProgramData\Radarr) while my Sonarr installation has more subfolders, namely for the configuration files, seemingly preventing this error (C:\ProgramData\NZBDrone\Bin).
Is there any way to change the directory of these files in Radarr to remedy this error?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Yea, my mistake. Not sure how I ended up here hah.


Unable to work under. net standard

The asp.net core package requires netcoreapp due to diagnostic hooks. You should place the AspNetCore package in your web entry points and reference the exceptionless package anywhere else it’s needed. I hope this helps, let us know if you have any other questions.


Html substitution  and RCF standards.

Hi Guys ,
Currently i am using mjml to substitute html in freemarker templates and what tends to happens  the newly created html seem to break the RCF2822/RCF 5322 protocol  where the line of characters should not exceed the limit of 998 characters per line.
Currently I am using postfix and if the line length is longer than the standard  specified in  RCF2822/RCF5322 protocol   then postfix will automatically truncate the lines which then can be at any point in the mail  causing  various errors the main one being  text not displayed  as the html tag itself can get truncated so the closing tag could be cut off. This did happen before  however we had found a solution whereby if we just added the line breaks in the mj-text tags for the column, that was exceeding the limit , that seemed to solve the issue but after  your Version 3.3.0 update that solutions no longer fixes this issue.
Can you guys fix this to adhere to the standard ?

Hi @lrae24
It looks really really specific to me, can you have a template to share that have this limitation ? I think that limit can happen if the HTML is minified... Can you test with non-minified HTML to see if it's ok ?
To be honest it can be fixed with a simple gulp task like this:  compiledMJML.replace(/(.{998})/g,"\n$1") However it can break things if the 998th chars is a tag or something.

@iRyusa  the html I have seems to be minified so how would i change that ?

How do you render your MJML ? With cli/gulp/... ? Thanks !

We use gulp .

From what version you've updated ? I think we didn't change the minify default option from a long time...
Well, gulp-mjml will be updated soon to 2.1.1 and you'll be able to pass extra option like { minify: false } to prevent this behaviour

We upgraded from  3.2.2 to 3.3.0 , and is there no work around or fix that you guys have for this issue ?

I'm a bit surprised that you have some change in minification process from 3.2.X to 3.3.0. It still set to false by default.
So it shouldn't be an issue, can you share your gulp file or something ?
To be honest, I never encountered this issue and neither familiar with Freemarker environment too... You could use something like gulp-html-beautify https://www.npmjs.com/package/gulp-html-beautify that will reindent everything for you, and i think there's a line-length's option too

@iRyusa  i will definitely have a look at that solution and then get back to you if it works  or not  and with further details . However i would like to ask you  , is what was mentioned in this thread  replaced as this indicates that  minify is enable and even if i look at the current file you guys have  on github it still seems like you guys are using minify on the  templates.
https://github.com/mjmlio/gulp-mjml/issues/13.

We're providing a minify option as well as a beautify option that is disabled by default. ( because you have to activate it with with { minify: true/false } as 2nd parameters to the mjml2html function.
Please note that we're using React internally and outputted HTML comes straight from React, so it's probably why the outputted HTML looks minified but in reality it doesn't, it's just how React output it.
We did change something related to how we're parsing MJML input (mostly cleaning stuff to avoid bugs with special characters) so it probably strips out your line breaks, and in result you don't see them in the final output.

@iRyusa thanks will get back to you on this   after checking out the beautify solution with details.

@iRyusa the html beautify plugin works well thanks.

👍


Change buttonColor on handler

Hi, everyone
i want change my button color on handler, but doesn´t change:
(...)
    item.title = "Talvez"
    item.icon = UIImage(named: "neutral")
    item.handler = { item in
        itembuttonColor =  UIColor.gray

    }

(...)
It´s possible to give me some help ?
Thanks for your time.

I'm facing the same issue. Any solution available?

Hello, solution here.
item.handler = { item in
    item.buttonColor = UIColor.green
    item.setNeedsDisplay()
}

still cannot :( using item.setNeedsDisplay()

Better u code like this i think
let fab = KCFloatingActionButton()
let item = KCFloatingActionButtonItem()
item.buttonColor = UIColor.blue
item.title = "Custom item"
item.handler = {item in
self.performSegue(withIdentifier: "segueToAnother", sender: self)
}
fab.addItem(item: item)

I want to change fab.buttonColor and fab.itemButtonColor at the same time.  It will only change buttonColor if fab.setNeedsDisplay(). And I try
fab.items.forEachEnumerated({ (index, item) in
                item.setNeedsDisplay()
            })

, but it does not work.

I try:
fab.items.forEachEnumerated({ (index, item) in
                item.buttonColor = MyColor
                item.setNeedsDisplay()
            })

That's work.

Good :)


mathlib: add Vector3f low pass filter

To be used in drivers.

Nice. Is there any performance gains by doing this or is it just for usability?

TBD, but it's mostly for convenience and not having to duplicate the internal parameters 3 times.

Updated and applied to the MC attitude controller D term LPF for testing.

Added a finite check in reset.


ISPN-11315 Split XSiteAdminCommand into individual commands

https://issues.redhat.com/browse/ISPN-11315

integrated! thanks @ryanemerson !


EP-1056  iOS - Update Security Message from SSL to TLS

update translation for secure_server_transmission key

@AlexeiJovmir missing translations for Spanish and Polish


add NPO_2001 to NPO_2006

added
biopolymer nanoparticle NPO_2001
carbon black nanoparticle NPO_2002
alloy nanoparticle NPO_2003
nanobin NPO_2004
nanolipogel NPO_2005
solubility in organic solvents NPO_2006

@egonw Could you please double check these terms and merge them. Thank you.
More details: https://docs.google.com/spreadsheets/d/1rZOsAID7dBRziOXbqVbgUnNP6TGLDxDI9CTLrFcsVAM/edit?usp=sharing

HI @JKChang2015, I cannot review this, as the whole file is turned upside down :(

Hi @egonw , I think those terms have been successful merged to eNM ontology after Maastricht hackathon in February.  Here is the link to the working spreadsheet:
https://docs.google.com/spreadsheets/d/1rZOsAID7dBRziOXbqVbgUnNP6TGLDxDI9CTLrFcsVAM/edit?usp=sharing

OK, then I'll close this for now. We need a larger merge event anyway, to move stuff from ENM back into NPO.


Can't see containers

Problem/Motivation
When i open Portainer in have one Primary Endpoint. in the description it say that i have 15 (12 active) containers. (that sounds accurate)
When i open the endpoint dashboard i can only see two containers and they are both inactive.
Expected behavior
To be able to see and manage all containers that is installed via Homeassistant
Actual behavior
I can only see the 17 images and two inactive containers and 4 networks. no stacks or volumes vissible.
Steps to reproduce
Don't know if possible
Proposed changes
None

Log
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-banner.sh: executing...

Hass.io Add-on: Portainer
Manage your Docker environment with ease
Add-on version: 0.9.0
You are running the latest version of this add-on.
System: Ubuntu 18.04.3 LTS  (amd64 / qemux86-64)
Home Assistant version: 0.105.5
Supervisor version: 201
Please, share the above information when looking for help
or support in, e.g., GitHub, forums or the Discord chat.
[cont-init.d] 00-banner.sh: exited 0.
[cont-init.d] 01-log-level.sh: executing...
[cont-init.d] 01-log-level.sh: exited 0.
[cont-init.d] nginx.sh: executing...
[cont-init.d] nginx.sh: exited 0.
[cont-init.d] portainer.sh: executing...
[cont-init.d] portainer.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[15:12:38] INFO: Starting Portainer...
[services.d] done.
2020/02/25 15:12:39 Templates already registered inside the database. Skipping template import.
2020/02/25 15:12:39 Instance already has defined endpoints. Skipping the endpoint defined via CLI.
2020/02/25 15:12:39 server: Reverse tunnelling enabled
2020/02/25 15:12:39 server: Fingerprint XXXXXXXXXXXXXXXXXXXXXXX
2020/02/25 15:12:39 server: Listening on <IP_ADDRESS>:8000...
2020/02/25 15:12:39 Starting Portainer 1.23.0 on <IP_ADDRESS>:9000
2020/02/25 15:12:39 [DEBUG] [chisel, monitoring] [check_interval_seconds: 10.000000] [message: starting tunnel management process]
[15:12:39] INFO: Starting NGinx...
nginx: [alert] detected a LuaJIT version which is not OpenResty's; many optimizations will be disabled and performance will be compromised (see https://github.com/openresty/luajit2 for OpenResty's LuaJIT or, even better, consider using the OpenResty releases from https://openresty.org/en/download.html)

Try the manual: https://github.com/hassio-addons/addon-portainer#known-issues-and-limitations


chore: Add support for enabling Azure Bastion on an aks-engine cluster

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds both an independent script and to support to hack/azure-cluster-up.sh for enabling Azure Bastion on an aks-engine based cluster.
Which issue(s) this PR fixes:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
For security reasons, aks-engine cluster nodes are not exposed to the Internet. Azure Bastion provides a secure means to access the cluster nodes via SSH or RDP directly through Azure Portal.
When creating a new cluster using the hack/azure-cluster-up.sh script, specify the --enable-bastion option to automatically configure Bastion for the cluster. For existing clusters or cluster created without the --enable-bastion option, you can run the hack/enable-azure-bastion.sh script to configure Bastion. The usage of the script is:
$ hack/enable-azure-bastion.sh --help
enable-azure-bastion.sh: Enables Azure Bastion on a cluster created using
  azure-cluster-up.sh.

Options:
  -l, --location       [Required] : The region.
  -r, --resource-group [Required] : The resource group name.
  -s, --subscription   [Required] : The subscription identifier.
  -n, --name           [Required] : The Kubernetes cluster DNS name.

In order to use SSH or RDP access, you will need the azureuser SSH private key or password, respectively. These are contained in the id_azureuser and id_azureuser.pwd files in the output directory used by the hack/azure-cluster-up.sh script.
Release note:
none

Pull Request Test Coverage Report for Build 726840764

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.105%

Totals

Change from base Build 724840648:
0.0%

Covered Lines:
2180

Relevant Lines:
2982

💛  - Coveralls


Random fixes

Coverage decreased (-21.5%) to 76.687% when pulling 3e9c4d23a3994ff2e55af2a8f839df1265ed0129 on davidbegin:random-fixes into 234abadbfb14ed2753973bc0600cafe0c67b3941 on danascheider:master.

Go ahead and make my project look bad why dontcha!! :stuck_out_tongue:


Address dependabot alert.

Updated: Bump testcontainers runc library version.

Question: Are we running with the current release for Unit Test?


Migration from _asm.undocumented.spaces to hs._asm.spaces

The _asm.undocumented.spaces repository states:

This module has been superseded by https://github.com/asmagill/hs._asm.spaces and is no longer being maintained.

Can you please confirm whether hs._asm.spaces would work in place of this dependency? And if it does not, how heavy of a lift do you think it would be to migrate?
Thanks!

From a quick glance, it doesn't look like it's a plug-and-play replacement. I don't think I'll have the time in the near future to spend time on this, but I'm happy to accept PRs.

Thanks for taking a look. As I play with hhtwm I'll explore the option of migrating. Take care!

PR #13 is my attempt at this migration.

@cmpadden Why did you close PR #13 ? It seems to work for me, but I've only begun setting up hhtwm

@cmpadden Why did you close PR #13 ? It seems to work for me, but I've only begun setting up hhtwm

Apologies, I ended up closing it as I am no longer using hhtwm. You're welcome to take ownership of those changes if you find it useful!


Ability to query the maximized state of a window

There are currently functions for creating a window maximized and to maximize an existing window, but there is no way to query if a window is maximized or not. We're having issues with saving the previous window resolution when our game exits and restoring it the next time the game starts, as we currently don't know if the user maximized the window or not.
Also: http://www.glfw.org/docs/latest/window.html does not list the maximization functionality.

Use the window attribute.
GLFW 3.2 has not been released yet and so is not the latest release.

I see I forgot to add an error section for glfwMaximizeWindow. Thank you for making me take another look at the documentation!

Ah, seems like I jumped the gun a bit early there. xd Thanks for the info!


Remove use of Exception.message for py3 compatibility. Closes #36

The DeprecationWarning from #36 is actually problematic, since Python 3 has removed the "message" attribute of Exceptions. The fix from #42 masked this Python 3 incompatibility by just catching an overly broad Exception base class. This PR replaces the use of .message with .args[0] as seen in http://stackoverflow.com/questions/1272138/baseexception-message-deprecated-in-python-2-6.

Codecov Report

Merging #86 into master will decrease coverage by 0.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   95.26%   94.92%   -0.34%
==========================================
  Files           3        3
  Lines         591      591
==========================================
- Hits          563      561       -2
- Misses         28       30       +2

Impacted Files
Coverage Δ

signxml/__init__.py
94.66% <100%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad3353...a24feaa. Read the comment docs.

LGTM


test $EMACS directly rather than using "which"

Fixes #33

r? @huonw
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks!


test: ☑  add systems unit tests

Description
Add systems unit tests
Type of change

[X] Testing

How Has This Been Tested?

[X] New and existing Catch2 unit tests run and passed

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd4909c) 64.18% compared to head (4d7ced2) 69.40%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   64.18%   69.40%   +5.21%
==========================================
  Files           7        7
  Lines         296      317      +21
  Branches       54       54
==========================================
+ Hits          190      220      +30
+ Misses        106       97       -9

Files
Coverage Δ

Catch_tests/components/rectangle.cpp
100.00% <ø> (ø)

Catch_tests/entities/ball.cpp
100.00% <ø> (ø)

Catch_tests/entities/bricks.cpp
100.00% <ø> (ø)

Catch_tests/systems.cpp
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


cast as size_t for cpp api, cast u64 for rust api

#4

Thanks! May I ask which underlying change causes this issue?

I'm trying to compile this module on windows, with toolchain=nightly-2021-11-25-x86_64-pc-windows-msvc
size_t may be different, the error shows that size_t is u32 and u32 is not u64(#4)

Got it. I didn't test it on the x86 arch. This makes sense.


Druid web console in in 'No SQL mode'

We have druid 0.22.1 deployed in on premise kubernetes cluster which works perfect. But deploying the same image to IT namespace results in druid router console running in 'No SQL mode'. Both environments use same configuration with difference only in names, metadata db and pvc mountpoints. I see no error in any of pod logs. Could I get some guidance.

This can happen if the management proxy is not enabled in the router https://druid.apache.org/docs/latest/design/router.html#router-as-management-proxy
In Druid 24.0 there is a way to force the console to un-restrict.

Also there was a bug fixed in 24.0 that would have too short of a timeout on the capability detection. It should be a lot more robust now. Please reopen if you see this again.


Add Flatbox Rev5 RGB

Test build: https://github.com/OpenStickCommunity/GP2040-CE/suites/14155123588/artifacts/793075178

I assume this works fine for v2 and the user will just need to set LEDs per button to 2?

That's correct.  Rev1 would also need the PLED numbers changed on it.
V1 is depreciated now so I'm fine just hosting v2.

@TheTrainGoes OK makes sense. Updated to 2 LEDs per button, PLED pins are 12-15, is that right?

PLED pins are 24, 25, 26 and 27

Correction - LED # not PIN number.


lilypond-with-fonts: fix quoting

Motivation for this change
It looks like the wrapper script changed its quoting at some point, which broke lilypond-with-fonts. This commit fixes it. I'd love to have tests for this going forward, but I'm not sure how best to approach writing them. Manually, I can check as follows.
Assuming:
{
  my-lilypond = lilypond-with-fonts.override {
    fonts = with openlilylib-fonts; [ improviso ];
  };
}

The output of:
 lilypond -dshow-available-fonts

... should include several lines that start with:

family improviso

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/ping @Mic92


Implement notification service to api interceptor

Create api interceptor to add notification side effects
Skip authorization requests
DELTE Successfully

Handle error


update example to use local db

this example is connecting to a remote database; if users download it, they won't be able to run it; so we should update it to use local data.
we can use the same data as here: https://jupysql.readthedocs.io/en/latest/compose.html

looks like the build is failing:  https://readthedocs.org/projects/jupysql/builds/18184333/

I've opened an issue for failing builds. ( #11 )


DO NOT MERGE: Sprint Progress

TODO:

[ ] Add co-authors

Please complete the following checklist:

[ ] I have read the guidelines in CONTRIBUTING.md.

[ ] I have documented all public-facing changes in CHANGELOG.md.

[ ] This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the licenses directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied. It is your responsibility to disclose code, documentation, or other content derived from external source(s). If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.

[ ] This pull request does not include code, documentation, or other content derived from external source(s).

Note: REVIEWING.md may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.

Superseded by https://github.com/biocore/scikit-bio/pull/1618/


fix(quote): Load Plex Serif font into Storybook previews

Related Ticket(s)
Resolves https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/5434
Description
Previous to this PR, the serif versions of the Plex font were not loaded in Storybook component <iframe>s. This forced any component that was supposed to use them, including quote components, to use fallback fonts instead.
Now that we're loading the correct font, all quote fonts should appear identically in all browsers. I personally tested the latest versions of Chrome, Firefox, and Safari on macOS 11.4 (Big Sur).
Screenshots
Quote

Before:

After:

Callout Quote

Before:

After:

Changelog
New

IBM Plex Serif fonts are loaded in Storybook component iframes.

Changed

Plex fonts loaded in Storybook component iframes are pulled from the @carbon/type package instead of carbon-components.

@jkaeser Did the serif font load from the CDN when we tested in codepen yesterday? If not @jeffchew should the CDN package be modified to include the serif font for the quote component?


epic: cortex run vs cortex pull UX for Cortex Model Repos

Goal

cortex run <model> should have a default option (vs. overwhelming users with choice)
We can present a "menu" to the user, but also allow for default/recommended selection

Out-of-scope:

cortex pull and cortex run for Huggingface Model Repos

Path
As per @namchuai's suggestion, we will have differentiate between cortex run and cortex pull: https://github.com/janhq/cortex.cpp/issues/1401#issuecomment-2391103806
cortex pull

cortex pull is optimized for pulling models, and shows full list of available downloads
We should optimize for showing the list of available downloads, with default at the top
We should make the default selection for the user (i.e. they just press enter again)
[ ] Research CLIs to find an example of CLI UX with default selection

> cortex pull tinyllama

Default (press enter to select)
    1. 8b-gguf

Available to download:
    2. 8b-gguf-q4-km
    3. ...
    4. ...

Your selection (default: 1):

cortex run tinyllama

cortex run is optimized for running local models

Case 1: If no models detected

We display the pull menu (similar to the above)

Case 2: 1 local model detected

We automatically run the local model that has been downloaded, that is part of that model family

Case 3:

We show a "menu" with list of local models, for user to select

> cortex run tinyllama

Local Models: (press enter to select)
    1. 8b-gguf-q2
    2. 8b-gguf-q4_km

Your selection (default: 1): 1

Tasklist

[ ] cortex pull/run <model> should have a "menu"

Better indentation for readability
Different sections (i.e. default, available to download)

@0xSage Please note: current Huggingface Cortex models do not have a metadata.yaml. We deprecated it for having a model in main branch.

@namchuai Please give us an hour to finalize the structure of metadata.yaml. The one in Mistral is not correct.

@dan-homebrew , let me clarify this a little bit. So, when user enter, for example cortex run llama3, we need to get metadata.yaml in main branch to get the default branch (default model) to download from?

Immediate Goal: metadata.yaml to specify a default branch to download - without hardware detection for v1.0.0

Read metadata.yaml in main branch - default
List other branches - available to download

Example: llama3.2
metadata.yaml
version: 1
default: 3b-gguf-q4-km

CLI
> cortex run llama3.2
Default (press enter to select)
    1. 3b-gguf-q4-km

Available to download:
    2. 3b-gguf-q2-k
    3. 3b-gguf-q3-kl
    4. 3b-gguf-q3-km
    5. 3b-gguf-q3-ks
    6. 3b-gguf-q4-ks
    7. 3b-gguf-q5-km
    8. 3b-gguf-q5-ks
    9. 3b-gguf-q6-k
    10. 3b-gguf-q8-0

Implementation:

[ ] Need cortex team's suggestions on default branch for 80% of users hardware
[ ] Add metadata.yaml to cortexso model repos - Gab

Future
metadata.yaml can be customised the listing of different configurations eg 3b, 11b (spec-ed out in future)

I think we should change the command behavior a little bit.

cortex run, basically, user's intention is to chat with a model. For example, cortex run llama3, we can query locally and if we found any llama3 ready (any quant), we use it. If user don't have llama3, we download from main
cortex pull user's intention is to download models. We should display selections. Display what they already have and what they don't locally.

Based on discussion over Discord.

@dan-homebrew, I think separate the default into another section will add complexity. I think we can just indicate as below. Please let me know your idea.

Thank you @James!


KAFKA-16203: Fix bug on auto-commit empty offsets blocking inflight

Fixes a bug with the auto-commit logic. When auto-committing empty offsets, the operation completes without generating a request, but mistakenly leaves the inflight request flag on. This makes that following auto-commits won't generate requests, even if offsets have been consumed.

@dajac could you please add the kip-848 label when you have a chance to take a look at this? Thanks for reporting it!


Update install cmd to not specifiy release version

Thought it would be better for the readme to not have to be constantly updated when ever a new release is created.

I've updated the plugin to work with Kubernetes 1.12 and krew


Initial implementation of adjustsFontSizeToFit.

It had been way too long to fix it up myself, so I've reopened the PR. Here's the original. https://github.com/facebook/react-native/pull/2327

This should be stable enough to merge now.

Keeping this squashed on master led to a missed file. Corrected.

@nicklockwood, @sahrens, @a2 Correct me if I'm wrong, but the tests failing after my last commit/squash are not due to my code changes, correct?

Cool :)

Did something go wrong with the merge/rebase?
The adjustsFontSizeToFit and minimumFontScale are defined on both RCTText and RCTShadowText, but the ones on RCTShadowText aren't used anywhere in the code, and the ones on RCTText aren't exported in RCTTextManager.
Also, you don't seem to have added the new props to Text.js or TextStylePropTypes.js

I think that's just misunderstanding on my part, and the age of this PR. Let me remove them from RCTShadowText.
I was assuming that RCTTextManager just needed the two RCT_EXPORT_SHADOW_PROPERTY lines it has, is that not correct? Give me a bit and I will add them to Text.js and TextStylePropTypes.js.

RCT_EXPORT_SHADOW_PROPERTY exports properties on the shadow view. To export properties on the view you need RCT_EXPORT_VIEW_PROPERTY. I'm not sure how this could ever have worked in its current form.

Miracle of science I suppose.

Are you sure that RCT_EXPORT_VIEW_PROPERTY is correct in this instance? It's not used once inside the entire RCTText project?

You know, I think I see part of what's missing. RCTText must be an odd case. From what I can tell, all properties of RCTText are exported as shadow properties, and then passed into RCTText from RCTShadowText via NSTextContainer, NSTextStorage, and NSLayoutManager. That being said, there were a few lines in RCTShadowText that have been squashed out. Updating now.

What can you make you more confortable when you are at your page

Github spam. That's a new one.

@MattFoley thanks, that makes more sense. Is there any reason that this resizing logic can't be implemented on the shadow view though? It seems like it only relies on the view frame, which is calculated on the shadow side.
The reason we have this thread architecture is because calculating text layout is fairly expensive, so we do it off the main thread. But it seems like we lose the benefit of that if we then re-calculate it on the main thread in order to do the size adjustment.

That makes sense. I think I'm mainly doing it on the main thread now so that I knew the font was only modified after the frame was completely set for the view. I'm trying to move it out to the RCTextShadowView now without much luck yet.

Ah, immediately after typing that I figured out what I was doing wrong. Give me a bit and I'll have this cleaned up and moved out to RCTShadowText.

This looks great, thanks!
@facebook-github-bot import

I'm going to run some more in depth tests on this @nicklockwood with some of my own projects that are using this, just to make sure everything is solid on master. But yay! :tada:

It would be great if you could add an example to the TextExample.hs in UIExplorer that demos the feature.

Yeah, I will, may be a few days. After these changes, I'm having trouble running against this with some of my older projects using this stuff, so I'd like to take a little while to make sure this is working the way it should. (Probably has something to do with my build environment.) Wait on this PR until there's a working example?

:+1:  hope to see this feature soon.  Great work!

I cherry-picked this and have been using it in my app. Pretty great! The only thing is I wish it would append '...' if your minimumFontScale was not small enough to fit the whole string. Think that could be accomplished?

@MattFoley hmmm, I'm running into some issues with this today. It appears that text isn't always re-rendering.
I'm logging a variable name in my render method, and using it inside a <Text> component. On the initial render, name is an empty string, but eventually new props come in and it becomes a valid string. Re-render is triggered (I see name logged correctly), but the <Text> remains blank.
Any idea what could be going on?

@MattFoley just wanted to ping on this...any news on this PR?

Still haven't had time to build an example for this. @marcshilling Were you able to fix the issues you found with this? or for the ...? I haven't had a chance to look into either yet.

@MattFoley I have not. The ellipses thing is more of a nice to have feature, but the text not re-rendering is definitely a bug that needs to be fixed. I wouldn't really know where to start...but if it would help I could try to put together an example project that displays it breaking?

That would definitely be appreciated! :)

@MattFoley here ya go: https://github.com/marcshilling/react-native-auto-sizing-font-bug
Pull that down, npm install. Give it a shot. Note that on a 1 sec delay in componentDidMount I set state to change the text and its color. The text never re-renders.
I hope this helps you figure it out and get this fixed!

This has been imported to the internal Phabricator but not merged yet.
Sorry about the churn @MattFoley, can you try to rebase it please? @nicklockwood do we want to merge this as-is?

@mkonicek still working on it. Pieter had some review feedback.

:+1:

Going to try really really hard to wrap this up this week

I think @nicklockwood is still working on it? You might want to wait for an update.

I've had some requests to make changes to this, I'm going to work on getting those into this PR this week, is what I meant. Is @nicklockwood doing work on top of this as well?

@marcshilling I saw something tonight that suggests the re-render issue may not be with my code. I'm sorry I haven't had a chance to look into this more yet, but I noticed it tonight while I was building two separate countdowns labels for different screens in an upcoming release.
I was working on iOS 9.2 simulator, with RN 0.18 (with my PR applied on top), Node 5.4. The text nodes were not being re-rendered as I updated the countdown text in my state. I confirmed that the render functions were being called, and the string was changing. Once I set the key of my node to the string I wanted to render it begin redrawing each time. Is it possible that something is being too aggressive on caching DOM elements in the newer versions of RN?
Again, I'll try to come back to this PR soon, but all my focus is going into current work project at Skillz.

I have a small problem with this, and actually need to fix it elsewhere as well. If I do my resizing on the native/ObjC side, how do I notify RN that the view's size has changed, and that it then needs to relayout the rest of the view? This is a small problem for this PR, but I'm also working on a wrapper for THLabel, and currently it requires a fixed width or RN just lays it out as 0 width.

cc @nicklockwood

I was hoping there was some way to communicate directly to the ui manager, rather than firing an event, and setting style value manually.

You can call [bridge.uiManager setFrame:forView:] to trigger a layout update. That will automatically call onLayout on the JS side, etc.

Thanks Nick!

@MattFoley let me know if that works and hopefully we can get this merged soon!

@MattFoley any updates here? Been waiting on this to land for soooooo long

@MattFoley I'm going through all PRs to make sure they are either being worked on or closed. Closing all PRs after a month of inactivity, leaving this one open since it's been 20 days.

Let's please not let this one get closed! Lot of work done here and this is still a huge missing piece of React Native `Text

@MattFoley do you have any updates for this pull request? It's been a while so we wanted to check in and see if you've looked at the requested changes.

OK sounds good :+1:

@nicklockwood would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@MattFoley Do you have a laundry list of what needs to happen to finish this up? I cherry picked it and started playing around with it. Would love to help tackle some outstanding tasks to get some momentum back to this feature. Definitely a must have!

@duhduhdan check out my comment above. That repo probably isn't a good example anymore since it's 5 months old, but the JS-side of the code illustrates what the issue was at the time (text not re-rendering). Maybe things have changed? But that was the only issue I was seeing back in the day.

@marcshilling Awesome, thanks. I'll start applying some brain power to this

@duhduhdan I've been waiting for someone to ask me that exact question! Part of the reason this has lasted so long is that I didn't feel comfortable finishing this without another outside developer giving it concrete use. The PR here is slightly out of date, but the feature itself is not, we are using it in production here at Skillz and will continue to do so.
You can see an example of our usage in production here.
Here's my todo list here:
• Find another developer to actually use it, get feedback on the API/functionality.
• Default adjustsFontSizeToFit to true, rather than false as it is right now?
• Fix the text re-rendering issue (for now we just use the key prop to workaround that issue)
• Add "..." truncation when the minimum text scale can't be reached
• Possibly improve binary search, still feels a bit weird for multi-line auto-shrinking.
• Android support? (We're iOS developers here.)

@MattFoley Perfect! Thanks for the list. Excited to see this moving forward again!

Also good to know is that right now when the text shrinks, the frame of the Text node does not, so you can see some strangeness related to text sizing. Haven't figured out a great solution for this yet.

Another thing, and this is probably not a big issue for most developers on React Native, but due what seems to be an ancient issue with NSLayoutManager dating all the way back to OSX, Japanese text is drawn a a bit above the baseline.
You can see how I use usedRectForTextContainer in calculateSize in RCTShadowText.

@MattFoley updated the pull request.

@nicklockwood would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@MattFoley updated the pull request.

@nicklockwood would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@MattFoley updated the pull request.

@nicklockwood would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

Hi! Just pinging this to see how this is moving forward?

@Hagbarth Working on adding a UIExplorer example today, and fix the dynamic text element issue. If I manage to implement both of those today, I'm going to recommend this be merged without the ... truncation feature.

I've added a UIExplorer demo to this, and updated it so that the frame of the Text element ends up being drawn at the exact size required (no leftover space after being shrunk).
There is still one minor issue, if an element is shrunk by adding text to it, and then that text is removed, the height of the element will not grow back to it's original height, which leads to the font being stuck at a certain size, or number of lines being lessened.
However, that seems like an edge case, and it turns out that the re-render issue mentioned by @marcshilling is no longer a problem on the latest React Native, so I'm going to suggest this finally be merged in. We're still using it in production just fine.
@ide @nicklockwood @mkonicek I have no idea who's in charge of this now! Sorry it has taken so long!

I think I caught everything mentioned by eslint-bot, please let me know if I missed something else.

Rebased on top of master again this morning, so this is once again ready to be merged! :)

@majak would you mind taking a look please? Just trying to triage impactful PRs, splitting iOS ones between you and Pieter.

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @rigdern as a potential reviewer. Could you take a look please or cc someone with more context?

I'm on Discord as teejayF#8027, please feel free to reach out to me there. I'd like to get this merged in as soon as possible! Thanks! :)

Still waiting on a review here @majak @mkonicek @rigdern.

Hi guys! Could I somehow to use it before it`s merged? I really need this feature to use right now =)

Hi, just another friendly reminder that this still needs a review. @majak Thanks!

@MattFoley updated the pull request.

@MattFoley updated the pull request.

@MattFoley updated the pull request.

I've rebased this on top of the latest master. The failure in continuous-integration/travis-ci/pr doesn't seem to be related to this PR.

@marcshilling Looks like you've been reviewing and merging in ObjC PRs. Feel good about merging this one in? I've just been bumping this PR and rebasing since June, it feels good to merge to me.

@MattFoley not me - I don't have merge permissions! I would if I could!

@marcshilling Thanks Marc, is there anyone else I can poke about this?

@MattFoley updated the pull request.

Just cleaning up what I think the last thing ESLint bot was complaining about.

Rebased on top of master again.

@mkonicek @majak I hate to keep pinging you guys on this, but I'd really like to get this merged in before I do another RN update. Is there anything I can do to help move this along? Thanks!

@MattFoley updated the pull request.

@MattFoley updated the pull request.

Note, I had to update this PR to fix a failing test due to a previous rebase.

cc: @majak @javache

@facebook-github-bot shipit

@MattFoley thank you SO much for sticking with this for so long. Sorry it took so long to get it merged!

Thanks for importing.If you are an FB employee go to Phabricator to review internal test results.

@skevy @MattFoley 👏👏👏👏

@skevy Thanks!!!!!!!!!!!!!!!!!!!!!!!!
ps. @brentvatne it happened. 🎉

👏👏👏

@MattFoley so, is this available in<EMAIL_ADDRESS>or no? Thanks so much for this!

It's in .33rc I think, you're welcome!
Sent from my iPhone

On Sep 2, 2016, at 7:58 AM, Chandler Van De Water<EMAIL_ADDRESS>wrote:
@MattFoley so, is this available in<EMAIL_ADDRESS>or no? Thanks so much for this!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Text gets truncated a little bit (maybe because of large font?). Easily solved by adding style={{marginVertical: 6}} tho.

can adjustsFontSizeToFit work with TextInput? On the user input

You can add adjustsFontSizeToFit={true} (currently undocumented) to you Text Component to auto adjust the size inside a parent node.
  <Text adjustsFontSizeToFit={true} numberOfLines={1}>Hiiiz</Text>

You can also add the following in your Text Component:
<Text style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>

Or you can add the following into the parent of the Text component:
<View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text>Hiiiz</Text>
</View>

or both
 <View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>
</View>

or all three
 <View style={{flex:1,justifyContent: "center",alignItems: "center"}}>
     <Text adjustsFontSizeToFit={true}
           numberOfLines={1}
           style={{textAlignVertical: "center",textAlign: "center",}}>Hiiiz</Text>
</View>

before

after

It all depends on what you're doing. You can also checkout my full blog post on the topic
https://medium.com/@vygaio/how-to-auto-adjust-text-font-size-to-fit-into-a-nodes-width-in-react-native-9f7d1d68305b

it does not work for Android in react 47.1 and does not work perfectly for IOS

Does this work for Android? It works for me for IOS but need Android support as well.

I should be doable for android https://react-native.canny.io/feature-requests/p/textandroid-autosizing-support. But I failed to implement it maybe someone more experienced with react-native can do it.

Would be great to get this on Android too!

We desperately need this on Android

I see this is closed, was it merged in?


dataSlayer is not recording GA hits sent with POST

e.g. I load a page and Network tab shows 3 pageviews (tagging is in development!!!)
If GA sends all 3 hits using GET, all 3 are reported
If one is sent with POST and 2 using GET, only the GET pageviews are reported by dataSlayer
The Network tab reports all 3
In the attached image, the 3 pageviews report via a GET and the event by POST and the latter is the one that dataSlayer is not reporting.
It does not appear to relate to the size of the request because I had bloated the request previously to force all hits to send via POST. Strangely, dataSlayer reported all those hits
dataSlayer is showing all the dataLayer updates that trigger the hits whether it reports them or not.
I un-/reinstalled dataSlayer to ensure I had the latest version - made no difference
Google Chrome is up to date
Version 87.0.4280.66 (Official Build) (64-bit)
Running Windows 10

Seems like GA is using a new, slightly different endpoint that dataslayer wasn't catching - I've identified a fix and will be releasing ASAP. Thanks for flagging

This should be resolved in version 1.3.7 released to the Chrome store today and releasing to Firefox store shortly.


Return field name for semantic (Category::Data) errors

It would be very useful to have access to the field name in which a semantic (Category::Data) error occurred. For example, the structure:
#[derive(Deserialize)]
struct MyData {
    number: u8,
}

applied to the data:
{ "number": -1 }

gives a somewhat unhelpful error message Error("invalid value: integer -1, expected u8", line: 1, column: 14) [playground].
This is especially problematic because the given column is the column of the actual value in question, not the beginning of the field name, so fairly complex logic is needed to "rewind" to the field name. Especially in contexts where confidentiality is important, it would be useful to be able to know the name of the field for which type validation failed without looking at the data myself.
Would it be desirable to add a method field(&self) -> Option<&str> for Errors of Category::Data? If so, I'll put together a PR.

Right now you can already use serde_path_to_error to extract which field caused the error.  As a benefit it works right now and with any data format (also toml etc.).

This looks like a neat workaround, thank you!

Right now you can already use serde_path_to_error to extract which field caused the error. As a benefit it works right now and with any data format (also toml etc.).

Thank you for mentioning this, it made my day.  Lack of a "verbose error mode" (like serde_path_to_error provides) for --debug builds had been driving me crazy until now.
Could you please consider mentioning the serde_path_to_error crate in the serde_json crate documentation or the introduction at https://serde.rs/?  I bet most new users want to be able to use this feature.  I understand why it is in a separate crate, but that makes it hard to discover.
Thanks again!

Ah it's related to my question #759
But is there a way @jonasbb to avoid having to implement a custom deserializer for each of the types ?

@Roms1383 Sorry, I cannot help. I don't understand what you are implementing.

@jonasbb so actually it's like having a query parameter order_by that can be only asc or desc and getting more details during deserialization failure, but I guess I misunderstood the fact that it's more related to validation than deserialization.


docs?

Any documentation or example anywhere?

See https://adventure.docs.kyori.net/index.html.

https://github.com/KyoriPowered/indra/wiki

Yes, saw that. I want to publish to Sonatype, so I clicked through:
https://github.com/KyoriPowered/indra/wiki/indra-publishing-sonatype


Update FadeInImage to use new Image APIs

Description
This updates FadeInImage to use the new Image.frameBuilder
API (added in https://github.com/flutter/flutter/pull/33369), to greatly
simplify the implementation of FadeInImage.
This also removes the FadeInImage.placeholderSemanticLabel property.
This property was added in #28799 for the sake of completeness (the bug
it fixed was the lack of any semantic label support in FadeInImage), but a
placeholder is a transient visual artifact, not something that affects the
underlying semantic meaning of the image.
Related Issues

https://github.com/flutter/flutter/issues/32374
https://github.com/flutter/flutter/issues/33480

Tests
I added full test coverage of the two new properties (verified in merged lcov.info).  Due to the fact that the implementation of FadeInImage was completely rewritten, I replaced the existing tests with new tests that verify that FadeInImage:

animates an uncached image
handles updating the placeholder image
re-fades in the image when the target image is updated
doesn't interrupt in-progress animation when animation values are updated
Semantics:

only one Semantics node appears within FadeInImage
is excluded if excludeFromSemantics is true
label

defaults to image label
is empty without any specified semantics labels

Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change -- https://groups.google.com/forum/#!topic/flutter-announce/inURQEHtKWM
[ ] No, this is not a breaking change.

@Hixie I significantly re-worked this class.  In the process, I got rid of two instance variables:

skipFadeOnSynchronousLoad (was proposed new instance variable).  I decided not to increase the API surface of the class until a real use case warrants it.
placeholderSemanticLabel.  This property makes no sense - a placeholder is a transient visual artifact, not something that affects the underlying semantic meaning of the image.  A quick code search turned up no usages of this property.

PTAL.

Ok, this has been rebased off of https://github.com/flutter/flutter/commit/68841469251acdb1152957745fe1cb610de62c93.  I've updated the PR description to account for the breaking change.
PTAL.

FYI, waiting for LGTM on this.
I also submitted https://github.com/flutter/flutter/pull/33674 for review to address the documentation in ImplicitlyAnimatedWidgetState


WIP - feat: Add codecov to CI/CD and update coverage in README.md

Description
Describe the purpose of this pull request.
Related Issues
Closes #26
Checklist

[ ] I have tested this code.
[ ] I have reviewed the code changes.
[ ] I have updated the documentation.
[ ] This PR follows the coding standards.
[ ] I have added tests for the changes.

Hey @aswath-s-tw this is still a draft PR but can you approve the workflow so I can test?

Can you add this markdown as badge in README.md?

Can you add this markdown as badge in README.md?
[![codecov](https://codecov.io/gh/gopher-utils/go-collections/graph/badge.svg?token=Z6SU2GOHDI)](https://codecov.io/gh/gopher-utils/go-collections)

Done! This is ready

Hey @adarsh-a-tw can you check this PR again?

Looks like I can't merge the PR, feel free to merge it!

@JoseAngel1196 Thanks for your contribution!


d.ts type definition error

⬆ the type of t4.a should be a number type, not never.

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

What would be the correct way to fix the type definition? https://github.com/TehShrike/deepmerge/blob/master/index.d.ts#L1-L2

https://github.com/TehShrike/deepmerge/pull/181 here

@TehShrike any plans to merge the PR?

Sorry for not looking in for a while – any other TS folks want to give this a review?  @teppeis @RebeccaStevens @s-edlund

I can probably give it a review a bit later today

Sorry I took a bit longer to do this than I said I would but I just reviewed it. It's good but I found some issue with it; I've commented them there.


[stable/jenkins] Properly handle overwrite config for additional configs

What this PR does / why we need it:

Additional configs are only copied (overwritten) to Jenkins home when .Values.master.overwriteConfig is false. This PR updates the template to always overwrite additional configs when .Values.master.overwriteConfig is true and only copy the first time when .Values.master.overwriteConfig is false.
.Values.master.healthProbesLivenessTimeout and .Values.master.healthProbesReadinessTimeout are rendered as the respective initial delays. Refactored the healthProbes section

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

@maorfr Any thought about how the probes are configured? Are there any best practices how it's done in other charts?
As the change is incompatible to the existing values should we add a warning or support both?

i found this:
https://helm.sh/docs/chart_best_practices/#flat-or-nested-values
and in general, it feels like there are 2 separate PRs here. :)

i found this:
https://helm.sh/docs/chart_best_practices/#flat-or-nested-values
and in general, it feels like there are 2 separate PRs here. :)

Thanks @maorfr I used the nested structure here because we have the same set of attributes for liveness and readiness checks, and nesting makes it more clear which belongs where.
I however do not have strong opinions about this, I can switch to a flat structure if you prefer that.
I'll extract changes related to overwriteConfig to another PR

but the title of this PR is Properly handle overwrite config for additional configs. maybe go the other way around?

but the title of this PR is Properly handle overwrite config for additional configs. maybe go the other way around?

Correct, thanks. I've updated the title and description.
#13915 is the PR for the overwriteConfig changes

Do you see a way of making you suggested changes while staying compatible to the existing chart? I'd prefer not to increase the major version for a change like this.

i couldn't agree more with @torstenwalter.

Do you see a way of making you suggested changes while staying compatible to the existing chart? I'd prefer not to increase the major version for a change like this.

@torstenwalter @maorfr done

/lgtm

@startnow65 Thank you for your contribution!


Remove enemy entities and unit damage

Adds the enemy unit, spawner, and turret types to the entities to be removed and adds dummies for those entity types. The category was already renamed to "Units" and given a new icon in e29ff57. The "compilatron" unit is added to the default exceptions list.
Compilatron has a "damage" stat so there's a new list PacifistMod.units_to_disarm of units whose attack_parameters.ammo_type.action should be set to nil to get rid of that. That could possibly be handled differently, but I figured an explicit list of units to modify would be less likely to break mods (although all units added by mods will be removed anyway). Not sure what mods exist that actually add units that aren't enemies.
Together with #58, this should fix #56.

This makes enabling enemies on map gen not do anything, so the wording about that should probably be changed. Or possibly the "Pacifist default" can just be removed entirely (and pollution disabled for the default settings)?


request: add support for class method mocks

Background:
WE use OpenAPI generator to generate the network code to interact with our REST API. The code that is generated use class methods.
Unfortunately, sourcery stubs that is generated for this won't work as it creates instance methods and variable on the mock. So we get compile errors
The workaround I have adopted is to:

ask sourcery to generate the stub
copy and paste it in a different file
edit the mock to include only static function and variable

It would be great if sourcery could somehow detect the use of class method vs instance method and generate the appropriate mock.
Details
ie:
Class generated by OpenAPI generator
open class AggregatedOrdersAPI {

    /**
     Adds an order to an Update an aggregated order.  Requires that the UpdateToken matches the current update token. Update token will be updated for each update.

     - parameter aggregatedOrderAddOrderRequest: (body)
     - parameter apiResponseQueue: The queue on which api response is dispatched.
     - parameter completion: completion handler to receive the data and the error objects
     */
    @discardableResult
    open class func aggregatedOrdersAddOrderAsync(aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue = InternalRestServiceAPI.apiResponseQueue, completion: @escaping ((_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void)) -> RequestTask {
        return ...
    }
}

If I create the protocol for this:
protocol AggregatedOrdersAPIProtocol {
    static func aggregatedOrdersAddOrderAsync(
        aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest,
        apiResponseQueue: DispatchQueue,
        completion: @escaping ((_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void)
    ) -> RequestTask
}

and ask sourcery to create the stub for it, it generates (notes the instance method and function :
class AggregatedOrdersAPIProtocolMock: AggregatedOrdersAPIProtocol {

    //MARK: - aggregatedOrdersAddOrderAsync

    var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount = 0
    var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCalled: Bool {
        return aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount > 0
    }
    var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedArguments: (aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue, completion: (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void)?
    var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedInvocations: [(aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue, completion: (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void)] = []
    var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReturnValue: RequestTask!
    var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure: ((XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, DispatchQueue, @escaping (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void) -> RequestTask)?

    func aggregatedOrdersAddOrderAsync(aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue, completion: @escaping (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void) -> RequestTask {
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount += 1
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedArguments = (aggregatedOrderAddOrderRequest: aggregatedOrderAddOrderRequest, apiResponseQueue: apiResponseQueue, completion: completion)
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedInvocations.append((aggregatedOrderAddOrderRequest: aggregatedOrderAddOrderRequest, apiResponseQueue: apiResponseQueue, completion: completion))
        if let aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure = aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure {
            return aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure(aggregatedOrderAddOrderRequest, apiResponseQueue, completion)
        } else {
            return aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReturnValue
        }
    }

manually created mock from generated mock. Note the reset func to reset the mock in between unit tests:
class AggregatedOrdersAPIProtocolMock: AggregatedOrdersAPIProtocol {

    static func reset()
    {
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount = 0
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedArguments = nil
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedInvocations = []
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure = nil
    }

    //MARK: - aggregatedOrdersAddOrderAsync

    static var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount = 0
    static var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCalled: Bool {
        return aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount > 0
    }
    static var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedArguments: (aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue, completion: (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void)?
    static var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedInvocations: [(aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue, completion: (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void)] = []
    static var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReturnValue: RequestTask!
    static var aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure: ((XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, DispatchQueue, @escaping (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void) -> RequestTask)?

    static func aggregatedOrdersAddOrderAsync(aggregatedOrderAddOrderRequest: XFloModelsInternalApiModelsAggregatedOrdersAggregatedOrderAddOrderRequest, apiResponseQueue: DispatchQueue, completion: @escaping (_ data: MoreFloModelsInternalAggregatedOrdersAggregatedOrderResult?, _ error: Error?) -> Void) -> RequestTask {
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionCallsCount += 1
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedArguments = (aggregatedOrderAddOrderRequest: aggregatedOrderAddOrderRequest, apiResponseQueue: apiResponseQueue, completion: completion)
        aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReceivedInvocations.append((aggregatedOrderAddOrderRequest: aggregatedOrderAddOrderRequest, apiResponseQueue: apiResponseQueue, completion: completion))
        if let aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure = aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure {
            return aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionClosure(aggregatedOrderAddOrderRequest, apiResponseQueue, completion)
        } else {
            return aggregatedOrdersAddOrderAsyncAggregatedOrderAddOrderRequestApiResponseQueueCompletionReturnValue
        }
    }

hey @otusweb, want to update the template? this is actually quite easy because Sourcery knows this info so you should be able to just add simple if check

I'll take a look, I figured it would be "complicated" :-)


Interceptor not support .net core 3.1?

I'm use ASP.NET Boilerplate  build my application . .net core3.1 , castle core 4.4.
I had customed an interceptor like this Creating Interceptors

debug shows Constructor Breakpoint be hitted, but Intercept method never be called. anything wrong?

Test in .net framework 4.6.1, work fine

@tanghaojie I'm one of the maintainers of AspNet Boilerplate and we are using interceptors in .NET Core 3.1. Could you create an issue on https://github.com/aspnetboilerplate/aspnetboilerplate so we can try to help you ?

Done


Drop the class documentation and the generation infrastructure

https://myintervals.github.io/PHP-CSS-Parser/annotated.html
Also drop the doxygen configuration.

Closing in favor of #522.


VerneMQ vs eMQTT

Hello,
I'd like to compare VerneMQ benchmarks with these given here: http://emqtt.io/ for eMQTT (which really seem impressive).
Where can I find this data, and can someone of you VerneMQ expert give us a quick comparioson and benefits of using one or other.
BR,
Drasko

Hi Drasko
we have no official benchmarks published. However, others on the web did so e.g. http://acro-engineer.hatenablog.com/entry/2015/12/09/120500 (it's in Japanese though). We also tweeted a while back some graphs of an internal benchmark, which you can find here. https://twitter.com/vernemq/status/651802735801729024.
The main differences are the way VerneMQ implements clustering and subscriber/message-storage. An additional difference is, interesting for some users, that VerneMQ is an official product developed and pushed by the Swiss company Erl.io.
Hope this helped. Please get in touch with us over email, so we can share with you some details.
Best,
Andre

@dergraf it would be awesome to have some basic public benchmarks available. I have a spare 32GB dedicated server if you need some place where to do some load testing.

How does LevelDB in vernemq differ from emqtt's use of mnesia?
Are offline messages distributed to nodes or just in a single place?

Offline messages are currently stored on one node only, yes.
I'm afraid I can't describe the differences between Mnesia and LevelDB quickly... it requires reading up on the internals and topics like consistency/eventual consistency :)

@unbalancedparentheses just seen your note...thanks a lot for your kind offer. lots of stuff to do, but we  will also work a little on testing tools. might take you up on that!

@dergraf what is the clustering difference between eMQTT and VerneMQ you are mentioning?

Please excuse this wall of text, but it is a complex topic, and I am sure I can link to this response at some other time again. :) I think a short video could also explain some of the ideas here too.
TL;DR
The main difference relies on the underlying distributed storage engine. Emqtt and RabbitMQ use Mnesia (http://erlang.org/doc/apps/mnesia/Mnesia_overview.html) for its underlying distributed storage engine. VerneMQ uses an eventual consistent datastore backed by LevelDB.
We decided to not use Mnesia because Mnesia doesn't tolerate network partitions very well. Before starting VerneMQ our company consulted on RabbitMQ setups and we experienced those issues hands-on. This made us following a completely different approach to enable clustering.
Differences
Emqtt (as well as RabbitMQ) relies on Mnesia, as the underlying distributed storage engine (subscriptions, configurations, and retained messages). Mnesia is a distributed database that is packaged together with the Erlang programming language, so it might be the logical choice for this kind of data when you implement a message broker. In fact VerneMQ used it in the beginning too. While using Mnesia is super practical at first, we soon discovered that we require a different approach for replicating this kind of data. We decided to use the Plumtree implementation found in Basho's great Riak distributed KV store and adapted it to use LevelDB.
Basically Plumtree is an epidemic broadcast protocol published in http://repositorio.ul.pt/bitstream/10451/14105/1/07-14.pdf by J Leitao, J Pereira, L Rodrigues from the University Lisbon. The paper describes an algorithm to efficiently broadcast messages to thousands of nodes in a always changing network. Neither Riak nor VerneMQ clusters contain thousands of nodes, but the characteristics of such networks exist in todays computing environments where cluster nodes are dynamically removed or added , cluster nodes may die, network partitions occur, and network latencies are real. (see https://en.wikipedia.org/wiki/Fallacies_of_distributed_computing)
Basho's implementation of the Plumtree protocol for Erlang clusters also added a basic distributed storage engine, which Riak is using for distributing cluster metadata in an eventual consistent manner. VerneMQ currently uses it to distribute subscriber and retain data. So we named it, this kind of storage is eventual consistent, with all its pros and cons (read here more about the eventual consistency model https://en.wikipedia.org/wiki/Eventual_consistency). Mnesia on the other hand is built for ACID transactions, of course it also supports dirty read and write operations (giving up most if not all consistency guarantees in a clustered setup), which is used by most performance critical applications (including emqtt). Most of the points why we moved away from Mnesia are summarized in the blog post "Mnesia and CAP" found here<EMAIL_ADDRESS>(it's from 2014 but most if not all points are still valid).
At the point when we decided to switching gears (from Mnesia to Plumtree) the interesting blog post "Call me maybe rabbitmq" found here https://aphyr.com/posts/315-call-me-maybe-rabbitmq was published, which demonstrated several downsides of RabbitMQ and its underlying clustering abilities (mainly it's behaviour during network partitions), which are mostly related to the way RabbitMQ is using the Mnesia database. I am not sure how exactly Emqtt is using Mnesia, but chances are high it's using it in a similar way as RabbitMQ does. After the mentioned blog post RabbitMQ further clarified it's netsplit behaviour found here https://www.rabbitmq.com/partitions.html. The first sentence puts it quite well: RabbitMQ clusters do not tolerate network partitions well.
To sum up
All in all we think it's great to have a MQTT broker (with all the great benefits of Erlang) that uses a different approach to distributed storage. However, in times where the network is operational and the cluster state is as expected you won't feel this as the main differentiator between Emqtt and VerneMQ. But it might give you that warm fuzzy feeling.
In case you're interested we have a dedicated chapter on network partitions in our docs https://vernemq.com/docs/clustering/netsplits.html. If you want to dig deeper, and you're familiar with Erlang, you may find the common test suite interesting, where we test different netsplit scenarios.
https://github.com/erlio/vmq_server/blob/master/test/vmq_cluster_netsplit_SUITE.erl

@dergraf wow, thanks a lot for such a detailed answer. It definitely deserves a blog post, I think.
Very useful.


Replace set and list function calls with literals

This removes a name resolution and other extra work in each case.

I did not know you could use set comprehensions.


"Indicate cursor position" negatively affects graphics tablet/mouse input

Indicate Cursor Position negatively affects graphics tablet/mouse input. Using a Cintiq 13 HD in Adobe Flash CS6 W10 64bit
see video:
https://youtu.be/tyhq531YFJU

fixed with v1.0.0
I tested it in FreshPaint with a touch sensitive pen and it worked. Hopefully that will fix it for you as well.


C++ support

Hello! I had to add following code to make compiling in C++ possible. I think it should be added to the library.
In schrift.h:
// Just before first struct declarations
#ifdef __cplusplus
extern "C" {
#endif

// (schrift.h code here...)

// Before the last #endif
#ifdef __cplusplus
}
#endif

Hi, I just want to let you know that this going into the library as soon as I have the time.

Done as of b48359e (on the v0.8 branch only).


db pull not working?

$ bun db/dbScript.ts pull

4430 |     }
4431 |   }
4432 |   if (table) {
4433 |     for (const it of data.constraints) {
4434 |       if (it.tableName !== table.name || it.schemaName !== table.schemaName || it.check || ((_h = it.references) == null ? void 0 : _h.columns.length) !== 1 || it.references.columns[0] !== item.name || checkIfIsOuterRecursiveFkey(data, table, it.references)) {

TypeError: null is not an object (evaluating '_h.columns.length')
      at dbColumnToAst (/home/minkoonim/hsadmin/node_modules/rake-db/dist/index.mjs:4435:133)
      at makeDbStructureColumnsShape (/home/minkoonim/hsadmin/node_modules/rake-db/dist/index.mjs:4384:27)
      at tableToAst (/home/minkoonim/hsadmin/node_modules/rake-db/dist/index.mjs:4273:12)
      at /home/minkoonim/hsadmin/node_modules/rake-db/dist/index.mjs:4136:14

Bun v1.1.10 (Linux x64)
error: script "db" exited with code 1

This is my first time using db pull command,
dunno what's wrong with it,
I used all the same file structures and settings as I usually do

oops, wrong credentials, my bad.

my favorite kind of issues :)

apparently, a better error message should be displayed in such case


[FEAT] Render End event

Is your feature request related to a problem? Please describe.
Render the End event with the BPMN standard.
Describe the solution you'd like
Create a new MxGraph Shape.


Expose client IP address

I believe this fixes #41, based on the reading I've done on the related issue. It basically mimicks https://github.com/sveltejs/kit/pull/4289/commits/0946d98f038258ef15d00b40ea3dad8bbb697a0a# and uses the value before the : in the x-forwarded-for header.
In my testing, Azure's x-forwarded-for header has been like this (ip address replaced with random value):
"x-forwarded-for":"<IP_ADDRESS>:52987, [fd00::d63d:e0b8:bc35:12be:2e17:f3af]:64909"

Azure Static Web Apps don't seem to assign a public IPv6 address for the app, so I don't think the given IPv6 address could ever be a valid IPv6 address of the visitor. The number after the colon appears to be a port number, so I think it's safe to cut it off at the first colon to return the IPv4 address of the visitor.
I don't have an easy way to test this right now because I use a GitHub action to build my app and it uses the published version of this adapter, so I'm hoping someone else can test it.

I think this would be good to test in a prod app to make sure the header behaves as expected - in the past, I've installed the adapter directly from the GitHub branch, e.g.
npm i github:FlippingBinary/svelte-adapter-azure-swa#FlippingBinary/issue41

Also, would be good to extract this function and have a small unit test to document the expected inputs/outputs.


Fixed jade warning and added Windows make.cmd file

Fixed jade missing space warning for lib/proposal-article/paragraph.jade
Added Windows make.cmd file to nearly emulate the unix Makefile functionality.

Hi @AaronNGray ! Thanks for this :)
But, could you please send two separate pull requests, one with Window's make.cmd and other with the --timout option for dos-install? It lets us test specific features separately.
Also, why do you need the --timeout option?
We already merged the little fixes:

tj/debug => visionmedia/debug: https://github.com/DemocracyOS/app/commit/5986c9d1488d16d67670ec9a535187e95c701c98
Jade warning: https://github.com/DemocracyOS/app/commit/04d5b1c2
Translations fix: https://github.com/DemocracyOS/app/commit/b710ee4

Hi Matias,
Sorry for the delay. I need to clean up the UKDemocracyOS repo, it got broken after the pull request was made.
The ---timeout issue is much more complex that that and was just a quick fix that worked in some cases.
The issue https://github.com/DemocracyOS/app/issues/725 outlines the problem that is with the componentjs component installer and manifests on slow and intermittent internet connectivity.
The Windows make.cmd file https://github.com/UKDemocracyOS/app/blob/development/make.cmd can be taken as is. But a better solution would to do away with make files altogether and put that functionality into package.json run scripts. There are full Windows instillation instructions here https://github.com/UKDemocracyOS/app/wiki/Windows-Installation


Load both ~/.bash_history and ~/.black-screen/history

Due to some bugs in black-screen I switch between iTerm2 and black-screen. This change reads the command history from both history files, putting the one that was written to most recently first.

It would be great to support zsh_history

Hey, @drew-gross. It might be a good short-term fix, but I'd rather not do it for two reasons:

We plan to extend the history format to include start time, end time, session id, PWD and maybe something else. It'll make them incompatible.
We should really make it stable instead of fixing the symptoms.

Although, we might leave it for now.

I hope we can also make this stable, but even once it is, I think loading their original shell history will still be nice, especially for people switching to black-screen for the first time.

OK, I made the suggested changes.

Done.


disk use % not reporting correctly since 1.7.4

and have you...

[X] I updated to the latest version available
[X] I cleared the cache of my browser

Version of RPi Monitor Card
Failling in 1.74, working in 1.72
Is this a regression?
Yes. This used to work, but now it doesn't.
Browser and Operating system
Chrome/ Home Assistant
Hey the latest Dameon Update to 1.7.4 now makes a bogus disk use number in the HA lovelace card. The sensor is correct, so im thinking there is something in the card that needs to be tweaked. thanks

thanks!
Description of problem
incorrect disk use number on card only.
Errors in Browser Console
No response
Additional information
No response

Thanks, your title is better! I filed this already as the daemon was feeding disk free and the card was correcting it to disk used.  The latest daemon is now delivering the correct value so the card needs to have this correction removed.
This is effectively a dupe of (#41)
Stephen

oh you're right. I just read your other at https://github.com/ironsheep/lovelace-rpi-monitor-card/issues/41
Ok, you're aware of this so I will close here.
Cheers.


License is unsigned

I don't know if this matters, but I noticed this line
https://github.com/yahoo/kafka-manager/blob/master/LICENCE#L189

Thanks, fixed.


Cross-platform?

It'd cool to have the program split in two parts depending if it's running on Windows or Linux 😋 (assuming you'd be into making it support both)

It wouldn't need to split in two parts and can be in the same codebase thanks to rust's conditional compilation support.
I may look into it once I've gotten all the windows stuff down maybe even sooner if the structure of the driver is the same (or similar) on linux


Stream events on overlaid DynamicMaps should selectively update layers that reference the stream

Based on the recommendation from @philippjfr , I am using a holoviews.stream.PositionXY  to overlay hv.Text onto a DynamicMap.   This works well in theory; but with wide plots with several layers, the feedback is very slow.  Here is an example:
import holoviews as hv
import numpy as np
import pandas as pd
from holoviews.operation.datashader import datashade, aggregate, shade
from holoviews.streams import PositionXY

hv.notebook_extension('bokeh')

%opts DynamicMap [width=1800, height=450, tools=['xwheel_zoom']] Layout [shared_datasource=False]

n=100000
def f(n):
    return np.cumsum(np.random.randn(n))
df = pd.DataFrame({'t': range(n), 'y1': f(n), 'y2': f(n), 'y3' : .10 * f(n)} )

def p(y):
    return hv.Curve(df, kdims=['t'], vdims=[y])

ts = datashade(p('y1'))
ch = hv.DynamicMap(lambda x, y: hv.HLine(y) * hv.VLine(x) * hv.Text(x+0.15, y, '%.3f' % x + ", %.3f" % y),
              kdims=[], streams=[PositionXY()], source=ts)
%opts RGB [width=1800, height=450]
(ts * datashade(p('y2')) * ch + ts).cols(1)

I'm using bokeh 0.12.3 and holoviews latest code as of 2425fadfd80b10e65b3c7f87cb00a102932e6dce .

Thanks @jordansamuels, this highlights an important issue with our current implementation. What is happening here is that ts * datashade(p('y2')) * ch is combined into one DynamicMap, which calls each of the individual layers. This means the datashade DynamicMap gets called every time a PositionXY event is sent. This will massively slow down what should be a very quick plot update. What should happen instead is that the outer DynamicMap only calls the individual layers if they are also attached to that PositionXY event. I'll have to think about how best to implement this, but it's an important issue that needs to be addressed before release. @jlstevens Any thoughts?

I agree this raises an important issue. I'll have to think a bit more about before suggesting anything though...

I've thought a bit about this a little and I think there are the following approaches:

Try to automatically figure out which layers are affected by streams. This in itself doesn't sound too bad but then we need to figure out how to link this information to what gets refreshed.
Using * with DynamicMaps doesn't return a normal Overlay but another DynamicMap (an instance of Dynamic if I remember rightly). We could have a special DynamicMul class just for * with additional methods such a refresh method to specify with layers ought to be updated.
You could reach into the callback and explicitly specify what should be refreshed there. Not sure if this should be by layer number or group.label (or maybe the refresh method supports both?).

I'm not a fan of option 2. as I would rather not introduce a new class. I think options 1. and 3. might be related though if we can start with option 3 and then move to option 1 later. The idea is that we offer a way for users to explicitly state which layers should be updated by specifying it on the DynamicMap callback (all of them by default).
This would offer a way for the user to improve performance right away by specifying what shouldn't be refreshed explicitly. Later on, we might be able to set this mechanism automatically, by figuring out which layers the streams affect. This doesn't sound too bad but it does need to work for arbitrary deep overlays.

I've thought about this also, indeed I lost an issue I was about to open describing a proposal. I think any approach we implement must satisfy 1. otherwise it is useless. We definitely do not add a system that the user has to know about to figure this stuff out, it should just happen. I also wouldn't be happy with 2., definitely don't want a new class. In the end it depends a lot on what you meant by:

You could reach into the callback and explicitly specify what should be refreshed there. Not sure if this should be by layer number or group.label (or maybe the refresh method supports both?).

The way I see it the only solution will be to have an events system that allows registering, among other things, which streams just received an event. These would be set either globally or somewhere else, probably with a context manager. Then it would be on the dynamic overlay functions to use the get_nested_streams to figure out whether to update a particular layer, and using the dimensionless_cache context manager to control whether to use the cache or generate a new frame.

After discussing things with @jbednar and @philippjfr, we came to the conclusion that we might be over-complicating things.
I now believe we just need to auto-memoise the user provided callbacks. If the arguments to the callback doesn't change, we assume the output doesn't change so we just return the last value. Users could set this up for themselves now but it is probably worth adding this optimization automatically, especially for things such as datashader output.

This has now been addressed through auto-memoization. @jordansamuels Please let me know how you get on with this. I'd also strongly recommend you update to bokeh 0.12.4, which should speed up datashader plots by a lot.


Revise Key Vault samples

In addition to content revision, the samples need a readme and metadata.

Note of content to look out for:

Soft-delete disabling


Doesn't infer type of default parameters

If you run tslint with requireParameterType set to true, you will get an error on the following function definition:
function foo(bar = true)

However TypeScript automatically infers the signature of this function to be
(bar: boolean)

Tslint should infer the types of default parameters so that you don't have to write redundant code such as
function foo(bar: boolean = true)

@jteplitz602 I think the rule's intent is about forcing types to be explicitly declared, even in situations like these. For example, the return type of functions can often be inferred, but this rule still requires type annotations on them. What do you think?

@JKillian That sounds reasonable. I suppose forcing explicitness is a good thing.

I think explicit type declarations only make sense, where they can't be inferred. I would love to have an option on the rule to accept inferred types as type declarations.

@Fraegle If you're working in an editor that doesn't show type information, it can make sense to have explicit type declarations. It can also add to code scanability at times.
What you're asking for seems reasonable, but isn't it essentially what you get with the typescript compiler and disallowing implicit any declarations?

requireParameterType seems to have been removed at some point?

Yes, this seems to have aged away.


Sonar Cleanup

Remove unused imports
Add tests to maps/controllers.
Narrow mocks for import functions.

Needs conflict fixes before merge but nice cleanup!


Why big indent (4 spaces instead of 2)?

I was wondering why you chose 4 spaces indent instead of 2? I know that Python uses 4 and in LaTeX you can use whatever (or use different indent size in different cases). Also, I think TypeScript by default uses 4 spaces (it also uses Microsoft's favorite CRLF instead of LF, so it doesn't really count for me), but you can easily change that. I recently read a Linux source code formatting rules where it uses 4 or 8 spaces (but 1 tab or something) because more than 3 indents is a "bad code". But most of the languages either don't have a standard indent size or use 2 spaces.
I am a 2 spaces enjoyer and therefore would like to ask to change the default indent size to 2 or add a new (first) configuration entry (or just a CLI flag/option) to enable setting different indent sizes.

The default is now 2 spaces and it will be configurable, I'll do the configuation bit (and the bin bit) when I consider the formatter offers a good experience.

I'll close this when I add a way to get the config from the bin (from a file for instance)

it is now configurable!


Feature/adapt editor to new cpp class

This enable map edition in Godot editor using C++ classes.
This fixes a lot of unusefull copy by using const references.
Spotted crash on linux when changing window from godot to another (like web browser as an example) when a map is used. This crash does not happen every time. When changing window, godot complain that it cannot find registered properties and methods, like if C++ classes are not tools anymore...

100f1aa fixes crash


BracesFixer - Fix early bracket close for do-while loop inside an if without brackets

Fix #2609

Thank you @felixgomez.

merged into 2.1 instead of 2.2


Add x_message to Universal gateway

This makes it so that Universal gateways can include x_message in payload to Shopify. We need this for COD app so that it to return a custom failure message upon payment failure. @aprofeit let me know if this makes sense or if there's a better way to do this somewhere. cc @quelledanielle @kyledurand

Looks fine to me, but should get sign off from @andrewpaliga or someone from the integrations team.

This should probably be included in docs as well. cc @jamiemtdwyer @dtkinger

I think we'll need to notify payment providers of this change and give them 30 days to adjust. x_message is included in the signature calculation and can break existing integrations.

@andrewpaliga Hmm, Signature is only calculated based on all the given x_... params, so if your payment gateway does not include x_message, Shopify won't include it in the signature calculation?

Okay I might be misunderstanding then. Will thex_message only be sent by Shopify in certain cases? ie. only be the COD app?

@andrewpaliga x_message will get sent by the app right. We'll then make Shopify use the value of notification.message when it exists for gateways like COD.

Okay as long as the parameter is not sent by default on all universal requests 👍

Okay as long as the parameter is not sent by default on all universal requests

It's in the response values so it's up to gateway to add/not add it. Shopify side will end up doing something along the lines of .message.present?


add new stateless mode and test compatibilites

[x] Add the new "Stateless" mode that does not use local storage at all.
[ ] Determine which compatibilities work and which compatibilities do NOT work with this new mode.

@ewsopp With new "Stateless" mode I can't add files to Bucket root. It needs to have folder in Bucket.
So new field Folder shouldn't be empty for "Stateless" mode

Yes, compatibility with Imagify not working on Stateless mode.
Imagify add mediafiles to local server

Review compatibility

[] Advanced Custom Fields Image Crop Addon
[] BuddyBoss
[] BuddyPress
[] Divi
[] Dynamic Image Support
[] Easy Digital Downloads
[] Elementor Page Builder
[] EWWW Image Optimizer
[] Gravity Forms   - working
[] Imagify Image Optimizer   - not working
[] LearnDash LMS
[] LiteSpeed Cache
[] Polylang Pro
[] ShortPixel Image Optimizer
[] Simple Local Avatars
[] SiteOrigin CSS
[] SiteOrigin Widget Bundle
[] VidoRev
[] WooCommerce Extra Product Options
[] WP Retina 2x Pro
[] WP Smush
[] WPBakery Page Builder
[] WPForms

@ewsopp With new "Stateless" mode I can't add files to Bucket root. It needs to have folder in Bucket.

Should we just default to the standard Wordpress organization scheme?

Should we just default to the standard Wordpress organization scheme?

Yes, we can use our predefined values for Single site and for Multisite by default.

@ewsopp I added predefined value for field Folder on Stateless mode.
Also I added notice, maybe need to change text on it?

@ewsopp

Determine which compatibilities work and which compatibilities do NOT work with this new mode.

I have checked compatibilities with new mode. Most of them are working.
List of compatibilities with comments - https://github.com/wpCloud/wp-stateless/issues/482#issuecomment-627301779

@ewsopp
Should we disable and hide from list compatibilities which not working on Stateless mode?

I don't think we should hide it. Lets disable it, similar to how we treat compatibilities that are disabled when the related plugin is not active.

We probably should also add the following message:

This compatibility does not support Stateless mode.

Mockup

Done.

Working fine.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>
add one condition that test the first character of the username and with isalpha() fun check if it's a letter or not.
For example

the username 'blue.kale' the first character is b so the username validate
the username '_red_quinoa' the first character is _ then the result is false
and add some test line to check the code work properly.
@cdibona @dberlin @google-admin @margamanterola

It's a good idea to open an issue first for discussion.

[√] Tests pass
[] Appropriate changes to README are included in PR

comitte changes


[5272] Bulk QTS: guidance page

Context
https://trello.com/c/y5sBNdW4/5272-s-bulk-qts-guidance-page
Changes proposed in this pull request

New page using markdown

Guidance to review

Visit /guidance
Click on link "Bulk recommend trainees for QTS or EYTS"

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 [S] Bulk QTS: guidance page


Focus on first matching item when key is pressed

I've made the mistake of thinking I could jump down to the next item when I pressed a key before in a custom selectlist. This allows a feature that the native select supports. When the dropdown is open pressing a letter will search the dropdown list until the first item starting with that letter is found and set the focus to that a tag. Fixes #128.
@jamin-hall Do we want to support this?

@interactivellama, yep. This sounds great.

tested this and it's awesome... nice add!