Write script to move autogenerated sidebar content to API from the Interfaces tab

When you run npm run docs, TypeDoc automatically created a new "Interfaces" key in the sidebar.
As a solution to this issue, we would need to write a script to move contents from here to the "Api" section.

@shubhamzanwar I'd be happy to lend a hand with this issue

Go for it 🤘🏽
You can check out nodegui to see how it's being fixed there.
 If you need some help, drop a message here :D

@shubhamzanwar it seems to me that Widgets and Interfaces arrays are identical, do you want to keep one or the other?

Everytime TypeDoc runs, it generates the Interfaces array. We want to replace the api.widgets array with the Interfaces array and then remove the Interfaces array.

This is what the generated website API tab looks like with the above PR


mime.lookup is not a function

my os is windows 8.1 64 bit
this is the following error
CRASH: TypeError: mime.lookup is not a function
    at Server.respond (C:\Users\inky\Music\pokemon-showdown\node_modules\node-st
atic\lib\node-static.js:348:28)
    at C:\Users\inky\Music\pokemon-showdown\node_modules\node-static\lib\node-st
atic.js:64:22
    at FSReqWrap.oncomplete (fs.js:155:5)

Additional information:

here is the following logs
inky@Shousto4 MINGW64 ~/Music/pokemon-showdown (master)
$ node pokemon-showdown
NEW GLOBAL: global
NEW CHATROOM: lobby
NEW CHATROOM: staff
Worker 1 now listening on <IP_ADDRESS>:8000
Test your server at http://localhost:8000

CRASH: TypeError: mime.lookup is not a function
    at Server.respond (C:\Users\inky\Music\pokemon-showdown\node_modules\node-st
atic\lib\node-static.js:348:28)
    at C:\Users\inky\Music\pokemon-showdown\node_modules\node-static\lib\node-st
atic.js:64:22
    at FSReqWrap.oncomplete (fs.js:155:5)

Additional information:

it happended when i went on http://localhost:8000

My best guess is that this is a bug in node-static's Windows support?

Looking further, it seems like either you're missing a subdependency, or you have the wrong version of mime.
Try deleting node_modules and trying again?

(Feel free to reopen if that doesn't work)

@Zarel changing mime.lookup to mime.getType in the code worked thanks anywayws

That definitely means you have the wrong version of mime. Are you using a third party npm implementation? The default one should install mime 1, not mime 2...

i just did npm install i belive npm is installing the lastest version but after i restarted my pc it stopped showing that error so i think its a web error or something

Let's just chalk it up to a one-time npm glitch.

Are you using c9? I've expirienced this in the past trying to connect (link didnt redirect to psim.us) its easily fixed by adding -80.psim.us to the normal link (if it dosent already have it)

What versions of node, npm, node-static, and mime are installed if this happens for you, out of curiosity?

Are you using c9? I've expirienced this in the past trying to connect (link didnt redirect to psim.us) its easily fixed by adding -80.psim.us to the normal link (if it dosent already have it)

The only reason that prevents the crash is because using the psim.us URL skips having to get index.html from the server to get redirected. Any requests to the server outside of /showdown/* should still crash

lookup() renamed to getType() in mime version 2. https://www.npmjs.com/package/mime


Added timestamps to verbose logging

fixes #257

@anlynes @camiloborges @caadam @ykuijs Code review boys

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Looks good, no comments.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[TextMate] treat tag annotations as comments

Most files contain a license header, and a lot of standard functions contain documentation tags.
The body of them should be marked as comments.
@license{
  BSD-2 License
}
module A

@doc{
   Textile markup for the documentation
}
@javaClass{org.rascalmpl.library.X}
public java str doStuff(int x);

they should be marked as comments instead of normal text

New example

Nice!


[Forge] Tags related stuff

add #forge:mushrooms, #minecraft:enderman_holdable, #minecraft:terracotta / #forge:terracotta tags
also consider adding compat tag: #createadditions:plants

Done for the next update


Add SimpleTest to reproduce ClosedChannelException issue

This reproduces what I was talking about in #3. Feel free to change it or move it or not accept it or anything.

Pushed a new commit that was signed

Thanks again for providing this example @sixcorners. The resolution is now released in Jagged version 0.3.2 and as fixed in PR #5.


fix: merge conflict

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.44%. Comparing base (605b4bd) to head (da553cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1974   +/-   ##
=======================================
  Coverage   78.43%   78.44%
=======================================
  Files          62       62
  Lines        8843     8847    +4
  Branches     8843     8847    +4
=======================================
+ Hits         6936     6940    +4
  Misses       1470     1470
  Partials      437      437

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


on page load

Hi,
Your lib is awesome, really great effects. I have just a tiny problem. On one of my pages, there are 5 panels with storybox effect (bounceInRight or bounceInLeft). When this page is loaded, panels appears without effects during less than 1 seconde, then disappears and finally comes back with the storybox effect.
Do you see what i mean and why ?
Thanks a lot
Séb

Hey :)
Add this css rule : [data-sb] { opacity:0 }

Thank you !! that's resolve the problem on the load but generate an other one. On postback, panels don't reappear, opacity=0 and effects are not played again :-(. Any idea ?
Thanks


Unable to use std::ranges::is_sorted with view's each - not a forward iterator

It is possible to use storage and a simple view with std::ranges::is_sorted. However, view::each does not satisfy the forward iterator requirements.
See an example here
With multi component views it would be nice if the extended iterator satisfied the requirements as it would make it easier not only to verify if a storage is sorted by another storage, or with any other range that requires forward iterators.
registry.sort<A,B>();
std::ranges::is_sorted(registry.view<A,B>().each(), cmp, []( auto each ){ return std::get<1>(each); });

Well I can
registry.sort<A,B>();
std::ranges::is_sorted(registry.view<A>().each(), cmp, [&registry]( auto entt ){ return registry.get<B>(entt); });

but now I have to capture the registry and do a get call for every entity.
Also, this is assuming that every entity that owns A also owns B, which is true for my use-case, but not everyone.

Unfortunately, the iterable object returned by each cannot offer forward iterators.
It's funny because this happens due to an idiosyncrasy of the C++ language. 😅
Long story short, among the other things, the reference type of a forward iterator must be an actual reference.
On the other hand, the view returns a tuple containing the entity and a bunch of component references 🤷♂ that's it.
The multi-pass and all other requirements would still apply, but we can't say it's a forward iterator anyway.
A long-standing flaw in the standard that has been long discussed and never truly resolved.
There is nothing I can do here I guess but I'm open to suggestions if you want to discuss it further. 👍

Probably a similar approach to ranges' zip implementation. It offers forward iterators if all views are forward iterators. The same for bidirectional and random access. Paper
So, if a storage is by itself a forward iterator, and this iteration is kind of like a zip | filter - or the other way around, it could be possible, if I'm seeing this straight.

Technically speaking, this iterator is literally a zip iterator already. It also models a forward iterator for most of the requirements.
However, its reference type cannot be a reference and this puts it in the input iterator category.
An algorithm that checks the category and requires a forward iterator tag will reject it. It doesn't matter if it provides a multi-pass guarantee, if it's default constructible or if it fits all other requirements of a forward iterator.
That is why I mentioned a well-known and documented idiosyncrasy of the C++ language. Fortunately, the forward iterator concept fixed it with C++20. It doesn't require an actual reference anymore when dereferencing for example. However, I cannot change the iterator category since the requirement is still there.

But can't we add using iterator_concept = std::forward_iterator_tag to work with c++20 ranges?

Well, technically speaking this is still a C++17 library (mainly because C++20 isn't a thing yet in many envs). I guess it's possible though.
However, I'm not 100% sure that iterator_traits reads this type member from iterators. The standard talks about explicit specializations of the traits. Am I missing something?

Well, reading through this paper and the iterator tag says it does, if I'm understanding it correctly. C++17 will use the category and C++20 will prioritize the concept, making it compatible with both legacy and current iterator implementations. Since this specific iterator is an input_iterator in the legacy system and a forward_iterator in the newer system, it also is a valid candidate to specify the different iterator tags, if I'm understanding this correctly.

Actually, there are a few iterators in EnTT that model a different concept.
For example, the ones for meta containers too. I'll review them all soon. 👍

Thank you! Looking forward to this :)


Use user-specified keystore file instead of creating a new one

In #9912 a support for specifying keystore files for SSL configuration was added. We need to refactor SSL handler to allow it to use existing keystore files instead of creating a new one.

verified


import jpegio error:No module named 'jpegio.componentinfo'

how should i use your lib to my project,i run the python setup.py install in my env ,but errors happen,thank you for you answer

Could you post your error. OS details, python version, version of jpegio etc.


Recursive lang change, refactor thumbnail selector, not work from 21/07/2022

Recursive language change, if YouTube, for some reason, did not change the language the first time, although the English (UK) button was pressed, the exit from the recursion occurs when the selectedLang selector is tested for the set language. And changed selector for choising thumbnail, youtube add  at the end.

This change is

I have fixed the thumbnail issue in v1.3.66

I have fixed the thumbnail issue in v1.3.66

But you don't fix problem with change lang at first-time. I'm from Ukraine and youtube set default language ukrainian based on my ip, and basically don't change at first-time.

ok, thanks


Not working with @nuxtjs/router

Version
nuxt-i18n: 6.25.0
nuxt: 2.15.3
Nuxt configuration
mode:

[x] universal
[ ] spa

Reproduction Link
https://codesandbox.io/s/angry-sanne-uqrru
https://github.com/DonSalvador/langVue
What is Expected?

i18n-module should generate the language routes automatically
switchLocalePath should working when press the languages buttons
localePath() should return the path with the prefix

What is actually happening?

the language routes are not being created automatically and I have to create them manually. If I go to /es without creating the routes for Spanish language, it will go to the user page /:username, instead of home.
when I switchLocalePath nothings happen, so I have created a path manually
localePath is returning the path without any prefix

Adding @nuxtjs/router removes all routes by default. See its documentation https://github.com/nuxt-community/router-module#usage and especially the keepDefaultRouter option.
You will have the same behavior without nuxt-i18n.


How to change default 8000 port to another custom one ?

Hello ,
I could not find a way how to change 8000 port used by WS to another custom one in the documentation, can you help me please ?

sorry i found it in this link


Template editor is breaking when working with > characters in liquidjs

Write directly in a text block something like:
{% if 2 > 1 %}
  test
{% endif %}

The template editor will save it as &gt instead of > resulting in error:
unexpected token at "> 1",
I would expect the templating language to work.
Workaround:
Manually edit from source code --> json source replace the > back to >

This is expected, special characters must be treated like this, If you don't want special processing, you can use html mode


Instruction for Firefox is wrong

For step 4, Enter https://autologon.microsoftazuread-sso.com in the field., the protocol should not be specified. The login FQDN should be directly used.
Tested on Firefox 62.0.3 (64-bit).
Please fix the document, thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d53fedc-b37d-9c37-fd71-32088e1e88d3
Version Independent ID: 1d67c426-39ff-8646-139d-51cd5e9fe44e
Content: Azure AD Connect: Seamless Single Sign-On - quick start
Content Source: articles/active-directory/hybrid/how-to-connect-sso-quick-start.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

Sorry, I just noticed that when I copied the site by right clicking the address and select "Copy link address" in Chrome, a forward slash was added, which is causing the seanless SSO failed.
I will close the issue and pull request. Sorry for any inconvenience.

@DSakura1987 Thanks for the update.


double-beep: Watch profitaccumulator.co.uk

double-beep requests the watch of the watch_keyword profitaccumulator\.co\.uk. See the MS search here and the Stack Exchange search here.

profitaccumulator\.co\.uk has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


key attribute

Currently key attribute is silently skipped, shouldn't this be set as attribute or property or at least in dataSet?
https://github.com/proteriax/jsx-dom/blob/a24e63e96836575ddf878a2a43263c7178c86db1/src/jsx-dom.ts#L135-L136

shouldn't this be set as attribute or property or at least in dataSet?

Nope, it should not:

Keys serve as a hint to React but they don’t get passed to your components. If you need the same value in your component, pass it explicitly as a prop with a different name

source

This is not react and key have to be accessible somehow to be any useful, for example to use with morphdom. Otherwise should be removed from types.

jsx-dom strikes to emulate React’s API and behavior as much as possible, that’s why key is stripped away.


Imperfect round-trip of Miri repo due to gpgsig

When applying josh to https://github.com/rust-lang/miri, doing a round-trip that should be the identity nevertheless produces a result with a different hash:
git clone https://github.com/rust-lang/miri
cd miri
# do this in 2 steps because otherwise josh is too clever and doesn't do any work
josh-filter :prefix=extra refs/heads/master --update refs/heads/filtered
josh-filter :/extra refs/heads/filtered --update refs/heads/double-filtered
git diff refs/heads/master refs/heads/double-filtered
# no output, as expected
git rev-parse refs/heads/master refs/heads/double-filtered
# two different SHAs

I went through our history to see where the difference starts, and it is this commit. show --pretty=raw also shows why:
commit 6abfa56b20009546be67837cc7cd92c9c13f5951
tree b450b00d80b565f5ef7f93660af60468b6add237
parent 8cac01ae66a8eebca4711a5771ad161cb8f498ba
author Pascal Hertleif<EMAIL_ADDRESS>1460584860 +0200
committer Pascal Hertleif<EMAIL_ADDRESS>1460584860 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org

 iEYEABECAAYFAlcOwccACgkQ7bsajSBHoHQp+gCgqi423y1LEedj4qkVGvdzGx28
 OXQAnijThOzObWreOk0wRMZ8RvTE7/EK
 =q0is
 -----END PGP SIGNATURE-----

    Update to Rust Nightly 2016-04-11

diff --git a/src/interpreter.rs b/src/interpreter.rs
index 850ddf8aa18..a1db521760f 100644
--- a/src/interpreter.rs
+++ b/src/interpreter.rs
@@ -1,7 +1,7 @@
 use arena::TypedArena;
 use rustc::infer;
 use rustc::middle::const_val;
-use rustc::middle::def_id::DefId;
+use rustc::hir::def_id::DefId;
 use rustc::mir::mir_map::MirMap;
 use rustc::mir::repr as mir;
 use rustc::traits::{self, ProjectionMode};

The gpgsig part is lost after josh did its thing.
Obviously the signature is broken on the intermediate trees, but given that the josh design goal is a perfect roundtrip, this still seems like a bug.

Yes, that is true. Signatures are lost when filtering because they cannot be valid for filtered commits. Once lost we can't recover them.
I looked at your change now and I'm shocked that it seems to work :)
So git does not mind for a invalid signature being present in the commit?

I don't know if and when git validates signatures. That would probably be good to figure out. :)  But the testcase works, is all I can say.
Given that we have singed commits in the Miri history, I think we pretty much need this to round-trip properly. Otherwise if, in the future, someone pushes a signed commit to Miri, the syncing round-trip will do some awkward duplication of that change and probably end up conflicting with itself...

Looking at https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work and other resources I found only, it doesn't seem like git will verify anything by default, and validation will validate only the commit in question, not the signatures in the history (which makes sense since the signature signs the history due to the hashing).
Maybe this should be a user-configurable option, controlling globally whether signatures should be preserved or not.

I think knowing that now, we can just preserve the signatures (apply #958)
This will solve the "imperfect roundtrip" issue and I think if somebody needs smarter handling of "partial signatures" that could maybe build on top of that.


Customize BRAAF Information

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

What are we trying to do?
Get ready to bring BRAFF onto system.

What feature or behavior is this required for?
Changing any tool tips, pledge caps, and fund specific information for BRAAF.

How could we solve this issue? (Not knowing is okay!)
Change related fields per BRAAF's guidance

No cap for up to 13w6d. For 14 weeks the cap is $300.
Use BRAAF name for logo (currently no art work type logo available)
BRAAF website link: blueridgeaaf.com
BRAAF call line number:<PHONE_NUMBER>
Currently no CM Resource link (hide for now?)

Anything else?
Let me know if we missed anything.  I have a copy of their pledge form.  Will we be able to do auto-generate for them?

Down the line:

There's a PR that I'm going to merge today #1215  that'll let them set their own text for cap guidance, so nothing much to do there.
The places I see the logo are the footer and the favicon. I think it's fine on both of those tbh, since this is a DCAF/Code for DC product, pretty much.
The phone / website link are an oversight, I think! I'll spin up an issue to set those to env vars.
No resources link means the link just won't show up, so we're good on that.
Autogen is DCAF only for the immediate future, sad to say. They should plan on use their existing pledge shipping processes at launch.

@NerdyGirl537 when you get a sec could you send me the emails of anyone at BRAAF who should be on the updates distro list?
If you wouldn't mind also emailing me that copy of their pledge form that would be 💯

Per an email, need to customize the fax link as well -- BRAAF has a different service they're using.

Talked to Toby tonight and she brought up zip codes -- rediscuss

I'm going to make a semi-executive decision and say no zip code for now, since I don't think it serves our project to continue going back and forth on this even if it does make them adjust their procs a little bit. If this is a pain for them on an ongoing basis then we should rediscuss, but for now they should think about just making a note about eligibility or zip in their notes.
The discrete tasks should be good to go here, so marking complete.


added eventDetails Fragment

fixes : #28
@dreadpool2  @nikit19  since it's a big PR I may have missed some indentation errors, please review

On clicking on event -

@simarsingh24 It would be better to remove the first card I guess

first card displays the logo of the event

Okay

@simarsingh24 I think the UI should look like this (my opinion)

UI -

Why is text not centered after toolbar collapsed ?

Update screenshot

@iamareebjamal please look at the screenshots, why is collapsing app bar text not vertically center in screen shot 1?

As you can see, the toolbar is not correctly visible

@iamareebjamal yes! but not sure why is this happening

Very good

@simarsingh24 Follow the commit guidelines


Nested ordered list resumes child's numbering

Describe the bug
After nesting an ordered list and returning to the first level, the index resumes the child's numbering. This also happens when you nest a list inside another nested list.
To Reproduce

Compose a new email, reply to an existing one or edit a draft.
Select Ordered List
Write something at index 1.
Nest a list inside it (insert a new line and tabulate)
Add a few lines
Go back to the first level (shift+tab)

When nesting lists inside nested lists, the same thing happens.
Expected behaviour
You would expect something like this:

Section A

Subsection A
Subsection B

Section B

Section A

Subsection A
Subsection B

Subsubsection A
Subsubsection B
Subsubsection C

Subsection C

Section B

Screenshots

(this is on mail.protonmail.ch)

(this is on beta.protonmail.ch)
Desktop (please complete the following information):

OS: Ubuntu 20.04
Browser Firefox
Version 76.0.1
Plugins uBlock Origin and LanguageTool
Resolution 1920x1080
URL mail.protonmail.com and dev.protonmail.com

Closing as this is a Firefox specific issue.


Importing library 'AppiumLibrary' failed | PyCharm

Issue Summary:
Unresolved library: AppiumLibrary. Importing library 'AppiumLibrary' failed: ModuleNotFoundError: No module named 'AppiumLibrary'. Consider adding the needed paths to the "robot.pythonpath" setting and calling the "Robot Framework: Clear caches and restart" action.
Issue Description:
I am encountering an issue when attempting to import the AppiumLibrary in my Robot Framework project. The error message indicates that the module cannot be found and there is a suggestion to modify the "robot.pythonpath" setting.
Environment:

Robot Framework version:  3.1.1
Python version: [version number]
Operating System: Mac
Installed libraries:

Steps to Reproduce:

Install Robot Framework and AppiumLibrary using pip.
Create a new Robot Framework test suite.
Add the import statement for the AppiumLibrary in the test suite settings.
Execute the test suite.

Expected Result:
The test suite should import the AppiumLibrary successfully and execute without any errors.
Actual Result:
The test suite fails to import the AppiumLibrary, and the mentioned error message is displayed.
Additional Information:

I have confirmed that the AppiumLibrary is installed at [path to the AppiumLibrary installation directory].
I have verified that the Python interpreter being used matches the one where the AppiumLibrary is installed.
I have attempted to set the "robot.pythonpath" setting with the path to the AppiumLibrary directory, but the issue persists.

Any guidance on resolving this issue would be greatly appreciated.
Thank you for your assistance.
Best regards,

@baselalali did you find any work around for this issue? I am facing similar issue .

No, i don't find any solution for this problem. I tried with other python version, but i get the same problem. Any help library developer side?

This issue tracker is for Robot Framework and the issue seems to be related to AppiumLibrary and/or PyCharm plugin.

@baselalali did you find any solution?

Any solution yet?

I have the same problem here. Did anyone was able to find any solution?

I my case, I found that issue open https://github.com/serhatbolsu/robotframework-appiumlibrary/pull/418 and I was able to solve my problem doing downgrade of the library Appium-Python-Client.
python -mpip install --force-reinstall Appium-Python-Client==3.2.1


Automating dotmailer extract

Need to automate emailing Linda with the latest address book updates.
Emails should happen weekly

@davidpmccormick already has a way of extracting and formatting the data, we need to add the email functionality and automate it

This is now running as a lambda in AWS – it should ping me and Linda once a week. Linda is aware (and she received the first email this morning).

https://github.com/wellcometrust/dotmailer-reporter


Provide tar.gz for releases for different archs

Hi,
As seen here: https://github.com/coreos/flannel/releases, there are releases available for different archs, but the tar is only available for amd64. Now, ansible playbooks for kubernetes use tar.gz to install flannel. To make those playbooks arch neutral, we need tar.gz files for ppc64le and arm. Is there any plan/possibility to provide that?

That sounds fine to me, but I'm not sure I can promise it for the next release. If you'd like to submit a PR (changing the Makefile) then I'll happily merge it.

Sure, I will submit a PR soon.


WIP: vectorize PPoly.solve

will close gh-3260, when done.

cross-ref https://github.com/scipy/scipy/pull/3260#issuecomment-1166510296 for a discussion. I'm currently leaning towards this being a bad idea, am very much open to suggestions.

Based on the discussion started in https://github.com/scipy/scipy/pull/3260#issuecomment-1166510296, let's reject it.


NIFI-5448 Added failure relationship to UpdateAttributes to handle ba…

…d expression language logic.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

In case any reviewer comes along and wonders why it wouldn't be simpler to just control the EL logic and input data better, the reason why is that the folks in our company who reported this error to me and @dmkoster are working with another team that is driving this with their own input. So their only choices in this multiple-chefs-in-the-kitchen situation are to either add manual steps to clean it up or watch the data back up in the queue.

@MikeThomsen - unfortunately, I believe this is a breaking change that will need to wait for NiFi 2.0.0. Adding a relationship will make the processor invalid after an upgrade and users will have to define what they want to do with this new relationship.

@pvillard31 @zenfenan it's an autoterminating relationship by default and the default behavior is maintain the status quo.

@MikeThomsen oh nice! completely forgot about this option! my bad

I would be very careful taking that option. Yes, it would ensure that users flows remain valid. However, I would question if that is the behavior that those users actually want. If the new relationship were auto-terminated that would mean that any data routed there would be DROPped. Folks upgrading may not realize this and it could lead to data loss.
This concern was brought up in an old JIRA [1]. At that time, the solution was to penalize the flowfile and rollback the session. Since this processor is so widely used, it may warrant a DISCUSS thread so the community can consider the options and when they may be appropriate to introduce.
[1] https://issues.apache.org/jira/browse/NIFI-11

Looking at the changeset I see that a property was added to allow the user to opt-in to the new behavior. That should alleviate my concerns. Sorry for the confusion.
Only other suggestion would be to change the name of "Stop Processing" AllowableValue to maybe "Penalize" as that is what the current behavior should be doing.

@zenfenan changed it.

+1 Built it and verified the changes with a sample flow. Everything works as expected. Thanks @pvillard31 and @mcgilman for the reviews. Thanks @MikeThomsen. Merged to the master.


Operator isEmpty is missing the short description, description, and examples

Please check those that apply

[ ] typo
[x] documentation doesn't exist
[ ] documentation needs clarification
[ ] error(s) in example
[x] needs example

Description Of The Issue
The isEmpty operator is missing the short description, description, and examples.
We might want to implement this.

This should be already there because of #4580.

It's just not deployed yet. Therefore I will close this issue for now.

Next time I will take a better look at the PR's. 🙈


Fix the phantomjs dependencies

PhantomJS and its mocha adapter are only used for testing, so they
belong in devDependencies.
Bumped the versions to phantomjs 1.9.20 and mocha-phantomjs 4.0.0

Will send a cleaner fix.


Move README.md documentation to new /docs directory

Overview
We should simplify our README by separating the key concepts and architecture guides into their own separate /docs directory, similar to how Soulmedicine is organized, and turn the README into a brief overview of the project and quick start guide.
Action Items

[ ] Create a /docs folder in the root directory.
[ ] Move the Key Concepts section of the README.md into the /docs folder in a file called key-concepts.md
[ ] Move the Database Models section of the README.md into the /docs folder in a file called data-architecture.md
[ ] Write the following sentence under the "Local Development" section title in the README.md:
"For a more detailed explanation of this project's key concepts and architecture, please visit the /docs directory."
[ ] Make sure the above sentence contains a Markdown link to the /docs directory, which would be: https://github.com/chaynHQ/bloom-backend/tree/develop/docs (This is where a README.md file will be located in the near future.)

Resources:

How to make Markdown Links

Hi! May I pick this up?

Thanks for your interest @maryamkhan14! I see you commented on 2 no-code, good first issues, we limit 1 no-code, good first issue per contributor! Let us know which one you'd prefer an I'll get you assigned ASAP. :)

hey @kyleecodes, can I work on this issue?

@ATREAY thanks for your interest, I have assigned you the issue. :)

Hey @kyleecodes,
I'm running into an error. Should I downgrade my Node version to fix it, or do I need to update the one in the repo? Here's a screenshot for reference.

Great question @ATREAY
I suggest using a node version manager, such as nvm, which can install multiple versions of node on your computer and switch between versions for a given project. For instance, I generally use the latest version of node on my computer, but when I need to run an older node version for a project, I target that specific node version using nvm. It's a simple system once you get it set up.

Hey @kyleecodes,
I've run into another issue, and I'm hoping you could lend me a hand with it. Here's a screenshot for reference:

My apologies for reaching out on the weekend.

This is an error thrown by the NestJS testing framework, but because this issue is a no-code issue, it is not required for these tests to pass on your computer. The test is failing because you do not have the required environment variables set up, in this case the tokens from Simplybook. For this issue, I would not worry about this.

Hey @kyleecodes, I've made the necessary updates. Could you please review them when you have some time?

Hey @kyleecodes, I've created a new pull request that includes only the necessary files. I closed the previous one. Could you please take a look when you have a moment?

Perfect thank you @ATREAY!


bau: update rails to 6.1.7

To address CVE-2022-32224 / GHSA-3hhc-qp5v-9p2j
Updated with:
bundler update rails
All rubocop and rspec tests pass.

Ah, looks like automatic builds in PRs from Forks may not be working....

Hi @phyzical , I tried force-pushing, but the status is still reported as:

Some checks haven’t completed yet
AWS CodeBuild ap-southeast-2 (saml-service) Expected — Waiting for status to be reported

Not sure whether this is because the PR's from a Fork...
Cheers,
Vlad

yeah it fired off of my pr maybe it doesn't like forks

yeah it fired off of my pr maybe it doesn't like forks

I think it might be that the repo config has secrets for running the CI job, but these secrets are not shared with forks...
Perhaps might help if I get collaborator access on your repo so that I can send PRs from within the repo?

@vladimir-mencl-eresearch i think the workflow that the rework is using will work as expected, but once thats merged we can readdress if this is still an issue 👍


cross-platform path resolution

This has been very frustrating for me to debug, but now it seems that author of this gulp module is using OSX or Linux machine.
I am  a Windows user myself  and I have a big problem with this bit right here in index.js:
function cacheLocale(file, enc, cb) {
	// ignore empty files
	if (file.isNull()) {
		cb(null);
		return;
	}

	if (file.isStream()) {
		cb(new gutil.PluginError(PLUGIN_NAME, 'streaming not supported'));
		return;
	}

	// file is buffer
	var localeId = file.path.split('/').pop().split('.').shift();
	var locale = JSON.parse(String(file.contents));
	localeCaches[options.cacheId].locales[localeId] = locale;
	cb();
}

Line for finding localeId is not working on Windows. Filepaths on different OSs are written differently. For a cross-platform solution module path should be used.  Respective line should change to this:
var localeId = path.basename(file.path, '.json');

Also, I fixed a typo in README.md.

Hey @teodors, thanks so much for the pull request! I'll have to be more cognizant of cross-platform compatibility.

Thanks @teodors!

Yeah, there is no need for it. It is core module. Thanks for quick response @bitjson.


HDFS-14483. Backport HDFS-14111,HDFS-3246 ByteBuffer pread interface to branch-2.9

1046

 Quality gate: Failed
11 Issues

 3 Vulnerabilities
 8 Code issues

Details

 Quality gate: Failed
11 Issues

 3 Vulnerabilities
 8 Code issues

Details


Doc : Add OpenEBS example

Thanks for taking the time to contribute to clickhouse-operator!
Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:

[x] All commits in the PR are squashed. More info
[x] The PR is made into dedicated next-release branch, not into master branch1. More info
[x] The PR is signed. More info

--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

you just need proper base instead of master

@Slach sorry yes, I closed this to open another one properly based....

i changed the base, let's wait when e2e tests complete

@lorellalou could you sync your PR with 0.24.1 to re-run tests?
something like that
git remove -v
git pull upstream 0.24.1` ?

or just something like "sync upstream" in github web interface

@Slach done.


nexterov in LARS

https://github.com/rwightman/pytorch-image-models/blob/75144395739162a153dae5628320b85b5895634b/timm/optim/lars.py#L70-L73
Why set the nesterov as False when calling __setstate__?

@weigq it was based on the SGD impl in PyTorch which does the same thing, I don't know exactly why that is... probably some historical reason when nesterov was added, and may not apply at all here (likely)

Thanks.


koji_promote: use component in nvr, not Name label

We should be using component-version-release for the Koji Build, i.e.:

'name' = com.redhat.component / BZComponent
'version' = version / Version
'release' = release / Release

Coverage increased (+0.007%) to 87.233% when pulling 4eaa1e4e568a0e25ad0726ec0e4fb63fb3f89a06 on koji-promote-component into 59599359b8eda3cb05e12ee96e062686ab4e7dca on master.

Coverage increased (+0.007%) to 87.233% when pulling 413e57b46c03e51dc931448b6e24d8b6db54a7e3 on koji-promote-component into 59599359b8eda3cb05e12ee96e062686ab4e7dca on master.

Coverage increased (+0.01%) to 87.236% when pulling 9c44249890610074c0166fcc625ee7aa234ce8ee on koji-promote-component into 59599359b8eda3cb05e12ee96e062686ab4e7dca on master.

LGTM

Coverage increased (+0.01%) to 87.24% when pulling 67fdf454fa99fb07a66b89ea6f37fe8a6892df7d on koji-promote-component into 8d44e8d397c1d0140c38050418db1499691f7877 on master.


Make AOT compiled classes implement Machine

The first two commits are from #559

Well, what should I say:

:rocket: :rocket: :rocket:

It does add complexity, but also removes the MethodHandle adaptation code, which wasn't easy to understand (or write). But the primary motivation is for your pre-compiled AOT work. Now we don't need the Java code generator and it uses the same code in both modes.

Agreed, thanks a lot for the help.
Much appreciated, and the result is outstanding!
Next is going to be Instance.initialize fully embedded in AOT, but let's settle things a bit first 😅


Brent a dorsey 001

one-time-setup.sh

refactored chmod bin/a+rx *.sh to resolve “chmod: Invalid file mode: bin/a+rx” error
** cd ~/pipeline/bin && chmod a+rx *.sh && cd ~/pipeline

config-services-before-starting.sh

implemented bzip2 -d -k $DATASETS_HOME/movielens/ml-latest/movies.csv.bz2 in #Datasets section to resolve file not found issue in spark-notebook Cassandra Exercises - Load and Save Movie and Ratings Data

TrainALSIncremental.scala

flxed df column name casing, changed userId to userid and itemId to itemid

Cassandra

changed Cassandra Version to 2.2.4 to fix “Build Fatal Error: dist/cassandra/2.2.3/apache-cassandra-2.2.3-bin.tar.gz NOT FOUND”
changed Spark Cassandra Connector Version to 1.4.0-M3 to match db version
** Files Modified
*** DockerFile
*** config/bash/.profile
*** myapps/feeder/src/build.sbt - comment only update
*** myapps/streaming/src/build.sbt - comment only update
*** spark-notebooks
**** core/Spark on Mesos using Cassandra.snb
**** pipeline/Cassandra Exercises.snb
**** pipeline/Likes From Kafka.snb
**** pipeline/Ratings from Cassandra.sb
**** pipeline/Ratings from File.snb
**** pipeline/Ratings from Kafka.sb
**** virdata/List of things.snb
*** zeppelin
**** 2ASK4UQ3M
**** 2AUUDPT56
**** 2AZ37ZY6H
**** 2B2M4DMJK
**** 2B2SHA7Y8
**** 2B3N77G95
**** 2B42HQF6Z
**** 2B4KM1ZUH
**** 2B5U7ZA3Y
**** 2B7DV97DX

Feeder

Modify the kafka topic name from ratings to item_ratings in:  myapps/feeder/src/main/resources/application.conf

Spark-Notebooks

Cassandra Exercises - Load and Save Movie and Ratings Data
** moviesFromCSV - changed file path to:  file:/root/pipeline/datasets/movielens/ml-latest/movies.csv

Tachyon

config-services-before-starting.sh - implemented “tachyon format” on line 149
config-services-after-starting.sh - removed #tachyon format comments
config/spark-notebook/application-pipeline.conf - tachyon.enabled=true
config/tachyon/log4j.properties
** Replaced tachyon.Log4JFoileAppender with org.apache.log4j.RollingFileAppender to resolve “log4j:ERROR Could not instantiate class [tachyon.Log4jFileAppender].” error
** Removed the deletionPercentage settings to resolve “log4j:WARN No such property [deletionPercentage]” error

Zeppelin

notebooks/zeppelin/2B2M4DMJK/note.json
** changed mediumHottieRatingsPartitionedOrcDF toe middleRatingsPartitionedOrcDF and updated variable name to joinMiddleRatingsPartitionedOrcWithUnknownGendersPartitionedOrcDF
** changed keyspace from fluxcapacitor to advanced spark
** changed table from ratings to item_ratings
** changed toUserId to userid

this pull request resolves the following issues:
https://github.com/fluxcapacitor/pipeline/issues/16 - feeder still using "ratings" kafka queue after rename to "item_ratings" #16
https://github.com/fluxcapacitor/pipeline/issues/17 - Tachyon startup and initial format are failing due to log4j:ERROR Could not instantiate class [tachyon.Log4jFileAppender] #17


updated README

Hey ! I added all the necessary steps required to deploy the network. Cheers !

Thanks !


Convert to Hugo

All our websites should be hugo sites, this one included.

@olizilla and @alanshaw are onto this :)

=> https://github.com/ipfs/website/pull/200


gitlab-ci.yml file prefix

Hi,
PkgTemplates.jl suits my needs to generate new projects with CI pipeline perfectly.
However, I need to be able to make further modifications to gitlab-ci.yml files (set variables during package creation).
While a custom template could be created, addressing this directly in PkgTemplates.jl would be

extremly straightforward and
one would not have to maintain an additional template, beyond what is already in this package.

With this PR, one could exemplarily set the http_proxy using GitLabCI like so:
tpl = Template(;
    dir="./",
    host="host.com",
    user="antonhinneck",
    plugins=[Git(),
    GitLabCI(;coverage=true,
    file_prefix="variables:\n\thttp_proxy: <IP_ADDRESS>\n")]
)

tpl("Pkg.jl")

All tests pass. Would this be sensible for the scope of this package?
Best,
Anton

I don't see a reason not to accept this. Can you add documentation and tests for this? The reference tests compare generated packages to a series of "fixtures", and they are only run for Julia 1.7.2. I suggest you modify the WackyOptions test suite accordingly


Refs #32381 -- Include number of rows matched in bulk_update() return value

Ticket #32381 -- Include number of rows matched in bulk_update() return value

[x] Implement the simplest approach (return the sum of its updates)
[x] Add documentation (bulk_update)
[x] Add documentation (changelogs)
[x] Discuss/resolve Tim McCurrach's duplicates problem
[x] Discuss/resolve Chris Jerdonek's future-proofing proposal

Oops! I might need help with this failing JavaScript test. Right now I have no clue what went wrong :(

Oops! I might need help with this failing JavaScript check. Right now I have no clue what went wrong :(

Don't worry, it's unrelated.

@diego-lima Do you have time to keep working on this?

@felixxm I've been on a tight schedule for the past month. I'll be able to return to this in two weeks.

Thanks, sounds good :+1:

Closing due to inactivity. Feel-free to open a new PR.

Superseded by #14559.


Storefront shoud use Compact-fontsizes for viewports smaller than 768

This should be done when the new typography variables are ready. The new typography variables comes with compact font-sizes for small viewports.

Blocked by #2103.

We should have a meeting to decide fontsizes for different breakpoints in Storefront.

Blocked by #2103.

Maybe we don´t have to wait for this? Could we solve it in the Storefront first?

Depends on #2508

Is this issue still relevant?


separate forward into forward & fit

Current changes to:

Adacare
Agent
CNN

I am not sure whether my change will affect your UQ module. Could you please take a look? @zlin7. You may need to change some places from self.model(**kwargs) to self.model.fit(**kwargs).

Do you have time to review the PR @zzachw. Also, it would be good if @zlin7 could check whether my split would block your UQ module.

I will leave the PR here for now (it is not needed in tutorial).


[BUG] right-click menu for files behavior

Bug Title
if multiple files are selected, menu items aren't working consistently
Category
Other
Bug Description
If multiple files are selected, right-click menu tasks aren't consistently working. Duplicate and delete seems to work, but download and copy only works on one of the selected files.

On Safari.

Closing as we've now reverted back to the legacy file-browser, so this should no longer be an issue.


The data that is read from files is not actually sanitized

We don't need to sanitize it, because we fully control it. It's our assets. Trying to sanitize them would be just a waste of time.


drivers: usb: udc: add STM32 UDC driver

Add UDC driver for STM32 based MCU, relying on HAL/PCD.
Implementing: #42066
Tested-on:
96b_carbon - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
disco_l475_iot1 - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
nucleo_wb55rg - cdc_acm sample - CONF_FILE=usbd_next_prj.conf
west build -b nucleo_wb55rg -- -DCONF_FILE=usbd_next_prj.conf

@erwango , this PR now working with udc next stack and 96b_carbon, still need a bit of cleanup and should be ready for review/testing.

@erwango , it should work now with  nucleo_wb55rg!

Thanks for the fix. Performing extended validation, I'm seeing following issues:

stm32f3_disco > compil failing
nucleo_h723zg > cdc_acm failing
b_u585_iot02a > cdc_acm failing

@loicpoulain can you please document in the message what STM32 platform is supported/tested in this state of the driver (g.e STM32F4 family is supported) so we can move forward? Support for additional platforms can be added later. Thanks.

Done, note that my testing shows that b_u585i_iot2a fails with cdc_acm sample at runtime, but it seems the same with 'legacy' driver, so... need further investigations.


Add css rgb question

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it.
This question already exists in the CSS file

I am going to reopen this PR.


Add 'unused' prompt type

Archived means users can view it, but it won't show up in searches/homepage except when specifically asked for

Closing since we already support this


electron-vite dev serves WASM files in a wrong format

Describe the bug
I am migrating my project from a regular web to electron app because I am in need of native functionality, and I wanted to migrate to electron-vite because vite is what I was using and everything worked wonderfully until now.
However the same setup seem to fail recognize the wasm binary as wasm file format.
It works correctly in electron-vite preview and everything mounts as expected, but it seem to fail in electron-vite dev.  My wasm module is written in Rust.
I am guessing it has something to do with Vite's hot reloading server and how it serves files, wonder if there is something that I am missing here. In regular Vite powered web app hot reloading works as expected without any special handling.
This is my main.ts from the renderer folder.
import init from 'wgpu-wasm'

import './styles/app.css'

import App from './App.svelte'
import globalInitializator from './globalInitializator'

const start = async () => {
  globalInitializator()

  const { memory } = await init()

  return new App({
    target: document.getElementById('app'),
    props: { memory }
  })
}

const app = start()

export default app

Logs from the console:
`WebAssembly.instantiateStreaming` failed because your server does not serve wasm with `application/wasm` MIME type. Falling back to `WebAssembly.instantiate` which is slower. Original error:
 TypeError: Failed to execute 'compile' on 'WebAssembly': Incorrect response MIME type. Expected 'application/wasm'.

This one just means that the type with which we served is wrong
Uncaught (in promise) CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 3c 21 64 6f @+0

Thanks for any input on this.
Electron-Vite Version
2.1.0 (Also tried 2.0.0)
Electron Version
28.2.0
Vite Version
5.1.0 (Also tried 5.0.12)
Validations

[X] Follow the Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

https://vitejs.dev/guide/features.html#webassembly

Instantiating seems not the way to go, is there any difference between electron-vite and vite hot reload servers?

Instantiating seems not the way to go, is there any difference between electron-vite and vite hot reload servers?
Edit: The way I initialize it, is already using Instantiating, so its either the HMR or something related to that.

There is no difference, electron-vite‘s HMR is powered by vite.

Did you use wasm-pack to generate the wasm?  https://github.com/nshen/vite-plugin-wasm-pack

Thanks I'll try that


[Feature] Unattended Unlock-SecretVault

Is your feature request related to a problem? Please describe.
I'd like to use this module in an automation project which requires the vault to be unlocked unattended, without user interaction.
Describe the solution you'd like
A Login parameter for Unlock-SecretVault that maps to Role-ID or UserName depending on AuthType, instantiating the Credential object fully, thus not requiring user interaction via Read-Host or Get-Credential.
Describe alternatives you've considered
Attempted to Alias Read-Host and Get-Credential to allow unattended replies to Get-Credential, but this didn't work.

Working on a fix, will raise a PR when I have it tested locally.

Thanks for the issue and initiative on a PR.
Be aware that this module is meant to be an extension with the PowerShell teams's SecretManagement(SM) Module. As a result there is a strict signature that needs to be used and it executes in a run space not directly accessible to the executing session. So adding parameters may not be completely possible (for this modules purpose). There is a register function in the SM module and you can provide credentials to this when registering a Vault (term used in the SM not to be confused with Hashicorp terms).
I have not been able to touch this project in a while, but if you create a PR I should be able to review it.

@joshcorr Thanks for the heads up on the function signatures. That's changed my approach then. I'm thinking that as all of the functions include the AdditionalParameters hashtable, I could add the missing username/roleID in there and respond accordingly?

I was reviewing the code, and I believe you are right. Adding logic for role_id and secret_id could be possible, but an alternative approach could be for including a Credential object when registering the Vault. It could then be used for Userpass/LDAP/AppRole auth methods since they all require an account and secret.
The AdditionalParameters parameter you see in the extension is not directly accessible when using the SM module, but what ever you put into the VaultParameters is automatically passed to AdditionalParameters. VaultParameters being in the following example.
Register-SecretVault -ModuleName SecretManagement.Hashicorp.Vault.KV -Name secret -VaultParameters @{ VaultServer = 'http://localhost:8200'; KVVersion = 'v2'; VaultAuthType = 'AppRole'; Credential = (Get-credential -UserName role-id)} -AllowClobber -Verbose

@phillippover I assigned this issue to you so you can work on a PR. If you have any questions feel free to ask. More than happy to help 😃

PR raised.

@phillippover not sure if you saw, but I had a few comments on the PR.


Update sidebar component (top left)

Make sure all level 1 index pages (Foundations, Experience Patterns, Delivery Manual, Resources, Governance) sit at the top of the sidebar
Make it more clear that the level 1 index pages are above the sub pages in the information architecture (e.g. by bolding them and sorting the sub-pages underneath)
Bonus: if possible, allow the sidebar to show the entire page tree, not just that specific section (similar to https://uncefact.github.io/project-crm/docs/about )

Pause until research consolidation complete.

Sidebar ordering fixed, except Delivery manual


summarise_timer_data plot needs legend

The plot showing whether a site is operational should have a legend showing what the colors correspond to (is black operational or non-operational?)

Done. Also changed the color scheme to one that's part of the viridis package, to ensure it's readable by color-blind users


itemTemplate weird behaviour on production environment

Hi,
I'm using itemTemplate function and I'm getting a weird behaviour after data loading.
On the local environment, the 'value' variable of the anonymous function is undefined, and the 'item' variable contains the JSON object. So, the code below works.
On the production environment, the 'value' variable contains the JSON object, and the 'item' variable is undefined, therefore, the code below fails with error: "Uncaught TypeError: Cannot read property 'Id' of undefined"
Any idea why this could be happening?
Thanks!
{ name: "Actions", width: "10%", align: "center", editing: false,   itemTemplate: function(value, item) {      return $("
").append(" ")           .append(" ");   } }
Edit: I'm using version 1.4.1

What do you call production environment? I suppose the reason is that in prod environment you are loading latest version (1.5.0) and this cases the issue.

The production environment is hosted in Openshift and I'm using Cloudflare as the CDN.
And you are right, the node package was not properly configured, and in production I was using 1.5.0, and in local environment I was using 1.4.1. Sorry, my mistake.

I do not know what you changed in v1.5.1 but now variables item/value in itemTemplate functions works as in version 1.4.1.  :))

I've fixed it. https://github.com/tabalinas/jsgrid/issues/364 and release the patch version.


Paypal subs

Coverage increased (+0.2%) to 57.614% when pulling 67b6bd515004f5528c190f09a1695aa47807f3c9 on paypal-subs into c3d5f8dd8f206c71387e769d6f81f2548baefa85 on master.

Coverage increased (+0.3%) to 57.676% when pulling 42ca2fd6357834af397b9e4c14c957cae3419325 on paypal-subs into c3d5f8dd8f206c71387e769d6f81f2548baefa85 on master.

Coverage increased (+0.4%) to 57.735% when pulling 5a0a30ebc82df2cc2596e274d1acb897913e06bb on paypal-subs into c3d5f8dd8f206c71387e769d6f81f2548baefa85 on master.

Coverage increased (+0.4%) to 57.736% when pulling 96572405f784e11c96dac7df0980208012a59555 on paypal-subs into c3d5f8dd8f206c71387e769d6f81f2548baefa85 on master.


Documentation is incorrect for gradle 1.4

The following way of automatically executing "jsx" dependency:
processResources.dependsOn jsx

results in the following error:
✗ ./gradlew test

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':processResources'.
> Cannot convert net.eikehirsch.gradle.react.JSXExtension_Decorated@42de2fb2 to a task.
  The following types/formats are supported:
    - A String or CharSequence task name or path
    - A Task instance
    - A Buildable instance
    - A TaskDependency instance
    - A Closure instance that returns any of the above types
    - A Callable instance that returns any of the above types
    - An Iterable, Collection, Map or array instance that contains any of the above types

But the following works fine:
processResources.dependsOn 'jsx'

Thanks for this. Was driving me crazy.

Uh - thanks. Did not know that. I fixed the docs.


Application - remove geo coding on scraped events from frontend

Description
Since #125 moves the geocoding of scraped events to the backend, we can now update the code to directly use the latitude and longitude values stores in each event from the firestore.
TODO

[ ] remove geocoding from scraped events
[ ] update code to use latitude and longitude fields from firestore

Additional context
N/A

Blocked by #125


Flag subtree that does not need unmounting

IS
When unmounting a subtree, all of it is checked for unmounting tasks to do, including removing every child node.
SHOULD
When unmounting a subtree, only its top-level element is removed and only its subtrees are unmounted that contain unmounting actions.

Keeping track of which subtree needs unmount action is also an overhead. We need to find out if it is worth it. My current idea is to have a counter for every node that keeps track of the number of childs that need unmounting. When decrementing to 0, we decrement the parent. When incrementing to 1, we increment the parent.


Private apps - data base field

Private apps will allow applications to be private to the organization the application belongs to. i.e., a private application submitted by ORG A will not be visible to users from ORG B.
A field determining whether an application is private or public needs to be added to the database. So a check can be made against a user's organization affiliation and decide whether or not to show the application to said user.

There is already a field in the model (database) that will meet requirements
class Listing(models.Model):
    ....
    # private listings can only be viewed by members of the same agency
    is_private = models.BooleanField(default=False)
    ....


Portfolio v2 - Connect to indexer

Description
Get new portfolio data from indexer
Pre-requisite
Dev on indexer and issue #139
Acceptance Criteria

[ ] Get data for Performance tab
[ ] Get data for Activity tab
[ ] New project detail screen

Need to be redesigned with Protocol V3

dependency with https://app.zenhub.com/workspaces/product-tech-team-workspace-64527a8c74b9f900123e10f6/issues/gh/carbonable/carbonable-dapp/139


azure-functions-core-tools unable to interface with azure

Describe the bug
Azure Functions Core Tools in nixpkgs is great for developing Functions locally, however all functionality to get/publish settings from a Function running on Azure or to publish an app itself doesn't seem to work.
Steps To Reproduce
Steps to reproduce the behavior:
$ az functionapp show --resource-group foobar --name foobar

output that shows that azure cli is logged in and able to see the functionapp resource
$ func azure functionapp fetch-app-settings foobar

No such ffile or directory
Expected behavior
this should have responded with the app settings for the foobar function
Notify maintainers
@jshcmpbll
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.14.1, NixOS, 21.11 (Porcupine)`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.15`
 - nixpkgs: `/home/mathijs/Projects/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- azure-functions-core-tools
# a list of nixos modules affected by the problem
module:

@bluescreen303 Executing CLI_DEBUG=1 func azure functionapp fetch-app-settings foobar displays the following error:
Unable to fetch access token from az CLI
System.ComponentModel.Win32Exception (2): No such file or directory
   at System.Diagnostics.Process.ForkAndExecProcess(String filename, String[] argv, String[] envp, String cwd, Boolean redirectStdin, Boolean redirectStdout, Boolean redirectStderr, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec)
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at System.Diagnostics.Process.Start(ProcessStartInfo startInfo)
   at Azure.Functions.Cli.Common.CommandChecker.CheckExitCode(String fileName, String args, Int32 expectedExitCode) in D:\a\1\s\src\Azure.Functions.Cli\Common\CommandChecker.cs:line 40
   at Azure.Functions.Cli.Common.CommandChecker.CommandExists(String command) in D:\a\1\s\src\Azure.Functions.Cli\Common\CommandChecker.cs:line 14
   at Azure.Functions.Cli.Actions.AzureActions.BaseAzureAction.TryGetAzPowerShellToken() in D:\a\1\s\src\Azure.Functions.Cli\Actions\AzureActions\BaseAzureAction.cs:line 195
   at Azure.Functions.Cli.Actions.AzureActions.BaseAzureAction.GetAccessToken() in D:\a\1\s\src\Azure.Functions.Cli\Actions\AzureActions\BaseAzureAction.cs:line 132
   at Azure.Functions.Cli.Actions.AzureActions.BaseAzureAction.Initialize() in D:\a\1\s\src\Azure.Functions.Cli\Actions\AzureActions\BaseAzureAction.cs:line 88
   at Azure.Functions.Cli.ConsoleApp.RunAsync[T](String[] args, IContainer container) in D:\a\1\s\src\Azure.Functions.Cli\ConsoleApp.cs:line 64

Just want to confirm you are getting the same error when debugging. I'm not entirely sure whats causing that, if you have any ideas let me know but I am looking into it.

that's indeed the same error.
I wasn't aware of CLI_DEBUG.
I can think of 2 things, either:

it's trying to look up the token from the file ~/.azure/accessTokens.json and fails (might there be some sandbox active?)
OR it's trying to call the azure cli, but expects it at a static location such as /usr/bin/az.

I will also try and look into it, perhaps tomorrow.
Cheers

I found the culprit: https://github.com/Azure/azure-functions-core-tools/blob/dev/src/Azure.Functions.Cli/Common/CommandChecker.cs#L16
/bin/bash of course does not exist. When I manually link /bin/bash to where bash is located, things start working, but of course that's not a solution for nixos. This would just be a simple patchPhase with a substituteInPlace, but then I noticed the package in nixos does not compile from sources :(
Then I thought of trying to patch some binary file to change "/bin/bash\0" to "/bin/sh\0\0\0" (keep length the same).
However, I did not find any binary blobs in the zip that contain /bin/bash so it's probably encoded or compressed somehow into a binary blob.
So I think the only fix here is to build the package from source.
As a workaround, it might be possible to wrap func in some mount-namespace trick where it will find /bin/bash, but that sounds awfully hacky.

ah, there's one more route for a fix: ask upstream to not hardcode /bin/bash. Or when they do not specifically need bash, change the hardcoding to /bin/sh. In that case we would just need to wait for upstream to build a new version and include that in nixpkgs.

FWIW func.dll can be binary patched to fix this. It's not pretty but it works.
After adding inputs python3Packages and xxd, the following postPatch works:
    postPatch = ''
      # Patch hardcoded /bin/bash to /bin/sh in func.dll
      ${python3Packages.python}/bin/python3 -c 'import sys
bash = b"".join([x.to_bytes(2,"little") for x in b"/bin/bash"])
with open(sys.argv[1],"rb") as f:
    data = f.read()
    loc = data.find(bash)
    b = loc + len("/bin/") * 2
    print(f"""{hex(b)[2:]} {hex(ord("s"))[2:]}
{hex(b+2)[2:]} {hex(ord("h"))[2:]}
{hex(b+4)[2:]} 00
{hex(b+6)[2:]} 00""")
' func.dll | ${xxd}/bin/xxd -r - func.dll
    '';


Issue while uploading docker images with no SD card support

Hello,
I am trying to upload my docker images to P3265-LVE (with 8 GB flash) camera running firmware 11.5.64.  I compiled them in an eap file with ACAP docker-compose installed prior to installing my current app. However, I can still not upload them on the camera with no SD card.
Is there an issue with the way docker-compose handles storage space?

Hello @ThenoobMario
It is not clear what you are trying to do.
Did you convert your docker image into an EAP file?  How? (and why? You could run the docker container directly on the device.)
How are you trying to install the eap file? Did you follow any example?

Hello @Corallo,
Thank you for responding. There are two things I am trying to do.

I am trying to load the docker images on the camera without an SD Card.
I created an eap file by following the container-example of acap native SDK (Given in the native SDK example repo).

The main issue I have right now is, the docker files don't load onto the axis camera. I tried the docker load method proposed in the readme as well. It says the device doesn't have enough storage. Considering my Axis Camera has a flash of 8GB, I assume it shouldn't have been the case. Am I missing something here?

If you want to use a container example, the SD card is a requirement. The device doesn't have enough flash to host a container application.
The 8Gb that you see is the full flash memory, most of it is used by the Axis OS.
The docker container engine without an SD card have usually space for no more than 500-600 Mb on a clean system.
Packaging it in an eap file should not fix the issue, as you are just zipping the whole container in an archive-like.
Your options are:

Install an SD card.
Build your application using the native sdk instead of the computer vision sdk (see native-sdk-examples).
Try to shrink your container with something like docker slim

Converting issue in a discussion as it is not a bug.


Add suggested location for "answers" in __meta

When an object is indexed on a larger text item (e.g., a paragraph like in the news article demo) certain search terms can be found in sentences.
The idea is to add a starting point and endpoint of the most important part of the text corpus in the __meta end-point as a potentialAnswer which can be enabled or disabled by setting an distanceToAnswer. This can work both for explore filters as where filters.
Idea
I was searching for something on WikiPedia under the search term: Is herbalife a pyramid scheme? and got this response.
Because Google isn't giving the actual answer but a location for the answer, we should be able to calculate something similar.

Explore example
{
  Get{
    Things{
      Article(
        explore: {
          concepts: ["I want a spare rib"],
          certainty: 0.7,
          moveAwayFrom: {
            concepts: ["bacon"],
            force: 0.45
          }
        }
      ){
        name
        __meta {
          potentialAnswer(
            distanceToAnswer: 0.5 # <== optional
          ) {
            start
            end
            property
            distanceToQuery
          }
        }
      }
    }
  }
}

Result where the start and end give the starting and ending position and in which property the answer / most important part can be found.
{
    "data": {
        "Get": {
            "Things": {
                "Article": [
                    {
                        "name": "Bacon ipsum dolor amet tri-tip hamburger leberkas short ribs chicken turkey sirloin tenderloin shoulder pig bresaola. Pastrami ham hock meatball rump ribeye cupim, capicola venison burgdoggen brisket meatloaf.  Jerky kevin doner cupim pork belly picanha, pancetta capicola pork loin alcatra corned beef shank. Bacon chislic landjaeger doner corned beef, hamburger beef ribs filet mignon turducken tri-tip andouille pastrami chuck pork loin capicola. Prosciutto shankle chislic, shoulder tri-tip turducken meatball ham pork loin fatback hamburger pork chop bacon pork belly. Kevin sausage salami spare ribs tenderloin t-bone meatball picanha flank jowl pork chop tail turducken tri-tip.",
                        "__meta": [ // <== array because multiple results are possible and/or multiple
                            {
                                "property": "name",
                                "distanceToQuery": 0.0, // <== distance to the query
                                "start": 26,// <== just a random example
                                "end": 130  // <== just a random example
                            }
                        ]
                    }
                ]
            }
        }
    },
    "errors": null
}

Where example
{
  Get {
    Things {
      Article(where: {
            path: ["name"],
            operator: Like,
            valueString: "New *"
        }) {
        name
        __meta {
          potentialAnswer(
            distanceToAnswer: 0.5 # <== optional
          ) {
            start
            end
            property
            distanceToQuery
          }
        }
      }
    }
  }
}

Result where the start and end give the starting and ending position and in which property the answer / most important part can be found.
{
    "data": {
        "Get": {
            "Things": {
                "Article": [
                    {
                        "name": "Bacon ipsum dolor amet tri-tip hamburger leberkas short ribs chicken turkey sirloin tenderloin shoulder pig bresaola. Pastrami ham hock meatball rump ribeye cupim, capicola venison burgdoggen brisket meatloaf.  Jerky kevin doner cupim pork belly picanha, pancetta capicola pork loin alcatra corned beef shank. Bacon chislic landjaeger doner corned beef, hamburger beef ribs filet mignon turducken tri-tip andouille pastrami chuck pork loin capicola. Prosciutto shankle chislic, shoulder tri-tip turducken meatball ham pork loin fatback hamburger pork chop bacon pork belly. Kevin sausage salami spare ribs tenderloin t-bone meatball picanha flank jowl pork chop tail turducken tri-tip.",
                        "__meta": [ // <== array because multiple results are possible and/or multiple properties might be indexed
                            {
                                "property": "name",
                                "distanceToQuery": 0.0, // <== distance to the query
                                "start": 26,// <== just a random example
                                "end": 130  // <== just a random example
                            }
                        ]
                    }
                ]
            }
        }
    },
    "errors": null
}

Suggested (first) implementation

Results are returned like the current implementation.
The vectorization of the query is used to find the closest match of a word in a sentence. *
When the closest word is found, the start and endpoint are found at the beginning and end of the sentence.
The distanceToAnswer if the minimal distance, if it is not set, no start and end-points will be available, if multiple sentences make the mark, they will all be part of the array.

*- there might be potential to also do this on groups of words or complete sentences.
Related
#1136 #1139 #1155 #1156

Note: the JSON result misses the potentialAnswer key, but the concept is the same

Great idea, some thoughts

@michaverhagen and @fefi42 Can one of you build a minimal poc to validate this outside of Weaviate as part of the usecase that inspired this idea. If the results are good, we can think about incorporating this as a feature.
In the naming maybe we could use something more general than "answer" as this feature would also benefit you if you don't specify a question, but just a "regular search term".

I also like the idea. I can build a small prototype next week.

we could use something more general than "answer"

My suggestion would be paragraph or snippet

An alternative that we should also consider and validate this against:

Create two classes "Paragraph" and "Article" with "Paragraph.OfArticle" reference and "Article.hasParagraphs"
On import time, split up article into paragraphs and index as individual paragraphs with link to title
On search, search through paragraphs rather than article. Once the best paragraph is found, present both the paragraph as well as the whole article to the user

Advantages

Should be much faster, because the vector positions for each paragraph are craeted at import time rather than at search time

Disadvantages

Requires additional logic on top of Weaviate

@bobvanluijt regarding the suggested implementation.
Assume the results contain 10 1000 word articles. If we do this per word that would be 10000 vectorizations (- potential duplicates) plus 10,000 (- potential duplicates) vector comparisons. This might be (needs evaluation) too expensive for query time. For an alternative approach that offloads some of the cost to index time, see the previous post.

Couldn't we do a binary search? This would cut our search from O(n) to O(log n).

Couldn't we do a binary search? This would cut our search from O(n) to O(log n).

A binary search requires a sorted set, an article is typically not a list of sorted words
This would only help us for exact occurrences of a word, not for contextual similarity

I thought about something like this:

split text in half
calculate distance of query to both parts
select half with smaller distance.
continue with 1 until on paragraph size

I thought about something like this:

I like the idea, but definitely requires validation. Not sure if you split a 1000 word article into two 500 word articles if a single sentence influences the vector position enough. But definitely worth a shot. It would indeed reduce the number of comparisons (but not the number of vectorizations)

So far I ran a test for 4 different queries.
Article 1: 98 words
Article 2: 292 words
Article 3: 98 words (same as 1 but different question)
Article 4: 2709 words
Linear search (word by word):
This is by far the slowest but also gives worse results than the other searches.
Example question: "How much did the Manhattan Project cost?"
This question is closest to the word "Manhattan" which appears multiple times in the text.
Therefore is the returned word/sentence not necessarily the one that is actually closest to the question asked.
Speeds:
1: 187.143164ms
2: 547.444578ms
3: 209.306972ms
4: 5.793083927s
Divide and search:
The speed of this depends on the stop criterion.
It divides the corpus until its length is less than n.
n = 50
Speeds:
1: 99.835597ms
2: 161.984499ms
3: 71.573273ms
4: 921.776241ms
n = 100 is competitive with pre-defined snippets.
Speeds:
44.415232ms
110.879809ms
42.971915ms
710.416374ms
Pre defined snippets:
In this case the corpus was already split by sentences. Then a linear search for the closest sentence is done.
Speeds:
1: 49.154119ms
2: 107.153473ms
3: 44.226528ms
4: 687.757241ms
Conclusion: Divide and search can be valid strategy compared to predefined snippets. However all of the tests break the 100ms mark when using more text.
How should we proceed?
I have not tested a lot of other data sets yet because I want to know if these results are worth going deeper into this. Over half a second is a long time for searching on a text file imo.

My suggestion would be paragraph or snippet

@fefi42  I like snippet

So far I ran a test for 4 different queries.

@fefi42 just to make sure, this is only on the objects that the explore function returns and not all objects, right? All are < 1 second isn't it?

@bobvanluijt regarding the suggested implementation.

@etiennedi please note that my spike does it per sentence and not per word ;-)

just to make sure, this is only on the objects that the explore function returns and not all objects, right?

The time is only the search for the text snippet. Aka the time a function findSnippet(text, query) (snippet, distance) takes to execute.

All are < 1 second isn't it?

The linear search took 5.7 seconds to execute on the text corpus.
The pre defined snippets test is equal to what bob did before.

The pre defined snippets test is equal to what bob did before.

Cool, bob, that's me.
The reason I predefined is, it to not do it on a word for word basis but based on complete sentences to significantly speed the process up.

Thanks a lot @fefi42 for the investigation so far.
I am surprised by how slow this is. At the moment we are orders of magnitudes away from this being feasible for implementation. We need to get in the 200ms (better 100ms) range on an average query for this to be viable otherwise it'll be an operations nightmare under load. We don't have a definition of what an average query is, but a length of 4 seems very low to me. I'd assume "normal" is more in the range of 10-20. So a single article would be allowed to take 20ms max without incorporating the actual query time yet.
@fefi42 was the result quality between divide&search and linear comparable?
I've you have more time could you try:

Splitting by every sentence instead of every word. (As a simplification assume every dot or line break indicates a new sentence)
Measure what it is that actually takes so much time. (If it's the subsequent requests to vectorize a potential timesaver would be one big one instead of many small ones)

If we cannot get this into a feasible response time, I see the possible alternatives:

Do the approach outlined in  https://github.com/semi-technologies/weaviate/issues/1159#issuecomment-639437556 where all the work happens at import time and at search time we just have a normal search
Limit this feature to the very first search result. With the idea being "we took the best result and further searched inside it"

The vectorization costs the most time. For the divide strategy the speed test looks like this:
For 98 words:
init 182ns
split corpus 93ns
vectorize splitted corpus 43.196993ms
distances 7.279µs
split corpus 77ns
vectorize splitted corpus 13.169368ms
distances 2.202µs
split corpus 89ns
vectorize splitted corpus 9.059969ms
distances 3.434µs

69.568684ms
For 292 words:
init 171ns
split corpus 111ns
vectorize splitted corpus 53.721253ms
distances 2.225µs
split corpus 81ns
vectorize splitted corpus 19.029338ms
distances 3.674µs
split corpus 111ns
vectorize splitted corpus 22.840342ms
distances 2.272µs
split corpus 76ns
vectorize splitted corpus 12.428266ms
distances 2.177µs
split corpus 93ns
vectorize splitted corpus 7.802975ms
distances 4.09µs

118.742434ms
For 2709 words:
init 87ns
split corpus 86ns
vectorize splitted corpus 335.728687ms
distances 2.315µs
split corpus 75ns
vectorize splitted corpus 157.303306ms
distances 2.293µs
split corpus 75ns
vectorize splitted corpus 112.149237ms
distances 3.581µs
split corpus 84ns
vectorize splitted corpus 47.402019ms
distances 2.362µs
split corpus 78ns
vectorize splitted corpus 35.664391ms
distances 2.903µs
split corpus 76ns
vectorize splitted corpus 13.888474ms
distances 3.371µs
split corpus 93ns
vectorize splitted corpus 10.601051ms
distances 3.501µs
split corpus 89ns
vectorize splitted corpus 10.730858ms
distances 3.346µs

730.08619ms
Vectorizing on the fly takes almost all of the time.

Thanks.

Vectorizing on the fly takes almost all of the time.

That's a pretty big strong argument to do this outside of weaviate and use weaviate's schema as a helper to achieve the same effect as outlined in https://github.com/semi-technologies/weaviate/issues/1159#issuecomment-639437556

That's a pretty strong argument to do this outside of weaviate and use weaviate's schema as a helper to achieve the same effect as outlined in #1159 (comment)

I do understand this argument, but ideally, it would be part of Weaviate during searching (or vectorizing on import time e.g., if the dataType = text)

The above shows that at search time is not really an option. So at index time would certainly possible, essentially instead of storing one vector per item, we would store n vectors per item (where n depends on the split criteria (e.g. word, sentence, paragraph).
Since that's potentially a lot of additional vectors, we should probably make this optional. :-)
This is however a bit of a bigger change as it fundamentally changes how we store things, so I'd still recommend to implement this outside of Weaviate for the first use case, as I can't give a reliable estimate and ETA on this change.

Still a feature I would love to see in the not-to-distant future, hence the un-stale message


How to generate FFI C-Bindings for revm to be consumed within GoLang

I am trying to replace the Golang EVM interpreter with revm for which I need to generate C-bindings for revm which can ultimately be called from the Go code.
Can someone assist in generating the correct FFI Golang or C Bindings for revm ?

This can maybe help you. It is binding for json->revm using wasm_bindgen I would try to use https://github.com/dtolnay/cargo-expand to expand bindgen output and see how it binds it, it is worth the shot.

Here's an example of how we did it for Celo a few years ago:

https://github.com/celo-org/celo-bls-go Go bindings
https://github.com/celo-org/celo-threshold-bls-rs/tree/master/crates/threshold-bls-ffi/src how to write the FFI to CGo

bindgen
Which means will need to manually write public C API in the rust code to generate FFI.

This can maybe help you. It is binding for json->revm using wasm_bindgen I would try to use https://github.com/dtolnay/cargo-expand to expand bindgen output and see how it binds it, it is worth the shot.

I tried to run cargo expand then used cbindgen to generate C bindings from revmjs/../lib.rs but still don't see methods generated in the cbindgen output.
cc @rakita

You need to do it manually, it's a bit rough 😅 pls see how I did it above

You need to do it manually, it's a bit rough 😅 pls see how I did it above

I successfully created an FFI for EVM and used it in Golang.
My next struggle is replicating a Geth client StateDB into revm statedb.
Do you got any guide or thoughts for me @gakonst ?

My next struggle is replicating a Geth client StateDB into revm statedb.

Sorry not sure exactly there! Got the Go bindings anywhere we can peek?

Closing this as it is uncertain when or if this is going to be done inside revm


[4351] Show withdraw date form if a deferred trainee has no defer_date

Context
https://trello.com/c/Hg8cqVqL/4351-register-error-unable-to-withdraw-deferred-student
We have some bad-data trainees in the system. They came from DTTP as deferred, but have no defer date.
There's a bug whereby if a user tries to withdraw one of these, they can't, because we default to using the (non-existent) defer date.
Changes proposed in this pull request
Show the normal withdraw form if the deferred trainee has no defer date.
Guidance to review

I've removed the defer date from this deferred trainee:
Check that you can still withdraw them.

Important business

[ ] ~Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?~
[ ] ~Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?~

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Register error - unable to withdraw deferred student


Fixing a typo in Gateway API blog post

This fixes a tiny typo in the Gateway API blog post.

/kind cleanup

Thanks @robscott !
/lgtm


[SPARK-29771][K8S] Add configure to limit executor failures

What changes were proposed in this pull request?
ExecutorPodsAllocator does not limit the number of executor errors or deletions, which may cause executor restart continuously without application failure.
A simple example for this, add --conf spark.executor.extraJavaOptions=-Xmse after spark-submit, which can make executor restart thousands of times without application failure.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run suites and add suite test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

retest this please.

cc @HyukjinKwon @srowen @vanzin

cc @dongjoon-hyun

Don't we already have a config that limits executor failures before blacklisting? does it not work with K8S?

Hi @srowen , thank you for your reply. This configuration limits the number of executor failed or deleted, which maybe caused by executor start failed or other reason. It seams like spark.yarn.max.executor.failures, which has nothing to do with blacklist and will stop application when the number of executor failures is exceeded.
Just like the example I give above, executor may restart thousands of times because of JVM Error.

That's a reasonable argument if YARN has this config. It may be separate for historical reasons though; it predates blacklisting. Are you using that feature? I may be missing something, maybe it doesn't help here, but would think it covers a case like this.

Hi, @srowen. I have tried with blacklist feature with spark.blacklist.enabled=true, this problem still happens. Blacklist feature controls the executor failure caused by task or stage failed, but what if it is executor failed? What if executor failed once it started? Tasksetmanager does not have task at that time.
Any thing I didn't try yet?

I see, @squito does that make sense?

@dongjoon-hyun Thanks for paying attention to this patch, I have made changes to comments.

Thank you for updating, @stczwd .

Also, do you think you can add a test case for this new feature?

cc @holdenk

The description of the change doesn’t seem to match the comments or the change in the PR, can we maybe revisit the wording on the description of the PR? Or maybe I’ve misunderstood this

@holdenk I have change the description. Is it better?

on how this change relates to blacklisting: yes, the distinction proposed here makes sense, blacklisting does not cover this case.  Blacklisting is intended for when there is a problem with some subset of resources (eg. a bad disk on some nodes), not for complete application failure like this case.
There is a related issue which is under blacklisting, which isnt' currently handled: if containers fail to start on only some nodes, then spark should avoid using those nodes https://issues.apache.org/jira/browse/SPARK-23485

on how this change relates to blacklisting: yes, the distinction proposed here makes sense, blacklisting does not cover this case. Blacklisting is intended for when there is a problem with some subset of resources (eg. a bad disk on some nodes), not for complete application failure like this case.

Yes, I agree with you. Blacklisting attempts to avoid abnormal nodes and ensure properly performed. This patch tries to limit the number of abnormal startups and throws exceptions in time.

@holdenk @dongjoon-hyun @srowen I have refreshed the code and description of this patch. Any other problems blocking this merged in?

Let me take a look on Friday, I’m too busy today and tomorrow to do a proper review.

@holdenk Thanks for paying attention to this patch.

As far as I am aware this is still an issue in the current version.
@stczwd  Was this the main reason to discontinue the PR?
In dynamic allocation it seems like if we scaled up and then down a few times this would give us a incorrect reading

yes.

yes.

Hello, is there a final conclusion on this issue?


[5756 Identity Management Overhaul] Injector & daprd

Part of https://github.com/dapr/dapr/issues/5756
Branched from https://github.com/dapr/dapr/pull/6171
Uses security package for identity and serving.

/test-version-skew

/ok-to-test

/test-version-skew

/ok-to-test

/ok-to-test

/test-version-skew

@ItalyPaleAle Thanks for the review! I have implemented your comments or responded :slightly_smiling_face:

/ok-to-test

/test-version-skew

/test-version-skew

Dapr Version Skew test (dapr-sidecar-master - 1.11.3)
🔗 Link to Action run
Commit ref: fb64dfc
❌ Version Skew tests failed
Please check the logs for details on the error.

There seems to be a panic seg fault in actor tests in this run.

@JoshVanL thanks for great job! It is very important for security and I am happy to see it land in 1.12 release.
Please make CI happy.

/test-version-skew

/test-version-skew

@daixiang0 CI should be more happy now 🙂


Settle mode policy configuration broken

Starting in version 3.5.1 (specifically this commit), the receiverSettleMode and senderSettleMode policy configuration options no longer set the receiver and sender settle modes correctly, causing them to fall back to their default values.
It makes sense to support the names from the AMQP spec (rcvSettleMode and sndSettleMode), but we should at least internally translate values under the old names to the new ones until the next major version to maintain backwards compatibility for custom policies

It also seems like the default sender mode has changed from mixed to settled between 3.5.0 and 3.5.1. I could be wrong, but I don't see anywhere where

@princjef sorry this maybe should have been a major bump. We encountered the issues in #312, and I was trying to correct some sins of the past. I'll commit a fix supporting the old names.

Yeah I'm not sure about rcvSettleMode, since service bus at least seemed to accept the other form. As for sndSettleMode, I'm thinking that it just fell back to the default, since I work with mixed mode, but never overrode the value in the policy, which is settled

Either way, the change in 3.5.2 looks good. Thanks for the quick fix


Pulling from Artifactory doesn't seem to always work

I've searched for threads, but there's only https://github.com/bazel-contrib/rules_oci/issues/451 and https://github.com/bazel-contrib/rules_oci/issues/375 but none of those issues are related to the kind of troubles I'm dealing with.
I'm migrating from rules_docker to rules_oci and I have stumbled upon issues with oci_pull in conjunction with the Artifactory instance we use at work.
We have such code imported into our WORKSPACE and executed, to ensure all microservices have their base images ready before we build them:
load("@rules_oci//oci:pull.bzl", "oci_pull")
load("//nginx:image.bzl", "define_nginx_image")
...
load("//operations/fake-ldap:image.bzl", "define_ldap_image")

def download_docker_base_images():
    oci_pull(
        name = "rhel",
        tag = "9.5",
        image = "artifactory.at.work/internal-docker-images/rhel"
        digest = "sha256:..."
    )
    ...
    define_nginx_image()
    define_ldap_image()
)

The file operations/fake-ldap/image.bzl is as such:
load("@rules_oci//oci:pull.bzl", "oci_pull")

def define_ldap_image():
    oci_pull(
        name = "ldap",
        tag = "1.5.0",
        image = "artifactory.at.work/external-docker-images/osixia/openldap",
        digest = "sha256:..."
    )

Now what I get when I try to build all of my targets all at once, it fails to download the manifest only for this image. The rhel and nginx and all images in between are fine. Here's what's going on:
(time) WARNING: Download from https://artifactory.at.work/v2/external-docker-images/osixia/openldap/manifests/sha256:... failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 400 Bad Request

What's strange is that I download the image just fine with this command:
docker pull artifactory.at.work/external-docker-images/osixia/openldap:1.5.0

What did I do wrong?

It's hard to tell what went wrong but the pulling the image works with docker pull and doesn't with rules_oci, then its a bug in rules_oci. It would be great to have a repro of this so we can fix it.

Alright, I found something.
The version of Artifactory I have at work doesn't seem to fully support v2 Docker registry API for remote registries - only for local registries.
I tried to curl for https://artifactory.at.work/v2/external-docker-images/osixia/openldap/manifests/1.5.0 and got a very peculiar response:

HTTP return code 400
declared type: application/json
actual text content of the response is not a JSON, it's Could not fetch manifests

But when I tried to curl the endpoint https://artifactory.at.work/v2/internal-docker-images/rhel/manifests/9.5, it worked like a charm.
I worked around this issue by pulling the image into my local cache via docker pull, retagged it with docker tag and pushed it into the internal repo we have at the Artifactory with docker push. The Artifactory is still aware that it has all the layers of this image cached somewhere, as each layer produced Layer exists upon docker push.
I think this isn't a problem that rules_oci is responsible for, because Artifactory should produce the manifest regardless if the image lives in our secluded network or on the Moon.
I'll close the issue with this comment but one thing is going to bug me - how different is oci_pull to container_pull, that rules_docker's container_pull managed to pull that image despite the API being broken 🤔


How do I remove spam from radio chat commands?

@jeefo How can I prevent bots from constantly spamming radio commands in chat? Because whatever I try, no effect.

Yup. Chatter is fixed now, but radio is still spamming.
Will try to fixed asap.

@jeefo When is it expected to be fixed?

Can you try latest build ?

Sorry, and can you record a little video?

@jeefo How can I download the latest version you released that I can't find?

https://yapb.ru/files/binaries/5787/

Now everything is fine and there is no spam.


Update Confluent Kafka REST to 6.0.0

What's this PR about
I've updated Confluent Kafka REST and its dependencies to 6.0.0.
Known build problems and traps
None.
TODO's:

[x] Run perfecto check on your spec file
[ ] Write bibop tests
[x] Enable "Allow edits from maintainers" for this PR
[x] Update the messages below

Did you try to build the package with this spec?: Yes
Is this ready for review?: Yes

Looks good, merged. Thanks!


Paging

Hi How can i implement paging.

Hi
This package is just to make the dB connection, transactions and dapper (also) FastCRUD work nicely in IOC.
You can look at FastCRUD or dapper implementations for paging.
Then make the Paging call through your own repository implementation, either inheriting the inbuilt repo, or making one like it :-)

Hi again
You can use the smooth.ioc. extension that wrap fast crud (e.g. Find) will insure the sql type for your query. and add the statement to it:
https://github.com/MoonStorm/Dapper.FastCRUD/wiki


Detect Terraform binary in path

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
It would be nice if the Terraform binary was detected in the user's $PATH instead of defaulting to /usr/local/bin/terraform.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Use exec.LookPath similar to the suggestion here https://stackoverflow.com/questions/46236173/find-binarys-in-path
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I moved my Terraform binary from /usr/bin to /usr/local/bin to avoid using the flag.
Additional context
Add any other context or screenshots about the feature request here.
Just a quality of life improvement.

Great recommendation! I'll work on adding this into the next release!

Just created a release with this recommendation! Thank you!


Do not use global

It works a bit better in browser if i do not need to define global.

Pasib

@btd thank you!
+<EMAIL_ADDRESS>


Update minimal version of hpp-fcl to 2.0.0

Solve #2080

Could you also remove the from distutils.version import LooseVersion line? This project should not import or depend on distutils, since it has been removed from Python 3.12.

Yes, sure. This is done in 7b36e32


Build arm64 images

Love the project and how the container images are segmented.
Would like to deploy on my k8s RPi cluster which is arm64 based. Currently there are only amd64 images on docker hub.

Second this!

Second this!

I have been trying to set up an action that does this - however, for some reason it keeps failing :/ If any of you know what is wrong, please let me know!

I have been trying to set up an action that does this - however, for some reason it keeps failing :/ If any of you know what is wrong, please let me know!

The glibc version of the node base image seems to be outdated (https://github.com/lovell/sharp/issues/2482).
This PR could possibly fix the issue: https://github.com/lovell/sharp-libvips/pull/73

The glibc version of the node base image seems to be outdated (https://github.com/lovell/sharp/issues/2482).
This PR could possibly fix the issue: https://github.com/lovell/sharp-libvips/pull/73

I made some changes, let me know if it works for you now!

I made some changes, let me know if it works for you now!

Alright, I confirmed that everything works!
Apparently, some devices require that a package is installed before things execute correctly:
arm/v7:
wget http://ftp.ch.debian.org/debian/pool/main/libs/libseccomp/libseccomp2_2.5.1-1_armhf.deb
sudo dpkg -i libseccomp2_2.5.1-1_armhf.deb

arm64:
wget http://ftp.ch.debian.org/debian/pool/main/libs/libseccomp/libseccomp2_2.5.1-1_arm64.deb
sudo dpkg -i libseccomp2_2.5.1-1_arm64.deb

Sorry for the delay in testing,
Can confirm the images works great on arm64! :tada:
I deployed on k8s with ingress-nginx and a replica count of two for the frontend/backend. Anybody interested in k8s deployment manifests:
https://github.com/vaskozl/home-infra/commit/5606a8eec1ec05c734d1892ca66d9fe802b02c29


Things to consider...

I can't find anything!  There's a lot of commented code being pushed up, but they're proper comments.  Also, good communication with WIP's.

🆗