The score and sound do not match.

The score and sound do not match.
When the score is loaded with "fur-elise.xml" and played back, the following MIDI pitch value is output.
channel -> 0, pitch -> 76, volume -> 60
channel -> 0, pitch -> 77, volume -> 60
channel -> 0, pitch -> 76, volume -> 75
channel -> 0, pitch -> 77, volume -> 60
channel -> 0, pitch -> 76, volume -> 60
channel -> 0, pitch -> 71, volume -> 60
channel -> 0, pitch -> 74, volume -> 60
channel -> 0, pitch -> 72, volume -> 60
channel -> 0, pitch -> 69, volume -> 75
channel -> 0, pitch -> 45, volume -> 75
channel -> 0, pitch -> 52, volume -> 60
channel -> 0, pitch -> 57, volume -> 60
channel -> 0, pitch -> 60, volume -> 60
channel -> 0, pitch -> 64, volume -> 60
channel -> 0, pitch -> 69, volume -> 60
channel -> 0, pitch -> 71, volume -> 75
channel -> 0, pitch -> 40, volume -> 75
channel -> 0, pitch -> 52, volume -> 60
channel -> 0, pitch -> 58, volume -> 60
channel -> 0, pitch -> 64, volume -> 60
channel -> 0, pitch -> 70, volume -> 60
channel -> 0, pitch -> 71, volume -> 60
channel -> 0, pitch -> 72, volume -> 75
channel -> 0, pitch -> 45, volume -> 75
However, if it is normal, it should be as shown below.
channel -> 1, pitch -> 76, volume -> 60
channel -> 1, pitch -> 75, volume -> 60
channel -> 1, pitch -> 76, volume -> 75
channel -> 1, pitch -> 75, volume -> 60
channel -> 1, pitch -> 76, volume -> 60
channel -> 1, pitch -> 71, volume -> 60
channel -> 1, pitch -> 74, volume -> 60
channel -> 1, pitch -> 72, volume -> 60
channel -> 1, pitch -> 69, volume -> 75
channel -> 2, pitch -> 45, volume -> 75
channel -> 2, pitch -> 52, volume -> 60
channel -> 2, pitch -> 57, volume -> 60
channel -> 1, pitch -> 60, volume -> 60
channel -> 1, pitch -> 64, volume -> 60
channel -> 1, pitch -> 69, volume -> 60
channel -> 1, pitch -> 71, volume -> 75
channel -> 2, pitch -> 40, volume -> 75
channel -> 2, pitch -> 52, volume -> 60
channel -> 2, pitch -> 56, volume -> 60
channel -> 1, pitch -> 64, volume -> 60
channel -> 1, pitch -> 68, volume -> 60
channel -> 1, pitch -> 71, volume -> 60
channel -> 1, pitch -> 72, volume -> 75
channel -> 2, pitch -> 45, volume -> 75
Also, channel values are not separated by 1 or 2.
The above values are output from the function below.
void MidiServer::note_on(int channel, int pitch, int volume)

Although in MIDI documentation channels are numbered 1...16, in Lomse software the channel number goes from 0...15  ( c++ heritage  ;-)  ). The same with all other values, the range in lomse starts always at 0.
The channels are assigned to score-parts according to the settings specified in the MusicXML file. For instance:
    <score-part id="P1">
      ...
      <midi-device>Bank 1</midi-device>
        <midi-instrument id="P1-I1">
        <midi-channel>1</midi-channel>
        <midi-program>1</midi-program>
        <volume>80</volume>
        <pan>-70</pan>
      </midi-instrument>
    </score-part>

When a part has no midi settings, it is assigned to channel 0 (MIDI channel 1).
In file fur-elise.xml there is no MIDI settings information, so both parts get assigned to channel 0.
Therefore, I think the output is correct.
Instead of assigning channel 0 to instruments without MIDI settings, other alternatives could be possible, such as assigning a channel to each score-part (what to do if more than 15 instruments? should channel 15 (percussion) be used? ). Thoughts on this are welcomed!

Okay, I understand the MIDI channel. Thank you.
Please take a closer look at the pitch values above.
The correct pitch value is not output.

Thanks! I didn't pay attention to the pitch. It is wrong! I will look at this.

I created a MusicXML file for the channel test.
MIDI information is also included in the xml file.
     <part-list>
	<score-part id="P1">
		<part-name></part-name>
		<part-abbreviation></part-abbreviation>
		<score-instrument id="P1-I-1">
			<instrument-name></instrument-name>
		</score-instrument>
		<midi-instrument id="P1-I-1">
			<midi-channel>1</midi-channel>
			<midi-program>0</midi-program>
		</midi-instrument>
	</score-part>
	<score-part id="P2">
		<part-name></part-name>
		<part-abbreviation></part-abbreviation>
		<score-instrument id="P2-I-1">
			<instrument-name></instrument-name>
		</score-instrument>
		<midi-instrument id="P2-I-1">
			<midi-channel>2</midi-channel>
			<midi-program>0</midi-program>
		</midi-instrument>
	</score-part>
</part-list>

Still, the channel information is still displayed as 0 as shown below.
channel -> 0, pitch -> 64, volume -> 85
channel -> 0, pitch -> 48, volume -> 85
channel -> 0, pitch -> 52, volume -> 75
channel -> 0, pitch -> 67, volume -> 75
channel -> 0, pitch -> 55, volume -> 75
channel -> 0, pitch -> 74, volume -> 75
channel -> 0, pitch -> 43, volume -> 75
channel -> 0, pitch -> 47, volume -> 75
Is there a problem with the MusicXML file?
Attach the file.
Edelweiss.zip

@juuk100

Is there a problem with the MusicXML file?

No, it is correct. The problem is that Lomse MusicXML importer is not yet dealing with midi information in <score-part> elements. This can be fixed quickly. I'm opening issue #82

Looking at your file in more detail, there is an error: the value 0 for <midi-program> is not valid. In MusicXML the  <midi-program> value must be in the range 1...128.
In any case, the problem is that I have to add support for more MusicXMl tags.


added function descriptions, method, params, returns, and examples fo…

…r several functions

This looks fantastic!  Thank you!


ServiceFabric Upgrade fails when enabling EventStore

Upgrading the ServiceFabric to enable the EventStore fails.
fabric:/System/EventStoreService fails to start and terminates and when looking into the diagnostic logs on the node I can see the following error message:
02/14/2019,11:18:04.325442 AM,1026,Error,.NET Runtime,,,Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

Service Fabric Version: 6.4.637.9590

{
	"authorization": {
		"action": "Microsoft.ServiceFabric/clusters/write",
		"scope": "xxx"
	},
	"caller"<EMAIL_ADDRESS>	"channels": "Operation",
	"claims": {},
	"correlationId": "d09d7609-d41c-4c90-8593-c62be981e8a3",
	"description": "",
	"eventDataId": "9dae84c0-f381-4ac9-ac87-852f07beb6f0",
	"eventName": {
		"value": "EndRequest",
		"localizedValue": "End request"
	},
	"category": {
		"value": "Administrative",
		"localizedValue": "Administrative"
	},
	"eventTimestamp": "2019-02-15T12:37:19.7400654Z",
	"id": "xxx",
	"level": "Error",
	"operationId": "d5d2006b-2c3e-4fba-8c84-ca5750168451",
	"operationName": {
		"value": "Microsoft.ServiceFabric/clusters/write",
		"localizedValue": "Create or Update Cluster"
	},
	"resourceGroupName": "xxx",
	"resourceProviderName": {
		"value": "Microsoft.ServiceFabric",
		"localizedValue": "Microsoft.ServiceFabric"
	},
	"resourceType": {
		"value": "Microsoft.ServiceFabric/clusters",
		"localizedValue": "Microsoft.ServiceFabric/clusters"
	},
	"resourceId": "xxx",
	"status": {
		"value": "Failed",
		"localizedValue": "Failed"
	},
	"subStatus": {
		"value": "",
		"localizedValue": ""
	},
	"submissionTimestamp": "2019-02-15T12:37:47.0967287Z",
	"subscriptionId": "xxx",
	"properties": {
		"statusCode": "Conflict",
		"statusMessage": {
			"status": "Failed",
			"error": {
				"code": "ResourceDeploymentFailure",
				"message": "The resource operation completed with terminal provisioning state 'Failed'.",
				"details": [{
						"code": "ClusterUpgradeFailed",
						"message": "Cluster upgrade failed. Reason Code: 'HealthCheck'",
						"Upgrade Progress": {
							"upgradeDescription": {
								"targetCodeVersion": "6.4.637.9590",
								"targetConfigVersion": "5",
								"upgradePolicyDescription": {
									"upgradeMode": "UnmonitoredAuto",
									"forceRestart": true,
									"upgradeReplicaSetCheckTimeout": "00:20:00",
									"kind": "Rolling"
								}
							},
							"targetCodeVersion": "6.4.637.9590",
							"targetConfigVersion": "5",
							"upgradeState": "RollingBackCompleted",
							"upgradeDomains": [{
									"name": "0",
									"state": "Completed"
								}, {
									"name": "1",
									"state": "Completed"
								}, {
									"name": "2",
									"state": "Completed"
								}
							],
							"rollingUpgradeMode": "UnmonitoredAuto",
							"upgradeDuration": "00:11:00",
							"currentUpgradeDomainDuration": "00:00:00",
							"unhealthyEvaluations": [{
									"unhealthyEvaluations": [{
											"unhealthyEvaluations": [{
													"applicationName": "fabric:/System",
													"nodeName": "_esb-nl-dev-nt1_0",
													"unhealthyEvaluations": [{
															"unhealthyEvaluations": [{
																	"applicationName": "fabric:/System",
																	"nodeName": "_esb-nl-dev-nt1_0",
																	"serviceManifestName": "ES",
																	"servicePackageActivationId": "",
																	"unhealthyEvaluations": [{
																			"unhealthyEvent": {
																				"sourceUtcTimestamp": "2019-02-15T12:26:50.7233019Z",
																				"lastModifiedUtcTimestamp": "2019-02-15T12:27:03.07396Z",
																				"isExpired": false,
																				"lastOkTransitionAt": "0001-01-01T00:00:00",
																				"lastWarningTransitionAt": "2019-02-15T12:27:03.07396Z",
																				"lastErrorTransitionAt": "2019-02-15T12:27:03.07396Z",
																				"healthInformation": {
																					"sourceId": "System.Hosting",
																					"property": "CodePackageActivation:Code:SetupEntryPoint:131947071313722052",
																					"healthState": "Error",
																					"description": "There was an error during CodePackage activation.The service host terminated with exit code:3762504530",
																					"timeToLive": "10675199.02:48:05.4775807",
																					"removeWhenExpired": false,
																					"sequenceNumber":<PHONE_NUMBER>07233020
																				}
																			},
																			"considerWarningAsError": false,
																			"kind": "Event",
																			"description": "'System.Hosting' reported Error for property 'CodePackageActivation:Code:SetupEntryPoint:131947071313722052'.",
																			"aggregatedHealthState": "Error"
																		}
																	],
																	"kind": "DeployedServicePackage",
																	"description": "Service package for manifest 'ES' and service package activation ID '' is in Error.",
																	"aggregatedHealthState": "Error"
																}
															],
															"totalCount": 5,
															"kind": "DeployedServicePackages",
															"description": "20% (1/5) deployed service packages are unhealthy.",
															"aggregatedHealthState": "Error"
														}
													],
													"kind": "DeployedApplication",
													"description": "Deployed application on node '_esb-nl-dev-nt1_0' is in Error.",
													"aggregatedHealthState": "Error"
												}, {
													"applicationName": "fabric:/System",
													"nodeName": "_esb-nl-dev-nt1_2",
													"unhealthyEvaluations": [{
															"unhealthyEvaluations": [{
																	"applicationName": "fabric:/System",
																	"nodeName": "_esb-nl-dev-nt1_2",
																	"serviceManifestName": "ES",
																	"servicePackageActivationId": "",
																	"unhealthyEvaluations": [{
																			"unhealthyEvent": {
																				"sourceUtcTimestamp": "2019-02-15T12:16:31.3997642Z",
																				"lastModifiedUtcTimestamp": "2019-02-15T12:16:32.8119855Z",
																				"isExpired": false,
																				"lastOkTransitionAt": "0001-01-01T00:00:00",
																				"lastWarningTransitionAt": "0001-01-01T00:00:00",
																				"lastErrorTransitionAt": "2019-02-15T12:16:32.8119855Z",
																				"healthInformation": {
																					"sourceId": "System.Hosting",
																					"property": "ServiceTypeRegistration:EventStoreServiceType",
																					"healthState": "Error",
																					"description": "The ServiceType was disabled on the node.",
																					"timeToLive": "10675199.02:48:05.4775807",
																					"removeWhenExpired": false,
																					"sequenceNumber":<PHONE_NUMBER>13997642
																				}
																			},
																			"considerWarningAsError": false,
																			"kind": "Event",
																			"description": "'System.Hosting' reported Error for property 'ServiceTypeRegistration:EventStoreServiceType'.",
																			"aggregatedHealthState": "Error"
																		}
																	],
																	"kind": "DeployedServicePackage",
																	"description": "Service package for manifest 'ES' and service package activation ID '' is in Error.",
																	"aggregatedHealthState": "Error"
																}
															],
															"totalCount": 5,
															"kind": "DeployedServicePackages",
															"description": "20% (1/5) deployed service packages are unhealthy.",
															"aggregatedHealthState": "Error"
														}
													],
													"kind": "DeployedApplication",
													"description": "Deployed application on node '_esb-nl-dev-nt1_2' is in Error.",
													"aggregatedHealthState": "Error"
												}, {
													"applicationName": "fabric:/System",
													"nodeName": "_esb-nl-dev-nt1_1",
													"unhealthyEvaluations": [{
															"unhealthyEvaluations": [{
																	"applicationName": "fabric:/System",
																	"nodeName": "_esb-nl-dev-nt1_1",
																	"serviceManifestName": "ES",
																	"servicePackageActivationId": "",
																	"unhealthyEvaluations": [{
																			"unhealthyEvent": {
																				"sourceUtcTimestamp": "2019-02-15T12:18:35.4494539Z",
																				"lastModifiedUtcTimestamp": "2019-02-15T12:19:00.4514242Z",
																				"isExpired": false,
																				"lastOkTransitionAt": "0001-01-01T00:00:00",
																				"lastWarningTransitionAt": "2019-02-15T12:19:00.4514242Z",
																				"lastErrorTransitionAt": "2019-02-15T12:19:00.4514242Z",
																				"healthInformation": {
																					"sourceId": "System.Hosting",
																					"property": "CodePackageActivation:Code:SetupEntryPoint:131946393805718831",
																					"healthState": "Error",
																					"description": "There was an error during CodePackage activation.The service host terminated with exit code:3762504530",
																					"timeToLive": "10675199.02:48:05.4775807",
																					"removeWhenExpired": false,
																					"sequenceNumber":<PHONE_NUMBER>54494540
																				}
																			},
																			"considerWarningAsError": false,
																			"kind": "Event",
																			"description": "'System.Hosting' reported Error for property 'CodePackageActivation:Code:SetupEntryPoint:131946393805718831'.",
																			"aggregatedHealthState": "Error"
																		}
																	],
																	"kind": "DeployedServicePackage",
																	"description": "Service package for manifest 'ES' and service package activation ID '' is in Error.",
																	"aggregatedHealthState": "Error"
																}
															],
															"totalCount": 5,
															"kind": "DeployedServicePackages",
															"description": "20% (1/5) deployed service packages are unhealthy.",
															"aggregatedHealthState": "Error"
														}
													],
													"kind": "DeployedApplication",
													"description": "Deployed application on node '_esb-nl-dev-nt1_1' is in Error.",
													"aggregatedHealthState": "Error"
												}
											],
											"maxPercentUnhealthyDeployedApplications": 0,
											"totalCount": 3,
											"kind": "DeployedApplications",
											"description": "100% (3/3) deployed applications are unhealthy. The evaluation tolerates 0% unhealthy deployed applications.",
											"aggregatedHealthState": "Error"
										}
									],
									"kind": "SystemApplication",
									"description": "System application is in Error.",
									"aggregatedHealthState": "Error"
								}
							],
							"currentUpgradeDomainProgress": {
								"upgradeDomainName": "",
								"nodeProgressList": []
							},
							"startTimestampUtc": "2019-02-15T12:24:12.7828439Z",
							"failureTimestampUtc": "2019-02-15T12:33:13.4991699Z",
							"failureReason": "HealthCheck",
							"upgradeDomainProgressAtFailure": {
								"upgradeDomainName": "",
								"nodeProgressList": []
							}
						},
						"details": []
					}
				]
			}
		},
		"serviceRequestId": null,
		"responseBody": {
			"type": "Microsoft.ServiceFabric/clusters",
			"location": "westeurope",
			"id": "xxx",
			"name": "esb-nl-dev",
			"tags": {
				"resourceType": "Service Fabric",
				"clusterName": "esb-nl-dev"
			},
			"etag": "W/"<PHONE_NUMBER>45519930 "",
			"properties": {
				"provisioningState": "Updating",
				"clusterId": "d2e93945-00b2-4693-92f1-1d931de38323",
				"clusterCodeVersion": "6.4.637.9590",
				"clusterState": "UpdatingUserConfiguration",
				"managementEndpoint": "xxx",
				"clusterEndpoint": "xxx",
				"certificate": {
					"thumbprint": "xxx",
					"x509StoreName": "Root"
				},
				"clientCertificateThumbprints": [{
						"isAdmin": true,
						"certificateThumbprint": "xxx"
					}
				],
				"clientCertificateCommonNames": [],
				"fabricSettings": [{
						"name": "Security",
						"parameters": [{
								"name": "ClusterProtectionLevel",
								"value": "EncryptAndSign"
							}
						]
					}, {
						"name": "Hosting",
						"parameters": [{
								"name": "ContainerDeactivationTimeout",
								"value": "10"
							}, {
								"name": "ContainerTerminationTimeout",
								"value": "10"
							}, {
								"name": "PruneContainerImages",
								"value": "true"
							}, {
								"name": "ContainerImagesToSkip",
								"value": "microsoft/windowsservercore|microsoft/nanoserver"
							}
						]
					}, {
						"name": "EventStoreService",
						"parameters": [{
								"name": "TargetReplicaSetSize",
								"value": "1"
							}, {
								"name": "MinReplicaSetSize",
								"value": "1"
							}
						]
					}
				],
				"diagnosticsStorageAccountConfig": {
					"storageAccountName": "xxx",
					"protectedAccountKeyName": "StorageAccountKey1",
					"blobEndpoint": "xxx",
					"queueEndpoint": "xxx",
					"tableEndpoint": "xxx"
				},
				"vmImage": "Windows",
				"reliabilityLevel": "Bronze",
				"nodeTypes": [{
						"name": "nt1",
						"vmInstanceCount": 3,
						"clientConnectionEndpointPort": 19000,
						"httpGatewayEndpointPort": 19080,
						"applicationPorts": {
							"startPort": 20000,
							"endPort": 30000
						},
						"ephemeralPorts": {
							"startPort": 49152,
							"endPort": 65534
						},
						"isPrimary": true,
						"durabilityLevel": "Bronze"
					}
				],
				"upgradeDescription": {
					"forceRestart": true,
					"upgradeReplicaSetCheckTimeout": "10675199.02:48:05.4775807",
					"healthCheckWaitDuration": "00:10:00",
					"healthCheckStableDuration": "00:10:00",
					"healthCheckRetryTimeout": "00:05:00",
					"upgradeTimeout": "02:00:00",
					"upgradeDomainTimeout": "02:00:00",
					"healthPolicy": {
						"maxPercentUnhealthyNodes": 33,
						"maxPercentUnhealthyApplications": 33
					},
					"deltaHealthPolicy": {
						"maxPercentDeltaUnhealthyNodes": 0,
						"maxPercentUpgradeDomainDeltaUnhealthyNodes": 0,
						"maxPercentDeltaUnhealthyApplications": 0
					}
				},
				"upgradeMode": "Automatic",
				"availableClusterVersions": [{
						"codeVersion": "6.4.637.9590",
						"supportExpiryUtc": "9999-12-31T23:59:59.9999999",
						"environment": "Windows"
					}
				],
				"addonFeatures": ["RepairManager"]
			}
		},
		"requestbody": {
			"location": "westeurope",
			"tags": {
				"resourceType": "Service Fabric",
				"clusterName": "esb-nl-dev"
			},
			"properties": {
				"certificate": {
					"thumbprint": "xxx",
					"x509StoreName": "Root"
				},
				"clientCertificateCommonNames": [],
				"clientCertificateThumbprints": [{
						"certificateThumbprint": "xxx",
						"isAdmin": true
					}
				],
				"clusterState": "Default",
				"diagnosticsStorageAccountConfig": {
					"blobEndpoint": "xxx",
					"protectedAccountKeyName": "StorageAccountKey1",
					"queueEndpoint": "xxx",
					"storageAccountName": "xxx",
					"tableEndpoint": "xxx"
				},
				"fabricSettings": [{
						"name": "Security",
						"parameters": [{
								"name": "ClusterProtectionLevel",
								"value": "EncryptAndSign"
							}
						]
					}, {
						"name": "Hosting",
						"parameters": [{
								"name": "ContainerDeactivationTimeout",
								"value": "10"
							}, {
								"name": "ContainerTerminationTimeout",
								"value": "10"
							}, {
								"name": "PruneContainerImages",
								"value": "true"
							}, {
								"name": "ContainerImagesToSkip",
								"value": "microsoft/windowsservercore|microsoft/nanoserver"
							}
						]
					}, {
						"name": "EventStoreService",
						"parameters": [{
								"name": "TargetReplicaSetSize",
								"value": "1"
							}, {
								"name": "MinReplicaSetSize",
								"value": "1"
							}, {
								"name": "PlacementConstraints",
								"value": "NodeTypeName==nt1"
							}
						]
					}
				],
				"upgradeDescription": {
					"forceRestart": true,
					"upgradeReplicaSetCheckTimeout": "10675199.02:48:05.4775807",
					"healthCheckWaitDuration": "00:02:00",
					"healthCheckStableDuration": "00:05:00",
					"healthCheckRetryTimeout": "00:05:00",
					"upgradeTimeout": "2:00:00",
					"upgradeDomainTimeout": "02:00:00",
					"healthPolicy": {
						"maxPercentUnhealthyNodes": 100,
						"maxPercentUnhealthyApplications": 5
					},
					"deltaHealthPolicy": {
						"maxPercentDeltaUnhealthyNodes": 0,
						"maxPercentUpgradeDomainDeltaUnhealthyNodes": 0,
						"maxPercentDeltaUnhealthyApplications": 0
					}
				},
				"addonFeatures": ["RepairManager"],
				"managementEndpoint": "https://<IP_ADDRESS>:19080",
				"nodeTypes": [{
						"name": "nt1",
						"applicationPorts": {
							"endPort": 30000,
							"startPort": 20000
						},
						"clientConnectionEndpointPort": 19000,
						"durabilityLevel": "Bronze",
						"ephemeralPorts": {
							"endPort": 65534,
							"startPort": 49152
						},
						"httpGatewayEndpointPort": 19080,
						"isPrimary": true,
						"vmInstanceCount": 3
					}
				],
				"provisioningState": "Default",
				"reliabilityLevel": "Bronze",
				"upgradeMode": "Automatic",
				"vmImage": "Windows"
			}
		}
	},
	"relatedEvents": []
}

</Data></EventData></Event>
02/15/2019,12:38:11.151623 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Operation: Upgrade started<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.151623400Z'/><EventRecordID>12569</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Operation: Upgrade started</Data></EventData></Event>
02/15/2019,12:38:11.151623 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Upgrade Agent operation: UAStartedPrepareNextState<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.151623400Z'/><EventRecordID>12570</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Upgrade Agent operation: UAStartedPrepareNextState</Data></EventData></Event>
02/15/2019,12:38:11.152668 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Upgrade  Agent operation: Verifying<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.152668500Z'/><EventRecordID>12571</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Upgrade  Agent operation: Verifying</Data></EventData></Event>
02/15/2019,12:38:11.152668 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Operation: Upgrade verification<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.152668500Z'/><EventRecordID>12572</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Operation: Upgrade verification</Data></EventData></Event>
02/15/2019,12:38:11.152668 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Making poll request from _esb-nl-dev-nt1_1, {"currentAgentVersion":"<IP_ADDRESS>","currentUpgradeAgentVersion":"<IP_ADDRESS>","isTestExtension":false}<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.152668500Z'/><EventRecordID>12573</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Making poll request from _esb-nl-dev-nt1_1, {"currentAgentVersion":"<IP_ADDRESS>","currentUpgradeAgentVersion":"<IP_ADDRESS>","isTestExtension":false}</Data></EventData></Event>
02/15/2019,12:38:11.160664 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Response: null<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.160664900Z'/><EventRecordID>12574</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Response: null</Data></EventData></Event>
02/15/2019,12:38:11.160664 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,Poll request response is null or empty<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.160664900Z'/><EventRecordID>12575</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Poll request response is null or empty</Data></EventData></Event>
02/15/2019,12:38:11.160664 PM,0,Information,ServiceFabricNodeBootstrapAgent,,,BootstrapAgent polling operation completed<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='ServiceFabricNodeBootstrapAgent'/><EventID Qualifiers='0'>0</EventID><Level>4</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:11.160664900Z'/><EventRecordID>12576</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>BootstrapAgent polling operation completed</Data></EventData></Event>
02/15/2019,12:38:16.049007 PM,1026,Error,.NET Runtime,,,Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='.NET Runtime'/><EventID Qualifiers='0'>1026</EventID><Level>2</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:16.049007300Z'/><EventRecordID>12577</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

</Data></EventData></Event>
02/15/2019,12:38:38.568331 PM,1026,Error,.NET Runtime,,,Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='.NET Runtime'/><EventID Qualifiers='0'>1026</EventID><Level>2</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:38:38.568331300Z'/><EventRecordID>12578</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

</Data></EventData></Event>
02/15/2019,12:39:12.110726 PM,1026,Error,.NET Runtime,,,Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

<Event xmlns='http://schemas.microsoft.com/win/2004/08/events/event'><System><Provider Name='.NET Runtime'/><EventID Qualifiers='0'>1026</EventID><Level>2</Level><Task>0</Task><Keywords>0x80000000000000</Keywords><TimeCreated SystemTime='2019-02-15T12:39:12.110726600Z'/><EventRecordID>12579</EventRecordID><Channel>Application</Channel><Computer>dev-nl-000001</Computer><Security/></System><EventData><Data>Application: EventStore.Service.Setup.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ComponentModel.Win32Exception
   at EventStore.Service.Setup.Program+PortAclUtility.BindCertificate(System.String, Int32, Byte[])
   at EventStore.Service.Setup.Program.Main(System.String[])

@masnider can you please (have someone) close the issue
We had both certificates (cluster + admin client) stored in Root store - which was required for us to be able to connect to the cluster for admin clients and PowerShell. This constellation was working so far. Now EventStore BindCertificate seems to expect the cluster certificate in the My store.
To solve this, we adjusted our template to store cluster cert in My and client cert in Root .
...
          "osProfile": {
            "computerNamePrefix": "[parameters('clusterNodePrefixName')]",
            "adminPassword": "[parameters('adminPassword')]",
            "adminUsername": "[parameters('adminUsername')]",
            "secrets": [{
              "sourceVault": {
                "id": "[parameters('sourceVaultValue')]"
              },
              "vaultCertificates": [{
                  "certificateStore": "[parameters('certificateStoreValue')]",
                  "certificateUrl": "[parameters('certificateUrlValue')]"
                },
                {
                  "certificateStore": "[parameters('adminCertificateStoreValue')]",
                  "certificateUrl": "[parameters('adminCertificateUrlValue')]"
                }
              ]
            }],
...


Any way to save annotations?

Is there any way to save annotations in OHIF Viewer 2.x? If not, is it part of the roadmap?

You could do this with a quick and dirty extension that has a SidePanel module
To Persist:

Panel has a button that serializes cornerstone toolstate
Serialized toolstate is passed to the backend of your choice

To Restore:

Panel initiates request to check for existing/persisted toolstate
If it exists, button to "restore" toolstate is shown as "active"
Clicking "restore" hydrates cornerstone's toolstate

We're also very open to exposing new extension points and services based on community needs as we continue to identify those needs.
Long-term, our default/bundled solution will be persistence with DICOM-SR. You can see an in-progress PR here: https://github.com/OHIF/Viewers/pull/954

We're using this issue to track progress: https://github.com/OHIF/Viewers/issues/758
You can see it on our short-term roadmap as in-progress here: https://github.com/OHIF/Viewers/projects/4?card_filter_query=assignee%3Agalelis
We're definitely open to exposing an extension point around this functionality. Not everyone is going to want to use DICOM SR to persist/restore annotations. More than happy to kick up a discussion and scope out something we would be willing to merge if implemented.

Hey @dannyrb could you provide a sample code reference for the mentioned process? I'm trying to add a segmentation tool extension and want to load the marked segmentation to the DICOM. I'm looking at the process you've provided but unable to find a vague code reference to get started. Could you help me out? I'd like to send a PR after implementing this too.


Don't make ol.format.ogc.filter.Filter inherit from ol.Object

See https://github.com/openlayers/ol3/pull/5252#discussion_r65902356

Thanks, that looks good.

Thanks for the review


Issues with Verify() function

We are currently modeling a hybrid automaton in Verse to achieve clock synchronization in swarm robotic systems. The simulate_simple() function works as expected. However, we are facing the following error while trying to call verify().
`[(<RobotMode.Wait: 1>,), (<RobotMode.Wait: 1>,), (<RobotMode.Wait: 1>,), (<RobotMode.Wait: 1>,), (<RobotMode.Wait: 1>,)]
<class 'list'>
{'robot_1': ['Wait'], 'robot_2': ['Wait'], 'robot_3': ['Wait'], 'robot_4': ['Wait'], 'robot_5': ['Wait']}
Traceback (most recent call last):
File "/home/sarthak/Verse-library-main/demo/robot_swarm.py", line 53, in
traces = swarm.verify(10, 0.01)
File "/home/sarthak/Verse-library-main/verse/scenario/scenario.py", line 353, in verify
tree = self.verifier.compute_full_reachtube(init_list, init_mode_list, static_list, uncertain_param_list, agent_list, self, time_horizon,
File "/home/sarthak/Verse-library-main/verse/analysis/verifier.py", line 244, in compute_full_reachtube
asserts, all_possible_transitions = transition_graph.get_transition_verify(new_cache, paths_to_sim, node)
File "/home/sarthak/Verse-library-main/verse/scenario/scenario.py", line 850, in get_transition_verify
if dest_track == track_map.h(src_track, src_mode, dest_mode):
File "/home/sarthak/Verse-library-main/verse/map/lane_map.py", line 119, in h
return self.h_dict[(lane_idx, agent_mode_src, agent_mode_dest)]
KeyError: ('', 'Wait', 'Wait')
Please find attached the python file for our model here.

Hi,
Sorry for the late response. We looked into the problem you encountered. I think the cause of this problem is that the map you are using doesn't match the decision logic you are using. Since you are not using the map in this scenario, you shouldn't specify any exisiting map, which causes this mismatch. The modified model files are attached here. The model file should work with the latest code on the main branch.

Hi,
Could you please explain the reason behind the modifications in the decisionLogic of the agent, particularly the reason for adding an FLMode? Also, the verification routine in the modified model files is taking too long even for a time horizon of 10.

For the FLMode part it's mainly a modeling technique. As in this example, the flmode variable is mainly an integer valued variable which can only take values 0 and 1, it would be better to treat it as a discrete variable, which can be encoded as FLMode. I think for me the verification routine can finish in around 2minutes. Please pull the most recent code on the main branch for this example.

I pulled the most recent code on the main branch. Verification is working as expected. Thanks!


FIAM test failing often in CI

Please fix or disable.  Most recently at https://travis-ci.org/firebase/firebase-ios-sdk/jobs/535124299
FIRIAMClearcutUploaderTests
  testUploadNotTriggeredWhenWaitTimeConditionNotSatisfied, ((sendingAttempted) is false) failed
  /Users/travis/build/firebase/firebase-ios-sdk/InAppMessaging/Example/Tests/FIRIAMClearcutUploaderTests.m:150

[self waitForExpectationsWithTimeout:10.0 handler:nil];
XCTAssertFalse(sendingAttempted);
}

The problem isn't the timeout. It's that sendClearcutHttpRequestForLogs:withCompletion: gets triggered.


Resolver for org.scalaz.stream#scalaz-stream_2.11;0.7a: not found

::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scalaz.stream#scalaz-stream_2.11;0.7a: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		org.scalaz.stream:scalaz-stream_2.11:0.7a
[warn] 		  +- org.specs2:specs2-common_2.11:3.6
[warn] 		  +- org.specs2:specs2-matcher_2.11:3.6
[warn] 		  +- org.specs2:specs2-core_2.11:3.6
[warn] 		  +- org.specs2:specs2-mock_2.11:3.6
[warn] 		  +- com.typesafe.play:play-specs2_2.11:2.4.3 (/Users/phofmann/code/ArticleValidator/build.sbt#L9-17)
[warn] 		  +- articlevalidator:articlevalidator_2.11:1.0-SNAPSHOT
possible fix:
add resolver:
resolvers += "scalaz-bintray" at "http://dl.bintray.com/scalaz/releases"

Another fix is to change the specs2 version

Actually it is defined in the documentation of Play 2.4. One should add the scalaz resolver if you want to use specs2

IMHO upgrading to one of the more recent scalaz releases that is on Central would be more developer friendly, so worth considering as an enhancement

The latest stable Play 2.4 Version (2.4.6) still relies on specs2 version 3.6 (could be upgraded to 3.6.6) which in turn still relies on the scalaz version published in bintray.
To upgrade to the recent scalaz release we will need to play with the build.sbt of the project by specifying required scalaz version and extending import of play's specs with exclude("org.scalaz.stream", "scalaz-stream")
I' stick to the approach recommended by the Play 2.4 documentation.
@nmcb Should we close the ticket with "won't fix" resolution?

Won't fix

hey,
Have you seen these impressive pics? They are  shocking!


fix webkit styles in our app

Description
This PR includes the following proposed change(s):
fix webkit styles in our app
bug fix for mozilla

🧙


Adds river's new Merkle tree implementation, with some cleanup

Description
How do we give River credit for this PR?
Contributing Agreement

[x] I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

Co-authored-by: name<EMAIL_ADDRESS>

PR fixing Fraud Prover is here: https://github.com/ethereum-optimism/optimism-ts-services/pull/13


if i want The training input data is four channels, because my six-channel data is spliced from six single-channel 2D images. How should I modify the code? I do not have a mask annotation file. Can I use this code?

Sorry, the model now only supports 3-channel image inputs, since 3-channel images are first extracted with features from the pre-trained ResNet-50.


Roslyn 2.9

what does it bring?

@filipw Just investigating for breaking changes right now. We'll need to do this eventually.

Your binding redirects are incomplete, which produces build warnings. After that, it looks like the following tests are failing on both Linux and OSX:

OmniSharp.Roslyn.CSharp.Tests.HighlightFacts.HighlightStringInterpolation
OmniSharp.Roslyn.CSharp.Tests.HighlightFacts.HighlightEntireFile
OmniSharp.Roslyn.CSharp.Tests.HighlightFacts.HighlightSingleLine


Random Battle: Reject more move combinations

Reject Toxic with Nuzzle.
Remove Sleep+Talk from Primal Kyogre. Getting just Rest and not Sleep
Talk can be a problem since it cannot hold a Chesto Berry.

Assuming the Toxic-Nuzzle change is for Dedenne, I don't see why it should be removed. Gives it a way to punish otherwise safe electric switch ins, apart from pivoting out.

If so, then why is Toxic rejected with Thunder Wave?

Double status is mostly bad. Except if it is like Toxic + Scald. But, in this case, Dedenne has poor offensive stats and does more damage with status. And Nuzzle isn't exactly like Thunder Wave. It can't be Taunted and does some, albeit a very small amount of, damage.
As for the other change, I have a better idea.

Dedenne can get brutal once it hits Petaya because of its base 81 SpA for its level tier at +1, but you do have a good point. Not only that, Pachirisu (who also has both in its set) has practically zero offensive worth whatsoever.
For the other change, are you thinking of something like adding if (!hasMove['sleeptalk'] && template.requiredItem) to the Rest check? That would probably work.

8c62c585109182d192096e21c28f34b5daf2de68


Referenced dlls are not getting updated

I have referenced some projects in NuGet Package project and it copied the dlls into Lib folder when I installed the package. However, if I modify some properties in the referenced projects and build the solution, the dlls in the Lib folder are not getting updated. Please let me know how to solve this issue.

Do the referenced projects themselves build?
I've never seen a problem where nuproj's build doesn't update its package with updated input DLLs, but I have seen several problems where the C# project system will not notice a change and not compile the DLL at all.


Hit o on a code cell and Hit z does not work in notebook editor.

Environment data
Build of Visual Studio Code - Insiders: 1.51.0-insider
Build of python-insider: 2020.11.120011-dev
Build of Jupyter: 2020.11.346086790-rc
Anaconda: Python 3.8.3 64 bit
Steps to reproduce:

Run cell and export as Jupyter notebook named 'tester.ipynb' in interactive window.
Open tester.ipynb in editor
Hit o on a code cell with output and verify that outputs disappear.
Hit z and verify a deleted cell reappears

Expected behaviour
Hit o on a code cell with output and verify that outputs disappear.
Hit z and verify a deleted cell reappears
Actual behaviour
Hit o on a code cell with output and that outputs did not disappear.
Hit z and  a deleted cell did not reappear

This is actually by design. The native notebook editor has different keyboard shortcuts than the older editor. The test plan is incorrect when using the insiders build.

Sorry this was a mistake. The test plan we sent specified VS code insiders. It should have said VS code stable.


Set up Janus API

We need to write some code to set up and wire up the Janus API with the Redux store.

Already implemented.


Creating a new MVC?

I was wondering what is the basic process too creating a new MVC / table to work in the same way as your todo with the API and page routeing?
Say a posts controller / modal and views with the angular routeing included?
I tried the normal route by copyings the MVC of the todos and manually created the table but I suspect this is wrong. It hasn't created the angular controllers, something now I suspect gulp does? I have never used gulp before.
Thanks

I added a model contact;here are the files you need to change
app/Http/Controllers/ContactController.php
resources/assets/js/app.js
resources/assets/js/controllers/ContactController.js
resources/assets/js/services/ContactService.js
resources/views/layout.blade.php
resources/views/partials/contacts/create.php
resources/views/partials/contacts/index.php
resources/views/partials/contacts/view.php
routes/api.php


admin tools

this will be a little involved.

[ ] add database and proper authentication
[ ] add dropdown to select phc event
[ ] add on-off switch for being able to check in and out participants

Is it worth having proper authentication? i think we should avoid adding a database if we can. Current PHC event can be set in the heroku env var

i'll give it a shot to see if it's hard; agree that simpler is better, but i think in this case having no database makes PHC have to learn a little too much.  another thing is the PHC_Event__c id isn't visible on the salesforce page, so we'd have to like build some tool to show PHC events and their corresponding id's which is kinda hacky.


View Owner's user mapping not used for VIEWs referencing foreign tables

CrateDB version
5.7.1
CrateDB setup information

cloud or local
single node

Problem description
When trying to perform a SELECT operation on a view created by user_a using user_b, a PSQLException error occurs, indicating that password-based authentication was requested but no password was provided. The expectation is that the view should use the user and therefore the user mapping of the owner of the view, which is user_a.
This issue specifically pertains to views on foreign tables. For normal CrateDB tables, the permissions of the view owner are correctly used.
In PostgreSQL, when a user creates a view, the view is executed with the permissions of the user who owns the view. This means that any underlying foreign tables or queries should use the credentials and user mappings of the view's owner.
georg=> SELECT current_user;
 current_user
--------------
 georg2

georg=> SELECT * FROM x;
ERROR:  user mapping not found for "georg2"

georg=> SELECT * FROM x_v;
 classification | country | first_ascent | height |    mountain    | prominence |    range     |        region
----------------+---------+--------------+--------+----------------+------------+--------------+----------------------
 I/B-09.V-A     | CH      |         1859 |   4199 | Rimpfischhorn  |        642 | Valais       | Mischabel

Steps to Reproduce

As user_a:
-- Create user mapping for user_a
CREATE USER MAPPING FOR user_a ...;

-- Create a foreign table in the schema doc
CREATE FOREIGN TABLE doc.x (
   "region" TEXT
);

-- Create a view in the schema doc
CREATE VIEW doc.x_v AS
SELECT *
FROM doc.x
WHERE region = 'y';

-- Verify the view works for user_a
SELECT * FROM doc.x_v;

The above SELECT statement should work correctly and return the expected results.

As user_b:
-- Attempt to query the view created by user_a
SELECT * FROM doc.x_v;

Actual Result
The following error is encountered:
PSQLException[The server requested password-based authentication, but no password was provided by plugin null]

Expected Result
The view doc.x_v should execute using the credentials and user mapping of user_a, the owner of the view.

Thanks for reporting @proddata. I should check why MissingPrivilegeException was not thrown.

@jeeminso the issue is not the returned exception, but rather that this should work and return results for user_b even though that user does not have access to the (foreign) table directly nor a user mapping.

https://cratedb.com/docs/crate/reference/en/latest/general/ddl/views.html
Privileges on relations accessed by the view are not necessary.
However, it is required, at all times, that the owner (the user who created the view), has DQL privileges on all relations occurring within the view’s query definition.

Thanks again @proddata the fix will be available in 5.7.2 release.


[BEAM-9775] Go SDF Example

Added an SDF example.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

For reference, the bug I'm getting is that after processing a few elements of the SDF, I get this message in the docker container: "Failed to send message: EOF" and then the container gets cancelled and the pipeline ends, apparently early. No errors in the Flink job server.

For some reason it's not letting me respond directly to the comment.

Do we know if it's a mistake to have duplicated restrictions in the returned list?

It would be if the duplicate restrictions aren't empty. The only real requirement, though, is that the same work gets done by processing each of the split restrictions as would get done if you processed the original. Since the duplicate empty restrictions are no-ops, this works fine.


Print the time when the new version becomes active

From the buildkite deploy log it's not trivial to tell when the new version became active.
Add a timestamp to the last message to make debugging / searching logs easier.

The plugin only logs when the push has finished. To find out when all the dynos are rotated and it's completely active, you'll need to use the heroku CLI.
heroku ps:wait --app <app_name>

It's still helpful for finding related things in the logs. Especially since I don't have access to every heroku app, so can't always use the API. Saves calculating the buildkite step start time + duration.

The timeline tab in buildkite displays a timestamp for when the job finishes.


How to use it? Is there any API similar to GPT related models?

How to use it? Is there any API similar to GPT related models?

Unfortunately, they have changed API, so it's no longer active. It was just a small project to make an extension for Raycast, so I'm not sure if I'll spend my time fixing it

I'm from China, and I want to solve the problem of AIGC testing. Do you have any recommendations?

Nope, as you can see from my repos, I'm not very interested in AI, so I can't give you any advice


Adonis's library URL is outdated and does not match the one in README markdown

The Adonis library URL is outdated, (https://www.roblox.com/library/2373505175/Adonis-Loader-Sceleratis-Davey-Bones)

It should be updated to the updated module as listed in the README

@Sceleratis

👋 Welcome! It looks like this is your first time creating an issue here.  It looks like this is your first time creating an issue here. Do expect a maintainer's response in a few days' time regarding your matter.

🤮 reis bot

👋 Welcome! It looks like this is your first time creating an issue here. Do expect a maintainer's response in a few days' time regarding your matter.

🤮 reis bot

fixed

Issue still not resolved.

https://www.roblox.com/library/2373505175/Adonis-Loader-Sceleratis-Davey-Bones

Issue still not resolved.

https://www.roblox.com/library/2373505175/Adonis-Loader-Sceleratis-Davey-Bones

@Sceleratis Help.

Thought I fixed that one sec

@Sceleratis Not fixed; the link in the repo's About section still leads to the old loader by Davey_Bones.

@Sceleratis Not fixed; the link in the repo's About section still leads to the old loader by Davey_Bones.

Ahhhhhhhhhhhhh

Actually fixed now (don't even need the library link there since it's all in the readme anyway)


Fixes link to ARB and uniforms markdown links in ReadMe

Fixing the readme as link was broken in documentation. Added a dot at
end of a sentence and moved links to bottom of readme.

:+1:

I signed it!

Merged by jumping backwards through flaming hoops in
https://github.com/dart-lang/intl/commit/f9ab5a9f1c364886a93fa0f4e132894b778e4381


allow method idx + 1 index

Fixes #6417 , which happens when we write a binary with exactly 65535 methods.
I checked the binary writer code in Mono.Cecil and our computations for sizes are correct, as is our token writing code.  The issue happens because an empty type definition (no methods) emits a "method table idx + 1" value, but that is expected.
https://github.com/jbevain/cecil/blob/ab5075b3a885ffd5bee5d347b79ce71aabeb32d1/Mono.Cecil.Metadata/Buffers.cs#L99
I'm testing the compiler referenced in the bug by hand

So when an idx of 0x10000 is passed in, 0x0000 is written to buffer by this, which is identical to passing an idx of 0x0000. Is that actually what we want?

Yeah it is weird isn't it.
The above is certainly what Mono.Cecil does, at least as far as I can tell.  We can check a few other binary writers too, e.g. create a binary with exactly 65535 methods using ILASM.
I was hoping to verify by simply executing but we are currently hitting this problem on small variations of FSHarp.Compiler.Service.dll and executing that's a little awkward except in tests.  Also testing it that way isn't really good enough is it.
AFAICS the end+1 index of 0x10000 gets used for the "end index + 1" for the methods, fields and properties of a TypeDef.  This corresponds to these lines when reading the information back in:
           let ((flags, nameIdx, namespaceIdx, extendsIdx, fieldsIdx, methodsIdx) as info) = seekReadTypeDefRow ctxt idx
           let nm = readBlobHeapAsTypeName ctxt (nameIdx, namespaceIdx)
           let (endFieldsIdx, endMethodsIdx) = seekReadTypeDefRowExtents ctxt info idx

then this:
           let mdefs = seekReadMethods ctxt numtypars methodsIdx endMethodsIdx

then this:
and seekReadMethods (ctxt: ILMetadataReader)  numtypars midx1 midx2 =
    mkILMethodsComputed (fun () ->
           let mdv = ctxt.mdfile.GetView()
           [| for i = midx1 to midx2 - 1 do
                 yield seekReadMethod ctxt mdv numtypars i |])

Here if midx2 is zero then the loop will simply never execute its body and we get an empty array....  It looks like this might be wrong...because we are simply failing to read any methods for a type.....   If so it's possible other readers would have similar odd behaviour....
Another approach would be to refuse to emit a binary with 65535 methods and emit a dummy.
I'll create a fake C# binary where one class has 65535 methods and compare.

Actually I think the problem can only occur when

there are precisely 65535 methods (or fields) and
the last type definition has no methods (or fields)

Sure enough, the last type we're emitting is <PrivateImplementationDetails$FSharp-Compiler-Service>, which has no methods because there are no private implementation details for that file in the compilation.
In the ECMA 335 spec, it says that each TypeDef row has the following MethodList value:
 MethodList (an index into the MethodDef table; it marks the first of a continguous
run of Methods owned by this Type). The run continues to the smaller of:
1. the last row of the MethodDef table or
2. the next run of Methods, found by inspecting the MethodList of the next
row in this TypeDef table

Since there is no next row in the TypeDef table (this is the last type definition), then the second bullet doesn't apply, and the end of the method range  will be the last row in the MethodDef table.  But what should the start be?  No number in the index range 0 - 65535 is valid to represent the absence of methods.  We really want MethodDefTable.Length (65536).  Any other index is wrong.
I actually believe this is a flaw in the .NET IL binary format.... Wow.... You simply can't represent this case.  Bang.
Is there a bounty prize for this kind of thing after 20 years of .NET?

:)

@jbevain Have I got this wrong?

@dsyme no I think you're spot on, I was just amused. Thinking about it this could show up elsewhere as well, I think properties and events also use ranges in a list.

@jbevain Should 0 be emitted to represent the absence of methods in this case?

@dsyme no I think you're spot on, I was just amused. Thinking about it this could show up elsewhere as well, I think properties and events also use ranges in a list.

Yeah, also method parameters.  Though maybe the fact that all methods have a return parameter mean that's never hit.

@dsyme yes I think that would work. That reminds me of an issue in Cecil that was triggered by the portable pdb support in fsc where we were not expecting 0 for a *List, but where that's actually valid to represent the absence of a list.

It looks like Mono.Cecil handles a list start range of zero:
https://github.com/jbevain/cecil/blob/ab5075b3a885ffd5bee5d347b79ce71aabeb32d1/Mono.Cecil/AssemblyReader.cs#L971
So I think 0 is the right value to emit here.  But Ecma 335 just doesn't document it

There is this note in ECMA 335 on a different section.  So yes, it looks like 0 is the right thing to emit.
18. MethodList can be null or non-null
If MethodList is non-null, it shall index a valid row in the MethodDef table, where
valid means 1 <= row <= rowcount+1 [ERROR]

That was added in August 2017:
https://github.com/jbevain/cecil/commit/22b36c3dc5dcc0ddba38164904a1b3daf02151e2
So yes, not a common case, but 0 should be valid.

OK, I updated the PR so our binary reader respects '0' in the start-of-list entries to mean an empty list.
I think the PR is sound now, but we should really double check the code for the .NET runtime binary reader - I'm sure it will record a zero entry as an empty list to.

@dsyme, I think you are right that they use 0 as the start row id to indicate 0 methods, fields and properties.
GetMethodRange for a type returns the start and end row in the method table: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/src/System/Reflection/Metadata/MetadataReader.cs#L864
In methoddefinitionhandlecollection here: https://github.com/dotnet/corefx/blob/master/src/System.Reflection.Metadata/src/System/Reflection/Metadata/TypeSystem/HandleCollections.TypeSystem.cs#L456
Notice the count property is last - first + 1, (0 - 1 +1) = 0

@dsyme, this looks ready to pull, are you good with it?


jq error

Using the example config I'm getting the following error:
jq: error (at <stdin>:4): Cannot iterate over null (null)
I also don't want to write my own resource. Could you please verify that error or tell me if I'm doing something wrong.

What operation is this occurring during: check, get, put? Are you sure your API token user has permissions for the repository you’re trying to edit?

Hi, @dpb587.
Thank you for the answer. I'm trying to put status to my repo. API token is 100% right cause previously I was able to push status to that repo with a simple Go program. Basically I'm trying to do this:
plan:
    - get: builder
      params: {submodules: none}
      trigger: true
    - put: "repo-status"
      params:
        state: "pending"
        commit: "builder"

I don't think I have seen this error before and, unfortunately, it's not easy to debug right now. Quickly reviewing some of the code, I think this could, theoretically, occur if builder is working off a different branch than repo-status was. You might want to make sure repo-status is configured with the branch option if you're using something other than master for builder.

For what it's worth, the original issue might be fixed by any of:

https://github.com/dpb587/github-status-resource/pull/14
https://github.com/dpb587/github-status-resource/pull/15

I am getting this in check
resource_types:
- name: github-status
  type: "docker-image"
  source:
    repository: "dpb587/github-status-resource"
    tag: v2.1.0
- name: github_status
  type: github-status
  source:
    branch: master
    repository: git@github.com:<repo name>.git
    access_token: ((github-access-token))
jobs:
- name: Build Master
  plan:
  - do:
   ...
  on_failure:
    put: github_status
    params: { state: failure, commit: git_master }

resource script '/opt/resource/check []' failed: exit status 5

stderr:
jq: error (at <stdin>:4): Cannot iterate over null (null)

I am also getting this problem since I moved a repository from my personal account to an organisation I own (moved from luispabon/kong-certbot-agent to phpdocker-io/kong-certbot-agent):
https://ci.auronconsulting.co.uk/teams/main/pipelines/kong-certbot-agent-master/jobs/analyze-master/builds/16
https://github.com/phpdocker-io/kong-certbot-agent/blob/master/concourse/pipeline-master.yaml
I'm certain the token is good since it's been working before, and another resource for the same repository (the pull request status) also works with the same token

I was also getting this error upon moving a git repo from organisation to organisation and I had forgotten to apply the changes on the resource_type section.

Having the same issue. The status gets set correctly but it still throws that error.
out of curiosity, is this repo even maintained?


Have a dummy container in helm charts (optional) that will wait for the init commands to finalize

This will be useful in cases where we are doing a day zero deployment for a cluster with many apps; we register secrets to all apps; and all the apps will wait on the dummy container to reconcile after all secrets have been registered.

Done.


v2.1.9 release notes

Fixes #5369.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/13727d3e7598f2b9af9a23cfcf2b4bd733910214/
Edited pages:

releases/v2.1.9.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a7f36a99042b54b1018821ab6b47444a07d926eb/
Edited pages:

releases/v2.1.9.md

We should add a note for cockroachdb/cockroach#40353, which went in without one because we didn't grasp its significance when it was originally written. This is the biggest bug fix and the whole reason we're pushing this build now.
"Fixed a bug that could lead to data inconsistencies and crashes with the message consistency check failed with N inconsistent replicas."

We should add a note for cockroachdb/cockroach#40353, which went in without one because we didn't grasp its significance when it was originally written. This is the biggest bug fix and the whole reason we're pushing this build now.
"Fixed a bug that could lead to data inconsistencies and crashes with the message consistency check failed with N inconsistent replicas."

Done! Thanks @bdarnell.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6c923124219b76be78021a6dbf599dd9ca48f575/
Edited pages:

releases/v2.1.9.md

Handing this off to you, @rmloveland

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9febf82b73f0a0ef7379fa407abcf17ddee9bdf4/
Edited pages:

releases/v2.1.9.md

@bdarnell  and @jseldess , mind taking one more pass over these?
Updated with a few new commits and updated the date to 9/23, everything else should be the same, hopefully.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0fab7bc45c35e40116c6771dfd7e1049e2374361/
Edited pages:

releases/v2.1.9.md

Thanks Ben.  Removed dupes, publishing now.

releases/v2.1.9.md, line 51 at r2 (raw file):

- Fix bug where MVCC value at future timestamp is returned after a transaction restart. [#40632][#40632] [9dbb670a8][9dbb670a8]
- Consider intents in a read's uncertainty interval to be uncertain just as if they were committed values. This removes the potential for stale reads when a causally dependent transaction runs into the not-yet resolved intents from a causal ancestor. [#40632][#40632] [d6b00e37e][d6b00e37e]
- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]

Duplicate?

releases/v2.1.9.md, line 50 at r2 (raw file):

- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368] [75a8d2468][75a8d2468]
- Fix bug where MVCC value at future timestamp is returned after a transaction restart. [#40632][#40632] [9dbb670a8][9dbb670a8]
- Consider intents in a read's uncertainty interval to be uncertain just as if they were committed values. This removes the potential for stale reads when a causally dependent transaction runs into the not-yet resolved intents from a causal ancestor. [#40632][#40632] [d6b00e37e][d6b00e37e]

Rephrase: Intents in a read's uncertainty interval are now considered uncertain just ....

releases/v2.1.9.md, line 49 at r2 (raw file):

- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105] [6f537772c][6f537772c]
- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368] [75a8d2468][75a8d2468]
- Fix bug where MVCC value at future timestamp is returned after a transaction restart. [#40632][#40632] [9dbb670a8][9dbb670a8]

Fix > Fixed

releases/v2.1.9.md, line 48 at r2 (raw file):

- Fixed incorrect results, or "unordered span" errors in some cases involving exclusive inequalities with non-numeric types. [#38897][#38897] [c2919b478][c2919b478]
- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105] [6f537772c][6f537772c]
- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368] [75a8d2468][75a8d2468]

Duplicate.

releases/v2.1.9.md, line 47 at r2 (raw file):

- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]
- Fixed incorrect results, or "unordered span" errors in some cases involving exclusive inequalities with non-numeric types. [#38897][#38897] [c2919b478][c2919b478]
- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105] [6f537772c][6f537772c]

This is a duplicate.

releases/v2.1.9.md, line 46 at r2 (raw file):

- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368]
- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]
- Fixed incorrect results, or "unordered span" errors in some cases involving exclusive inequalities with non-numeric types. [#38897][#38897] [c2919b478][c2919b478]

This is a duplicate.

releases/v2.1.9.md, line 45 at r2 (raw file):

- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105]
- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368]
- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]

Fix > Fixed


Curiousness at 1200! (factorial)... ?

This used to work just fine about a year ago (with num 0.4.0 and factorial 0.2.1) to calculate permutations:
$ xpg --analyze
* Word list length: 1,259
* Words in password: 4
* Total permutations (without repetition): 2,500,525,503,024

    ```
    1,259! / (1,259 - 4)!
    1,259! / 1,255!
    2,500,525,503,024
    ```

Words | Permutations
---|---:
1 | 1,259
2 | 1,583,822
3 | 1,990,864,254
4 | 2,500,525,503,024
5 | 3,138,159,506,295,120
6 | 3,935,252,020,894,080,480
7 | 4,930,870,782,180,282,841,440
8 | 6,173,450,219,289,714,117,482,880
... | ...

Reference xpg/README.md and xpg/src/lib.rs: permutations() function and use.

Now working with num 0.4.1 (with or without num-bigint feature, doesn't seem to matter) and factorial 0.3.0 and otherwise same code says:
$ xpg --analyze
* Word list length: 1,259
* Words in password: 4
* Total permutations (without repetition): 51

    ```
    1,259! / (1,259 - 4)!
    1,259! / 1,255!
    51
    ```

Words | Permutations
---|---:
1 | 1
2 | 1,258
3 | 1,581,306
4 | 51
5 | 64,808
6 | 81,269,380
7 | 101,830,534,280
8 | 13,283
... | ...

What? Any idea what could be going on here?

Dev'd a quick test...
Cargo.toml:
[package]
name = "factorial-issue"
version = "0.1.0"
edition = "2021"

[dependencies]
factorial = "0.3.0"
num = { version = "0.4.1", features = ["num-bigint"] }

src/main.rs:
use factorial::Factorial;
use num::BigUint;

fn main() {
    let k = 2_u128;

    for n in 1190_u128..=1220_u128 {
        let d = n - k;

        let n_fac = BigUint::from(n).factorial();
        let d_fac = BigUint::from(d).factorial();

        let p = n_fac.clone() / d_fac.clone();

        println!("P({n}, {k}) = {n}! / ({n} - {k})! = {n}! / {d}! = {p}");
    }
}

which prints:
P(1190, 2) = 1190! / (1190 - 2)! = 1190! / 1188! = 1414910
P(1191, 2) = 1191! / (1191 - 2)! = 1191! / 1189! = 1417290
P(1192, 2) = 1192! / (1192 - 2)! = 1192! / 1190! = 1419672
P(1193, 2) = 1193! / (1193 - 2)! = 1193! / 1191! = 1422056
P(1194, 2) = 1194! / (1194 - 2)! = 1194! / 1192! = 1424442
P(1195, 2) = 1195! / (1195 - 2)! = 1195! / 1193! = 1426830
P(1196, 2) = 1196! / (1196 - 2)! = 1196! / 1194! = 1429220
P(1197, 2) = 1197! / (1197 - 2)! = 1197! / 1195! = 1431612
P(1198, 2) = 1198! / (1198 - 2)! = 1198! / 1196! = 1434006
P(1199, 2) = 1199! / (1199 - 2)! = 1199! / 1197! = 1436402
P(1200, 2) = 1200! / (1200 - 2)! = 1200! / 1198! = 0
P(1201, 2) = 1201! / (1201 - 2)! = 1201! / 1199! = 0
P(1202, 2) = 1202! / (1202 - 2)! = 1202! / 1200! = 3
P(1203, 2) = 1203! / (1203 - 2)! = 1203! / 1201! = 4807
P(1204, 2) = 1204! / (1204 - 2)! = 1204! / 1202! =<PHONE_NUMBER>12
P(1205, 2) = 1205! / (1205 - 2)! = 1205! / 1203! =<PHONE_NUMBER>20
P(1206, 2) = 1206! / (1206 - 2)! = 1206! / 1204! = 1453230
P(1207, 2) = 1207! / (1207 - 2)! = 1207! / 1205! = 1455642
P(1208, 2) = 1208! / (1208 - 2)! = 1208! / 1206! = 0
P(1209, 2) = 1209! / (1209 - 2)! = 1209! / 1207! = 0
P(1210, 2) = 1210! / (1210 - 2)! = 1210! / 1208! = 1462890
P(1211, 2) = 1211! / (1211 - 2)! = 1211! / 1209! = 1465310
P(1212, 2) = 1212! / (1212 - 2)! = 1212! / 1210! = 1467732
P(1213, 2) = 1213! / (1213 - 2)! = 1213! / 1211! = 1212
P(1214, 2) = 1214! / (1214 - 2)! = 1214! / 1212! = 3
P(1215, 2) = 1215! / (1215 - 2)! = 1215! / 1213! = 4855
P(1216, 2) = 1216! / (1216 - 2)! = 1216! / 1214! =<PHONE_NUMBER>3661425442004249299214815912574782761274542951623296515259630626327360
P(1217, 2) = 1217! / (1217 - 2)! = 1217! / 1215! =<PHONE_NUMBER>4001173203295678435567749722283771819979047696809297543423564301504
P(1218, 2) = 1218! / (1218 - 2)! = 1218! / 1216! = 1482306
P(1219, 2) = 1219! / (1219 - 2)! = 1219! / 1217! =<PHONE_NUMBER>
P(1220, 2) = 1220! / (1220 - 2)! = 1220! / 1218! = 1487180

So something weird going on around n = 1200...
Any help/pointers are greatly appreciated! Thanks!

Cross posted as https://github.com/thomwiggers/factorial/issues/16

I doubt this is a num issue.


Add some reserved checks that need to be present

@nathanielmanistaatgoogle @soltanmm @stanley-cheung @jtattermusch @tbetbetbe heads up

Python looks good but @soltanmm will also independently review.

LGTM

PHP LGTM

lgtm

Should this be changed in Node too?

It probably should - but I didn't see a failure (looks like Nico updated
some places and not others) - want to check?
On Tue, Aug 18, 2015 at 4:44 PM Michael Lumish<EMAIL_ADDRESS>wrote:

Should this be changed in Node too?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/2972#issuecomment-132392004.

LGTM.

The Node tests are passing, so if there is a problem, it isn't urgent. I can send a separate pull request if necessary.

@murgatroid99 went ahead and updated node for safety.

Node LGTM


Correctly handle parameter.schema in ToJson() instead of generator

The decision whether to use "schema" or parameter directly should be made in ToJson(type) instead of in the generator

Also check other usages of SchemaType

Add unit tests for https://github.com/RSuter/NSwag/issues/1503
Check if CreateUntypedPathParameter also needs to use "schema" instead of "type" directly

Only as a side note in case you did not already see it:
The Swagger Editor shows all the issues with the gernerated OpenAPI 3 spec.
Following properties should also be inside the schema object:

default
required
nullable

And parameters added through an OperationProcessor should also use that schema object (currently not affected by c350820):
public class HeaderOperationProcessor : IOperationProcessor
{
	public async Task<bool> ProcessAsync(OperationProcessorContext context)
	{
		context.OperationDescription.Operation.Parameters.Add(new SwaggerParameter
		{
			Name = "X-MyProduct-Token",
			Description = "API Token",
			Kind = SwaggerParameterKind.Header,
			Type = NJsonSchema.JsonObjectType.String,
			IsRequired = true
		});
                return true;
        }
}

TIA 👍

Not sure if "required" can be used from JSON Schema, it's defined as an array and specifies which object properties are required: https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-5.15

The idea of this issue is to avoid assigning "schema" as it is currently done but copy parameter properties to "schema" when serializing to OpenAPI 3, this way you can keep this processor and serialization to OAI3 and Swagger2 works... not sure if it is possible to do.

Oh ok now I get it! Then I should have commented elsewhere I guess...
And yes required does not have to be in schema, sorry :|

Hi.
I use NSwagStudio v<IP_ADDRESS> and NSwag.MsBuild v13.4.1.
They still generate the Query-Paramaters using the old Swagger2 style, instead of the new OpenApi3 style (#1503 was closed, that's why I write here), evene I use "outputType": "OpenApi3" in the aspNetCoreToOpenApi.
Is there maybe an extra switch to use the new style?

I'm on 13.5.0, set my schemaType to OpenApi3, but still have query parameters listed in the JSON instead of the object. Am I missing another settings?

I managed to get the following workaround working to get the output OpenApi3 compliant for now,
create an OperationProcessor and add it to the settings OperationProcessors (I put it as the very last one):
	public class Swagger2ToOpenApi3ParameterOperationProcessor : IOperationProcessor
	{
		public bool Process(OperationProcessorContext context)
		{
            var parameterTypesToConvert = new[] { JsonObjectType.String, JsonObjectType.Boolean, JsonObjectType.Integer, JsonObjectType.Number };
            for (var i = 0; i < context.OperationDescription.Operation.Parameters.Count; i++)
            {
                var parameter = context.OperationDescription.Operation.Parameters[i];
                if (parameterTypesToConvert.Contains(parameter.Type))
                {
                    var newParameter = new OpenApiParameter
                    {
                        Name = parameter.Name,
                        Kind = parameter.Kind,
                        IsRequired = parameter.IsRequired,
                        Description = parameter.Description,
                        Schema = new JsonSchema()
                        {
                            Type = parameter.Type,
                            Format = parameter.Format,
                            IsNullableRaw = parameter.IsNullableRaw
                        }
                    };
                    context.OperationDescription.Operation.Parameters[i] = newParameter;
                }
            }
            return true;
        }
    }


Prickly pufferfish mrcuber html server

prickly-pufferfish folder

Here is my pull request. There are a couple unused files, but i left them there as a placeholder if we need them in the future.


[Docs]: Template - Job Story

Problem Statement
Template - Job Story
Other Relevant URLs
Draft: https://www.notion.so/Template-Job-Story-162fe271b0e280db8151c39e696e3173
Slack/conversation:

duplicate


Anybody using bs-react-native bindings with react-native-web ?

There are some minor platform specific differences, for example react-native-web allows to use em or rem for spacing. In untyped JS, this is easy to deal with, no code changes required.
What would be the ReasonML way to deal with such cases ? Put platform specific code right into bs-react-native ? I guess not.
A  kind of monkey-patching wrapper module ?

ok, found some discussion  related to this here:  https://github.com/reasonml-community/bs-react-native/pull/123

I use it, and I avoid at all cost web stuff only. No just because of the bindings limitation. If I need to, I use web stuff directly without the bindings.
I guess the only way would be to have a bs-react-native-web. Maybe scripted from this one?

@MoOx thanks, but how do you "use web stuff directly without the bindings" ?
E.g. I would like to use Hover functionality on the web platform. In react-native-web there is glitch where the following implementation is suggested (just render function here):
 render() {
    const { children, onHoverIn, onHoverOut } = this.props;
    const child = typeof children === 'function' ? children(this.state.isHovered) : children;

    return React.cloneElement(React.Children.only(child), {
      onMouseEnter: this._handleMouseEnter,
      onMouseLeave: this._handleMouseLeave
    });
 }

I tried to implement that in reason-react like this:
open BsReactNative;

type action =
  | Toggle;

type state = {isHovered: bool};

let component = ReasonReact.reducerComponent("Hoverable");

let make = (~isHoverEnabled, children) => {
  ...component,
  initialState: () => {isHovered: false},
  reducer: (action, state) =>
    switch (action) {
    | Toggle => ReasonReact.Update({isHovered: ! state.isHovered})
    },
  render: self =>
    <div
      onMouseEnter=(
        (_) =>
          if (isHoverEnabled^ && ! self.state.isHovered) {
            self.send(Toggle);
          }
      )
      onMouseLeave=(
        (_) =>
          if (self.state.isHovered) {
            self.send(Toggle);
          }
      )>
      (children(~isHovered=self.state.isHovered))
    </div>,
};

it actually works, but I guess this is not as it is supposed to be done.
So what is the best way to get something like this done in reason react (or if possible, directly in "web" as you mentioned) ?

Solutions I see are:

recreate locally some components interfaces and add missing parts for RNW
make a JS component exposed to RE
make a web component (JS or RE) without using (bs-)RN APIs (but web primitives instead).

Feel free to close this one unless you're gonna have some actionable outcome 👍

I will explore a bit more the different options to get RN nicely working on web. For now, closing the issue.


Sent messages often lost during poor Internet connectivity

Expected behavior
A sent message should be copied to the Sent folder when it is transmitted.  During times of good Internet connectivity (3G/4G/wifi), this is fine.
Actual behavior
During times of poor Internet connectivity, the message is sometimes transmitted but not saved into Sent, leaving no record for the sender.  I experienced this numerous times during a recent trip into areas with dodgy signal.  My theory is that the signal was good enough for K-9 to transmit the message with SMTP, but failed before it could completely APPEND with IMAP, and it therefore discarded the message.  In some cases, I was able to resurrect most of it from the Drafts folder.
I suspect there needs to be a state in the state machine for outgoing messages: sent via SMTP, appended via IMAP, complete.
Steps to reproduce

Send a message while the signal is dodgy (not so bad that Android thinks you have no Internet, just bad enough.)  Attaching a photo will probably help with reproduction.
If K-9 is able to send via SMTP but not complete via IMAP, the sent message is lost.

Environment
K-9 Mail version: 5.600
Android version: 9, patch level 2019-02-05
Account type (IMAP, POP3, WebDAV/Exchange): IMAP with SMTP

https://tools.ietf.org/html/rfc4468 might help here.
If the message is received by the server, it will be copied into the sent folder  by the server.

Duplicate of #2616


Macro based Scala APIs for Predicate and Projection push down

There has been some experiments with Scala macros to make Predicate and Projection APIs in Scala.
In particular by [~neville]:
https://github.com/nevillelyh/parquet-avro-extra/blob/master/parquet-avro-examples/src/main/scala/me/lyh/parquet/avro/examples/ExampleApp.scala
https://github.com/nevillelyh/parquet-avro-extra/commit/090f8d1d1d7d44489bb71e04465d4a12a46432c9#diff-89dca6adcdf105c6063661de43931c29R15
There have also been some discussion at Twitter.
Reporter: Julien Le Dem / @julienledem
Note: This issue was originally created as PARQUET-218. Please see the migration documentation for further details.

Neville Li / @nevillelyh:
True in most cases it doesn't and we only use a tiny subset.
In Projection[T], only avroObj.getField1.getField2... is allowed. And in Predicate[T], only basic boolean comparison & logical expression are allowed. Value expressions/literals from the closure will be pulled in as is.
Also it probably only works for data representation formats from schema, e.g. Avro, Proto, Thrift?

Alex Levenson / @isnotinvain:
One more thing we need to support is projecting / filtering into repeated columns, which is a little bit harder.
A normal function for that would look like:
myStruct.foo.bar.someList.map { x => (x.a, x.d, x.f) }
And for filtering:
myStruct.foo.bar.someList.filter { x => x.a > 0 && x.d > 0 }
So these macros will have to recurse, instead of taking the approach of pulling the 0th element out of a repeated field and operating on that.

Oscar Boykin:
I think these macros are great, but I'd like to see if we can go a bit further.
I'd like Projection[T, U] to extend (or be implicitly convertible to Function1[T, U]) so that we can use projections in scalding/spark without being sure the underlying data supports parquet project (we have sources that are mixed: for some time ranges they are parquet, but older data might just be compressed thrift).
If we have this functionality, we can project as the IO layer when possible, when not possible we can do it at scalding/spark layer.

Alex Levenson / @isnotinvain:
How would we want to handle the case where the macro can't really tell what's going on in the closure?
The more we make the closure look like a plain chunk of any scala code, the more confusing it's going to be to users when no, actually, only a tiny subset of valid scala can go here.

Alex Levenson / @isnotinvain:
Yes, I agree they should be valid functions, and failing fast when they aren't understood is a pretty good solution.
I guess i was just wondering if we could make it more clear to users that they aren't writing just any function, they're writing a very specific function. Good error reporting is probably enough.

Oscar Boykin:
I would just fail the macro with an explanation that only field access is allowed in Projection.
I think Projection[T, U] and Predicate[T] being valid functions that we can run will be of use.


Using ngrx/router

Any reasons the seed uses angular2 router instead of ngrx/router even though it uses ngrx/store. I was trying to replace angular2 router with ngrx/router but got some issue with missing provider for Analytics Service. Would you recommend using angular2 router instead of ngrx/router for any new project which is build on top of this seed. Also ngrx/router provides some cool features like guards is there any replace for that in angular2 router.

It's still up in the air whether NG2/Router 3.0 is going to fully replace ngrx/router...
ngrx/router#147

Thanks @zeeshanjan82 and @spicemix indeed we will stick with ng2 router here since it is shaping up and will eventually replace ngrx/router.
I'm having a good experience so far with ng2 new v3 router that's in the seed.


Question about RegExp

Hi,
Why you use RegExp here for example:
https://github.com/tananaev/traccar/blob/master/src/org/traccar/protocol/Gps103ProtocolDecoder.java
And not use String Split by comma "," ? Any good reason? It is only a question.
Thanks.

Splitting by comma might work for some protocols, but regular expressions work for all of them (there is one exception where I uses splitting by comma).


python310Packages.pytest-datafiles: 2.0 -> 2.0.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pytest-datafiles is: "py.test plugin to create a 'tmpdir' containing predefined files/directories."
meta.homepage for python310Packages.pytest-datafiles is: "https://github.com/omarkohl/pytest-datafiles"
meta.changelog for python310Packages.pytest-datafiles is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.0.1 with grep in /nix/store/8hb3082s8vj2piy80n256ga6528dvwwy-python3.10-pytest-datafiles-2.0.1
found 2.0.1 in filename of file in /nix/store/8hb3082s8vj2piy80n256ga6528dvwwy-python3.10-pytest-datafiles-2.0.1

Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pytenable
python310Packages.pytest-datafiles
python310Packages.restfly
python39Packages.pytenable
python39Packages.pytest-datafiles
python39Packages.restfly
watson

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8hb3082s8vj2piy80n256ga6528dvwwy-python3.10-pytest-datafiles-2.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pytest-datafiles https://github.com/r-ryantm/nixpkgs/archive/914bef69c3e3dacf7d1917377b066a17e165392d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8hb3082s8vj2piy80n256ga6528dvwwy-python3.10-pytest-datafiles-2.0.1
ls -la /nix/store/8hb3082s8vj2piy80n256ga6528dvwwy-python3.10-pytest-datafiles-2.0.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

7 packages built:

python310Packages.pytenable
python310Packages.pytest-datafiles
python310Packages.restfly
python39Packages.pytenable
python39Packages.pytest-datafiles
python39Packages.restfly
watson

Maintainer pings

Result of nixpkgs-review pr 171232 run on x86_64-linux 1

7 packages built:

python310Packages.pytenable
python310Packages.pytest-datafiles
python310Packages.restfly
python39Packages.pytenable
python39Packages.pytest-datafiles
python39Packages.restfly
watson


Update all GitHub actions

PR Type
Does this PR add a new feature, or fix a bug?
No.
Why should this PR be included?
Actions used in GitHub Actions should be updated to the latest version and not use any beta versions. Dependabot could be used to automate this.

Thanks!


Unable to delete algorithm properties once added

HKube micro-service
API-SERVER
Describe the bug
Adding props:
"algorithmEnv": {
"DISCOVERY_TIMEOUT": 30,
"DISCOVERY_ENABLE": "False"
}
and then unable to delete this.

when editing algorithm if "algorithmEnv" exist .
you can delete   algorithmEnv child property
but fail to delete the entaier property


Dashboard commits are not updating

Hit this when refreshing github commit:
GitHub Error: Requested Resource was Not Found
#0      GitHub.handleStatusCode (package:github/src/common/github.dart:400:9)
#1      GitHub.request (package:github/src/common/github.dart:372:7)
<asynchronous suspension>
#2      PaginationHelper.fetchStreamed (package:github/src/common/util/pagination.dart:36:33)
<asynchronous suspension>
#3      GithubService.listCommits (package:cocoon_service/src/service/github_service.dart:38:54)
#4      RefreshGithubCommits.get (package:cocoon_service/src/request_handlers/refresh_github_commits.dart:70:66)
<asynchronous suspension>
#5      RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:46:28)

Something wrong when fetching commits of branch: experimental_skshaper.
workaround to skip that branch to make the dashboard rolling.
Still looking at the experimental_skshaper branch issue.

This is caused by missing branch experimental_skshaper in github flutter/flutter, whereas that branch is still in cocoon: https://github.com/flutter/cocoon/blob/master/app_dart/dev/branches.txt. The backend is trying to fetch commits of that branch, which doesn't exist anymore.

experimental_skshaper should not have been deleted.  I've repushed it to flutter/flutter.

Fix got pushed to latest cocoon.


Malformed metrics

Hello,
I observe the following malformed metrics output:
some_metic1{lab1="f5378719-907e-11e9-b826-0050569bce07"} 29520800
some_metic1_count{lab1="f5378719-907e-11e9-b826-0050569bce07"} 103lab2="Chat",lab1="f5378719-907e-11e9-b826-0050569bce07",quantile="0.9"} NaN

It seems that part of the line of a metric is somehow missing from the output.

Fixed in 3.0.1: https://github.com/PrometheusClientNet/Prometheus.Client/issues/66
@arieradle You have problem in 3.0.1?

Thanks, my bad


Deprecated $call syntax in express_v4.16.x.js using flow 0.75.0

After upgrading to flow 0.75.0 the express definition file reports the following error but I cannot find any documentation on what changed:
Warning ----------------------------------------------------------------------- interfaces.flow/express_v4.16.x.js:200:3

Deprecated $call syntax. Use callable property syntax instead. (`deprecated-call-syntax`)

   200|   $call: (
          ^^^^^

FYI for anyone who has this issue, whilst waiting for these definitions to update you can set this option in your .flowconfig to disable the error:
[lints]
deprecated-call-syntax=off

I'm on Flow 0.52.0, and getting many errors like this after the fix in https://github.com/flowtype/flow-typed/pull/2408:
Library type error:
flow-typed/npm/express_v4.16.x.js:215
     v------------------------------------------------------------------------------------
215: declare class express$Application extends express$Router mixins events$EventEmitter {
216:   constructor(): void;
217:   locals: { [name: string]: mixed };
...:
253: }
     ^ property `disable`. Property not found in
Object

Any ideas?
Upgrading to flow 0.75.0 is not a good option at the moment, because it causes me many more errors with GraphQL types, and I would have to also upgrade GraphQL to a newer version.

@luislhl You probably did this and I am not sure this is helpful, I had to just //$FlowIgnore above the that class declaration for the time being. I am on the same versions as you.


Request for automerge, updates existing token, metadata stSOL

I'm submitting a ...
[x] feature request

Hi, please manually merge our updates to stSOL token.
Original PR: https://github.com/solana-labs/token-list/pull/740
New PR: https://github.com/solana-labs/token-list/pull/14424
@ruuda  and @hritique can confirm changes. Also I'm in lidofinance organisation. U can check it in my profile.

I confirm changes

@joncinque @keone can u please merge it?

Done


fix: First name replacement

I'm in the habit of naming my characters beginning with the IC first name. I noticed that if I tried to replace my name with only the first name, no replacements were made.
This fix should ensure that the name is properly replaced even in these cases.
Steps to reproduce:

Create a character or use an existing one, say it's name is "TestyMcTest".
Set the TRP first name to "Testy"
Configure Quest RP names to use first name only.
Verify that for example quest texts is properly changed to use only the first name and not the full OOC character name.

Thank you for this! I haven't had any issues personally with first-name only settings, but I've tested this commit and not seen any issues. I'll get this uploaded asap. Thanks!


[Problem] String consts

Currently, Vanilla_____ classes don't have all of the identifiers. For instance, VanillaTraits doesn't have a lot of + versions of traits.

I've been gradually expanding these lists, there are more complete versions in my mod. I will try to get around to submitting them as a pull request.

RogueLibs v3 will no longer be updated. Reopen the issue if the issue persists in v4+.


[ChartJS] Fix failing build with ChartJS >= 3.9.0

Q
A

Bug fix?
yes

New feature?
no

Tickets
N/A

License
MIT

Fix the failing builds like https://github.com/symfony/ux/runs/7813370449?check_suite_focus
If running with ChartJS < 3.9.0, the build passes, not sure where it comes from but changing the way we import fixes it.
When I builded locally, it changed some other files which I included here. Those changes seem mostly like syntax changes.

Thank you! This has been bothering me, but I hadn’t had a chance to look yet!
But, I think this new import may have a different meaning? See: https://www.chartjs.org/docs/latest/getting-started/integration.html - the old way, it appears, registered everything, while I think the new way might not. We should check. But if I’m right, it looks like we could import that registerables thing and get the same behavior with this new import (I have no idea why the old auto import now fails).

You are right, we should use the "registerables" thing to make sure we are on par with what was done previously and follow the documented way, though I couldn't find a case where doing it the way this PR does breaks (even when running encore production for example which should do tree-shaking).
I think the culprit PR on the ChartJS side is https://github.com/chartjs/Chart.js/pull/10479 but not sure why it fails as they say to have kept backward compatibility.
I've pushed a new commit doing Chart.register(...registerables) but that now fails the tests :sweat_smile:
So I'm wondering if that's not a test vs build toolchain difference, a bit clueless on this one to be honest.

I was just about to open an issue on chart.js about this, but i thought I should dig into the issue more and see if I could get a reproducer. Well, I failed! And I can't figure our why yet.
Here is my reproducer - https://github.com/weaverryan/chartjs-rollup-reproducer - which leverages rollup + typescript and imports chart.js. But, when you run yarn rollup -c, it works. We need to figure out what differs between that project and this project. If you have any time to check into it, I'd appreciate it - I'm about to start vacation. I tried commenting out some things in the symfony/ux rollup script to see if I could find the cause, but no luck.

As pointed out in your reproducer repo, it's reproduceable.
The only thing I can say from my tests is that it seems linked to Typescript because if I remove the rollup typescript plugin and change index.ts to index.js, it builds correctly.
Do you want me to go ahead and create an issue in chart.js or do you have a clue to why it's failing ?
For reference, my reproducer is failing in the same way as the UX repo on main https://github.com/t-richard/chartjs-rollup-reproducer

For reference, my reproducer is failing in the same way as the UX repo on main https://github.com/t-richard/chartjs-rollup-reproducer

Ah, wonderful! I may have written poorly, I actually could NOT reproduce the issue on my repo. But I see that I had a silly typo that you fixed 👏 .
So now that you DO have a simple reproducer repository, yes, please open an issue on the chart.js repository. It will be especially helpful to be absolutely sure that the bad behavior was introduced in exactly 3.9.0 (so, try 3.8.2 on the reproducer temporarily so that you can say on the issue for sure that 3.9.0 is the cause).
Thank you :)

I validated that 3.8.2 works as expected.
I've opened an issue on chart.js, lets see if someone can help there.
Have nice vacation!

Hey @t-richard!
Did you get any answers on the chartjs issue? Can you link to it?
Thanks!

hey @weaverryan
https://github.com/chartjs/Chart.js/issues/10599

Closing for #468