Faking javascript for jquery getScript

We have a feature we'd like to test that involves the use of this call:
Ember.$.ajax({ url: url, cache: true, dataType: 'script' })
Works fine on real js files, so in the tests I wanted to use mirage to mock the ajax request to url.
    function jsResponse (javaScript) {
      return new Mirage.Response(200, {
        'Content-Type': 'application/javascript'
      }, javaScript)
    }

    this.get('/tests/caper-game-loader/script.js', function () {
      return jsResponse(`
        define('test/script', [], function () {
          return 'foo';
        });
      `);
    });

The response is json encoded. Looking into the code and docs this looks like something we can't change. Have I missed something here?
Thanks for your time.

(sorry about the delayed response!)
I would try configuring Pretender's prepareBody function. By default Mirage sets it to stringify the response. You can use this.pretender.prepareBody (docs) in your mirage/config.js file to configure this property.
Let me know if it helps!

(Not a problem, we did a workaround with JSON.parse and eval in the meantime)
Thanks, I'll follow this up and report back.

Also you might be all set when #392 is merged

got this pull request in pretender as well https://github.com/pretenderjs/pretender/pull/134
which might be useful to have different logic inside prepareBody depending on content-type which

Closing due to inactivity.


Session Not Established

Issue template

Hardware description: Arduino Nano rp2040 connect
RTOS: N/A
Installation type: Android IDE 2.2.1
Version or commit hash: v2.0.7 Humble

I'm very new to ROS, so it would be very appreciated if I can figure out the issue.
I wanted to test using the publish example code if I can publish from arduino to my PC.
Indeed, if I use micro-ros_reconnection_example, it works, I'm not sure why.
I followed the official installation procedures, and I did not make any changes to ROS_DOMAIN_ID.
ros2 run micro_ros_agent micro_ros_agent serial --dev /dev/ttyACM0 -v6
The session was not established using the above command.
Expected behavior
I expected the session to be established
Actual behavior
The only log I got was as the below image.

Are you resetting the board after instantiating the micro-ROS Agent?
This example do not handle client-agent reconnection, see this for implementing it: https://docs.vulcanexus.org/en/latest/rst/tutorials/micro/handle_reconnections/handle_reconnections.html

Should I reset the board, after instantiating?

Please read: https://docs.vulcanexus.org/en/latest/rst/tutorials/micro/handle_reconnections/handle_reconnections.html

Thank you so much, I was able to somehow solve the issue.


"Cannot read property 'ev' of null thrown " in angular 2

when I am trying to execute jasmine test cases in angular 2 getting error as
"Cannot read property 'ev' of null thrown "
I checked this issue in GitHub and stack overflow. In that i got few solutions in https://github.com/ionic-team/ionic/issues/10186.,
https://github.com/ionic-team/ionic/issues/10045
but those are not worked for me.
Ionic Info:
Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.0.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 7
Node Version: v6.3.1
Xcode version: Not installed
In  Package. Json:
"jasmine-core": "^2.6.2",
"ionic-angular": "2.0.0",
"@ionic/app-scripts": "1.0.0",
"typescript": "2.0.9"
And this issue sometimes is not getting without change any code and dependencies also.Please try to give permanent solution. Thanks in advance.

Please use the issue template.

Hello! Thanks for opening an issue with us! As this seems like more of a support question I will urge that you ask this question on our forum or on our slack channel. Thanks for using Ionic!


Update cms819

Added MAT measure CMS819 and corresponding test cases.
JIRA ticket CQF-1483
https://tracker.esacinc.com/secure/RapidBoard.jspa?rapidView=15&view=detail&selectedIssue=CQF-1483&quickFilter=30

redid PR


The issues need to be resolved before next release

frame graph category b problem

Let user install the frame graph dependency, and set the env variable to the location of script.
brpc docs should also be updated correspondingly to guide user.

If we don't change the frame graph code , we don't need to ship the code in the source release.
We can provide a script to download the frame graph dependency before build the source.
In this way we can make sure our source release is follow the Apache release rule.

IMO that's a good suggestion,
jiashun,  how do you think?

It's a good advice. We can mention in the doc that only users who need frame graph feature should download and install it. Otherwise just build the source.


Use config serverUrl for HLS video stream

When serving TileBoard on a different url then HA API, HLS video streams are not working.
Added the CONFIG.serverUrl to fix this issue

Thank you.


Video wont play,afted several months of using the app i am suddenly not able to watch video anymore, i have a black screen with this text on it "this content is not available for this app"

I have a samsung a13 and i updated and reinstalled the app but nothing change

new problem

all Gmail request request

69e58sotzigzitco

continuously email id request notification sent why and please fix sir

what is the meaning this spellings


FIX: Session Secret

Fix session secret, as it is still using dummy data.
Use process.env for the secret

[x] Investigation - express session
[x] Remove dummy string and improve security of express session

Moved to env file and create a hash string for the secret


[#2677] Remove unnessary synchronized in SpdySessionHandler

Motivation:
As all methods in the ChannelHandler are executed by the same thread there is no need to use synchronized.
Modifications:
Remove synchronized keyword.
Result:
No more unnessary synchronized in SpdySessionHandler.

Cherry-picked into 4.0 (4c758fac12bd3a6244601a35ea98738d606af051) , 4.1 (d9d488e477c302481bb8fa5028e5bb469eefd492) and master (5b9e55f3abd01cc142a3d63e70462ecdafce81f6)


Recommendation: move the UNUSED macro to aria.h

Use Case
The consuming developer wishes to embed an aria console in their application, modeled on the sample main function.
Estimated Impact
Cons: Potential for human error during copy and paste.
Pros: It keeps the coding style neat and consistent with the rest of aria and provides an "out of the box" compilable solution for beginning programmers who want to start extending and embedding aria in another application.

The UNUSED macro is intentionally internal as projects which have unused-variable warnings enabled will likely be using their own unused-macro, those that don't wouldn't require such a macro. I'm not sure I understand the benefit of moving it to the header file.

I guess I misunderstood the purpose of that macro. I thought it was more important than it was. :-)


Respect the python interpreter given by the 'python' attr.

Shebang not needed for locate_archive.py
Prefix pip call with python argument from the attribute.

Closing due to inactivity, please reopen if needed.


[Bug]: Widget label is persistent when property pane pop-ups are opened

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Widget label is persistent when property pane pop-ups are opened

Steps To Reproduce

Highlight a widget
Open it's action selector pop-up as seen in the screenshot

Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
cloud

This is happening for the site footer bar and the error pane as well.
https://www.loom.com/share/04ccc8013d3c4a88ac582112ab37b3b3?sid=47d4912a-fef3-43cd-bdb5-787867a742f4


change the voxel size, I can train with the new config

I just change the voxel size form [0.05,0.05,0.1] to [0.025,0.025,0.05], and run the train.py, then I get the problem like this.

Anyone can help me. plz

https://github.com/open-mmlab/OpenPCDet/issues/253#issuecomment-677473408

thank you very much


DLIB_ISO_CPP_ONLY is broken

Here's what I get when trying to use dlib::shape_predictor with DLIB_ISO_CPP_ONLY defined:
In file included from /usr/local/include/dlib/threads/posix.h:4:0,
                 from /usr/local/include/dlib/threads/threads_kernel.h:13,
                 from /usr/local/include/dlib/threads.h:11,
                 from /usr/local/include/dlib/image_processing/shape_predictor.h:14,
                 from test.cpp:12:
/usr/local/include/dlib/threads/threads_kernel_2.h:7:2: error: #error "DLIB_ISO_CPP_ONLY is defined so you can't use this OS dependent code.  Turn DLIB_ISO_CPP_ONLY off if you want to use it."
 #error "DLIB_ISO_CPP_ONLY is defined so you can't use this OS dependent code.  Turn DLIB_ISO_CPP_ONLY off if you want to use it."
  ^

Please note, (at least as of 19.1) commenting out dlib::shape_predictor_trainer in dlib/image_processing/shape_predictor.h fixes the issue.

It's not broken.  This is just what happens when you disable that part of the code.  I don't know what you would expect to happen.
Although, honestly, I'm tempted to remove the DLIB_ISO_CPP_ONLY switch since I suspect mightily that no one really uses it.

I don't know what you would expect to happen.

Wouldn't you expect it to work as outlined in the "documentation"?

This is a #define directive that you can set to cause the library to exclude all non ISO C++ code (The things in the API wrappers section and any objects that depend on those wrappers).

Yes. Some things depend on that stuff. Like part of the shape prediction tooling.

Though the predictor itself doesn't depend on threads, and the trainer's declaration could be moved to a separate header (not sure why the thread part has to be OS dependent in the first place, since DLib requires a C++11 compiler why can't it use std::thread?).

Because a lot of dlib was written before there was C++11 support in compilers.  Also, yes, many things could be split up.  You can almost always split source files into smaller parts, we could make it so there are 10,000 source files instead of about 1000.  But I'm not doing that.
Do you have a use case that is somehow impacted by what you are posting about?

The use case is pretty simple: all I use from DLib is the shape predictor, and since it's implemented solely in headers I'd like to benefit from a header-only part of DLib, not having to build it for various platforms.

Sure.  If you want to move the shape_predictor to its own header then submit it as PR :).  Do make sure you don't break any existing code though.

Sorry, had no idea how to link PR to an issue... so here it is #599

No worries.  Thanks for the PR :)


dealing with date/time columns

dates and times can come in so many different shapes and sizes; we need a whole method that can be integrated into structured_preprocesser() to deal with all possibilities.

If this could be some kind of column transformer, it would be really easy to integrate into the preprocessor


Colored Point Cloud

Hi,
Are these generated point clouds colored or just grey level points? If not, do you plan to add color information to the generated point clouds?

Hi @YilmazKadir ,
no color information is processed ATM and unfortunately I don't have much time to extend this project. But if you do, please feel free to propose a pull request with the changes :)
Best,
D

Closing, feel free to open, if you have other questions :slightly_smiling_face:


Task Timeout

This software looks great and a perfect fit for an application that I am refactoring!
One question, my tasks need to have a timeout. I.E. if they run past a certain time they should fail as I assume something is stuck. Does this library have an option to specify the task time.
If you are interested in such an option I could add it to this software. If not then I will code it into a base class for my jobs.
Implementation-wise I was thinking of using pcntl_alarm and installing a signal handler to kill the process rather than set_time_limit since the later doesn't work if the process is doing some sort of IO or other system operation.

After thinking about this a bit more I decided this is probably best accomplished through the event system as callbacks. Could be wrapped up as a plugin if desired. This weeks resque lean. To help anybody else that comes along here is my event handler which implements the timeout.
<?php
# Required to ensure signal is delivered. If in a tight loop PHP will keep
# executing even once the signal is deliver which may mean it will run for much
# longer than intended. The code can manually yield by calling
# `pcntl_signal_dispatch`, but jobs are unlikely to call that. This causes PHP
# to come up for air and deliver the signals.
declare(ticks=1);

# Install the alarm and signal handler before the job is executed. Note, that
# we don't remove the handler and alarm in an `afterPerform` event. Jobs are
# executed in a fork, as soon as the job is done everything is thrown out anyway.
Resque_Event::listen('beforePerform', function($job) {
  # For easy reference
  $logger = $job->worker->logger;

  # Grab the name of the job class handling this job
  $job_class = $job->payload['class'];

  # Check if job class wants a timeout.
  if( property_exists($job_class, 'timeout') ) {
    $timeout = $job_class::$timeout;

    $logger->info("$job timeout in {timeout}", ['timeout' => $timeout]);

    # Requiring jobs to set the timeout in seconds can get tedious. If a string
    # then use strtotime to figure out the number of seconds;
    if( is_string($timeout) ) $timeout = strtotime($timeout) - time();

    # NOTE: The default behavior of SIGALRM is to kill the process which is
    # exactly what I am doing. I install a handler anyway for two reasons:
    #
    # * The default handler is at the OS level and will just kill the process
    #   completely without executing any more PHP. This results in Resque's
    #   `onFailure` handler not being run. The process will just silently die.
    #   Having a handler and manually killing means anything registered in
    #   `onFailure` will run properly.
    # * I can also log a message so even if no handler is installed there is
    #   some bit of feedback as to what happened.
    pcntl_signal(SIGALRM, function() use($job, $logger) {
      $logger->error("$job timed out. Killing process");
      exit(12);
    });

    # Setup alart to go off after the configured time.
    pcntl_alarm($timeout);
  }
});

That's a good idea. I agree with you.

Nice work!👍


Gardenlet in local gardener fails to create seed due to IP CIDR conflicts

How to categorize this issue?

/area dev-productivity
/kind bug
What happened:
Following this guide https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md, it failed on step make gardener-up as no seed was created. In fact, gardenlet is crashing with this error message
panic: failed during bootstrapping: incorrect node network specified in seed configuration (cluster node="<IP_ADDRESS>" vs. config="<IP_ADDRESS>/16")

What you expected to happen:
To be able to create local gardener environment
How to reproduce it (as minimally and precisely as possible):
Follow the guide from https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md
Anything else we need to know?:
It is still working, if I checkout v1.57.0 tag.
Environment:

Gardener version: afa6db45466a5f1c171a3848ef0f86168464d92c
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

The problem is that the node CIDR is hard-coded at several places (https://github.com/gardener/gardener/search?q="<IP_ADDRESS>%2F16"). This specific CIDR seems to only be the correct one for Macs.

@dimityrmirchev suggested that this is related to the kind docker network which changed its CIDR in newer versions of kind and needs to be re-created, but this is did not work for me as it still uses the <IP_ADDRESS>/20 CIDR.


Removing Deprecated Util Functions

Updated Examples which were using deprecated Util functions.

@mranney as you have already made this changes in https://github.com/mranney/http_trace I recommend we opt for pull #147 and remove examples from this library.
@vigneshshanmugam thanks for the PR, if @mranney wants to keep examples in this repo will merge it in.

Sure @jmaxxz  :)

Yeah, let's clean out any examples that don't actually work, or at least fix the ones that do. It would be nice to give people some examples of what can be done, so feel free to add any other informative examples if you have some.
http_trace has been its own repo for a while, so it's good to see it removed.

Sure will raise a new request removing the http_trace.


Remove API store mutex #653

Codecov Report

Merging #662 into rusk-ipc will increase coverage by 0.58%.
The diff coverage is 59.00%.

@@             Coverage Diff              @@
##           rusk-ipc     #662      +/-   ##
============================================
+ Coverage     54.96%   55.55%   +0.58%
============================================
  Files           156      160       +4
  Lines          9689    10564     +875
============================================
+ Hits           5326     5869     +543
- Misses         3723     3975     +252
- Partials        640      720      +80

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/core/consensus/collector.go
0.00% <0.00%> (ø)

pkg/core/consensus/committee/handler.go
80.00% <0.00%> (-8.89%)
:arrow_down:

pkg/core/consensus/component.go
72.41% <ø> (ø)

pkg/core/consensus/generation/score/generator.go
14.92% <0.00%> (-0.70%)
:arrow_down:

pkg/core/consensus/header/header.go
24.75% <0.00%> (ø)

pkg/core/consensus/queue.go
100.00% <ø> (ø)

pkg/core/consensus/reduction/testutil.go
46.42% <0.00%> (-1.72%)
:arrow_down:

pkg/core/consensus/user/provisioners.go
23.28% <ø> (ø)

pkg/core/data/transactions/provider.go
0.00% <0.00%> (ø)

... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d1df3...4c85bb9. Read the comment docs.


cant't process jailbreak

device ： M1  iPad Pro 15.4.1
first,I used Dopamine 1.0.2 ,it is worked for me ,but after i installed the  latest SnowBoard ,it is very caton,i cant't entry to sileo to uninstall it .so I reboot my ipad. after that ,i have never success to jailbreak my ipad again.even i changed the latest Dopamine.
it is show :
hello from xxx server
my UID is 0
my GID is 0
xxxxx          ------->.    there is only oneline info. after that my ipad will be reboot. try to jailbreak again,it will be reboot after that info again.
i try to jailbreak with airplane mode，but is ineffective.

Airplane mode is essentially useless, don't report issues if you are using old versions of dopamine, this wastes everyone's time.
I'm pretty sure the success rate on m1 is really really bad. Has not been investigated yet. @qq2519157

@Cryptiiiic I used the latest version on my iPhone 13 Pro，so I want use it on my M1 iPad Pro，but It doesn't seem to have a high success rate，after reboot i've never success jailbreak anymore

Repeat... I'm pretty sure the success rate on m1 is really really bad. Has not been investigated yet.

well，Pray for success next time


Automated cherry pick of #8139: bugfix :esxi 多机器环境下拉取监控超时

Cherry pick of #8139 on release/3.4.
#8139: bugfix :esxi 多机器环境下拉取监控超时

Codecov Report

Merging #8140 into release/3.4 will decrease coverage by 1.16%.
The diff coverage is 0.22%.

@@              Coverage Diff               @@
##           release/3.4   #8140      +/-   ##
==============================================
- Coverage         5.48%   4.32%   -1.17%
==============================================
  Files              524     453      -71
  Lines            90076   82789    -7287
==============================================
- Hits              4943    3579    -1364
+ Misses           84726   78902    -5824
+ Partials           407     308      -99

Flag
Coverage Δ

#aFlag
4.32% <0.22%> (-1.17%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/scoperesource.go
0.00% <0.00%> (ø)

pkg/cloudprovider/dnszone.go
68.29% <0.00%> (ø)

pkg/compute/models/buckets.go
1.06% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
5.14% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/cloudproviders.go
0.86% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/dbinstance_accounts.go
2.04% <0.00%> (-0.06%)
:arrow_down:

pkg/compute/models/dbinstance_databases.go
3.31% <0.00%> (-0.16%)
:arrow_down:

pkg/compute/models/dbinstancenetworks.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstances.go
0.78% <0.00%> (+<0.01%)
:arrow_up:

pkg/compute/models/disks.go
0.50% <0.00%> (-0.01%)
:arrow_down:

... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3ff8a...b88c114. Read the comment docs.

/lgtm
/approve


tooling: --help option for crystal docs

I am very new to crystal and have been playing around with the tools.
Almost all the crystal commands have a --help option to help the user to understand its purpose better. But the crystal docs command does not seem to have one.

I think it would be better to have some help for it like below.
$ crystal docs
Usage: crystal docs [Options] [file]

Options:
    -h, --help      Show this message

In this way, it would be easy for adding new options and documenting them in future. (Right now crystal docs has no options, I suppose)

#4937 includes a --help option.
But we should keep this issue open until it gets merged.

#4937 got merged so this is fixed now


MUI v6: Fix Typography Examples

See feat/mui-6 branch
Some spacing seems to be off in Typography examples. This is probably due to systemProp changes.
See the BlockUI paragraph examples and the Forms examples.

This was completed.


Android app Crash reports are not reflected in Azure application insights dashboard?

Currently am using "com.microsoft.azure:applicationinsights-android:1.0-beta.8" version for unhand-led crash reports. But reports are not reflected in dashboard. I refereed below link for setup/integrating: https://github.com/microsoft/ApplicationInsights-Android#2
Since, SDK in version 1.0-beta.9 on words SDK is officially deprecated. But i am using 1.0-beta.8 version.So it should work for me right. please help me if i am doing wrong at any place.
Is there any other way for getting crash reports for android?
Kindly help me anyone on this issue.
Thank you in Advance !!

@galla-devlop  Thanks for the question! We are investigating and will update you shortly.

@galla-devlop Thanks for reaching out! While I reach out to our internal teams to get guidance, could you please let me know if and what your findings were when you tried to debug the issue? If yes, could you provide me with the logs?

@galla-devlop Just following up here to check if you have any update.

@galla-devlop Given that the referenced Application Insights SDK for Android was deprecated more than 2.5 years ago, we would strongly recommend you to move over to using Visual Studio App Center for your reporting needs.
If you'd like to pursue the idea further, there are some helpful resources available to ease the movement and also cater to your requirement of reporting crashes for Android:

Quickstart with Azure App Insights
Use the App Center SDKs together with the Application Insights connector
App Center Crashes for Android

Hope this helps!
We will now proceed to close this thread as resolved, but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


how to do this in v2

Could somebody please explain how to achieve the same behavior in v2?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: af5a2184-2f06-5c07-477c-86b2591fb2aa
Version Independent ID: 0cbf10e2-1cc1-7eff-57a9-6bc8872e7620
Content: Train a model by using a custom Docker image - Azure Machine Learning
Content Source: articles/machine-learning/v1/how-to-train-with-custom-image.md
Service: machine-learning
Sub-service: core
GitHub Login: @saachigopal
Microsoft Alias: sagopal

@wmpauli
Thanks for your feedback! We will investigate and update as appropriate.

Thanks @ManoharLakkoju-MSFT. I found a solution here: https://learn.microsoft.com/en-us/azure/machine-learning/how-to-manage-environments-v2?tabs=python#create-an-environment-from-a-docker-build-context
It's generally difficult to find documentation specific for v2. Bing and other search engines are not able to separate results for the two versions cleanly.
Because there are so many customers who need to use their own containers, it could be useful to add that documentation as a next step here as well: https://learn.microsoft.com/en-us/azure/machine-learning/migrate-to-v2-command-job

@wmpauli
Thank you for bringing this to our attention!!
I've delegated this to @saachigopal , a content author, to review and share their valuable insights.


Caching should happen

It doesn't currently because I hacked this up on a Fedora 21 box, and Fedora 21 has Pelican 3.3.0 in its repos (3.6 is in F22, which I have not upgraded too yet)... and I was too lazy to set up virtualenv.
My (bad) excuses aside, caching should be implemented. That can speed up running over large mailboxes.

I'm actually not sure how to do this, now that I think about it. We still need to iterate over the mailbox to get to any "new" mail, don't we?
Also, it takes my machine about 10 seconds to process an ~10 MB mbox with more than 900 messages, so this is probably not a huge worry at the moment. It should still happen eventually, of course!


[ASTGen] Make ASTGenVisitor not conform to SyntaxTransformVisitor

Removal of conformance of ASTGenVisitor to SyntaxTransformVisitor.
Implementation of a visit(Syntax) method similar to SytnaxTransformVisitor.visit(Syntax) but that only handles the correct nodes in ASTGen.
Renamed the visit methods to generate.

Resolves #68350

do we want to rename all instances of visit to generate in all other files like Exprs.swift, Types.swift, Generics.swift , etc. ?

I rebuilt all the test dependencies and ran all the test with this command
utils/run-test --lit ../llvm-project/llvm/utils/lit/lit.py \
  ../build/Ninja-RelWithDebInfoAssert/swift-macosx-$(uname -m)/test-macosx-$(uname -m)

I had an error with the test/ASTGen/verify-parse.swift . I did not see any steps in the docs for adding the test folder to the xcodeproj so I did not make changes to the file.
Any tips when making code changes and having to update/write tests? There are lots of moving pieces and the repo is very big but I want to grasp how testing works and where I would need to make updates.

I had an error with the test/ASTGen/verify-parse.swift . I did not see any steps in the docs for adding the test folder to the xcodeproj so I did not make changes to the file.
Any tips when making code changes and having to update/write tests? There are lots of moving pieces and the repo is very big but I want to grasp how testing works and where I would need to make updates anytime I make a change.

What I usually do, is opening the test files in a separate text editor that’s not Xcode. Alternatively, you can also navigate to test/ASTGen/verify-parse.swift in Finder/Terminal and open the file from there. But I wouldn’t expect any changes in the tests to be necessary, really.

But I wouldn’t expect any changes in the tests to be necessary, really

When would I know if it is appropriate to updates/add tests? For this issue, do we not need to do any testing because it is just updating function calls/names?

@swift-ci Please smoke test

CI failed with
swiftASTGen/ASTGen.swift:274: Fatal error: not implemented
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.    Apple Swift version 5.11-dev (LLVM 69cd2190ea64502, Swift a23eaeac64bc974)
2.  Compiling with effective version 4.1.50
3.  While evaluating request ParseSourceFileRequest(source_file "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/test/ASTGen/verify-parse.swift")
4.  With parser at source location: <invalid loc>
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x000000011469e177 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
1  swift-frontend           0x000000011469d1f8 llvm::sys::RunSignalHandlers() + 248
2  swift-frontend           0x000000011469e7d0 SignalHandler(int) + 288
3  libsystem_platform.dylib 0x00007ff805906dfd _sigtramp + 29
4  libsystem_platform.dylib 0x00007ff7b1251780 _sigtramp +<PHONE_NUMBER>2293231008
5  swift-frontend           0x000000011035fb23 $s11swiftASTGen0B7VisitorV8generateyAA7ASTNodeO11SwiftSyntax0G0VF + 7011
6  swift-frontend           0x000000011035d994 $s11swiftASTGen0B7VisitorV8generateySaySvG11SwiftSyntax010SourceFileF0VF + 836
7  swift-frontend           0x0000000110360969 $s11swiftASTGen21buildTopLevelASTNodes13diagEnginePtr010sourceFileI02dc3ctx13outputContext8callbackySpys5UInt8VG_SPyAJGS3vySv_SvtXCtF + 297
8  swift-frontend           0x00000001102e6dd9 swift::Parser::parseSourceFileViaASTGen(llvm::SmallVectorImpl<swift::ASTNode>&, llvm::Optional<swift::DiagnosticTransaction>&, bool) + 569
9  swift-frontend           0x00000001102e67ba swift::Parser::parseTopLevelItems(llvm::SmallVectorImpl<swift::ASTNode>&) + 42
10 swift-frontend           0x0000000110346545 swift::ParseSourceFileRequest::evaluate(swift::Evaluator&, swift::SourceFile*) const + 389
11 swift-frontend           0x0000000110346f21 swift::SimpleRequest<swift::ParseSourceFileRequest, swift::SourceFileParsingResult (swift::SourceFile*), (swift::RequestFlags)12>::evaluateRequest(swift::ParseSourceFileRequest const&, swift::Evaluator&) + 17
12 swift-frontend           0x0000000110648b7e llvm::Expected<swift::ParseSourceFileRequest::OutputType> swift::Evaluator::getResultUncached<swift::ParseSourceFileRequest>(swift::ParseSourceFileRequest const&) + 414
13 swift-frontend           0x00000001106488bc llvm::Expected<swift::ParseSourceFileRequest::OutputType> swift::Evaluator::getResultCached<swift::ParseSourceFileRequest, (void*)0>(swift::ParseSourceFileRequest const&) + 156
14 swift-frontend           0x00000001106257d5 swift::ParseSourceFileRequest::OutputType swift::evaluateOrDefault<swift::ParseSourceFileRequest>(swift::Evaluator&, swift::ParseSourceFileRequest, swift::ParseSourceFileRequest::OutputType) + 37
15 swift-frontend           0x000000011061b40b swift::SourceFile::getTopLevelItems() const + 123
16 swift-frontend           0x00000001103f1f06 swift::SourceFile::dump(llvm::raw_ostream&, bool) const + 38
17 swift-frontend           0x000000010ef02fe3 dumpAST(swift::CompilerInstance&) + 467
18 swift-frontend           0x000000010eef5006 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 2038
19 swift-frontend           0x000000010eef391b swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 3243
20 swift-frontend           0x000000010ece354a swift::mainEntry(int, char const**) + 2282
21 dyld                     0x000000012bf7e52e start + 462
/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/ASTGen/Output/verify-parse.swift.script: line 6: 55123 Illegal instruction: 4  /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swift-macosx-x86_64/bin/swift-frontend -target x86_64-apple-macosx10.13 -module-cache-path /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swift-macosx-x86_64/swift-test-results/x86_64-apple-macosx10.13/clang-module-cache -sdk '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk' -swift-version 4 -define-availability 'SwiftStdlib 9999:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -define-availability 'SwiftStdlib 5.0:macOS 10.14.4, iOS 12.2, watchOS 5.2, tvOS 12.2' -define-availability 'SwiftStdlib 5.1:macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0' -define-availability 'SwiftStdlib 5.2:macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4' -define-availability 'SwiftStdlib 5.3:macOS 11.0, iOS 14.0, watchOS 7.0, tvOS 14.0' -define-availability 'SwiftStdlib 5.4:macOS 11.3, iOS 14.5, watchOS 7.4, tvOS 14.5' -define-availability 'SwiftStdlib 5.5:macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0' -define-availability 'SwiftStdlib 5.6:macOS 12.3, iOS 15.4, watchOS 8.5, tvOS 15.4' -define-availability 'SwiftStdlib 5.7:macOS 13.0, iOS 16.0, watchOS 9.0, tvOS 16.0' -define-availability 'SwiftStdlib 5.8:macOS 13.3, iOS 16.4, watchOS 9.4, tvOS 16.4' -define-availability 'SwiftStdlib 5.9:macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0' -define-availability 'SwiftStdlib 5.10:macOS 9999, iOS 9999, watchOS 9999, tvOS 9999' -typo-correction-limit 10 /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/test/ASTGen/verify-parse.swift -dump-parse -disable-availability-checking -enable-experimental-feature ParserASTGen > /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/ASTGen/Output/verify-parse.swift.tmp/astgen.ast

Could you debug the failure?

Could you debug the failure?

This is a weird issue because all I did was add new lines between the functions and it broke the CI. I just pushed up changes to resolve merge conflicts and updated the branch completely. Maybe that is the fix?

This is a weird issue because all I did was add new lines between the functions and it broke the CI. I just pushed up changes to resolve merge conflicts and updated the branch completely. Maybe that is the fix?

Unlikely. You've made quite a few changes, including entirely rewriting the function that contains the tripping fatal error. According to the stacktrace, you're fatal erroring in swiftASTGen.ASTGenVisitor.generate(SwiftSyntax.Syntax) -> swiftASTGen.ASTNode: https://github.com/apple/swift/pull/68574/files#diff-627bedb4ff4c21e0c31e3af2850fdc80643131077504c697cd31e4a4af16799dR274
You'll need to figure out what cases you're missing and either figure out why you're hitting them if they're not supposed to be hit, or implement them.

@ahoppen could you run the tests please?

@swift-ci please test

@swift-ci Please test Linux

@swift-ci please test Linux

@swift-ci please test Linux

@swift-ci Please test Linux

recent changes pushed to main are not 100% working. On line 161, I am getting the error
Value of type 'TypeEffectSpecifiersSyntax' has no member 'thrownError'

This same issue is ocurring on the main branch

recent changes pushed to main are not 100% working

swift/main depends on swift-syntax/main when the early swift-syntax build is enabled. Did you manually pull changes? Normally, you should rely on update-checkout instead to sync up with dependencies.

cleanup the commit history

I am having trouble with the cleanup because even though I have only 16 commits, all the commits from when I merge with main show up too. It is a long list of like 500 commits. Do I only need to change the most recent commit to squash and then all the rest will be combined to that one?

Did you manually pull changes?

I did manually pull changes......

I am having trouble with the cleanup because even though I have only 16 commits, all the commits from when I merge with main show up too. It is a long list of like 500 commits. Do I only need to change the most recent commit to squash and then all the rest will be combined to that one?

Running git rebase main on your branch should get rid of the merge commit (you will be asked to re-resolve the conflict in the process). Once the merge commit is gone, you can proceed with an interactive rebase on main to perform the rest of the clean-up.

sorry to all for adding as reviewers, please ignore 😅

How'd it go? Need help?

How'd it go? Need help?

It went alright, I think. I cleaned up past commits but I don't think it was 100% right. After I ran git rebase main, I ran the git rebase -i HEAD~N and changed all commits to squash except the first one.
[ASTGen]: Implementation of visit(syntax) method

I then force pushed to the PR and it did remove all the extra commits I wanted gone. But then, it added all past commits from others (which is why it added them as reviewers), and I simply did the same thing but changed commits to drop. However, it was outdated with main and I had to force push main again. There are now 3 commits instead of 1.

It went alright, I think. I cleaned up past commits but I don't think it was 100% right. After I ran git rebase main, I ran the git rebase -i HEAD~N and changed all commits to squash except the first one.

You can just run git rebase -i main in this case, which maybe we should change the docs to suggest over HEAD~N. The second commit can be squashed and the last commit shouldn't be needed at all.

But then, it added all past commits from others (which is why it added them as reviewers), and I simply did the same thing but changed commits to drop. However, it was outdated with main and I had to force push main again. There are now 3 commits instead of 1.

It's not clear to me how this could have happened, did you do any re-ordering of commits in the rebase?

did you do any re-ordering of commits in the rebase

I did not do any reordering of commits in the rebase. Should I cleanup the 3 commits or is what I have fine?

I did not do any reordering of commits in the rebase. Should I cleanup the 3 commits or is what I have fine?

Squashing them would be appreciated 🙇♂

Should I cleanup the 3 commits or is what I have fine?

After squashing and getting rid of the merge commit, please consider breaking up your changes into at least 2 meaningful commits rather than cramming everything into a single one. For example, the first one removes the conformance, and the second renames the methods.

please consider breaking up your changes into at least 2 meaningful commits rather than cramming everything into a single one

I think it's fine in this case, it's fairly self contained as is.

@swift-ci please test

@saehejkang
[ASTGen]: Updates to BridgedSourceLoc function calls

That should definitely be a separate PR, is there any reason you added it to this one?

@bnbarham I just pushed up one last commit. It should be good to go now.

@bnbarham I just pushed up one last commit. It should be good to go now.

I saw, see my above comment. I'd prefer that one in a new PR.

That should definitely be a separate PR, is there any reason you added it to this one?

I added this commit to keep things in line with main. It was out of date by one commit and I think I missed it while rebasing. The changes I have in this PR are reflected correctly and no changes are technichally being made that are different to main.

Ok @bnbarham I got the rebase working correctly and now there is only one commit 😎

I think it's fine in this case, it's fairly self contained as is.

I don’t mind as much, but would love a more descriptive commit message, like the title of the issue.

I don’t mind as much, but would love a more descriptive commit message, like the title of the issue.

I don't mind updating it

I don’t mind as much, but would love a more descriptive commit message, like the title of the issue.

Sure, all for a more descriptive title and description in the commit :)

@swift-ci please test


Continents and biogeographical realms

I spent a bit of time recently cleaning up the "continentDistribution" and "biogeographicRealm" columns. I fixed most of the obvious issues, but there's room for more clarification. We probably won't have time soon to dive deep into this area, so I'll just write up some thoughts here.
Definitions
The MDD defines its biogeographic realms based on a map in Wikipedia/Commons: https://commons.wikimedia.org/wiki/File:Ecozones.svg. However, this is of course editable by anyone, and if you look at the history, there have been a few changes recently. For example, someone moved the Sulawesi area from Indomalaya to Australasia and someone else moved Fiji and Vanuatu from Australasia to Oceania. The map is also not supported by any citations. I don't think any part of the map is necessarily wrong, but it would be better for MDD to adopt its own definitions that don't rely on an external map that keeps changing. I also have some nitpicks with a few of the specific boundaries; see below.
MDD already uses its own definitions for the continents, which is good.
Indomalaya/Australasia boundary (realms) and Asia/Oceania boundary (continents)
Our current definitions place the realm boundary between Indomalaya and Australasia at Wallace's Line, meaning that Indomalaya contains the Sunda Shelf and the Philippines, and Australasia contains Sulawesi, the Lesser Sunda Islands, and the Moluccas. However, the continent boundary between Asia and Oceania is at Weber's line, which is between Sulawesi and the Moluccas. Therefore, the Wallacea area (Sulawesi and the Lesser Sundas) is in the continent of Asia but the realm of Australasia:

Island (group)
Continent
Realm

Java
Asia
Indomalaya

Borneo
Asia
Indomalaya

Sumatra
Asia
Indomalaya

Bali
Asia
Indomalaya

Philippines
Asia
Indomalaya

Sulawesi
Asia
Australasia

Sangihe, Talaud
Asia
Australasia

Lesser Sundas
Asia
Australasia

Timor
Asia
Australasia

Moluccas
Oceania
Australasia

Tanimbar
Oceania
Australasia

Kai Islands
Oceania
Australasia

New Guinea
Oceania
Australasia

The two different boundaries are sort of helpful in that they emphasize the taxa that occur in Wallacea, but I'd prefer to make that explicit. For example, we could add Wallacea as a separate biogeographic realm, or add subregion distributions within Indonesia.
Australasia and Oceania
The latest release mostly uses "Australasia/Oceania" as a realm and "Oceania" as a continent. The source map on Wikipedia separates "Australasia" from "Oceania" and the slash feels awkward, so I recently made a change to separate "Australasia" from "Oceania" as separate realms. This restricts Oceania to only the remote islands of the Pacific (e.g., Fiji and Hawaii), with very few native mammals.
Now there's a new problem: the definitions of Oceania the continent and Oceania the biogeographic realm are different, because the continent includes Australia, New Guinea, and nearby islands, but the biogeographic realm does not. To fix this I would recommend to also add Australasia as a continent. If we also adjust the boundary with Asia (above section), "Australasia" would mean the same thing in the continent and realm columns, which is good.
Palearctic/Indomalaya boundary
The Wikipedia map places the boundary between the Palearctic and Indomalayan regions approximately as follows: from western Pakistan through India along the southern margins of the Himalayas, then into southern China, with approximately the Yangtze River as the boundary. The map has a long bulge of Palearctic in China south of the northernmost Indomalayan area. Taiwan contains both Indomalaya (lowlands) and Palearctic (mountains in the east). The Ryukyu Islands appear to be mostly Palearctic but it's hard to see them.
In practice MDD tends to favor putting things in the Palearctic. I moved a lot of South Asian species that live in the lowland parts of India into Indomalaya, but there are also a lot of species from South China that are currently placed in the Palearctic but probably should be in Indomalaya.
I would favor putting Taiwan fully in Indomalaya, since its mammal fauna as far as I can tell is mostly Indomalayan, though there are some Palearctic elements. I don't have strong feelings on exactly where the boundary should be within mainland China, but I don't think the exact boundary in the Wikipedia map is very defensible.
Palearctic/Afrotropic boundary
The Wikipedia map places this boundary first on a straight line through the Sahara (looks like about 20°N), passing through Mauritania, Mali, Algeria, and Niger, then a little further south in Chad, then a little further north at the Egypt/Sudan boundary. The Arabian peninsula is also in the Afrotropic, with the boundary some way further north in a straight line passing through Saudi Arabia. That means Yemen, Oman, the UAE, Bahrain, and Qatar are fully in the Afrotropic. A small area of coastal southern Iran is also in the Afrotropic.
Some consequences:

The country of Egypt is fully in the Palearctic region. It is mostly in the continent of Africa, except that the Sinai region is in Asia.
The country of Yemen is fully in the Afrotropic region. The mainland is in Asia, but the island of Socotra is in Africa by the MDD's definition.

My thoughts:

The Palearctic/Afrotropic boundary in the Sahara on the map looks very arbitrary, mostly following straight lines and country boundaries. For simplicity I'd favor defining the boundary to follow country boundaries exactly, placing the Western Sahara, Morocco, Algeria, Tunisia, Libya, and Egypt fully in the Palearctic and everything else fully in the Afrotropic.
Putting this much of the Arabian Peninsula in the Afrotropic feels wrong to me based on the mammal fauna, though definitely the southern coast has some African elements.
I would not put any of Iran in the Afrotropic; among mammals I don't think there is a significant amount of African fauna, and practically it's easier to put the entire country in the Palearctic.

Nearctic/Neotropic boundary
Here the Wikipedia map places the boundary in the middle of Mexico, with much of the western and eastern coast in the Neotropic (almost reaching the southern tip of Texas in the east) and the north and the central highlands in the Nearctic. Elsewhere the southern tips of Florida and Baja California are in the Neotropic, as are all Caribbean islands.
I would prefer to put all of Baja and Florida in the Nearctic, both for simplicity and because I don't think either area has a lot of Neotropical elements in the mammal fauna.

Many thanks for outlining these issues here Jelle -- super helpful.  Sounds like what we need is an MDD-specific set of criteria that we use to justify the biogeographicRealm and continentDistribution assignments.  Ideally this would be referenced for different more controviersial boundaries, drawing on outside works and/or explaining our reasoning.  We could then post this information on the About page for maximal transparency.  How far away are we from that type of explication, based on what you've written above + other references that you've seen (ideally relying on more authoritative sources than Wiki)?

Yes, I think that's a good goal!
I am not too familiar with the literature on demarcating biogeographical realms, but here's some references I have:

Escalante, T., Rodríguez-Tapia, G., Szumik, C., Morrone, J.J. and Rivas, M. 2010. Delimitation of the Nearctic region according to mammalian distributional patterns. Journal of Mammalogy 91(6):1381-1388. doi:10.1644/10-MAMM-A-136.1
Ortega, J. and Arita, H.T. 1998. Neotropical-Nearctic limits in Middle America as determined by distributions of bats. Journal of Mammalogy 79(3):772-783. JSTOR 1383088


Copy consistency from CEQ

Describe the bug
Copy edits from CEQ received on 3/2/22 will be tracked against this issue.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
See updated living copy with this issue number.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

all QA for this issue passed


tridactyl-native: 1.20.2 -> 1.20.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/tridactyl-native/versions.
meta.description for tridactyl-native is: "Tridactyl native messaging host application"
meta.homepage for tridactyl-native is: "https://github.com/tridactyl/tridactyl"
meta.changelog for tridactyl-native is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.20.3 with grep in /nix/store/f8lvwa8q2inksgfcaaddwr0skhdcwdas-tridactyl-native-1.20.3

directory tree listing: https://gist.github.com/c7353fc3c08d39defd31ba4d03428107

du listing: https://gist.github.com/1c2f13a28272c75995f612b9cf73fca9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
tridactyl-native

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f8lvwa8q2inksgfcaaddwr0skhdcwdas-tridactyl-native-1.20.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tridactyl-native https://github.com/r-ryantm/nixpkgs/archive/f4bd1d1a4bb484938d360234c4ad6dd2881d0b94.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f8lvwa8q2inksgfcaaddwr0skhdcwdas-tridactyl-native-1.20.3
ls -la /nix/store/f8lvwa8q2inksgfcaaddwr0skhdcwdas-tridactyl-native-1.20.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

tridactyl-native

Maintainer pings
cc @timokau for testing.

Result of nixpkgs-review pr 105637 run on x86_64-linux 1

1 package built:

tridactyl-native


Put beacon DKG execution in right context

Closes: https://github.com/keep-network/keep-core/issues/3314
To ensure logs from DKG execution in beacon are in the right context,
the function responsible for DKG execution now accepts DKG-specific logger.

Tested it locally, now the logs from beacon DKG execution seem to use DKG logger and have info on seed attached to them:
2022-09-28T18:56:00.444+0200    INFO    keep-beacon     state/machine.go:184    [member:26,state:*gjkr.commitmentsVerificationState] transitioned to new state  {"seed": "b0aef5886bfae6cf928a6c7f88a08f889e03f2610773214b119f20021c1261b6"}


Move function-like rule check to verification

The check for function-like rewrite rules should be moved into the verification step so that we can provide source locations.

The new location of the function: https://github.com/runtimeverification/haskell-backend/blob/a9ba15843df8c8ea46437dd264294b88a3a3fb52/kore/src/Kore/Rewrite/Step.hs#L237


Add additional docs to the publish script

A number of issues have arisen regarding how tools/publish.js works and what its prerequisites are.
This PR adds additional documentation to publish.js explaining what each docker command does and what prerequisites are needed.
Some issues related to publish.js that would probably be resolved with this documentation:

#44
#32

@b-gran thank you!


add example code for count(1) in Functions.md

Add an example in Functions.md to explain count(1).
This SQL is tested (I'm developing a python module with pybind11 and sqlpp11, so I test it in my python module):
>>> db.count_all_ip_proxy()
MySQL debug: Executing: 'SELECT COUNT(1) AS count_ FROM tb_ip_proxy'
MySQL debug: Constructing result, using handle at 0x104fe7e50
MySQL debug: Accessing next row of handle at 0x104fe7e50
4920
>>>

Thanks for helping with the docs!


Support Epsilla as a document store

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Docarray supports a number of vector databases. Epsilla is an open source vector db with a cloud offering, but not currently supported.
I see a past issue with @JohannesMessner and @JoanFM that indicates docarray is open to supporting any kind of vector db, as long as the requester can contribute this feature. Is this still the case?
I am open to contributing this feature via PRs and will follow the contributing guideline.
Affected Components

[X] Vector Database / Index
[ ] Representing
[ ] Sending
[ ] storing
[ ] multi modal data type

Hey @tonyyanga,
Sure you are more than welcome to contribute this feature. We would really appreciate it.

Thanks! First PR with the code contributions is in: https://github.com/docarray/docarray/pull/1835
I plan to make a second PR to update the docs.

Documentation PR: https://github.com/docarray/docarray/pull/1838
Thank you for the review.


Glob files for library and smart contract development.

The current way antler-proj works is that it uses only the generated file for the source for a library or smart contract.  We should instead generate CMake that globs all of the CPPs in the directories for those apps or libraries for building those respectively.

Closed in #41


controller layer how to use transaction and call model layer function

I have two model: preset and task
Model has many function to operate database via sql.
For example in preset model, I have one method:
preset.model
function add() {
    const sql = `INSERT INTO preset (name) VALUES (a)`
    const result = db.prepare(sql).run()
    return result
}

and I also have the same function in task model file.
Now, I want to do transaction in controller layer
controller
import preset from './preset.model'
import task from './task.model'

// I want to begin transaction
preset.add()
    .then(rows => {
        task.preset = rows.lastInsertRowid
        return task.add(task)
    })
    .then(()=>{
        // I want to do commit
    })
    .catch(err=>{
        // I want to rollback
    })

How can I do?
thanks

Questions like these are not actual issues with better-sqlite3, so they should be posted here. But aside from that, there are multiple ways of implementing things, and nobody can know the best way for you without intimately knowing how your program works, and what it's supposed to accomplish.
Start by educating yourself by reading our documentation on transactions. If something there confuses you, you could ask here or here for clarification.

@JoshuaWise  Thank you for reply.
My project use MVC architecture.
I have two model file: preset.model and task.model, and one controller file.
The preset schema only save name field, task schema has name and presetUid fields
I need to create preset first step and get presetUid,  so that I can add the task.
preset.model.js
function add(preset) {
    const sql = `INSERT INTO preset (name) VALUES ($name)`
    const result = db.prepare(sql).run(preset.name)
    return result
}

task.model.js
function add(task) {
    const sql = `INSERT INTO preset (name, presetUid) VALUES ($name, $presetUid)`
    const param = {
        name: task.name,
        presetUid: task.presetUid
    }
    const result = db.prepare(sql).run(param)
    return result
}

In my controller.js file, I want to use preset.add and task.add function in model file
like this:
controller.js
import preset from './preset.model'
import task from './task.model'
import db from './db'

async function combo() {
    const data = { name: 'preset01'}
    try {
       await db.beginTransaction()   //  I want to start for transaction
       const preset = await preset.add(data)
       const task = {
            name: 'task01',
            presetUid: preset.lastInsertRowid
       }
       await task.add(task)
       await db.commit()  // I want to do commit
    } catch(error) {
        await db.rollback() // I want to rollback
    }
}

I know the documentation of better-sqlite does not have db.beginTransaction(), db.commit() and db.rollback() api. They are example to show what I want to do.
My problem is how can I do then I will get the same feature in my controller file.
Thank you.

It sounds like the issue you're having is with your own app, not better-sqlite3. For general help like this, post here. GitHub Issues are not a general help forum.


Better integration between system and device power modes.

Currently the integration between system and device power management is not portable and very limited.
We need an API which allow:

Select which devices should be suspended and which ones should remain active in given power mode(s).
Select which devices should be configured as wake-up source in given power mode(s).

This is similar to how Linux does things using device_set_wakeup_capable() and device_set_wakeup_enable(), defined in include/linux/pm_wakeup.h.

This was implemented in 8eceeee798743d25ac882cf0374cb062a435cefe


Bert Retraining

Hi Mandar ,
While running spanbert large model , if is not able to capture some of words such as Degree .
The same text if I use other brand like Kurkure it will detect . Can I train coref model with my own dataset .
How do I do it ? I have access to onto notes 5. I'm new in the field on AI . Should I convert my dataset to ontonotes format? How can I train on custom dataset.

Convert your dataset to conll format. (I think It's easiest way)
and convert conll to jsonlines using minimize.py
you can see conll format through results of ./setup_training.sh


Importing 'package:analyzer' increases memory consumption of VM script by 600MB with Dart2

Version: 2.0.0-dev.65.0
The following script consumes ~200MB of system memory during runtime:
import 'dart:async';
Future main() async {
  await new Future.delayed(Duration(seconds: 6000));
}

Adding the following import of 'package:analyzer', Observatory reports that the following script peaks at ~800MB of memory consumption, and settles down to ~700MB.
import 'dart:async';
import 'package:analyzer/analyzer.dart';
Future main() async {
  await new Future.delayed(Duration(seconds: 6000));
}

Triggering a manual garbage collection event has no impact.

cc @mraleph @dgrove

in Dart 2 mode the VM runs the front end in an isolate called the 'kernel isolate'. This isolate runs the front end code and compiles sources into the kernel format. When you add the package:analyzer all of this code is compiled by the front end and it keeps some internal state around to support incremental compilation (used in hot reload). The Dart heap of this kernel isolate accounts for this big jump in the
memory footprint of the process that you are seeing.

You can use 'dart --print-metrics test.dart' with and without package:analyzer to see the dart heap sizes of the kernel isolate

https://github.com/dart-lang/sdk/issues/32953#issuecomment-384006430

currently VM completely discards CFE state between URI loading requests because it has no way of knowing whether there will ever be another URI loading request that might benefit from the cached state - and discarding the state frees significant chunk of memory.

Has this changed? What benefit are non-flutter users seeing from this memory overhead?

I am not sure I understand the relevance of that comment in this context. The comment talks about spawning another isolate, i.e current isolate dies and another isolate is spawned. Yes in that case the state in the front end for the first isolate is discarded completely.

Flutter users do not see this overhead as the front end does not run in the VM for flutter.
The benefits for command line Dart VM users are

ability to run from source
ability to hot-reload app

If the command line offering has a wrapper like 'flutter tools' then the CFE could be decoupled from the VM and this overhead would not exist. It would also mean the uri specified for spawnURI should point to a 'kernel file' and not to the sources.

I am not sure I understand the relevance of that comment in this context.

The context is that my understand was that we weren't holding memory for this type of thing which made the feature request intractable. Now I'm learning that we are holding memory, but it can't be used across isolates, only within an isolate?

ability to run from source

Why does the memory need to be held after parsing has completed and we're running for this use case?

ability to hot-reload app

Do we have documentation on how do do this with the command line VM outside of flutter? Would it be possible to disable this feature and buy back some of the memory?

If I understand correctly, there is nothing special about package:analyzer, other than it is large?

@a-siva To me it seems that most users of the command line VM actually don't do hot reloads. It seems that only our tests do that currently - the only external way to initiate hot reload is to send a vmservice request, which is not wired to any IDE outside of Flutter. So it seems we are just wasting memory if you are running from source. The original implementation of kernel-service did only one-shot compilations and completely discarded compiler state between runs, I think we should go back to this. We should be able to create an incremental compiler lazily when we need hot reload.
We also seem to start kernel-service very eagerly - even when running from the snapshot, which seems like a waste too.
Additionally we should probably shutdown kernel-service after it was used after some timeout - because most command line usages from source only need it once.

@natebosch The comment you are quoting was based on my knowledge of how kernel-service was implemented originally. I completely missed that at some point we started keeping the whole compiler instance around (which does seem wasteful resource consumption-wise).

Agreed with @mraleph that compiler state should be discarded immediately once it is done with the first run. The memory overhead is not justifiable given that hot reload isn't supported in practice outside of flutter.
Is it possible to simply make the current functionality be hidden behind a flag, --enable-hot-reload or something similar?

I like the flag approach, and that it is off by default. I think argument can be made that hot reload is a 'development' only option. This is opaque to Flutter users because the rest of the tooling manages the flag. VM developers can opt in, but the majority of use cases are going to be 'production' command line invocations. Requiring a user of a Dart CLI to both know about and use an opt-out flag would be hard to communicate to users.

I went a checked - now starting a sample app Aqueduct takes 2 GB of memory.
In observatory I can only see 12 isolates having heaps around 10mb each - I think this is unreasonable.
We definitely need to reconsider the current setup with kernel-isolate - because all batch mode applications will severely suffer from this including our own batch mode tools like analyzer, build_runner, DDC workers, etc.
Marking this P0 and assigning Dart 2 milestone.

I am tentatively assigning to @a-siva because it is P0 for triage.

@a-siva To me it seems that most users of the command line VM actually don't do hot reloads. It seems that only our tests do that currently - the only external way to initiate hot reload is to send a vmservice request, which is not wired to any IDE outside of Flutter. So it seems we are just wasting memory if you are running from source. The original implementation of kernel-service did only one-shot compilations and completely discarded compiler state between runs, I think we should go back to this. We should be able to create an incremental compiler lazily when we need hot reload.

That is not true the observatory debugger has the mechanism to do hot reloads and it works today, I am surprised that IntelliJ does not have this wired.
We also get a fairly good amount of hot reload scenario testing which we don't get in other cases.

I like the flag approach, and that it is off by default. I think argument can be made that hot reload is a 'development' only option. This is opaque to Flutter users because the rest of the tooling manages the flag. VM developers can opt in, but the majority of use cases are going to be 'production' command line invocations. Requiring a user of a Dart CLI to both know about and use an opt-out flag would be hard to communicate to users.

I like this suggestion which specifies the VM is running in 'production' mode and no 'development' support is needed.
Lowering priority to P1 as I don't think this is a P0.

Is this really required for Dart2Stable, or could it wait for a patch release?

The memory usage impact is definitely felt by our users and could block some from upgrading.
Also, if we move functionality to behind a flag it would be technically breaking.

I think this could wait for post-Dart2Stable (I don't think it changes the
timeline for the flag, just whether or not it's blocking the release).
On Sat, Jul 7, 2018 at 10:18 AM Nate Bosch<EMAIL_ADDRESS>wrote:

Is this really required for Dart2Stable, or could it wait for a patch
release?
The memory usage impact is definitely felt by our users and could block
some from upgrading.
Also, if we move functionality to behind a flag it would be technically
breaking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/33658#issuecomment-403230496,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAsW8BFLVljcm86mhZ1doMpbXqZqU8Fks5uEO1WgaJpZM4U6Dsa
.

@dgrove in the current form it increases memory consumptions of apps that use isolates spawned from source by hundreds of megabytes per isolate - and this memory cost is completely opaque to the user. Given that the fix is very straightforward and that impact is severe I think it is fair to do this before Dart 2 stable.

+1 to the proposed solution of having an off-by-default flag for enabling the hot reload behavoir.
+1 to keeping this issue in stable given the huge regression in memory usage.

OK, let's leave this in Dart2Stable.

@a-siva are you the right assignee for this?

Can this be closed now that https://critique.corp.google.com/#review/204546507 has landed?


[BUG] TailwindCSS JIT requires a restart every time a new class is inferred

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins.
[x] I use package manager yarn (Fill in: npm, yarn, pnpm, etc).
[x] I run Snowpack on OS Mac (Fill in: Windows, Mac, Linux, etc).
[x] I run Snowpack on Node.js v12+

Describe the bug
Tailwind JIT works by scanning your source files for classes and including them in the css that's built. When used with Snowpack and following the documentation, you must restart Snowpack every time you use a new class, which makes JIT near unusable.
This plugin helps: https://github.com/jadex/snowpack-plugin-tailwindcss-jit
To Reproduce
https://github.com/aaronjensen/snowpack-tailwind-jit-repro

Hello @aaronjensen. I just noticed your discussion with @drwpow  in #2916 then followed through here. For tailwind users this is a hot topic! I have now spend many hours looking into what is actually going on here. Because Snowpack is such a solid concept I decided to not give up so can contribute here.
I hope this will also help the Snowpack authors to accommodate whatever is needed to make the tailwind developer experience exemplary :)
1. Triggering Snowpack to rebuild the CSS
The reason that you need to restart snowpack to see the tailwind changes is that when you change for example a color in tailwind.config.js, snowpack has no idea that it needs to rebuild global.css. This bit is cover-able with a plugin that would mark global.css as when you edit tailwind.config.js. See markChanged() in the plugin API for more details.
2. The real challenge: cache busting
However this is not where the challenge lies... After some digging it seems that even if you mark global.css as changed in a custom plugin, snowpack is very good at caching and will check to see if global.css file has changed before it triggers the file for rebuild... As you don't edit that file, its just used as an intermediary file by tailwind via the postcss chain, it won't bust the cache until it changes. A highly annoying workaround is to add a CSS comment and every time you want to rebuild tailwind, just add a letter. Not a pleasant experience by any account but does prevent having to restart snowpack.
3. Possible solution: bust cache on mark changed
Something for @drwpow and @FredKSchott to consider (as there may be better ways to accommodate this) is a plugin API to bust the cache for a file or, to improve the behaviour of markChanged() to automatically bust the cache when a file is marked as changed (this is what I expected before investigating further).
Maybe this could be added as an option to the markChanged() function?

Just clarifying one thing here:

The reason that you need to restart snowpack to see the tailwind changes is that when you change for example a color in tailwind.config.js

I am not talking about changing tailwind.config.js. I'm talking about using a color in my code that was not previously used while using TailwindCSS JIT. This should not require a restart at all.
As an aside, we are in the process of migrating to Vite for our projects where this works out of the box, so unless something goes wrong in that migration I probably won't have much time to update this issue, but I do still hope it gets fixed for all the other Snowpack + Tailwind users.

@aaronjensen thanks for the clarification. I suspect that your issue is still due to snowpack thinking that global.css is never changed so will never rebuild your tailwind CSS via postcss.

Thanks again for raising this, and taking the time to write up an issue and a great reproduction. I’m happy to announce that we will fix this in the upcoming v3.5.0 release that’s publishing now. Please note that you’ll need to set a new tailwindConfig option in your Snowpack config to take advantage of this. The reason for that is that blowing the CSS cache away more frequently could have performance implications in other non-Tailwind setups, so we require you to tell us that Tailwind is being used.
Please give it a try and let me know if it fixes your problem!

Nice!
Unfortunately I can't try it because I'm still blocked by https://github.com/snowpackjs/snowpack/issues/3082#issuecomment-842714585 :frowning_face:

Thanks so much @drwpow!
Was anybody else on this issue able to get this to work though? My package.json is showing snowpack at 3.5.1. In my existing snowpack.config.js I added:
  devOptions: {
    tailwindConfig: './tailwind.config.js',
  },

And in my tailwind.config.js I re-added:
  mode: 'jit',

However, I'm getting the exact same behavior as before (new classes aren't reflected without restarting snowpack).

I was not able to get this working, and like before it only seems to update on a snowpack restart. I have followed the instructions on the Tailwind setup guide, so I don't know what is wrong. This is the repo I was trying to get it to work with: https://github.com/valtism/react-snowpack

I've tested 3.5.0 with static html and the standard tailwind utility workflow. Both tailwind standard mode and JIT mode worked without any issue.

I've tested 3.5.0 with static html and the standard tailwind utility workflow. Both tailwind standard mode and JIT mode worked without any issue.
The JIT kinda works for me. I still have to refresh the page if console is opened or hard refresh to see the changes.

I've tested 3.5.0 with static html and the standard tailwind utility workflow. Both tailwind standard mode and JIT mode worked without any issue.

The JIT kinda works for me. I still have to refresh the page if console is opened or hard refresh to see the changes.

Ah, I see the issue. It is updating, but does not update until there is a refresh with the cache disabled / hard refresh.
I would like for this to work without refreshing, and ideally with React Fast Refresh.

It turns out I was mistaken earlier (or something changed in my configuration) --- the webpage does not update until I do a hard refresh, like @valtism mentioned (refreshing with the console open does not work for me on Firefox Developer Edition).

Yeah, same here. It requires a hard refresh for the new classes to load.

Disabling JIT seems to fix the issue. But that shouldn't be happening ?

I'm experiencing the same issues listed above. Restarting snowpack causes new classes to load, but changing the classes causes them to disappear. Running latest snowpack, tailwind, and postcss.

For what it's worth, I ultimately decided to switch to Vite. Snowpack has clearly fallen to the wayside, and Fred himself suggested Snowpack users consider the switch:
https://dev.to/fredkschott/5-things-i-learned-while-building-snowpack-to-20-000-stars-b9d
https://dev.to/fredkschott/5-more-things-i-learned-building-snowpack-to-20-000-stars-5dc9

So snowpack is now abandoned 😶
On Fri, 17 Dec, 2021, 8:04 pm Francis Lavoie, @.***>
wrote:

For what it's worth, I ultimately decided to switch to Vite. Snowpack has
clearly fallen to the wayside, and Fred himself suggested Snowpack users
consider the switch:
https://dev.to/fredkschott/5-things-i-learned-while-building-snowpack-to-20-000-stars-b9d
https://dev.to/fredkschott/5-more-things-i-learned-building-snowpack-to-20-000-stars-5dc9
—
Reply to this email directly, view it on GitHub
https://github.com/withastro/snowpack/issues/3246#issuecomment-996768606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFVA4NQQXID3GBV7Q47ELXLURNDATANCNFSM4347W7NA
.
You are receiving this because you commented.Message ID:
@.***>

Seems to be. Only 4 commits since the last release in August.

For what it's worth, I ultimately decided to switch to Vite. Snowpack has clearly fallen to the wayside, and Fred himself suggested Snowpack users consider the switch:
https://dev.to/fredkschott/5-things-i-learned-while-building-snowpack-to-20-000-stars-b9d
https://dev.to/fredkschott/5-more-things-i-learned-building-snowpack-to-20-000-stars-5dc9

Oh noes, that makes me quite frustrated 😞. I've looked at Vite.js and don't see how would I replace Snowpack with it. All I need is fast unbundled frontend build tool with watch. I work with Blazor and thus compile and run server with .NET runtime from DLLs. Which means I need it to transform static files, basically throw couple .pcss and .ts files at it and expect .css & .js ESM modules with imports resolved which I load at runtime as needed.
Vite requires index.html and manual import of every resource, which I don't have nor want to maintain just for the sake of it and what is worse vite build --watch will funnel everything through rollup bundler with no way to opt out. With ESM and HTTP/3 why is that even a thing? Snowpack is by default unbundled and you can choose to use bundler at the end which is in my opinion much better approach.

I've tested 3.5.0 with static html and the standard tailwind utility workflow. Both tailwind standard mode and JIT mode worked without any issue.

Would you mind commenting on how you achieved this? And does this still work on the latest version (3.8.8)?


SNR may have broken with a recent update

Just got 3155b85a-29b0-4de0-8c5e-c23c321bf245.uterm.release and I've not looked into it much, but at least my SNR graph looks broken while the rest of the stuff seems to be working.

Yeah, sadly SNR was removed in that firmware update.
I was going to drop a note in the README, but I didn't want something that was essentially a temporary notice cluttering that up (further...). Maybe I should have kept the issue tracking this (#32) open so people could see it had already come to my attention.


try another

asdf

@quantstruct-bot say hi.

@quantstruct-bot say hi

@quantstruct-bot try to greet me.

@quantstruct-bot try to greet me again.


Make it possible to manually run a plan

What would you like to be added:
It is handy for certain plans (e.g. backup) to be able to manually execute that plan. Currently there is no option, or certainly no straightforward one (I guess you can manually create PlanExecution ?).
My ideal solution would be triggered from CLI, something like kudo execute-plan <instance-name>
Why is this needed:

The KUDO Cassandra Operator will need this soon.
Does it make sense to have a plan CLI entry-point? e.g.:
List plans
$ kudo plan list
deploy
update

Show plan status
$ kudo plan status $plan
<...>

Start plan
$ kudo plan start $plan
<...>

Pause plan
$ kudo plan pause $plan [$phase]
<...>

Resume plan
kudo plan resume $plan [$phase]
<...>

Stop plan
kudo plan stop $plan [$phase [$step]]
<...>

And a couple more advanced ones:
Force-complete plan
kudo plan force-complete $plan [$phase [$step]]
<...>

Force-restart plan
kudo plan force-restart $plan [$phase [$step]]
<...>

partially a duplicate of #741 but let's use this issue for the server-side implementation and the other for CLI


Support for MongoDB time-series collections

This adds support for MongoDB time-series collections, which are available starting in MongoDB 5.0. The changes include:

Switch from mgo to the official MongoDB Go driver
Add options to the MongoDB loader

--url
--document-per-event
--timeseries-collection
--retryable-writes
--ordered-inserts
--random-field-order

Add option to query generator

--mongo-use-naive

Move measurement data to the top level of inserted objects
Support queries using MongoDB naive data format

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: mdcallag:x: gregorynoma:x: henrikedin:x: kaywuxYou have signed the CLA already but the status is still pending? Let us recheck it.

Hello @gregorynoma ! thanks for the PR and all improvements related to mongodb! would you mind fixing the mongo test errors for the broken build?
# github.com/timescale/tsbs/pkg/query [github.com/timescale/tsbs/pkg/query.test]
1440pkg/query/mongo_test.go:23:20: cannot use "github.com/globalsign/mgo/bson".M literal (type "github.com/globalsign/mgo/bson".M) as type primitive.M in append
1441FAIL	github.com/timescale/tsbs/pkg/query [build failed]
1442?   	github.com/timescale/tsbs/pkg/query/config	[no test files]
1443?   	github.com/timescale/tsbs/pkg/query/factories	[no test files]
1444?   	github.com/timescale/tsbs/pkg/targets	[no test files]

Hi @jonatas sorry about that, should be fixed now.

Hey @jonatas, I added those files you suggested as well as incorporated some additional changes we made since the original PR!

This PR is needed. Currently your code doesn't actually support MongoDB at all, but your documentation does, which is misleading.

@y123456yz please, use the branch while it's not merged.

@y123456yz please, use the branch while it's not merged.

got it, thanks.


Broken links in the material design lite FAQ

In the section titled "CAN I BUILD OR USE INDIVIDUAL MDL COMPONENTS (E.G A BUTTON)?", there are two broken links: https://getmdl.io/faq/index.html#individual-components

Change the branch in the url mdl-1.x to get to the files until a fix is landed and new site pushed to update the URLs.
Thank you.

I would love to fix this! 🙋♂


As a user, when I'm looking at the details for an item I want to see an indicator if it's an excerpt or article so I understand the content better.

testing notes
design links
excerpt + article icons

[x] article icon should display for articles
[x] excerpt icon should display for excerpts
[x] book or journal title should display when set, with appropriate title based on type
[x] original page range should display when set
[x] link to item in HathiTrust should go to the first page in range

dev notes

[x] include excerpt/article icons on document detail page based on item type
[x] include additional metadata on document detail page based on item type: book or journal title, original page range
[x] link to view item in HathiTrust or Gale should link to the first page in sequence for the excerpt

Everything above looks good, love how journal/book title on detail view changes automatically depending on content type. Same icon problems as I noted on #397 but we can track them there.
FYI: The HT link to first page works on frontend, but on backend it doesn't. But it works "as a user," so I can track that as an admin issue elsewhere...


HACK: Remove "Open in Vega Editor" from volatility for now

band aids #153
band aids #155

The plot in vega no longer automatically resizes when the window resizes. I don't know if the vega feature itself is broken now, or if something just broke our previous usage of it, but auto resizing the plot on window resize was just causing the plot to grow wider and wider and wider to unreasonable widths.
The plot outside of the vega editor is now too wide. This has to do with the autosize being changed from fit-x to pad. On fit-x it was impossible to effectively resize the plot within the editor. I think if I just reduce the default width this issue may be resolved.
This was happening prior to this PR, but the controls on the bottom of the plot in the editor are all smashed together. I'm not sure why. No matter how much width you give the plot they don't seem to separate.

EDIT: In regards to number 2, the plot being too wide or not outside the vega editor is now entirely dependent on monitor resolution. This is obviously not ideal.

Maybe the answer, at least in the short term, is to leave the autosize on fit-x and not have the text box there to change the width. This also allows us to leave the resize on window size change which is definitely a good thing. I'm really not finding any way to keep things sized nicely and consistently while also allowing the user to edit the width.

while also allowing the user to edit the width.

We aren't really looking to allow that - the textbox is just a by-product of how we were doing dynamic sizing via signal. Once upon a time that was the best way to handle dynamic resize in vega. I think that some time later in the 4.x or 5 series of vega they added new options to vega for including a signal directly in the autosize attribute. I bet there's just a better, more succinct way to do this, now.

@thermokarst in that case, my life just got a whole lot easier. Do we still want to leave all those other modifiable settings down there? They don't seem to be breaking anything. And I'm pretty sure I can ditch that textbox pretty easily now that it's not useful.

I think we need everything listed below, except width:

https://github.com/qiime2/q2-longitudinal/pull/154/commits/211098c66dc03949f5d23993f83f55a98f1df273 This should size the plot pretty well overall. I'll look into making it happen without that textbox. Absolute worst case I can call it something like "width (don't change)" I suppose. Or "width (set autosize type to 'pad' before changing)" those get a bit too long though.

https://github.com/qiime2/q2-longitudinal/pull/154/commits/f02690b2d55cb11dfa2b25aa36ed277b8be4461d Turns out you can just remove the binding to the textbox and it still works just fine.

@thermokarst I'm not seeing any other viz's that use vega

@thermokarst I believe the js changes were also rolled back here, but do you want me to also role back the other changes I made while trying to make the viz work.

@thermokarst I think this one also has the js change reverted. Do you want me to revert the other changes I made when we were trying to get the viz to work too?


[rom_ctrl, dv] Added rom_ctrl_corrupt_sig_fatal_chk testcase

Added rom_ctrl_corrupt_sig_fatal_chk testcase and all the necessary
changes to run the test.
Signed-off-by: Prajwala Puttappa<EMAIL_ADDRESS>

Hi Prajwala! This looks good, thanks. I've made some specific comments below. Also, I think there still needs to be a couple of lines of comment above each case item explaining what it's doing and why it works like that.

Added the comments now. I'm sorry I missed the top comment earlier.


output on create/update/delete to contain namespace

Is this a request for help?: No
What keywords did you search in Kubernetes issues before filing this one?: namespace

Is this a BUG REPORT or FEATURE REQUEST? (choose one): feature request
When a resource is modified in someway, the typical output from kubectl looks like the following:
deployment.apps/nginx created
It would be nice if the output would also contain the namespace like:
deployment.apps/nginx created in default

/remove-lifecycle stale
/kind feature

This sounds like a good idea I'd be happy to work on this if anyone thinks it's a worthwhile addition to kubectl 😄

+1 Sounds like a good idea


Project URL?

Please provide a URL to preview the project

I'm closing the issue now as the URL is now obtained Here


Filter vulnerabilities based on CVSS score

It would nice to have an option to filter issues processed and displayed based on CVSS score.
This would allow us to have a different nsp behavior depending on where the nsp tool is used in a CI pipeline.
For instance: we only display and stop with error for high and critical issues in the standard pipeline run at each commit, but we take all issues in account for daily code quality analysis.

i like this, interesting companion for #130

Already having the severity in the summary output would help filtering the results


Work even when 'fs' not available for require

Sometimes the node module 'fs' is not available, so instead of failing completely, this  will help 'html-to-text' regress gracefully by changing the one dependent library function fromFile to callback with a specific failure, if called at runtime.
Also, by using a string variable as an argument to require, it helps prevent webpack's static analysis from failing if it happens to try making a bundle in an fs-less environment.
Since it seems many others were also having this problem, I'm raising the PR here instead of just creating another fork with the fs code removed.

oh yes.... please merge this!

When is fs not available?

In our particular case we'd like to use html-to-text in an embedded system that has no file system (hence, trying to import fs will fail).  Many of the reported problems are for use in the browser (also no fs).  One could argue the merits of doing html-to-text client-side vs server-side, but it's more arguable that html-to-text should not depend on fs as there's no real need (fromFile is just a simple convenience function that could be in the calling code or should be in a separate library instead, to avoid introducing this otherwise unneeded dependency).  But fromFile and it's fs dependency at this point might break compatibility since people may already be using it, so this PR just makes it conditional with a graceful fallback.

+1, would like to use this in the browser


"Too many open files" error when performing a simple conversion

The .mov is 12.8 mb.
No fancy command-line arguments were used.
There wasn't a newline after "151/610" - I introduced it here for clarity.
> screengif --input screen-recording.mov --output screen-recording.gif
Processing image: 151/610
/usr/local/lib/ruby/gems/2.2.0/gems/screengif-0.0.3/lib/screengif.rb:94:in `contrast': UnableToOpenPixelCache `': Too many open files @ error/cache.c/OpenPixelCache/3720 (Magick::ImageMagickError)
	from /usr/local/lib/ruby/gems/2.2.0/gems/screengif-0.0.3/lib/screengif.rb:94:in `block in start'
	from (eval):2:in `each'
	from (eval):2:in `each'
	from /usr/local/lib/ruby/gems/2.2.0/gems/screengif-0.0.3/lib/screengif.rb:83:in `each_with_index'
	from /usr/local/lib/ruby/gems/2.2.0/gems/screengif-0.0.3/lib/screengif.rb:83:in `start'
	from /usr/local/lib/ruby/gems/2.2.0/gems/screengif-0.0.3/bin/screengif:10:in `<top (required)>'
	from /usr/local/bin/screengif:23:in `load'
	from /usr/local/bin/screengif:23:in `<main>'

>

I closed all non-essential programs and tried again.
It fails at the same place: image 151 of 610.

Thanks for your detailed feedback, I'll look at it when I can!
Please upload input .mov file if possible.


Replace pytz with native zoneinfo module

https://docs.python.org/3/library/zoneinfo.html
Haven't used it yet, seems much simpler than the pytz interface though on first glance.

Yes, it also doesn't break Python's timezone model: https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html


chore print the file path to the log when encountering corruption data pages

Proposed changes
Print the file path to the log when encountering corruption data pages, so that we can know which tablet has corrupted data page.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Adding bookmarks is slow sometimes

today at 10:06:49 AM [pid: 18|app: 0|req: 44/162] <IP_ADDRESS> () {52 vars in 1359 bytes} [Mon Jul 26 14:06:49 2021] GET /api/tags/?limit=1000&offset=0 => generated 3297 bytes in 24 msecs (HTTP/1.1 200) 6 headers in 196 bytes (1 switches on core 0)
today at 10:06:53 AM [pid: 16|app: 0|req: 40/163] <IP_ADDRESS> () {52 vars in 2053 bytes} [Mon Jul 26 14:06:49 2021] GET /api/bookmarks/check/?url=https%3A%2F%2Fwww.amazon.com%2Ffcx%2Fshop-by-age%2Fstore%2Fref%3Ds9_acss_bw_cg_SBATG_2b1_w%3Fref_%3Dfly_sa_hom_rwt_stet_r_2y4y_nvs_165793011%26age%3D2y_4y%26st%3D165793011%26pf_rd_m%3DATVPDKIKX0DER%26pf_rd_s%3Dmerchandised-search-4%26pf_rd_r%3DBYJW4WZYJTNV4B2BKXT5%26pf_rd_t%3D101%26pf_rd_p%3Dcf12e233-413e-4cec-875c-d3d603da0684%26pf_rd_i%3D165793011 => generated 395 bytes in 3541 msecs (HTTP/1.1 200) 6 headers in 189 bytes (1 switches on core 0)
today at 10:06:57 AM [pid: 16|app: 0|req: 41/164] <IP_ADDRESS> () {60 vars in 1551 bytes} [Mon Jul 26 14:06:54 2021] POST /bookmarks/new => generated 0 bytes in 3614 msecs (HTTP/1.1 302) 6 headers in 191 bytes (1 switches on core 1)

Sometimes such check calls finish in 20-50msec, but some other times it takes such a long time. Why could this be happening? How can I fix it?

My database is on SD card, server running on raspberry pi. I wonder if SD card performance is an issue? It's a class 10 Sandisk SD card.

When saving a bookmark the application will fetch the website to get the website's title and description. So saving a bookmark takes longer if the page takes longer to load.
There is currently no way to influence this. There is an open PR (https://github.com/sissbruecker/linkding/pull/126) to apply a timeout to the website request, but it still needs some work.

Closing this as an explanation was given and the PR for adding a timeout was merged.


WL-3284 Don't display multiple teachingDetails.

Drop the addional data and sanitise our JSON a little.

Apart from the last commit, is this mainly a refactor of the 'slot' variable?

Yep, just remove it as it's a duplicate of existing data).


MD preview does not show backslashes

Source
This bug was initially reported as https://github.com/madskristensen/MarkdownEditor2022/issues/70.
madskristensen asked me to post it here, as "This is the rendering component that the extension uses to render the HTML from the markdown source file."
Describe the bug
MarkdownEditor2022 preview does not show backslashes the same way Azure DevOps and Visual Studio Code do.
Tested with Visual Studio Professional 2022 (64-bit) Version 17.3.1.
To Reproduce
Preview attached minimal markdown file README.md with MarkdownEditor2022 and Azure DevOps and and Visual Studio Code respectively.
Expected behavior
MarkdownEditor2022 preview shows backslashes the same way Azure DevOps and Visual Studio Code do.
Screenshots

MarkdownEditor2022 (VS 17.3.1) preview

Azur DevOps preview

Visual Studio Code (1.70.1 6d9b74a) preview

Motivation
Documenting Infrasctructure as Code I want to be able to read and copy Windows and UNC paths from Markdown, e.g. within PowerShell commands.

So the following markdown is producing the correct output for Markdig here (look for markdig (advanced))
Backslash in Markdown Previews

|Count|Code|Markup|
|:--|:--|:--|
|Single|inside| `\` |
|Single|outside| \ |
|Double|inside| `\\` |
|Double|outside| \\ |

Markdig HTML output

  Backslash in Markdown Previews

        Count

        Code

        Markup

        Single

        inside

          \

        Single

        outside

        \

        Double

        inside

          \\

        Double

        outside

        \

So the HTML output from Markdig looks correct to me. I don't know why MarkdownEditor2022 is displaying something different, but looks more a bug there (sorry for the ping-pong!)

Thanks for the immediate response!
I'll switch serving side again ;-)


Hotfix port assignment bug

Hot fix

Coverage increased (+5.5%) to 50.289% when pulling 40faa7c573c0d142416e2a403e47d1087400cb69 on hotfixportbug into 313dfd0d887f728bcc6011625a7db40356814c42 on master.

Coverage increased (+5.5%) to 50.289% when pulling 40faa7c573c0d142416e2a403e47d1087400cb69 on hotfixportbug into 313dfd0d887f728bcc6011625a7db40356814c42 on master.

Coverage increased (+5.5%) to 50.289% when pulling 40faa7c573c0d142416e2a403e47d1087400cb69 on hotfixportbug into 313dfd0d887f728bcc6011625a7db40356814c42 on master.

Coverage increased (+5.5%) to 50.289% when pulling 40faa7c573c0d142416e2a403e47d1087400cb69 on hotfixportbug into 313dfd0d887f728bcc6011625a7db40356814c42 on master.


Package with different values files

When I install or upgrade a release, can I use a different values file inside my package (.tgz)?
For example, my package has two values files:

values.yaml
values-production.yaml

Is there a way to refer a non-default values file which is inside my package (.tgz)?
Is this a good practice to maintain different environment configurations?
Thanks!!!

Yes, I agree @bacongobbler.


Introduce pre-commit hooks and flake checks (#226)

This pull request cherry-picks #226 into ch/hedge-v2, bringing the pre-commit hooks there too. Hopefully it will fix some issues encountered in the past few days.

And now it also contains the fix of #237. We should probably first discuss there if there is any discussion needed, and then merge this one if everybody is happy.


get visitors from GAPI

try to get visitors from GAPI module is installed.

Hello,
Thanks for your PR.
I've modified it in the PR #5 to respect the norm and also, the AdminStatsControllerCore already check if the module is configured.
Best regards


type safety for GUI2

What about checking the types of the API responses in a test version of the GUI (while running automated browser tests) and if they pass running it without type checking?
Checking could by done like this: assign an API response to a typescript variable and give it a type. Then pass it to the typescript transpiler. If the type is wrong, typescript will complain.
Example:
var simpleSearchResponse: searchResponseFormats.searchResponse = {"userdata":{"email":null,"username":null,"firstname":null,"projects_info":[],"user_id":null,"active_project":null,"lastname":null,"token":null,"projects":null,"lang":"en","password":null},"subjects":[{"iconlabel":"Book","valuetype_id":["http://www.w3.org/2000/01/rdf-schema#label","http://www.knora.org/ontology/knora-base#TextValue"],"preview_nx":32,"icontitle":"Book","preview_ny":32,"obj_id":"http://data.knora.org/c5058f3a","iconsrc":"http://localhost:3335/project-icons/incunabula/book.gif","preview_path":"http://localhost:3335/project-icons/incunabula/book.gif","rights":1,"value":["Zeitglöcklein des Lebens und Leidens Christi","Zeitglöcklein des Lebens und Leidens Christi"],"valuelabel":["Label","Title"]},{"iconlabel":"Page","valuetype_id":["http://www.w3.org/2000/01/rdf-schema#label","http://www.knora.org/ontology/knora-base#TextValue"],"preview_nx":94,"icontitle":"Page","preview_ny":128,"obj_id":"http://data.knora.org/fcac0fe61801","iconsrc":"http://localhost:3335/project-icons/incunabula/page.gif","preview_path":"http://localhost:1024/knora/incunabula_0000001228.jpg/full/full/0/default.jpg","rights":1,"value":["h8r","Identität: Der Holzschnitt ist möglicherweise identisch mit Schramm, Bd. 21, Abb. 690. (siehe \"Zeitglöcklein, 1490\", Bl. c6v)."],"valuelabel":["Label","Comment"]},{"iconlabel":"Book","valuetype_id":["http://www.w3.org/2000/01/rdf-schema#label","http://www.knora.org/ontology/knora-base#TextValue"],"preview_nx":32,"icontitle":"Book","preview_ny":32,"obj_id":"http://data.knora.org/ff17e5ef9601","iconsrc":"http://localhost:3335/project-icons/incunabula/book.gif","preview_path":"http://localhost:3335/project-icons/incunabula/book.gif","rights":1,"value":["Zeitglöcklein des Lebens und Leidens Christi","Zeitglöcklein des Lebens und Leidens Christi"],"valuelabel":["Label","Title"]}],"thumb_max":{"nx":94,"ny":128},"nhits":"3","paging":[{"current":true,"start_at":0,"show_nrows":3}],"status":0};

The problem is however, that you would have to write the response to a file and then pass this to the typescript compiler.

This issue has been inactive for a significant time, so we’re closing it for now. If it’s still relevant, feel free to reopen.