Implement StreamTable and StreamTableProvider (#7994)

Which issue does this PR close?

Closes #7994
Rationale for this change

See ticket
What changes are included in this PR?

Implements StreamTable and StreamTableProvider as in the design proposal. Also defines a DefaultTableFactory that wires this up as the default for unbounded tables.
Are these changes tested?

Are there any user-facing changes?

Thx @tustvold, I believe that the proof of concept is looking good. My opinion:
Instead of creating a new TableProvider for FIFO, we could use a StreamingTableProvider including its factory. We can obtain the correct factory by using the UNBOUNDED (can be change like STREAM) keyword in SQL. Additionally, we can leverage a new StreamSinkExec and valid DataSink implementations to handle different use cases like FIFO or Kafka. I think this approach could scale effectively. For FIFO, there are different types of formats as well, also a potential Kafka Sink may implement different types of BatchSerializers. This was in my mind for a time but couldn't find the necessary time to code it. Does it seem like fine plan?

I believe we can use your implementation of DataSink for FIFO, nicely coded 👍🏻

Instead of creating a new TableProvider for FIFO, we could use a StreamingTableProvider including its factory

So this is what I started on implementing, but I wasn't really sure how this interface would materially differ from the existing interfaces used by this PR. In particular I'm struggling to devise an interface that would substantially reduce the amount of boilerplate, whilst still preserving the necessary flexibility. Perhaps I am missing something?

Instead of creating a new TableProvider for FIFO, we could use a StreamingTableProvider including its factory

So this is what I started on implementing, but I wasn't really sure how this interface would materially differ from the existing interfaces used by this PR. In particular I'm struggling to devise an interface that would substantially reduce the amount of boilerplate, whilst still preserving the necessary flexibility. Perhaps I am missing something?

To help with this subject, let's break it down into smaller parts. We can begin by focusing on the FIFO table and finding ways to optimize the SQL involved. Additionally, for external tables that are unbounded, we can create FIFO tables with the proper formatting, starting with CSV and AVRO. When it comes to session state, we keep TableProviderFactory as
    /// This is used to create [`TableProvider`] instances for the
    /// `CREATE EXTERNAL TABLE ... STORED AS <FORMAT>` for custom file
    /// formats other than those built into DataFusion
    table_factories: HashMap<String, Arc<dyn TableProviderFactory>>,

which is not scalable. Currently, Datafusion SQL is closely intertwined with the ListingTable approach, which resulted in FIFO support within the ListingTable. To avoid this, we need to be able to use multiple TableProviderFactory instances for a single format, by specifying the connector.
TL:DR, this part should change to scale the support.
async fn create_custom_table(
        &self,
        cmd: &CreateExternalTable,
    ) -> Result<Arc<dyn TableProvider>> {
        let state = self.state.read().clone();
        let file_type = cmd.file_type.to_uppercase();
        let factory =
            &state
                .table_factories
                .get(file_type.as_str())
                .ok_or_else(|| {
                    DataFusionError::Execution(format!(
                        "Unable to find factory for {}",
                        cmd.file_type
                    ))
                })?;
        let table = (*factory).create(&state, cmd).await?;
        Ok(table)
    }

which is not scalable

I don't see why you couldn't have a TableProviderFactory that itself delegates out to other TableProviderFactory based on some criteria? Perhaps I am misunderstanding what you mean by scalable?

I've marked this ready for review as I think the feedback is this is a sound approach, but feel free to correct me if I am wrong

AFAICT this breaks use cases including creating external tables reading from FIFO files that used to have built-in support

TBC this PR simply updates the fifo tests and makes no changes to ListingTable, which would instead be a follow on PR. The idea of this PR is to show that removing the functionality from ListingTable, whilst it would still represent a breaking change, would not require major architectural changes to existing workloads, nor would it require introducing new abstractions to DF. If you feel this hasn't been demonstrated please let me know how I can articulate this better.

We have discussed this today in detail. We will come back with a design/proposal early next week. Let's iterate together to find the best design. We will also help with the implementation when we converge.

Given I think this PR has demonstrated the existing APIs can accommodate streaming use-cases, perhaps we might move forward with this and potentially refine things later? I'm keen to find a way to keep things moving so we don't hold up #8029 and by extension the next DF release

I don't think we should merge this without getting consensus / ensuring the synnada team has reasonable way forward, especially there are other options (e.g. an arrow patch release) that can unblock the datafusion release
In particular, I think the tradeoffs between different implementation options and order come down to who is going to do the work, and I think there are ways it doesn't all fall into @tustvold . I will try and set up a call / some forum to discuss this and will post notes on the outcome

We anticipate to have @metesynnada's design proposal, which aims to embody the discussions in Issue #7994, in a weeks time. The proposed design will provide an API for streaming sources that will decouple them from ListingTable. We propose to not merge this draft, iterate on the upcoming proposal to converge on a design as a community, and hold off on upgrading to arrow-rs 49.0.0 during this process. We do so as this upgrade removes the append functionality from object_store, which is critical to the current implementation of FIFO functionality in Datafusion.
We aim to resolve the situation in approximately two weeks, with the following end state: (1) We will have merged the converged-on design decoupling ListingTable from streaming sources, (2) We will proceed with the upgrade to arrow-rs 49.0.0.
In the meantime, we may make a serde-fix-backported 48.1.0 release of arrow-rs to get Datafusion benefit from this fix.

We anticipate to have @metesynnada's design proposal, which aims to embody the discussions in Issue #7994, in a weeks time. The proposed design will provide an API for streaming sources that will decouple them from ListingTable. We propose to not merge this draft, iterate on the upcoming proposal to converge on a design as a community, and hold off on upgrading to arrow-rs 49.0.0 during this process. We do so as this upgrade removes the append functionality from object_store, which is critical to the current implementation of FIFO functionality in Datafusion.
We aim to resolve the situation in approximately two weeks, with the following end state: (1) We will have merged the converged-on design decoupling ListingTable from streaming sources, (2) We will proceed with the upgrade to arrow-rs 49.0.0.
In the meantime, we may make a serde-fix-backported 48.1.0 release of arrow-rs to get Datafusion benefit from this fix.

I think this makes a lot of sense -- thank you @ozankabak . I will prepare a 48.0.1 patch release candidate -- see https://github.com/apache/arrow-rs/issues/5050#issuecomment-1802574764

Marking as draft so we don't accidentally merge this as we work on the updated design

We have discussed this today in detail. We will come back with a design/proposal early next week. Let's iterate together to find the best design. We will also help with the implementation when we converge.

@ozankabak  -- @tustvold said he may have some time to help (and would be interested in assisting the design and implementation to help accelerate this process).
Is it possible to describe the use case you have in more detail?
Given that this particular PR replicates the functionality that already exists in DataFusion using the extension APIs, we think we must not fully understand the use case for which you are designing a solution for.

I will talk to @metesynnada tomorrow and check with him to see where he is at in terms of the proposal. If he is close to getting something he can share soon, it'd be better to just talk about the proposal and collaborate on it directly. If he is not close to having something publishable, we will explain the use cases we are trying to support beforehand. I will circle back tomorrow.

@tustvold said he may have some time to help (and would be interested in assisting the design and implementation to help accelerate this process)

thank you, we appreciate it

It seems to me one of the core tensions here is that ListingTable (the built in table source from DataFusion) uses ObjectStoreto read data.
Therefore, if append is removed from ObjectStore ListingTable can no longer be used directly to append to existing files (e.g. FIFO), though it can make new files in a directory.
Thus one API question  is probably  "should ListingTable" support the ability to modify / append existing files, or should that functionality be delegated to some other structure, possibly even outside the core DataFusion crate.

Thus one API question is probably "should ListingTable" support the ability to modify / append existing files

The proposal in https://github.com/apache/arrow-datafusion/issues/7994 would posit no

uses ObjectStore to read data.

I think it is more subtle than that, the very notion of how ListingTable works is predicated on the notion of immutable files. If files can change following planning, etc... you aren't going to get coherent query results.

Thus one API question is probably "should ListingTable" support the ability to modify / append existing files
The proposal in https://github.com/apache/arrow-datafusion/issues/7994 would posit no

Right, but we have at least one set of users who use that functionality, so I don't think we can just unilaterally remove functionality without getting consensus that moving the functionality downstream makes sense

we can just unilaterally remove functionality without getting consensus that moving the functionality downstream makes sense

I don't think anyone is proposing unilaterally removing anything, the whole exercise has been trying to find a path to accommodate these workloads whilst fixing ListingTable.

The problem is that this PR becomes "ready to merge" instead of a POC PR. I got the idea and iterated on this to come up with a design, as promised. I will publish it today. Indeed, there is enough functionality for FIFO or more use cases without the object store. I agree with separating batch and stream sources to ease the feature development on both sides.
However, pushing this PR means deleting the gatekeepers of the unbounded functionality without an alternative. I do not understand the rush to disable these tests from the rest of the code base. What is the gain here, can you explain if I do not fully understand?

I updated an initial design document on https://github.com/apache/arrow-datafusion/issues/7994#issuecomment-1806791702

I've updated this inline with the design articulated by @metesynnada in - https://github.com/apache/arrow-datafusion/issues/7994#issuecomment-1806791702
As StreamingTable already exists, I had to opt for StreamTable instead

Is the desired behaviour that StreamTable would only be used for unbounded tables, and otherwise ListingTable used?

We would then base our work on top of this to get the proposal implemented more quickly than otherwise.

Thank you for being flexible, this situation is definitely not ideal

Is the desired behaviour that StreamTable would only be used for unbounded tables, and otherwise ListingTable used?

Yes, this would be enough for separation.

Sorry for the delay was pulled into a meeting, https://github.com/apache/arrow-datafusion/pull/8021/commits/0e0ff1484d031c2d47eb5e37aa32e671ed3cf02a adds a DefaultTableFactory that automatically switches between ListingTableFactory and StreamTableFactory based on the unbounded parameter. This I think provides the desired behaviour out of the box behaviour, whilst allowing people to explicitly opt-in to using a specific variant.

I believe this behavior is satisfactory.

unbounded_file_with_symmetric_join has failed on OS X, I have no looked into if this is an intermittent failure, but I note that this test has been ignored since https://github.com/apache/arrow-datafusion/commit/d6c2233e21b6aa7cfb157e5f36c75934f077c167#diff-2f6b05fb3bc4e54422c680dfa47dd8a993cc93fcaa056f678e455cc5d83ae6d0R237
I'm not sure what the history here is, is this a known flaky test that I should keep ignored?

Thanks @tustvold, we will look into this early morning tomorrow and report our findings

The previous locks ensure that the FIFO is read and written in a streaming manner, simulating infinite data streams. This guarantees that each batch produced contains a specific amount of data.
I plan to submit a corrective commit soon to address stucking caused by asynchronous processing and configuration issues in the current implementation.

Thank you, I've also just pushed a commit that configures the readers to respect the configured batch size which may help

Thank you, I've also just pushed a commit that configures the readers to respect the configured batch size which may help

Yes, it is necessary as well. However, I need to figure out some points on async runtime. Then, we can move on I think.

However, I need to figure out some points on async runtime

If you're able to articulate the issue I may be able to help out here.

CI failures are due to logical merge conflicts - https://github.com/apache/arrow-datafusion/pull/8187

Thank you for your help getting this over the line.
@ozankabak any final comments or are you happy for me to proceed?

@tustvold, thank you for helping out with the stopgap. @metesynnada will use this as a foundation as he implements the proposal to completion. Feel free to go ahead and merge this after CI passes 🚀


Create Reverse a String in C++.cpp

A new file has been added.
Proper Code with Comments.
Easy Code for beginners with explanation.
#hactoberfest2022

This repository is excluded from hacktoberfest


Fix microseconds formatting

This fix formatting fractional seconds with leading zeroes and change the format of microseconds when using %f to conform with what's documented:

%f - microseconds in zero padded decimal form, i.e. 025000

Please see the changed tests. I'd like to hear some thoughts on whether the precision should be taken into account when formatting microseconds.
Summary of changes

Pad with zeroes before truncating when formating fractional seconds;
Pad with zeroes and never truncate when formatting with %f.

Coverage increased (+0.1%) to 68.098% when pulling 7f27d3001a6aa5ae10ecd7de01ca7431fb8d2f96 on fsabe:format-us into c86a96af43cb0052249a4899d988aaa4f665982b on bitwalker:master.

Thanks for the fix!


UXO app

Fixed issue with TEMTADS. Added better constraints for optimization requiring cvxopt package.

@dccowan : You might need to add cvxopt package to the requirements


When pruning VGG16, the result is very bad while opening speed-up

Describe the issue:
When pruning the model in the project, I found that speed up would make the results worse, so I intend to use vgg16 to reproduce the pruning results in cifar10 using the file "basic pruners_torch.py". The pruning method is L1 norm, sparsity is 0.5, and prune all convs, that is, I annotated line 260

When speedup is false, finetune 1 epoch, and the model accuracy reaches 82%
When speedup is true, finetune 100 epoch, and the model accuracy is only 53%

Apart from the influence of bias in BN when speedup is False, what else have I ignored? Could you tell me how the following results are reproduced? Thank you very much

Environment:

NNI version: 2.3
Training service (local|remote|pai|aml|etc): remote
Client OS: Windows10
Server OS (for remote mode only): Ubuntu18
Python version: 3.6
PyTorch/TensorFlow version: 1.6
Is conda/virtualenv/venv used?: Yes
Is running in Docker?: No

Hello @iMurphL , I tried this setting in nni v2.5, and the results of finetuning 1 epoch are [no-speed-up 83.96] and [speed-up 84.8].
The reason for its performance so bad in v2.3 example is when we use speed-up, the modules in the model are replaced with the small ones, so the parameters handled by the old optimizer are deprecated. And v2.3 example has a bug, when we use speed-up, it uses the old optimizer to finetune the new compact model.
To fix it, you can initialize a new optimizer after speed-up for finetuning, and recommended using the latest nni version, it has a better speed-up experience.


[WIP] Apple anonymous attestation experimental implementation

This is an experiment to implement Apple Anonymous Attestation validator. When it's validation procedure is confirmed, it will be merged into webauthn4j-core, not webauthn4j-spring-security.

Move to https://github.com/webauthn4j/webauthn4j/pull/357


Is there a way to customize the MathJax fonts?

MathJax supports different fonts according to this webpage?
https://docs.mathjax.org/en/v2.7-latest/font-support.html
Is it possible to set these within Academic?

For support, see https://github.com/gcushen/hugo-academic/blob/master/.github/support.md


Model ActDTo and ContentItemDTo

Two separate Pull Requests, one for each!
Create the models for Act and ContentItem from the Valorant API
https://developer.riotgames.com/apis#val-content-v1

Reopening as this needs to track an addition PR


Error when run ochrona command using a .ochrona.yml without defining a policies key.

Describe the bug
I need to execute the ochrona validation using a .ochrona.yml with only ignore key, but if I don't define a policies configuration with some parameter or even though an  empty police I receive this error.
  File ".venv/bin/ochrona", line 8, in <module>
    sys.exit(run())
  File ".venv/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File ".venv/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File ".venv/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File ".venv/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File ".venv/lib/python3.8/site-packages/ochrona/cli/cli.py", line 107, in run
    config = OchronaConfig(
  File ".venv/lib/python3.8/site-packages/ochrona/config/config.py", line 46, in __init__
    valid = self._validate()
  File ".venv/lib/python3.8/site-packages/ochrona/config/config.py", line 175, in _validate
    if len(self._policies) > 0:
TypeError: object of type 'NoneType' has no len()

But, If I use the .ochrona.yml with the follow content the ochrona validation work normally:
ignore:
  - requests
policies: []

But, adding empty keys for a configuration that I won't use doesn't seem to be necessary.
Apparently the error can occur due to this line because if the polices key does not exist in .ochrona.yml a None value will be returned to self._policies.
To Reproduce
Steps to reproduce the behavior:

Create .ochrona.yml file.
Add the follow content in .ochrona.yml file:

  ignore:
    - requests

Run ochrona command:

ochrona

Expected behavior
Run the vulnerability validation using only ignore key inside .ochrona.yml.
Background (please complete the following information):

OS: Ubuntu 20.04.4 LTS
Python Version: 3.8.10
Ochrona Version: 2.0.0
Ochrona Arguments: None or -r requirements.txt --report_type FULL

Thanks for reporting the detailed issue, @igor-rodrigues1 . I'll get a fix up for this as soon as possible


No way to detect connection(registration) success or failure of LeshanClient

Hi.
Is there a way to monitor the connection status of of LeshanClient?
It would be much better if it can provide a callback or listener interfaces.
Thanks.

You can register a ClientRegistryListener which will be notified when a client registers, deregisters. It does not (yet) notify listeners about failed registration attempts, though. Maybe you can provide a PR adding this behavior?

First of all, thank you for the comment.
The ones you’ve explained is about the server side details which I’m already acquainted of.
I want to know about the detail way at the client side. (after LeshanClient.start() is called)
As an alternative, I'm going to call LeshanClient.getRegistrationId() and check the ID value periodically.
Is this a right way??

I see. AFAIK there is no way to register a listener for lifecycle events on the client. But I think this would be a great addition. Would you be interested in creating a PR for it?
Yes, you should be able to determine whether the client is registered or not by polling LwM2mClient.getRegistrationId(). The registration ID is set to null on de-registration. However, AFAIK this feels like a hack. Providing a way to register a lifecycle listener seems like a better solution to me.

Unfortunately providing a PR is not possible for me. Thanks for the answer. :)
P.S Should I close this issue now?

That's a pity :-(
I would like to keep the issue open, though, as an idea for future enhancement ...

The PR #135  aims to fit this need

PR #135 integrated in master (commit 6d3e54818c41df4ccb12faf7215b9745bf23a19c)


License

Please provide license file, or just mention license type in readme, please. Describing at least basic terms of use will also be great.

👌


Fail to compile the example on termux

Firstly, thanks for the awesome testing framework.
I've used libcester on termux, but failed to compile the given example. The errors are as follows:

In file included from ./test.c:2:
/data/data/com.termux/files/usr/local/include/exotic/cester.h:283:10: error: field has incomplete type 'FILE' (aka 'struct __sFILE')
    FILE original_stream;                   /**< The actual address of the captured stream. For internal use only.*/
         ^
/data/data/com.termux/files/usr/include/stdio.h:61:8: note: forward declaration of 'struct __sFILE'
struct __sFILE;
       ^
In file included from ./test.c:2:
/data/data/com.termux/files/usr/local/include/exotic/cester.h:407:10: error: field has incomplete type 'FILE' (aka 'struct __sFILE')
    FILE output_stream_address;                         /**< Output stream address. incase the output stream was captured in test it state can be reset. For internal use only. */
         ^
/data/data/com.termux/files/usr/include/stdio.h:61:8: note: forward declaration of 'struct __sFILE'
struct __sFILE;
       ^
In file included from ./././test.c:2:
/data/data/com.termux/files/usr/local/include/exotic/cester.h:3880:13: error: incomplete type 'FILE' (aka 'struct __sFILE') is not assignable
    *stream = *(captured_stream->replaced_stream_handle);
    ~~~~~~~ ^
/data/data/com.termux/files/usr/include/stdio.h:61:8: note: forward declaration of 'struct __sFILE'
struct __sFILE;
       ^
In file included from ./././test.c:2:
/data/data/com.termux/files/usr/local/include/exotic/cester.h:3959:33: error: incomplete type 'FILE' (aka 'struct __sFILE') is not assignable
                        *stream = *(captured_stream->replaced_stream_handle);
                        ~~~~~~~ ^
/data/data/com.termux/files/usr/local/include/exotic/cester.h:367:43: note: expanded from macro 'CESTER_ARRAY_FOREACH'
                                          z\
                                          ^
/data/data/com.termux/files/usr/include/stdio.h:61:8: note: forward declaration of 'struct __sFILE'
struct __sFILE;
       ^
4 errors generated.

My compiler is clang of version 15 on termux. Then I check it on windows with clang of the same version,  and no error happens.
Maybe this error is related to the termux platform, but I'm not sure. If you are free, please check it. Thanks!

Hello, @chenyulue I will try to simulate your environment today to see if I can reproduce the error.
And also I have an update in the pipeline to make the FILE capturing and testing feature optional will merge that to the main branch today.

After some search, I think I've found the reason for the above error.
In the termux, the stdio.h file includes the following snippet:
#if __ANDROID_API__ < 24
#include <bits/struct_file.h>
#endif

The struct_file.h defines the FILE struct. In my phone , __ANDROID_API is 24, so unfortunately in the cester.h header, the FILE is not defined.
So I add the following code into the cester.h header:
#ifdef __ANDROID_API__
#include <bits/struct_file.h>
#endif

After that, at least the given example can be compiled and run successfully. I'm not sure whether there are any other  issues. I'll check it in my real projects.


added swagger for 'actionplan/operation/attempts' , 'operationresults…

…' endpoints and corrected Product Package Secrets endpoint
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask<EMAIL_ADDRESS>(or NullMDR in github) for additional help.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kegangum sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can one of the admins verify this patch?

@kegangum please run the validation tools locally to fix the issues

This PR did not passing the number of checks we have put in place to ensure quality and correctness. Please review them in the Details section and make corrections. Once the checks are passing, please add label ReadyForSDKReview. If you have questions on the errors, feel free to ping me on GitHub or Teams. Thanks.

Thanks Allen . I will fix them in a couple of days .
Thanks,
Keerthana
From: Allen Zhang<EMAIL_ADDRESS>Sent: Friday, May 1, 2020 6:07 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Keerthana Reddy Gangumalla<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] added swagger for 'actionplan/operation/attempts' , 'operationresults… (#9292)
This PR did not passing the number of checks we have put in place to ensure quality and correctness. Please review them in the Details section and make corrections. Once the checks are passing, please add label ReadyForSDKReview. If you have questions on the errors, feel free to ping me on GitHub or Teams. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F9292%23issuecomment-622646473&data=02|01|Keerthana.Gangumalla%40microsoft.com|c629e0c3bfa94d12244708d7ee35162a|72f988bf86f141af91ab2d7cd011db47|1|0|637239784087215751&sdata=G2im8U9P3VWkxpbjPT%2F5q9XUf80VXFMKYLcikEQAHZ4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPIVCMOOPHAR6J5GFKLOSSLRPNW2LANCNFSM4MWHHACA&data=02|01|Keerthana.Gangumalla%40microsoft.com|c629e0c3bfa94d12244708d7ee35162a|72f988bf86f141af91ab2d7cd011db47|1|0|637239784087215751&sdata=4HHp6%2FTqDka%2BcqSXGQ8Btpdw7t4B8FMQ30hmdHzEIWY%3D&reserved=0.


Partitioned topics stats doesn't appear in "pulsar-admin broker-stats topics" response until get the specific topic stats manually

How to reproduce

Create a partitioned topic
pulsar-admin topics create-partitioned-topic -p 2 persistent://public/default/prt-1

Wait for about a minute and try to get broker topics stats
pulsar-admin broker-stats topics -i | grep prt
You'll get an empty output.

Now try to get the specific topic stats
pulsar-admin topics partitioned-stats persistent://public/default/prt-1
You'll get the topic's stats.

Wait for wait about a minute and try to get broker topics stats again.
pulsar-admin broker-stats topics -i | grep prt
You'll get the topic's stats now.
"persistent://public/default/prt-1-partition-1": {
"persistent://public/default/prt-1-partition-0": {

Pulsar v2.10.0

The topic's stats comes from PulsarStats, which updated at fix rate. You can set statsUpdateFrequencyInSecs(default 60) and statsUpdateInitialDelayInSecs(default 60) to config it.

@AnonHxy, thank you for the reply.
I wait 120 seconds here and get no output:

I waited about 5 minutes with the same result.
This behavior is only for partitioned topics.
Please try to reproduce it.

I think the partition topic has not been created until when we really use it (create a producer/consumer).

@coderzc
I use apachepulsar/pulsar:2.10.0 docker image with bin/pulsar standalone command.
I have only one standalone.conf (broker.conf) option override:
brokerDeleteInactiveTopicsEnabled=false

If the step you mentioned is critical to reproduce, feel free to ask me to record a video or create a repo with docker-compose and the configs.

broker-stats will list the topics which are loaded by the current broker.  So if you create the partitioned topic but without loading it (create producer/consumer),  it can't be listed. Even if you use the topics partitioned-stats.

broker-stats will list the topics which are loaded by the current broker.  So if you create the partitioned topic but without loading it (create producer/consumer),  it can't be listed. Even if you use the topics partitioned-stats.

Aha! @Technoboy- Thank you for the explanation.
For the context, I'm building UI for Pulsar https://www.youtube.com/watch?v=0Xs8phdnta4
And now I see my mistake that I build it against a single-node cluster.
Am I understanding it right that everything under broker-stats APIs should be considered broker-specific and to get the whole Pulsar instance picture, I should ask each broker in my Pulsar instance?
And other resources like tenants, namespaces, functions, etc. aren't broker-specific. I can ask any broker and should get complete (paying eventual consistency into attention) results, right?


nodePackages.netlify-cli: update esbuild

Motivation for this change
Netlify CLI moved to a fork of esbuild which now requires a different "src" value in addition to a more recent version
This is in reference to https://github.com/NixOS/nixpkgs/pull/127291 @happysalada
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 127930 run on x86_64-darwin 1

nixpkgs-review did not catch the change it seems.
The change looks good to me. Leaving this open one more day in case somebody else wants to check.


[HTML5, Chrome] Shader program link error

Building and running - for html5 - the start file (test.blend) in Google Chrome and IE gives the following error:
> Uncaught Could not link the shader program      |     kha.js:13887

But Firefox has no problem at all running the exact same thing...
This also happens with your node-demo you posted on twitter
I don't know if this is a fox only thing, but it is quite recent. Earlier demos - eg. chess - work just fine.

Ugh it also works in Safari but have the same error in Chrome. Thanks for report, I'm on it.

Should be fixed, had to change sampler name in shader. Both fox and sources repo needs to be updated.

Works :+1:


Example project: ExpandableItemIndicator.java onInit method - wrong minimal api level for animated indicator

Source code from example project:
protected void onInit(Context context, AttributeSet attrs, int defStyleAttr) {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            // NOTE: Use animated indicator only on API level 16+ due to performance reason.
            mImpl = new ExpandableItemIndicatorImplAnim();
        } else {
            mImpl = new ExpandableItemIndicatorImplNoAnim();
        }
        mImpl.onInit(context, attrs, defStyleAttr, this);
    }

but animated-vector  element of ic_expand_more_to_expand_less.xml and ic_expand_less_to_expand_more.xml available only from 21 api level

Hi. I believe that is not a bug. Have you tried adding the following setting to your build.gradle?
android {
    defaultConfig {
        vectorDrawables.useSupportLibrary = true
    }
}

In the example app, it uses AnimatedVectorDrawableCompat for animated indicator. Therefore the animation will work on API level 11 or later, but I decided to enable it only for API level 16 or later due to performance reason of both hardware and Android platform.

NOTE:
I made a small modification to ExpandableItemIndicator in the commit d2e954d. It is just a small refactoring, I added shouldUseAnimatedIndicator() method which determines whether to use animations. Override or tweak this method according to your decision.
    protected boolean shouldUseAnimatedIndicator(Context context, AttributeSet attrs, int defStyleAttr) {
        return Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN;
    }

    protected void onInit(Context context, AttributeSet attrs, int defStyleAttr) {
        if (shouldUseAnimatedIndicator(context, attrs, defStyleAttr)) {
            mImpl = new ExpandableItemIndicatorImplAnim();
        } else {
            mImpl = new ExpandableItemIndicatorImplNoAnim();
        }
        mImpl.onInit(context, attrs, defStyleAttr, this);
    }

Sorry. You are right . Thank you :)

I'm trying to write my own sample but "ExpandableItemIndicatorImplAnim" animation for Lollipop and above dosen't work, thought it changes the icon without anim.  Is there any piece of code that I'm missing?


Refactor and reuse input color

Related issue: #13906
Project: CartoDB/product#54
Notes:
The main purpose of this refactor is to reuse a fill input color template and externalize this logic, so it can be used in all the color input fields.

retest this please


Getting Validation query error : 260004 failed to parse a port number. port:

When I am trying to save and test the connection.  I am getting error:
Validation query error : 260004 failed to parse a port number. port:

Remove the protocol string from the beginning of the domain.
https://snowflakecompuing.com => snowflakecomputing.com


terminal is missing characters

for some reason i can only enter keys that are found in my folder name in the terminal. the same goes for what the terminal says back.

That's really weird. Which iPadOS version are you on?

ipados 15 latest beta

Thanks for the additional information. I can confirm that it presents on iPadOS 15 beta 3.

Looks like xterm.js is broken on beta 3's WKWebView.

this issue is occurring for me, when will the next update to the app store app be? I was also wondering if this application has a testflight so that I can submit bug reports for a “beta” version of the app?

this issue is occurring for me, when will the next update to the app store app be? I was also wondering if this application has a testflight so that I can submit bug reports for a “beta” version of the app?
I love the premise of this app and have waited a long time for something like this to show up on the iPad.

I've added the link in README.md. The fix is still waiting for approval and not yet available though.

I noticed that it has only been spaces (at least for me), after stopping the PHP server with the stop button on the terminal, with a side effect of when trying to press space, it slides up the text so it makes it not-visible, then to see it, you have to scroll it back down, but it never inputted the character.


Typescript version

Version 2.1.0 does not exist, please can you update your package.json to versions that work.
Thanks

typescript version has been updated in the package.json ..


chore: Some typo and grammar fix.

What ❔
typo and grammar fixes in various files
Why ❔

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[ x] Documentation comments have been added / updated.
[ x] Code has been formatted via zk fmt and zk lint.

@RomanBrodetski can it be merged?

@FarukhS52 looks like CI lints job fails. Could you please run zk fmt?

@popzxc , actually i am new to github and i don't know about how to work with these commands

Can you tell me where should i run that command

There are instructions on how to set up the repository: setup_dev.md and development.md.
When you'll be able to run zk tool, you can use zk fmt to fix the formatting.


[Feature Request] Send Battery percentage from Server software to SteamVR

I was wondering if it would be possible to send the battery info from trackers to SteamVR maybe via the server I'm not sure how it would be implemented but it would be helpful to see the battery status of trackers within SteamVR

Seem we need to update this three props: Prop_DeviceProvidesBatteryStatus_Bool, Prop_DeviceBatteryPercentage_Float, Prop_DeviceIsCharging_Bool in driver repo
Ref: https://github.com/ValveSoftware/openvr/blob/8f71cf8d9892006939f5e7a9473b6984387a8ec3/docs/Driver_API_Documentation.md#device-properties

the reason I suggested grabbing the battery percentage from the server. I assumed that might be the easiest way to send SteamVR battery info. I don't know how the SteamVR drivers and server fully work so my assumption could be completely wrong

This was done by #668


GLTF animation not running

I am not sure this is a Resium issue but I can't seem to get my GLTF/GLB animation running. I am just trying to make a simple kick-the-tires test of resium/cesium GLTF support. I have a GLB with a single animation (CylinderAnimation) that I would like to turn on. I have tried shouldAnimate/runAnimations without success.
Can you see anything egregious with the below code.
import React from "react";
import { Cartesian3, Color } from "cesium";
import {Viewer, Entity, ModelGraphics} from "resium";

export default function App() {
    let asset = "assets/junk-iss.glb"

    function action(onClick) {
        console.log(onClick + "!")
        // I would like to turn on the animation of my choice.
    }

    return (
    <Viewer full shouldAnimate={true}>
      <Entity
        name="Tokyo"
        position={Cartesian3.fromDegrees(139.767052, 35.681167, 100)}
        point={{ pixelSize: 10, color: Color.WHITE }}
        description="hoge"
      >
          <ModelGraphics
              uri={asset}
              minimumPixelSize={128}
              maximumScale={20000}
              // this appears to have no affect
              runAnimations={true}
              onReady={action("You can cycle animations")}
          />
      </Entity>
    </Viewer>
  );
}

Is the timeline playing? Try <Viewer><Clock shouldAnimate />{/* ... */ }</Viewer> also


docs: add missing package-info.java files to SPI modules

What this PR changes/adds
Add the missing package-info.java files to the SPI modules
Why it does that
Clearify the identity of SPI modules
Further notes
Linked Issue(s)
ref #2710
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] assigned appropriate label? (exclude from changelog with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Will be reopened later


⚠ Bofrost.at has degraded performance

In 467e793, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1240 ms

Resolved: Bofrost.at performance has improved in f9354dc.


Part1 review

Suggested a change to the way sensor brand and dataformat are encoded in part 1, for readability. The new approach is fully consistent with the old one.
Made some other cleanup suggestions.
I'm still working my way through part 1, but I thought I'd send a PR with what I have now, so that it doesn't get even more bloated.

Checklist before merging:

[X] Existing tests still work (check by running the test suite, e.g. from RStudio).
[ ] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[ ] Updated or expanded the documentation.
[ ] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[ ] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #882 (53ef720) into master (b596ca2) will decrease coverage by 0.27%.
The diff coverage is 62.68%.

:exclamation: Current head 53ef720 differs from pull request most recent head bd82eb9. Consider uploading reports for the commit bd82eb9 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   78.40%   78.14%   -0.27%
==========================================
  Files          91       91
  Lines       12149    12062      -87
==========================================
- Hits         9526     9426     -100
- Misses       2623     2636      +13

Files Changed
Coverage Δ

R/g.calibrate.R
59.79% <37.93%> (-5.94%)
:arrow_down:

R/get_nw_clip_block_params.R
46.66% <52.17%> (ø)

R/GGIR.R
65.01% <52.77%> (-1.77%)
:arrow_down:

R/g.readaccfile.R
42.23% <57.14%> (-1.56%)
:arrow_down:

R/g.getmeta.R
60.70% <57.40%> (-0.15%)
:arrow_down:

R/g.inspectfile.R
58.29% <60.43%> (-4.61%)
:arrow_down:

R/g.dotorcomma.R
68.75% <71.42%> (ø)

R/g.getstarttime.R
54.47% <75.00%> (ø)

R/g.part1.R
64.84% <78.57%> (-0.08%)
:arrow_down:

R/convertEpochData.R
78.30% <100.00%> (+0.52%)
:arrow_up:

... and 1 more


Correct "Bus proiders" typo

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/TOC.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Updated pre-req for AWS IAM IdP

Updated pre-reqs per customer request

GitHub Issue: https://github.com/MicrosoftDocs/azure-docs/issues/89963
cc: @jeevansd

@JamesTran-MSFT Updated pre-requisite steps in another PR. so closing this PR now.
#please-close


Support the MongoDB auth_source connect option

Proposed Changes
Allow a different auth source in MongoDB connections. This allows MongoDB users (versus MQTT users) to reside in a database other than "admin".
Types of Changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes issue #XXXX)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, styles...)
[x] DevOps (Build scripts, pipelines...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

[x] I have read the CODE_OF_CONDUCT.md document
[x] All tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if needed)
[x] Any dependent changes have been merged and published in related repositories
[x] I have updated changelog (At the bottom of the release version)
[x] I have squashed all my commits into one before merging

Further Comments
The setup-gleam action started failing in my local GitHub Actions instance. This is likely because of a dependency issues between Ubuntu 18.04 and 20.04. I pinned CI runners to 18.04 until the issue gets fixed upstream.

@varnerac can you please merge upstream, have merged otherPR in the mean time.

@ioolkos done


Editor/Publisher groups per content type

First off, awesome plugin! This is extremely well done.
I had a question about how Workflow should (or could) be setup to handle a particular user group/content type scenario. Here's the roles and the content types these groups have access to.
PR Team (Editors)

News
Blog Posts
Calendar Events

PR Team (Publishers)

News
Blog Posts
Calendar Events

News Team (Editors)

News
Blog Posts

News Team (Publishers)

News
Blog Posts

I have multiple Editor and Publisher groups, but Workflow expects a single Editor group and Publisher group. My groups also vary on content type and even have content type overlap. Does Workflow have a way to manage this type of setup? Or will it at some point?

You should be able to accomplish that by creating master/slave groups for both editors and publishers. All of your permissions (create, edit, etc.) would be set on the slave group(s), the master master controls access to Workflow features. In Workflow settings, point Editor/Publisher user groups to each master. Then, assign users  to both the master and the team specific slave group(s).
`
Editor Master (no permissions)
|---- Editor PR Team (team specific permissions)
|---- Editor News Team (team specific permissions)
Publisher Master (no permissions)
|---- Publisher PR Team (team specific permissions)
|---- Publisher News Team (team specific permissions)
`

Great idea! Didn't even consider this approach. So, just to confirm, you're saying these are the user groups I'd end up with:
Editor
Publisher
PR Team
News Team

And the steps are as follows:

Create two primary user groups with no permissions ("Editor" and "Publisher")
Set up Workflow to use these as the primary "Editor" and "Publisher" groups
Create any additional user groups as needed ("PR Team", "News Team", etc)
When assigning a new user to a group use both types groups. The primary group ("Editor" or "Publisher") and the secondary group ("PR Team", "News Team", etc).

Am I understanding that correctly?

Yes, you would assign users to two groups. The trick is in where the permissions get assigned.
The primary group (editor/publisher) should not define any permissions - it's essentially a placeholder for the Workflow plugin.
The secondary groups are where all the permissions get defined - can create, can edit, can publish, etc. You need at least one secondary group for editors (no publish permission) and publishers. You can have any number of secondary groups (editor or publisher) as needed.
Given your example, you would create four secondary groups:

PR team editor
PR team publisher
News editor
News publisher

Then configure the permissions for the groups as required. For example, PR team editor would get access to create and edit news, blogs and events; PR team publisher would set permissions to publish news, blogs and events. Repeat for News team.
Finally, assign users the both a primary and secondary group:

Editor + PR team editor
Editor + News team editor
Publisher + PR team publisher
Publisher + News team publisher

I suspect that a user could belong to multiple workflows by being a member of multiple groups, yes? So a user could be a Publisher for PR team but be only an Editor for News?

That level of granularity does not seem possible at the moment. Using multiple groups comes close, but is still only a workaround to limit editor/publisher controls to specific sections of the CMS. While you can have many subgroups of each, editors and publishers are still unique and can't crossover. Adding a user as an editor in one area and a publisher in another would cause a permission mismatch.

Great info, @raptureaid. Perhaps one day Workflow will allow the type of functionality @Emkaytoo is asking for. But for now, I believe this covers my particular use-case pretty nicely.
Appreciate the stellar work on this!

@raptureaid Had an additional question here. If you have multiple groups to handle permissions...
Editor Master (no permissions)
|---- Editor PR Team (team specific permissions)
|---- Editor News Team (team specific permissions)

Publisher Master (no permissions)
|---- Publisher PR Team (team specific permissions)
|---- Publisher News Team (team specific permissions)

...and a "News Team (Editor)" requests approval of their new "News" entry won't the email notification go to everyone in the "Publisher" group? Wouldn't these go to users who shouldn't be administrating the "News" channel?


Change group ID to be under org.zaproxy

Change group ID of parent and modules to be under org.zaproxy (e.g.
org.zaproxy.crawljax) to make releases to Maven Central easier. While
all modules were changed only core is essential for ZAP (AJAX Spider
add-on), having all modules under the same group ID allows for easier
test of the changes done to core and hopefully make it easier to get
the changes integrated upstream.

@kingthorin, @psiinon, PTAL (at this and the other pull requests).
Should we use other version number (e.g. 1.0 instead of 3.7) for a following release?

Looks fine to me. Does any of the code tree need to change to align?
I think staying with 3.7 etc is going to be least confusing... but it doesn't really matter to me either way.

I don't think we need to change the package, we aren't going to use both libraries at the same time (and using the same package does not require changing AJAX Spider if/when we start using the main library again).


iOS: Git support

Please add git support for the iOS Keybase app. Being able to checkout an encrypted repo locally with an app like Working Copy would be ideal.
Thanks.

See #13665

I'm the developer of Working Copy and would love to add support for the keybase:// scheme.
It isn't immediately clear to me how best to use a transport scheme from the Keybase app inside another app with the restrictions on iOS, but if you provide any kind of integration or perhaps some SDK I could use, I would be all over this.

+1 for this, did it ever get anywhere? <_<


Added exposing storeLimit and storeOffset for gets and scans

This is very useful if you make active use of column qualifiers and have many sorted columns columns per key

Codecov Report

Merging #52 into master will decrease coverage by 0.71%.
The diff coverage is 12.5%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   42.16%   41.44%   -0.72%
==========================================
  Files          24       24
  Lines        2215     2263      +48
==========================================
+ Hits          934      938       +4
- Misses       1226     1269      +43
- Partials       55       56       +1

Impacted Files
Coverage Δ

hrpc/call.go
53.54% <0%> (-12.33%)
:arrow_down:

scanner.go
86.87% <100%> (+0.16%)
:arrow_up:

hrpc/scan.go
36.12% <20%> (-1.12%)
:arrow_down:

hrpc/get.go
39.36% <28.57%> (-0.87%)
:arrow_down:

region/client.go
79.09% <0%> (-0.91%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3354b8a...ee0a7ca. Read the comment docs.

Your suggestions are great - I was a bit sloppy on the comments. Will put those in.
I signed the contributor agreement and hit submit; I'm not sure where it went but am hoping that all went where it needed to.
I'm trying to get past the codecov audits; it's claming the tests aren't covering the code, yet they are being called from integration_test.go. It's just they are called quite far down the call stack. I'm going to try to call those outside of the normal context and see how I fare. If you have suggestions to help this along I would appreciate it.
Cheers!

Thanks!
I wouldn't worry about code coverage checks failing, as you are right, the integration test don't show up in there (that's why you only see 41% coverage on README, while those actually only unit tests within each specific package).
Right now the only issue you have is merge conflicts with master, once you resolve those, I merge your changes.

I think I have the merge conflicts resolved. If not can you let me know?

Nope, I'm still getting This branch cannot be rebased due to conflicts. Your commit looks empty btw: https://github.com/tsuna/gohbase/pull/52/commits/7e0b6f5f79ff68d0ba9735a3447c548fbc8010a8

Sorry about this; I've not done this before. I think I've just managed to correctly rebase my fork against master. If this doesn't work I may just create a new fork and re-apply the changes.

have you tried something like git pull --rebase https://github.com/tsuna/gohbase.git master? basically you don't want to have merge commits, instead you want your changes to be applied on top of the current master modifying them if there are conflicts. You should look into https://git-scm.com/book/en/v2/Git-Branching-Rebasing.

I thought I had done that. In the end I deleted my fork and re-created it, applying my changes over the top of the latest master.


Image fit circle

I need some help to achieve an easy task. I just want to fit an image inside the circle.
<Svg height={this.props.height} width={this.props.width}>
	{this._renderCircles()}/*render some other elements*/
	<Defs>
		<ClipPath id="clip">
			<Circle cx="50%" cy="50%" r={this.innerSpace / 2 }/>
		</ClipPath>
	</Defs>
	<Image
		x="0"
		y="0"
		height="100%"
		width="100%"
		preserveAspectRatio="xMinYMin meet"
		href={{uri: url, __packager_asset: true}}
		clipPath="url(#clip)"
	/>
</Svg>

The image does not resize to fit the circle. I should not modify main Svg. What am I doing wrong?
Thanks in advance

Same here. @EstebanBP you found a solution?

@dotansimha I couldn't do it. I had to use an Image within a View (React-native components) with position absolute.

I think you probably need to set the viewbox attribute, have you tried that?


Working mode proposition

Hi all,
This is a rough working mode document designed to get us started. Your comments and suggestions here are welcome.

I think that is an excellent start.

OK, so this was merged a bit prematurely. I really would have liked to give the whole AC a chance to have a look at it and comment before it got merged. As GitHub doesn't support re-opening merged PRs, I'm just going to force push to master and create a new PR from this branch.


NO_PROXY environment variable is not respected

I'm currently playing with fluxcd installed by the Flux operator,
https://operatorhub.io/operator/flux, version 0.26.1.
The Openshift cluster where I have installed it is behind a proxy and I have
defined a "cluster wide proxy",
https://docs.openshift.com/container-platform/4.8/networking/enable-cluster-wide-proxy.html,
in my cluster. The "cluster wide proxy" adds the environment variables
HTTP_PROXY, HTTPS_PROXY and NO_PROXY to all pods, where NO_PROXY includes
".cluster.local,.svc" to disable PROXY for kubernetes internal calls.
I'm installing
https://github.com/christianh814/example-kubernetes-goflux-repo, but without
bootstrap/base/ (as Flux has already been installed by the operator) and from an
internal git repository.
When I check the kustomizations I see an error, like below:
$ kubectl -n flux-system get kustomization
NAME      READY   STATUS                                                                                AGE
core      False   failed to download artifact, error: GET http://source-controller.flux-system.svc.cluster.local./gitrepository/flux-system/openshift-gitops-fluxcd-gitrepo/f07b78d3ebe3284afeb1cb7fc1dcdfd29a68b39b.tar.gz giving up after 10 attempt(s)   8m39s
tenants   False   failed to download artifact, error: GET http://source-controller.flux-system.svc.cluster.local./gitrepository/flux-system/openshift-gitops-fluxcd-gitrepo/f07b78d3ebe3284afeb1cb7fc1dcdfd29a68b39b.tar.gz giving up after 10 attempt(s)   8m39s

It looks like the kustomize-controller is using the HTTP_PROXY but not NO_PROXY
and the file it tries to retrieve is not available via the proxy.
When I created a custom docker image,
dawidhaglund/fluxcd-kustomize-controller:v0.20.0-1, for kustomize-controller
where I just run unset HTTP_PROXY HTTPS_PROXY NO_PROXY before /sbin/tini -- kustomize-controller in my entry point script it works fine, so the guess about
NO_PROXY seems valid.
I see this problem with docker image ghcr.io/fluxcd/kustomize-controller:v0.20.0.

Hey @daha, thank you for reporting this. Can you confirm the full contents of NO_PROXY please?
The request is going to http://source-controller.flux-system.svc.cluster.local. and at least from what you provided above NO_PROXY only has .cluster.local,.svc. Meaning that it would still go through the proxy settings.
The screenshot below sets the http_proxy to a non-existent IP, I can simulate your issue, and by amending NO_PROXY with the extra dot it works:

( First call does not end with dot in both NO_PROXY and the request, then I add the dot into the request to reproduce the issue and last I make sure the dot is in the NO_PROXY )

Ok, then I think the issue is that there is a dot after cluster.local which is causing the problem. I did not notice that dot before.
Why is http://source-controller.flux-system.svc.cluster.local. used and not http://source-controller.flux-system.svc.cluster.local without a dot, like for all normal host addresses? If you used http://source-controller.flux-system.svc.cluster.local I believe it would work both with proxy with standard excludes like .cluster.local,.svc and without a proxy.

Reply to my own question. Seems the dot in the end has a special meaning:
http://www.dns-sd.org/trailingdotsindomainnames.html
And there are a pull request in source-controller, https://github.com/fluxcd/source-controller/pull/233, to get around the problem I have.

Nice one @daha, as per PR you mentioned, the --storage-adv-addr flag would helpful here.
I will be closing the issue, but happy to reopen in case we find out later that there is more to it.


Fix for authenitcation issue when using bot framework web api integration

This PR fixes an issue where bot framework authentication was not working with the ASP.NET Web API integration libraries. When calling processActivity on the BF activity, only the parameter for the auth header was being passed through, but the authenitcation libraries in the connector expect the whole header, i.e. scheme and param. cc @drub0y

@garypretty Thanks Gary!!


node-png is incompatible with node 12.x.x

I tried installing my dependencies using 'yarn' and that lead to the process failing mainly 'cause node-png isn't compatible with my current version of node.

Any progress on this?


Default mapper: mark default_make_instance and default_create_custom_instances as virtual

It would be useful to be able to overwrite the two methods mentioned in the title in mappers that inherit from the default mapper.
@elliottslaughter, can you add this issue to #1032 ?

Why do you want to do that? Really only the default_policy_* methods are designed to be overridden since they are policies that you might want to change. If you find yourself wanting to override the actual mechanism functions like default_make_instance (which does what it says without any policy considerations) then that probably suggests you want to be overriding the enclosing mapper interface function instead of messing with the mechanism functions of the default mapper which need to have predictable semantics for all mappers that call them.

The current implementation of default_make_instance forces every region requirement with reduction privileges to create a new reduction instance without checking if there are existing compatible instances (see https://gitlab.com/StanfordLegion/legion/-/blob/master/runtime/mappers/default_mapper.cc?ref_type=heads#L2437).
In my case, I have three tasks, say tasks A, B, and C, launched in succession and with reduction privileges on the same field and region. Tasks A and C apply the same layout constraints on the region requirement with reduction privileges. Task B has different layout constraints. To my understanding, the current implementation of the mapper will always force tasks A, B, and C to have different reduction instances. I would like tasks A and C to share the same reduction instance and B to have its own. I do not think that I can achieve this behavior by just overriding the default_policy_* methods

The current implementation of default_make_instance forces every region requirement with reduction privileges to create a new reduction instance without checking if there are existing compatible instances

Isn't that true of all instances though? If you're calling default_make_instance then you're making an instance no matter what unless you set force_new=false. We should support setting force_new=false for reduction instances which will call find_or_create_physical_instance, but that shouldn't necessitate overriding default_make_instance.

Isn't that true of all instances though? If you're calling default_make_instance then you're making an instance no matter what unless you set force_new=false

That's right. This pattern is particularly critical for the performance of one section of the code and overriding default_make_instance would have been the quickest fix without requiring significant effort from the legion team.
I agree that the better fix is allowing the default mapper to reuse reduction instances, as discussed in #1703.

Ok, I think in general for things like this that fixing the default mapper is probably the right answer rather than allowing default_* functions to be overridden. I think that is likely to cause more problems than it fixes as lots of stuff in the default mapper depends on the semantics of those functions if users change those semantics out from under us then lots of things might be prone to breaking. We're always open to receiving pull requests on the default mapper and they will receive far less scrutiny than stuff that goes into the runtime itself.

https://gitlab.com/StanfordLegion/legion/-/merge_requests/1337 has been merged into master

I'm going to close this as "won't fix" unless someone strongly objects.


configtxgen - add a check for V3 style signature - BFT consensus

Add a check for V3 style signature - BFT consensus
Type of change

Improvement (improvement to code, performance, etc)

Related issues
Issue: #4228 .

@semil can you add a test to validate that your check works as expected?

2023-06-05T13:33:43.2006536Z [1685971554] Config Suite - 2/2 specs •
2023-06-05T13:33:43.2007052Z ------------------------------
2023-06-05T13:33:43.2007381Z • [FAILED] [0.104 seconds]
2023-06-05T13:33:43.2008018Z ConfigTx ConsenterMapping [It] generates an application channel genesis block and checks it contains the ConsenterMapping
2023-06-05T13:33:43.2010612Z /home/runner/work/fabric/fabric/integration/configtx/consenter_mapping_test.go:22
2023-06-05T13:33:43.2010989Z


Retry of failed test cases with data provider will mark as passed[Even though the test has failed]

When executed data provider based test cases using the approach mentioned in https://github.com/Microsoft/vsts-tasks/issues/7545#issuecomment-403024781 the test case is marked as passed, although there are failures in the execution result. Please check the attached screenshot.
       [TestMethod]         [DataSource("Microsoft.VisualStudio.TestTools.DataSource.XML", "TestData.xml", "TestData", DataAccessMethod.Sequential)]         public void VerifyDataProviderTest() 		{ 			var usertype = (string)TestContext.DataRow["User"]; 			Assert.AreEqual("TestData", usertype, "Mismatch"); 		}
https://github.com/Microsoft/vsts-tasks/issues/6294#issuecomment-415294223

As you can see in Attempt # 1 some data provider based test cases failed. But the final test outcome is marked as passed.
Note : Retry of passed test cases is also happening, which shouldn't happen

Hi @mathewkuruvila,
Please send us your build logs with system.debug build variable set as true in your definition. You can send the logs on<EMAIL_ADDRESS>It will also help if you can share a sample project with one of the tests where you observe this behavior. Thanks!

@mathewkuruvila Regarding your note that retry of passed test cases shouldn't happen, that is by design today. The way we execute data driven tests today in VsTest task is by passing the FQDN of the parent test and not individual iterations. In fact discovery of MsTest based data driven tests also returns only one FQDN and not all iterations (that again is by design).

@mathewkuruvila were you able to send your logs?

@prawalagarwal I can't send you the logs. It is against my company policy. You can mock this scenario very easily. Create a test case based on DataSource. Make sure that the test case fails
In VSTS, create a build with retry option. Follow the mitigation approach specific in https://github.com/Microsoft/vsts-tasks/issues/7545
Then you will be able to see the issue.

@prawalagarwal Also for the retry[Passed test cases are getting executed again] is happening only if followed the mitigation approach mentioned in https://github.com/Microsoft/vsts-tasks/issues/7545#issuecomment-403024781 . This won't be helpful if i have some 100 iteration and only 1 failed. So all the test cases will be picked up for execution.
If the above mitigation approach is not used, Individual iteration is passed with the test case for retry but it will fail because of the issue https://github.com/Microsoft/vsts-tasks/issues/6294. So if issue https://github.com/Microsoft/vsts-tasks/issues/6294 is fixed, then everything should be fine. We don't need to follow the mitigation approach and use the normal approach for retry.

@prawalagarwal
Issue is still there after trying the approach which you suggested.
Check if these logs are useful for you
Task         : Visual Studio Test Platform Installer
2018-08-31T01:24:50.2032917Z Looking for the latest pre-release version of the Microsoft.Testplatform.
2018-08-31T01:24:50.2089859Z [command]C:\agent_work_tasks\VisualStudioTestPlatformInstaller_2c65196a-54fd-4a02-9be8-d9d1837b7111\1.1.1\nuget.exe list packageid:Microsoft.TestPlatform -PreRelease -NonInteractive -Source https://api.nuget.org/v3/index.json
2018-08-31T01:24:53.8399902Z Microsoft.TestPlatform 15.9.0-preview-20180816-01
2018-08-31T01:24:53.8925147Z [command]C:\agent_work_tasks\VisualStudioTestPlatformInstaller_2c65196a-54fd-4a02-9be8-d9d1837b7111\1.1.1\nuget.exe install Microsoft.TestPlatform -Version 15.9.0-preview-20180816-01 -Source https://api.nuget.org/v3/index.json -OutputDirectory C:\agent_work_temp\VsTest -NoCache -DirectDownload -NonInteractive
2018-08-31T01:24:58.4601491Z Adding package 'Microsoft.TestPlatform.15.9.0-preview-20180816-01' to folder 'C:\agent_work_temp\VsTest'
2018-08-31T01:25:02.8891897Z Added package 'Microsoft.TestPlatform.15.9.0-preview-20180816-01' to folder 'C:\agent_work_temp\VsTest'
2018-08-31T01:25:02.9019416Z Successfully installed 'Microsoft.TestPlatform 15.9.0-preview-20180816-01' to C:\agent_work_temp\VsTest
Task         : Visual Studio Test
2018-08-31T01:25:28.4272354Z [command]C:\agent_work_tool\VsTest\15.9.0-preview-20180816-01\x64\tools\net451\Common7\IDE\Extensions\TestPlatform\vstest.console.exe "@C:\Users\testagent\AppData\Local\Temp\tmp2D5F.tmp"
2018-08-31T01:25:28.6183041Z Microsoft (R) Test Execution Command Line Tool Version 15.9.0-preview-20180816-01
2018-08-31T01:25:28.6183300Z Copyright (c) Microsoft Corporation.  All rights reserved.
2018-08-31T01:25:28.6222813Z vstest.console.exe "C:\agent_work\23\s\xxx.xxx.xxx\bin\Debug\xxx.xxx.xxx.dll"
2018-08-31T01:25:28.6258658Z /TestCaseFilter:"TestCategory=FailedTestCaseCategory"
2018-08-31T01:25:28.6259097Z /Settings:"C:\Users\testagent\AppData\Local\Temp\tmp2D3F.runsettings"
2018-08-31T01:25:28.6259185Z /Logger:"trx"
2018-08-31T01:25:28.6259301Z /TestAdapterPath:"C:\agent_work\23\s"
**************** Completed test execution *********************
**************** Rerunning failed tests for Test run 48437 *********************
2018-08-31T01:26:04.1549036Z /Settings:"C:\Users\testagent\AppData\Local\Temp\tmp2D3F.runsettings"
2018-08-31T01:26:04.1549129Z /Logger:"trx"
2018-08-31T01:26:04.1549213Z /TestAdapterPath:"C:\agent_work\23\s"
2018-08-31T01:26:04.1549650Z /TestCaseFilter:"FullyQualifiedName=xxx.xxx.xxx.Tests.xxxx.Verify_TestCaseA (Data Row 2)|FullyQualifiedName=xxx.xxx.xxx.Tests.xxx.Verify_TestCaseA (Data Row 6)|FullyQualifiedName=xxx.xxx.xxx.Tests.xxx.Verify_TestCaseA (Data Row 0)"
2018-08-31T01:26:04.4124840Z Starting test execution, please wait...
2018-08-31T01:26:05.2035744Z ##[error]Incorrect format for TestCaseFilter Missing Operator '|' or '&'. Specify the correct format and try again. Note that the incorrect format can lead to no test getting executed.

@prawalagarwal

Yes it is VSTS.

2018-08-31T01:25:23.2561418Z Task         : Visual Studio Test
2018-08-31T01:25:23.2561606Z Description  : Run unit and functional tests (Selenium, Appium, Coded UI test, etc.) using the Visual Studio Test (VsTest) runner. Test frameworks that have a Visual Studio test adapter such as MsTest, xUnit, NUnit, Chutzpah (for JavaScript tests using QUnit, Mocha and Jasmine), etc. can be run. Tests can be distributed on multiple agents using this task (version 2).
2018-08-31T01:25:23.2561965Z Version      : 2.139.9
2018-08-31T01:25:23.2562048Z Author       : Microsoft Corporation
2018-08-31T01:25:23.2562139Z Help         : More Information
Yes, Version is 2.139
2.Not sure what is happening. I shared with you, the important logs. Let me know like which part of the logs needs to be shared with you.

I don't want to use the batch option, coz it will retry all failed and passed test cases. Also a test case will be marked as passed, even if one of the data provider fails. I have mentioned it in the top thread.

@mathewkuruvila On point 3. I think you believe that non batching mode will run only failed iterations because you see this in the log : /TestCaseFilter:"FullyQualifiedName=xxx.xxx.xxx.Tests.xxxx.Verify_TestCaseA (Data Row 2)|FullyQualifiedName=xxx.xxx.xxx.Tests.xxx.Verify_TestCaseA (Data Row 6)|FullyQualifiedName=xxx.xxx.xxx.Tests.xxx.Verify_TestCaseA (Data Row 0)"
I can assure you this a wrong invocation of vstest console and the mstest adapter does not understand individual data rows when passed this way. MsTest adapter onl understands the FQDN in the test case filter. For data driven tests you cannot do away with running the passed iterations again on a rerun. This is by design.
I am guessing your tests are picking up state adapter from somewhere instead of the tools installer task. Can you clean the sources folder (C:\agent_work\23\s) before queuing again. This can be done manually or by using the build definition options:

After this both single agent and batching options should exhibit the same behavior and show correct results.

@prawalagarwal
On Option 3, If retry picks up the passed test cases also, i can't use that. For me more then 100 data are there in the data provider and if only a couple of test cases fail, all tests will be executed[Like wise i have multiple test cases]. So it will take more time and some other test cases might fail in retry. sorry about that.
FYI : I always use the clean option
So is there any way to retry just the failed test cases[With dataprovider option]. I am desperately in search of solution for this.

Tagging @PBoraMSFT for the below ask

So is there any way to retry just the failed test cases[With dataprovider option]. I am desperately in search of solution for this.

@mathewkuruvila the batch option will fix the initial bug you mentioned please use that as a workaround for now.

Ok Thank you

@mathewkuruvila please re-open with relevant logs and screenshots if you are still facing this issue with the latest test platform and adapters.

Hi @mathewkuruvila, did you get any fix for the option 3 (rerun only failed iterations)?
I'm facing the same issue:
When I run my tests, I have several iterations running per test, but only a few of the iterations are failing, however it's rerunning all the iterations, wasting a lot of time rerunning iterations that have already passed.
@ShreyasRmsft or @prawalagarwal, could you please double check this?
Thank you very much.

@neomarck today if a single datarow fails we re-run the whole parent test method. This is a limitation today and the behavior is as designed, this is not a bug.


How to create a bosh account with readonly access on director?

By following Adding/removing Users and Permissions(https://bosh.io/docs/director-users-uaa.html#uaac), it said the newly added user has readonly access but I was able to run bosh recreate job index 0 command after I login as this newly added user.
I tried to remove this newly added user from bosh.admin group but failed.
ubuntu@pivotal-ops-manager:~$ uaac member delete bosh.admin david

RuntimeError: no existing users to delete

ubuntu@pivotal-ops-manager:~$

From the output of command uaac user get user_name it turned out the newly added user david was the exact the same with default user, director.

@David-Pivotal i think it really depends on how you configure UAA. cc @sreetummidi @fhanik

Thank you for your comments. Could you suggest how I can configure UAA to eliminate bosh.admin?

We recently updated the docs here: https://bosh.io/docs/director-users-uaa-perms/#full-read. Given the limited activity, I'm going to close this due to age.


Support dynamic.get and dynamic.get('realmValuePropName')

PR started - https://github.com/realm/realm-dart/pull/1305

Fixed in https://github.com/realm/realm-dart/pull/1533


Support controller manager framework

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

/kind enhancement
What this PR does / why we need it:
The PR contribute to support generic controller manager framework for kahu controller manager
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED
/kind TESTED
Test Report:

Special notes for your reviewer:

@PravinRanjan10 @joseph-v @sushanthakumar
PTAL


Removed expired certs

Keystore shipped with these 8 expired certs. I checked in the latest jdk version (jdk 17) and haven't found any new certificates. Hence we are removing it.
thawtepremiumserverca
identrustdstx3
globalsignr2ca
geotrustglobalca
soneraclass2ca
verisigntsaca
quovadisrootca
luxtrustglobalrootca

Related issue : https://github.com/wso2/product-is/issues/14087

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2630434452

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2630434452
Status: failure


cherry-pick : [NativePDB] Don't fail on import modules.

A recent patch to LLD started emitting information about import modules.
These are represented as compile units in the PDB, but with no
additional debug info.  This was confusing the native pdb reader, who
expected that the debug info stream be present.
This should fix failing tests on the Windows bots.
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@357513 91177308-0d34-0410-b5e6-96231b3b80d8

@compnerd

CC: @adrian-prantl @dcci

@swift-ci please smoke test

@swift-ci please test


:memo: docs: core ideas

The main ideas of the steps around the selection process for a role at Conduent were compiled using Whimsical (image in .png).
A .tex archive was also included in order to we practice the hierarchy organisation of data we are going to insert in the LaTeX document (as bullet points, enumeration, etc.)

thaaaaaaanks ❤


Idea: Base image validation

Using the proposed annotations: https://github.com/opencontainers/image-spec/issues/821
We could identify the base image seam. We can't trust this annotation, but we can use it as a hint. We can do the following:

Fetch the actual base image by combining the digest and location annotations. Basically, strip the tag from the org.opencontainers.image.base.ref.name and add the digest from org.opencontainers.image.base.digest.
Compare the layers from the base image with the layers from the image, pre-seam. They should match exactly.

From there, we can fetch signatures on the base image and verify those against keys/identities.

@ImJasonH @jonjohnsonjr does my annotation-munging scheme make sense?

We could do this in cosign and/or copasetic.
In copasetic it would look something like oci.base_image_ref and oci.base_image_digest just for the raw annotation values, and oci.verified_base_image_ref for fully-qualified ref of the base image (by digest), after verifying the layers.
In cosign, it could look something like cosign verify-base or cosign verify --base, and then everything else would be the same.

This morning, @developer-guy sent me a link about the OCI Base Image Annotations. And just want to look around to see if there is an active discussion issue about this.

What would the cosign's behavior in case there are multiple base images? Let's assume we have the following minimal Dockerfile:
# base image 1
FROM foo:v1 as foo
# base image 2
FROM bar:v1 as bar
# base image 3
FROM baz:v1 as baz

WORKDIR /src

# Create a group and user
RUN addgroup -S qux && adduser -S qux -G qux
RUN chown -R qux:qux /src

USER qux

COPY --chown=qux:qux --from=foo /usr/bin/foo /usr/bin/foo
COPY --chown=qux:qux --from=bar /usr/bin/bar /usr/bin/bar
COPY --chown=qux:qux --from=baz /usr/bin/baz /usr/bin/baz

Sorry, I'm a bit confused here, maybe I'm missing some point about the spec. Actually, is there one base image, which is FROM foo:v1 as foo?

What would the cosign's behavior in case there are multiple base images?

I tried to get support for multiple bases in the proposal, but everybody seemed to hate it, so I gave up.
For my own purposes, I'd also love to be able to express this kind of thing, but I don't think the world is ready for it quite yet. In the meantime, I'm planning just produce a synthetic base index that includes every image you pulled FROM. This would essentially be a snapshot of all your build dependencies at some point in time.

Assuming you have some infrastructure that could update a base index whenever any of its children update, you could use the same mechanism to detect out of date images. For example:
{
  "schemaVersion": 2,
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 7143,
      "digest": "sha256:123...",
      "annotations": {
        "org.opencontainers.image.base.digest": "sha256:123...",
        "org.opencontainers.image.base.name": "deps.example.com/foo:v1"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 7143,
      "digest": "sha256:456...",
      "annotations": {
        "org.opencontainers.image.base.digest": "sha256:456...",
        "org.opencontainers.image.base.name": "deps.example.com/bar:v1"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "size": 7682,
      "digest": "sha256:789...",
      "annotations": {
        "org.opencontainers.image.base.digest": "sha256:789...",
        "org.opencontainers.image.base.name": "deps.example.com/baz:v1"
      }
    }
  ],
}

And maintaining some infrastructure that updates this index whenever any of its children get updated. It's a bit of an abuse of this annotation, but I think it's in the same spirit as the intended use case. I might also just have my own annotation for this thing... who knows.
In general, I want to maintain metadata of the build-time dependency graph between images, and if I have to produce some synthetic placeholder nodes to make that all come together, so be it.


fix timeout when using Xvnc

Hello,
for some reason when using Xvnc, its timeout, please take a look in this screenshoot.
https://itamarjp.fedorapeople.org/tmp/Xvnc-timeout.png
alot of people complained about it in redhat bugzilla
After this patch the error stopped, but I don't know if this is the best solution.
what do you think about ?
do you have a better solution ? how about setting up a socket timeout in g_tcp_connect ?

I think just increasing the default value of delay_ms in xrdp.ini can avoid the issue.
neutrinolabs/xrdp#182
neutrinolabs/xrdp#196

metalefty, this patch looks better than adjusting delay_ms because it will make it works automatically.

:+1:

How would you like to think about automatic delay adjustment again?

@jsorg71 what do you think about automatic delay ?

This includes other changes. I created #457.


Error when trying to load  exported model

I trained the model and exported it by instructions.
I wrote a script to load the model like "load model section "
An error "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf7 in position 1: invalid start byte"
occurred when executing  to this line
fool.load_model(map_file=map_file, model_file=checkpoint_ifle)
I fixed it by change load_graph of fool/model.py
with tf.gfile.GFile(path) as f:
to
with tf.gfile.GFile(path,'rb') as f
Please fix it, thank you!

what the python version and you os ?

python : 3.5
os: ubuntu 16.04


autocomplete like google for suggestions with ui-select

I have a autocomplete like google for suggestions .
how do to add this feature in ui-select ?

I'm guessing you already know about ui-select-choices and search filters like the ones demonstrated on https://github.com/angular-ui/ui-select/blob/master/examples/demo-multi-select.html, but I wanted to point it out in case you'd missed it.

Closing due to lack of info.


Please invite me to the community

Name
James
Additional Context
I really love Infraform Community

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is an open source solution for serverless platforms, it is designed for developing solutions and enhancing creators to create their infrastructure 💻 Great to have you in our community ✨ Looking forward to your valuable contributions! 🤓 You can also check our community ✨ Github ✨ LinkedIn 💜 You can also share our community with other folks who want to learn about development, DevOps, tech, and contribute together and with us 👉💜👈


Using Link component with legacyBehavior+passHref producing warnings

Description
I'm trying to use shadcn NavigationMenu together with the next-intl link, using legacyBehavior+passHref but I'm getting a bunch of the following warnings:
"onClick" was passed to <Link> with `href` of `/about` but "legacyBehavior" was set. The legacy behavior requires onClick be set on the child of next/link

Usage
// Import next-intl Link component returned by createSharedPathnamesNavigation
import { Link } from "@/i18n/navigation";

function NavigationMenuLocalizedLink({ item }: { item: INavigationMenuItem }) {
  return (
    <Link href={item.href} legacyBehavior passHref>
      <NavigationMenuLink>{item.title}</NavigationMenuLink>
    </Link>
  );
}

Tracing back the issue, it looks like nextjs doesn't like setting the onClick property, when legacyBehavior is set.
https://github.com/amannn/next-intl/blob/ed4681fa70b8f67a97e1364deaabf58df302d80c/packages/next-intl/src/navigation/shared/BaseLink.tsx#L76
Verifications

[X] I've verified that the problem I'm experiencing isn't covered in the docs.
[X] I've searched for similar, existing issues on GitHub and Stack Overflow.
[X] I've compared my app to a working example to look for differences.

Mandatory reproduction URL
https://github.com/mschinis/next-intl-bug-repro-app-router
Reproduction description
Steps to reproduce:

Open reproduction
Look at console

Expected behaviour
Expected behavior is to not have any warnings.

The following workaround seems to work for now, but the behavior of the issue still stands:
function NavigationMenuLocalizedLink({ item }: { item: INavigationMenuItem }) {
  return (
    <NavigationMenuLink asChild>
      <Link href={item.href}>{item.title}</Link>
    </NavigationMenuLink>
  );
}

Thanks for the careful report and reproduction!
This could probably be addressed by adding cloneElement in BaseLink in case legacyBehavior is detected. I'm not sure though if it's worth it though, given that—as the name suggests—this is legacy behavior and there are modern alternatives (like the one you suggested).
This was in fact the first time this was reported, so maybe it's a good idea to keep this open to see if more people are affected and to give visibility to the alternative you've posted.

Yes, I'm also facing the same issue. Directly importing from next/link does not have this problem.

This topic came up again in https://github.com/amannn/next-intl/issues/1322 and I've added some details in https://github.com/amannn/next-intl/issues/1322#issuecomment-2329841708.
Will have a look if we can improve something here.

It seems like Radix Primitives will switch to a new API eventually that does not require cloneElement: https://x.com/vladyslavmoroz/status/1863986795601363285


count-less vectors at tail of struct

Thanks for writing this, very neat library - took about an hour to convert a small project from doku.
I'm running into the same problem though: buffers/streams containing bytes which map to
struct Abort {
    user_reason: u8,
    system_reason: u8,
    data: Vec<u8>
}

don't have any means by which to map the size of the tail byte vector. The ::read_to_end method seems the right way to handle the IO, but i'm having difficulty annotating the struct to let it compile since it seem to expect a count. Bit opaque with the error message:
   |
145 |     data: Vec<u8>
    |           ^^^ the trait `Default` is not implemented for `VecArgs<()>`

since there's no default value to speak-of; just a few bytes to read into a Vec<u8>. Am i missing something simple, or do i need to implement a reader to cover the constraints involved?

Check this - https://docs.rs/binrw/latest/binrw/helpers/fn.until_eof.html

Oooh, shiny! Thank you very much. This is a reasonably common thing to process when handling nested protocol frames - might the use case merit some up-front-documented count sugar (count = helpers::all or such)?