Add blogs page with the same design of homepage , link with the blogs in navbar

Content:https://docs.google.com/document/d/1VNNaToMyuFHgUvuu2n_Sr68SD7gwoSEc0MAyLbIFN0c/edit
Please use above docs link, want the content of blogs like above using cards

Hi @Anu27n  I am happy to contribute to this issue and solve it, could i

@LoayTarek5  Go ahead.

Hi @Anu27n, i Could Not find  CONTRIBUTING.md
where Should I get it


Joining a group by invite code doesn't work

java.util.concurrent.TimeoutException: Node[description=iq, attributes={xmlns=w:g2, to=g.us, id=a6-11, type=set}, content=[Node[description=invite, attributes={invite=INVITE_CODE}]]] timed out: no response from WhatsApp
at it.auties.whatsapp.model.request.Request.cancelTimedFuture(Request.java:51)
at it.auties.whatsapp.model.request.Request.lambda$with$0(Request.java:42)
at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

java.util.concurrent.TimeoutException: Node[description=iq, attributes={xmlns=w:g2, to=g.us, id=a6-11, type=set}, content=[Node[description=invite, attributes={invite=INVITE_CODE}]]] timed out: no response from WhatsApp at it.auties.whatsapp.model.request.Request.cancelTimedFuture(Request.java:51) at it.auties.whatsapp.model.request.Request.lambda$with$0(Request.java:42) at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

Should be fixed in 3.0-RC12, let me know

So not sure if I'm doing something wrong but literally nothing happens, sometimes it freezes the bot sometimes it doesn't..  I've tried using the full link and just the code neither have worked

@Auties00 forgot to ping you in previous message

So not sure if I'm doing something wrong but literally nothing happens, sometimes it freezes the bot sometimes it doesn't.. I've tried using the full link and just the code neither have worked

check the latest version, I'm working on a fix. it shouldn't be ready but maybe it works

Still no fix for this issue sadly, I'm working on it though

Still no luck on a solution?

@Auties00 still no luck?

@Auties00 any news or is it just weird?

@Auties00 any news or is it just weird?

I've found no fix. Is this something you need urgently? I can prioritize it if that's the case

@Auties00 any news or is it just weird?

I've found no fix. Is this something you need urgently? I can prioritize it if that's the case

Not urgently, no.. Waiting on it for full release of my bot, but really it's completely fine.. just was wondering if there was an update on it.

@Auties00 any news or is it just weird?

I've found no fix. Is this something you need urgently? I can prioritize it if that's the case

Not urgently, no.. Waiting on it for full release of my bot, but really it's completely fine.. just was wondering if there was an update on it.

Fixed in RC21, please lmk

@Auties00 any news or is it just weird?

I've found no fix. Is this something you need urgently? I can prioritize it if that's the case

Not urgently, no.. Waiting on it for full release of my bot, but really it's completely fine.. just was wondering if there was an update on it.

Fixed in RC21, please lmk

Cool thanks! I found a weird bug that will make the application on certain pcs just not work after reboot, Ill try to find a real cause tho

@Auties00 any news or is it just weird?

I've found no fix. Is this something you need urgently? I can prioritize it if that's the case

Not urgently, no.. Waiting on it for full release of my bot, but really it's completely fine.. just was wondering if there was an update on it.

Fixed in RC21, please lmk

Cool thanks! I found a weird bug that will make the application on certain pcs just not work after reboot, Ill try to find a real cause tho

Can you confirm though that this issue is fixed? so at least we can close this hahaha

@Auties00 sorry m8 to tell you this.. but unless im doing something wrong its still broken..
        api.acceptGroupInvite("code")
``` thats what I was testing, code Ive tried both the link itself and the code itself

@Auties00 sorry m8 to tell you this.. but unless im doing something wrong its still broken..
        api.acceptGroupInvite("code")

thats what I was testing, code Ive tried both the link itself and the code itself

Can you try with RC26? also try to query the code instead of hard coding it, maybe it's expired

@Auties00 sorry m8 to tell you this.. but unless im doing something wrong its still broken..
        api.acceptGroupInvite("code")

thats what I was testing, code Ive tried both the link itself and the code itself

Can you try with RC26? also try to query the code instead of hard coding it, maybe it's expired

Its for sure not an old link since I just generated the link

Also @Auties00 Querying isnt what I want.. Since I just want to join a group via a code that they arent in already...

Just tested it, for some groups it works for some it doesnt.. Ive tried remaking  the link a few times

Just tested it, for some groups it works for some it doesnt.. Ive tried remaking the link a few times

Uhm is there any clear difference between which groups work and which Don't?

No clue one is a big group with 200ish ppl, which for some reason other things don't work in it.. and mine is a small group

No clue one is a big group with 200ish ppl, which for some reason other things don't work in it.. and mine is a small group

What doesn't work? Btw I'll try to use the analyzer to fix it, maybe there are different requests based on the group size and type

Yes, I'll send the error on telegram just because it includes info that I don't feel like removing.

@Auties00 any news on this by chance?
Thanks

@Auties00 any news on this by chance? Thanks

It should work as of now, Whatsapp uses the same exact node. You can try to test it again

Hmm doesn't seem to work, it doesn't throw an exception either.. mind sending a snip it of code to make sure I'm using it correctly? It was also unclear if I'm supposed to use the actual code or the link ( should specify it)
Thanks, shmezi

Hmm doesn't seem to work, it doesn't throw an exception either.. mind sending a snip it of code to make sure I'm using it correctly? It was also unclear if I'm supposed to use the actual code or the link ( should specify it) Thanks, shmezi

Sure send it

@Auties00 I meant that you send a snippet.

Fixed in release 3.4.0


How this package works - Nextjs

I have nextJs application.
Telemetry.ts
import { ApplicationInsights } from '@microsoft/applicationinsights-web';

const appInsights = new ApplicationInsights({
  config: {
    connectionString:
      'InstrumentationKey=<<connectionString>>',
  },
});

appInsights.loadAppInsights();
export { appInsights };

Document.ts
import { Html, Head, Main, NextScript } from 'next/document';
import Script from 'next/script';
import { appInsights } from 'services/telemetry';

appInsights.trackPageView();
appInsights.startTrackPage();
const Document = () => {
return ();
}

The document page is the homepage. So when ever I hit the homepage I can able to see the PageViews logs are getting populated in the log table. But it doesn't give any information like below. What I expect is atleast the url of the page which loads this application. But the below information doesn't provide anything.

I read that difference between operation vs dependency. That the request will be tagged under operations and the response will be under dependency (correct me if I'm wrong). But in the above case even though I can see the page views in logs. I don't see the graph spike for request count in neither the operation nor the dependency. Is there anything I'm missing.

How to log each request(url and page information) for each page views I'm visiting. Is there anything apart from the above need to be done.

The URL for this Web based SDK is obtained from the location.href, if this code is running on the Server side (in the NextJS runtime), then this would indicate that these values are either not available, or the server request is not supplying a mocked version of the location object.
How to populate this (for the automatic) request (on the server) is unknown (we don't use NextJS). However, if you don't have the automatic PageView enabled (enableAutoRouteTracking) and you are manually calling trackPageView() during the initialization, then you can pass in the uri yourself.
appInsights.trackPageView({
    uri: "https://my.url.com/abc"
});


modifying stub

first of all i'd love to thank you for the immense work u've made :)
so u've said that only the stub needed modification to be FUD. but i dont know where to look at in the code lmao.
when i open the pe-union.sln file in VS, could u give me some indication as where to look at ? (peunion, pebuild or pe compiler  folder?
im relatively new to this game, sorry if it seems to be a dumb question.
also if u have some tips to make it FUD  i'd love to hear from a pro.
thanks for everything

when i open the pe-union.sln file in VS, could u give me some indication as where to look at ? (peunion, pebuild or pe compiler folder?

Under SlnBin/Stub you have both stubs.

im relatively new to this game, sorry if it seems to be a dumb question.
also if u have some tips to make it FUD i'd love to hear from a pro.

You really need to have the skills in order to pull something like this off. If you previously were just a user of crypters, then writing one or FUDding an existing will be a very difficult task. It always takes time to get there...

i thought that maybe by adding some junk code it would do the trick lmao.
do u maybe have some tips of what should i start learning in order to make this stub fud again?

In the beta, the amount of junk code was acutally configurable - until I have discovered that it increases the detection rate. So, I have removed that option to not lead users into worsening their detection score. Now the amount of junk code is constant.

do u maybe have some tips of what should i start learning in order to make this stub fud again?

You have two options: If you want to write a crypter or FUD an existing one, you have to start from zero and figure out what works best by reading + trial and error. That's the only way, since there is nobody or forum that will teach for free how to become a good reverse engineer or hacker.
If that's not your passion at all and you're looking for an efficient solution, then there's crypters that cost money. They cost money because it's a rather time consuming job to develop such software, as I have mentioned in FUD.md.

yup i understand completly. but yeah u've already made a fantastic job with this stub
by any change could u redirect me to someone who's selling crypting service?

Since I have no need to buy a crypter, I don't know which paid product is the best. Only thing I know is that it's work to maintain a crypter FUD which is the reason that free ones, like mine, are not FUD - regardless of overall quality of the project.
But if you just need something to use on your binaries, you'll find one ;) Have fun


[gui] Notification date is not correctly shown after refreshing the page

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Do you want to request a feature or report a bug?
Bug

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Create a flow that sends a notification
Make the flow send at least one notification
Go to the Notifications page:

Refresh one or more times. You'll get the following:

I tried refreshing by pressing F5 and Ctrl+F5 too, to check if it would correct the visualization, but it did not.

What is the expected behavior?
The date should be correctly displayed at all times.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version: v0.5.0-rc.1
Environment: docker-compose
Operating system: Ubuntu 18.04

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Note: Problem still occurs in release v0.5.0

Error does not repeat in version v0.6.0-rc.2 (Docker-compose)


Devel mec1501 rtos timer load fix 1

Latest MEC1501 RTOS timer changes. Works around HW taking up to one 32KHz cycle to move load register value into count register. Driver has been tested by MCHP and Intel.

Tried to squash the two commits into one.


ref(build): build all images with buildx

Description:
This change standardizes how all Docker images are built using buildx
to enable multi-platform images. OSM control plane images will be built
for linux/amd64 and linux/arm64. Demo images will be built for
linux/amd64 and windows/amd64.
 The biggest changes are that Go binaries
are built inside Docker instead of the native environment, and the
docker-push-* Makefile targets have been removed. See the dev guide
changes for more details.

For reviewers
This is a big PR, but the "entrypoint" is the Makefile, so that's where I would suggest looking first, then the changes to the Dockerfiles. Everything else is mostly collateral damage from those changes.

Testing done:
I tested the main CI workflow on my fork: https://github.com/nojnhuh/osm/actions/runs/1593840436
I also created a release on my fork to test the release process and artifacts. Images are pushed to my docker hub (nojnhuh) with the tag v0.0.0-multiarchtest.0. I did osm install --set osm.image.registry=nojnhuh and spun up a bookbuyer pod to test pulling/starting the init container and that worked for me.
I have not tested the functionality of the windows/amd64 demo images or the linux/arm64 OSM images. If anyone has a cluster running with nodes that can run those, feedback would be appreciated.

Affected area:

Functional Area

New Functionality
[ ]

CI System
[X]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[X]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No

Did you notify the maintainers and provide attribution?

Is this a breaking change? Makefile targets to build images have been modified, but no user-facing breaking changes.

Codecov Report

Merging #4402 (96fcde7) into main (332b52b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

:exclamation: Current head 96fcde7 differs from pull request most recent head 64eb9c7. Consider uploading reports for the commit 64eb9c7 to get more accurate results

@@            Coverage Diff             @@
##             main    #4402      +/-   ##
==========================================
+ Coverage   69.21%   69.32%   +0.10%
==========================================
  Files         212      212
  Lines       14450    14476      +26
==========================================
+ Hits        10002    10035      +33
+ Misses       4396     4389       -7
  Partials       52       52

Flag
Coverage Δ

unittests
69.32% <100.00%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/catalog/fake.go
33.33% <ø> (+0.18%)
:arrow_up:

pkg/k8s/mock_controller_generated.go
0.00% <ø> (ø)

pkg/k8s/types.go
100.00% <ø> (ø)

cmd/cli/namespace_add.go
83.63% <100.00%> (-0.53%)
:arrow_down:

pkg/configurator/methods.go
73.38% <100.00%> (+2.85%)
:arrow_up:

pkg/envoy/cds/response.go
82.35% <100.00%> (ø)

pkg/envoy/lds/response.go
76.00% <100.00%> (ø)

pkg/injector/init_container.go
100.00% <100.00%> (ø)

pkg/injector/iptables.go
100.00% <100.00%> (ø)

pkg/k8s/client.go
93.01% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01013d7...64eb9c7. Read the comment docs.


Add support for Custom Metrics

In heapster-scalability
Read Custom Metrics from cAdvisor/Kubelet response (https://github.com/google/cadvisor/blob/master/info/v1/container.go#L463).
cc: @piosz @huangyuqi

Fixed with #846.


Revert dummy markdown change

Reverts Expensify/Expensify.cash#2872
Testing https://github.com/Expensify/Expensify/issues/157916

🚀 Deployed to staging in version: 1.0.43-9🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.44-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


pushing to proper repo

So this is a fix for what Luis just pushed over to me, should work just fine now.

Bumped to 0.3.0 per breaking changes.


memory pass bug on simple RAM

Hello!
 Yosys is a very powerful tool and bugs seem quite rare, great job!
I tried to apply the memory pass of Yosys on a simple RAM, and observed that after memory; proc; opt -purge, it was completely optimized out.
Here is the SystemVerilog code for the RAM (simplified from the opentitan prim_generic_sram_1p):
module data_mem (
	clk_i,
	write_i,
	addr_i,
	wdata_i,
	wmask_i,
	rdata_o
);
	parameter unsigned [8:0] Width = 1;
	parameter unsigned [8:0] Depth = 4;
	localparam unsigned [8:0] Aw = $clog2(Depth);
	input wire clk_i;
	input wire write_i;
	input wire [Aw - 1:0] addr_i;
	input wire [Width - 1:0] wdata_i;
	input wire [Width - 1:0] wmask_i;
	output reg [Width - 1:0] rdata_o;
	reg [Width - 1:0] mem [Depth];
	always_ff @(posedge clk_i) begin
			if (write_i) begin
				reg unsigned [8:0] i;
				for (i = 0; i < Width; i = i + 1)
					if (wmask_i[i])
						mem[addr_i][i] <= wdata_i[i];
			end
			else
				rdata_o <= mem[addr_i];
    end
endmodule

stat gives:
=== data_mem ===

   Number of wires:                 23
   Number of wire bits:             52
   Number of public wires:           7
   Number of public wire bits:      16
   Number of memories:               1
   Number of memory bits:            4
   Number of processes:              1
   Number of cells:                  1
     $memrd                          1

The memory pass followed by a Verilog backend gives the code below. You can observe that rdata_o is never influenced by the input. This is not expected.
module data_mem(clk_i, write_i, addr_i, wdata_i, wmask_i, rdata_o);
  reg \initial  = 0;
  reg [1:0] _00_;
  reg _01_;
  reg _02_;
  reg _03_;
  reg [8:0] _04_;
  reg [1:0] _05_;
  reg _06_;
  reg _07_;
  reg [8:0] _08_;
  reg [1:0] _09_;
  reg _10_;
  reg _11_;
  wire _12_;
  reg [1:0] _13_;
  reg _14_;
  reg _15_;
  input [1:0] addr_i;
  input clk_i;
  output rdata_o;
  reg rdata_o;
  reg [8:0] \sv2v_autoblock_1.i ;
  input wdata_i;
  input wmask_i;
  input write_i;
  always @* begin
    if (\initial ) begin end
    _03_ = rdata_o;
    _04_ = _08_;
    _00_ = _05_;
    _01_ = _06_;
    _02_ = _07_;
    casez (write_i)
      1'h1:
        begin
          _05_ = _09_;
          _06_ = _10_;
          _07_ = _11_;
          _08_ = 9'h001;
          casez (wmask_i)
            1'h1:
              begin
                _09_ = addr_i;
                _10_ = wdata_i;
                _11_ = 1'h1;
              end
            default:
              begin
                _09_ = 2'hx;
                _10_ = 1'hx;
                _11_ = 1'h0;
              end
          endcase
        end
      default:
        begin
          _08_ = \sv2v_autoblock_1.i ;
          _05_ = 2'hx;
          _06_ = 1'hx;
          _07_ = 1'h0;
          _03_ = _12_;
        end
    endcase
  end
  always @(posedge clk_i) begin
      rdata_o <= _03_;
      \sv2v_autoblock_1.i  <= _04_;
      _13_ <= _00_;
      _14_ <= _01_;
      _15_ <= _02_;
  end
  assign _12_ = 1'hx;
endmodule

Eventually, continuing with proc; opt -purge unsurprisingly optimizes the logic out because of the issue with memory:
module data_mem(clk_i, rst_ni, write_i, addr_i, wdata_i, wmask_i, rdata_o);
  input [1:0] addr_i;
  input clk_i;
  output rdata_o;
  input wdata_i;
  input wmask_i;
  input write_i;
  assign rdata_o = 1'hx;
endmodule

Changing reg [Width - 1:0] mem [Depth] into reg [Depth-1:0][Width - 1:0] mem is a successful workaround, which also suggests that the issue comes from the memory pass.
Thanks! :slightly_smiling_face:

Hi!
The memory passes work on elaborated netlists, rather than RTLIL processes, so you need to run proc before memory.
Running proc; memory; opt -purge does appear to work fine (it no longer gets entirely optimised away), although I haven't looked at the synthesis result in detail.

Excellent, thank you for your very fast answer, this works like a charm! :slightly_smiling_face:


Add DSLogon claims in config

This allows the proxy to map through dslogon-specific claims through to Okta, and then there is corresponding config on the Okta side to map them through to the user profile.

I pushed this to one of the dev saml proxy instances and was able to complete DSLogon sign-in


annotation segmentation type info

Is your feature request related to a problem? Please describe.
It is not always clear what annotation set is human vs machine, especially in the segmentation part.
Because although some annotation sets are labeled to be recognizable between e.g. VTC and eaf, some human annotation are based on machine segmentations (human classifies the segments vtc identified)
Describe the solution you'd like
New field in annotations.csv index . Being 'segmentation' and having to be between human or machine

Idea of having a 'sets.csv' file listing sets is interesting, it would hold information aggregated by sets like segmentation, origin, notes etc, the package should create it if does not exist but info should be added there

Maybe an "annotator" field? Then people can set to "human" or something more precise if needed (e.g. the annotator's initials)


feat: use Tabs component from component library

@keith33m - can you resolve conflicts here. I'll take a look after those are resolved. thx

@keith33m - can you resolve conflicts here. I'll take a look after those are resolved. thx

@brightiron apologies for the delay, was running into issues with snapshots, but it's resolved now!


🐛 BUG: using wrangler to execute migreation, but wrangler exit without error logging

Which Cloudflare product(s) does this pertain to?
Wrangler
What version(s) of the tool(s) are you using?
wrangler 3.78.5
What version of Node are you using?
v22.4.0
What operating system and version are you using?
Ubuntu 22.04.5 LTS
Describe the Bug
Observed behavior
I'm trying to run migration in CICD, everything works fine with -local, but when I get to --preview / --prod, the wrangler just exits without an error message.
Expected behavior
Succeed or fail, rather than just quit code 1
Steps to reproduce
Use Command pnpm wrangler d1 migrations apply [db name]--remote -c config/prod.toml

Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

Updated to version 3.78.10, resolved


Make HOMEBREW_PREFIX/Caskroom the default.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

Fixes https://github.com/caskroom/homebrew-cask/issues/24610.

@reitermarkus May also be worth tweaking https://github.com/Homebrew/brew/blob/master/Library/Homebrew/cmd/update-report.rb#L234-L239. Happy to merge this once we have one job with 👍 to avoid waiting for coverage completion.

Also: will this break any symlinks?

I'm not sure about tweaking update-report.rb, because if the Caskroom isn't moved to the new repository first, there won't be a reference to it.

It feels pretty odd to move it and then move it back to the same location?

Also: will this break any symlinks?

It might. But it will probably fix more symlinks than it breaks, since the move to /usr/local/Homebrew/Caskroom broke all links pointing to /usr/local/Caskroom.

/usr/local/Caskroom was migrated to /usr/local/Homebrew/Caskroom with the migration of the Homebrew repo to /usr/local/Homebrew, so all symlinks would be broken if we left the caskroom at /usr/local/Homebrew/Caskroom.

Ah, sorry, read your comment too fast and thought you were talking about the earlier migration from /opt/homebrew-cask/Caskroom to /usr/local/Caskroom.

Current coverage is 81.76% (diff: 100%)

Merging #1025 into master will decrease coverage by 1.52%

@@             master      #1025   diff @@
==========================================
  Files           340        340
  Lines         14109      14390   +281
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          11751      11766    +15
- Misses         2358       2624   +266
  Partials          0          0

Powered by Codecov. Last update 3ffb9a2...c0cc703


Make 8-bit serialization more memory-efficient (v2)

Current 8-bit serialization mechanism keeps double the memory of weights, because it creates a new tensor of parameters in a row-major layout and stores it in the state dict. This PR implements the following logic: if the weights were rearranged, save their memory layout along with them and use it when restoring the checkpoint.
In this implementation, the memory shouldn't leak between _load_from_state_dict from different modules, as we are directly rearranging the data of the state dict before loading it. However, there might be a memory overhead because of that: we are creating a new temporary tensor that is different from what's stored in the state dict

Tagging @otto-dev because you've tried another fix in https://github.com/TimDettmers/bitsandbytes/pull/330. Would be great to hear your feedback on whether this fix helps, at least when saving the model.
I reproduced the original issue using the same setup as https://github.com/huggingface/peft/issues/447, and it did seem to help

This pull request solved the problem, thank you.

I have the exact same issue going to try with this PR to see if this fix it

This pull request solved the problem, thank you.

@mryab Did you get an error when loading the model? I got an error when loading the model:
File /usr/local/lib/python3.8/dist-packages/bitsandbytes/nn/modules.py:310, in maybe_rearrange_weight(state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs)
    309 def maybe_rearrange_weight(state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs):
--> 310     weight = state_dict[f"{prefix}weight"]
    311     weight_format = state_dict.pop(f"{prefix}weight_format", "row")
    313     if weight_format != "row":

KeyError: 'base_model.model.model.layers.0.self_attn.q_proj.weight'

the lora_target_modules is [             "q_proj",             "v_proj",             "k_proj",             "o_proj",         ] in my code.

hey @mryab I just tried your PR. It indeed solve the OOM problem. But I have the same problem as @Beants when loading the model.
File ~/.cache/pypoetry/virtualenvs/jerboa-SzH-b7Hf-py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py:70, in _WrappedHook.__call__(self, *args, **kwargs)
     68         raise RuntimeError("You are trying to call the hook of a dead Module!")
     69     return self.hook(module, *args, **kwargs)
---> 70 return self.hook(*args, **kwargs)

File ~/.cache/pypoetry/virtualenvs/jerboa-SzH-b7Hf-py3.10/lib/python3.10/site-packages/bitsandbytes/nn/modules.py:310, in maybe_rearrange_weight(state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs)
    309 def maybe_rearrange_weight(state_dict, prefix, local_metadata, strict, missing_keys, unexpected_keys, error_msgs):
--> 310     weight = state_dict[f"{prefix}weight"]
    311     weight_format = state_dict.pop(f"{prefix}weight_format", "row")
    313     if weight_format != "row":

KeyError: 'base_model.model.model.layers.0.self_attn.q_proj.weight'

Here is a code to reproduce :
from transformers import BitsAndBytesConfig, AutoModelForCausalLM, AutoConfig

from peft import PeftModel, prepare_model_for_kbit_training, get_peft_model, LoraConfig

import torch

def load_model(base_model):
    model_config = AutoConfig.from_pretrained(base_model, trust_remote_code=True)

    quant_config = BitsAndBytesConfig(
        load_in_8bit=True,
        bnb_4bit_compute_dtype=torch.float16,
    )

    # Instantiate Llama model either from base model or from empty model
    model = AutoModelForCausalLM.from_pretrained(
        pretrained_model_name_or_path=base_model,
        torch_dtype=torch.float16,
        device_map='auto',
        config=model_config,
        quantization_config=quant_config,
        trust_remote_code=True,
    )

    return model

lora_r: int = 8
lora_alpha: int = 16
lora_dropout: float = 0.05
lora_target_modules = [
    "q_proj",
    "v_proj",
]
lora_config = {
    'r': lora_r,
    'lora_alpha': lora_alpha,
    'target_modules': lora_target_modules,
    'lora_dropout': lora_dropout,
    'bias': "none",
    'task_type': "CAUSAL_LM",
}

model = load_model("yahma/llama-7b-hf")

model = prepare_model_for_kbit_training(model)
lora_config = LoraConfig(**lora_config)
model = get_peft_model(model, lora_config)

model.save_pretrained('trash')

model2 = load_model("yahma/llama-7b-hf")

model2 = PeftModel.from_pretrained(
        model2,
        'trash',
)

@Beants Hi, thanks for trying this out!
Is it true that you're trying to load the checkpoint that was saved by the code from this PR! If yes, could you please share a link to the state dict you're trying to restore? It looks like that the weight key is missing, which is strange for a linear layer

Here is a link to the model file: https://drive.google.com/drive/folders/1K0Gg_BzwESy3PW2_t2UICG3vE8UpRWlF?usp=sharing

I am trying to debug, it seems that the problem is coming from Lora in peft, the name of the layer is changing

Hi @Beants @samsja! I've investigated the problem: looks like peft checkpoints don't contain any weights for non-LoRA parameters, so my code fails when trying to rearrange nonexistent weights. I made an attempt to fix this in https://github.com/TimDettmers/bitsandbytes/pull/503/commits/b599fdb197c6b80d3be334899b9e9620492656b9, please see if it helps

Hi @mryab! I'm happy to report that your changes are working and the weights are loading normally.


Events muted when component is updating widget's options

Issue Type
bug report
Description

The issue is related to all widgets.
Assume we have a HtmlEditor instance. If the valueType option changed, the onValueChanged callback should be fired, but it is muted - because the component is "updating props" (see the options-manager._wrapEventHandler method)
Current Behavior
The onValueChanged callback not fired
Expected Behavior
The onValueChanged callback fired
Demo
https://codesandbox.io/s/4z16jykwz9
Change from "Html" to "Markdown" - event not fired
Environment Details

devextreme-react version: 18.2.4

We will research this issue in the context of the DevExtreme Vue Widgets - Events are muted when a component updates widget's options report.


Make it easy to webpack this

[x] WebSocket
[ ] request.js
[ ] package.json.browser
[ ] webpack config
[ ] move test IIFEs to test files
[ ] split dashsight-ws into own module?

npm create vite@latest vue -- --template vue
cd vue
npm install --save<EMAIL_ADDRESS>npm i
npm run dev

@jojobyte Can we close this?

I see a lot of unticked boxes.
@jojobyte , what do we need to do here?


Bug - Suggest command not working

<suggest command:/command>clickable text
Doesn't seem to work.
I'm using 1.13.2.

Same Problem here with InteractiveBooks v1.3.3 and PaperMC Build 510 (MC: 1.13.2)

This feature it's not supported for books by Minecraft, I've implemented it (without testing) because I didn't know so.

:/


Support setting a custom CA bundle for S3-compatible storage

This adds a AwsCustomCABundle field to the BackupStorageConfig definition, which accepts a base64 encoded CA bundle that will be used instead of the system-provided certs to validate HTTPS connections to the S3-compatible storage.
I might just be missing it, but it appears the aws-sdk for Go does not support SSL-without-verification, so connecting to an endpoint with a self-signed cert would require that a CA bundle be provided here.
For reference, documentation on the behavior of the aws-sdk session's CustomCABundle option can be found here: https://docs.aws.amazon.com/sdk-for-go/api/aws/session/
Fixes #270

@mansam @jortel @dymurray do you guys think it would be useful to add support for skipping verification of S3 caBundle?
Have been chatting with @pranavgaikwad and think it would save some hassle if someone doesn't care to complete this step. I don't think the technique is well documented but found this issue on the aws-sdk for golang outlining the approach:
https://github.com/aws/aws-sdk-go/issues/2404#issuecomment-454196045

In the meantime, anyone trying to figure out the correct caBundle to use with their custom S3 service running on OpenShift (e.g. NooBaa) should be able to use this script to grab the value from their NooBaa URL:
#!/bin/bash
# grab_cabundle.sh
openssl s_client -showcerts -verify 5 -connect $1 < /dev/null | awk '/BEGIN/,/END/{ if(/BEGIN/){a++}; out="cert"a".crt"; print >out}' && for cert in *.crt; do newname=$(openssl x509 -noout -subject -in $cert | sed -n 's/^.*CN=\(.*\)$/\1/; s/[ ,.*]/_/g; s/__/_/g; s/^_//g;p').pem; mv $cert $newname; done

cat *.pem > caBundle.pem

Then dump caBundle.pem into the field on MigStorage.

Just a note that until the Velero side supports this (which I am presently working on), the MigStorage validation will pass because the S3Test will succeed, but it will fail when Velero attempts to reach the bucket.


fix RandomSampler' object has no attribute 'set_epoch'

issue/125
and det configure error

Thanks!!!


[OSD-21097-handle-permissions-errors] Handle Misconfigured Role Permissions

What is being added?
A fix to handle accounts that don't have the correct permissions to enable opt in regions. The change will update the state from TODO to MANUL_ACTION and prevent accounts from continuously trying to enable accounts with the wrong permissions
Checklist before requesting review

[x] I have tested this locally
[ ] I have included unit tests
[ ] I have updated any corresponding documentation

Steps To Manually Test

Start the operator
Modify OrganizationAccountAccessRole permissions
Run "make predeploy"
Set "feature.opt_in_regions" to true in hack/templates/aws.managed.openshift.io_v1alpha1_configmap.tmpl
Add "opt-in-regions" entry to hack/templates/aws.managed.openshift.io_v1alpha1_configmap.tmpl
Run "make create-account"
Set account.Spec.accountPool to "hs-zero-size-accountpool"
Verify account CR state changes to READY
Verify in the AWS console that the opt-in regions specified in the configMap are enabled

Ref OSD-21097

Codecov Report
Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 47.61%. Comparing base (d302f4c) to head (ad90bbc).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
+ Coverage   47.60%   47.61%   +0.01%
==========================================
  Files          44       44
  Lines        6663     6670       +7
==========================================
+ Hits         3172     3176       +4
- Misses       3152     3155       +3
  Partials      339      339

Files
Coverage Δ

api/v1alpha1/account_types.go
81.76% <100.00%> (ø)

controllers/account/account_controller.go
36.10% <100.00%> (ø)

...ollers/validation/account_validation_controller.go
42.50% <0.00%> (ø)

controllers/account/region_enablement.go
53.55% <62.50%> (+0.12%)
:arrow_up:

/lgtm


Use TypeDoc to generate/publish reference docs to github.io

We need to automatically publish reference docs to github.io for this repo.  At a minimum we should publish these for track 2 libraries.  Even better would be to publish them for the entire repo (as we do in the python repo).
Please work with @jeremymeng to understand how to use/call the tooling and add it to the appropriate DevOps pipeline.
Once this is complete, the docs should appear here: http://azure.github.io/azure-sdk-for-js.

From Jeremy Meng's email on how to do this:
C:\github\jeremymeng\azure-sdk-for-js\sdk\storage\storage-blob>npm i -g typedoc
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. handlebars provides its own type definitions, so you do not need this installed.
C:\Users\yumeng\AppData\Roaming\npm\typedoc -> C:\Users\yumeng\AppData\Roaming\npm\node_modules\typedoc\bin\typedoc
+<EMAIL_ADDRESS>updated 12 packages in 7.197s

C:\github\jeremymeng\azure-sdk-for-js\sdk\storage\storage-blob>typedoc --excludePrivate --exclude "node_modules/**/*" --mode file --out ./dist/docs ./src

Using TypeScript 3.2.4 from C:\Users\yumeng\AppData\Roaming\npm\node_modules\typedoc\node_modules\typescript\lib
Rendering [========================================] 100%

Documentation generated at C:\github\jeremymeng\azure-sdk-for-js\sdk\storage\storage-blob\dist\docs


Click on a Map location using their latitude and longitude

Automating a site where root functionality starting from a clicking on  map location.
I have that particular latitude and longitude for that location(18.649247,73.812793)
and On web app ,I found the map height and width where map frame is set.
mapwidth * mapheight = 812.81 * 500;
So my question is , can we click on a map location using these values using protractor?
Help me out to resolve it!

Hi @makwanaparth94
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow
(use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!


Links formats (CSS) for multiple models are not reflecting correctly

The links formats are multiple models are reflecting as text while it's clickable which make it confusing
Example while the links for the configuration guide for Check Point is available it showing as text

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 779fbece-f67b-28ef-143e-f58ecfa29b1d
Version Independent ID: fe532684-022f-9006-9179-c534fd923171
Content: About VPN devices for cross-premises Azure connections
Content Source: articles/vpn-gateway/vpn-gateway-about-vpn-devices.md
Service: vpn-gateway
GitHub Login: @yushwang
Microsoft Alias: yushwang

@hkamel , Thank you for your feedback. I have assigned this issue to the author to update the documentation with the correct link.
@yushwang , Can you take a look and update the documentation with the URL for Check Point ?

@hkamel - please reach out to me internally. I am not sure what the feedback is about, will need some clarifications
#please-close


delete unused file

What this PR does / why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #665 (1005998) into main (19aa459) will increase coverage by 0.60%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   30.10%   30.70%   +0.60%
==========================================
  Files          26       25       -1
  Lines        1578     1547      -31
==========================================
  Hits          475      475
+ Misses       1038     1007      -31
  Partials       65       65

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Scene partitioning for large scale MVS

@AIBluefisher, hello, is it possible to partition the scene like CMVS or method introduced by Maura, Massimo et al. using GraphSfM? Should I just use lower completeness ratio when performing point_cloud_segmenter?
I found there is huge overlapping area(e.g. 50% when I set completeness_ratio=0.5) between clusters of my sfm result. Is it possible to use lower completeness_ratio when performing distributed_mapper? I think, perhaps, using lower completeness_ratio will greatly improve the efficiency distributed_mapper, cause there will be less views in each cluster.
Thank you!

Hi, I don't have much knowledge of CMVS. The point_cloud_segmenter is just served as an experimental tool right now, and I mainly use it for distributed bundle adjustment. I'm now busy on something else, so I feel sorry that I currently don't have much time to revise CMVS. Would you like to show me the main idea of CMVS?

Thank you for your response! Sure, as far as I know, the main idea of CMVS and method introduced by Maura, Massimo et al can be illustrated using the following picture:

Maura's methods uses camera view information available from Structure-from-Motion (SfM) for
computing a set of overlapping clusters suited for Multi-View Stereo (MVS) reconstruction. The main difference between the clusters of GraphSfM and Maura's clusters is that they have different percentage of overlapping area. Specifically, GraphSfM's clusters requires at least 50% of overlapping, while Maura's clusters requires less overlapping.
I guess that the key point of huge overlapping area requirement in GraphSfM is to ensure reliable component merging. The key point of Maura's method is to reconstruct dense point cloud with high quality.

Could GraphSfM's cluster generation method cover the needs of large scale MVS?
How could I reduce the overlapping area to achieve better clusters to satisfy the needs of large scale?
Is it possible to use less overlapping area to achieve the same robustness and higher efficiency in clusters merging step？

The picture listed above was provided by:
Mauro, Massimo, et al. "Overlapping camera clustering through dominant sets for scalable 3D reconstruction." 2013 British Machine Vision Conference


Update to use ptr for PwmConfig object

I prefer if we just annotate the type with {.byref.}, as it's easier to handle.


Introduce sync fall back not hang on current height

Version(s) of tendermint-rs:
Description
I found a phenomenon in current consensus processing, that when a node fall behind with its neighbor nodes, it will panic right now which make this node no progress aka lose liveness. I think the second below maybe a enhancement for Tendermint:

node first time startup, it will use the sync mode to sync blocks from its nighbors, all thing done, this node recover from sync to consensus mode.
when a node fall behind with its nighbors, it will fall back to sync mode not hang on consensus mode to sync blocks from its nighbor after this action the node recover from sync to consensus.

But in current implementation not only rust but go, there is only first approach, not second, I am confused why can't we support the second approach. Thx for reply
Definition of "done"
The correct behavior imaged as before second approach

Is this related to Tendermint Core or tendermint-rs?


Add typewriter text animation with blinker

Aim
To integrate the following feature under the 'Text Animations' directory
Demo

Note

I will replace text content with neutral/filler content.
I will enable easy modification to text content with well-commented code.
I will abide by community guidelines and code of conduct

Please assign me this issue to add this feature in your repository.

Go for it🎊🎊🎊🎊🎊


Image upload button didn`t show up

Hi Li,
Pretty enjoyed the extension you made. Thank you very much!
Here`s one issue that inside the image property window, only Image Information and Link button are showed up, however, the Upload button is mis-rendered.
In rendered html source code page, inside the CKEditor script :
/tech is my blueprint prefix.
<script type="text/javascript">
  CKEDITOR.replace( "Content", {
  language: "",
  height: 0,
  width: 0,
  //toolbarCanCollapse: true,
  codeSnippet_theme: "monokai_sublime",
  imageUploadUrl: "/tech/upload",
  filebrowserUploadUrl: "/tech/upload",
  filebrowserBrowseUrl: "",
   extraPlugins: "filebrowser,filebrowser",
   });
  </script>

Noticed that the filebrowser string has been generated twice comparing with the project standard example I ran early, is this the problem? Any possible reason?
For whole application I have config.py, the CKEditor related :
class Config(object):
    CKEDITOR_FILE_UPLOADER = 'Technical.upload'
    CKEDITOR_SERVE_LOCAL = True

For blueprint Technical/routes.py, I basically follow instruction:
@mod.route('/files/<path:filename>')
def uploaded_files(filename):
    path = '/var/www/FlaskApp/FlaskApp/static/post_pics'
    return send_from_directory(path, filename)

@mod.route('/upload', methods=['POST'])
def upload():
    f = request.files.get('Technical.upload')
    extension = f.filename.split('.')[1].lower()
    if extension not in ['jpg', 'gif', 'png', 'jpeg']:
        return upload_fail(message='Image Only')
    f.save(os.path.join('/var/www/FlaskApp/FlaskApp/static/post_pics', f.filename))
    url = url_for('Technical.uploaded_files', filename=f.filename)
    return upload_success(url=url)

BTW, Is this correct?
f = request.files.get('Technical.upload')
or should I remove blueprint prefix 'Technical.'?
Thanks in advance.

BTW, Is this correct? f = request.files.get('Technical.upload')

The input name must be upload (i.e. f = request.files.get('upload')), it's defined by CKEditor, sorry for not clarify it in README.

the Upload button is mis-rendered.

Could you provide the HTML template file?

Thanks for the quick reply.
Here is file link:
layout:
https://gist.github.com/ivymichael/e27ecf535068f3bf73dacc849dab0b61
create_post.html:
https://gist.github.com/ivymichael/ce098e39ac356e2f251a586b0cdb62e4

Hi,
Problem solved!
I made a mistake that in my models.py, the post main body name is defined as 'content',
however I used 'Content' in CKEditor.config(), that causes the duplicates of string 'filebrowser' somehow.
Sorry to bother, thank you!

It's my pleasure :)


RN GoogleSignin native module is not correctly linked ....

I am really stack with this error (RN GoogleSignin native module is not correctly linked...),
I tried tried to follow suggestions here https://github.com/react-native-community/google-signin/issues/771#issue-514898758 but they were not helpful
I have have followed all right procedures but still fail. I have tried it for three days!!
Please someone should help with a clear solution...
I use RN^0.61.2  and latest  @react-native-community/google-signin version

Hi there! Sorry you're having an issue. As the issue template explains, we require that you provide a runnable example (please try reproducing the bug with our example app) that reproduces your issue in a github repository. Please try to minimize the superfluous code and focus only on reproducing the bug.

I'm facing this issue too. Followed the readme to the letter and I'm having the same issue on RN v0.61.5 which supports auto linking.

You can resolve the problem of duplicated dependencies in android adding this to your react-native.config.js file:
module.exports = {   dependencies: {     'react-native-google-signin': {       platforms: {         android: null       }     }   } };

@celso-henrique  can you please tell me where can I find the react-native.config.js file?

@celso-henrique can you please tell me where can I find the react-native.config.js file?
Look here it's a file that replace package.json key/value. https://github.com/react-native-community/cli/blob/master/docs/configuration.md

I have same issue did someone find a solution a fix?

@celso-henrique can you please tell me where can I find the react-native.config.js file?

I found it on ./node_modules/react-native/react-native.config.js. It actually worked on the first try, but then when I added the button it was throwing another error, I reloaded the app and now it doesn't work anymore.

@celso-henrique can you please tell me where can I find the react-native.config.js file?

Just create this file in the root of your project

Got the same issue. My steps to reproduce from scratch:

expo init  //expo version 37.0, react-native 0.61.5
npm install @react-native-community/google-signin
import this package in App.tsx,
expo start
open on android via expo

@lkvr expo does not support native modules, so this is expected; please use https://docs.expo.io/versions/latest/sdk/google-sign-in/ instead.
I'm closing this issue because no runnable reproduction was provided.

@iut-cse-4301-mubahood upon re-review, I think if you share your app/build.gradle and settings.gradle we may be able to solve this without a repro

I am also having this issue! I have seen many posts with the same issue and it keeps getting closed without even being resolved. I have followed the docs provided by react-native-google-signin and still, I get the 'RN GoogleSignin native module is not correctly linked error'. I have spent days trying to get the google sign in to work and still no luck. I used auto-linking with pods and even manual linking. If I manual link then I will get a '<GoogleSignIn/GoogleSignIn.h> not found' error from my <RNGoogleSignIn.h> file. At this point, I cannot see what I am doing wrong.  Has anyone resolved this?? Please help!!

Hi there! Sorry you're having an issue. As the issue template explains, we require that you provide a runnable example that reproduces your issue (see the issue template). The reason is that maintainers do not have time to try reproduce bugs themselves. Please try to minimize the superfluous code and focus only on reproducing the bug.
Please create a new issue with this and we'll be happy to review it!
If you need assistance, a paid option is available: https://github.com/react-native-community/google-signin/pull/861.


Update actions for release

Description
This PR adds two new actions related to our release process. test-deps.yml checks whether any new release of packages that we depend on will break our package. release.yaml builds a wheel and then installs the wheel and checks that imports and CLI are working correctly.
More details:

test-deps.yml does a fresh install with the latest version of all our (i) core dependencies and (ii) developer dependencies, and then checks that imports, CLI and tests all work correctly. This is currently a nightly cron job as it takes a while for pip to resolve and install the latest version of our dependencies. Failures will be sent to Slack.

release.yaml builds our package, and then installs it and checks that CLI and imports are working correctly. It only does this for CPython 3.10 and one platform (Ubuntu) because it will make the action very slow otherwise (but this can be changed)

Related Issues
#607
Checklist
N/A
Additional Notes or Comments
This is still quite rough. Improvements are very weclome!
This requires an admin to create a secret with a Slack webhook URL. Please contact me for details.

Codecov Report
Patch coverage has no change and project coverage change: +0.04% :tada:

Comparison is base (90dc025) 79.66% compared to head (4eca79c) 79.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   79.66%   79.70%   +0.04%
==========================================
  Files          79       79
  Lines        4819     4819
==========================================
+ Hits         3839     3841       +2
+ Misses        980      978       -2

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

... it will make the action very slow ...

A comment to the quote above: even if a test is slow, we shall not omit it for the sake of quality in order to guarantee that the software works corss-OS and corss-versions - just the way we advertise. WDYT?

A non-blocking comment to the quote above: even if a test is slow, we shall not omit it for the sake of quality in order to guarantee that the software works corss-OS and corss-versions - just the way we advertise. WDYT?

Yes, very poor wording on my part. Thanks!


Component instance API

attachTo currently doesn't return anything.

Agree with @phuu . I have tried the flight-with-child-component mixin, and the first thing that I was missing was the instance of the child inside of the parent. I wanted to manipulate the child through the instance, instead of throwing the event and catching it.
In case where i store some info of the children in parent and i know exactly which child i want to interact with, i don't need to create a listener and trigger an event, then check if that event is meant for that child, etc... It would be a lot easier if i could store the instance of the attached children and then just call a method on one child instance.
This will also be good for the attachment of components.
In some parent component:
var childComponent = self.attachChild(SomeChildComponent, 'nodeToAttachChildTo',
    {
         name: 'John Do',
         count: 3
     });
self.attr.childrenArray.push(childComponent);

And then, when i need to call some method of the child:
self.attr.childrenArray[3].someMethod();

Thanks for your thoughts @BugiDev.
To clarify, I don't think the parent should have access to the methods of the child. Have a look at the actor model for some context about why.
I actually mean a very limited interface for talking/modifying to the child. The kind of thing that could simply be done with events.
@BugiDev Your example is troublesome because of the teardown behaviour — it has to work automatically. A parent cannot depend on a child being there (although the reverse can be true)

I felt that something like this was missing too, and ended up playing around with hacks like http://codepen.io/necolas/pen/Djbpr to get the desired outcome.

I like the idea of being able to teardown a component from the parent. We do this anyway with events - would seem sensible to provide a simple API for that.

Wouldn't this go against the principle of separation of concerns?
Flight enforces strict separation of concerns. When you create a component you don't get a handle to it. Consequently, components cannot be referenced by other components and cannot become properties of the global object tree. This is by design. Components do not engage each other directly
What would happen when

the child component is torn down
your try to do something with the instance

@tbrd with events instead the child components teardown themselves in case they are still around

Hmm. It's a tough question. Here's my thinking behind this; perhaps it'll clarify why I want it (though there aren't really any answers here).
In short(ish), I don't really think the actor model (aka, Flight-philosophy) is really suitable for building complex interfaces, and Flight throws the baby out with the bath water in it's insistence separating components from each other.
React and cousins have shown there's a huge amount of value in accepting component hierarchy, and I think there's a comfortable middle ground for Flight.
Perhaps this will make more sense when TweetDeck open-sources the observable stream stuff we've been using — it's absolutely staggering how much more simple, testable and readable components become when you architect for the inherent tree-structure of UI.
It's possible we don't need this, but I'd be really interested to discuss it.

We need to get the observable stuff out so it can help inform this, but the mixins we have created would arguably benefit from having more direct knowledge of their parent/child relations (it would remove some boilerplate that we're using withResource for). Let's try and get a version of that out next week.

@phuu I hear you but that's one of the best features of flight in my opinion.
Maybe we can improve withChildComponents to solve some of those problems.
For example we could add a children registry where we store some info about children components,
push stuff on it when we use this.attachChild and have this.attachChild return a ChildComponent object that exposes the API you suggested ie. you get instance info only from this.attachChild instead of Component.attachTo.
this.attachChild would mix an object in the child component so that after teardown we can remove the child from the parent's registry.
ChildComponent would have access to the children registry of course.
I also suggest to introduce a new concept of RootComponent|ComponentsGroup|FlightSquares :) or something like that so that people understand that components that get withChildComponents are just a common place where you can organise the subtree and establish those relationships - at yelp we call them controllers

The other day I realized that the idea above is implemented in Deku (a component-based framework from Segment). They call these thing Scene(s) https://github.com/segmentio/deku/wiki/Scene-API

I was playing with the idea to add some component hierarchy to my app. I like how React solves the inverse data flow and the idea of passing callbacks as props / attributes to the child components.
To test this on Flight, all I had to do was remove these three lines:
https://github.com/flightjs/flight/blob/master/lib/base.js#L84
This removes the ability to call a function in this.attributes, but it enables me to do stuff like:
this.attachChild(Playlist, this.select('playlistSelector'), {
 onSongClick: this.onSongClick.bind(this)
});

For me the challenge now, is how to share state with the child components. On an individual component level you can add state through with-state, but it would be great to update the child component's attributes through a React like function render without a need for a virtual dom (which is my use case for using Flight).
IMO state would be a inherent part of Flight. Children could only be initialised through attachChild and pushed into an array. When the parent state is updated, a method like this.afterStateChanged would be invoked on the child.


Usergroups empty after disabling 2FA

As an admin, when I disable 2FA for a user, the page reloads.
When a user belongs to a user group, this group is now unchecked. So if I save the current user, it is removed from that user group.
However when I reload the page, the user is correctly in the user group (and is correctly saved).
Maybe a bug within Craft?
*ps: thanks again for this great plugin

@RichardFrontwise thanks!
I'm guessing this is a Craft bug, since we don't change the user. We keep the 2FA data in out own separate tables. Disabling doesn't even redirect, but fires an action and let Craft resolve the url.
I'm seeing the same bug in Craft CMS 3.2.10


Make Submenu of shabad sticky

When I scroll down a shabad - The menu bar with buttons " Guru Nanak Dev ਗੁਰੂ ਨਾਨਕ ਦੇਵ
TRANSLATIONUNICODE FONT
OPEN ANG 1stars BOOKMARK"
disappears
I think it would be better to freeze this bar so even when I am at the bottom of the shabad, these buttons could still be accessed

position: sticky; is now supported by Chrome 56+


Sharing snippets doesn't work anymore (again)

My snippets all mysteriously disappeared, despite creating them after #12. And as of now, clicking the share button results in a "Failed" status.
This is really quite annoying – after #12 I had to recreate a couple dozen snippets for a presentation and now they're all gone again. :-( Why not just base64 encode the code + time window instead of storing the snippet in the backend?

I'm sorry to hear it caused you a trouble.
Looks like the https certificate has expired for the api.
I renewed it, and it seems ok now.
I need to automate the renewal process.
I'll think about your idea of base64.

Hey, it looks like this is occurring again (caused by the same thing)

Sorry about that. Fixed now.


force conflicts on deploy

with kubectl apply --server-side, sometimes we get conflict errors, such as after using the make target set-xxx-image which amends the deployment env variables. Using --force-conflicts allows to ignore such conflict, and makes the new deployment prevail.

/LGTM

thanks @msherif1234
/approve


Snap to the next item in list?

I have implemented this with a CarouselZoomPostLayoutListener. Everything is OK but the scrolling can be paused in between two items. I need the one item to always be in center, so if I fling and when the carousel stops, one of the items is centered (and zoomed).
How would I do that?

Hi @asknask.
This is not the correct behavior and the item should be centered after the scroll event.
recyclerView.addOnScrollListener(new CenterScrollListener()); is doing this.
If you have this code line and items are not centered, please give me the full code to reproduce and I will fix this issue.
Before your answer I will close this issue and will open as soon as you confirm the bug and give an example.


Orchard does not recreate resource when manually killed by external user

To reproduce:
Create a workflow with resource (e.g. EMR) that have more than 1 as max retry. Activating it, kill the resource through AWS console, orchard will mark workflow failed without retry creating the resource.

Note, the issue is that ResourceInstanceFinished message is used in ResourceMgr to get the final confirmation that resource is eventually cleaned up. In the event of user triggered termination, the ResourceMgr would not know if certain activity is running on it, hence send causing ResourceMgr to terminate itself, where activity is marked as "cenceled"


Fix/1632

Closes #1632
📝 Description
The modal closes immediately if it is opened from the Dropdown component.
⛳ Current behavior (updates)
The modal automatically closes when triggered by onMenuAction in use-dropdown.ts.
🚀 New behavior
The modal will not close when menuAction is performed.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Please kindly let me know if any suggestions.

Close this pull request because there's still a dropdown overlay issue between Modal and outside of Modal that needs to be fixed.


chore: Bump gradle from v7.6.2 to v8.2.1

Not going to happen. Too many failures from configuration cache violations.


ruff - S101 - no assert

Changes
Using assert is a bad pattern except in pytest. Overwriting S101 in tests, leaving everywhere else.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#160  👈
#159
#158
#157
#156
#155
#154
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @chrisaddy and the rest of your teammates on  Graphite


Add Meta Step for geopackage generation

Add a data-integration step for the plugin meta

Added the meta step for saving and loading the step in the data-integration environment.


feat(client): add context to middleware

Summary
This is my first pr to contribute, if I am missing something let me know.
It is the continuation of the work of a previous pr, it is a feature to add a context that can be used in middleware.
A very common and discussed use case in the community is the multi tenat architecture.
Original Pr
How to use it
prisma.$setContext({ someValue: 'something' })

prisma.$use((params, next, ctx) => {
  // Do something with the ctx
  console.log(ctx)
  return next(params)
})

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Lazy load default namespace for istioctl

Please provide a description of this PR:
This is to avoid checking the kubeconfig in commands that require non-kube environment.
Fix https://github.com/istio/istio/issues/47159.

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fcaaa194df4da9f9bb12ae0d2a9c969698bd88c5
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fcaaa194df4da9f9bb12ae0d2a9c969698bd88c5
link
true
/test release-notes

gencheck_istio
fcaaa194df4da9f9bb12ae0d2a9c969698bd88c5
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hanxiaop: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
fcaaa194df4da9f9bb12ae0d2a9c969698bd88c5
link
true
/test release-notes

gencheck_istio
fcaaa194df4da9f9bb12ae0d2a9c969698bd88c5
link
true
/test gencheck

lint_istio
fcaaa194df4da9f9bb12ae0d2a9c969698bd88c5
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Custom rootValue and context parameters for graphql

HI, i saw this lib pass the same request object in graphql function at the 3rd and 4th parameters which are rootValue and context.
Why not make it customizable so we can pass the rootValue and context parameters for graphql.

Hi @shenyzore,
sorry for the delay, I am really short on time recently. I've added the possibility to pass in a custom context object (see readme). Would you like me to add support for function too? What parameters should it get (eg. request)?

I've done it poorly.. Working on it now. :)

Take a look at version 3.1.1.

Thanks for your reply, i think it works for me.


why do you use Vertx

Hi, Why do you use Vertx, are you using reactive programming, why dont you use Webflux in Spring. What is the difference between Vertx and Webflux when talking about Reactive Programming

Why do you use Vertx : I use vertx to compare with others. this app is testing all different frameworks you can see the graphic

are you using reactive programming : yes sometimes.
** why dont you use Webflux in Spring** : I think code has webflux here https://github.com/ozkanpakdil/test-microservice-frameworks/blob/main/spring-boot-webflux/pom.xml
What is the difference between Vertx and Webflux when talking about Reactive Programming Vertx has more light framework, spring is little bit heavy


SpotBugs scanner integration

The SpotBugs scan parser. The tool itself is an successor of Findbugs and can use FindSecBugs as plugin for accurate security scans. Tested against  OWASP Benchmark.

Added sample report
spotbugs-report-short.xml.zip

Hi @bakalor thank you for your PR. Please review the merge conflicts: https://github.com/DefectDojo/django-DefectDojo/pull/792/conflicts

Hi @devGregA , please check, conflicts have been resolved. Compliant to flake8.


Sorting Visualizer using Vanilla JS

WebMasterLog Repository (Proposing new issue)
:red_circle: Project Title : Sorting Visualizer
:red_circle: Aim : Add a Sorting Visualizer, which will visualize Bubble Sort, Selection Sort, Insertion Sort & Quick sort.
:red_circle: Tech Stack Used :  HTML, CSS, JS
:red_circle: Category :  Vanilla JS

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be all the main components.

Cover image of the application, if project will be deployed in future, with the name of the folder in Kebab-Case (hypen-separated).
Main files in formatted state so that code will be readable.
Other Images - In seprate folder named Images used to form the application.

Inside the Project folder, the README.md file must be filled up properly, with proper visualizations and descriptions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :  Surajit Maity
GitHub Profile Link : https://github.com/Surajit0573
What is your participant role? JWOC Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@Surajit0573 Assigned to you. Follow the contributing guidelines carefully.


fix for rails 5

replaced == with >= when comparing ActiveRecord::VERSION::MAJOR
should resolve: https://github.com/jashmenn/activeuuid/issues/80
ref: https://github.com/jashmenn/activeuuid/issues/46
https://github.com/jashmenn/activeuuid/issues/39

oh, i guess rails 5 has builtin support for uuid primary keys.

rails 5 apparently has builtin support for uuid primary keys with postgres, but not with sqlite3 AFAIK.
reference: https://github.com/rails/rails/issues/20518
But then, does anyone actually use sqlite3 in production?

Rails <IP_ADDRESS>
Sqlite as development storage
activeuuid 0.6.1  (at master@4f8e0ef)
Keep showing error
Gem Load Error is: undefined method type_cast' for class ActiveRecord::ConnectionAdapters::Column'


Stop leaking IdleTimeoutStages

Multiple IdleTimeoutStages, whose timers have been canceled, are piling up on recycled connections.  This ensures that we clean up what we add.
It's sloppy, but so is the problem.  It's another case of trying to shift life cycles outside a traditional bracket, and I haven't yet figured out how to make it work as a bracket.
I expect that this fixes #2289.

I can confirm this PR fixes #2289. This is the only regression we have noticed in 0.20.0-M3. Thank you!


A few more tweaks to room 2

Add a link to some password guidance
Make the Actions more consistent

This should complete the work on #25


Reduce effect of index backfills on OLTP traffic

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwchkdQkRUw6hZ3z/recZ2ddue8PKNnDFp?blocks=hide
PM: @rolandcrosby
Eng:

Closing - labeled as "not building" in AirTable.


HowTo.scala throws error when running as instructed

When trying to run HowTo.scala the following error occurs.
sbt "; project amm-executor; test"
[error] ## Exception when compiling 133 sources to C:\Users\didel\ergo-dex-backend\modules\dex-core\target\scala-2.12\classes [error] scala.reflect.internal.FatalError: Error accessing C:\Users\didel\AppData\Local\Coursier\Cache\v1\https\repo1.maven.org\maven2\com\github\pureconfig\pureconfig-core_2.12\0.14.1\pureconfig-core_2.12-0.14.1.jar
I tried with JDK 11, 17, 21 on a Windows 10 and a Debian Linux machine and the same error occured in all scenarios.

It appears that this specific jar ("com.github.pureconfig" %% "pureconfig-core" % "0.14.1") from Maven Central is broken, because IntelliJ won't display its contents (which it does with every other jar) and forcing the build to use version 0.14.0 of the pureconfig libs compiles and runs the test just fine (and IntelliJ displays its contents, too).
Tried this on Arch Linux with SBT 1.5.5 with JDK 11 and 17 (the versions shipping with Arch Linux).


add preview note to 2 more Outlook articles

Product team requested the note be added to these two articles

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/authentication.md
:white_check_mark:Succeeded

docs/add-ins/implement-sso-in-outlook-add-in.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/authentication.md
:white_check_mark:Succeeded

docs/add-ins/implement-sso-in-outlook-add-in.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Reduce indentation after return

Reduce indentation where possible and where it makes understanding code easier.
Early exit is one of the suggested enforcements of that. Please do not use else
or else if after something that interrupts control flow - like return, break,
continue, throw.
clang-tidy readability-else-after-return
PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)

@hjmjohnson Can you please explicitly mention the clang-tidy option you are using, in the commit message, also for "PERF: Replace explicit return calls of constructor"? And if you copy the documentation directly from clang.llvm.org into the commit message, please mention the source of the copied text.
When you literally quote a text, consider using double-quotes or indentation, to clarify that the text is quoted.
If it is just a style improvement, please use "STYLE", rather than "PERF". (Please only use "PERF" when you expect a significant performance improvement, observable by ITK users. Please use "STYLE" when the commit does not cause behavior changes.)


Accidental combination of code

After merging code from two sources the code has ended up in a jumbled state.

I think that MainActivity.java and activity_main.xml need to be fixed.


HasNewestPtcsJenkinLibRule refactoring

Refactor HasNewestPtcsJenkinLibRule fix creation to hide git details for easier logic testing.
GitUtils should be a interface (and maybe named something else)
Consider just fetching the specific branch instead of all branches in GetCommitAsBase client.Repository.Branch.Get(repository.Owner.Login, repository.Name, BranchName)

I think this doesn't have a clear enough goal. Closing.


expect_events cheatcode

Closes #356
Introduced changes

added expect_events cheatcode
events can be passed as follows

expect_events(array![
    Event { name: 'FirstEvent', keys: array![], data: array![456] },
    Event { name: 'SecondEvent', keys: array![789], data: array![456] },
    Event { name: 'ThirdEvent', keys: array![], data: array![456, 789, 1, 1] },
]);

only next call is checked

Breaking changes

Checklist

[x] Linked relevant issue
[ ] Updated relevant documentation
[x] Added relevant tests
[ ] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

@war-in should we convert this to a draft, since we want to iterate on the design?


connection

Describe the bug
guild.xyz can not connect to X account .
Steps to reproduce
Steps to reproduce here.
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

Please use discord, this is not related to our codebase.


Support Pipelines

Hello,
Currently the Pipeline API, as defined here is not supported.
Is there any plan to support it?
Regards

At this point I only really have time to review PRs.  If you'd like to add the feature your contribution would be welcome.  CONTRIBUTING.md - for reference on how to contribute.


SystemChrome.setPreferredOrientations works only after a short switchover

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I added the following code to my main file:
Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  // Portrait Modus
  await SystemChrome.setPreferredOrientations(
    [
      DeviceOrientation.portraitUp,
    ],
  );

The portrait mode only works after it has switched once. If I move from portrait to landscape it goes to landscape and jumps back briefly afterwards and then stays in portrait mode. it's the same on simulator or real device.
To recreate the behavior, I need to restart the app.
In Xcode I have this:

I cannot turn off the landscape modes because I want to allow landscape mode on individual pages.
https://github.com/flutter/flutter/issues/121625 and https://github.com/flutter/flutter/issues/57748 does not resolve the issue because it doesnt work with 3.7.12 and also not with 3.10.6.
https://github.com/flutter/flutter/assets/9454529/3d7b486b-04e2-413c-bb60-a4930d256d19
Expected results
It should stay in portrait mode from the beginning.
Actual results
The portrait mode only works after turning once.
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.7.9, on macOS 12.6 21G115 darwin-arm64, locale de-DE)
    • Flutter version 3.7.9 on channel stable at /Users/XXX/development/tools/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 62bd79521d (4 months ago), 2023-03-30 10:59:36 -0700
    • Engine revision ec975089ac
    • Dart version 2.19.6
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/XXX/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = /Users/XXX/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/XXX/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.80.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (4 available)
    • SM J530F (mobile)      • 52034239f4dca4ed                     • android-arm    • Android 9 (API 28)
    • iPhone 14 Pro (mobile) • 2F34815C-796B-45FB-9FD8-FEE88312AF59 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.6 21G115 darwin-arm64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 115.0.5790.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @desmeit. Thanks for filing this issue. I am unable to reproduce this on the latest version of Flutter. It works fine without the switch over. I see you are on an older version of flutter. Can you upgrade to the latest versions to confirm this issue still persists?

@dam-ease sorry, you are right. The issue is gone if I update to 3.10.6.


Enable strict compile options on all scala projects and fix warnings.

Description
Not all scala projects had the compiler flags we usually use so some warnings went under the radar. This fixes this.
Types of changes

[X] Bug fix (generally a non-breaking change which closes an issue).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).

Codecov Report

Merging #4742 into master will decrease coverage by 5.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4742      +/-   ##
==========================================
- Coverage    83.6%   78.31%   -5.29%
==========================================
  Files         198      198
  Lines        8849     8827      -22
  Branches      615      618       +3
==========================================
- Hits         7398     6913     -485
- Misses       1451     1914     +463

Impacted Files
Coverage Δ

...g/apache/openwhisk/core/database/UserCommand.scala
97.82% <ø> (ø)
:arrow_up:

...apache/openwhisk/core/database/LimitsCommand.scala
98.5% <ø> (ø)
:arrow_up:

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...e/database/cosmosdb/cache/ChangeFeedConsumer.scala
0% <0%> (-100%)
:arrow_down:

...ore/database/cosmosdb/cache/CacheInvalidator.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.85%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-93.85%)
:arrow_down:

...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala
0% <0%> (-92.31%)
:arrow_down:

...e/database/cosmosdb/cache/KafkaEventProducer.scala
0% <0%> (-77.78%)
:arrow_down:

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff59ae...f0e757a. Read the comment docs.


fix(deps): revert koanf to v1.5

While the update works for go-ftw, koanf v2 is not used in other dependent libraries and breaks when used.
E.g. https://github.com/corazawaf/coraza/pull/908

I don't understand the issue. All they need to do is the same that I've done, which is to use koanf/v2 and add koanf/providers/yaml etc. as indirect dependencies. I just tried it on the branch of that PR for Coraza.

The problem is this: I learned that dependencies might also pull koanf. But they pull v1. Because of that, there is a namespace collision upstream. So, to move forward, we might need to change our code and include v2 but use it in a different namespace, like koanf2 or something. We can do that now and see if it works instead of downgrading....

The error:
Error: ../../../go/pkg/mod/github.com/knadh/koanf/v2@v2.0.1/koanf.go:11:2: ambiguous import: found package github.com/knadh/koanf/maps in multiple modules:
	github.com/knadh/koanf v1.4.4<EMAIL_ADDRESS>	github.com/knadh/koanf/maps v0.1.1<EMAIL_ADDRESS>FAIL

The dependency graph:
❯ go mod graph | grep koanf
github.com/corazawaf/coraza/v3/testing/coreruleset<EMAIL_ADDRESS>github.com/corazawaf/coraza/v3/testing/coreruleset<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

From what I can see, they only pull in koanf because of go-ftw, and that only in the testing/coreruleset module.  I'll have to look into that.

It is just the name used when importing. If you do:
import (
    "github.com/knadh/koanf"
    "github.com/knadh/koanf/v2"
)

then you'll have a collision because both are imported as "koanf". Tipically you use it like:
import (
    "github.com/knadh/koanf"
    koanfv2 "github.com/knadh/koanf/v2"
)

So there is a way to make both versions work. The first one will be "koanf" and the second "koanfv2".

I see. We can certainly do that. I'm trying to think how this will play out, because at some point I would want to drop koanf for koanf/v2 completely. Say we do this now and people update, if they clean up their go.mod files properly, koanf should be replaced with koanfv2. Then, in a future version, we can drop koanfv2 again and since the go.mod files will no longer contain a references to koanf it should just work. Does that make sense?

Do you still want to first revert to koanf or should we just make that namespace change in this PR?

Let's to the namespace change instead. I'll push the changes here.


"There was an unhandled error "

There was an unhandled error - sorry! Please create a ticket on github https://github.com/Stickymaddness/Procurement/issues. If the crash occured after Procurement was done downloading, zip and include your .tab files.
I attached my 4 Hesit tabs and my debug log
DebugInfo.log
Batta.zip

I have the same error! I think it appears if I do nothing for some time

Hey i dot the same error, has i tested seem to be an error caused by some Heist league items, hope fixes soon or the only way is to buy some premium tab :)

same

Thanks for the bug report, guys.  I found a crash when hovering over contracts/blueprints, as well as possibly older items.  I have a fix for that in #1118, and you can download a version with that patched in to test here.  I believe this will mess up how some item tooltips are displayed, but Procurement should at least not crash.  I'll work on a better solution when I get a chance.
If you're still encountering an error, please provide a description of what you are doing when the error occurs, in addition to the DebugInfo.log file.  Thanks!

Thanks very much! It didn't crash for time I've used it.


ArrayHelper::multisort doesn't support ArrayIterator?

What steps will reproduce the problem?
Run this code:
use yii\base\Component;
use yii\console\Controller;
use yii\helpers\ArrayHelper;

class StatusController extends Controller{

    public function actionCount()
    {
        // Prepare data.
        $packAsArray = [
            new Dog(['rank' => 2]),
            new Dog(['rank' => 3]),
            new Dog(['rank' => 4]),
            new Dog(['rank' => 1]),
        ];

        $packAsIterator = new \ArrayIterator($packAsArray);

        // Now sort.

Both arrays sorted.
What do you get instead?
Exception: array_multisort(): Argument #7 is expected to be an array or a sort flag'
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
PHP 7.0.15 (cli)

Operating system
Mac OS Sierra 10.12 (16A313a)

PHP function array_multisort does not support ArrayIterator as an argument, so the problem is out of Yii scope. We will not write custom implementation to support this use case, sorry


k8s reporter, Use dmesg directly in logDMESG

This way logDMESG will also work on kind based provider,
which otherwise fails (unless it also virt-chroot to the mnt namespace):
/proc/1/root/bin/dmesg: /lib64/libtinfo.so.6: no version information available (required by /proc/1/root/bin/dmesg)
/proc/1/root/bin/dmesg: /lib64/libc.so.6: version `GLIBC_2.33' not found (required by /proc/1/root/bin/dmesg)

Signed-off-by: Or Shoval<EMAIL_ADDRESS>None

/retest

/cc @rmohr
can you please take a look ?
was there any reason to use /proc/1/root/dmesg ?
using just dmesg works both on kind and on k8s based providers

can you please take a look ?
was there any reason to use /proc/1/root/dmesg ?
using just dmesg works both on kind and on k8s vm based providers

Yes the reason was to not have a dependency on dmesg in the container. However, as your example shows we still load glibc from the wrong namespace and as such have a dependency.

p.s
from what i saw and understand, it shows the host dmesg both on kind and on k8s vm based providers,
so it means we will just have the same file on all the nodes, we can improve to take it just one time if needed
on a following PR.

I think we can take your current solution. However your previos virt-chroot solution may be the best. Because we don't have a dependency on dmesg inside our container and it will still work everywhere.

I think we can take your current solution. However your previos virt-chroot solution may be the best. Because we don't have a dependency on dmesg inside our container and it will still work everywhere.

Thanks, will restore it then instead

closing in favor of https://github.com/kubevirt/kubevirt/pull/6121


issues

Describe the bug
A clear and concise description of what the bug is.
dashbord isnt loading /play not working
To Reproduce
Steps to reproduce the behavior:

music issue not playing/searching [log-[2024-04-05 10:04:22] ERROR: {}]
dashbord not loding -link http://de-prem-01.hosts.optikservers.com:35195/
Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
If possible

NodeJS version:20
Bot version:latest

Additional context
Add any other context about the problem here.
logs-╔═══════════════════════════════════╗
║           Client Events           ║
║ error.js                  │   ✓   ║
║ guildCreate.js            │   ✓   ║
║ guildDelete.js            │   ✓   ║
║ interactionCreate.js      │   ✓   ║
║ inviteCreate.js           │   ✓   ║
║ inviteDelete.js           │   ✓   ║
║ guildMemberAdd.js         │   ✓   ║
║ guildMemberRemove.js      │   ✓   ║
║ messageCreate.js          │   ✓   ║
║ messageDelete.js          │   ✓   ║
║ messageReactionAdd.js     │   ✓   ║
║ messageReactionRemove.js  │   ✓   ║
║ ready.js                  │   ✓   ║
║ voiceStateUpdate.js       │   ✓   ║
║ warn.js                   │   ✓   ║
╚═══════════════════════════╧═══════╝
[2024-04-05 10:04:18] INFO: Validating config file and environment variables
[2024-04-05 10:04:19] WARN: config.js: SUPPORT_SERVER is not provided
[2024-04-05 10:04:19] WARN: env: STRANGE_API_KEY is missing. Image commands won't work
[2024-04-05 10:04:19] INFO: Loading commands...
[2024-04-05 10:04:19] INFO: Loaded 98 commands
[2024-04-05 10:04:19] INFO: Loaded 79 slash commands
[2024-04-05 10:04:19] INFO: Loading contexts...
[2024-04-05 10:04:19] INFO: Loaded 1 USER contexts
[2024-04-05 10:04:19] INFO: Loaded 0 MESSAGE contexts
[2024-04-05 10:04:19] INFO: Loading events...
[2024-04-05 10:04:19] INFO: Loaded 15 events. Success (15) Failed (0)
[2024-04-05 10:04:19] INFO: VersionCheck: Your discord bot is up to date
[2024-04-05 10:04:19] INFO: Launching dashboard
[2024-04-05 10:04:19] INFO: Connecting to MongoDb...
[2024-04-05 10:04:20] INFO: Mongoose: Database connection established
[2024-04-05 10:04:20] INFO: Dashboard is listening on port undefined
[2024-04-05 10:04:26] INFO: Logged in as marko#4478!<PHONE_NUMBER>454162002)
[2024-04-05 10:04:26] INFO: Music Manager initialized
[2024-04-05 10:04:26] INFO: Initializing giveaways manager...
[2024-04-05 10:04:26] ERROR: Node "Local Node" encountered an error: AggregateError.: AggregateError
[2024-04-05 10:04:26] INFO: Node "Local Node" disconnected
[2024-04-05 10:04:27] INFO: Giveaway Manager initialized
[2024-04-05 10:04:27] INFO: Successfully registered interactions
[2024-04-05 10:04:30] ERROR: {}
[2024-04-05 10:04:41] ERROR: {}
[2024-04-05 10:04:47] ERROR: {}
[2024-04-05 10:04:18] ERROR: {}
[2024-04-05 10:04:22] ERROR: {}

Its the lavalink problem. Please make sure you are hosting correct version of lavalink


General: homepage overhaul including removal of greyed out study cards

Discussed in 9/13/2021 EDA WG meeting
The homepage should be redesigned. The utility of the sections of the landing page below the study cards is unclear. Likely will be most useful for naive users who don’t even understand what the databases are about.
Combining the example searches & example visualizations is fine for phase 1. For later phases, perhaps videos would be more useful? But videos are also very difficult to keep up to date when the UI changes.
Old mockups around site search may be useful for the homepage redesign

Homepage redesign proposal is here: https://docs.google.com/presentation/d/1ASPwraqVzp2ZHAM7ChM_tnxUTk2QvNOuTR67sd0Fng0/edit#slide=id.p
See eda-homepage-wg for discussion. Scheduled to be discussed in an EDA/UX meeting soon.

We also want to get rid of greyed out cards on the live site. When we get rid of the greyed out cards, we will also remove the "isSecret" property from the presenter.
Note...We intend to do a more thorough homepage redesign at some point that de-prioritizes the card view, which is getting increasingly difficult to navigate given the large amount of released studies and isn't as useful now that site search does not filter the cards.

Can i close this ticket? As far as i know we're not planning on working on this for a while


Fix permission error on double click on submit determination

Fixes #3342
This PR contains changes only for determination. We will be implementing the same approach for other forms as well.

Neat solution!