HasManyThrough, final Model id overwritten by intermediate model id if columns match

Laravel Version: 5.5.3
PHP Version: 7.2
Database Driver & Version: PostgresQL 9.6 although I believe this is agnostic

Description:
Let's take these three models. We're using a custom intermediate model here rather than just a belongsToMany for reasons unrelated to this issue
User: id
Block: id, user_id (the owner)
BlockContractor: id, user_id (the contractor id), block_id
If we say that User hasMany Block through BlockContractor this makes sense.
However the query that gets executed ends up being select blocks.*, block_contractor.user_id from ... which means the user_id from block_contractor overrides the actual user_id from block in the Block model we get back!
An easy solution to this would be to allow us to alias the key e.g.
  public function contractedBlocks(): HasManyThrough
  {
    return $this->hasManyThrough(
      Block::class,
      ContractorBlockLink::class,
      'user_id AS contractor_id',
      'id',
      'id',
      'block_id'
    );
  }

However this almost works but ends up producing (pay attention to the last line)
select
  "blocks".*,
  "block_contractor"."user_id" as "contractor_id"
from "blocks"
  inner join "block_contractor" on "block_contractor"."block_id" = "blocks"."id"
where "block_contractor"."user_id" as "contractor_id" = 11

My solution right now is to just rename the column in block_contractor but that's not always going to be possible.

This is a known problem and discussed at https://github.com/laravel/ideas/issues/347.

Ah thanks @sisve I'll join the conversation over there, but I'm going to also leave this open because of the fun we're having with the ideas repo.

This will be fixed in Laravel 5.8 (#25812). Please close the issue.

For anyone else running into this issue before the 5.8 release, I just took the code changes that fixed the issue and created HasManyThroughFixed & a trait for using it.
<?php
// HasManyThroughFixedRelation.php

namespace App\Traits;

use Closure;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasManyThrough;
use App\Relations\HasManyThroughFixed;
use Illuminate\Database\Eloquent\Builder;

trait HasManyThroughFixedRelation
{
    public function hasManyThroughFixed($related, $through, $firstKey = null, $secondKey = null, $localKey = null, $secondLocalKey = null)
    {
        $through = new $through;

        $firstKey = $firstKey ?: $this->getForeignKey();

        $secondKey = $secondKey ?: $through->getForeignKey();

        return $this->newHasManyThroughFixed(
            $this->newRelatedInstance($related)->newQuery(),
            $this,
            $through,
            $firstKey,
            $secondKey,
            $localKey ?: $this->getKeyName(),
            $secondLocalKey ?: $through->getKeyName()
        );
    }

    protected function newHasManyThroughFixed(Builder $query, Model $farParent, Model $throughParent, $firstKey, $secondKey, $localKey, $secondLocalKey)
    {
        return new HasManyThroughFixed($query, $farParent, $throughParent, $firstKey, $secondKey, $localKey, $secondLocalKey);
    }
}

<?php
// HasManyThroughFixed.php

namespace App\Relations;

use Illuminate\Database\Eloquent\Relations\HasManyThrough;
use Illuminate\Database\Eloquent\Collection;

class HasManyThroughFixed extends HasManyThrough
{
    // Override 2 necessary methods to keep sane ids
    protected function buildDictionary(Collection $results)
    {
        $dictionary = [];

        // First we will create a dictionary of models keyed by the foreign key of the
        // relationship as this will allow us to quickly access all of the related
        // models without having to do nested looping which will be quite slow.
        foreach ($results as $result) {
            $dictionary[$result->_first_key][] = $result;
        }

        return $dictionary;
    }

    protected function shouldSelect(array $columns = ['*'])
    {
        if ($columns == ['*']) {
            $columns = [$this->related->getTable().'.*'];
        }

        return array_merge($columns, [$this->getQualifiedFirstKeyName().' as _first_key']);
    }
}

So now, just use that the HasManyThroughFixedRelation trait in your model, and use HasManyThroughFixed() just like you would HasManyThrough().


New version: KhronosGroup.VulkanSDK version 1.3.268.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Manual Validation ended with:

Hi @scribam,
Is a dependency needed for the above error?

Hi @stephengillie,
AFAIK, yes, the dependency is needed.
You can have a look at my previous PR https://github.com/microsoft/winget-pkgs/pull/118619 which also had some issues with automatic validation

Do you know the name or location of the dependency with vulkan-1.dll? We should add it to the manifest.

Automatic Validation ended with:

https://github.com/microsoft/winget-pkgs/issues/107639

@stephengillie I think you were still gonna look into this right, or is there any action that can be taken to get this package moving?

Hi @sandercox,
This package was depending on https://github.com/microsoft/winget-pkgs/pull/124997, which had stalled as the interactive installer installs different files than the unattended installer. I suspect installer switches might need to be adjusted.


Use const fixed siez arrays

From Ariel Elperin
Try using const fixed size arrays, if there are issues under 2^15 then share Cairo code with us and we'll solve it together

solved by #2


Post data and Entity inherit

Hi,
I have created a model that inherits from Entity. And one that does not inherit from Entity.
The model that inherits from Entity instantiate the object but does not fill the property in the post request. See screenshots.
My model is like this:

public class EmailTransac : Entity
    {   [Required()]
        public string Name { get; set; }
        [Required()]
        public string From { get; set; }
        [Required()]
        public string Template { get; set; }
        [Required()]
        public string Subject { get; set; }
    }

    public class EmailTransacModel
    {
        [Required()]
        public string Name { get; set; }
        [Required()]
        public string From { get; set; }
        [Required()]
        public string Template { get; set; }
        [Required()]
        public string Subject { get; set; }
    }

With inherit of Entity

Without inherit of Entity

My Postman config

Any ideas how can I fix this?
Thanks,

I kindly request you post questions on Stackoverflow or similar sites. This github repository contains code and actual issues and is not intended for support.

Ok.
Post for the question on stack
http://stackoverflow.com/questions/32158737/mongorepository-post-data-and-entity-inherit-is-property-empty


Where do i could find this untranslated text for translate it to russian language

It is in the media modal. I need to translate Chinese words to russian

https://github.com/margox/braft-finder here, PR's welcome :)

https://github.com/margox/braft-finder here, PR's welcome :)

thanks!


added gopath args for it

it is not able to set a dynamic gopath when using supervisor liked tools. for example:
[program:goproxy]
environment = HTTP_PROXY=http://<IP_ADDRESS>:7777,HTTPS_PROXY=http://<IP_ADDRESS>:7777 # can not set gopath dymicly in env
command = ./bin/goproxy -listen=<IP_ADDRESS>:9000 -gopath=./go_repo
stderr_logfile=/dev/stdout
stdout_logfile=/dev/stdout

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Jamlee  Thanks for your contribution. We need you to sign the CLA, so we can continue.

ok, i have done it.

singing license/cla is too hard to do for me. it is  always not signed yet although  i have signed. could ignore it ?


Should synonyms creation return Accepted or Created

For the moment when you create a synonym using POST /indexes/:index/synonym the return status is 201 Created while also giving back an update id in the return body.
Should there be a consistency with async action that return a 202 Accepted with an update Id or should there be a consistency on the create routes that return a 201 Created even when the creation may not have occurred yet?

Same goes for PUT /indexes/:index/synonym/:synonym which return a 200 Ok and a updateId

I think other routes also return an other status code than 202 Accepted while also sending back an updateId.
Could you update them there too ?


undefined method `configuration_list'

When running Kintsugi, I'm getting the following error:
/Library/Ruby/Gems/2.6.0/gems/kintsugi-0.7.3/lib/kintsugi/apply_change_to_project.rb:457:in child_component': undefined method configuration_list' for <PBXNativeTarget name=MyApp UUID=8B0F7A522A991C9A00233F44>:Xcodeproj::Project::Object::PBXNativeTarget (NoMethodError) Did you mean?  configure_with_plist
Any ideas on how to resolve?

@codyrotwein I wasn't able to reproduce it yet, what version of Xcode are you using?
Additionally, can you post the diff by running kintsugi with --changes-output-path?

@byohay Xcode 15.0.1. I ended up just manually correcting the git merge conflicts. You can probably close the issue since I don't have the merged branch anymore and therefore can't debug with you further on the issue. Thanks though.

Makes sense.
I don't think I've ever seen configuration_list under native_target before, so I thought it might be related to a newer Xcode version. Let's see if it happens again..

Getting the same here, with Xcode 15.


Fake an InterruptedDueToStepDown error on upstream topology-affecting errors

Fixes #16.
Returns a fake InterruptedDueToStepDown error (code 11602) to the downstream application if the upstream server causes errors that would change the topology. This is to ensure that the application's view of the mongobetween server remains unchanged, and the connection pool isn't drained for no reason.
{
  "ok": 0,
  "code": 11602,
  "codeName": "InterruptedDueToStepDown",
  "errmsg": "interrupted due to shutdown"
}

I've only skimmed the code so far, but I have some thoughts based on the description:

Per this list of error codes, 11602 is InterruptedDueToReplStateChange, not InterruptedDueToStepDown.

11602 is considered a "node is recovering error" by the the SDAM spec's error handling section. This is more generally considered a state change error, which will force the app servers to mark mongobetween Unknown, which I think we want to avoid. State changes errors clear the server's connection pool if they are shutdown errors or they're from a pre-4.2 server. 11602 is not in the list of shutdown error codes, but mongobetween's isMaster responses have maxWireVersion=7, which is 4.0, so this error will cause the app servers to clear connection pools.


Replace 14 homepage 'showcase' brand images to scaled images (100x100)

It's my first PR, so forgive me if it's not organized or something! 🙏
I found that we are resizing the Showcase section images using CSS, which isn't recommended. Instead, we need to Use Scaled Images directly. It seriously affects our website performance, here's GTMetrix Report:

I resized all images (without decreasing its quality nor changing its extension) to 100x100. Total 14 images size was 574KB, and now it becomes 81.3KB (~86% smaller). This should give us a green Grade A on GTMetrix Serve Scaled Images criteria 👌
UPDATE: I changed them to 100x100 instead of 68x68 as it appears to be hardcoded to 100x100 on the Showcase Page, now it won't break the UI there.

Any updates, @rickhanlonii ?

@elharony, thanks for submitting this!
On the left is your change and the right is production:

Switching to 100x100 causes blurring on retina screens, can you do this with 200x200 or 300x300? That should fix the blurring 👍

Thanks @rickhanlonii for checking it out and providing such feedback!
We can't switch them to 300x300 as many of them is less than 300x300, but 200x200 is good for all 14 images, except the artsy, it's 167x167.
Well, I have a few suggestions here:

Stick with 150x150, it will suit all current images & possibly future images as well.
Keep them 200x200 except the artsy logo as it will look even worse if we scale it up (Bigger size, Bad quality!)

What do you think, Ricky? I would be happy to continue working on this part according to your feedback/suggestion to make it scalable for any future images as well.

What a wonderful idea! I have a suggestion: check out this format to accomodate retina screens as well as lower DPI without burdening one over the other:
<img
  src="/img/2016/p_rachel-in-the-cubicle.png"
  srcset="/img/2016/p_rachel-in-the-cubicle2x.png 2x"
  height="338" width="600" alt="A manga-style illustration of Rachel Nabors winking from behind a computer monitor in an implied cubicle."
/>

(From this old blog post)
You would use:
<img
  src="/img/100x100.png"
  srcset="/img/200x200.png 2x"
  height="100" width="100" alt="Brand X"
/>

Unless you don't have a 200x200 pic, in which case this works fine:
<img
  src="/img/100x100.png"
  height="100" width="100" alt="Brand X"
/>

What do you all think?

Sounds good to me! Sorry for the delay @elharony I must have missed the notification!

Great. So, I will go for #1 Suggestion and keep the in 150x150, right @rickhanlonii ?

Oh sorry, my message is confusing, I think we should go with @rachelnabors' solution which is your option 1, along with the updated image tags she provided 👍

Any movement on this @elharony? I'd soooo love to have this update on the site if you can get to it!

@elharony if you're not interesting in doing the full <img> tag version, updating this to use you option number 2 of using 200x200 for all images except artsy is good too!

@orta do you know where we could find a artsy logo that's at least 200x200?

Hey @rickhanlonii ,
Very sorry for being late, I am doing a Frontend Diploma with OpenClassrooms and I had some projects to finish. I've done the requested update, please give it another try!

Here's a copy: https://is4-ssl.mzstatic.com/image/thumb/Purple123/v4/70/64/3f/70643fc6-24c0-1878-c4a4-cbb92f8fc199/AppIcon-0-1x_U007emarketing-0-0-GLES2_U002c0-512MB-sRGB-0-0-0-85-220-0-0-0-4.png/460x0w.png

Thank you @orta . I've updated the Artsy logo.
@rickhanlonii Now, all of them are updated to 200x200 and optimized. Let me know if this PR needs any further changes

Alright looks great thank you!

btw I just created this issue to update the Facebook logo if you're interested!
https://github.com/facebook/react-native-website/issues/1524

Thanks for approving this PR. I am interested in #1524 and I will fix it! 👍


Fixes for nested resource and scope interop issues

Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check.
Contributing a feature

[x] I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
[x] I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
[x] I have appropriate test coverage of my new feature

Fixes #1810
This fixes the following issues:

Setting 'scope' should not be permitted on nested child resources
It should not be possible to deploy a nested child for an existing resource at a different scope to that of the template
Scope not being accounted for when generating resourceIds for extension resources
Scope note being accounted for when generating 'existing' resource references
Simplify formatting of nested resource reference names (avoid concat + split when we already have a list of names)

Codecov Report

Merging #1827 (5f5a0ba) into main (fb1a053) will increase coverage by 0.42%.
The diff coverage is 98.86%.

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
+ Coverage   95.03%   95.45%   +0.42%
==========================================
  Files         371      367       -4
  Lines       21671    21741      +70
  Branches       15        0      -15
==========================================
+ Hits        20594    20753     +159
+ Misses       1077      988      -89

Flag
Coverage Δ

dotnet
95.45% <98.86%> (-0.02%)
:arrow_down:

typescript
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Bicep.Core/Semantics/Symbol.cs
85.71% <ø> (ø)

src/Bicep.Core/Emit/ResourceDependencyVisitor.cs
91.25% <88.88%> (-2.18%)
:arrow_down:

...Bicep.Core.IntegrationTests/NestedResourceTests.cs
100.00% <100.00%> (ø)

...icep.Core.UnitTests/Assertions/JTokenAssertions.cs
100.00% <100.00%> (ø)

...UnitTests/Assertions/JTokenAssertionsExtensions.cs
95.65% <100.00%> (+3.65%)
:arrow_up:

src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs
100.00% <100.00%> (ø)

src/Bicep.Core/Emit/ExpressionConverter.cs
93.76% <100.00%> (+0.07%)
:arrow_up:

src/Bicep.Core/Emit/ExpressionEmitter.cs
98.75% <100.00%> (ø)

src/Bicep.Core/Emit/ScopeHelper.cs
91.60% <100.00%> (+0.57%)
:arrow_up:

src/Bicep.Core/Emit/TemplateWriter.cs
97.93% <100.00%> (ø)

... and 12 more


pull-request should open existing pull requests with --browse or -m

hub pull-request --browse -m 'my new feature'

fails if there is already a pull request open
but I really wanted that open in my browser (hence the --browse)
I think that if the PR already exists and you have --browse or -o, then open the exiting pr in my browser.
this is similar (but not quite) to https://github.com/github/hub/issues/897
and maybe also related to https://github.com/github/hub/issues/182 (i.e. if you have the option to add it to the clipboard, do it when the pull request already exists too).

Right now, I do hub browse then click the link to the PR. It's not ideal, but it works.

This is effectively what would a --web option do proposed in #1005. Closing this in favor of that PR.
It's already on our roadmap that we want to allow browsing of PRs by just their number, or by a branch name, or by current branch.

I don't think --web will do what I'm asking for here.
What I want to be able to do is regardless of if I have a PR open on this branch or not. I want to be able to do this:
hub pull-request --browse -m 'my new feature'

If there is NOT a pull request this creates one and opens the browser
If there IS a pull request this ignores my -m command and just opens up the pull request in the browser.
hub browse just opens up the current repo  (not even on the current branch!?)
hub pull-request --web seems like it will open up the page to create a pull request and type everything in I would usually put on the command line. admittedly if there is already a pull request it'll show me, but I'll have to click to view it.  I just want to be taken to the pull request with a simple hub command.
I don't even think --web should be on the pull-request command. It's not creating a pull request. it's opening up the compare branches page. (from which you can create a pull request).
Would you consider reopening this please?

The --web command (or however it will be called in the final phase) will open the current PR directly without the need for clicking on it separately.
You will be able to use the pull-request command to either open a new PR in the web view (if not already existing) or view existing one, based on whether one exists for the current branch.
Does this sound alright?

Will I be able to fill in the title (and description) form elements on the new PR via the --web command? that would be very nice.
either way, the more I think about it the more I like the --web idea, hopefully it'll turn into less mistaken pr's into master ;)
Thanks for following up.


clear event is now available on iOS

Fixes #12

Summary
Clear event is now available on iOS

Ticket Link
https://github.com/mattermost/react-native-paste-input/issues/12

Hello @andres-torres-marroquin,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Closing this as already handled in #15


Correct removing duplicate positions from WallGeometry

Fixes #8842
WallGeometry was missing a call to arrayRemoveDuplicates that we created to standardize the epsilon distance at which to remove duplicate positions.
Also updated the lat/lon epsilon check to use EPSILON10.  We initially undershot with EPSILON6, then https://github.com/CesiumGS/cesium/pull/1483 overshot and changed it to EPSILON14, but EPSILON10 is what we've standardized on in arrayRemoveDuplicates and our other geometry duplicate check functions.

Thanks for the pull request @hpinkos!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Thanks!


Update app-attach-powershell.md

Added that the Hostpool needs to be in the Validation Environment, just like it is stated in the Azure Portal doc (https://docs.microsoft.com/en-us/azure/virtual-desktop/app-attach-azure-portal)

@michawets : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@michawets : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stgeorgi , is this a good suggestion?

@stgeorgi , is this a good suggestion?

Yes, we should merge this change

Thanks for the review and PM approval @stgeorgi; merging.


[Snyk] Upgrade org.apache.httpcomponents.client5:httpclient5 from 5.2.1 to 5.2.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.apache.httpcomponents.client5:httpclient5 from 5.2.1 to 5.2.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-11-19.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Fixed in https://github.com/swedenconnect/signservice/pull/183


Updated pre-requisite

Customers are opening request because the connector isn't working but they need to create a diagnostic setting in AAD to stream AAD events to sentinel. Once this is configured, they can use the connector in sentinel. If this isn't enabled in AAD they won't be able to configure the Azure Active Directory connector in Sentinel.

@elevin - can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@yelevin - can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Customers are opening request because the connector isn't working but they need to create a diagnostic setting in AAD to stream AAD events to sentinel. Once this is configured, they can use the connector in sentinel. If this isn't enabled in AAD they won't be able to configure the Azure Active Directory connector in Sentinel.

@OusmaneDi Hello, and thanks for your feedback!
Unfortunately, this "correction" is not necessary, as it is not true. My own testing confirmed that the prerequisites mentioned are enough. Following the instructions on the connector page - marking the check boxes of the logs you want to ingest and selecting "Apply changes" - creates those AAD diagnostic settings behind the scenes, so you don't need to do that separately.
It may be a valid troubleshooting step, creating the AAD diagnostic settings manually if the connector failed to do so, but this shouldn't be necessary - and certainly not a prerequisite - as a matter of course.
There is already mentioned a prerequisite to have read and write permissions to the AAD diagnostic settings. Could that have been the problem for these customers?
I'm going to close this PR for now, feel free to reopen if this problem is further confirmed by support.
@American-Dipper
#please-close

Hello Yechiel,
Thanks for your response. I've actually tested this the second time with a Global admin on the tenant, owner on the subscription and log analytic workspace. After removing the diagnostic setting, the connector fails to apply changes to the selected logs. Please see screenshot below:
[cid:18d92c97-7c84-4776-8999-f5818960cac3]
So, if the expectation is that the connector will create the diagnostic settings in AAD then would that be a bug on the connector that needs to be raised to the product group?
I've also been supporting Azure AD identity related issues for the last 30 days and to get data from there to any SIEM the diagnostic settings need to be configured to stream the data and not the other way around. Similar to many other connectors for instance Microsoft defender for cloud apps. You can connect the connector from Sentinel but until you configure in Defender for cloud apps to have logs stream to sentinel as the SEIM, there will be no data despite the connector status saying connected in Microsoft sentinel.
Please give this a test or let me know if we should take the route to create another ICM for the connector to have the capability to create the diagnostic settings in AAD on behalf of the customer.
Thanks,
Ousmane

From: Yechiel Levin @.>
Sent: Sunday, January 22, 2023 11:09 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Ousmane Diallo @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Updated pre-requisite (PR #104088)
Customers are opening request because the connector isn't working but they need to create a diagnostic setting in AAD to stream AAD events to sentinel. Once this is configured, they can use the connector in sentinel. If this isn't enabled in AAD they won't be able to configure the Azure Active Directory connector in Sentinel.
@OusmaneDihttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOusmaneDi&data=05|01|Ousmane.Diallo%40microsoft.com|6867c27cb1c543996d1208dafc93061f|72f988bf86f141af91ab2d7cd011db47|1|0|638100005658465724|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=H4ZX6zxNKX7quvrkEnGTiSGannJmNZW8Flj%2FTgTmEfY%3D&reserved=0 Hello, and thanks for your feedback!
Unfortunately, this "correction" is not necessary, as it is not true. My own testing confirmed that the prerequisites mentioned are enough. Following the instructions on the connector page - marking the check boxes of the logs you want to ingest and selecting "Apply changes" - creates those AAD diagnostic settings behind the scenes, so you don't need to do that separately.
It may be a valid troubleshooting step, creating the AAD diagnostic settings manually if the connector failed to do so, but this shouldn't be necessary - and certainly not a prerequisite - as a matter of course.
There is already mentioned a prerequisite to have read and write permissions to the AAD diagnostic settings. Could that have been the problem for these customers?
I'm going to close this PR for now, feel free to reopen if this problem is further confirmed by support.
@American-Dipperhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAmerican-Dipper&data=05|01|Ousmane.Diallo%40microsoft.com|6867c27cb1c543996d1208dafc93061f|72f988bf86f141af91ab2d7cd011db47|1|0|638100005658465724|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=f6q1XHINH%2Ft95ASHOqORrEND7wZAem1N3MKVdsVJgAo%3D&reserved=0
#please-close
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F104088%23issuecomment-1399532012&data=05|01|Ousmane.Diallo%40microsoft.com|6867c27cb1c543996d1208dafc93061f|72f988bf86f141af91ab2d7cd011db47|1|0|638100005658465724|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TauOnd980tCie2AhN1FM1uOy4hSfLBCeVRpG2RzdMGE%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQUUE4RNGCRZF5IU3PBX4A3WTVLTDANCNFSM6AAAAAAUB2GSEY&data=05|01|Ousmane.Diallo%40microsoft.com|6867c27cb1c543996d1208dafc93061f|72f988bf86f141af91ab2d7cd011db47|1|0|638100005658465724|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=RaPEjVFzRRUkHRJNW%2FzNx8IK9vsGmtP6DF8hncuZ%2Bo4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Hi Ousmane,
You're talking about two different sets of connectors that don't work the same way.
As far as I understand, when it comes to Azure Active Directory Identity Protection, Microsoft Defender for Cloud Apps, and possibly some other services whose logs are ingested to Sentinel via Microsoft 365 Defender, then indeed you have to configure those services' SIEM settings separately.
However, for the Azure Active Directory connector, the settings in the connector page mirror and manipulate the Azure AD diagnostic settings. I created a new workspace in my personal tenant (so I'm a global administrator), deployed the Sentinel solution on it, and enabled the AAD connector. I then went into the AAD service and found a diagnostic setting already there, with the name "AzureSentinel_". When I marked or cleared check boxes for additional log types in either the connector or the diagnostic settings, the change was reflected in the other.
The exception to this appears to be if after enabling the connector, I then went into the AAD diagnostic settings and deleted the entry created by the connector. Then, when I tried to make changes in the connector, I got an error until I recreated the diagnostic setting manually, after which the synchronization behavior returned. Whether this should be considered a bug or not, I don't know, but I'll mention it to the product team.
Is there some reason anyone would delete these diagnostic settings? Is that suggested as a troubleshooting step for any particular issue?
In any event, if the user has the permissions already specified in the Prerequisites, they should be able to create the AAD diagnostic settings without any additional permissions or other prerequisites.
Thanks,
Yechiel

Hello Yechiel,
Thank you for that clarification. This issue appears to be on already connected data connector. A couple of customers mentioned having to remove the diagnostic settings and having the issue after trying to apply the logs from the connector in Sentinel.
I enabled the diagnostic from my end manually and ran into similar issue the customer was facing which is the reason for opening a pull request. But it make sense now and you can close the PR.
Thanks,
Ousmane

From: Yechiel Levin @.>
Sent: Monday, January 23, 2023 11:37 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Ousmane Diallo @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Updated pre-requisite (PR #104088)
Hi Ousmane,
You're talking about two different sets of connectors that don't work the same way.
As far as I understand, when it comes to Azure Active Directory Identity Protection, Microsoft Defender for Cloud Apps, and possibly some other services whose logs are ingested to Sentinel via Microsoft 365 Defender, then indeed you have to configure those services' SIEM settings separately.
However, for the Azure Active Directory connector, the settings in the connector page mirror and manipulate the Azure AD diagnostic settings. I created a new workspace in my personal tenant (so I'm a global administrator), deployed the Sentinel solution on it, and enabled the AAD connector. I then went into the AAD service and found a diagnostic setting already there, with the name "AzureSentinel_". When I marked or cleared check boxes for additional log types in either the connector or the diagnostic settings, the change was reflected in the other.
The exception to this appears to be if after enabling the connector, I then went into the AAD diagnostic settings and deleted the entry created by the connector. Then, when I tried to make changes in the connector, I got an error until I recreated the diagnostic setting manually, after which the synchronization behavior returned. Whether this should be considered a bug or not, I don't know, but I'll mention it to the product team.
Is there some reason anyone would delete these diagnostic settings? Is that suggested as a troubleshooting step for any particular issue?
In any event, if the user has the permissions already specified in the Prerequisites, they should be able to create the AAD diagnostic settings without any additional permissions or other prerequisites.
Thanks,
Yechiel
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F104088%23issuecomment-1400644811&data=05|01|Ousmane.Diallo%40microsoft.com|3e038ace920f4299dc0908dafd601dc4|72f988bf86f141af91ab2d7cd011db47|1|0|638100886514706354|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=RpOkuu09sNEpYTwh5B2Z7zY7V3VTk%2B1BWXKKPtvKeLg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQUUE4TDSWKQIBECC5UOAO3WT2XURANCNFSM6AAAAAAUB2GSEY&data=05|01|Ousmane.Diallo%40microsoft.com|3e038ace920f4299dc0908dafd601dc4|72f988bf86f141af91ab2d7cd011db47|1|0|638100886514862585|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=1BZjQL5876ZkXBGbtffIMg3CMXvtfFwhctLGNnpY0WI%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


Fusion: Fix files collection and small bug-fixes

Brief description
Fixed Fusion review-representation and small bug-fixes
Description
This fixes the problem with review-file generation that stopped the publishing on second publish before the fix.
The problem was that Fusion simply looked at all the files in the render-folder instead of only gathering the needed frames for the review.
Also includes a fix to get the handle start/end that before throw an error if the data didn't exist (like from a kitsu sync).

Fixed all commented problems and I would say that the code is ready to be merged :)


Block generator

It would be handy to have a generator for adding a new block to an existing addon.

@ujjwaleee26 No, that's not what this issue is about. This is about the command line generator tool. At this point this is just an idea with no specification yet.


feat(popover): close menu programmatically

Describe pull-request
Added a close() method to the popover menu. This will make it possible to programmatically close the menu which is for example needed when having some button as a menu item that doesn't act as a link.
Issue Linking:

GitHub

How to test
Provide detailed steps for testing, including any necessary setup.

Implement for example a button that calls the close() method provided by the popover menu.
Click the button and make sure that the menu closes.

Checklist before submission

[x] I have added unit tests for my changes (if applicable)
[x] All existing tests pass
[x] I have updated the documentation (if applicable)

Suggested test steps

[x] Browser testing (Chrome, Safari, Firefox)
[ ] Keyboard operability
[ ] Design/controls/props is aligned with other components

Not exactly, I wanted an open prop instead to align with for example side menu dropdown. But the popover menu has a conflicting variable called show that has a slightly other purpose here.

[x] Events

Thank you for a new feature @ExeAy ! Tested and it works nice. One thing we could do is to add the same feature to popover-canvas too.

Oh, for sure. I'll get to it later today or this week when I find time.


Phantom zig  calibration supporting

@kylechampley  As you may know most ct-reconstruction package support their own phantom zig calibration feature.
Is there any plan for this feature in leap package or already has ?

What is a “phantom zig”? Could you send a link that describes this?

I sent a related data to your gmail, please check it.

The word "zig" does not appear in this document.  Could you point me to the correct page?

phantom-based alignment, refer to 102 page.  I called the phantom which made for this feature as like "phantom-zig".

OK, I see.  This just entails scanning a calibration phantom and automatically determining the CT geometry parameters.  I've never heard of the term "zig" before.  At LLNL we used a so-called "ball phantom" which was a stack of metal balls.  NSI also uses this kind of calibration phantom as well.
Ya, I could add this to a future release.  Currently I am finishing up support for cone-parallel coordinates.  After that I need to work on the GUI and routines to process data that is too big for CPU RAM.  Ball phantom calibration could be implemented after these features.

I see, Thanks for your detailed explanation. If that feature added, I will check it later.

Ball phantom calibration function has been released in v1.22.


feat: transaction metric

ref: https://github.com/cectc/dbpack/issues/
Ⅰ. Describe what this PR did
#54
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #116 (c26cf29) into dev (925429c) will decrease coverage by 0.18%.
The diff coverage is n/a.

:exclamation: Current head c26cf29 differs from pull request most recent head 5b729e3. Consider uploading reports for the commit 5b729e3 to get more accurate results

@@            Coverage Diff             @@
##              dev     #116      +/-   ##
==========================================
- Coverage   48.41%   48.23%   -0.19%
==========================================
  Files          55       55
  Lines        5566     5759     +193
==========================================
+ Hits         2695     2778      +83
- Misses       2640     2738      +98
- Partials      231      243      +12

Impacted Files
Coverage Δ

pkg/executor/read_write_splitting.go
0.00% <ø> (ø)

pkg/executor/sharding.go
0.00% <ø> (ø)

pkg/executor/single_db.go
0.00% <ø> (ø)

pkg/dt/undolog/undo_log.go
0.00% <0.00%> (ø)

pkg/filter/dt/exec/executor.go
0.00% <0.00%> (ø)

pkg/filter/dt/exec/query_update.go
0.00% <0.00%> (ø)

pkg/filter/dt/exec/prepare_delete.go
0.00% <0.00%> (ø)

pkg/filter/dt/exec/prepare_update.go
0.00% <0.00%> (ø)

pkg/dt/undolog/protobuf_undo_log_parser.go
61.49% <0.00%> (+0.41%)
:arrow_up:

pkg/dt/undolog/table_records.pb.go
21.67% <0.00%> (+7.57%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925429c...5b729e3. Read the comment docs.

LGTM

LGTM


make all headings follow the AP Stylebook rules

Make all headings follow the AP Stylebook rules using: http://titlecase.com/

Canceled.


Upgrade dependencies

Going to have to investigate test timeouts for test/integrations/error-test.js some other time. They pass locally.


Update inbox styling

Adjusted to conform to zeplin

[x] conversation-list -> inbox

@keybase/react-hackers

The commits 4ada137dbfcb...78aef9570869 introduce visual changes on linux. :mag_right: 9 changed

Changed: Chat_Conversations_List-You_Rekey_Selected (before) (after)

Changed: Chat_Conversations_List-You_Rekey (before) (after)

Changed: Chat_Conversations_List-Selected_Normal (before) (after)

Changed: Chat_Conversations_List-Selected_Muted (before) (after)

Changed: Chat_Conversations_List-Part_Rekey_Selected (before) (after)

Changed: Chat_Conversations_List-Part_Rekey (before) (after)

Changed: Chat_Conversations_List-Normal (before) (after)

Changed: Chat_Conversations_List-Long_Top (before) (after) (diff)
Changed: Chat_Conversations_List-Long_Bottom (before) (after) (diff)

[ ] Expand dumb height for desktop to remove scrolbar from visdiff

The commits 4ada137dbfcb...987a5bf56fa3 introduce visual changes on linux. :mag_right: 14 changed

Changed: You_Rekey-Normal (before) (after)

Changed: Chat_Participant_Rekey-Normal (before) (after)

Changed: Chat_List-Normal (before) (after)

Changed: Chat_List-Empty (before) (after)

Changed: Chat_Conversations_List-You_Rekey_Selected (before) (after)

Changed: Chat_Conversations_List-You_Rekey (before) (after)

Changed: Chat_Conversations_List-Selected_Normal (before) (after)

Changed: Chat_Conversations_List-Selected_Muted (before) (after) (diff)
Changed: Chat_Conversations_List-Part_Rekey_Selected (before) (after) (diff)
Changed: Chat_Conversations_List-Part_Rekey (before) (after) (diff)
Changed: Chat_Conversations_List-Normal (before) (after) (diff)
Changed: Chat_Conversations_List-Long_Top (before) (after) (diff)
Changed: Chat_Conversations_List-Long_Bottom (before) (after) (diff)
Changed: Chat_Conversations_List-Empty (before) (after) (diff)


Add Amount Healed with bank interface open

Basically, make the 'Item Stats' Plug in work with bank interface open. Maybe only when pressing shift?
This is more suitable for consumables.

I believe the tooltips were originally not shown in the bank interface since players could not eat/drink consumables there. Now that that's no longer the case, I don't see any reason not to add this behavior. (As a bonus, this could be hidden conditionally based on the bank settings for whether consumable menu options are enabled)

sounds good to me!

Closed by #10258


refactor: remove worker pool

Description
Fixes: #611
This PR refactors the policy server by removing the worker thread pool.
Also, it changes the web framework from warp to axum.
Removing the worker pool is possible because we can now share the EvaluationEnvironment between handlers using axum State extractor.
A semaphore is used to limit the simultaneous evaluations instead of relying on a pool of workers.
By doing this we can remove the complexity of the worker pool bootstrap and the bridge between sync and async world, also it simplifies the evaluation flow since we do not have to rely on channels and async communication to start an evaluation in the handlers.
This PR also takes care of the following:

clean-up and major improvements in the layering of the application. The major change is wrapping the policy server code in a PolicyServer type that handles bootstrapping and running the API server.
adding JSON responses in case of errors (before we were returning plain text and status code)

Test
Existing tests were moved/updated to comply with the new code.
This PR also takes care of the following:

adding back timeout protection integration tests that were removed when we removed the venom e2e tests.
refactoring existing tests using axum testing utilities instead of starting a global HTTP server and sending requests against it.

As expected load testing doesn't show major performance improvements, the old and new implementations show briefly the same results.
Manual metrics/tracing was performed.
TODO:

[x] test against a real cluster -> ran e2e tests, passing

Additional Information
Since the sigstore crate dependes on the blocking reqwest feature by using and old version of tough, I needed to wrap the fulcio and rekor initialization in a spawn_blocking task.
This should go away once we update sigstore-rs, see:
https://github.com/sigstore/sigstore-rs/pull/320
and
https://github.com/kubewarden/policy-server/blob/624ca3b650b2914a4e463a37f53c1dab995e3470/src/lib.rs#L58

Fantastic job @fabriziosestito :clap:
I left some comments, I think we're pretty close to merge this PR

Merging, all the concerns/issues have been addressed! :partying_face:


A test of the utility functions for array->param dict was erased

There are two functions in utils that give frequency/time parameters consistent with a given parameter array. There was a unit test of these, but it got erased.

These changes are included in PR #25 .


API Move admin to separate module

Module has been history pruned and refactored out to https://github.com/silverstripe/silverstripe-admin

[ ] CMS PR https://github.com/silverstripe/silverstripe-cms/pull/1760
[ ] Installer PR https://github.com/silverstripe/silverstripe-installer/pull/156

@tractorcow The admin module weighs in at 30.95MB - we need to prune that.
git clone https://github.com/silverstripe/silverstripe-admin.git
Cloning into 'silverstripe-admin'...
remote: Counting objects: 20427, done.
remote: Compressing objects: 100% (6493/6493), done.
remote: Total 20427 (delta 13632), reused 20427 (delta 13632), pack-reused 0
Receiving objects: 100% (20427/20427), 30.95 MiB | 1.66 MiB/s, done.
Resolving deltas: 100% (13632/13632), done.

The actual weight (without history) is ~12MB
du -hc -d 1
 32M	./.git
4.0K	./_config
5.4M	./client
236K	./code
104K	./templates
100K	./tests
120K	./themes
6.1M	./thirdparty
 44M	.
 44M	total

I wonder if this would be a good opportunity to get some thirdparty deps out of code, and avoid bloating the download. It'll cause every composer create-project to download an additional 6.1MB, which could be done a lot more efficiently through pre-bundling into a dist/ folder. We have to keep tinymce in there, since that's compiled on demand (at least for now).
du -hc -d 1 thirdparty/
348K	thirdparty//jquery
556K	thirdparty//jquery-changetracker
 12K	thirdparty//jquery-cookie
760K	thirdparty//jquery-entwine
 40K	thirdparty//jquery-form
 12K	thirdparty//jquery-hoverIntent
 12K	thirdparty//jquery-notice
8.0K	thirdparty//jquery-ondemand
8.0K	thirdparty//jquery-query
724K	thirdparty//jquery-ui
132K	thirdparty//jquery-ui-themes
792K	thirdparty//jstree
2.7M	thirdparty//tinymce
 72K	thirdparty//tinymce-spellchecker
6.1M	thirdparty/
6.1M	total

I trimmed history from the point where we aliased master as 4.0, and trimmed off secondary trees for merge commits. It only reduced the repo size a little.
git clone https://github.com/silverstripe/silverstripe-admin.git
Cloning into 'silverstripe-admin'...
remote: Counting objects: 9363, done.
remote: Compressing objects: 100% (3493/3493), done.
remote: Total 9363 (delta 5591), reused 9363 (delta 5591), pack-reused 0
Receiving objects: 100% (9363/9363), 25.42 MiB | 4.90 MiB/s, done.
Resolving deltas: 100% (5591/5591), done.

I've trimmed all the way up until the release of 4.0.0-alpha5 (so we have no duplicates commits between tags). Down to 3.6 mb compressed.
git clone git@github.com:silverstripe/silverstripe-admin.git
Cloning into 'silverstripe-admin'...
remote: Counting objects: 1346, done.
remote: Compressing objects: 100% (1064/1064), done.
remote: Total 1346 (delta 231), reused 1346 (delta 231), pack-reused 0
Receiving objects: 100% (1346/1346), 3.60 MiB | 1.43 MiB/s, done.
Resolving deltas: 100% (231/231), done.
Checking connectivity... done.

Note that I've used the below to flatten the silverstripe-admin module history.
http://stackoverflow.com/questions/17988099/how-do-i-trivially-linearize-my-git-history

Awesome work, SO CLOSE! :)
Blockers:

New module doesn't run NPM tests or linter
framework runs linter on silverstripe-admin subdirectory (which fails the build)
PHPCS tests in framework fail because of a non-existant folder

Can be fixed after merge:

All Behat tests need to move over into the new module (we could keep some login tests in framework, but I think that's fairly low value)
/lang keys aren't untangled (need new transifex module)
Module doesn't have a README or LICENSE file
Module doesn't expose build status indicators in README (https://travis-ci.org/silverstripe/silverstripe-admin)
Framework still tries to run yarn run build in CI (even though there's no tests)
I wonder if it's worth installing 62MB of node_modules and an entire webpack build toolchain for compiling two SCSS files (./client/src/styles/debug.scss and ./src/Dev/Install/client/src/styles/install.scss). It's probably OK since most contributors will never need to install it (unlike admin, cms and asset-admin, where heavy use of JS and SCSS mandates it)
GridFieldDetailForm_ItemRequest refers to LeftAndMain without class_exists()
GridFieldPrintButton refers to an admin/ css file
TinyMCE refers to assets in FRAMEWORK_ADMIN_DIR
The CMSSecurity class is still in framework?
GenericTemplateProvider still has 'frameworkadmin' => FRAMEWORK_ADMIN_DIR, in framework
Do we need to move upgrade.yml definitions over?
Module needs to be added to the build dashboard at github-dashing.herokuapp.com

All Behat tests need to move over into the new module (we could keep some login tests in framework, but I think that's fairly low value)

Yes, that would be a little bit of work though :) Maybe when behat 3 is a bit closer?

/lang keys aren't untangled (need new transifex module)

We could make this another story. Maybe when we implement https://github.com/silverstripe/silverstripe-framework/issues/5758?

I wonder if it's worth installing 62MB of node_modules and an entire webpack build toolchain for compiling two SCSS files (./client/src/styles/debug.scss and ./src/Dev/Install/client/src/styles/install.scss). It's probably OK since most contributors will never need to install it (unlike admin, cms and asset-admin, where heavy use of JS and SCSS mandates it)

I wasn't really sure what would be necessary to leave here; Maybe we could simplify it a bit? I need a bit of front end guidance on this. :)

GridFieldDetailForm_ItemRequest refers to LeftAndMain without class_exists()

instanceof works even if the class doesn't exist (returns false)

GridFieldPrintButton refers to an admin/ css file

Yep needs fixing.

TinyMCE refers to assets in FRAMEWORK_ADMIN_DIR

Needs fixing.

The CMSSecurity class is still in framework?

Well, it's a security namespace class; It doesn't have a direct dependency on admin module, so it should be safe. I probably need a class_exists around AdminRootController though.

GenericTemplateProvider still has 'frameworkadmin' => FRAMEWORK_ADMIN_DIR, in framework

Needs fixing.

Do we need to move upgrade.yml definitions over?

Yes.
Question: Should we just move gridfield and tinymce to admin module? Move them under the SilverStripe\Admin\Forms namespace?


Simplify getAuthConfigFromSecret and extractProtocol (#2906)

Simplify function to get protocol from legacy secret

Signed-off-by: Christoph Stäbler<EMAIL_ADDRESS>
Remove unneeded KafkaAuthConfig structs

Signed-off-by: Christoph Stäbler<EMAIL_ADDRESS>Signed-off-by: Christoph Stäbler<EMAIL_ADDRESS>

/retest

OCF Webhook is merging this PR


Text overflow

Looks like long code blocks can overflow on mobile

Thanks, just pushed a fix for this!


Unable to shoot arrows

I am unable to shoot arrows. The issue started happening after adding both Artificer and the 5e spells optional file.
The following is my mod list.

(I can also send my save if that could help).

There is a guide on how to solve this on the mod forum on Nexus. It looks like a save compilation issue when you update the game with the mod installed.

There is a guide on how to solve this on the mod forum on Nexus. It looks like a save compilation issue when you update the game with the mod installed.

Fresh game, fresh mods, for Patch 7 - issue still persists. If I start a new game with Artificer mods it works fine for some time, then randomly it will start happening again mid act-1. If I don't have Artificer mod, the issue never happens.
Current modlist:


docs: Update build instructions for OS X > 10.10

Since Mac OS X 10.10 compiling against OpenSSL is a bit strange since as already mentioned in the README Apple doesn't ship Header files anymore. This updated build command resolves the build errors which occured before so semantic-rs can be compiled successfully on current OS X versions.

@not-a-robot r+


Multiple include-paths from CLI

includePaths from the Node API expects an array of paths, but I can't figure out how to pass multiple paths on the command line. Is that possible? It seems like the CLI is checking for include-path to be an array, but it is initially declared as a string.
I expected it to work like node-sass sass/ --include-path path/1/ path/2/ -o css/. Perhaps there is a different syntax and I'm just being a bit dull?
If this is currently impossible, I could certainly try my hand at implementing it!

Just a shot in the wild, but have you tried node-sass sass/ --include-path /1 --include-path /2. This is just a guess, since it is how most CLI tools work ...

@mgreter Nice! worked great!

:+1:


910 pjg computeclimopts

@lee1043 @acordonez I'm sure there is a cleaner way to do this but these options are now functional.  OK to overhaul as needed!  The first option enables removing the clim period from the file name (useful, e.g., when clim is based on the entire time series period which is already part of the filename).  The second option is to modify the default clim output list.  Parameter file I have tested this with:  https://github.com/PCMDI/obs4MIPs-cmor-tables/blob/230_clims_pjg/inputs/pcmdi/mkClims/test_obs_param.py
You probably don't have permission to write to obs4MIPs database so if you want to test this you probably need to change output path.

@lee1043 any hints regarding when these simple additions can be added? ;-)

@gleckler1 sorry for the delay. I will check this and merge it today.

@gleckler1 just merged!

@lee1043  Great, thank you!  I'll take it for a spin!


adds clone.js to utils

just a small utility function
MERGE ME FIRST PLEASE

cool! We need warnings for nested objects


Switch to attoparsec as the parser to use until an error occurs

At the moment Trifecta is very slow and memory consumptive. It dominates the profiling output (though maybe @ekmett knows what we're doing wrong). Yet it gives such great error message, it would be hard to give up.
I wonder if we could use both attoparsec and Trifecta, and if parsing fails with the former, reparse with the latter for the error message.
I mention this because right now parsing the entirety of nixpkgs takes several minutes, which is unacceptable.

That sounds great :)  I wonder if it's possible to productive cache parsing
(in conjunction with this)
On Thu, Apr 5, 2018, 23:48 John Wiegley<EMAIL_ADDRESS>wrote:

At the moment Trifecta is very slow and memory consumptive. It dominates
the profiling output (though maybe @ekmett https://github.com/ekmett
knows what we're doing wrong). Yet it gives such great error message, it
would be hard to give up.
I wonder if we could use both attoparsec and Trifecta, and if parsing
fails with the former, reparse with the latter for the error message.
I mention this because right now parsing the entirety of nixpkgs takes
several minutes, which is unacceptable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jwiegley/hnix/issues/147, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGlYIQGRlGnD7OAf0jMrcYD4bVYJo1Sks5tluV4gaJpZM4TJd8j
.

Here's the profiling results for all of nixpkgs. It appears that much of the slowness is due to the enormous turn-over in temporary allocations:
        Thu Apr  5 20:50 2018 Time and Allocation Profiling Report  (Final)

           hnix +RTS -p -RTS -f -

        total time  =      243.46 secs   (243463 ticks @ 1000 us, 1 processor)
        total alloc = 310,382,398,904 bytes  (excludes profiling overheads)

COST CENTRE       MODULE                                SRC                                             >

>>=.\             Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(144,5)-(171,13)    >
satisfy.\         Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(227,5)-(235,58)    >
fmap.\            Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:108:46-67           >
<?>.\             Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(204,41)-(206,50)   >
<$.\              Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:110:42-71           >
<|>.\             Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:123:5-88            >
<|>.\.\           Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:123:17-76           >
>>=.\.\           Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(151,24)-(169,15)   >
unconsB           Codec.Binary.UTF8.Generic             Codec/Binary/UTF8/Generic.hs:297:1-18           >
>>=.\.\           Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:147:16-88           >
parseFromFileEx   Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(365,1)-(367,70)    >
try.\             Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:202:45-72           >
decode            Data.ByteString.UTF8                  Data/ByteString/UTF8.hs:(68,1)-(124,32)         >
string            Text.Parser.Char                      src/Text/Parser/Char.hs:216:3-51                >
identifier        Nix.Parser.Library                    Nix/Parser/Library.hs:99:1-46                   >
decode.choose     Data.ByteString.UTF8                  Data/ByteString/UTF8.hs:(72,3)-(78,39)          >
displayIO.display Text.PrettyPrint.ANSI.Leijen.Internal Text/PrettyPrint/ANSI/Leijen/Internal.hs:(1159,7>
<?>.\.\           Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:206:13-49           >
<?>               Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(204,3)-(206,50)    >
char              Text.Parser.Char                      src/Text/Parser/Char.hs:196:3-38                >
>>=               Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(143,3)-(171,13)    >
fmap              Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:108:3-67            >
manyAccum.\.walk  Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:190:7-119           >
>>=.\.\.\         Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:158:20-51           >
uncons            Data.ByteString.UTF8                  Data/ByteString/UTF8.hs:(166,1)-(167,38)        >
<>                Text.Trifecta.Delta                   src/Text/Trifecta/Delta.hs:(119,3)-(134,101)    >
manyAccum.\       Text.Trifecta.Parser                  src/Text/Trifecta/Parser.hs:(190,3)-(193,47)    >

Here's what these numbers and errors need to be compared with, by running:
time find ~/src/nix/nixpkgs -name '*.nix' | xargs nix-instantiate --parse > /dev/null

which gives:
error: undefined variable ‘hostPlatform’ at /Users/johnw/src/nix/nixpkgs/pkgs/os-specific/windows/pthread-w32/default.nix:4:8
error: undefined variable ‘URL’ at /Users/johnw/src/nix/nixpkgs/pkgs/development/interpreters/python/cpython/docs/template.nix:8:11
error: undefined variable ‘placeholder’ at /Users/johnw/src/nix/nixpkgs/pkgs/development/libraries/pipewire/default.nix:37:46

real	0m3.158s
user	0m2.499s
sys	0m1.516s

This issue is being tracked in #16.


13 starboard

Resolves #13

K I'm gonna look at this today finally

Additional considerations:

Do we want reactboard messages to be deleted when their original message is deleted? Or are reactboards a deletion-resistant museum of sorts?
The bot occasionally joins reacts, but it ignores :star: reacts. It should probably ignore all other reactboard emojis, too. We can probs add this later, since right now we only really need the starboard working.


Rejecting invocation, expected 6 argument registers, method signature has 7 or more

 java.lang.VerifyError: Verifier rejected class cafe.adriel.lyricist.JaStringsKt: void cafe.adriel.lyricist.JaStringsKt.<clinit>() failed to verify: void cafe.adriel.lyricist.JaStringsKt.<clinit>(): [0x79F] Rejecting invocation, expected 6 argument registers, method signature has 7 or more (declaration of 'cafe.adriel.lyricist.JaStringsKt' appears in /data/data/com.xx.xx/code_cache/.overlay/base.apk/classes5.dex)

It seems that an error occurs because there are too many fields in the data class.

If the data class has too many arguments (a language limitation), you can split them into nested data classes. That way you can have virtually an infinite number of strings.
data class Strings(
  screenA: ScreenAStrings(),
  screenB: ScreenBStrings(),
  ...
)

data class ScreenAStrings(
  ...
)

Feel free to reopen if this solution doesn't work for you.


Issues publishing to Azure VM

First of all, thank you for this awesome repo.
Just need a help with publishing to Azure VM. While I can publish to local folders without any issues, I got some errors when trying to publish to Azure VM via Web Deploy.
The following errors have stopped me from publishing:
Severity	Code	Description	Project	File	Line	Suppression State
Error	TS1148	(TS) Cannot use imports, exports, or module augmentations when '--module' is 'none'.	Miscellaneous	~\iceandfire\App.vue	36	Active
Severity	Code	Description	Project	File	Line	Suppression State
Error	TS1219	(TS) Experimental support for decorators is a feature that is subject to change in a future release. Set the 'experimentalDecorators' option to remove this warning.	Miscellaneous	~\iceandfire\App.vue	46	Active
Error	TS2307	(TS) Cannot find module 'vue'.	Miscellaneous	~\iceandfire\App.vue	36	Active
Error	TS2307	(TS) Cannot find module 'vue-property-decorator'.	Miscellaneous	~\iceandfire\App.vue	37	Active

Any help would be appreciated. Thanks.

Hi 👋
Could you maybe provide a little more information about the problem you are facing? Also, maybe try to update the node version.
I have created a fresh project from the template and published it to Azure(Web service), it works fine.
URL: https://issues8.azurewebsites.net/template/info ( will remove it in a few days )
Also, try to run the production command, npm run build:prod and see if you encounter any errors.

Closed due to no activity. The project can be published normally to Azure.

Sorry I meant to give more feedback but I have issues with my Azure VM it seems that Web Deploy won't even connect now. Until I resolved the issues with my Azure VM just keep this closed. I will get back once I got my Web Deploy working and if I still have issues. Thanks.


Update media/ path to image

Update media/ path to images

Manually merged due conflicting changes. All changes now included in master branch.


🍒 Cherry pick PR #14508 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/14508 to staging 🍒

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.2.58-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


implement account deactivation through --deactivate parameter

This is an updated version of https://github.com/lukas2511/dehydrated/files/2641548/dehydrated_add_deactivate_command.diff.txt
Fixes #216

This should do something with the deactivated key so it doesn't just error out on rerun. Maybe touch a file "deactivated" in the account directory and check on load if it exists, if it does error out "Account has been deactivated, please delete old key and register a new one.", or just simply delete or rename the account directory after it was successfully deactivated.
Also as stated in #216 ACMEv1 does support deactivation as well and it should be easy to implement as it's basically the same as with v2.

Merged


Refactor to simplify codebase and reduce dependencies

A number of dependencies have minimal use or overlap with other dependencies. Refactor the code base to eliminate redundant dependencies. Some of the code is unused or duplicated between public and admin - clean this up.
Here's a list of potential items to look at:

Review public/src/core classes and remove all unused
Review admin/src/core classes and remove all unused, then move common ones between admin and public to libs
@angular/cdk - only used by public component (openCustomDialog) in http-error.interceptor, while admin component uses openErrorDialog in http-error.interceptor. Refactor public to be like admin. (@angular-cdk can't actually be removed though, it is a peer dependency of other angular packages).
There are 3 dependencies on bootstrap in admin and public: @ng-bootstrap/ng-bootstrap, bootstrap, and ngx-boostrap. ng-bootstrap is used and can be kept, bootstrap is the most likely candidate to remove (impact unknown though), and not sure about ngx-bootstrap.
Remove jquery and rewrite any scripts making use of it.
@angular/forms from public - refereneced in form-control.directive.ts that I suspect is not used. Likely referenced in FormGroupComponent which isn't used.

These changes will potentially impact functionality so significant UI testing will be required.

@basilv is this ticket still relevant?

This is still relevant maybe, depending on the longer term whether we want to redo the FOM UI in synch with FOP, or to refresh it to match the design system.
The intent of this specific ticket is to reduce the # of dependencies in FOM to make it easier to keep current.

@basilv dependencies on what?


Activation offloading to CPU's for the Linear, Layernorm Linear and the Layernorm MLP modules

This PR adds support for offloading all the tensors saved for backward pass by the Linear, Layernorm Linear and the Layernorm MLP modules except the weight tensors.
The cpu_offloading switch will be sent from the M-LM module construction which will enable calling the PyTorch hooks during tensor saving and retrieval. When these PyT hooks are called, the weight.main_grad isn't saved, so we save them separately on a need basis when we need to fuse gradients. All these layer executions will be done under a context which is placed at M-LM repo.
Please review and let me know if you have any questions.

/te-ci pytorch

Could you add some unit test for the functionality?

/te-ci pytorch

/te-ci pytorch

I've fixed most of the functional and lint errors and added some new tests as well as opposed to the singular test file that wasn't being used. The offloading for the TransformerLayer is failing with the following error due to the LayerNormMLP block, specifically during the offloading of weights.
RuntimeError: Attempting to use FunctionalTensor on its own. Instead, please use it with a corresponding FunctionalTensorMode()

@sanandaraj5597 The above bug is a result of an attempted offload of a [4, 4] tensor, which seems unusual.
Additionally, the Linear and LayerNormLinear modules are not setting the weight_offloading attribute for the weight itself.

Fixed the issue you were seeing Kirthi. Please review. Thank you.

/te-ci pytorch


Elements that aren't themable

https://github.com/Microsoft/vscode/issues/23294
Not sure if these are in progress, but I changed every theme attribute to red/yellow so I can notice which elements aren't themable.

[x] Selected rows in list (also file explorer, etc)

[ ] Placeholder text in input boxes (above screenshot)
[ ] Disable/uninstall buttons on extension page

[ ] Notification bar

[ ] Badge on list (search results, problems)

[ ] Welcome page

[ ] This thing

[ ] And the background on this popup

[ ] Not all editor settings applied inside the welcome walkthrough

This one goes out to Hot Dog Stand
Items collected by @psuedoSudo

[x] Autocomplete box

[ ] Background on startup

[ ] Button outline in debug panel

[ ] Disable and uninstall buttons

[ ] Vscode feedback popup

[x] Right sidebar in git diff view

[ ] Search and replace dropdown on hover

[ ] Selected tab underline in bottom tray

[ ] Total settings count background and gray lines

[x] Sidebar file selection highlighting.

Selected (blue), hovered (dark gray) and out of focus (lighter gray)

[ ] Welcome page quick links

Extra
These might be out of scope for the initial workbench theming but as far as I can tell the buttons and badges used throughout the ui are also not themable.

[ ] git file status badges and counts

[ ] Install button

[ ] open folder button

[ ] reload button

@bpasero I assume you set the March milestone as you are working on fixes?

That is usually what it means.

Awesome, just learned that there is a ::placeholder CSS pseudo element that can be used to theme the placeholder text 👍
Great findings, will continue in April.

[ ] Terminal picker dropdown

Some of these are duplicates but I'm cross-posting this here as requested in #3112
I've switched to insiders so I can test the Solarized Dark theme.
I'm not sure if these are issues with the theme or the theming support but I've tried to find all the ui areas that I think aren't themed yet. Some are pretty minor but hopefully it helps.
Autocomplete box

Background on startup

Button outline in debug panel

Disable and uninstall buttons

Vscode feedback popup

Right sidebar in git diff view

Search and replace dropdown on hover

Selected tab underline in bottom tray

Total settings count background and gray lines

Sidebar file selection highlighting.

Selected (blue), hovered (dark gray) and out of focus (lighter gray)

Welcome page quick links

Extra
These might be out of scope for the initial workbench theming but as far as I can tell the buttons and badges used throughout the ui are also not themable.
git file status badges and counts

Install button

open folder button

reload button

@psuedoSudo Great list of missing items. I copied them from your comment to the issue description, along with checkmarks to track our progress.

please consider adding:
editorColumnHighlight
editorColumnHighlightBorder
so that a cross-hair effect can be produced - old/tired eyes will appreciate it

@davenport Can you add a screenshot? Not sure what you mean.

This is a screenshot from vim. Believe it or not this is usually a deal breaker for me when switching editors.

I'm not sure there is a way to customize minimap background as well (at least I did not find it).

I've got an impossible one: editor right click context menu.
It's not just an aesthetic thing, it always bothered me that if you are using a dark theme right clicks flash light into your eyes.
This might be so unfixable I am offtopic, but I think it's worth mentioning.

I couldn't see it above, but would it be possible to add a background colour for the explorer title? That way the colour from the tabs and activity bar can flow through.

There is!

@bpasero I tried setting the INACTIVE and ACTIVE backgrounds, but they only affect the title bar, not the 'EXPLORER' heading - that was my bad for using the word 'title' instead of heading :)

@benperiton there is only sideBarBackground right now.

@bpasero Ah ok cool, something that could be added in the future?

Probably, today we have no use case for a separate color there as none is used.

Is there a way to change the intellisense active item?

@Tyriar It's currently the listFocusBackground but I think it makes sense to add a specific color for suggest, given that you can customize the background color. I created #25522

Moving to May, I think we will not have everything covered by April.

More  items identified:
Title/Editor action bar icons

Panel Drop-down\list focus color:

Debug Launch drop-down (select box) focus color:

Find Selected/Focused Text: (also file find):

@cleidigh icons are not themable at all anywhere in the UI. The other ones are good catches, looks very bad especially on Windows where the selection color is so strong (compared to Windows).

@bpasero

good to do something useful - I already learned select/options has platform and browser styling limitations
I infer from your prior comments , best to have issues for each of these for tracking
I also infer (other than the icons) that the other items having been there for a while so they have all been determined to be legitimate candidates , priority TBD

so I will do the following to set up for May milestones IF you agree:

create individual issue for each theme item, common issue title "UI Theme Add: xyz" (easy search)
copy image for reference, current UI color name where obvious or possible new names for discussion
any known issues from above

Then you and the team can decide what goes into the May milestones, then discuss / assign
I am already working on the select box as mentioned interesting issues, may want to really be a single select list. Also found it odd not all UI items in color registry and default colors distributed in various places.

Tree default foreground color:

@equinusocio What icon theme are you using?

@rfgamaral From my Material Theme, https://github.com/equinusocio/vsc-material-theme

Is the border of scroll bar themable?

I do not see any option to change the color of the border of pair character indicator.

I have extracted some issues for specific editor things that are not themable yet: https://github.com/Microsoft/vscode/issues/26102, https://github.com/Microsoft/vscode/issues/26103, https://github.com/Microsoft/vscode/issues/26104,
https://github.com/Microsoft/vscode/issues/26105

We continue working on this but will probably not get everything done for May, so moving to Backlog to focus on individual items as we see fit. Thanks for the input 👍

Is there a way to theme the intellisense parameter info popup?

@pzuraq I created #26671

Inspect TM Scopes dialog now also uses the hover colors

@aeschli Is already released on insieders?

Closing this one, I added support for extension buttons. The full list of new colors is available here: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_13.md#theming
For things still missing I suggest to open separate issues (after checking for any existing duplicates).

Would it be at all possible to somehow change the style of changed files in explorer? I know there is issue #178 but I thought it maybe a simple change so asking here. Thank you!

@joeshub outside of icon themes which you can use today, it's not a particularly simple change and https://github.com/Microsoft/vscode/issues/178 is the right spot for the discussion.

@Tyriar that's exciting, looked it up, do you know by any chance if there's documentation on how to set up VS icons to reflect git status?

I believe the icons can only be based on the type (folder/file) and the name of the file.


syz-manager: re-minimize a subset of corpus programs

The current fuzzing algorithm in syzkaller may preserve the poorly
minimized corpus programs forever - they trigger a lot of coverage and
will very likely survive all syzkaller restarts.
As a result, more than 18% of the current syzbot corpus programs are
larger than 25 calls, which is an unreasonably big figure.
Introduce a way to prevent the domination of the bigprograms in the
corpus.
Every corpus retriage, pick up to 50 seeds among the 10% largest corpus
programs and re-minimize them. Hopefully, this should reduce the
magnitude of the problem.

PTAL


sweep, rpcserver: optimize SendAll cost wise

Change Description
If there is a coin of value equal to the amount reserved for anchor bumping (e.g. 100k sats), SendAll used to spend it and to create another coin of such size. Now it just does not touch the coin in this scenario.
To achieve this, added argument skipInputAmount to fn sweep.CraftSweepAllTx. If it is not 0, it looks for an input of that value and skips it. If it can't find an input, it skips locking UTXOs and returns ErrMissingInputToSkip.
Added unit test for new functionality of CraftSweepAllTx.
Added itest to test the optimization in SendAll.
SendAll is used by lncli sendcoins --sweepall.
Steps to Test

Run LND node built from this PR
Open few channels
Fund node's wallet with with 0.01 BTC
Run lncli sendcoins --sweepall moving all the funds to an external address
That tx should have a change output of value equal to reserved funds (e.g. 100k if there are 10+ channels)
Fund node's wallet again with 0.01 BTC
Run lncli sendcoins --sweepall again moving all the funds to an external address
The tx should be 1-to-1, not 2-to-2, as it would be before this PR

Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[x] Tests covering the positive and negative (error paths) are included.

Code Style and Documentation

[x] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[x] Commits follow the Ideal Git Commit Structure.
[x] Any new logging statements use an appropriate subsystem and logging level.
[ ] There is a change description in the release notes, or [skip ci] in the commit message for small changes.

An example tx.

Superseded by https://github.com/lightningnetwork/lnd/pull/8955

Change Description
If there is a coin of value equal to the amount reserved for anchor bumping (e.g. 100k sats), SendAll used to spend it and to create another coin of such size. Now it just does not touch the coin in this scenario.
To achieve this, added argument skipInputAmount to fn sweep.CraftSweepAllTx. If it is not 0, it looks for an input of that value and skips it. If it can't find an input, it skips locking UTXOs and returns ErrMissingInputToSkip.
Added unit test for new functionality of CraftSweepAllTx.
Added itest to test the optimization in SendAll.
SendAll is used by lncli sendcoins --sweepall.
Steps to Test

Run LND node built from this PR

Open few channels

Fund node's wallet with with 0.01 BTC

Run lncli sendcoins --sweepall moving all the funds to an external address

That tx should have a change output of value equal to reserved funds (e.g. 100k if there are 10+ channels)

Fund node's wallet again with 0.01 BTC

Run lncli sendcoins --sweepall again moving all the funds to an external address

The tx should be 1-to-1, not 2-to-2, as it would be before this PR

Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.

[x] Tests covering the positive and negative (error paths) are included.

Code Style and Documentation

[x] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.

[x] Commits follow the Ideal Git Commit Structure.

[x] Any new logging statements use an appropriate subsystem and logging level.

[ ] There is a change description in the release notes, or [skip ci] in the commit message for small changes.

Example transaction

lncli sendcoins --sweepall

If this PR was applied, the transaction wouldn't include its last input and first output (0.001 BTC each).


return response, need it for error handling

Hi all,
In order to perform error handling on my side, I need the actual response returned from this call. Printing the response does nothing for me, so I modified it to return the actual response object.

Hey @fullmetalengineer, thanks for your contribution. We have removed puts in new version. However, if you want to access the response, for example, you should do this:
# frozen_string_literal: true

require 'mailersend-ruby'

ms_domains = Mailersend::Domains.new
puts ms_domains.list.status

Our responses are matching the http library we are using, HTTP.rb, so you could use body.to_s for example to print out the body of response, etc.


Bug: [IL2CPP] ExecutionEngineException on deserializing array of struct

Expected behavior
Successfully deserializing json with array of nested struct.
{"classProp":"this is classProp Value", "myArray":[{"someProp":"someProp Value"}]}
Actual behavior
Getting ExecutionEngineException.
ExecutionEngineException: Attempting to call method 'System.Collections.Generic.List`1[[MyClass+NestedStruct, Assembly-CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]]::.cctor' for which no ahead of time (AOT) code was generated.
Steps to reproduce

New project
Import jillejr.newtonsoft.json-for-unity via UPM
Add following script to scene:

public class MyClass
{
    public struct NestedStruct
    {
        public string someProp;
    }

    public string classProp;
    public NestedStruct[] myArray;
}

public class Main : MonoBehaviour
{
    private string JsonToParse = "{\"classProp\":\"this is classProp Value\"," +
                                 "\"myArray\":[{\"someProp\":\"someProp Value\"}]}";
    void Start()
    {
        var d = JsonConvert.DeserializeObject<MyClass>(JsonToParse);
        Debug.Log(d.classProp);
        Debug.Log(d.myArray.Length);
    }
}

Run the game

Details
Please Note that if I changing the struct to class, it will work as expected.

Host machine OS running Unity Editor 👉 MacOS Catalina

Unity build target 👉 Android

Newtonsoft.Json-for-Unity package version 👉 12.0.301

I was using Unity version 👉 2018.4.26
Checklist

[x] Shutdown Unity, deleted the /Library folder, opened project again in Unity, and problem still remains.
[x] Checked to be using latest version of the package.

Hi @SergeOxe! Thanks for making such a clear issue! This is actually a known issue with the package, and I apologize for not being clear about it back.
The issue here is about some AOT generation. Funny, System.Collections.Generic.List<T> is one of the more difficult types to get an AOT error about :)
I have written some wiki pages, a bit hidden, over 'ere: https://github.com/jilleJr/Newtonsoft.Json-for-Unity/wiki/Fix-AOT-compilation-errors, and in this case, I would suggest looking into using AotHelper. Especially the AotHelper.EnsureList<T>
To fix this, you need to add AotHelper.EnsureList<NestedStruct>() to a file that won't be stripped (such as a class that inherits from MonoBehaviour, a type with the [Preserve] attribute, or a type that's preserved via a link.xml file). The code does not need to run, nor does it need to be added to a GameObject in a scene; it only need to be included in the build. Example:
using UnityEngine;
using Newtonsoft.Json.Utility;

public class AotEnforcements : MonoBehaviour
{
    public void Awake()
    {
        AotHelper.EnsureList<NestedStruct>();
    }
}

Hope that resolves it for you! :)

Hi @SergeOxe! Thanks for making such a clear issue! This is actually a known issue with the package, and I apologize for not being clear about it back.
The issue here is about some AOT generation. Funny, System.Collections.Generic.List<T> is one of the more difficult types to get an AOT error about :)
I have written some wiki pages, a bit hidden, over 'ere: https://github.com/jilleJr/Newtonsoft.Json-for-Unity/wiki/Fix-AOT-compilation-errors, and in this case, I would suggest looking into using AotHelper. Especially the AotHelper.EnsureList<T>
To fix this, you need to add AotHelper.EnsureList<NestedStruct>() to a file that won't be stripped (such as a class that inherits from MonoBehaviour, a type with the [Preserve] attribute, or a type that's preserved via a link.xml file). The code does not need to run, nor does it need to be added to a GameObject in a scene; it only need to be included in the build. Example:
using UnityEngine;
using Newtonsoft.Json.Utility;

public class AotEnforcements : MonoBehaviour
{
    public void Awake()
    {
        AotHelper.EnsureList<NestedStruct>();
    }
}

Hope that resolves it for you! :)

For reference, the reason it works when it's a class and not when it's a struct is because the IL2CPP compiler does some generics reuse in its code generation.
The Unity engine already has some references to some List<T> types here and there, and the IL2CPP compiler can take the code it generates for example for a List<GameObject> and reuse the exact same implementation for List<NestedClass>. This is because both GameObject and NestedClass in this example are reference types. I.e. they are just pointers. It doesn't matter if one's a pointer to a GameObject and one's to a NestedClass, they both are just the same size of a .NET pointer.
In the background, a List<T> stores its items in an array of T[]. To restate: GameObject[] and NestedClass[] arrays both look the exact same in memory, and IL2CPP can abuse this. Example memory of such array:
0: int32, array length (4 in this case)
1: int64, pointer to GameObject
2: int64, pointer to GameObject
3: int64, pointer to GameObject
4: int64, pointer to GameObject

0: int32, array length (4 in this case)
1: int64, pointer to NestedClass
2: int64, pointer to NestedClass
3: int64, pointer to NestedClass
4: int64, pointer to NestedClass

Structs have this particular property of being embedded wherever they're used. For example, if we had the following struct:
struct Vector2 {
    public int x;
    public int y;
}

Then the memory of an Vector2[] would look like so:
0: int32, array length (4 in this case)
1: int32, Vector2.x of Vector2 at index 0
2: int32, Vector2.y of Vector2 at index 0
3: int32, Vector2.x of Vector2 at index 1
4: int32, Vector2.y of Vector2 at index 1
5: int32, Vector2.x of Vector2 at index 2
6: int32, Vector2.y of Vector2 at index 2
7: int32, Vector2.x of Vector2 at index 3
8: int32, Vector2.y of Vector2 at index 3

Because structs behaves like this, IL2CPP does not even try to reuse generic types where the generic type argument is a struct.
More about this here: https://blogs.unity3d.com/2015/06/16/il2cpp-internals-generic-sharing-implementation/

For reference, the reason it works when it's a class and not when it's a struct is because the IL2CPP compiler does some generics reuse in its code generation.
The Unity engine already has some references to some List<T> types here and there, and the IL2CPP compiler can take the code it generates for example for a List<GameObject> and reuse the exact same implementation for List<NestedClass>. This is because both GameObject and NestedClass in this example are reference types. I.e. they are just pointers. It doesn't matter if one's a pointer to a GameObject and one's to a NestedClass, they both are just the same size of a .NET pointer.
In the background, a List<T> stores its items in an array of T[]. To restate: GameObject[] and NestedClass[] arrays both look the exact same in memory, and IL2CPP can abuse this. Example memory of such array:
0: int32, array length (4 in this case)
1: int64, pointer to GameObject
2: int64, pointer to GameObject
3: int64, pointer to GameObject
4: int64, pointer to GameObject

0: int32, array length (4 in this case)
1: int64, pointer to NestedClass
2: int64, pointer to NestedClass
3: int64, pointer to NestedClass
4: int64, pointer to NestedClass

Structs have this particular property of being embedded wherever they're used. For example, if we had the following struct:
struct Vector2 {
    public int x;
    public int y;
}

Then the memory of an Vector2[] would look like so:
0: int32, array length (4 in this case)
1: int32, Vector2.x of Vector2 at index 0
2: int32, Vector2.y of Vector2 at index 0
3: int32, Vector2.x of Vector2 at index 1
4: int32, Vector2.y of Vector2 at index 1
5: int32, Vector2.x of Vector2 at index 2
6: int32, Vector2.y of Vector2 at index 2
7: int32, Vector2.x of Vector2 at index 3
8: int32, Vector2.y of Vector2 at index 3

Because structs behaves like this, IL2CPP does not even try to reuse generic types where the generic type argument is a struct.
More about this here: https://blogs.unity3d.com/2015/06/16/il2cpp-internals-generic-sharing-implementation/

@jilleJr Thanks for your quick response and detailed explanation! You are doing a great job 💪. I missed the wiki page, thanks!

@jilleJr Thanks for your quick response and detailed explanation! You are doing a great job 💪. I missed the wiki page, thanks!

@SergeOxe Heh thanks :) I got into writing mood so may have written too much detail /shrug. Tell me if AotHelper fixed the problem! I do find joy in resolving these issues

@SergeOxe Heh thanks :) I got into writing mood so may have written too much detail /shrug. Tell me if AotHelper fixed the problem! I do find joy in resolving these issues


Wrong limitation "Cloud only" in description.

The following paragraph is quoted from the SourceFolder parameter description:
"PurgedItems: (Cloud only) The Recoverable Items\Purges folder. This folder contains items that have been purged from the Recoverable Items folder (hard-deleted items)."
The mentioned limitation "Cloud only" is incorrect as this also works in OnPremise Exchange 2019 environments.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 21b1cd9d-df2e-d4d6-52e2-d3fbdfb9db9f
Version Independent ID: e675173d-290a-dee0-62a4-5485cf3d2570
Content: Restore-RecoverableItems (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Restore-RecoverableItems.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@arodir, confirmed. I updated Restore-RecoverableItems and also Get-RecoverableItems.
Thanks for the feedback.
Closing

@arodir, confirmed. I updated Restore-RecoverableItems and also Get-RecoverableItems.
Thanks for the feedback.
Closing


MixitUp initialized after Ajax call

So I have a page that makes an ajax call and splices the returning html onto an element in my dom. Included in this html is an element with the id of 'card-container' I then call $('#card-container').mixItUp(...) but nothing happens. If I load this page with a full refresh and build the page with the html already in the dom at startup everything works. I have tested that $('#card-container').length == 1 just after the ajax call and before the call to mixitup.

Totally solved the problem. Thanks !!

Problem solved, you should write it on the docs.

Awesome solution Thanks alot @toddca <3


Target correlation

Finished targetCorrelation function

You should open the project first (AutoExploreR.RProj), rather than any individual script; this should open the project in the development environment. You should then be able to build with

ctrl+shift+b

which will load the package and all its functions. To run all tests use

ctrl+shift+t

If there's any problems with all this you may need to run devtools::load_all() first. I am not sure about auto installing required packages, I will look into it.

Thanks all good now. Tests running. Merging and closing.


Have the 'online_resource' metadata for WMS service defaulted to the service URL if not described

To simplify the configuration of a WMS service, the 'online_resource' metadata (mandatory by the WMS specification) could be defaulted to the service URL if this one is not described in the yaml MapProxy configuration file.
Note; This could also resolve the problem identified at
http://osdir.lowified.com/mapproxy-gis/2012-02/msg00016.html

I suggest the following modification in the wms templates files wms100capabilities.xml, wms110capabilities.xml, wms111apabilities.xml and wms130capabilities.xml:
{{if service.online_resource}}
  <OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="{{service.online_resource}}"/>
{{else}}
  <OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="{{service.url}}"/>
{{endif}}

OnlineResource is empty if it is not defined in the configuration. So the Capabilities are still valid.
The metadata OnlineResource (different than the DCP OnlineResource) should point to a website for this service. So I'm not sure how a link to the service is helpful.

On a GetCapabilities request to the WMS service, my concern is that the GetCapabilities, GetMap and GetFeatureInfo DCP OnlineResource are guest from the service URL, but not the metadata OnlineResource. The metatada Service OnlineResource is filled from the 'online_resource' configuration key.
By looking at the WMS specifications (at least 1.1.1 of OGC), the OnlineResource should always contains a valid URL (chapter 6..2.2). In this condition, the 'online_resource' configuration key should be filled. In a concern of simplifying the deployment of the MapProxy product, the 'online-resource' configuration should so contains a valid URL (http://my-host/ blah, blah, ...). But in the majority of case, this is the service URL. That's why I suggest to guess the metada OnlineResource if not described in configuration file.

Ok. I just checked with the XML DTD and it allowed empty OnlineResources.
Thanks for the pull request!


Add homepage

This replaces "Hello world!"
It copies the current Digital Marketplace, with the following caveats:

No link to Crown Hosting—we don't have the page yet
No link to framework information pages (we don't have the pages yet, and maybe they will be published on GOV.UK by the time this app goes live)

And the following sub-caveat:

I don't know what the URL structure for search will be yet, so have assumed /search?lot=saas

The lack of all punctuation disturbs me, but "it's in the guide", I know.


keybase is abandoned

Given the amount of spam in this Issues tracker, and the Reddit problem, I suspect Keybase may be abandoned.

Code is being updated though, but yeah... 3 of my proofs are failing, despite being where they are supposed to be ;)
For example https://github.com/keybase/client/pull/26904

Notice that all the spam that was here when you wrote this is gone, but new spam is in place
It's just that Github's spam problem is getting out of control even for maintained repos

I'm speculating, but both Twitter and Reddit have become pretty hostile to API users, so I'm guessing that's a reason why those are failing, though Facebook is failing too.


How people retrieve password? for yobiapps

Im thinking how if people forgot the password for yobiapps?
is there any recovery password or something?

The functionality is available in the current version of Yobichain.


Support for next middleware function

This will allow the solid-start middleware to be bypassed to the next middleware.
entry-server can take a next param which will enable it to move to the next middleware.

I was able solve my use case by making ApolloServer lazy load:
function graphql_plugin_(path) {
	/** @type {import('vite').ServerHook} */
	const configureServer = async server=>{
		/** @type {import('apollo-server-express').ApolloServer<any>} */
		let apollo
		/** @type {import('express').Router} */
		let router
		server
			.middlewares
			.use(async (req, res, next)=>{
				if (!apollo) {
					const { typeDefs, resolvers } = await server.ssrLoadModule('@censible/service-domain')
					apollo = new ApolloServer({
						typeDefs,
						resolvers,
						plugins: [ApolloServerPluginDrainHttpServer({
							httpServer: server.httpServer
						})],
					})
					await apollo.start()
					router = apollo.getMiddleware({
						path
					})
				}
				router(req, res, next)
			})
	}
	return { configureServer }
}

The issue with something like this is that now you have to figure out how to integrate this into the adapters since they don't use vite middleware to build their server.. so doing stuff with the vite server creates a split where u need to setup the build step and dev step separately. Maybe we can brainstorm how to do this from within entry-server itself without involving vite.

In the case of Apollo, there's a different adapter for each platform. I don't know if having to support the dev & prod adapters separately is avoidable. Making it easier to manage by creating the right abstractions to handle each platform seems doable & will form a base layer if a common interface can be created.

We do want to enable you to use platform specific primitives where you want, and you would be consciously opting out of universal deployment for that app. I see Cloudflare workers KV or Durable Object beings examples of this. But I don't think the vite config is the correct place for this since that's working in dev only. In prod your entry-server is the main place to initialize these things. including lazy loading via dynamic imports..
Could you try what this might look like via a dynamic import in entry-server. We do support middleware in there so this might work.
Closing this for now, but you can open it again if things don't work as you want!


Release: 2.0.0a0

Working towards the 2.0 version release alongside DRF 3.4 + CoreAPI with the OpenAPI codec.
The proof of concept was built https://github.com/marcgibbons/core-api-swagger and can be previewed at https://core-api-swagger.herokuapp.com/.
This version has breaking changes; introspection and schema generation is now handled by Django REST Framework. The package provides a renderer to generate the Swagger/OpenAPI JSON spec and an another to render the UI. This gives the option of hosting the Swagger UI separately if desired.
Still to do:

[x] Update documentation & example
[x] Provide settings for auth types
[ ] Provide Swagger UI settings
[ ] Test coverage

Huge thumbs up from me! 👍 😎

Nice. Let me know if/when you need me to do anything on the REST framework docs side of things! :)