feat: add brief err to CertificateStore CRD

Description
What this PR does / why we need it:
Add truncated error message to CertificateStore Status to avoid displaying long error message when listing it.
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #843
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
[ ] This change requires a documentation update

How Has This Been Tested?
Status before:

Status after:

Details when describing it:

Checklist:

[ ] Does the affected code have corresponding tests?
[ ] Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have appropriate license header?

Post Merge Requirements

[ ] MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

General question: Is the goal to just truncate the error message? I'm wondering if this will make it more confusing?

General question: Is the goal to just truncate the error message? I'm wondering if this will make it more confusing?

I posted some screenshots before and after the pr. The target is to avoid displaying long message when listing resources. Truncating is just one possible solution. @fseldow and I also considered other options:

Display error code while listing resources and display detailed error when describing it. But it means we need to parse the dependency error and have a mapping from error code to each specific error. And we have to maintain the mapping when new errors are added in the future.
Probably we can just remove the ERROR column when listing it since there is anIsSuccess column which can indicate an error happened as well.

General question: Is the goal to just truncate the error message? I'm wondering if this will make it more confusing?

I posted some screenshots before and after the pr. The target is to avoid displaying long message when listing resources. Truncating is just one possible solution. @fseldow and I also considered other options:

Display error code while listing resources and display detailed error when describing it. But it means we need to parse the dependency error and have a mapping from error code to each specific error. And we have to maintain the mapping when new errors are added in the future.
Probably we can just remove the ERROR column when listing it since there is anIsSuccess column which can indicate an error happened as well.

Thanks for clarifying. I understand the goal now. Truncating makes sense to me since user can just run describe to get the full error details.

Thanks for making these diagnostics improvements. Really helps debuggability.


Stone-click Sounds

An audible "click" or "tap" sound should be played when a stone is placed on a visible goban, alerting the user to the occurrence of a move.

[x] Evaluate techniques for playing immediate audio effects

[x] Audio container support
[x] Audio codec support
[x] Cross-platform audio format fallbacks

[x] Render or acquire adequate audio clips

[x] Stone placed
[x] Pass played

[x] Develop audio service component with the following features:

[x] Pre-loading (buffering) in order to provide instantaneous playback
[x] Robust handling of multiple simultaneous play events

[x] Integrate audio cues on the game screen for the following events:

[x] Stone placed
[x] Pass played

Closed (5e511f12d7f056d3c3fcbb53e3041e308ad0ce74)


Rig Layers not show correctly in the generated UIs in Blender 4.0.3

The Rig->Layers box cannot show correctly in the generated UIs

I have solved this problem.
This problem is caused by the line 666 in character_ui.py:
ch.data, "layers", index=rig_layer['index'], toggle=True, text=rig_layer['name'])
However, there is no "layers" in ch.data in Blender 4.0.3. Instead, it's ch.data.collections.
So, it should be:
ch.data.collections[rig_layer['index']], "is_visible", toggle=True, text=rig_layer['name'])

It is solved as a result.

I tried the above fix which would be really nice and easy and it might  automatically port over the rig layers names. However on some of my models the rig layers weren't properly matched to the new collections created by blender when I opened it for the first time.
Instead I opted to replace the whole UI with the same one blender has and when generated it gets simplified into just a list of collections.


Version 0.5 Updates

I just pushed quite a few changes to GitHub for Version 0.5. I plan on pushing these changes to PyPI tomorrow afternoon unless there are any objections.
ttkbootstrap

changed theme file from json to py
remove dependency on external fonts
remove dependency on importlib_resources
remove default font (relies on os defaults)
updated all style colors
added highlight effects on dark theme Entry type widgets (this is now possible because of the darker inputbg color)
added 'morph' theme
changed the drawing of the radio and checkbutton to the same as the version 1.0 (except for no scaling)

ttkcreator

removed theme splash screen
added base theme combobox to select starting colors (have one more tweak on this to make)
added import an export buttons which import and export to the themes_custom.py file

Apart from the three issues I submitted PRs for, it looks ready to be pushed to PyPI!

@daniilS
Ok. Had to make a few more tweaks, lol. I'm regretting going down this path now... but too late. Oh well.
I changed the ttk creator to the version 1.0 style... and this gave me a much better look at the styles, which needed some more tweaks. I updated the selectbg color on the dark themes.. which makes a big difference. I also fixed the horizontal scrollbar arrows, which were wonky. And then a few other small things.
Here are the new theme colors... slightly modified.

And, here is the new ttk creator app... I actually used it to figure out the correct selectbg colors for the dark themes. very useful.

published https://pypi.org/project/ttkbootstrap/0.5.2/


Support for Terraform workspaces

Possibility to manage multiple environments using workspaces.

hello @gureya can you explain it a little bit more, what do you mean with workspaces?

Basically, I needed support for the terraform workspace command (https://developer.hashicorp.com/terraform/cli/workspaces) which I cannot find in the current implementation. The workspace command will enable me to manage multiple deployments of the same configuration.
For instance, before executing terraform plan/apply/destroy commands, I will like to select/create a particular workspace by executing a command like terraform workspace select NAME.
Is there any reason why you have not considered supporting the workspace command?

Hello @gureya now I understand what you are saying.
You could handle environments using different folders in your filesystem as an alterntive, from my side I wont spend  time adding this feature because it not something we need in terrakube.
In Terrakube we handle "workspaces" internally in our backend without using the "workspace command".
If someone would like to add this feature in the library I am open to review any pull request with the necessary changes
This is the class will that needs to be updated in order to support new commands.
https://github.com/AzBuilder/terraform-spring-boot/blob/master/terraform-client/src/main/java/org/terrakube/terraform/TerraformClient.java


Request: Support manifest locations other than git repos

Is your feature request related to a problem? Please describe.
Currently it is documented as a requirement to store the manifest file in a Git Repo, this assumes that one has private git repos available which may not always be the case but shared/cloud storages tend to be more ubiquitous in this regard. this also seems like a lot of overhead for a single file although the version history/tracking is a great feature as a result
Describe the solution you'd like
Please consider supporting alternative locations to source the manifest from, for example, a local file system path (which could be inside a Dropbox/OneDrive or NextCloud folder and synced to those cloud services or natively via services such as HTTPS/WebDAV (nextcloud) or direct API integrations(e.g. DropBox/OneDrive etc) - even a private GIST would work for many
This concept could reasonably be extended to also saving other app specific configuration in a consistent location for use accross devices, especially if the manifest well supports paths other than the current working directory e.g. ~/Repos/foo

Sorry, I don't really get the problem you are trying to solve here.

this assumes that one has private git repos

Well, tsrc makes no assumption about the public or private nature of the repositories. You just need to be able to clone both the manifest repos and the repos in the groups you are interested in.

This also seems like a lot of overhead for a single file although the version history/tracking is a great feature as a result

I disagree. I don't think it's a lot of overhead and I believe history and tracking for the manifest file are crucial features.
Moreover, lots of tsrc usage require a branch of the manifest as well, which would not work at all with any of the solutions you suggest.
Bear in mind, tsrc assumes you have groups of git repositories to manage, so having to one repo for the manifest makes sense in this regard.

This concept could reasonably be extended to also saving other app-specific configuration in a consistent location for use across devices, especially if the manifest well supports paths other than the current working directory e.g. ~/Repos/foo

This sounds like a separate feature request. The idea of having absolute paths in the manifest is under discussion here : #62 - but there are other tools better suited for saving app-specific configuration, like GNU Stow

Update : feel free to leave a comment if I misunderstood your request and we may re-open this issue.


A python code to submit jobs to SLURM

About:
This pull request adds the preliminary version of a Python code to submit jobs to HPC.
Changes

Added Messy Python class to submit jobs to a HPC system running SLURM.
Added use_messy, an example script showing how the Messy class can be used.
Added templates/netlogo_job.jinja, a jinja template which is rendered to create a script for the batch job.
Added docs/HPCDocker.md, a document describing the steps to manually achieve the same goal as Messy class.
Added requirements.txt for Messy class dependencies
Added .gitignore
Added test_folder to be used in examples.

Review instructions:
Requirements

Docker 25.0.2 or newer
Apptainer 1.2.5 or newer (https://apptainer.org/)
Python 3.11.X or newer
Bash shell

Instructions

Run a local SLURM service using a xenon docker image

docker pull xenonmiddleware/slurm:latest

Give it some time to start the services. If you need to ssh to the container the credentials are below.
username: xenon
password: javagat

Create a virtual environment and install the dependencies (run in Bash shell)

python3 -m venv venv
. ./venv/bin/activate
pip install --upgrade pip wheel
pip install -r requirements.txt

Test Messy class methods. You can find some examples in use_messy script.

Related issues:

#20
#23
#36

Thank you for reviewing @recap!
I created issues about the improvements you pointed to. Can you please review again and submit a review?

Thank you for the review @lyashevska. I updated the example. Can you have a look once again?

Thanks @fdiblen. All looks good.


[release-v0.43.x] Fix ci for 0.43

Changes
End of Life for 0.43 is 2023-04-22, until then we need to keep the CI working for it 💓

In PR https://github.com/tektoncd/pipeline/pull/6201, we identified a failure with our CI system. Beta integrations tests are failing in PR https://github.com/tektoncd/pipeline/pull/6201. Our CI system has been updated to run beta tests but the code base in release-v0.42.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.42.x branch for the tests to work.
Cherry picking the following PRs:

Add prow env for beta integration test https://github.com/tektoncd/pipeline/pull/5737
Beta Example Tests https://github.com/tektoncd/pipeline/pull/6031

This PR has these commits along with the changes after running ./hack/update-codegen.sh using Go 1.19.
Part of https://github.com/tektoncd/pipeline/issues/6220
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

The build is failing because of an update to gofmt in Go 1.19. Please run try to run go fmt ./... with Go >=1.19 and see if it resolves the failure. Thanks!

/retest

/retest

/retest
try again 🤔

Ah ci passes


TLSEXT_SIGALG_gostr34102012 0x0840 and 0x0841 support

For GOST2012-GOST8912-GOST8912 IANA introduce signature Signature Algorithm parametrs
https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-16

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

@t8m @beldmit fix commited

Dmitry, please re-approve.

Done.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

ping @beldmit @t8m

I don't understand why the label was not applied automatically.

As per the comment  from openssl-machine above "this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set." - you added a comment after "approval done".

This behavior seems a bit strange - no code changes/change requests... Thanks for the clarification!

Merged. Thanks!

This behavior seems a bit strange - no code changes/change requests... Thanks for the clarification!

The bot doesn't know the difference between an innocuous "Looks good to me" comment from an approval status relevant "This code is rubbish, I think this PR should be closed without merge". So it errs on the side of caution. Any update whatsoever results in the tag not being applied automatically - instead you just get the message above.


"incorret params values" when has default parameters on node.js function

I'm trying to execute this code:
function fn(n, sum = 0, prev = 1) {
    if (n <= 1) return sum;
    return fn(n - 1, prev + sum, sum);
}

But, when I'm execute him without the two last parameters, like fn(5), popout an error with the phrase: Incorrect params values.

It's fixed. Thanks!


hello i am facing problem while installing platform ide terminal in my package

[ ] I have reset Atom to defaults prior to submitting report.
[x] I have not reset Atom to defaults prior to submitting report.

Description

Steps to reproduce

Expected behavior:
Actual behavior:
Reproduces how often:
Versions

> atom --version

> apm --version

OS name and version:
Platformio-ide-terminal version:
Additional Information

its failing every time

This package is not maintained see https://github.com/platformio/platformio-atom-ide-terminal/issues/543#issuecomment-678979080

So what should I do

install a different terminal as mentioned in https://github.com/platformio/platformio-atom-ide-terminal/issues/543#issuecomment-678979080

but that terminal doesn't providing new terminal

which one?

Fixed in https://github.com/platformio/platformio-atom-ide-terminal/releases/tag/v2.10.1
Please update platformio-ide-terminal to the latest version.


Minimum cost for Tickets

Related Issue
https://leetcode.com/problems/minimum-cost-for-tickets/
Solved issue number: #420
Describe the changes you've made
Solution of problem in c++
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
C++
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

Problem name on platform is "Minimum Cost For Tickets". So, please make change to your folder name so that your folder doesn't get separate to others.

I did


Fixing build of Release/1_0 in VS 2017.

The Microsoft.R.Host.vcxproj is missing from the repo, but referenced in Microsoft.VisualStudio.R.Package.csproj.
And the dlls: zip.dll and zlib.dll are also just referenced, but nowhere to be found.
Both of these make the build in VS 2017 fail.

@mvacha,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@mvacha, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Oh, I see you haven't got a CI setup, so I'll test the build also in VS2015, run the tests and see if I didn't broke something.

The C++ project is required it is host process for R. It is in a separate repo per GPL requrement. It is listed as submodule. https://github.com/Microsoft/R-Host. zlib comes with it. Package references it (although you get a warning since it is native) so the host is built before the package.
We build in a lab that does everything from clean slate.

See the bit about submodules at https://github.com/Microsoft/RTVS/blob/master/CONTRIBUTING.md#getting-the-source-code


Replace Bitcoin by Dogecoin in CONTRIBUTING.md

Change CONTRIBUTING.md from rst format to md format.

Thanks!


add tile ratio warning when there is class imbalance

@drewbo, should we add class imbalance warning?
When I create a bounding box for an image classification task, a building classifier. I set the background_ratio to 1 and assumed Label Maker will create a balance classes ratio. But in this case, the bounding box only contained building tiles, and I ended up only have 9 tiles are the background tiles out of 340 tiles. If we can add the class imbalance warning that will help to evaluate the training dataset.

Good catch. I think there are two underlying pieces here to better handle this:

For classification problems, we are "correctly" handling background ratio because we try to get enough tiles to match the ratio but if there aren't enough, we can't make new background tiles. We also print out the number of each class. For the case above, should we only generate 9 foreground tiles because there aren't enough background tiles to match or is the class summary sufficient?
For object detection + segmentation problems, we aren't properly respecting the background ratio because I had assumed (somewhat erroneously and based on how we implemented skynet-data) that the background information from those tiles would be enough. In reality, it probably creates models which are likely to have false positive problems and needs to have some negative mining done. This needs to be fixed.


Preset

🐛 Bug Report
Documentations states:
A preset that is used as a base for Jest's configuration. A preset should point to an npm module that exports a jest-preset.json or jest-preset.js module at its top level.

See: https://facebook.github.io/jest/docs/en/configuration#preset-string
Then I would like to use an scope package as follow:
// jest.config.js

module.exports = {
  preset<EMAIL_ADDRESS>};

But I got this error:
● Validation Error:

  Preset @xxx/rdk.jest-preset-proactive not found.

  Configuration Documentation:
  https://facebook.github.io/jest/docs/configuration.html

As I understand the module resolution comes from: https://github.com/facebook/jest/blob/cb87c0a8536519a3ad2f89cfe357a0d2ae99d22c/packages/jest-config/src/normalize.js#L60
where it handles relative packages, but not node resolution.
Workaround:
module.exports = {
  preset: path.relative(__dirname, require.resolve('@xxx/rdk.jest-preset-proactive'))
};

Expected behavior
Try node resolution first, if it fails proceed with path normalisation.

@artola you don't need to name your module specifically.
The following will work:
├── jest.config.js
├── node_modules
│   └── @jungle
│       └── monkey.banana
│           └── jest-preset.js
└── package.json

npm module that exports a jest-preset.json or jest-preset.js module at its top level

Maybe we can change the description into:
"npm module that has jest-preset.json or jest-preset.js file at the root.
For example, foo-bar/jest-preset.js" would be configured as follows:
{
  "preset": "foo-bar"
}

We should definitely improve both the docs and the error message in this case

@SimenB In case we've found a module without jest-preset.js/jest-preset.json file, we can say:
● Validation Error:

Preset "my-jest-preset" should have "jest-preset.js" or "jest-preset.json" file at the root.

Module "my-jest-preset" instead of Preset and I'm down with that 🙂

@SimenB @ranyitz Sorry, may be I did not explain it well. I would like to read our package publised in the scope @xxx and named rdk.jest-preset-proactive which main entry points to some js or json file containing the configuration. Just by doing the following:
// jest.config.js

module.exports = {
  preset<EMAIL_ADDRESS>};

Today it is not possible because of the rdk. prefix the package name.
Jest can manage something as jest-preset-proactive or for scoped @xxx/jest-preset-proactive.
In the meantime we have a workaround:
// jest.config.js

module.exports = require('@xxx/rdk.jest-preset-proactive');

This is the reason why I would prefer Node resolution before trying any kind of config lookup.
For me makes more sense to extend the use possibilities than just fix the documentation with a constraint.

@artola If you suggest to start and look for index.js first, then it will be a breaking change. Looking at jest-preset.js/jest-preset.json file is a feature and not just a constraint. It enables already working packages to expose jest-preset while reusing the same package.
For example, look at react-native's case - https://github.com/facebook/react-native/blob/master/jest-preset.json

@ranyitz @SimenB Just a comment, similar situation happens for Babel presets, with same reasoning shown above ... and now it is already in master for Babel 7, for details: https://github.com/babel/babel/pull/8473
Very similar:

What this PR does is make it so that, if there is a scope and "babel-plugin" is anywhere in the package name (after the scope name anyway), we will skip inserting the prefix. See #8236 for an example usecase.

I find presets a great tool and we use them for everything (e.g. tslint, webpack, babel, neutrino and jest).
It would be great and very convenient to inline the tooling configurations (as much as doable).

We don't do anything with the package name, we just have expectations on the name of the file within that module

@SimenB @ranyitz Thanks a lot for your support. In short:

my preset package works fine if I have jest-preset.js and consumed as preset<EMAIL_ADDRESS>or it could have any name if consumed with a relative route preset<EMAIL_ADDRESS>
For my actual use case, I will use option 1.
Closing this issue. Thanks again guys.

@ranyitz I'd still love to se a PR for a better error and some clarifying docs :)

Please see this issue


[FLINK-18854][docs-zh] Translate the 'API Migration Guides' page of 'Application Development' into Chinese

What is the purpose of the change
Translate the 'API Migration Guides' page of 'Application Development' into Chinese
Brief change log
Translate the 'API Migration Guides' page of 'Application Development' into Chinese

The page url is: https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/migration.html
The markdown file is located in flink/docs/dev/migration.zh.md

Verifying this change
This change is a pure translation work.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi, @XBaith .
Could you help me to review this PR if you have free time?
Thank you.

Hi, @XBaith @klion26 .
Could you help me to review this PR if you have free time?
Thank you.

@klion26 @Thesharing
Thank you for your efforts.
I made some changes based on your suggestions.
Please take a look.

Mering...


Source code of the firmware

Could you also share the source code of the firmware?

You can use either C/C++ or Microsoft's PXT tool at https://pxt.microbit.org/
You'll find information on this topic at:
http://bluetooth-mdw.blogspot.co.uk/p/bbc-microbit.html
http://www.bittysoftware.com
and there's an example project in the micro:bit sample repo here:
https://github.com/lancaster-university/microbit-samples/tree/master/source/examples/bluetooth-services
Cheers
Martin

@bluetooth-mdw thanks for helping out!
@vshymanskyy I've attached the mbed exported code from the online version of mbed, it's based on the micro:bit template.
node-bbc-microbit_zip_nrf51_microbit.zip


On Flutter web preview the Icon widget i.e; Icon(Icons.home) isn't rendering properly
On Firefox and Chromium it looks like some kind of box.
Host OS: Arch Linux [5.0.10-arch1-1-ARCH #1 SMP PREEMPT Sat Apr 27 20:06:45 UTC 2019 x86_64 GNU/Linux]

It's already implemented here.
https://github.com/flutter/flutter_web/tree/master/examples/custom_fonts

They should come by default when you create a new web project, just like Flutter.

That's the migration guide https://github.com/flutter/flutter_web/blob/master/docs/migration_guide.md#webassetsfontmanifestjson-optional.
Closing as a duplicate of #32245

@BondarenkoStas that documentation is out of date. The only up to date web documentation is flutter.dev/web


[FEA] Appending host columnar data into ColumnBuilder by batch

During optimizing HostColumnVector.ColumnBuilder: https://github.com/rapidsai/cudf/pull/10025 , I realized that it is quite inefficient to append a large amount of data into the off-heap buffer by row. Meanwhile, we perform the append behavior for numerous times in HostColumnarToGpu, because we can not access the Spark ColumnVector in a columnar manner.
I proposed an alternative approach which may accelerate this process: cache the ColumnVector data with a Array buffer, and append the buffer into ColumnBuilder whenever the buffer is full.
For fixed-width types without null, it is relatively easy implement the batch appending:
  private def batchAppending[T: ClassTag](size: Int,
      batchSize: Int,
      @inline accessor: Int => T,
      @inline appender: Array[T] => Unit): Unit = {
    var i = 0
    var j = 0
    val buffer = Array.ofDim[T](batchSize min size)
    while (i < size) {
      buffer(j) = accessor(i)
      i += 1
      if (j == batchSize - 1) {
        appender(buffer)
        j = 0
      } else {
        j += 1
      }
    }
    if (j > 0) {
      appender(buffer.slice(0, j))
    }
  }

For nullable fixed-width types, we need to maintain a bit set as the valid buffer. For now,  the function batchAppendingWithNull works under the assumption that it can be called only once. Because we can not guarantee the input sizes are multiplies of 8. So, the subsequent appending may override the previous valid data. Perhaps we can address the problem via recording the last byte of each appending.
  private def batchAppendingWithNull[T: ClassTag](size: Int,
      batchSize: Int,
      @inline accessor: Int => T,
      @inline nullPredicate: Int => Boolean,
      @inline appender: (Array[T], Array[Byte]) => Unit): Unit = {
    require(batchSize % 8 == 0)
    var i = 0
    var j = 0
    val initial = 0xFF.toByte
    val bitMask = Array.tabulate(8)(i => ~(1 << i))
    val nullBuffer = Array.fill[Byte](batchSize >> 3)(initial)
    val buffer = Array.ofDim[T](batchSize)
    while (i < size) {
      if (nullPredicate(i)) {
        nullBuffer(j >> 3) = (nullBuffer(j >> 3) & bitMask(j & 7)).toByte
      } else {
        buffer(j) = accessor(i)
      }
      i += 1
      if (j == batchSize - 1) {
        appender(buffer, nullBuffer)
        j = 0
        nullBuffer.indices.foreach { i =>
          if (nullBuffer(i) != initial) {
            nullBuffer(i) = initial
          }
        }
      } else {
        j += 1
      }
    }
    if (j > 0) {
      appender(buffer.take(j), nullBuffer.take((j >> 3) + 1))
    }
  }

In cuDF side, we need to implement appendArray  and appendNullableArray methods:
    public ColumnBuilder appendArray(long[] values) {
      assert type.isBackedByLong();
      growFixedWidthBuffersAndRows(values.length);
      data.setLongs(currentIndex << bitShiftBySize, values, 0, values.length);
      currentIndex += values.length;
      return this;
    }

    public ColumnBuilder appendNullableArray(long[] values, byte[] validMask) {
      assert type.isBackedByLong();
      growFixedWidthBuffersAndRows(values.length);
      data.setLongs(currentIndex << bitShiftBySize, values, 0, values.length);
      growValidBuffer();
      valid.setBytes(currentIndex >> 3, validMask, 0, validMask.length);
      currentIndex += values.length;
      return this;
    }

Hi @revans2 @jlowe, I would like to hear your opinions on this idea. Thank you!

cache the ColumnVector data with a Array buffer, and append the buffer into ColumnBuilder whenever the buffer is full.

If this really is faster (do you have empirical evidence?), why not put this logic in ColumnBuilder directly?  ColumnBuilder could buffer rows as they are added, and when we get to some determined size (ideally a multiple of 8 rows to simplify validity handling), it adds those rows to the off-heap buffer in bulk.  When the caller finally calls .build() then it can push the last remaining data in the buffer.  With this approach we don't have to track down everyone using ColumnBuilder to speed them up.  It also nicely avoids the problem of the caller attempting to add a batch that isn't a multiple of 8, since ColumnBuilder controls when batches are pushed off-heap.
Then the discussion pivots to memory usage which is increased with this approach.  It would be good to plot a curve for performance vs. array size to see if there's a "sweet spot," ideally with a relatively low buffer size.
If we're willing to throw more memory at it, we could also avoid off-heap reallocations by tracking multiple array buffers and then when build() is called we know how big the off-heap buffer needs to be.  Downside is we are doubling the memory cost of building the column.  Maybe there's a hybrid approach where we buffer data up to some limit, hoping the caller calls build() before we are forced to push the memory off-heap.
Anyway, the first step is to get some hard numbers as to how this idea performs across a variety of types and buffer sizes, so we can make informed decisions.  First step is to prototype the easy case of fixed-width and see how it performs.

In Spark CPU the producer of the ColumnarBatch owns it and any memory backing it. There is no API to tell the producer that the data was not fully processed. The Parquet reader and others actually explicitly reuse the ColumnVector memory for each batch that they produce because it improves performance. So if we want to hold onto that data and call next again to get more data we would have to make a copy of the original input data. But we are already doing this when we write it into the off heap memory.

Hi @jlowe, I ran some benchmarks locally with the batch appending codes shown above. The result is frustrating: row-wise appending beated batch-wise appending of any batch size (16, 64, 256, 1024, 4096, 8192) on performance. The result incidates that batch size itself doesn't affect the performance. All batch appending attempts were significantly slower than  improved row appending.
I tested with non-nullable fixed-length columns. Each of them contains 1 billion rows.

The performance is going to be impacted by the number of columns much more than it is by the length of the columns. You also have to think about memory access patterns to guess at the performance, assuming that main memory is going to be the bottleneck.
When reading a single fixed width column the CPU will read an entire cache line of data around the part we are accessing. Because we are reading the data sequentially it means we can get all of the other reads on the same cache line essentially for free. Some CPUs can even see the read pattern and read data ahead. So depending on the CPU/etc we should be able to read in the data at close to memory speeds and write it back out at close to memory speeds.
When copying to an array first, even if the array fits in the cache, it is on the heap. Because of that we should be able to read the data at main memory speeds, like with the first one, but we are going to write it at least twice. Once to the array that will write through the cache to main memory, and then again to copy it to the final location.  If the array is large enough to not fit in the cache, then we are now reading and writing the data twice, so I would expect it to be twice as slow.
When we start to get into multiple columns, they will fight with each other over space in the cache. The more columns you have the more likely it is that one column will read data into the cache, but then it will be evicted by another column before the other parts of the same cache line can be used. This will effectively slow down the performance until each entry is read from main memory and written to main memory separately.
This is why in the copy code we try to copy a single column at a time.  Once we hit arrays the APIs don't let us get at the underlying columnar array data.  If they did we could copy it columnar to columnar at hopefully close to main memory speeds.

@revans2 Thank you for such a detailed elaboration.

@sperlingxx closing unless you have other thoughts.


Error "android.permission.access_network_state" simple solve

Installed normal the sample-Groceries, but when click in log in button get a error in

android.permission.access_network_state

.
So I add android.permission.access_network_state in AndroidManifest.xml and solve the problem.
Using emulator Nexus 5 with Android 6.

Hey @dekonunes,
Thanks for letting us know. This is a bit of an odd one; I’ll have to see if I can recreate this. Out of curiosity, which branch of this repo were you working on when you ran into this?

Master

Fixed in mastee: https://github.com/NativeScript/sample-Groceries/blob/master/app/App_Resources/Android/AndroidManifest.xml

For those who struggled with this like me, I had to add correct the AndroidManifest.xml accordingly, plus:
tns platform remove android

then
tns platform add android --bundle


Returning to 'workloads' via breadcrumb links removes all filters

Returning back via a breadcrumb should retain the same filters that were in place when the path was entered.

fixed in latest commit


Order reference weights

Small enough for chosen sensors

500g kit, since that's the maximum weight of planned testing


Initializing with declared lazy var causes error

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
07:40:43 .../workspace/.../CollectionViewController.swift:143:235:
    extra argument 'timestamp' in call
07:40:43 ...forStruct: MyStruct(startDate: startDate.addingTimeInterval(-4 * 30 * 24 * 3600),
    endDate: endDate.addingTimeInterval(4 * 30 * 24 * 3600), timestamp: nil))

The same scheme with the same target can be compiled in Xcode directly without any error.
Example
I've build a little example showing how MyStruct in the log above is implemented. In Xcode there is no upcoming error with the code we're using.
struct MyStruct {
    var startDate, endDate: Date
    lazy var timestamp = Date()
}

let anInstance = MyStruct(startDate: Date(), endDate: Date(), timestamp: Date())

Xcode suggests us to use the initializer with all three parameters.

But fastlane asks us for let anFastlaneInstance = MyStruct(startDate: Date(), endDate: Date()) but Xcode is throwing an error then, that timestamp is Missing.
Workaround
We've worked around this error/issue by changing the impekentation of our struct to something like this.
struct MyStruct {
    var startDate, endDate: Date
    var timestamp: Date

    init(startDate: Date, endDate: Date, timestamp: Date = Date()) {
        self.startDate = startDate
        self.endDate = endDate
        self.timestamp = timestamp
    }
}

Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.3

Ruby
2.2.4

Bundler?
false

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.12.3 (16D32)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Xcode Path
/Applications/Xcode_8.2.1.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.13.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

slack-notifier
1.5.1

i18n
0.7.0

json
1.8.1

thread_safe
0.3.5

tzinfo
1.2.2

minitest
5.4.3

activesupport
<IP_ADDRESS>

CFPropertyList
2.3.5

claide
1.0.1

colored
1.2

nanaimo
0.2.3

xcodeproj
1.4.2

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

plist
3.2.0

public_suffix
2.0.5

addressable
2.5.0

multipart-post
2.0.0

word_wrap
1.0.0

babosa
1.0.2

highline
1.7.8

commander
4.4.3

excon
0.54.0

faraday
0.11.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.0.1

gh_inspector
1.0.3

uber
0.0.15

representable
2.3.0

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

hurley
0.2

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

google-api-client
0.9.26

mini_magick
4.5.1

multi_xml
0.6.0

rubyzip
1.2.0

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.0

bundler
1.14.3

faraday_middleware
<IP_ADDRESS>

generated on: 2017-02-02

Added current environment

fastlane is just running xcodebuild under the hood. Have you tried taking the command line argument that is being sent to xcodebuild and calling it directly from the Terminal?

@lyndsey-ferguson yes we tried this, it is working by command-line, too.

Can you include the output from fastlane?

@lyndsey-ferguson I'm sorry but the snippet above is all i can publish from our log. Hoped it's enough to reproduce the error anywhere :(

Unfortunately, it is not enough as it just points out the error. If I were to investigate it, I would look at the output from fastlane to learn:

which action is being run, gym, xcodebuild
what are the environment variables
what is the exact xcodebuild command that is being executed from fastlane.
what other errors or warnings are being emitted --> that would provide some clues

Maybe the above is enough for you to figure it out without providing more info here. Like clues or things to think about.

I've installed xcode and fastlane fresh and clean again and it works now with my demo project, containing the code snippet above.

@DBocksteger awesome!! glad it works now, i am going to close the issue then, feel free to reopen or file a new issue whenever needed.


Add default spacing after button, hint and helplink

This PR does three things:

Adds default spacing after the Button, Hint and HelpLink components. We never want the next element to butt up against these, and we shouldn't have to set potentially-inconsistent inline styles every time we use them.
Adds a className property to Hint so the spacing can be overridden if required. The others already support className.
Improves the accessibility of the HelpLink component with an improved technique for announcing the status. Previously it used role="alert" which is meant for errors and warnings. Adding a timeout makes it less likely to be announced again as an assistive technology user moves down through the page.

@sussexrick Any reason the margin bottom for buttons is space-3 but for help link and hint is space-4?

@HarryAmmon It's a good question. The most tightly-spaced place I know of these in existing usage is asset breakdown, so I took the space-4 from current behaviour there. space-3 on the button was to have equal spacing around the button, because two buttons side-by-side have space-3. But space-4 would be a valid choice too...


Build Conan package in Travis CI

To solve the automatic Conan build for each new push, this PR brings a solution by Conan package tools.
All about Conan package tools could be found here
Travis will run build.py by Docker service. It script calls Conan, that export, build and test your package.  To upload your package after all tests, you must include some environment variables in your Travis settings.
CONAN_UPLOAD: Your Bintray Conan repository. e.g. https://api.bintray.com/conan/philsquared/conan
CONAN_PASSWORD: Your Bintray API Key

Why are they not included in travis.yml?
To provide the capability to anyone customize and upload it own package by project fork
Will this work without these environment variables?
Yes. The package will be created and tested in Travis job, but will not be uploaded to Bintray.
Will all packages be sent to the same channel?
No. Only tags (vX.X.X) will be pushed to stable channel. Otherwise, will be sent to ci not be uploaded.
 Conan project has documented about how to use Bintray here.
I would like to invite @memsharded to review and discuss about this PR.
Regards.

Related issue: https://github.com/philsquared/Catch/issues/926

Just adding @lasote to this discussion.

Hi!
I merged the master branch on this PR. Now this feature is able again to be merged without conflicts.
Could I help to finish this PR? The last point discussed was about create a Bintray account to push Catch as Conan package.
Regards.


#18896 Show all output severities

Acceptance criteria:

[x] All severities are available despite the value of the client_min_messages server setting
[x] All selected severities are shown in the log

Sample script can be found in the issue

verified


harden chmod of haproxy config file

it might be that the config file contains sensitive data (e.g.
https://cbonte.github.io/haproxy-dconv/1.5/configuration.html#4.2-stats auth )
and so it shouldn't be world readable.

this is resolved in #272


Settings : finish security settings section

Release version will have PIN, Touch ID settings for app entry and transaction send actions

zpl://project?pid=5b167c731d079e4122e946b7&seid=5b8fa6c89ac5420ef6557cbe

When switching touch id, request pin to set in case it was not done earlier.


how do I expand the vocabulary size of a pre trained embedding

Hi,
I have a pre-trained Keras model and there's a word embedding [1000 vocabulary *  200 dimensions] inside of the model.
Now I want to load it back to memory and continuous training it with new data. The vocabulary size increased because of the new data.
I am wondering if it's possible to replace this embedding with a bigger vocabulary size [2000 vocabulary * 200 dimensions] but keeping other parameter weights unchanged for the entire model.
Thank you

I believe the question is not specific to keras. You will definitely need to retrain your model(refer arxiv) but if word embedding for your new vocabulary are covered in some other model, you may borrow them and use them for supervised learning.

you can now do this. Keras nightly version has added a new util keras.utils.warmstart_embedding_matrix. Using this you can continuously train your model with changing vocabulary. https://www.tensorflow.org/api_docs/python/tf/keras/utils/warmstart_embedding_matrix


chore: bdd-spring-1568491134 to 0.0.1

chore: Promote bdd-spring-1568491134 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


rename helper methods a bit

@bors r+

:pushpin: Commit 94732aaf7bf79fd01a4a48d11155c6586b937514 has been approved by RalfJung

:hourglass: Testing commit 94732aaf7bf79fd01a4a48d11155c6586b937514 with merge 878bb4d78f547d13936feca1ac8f8f33b7744b11...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 878bb4d78f547d13936feca1ac8f8f33b7744b11 to master...


Call to sentry_trace_meta() breaks with Twig 3.4.0.

Environment
How do you use Sentry?
Sentry SaaS
Which SDK and version?
sentry/sentry-symfony 4.2.9
Steps to Reproduce

Setup a Symfony project using sentry/sentry-symfony 4.2+ and twig/twig 3.4.0.
Call the sentry_trace_meta() function in a Twig template.

Expected Result
Template should be rendered without error.
Actual Result
Symfony returns an exception: "Call to private method Sentry\SentryBundle\Twig\SentryExtension::getTraceMeta() from scope _TwigTemplate ..."

This seems very strange to me. We even have a dedicated test for that function: https://github.com/getsentry/sentry-symfony/blob/6177d71f2fd65f4f0f77036a1ca910aa9326767f/tests/Twig/SentryExtensionTest.php#L48-L51
Can you give us additional information?

Relates to https://github.com/twigphp/Twig/issues/3703


W2D5 - how long is the US?

In section 3 it says: "In this environment, we'll return to delivering a single reward of ten units".
However, it seems that the reward lasted only 1 time point.
Could that be clarified?

I assume this is for Tutorial 1?
In all of the environments, the rewards were only present on a single timestep. However, in the previous exercise, the environment delivered one of several different-sized rewards (depending on the values you entered).
Would something like this be better?

"As in Section 1, this environment only dispenses one size of reward. However, it will be delivered intermittently..."

“Units” is the magnitude, not the duration.

Ho thanks :)


Get rid of the scroll bars

Signed-off-by: Igor Pashev<EMAIL_ADDRESS>

This change is

Incomplete.


Allow first-name only searches

I understand why first-name only searches are resticted to a specific place but this generates huge extra work for me or prohibits wide searches. Two thoughts: 1. get more computer power. Nowadays that should be cheap as chips and remove the restriction. or 2. Consider providing a screen that shows a breakdown of hits by place. That way one could explore each place where there is a prospect of discovery - one place at a time.
First task: assess impact on performance of simply enabling a first-name-only search
E 2, U 3, S 2, C5?

Another comment - The fact you have to enter 4 sets of information when you dont provide a surname is frustrating as it makes it very difficult to search when you dont know exactly what you are looking for or are trying to broaden your search. A better model to adopt would be that used by the Canadian archives census records.

Communicate in 'Help' that 'Nearby Places' can be used with this.
Kirk to investigate if we can relax on 'First Name' at all, and look at https://www.bac-lac.gc.ca/eng/census/Pages/census.aspx model.

Do not understand what I am supposed to do with this. First name searches are permitted. But only for a specific census place

A forename search based on a census place that uses the nearby places option works and is an effective solution providing the name is not too common and a narrow date range applied

I am wondering if we should just try removing the need to include Place in a first-name only search - so retain need to enter census county. As if we take out the census county requirement too I think that many many queries would exceed the 500 max results limit that we have.


Uh oh...I broke PATRIC

I tried to do something new.  From Protein Family Sorter I selected FIGFams and then filtered on Imperfect families.  Then I tried to resize the table to see them all, and it killed every tab of PATRIC I had open.

This means your browser is crashed. Maybe you opened too many tabs or opened tabs for long time (possible memory leak). This does no harm on site.
Harry
On Apr 14, 2016, at 10:53 AM, ARWattam <notifications<EMAIL_ADDRESS>wrote:
I tried to do something new. From Protein Family Sorter I selected FIGFams and then filtered on Imperfect families. Then I tried to resize the table to see them all, and it killed every tab of PATRIC I had open.
[screen shot 2016-04-14 at 11 52 10 am]https://cloud.githubusercontent.com/assets/11475316/14534515/861e13d6-0237-11e6-900a-d7442ee44405.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/PATRIC3/patric3_website/issues/655


UI - Deploy VM with params from the template, iso, network pages

Description
This PR fixes https://github.com/apache/cloudstack/issues/5639

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-802)

I think the specific parameter should be passed to the url and be picked up by the form.

@rhtyd Will now pass the template id, network id on the URL, and will auto-select it on the form.

@blueorangutan ui

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-835)

@blueorangutan ui

@blueorangutan ui

@blueorangutan ui

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-967)

@blueorangutan ui

@blueorangutan ui

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_multiplication_x:
(SL-JID-992)

@blueorangutan ui

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5653 (SL-JID-996)

Verified deploy VM from template and network. LGTM.


Ci_fix_2

Breaking change

Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[ ] Local tests pass. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the [development checklist][dev-checklist]
[ ] The code compiles without warnings (code quality chek)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

Codecov Report

Merging #454 (098cd40) into remodel (49305b7) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           remodel     #454      +/-   ##
===========================================
- Coverage    55.65%   55.59%   -0.07%
===========================================
  Files           91       91
  Lines         4754     4754
  Branches       726      726
===========================================
- Hits          2646     2643       -3
- Misses        1882     1885       +3
  Partials       226      226

Flag
Coverage Δ

unittests
55.59% <ø> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

....App/Common/Reactive/ObservableExtensionMethods.cs
52.17% <0.00%> (-13.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49305b7...098cd40. Read the comment docs.


LibWeb:  element in inline element appears after text nodes

Reduction:
hi
Expected (Firefox):

Actual (Ladybird):

Looks like this is a layout issue, not HTML parsing, because the inspector shows the DOM in the correct order.

My guess is that it affects all block elements in inline elements, but
 was the reduction I found

You can add a secondary  tag to match the expected outcome and hide the unnecessary one.

Tha bug is with the browser not with the website

The rendering for
hi shown in the issue description seems to be what’s actually intended by the current code, not unintended:
https://github.com/LadybirdBrowser/ladybird/blob/73ca9516a92904b2d57719d65ee4da260ceca37f/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp#L164-L165
And that “Non-inlines can't be inserted into an inline parent, so find the nearest non-inline ancestor” comment seems to be stating a fact about a restriction in what the current code allows — in that, even if you change the code to try to insert a non-inline into an inline in the layout tree, it will not get rendered as expected.
For example, given the following patch:
diff --git a/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp b/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp
index bd5fa7d593d..60101cc052f 100644
--- a/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp
+++ b/Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp
@@ -162,21 +162,14 @@ void TreeBuilder::insert_node_into_inline_or_block_ancestor(Layout::Node& node,
             insertion_point.append_child(node);
         insertion_point.set_children_are_inline(true);
     } else {
-        // Non-inlines can't be inserted into an inline parent, so find the nearest non-inline ancestor.
-        auto& nearest_non_inline_ancestor = [&]() -> Layout::NodeWithStyle& {
+        auto& nearest_ancestor_without_display_contents = [&]() -> Layout::NodeWithStyle& {
             for (auto& ancestor : m_ancestor_stack.in_reverse()) {
-                if (ancestor->display().is_contents())
-                    continue;
-                if (!ancestor->display().is_inline_outside())
-                    return ancestor;
-                if (!ancestor->display().is_flow_inside())
-                    return ancestor;
-                if (ancestor->dom_node() && is<SVG::SVGForeignObjectElement>(*ancestor->dom_node()))
+                if (!ancestor->display().is_contents())
                     return ancestor;
             }
             VERIFY_NOT_REACHED();
         }();
-        auto& insertion_point = insertion_parent_for_block_node(nearest_non_inline_ancestor, node);
+        auto& insertion_point = insertion_parent_for_block_node(nearest_ancestor_without_display_contents, node);
         if (mode == AppendOrPrepend::Prepend)
             insertion_point.prepend_child(node);
         else

…then, if you dump the layout tree for that
hi document, I get this:
8363.008 WebContent(21993): Viewport <#document> at (0,0) content-size 1000x800 [0+0+0 1000 0+0+0] [0+0+0 800 0+0+0] children: not-inline
  BlockContainer  at (0,0) content-size 1000x16 [0+0+0 1000 0+0+0] [0+0+0 16 0+0+0] [BFC] children: not-inline
    BlockContainer  at (8,8) content-size 984x0 [8+0+0 984 0+0+8] [8+0+0 0 0+0+8] children: inline
      InlineNode
        BlockContainer
 (not painted) [0+0+0 0 0+0+0] [0+0+0 0 0+0+0] [BFC] children: not-inline
        TextNode <#text>
      TextNode <#text>

That is:

the hr element goes into the layout tree, but nothing gets painted for it
the hi text doesn’t seem to end up in the layout tree at all

Considering that other browsers can render it just fine, I believe this is a limitation that needs to be fixed, for web compatibility

Considering that other browsers can render it just fine, I believe this is a limitation that needs to be fixed, for web compatibility

Yeah I agree it needs to be fixed. I’d only intended my comment as a way of trying to help isolate the cause, and to help make clear that there doesn’t seem to be a simple fix.

Unfortunately. I may try to take a look at it when I'm up for it. Thanks for investigating it

Yeah I’m also continuing to investigate it. But I’ve not really done significant work on layout code before, and so far my time on this has gone mostly just getting a basic understanding of how the layout code works


Explorer sort order doesn't follow standard practice

I've noticed that the sort order in the Explorer view doesn't comply with the one in Windows Explorer and in output of the ll linux command. This makes me feel confused sometimes especially if there are a lot of files in a folder.
References:

https://github.com/microsoft/vscode/issues/9437
https://github.com/microsoft/vscode/issues/5066

Version: 1.38-insider (user setup)

@iliazlobin did you see #27759 ? If yours is a duplicate of it please close this one.


Add case-sensitive toggle for Find/Replace

Following work on #705, keeping Find and Replace consistent, it may be beneficial to allow the user to toggle this behaviour.
When this work begins, both find and replace will be case insensitive. One of the reasons for this is that there is support for 'diacritics' built in (important for other language use), which use library that hardcodes various glyphs/characters to our regular English alphabet. Trying to split this out into what should/would be lowercase or uppercase is subjective (e.g., pick which one of these you would deem as uppercase 'I' or lowercase 'i' or something else entirely: ḭƗɨɨ̆ᵻᶖİiIıɪ  )
While I don't think case sensitivity will solve the problem just listed, a user will at least be able to just distinguish between 'lowercase' and 'uppercase' in regular alphabet. Mucking around with what diacritics would or wouldn't be supported by such a toggle, say in a user preference, would be out of scope for this ticket.

Sounds reasonable for this support release @mattRedBox.
@markwheels suggest this is labelled support:Approved and prioritised above #902.

Thanks @mattRedBox  and @Stephen-Gates. I have marked this issue 'support:Approved'.

Confirmed working in 1.1 beta


Write a README.md for the api chart

Issue Type

Feature request

Current Behavior

There is no README.md to provide user information.
Expected Behavior

The chart should contain a README.md explaining how to deploy the chart and the available options to configure it.

GitMate.io thinks a possibly related issue is https://github.com/request-yo-racks/charts/issues/5 (Add a Makefile to each chart).


neutron2snabb: Added automatic database schema detection

neutron2snabb now scans the *.sql files produced by mysqldump to determine the order of columns in the database dump.
The original selftest.sh regression test case is reintroduced to confirm that the schema is understood correctly and the same configuration files are generated.
This depends on the neutron_sync_master to store the *.sql files, which is the subject of a separate change. If these files are not present then the old hard-coded default is used.

Merged onto nfv branch.


ng serve removes the dist folder, don't see why developing should remove my production build

OS?
Linux (arch)
Versions.
1.0.0-beta30
Repro steps.

ng build --prod
ng serve
ng serve has now removed my dist folder.

This was done on purpose.
See: #4293, #4366

Seems to me like documenting behaviour would have been a better approach to #4293 than deleting the folder. Looks to me like you're treating the symptoms rather than the disease with the current approach and this philosophy concerns me. There's also an element of "capitulating to ignorance" about the approach you took which also niggles at me ;)
In my instance I was building some server code into dist. Perhaps I should have built it into a folder under /dev/shm but the simplest quick solution seemed to be to put the code alongside the client output. angular-cli deleting my code was an inconvenience.


Introduce some real data for use in test coverage

Alternative to #875 . Which do we like better..?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (988266b) to head (444d5fc).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #911   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           97        99    +2
  Lines         4673      4687   +14
=========================================
+ Hits          4673      4687   +14

Files
Coverage Δ

policy/lib/tekton/recorded_test_data.rego
100.00% <100.00%> (ø)

policy/lib/tekton/recorded_test_data_test.rego
100.00% <100.00%> (ø)

This is perhaps a bit neater than #875. An interesting followup could be that we automate PR creation against hacks/recordings and here for actual production workload. Say for the golden container. We could add different kinds of Tekton Pipelies there, but also include attestations from different build systems (GitHub Actions, Jenkins...).
I like that this keeps it within Rego and doesn't require running additional infrastructure while it is still representable of real attestations. Makes for (a bit) quicker turnarounds.

There was a little more work needed to get the lint checker to pass.


Issue warning on static ports

Issue warning about static ports assigned in application port range

@tugup : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@tugup : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@tugup: I'm sorry - only the author of this article, @athinanthny, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


2 sample t-test for means comparison

t-test: https://en.wikipedia.org/wiki/Student's_t-test
How to contribute stat test for Drift Analysis: https://github.com/evidentlyai/evidently/wiki/Hacktoberfest

Hi @emeli-dral I am interested in working on this issue.

Hi @inderpreetsingh01, feel free to take it!
We will review contributions on first come basis.

Sure will raise pr soon

We recently added an example of setting stattests in TestSuites. We are happy to receive PRs to update it with new drift detection methods!


Add material design

Please feel free to ask for changes (if necessary) or stash this PR if it seems inappropriate.

Keep a hold on this PR, I have got a better solution to dark and light theme

What do you mean?

This PR did not have the ability to have Light and dark theme, as I had removed the links to existing stylesheets. Although I can override the color of the material designed cards, to take a dark color, It would be relatively better to use a material design function which can be invoked in the code, than maintaining two different stylesheets.


0.3.7: Browser Language Detection - Ignores English setting in Chrome

Bug Report
Description
Bug Summary:
After updating to 0.3.7 the UI is presented in the browser language ignoring the language option set in settings if the language chosen it English (US and GB).
Steps to Reproduce:
Update to 0.3.7 running on a machine with browser language different from the UI language settings.
Expected Behavior:
Expected the UI to be displayed with the language set in settings (Portuguese), in my case I want the UI to be presented in English (US) but even with the language setting to English the UI is always showed in Portuguese (My browser language setting).
Actual Behavior:
The UI is being presented in the browser language (Portuguese) whenever I choose English (US) or English (GB) in settings, it DOES change for any other language other then English.
Environment

Open WebUI Version: [0.3.7]

Ollama (if applicable): [0.1.47]

Operating System: [Windows 11/Docker Desktop]

Browser (if applicable): [Chrome 126.0.6478.127]

Reproduction Details
Confirmation:

[X] I have read and followed all the instructions provided in the README.md.
[X] I am on the latest version of both Open WebUI and Ollama.

Logs and Screenshots
Screenshots (if applicable):
[Attach any relevant screenshots to help illustrate the issue]

Installation Method
[Docker Desktop]
Additional Information
Cookies deleted in chrome, behaviour is the same, in Firefox it's working fine.

I can confirm this behaviour for
ubuntu / docker / webui 0.3.7 with Browserlanguage in German

Same happening to me, can't make it work in english

Should be fixed with the latest main, let me know if the issue persists!


How to payment by credit card like Uber app

How to integrate payment by Visa/Master card in Xamarin.Forms?

You would want a payment processor like PayPal or stripe


Request: Add save to file functionality to config

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
To use the SDK together with the continuation orb, you need a configuration file written to disk. This also stated in the README and getting started guide.
Saving the file to disk is something that I think a lot (if not most) of the users would find useful.
Describe the solution you'd like
Provide a way to save to disk with a method directly on the CircleCI configuration object.
The ideal solution would look like this:
const config = new CircleCI.Config();
// ... build configuration
try {
  await config.saveToDisk("fileName.yml");
} catch(e) {
  console.error("Failed to generate configuration", e);
  process.exit(1);
}

Under the hood, it just uses the fs module from Node.js to write the file to disk and wrapping the logic into a promise, making it easy to use.
Teachability, documentation, adoption, migration strategy
When the functionality is implemented, adjusting the getting started guide and the example should be sufficient.
What is the motivation / use case for changing the behavior?
Currently, it is required to copy & paste the logic block to all projects where dynamic pipelines are used, or otherwise an internal library is required.
To reduce this effort, it would be convenient to include this in the regular SDK.
Additional information
If the feature is something you folks from CircleCI see as useful and worth to include into the SDK, I would also happily create a PR :)

Hey folks,
While we could add the writing-to-file bit to the SDK, this would be a Node-exclusive feature, preventing us from using the SDK in the browser. The SDK is responsible for generating the config as a library but I think it may need to be on the user to decide what to do with that data, of course most users will in fact be writing to a file.

Heya @KyleTryon,
understand that making it only work for Node might be only half of a solution.
Might it be a thing to also add some logic like "if running in browser, use FileSystem API"? Just thinking this could also be a nice feature for e.g. the visual config editor.
Imho it would be a really valuable feature. But if you don't see any value in also adding it for the browser world, lets close this request :)
Cheers,
Timo

A solution has been prepared. Thanks for the tip @timo-reymann !
https://github.com/CircleCI-Public/circleci-config-sdk-ts/pull/157

Awesome, thank you @KyleTryon! 🚀


Adapted NB7 to work in Colab and simplified it

Hi Robert,
I just uploaded some small modifications to adapt NB7 to work in Colab and simplified it according to Stephanie Juneau requests. Could you please check?
Thanks!

Hi @DavidVargasMora thank you for the PR, merging.


There are ignored errors

https://github.com/hugocarreira/go-decent-copy/blob/9e3645d351b96972dd5fa7797573ec2dddf4a0db/decent_copy.go#L16
These errors should not be ignored.

PR merged!!


Czech character 'í' is malformed in the left menu

Character 'í' is exported as  '�' in left menu. On the page detail 'í' is exported correctly.

Couldn't reproduce this issue. Please provide an example collection and open a new issue.


Core Feature: status bar

A status bar is needed for Way Cooler. The design is still up in the air, and this will be updated when there is more information...

Maybe a lua API for managing events, like when a new window is added or whatever, and a default theme? I've done a ton of stuff with awesome in this space, including rendering my own vector icons using cairo from lua.
http://imgur.com/a/RGKm5

I believe that's the route we are going. We are leaning towards using Conrod and Lua together, with a Conrod layer exposing a nice widget construction library/framework that Lua can call into and dynamically construct and modify the bar.

Neat! I read a little about that in another issue.

I wrote systemstat + unixbar for dzen2/lemonbar/i3bar/swaybar… Actually a simple i3-compatible bar in way-cooler like in sway would be cool.
Also, you could use systemstat directly for getting system info in your bar. (Linux support is incomplete for now: loadavg/memory/battery works, cpu/mounts/networks aren't implemented.)

The bars are designed to be swappable, so an i3-compatible bar could definitely be something that can be developed (either by us or others). The sway one won't work, since he makes sway-specific IPC calls in his. It could be translated easily enough to Rust/the IPC Way-Cooler though.
We'll look into using systemstat when we start work on the bar, we are still probably a month out at least from starting to work on that.


Integrate Arrow to query / read

This issue addresses the section titled Research best practices when working with Arrow of #10088. As outlined below, Arrow was not a simple drop-in to the existing storage read path. Some exploratory attempts to integrate it to the existing code-generated cursors and arrays failed or raised significant performance concerns. Taking a step back to explore the spec, canonical C++ implementation and the existing Go code has proven fruitful in better understanding the right path. The first section details that research and also includes a high-level review of the TSM encoding and compaction process, to ensure the design was appropriate in order to move this area forward to columnar data structures. See Design / TODOs section below for the list of tasks to be completed.
A complimentary issue and set of TODOs will be prepared for the encoding and compaction work.
Overview
Query and compaction are independent processes that leverage a number of shared APIs to manage the reading, decoding, deletion (tombstones) and merging of TSM and cache (WAL) data. The two process diverge for specific use cases, that will be identified later. Assume these processes are performed per-shard.
For the sake of simplicity, examples will refer to the Float data type, however, any of the other supported data types (Integer, String, etc) could be substituted.
At a high level, the common APIs used by query and compaction are:

Block decoders, such as DecodeFloatBlock or the newer, columnar API, DecodeFloatArrayBlock

decoders return blocks of Time / Value data

Time / Value blocks are encapsulated as FloatValues or the newer, columnar FloatArray

FloatValues are used by the InfluxQL query engine and the compaction service
FloatArray is used by the storage/read service
both are represented as Go slices

FloatValues → []struct { time int64; value float64 }
FloatArray → struct { time []int64; value []float64 }

provide a number of APIs, used independently by the LSM Tree merge operations for query and compaction

TSMReader for accessing the mmapped TSM files

query and compaction use different APIs provided by TSMReader for reading and decoding blocks

The subsequent sections discuss the differences.
Query / Read
At a high level, the query process is encapsulated in a cursor. Concretely, a cursor is

an implementation of the LSM Tree merge operation
merges all TSM files and the cache (WAL)
produces merged blocks of time and value data
in ascending or descending time order
for a single series key + field key combination

Series keys are typically read in random order, as driven by the query engine.
To fulfill this requirement, a cursor is constructed with the series key to be read, any associated values from the cache1 and a KeyCursor. The KeyCursor is a lower-level construct that produces merged blocks from the TSM files for the shard.
Code generation (AKA "generics") is employed to produce concrete implementations for each supported value type and whether the data should be retrieved in ascending or descending time order. The InfluxQL query engine and storage/read services uses alternate implementations, which have significantly different performance characteristics. The focus will remain on the newer columnar implementations, which have been primed for moving to Arrow.
A query may span multiple shards and therefore the process will create cursors for each shard in order to aggregate or filter the data.
Arrow Challenges
As data flows between these layers, existing FloatArray blocks are mutated via the FloatArray.Include or FloatArray.Exclude APIs. In some cases, new arrays are allocated via the FloatArray.Merge API. These allocations occur in isolation due to no shared state or context, making the process of tracking resource usage impractical; a requirement for 2.0. This process and lack of shared context is particularly problematic for Arrow, which generally considers arrays immutable and requires access to a memory.Allocator for building new arrays. It is worth noting that immutability may facilitate caching in the future.
Compaction
The equivalent merge operation for compaction is implemented by the tsmKeyIterator. The tsmKeyIterator is

an implementation of the LSM Tree merge operation
merges a specific set of TSM files
in series-key order
producing merged blocks of time and value data
in ascending time order
for all series keys across the set of TSM files

A notable difference from the query process is data is read sequentially.
Arrow Challenges
Similar to the KeyCursor used by the query process, the tsmKeyIterator leverages the equivalent Include, Exclude and Merge APIs during the merge process, however, again the lack of shared state or context presents challenges for Arrow.
NOTE: The compaction service has not been updated to use the columnar decoders, which is out of scope for the goal of supporting columnar access patterns through the storage/read service. There is also additional work required to review and implement columnar encoders and refactor tsmKeyIterator and the Cache to use the new columnar data structures.
Summary
Given the differences between the query and compaction processes, it may not be possible or practical to unify the entire LSM Tree merge operations. It is necessary that FloatArray and related types be altered to utilize a shared context in order to provide an Arrow memory.Allocator and facilitate tracking metrics in the future.
Design / TODOs
Although context.Context was considered, it is not appropriate in this scenario, as the shared state is required. A new data type will be created as a container for the shared state and made available through a significant portion of the read process. At a minimum, it will provide access to an Arrow memory.Allocator and later extended to supply various metrics / counters and resource tracking.
Much of the existing code uses code-generation to produce type-specific cursors and arrays for each of the supported types, namely Integer, Float, Unsigned, String and Boolean. These are currently represented as simple Go slices, so the templated code to mutate and create new blocks is easily shared. Updating the fixed-width numeric types should present few challenges, as they map natively to the memory layout of the underlying architecture and Go slices. The packed types (String and Boolean) can no longer share this generic code and therefore will require the most changes. Additionally, whilst Arrow arrays don't require the validity vectors (used to track the positions of null values in an array) and nor does InfluxDB, the builders always create them. To avoid the overhead for manually building the fixed-width types, we'll simply create the arrays directly from the decoded blocks. We may also experiment with creating an additional set of builder types that do not create the validity vectors, if that permits more reuse in the templates.
Create execute state / context

[ ] create shared query context

must be an interface that provides memory.Allocator
future APIs to expose metrics
implementation lives in storage/read
perhaps tsdb can vend a memory.Allocator that is optimized for block sizes?

Update following to accept / use context

[ ] <type>ArraySumCursor
[ ] <type>ArrayCountCursor
[ ] <type>ArrayFilterCursor
[ ] CreateCursor API
[ ] KeyCursor
[ ] <type>ArrayAscendingCursor
[ ] <type>ArrayDescendingCursor

Update <Type>Array types
This collection of types represent the time / value blocks. They require some significant changes to be a container for Arrow builders and arrays vs the current implementation, which are simple Go slices.
Float, Unsigned, Integer are fixed-width, thus their in-memory representation matches a native slice, therefore they should be relatively easy to implement.
String and Boolean are densely packed in Arrow, so these are not a drop in replacement. Some experimentation will be required to determine best / most efficient approach for implementing Include, Exclude and Merge APIs. Downstream filter query cursors will also require changes, when mutating these blocks.
Update fixed-width <Type>Array types:

[ ] store shared context and create memory.Buffer (for data, nullability excluded)
[ ] alias memory.Buffer with native Go slices types
[ ] implement Include, Exclude
[ ] implement Merge

Update packed StringArray type:

[ ] store shared context and memory.Buffers
[ ] implement Include, Exclude
[ ] implement Merge

Update packed BooleanArray type:

[ ] store shared context and memory.Buffers
[ ] implement Include, Exclude
[ ] implement Merge

Update cursors to use Arrow arrays
KeyCursor

[ ] KeyCursor ascending merge
[ ] KeyCursor descending merge

Typed ascending / descending cursors
These implement the TSM + Cache LSM Tree merge operation
Update fixed-width cursor types:
Similarly to the <Type>Array, the fixed-width cursors (Integer, Float and Unsigned) should be relatively easy to update, due to the Arrow arrays layout in memory matching Go slices.

[ ] <type>ArrayAscendingCursor
[ ] <type>ArrayDescendingCursor

Update packed string cursor

[ ] stringArrayAscendingCursor
[ ] stringArrayDescendingCursor

Update packed boolean cursor

[ ] booleanArrayAscendingCursor
[ ] booleanArrayDescendingCursor

Update query cursors
These cursors are implemented in the storage/read package.
Update aggregate cursors
These cursors perform aggregations for the numeric cursor types (Integer, Float and Unsigned) and will be easy to update.

[ ] <type>ArraySumCursor
[ ] <type>ArrayCountCursor

Update filter cursors
This is another cursor that mutates incoming data, and will likely required differences between the fixed-width vs packed data types. By this point, I expect patterns to be established for efficiently mutating both formats.

[ ] fixed-width, numeric <type>ArrayFilterCursor
[ ] packed String and Boolean <type>ArrayFilterCursor

Switch query cursors to public API
Move these cursors to a public-facing API, so they can be reused directly in Cloud 2.0.

[ ] Switch query cursors to public-facing API

NOTE: Additional time should be scheduled increase the reusability of the OSS storage service APIs, to avoid the constant duplication of work between OSS and Cloud 2.0.

@stuartcarnie Looks like you have a clear picture of what needs to be done. My only question is regarding the OSS and Cloud 2.0 duplication. Does it make sense to try and unify those code paths before or after the Arrow work? My understanding is that there is currently divergence between the two code bases because of the batch decoding work. And the Arrow work is going to change things more than we expected. In that light it makes sense to get Arrow fully integrated in OSS and then once that code is stable, decide how to incorporate that code in the cloud 2.0 bits.  Does that make sense? Or are their significant requirements that 2.0 places on the code that we need to consider upfront?

@nathaniel, the divergence occurred from the outset, when the read RPC was added, to get things working quickly. I agree it is time to put some effort into sharing as much of the code as possible.
We can chat tomorrow to decide on scheduling. My gut says do that work now, so that InfluxDB updates don’t impede other work


License

@xykong there is currently no license specified for your code. I found the code useful, but without an explicit license, I'm technically not even allowed to run it.
I would suggest an MIT license.

Hi @rollcat, I'm very happy to know that this project can helps you.  I'll add a license for this.

Wonderful, thank you!


Feature/issue 12 enable to switch generate gogenerate or not

fixed #12

Pull Request Test Coverage Report for Build 44

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 42:
0.0%

Covered Lines:
205

Relevant Lines:
205

💛  - Coveralls


translate loader

ref: #105

Coverage remained the same at 87.72% when pulling 8e24e45b8cd8ffcfc294f755bbf743190967dddd on translate-doc/loader into ca8ca45af80b3843a1a12802bcc55a04c147f5df on develop.


Core form & html helper updates

Noticed that the placeholder attribute wasn't showing up. To make it accessible, I added the attribute to $valid_attributes_by_tag for textarea.
Added step attribute to valid_attributes_by_tag for number input field
Allowed for default values in text, textarea and select inputs
Allowed for hyperlink confirmation messages
Sanitize input name attribute values for form helper

Thanks for your contributions!

Thanks for your contributions!


feature: 资源限额接口权限控制 (close #536)

Codecov Report

:exclamation: No coverage uploaded for pull request base (V2.2.3-rc@9376432). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             V2.2.3-rc     #538   +/-   ##
============================================
  Coverage             ?   69.98%
============================================
  Files                ?      288
  Lines                ?    20859
  Branches             ?        0
============================================
  Hits                 ?    14599
  Misses               ?     6260
  Partials             ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9376432...8f41ca2. Read the comment docs.


Prevent negative value for currentPage

When given an empty list, the value of currentPage becomes -1.
Even when you then update the empty list with an item, the items still won't show up.
This pull request ensures there can never be a negative value for the currentPage and it will always have an minimum value of 0.
Fixes: #94

I found a hacky workaround that fixed it for my app.  First, I added a ref to my <paginate></paginate> component ref="paginator".  Then I created a computed property:
emptyArray () {
 return store.state.recipes.length == 0
}

then I created a watcher that looks for a change from length == 0 to length != 0:
watch: {
      emptyArray: function(newVal, oldVal) {
        if ( newVal === false && oldVal === true ) {
          setTimeout(() => {
            if (this.$refs.paginator) {
              this.$refs.paginator.goToPage(page)
            }
          }, 100)
        }
      }
    }

The timeout was necessary otherwise it thought there was no page 1.


SAK-13822 try to increment the folder name similar to resource id creation

Note that this does not force a unique display id. Folders now function the same as resources.

LGTM


Added execution-parameters to nginx.conf.template

/execution-parameters is an optional override for SageMaker Batch Transform
Docs: https://docs.aws.amazon.com/sagemaker/latest/dg/your-algorithms-batch-code.html#your-algorithms-batch-code-how-containe-serves-requests
Description of changes:
Updated nginx.conf.template to forward /execution-parameters to gunicorn workers.
If the worker does not implement execution-parameters, the previous response was:
HTTP/1.1 404 Not Found
Server: nginx/1.10.3 (Ubuntu)
Date: Tue, 25 Jun 2019 22:26:16 GMT
Content-Type: application/octet-stream
Content-Length: 2
Connection: keep-alive

{}

The current response is:
HTTP/1.1 404 NOT FOUND
Server: nginx/1.10.3 (Ubuntu)
Date: Tue, 25 Jun 2019 22:17:17 GMT
Content-Type: text/html
Content-Length: 232
Connection: keep-alive

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>404 Not Found</title>

Not Found

The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.

Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

[x] I have read the CONTRIBUTING doc
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Remove psyched_yaml

Closes #4825
See https://github.com/bundler/bundler/issues/4856

is that the only place we ever required the file? do we still need to require psych, or are we completely independent of it now for Bundler itself?

RubyGems will handle loading psych internally in these places

@homu r+

:pushpin: Commit 3371479 has been approved by indirect

:hourglass: Testing commit 3371479 with merge 1bea775...

:broken_heart: Test failed - status

Blocked on https://github.com/bundler/bundler/pull/4928

@homu retry

:hourglass: Testing commit 3371479 with merge 118897e...

:broken_heart: Test failed - status

@homu r+

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit 3371479 has been approved by segiddins

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@homu retry

:hourglass: Testing commit 3371479 with merge 7a093b9...

:broken_heart: Test failed - status

:bulb: This pull request was already approved, no need to approve it again.

:bulb: This pull request was already approved, no need to approve it again.

@homu r+

:pushpin: Commit 6b4c1d4 has been approved by segiddins

:hourglass: Testing commit 6b4c1d4 with merge 286e12f...

:broken_heart: Test failed - status

I can't seem to get that one failure to reproduce locally

Got it to reproduce, leading me to question how any other Ruby was passing at all. ¯\_(ツ)_/¯

I love the fix for Rails versions :joy:
@homu r+

:pushpin: Commit 7428308 has been approved by indirect

:zap: Test exempted - status


feat: use NODE_ENV and cds.env.features.kibana_formatter for format

Closes SAP/cloud-sdk-backlog#380.

cds.env.features.kibana_formatter has higher priority than NODE_ENV.

There are following cases:

If features.kibana undefined
NODE_ENV is production -> kibana.
Otherwise, local.
If features.kibana is defined
features.kibana is true -> kibana
features.kibana is false -> local

There are potentially some problems though and I need your thoughts on these:

If a user does not use cds and wants to use local in production, they can only set features.kibana in package.json as a work around. Could this case happen?
Also we need to import @sap/cds in cloud-sdk-logger.ts to align with the CAP configuration. Would it be too much or it is fine?
If we want to generalize the situation, maybe we can define a separate env variable for the logger as well, which has the highest priority?

We should not depend on CDS, I think this might not have been clear enough in the ticket.

[fixed] Thanks for the feedback. I removed the @sap/cds dependency and add some functions to let users set up the log format similar to the log level. I kept NODE_ENV to determine the default log format same as before.


Very strange exception

vue & vue-validator version
1.0.25, 2.1.3
Reproduction Link

The problem is heavily related to development environment, so I can't make a minimal reproduction sample.
Steps to reproduce

env: webpack-dev-server, vue-loader
plugins: vue-router, vue-validatior
problem:
There is a component called 'Edit', it's mapped to a certain route via vue-router.
Before introducing vue-validator all things worked fine. And then I put some validator code into it which causes the source code to throw an exception saying Uncaught TypeError: Cannot read property 'required' of undefined. I removed all validator code and added a small set of testing code like

<validator name="validation">
    <input v-validate:input="['required']">
</validator>

It still caused the exception.
And then, the VERY STRANGE thing happened:

First, I commented this testing code out, and webpack-dev-server reloads the page and the page rendered correctly.
Then I uncommented this testing code and webpack-dev-server made a HOT-UPDATE to apply the changes, it worked, the page got rendered correctly and validator worked fine ( I inspected the dom element and it's css class name changed according to my input).
Finally, I made a manual full reload, i.e. pressing Command + R(ctrl + R for windows) to reload the page, that exception comes back.
The code was totally untouched between step 2 and 3, but the result was different.

I added a exception break point , and that exception comes from resolveAsset function, which is called from BaseValidation.prototype._resolveValidator.
The incoming arguments of resolveAsset function looks like:

options: Edit components options
type: string with value "validators"
id: string with value "requried"

function resolveAsset(options, type, id, warnMissing) {
    // ... some code
    var assets = options[type] // assets = undefined here, because options don't have a property named validators, I think this is the point
    var res = assets[id] // throws exception because assets = undefined

}

It's very strange because hot-updating doesn't cause this exception but full reload does. I don't know if the details above are enough to figure out what's going wrong.

I found a similar issue #188
I've tried to import and install validator before router, but it's still not working

related #130

Solved issue 130


Compile errors in iOS 13.4

Hi, I'm getting compile errors using Xcode Version 11.4 (11E146), on iOS 13.4. The error is:
/ExpyTableView/BasicExampleViewController.swift:30:1: Non-'@objc' method 'tableView(_:canExpandSection:)' does not satisfy requirement of '@objc' protocol 'ExpyTableViewDataSource'
Please advise. Many thanks

on it

Wonderful , Thank you
Sent from my iPhone

On Apr 13, 2020, at 7:45 PM, Okhan Okbay<EMAIL_ADDRESS>wrote:

on it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

thanks for reporting, fixed


This code has a problem with routers that have tow cfcards while saving file in commit object

In routers that have 2 cfcards, saving files need to save in slave cards also. So when I want to use the device.commit_config() API, because it trying to save a file into cfcard the router ask an extra question to save the file to slave cfcard:
<BRKSAB_KS0006>save config_20221004_1026.cfg
Warning: Are you sure to save the configuration to cfcard:/config_20221004_1026.cfg? [Y/N]:
By the “y” command that will be sent to the node using “_save_config(self)” function the node goes to the next step, so the situation will be like below:
Warning: cfcard:/config_20221004_1026.cfg exists,overwrite? [Y/N]:y
Now saving the current configuration to the slot 11 .
Info: Save the configuration successfully.
Warning: Are you sure to save the configuration to slave#cfcard:/config_20221004_1026.cfg? [Y/N]:
But in the last line, the node asks to save the file into slave cfcard, but the code doesn’t have an answer for this question. So that it senses an error. In continue we can see the _save_config(self) code:
def _save_config(self, filename=''):
"""Save the current running config to the given file."""
command = 'save {}'.format(filename)
save_log = self.device.send_command(command, max_loops=10, expect_string=r'Y/N')
# Search pattern will not be detected when set a new hostname, so don't use auto_find_prompt=False
save_log += self.device.send_command('y', expect_string=r'<.+>')
search_result = re.search("successfully", save_log, re.M)
if search_result is None:
msg = "Failed to save config. Command output:{}".format(save_log)
raise CommandErrorException(msg)
I have been trying to add change the function code to like below, but it doesn’t work while it seems true:
def _save_config(self, filename=''):
"""Save the current running config to the given file."""
command = 'save {}'.format(filename)
save_log = self.device.send_command(command, max_loops=10, expect_string=r'Y/N')
# Search pattern will not be detected when set a new hostname, so don't use auto_find_prompt=False
save_log += self.device.send_command('y', expect_string=r'Info:')
savecfcard = re.search(“save the configuration to slave#cfcard” , )
if savecfcard == True:
save_log += self.device.send_command('y', expect_string=r'<.+>')
search_result = re.search("successfully", save_log, re.M)
if search_result is None:
msg = "Failed to save config. Command output:{}".format(save_log)
raise CommandErrorException(msg)
Would you help me please to solve this problem?

Hi @arashxmohammadi,

Can you share more information about tis Huawei device? Model, VRP version.
Can you share a full interaction(sessiong logging) with these double confirmation?