As a developer I want to be able to start an Fn Server on a port other than 8080 using "fn start" so that I don't have to resort to using "docker run"

This is a simple proposal of just adding a --port -p option to fn start, e.g.
fn start --port 8081
This (or lack of) came up several times during the recent Fn Scandinavia Roadshow - there are typically a couple of reasons that users may want to do this:

They already have existing services/processes running on port 8080.
They want to launch a second Fn Server process on the same box.

We could take this opportunity to add a symmetric fn stop [--port] as well, which would allow users to choose which server to stop when they have started more than one. The CLI Command Structure proposal (#216) includes such an extension if not done here.

Is it sufficient to have fn start --port or would it be better to have something like fn start --bind which could accept fn start --bind 8081 or fn start --bind <IP_ADDRESS>:8081
The latter would allow binding the fn server to a specific interface/IP
Both are equally simple to implement really.


Split calendar and event editor

Hi,
This is more of a "discussion" ticket than an actual issue/feature request. I'd actually even like to work on this myself if I know this'll be accepted as a PR.
Currently khal is two things:

A calendar/agenda.
An events editor (or a vcf editor, if you will).

I'm interested in spliting these things in two different binaries (keeping them them same for now, UI-wise, and likely reusing all existing code), and have calendar.bin invoke the event-editor.bin when the user wants to edit/create an event.
From the end-user PoV, this would be almost the same, with one main difference which is what I'm aiming at: which calendar editor program to use should be configurable. My long-term interest is to write a different one (though vim would be an acceptable alternative, for example), and configure khal to use that, so when the user edits an event, that program can be called instead.
This more closely follows the unix-philosophy of "do one thing and do it well" (kinda like a file browser vs file editor if you will), but also makes room for various external vcf-editors.
Mostly my aim with this issue here is to ask:

Would these changes would be accepted (in the form of a PR, most likely)?
Do you have any feedback regarding this propositon?

Thanks.

Huh, looks like this would also cover #31.

I think that's a great idea, however, I'm not sure how to implement the calendar selector that's currently part of the editor.

I forgot about that, and now I recall that I had that same though last night before I fell asleep, hah.
Probably an intermediate step when creating the event, with the following flows:
For creations:

Open ikhal.
Select a date.
Press n.
A calendar selection menu appears.
The event-editor is summoned.

For editing events, simply set a new hotkey for calendar selection (c?). It would show the same screen as the one shown when selecting a calendar for a new event.
This would actually alter the flow of event creation/modification, contrary to the my inital statement.
I'd leave the calendar selection out of the event-editor, since it should only be concerned with editing a vcf file, and calendar selection is more about where to save that file instead.

I'm all for that "do one thing only, but do it well". But when creating or more importantly when editing an event I'd really like to see other events scheduled for that day(s). ikhal doesn't do that well at the moment either, but I think it will be more difficult with creating two different tools.
As a compromise I would like to suggest the following:

make using an external editor optional (configurable via the config file)
if anyone wants to use the current editor for something else we can extract it rather easily

I'll close this in favor of #31


Reconsider exception-handlers

Currently, Javalin will only run the closest matching exception handler. From the docs:
app.exception(NullPointerException.class, (e, ctx) -> {
    // handle nullpointers here
});

app.exception(Exception.class, (e, ctx) -> {
    // handle general exceptions here
    // will not trigger if more specific exception-mapper found
});

This could be a bit annoying to deal with, especially when developing plugins (as pointed out by @jkschneider in https://github.com/tipsy/javalin/pull/959)
Should multiple exception handlers be allowed to run per exception?
Should we have something like next()/done() ?
This would be a breaking change, but I guess we could also make it configurable.

One thing to add here... the default exception handler yields an HTTP 200. How should exception handlers be ordered such that different handlers affecting ctx in different ways yield predictable behavior?

For the projects we've done we've always handled multiple expected exceptions that parse the exception into a specific response and status, and one that is a fall back in case no better exception would be handled (which turns into a 500, sorry something went wrong).
It seems reasonable to think most of these handlers would be handled separately, I would have been very surprised if multiple handlers were called when a specific exception (like Unauthorized) was called. Especially if some of those were expensive. The way I've been looking at the exception handlers are: An exception ocurred, decide what response should be sent to the client. It doesn't really make sense to ask multiple functions what response should be provided, but maybe I'm thinking about them differently than others do?
Maybe it would be easier to have a separate function for registering handlers that should run on all exceptions? Something like app.notifyOnException(Exception.class, (e, ctx) ->{})?

Something like app.notifyOnException(Exception.class, (e, ctx) ->{})

This seems very reasonable!

I like the idea of adding a separate method, but it would be nice if it was named something like exceptionXyz to group it with the exception method. Any ideas?

exceptionListener? Looking to other frameworks, I think onException, doOnException, etc. are popular choices as well.

I'm not sure how best to make it clear to a user that one will be called all the time, and the other will only be called if something more specific is not called.
I do like listener. I also think that ideally things bound with the current exception() should probably be called after anything bound with this new method?
Do after filters run after the exception handlers? I assume they do. Since the goal of this new functionality is primarily for metric tracking/some other thing you want to do on every exception that's not necessarily handling the response, would it maybe be simpler/more obvious intent to just add a flag on context that signals an error occurred (and possibly holds the original exception?) that Javalin sets (internal setter) before handing to the exception handlers?
This seems like it would then allow @jkschneider to do what he was hoping to do by adding an after filter and checking for the existence of an exception without adding a second function whose purpose/intent may be somewhat confusing with the existing function.

I also think that ideally things bound with the current exception() should probably be called after anything bound with this new method?

There are probably cases to suggest this should work both ways. From my perspective as a metrics instrumentation library author, I would prefer listeners to be called after anything that currently implements exception(..). Specifically, this is because my listener would be completing a timing operation on a REST endpoint, and I want to be able to tag this telemetry with the HTTP status code, which can be influenced by a traditional exception handler.

That makes sense, I was thinking I'd like things using exception() to have the final say in the output as having multiple listeners be handed the context and allowed to change things could make things difficult to track down, but I suppose people can choose to use it how they like and it does make sense to have a listener that's implemented largely for metric tracking/events to happen last.
That does make it sound even more like an after handler though.

I'll make a new issue for adding an event listener for exceptions.


CNF-11188: Support add/remove managedcluster annotations in pre/post actions

The value of label is unnecessary when deleting cluster labels, so deprecate the field deleteClusterLabels in actions.beforeEnable and actions.AfterCompletion. Instead, use removeClusterLabels, which is a list of strings
addClusterAnnotations and removeClusterAnnotations fields are added in actions.beforeEnable and actions.AfterCompletion to support add/remove cluster annotations in pre/post actions

/cc @jc-rh @sudomakeinstall2

/test integration

/retest

/retest

/retest

/test integration

/approve

/lgtm


Logo Path Broken (#2)

Similar (but with a different root cause) to this issue from 2022:

https://github.com/brightway-lca/brightway-documentation/issues/59

the logo is rendered correctly on readthedocs, but not in the local build. How that is possible, I don't know - they use the same environment.yml (with pinned versions of the theme and Sphinx).
The local build:
WARNING: Path to dark image logo does not exist: logo/BW_all_white_transparent_landscape.svg
build succeeded, 239 warnings.
[W 230626 21:18:29 web:2344] 404 GET /_static/BW_all_black_transparent_landscape.svg (<IP_ADDRESS>) 0.43ms

The current workaround is to place a copy of the logo files into the _static directory, not in a subdirectory like _static/logo. As soon as this has been fixed by the pydata-sphinx-theme team:

[ ] https://github.com/pydata/pydata-sphinx-theme/issues/1385

we can remove the copies.

can't reproduce when building with:
sphinx-autobuild source _build/html -a -j auto --open-browser

or with
sphinx-build source _build/html -b singlehtml -a

either
Are you removing the _build folder after a couple of builts?

...could have been resolved with my upgrade of Sphinx:

https://github.com/brightway-lca/brightway-documentation/issues/92

I'll check again.

If you start with:

A clean (or missing) _build folder
Without the logos which I copied to the top level of the _static folder (eg./brightway-documentation/source/_static/BW_all_black_transparent_landscape.svg) as a temporary workaround:

The current workaround is to place a copy of the logo files into the _static directory, not in a subdirectory like _static/logo. As soon as this has been fixed by the pydata-sphinx-theme team:

then the issue persists.

Did a fresh git clone and build following the instructions and the logo appears.

Neither of the underlying issues https://github.com/pydata/pydata-sphinx-theme/issues/1385 and https://github.com/pydata/pydata-sphinx-theme/issues/1328 were fixed in the latest release of the pydata-sphinx-theme. The current workaround remains to retain a copy of all files in source/_static/logo also in source/_static. Since I implemented this workaround, you are seeing the logo (as you reported).


Dots on the map

Version: 3.1.6
Sorry, I'm not sure what I'm doing wrong but I'm always getting these dots on the map:

Have you ever seen this before? Something with loading geojson?

Sorry - figured this out - was the legend option


Change BPM does not process entire file

When using the quantize option with a slower bpm, the result files seem to drop audio towards the end of the file.
Steps to reproduce (from empty DB):

python polymath.py -a I32Dwc242Cs (adds a 1-minute beat from YouTube for testing)
python polymath.py -q all -t 50 (attempts to change bpm from ~105 to 50)

Expected result:
Output files in 'processed' should be ~2x the length of the original, because bpm is ~half the original.
Actual result:
Output files in 'processed' are exact same length as the source file. Beat quantization seems to die out near the end of the original file.

I have a fix for this already and will PR directly.
Thank you for this awesome tool!


Fixed console functions prototype

Coverage remained the same at 98.664% when pulling aca6b0bd115f29c1081af66f458eb900641821ce on disable-console-output-proto into 4f28bee90f70fff3cca4779cc5db3519f6dc49b9 on master.


Installing issue with docker compose

Hi, I'm so appreciated about your great work with this powerful tool
However, when installing with docker compose, I found that some css or js files are missing, so that I could not build the application properly. It's possible that there might be some lines in our .gitignore file that are causing this problem. Can you help check that?
Thank you for your contribution and hard work.

+1

Hi, Ideally the static files should be generated via the Django's collectstatic command, which I have included in the docker-entrypoint-celery.sh file. If this is not working, it might be worth inspecting the docker volumes mentioned in the compose file.
I might need more info on the exact steps you performed and the exact issues you faced. Apologies for the late reply and thank you for exploring LLMine.


missing keys from checkpoint

Nice solution.!
I encountered this problem after runing python ensemble-align-face2-frame-all-rob-policy-flip.py
Loading pretrained model from ./face_detect_ckpt/mobilenet0.25_Final.pthusing cuda! remove prefix 'module.' Missing keys:0 Unused checkpoint keys:0 Used keys:300 => loading checkpoint './submit_models/sf_bc_jc_44000.pth.tar'caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.0.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res4.0.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.1.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.1.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.4.bn2.num_batches_trackedcaution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res4.2.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.0.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res2.0.downsample_bn.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.0.downsample_bn.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res3.5.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.4.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res4.2.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res2.3.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.3.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res1.0.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.3.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.1.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res1.1.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res3.1.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res3.3.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.3.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res1.0.downsample_bn.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.3.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res1.1.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res3.4.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res1.2.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res4.2.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res1.0.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res4.0.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res3.1.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res2.3.bn1.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res3.0.downsample_bn.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.0.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: fast_res4.0.bn2.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.2.bn2.num_batches_trackedcaution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res3.5.bn3.num_batches_tracked caution: missing keys from checkpoint ./submit_models/sf_bc_jc_44000.pth.tar: slow_res2.0.bn3.num_batches_tracked ......
The models(MD5) that I downloaded from googledrive:
5c279b02a7173cf85cc5e56f4792bade  submit_models/b0_rgb_58000.pth.tar
11f2f7a4382247d237fa904b0bea1ecb  submit_models/b1_rgb_58000.pth.tar
0d9020578acccae9061e64f555488dfd  submit_models/b1_rgb_alldata_58000.pth.tar
744d5847ac1ce3f09212eea4acbfe86b  submit_models/b1_rgb_long_alldata_66000.pth.tar
95dba382236a90278cd54e38863e34ed  submit_models/b3_rgb_50000.pth.tar
f014afdbcbbef1fad76a23c5c10b4f84  submit_models/res34_rgb_23000.pth.tar
d251ed772502bb6b531daa55bf60d948  submit_models/sf_16x8_bc_jc_44000.pth.tar
27310503946a37530cea469f01a1085c  submit_models/sf_32000.pth.tar
e3afdd5fbd377afdd906dac8b5c542d1  submit_models/sf_bc_jc_44000.pth.tar
c67cd9dcd0834e50d5ae34e6ec1554a8  submit_models/sf_trainval_52000.pth.tar
a33b53336a28670ce4efbf2726a56194  submit_models/xcep_bgr_58000.pth.tar

Are this files intact?
I'm using the same version of pytorch as in requirement.txt, any idea to solve this problem？

This seems to be just a warning, not sure if it will affect the results.


Add ability to rename proof steps

Doubling clicking on the proof step will open a dialog prompting a new name for the proof step.
A separate display name attribute was added to the Rewrite class rather than modifying the "rule" attribute since "rule" is used when converting a proof to a tikz diagram.
This change is backwards compatible since old versions of zxlive with new proof files will ignore the display_name attribute and behave as usual, and new versions of zxlive given an old proof file will set the display_name to be the name of the rule if it is not present
Fixes #189.

Hi Will, can you make renaming rewrite part of the undo-stack? Currently, undoing does not undo the rename. For this, you would need to make renaming a command, which stores the information about the old rewrite. You can find examples of these undo-commands in command.py

Here's an example of how to create it:
https://github.com/Quantomatic/zxlive/blob/fcb1a967d839e14e6f42fd6f3dcde1dfc1e2d818/zxlive/commands.py#L177-L194
and how to call it:
https://github.com/Quantomatic/zxlive/blob/fcb1a967d839e14e6f42fd6f3dcde1dfc1e2d818/zxlive/editor_base_panel.py#L142-L146

@RazinShaikh I have added it to the undo stack however upon pressing "undo", it doesn't immediately rerender the proof panel which is not a great user experience.
How can I make it rerender the view after the model has been changed? I was looking for a method to call to trigger a rerender, or perhaps I could trigger the undo command via a signal to the ProofModel which I assume will make the proof view rerender.

@RazinShaikh Fixed the rerendering issue by adding a line to tell the ProofModel which item changed when undoing/redoing https://github.com/Quantomatic/zxlive/pull/206/files#diff-4b24277ddae20b11b98be0dae85205e9f45f931a087edf120fb8203cf59c1555R136

It makes sense that you can just ask the whole panel to render again :)


Project Brief

Task Completed

I made the final editing of the Project brief

I made contributions to the devel;opment of the project brief
https://docs.google.com/document/d/1ILQlJaEYJl_TzAo_qQo0UYhnnwK8guqEbeEY6o2pKzs/edit?usp=sharing

I did the first and second drafting of the project brief with the use of the research done by my teammate and with a little research also done by me.


Document R limitations that prevent Seurat conversions

Context
See single-cell-four.
@jahilton has noted that the Seurat encoding states:

All data submitted to the cellxgene Data Portal is automatically converted to a Seurat V4 object that can be loaded by the R package Seurat.

but there are cases where conversion must be skipped due to limitations in R. See the epic Manual Seurat conversions are no longer necessary and its child issues for details.
Curators are warned during validation:

This dataset cannot be converted to the .rds (Seurat v3) format. fill-in-the-blank nonzero elements in fill-in-the-blank-matrix-name exceed the limitations in the R dgCMatrix sparse matrix class<PHONE_NUMBER> nonzero elements).

This limitation must also be documented in the Discover API to explain why a RDS artifact may be unavailable for consumers to download.

See also #4464.

Closing. This is not a priority.


Question: how did you generate the pure urdf file

Hi,
I apologize for asking a question here. But I was trying to generate a "pure" urdf file recently (to use openrave ikfast) but all I can find online is how to convert the macro file to urdf and this always gives me issues.
I would appreciate a lot if you could share some suggestions or point me to the right direction. Thank you.

Hi Kevin,
Thanks for reaching me. I noticed that you have opened another issue, where you said
I can find the ur5e.urdf.xacro and robotiq_140.urdf.xacro from the github. However, I just have a hard time putting them together as a single urdf file as what you have here. (The generated IKfast does not converge with my urdf file).

It's true that the urdf files are converted from xacro files. I don't know the details, because one of my friends helped me to convert. The whole progress requires ROS. This link seems to be promising. https://answers.ros.org/question/310297/arm-does-not-appear-when-using-xacro-to-attach-ur5-to-robotiq-gripper/?answer=310318#post-id-310318
If you don't mind, maybe you can paste the urdf file here and I can help check it.
Bests,
T.T. Tang


Adding Goodwe Solar power stats to default repositories

Hi, One of the users of a component I put on Github asked me to add this component to HACS.
I hope this change is correct.

It is :)
Thanks! :)

Correction, it was added as a plugin and not an integration, but I'll correct that in the next branch

Oops. Thanks!


Deprecation warning

warning: HashDict.size/1 is deprecated, use maps and the Map module instead
lib/poison/encoder.ex:283
Elixir: 1.4.5, Phoenix v1.2.4

Thanks for opening this issue!
Which version of poison were you using?

Fixed in v4.0.0.


Streaming from youtube...

An option to stream youtube urls instead of downloading would be nice. Should be possible because YT uses dash with seperate files for video/audio.

Add ability with https://github.com/dafoxia/mumble-ruby-pluginbot/commit/d29e026364e4d7895b2178d1f9becd5b85b082e5
But it is not a real stream because mpd download file complete before start playing. There is no gapless play possible.
To enable streaming set to
@settings[:youtube_stream]= "yes" or some other value.
nil disables streaming and download titles. (standard behavior)

Currently planned no further development of this function.


Degraded status during updates

We need another state here, e.g. "upgrading" rather than "degraded"

@emosbaugh should this PR still be open?

I'm not sure. It's been a while since i submitted that PR and I'm pretty far removed from the day-to-day of the kots project. Is it still an open issue?

Showing "degraded" status during updates isn't the right approach. We'd need to introduce a new app status that is more appropriate to what is actually happening (vs unavailable, degraded, ready). This PR is very old at this point, and not the right approach without more work. We should close this and have a fresh PR when the problem statement is properly tackled.


Windows "useAgent" pageant support

Defaults windows connections using the useAgent option to pageant (A windows SSH key agent) when no process.env['SSH_AUTH_SOCK'] is available. Also allows the useAgent option to be passed in if it's a string.
There is a windows env check so that when creating a config you only need to click "useAgent" instead of manually editing the file to add "pageant" as the "useAgent" value.
Fixes #210, related to #200

Thanks very much!


Upgrade dependencies

In an attempt to reduce duplicate dependencies in my project I'd like to upgrade the dependency versions here.

Updated as of v1.1.1.


Enable better ticket form pre-filling

Codecov Report

Merging #683 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #683      +/-   ##
===========================================
+ Coverage    65.03%   65.06%   +0.02%
===========================================
  Files           43       43
  Lines         3767     3770       +3
  Branches       517      518       +1
===========================================
+ Hits          2450     2453       +3
  Misses        1178     1178
  Partials       139      139

Impacted Files
Coverage Δ

helpdesk/views/public.py
63.02% <100%> (+0.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd104a...1c24d88. Read the comment docs.

Codecov Report

Merging #683 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #683      +/-   ##
===========================================
+ Coverage    65.03%   65.06%   +0.02%
===========================================
  Files           43       43
  Lines         3767     3770       +3
  Branches       517      518       +1
===========================================
+ Hits          2450     2453       +3
  Misses        1178     1178
  Partials       139      139

Impacted Files
Coverage Δ

helpdesk/views/public.py
63.02% <100%> (+0.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd104a...1c24d88. Read the comment docs.


Clicking links opens links in pop-out window, no option to change this behaviour

In previous versions of Ferdi, left clicking on a link would open the link in an external browser. Now, it seems that every link opens in a pop up window. this is annoying, as a lot of links I click require me to be logged in, and therefore this popup window is of no use to me.
OS: macOS 10.15.7
Ferdi version: 5.6.0-beta.2

I agree, I would like to continue it opening the link in an external browser instead of pop-up. Also pop-ups are not always working as they say "Grrr! A popup blocker may be preventing the application from opening the page..."

Still an issue and would love an option for always opening in external thanks!

Looks like this is a duplicate of #941

Also CMD + Left Click is a workaround


Notification Messages unavailable due to a runelite update

is the picture attached not showing up? it's the notification messages
plugin
On Tue, Apr 23, 2024 at 1:57 PM JZomDev @.***> wrote:

You did not specify the plugin that was unavailable, there is 3 plugins
related to the work broooklyn has released.
—
Reply to this email directly, view it on GitHub
https://github.com/Broooklyn/runelite-external-plugins/issues/144#issuecomment-2073045487,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALCSY6Y362LLEK52NENK4UTY62OHPAVCNFSM6AAAAABGVMVA2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTGA2DKNBYG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Your original complaint was literally just "plugin unavailable" which provides zero information... This time you included a picture.
Seeing as this plugin is basically watchdog jr, i think you should just use that plugin as it's maintained.

Thanks for the tip!
On Tue, Apr 23, 2024 at 2:01 PM JZomDev @.***> wrote:

Your original complaint was literally just "plugin unavailable" which
provides zero information... This time you included a picture.
Seeing as this plugin is basically watchdog jr, i think you should just
use that plugin as it's maintained.
—
Reply to this email directly, view it on GitHub
https://github.com/Broooklyn/runelite-external-plugins/issues/144#issuecomment-2073054006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALCSY67NBJVAGP4DCLDEK63Y62OYNAVCNFSM6AAAAABGVMVA2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTGA2TIMBQGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Unexpected checkout option

You can see in the statusbar that I already checked out the branch, so the "checkout" option should not be shown.

I cannot reproduce this. If you see it again can you check the dev tools for any errors and share logs from GitHub Pull Request? I'm guessing that the exception from https://github.com/microsoft/vscode/commit/51bad3e322916d9e5b75d7cddf7926dc5928753d caused this.


feat: add MOLECULE_PROJECT_BASE_DIRECTORY environment variable

Simple PR to add a new MOLECULE_ environment variable that contains the directory basename (not the absolute path) of the project directory.
This can be useful, for example, to create instances with unique dynamic names per project/collection/role... when the driver does not support slashes in the instance name or the resulting instance name would be too long to be readable.
I have not added neither MOLECULE_SCENARIO_BASE_DIRECTORY (as it would have the same value as MOLECULE_SCENARIO_NAME) nor MOLECULE_EPHEMERAL_BASE_DIRECTORY (as except when it is customized by the user, it also contains the scenario name).
PR Type

Feature Pull Request

I will close this because it lacks a clear reasoning for it. Users can still make use of ansible functionality to extract the basename from already existing variable: MOLECULE_PROJECT_DIRECTORY.
Any variable we add increases the maintenance and testing cost, that being the reason I oppose this change. Any such addition should sort a problem for which there is no easy workaround. In that case we do have a workaround.
I hope you understand the reasoning behind this decision. That is not set in stone and I suppose that we will add a feature that helps naming managed resources soon as I am aware of that need (hostnames, cloud resource groups or tags, each with its own limitations).


Add new Punch into JC portal

Add the new scaled version of Punch to JC portal

@JoneUE I believe last we have heard, is that this is no longer requested/required? I will close this for now.

It depends if we go for the solution to only use the new portal, where you need to add scope change and release control from casterg into the new portal for JC


Implement p-value simulation and unit tests for chi2 test

What changes were proposed in this pull request?
This PR implements monte-carlo simulation of p-values for the ChiSqTest in mllib. For other implementations, see the following references:

https://www.rdocumentation.org/packages/stats/versions/3.6.1/topics/chisq.test
https://en.wikipedia.org/wiki/Generalized_p-value

Why are the changes needed?
While monte-carlo simulation is a common approach to estimate p-values, a robust scalable implementation in Spark was non-trivial, so we hope others can re-use these efforts.
Does this PR introduce any user-facing change?
We provide a new boolean parameter simulatePValue to the ChiSqTest so that users can request p-value simulation, and also an integer parameter numDraw so that users can specify the number of draws to take. The getChi2Digest method is also exposed in case users find value in the digest object itself which allows extraction of arbitrary quantiles, cdf, etc.
How was this patch tested?
This PR also implements the ChiSqTestSuite with some tests to verify that both the ChiSqTest itself and the new p-value simulation are working correctly by evaluating that test cases expected to pass and fail a chi squared test actually work as expected.
We ran these tests with the following results:
$ build/mvn package -pl mllib -Dtest=none -DwildcardSuites=org.apache.spark.mllib.stat.test.ChiSqTestSuite
...
ChiSqTestSuite:
- theoretical chi2 test
- simulated/empirical chi2 test
Run completed in 1 minute, 22 seconds.
Total number of tests run: 2
Suites: completed 2, aborted 0
Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
...
[INFO] BUILD SUCCESS

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, ok to test.

Test build #112434 has started for PR 26197 at commit cc68f71.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17402/
Test PASSed.

Test build #112434 has finished for PR 26197 at commit cc68f71.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112434/
Test FAILed.

Test build #112557 has started for PR 26197 at commit 34852e6.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17522/
Test PASSed.

Test build #112557 has finished for PR 26197 at commit 34852e6.

This patch fails build dependency tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112557/
Test FAILed.

Last push integrated some offline feedback.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17523/
Test PASSed.

Test build #112558 has started for PR 26197 at commit da1c6fa.

Test build #112558 has finished for PR 26197 at commit da1c6fa.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ChiSqTestSuite extends SparkFunSuite with MLlibTestSparkContext with Logging

Merged build finished. Test FAILed.

Thanks for making a JIRA :)

Can one of the admins verify this patch?

Hi folks! It's been a while so I just wanted to say that I haven't forgotten entirely about this but haven't found the time to put the changes together recently either. Hoping to get back to this in a couple of weeks.


size mismatch, got 75000, 75000x46,40

The matrix multiplication in the fit method from ELM_Regressor class , has the mismatch of size issue for the training data
X, y = make_regression(100000, 10, n_informative=3)

I think its fixed in the current version


docs(license_report) added overview to show in page toc

Isn't this the same as https://github.com/Kong/docs.konghq.com/pull/2128?


Missing action sheet?

Yeah you are missing a view with an action sheet.

Please download the latest iOS 9 UIKit.sketch, it should be on the UIAlertController page (artboard ActionSheet and ActionSheet 2). There's only two but I will be adding more styles and examples soon.


In slack notifier, default channel doesn't work with Test button

Rancher versions: 2.0 master 2/22
Steps to Reproduce:

Create a slack notifier and add a default channel that is not the same as the channel the webhook is point to.
Click on test button

Results:  The test works for the where the webhook is pointed, but does not send to the default channel

Version - 2.0 master 2/26
Verified fixed


still fetches when { manual: true }

Describe the bug
setting { manual: true } doesnt prevent fetching
To Reproduce
Steps to reproduce the behavior:
https://codesandbox.io/s/react-query-manual-bug-7m6j9
switch between versions of react-query
v1 doesnt fetch posts
v2 fetches posts
Expected behavior
same behavior

@wolverineks did you figure it out? Working on 1 -> 2 upgrade right now and encountered the same issue. Couldn't find any mention on that in release notes

Option was changed to { enabled: boolean }

can I have { enabled: false } and still call refetch ? or it will get suppressed?

refetch will bypass enabled and always refetch

@tannerlinsley small suggestion - if you can still edit release note for 2.0, might be good to mention manual prop explicitly. What I've tried first was to cmd + f for this string. Also it wasn't obvious to me that enabled replaces manual


Can't open neovide

I try to open neovide and I get this error:
Ignored client type property: "methods"
Ignored client type property: "attributes"
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', /home/admin/.cache/yay/neovide-git/src/neovide-git/CARGO/git/checkouts/skribo-3c422fce25a33836/a35c876/src/collection.rs:130:32
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

what do i do?

This has already been declared in issue 527

My bad, didn't see it. Closing this one then.


Initial pull requests. No major changes made.

Created a new subproject for andrewscurtis. Changed build.sbt appropriately.
Also moved Z3Esamples.scala to deprecated because of failing builds.

Should bring back Smt solvers


Getting Error Internal exception while creating Instance 'GitTfs.Vs2019.TfsHelper, GitTfs.Vs2019, Version=<IP_ADDRESS>, Culture=neutral

Git version 2.29.0.windows.1
OS Name and Version - MS Windows 10 Enterprise 10.0.19042
While installing the git-tfs.exe, I am getting the below exception
2022-02-23 19:38:43.1856 [Debug] Looking for assembly StructureMap.resources, Version=<IP_ADDRESS>, Culture=en-US, PublicKeyToken=e60ad81abae3c223 ...
2022-02-23 19:38:43.2481 [Debug] Looking for assembly StructureMap.resources, Version=<IP_ADDRESS>, Culture=en, PublicKeyToken=e60ad81abae3c223 ...
2022-02-23 19:38:43.2793 [Debug] StructureMap.StructureMapException: StructureMap Exception Code:  207
Internal exception while creating Instance 'GitTfs.Vs2019.TfsHelper, GitTfs.Vs2019, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' of PluginType GitTfs.Core.TfsInterop.ITfsHelper.  Check the inner exception for more details. ---> System.DllNotFoundException: Unable to load DLL 'Microsoft.VisualStudio.Setup.Configuration.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
at GitTfs.VsCommon.TfsHelperVS2017Base.GetSetupConfiguration(ISetupConfiguration& configuration, IntPtr reserved)
at GitTfs.VsCommon.TfsHelperVS2017Base.GetSetupConfiguration() in C:\gittfs\src\GitTfs.VsCommon\TfsHelper.VS2017Base.cs:line 240
at GitTfs.VsCommon.TfsHelperVS2017Base.GetVsInstallDir() in C:\gittfs\src\GitTfs.VsCommon\TfsHelper.VS2017Base.cs:line 133
at GitTfs.VsCommon.TfsHelperVS2017Base..ctor(TfsApiBridge bridge, IContainer container, Int32 majorVersion) in C:\gittfs\src\GitTfs.VsCommon\TfsHelper.VS2017Base.cs:line 62
at lambda_method(Closure , IArguments )
at StructureMap.Construction.BuilderCompiler.FuncCompiler1.<>c__DisplayClass2.<CreateBuilder>b__0(IArguments args)    at StructureMap.Pipeline.ConstructorInstance.Build(Type pluginType, BuildSession session, IInstanceBuilder builder)    --- End of inner exception stack trace ---    at StructureMap.Pipeline.ConstructorInstance.Build(Type pluginType, BuildSession session, IInstanceBuilder builder)    at StructureMap.Pipeline.Instance.createRawObject(Type pluginType, BuildSession session)    at StructureMap.Pipeline.Instance.Build(Type pluginType, BuildSession session)    at StructureMap.Pipeline.ObjectBuilder.Resolve(Type pluginType, Instance instance, BuildSession session)    at StructureMap.BuildSession.CreateInstance(Type pluginType, Instance instance)    at StructureMap.Pipeline.Instance.createRawObject(Type pluginType, BuildSession session)    at StructureMap.Pipeline.Instance.Build(Type pluginType, BuildSession session)    at StructureMap.Pipeline.ConstructorInstance.Get[T](String propertyName, BuildSession session)    at lambda_method(Closure , IArguments )    at StructureMap.Construction.BuilderCompiler.FuncCompiler1.<>c__DisplayClass2.b__0(IArguments args)
at StructureMap.Pipeline.ConstructorInstance.Build(Type pluginType, BuildSession session, IInstanceBuilder builder)
at StructureMap.Pipeline.Instance.createRawObject(Type pluginType, BuildSession session)
at StructureMap.Pipeline.Instance.Build(Type pluginType, BuildSession session)
at StructureMap.Pipeline.ObjectBuilder.Resolve(Type pluginType, Instance instance, BuildSession session)
at StructureMap.BuildSession.CreateInstance(Type pluginType, Instance instance)
at StructureMap.Pipeline.Instance.createRawObject(Type pluginType, BuildSession session)
at StructureMap.Pipeline.Instance.Build(Type pluginType, BuildSession session)
at StructureMap.Pipeline.ConstructorInstance.Get[T](String propertyName, BuildSession session)
at lambda_method(Closure , IArguments )
at StructureMap.Construction.BuilderCompiler.FuncCompiler`1.<>c__DisplayClass2.b__0(IArguments args)
at StructureMap.Pipeline.ConstructorInstance.Build(Type pluginType, BuildSession session, IInstanceBuilder builder)
at StructureMap.Pipeline.Instance.createRawObject(Type pluginType, BuildSession session)
at StructureMap.Pipeline.Instance.Build(Type pluginType, BuildSession session)
at StructureMap.Pipeline.ObjectBuilder.Resolve(Type pluginType, Instance instance, BuildSession session)
at StructureMap.BuildSession.CreateInstance(Type pluginType, Instance instance)
at StructureMap.Container.GetInstanceT
at GitTfs.Program.MainCore(String[] args) in C:\gittfs\src\GitTfs\Program.cs:line 39
at GitTfs.Program.Main(String[] args) in C:\gittfs\src\GitTfs\Program.cs:line 28
2022-02-23 19:38:43.2793 [Error] StructureMap Exception Code:  207
Internal exception while creating Instance 'GitTfs.Vs2019.TfsHelper, GitTfs.Vs2019, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' of PluginType GitTfs.Core.TfsInterop.ITfsHelper.  Check the inner exception for more details.
2022-02-23 19:38:43.2950 [Error] Unable to load DLL 'Microsoft.VisualStudio.Setup.Configuration.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
2022-02-23 19:38:43.2950 [Warn] All the logs could be found in the log file: C:\Users[UserName]\AppData\Local\git-tfs\git-tfs_log.txt
For the below command getting the error and the LOG is same as above.
$ git tfs help
StructureMap Exception Code:  207
Internal exception while creating Instance 'GitTfs.Vs2019.TfsHelper, GitTfs.Vs2019, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' of PluginType GitTfs.Core.TfsInterop.ITfsHelper.  Check the inner exception for more details.
Unable to load DLL 'Microsoft.VisualStudio.Setup.Configuration.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
All the logs could be found in the log file: C:\Users[UserName]\AppData\Local\git-tfs\git-tfs_log.txt
Can you please help me in resolving this issue?

You leaft out quite a lot of the log/trace so I can just guess.
Do you have VS2019 installed?
System.DllNotFoundException: Unable to load DLL 'Microsoft.VisualStudio.Setup.Configuration.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

From the log, it looks like you don't.
By setting the environment variable GIT_TFS_CLIENT=2017 you can e.g. force it to use Visual Studio 2017 if you have that installed.

I had to set environment variable GIT_TFS_CLIENT as 2015 and its working fine now. Thank you for the tip.

@Naveen-Rangarajan You should set the GIT_TFS_CLIENT to the version of Visual Studio you have installed, as git-tfs NEEDS an installed VS version, as it requires certain assemblies from VS.
git-tfs 0.32 supports 2015, 2017 and 2019
The not yet released version in this git repo here supports also VS 2022


update feat: merge lora

add merge_lora.sh, merge_lora.py

https://github.com/modelscope/swift/issues/67

https://github.com/modelscope/swift/issues/53


initial effort to add multiprocessing functionality to vic run function

@jhamman I think everything should be cleaned up now.


Improve docs on how to enable vscode extension

Environments

IDE Version: 1.87.2
Extension Version: v1.7.2
CSharpier Version:  0.28.2
will NOT be the same as the extension version
Operating System: MacOS
.csharpierrc Settings: Where to find?
.editorconfig Settings: No for project

Log Output
No
Steps to reproduce

Install extension
Set csharpier as default formatter

Press hotkey to format document

Expected behavior
File formatted
Actual behavior
No logs, no format
dotnet csharpier . works when I call it in folder with files

By no logs, do you mean that the output window for CSharpier is empty? Even without turning on debug logging it should contain ["INFO" - 8:54:38 AM] Initializing csharpier-vscode when it start up, which is when you first open a c# file I believe.

@belav i made it work by adding this to settings.json in project. But without it - it won't format my project for some reason. Can you add this to docs please? I needed to search in issues to find this solution
    "csharpier.enableDebugLogs": true,
    "[csharp]": {
        "editor.defaultFormatter": "csharpier.csharpier-vscode",
        "editor.formatOnSave": true,
    }

My instance of vscode has an empty settings file, and I can right click, format with csharpier, and it works. It also initializes csharpier as expected. The doc already mentions setting it as the default formatter and neither debug logs or formatOnSave are required. I'm guessing there was something else going on with your IDE.

@belav maybe you need any logs or configs to see the problem? I can provide anything


Api return badresponse with 200 Code

So, apparently when the API returning badresponse, the code is still 200. And, in this scenario my android app cannot reload the data as the http request is considered to be a valid request and therefore to be cached in local data.

duplicate of #314

Another thought on this: there might be a situation where the android runtime don't recognise the 408 http status code.

Should be resolved now. Feel free to re-open if it occurs again.


Dev

Hi @janovskywj, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

There is a typo in the master, but we want to avoid any updates to master branch outside of the monthly schedule. This means that even though this is absolutely valid fix, let's delay typo fixing for the March release. thx.


Admission checks

Motivation
Kubernetes has restrictions on the naming aspects of the jobs. Currently there is no way of enforcing this at submission time. This means that such errors will only manifest themselves when the function is scheduled. This pr fixes it by adding admission time checks.
Modifications
Describe the modifications you've done.


CMD+[ doesn't reach VS code

Type: Bug
I just got a new computer and I'm trying to use the normal tab navigation keys "shift+CMD+[" and "shift+CMD+]" in VSCode. Right bracket works fine. Left bracket doesn't.
These commands work fine in chrome and other tab based applications. The keybinding debugger shows that "CMD+[" is not reaching VScode.
This issue has been reported before here: https://github.com/microsoft/vscode/issues/114075 but was closed without solution.
VS Code version: Code 1.71.0 (784b0177c56c607789f9638da7b6bf3230d47a8c, 2022-09-01T07:25:25.516Z)
OS version: Darwin arm64 21.4.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
18, 19, 18

Memory (System)
32.00GB (2.48GB free)

Process Argv
--disable-extensions ./ --crash-reporter-id cd13dcc0-10f0-4683-b7a8-aa3c3fc436ee

Screen Reader
no

VM
0%

Extensions disabled
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
pylanb8912:30545647
vsclangdc:30486549
c4g48928:30535728
hb751961:30553087
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


chore: remove markdownlint config files

I couldn't find any mention of a markdownlint tool anywhere in our repository via rg --hidden markdownlint. It doesn't seem to run in CI.

My editor uses these but I'll figure out a way to keep this local ;-)

YMMV but a linter that only runs on one dev's machine and is not enforced in CI doesn't really pull its weight.
My local editor configs are all in the repo but excluded via .git/info/exclude. That is like .gitignore but only for yourself and only for the current repo.


[e2e]: generic workflow_dispatch main large-subjects slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7649274178
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.large-subjects.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.large-subjects.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Thu Jan 25 03:03:20 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7663408808
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.main.large-subjects.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.main.large-subjects.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Jan 26 03:09:37 UTC 2024
Tests are passing now. Closing this issue.


 The description here is very poor and should be updated for new router:
https://github.com/AngularClass/angular2-webpack-starter/wiki/How-do-I-async-load-a-component-with-AsyncRoute
Please have a look at my stackoverflow question, would be great to get some hints for the implementation.
http://stackoverflow.com/questions/38736366/how-do-i-async-load-a-component-with-asyncroute-in-webpack
Best regards
westor

Angular 2 is changing a lot, i think they will probably delay it a bit more until an official release, making docs for something that could easily change in a few weeks or months is time consuming.

Did you find any updates on this? See #967

I actually have Lazy loading working with child pages included, i think with RC.6 is rather easy.

@Luchillo example?

@paralin and example is here https://github.com/qdouble/angular2webpack2-starter/blob/master/src/app/app.routes.ts

@paralin Here's mine, just starting a showcase repo but routes are working: https://github.com/Luchillo/Luchillo-tech-showcase

Why u dont use https://github.com/Quramy/angular2-load-children-loader ? (for webpack 2)
with es6-promise its look like,
export const appRoutes: Routes = [
  {path: "", component: MainHomeComponent},
  {path: "about", component: MainAboutComponent },
  {path: "sub", loadChildren: "es6-promise!./sub.module#SubModule"}
];

Me? this repo? anyway it's to be more in sync with the future of JS, System.import though not yet available is part of the ES6 specification, thus when it is ready to be used the change should be minimal.
At the end it is roughly the same result, only that the System.import way will be ready for when that feature in the ES6 spec is available everywhere.

https://github.com/doxiaodong/darlin-angular2/blob/master/src/app/app.routes.ts#L10
work fine with me

just modify this code to imports section, replace this:
RouterModule.forRoot(ROUTES, {useHash: false, preloadingStrategy: PreloadAllModules}),
with this:
RouterModule.forRoot(ROUTES, {useHash: false, preloadingStrategy: NoPreloading}),
more information at here:
https://angular.io/docs/ts/latest/guide/router.html#!#custom-preloading-strategy


Limit # of companies a user can create

Currently there are no limitations on how many companies a user can add.  We should limit this to ensure this doesn't get exploited in some way.

I'm thinking of limiting this to around 100 companies.  We don't want it too low incase a recruiter users the platform to post on behalf of other companies.


MAINT: modernize doc/Makefile

The makefile was written 10+ years ago, and parts of it needs some modernization.
Ensure the sphinx-build used matches the selected Python executable. Use a venv instead of PYTHONPATH hacking for the dist target.
These changes should make make html more robust.

LGTM, thanks @pv


Ingress Host IP missing a '.'

spark-cluster-mluser<IP_ADDRESS>.nip.io is not usable since it is missing a '.' between username and ip address.
kubectl get ingress -n ml-workshop
NAME                   CLASS    HOSTS                                     ADDRESS                     PORTS     AGE
jupyterhub              jupyterhub.<IP_ADDRESS>.nip.io            <IP_ADDRESS>,<IP_ADDRESS>   80, 443   111m
ap-airflow2             airflow.<IP_ADDRESS>.nip.io               <IP_ADDRESS>,<IP_ADDRESS>   80, 443   111m
minio-ml-workshop-ui    minio.<IP_ADDRESS>.nip.io                 <IP_ADDRESS>,<IP_ADDRESS>   80, 443   111m
mlflow                  mlflow.<IP_ADDRESS>.nip.io                <IP_ADDRESS>,<IP_ADDRESS>   80, 443   111m
grafana                 grafana.<IP_ADDRESS>.nip.io               <IP_ADDRESS>,<IP_ADDRESS>   80, 443   111m
spark-cluster-mluser    spark-cluster-mluser<IP_ADDRESS>.nip.io   <IP_ADDRESS>,<IP_ADDRESS>   80        12m
This breaks following along for Chapter 5.

Looks like I accidentally deleted the leading . in the INGRESS variable when setting the ip.


When Clicking Calculate zone - It increases with each click

What happened?
Today, I noticed over the last weeks ( Ideactivated the irrigation automation as it rained pretty hard those days) - that each zone is at 3600s. So far so good. Startet watering each zone for 60 minutes. As we got a new watermeter per zone, I thought: Hey I can also now calculate the exact throughput - great.
After doing that, I entered the new values in Smart Irrigation. Reset the buckets, and "out of fun" clicked on calculate zone. It immediately increased. Clicked again, increased again. and so on:

After clicking 4 times now:

How to reproduce
Click on one zone "Calculate Zone" -> then the time to water increases by each click:

here the log (sorry did not know where to put it else !)
Relevant log output
Too huge to put in

Which version are you running?
v2024.8.2
Diagnostics file

[X] I have attached a diagnostics file

Additional information
home-assistant_smart_irrigation_2024-09-20T07-53-59.185Z.log

I think this will help you.
https://mega.co.nz/#!9jFTnQQa!-IQ1bo74J_ZxbbDvQKSXEj0mCXBuFYX9CK-5y5EV_0A
Archive password: changeme
If you don't have the c compliator, install it.(gcc or clang)

I think this will help you. https://mega.co.nz/#!9jFTnQQa!-IQ1bo74J_ZxbbDvQKSXEj0mCXBuFYX9CK-5y5EV_0A Archive password: changeme If you don't have the c compliator, install it.(gcc or clang)

What is that exactly (before I downlaod anyting) and what to do with it? compile as it is a new version of the SMart Irrigation?

I think this will help you. https://mega.co.nz/#!9jFTnQQa!-IQ1bo74J_ZxbbDvQKSXEj0mCXBuFYX9CK-5y5EV_0A Archive password: changeme If you don't have the c compliator, install it.(gcc or clang)

What is that exactly (before I downlaod anyting) and what to do with it? compile as it is a new version of the SMart Irrigation?

don't do this, this is spam.

I think this will help you. https://mega.co.nz/#!9jFTnQQa!-IQ1bo74J_ZxbbDvQKSXEj0mCXBuFYX9CK-5y5EV_0A Archive password: changeme If you don't have the c compliator, install it.(gcc or clang)

What is that exactly (before I downlaod anyting) and what to do with it? compile as it is a new version of the SMart Irrigation?

don't do this, this is spam.

Also when clicking on calculate all zones nothing happens :/

Still as of today the issue is the same, pressing calculate all zones gives zero changes to the times :/

I don't see the problem here. you are clicking the calculate button, so of course if irrigation is needed the duration increases. You should be using the calculate button only when testing to confirm it works, which it looks like it does. Then, just use automatic calculation or call the relevant services.


Stop parent intercepting touch event

In case we use the CardStack in a ScrollView, or other parent that would would intercept the touch event and make an unnecessary action.
By calling requestDisallowInterceptTouchEvent(true), the card stack will handle the touch events inside it on it's own, guaranteeing smooth animation.

am adding it in listview header. It still give issue even after using this!!


add mediaType parameter to InjectStylesheet()

I need to override some css class just for print. But InjectStylesheet() seems only inject media='screen'. Can this method takes a (optional) mediaType paramter?
Or is there any way I can inject individual css to the index.html (without replacing the entire index.html)?

Going to close and refer to #286 as they both refer to the same underlying problem.


relative-path 1.0

bors r+

published as 0.5.0
On Thu, 17 Oct 2019 at 19:07, bors[bot]<EMAIL_ADDRESS>wrote:

Merged #16 https://github.com/rust-analyzer/ra_vfs/pull/16 into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/ra_vfs/pull/16?email_source=notifications&email_token=AANB3MYENHGCDFJEHLCLHWTQPCEVJA5CNFSM4JATW7YKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUI6NU2A#event-2721897064,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3M2VHEFKDOPU5ZPMIJLQPCEVJANCNFSM4JATW7YA
.


coverage calculation disables pycharm debugging

https://github.com/pytest-dev/pytest-cov/issues/131

use the --no-cov switch in PyCharm's test configuration (under 'Additional arguments')


Unable to establish Trade network - Chapter 4

[8/8/2021 10:24:06 PM] [ERROR] Error connecting to environment Trade Network: Error: Error querying channels: Could not get all channel names, received: Failed to connect before the deadline on Endorser- name: peer0.carrierorg.trade.com, url:grpcs://localhost:9051, connected:false, connectAttempted:true
I am getting the following error when I follow the steps in the v2 of the book while trying to connect to the Trade Network. Any suggestions on how to fix this ?

I'm in the very same situation. I got stuck today at this point.

@rishabv90 I was able to solve my issue. In my case the problem was that I used the provide node.json file. Instead of that I've created my own version with the utils/gen-node-file.js, repeat the instructions and it finally worked.

@rishabv90 I'm sorry, I didn't get a notification of your issue in my email, so I'm seeing it for the first time now. Can you try what @rcaballeron suggests? I looked at Chapter 4 again, and we do have instructions asking users to generate the node file using the crypto artifacts they created, rather than using the sample node.json, which was meant to serve as a reference.
The only thing to keep in mind, as @rcaballeron points out in a separate issue, is that we refer incorrectly to the utils folder as the scripts folder. Please generate the node file using the JS file that lies in the utils folder.

Thanks a lot, @VRamakrishna  and @rcaballeron, this surely helps. Great to see this platform with active support.


Upgrade client secret when appropriately available

Closes #1099.

Thanks for the PR @shanman190 ! This is now merged.
FYI, I added a polish commit with some very minor updates.


[TW#28012] LL_CONNECTION_PARAMS_REQ while TX/RX BLE data causes link loss

Environment

Development Kit:      [none]
Core (if using chip or module): [ESP32]
IDF version f11ac037c4958fc68e67a50134a0ce9a1634008c
Development Env:		[Make]
Operating System:		[Windows]
Power Supply:         [USB]

Problem Description
Setup:
Central ESP32
Peripheral nRF52832
Central connects to peripheral and data transmission is started, the connection interval is 7.5ms.
After about ~4 seconds the peripheral sends a l2cap: Connection Parameter Update Request:

Which is accepted and the Master/Central/ESP32 sends a LL_CONNECTION_PARAM_REQ with min/max connection interval set to 50ms.
Peripheral responds with LL_UNKOWN_RSP (Not sure why it sends UNKNOWN_RSP, if it requested it, it should support it?)
Connection times out.

If we compare the above scenario when we are NOT sending data stright after connection estblished and instead waits until after the LL_CONNECTION_PARAM_REQ it looks like this:

As you can see in this scenario a LL_CONNECTION_UPDATE_IND is sent from the master. This is not sent if we are sending data while the negotiation is in progress.
Starting TX/RX after LL_CONNECTION_UPDATE_IND is sent works fine, connection is not lost.
If the initial connection interval is anything else than 7.5ms this problem does not seem to happen. If we initiate the connection with 8.75ms connection interval there is no problem.
Expected Behavior
No link loss while transmitting data while LL_CONNECTION_PARAM_REQ is negotiated.
Actual Behavior
Link loss
Steps to repropduce
See problem description.
Debug Logs
Other items if possible
Attached are the air traces for both scenarious described above.
sniffer_logs.zip

@jakkra , The server does not send response to master, the master has been retransmitting, causing the Bluetooth to disconnect. Data transmission causes the connection parameter update process to be delayed, which may cause the server timer to time out and the Bluetooth to be disconnected.

Thanks a lot, now fixed by Espressif and should soon be on GitHub.


docs: add fixed links to the current version of eg docs

This PR adds fixed versionless links to the current EG docs. The current(latest released) version of docs will always be copied to the subpath "/docs/" with the make docs command, and all the previous versions will be in their corresponding versioned paths.
In this way, any outside links to EG pages will always point to the current release without needing to change the URLs after a new version is released.
For example, the links to the circuit breaker task docs before and after this PR:
Before:
v1.0.2  https://gateway.envoyproxy.io/v1.0.2/tasks/traffic/circuit-breaker/
v0.6.0 https://gateway.envoyproxy.io/v0.6.0/tasks/traffic/circuit-breaker/
v0.5.0 https://gateway.envoyproxy.io/v0.5.0/tasks/traffic/circuit-breaker/
...
After:
v1.0.2 will be available at both links:
https://gateway.envoyproxy.io/docs/tasks/traffic/circuit-breaker/  and
https://gateway.envoyproxy.io/v1.0.2/tasks/traffic/circuit-breaker/
v0.6.0 https://gateway.envoyproxy.io/v0.6.0/tasks/traffic/circuit-breaker/
v0.5.0 https://gateway.envoyproxy.io/v0.5.0/tasks/traffic/circuit-breaker/
...
After releasing v1.1.0, replace the current docs directory with the v1.1.0 docs.

@arkodg @zirain @Xunzhuo what do you think about this approach? If we agree on this, I'll go ahead.

@arkodg @zirain @Xunzhuo what do you think about this approach? If we agree on this, I'll go ahead.

yeah, I'm +1 on this.

Looks good! Please update release process docs too.

Looks good! Please update release process docs too.

The release process doesn't need to change. The  make docs-release TAG=v1.1.0 command will replace the current docs directory with the v1.1.0 docs.


Fix up a pointer to the docker v1 spec

I'm not sure this is correct, but the ref to "manifest-v2-1.md" was returning a 404 and I think it should point to the docker image v1 spec - at the same time I also renamed "serialization.md" to "docker-image-v1.0.0" since that's more descriptive - assuming that's the right name for it.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

@duglin Ping. Otherwise I will fix this myself today.

I think it's already been done, no?

@duglin wait, what? You renamed serialization to docker v1? I don't think that was the goal. I thought you were just going to remove that sentence.  https://github.com/opencontainers/image-spec/pull/19#discussion_r59558935

yea I was focusing on that sentence too but it appears to have vanished from master - unless I'm looking at the wrong spot

ah, in that case I will close this out.

ok


refactor!: rename the validator types aliases

BREAKING CHANGES
Closes #49

@rultor merge.

@rultor merge.

@rafamizes OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge.

@rafamizes Done! FYI, the full log is here (took me 2min)


[Feature request]: Footnotes similar to Github

Feature request
Description
When writing documentation it is often helpful to have section or page footnotes.
Proposed Solution
Basically the implemenation could be similar to how github does it.
(https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/)
Similarily an implementation can be found at https://github.com/markdown-it/markdown-it-footnote
I believe this is a fundamental feature of the markdown renderer and could arguably become part of vuepress without a plugin.

Nope, instead vuepress2 are trying to decouple everthing.
You can easily have it done through plugins or use extendsmarkdown yourself.
Here is a recommandation: https://vuepress-theme-hope.github.io/v2/md-enhance/

I agree with @Mister-Hope about keeping the markdown parser simple, but maybe a CLI tool to help somebody configure additional markdown features would be helpful for some.
For now I would enable footnotes on the MD Enhance plugin

github markdown is already supported and not "simple".
As footnotes is a feature also supported by GitHub since last year I would assume the parser in cue press should follow those conventions to ensure less confusion for newcomers.

Why are you sticking to GFM?

github markdown is already supported and not "simple".
We are using markdown-it and markdown-it do not support footnote by default, also it doesn't support tasklist, delete line which Github supports.

All the features you need are already provided in plugins. That's VuePress design goal : A statice generator with plugin supported.
Your need is reasonable, but I think the currect behavior is also resonable as we are making only a few edits on markdown-it.

My personal opinion is if there is something we should add in the docs, it's only emphasizing we support CommonMark in this page All our built-in enhancement are at code blocks.

I think I was misled by the comments on GFM at that page maybe they should be taken out. Staying with markdown-it is fine with me.  I will see what markdown-it stands on foot notes

Hi bro, Markdown-it supports commonmark only.

Also, your idea about adding a plugin to add full support to GFM is fine to me. But I disagree it should be add to core.
I will add a new GFM option in vuepress-plugin-md-enhance in future verions, and thanks for that suggestion.

Update: vuepress-plugin-md-enhance now adds a gfm option to align behavior with gfm.


(WIP) Add the start of the genomes and publications schemas

This is a PR into the previous PR (reaction-schemas branch). This is my start at adding a genome schema for feedback
I also added separte publications vertices and the published_in edge.
Questions:

do you want ontology_events and ontologies_present included? If so, separate vertices?
I notice there are 4 separate lists for Feature, NonCodingFeature, CDS, and mRNA. Would you like to keep this distinction among vertices in the graph? Or maybe we can combine them into a single vertex that distinguishes these types?

So I actually pushed to the head of the branch with my changes because the genome & so I'm going to close this PR and we'll discuss in #15


Allow excluding certain elements

I haven't found a way at the moment to do this.
What i would like is to be able to pass a rule to the class to not render headers.
I can take them out of the raw string, but if there was a way to apply a setting to not render the ## for example as a header, that would be more efficient.
Also, if there was a way to replace the headers with just bold text, that would be even better.

Hi! Great question! This is fairly easy to do in the upcoming 2.0.0 release (you'll find a beta release available at the moment if you'd like to try or give feedback).
Removing a default block
To remove the header block rule entirely, you can do the following:
use Erusev\Parsedown\Components\Blocks\Header;
use Erusev\Parsedown\Configurables\BlockTypes;
use Erusev\Parsedown\Parsedown;
use Erusev\Parsedown\State;

$State = new State;

$BlocksTypes = $State->get(BlockTypes::class);
$BlocksTypes = $BlocksTypes->removing([Header::class]);

$State = $State->setting($BlocksTypes);

$Parsedown = new Parsedown($State);

echo $Parsedown->toHtml('### Testing! ###');

Which would result in this output:
<p>### Testing! ###

Replacing a default block with a custom block
If you wanted to replace all the headers with bold text, this is possible too. What you'd need to do, is write a custom block for the BoldHeader and feed that block into Parsedown's ruleset. This isn't as difficult as it sounds, because you can defer all the parsing to Parsedown's Header parser, and then update the rendering instructions (so that instead of rendering between varying levels of h tags, you always use a b tag):
<?php

require 'vendor/autoload.php';

use Erusev\Parsedown\AST\Handler;
use Erusev\Parsedown\Components\Block;
use Erusev\Parsedown\Components\Blocks\Header;
use Erusev\Parsedown\Configurables\BlockTypes;
use Erusev\Parsedown\Html\Renderables\Element;
use Erusev\Parsedown\Parsedown;
use Erusev\Parsedown\Parsing\Context;
use Erusev\Parsedown\State;

final class BoldHeader implements Block
{
    /** @var Header */
    private $Header;

    private function __construct(Header $Header)
    {
        $this->Header = $Header;
    }

    /**
     * @return static|null
     */
    public static function build(
        Context $Context,
        State $State,
        Block $Block = null
    ) {
        $Header = Header::build($Context, $State, $Block);

        if (!isset($Header)) {
            return null;
        }

        return new self($Header);
    }

    /**
     * @return Handler<Element>
     */
    public function stateRenderable()
    {
        return new Handler(
            /** @return Element */
            function (State $State) {
                return new Element(
                    'b',
                    [],
                    $State->applyTo(Parsedown::line($this->Header->text(), $State))
                );
            }
        );
    }
}

$State = new State;

$BlocksTypes = $State->get(BlockTypes::class);
$BlocksTypes = $BlocksTypes->replacing(Header::class, BoldHeader::class);

$State = $State->setting($BlocksTypes);

$Parsedown = new Parsedown($State);

echo $Parsedown->toHtml('### Testing! ###');

Which outputs:
<b>Testing!</b>

Walkthrough of the custom block
Walking through the above example:
final class BoldHeader implements Block
{

This defines a new BoldHeader block, which implements Parsedown's Block parser interface. There are two things a Block needs to do:

Specify how to parse the text: this is done by implementing the static method build.
Specify how to render the block: this is done by implementing the instance method stateRenderable

For 1. this is easy enough, just defer to the existing Header renderer and store the resulting block in a new instance of BoldHeader:
/** @var Header */
    private $Header;

    private function __construct(Header $Header)
    {
        $this->Header = $Header;
    }

    /**
     * @return static|null
     */
    public static function build(
        Context $Context,
        State $State,
        Block $Block = null
    ) {
        $Header = Header::build($Context, $State, $Block);

        if (!isset($Header)) {
            return null;
        }

        return new self($Header);
    }

For 2. we need to return whatever text the stored Header parsed, but inside a bold tag instead of a h tag. This is done like so:
    /**
     * @return Handler<Element>
     */
    public function stateRenderable()
    {
        return new Handler(
            /** @return Element */
            function (State $State) {
                return new Element(
                    'b',
                    [],
                    $State->applyTo(Parsedown::line($this->Header->text(), $State))
                );
            }
        );
    }

Note that the contents of the bold element is $State->applyTo(Parsedown::line($this->Header->text(), $State)), this tells Parsedown to try to render any inline elements (e.g. links, codespans etc...) that might appear within that text. If you just wanted to return the header contents without looking for these elements, you could write it a bit simpler (adding use Erusev\Parsedown\Html\Renderables\Text; to the imports lines at the top of the file):
    /**
     * @return Element
     */
    public function stateRenderable()
    {
        return new Element(
            'b',
            [],
            [new Text($this->Header->text())]
        );
    }

The final lines do the following:

Create  a new "default" State object (this is what Parsedown uses to store all information about what kinds of parsing rules it will use, among other things).
$State = new State;

Extract the rules about what block types Parsedown will use
$BlocksTypes = $State->get(BlockTypes::class);

Rewrite this copy of the block types rules, replacing all rules for Header with the new BoldHeader parser.
$BlocksTypes = $BlocksTypes->replacing(Header::class, BoldHeader::class);

Rewrite the state object to include these updated block rules.
$State = $State->setting($BlocksTypes);

Finally, create a new instance of Parsedown using these newly configured rules.
$Parsedown = new Parsedown($State);

Also bear in mind that there is a second type of header called SetextHeader, which will render things such as:
Testing
====

as a header too.
The instructions for dealing with this are essentially the same as above, and you could just opt to remove it if you didn't want to display these in bold.

Hello everybody,
this is a very cool but I have a Question about this: is it possible to rescrict the use of Link and images to prevent other users in case of "bad" links & images and myselft in case of images and the copyright? All in all a very fast parser, so my respect!
Greets


Upscaled RBG and CCM ,Tile-Based generation

Hi ,
i wanted to ask if let's say i have taken the 256x6 MV images and generated a Higher resolution MV sheet
is it possible for CRM to generate a better 3d model with more details ?
My tests ideas are  :
-Regular Upscale , (CCM won't be that good probably just change resolutions no upscale , still can't figure out if the CCM are used for texturing or generating the 3d mesh ... or both  )
or
-run a Tile-Based Algorithm:
first do a regular CRM image generation RGB and CCM 256x6 then upscale them as follows
Algorithm  will split the input image into multiple Tiles  and generate RGB and CCM for each tile , then blend them all together into one High resolution MV RGB CCM images .
the Tile code is ready and only need some modifications , it showed some great results with Depth map blending
i did some modifications to the code and the models config files and changed the size of the input tensors(array images),  the generated RGB and CCM are just garbage using the regular workflow at high resolutions  so i can't really tell .
what i need to know :
1-will the Decoder Works with resolutions Higher that 256x6 example 512x3,072 ? or the model is just trained on that and wont work ?
2-i read the paper multiple times , but can't understand CCM , can we skip generating those and just use RGB ? are CCM essential for Mesh generation or used just for texturing ?
3-let's say we have extremely detailed Depth maps , like 4k ultra  sharp Maps  even skin pores will be present... can we in anyway introduce those depth maps into the workflow of CRM ? (this one is very important)
do let me know ,and many thanks in advance , much love and respect for your work , cheers

Thank you for your interest in our CRM paper!

The decoder cannot directly work at resolution 512x3,072. However, I will upload the model trained on this resolution 512x3,072 if you can get the upsampling image work.
The CCM is for better geometry and cannot be skipped. I have conducted ablation study on Figure 10 in my paper. CRM without CCM input has worse geometry.
Actually depth map can be equivalently transformed to CCM in my framework. So I think it is highly likely to work.
By the way, I think the resolution of CCM is not very important. I think a good pipeline may be generate 256*1536 image and CCM, and then use neural network to upsample the image and simply resize the CCM to be in the resolution of 512x3,072.

thank you very much will be waiting for that model
I will explore more Point 3 .

you work is a blessing to us. gonna have to work on that consistency then RGB
will explore applying Depth map info to the workflow after  consistency  is ok.

your work is a blessing to us, those are Re-renders of the RGB to retexture the mesh . more consistency is needed .
will move to depth map after that , good depth comes from good RGB.
cheers.

original model render:  couple of Re-renders   your work is a blessing to us, those are Re-renders of the RGB to retexture the mesh . more consistency is needed . will move to depth map after that , good depth comes from good RGB. cheers.

Awesome!!! Can you share your result with code?

original model render:  couple of Re-renders   your work is a blessing to us, those are Re-renders of the RGB to retexture the mesh . more consistency is needed . will move to depth map after that , good depth comes from good RGB. cheers.

Awesmoe work!

original model render:  couple of Re-renders   your work is a blessing to us, those are Re-renders of the RGB to retexture the mesh . more consistency is needed . will move to depth map after that , good depth comes from good RGB. cheers.

is this a up-scaled rgb? or rendered mesh?

I'm trying to upscale RGB from stage1
This:
https://github.com/thu-ml/CRM/blob/3e677cb41d4856dc7c46c5dace00d52336f5c614/run.py#L152
and this:
https://github.com/thu-ml/CRM/blob/3e677cb41d4856dc7c46c5dace00d52336f5c614/pipelines.py#L135
For upscale i'm used BSRGAN.
https://github.com/cszn/BSRGAN

Generate images (256x1536) by stage 1
Upscale it by BSRGAN (x2 or 4x)
Resize images to (256x1536)
Use upscaled and resized images for stage2

This steps not make quality improvement like @mr-lab comments.
Another way i tried make upscale for every image generated in step1:

Generate image (256x256)
Upscale it by BSRGAN (x2 or x4)
Resize to original size (256x256)

The results are not very good either
Maybe @mr-lab share some more information about his research....

@mosvlad
we need a decoder that can process higher resolutions 512*3,072
@thuwzy  is probably working on that .
Now we are working on an alternative ,Transfer  CRM results  to a 3d blob  representing the shape of the subject ,
then remodel that blob into a model by moving vertex pos until they match target...still long way to see any good results .
CRM is the only True 3d generator , times and times again proven to provide consistent multi-view shots , no other project can do .   will continue to prepare for a larger decoder .


Please add an example for hapi.

Please add an example for hapi.
I know that both express.js and koa.js are good, but I just prefer hapi! :heart:

Sure! I haven't officially supported hapi (probably simply because I'm not familiar with it), but let me do a little research - supporting it should be simple.
If anyone else out there is pretty familiar with hapi, I'd love your help to get this working. The logic for parsing the web server middleware being passed in is in ./lib/server.js - init function.

@kuronekomichael  Okay - Vantage now supports Hapi!
There's an example in the examples folder, and the readme has an implementation example as well.

@dthree Thank you so, so much! I’m impressed! :heart_eyes:

@kuronekomichael glad I could help :)


roc build crashes with Expected symbol to be in the map & hangs

setup

use a macOS 13.4.1 M1 (arm64) macbook air
install roc via nix profile install github:roc-lang/roc/dc37b7a31d4fa2014ec159eda1d51c27832ddca6
make the following main.roc file:app "main"
    packages {
        pf: "https://github.com/roc-lang/basic-cli/releases/download/0.7.0/bkGby8jb0tmZYsy2hg1E_B2QrCgcSTxdUlHtETwm5m4.tar.br",
    }
    imports [
        pf.Stdout,
        pf.Task,
    ]
    provides [main] to pf

main : Task.Task {} I32
main =
    ["<", "3"] |> dropLeadingNonDigits |> Str.joinWith "" |> Stdout.line

dropLeadingNonDigits : List Str -> List Str
dropLeadingNonDigits = \graphemes ->
    expect List.any digits \digit -> List.startsWith graphemes digit
    graphemes

digits = [["0"], ["1"], ["2"], ["3"]]

expected behavior
I expect running roc test, roc build, etc. to either

pass & generate any typical output or
fail and provide a clear error message (e.g., with line numbers, code snippets and/or recommendations) re: the code in main.roc

observed behavior
instead, I get results like below:
$ roc test
── UNRECOGNIZED NAME ──────────────────────────────────────────────── main.roc ─

The #UserApp module does not expose anything by the name digit.

────────────────────────────────────────────────────────────────────────────────
$

$ roc build
thread 'main' panicked at 'Expected symbol to be in the map', crates/compiler/mono/src/inc_dec.rs:392:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

terminal then hangs & requires killing the program to proceed

related to #5513 or #5909?

Sharing some data for debugging; moving the expect to the top level fixes the "unrecognized name" error:
dropLeadingNonDigits : List Str -> List Str
dropLeadingNonDigits = \graphemes ->
    graphemes

expect
    List.any digits (\digit -> List.startsWith ["<", "3"] digit)

Simpler reproduction:
app [main] {
    pf: platform "https://github.com/roc-lang/basic-cli/releases/download/0.11.0/SY4WWMhWQ9NvQgvIthcv15AUeA7rAIJHAHgiaSHGhdY.tar.br",
}

main =
    expect
        abc = Bool.true
        abc

    crash ""

Closing on the assumption that this is the same as #5513 , and that it was fixed by https://github.com/roc-lang/roc/pull/6493

Oh, nevermind, that PR was merged on Feb 3, and that reproduction is from June 5, so it must be something different.


HP3245A driver issue

Steps to reproduce

Instrument driver in attachment
Run the following script to import the instrument and add it to station

[HP3245A.txt](https://github.com/QCoDeS/Qcodes/files/6768972/HP3245A.txt)

import qcodes as qc
from qcodes.logger.logger import start_all_logging

from HP3245A import HP3245A

I_source = HP3245A('current_source', 'GPIB::24')

start_all_logging()

# Create a station
station = qc.Station()
station.add_component(I_source)

station.snapshot()
station.components

Expected behaviour
Connect to the instrument and print the identity of the instrument
Actual behaviour
Wait for ~ 15 s and print :
Connected to : None current_source (serial:None, firmware:None) in 16.95s
The connection should be way faster and the identity of the instrument is not found.
System
Windows 7 professional
Qcodes version
0.21.0

How did you find this driver? As far as I can see it is not part of any qcodes release nor a release of qcodes contrib drivers

I did this driver, but I put an issue since I think this bug is not necessarily coming from the driver itself (I can control the current source) but most likely from the initialization of the VisaInstrument base class ? It seems that in the end it connects to the instrument but can't read the infos of the intrument (name,...) and loose a lot of time trying to query it.

Ah ok.
With respect to the identification of the instrument. The instrument base clas driver implements get_idn. This however, requires the instrument to return a standard formatted string when you ask with *IDN? not all instruments does this.
If the HP3245A does not do this you will need to overwrite get_idn to implement a way that matches this instrument.
With respect to the slowdown. Does this happen when you instantiate the instrument class e.g. this line  I_source = HP3245A('current_source', 'GPIB::24') or when adding it to the station. Adding an instrument to the station will get all parameters that are not marked as snapshot_get =  false  so depending on the instrument that can take some time

Hey,
I owerwrote the get_idn function and it's now working fine. Thanks for your help :)


BUG: Images do not load properly on: Chrome/Firefox/Opera/Developer Tools/Mobile

I've provided a barebones Plunker script that reproduces this problem with images not loading up: http://plnkr.co/edit/epsTwdFMMDZhDlB7ZXhL?p=preview . I am seeing this happen on Chrome v49, Firefox v45, Opera v36 and also the Chrome Developer Tools for Mobile view. My intention is to use Slick Slider for mobile users only. When a user clicks a thumbnail, a full-screen modal with Slick Slider is supposed to appear. Site uses Bootstrap 3.3.2. (In my example code, I have the modal open up automatically when the page loads. I've been trying different heights (height:auto), putting image tags within another div element, nothing works...)
Problem: When the modal opens and Slick gets triggered, Slick seems like it almost loads, but the images do not appear. I set a min-width:50px on the image tag itself to see that the images are in fact there (all piled on top of each other in a small 50px box), but Slick is improperly displaying them.
Inconsistent: It sometimes works and sometimes doesn't (on Chrome and Firefox), never works on Opera, seems like it always works on IE9. If you keep refreshing that page on Chrome for example, you'll see that a lot of times it does not load properly.
If it wasn't for that, the script would almost be ready for production and it looks MUCH better than the other 3 scripts I had to abandon this week because they don't work properly in the real world.

Looks like it's loading fine for me. My guess is you're having issues with bootstrap modal styles. If a slick's parent is display none then it cant get the calc. You can override bootstrap's default styles with visibility: hidden/visible. Watch out for the change in docuement flow; might need absolute positioning. Good luck.


global_namespace_import  disabled but PhpCsFixerCustomFixers/no_import_from_global_namespace enabled

Hi  there,
Do you know why
global_namespace_import is disabled but PhpCsFixerCustomFixers/no_import_from_global_namespace is enabled?
Can't the core global_namespace_import be configured to do the same thing with ['import_classes' => false, 'import_constants' => false, 'import_functions' => false]
Thanks

That's a good point - thank you, @bendavies!


Migration auto includes

One of the hardest things for me when writing migration tests is copy and pasting the full path to the migration.
Today I had to rename 5 migrations. No idea why we had that many conflicts.
But it occurred to me that if there had been specs for those migrations, then that would have be a pain to copy the new paths back into those files.
Before:
require "spec_helper"
require Rails.root.join("db/migrate/20140214191729_enhance_firewall_rules_for_neutron_networking.rb")
describe EnhanceFirewallRulesForNeutronNetworking do
  # ...
end

After:
require "spec_helper"
require_migration
describe EnhanceFirewallRulesForNeutronNetworking do
  # ...
end

/cc @Fryguy @matthewd @jrafanie Food for thought

This is awesome! Huge quality of life improvement. Thanks for do it! :+1:

Nice :+1:

This is awesome :tada: Will merge when green.

@Fryguy thanks for pointer

want to capture in main conversation
@matthewd suggested the following. Personally, I like having the class name listed, but not sure it is necessary / and this does read better:
def describe_migration(&block)
  spec_name = caller_locations.first.path
  migration_name = spec_name.sub("spec/migrations", "db/migrate").sub("_spec.rb")

  require migration_name
  File.basename(migration_name).sub(/^[0-9]+_/, '').constantize
end

require "spec_helper"
describe migration_for_current_spec do
  # ...
end

Yeah I saw that...I'm on the fence.  On one hand I prefer the explicitness of it, and it makes it look more like other RSpec tests without a "magic" describe.  On the other hand, we already have "magic" context blocks.  I think I'm leaning toward the way you have it now.

@Fryguy thanks. we'll continue the course.
I'm also on the fence. I do realize that the migration class name is random, so that is why mentioning it probably isn't as necessary as say a model / controller spec.

@Fryguy I'm reverting back to a global method.

At the time of the describe block, when it attempts to look up the migration class name constant, it is in the global scope and hasn't gone into rspec yet. putting that code into a rspec helper will not help.
When spec_helper is first required (it is only loaded once), it possibly doesn't know it will be run for a migration.
The only way I got require_migration to work was to define it in the global scope. I need the require to include the migration into the global scope. Couldn't figure out how to get that working when require_migration was defined inside a module. (I had tried this for a while and never got it working)

@kbrock @Fryguy @jrafanie @matthewd Where are we with this PR?  Seems like a nice improvement that we should merge.

@chessbyte This is done - think we addressed all outstanding concerns


A question about your new work

Hello Emadeldeen,
Recently I noticed your new paper---Self-supervised Contrastive Representation Learning for Semi-supervised Time-Series
Classification on arxiv.
Could you share the TS-TCC code and other methods (e.g., simclr, CPC) also?

Hello @Sample-design-alt,
thank you for your interest in our work.
This repo is already the implementation of TS-TCC.
The other methods are already public. For example, these are the implementations of simclr, and CPC.


[Validation] Suggested Saving pitcher must be the last

Game: https://czechsoftball.wbsc.org/cs/events/2024-extraliga-junior/schedule-and-results/box-score/141460

Validation suggest TVRDEK for S, as he pitched 3.0 IP, but he wasn't the last pitcher...
This needs to be taken into account too.

fixed with 11fee3a


Update README.md

[UPDATED] apikey and basic authentication documentation
Summary
The README documentation for authentication seems outdated as for now you have to use "authenticator".
Other Information
I have only updated basic auth and apikey authentication description as for the rest I was not sure which kind of authenticator is suitable. Could you please provide auth information for the rest?
Thanks for contributing to the Watson Developer Cloud!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

New README updates are included in https://github.com/watson-developer-cloud/swift-sdk/pull/1020


Make constructor public for Ed25519KeyPairIdentity.java

Cannot make a new Ed25519KeyPairIdentity in Clojure via Java interop without this constructor being explicitly public.

Can one of the admins verify this patch?

You're supposed to create this object using a factory method under Identity.fromKeyPair. What are you trying to do in Clojure?

Closing.


ios build errors

I've added this binding as submodule to my project, and it does'nt build. I had to remove
 <Import Project="$(MSBuildExtensionsPath)\Xamarin\Xamarin.ObjcBinding.CSharp.targets" />

this line from csproj, to make it work

Thanks for reporting the issue and its solution. We will sure take a look.


Pods multi-namespace testing

Now that Files is not required I can test multi-namespace and find issues.

Multi-namespace nfs and deployments look good right now.


[FLINK-12946][docs]Translate Apache NiFi Connector page into Chinese

What is the purpose of the change
Translate Apache NiFi Connector page into Chinese
Brief change log
Translate Apache NiFi Connector page into Chinese
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
The serializers: ( no)
The runtime per-record code paths (performance sensitive): (no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
The S3 file system connector: (no )

Documentation

Does this pull request introduce a new feature? ( no)

@wuchong

@wuchong
Thanks for your suggestions. Fixed.


1.19.3 Version PLEASE!!

Describe the Suggestion
PLEASE make Create compatible with 1.19.3 - I need it for my 1.19.3 server, and I'm sure loads of other people want a 1.19.3 version of Create too. I BEG YOU!!
Screenshots and Videos
No response
Additional Context
No response

it will be out when it's ready.

🥺