fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "msg": "Error connecting: Error while fetching server API version: ('Connection aborted.', PermissionError(13, 'Permission denied'))"}

Hello, I've done everything correctly, in the right order, and am getting this error. I have no idea what to do about it. Thank you for your time and help.
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "msg": "Error connecting: Error while fetching server API version: ('Connection aborted.', PermissionError(13, 'Permission denied'))"}

Try rebooting the Pi and then try again :)

Thanks for responding! I did as you suggested that just about fixed everything... I am getting the following error:
fatal: [<IP_ADDRESS>]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host <IP_ADDRESS> port 22: Connection timed out", "unreachable": true}
I am using ssh to use my Raspberry Pi, does this affect the execution of the code? Is it like using a phone landline? Can't have 2 calls at once? Thank you again for your time and help.

It looks like your inventory file might have to different lines in it connecting to both localhost AND <IP_ADDRESS>. You should comment out the <IP_ADDRESS> line in the inventory file if you don't have a Pi at that address as well.

Wow! Incredible, it worked! Thank you so much!

I know this one is closed, I am just having the same issue with the fetching server API  version (first part) -- logging out and rebooting the pi do not work.  I am using a pi4 8GB with 64-bit pi and booting off SSD.


When a humanoid is first climbing and then jumps off the anticheat detects it.

This also happens when a player bounces from an edge if they enter the climbing dtate for even a brief moment.


Automated investigations statistics - 7 days not 30

The "Automated investigations statistics" section should read "7 days" vice "30 days".
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-atp/security-operations-dashboard?source=docs#automated-investigations-statistics

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2dec0f3e-e970-48ed-68d5-56200c566ac7
Version Independent ID: 89757f65-c389-c826-347a-c0a9839b3042
Content: Microsoft Defender Security Center Security operations dashboard - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/security-operations-dashboard.md
Product: w10
Technology: windows
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Thank you for the feedback, @s207307. We've made the fix, and the change will render live later today.


Fixes Test-DbaLastBackup

Fixes #1255
Changes proposed in this pull request:

TrustDbBackupHistory implement to make things easier
moved to -raw for get-DbaBackupHistory as the looping expects ungrouped input
removed some path[0] calls as path is now a string, so that was pushing in a char array for giggles.

lol giggles! you're awesome, thank you stuart!


Add some Grafana dashboard examples

Create some screenshots of Grafana dashboards (and alerts?)
(spoiler: I didn't have an actual one myself, for the moment)

Can you post the json of the grafana dashboard? Or make it public and provide a link?
I'm trying to replicate the logs by level graph but can't seem to quite get it.

@aacater good idea, I've updated the README with queries and panel JSONs.
(beware that my Grafana-fu is limited and this is just a pet-project, so there surely may be a lot I got wrong).

Perfect, thank you!


Add prefix to link block title - CourseDatesView

Description
LEARNER-7911

Add assignment type before date block title i.e, Homework, Lecture

The Date sub item title should be wrapped underneath of prefix title like the web.

Web screenshot:

Fixed.
I also squash the commit as the code isn't reviewed so make it single commit


Add vedro to Awesome Frameworks list

Vedro.io appears to be a modern and pragmatic framework, providing all the necessary functionality right out of the box without relying on magic.

can you please link to the gh repo https://github.com/vedro-universe/vedro and insert it in the alphabetical order?

can you please link to the gh repo https://github.com/vedro-universe/vedro and insert it in the alphabetical order?

Thank you for the comment! I have fixed it.

@cleder Hey there! Any other roadblocks for putting vedro on the awesome list?
Just let me know if there's anything else we need to handle before merge it 🤙


add offset shifting for GPU particles

https://forum.babylonjs.com/t/origin-shifting-and-particle-systems/1201/8

https://doc.babylonjs.com/babylon101/particles#world-offset


Updated Generic Helm Chart to use ClusterIP configuration and validate within Testnet

Currently, the Generic Helm chart is using a NodePort configuration to expose the mina daemon services. Past configurations used Cluster IP instead. At this time, portions of the integration test stack as well of scripts and terraform for deploying testnets are relying on the helm chart using a ClusterIP configuration. This zenhub issue is to document updating the Generic Helm and validating it in testnet deployment.

This item is no longer valid, @lk86 is currently working on newly planned changes for the existing helm charts. This allows a cleaner split, where @lk86 updates the Helm charts, while I focus on refactoring the Terraform configurations.


Pipenv run swallows terminal errors, and shows standard command  could not be found

Be sure to check the existing issues (both open and closed!), and make sure you are running the latest version of Pipenv.
Check the diagnose documentation for common issues before posting! We may close your issue if it is very similar to one of them. Please be considerate, or be on your way.
Make sure to mention your debugging experience if the documented solution failed.
Issue description
I was trying to get pyenv and pipenv working on my machine (mac OS), and what resulted was that I could still run pipenv shell but any pipenv run <command> attempt failed.
After some deep debugging, it turns out I had a terminal error appearing, that wasn't an obvious problem, but caused the subprocess.POpen call in delegator to fail as if it had not found the file, rather than an unknown error.
> /Users/abartlett/Library/Python/3.7/lib/python/site-packages/pipenv/core.py(1470)system_which()
-> c = delegator.run("{0} {1}".format(_which, command))
(Pdb) l
1465 	    os.environ = {
1466 	        vistir.compat.fs_str(k): vistir.compat.fs_str(val)
1467 	        for k, val in os.environ.items()
1468 	    }
1469 	    try:
1470B->	        c = delegator.run("{0} {1}".format(_which, command))
1471 	        try:
1472 	            # Which Not found…
1473 	            if c.return_code == 127:
1474 	                click.echo(
1475 	                    "{}: the {} system utility is required for Pipenv to find Python installations properly."
> /Users/abartlett/Library/Python/3.7/lib/python/site-packages/pipenv/vendor/delegator.py(206)run()->None
-> self.was_run = True
(Pdb) l
201  	                pexpect_kwargs["env"].update(env)
202  	            # Enable Python subprocesses to work with expect functionality.
203  	            pexpect_kwargs["env"]["PYTHONUNBUFFERED"] = "1"
204  	            s = PopenSpawn(self._popen_args, **pexpect_kwargs)
205  	        self.subprocess = s
206  ->	        self.was_run = True
207
208  	    def expect(self, pattern, timeout=-1):
209  	        """Waits on the given pattern to appear in std_out"""
210
211  	        if self.blocking:
(Pdb) p s.stderr.readlines()
['dyld: Library not loaded: /usr/local/opt/icu4c/lib/libicui18n.62.dylib\n', '  Referenced from: /usr/local/bin/node\n', '  Reason: image not found\n']

Expected result
I would expect the actual error to bubble up to the console, so that I know it failed to run the which command, rather than it failing silently.
Actual result
> pipenv run pip freeze
Loading .env environment variables…
Error: the command pip could not be found within PATH or Pipfile's [scripts].

Steps to replicate
unsure how to replicate this, I suspect something that intentionally fails in your .bash_profile or .zshrc file.
Have spent last day on this, and am unable to reproduce right now, will try next week.
$ pipenv --support
Pipenv version: '2018.11.26'
Pipenv location: '/Users/abartlett/Library/Python/3.7/lib/python/site-packages/pipenv'
Python location: '/usr/local/opt/python/bin/python3.7'
Python installations found:

3.7.2: /usr/local/opt/python/libexec/bin/python
3.7.2: /usr/local/bin/python3.7m
2.7.10: /usr/bin/python
2.7.10: /usr/bin/pythonw
2.7.10: /usr/bin/python2.7

PEP 508 Information:
{'implementation_name': 'cpython',
 'implementation_version': '3.7.2',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '18.2.0',
 'platform_system': 'Darwin',
 'platform_version': 'Darwin Kernel Version 18.2.0: Fri Oct  5 19:41:49 PDT '
                     '2018; root:xnu-4903.221.2~2/RELEASE_X86_64',
 'python_full_version': '3.7.2',
 'python_version': '3.7',
 'sys_platform': 'darwin'}

System environment variables:

TERM_SESSION_ID
SSH_AUTH_SOCK
Apple_PubSub_Socket_Render
COLORFGBG
ITERM_PROFILE
XPC_FLAGS
LANG
PWD
SHELL
TERM_PROGRAM_VERSION
TERM_PROGRAM
PATH
COLORTERM
TERM
HOME
TMPDIR
USER
XPC_SERVICE_NAME
LOGNAME
__CF_USER_TEXT_ENCODING
ITERM_SESSION_ID
SHLVL
OLDPWD
BROWSER
EDITOR
VISUAL
PAGER
LESS
LESS_TERMCAP_mb
LESS_TERMCAP_md
LESS_TERMCAP_me
LESS_TERMCAP_se
LESS_TERMCAP_so
LESS_TERMCAP_ue
LESS_TERMCAP_us
LSCOLORS
LS_COLORS
GREP_COLOR
GREP_COLORS
WORKON_HOME
PROJECT_HOME
VIRTUALENVWRAPPER_PYTHON
VIRTUALENVWRAPPER_PROJECT_FILENAME
VIRTUALENVWRAPPER_WORKON_CD
VIRTUALENVWRAPPER_SCRIPT
VIRTUALENVWRAPPER_HOOK_DIR
_
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PIP_SHIMS_BASE_MODULE
PIP_PYTHON_PATH
PYTHONFINDER_IGNORE_UNSUPPORTED

Pipenv–specific environment variables:
Debug–specific environment variables:

PATH: /usr/local/opt/python/libexec/bin:/usr/local/opt/icu4c/sbin:/usr/local/opt/icu4c/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/abartlett/Library/Python/3.7/bin:/Applications/MacVim.app/Contents/bin
SHELL: /usr/local/bin/zsh
EDITOR: mvim -f --nomru -c "au VimLeave * !open -a iTerm2"
LANG: en_AU.UTF-8
PWD: /Users/abartlett/src/relist/backend

Anyone know if this is still considered an issue or if it has been resolved?


Turning on support for Curve x25519 w/ ECC curve configurations

Please note that while we are transitioning from travis-ci to AWS CodeBuld, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Issue # (if available):
https://github.com/awslabs/s2n/issues/1540
Description of changes:
Allowing different ECC curve configurations and turning on support for Curve x25519
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This PR is pending merge from https://github.com/awslabs/s2n/pull/1690

Codecov Report

Merging #1693 into master will decrease coverage by 0.12%.
The diff coverage is 94.18%.

@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
- Coverage    81.2%   81.07%   -0.13%
==========================================
  Files         220      221       +1
  Lines       16033    16080      +47
==========================================
+ Hits        13019    13037      +18
- Misses       3014     3043      +29

LGTM with respect to the recent changes in #1690.


ORC-519: Correct encoding for Decimal columns in specification

Currently the ORC specifications state that the secondary stream of
decimal columns are Unsigned RLE, but according to the code (both
Java and C++), Signed RLE is used.

@luksan47 Can you please also add the fix to ORCv0.md? Thanks!

@wgtmac Done.


  at Socket.<anonymous> /node_modules/gm/lib/command.js:57:17)

Env 👍
1. OS : OSX  10.11.6
2. Npm: 4.0.1
3. Node 6.2.1
Error 👎
[ Error: Stream yields empty buffer
      at Socket.<anonymous> (/Users/hamma/test-img-console/node_modules/gm/lib/command.js:57:17)
      at emitNone (events.js:91:20)
      at Socket.emit (events.js:185:7)
      at endReadableNT (_stream_readable.js:926:12)
      at _combinedTickCallback (internal/process/next_tick.js:74:11)
      at process._tickCallback (internal/process/next_tick.js:98:9),
  Error: Could not execute GraphicsMagick/ImageMagick: gm "identify" "-ping" "-format" "%wx%h" "-" this most likely means the gm/convert binaries can't be found
      at ChildProcess.<anonymous> (/Users/hamma/test-img-console/nodejs-plugins/console-img/node_modules/gm/lib/command.js:232:12)
      at emitOne (events.js:96:13)
      at ChildProcess.emit (events.js:188:7)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:202:12)
      at onErrorNT (internal/child_process.js:348:16)
      at _combinedTickCallback (internal/process/next_tick.js:74:11)
      at process._tickCallback (internal/process/next_tick.js:98:9) ]

Is it happening for all the images or for a specific image only? If it's the later, can you please upload the image?

Did you install the perquisite?
$ sudo apt-get install graphicsmagick # Ubuntu
$ brew install graphicsmagick         # Mac OS X

Shouldn't the lwip fallback prevent this?

@m59peacemaker It should the lwip fallback should prevent the spawn error (ENOENT command not found ..., or so). It's very hard to tell why does this problem appear at all, because we have no example when it fails like that.
The OP seems to have GraphicsMagick already installed.
Did it happen to you as well?

I did originally get the same error as the OP. I'm not sure whether I had graphicsmagick installed, but I thought I didn't and so went ahead installed it without checking first (oops). The same error remained. I just purged graphicsmagick and reinstalled image-to-ascii globally, now the error is simply error spawn gm ENOENT. I was just checking out the package. I don't have a stake in getting it working, but I hope my notes help.

@m59peacemaker Thanks for that! I will look into that error when getting a little bit of time. Sounds like lwip is not used...

I reproduced this error on my machine. I'm on it.

@m59peacemaker @abdennour For my information—did you receive any errors during the installation?
You can double-check by running rm -rf node_mdoules && npm install

The installation should fail if lwip fails to be installed.
Addressed in https://github.com/IonicaBizau/lwip2/pull/16.
The reason for the error was: in case gm is not available, lwip is installed (and compiled). In case the required tools for compilation are missing (e.g. XCode or so), lwip installation was failing silently. Now that error should block the image-to-ascii installation. 💥


Prototype implementation DaskDataSet wrapper class

This follows on from https://github.com/LiberTEM/LiberTEM/pull/1136 as a wrapper for Dask arrays which makes them compatible with the normal UDF interface. There are no modifications to current LiberTEM master, only a new dataset implementation.
The dataset builds LiberTEM partitions out of the existing Dask chunks, applying a merge-only strategy to avoid read amplification while making the chunk structure compatible with the existing LiberTEM Partition interface (and everything which goes with that). The major assumption for efficient performance of this class is that the chunks in the Dask array can all be computed individually without incurring upstream read amplification.
A major design factor was the fact that Partitions currently have to be contiguous in the flattened nav dimension, so if the Dask array is blocked in more than one nav dimension we are obliged to do a lot of merging (except when all higher nav dimensions are chunked like (1, 1, 1, 1, ...)). If we ever lift this requirement then this class could be made a lot more efficient.
See the accompanying notebook and the docstrings for more detail.
Contributor Checklist:

[x] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[x] I have added/updated documentation for all user-facing changes
[x] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if changes were made to the GUI)

Reviewer Checklist:

[ ] /azp run libertem.libertem-data passed

By the way, with math.prod() vs np.prod() I decided it is time to fix this for good: https://github.com/LiberTEM/LiberTEM/pull/1145

@matbryan52 I'll take care of a HyperSpy integration example now, if that suits you!

@matbryan52 I'll take care of a HyperSpy integration example now, if that suits you!

Of course, I'm looking into the HDF5 question for now.

@matbryan52 the example triggers a warning we should look into:

dask_ds = ctx.load("dask", lazy_4d.data, sig_dims=2)
pick_a = ctx.create_pick_analysis(dataset=dask_ds, y=45, x=60)
pick_res = ctx.run(pick_a)

c:\users\dwebe\.conda\envs\libertem\lib\site-packages\distributed\worker.py:3877: UserWarning: Large object of size 215.36 MiB detected in task graph:
  (<UDFTask [<class 'libertem.udf.raw.PickUDF'>]>, ' ... 528e80d7ef', 0)
Consider scattering large objects ahead of time
with client.scatter to reduce scheduler burden and
keep data on workers

    future = client.submit(func, big_data)    # bad

    big_future = client.scatter(big_data)     # good
    future = client.submit(func, big_future)  # good
  warnings.warn(

200 MB is about the size of the dataset. Perhaps it gets baked into the Task somehow?

Soon it will be possible to keep wrapping the same data in an infinite loop?

Would be a good test for overheads! :-)

Do you want me to try to debug it or are you already on it?

Maybe you can have a look first? I have to leave now. It feels like the ROI may have something to do with it. Otherwise we can look together next week. :-)

OK, I'll see if I can reproduce it in a more minimal example.

OK, I'll see if I can reproduce it in a more minimal example.

https://gist.github.com/matbryan52/f2a092d6706e9dd28e52d1d8e0de0b0d
After looking through the code, the gist there pretty much reproduces what the current combination of Hyperspy+LiberTEM does, generating the same error.
Dask has a doc note about it: https://docs.dask.org/en/latest/array-creation.html#memory-mapping
I'm not sure there is a good way to get around this. There are hacky solutions like trying to re-create the memmap on each worker using the np.memmap.filename attribute, but actually if the object has already been wrapped as a dask array I think the information is lost anyway! I'm kind of surprised there is no Dask-provided memmap-based array creation routine which is backed by dask.delayed. I will look more into why this is.

Dask has a doc note about it:

Nice that you found it! https://github.com/dask/dask/pull/7380 https://github.com/dask/dask/issues/7355 😄

I'm not sure there is a good way to get around this.

Since we can't control what people do in their code and it "works for them"™ with the default threaded Dask executor, we can consider adding a threaded executor for single-host setups, for example based on concurrent.futures. We can even consider making it the default if it works well. That way we'd be more tolerant to Dask arrays that are inefficient on a multiprocess cluster.

the gist there pretty much reproduces what the current combination of Hyperspy+LiberTEM does, generating the same error

Yes, it really seems so. Here's how it happens as an overview:
BLO reader returns a read-only memory map
https://github.com/hyperspy/hyperspy/blob/b5815c01d303d6598484d97096622708b38e41e0/hyperspy/io_plugins/blockfile.py#L180-L297
Hyperspy reading seems to be indirected here to a specific Signal sub-class
https://github.com/hyperspy/hyperspy/blob/b5815c01d303d6598484d97096622708b38e41e0/hyperspy/io.py#L663-L738
LazySignal seems to use the same arguments in the constructor and attributes as BaseSignal:
https://github.com/hyperspy/hyperspy/blob/707e1f96d39bef369a4d5ed6b65e226c4d69e025/hyperspy/_signals/lazy.py#L87-L92
https://github.com/hyperspy/hyperspy/blob/707e1f96d39bef369a4d5ed6b65e226c4d69e025/hyperspy/signal.py#L2133-L2169
to_array(), finally, seems to turn things into a Dask array with dask.array.from_array():
https://github.com/hyperspy/hyperspy/blob/707e1f96d39bef369a4d5ed6b65e226c4d69e025/hyperspy/_signals/lazy.py#L49-L84

The BLO reader would probably be rather easy to fix: With lazy=True, just return a Dask array with memory-mapped delayed chunks like in https://docs.dask.org/en/latest/array-creation.html#memory-mapping
In any case, LiberTEM should also work with dask.array_from_array(numpy.memmap(...)), and that means using a threaded executor.

Let me know if I can help with anything for this PR - now that #1149 has landed, a few details might need to be changed. I could take care of rebasing onto master, if that makes sense. Let me know!

@matbryan52 I had a look at the I/O backend part of this PR and it looks good to me.

Thanks for taking a look! at least we're using the standard memmap backend now.
One of the commits I've pushed 57c22c5 is actually a note about a potential problem with the backend if the Dask array happens to be Fortran-ordered. Apparently np.frombuffer cannot read from a f-ordered array and just throws a ValueError. I originally added an np.ascontiguousarray to the open method but this can cause memory problems on the worker as we're forced to make a copy. For now I've just left it because I think it's an edge case. I was able to reproduce it by doing the following, though:
import numpy as np
import dask.array as da
import libertem.api as lt

if __name__ == '__main__':
    with lt.Context() as ctx:
        dar = da.ones((20, 100, 512, 512), chunks=(2, -1, -1, -1), dtype=np.float32)
        ds = ctx.load('dask', dar, sig_dims=2)
        pick_a = ctx.create_pick_analysis(dataset=ds, y=4, x=27)
        pick_res = ctx.run(pick_a)

In _adapt_chunking, maybe the log level should be "warn" in case we hit a pathological perf case?

I have pushed this change.

Btw. the restriction of only allowing whole signal frames per partition will probably lifted soon (see for instance #1025), which may help with some weird chunking configurations.

That will be great to remove, the more chunking flexibility the better, really.

Let me know if I can help with anything for this PR - now that #1149 has landed, a few details might need to be changed. I could take care of rebasing onto master, if that makes sense. Let me know!

Could you explain what you have in mind about what might need to be changed? The partition layout is constrained here by the array backing the DS, so we have a bit less flexibility than usual to re-partition optimally. We could of course adapt the partition merging (if any) so that we get a good tiling scheme, based on the ROI, of course, but that might be quite complex.

(https://github.com/matbryan52/LiberTEM/commit/57c22c5580e633b2a049cf047bae683370450fce) is actually a note about a potential problem with the backend if the Dask array happens to be Fortran-ordered. Apparently np.frombuffer cannot read from a f-ordered array and just throws a ValueError. I originally added an np.ascontiguousarray to the open method but this can cause memory problems on the worker as we're forced to make a copy. For now I've just left it because I think it's an edge case. I was able to reproduce it by doing the following, though:
import numpy as np
import dask.array as da
import libertem.api as lt

if __name__ == '__main__':
    with lt.Context() as ctx:
        dar = da.ones((20, 100, 512, 512), chunks=(2, -1, -1, -1), dtype=np.float32)
        ds = ctx.load('dask', dar, sig_dims=2)
        pick_a = ctx.create_pick_analysis(dataset=ds, y=4, x=27)
        pick_res = ctx.run(pick_a)

I think we can leave this as an open issue for now - we will notice if this happens more often than we think. It could be fixed by calling a method on the MMapFile instead of using np.frombuffer - this method could be overridden by your FakeDaskMMapFile. Although I haven't tested what happens in the I/O code when it is presented with an 'F'-order array...

In _adapt_chunking, maybe the log level should be "warn" in case we hit a pathological perf case?

I have pushed this change.

:+1: thx!

Could you explain what you have in mind about what might need to be changed?

Because the TilingScheme is now calculated once per DataSet (with an approx. partition size as input), some methods have moved from Partition to DataSet:

Partition._get_decoder is moved to DataSet.get_decoder
Partition.need_decode is moved to DataSet.need_decode - that uses DataSet.get_io_backend, so you may need to move your get_io_backend impl to DaskDataSet
The Decoder needs to be passed to the Partition in DataSet.get_partitions (to have a single point, in the DataSet, where the Decoder is constructed

That should be all changes required. The reasoning for moving these methods is that we need to know if we are decoding/copying for choosing the right tile size (it can be much larger if we are working directly on mmapped data vs. if we need to decode into an intermediate buffer) - and for that we need to instantiate the IO backend, together with the Decoder.

The partition layout is constrained here by the array backing the DS, so we have a bit less flexibility than usual to re-partition optimally. We could of course adapt the partition merging (if any) so that we get a good tiling scheme, based on the ROI, of course, but that might be quite complex.

I think this is mostly important for the next step, when we do adaptive partition sizing (this is work in progress). If we can get this PR merged before that, I can take care that this is properly handled.

The test "failure" (hang) looks unrelated - I'll push an increase of the timeout into your branch (and mark the thread as daemon thread, so it doesn't keep the main thread from exiting if it hangs for some reason)

/azp run libertem.libertem-data

/azp run libertem.libertem-data

This should now be ready to be merged, correct? Would you be fine with me squashing the commits into one? We usually try to keep the commit history linear (by rebasing instead of merging the upstream master branch) - that's maybe something for the contribution docs, too...

This should now be ready to be merged, correct? Would you be fine with me squashing the commits into one? We usually try to keep the commit history linear (by rebasing instead of merging the upstream master branch) - that's maybe something for the contribution docs, too...

Of course, whatever you normally do. I tend to make a lot of small commits when I work but it makes for a very long PR I know!

Thanks, merged!

🎉 🎉 🎉 Congratulations, a major milestone for LiberTEM! :-)


DOC-5336 12 new repl metrics

Addresses: DOC-5336

Added 12 new repl queue metrics to metric-names.md

Question:

Do you know if these metrics also available for Serverless? If so I need to also add them to metric-names-serverless.md. Post v22.2 GA, DOCs has a method for automatically determining this, but it is not ready yet. Guess: not for Serverless at present time.

Staging:

metric-names.md

This change is

Hi @AlexTalks friendly ping on this review, or please let me know if there is another engineer you would prefer I reach out to. Thank you!

@AlexTalks Friendly ping on this PR, we'd like to get GA docs live for GA. Feel free to send off to another engineer if preferred. Thanks much!

@thtruo , can you help me find an engineer to review this? Thanks -- sorry to bother.

@kvoli since you were involved in the upstream PR, mind taking a look at this doc PR?


Start new rollouts when secrets or configuration changes

With Ansible it should be possible to register when a secret or configuration was changed in the cluster. Register these changes when they happen and force a new rollout of the deployments which depend on them.
This should save us the time to start rollouts manually, when all that a make deploy does is to update some secrets or configs.

Do you perhaps have some link(s)?
Is it something like notify & handlers?

Do you perhaps have some link(s)? Is it something like notify & handlers?

Indeed, it is. Thanks for providing the link!

As for the current state of secrets, only the Sentry DSN (which we do not rotate that frequently) and Copr (which has an indefinite expiration right now) token cannot be used with the older secrets at the same time.
On Monday we did a quite seamless renewal of TLS certs, I renewed TLS, @lachmanfrantisek moved the production and redeployed. There was no need to immediately rescale to update to the latest tokens.
IMO currently the benefits do not outweigh the cost of adjusting the deployment. Therefore after the discussion on today's stand up, closing this issue for now. We can reopen if needed.


Form error

Adds a simple form error class that modifies some things from the
wds input error class.
Also defines two variables for warning and error color, which are
currently the same value.

Well, there's nothing in here that looks out of the ordinary. As long as it exists for a reason, it works for me.


Swift 2.2 - Xcode 7.3 support

Current coverage is 60.89%

Merging #243 into master will not affect coverage as of 406fb5d

@@            master    #243   diff @@
======================================
  Files           48      48
  Stmts         1565    1565
  Branches         0       0
  Methods
======================================
  Hit            953     953
  Partial          0       0
  Missed         612     612

Review entire Coverage Diff as of 406fb5d

Powered by Codecov. Updated on successful CI builds.


[Bug] Unused variable error happens when it used

🐛 Bug
I'm trying to compile module contains while loop and variable defined before loop. Each iteration i change variable value.
Yet i'm getting error and it seems a compiler bug.
To reproduce
module 0x1::Bug {
    public fun loop_over() {
        let i = 0;
        let something = 604800;
        let my_counter = 0;

        while (i < 100) {
            my_counter = something * i;

            if (my_counter > 100) {
                // do something
            };

            i = i + 1;
        }
    }
}

I got an error during compilation:
warning[W09003]: unused assignment
  ┌─ ./sources/Bug.move:5:13
  │
5 │         let my_counter = 0;
  │             ^^^^^^^^^^ Unused assignment or binding for local 'my_counter'. Consider removing, replacing with '_', or prefixing with '_' (e.g., '_my_counter')

Expected Behavior
I understand i can do let my_counter = something * i; in the start of each loop iteration instead of define counter before loop, yet i think my initial example should compile or show some explained error/warning.
Additional Context
I'm using Aptos CLI 0.1.2.

A bad error message, but it is finding something! The initial value is not used, so you could have let my_counter;

Hi @tnowacki ,
Yeah, right, but still i think error message should be fixed, the rustc showing me something like:
warning: value assigned to `my_counter` is never read

IMHO, much more clear


Disambiguate dataset name vs service name

Rate limits apply to datasets
Datasets match with upstream topic names
If datasets specify service names then match those from the record

Closing as this was addressed in https://github.com/slackhq/kaldb/pull/405 and has already been merged! :shipit:


Remove develop branch

Moving to master branch + branching + squash-merges moving forward.
Gitflow is fine, but for this OSS repo, doesn't really add value.

Done.


Added Whisper system for talking with players 2 tiles away.

About the PR
Feature request #5987 asks for a Whisper chat function. Whisper chat functions just like local however only gets broadcast to players within 2 tiles of each other.

[x] Implement Whisper functionality
[x] Add custom Whisper channel and filter
[x] Make whisper behave as it did in SS13. Players 7 tiles away (the default range) should still hear some of the message, however it is obfuscated with random characters to make the message hard to understand.

Screenshots

Changelog

:cl: MeltedPixel

add: Added Whisper chat functionality

Looks like I have a build error with the addition of Octothorp, or #.

I guess this is ready for a code review. First real one, be gentle.

add: Whisper chat functionality

FYI "add" is for the image so this will just appear as "Whisper chat functionality" in the changelog.

All change requests have now been squashed.

Looks good. If someone else could review this, that'd be great. I've been looking at it too long, so I'm not sure if I caught everything.


Unable to set system theme if you enable dark/light manually

Is your feature request related to a problem?
If I manually switch the theme, I can't get the system theme back, which can be inconvenient
Describe the solution you would like
Usually, the theme switch has three states:

Dark theme
Light theme
Automatic theme (taken from the system).

Describe alternatives you have considered
No response
Screenshots
No response
Are there opened related issues?
No response

If I manually switch the theme, I can't get the system theme back, which can be inconvenient

isn't it excepted result?
Let take for example a case:

user has dark mode in browser preference
first navigation on Kodadot -> should be dark ✔
change to light mode because user like Kodadot light mode ✔
now user close brower, and when reopen Kodadot should be light mode instead of browser preference

We have to save the selected theme locally

nuxt-color-mode handle this
What's your concern with the theme feature? we've never had a problem with it, don't loose to much time focus on something derisory


bug: Initital controller called twice on Android

Type: bug
Platform: android 4.4 webview
The initial controller is called twice on Android but not on the browser.
Set up like so:
  .state('app.map', {
      url: "/map/:shopId",
      cache: false,
          'tab-shops': {
              templateUrl: "templates/map.html",
              controller: "MapCtrl"
          }
      }
  })
$urlRouterProvider.otherwise('/app/map/init');

And need to have this hack to prevent the app to initgialize twice. But only on the device:
if (typeof $scope.init !== 'undefined' || $scope.init) return;</span>

We are not seeing on our testing apps. Can you share a functional codepen or sample project that we can test against?

We have the same issue here.

Greetings @psimondk!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.

Greetings @psimondk!
My sensors indicate a reply was requested, but we have not received one yet, I am using my robot powers to close this issue. However, if you are still experiencing this issue, please feel free to reopen it by creating a new issue, and include any examples or necessary information.
Thank you for allowing me to assist you.

can we reopen this one? :)


Just not exported

Have the following line in code:
import Data.Maybe (Maybe(Just, Nothing))

But compiler emits javascript with missed Just:
(function(exports) {
  // Generated by psc version 0.10.6
  "use strict";
  var Prelude = PS["Prelude"];
  var Control_Alt = PS["Control.Alt"];
  var Control_Alternative = PS["Control.Alternative"];
  var Control_Extend = PS["Control.Extend"];
  var Control_MonadZero = PS["Control.MonadZero"];
  var Control_Plus = PS["Control.Plus"];
  var Data_Functor_Invariant = PS["Data.Functor.Invariant"];
  var Data_Monoid = PS["Data.Monoid"];
  var Data_Functor = PS["Data.Functor"];
  var Control_Apply = PS["Control.Apply"];
  var Control_Applicative = PS["Control.Applicative"];
  var Control_Bind = PS["Control.Bind"];
  var Control_Monad = PS["Control.Monad"];
  var Data_Semigroup = PS["Data.Semigroup"];
  var Data_Eq = PS["Data.Eq"];
  var Data_Ord = PS["Data.Ord"];
  var Data_Ordering = PS["Data.Ordering"];
  var Data_Bounded = PS["Data.Bounded"];
  var Data_Show = PS["Data.Show"];
  var Data_Unit = PS["Data.Unit"];
  var Data_Function = PS["Data.Function"];
  var Control_Category = PS["Control.Category"];
  var Nothing = function Nothing() {

  };
  Nothing.value = new Nothing();
  function Just(value0) {
      this.value0 = value0;
  };
  Just.create = function (value0) {
      return new Just(value0);
  };
  exports["Nothing"] = Nothing;     // <------------------------ ONLY Nothing here
})(PS["Data.Maybe"] = PS["Data.Maybe"] || {});

I have this purescript input:
module Main where

import Prelude (Unit, bind, unit, (<>))
import Control.Monad.Eff (Eff)
import Control.Monad.Eff.Console (CONSOLE, log)
import Data.Maybe (Maybe(Just, Nothing))

import Web.Cookies (COOKIE, setCookie, getCookie)

main :: forall e. Eff (cookie :: COOKIE, console :: CONSOLE | e) Unit
main = do
     setCookie "_cookie" 123 unit
     c <- getCookie "_cookie"
     let st = case c of
                Just cook -> "Have cookie: " <> cook
                Nothing -> "No cookies"
     log st

compiled to this js output: https://gist.github.com/Zert/f35f03d2c3187cd970edb6e7e7ec98b4
Missed Just export causes an error:
prepare — output.js:292:101TypeError: undefined is not a constructor (evaluating 'new Data_Maybe.Just(v[0])')

:scream: This is a bug in PS 0.10.6, please downgrade to 0.10.5 now. I've opened an issue on the compiler repo: https://github.com/purescript/purescript/issues/2642


Unable to find sanitizer called 'x.y'

I have a Django 1.8 project for which I'm trying to configure django-sanitized-dump. I've followed the steps in readme and read how the imports are resolved but couldn't get the create_sanitized_dump command to work properly. All I get is the following ConfigurationError:
root@2e57134ba7a2:/code# python manage.py create_sanitized_dump > dump.sql
Traceback (most recent call last):
  File "/usr/local/bin/database-sanitizer", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.5/site-packages/database_sanitizer/__main__.py", line 48, in main
    config = Configuration.from_file(args.config[0])
  File "/usr/local/lib/python3.5/site-packages/database_sanitizer/config.py", line 45, in from_file
    instance.load(config_data)
  File "/usr/local/lib/python3.5/site-packages/database_sanitizer/config.py", line 65, in load
    self.load_sanitizers(config_data)
  File "/usr/local/lib/python3.5/site-packages/database_sanitizer/config.py", line 150, in load_sanitizers
    sanitizer_callback = self.find_sanitizer(sanitizer_name)
  File "/usr/local/lib/python3.5/site-packages/database_sanitizer/config.py", line 230, in find_sanitizer
    name,
database_sanitizer.config.ConfigurationError: Unable to find sanitizer called 'user.first_name'

The (dumbed down) project structure is as follows:
foobar/
    __init__.py
    forms.py
    models.py
    urls.py
    views.py
sanitizers/
    __init__.py
    generic.py
    user.py
manage.py
.sanitizerconfig

sanitizers/generic.py
from datetime import datetime
from django.utils import timezone

def sanitize_tz_aware_datetime(value):
    dt = datetime(year=2018, month=1, day=1, hour=12, minute=0, second=0)
    return timezone.make_aware(dt)

sanitizers/user.py
from faker import Faker

fake = Faker()

def sanitize_email(value):
    return fake.email(domain='example.com')

def sanitize_first_name(value):
    return fake.first_name()

def sanitize_last_name(value):
    return fake.last_name()

def sanitize_username(value):
    return fake.user_name()

.sanitizerconfig (relevant parts)
config:
  addons: []
strategy:
  auth_user:
    date_joined: generic.tz_aware_datetime
    document: null
    email: user.email
    first_name: user.first_name
    groups: null
    id: null
    image: null
    is_active: null
    is_staff: null
    is_superuser: null
    last_login: generic.tz_aware_datetime
    last_name: user.last_name
    logentry: null
    owned_pages: null
    pagerevision: null
    password: null
    user_permissions: null
    username: user.username
    userprofile: null

Yeah, the problem is that the user.name part does not exist currently. It is just written as an example. With the latest version of database-sanitizer that was release today there are some sanitizers build in however, so you can now do user. sanitize_username or user.username I'm not 100% sure which one will work correctly, try it out :)
These functions were added (might need the sanitize_ prefix):
email
username
full_name_en_gb
given_name_en_gb
surname_en_gb

random_past_timestamp

I running pip install -U database-sanitizer so that you get these :)

Adding sanitize_ prefix has no effect.
Just to clarify the import fails on each one of the sanitizer functions. I.e. if I change all user.first_name to null it will fail on generic.tz_aware_datetime instead and if I replace that one it will fail on one of the remaining functions.

Could it be a pathing issue.. can you try running database-sanitizer -c .sanitizerconfig postgres://user:password@host/database ?

Same error with that one. The issue seems to be related to the underlyingpython-database-sanitizer package instead of this Django wrapper.

It does indeed, mind create a issue there as well pointing to this for instance?

Sure 👍

Thanks! 👍

Fixed long ago in https://github.com/andersinno/python-database-sanitizer/issues/13


chore: Refactor binary and math expression serde code

Which issue does this PR close?

N/A
Rationale for this change

Follows on from https://github.com/apache/datafusion-comet/pull/1065
What changes are included in this PR?

How are these changes tested?

Thanks @andygrove @kazuyukitanimura


[TF-TRT QAT Explicit precision] Assertion outScales.size() == 1 when converting QAT TF model

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
2.9
Custom Code
Yes
OS Platform and Distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I am currently working through supporting TF-TRT with explicit quant / dequant nodes, and am in the final stages of making it work. Here is a summary of the fixes I landed:

Implement a explicit convert for FakeQuantWithMinMaxVars keras API
Support Conv2D with a tensor input in explicit conversion (transpose 2nd input to KCRS format) to be compatible with TRT conv layer

The conversion actually runs through, but I get an error when building the engine almost immediately:
Internal Error (Assertion outScales.size() == 1 failed. )

Standalone code to reproduce the issue
I am building the code from a custom TF-TRT branch off of r2.9, with minimal non-breaking changes. I can clean up my changes and open a PR on r2.9 so people can understand the changes better.
Relevant log output
W20230329 16:29:04.094142 99658 quantization_ops.cc:309] FakeQuantWithMinMaxVars has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.
W20230329 16:29:04.138859 99658 quantization_ops.cc:309] FakeQuantWithMinMaxVars has narrow_range=true, but for TensorRT conversion, narrow_range=false is recommended.
E20230329 16:29:05.544306 99658 convert_nodes.cc:7274] use_explicit_precision: 1
E20230329 16:29:05.544360 99658 convert_nodes.cc:7280] Build cuda engine
E20230329 16:29:05.545313 99658 convert_nodes.cc:1287] Setting TensorRT network name to TF:2.9.1, TRT:8.5.1-Precision:INT8, Calibration:0, Max-Batch-Size:1, Max-Workspace-Size:4294967296
E20230329 16:29:12.417982 99658 trt_logger.cc:40] DefaultLogger 2: [pointWiseV2Builder.cpp::toExpr::279] Error Code 2: Internal Error (Assertion outScales.size() == 1 failed. )
W20230329 16:29:12.464977 99658 trt_engine_op.cc:1047] TF-TRT Warning: Engine creation for TRTEngineOp_000_000 failed. The native segment will be used instead. Reason: INTERNAL: Failed to build TensorRT engine
W20230329 16:29:12.465102 99658 trt_engine_op.cc:888] TF-TRT Warning: Engine retrieval for input shapes: [[1,7,12], [1,7,15], [1,7,12], [1,6,5,550400], [7,3,1208,1920], [1,15,1,1]] failed. Running native segment for TRTEngineOp_000_000

Following up from this issue: https://github.com/tensorflow/tensorflow/issues/59711
It can possibly help solve both.

Third update: The issue was resolved by ensuring that narrow_range=False on the tensorflow side, and retraining the QAT model with that setting. The warning should be an error on the TF-TRT side. I will close this issue as I no longer need support.


Update index.md

Updating index.md,
Deleting brackets that did not do any function

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@Santosf5, everything LGTM! Thank you for helping us improve this section of the guide. Congratulations on your first contribution to freeCodeCamp! Looking forward to your next contribution! :+1: :+1:


pm: device_runtime: pm_device_request can block forever

Describe the bug
The core runtime power management function pm_device_request can hang forever with a small amount of bad luck.
The core actions taken by this function are:
	(void)k_work_schedule(&dev->pm->work, K_NO_WAIT);
	(void)k_condvar_wait(&dev->pm->condvar, &request_mutex, K_FOREVER);

The nuance is that the condvar API only unblocks threads that are currently blocked, there is no persistent state like k_poll_signal. What this means is that if the thread calling pm_device_request  is interrupted between the two function calls above, it is possible (and even likely, given that the system work queue runs at priority -1) that the submitted work item completes (calling k_condvar_broadcast) before the submitting thread blocks on the condvar.
As a result, the original call to pm_device_request won't return (unless a second thread also runs pm_device_request on the same device at a later time).
To Reproduce
Simulate another thread interrupting the calling thread by updating pm_device_request to contain:
	(void)k_work_schedule(&dev->pm->work, K_NO_WAIT);
	k_sleep(K_SECONDS(1));

Build and run the device power management sample: samples/subsys/pm/device_pm
*** Booting Zephyr OS build v2.6.0-rc1-244-gaa78a6473b16  ***
Device PM sample app start
open()
parent resuming..

Expected behavior
The power management functions should be robust in the face of arbitrary interrupts and rescheduling.
Environment (please complete the following information):

Zephyr v2.6-rc1

@ceolin

You're absolutely right, I noticed it this week. This pr fixes it https://github.com/zephyrproject-rtos/zephyr/pull/35315
This commit https://github.com/zephyrproject-rtos/zephyr/pull/35315/commits/1039186d730d2c71cd92ab90c38965745a1adec8, in particular, introduces a function to wait correctly on the codvar


with.repository parameter is unable to access external repository: "The requested URL returned error: 403"

Use Case
I am attempting to use jekyll-deploy-actions for the following use case:

I have a private repository that I use for taking notes and writing blog posts using Jekyll
I want to publish using GitHub pages, though don't want to pay for the premium subscription (required for publishing from a private repository)
Instead, I'd like to use this action and the with.repository argument to push the pages bundle to a public repository that can then publish via GitHub pages for free

Workflow Definition
Here is the definition of my GitHub workflow (from the private repository), which is configured according to the README:
name: Deploy Github Pages

on:
    push:
        branches:
            - main
        paths:
            - .github/workflows/build-jekyll.yml
            - Website/**

jobs:
    build-and-deploy:
        runs-on: ubuntu-latest
        steps:
            - uses: actions/checkout@v2

            - uses: jeffreytse/jekyll-deploy-action@master
              with:
                  branch: main
                  provider: github
                  repository: cwboden/website
                  token: ${{ secrets.GITHUB_TOKEN }}

When this Workflow runs, it completes the build / bundling process successfully, but fails when attempting to push to my public repo:
remote: Permission to cwboden/website.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/cwboden/website.git/': The requested URL returned error: 403

I initially thought this was a problem with the secrets.GITHUB_TOKEN, so I also added a PAT to the repository under the secret GH_TOKEN (as outlined in the README):

However, I end up with the same error :cry: I'm curious if the with.repository parameter is only supported by SSH authentication?
Other Troubleshooting Attempts
I also tried a few other things, such as replacing the with.token parameter with $GH_TOKEN (though then the build step cannot complete), using a Legacy GitHub PAT rather than the granular ones, and by removing the authorization headers, according to this Stack Overflow post.
None of these have helped, though I can update this section as I continue troubleshooting the problem. My next step will be to take a look at how GH_TOKEN is used within the plugin source code. Perhaps I'm missing something there.

Hi @cwboden
Thanks for the issue, for your case, you should follow below steps:

Set up this action in your private repository.
Set with.repository to your public repository.
Create a new secret GH_TOKEN in your public repository.
Set with.token to ${{ secrets.GH_TOKEN }} or set with.ssh_private_key to ${{ secrets.SSH_PRIV_KEY }}.
Try to build again

Thanks & Regards

Thanks for the prompt response! Looks like this one was user error -- I must have misconfigured my PAT token so that it didn't have the correct permissions. I walked through your steps above and everything is working now. Appreciate the help!


ColorPickerDelegate

func colorPicker(_: ColorPickerController, confirmedColor: UIColor, usingControl: ColorControl) {
}
This Delegate Method will not call Please suggest me..

That is only called when user taps the preview control to confirm the color choice. You probably want to use the other delegate method to keep track of changes as they are happening. read in code documentation of the delegate and its methods for details.

Hi,
Actually i want the color when i am complete the selection.


Add support for PUT and DELETE requests

For PUT requests, the library will parse both the x-grpc-route-data and x-grpc-body-data upstream headers and merges them into a single JSON object to be sent to the appropriate gRPC service. For DELETE requests, the parser for GET requests is used (where only x-grpc-route-data is parsed).
To help test these new features, I've added an UpdateProduct method and a DeleteProduct method in the Product gRPC service. The Ocelot configuration and appsettings in the OcelotGateway sample project have also been updated to recognise these new methods. The methods can be accessed by making a PUT or DELETE request to /products/{id}.
Closes #6.

I have merged it with the new version. Thank you for your contribution


Mod is not working at all...

Ive now tried to use the mod with only what it depends on and it doesnt work...

I am going to create a pull request please accpet it i fixed both of the issues i brought up

also sorry if your going to have to change a little bit of the pr as i had a bit of trouble getting the mod building on my pc so yeah

Issue has been identified to be caused by a defect in the LethalCompany Input Utils.
Fixed in version 0.0.4


Prototype user name/icons app

Goals:

Central user manifest should have account name, display name, role/position, arbitrary badge names.
It should allow overwriting of display name from central manifest to "add" role/position.
It should allow adding arbitrary badges floating above user head.

Support:

May require flag on account scene permissions to allow overwriting of display name.

I've started work on this.


Make it possible to force open the dropdown in a specified direction

In our project we had the specific case that our client wanted the dropdown to only open on south / north, even if there's no space anymore to display all the suggestions there.

This has come up a few times, and there does not appear to be any interest in putting it in the core.

There are like 10 issues about this exact problem, if not more. What do you mean "there is no interest"? I mean, it's your library and you can do whatever you want with it, but it's pretty obvious that a lot of people need this functionality.


nginx-ingress-controller failure to retrieve page relative resources

Maybe I'm getting this wrong, but the base-url should be constructed from matched path instead of rewrite target.
Problem description:
Ingress rule:
path = "/p"
rewrite-target = "/"
add-base-url = true

How it works:
base-url=protocol://host/target => http(s)://some.host/

css/test.css becomes http(s)://some.host/css/test.css (ingress rule is not matched anymore)

How it should work:
base-url=protocol://host/target => http(s)://some.host/p

css/test.css becomes http(s)://some.host/p/css/test.css (matches the ingress rule and URL is rewritten to /css/test.css for the backend to be loaded correctly)

If a path "/p" is matched by the ingress rule, the backend is rewritten to /, but the resources should still be pulled by /p/ from the browser point of view, otherwise there is no matching path in ingress rule.

I've also enabled the annotation:
ingress.kubernetes.io/add-base-url: "true"
I see something very similar. The current implementation does not seem to address the underlying probelm at all.


Release 4.3.0

@TECH7Fox, just to let you know I am not planning on continuing maintaining after this release. I personally lost the interest on Asterisk and prefer using alternatives like go2rtc for 2-way audio.

@TECH7Fox, just to let you know I am not planning on continuing maintaining this add-on after this release. I personally lost the interest on Asterisk and prefer using alternatives like go2rtc for 2-way audio.

I understand. Thank you for all your help with this project! Hope to see you around on Discord and forums. 🫡


WDL Memory Override for WhamG

Now this is a story, all about how
My GATK-SV run got flip turned upside down
And I'd like to take a minute
Just sit right there
I'll tell you how I'm trying to override the default memory setting used here

See https://batch.hail.populationgenomics.org.au/batches/425063/jobs/2 - OOM error running WHAMg on CPG264531 (This sample doesn't seem to be a particular outlier size-wise, but has failed ~3 times on the bounce so this appears deterministic)
Since #383 a canonical place for "I want this default setting to behave differently" is get_config()['resource_overrides']
Failing Stage starts here

I'd like to shove a new setting into the input dictionary, here that's runtime_attr_wham
this be passed to the Wham WDL
the name changes (because who cares about consistency)
memory is automatically determined here based on various metrics
that can be overridden by passing mem_gb through in the override dict

Looks plausible to me, I'm not super familiar with RuntimeAttr and whether it needs a spicy 🌶 structure above + beyond a dictionary.
From the Cromwell metadata on the failed run I see the current params as
"runtime_attr": {
    "cpu_cores": 1,
    "max_retries": 1,
    "boot_disk_gb": 10,
    "disk_gb": 100,
    "mem_gb": 3.75,
    "preemptible_tries": 3
},

So I'll probably poke this in a single-SG run with 7.5GB just to try and get this one sample through 🗿

P.S. This PR was a pleasure to read.

would we want to be more explicit about the additional arguments that we're passing along

Possibly... I might add another couple but commented out for templating purposes. I was hoping to keep the override -> runtime config pretty light touch, rather than reading specific values and rebuilding a dict of parameters to send, which might require additional PRs if we want to poke other settings. I'm not sure if that's correctly understanding your comment...
In theory the syntax here could also be used to override docker images or filepaths, so it might be a little too light-touch...
The way that it's determining values at runtime has worked for 99.5% of samples in this batch, so I don't want to tinker too much.


Restore kernels for point masses

Revert "Ditch kernel functions for point masses (#42)". Remove tests for point source kernels.
Relevant issues/PRs:
Revert changes as requested in #42

@Souza-junior, would you like to take a look at this PR? Let me know if these changes work for you, as @leouieda pointed it out in #42.
No pressure and no time limit, just do it if you feel to do so 🙂

Hey, @santisoler! I will take a look at it and give you feedback soon.

Merging this in! Thanks for doing it @santisoler


Adjustments for handling an IPv6 socket.

While resolving to IPv6, SwiftMailer produce malformed SMTP commands eg: "HELO [::1]".
According to following SMTP RFC "IPv6:" a tag is needed:
https://tools.ietf.org/html/rfc5321#section-4.1.3
The System should send "HELO [IPv6:::1]", then both mail server will be able to communicate.
As of now, whenever system uses an IPv6 address literal in the HELO command, it sends a malformed command. IPv4 mail servers are handling it, while IPv6 aren't.

Thank you @ravi-sharma.


Chore: Use Centralized Templates

This PR removes the CONTRIBUTING.md, CODE_OF_CONDUCT.md, .github/ISSUE_TEMPLATE, and .github/PULL_REQUEST_TEMPLATE.md files to centralize templates.

No issues with  this change.


docs/license: update LICENSE details [MAID-2861]

Update license for rust_sodium and rust_sodium-sys to MIT or BSD-3-Clause option, no longer Apache-2.0.
Also standardised MIT license format so as to be the same across all our repo's.

FYI - once this PR is approved and merged I'll raise a separate PR for a version update to both rust_sodium and rust_sodium-sys

Closing PR for now as there is a conflict between the license types I'm changing to and the licensing for sodiumoxide. Can be reopened in future if need be.


#52 Resolved the test cases involving Person attributes and renamed AddressBook

Resolved the test cases involving Person attributes and renamed AddressBook

nice


Fix long string values in json parser

This fixes a core issue in the JSON parser, it uses a shared buffer of 8kb to avoid excessive allocations while it null-terminates strings coming from YAJL.
Unfortunately I never actually implemented it properly for values over 8kb as the code never memcpy'd or did anything to actually represent the string.
@paulofaria review 👍

LGTM! Waiting for travis to merge. (:

Hm we have some inconsistencies on Linux. grrr 😡
I'll take a look at it later if you don't beat me to it.


newArchEnabled=true not working

Description
Hello!
I tried to switch my project to New Architecture and it was not successful for me for an android app.
The build of the application goes without problems,
but trying to open it in the emulator shows me Splash Screen and then immediately closes, this is the whole problem.
Version
0.68.0
Output of npx react-native info
    OS: macOS 12.3.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 90.55 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.2/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.2/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK: Not Found
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7583922
    Xcode: 13.3/13E113 - /usr/bin/xcodebuild
  Languages:
    Java: javac 18 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.68.1 => 0.68.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

Create project with npx command: npx react-native init MyApp.
On Android I set newArchEnabled=true in android/gradle.properties file.
Then I just run the project on Android with the command: yarn android.

Snack, code example, screenshot, or link to a repository
The code, except for the steps above to reproduce the error, remains unchanged.

Please show the error log

04-25 23:29:15.886   382   479 E SurfaceFlinger: Only WindowManager is allowed to use eEarlyWakeup[Start|End] flags
04-25 23:29:15.927  1440  1440 E HwDetectorWithState: a: 3
04-25 23:29:15.942   343   432 E<EMAIL_ADDRESS>device/generic/goldfish/audio/stream_out.cpp:updateSourceMetadata:377 failure: Result::NOT_SUPPORTED
04-25 23:29:16.088  9238  9238 E unknown:ReactRootView: Unable to update root layout specs for ReactRootView: no rootViewTag set yet
04-25 23:29:16.353   382   479 E SurfaceFlinger: Only WindowManager is allowed to use eEarlyWakeup[Start|End] flags
04-25 23:29:16.475  9238  9238 E AndroidRuntime: Error reporting crash
04-25 23:29:16.475  9238  9238 E AndroidRuntime: java.lang.OutOfMemoryError: Failed to allocate a 319681440 byte allocation with 4245510 free bytes and 187MB until OOM, target footprint 8491022, growth limit 201326592
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.util.Arrays.copyOf(Arrays.java:3257)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.StringBuilder.append(StringBuilder.java:137)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.Throwable.toString(Throwable.java:493)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.String.valueOf(String.java:2924)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.io.PrintWriter.println(PrintWriter.java:754)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.Throwable$WrappedPrintWriter.println(Throwable.java:778)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.Throwable.printStackTrace(Throwable.java:667)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.Throwable.printStackTrace(Throwable.java:735)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at android.app.ApplicationErrorReport$CrashInfo.<init>(ApplicationErrorReport.java:354)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at android.app.ApplicationErrorReport$ParcelableCrashInfo.<init>(ApplicationErrorReport.java:484)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$KillApplicationHandler.uncaughtException(RuntimeInit.java:157)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1073)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1068)
04-25 23:29:16.475  9238  9238 E AndroidRuntime: 	at java.lang.Thread.dispatchUncaughtException(Thread.java:2200)
04-25 23:29:16.499   382   382 E ClientCache: failed to get buffer, invalid process token
04-25 23:29:16.499   382   382 E BpTransactionCompletedListener: Failed to transact (-32)```

04-25 23:29:16.475  9238  9238 E AndroidRuntime: Error reporting crash
04-25 23:29:16.475  9238  9238 E AndroidRuntime: java.lang.OutOfMemoryError: Failed to allocate a 319681440 byte allocation with 4245510 free bytes and 187MB until OOM, target footprint 8491022, growth limit 201326592

Duplicates https://github.com/facebook/react-native/issues/33640
I see you're running with Java 18. Downgrading to Java 11 would fix the issue.
Thanks for reporting this 🙏


Remove excluded upwind/downwind angles?

Purpose

Check if excluding range of angles for upwind/downwind sailing is necessary. Its possible that the speed objective will prevent upwind/downwind sailing for free. This is because:

If the boat is too close to irons, the speed will be really low (or zero)
If the speed is 0 for some segment, the path will take infinitely long to complete
So the speed objective cost would be really high, and any path without upwind sailing would beat it.

Note: Work on this issue can only be started after:

Justin's interpolation function is merged in
Speed objective is complete
We can visualize paths on the website

Changes

May remove the function for excluding paths that have a segment within a certain range of straight upwind/downwind sailing

Resources

Jay's optimization objectives PR
Justin's interpolation issue

I believe we should first keep all the objectives in and build a proper testing process as suggested by Asvin. Then we can determine what we can adjust or remove to fine-tune and configure the optimization objectives.

Sounds good to me!


HDMI sound not working.

Mac mini M1.  The sound only works on the built-in speakers.  Hdmi does not transmit sound to TV.  Please tell me how to transfer sound via Hdmi?  Thank you!

This is not yet supported and considered too small of a feature to be mentioned on https://github.com/AsahiLinux/docs/wiki/Feature-Support

Sorry, thanks.

Sorry, thanks.

Sorry, thanks

This is not yet supported and considered too small of a feature to be mentioned on https://github.com/AsahiLinux/docs/wiki/Feature-Support

Is there any chance this feature could be added to the wiki?  I often wonder whether this functionality is present (has been added) or not and searching for it is difficult due to the keywords involved.

Not an installer issue.

This is not yet supported and considered too small of a feature to be mentioned on https://github.com/AsahiLinux/docs/wiki/Feature-Support

Too small of a feature? What do you think people use computers for these days? I use mine as a media server, HDMI audio is critical for this application. Please reconsider your priorities. I also use a Mac and another Linux workstation as DAWs.

@jannau is it not mentioned here?
https://github.com/AsahiLinux/docs/wiki/M1-Series-Feature-Support#hdmi-audio


Remove workaround for scalacheck

This PR addresses https://github.com/twitter/summingbird/issues/741 issue with serialization of generated scalacheck lambdas. We can safely remove ArbitraryWorkaround class with newest scalacheck release.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


dc2 weak lensing

waiting on #1047 for image normalizers & potential dc2 changes

refactored the tile catalog and made the small changes.
imo, the explicit stating of input parameters is better than just accepting **kwargs; that is there since the base_config provides arguments that can't be replaced (i.e. without it, there's some cases of "unexpected keyword ___ found" , but in this case we ensure that any missing arguments in lensing_config are noted quickly by the explicit constructor.


[Unity 2021.3.14f1] Additional windows.

Good day. I wanted to know why, after running the example in Unity 2021.3.14f1, 2 additional empty windows are created.

Good day. I wanted to know why, after running the example in Unity 2021.3.14f1, 2 additional empty windows are created.

You are right, it's a mistake. I upated the asset, but be carreful, I alse made a major update for Lukomor Architecture, and if you already use the asset in your project, your should update by different way. You should reimport asset with a link
https://github.com/vavilichev/Lukomor.git#version_2

Because major update doesnt support backward compatibility and it will break your project.


Use in reply to for resubmissions

 Fixup COAR notifications for protocol v1.0 & inReplyTo-based resubmissions


cargo/targets: fix error-message typo

Fix typo: "with with" -> "with"

(update: added missing test-adjustment)

:pushpin: Commit 4aa1a957144c99ab46107e5c6031b1d7870e2a21 has been approved by epage
It is now in the queue for this repository.

Thanks!

:hourglass: Testing commit 4aa1a957144c99ab46107e5c6031b1d7870e2a21 with merge fc790e7b2dcbd0c5635f28bc2147e7b69de182ab...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing fc790e7b2dcbd0c5635f28bc2147e7b69de182ab to master...


feat: make the demo_client work without Docker

This create a local scenario that runs the testbed and launches the demo against it.
It succeeds in retrieving collections as intended.

Can you also update the README please 🙏🏽


Roll engine to 20b286dd428a0d8dd0f87b7a03ab67fbf0da2836

Fixes #16718
Includes:
Roll src/third_party/skia/ a8daee88d..cea8e3d13 (3 commits) (#5192)  …
libtxt: exclude trailing whitespace from right-justified lines (#5190)  …
libtxt: support fake italic text (#5191)  …
Re-land Enables system chrome customization on Android O/N and greater (  …
Use the rasterizer's compositor context and texture registry to captu…  …
add onStart hook which places flutter in an inactive state (#5177)
Use a view container handle instead of a reference to the view interf…  …
rename obsolete SkColor.h macro (#5175)  …

You need the changes in https://github.com/flutter/flutter/pull/17362/files for Re-land Enables system chrome customization on Android O/N and greater (


Wild Card for batch editing in CLI is not working for Windows

When I try to use *.cbz or *.cbr it will not find any files but I can make edits using the full file name. But I want to batch edit, is there a problem with how I am using it or a problem with the problem.
comictagger -s -t cr -m "series=Chronicles of the Avatar" *.cbz will not work
comictagger -s -t cr -m "series=Chronicles of the Avatar" "Dawn of Yangchen, The - F.C Yee.cbz" works

File globbing is provided by the shell on macOS and Linux.  You can also enable recursion with -R and just give it the name of the folder


PowerShell module AzureRM.Subscription not found in the PSGallery

It seems that the PowerShell module defined in the documentation don't exist.
I've been able to install the subscription module with this command "Install-Module AzureRM.Subscription.Preview" then use the command "New-AzureRmSubscriptionDefinition" to create my subscription.
The documentation should be updated ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 371189c2-154f-2716-bbc0-8496a76c5ac9
Version Independent ID: bb5cd103-ff51-1753-f269-e2c1aa49a8c8
Content: Programmatically create Azure Enterprise subscriptions
Content Source: articles/azure-resource-manager/programmatically-create-subscription.md
Service: azure-resource-manager
GitHub Login: @jlian
Microsoft Alias: jlian

Do you mean that you haven't been able to install? Did you make sure to use -AllowPrerelease?

I apologise for this error, this morning I was unable to install the module AzureRM.Subscription, when I tried to run the command an error message appeared, the module wasn't found.
So I had to use the command "Install-Module AzureRM.Subscription.Preview" and use the command New-AzureRmSubscriptionDefinition
What's the right command and module to finally use ?

The right command is Install-Module AzureRM.Subscription -AllowPrerelease

Oh, I see what's going on. This link https://docs.microsoft.com/en-us/powershell/module/azurerm.subscription.preview/?view=azurermps-5.7.0 is for the older version, don't use it. Follow instructions here https://docs.microsoft.com/en-us/azure/azure-resource-manager/programmatically-create-subscription?tabs=azure-powershell#create-subscriptions-under-a-specific-enrollment-account please

@jlian thanks for the update. may be helpful to include a note to clarify this in the published doc. thoughts?

@YoannGUILLO We will now close this issue. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

Just pushed a fix to link to https://docs.microsoft.com/powershell/module/azurerm.subscription/new-azurermsubscription instead, should be live before noon PST tomorrow. Thanks for pointing out the issue.

same issue with 6.13.0


Doesn't work when MAX_TEXTURE_SIZE is not large enough

It seems the script is assuming weblasTensor is available after calling createWeblasTensor. However, when MAX_TEXTURE_SIZE is not enough, createWeblasTensor may create weblasTensorsSplit instead (or raise an error if it is really not enough).
If it is hard to use weblasTensorsSplit for this, I think it would be better to show some warning and gracefully fallback to CPU.

Added some notes in the readme.


Uncaught FileNotFoundError in subprocess.py line 1538

Aider version: 0.55.1.dev37+g2d866418
Python version: 3.12.4
Platform: Windows-11-10.0.26120-SP0
Python implementation: CPython
Virtual environment: Yes
OS: Windows 11 (64bit)
Git version: git version 2.45.2.windows.1
An uncaught exception occurred:
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "__main__.py", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "main.py", line 694, in main
    coder.run()
  File "base_coder.py", line 732, in run
    self.run_one(user_message, preproc)
  File "base_coder.py", line 775, in run_one
    list(self.send_message(message))
  File "base_coder.py", line 1196, in send_message
    lint_errors = self.lint_edited(edited)
                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "base_coder.py", line 1290, in lint_edited
    errors = self.linter.lint(self.abs_root_path(fname))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "linter.py", line 115, in lint
    lintres = self.run_cmd(cmd, rel_fname, code)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "linter.py", line 66, in run_cmd
    process = subprocess.Popen(
              ^^^^^^^^^^^^^^^^^
  File "subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "subprocess.py", line 1538, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified

Thanks for trying aider and filing this issue.
The fix is available in the main branch. You can get it by installing the latest version from github:
aider --install-main-branch

# or...

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.


fix: Can not specify custom Packer directory

What problem does this PR solve?:
This PR supports packer provisioning with STIG requirements by using the remote_folder parameter in packer to override the default /tmp directory.
Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-93657/

Special notes for your reviewer:

@supershal and I tested using a custom source_ami image in rhel-82.yaml where we remounted the /tmp directory with the noexec flag to match STIG requirements. We also commented out ami_filter_name and ami_filter_owners.

@mesosphere-ci help


feat(dayoff calendar): add new component

FX-2678
Description
Extend an existing Calendar to be able to build a new Calendar in SP.
Link to the Staff Portal Design, the needed calendar.
How to test
Go to the StoryBook and check that it works as expected.
Screenshots

Review

[x] Read CONTRIBUTING.md and Component API principles
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

After the discussion with FX, https://toptal-core.slack.com/archives/CERF5NHT3/p1651047382916219, I'm going to work more on this, I'll remove DayOffcalendar and it would be a part of the SP

@toptal-anvil ping reviewers

@toptal-bot run package:alpha-release

Could you please confirm that these two new designs are proper: https://happo.io/a/675/p/848/compare/ee4624f8277997acc3eba44af3556d217ffaafa2/85753ec925cf4d0c1c4ae6b7beca5bfb7afe3f30?t=added

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release


Fix link formatting

Fix link formatting to make it clickable

@nardieu : Thanks for your contribution! The author, @mikeblome, has been notified to review your proposed change.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/test/writing-unit-tests-for-c-cpp.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


latest version 3.2.0 is broken in google colab

Describe the bug

To Reproduce
profile = ProfileReport(df, title="Pandas Profiling Report")
profile.to_notebook_iframe()
will throw error
<!--

anyone want a dirty fix
!pip install pandas-profiling==3.1.0
instead

!pip install pandas-profiling==3.1.0
dirty fix

Will look into this

@athulkrishna2015 thanks for reporting. The versions of "markupsafe" and "jinja2" are incompatible on colab.
Solution:
!pip install -U "jinja2>=2.3"
Will update the dependencies accordingly.


[WFLY-12003] Update jboss-ejb-client to 4.0.17.Final

https://issues.jboss.org/browse/WFLY-12003
Core PR:
https://issues.jboss.org/browse/WFCORE-4433
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[ ] Pull Request contains link to the JIRA issue(s)
[ ] Pull Request contains description of the issue(s)
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[ ] Pull Request requires a change to the documentation
[ ] Documentation have been updated accordingly
[ ] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.

@tadamski This needs to reference a Jira in the commit message, and also the PR should have a link to the Jira issue

@kabir ok will do, but could you please hold up this PR; we would need core update for that - I will clarify it in the JIRA

retest this please

@tadamski WF Core has been updated but this still has lots of test failures.

FYI, i'm running this locally against Wildfly master on Fedora/JDK 8 and I don't see these failures.

retest this please
In case the above failures were something strange

@rachmatowicz on the off chance it's relevant, the CI jobs run with -Dipv6, which most people don't do when testing locally.