finishTrial() should clear timeouts and the screen by default.

Discussed in https://github.com/jspsych/jsPsych/discussions/3241

Originally posted by Shaobin-Jiang February 29, 2024
I use the on_load event quite a lot to tweak with the default behavior of jsPsych and from time to time I would have to manually end the experiment. I recently encountered a bug, though, when I called finishTrial in on_load but accidentally forgot to set the trial_duration of an html-keyboard-response plugin to null, so that when I was half way in the next trial, the finishTrial from within the previous trial, having reached the time limit, was executed, causing the current trial to be ended, resulting in a break down of the entire experiment.
I located the bug quick enough, and to be frank, this was expected, as I only called finishTrial in my on_load and did not clear the timeout. The finishTrial function of its own accord does not include the latter; that is quite clear in the docs. However, this led me to wonder whether this is right. I mean, I have written quite a number of plugins myself and as far as trial duration is concerned, I would have to call clearAllTimeouts aside from finishTrial; oh, and besides these two I would have to clear the screen as well. And from what I see in the official plugins, these three tasks co-occur quite frequently as well. So why not just put them together in one function and let finishTrial also clear timeouts and the content of the screen?
I would propose something like this:
// clear all timeouts and the content of the screen by default
jsPsych.finishTrial(data_obj);

// only end the trial but do not clear timeouts or the screen
jsPsych.finishTrial(data_obj, { clear_timeout: false, clear_screen: false });

Quoting from this answer:

The finishTrial() method isn't really intended to be called outside the plugin context. You can do it, but it is likely to create problems.

I do not quite agree because using it properly never caused problems for me; the only problem that arose from using it was due to my not clearing the timeouts and the experiment content with it. And for that, I am much in favor of the idea of grouping the three tasks together.

Agreed. It was a bad pattern from early days of the library.

@jodeleeuw So do you think we should make clearing the screen and resetting the timeouts the default in v8, without opt-out parameters (I do)?

So do you think we should make clearing the screen and resetting the timeouts the default in v8, without opt-out parameters (I do)?

Yes, let's do it.

I've implemented this in #3339.
I decided not to create the arguments for clear_screen and clear_timeouts. I think it's best if plugins never leave anything on the display_element, and if a developer really wants a timeout to persist beyond the trial they can just use the built-in setTimeout instead of the pluginAPI version.


annotation-no-unknown should allow !default

Hi, thank you for maintaining this stylelint configuration, it is very helpful 👍.
Since v14.10.0, stylelint added the annotation-no-unknown rule. Given that !default is a valid flag for Sass variables, I suggest to add some configuration to allow it. This way, users of this config will not have errors raised on their default Sass variables.
Before the change:
$my-variable: #ff0000 !default; // ✖  Unexpected unknown annotation "!default"  annotation-no-unknown

After the change:
$my-variable: #ff0000 !default; // No error

What do you think about it ? I'll submit a PR for it shortly.

This could be combined with https://github.com/stylelint-scss/stylelint-config-recommended-scss/pull/117, because the rule is enabled in stylelint-config-recommended version 9.0, which causes this error to appear now for users.

Thanks, sure, let's fix this!


Lock the electron version

For context, this PR:

locks the version of electron (so we can carefully test and upgrade)
changes the build script to always use the version of electron specified in package.json so we don't need to specify it in multiple places like most Electron based projects do. This is done with the $npm_package_xxx environment variable

Cool, that method might help solve https://github.com/moose-team/friends/issues/154 :+1:

nice!


Disabling the buttons after the timeout expires throws an Exception when the interaction is done in a channel hidden for the bot

The plugin throws an error after the timeout expires when the initial interaction is done in a channel hidden for the bot.

This line seems to cause the error:
https://github.com/ryzyx/discordjs-button-pagination/blob/interaction/index.js#L73
Changing it to this also seems to fix the issue:
collector.on("end", () => {
  if (!curPage.deleted) {
    const disabledRow = new MessageActionRow().addComponents(
      buttonList[0].setDisabled(true),
      buttonList[1].setDisabled(true)
    );
    // curPage.edit({ // throws an error when the channel is hidden for the bot
    interaction.editReply({ // seems to fix to issue
      embeds: [pages[page].setFooter(`Page ${page + 1} / ${pages.length}`)],
      components: [disabledRow],
    });
  }
});

Some error info:
{
    "name": "DiscordAPIError",
    "message": "Missing Access",
    "method": "patch",
    "path": "/channels/*snip*/messages/*snip*",
    "code": 50001,
    "httpStatus": 403,
    "requestData": {
        *snip*
    }
}

I see, I'll look into it soon


Renames Gooey.Color to Gooey._Color and provides versioned names for …

…the type: Color for iOS 12 and ColorToken for iOS 13. Unfortunately, the compiler is unable to resolve any usages of Color when both Gooey and SwiftUI are imported.

@rpwachowski What about in the case that a user is using both SwiftUI and UIKit? Or even when 3rd party dependencies built for UIKit are imported into a SwiftUI project and can import SwiftUI?
An alternative might be to change the name to ColorToken and use Color as an alias to maintain compatibility when iOS 13 or higher isn't being targeted.
Another alternative might be to rethink how we access Gooey's Color. For example Color.goo. Although looks weird to get back a Gooey.Color after accessing SwiftUI.Color.goo.

Yeah, the typealiasing was a quick fix to test whether the change was valuable—I wasn't able to use Color in a manner that was sufficient without a rename.


Add a custom 404 not found page [GSSoC'23]

Add a custom  404 not found page
Can you assign this to me, I want to work on this under GSSoC'23

Hey @J0SAL ,
I'm Darshan Jain, and I'm thrilled to be a part of this GSSOC'23. I bring along my expertise in HTML5, CSS, PHP, Bootstrap, and creativity too. I'm passionate about open source projects and eager to contribute and collaborate with fellow enthusiasts.
Can you please assign this to me.

Hii,
I would like to work on this issue

@J0SAL can you assign me this issue I can make this

@J0SAL I want to work on this issue please assign me

Hello @J0SAL ,
I'm Anushka Anand . I want to work on this issue under Gssoc'23. I am really eager to work on open source projects and contribute to this community.
Skills
HTML5, CSS3, JS, Bootstrap |  Python, Django | Php, mysql | MERN | Responsive Design | Adobe Photoshop |
Can you please assign this issue to me.

@J0SAL
I would like to work on this issue,  I am good at designing
I have worked on more than 30 designs on Canva and I have knowledge of HTMl, CSS, Bootstrap,  Javascript and I have tried tried my handout in Node and express and I took keen interest in learning MERN Stack Web Development.

Hello @J0SAL
I'm thrilled to work on the Custom 404 Not Found page for GSSoC'23. With expertise in PHP, HTML, CSS, and Bootstrap, I'm eager to contribute. Please assign me this task on GitHub.
It's my first time in GSSOC and I assure you to give my best.
Thank you!"

Hello @J0SAL , I hope you are well
I am really excited to work on this project , its a humble request to assign this issue to me . I would use my expertise in HTML,CSS,Next.Js and Bootstrap . It would be a pleasure to design this page . I'll give my best and hope to fulfill your expectations
Thank You !!

Hello @J0SAL . I came across your project  and I'm really interested in contributing by adding a 404 page to the website. I have experience in web development especially HTML, CSS , javascript , designing and Bootstrap . I can design a 404 page  ensuring it matches the overall theme of the website . If you are open to collaboration I would be happy to take this task. I look forward to hearing from you.
Best Regards
Suchitra Sahoo

it would be easier to decide if you could show a screenshot of your design. Then we can choose the one we prefer

I don't have the design ready yet in screenshot but I have the idea i.e -
A big 404 with the monopoly guy in between the space of zero that appears to comeout of that space

@J0SAL

Please assign it to me under GSSoC'23.

Hey @J0SAL , this is one error page idea had implemented in my previous projects. I could do something similar like an ethereum icon with cracks in it  saying "The page Wasn't Found." Although I don't have any visuals to present my idea however I feel that I will be able to successfully implement it. Kindly consider assigning me this issue . Thank you.

@Thrillseekr your design doesn't give a proper context for page not found
@Google-Ka-Dinosaur 's Design is good, can you also add some icons to it?

@J0SAL yes I can add some icons like one to go back to the main page

I request you to kindly assign me this project. As I can provide relevant outcomes.Here, I am attaching one

go ahead, @Google-Ka-Dinosaur 🚀


Ensure POSIX paths are preserved even if running on Windows

As per #48

[Current coverage][cc-pull] is 92.15%

Merging [#49][cc-pull] into [master][cc-base-branch] will increase coverage by 0.32%

@@             master        #49   diff @@
==========================================
  Files             1          1
  Lines            49         51     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits             45         47     +2
  Misses            4          4
  Partials          0          0

Powered by Codecov. Last updated by [aa8a5a7...9052f1d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/tleunen/babel-plugin-module-alias/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/tleunen/babel-plugin-module-alias/compare/aa8a5a7550287d4ac1c4b0b823d367a093220493...9052f1d76e2c6e65cc8078512e44d3ee8d705553
[cc-pull]: https://codecov.io/gh/tleunen/babel-plugin-module-alias/pull/49?src=pr

Thanks @raulmatei!

Thanks for merging!


ntv2version.h.in is installed in the include folder

The ntv2version.h.in is installed in the include folder (e.g. /usr/include), it should not be there since it is only meant to configure ntv2version.h for the library.
Edit: The file ends up with this path /usr/include/libajantv2/ajantv2/includes/ntv2version.h.in

@thomas43 Do we use this in our internal OEM SDK build or is it no longer useful?

@paulh-aja it is not used there, and is no longer useful. We will remove it.

This is resolved by https://github.com/aja-video/libajantv2/commit/eb53f4b415b30bf8314d4abcbc373fef990d8a01.


stone tools and sword using "stone" and not "cobblestone"

discovered that stone tools were not set to cobblestone.

updated spreadsheet to cobblestone.


RN2483 send timeout?

What firmware of the RN2483 are you running, 1.0.5 or an earlier version? And what settings did you use on TTN side for the device?
I'm having some issues where the RN2483 sometimes doesn't give a response anymore to a TX command.
It would do multiple rounds OK, and then suddenly it acknowledges the command to send an unconfirmed message, but after ~1 hour it still sits there with no response on the UART from the RN seemingly (I didn't tap the UART yet directly from the RN in parallel, will try that). In the docs of the RN2483 there is a possible timeout response mentioned, so should it need to be set explicitly perhaps?
example:
Sleeping for 4320 seconds

Round: 3
Measuring
Measuring battery: 4684 mV
Measuring fence positive: 0 V
Measuring fence negative: 0 V

Transmitting
RN2483 wakeup and baud change
RN2483 RX clearing
RN2483 TX: mac join abp
RN2483 RX: ok
RN2483 RX: accepted
RN2483 TX: mac get upctr
RN2483 RX: 25
RN2483 TX: mac set pwridx 1
RN2483 RX: ok
RN2483 TX: mac tx uncnf 1 0003124C00000000
RN2483 RX: ok
RN2483 RX: mac_tx_ok
RN2483 TX: mac save
RN2483 RX: ok
RN2483 TX: sys sleep 86400000

Sleeping for 4320 seconds

Round: 4
Measuring
Measuring battery: 4658 mV
Measuring fence positive: 0 V
Measuring fence negative: 0 V

Transmitting
RN2483 wakeup and baud change
RN2483 RX clearing
RN2483 TX: mac join abp
RN2483 RX: ok
RN2483 RX: accepted
RN2483 TX: mac get upctr
RN2483 RX: 26
RN2483 TX: mac set pwridx 1
RN2483 RX: ok
RN2483 TX: mac tx uncnf 1<PHONE_NUMBER>000000
RN2483 RX: ok

/edit: found some other references to this
https://www.thethingsnetwork.org/forum/t/rn2483-timing/36278
https://www.microchip.com/forums/m1101599.aspx
So for now I've put a (naive) 5 second timeout in the rn2483_rx() function to cope with this. Will let it run again overnight and see how it behaves

Hmmm. Unfortunately I haven't seen this problem before. I have 10 devices running and I didn't observe a device being stuck. Or - to be more precise - I didn't see it while testing. The devices are in the field and maintained by friend. I wouldn't notice if he reboots devices sometimes.
I am pretty sure that all my devices run RN2483 firmware 1.0.5.
Adding the timeout is a good idea anyways. Please provide feedback on your experience.

Actually I can see resets as I am monitoring them. But I don't know if they were intended (device was moved / battery changed) or because of a lock up.
Each spike is reset on a device.

For now it's going steady again, perhaps too soon to tell. But I guess the timeout doesn't hurt anyhow.
I saw a prior ticket with some potential changes ( https://github.com/kiu/lofence/issues/7 ) which didn't go through yet since kicad 6 isn't released yet. I'll probably hop on that wagon as well, since updating the keys and creating a custom hex file gets error-prone very quickly.
I'll probably create some pyserial wrapper around a json/config file which has the hweui's and TTN keys. Then it can do the RN<->TTN config mapping by itself and every AVR can have the same firmware (PS, why the EEPROM save every time, it's only altering those settings once, not concerned about EEPROM wear?).
Didn't use lorawan before, so have to read up on OTAA vs ABP and see what that entails possibly

(PS, why the EEPROM save every time, it's only altering those settings once, not concerned about EEPROM wear?).

I believe - its been a while - that the frame counter is only persisted on a "mac save". As I have enabled that for the devices in the TTN console, I need to ensure that the value is not lost. Otherwise the RN2483 on a reboot will start with frame counter 0 and the messages are discarded. There is probably no need to enable frame counters (replay attacks aren't a strong vector in my scenario).

Didn't use lorawan before, so have to read up on OTAA vs ABP and see what that entails possibly

I didn't use OTAA for my devices, as there is really bad coverage in the area I am setting them up. OTAA - not on every message though - requires additional packets being transmitted to join the network and there would be a higher chance of packet loss.

I followed this issue and because you mentioned #6 here my comment.
I wanted to change and use a ready to go lib for the RN module, but as it goes it didn't have the time and just changed the code to do what I need and thought was right.
That is burning the keys to the RN module using an extra script before programming the ATmega and then using soft ABP joining.
I recently switched to an OTAA rejoin when the device gets reset/restarted because of some issues witch my LoRa gateway sometimes having troubles with fCnt of packets and re-joining resets that counter and starts over... This is how my other LoRa sensors are doing it and as the devices have a very long uptime I don't see an issue there anymore. Initially I thought re-joining should not occur on every restart but what I really meant was not too often and if a device is up for a year and then the battery has to be changed this is not too often for a re-join...
One or two times since I use the devices I had a hanging RN module, the device didn't post updates, I opened it and the transmit LED lit continually but I wasn't able to debug and get the cause if it. A restart solved it...
I thought of implementing a watch dog but I have no idea if that is even possible with the ATmega chip...

@Alex9779 "One or two times since I use the devices I had a hanging RN module, the device didn't post updates, I opened it and the transmit LED lit continually but I wasn't able to debug and get the cause if it. A restart solved it..."
That's exactly what I had yesterday / see start of issue ticket.
What I changed (apologies for the ugly code, this is outside my comfort zone ;-)) to have a ~5 second timeout
void rn2483_rx() {
	char nc = 0x00;
	uint8_t len = 0;

    // erase buffer_rn to make sure it doesn't contain data from prior read
    memset(buffer_rn, 0, 255);

    // do 5000 loops, bit naive way to yield a 5 second timeout
    for(int i = 0; i < 5000; i++){
        if (USART_0_is_rx_ready()) {
            nc = USART_0_read();
            buffer_rn[len] = nc;
            len++;
            if (nc == '\n') {
                break;
            }
        } else {
            _delay_ms(1);
        }
	}
	buffer_rn[len+1] = '\0';

	#ifdef DEBUG
	debug("RN2483 RX: ");
	debug(buffer_rn);
	#endif
}

Well it is hard to test, maybe have a look in that lib and see if they have implemented some kind of watch dog:
https://github.com/jpmeijers/RN2483-Arduino-Library

no watchdog at first glance, but timeouts on the serial reads on many places
like
        _serial.setTimeout(30000);
        receivedData = _serial.readStringUntil('\n');
        _serial.setTimeout(2000);

Yeah well, as already said I have it running in a way it suits me...
If I wanted to sell those devices then yes, the firmware would need a rework, but for now I don't need it.
A hang rarely happens, most devices didn't have a single hang until the battery ran out so...

It is my understanding that once the module hangs, it won't recover later on. Can you confirm that? If that is the case, you would need to reset the module in case your timeout is triggered: rn2483_init();
It is also possible to integrate the hardware watchdog into the system, but be aware that the current code immediately starts to send a packet through TTN. A device with problems restarting through the watchdog all the time, could violate the fair use policy of TTN. The RN2483 itself covers any regulatory violations, but who knows what the module actually will do, if it hangs/crashes. Probably best solution for a watchdog solution would be to go to sleep after startup to insure proper delays in case the device goes roque.

As far as I can tell from other LoRa devices TTN fair use is one thing, local regulations something other and what a device does also.
I don't use TTN because for my fence monitoring the fair use is not enough for me to get alerts in time. I have my own gateway on Chirpstack.
TTN just ignores packets above the fait use, you won't get them in your app.
What happens if your device constantly breaks local restrictions I can't tell... I think it depends if you really interfere with something important then they come and analyse.
My approved devices for example try to join every 30 seconds after a reboot I think but I have no idea for how long if they don't get an answer.
That is much above what TTN allows.
I agree if the module hangs and you have to reset you also reset the regulation restrictions and that way you can break them, send more packets than allowed.
And as far as I know the approved devices have some kind of timeout, they try but stop after some time and require a manual reset to try again to not overwhelm the band...

Just documenting it here, for future reference.
I tried the absence of the eeprom save command, but that's indeed needed to keep track of the frame counter. It confused me that the docs said it was needed after mac set <xyz> commands (and there exists an explicit downlink/uplink frame counter set command), but implicitly the module is bumping that every transmission I guess, hence the need for the save.
Tested here below, The last 2 cycles was with firmware without the mac save command (and a reset in-between)

As for the RN reset / hang, very possible indeed, but hard to provoke to be certain. For testing purposes I'll leave it out for now and see what happens.

I used that mac save in my firmware but only every 100 uplinks to save the eeprom from wearing out, on a new start I increased the counter by 100 to be after any count between where the gateway might be...
But I changed to a rejoin on a reset so no need to save for now...

I want to share some recent impressions on this topic.
I do not use TTN but have an own gateway running ChirpstackOS. I stumbled over some special handling in the Chirpstack code regarding the RN2483 and the LoRa power index sent to the device if in ADR mode.
The issue seems to be that the RN2483 does not handle a power index of 0 properly.
Though this seems to be taken care of in the base code of Chirpstack I created an own ADR algorithm plugin and changed it so power index 0 is never used despite some other changes I want to have for my installation.
Since I use (about 1 month at the time of writing) this ADR algorithm for my LoFence devices I never had a hanging device again.

here is the code in Chirpstack I referred: https://github.com/brocaar/chirpstack-network-server/blob/3971570b77c79c1cfd184b6f06a4f1770b5a0db0/internal/maccommand/link_adr.go#L119

Oh and yes I know there is firmware 1.0.3 mentioned, i checked one device and I have 1.0.5 on it.
But since there was a problem in 1.0.3 no idea if the fix works properly.
I will monitor and see how long the system is stable with the new ADR for the RN2483 and report if I see a hanging device again...

About a month passed and system still stable, no hanging devices after changing to my ADR algorithm.
I had one device having an issue but it turned out the crystal had a connection issue and the clock didn't get a signal so the device didn't wake up after initial join and first measurement.
I changed batteries of all six devices yesterday, all joined without issues and sent ~200 updates...


[BUG] - slot attribute is not propagated to the button

NextUI Version
2.0.18
Describe the bug
<Button variant="light" color="primary" slot="button">
    Button
</Button>

Rendered html;
<button class="..." type="button">Button</button>
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Add slot to the button component
Open devtools
Look at the button

Expected behavior
I expected to see the slot attribute on the button, but I'm not seeing it.
Screenshots or Videos
No response
Operating System Version
macOS
Browser
Edge

That was fast.


Item duplicated after drop in the same list (second item into first position)

Using angular-drag-and-drop-lists version 1.4 with angular 1.5.0
After dropping a item on the same list (second item into first position - Choosen fields) the second item becomes duplicated on the model.
Does anybody had the same problem?
JsFiddle: jsfiddle

have you fixed it?@jjsjunior


fix #160

I also removed initialCapacity since it is not used

Codecov Report

Merging #246 into master will decrease coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   87.80%   87.13%   -0.67%
==========================================
  Files          15       15
  Lines         623      622       -1
==========================================
- Hits          547      542       -5
- Misses         64       67       +3
- Partials       12       13       +1

Impacted Files
Coverage Δ

queue/bytes_queue.go
92.52% <100.00%> (-0.07%)
:arrow_down:

shard.go
85.37% <0.00%> (-1.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0afcdc4...67fc39e. Read the comment docs.


Polish updates to Amex card flow

Coming from here, we need to add support for the case where someone wants to setup an Amex personal on their workspace because they (and others) use it for their business. To do this, we'll:

Add a third row on the Amex connection page. Header is American Express Personal Cards. Subheader Select this if your cards are personal. Mock below.
Selecting it does the same thing as the existing American Express Business Cards option.

Does this need to be External? Or will @mountiny and @allgandalf handle it?

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.


dotnet new react should use latest create-react-app and react-scripts

Describe the bug
When I create a new ASP.NET Core + React project with dotnet new react, the template uses an old version of create-react-app. Specifically, it installs an old version of create-react-app's "react-scripts" package.
This causes a lot of npm audit warnings that wouldn't be there if it used the latest react-scripts, and prevents using the TypeScript support that's built into react-scripts 2.1.0 and later without a lot of juggling.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core: 2.2.203
Run this code: dotnet new react -o new-react-project
Look at new-react-project/ClientApp/project.json and find the version of react-scripts that the template is using

Expected behavior
The new project should specify "react-scripts": "3.0.0".
That's because the template supposedly uses create-react-app to create the ClientApp folder, and if you run npx create-react-app ClientApp, it does create a package.json with "react-scripts": "3.0.0".
Actual behavior
The new project's ClientApp/package.json specifies "react-scripts": "^1.1.5" - a version that's currently 8 months old. Somehow, in spite of using create-react-app, the "dotnet new react" template is forcing an old version of react-scripts.
Additional context
Output of dotnet --info:
.NET Core SDK (reflecting any global.json):
 Version:   2.2.203
 Commit:    e5bab63eca

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17134
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.2.203\

Host (useful for support):
  Version: 2.2.4
  Commit:  f95848e524

.NET Core SDKs installed:
  1.0.0-preview2-003121 [C:\Program Files\dotnet\sdk]
  2.0.3 [C:\Program Files\dotnet\sdk]
  2.1.200 [C:\Program Files\dotnet\sdk]
  2.2.105 [C:\Program Files\dotnet\sdk]
  2.2.202 [C:\Program Files\dotnet\sdk]
  2.2.203 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

Thanks for contacting us, @joewhite.
We are going to update the version of React for .Net Core 3.0 as part of https://github.com/aspnet/AspNetCore/issues/5432


Find an alternative to replace SOCKS5 HTTPS Client nodejs package

Describe the bug
Find an alternative to replace SOCKS5 HTTPS Client nodejs package. It seems to break pretty frequently such as not setting the proxy properly even though it says it has. Sometimes it fails to connect entirely to a working proxy.
To Reproduce
N/A
Expected behavior
Should set the proxy and use it properly when sending an http request.
Screenshots

Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
N/A

https://www.npmjs.com/package/socks-proxy-agent

Finished #15


nss_latest: 3.92 -> 3.93

Description of changes
https://groups.google.com/a/mozilla.org/g/dev-tech-crypto/c/aC5r1-9zPWI
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

What about adding this commit into the same PR then?
https://github.com/vcunat/nixpkgs/commit/ebd9a9127a11248f380c54c4a51affb2c915929a
(I'm not allowed to, apparently.)

Yeah, collaborating on PRs from non-personal forks has always been weird.

Backported via #254804


Adding of a Click to Copy button to the docs

Fixes Issue
Closes #2559
Closes #2561

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] My change requires changes to the documentation.
[X] I have updated the documentation accordingly.

Screenshots

note to review
Added copy button to the doc, so that it will be easy to copy the code.

Sorry this has been completed by another PR https://github.com/EddieHubCommunity/LinkFree/pull/2565
Have a look at our issues, there is many more items you can do - any questions let us know in Discord


import shaka as es6 module doesn't expose all APIs

Have you read the FAQ and checked for duplicate open issues?
Yes, this is nothing about what's currently in the FAQ and I couldn't find a similar issue.
What version of Shaka Player are you using?
"shaka-player": "^2.4.3",
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
I haven't tried because I import it just as a node module.
Are you using the demo app or your own custom app?
I'm importing the npm package shaka-player and trying to use it in my app.
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Chrome
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
N/A
What did you do?
I import the shaka debug module using import { shaka } from 'shaka-player/dist/shaka-player.compiled.debug';
What did you expect to happen?
Being able to access shaka's fields like:
- shaka.log.*

shaka.media.DrmEngine.*
etc...

just like I can do when I import it as a js file in my index.html (without using es6 modules).
What actually happened?
Some fields of shaka are exposed, but not all of them (for example the one I mentioned are not exported).

This is working as intended.  The library only exports certain APIs.  The ones you mentioned are not exported from a production build.  For example, shaka.log is compiled out in production, and shaka.media.DrmEngine is an internal class that applications are not meant to interact with directly.
To access the internals, you can use a debug build or an uncompiled build, but we make no guarantees about backward compatibility of those interfaces.  They may change at any time, in any release.
If you have a specific need for those internal methods in your application, I may be able to help you find a supported way to accomplish the same thing.
Does this help?


Add new fn AsyncClient::with_http_client

This enables users to pass in their own reqwest::Client with configurations such as https only and etc.
This would also enables users to reuse their existing reqwest::Client.
Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

@theduke Pinging.

@theduke Pinging as this has been stale for 8 days.

@theduke Pinging as this has been stale for another 8 days.

@theduke Can you review this PR please?

Sorry for the delay!


please document the sytem lib dependencies

the gem seems to depend on libmagickcore-dev and libmagickwand-dev. I had installed the regular packages but still could not build the native extensions.
OS: Linux Mint 17.1 Rebecca
thank you.

Hi Konstantin,
Thanks for raising this issue. Those are prerequisites of rmagick, a gem that catpix depends on. They describe what you need here.
Let me know if you have any more questions/issues.

Ah, I see, I didn't detangle the transitional dependencies. Thank you for the explanation and the cool tool and sorry for the inconvenience :$

No worries at all. There's no harm in asking :-).


Only emits the warning for gcloud credentials

@dwsupplee I introduced an env var to suppress the warning. PTAL


Assign materials to Wattle and HD hay homes

fixes an eye sore of mishmashed textures for houses that use post/wall 1602.
Master/PR:

That means these are finally textured!


viewer 'open' event not being triggered anymore

Viewer open event is not being triggered if viewer is initialized without a tile source
but images are later added on with addTiledImage() calls. Therefore, my code below
will not be called.

My code segment below used to start the view with the focused location  if the viewer
was called with a specific X, Y, Zoom location (startState is set to true)
myViewer.addHandler('open', function(target) {
  window.console.log("in open handler");
  if(startState) {
    goPosition(newX,newY,newZoom);
    startState=false;
  }
}

Yes, we consider adding additional images to be different than the initial open. If you want to know when addTiledImage is successful, use this:
myViewer.world.addHandler('add-item', handler);

There is a subtle difference in triggering with viewer's 'open' and with world's 'add-item'.
We want to load an image and followed with a function that calls viewerport.panTo and
viewport.zoomTo to take it to a particular location. Under open-handler that worked
but not with add-item-handler. Tracing it, goHome() was called after add-item event within
OpenSeadragon. If panTo() and zoomTo() were called before goHome(),  is there a function
that needs to be called to save the new location as the 'home' location and so all  the subsequent items will also be using the same  'home' location?

I see. Well, you can use the preserveViewport: false flag to turn off the goHome entirely, which is probably want you want.
For what it's worth, the success handler passed into addTiledImage happens after the goHome.


[Feature]Localization

Purpose

Custom String
RTL
set different locale

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Test the code

Selected the languages from Drop down
Use Java Launcher to test

What to Check
Verify that the following are valid

...

Other Information

I think public API lgtm. Left quality of life improvements, but I think improvements are best followed up as refactoring/organization pr's as necessary.


Can't resolve 'graphiql-subscriptions-fetcher'

I'm trying to built graphiql-workspace-app after updating to 1.0.5 and am getting this error:
Creating an optimized production build...
Failed to compile.

Module not found: Error: Can't resolve 'graphiql-subscriptions-fetcher' in '/path/to/graphiql-workspace-app/node_modules/graphiql-workspace/dist'

@tlvenn could this be related to your changes in package.json?
UPD: See CI build logs.

@kachkaev the issue with graphiql-subscriptions-fetcher is that it does not produce the expected main entrypoint index.js but fetcher.js. Depending on your packager, you will have to help it out figuring the correct entrypoint.
In the case of Browserify, this can be done with a browser entry in the package.json as you have seen. Create React App is using Webpack so you will have to check how this is done in Webpack.

I see. There is an issue for that: https://github.com/apollographql/GraphiQL-Subscriptions-Fetcher/issues/4
I'm using create-react-app, which is one of the most popular boilerplates today and I don't think it would allow a config you are mentioning. How about this workaround in this repo's code (suggested by @twelve17)?
import { graphQLFetcher } from 'graphiql-subscriptions-fetcher/dist/fetcher';

Sure that would totally work. Would you mind create a PR to address the issue ? Thanks in advance.


Bundled npm modules

Allow to specify a NPM module folder to be bundled in the target build process (as opposed to having it under /libs)

Actually, we can simply use "bundleddirs".


How can I access from AuthorizeRouteView.NotAuthorized the url or name of a component .

How can I access from AuthorizeRouteView.NotAuthorized the url or name of a page component from which I'm being redirected to a Login component. In other words, when an unauthenticated user tries to access a page component with the Authorize attribute, he should be redirected to a Login component. The code to navigate to the  Login component resides within the AuthorizeRouteView.NotAuthorized property thus:
    <AuthorizeRouteView RouteData="@routeData"
                                DefaultLayout="@typeof(MainLayout)">
            <NotAuthorized>
                   NavigationManager.NavigateTo("Login");
             </NotAuthorized>
            <Authorizing>
                Wait...
            </Authorizing>
      </AuthorizeRouteView>

Now, what I want to pass with the login route is the return url; that is the url from which the user is redirected, so that if the login succeed, I can redirect the user to the the page he wanted to access. I could do it, but as shown below, but it smells as a workaround, and I want to know if Blazor has a dedicated feature for this purpose, which I believe many users will need without resorting to workarounds.  This is the code that is supposed to do the job:
 @{
      var returnUrl = routeData.PageType.Name.Equals("Index") ? null : routeData.PageType.Name;

      var str = returnUrl == null ? $"Login/Index" : $"Login/{returnUrl}";

       NavigationManager.NavigateTo(str);
 }

Note: routeData.PageType.Name returns values such as Counter and FetchData, which is fine and I can use it as the return url. But it also returns Index, which is not so fine, because I can't use Index as a url...
This "Login/Counter" works, and this "Login/FetchData" aslo works, but this "Login/Index" does not exist.
Note also that in the Login component, I define a parameter Property which will accept the return url value passed to the Login component.
This should be a common scenario, and that feature is much needed unless I've missed something. Thanks.

@enetstudio thanks for contacting us.
You could write a "Redirect" component and use NavigaionManager.Uri to get the current URI, and then redirect appropriately.

Thank you very much for your quick and immensely  helpful response. I was well aware of NavigaionManager.Uri property, but I thought that I could not get the current uri as I wrongly believed that the page I was trying to access no longer exists, as a redirection to the App component has occurred. But I guess that  the App component ( and the Router embedded within) are not part of the routing. They are the routing agent themselves, and as long as no new routing (to a routable component)  has taken place, the current uri is that of the page I was trying to access (say, the FetchData page with the Authorize attribute. Am I write in my assumption ? Anyhow I did what you've suggested and it works great. Once again, many thanks...


feat: add check-consistency option

The reason for check failure seems to be that my forked repository does not contain any tags, not the implementation.


Fix: add provider filter for RDS

Relevant information
Added the provider filter to RDS entities. We're seeing shimming errors and we believe it might be because of this missing filter.
Checklist

[ ] I've read the guidelines and understand the acceptance criteria.
[ ] The value of the attribute marked as identifier will be unique and valid.
[ ] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

This is related to the slack discussion with Jose, right @jlegoff?

@IreneMLC yes!


adds example of logging to console to cheatsheet

Make sure to fill out everything below — your pull request won't be merged until you do!
Check all applicable boxes below (put an x in between the square brackets, with no spaces)

[x] This is to fix an issue. Issue #:
[x] If I modified anything other than comments, I ran npm run build and npm test

Summary
Explain your pull request
This pull request is associated with issue number #83

Thanks! You're now a contributor to Squirrelly!


Support ua override

Epic: #61
query param "ua" can override http header's user-agent

Commit #88


Improve status messages

:tada: This PR is included in version 1.9.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Missing ConnectedRouter export

ConnectedRouter is not properly exported in 5.0.0-alpha.8.
$ head node_modules/react-router-redux/package.json
{
  "name": "react-router-redux",
  "version": "5.0.0-alpha.8",

// index.js

import * as RRR from "react-router-redux"

console.log(Object.keys(RRR))
// ["syncHistoryWithStore","routerMiddleware","LOCATION_CHANGE","routerReducer","CALL_HISTORY_METHOD","push","replace","go","goBack","goForward","routerActions"]

// This does work though:
import ConnectedRouter from "react-router-redux/ConnectedRouter"

You should clean up your node_modules. You are importing from react-router-redux v4; there is no syncHistoryWithStore in r-r-r v5.


turbo.es2017-esm.js.map 404 error

We're using Turbo in a Laravel Mix environment, which uses Webpack 5 in the background.
After importing and setting everything up the logic works fine, expect that the browser outputs an error that the sourcemap cannot be found. What's the best practice around this?
Warning:

Setup:
import * as Turbo from '@hotwired/turbo';

window.Turbo = Turbo
Turbo.start()

@mbardelmeijer Adding .version() resolved this for me; cache busting. Turbo documentation recommends cache busting, so may have something to do with it.


Docker Permission to jenkins

Permission denied when trying to connect to Docker daemon with Jenkins

sudo usermod -a -G docker jenkins

sudo systemctl restart jenkins


Insight into "auto-commit mode" error

I am trying to write an Airflow hook for connecting to Athena, and I'm getting this error about 'Athena JDBC connection is only supported for auto-commit mode.'  Can you offer any insight into this error?
`class AthenaHook(S3Hook):
"""
Hook to work with Athena and associated data in S3 buckets.
"""
def __init__(self, s3_staging_dir, aws_conn_id):
    self.region_name = None
    self.conn = None
    self.s3_staging_dir = s3_staging_dir
    super(AthenaHook, self).__init__(aws_conn_id)

def connect(self,**kwargs):
    """
    Connect to Athena using JDBC. Credentials handled by S3hook
    """

    credentials = map(str, self.get_credentials())
    self.conn = jdbc_connect(
        s3_staging_dir=self.s3_staging_dir,
        access_key=credentials[0],
        secret_key=credentials[1],
        region_name=self.region_name
    )

def dataframe(self, query):
    """
    Pull the results of a query into a data frame

    Args:
        query(str): A SQL query to be run in Athena.

    Returns:
        (pd.DataFrame): A dataframe containing the results of the query
    """
    return pd.read_sql(query, self.conn)

class AthenaPlugin(AirflowPlugin):
name = "athena_plugin"
hooks = [AthenaHook]
`
Here is the traceback:
In [15]: hook.dataframe('SELECT * from posterior_db.strain_posterior_local LIMIT 10')

[2017-11-08 14:19:27,349] {cursor.py:193} ERROR - Failed to execute query.
Traceback (most recent call last):
File "/home/rness/projects/ztl/venv/lib/python2.7/site-packages/pyathenajdbc/cursor.py", line 172, in execute
result_set = self._statement.executeQuery(query)
java.sql.SQLExceptionPyRaisable: java.sql.SQLException: Failed to run query
DatabaseError                             Traceback (most recent call last)
 in ()
----> 1 hook.dataframe('SELECT * from posterior_db.strain_posterior_local LIMIT 10')
/home/rness/projects/ztl/zflow/plugins/athena_plugin.pyc in dataframe(self, query)
55             (pd.DataFrame): A dataframe containing the results of the query
56         """
---> 57         return pd.read_sql(query, self.conn)
58
59
/home/rness/projects/ztl/venv/lib/python2.7/site-packages/pandas/io/sql.pyc in read_sql(sql, con, index_col, coerce_float, params, parse_dates, columns, chunksize)
397             sql, index_col=index_col, params=params,
398             coerce_float=coerce_float, parse_dates=parse_dates,
--> 399             chunksize=chunksize)
400
401     try:
/home/rness/projects/ztl/venv/lib/python2.7/site-packages/pandas/io/sql.pyc in read_query(self, sql, index_col, coerce_float, params, parse_dates, chunksize)
1434
1435         args = _convert_params(sql, params)
-> 1436         cursor = self.execute(*args)
1437         columns = [col_desc[0] for col_desc in cursor.description]
1438
/home/rness/projects/ztl/venv/lib/python2.7/site-packages/pandas/io/sql.pyc in execute(self, *args, **kwargs)
1407                 ex = DatabaseError("Execution failed on sql: %s\n%s\nunable"
1408                                    " to rollback" % (args[0], exc))
-> 1409                 raise_with_traceback(ex)
1410
1411             ex = DatabaseError(
/home/rness/projects/ztl/venv/lib/python2.7/site-packages/pandas/io/sql.pyc in execute(self, *args, **kwargs)
1403         except Exception as exc:
1404             try:
-> 1405                 self.con.rollback()
1406             except Exception:  # pragma: no cover
1407                 ex = DatabaseError("Execution failed on sql: %s\n%s\nunable"
/home/rness/projects/ztl/venv/lib/python2.7/site-packages/pyathenajdbc/connection.pyc in rollback(self)
148
149     def rollback(self):
--> 150         raise NotSupportedError('Athena JDBC connection is only supported for auto-commit mode.')
DatabaseError: Execution failed on sql: SELECT * from posterior_db.strain_posterior_local LIMIT 10
java.sql.SQLException: Failed to run query
unable to rollback

Does the error appear in the history of the Athena Web console?
And if you know the query ID, you can also use Boto3 to see details, so please check it.
http://boto3.readthedocs.io/en/latest/reference/services/athena.html#Athena.Client.get_query_execution

I am also getting same error. When I am executing pd.Read_sql statement it is showing results in athena but in python I am getting below error:
NotSupportedError: Athena JDBC connection is only supported for auto-commit mode.
Below is the code
df_700 = pd.read_sql('SELECT * FROM jqerosh.alestbun_nioi_1110 limit 10', conn, chunksize=10)
Please help

yes the same error occur using pyathenajdbc library. This is the stack
trace of the exception:
Failed to execute query.
Traceback (most recent call last):
File "C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py",
line 181, in execute
query_execution = self._query_execution()
File "C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py",
line 145, in _query_execution
client = self._athena_client()
File "C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py",
line 140, in _athena_client
field.setAccessible(True)
jpype._jexception.java.lang.NullPointerExceptionPyRaisable:
java.lang.NullPointerException
---------------------------------------------------------------------------java.lang.NullPointerExceptionPyRaisable
Traceback (most recent call
last)C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py
in execute(self, operation, parameters)    180
self._update_count = self._statement.getUpdatecount()--> 181
query_execution = self._query_execution()    182
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py in
_query_execution(self)    144     def _query_execution(self):--> 145
client = self._athena_client()
146         request = jpype.JPackage('com.amazonaws.athena.jdbc.shaded.' +

C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py in
_athena_client(self)    139             if field.name ==
'athenaServiceClient':--> 140
field.setAccessible(True)    141                 return
field.get(self._connection).getClient()
java.lang.NullPointerExceptionPyRaisable: java.lang.NullPointerException
The above exception was the direct cause of the following exception:
DatabaseError                             Traceback (most recent call
last)C:\Users\parth\Anaconda3\lib\site-packages\pandas\io\sql.py in
execute(self, *args, **kwargs)   1403             else:-> 1404
cur.execute(*args)   1405             return cur
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\util.py in
_wrapper(*args, **kwargs)     33
jpype.attachThreadToJVM()---> 34         return wrapped(*args,
**kwargs)     35     return _wrapper
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\util.py in
_wrapper(*args, **kwargs)     23         with _lock:---> 24
return wrapped(*args, **kwargs)     25     return _wrapper
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py in
execute(self, operation, parameters)    194
logger.exception('Failed to execute query.')--> 195
raise_from(DatabaseError(unwrap_exception(e)), e)    196
C:\Users\parth\Anaconda3\lib\site-packages\future\utils_init.py in
raise_from(exc, cause)    397         execstr = "raise
__python_future_raise_from_exc from
__python_future_raise_from_cause"--> 398         exec(execstr,
myglobals, mylocals)    399
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\cursor.py in ()
DatabaseError: java.lang.NullPointerException
During handling of the above exception, another exception occurred:
NotSupportedError                         Traceback (most recent call
last)C:\Users\parth\Anaconda3\lib\site-packages\pandas\io\sql.py in
execute(self, *args, **kwargs)   1407             try:-> 1408
self.con.rollback()   1409             except Exception:  #
pragma: no cover
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\connection.py
in rollback(self)    157     def rollback(self):--> 158         raise
NotSupportedError('Athena JDBC connection is only supported for
auto-commit mode.')
NotSupportedError: Athena JDBC connection is only supported for
auto-commit mode.
During handling of the above exception, another exception occurred:
DatabaseError                             Traceback (most recent call
last) in ()      1 query =
'SELECT * FROM josh.buxton_imei_1110 limit 10'----> 2 df_700 =
pd.read_sql(query, conn, chunksize=10)      3       4
df_700C:\Users\parth\Anaconda3\lib\site-packages\pandas\io\sql.py in
read_sql(sql, con, index_col, coerce_float, params, parse_dates,
columns, chunksize)    398             sql, index_col=index_col,
params=params,    399             coerce_float=coerce_float,
parse_dates=parse_dates,--> 400             chunksize=chunksize)
401     402     try:
C:\Users\parth\Anaconda3\lib\site-packages\pandas\io\sql.py in
read_query(self, sql, index_col, coerce_float, params, parse_dates,
chunksize)   1437    1438         args = convert_params(sql,
params)-> 1439         cursor = self.execute(*args)   1440
columns = [col_desc[0] for col_desc in cursor.description]   1441
C:\Users\parth\Anaconda3\lib\site-packages\pandas\io\sql.py in
execute(self, *args, **kwargs)   1410                 ex =
DatabaseError("Execution failed on sql: %s\n%s\nunable"   1411
" to rollback" % (args[0], exc))-> 1412
raise_with_traceback(ex)   1413    1414             ex =
DatabaseError(
C:\Users\parth\Anaconda3\lib\site-packages\pandas\compat_init.py
in raise_with_traceback(exc, traceback)    342         if traceback ==
Ellipsis:    343             _, _, traceback = sys.exc_info()--> 344
raise exc.with_traceback(traceback)    345 else:    346     #
this version of raise is a syntax error in Python 3
C:\Users\parth\Anaconda3\lib\site-packages\pandas\io\sql.py in
execute(self, *args, **kwargs)   1406         except Exception as exc:
1407             try:-> 1408                 self.con.rollback()
1409             except Exception:  # pragma: no cover   1410
ex = DatabaseError("Execution failed on sql: %s\n%s\nunable"
C:\Users\parth\Anaconda3\lib\site-packages\pyathenajdbc\connection.py
in rollback(self)    156     157     def rollback(self):--> 158
raise NotSupportedError('Athena JDBC connection is only supported for
auto-commit mode.')
DatabaseError: Execution failed on sql: SELECT * FROM
josh.buxton_imei_1110 limit 10
java.lang.NullPointerException
unable to rollback
On Tue, Jun 26, 2018 at 6:25 PM, laughingman7743<EMAIL_ADDRESS>wrote:

Does the same error occur in the following libraries?
https://github.com/laughingman7743/PyAthena
I would like to know the stack trace of the exception.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/laughingman7743/PyAthenaJDBC/issues/50#issuecomment-400482668,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ajr51LUMw2gXP9-bWgmk9z0pvpVX5SSzks5uArTHgaJpZM4QXJVu
.

Will it work out if you use read_sql_query?
https://github.com/laughingman7743/PyAthena/issues/30#issuecomment-377737640

Yes I tried with both functions. Still getting same error.

Same problem here. It seems a problem of pd.read_sql() or read_sql_query. The table definition is same as the example of one_row_complex.

I get the same error with this small example.
`from pyathenajdbc import connect
import pandas as pd
conn = connect(access_key='KEY',
secret_key='KEY"',
s3_staging_dir='DIR',
region_name='eu-central-1')
df = pd.read_sql_query("SELECT TRUE", conn)`

Perhaps it depends on the version of pandas?
It seemed that there would be no problem if the following libraries were installed in a virtual env environment.
botocore==1.12.0
docutils==0.14
future==0.16.0
jmespath==0.9.3
JPype1==0.6.3
numpy==1.15.1
pandas==0.23.4
PyAthenaJDBC==1.3.3
python-dateutil==2.7.3
pytz==2018.5
six==1.11.0
urllib3==1.23

Pipfile:
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
pandas = "*"
pyathenajdbc = "*"

[dev-packages]

[requires]
python_version = "3.6"

Pipfile.lock:
{
    "_meta": {
        "hash": {
            "sha256": "48cd71ffb13391fb4aeac611ad388feefe346734c0d754d69f5024fef1a43ec0"
        },
        "pipfile-spec": 6,
        "requires": {
            "python_version": "3.6"
        },
        "sources": [
            {
                "name": "pypi",
                "url": "https://pypi.org/simple",
                "verify_ssl": true
            }
        ]
    },
    "default": {
        "botocore": {
            "hashes": [
                "sha256:354dd98082dc1ca8aa127f5aff0e28404363f94a8c13c9a9ddbd24b9a70eb259",
                "sha256:81b0b15f5cfe16bce7280010daaee4c88c046aa0eef0b65432cf4832a0d8c5e8"
            ],
            "version": "==1.12.0"
        },
        "docutils": {
            "hashes": [
                "sha256:02aec4bd92ab067f6ff27a38a38a41173bf01bed8f89157768c1573f53e474a6",
                "sha256:51e64ef2ebfb29cae1faa133b3710143496eca21c530f3f71424d77687764274",
                "sha256:7a4bd47eaf6596e1295ecb11361139febe29b084a87bf005bf899f9a42edc3c6"
            ],
            "version": "==0.14"
        },
        "future": {
            "hashes": [
                "sha256:e39ced1ab767b5936646cedba8bcce582398233d6a627067d4c6a454c90cfedb"
            ],
            "version": "==0.16.0"
        },
        "jmespath": {
            "hashes": [
                "sha256:6a81d4c9aa62caf061cb517b4d9ad1dd300374cd4706997aff9cd6aedd61fc64",
                "sha256:f11b4461f425740a1d908e9a3f7365c3d2e569f6ca68a2ff8bc5bcd9676edd63"
            ],
            "version": "==0.9.3"
        },
        "jpype1": {
            "hashes": [
                "sha256:6841523631874a731e1f94e1b1f130686ad3772030eaa3b6946256eeb1d10dd1"
            ],
            "version": "==0.6.3"
        },
        "numpy": {
            "hashes": [
                "sha256:1c362ad12dd09a43b348bb28dd2295dd9cdf77f41f0f45965e04ba97f525b864",
                "sha256:2156a06bd407918df4ac0122df6497a9c137432118f585e5b17d543e593d1587",
                "sha256:24e4149c38489b51fc774b1e1faa9103e82f73344d7a00ba66f6845ab4769f3f",
                "sha256:340ec1697d9bb3a9c464028af7a54245298502e91178bddb4c37626d36e197b7",
                "sha256:35db8d419345caa4eeaa65cd63f34a15208acd87530a30f0bc25fc84f55c8c80",
                "sha256:361370e9b7f5e44c41eee29f2bb5cb3b755abb4b038bce6d6cbe08db7ff9cb74",
                "sha256:36e8dcd1813ca92ce7e4299120cee6c03adad33d89b54862c1b1a100443ac399",
                "sha256:378378973546ecc1dfaf9e24c160d683dd04df871ecd2dcc86ce658ca20f92c0",
                "sha256:419e6faee16097124ee627ed31572c7e80a1070efa25260b78097cca240e219a",
                "sha256:4287104c24e6a09b9b418761a1e7b1bbde65105f110690ca46a23600a3c606b8",
                "sha256:549f3e9778b148a47f4fb4682955ed88057eb627c9fe5467f33507c536deda9d",
                "sha256:5e359e9c531075220785603e5966eef20ccae9b3b6b8a06fdfb66c084361ce92",
                "sha256:5ee7f3dbbdba0da75dec7e94bd7a2b10fe57a83e1b38e678200a6ad8e7b14fdc",
                "sha256:62d55e96ec7b117d3d5e618c15efcf769e70a6effaee5842857b64fb4883887a",
                "sha256:719b6789acb2bc86ea9b33a701d7c43dc2fc56d95107fd3c5b0a8230164d4dfb",
                "sha256:7a70f2b60d48828cba94a54a8776b61a9c2657a803d47f5785f8062e3a9c7c55",
                "sha256:7b9e37f194f8bcdca8e9e6af92e2cbad79e360542effc2dd6b98d63955d8d8a3",
                "sha256:83b8fc18261b70f45bece2d392537c93dc81eb6c539a16c9ac994c47fc79f09a",
                "sha256:9473ad28375710ab18378e72b59422399b27e957e9339c413bf00793b4b12df0",
                "sha256:95b085b253080e5d09f7826f5e27dce067bae813a132023a77b739614a29de6e",
                "sha256:98b86c62c08c2e5dc98a9c856d4a95329d11b1c6058cb9b5191d5ea6891acd09",
                "sha256:a3bd01d6d3ed3d7c06d7f9979ba5d68281f15383fafd53b81aa44b9191047cf8",
                "sha256:c81a6afc1d2531a9ada50b58f8c36197f8418ef3d0611d4c1d7af93fdcda764f",
                "sha256:ce75ed495a746e3e78cfa22a77096b3bff2eda995616cb7a542047f233091268",
                "sha256:dae8618c0bcbfcf6cf91350f8abcdd84158323711566a8c5892b5c7f832af76f",
                "sha256:df0b02c6705c5d1c25cc35c7b5d6b6f9b3b30833f9d178843397ae55ecc2eebb",
                "sha256:e3660744cda0d94b90141cdd0db9308b958a372cfeee8d7188fdf5ad9108ea82",
                "sha256:f2362d0ca3e16c37782c1054d7972b8ad2729169567e3f0f4e5dd3cdf85f188e"
            ],
            "version": "==1.15.1"
        },
        "pandas": {
            "hashes": [
                "sha256:11975fad9edbdb55f1a560d96f91830e83e29bed6ad5ebf506abda09818eaf60",
                "sha256:12e13d127ca1b585dd6f6840d3fe3fa6e46c36a6afe2dbc5cb0b57032c902e31",
                "sha256:1c87fcb201e1e06f66e23a61a5fea9eeebfe7204a66d99df24600e3f05168051",
                "sha256:242e9900de758e137304ad4b5663c2eff0d798c2c3b891250bd0bd97144579da",
                "sha256:26c903d0ae1542890cb9abadb4adcb18f356b14c2df46e4ff657ae640e3ac9e7",
                "sha256:2e1e88f9d3e5f107b65b59cd29f141995597b035d17cc5537e58142038942e1a",
                "sha256:31b7a48b344c14691a8e92765d4023f88902ba3e96e2e4d0364d3453cdfd50db",
                "sha256:4fd07a932b4352f8a8973761ab4e84f965bf81cc750fb38e04f01088ab901cb8",
                "sha256:5b24ca47acf69222e82530e89111dd9d14f9b970ab2cd3a1c2c78f0c4fbba4f4",
                "sha256:647b3b916cc8f6aeba240c8171be3ab799c3c1b2ea179a3be0bd2712c4237553",
                "sha256:66b060946046ca27c0e03e9bec9bba3e0b918bafff84c425ca2cc2e157ce121e",
                "sha256:6efa9fa6e1434141df8872d0fa4226fc301b17aacf37429193f9d70b426ea28f",
                "sha256:be4715c9d8367e51dbe6bc6d05e205b1ae234f0dc5465931014aa1c4af44c1ba",
                "sha256:bea90da782d8e945fccfc958585210d23de374fa9294a9481ed2abcef637ebfc",
                "sha256:d318d77ab96f66a59e792a481e2701fba879e1a453aefeebdb17444fe204d1ed",
                "sha256:d785fc08d6f4207437e900ffead930a61e634c5e4f980ba6d3dc03c9581748c7",
                "sha256:de9559287c4fe8da56e8c3878d2374abc19d1ba2b807bfa7553e912a8e5ba87c",
                "sha256:f4f98b190bb918ac0bc0e3dd2ab74ff3573da9f43106f6dba6385406912ec00f",
                "sha256:f71f1a7e2d03758f6e957896ed696254e2bc83110ddbc6942018f1a232dd9dad",
                "sha256:fb944c8f0b0ab5c1f7846c686bc4cdf8cde7224655c12edcd59d5212cd57bec0"
            ],
            "index": "pypi",
            "version": "==0.23.4"
        },
        "pyathenajdbc": {
            "hashes": [
                "sha256:11be804192b6b09174dee46aa2316669b8c7a068bec79873ff1334c6e00ce108",
                "sha256:d236c146a91b9390e7ccd9e29e1395fde103e20e1feadabf6013a997461d7b98"
            ],
            "index": "pypi",
            "version": "==1.3.3"
        },
        "python-dateutil": {
            "hashes": [
                "sha256:1adb80e7a782c12e52ef9a8182bebeb73f1d7e24e374397af06fb4956c8dc5c0",
                "sha256:e27001de32f627c22380a688bcc43ce83504a7bc5da472209b4c70f02829f0b8"
            ],
            "version": "==2.7.3"
        },
        "pytz": {
            "hashes": [
                "sha256:a061aa0a9e06881eb8b3b2b43f05b9439d6583c206d0a6c340ff72a7b6669053",
                "sha256:ffb9ef1de172603304d9d2819af6f5ece76f2e85ec10692a524dd876e72bf277"
            ],
            "version": "==2018.5"
        },
        "six": {
            "hashes": [
                "sha256:70e8a77beed4562e7f14fe23a786b54f6296e34344c23bc42f07b15018ff98e9",
                "sha256:832dc0e10feb1aa2c68dcc57dbb658f1c7e65b9b61af69048abc87a2db00a0eb"
            ],
            "version": "==1.11.0"
        },
        "urllib3": {
            "hashes": [
                "sha256:a68ac5e15e76e7e5dd2b8f94007233e01effe3e50e8daddf69acfd81cb686baf",
                "sha256:b5725a0bd4ba422ab0e66e89e030c806576753ea3ee08554382c14e685d117b5"
            ],
            "version": "==1.23"
        }
    },
    "develop": {}
}

Script:
#!/usr/bin/env python
# -*- coding: utf-8 -*-
from pyathenajdbc import connect
import pandas as pd

def main():
    conn = connect(s3_staging_dir='s3://BUCKET/path/to/',
                   region_name='us-west-2')
    df = pd.read_sql_query("SELECT TRUE", conn)
    print(df.describe())

if __name__ == '__main__':
    main()

Ok, this is strange.
I created a virtual environment with Python 3.6.5 and all packages with the version you said. Nevertheless, I get the same error. It doesn't matter if I use pd.read_sql or pd.read_sql_query.
Here is the error.
log4j:WARN No appenders could be found for logger (com.amazonaws.athena.jdbc.AthenaDriver).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Failed to execute query.
Traceback (most recent call last):
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 181, in execute
    query_execution = self._query_execution()
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 145, in _query_execution
    client = self._athena_client()
  File "MYVENV/myenv/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 140, in _athena_client
    field.setAccessible(True)
jpype._jexception.java.lang.NullPointerExceptionPyRaisable: java.lang.NullPointerException
Traceback (most recent call last):
  File "MYVENV/myenv/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 181, in execute
    query_execution = self._query_execution()
  File "MYVENV/myenv/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 145, in _query_execution
    client = self._athena_client()
  File "MYVENV/myenv/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 140, in _athena_client
    field.setAccessible(True)
jpype._jexception.NullPointerExceptionPyRaisable: java.lang.NullPointerException

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/MYVENV/lib/python3.6/site-packages/pandas/io/sql.py", line 1378, in execute
    cur.execute(*args)
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/util.py", line 34, in _wrapper
    return wrapped(*args, **kwargs)
  File "/MYVENV/myenv/lib/python3.6/site-packages/pyathenajdbc/util.py", line 24, in _wrapper
    return wrapped(*args, **kwargs)
  File "/MYVENV/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 195, in execute
    raise_from(DatabaseError(unwrap_exception(e)), e)
  File "MYVENV/lib/python3.6/site-packages/future/utils/__init__.py", line 398, in raise_from
    exec(execstr, myglobals, mylocals)
  File "<string>", line 1, in <module>
pyathenajdbc.error.DatabaseError: java.lang.NullPointerException

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "MYVENV/lib/python3.6/site-packages/pandas/io/sql.py", line 1382, in execute
    self.con.rollback()
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/connection.py", line 158, in rollback
    raise NotSupportedError('Athena JDBC connection is only supported for auto-commit mode.')
pyathenajdbc.error.NotSupportedError: Athena JDBC connection is only supported for auto-commit mode.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "test.py", line 26, in <module>
    main()
  File "test.py", line 21, in main
    df = pd.read_sql("SELECT TRUE", conn)
  File "/MYVENV/lib/python3.6/site-packages/pandas/io/sql.py", line 381, in read_sql
    chunksize=chunksize)
  File "MYVENV/lib/python3.6/site-packages/pandas/io/sql.py", line 1413, in read_query
    cursor = self.execute(*args)
  File "MYVENV/lib/python3.6/site-packages/pandas/io/sql.py", line 1386, in execute
    raise_with_traceback(ex)
  File "MYVENV/lib/python3.6/site-packages/pandas/compat/__init__.py", line 404, in raise_with_traceback
    raise exc.with_traceback(traceback)
  File "MYVENV/lib/python3.6/site-packages/pandas/io/sql.py", line 1382, in execute
    self.con.rollback()
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/connection.py", line 158, in rollback
    raise NotSupportedError('Athena JDBC connection is only supported for auto-commit mode.')
pandas.io.sql.DatabaseError: Execution failed on sql: SELECT TRUE
java.lang.NullPointerException
unable to rollback

A few days ago, everything was fine. Unfortunately, I can't tell if I changed anything that has and impact on that matter.

Traceback (most recent call last):
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 181, in execute
    query_execution = self._query_execution()
  File "MYVENV/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 145, in _query_execution
    client = self._athena_client()
  File "MYVENV/myenv/lib/python3.6/site-packages/pyathenajdbc/cursor.py", line 140, in _athena_client
    field.setAccessible(True)
jpype._jexception.java.lang.NullPointerExceptionPyRaisable: java.lang.NullPointerException

A NullPointerException occurs at the place where query execution information is retrieved. 🤔

I just posted the output. Unfortunately, I don't understand in detail what's going on there. But I'll try everything that might solve the problem.

Sorry, I do not know the cause. There is no problem in my environment.
Since an error has occurred while retriving query execution information, perhaps the role authority of the user executing the query may be different.
If you do not have to be JDBC, please try using PyAthena (https://github.com/laughingman7743/PyAthena).

Which JDBC driver version for Athena are you all using?


xcodebuild args are not being passed to xcodebuild command

Troubleshooting

Which version of the step is effected? current
Is the issue reproducible with the latest version? YES
Does the issue happen sporadically, or every time? EVERY TIME
Is the issue reproducible locally by following our local debug guide? YES

Issue description
https://github.com/DamienBitrise/sample-swift-project-with-parallel-ui-test/blob/master/bitrise.yml#L67
Step does not add the additional xcodebuild args
Command output is:
xcodebuild "test-without-building" "-xctestrun" "./test_bundle/BullsEye_FullTests_iphonesimulator15.5-arm64-x86_64.xctestrun" "-destination" "platform=iOS Simulator,name=iPhone 12 Pro Max" "-resultBundlePath" "/var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/TestOutput3926229233/Test-BullsEye_FullTests_iphonesimulator15.5-arm64-x86_64.xcresult"
Bitrise info

Build URL: https://app.bitrise.io/build/45932781-3b36-45db-950b-5a3e991649a3
Bitrise Support enabled: YES
Log:

+------------------------------------------------------------------------------+
| (0) xcode-test-without-building                                              |
+------------------------------------------------------------------------------+
| id: xcode-test-without-building                                              |
| version: 0.2.0                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: go                                                                  |
| time: 2022-07-26T05:06:39Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[05:06:39]  * [OK] Step dependency (xcode) installed, available.
Input:

xctestrun: ./test_bundle/BullsEye_FullTests_iphonesimulator15.5-arm64-x86_64.xctestrun
destination: platform=iOS Simulator,name=iPhone 12 Pro Max
xcodebuild_options: -parallel-testing-enabled YES -maximum-parallel-testing-workers 3
test_repetition_mode: none
maximum_test_repetitions: 3
relaunch_tests_for_each_repetition: false
BITRISE_DEPLOY_DIR: /Users/vagrant/deploy
BITRISE_TEST_RESULT_DIR: /var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/test_results1965003800/test_result2593922559
Running tests:
[05:06:40] xcodebuild "test-without-building" "-xctestrun" "./test_bundle/BullsEye_FullTests_iphonesimulator15.5-arm64-x86_64.xctestrun" "-destination" "platform=iOS Simulator,name=iPhone 12 Pro Max" "-resultBundlePath" "/var/folders/11/nh0v1jld7zd7b9zqm1774gtm0000gn/T/TestOutput3926229233/Test-BullsEye_FullTests_iphonesimulator15.5-arm64-x86_64.xcresult"

Steps to reproduce

Run the pipline
Parallel Simulators are not enabled

We've just merged in a fix for this. I think we'll wait to do a proper release until @Bence1001 has time to write some unit tests, but pulling the Step using git will work until then.

Fixed in https://github.com/bitrise-steplib/bitrise-step-xcode-test-without-building/releases/tag/0.2.1.


Contact Owners/Support Emails have erroneous markdown formatting

We use markdown in the email bodies of the contact owners and contact support emails.  Inadvertent markdown formatting can lead to formatted text in place of the literal characters.
For instance, a package id with underscores in it leads to italics in the package id instead  of the actual underscores.

Using Markdown seems like a bad mistake. Brokering all this email in the first place seems like another bad mistake.
But given we've got this currently running, it should at least work. Perhaps there is a minimal fix we can drop in here. Otherwise we should close this as won't fix.


Ability to sample interval in date range

Add the ability to provide a stepsize for a data range, i.e. 12 day intervals etc in support of NISAR work.

closed via #152


Error object not in stack on exception

Hi Svaarala,
After some time, updated DukTape and found different things:
I'm using DUK_USE_CPP_EXCEPTIONS and use a try/catch(duk_internal_exception&) to catch for error thrown by native functions and DukTape functions like push/pop operations (I think DukTape api's might throw, mainly, insufficient memory or range errors).
When the error raises (i.e., bad javascript code), exception is raised, duk_err_create_and_throw catches it, pushes the error object and exception and duk_err_longjmp is executed again. At this point my handler catches the error but all available stack items are null.
try {
    duk_pop(ctx); //some code that will raise an error
}
catch (duk_internal_exception&) {
    //at this point stack has nothing.
}

Regards,
Mauro.

When Duktape is using C++ exceptions for long control transfers you're not intended to catch the exceptions yourself. They're just used as a technical means for doing a C++ stack unwind respecting destructors etc. So the protected call sites should just use normal protected calls like duk_pcall(), etc.

Pushing a string, a buffer or growing the stack can lead to memory errors.
Let's say I call duk_create_heap and initialize some global vars/functions from C before executing actual Javascript code. If I run out of mem (or trigger another error like out-of-range), I want to catch them. Also to catch errors raised by custom native functions that could be called by this pre-JS code (i.e. creating some object where its constructor is native code too)
And, if possible, I want to differentiate a range error from an alloc error from a custom error (using duk_error_raw or similar)

Right, that initialization code would be inside a protected call and any errors thrown would have a message indicating if an out-of-memory happened.
When you say you want to differentiate a range error from an alloc error, what would that mean in practice? Would there be a different code path handling the different error types - and if so, what would they do differently?
The errors are already differentiated by their error messages as far as logging, diagnostics etc are concerned. What I'm trying to understand is why you need to programmatically differentiate the errors, and why alloc errors specifically and not a variety of other internal errors.

Trying to clarify, a sample code:
HRESULT RunJsCode(LPCSTR szCodeA)
{
    duk_context *ctx = duk_create_heap(...);
    duk_push_global_object(ctx);
    duk_push_buffer(ctx, 2000, 0);
    duk_push_buffer_object(ctx, -1, 0, 2000, DUK_BUFOBJ_UINT8ARRAY);
    duk_put_prop_string(lpCtx, -2, "\xff""\xff""dummyBuffer");
    duk_eval_string(ctx, szCodeA);
    ....
    return S_OK;
}

a) Assume low mem situation and the call to duk_push_buffer or duk_push_buffer_object fails. How can I catch it? If I'm right the code there is not protected. Or how can I protect it? Tried try/catch your internal exception but for some reason the error object does not appear on stack.
b) Error differentiation is not important. Previously I checked for DUK_ERR_ALLOC_ERROR which I turned into E_OUTOFMEMORY. I believe it is a fatal error, different, i.e., from a range error because one is raised by the system failing and the other by, i.e., bugs in passes javascript code.
If there is something I can use, the better, may be a string but I cannot get error info because the unprotected code above.

You should look into duk_safe_call().  That's how you would protect arbitrary Duktape code.  If an error is thrown during the duration of the safe call, the call will return 1 with the error on the stack.

Thanks @fatcerberus. I'll see it. A quick view indicates it is the function I need to solve my problems hehe.

@svaarala If nrets == 0 in a call to duk_safe_call that returns DUK_EXEC_ERROR, then the error object is removed from stack too.

That's documented behavior and not a bug:

If an error occurs, the stack will still have nrets values at "base index"; the first of such values is the error, and the remaining values are undefined. If nrets is zero, the error will not be present on the stack (the return stack top will equal the "base index"), so calling this function with nrets as 0 is not very useful.

Thanks again @fatcerberus.

@mxmauro No problem, always happy to help.


Fineract 853

Description
Added spotbugsplugin "com.h3xstream.findsecbugs:findsecbugs-plugin:1.8.0" to dependencies.gradle and dev-dependencies.gradle.
To fix issue   ## FINERACT-853
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

[ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

[ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.

[ ] Integration tests have been created/updated for verifying the changes made.

[ ] All Integrations tests are passing with the new commits.

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)

Hello @vorburger
Can you review my PR and correct it

@DBryzz hello, can you please change the commit messege? It is recommended that the commit messege starts with issue number 😃

Also, 2 commit messages for 1 PR does not look good in the commit history. So i suggests you squash your commit messages into a single message and don't forget to apply @thesmallstar comment.

Thanks for your comments
I will work on them
On Wed, Apr 1, 2020 at 12:08 PM Yemdjih Kaze Nasser <
<EMAIL_ADDRESS>wrote:

Also, 2 commit messages for 1 PR does not look good in the commit history.
So i suggests you squash your commit messages into a single message and
don't forget to apply @thesmallstar https://github.com/thesmallstar
comment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/fineract/pull/749#issuecomment-607185025, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMBFONBUYTV2UVTWR77QESLRKMOCFANCNFSM4LXWWRXA
.

@DBryzz try adding

spotbugsMain.maxHeapSize = '2g'

To the build.gradle and fix the violation that come up.

Greetings
Thanks for your review and comments @vorburger. I will try to find out why CORS is the only violation findsecbug detects.
Regarding the Overly permissive CORS policy, I located the file and the violation is due to the line response.setHeader("Access-Control-Allow-Origin", "*"); in class org.apache.fineract.infrastructure.security.filter.TenantAwareTenantIdentifierFilter

needs to be replaced by a particular domain. I'll be happy if I someone could help me with the domain.

Thanks

@DBryzz Following #764 and #761 this will pass the build (or not at least not fail because of integration tests) if you rebase this now.

@DBryzz see (new) https://github.com/apache/fineract#pull-requests and do not wait for an active maintainer to come and help you re. build failures - it's your responsibility to get a green build. Have you checked the log, and done what the README suggests to do in such cases? :smiley_cat:

Hello @DBryzz can you please solve the conflicts? if this still fails due to "flaky" test please follow the readme :)


Ability to delete files

Thanks in advance guys!
So pull, publish works great but is it possible to delete files straight from Code?

@sg-chrishasz, as a proposal for this feature: sppurge can be integrated in the same way like sppull and spsave, it used the same principals on the background.

@quachhongak, I referenced to a library which could be integrated to SPGo by the extension authors. It's a raw Node.js library and some reasonable affords needed to add it to VS Code extension. Yet, as a console command, it can be easily executed i.e. as a Gulp task.

@koltyakov I will look into sppurge as a solution for file deletes. Thanks for the reference!

I have just published 1.3.0 to the VS Marketplace which supports file delete as a context-menu command. Thanks for the feedback and support of SPGo! Closing this issue.

Thank YOU!!!


pugixml: fix darwin build

Motivation for this change
This should fix things on darwin by disabling the long long option.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Quick question: how do we not have long long on Darwin? That really surprises me...
Also, if we really don't (doesn't the configure script try to figure out if it works automatically?), shouldn't this disable the PUGIXML_HAS_LONG_LONG variable rather than patching the CMakeLists file?

@copumpkin I think it's just a CMake problem. Somehow it's not finding a "target_compile_features" for our clang. Here's the error you get without it:
CMake Error at CMakeLists.txt:30 (target_compile_features):
  target_compile_features no known features for CXX compiler

  "Clang"

  version 3.7.1.

-- Configuring incomplete, errors occurred!

I think so


+r command not working

The "send_server+r" command isn't working when I try to use it on my own server, although when I use it on another it works fine. All other bot commands work on the server fine as well.
Ex: "send_server+r "Voltaire" anon If we can just get back to Earth, and find Halsey, she can fix this." Will work accordingly on the Voltaire server the way it is supposed to easily, although the almost exact same command: "send_server+r "Basin City" anon-chat If we can just get back to Earth, and find Halsey, she can fix this." gives no results.

Side Note: Sorry if there isn't enough detail or anything else, never used this site before, nor am I used to writing issue reports like this.

@Borksie - that is odd. I am unable to recreate currently. Would you mind inviting me to one of your servers to help debug? Otherwise, can I get your server's ID?


Update history to new format

Fix does not work. After opening a request in the history, errors are permanently displayed in the console, CPU load increases and details about the opened motion are not displayed in the client.

@MSoeb did you test in conjunction with https://github.com/OpenSlides/openslides-backend/pull/1356? Also, you have to clear all existing informations before trying it out, which I explained in the backend PR. Executing UPDATE positions SET information=NULL in the postgres DB suffices - maybe @peb-adr can assist you in this as well.

@MSoeb did you test in conjunction with OpenSlides/openslides-backend#1356? Also, you have to clear all existing informations before trying it out, which I explained in the backend PR. Executing UPDATE positions SET information=NULL in the postgres DB suffices - maybe @peb-adr can assist you in this as well.

No, I do not assume that I have tested this in the configuration. I did not know that. I discuss everything else with @m-schieder or @peb-adr

needs improvement. errors still appear. talked with @jsangmeister about it.

I had been talking to Magnus about this PR. He mentioned that with this PR in combination with https://github.com/OpenSlides/openslides-backend/pull/1356 the existing chronicle will no longer be available. This is problematic because the chronicle is already in use and existing data will be lost. We should urgently avoid this. The optimal solution would be one that preserves the existing data. We need to discuss the implementation before publishing. @emanuelschuetze @jsangmeister @r-peschke

Open the history of an old motion (created on main branch with some changes) you get a type error - the history table is empty:
TypeError: position.information is not iterable
    at HistoryListComponent.parseInformation (history-list.component.ts:212:43)

Did you clear the position information as described above? Also, did you test in conjunction with the backend branch? When I try to reproduce it including the clearing (create motion and change status on current main - checkout this branch and the backend history branch - clear position information - go into history of motion), I don't get any error. When I update the state again, the entry is correctly appended to the history.


Can I place the

Is it possible to put the automatic output in a CSS file? Instead of the standard way between the  style id='kirki-styles-inline-css' type='text/css' tags in the header?

Or do I need to create a CSS file where I declear all my options with get_theme_mod?

Is there an easy way to turn off the output to the header so I can copy the ouput to a CSS file myself if it's not possible to put the output in a CSS file?

Thanks in advance!

I have solved my issue by changing the file: class-kirki-styles-frontend.php

@RonalddeRooij could you please let me know you did exactly?
I'll be implementing something similar soon, so it would be nice to see how you did that

The "issue" that we had was that the output was visible in the souce code (ctrl + u). I made some changes, which you had commented in the following file: class-kirki-styles-frontend.php. The ouput isn't visible anymore when i'm looking in the source. It's generatting the following CSS file when inspecting the elements that have been affected by kirki: admin-ajax.php?action=kirki_dynamic_css
I made those changes in the following website: http://acheron.staging.caramelo-media.nl/
URL to the dynamic CSS: http://acheron.staging.caramelo-media.nl/wp-admin/admin-ajax.php?action=kirki_dynamic_css
I'm guessing that you are trying to do something else. If needed let me know and I can send my changed class-kirki-styles-frontend.php

oh! ok, gotcha.
The ajax method is still a work in progress, that's why it's not (yet) the default method. :)
You shouldn't have any issues with that though.

Nope, I didn't have any issues yet! Looking forward for the default method, this is really an awesome feature. Good luck with future development!!

Hey Ronaldde, would you be able to share what you done with the class-kirki-styles-frontend.php file? Would like to use the ajax method before releasing my theme! Many thanks.

@scopeak since this is a work in progress, I've simply commented-out these methods.
You can uncomment these lines if you want to try it:
https://github.com/aristath/kirki/blob/2.0.8/includes/class-kirki-styles-frontend.php#L36-L47
https://github.com/aristath/kirki/blob/2.0.8/includes/class-kirki-styles-frontend.php#L59-L66

@aristath I did uncomment those but was still receiving the inline option after a cache refresh. Is there anything else I need to do to default ajax?

Yes, change line 41 from this:
if ( ! $wp_customize && ( isset( $config['inline_css'] ) && false == $config['inline_css'] ) ) {

to this:
if ( ! $wp_customize || ( isset( $config['inline_css'] ) && false == $config['inline_css'] ) ) {

Please keep in mind that a few things may change there by the time we release this feature...
This is a very early version of what we want to implement.

Okay, i'll do some testing and keep that in mind. Cheers!

@aristath Thanks for helping Scopeak !!


Hyperparameter sweep "crashed" logging is false

If a hyperparameter sweep run uses patience to stop, you'll see something like the following logged:
sweep.py INFO: 27-Dec-24 01:15:00 - Monitored metric val_loss did not improve in the last 10 records. Best score: 0.543. Signaling Trainer to stop.

However, W&B treats this is as a "crash" rather than a successful halt. This is strange. Perhaps when patience halts training, it returns a non-zero error code. Assuming this is a unique error code and different than the error code used for actual crashes, we could intercept it here to eliminate this.

My hypothesis about what is happening is wrong. Early stopping doesn't give you a non-zero error code.


rpi-clone to img file

Is it possible to use rip-clone to write not to an sd-card but to a img file (perhaps created with dd)? If so, how to?

hi. also a feature-request:
maybe you change your scprit to rsync backups over the net/lan to a central rasperry-backupserver?
i find your script juseful. thanx a lot..

For exporting to img, dd can do the stuff :
(sudo) dd if=<your_sd_disk> of=/path/to/your/img bs=1M

+1 for this feature request.

+1
I worked on a litte script and I used loopback devices.
It would be very nice, because you can deal with image files with all advantages... and if you need a "real" clone you dd the file to a sd-card.

+1 for ability to write to an image file while ignoring open/temp files and also truncating to a small file.

+1 for image file support.

+1 for image file support!

Is it possible to use rip-clone to write not to an sd-card but to a img file (perhaps created with dd)? If so, how to?

Hi all,
I believe this could be possible with small changes to rpi-clone, but I do not have enough knowledge, I'd probably mung it.
What I've done so far:

Mounted a SMB share on /media.
Created a zero filled file, /media/rpibup.img, a tad larger than the sum of the boot partition and main partition's used space.
Loop mounted the above file, with -Pf params.
Launched rpi-clone: sudo rpi-clone loop0 --exclude=/media/*.

Here's the output:
 Initializing
  Imaging past partition 1 start.
  => dd if=/dev/mmcblk0 of=/dev/loop0 bs=1M count=8 ...
  Resizing destination disk last partition ...
    Resize success.
  Changing destination Disk ID ...Re-reading the partition table failed.: Invalid argument

  => mkfs -t vfat -F 32  /dev/loop01 ...
  => mkfs -t ext4  /dev/loop02 ...

Syncing file systems (can take a long time)
Syncing mounted partitions:
  Mounting /dev/loop02 on /mnt/clone
mount: special device /dev/loop02 does not exist
    Mount failure of /dev/loop02 on /mnt/clone.
Aborting!

Script's trying to operate on partitions /dev/loop0[12], while loopback calls them this way (a "p" between device's name and partition no.):
Device       Boot  Start      End  Sectors  Size Id Type
/dev/loop0p1        8192   532479   524288  256M  c W95 FAT32 (LBA)
/dev/loop0p2<PHONE_NUMBER>9999 24667520 11.8G 83 Linux

I can guess two solutions: having loopback not to insert that letter, or make rpi-clone loopback aware. Is any viable?
TIA, cheers!


Add helm Charts

This pull request adds helm charts to create a deployment via Kubernetes. The documentation is updated accordingly.

Thanks a lot for your review, @carslen! I updated the helm charts and resolved all your suggested changes and further included a README.md, generated with helm.docs as suggested that follows the guidelines mentioned in TRG 5.02.


Add spike docs for using computer vision

Includes a working Jupyter notebook demonstrating how to
ingest and chat with image based data

Closes #713

I'd like to understand what changes we will be making (and where) in Chat With Your Data based on what we learned from this spike. Doesn't have to be part of this PR, as long as it is written somewhere, even if just a github issue.

I've not looked closely at the code as yet. It won't look exactly like the code here as in reality we have things like openai functions and langchain to factor in. However, I've written up a task list here https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/issues/323, I'll then look more in detail at what's required for each step when I get to that point. Does that suffice?


fscache: print error message when nydusd can't start

At present, nydusd says nothing before exit. It's
better to give users and developers a message about
what's going on.
Signed-off-by: Changwei Ge<EMAIL_ADDRESS>

@changweige , a new test job has been submitted. Please wait in patience.

@changweige , The CI test is completed, please check result:

Test CaseTest Result

merge-target-branch:white_check_mark:SUCCESS

build-docker-image:white_check_mark:SUCCESS

compile-nydus:white_check_mark:SUCCESS

compile-ctr-remote:white_check_mark:SUCCESS

compile-nydus-snapshotter:white_check_mark:SUCCESS

start-nydus-snapshotter-config-containerd:white_check_mark:SUCCESS

run-container-with-nydus-image:white_check_mark:SUCCESS

Congratulations, your test job passed!

@changweige , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@changweige , your test job has passed, and no need to test again.


supported authentication mechanisms per handler are documented

Ultimately handlers are made up of 2 things:

General Protocol Awareness
Implementations of Authentication Mechanisms e.g. Mongo has SCRAM (Default), x.509 Certificate Authentication etc.

The bare minimum for a handler to be called 'supported' is 1. and at least one of 2.
Documenting the status of each handler is important:

[ ] to manage our development efforts
[ ] to be transparent to users of Secretless about what's currently available for consumption e.g. https://github.com/golang/go/wiki/SQLDrivers

Moved to cyberark/secretless-docs#164


Customized dashboard

Changes

How to test these changes?

Related issues

@zomglings  required changes fix them in branch https://github.com/bugout-dev/moonstream/pull/476 wich was merge to customized-dashboard
`dashboard_subscriptions -> subscription_settings`

Also make the appropriate change on frontend.

Need run subscription migration.
python -m moonstreamapi.admin.cli migrations run --id 20211202


question about create factors

how do I use the last N days of closing prices to create factors? for example, using RSI to create factors that can be used in alphalens? I am talking about calculation not using quantopian's pipeline.

Please have a look at the examples, they don't use Quantopian's Pipeline.  Once you have the price data you can make use of Pandas' functionalities to compute what you need. Also make sure to read the documentation of alphalens.utils.get_clean_factor_and_forward_return to understand how to properly format the factor data.

Thanks a lot for your quick response! It seems that The examples create
factors by simulated data. How do I create factors based on prices series
for example RSI?
Thanks much!
On Wed, Aug 1, 2018, 8:31 AM luca-s<EMAIL_ADDRESS>wrote:

Please have a look at the examples
https://github.com/quantopian/alphalens/tree/master/alphalens/examples,
they don't use Quantopian's Pipeline. Once you have the price data you can
make use of Pandas' functionalities to compute what you need. Also make
sure to read the documentation of
alphalens.utils.get_clean_factor_and_forward_return to understand how to
properly format the factor data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quantopian/alphalens/issues/310#issuecomment-409595714,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB21SLe6eqsBb8Z5mSjwWCULeC6cwvoVks5uMbvLgaJpZM4VqlSc
.

I believe you haven't looked at all the examples. Some of them fetch data from yahoo or google but I believe their services haven't been reliable recently but I haven't tried them for quite some time.
Also please keep this and future issues focused on Alphalens specific questions.  Questions on how to query marked data or how to use python to compute RSI are out of topic. Thanks.

@fzhcary It seems that your index is using dates in descending order. Try inverting the order.


Phantom Edges

I am encountering an issue where deleting nodes and edges in a pass leads to additional edges, never created, to nodes created in a later pass.
I have written and published a proof of concept that replicates the issue in a minimal fashion.
As a quick explanation:
I have three passes:

CreateInitialSetupPass  - creates the initial AST/CFG of the minimal example
DeleteExtStmtCalls - this is a pass that goes over the current graph and deletes all call nodes with name EXT_STMT and rewires their CFG edges to not leave a gap in the CFG
TriggerBugPass - this pass triggers the bug

You can run the (single) unit test failing due to the bug by
sbt test

The unit test expects there to be a single CFG edge from DO_FCALL to a node with code after call.
Initially a CFG edge to EXT_STMT is created here. The second pass removes that edge, and replaces that with a CFG edge skipping this call. This works as expected and can be verified by commenting out the pass triggering the bug and seeing the unit test pass.
However, after the third pass, there is suddenly an additional CFG edge leading to the newly created node with the code test, which inevitably leads to the failing of the unit test. This edge is never created and must not be there
For a quick reference
current output:
List(test, after call)
[info] TestForBug:
[info] the cpg
[info] - should have a single CFG edge after DO_FCALL *** FAILED ***
[info]   2 was not equal to 1 (TestForBug.scala:19)
[info] Run completed in 389 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 0, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***

expected output (currently achievable by commenting out the third pass):
List(after call)
[info] TestForBug:
[info] the cpg
[info] - should have a single CFG edge after DO_FCALL
[info] Run completed in 352 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 1 s, completed Nov 29, 2020, 6:56:40 PM
[info] 14. Monitoring source files for cpg-bug-poc/test...
[info]     Press <enter> to interrupt or '?' for more options.

Thanks @simkoc for the excellent reproducer. Fix incoming.