aptsync - Download i18n translations fails in bullseye-security

Hi
I found, that the translations in folder i18n won't download. Double slash in commandline??
The error message:
**
Processing indexes: [Papt-mirror: can't open index security.debian.org/debian-security//dists/bullseye-security/i18n/binary-amd64/Packages in process_index at /usr/local/bin/apt-mirror line 800.
]
Maybe an idea to fix???
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932112
My run script:
[root@debmirror aptsync]# cat debian-security.sh
docker run --rm
-e LOG_ROTATE_CYCLE='5'
-e APTSYNC_URL='http://security.debian.org/debian-security'
-e APTSYNC_DISTS='bullseye-security|main contrib i18n|amd64'
-v /var/www/html/:/data --security-opt label=disable
docker.io/ustcmirror/aptsync:latest
[root@debmirror aptsync]#
--
Tnx in advance

It seems that the upstream of apt-mirror has stopped development, and a sed command can be added to https://github.com/ustclug/ustcmirror-images/blob/master/aptsync/Dockerfile to fix this bug.
BTW: It's a better idea to use rsync to sync Debian official repos instead. For Debian Security, the url is rsync://rsync.security.debian.org/debian-security/

It seems that the upstream of apt-mirror has stopped development, and a sed command can be added to https://github.com/ustclug/ustcmirror-images/blob/master/aptsync/Dockerfile to fix this bug.

Why is the development stopped? Is there any alternative? I've tried debmirror, but also with problems with  debian-security..

BTW: It's a better idea to use rsync to sync Debian official repos instead. For Debian Security, the url is rsync://rsync.security.debian.org/debian-security/

Rsync is not so easy to setup, especially if i only want to mirror only one release like bullseye amd64...

I have tested locally and your error message Papt-mirror: can't open index security.debian.org/debian-security//dists/bullseye-security/i18n/binary-amd64/Packages in process_index at /usr/local/bin/apt-mirror line 800 is not relevant with Debian bug 932112.
The APTSYNC_DISTS should be bullseye-security|main contrib|amd64 (there is no i18n folder in https://security.debian.org/debian-security/dists/bullseye-security/).
Also I'm now testing a patched version of apt-mirror and will be pushed to this repo soon.

@RudiOnTheAir A new version of ustcmirror/aptsync:latest has been pushed (https://github.com/ustclug/ustcmirror-images/commit/a4989b30b3d19d987e992e81432ba49ffcf1ba6f). Could you confirm that whether the i18n files can be downloaded or not (with APTSYNC_DISTS='bullseye-security|main contrib|amd64')?

I have tested locally and your error message Papt-mirror: can't open index security.debian.org/debian-security//dists/bullseye-security/i18n/binary-amd64/Packages in process_index at /usr/local/bin/apt-mirror line 800 is not relevant with Debian bug 932112.
The APTSYNC_DISTS should be bullseye-security|main contrib|amd64 (there is no i18n folder in https://security.debian.org/debian-security/dists/bullseye-security/).

Hmm, the i18n folder is inside main. And yes, i can run with no error the script, when i have removed i18n. But my debian system says, there should be such a folder.. I've putted my testmirror to the public..
Err:7 http://home.rsdns.de:8080/debian-security bullseye-security/main Translation-en
404  Not Found [IP: <IP_ADDRESS> 8080]
Fetched 205 kB in 1s (325 kB/s)
Reading package lists... Done
E: Failed to fetch http://home.rsdns.de:8080/debian-security/dists/bullseye-security/main/i18n/Translation-en  404  Not Found [IP: <IP_ADDRESS> 8080]
E: Some index files failed to download. They have been ignored, or old ones used instead.
root@pve1:~#

Also I'm now testing a patched version of apt-mirror and will be pushed to this repo soon.

Would you like to show us the contents of your /etc/apt/sources.list?

Would you like to show us the contents of your /etc/apt/sources.list?

Sure.
deb http://home.rsdns.de:8080/debian-security/ bullseye-security main contrib
Should i put i18n to the end of the line.?? Never done that..

My local test shows that the i18n/Translation-en.xz file can be successfully downloaded. Did you pull the latest docker image (docker pull ustcmirror/aptsync:latest) before running again?

My local test shows that the i18n/Translation-en.xz file can be successfully downloaded. Did you pull the latest docker image (docker pull ustcmirror/aptsync:latest) before running again?

Upps. No, i thought thats happend every time i run the script.. Btw. i'm using RockyLinux, a RHEL clone with podman.

That is it..
root@pve1:~# apt update Hit:1 http://home.rsdns.de:8080/debian bullseye InRelease Hit:2 http://home.rsdns.de:8080/debian bullseye-updates InRelease Hit:3 http://home.rsdns.de:8080/proxmox/debian/pve bullseye InRelease Get:4 http://home.rsdns.de:8080/debian-security bullseye-security InRelease [44.1 kB] Hit:5 http://download.proxmox.com/debian/ceph-octopus bullseye InRelease                  Get:6 http://home.rsdns.de:8080/debian-security bullseye-security/main amd64 Packages [121 kB] Ign:7 http://home.rsdns.de:8080/debian-security bullseye-security/main Translation-en Get:7 http://home.rsdns.de:8080/debian-security bullseye-security/main Translation-en [77.5 kB] Fetched 122 kB in 1s (232 kB/s)                                     Reading package lists... Done Building dependency tree... Done Reading state information... Done 9 packages can be upgraded. Run 'apt list --upgradable' to see them. root@pve1:~#

To understand, what do you have changed now.? I've only removed i18n after contrib. And finaly pulled your update.. ;)

This repo is configured with GitHub Actions, and when the master branch is pushed, it will automatically build new Docker image and push to Docker Hub.
As this issue has been resolved, I will close it :)


Fall back to cached skins, renders, and capes if possible

i tested my username and it shows steve as my avatar :
https://crafatar.com/skins/Bastikeks
this is my actual skin: http://mcskinsearch.com/skin/Bastikeks
Is it just some kind of caching problem or how do i get this working? Tested this also with some other users and there it works...

Looks like it works now. @jomo are we caching skins and profiles even if there was a server error when attempting to get them?

I think we only cache avatars, wanted to open an issue for that after looking into it

Actually we cache everything of course, but IIRC we only use the cached version of avatars when we have trouble with Mojang

To explain @Bastikeks what most likely happened:
We tried to check for updates on your skin, but couldn't receive it (either hit Mojang's rate limit, their servers failed to reply properly or there were some network issues).
What happens in this case with avatars is that we just fall back to an older version of the avatar (if available) but this feature is not yet implemented.
However, this is only a temporary issue that happens rarely and it starts working again after we successfully checked for another update.

@jomo aren't we caching skin and cape hashes even if we get a 500/non-404?

Quite sure we cache at all times (including null hashes) but not on errors. Will look into it after work

we should only cache if it's a 404, and let it continue to request again if necessary if it's a 500 or server error.

Well you forgot 200 :laughing:
For 429 (rate limit) we could update the timestamp if we already have a hash (if not, we will have to cache null). I think right now we overwrite it with null when that happens. Updating the timestamp would cause it to return the cached image. We could also set the timestamp to some time in the past so that the skin can be requested again 1 minute later (when the rate limit is lifted).

We can use redis TTL!!! 👌

hmm, but we don't want to delete the cape because the skin couldn't be received. using the timestamp should work

Alright, so I had a look at the code and the fallback for cached hashes is done inside helpers.get_image_hash which is called by get_avatar, get_cape and get_skin, which is also called by get_render.
So, in fact, this should be the case for all of the images we server.
My guess is that CloudFlare cached the skin image when it had some sort of issues, but it cached the avatar when it was just fine.
I'm afraid we can't look into details because it was a temporary issue that went away too fast. Unfortunately we're still on heroku and our free Papertrail plan has hit the 1.5 GB limit and log processing has been paused.

@Bastikeks this should no longer happen due to #99 / #101 :sunglasses:


[DROOLS-463] explain how to activate the kie-maven-plugin in Maven pr…

…oject

Merged by https://github.com/droolsjbpm/kie-docs/commit/412be9bb7daab17a8a3e6de1194245a424d0be16


fix: early-exit if no keydown event key exists

We're having issues with Google Chrome's autofill putting an address into the autocomplete input and upon change detection occurring, it triggers a keydown event with no key.  In result we get a type error due to no event.key being available when toLowerCase() is called.  My solution simply guards the eventListener functionality from executing when event.key does not exist.

Hi @eyev ,
Thanks for the pull request,
Merged, your code is included in 2.0.4 version.
Thanks,
Stas


Can't access TradingView's API. HTTP status code: 404.

Can't access TradingView's API. HTTP status code: 404.
Please report this error on GitHub: deathlyface/tradingview-ta-demo and attach the screenshot of the form.

Hello @amir-behnous,
Could you please give more details? What's the symbol/interval/exchange/screener?

my bad, i enter wrong informations

sorry


Update migration to catch old export name

Context
Only a small subset of export history records are being shown.
Only data_export records with an export_type are shown. This field is automatically filled for all new export downloads. We wrote a migration to backfill the old data_export records but this migration failed to run successfully because one of the exports was renamed (Unexplained breaks in work history to Work history break).
Changes proposed in this pull request
This PR updates the migration to catch this particular case.
Guidance to review
It would be good if you could test it locally please.

Run this migration on master. Open backfill_export_type.rb and change line 4 to MANUAL_RUN = true. Then run rake data:migrate:manual[DataMigrations::BackfillExportType]. It should fail with this error, (if you have a data_export with the name "Unexplained breaks in work history").

Take a look at the data in your data_exports table. The older records (>1 month) probably won't have the export_type filled in.
Then run this migration on this branch and it should succeed. To run this migration a second time you will have to remove the latest record in the data_migrations table
Take a look at the data in your data_exports table. The older records should now have the export_type filled in.

Link to Trello card
https://trello.com/c/K5o3HiH8/3258-fix-export-history-bug
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] This code does not rely on the addition/removal of Azure config environment variables in the same Pull Request
[x] New environment variables have been added to the Azure config

I believe that it never ran in production. I've checked the data_migrations table in Blazer and it's not there. I think it tried to run, but then fell over and rolled back.


dynamic properties smartness

the dynamic properties are super cool, but they could be smarter:
I needed something to extract docs and this does not work:
print(RContour.reverse.__doc__) # a normal method
print(RContour.open.__doc__) # a dynamic property

proposal:
class dynamicProperty(object):

    def __init__(self, name, doc=None):
        self.name = name
        self.__doc__ = doc
        self.getterName = "_get_" + name
        self.setterName = "_set_" + name

    def __get__(self, obj, cls):
        getter = getattr(obj, self.getterName, None)
        if getter is not None:
            return getter()
        else:
            if obj is None:
                # when a class is not initiated obj is None
                return self
            raise FontPartsError("no getter for %r" % self.name)

    def __set__(self, obj, value):
        setter = getattr(obj, self.setterName, None)
        if setter is not None:
            setter(value)
        else:
            raise FontPartsError("no setter for %r" % self.name)

I will setup a PR

This looks good to me.


Use aliases:true for YAML.load in Psych for Ruby version >= 3.1.0

This PR makes redcord work properly with the version of psych bundled with Ruby versions >= 3.1.0.
Quick summary:

in Ruby 3.1, psych (the bundled YAML parser) has a major version bump to 4
a breaking change is the behaviour of psych's load_file, which YAML.load wraps:

previously (Psych < 4), load_file is "unsafe" by default: this includes parsing aliases
in Psych > 4, load_file is safe by default; users need to opt in to alias parsing (and other extended YAML features)

however, simply using aliases: true breaks on Psych < 4, since the keyword doesn't exist for earlier versions of psych (and throws an error)
therefore, this PR:

uses the Ruby version as a heuristic for the bundled psych version
on Ruby versions >= 3.1.0, explicitly passes in aliases: true
otherwise, keeps the same behaviour as before

In particular, this should let us support Ruby 3.1 without cutting support for Ruby < 3.1 (i.e., in traject).

Admittedly - this is a code coverage decrease, since the line of code previously wasn't tested (and I'm not adding a test in this PR). I'd like to merge this ~ before my internship ends, but if we think delaying it to write a test is reasonable, more than happy to do that!


update text/en/inflect.py

resolve #272

Coverage decreased (-0.8%) to 67.472% when pulling d253df479c0f01c0c139c789b596d7c9c46fa192 on k4ni5h:master into 5b85d998c30ddc6772b56310713530224466083a on clips:master.


Refine Integration Test Script

Refine code style.
Add rest srcipt for resetting test environment.
Handle Timeout exception caused by writing 2GB file.
Try to replay some possible issues.
Add script for corner cases.

@duzhen1996

Already done. Issue closed.


[random fix] - don't look here!

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

@weicaiyang you want to give this a try?


Flip Local View Camera

Hi, how would i go about flipping/alternating between the front and rear facing camera on the local user when capturing video?
Thanks!

In the ARDAppClient there are 2 methods swapCameraToFront and swapCameraToBack methods.
In the sample app demo ARTCVideoChatViewController you could call [self.client swapCameraToFront] and [self.client swapCameraToBack].

I don't have those methods...and I am using the most recent version from the pod.These are the only methods exposed in the ARDAppClient header:
@interface ARDAppClient : NSObject

@property(nonatomic, readonly) ARDAppClientState state;
@property(nonatomic, weak) id<ARDAppClientDelegate> delegate;
@property(nonatomic, strong) NSString *serverHostUrl;

- (instancetype)initWithDelegate:(id<ARDAppClientDelegate>)delegate;

// Establishes a connection with the AppRTC servers for the given room id.
// TODO(tkchin): provide available keys/values for options. This will be used
// for call configurations such as overriding server choice, specifying codecs
// and so on.
- (void)connectToRoomWithId:(NSString *)roomId
                    options:(NSDictionary *)options;

// Disconnects from the AppRTC servers and any connected clients.
- (void)disconnect;

Did you check out https://github.com/ISBX/apprtc-ios/blob/master/Lib/ARDAppClient.h

I saw this from a past project, but any idea why its not the version being pulled from pod 'AppRTC' ? I'll try to see if i can specifically pull that version (if its available). How did you install it on your project, or did you just use the demo project?

weird..both of my projects (one with the more robust  ARDAppClient and one without) seem to have version 1.0.2 of AppRTC. Any ideas? What happens if you create a new project and do pod 'AppRTC', do you see those methods in the file? @coolwr
Btw - thanks for the help :)


Missing translation throws an error

Hello,
I recently upgraded from Laravel 5.1 to 5.2 and as far as I noticed the modules package runs fine except one little and annoying issue:
My language files are located at \app\Modules\News\Resources\Lang\ro\admin.php for example and I'm calling them from my blade view using usual trans('news::admin.line'). Everything works fine except from the case when the translation is not found and then it throws this error:
ErrorException in C:\Program Files (x86)\EasyPHP-DevServer-14.1VC11\data\localweb\refillio\vendor\laravel\framework\src\Illuminate\Translation\FileLoader.php line 88:
Argument 1 passed to Illuminate\Translation\FileLoader::loadNamespaceOverrides() must be of the type array, integer given, called in C:\Program Files (x86)\EasyPHP-DevServer-14.1VC11\data\localweb\refillio\vendor\laravel\framework\src\Illuminate\Translation\FileLoader.php on line 73 and defined (View: C:\Program Files (x86)\EasyPHP-DevServer-14.1VC11\data\localweb\refillio\public\themes\refillio\views\modules\news\admin\addNews.blade.php)
Previously, if a translation was not found, blade was showing the variable name instead.
Any ideas what can cause this error?
Regards,
Dan

Hmm, seems the way translation files should be loaded has changed. This may be the cause of the issue you're running into (I haven't tested though).
Instead of using Lang::addNamespace(), create a boot method and add the following (be sure to update the paths accordingly):
$this->loadTranslationsFrom(__DIR__.'/path/to/translations', 'moduleslug');

I'll be sure to update the package for this so any future modules will be set up properly automatically.

For future reference and debugging tips, anything documented under Package Development in the Laravel documentation applies to modules.

Hi,
Thank you for your fast reply. I run a composer update today and laravel framework upgraded from 5.2.24 to 5.2.25 and the problem vanished. It might have been a framework little bug that now got corrected.
Thank you again for your help.
Regards,
Dan


Missing roads

I recently updated to build 2545 and have huge holes in the roads as shown below.  I switched back to build 2372 and the holes were gone.  I'm currently running version 2.0.15 of bob74_ipl.  Everyone in server sees the holes the same as I do.  I've also tried running FiveM in beta and the canary version.

Well I'm not having any issue running this version:

Did you try disabling other resources? If you are using custom mappings, it often leads to collisions issues with the map.

Hi. This issue is related to occlusion change in new game build so you have to modify add-on maps

It was caused by a custom MLO building in that area.  Thanks guys!


Feature Request: Extend Comment options in UI

The matrix view in the UI allows the user to leave a comment on each model output, which is really helpful!
For some tasks outputs can be rather long & it'd be very helpful if we could leave multiple comments linked to different lines of the output.
Alternatively, even having a bigger box to leave a comment in would allow for easier editing/review.
Thank you!

Hi @magdalena-mladenova-veeva, https://github.com/promptfoo/promptfoo/pull/713 adds an improved comment view. It's still not specific to individual lines of output, but it's a bigger box for you to use.  Hope this helps

amazing, thank you so much!

This change is included in release 0.56.0


Initial oscap execution module for testing & feedback

This code is ugly and not completely baked, but I'm "releasing early & releasing often" as it were. docstring includes roadmap and things that need attention.

I wonder if this would be something worth submitting upstream once we have it fully baked? Would be nice to have one fewer module to ship with nova.

@basepi, do you mean as a Salt execution module?

@avb76 Yes, that's what I meant.

Since there isn't one at the moment, I think it would be useful.

Yes, an oscap execution module should probably go upstream. I don't want to overload Hubble with execution modules, but in the meantime we can use it this way.


Rest Catalog and Writing data to Minio Raises OSError: When initiating multiple part upload

Apache Iceberg version
0.6.1 (latest release)
Please describe the bug 🐞
Hi,
I am trying to use the rest catalog and writing the data into Minio, the script I am using can communicate with Minio (it creates the metadata.json file under metadata directory, however, it raises OSError: When initiating multiple part upload for key 'poc_new/coordinates/data/00000-0-f27b7921-a6d7-4c7e-b034-2d12221e5054.parquet' in bucket 'warehouse': AWS Error NETWORK_CONNECTION during CreateMultipartUpload operation: Encountered network error when sending http request when it tries to write the data table.append(df)
this is the docker compose file that I use
version: '3'
services:
  rest:
    image: tabulario/iceberg-rest:1.5.0
    container_name: iceberg-rest
    ports:
      - 8181:8181
    environment:
      - AWS_ACCESS_KEY_ID=admin
      - AWS_SECRET_ACCESS_KEY=password
      - AWS_REGION=us-east-1
      - CATALOG_WAREHOUSE=s3://warehouse/
      - CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
      - CATALOG_S3_ENDPOINT=http://minio:9000
    networks:
      iceberg-rest:

  minio:
    image: minio/minio:RELEASE.2024-05-10T01-41-38Z
    container_name: minio
    environment:
      - MINIO_ROOT_USER=admin
      - MINIO_ROOT_PASSWORD=password
      - MINIO_DOMAIN=minio

    ports:
      - 9001:9001
      - 9000:9000
    command: [ "server", "/data", "--console-address", ":9001" ]
    networks:
      iceberg-rest:
        aliases:
          - warehouse.minio

  mc:
    depends_on:
      - minio
    image: minio/mc:RELEASE.2024-05-09T17-04-24Z
    container_name: mc
    entrypoint: |
      /bin/sh -c "
        until (/usr/bin/mc config host add minio http://minio:9000 admin password)
        do
          echo '...waiting...' && sleep 1;
        done;
        /usr/bin/mc rm -r --force minio/warehouse;
        /usr/bin/mc mb minio/warehouse;
        /usr/bin/mc policy set public minio/warehouse;
        tail -f /dev/null
      "
    environment:
      - AWS_ACCESS_KEY_ID=admin
      - AWS_SECRET_ACCESS_KEY=password
      - AWS_REGION=us-east-1
    networks:
      iceberg-rest:

networks:
  iceberg-rest:

And this the script file
import pyarrow as pa
from pyiceberg.catalog import load_rest
from pyiceberg.exceptions import NamespaceAlreadyExistsError, TableAlreadyExistsError

catalog = load_rest(
    name="rest",
    conf={
        "uri": "http://localhost:8181/",
    },
)

namespace = "poc_new"
try:
    catalog.create_namespace(namespace)
except NamespaceAlreadyExistsError as e:
    pass

df = pa.Table.from_pylist(
    [
        {"lat": 52.371807, "long": 4.896029},
        {"lat": 52.387386, "long": 4.646219},
        {"lat": 52.078663, "long": 4.288788},
    ],
)
schema = df.schema

table_name = "coordinates"
table_identifier = f"{namespace}.{table_name}"
try:
    table = catalog.create_table(
        identifier=table_identifier,
        schema=schema,
    )
except TableAlreadyExistsError as e:
    pass

table = catalog.load_table(table_identifier)
table.append(df)

The Traceback
Traceback (most recent call last):
  File "d:\flink_iceberg\poc_01_iceberg_rest.py", line 40, in <module>
    table.append(df)
  File "D:\flink_iceberg\.venv2\Lib\site-packages\pyiceberg\table\__init__.py", line 1068, in append
    for data_file in data_files:
  File "D:\flink_iceberg\.venv2\Lib\site-packages\pyiceberg\table\__init__.py", line 2423, in _dataframe_to_data_files
    yield from write_file(table, iter([WriteTask(write_uuid, next(counter), df)]))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\flink_iceberg\.venv2\Lib\site-packages\pyiceberg\io\pyarrow.py", line 1726, in write_file
    with fo.create(overwrite=True) as fos:
         ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\flink_iceberg\.venv2\Lib\site-packages\pyiceberg\io\pyarrow.py", line 299, in create
    output_file = self._filesystem.open_output_stream(self._path, buffer_size=self._buffer_size)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "pyarrow\_fs.pyx", line 868, in pyarrow._fs.FileSystem.open_output_stream
  File "pyarrow\error.pxi", line 144, in pyarrow.lib.pyarrow_internal_check_status
  File "pyarrow\error.pxi", line 115, in pyarrow.lib.check_status
OSError: When initiating multiple part upload for key 'poc_new/coordinates/data/00000-0-efc0be57-453d-442d-af13-2e0b2382a53d.parquet' in bucket 'warehouse': AWS Error NETWORK_CONNECTION during CreateMultipartUpload operation: Encountered network error when sending http request

In Minio, the metadata directory is created and it stores the metadata.json file, but, no data directory.

Also, this is the requirements.txt file
annotated-types==0.7.0
apache-beam==2.48.0
apache-flink==1.19.1
apache-flink-libraries==1.19.1
avro-python3==1.10.2
certifi==2024.7.4
charset-normalizer==3.3.2
click==8.1.7
cloudpickle==2.2.1
colorama==0.4.6
confluent-kafka==2.5.0
crcmod==1.7
dill==<IP_ADDRESS>
dnspython==2.6.1
docopt==0.6.2
duckdb==0.9.2
duckdb_engine==0.13.0
Faker==26.0.0
fastavro==1.9.5
fasteners==0.19
fsspec==2023.12.2
greenlet==3.0.3
grpcio==1.65.1
hdfs==2.7.3
httplib2==0.22.0
idna==3.7
kafka-python==2.0.2
markdown-it-py==3.0.0
mdurl==0.1.2
mmhash3==3.0.1
numpy==1.24.4
objsize==0.6.1
orjson==3.10.6
packaging==24.1
pandas==2.2.2
polars==1.2.1
proto-plus==1.24.0
protobuf==4.23.4
py4j==<IP_ADDRESS>
pyarrow==11.0.0
pydantic==2.8.2
pydantic-settings==2.3.4
pydantic_core==2.20.1
pydot==1.4.2
Pygments==2.18.0
pyiceberg==0.6.1
pymongo==4.8.0
pyparsing==3.1.2
python-dateutil==2.9.0.post0
python-dotenv==1.0.1
pytz==2024.1
regex==2024.7.24
requests==2.32.3
rich==13.7.1
ruamel.yaml==0.18.6
ruamel.yaml.clib==0.2.8
six==1.16.0
sortedcontainers==2.4.0
SQLAlchemy==2.0.31
strictyaml==1.7.3
typing_extensions==4.12.2
tzdata==2024.1
urllib3==2.2.2
zstandard==0.23.0

I checked this Slack thread for the same issue, but, it doesn't contain any fix for my case.
OS: Windows 10
environment variables contain aws in the three containers
iceberg-rest container
iceberg@ce79d3f11b5f:/usr/lib/iceberg-rest$ env | grep -i aws
AWS_REGION=us-east-1
CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
AWS_SECRET_ACCESS_KEY=password
AWS_ACCESS_KEY_ID=admin

minio container, doesn't have any ENV with aws
mc container
AWS_REGION=us-east-1
AWS_SECRET_ACCESS_KEY=password
AWS_ACCESS_KEY_ID=admin

As a workaround, you can define the S3 configurations (endpoint, secret access key, and access key ID) in the load_rest method.
catalog = load_rest(
    name="rest",
    conf={
        "uri": "http://localhost:8181/",
        "s3.endpoint": "http://localhost:9000",
        "s3.access-key-id": "admin",
        "s3.secret-access-key": "password",
    },
)

For some reason, the iceberg-rest-image does not return the overrides in the getConfig endpoint.
If you test with Tabular or other catalogs, you will not have this problem.

@ndrluis thank you for your fast response, now it is writing the data into Minio

As a workaround, you can define the S3 configurations (endpoint, secret access key, and access key ID) in the load_rest method.
catalog = load_rest(
    name="rest",
    conf={
        "uri": "http://localhost:8181/",
        "s3.endpoint": "http://localhost:9000",
        "s3.access-key-id": "admin",
        "s3.secret-access-key": "password",
    },
)

For some reason, the iceberg-rest-image does not return the overrides in the getConfig endpoint.
If you test with Tabular or other catalogs, you will not have this problem.

I've tried using  load_rest instead of load_catalog but I'm getting a similar error.
When initiating multiple part upload for key 'namespace/table/metadata/snap-....avro' in bucket 'warehouse':
AWS Error UNKNOWN (HTTP status 400) during CreateMultipartUpload operation:


Repeater Input #addButton Slot Not Working

Reproduction
https://formkit.link/b5bdc49d803df5923007bd36e4123203
Describe the bug
Repeater Input #addBytton Slot Not Working
Environment
Latest

Not entirely sure why this works — but if you use the sections-schema prop to set the addButton element to null and then use the slot it'll work. You can use this as a workaround until we get the schema updated in the next Pro release. https://formkit.link/452626c7bc0a25b4f89643ed6487c493


[SLAM] Reject invalid options and keep internal options unchanged

Kenny:

Ref: https://github.com/01org/node-realsense/issues/109
No test case yet, just log this according to the analysis in our meeting. If there is no such bug, please close it directly.

I think #164 has resolve this issue. @haoyunfeix would you please help to verify it?

Move out of this milestone, @haoyunfeix please help to verify it after the release.

Sorry for the late feedback, this issue has been fixed with the latest code.
So close this issue.


Backport: UI for Allow S3 Snapshot service to trust internally signed certs when talking to the S3 endpoint

This ticket is for UI component of https://github.com/rancher/rancher/issues/21103 > we need to add one extra optional field in the snapshot configuration UI
@westlywright: @moelsayed worked on the backend part in case you have any questions.

Available in UI Tag 2.2.81

verified on rancher:v2.2-head with UI tag - 2.2.81
UI has a new field - Custom CA Certificate
Scenario 1:
Valid and correct certificate and S3 enabled with minio
Able to take snapshots and restore from snapshots
Scenario 2:
InValid certificates and S3 enabled with minio
Error on the UI, when the user clicks on create cluster or Save on an edit cluster.
Failed to validate cluster: invalid S3 endpoint CA certificate: data does not contain any valid RSA or ECDSA certificates

Scenario 3:
Valid and incorrect certificate and S3 enabled with minio
Error in the rancher logs on taking a snapshot on the UI
2019/06/27 20:52:16 [ERROR] ClusterController c-jgv8g [cluster-provisioner-controller] failed with : Failed to download etcd snapshot from s3, exit code [1]: time="2019-06-27T20:52:14Z" level=fatal msg="failed to set s3 server: failed to check s3 bucket:sowmya-test, err:Get https://x.x.x.x:9000/sowmya-test/?location=: x509: certificate signed by unknown authority"

And the snapshot is seen stuck in Activating state


Make the thing threadsafe

Fixes https://github.com/elastic/logstash/issues/4625 and makes this thing able to use multiple workers.
Slight problem.... no tests in this plugin :(

Small details about the library, but code LGTM

I attempted to test out this PR and got the following after building the gem locally and installing like: bin/plugin install logstash-filer-zeromq-2.0.2.gem
Strange enough, it had nothing to do with zeromq filter in the config, it only occurred when I had the elasticsearch plugin output in my config.
root@logs:/etc/logstash/conf.d# /opt/logstash/bin/logstash agent --configtest -f ./The error reported is:

	you might need to reinstall the gem which depends on the missing jar or in case there is Jars.lock then resolve the jars with `lock_jars` command

no such file to load -- org/apache/httpcomponents/httpclient/4.5/httpclient-4.5 (LoadError)

Not sure if related.

@buddyp450 what if you just put it in your Gemfile like this:
gem 'logstash-filter-zeromq', :path => /path/to/git-repo-with-this-branch
then run
bin/plugin install --no-verify. That should get things working.

@andrewvc I was OK with merging this if we move to threadsafe?


Staff officer slots are not enough for the amount of players

seems to cap at 3 instead of 4

Were there 119 players ready? That's how the job slot scaling formula works for SOs, players / 40 + 1, min 2 max 5
I have to check if 13 readjusts the slots with late joins though


fix(pydantic_i18n/main.py): fix normal translation case

Hi there! I noticed that the first case does not work.
I applied these lines to fix it. Please feel free to check and modify it!

Hey, @matiasz8 Thank you a lot for your contribution. I expanded your contribution a bit here (#17) to force master fixing.

Great! good work!


Add UM_HYBRID_ROLE_AUDIENCE table exist check to fix server startup issues of migrating clients

Purpose

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7630137541

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7630137541
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7635474700

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7635474700
Status: failure

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7639068175
Status: success


Support zones with / in zone name

The suggested scheme in https://tools.ietf.org/html/rfc2317 is to have zone names such as 128/<IP_ADDRESS>.in-addr.arpa. to represent the range <IP_ADDRESS>/26.
There are at least 3 DNS UI bugs related to having / in the zone name:

Git-tracked-export files cannot be created due to / in file path.
Apache by default will respond with 404 to any request with a %-encoded / (%2F) in unless AllowEncodedSlashes is specifically set. We want it to be set to NoDecode, though this means we cannot support this under Apache 2.2.
Display of such zones in the zone list is broken ("IPv4 prefix" and "Subnet" columns).

Seems we can still support it in Apache 2.2:

NoDecode option available in 2.2.18.


Adjustments to decay0 v3.4 model

This PR changes the configuration fhicls of the new radiological model decay0 v3.4 to make maintenance easier for future updates.

Looks good to me. The reorganisation should make the maintenance a lot easier going forward.
I had one minor comment about moving a comment but that shouldn't delay approval.
Have we confirmed that the reorganisation hasn't changed the parsed fcl structure (e.g. comparing fcl dumps before/after reorganisation)?

I have, fhicl-dumps are here: /dune/app/users/lpaulucc/leprod/fcldumpsbackground/. No harm in having a second look, though.


Remove warnings from native image build.

Signed-off-by: Tomas Langer<EMAIL_ADDRESS>

A different version of this fix was merged into 2.4.1. Closing.


There is a unresolved usage in LaravelLogger file giving error when using with ide-helper package

Describe the bug
When you use laravel-bugsnag package with barryvdh/laravel-ide-helper, if you run
php artisan ide-helper:meta

command giving this error.

Error messages:
 laravel.EMERGENCY: Unable to create configured logger. Using emergency logger. {"exception":"[object] (ReflectionException(code: 0): Class 'Illuminate\\Contracts\\Logging\\Log' not found.

Because of in
Bugsnag\BugsnagLaravel\LaravelLogger.php

file's
  Illuminate\Contracts\Logging\Log

namespace definition
Steps to reproduce

Go to terminal
run php artisan ide-helper:meta command
open storage/logs/laravel.log (You can open whichever log file is in your project)
See error

Environment

Bugsnag version: 2.28
PHP version: 8.3
Composer version: 2.2.21
Laravel version: 11.28.1

Hi @mertaydin
Can you please confirm that you have followed the documentation for configuring the logger and ensured correct binding to Psr\Log\LoggerInterface ? This will eliminate the reliance on the deprecated Illuminate\Contracts\Logging\Log interface, which I believe is what was causing the issue.
For convenience you can find those docs here: https://docs.bugsnag.com/platforms/php/laravel/#laravel-5-6

Yes, I did everything according to documentation. I don't have any problem with bugsnag. But I think problem is unresolved namespace which was found by ide-helper package. It's scanning all classes for ide helper for autocompletion.

Hi @mertaydin,
To help us investigate this further, are you able to provide your full BugSnag configuration, along with your full composer.json file? Or even better, would you be able to provide a stripped down example app that reproduces this?
If you are concerned about sharing these files publicly then please feel free to reach out to us via<EMAIL_ADDRESS>

I sent details with email to<EMAIL_ADDRESS>

Hi @mertaydin
As you have now opened a support ticket with us directly, we are going to close this issue and continue the conversation over there. If you have any questions, please respond to us on the ticket.


use buit-in detach

For truncated BPTT, use built-in detach
For GANs, detach variables of fake images (thus no useless backprop) when training discriminator.

Great, Thanks!


Allow replay on a Saga

Currently, regardless of whether @AllowReplay is put on a Saga, sagas are note replayed at any circumstances. This ticket should support it, however, the default behaviour should still be @DisallowReplays on sagas.
If @AllowReplay is placed on a Saga, this Saga should support reset handlers as well.

Implementation of this feature is relatively straightforward, except for the @ResetHandler support.
Would only a single reset handler be invoked?
The reset handler of any active Saga?
The reset handler of all Sagas that ever have been active?
Further diving into the reset handler point, I'm starting to conclude that providing overall replay support for sagas might not be a good idea.
It will require a lot of explanation to end-users that using such behavior is likely, not what they need.
Do you want to retrigger all those side effects from the past?
If so, why? Because the process changed?
If it changed, it would be easier to construct a new Saga for the adjusted process instead of reworking the old implementation.
Furthermore, it simplifies the Saga implementation as it does not require any replay logic clutter.
I have not removed the branch with all changes to make this work, as I am open to further debate.
However, I do not think this is the right time to provide full-fledged replay support on Sagas yet.
As such, I will close this issue for the time being, with the label Won't Fix attached to it.


Version 1.9.1 Does Not Upload Properly to VRChat

I have been using this stub in many of my projects for use with VRChat.
However, in the latest release, the files were moved into a different folder structure and reorganized as a creator companion package.
Even though my projects still link to these scripts properly, they do not upload correctly to VRChat. The result in game appears to have no scripts installed at all.
For the time being, I am asking my customers to continue to use the older version of the script. Please take a look at this issue and let me know what you think or if I need to make changes on my end.
I normally develop using the official release of Final IK and then my customers use the stub to upload.
I can confirm that nothing about my project has changed and my project still works correctly on the original release of the stub.

Thank you for confirming that you are aware of this issue. I'll continue to direct people to use the older version until there is a fix.
I do understand the need to move this over to the VCC packages section, and I hope there is a solution that will work going forwards. I prefer to use VCC packages when possible.

1.9.2 is released, with the fix for the upload issue.
Also as a nice bonus now it won't nuke a full Final IK installation if it finds one.


How to repackage Angular2 packages on Atmosphere

Hi, @Urigo and everyone, can you give us, especially the author of ng2-bootstrap, ng2-charts, ng2-file-upload @valorkin some directions for repackaging these Angular2 style packages on Atmosphere to let them be reused in the future angular2-meteor project?
@valorkin's packages are really high-quality style packages for angular2. All their packages can be found here.
https://github.com/valor-software/ng2-file-upload/issues/49

@Hongbo-Miao please read this chapter of the tutorial and let me know if that worked for you - http://www.angular-meteor.com/tutorials/socially/angular1/3rd-party-libraries

@Urigo thx for link, I will read it
but you suggestion about consuming 3rd party
what about automatic packaging 3rd party libraries?
if I want to publish my ng2 libraries in atmosphere

my bad seems solution #1 is what we need

@Urigo Sorry, I failed after some tries... I think it needs put some d.ts files in typings automatically after downloading the package, but I don't know how to create those files. How about creating a tutorial Step 3rdParty Libraries for angular 2 here first using  ng2-bootstrap or ng2-file-upload as examples... :P

Hi, I also tried to package angular2-materialize package for Meteor, but failed. Main problem so far is packing any .ts files for Meteor, as well as packing npm dependencies of the original package that don't already exist on Atmosphere.
I will keep trying. If I succeed, I'll suggest a chapter for Angular2-Meteor tutorial.

@Hongbo-Miao I kinda succeeded to transpile TS and package it for meteor using the package.js like in https://github.com/barbatus/ng2-meteor-accounts/blob/master/package.js
Please try and let me know.
It seems that I also need to package other npm dependencies that don't exist on atmosphere and use them in my package.js

@valorkin @MilosStanic  I got help from (zrbfly)[https://atmospherejs.com/zrbfly/ng2-bootstrap], who first succeed packaging ng2-bootstrap, I will let you know details of how to package it once I am clear those steps.

with the new Meteor version you can just use npm and import styles from it

Oh, yeah, it is working well now using NPM.


[Feature Request] : Add support for emoji picker in pop up input helper

Hi,
It would be great if the input assistant popup could utilize the emoji picker as well. In certain cases the emoji's themselves are used as tags and would hence be very helpful.
Thanks

Do you mean the emoji picker plug-in?
On 12 Jun 2022 at 11:33 AM +0400, piyush-das @.***>, wrote:

Hi,
It would be great if the input assistant popup could utilize the emoji picker as well. In certain cases the emoji's themselves are used as tags and would hence be very helpful.
Thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Make quotes work for an arbitrarily tall quote text

Currently it only works on 1080*1920, make it work for any height. This would allow an mcas script to generate quote images with imagemagick or whatever so you could do mcas --make-quotes script.org which could then be trivially passed to the animation script to generate the quotes. Potentially needs mcas --make-quotes script.org to also generate json files containing information about the quotes such that it can be taken in by motion-canvas easily enough, at least an index.ts that links off to all of the pngs would be nice.

Resolved by https://github.com/LiquidZulu/mcas/commit/02107dae90cfa368d4d3a87f7397c2cb20ecd27f


[URGENT!] Crash is happening on only Android when I add flutter_facebook_login: ^3.0.0, but works on iOS well

On iOS it works well. But on Android, app crashes at very beginning.
I followed the suggestions on this issue. https://github.com/roughike/flutter_facebook_login/issues/112
And I changed the versions several times as 1.2.0, 2.0.0, etc. But it never works.
Only if I remove the plugin from pubspec.yaml file, the crash disappears. Please help me to figure out this issue on Android

@danyiliev Could you post your flutter doctor, and your specific android configurated files?

I'm facing the same issue

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.17.5, on Microsoft Windows [Version 10.0.17133.1], locale en-US)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[√] Android Studio (version 3.6)
[√] VS Code (version 1.45.1)
[√] Connected device (1 available)
when running the project after adding you library I got this error
AILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':flutter_facebook_login'.

Could not resolve all artifacts for configuration ':flutter_facebook_login:classpath'.
Could not find gradle.jar (com.android.tools.build:gradle:3.3.1).
Searched in the following locations:
https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.3.1/gradle-3.3.1.jar

although I could access and download this files from browser
https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.3.1/gradle-3.3.1.jar
I believe there is android build bug in your module

I experience this tool, I debug the whole app from Android manifest file to removing all my code to removing all the libraries before I discovered that its flutter_facebook_login that is causing the crash

Same problem. I am on flutter channel dev

did anyone fix this?

did any one fix this same problem facing please

did any one fix this same problem facing please


[incubator/logstash] Provide a Way to Specify JVM Heap Size

Is this a request for help?:
yes
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Version of Helm and Kubernetes:
helm:
Client: &version.Version{SemVer:"v2.7.0", GitCommit:"08c1144f5eb3e3b636d9775617287cc26e53dba4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.7.0", GitCommit:"08c1144f5eb3e3b636d9775617287cc26e53dba4", GitTreeState:"clean"}

kubernetes:
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.0", GitCommit:"91e7b4fd31fcd3d5f436da26c980becec37ceefe", GitTreeState:"clean", BuildDate:"2018-06-27T22:30:22Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.6-gke.2", GitCommit:"384b4eaa132ca9a295fcb3e5dfc74062b257e7df", GitTreeState:"clean", BuildDate:"2018-08-15T00:10:14Z", GoVersion:"go1.9.3b4", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
[incubator/logstash]
What happened:
I'd like to change the JVM Heap size using the helm chart, but the values file doesn't provide a way to do so. Also using the environment variable LS_JAVA_OPTS doesn't allow you to deploy the container with increased JVM Heap sizes.
What you expected to happen:
I would expect passing in the LS_JAVA_OPTS environment variable would allow you to change the JVM heap size, but it doesn't seem to.
I'd also expect there to be a way to change the heap size using the helm chart, similar to [incubator/elasticsearch].
How to reproduce it (as minimally and precisely as possible):
helm install --name logstash incubator/logstash --namespace logging -f custom.values.yaml
Use the following values inside of custom.values.yaml:
  config:
    ls.java.opts: "-Xmx4g -Xms2g"
  resources:
    limits:
      memory: 8Gi
    requests:
      memory: 8Gi
  replicaCount: 2

Anything else we need to know:

Verified that it is working by passing LS_JAVA_OPTS environment variable through config section in values.yaml
config:
  ls.java.opts: "-Xmx2g -Xms2g"


increase timeout

Increase another timeout, add more logging when disconnecting

This was an old commit sitting in my repo that I forgot to push; Unfortunately I don't remember what problem I was having when I made this change.

Could you move these timeouts (and maybe https://github.com/lbryio/lbryum/blob/9c54e039e78e879fad6e34720f5a31cf51228816/lib/network.py#L821) to some constants at the top of the respective files?

Closing as I think we've, hopefully, fixed the underlying problem.


Update security-findings-faq.md

Add dojo vulnerability to FAQ. See ticket 173999.

Sorry, ticket 175805


Facebook

Facebook doesn't return "link" for some reason, so
services/FacebookOAuth2Service.php:55 can be patched as:
-$this->attributes['url'] = $info['link'];
+$this->attributes['url'] = "https://www.facebook.com/".$info['id'];

$info['link'] works ok in all of my apps.
Can you see the link at http://nodge.ru/yii-eauth/demo2/login ?

Hmm.. you've got so much data of it. I only get name and id.

What am I doing wrong? :-)

Try to use yii2-eauth/src/services/extended/FacebookOAuth2Service.php instead of yii2-eauth/src/services/FacebookOAuth2Service.php :)

Yeah, that's what I did.
I don't need all that info, anyway, only name and ID, but I don't understand the reason why $this->makeSignedRequest('me') doesn't return all that to me.. O.o Can it be app's persmissions?

Try to add options to method makeSignedRequest.This code helped for me.
protected function fetchAttributes()
{
    $options = [
        'query' => [
            'fields' => 'id,name,email',
        ],
    ];
    $this->attributes = $this->makeSignedRequest('me', $options);
    return true;
}

Starting from version 2.4 Graph API requires that you explicitly request the fields you need for your GET requests.
I've updated example here: https://github.com/Nodge/yii2-eauth/blob/a00e9d5652eb2be57e08bf04be17e9e4d5db61bf/src/services/extended/FacebookOAuth2Service.php


Sink wet sensor

Objective
Much like my #16 bath water level sensor I wanted a way to track if the bathroom sink was in use. There are a number of use-cases why I wanted to know this, for example, detecting if hands are washed after using the toilet and tracking water consumption. I know this seems an odd application for a water sensor but as I'm tracking when the toilet is flushed this seemed a natural next step. I had a spare Aqara water sensor which I will put to use. The idea is the sensor will be placed over the sink overflow hole without impeding or blocking it. Then two wires will be passed from the sink waste hole up through the pipe to the overflow hole. I'll connect these wires to the Aqara water sensor which will close the circuit when wet. If this works I will 3D print a suitable housing to keep the sensor away from blocking the overflow hole.

[ ] Detect running water in the sink
[ ] 3D printed housing
[ ] Home Assistant automation

Ingredients

Aqara water sensor
2 appropriate lengths of wire. I stripped an old ethernet cable for the thin gauge copper wire

To get the wire through the pipe I used sewing cotton with a small piece of blue-tac rolled to one end. I kept the cotton on the roll so I had a constant stream of it available. I then placed this in the overflow hole and used my hand to create a flow of water down the pipe. The cotton and blue-tac ran through the pipe with the water and to my amazement popped out in the waste pipe where I was easily able to use some tweezers to pull it out from the pipe. I then taped the cable to the cotton and pulled the cable through and repeated for the second cable.

After a great start with testing, it seems that the sensor stopped working through the cable and reporting being wet permanently. I decided to replace the cable in case I caught the cables in the pipe with might having been shorting them.  I had a resistor on the side and tried this inline with one of the wires and the sensor correctly reported each time I shorted the sensor.

Measurements for the housing I plan to make with my 3D printer.

Since adding the resistor the sensor is reporting with 100% accuracy and change from wet to dry within 10 seconds of the water stopping.

I found a really cool design on Thingsverse which was very close to the design I was going to create. After two test prints I was able to scale this design for my use-case perfectly. I attached it to an old Aqara water sensor using hot glue. The case on this sensor is damaged so I plan to swap it with one that is currently on the way to me. When the new one arrives I will use super glue to attach it to the battery compartment and tidy up the resistor I temporarily soldered for testing.

Replacement sensor arrived today. Soldered a 47 ohm resistor and sealed it with some heat shrink. Superglued the 3d printed mount to the battery compartment and that’s another little job completed.
Tested with a full sink and the water runs freely down through the overflow hole just fine. The bonus is the sensor state becomes ‘wet’ because the contacts at the back of the sensor detect the overflowing sink so I will create an automation to warn of a overflowing sink if the sensor is ‘wet’ for an extended period of time.
I’ll close this issue out by sharing the automation in a commit.

Prototype V2
This has been in for a couple of months now. At first, the results were perfect but for some reason, this sensor really does not like the addition of the wire (even though the manual says this is okay).

Option 2: Use a hex screwdriver to loosen the probes, and connect to cables for more smart scenes

Since I have spent the last week moving over to ZHA #167 I thought I'd revisit this sensor and see if I could fix it. It is totally unnecessary but when it was working it was a really great reminder "to all" to wash their hands, COVID19 or no COVID19.

https://twitter.com/jamescallaghan/status/1276948498680815619


Fix DSCResource.Template/Readme.md markdown rule violations - Fixes #220

This fix just corrects the markdown best practice rule violations in the DSCResource.Template/Readme.md.
The most significant change is that the AppVeyor build badge is moved to below the top level header line.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Update for scheduled-events.md

Update for scheduled-events.md, adding EventSource and Description.

@knightx7 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#hold-off

Closing in favor of #53128
@knightx7 let me know if you need both Pull requests merged instead of one.


Update restructured work history error messaging

Context
The error messages in the work history need to be updated to match the new design.

Changes proposed in this pull request

Most of the changes described by the Google doc linked in the ticket
Does not include error messages specifically for the month or specifically for the year, as agreed with @gregknight1 (reason—not just a copy change, needs some non-trivial changes to how we handle date validations).
Some spec setup changes, mostly related to locale strings and the shared examples we're using for dates.

Guidance to review

Running locally or in the review app, ensure restructured work history feature flag is active, and the current application has feature_restructured_work_history set to true. Easiest way to ensure the latter is to sign up as a new user (rather than log in as an existing one).
Go through the Add Job and Explain Break flows, testing the scenarios outlined in the doc (except the ones where a month-only or year-only error is expected).
Regarding the missing locale string mentioned in one of the commits - I've written up this card to deal with similar cases https://trello.com/c/ouZ2DExb

Link to Trello card

https://trello.com/c/pArii32e/3053-error-messaging-in-the-work-history-section
Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

Unit tests need a rethink, closing for now.

@malcolmbaig this is clashing with some work I did last night to create some reusable shared examples that enable easier and more consistent date validation. Can we somehow fit both together? I think it will also remove the need for having to have conditions specific to certain forms in the shared validations, as it checks for the locale key rather than the exact error message.
https://github.com/DFE-Digital/apply-for-teacher-training/pull/4207
I also couldn't identify how it skips the month and year specific error, as I was expecting blank_date_fields to be overriden in the form specific locales.

Can we somehow fit both together?

Sounds good, reviewing now.

I also couldn't identify how it skips the month and year specific error, as I was expecting blank_date_fields to be overriden in the form specific locales.

Not sure I follow, but restructured work history forms are falling back on errors.messages.blank_date_fields.

Can we somehow fit both together?

Sounds good, reviewing now.

I also couldn't identify how it skips the month and year specific error, as I was expecting blank_date_fields to be overriden in the form specific locales.

Not sure I follow, but restructured work history forms are falling back on errors.messages.blank_date_fields.

In the description of the PR there is a note about not including error messages specifically for the month, or specifically for the year (as quoted below).  I assume that means that you don't want to display the default invalid_date_month_and_year error which  indicates if the month or year are missing, but instead replace it with a more generic one? Unless I have mirsunderstood the description!

Does not include error messages specifically for the month or specifically for the year, as agreed with @gregknight1 (reason—not just a copy change, needs some non-trivial changes to how we handle date validations).

Closing to rebase on https://github.com/DFE-Digital/apply-for-teacher-training/pull/4207


How does Apollo parse raw radar/lidar CAN messages to construct point cloud data?

Hello, I'm currently studying Apollo source code. I would like to understand how Apollo parses raw radar/lidar CAN messages to construct point cloud data. Which part of the source code should I pay attention to?
Sorry for this boring question, I'm only a green hand for the moment...

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


custom.jmx.vegardit.ActiveMQ_Artemis_Queues plugin: ConsumerCountByQueue: missing dimension "queue"

Hi!
In
https://github.com/vegardit/activemq-artemis-dynatrace-plugin/blob/master/artemis-queues-plugin/custom/plugin.json
In the section
     "timeseries": {
        "key": "ConsumerCountByQueue",
        "unit": "Count",
        "displayname": "Consumer Count By Queue",
        "dimensions": [ "rx_pid" ]
      },
      "source": {
        "domain": "org.apache.activemq.artemis",
        "keyProperties": {
          "broker": "*",
          "component": "addresses",
          "address": "*",
          "subcomponent": "queues",
          "routing-type": "\"anycast\"",
          "queue": "*"
        },
        "attribute": "ConsumerCount",
        "allowAdditionalKeys": true,
        "calculateDelta": false,
        "calculateRate": false,
        "aggregation": "AVG",
        "splitting": {
          "name": "queue",
          "type": "keyProperty",
          "keyProperty": "queue"
        }
      }
    }

there is the splitting "queue" defined, but that requires also the dimension "queue" in the timeseries/dimensions element.
This causes data sent from the JMX agent sent to Dynatrace to be discarded, as there is a "dimensions mismatch" (data schema mismatch). So the data for this timeseries is lost unless the JSON is modified.
Note that newer versions of Dynatrace will validate this, causing the JSON not to be installable as is right now:

Best regards, Thomas

Thanks a lot!


new translation from weblate break the master

There is a empty translation file from weblate which cause issue on master:
https://github.com/OpenRefine/OpenRefine/commit/62be866a9f6346f0f62bcf60a150ebc6ed51de9f
need to find out why and how to prevent in future.

Yes this is annoying, this has already happened in the past and I have just deleted the translation. I will work on a cleaner solution so that OpenRefine just ignores these translations.

Not sure if this can be done from the weblate side. Another option is to merge to a dedicated branch and manually merge to master after review.

Weblate can also generate JSON file with empty translations for new language, would that work better for you?
If this is desired, just set "Base file for new translations" under File settings for your translation to translation to use a a template (translations will be removed when using it).

@nijel thanks a lot for chiming in, it's good to know! In our case I don't think it would work as the language name would be empty, so we could end up with blank labels in our drop-down list of languages to choose from.


Simplify mkVariable

I checked it at www.fpcomplete.com, it compiles and the tests pass, but I copied the changes to github editor manually, so there might be syntax errors if I missed something. I don't have GHC on my mobile phone :(
Note: mkVariable has simpler type now.

Cool!


kernel: Implement k_sleep for Single Thread

The current z_tick_sleep return directly when building kernel for Single Thread model. This reorganize the code and implement a spin lock to wait pass the required ticks.

I'm also curious, we always k_wait in single-threaded applications, why do we need k_sleep?

I'm also curious, we always k_wait in single-threaded applications, why do we need k_sleep?

The intention is not to provide more kernel functionality to Single Thread applications instead is to make drivers and subsystems available to it. For instance, I need RTC driver from ST and it uses a k_msleep
https://github.com/zephyrproject-rtos/zephyr/blob/b272760f062b36fe6ce5d14c7a3d9065d40a570a/drivers/rtc/rtc_ll_stm32.c#L84
The intention is make it compatible with the whole system at all. In this case the driver was wrote to multi-thread but it can be used in Single Thread applications.

I think we should just remove #ifdef CONFIG_MULTITHREADING instead of changing k_sleep so that it can be used in single thread

If I understood you correctly I'm not sure if this is possible.

sched.c is only compiled when using multiple threads. The limitation of CONFIG_MULTITHREADING seems redundant.

I originally opened at #63987 and than I realize that a spin look to wait the ticks is needed to make RTC works.

I'm also curious, we always k_wait in single-threaded applications, why do we need k_sleep?

The intention is not to provide more kernel functionality to Single Thread applications instead is to make drivers and subsystems available to it. For instance, I need RTC driver from ST and it uses a k_msleep
https://github.com/zephyrproject-rtos/zephyr/blob/b272760f062b36fe6ce5d14c7a3d9065d40a570a/drivers/rtc/rtc_ll_stm32.c#L84
The intention is make it compatible with the whole system at all. In this case the driver was wrote to multi-thread but it can be used in Single Thread applications.

#ifdef CONFIG_MULTITHREADING
bool success = WAIT_FOR(LL_RTC_IsActiveFlag_INIT(RTC), RTC_TIMEOUT, k_msleep(1));
#else
bool success = WAIT_FOR(LL_RTC_IsActiveFlag_INIT(RTC), RTC_TIMEOUT, k_wait(1000));
#endif
Wouldn't it be better to do this? According to the documentation of zephyr rtos, k_msleep will not actually appear in multi-threaded applications. You may need to change the document according to your change method

Wouldn't it be better to do this?

IMHO a good idea is make a small patch on a single point that do not affect anything and enable all subsystem/drivers that use the primitive. It's far better than start to adapt drivers/subsystems. It is perfect reasonable if there is intention to make code compatible.
Do you see issues to make k_sleep behave exactly like k_wait for single thread ?

You may need to change the document according to your change method.

Sure, I'll do it.

Wouldn't it be better to do this?

IMHO a good idea is make a small patch on a single point that do not affect anything and enable all subsystem/drivers that use the primitive. It's far better than start to adapt drivers/subsystems. It is perfect reasonable if there is intention to make code compatible.
Do you see issues to make k_sleep behave exactly like k_wait for single thread ?

You may need to change the document according to your change method.

Sure, I'll do it.

I am not opposed to this change. One bad thing I think is that there are many functions in the sched.c file that cannot be used in a single thread. After the current change, you cannot get a warning during the compilation phase. This is where I think there's a problem

Would it be better to combine k_sleep and k_busy_wait into one file. Make them usable from a single thread. It is obvious that zephyr's scheduler(sched.c) cannot be used in a single thread

I don't think that moving sched.c to always be built is the right direction.
Two ideas come to mind that build upon each other--perhaps they are not any good, but I will toss them out for evaluation nonetheless.
The first is to have a non-multithreading definition either in its own file, or in busy_wait.c.
The second is ... can we build on this alternate k_sleep() to leverage k_timer in some way? This would require some exploration/experimentation, but the gist of this idea is to set up a custom k_timer to fire in N ticks and have the main thread go idle via k_cpu_idle(). If this is workable, then the primary benefit would be that it might allow for the system to sleep for the necessary number of ticks without consuming as much power.

The second is ... can we build on this alternate k_sleep() to leverage k_timer in some way? This would require some exploration/experimentation, but the gist of this idea is to set up a custom k_timer to fire in N ticks and have the main thread go idle via k_cpu_idle(). If this is workable, then the primary benefit would be that it might allow for the system to sleep for the necessary number of ticks without consuming as much power.

More or less exactly what I was thinking.
I'm less partial about the separate compilation unit, but I do appreciate a reduction in #ifdefs occasionally

Targeting the same issue ;) https://github.com/zephyrproject-rtos/zephyr/pull/66430
Some drivers use k_sleep(). In our case, LPC Serial driver. So compilation of single threaded application is blocked by error.
We need to move sched.c to common code to unblock our progress.

Hi @peter-mitsis , @cfriedt ,

The second is ... can we build on this alternate k_sleep() to leverage k_timer in some way? This would require some exploration/experimentation, but the gist of this idea is to set up a custom k_timer to fire in N ticks and have the main thread go idle via k_cpu_idle(). If this is workable, then the primary benefit would be that it might allow for the system to sleep for the necessary number of ticks without consuming as much power.

I think that will be the better idea. However adding a timer inside kernel to track that option could be trick, since we need to manage other resources that may wake-up in the mean time. Because of that, at moment, I added the Peter proposal to the case of a timeout == K_FOREVER. This is already handled by the z_impl_k_sleep function and system will wait in LPM for an interrupt.
The second part could be introduced in a second moment as an optimization for LPM which is not part of this PR.

It might make sense to have a no_multithreading.c that gathers
all sorts of dummy wrappers and/or simplified implementations.
Mutex support (PR #63935) is another one that could go in.

Hi @andyross ,
Can you revisit and let me know if something is missing? It important to us have this in v3.6.


Using arrow keys in ImagePreviewerPlugin duplicates the rotate buttons and Image not scroll using arrow keys.

Fixed : Create buttons on initialize instead of showPage() and added logic for handling page mechanism to scroll image with arrow keys.

Untested, but thanks for the code.


🐛 Fix no completions for comments

:tada: This PR is included in version 2.1.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


nixos/swap: avoid top-level with expressions

#208242

Motivation
Top-level with turns off any sort of typo detection at parse time; the file must be actually evaluated to find out whether there's an error.
Description of changes

[x] Inherit mkIf, mkOption, and types from lib as they are used pervasively
[x] Otherwise, where something was used from lib, add lib.
[x] Where something was used from utils, add utils.

Things done

[x] Tested with nix-build -A nixosTests.swap-partition
[x] Fits CONTRIBUTING.md.

@fricklerhandwerk: on this one, I decided to try lib. in front of each usage except for pervasive usages.


Enhance Lint/IdentityComparison cop with a rule for object_id as hash keys

This implements a second part of https://rubystyle.guide/#identity-comparison

Thank you for the implementation. I was also considering this style rule implementation.
I'm not sure if user can always change hash creator which compare_by_identity method should be added. So, It may be simpler to split the roles with another Lint/CompareByIdentity (?) cop. They also have different auto-correction support.
Cc @rubocop-hq/rubocop-core

Extracted into a separate cop.

Thanks!


Keypad registers two presses when only pressing once.

Sometimes when using predictive text, pressing a key once will type two letters, this could be a hardware issue on my end although I haven't encountered it anywhere other than typing.
The keyboard also sometimes adds a number when I start typing, in addition to the letter I have selected.
Thanks for all of your hard work on this incredibly useful tool!

Yes, it sounds to me that some system key handler occasionally kicks in and tries to type numbers and whatnot. I suppose your phone is running a heavily customized version of Android, like Kyocera and LG, which is really difficult to deal with. Unfortunately, I don't think anything can be done, besides going back to your default keyboard, as alexknop suggested.
Out of curiosity, what is your phone make and model?


Add make instructions for Windows WSL users

This PR simply adds instructions for those that're running Windows WSL (Bash on Windows), and are having trouble running the make command, which seems to be a common issue.

@matthewlilley @Roasbeef  This is wrong info that got merged. I've done compiling on WSL many times and never have I had to run make like this. This info will confuse WSL users if there are anymore users running LND on WSL.  In case LND devs haven't got to know, WSL is "Windows Subsystem for Linux", basically a commnandline Linux distro like Ubuntu on Linux bash shell for windows. If you don't have to directly reference to where you store `make1 on your linux system, you don't have to do this on WSL, so it's false to say you have to do this on WSL.

@molxyz @Roasbeef You're right, this isn't related to Bash at all, it's something to do with Zsh.
Please see the following screenshot:

@matthewlilley  You need to figure out what's wrong with your zsh. I've been using WSL for two years since Ubuntu 14 then Ubuntu 16, and now Ubuntu 18, and I've compiled lnd, c-lightning, bitcoin core, bitcoin knots and some other software on WSL, always have to use make  and not one time WSL has ever demanded me to reference directly to where make is located.  I think probably there is some issue with your Zsh how it's installed?  Looks to me more like it's a personal issue than a general issue with WSL, otherwise you should discuss it with Microsoft Linux team.
Here's my screenshot to show how make && make install works just fine on WSL:

@matthewlilley I have confirmed that make && make install works from the bash Windows program (which runs under WSL), while "make" && "make" install does not work, at least not the first time, and I didn't try it a second time.  Adding the double-quotes is an interesting idea.  It seems to me that the double-quotes should not have any effect, but @molxyz said it wouldn't work with them (after it didn't work with them when I tried it) so I tried it without them and it worked fine.

My tests suggest that I was right that the quotation marks (in this case) don't make a difference.  The differences I experienced seem to be because I did it more than once, but it may have been the case that I wasn't always in the same folder.

@dscotese AFAIK this was one of the quirky bugs in an early version of WSL, specifically related to the way WSL at the time was adding the Windows PATH.
If you're interested in some specifics, there's a very relevant Bitcoin Core issue below.
https://github.com/bitcoin/bitcoin/issues/10269


VASP calculation not detected

The attached zip file has one selected VASP calculation with complete OUTCAR (as far as I can say), but it is not detected and nomad fails at processing with "No calculations found". Is this some problem with the calculation itself (I have a whole bunch of similar ones from one user) or a parser (mainfile detection) bug?
8.9_0.6eV0.96.zip

@ladinesa Please have a look at this.

The issue seems to be with the mainfile matching indeed i.e., the first line in my OUTCAR is:
 vasp.<IP_ADDRESS>Apr17-6-g9f103f2a35 (build Sep 11 2017 19:21:43) complex
the current relevant part of mainfile_contents_re:
?|^\svasp[\.\d]+\s*\w+\s*\(build')
the issue is that the \w fails to match the dash, something like
?|^\svasp[\.\d]+\s*[\w-]+\s*\(build')
could maybe work?

My regex skills are failing me. \w in character class [] doesn't work as I thought it does,
?|^\svasp[\.\d]+\s*\S+\s*\(build')
works obviously, but might be too general?

I think it is specific enough. It still has vasp, a version number, and build in it. Everything in one line. That is pretty unlikely to have it in other files.

Sorry for jumping in too late. Should I include a fix in the next commit or will you @ondracka will do it?

@ladinesa please do it. Thanks.

Actually hold the fix yet, I rebuilded my local image with the fix, but it still doesn't work, I need to do more testing.

@ondracka the current fix seems to work. I am closing this now.

Confirming fixed


Scenario failure [13/10/20]: BF1 - Expected request_count 11 but got 10

Thanks for filing a bug report :-)
During the nightly run the BF1 scenario failed.
Looks like this is related to https://github.com/raiden-network/raiden/pull/6613 as it passed the run before.
Traceback (most recent call last):
File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/base.py\", line 138, in __call__
  raise exception
File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/base.py\", line 126, in __call__
  return_val = self._run(*args, **kwargs)
File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/api_base.py\", line 66, in _run
  return self._process_response(response_dict)
File \"/usr/local/lib/python3.7/site-packages/scenario_player/tasks/services.py\", line 217, in _process_response
  f\"Expected request_count {exp_request_count} but got {actual_request_count}\"
  scenario_player.exceptions.ScenarioAssertionError: Expected request_count 11 but got 10"}
{"task": "<SerialTask: {'name': 'Check that IOUs exist after the payments', 'tasks': [{'wait': 100}, {'assert_pfs_history': {'source': 3, 'target': 0, 'request_count': 11}}, {'assert_pfs_iou': {'source': 3, 'amount': '550000000000000000'}}, {'assert_pfs_history': {'source': 1, 'target': 4, 'request_count': 10}}, {'assert_pfs_iou': {'source': 1, 'amount': '500000000000000000'}}, {'assert_pfs_iou': {'source': 2, 'iou_exists': False}}]}>", "event": "Task errored", "logger": "scenario_player.tasks.base", "level": "error", "greenlet_name": "orchestration", "timestamp": "2020-10-13 14:50:22.532853", "exception": "Traceback (most recent call last):

Logs:
scenario-player-run_bf1_basic_functionality_2020-10-13T14:25:29.log.gz
Expected Result

Scenario should pass

Remark

This needs to be fixed on the Raiden Python client side and the scenario needs to be changed back as this it is a capacity check.

@karlb Could you please have a look at it. Thanks :) @andrevmatos has got details about it.

@karlb Looks like you guys removed local routing, and changed the expected request_count to 11. We don't have local routing, and had it passing before, because even without full network topology, on this specific case, the node can know no local channels are eligible for the requested transfer, and fail before wasting a PFS request which we could know wasn't possible anyway.
The reason the scenario failed for us is because we have this optimization, and I think you can implement it to and revert the scenario change:
https://github.com/raiden-network/light-client/blob/25bf8e352b6e8d61e0b72cb6c54287a8e378edc3/raiden-ts/src/services/epics.ts#L1068-L1075

Our though was that asking the PFS was acceptable (although not optimal in this case) and the quick and simple way was to allow this in the scenario. We still have to get used to the fact that the light client is running the same scenarios :-)
Adding the same optimization to the python client should not be too hard, so I guess that is what we will do to resolve this.


updated go path to run the cli install

Description
Missing Go path and need privilege to run make install.

/bin/sh: 2: go: not found
go: writing go.mod cache: mkdir /home/airflow/go/pkg/mod/cache/download/github.com/mitchellh: permission denied

Fixes

Codecov Report

Merging #156 (11ada85) into master (70617b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   93.45%   93.45%
=======================================
  Files          24       24
  Lines         993      993
=======================================
  Hits          928      928
  Misses         65       65

Flag
Coverage Δ

gha
93.45% <ø> (ø)

python-3.9
93.45% <ø> (ø)

unit
93.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70617b3...11ada85. Read the comment docs.


Fork resilience has been disabled since the new Meson build

Shouldn't we re-enable BXF_FORK_RESILIENCE by default?

Leaving it off by default is probably the better default. Fork safety is very delicate and not guaranteed to work on all platforms & pthread implementations, and not all users might decide to use threads necessarily. Even when using threads, all forks are followed by exec() so we don't need to clean up the locks & threads in the children, at maybe the risk to see some deadlocks if there's a programming error in BoxFort.
In any case, this option has risks, and enabling it should come with full awareness of what this means.

Oh, I see.
Thank you for the insight.


[WFCORE-4105] Add tests for add-user, domain, elytron-tool, jboss-cli…

… and standalone scripts.
https://issues.jboss.org/browse/WFCORE-4105
There are some ignored tests in this PR for shells the scripts do not seem to work in. If there is no intention of the scripts to work with these shells we can remove the tests all together. Otherwise we should consider attempting to fixing the scripts.
I also discovered there PowerShell is available for other platforms, https://github.com/PowerShell/PowerShell#get-powershell. Our scripts do not work however as we hard-code the path separator (\) which didn't seem to work on Linux. We could attempt to fix that so the *.ps1 scripts could be tested on other platforms. However these tests may be enough since they'll run on the Windows PR runs.

@jamezp Could you update the testsuite/scripts/pom.xml to use the 7.0.0.Alpha2-SNAPSHOT version?

I removed the label as I've updated the version to 7.0.0.Alpha2-SNAPSHOT.


How to package this application for Mac, Windows and linux.

How to package this application for Mac, Windows and linux.

electron builder takes care of packaging.
If you want to build an installation package do
npm run release
Once the packaging process finished, the dist directory will contain your distributable file.


Consider restating in the positive: "Do not send home when stopped" -> "Dock when stopped" (1.3.0-beta.5)

Settings should be stated in the positive for clarity.

Expected Behavior
The last setting in the screenshot should be:

☑  Dock when stopped

"dockOnStop": true,

It can default to on/"true".
Current Behavior
The current setting is a double negative when it is in its default state, which makes it harder to understand at a glance:

[Do not] "Do not send home when stopped"

Or, in the config:
"noDockOnStop": false,

Versions

Homebridge: 1.3.4
Node:  14.17.6
Plugin: 1.3.0-beta.5

@khad thank you, I agree. @rcoletti116 would you like to update, and set a default in the schema and in the code?

I'll take a look and think about this one. I had this in the positive before submitting the PR, but there was a reason I changed it.

(I wouldn't recommend "Pause when stopped" because it seems like a logical contradiction. Pause and stop are two different things, no?)

I've got a PR coming that should reverse this and make it more logical. As far as pause vs. stop - they are two different things to Roomba, though iRobot's own app has tried to do away with stop. Stop ends a cleaning job and pause does not.
The next version will be "Send home when stopped," with the default being "true" to preserve the current function for all users who update.


Learn Advanced Array Methods By Building A Statistics Calculator - Step 32: Confusing Phrase

Describe the Issue
Confusing phrase:

"Inside your getMode function, on the empty line above your return call forEach on array. (...)"

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-advanced-array-methods-by-building-a-statistics-calculator/step-32
Your code
.
Expected behavior
I believe it is better understood by (1) placing an extra comma (,), and maybe (2) placing backticks (``) on the "return", like the following:

"Inside your getMode function, on the empty line above your return, call forEach on array. (...)"

NOTE: The problem was: I was keep reading "above your return call", and then "forEach on array", and it wasn't making any sense to me. I had to read multiple times until I get it, to separate "return" from "call forEach".
Screenshots
No response
System

Device: [e.g. iPhone 6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]

Additional context
No response

Thank you for reporting this issue.
This is a standard message notifying you that the problem you mentioned here is present in production, but that it has already been fixed in codebase - #55106. This means that the next time latest codebase changes will be pushed to production, this problem should be fixed. Because of this, we're closing this issue.
If you think we're wrong in closing this issue, please request for it to be reopened and add further clarification. Thank you and happy coding.


Training with custom dataset

Hi,
Thank you for your beautiful work.
I am trying to train using custom dataset. I have tried replicating the COCODIR format for the training but unable to do so. Could you kindly provide a manual to work with custom dataset, and how custom dataset format should look like?
Thank you.

We provide a guide on custom dataset in https://github.com/IDEA-Research/DINO#run. Training/Fine-tuning a DINO on your custom dataset item. Hope this section is helpful.


Hawtjni plugin uses hard-coded MSVS project file name

It's currently hard-coded to vs2010.vcxproj.  It would be nice if this was configurable.

FYI @normanmaurer


Added support in streamlit >= 1.17.0

Thank you for the contribution, but the CI failed.
Please run the following command to format the code.
poetry run isort .
poetry run black .
poetry run flake8

Mypy static type checking is also done.
poetry run mypy .

Sorry there are not documented yet, but I will.

Hi @whitphx, done :)

Thank you!


Fixed #4262 by skipping typename while deserializing map entries.

Related to the issue:

https://github.com/libgdx/libgdx/issues/4262

ArrayMap and ObjectMap are not affected, but the added test should cover this scenario for them as well.

Thanks!


Peer review for Shivank Goel

Based on the extensive review of your paper, here are some observations and recommendations for enhancement:
Title and Abstract:

Observation: The title of your paper suggests a focus on cybersecurity, specifically data breaches and ransomware statistics, which aligns well with the growing concern over digital security. The abstract, however, could benefit from a clearer delineation of the study's scope, including geographic focus and specific cybersecurity incidents analyzed.
Recommendation: Consider refining the title to include a mention of the geographic focus if your study is limited to a specific region. For the abstract, succinctly summarize the research problem, methodologies employed, key findings, and the implications of these findings.

Introduction:

Observation: Your introduction provides a solid groundwork, emphasizing the importance of cybersecurity in the digital age. The mention of specific cyber incidents adds relevance to your study. However, the introduction could further benefit from a brief overview of the theoretical framework guiding your analysis.
Recommendation: Incorporate a concise discussion of the theoretical perspectives or models that inform your analysis. This could include theories related to cybersecurity, data protection, and the socio-economic impacts of cyber incidents.

Data:

Observation: The data section details the sources and collection methodologies clearly, particularly your reliance on datasets from Alberta's provincial open databases. However, there seems to be a misalignment between the datasets described (focusing on air quality and mortality rates) and the stated focus of your paper on cybersecurity.
Recommendation: Clarify the relevance of the datasets to your study's objectives. If the focus is indeed on cybersecurity, ensure the data section accurately reflects the cyber incident datasets used in your analysis. Consider separating the description of datasets if your study encompasses both cybersecurity and environmental health to avoid confusion.

Methodology:

Observation: Your methodology section is detailed and demonstrates a rigorous approach to data cleaning and analysis using R. The mention of specific R packages and functions enhances the reproducibility of your study.
Recommendation: Further clarify the analytical techniques used to draw correlations or assess the impact of cybersecurity incidents. If statistical models or specific analytical frameworks are employed, provide a detailed explanation of these methods and their justification.

Results and Discussion:

Observation: The results are comprehensive, and the use of visualizations like graphs enhances the presentation of your findings. However, the connection between the data presented (related to air quality) and the stated focus on cybersecurity incidents needs clarification.
Recommendation: Ensure that the results section directly addresses the research questions outlined in your introduction. If your study indeed covers both cybersecurity incidents and environmental data, clearly delineate these sections and discuss their interrelation if relevant.

Conclusion:

Observation: The conclusion succinctly summarizes key findings but could be enhanced by explicitly linking these back to the research objectives and discussing their broader implications.
Recommendation: Expand your conclusion to reflect on the study's contributions to the existing literature on cybersecurity, potential policy implications, and suggestions for future research.

General Feedback:

Your paper demonstrates a strong foundational understanding of the importance of cybersecurity. The detailed methodology and comprehensive analysis speak to a thorough investigative process. However, the apparent misalignment between the paper's stated focus and the datasets described warrants clarification. Ensuring a coherent narrative that aligns the title, abstract, data, and analysis sections will significantly enhance the paper's clarity and impact.

Overall, your paper is on a promising track, and addressing these observations can elevate its quality further. Good luck with your revisions!

I really appreciate your efforts for providing a detailed review and suggestions. I have fixed all the issues as suggested.
Thanks


chore: Consumer refresh button

What this PR does / why we need it:

A refresh button that can be used for Consumer Groups and Topics

Verification steps

Hoover
< PROOFOFCONCEPTS > < RefreshButton > < Example1 >

Text next to button
< PROOFOFCONCEPTS > < RefreshButton > < Example2 >

*Text to far right
< PROOFOFCONCEPTS > < RefreshButton > < Example3  >

@riccardo-forina I wasn't able to get the test to run on the old pr, but when I opened a new one (this one) it worked


Change coding cookie to use utf-8 (lowercase)

While perfectly valid, the encoding 'UTF-8' (uppercase) is not
recognized by the Emacs MULE system. As such, it displays the following
warning when opening a file with it used as an encoding cookie:
Warning (mule): Invalid coding system ‘UTF-8’ is specified
for the current buffer/file by the :coding tag.
It is highly recommended to fix it before writing to a file.

Some discussion of this can be found at:
https://stackoverflow.com/questions/14031724/how-to-make-emacs-accept-utf-8-uppercase-encoding
While the post does offer a workaround for Emacs users, rather than ask
all to implement it, use the more typical utf-8 (lowercase).

Seems good to me!


Implement DeepOmit

Below is a simple example (which has been added to README)
Here is the Teacher interface.
interface Teacher {
  name: string,
  gender: string,
  students: {name: string, score: number}[]
}

Now suppose you want to omit gender property of Teacher, and score property of students. You can simple define a filter type and then use DeepOmit.
In the filter type, the properties to be omitted completely should be defined as true. For the properties you want to partially omit, you should recursively define the sub-properties to be omitted.
interface Filter {
  gender: true,
  students: {
    score: true,
  }
}

type TeacherSimple = DeepOmit<Teacher, Filter>

// The result will be:
// {
//  name: string,
//  students: {name: string}[]
// }

NOTE: DeepOmit works fine with Arrays and Sets. When applied to a  Map, if its key and value shares common properties, both will be omitted.

The major difference from my proposal is that your filter type can have arbitrary keys, while mine was restricted to use only the actual keys of the filtered type. This can be helpful to avoid type typos (hehe), but maybe it's overkill?

I think we should be strict and allow only types that have common keys with a type being filtered — I really liked this in your original solution @quezak I can't imagine a situation when not finding such mistake makes sense.

I think we should be strict and allow only types that have common keys with a type being filtered

Ok :) I think my type can be incorporated into this PR and extended for work with Arrays, Sets and Maps. Let's wait for @lucifer1004, or I could look into it later.
Maybe we should even restore "our better Omit" as StrictOmit or something :joy:

Maybe we should even restore "our better Omit" as StrictOmit or something 😂

Yeah I didnt realize that there is a difference in their implementation. Our type is so much better 😆

@quezak I have tried your solution but found a problem.
Spec extends DeepOmitSpec<T> cannot force common types, because
{a: string, b: number} extends {a: string} is true.
So even with the spec, filters with nonexistent properties still pass.

@krzkaczor I have added the filter spec suggested by @quezak
It took quite a while to handle the Array/Set/Map case.
For Map, I now only filter V instead of K+V.
The problem is described in the comment above.

I come up with a new idea, wait for my update.

@krzkaczor @quezak
Please check my latest implementation.
My idea is that T should be the subset of a superset of P.
This implementation ensures that neither wrong property type nor extra properties are allowed in the filter.

Looks promising, I'll take a detailed look later to compare the two approaches.

Tried my best but failed to figure out a way to support immediately nested Set/Map/Array.
Works fine for things like:
type T = Set<{
    a: {
      b: string;
      c: {
        d: string;
        e: boolean;
      };
      f: number;
    };
    array: { a: string; b: boolean }[];
    set: Set<{ a: string; b: boolean }>;
    map: Map<number, { a: string; b: boolean }>;
  }>

But not this
type T = Set<{
    a: {
      b: string;
      c: {
        d: string;
        e: boolean;
      };
      f: number;
    };
    array: { a: string; b: boolean }[];
    set: Set<{ a: string; b: boolean }>;
    map: Map<number, { a: string; b: boolean }>;
  }>[]

nor this:
type T = {
    a: {
      b: string;
      c: {
        d: string;
        e: boolean;
      };
      f: number;
    };
    array: { a: string; b: boolean }[];
    set: Set<{ a: string; b: boolean }>;
    map: Map<number, Set<{ a: string; b: boolean }>>;
  }

I just checked and confirmed that my original version could support such nested omit.
A practical use case would be deep omitting in a high-dimensional array.
So there is a tradeoff.

To sum up:

Commit
Cascaded Array/Set/Map
Security

Impl 1 Plain
30da8b9
✔
No type check

Impl 2 Filter Spec
d486615
❎
Check wrong types

Impl 3 Superset + Subset
813dbf1
❎
Check wrong types & nonexistent types

Cascaded Array problem solved via the latest commit.
@krzkaczor @quezak Looking forward to your comments.

One more thing to explain, I changed the markup type (for properties requiring complete deletion) from true to never in an earlier commit, because I found that when I used true as the markup type, never would just fit in as well. It seemed that the easiest way to address this was to change the markup type to never, and I did so.

I changed the markup type from true to never

I noticed that, nice idea -- gives a better feeling when writing the filter!

Thank you for this contribution 🙏 Released as<EMAIL_ADDRESS>Btw. I am gonna update readme master's readme about what's cooking here.

@all-contributors please add @lucifer1004 for documentation

@all-contributors please add @quezak for documentation, review


testground/infra: create a nightly job for arabica test

What we need to do:
Important Job

[x] Clones the repositories testground & test-infra
[x] Setup & Configure TestGround in the GA
[x]  GA that takes the latest commit hash of node and builds a new go.mod
~[ ]  Granting our job rights in AWS to execute the test~

We don't need to grant AWS permissions to the GA to execute the test

[x]  Schedules a testground test run via composition
[x]  If the daemon accepts the job run -> we can mark the job as success

Another Job

[ ] Test Status should be done as a separate job
[ ] As the daemon exposes it REST endpoint, we can simply curl it to get the latest job run status

Caveats
Installing testground is required to get the client up and running the test
This is a bummer as GA is notoriously famous to not have a beefy instance
Hence, we can delegate the calling to another instance that never deletes the client of testground
Nice to have

[ ]  we need an slack alert to know what happened to the nightly run

Very nice to have

[ ]  slack alert should contain a link to the dashboard with logs
[ ] i.e. a simple LogQL query might be nice for the start

@Bidon15 and @jrmanes to get back to this once robusta nightly is achieved

hey @Bidon15
I'm working on this one, I'll let you know as soon as I have something 👌
cheers!

Hello!
we can schedule tests using the GitHub Action to TestGround 🚀
(In the image we can see an error, no worries for that, it was because I manually killed it, we are running huge tests atm and I didn't want to bother them)

The Github Action results looks like this:

Execution: link
As you can see, the last message:
TestGround ID is: [ch52ejh26un2ddne0640]

This gives us information about if we could queue the task or not, if not, we fail the job and returns an exit 1 code, setting the execution as failed.
I'll do couple of more test

Closing as barely sufficient
We will open a new one once more feedback comes in


Creation of setup.py

Hi guys!
First of all, thank your for a great project!
I would like to suggest that you create a minimal setup.py so that the project can be easily installed. Or is there something that is preventing you from doing this?

You are right. If you have time, a pull request will be great.

Can you just provide an update on whether it is still necessary to get your fork of allennlp? I know it was discussed here #55 but I wonder whether some newer versions of allennlp already have the feature you mentioned?