Something error of Visinteraction when using toy example

#reproduce script
python ExtractEdges.py --species mouse --emFile toy.sc.em.txt --annFile toy.sc.ann.txt --interDB lrc2p --coreNum 4 --out example
python VisInteractions.py --sourceFolder example --drawClusterPair n --keepTopEdge 15

Error information:
Input data:
The source dataset folder: example
The ligand-receptor interaction database: lrc2p
The weight type of cell-to-cell signaling: mean
The detection threshold for interactions to draw is: 0.2
The specicificity threshold for interactions to draw is: 0
The expression threshold for interactions to draw is: 0
Top cluster-to-cluster edges to draw is: 15
The network layout: kk
The font size for cluster labels: 8
The edge width: 0
The maximum radius of the clusters: 0
The relative distance between clusters: 1
The plot width: 12
The plot height: 10
The plot format: pdf
===================================================
#### start to construct the cell-to-cell communication network
#### 575 edges are loaded
#### plotting the weighted directed cell-to-cell communication network
#### the folder "/Users/lixiangjie/Documents/tmp_xumengda/example/Network_exp_0_spe_0_det_0.2_top_15_signal_lrc2p_weight_mean" has been created to save the analysis results
Traceback (most recent call last):
  File "VisInteractions.py", line 951, in DrawGraphvizPlot
    nxgS.draw(plotFileName,prog='fdp')
  File "/Users/lixiangjie/anaconda3/envs/py36/lib/python3.6/site-packages/pygraphviz/agraph.py", line 1476, in draw
    data = self._run_prog(prog, args)
  File "/Users/lixiangjie/anaconda3/envs/py36/lib/python3.6/site-packages/pygraphviz/agraph.py", line 1341, in _run_prog
    warnings.warn(b"".join(errors).decode(self.encoding), RuntimeWarning)
RuntimeWarning: Warning: node 'Cancer Cell
(5 cells)', graph '' size too small for label
Warning: node 'Endothelial Cells
(2 cells)', graph '' size too small for label
Warning: node 'Neutrophils
(3 cells)', graph '' size too small for label

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "VisInteractions.py", line 2507, in <module>
    MainNetwork(opt.sourceFolder, interDB, weightType, specificityThreshold, weightThreshold, detectionThreshold, keepTopEdge, layout, plotFormat,plotWidth, plotHeight, fontSize, edgeWidth, maxClusterSize, clusterDistance)
  File "VisInteractions.py", line 1327, in MainNetwork
    BuildInterClusterNetwork(origlabels, labels, cltSizes, ccolorList, edgeDF, specificityThreshold, weightThreshold, frequencyThreshold, keepTopEdge, interDB, weightType, layout, plotFormat, plotWidth, plotHeight, fontSize, edgeWidth, maxClusterSize, clusterDistance, resultDir)
  File "VisInteractions.py", line 1126, in BuildInterClusterNetwork
    readmeStr = DrawGraphvizPlot(readmeStr, 'edge-count', 'int', nxgC, adjCountM, dataType, resultDir, plotWidth, plotHeight, fontSize, edgeWidth, colorDict, cltSizeDict, maxClusterSize, wposDictCount, labels, specificityThreshold,weightThreshold,frequencyThreshold,interDB,weightType,layout,plotFormat)
  File "VisInteractions.py", line 959, in DrawGraphvizPlot
    for nd in nxgS.nodes():
  File "/Users/lixiangjie/anaconda3/envs/py36/lib/python3.6/site-packages/pygraphviz/agraph.py", line 388, in nodes
    return list(self.nodes_iter())
DeprecationWarning: generator 'AGraph.nodes_iter' raised StopIteration
Exception ignored in: <bound method Popen.__del__ of <subprocess.Popen object at 0x7f81c8dec390>>
Traceback (most recent call last):
  File "/Users/lixiangjie/anaconda3/envs/py36/lib/python3.6/subprocess.py", line 786, in __del__
    ResourceWarning, source=self)
ResourceWarning: subprocess 74762 is still running

Hi, could you increase --plotWidth (default is 12) and --plotHeight (default 10)?


Question about the data needed for single-view recon testing

First of all, thank you so much for sharing your great work!
I have a question about the types of data needed for single-view reconstruction.
In the paper, it appears that 3D can be reconstructed with just a single view image.
However, in the code, poses and intrinsics are also needed. Also, the chairs_test_cache.pkl file seems to be needed for chair reconstruction. Are poses and intrinsics also necessary for single view reconstruction test? And what does the pickle file do?
Lastly, I would really appreciate it if you could tell me what steps must be taken to test single view reconstruction from an arbitrary real (chair) image.
Thanks

Hi! In the paper we mentioned that camera parameters are currently required to perform image-based reconstruction. To perform reconstruction from real images, you may either use a pose estimator or manually set the camera in GUI (this feature may be streamlined in a future update of this codebase). Many of our tests indicate that SSDNeRF is reasonably robust to pose errors.
The cache file is auto generated from the dataset, and is therefore not necessary (you can comment out that line).

@Lakonik
Thank you for answer!
I didn't read the paper carefully... I'm sorry.

@Lakonik
I have additional questions!
I found out that the camera pose is in opencv format. But is the format w2c form or c2w form?

The pose matrix is c2w, from opencv's camera coordinate system to the world.


Removing unnecessary maildir folders creation

According to Dovecot configuration /etc/dovecot/conf.d/15-mailboxes.conf
Drafts, Junk, Trash and Sent folders will be created on the fly (reference documentation: https://wiki.dovecot.org/MailboxSettings)

Looks good except for one thing. We are not removing the folders - we just want Dovecot to create them for us, right? Ideally I'd like to keep the old checks in the test and create the folders by making a Dovecot connection to the server from the test. Then the test verifies that the auto-creation works as intended.


fix: gallery item image container is not square on tablet

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Context

[x] Closes #5682

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at ce54cd9
Improved image quality and performance in the gallery by removing the original prop from the image components. This affects the GalleryItem.vue component and its subcomponents.

🤖 Generated by Copilot at ce54cd9

original gone
o-image and o-carousel
faster, sharper spring

Any news with this ? cc @exezbcz ?

@vikiival I approve this pr :D

hey i checked this one yesterday and squared images were still not showing properly, can give it another go today


Context is not correctly passed down to individual resolvers

Hi guys, I believe I have encountered the following bug. The context value which is created in express-graphql or apollo-server is not reaching the individual resolvers which are registered in the .meshrc.yml as resolverComposition resolvers or as additional-resolvers. I have set a codesandbox example where you can see the issue. Have a look at the README.md there. Alternatively you can use the example code also from github -> https://github.com/angelsvirkov/graphql-mesh-context-not-passed
Expected Behavior
Context object is available inside the resolvers. In the case of using express-graphql I also expect that the individual resolvers receive the request object.
Current Behavior
Context object is not available in resolvers. Instead it only partially works when we use destructuring to obtain the corresponding context of a particular source.
Steps to Reproduce

Start server I have given in the example
Navigate to the GraphiQL UI at codesandbox or locally at http://localhost:8081/
Use the following query query {  continents {  name  testProperty  } }
Have a look at the logs. The context is an empty object.

Possible Solution
I am currently looking at your source code, but I am still not able to pinpoint the issue. I assume it has something to do with how the context is built. Will give you an update if I find more details. What's interesting to note that in case we use destructuring inside the resolvers then we can at least pull some part of the context which is related to the corresponding source. This is how your example in the docs works -> https://github.com/Urigo/graphql-mesh/tree/master/examples/openapi-javascript-wiki

@angelsvirkov Context passed in resolvers is a Proxy instance from an empty object so that's why you are seeing {} but you can see it is connected to the actual context in the source code. If you do console.log(context.headers) you will see that your context object is still there as is.
That PR makes Proxy to point to the actual context object so it will give you better results;
https://github.com/Urigo/graphql-mesh/pull/597

Available in Available in  https://github.com/Urigo/graphql-mesh/releases/tag/v0.2.12


GNOME 46

Yeah, just can we get gnome 46 support

Would like that too

Done here, review pending on gse.


Croatian holiday date

Hi, can you please change:
in holidays.py line 4188 - Croatian Statehood day is june 25, not june 22.
Everything else looks good for Croatia.
Thank you, this repo helped a bunch

Fixed


What can we borrow from the Weave Cloud Deploy functionality

Question
What concepts, code, etc can we borrow from the Weave Cloud Deploy functionality?
Short description
I've heard from several sources that the deploy functionality is useful for customers of weave cloud.  Because of this, we should inventory what's there and assess what might be brought into WeGO
Timebox
3 days

Outcome
Writeup your findings here.  Please include the following (if any have been created) :

Screenshots
Design/architecture diagrams
WEP
PR/FAQ

Not specifically the code but the concept of the deploy action

@markramm  the Deploy button and the progress are key concepts.

Things that are interesting:

Deploy button, and deploy progress view
The timeline view (in phase 4 when we have prometheus

Documenting the different stages of the Deploy UI:
Pre button click; this shows which image is currently running on the cluster and which image will be deployed:

Flux v1 has two stages. The "Sync" stage is doing repository operations. The "Apply" phase is applying the manifest(s) to the cluster.

Some notifications pop in as things are happening (top right):

After the process is completed, some notes about the status of the individual steps:

To me, the core features of the Weave Cloud Deploy UI are as follows, with some added notes about Weave GO feasability:
Weave Cloud Deploy: Show a list of things that can be updated and their current image status

Weave GO: the list of "things to be updated" might be trivial, but showing the image status or "this thing can be updated" will take some thought, as the data model does not match 1-1

Weave Cloud Deploy: Show what changes will take place when the user clicks "Release"

Weave GO: Weave Cloud's atomic unit is a container image. Since Weave GO's atomic unit is a set of K8s yamls at a specific version (git ref), things are a little trickier here. We can show the different ref that will get applied, but a deeper diffing UI would take some time. Linking to a commit may be enough, since Github (or whomever) will take care of that UI for us.

Weave Cloud Deploy: Show the status of the steps of a deployment

Weave GO: Flux v1 had a simpler model where one agent did all the work, and therefore knew the status of that work. Its not immediately clear to me how we could know which things are "in progress".
A manual "sync" interaction is easy enough to track (the Flux UI does this now). Maybe we rely on the notification-controller for richer updates. We may also what to take a look at how kspan does it.

The timeline view (in phase 4 when we have prometheus

We do not need prometheus to render at timeline of releases. We would need prom for metrics/alerts/other events overlayed on the timeline.

In summary:
For a first-iteration of the Weave GitOps UI, Weave Cloud will be the inspiration for much of what we implement via a deployment UI. Weave Cloud is built on Flux v1, and Weave GO will be built on Flux v2, so the differences in the two data models will be where the UIs diverge, with Weave GO being more holistic, where Weave Cloud focused on container image changes.


Сreated login page, success login page.

Created a login page with a form, implemented email field validation, concealed the password, added focus on label click, and created a success login page with a 'Return to homepage' button for redirection

Hello, Of course you can't submit the form if you don't check the checkbox. All the inputs have the required attribute, which means that they are all required to be filled in before the form can be submitted.
"I don't see any errors " Erors when checkbox is not checked ?
Is there a way to implement this other than with the required attribute in HTML?
In the homework, it is indicated that the form should not be sent if the checkbox is not checked (or the mail or password fields), there seems to be nothing about errors.
"If the checkbox is not checked, or if the email or password fields are not filled in, the form should not be sent."

@MZabolotnev Hello, you can't submit the form if you don't check the checkbox. All the inputs have the required attribute, which means that they are all required to be filled in before the form can be submitted. "I don't see any errors " Erors when checkbox is not checked ? Is there a way to implement this other than with the required attribute in HTML?
In the homework, it is indicated that the form should not be sent if the checkbox is not checked (or the mail or password fields), there seems to be nothing about errors. "If the checkbox is not checked, or if the email or password fields are not filled in, the form should not be sent."

This is an example of bad UI. From the user's point of view - he cannot send the form and does not understand why. Now you don't see a about validation message through display:none. Try another way or use default checkbox

@MZabolotnev Thanks, check now please.


fix: Update book with new functionality

This change is

This builds on top of PR #378.

@Rhuagh I did a commit amend for that PR prior to it being r+ed, so you'll probably need to rebase this once it merges.

Ready for review

Nits addressed.


Adapting based not on props?

is it possible to inject variable not from props? says, i have a list and want to dynamically change the size of each items like below:
const Box = styled.div`
  wigth: ${index * 10}
  height: ${index * 10}
`;

[0, 1, 2].map((_, index) => <Box />);

Do you mean like this?
const Box = styled.div`
  wigth: ${props => props.index * 10}
  height: ${props => props.index * 10}
`;

[0, 1, 2].map((_, index) => <Box index={index} />);


[msal-node]: Increase code coverage

Increase code coverage of the msal-node library to +90%

Codecov Report

Merging #3975 (79d201b) into dev (cd45c77) will not change coverage.
The diff coverage is n/a.

Flag
Coverage Δ

*Carryforward flag

msal-angular
95.85% <ø> (ø)

Carriedforward from cd45c77

msal-browser
87.91% <ø> (ø)

Carriedforward from cd45c77

msal-common
85.00% <ø> (ø)

Carriedforward from cd45c77

msal-core
76.66% <ø> (ø)

Carriedforward from cd45c77

msal-node
81.57% <ø> (ø)

msal-react
94.11% <ø> (ø)

Carriedforward from cd45c77

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-node/src/network/HttpClient.ts
70.58% <ø> (ø)

@samuelkubai any update on this?

@samuelkubai any update on this?

Hi @sameerag, working on this, this week whilst on call.


MacOS Universal2 library

There is basic support for this in #4 but Big Sur runners for GitHub actions are currently restricted. This can be revisited in order to add Python wheels compatible with M1 Macs once the pool becomes generally available: https://github.com/actions/virtual-environments/issues/2486

Supported as of #24


feat: #960 - 2 lines (instead of 1) for "importance", and radio button on top

Impacted files:

attribute_button.dart: 2 lines (instead of 1) for "importance", and radio button on top
user_preferences_page-blue-dark.png: golden refresh
user_preferences_page-blue-light.png: golden refresh
user_preferences_page-brown-dark.png: golden refresh
user_preferences_page-brown-light.png: golden refresh
user_preferences_page-green-dark.png: golden refresh
user_preferences_page-green-light.png: golden refresh

What

When I tested the preference page in Italian, that didn't look good because the importance text could not fit in 1 line ("Non è") (and a second line "importante" was missing)
I've switched to 2 lines instead of 1, but then the combination of the text and the radio button didn't look good
I've moved the radio button to the top of the text, and that looks more coherent

Screenshot

Part of

https://github.com/openfoodfacts/smooth-app/issues/960

Thank you @M123-dev!
I'll need to add some minor changes as "golden" tests fail because of a "not big enough target" error.


chrome://flags : forgotten arrow

wondering why chrome is not able to get correct location and found that not using windows location api if need to use we have to set experimental feature through flags
and found following option to be through a function in Selenium
https://www.selenium.dev/selenium/docs/api/dotnet/?topic=html/T_OpenQA_Selenium_Chrome_ChromeOptions.htm
ChromeOptions.AddLocalStatePreference Method	WebDriver
Adds a preference for the local state file in the user's data directory for Chrome. If the specified preference already exists, it will be overwritten.
i am damn sure you will definitely add this to SeleniumVBA to get more control over chrome  and for those who want location services from such websites
https://www.gps-coordinates.net/my-location
https://whatmylocation.com/

@surfer-silver, I'm not sure I understand what you are asking for above - maybe you can demonstrate with some code? I think the WebCapabilities class should allow you to add any preference that you want to so maybe you can suggest a usage case to make your thinking clearer?
BTW, I just added GetGeolocation and SetGeolocation methods (Edge and Chrome only) to the WebDriver class that will allow you to do the following:
Sub test_geolocation()
    Dim driver As WebDriver

    Set driver = New WebDriver

    driver.StartChrome 'Chrome and Edge only
    driver.OpenBrowser

    'set the location lat and lon
    driver.SetGeolocation 41.1621429, -8.6219537

    driver.NavigateTo "https://www.gps-coordinates.net/my-location"
    driver.Wait 1000

    'print the name/address of the location to immediate window
    Debug.Print driver.FindElementByXPath("//*[@id='addr']").GetText

    driver.CloseBrowser
    driver.Shutdown
End Sub

@surfer-silver, I finally figured out what the "forgotten arrow" was... I added a new method in WebCapabilities class to make it easier:
Here is what you had to do before:
Dim localStatePrefs As New Dictionary
localStatePrefs.Add "browser.enabled_labs_experiments", Array("download-bubble@2", "download-bubble-v2@2")
caps.SetOption "localState", localStatePrefs
driver.OpenBrowser caps

Here is what you can do with v4.7:
caps.AddLocalStateFlags "download-bubble@2", "download-bubble-v2@2"
driver.OpenBrowser caps


[FEATURE] TPU training / validation support and train / val code refactor.

Goal is to adapt timm training and validation scripts to work well with PyTorch XLA on TPU/TPU Pods (maybe CPU/GPU), and PyTorch on GPU.
As part of this I will also refactor the training / validation loop, step fn, cuda/xla/distributed abstractions.
The aim is to keep it lean and fairly flat while breaking it down into some reusable/swapable components. There will be a bit more structure, but only a step in the direction of what fastai, lightning, ignite, etc offer.

@rwightman If you want, I am willing to help out with any efforts regarding adapting code to PyTorch XLA, having used PyTorch XLA many times in the past...

@tmabraham thanks, might take you up on that, currently thinking through the abstracitons, trying to hide most of cuda + distributed config vs xla + distributed config without making too many levels of abstraction.
My biggest concern is with the current 2 VM TPU architecture, how to feed the TPU VMs with data without needing to spin up one n1-96 nodes per 8 tpu as seems to be suggested to prevent the data preprocessing from holding back the TPU. Have you spent any time optmizing the infeed or tinkering with balancing pre-processing between the GCE feeding VM and the TPU host VM?

Unfortunately, I haven't spent too much time with optimizations regarding the passing of data from the VM to the TPU.

to prevent the data preprocessing from holding back the TPU
I would suggest that the data preprocessing should be already done and it's the preprocessed data that we load onto the TPU. For example, I had an NLP dataset that I trained an XLM-RoBERTa-large on using PyTorch XLA, and I already did the tokenization and saved as numpy files which I loaded as out-of-memory datasets.

Regarding things like augmentations, I think the best approach is to do batch augmentations on the TPU. I think this is already standard practice for TPU usage with TensorFlow. I know batch augmentations isn't something that's typically done in PyTorch though, but fastai's implementation of that might be worth a look...
I am assuming you want to do ImageNet training, correct? There is an example over here and a tutorial over here.


Add cilium upgrade planner

Description of changes:
In combination with the cilium installation, this allows to represent
the currently installed Cilium components and make an upgrade plan based
on the desired state defined in a cluster Spec.
Testing (if applicable):
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


[KOGITO-4675] Kogito operator PR check doesn't work after repository …

…rename
https://issues.redhat.com/browse/KOGITO-4675
Signed-off-by: Karel Suta<EMAIL_ADDRESS>Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains a link to the JIRA issue
[x] Pull Request contains a description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

/jenkins test

deploy and promote pipelines would also need to be modified (env REPO_NAME):

https://github.com/kiegroup/kogito-operator/blob/master/.jenkins/dsl/jobs.groovy#L123
https://github.com/kiegroup/kogito-operator/blob/master/.jenkins/dsl/jobs.groovy#L181

/jenkins test

bats test stuck but unrelated here. merging

lgtm.
Do we have any jira to change the go module name from github.com/kiegroup/kogito-cloud-operator to github.com/kiegroup/kogito-operator we would also need to make changes in the CSV with the repo name. I am not sure but will it be something that @vaibhavjainwiz you'll do in the productization effort?

@Kaitou786 I had create below Jira to change repo in all required places. Currently I had mentioned kie-docs, Jenkin pipeline and csv need to be changes for it. Please add more point if you found.
https://issues.redhat.com/browse/KOGITO-4678


⚠ Bofrost.es has degraded performance

In 068748d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1605 ms

Resolved: Bofrost.es performance has improved in 829a5c3 after 8 minutes.


Add documentation for running PyTest and PyLint from command line

Documentation Request Type

Please choose one of the following:

[x] New documentation
[ ] Documentation needs enhancement or clarification
[ ] Documentation is broken, inaccurate, or out of date

What needs to be done
There is currently no documentation on how to run pylint and/or pytest (as applicable) from the command line for repositories.
Result
Testing documentation is added to repositories

drone-makeflow: pending previous PR reviews
plotclip: https://github.com/AgPipeline/transformer-plotclip/pull/20
canopy cover: https://github.com/AgPipeline/transformer-canopycover/pull/26
soilmask: https://github.com/AgPipeline/transformer-soilmask/pull/22
greenness indicies: https://github.com/AgPipeline/transformer-rgb-indices/pull/13


Creating a folder to add all sorting algorithms

I am creating a folder for all the sorting algorithms in Python. New contributions or changes to the existing code are welcome.
This folder will make it easy to find all sorting algorithms in one place.

@vrittles please review


[ENHANCEMENT] Use generalJob image in promote jobs

Is your enhancement related to a problem? Please describe.

The promote jobs use busybox images: https://github.com/harvester/harvester/blob/01417955824dbea8d6e3a22bc0d7caad77915973/pkg/controller/master/node/promote_controller.go#L48
Describe the solution you'd like

We can use the general job image: https://github.com/harvester/harvester/blob/01417955824dbea8d6e3a22bc0d7caad77915973/deploy/charts/harvester/values.yaml#L488
This can reduce 1 image dependency. It would be nice to check if we have other components that depend on the image too.
Describe alternatives you've considered

Additional context

Provide test result on v1.3.0-dev-20231222, close as fixed.
Environment

Harvester
Version: v1.3.0-dev-20231222
Profile: QEMU/KVM, 3 nodes (8C/16,12,16/500G)
ui-source: Auto

Steps

 Provision 2 nodes Harvester cluster

Join node2 (3rd node)

 Job harvester-promote-harvester-node-1 uses bci-base:15.5 image :ballot_box_with_check:

 Job harvester-promote-harvester-node-2 uses bci-base:15.5 image :ballot_box_with_check:

 Promote jobs complete :ballot_box_with_check:


Node Attribute Deep Merge Caching Is Susceptible to Caching an Out of Date Attribute Merge

Description

Chef node attributes have various precedence levels and a deep merge is performed when node attributes are looked up.  The result of a deep merge is cached and a StateTracking mixin is used to invalid the cached result when attributes are mutated.  The crux of the issue is that the deep_merge! method in chef/node/attribute.rb can mutate the __root__ StateTracking instance variable and this will break merge cache invalidation.  This doesn't show up often in practice because the __root__ StateTracking variable is "fixed" by the [] method of StateTracking, so a fully-qualified lookup masks the issue (i.e. node.default['foo']['bar'] = 'something').  However, if, for example, you are holding on to a sub-level of the default attribute tree in a variable such that further assignments are done directly on that variable, the issue can show up.  Ex.
default['foo']['bar'].tap do |bar|
  # Other stuff up here...
  # Under certain cases this won't invalid the merge cache, see full replication steps
  # for specifics
  bar['hello'] = 'world'
end

Chef Version

Reproducible starting on version 13.4.11
Platform Version

CentOS 7
Replication Case

I created a minimal replication example in the form of a script that can be placed in the bin folder of a chef source code checkout and run to reproduce and explain the issue.
As previously stated, the issue can be replicated in any version starting with 13.4.11, but for the purposes of this example, we will use the latest stable version at the time of writing: 14.5.33
# Get the code and get set up
git clone https://github.com/chef/chef.git
cd chef
git checkout v14.5.33
bundle install
bundle exec rake install

Here's a script that demonstrates the bug and outputs information about what's going on as it does stuff:
#!/usr/bin/env ruby

require "rubygems"
$:.unshift(File.join(File.dirname(__FILE__), "..", "lib"))

require "chef"
require "chef/node/attribute"

puts '''
default = {
    "key1" => {
        "key2" => {
            "key3" => true
        }
    }
}
'''

default = {
    "key1" => {
        "key2" => {
            "key3" => true
        }
    }
}

puts '''
env_default = {
    "key1" => {
        "key2" => {
            "key4" => false
        }
    }
}
'''

env_default = {
    "key1" => {
        "key2" => {
            "key4" => false
        }
    }
}

# Keep this simple -- we only have defaults
puts "\n"
puts "a = Chef::Node::Attribute.new({}, default, {}, {})"
a = Chef::Node::Attribute.new({}, default, {}, {})
puts "a.env_default = env_default"
a.env_default = env_default

puts "\nFirst let's proxy some relevant StateTracking methods so we can log when they are called"

# Logs a call to the reset_cache method
module ResetCacheLogger
  def reset_cache(path = nil)
    puts "=== ResetCacheLogger ==="
    puts "Reset cache called for path #{path == nil ? 'nil': path}"
    super
  end
end

# Logs a call the StateTracking __root__ setter if the set changes the value
module RootChangeLogger
  def __root__=(root)
    if root != __root__
        puts "=== RootChangeLogger ==="
        puts "__root__ on #{__path__} is getting changed from object_id #{__root__.object_id} to #{root.object_id}!\nStacktrace: #{caller.join("\n")}"
    end
    super
  end
end

# Stick our logger modules in where we want them
puts "a.default['key1'].__root__.extend(ResetCacheLogger)"
a.default['key1'].__root__.extend(ResetCacheLogger)
puts "a.default['key1']['key2'].extend(RootChangeLogger)"
a.default['key1']['key2'].extend(RootChangeLogger)

puts "\nWe look up a merged value to make the 'key1' subtree merge get cached..."
puts "Notice that this invokes our logger for the __root__ StateTracking variable getting changed on a.default['key1']['key2'] -- that seems weird"
puts "a['key1']"
puts
a['key1']

puts "\nNow we will use a.default['key1']['key2'].tap to add some default values. Note: This is going to reset the __root__ on a.default['key1']['key2']"
puts "to the proper value since the [] method on StateTracking sets __root__ appropriately as you navigate down the tree"
puts "a.default['key1']['key2'].tap do |key2|"
puts

a.default['key1']['key2'].tap do |key2|
    puts "\nLet's invalid the merge cache by setting a default value..."
    puts "key2['foo'] = 'bar'"
    puts
    key2['foo'] = 'bar'

    puts "\nGreat, now let's look up the value we just set using the merged attributes.  This will result in the"
    puts "'key1' subtree merge result getting cached again, but it will also mutate the __root__ StateTracking variable... this seems bad."
    puts "on a.default['key1']['key2']"
    puts
    puts "\nWe expect a['key1']['key2']['foo'] to return bar. Actual result: #{a['key1']['key2']['foo']}"

    puts "\nWe will now set a default again, and we expect it to result in a call to cache_reset, but it doesn't"
    puts "The reason is that __root__ got redefined when we did the attribute merge above.  In fact, cache_reset is getting"
    puts "called, but on some random VividMash instance that gets created during the merge"
    puts "key2['foo'] = 'bar2'"
    key2['foo'] = 'bar2'

    puts "\nNow when we look up the default value we just set using the merged attributes, we get the wrong result"
    puts "since the previously cached merge was never cleared"
    puts "\nWe expect a['key1']['key2']['foo'] to return bar2. Actual result: #{a['key1']['key2']['foo']}"
end

The easiest thing to do is to copy the above script into the bin folder of your chef checkout and call it attribute-bug.rb.  You then run it and it prints the relevant code it is executing and explains what exactly is going wrong:
cd bin
# Create attribute-bug.rb with the contents above
bundle exec attribute-bug.rb | less

bit simpler repro case:
% cat test.rb
#!/usr/bin/env chef-apply

node.default['key1']['key2']['key3'] = true
node.env_default['key1']['key2']['key4'] = false

node.default['key1']['key2'].tap do |key2|
  key2['foo'] = 'bar'
  pp node['key1']['key2']['foo']
  key2['foo'] = 'bar2'
  pp node['key1']['key2']['foo']
  raise "boom" unless node['key1']['key2']['foo'] == "bar2"
end

i vaguely recall deliberately breaking this use case to make something else work.

https://github.com/chef/chef/pull/6362 contains the first bad commit.

prior notes and ramblings to myself on this kind of thing:  #5378

I'm seeing the same object_id be set on every call to update __root__=(node) i don't think that's the problem, i suspect its with the __path__

In the replication script I posted, the RootChangeLogger only generates log output if the value of __root__ is getting changed.  Here's a part of the output I see when I run it:
=== RootChangeLogger ===
__root__ on ["key2"] is getting changed from object_id<PHONE_NUMBER>5500 to<PHONE_NUMBER>2320!
Stacktrace: /home/jswett/src/chef/lib/chef/node/mixin/state_tracking.rb:87:in `copy_state_to'
/home/jswett/src/chef/lib/chef/node/mixin/state_tracking.rb:41:in `[]'
/home/jswett/src/chef/lib/chef/node/attribute.rb:582:in `block in deep_merge!'
/home/jswett/src/chef/lib/chef/node/attribute.rb:579:in `each'
/home/jswett/src/chef/lib/chef/node/attribute.rb:579:in `deep_merge!'
/home/jswett/src/chef/lib/chef/node/attribute.rb:549:in `block in merge_defaults'
/home/jswett/src/chef/lib/chef/node/attribute.rb:547:in `each'
/home/jswett/src/chef/lib/chef/node/attribute.rb:547:in `inject'
/home/jswett/src/chef/lib/chef/node/attribute.rb:547:in `merge_defaults'
/home/jswett/src/chef/lib/chef/node/attribute.rb:528:in `merge_all'
/home/jswett/src/chef/lib/chef/node/attribute.rb:402:in `merged_attributes'
/home/jswett/src/chef/lib/chef/node/mixin/deep_merge_cache.rb:54:in `[]'
/home/jswett/src/chef/lib/chef/node/mixin/state_tracking.rb:38:in `[]'
./attribute-bug.rb:101:in `block in <main>'
./attribute-bug.rb:91:in `tap'
./attribute-bug.rb:91:in `<main>'

Ah yeah, now I see it, one different number in a list of like 40 that both look very similar...

validated that the root is being updated there and on that node object, which does in fact smell like something that should never ever happen...
i don't think this is the case i was thinking it was -- which was more related to taking a node object and inserting it into the tree in other locations (the shape there is slightly different since you'd be doing node.default['key1']['key3'] = key3 inside the tap which gets crazy fairly quickly)

I really wonder why I created that VividMash and then immutablize'd it later rather than just creating an ImmutableMash.

yeah, we wind up passing a vividmash to a vividmash constructor which correctly shortcircuits doing all the work in convert_value() but that winds up with the original object being attached to the merged vivid_mash chain and its root is modified.
building with an immutablemash only bypasses convert_value when given another immutablemash.
so switching that around fixes the problem...
and it passes all the tests....
but why the hell did i write it that way in the first place?

(thanks for the bug, now you know how the sausage is made...)

Thanks for fixing the bug!  Yah, this was a fun one to investigate.


EdgeRouter will not probe for router connection, if connection to router was closed

Implement support for this, by spawning a probe thread when encountering a close of WS to Router

Implemented, issue closed


KDE/Plasma: support spellchecking

Issue description
Currently we build sonnet with support for hunspell.
https://github.com/NixOS/nixpkgs/blob/a821be7a0646adbb5c14dc94b0ace74992cad8f6/pkgs/development/libraries/kde-frameworks/sonnet.nix
Sonnet typically looks in /usr/share/hunspell for dictionaries
https://cgit.kde.org/sonnet.git/tree/src/plugins/hunspell/hunspelldict.h?id=6db26d1fcdc986c8341b13622d8eecae70a23bfd
That means it won't be able to find any dictionaries and thus spellchecking won't work.

Is this still a thing? @ttuegel

Yes, this is still a problem. It seems like we should disable hunspell and use aspell, which is configured correctly in NixOS.

I marked this with "good first bug" because I think we need only to change sonnet to depend on aspell, and do some testing.


wrong type of Lua.workspace.library in JSON schema

How are you using the lua-language-server?
NeoVim
Which OS are you using?
MacOS
What is the issue affecting?
Other
Expected Behaviour
the key Lua.workspace.library expects an array of strings, however, coc-json complains that it is expecting an object. (Since the JSON schema is provided on this repo, I assume the bug is caused by this LSP server and not coc-json.)
Actual Behaviour

Reproduction steps
Open the coc-settings.json file and add the text seen above.
Additional Notes
No response
Log File
No response

The schema that is listed in the wiki and is found in the VS Code extension appears to be correct.
Can you confirm that this is the schema you are using? Can you share the schema file you are using?

Where is the schema I am using stored so I can take a look? (I simply installed coc-json without doing any sort of changes to the default
config, if that's what you are asking?)

I don't use NeoVim or coc-json, but it looks like your schemas can be customized. Alternatively, add the schema to your configuration file manually:
{
    "$schema": "https://raw.githubusercontent.com/sumneko/vscode-lua/master/setting/schema.json"
}

hmm, indeed this works. But it is something that should work out of the box. 🤔

ah, just checked – the problem does not occur when using the same language server in Sublime Text, so it is likely related to coc-json after all.


npm coverage task is broken

First I get an error for missing folder: .nyc_output
I add that, now I get the following errors:
 npm run coverage

><EMAIL_ADDRESS>coverage /Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
> nyc report --reporter=text-lcov | coveralls

[error] "2018-11-18T15:44:58.791Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2018-11-18T15:44:58.794Z"  'input: ' ''
[error] "2018-11-18T15:44:58.794Z"  'error from convertLcovToCoveralls'

/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Failed to parse string
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>coverage: `nyc report --reporter=text-lcov | coveralls`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>coverage script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/georgecook/.npm/_logs/2018-11-18T15_44_58_805Z-debug.log```

log content:

```0 info it worked if it ends with ok
1 verbose cli [ '/Users/georgecook/.nvm/versions/node/v9.9.0/bin/node',
1 verbose cli   '/Users/georgecook/.nvm/versions/node/v9.9.0/bin/npm',
1 verbose cli   'run',
1 verbose cli   'coverage' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'precoverage', 'coverage', 'postcoverage' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter/node_modules/.bin:/Users/georgecook/.nvm/versions/node/v9.9.0/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/Wireshark.app/Contents/MacOS:/Applications/Xamarin Workbooks.app/Contents/SharedSupport/path-bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'nyc report --reporter=text-lcov | coveralls' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec coverage script
13 verbose stack Error<EMAIL_ADDRESS>coverage: `nyc report --reporter=text-lcov | coveralls`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:304:16)
13 verbose stack     at EventEmitter.emit (events.js:180:13)
13 verbose stack     at ChildProcess.<anonymous> (/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:180:13)
13 verbose stack     at maybeClose (internal/child_process.js:936:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
16 verbose Darwin 17.5.0
17 verbose argv "/Users/georgecook/.nvm/versions/node/v9.9.0/bin/node" "/Users/georgecook/.nvm/versions/node/v9.9.0/bin/npm" "run" "coverage"
18 verbose node v9.9.0
19 verbose npm  v6.1.0
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>coverage: `nyc report --reporter=text-lcov | coveralls`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>coverage script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]```

What npm and nodejs versions are you running?
On Sun, Nov 18, 2018, 10:45 George Cook<EMAIL_ADDRESS>wrote:

First I get an error for missing folder: .nyc_output
I add that, now I get the following errors:
npm run coverage

<EMAIL_ADDRESS>coverage /Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
nyc report --reporter=text-lcov | coveralls

[error] "2018-11-18T15:44:58.791Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2018-11-18T15:44:58.794Z"  'input: ' ''
[error] "2018-11-18T15:44:58.794Z"  'error from convertLcovToCoveralls'
/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter/node_modules/coveralls/bin/coveralls.js:18
throw err;
^
Failed to parse string
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>coverage: nyc report --reporter=text-lcov | coveralls
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>coverage script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      /Users/georgecook/.npm/_logs/2018-11-18T15_44_58_805Z-debug.log```
log content:
1 verbose cli [ '/Users/georgecook/.nvm/versions/node/v9.9.0/bin/node',
1 verbose cli   '/Users/georgecook/.nvm/versions/node/v9.9.0/bin/npm',
1 verbose cli   'run',
1 verbose cli   'coverage' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'precoverage', 'coverage', 'postcoverage' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter/node_modules/.bin:/Users/georgecook/.nvm/versions/node/v9.9.0/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/Wireshark.app/Contents/MacOS:/Applications/Xamarin Workbooks.app/Contents/SharedSupport/path-bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'nyc report --reporter=text-lcov | coveralls' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec coverage script
13 verbose stack Error<EMAIL_ADDRESS>coverage: `nyc report --reporter=text-lcov | coveralls`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:304:16)
13 verbose stack     at EventEmitter.emit (events.js:180:13)
13 verbose stack     at ChildProcess.<anonymous> (/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:180:13)
13 verbose stack     at maybeClose (internal/child_process.js:936:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
16 verbose Darwin 17.5.0
17 verbose argv "/Users/georgecook/.nvm/versions/node/v9.9.0/bin/node" "/Users/georgecook/.nvm/versions/node/v9.9.0/bin/npm" "run" "coverage"
18 verbose node v9.9.0
19 verbose npm  v6.1.0
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>coverage: `nyc report --reporter=text-lcov | coveralls`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>coverage script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]```

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/TwitchBronBron/brightscript-formatter/issues/15>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACbTbc8uQiFvgynMtEVfDsRhA7ySfw2dks5uwYCPgaJpZM4Yn_9o>
.

npm -v
6.1.0
Mac-mini:brightscript-formatter georgecook$ node -v
v9.9.0
On November 18, 2018 at 12:46:29 PM, Bronley Plumb<EMAIL_ADDRESS>wrote:
What npm and nodejs versions are you running?
On Sun, Nov 18, 2018, 10:45 George Cook<EMAIL_ADDRESS>wrote:

First I get an error for missing folder: .nyc_output
I add that, now I get the following errors:
npm run coverage

<EMAIL_ADDRESS>coverage
/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
nyc report --reporter=text-lcov | coveralls

[error] "2018-11-18T15:44:58.791Z" 'error from lcovParse: ' 'Failed to
parse string'
[error] "2018-11-18T15:44:58.794Z" 'input: ' ''
[error] "2018-11-18T15:44:58.794Z" 'error from convertLcovToCoveralls'

/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter/node_modules/coveralls/bin/coveralls.js:18

throw err;
^
Failed to parse string
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>coverage: nyc report --reporter=text-lcov | coveralls
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>coverage script.
npm ERR! This is probably not a problem with npm. There is likely
additional logging output above.
npm ERR!
/Users/georgecook/.npm/_logs/2018-11-18T15_44_58_805Z-debug.log```
log content:
1 verbose cli [ '/Users/georgecook/.nvm/versions/node/v9.9.0/bin/node',
1 verbose cli '/Users/georgecook/.nvm/versions/node/v9.9.0/bin/npm',
1 verbose cli 'run',
1 verbose cli 'coverage' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'precoverage', 'coverage', 'postcoverage' ]
5 info lifecycle<EMAIL_ADDRESS>

<EMAIL_ADDRESS>
6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in
lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH:
/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter/node_modules/.bin:/Users/georgecook/.nvm/versions/node/v9.9.0/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/Wireshark.app/Contents/MacOS:/Applications/Xamarin
Workbooks.app/Contents/SharedSupport/path-bin
9 verbose lifecycle<EMAIL_ADDRESS>CWD:
/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c',
'nyc report --reporter=text-lcov | coveralls' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code:
1 signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec
coverage script
13 verbose stack Error<EMAIL_ADDRESS>coverage: nyc report --reporter=text-lcov | coveralls
13 verbose stack Exit status 1
13 verbose stack at EventEmitter.
(/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:304:16)
13 verbose stack at EventEmitter.emit (events.js:180:13)
13 verbose stack at ChildProcess.
(/Users/georgecook/.nvm/versions/node/v9.9.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack at ChildProcess.emit (events.js:180:13)
13 verbose stack at maybeClose (internal/child_process.js:936:16)
13 verbose stack at Process.ChildProcess._handle.onexit
(internal/child_process.js:220:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd
/Users/georgecook/Documents/h7ci/hope/vscode/brightscript-formatter
16 verbose Darwin 17.5.0
17 verbose argv "/Users/georgecook/.nvm/versions/node/v9.9.0/bin/node"
"/Users/georgecook/.nvm/versions/node/v9.9.0/bin/npm" "run" "coverage"
18 verbose node v9.9.0
19 verbose npm v6.1.0
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>coverage: nyc report --reporter=text-lcov | coveralls
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>coverage script.
23 error This is probably not a problem with npm. There is likely
additional logging output above.
24 verbose exit [ 1, true ]```
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/brightscript-formatter/issues/15, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/ACbTbc8uQiFvgynMtEVfDsRhA7ySfw2dks5uwYCPgaJpZM4Yn_9o
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/brightscript-formatter/issues/15#issuecomment-439711420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUexxNsYAQ1YMRTKjrOz53Cml-4QRks5uwZz1gaJpZM4Yn_9o
.

Well the good news is that I'm getting the error too. I wonder what happened. Weird. I'll look into it.

I'm not actually worried about this task right now, because I don't think you need to run the coverage task directly. That task is only run by TravisCI. You can simply run npm run test, and it will auto-generate the coverage statistics and line coverage data and output the results to the coverage folder. You can then open the coverage/index.html file to see what lines aren't getting covered.
Once you hit 100% locally, and you push to github, TravisCI will rebuild, and hopefully npm run coverage will pass. Give that a shot and we will see how it goes (fingerscrossed)

removed the skip, on your existing test. 100% code coverage achieved.
On November 18, 2018 at 3:58:35 PM, Bronley Plumb<EMAIL_ADDRESS>wrote:
I'm not actually worried about this task right now, because I don't think
you need to run the coverage task directly. That task is only run by
TravisCI. You can simply run npm run test, and it will auto-generate the
coverage statistics and line coverage data and output the results to the
coverage folder. You can then open the coverage/index.html file to see what
lines aren't getting covered.
Once you hit 100% locally, and you push to github, TravisCI will rebuild,
and hopefully npm run coverage will pass. Give that a shot and we will see
how it goes (fingerscrossed)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/brightscript-formatter/issues/15#issuecomment-439725279,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUWEoaYKY33KL6tuWFuO1qj1j8M3kks5uwcn7gaJpZM4Yn_9o
.

Did you push new code to the PR? I looked and still only see a few lines changed in the one file.

closing due to inactivity (and because it's probably not a problem anymore).


Gene assignment scoring should be weighted at tissue/feature level, instead of source level

This will give us much more flexibility when doing therapeutic-area specific scoring.

Closed until we have a plan for how tissues will be used

is this still relevant @d0choa or should we drop it?


Add a ChangeLog

A ChangeLog would help both the spec developers and the implementers to track spec modifications between releases without the need to resort to reading git logs.

Are the summaries in the released tags sufficient, or should we make a changelog file containing them too?

Are the summaries in the released tags sufficient, or should we make a changelog file containing them too?

Good point. Summaries in released tags are not visible outside the GitHub (I mean they don't come with the source), so I would prefer having them in a changelog file too.

Changelog is already present in the source (:partying_face:), closing the issue.


Unable to do "nodes" validation on RichText type

Expected Behavior
Copying example 22 rich text should run a migration successfully

Actual Behavior
Throws errors
errors: [
    {
      type: 'InvalidPayload',
      message: `A field can't have "nodes" as a validation.`
    },
    {
      type: 'InvalidPayload',
      message: `A field can't have "embedded-asset-block" as a validation.`
    }
  ]

Possible Solution
Extending fields validations to include "nodes" validation when type is 'RichText'
https://github.com/contentful/contentful-migration/blob/0203edf5267b07450ae0cb73e37660d5c456185f/src/lib/offline-api/validator/schema/field-validations-schema.ts

Steps to Reproduce
Run example 22 from the examples folder
Context
I have created a post on the community as well.
https://www.contentfulcommunity.com/t/rich-text-validation-using-nodes/3561

I have found that the nodes validator doesn't allow

embedded-asset-block
asset-hyperlink
hyperlink

Not sure if this is intentional due to them maybe not be being part of the query complexity validation for the Graphql API or if it is just a bug.

Made a PR
https://github.com/contentful/contentful-migration/pull/254

:tada: This issue has been resolved in version 1.0.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support zooming to imagery's highest zoom

Essentially this extends the max zoom on a case by case basis
when an individual imagery layer is selected through the results pane.
Fixes #200.
I had planned to also limit the panning (so the imagery can't leave the
viewport), however the default behaviour of selecting imagery doesn't
focus the map, so there's no consistent entry point for applying new
panning limits. It could be done alongside the zoom-to-fit button
behaviour, but then there is an inconsistency in panning behaviour,
which we be more confusing than helpful. So as it stands this commit
does leave a small UX problem in that you can zoom to a level where the
main map layer disappears, but only when individual imagery is selected.
As soon as imagery is deselected the default max zoom (18) is reset and
you are zoomed back out to the default max zoom if you were browsing
imagery at a higher zoom level.
Notes:

Imagery's metadata does not contain the max tile zoom. It needs to be
fetched separately through the tileJSON manifest, this is somewhat
hacky and requires a blocking XHR request. We should look to
include at least the maxZoom level from imagery's tileJSON, or
perhaps even include the tileJSON by default in the
oin-meta-generator process.
Mapbox.js version is missing setMaxZoom(), consider upgrading.
The custom DS zoom controls are listening to layeradd which gets
triggered around 150 times per map movement.
Commit also contains formatting updates, mainly line length.

If this gets merged then we should open an issue on hotosm/oin-meta-generator to include tileJSON data.

👍 from me. I tested and I don't see a huge UX issue without the panning limits. There isn't a strong reason to keep panning outside of the visible image area when there is nothing on the map. The reset of the zoom when exiting the image view is handled nicely.


fix wrong calls filter because sessionId is same when call self

When use call self, the session id is same.
It will not influence ringout calls. Because the two legs of ringout calls's session id is different.

Coverage remained the same at 40.456% when pulling 330f339558ada71dddb2c015b64c4f8641bbf34c on embbnux:bugfix/active-calls into 856fc15db0d06ebff8c9ea90837c1471d3947951 on ringcentral:master.

Coverage remained the same at 40.456% when pulling 330f339558ada71dddb2c015b64c4f8641bbf34c on embbnux:bugfix/active-calls into 856fc15db0d06ebff8c9ea90837c1471d3947951 on ringcentral:master.

Please modify CallLogger to filter out the self-calling calls when processing for logs

Coverage decreased (-0.07%) to 40.385% when pulling 5656587d36d1f50f21862506e62deb0199aac301 on embbnux:bugfix/active-calls into 856fc15db0d06ebff8c9ea90837c1471d3947951 on ringcentral:master.


Add University

https://aimsammi.org/about-ammi-2/

@nii4u aimsammi.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.


Fixing the same typos in the source files.

I forgot to fix the Javadoc SearchResults.class typos in the source files. The Javadoc typos will appear again once it is generated the next time.

SearchResults.class typo fix:
https://github.com/thelinmichael/spotify-web-api-java/pull/186


Add support of parsing ON CLUSTER in ALTER TABLE for ClickHouse

ClickHouse dialect supports ON CLUSTER clause for ALTER TABLE:
ALTER TABLE table_name ON CLUSTER cluster_name ADD COLUMN c UInt32

Please refer to: https://clickhouse.com/docs/en/sql-reference/statements/alter

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

17 of 30 (56.67%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 89.17%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser/mod.rs
12
13
92.31%

src/ast/mod.rs
3
5
60.0%

tests/sqlparser_clickhouse.rs
0
10
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/ast/mod.rs
1
81.38%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
26865

Relevant Lines:
30128

💛  - Coveralls

The CI lint error would be fixed after PR #1352 or #1353 was merged

For the CI errors, they are not caused by the changes in this pr. https://github.com/sqlparser-rs/sqlparser-rs/pull/1357


Only scroll to selected convo if the filter is focused

Fixes the inbox scrolling way down if you click +123 more and have a big team channel selected. r? @keybase/react-hackers

Jenkins failing on unrelated storyshots (master too)


Input ports wrongly displayed on higher order functions

The IDE should not display input ports for functions passed as argument to another function.

When I pass a function to a higher-order function like map, the input ports for the arguments of that passed function are displayed on the node. That is invalid.

All the grey input ports displayed here are wrong - these are arguments to the functions that are passed as argument to map, they cannot be applied here.
They can confuse the user suggesting that they can create connections to these ports. But if the user tries to create the connection, they'll get:

That is because connecting to these nodes creates code like:
var3.map Aggregate_Column.Group_By "X"
var2.map var4.get 0

which is NOT
var3.map (Aggregate_Column.Group_By "X")
var2.map (var4.get 0)

BUT
(var3.map Aggregate_Column.Group_By) "X"
(var2.map var4.get) 0

Closing as duplicate of #6776


Unable to write timestamps to Timestream measure columns

Describe the bug
The Timestream documentation says:

TIMESTAMP datatype for measures – You can use the TIMESTAMP data type to store data from the past, present, or future. A multi-measure record can have multiple attributes of TIMESTAMP data type, in addition to the time field in a record. TIMESTAMP attributes, in a multi-measure record, can have timestamps in the future or the past and behave like the time field except that Timestream does not index on the values of type TIMESTAMP in a multi-measure record.
Note

The TIMESTAMP datatype is supported only for multi-measure records.

But when I try to write timestamps with awswrangler, when passing multiple measure columns, I get errors saying that type is not supported.
How to Reproduce
import datetime as dt
from datetime import datetime
import awswrangler as wr
import pandas as pd
import boto3
db_name = 'mwe'
table_name = 'test_tz_a'
tags = {
    'person': 'matt',
    'delete after': 'Dec 2022'
}
w_client = boto3.client('timestream-write')
# create database
try:
    wr.timestream.create_database(
        database=db_name,
        tags=tags
    )
except w_client.exceptions.ConflictException:
    # database already exists
    pass
try:
    wr.timestream.create_table(
        database=db_name,
        table=table_name,
        memory_retention_hours=5,
        magnetic_retention_days=1,
        tags=tags)
except w_client.exceptions.ConflictException:
    # database already exists
    pass
# same as the awswrangler documentation
df = pd.DataFrame(
    {
        "time": [datetime.now()]*3,
        "dim0": ["foo", "boo", "bar"],
        "dim1": [1, 2, 3],
        "measure": [1.0, 1.1, 1.2],
    }
)
rejected_records = wr.timestream.write(
    df=df,
    database=db_name,
    table=table_name,
    time_col="time",
    measure_col="measure",
    dimensions_cols=["dim0", "dim1"],
)
assert len(rejected_records) == 0
# timezone aware index time
df = pd.DataFrame(
    {
        "time": [datetime.now(dt.timezone.utc)]*3,
        "dim0": ["foo", "boo", "bar"],
        "dim1": [1, 2, 3],
        "measure": [1.0, 1.1, 1.2],
    }
)
rejected_records = wr.timestream.write(
    df=df,
    database=db_name,
    table=table_name,
    time_col="time",
    measure_col="measure",
    dimensions_cols=["dim0", "dim1"],
)
assert len(rejected_records) == 0
# Same as awswrangler docs,
# but adding timezone unaware timestamp to measure column
df = pd.DataFrame(
    {
        "time": [datetime.now()]*3,
        "dim0": ["foo", "boo", "bar"],
        "dim1": [1, 2, 3],
        "measure_f": [1.1, 1.2, 1.3],
        "measure_t": [datetime.now()]*3,
    }
)
rejected_records = wr.timestream.write(
    df=df,
    database=db_name,
    table=table_name,
    time_col="time",
    measure_col=["measure_f", "measure_t"],
    dimensions_cols=["dim0", "dim1"],
)
assert len(rejected_records) == 0
# Same as awswrangler docs,
# but adding timezone aware timestamp to measure column
df = pd.DataFrame(
    {
        "time": [datetime.now()]*3,
        "dim0": ["foo", "boo", "bar"],
        "dim1": [1, 2, 3],
        "measure_f": [1.1, 1.2, 1.3],
        "measure_t": [datetime.now(dt.timezone.utc)]*3,
    }
)
rejected_records = wr.timestream.write(
    df=df,
    database=db_name,
    table=table_name,
    time_col="time",
    measure_col=["measure_f", "measure_t"],
    dimensions_cols=["dim0", "dim1"],
)
assert len(rejected_records) == 0

Expected behavior
The script should pass.
Actual behavior
I get errors with the last 2 writes.

UnsupportedType: Unsupported Amazon Timestream measure type: timestamp[ns]

and

UnsupportedType: Unsupported Amazon Timestream measure type: timestamp[ns, tz=UTC]

Your project
No response
Screenshots
No response
OS
Amazon Linux 2
Python version
3.10.1
AWS SDK for pandas version
2.15.1
Additional context
I actually don't understand why the example in the docs for writing to timestream works. I would expect it to fail because awswrangler is being asked to convert a timezone unaware datetime (datetime.now()) to unix epoch time. But that's a separate issue. The behavior I mention in this ticket is the same regardless of whether the measure is timezone aware or unaware.

Data types are inferred from the pandas data frame type via pyarrow. Above PR should introduce a fix.


Getting around 5mb storage limitation

Right now we're limited to 5mb of storage on Firefox without doing any file i/o. We're not coming particularly close to using all of that, but it could impair someone who wants a lot of keys/be necessary for pfs ( #7 ). This ticket is both to track the issue as well as to allow us to figure out if there is anyway to do this without having to do file i/o.

This issue was moved to GrdMe/GrdMe#44

This issue was moved to GrdMe/GrdMe#44


Project name
CasperSwap
URL to be whitelisted
*://testnet.casperswap.xyz/*;*://testnet.casperswap.com/*;*://app.casperswap.xyz/*;*://app.casperswap.com/*;*://dao.casperswap.xyz/*;*://dao.casperswap.com/*
Code audit/review URL if available
https://certificate.quantstamp.com/full/rengo-labs
Project description
UniswapV2 based defi project using Curve Finance based tokenomics.
Project's phase
Testing
Who is the project owner?
Company
Project owner's name
Abyss
What kind of Web3 functionality will you be offering in your product?
LP staking, swaps, gauge staking, vote staking, voting
Contact details
<EMAIL_ADDRESS>Link to the code
https://github.com/orgs/CasperSwap/repositories
Is this a project by an enterprise partner of Casper Association or CasperLabs?
Yes
Grant/proposal number if this is a project funded by the DEVxDAO
153

In progress. ETA - ~ Monday EOD CET.


test: fix warning in test-tcp-open

```test/test-tcp-open.c: In function ‘timer_cb’:
test/test-tcp-open.c:179:34: warning: passing argument 2 of ‘uv_shutdown’ from incompatible pointer type
   r = uv_shutdown(&shutdown_req, &client, shutdown_cb);
                                  ^
In file included from test/test-tcp-open.c:22:0:
./include/uv.h:398:15: note: expected ‘struct uv_stream_t *’ but argument is of type ‘struct uv_tcp_t *’
 UV_EXTERN int uv_shutdown(uv_shutdown_t* req,

Landed in https://github.com/libuv/libuv/commit/589736303fe47a488bd1f79487f3ab8201088d2b. Thanks!