smp: irq_csection: enable irq to process the pending pause request

Summary
It's found in a complicated task-exiting/rescheduling scenario, two CPUs are deadlocked.
Use JTAG to dump the backtrace of the two CPUs to see what happened.
CPU0‘s backtrace shows it's waiting CPU1 to pause:
(gdb) bt
#0  spin_lock (lock=lock@entry=0x40ed66cd <g_cpu_paused+1> "\001") at semaphore/spinlock.c:74
#1  0x40017bb0 in up_cpu_pause (cpu=cpu@entry=1) at armv7-a/arm_cpupause.c:280
#2  0x40066714 in nxsched_add_readytorun (btcb=btcb@entry=0x418b9b50) at sched/sched_addreadytorun.c:260
#3  0x400686f0 in nxsem_post (sem=sem@entry=0x42a905bc) at semaphore/sem_post.c:174
#4  0x40065e58 in pthread_sem_give (sem=sem@entry=0x42a905bc) at pthread/pthread_initialize.c:108
#5  0x4006603c in pthread_notifywaiters (pjoin=0x42a905b0) at pthread/pthread_completejoin.c:76
#6  pthread_completejoin (pid=<optimized out>, exit_value=exit_value@entry=0x0) at pthread/pthread_completejoin.c:224
#7  0x401c6f40 in nx_pthread_exit (exit_value=exit_value@entry=0x0) at pthread/pthread_exit.c:82
#8  0x40093b7c in pthread_exit (exit_value=0x0) at pthread/pthread_exit.c:71
#9  0x40093acc in pthread_startup (entry=<optimized out>, arg=<optimized out>) at pthread/pthread_create.c:59
#10 0x401c6be4 in pthread_start () at pthread/pthread_create.c:139
#11 0x00000000 in ?? ()

And the backtrace shows that CPU1 is in enter_critical_section() and has percepted it is asked to pause:
(gdb) bt
#0  enter_critical_section () at irq/irq_csection.c:320
#1  0x40067b98 in nxsem_wait (sem=0x418a7a00) at semaphore/sem_wait.c:88
#2  sem_wait (sem=sem@entry=0x418a7a00) at semaphore/sem_wait.c:303
#3  0x4009315c in nxmutex_lock (mutex=mutex@entry=0x418a7a00) at misc/lib_mutex.c:203
#4  0x400a37b4 in mm_lock (heap=heap@entry=0x418a7a00) at mm_heap/mm_lock.c:96
#5  0x400a3b58 in mm_free (heap=0x418a7a00, mem=0x43680000) at mm_heap/mm_free.c:96
#6  0x400a1764 in free (mem=<optimized out>) at umm_heap/umm_free.c:49

So it's repeatly looping, trying to ack the pause request, a SGI interrupt.
But for some reason, the local interrupt on CPU1 is already disabled, so CPU1 will never ack the SGI interrupt.
This is why the two CPUs are deadlocked.
try_again:
  ret = up_irq_save();
...
...
  up_irq_restore(ret);
  goto try_again;

This fix will really enable local interrupt when doing the retry.
Impact
smp, enter_critical_section
Testing
Tested in an armv7a smp configuration.

@chirping78

But for some reason, the local interrupt on CPU1 is already disabled, so CPU1 will never ack the SGI interrupt.

Can you identify where the local interrupt on cpu1 was disabled when the deadlock happened?
Also, I’d like to know that what happens if the DEBUGASSERTION is enabled.

@chirping78

But for some reason, the local interrupt on CPU1 is already disabled, so CPU1 will never ack the SGI interrupt.

Can you identify where the local interrupt on cpu1 was disabled when the deadlock happened?
Also, I’d like to know that what happens if the DEBUGASSERTION is enabled.

Need get time and the board to  reproduce.
Will return here after I get the information.

Was closed by accident when syncing my repository. Restore it now.

@chirping78

But for some reason, the local interrupt on CPU1 is already disabled, so CPU1 will never ack the SGI interrupt.

Can you identify where the local interrupt on cpu1 was disabled when the deadlock happened?
Also, I’d like to know that what happens if the DEBUGASSERTION is enabled.

I got the board today, and can reproduce the issue w/o this PR change.
About "where the local interrupt on cpu1 was disabled", I can't find a proper way to find this answer. Could you sugguest a method, maybe gdb script or log? @masayuki2009
About DEBUGASSERTION, I found   CONFIG_DEBUG_ASSERTIONS is opened:
nuttx$ grep DEBUG_ .config|grep ASS
CONFIG_DEBUG_ASSERTIONS=y

but it does not print assert when this issue happend.

@chirping78 please rebase your change to the last master, ci break is fixed sometime ago.

@chirping78

I got the board today, and can reproduce the issue w/o this PR change.

Can you attach .config to this PR?

About "where the local interrupt on cpu1 was disabled", I can't find a proper way to find this answer. Could you sugguest a method, maybe gdb script or log? @masayuki2009

You need to modify up_irq_save() to find where the local interrupt was disabled last time.
Please note that up_irq_save() is called on both CPUs and is also called recursively.

I tried to print the cpu/pid of the task which has disabled IRQ with following changed up_irq_save.
Please note that:

the changed part is closed in #if 1 and #endif
can not use syslog / info, which will call up_irq_save recursively. So up_putc is used here
can not use up_interrupt_context / gettid. They call  up_irq_save recursively. So copy their logic here (the IRQ is disabled)

irqstate_t up_irq_save(void)
{
  unsigned int cpsr;
#if 1
  int cpu;
  pid_t tid;
  static pid_t printed_pid[2] = {0};
#endif

  __asm__ __volatile__
    (
      "\tmrs    %0, cpsr\n"
      "\tcpsid  i\n"
#if defined(CONFIG_ARMV7A_DECODEFIQ)
      "\tcpsid  f\n"
#endif
      : "=r" (cpsr)
      :
      : "memory"
    );

#if 1
  if (g_nx_initstate >= OSINIT_IDLELOOP && CURRENT_REGS == NULL)
  {
    cpu = up_cpu_index();

    struct tcb_s *rtcb = current_task(cpu);
    tid = rtcb->pid;

    if (!(cpsr & 0x80))
    {
      if (tid != printed_pid[cpu])
      {
        up_putc(cpu + '0');
        //up_putc(':');
        up_putc((tid / 10) + '0');
        up_putc((tid % 10) + '0');
        //up_putc(':');
        //up_putc('0');
        up_putc('\n');
        printed_pid[cpu] = tid;
      }
    }
  }
#endif

  return cpsr;

}

The bad news is, with the change this issue can not be reproduced, although the change has been limit to minimum range.
Any other suggestion? @masayuki2009

The bad news is, with the change this issue can not be reproduced, although the change has been limit to minimum range.

@chirping78
I think you should not use up_putc() because it's too slow. Instead, you should use trace buffers.

@masayuki2009
Since when the issue is reproduced, the system will hang and can't use trace dump command, so I made a homemade trace buffer to save up_irq_save / up_irq_restore call.
And after the issue is reproduced, I use jtag to dump the trace buffer.
Then I really find something in the trace: there are some directly up_irq_save / up_irq_restore call in the chip vendor code.
Since I can't post the vendor code here, I modified the smp tesing code to simulate the scenario.
https://github.com/chirping78/nuttx-apps/commit/c6dbb0aa0d43d16e636954518b1eb4d6a8f67804
You can try this modified smp testing on a smp board in case you have, to see whether it can reproduce?
You can see that the problem is caused by mixed using up_irq_save and enter_critical_section. Is this a permitted pattern?

if it is, then this PR is needed to fix up.
if it isn't, the this PR is not needed. We must use only enter_critical_section, instead of up_irq_save in smp case?

You can see that the problem is caused by mixed using up_irq_save and enter_critical_section. Is this a permitted pattern?

if it is, then this PR is needed to fix up.
if it isn't, the this PR is not needed. We must use only enter_critical_section, instead of up_irq_save in smp case?

Just adding some information on this topic:
I've found a similar issue with ESP32-S3 + SMP in a WIP development regarding a function that performs an SPI flash operation in esp32s3_phy_enable
Basically, this function will call (WIP) another function to read data from SPI flash. This operation requires disabling the non-IRAM interrupts on both cores in spiflash_start. This function posts to a semaphore to make a pinned-to-the-other-core task to make it run a busy loop while the operation takes place.  nxsem_post calls nxsched_add_readytorun which will pause the other CPU to set up the g_assignedtasks on the other core and add the task that performs the busy loop.
This operation causes a deadlock because of the critical section of esp32s3_phy_enable. The CPU pause will hang here: not because of the CPU pause operation (the other CPU was already resumed),  but because this enter_critical_section will keep looping in irq_waitlock because it can't acquire the spinlock (owned by esp32s3_phy_enable).
This situation is avoided by not entering a critical section in  esp32s3_phy_enable. Using spin_lock_irqsave(NULL) fixes the issue.
Please note that spin_lock_irqsave calls up_irq_save, so I'd say that calling it is not an issue to perform a CPU pause operation, the problem is performing this operation in a nested critical section (called by enter_critical_section).

This operation causes a deadlock because of the critical section of esp32s3_phy_enable. The CPU pause will hang here: not because of the CPU pause operation (the other CPU was already resumed), but because this enter_critical_section will keep looping in irq_waitlock because it can't acquire the spinlock (owned by esp32s3_phy_enable).

Do you handle up_cpu_pausereq in arch/chip specific code correctly?

This operation causes a deadlock because of the critical section of esp32s3_phy_enable. The CPU pause will hang here: not because of the CPU pause operation (the other CPU was already resumed), but because this enter_critical_section will keep looping in irq_waitlock because it can't acquire the spinlock (owned by esp32s3_phy_enable).

Do you handle up_cpu_pausereq in arch/chip specific code correctly?

up_cpu_pausereq is a common code of xtensa arch, which is the same as other archs. This is check in xtensa_pause_handler which is also similar/equal to other archs (arm_pause_handler, for instance: both are called inside an ISR)
I can't see any problems regarding handling. I'd say that the same situation will happen for any arch: the problem seems to be calling up_cpu_pause on a nested critical section.
Do you have any thoughts about it, @xiaoxiang781216 ?

Since I can't post the vendor code here, I modified the smp tesing code to simulate the scenario.
https://github.com/chirping78/nuttx-apps/commit/c6dbb0aa0d43d16e636954518b1eb4d6a8f67804
You can try this modified smp testing on a smp board in case you have, to see whether it can reproduce?

@chirping78
Could you tell us more about the target information? (CPU type and the number of cores and so on)

Could you tell us more about the target information? (CPU type and the number of CPUs and so on) I'd like to see the .config file.

The target is a dual core cortex A7.
About the .config, I take a glance on the file and found some sensitive information, like internal components and partner name. There maybe some discipline prevent me to post it here.

Also, please provide the following information

the toolchain you are using

The toolchain version is:
Target: arm-none-eabi
Configured with: /data/jenkins/workspace/GNU-toolchain/arm-11/src/gcc/configure --target=arm-none-eabi --prefix=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/install --with-gmp=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --with-mpfr=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --with-mpc=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --with-isl=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --disable-shared --disable-nls --disable-threads --disable-tls --enable-checking=release --enable-languages=c,c++,fortran --with-newlib --with-gnu-as --with-gnu-ld --with-sysroot=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/install/arm-none-eabi --with-multilib-list=aprofile,rmprofile --with-pkgversion='Arm GNU Toolchain 11.3.Rel1' --with-bugurl=https://bugs.linaro.org/
Thread model: single
Supported LTO compression algorithms: zlib
gcc version 11.3.1 20220712 (Arm GNU Toolchain 11.3.Rel1)

how long does it take to reproduce the deadlock with the modified smp app

Very soon, in seconds.

@chirping78

The target is a dual core cortex A7.

Since I do not have a dual Cortex-A7-based board, I tested the modified smp app with NXP sabre-6quad (quad Cortex-A9) with NCPUS=2. (I modified sabre-6quad:smp config file)

About the .config, I take a glance on the file and found some sensitive information, like internal components and partner name. There maybe some discipline prevent me to post it here.

Can you remove such sensitive information and post the .config file?

Very soon, in seconds.

Hmm, I've never reproduced the deadlock with the modified smp app on the board.
I repeated running the smp app more than 1000 times. (It took more than 5 hours)
Now, I've been testing the app on different CPUs such as esp32-devkitc but I still can not reproduce the deadlock.

Have asked the chip vendor to remove their wrong up_irq_save usage, so this PR change is not needed any more. Close it.


0.5 String compat

Thanks

Compat is not in REQUIRES? Doesnt seem to be loaded with using either. Also I thought the way to do it is to import Compat.String and just use that type, not with the Compat macro.


sift and adalam Configurations Lead to Missing scales1 and oris1 Keys

Encountering AssertionError: Missing key scales1 in data when using the following configurations:
feature_conf = extract_features.confs['sift']
matcher_conf = match_features.confs['adalam']
retrieval_conf = extract_features.confs['netvlad']

The dictionary for matching lacks the scales1 and oris1 keys. It seems the configuration does not align with the expected input structure.

Thanks it's all my own problem.


gpt-4-turbo-2024-04-09 tools agent error

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain.js documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain.js rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
import { PromptTemplate } from "@langchain/core/prompts";
import { AgentExecutor } from "langchain/agents";
import { ChatOpenAI } from "@langchain/openai";
import { SerpAPI } from "@langchain/community/tools/serpapi";
import { createOpenAIFunctionsAgent } from "langchain/agents";

const search = new SerpAPI();
const tools = [search];

const prompt =
  PromptTemplate.fromTemplate(`Turn the following user input into a search query for a search engine:

{input}`);

const llm = new ChatOpenAI({
  model: "gpt-4-turbo-2024-04-09",
  temperature: 0,
});

const agent = await createOpenAIFunctionsAgent({
  llm,
  tools,
  prompt,
});

const agentExecutor = new AgentExecutor({
  agent,
  tools,
});

const result = await agentExecutor.invoke({
  input: "Who is the current prime minister of Malaysia?",
});

console.log(result);

Error Message and Stack Trace (if applicable)
{
message: '{\n' +
'  "error": {\n' +
    "message": "Unknown parameter: 'messages[1].tool_calls[0].index'.",\n +
'    "type": "invalid_request_error",\n' +
'    "param": "messages[1].tool_calls[0].index",\n' +
'    "code": "unknown_parameter"\n' +
'  }\n' +
'}',
code: 400
}
Description
It should be the same error as this one. https://github.com/langchain-ai/langchain/issues/20264
System Info

"@langchain/core": "0.1.57"
"langchain": "0.1.33"

Thank you for reporting, following.

Thanks, will have a look!

Hi @jacoblee93 thank you for looking into it. It seems that it resolved itself after the changes in
@langchain/openai": "^0.0.28
Tested also with
@langchain/community": "0.0.48"

Upgrade @langchain/openai to 0.0.28 works fine, thanks.

I don't think we changed anything but glad it's working!

Hmm I'm actually not able to repro - did OpenAI maybe patch on their end?

Yes. I checked and it seems to have been patched on the OpenAI side.


MAINT: Harmonized documentation for Interpolator classes

Reference issue
https://github.com/scipy/scipy/issues/18165#issue-1629330543

What does this implement/fix?
In the documentation, I harmonized and clarified the dimensions of the inputs of *Interpolator objects. I chose the (npoints, ndims) convention. In addition, since the legacy class interp1d uses the last axis and other interpolators use the first axis by default, I emphasized the default value in the docstring.

Additional information
This is a modest change but I'm hoping to motivate more ambitious harmonization of the interpolation module.  In particular, naming the inputs points and values in all interpolators would make it easier for the user (see my original issue). In addition, some interpolators allow specifying the interpolation axis while others don't, which prevents the user from seamlessly interchanging one interpolator for another.
Best,
GJ

Thank you @gjhuizing and congartulations with what I believe is your first scipy commit. Keep them coming!

Thanks a lot for the review!


Software-Architecture Concept

Situation: We don't have a software architecture yet
Task: architecture should be conceptually designed with a diagram
Action:

Brainstorm
Create a architecture using raft
Create an architecture diagram

Result:

Full conceptual design
Diagram with the design
Open for changes

Created Meetup at 07/04 to discuss architecture


#coordinates for irregular axis storage is less than advertised

Reported by Ansley B Manke on 22 Jan 2004 17:29 UTC
We have maxlinestore = 250000, amount of storage for coordinates.
But the test (in cd_get_1_axis)  is
     IF ((next_line_mem_pos+2*npts).GT.maxlinestore) GOTO 5300

So, the actual limit on npts is < 125000
maxlinestore is in fmt/cmn/tmap_dims.parm
Set it to 501000 if we want to allow 250000 coordinates
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/767

Comment by<EMAIL_ADDRESS>on 20 Jan 2005 20:47 UTC
... and in fact,now that we are storing bounds rather than edges in general for
irrregular axes, the test should be
     IF ((next_line_mem_pos+3*npts).GT.maxlinestore) GOTO 5300

So, the limit of 250000 memory words lets us store ~83000 coordinates.

Comment by<EMAIL_ADDRESS>on 28 Oct 2005 18:27 UTC
Coordinate storage is 2*n+1 for irregular axes, storing coordinates, then
upper/lower bounds as a single list. The limit of 250000 memory words lets us
store ~83000 coordinates.

Modified by ansley.b.manke on 5 Jan 2011 22:10 UTC

Comment by ansley.b.manke on 15 Jun 2017 20:29 UTC
The storage total is currently 750K.  For coordinates read in from netCDF files we store 2*n+1 edges, whether the incoming file lists bounds, edges, or neither. The code correctly uses this to check.
For DEFINE AXIS, can we check first whether they're specifying 2N bounds? If not, then only require 2n+1 not 3n+1.  If 2N bounds is given and the storage is insufficient, the error message should note that converting the bounds to edges would gain some space.
The error messages might be more helpful if they reported the current available storage, though that might just be confusing - perhaps state a total number of coordinate locations total are allowed, i.e. 750/2 K, so they know the general scope.

Comment by ansley.b.manke on 20 Jun 2017 23:41 UTC
Ideas on a strategy: No longer allocate one giant array as is currently used for coordinate storage, but rather give each individual line that requires coordinate memory, gets it own individual allocation. (copying from an email, details may not be quite right...)
Currently all line memory references "isubsc1" as a pointer to the index of its start
line_mem(isubsc1(line))
All such references would need to be changed to (new)
linemen(line)%ptr
There is a variable in common that points to the beginning of free memory in line_mem, next_line_mem_pos. It is only used in a few places.  Those would need to be tracked down, and the place(s) where it is used to find memory for a new line would be replaced with the new dynamic linemen.

Comment by ansley.b.manke on 14 Sep 2017 22:50 UTC
The strategy in comment 3 is implemented.  Line and edge coordinate storage is allocated. Time and forecast aggregations needed a bit of rethinking but overall an easy change.
Documentation needs updating before this is publicly released.


Add app name validation APIs

Change summary:

Add app name validation APIs (ain_validateAppName, /validate_app_name)

Related issues:

https://github.com/ainblockchain/ain-blockchain/issues/986

Note that it was amended using isValidServiceName().

Let me merge it now. Thanks for the review. @liayoo


[beta-1.72] backport #12359

Beta backports:

https://github.com/rust-lang/cargo/pull/12359

In order to make CI pass, the following PRs are also cherry-picked:

Thanks!
@bors r+

:pushpin: Commit f9e1aeb1fb92815576abd263638a96bfaaf6b2ee has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit f9e1aeb1fb92815576abd263638a96bfaaf6b2ee with merge dd6536b8ed28f73c0e82089c72ef39a03bc634be...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing dd6536b8ed28f73c0e82089c72ef39a03bc634be to rust-1.72.0...


PDF with images are dameged and cannot be open be acrobat reader

On Android using Ti SDK 5.0.0.GA I am adding an image to a PDF. I am able to open the image using the Google PDF viewer but not Adobe Acrobat. I sent the message to my desktop and the same applies. I was able to view the image using "Preview" but not Adobe Acrobat. The error message says "The document cannot be opened because it is corrupted or damaged." If I remove the image from my PDF, the PDF will open in Acrobat. Odd right?

We have fixed in our fork:
https://github.com/AppWerft/TiJSPDF/pull/8/files#diff-0


(Duplicate) Black Screen in headset

Description
As of June 12, 2024 the "previous" workaround, for this problem is now borked. Steam has pushed the 2.6 update for steam vr, pushing 2.5.5 into the previous slot for now.
Environment
Operating System: EndeavourOS
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1
Kernel Version: 6.9.3-zen1-1-zen (64-bit)
Graphics Platform: X11
Processors: 16 × Intel® Core™ i7-10700K CPU @ 3.80GHz
Memory: 31.2 GiB of RAM
Graphics Processor: NVIDIA GeForce RTX 3060/PCIe/SSE2
additional hardware information is available here
https://linux-hardware.org/?probe=d9f4927a1a
Installation
ALVR Version:
20.8.1
ALVR Settings File:
SteamVR Version:
Install Type:

[  ] Packaged (exe, deb, rpm, etc)
[ X] Portable (zip)
[  ] Source

Closing as duplicate of #2190


Export doesn't display any status

Godot version
81c2d7a
System information
Windows 10 x64
Issue description
Exporting a project looks like this right now:

The export dialog simply freezes and then unfreezes when export finishes. No progress, no status. You don't even know if the export succeeded or anything has happened if you don't look into the output tab.
Steps to reproduce

Export project

Minimal reproduction project
No response

When exporting to android its even worse because the entire screen goes black while its exporting.

Seems fixed in c50febf


SMI TrafficSplits v1alpha2

Flagger as of today supports v1alpha1 only. Can we add v1alpha2 as well?
The latest spec can be found here: https://github.com/deislabs/smi-spec/blob/master/traffic-split.md
The only change between v1alpha1 and v1alpha2 is that weight is now int, where it was formerly string representing a quantity.
https://github.com/deislabs/smi-sdk-go/commit/70439895a7cfa724b59269892dad18dac082f17b

I would hold back on that until Linkerd switches to v1alpha2. Flagger uses integer weights anyway so this change is just a version bump.

Is it possible to make the SMI CRD versions used by Flagger configurable for service mesh implementations that use SMI and Flagger?

Closed in favour of https://github.com/weaveworks/flagger/issues/551


[Test] To test fork and pull req

To test fork and pull req

and this is your first rejection :)

so sad

Hey @ngzhekai, don't comment on a dead pull request, you'll be "educated" by others if you're in serious repos

lock the convo now


Improve ResponseError

Remove ResponseError model if it's never used.
Otherwise, we want to see once more if we can make the deserialization work with the Azure.Core type.
At minimums we want to manually modify this type so that we don't have the extra layer with one property inside it.

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.303913,Extensions:0.062036585,Cognitive Services:0.04985071'

Removed ErrorResponse in Azure.ResourceManager, but kept ErrorDetail and ErrorAdditionalInfo as they could be referenced by other models in some RPs.


"Eh it's just one ship, what's the worst they could do?"
What IS the worst you could do?
The Nesasio is a player ship built by the Frontier Stability Corporation with 11 cryo pods, 6 guns, two gun control rooms, a mini armory with c4, no windows at the piloting room, cameras in every room, a door control room, a cool shape, a short backstory, FOUR (MAYBE real???) NUKES, a place to drop said nukes when you're flying over a warzone, and personal bedrooms for the captain and HoS, (CE and CMO simply aren't important enough.)
A more up-to-date alternative to the kestrel and paper-plane, the FSC Nesasio-Class Stealth Bomber is built with the new guns system in mind for a more prolonged and hopefully more action-filled round.

what does that error even mean

try asking upstream, but this is an issue regarding your map file

IT IS LITERALLY THERE WHAT DO YOU MEAN "FILE NOT FOUND"

screw you too I'll figure this out when my brain is functioning at full capacity in like 8-10 hours

WHAT EVEN WENT WRONG THIS TIME???


MAINTAINERS: Add Bluetooth Audio section

Add a Bluetooth Audio section in the maintainers
file for the Bluetooth Audio (sub)subsystem.
The Bluetooth Audio stack is a significant size, and
there's a signficant amount of people working on it,
where many do not have proper review rights and
many that do not get automatically assigned
for reviews.
I've removed asbjornsabo from Bluetooth Host as he
is mostly involved with LE Audio and not the host.
I've included Vudentz as he has been very active in
the early days.
I've excluded szymon-czapracki as he has not yet
contributed a significant amount, even if he is
involved.
Signed-off-by: Emil Gydesen<EMAIL_ADDRESS>

ping @rymanluk


additional simple login security

Hello,
is it possible to block an IP for e.g. 1 hour after 3 unsuccessful logins? And after another 2 unsuccessful logins, to ban them forever? And with a corresponding note. (without cookies)
Is there anything like that? If so, how can I implement it?
If not, is there another login security solution? ( I don't like google-recaptcha!!! )
Note: I use the precompiled build
thank you

You can build a new custom Auth adapter or modify existing one and add those features, see this for more info: https://docs.filegator.io/configuration/auth.html


Dark UI - Toggle in v2.0

I would like to make a feature request for a Dark UI toggle.
I really like v2.0 the new UI design is great A+ man!

Hi, thanks for kind words. Recently I lost enthusiasm for this project, I need to sit down and release finally this 2.0 version :)


How to set column width

Hello @midzer , When i was seaching filter and QT, i found this repo, it is helpful to reference. Now i encountered a problem, i know this repo has been uploaded for 4 years, if you could give me some tips, that would be very nice, my problem is i want to resize the width of each column, so i add follwing code(for simplicity, i just set the first column) :

But neither method works...How to solve this problem ?
Thank you in advance !

Hi @wwdok thanks for your issue.
I'm not to familiar with Qt any more. But I found this at stackoverflow https://stackoverflow.com/questions/26681578/qtableview-column-width

Your reply is so quick, hahaha, i just make it Ok ! I just put those two lines of code after view->setHorizontalHeader(header); :

Sorry to bother you, Thank you again !

No worries, have a nice day!


Limit total telemetry events sent per session

What does this PR do?
Limit the total number of telemetry events sent per session
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.26%. Comparing base (a6f7ed2) to head (45c2ff7).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/2.10.0    #2061      +/-   ##
==================================================
- Coverage           83.47%   83.26%   -0.21%
==================================================
  Files                 494      494
  Lines               17735    17724      -11
  Branches             2686     2681       -5
==================================================
- Hits                14803    14757      -46
- Misses               2212     2235      +23
- Partials              720      732      +12

Files
Coverage Δ

...ndroid/telemetry/internal/TelemetryEventHandler.kt
81.35% <100.00%> (-1.90%)
:arrow_down:

... and 26 files with indirect coverage changes


Database to store posts

There probably needs to be a database where we can store the post itself and who wrote it.

I could TRY to set up a database myself. Don't know how fast it would be though.

sure


modal-filter annotations before meshing

Description
What is this PR

[ ] Bug fix
[x] Addition of a new feature
[ ] Other

Why is this PR needed?
Axolotl atlas script currently creates quite rough meshes, because the annotations have a few quite jagged regions.
What does this PR do?
Smoothes the meshes a bit, by keeping more vertices, closing more, and importantly, passing the meshing code a modal-filtered version of the annotations.
References
\
How has this PR been tested?
Local visual inspections of the resulting pallium, telencephalon and root meshes:

vs before

Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist:

[x] The code has been tested locally
[ \ ] Tests have been added to cover all new functionality (unit & integration)
[ \ ] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

Ah I see that marching cubes isn't used as the default so that's out! If this can't be replicated perhaps it's worth moving this out to mesh_utils.py for future reuse!

Thanks!
Yea, I guess so - not sure how good marching cubes is at smoothing very jagged annotations but didn't try. Playing with closing_n_iters or decimate_fraction had little effect.


Re-Add Voyager

Voyager now has API stability with the release of 1.0.0, now would be a great time to re-add it.

Voyager is back on release 0.0.9

Thanks!


Add quickCheck properties and unit tests.

Please add quickCheck properties and unit tests.
That would make me more confident to use this package.

See Pull Request #8. It only contains tests for IntMap, but the model used can be extended for testing the other implementations.


ERROR Could not pass event PlayerMoveEvent to Quests v3.9.3-b107

What is your Quests version / build number (do not say "latest")?
Ver 3.9.3
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
I think people are just walking around and generating this error
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
Not applicable but heres a error: https://pastebin.com/8RtteKWj

Nvm. After refreshing config and data. It now works without errors


Add support for ZIP load modelings

The power systems aspect of this issue is now open at https://github.com/NREL-SIIP/PowerSystems.jl/discussions/846

closed via #204


Add code file import feature for static-site-gen platform

Discussion on zulip
This PR adds a feature to static-site-gen so that you can replace the content of a code fence with a file. Include the relative file path in the code block, and the platform will replace the code with the contents of the file.
'''roc
codeExample.roc
'''

@Anton-4 Ok, so I've tried a few different things and this is the latest design. It still uses the code fence (more on why below) and now requires a file: prefix for importing a code file. This provides all the performance and security benefits at the cost of checking if the code block content starts with the prefix.
'''roc
file:codeExample.roc
'''

I removed the 255 character limit, I hadn't considered multiple subfolders. Added a check for any ../ strings in the file path and panics if any are present. Also checks the file before reading and panics if it does not exist.
I tried re-writing to use [filename.roc will be embedded here](path/filename.roc) but found it to be impractical to make the pulldown_cmark parser behave correctly. The issue here is that it detects a link start event, and not a code block. So to then produce highlighted html we would need to duplicate the highlighting code, which is already located in the code block event.
The other concern was that I didn't see a natural way to determine if the link was to a file, or a legitimate link to a URL resource. Which is the same issue we have with the code block. Hence there was no advantage with using this format, instead it complicates the implementation and uses a link where a code block is probably more relevant.
This is the reason why I prefer using the code block as we have been, but instead adding a prefix. I have used file: however there may be a better prefix that is more commonly used or more clearly conveys intent?

Super. I'll update the Examples repo tomorrow so they will work with the prefix.


GitHub bridge fails to sync closed PRs

I had an open PR#1 on my virtual test GitHub, which I then closed. After syncing the bridge, the PR is still marked as open on DataKit:
GitHub:
{("a",
  {("a",
    prs=[n=0;head=123;title="PR#0";open; n=1;head=789;title="PR#1";closed;
         n=2;head=456;title="PR#2";open; n=3;head=456;title="PR#3";open];
    commits=[123->[[a/a:123:ci/datakit/test, description=Testing..., pending]];
             456->[[a/a:456:ci/datakit/test, description=Testing..., pending]]])
   ("b", prs=[];commits=[])})
 ("b", {("a", prs=[];commits=[]) ("b", prs=[];commits=[])})}
DataKit:
{("a",
  {("a",
    prs=[n=0;head=123;title="PR#0";open; n=1;head=123;title="PR#1";open;
         n=2;head=456;title="PR#2";open; n=3;head=456;title="PR#3";open];
    commits=[123->[[a/a:123:ci/datakit/test, description=Testing..., pending]];
             456->[[a/a:456:ci/datakit/test, description=Testing..., pending]]])
   ("b", prs=[];commits=[])})
 ("b", {("a", prs=[];commits=[]) ("b", prs=[];commits=[])})}

Looking at the code, it appears that import_repos filters out closed PRs:
https://github.com/docker/datakit/blob/122e3a8e96850089af769e5fffd4ba21327e0712/bridge/github/src/datakit_github.ml#L859
This is then passed to Conv.update_prs, which does:
    match pr.PR.state with
    | `Closed -> safe_remove t dir

https://github.com/docker/datakit/blob/122e3a8e96850089af769e5fffd4ba21327e0712/bridge/github/src/datakit_github.ml#L506

Do you have any existing test which reproduce the issue?

Yes. Here's the commit with the test: https://github.com/talex5/datakit/commit/10c96584effe7f57681203d4e6018245f199a2f2
Here's the travis output: https://travis-ci.org/talex5/datakit/jobs/154159945 (the random seed is fixed, so you'll get the same result locally too)


telegram-notify v1.0.1

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Any update on this?

Your tag is not in semver format. Here is the guideline: https://github.com/bitrise-io/bitrise/blob/master/_docs/step-development-guideline.md#version-naming-convention

Your tag is not in semver format (there is extra v prefix). Here is the guideline: https://github.com/bitrise-io/bitrise/blob/master/_docs/step-development-guideline.md#version-naming-convention

because of the v ?

Exactly.

Exactly.

🤦🏻♂
Can i update this PR or need to create a new one? If so, how?

I think the easiest way is to create new, valid tag and share the step again in new PR.

Hey @mcaldas !
Thanks for the PR, but please try to follow @koral-- 's suggestions as he were right.
The v in the version is not a valid version format for our system.
Thanks in advance!

Hey @mcaldas !
Thanks for the PR, but please try to follow @koral-- 's suggestions as he were right.
The v in the version is not a valid version format for our system.
Thanks in advance!

@trapacska @koral--  done in #1777


Update start-using-web-services-in-exchange.md

Fix formatting

OPS Build status updates of commit 897d129:
:clock10: Preparing: average preparing time is 1 min(s) 22 sec(s)

OPS Build status updates of commit 897d129:
:clock10: Incremental building: average incremental building time is 37 sec(s)

OPS Build status updates of commit 897d129:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/exchange-web-services/start-using-web-services-in-exchange.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Adding tests for route53

Part of APPSRE-6308
Signed-off-by: Suzana Nesic<EMAIL_ADDRESS>

Thank you for adding tests for route53! Any chance of adding tests for the *WithBackoff methods? :smile:


Docker events stops sending events

I don't have clear repro steps but I have a box that ran out of disk space and now it intermittently stops sending docker events when containers get created, destroyed, etc.  This is on docker 1.3.3 on CentOS 7.  Has anyone seen this before, or can give me advice on how I may be able to debug this issue?  The systemd logs don't provide any information beyond what kind of commands were called.
Also, I have tried uninstalling and reinstalling docker, but the issue recurs.
The current workaround is restarting the docker daemon.

@smousa have you found a way to reproduce this? Also could you add the output of docker version, docker info and uname -a. Also, perhaps you can try if this problem is still present in the current version of Docker (1.5.0)

Any update? This issue seems stale.

agreed, I'm closing this issue, happy to re-open with a reproducible case and running the current version of docker


Do not crash repo main page if the repo has no branch but has tag

Do not crash repo main page if the repo has no branch but has tag

Hi, what is the use case that a repository doesn't have any branch but have tags?

After creating the repo, the user runs git push --tags, not git push

Thanks, what is the practical meaning to have tags with empty repository?

The user simply typed git push --tags. He actually wants to type something like git push --tags origin master

OK... make sense. I'll review it.

Why issue closed?  Due to commit message in 895e538?

OMG, I 100% believe it didn't hit close and now even me can't reopen this PR.

OK, I think I know why... I removed use of develop branch, so all PR will be merged to master. I'm surprised by this automatic side effect with no explanation in the timeline.

Thanks for rising the attention! I'm going to pull PRs with status/waits for review as a branch to the repository.


Concurrent Event Hub receivers not working with in same consumer group

Describe the bug
Multiple/Concurrent Event Hub receivers/consumers not working with in same consumer group. I have an EH with 3 partitions. If i have 1 consumer, it's working perfectly fine, but as soon as i start 2nd consumer with in same consumergroup, 1st consumer gets errors on console for all it's partitions.
Exception or Stack Trace
2020-06-24 12:05:07.130 [INFO] [DirectJDKLog:173] Initializing ProtocolHandler ["http-nio-8089"]
2020-06-24 12:05:07.130 [INFO] [DirectJDKLog:173] Starting service [Tomcat]
2020-06-24 12:05:07.131 [INFO] [DirectJDKLog:173] Starting Servlet engine: [Apache Tomcat/9.0.35]
2020-06-24 12:05:07.349 [INFO] [DirectJDKLog:173] Initializing Spring embedded WebApplicationContext
2020-06-24 12:05:10.487 [INFO] [ClientLogger:335] connectionId[MF_4b9d07_1592980508381] entityPath[$management]: Setting next AMQP channel.
2020-06-24 12:05:12.459 [INFO] [DirectJDKLog:173] Starting ProtocolHandler ["http-nio-8089"]
2020-06-24 12:05:12.499 [INFO] [StartupInfoLogger:61] Started ServerApplication in 11.774 seconds (JVM running for 13.405)
2020-06-24 12:05:13.481 [INFO] [ClientLogger:335] connectionId[MF_a2f6c7_1592980513356] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:05:20.934 [INFO] [ClientLogger:335] connectionId[MF_f9f7c1_1592980520718] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:05:41.111 [INFO] [ClientLogger:335] connectionId[MF_4d905f_1592980540781] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:06:55.656 [ERROR] [ClientLogger:347] connectionId[MF_a2f6c7_1592980513356] linkName[1_8ef99e_1592980513358] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1] Error occurred in link.
New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:f121413d0001332700a8a0b75ef2f421_G43_B22, SystemTracker:eh-extn-dev:eventhub:eventhubtest~21844|eventhubtestcg, Timestamp:2020-06-24T06:36:55, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1, REFERENCE_ID: 1_8ef99e_1592980513358, LINK_CREDIT: 500]
2020-06-24 12:06:55.656 [ERROR] [Loggers$Slf4JLogger:319] Operator called default onErrorDropped com.azure.core.amqp.exception.AmqpException: New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:f121413d0001332700a8a0b75ef2f421_G43_B22, SystemTracker:eh-extn-dev:eventhub:eventhubtest~21844|eventhubtestcg, Timestamp:2020-06-24T06:36:55, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1, REFERENCE_ID: 1_8ef99e_1592980513358, LINK_CREDIT: 500]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:77)
	at com.azure.core.amqp.implementation.handler.LinkHandler.processOnClose(LinkHandler.java:90)
	at com.azure.core.amqp.implementation.handler.LinkHandler.handleRemoteLinkClosed(LinkHandler.java:108)

2020-06-24 12:06:55.656 [ERROR] [Loggers$Slf4JLogger:319] Scheduler worker in group main failed with an uncaught exception com.azure.core.amqp.exception.AmqpException: New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:f121413d0001332700a8a0b75ef2f421_G43_B22, SystemTracker:eh-extn-dev:eventhub:eventhubtest~21844|eventhubtestcg, Timestamp:2020-06-24T06:36:55, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1, REFERENCE_ID: 1_8ef99e_1592980513358, LINK_CREDIT: 500]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:77)
	at com.azure.core.amqp.implementation.handler.LinkHandler.processOnClose(LinkHandler.java:90)
	at com.azure.core.amqp.implementation.handler.LinkHandler.handleRemoteLinkClosed(LinkHandler.java:108)

2020-06-24 12:07:13.627 [ERROR] [ClientLogger:347] connectionId[MF_4d905f_1592980540781] linkName[0_c1dd15_1592980540783] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0] Error occurred in link.
New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:0602df8f000133250015fe945ef2f43d_G32_B34, SystemTracker:eh-extn-dev:eventhub:eventhubtest~10922|eventhubtestcg, Timestamp:2020-06-24T06:37:13, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0, REFERENCE_ID: 0_c1dd15_1592980540783, LINK_CREDIT: 500]
2020-06-24 12:07:13.627 [ERROR] [Loggers$Slf4JLogger:319] Operator called default onErrorDropped com.azure.core.amqp.exception.AmqpException: New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:0602df8f000133250015fe945ef2f43d_G32_B34, SystemTracker:eh-extn-dev:eventhub:eventhubtest~10922|eventhubtestcg, Timestamp:2020-06-24T06:37:13, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0, REFERENCE_ID: 0_c1dd15_1592980540783, LINK_CREDIT: 500]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:77)
	at com.azure.core.amqp.implementation.handler.LinkHandler.processOnClose(LinkHandler.java:90)
	at com.azure.core.amqp.implementation.handler.LinkHandler.handleRemoteLinkClosed(LinkHandler.java:108)

2020-06-24 12:07:13.627 [ERROR] [Loggers$Slf4JLogger:319] Scheduler worker in group main failed with an uncaught exception com.azure.core.amqp.exception.AmqpException: New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:0602df8f000133250015fe945ef2f43d_G32_B34, SystemTracker:eh-extn-dev:eventhub:eventhubtest~10922|eventhubtestcg, Timestamp:2020-06-24T06:37:13, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0, REFERENCE_ID: 0_c1dd15_1592980540783, LINK_CREDIT: 500]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:77)
	at com.azure.core.amqp.implementation.handler.LinkHandler.processOnClose(LinkHandler.java:90)
	at com.azure.core.amqp.implementation.handler.LinkHandler.handleRemoteLinkClosed(LinkHandler.java:108)

2020-06-24 12:07:23.665 [ERROR] [ClientLogger:347] connectionId[MF_f9f7c1_1592980520718] linkName[2_05a282_1592980520718] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2] Error occurred in link.
New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:7ac667a900013328005abde15ef2f429_G34_B54, SystemTracker:eh-extn-dev:eventhub:eventhubtest~32766|eventhubtestcg, Timestamp:2020-06-24T06:37:23, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2, REFERENCE_ID: 2_05a282_1592980520718, LINK_CREDIT: 500]
2020-06-24 12:07:23.665 [ERROR] [Loggers$Slf4JLogger:319] Operator called default onErrorDropped com.azure.core.amqp.exception.AmqpException: New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:7ac667a900013328005abde15ef2f429_G34_B54, SystemTracker:eh-extn-dev:eventhub:eventhubtest~32766|eventhubtestcg, Timestamp:2020-06-24T06:37:23, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2, REFERENCE_ID: 2_05a282_1592980520718, LINK_CREDIT: 500]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:77)
	at com.azure.core.amqp.implementation.handler.LinkHandler.processOnClose(LinkHandler.java:90)
	at com.azure.core.amqp.implementation.handler.LinkHandler.handleRemoteLinkClosed(LinkHandler.java:108)

2020-06-24 12:07:23.665 [ERROR] [Loggers$Slf4JLogger:319] Scheduler worker in group main failed with an uncaught exception com.azure.core.amqp.exception.AmqpException: New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:7ac667a900013328005abde15ef2f429_G34_B54, SystemTracker:eh-extn-dev:eventhub:eventhubtest~32766|eventhubtestcg, Timestamp:2020-06-24T06:37:23, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2, REFERENCE_ID: 2_05a282_1592980520718, LINK_CREDIT: 500]
	at com.azure.core.amqp.implementation.ExceptionUtil.toException(ExceptionUtil.java:77)
	at com.azure.core.amqp.implementation.handler.LinkHandler.processOnClose(LinkHandler.java:90)
	at com.azure.core.amqp.implementation.handler.LinkHandler.handleRemoteLinkClosed(LinkHandler.java:108)

2020-06-24 12:11:55.521 [WARN] [ClientLogger:341] Retry #1. Transient error occurred. Retrying after 4511 ms.
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:c849399cdfc8481fafaedafc733c7410_G43, SystemTracker:gateway5, Timestamp:2020-06-24T06:41:55, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: $cbs, REFERENCE_ID: cbs:sender, LINK_CREDIT: 99]
2020-06-24 12:11:55.529 [ERROR] [ClientLogger:347] Exception in RequestResponse links. Disposing and clearing unconfirmed sends.
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:c849399cdfc8481fafaedafc733c7410_G43, SystemTracker:gateway5, Timestamp:2020-06-24T06:41:55, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: $cbs, REFERENCE_ID: cbs:sender, LINK_CREDIT: 99]
2020-06-24 12:12:00.176 [INFO] [ClientLogger:335] Retry #1. Requesting from upstream.
2020-06-24 12:12:00.180 [INFO] [ClientLogger:335] connectionId[MF_a2f6c7_1592980513356] entityPath[$cbs]: Connection not requested, yet. Requesting one.
2020-06-24 12:12:00.181 [ERROR] [ClientLogger:347] connectionId[MF_a2f6c7_1592980513356]: Connection is disposed. Cannot get CBS node.
2020-06-24 12:12:00.183 [INFO] [ClientLogger:335] connectionId[MF_a2f6c7_1592980513356] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:12:55.539 [WARN] [ClientLogger:341] Retry #1. Transient error occurred. Retrying after 4511 ms.
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:713375a6000645a68dda81991fab2173_G32, SystemTracker:gateway5, Timestamp:2020-06-24T06:42:13, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: $cbs, REFERENCE_ID: cbs:sender, LINK_CREDIT: 99]
2020-06-24 12:12:55.539 [ERROR] [ClientLogger:347] Exception in RequestResponse links. Disposing and clearing unconfirmed sends.
The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'. TrackingId:713375a6000645a68dda81991fab2173_G32, SystemTracker:gateway5, Timestamp:2020-06-24T06:42:13, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: $cbs, REFERENCE_ID: cbs:sender, LINK_CREDIT: 99]
2020-06-24 12:13:00.062 [INFO] [ClientLogger:335] Retry #1. Requesting from upstream.
2020-06-24 12:13:00.063 [INFO] [ClientLogger:335] connectionId[MF_4d905f_1592980540781] entityPath[$cbs]: Connection not requested, yet. Requesting one.
2020-06-24 12:13:00.067 [ERROR] [ClientLogger:347] connectionId[MF_4d905f_1592980540781]: Connection is disposed. Cannot get CBS node.
2020-06-24 12:13:00.068 [INFO] [ClientLogger:335] connectionId[MF_4d905f_1592980540781] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:13:01.408 [ERROR] [ClientLogger:347] There are no partitions in Event Hub eventhubtest
Error occurred while processing events There are no partitions in Event Hub eventhubtest
2020-06-24 12:13:11.431 [ERROR] [ClientLogger:347] There are no partitions in Event Hub eventhubtest
Error occurred while processing events There are no partitions in Event Hub eventhubtest

To Reproduce
Steps:

Create a spring boot application.
Add azure-messaging-eventhubs dependency in pom.xml
Start 1st consumer with a port 8080
You will see it's connected to all 3 partitions on console as below:

2020-06-24 12:05:13.481 [INFO] [ClientLogger:335] connectionId[MF_a2f6c7_1592980513356] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:05:20.934 [INFO] [ClientLogger:335] connectionId[MF_f9f7c1_1592980520718] entityPath[$cbs]: Setting next AMQP channel.
2020-06-24 12:05:41.111 [INFO] [ClientLogger:335] connectionId[MF_4d905f_1592980540781] entityPath[$cbs]: Setting next AMQP channel.

Now start 2nd consumer with port 8081 with same conosumer group. Then you will see errors on 1st consumer console.
Operator called default onErrorDropped com.azure.core.amqp.exception.AmqpException

Code Snippet
public IEventHubConsumer(EventHubConsumerConfig config) {

       BlobContainerAsyncClient blobContainerAsyncClient = new BlobContainerClientBuilder()
               .connectionString(config.getStorageConnectionString())
               .containerName(config.getStorageContainerName())
               .buildAsyncClient();

       eventProcessorClient = new EventProcessorClientBuilder()

               .consumerGroup(config.getConsumergroup())
               .connectionString(config.getConnectionString())
               .checkpointStore(new BlobCheckpointStore(blobContainerAsyncClient))
               .processEvent(eventContext -> {

                   String message = eventContext.getEventData().getBodyAsString();

                   System.out.println(message);

                   if(isAlive()) {
                       eventContext.updateCheckpoint();
                   }
               })
               .processError(errorContext -> System.out
                       .println("Error occurred while processing events " + errorContext.getThrowable().getMessage()))
               .buildEventProcessorClient();

   }
   public void stop() {
       // This will stop the processor.
       eventProcessorClient.stop();
   }

Expected behavior
1)If 1st consumer is started, it consumes from all 3 partitions, it's working fine, no problem.
2)If 2nd consumer is started, 1st consumer should release 1 partition and provide it to 2nd consumer
3)If 3rd consumer is started, 1st consumer should release 1 partition and provide it to 3rd consumer
4)On the whole, all 3 consumers should be consuming from 3 partitions, 1 each.
5)All 3 consumers should be using same consumer group.
Setup (please complete the following information):

OS: Windows 10 64 big
IDE : IntelliJ
Version of the Library used

<parent>
	<groupId>org.springframework.boot</groupId>
	<artifactId>spring-boot-starter-parent</artifactId>
	<version>2.3.0.RELEASE</version>
	<relativePath/> <!-- lookup parent from repository -->
</parent>
<dependency>
	<groupId>com.azure</groupId>
	<artifactId>azure-messaging-eventhubs</artifactId>
	<version>5.1.0</version>
</dependency>
<dependency>
	<groupId>com.azure</groupId>
	<artifactId>azure-storage-blob</artifactId>
	<version>12.6.1</version>
</dependency>
<dependency>
	<groupId>com.azure</groupId>
	<artifactId>azure-messaging-eventhubs-checkpointstore-blob</artifactId>
	<version>1.1.0</version>
</dependency>

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@serkantkaraca or @JamesBirdsall  - could you please check this issue

@kumarrajnumber Thanks for reporting the issue. Can you please try the newer version of the library that has the fix for this? This was previously reported in this issue - https://github.com/Azure/azure-sdk-for-java/issues/11419
<dependency>
	<groupId>com.azure</groupId>
	<artifactId>azure-messaging-eventhubs</artifactId>
	<version>5.1.1</version>
</dependency>
<dependency>
	<groupId>com.azure</groupId>
	<artifactId>azure-messaging-eventhubs-checkpointstore-blob</artifactId>
	<version>1.1.1</version>
</dependency>

Thanks very much for quick response.
After updating to new version,It's throwing same error messages now as well, but it doesn't say it as ERROR. it's throwing similar kind of errors on all the receivers now, and these ERRORs keeps on repeating on console, like infinity looop.
Please find below trace which is repeating on all the receivers:
2020-06-25 11:06:41.215 [ERROR] [ClientLogger:347] connectionId[MF_07d9dd_1593063370322] linkName[1_231ec7_1593063370322] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1] Error occurred in link.
2020-06-25 11:06:50.111 [ERROR] [ClientLogger:347] connectionId[MF_e18f29_1593063322770] linkName[2_d61c3b_1593063322772] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2] Error occurred in link.
2020-06-25 11:07:00.354 [ERROR] [ClientLogger:347] connectionId[MF_554ecc_1593063350247] linkName[0_764672_1593063350248] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0] Error occurred in link.

Detailed trace:
2020-06-25 11:05:22.109 [INFO] [StartupInfoLogger:61] Started ServerApplication in 16.544 seconds (JVM running for 19.737)
2020-06-25 11:05:22.892 [INFO] [ClientLogger:335] namespace[MF_e18f29_1593063322770] entityPath[$cbs]: Setting next AMQP channel.
2020-06-25 11:05:22.893 [INFO] [ClientLogger:335] namespace[MF_e18f29_1593063322770] entityPath[$cbs]: Next AMQP channel received, updating 0 current subscribers
2020-06-25 11:05:22.920 [INFO] [ClientLogger:335] namespace[MF_e18f29_1593063322770] entityPath[$cbs]: Channel is now active.
2020-06-25 11:05:22.921 [INFO] [ClientLogger:335] namespace[MF_e18f29_1593063322770] entityPath[$cbs]: Channel is now active.
2020-06-25 11:05:50.481 [INFO] [ClientLogger:335] namespace[MF_554ecc_1593063350247] entityPath[$cbs]: Setting next AMQP channel.
2020-06-25 11:05:50.481 [INFO] [ClientLogger:335] namespace[MF_554ecc_1593063350247] entityPath[$cbs]: Next AMQP channel received, updating 0 current subscribers
2020-06-25 11:05:50.524 [INFO] [ClientLogger:335] namespace[MF_554ecc_1593063350247] entityPath[$cbs]: Channel is now active.
2020-06-25 11:05:50.524 [INFO] [ClientLogger:335] namespace[MF_554ecc_1593063350247] entityPath[$cbs]: Channel is now active.
2020-06-25 11:06:10.638 [INFO] [ClientLogger:335] namespace[MF_07d9dd_1593063370322] entityPath[$cbs]: Setting next AMQP channel.
2020-06-25 11:06:10.639 [INFO] [ClientLogger:335] namespace[MF_07d9dd_1593063370322] entityPath[$cbs]: Next AMQP channel received, updating 0 current subscribers
2020-06-25 11:06:10.701 [INFO] [ClientLogger:335] namespace[MF_07d9dd_1593063370322] entityPath[$cbs]: Channel is now active.
2020-06-25 11:06:10.702 [INFO] [ClientLogger:335] namespace[MF_07d9dd_1593063370322] entityPath[$cbs]: Channel is now active.
2020-06-25 11:06:41.215 [ERROR] [ClientLogger:347] connectionId[MF_07d9dd_1593063370322] linkName[1_231ec7_1593063370322] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1] Error occurred in link.
New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:f121413d0001332700b7cf3c5ef437ca_G45_B22, SystemTracker:eh-extn-dev:eventhub:eventhubtest~21844|eventhubtestcg, Timestamp:2020-06-25T05:36:41, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1, REFERENCE_ID: 1_231ec7_1593063370322, LINK_CREDIT: 500]
Error occurred while processing events New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:f121413d0001332700b7cf3c5ef437ca_G45_B22, SystemTracker:eh-extn-dev:eventhub:eventhubtest~21844|eventhubtestcg, Timestamp:2020-06-25T05:36:41, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/1, REFERENCE_ID: 1_231ec7_1593063370322, LINK_CREDIT: 500]
2020-06-25 11:06:50.111 [ERROR] [ClientLogger:347] connectionId[MF_e18f29_1593063322770] linkName[2_d61c3b_1593063322772] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2] Error occurred in link.
New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:7ac667a900013328005e84615ef4379a_G34_B54, SystemTracker:eh-extn-dev:eventhub:eventhubtest~32766|eventhubtestcg, Timestamp:2020-06-25T05:36:50, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2, REFERENCE_ID: 2_d61c3b_1593063322772, LINK_CREDIT: 500]
Error occurred while processing events New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:7ac667a900013328005e84615ef4379a_G34_B54, SystemTracker:eh-extn-dev:eventhub:eventhubtest~32766|eventhubtestcg, Timestamp:2020-06-25T05:36:50, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/2, REFERENCE_ID: 2_d61c3b_1593063322772, LINK_CREDIT: 500]
2020-06-25 11:06:50.623 [INFO] [ClientLogger:335] namespace[MF_3032d3_1593063410375] entityPath[$cbs]: Setting next AMQP channel.
2020-06-25 11:06:50.624 [INFO] [ClientLogger:335] namespace[MF_3032d3_1593063410375] entityPath[$cbs]: Next AMQP channel received, updating 0 current subscribers
2020-06-25 11:06:50.668 [INFO] [ClientLogger:335] namespace[MF_3032d3_1593063410375] entityPath[$cbs]: Channel is now active.
2020-06-25 11:06:50.669 [INFO] [ClientLogger:335] namespace[MF_3032d3_1593063410375] entityPath[$cbs]: Channel is now active.
2020-06-25 11:07:00.354 [ERROR] [ClientLogger:347] connectionId[MF_554ecc_1593063350247] linkName[0_764672_1593063350248] entityPath[eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0] Error occurred in link.
New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:0602df8f00013325001a7fae5ef437b8_G21_B34, SystemTracker:eh-extn-dev:eventhub:eventhubtest~10922|eventhubtestcg, Timestamp:2020-06-25T05:37:00, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0, REFERENCE_ID: 0_764672_1593063350248, LINK_CREDIT: 500]
Error occurred while processing events New receiver 'nil' with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected. If you are recreating the receiver, make sure a higher epoch is used. TrackingId:0602df8f00013325001a7fae5ef437b8_G21_B34, SystemTracker:eh-extn-dev:eventhub:eventhubtest~10922|eventhubtestcg, Timestamp:2020-06-25T05:37:00, errorContext[NAMESPACE: eh-extn-dev.servicebus.windows.net, PATH: eventhubtest/ConsumerGroups/eventhubtestcg/Partitions/0, REFERENCE_ID: 0_764672_1593063350248, LINK_CREDIT: 500]
2020-06-25 11:07:00.610 [INFO] [ClientLogger:335] namespace[MF_9f0de6_1593063420400] entityPath[$cbs]: Setting next AMQP channel.
2020-06-25 11:07:00.611 [INFO] [ClientLogger:335] namespace[MF_9f0de6_1593063420400] entityPath[$cbs]: Next AMQP channel received, updating 0 current subscribers
2020-06-25 11:07:00.656 [INFO] [ClientLogger:335] namespace[MF_9f0de6_1593063420400] entityPath[$cbs]: Channel is now active.

@kumarrajnumber Thanks for trying out the new version. Can you also please provide full logs of both instance 1 and instance 2 with debug loglevel enabled?

server1.txt
server2.txt
Sorry for late response, enabled DEBUG. PFA logs of both the servers. Just to brief:
1 consumer group, 3 partitions, 2 consumers with in same consumer group. PFA logs of 2 consumers.

One more observation, consumers are consuming duplicate messages.
Producer produces messages based on a partition key to maintain sequence.
server2-duplicate.txt
server1-duplicate.txt
If you observer the line number :
3720 - in server1-duplicate.txt
3913 - in server2-duplicate.txt
That's the same message read by 2 consumers, which is not supposed to be read by 2 consumers. As per logs, i understand retaining of partitions are not happening properly in consumers. Can you please check.
This is the consumer code i used:
import com.azure.messaging.eventhubs.EventData;
import com.azure.messaging.eventhubs.EventDataBatch;
import com.azure.messaging.eventhubs.EventHubClientBuilder;
import com.azure.messaging.eventhubs.EventHubProducerClient;
import com.azure.messaging.eventhubs.models.CreateBatchOptions;
import com...helper.ObjectMapperHelper;
import com...models.Base;

import java.time.LocalDateTime;
import java.util.ArrayList;
import java.util.List;

public class EventHubProducer {

    private ObjectMapperHelper objectMapper = new ObjectMapperHelper();
    int i = 0;

    public EventHubProducer() {
        EventHubProducerClient producer = new EventHubClientBuilder()
                .connectionString("Connectionstring")
                .buildProducerClient();

        List<Base> data = getDataFor();

        data.forEach(da -> {

            if(Integer.valueOf(da.getMessageId()) % 10 == 0) {
                i++;
            }

            String partitionKey = "grouping-key" + i;
            System.out.println("PartitionKey  :"+partitionKey);

                CreateBatchOptions batchOptions = new CreateBatchOptions().setPartitionKey(partitionKey);
                EventDataBatch eventDataBatch = producer.createBatch(batchOptions);
                String stData = objectMapper.getValueString(da);
                EventData sendEvent = new EventData(stData);
                eventDataBatch.tryAdd(sendEvent);

                producer.send(eventDataBatch);

            System.out.println("Producer sent :" + sendEvent.getBodyAsString());
        });
    }

    private List<Base> getDataFor() {
        List<Base> list = new ArrayList<>();

        for (long i = 600; i < 650; i++) {
            Base Base = new Base(String.valueOf(i), LocalDateTime.now().toString(), "mesasgetype" + i, " message" + i);
            list.add(Base);
        }

        return list;
    }

    public static void main(String[] args) {
        new EventHubProducer();
    }
}

@kumarrajnumber Thanks for the sharing logs.
I noticed that in the logs, there were 3 servers running simultaneously. Is it possible to include the logs for all 3 servers?
2020-06-30 10:39:25.757 [INFO] [ClientLogger:335] Number of active event processors 3

Also, it would be great if you could set the HttpLogOptions when creating the blob container client as shown below:
BlobContainerAsyncClient blobContainerAsyncClient = new BlobContainerClientBuilder()
               .connectionString(config.getStorageConnectionString())
               .containerName(config.getStorageContainerName())
               .httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
               .buildAsyncClient();

This is generally not required but will help me understand the sequence of events when looking at the logs.

I haven't started 3rd server. I am wondering from where processor 3rd would have come.
Now i made sure there are only 2 processors.
added httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
Tried multiple times to replicate duplicate messages, unfortunately after adding BODY_AND_HEADERS i am unable to reproduce the error.
But still i see the epoc errors. please check the logs of 2 servers.
server2-01July.txt
server1-01July.txt

@kumarrajnumber Thank you for providing these logs. I checked the logs and it seems like the 2 processors are in a balanced state. There are 3 partitions in the Event Hub and server 1 owns two partitions and server 2 owns one partition.
server-1 log:
2020-07-01 16:03:35.926 [DEBUG] [ClientLogger:332] Current partition distribution
455d722e-182d-4fd4-9dd0-cd0568495946=[2];b6f9cb02-41f4-42eb-82f4-496504692974=[0,1]
2020-07-01 16:03:35.926 [INFO] [ClientLogger:335] Number of active event processors 2
2020-07-01 16:03:35.926 [INFO] [ClientLogger:335] Expected min partitions per event processor = 1,
expected number of event processors with additional partition = 1
2020-07-01 16:03:35.926 [INFO] [ClientLogger:335] Load is balanced with this event processor owning 2 partitions
2020-07-01 16:03:35.926 [INFO] [ClientLogger:109] Load balancing completed successfully

server-2 log:
2020-07-01 16:04:16.771 [DEBUG] [ClientLogger:332] Current partition distribution
 455d722e-182d-4fd4-9dd0-cd0568495946=[2];b6f9cb02-41f4-42eb-82f4-496504692974=[0,1]
2020-07-01 16:04:16.771 [INFO] [ClientLogger:335] Number of active event processors 2
2020-07-01 16:04:16.771 [INFO] [ClientLogger:335] Expected min partitions per event processor = 1,
expected number of event processors with additional partition = 1
2020-07-01 16:04:16.771 [INFO] [ClientLogger:335] Load is balanced with this event processor owning 1 partitions
2020-07-01 16:04:16.772 [INFO] [ClientLogger:109] Load balancing completed successfully

So, it looks like the processors reached a stable state. If you are asking about the error regarding epoc, that's expected when one processor "steals" a partition from another processor that was owning the partition. In this case, server-1 was owning all 3 partitions initially. Then when server-2 started, it stole one of the partitions from server-1. When this happens, server-1 gets notified that the partition was stolen and the epoc error is logged. It is not an application error. It is just that the ownership transferred from one server to another.
020-07-01 15:56:54.090 [INFO] [ClientLogger:335] processOnClose connectionId[MF_a3f38d_1593599136695],
linkName[2_a8ca68_1593599136697], errorCondition[amqp:link:stolen], errorDescription[New receiver 'nil'
with higher epoch of '0' is created hence current receiver 'nil' with epoch '0' is getting disconnected.
If you are recreating the receiver, make sure a higher epoch is used.

Thanks for the clarification.
I observed consumers got duplication messages multiple times, i am unable to replicate it now, will keep monitoring this. Will raise new issue if required.
Please close this ticket.

We also got duplicate messages multiple times and we use the latest dependency 5.3.1 for event hub and checkpointing store is 1.1.1. See the exception below when EHB consumers start up
Exception in RequestResponse links. Disposing and clearing unconfirmed sends. The connection was inactive for more than the allowed 300000 milliseconds and is closed by container 'LinkTracker'.


Add H2O.ai Database-like Ops benchmark to dfbench

Is your feature request related to a problem or challenge?
Follow on to #7052
There is an interesting database benchark called "H20.ai database like benchmark" that DuckDB seems to have revived (perhaps because the original went dormant with very old with very old/ slow duckdb results). More background here: https://duckdb.org/2023/04/14/h2oai.html#results
@Dandandan  added a new solution for datafusion here: https://github.com/duckdblabs/db-benchmark/pull/18
However, there is no easy way to run the h2o benchmark within the datafusion repo. There is an old version of some of these benchmarks in the code: https://github.com/apache/arrow-datafusion/blob/main/benchmarks/src/bin/h2o.rs
Describe the solution you'd like
I would like someone to make it easy to run the h20.ai benchmark in the datafusion repo.
Ideally this would look like
# generate data
./benchmarks/bench.sh data h20.ai
# run
./benchmarks/bench.sh run h20.ai

I would expect to be able to run the individual queries like this
cargo run  --bin dfbench -- h2o.ai --query=3

Some steps might be

port the existing benchmark script to dfbench following the model in https://github.com/apache/arrow-datafusion/pull/7120
update bench.sh, following the model of existing benchmarks
Update the documentation

Describe alternatives you've considered
We could also simply remove the h20.ai benchmark script as it is not clear how important it will be long term
Additional context
I think this is a good first issue as the task is clear, and there are existing patterns in bench.sh, dfbench and in

I will be working on this

sorry for the inactivity on this. my RSI came back so i was taking a break from typing, i will try to submit the PR in a day or two.

No problem -- I hope you feel better soon

Is this something that's still wanted? I took a look at doing this but it looks like the data isn't hosted on the benchmark repo, just data gen scripts in R.

Is this something that's still wanted? I took a look at doing this but it looks like the data isn't hosted on the benchmark repo, just data gen scripts in R.

I think it would be useful. Thank you
I think figuring out how to generate the data locally would be super valuable -- perhaps we can use a docker like approach as we do for tpch:
https://github.com/apache/datafusion/blob/89677ae66ec2238ffd58de8c36fe6030fad458fa/benchmarks/bench.sh#L286-L292
So it would run like
./bench.sh data h2o

Which would leave data in  datafusion/benchmarks/data/h2o
🤔

Now that @Rachelint  and @2010YOUY01  and others have started working on

https://github.com/apache/datafusion/issues/13548

I think this issue is more important than ever
I think the hardest part of this task is actually generating the benchmark data
Thankfully @MrPowers has created falsa to generate the dataset (so we don't need R installed):
Here are the instructions for generating data: https://github.com/MrPowers/mrpowers-benchmarks?tab=readme-ov-file#running-the-benchmarks-on-your-machine

I don't currently have bandwidth to take this across the finish line but I did get the datagen working via Docker
Commit with data gen

Thanks @drewhayward  -- maybe someone else can pick it up from there


[BUG] unwanted header

Describe the bug
unwanted header added to the custom header
To Reproduce
I don't know whether this only applies to cloudflare cfg only as this issue does not occur in non cloudflare cfg. http://prntscr.com/nbi37i
In the request block even if the custom header are blank https://prnt.sc/nbatd1 those three header are being added, you can specify a Accept header, but Accept: / will always be added, also for pragma and user agent. This shouldn't be the case.
Expected behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Version

Version [e.g. 1.0.1]

Additional context
Add any other context about the problem here.

https://github.com/openbullet/openbullet/commit/2df8e52f92d996b74351dd281dd84f44d45294cb

it still append header Accept-Encoding: gzip,deflate and I can't override this. it could be problem in Extreme.Net ?

Open a new issue @ewwink this one is closed.


Make confidence histograms easier to read

Description of Problem:
rasa test currently produces a histogram of confidence values for both correct and incorrect predictions.

IMO something like this would be easier to read, e.g.:

Definition of Done:

[ ] Tests are passing
[ ] Example images are updated in the docs
[ ] Feature mentioned in the changlog

Hey, our team would like to take a look at this task and work on getting a PR up. We are university students looking to contribute as part of a course.

Hey, our team would like to take a look at this task and work on getting a PR up. We are university students looking to contribute as part of a course.

+1

Hey, our team would like to take a look at this task and work on getting a PR up. We are university students looking to contribute as part of a course.

+1

Hey, our team would like to take a look at this task and work on getting a PR up. We are university students looking to contribute as part of a course.

+1

@amn41

sounds great! thanks for getting involved, this would be a great contribution :)

@amn41  could you assign it to us under doing in the contributor board please :)

our pr is also up: https://github.com/RasaHQ/rasa/pull/7404

@amn41 sorry, could any maintainer help us add this issue to the board and assign it to us ? Thanks!


Admin rights for jpkrohling

I would like to request admin rights for this repository. My current need is to enable a set of checks, making them required before merging, such as the successful execution of e2e tests, and I cannot do that as a maintainer only.
cc @open-telemetry/collector-maintainers

@jpkrohling you are an Admin now.

Thanks!


Archen

Added Archen

I solved the conflicts you can review it.

It still happens to have 5. I will close this one. You can make a newer PR after updating your fork. I will make sure i merge that.


Support PostgreSQL 9.5 ON CONFLICT DO UPDATE

I can see it's supported for MySQL but there's DO NOTHING for Postgres. Any reason for that?
It's supported since 9.5: https://wiki.postgresql.org/wiki/What's_new_in_PostgreSQL_9.5#INSERT_...ON_CONFLICT_DO_NOTHING.2FUPDATE.28.22UPSERT.22.29

Probably, the person who submitted the original PR implemented it only for MySQL. Please do submit a PR adding the PostgreSQL support!


Fix CodeClimate Issues

This is an entry level issue for users to become familiar with the Privly Project's code base. You should pick a file from CodeClimate and improve files per the recommendation of the programmatic code quality system.
Do not close this issue in your commits since this is intended to be a more permanent issue.

CodeClimate issue pull request #208

@smcgregor Since this issue is merged in #182  I think its good to close this issue.

This repository still needs improvement, according to CodeClimate. I will leave the issue open until CodeClimate stops complaining since it is a great entry-level issue.
See: https://codeclimate.com/github/privly/privly-applications


PITR checkpoint not advance if tikv fails to connect to PD at start

Bug Report

What version of TiKV are you using?
 # /tikv-server -V
TiKV
Release Version:   6.5.0
Edition:           Community
Git Commit Hash:   fd2904a7ac9ff395ff7f908a3c2a961a95551484
Git Commit Branch: heads/refs/tags/v6.5.0
UTC Build Time:    2022-12-02 09:08:26
Rust Version:      rustc 1.67.0-nightly (96ddd32c4 2022-11-14)

What operating system and CPU are you using?
K8S
Steps to reproduce

Create TiDB cluster cross 3 AZs
Create PITR task
inject single AZ failure for 10min
Check PITR lag

What did you expect?
PITR lag should be less than 5min during single AZ failure
What did happened?
PITR checkpoint not advance when the single AZ failure ends and tikv restart, at which time TiKV fails to connect to PD.
[2022/12/05 13:41:20.532 +08:00] [WARN] [[errors.rs:155](http://errors.rs:155/)] ["backup stream meet error"] [verbose_err="Etcd(GRpcStatus(Status { code: Unknown, message: \"buffered service failed: load balancer discovery error: transp
ort error: transport error\", source: Some(ServiceError { inner: Discover(TransportError(tonic::transport::Error(Transport, hyper::Error(Connect, ConnectError(\"tcp connect error\", Os { code: 111, kind: Connecti
onRefused, message: \"Connection refused\" }))))) }) }))"] [err="Etcd meet error grpc request error: status: Unknown, message: \"buffered service failed: load balancer discovery error: transport error: transport
error\", details: [], metadata: MetadataMap { headers: {} }"] [context="failed to start watch tasks"]

refer to: http://perf.pingcap.net:3000/d/dkZqxvG4k/ha-test-plan-summary?orgId=1&var-plan_tag=All&var-tag_id=1050107&var-case_id=All&refresh=10s

/component br

/severity Critical

/type bug

/label affects-6.4

/label affects-6.5

/label may-affects-6.3

/remove-label may-affects-6.3


RSS server API support

Will you implement also support for RSS servers (e.g. FreshRSS and similar)? Is it planned?

Hi, this is android app, and RSS server is hosted on PC so it is completely different.

What I meant is that most of us have some self-hosted RSS servers where the feeds are collected, and I was wondering whether your app can operate as a client to it.

Cant find a good reference on the standard. Is there any W3C standard that is widely used for all?

As far as I am aware, there are

fever API (https://freshrss.github.io/FreshRSS/en/developers/06_Fever_API.html)
GReader API (https://code.google.com/archive/p/pyrfeed/wikis/GoogleReaderAPI.wiki), and
TT-RSS API (https://tt-rss.org/wiki/ApiReference)

Doesn't seemed to be a well maintained and stable standards.

Seemed unable to reach https://feedafever.com/api ? And also the API design is somewhat unusual ( appending request parameter names? )

Is that google reader API standard? It looks very hacky, not to mention it clearly says it is unofficial and should not rely on it.

This API seemed to be developed for specific RSS server only and not widely used?

I do not think it is a good idea to implement these standards, need at least widely used standards, perhaps from W3C or from RSS advisory board.


CSS Selector Bridge 2

Hey maintainers,
I was working with the CSS Selector bridge, but I was missing some features. This is a pretty big change (breaking) in how the bridge works, so I made it CssSelector2Bridge.
It adds support for:

Cookies
Timestamps
Categories
Author

It works by this principle:

From the page containing the collection of articles, select all elements describing the articles
From each article element, select the article URLs
If needed, download every article page and use the provided article selector to find the article content element
Parse the article contents using the provided selectors and filters

I made this because I found the original parser a bit too limited for my needs.

@ORelio

Looks nice!
I designed the CSS Selector bridge to be as simple as possible because we can't address everything using a selector bridge: each site may have its little quirks requiring special handling, so CssSelectorBridge bridge was not designed to be a full replacement of the regular way of writing bridges in PHP, but rather a quick way of generating a feed for simple sites that don't have any specificity to take into account. Addressing everything may be frustrating and/or lead to feature bloat, difficulty to maintain the bridge to accommodate fixes for each user without breaking existing feeds.
Note that if the site has a truncated RSS feed, you can use WordPressBridge to expand it and retain metadata such as author and timestamp from the feed. The site does not need to run WordPress for the bridge to work as you can specify a custom content selector if needed, so WordPressBridge should be preferred over CssSelectorBridge when possible.
Now, let's assume that we still want to generate complex feeds using CSS Selectors anyway and not write a PHP bridge.
I see that the changes will indeed break existing feeds, so CssSelector2Bridge makes sense.
Here are some thoughts about the added features:

Cookies: Are you sure your cookie will not expire after some time, requiring you to recreate/update your feed? Seems more convenient to write a bridge in PHP that would first fetch the cookie automatically, then use it. I'd be curious of your use case for that feature in Css Selector Bridge 🤔

Timestamps: After giving it some thought, I did not implement them in the CSS Selector Bridge because of so many sites that use timestamps not compatible with strtotime(). Adding support for timestamps would work better if also adding support for custom date formats as additional setting. Also, as if it wasn't already complicated enough, the timestamp may be either on home page or on article page. So an additional switch would be needed (that makes 3 settings just for the timestamp). But then I realized that when timestamp is missing, feed aggregators take the time where the item is first discovered, which does the job well in most cases. If you prefer adding support for timestamps, consider adding format setting. That will surely be handy.

Categories/Author: Note that in some case, they may be present on home page only.

remove_styling: Note that this is usually up to the feed reader application to do this.

The CssSelector2Bridge looks nice as is, so you are not required to make further changes. I'm just making suggestions.
Just let @dvikan know when you are ready for merging.

Thanks for your detailed reply!

I designed the CSS Selector bridge to be as simple as possible because we can't address everything using a selector bridge: each site may have its little quirks requiring special handling, so CssSelectorBridge bridge was not designed to be a full replacement of the regular way of writing bridges in PHP, but rather a quick way of generating a feed for simple sites that don't have any specificity to take into account. Addressing everything may be frustrating and/or lead to feature bloat, difficulty to maintain the bridge to accommodate fixes for each user without breaking existing feeds.

I agree there is something to say for keeping it more simple. I do think this will add valuable functionality, since the way to select content is more powerful.

Note that if the site has a truncated RSS feed, you can use WordPressBridge to expand it and retain metadata such as author and timestamp from the feed. The site does not need to run WordPress for the bridge to work as you can specify a custom content selector if needed, so WordPressBridge should be preferred over CssSelectorBridge when possible.

I am not sure what you mean. I don't think I did anything to expand truncated feeds.

Now, let's assume that we still want to generate complex feeds using CSS Selectors anyway and not write a PHP bridge. I see that the changes will indeed break existing feeds, so CssSelector2Bridge makes sense. Here are some thoughts about the added features:

Cookies: Are you sure your cookie will not expire after some time, requiring you to recreate/update your feed? Seems more convenient to write a bridge in PHP that would first fetch the cookie automatically, then use it. I'd be curious of your use case for that feature in Css Selector Bridge 🤔

The website I was using to test this just required a cookie to enable loading the content. Just passing a cookie with a certain string would enable loading the content already. It didn't have to be valid. See issue #3612.

Timestamps: After giving it some thought, I did not implement them in the CSS Selector Bridge because of so many sites that use timestamps not compatible with strtotime(). Adding support for timestamps would work better if also adding support for custom date formats as additional setting. Also, as if it wasn't already complicated enough, the timestamp may be either on home page or on article page. So an additional switch would be needed (that makes 3 settings just for the timestamp). But then I realized that when timestamp is missing, feed aggregators take the time where the item is first discovered, which does the job well in most cases. If you prefer adding support for timestamps, consider adding format setting. That will surely be handy.

Good idea. I didn't feel like implementing it, but I can spend some time doing it.

Categories/Author: Note that in some case, they may be present on home page only.

True, but I don't think this is worth supporting right now.

remove_styling: Note that this is usually up to the feed reader application to do this.

Interesting, I didn't know that as I just starting using RSS. Do you recommend removing this feature?

The CssSelector2Bridge looks nice as is, so you are not required to make further changes. I'm just making suggestions. Just let @dvikan know when you are ready for merging.

👍

Note that if the site has a truncated RSS feed, you can use WordPressBridge to expand it and retain metadata such as author and timestamp from the feed. The site does not need to run WordPress for the bridge to work as you can specify a custom content selector if needed, so WordPressBridge should be preferred over CssSelectorBridge when possible.

I am not sure what you mean. I don't think I did anything to expand truncated feeds.

I meant, as a user, you may use WordPressBridge rather than CssSelectorBridge when the site has a truncated feed.

The website I was using to test this just required a cookie to enable loading the content. Just passing a cookie with a certain string would enable loading the content already. It didn't have to be valid. See issue https://github.com/RSS-Bridge/rss-bridge/issues/3612.

Oh, OK, got it. I did not see your issue, feel free to ping me whenever your issues are related to a bridge I maintain. This is rather strange, because the site may fail to be indexed properly in search engines if it does require a cookie.

Good idea. I didn't feel like implementing it, but I can spend some time doing it.

No pressure 😉

Interesting, I didn't know that as I just starting using RSS. Do you recommend removing this feature?

Then welcome! Feel free to first test your feed with and without styling in your feed reader to see if that makes a difference, and decide based on your results. From my experience, I can just say that most bridges in rss-bridge will not clean style/class attributes from the HTML content, but all RSS readers I tried will just ignore them.

I added the possibility to specify the time format.
I also tested not removing the styling, but my own RSS Reader (NetNewsWire) did not ignore it and it caused a large amount of whitespace to be contained in the article, so I kept that functionality.

@dvikan I am ready with the PR.

Done

Trying to get property 'innertext' of non-object at bridges/CssSelectorComplexBridge.php line 426

@dvikan Check your Author selector
https://github.com/RSS-Bridge/rss-bridge/blob/eb4ff7099f07859a2a3078c50a7d5366ca722bb1/bridges/CssSelectorComplexBridge.php#L424-L427

please fix:
Trying to get property 'innertext' of non-object at bridges/CssSelectorComplexBridge.php line 421

@LarsStegman