Encoding is not compatible with Browser decoding

Hey, I compiled it to javascript using scala-js and if you do something like :
href = "data:application/octet-stream;base64," + data.stripMargin.getBytes.toBase64

Then the downloaded file ends with some incorrectly decoded characters, otherwise it is alright. So I suspect that the Webkit/Chrome decoding is not compatible with this base64 encoding...
Btw to make this scala-js compatible one just need to comment out the specs2 test suite (that doesn't compile to javascript) or rewrite it using some scala-js compliant testing framework like utest and add plugin :
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.0-M3")

and enable it :
lazy val base64 = (project in file(".")).enablePlugins(org.scalajs.sbtplugin.ScalaJSPlugin)

Anyway using btoa is a better idea. I just wanted to let you know that it might be something wrong with it if the encoder is not compliant with third party decoders. It means that stuff must be necessarily encoded and decoded by this codec.

I'm pasting the answer of Sébastien Doeraene, the creator of scala-js :
The Scala implementation you found doesn't work in Scala.js because of this:
java.nio.ByteBuffer.allocate(8).putLong(r).array().takeRight(3)
ByteBuffer.putLong() is not (yet) implemented.
Note however that this line is super inefficient to produce the desired result. It is much better to do
Array((r >> 12).toByte, (r >> 6).toByte, r.toByte)
It's even shorter ^^
But yes, anyway btoa is the way to go in browsers, unless you want a cross-compiling source.

In case you were interested in the javascript benchmark of your library, see

https://groups.google.com/forum/#!msg/scala-js/En8WL-WIY_Q/147WEVIIOKAJ
The analysis is brutally accurate.  This implementation is is very inefficient and totally unacceptable for bulk encoding or decoding.  I'll look into producing a scala-js compatible version but converting the implementation to bit - twiddling arrays is out of scope for me.

The conversion to  is complete except for a snafu involving cross compiling in js and the jvm.  I'll push the update once I've got the tests running in js.  I also made a note about performance in the read me and implemented Sebastian's array output suggestion.


Add Support for Styled Components v6

Describe the bug
Now that sanity-ui supports styled components v6 and is the default in a new studio template, getting peer dependency issue.

Any updates on this?

Resolved in https://github.com/sanity-io/sanity-plugin-mux-input/releases/tag/v2.3.0


Update facter version to support Mariner

Minimum version of facter that supports Mariner facts.
https://puppet.atlassian.net/browse/FACT-3142

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[ ] The toolchain has been rebuilt successfully (or no changes were made to it)
[ ] The toolchain/worker package manifests are up-to-date
[ ] Any updated packages successfully build (or no packages were changed)
[ ] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[ ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[ ] All package sources are available
[ ] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[ ] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[ ] All source files have up-to-date hashes in the *.signatures.json files
[ ] sudo make go-tidy-all and sudo make go-test-coverage pass
[ ] Documentation has been updated to match any changes to the build system
[ ] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[ ] Ready to merge

Summary

The version of facter that currently ships with Mariner does not set the correct facts. Bumping the version to the minimum supported version that will expose the correct Mariner facts for puppet
Change Log

Bump version of facter to 3.2.13

Does this affect the toolchain?

NO
Test Methodology

Was hoping to use buddy build system to test

Buddy Build Passed: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=569459&view=results


Incredibly sticky quick open from very prominent action

Clicking this button will open the layout quick open menu, which is incredibly sticky. Suggestions to make it less sticky:

Clicking the button should always toggle visibility, instead of always making sure it's visible
Clicking outside the quick open should close it, while clicking actions within it shouldn't

See #145020

can take the first piece

resolving this to https://github.com/microsoft/vscode/issues/145376


Replace our StackConfig with stacks BuildConfig

Change our own type for parsing stack.yaml with Stack.Config.BuildConfig to make sure it's always parsed correctly.
This uses stack master since types have changed significantly.
./script/travis.sh passes, I still have to test on a bigger project.
Thanks to @jmitchell and @k0001 for help!
PS: I next plan to remove the rest of subprocess calls to stack.

This is great--thank you!
I've noticed a minor regression where passing a relative path instead of a remote git URI results in an error:
$ stack2nix-stack .
Ensuring cabal2nix version is >= 2.2.1 ...
Ensuring git version is >= 2 ...
Ensuring cabal version is >= 1 ...
stack2nix: InvalidAbsFile "./stack.yaml"

Otherwise, I haven't found any behavioral differences with a larger project like cardano-sl. My testing has covered with and without the --test and --haddock flags.

I have verified via stack2nix . and it works. Waiting on the CI.


Autocomplete Panel width

Bug, feature request, or proposal:
A Way to set the panel width in autocomplete
What is the expected behavior?
The panel width could have a property to change the panel-width.
What is the current behavior?
The panel width isn't wide enough, so the content doesn't fit in it. My project is hosted in heroku, so it compiles the project remotely and donwload the material fonts also remotely (so I can't customize de component scss)
What are the steps to reproduce?
Just modify the example of the material.angular.io, changing the width of  to 100% and modify one of the states name to a longer name.
Plunker Link: https://plnkr.co/edit/nKgx04MYK0q0xhS1yfAZ?p=preview
In plunker, just click on the input to see that the panel is too short to show the first name, even if there's a lot of space in the window.
Which versions of Angular, Material, OS, browsers are affected?
@angular/cli: 1.0.0-beta.32.3 [1.0.0-beta.30]
node: 6.9.5
os: win32 x64
@angular/cli: 1.0.0-beta.32.3
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/flex-layout: 2.0.0-beta.5
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/compiler-cli: 2.4.8
Is there anything else we should know?
I'm currently setting the encapsulation to None in the host component to fix it, but I don't know if this is the recommended way to make the things right.

@julianobrasil for now, you could add this to your global stylesheet
.mat-autocomplete-panel {
  max-width: none !important;
}

The problem seems to be that the autocomplete is including styles from the menu, which has a max-width
// autocomplete.scss
.mat-autocomplete-panel {
  @include mat-menu-base();
  ...
}

// _menu-common.scss
@mixin mat-menu-base() {
  @include mat-elevation(8);
  min-width: $mat-menu-overlay-min-width;
  max-width: $mat-menu-overlay-max-width; // is 280px
  ...
}

@willshowell, thanks for the reply. I'll do as you said for now and wait for the next beta.


Fix margins on color schemes settings page

Summary of the Pull Request
This increases the left and right margins of the contents of the color schemes settings page so that they line up correctly with the page header.
References and Relevant Issues
Addresses #16290.
Detailed Description of the Pull Request / Additional comments

Replaced the Grid with a StackPanel to be consistent with other settings pages

Validation Steps Performed
Visually verified the changes.
Before:

After:

PR Checklist

[x] Closes #16290
[ ] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

Thanks! Would you mind testing this at different window sizes? There's a breakpoint between small/medium/large that results in slightly different margins on these components.

Switching this PR to Draft for now since the behaviour at the breakpoint is indeed not 100% right. Will check if I can find a proper fix for it.


ToggleButtonGroup does not keep track of selected item, when value is an object

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When using state that is an object (not a string or number), ToggleButtonGroup does not track the selected item correctly. Perhaps the comparison should be a callback, passable via props?
Expected Behavior 🤔

Values should only be added to the list once, and items should be removed when clicked while selected.
Perhaps the comparison could be determined via a callback passed via props.
Steps to Reproduce 🕹
https://codesandbox.io/s/material-demo-gun9b
This is an example that does not use the exclusive prop.

Click the buttons
Observe in the console that the state list keeps growing with each click.
Also observe the buttons do not display as selected. (Overriding the ToggleButton selected prop to compare objects fixes this, but does not fix the state list growing in size.)

Context 🔦
I am attempting to keep track of state using the ToggleButtonGroup and ToggleButton components that is more complex than just a number or string.

Your Environment 🌎

Tech
Version

Material-UI (lab)
v4.0.0-alpha.48

React
16.13.1

Browser
Chrome (latest)

TypeScript
No

I found a workaround, but it does not involve letting ToggleButtonGroup manage state. It makes this more like a controlled component I suppose.
    <ToggleButtonGroup aria-label="Selected Items">       { items.map((item, i) => {           return (             <ToggleButton value={item}                           selected={selectedItems.some(x => x.id === item.id)}                           onClick={() => handleItemClick(item) }                           aria-label={item.name}>                 {item.name}             </ToggleButton>           )         })       }     </ToggleButtonGroup>
Then all state management is done in handleItemClick().

Given that we have a similar description message for the Select component, I propose we apply here it too:
diff --git a/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js b/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js
index e7db5b9ef..9100e2fac 100644
--- a/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js
+++ b/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js
@@ -152,6 +152,8 @@ ToggleButtonGroup.propTypes = {
   /**
    * The currently selected value within the group or an array of selected
    * values when `exclusive` is false.
+   *
+   * The value must have reference equality with the option in order to be selected.
    */
   value: PropTypes.any,
 };

@liberza What do you think of a diff? Do you want to work on a pull request? :) Regarding your problem, it's expected, you create new objects at each render.

Yes that's fine by me. Do you mean a pull request to add an example of how
to do this, or just to update the documentation?
On Wed, Apr 8, 2020, 6:08 PM Olivier Tassinari<EMAIL_ADDRESS>wrote:

Given that we have a similar description message for the Select component,
I propose we apply here it too:
diff --git a/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js b/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js
index e7db5b9ef..9100e2fac 100644--- a/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js+++ b/packages/material-ui-lab/src/ToggleButtonGroup/ToggleButtonGroup.js@@ -152,6 +152,8 @@ ToggleButtonGroup.propTypes = {
/**
* The currently selected value within the group or an array of selected
* values when exclusive is false.+   *+   * The value must have reference equality with the option in order to be selected.
*/
value: PropTypes.any,
};
@liberza https://github.com/liberza What do you think of a diff? Do you
want to work on a pull request? :) Regarding your problem, it's expected,
you create new objects at each render.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/issues/20471#issuecomment-611219709,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCCD6GIJ4N5W2BBCR44GXTRLTYU3ANCNFSM4MEG2ZVA
.

@liberza I think that an update of the description of the prop will be enough. Like we have here:
https://github.com/mui-org/material-ui/blob/e9eb2df4dc87707f47f5383976e9ec7ec6510678/packages/material-ui/src/Select/Select.js#L218-L221

Is this issue fixed?  It is marked Closed but it still exists. I'm using mui/material 5.2.6  with React 17.0.2 .  In my case,  I'm needing to save the button state in the parent when the component is unmounted and supply the initial state when user navigates back to the component.  It only works if the object value is JSON stringified (note the JSON.stringify is the value attribute of ToggleButton) .  Although this hack works, it is not ideal since the object array is used elsewhere in my app.
I recreated in CodeSandbox , https://codesandbox.io/s/dazzling-lake-dnwir?file=/src/ToggleButtons.js

You can use an 'exclusive' keyword in ToggleButtonGroup it seems to fix the issue.


Definition Objects Array Enhancement

Hi there,
I'm using your package and I would like to suggest an idea. Could it be possible to declare one array object instead of:
questions:{
	type:[Object],
	minCount: 1,
	maxCount: 4,
},
'questions.$.a':{
	type: String,
},
'questions.$.b':{
	type: String,
},
'questions.$.c':{
	type: String,
},
'questions.$.d':{
	type: String,
},
'questions.$.answer':{
	type: String,
},

... declare nested syntax like this example:
questions:{

	type:[Object],
	minCount: 1,
	maxCount: 4,

	elem:{
		'a':{
			type: String,
		},
		'b':{
			type: String,
		},
		'c':{
			type: String,
		},
		'd':{
			type: String,
		},
		'answer':{
			type: String,
		},
	}

}

'elem' can be anything... It's just a point of view I find it more obvious to understand like this.
What do you think?

I prefer the flat structure. If you don't need any advanced SS features, you can write a JSONSchema, which is nested, and then use https://atmospherejs.com/bshamblen/json-simple-schema to convert it to a SS.


udev-gothic-nf: 1.3.1 -> 2.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yuru7/udev-gothic/releases.
meta.description for udev-gothic-nf is: Programming font that combines BIZ UD Gothic, JetBrains Mono and nerd-fonts
meta.homepage for udev-gothic-nf is: https://github.com/yuru7/udev-gothic
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.0 with grep in /nix/store/kwqgr4ma39hrxdxa0r68gph6lg687bwx-udev-gothic-nf-2.0.0
found 2.0.0 in filename of file in /nix/store/kwqgr4ma39hrxdxa0r68gph6lg687bwx-udev-gothic-nf-2.0.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

udev-gothic-nf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kwqgr4ma39hrxdxa0r68gph6lg687bwx-udev-gothic-nf-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A udev-gothic-nf https://github.com/r-ryantm/nixpkgs/archive/8b9ca438650a5ab1d5d4f5853332286bc873d328.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8b9ca438650a5ab1d5d4f5853332286bc873d328#udev-gothic-nf

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kwqgr4ma39hrxdxa0r68gph6lg687bwx-udev-gothic-nf-2.0.0
ls -la /nix/store/kwqgr4ma39hrxdxa0r68gph6lg687bwx-udev-gothic-nf-2.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

udev-gothic-nf

Maintainer pings
cc @haruki7049 for testing.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 335419 run on aarch64-darwin 1

1 package built:

udev-gothic-nf


[SPARK-24997[SQL] Enable support of MINUS ALL

What changes were proposed in this pull request?
Enable support for MINUS ALL which was gated at AstBuilder.
How was this patch tested?
Added tests in SQLQueryTestSuite and modify PlanParserSuite.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Test build #93958 has started for PR 21963 at commit 1dd61a2.

Probably, IMO we need a new jira for this.

@maropu OK. I will create a new JIRA. Actually i missed it in original PR. @gatorsmile had put a code review comment to add "MINUS" in the documentation that got me to test the scenario :-)

Test build #93958 has finished for PR 21963 at commit 1dd61a2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93958/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1632/
Test PASSed.

Test build #93972 has started for PR 21963 at commit 1dd61a2.

Test build #93972 has finished for PR 21963 at commit 1dd61a2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93972/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1651/
Test PASSed.

Test build #93994 has started for PR 21963 at commit 1dd61a2.

Test build #93994 has finished for PR 21963 at commit 1dd61a2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93994/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1690/
Test PASSed.

Test build #94045 has started for PR 21963 at commit a126a14.

Test build #94045 has finished for PR 21963 at commit a126a14.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94045/
Test PASSed.


how to use it in an axios interceptor

I'm a newbie for Vue. And I want to make an uniform error handler and toast user something. But the this.$h throw the error "Cannot read property 'dialog' of undefined". So how can I use this plugin in a standalone js file?
Really really need your help, thx.

First, make sure this points to the Vue instance.
I recommend using CommonJS module to install vue-hawesome-modal.


IntegrationEvent Request: Please Add OnBeforeInsertServComponentFromBOM() in Codeunit "ServComponent-Copy from BOM"

IntegrationEvent Request
Please Add in Codeunit "ServComponent-Copy from BOM" in OnRun() trigger:
Signature:
OnBeforeInsertServComponentFromBOM(var ServItemComponent: Record "Service Item Component"; BOMComp: Record "BOM Component"; Item: Record Item)
Place in Code:
....
ServItemComponent."Description 2" := Item."Description 2";
ServItemComponent."From Line No." := 0;
OnBeforeInsertServComponentFromBOM(var ServItemComponent: Record "Service Item Component"; BOMComp: Record "BOM Component"; Item: Record Item)
if not ServItemComponent.Insert() then
ServItemComponent.Modify();
....

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


parameter input + sample grid + calculation without classes

Start calculation with button in formular and run cellular automaton with sample grid (10x10 cells)
doing calculations without classes

nice


Optionally install and configure slurm spank x11 plugin

Thanks to Ville Rantala, these are the manual steps:

yum -y install slurm-spank-x11 on login, install and computes
yum -y install xauth on login and computes

setup plugstack.conf to include plugstack.conf.d (and setup x11.conf there) in /etc/slurm on login, install and computes

More tasks added in 931d92643cb1190cda9a0e48559fcddf93e320dd to common.yml - meaning if plugstack and x11spank are True it will install slurm-spank-x11 and xauth on all the servers.
Three new variables and their defaults:

slurm_plugstack: False
slurm_x11_spank: False

slurm_spank_x11_packages:
  - xauth
  - slurm-spank-x11


feat(form): form enhancement with trim and cleave

What:

Form enhancement with trim and cleave

add trim directive for username to trim value on input
add a phone number field
add cleave directive for phone number and birthday auto-format on typing

Issue number: N/A

Hi @tomastrajan ,
I'm not sure if this kind of new feature is welcome. The trim function was built-in for Angular.js 1.x, but it's missing in Angular. I think it's essential for data-binding.
And for some reason, the exact lines diff of the i18n json files are not very clearly displayed. There's only one line added for each json file, but the diff page shows each whole file in diff.
If you need me to add more demo in the examples or some description for the docs, please let me know.
Thanks.


MI-111 adding contribution, code of conduct, PR template docs

Adding basic contribution notes :)

@ryanrixxh I think this is the right direction for Aligent but want to be clear about what we're signing ourselves up for with the code of conduct in particular.

@TheOrangePuff @tvhees
As per our discussions and fix-ups necessary for an initial code of conduct / contribution guideline.
For anything addressing more philosophical concerns in this documentation I leave it to the principals to discuss and determine how best we move forward with conduct and contribution guidelines.


Avoid invoking internal functions in the demo programs

Some of the demo applications are using internal functions such as _twin_widget_init, which should never be visible to Mado users. Sooner or later, the header twin_private.h should be moved from the include directory to the src directory, where the implementation parts are located. Known applications that should be changed include apps/clock.c, apps/line.c, and apps/spline.c.

All file in /src directory can use functions declared in twin_private.h, but all source file in /apps are not allowed to use it. Is my understanding correct ?

All file in /src directory can use functions declared in twin_private.h, but all source file in /apps are not allowed to use it. Is my understanding correct ?

Yes, it is intentional.


Nightmare Zone Timer request

Can we get a custom timer plugin (or addition to NMZ plugin) that we can set time intervals for notifications? Would be useful to be able to set a timer for overloads and a timer for 50 second rapid heal flick for Nightmare zone.

There are open issues for both of these requests.


Missing declared license

Type: Missing
Summary:
Missing declared license
Details:
Missing license
Resolution:
BSD-3-Clause: https://github.com/numpy/numpy/blob/v1.17.3/LICENSE.txt
Affected definitions:

numpy 1.17.3

@geneh - please resolve the conflicts.  Thanks!!

@geneh - please resolve the conflicts. Thanks!!

Done!


Broken inherited colors in Taverly Dungeon

Describe the bug
These rocks aren't meant to be green. Inheriting colors from bridge tiles is likely what's broken. (The object ID is 320)
Screenshots

Should look like:

Fixed by https://github.com/117HD/RLHD/commit/048f0496e3b3517a80a8e310361975da059c3ed3


added the ability to set MessageConvertors on the MockMvcTarget insta…

Thanks for the PR.

@uglyog This is the first time I have contributed to this repo so I have what may be a dumb question for you. When will there be a consumable artifact for au.com.dius:pact-jvm-provider-spring_2.11 that includes my changes?

I've released 3.5.6 with your changes: https://github.com/DiUS/pact-jvm/releases/tag/3_5_6


add note in configuration docs

Summary
As requested in https://github.com/facebook/jest/issues/5974 I added to the docs a note to reflect the fact that the test files regex is tested against the absolute path.
Test plan
I actually opened this PR to understand how can I test changes in the docs. I would love to get such help.

Codecov Report

Merging #6489 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6489   +/-   ##
=======================================
  Coverage   63.48%   63.48%
=======================================
  Files         227      227
  Lines        8697     8697
  Branches        4        4
=======================================
  Hits         5521     5521
  Misses       3175     3175
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d4370...4c5703c. Read the comment docs.

You can start the docs site locally by running yarn start in the webiste/ directory


Trivy-Operator CRDs out-of-sync if deployed using ArgoCD

What steps did you take and what happened:

I deployed the trivy-operator helm chart using an ArgoCD application and noticed a small issue.
The trivy operator get's installed and it's working perfectly, but the trivy-operator CRDs are staying out-of-sync in ArgoCD.
This is because the categories: field of all trivy-operator CRD is an empty list and get's dropped by Kubernetes.
While this might not be an issue for trivy-operator and kubernetes, it is for argocd that sees a diff between the desired state and the live state.

What did you expect to happen:

I expect to have all trivy-operator CRD in sync after the helm chart deployment.

Anything else you would like to add:

Coming back with a PR to fix

[Miscellaneous information that will assist in solving the issue.]
Environment:

Trivy-operator version (use trivy-operator version): v0.0.3
Kubernetes version (use kubectl version): v1.20.15-eks (aws eks)
OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): archlinux

Just realized that this project is the follow-up to starboard.
I'm the author of the original issue #1021 on Starboard.
I will re-open the PR here.
Maybe you should display a warning banner in the starboard README.md to redirected people to trivy-operator :wink:


Development bugfix

Tests are passing on my computer now - had to fix some string parsing details inside the code.  TravisCI is still not working...

This appears to be a PVLib version issue - there's a to_datetime error that we get with PVLib 0.7.1 but not for PVLib 0.8.0

Tests are passing.  I'm merging this.


check_jvps, like check_grads but without vjps/transpose

This test utility follows like the check_grads but for checking higher order jvps directly in the situation where vjps or transposes haven't yet been defined.
I've "tested" this locally, but I don't know if jax test_utils have tests themselves... If so let me know and I can commit a test for this.

Signed CLA :o

Not sure what's up with the Travis CI failures; it seems unlikely that those stem from the changes here.
However, I think this might be equivalent to calling check_grads with modes=['fwd'], which only checks forward-mode rather than mixing in reverse-mode. WDYT?

Almost forgot to say: thanks for the PR! I hope it's the first of many :)

@mattjj Was not aware of modes=['fwd']!

Do you have an example of how I can specify this?

IIUC these two calls are equivalent:
check_jvps(f, args, order, atol, rtol, eps)  # function in this PR

check_grads(f, args, order, ["fwd"], atol, rtol, eps)  # from jax.test_util import check_grads

But don't take my word for it, look at the code for check_grads and see if you agree! :)

Ah! I see that is in master, but I was editing the source pip installed which didn't have a modes argument.

If you're badass enough you can do
git clone https://github.com/google/jax.git
pip install -e jax

That way pip will symlink the package files from the git repo into your site-packages.

Closing this because my understanding is check_grads with modes=['fwd'] covers it.


React DnD does not provide a default export

This seams it can trigger error in completely unrelated third party module like for example "mapbox-gl" in my case.
https://github.com/gaearon/react-dnd/blob/master/src/index.js#L7
Error happens when instantiating map otherwise everything works fine. The whole drag and drop also works fine in another page. And if I disable drag and drop then map works ok also.
Error happens when dnd context is set and instantiating unrelated code like map in my case:
// root component
import { DragDropContext } from 'react-dnd';
import HTML5Backend from 'react-dnd-html5-backend';
export default DragDropContext(HTML5Backend)(Root);

// unrelated code without drag and drop map component
   map = new mapboxgl.Map({
    ...
    });

Did anyone came across something similar? Anyone has a suggestion to a quick fix, workaround?
Cheers

Please set a breakpoint during the warning and check the stack trace. File an issue with the relevant project that tries to access the default export (which does not exist).

It may be for the best but this is a bit annoying and this message is deceiving...

What is deceiving about it? Have you checked why this other library you are using triggers it? It should be fixable on their side.

With the third party library Its a bit complex of webpack, webworkify-webpack and mapbox-gl and I am having problem figuring out which module and why is giving me trouble.
Why the message is deceiving: Its talking about how to correctly include dnd module, submodule while the real problem is miles away. I think the module should mind itself as much as possible.

Problem could be also context injection into child component or something related to serverside render.

If I comment out dnd stuff below:

//import { DragDropContext } from 'react-dnd';
//import HTML5Backend from 'react-dnd-html5-backend';

const Root = React.createClass({
  displayName: 'Root',

  propTypes: {
    children: React.PropTypes.any
  },

  render() {
    return (
      <App centered={false}>
        {this.props.children}
      </App>
    );
  }
});
// export default DragDropContext(HTML5Backend)(Root);
export default Root;

Then build it (server, client)
Then uncomment the stuff from above and just build the client code, then everything works. I can also drag and drop over the map. etc...

I don't know why, but it looks like DragDropContext somehow trips webworkify-webpack while instantiation mapbox.Map if its also server side rendered first.

I didn’t even know webworkify-webpack exists :-). Apparently here is the access: https://github.com/borisirota/webworkify-webpack/blob/2b7a1e9e82b889aaa17e4d5e40e034bd51b140fa/index.js#L23.
I don’t mind removing the warning if it causes much trouble. I’d accept a PR removing it.

I have also made pull request on webworkify-webpack to check for undefined.
Thank you @gaearon for your work!
Cheers

Fixed in 2.1.3, thanks for the PR!

Thank you for your help!


Jesse: Watch AI[\W_]+Seed[\W_]+(Phrase[\W_]*+)?Finder

Jesse requests the watch of the watch_keyword AI[\W_]*+Seed[\W_]*+(Phrase[\W_]*+)?Finder. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Spevacus in Charcoal HQ


Use strip_include_prefix and include_prefix to avoid rewriting QUICHE platform include paths

Use strip_include_prefix and include_prefix to avoid rewriting QUICHE platform include paths
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @danzh2010

@danzh2010 Please take a look. Using Bazel's include_prefix and strip_include_prefix we are able to get rid of (most of) the include rewriting in quich.gencmd. Once more of the quiche platform refactoring is finished, we'll be able to get rid of more of it.
FWIW, the clang-tidy errors seem to be spurious ala the logging.h tidy errors last week. (I think our clang-tidy handling doesn't understand strip_include_prefix)

@danzh2010 Please take a look. Using Bazel's include_prefix and strip_include_prefix we are able to get rid of (most of) the include rewriting in quich.gencmd. Once more of the quiche platform refactoring is finished, we'll be able to get rid of more of it.
FWIW, the clang-tidy errors seem to be spurious ala the logging.h tidy errors last week. (I think our clang-tidy handling doesn't understand strip_include_prefix)

This is a brilliant idea! As this PR removes special handlings in .gencmd, it will greatly simplify Google's envoy import as well.

Awesome! Care to approve?

cc: @envoyproxy/dependency-shepherds can you review for the bzl changes?

/lgtm deps

@itayd do you have any idea why repokitteh is saying: no relevant owners for "deps"?

@itayd do you have any idea why repokitteh is saying: no relevant owners for "deps"?

Oh, @htuch figured out that there are no longer any files which needed deps approval. sorry for the noise!

/assign @alyssawilk

No objections to this one but can you put a bit more detail in the description about what the functional impact is?

Done.

And is this the one where we expect to force merge over clang tidy?

Yup, much like logging.h it seems clang-tidy has issues with strip_include_prefix


fix: use mocked time to solve happo diffs

ZH: https://github.com/bcgov/cas-cif/issues/929

@BCerki after looking at happo diffs, I found an issue with the mocked time I've implemented; I've added mocked time as today but Complete badge is showing yesterday. I think I need to change the mocked time to a full timestamptz.


New release

Hey,
Thanks for your amazing work. Is there an ETA when you will craft a new release/tag so that we can use this repo with dep or other tools dependend on git tags?
Best,
Michael

This would be great.

@chzyer do you have any plans to do a release? We are pretty related to it?

@chzyer do you have plans to do a release? We pretty related to it.


new docs break firefox/Dark Reader

My goal is to read light-text on a dark background, without losing the syntax highlighting colors in the code documentation.
I could do this with the Firefox "Dark Reader" extension with the old docs at raku.org, but the new setup breaks it for some reason, even though it continues to work with raku-new.finanalyst.org.
It seems strange that something about the current site setup is working differently than finanalyst.org, and this might be worth looking into.
I'm attempting to attach some screenshots, but the odds that I can drag&drop files successfully seems low.   As expected, that failed.  I pushed the  images out to my old website instead (I should open an issue, "still possible to use github with linux"):
White backgrounds at main site, in spite of Dark Reader:

The finanalyst site shows how Dark Reader is supposed to work (and used to work, with the main site):

@doomvox could you please look at docs-dev to see if the problem persists? docs-dev is the site where the latest changes to the tooling are tried out. Only when everyone is happy does the newest build get pulled into docs.raku.org.

I see the same behavior with docs-dev.
This:
https://docs.raku.org/routine/MAIN
Looks much like:
https://docs-dev.raku.org/routine/MAIN

@doomvox Since you raised the issue, I have been battling with highlighting in Code blocks. The problem arose because of the interaction between C<> or B<> markup in Code blocks and the syntax highlighter. If you look at the operators page in new-raku, you will see towards the bottom, Bolding gets switched on, but is not cancelled.
However, just to check. Have you tested new-raku recently?  I ask because there is an implementation tweak to get unicode named pages in the url. To do this, I now have the files served by Caddy behind an Apache reverse proxy. Previously new-raku was served directly by Apache, while docs-dev is served by Caddy.
Also please give a list of steps to get the Dark-Reader addon, and then how to switch on the addon. I use Firefox, but not the Dark-Reader, and I want to try to duplicate the behaviour you have.

@doomvox Would you please look at the new user interface at new-raku eg operators

@doomvox Would you please look at the new user interface at new-raku eg operators

Dark Reader does not seem to work there.
However, it is working with:
https://docs-dev.raku.org/
On 8/12/23, Richard Hainsworth @.***> wrote:

@doomvox Would you please look at the new user interface at new-raku eg
operators
--
Reply to this email directly or view it on GitHub:
https://github.com/Raku/doc-website/issues/252#issuecomment-1675900552
You are receiving this because you were mentioned.
Message ID: @.***>

@doomvox please check this again. BUT first make sure that the local storage cleared.

The local storage saves your theme preference, and is saved for each domain. This may be why you are getting inconsistent results for essentially the same HTML.

Okay, as far as I can tell I don't have any local cached data for the site, but I find that if I open a very old tab again I get a light background still, but if I refresh the page Dark Reader works.
Dunno what's going on, but I'd tentatively say this is fixed, Dark Reader works now, so I'll close this.

SO, let's close it.


Add a timeout interop spec

This looks great @iamqizhao. I made comments on just some small details.

all addressed. PTAL.

It looks good to me. Let's remove response_type before I merge though.

done.

err, forgot to remove response type server feature. 1 sec.
On Thu, May 14, 2015 at 3:39 PM, Eric Anderson<EMAIL_ADDRESS>wrote:

It looks good to me. Let's remove response_type before I merge though.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/1599#issuecomment-102189707.

k, done.
On Thu, May 14, 2015 at 4:02 PM, Qi Zhao<EMAIL_ADDRESS>wrote:

err, forgot to remove response type server feature. 1 sec.
On Thu, May 14, 2015 at 3:39 PM, Eric Anderson<EMAIL_ADDRESS>wrote:

It looks good to me. Let's remove response_type before I merge though.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/1599#issuecomment-102189707.

@iamqizhao, ah, good. I'd have missed the server feature section. Thanks!


Docker for mac fails on: docker-compose up ./docker-compose.proxy-example.yml

Might be my lack of experience, but cant get docker-compose up to start the proxy example.
I am using the Docker for Mac:
Version 1.12.0-rc2-beta17 (build: 9779)
Googling around for solution found a few red herrings. So posting here to see if anyone sees what i am doing wrong.
Heres my attempt:
x-MacBook-Pro:examples apple$ pwd
/Users/apple/workspace/go/src/bitbucket.org/joe/md-x/_docs/Tech/Docker/alpine-caddy/examples
x-MacBook-Pro:examples apple$ ls -al
total 24
drwxr-xr-x   5 apple  staff  170 Jul  5 14:18 .
drwxr-xr-x  19 apple  staff  646 Jul  5 14:18 ..
-rw-r--r--   1 apple  staff  727 Jul  5 14:18 Caddyfile.proxy.example
-rw-r--r--   1 apple  staff  240 Jul  5 14:18 docker-compose.example.yml
-rw-r--r--   1 apple  staff  597 Jul  5 14:18 docker-compose.proxy-example.yml
x-MacBook-Pro:examples apple$ docker-compose up ./docker-compose.proxy-example.yml
ERROR:
        Can't find a suitable configuration file in this directory or any
        parent. Are you in the right directory?

        Supported filenames: docker-compose.yml, docker-compose.yaml

try docker-compose -f docker-compose.proxy-example.yml
Do this inside of the same directory that the docker-compose.proxy-example.yml file exists :). Let me know if you have any more questions. (Also note that the example files may not bring fully working functionality out of the box, as they are meant to be more of a guidance in writing your own.

@Skilgarriff
i am doing it in the same dir, but no luck.
When i run it nothing at al happens except the standard help output. Its not saying that docker-compose file does not exist at least now that the -f (--file) was added to the command line.
my versions -
These versions are new. The standard docker for Mac update ran on my Macbook tonight.
DO you have the same version i wonder ?
Docker for mac version 1.12.0-rc3-beta18 (build: 9969)
Docker version 1.12.0-rc3, build 91e29e8, experimental
Docker-compose version 1.8.0-rc1, build 9bf6bc6

got more luck with the "up" at the end
but now got a "not a directory"
docker-compose -f docker-compose.proxy-example.yml up
Creating network "examples_frontend" with the default driver
Pulling example-blog (zzrot/alpine-ghost:latest)...
latest: Pulling from zzrot/alpine-ghost
6d6a6a7dae29: Already exists
417f0c1a928b: Pull complete
9d7dc17b812e: Pull complete
36ee4c5a2a05: Pull complete
c601005fff6c: Pull complete
3555209b4f0f: Pull complete
372d4ccc331d: Pull complete
Digest: sha256:fe7fc240d9888ea7e39b4b921cdfc11cf39b3f712795e20cde4362336b760437
Status: Downloaded newer image for zzrot/alpine-ghost:latest
Creating examples_example-server_1
Creating examples_example-blog_1
Creating examples_proxy_1

ERROR: for proxy  oci runtime error: rootfs_linux.go:53: mounting "/var/lib/docker/aufs/mnt/d31dedf05fe66093ce7fa18a3e711847875687343fc6b90af00e7b3ab6733b81/etc/Caddyfile" to rootfs "/var/lib/docker/aufs/mnt/d31dedf05fe66093ce7fa18a3e711847875687343fc6b90af00e7b3ab6733b81" caused "not a directory"
ERROR: Encountered errors while bringing up the project.
x-MacBook-Pro:examples apple$

The simpler example gets the exact same error, so thats at least consistent.
Seems to be a path issue.
docker-compose -f docker-compose.example.yml up
Creating examples_web_1

ERROR: for web  oci runtime error: rootfs_linux.go:53: mounting "/var/lib/docker/aufs/mnt/60945ce565329512c760503a6a5fd9cc72efc9c564192d8056fe1140d659b2bb/etc/Caddyfile" to rootfs "/var/lib/docker/aufs/mnt/60945ce565329512c760503a6a5fd9cc72efc9c564192d8056fe1140d659b2bb" caused "not a directory"
ERROR: Encountered errors while bringing up the project.
x-MacBook-Pro:examples apple$

i got the compose working:
docker-compose -f docker-compose.example.yml up
Creating examples_web_1
Attaching to examples_web_1
web_1  | jack is incompatible with use of CloseNotifier in same ServeHTTP call
examples_web_1 exited with code 137

I did not quite understand the readme, regarding copying the files into the examples dir.
Once i copied the public folder (with the index inside) and the Caddfile, into the examples dir, everything worked.
I am pretty new at this, but learnt allot. thanks

I'm having this same issue oci runtime error specific to mounting the Caddyfile in the container.
What ended up being the solution for you?
The error for me:
ERROR: for caddy  Cannot start service caddy: invalid header field value "oci runtime error:
container_linux.go:247: starting container process caused \"
process_linux.go:359: container init caused \\\"
rootfs_linux.go:53: mounting
\\\\\\\"/Users/jonbanashek/Projects/fs/lh/Caddyfile\\\\\\\" to rootfs
\\\\\\\"/var/lib/docker/aufs/mnt/e501fe2a9cbf5a64c913592862204dc5d6d31856f69ec43b164c46355ab23776\\\\\\\"
at \\\\\\\"/var/lib/docker/aufs/mnt/e501fe2a9cbf5a64c913592862204dc5d6d31856f69ec43b164c46355ab23776/etc/Caddyfile\\\\\\\"
 caused \\\\\\\"not a directory\\\\\\\"\\\"\"\n"

It seems as though it can't find the /etc directory on the docker host.
This is when using docker-compose to deploy to a digitalocean droplet (configured via docker-machine) fyi.
Caddyfile:
www.mysite.com, mysite.com {

	proxy / web:80 {
		proxy_header Host {host}
		proxy_header X-Real-IP {remote}
		proxy_header X-Forwarded-Proto {scheme}
	}

	header / {
		#Include any headers for your site here
	}

	gzip

	tls<EMAIL_ADDRESS>}

Any ideas?


[GH Action] Add Copy Configs File Step To Pull Request Workflow

Describe the bug A clear and concise description of what the bug is.
Currently the GH action that runs tests on pull requests is breaking. This is because the tests depend on a configs.ts file which is not generated during this test.
To Reproduce Steps to reproduce the behavior:
Type run-tests on any pr.
Expected behavior A clear and concise description of what you expected to
happen.
The test should run.
The solution is simple. Just copy the 2 lines from the main tests.yml

#1825


High - Search bar not working fully.

Hey guys,
I had one of my contacts checking the site who has the last name "Parker", and he said that when he searched his last name, it pulled up nothing related to that request. If there are no Parkers on the list, then it should reflect a "There are no results found with [insert request here]"
I checked the data, and there should be at least 4 Parkers on the list that should have pulled up.
This is a high priority as we need to have the search working accurately.
Thank you so much for all you guys do,
Ian

Hey @KC135Q & @gitKendra 2 things with this one.
1 - The search options should not be pulling up a street address at all. We should only have 3 things pulled up. Name, City or Zip. Anything else being pulled up should not happen.
2 - In the search bar, it already shows "Search by name and city" as search parameters, but can you change that to say "Search by Name, City or Zip"?

Take street address out of the search:

Name, City or Zip.

Back to Redis: https://github.com/NodeRedis/node-redis

Confirmed the updates are working. Closing the issue.


feat: adapt form to be used in edit

📝 Changed routes:

/edit/[name]

(view full size)

Commit<PHONE_NUMBER>776f47e13434da6d0c67ff0341631f (https://madewithsupabase-3yg1y6tzu-zernonia.vercel.app).


russian data

Hi,
With your repo, I want to create own model to do summarization article to the title in my data.
How u think, when I have done this with your repo, the result had been similar?
Plus, how I should prepare my data?

Please check this repository for data preprocessing. Feel free to create PR when you're done :)
Thanks!

closing due to no further discussion


convform jquery first message do not load

pluign , it works with but first message do not load. I must type anything in Textarea then clear it , then the first message load.
this happens only with first message

nothing


Provide jstree-3.3.0-patched.js for download

By enabling dnd, it is necessary to use jstree-3.3.0-patched.js in order to make it work properly with jstreegrid. It would be greatly appreciated if this could be provided.

I had thought @vakata had fixed the issue in jstree, but just in case, here it is.
https://gist.github.com/deitch/a6926a4742bb0fc4979d87b168bec8ac

Yeah, looking at jstree-3.3.1, it looks like the patch is in there.


Backport Wireguard ListenPort fix in systemd

In systemd 242 (in flatcar edge release 2261.99.0) there is a bug that the listen port of wireguard is always set randomly. This has been fixed upstream.
See: https://github.com/systemd/systemd/issues/12377

Yes exactly.
Systemd v242 has the bug w.r.t. Wireguard.
We noticed the issue in the past, and created a PR https://github.com/flatcar-linux/systemd/pull/5.
We will merge the PR, and create a new Edge release. Then it will be fixed.
However, backporting every patch is not ideal.
An underlying issue is that the systemd repo in Flatcar Linux is not automatically synchronized with the upstream systemd-stable repo. That has been always the case since the beginning of Container Linux. That's basically why such bug fixes are missing.
We are working on a new workflow to make it synced.

@dongsupark thanks for the detailed explanation. Sounds good :+1:

Edge 2275.99.0 was released with the backport.
Please try it out, and let us know if it fixes the Wireguard issue.

@dongsupark thanks! works like a charm.


DragQueryFileW and Others: Confusing (Wrong?) API

I wasn't sure whether this was a bug report, feature request, or just commentary, so I opted for a blank issue. Apologies if that is incorrect.
DragQueryFileW and some other APIs are defined in MSDN as taking a string pointer (LPWSTR) and length (UINT); these are essentially out buffers. Providing NULL to these APIs is semantic: it is documented as signaling a request for the requisite buffer length. When attempting to upgrade from windows crate 0.28 to 0.37 I noticed that at some point the API had changed from taking a PWSTR and length to taking a &mut [u16]. This meant there was no documented possibility of supplying NULL to query the length.
Digging through the code, however, I found that the crate translated an empty slice to a NULL, so the operation was still possible as long as I was willing to rely on implementation detail rather than documented behavior. I would suggest that if this API is sustained, that something be done to document it so that a user can feel comfortable relying on it.
It does also mean that it is effectively impossible to supply a 0-length (but not NULL) buffer to the function, which was possible prior to this change. I will grant that in the specific case of DragQueryFileW that isn't a big deal because such an argument isn't very meaningful. That said, it is behavior that deviates from MSDN. I also seem to recall noticing other APIs which were similarly changed (I apologize for not taking better note of which ones at the time); it may be that for others a 0-length non-NULL buffer makes sense.
An additional minor note: I also noticed that when converting the slice to the pointer and length for the underlying Win32 API, the length was cast in an unchecked fashion from usize to u32. If a buffer size larger than u32::MAX is supplied, it would be silently truncated. This is almost certainly a degenerate condition (at least in the specific case of DragQueryFileW), but it does creates the possibility of more behavior deviating from MSDN. For example, if a 64-bit usize of value u32::MAX + MAX_PATHis supplied (probably as a consequence of some other bug), it would be truncated to just length MAX_PATH and the API might succeed where otherwise it would have failed. This issue is hidden by the change to using a slice; in 0.28 the length was a u32, so the using code got to make the casting decision. I would suggest that if this API is sustained, the limitation in slice length is documented (and possibly an assert! or debug_assert! added) so a user knows they need to ensure the precondition.
Thanks for your time and attention!

Thanks for the feedback. The windows crate aims to provide more idiomatic bindings to the Windows API and uses the metadata provided by the Windows API to do that. The windows-sys crate, on the other hand, provides the lowest-level raw bindings to Windows APIs without any translation. If that's what you prefer, then go with the windows-sys crate.
In particular, the metadata for DragQueryFileW looks as follows:
[DllImport("SHELL32", ExactSpelling = true, PreserveSig = false)]
[SupportedOSPlatform("windows5.1.2600")]
public static extern uint DragQueryFileW([In] HDROP hDrop, [In] uint iFile, [Optional][Out][NativeArrayInfo(CountParamIndex = 3)] PWSTR lpszFile, [In] uint cch);

These attributes are derived directly from the Windows API and how it is documented, defined, and implemented to behave. As you can see, there is an explicit relationship between the third and fourth parameters. That is what the windows crate now models with a slice.
If you discover a bug, open an issue with a repro and we can get it fixed. Otherwise, this is by design. If you prefer not to have this abstraction, this same function is defined by the windows-sys crate without any translation, as you can see here.


"xlings" isn't recognized as a name of a cmdlet.

Background | 背景
OS: windows11
Describe | 问题描述
After install it by Invoke-Expression (Invoke-Webrequest 'https://d2learn.org/xlings-install.ps1.txt' -UseBasicParsing).Content, refresh powershell, type "xlings", shows:

"xlings: The term 'xlings' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again."

Desktop | 环境
OS: windows11
To Reproduce | 复现步骤
Expection | 预期结果
Solution by you | 已尝试的方案
Additional context | 额外补充
After install it without refreshing, I could use "xlings"

Q1: is it only not found in current powershell window?  - sitll is a issue
Q2: can 'xlings' recognized by reopen a new cmd or powershell?
Q3: Is your username is Administrator?

https://github.com/d2learn/xlings/blob/ed77bc8727d0308d515477010b6b60032b774f70/tools/other/quick_install.ps1#L155

Q1: is it only not found in current powershell window? - sitll is a issue Q2: can 'xlings' recognized by reopen a new cmd or powershell? Q3: Is your username is Administrator?

A1: If I reopen powershell, it can't recognize xlings, the scope of xlings only works on powershell window I install xlings
A2: as above.
A3: Yes.

I don't see env modification when I check it. Here it use

Tab completion service
=> installing shell integration to C:\Users\nostalgia\OneDrive\文档\PowerShell\profile.ps1 .. ok
Tab completion installed
[xlings]: set xlings to PATH
and create a profile.ps1 link to the script of xlings, bu it doesn't seem to work for me.

@lvyuemeng
maybe exist some issue in install procedure
can you install xlings again? then paste all install's log to 'To Reproduce | 复现步骤'

repo:  https://github.com/d2learn/xlings
forum: https://forum.d2learn.org                                                                                ---                                                                                Testing network...                                                                                WARNING: Unable to ping github.com
WARNING: Unable to ping gitee.com
Latency for github.com : 999999 ms
Latency for gitee.com : 999999 ms
[xlings]: start detect environment and try to auto config...
[xlings]: start install xmake...
                  _
__  ___ __  __  __ _| | ______
\ \/ / |  \/  |/ _  | |/ / __ \
 >  <  | \__/ | /_| |   <  ___/
/_/\_\_|_|  |_|\__ \|_|\_\____| getter

Start downloading https://github.com/xmake-io/xmake/releases/download/v2.9.6/xmake-master.win64.exe ..
Start installation... Hope your antivirus doesn't trouble
Install to C:\Users\nostalgia\xmake
Adding to PATH... almost done
xmake v2.9.6+master.2f1213a70, A cross-platform build utility based on Lua
Copyright (C) 2015-present Ruki Wang, tboox.org, xmake.io
_
__  ___ __  __  __ | | ______
\ / / |  /  |/ _  | |/ / __
>  <  | _/ | /| |   <  /
//__||  ||_ ||____|
by ruki, xmake.io
👉  Manual: https://xmake.io/#/getting_started
🙏  Donate: https://xmake.io/#/sponsor

Tab completion service
=> installing shell integration to C:\Users\nostalgia\OneDrive\文档\PowerShell\profile.ps1 .. ok
Tab completion installed
[xlings]: set xlings to PATH
WARNING: The data being saved is truncated to 1024 characters.
SUCCESS: Specified value was saved.
[xlings]: xlings uninstalled(C:/Users/Public/xlings) - ok
[xlings]: install xlings to C:/Users/Public/xlings
[xlings]: add bin to linux's .bashrc or windows's path env
[xlings]: xlings installed
run xlings help get more information

removing directory: F:\Stratum\TEMP\xlings (tmpfiles)
xlings has been successfully installed.

I try to solely install xmake, and it works. So I guess there's a deficit installation in xlings

install-script updated already. you can re-install to verify.
xlings uninstall
Invoke-Expression (Invoke-Webrequest 'https://d2learn.org/xlings-install.ps1.txt' -UseBasicParsing).Content

https://github.com/d2learn/xlings/blob/06274b10ef09e13c1cec6fe70324cd65f5304940/tools/other/quick_install.ps1#L154-L164

install-script updated already. you can re-install to verify.
xlings uninstall
Invoke-Expression (Invoke-Webrequest 'https://d2learn.org/xlings-install.ps1.txt' -UseBasicParsing).Content

https://github.com/d2learn/xlings/blob/06274b10ef09e13c1cec6fe70324cd65f5304940/tools/other/quick_install.ps1#L154-L164

It works now, thanks!


[PAGOPA-1020] add due date to API: updated API and JUNIT test

depends on https://github.com/pagopa/pagopa-api-config-starter/pull/22
List of Changes

added due_date field to iban API

Motivation and Context

business request

How Has This Been Tested?
manual and junit test

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

update_code


Move from ClickOnce to Squirrel.Windows

[x] Introducing Squirrel.Windows

[x] Test checking for updates locally in debug mode
[ ] Test checking for updates on :octocat: in release mode

[x] Introducing Cake

[x] Build solution
[x] Run unit tests
[x] Generate Zip file
[x] Generate Chocolatey package
[x] Generate NuGet package ready to be squirrelified
[x] Releasify the NuGet package
[x] Publish Squirrel release files to :octocat:

[x] Chocolatey

[x] Use ChocolateyPack to generate chocolatey package
[x] Add checksum to install script

[x] Remove old, redundant build script
[x] Update README, probably...
[x] Bump version??
[x] Update authors and components

Closes #125
Closes #135
Closes #140

I haven't forgotten about this...Just been a bit busy last few days 🙂

@alfhenrik no worries. Life Happens™

Apart from testing the Squirrel update logic now that the build generates the correct artifacts, this is probably ready for a first-pass review 🤔

sad 🐼 ...to build the Squirrel update package it looks like it needs the package of the previous version otherwise it won't update the app...i.e. I build version 0.0.1 and get that installed, I run a new build for version 0.0.2 (which cleans the deploy folder where the previous package was), I run the app again and it won't update to version 0.0.2. If I don't clean the previous artifacts when building 0.0.2 and I run the app it will successfully update to 0.0.2...

You need to have the current version of the app when Releasing in order to build the new version of the app because of Delta updates. There's a tool in Squirrel called SyncReleases that you can use in CI to pull it down, so you don't have to keep a releases folder in perpetuity.

OK, got the SyncReleases logic in, now I'm hitting the :octocat: API rate limit for unauthenticated calls (makes sense).
If I add our auth token as a secure environment variable in appveyor.yml and pass that into / use that in the build script am I opening a security hole where the token somehow could leak and be exposed to someone that shouldn't see it...? I've done some googling but haven't been able to find a definitive answer...

If I add our auth token as a secure environment variable in appveyor.yml and pass that into / use that in the build script am I opening a security hole where the token somehow could leak and be exposed to someone that shouldn't see it...?

I think you're fine to do this as long as it's encrypted, as per this link:

However, secure variables are not decoded during Pull Request builds which prevents someone from submitting PR with malicious build script displaying those variables.

Yea, I was going to use the one we already have in the config file.

OK, I think the only thing left for me to test at this moment is the app update from :octocat:.
Although, 1 thing I'd like to discuss is the where should we do the app update check.
Currently I do it at startup, but this might not be the best place...and also, do we want to show somewhere in the UI that the app has been updated (so the user knows they need to restart to get the latest...)? E.g. a tooltip once the update manager has successfully pulled down and applied the update.

Currently I do it at startup, but this might not be the best place...

Maybe not best to do it immediately at setup, but a few minutes after startup (using a background timer or something?)

do we want to show somewhere in the UI that the app has been updated (so the user knows they need to restart to get the latest...)?

Let's punt this to another time. If the update is applied on next startup then that should be fine.

So something like this? (Excuse my Rx n00bness if this is not correct...)
            Observable
                .Timer(TimeSpan.FromMinutes(5))
                .Subscribe(async x =>
                {

                    try
                    {
#if DEBUG
                        using (var mgr = new UpdateManager(carnacUpdateUrl))
                        {
                            await mgr.UpdateApp();
                        }
#else
                using (var mgr = UpdateManager.GitHubUpdateManager(carnacUpdateUrl))
                {
                    await mgr.Result.UpdateApp();
                }
#endif
                    }
                    catch
                    {
                        // Do something useful with the exception
                    }
                });

Just realised that the zip file used by choco install won't install the app so it can be updated via Squirrel as it right now will just extract the carnac binaries.
Will Fix!

All fixed, and ready for review now 👍

let me know if there's specific areas or things you'd like me to review.
I think I just wanted a sanity check really 😃

I can't think of anything left to do on this, so should we merge it?

I can't think of anything left to do on this, so should we merge it?

Yeah, let's give it a shot :shipit:

@alfhenrik let me know if there's anything else to merge

@shiftkey I'm pretty sure everything I wanted to get in is in, at least I can't think of anything else right now 😄


Numeric max and min are flip-flopped in validation

Test case: https://jsfiddle.net/b4ykh59d/3/
Max is set to 5 but you need to type in 6 or greater for it to pass validation

False alarm, only happens in the new enhancement-rule-js-overhual branch


chore: Add OpenSSF scoreboard to the README

The scoreboard checks a project's level of professionalism and combines a lot of metrics including the OpenSSF best practices score.

Note that for the badge to work, best practices poll must be filled first: https://bestpractices.coreinfrastructure.org/en/projects/6725 . I skimmed through it and ticked some boxes, but it's not complete yet. Thanks for suggesting this badge!

@psarna No need to complete all, the badge will still work.
It is very tough to get a perfect score and much work for a decent score, but, i think that the project already has a lot done.
CI/CD tests
static code analysis maybe we'll need!

The links from this PR still resolve to an "invalid repo path" badge, so perhaps coreinfrastructure.org needs to catch up with matching the project number and its github link?

Ah i mean you need to create and save the project even if it is empty on the best practices site.

The rendered badge is showing "invalid repo path". Closing this as inactive.


UnityEditor Crash by UdonSharp compile

Describe the bug in detail:

I'm not sure why .
I guess compiling  string + property has some bug.
but when i use string.format to replace that code ,it will fix the problem.

Cannot repro, is this happening when the script runs in play mode? Please post the output log that Unity makes, and if possible a minimal script that causes the issue.

Also forgot to confirm, is this in U# 1.0?


Crash in WaveformArea::DoRenderCairoOverlays() on line 372

Happens when dragging the trigger position bar if a frequency-vs-time plot is active.

Caused by m_channel->GetScope() returning NULL.


PlutoUI.NumberField changes value whenever you hit backspace or delete to change its value.

When using PlutoUI.NumberField, the variable changes it's value whenever you hit backspace, delete or number keys. Maybe a better behaviour for NumberFiled should be to accept the change in the variable only after the enter key is pressed, or an option could be added when calling it to enable this behaviour.

This sounds similar to #177. Would wrapping in PlutoUI.confirm be alright?
using PlutoUI

@bind x confirm(NumberField(1:10))

Yes, I think that should fix this behaviour! Thanks!


init dashboard

PTAL.

@grafnu  firebase requires a CI token even with the emulators, would you please follow this section to generate a token and store that in this repo's env var.https://firebase.google.com/docs/cli#cli-ci-systems

Which repo are you talking about for the token?  I'd rather get the permissions fixed so that you can do it yourself rather than relying on me.  Will make it easier in the future.
Also still one unresolved comment about the functions deploy.
Everything else LGTM.


screenshot not working while setting up options

While setting up the browserOptions on config.ts file.
`
import { ChromiumEnv, test, setConfig } from "@playwright/test";
const browserOptions = {
// Launch options:
headless: false,
slowMo: 50,
// Context options:
viewport: { width: 800, height: 600 },
ignoreHTTPSErrors: true,
// Testing options:
video: 'on',
screenshot: 'on',
};
test.runWith(new ChromiumEnv(browserOptions), { tag: 'chromium' });
`
the screenshot does not work with any of the available parameters listed on :
Available testing options:
screenshot: 'off' | 'on' | 'only-on-failure' - Whether to capture a screenshot after each test, off by default.
off - Do not capture screenshots.
on - Capture screenshot after each test.
only-on-failure - Capture screenshot after each test failure.

working as expected with the latest update, closing the issue.


Get rid hardcoded values in opt_verification.api

There are some hardcoded values in OtpVerification.SMSLogs (-32, 30 etc = "sms_statuses_expiration" config value). Need to understand if they could be got rid by using config values.

@Troush ^^


Feature request: add indexHtmlTransformer and plugins options to application builder

Command
build
Description
Hi. This feature exists for a long time in angular-builders and nx custom builders' code.
plugins allows adding vite plugins; we use this option to use custom plugin with .env file parsing, adding ENVIRONMENT_NAME and APP_VERSION global variables and much more. I guess there are plenty of other use-cases for this.
indexHtmlTransformer allows to replace some placeholders in index.html while building or serving an app. Useful to make similar DX when building or developing locally my app.
There is not much to do with these two, but i think this will boost DX many times.
Thanks for your time!
Describe the solution you'd like
No response
Describe alternatives you've considered
https://github.com/nrwl/nx/blob/master/packages/angular/src/executors/application/application.impl.ts

@zip-fa, thanks for this feature request.
While we do offer the option to add additional plugins and modify the index.html file, we do not consider this to be part of the "recommended" or optimal path.
What is the use-case of including environment variables directly in the index.html instead of embedding them in the JS bundle and setting them with the --define option?

You misunderstood me a bit. NX parses .env.{envName} files automatically and set them inside process.env
We have three environments: staging, prod and dev.
While it's ok to use --define option, it's much easier to depend on .env files.  Our plugin to define global env vars is:
const path = require('path');
const { dirname } = require('node:path');
const envPrefix = /^APP_/i;

function getProjectEnvVars() {
  const envVars = {};

  for (const key in process.env) {
    if (envPrefix.test(key)) {
      envVars[key] = process.env[key];
    }
  }

  return envVars;
}

const envVarPlugin = {
  name: 'env-var-plugin',
  setup(build) {
    const options = build.initialOptions;
    const envVars = getProjectEnvVars();
    const sourceDirectory = dirname(build.initialOptions.tsconfig);
    const packageJsonPath = sourceDirectory + '/package.json';

    options.define['__APP_VERSION__'] = `"${ require(packageJsonPath).version }"`;
    options.define['__SOURCE_DIRECTORY__'] = `"${ sourceDirectory }"`;
    options.define['BUILD_ENV'] = JSON.stringify(envVars);
    options.define['ENVIRONMENT_NAME'] = `"${ process.env.NX_TASK_TARGET_CONFIGURATION }"`;
  }
};

module.exports = envVarPlugin

For index.html we change placeholders on the fly:
<head>
{analytics_scripts}
</head>

transformer:
export default function(indexContent: string) {
  const replacements: Record<string, string> = {
    '{analytics_scripts}': '...'
  };

  for (const key in replacements) {
    indexContent = indexContent.replaceAll(key, replacements[key]);
  }

  return indexContent;

Hi all, adding another use case, some scripts needs to be added in head section like this:
 <script async src="https://www.googletagmanager.com/gtag/js?id=GTM-XXXX"></script>

currently we can't use variable for GTM id in index.html, we can also load script using js/angular, but it will have some issue if its loaded later from angular app code. sometimes script's domain name can also be different based on env, fonts can also be different for each env, currently we need to create different index.html files for each env & replace it using fileReplacements config.

@imaksp Have you tried using in the "index" property in angular.json to provide different index.html files for different configurations? https://angular.dev/reference/configs/workspace-config#index-configuration

Hi @stephanietuerk yes I forgot to mention but I am using it but it also requires new index file for each env like file replacement, variables support in index would not require new file for each env, currently we need to create new file even if only 2-3 things are different between each env.


enable api2x tools for oneVPL

enable api2x tools for oneVPL

Tracked-On: OAM-112268

@Shao-Feng @TianmiChen @YuanjunHuang please help to review, thanks!


Convention over configuration

I believe we could decrease the number of decisions a plugin developer needs to do when using this SDK, by enforcing some conventions, and therefore simplify the process of creating your own plugin.
For example, the various NewGo... (e.g. sensu.NewGoHandler) require you to pass functions as arguments:
func main() {
	handler := sensu.NewGoHandler(&handler.PluginConfig, options, checkArgs, executeHandler)
	handler.Execute()
}

func checkArgs(_ *types.Event) error {}

func executeHandler(event *types.Event) error {}

I believe by adopting some conventions on the name of these functions, we could reduce the number of arguments required and therefore the complexity. For example, if we assumed that a Plugin must adhere to a given interface, we could simply do the following instead:
func main() {
	handler := sensu.NewGoHandler(&plugin)
	handler.Execute()
}

func (p *Plugin) Validate(_ *types.Event) error {}

func (p *Plugin) Execute(event *types.Event) error {}

Similarly, I don't believe declaring a PluginConfigOption should require that much attributes, e.g.
&sensu.PluginConfigOption{
			Path:      "example",
			Env:       "HANDLER_EXAMPLE",
			Argument:  "example",
			Shorthand: "e",
			Default:   "",
			Usage:     "An example configuration option",
			Value:     &handler.endpoint,
		},
	}

Instead, maybe we could simply assume sane default values (e.g. I assume the Path and the Argument could be similar) but allow those values to be overridden for edge cases.

+1, we could probably do much better with interfaces here.

Love it!

One comment...
I don't think we always want to have an cmdline Argument backed by a path. The name of the path might be a convention we can set and have it match the argument name... but we will still need a bool to indicate if path override is desired.
Similarly with Env, we could enforce a naming convention but we'd still need a bool to enable/disable the optional Env binding.
Looking more closely... we actually could allow a PluginConfigOption with a Path but no cmdline argument set if we wanted to.


ShortcutPreviewRenderer should also show time controlled references that are currently not visible

Hi,
The preview renderer for shortcuts filters out time controlled references that are currently not visible. This is a bit confusing for editors, since they might think that the element does not work. Thus i'd like to remove the restrictions for StartTime and EndTime. Do you agree? Then i will prepare a pull request
--> \EHAERER\PasteReference\PageLayoutView\ShortcutPreviewRenderer::collectContentData
$queryBuilder = $this->getQueryBuilder();
$queryBuilder->getRestrictions()->removeByType(\TYPO3\CMS\Core\Database\Query\Restriction\StartTimeRestriction::class);
$queryBuilder->getRestrictions()->removeByType(\TYPO3\CMS\Core\Database\Query\Restriction\EndTimeRestriction::class);

Hi @akiessling I think you're right and will integrate and test it.


Fix typos in documentation

Fix repeated words
Fix broken links

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b0d6d4b8df0a4e8b306c12dc1b192e3de72fa51d/

@jseldess No: I was just reading the docs, spotted the typos, then used  git grep to get all the similar typos.


remove reboot playbook from dockerfile

Signed-off-by: Jonathan Holloway<EMAIL_ADDRESS>

Codecov Report

Merging #337 (66a8edf) into main (d9b707d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   26.01%   26.01%
=======================================
  Files          29       29
  Lines        2587     2587
=======================================
  Hits          673      673
  Misses       1840     1840
  Partials       74       74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b707d...66a8edf. Read the comment docs.

Might be worthy to also remove the code that calls it.

Ah, yes. The call was removed before, but I can include removing the orphaned functions in this PR.

/recheck

/retest


[usecase-linux][xwalk-3714] Add usecase for window size

Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: [Linux]
Unit test result summary: pass 1, fail 0, block 0

@zqzhang
I have updated it following your comments


Fix: make sure MultiplexTcpTransport creates a TCP socket over Wi-Fi network

Fixes https://github.com/smartdevicelink/sdl_android/issues/899
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
This PR only affects MultiplexTcpTransport class.
Testing Plan
Repeat the steps mentioned in my comment https://github.com/smartdevicelink/sdl_android/issues/899#issuecomment-428445159 and make sure that the library establishes a TCP connection to Core.
Summary
This PR updates MultiplexTcpTransport to make sure it creates a Socket instance which is bound to Wi-Fi network.
Changelog
Breaking Changes

None.

Enhancements

None.

Bug Fixes

fixes MultiplexTcpTransport opening a TCP socket via mobile network when the head unit has no Internet connectivity over Wi-Fi network and the phone is associated with cellular network.

Tasks Remaining:

None

CLA

[X] I have signed the CLA

Codecov Report

Merging #900 into release/4.7.0-rc1 will decrease coverage by 0.06%.
The diff coverage is 0%.

@@                   Coverage Diff                   @@
##             release/4.7.0-rc1     #900      +/-   ##
=======================================================
- Coverage                42.39%   42.32%   -0.07%
  Complexity                3706     3706
=======================================================
  Files                      433      434       +1
  Lines                    23006    23024      +18
  Branches                  2673     2676       +3
=======================================================
- Hits                      9753     9745       -8
- Misses                   12616    12644      +28
+ Partials                   637      635       -2

Impacted Files
Coverage Δ
Complexity Δ

...artdevicelink/transport/utl/WiFiSocketFactory.java
0% <0%> (ø)
0 <0> (?)

...artdevicelink/transport/MultiplexTcpTransport.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om/smartdevicelink/transport/SdlRouterService.java
7.2% <0%> (ø)
9 <0> (ø)
:arrow_down:

...smartdevicelink/encoder/VirtualDisplayEncoder.java
24.71% <0%> (-4.6%)
8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f099f7c...44c3f2a. Read the comment docs.

Hi @joeygrover , please kindly review.
According to Ford team this is in priority, so I opened a PR against RC branch. Let me know if I should also create one for develop. Thanks.

Priority is understood, note that we are in our testing period of the release so I can't guarantee this PRs inclusion into the 4.7 release, however, if changes requested are made it makes it much more likely.
I do have issues with this PR just being outright accepted. The PR itself would create a new requirement for all app developers to add the ACCESS_NETWORK_STATE permission to their app which would be a breaking change since it will throw an exception and cause their app to crash. Because of this, the router service would get closed down and cause all other apps to disconnect from the head unit which is a very poor user experience. Furthermore, I do not see a requirement that the IP address of the module must be part of a local network; theoretically the module could send a static IP it has that can be accessed via the WAN connection regardless of WiFi connection or not.
I would propose the following changes:

Do not throw an exception when it can't access a WiFi socket.
A WiFi socket may be preferred, but if one can not be created for whatever reason, a default socket should be created and returned.
The createWiFiSocket method must check for the ACCESS_NETWORK_STATE permission and return null if does not have it. Which then, following bullet #2 a default socket would be created and returned.
Please add some unit tests around this new class, likely will have to use mockito to mock the network interfaces and system service.
Proper null checks should be put into place in the createWiFiSocketto ensure the router service does not crash from an NPE

Thank you @joeygrover for your feedbacks. I'll definitely reflect them into my PR.
Just one thing, I was less worried about ACCESS_NETWORK_STATE since the official integration guide https://smartdevicelink.com/en/guides/android/getting-started/integration-basics/ states that the permission is required. I still agree that checking the permission and returning null is a good idea, so I'll follow it.

@shoamano83 you are right. I will have to revisit why we added that permission to the guide, because I can't think of where it is used off hand. That makes this PR easier to accept with the changes we agreed upon.

Hi @joeygrover , I updated my code and also added unit tests.
Thanks.


Glowing Text Animation

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
I would like to add Glowing Text Animation to the website.
Screenshots
No response
Code of Conduct

[X] I follow Contributing Guidelines of this project.

Go ahead @GhoshAditi


Set note title to first line of note when exporting to Evernote

Thanks for making simplenote backup available - great use of Google App Engine.
I used it today and wished that, when exporting for Evernote, the note title would be the first line of the note, rather than the first 4 words.
So here's a tiny modification to do that; I've added a custom filter since Django templates don't seem to have a 'first line of string' filter.
Would be honoured if you accepted this modification - I feel it's more consistent with the way that Simple Note handles things.
Best regards,
Richard

I'm no longer the maintainer of simple-backup. Simperium, the company that
makes Simplenote, took it over a while back. Please contact them to get
your patch included. Thanks!
On Wed, Jan 4, 2012 at 14:24, Richard Morrison <
<EMAIL_ADDRESS>
wrote:

Thanks for making simplenote backup available - great use of Google App
Engine.
I used it today and wished that, when exporting for Evernote, the note
title would be the first line of the note, rather than the first 4 words.
So here's a tiny modification to do that; I've added a custom filter since
Django templates don't seem to have a 'first line of string' filter.
Would be honoured if you accepted this modification - I feel it's more
consistent with the way that Simple Note handles things.
Best regards,
Richard
You can merge this Pull Request by running:
git pull https://github.com/mozz100/simple-backup evernote-firstline
Or you can view, comment on it, or merge it online at:
https://github.com/al3x/simple-backup/pull/2
-- Commit Summary --

Set note title to first line of note when exporting to Evernote

-- File Changes --
A filters/init.py (0)
A filters/textfilters.py (12)
M main.py (2)
M templates/enex (2)
-- Patch Links --
https://github.com/al3x/simple-backup/pull/2.patch
https://github.com/al3x/simple-backup/pull/2.diff

Reply to this email directly or view it on GitHub:
https://github.com/al3x/simple-backup/pull/2

--
Alex Payne
http://al3x.net/


fix(#623) - Fix open editor with space key (must be treated as a normal character)

Fixes #623.
Description
When using the keyboard to start cell editor, we cannot use the space key to open the cell editor and replace its content with a new space character.
Everything works fine if we type a "normal" character.
Test conditions
OS: Mac OS v10.12.6
Browsers: Chrome 60.0.3112.113 and Firefox 55
How to reproduce

Open hypergrid's demo app;
Focus on an editable cell (either with or without content);
Hit the "space" key (nothing happens -> should have opened the editor);
Hit the "a" key (a new editor with "a" value type should be rendered).

Note: I've created this new PR because I've messed up with the original branch history.

@joneit Hi! I've applied the changes suggested in the previous code review.
Sorry for creating this new PR, but I've messed up a bit with the previous branch history and this should fix it.
Regarding your comment about the RETURN and RETURNSHIFT code:

including RETURN here opens a cell's editor on receipt, but short circuits current functionality which is that RETURN goes down one cell and SHIFT-RETURN goes up one cell (like down- and up-arrrow, respectively). Let's remove these from here. Developer could override this method to get this functionality.

The RETURN keys are handled before this code, if they're mapped as navigation keys.
Because the handler (CellSelection.handleKeyDown) prevents their propagation, I've removed the bit of code that was checking for it in line 60.
BTW we've have a local branch that adds the feature to use RETURN and RETURNSHIFT to open cell editor, but keeping them as navigation keys, so they can close the editor and execute the move down or up code. This feature can be toggled on/off with the editOnReturnKeydown property.

@hugoeanogueira @joneit Whats the status here

Closing. Worked into Hypergrid v2.2.11 (PR #722).


Support Clone trait

Extend external_fn_specification with general support specifying trait function impls
Hardcode support for Clone and the generic Clone::clone
Add support for a few types, including Vec

Note that Clone::clone_from is completely ignored. It has a default implementation which causes all kinds of problems. We pretend it doesn't exist and error if the user tries to use it.

Can we strengthen the post-condition for clone in some way so that this example doesn't require a manual proof (except perhaps the assert(w@ =~= v@))?
        fn test_bool_vec(v: Vec<bool>) {
            let w = v.clone();
            proof {
                assert_seqs_equal!(w@, v@, i => {
                    assert(call_ensures(<bool>::clone, (&v@[i],), w@[i]));
                    assert(w@[i] == v@[i]);
                });
            }
            assert(w@ =~= v@);
        }

This seems rather heavyweight (and unintuitive) for a developer who expects clone to "obviously" produce a copy of the original object.  (unless the example above is spelled out more than necessary for didactic purposes?)

It should work without the proof{} block

Excellent!

Can we strengthen the post-condition for clone in some way so that this example doesn't require a manual proof (except perhaps the assert(w@ =~= v@))?

We can probably do even better by adding the postcondition vec@ =~= res@ ==> vec@ == res@,.  Then we don't even need the assert.

We can probably do even better by adding the postcondition vec@ =~= res@ ==> vec@ == res@,. Then we don't even need the assert

Ooh, very cool!


release: update v9 upgrade docs

Given that https://github.com/inveniosoftware/invenio-userprofiles/pull/142 got merged, updating the specific branch is not needed anymore.

@slint perhaps in invenio-app-rdm, even though I think it will resolve to 2.0.1 .