a novel 64 bit roaring bitmap implementation

the novel 64 bit roaring bitmap implementation :

using ART to keep the key/value pairs, key is the high 48 bit of the long value, value is the container id of the low 16 bit containers stored in Containers.
serialization/deserialization of the art tree is native ,no need to reconstruct it.

@lemire please give a review

I ll try to get this soon through my use of 64b RoaringBitmap to check for bugs

Looks really good! I think there are a few places where we could avoid little byte[] being created, and get more operations per cycle and reduce spatial overhead in some of the node implementations (in Node256 this would deviate from the ART paper but I expect it would work well to add a bitmask for child existence at very small cost). I think de/serialisation via ByteBuffer would be preferable.

thanks @richardstartin @blacelle. @richardstartin your advice is valuable. But converting node4, node16's byte[] to int or longs will make search ,sort, insert operations on the byte array be difficult.

What I had in mind really wasn’t very complicated at all actually. I can send you some changes later if you like.

@richardstartin I could try that but will be later as I am on vacation from now on. Never mind to show your example code. I wonder we will change the int or long into byte array some areas or through some shift operations.

@richardstartin  I spend some of my free time applying your review advice to the codes. Please give a review again, thanks!

need help! What's wrong with the checkstyle method name?

/home/travis/build/RoaringBitmap/RoaringBitmap/shims/src/main/java/org/roaringbitmap/ArraysShim.java:43:21: Method name 'mismatch' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9_]*$'. [MethodName]

@weijietong  You have used a non-ASCII symbol in the method name. Please use only ASCII for names (this is what the style error message is telling you, effectively). I am surprised that Java will even compile this...

@lemire thanks for your help,I have fixed that.

Coverage decreased (-0.5%) to 91.435% when pulling ffa489ec25427fc04a121db3cf54fca320a0b10f on weijietong:64bit into c4b1c69419cec8f6b6c817f4d7f83a2ba9d754fe on RoaringBitmap:master.

Thanks for making some of the suggested changes. I especially like that the sizes of some of the serialised attributes have been made smaller. I have a branch where I removed the need for small byte[] (meaning things like the longest common prefix matches and binary searches can be accelerated) which I could apply on top of this, so don't worry about those.
I think the ByteBuffer serialisation could do with some work; this PR introduces duplicated methods to the containers, look generic but are really specific to ART and can't be used with RoaringArray. The motivation to do this is that the container's cardinality is not stored in the leaf node; storing the container cardinalities in the ART leaf node would be more consistent with RoaringArray and would lead to some small efficiencies in deserialising containers.
Specifically:

Store a container cardinality next to the container type when serialising leaf nodes.
I would like to see the Container.deserialize methods moved into the ART package (make whichever Container constructors public you need to do this).
Container.serialize duplicates writeArray and is less efficient in BitmapContainer and ArrayContainer - remove these and call writeArray - once you have the cardinality in the leaf node you might as well do this anyway.

I appreciate it's probably frustrating to go back and forth making changes and meeting more requests for changes. I think the sooner we merge this the sooner it gets used and the sooner others can make improvements. So if you're OK to make the changes suggested, we can merge it to master afterwards, otherwise we could merge it to a development branch without the requested changes where others can make changes before making the feature generally available.
@lemire do you have any thoughts?

@richardstartin I am curious about how to keep compatible between the ArrayContainer's writeArray(ByteBuffer) and serialize(DataOutput) version. As their binary version data is not the same. When serializing the Roaring64Bitmap through the DataOutput , the ArrayContainer will have a cardinality data in the serialized data, If the user change to the ByteBuffer version to deserialize the data. It will be error.  Could we name the serialize(ByteBuffer) to a more specific name (maybe serializeForArt)?

Sorry, I wasn't clear, both should be changed, because there's only one serialisation format :) the basic idea is just that the cardinality should be stored in the leaf node, for consistency, performance, and so on. Also, if this starts getting used seriously, a memory mapped version will need to be implemented on the same format, pushing the cardinality up to the leaf node would help with that. Does that make sense?

@richardstartin got it, thanks. Please review again.

@weijietong
Thanks for the good work (and thanks to @richardstartin for the thorough review).
I am happy that changes to the core classes is minimal.
I would like to invite you to improve slightly the test coverage before we merge...
There are several methods that are either untested or poorly tested...

deserializeHeader in org/roaringbitmap/art/Node.java
replaceChildren in org/roaringbitmap/art/Node256.java
getCurrentContainerIdx() and replace(Container container) in org/roaringbitmap/art/ContainerIterator.java
remove in org/roaringbitmap/longlong/HighLowContainer.java
getNextSmallerPos, getMaxPos, replaceChildren, and all of the serialize* methods in org/roaringbitmap/art/Node16.java
replace in org/roaringbitmap/art/Containers.java

Also the javadoc needs help...
> Task :shims:javadoc
RoaringBitmap/shims/src/main/java/org/roaringbitmap/ArraysShim.java:43: warning: no @param for a
  public static int mismatch(byte[] a, int aFromIndex, int aToIndex,
                    ^
RoaringBitmap/shims/src/main/java/org/roaringbitmap/ArraysShim.java:43: warning: no @param for b
  public static int mismatch(byte[] a, int aFromIndex, int aToIndex,
                    ^
RoaringBitmap/shims/src/main/java/org/roaringbitmap/ArraysShim.java:43: warning: no @return
  public static int mismatch(byte[] a, int aFromIndex, int aToIndex,
                    ^
3 warnings

> Task :RoaringBitmap:javadoc
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Shuttle.java:18: warning: no description for @return
   * @return
     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Art.java:92: warning: no @param for containers
  public KeyIterator iterator(Containers containers) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Art.java:92: warning: no @return
  public KeyIterator iterator(Containers containers) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Art.java:101: warning: no @param for key
  public long remove(byte[] key) {
              ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/ContainerIterator.java:96: warning: no @param for container
  public void replace(Container container) {
              ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:37: warning: no @param for k
  public abstract int getChildPos(byte k);
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:37: warning: no @return
  public abstract int getChildPos(byte k);
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:42: warning: no @param for pos
  public abstract Node getChild(int pos);
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:42: warning: no @return
  public abstract Node getChild(int pos);
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:47: warning: no @param for pos
  public abstract void replaceNode(int pos, Node freshOne);
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:47: warning: no @param for freshOne
  public abstract void replaceNode(int pos, Node freshOne);
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:52: warning: no @return
  public abstract int getMinPos();
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:59: warning: no @return
  public abstract int getNextLargerPos(int pos);
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:64: warning: no @return
  public abstract int getMaxPos();
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:69: warning: no @param for pos
  public abstract int getNextSmallerPos(int pos);
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:69: warning: no @return
  public abstract int getNextSmallerPos(int pos);
                      ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:76: warning: no @param for pos
  public abstract Node remove(int pos);
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:147: warning: no @param for children
  public abstract void replaceChildren(Node[] children);
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:152: warning: no @param for dataOutput
  public abstract void serializeNodeBody(DataOutput dataOutput) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:152: warning: no @throws for java.io.IOException
  public abstract void serializeNodeBody(DataOutput dataOutput) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:157: warning: no @param for byteBuffer
  public abstract void serializeNodeBody(ByteBuffer byteBuffer) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:157: warning: no @throws for java.io.IOException
  public abstract void serializeNodeBody(ByteBuffer byteBuffer) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:162: warning: no @param for dataInput
  public abstract void deserializeNodeBody(DataInput dataInput) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:162: warning: no @throws for java.io.IOException
  public abstract void deserializeNodeBody(DataInput dataInput) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:167: warning: no @param for byteBuffer
  public abstract void deserializeNodeBody(ByteBuffer byteBuffer) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:167: warning: no @throws for java.io.IOException
  public abstract void deserializeNodeBody(ByteBuffer byteBuffer) throws IOException;
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:181: warning: no @param for childNode
  public static Node insertLeaf(Node current, LeafNode childNode, byte key) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:181: warning: no @param for key
  public static Node insertLeaf(Node current, LeafNode childNode, byte key) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:181: warning: no @return
  public static Node insertLeaf(Node current, LeafNode childNode, byte key) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:199: warning: no @param for src
  public static void copyPrefix(Node src, Node dst) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:199: warning: no @param for dst
  public static void copyPrefix(Node src, Node dst) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:210: warning: no @param for key
  public static int binarySearch(byte[] key, int fromIndex, int toIndex,
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:210: warning: no @param for k
  public static int binarySearch(byte[] key, int fromIndex, int toIndex,
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/art/Node.java:210: warning: no @return
  public static int binarySearch(byte[] key, int fromIndex, int toIndex,
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/HighLowContainer.java:76: warning: no @return
  public LeafNodeIterator highKeyLeafNodeIterator(boolean reverse) {
                          ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/HighLowContainer.java:87: warning: no @param for highPart
  public void remove(byte[] highPart) {
              ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:8: warning: no @param for v
  public static byte[] toBDBytes(int v) {
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:8: warning: no @return
  public static byte[] toBDBytes(int v) {
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:20: warning: no @param for bytes
  public static int fromBDBytes(byte[] bytes) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:20: warning: no @return
  public static int fromBDBytes(byte[] bytes) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:30: warning: no @param for v
  public static int setByte(int v, byte bv, int pos) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:30: warning: no @param for bv
  public static int setByte(int v, byte bv, int pos) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:30: warning: no @param for pos
  public static int setByte(int v, byte bv, int pos) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:30: warning: no @return
  public static int setByte(int v, byte bv, int pos) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:39: warning: no @param for v
  public static int shiftLeftFromSpecifiedPosition(int v, int pos, int count) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:39: warning: no @param for pos
  public static int shiftLeftFromSpecifiedPosition(int v, int pos, int count) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:39: warning: no @param for count
  public static int shiftLeftFromSpecifiedPosition(int v, int pos, int count) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:39: warning: no @return
  public static int shiftLeftFromSpecifiedPosition(int v, int pos, int count) {
                    ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:48: warning: no @param for v
  public static byte firstByte(int v) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/IntegerUtil.java:48: warning: no @return
  public static byte firstByte(int v) {
                     ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/LongUtils.java:56: warning: no @param for v
  public static byte[] toBDBytes(long v) {
                       ^
RoaringBitmap/RoaringBitmap/src/main/java/org/roaringbitmap/longlong/LongUtils.java:56: warning: no @return
  public static byte[] toBDBytes(long v) {
                       ^
52 warnings

Both of these issues (coverage and javadoc) should be fixed.
The coverage issue may seem like nitpicking since you already added quite a few tests... but you are also adding quite a bit of code... We have had trouble many times with untested code that looked ok, went into production and caused no end of trouble... Of course, it is not because it is tested that it is correct, but it is much less embarrassing when there are failures and we can trace them back to tested code... it is then simply a matter of adding more tests.
The javadoc fixes are just flat out necessary before we can do a release for obvious reasons.
You refer on a few occasion to performance...  Would you consider contributing a benchmark... See  https://github.com/RoaringBitmap/RoaringBitmap/tree/master/jmh/src
Without any benchmarking, it is hard for people to appreciate the value of this new code. It would be really helpful for the users to see the performance...  It is not super easy to add a JMH benchmark and run it, but we have a ton of existing examples...
Cheers!

ok, please wait.

@weijietong Note that it is ok to remove code so as to avoid coverage issues.

@lemire  I think it's ready to review, but there's two build errors which I can not get any meaningful message. Please give some help.

I will check.


Create a Deep learning Model for object detection..

ill like to make the model using darkflow and yolo v5
if there is something more specific you need pls tell
could you assign me this issue

I'd like to work on this issue under label LGMSOC21.

@PadminiRai go for it.

I would also like to contribute under LGMSOC21

@Niketkumardheeryan I've created the PR for this issue.
PR : https://github.com/Niketkumardheeryan/Hands-on-ML-Basic-to-Advance-/pull/114


MNT: Update pinned versions.

Hi! This is the friendly conda-forge-admin automated user.
I've bumped some of the conda-forge pinned versions, and noticed that it impacts this feedstock.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).
Thanks!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

it's a build-time only depency, so pinning is not mandatory


feat: improve attribute checking

generate a report error when attribute is missing/empty or when the value didn't meet the length requirement
Adding jsDoc for classes and method

Result in action in this pull request
https://github.com/bonitasoft/bonita-doc/pull/2731

With this update, we generate this report when contribution check failed:


Add sys software suite

@yavko

@yavko

i completely missed this sowwy

All's good!

Should be good now lmk

aight sick

Cool beans, Just as a heads up, sysvol will be renamed this week, likely in a few commits so uhh yeah keep ur heads up

Cool beans, Just as a heads up, sysvol will be renamed this week, likely in a few commits so uhh yeah keep ur heads up

oki, can u plz pr it then


Qh config

Update configuration plan
This should allow us to remove the aggie-experts-deployment project eventually, and just use this.
You  can test with
cmds/aggie-experts setup build
docker compose up

@rakunkel-ucd this tries to simplify building and running aggie-experts, but currently I haven't included building the harvest which is still cd images; make harvest but should be included here as well somehow.  I will add this into dev when I can verify that it works for @UcDust

@rakunkel-ucd  Review the changes here, and I'll add them into dev, and then we can pull in your request.  Most of these are fixes to the queries.


Moar doc examples

Wrote some simple examples on how to send and reply to messages. Also, atom made those weird whitespace changes :100: :ok_hand: :facepunch:
I saw Technoguyfication make a PR to master so I hope I am supposed to do so to.
If something needs to be changed, then let me know!

I'm glad to see people are actually taking on to this idea :D


add jsdoc style inline documentation to methods

Mentioned by @samselikoff as a task that would be good for new contributors. Adding JSDoc style comments for methods would help improve the overall quality of documentation.

Some more details:
YUIDoc is a syntax for adding comments to code. You add a comment to an object, method or property in a structured way, and then later you can run a tool to parse the comments from your code. The parsed comments can be used for all sorts of things, like autogenerating a documentation site. This is how Ember's API docs are generated - the descriptions for each object and method actually come from the code. This is great, because that means they stay up to date.
Here's an example of a YUIDoc for the Ember.Route#serialize method: https://github.com/emberjs/ember.js/blob/master/packages/ember-routing/lib/system/route.js#L341-L347.
I'd love to get this into Mirage! We could eventually autogenerate the API docs from the code, which would be amazing.
A great place to start in Mirage would be the new orm/Model class.

Here's the class
And here's the docs from the site

Note the methods in the "Class methods" section are on schema.js, so you can ignore those as a first pass.

The idea would be, basically copy the info from the docs, and write it as structured YUIDoc in the code, adding the important things like @method, @param, and so on, and marking methods @private or @public.
I would probably start with a single file and then PR it, and we can discuss from there.

For anyone else interested in jumping in, check Liz's PR for a great example on a single class.

Trying to figure out which file to tackle next - any suggestions? I couldn't find any more that were quite as straightforward (in terms of their being similar enough to the docs that I could easily figure it out) as the ones I've already done. I can easily just pop in the basics (making note of the function name, params, and whether public/private) on any file, if that's helpful.

I think it is helpful, definitely. I'm wondering what the path for us to get to autogenerated API docs from the YUI comments would look like. I think ember-concurrency does this, and they even have Travis autobuild + deploy. If you want to, you could look into how they do that. Would be really great if we could ensure the API docs are always in sync with the code comments!

That would indeed be sweet - I will look into that over the next few weeks (will be easier after RailsConf 😛 ) and I'll get started adding some generic comments to the other files.

Started messing around with ember-cli-yuidoc (which is how the Ember API docs are generated). I was able to generate some HTML pages, but still trying to figure out exactly how to parlay these into an actual documentation site. Sadly, the documentation for the addon is not super helpful, but I'll keep futzing with it and see what I can get!

@samselikoff You're just looking for people to start adding the docblocks now, not actually work on generating anything from them, yet? If so I'm interested in this one. I saw Waffle.io recently added support for multiple assignees for a ticket. With that in mind I'm interested in this one.

@alecho yes sir. That would be wonderful. Why don't I make a new ticket for each undocumented class, and we can track it that way

Add one to Ready and the rest to the top of Chores: https://waffle.io/samselikoff/ember-cli-mirage
Closing this issue for now since we've kicked off the process. Thanks everyone for getting this started!


Adding child node to the node returned from onNodeSelected fails

I was trying to use the node returned from event hooks (e.g. onNodeSelected(event, node)) as parent and to add a child to that parent without success. Here is an emulating code of what i was doing.
$("#tree").treeview({
  // ...
   onNodeSelected: function (event, node) {
      var folder = {
        name: "child",
        // ...
      };
      $("#tree").treeview(true).addNode(folder, node);
  },
// ...
}

The cause of that is the node returned from the hook is a deep copy. See below code
        // ...
        this._triggerEvent('nodeSelected', node, options);
        // ...
       Tree.prototype._triggerEvent = function (event, data, options) {
		if (options && !options.silent) {
                        // $.extend(true, {}, data) is a deep copy of the original node.
			this.$element.trigger(event, $.extend(true, {}, data));
		}
	}

So, adding child is to add child to the copy which has no effect to the tree.
The issue can be worked around by getting the original node (see below). Wound it be better to return the original copy? Is it intentional to return a replicate over original to avoid internal data structure being messed up? Thanks.
$("#tree").treeview({
  // ...
   onNodeSelected: function (event, node) {
      var folder = {
        name: "child",
        // ...
      };
      var parent = $("#tree").treeview(true).findNodes(node.id, "id");
      $("#tree").treeview(true).addNode(folder, parent);
  },
  // ...
}

Any solution for this?

$('#tree').treeview(true).addNode(nodes=s_nodes,$('#tree').treeview('getSelected'));


Does this only work with shelley era?

I was trying this out and got the following error:
cardano_clusterlib.clusterlib.CLIError: An error occurred running a CLI command `cardano-cli transaction submit --testnet-magic<PHONE_NUMBER> --tx-file send_funds_tx.signed --cardano-mode` on path `/home/pwnbox/cardano`: Command failed: transaction submit  Error: Error while submitting tx: ShelleyTxValidationError ShelleyBasedEraAlonzo (ApplyTxError [UtxowFailure (WrappedShelleyEraFailure (UtxoFailure (OutputTooSmallUTxO [(Addr Testnet (KeyHashObj (KeyHash "44d0f363b17fe23435609fd2e9bc5bf8b7379c11597320789a20b97d")) StakeRefNull,Value 206721 (fromList [(PolicyID {policyID = ScriptHash "6b8d07d69639e9413dd637a1a815a7323c69c86abbafb66dbfdb1aa7"},fromList [("",2)])]),SNothing)])))])

I believe in the state_dir I provided the shelley-genesis.json. Should I be providing, alonzo/genesis.json?

The important part is OutputTooSmallUTxO. That happens when one of the transaction outputs is less than minimal amount, which is around 1 ADA on mainnet. It can be either the amount you are trying to transfer, or the resulting change.

@mkoura Yes I actually looked at it, I was testing on testnet and in the UTxO I had 100 tADA, and I was trying to transfer 10 ADA so not sure why would that happen.

Can you post how you called the python function? Or do you have the transaction file? The only idea I have is that you specified output for change in addition to the 10 tADA transfer, and the change amount was not precise.

from cardano_clusterlib import clusterlib
import sys

SRC_ADDR = "MY_ADDR"

def main():
    dst_addr = sys.argv[1]
    amt = int(sys.argv[2])*1000000
    print(dst_addr, amt)
    cluster = clusterlib.ClusterLib(state_dir="cardano/testnet/configs")
    destination = [clusterlib.TxOut(address=dst_addr, amount=amt)]
    tx_files = clusterlib.TxFiles(signing_key_files=["cardano/payments/payment_addr_1/payment.skey"])

    tx_raw_output = cluster.send_funds(
        src_address=SRC_ADDR,
        destinations=destination,
        tx_name="send_funds",
        tx_files=tx_files,
    )

    cluster.wait_for_new_block(new_blocks=2)
    cluster.get_utxo(dst_addr)

if __name__ == "__main__":
    main()

I call this script in the following way:
python3 transfer_ada.py <ANOTHER_ADDR> 10

Thanks @mzfr!
When used this way, without specifying input UTxOs explicitly (send_tx(txins=...), the UTxOs are selected so that their total tADA amount can satisfy all transaction outputs and fee. Unfortunately minimum change value is not taken into consideration, so it can happen that the remaining change is lower than allowed and the change UTxO cannot be created.
I should probably hardcode a meaningful default for min change value that works for testnet and mainnet instead of 0 (until I come up with more precise computation). In the meantime, you can do
cluster = clusterlib.ClusterLib(state_dir="cardano/testnet/configs")
cluster._min_change_value = 1500_000

I've changed the hardcoded _min_change_value from 0 to 1800000 Lovelace. The code that selects input UTxOs will take it into account. It is released in https://pypi.org/project/cardano-clusterlib/0.1.48/

@mkoura Thanks for updating this. I'll try it out with the latest version and then close this issue if I don't encounter any problem with it.

@mkoura This works like a charm, thanks once again :)


[Bug]: Very big + sign in Page Settings : Advanced : S.E.O. for Add Url

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
After upgrading to DNN 9.13.4 (from DNN 9.13.3), the Plus icon for adding an Url is very big (really, very, very big).
Steps to reproduce?

Goto Page Settings : Advanced : S.E.O.
See the icon

Current Behavior
No response
Expected Behavior
Like it was before...
Relevant log output
No response
Anything else?
As the release of 9.13.4 is not listed in the dropdown below I choose the alpha. It happens in the release.
Affected Versions
9.13.4 (alpha)
What browsers are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi Michael,
I think there is already a issue reported: [Bug]: Add icon is huge in pages SEO tab #6116
Can you doublecheck if your issue belongs to the same problem.
Regards, Wolfgang

Wolfgang, you are right. I did not find this when I searched the issues.

Duplicate of #6116

Closes as #6116 already has documentation about a fix


Slick is not work with jQuery 3 or higher

When i use jQuery version 3.0 or higher, slick slider is not working.

Having this issue as well, any update on when this will be compatible with jQuery 3, thanks!

Merged a fix into the new master. You can grab that. There's another issue on this subject if you'd like to learn more about the breaking changes to jQuery.

I did grab it, still no luck. Using the master repo, I changed jquery from 2.2.0 to 3.1.0 and the sliders stopped working.

Can you recreate in a fiddle or codepen?

https://jsfiddle.net/7gaw3hra/
i didnt change anything except the JS on line 133

Check the console for errors

No errors. Works fine when I change it back to 2.2.0.

Anyway it works here with jQuery edge: https://jsfiddle.net/simeydotme/fmo50w7n/

So I figured out the problem with your implementation. The reason slick broke w/ jquery 3 is because we used on ready which you are using in your code.
 $(document).on('ready', function() { ... }

Thank you that works! Sorry, I literally pulled the repo and only changed the version of jQuery in the index.html.

Slick Playground

``

CHANGE JS

Should we remove $(document).on('ready', function() { ... } to solve above issue.

Try jquery with noConflict and all is work fine.
Create new constant from jQuery with no conflict and slick slider will work.

<script src="slick/slick.js'>

So I figured out the problem with your implementation. The reason slick broke w/ jquery 3 is because we used on ready which you are using in your code.
 $(document).on('ready', function() { ... }

I was able to solve this when I replaced the above function with
$(function () {

So I figured out the problem with your implementation. The reason slick broke w/ jquery 3 is because we used on ready which you are using in your code.
 $(document).on('ready', function() { ... }

This fixed my issue after using code outside:  $(document).on('ready', function() { ... }


Invalid raw data order in the docstring

Given code like that:
# frozen_string_literal: true

module Karafka
  # Namespace for all elements related to requests routing
  module Routing
    # Karafka framework Router for routing incoming messages to proper consumers
    # @note Since Kafka does not provide namespaces or modules for topics, they all have "flat"
    #  structure so all the routes are being stored in a single level array
    module Router
      # Find a proper topic based on full topic id
      # @param topic_id [String] proper topic id (already mapped, etc) for which we want to find
      #   routing topic
      # @return [Karafka::Routing::Route] proper route details
      # @raise [Karafka::Topic::NonMatchingTopicError] raised if topic name does not match
      #   any route defined by user using routes.draw
      def find(topic_id)
        App.consumer_groups.each do |consumer_group|
          consumer_group.topics.each do |topic|
            return topic if topic.id == topic_id
          end
        end

        raise(Errors::NonMatchingRouteError, topic_id)
      end

      module_function :find
    end
  end
end

when I print the docstring for the #find I get this:
Find a proper topic based on full topic id
@param [String] topic_id
  proper topic id (already mapped, etc) for which we want to find
  routing topic
@raise [Karafka::Topic::NonMatchingTopicError] raised if topic name does not match
  any route defined by user using routes.draw
@return [Karafka::Routing::Route] proper route details

The order does not match on the tags, while the docstring docs state:
    # @return [String] the raw documentation (including raw tag text)
    attr_reader :all

I print it like so:
puts object.docstring.all

Shouldn't raw contain raw data? Is there a way to get actual raw data?

The contact for #all is to provide access to the raw data used to generate an equivalent Docstring. This may differ from source due to post processing. Docstrings don't actually maintain relative tag position, so if you really want source, you can use object.files to get line information for the declaration and parse upwards for comments.

Thank you. That is more than enough for me.


HBASE-23376 NPE happens while replica region is moving

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 55s
master passed

+1 :green_heart:
compile
0m 25s
master passed

+1 :green_heart:
checkstyle
0m 34s
master passed

+1 :green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
master passed

+0 :ok:
spotbugs
1m 11s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  9s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
the patch passed

+1 :green_heart:
compile
0m 24s
the patch passed

+1 :green_heart:
javac
0m 24s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m  9s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 21s
the patch passed

+1 :green_heart:
findbugs
1m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

52m 51s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-906/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/906

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f981b8c595f5 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-906/out/precommit/personality/provided.sh

git revision
master / 9c82a65b29

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-906/1/testReport/

Max. process+thread count
265 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-906/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Add a unit test for this case?


With setting a title attribute mayhaps

I'm currently using angular-moment like this:
<time ng-if="event.archive_time" title="{{ formatDate(event.archive_time) }}" am-time-ago="event.archive_time"></time>

It works great because it displays it as "2 hours ago" but when you hover over the text you get the full, accurate, description of the date.
Could this be something built into angular-moment perhaps?

+1 for such a feature!


api.go: add constructor variant for organizations

To set the OpenAI-Organization header, if appropriate.
https://beta.openai.com/docs/api-reference/authentication

Thank you so much for PR!

Thanks for the library!


Out of the box test coverage is not 100%

PR for issue #1386
> react-scripts test --env=jsdom "--coverage"

 PASS  src/App.test.js
  ✓ renders without crashing (18ms)

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |       50 |      100 |      100 |       50 |                |
 App.js   |      100 |      100 |      100 |      100 |                |
 index.js |        0 |      100 |      100 |        0 |              1 |
----------|----------|----------|----------|----------|----------------|
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        1.137s
Ran all test suites.

Thanks for the PR!
I’m closing this PR—please see my comment in https://github.com/facebookincubator/create-react-app/issues/1386#issuecomment-279172682 for an explanation.
I appreciate the time you took to send it though.


[baseline][osg] Prefer GLVND libraries

Fixes an osg build error, occuring in vcpkg CI. Cf. https://github.com/microsoft/vcpkg/issues/28087. (But this PR doesn't resolve the issue that "#include <GL/gl.h> is ambiguous on case-insensitve file systems".)

Hm, now osg build step doesn't find GL/glext.h. Despite depending on opengl-registry which does install the file.

Now tested with both opengl-registry and mesa installed before osg: It is just a matter of preferring GLVND libraries. osg is stuck at cmake_minimum_required(VERSION 2.8.0) but needs to use the new CMP0072 behaviour.
FTR there was a warning about CMP0072 in local linux logs but not x64-windows-static-md failure logs from CI.

Hmm that policy affects windows? Seems like a bug to me since glvnd isn't available on windows.

https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindOpenGL.cmake#L157 doesn't even search for libs it also doesn't set OPENGL_INCLUDE_DIR.
And no the policy does not affect windows.

hmm have you tried  /showIncludes in  VCPKG_C(XX)_FLAGS ?

No, I'm still learning MSVC ;-) It is a pity that the include path is not logged.
And it is a shame that the llvm artifact still breaks caching.

#27279 has a libglvnd port if you need it.


Sanitize test subjects before tests.

This test suite will fail if the subjects are not properly deleted in a previous run. Attempts to wipe the subjects before running the suite to compensate for past failures.
Closes https://github.com/apache/incubator-openwhisk/issues/3136.

Needs a pg.

PG1 2670 ⏳

@rabbah, needs rebasing for PG.

@dubeejw I added a commit and rebased

PG2 2884 ⏳

@markusthoemmes,
.../open/tests/src/test/scala/limits/ThrottleTests.scala:49: Unused import
import scala.util.{Failure, Success, Try}

Thanks @markusthoemmes @dubeejw


Update Witherspoon.py in test data

Sync witherspoon sekelton data
https://github.com/openbmc/skeleton/blob/master/configs/Witherspoon.py

As part of the cleanup for Firestone and Garrision.. we will need to pull data to update..

https://gerrit.openbmc-project.xyz/#/c/10971/


Add {PENKY}: {Penky}

[x] I understand that token listing is not required to use the Polygon Wallet with a token.

Please provide the following information for your token.
Token Name: Penky
Token Symbol: PENKY
Decimals: 18
Polygon Address: 0x3A35e98cC7390A15d458Bb85f9a12823e2eF25eD
Ethereum Address: 0xF8939164A46fBe9Fc923F837221EB541E3C7e7b0
Logo URI: https://i.postimg.cc/ryJ2smy4/Penky-Logo-Round-300x300.png
Project Name: Penky
Project Summary:
Project Contact: Jimmy white
Project Website: https://penky.io
Mainnet/Testnet:
Additonal Notes:

Please provide an email address as the Project Contact @PenkyArena


Editing one form causes another on the same page to re-render

I'm currently debugging some performance issues related to forms on an application I am building, and one in particular seems very strange.
At some points there are two forms on the page - one for search filters, another for a data entry form in a modal. Typing in the data entry modal is noticeably sluggish, and the main culprit seems to be the ReduxFormConnector component - which makes some sense for the form in which I am typing, but there is no reason for the other form to be re-rendering.
Below is Perf.printInclusive() output while typing into the InfluencerDetailView form - as you can see, most of the time is spent rendering the SearchFilters form, even though that form isn't changing at all (and is not subscribed to any parts of the state that may change).

Digging deeper, I added the pure render decorator to the SearchFilters component (which is wrapped in reduxForm - BTW, is it best practice to implement shouldComponentUpdate or should redux-form do it itself?) and added some debug to the shallowEqual check on the props, and the props which are causing it to re-render are all the functions passed in by redux-form ('asyncValidate', 'destroyForm', 'initializeForm', 'resetForm', 'touch', 'touchAll', 'untouch', 'untouchAll').
I tried ignoring these when doing the pure render comparison but that breaks the form.
Any ideas?
Cheers,
Tom

Are the two forms attached to the same form slice? i.e. is the form parameter to reduxForm() the same for both of them?

No, one has form: 'search' and the other form: 'influencer'
On 16 December 2015 at 16:46, Erik Rasmussen<EMAIL_ADDRESS>wrote:

Are the two forms attached to the same form slice? i.e. is the form
parameter to reduxForm() the same for both of them?
—
Reply to this email directly or view it on GitHub
https://github.com/erikras/redux-form/issues/432#issuecomment-165170760.

same thing happens to me :(

Hi @beeant, do you mind opening a new issue with a reproducible example, please?
This issue probably referred to some really old version like v3 or v4, so I'll close it.


How to catpure connection errors in the SFTP read stream

I have some code that can access a number of different network/file resources, including a SFTP server.  This code gets a Stream from any of those different resources and then pipes it doing some processing.
Our problem is that for ssh2-sftp-client, if the connection drops the stream does not fail. We have added keepAliveInterval to have an error event when the connection drops, but that event does not make our stream fail.  Are we doing anything incorrectly?  We would like the stream to fail so we can capture the error, is that possible? Otherwise, what would be your recommended approach to make sure the download() method below fails?
Sample pseudocode where client is an abstraction over ssh2 sftpclient (with some other implementations):
async download() {
await client.connect(params);
const stream = await client.getReadStream(name);
return new Promise((resolve, reject) => {
stream
.on('error', err => {
LOG.error(Error {err}, Full stack: ${err.});
reject(err);
})
.pipe(unzipper.Parse())...
}

getREadStream is not part of the ssh2-sftp-client library -0 that is a function from the underlying SSH2 and SSH2 sftp-streams libraries, which do not use promises. The ssh2-sftp-client library is a convenience library that just uses these other underlying libraries, wraps some useful extensions as promises etc. If you want to interact directly using streams, you are probably better off just using the underlying libraries directly.  Alternatively, use the get method, passing it a writeable stream (which could be for example a zlib unzip stream). It will return a promise that is either resolved or rejected if there is an error.


Crash while mouse-selecting in two-buffer mode

Steps to reproduce:

Open second buffer (Ctr-W v)
Drag mouse cursor starting from area right to last character column in right buffer.

Vim crashes with message:
Vim: Caught deadly signal SEGV
Vim: Finished.

Archlinux
vim 7.4
konsole

Hi Kirill!
On Mi, 18 Nov 2015, Kirill Ivashov wrote:

Steps to reproduce:

Open second buffer (Ctr-W v)
Drag mouse cursor starting from area right to last character column in right buffer.

Vim crashes with message:
Vim: Caught deadly signal SEGV
Vim: Finished.

Archlinux
vim 7.4
konsole

I might be missing something. While I can select with the mouse, I don't
know how to drag with the mouse. So how do you drag?
Can you reproduce using vim -u NONE -N?
Please give exact patch level.
Best,
Christian
Politik besteht nicht selten darin, einen simplen Tatbestand so zu
komplizieren, daß alle nach einem neuen Vereinfacher rufen.
-- Giovanni Guareschi

vim -u NONE -N
:set mouse=a
2.5. Ctr-W v
click as right as possible (terminal size should be larger than column size * column count
move cursor left
vim crashes

vim 7.4.884
also in neovim with more detailed error message: https://github.com/neovim/neovim/issues/3704

I might be missing something

it is possible, i barely can write in English

I can't reproduce this, though I am seeing incorrect behaviour.

click as right as possible (terminal size should be larger than column size * column count

I don't know what "column size" and "column count" refer to, sorry.
Making my konsole 248 columns wide, if I click as far right as possible, nothing happens (vim should move the cursor to the right window).  Using ctrl-V indicates that konsole won't tell vim a mouse click beyond column 222.  xterm can, it's using a different control sequence for this now.
My konsole is KDE Frameworks: 5.9.0, konsole 3.0.1. on Kubuntu
Regards, John Little

if I click as far right as possible
Issue title states not "clicking" but "selecting" which means "Hold left mouse down and move cursor".

Also in Opensuse 13.1

On Thursday, November 19, 2015 at 10:19:23 PM UTC+13, Kirill Ivashov wrote:

if I click as far right as possible
Issue title states not "clicking" but "selecting" which means "Hold left mouse down and move cursor".

There's confusion here, or at least I am.  There are two "cursors": the mouse cursor and what I'll call the "text cursor" (note this is usually what konsole and vim mean by "cursor"; I have blinking cursor checked on the advanced tab of editing the profile).
Do you mean "hold left mouse down and move mouse to the left"?  I haven't been able to reproduce any problem, however I move anything.  Aha, I just did it.  I had to type a lot of text, and do lots of mouse dragging.  The handling of the visual highlighting before that didn't inspire confidence, with the wrong parts of the text being highlighted.
I suspect your problem may have something to do with "extended coordinates".
What does
set ttymouse?
tell you?
Regards, John Little

Can you get a debug build and post a backtrace? Once you have compiled with DEBUG enabled (see the Makefile how to do it), simply run gdb --args ./vim -u NONE -N and once it crashes and  you are left in the debugger, post the output of bt

Do you mean "hold left mouse down and move mouse to the left"?

yes
ttymouse=xterm2

Can you get a debug build and post a backtrace?
yes, i am just doing it now

#0  0x00007f7515f79937 in kill () from /usr/lib/libc.so.6
#1  0x000000000051e9db in may_core_dump () at os_unix.c:3389
#2  0x000000000051e97f in mch_exit (r=1) at os_unix.c:3355
#3  0x00000000005e9482 in getout (exitval=1) at main.c:1529
#4  0x00000000004daf5a in preserve_exit () at misc1.c:9600
#5  0x000000000051cb00 in deathtrap (sigarg=11) at os_unix.c:1118
#6  <signal handler called>
#7  0x00000000005c7627 in win_drag_vsep_line (dragwin=0x1fec840, offset=1) at window.c:5790
#8  0x00000000005b6c7d in jump_to_mouse (flags=7, inclusive=0x7ffd8de7add4, which_button=0) at ui.c:2861
#9  0x00000000004f32af in do_mouse (oap=0x7ffd8de7adc0, c=-11773, dir=-1, count=1, fixindent=0) at normal.c:2784
#10 0x00000000004f6657 in nv_mouse (cap=0x7ffd8de7ace0) at normal.c:4686
#11 0x00000000004f0638 in normal_cmd (oap=0x7ffd8de7adc0, toplevel=1) at normal.c:1163
#12 0x00000000005e917a in main_loop (cmdwin=0, noexmode=0) at main.c:1351
#13 0x00000000005e8bc7 in main (argc=4, argv=0x7ffd8de7b0d8) at main.c:1050

Kirill Ivashov wrote:

#0  0x00007f7515f79937 in kill () from /usr/lib/libc.so.6
#1  0x000000000051e9db in may_core_dump () at os_unix.c:3389
#2  0x000000000051e97f in mch_exit (r=1) at os_unix.c:3355
#3  0x00000000005e9482 in getout (exitval=1) at main.c:1529
#4  0x00000000004daf5a in preserve_exit () at misc1.c:9600
#5  0x000000000051cb00 in deathtrap (sigarg=11) at os_unix.c:1118
#6  <signal handler called>
#7  0x00000000005c7627 in win_drag_vsep_line (dragwin=0x1fec840, offset=1) at window.c:5790

Can you edit window.c and show that line, and some context?  The line
number changes when inserting/deleting lines.

#8  0x00000000005b6c7d in jump_to_mouse (flags=7, inclusive=0x7ffd8de7add4, which_button=0) at ui.c:2861
#9  0x00000000004f32af in do_mouse (oap=0x7ffd8de7adc0, c=-11773, dir=-1, count=1, fixindent=0) at normal.c:2784
#10 0x00000000004f6657 in nv_mouse (cap=0x7ffd8de7ace0) at normal.c:4686
#11 0x00000000004f0638 in normal_cmd (oap=0x7ffd8de7adc0, toplevel=1) at normal.c:1163
#12 0x00000000005e917a in main_loop (cmdwin=0, noexmode=0) at main.c:1351
#13 0x00000000005e8bc7 in main (argc=4, argv=0x7ffd8de7b0d8) at main.c:1050

--
Nobody will ever need more than 640 kB RAM.
-- Bill Gates, 1983
Windows 98 requires 16 MB RAM.
-- Bill Gates, 1999
Logical conclusion: Nobody will ever need Windows 98.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

    if (room < offset)          /* Not enough room */
        offset = room;          /* Move as far as we can */
    if (offset <= 0)            /* No room at all, quit. */
        return;

    /* grow frame fr by offset lines */
    frame_new_width(fr, fr->fr_width + offset, left, FALSE);

    /* shrink other frames: current and at the left or at the right */
    if (left)
        fr = curfr;             /* current frame gets smaller */
    else
        fr = curfr->fr_next;    /* next frame gets smaller */

Which one is line 5790? Can you print the value ofr fr and curfr? (use p fr and p curfr on the gdb prompt at frame 7)

Hi,
2015-11-20(Fri) 6:43:29 UTC+9 Christian Brabandt:

Which one is line 5790? Can you print the value ofr fr and curfr? (use p fr and p curfr on the gdb prompt at frame 7)

I can reproduced it.  (fedora21 + konsole)
and make a patch.
Please check this.
--
Best regards,
Hirohito Higashi (a.k.a h_east)

Hi,
2015-11-20(Fri) 14:20:48 UTC+9 h_east:

Hi,
2015-11-20(Fri) 6:43:29 UTC+9 Christian Brabandt:

Which one is line 5790? Can you print the value ofr fr and curfr? (use p fr and p curfr on the gdb prompt at frame 7)

I can reproduced it.  (fedora21 + konsole)
and make a patch.
Please check this.

Above patch is for a last resort.
It is strange that the variable on_sep_line set 1 in jump_to_mouse().
I will take a look a little more.
--
Best regards,
Hirohito Higashi (a.k.a h_east)

Hi,
2015-11-20(Fri) 15:10:26 UTC+9 h_east:

Hi,
2015-11-20(Fri) 14:20:48 UTC+9 h_east:

Hi,
2015-11-20(Fri) 6:43:29 UTC+9 Christian Brabandt:

Which one is line 5790? Can you print the value ofr fr and curfr? (use p fr and p curfr on the gdb prompt at frame 7)

I can reproduced it.  (fedora21 + konsole)
and make a patch.
Please check this.

Above patch is for a last resort.
It is strange that the variable on_sep_line set 1 in jump_to_mouse().
I will take a look a little more.

I found the root cause.
konsole mouse button reporting is wrong.
When konsole size is 144x24 and press the upper right corner,
konsole sends following escape sequence (*1).
ESC  [    M    Cb   Cx   Cy
0x1b 0x5b 0x4d 0x20 0xb1 0x21
Cx,Cy is coordinates of the mouse event. The upper left corner is (1,1).
(In fact it is added ' '.  (0x20))
So, actual x,y is (145, 1)
x is wrong!!
When press the upper left corner, konsole send below.
ESC  [    M    Cb   Cx   Cy
0x1b 0x5b 0x4d 0x20 0x22 0x21
Actual x,y is (2, 1)
Obviously wrong!
This is a konsole bug, but we should guard in Vim side.
In something like this:
if (mouse_col >= Columns)
mouse_col = Columns - 1;
(*1)
See Page 5. 'Mouse Tracking' of this document.
http://www.x.org/docs/xterm/ctlseqs.pdf
Best regards,
Hirohito Higashi (a.k.a h_east)

fixed with https://github.com/vim/vim/releases/tag/v7.4.938


chore(main): release 0.2.0

:robot: I have created a release beep boop
0.2.0 (2024-03-17)
Features

Start docs (3cf346e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/philipcristiano/w2z/releases/tag/v0.2.0 :sunflower:


Eval logic

Hello! I'm trying to figure out the logic. As far as I understand, there are two (three) options in the config for the eval key:
1.1) specify 'pure' without injectors and then step.do_forward_backward will be performed
1.2) specify 'pure' with injectors, and then they will be executed
2) specify evaluators
Do I understand correctly that (1.2) differs from (2) in that there may be more complex logic in the evaluator than in the injector?
Anyway, I found a config (recipes/vqvae2/train_imgnet_vqvae_stage1.yml) in which the eval key has neither the pure key nor the evaluators key, but the injectors key right away. How will it work in this case?

Pure=true will use the training losses for evaluation, which is an effective way of monitoring for overfitting a lot of the time and requires no effort on your part.
Frankly, i dont manually specify eval injectors anymore. I would not be surprised if that option was broken in some way and i dont recommend using it unless you want to do some testing.
The evaluator path is my recommendation if you want a custom eval metric like fid, accuracy, wer, etc.  This is very important for diffusion and gan models where the training losses are completely disconnected from downstream quality.
If you dont specify an evaluator or set pure=false, the trainer will just not do evaluation passes.

Thanks!


Nice custom form styles

Currently there are no form.custom.nice styles, so forms that combine the two look a little funny. This adds a minimal amount of styling to checkboxes and dropdowns inside of form.custom.nice to make them look at bit more like the nice styles.
Edit: Github didn't like my inline image, so here's a link instead: http://cl.ly/DE2l.

Purely visual thing - since the dropdowns would actually be popping up off the page rather than recessed, can we put the inset shadow on the bottom at 90 degrees, rather than top left? If you can modify that we'll just pull this in. Thanks!

Sure! I don't have time right now, but will update tomorrow evening.

Before: http://cl.ly/DQlL and after: http://cl.ly/DQTw. Is this the look that you wanted?

Fa shizzle - pulling this in. Thanks!

I didn't actually commit that yet. ;) Will open a new pull request.

Haha, fail. My bad. Yeah, if you open a new request against the current master I'll pull it in.

Added #236.


expression of find peak of "cc"

at https://github.com/xiongyihui/tdoa/blob/master/gcc_phat.py#L44, should the "np.abs()" be removed?
the GCC-PHAT is on top of cross-correlation, fine-tuned of cc.
The cc is real number, not complex number.
My understanding of the biggest positive value means: "at the shift point, the two signal are match best".
The negative of cc value is "at the shift point, the one signal is are more likely to match, when the second signal take upside-down flip (*-1).

Yes, np.abs() should be removed, unless there is a 180-degree phase difference between the two microphones.


Add support for foundationdb in integration test suite

Change Overview
This change adds foundationdb in our integration test suite.
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[x] :robot: Test

Issues

#452

Test Plan
To test the foundationdb we can use below command
make integration-test

The logs can be found at this gist.

[x] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

this looks great! Please include the output when running the test in the PR description

Hi @tdmanv
I actually mentioned the link to the log of the test. that is in a secret gist.


Syntax highlighting for numbers

Added syntax highlighting for numbers.

Looking good but somehow return 0 has no highlighting is it a bug? Only negative numbers return -1 ....

Good catch, yeah it's a bug seem to be caused as _is_symbol doesn't look for spaces, the fix would be to either add the check for space in _is_symbol or at this if statment


Modifying the php-fpm configuration file workspace container does not take effect

I did a build operation on php-fpm and wrkspace, but it still didn't work

Did you also run it with --no-cache?

@jasperf Workspace containers and php-fpm containers do not share the same configuration file,Why does the workspace container have PHP installed separately,If I need to change the configuration under workspace bash via vim

You did not add your docker-compose.yml here which would have helped. Workspace however does use PHP so you can run artisan commands from there which is one of the reasons we have Workspace. In your docker-compose.yml file you can configure it as well. PHP FPM container is used to process PHP for the application itself.

Maybe workspace and php-fpm share the same configuration file by default? Why not set the default?

Maybe workspace and php-fpm share the same configuration file by default?
No, they don't in Laradock. But you are of course always able to roll your own setup.
Why not set the default?
Because I guess a lot of people wanted flexibility and often want more in the workspace container than in the general purpose PHP FPM container. This because workspace is to manage ALL containers. Again, you can change it all.


Signin redirect does not works in production.

Hi,
In my application I need to set the signin redirect after the default page is loaded and click on login button from that default page.
This scenario works on debug mode but not in production.
It works in production only if I do it from app.ts in which case I loose the option to choose between register / login.
It does not throw any error in production, but it just never redirects and nothing loads in the page.
--app.ts
config.map([
{route: ['', 'login'],   name: 'login',   settings: { icon: 'home' },   moduleId: PLATFORM.moduleName('./login'),   nav: true,   title: 'Home'},
{route: 'profile',   name: 'profile',   settings: { icon: 'education', auth: true},   moduleId: PLATFORM.moduleName('./profile'),   nav: true,   title: 'Profile'},
]);
this.openIdConnect.configure(config);
this.config = config;
this.router = router;
-->pipeline step:
config.addPipelineStep('authorize', AuthorizeStep);
-->run method from AuthorizeStep:
async run(navigationInstruction, next) : Promise{
// currently active route config
let currentRoute = navigationInstruction.config;

// settings object will be preserved during navigation
let loginRequired = currentRoute.settings && currentRoute.settings.auth === true;

let user =  await this.openIdConnect.userManager.getUser();
  if (typeof user === undefined || user === null)
      {
       this.isAuthenticated = false;
      }
      else
        {
        this.isAuthenticated = true;
        }
if (this.isAuthenticated === false && loginRequired === true) {
  return next.cancel( this.openIdConnect.userManager.signinRedirect());
}
return next(this.isAuthenticated);

}
Could please help me to solve this. Tried to move the login page out from app configrouter and in the main.ts set the root to login.
if(app == null || app.user == null)
{
aurelia.start().then(() => aurelia.setRoot(PLATFORM.moduleName('login')));
}
else
{
aurelia.start().then(() => aurelia.setRoot(PLATFORM.moduleName('app')));
}
But this approach loads the login page always and after signin and redirect it loads login page 3 times and clicking login 3 times before it goes to my actual profile page which is added as my login redirect.
const oidcConfig: OpenIdConnectConfiguration = {
loginRedirectModuleId:  PLATFORM.moduleName("./profile"),
works in debug mode.

not in production.

Have you experimented with the demos here?
https://github.com/shaunluttin/aurelia-open-id-connect-demos
If you could please reproduce the issue you're experience in a public fork, that would speed up the troubleshooting that I can provide.

Have you added the client configuration in the server code for production? It might be the case you allowed your debug environment to communicate with the id server, but not the client on production.

Hi I have client configuration in place. Everything loads in production if I do not have login view included in the app routingconfig and set this as root in main. But the problem is even after login it takes 3 clicks to redirect to to app/profile.
That is the reason I used pipeline step and had all my views(including login) in app configrouter but that does not work in production.

There is a chance that protocol switching is the problem. In production, are you using HTTPS for all the pages?

Hi Shaunluttin , Yes my host,  id server, and other api urls everything is using https

Hi Shaunluttin, I will try to recreate using the demos.

Hi,
the problem is when I publish it in iis as application it does not redirect, but if I publish as a site it is working with all pages in single app router.
I have added web.config with rewrite rule as beloe to resolve the file not found error for static files.
Could this be the reason? or any changes in this would fix it?
Appreciate you suggestion on this.

                 </conditions>
                 <action type="Rewrite" url="/" appendQueryString="true" redirectType="Temporary" />
             </rule>
         </rules>
     </rewrite>
</system.webServer>

Apologies for not having responded... I have been away from the computer for a while.

Hi, I will be closing up stale issues by the end of the week.
Are you still experiencing this issue? Feel free to close this yourself. If you are still experiencing this issue, let me know as well, thanks!


update: release pipline

Is your feature request related to a problem? Please describe.
How should we handle releases?

This repo will be archived so closing this issue.


Update spring-context, spring-core to 5.2.9.RELEASE

Updates

org.springframework:spring-context
org.springframework:spring-core

from 5.2.8.RELEASE to 5.2.9.RELEASE.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.springframework" } ]

labels: library-update

Codecov Report

Merging #662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   81.39%   81.39%
=======================================
  Files         114      114
  Lines        3869     3869
  Branches       95       95
=======================================
  Hits         3149     3149
  Misses        720      720

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bf0df...ddf8af7. Read the comment docs.


Deprecated eval_format

supervised_classifier.py uses eval_format which is deprecated. It's used in the only_forward evaluation. @ciptah ?

Should be fixed now.


Resolve vcs type the same way as 'go get -u' does.

Basically it fixes restore command for private repositories.

Thanks!
Merged in 8063f550a728b76d3a1a828e45d482f7dbde61e7


Add support for XV Lidar Controller v1.2

Control the Neato XV Lidar with an Arduino compatible board.
https://www.getsurreal.com/product/xv-lidar-controller-v1-2?v=47e5dceea252
https://www.amazon.com/Neato-LIDAR-Laser-distance-sensor/dp/B00QSUJPSY
https://xv11hacking.wikispaces.com/LIDAR+Sensor

http://answers.ros.org/question/227816/limitations-of-neato-xv11-lidar-vs-rplidar-and-recommendations-for-buying-a-low-cost-lidar/

It is not a priority


[TASK] Handle Loading state for Account page

Description
Currently, we are using Suspense to handle loading state of the Account page. This is not a correct way since all components on that page are client-side.
Most likely we have to use loading.tsx provided by Nextjs to deal with this.
Video
Navigating to Account page on the live website still lagging (slower than Claim page)
https://github.com/webb-tools/webb-dapp/assets/69841784/72876777-3b6e-4839-a8fc-414dac4c57b1
Note: this is still quite fast on the live site so no need to prioritize this

Related #2239


Add password input

The 'password input' is a new form component added to version 5.3.0 of the GOV.UK Design System.
This change attempts to implement it with all of its custom behaviour and document it in the guide.

Yeah I was going to cover that in the release notes. Technically breaking but the old one didn't exactly do very much to start with, can't really see it causing any problems.


Distinction between Catalyst and generated Block

It would be fantastic if the catalyst could be something else than the Block that gets generated.
For example if the catalyst is a Magma Block the generator will create basalt. Something like that.
Right now that's not possible to do in the configs.

This is currently on my to-do list, which I will hopefully get around to soon. Thanks for the suggestion


Installation fails on Windows - mindash is not found

I tried to install cash which depends on vorpal but couldn't get it to install.
I'm no npm specialist (quite the opposite) but it seems that https://registry.npmjs.org/mindash returns a 404 error during npm install.
I tried to look for mindash but couldn't even find a Github repository for it.
Is this a known issue ?

My bad. Just did something very dumb. Give me a second.

Sorry about that. Latest version should be good now.

I can confirm it works now. Thanks !

:+1:


Hot Reloading causes error on click

When using hot reloading with react & webpack, on a reload, the reference to the element to check if clicking outside is lost.
Getting the error Uncaught TypeError: Cannot read property 'getInstance' of null on this block of code:
_proto.getInstance = function getInstance() {
      if (!WrappedComponent.prototype.isReactComponent) {
        return this;
      }

      var ref = this.instanceRef;
      return ref.getInstance ? ref.getInstance() : ref;
    };

With react-hot-loader/babel using webpack version 3.12.0

Testing with latest version of webpack seems to be working just fine. I am running the following:

webpack 3.12.0
babel-core 6.26.3
react-hot-loader 4.2.0

I think this may just be an issue with my old version of webpack, hopefully I will be able to upgrade soon.
Thanks!


feature/commonjsify-with-umd-export

asana
https://app.asana.com/0/10663154302695/76076528244858
problem statement
manual UMD maintenance can be tricksie
solution
simplify our lives by doing pure commonjs, but export a UMD compatible build w/ webpack
post npm link in halfpenny and npm link halfpenny in nodeapi...

i did this a while ago, but didn't commit and stage it.  unforch that means i gruntified, vs. our new goal of simple npm'ifying, but hey, big whoop.  who cares, it works!  we can npmify in another PR.

most of this PR is just file moves and de-UMD-ification.  the real meat is just the webpack config, https://github.com/MRN-Code/halfpenny/pull/1/files#diff-11e9f7f953edc64ba14b0cc350ae7b9dR1

ᕦ(WEBPACK)ᕤ
Sorry this took so long to review. Nice work.


NetBox v3.0-beta1 Support

As an FYI here is what changed that could impact or help the plugin:

HTML Template updates (support change from bootstrap 3 to bootstrap 5)
Overall UI tweaks
Custom Queue Support for Plugins netbox-community/netbox/issues/6651

If you find any issues or have any questions feel free to hit us on the slack or add a bug /issue or add to the umbrella UI issue netbox-community/netbox/issues/6797

Is this plugin working with 3.0.3

NetBox 3.0.X and 3.1.X support has been implemented.


Doc : PromptHelper - need more info on parameters

It would be great to have more information about parameters of PromptHelper :

Definition of parameters, the impact, for what they are used to
Precise the unity (nb of chars ? etc...)
Min / Max ?

Enventually, we can provide external link documentation from LLM Theory.

Agreed, we should definitely make the documentation clearer. Will take a todo here.

Hello, have you figured out the purpose of these parameters? I want to control the number of tokens used by the query each time. Which parameters are mainly used? @ezawadzki

@mingxin-yang I guess number of chars but not sure...

The documentation has been updated with more info on token parameters. All parameters related to chunk sizes are measured in tokens. Furthermore, the prompt helper isn't really user facing anymore. Instead, you can use the service context directly.
Check the docs out!
https://gpt-index.readthedocs.io/en/latest/core_modules/supporting_modules/service_context.html#configuring-the-service-context


No apparent buf8/16/32/64 documentation

The problem
Searching for "buf8" on docs.perl6.org returns no data.
Suggestions
These buffer types should probably be documented.

They definitely should. Thanks.

There are mentions here and there, but it's definitely not described or indexed. It's here, for instance.


project:adddependencies command adds features that doesn't exist

Your environment
OS : iOS Catalina 10.15.4
Node.js version : 13.13.0
suitecloud-cli version : 1.0.2
Terminal/CMD tool : iTerm2
Describe the bug
project:adddependencies command adds features that doesn't exist.
For example, when editing a transactionForm, the following features are added as a dependency:
NOTTAX_OVERHAULING, VATNOTTAX_OVERHAULING, DOCUMENTS, VATORTAX_OVERHAULING, PERLINETAXNOTTAX_OVERH
When triggering project:deploy command right after, I receive the below for each of the above dependencies:

Details: The NOTTAX_OVERHAULING feature defined in the manifest does not exist.

To Reproduce
Steps to reproduce the behavior:

Add the attached transactionForm XML to the project - custform_6_2239021_717.txt (modify to .xml)
Run suitecloud project:adddependencies
Run suitecloud project:deploy

Actual Behavior
Receiving the below error:

Details: The NOTTAX_OVERHAULING feature defined in the manifest does not exist.

Expected Behavior
Deploy should succeed

@omrilit we are checking it, will get back to you soon with our findings.

@alii-gator any updates on this one?

@omrilit We have started working on this at priority bases. We will have update soon.

Another for the investigation:
project:validate told us:
Line No. 1 - Error Message: The following dependencies are missing from the manifest.xml file: [Feature - WMSSYSTEM:required]
But upon adding it via project:adddependencies:
Error Message: The "WMSSYSTEM" feature defined in the manifest does not exist.

@omrilit Can you please verify this in latest version 1.1.0?

Seems like this bug is indeed resolved in this version, but the same attached transactionForm still produces some errors upon deploy. I will open a separate ticket on it.

@omrilit Thanks for confirmation.
Yes, there are some issues still being worked on. Feel free to open the a new ticket.


Monitor Masterleague API

Right now, they dont have the newest patch (which is 9 days old).

[ ] remove hotfix for new talents not being present
[ ] think about alternatives

decision until season start please

As of today, they have the KTZ patch, but not the Cassia changes from 2 days ago. Continues to be unreliable

Decision: No longer use Masterleague.


docs: Update and extension of Javadocs for entities

Pull Request
Description
This PR extends Javadocs for all entity classes and enums.
Related to #307.
Also, refactored source code where needed.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Code cleanup/refactoring
[X] Documentation update
[ ] This change requires a documentation update
[ ] CI system update
[ ] Test Coverage update

Checklist:

[X] My code follows the style guidelines of this project
[x] My code meets the required code coverage for lines (90% and above)
[x] My code meets the required code coverage for branches (80% and above)
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6600bd2) 91.36% compared to head (8fab7f7) 91.34%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #355      +/-   ##
============================================
- Coverage     91.36%   91.34%   -0.02%
+ Complexity      478      475       -3
============================================
  Files            49       48       -1
  Lines          1609     1606       -3
  Branches        194      194
============================================
- Hits           1470     1467       -3
  Misses           82       82
  Partials         57       57

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix wrong item width calc in GPP flickity carousels

Reported in https://artsy.slack.com/archives/C03JWJLLH/p1503332879000518
Problem
Upon initial load in smaller viewport, some carousels on GPP have overlapping items. Once we resized the window, it's back to normal.
Solution

We can simply call flickity.resize() immediately after initialization but it's more expensive. It turned out the initial template rendering had wrong width for the overflowing items in a flexbox item, and that caused flickity to calculate wrong item width in it's initialization.
I can reproduce the CSS problem here.
I think the issue was that overflowing children in a flex-basis: 100% flexbox item have trouble calculating their width based on percentage, and we have to explicitly specify width: 100% on the flexbox item again to make it work.

Going to merge and give it a try! Thanks, @anandaroop for the review!