[gardening] align platform checks when enabling bitcode inclusion

use quoted arguments when referencing "SWIFTLIB_SINGLE_SDK"
break the first condition on multiple lines

This will make changes to these conditions easier to review.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 3b82dc008c808858d84b97faa15e9a7375941fa7

@swift-ci please smoke test macOS

@swift-ci please test macOS

@compnerd yes, that's my intention.


Adding Cursor animation

Currently, the cursor is just an arrow, adding a circle animation to the cursor for better UI.

Team 4(Nilisha, Johnpaul and Eshika) are working on this.


[macvlan] ARP traffic routing between container and host interface

I've hit an issue where ARP traffic across a macvlan (bridge) network isn't being routed as I expect. I'm hopeful someone with macvlan expertise could shed some light onto what's going on.
In brief, a tap device within a container (bridged with the container's default interface) makes an ARP request out over the vlan network, a reply is sent but not received by the container. I suspect this is due to some macvlan routing policy conflicting with the (arbitrary) mac address of the tap device, but I know of no way to observe/confirm this. Here’s the setup:
$ docker info | grep Version
Server Version: 17.10.0-ce
Kernel Version: 3.13.0-63-generic

On a (local/physical) host machine I configure a docker network using the macvlan driver:
docker network create --config-only --subnet <IP_ADDRESS>/24 --gateway <IP_ADDRESS> -o
parent=eth0.1098 --ip-range <IP_ADDRESS>/27 mv-config
docker network create -d macvlan --scope swarm --config-from mv-config --attachable mv-net

I create an interface on the host visible to the network:
ip link add eth0.1098.br link eth0.1098 type macvlan mode bridge
ip addr add <IP_ADDRESS>/24 dev eth0.1098.br
ip link set dev eth0.1098.br up

As expected, a container on the network can ping the host interface and vice versa:
docker run --network=mv-net -it netdebug ping -c 3 <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.139 ms

--- <IP_ADDRESS> ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 0.139/0.139/0.139/0.000 ms

Here's where it gets interesting...
Inside of a container I create a tap interface and bridge it with eth0.
ip link add name br0 type bridge
ip link set dev br0 promisc
ip link set dev br0 up
ip tuntap add dev tap0 mode tap multi_queue
ip link set tap0 master br0
ip link set dev tap0 promisc on
ip link set dev tap0 up
ip link set dev eth0 down
ip addr flush eth0
ip link set dev eth0 promisc on
ip link set tap0 master br0
ip link set dev eth0 up

When I attached a process to the tap (w/ IP <IP_ADDRESS>) and attempt to ping the host interface (<IP_ADDRESS>), a broadcast ARP request is sent over the internal bridge, and out to the vlan interface on the host. However, the reply does not arrive back within the container, despite it being sent back over via the same interface it came in on.
ARP traffic seen within the container:
root@97b58e38d106:/# tcpdump  -e -i br0 arp
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on br0, link-type EN10MB (Ethernet), capture size 262144 bytes

20:34:50.988296 62:56:ba:21:f7:9a (oui Unknown) > Broadcast, ethertype ARP (0x0806), length 42: Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
^C
1 packet captured
1 packet received by filter
0 packets dropped by kernel

ARP traffic seen on the host:
root@host:~ $ tcpdump -e -i eth0.1098 arp
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on eth0.1098, link-type EN10MB (Ethernet), capture size 262144 bytes
16:34:50.988316 62:56:ba:21:f7:9a (oui Unknown) > Broadcast, ethertype ARP (0x0806), length 42: Request who-has <IP_ADDRESS> tell <IP_ADDRESS>, length 28
16:34:50.988378 92:22:a1:de:d5:eb (oui Unknown) > 62:56:ba:21:f7:9a (oui Unknown), ethertype ARP (0x0806), length 42: Reply <IP_ADDRESS> is-at 92:22:a1:de:d5:eb (oui Unknown), length 28
^C
2 packets captured
2 packets received by filter
0 packets dropped by kernel

My suspicion is that the reply is being filtered/dropped somewhere because of the "unknown" mac address of the tap device. The arp cache of the host has the macaddr of the tap associated  with the correct local interface, so the problem must be happening at a deeper level.  Unfortunately, this is about where my knowledge of macvlan routing policies ends :)
root@host: $ arp -an
? (<IP_ADDRESS>) at 62:56:ba:21:f7:9a [ether] on eth0.1098.br  // <-- container tap0
? (<IP_ADDRESS>) at 52:54:00:e7:96:6e [ether] on eth0
? (<IP_ADDRESS>) at 02:42:0a:0a:ff:21 [ether] on eth0.1098.br // <-- container eth0
? (<IP_ADDRESS>) at <incomplete> on eth0

Thanks for reading!

See here:
https://superuser.com/questions/1205346/macvtap-interface-created-on-top-of-macvlan-interface-of-a-docker-container-cann


CPT Archive Support for FoundationPress Breadcrumb

On Custom Post Type Archives the breadcrumb currently shows only the "home page".
This additional code will add the custom post type name as current menu item.

Ha this is great, I was literally trying to do the same thing


Enforce usage of --useUnknownInCatchVariables

https://devblogs.microsoft.com/typescript/announcing-typescript-4-4-beta/#use-unknown-catch-variables

Done

Hi @danielnixon,
Since I updated the package, I have eslint error like:   1:1  error  TypeScript's useUnknownInCatchVariables mode is required  total-functions/require-strict-mode
However, I don't know how to enable it correctly, my project is already in strict mode.

Enforcing --useUnknownInCatchVariables seems unnecessary and confusing, because eslint-plugin-total-functions already enforces "--strict" which already sets  --useUnknownInCatchVariables to true
https://www.typescriptlang.org/tsconfig#useUnknownInCatchVariables

Good point @stenzengel. For some reason I believed it was like noUncheckedIndexedAccess (i.e. separate from strict). Hold tight for a fix.

Fixed in v4.10.1

It works. Thanks!


Nuisance: auto-widen the columns after importing

This is just a nuisance issue.  I will take a look at it in a couple weeks if no one else does.

That should be easy enough.
On Wed, Apr 29, 2015 at 5:13 AM, Ryan Adams<EMAIL_ADDRESS>wrote:

This is just a nuisance issue. I will take a look at it in a couple weeks
if no one else does.
—
Reply to this email directly or view it on GitHub
https://github.com/aaOpenSource/Galaxy-CSV-Processor/issues/4.

Issue closed by commit 235a413302435c94d17bf737f9528ac02f9613da

Issue closed by commit 235a413302435c94d17bf737f9528ac02f9613da


optimize_memory maximum interval

Every bot should call optimize_memory sometimes to avoid memory "leaks".
Add a parameter to force optimize_memory on all bots that didn't call it in the last X hours.
This parameter should be configurable, but it shouldn't be less than 20 minutes or more than 2 days.
Bots cleaned in this way can return answers with missing data or can lose some updates, but this is not a problem, since every bot can call it for themselves every X hours to avoid this kind of problems.

The interval shouldn't be disabled by the users, because disabling optimize_memory leads inevitably to out of memory.

The interval shouldn't be disabled by the users, because disabling optimize_memory leads inevitably to out of memory.

Regarding the memory usage, how do the official servers handle that?
Or do they just have 2TB Ram and run until they crash?

Regarding the memory usage, how do the official servers handle that?
Or do they just have 2TB Ram and run until they crash?

levlam says that tdlib doesn't consume as much ram, they are fine with that, they say they have never had memory problems, probably because they have thousands of bots that have less than 1 message/s

levlam says that tdlib doesn't consume as much ram, they are fine with that, they say they have never had memory problems, probably because they have thousands of bots that have less than 1 message/s

levlam: "This isn't a critical amount of data compared to another data stored in memory."

levlam: "This isn't a critical amount of data compared to another data stored in memory."

Regarding the memory usage, how do the official servers handle that?
Or do they just have 2TB Ram and run until they crash?

They restart an instance when it consumes too much memory.
They do this because the vast majority of instances is composed of semi-dead bots.

Regarding the memory usage, how do the official servers handle that?
Or do they just have 2TB Ram and run until they crash?

They restart an instance when it consumes too much memory.
They do this because the vast majority of instances is composed of semi-dead bots.

Is that something we should to have as a cleanup mode as well? Like kill bots which were not used in X hours?
Should I open up an issue for that?

Is that something we should to have as a cleanup mode as well? Like kill bots which were not used in X hours?
Should I open up an issue for that?

It isn't useful because if you kill a bot it will not free memory.
If you want to do that we should open an issue in tdlight-team/tdlight about releasing memory of closed sessions.

It isn't useful because if you kill a bot it will not free memory.
If you want to do that we should open an issue in tdlight-team/tdlight about releasing memory of closed sessions.

I was under the assumption that is what the close command is doing

close
Use this method to close the bot instance before moving it from one local server to another. You need to delete the webhook before calling this method to ensure that the bot isn't launched again after server restart. The method will return error 429 in the first 10 minutes after the bot is launched. Returns True on success. Requires no parameters.
https://core.telegram.org/bots/api#close

I was under the assumption that is what the close command is doing

close
Use this method to close the bot instance before moving it from one local server to another. You need to delete the webhook before calling this method to ensure that the bot isn't launched again after server restart. The method will return error 429 in the first 10 minutes after the bot is launched. Returns True on success. Requires no parameters.
https://core.telegram.org/bots/api#close

Close doesn't free the resources unfortunately. You can try it by yourself.

Close doesn't free the resources unfortunately. You can try it by yourself.


fix: Padding in language section

What

Small padding in country/language selection in settings issue #2683

Screenshot

Fixes bug(s)

Part of

#2683

Codecov Report

Merging #2690 (49a7623) into develop (2ea0da3) will decrease coverage by 1.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2690      +/-   ##
==========================================
- Coverage     8.86%   7.25%   -1.61%
==========================================
  Files          161     219      +58
  Lines         6623   10532    +3909
==========================================
+ Hits           587     764     +177
- Misses        6036    9768    +3732

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
8.73% <0.00%> (-23.57%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
60.00% <0.00%> (-22.98%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
15.11% <0.00%> (-19.10%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
21.68% <0.00%> (-9.75%)
:arrow_down:

packages/smooth_app/lib/main.dart
14.65% <0.00%> (-3.24%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

...ackages/smooth_app/lib/pages/scan/scan_header.dart
3.33% <0.00%> (-1.43%)
:arrow_down:

... and 236 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


[FEATURE] Add command to explain the different commit types

Is your feature request related to a problem? Please describe.
Sometimes I can get confused which commit type is suitable for my changes.
Describe the solution you'd like
A command to describe the built in commit types.
$ coco explain
  - ci: for when ...
  - docs: for when ...
  - feat: for when ...
  - fix: for when ...
  - ...

A much more extensive feature would be for coco to guess what type should be used based on the changed files. For example, if a Cargo.toml, gulpfile.js, package.json, makefile is the only file changed and the user types coco feat "...", perhaps it chould show a warning:
$ coco feat "add build script"
[warning] you seem to be changing a build file, would you like to use `build` type instead of `feat` (Y/N): Y
Updating commit type to `build`.
Created commit:
  build: add build script

But this feature could be implemented separately in the future if desired.
Describe alternatives you've considered
Manually open the angularjs docs when I forget the commit types and what each is for.
Additional context
N/A

A command to describe the built in commit types.

That would be great and cheap to implement.

A much more extensive feature would be for coco to guess what type should be used based on the changed files. For example, if a Cargo.toml, gulpfile.js, package.json, makefile is the only file changed and the user types coco feat "...", perhaps it chould show a warning:

This is interesting and look similar to what I had in mind for scope suggestion. However this would require to maintain a default configuration for a lot of languages/package managers. Making such feature exhaustive and accurate would require a tremendous amount of work.
Ideally this should be extendable and not resides in cog.toml but in a global cog config file.
It would provides the default (i.e. widely used language and their package managers (probably the top 20 languages in this year stackoverflow survey).

Hi, I started working on this (only the explain part).
Should the explain command also handle the keywords from the angular commit convention ? I think this would be more helpful than only feat/fix from the conventional commit spec.

I personally always use the conventional commit convention, and I'm sure a lot of others do too.

I personally always use the conventional commit convention, and I'm sure a lot of others do too.

is this a lapsus for "angular commit convention" :smile:  ?

Haha yeah I mean angular conventional commit*


[$500] Chat - PDF is not displayed in chat after uploading

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Pre-requisite: the user must be logged in.

Go to any chat.
Tap on the "+" button.
Tap on "Add attachment".
Tap on "Choose document".
Select any PDF.
Tap on "Send".
Wait for it to upload.

Expected Result:
PDF preview should be displayed in chat after the uploading.
Actual Result:
PDF preview is not displayed in chat after the uploading.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/96d73311-480c-46aa-b1fe-64977f66b2d6
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a3278ab046cf0de8
Upwork Job ID:<PHONE_NUMBER>479259648
Last Price Increase: 2023-12-26

Issue is not reproduced on production
https://github.com/Expensify/App/assets/93399543/f4e9fb8b-aa1b-4dba-9049-44c5a1baa806

I think this might be related to the expo image pr https://github.com/Expensify/App/pull/30905 and seems like a true blocker as PDF files cannot be used/ sent in native devices cc @WojtekBoman

The PDF previews are missing even after coming back to the chat so definitely a blocker imho

holy monkeys that's a big diff 😅
Would be great if @WojtekBoman could help investigate this 🙏  I'll try to test locally soon, assuming my sims start up nicely

Hmm @mkhutornyi I like your idea, but i think we need to know why this is now necessary - a.k.a. what's different in prod now & how did things change?

I am afraid the SWM developers will be ooo mostly so we should not wait for them. @mkhutornyi could you pinpoint whats the rootcause of this being different in staging than in production? thanks!

It seems like you are facing an issue where the default size (200, 200) is briefly shown before getting the correct size when using the updateImageSize function. I think the solution is to set an initial state for thumbnailWidth and tumbnailHeight before calculating and updating them. In this way, the
component rendering will have the correct initial values before the asynchronous calculation completes.
Here is my answer.
const updateImageSize = useCallback(
  async ({ width, height }: UpdateImageSizeParams) => {
    // Set initial values to the default size
    let thumbnailWidth = 200;
    let thumbnailHeight = 200;

    // Calculate the thumbnail size asynchronously
    const { thumbnailWidth: calculatedWidth, thumbnailHeight: calculatedHeight } = await calculateThumbnailImageSize(
      width,
      height,
      windowHeight
    );

    // Update the state with the correct size
    thumbnailWidth = calculatedWidth;
    thumbnailHeight = calculatedHeight;

    setCurrentImageWidth(thumbnailWidth);
    setCurrentImageHeight(thumbnailHeight);
  },
  [windowHeight],
);

In this code, by setting the initial values before the asynchronous calculation, you ensure that the default size is set before the component renders. The await keyword is used to wait for the asynchronous calculation to complete before updating the state with the correct size.
(I have assume that calculate ThumbnailmageSize returns a Promise or is an asynchronous function. If it is a synchronous function, you can remove the async keyword and the await statement.)
if my answer makes any problem or make sense to you plz ping me.

It seems like you are facing an issue where the default size (200, 200) is briefly shown before getting the correct size when using the updateImageSize function. I think the solution is to set an initial state for thumbnailWidth and tumbnailHeight before calculating and updating them. In this way, the
component rendering will have the correct initial values before the asynchronous calculation completes.
Here is my answer.
const updateImageSize = useCallback(
  async ({ width, height }: UpdateImageSizeParams) => {
    // Set initial values to the default size
    let thumbnailWidth = 200;
    let thumbnailHeight = 200;

    // Calculate the thumbnail size asynchronously
    const { thumbnailWidth: calculatedWidth, thumbnailHeight: calculatedHeight } = await calculateThumbnailImageSize(
      width,
      height,
      windowHeight
    );

    // Update the state with the correct size
    thumbnailWidth = calculatedWidth;
    thumbnailHeight = calculatedHeight;

    setCurrentImageWidth(thumbnailWidth);
    setCurrentImageHeight(thumbnailHeight);
  },
  [windowHeight],
);

In this code, by setting the initial values before the asynchronous calculation, you ensure that the default size is set before the component renders. The await keyword is used to wait for the asynchronous calculation to complete before updating the state with the correct size.
(I have assume that calculate ThumbnailmageSize returns a Promise or is an asynchronous function. If it is a synchronous function, you can remove the async keyword and the await statement.)
if my answer makes any problem or make sense to you plz ping me.

With RNFastImage we had this issue only on Android which was fixed with a patch.
With Expo Image it is on iOS as well.
I think properly addressing the falsy values here https://github.com/Expensify/App/blob/6365aebb9cdb3dd4a66e77117afd0fb1b1fa8957/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.js#L48-L49
like @mkhutornyi suggested is a good approach.

@mkhutornyi can you raise the pr? I think that showing briefly wrong size is fine for now to unblock deploy

@mkhutornyi yep this is great, we can polish this later with SWM once they are back from holidays!

Fixed in staging

Payment summary:

[x] $500 to @mkhutornyi paid via upwork for PR
[ ] $500 to @parasharrajat via newdot (please send a manual request, CC @JmillsExpensify )

$500 approved for @parasharrajat


Badges should have names other than "compatibility lib"

How about:
"Self Compatibility" => "internal compatibility"
"Google Compatibility" => "cross compatibility"
"Dependency Version Status" => "up-to-date dependencies"

The compatibility_lib on the badge is actually the package name being checked (our package name is compatibility_lib). But changing the package name displayed on badge to the check type sounds good!


receiveListener doesn't have a handler for a bad value

Add else (formerly would have been case _) and determine some other course of action, maybe:
+        else:
+            logging.warning("Invalid control frame format 0x{:08X}"
+                            "".format(self.decodeControlFrameFormat(frame)))

@bobjacobsen I can fix this in my python-3.8-backport branch and upcoming pull request. Can you advise as to whether this code above is a good course of action? I'm not sure if the formatting used above is ok.

Thanks!
I read the Standard as saying that "All others" are "... shall be ignored upon receipt".  So logging and ignoring sounds like the right approach.  Thanks for fixing this.


Need to merge master into test branch

Changed encrypted bytes threshold to a record limit

Removed int from for loop iteration variable

Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Resolved issues:
resolves #ISSUE-NUMBER1, resolves #ISSUE-NUMBER2, etc.
Description of changes:
Describe s2n’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Address any potentially confusing code. Is there code added that needs to be cleaned up later? Is there code that is missing because it’s still in development?
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1994 into test will increase coverage by 2.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             test    #1994      +/-   ##
==========================================
+ Coverage   86.85%   89.19%   +2.34%
==========================================
  Files         149      149
  Lines       11522    11534      +12
==========================================
+ Hits        10007    10288     +281
+ Misses       1515     1246     -269


TypeError in sandbox tests

About a week ago, tests started failing like so with errors in hide_setuptools when module names are 'None'.

I'm able to replicate the failures locally, but not against v28.8.0, so it appears to be a regression with some commit preceding the release of v28.9.0. The failure doesn't occur if I run tests with -k test_sandbox, so the failures seem to have some interaction with other tests.

Well, I was able to replicate it locally, but now I'm not, even against master, and even when I run the whole test suite. I'm not sure what's going on.

Running the test now, I'm getting the failure again. I think perhaps I hadn't properly gotten back to master.
I can replicate the test failure running only the tests from two files:
python -m tox -- -k 'test_sandbox or test_namespaces'

When it fails, there's a pseudo module in sys.modules[None]:
(Pdb) l
225  	    invocation to import the most appropriate setuptools. This technique is
226  	    necessary to avoid issues such as #315 where setuptools upgrading itself
227  	    would fail to find a function declared in the metadata.
228  	    """
229  	    modules = filter(_needs_hiding, sys.modules)
230  ->	    _clear_modules(modules)
231
232
233  	def run_setup(setup_script, args):
234  	    """Run a distutils setup script, sandboxed in its directory"""
235  	    setup_dir = os.path.abspath(os.path.dirname(setup_script))
(Pdb) sys.modules[None]
<module '_pycodecompile_pseudo_module' (1)>

It appears to me that code is being injected by pytest here. It seems that code has been around a long time, so it's only now that it's been triggered, presumably by something in the new test_namespaces.py.

If I remove the pytest skip, the issue doesn't occur.
$ git diff
diff --git a/setuptools/tests/test_namespaces.py b/setuptools/tests/test_namespaces.py
index 21fd69e..c148577 100644
--- a/setuptools/tests/test_namespaces.py
+++ b/setuptools/tests/test_namespaces.py
@@ -13,8 +13,6 @@ class TestNamespaces:

     @pytest.mark.xfail(sys.version_info < (3, 3),
         reason="Requires PEP 420")
-    @pytest.mark.skipif('os.environ.get("APPVEYOR")',
-        reason="https://github.com/pypa/setuptools/issues/851")
     def test_mixed_site_and_non_site(self, tmpdir):
         """
         Installing two packages sharing the same namespace, one installed
$

That explains why the tests started failing recently -- that behavior was added in e8d53c0b83.

Bypassing the string-style expression in the skip condition bypasses the issue, now reported upstream.


Add bits required for CoCo support

This should used on top of #351 & #348

@snir911 do you want to also update the instructions with KBS details or we do it as a next PR ?

Pointed to your repo, does it make sense?


Use templating to insert the course name, student name, and title of the generated templates

With a template resolution step it would be possible to generate files that e.g. don't necessarily include your name. An option could be Jinja templates, but there are many options available.

I should add that this is a suggestion, and not a forceful demand :)

My major question would be whether that would not be confusing for any new LaTeX users on the first years of the Bachelor's degree? Yet, one could have these templates created from such a script and then provide the generic template files as they are?

As a clarification, one maybe should make such a template in a seoncdary file. :)


Readme: Do I need to run commands as user or root?

Hey,
I'm unfamiliar with gem and docker, so it would be nice to add $ or # (or sudo) in front of all commands, so everyone knows if they need to be run as normal user or as root.

Run them as normal user.
Could you make a PR with this improvement?

Also the gem command?

Fixed in #602 - thanks!


Add hot meal routes

The route for getting the closest 3 hot meals is ready. documentation is coming in the next pull request

Changes Unknown when pulling 830e0e4291a55a349b48132b3a4baf8f28145b82 on add-hot-meal-routes into ** on master**.

Changes Unknown when pulling 3eb913509b631988a28237e3fb467e33f5af623d on add-hot-meal-routes into ** on master**.

Changes Unknown when pulling d0b7c1e41ca911d56f1c264b707cea4c569d2cb3 on add-hot-meal-routes into ** on master**.

Changes Unknown when pulling 757df5e3e6e32a89026f87e6aacbca5b8ef39e8d on add-hot-meal-routes into ** on master**.

Changes Unknown when pulling 63e79d08705f68faa82e607add38e2e620fe448e on add-hot-meal-routes into ** on master**.


PRIORITY - Fruitless neurons

Some additional classes, some updates to existing classes
fixes #127

Please resolve conflicts and merge.


Please be aware that your account is STOLEN or ABUSED by the very platform!

Hi guys, since we're the users of the very platform.
 Please check the two strange repo that "you" starred:

I think GitStar.com.cn is stealing Personal Access Token from us!

I think GitStar.com.cn is stealing Personal Access Token from us!

I have logged in on other devices.
I have fixed the problem.

I have logged in on other devices.
I have fixed the problem.


Rename Warning button to Negative

I could handle this! Is every "warning" component going to be renamed, or only the button one?

@rafaeelaudibert This is specific to the Button. That said, we're not ready to jump on issues with the breaking change tag just yet.

I will update with #813

This is done! 🎉


Using with ... yield twice

The following prints almost two pages of weird characters on my screen. Also, the output changes from run to run. The code is insane, I no longer remember what I was trying to accomplish with it and it should not actually compile.
def insane_method(value)
  with value yield
  with self yield
end

puts insane_method(:abc) { itself }

I am using Crystal 0.23.1 [e2a1389] (2017-07-13) LLVM 3.8.1 on ubuntu 16.04 LTS.
My guess is that the problem here has to do with how only one of the two receivers responds to itself, but somehow the compiler does not catch that.
Moreover, trying to build with --release results in a failure during the codegen phase with the following error:
crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102: 433222 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

This is a bug in LLVM 3.8. Updating to LLVM 3.9 fixes this.
See https://github.com/crystal-lang/crystal/issues/4719

No, it's a bug in the compiler

There's no self there
Even if it's in a class it breaks. with ... yield can't receive two different types (or maybe yes, but it should be the union, I don't know)

I now tried with the crystal version at https://github.com/crystal-lang/crystal/releases/download/0.24.0/crystal-0.24.0-2-linux-x86_64.tar.gz, which reports itself as
Crystal 0.23.0+313 [ea4187c57] (2017-10-27)

LLVM: 3.9.1
Default target: x86_64-unknown-linux-gnu

This time I get the following error when running it:
Invalid memory access (signal 11) at address 0x4
[0x44b335] *CallStack::print_backtrace:Int32 +117
[0x4402f6] __crystal_sigfault_handler +70
[0x7f5869e1b390] ???
[0x44d075] *String#to_slice:Slice(UInt8) +21
[0x44dce8] *String#to_s<IO::FileDescriptor>:Nil +24
[0x45b6a1] *IO::FileDescriptor +17
[0x485ddd] *Symbol#to_s<IO::FileDescriptor>:IO::FileDescriptor +45
[0x45c7b5] *IO::FileDescriptor +21
[0x45c77e] *IO::FileDescriptor +14
[0x440335] *puts<Symbol>:Nil +37
[0x4337ee] __crystal_main +1598
[0x4404b6] *_crystal_main<Int32, Pointer(Pointer(UInt8))>:Nil +6
[0x486306] *Crystal::main_user_code<Int32, Pointer(Pointer(UInt8))>:Nil +6
[0x4861d2] *Crystal::main<Int32, Pointer(Pointer(UInt8))>:Int32 +50
[0x43e6f6] main +6
[0x7f586943e830] __libc_start_main +240
[0x4330d9] _start +41
[0x0] ???

Compilation with --release still fails with:
crystal: /var/cache/omnibus/src/llvm/llvm-3.9.1.src/lib/CodeGen/LexicalScopes.cpp:159: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFun
ction())' failed.
/m/home/home8/82/jbomanso/data/Downloads/crystal-0.24.0-2/bin/crystal: line 102: 437332 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

I agree with "with ... yield can't receive two different types" and I implement such a feature at this branch as an experiment.

Also happens with this:
def foo
  with 1 yield
  with 1.5 yield
end

foo do
  p abs
end

So it has nothing to do with self.
That's a bit more difficult to fix.

These days we get a validation error for this:
Module validation failed: Call parameter type does not match function signature!

Checked in
$ crystal --version
Crystal 0.31.1 (2019-10-02)

LLVM: 8.0.1
Default target: x86_64-apple-macosx

Original example seem to be fixed now
$ crystal test.cr
Showing last frame. Use --error-trace for full trace.

In test.cr:3:8

 3 | with self yield
          ^---
Error: there's no self in this scope

Ary's example still fails with
Module validation failed: Call parameter type does not match function signature!


Release Google.Analytics.Admin.V1Beta version 1.0.0-beta05

Changes in this release:
No API surface changes; just dependency updates.

Created release for Google.Analytics.Admin.V1Beta-1.0.0-beta05


Working skipping

"Skip" button "scrolls forward" statement to next unseen or menu statemnet

Now It works, but need to be tested after new save/load system

Now its working:


Add pre-built frames/apps to python package with graphs that has string oid.

Is your feature request related to a problem? Please describe.
I think (have been asked by some users) that string as the oid_type is fairly common is real-world cases, including more prebuilt .so into our python library wouldn't cause too much memory usage (about 100~200 KB for an app, if I remember it correctly), and the compilation failure is common in user's enviroment (mainly caused by lower version of GCC, on old CentOS distribtion).
We already included many .sos in Python package, and each of them should have a string oid one as well.
Additional context
Add any other context or screenshots about the feature request here.

BTW I'm wondering if we have chance to make it work with GCC 5.4 or GCC 4.8? I think it is quite common setting in user's enviroment.
I'm thinking we will drop the dependency of folly on the next release, and there should be no blocking issues.

(FYI)

@siyuan0322 suggests that we could distribute a package like graphscope-apps that could be updated quickly and not constrained by the release cycle to move faster to match the requirements of users.
When users cannot upgrade GCC, and lack the inclusion of certain prebuilt app, they need to wait for the next release cycle, for a month.
Yes, requiring latest GCC is the simplest way for us, but is the hardest thing for users. Upgrade GCC is not trivial, on a shared enviroment of old Linux, especially on a centos/rh based Linux.


EventHandler

Sorry for being a novice, but how do I code an eventhandler to pick up when a device has been removed?
I can't see any examples anywhere.

You can do this by using https://github.com/Bassman2/UsbMonitor.


Inconsistency between ktlint and diktat in logging level when run from command line

The following applies to running ktlint+diktat in comand line:
ktlint executalbe jar bundles logback, but doesn't have any config file. Ktlint sets logging level programmatically, but only for a particular logger, that is used in KtLintCommandLine.kt. If neither of --debug, --trace, --verbose flags is present, it sets logback's level to INFO.
However, diktat uses multiple Slf4j loggers. Since no custom config for logback is present, the BasicConfigurator is used and logging level is set to DEBUG. This leads to several debug messages always showing up, see https://github.com/saveourtool/save-cli/issues/401#issuecomment-1161843347.
We should include a logback.xml into diktat-ruleset for setting default level to INFO, or try to find a way to share logging level with ktlint.

fixed by KotlinLogging.loggerWithKtlintConfig
also we have own cli now


Release cobigen-core-v7.0.0

Automatically processed.
The decisions taken by the developer and the context of the decisions throughout the script:

User confirmed that tests are running on CI and the build is not failing.
User has accepted to continue when found that some files were outside of build folder name


Enable enqueuing updates for expired items when serving stale

Currently, the logic behaves like the following when the ServeStale is true.
|______________________ ____threshold window__________ ______________ ____threshold window x2________ ______expiry & no threshold__________|
0 min                   9 mins                         10 mins        11 mins
Add key here           Update                          Update         Update                          No Update

I adapted it to also enqueue an update in the expired after the second "threshold window".
Please let me know if the previous behavior was on purpose or if it was a bug. If it was not purpose, I will also create a test case.

hey @simonbos thank you for that, it indeed looks like a miss, good catch. My tests weren't testing this scenario as well, it only checked if servestale worked, that too without an updater.

Thanks! I confirmed that TestThresholdUpdaterStale/long after threshold (cache expired) failed on the main branch.


Adds releasing block to bh.cr

Change-type: minor
Signed-off-by: Alex Bucknall<EMAIL_ADDRESS>

@balena-ci I self-certify!


Add workflows for Azure Key Vault examples

This issue is stale because it has been open 170 days with no activity. Remove stale label or comment or this will be closed in 10 days


Add max concurrency limit option

Summary
This command decorator should allow for the command to only have x running instances per the specified bucket, and raise an error if this limit was exceeded.
Why is this needed?
This feature would be extremely nice for commands that should not run more than one at a time (for example a typeracing command, where only a maximum of one instance of the command should be running in a channel at any given time), or commands that rely on their state not being altered by a different instance of themselves.
Ideal implementation
Example syntax:
@bot.command()
# A maximum of one instance per channel
@lightbulb.max_concurrency(1, lightbulb.ChannelBucket)
@lightbulb.command("thommo", "based")
@lightbulb.implements(...)
async def foo(ctx: lightbulb.Context) -> None:
    await asyncio.sleep(10.0) # Long operation
    await ctx.respond("foo")

Trying to execute a command that exceeded it's max concurrency should raise an error (for example: lightbulb.MaxConcurrencyReachedError) with information about the max uses & bucket-type used included in the exception.
Checklist

[X] I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.

I feel like using this as a constructor in the command decorator would be better and easier to use
@lightbulb.command("", "", max_concurrency=lightbulb.ChannelBucket(1))


Support of vgo

Package named internal can't be currently imported using vgo (issue golang/go#23970). This situation at least prevents importing module github.com/cznic/lldb (and transitively github.com/cznic/ql) and also intra-dependency import of "github.com/cznic/internal/slice" in buffer/buffer.go.
Please consider "renaming" this repo (with respect to backward compatibility) or make this package "stable" by integrating it into LLDB (#3).
$ mkdir example && cd example
$ echo "module example" > go.mod
$ echo -e "package main\n\nimport _ \"github.com/cznic/ql\"\n\nfunc main () {}" > main.go
$ vgo build
... some successful imports ...
..\..\..\v\github.com\cznic\lldb@v1.1.0\btree.go:16:2: use of internal package not allowed
..\..\..\v\github.com\cznic\lldb@v1.1.0\memfiler.go:13:2: use of internal package not allowed
..\..\..\v\github.com\cznic\internal@v0.0.0-20170905175358-4747030f7cf2\buffer\buffer.go:36:2: use of internal package not allowed

Would also need this for usql.

Please consider "renaming" this repo (with respect to backward compatibility) or make this package "stable" by integrating it into LLDB (#3).

Before eventually doing that I'd like to wait for feedback on https://github.com/golang/go/issues/25164#issuecomment-392083411. Also related: cznic/ql#199.

@cznic a definitive decision on whether or not you're renaming this repository would be appreciated!
May I suggest merging/renaming your various Git repositories? While vgo will likely fix this dependency issue, I find that it's best to get ahead of supporting standards. Since it's the intention of Go's core developers to make vgo the standard, I might suggest that renaming your repository would be prudent!

I would suggest renaming internal to common or something else. As your repositories are the only one using these, I don't believe it'll be an issue -- anytime someone does a go get -u, the latest paths would be updated from your dependent repositories. Anything that currently using these repositories will update/build still, as they already have copies on disk. Additionally, if you simply rename internal => common, I believe go get -u for projects with the old names will still work, as I believe GitHub serves the correct path in the ?go-get=1 response. I'll look further into it. Anyway, appreciate your response!

It's worth noting that according to https://godoc.org/github.com/cznic/internal/buffer?importers there doesn't appear to be any other projects (other than your own) using the internal/{file,buffer,slice} packages.

I just checked manually what happens with a renamed/moved project on GitHub with go get:

a 301 redirect occurs
go get sends a ?go-get=1 to the redirected location from 1
git clone is performed for the URL read from the metadata retrieved in 2

As such, a "lateral" move such that the final package name doesn't change, shouldn't affect any existing clones / code on disk.
Anyways, appreciate the consideration! Hope we can get this fixed. Thanks again!

OK, please check my line of thoughts.
Consider a fork of, for example. ql, owned by , say onwer foo at github.com/foo/ql. Today the owner of that repo can do go get -u in any repository that imports the ql fork and everything works just fine. If we rename github.com/cznic/internal to github.com/cznic/rename the forked ql build fails so as everything importing that fork.
Except there's the Github redirect feature and even when the foo's fork imports the old, now non-existing github.com/cznic/internal package, go get will handle the redirect and clones/pulls from the github.com/cznic/common repository instead.
The crucial question is: Where does go get clone/update the redirected package? If still in the original location, ie. $GOPATH/src/github.com/cznic/internal then I agree that it is safe to do the rename. It has even the added advantage that no import paths anywhere have to be updated.
Can you confirm the location on the user disk stays fork-compatible?
And thanks a lot, TIL about Github's redirect feature.

My suggestions with respect to backward compatibility:

Do you want to be package github.com/cznic/internal reused?

If yes, make copy/fork of github.com/cznic/internal to github.com/cznic/common and rename the package.
If no, copy a content of github.com/cznic/internal to github.com/cznic/ql/internal.

Refactor github.com/cznic/ql to use new package name/path and add go.mod file.
From this new version, vgo is supported for github.com/cznic/ql and backward compatibility is maintained.

@xmikus01 That was my original plan b/c I didn't know about the Github's redirect feature. Now that @kenshaw brought it to my attention, it seems to be also a non-breaking approach and even simpler. Do you think there's a catch I'm missing? Would love to know about it.

@cznic I don't believe there would be any problems. Just use the GitHub rename in the settings page.
If you rename this repository to common on GitHub, if you later do go get -u github.com/cznic/internal the code will be store on disk at $GOPATH/src/github.com/cznic/internal. Then in the  $GOPATH/src/github.com/cznic/common/.git/config file, the remote will be defined as:
[remote "origin"]
	url = https://github.com/cznic/common
	fetch = +refs/heads/*:refs/remotes/origin/*

@kenshaw Okay, I'll give it a try. If something goes wrong, it can be reverted. (The hard way: delete the renamed repository completely, create it again and restore its content.)

You can always just rename it back on GitHub.

It does not work, I'll revert in a few moments.
jnml@r550:~/tmp> ls -la
celkem 4
drwxr-xr-x  2 jnml users    6  8. čen 17.14 .
drwxr-xr-x 38 jnml users 4096  8. čen 15.59 ..
jnml@r550:~/tmp> export GOPATH=$(pwd)
jnml@r550:~/tmp> go get github.com/cznic/ql
jnml@r550:~/tmp> cd src/github.com/cznic/ql
/home/jnml/tmp/src/github.com/cznic/ql
jnml@r550:~/tmp/src/github.com/cznic/ql> vgo build
vgo: creating new go.mod: module github.com/cznic/ql
vgo: resolving import "github.com/cznic/b"
vgo: finding github.com/cznic/b (latest)
vgo: adding github.com/cznic/b v0.0.0-20180115125044-35e9bbe41f07
vgo: resolving import "github.com/cznic/golex/lex"
vgo: finding github.com/cznic/golex (latest)
vgo: adding github.com/cznic/golex v0.0.0-20170803123110-4ab7c5e190e4
vgo: resolving import "github.com/cznic/lldb"
vgo: finding github.com/cznic/lldb (latest)
vgo: adding github.com/cznic/lldb v1.1.0
vgo: resolving import "github.com/cznic/mathutil"
vgo: finding github.com/cznic/mathutil (latest)
vgo: adding github.com/cznic/mathutil v0.0.0-20180504122225-ca4c9f2c1369
vgo: resolving import "github.com/cznic/strutil"
vgo: finding github.com/cznic/strutil (latest)
vgo: adding github.com/cznic/strutil v0.0.0-20171016134553-529a34b1c186
vgo: finding github.com/cznic/strutil v0.0.0-20171016134553-529a34b1c186
vgo: finding github.com/cznic/mathutil v0.0.0-20180504122225-ca4c9f2c1369
vgo: finding github.com/cznic/lldb v1.1.0
vgo: finding github.com/cznic/golex v0.0.0-20170803123110-4ab7c5e190e4
vgo: finding github.com/cznic/b v0.0.0-20180115125044-35e9bbe41f07
vgo: downloading github.com/cznic/b v0.0.0-20180115125044-35e9bbe41f07
vgo: downloading github.com/cznic/golex v0.0.0-20170803123110-4ab7c5e190e4
vgo: downloading github.com/cznic/lldb v1.1.0
vgo: downloading github.com/cznic/mathutil v0.0.0-20180504122225-ca4c9f2c1369
vgo: downloading github.com/cznic/strutil v0.0.0-20171016134553-529a34b1c186
vgo: resolving import "github.com/cznic/fileutil"
vgo: finding github.com/cznic/fileutil (latest)
vgo: adding github.com/cznic/fileutil v0.0.0-20180108211300-6a051e75936f
vgo: resolving import "github.com/cznic/internal/buffer"
vgo: finding github.com/cznic/internal (latest)
vgo: adding github.com/cznic/internal v0.0.0-20180608151017-b638a8775a65
vgo: resolving import "github.com/cznic/sortutil"
vgo: finding github.com/cznic/sortutil (latest)
vgo: adding github.com/cznic/sortutil v0.0.0-20150617083342-4c7342852e65
vgo: resolving import "github.com/cznic/zappy"
vgo: finding github.com/cznic/zappy (latest)
vgo: adding github.com/cznic/zappy v0.0.0-20160723133515-2533cb5b45cc
vgo: finding github.com/cznic/zappy v0.0.0-20160723133515-2533cb5b45cc
vgo: finding github.com/cznic/sortutil v0.0.0-20150617083342-4c7342852e65
vgo: finding github.com/cznic/internal v0.0.0-20180608151017-b638a8775a65
vgo: finding github.com/cznic/fileutil v0.0.0-20180108211300-6a051e75936f
vgo: downloading github.com/cznic/fileutil v0.0.0-20180108211300-6a051e75936f
vgo: downloading github.com/cznic/internal v0.0.0-20180608151017-b638a8775a65
vgo: downloading github.com/cznic/sortutil v0.0.0-20150617083342-4c7342852e65
vgo: downloading github.com/cznic/zappy v0.0.0-20160723133515-2533cb5b45cc
vgo: resolving import "github.com/edsrzf/mmap-go"
vgo: finding github.com/edsrzf/mmap-go (latest)
vgo: adding github.com/edsrzf/mmap-go v0.0.0-20170320065105-0bce6a688712
vgo: finding github.com/edsrzf/mmap-go v0.0.0-20170320065105-0bce6a688712
vgo: downloading github.com/edsrzf/mmap-go v0.0.0-20170320065105-0bce6a688712
../../../v/github.com/cznic/lldb@v1.1.0/btree.go:16:2: use of internal package not allowed
../../../v/github.com/cznic/lldb@v1.1.0/memfiler.go:13:2: use of internal package not allowed
../../../v/github.com/cznic/internal@v0.0.0-20180608151017-b638a8775a65/buffer/buffer.go:36:2: use of internal package not allowed
jnml@r550:~/tmp/src/github.com/cznic/ql> cd ~/src/golang.org/x/vgo/
jnml@r550:~/src/golang.org/x/vgo> git log -1
jnml@r550:~/src/golang.org/x/vgo> git --no-pager log -1
commit 203abfb0741bf96c7c5e8dab019f6fe9c89bded3 (HEAD -> master, origin/master, origin/HEAD)
Author: Russ Cox<EMAIL_ADDRESS>Date:   Wed Jun 6 16:40:30 2018 -0400

    cmd/go/internal/vgo: fix handling of vendor dir in package patterns

    A directory x/vendor containing code is just a package called vendor.
    A directory x/vendor/y is vendored code.
    When a package pattern scans the current module's file tree
    it should include a package called vendor but should not
    include the directories containing vendored code.

    Maybe related to a comment on golang/go#25624.

    Change-Id: I083a98a9c70c2121cff7a2f394ff985a54bed37a
    Reviewed-on: https://go-review.googlesource.com/116759
    Run-TryBot: Russ Cox<EMAIL_ADDRESS>    TryBot-Result: Gobot Gobot<EMAIL_ADDRESS>    Reviewed-by: Bryan C. Mills<EMAIL_ADDRESS>jnml@r550:~/src/golang.org/x/vgo>

You'll need to rename the import paths in all the Go projects using this project. Considering your the owner of them all, it shouldn't be a problem I'd hope! I'd be glad to submit PRs for all the projects.

Reverted.
@kenshaw But then it means that foo's local fork (as discussed above) works no more. Thanks for the PR offer, but I now believe we should use something like the approach suggested by @xmikus01, which keeps foo's fork working.
To all: I'm quite busy so I didn't thought too much about all of the consequences. I'm not sure I understand all of them and I don't think I'm even aware of all of them. So my current inclination is quite possibly mistaken. Anyway, the safer approach is IMO better even when the other may have some advantage.
I'll have no more time today for experiments. Please comment here anything I should know about before tomorrow, when I hope to create the 'common` repository and change the imports. At least that's what I think/plan now ;-)

@cznic I do appreciate your attention to this, but any code that is a local fork will continue to work until they rebase as they'll already have the repositories on disk.
Please consider renaming it again. I'd be glad to offer assistance to anyone who does encounter issues.
Since vgo is now the accepted path forward, eventually this project (and all the other projects depending on it) will likely not be go get'able in the future. Keep that in mind when weighing your decision! Thanks!

This issue is now obsolete with closed golang/go#23970. Tested now on go master branch by installing github.com/cznic/ql. The vgo experiment will be replaced by go modules experiment in Go 1.11 which will be released in August 2018. Thereafter this repository can be used as is without any change.


Where is the CUDA path?

Thanks for your great work!
I am using the following docker image:
cnstark/pytorch:1.12.0-py3.9.12-cuda11.6.2-ubuntu20.04
I can not found the cuda path. /usr/local/cuda not exisits. As onnxruntime, TensorRT need the cuda well installed, could you provide more informations about this?

Hi!
This version does not contain CUDA files, it is built on the standard Ubuntu image.
Please use cnstark/pytorch:1.12.0-py3.9.12-cuda11.6.2-devel-ubuntu20.04 instead of the current image.

Right, Got it. Thanks very much!


Update turnitin settings instructions

Updates to clarify instructions and inform a 24 hour propagation time

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Activation literal based SMT checking

Implements activation literal based SMT checking. The big change is using a bool to create an implication instead of using push and pop. This allows the solver to reuse work it did to solve previous queries.
Currently using my easy-smt fork. Once https://github.com/elliottt/easy-smt/pull/21 is merged, we can switch to the original package.

Okay, the act lit nonsense didn't work at all so instead this PR attempts to discharge all the assertions in a component together. SMT solvers are optimized for giant queries anyways so this might work better.

Okay, finally this works! @UnsignedByte & @gabizon103 this adds an option to configure the solver we’re using and switches the default to cvc5. We can add a flag to runt to configure which silver is being locally. If you still can’t run this program locally, I’ve added a flag to skip SMT checks entirely.


BUG: all regions set to requested in ReconstructBiasField

Description of problem
See https://discourse.itk.org/t/n4biasfieldcorrectionimagefilter-getlogbiasfieldasimage-wrap-bsplinecontrolpointimagefilter-alternatives/5142/2
If (for some reason) the input requested region is different than the largest possible region, the code was

first reconstructing the bias field using the largest possible region
then setting all regions to inputImage->GetRequestedRegion(), which doesn't make sense

To reduce the change to a minimum I still set the requested region based on inputImage->GetRequestedRegion(), but  probably we could just remove the line completely.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

thanks @dzenanz for your fast response


doesn't work in my browser when specialProperty is Symbol

I have react@15 and chrome 59.0.3071.115.
With a little tweak in code, I was able to find out the possible cause.
Firstly I made specialProperty any string, including zeroWidthSpace, works fine.
Then I changed it back to Symbol, the function was not called.
then I attached a debugger to validator..
  propertyOne: PropTypes.string,
  propertyTwo: () => {
    debugger
    return null
  },

I was able to reach this frame

and the checkType function

It turns out that when doing the for... in, the symbol would not be found as a key.

I have no idea why tests would pass. My speculation would be...

the test environment doesn't support Symbol.
the test was run on native HTML element, instead of a React component, and React treated these two with different prop validation logic

I'm a bit confused - native HTML elements can't have propTypes, only custom components can.
However, if they're indeed using for..in, then it definitely won't work with symbols. In that case, I'm not sure why this test is passing in Symbol-supporting node versions. I'll add some tests and see if I can reproduce this problem.

Thanks, v1.1.1 incoming.


retire path argument from read_camtrap_dp()

Discussed with @damianooldoni and @peterdesmet , we will be retiring the path argument from read_camtrap_dp()

[x] remove path argument from read_camtrap_dp()
[x] remove path argument from read_camtrap_dp() documentation
[x] remove path argument test from test-read_camtrap_dp.R
[x] Check if the path argument is referenced in other functions

I think you can now close this issue as completed.


[Ignore] logging

https://github.com/aspnet/AspNetCore-Internal/issues/1896

Draft PR yo

Ajay used [Ignore] but it was totally ineffective

Comment

FINE

/azp run AspNetCore-Tooling-ci

/azp run AspNetCore-Tooling-ci

/azp run AspNetCore-Tooling-ci

/azp run AspNetCore-Tooling-ci

/azp run AspNetCore-Tooling-ci

This PR has served its purpose


Added SET_UP and TEAR_DOWN macros.

This is PR to add support for SET_UP and TEAR_DOWN macros requested in #815.
Probably needs more work and may need to be changed completely but just wanted to share my quick implementation of it.

Catch 1.X is meant to support old (some might say obsolete) compilers compiling C++98, so for things like nullptr, you should be using CATCH_NULL. Adding tests to the SelfTest project would also be appreciated.
The above isn't sufficient for merge, I'll leave that up to Phil, but at least compilation needs to be fixed.


How was the visualization results visualized?

Hi, I really wonder how the registration results were visualized? Especially for the deformed grid, many papers talked about registration but no one even mentioned how the results were visualized.

Hi @chengjiawang,
There are two ways to visualize the deformed grid:

Create a mesh grid. Then apply the displacement field to the mesh grid:

def plot_grid(gridx,gridy, **kwargs):
    for i in range(gridx.shape[1]):
        plt.plot(gridx[i,:], gridy[i,:], **kwargs)
    for i in range(gridx.shape[0]):
        plt.plot(gridx[:,i], gridy[:,i], **kwargs)

# Assume an image has size 384 x 384
x = np.arange(0, 384, 1)
y = np.arange(0, 384, 1)
X, Y = np.meshgrid(x, y)
u = displacement_field[0, 0, :, :] #batch, channel, size_x, size_y
v = displacement_field[0, 1, :, :] #batch, channel, size_x, size_y
for i in range(0, 384):
    for j in range(0, 384):
        # Apply displacements
        X[i, j] = X[i, j] - u[i, j]
        Y[i, j] = Y[i, j] - v[i, j]
plt.figure()
plot_grid(X, Y, color="C0")
plt.title('Deformed grid')
plt.show()

Create an image with a "synthetic" mesh grid. Then apply the displacement field to the image:

# Assume an image has size 160 x 192 x 224
def mk_grid_img(grid_step, line_thickness=1, grid_sz=(160, 192, 224)):
    grid_img = np.zeros(grid_sz)
    for j in range(0, grid_img.shape[1], grid_step):
        grid_img[:, j+line_thickness-1, :] = 1
    for i in range(0, grid_img.shape[2], grid_step):
        grid_img[:, :, i+line_thickness-1] = 1
    grid_img = grid_img[None, None, ...]
    grid_img = torch.from_numpy(grid_img).cuda()
    return grid_img

grid_img = mk_grid_img(8, 1, (160, 192, 224))
def_grid = spatial_transformation_function(grid_img.float(), displacement_field.cuda())
def_grid = def_grid.detach().cpu().numpy()[0, 0, :, :, :]

plt.figure()
plt.imshow(img[80, :, :], cmap='gray') # visualize an arbitrary slice
plt.title('Deformed grid')
plt.show()

We used method 2 in our papers, and I think the VoxelMorph paper used a similar method.
I hope this is helpful.
Junyu


[MAID-2835] chore/ci: update scripts to Rust stable 1.26.2

r? @Fraser999
(maidsafe_highfive has picked a reviewer for you, use r? to override)


GetPositionAsync issue when choosing "Only when using the App" rather then "Always Allow"

Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On: iPhone 6S - iOS 11.4
Simulator Tested On: iPhone 8 - iOS 11.4
Version of VS: VS for Mac 7.6.3
Version of Xamarin: <IP_ADDRESS>
Steps to reproduce the Behavior
Set up an app that requests background location updates
When app prompts for permissions, select "Only when using the App" rather than "Always Allow"
Expected Behavior
GetPositionAsync should still return the location as if we had chosen the "Always Allow" i.e. without hanging.
Actual Behavior
GetPositionAsync hangs for a few seconds (see traces below) and complains.
Eventually, it exits with the correct location and without exception.
2018-09-05 08:27:24.970 fipacapp.iOS[7747:5161304] Currently does not have Location permissions, requesting permissions
2018-09-05 08:27:24.987 fipacapp.iOS[7747:5161304] AuthorizedWhenInUse
...
2018-09-05 08:27:32.992 fipacapp.iOS[7747:5161304] Location permission denied, can not get positions async.

It works as expected though if we had chosen "Always Allow".
Worth mentioning, Geolocator version 4.2.0 (which also requires downgrading Permissions to 2.2.1) works as expected in both scenario.

Correct, this is how I had to implement it as Apple doesn't raise an event so I wait a while and return a result. Nothing I can do. Don't add the background permit if you don't need it.

Hi James,
Well I don't get your answer... there are a number of apps out there that request for the "Always"  permissions for which if we only allow "Only when Using" don't stop from working even on a subset of the possible functionalities.
Meaning, if the system allows for another answer than "Always", choosing it shouldn't break the app, only restrict the way it is allowed to work.
At least, the 4.2.0 version of your plugin does also trace the "Currently does not have Location permissions" and "AuthorizedWhenInUse" trace messages when calling GetPositionAsync but returns as soon as it gets a valid location which is better then the current behavior.
Because of that, I'm forced to stick with this 4.2.0 version rather than the newer one.

Perhaps I missunderstood what was going on in your original bug. It is hard without having sample code to fully understand what is being called.
It seems as though what when you called "GetPositionAsync" that it eventually returned and gave you back the position and future calls did not have the issue?
I have a longer thread on how I fixed it here: https://github.com/jamesmontemagno/PermissionsPlugin/issues/75

Yes it seems very related to that issue.
But not quite exactly the same, mine being probably a consequence of what you did try to fix #75
With the latest version of the Geolocator plugin, when answering "Only when using the App" rather than "Always Allow", GetPositionAsync always return the correct location but within the timeout you probably set waiting for the event that should fire if the user had chosen "Always", event which you say never fires in that specific case.
GetPositionAsync calls CheckPermissions, so if the latter isn't working properly, the former won't either.
I'll try to make some complementary tests with your sample to see if I can pinpoint the exact issue.

Just a suggestion reading the source... could GetPositionAsync only request for Permission.LocationWhenInUse rather then the full Permission.Location (I suppose that this is why it gets a denied...) at https://github.com/jamesmontemagno/GeolocatorPlugin/blob/master/src/Geolocator.Plugin/Apple/GeolocatorImplementation.apple.cs#L230 ?
Permission.LocationAlways is requested further down anyway and only if it is required (iOS > 9, background updates enabled): https://github.com/jamesmontemagno/GeolocatorPlugin/blob/master/src/Geolocator.Plugin/Apple/GeolocatorImplementation.apple.cs#L258

To further build onto this I had an issue where requesting Permission.Location on iOS just caused it to hang forever. Switching to Permission.LocationWhenInUse fixed it.

Hey James,
What do you think about my suggestion?
Have you had the time to think about it?
If valid, do you think you'll be able to release a new version of the package anytime soon?
Thanks

Can you make a PR

There you go. PR #278

Hi James,
I just tried with the new 4.5.1-beta version of Geolocator (which I assume has the fix) and with the I suppose related 4.0.0-beta version of Permissions... now requesting Location requires NSAppleMusicUsageDescription?!
Is it some kind of mix up?
I tried to downgrade only Permissions to <IP_ADDRESS> and no weird NSAppleMusicUsageDescription requirement, but behavior is the same as described at the top of this issue...

Where and how do you see this error message?

If you got this email from apple then their scanner must have changed and now are trying to force even if the API is in the app :( had this issue with contacts too, which is what 4.0 takes place. Looks like iOS 12 sdk may do something odd. I am pushing 4.0.1-beta of permissions for you to try out.

Just for you know, I was seeing this message on the device itself when requesting the Location permission.
Now 4.0.1-beta seems to have solved it.
And a full clean, restore package, remove bin & obj dirs and rebuild seemed to also let the fix in Geolocator 4.5.1-beta do its job.
All in all, everything seems now to work as it should.
Thanks

Yeah, most likely because i removed the enum from it so it was messed up. I updated and pushed out a new geolocator plugin built against t :)


Bug: QA Cert Event Code Dropdown

Issue:
The QA Cert Event Code dropdown does not include the actual QA Cert Event Code, only the Code description
Steps to Recreate:
Barry (3) 1, 2, CS0AAN

Select a configuration from the QA Cert Event Data & Test Extension Exemption Data screen
Add/ Edit a QA Cert Event

Private Zenhub Image

QA Cert Event Code Dropdown has been updated


x/tools/gopls: add support for 'refactor.extract.constant' code actions

See https://github.com/microsoft/vscode-go/issues/3040.
https://microsoft.github.io/language-server-protocol/specifications/specification-3-15/#textDocument_codeAction has more details on the possibilities here.
The function refactoring can be implemented by making use of guru's freevars code.

https://golang.org/cl/241957 and https://golang.org/cl/240182 support extracting a function and variable, respectively, as a code action. The following are open issues with function extraction:

[ ] Extraction does not include comments. Comments are replaced with newlines in the extracted function.
[ ] You cannot extract a selection that begins with or ends with a comment.
[ ] Control flow statements (break, continue, goto, etc.) are not handled specially. This can produce bad code if extracted poorly.
[ ] Defer statements are not handled specially. This can also produce bad code if extracted poorly.
[ ] Identifiers can be on the left-hand side of an assignment statement even if they are never used again. This produces a yellow line with the message "variable is never used." This occurs when a variable name is used later in scope, but the first time it is used after the selection, it is defined again (using :=) rather than assigned. This does not produce incorrect code, but should be fixed.

Ok, if you are seeing a refactoring there but it doesn't work with the hotkey, then this is probably a VS Code bug, not a bug in the extension. Please file an issue with https://github.com/microsoft/vscode.

Hi @stamblerre thanks for your reply. I tried to reinstall my vscode and restore to the initial state. Then set one customized shortcut like this in keybindings.json (refer to official doc):
// Place your key bindings in this file to override the defaults
[
    {
        "key": "alt+cmd+v",
        "command": "editor.action.codeAction",
        "args": {
          "kind": "refactor.extract.variable"
        }
    }
]

The issue still exists:
Using quick fix (cmd + . in mac os):

Using shortcut (alt+cmd+v defined above):

As a reference, for other languages,refactor.extract.constant shortcut is avaiable on TypeScript (doesn't support refactor.extract.variable), but both of two shortcuts aren't avaiable on Python and C#.
Seems even though vscode provides the ability for customizing shortcuts, this feature is not well supported by language extensions. Not sure if it is due to some bugs in vscode.

gopls sets the codeActionKind for Extract variable to be refactor.extract. So the keybinding would need to be
{
        "key": "alt+cmd+v",
        "command": "editor.action.codeAction",
        "args": {
          "kind": "refactor.extract"
        }
    }

We should definitely consider being more specific for the code action kinds to enable keybindings like this.

I've started attacking this issue at https://go.dev/cl/564338 and added tests/enabled the usage of refactor.extract.constant, refactor.extract.function, and refactor.extract.variable.
One possible issue is that I have not implemented a new type of code action for constants- the refactor.extract.constant still calls internal/golang/extract.go:extractVariable. The issue here is if someone calls refactor.extract.constant on a non-constant variable, the typical variable extraction will occur rather than an error stating that the target must be a constant.
I am not well-versed in the ast package that extractVariable uses to analyze the type of variable, but I imagine it would be possible to confirm that the target is a constant and then run the extraction. Does anyone have advice here? Thanks in advance.


 Many are unchecked errors or other bugs, some are just unnecessary and had no use so they get assigned to _.

Coverage decreased (-0.05%) to 34.619% when pulling 85c2592d2c18a4841934d9c3c9b7cdfbdc173be8 on TS_unused_assignments into 75027221fffdbed5bf457109d6526357f276e8ae on master.

Travis is succeeding, but Coveralls is marking the error logging/propogation as a decrease in code coverage however we were always missing coverage there, it just wasn't being counted before.


[Release-1.19] Restoration fails on etcd only nodes due to invalid state of loadbalancers

Environmental Info:
K3s Version: v1.19.x
Node(s) CPU architecture, OS, and Version:
Linux rke2-server 5.11.0-25-generic #27~20.04.1-Ubuntu SMP Tue Jul 13 17:41:23 UTC 2021 x86_64 GNU/Linux
Cluster Configuration:

1 etcd only node server
1 controlplane node servers

Describe the bug:
upon restoring on an existing etcd only node, it tries to setup internal load balancer with existing configuration, and tries to connect to old supervisor servers, which may or may not exist and fails to restore wiht the following error:
Waiting to retrieve agent configuration; server is not ready: Get \\\"https://<IP_ADDRESS>:6444/v1-rke2/serving-kubelet.crt\\\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)\""

Validated using release-1.19 branch commitid 11813ac822288ea7df784b1e516e52e3b7a8f2fb
Performed all the same steps as on the rke2 issues related to this and confirmed LB and etcd k3s/apiaddresses all get properly configured during each restore.


Use working set for reference

Currently a new RDD is created upon each reference to get the reference.
To solve this, we should support reference files in LazyMaterialization or keep a global RDD[NucleotideContigFragment] in VizReads

closed via #111


Use Collection.partition(by:) and remove Collection.split(_:)

Fix SR-6523

It seems MutableCollection.partition(by:) exists as mutating func. 🤔
https://developer.apple.com/documentation/swift/mutablecollection/2905358-partition

Thats great, can we use the stdlib method then?

Updated to use stdlib method.

Perfect, thanks!

@swift-ci please smoke test

Thanks! 🙏


connectivity-check: Reduce chances of port conflict with proxy

Cilium's DNS proxy listens on a port allocated by the kernel. That port can however conflict with the port used by echo-c-host-container from the connectivity checks, leading to CI flakes when run regularly.
A kernel comment on the function allocating the port gives us a way out:
* if snum is zero it means select any available local port.
* We try to allocate an odd port (and leave even ports for connect())

So using an even-numbered port for echo-c-host-container in the connectivity checks should strongly reduce the likelihood of this flake happening again. Other hostns pods already use even-numbered ports.
Fixes: https://github.com/cilium/cilium/issues/15459

test-me-please

k8s-1.16-kernel-netnext failed with known flake https://github.com/cilium/cilium/issues/15455. Team reviews are covered. Marking as ready to merge.


procodile.log disk usage

I just noticed that there's a procodile.log being written to /tmp/postal, and it appears that's it's never being purged or rotated.  And after growing for 3+ months, it's using up most of the disk space on our postal server.
What was the intent of this log, and how it would be managed over time?

It looks like it records how the processes work and any errors they encounter. Ours is only 76K so I guess it gets reset on server reboot or something.
Procodile is a separate repo here https://github.com/adamcooke/procodile so it might be worth asking this question there.
If you don't restart your server (namely for kernel updates) that may clear the log then I wonder if @adamcooke would be able to suggest an appropriate logrotate configuration for this.
I don't think the file is critical so if restarting the server is not possible or sufficient to empty the file, I'd suggest running postal stop, deleting the file, and then running postal start at a time convenient to you.

Thanks for the info.  By the way, I have restarted Postal several times over the past few months, and coincidentally the procodile process always seems to refuse being shutdown and I’ve had to resort to killing it.  Is that a known issue?

We've never experienced it. I just schedule late night shutdowns with the OS and Postal has no issues.
When you say the procodile process keeps running, do you mean its still there after a postal stop? Or does the postal stop never complete?

Back on your initial problem, it might be worth reviewing the contents of the log file yourself, it may be there are some issues in your setup.
Are you running the queue and MySQL server on the same server as Postal?

postal stop is not completing.  It reports that the it's stopped the worker processes, for example, but I can see in another shell that they're still running.  I usually have to resort to manually killing them.  It wasn't always like this.  postal stop used to function properly.  Here is the output I see (and it stays like this indefinitely until I intervene):
Stopped worker.1 (PID: 31084)
Stopped worker.2 (PID: 31086)
Stopped worker.3 (PID: 31088)
Stopped worker.4 (PID: 31091)
Stopped cron.1 (PID: 31096)
Stopped smtp.1 (PID: 31098)
Stopped requeuer.1 (PID: 31102)
Supervisor will be stopped when processes are stopped.
Waiting for supervisor to stop...```

And yes, everything is running on the same host.

So I had a look at the procodile.log and did notice a large number of warnings.  I seeing the same pattern repeated thousands of times:
ESC[33m15:42:25 smtp.1          | ESC[0mESC[33m=> ESC[0m        for<EMAIL_ADDRESS>Tue, 21 Nov 2017 15:42:23 -0800 (PST)
ESC[33m15:42:25 smtp.1          | ESC[0mESC[33m=> ESC[0m        by worker2 (Postfix) with ESMTP id 24B878180D
ESC[33m15:42:25 smtp.1          | ESC[0mESC[33m=> ESC[0m        for<EMAIL_ADDRESS>Tue, 21 Nov 2017 15:42:23 -0800 (PST)'
ESC[36m15:42:25 worker.3        | ESC[0mESC[36m=> ESC[0mWARNING: Could not parse (and so ignoring) 'by mail1.foobarinc.com (Postfix) with ESMTP id 26BB781570
ESC[36m15:42:25 worker.3        | ESC[0mESC[36m=> ESC[0m        for<EMAIL_ADDRESS>Tue, 21 Nov 2017 15:42:23 -0800 (PST)
ESC[36m15:42:25 worker.3        | ESC[0mESC[36m=> ESC[0m        by worker2 (Postfix) with ESMTP id 24B878180D
ESC[36m15:42:25 worker.3        | ESC[0mESC[36m=> ESC[0m        for<EMAIL_ADDRESS>Tue, 21 Nov 2017 15:42:23 -0800 (PST)'

<EMAIL_ADDRESS>represents the Postfix server of ours that relays mail into Postal.  Each batch of these lines has a different arbitrary email recipient.  I'm thinking this has something to do with that patch I did for stripping Received headers.

Did you mean https://github.com/atech/postal/pull/282?
Since that pull request is part of the main code now, you could try a postal auto-upgrade to reset your code to what is current.

I updated my copy of client.rb, to handle the continuation lines of Received headers and those warnings have gone away.
Now just need to figure out why procodile isn't gracefully stopping.  Another clue seems to be that of the 4 worker processes I start Postal with, the last one (worker.4) seems to be refusing to stop.    Looks like @adamcooke wrote procodile.  Perhaps he might know what's going on there.


Activating Spring Cloud Config results in NoSuchBeanDefinitionException

Based on https://github.com/apereo/cas-configserver-overlay and https://github.com/apereo/cas-bootadmin-overlay and using 5.1.0-RC4-SNAPSHOT I am getting
2017-04-28 10:27:14,676 WARN [org.apereo.cas.web.CasWebApplicationContext] - <Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'casConfigurationSupportUtilitiesConfiguration': Unsatisfied dependency expressed through field 'configurationPropertiesEnvironmentManager'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apereo.cas.configuration.CasConfigurationPropertiesEnvironmentManager' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true), @org.springframework.beans.factory.annotation.Qualifier(value=configurationPropertiesEnvironmentManager)}>
2017-04-28 10:27:16,345 ERROR [org.springframework.boot.diagnostics.LoggingFailureAnalysisReporter] - <

***************************
APPLICATION FAILED TO START
***************************

Description:

Field configurationPropertiesEnvironmentManager in org.apereo.cas.config.CasConfigurationSupportUtilitiesConfiguration required a bean of type 'org.apereo.cas.configuration.CasConfigurationPropertiesEnvironmentManager' that could not be found.

Action:

Consider defining a bean of type 'org.apereo.cas.configuration.CasConfigurationPropertiesEnvironmentManager' in your configuration.
>

when trying to run cas. Seems to be related to a ConditionalBean which is not created when spring.cloud.config.enabled=true which seems correct, as we cannot not watch the local config directory anymore.

I can verify that I as well have seen this issue and have not yet been able to enable the casconfigserver with my deployment.  I'm running 5.1.0-RC4-SNAPSHOT on Tomcat 8/Java 1.8.

Thanks for the report. Looks like an easy bug fix, but it would have to wait once after RC4 goes out and when we go into bug-fix mode exclusively.

Just FYI, we have a bunch of demos of these things  listed here:
https://apereo.github.io/cas/development/index.html
The config server will show up there shortly, and can be used for testing.

You should be able to test the fix in about an hour or so, by using the new SNAPSHOT.


docs: Add some more Binary Config details

@xzyfer I don't think this is actually correct, but maybe we can add another "Description" column to help too

Thanks for doing this


Error loading plugin

I have already installed ghostscript into Program Files (x86)\gs9.55.0
(And I tried Program Files\gs\gs9.55.0)
There is no useful information on how to install ghostscript or get it working for this plugin.

Do you mean by >>(And I tried Program Files\gs\gs9.55.0)<< that you also installed the 64bit version of ghostscript? The installation path should then look like C:\Program Files\gs\gs9.50.
Unfortunately the automatic detection of system paths is one of the messiest things in LaTeX2AI, we are currently working on it and the behavior should be better in the upcoming releases. For now, make sure the 64bit version of ghostscript is installed in the default path and try one of the following two things:

Remove the files under C:\Users\USERNAME\AppData\Local\Adobe\Illustrator\LaTeX2AI\
Manually create the application data file C:\Users\USERNAME\AppData\Local\Adobe\Illustrator\LaTeX2AI\LaTeX2AI_application_data.xml with the content (replace the paths to match your system)<LaTeX2AI_options
  command_gs="GS_PATH\gswin64c.exe"
  command_latex="pdflatex"
  command_latex_options="-interaction nonstopmode -halt-on-error -file-line-error"
  path_form_exe="FORMS_PATH\LaTeX2AIForms.exe"
  path_latex=""
/>

@macklinhrw did you try the suggestions? Also there is a new release v0.0.7 with improved path finding, you might also want to check that one out.
If you could resolve your problem, please close this issue.


MSPSDS-655: fix: some small font fixes

fix fonts in businesses/index, investigations/index, products/_form and products_suggestions_container

Pull Request Test Coverage Report for Build 845

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.222%

Totals

Change from base Build 844:
0.0%

Covered Lines:
1218

Relevant Lines:
1350

💛  - Coveralls


[Bug]: Custom queries override sane defaults

after/queries/python is overriding @variable.builtin (self), causing worse highlighting for any theme.
I'd recommend either a) using a custom name so as to not interfere with defaults, and they stay specific to this theme, or b) load them only if the plugin is loaded/in use
Relevant: https://github.com/nvim-treesitter/nvim-treesitter/issues/4485

@amaanq thanks for flagging! Stupidity on my part.
Interestingly, how do you conditionally load queries?

ngl, idk 😅 maybe putting it in a different directory and adding it to the runtime path of the theme is in use might work, give it a shot


Trying to use pdftotext in my Rails App deployed in Amazon with Elastic Beanstalk

For any reason the txt file is not being generated when running the app in AWS. The following works perfectly fine in local:
`
def self.pdf_to_text(file, noblank = true)
spec = file.sub(/.pdf$/, '')
pdftotext #{spec}.pdf
if File.exists?("#{spec}.txt")
  file = File.new("#{spec}.txt")
else
  abort "File in txt can not be found!"
end
text = []
file.readlines.each do |l|
  l.chomp! if noblank
  if l.length > 0
    text && l
  end
end
file.close

end
`
If doing the following:
text = Pdftotext.text("example.pdf")
I am getting the following error:
Cliver::Dependency::NotFound: Could not find an executable ["pdftotext"] on your path.
from /home/ec2-user/.gem/ruby/2.3.4/gems/cliver-0.3.2/lib/cliver/dependency.rb:143:in `raise_not_found!'

Have you installed Poppler as described in the README?

Hi Ben - yes that was the piece I was missing. Installed it in the server and worked fine. Thanks!


docs: add banner

:books: Documentation preview :books:: https://meltano-sdk--1763.org.readthedocs.build/en/1763/

@sbalnojan can you take this PR and update the colors / copy to what you want? We can add this to the EDK docs too.


Hide Primary Tray Area bug

Describe the bug
As you can see in the photo below, when I have both "hide primary start button" and "hide primary tray area" turned on, it doesn't exactly hiding the tray area but it is showing its borders.
To Reproduce
Steps to reproduce the behavior:

Go to 'extra'
Click on 'Hide Primary Start Button' & 'Hide Primary Tray Area'
Click on 'Apply'
See error

Expected behavior
It should hide the tray area without showing the borders.
Screenshots

Desktop (please complete the following information):

OS: Windows 10 pro
Version 1909

Additional context
Sometimes it does it even when  "hide primary start button" is off but not always.

Same issue. And thank you, Chris, just got TaskbarX and Aerial today, very happy!

Same issue. And thank you, Chris, just got TaskbarX and Aerial today, very happy!

@Everun2 @lefterispg I think I've got it now. You can try out the Pre-Release ;)
https://github.com/ChrisAnd1998/TaskbarX/releases/tag/<IP_ADDRESS>

@Everun2 @lefterispg I think I've got it now. You can try out the Pre-Release ;)
https://github.com/ChrisAnd1998/TaskbarX/releases/tag/<IP_ADDRESS>

@lefterispg , can you please tell after hiding the tray area is there a way to access it. i just discovered hiding start menu and tray, but sometimes i need to access the tray. is there a way ?

@lefterispg , can you please tell after hiding the tray area is there a way to access it. i just discovered hiding start menu and tray, but sometimes i need to access the tray. is there a way ?

I'd also like this a lot.
Something similar to the checkbox - Switch back to default on maximized window
It is possible?