HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in tea…

…rdown

Updated the changeset comment:

    HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown

    hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
     Change parameter name and add javadoc to make it more clear what the
     param actually is.

    hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/AssignRegionHandler.java
     Move postOpenDeployTasks so if it fails to talk to the Master -- which
     can happen on cluster shutdown -- then we will do cleanup of state;
     without this the RS can get stuck and won't go down.

    hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java
     Add handleException so CRH looks more like UnassignRegionHandler and
     AssignRegionHandler around exception handling. Add a bit of doc on
     why CRH.

    hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/UnassignRegionHandler.java
     Right shift most of the body of process so can add in a finally
     that cleans up rs.getRegionsInTransitionInRS is on exception
     (otherwise outstanding entries can stop a RS going down on cluster
     shutdown)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m 15s
branch-2 passed

+1 :green_heart:
checkstyle
1m 17s
branch-2 passed

+1 :green_heart:
spotbugs
2m 11s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 35s
the patch passed

+1 :green_heart:
checkstyle
1m 18s
hbase-server: The patch generated 0 new + 53 unchanged - 4 fixed = 53 total (was 57)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 44s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
spotbugs
2m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

45m 39s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 5f26a9ea0127 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ffb2359146

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m 36s
branch-2 passed

+1 :green_heart:
compile
1m 11s
branch-2 passed

-1 :x:
shadedjars
0m 10s
branch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 17s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
shadedjars
0m 10s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

-0 :warning:
unit
105m 39s
hbase-server in the patch failed.

125m 49s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eda6b4b0615f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ffb2359146

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/testReport/

Max. process+thread count
5729 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m 50s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
the patch passed

_ Other Tests _

-1 :x:
unit
106m 15s
hbase-server in the patch failed.

135m 54s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1e3dc7b68916 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ffb2359146

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/testReport/

Max. process+thread count
5504 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Thanks @ndimiduk . Will wait see if this patch good by @Apache9

bq. Let's focus on just making the UT pass here, without changing other code.
It is not just about unit test.
bq. I suggest we open a follow on issue, to discuss the abort behavior.
You are welcome to. I'm current just interested in landing a fix for cluster shutdown/RS aborts and concurrent assign/unassigns which causes flakey test failures and hangs in the wild.
bq. To me, the operations in abort method do not make sense. Maybe we just need to try our best to close the connection to zk to let master know we are dead, and then just do a System.exit(1). For now we will do lots of clean up work and even want to flush all the regions? This is not a abort I'd say, it is almost like a graceful shutdown...
For new issue.

bq. If you really want to do this to let the test pass, I suggest you add the removal in the handleException method, and add a FIXME or TODO comment to say that this is just for making test pass, should be addressed later.
I can move it to handleException, np. I will NOT note that it a UT fix only. There is an obvious hole here holds up shutdowns and shutdowns are not UT only.
These Handlers strike me as arbitrary regards where stuff goes; no wonder there are holes.
Let me put up another patch w/ your suggestions.

New push. Enjoys the benefit of @Apache9 feedback. Main change is restoring these Handlers to as they were (but w/ the PONR comment added) and then in the handleException, just removing entry from RS RIT map just before call to abort. Gets me what I want and leaves rest of code as was.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
7m 49s
branch-2 passed

+1 :green_heart:
checkstyle
1m 26s
branch-2 passed

+1 :green_heart:
spotbugs
2m 40s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 48s
the patch passed

+1 :green_heart:
checkstyle
1m 27s
hbase-server: The patch generated 0 new + 53 unchanged - 4 fixed = 53 total (was 57)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
22m 19s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
spotbugs
2m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

56m  6s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c521f1c30def 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ffb2359146

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m 30s
branch-2 passed

+1 :green_heart:
compile
1m  7s
branch-2 passed

-1 :x:
shadedjars
0m 12s
branch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 11s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
shadedjars
0m 11s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 37s
hbase-server in the patch failed.

_ Other Tests _

-0 :warning:
unit
68m 26s
hbase-server in the patch failed.

87m 43s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 18256abb643f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ffb2359146

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/testReport/

Max. process+thread count
5611 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m  6s
branch-2 passed

+1 :green_heart:
compile
1m  1s
branch-2 passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 17s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

-1 :x:
unit
67m 34s
hbase-server in the patch failed.

94m 32s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5de009b95d02 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ffb2359146

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/testReport/

Max. process+thread count
5609 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

One of the test failures -- A perversion around Region handling in TestRegionObserverInterface -- exposed issue w/ the CloseRegionHandler refactor trying to make it look like other handlers around  regionsInTransitionInRS handling. Fixed (and fixed the issue @Apache9 noted above). Added region name logging to this journal stuff -- otherwise its just opaque... thats just log change.

Thanks for review @Apache9 . I'd filed HBASE-24015 a few days ago because it seemed plain this issue had opened a can of worms -- and that was before you showed up. You want to go more radical that the scope of HBASE-24015, so I made HBASE-24026 for shutdown redo. Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m 18s
branch-2 passed

+1 :green_heart:
checkstyle
1m 21s
branch-2 passed

+1 :green_heart:
spotbugs
2m  9s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 43s
the patch passed

+1 :green_heart:
checkstyle
1m 23s
hbase-server: The patch generated 0 new + 259 unchanged - 4 fixed = 259 total (was 263)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 54s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
2m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

40m 14s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux<PHONE_NUMBER>d7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8320f73c8c

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 23s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
10m 43s
branch-2 passed

+1 :green_heart:
compile
1m 51s
branch-2 passed

-1 :x:
shadedjars
0m 13s
branch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m  2s
hbase-server in branch-2 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
9m 49s
the patch passed

+1 :green_heart:
compile
1m 46s
the patch passed

+1 :green_heart:
javac
1m 46s
the patch passed

-1 :x:
shadedjars
0m 24s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
1m  9s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
82m 49s
hbase-server in the patch passed.

113m 27s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9bf12a52404a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8320f73c8c

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/testReport/

Max. process+thread count
5634 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
6m  8s
branch-2 passed

+1 :green_heart:
compile
1m  1s
branch-2 passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 44s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
4m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
101m  0s
hbase-server in the patch failed.

129m  6s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1311

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3e382637ced1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8320f73c8c

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/testReport/

Max. process+thread count
4172 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1311/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Test report shows no failures. The test output got dropped because of below. I've been running this in tests local and seems fine. Will merge and keep an eye on it.
Post stage
[Pipeline] junit
[2020-03-20T21:24:40.217Z] Recording test results
[2020-03-20T21:24:43.747Z] Remote call on H1 failed
Error when executing always post condition:
java.io.IOException: Remote call on H1 failed
at hudson.remoting.Channel.call(Channel.java:963)
at hudson.FilePath.act(FilePath.java:1072)
at hudson.FilePath.act(FilePath.java:1061)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)
at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)
at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)
at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)
at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class jenkins.model.Jenkins
at hudson.ExtensionList.lookup(ExtensionList.java:433)
at hudson.tasks.junit.TestNameTransformer.all(TestNameTransformer.java:40)
at hudson.tasks.junit.TestNameTransformer.getTransformedName(TestNameTransformer.java:33)
at hudson.tasks.junit.CaseResult.getTransformedTestName(CaseResult.java:273)
at hudson.tasks.junit.SuiteResult.casesByName(SuiteResult.java:134)
at hudson.tasks.junit.SuiteResult.addCase(SuiteResult.java:297)
at hudson.tasks.junit.SuiteResult.(SuiteResult.java:270)
at hudson.tasks.junit.SuiteResult.parseSuite(SuiteResult.java:209)
at hudson.tasks.junit.SuiteResult.parse(SuiteResult.java:181)
at hudson.tasks.junit.TestResult.parse(TestResult.java:348)
at hudson.tasks.junit.TestResult.parsePossiblyEmpty(TestResult.java:281)
at hudson.tasks.junit.TestResult.parse(TestResult.java:206)
at hudson.tasks.junit.TestResult.parse(TestResult.java:178)
at hudson.tasks.junit.TestResult.(TestResult.java:143)
at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:146)
at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:118)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3052)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
... 4 more
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to H1
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1743)
at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:957)
at hudson.FilePath.act(FilePath.java:1072)
at hudson.FilePath.act(FilePath.java:1061)
at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)
at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)
at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)
at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)
at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)
at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
... 4 more


Error when trying to install extensions

I can't install any extension i don't know why.
every time i try to install new one i get this error
"Failed to install extension-name, Download Manually"
and even when i do download the extension manually it gives me the same error.
also all the extensions icons are not loading which means the editor can't reach the vs code servers to get the extensions and the icons.
but i have no idea how to fix it.
in the console when i open the extensions tab i get a list of errors for failing to fetch the icons and also the network tab i get an error when i try to install extensions,
i have screenshot for all that down below.

Related to #78783 seems to be a DNS issue.
Can you try to access this image? ms-python.gallerycdn.vsassets.io/extensions/ms-python/python/2019.8.29288/1565127378610/Microsoft.VisualStudio.Services.Icons.Default
If not, can you try changing your DNS setting, like pointing to <IP_ADDRESS> as suggested here? <IP_ADDRESS>/dns

Thanks It's a DNS Problem once I changed it everything went well!

all the solutions seems to be the same but i tried all noting is working i don't know what's wrong it was working perfectly before.


GPU Support Functions

Implement GPU support functions as described in Poseidon #199

Codecov Report

Merging #244 (d7a3f0d) into develop (0767ba7) will decrease coverage by 4.21%.
The diff coverage is 8.23%.

@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
- Coverage    82.46%   78.24%   -4.22%
===========================================
  Files           51       51
  Lines         2823     2993     +170
===========================================
+ Hits          2328     2342      +14
- Misses         495      651     +156

Impacted Files
Coverage Δ

include/client.h
100.00% <ø> (ø)

include/redisserver.h
100.00% <ø> (ø)

src/cpp/client.cpp
79.52% <0.00%> (-7.43%)
:arrow_down:

src/cpp/redis.cpp
57.03% <0.00%> (-13.06%)
:arrow_down:

src/python/module/smartredis/client.py
81.92% <22.22%> (-13.99%)
:arrow_down:

@al-rigazzi  Good idea on image_id.  Maybe there is a more intuitive variable name we can use.

To Mellis's comments:
0. Thanks for a careful review!

I'll write some test cases to cover the bits of the functions that can be hit on a non-GPU system
I added an issue for delete multi-GPU methods
Per discussion in group, I'll add support for first GPU/GPU count to the methods.

Matt's comments are now addressed


Creating a new data assets uses default datastore by default

We've encountered this issue recently:
Dataset initialization failed: UserErrorException:
Message: Failed with visit error: Failed with execution error: error in streaming from input data sources
VisitError(ExecutionError(StreamError(NotFound)))
=> Failed with execution error: error in streaming from input data sources
ExecutionError(StreamError(NotFound))
InnerException None
ErrorResponse
{
"error": {
"code": "UserError",
"message": "Failed with visit error: Failed with execution error: error in streaming from input data sources\n\tVisitError(ExecutionError(StreamError(NotFound)))\n=> Failed with execution error: error in streaming from input data sources\n\tExecutionError(StreamError(NotFound))"
}
}
This happened because the data asset was created using the workspace's default datastore. On shared workspaces like (hai4, mprr1ws), the default datastore doesn't contain our private data.
One should specify --datastore when submitting the first ever job that creates the data assets as we can not delete/edit data assets once they are created.
Using the default workspace's datastore by default is not always desired, can we come up with another strategy for default datastores?
Possible options:

The user has to specify a datastore for the first job: in get_or_create_data_asset only create the data asset if datastore is specified, this would force the user to be careful the first time and specify the right datastore
Before using the default workspace's datastore: can we check that the dataset exists already? if not throw an error: Input Dataset doesn't exist in default datastore, please specify the right datastore ?

cc @ant0nsc @peterhessey

After some more investigation here, it seems that creating new assets using the _create_v2_data_assets in datasets.py is creating all new assets in the default datastore, even if the datastore is specified on the command line.


#66 Made that list-configuration-options command was independent 2

This MR solves the issue, when pramen-py list-configuration-options were incompatible with windows os. The reason was in python3.6 doesn't support asyncio.subprocess.create_subprocess_shell on Windows. Solution is to use inbuilt.open for reading .env.example instead of running subprocess call with cat command

Also please do some short descriptions in the MR header. I'll try to give here an example

Awesome work! If this makes sense, can you use draft MR feature to indicate the work in progress (WIP) state. And once it is done, switch to ready for review (button at the end of screen)

We thought it was ready until we were unable to merge conflicts since the branch contained many commits with trial and error implementations.

Also please do some short descriptions in the MR header. I'll try to give here an example

I've added
Closes #66

as the description to this PR. This way it links to the issue and closes it automatically on merge.
I see you added more verbose description - thanks a lot!


Add error message to group creation, if group already exists

Currently the application doesn't display error message, if user tries to create a group that already exists.

[x] choose way to display error, preferably a MUI element
[x] give an error message
[x] Tests that produces the correct error on cypress

Pushed.


Add threlte and @threlte/xr

It was lovely meeting you at the hackathon. Thanks for this resource! Added a bit of shameless self-promotion 😂
Let me know if formatting is wrong / I need to change anything!

Was great meeting you too! Formatting looks good, just move it down the list a bit to be alphabetical and it'll be good to go

Woops! Missed that it was alphabetical, updated!

Thanks!


exercise 8 [-] PROGRAM ABORT : We need at least one valid input seed that does not crash!

cccc@ubuntu:~/fuzzing_acro$ AFL_QEMU_PERSISTENT_ADDR=0x08a464c8 AFL_QEMU_PERSISTENT_GPR=1 ACRO_INSTALL_DIR=/opt/Adobe/Reader9/Reader ACRO_CONFIG=intellinux LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'/opt/Adobe/Reader9/Reader/intellinux/lib' afl-fuzz -Q -i ./afl_in/ -o ./afl_out/ -t 2000 -- /opt/Adobe/Reader9/Reader/intellinux/bin/acroread -toPostScript @@
afl-fuzz++4.01a based on afl by Michal Zalewski and a large online community
[+] afl++ is maintained by Marc "van Hauser" Heuse, Heiko "hexcoder" Eißfeldt, Andrea Fioraldi and Dominik Maier
[+] afl++ is open source, get it at https://github.com/AFLplusplus/AFLplusplus
[+] NOTE: This is v3.x which changes defaults and behaviours - see README.md
[+] No -M/-S set, autoconfiguring for "-S default"
[] Getting to work...
[+] Using exponential power schedule (FAST)
[+] Enabled testcache with 50 MB
[+] Generating fuzz data with a a length of min=1 max=1048576
[] Checking core_pattern...
[!] WARNING: Could not check CPU scaling governor
[+] You have 2 CPU cores and 1 runnable tasks (utilization: 50%).
[+] Try parallel jobs - see /usr/local/share/doc/afl/parallel_fuzzing.md.
[] Setting up output directories...
[+] Output directory exists but deemed OK to reuse.
[] Deleting old session data...
[+] Output dir cleanup successful.
[] Checking CPU core loadout...
[+] Found a free CPU core, try binding to #0.
[] Scanning './afl_in/'...
[+] Loaded a total of 9 seeds.
[] Creating hard links for all input files...
[] Validating target binary...
[] No auto-generated dictionary tokens to reuse.
[] Attempting dry run with 'id:000000,time:0,execs:0,orig:test.pdf'...
[] Spinning up the fork server...
[+] All right - fork server is up.
[] Target map size: 65536
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000000,time:0,execs:0,orig:test.pdf' results in a crash, skipping
[*] Attempting dry run with 'id:000001,time:0,execs:0,orig:LIBRE_OFFICE-98479-0.zip-2.fdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000001,time:0,execs:0,orig:LIBRE_OFFICE-98479-0.zip-2.fdf' results in a crash, skipping
[*] Attempting dry run with 'id:000002,time:0,execs:0,orig:LIBRE_OFFICE-96902-1.pdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000002,time:0,execs:0,orig:LIBRE_OFFICE-96902-1.pdf' results in a crash, skipping
[*] Attempting dry run with 'id:000003,time:0,execs:0,orig:LIBRE_OFFICE-92614-3.pdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000003,time:0,execs:0,orig:LIBRE_OFFICE-92614-3.pdf' results in a crash, skipping
[*] Attempting dry run with 'id:000004,time:0,execs:0,orig:LIBRE_OFFICE-84690-0.pdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000004,time:0,execs:0,orig:LIBRE_OFFICE-84690-0.pdf' results in a crash, skipping
[*] Attempting dry run with 'id:000005,time:0,execs:0,orig:LIBRE_OFFICE-129976-1.pdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000005,time:0,execs:0,orig:LIBRE_OFFICE-129976-1.pdf' results in a crash, skipping
[*] Attempting dry run with 'id:000006,time:0,execs:0,orig:LIBRE_OFFICE-107149-0.pdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000006,time:0,execs:0,orig:LIBRE_OFFICE-107149-0.pdf' results in a crash, skipping
[*] Attempting dry run with 'id:000007,time:0,execs:0,orig:LIBRE_OFFICE-106270-0.ps'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000007,time:0,execs:0,orig:LIBRE_OFFICE-106270-0.ps' results in a crash, skipping
[*] Attempting dry run with 'id:000008,time:0,execs:0,orig:LIBRE_OFFICE-106270-0.pdf'...
[-] Oops, the program crashed with one of the test cases provided. There are
several possible explanations:
- The test case causes known crashes under normal working conditions. If
  so, please remove it. The fuzzer should be seeded with interesting
  inputs - but not ones that cause an outright crash.

- In QEMU persistent mode the selected address(es) for the loop are not
  properly cleaning up variables and memory. Try adding
  AFL_QEMU_PERSISTENT_GPR=1 or select better addresses in the binary.

- Least likely, there is a horrible bug in the fuzzer. If other options
  fail, poke<EMAIL_ADDRESS>for troubleshooting tips.

[!] WARNING: Test case 'id:000008,time:0,execs:0,orig:LIBRE_OFFICE-106270-0.pdf' results in a crash, skipping
[+] All test cases processed.
[-] PROGRAM ABORT : We need at least one valid input seed that does not crash!
Location : main(), src/afl-fuzz.c:2165
according to the error message ,i put a normal test.pdf  into afl_in . The error was still generated. i don't know how to solve it. is it related with afl++ version? or else?
thank you ~~`

cccc@ubuntu:~/fuzzing_acro$ AFL_QEMU_PERSISTENT_ADDR=0x08546a00 AFL_QEMU_PERSISTENT_GPR=1 ACRO_INSTALL_DIR=/opt/Adobe/Reader9/Reader ACRO_CONFIG=intellinux LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'/opt/Adobe/Reader9/Reader/intellinux/lib' afl-fuzz -Q -i ./afl_in/ -o ./afl_out/ -t 2000 -- /opt/Adobe/Reader9/Reader/intellinux/bin/acroread -toPostScript @@
the same error ~~~[-] PROGRAM ABORT : We need at least one valid input seed that does not crash!
Location : main(), src/afl-fuzz.c:2165

yes, i got crash when i was running afl-fuzz with the -Q argument.

@antonio-morales 👍 thank you for your concern:-) yes, i got crash when i was running like this: ACRO_INSTALL_DIR=/opt/Adobe/Reader9/Reader ACRO_CONFIG=intellinux LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'/opt/Adobe/Reader9/Reader/intellinux/lib' afl-fuzz -Q -i ./afl_in/ -o ./afl_out/ -t 2000 -- /opt/Adobe/Reader9/Reader/intellinux/bin/acroread -toPostScript @@ why i failed fuzzing when i used Persistent approach~~~ thank you for your guidance .

hi, the problem was fixed? I have the same problem. when i was runing like this:
 AFL_DEBUG=1 AFL_QEMU_PERSISTENT_ADDR=0x08a464c8 AFL_QEMU_PERSISTENT_GPR=1 ACRO_INSTALL_DIR=/opt/Adobe/Reader9/Reader ACRO_CONFIG=intellinux LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'/opt/Adobe/Reader9/Reader/intellinux/lib' afl-fuzz -Q -i afl_in/ -o afl_out/ -t 2000 -- /opt/Adobe/Reader9/Reader/intellinux/bin/acroread -toPostScript @@
afl-qemu-trace: /opt/Adobe/Reader9/Reader/intellinux/bin/acroread: Invalid ELF image for this architecture

[-] Hmm, looks like the target binary terminated before we could complete a
handshake with the injected code. You can try the following:

    - The target binary crashes because necessary runtime conditions it needs
      are not met. Try to:
      1. Run again with AFL_DEBUG=1 set and check the output of the target
         binary for clues.
      2. Run again with AFL_DEBUG=1 and 'ulimit -c unlimited' and analyze the
         generated core dump.

    - Possibly the target requires a huge coverage map and has CTORS.
      Retry with setting AFL_MAP_SIZE=10000000.

Otherwise there is a horrible bug in the fuzzer.
Poke<EMAIL_ADDRESS>for troubleshooting tips.

[-] PROGRAM ABORT : Fork server handshake failed
         Location : afl_fsrv_start(), src/afl-forkserver.c:1234

@bugchong "Invalid ELF image for this architecture"
Are you running this exercise on an ARM architecture?

@bugchong @antonio-morales ，
Hi , I met the same problem. "Invalid ELF image for this architecture"
test@A1fr3d:~/fuzzing_adobe$ file /opt/Adobe/Reader9/Reader/intellinux/bin/acroread
/opt/Adobe/Reader9/Reader/intellinux/bin/acroread: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 2.2.5, stripped

Hi @QiuJYWX
could run the following one on your machine
hostnamectl
and post here the result?
Thanks

Hi @antonio-morales , the result is attached when run hostnamectl
test@A1fr3d:~$ hostnamectl
Static hostname: A1fr3d
Icon name: computer-desktop
Chassis: desktop
Machine ID: fb509d7756084fc5a6d0931f75cf9c63
Boot ID: feaf1ba1eaa14457a8321dde78873db8
Operating System: Ubuntu 20.04.3 LTS
Kernel: Linux 5.11.0-40-generic
Architecture: x86-64

@bugchong "Invalid ELF image for this architecture"
Are you running this exercise on an ARM architecture?

no,it's not ARM architecture.
/opt/Adobe/Reader9/Reader/intellinux/bin/acroread: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 2.2.5, stripped

Hi @antonio-morales , the result is attached when run hostnamectl
test@A1fr3d:~$ hostnamectl Static hostname: A1fr3d Icon name: computer-desktop Chassis: desktop Machine ID: fb509d7756084fc5a6d0931f75cf9c63 Boot ID: feaf1ba1eaa14457a8321dde78873db8 Operating System: Ubuntu 20.04.3 LTS Kernel: Linux 5.11.0-40-generic Architecture: x86-64

i run "hostnamectl", the result is:
Static hostname: ubuntu
Icon name: computer-vm
Chassis: vm
Machine ID: f98866921b244210ba72b0a957db18dc
Boot ID: 7a1f0ac04db9418bbfede5453f41546e
Virtualization: vmware
Operating System: Ubuntu 20.04.2 LTS
Kernel: Linux 5.13.0-39-generic
Architecture: x86-64

@antonio-morales 👍 thank you for your concern:-) yes, i got crash when i was running like this: ACRO_INSTALL_DIR=/opt/Adobe/Reader9/Reader ACRO_CONFIG=intellinux LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'/opt/Adobe/Reader9/Reader/intellinux/lib' afl-fuzz -Q -i ./afl_in/ -o ./afl_out/ -t 2000 -- /opt/Adobe/Reader9/Reader/intellinux/bin/acroread -toPostScript @@ why i failed fuzzing when i used Persistent approach~~~ thank you for your guidance .

hi, the problem was fixed? I have the same problem. when i was runing like this:
 AFL_DEBUG=1 AFL_QEMU_PERSISTENT_ADDR=0x08a464c8 AFL_QEMU_PERSISTENT_GPR=1 ACRO_INSTALL_DIR=/opt/Adobe/Reader9/Reader ACRO_CONFIG=intellinux LD_LIBRARY_PATH=$LD_LIBRARY_PATH:'/opt/Adobe/Reader9/Reader/intellinux/lib' afl-fuzz -Q -i afl_in/ -o afl_out/ -t 2000 -- /opt/Adobe/Reader9/Reader/intellinux/bin/acroread -toPostScript @@
afl-qemu-trace: /opt/Adobe/Reader9/Reader/intellinux/bin/acroread: Invalid ELF image for this architecture

[-] Hmm, looks like the target binary terminated before we could complete a
handshake with the injected code. You can try the following:

    - The target binary crashes because necessary runtime conditions it needs
      are not met. Try to:
      1. Run again with AFL_DEBUG=1 set and check the output of the target
         binary for clues.
      2. Run again with AFL_DEBUG=1 and 'ulimit -c unlimited' and analyze the
         generated core dump.

    - Possibly the target requires a huge coverage map and has CTORS.
      Retry with setting AFL_MAP_SIZE=10000000.

Otherwise there is a horrible bug in the fuzzer.
Poke<EMAIL_ADDRESS>for troubleshooting tips.

[-] PROGRAM ABORT : Fork server handshake failed
         Location : afl_fsrv_start(), src/afl-forkserver.c:1234

not yet. i stiil failed in using persistent mode ~~~ i've read your issue . Is it related file format ?  In my case ,my problem was fouced on Input seeds. i could not start afl-fuzz interface normally after run the command. Anyway , Please tell me when you fixed your problem. Thanks !


conf.json issues

There are issues with conf.json. It's accessible with url and it gets lost after SPIFFS flashing. I think it should not be a SPIFFS file. Maybe the parameters could be saved with EEPROM library or there is a Wifi config mentioned in the flash layout diagram in Filesystem doc, but I can't found anything esp8255 core related about it.

Per the discussion in #25 , browsing to http://192.168.xx.yy/config.json  for the present device from any other device on the same network returns {"ssid":"your_ssid_name","password":"your_formerly_secret_password"} (with the actual unencrypted data).


Add HF models support

Create a support to Hugging Face models.
This needs to run a server considering a MODEL_PATH and HF_TOKEN env vars.

Working on that :D


I should have committed a project.lock.json file. then this would be much more on the side of deletion. Missed opportunity..


Add rethinkdb readiness check

Right now we wrap make test w a single make launch-test-rethinkdb sub task. (Before we had this subtask running on each suite that required it ... so that e.g. if you run make fuse it'll spin up the dependencies it needs to run the tests).
The problem is that the start time of rethinkdb is flaky. We know this lesson well from how pachd starts up (if it can't connect, it panics, and k8s reschedules the pod until it connects).
However, for the testing purposes it would be nice to have something block until its ready. Even the fix we have in place now will err sometimes if rethink happens to take longer than 20s to startup.

Do you think we could make things simpler and just use the rethink server that's spun up by make launch? That already has readiness checking. And it has the really nice advantage that it's guaranteed to be deployed the same way as you get from the manifest. So we'll avoid issues resulting from things like different versions of rethink being spun up?

Yea, thats a good point. However we want to make sure make test-fuse and make test-local also launch the cluster to make sure they have what they need for the tests. So, I'll:

Make each suite that needs it launch the cluster in its make task (make test, make test-fuse, make test-local)
Update make launch to do nothing if it detects that the cluster is already up (so that its idempotent)

This way we'll only launch the cluster once on CI, not three times.

Then, I'll go ahead and add the readiness probe to the manifest for rethinkdb. That should make pachd startup cleaner (and less confusing to users). I'll be using their own script for this

Ok, this is all done on the pfs-refactor branch (just using the launch-dev task for spinning up DB, updating rethinkDB in manifest to use readiness probe).
One note -- if you're using docker-machine now, you'll need to forward the 28015 port to be able to run the tests locally.

I got this partly working on pfs-refactor branch, but couldn't get local tests suites connecting to the rethink instance (which I'm sure is some k8s networking config).
However, I left the readiness probe in place, but there seem to be a few issues with it.
A) For a user on GCE, it wasn't working at all
They see the following logs:
  54m        1s        655    {kubelet gke-pach-cluster-default-pool-26852678-alpi}    spec.containers{rethink}    Warning        Unhealthy    Readiness probe failed: Get http://localhost:8080/: dial tcp <IP_ADDRESS>:8080: getsockopt: connection refused```

I'd expect maybe a few failures in the course of spinning this up, but it really shouldn't take that long (54 minutes and not up)

B) They reported that they saw the following when executing the curl manually:

They did `curl localhost:8080` and got the loading message below

```html

Loading...

Which I think is the message you see when the dashboard isn't connected to the backend? In which case, the server responding w any payload and a 200 gives us the wrong signal for a readiness check. In other words .... it'll respond before the backend is truly ready.

Oh one thing that comes to mind to explain the first effect.
I used the defaults I saw elsewhere to specify the total number of times it'll retry the readiness probe. If they're deploying k8s on a smaller VM, its possible it'll take rethink longer to startup, but by that time we'll have spent all of our readiness checks. We should consider updating that number (or removing it if it'll just try indefinitely)

Readiness check should probably keep going indefinitely.
We also might want to consider removing it, at least for non-dev clusters, it seems like it's an added liability to a functional system coming up and we already have a pretty effective readiness check for pachd which can't pass unless rethink has also come up correctly.

Do our tests depend on the readiness check?

Yea, I'll remove it for now. If we find we want it later we'll need to vet these issues to make sure it works.
Right now the integration tests implicitly rely on the cluster being up, so rely on the readiness check. But as you said, the pachd startup mechanism was working before without this check.

Ok, removed it
Putting that link here for posterity for when we do look at this again.

Rethink is no more. Closing.


[tutorial] less confusing self-quiz instruction

Instructs the user to "guess" rather than "write" a response. Also gives a hint that the answer might be "nothing."

LGTM!


Initial webapp version

F16 OK (400 pts)

This is a duplicate of issue #1, which for some reason is hiding:


Register in General

@JuliaRegistrator register()

Error while trying to register: "Pre-release version not allowed"

@JuliaRegistrator register()


Bump version to 1.2.0-alpha.1

We need the new version in query builder, it's currently blocking lots
of work.

Then next version would be 2.0.0-alpha.0 since we merged breaking changes into the master. Also, let me know when you have time, so we can do a one off r4elease together (the pre-release process is a little different than the release process we currently have (I am working on creating documentation and new workflows fro the pre-release).

Then next version would be 2.0.0-alpha.0 since we merged breaking changes into the master. Also, let me know when you have time, so we can do a one off r4elease together (the pre-release process is a little different than the release process we currently have (I am working on creating documentation and new workflows fro the pre-release).

I might be missing something obvious but the flavor change for buttons didn't get merged. Did we merge something else?

Did we merge something else?

Yeah, we deprecated the width prop for all components (#259). You can also take a look at [CHANGELOG.md](https://github.com/wmde/wikit/blob/master/CHANGELOG.md) to see the next expected version and what changed.

Did we merge something else?

Yeah, we deprecated the width prop for all components (#259). You can also take a look at CHANGELOG.md to see the next expected version and what changed.

Thanks. Done now.


Fix parsing and display of author information in BD2K-LINCS

The display of author information in dataset records from BD2K-LINCS looks bad for at least 1 record

It appears that the record may need to be split on commas during the parsing as multiple names are appearing in a single field:
  "author": [     {       "name": "Caitlin E. Mills"     },     {       "name": "Marc Hafner, Kartik Subramanian"     }   ],   "date": "2018-10-18",
Please conduct a check to see how frequently "," shows up in the "author.name" field for BD2K-LINCS records to better understand the extent of the problem before addressing. We don't want to inadvertently create a bunch of records with 'author.name = Jr.' if the majority of commas in the name field are not from lists but from those with actual commas in their names.

@Dylan I think this maybe emerges because we're concatenating two separate author types together. Can you check if that's true and we need to split the author field?
As @gtsueng notes, though, this could have unintended consequences if the authors are provided as a string.

Unfortunately with the LINCS api down (see dataset page and api there's no way to be sure, but looking at the code I believe this issue is with the way we split on the comma if there are multiple authors. The way it's setup now we split on a comma + 2 spaces. The dataset ginger linked we can see it's a comma + 1 space. So the split didn't happen on that string and saved both names to the author.name field. Lines 54/56 for reference. What I'll do is split on just the comma and strip all the whitespace from each name. We won't know until the website is back up if that's the actual solution but I believe it is.

Here is the the dataset's metadata that Ginger found:
  "author": [
    {
      "name": "Caitlin E. Mills"
    },
    {
      "name": "Marc Hafner, Kartik Subramanian"
    }
  ],

@DylanWelzel -- can you see how often a comma appears in the author.name field in our current build/dump of BD2K-LINCS data? This should give us an idea of the extent of the problem (is it a parser issue, or a one-off dataset issue). To be on the safe side, also check for the frequency of the terms "Jr" or "Sr". I didn't categorize it as a bug at this point, because it was unclear to me if we are not properly handling the data with our crawler or if the field has inconsistent values in needed of more extensive clean up.

Using this query 55 out of 424 datasets are affected. No Jr or Sr terms.

Thanks @DylanWelzel! Based on your query, I can see that splitting on the comma may cause issues for three of the records which formatted as "LastName, FirstInitial; LastName, FirstInitial", but should otherwise work. It looks like there are some records with extra quotation marks around the names, so we may want to consider checking them after any change is implemented to ensure that it worked.
Semi-colon delimited records: LINCS_LDS-1508, LINCS_LDS-1523, LINCS_LDS-1512
Extra quotation mark records: LINCS_LDS-1586, LINCS_EDS-1016, LINCS_LDS-1585, LINCS_EDS-1015

LINCS team is fixing this. I think this should be counted as "bug" that Scripps will resolve. (context: per Wilbert email 7/25/2023)

On 2023.08.04, the LINCS team sent a notice that the issue has been fixed.

As of 2023.08.09 a fix is available but is awaiting deployment and testing in staging

As of 2023.08.14, the fix has been implemented


How to access fields with the new API

How can fields be accessed in the Form ?
It looks like in the previous API one could define fields: {} in the decorator and then access them using props.fields.fieldname.onChange etc...
When I do this with v6.2.1 I just get an array of string values...
Thanks

Assuming you are using redux-form 6*, If you want to access individual fields in your form, then you can do something like this:
const selector = formValueSelector('redux-form-name');
function mapStateToProps(state) {
  const fieldValue = selector(state,'form-field-name');
  return{
    fieldValue
 }
}

and you can access the fieldValue as this.props.fieldValue anywhere in your component

@swp44744 I think you may have also answered my question from #2215 .  Checking now.

@swp44744 how would you access field values that are created by the FieldsArray object.  I haven't yet found a way to do that.

@dcurletti I haven't tried for FieldArray but you can do something like this.
instead of field name in selector pass the FieldArray Name
for example
<FieldArray name="personInfo" component={renderHobbies} />
const fieldArrayValues = selector(state,'personInfo');
your fieldArrayValues should be array of objects. then you can map through array of an object, something like this:
Object.keys(fieldArrayValues).map((fieldArrayItem, index) => {
console.log('field#', index, fieldArrayValues[fieldArrayItem].fieldName);
});
P.S: fieldName is the Field name in your FieldArray. Please also refer to the good documentation on redux form selecting form values:
http://redux-form.com/6.0.0-alpha.11/examples/selectingFormValues/

ok thanks, I'll try that out.

@swp44744, Thanks, that works to get the fields value ... but I would like to get hold of the actual field instance in order to get access to the input inside.
I was considering using refs but that cannot be used with stateless functions.

@swp44744 Thanks for the help.  Unfortunately, that wasn't quite what I was looking for.

I have taken the approach of using the change() function and passing in the field name. Will close the issue.

Just came across this related issue now - https://github.com/erikras/redux-form/issues/1312


Fix Acceptance Tests instructions in Readme

The Google Places Autocomplete mocked object in Readme is missing the setOptions() function, which is present in addon's tests' google-place-autocomplete-object
Hope this helps someone else saving time! 🙂

Hey @algodave!
Thanks a lot for reporting this. I am going to update the README to point to the actual mock.
Best regards,
Daniel.


Improved / more logical drag handling

Addresses the concerns raised in Discord about the visual (non-)representation of the drag and drop operation:

By default drag and drop within the same hierarchy will insert the dragged node below the drop node
A drag to the root branches will insert the dragged node on top of the list, if it's a a top-level node (before it was added to the end)
Visual indicator if you can drop the dragged nodes on the target node

Summary by Sourcery
Enhance the drag and drop functionality by adjusting the insertion logic for dragged nodes and adding visual indicators for drop targets. This improves the logical handling and user experience of drag operations within the application.
Enhancements:

Improve drag and drop handling by inserting dragged nodes below the drop node within the same hierarchy and at the top of the list for root branches if they are top-level nodes.
Add visual indicators to show if dragged nodes can be dropped on the target node, enhancing user feedback during drag operations.

@sourcery-ai review


Not detecting LED of Landis&Gyr ZMB120 meter

Hi
I can't get the sensor to detect the LED of my meter. I set the sensitivity to the lowest possible without triggering on it's own. On another meter of a neighbor it works without problems.  The ZMB120 uses a green LED instead of a red one, can this be a problem?
I already fixed the wrong polarity of the LED as mentioned in #34
Has anyone maybe some possible suggestions how I could get this to work? Different sensor or something?
Many thanks.

Doubt if the color of the led has much influence, mine is orange and works fine.

Just a wild guess. Since the power led on the photodiode sensor is green and seems to be constantly on, may that could confuse the photodiode somehow. Could you try to tape the power led so it won't be visible and leak to the photodiode?

Hello my meter is a Kamstrup as shown on the picture, but same problem, I cannot detect the LED of the meter. I did test my system with another light source and it works. Any adjustments (software or hardware) that can be done?

Just came across your issue as I am going to install one on my Landis Ger. Is the LED really green? I just found one manual stating it would be IR. I will come back to you as soon as I get mine up and running (or not).

Manual: "The test diode is used for testing the meter. It transmits infrared pulses cor-responding to the current measured value. The number of pulses per unittime depends on the meter constant set (according to the inscription on thedial, see also Fig. 3.2) and on the power applied." This is a ZxD120AP. I hope the LED is sub 1000 nm as a photodiode usually has 1000+ nm sensitivity.
Furthermore:
"The infrared test diode on the meter below the LCD should be used formeter testing. This supplies pulses at a frequency dependent on the meterconstant R and the power present, whereby the rising edge is always deci-sive for the test.Note that the digital signal processing provides a delay of 2 seconds be-tween the instantaneous power at the meter and the appearance of thepulses at the test diode. No pulses are lost.The number of pulses per second for the desired power is obtained bymultiplying the meter constant R by the power in kW divided by 3600.Example:    Meter constant R = 1000Power P = 35 kWf-LED = R x P / 3600 = 1000 x 35 / 3600 = 10 imp/sThe test diode is continuously lit at creep."
Enough theory, lets see next wekk what it does...

Ok, checked it. Mine is working perfectly fine. No sensitivity adjustment needed, all working and reading precisely without glitch. Porting it now to a M5Stick with dual sensor to read the aux ZMB of our house.

same problem here with Landis&Gyr  E220 and EHM
with 10000 imp
Used 3 photodiodes. wemos,nodemcu etc  Other light sources work good for detection so the photodiodes seem to work fine.
On the Landis& Gyr e.g. the diode blinks permanently so it receives impulses.


Bump unicode-display_width to 1.2.0 breaks the default behavior of Style/PercentLiteralDelimiters

Steps to reproduce the problem
Use default rubocop config
  rubocop -a test.rb

%i(test) will be converted to %i[test]
RuboCop version
$ rubocop -V
0.48.1 (using Parser <IP_ADDRESS>, running on ruby 2.4.0 x86_64-linux)

The defaults were changed in #4231 to reflect a change in the Style Guide. You can follow the thread over to the Style Guide to see the discussion there. 🙂

@Drenmi Thanks for the information. I forgot that %i: [] in default.yml overwrites the previous default: (), my mistake.


chore: @web3modal/standalone package replaced with @walletconnect/modal

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Type of change.

[ ] FIX - a PR of this type patches a bug.
[ ] FEATURE - a PR of this type introduces a new feature.
[ ] BUILD - a PR of this type introduces build changes.
[ ] CI - a PR of this type introduces CI changes.
[ ] DOCS - a PR of this type introduces DOCS improvement.
[ ] STYLE - a PR of this type introduces style changes.
[ ] REFACTOR - a PR of this type introduces refactoring.
[ ] PERFORMANCE - a PR of this type introduces performance changes.
[ ] TEST - a PR of this type adds more tests.
[x] CHORE - a PR introduces other changes than the specified above.

Since the filtering by chainId is not working properly as it used to, the way to include only wallets that fully support NEAR + WalletConnect was to specifically add them following the WalletConnect docs.
First excluded all wallets then included only specific wallets that we need for now only Opto Will show op in the WalletConnect modal.


Cannot read property 'encoding' of undefined Error

I get the error when i try to create row on database as:
function saveRequestMoneyAndSendNotification(data, callback) {
    var query = "INSERT INTO requestMoney (\
                        requestedUserName ,\
                        requestedEwalletNumber ,\
                        requestedMoney ,\
                        createdAt ,\
                        updatedAt\
                    ) VALUES (?, ?, ? , CURRENT_TIMESTAMP , CURRENT_TIMESTAMP);";
    connection.query(query, [data.fromUsername, data.userEwalletNumber, data.amount], function (err, results) {
        if (err) return callback(false);

        if (results.length === 0) return callback(false);

        callback(true);
    });
}

I check created MySql command on phpmyadmin, that work fine and command is correct, and my connection is:
var connection = mysql.createConnection(
    {
        host              : 'localhost',
        user              : 'root',
        password          : 'a',
        database          : 'shoot',
        charset           : 'utf8_persian_ci',
        multipleStatements: true
    });

Hi @tux-world , I've never seen that error occur before. Do you have a copy of the full stack trace of the error? Or full code I can run to reproduce the issue (I tried to piece together what you provided, but didn't have any errors)?

Hi @tux-world, I hope it's OK if I close this issue, as I haven't heard back in a month. If you can provide some more information, I can always re-open the issue :) !


If symlinks are removed after their target file during a deploy, the deploy fails

For example, I had removed the npm package acorn from a website and attempted to deploy.
The node_modules/acorn/ folder was removed successfully, but the node_module/.bin/acorn symlink, which points to ../acorn/bin/acorn (i.e. node_modules/acorn/bin/acorn) cannot be removed, with the error: Error: ENOENT: no such file or directory, stat '/home/site/wwwroot/stripe-node/node_modules/.bin/acorn' (presumably because the deploy script attempts to follow the symlink rather than checking the link itself).
Workaround was to manually remove the symlink.

@mcdurdin is this targeted for app service on Windows or Linux?

@mcdurdin is this targeted for app service on Windows or Linux?

Linux

According to https://github.com/Azure-App-Service/KuduLite/blob/dev/Kudu.Services/Deployment/PushDeploymentController.cs#L903 there is a WEBSITE_ZIP_PRESERVE_SYMLINKS environmental variable that can be set to properly preserve symlinks in the zipped package. My team is trying this we will report back if/how we got it working.

I've not seen it happening recently but I don't think I have removed any node modules from any websites recently, so that's probably not surprising.

@mcdurdin I will close it then. Feel free to re-open it if you come across the issue again.


Updating k8s to 1.31

Updated k8s dependencies to 1.31

Related to: https://github.com/operator-framework/operator-sdk/issues/6816

@everettraven / @acornett21 / @grokspawn / @zach-source could you help review this PR?

I'm don't have access to this repo, but release for main should be cut before this is merged.

@zach-source can you help create a release for main (based on 1.30 change) so that we can merge this after that?

@grokspawn / @zach-source can you help merge this PR since v0.7.0 is released now.


Remove unused LINUX_DISTRO variable

The variable assignment referenced lsb_release, which doesn't exist in the alpine linux distro.
Fixes #43

thx


Support Markup instances as Safe ones

At a moment there is a way for ludic to avoid escaping any content in a string - by wrapping it into ludic.base:Safe as follows,
from ludic import html as lhtml
from ludic.base import Safe

class SomePage(Component[NoChildren, NoAttrs]):
    @override
    def render(self) -> lhtml.body:
        content = ...  # Generate page content
        return lhtml.body(
           *content,
           lhtml.script(Safe(...), type="text/javascript"),
        )

and it works just fine.
But there is one very popular Python library, MarkupSafe, which provides Markup type and I wonder, whether it possible for ludic to treat those instances as Safe ones and do not attempt to escape them?

I'm asking, cause when I want to render Markdown content wrapped into Markup strings as,
        return PageLayout(
            markdown.markdown(extra["prologue"]),
            *links,
            markdown.markdown(extra["epilogue"]),
            extra_js=(
                lhtml.script(
                    Markup('new AnchorJS().add("h2");'), type="text/javascript"
                ),
            ),
        )

the output, for some reason, looks -->

But when I wrap markdown.markdown(...) calls, which returns Markup instances, into Safe (and change Markup in lhtml.script to Safe),
        return PageLayout(
            Safe(markdown.markdown(extra["prologue"])),
            *links,
            Safe(markdown.markdown(extra["epilogue"])),
            extra_js=(
                lhtml.script(
                    Safe('new AnchorJS().add("h2");'), type="text/javascript"
                ),
            ),
        )

all looks good -->

And I wonder, if it possible for ludic to treat Markup instances (automagically or via specific config) as Safe ones?

Sorry Igor, I just noticed the suggestion of the MarkupSafe library. Let me think, that probably allows a bit different approach.

I need to properly analyse this use case. The reason is that Ludic is already escaping user input, so for example, this is safe to do in Ludic:
from ludic.html import em

p(f"Hello {em(name)}")

It correctly renders while escaping name. The markupsafe library is basically allowing similar thing.
Now I think it should not be needed to use markupsefe at all and still be safe. But that requires making the following work:
from ludic.html import em

markdown(f"Hello {em(name)}")

Which would not work, of course, because python-markdown doesn't know anything about ludic's elements.
I need to analyse what would be the bast way to allow this - whether it is possible at all. Maybe it will involve usage of markupsafe in the end (by creating a Ludic component, something like Markdown that would incorporate all these libraries)

Sorry for not providing full context initially, but my markdown.markdown(...) call from the description has nothing common with mentioned python-markdown library. So let me try once again.

My main request for ludic is: support extra Safe strings, which can have other sources and not only be wrapper as ludic.base:Safe.
Safe string (in my case) passed as children to ludic component as markupsafe:Markup instance, but, if I'll use ludic with Django, it is natural that Django's safe string will be passed as django.utils.safestring:SafeString instances.
And I've run into the issue, which mentioned in the description, when pass following Markup instances to ludic,
@attrs.frozen(kw_only=True)
class Markdown:
    extras: tuple[str, ...] = DEFAULT_MARKDOWN_EXTRAS

    def markdown(self, text: str, /) -> Markup:
        return Markup(markdown2.markdown(text, extras=self.extras).strip())

markdown = Markdown()

class SomePage(Component[NoChildren, SomePageAttrs]):
    @override
    def render(self) -> lhtml.div:
        return lhtml.div(markdown.markdown(...), ...)

So, once again, the focus, from my POV, shouldn't be on python-markdown / markdown2 / any other library, which generates HTML from the text, but rather on:

markupsafe:Markup
django.utils.safestring:SafeString
and so on

And by ensuring that ludic somehow can be configured to understand that if such instance passed as children to component it shouldn't be rendered anyhow, by treating it as safe string.

Hope, that is more clear this time 🙏

ps. And yes, at a moment, I've fixed the original issue and my Markdown class knows which wrapper to use after the markdown2.markdown(...) call, so all good at my side and the issue can be moved to discussion TBH

Thank you for the clarification. I guess my main problem is I don't know how it should be implemented and I have to think about that, I see the following options:

a global configuration variable of "safe" classes - I don't like that because users need to explicitly register the class there. But perhaps it is still a better option than the next two options.
a contrib module with inherited e.g. "SafeString" class for Django which is recognized by ludic. We'd probably end up with a lot of contrib packages which would only contain one class.
hardcoded list of "safe" classes from various libraries - even though it is possible with try: ... except ImportError it doesn't seem especially nice and creates a bit of coupling, we could end up with a huge list of "safe" classes in Ludic. For the users of Ludic, this is probably the best option as they don't really need to do anything and it will work for them.

Do you see any other options? Which one sound the best for you? I guess I'm considering the third option the most. Are there any libraries which use this approach?


feat: initial Starknet support

This PR brings initial support for Starknet into graph-node. The implementation comes from starknet-graph, and has been used in production by the zkLend team for around a year. That said, the support enabled by this PR is not production ready:

Trigger filter is not implemented, and graph-node would always consume the entire Firehose block stream and build all possible triggers. No benchmark has been done yet, but this should hurt performance pretty bad.
Data source templates are not supported. This hasn't been tested yet, but technically graph-node would panic if someone deploys a subgraph with Starknet data source templates defined.
Substream support has not been added (will take inspiration from #4887).

Nevertheless, this PR is submitted here first to kickstart the integration process. Let's bring graph-node's amazing indexing capabilities to Starknet!

Just force pushed the PR branch to breaking changes from #4887. The branch is now up to date again.


invalidateSize()

I'm doing some animations with a map (using velocity.js), I need to change the size of the div and the map should stay centered on the same point. I created a fiddle to illustrate the problem.
https://jsfiddle.net/n236wLcm/
it works nice and smooth for me on chrome but not on firefox or edge, or even qtwebview. I need the animation to be smooth.
during the animation I'm continuously calling invalidateSize(). I dug in the code  and I saw that in the end the invalidate size uses translate to move things.
I don't know if somebody had this type of issue.

I don't think you should be calling invalidateSize that often. Can you throttle it to, say, 100ms? This seems like app-specific issue rather than something that should be fixed on the Leaflet side.

well, there is no way of making invalidateSize with an animation for instance

The leaflet-active-area and Leaflet.ControlledBounds plugins (http://leafletjs.com/plugins.html#events) might help - also, check the code for both to have an idea to how difficult it is to keep things centered. You might need to do some plugin to make your animations work.

thanks


Mauricio/revert docusaurus updates

Revert updates made on #83, #81 as they broke the website build.
It seems I made a mistake while trying it locally and didn't run npm install before.

CI worked for this one, let's go for it to fix the main branch.


Failed to execute goal com.github.github:downloads-maven-plugin:0.6:upload (default) on project github-maven-example:

I was working with sample maven project from eclipse.
on running install, i am getting this error.
clean, build and test commands are working fine.
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.github.kevinsawicki:github-maven-example:jar:0.1-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-javadoc-plugin is missing. @ line 135, column 12
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 115, column 12
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-source-plugin is missing. @ line 146, column 12
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-jar-plugin is missing. @ line 123, column 12
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building GitHub Maven Plugin Example 0.1-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ github-maven-example ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory D:\qasibeat\temp-workspace\git\example\src\main\resources
[INFO]
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ github-maven-example ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ github-maven-example ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory D:\qasibeat\temp-workspace\git\example\src\test\resources
[INFO]
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ github-maven-example ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.10:test (default-test) @ github-maven-example ---
[INFO] Surefire report directory: D:\qasibeat\temp-workspace\git\example\target\surefire-reports

T E S T S
Running com.github.maven.example.tests.WidgetTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 sec
Results :
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-jar-plugin:2.3.2:jar (default-jar) @ github-maven-example ---
[INFO] Building jar: D:\qasibeat\temp-workspace\git\example\target\github-maven-example-0.1-SNAPSHOT.jar
[INFO]
[INFO] --- maven-javadoc-plugin:2.9:jar (default) @ github-maven-example ---
[INFO]
Loading source files for package com.github.maven.example...
Constructing Javadoc information...
Standard Doclet version 1.6.0_39
Building tree for all the packages and classes...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\com/github/maven/example/\Widget.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\com/github/maven/example/\package-frame.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\com/github/maven/example/\package-summary.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\com/github/maven/example/\package-tree.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\constant-values.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\com/github/maven/example/\class-use\Widget.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\com/github/maven/example/\package-use.html...
Building index for all the packages and classes...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\overview-tree.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\index-all.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\deprecated-list.html...
Building index for all classes...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\allclasses-frame.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\allclasses-noframe.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\index.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\help-doc.html...
Generating D:/qasibeat/temp-workspace/git/example/target/apidocs\stylesheet.css...
[INFO] Building jar: D:\qasibeat\temp-workspace\git\example\target\github-maven-example-0.1-SNAPSHOT-javadoc.jar
[INFO]
[INFO] >>> maven-source-plugin:2.2.1:jar (default) @ github-maven-example >>>
[INFO]
[INFO] <<< maven-source-plugin:2.2.1:jar (default) @ github-maven-example <<<
[INFO]
[INFO] --- maven-source-plugin:2.2.1:jar (default) @ github-maven-example ---
[INFO] Building jar: D:\qasibeat\temp-workspace\git\example\target\github-maven-example-0.1-SNAPSHOT-sources.jar
[INFO]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ github-maven-example ---
[INFO] Installing D:\qasibeat\temp-workspace\git\example\target\github-maven-example-0.1-SNAPSHOT.jar to C:\Users\fold.m2\repository\com\github\kevinsawicki\github-maven-example\0.1-SNAPSHOT\github-maven-example-0.1-SNAPSHOT.jar
[INFO] Installing D:\qasibeat\temp-workspace\git\example\pom.xml to C:\Users\fold.m2\repository\com\github\kevinsawicki\github-maven-example\0.1-SNAPSHOT\github-maven-example-0.1-SNAPSHOT.pom
[INFO] Installing D:\qasibeat\temp-workspace\git\example\target\github-maven-example-0.1-SNAPSHOT-javadoc.jar to C:\Users\fold.m2\repository\com\github\kevinsawicki\github-maven-example\0.1-SNAPSHOT\github-maven-example-0.1-SNAPSHOT-javadoc.jar
[INFO] Installing D:\qasibeat\temp-workspace\git\example\target\github-maven-example-0.1-SNAPSHOT-sources.jar to C:\Users\fold.m2\repository\com\github\kevinsawicki\github-maven-example\0.1-SNAPSHOT\github-maven-example-0.1-SNAPSHOT-sources.jar
[INFO]
[INFO] --- downloads-maven-plugin:0.6:upload (default) @ github-maven-example ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.146s
[INFO] Finished at: Wed Jun 19 02:58:57 VET 2013
[INFO] Final Memory: 8M/15M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.github:downloads-maven-plugin:0.6:upload (default) on project github-maven-example: Server 'github' not found in settings -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Please update your demos and examples to not foolish us anymore.
Be clear about this in your main page and remove this plugin from Maven Central.

so what is the solution ?

I was also facing the same issue i just commented the whole plugin part and then it run fine for me .. hope that helps

I find out it just delete the plugin from  in pom.xml