Development Docker Image Bugs: Bashrc error and Incorrect Pipeline Step Base Image

Hi, I would like to run the latest version of the labextension (with the metrics support), but this is not yet available in the NPM repo that stores the extension. I also understand that I need the latest version of the Kale backend in order to to run everything with the metrics feature.
To try this out before the latest version is released and updated in Pip/NPM, I simply built a dev image from Dockerfile.dev, which includes the latest development version of Kale backend and labextension (now in this repo). But there were some issues with the resulting image:

The /etc/bash.bashrc file seems to have some syntax errors that cause issues when opening a terminal in Jupyterlab. Specifically:

bash: /etc/bash.bashrc: line 40: syntax error near unexpected token `elif'
'ash: /etc/bash.bashrc: line 40: `  elif [ -f /etc/bash_completion ]; then

The Kale extension seems to assume a default Kubeflow image (not the custom built kale dev image) in the compiled YAML file. There seems to be a closed issue for this, perhaps I am missing something?

Thanks for this great project. I've tried everything with the gcr.io/arrikto-public/tensorflow-1.14.0-notebook-cpu:kubecon-workshop image and I am beyond impressed with how easy Kale makes it to build KF pipelines.

Hi @TomLaMantia we will release an official version (0.5.0) very soon. We will try to automate this process in order to have more frequent minor releases. In general, if you build the labextension from source, be sure to uses the latest master version of the backend as well.
As for your other points:

I will test the image and get back to you. What system are you running on?
So I a assuming you are compiling the notebook from the labextension. In that case, if you are running inside a Kubeflow Notebook Server, Kale will detect the current Notebook Server image and use that one. Otherwise, you can specify one in the left area in the 'Advanced Settings' area. If none of these apply, then the default Kubeflow image will be used.

Hi @StefanoFioravanzo,
That sounds great, I am looking forward to 0.5.0!
I am running on Ubuntu 18.04 in a MircoK8s cluster - I understand this is a bit limited since it does not come with Rok as MiniKF does, but I am still able to produce compiled YAMLs with Kale under the gcr.io/arrikto-public/tensorflow-1.14.0-notebook-cpu:kubecon-workshop image. I plan on moving to MiniKF soon to take advantage of Rok/RPC and snapshots.
With the image resulting from Dockerfile.dev in the master branch, the compiled YAML assumes the gcr.io/arrikto-public/tensorflow-1.14.0-notebook-cpu:kubecon-workshop image, even though the Kubeflow notebook server was spun up with the image from Dockerfile.dev.  I did not specify anything in the "Advanced Settings" area, so I will try that out.
Thanks for your help :)

I tried to build an image out of  the current version of Dockerfile.dev and it worked, so I am not sure where your bash error comes from.
Regarding the generation of the YAML and assuming you are running the latest version, do you see a warning yellow sign beside the bottom left compilation progress? If the notebook you are using comes already with that image in the metadata, you should be able to see it in the Advanced Settings, as the docker image text field gets pre-filled with what's  in the notebook metadata

@StefanoFioravanzo Okay, I will try rebuilding the image from Dockerfile.dev  again tonight. After specifying the custom image manually in the Kale Advanced Settings area, the resulting YAMLs worked like a charm.
I think we can close this issue now!

@StefanoFioravanzo I should add that the bash issue in the Dockerfile.dev image is not observed at image build time, but rather in the image's terminal. For example, if we use the Dockerfile.dev image to spin up a Kubeflow Jupyter Server, then the bash errors occur in the Jupyter Terminal. I think we can replicate also this issue by opening an interactive terminal from the image: docker run -it <dev-img-tag> /bin/bash.
I suspect that the problem is caused when Windows line endings slip in to the /etc/bash.bashrc file. Perhaps this is carried into /etc/bash.bashrc on line 32 of Dockerfile.dev?


enable proxysql compatibility by updating mysql-otp

Proxysql has a bug, where it changes the reported value of SERVER_STATUS_AUTOCOMMIT just after authentication.
Mysql-otp used to check that the status bits did not change, (all except SERVER_SESSION_STATE_CHANGED) using an assertion (See https://github.com/mysql-otp/mysql-otp/blob/1.3.2/src/mysql_protocol.erl#L75-L76), which crashed connections with proxysql.
I intended to make a quick dirty fix by ignoring that bit change, but looks like the exact same fix was already proposed and merged upstream in commit https://github.com/mysql-otp/mysql-otp/commit/f43adad8e0a50c8f8120c407ec820d35add2f219

I suppose it is better to specify the dep tag rather dep branch in project

We have to fork and tag it, that commit is untagged.

There's a dep hook that forces the commit even in erlang.mk, so we can reproduce the build later. It is in a sense even better than the tag, tags may be force updated.
It doesn't look that neat in erlang.mk though.
What do you prefer? We make a fork, tag it and use it, or we just use the commit locking as I set it up?

Hi, @phanimahesh, your code base is too old and I cannot rebase your code on your own repo. So I open a new pull request here https://github.com/emqx/emqx-auth-mysql/pull/150. Anyway, really appreciate your work and thanks for your contribution. You are a member of the emqx organization, so I suggest you directly create a new branch in emqx repo rather fork it to your own repo. :)

👍


avoid java assert keyword as disabled per default

Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

The 2 failed tests by the camel-management module are not relevant to this PR and fail the same way on the main branch:
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.369 s - in org.apache.camel.management.ManagedThrottlerTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] org.apache.camel.management.ManagedFromRestGetTest.testFromRestModel
[ERROR]   Run 1: ManagedFromRestGetTest.testFromRestModel:67 expected: <true> but was: <false>
[ERROR]   Run 2: ManagedFromRestGetTest.testFromRestModel:67 expected: <true> but was: <false>
[ERROR]   Run 3: ManagedFromRestGetTest.testFromRestModel:67 expected: <true> but was: <false>
[INFO]
[ERROR] org.apache.camel.management.ManagedFromRestPlaceholderTest.testFromRestModelPlaceholder
[ERROR]   Run 1: ManagedFromRestPlaceholderTest.testFromRestModelPlaceholder:68 expected: <true> but was: <false>
[ERROR]   Run 2: ManagedFromRestPlaceholderTest.testFromRestModelPlaceholder:68 expected: <true> but was: <false>
[ERROR]   Run 3: ManagedFromRestPlaceholderTest.testFromRestModelPlaceholder:68 expected: <true> but was: <false>

One last reason for using the native assert instead of ObjectHelper.notNull: the native assert throws an AssertionError instead of an IllegalArgumentException.
As a descendant of Error it properly conveys the abnormality of the condition that raised it (granted: many places try to incorrectly catch Throwable - but that's a completely different discussion).

ObjectHelper is intended for startup/initiaizliation to check if Camel has been configured correctly.
During high speed processing then its not intended to be in use. At that place there can be assert code from JDK that can benefit during trouble shooting / debugging. However we very rarely use assert in the camel source code. So if Otavio have some of them in camel-kafka during his performance improvement work a while back then that is fine to keep.

One last reason for using the native assert instead of ObjectHelper.notNull: the native assert throws an AssertionError instead of an IllegalArgumentException.
As a descendant of Error it properly conveys the abnormality of the condition that raised it (granted: many places try to incorrectly catch Throwable - but that's a completely different discussion).

Thanks for your clarifications. So should I close this PR completely or is there any changes we want to apply? If so which ones?

One last reason for using the native assert instead of ObjectHelper.notNull: the native assert throws an AssertionError instead of an IllegalArgumentException.
As a descendant of Error it properly conveys the abnormality of the condition that raised it (granted: many places try to incorrectly catch Throwable - but that's a completely different discussion).

Thanks for your clarifications. So should I close this PR completely or is there any changes we want to apply? If so which ones?

Thanks! I don't think you need to close the PR. I think removing the ones I mentioned would be enough and then just double checking sure we are not replacing the assert with ObjectHelper in the hot path.

One last reason for using the native assert instead of ObjectHelper.notNull: the native assert throws an AssertionError instead of an IllegalArgumentException.
As a descendant of Error it properly conveys the abnormality of the condition that raised it (granted: many places try to incorrectly catch Throwable - but that's a completely different discussion).

Thanks for your clarifications. So should I close this PR completely or is there any changes we want to apply? If so which ones?

Thanks! I don't think you need to close the PR. I think rolling back the ones I mentioned would be enough and then just double checking to make sure we are not replacing the assert with ObjectHelper in the hot path.

@orpiske sorry for not getting back earlier today, as was much busy with other tasks.
I think in the meanwhile I have applied all your suggestions, so please verify.


Input: New down/up properties

Was thinking that it would be nice to have a few new pressed/released properties which return true when the event occurred during the interval between frames. This should help eliminate some confusion between the 'isDown'/'isUp' properties.

Pointers now contain a 'pressed' and 'released' getter, which returns a boolean indicating if the pointer was pressed or released on the last frame.
This should be useful for quick checks


[OSD-11464] Add gosec linter to CI.

Add .golanci-extras.yml file to test for errors detected by adding the gosec linter.
The linter will be added to boilerplate in the future, so any errors should be removed before then.

Please add a description to the PR including the OSD card, and I'll LGTM this from there.

We can pull this in extra now, to make sure that it is running, and then when we do get around to enabling it by default in boilerplate that's another manual pull we need to make so we can pull it out then.
It also prevents us from making any "breaking" changes in the meantime, in the rare case that we do have to make some kind of change here and we introduce something that would break when we do update boilerplate.
Overall, it's a little extra work later but it's the generally "safer" route.
/lgtm

/lgtm

/approve


add option to set inscription destination

Split just this feature out of #1512

@casey feedback addressed when you have time to take another look :)


Meta: should we have labels for FFE and the design system?

We're starting to see some open issues for design.sparebank1.no as well as FFE. Would it be helpful to add an :rocket: ffe and a :dizzy:  design system label (emojis pending) to help see at a glance which of the two the issue is about?

Cool by me!

Agreed.

I'll fix!


Crash on NetworkConnectivityChecker.checkConnectivity

Device info:
iPhone 13
iOS 16.0.0
crash_info_entry_0
BUG IN CLIENT OF LIBDISPATCH: Unbalanced call to dispatch_group_leave()

Log

Crashed: com.apple.NSURLSession-delegate
0  libdispatch.dylib              0x3a5ac dispatch_group_leave.cold.1 + 36
1  libdispatch.dylib              0x4e30 _dispatch_group_wake + 130
2  myapp                   0x7e0064 closure #1 in closure #1 in NetworkConnectivityChecker.checkConnectivity() + 35 (NetworkConnectivityChecker.swift:35)
3  myapp                   0x7e0a88 partial apply for closure #1 in closure #1 in NetworkConnectivityChecker.checkConnectivity() + 2280632 (:2280632)
4  myapp                   0x7e3b78 thunk for @escaping @callee_guaranteed (@guaranteed Data?, @guaranteed NSURLResponse?, @guaranteed Error?) -> () + 2293160 (:2293160)
5  CFNetwork                      0x1fd1c CFURLRequestSetMainDocumentURL + 2972
6  CFNetwork                      0x2fc40 _CFNetworkErrorCopyLocalizedDescriptionWithHostname + 13484
7  libdispatch.dylib              0x24b4 _dispatch_call_block_and_release + 32
8  libdispatch.dylib              0x3fdc _dispatch_client_callout + 20
9  libdispatch.dylib              0xb694 _dispatch_lane_serial_drain + 672
10 libdispatch.dylib              0xc214 _dispatch_lane_invoke + 436
11 libdispatch.dylib              0x16e10 _dispatch_workloop_worker_thread + 652
12 libsystem_pthread.dylib        0xdf8 _pthread_wqthread + 288
13 libsystem_pthread.dylib        0xb98 start_wqthread + 8

Device info:
iPad (6th generation) (Model A1893)
iOS 16.4
IterableSDK: closure #1 in closure #1 in NetworkConnectivityChecker.checkConnectivity() + 160


ajax xhr track upload progress not working

Hi, I was using:
xhr: function() {
                var myXhr = $.ajaxSettings.xhr();
                if(myXhr.upload){
                    myXhr.upload.addEventListener('progress',progress, false);
                }

                return myXhr;
        }

to track upload status and update a progress bar, but that's with jQuery $.ajax, but after changing to F7 $$.ajax, it is not working anymore.
am i missing something?

It should be:
var xhr = $$.ajax(...);
xhr.addEventListener('progress', progress, false);


SIL: no need for BRIDGED_... macros in SILNodes.def

It's not needed to distinguish between bridged and not bridged node classes in SILNodes.def.
This change is a NFC.

@swift-ci smoke test


Fix send() ouput

Sending in dict instead of json format

Coverage remained the same at 95.432% when pulling 9821ae9896d2f4d3d1bbb59b41c0791eb932388f on develop into 2664a4e58c3fd68e1a1073ddf9a918146398dc44 on master.


Fix/dependencies

PR to add dependencies fix to next versions 1.0.1.
Following the release process, since it is a fix, we would like to merge it into the same branch 1.0!

I changed the base branch. It is now release/1.0 (without the prefix v).
It contains all the fixes, including the fixes on the GitHub actions.


Add a "newsletter" view and add link below "about us" (below the logo on "main view")

Back-end (Yassine)

Save e-mails in the back-end

Front-end (Oscar)

When entering subscribe give a message that we received the e-mail adress and will get back as soon as there is something new.

@Ozcino please do it as correct as possible for the CSS. I know its a pain, but we don't have time to reiterate tomorrow.

Please also add Locale app integration to this :)

@Ozcino please do a commit when you have had time to do this :smile:

@superyass I just checked with @Ozcino and he is almost done, you can take over now and develop the connection to back-end 😄

branch = Feature/newsletter


＄Sign up for GitHub Sponsors ＄

fcp has made a lot of daily chores much faster, especially with Thunderbolt 3 (2.6GBps) and Apple Silicon internal gen4 SSD drives.
Please consider joining https://github.com/sponsors ‼

Please <3 <3 <3


Connection to my own server doesn't work

Summary
I'm trying the Demo application against my own VPN server, but it won't connect because of "unknown protocol" error, this is from the server log:
Jul 18 14:36:18 vpn.tuxed.net openvpn[26865]: 91.64.X.Y OpenSSL: error:140760FC:SSL routines:SSL23_GET_CLIENT_HELLO:unknown protocol
Initially my server had:
tls-cipher TLS-ECDHE-RSA-WITH-AES-256-GCM-SHA384
tls-version-min 1.2

Removing those configuration lines doesn't help, but even with those I expect the Demo app to connect after a quick review of PIATunnel/Sources/Core/TLSBox.m.
Is there anything required in the server configuration to make connections work?

The branch I'm working from: https://github.com/fkooman/tunnel-apple/tree/tuxed

@fkooman where you see this line:
https://github.com/fkooman/tunnel-apple/blob/tuxed/Demo/BasicTunnel-iOS/ViewController.swift#L137
you should replace .pia with .vanilla to stick with the standard OpenVPN protocol. I think I forgot to update the README accordingly.
Let me know if it fixes your issue.

FYI: introduced in #28 and #30.

Thanks for your help! I moved on to the next error ;-)
Jul 19 16:47:55 vpn.tuxed.net openvpn[30618]: WRRWWWRWRRRR<IP_ADDRESS> OpenSSL: error:14094418:SSL routines:ssl3_read_bytes:tlsv1 alert unknown ca
Jul 19 16:47:55 vpn.tuxed.net openvpn[30618]: <IP_ADDRESS> OpenSSL: error:140940E5:SSL routines:ssl3_read_bytes:ssl handshake failure

This would indicate that there is an attempt to send a client certificate by PIA, but it fails? I was under the impression that client certificates were (not yet) supported, that is what I wanted to look into :)
If I try with OpenVPN with a client configuration without <cert> and <key> and user user/pass authentication it does work with this server.
If I modify something in the PIATunnel project, e.g. TLSBox.m, do I need to run pod installorpod update` in the Demo directory again to get the changes? I'm still trying to get the hang of Xcode :-)

@fkooman client certificates are a different thing, this relates to the CA alerted by the server -at least based on the error message. The default Handshake enum values are all bound to the bundled PIA certificates, you must provide your own CA instead.
I see you patched the enum, but I introduced in #31 a way to avoid replacing the bundled PEM files. Again, the README needs updating. Try this:
builder.handshake = .custom
builder.ca = "your-ca-pem-as-a-string"


Deprecate this page.

This page is always outdated, and is not adding any value. The packages list can be found from Nuget.org directly or following any other docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: abbbc531-55a4-d477-b6a0-a848dc521537
Version Independent ID: 233ca0f7-f08d-33f7-2a82-df5cc30215dc
Content: Azure Monitor Application Insights NuGet packages - Azure Monitor
Content Source: articles/azure-monitor/app/nuget.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@cijothomas Thank you for bringing this to notice, assigning this issue to @mrbullwinkle to further evaluate and deprecate the page as needed.

This page has been retired.

#please-close


[WIP] add UDS support

This PR adds support for submission of custom metrics through a Unix Socket on Linux.
See https://github.com/DataDog/datadog-agent/wiki/Unix-Domain-Sockets-support for context and benefits.
Implementation details:

no change in the public API, UDS mode is triggered by setting 0 as port, the socket path as hostname
the send timeout is set at 100ms. It only triggers if dogstatsd is overloaded/frozen and the socket buffer is full. The equivalent in UDP is a full reception buffer, triggering a silent packet drop
the default behaviour of the library is to ignore all exceptions, but a custom handler can be passed. Documented the expected exceptions and their meaning

Testing

Reduced the parallelism of NonBlockingStatsDClientPerfTest (from 20 to 10) to reduce flakes on Travis
Added the UnixSocketTest test class to test good transmission + error handling and recovery

Windows
The feature is Linux only, and requires an external jnr.unixsocket JNI library. This library provides NOOP stubs for unsupported OSes, so the library still compiles and operates in UDS mode with no dark magic.
Tests pass on windows, all of the UnixSocketTest class is ignored of course. As with Linux, the NonBlockingStatsDClientPerfTest test is still a bit flaky.
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.timgroup.statsd.EventTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec
Running com.timgroup.statsd.NonBlockingStatsDClientPerfTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.172 sec
Running com.timgroup.statsd.NonBlockingStatsDClientTest
Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.703 sec
Running com.timgroup.statsd.UnixSocketTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec

Results :

Tests run: 51, Failures: 0, Errors: 0, Skipped: 1

Hi @xvello @masci, any ETA on when this can be merged?

Hello @erks,
The code is manually tested and ready for code review, I need to work on the unit testing before merging it. As we are currently focusing on the 6.2.0 release, I hope I'll be able to return to it in 2 weeks.
In the meantime, feedback on the PR and testing with your use case would be greatly appreciated.

@nmuesch @masci Tests are green and documentation is updated,
@erks Did you have time to test the branch yet?

@xvello No, I did not, unfortunately.

Any update on this PR? Exciting feature!

Hey, apologies for the delay. Having a look at this today! Thanks for the improvements!!


Remove BYFN tutorial (deprecated).

Signed-off-by: Chris Gabriel<EMAIL_ADDRESS>Prepare docs for BYFN deprecation.
Type of change

Documentation update

Description
BYFN to be deprecated, but leave link reference for now so users will continue to have functional bookmark.

Should BYFN be removed from the table of contents as well? it can still find the page if it is bookmarked, but it will not show up in the tutorials list.

There is still a mis-format the file should look like this:
Building Your First Network
===========================

.. note:: The Build your first network (BYFN) tutorial has been removed.
   If you are getting started with Hyperledger Fabric and would like to deploy
   a basic network, see :doc:`test_network`. If you are deploying Fabric
   in production, see the guide for :doc:`deployment_guide_overview`.

   You can still find the BYFN tutorial in earlier Fabric documentation versions:
   - `Fabric 2.1 <https://hyperledger-fabric.readthedocs.io/en/release-2.1/build_network.html>`_
   - `Fabric 1.4 <https://hyperledger-fabric.readthedocs.io/en/release-1.4/build_network.html>`_

.. Licensed under Creative Commons Attribution 4.0 International License
   https://creativecommons.org/licenses/by/4.0/

We merged this through another PR as there was a merge conflict on your branch and it was really ugly to fix for some reason


Replace Terminology / CodeSet selector

In a codeset, when adding a new term from a terminology, and when selecting a model for a model reference data type, there's a search-as-you-type dropdown which currently doesn't work - perhaps due to pagination issues.
It might be better to replace these (and any similar) with the same tree-view model selector that's used in other places.
An added bonus would be that if you're choosing a term for a codeset, it auto-selects the terminology that other terms are taken from.

@jamesrwelch For a start I have fixed the current implementation, the search was failing due to incorrect parameters being sent. Is this enough, or would you prefer the UI to change as requested?


confused abour svdnet

@hsfzxjy
Hi, I'm curious about what you implement in svdnet.
In this code,  https://github.com/hsfzxjy/svdnet-pytorch/blob/master/train_svdnet_xent.py#L62-L84. I notice you do some normalization and I'm confused about it.
Can you explain it?

Well, it's a direct translation from the official MATLAB code. It seems to be some unpublished tricks. The link above has more detailed comments.


Target named "TestHelpers" conflict with "swift-se0270-range-set" unit-test target

As title mentioned

Hi @dehengxu — I'm having trouble reproducing this error. Could you say more about what you're trying to do when you run into this?

Hi @dehengxu — I'm having trouble reproducing this error. Could you say more about what you're trying to do when you run into this?

I use packages  ArgumentParser and swift-se0270-range-set which both have TestHelpers target


ignoreUrlParametersMatching seems to be not working

Library Affected:
workbox-precaching
Browser & Platform:
All browsers.
Issue:
I am using workbox 4.0.0 and have a gulp task that uses injectManifest method of workbox-build - and the source/template file for service-worker (swSrc) has this block in it:
workbox.precaching.precacheAndRoute(
    [],
    {
        ignoreUrlParametersMatching: [/.*/]
    });

This is getting updated correctly to become the built service-worker (swDest) that looks like this:
workbox.precaching.precacheAndRoute([
  {
    "url": "style.css",
    "revision": "0ba0898e1a16d9f6eeec49041da47e79"
  },
  {
    "url": "script.js",
    "revision": "e8387f082ead450d27fa5c2865ad0eec"
  },
  // ...many more such files
],
    {
        ignoreUrlParametersMatching: [/.*/]
    });

But precaching does not match a request in this form: http://localhost:8080/style.css?v4.7.0
While debugging with breakpoints set within the addRoute method within workbox-precaching.dev.js, it looks like ignoreURLParametersMatching there still has the default value specified there: [/^utm_/]
What is interesting is, the precacheAndRoute function that calls the addRoute function itself seems to have the right value on the options object.
Could someone point out what I could be doing wrong?

Looks like it is case of case mismatch - the documentation has the parameter specified as ignoreUrlParametersMatching (which is where I copy-pasted from) - and the addRoute function now has it as ignoreURLParametersMatching
Is there a way I can send a PR to update the documentation?

Thanks for pointing this out—it's fixed in https://github.com/google/WebFundamentals/pull/7350


Rollup of opportunity contact role

Hello,
I am trying to create a rollup on the opportunity to count the number of contact roles a certain type that have been assigned. I get an error when I deploy the trigger stating that the object does not support triggers. I get the same error if I attempt to use scheduled mode.
I understand that opportunity contact roles do not support triggers, but shouldn't scheduled mode still be possible?
Many thanks for your wonderful tool.
Jonathon

Are we able to Rollup of opportunity contact role now?

That object doesn't support triggers :(
On Jul 11, 2017 4:31 PM, "Tena Wolver"<EMAIL_ADDRESS>wrote:

Are we able to Rollup of opportunity contact role now?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/afawcett/declarative-lookup-rollup-summaries/issues/59#issuecomment-314600529,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APXKqnx6Kcjgy3jiaOJQt2FEpvmRorOzks5sNAXCgaJpZM4CY-e-
.

Thanks for confirming that.


Add license header to every file

This PR mainly adds the license header to every file.
cc @radare @XVilka @crowell

I think theres a oneliner version of this comment

On 07 Sep 2015, at 21:52, Sushant Dinesh<EMAIL_ADDRESS>wrote:
This PR mainly adds the license header to every file.
cc @radare @XVilka @crowell
You can view, comment on, or merge this pull request online at:
https://github.com/radare/radeco-lib/pull/17
Commit Summary
Fixes an issue with constant propagation
Merge branch 'master' of github.com:radare/radeco-lib
Adds License header to files
File Changes
M src/analysis/constant_propagation/constant.rs (35)
M src/analysis/constant_propagation/mod.rs (7)
M src/analysis/dom/domtree.rs (7)
M src/analysis/dom/index.rs (7)
M src/analysis/dom/mod.rs (7)
M src/analysis/mod.rs (7)
M src/analysis/propagate/control.rs (7)
M src/analysis/propagate/data.rs (7)
M src/analysis/propagate/mod.rs     (7)
M src/analysis/valueset/knownbits.rs (7)
M src/analysis/valueset/math/mod.rs (7)
M src/analysis/valueset/math/test.rs (7)
M src/analysis/valueset/mod.rs (7)
M src/analysis/valueset/sintmultiple.rs (7)
M src/analysis/valueset/sintrange.rs (7)
M src/analysis/valueset/test.rs (7)
M src/analysis/valueset/uintmultiple.rs (7)
M src/analysis/valueset/uintrange.rs (7)
M src/backend/lang_c/mod.rs (7)
M src/backend/mod.rs (7)
M src/backend/scf/dream.rs (7)
M src/backend/scf/mod.rs (7)
M src/bin/cfg_dom.rs (7)
M src/bin/cfg_ssa.rs (7)
M src/frontend/esilssa.rs (11)
M src/frontend/mod.rs (7)
M src/frontend/parser.rs (7)
M src/frontend/r2.rs (7)
M src/frontend/structs.rs (7)
M src/lib.rs (7)
M src/middle/cfg.rs (7)
M src/middle/dce.rs (9)
M src/middle/display.rs (7)
M src/middle/dot.rs (7)
M src/middle/ir.rs (7)
M src/middle/mod.rs (7)
M src/middle/phiplacement.rs (9)
M src/middle/regfile.rs (7)
M src/middle/ssa/cfg_traits.rs (7)
M src/middle/ssa/error.rs (7)
M src/middle/ssa/mod.rs (7)
M src/middle/ssa/ssa_traits.rs (9)
M src/middle/ssa/ssadot.rs (7)
M src/middle/ssa/ssaquote.rs (7)
M src/middle/ssa/ssastorage.rs (15)
M src/middle/ssa/verifier.rs (7)
M src/utils/mod.rs (7)
M tests/lib.rs (45)
M tests/test1.rs (7)
Patch Links:
https://github.com/radare/radeco-lib/pull/17.patch
https://github.com/radare/radeco-lib/pull/17.diff
—
Reply to this email directly or view it on GitHub.

I'm not aware of the one-liner version. I copied this from the Rust guys.

Merge it, we can shrink it later

On 08 Sep 2015, at 11:20, Sushant Dinesh<EMAIL_ADDRESS>wrote:
I'm not aware of the one-liner version. I copied this from the Rust guys.
—
Reply to this email directly or view it on GitHub.


Bustaim prints console errors (Weapon ID seems to be invalid)

[22:35:07] [debug] #0 0003aff4 in OnPlayerWeaponShot (playerid=0, weaponid=128, hittype=96, hitid=46295, Float:fX=1631428965014962200.00000, Float:fY=0.00000, Float:fZ=0.00000, ... <1073741816 arguments>) at C:\Users\sondr\git\lsrcr/pawno/include\bustaim.inc:251 [22:35:07] [debug] #1 0000aeb4 in public OnPlayerWeaponShot (... <7 arguments>) at C:\Users\sondr\git\lsrcr/pawno/include\YSI\YSI\..\YSI_Coding\..\YSI_Internal\y_cgen.inc:32 [22:35:07] [debug] Run time error 4: "Array index out of bounds"
I am not entirely sure what it was caused by, but it could very well be because of a cheater. When it occured we had a cheater in-game, not sure what he was doing though, but he was autobanned a bit later for flying cheats. I have also noticed the errors before, hence why I am reporting them, don't think it's a really big issue though as they are very rare.

https://github.com/YashasSamaga/BustAim-AntiAimbot/blob/master/BustAim.inc#L249-L278
That code should've actually prevented it. Check if you are using an older version of the include.

I forgot about this, sorry for leaving the issue open. You were probably right as I have not seen the errors again.


Docs

Adds doc strings extracted from C++ code to most objects.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 29 (89.66%)  changed or added relevant lines in 3 files are covered.
14 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-7.7%) to 87.379%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pyhepmc/view.py
22
25
88.0%

Files with Coverage Reduction
New Missed Lines
%

src/pyhepmc/view.py
2
90.36%

src/pyhepmc/_deprecated.py
12
0%

Totals

Change from base Build<PHONE_NUMBER>:
-7.7%

Covered Lines:
180

Relevant Lines:
206

💛  - Coveralls


[FLINK-5699] [savepoints] Check target dir when cancelling with savepoint

When cancelling a job with a savepoint and no savepoint directory is configured, triggering the savepoint fails with an NPE. This is then returned to the user as the root cause.
Instead of simply forwarding the argument (which is possibly null), we check it for null and return a IllegalStateException with a meaningful message.

Build failures are unrelated in change is self-contained. Merging this to master and release-1.2.


Journey edits

Journey copy edits & assorted fixes.
Changes

Change Explore loan options to Explore loan choices in nav
Change step section title Pitfalls to avoid to How to avoid pitfalls
Add .content-l_col-1 class to .step-content when there is no key_tool to ensure correct margins (fixes GHE 1086)
Fix issues with Action steps section on smaller screens:

add grid_column behaviour between 600 & 799px
add top margin below 800px

Review
@cfarm @amymok @stephanieosan @mthibos
Screenshots
Explore phase title change in nav:

Pitfalls section title change:

Fixed indentation on step content:

Action steps on medium screens, before:

Action steps on medium screens, after:

Action steps on small screens, before:

Action steps on small screens, after:

Notes

The phase names are hardcoded in the nav, but they're pulled from WordPress for the page titles, so I also updated the Explore phase in WP on build.

Checklist

[x] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Visually tested in supported browsers and devices

Windows 7

[x] IE 11
[x] IE 10
[x] IE 9
[x] IE 8
[x] latest Chrome
[x] latest Firefox

Mac

[x] latest Chrome
[x] latest Firefox
[x] latest Safari

Mobile

[x] latest iPhone
[x] latest iPad

@virginiacc  Looks good, not sure how the code works so did you remember to change the Explore loan choices name in the bottom nav as well as the top nav?

@mthibos They share the same code, so it should be updated in both places.

:+1:

Anyone have an idea of why this is failing? It seems like everything runs correctly, and then coveralls throws an error. @fna @amymok @cfarm

This happened on another pr last week, but once we merged to master it was fine. https://travis-ci.org/cfpb/owning-a-home/builds/75110271
I don't know the cause of this though.

code looks good so I'ma merge


Transfer/Move Tutor

Transfer and Move Tutor names keep switching back and forth. Small bug, but thought it should be known.

The NPC also changes skins too to add.

They also do not keep any moves/prices saved. They get reset once you exit out of their edit mode.

This is a known Pixelmon issue, it's been forwarded to the tracker: https://www.pixelmonmod.com/tracker.php?p=2.


TLS Cipher 2a: tickets: use PSA for protection

In ssl_ticket.c, use psa_aead instead of mbedtls_cipher in order to protect tickets when MBEDTLS_USE_PSA_CRYPTO is enabled.

[ ] In struct mbedtls_ssl_ticket_key replace* the cipher context with two fields with types mbedtls_svc_key_id_t and psa_algorithm_t, and adapt mbedtls_ssl_ticket_free() accordingly.
[ ] In ssl_ticket_gen_key(), set appropriate attributes (will need to use the algorithm now stored in the context) and import the the random bytes with psa_import_key(). (Compared to using psa_generate_key(), this allows for better code sharing between PSA and non-PSA, and is also preferable if we even want to enable PSA builds without ENTROPY_C, see https://github.com/ARMmbed/mbedtls/issues/5156#issuecomment-984662340)
[ ] In mbedtls_ssl_ticket_setup(), translate the cipher to the appropriate algorithm using the utility function created in #5182  and store that in the context before calling ssl_ticket_gen_key() - the calls to mbedtls_cipher_setup() don't make sense with PSA and can be simply removed.
[ ] In mbedtls_ssl_ticket_write(), instead of mbedtls_cipher_auth_encrypt_ext() call psa_aead_encrypt().
[ ] In mbedtls_ssl_ticket_parse(), instead of mbedtls_cipher_auth_decrypt_ext() call psa_aead_decrypt().

*Note: this describes the final result; in terms of execution, it may be desirable to first add the new fields (keeping the existing ones), then modify the functions gradually, and finally remove the old fields when MBEDTLS_USE_PSA_CRYPTO is enabled.
Depends on: #5181 for tests, #5182 for translation function.

This task should wait until #5501 has been merged, so that the new call to mbedtls_cipher_setkey() that it introduces can be handled as well.

Removing "needs: preceding PR" as #5501 has been merged.


Update OpenStack Logo

OpenStack has a new logo, please update - thanks!

Thanks @resker will refresh in upcoming version

Thanks @resker, closing as this update was included in the most recent version https://github.com/cncf/landscape#current-version


Migrate:safe not creating indexes (unique) on first launch in production environment

Node version: "v10.15.2"
Sails version (sails): "1.2.3"
ORM hook version (sails-hook-orm): "2.1.1"
Sockets hook version (sails-hook-sockets): "1.5.5"
Organics hook version (sails-hook-organics): -
Grunt hook version (sails-hook-grunt): "3.1.1"
Uploads hook version (sails-hook-uploads): -
DB adapter & version (e.g. sails-mysql@5.55.5): "sails-mongo": "^1.0.1"

Hi Everyone,
I ran into an issue today, I deployed an API into production (with docker) for the first time (on an empty database) and my users could register twice (or more) with the same email, even though I set it to 'unique: true' in my User model.
After some research, I discovered that "migrate: safe" in production also means that it's NEVER going to create indexes or constraint, even on the first launch when database is not even created !
I also discovered that it's impossible to set migrate to alter in production (which I understand).
This is very confusing because everyone expect the database to be correctly setup on first launch ! Especially when it's working in development environment !
The worst part is that it's not even yelling at you in any way. It's like everything is working perfectly fine except not.
In my opinion, it should either be written in bold capital letters in the documentation or fixed.
What do you think ?

Hi, @25matt12, thanks for the feedback!
I'm going to stick a label on this issue requesting additional feedback from the Sails community at large re: the documentation pertaining to migrate: 'safe'. Is there a widespread desire for more explicit documentation here? We'd love to hear from y'all!

@25matt12 with migrate: 'safe', are the db tables & columns created but not constraints?

Hi, @25matt12!
Regarding your issue itself, the behavior you described is expected. In a situation where, say, you were using an existing database with a new Sails app, we wouldn't want to assume that it was okay to wipe all your data!
To set up a shiny new production database, you can lift your Sails app locally with --drop while connected to the production database. That would look something like this (all on one line):
sails_datastores__default__adapter=sails-mongo sails_datastores__default__url='mongodb://heroku_12345678:random_password@ds029017.mLab.com:29017/heroku_12345678' sails lift --drop
If you do this, proceed with caution, as it will wipe the database. This approach is only recommended for first-time setup.

Hi @madisonhicks,
Thanks for the tips, I'll make sure to do that next time I deploy sails into production!


Support builds with existing libcrypto

This change allows users to build s2n with an arbitrary
libcrypto. Users should supply their install directory
in the "LIBCRYPTO_ROOT" environment variable before
building s2n.
closes #77

[soco@/workplace/s2n]% LIBCRYPTO_ROOT=/usr make
...
\033[1m Compiled with OpenSSL 1.0.1k-fips 8 Jan 2015. \033[0;39m


Unable to get data from SQl Server please share me some code for reference

QAF Version

Note: only the latest version is supported

Steps To Reproduce
@QAFDataProvider(sqlQuery="Select top 1 SALESID,COMPID from SaleTable where SalesStatus = '4' and SALESID like 'Sale'")
@QAFTestStep(description="I search order {0}")
public void iSearchOrder(Map <String, String> data) throws ClassNotFoundException
{
	String getOrdernUmber=data.get("**SALESID**");
	System.out.println(getOrdernUmber + "*****************");
	String getcompanyId =data.get("**COMPID**");

}

And also used application properties
db.driver.class=com.microsoft.sqlserver.jdbc.SQLServerDriver
db.connection.url=jdbc:sqlserver://TSTData-DB.*:
db.user=*****
db.pwd=*****
Expected behavior
Please let me is it rgt way to use or not
Actual behavior
Is the issue reproducible on runner?

[x] QAS
[ ] Maven
[ ] Gradle
[x] Ant
[ ] Eclipse

Test case sample

Please, share the test case (as small as possible) which shows the issue

Data provider is used with test case not with test step. @QAFDataProvider annotation is used to define data provider for test written in java.  Refer documentation for example.
It is recommended to post questions with details (your current configuration, relevant code, execution logs, etc) in users group or in stack-overflow with qaf tag.


Picam can be not used in Hyperion.ng with both of pi zero W and Pi 3B+

[x] I confirm that this is an issue rather than a question.

Bug report
Picam can be not used in Hyperion.ng with both of rpi zero W and Pi 3B+
Steps to reproduce
What is expected?
rpi can detect and grabber via Picam module
What is actually happening?
rpi just detect module name "camera 0" then can not grabber it, there is not any chooses for it
System

Hyperion Server:

Build time:  Jun 29 2020 12:45:45
Version:     2.0.0-alpha.6
UI Lang:     auto (BrowserLang: en-CA)
UI Access:   default
Avail Capt:  dispmanx,v4l2,framebuffer,qt

Hyperion Server OS:

Distribution: Raspbian GNU/Linux 10 (buster)
Arch:         arm
Kernel:       linux (4.19.118+ (WS: 32))
Browser:      Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36

So what's the solution here, since it was closed??


[ll] Port dx12ll to dx12

Overview

Port over (most/all) parts of the old dx12ll backend to the dx12 backend
Remove dx12ll backend
Implement first parts of hidden descriptor heaps for dx12 using a free-list allocator (deallocation missing)
Allow descriptor sets to be mixed (srv/cbv/uav and samplers), but will split internally and requires up to 2x more root signature slots.

TODO

Pipeline barriers support is pretty basic atm, but it needs more love in general in core
Renderpasses also only ported over and missing large chunks of functionality
Descriptor pool deallocation
Some functions haven't been implemented so far (including destruction calls), only trying to get quad running atm (and it works when manually specifiying the barriers),

bors r+

bors r+

I'd recommend increasing timeout limit https://github.com/amethyst/amethyst/blob/develop/bors.toml#L20

Huge OSX backlog, as always :(


Stops the creation of _build and _logs directories if CMakeLists.txt is not found

This provides a better user experience for new users who run the tool outside of a CMake source tree, who would later have to clean up those directories.

I should have created the change in a different change in my fork such that I can create other pull requests on other branches. I am closing this pull request to reopen in a different one as I don't seem to be able to edit the branch of this one.


Add information about patterns search order to the doc about structuring repo

Following this issue I think we should add a note about the order of patterns that is used to find splits, see my comment. Also we should reference this page in pages about packaged loaders.
I have a déjà vu that it had already been discussed as some point but I don't remember....

Good idea, I think I've seen this a couple of times before too on the forums. I can work on this :)

Closed in #5693


Support React@18

Describe the bug
I'm currently using React 18 in my project and I'm having issues when I try to install this package because of the react version specified in https://github.com/storybookjs/testing-react/blob/d22cb1c397f273c382aff7920d7d97147d415f83/package.json#L81
Is there anything I can do to help? I suppose I can open a PR to update the peerDeps, but I'm not familiar with the project so I don't know if that fix is going to be "that simple"
To Reproduce
Steps to reproduce the behavior:
I can create a repo to reproduce this later today if that's helpful.
Expected behavior
I can install the library
Screenshots

Additional context
Add any other context about the problem here.

Just opened this, https://github.com/storybookjs/testing-react/pull/100 I'm not sure if that's enough!

Any idea when this change will be released?

Any idea when this change will be released?

Would like to know too!

Hey everyone! Sorry about this, the PR was not labeled correctly before getting merged. This should be out now in 1.3.0!


Make it impossible to forget calling init_heap and initialize before using esp-wifi

It's absolutely necessary to call the mentioned functions so we need to make sure the user can't forget about it

Also, the call to initialize the heap should be done internally in initialize - I think it's like this for historic reasons (for a couple of days we used a global allocator)


Update download-and-install-the-skype-for-business-online-connector.md

Added installation of TPM

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


M1 AMX

The PR contains a revised M1-AMX kernel generation doing C+=A*B^T

Supports FP16, FP32, FP64.
Supports generic block sizes in the micro-kernel (multiples of vec-length).
Supports leading dimensions not matching M, N, K.
Supports wrapping one micro-kernel config for FP16, FP32 and FP64 respectively. This allows for multiples of 64 in M; 32 (FP16) or 16 (FP32) or 8 (FP64) for N and arbitrary K.

Is there anything in particular blocking this PR?

Myabe cause AMX of Apple has nothing to do with Intel AMX?


"center camera at x , y" is misleading  - places at visable upper left

scene: center camera at x _ y _  doesn't center the camera but places the visible screen upper left at the designated x, y.
If this is the desired behavior then perhaps a change of wording - such as:
scene: place camera screen at x _ y _

Yep, noticed this the other day too. Definitely a bug, it should center not do top left (that is we should not reword the block, just fix the implementation)


Misc fixes

+1 for this PR, as I also notice the issue with variables not being explicitly declared in this version.

@samuei Ahh. Thanks for your prod because I don't see notifications otherwise. I've been making changes to this project over the past few months but not committing them. Oops. I hadn't been aware that anyone else was even bothered to use this project.
I'll accept these updates and then merge with the other changes I've been making.


in get_structured_config_data: check for dict subclass data

Closes #584
TODO:

[ ] add a test case to test_errors.py for the new try: ... except ValidationError: ... code path.

make sure your todo is addressed (in the bug description).
Consider adding a bugfix news fragment (if this is a bug in 2.0).

Should be ready to go :)


papertrail can no longer send logs to s3

Just had this email:
"""
We're emailing to let you know that Papertrail's access to your S3 bucket has been removed. Papertrail has been consistently receiving an Access Denied message from AWS for the past 11 attempts.
Usually this means a security policy was unintentionally removed or changed. If this is intentional, please feel free to ignore this message.
If this isn't intentional, please feel free to re-enable your S3 bucket here. As part of saving the bucket, Papertrail will verify access.
We're at your service if I can answer any questions. Warm regards,
Papertrail
"""
Looks like something revoked access (unintentionally). I bet it was some changes I made in terraform.

papertrail alledges it's now working.


Add support for webpack2 loader options. Fixes #115. Fixes #128.

No tests were added since it will require webpack2. However we can't still move to webpack2 since it is currently in beta.
Tested against initial tests and also locally against support for less-loader webpack2 options param.

hey, webpack2 released. Could you pls review this PR and merge if it's ok?

Thank your for your PR 👍, but this has been superseded by https://github.com/webpack/loader-utils/issues/56 and https://github.com/webpack-contrib/less-loader/pull/147/files


az webapp deployment for run-from-package when other methods say az webapp deploy --src-path

When it come to Microsoft created products or the documentation it is not clear why there is az webapp deployment source config-zip  and az webapp deploy --src-path and the first is used with run from package and the other is given in examples of zip deploy. But considering this is microsoft it could very well be that there is a hidden "feature" that this works only with those specific methods. When Microsoft finds extra work to fix something, they add one more command with a new name.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a7838171-5cab-d164-cc88-2973c0d0e56e
Version Independent ID: d888bc9c-c031-f67c-d5a0-25cc265f14e3
Content: Run your app from a ZIP package - Azure App Service
Content Source: articles/app-service/deploy-run-package.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@sijucm
Thanks for your feedback! We will investigate and update as appropriate.

@sijucm Thank you for providing your feedback.
At this time, there is no technical difference between --src-path and source config-zip. These are two different cmlets that ultimately do the same thing. While it would be possible to remove one of the cmdlet's this would create an issue for many customers who have built scripts around either cmdlet and so we have found it better to let both of them co-exist.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Content: Add to data structures

📚 Documentation
I would like to add some content for data structures.
What are data structures and why we need them
Types of data structures
Time complexities
Applications
Have you read the Contributing Guidelines on Pull Requests?
Yes!

📚 Documentation
I would like to add some content for data structures.
What are data structures and why we need them
Types of data structures
Time complexities
Applications
Have you read the Contributing Guidelines on Pull Requests?
Yes!

It is already in progress.


add example of how to extract command from user reply

When I started to use this adapter I found the basic examples a great start. But in the more advanced code with callback it only shows
if (command === "...")  {..}
but it does not explain or point in the direction of how to get "command" as string. This should help other beginners.
Best regards!

Thank you for helpful extension!


Streamlined the getting started

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   89.01%   89.01%
=======================================
  Files          38       38
  Lines         528      528
  Branches        2        2
=======================================
  Hits          470      470
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db60312...6c2620a. Read the comment docs.

@juanpedromoreno Thanks for your review, I think I've clarified things in 84b7246 :+1:

@fedefernandez good to go :+1:


Print statement in code should be removed

There is a print(..) statement on line 24 of alert_controller.dart that should be removed.  Print statements should not be used in released code.
AlertController._init() {
print("AlertController was created!");
}

its would be nice if you have Pull request, thanks.


RetryWithErrorOutputParser does not work with LLMChain because it does not implement the parse function

Feature request
Currently if one wants to use the RetryWithErrorOutputParser - we need to do the parsing manually instead of generating a chain that does it for us (including all the nice chain functions: batch, ainvoke, etc)
There are 2 issues:

The RetryWithOutputParser requires the prompt to be given to it as input so that it can do it's magic. It does this by implementing a parse_with_prompt function. Unfortunately this function is not plumbed all the way into the BaseParser so that when this is invoked as part of a regular chain it gives the NotImplementedError: This OutputParser can only be called by the parse_with_prompt method. exception.
The default output of the chatmodels is to return just the output or AIMessages. However in this case we need both the prompt and the output.

Motivation
Currently we need to run the output parsing for the retry parsing manually. This tends to look something like this:
        chain = chat_prompt | self.chat_model
        output_batch = chain.batch(messages_batch,
                                   config={"max_concurrency": 10,
                                           "callbacks": [tracing_callback_handler]})

        prompts_list = tracing_callback_handler.prompts
        result_list = tracing_callback_handler.results
        parsed_output_batch = []
        for idx, output in enumerate(output_batch):
            parsed_output = retry_parser.parse_with_prompt(output.content, prompts_list[idx])
            parsed_output_batch.append(parsed_output)

In the above code the tracing_callback_handler is a custom callback handler that persists the prompt and results - which we end up using to give the retry_parser the prompt.
This is cumbersome and it would be awesome if this would just work with the chain itself like so
        chain = chat_prompt | self.chat_model | retry_parser
       output_batch = chain.batch(messages_batch,
                                   config={"max_concurrency": 10,
                                           "callbacks": [tracing_callback_handler]})

Your contribution
If someone can validate that my understanding of the problem is correct - I can go ahead and create a PR for this.

Your Question was not clear to me but from what I have gotten is that you have a callback called tracing_callback_handler and you want to do the parsing at runtime rather than writing a separate loop.  For this, why don't you modify your existing custom callback which uses the RetryWithErrorOutputParser at runtime within the tracing_callback_handler callback itself or better yet write a complete chain using LCEL.  Please see the code below:
import os
from langchain.schema.output_parser import BaseOutputParser
from langchain_core.callbacks import BaseCallbackHandler
from langchain.prompts import PromptTemplate
from langchain.chat_models import ChatOpenAI
from langchain.output_parsers import RetryOutputParser
from langchain.schema.runnable import RunnablePassthrough,RunnableLambda,RunnableConfig
from langchain_core.exceptions import OutputParserException
from typing import List,Dict,Any

os.environ["OPENAI_API_KEY"] = "sk-xxxxxxxxxxxxxxxx"
MAX_RETRIES = 1
MAIN_PROMPT = """You are an expert in providing technical assistance for Windows 10 user related queries.
Given a user question,you need to answer the user question which will help them in resolving in Windows 10 issues. Output your result as number of steps that user should follow:
    1- Go to here.
    2- Click here.
    ....
    n- So on.

Question
---------
{input}

Steps:
"""
NAIVE_COMPLETION_RETRY_WITH_ERROR = """Prompt:
{prompt}
Completion:
{completion}

Above, the Completion did not satisfy the constraints given in the Prompt.
Details: {error}
Please try again:"""

class tracing_callback_handler(BaseCallbackHandler): # Option 1 using callbacks
    def on_chain_end(self, outputs: Dict[str, Any], **kwargs: Any) -> Any:
        """Run when chain ends running."""
        retry_parser = RetryOutputParser.from_llm(ChatOpenAI(),parser = TestParser()) # you can declare it outside as well.
        if "completion" in outputs and "prompt_value" in outputs and "input" in outputs:
            print(retry_parser.parse_with_prompt(completion = outputs["completion"],prompt_value = outputs["prompt_value"]))
            # save your results

class TestParser(BaseOutputParser):
    """Just a Dummy Parser"""

    @classmethod
    def is_lc_serializable(cls) -> bool:
        return True

    @classmethod
    def get_lc_namespace(cls) -> List[str]:
        """Get the namespace of the langchain object."""
        return ["langchain", "output_parsers", "list"]

    def get_format_instructions(self) -> str:
        return (
            "Your response should be a list of comma separated values, "
            "eg: `foo, bar, baz`"
        )

    def parse(self, text: str) -> List[str]:
        """Parse the output of an LLM call."""
        return text.strip().split("\n")

    @property
    def _type(self) -> str:
        return "custom"

def retry_parser(_dict): # Option 2 convert the the entire chain to LCEL
    retries = 0
    parser_prompt = PromptTemplate.from_template(template = NAIVE_COMPLETION_RETRY_WITH_ERROR,input_variable=['prompt','completion','error'])
    retry_parser_chain = parser_prompt| ChatOpenAI()
    parser = TestParser()
    while retries <= MAX_RETRIES:
        try:
            return parser.parse(_dict["completion"])
        except OutputParserException as e:
            if retries == MAX_RETRIES:
                raise e
            else:
                retries += 1
                completion = retry_parser_chain.invoke({"prompt_value":_dict["prompt_value"],
                                                        "completion":_dict["completion"],
                                                        "error":str(e)
                                                        })
                return completion
    raise OutputParserException("Failed to parse")
main_chain_prompt = PromptTemplate.from_template(template = MAIN_PROMPT,input_variable=['input'])
functional_chain = RunnablePassthrough().assign(completion =
    main_chain_prompt\
    | ChatOpenAI().bind(stop='Steps')\
    | RunnableLambda(lambda x:x.content),
    prompt_value = main_chain_prompt)
main_chain = functional_chain | RunnableLambda(retry_parser)
main_chain.batch([{"input":"What is Windows 10?"},{"input":"How to shut down Windows 10?"}],config = RunnableConfig(callbacks = [tracing_callback_handler()]))

Again note that you only need to use of these options, entire construct your entire chain using LCEL so that you can parse and save at run time rather than writing sperate loops or move the parsing logic to the callback itself. YOU DON"T NEED TO USE BOTH but I will recommend the LCEL.

@sid374  I hope my code helps you, LMK if you have any confusion.

@keenborder786, I have a doubt about how to collect the completion from a chain, this is my code, when i am executing the chain i got an RunTimeError from parser. My question is how do i collect the partial completion so that i can pass it to the retry_parser.parse_with_prompt
response_schemas = [
    ResponseSchema(name="answer", description="answer to the user's question"),
    ResponseSchema(
        name="source",
        description="source used to answer the user's question, should be a website.",
    ),
]
output_parser = StructuredOutputParser.from_response_schemas(response_schemas)

format_instructions = output_parser.get_format_instructions()
prompt = PromptTemplate(
    template="answer the users question as best as possible.\n{format_instructions}\n{question}",
    input_variables=["question"],
    partial_variables={"format_instructions": format_instructions},
)
prompt_value = prompt.format_prompt(question = "what's the capital of france?")

chain = prompt | llm | output_parser

response = chain.invoke({"question": "what's the capital of france?"})
prompt_value = prompt.format_prompt(question = "what's the capital of france?")
retry_parser = RetryOutputParser.from_llm(
    parser=output_parser, llm=father_llm
)

retry_parser.parse_with_prompt(response, prompt_value)


Setting-Support-Admin-App - Sprint 1

Description:
Build the Screen to match the Figma design.
Integrate Screen with the Backend

Hello @Honeyloveet kindly assign this task to me. Thank you


added encoder to whisper function in LLMWhisperClient

When processing documents in Arabic, the expected Arabic text was not returned correctly.
I added an encoder argument to the whisper function in LLMWhisperClient. The issue was resolved by encoding the response in UTF-8, which correctly handled the Arabic text. The encoder is set to default to ISO-8859-1, but can now be adjusted as needed.

@ShoaibMajidDar Thanks for the contribution!
This would really help. Just couple of minor suggestions and rest looks good.

Ideally we need to forward the encoding in the request headers itself, so that it is understood by LLMWhisperer itself and is handled subsequently by the requests library. The current approach would help handle UTF-8 correctly which should cover most of the usecases and any requirement to support different encoding schemes will be properly tackled in the client and server in the future

@chandrasekharan-zipstack Agree, let's take up the improvements as required later.


Data Extraction fails when creating a Dev environment

When creating a Dev environment, data extraction will fail with the error below.
Object reference not set to an instance of an object.
{
  "Date": "2021-12-20T08:40:30.5500524+00:00",
  "Message": "Object reference not set to an instance of an object.",
  "Ex": {
    "ClassName": "System.NullReferenceException",
    "Message": "Object reference not set to an instance of an object.",
    "Data": null,
    "InnerException": null,
    "HelpURL": null,
    "StackTraceString": "   at Vendr.Common.Events.EventBus.Dispatch[T](T evt)\r\n   at Vendr.Core.Models.AggregateBase`3.Validate(IValidationEvent validationEvent)\r\n   at Vendr.Core.Models.Store.SetName(String name, String alias)\r\n   at Vendr.Core.Models.Store.<>c__DisplayClass66_0.<Create>b__0(Store x)\r\n   at Vendr.Core.Models.AggregateBase`3.QuietSet(Action`1 actions)\r\n   at Vendr.Core.Models.Store.Create(IUnitOfWork uow, StoreState state, String alias, String name, Boolean autoPopulateStore)\r\n   at Vendr.Core.Models.Store.Create(IUnitOfWork uow, Guid id, String alias, String name, Boolean autoPopulateStore)\r\n   at Vendr.Deploy.Connectors.ServiceConnectors.VendrStoreServiceConnector.Pass1(ArtifactDeployState`2 state, IDeployContext context)\r\n   at Vendr.Deploy.Connectors.ServiceConnectors.VendrStoreServiceConnector.Process(ArtifactDeployState`2 state, IDeployContext context, Int32 pass)\r\n   at Umbraco.Deploy.Infrastructure.Environments.CurrentEnvironment.ProcessArtifacts(IEnumerable`1 arts, IDeployContext context, CancellationToken token)",
    "RemoteStackTraceString": null,
    "RemoteStackIndex": 0,
    "ExceptionMethod": null,
    "HResult": -2147467261,
    "Source": "Vendr.Common",
    "WatsonBuckets": null
  },
  "Sender": "Umbraco.Deploy.Infrastructure.Work.WorkItems.DiskReadWorkItem"
}

Umbraco 9.0.1
Vendr 2.0.3
Vendr.Deploy 2.0.1
Running a data extraction from the Umbraco backend will just result in the same error.
But there is a work around to it:
Go into \site\wwwroot\umbraco\Deploy and manually run echo > deploy. You'll get an error saying "The environment is busy with another deployment", but this is an Umbraco Deploy bug, and if you just wait a little longer, you'll get a deploy-complete message.

Hey @MichaelNielsenDK I think this might be the same issue as here https://github.com/vendrhub/vendr-deploy/issues/10
Ultimately It's an Umbraco Deploy issue, magnified a little with some caching we do. Ultimately Deploy is running too soon before Vendr has been given chance to initialize. Because of this, it causes some things to be null which Vendr was then caching. We currently have a beta build on the unstable feed that removes this caching which means subsequent deploys via the back office will succeed, but the initial deploy will still fail.
I've reported this to HQ and I believe a PR has been merged into Deploy but I'm not sure what it's release cycle will be.

Closing issue as I believe it's a duplicate of #10 but feel free to re-open if with more details if you believe it to be otherwise 👍

Seems I was lucky once with the work around, it does not seem to work anymore 👎


pull model info from backend when opening webui settings panel

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
I tend to leave a tab open for my webui, even when I stop the backend process to free up RAM. I've gotten unexpected results from this several times because when I start the process again, it doesn't load the model I was working with last.
This is clearly my fault for not checking that I was loading the model I thought I was. The annoying thing, though, is that when I open the settings panel, it still tells me that the model(s) loaded/cached are the ones from the last time I changed models using that panel. It would be nice if that panel checked with the backend to see what models are loaded/cached, rather than just remembering it in the browser.
I know I should really reload the webui when I restart the backend, but that doesn't always happen. I'm sure I'm not the only one. This would also come up if someone had the webui open in multiple tabs, or on another device. If you change models on one, then opened the panel in the other, it would show that you were using a different model from what it is actually using to generate images.
Alternatives
No response
Aditional Content
No response

Until Websockets/Service Workers and modern front end tooling (React, Vue.js, etc) are implemented I don't see how that would be possible.

I've resolved this (in v2.2) by querying the model list every time the UI connects to back end (e.g. after restarting the backend). Also, we display the model now in the site header. Thanks for the report.


Leak analysis tooling

What does this PR do?
Capture live allocations

Instrument mmaps
Keep track of allocated memory

Motivation
Tracking down a leak
Additional Notes
A further PR should split this into a different profile type
How to test the change?
A leak test was added

Closing in favour of feature/leak_detection


"!$&", as when referring to automated processes, is filtered out.

See issue https://github.com/dotnet/docs/pull/40492#issuecomment-2068278622

Thank you for reporting this... Fixed by 5515dd75006bd97cdfd54a695d3bdcf4811c22e9


Numbers not showing from template

Hey!
Absolutely love what you have done here https://developers.google.com/gsuite/solutions/content-signup
I am using the brackets on my google doc and everything works (this is my second time using this script) but I have brackets where the input from G form is numbers - They dont show up in the email - just the reference to the brackets
Any ideas?

Need more info in order to help, but in that sample only the two placeholders, {{NAME}} and {{TOPICS}} are ever replaced -- see https://github.com/gsuitedevs/solutions/blob/master/content-signup/src/Code.js#L83. If you have additional form fields you want reflected in the template, you'd have to modify the solution to do so.
Or are you seeing a bug where if name is a number it fails?


Jvenstad/remove old instance parts 2

@mpolden please review.
This can not be merged before #10806 has been rolled out.

Redid the last commit. PTAL :)

Unrelated test failure.

@ldalves @freva FYI.


Fixed preventing override scrolling event while using Select2 with ajax request

This pull request includes a

[x] Bug fix

Problem story
I'm using ajax Select2 with Bootstrap3 Modal with scrolling modal. so when select2's dropdown opened, Bootstrap modal can't scroll.
The following changes were made

change this to self

If this is related to an existing ticket, include a link to it as well.
PS. this commit from @mahadoang's idea, all credit to him

See my in-line comment on why this doesn't fix whatever issue you are seeing.
Please submit a ticket (instead of a pull request) about this issue, assuming one doesn't already exist.


feat: upgrade metallb implemenation for 0.15.x

Use the metallb implementation from 0.31, as the old implementation no longer works.
To handle backports in KIC 2.5, we need to continue using KTF 0.15. KTF includes dependencies on client-go, GWAPI, etc., and upgrading those by pulling in the new KTF breaks API compatibility for 2.5. However, the 0.15 metallb addon no longer works.
This change pulls in the latest addon in its entirety and creating a release branch in prep to release a 0.15.2. This technically breaks semver because it's new functionality (although it does not break API compatibility), but I'm not sure what we can really do otherwise since we can't exactly bump the minor version (0.16 already exists). We may want to consider cutting new KTF major releases when we want to do a KIC LTS, although this tightly couples KTF version bumps to something it's not directly.

The CI is not functional though 😢


dwz: init at 0.14

Motivation for this change
Add dwz, a DWARF optimization and duplicate removal tool.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 136078 at 9a6bc12d run on aarch64-linux 1

1 package built successfully:

dwz

3 suggestions:

warning: unused-argument
Unused argument: cmake.
Near pkgs/development/tools/misc/dwz/default.nix:1:26:
  |
1 | { lib, stdenv, fetchurl, cmake, elfutils }:
  |                          ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/misc/dwz/default.nix:14:3:
   |
14 |   installPhase = ''
   |   ^

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/development/tools/misc/dwz/default.nix:22:5:
   |
22 |     license = licenses.gpl3;
   |     ^


Using pandas' extension framework

Does modin data frames/series honor custom Arrays, data frame/series accessors?
I could not find the doc.

@achapkowski Generally Modin should support these. If you can create a dataframe in pandas, Modin should also support that. The only thing that strictly isn't supported is accessing pandas internals.


[docs]: created code of conduct

Created code of conduct in resolution of a missing code of conduct

Created a code of conduct for the repo
__
  Tags: Inefficient


Enable CORS

Hi,
I'm working on a JS gadget for Check Users, and I want to integrate some whois-data into it. But currently, I can't request the api because of a "Cross-Origin Request" issue.
Could you enable CORS for the wikimedia sites? Some doc here: http://tamercelik.com/212/how-to-enable-cors-in-lighttpd/
Thanks!

I tried that, and then https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web/Lighttpd but neither seemed to work from domains such as en.wikipedia.org. Interestingly, it works on meta.wikimedia.org. for me.
But maybe it fails because I'm trying from Scratchpad of Firefox? I'll leave in the Access-Control lines according to the Toolforge docs, for you to test.

What is the status of this? I am also contributing to a gadget for CUs and this is needed for that gadget to work.

I think you can fix this by adding the following to the bottom of your lighttpd.conf file:
server.modules += (
    "mod_setenv",
)
setenv.add-response-header = ( "Access-Control-Allow-Origin" => "*" )

It seems that it has be done for fa.wikipedia.org, could it also be done for other wikimedia domains (especially fr.wikipedia.org)?

0x010C don't be confused. The one that I set up for temporary use at fawiki (located at whois.wmflabs.org) is not the same as the permanent instantiation of this tool located at whois.toolforge.org, formerly at tools.wmflabs.org/whois.
I'm happy to open up my temporary one to *, but I think either whym should fix his/hers, or we should retire his/hers and use the new one instead.

Thank you for the suggestion.

setenv.add-response-header = ( "Access-Control-Allow-Origin" => "*" )

I tried this. Is it working?

It works like a charm, thanks a lot!


Use -q argument in test using docker images -f

The test case TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking
fails based on time because it uses full docker images output and
value in the CREATED column turns from A minute ago to 2 minutes ago
in the middle of execution and output comparison fails.
e.g.
REPOSITORY                                   TAG                 IMAGE ID            CREATED              VIRTUAL SIZE
foo-1219                                     latest              2b7225e23d92        About a minute ago   2.433 MB

vs
REPOSITORY                                   TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
foo-1219                                     latest              2b7225e23d92        2 minutes ago       2.433 MB

This test doesn't really care about output cosmetics but rather image IDs returned
so -q makes sense here.
Signed-off-by: Ahmet Alp Balkan<EMAIL_ADDRESS>cc: @jfrazelle @dkjer @unclejack @TintypeMolly @sachin-jayant-joshi

I personally think that that test mostly tests nothing, because it is not even care about image id :) But removing race is cool.
LGTM

hmmm ya what is this even testing.... but LGTM

Just rofl'd on the name of the test, I guess it must be testing if function-names with length > 80 chars are handled correctly 😄

Seems like this should be a filters unit test.


Make a Conda package

See:
https://docs.conda.io/projects/conda-build/en/latest/user-guide/tutorials/build-pkgs.html
https://docs.conda.io/projects/conda-build/en/latest/user-guide/tutorials/build-pkgs-skeleton.html

blocked by #1

This issue can be closed when https://github.com/matchms/matchms/pull/68 is merged.


Crash on startup - Linux Mint 17 with GLib

Report from IRC, same user (Froward) and system as https://github.com/MovingBlocks/DestinationSol/issues/40
Crashed on game startup, seems to be an error in GLib, specific to Linux systems. This is on a laptop with two GPUs.
Game log: http://pastebin.com/yjEXueE6
Snippet:
(process:18611): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
System details: http://pastebin.com/CZRxh8Jm
Snippet:
00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)
...
01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] RV620/M82 [Mobility Radeon HD 3450/3470]

I found the same error related to a Firefox bug - some links

http://ubuntuforums.org/showthread.php?t=2175102
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1160569
http://ubuntuforums.org/showthread.php?t=2238827
https://bugzilla.mozilla.org/show_bug.cgi?id=8331170

I'm not quite sure what we can do here since it seems specific to the OS, distro, GLib, or maybe video card drivers? One of the links got into the proprietary vs. open source GPU device drivers we've hit on occasion in the past.
May also be difficult to troubleshoot when system specific like this.
@emanuele3d any idea if this could be related to initializing something graphics related or nah?
Edit: It is in the log but to highlight this is for stable release 55, so unrelated to recent work
Edit2: May also want to follow up with http://forum.terasology.org/threads/failed-install.1381/ if progress is made

It looks like this may be the same issue encountered in Destination Sol just spiraling into a weird error. Froward reports that using the same patched LWJGL 2.9.2 that fixed DestSol also fixed Terasology.
The fix in question, https://github.com/LWJGL/lwjgl/commit/0b83683ed155f089af61b2f4497cfda8181e333a, actually got merged to LWJGL master. However, I don't see it released in a 2.9.4 anywhere. It may exist unofficially / in a nightly build.
We could likewise build it ourselves or use a nightly, then use that version for both Terasology and Destination Sol to fix both issues (its use is transitive though, so we'd need to override it there).
I remember there was something about the applet we were trying to fix as well that didn't get entirely fixed in 2.9.3. If it is a simple fix we can do ourselves and we're building it anyway ... might be worth a shot.
Likelihood of more official LWJGL 2.x.x releases may be low as it is legacy now with LWJGL 3 out.

Closing as outdated.


[SPARK-29151][CORE] Support fractional resources for task resource scheduling

What changes were proposed in this pull request?
This PR adds the ability for tasks to request fractional resources, in order to be able to execute more than 1 task per resource. For example, if you have 1 GPU in the executor, and the task configuration is 0.5 GPU/task, the executor can schedule two tasks to run on that 1 GPU.
Why are the changes needed?
Currently there is no good way to share a resource such that multiple tasks can run on a single unit. This allows multiple tasks to share an executor resource.
Does this PR introduce any user-facing change?
Yes: There is a configuration change where spark.task.resource.[resource type].amount can now be fractional.
How was this patch tested?
Unit tests and manually on standalone mode, and yarn.

ok to test

Thanks @tgravescs will address.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Ok to test

test this please

Test build #112040 has started for PR 26078 at commit ffec31a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17047/
Test PASSed.

Test build #112040 has finished for PR 26078 at commit ffec31a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112040/
Test FAILed.

@tgravescs I think I addressed the comments you had.

test this please

Test build #112398 has started for PR 26078 at commit f784981.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17369/
Test PASSed.

Test build #112398 has finished for PR 26078 at commit f784981.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112398/
Test FAILed.

@abellina  please look at test failures, they look valid

test this please

Test build #112467 has started for PR 26078 at commit f9bba0f.

Linter is failing with:

[error] (*:update) sbt.ResolveException: unresolved dependency: com.typesafe#sbt-mima-plugin;0.3.0: not found

But that only happens in the build here, not locally...

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17434/
Test PASSed.

Test build #112467 has finished for PR 26078 at commit f9bba0f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112467/
Test PASSed.

@tgravescs ok addressed latest comments. The scala style check is still failing on the mima dependency.

test this please

Test build #112483 has started for PR 26078 at commit 1ea63ab.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17450/
Test PASSed.

Test build #112483 has finished for PR 26078 at commit 1ea63ab.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112483/
Test FAILed.

test this please

@tgravescs looks like some javadoc failures, not related. Re-running.

test this please

Test build #112484 has started for PR 26078 at commit 1ea63ab.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17451/
Test PASSed.

Test build #112484 has finished for PR 26078 at commit 1ea63ab.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112484/
Test FAILed.

How would we expect the resource contention being resolved among multiple tasks, for example, two tasks require usage of the same GPU card at the same time?

So this feature is specifically to allow multiple tasks to use the same GPU.  Many times one task can't keep the gpu busy, so running multiple tasks gets better utilization and through put.  For instance one task can copy the data to gpu and start running  and while its running another task can start to copy the data  so that when the first task finishes the data for second task is there and ready to run.  Also many times one tasks data/kernel isn't enough to fully utilize the GPU so you can run 2 tasks in parallel.  Obviously it requires the framework/code that runs on the GPU to be able to handle this.

test this please

Test build #112545 has started for PR 26078 at commit 1ea63ab.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17509/
Test PASSed.

Thanks @tgravescs I agree it should be a useful feature, but still hesitate how much Spark shall be aware of the resource scheduling. For example,  do we want to handle the failure on Spark side that sometimes one task request to use a GPU but the GPU resource is busy and need to deny the request?  Should the user code be able to handle that?

Test build #112545 has finished for PR 26078 at commit 1ea63ab.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112545/
Test FAILed.

I'm not sure why this javadoc keeps failing it looks unrelated:
[error] /home/jenkins/workspace/SparkPullRequestBuilder/mllib/target/java/org/apache/spark/mllib/util/MLlibTestSparkContext.java:10: error: illegal combination of modifiers: public and protected
[error]   protected  class testImplicits {
[error]              ^
@abellina can you run locally to see if it works?

@tgravescs Sounds reasonable, also I want to add that this feature is also useful for workloads that want to oversubscribe CPUs.

I'll try to make a pass of this PR in this week. Thanks!

@tgravescs yeah will do I am not sure why they are failing either.

The CPU side would require additional changes since we still use the original configs for CPUs and this is only applying when you use the "resource." configs. We could certainly do that but I think we should do it separately.

I ran the unidoc target using sbt locally and it succeeded, but saw this on the jenkins cluster:
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/target/java/org/apache/spark/resource/ResourceAllocator.java:17: error: bad use of '>'
[error]    * With {@link slotsPerAddress} > 1, {@link assignedAddrs} can contain duplicate addresses
[error]                                   ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/target/java/org/apache/spark/resource/ResourceAllocator.java:26: error: bad use of '>'
[error]    * With {@link slotsPerAddress} > 1, {@link availableAddrs} can contain duplicate addresses
[error]                                   ^

I'll change > with greater than and try again :)

Rebased to pick up mima repo change.

test this please

Jenkins, add to whitelist

test this please

Test build #112560 has started for PR 26078 at commit f3ece52.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17525/
Test PASSed.

Test build #112560 has finished for PR 26078 at commit f3ece52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112560/
Test PASSed.

@jiangxb1987

@jiangxb1987 thanks for the comments, will address shortly.

@jiangxb1987 I addressed most of the comments and left responses for the others, please take a look.

Test build #113115 has started for PR 26078 at commit f971fa4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18029/
Test PASSed.

Test build #113115 has finished for PR 26078 at commit f971fa4.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113115/
Test FAILed.

will look at doc failures.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18030/
Test PASSed.

Test build #113116 has started for PR 26078 at commit f17faee.

Test build #113116 has finished for PR 26078 at commit f17faee.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113116/
Test FAILed.

Test build #113117 has started for PR 26078 at commit d579c5d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18031/
Test PASSed.

Test build #113117 has finished for PR 26078 at commit d579c5d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113117/
Test PASSed.

LGTM

merged, thanks @abellina @jiangxb1987


Ideas for enhancements of Try

Repenser-la-propagation-des-exceptions-avec-Java-8

Making Option, Try et.al. more collection-like is out of focus.

I can't read French(?), but Try looks like the Validation class in FJ.  FJ uses Try, Try0, Try1, ... and TryEffect, TryEffect0, TryEffect1, etc. for lambdas that can throw an exception and then returns either void or A respectively.
The Try series have type signatures for function application like A f() throws Z, whereas TryEffect0 has a void return void f() throws Z.  We then convert this to a P1 or function that returns a Validation<Z, Unit> (for arity 0) and treat it like any other value.

Yes, I've seen fj's Validation class. It's a good way for pure functional programming. The Javaslang world takes a simpler appoach by the cost of impurity. Java's well known try/catch
try {
   bunchOfWork();
} catch(Exception_1 x) {
   ...
} catch(Exception_2 x) {
   ...
} catch(Exception_n x) {
   ...
}

is replaced by using Javaslang's Try Monad:
Try(this::bunchOfWork).recover(x -> ...).getOrElse(other);

Maybe in conjunction with the Match API, where Try and Match can be seen as expressions:
Try(this::bunchOfWork).recover(x -> Matchs
        .caze((Exception_1 x) -> ...)
        .caze((Exception_2 x) -> ...)
        .caze((Exception_n x) -> ...)
}).getOrElse(other);

That's the way Javaslang works. I do not plan to introduce more Try types.

Oh, realized that we have done very similar things. Your Validation is mine Try and your `Try``s are the checked functions.


Added setAllowIDFACollection

Allows users to use demographic and interest features in Google Analytics. As per
https://github.com/danwilson/google-analytics-plugin/blob/master/www/analytics.js#L7-L9

Oops, dupe of #1300. I should have checked before opening a pull request.


Allow generated file path to be configurable

fixes #32 make destination configurable.
be warned, this is a really rough first pass at this.
// next.config.js

import withTypeSafeRoutes from 'next-type-safe-routes/plugin';

withTypeSafeRoutes({
  nextTypeSafeRoutes: {
    destination: '__generated__/next-type-safe-routes/',
  }
});

i wanted to push to your branch but i didn't have privileges so just opened up my fixes in another branch.


pipenv: 2022.10.25 -> 2022.11.11

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for pipenv is: "Python Development Workflow for Humans"
meta.homepage for pipenv is: ""
meta.changelog for pipenv is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2022.11.5 with grep in /nix/store/cxgcj22np2ivfl41ipj7y91q2jy5bmxy-pipenv-2022.11.5
found 2022.11.5 in filename of file in /nix/store/cxgcj22np2ivfl41ipj7y91q2jy5bmxy-pipenv-2022.11.5

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pipenv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cxgcj22np2ivfl41ipj7y91q2jy5bmxy-pipenv-2022.11.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pipenv https://github.com/r-ryantm/nixpkgs/archive/b0aca0f186928ecf0581f289f7b8debdd8617e00.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cxgcj22np2ivfl41ipj7y91q2jy5bmxy-pipenv-2022.11.5
ls -la /nix/store/cxgcj22np2ivfl41ipj7y91q2jy5bmxy-pipenv-2022.11.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pipenv

Maintainer pings
cc @berdario for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for pipenv is: "Python Development Workflow for Humans"
meta.homepage for pipenv is: ""
meta.changelog for pipenv is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2022.11.11 with grep in /nix/store/9plh2544jb84wqbyh0w1mh13n76rds2b-pipenv-2022.11.11
found 2022.11.11 in filename of file in /nix/store/9plh2544jb84wqbyh0w1mh13n76rds2b-pipenv-2022.11.11

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pipenv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9plh2544jb84wqbyh0w1mh13n76rds2b-pipenv-2022.11.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pipenv https://github.com/r-ryantm/nixpkgs/archive/81e0b52f217401ab43ea9356929f92a1cfef6873.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9plh2544jb84wqbyh0w1mh13n76rds2b-pipenv-2022.11.11
ls -la /nix/store/9plh2544jb84wqbyh0w1mh13n76rds2b-pipenv-2022.11.11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pipenv

Maintainer pings
cc @berdario for testing.


Flight Delay Predictions (ML)

💥 Proposal
The aim is to predict flight delays with the help of decision tree classifier.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Unescape JSON strings (and escape again)

This fixes a bug in the interpretation of JSON literals. Escaped chars were never unescaped, so a literal containing "\n" would not result in a newline but that literal string.
When unescaping these they also need to be escaped again when serializing back (which happens when you use to_string, for example).

I'm expanding this PR to cover unescaping everywhere. Specifically there are three places where escaping takes place:

In the JCF JSON parser where the standard JSON escapes, plus backtick are supported
In quoted identifiers where the standard JSON escapes are supported, but not escaped backticks
In raw strings where it's unclear what should be supported, besides single quotes. We've proposed a change to the JMESPath grammar (see jmespath/jmespath.site#26) and implemented that version (which treats backslashes as any other character except for when it's before a single quote or another backslash).

The escape/unescape implementation doesn't support escaping the char 0xffff since it uses that as a marker value in its translation maps, but I think that's an ok tradeoff.


Fix build on Windows: make libaccel_config.h be useable there

Description
Without the declarations in it, we get a lot of build errors because the types aren't declared.
hardware_configuration_driver.h:56:39: warning: 'struct accfg_ctx' declared inside parameter list will not be visible outside of this definition or declaration
hw_configuration_driver.c:134:9: error: conflicting types for 'dsa_driver_new_context'; have 'int32_t(struct accfg_ctx **)' {aka 'int(struct accfg_ctx **)'}
hardware_configuration_driver.h:56:9: note: previous declaration of 'dsa_driver_new_context' with type 'int32_t(struct accfg_ctx **)' {aka 'int(struct accfg_ctx **)'}

hw_configuration_driver.c:188:21: error: return type is an incomplete type

etc.
Fixes #38.
No functional testing done. I've only confirmed that the build now succeeds on Windows, not even tried to run it there (it's not in scope for us at the moment).
No regression testing added because you don't have a public CI here on GitHub. Let me know once you add one and I'll add the MinGW build.

Hi @thiagomacieira, idxd-config is not supported on Windows, so the #if defined(__linux__) is expected. Could you please elaborate on what you're trying to do/address?

I know it's not supported. I just wanted the code to compile. But we've since given up and decided to bypass DML.

@thiagomacieira could you please elaborate more on the issue that you have with DML build or is it no longer relevant and we could close this PR?

I don't need DML any more, but the change is still valid, if DML is meant to be (ever) used on Windows.

Closing the PR as no longer relevant and since libaccel-config is not supported on Windows.