[🐞 BUG]: log in / signup page display after login

Description 📝
Still Showing the sigup/sigin page after a user login to the account
Link 🔗
https://retlab-dev.firebaseapp.com/signup
Steps to Reproduce 🔄

Go the signup page
Signup / sign in to you account
After succesfully login, Go to the url https://retlab-dev.firebaseapp.com/signup

Screenshots 📸

Expected Behavior 🤔
After login the signup / login page have to redirect or passed
Actual Behavior 😱
After a user login to the account the login / sign up page is still accessible
Environment 🌍

Browser: edge
OS: Windows

Additional Information ℹ
No response

can i take this issue ? @KarinePistili

Hai @KarinePistili
I have fixed this issue. please find the details below.
looking forward to you

Hai @KarinePistili https://github.com/KarinePistili
Hope you are doing well
I have fixed this issue. please find the details in the repository.
looking forward to you
Thank you
On Mon, 4 Mar 2024 at 22:04, KarinePistili @.***> wrote:

Thank you for the report. If you feel like fixing it we would be glad to
accept a merge request.
—
Reply to this email directly, view it on GitHub
https://github.com/ruxailab/RUXAILAB/issues/332#issuecomment-1976999222,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY6JGEIHBAU626B6OSIF5R3YWSPA7AVCNFSM6AAAAABED7Q7DGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWHE4TSMRSGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hai @KarinePistili https://github.com/KarinePistili
Hope this will finds you well.
I have fixed this issue. please find the details below.
looking forward to you
Thank you.

Can i work on this issue?

Hey @HarshAgrawal1
I resolved this issue.
Check the commits below.
Feel free to check remaining too.


feat: add util starknet-sierra-compile

Replacing #24

This change is

Codecov Report
Attention: Patch coverage is 77.94118% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 56.71%. Comparing base (c7179ab) to head (9f0e0d6).

Files
Patch %
Lines

crates/gateway/src/compiler/compile.rs
77.94%
9 Missing and 6 partials :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   34.84%   56.71%   +21.86%
===========================================
  Files           5        6        +1
  Lines          66      134       +68
  Branches       66      134       +68
===========================================
+ Hits           23       76       +53
- Misses         43       52        +9
- Partials        0        6        +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

+reviewer:@orizi - using CasmContractClass::from_contract_class in the gateway-mempool.


Mazumder - Automate and generate BiosampleMeta data set via Scripts

you know how you guys are pulling information into your two sheets via the APIs (assemblyQC_NCBI & ngs_id_list, respctively)? Could you also do this with our biosampleMeta table? within this you could also have a part of the script that communicates to NCBI to pull info from there as needed? We do capture a decent amount of info in our APIs that could be used to generate that table + it is used to serve as a record anyway? what do you think? -  much of the info is already present in an ncbi format from 1 of the three other core tables (so maybe your script call information from all three APIs depending on the term), then any remaining info can be pulled with the biosample accession for that org from biosample with a script (From Steph)

Include new entries that were QC'd in ngs and assembly datasets + all current FDA BioProject entries into BiosampleMeta - duplicate to ticket #178

Closed with https://github.com/FDA-ARGOS/data.argosdb/issues/143

Closed with https://github.com/FDA-ARGOS/data.argosdb/issues/143


Build does not work - python 3.9.0 and wrong magic number (IDFGH-4490)

This environment works perfectly with Python 2.7 which I have been using for many years, but with each version you complain my python is too old so I tried using Python 3.
With a new download and build, I get the following error:
-- Project sdkconfig file /mnt/c/Users/x/dev/esp/FastLED-idf/sdkconfig
Traceback (most recent call last):
File "/mnt/c/Users/x/dev/esp/esp-idf/tools/kconfig_new/confgen.py", line 27, in
import kconfiglib
ImportError: bad magic number in 'kconfiglib': b'\x03\xf3\r\n'
CMake Error at /mnt/c/Users/x/dev/esp/esp-idf/tools/cmake/kconfig.cmake:228 (message):
Failed to run confgen.py
(/home/x/.espressif/python_env/idf4.3_py3.9_env/bin/python;/mnt/c/Users/x/dev/esp/esp-idf/tools/kconfig_new/confgen.py;--kconfig;/mnt/c/Users/x/dev/esp/esp-idf/Kconfig;--sdkconfig-rename;/mnt/c/Users/x/dev/esp/esp-idf/sdkconfig.rename;--config;/mnt/c/Users/x/dev/esp/FastLED-idf/sdkconfig;--env-file;/mnt/c/Users/x/dev/esp/FastLED-idf/build/config.env).
Error 1
Call Stack (most recent call first):
/mnt/c/Users/x/dev/esp/esp-idf/tools/cmake/build.cmake:443 (__kconfig_generate_config)
/mnt/c/Users/x/dev/esp/esp-idf/tools/cmake/project.cmake:396 (idf_build_process)
CMakeLists.txt:6 (project)
This is with master as of today 12/25/20.
I have tried this with deleting the build directory and deleting sdkconfig and whatnot. I don't know what kconfiglib is an why it would have the 'wrong magic number'

Hi @bbulkow. I'm sorry for the inconvenience. Please try to run idf.py python-clean. It should solve the problem.

I assume this has been solved. Please let me know if not.

Worked for me

Worked for me too!

Worked for me too


Can't use Brightdata proxy (error 407)

Describe the bug
I can't use Brightdata proxy. I got a 407 error.
I try this code:
const proxy = 'http://brd-customer-XXX:PWD@brd.superproxy.io:22225';
const proxyAuth = 'brd-customer-XXX:PWD';

const agent = ytdl.createProxyAgent({
  uri: proxy,
  token: `Basic ${proxyAuth}`
});

const audioStream = await ytdl(videoUrl, { agent, filter: 'audioonly', format: 'mp3' });

I also opened an issue on undici : https://github.com/nodejs/undici/issues/3442
Debug File
N/A
Environment

@distube/ytdl-core version: 4.14.3
Node.js version: 18
Operating system: Linux Mint 21

I cannot solve any problem with proxy, it should be due to your proxy error


User request: top 100 interactive studies

Can you create a top 100 leaderboard for interactive studies
can u have your own database for this
posted to the team forum about it

I thought what was meant was top interactive studies, but instead they meant how many times and with which proficiency people finished interactive lessons. I don't store not have that information, so this is not doable.


added Telugu localization strings. (te)

Description

Added Telugu (te) language localization strings.
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

@googlebot I signed it!

@googlebot I consent.

@googlebot I consent.

@felangel Thank you for reviewing and accepting my changes. 💙🙌


Add Chatbot for Enhanced User Support

Is your feature request related to a problem? Please describe.
To improve user engagement and provide instant support, a chatbot should be integrated into the website. The
chatbot will assist visitors by answering common questions.
Describe the solution you'd like

Implement a chatbot widget in the bottom-right corner of the website.
The chatbot should be able to:

Answer FAQs related to the website’s services, navigation, and common user queries.
Offer live chat support

we already have one !


chore: ha-node nvme connect over uds to csi-node

Signed-off-by: Abhinandan Purkait<EMAIL_ADDRESS>

bors merge


[1.12] Bump dcos-net

High-level description
Bump dcos-net.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4320 dcos-dns incorrectly deletes records in PODs when one container exits.
DCOS_OSS-4337 [dcos-net] DNS issue due to non unique task Id

Related tickets (optional)
Other tickets related to this change:

DCOS_OSS-4311 dcos_dns: make ZK servers configurable
DCOS_OSS-4338 [dcos-net] Make mesos stream parser fault tolerant
DCOS_OSS-4336 [dcos-net] reduce the depth of crashlog

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: all bugs were introduced and fixed in 1.12 branch
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: none
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[x] Test Results: [link to CI job test results for component]
[x] Code Coverage (if available): [link to code coverage report]

https://github.com/dcos/dcos-net/compare/d8dd43289b5626b8df30639e20bcefc4c0c437fa...b02814510c1d4686b7055c4f70f44410bc3892c9
https://github.com/dcos/dcos-net/pull/92
https://github.com/dcos/dcos-net/pull/94
https://github.com/dcos/dcos-net/pull/95
https://github.com/dcos/dcos-net/pull/96
https://circleci.com/gh/dcos/dcos-net/722
https://codecov.io/github/dcos/dcos-net/commit/b02814510c1d4686b7055c4f70f44410bc3892c9

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee


Can't Get link

After Finish Full process i can't get any link ...
Please response for this issue .

Hey, which OS you are using

check updated tool


Enable message queue listener on integration

This enables the message queue listener for rummager in integration.
Full story: https://trello.com/c/0FKSqAkK

This is fine.


Add a more generic hook mechanism

This would be useful in case anyone wants to hook in something specific to their application, such as custom metrics or other stuff

what about integrating it with: https://github.com/gchaincl/sqlhooks?

Looking at it, it looks like integration isn't even necessary, I see no reason why this package and gchaincl/sqlhooks wouldn't play nicely together.

@luna-duclos you're right, they should.
if you're getting problems with 1.8 can you open an issue pls?


Update winget package submission to support arm

Description of the new feature / enhancement
Here are samples.  Note the pipe and arch for backup style if arch can't be scanned.
wingetcreate update Microsoft.PowerToys -v 0.58.2 -u "https://github.com/microsoft/PowerToys/releases/download/v0.58.2/PowerToysSetup-0.58.2-x64.exe" "https://github.com/microsoft/PowerToys/releases/download/v0.58.2/PowerToysSetup-0.58.2-arm64.exe"
wingetcreate update Microsoft.PowerToys -v 0.58.2 -u "https://github.com/microsoft/PowerToys/releases/download/v0.58.2/PowerToysSetup-0.58.2-x64.exe|x64" "https://github.com/microsoft/PowerToys/releases/download/v0.58.2/PowerToysSetup-0.58.2-arm64.exe|arm64"
Scenario when this would be used?
automation :)
Supporting information
No response

this needs to be done after we manually update the winget manifest also

https://github.com/microsoft/PowerToys/runs/6904575395?check_suite_focus=true


Nested library linking results in duplicate deployments

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (9b0575e 2022-08-04T00:10:43.515642Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Intel)
Describe the bug
When a library calls another library, the second library gets re-deployed to a new address.
Given the code
library Library {
    function foo() external pure returns (uint256) {
        return 42;
    }
}

library Library2 {
    function foo() external pure returns (uint256) {
        return Library.foo();
    }
}

contract Contract {
    function foo() external pure returns (uint256) {
        return Library2.foo();
    }

    function bar() external pure returns (uint256) {
        return Library.foo();
    }
}

contract TestLibrary is Test {

    Contract c = new Contract();
    function testFoo() public {
        console.log(address(Library), "lib 1");
        console.log(address(Library2), "lib 2");

        assertEq(c.foo(), 42);
        assertEq(c.bar(), 42);
        assertEq(Library.foo(), 42);
        assertEq(Library2.foo(), 42);
    }
}

The outcome is

As can be seen, most of the calls to the librares go to the expected addresses (7e84 & f221), except when Library2 calls Library, in that case there's a second copy of Library in 0x62d6…3691
If I link the lib to a pre-defined address in foundry.toml then there's no issue, been using that as a workaround (I then etch the lib code) but of course is not ideal.
I assume this can be also a problem with deployment scripts where the same lib may be deployed multiple times.

Good find!

Fixed with https://github.com/foundry-rs/foundry/pull/5164 💆
see output:


Grammatical error on main page

In the text right under "SoyBase" on the main page, "that" is repeated twice.

We anticipate that that this transition will continue through 2024.

Thanks, @That-Thing. Fixed in https://github.com/soybase/jekyll-soybase/pull/192. Closing.


Remove cinderv1 support from cloudprovider

What this PR does / why we need it:
Cinder v1 is deprecated in Juno release of Openstack and removed completely in Queens (https://docs.openstack.org/releasenotes/cinder/queens.html) . This PR removes the support for the same in cloudprovider.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #695
Special notes for your reviewer:
Release note:

Cinderv1 support is removed from cloudprovider.

/test cloud-provider-openstack-acceptance-test-e2e-conformance-stable-branch-v1.15

/uncc

other than conflict seems good to go

/approve
/lgtm


Update composer cakephp dependency to stable

As CakePHP now has an official 3.x release it is time to update the composer.json to do this.
The current state of the file actually breaks composer installs of the plugin on CakePHP 3 apps.
This currently makes the Money Datatype uninstallable.
Thanks & Cheers,
Borislav Sabev.

Thanks :)


Ability to check if model is apart of multiple groups

Referenced in #146, the ability to check for multiple groups at once needs to be added. This array can contain a Group model, common name, or the groups distinguished name.
$groups  = [
    'cn=My Group,dc=corp,dc=acme,dc=org', // Group DN
    $group // Group Model
    'My Group' // Group Name
];

if ($user->inGroup($groups)) {
    // The user is apart of all of the specified groups
}

Thanks for this @steveauman! Great new feature!

Just now getting around to looking at this and can't seem to get it working with multiple groups. A single group works fine.
An example route looks like this: Route::get('/', ['uses' => 'HomeController@index', 'middleware' => ['auth.group:Systems,Marketing']]);
The middleware is as follows:
class VerifyGroupMembership
{
    public function handle($request, Closure $next, ... $groups)
    {
        if ( ! Auth::user()->adldapUser->inGroup($groups)) {
            abort(403, 'Unauthorized action.');
        }

        return $next($request);
    }
}

In the middlware, a dd($groups) returns the following so I know the variables are arriving to the middleware.
array:2 [▼
  0 => "Systems"
  1 => "Marketing"
]

But the auth check fails.
I also tried manually placing $myGroups = ['Systems','Marketing']; in the middlware and passing that to inGroup() but that also fails. Any ideas?

Is the user that's authenticated apart of both the Systems and Marketing groups?

I am the user and I am in the Systems group, not the Marketing group.

inGroup($groups, $recursive = true) does not seem to make a difference.

Oh, that's the reason then. The user must be apart of both groups that you give, not just one.

OK, that makes sense. What does $recursive do?

If for example, the Marketing group was apart of the Systems group:
// This would return true
$user->inGroup(['Marketing', 'Systems'], true);

// This would return false
$user->inGroup(['Marketing', 'Systems']);

The $recursive option pulls in groups of groups, merges the results, then checks if the user is in each of the specified groups.

OK, perfect. There is my work around then. So, I can create a Domain Universal group called Intranet-Marketing for example, and add groups (eg; Marketing, Systems) or users to it and set the recursive option to true. I just test that and it seems to work well.


Clean up our pytest configuration so others can use it

🐛 Bug
On Zulip, @perlman reports:

[the ome-zarr plugin] registers a pytest hook ( "pytest11": ["napari-conftest = napari.conftest"]) which is preventing me from using pytest in environments where I have ome-zarr but NOT napari installed.
Is there a reason this pytest plugin needs to be installed globally, especially when napari is not an actual requirement of ome-zarr?

The reason ome-zarr-py adds that hook is so that they can use our test fixtures, which they wanted to do to test their plugin. But, since there's no way for them to conditionally add an entry point, they are stuck depending on napari for testing.
I think the clean solution is to create a new, separate package with our conftest, eg napari-pytest, and have both us and ome-zarr-py depend on it as a test dependency only, not a runtime dependency.
See also #1602.
To Reproduce

Create a new environment
pip install pytest ome-zarr
Run pytest

Expected behavior
Installing packages in the napari ecosystem without napari should not break pytest.

Hm. I go through pytest documentation (for prepare classes) and found nice fixture (pytestconfig) which may be solution for this problem, https://docs.pytest.org/en/stable/reference.html#pytest.config.PytestPluginManager.register.
So to check it I download ome-zarr code, remove "pytest11": ["napari-conftest = napari.conftest"] line from setup.py then install and try to run test. Everything pass.
So it looks like this line is obsolete and I do not have idea which project could be used for test something like
@pytest.fixture(autouse=True, scope="session")
def load_napari_conftest(pytestconfig):
    from napari import conftest
    pytestconfig,register(conftest, "napari-conftest")

and put napari in a test dependecies.

@Czaki I'm sorry, could you explain the steps in more detail? I'm 95% sure that the ome-zarr folks added that entrypoint precisely because they couldn't use our fixtures without it...! CC @joshmoore @will-moore

Wow, thanks @Czaki! I've opened https://github.com/ome/ome-zarr-py/pull/51 with:
@pytest.fixture(autouse=True, scope="session")
def load_napari_conftest(pytestconfig):
    from napari import conftest

    pytestconfig.pluginmanager.register(conftest, "napari-conftest")

This looks to work. (The first run without a new call to pip install fails with a double registration of the plugin)
That block of code would need to be hard-coded by anyone wanting to re-use napari's conftest. If there were a way to make that simpler, this issue might still have some value. But from my side, I think @perlman's issue should be fixed with PR 51.

@joshmoore pleas check it detailed. I already created empty virtualenv and install ome-zarr. Then install test dependecies (pytest, scikit-imge, scipy) and run test. Everything works in environment without napari.
╰─$ pytest
============================================================= test session starts ==============================================================
platform linux -- Python 3.7.7, pytest-6.1.0, py-1.9.0, pluggy-0.13.1
rootdir: /home/czaki/Projekty/ome-zarr-py, configfile: pytest.ini
collected 32 items

ome_zarr/conversions.py ...                                                                                [  9%]
ome_zarr/data.py .                                                                                [ 12%]
ome_zarr/io.py ..                                                                                [ 18%]
ome_zarr/scale.py .                                                                                [ 21%]
ome_zarr/utils.py .                                                                                [ 25%]
tests/test_cli.py .....                                                                                [ 40%]
tests/test_napari.py ...s                                                                                [ 53%]
tests/test_node.py ...                                                                                [ 62%]
tests/test_ome_zarr.py ......                                                                                [ 81%]
tests/test_reader.py ...                                                                                [ 90%]
tests/test_starting_points.py ...                                                                                [100%]

Ah, you're saying that the current code is (without the PR 51) works as expected? Then I'd defer to @perman. From my side, the change isn't particularly onerous so if it helps, happy to see it go in.

Ah, you're saying that the current code is (without the PR 51) works as expected? Then I'd defer to @PERMAN. From my side, the change isn't particularly onerous so if it helps, happy to see it go in.

I run my test on revisions db60b8272e0fe005920f8a296d4828b7a32e663e.
Fro my test it looks like yesterday, developer version of ome-zarr test set does not dependent on napari.conftest. Maybe previous one does this.

is there any remaining actions needs to be done for this issue? it looks like we can close this one?

I guess @ziyangczi it would be to follow up on @jni comment

The reason ome-zarr-py adds that hook is so that they can use our test fixtures, which they wanted to do to test their plugin. But, since there's no way for them to conditionally add an entry point, they are stuck depending on napari for testing.
I think the clean solution is to create a new, separate package with our conftest, eg napari-pytest, and have both us and ome-zarr-py depend on it as a test dependency only, not a runtime dependency.

To prevent this from happening again, and maybe https://github.com/napari/napari/issues/1602 too

Not sure what the status of that one is

I guess @ziyangczi it would be to follow up on @jni comment

The reason ome-zarr-py adds that hook is so that they can use our test fixtures, which they wanted to do to test their plugin. But, since there's no way for them to conditionally add an entry point, they are stuck depending on napari for testing.
I think the clean solution is to create a new, separate package with our conftest, eg napari-pytest, and have both us and ome-zarr-py depend on it as a test dependency only, not a runtime dependency.

To prevent this from happening again, and maybe #1602 too

@jni are you still leaning towards separating out conftest to napari-pytest? It sounds like an API change to the plugin developers, I can look into the separation now if this is still desired

@jni are you still leaning towards separating out conftest to napari-pytest? It sounds like an API change to the plugin developers, I can look into the separation now if this is still desired

I do not think that it is a good idea. If you would like something like this, then you should first stop overwrite pytest-qt elements like qtbot
What is wrong with my proposed solution which uses pytestconfig.pluginmanager.register?

@jni are you still leaning towards separating out conftest to napari-pytest? It sounds like an API change to the plugin developers, I can look into the separation now if this is still desired

I do not think that it is a good idea. If you would like something like this, then you should first stop overwrite pytest-qt elements like qtbot
What is wrong with my proposed solution which uses pytestconfig.pluginmanager.register?

even though I don't have a comprehensive understanding of the benefit of the separation, I second @Czaki's solution 😄

Yeah I don't really understand this interaction either but it looks like https://github.com/ome/ome-zarr-py/pull/51 is stuck with failing test config, so I'd like to keep this open until that is resolved.

there are no changes in ome/ome-zarr-py#51 from long time. And tests fail because They have installed both PySide2 and PyQt5 in the test environment.
@joshmoore There are any plans to push this PR?

Sorry about that, @Czaki. I dropped the ball on that. Hopefully can get to it once I2K is over and before EOSS starts ...  but yes, my understanding is that there's a path forward, certainly for ome-zarr-py. Happy to make use of whatever the official solution is.

I failed to notice in https://github.com/napari/napari/issues/1661#issuecomment-701959175 that @Czaki's test run was skipped:
tests/test_napari.py ...s                                                                                [ 53%]

I'm currently struggling with
___________________________________________________ ERROR at setup of TestNapari.test_viewer ___________________________________________________
file /opt/ome-zarr-py/tests/test_napari.py, line 65
      def test_viewer(self, make_test_viewer):
E       fixture 'make_test_viewer' not found
>       available fixtures: add_implementation, add_specification, cache, caller_from_implementation, capfd, capfdbinary, caplog, capsys, capsysbinary, cov, doctest_namespace, initdir, load_napari_conftest, monkeypatch, no_cover, pytestconfig, qapp, qapp_args, qtbot, qtlog, qtmodeltester, record_property, record_testsuite_property, record_xml_attribute, recwarn, temporary_hookimpl, test_plugin_manager, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

but will keep looking.

could you point me to which version (branch) you test now?

Just pushed https://github.com/ome/ome-zarr-py/pull/51/commits/8f6d31d55717432ac6d9f921ed736c2d1e849ddd

@Czaki : let me know what you think of https://github.com/ome/ome-zarr-py/pull/51/commits/be56babf8cac86742305ac6e24510809482a1198 it seems to fix the issue. So a pytest scoping issue ?

Nope. It fixed the issue locally, but the GHAs are less than happy.

I have created https://github.com/ome/ome-zarr-py/pull/67

Especial thanks to @Czaki for all the help with ome/ome-zarr-py#51. Short summary from https://github.com/ome/ome-zarr-py/pull/51#issuecomment-738788825 as relevant to this issue:
👉  napari.conftest currently requires the registration block above and importing make_test_viewer for use elsewhere. A working example would apply a patch like this:
  import numpy as np
  import pytest
+ from napari.conftest import make_test_viewer  # noqa

  from ome_zarr.data import astronaut, create_zarr
  from ome_zarr.napari import napari_get_reader

+ @pytest.fixture(autouse=True, scope="session")
+ def load_napari_conftest(pytestconfig):
+     from napari import conftest
+
+     pytestconfig.pluginmanager.register(conftest, "napari-conftest")

big thanks to @joshmoore and @Czaki! closing this issue now

Thanks to everyone for fixing this, especially @jni for tolerating my poking in Zulip. :)


refactor option passing

Coverage remained the same at 100.0% when pulling 5c67b53993d61763abc04a58bbdbf6f69ddc986d on refactor-option-passing into ef62e2ad1479d0d67e53e135ba759748aa2d9e34 on main.


Won't install with PIP

Collecting numba!=0.49.0,>=0.46
  Using cached numba-0.56.4.tar.gz (2.4 MB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\david\AppData\Local\Temp\pip-install-kjd8wjro\numba_17e5f45e8dbf4b2f850a0efb94b9ffae\setup.py", line 51, in <module>
          _guard_py_ver()
        File "C:\Users\david\AppData\Local\Temp\pip-install-kjd8wjro\numba_17e5f45e8dbf4b2f850a0efb94b9ffae\setup.py", line 48, in _guard_py_ver
          raise RuntimeError(msg.format(cur_py, min_py, max_py))
      RuntimeError: Cannot install on Python version 3.11.0; only versions >=3.7,<3.11 are supported.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

[notice] A new release of pip available: 22.3 -> 23.0.1
[notice] To update, run: python.exe -m pip install -

Hello @David-OConnor, thanks for opening the issue. As this line in the traceback states;

RuntimeError: Cannot install on Python version 3.11.0; only versions >=3.7,<3.11 are supported.

numba, which is a dependency of EinsteinPy, does not yet support Python 3.11. It is due to add support soon however - https://github.com/numba/numba/issues/8841. Till that is done, can you try installing EinsteinPy on Python 3.10 or lower (till Python 3.8)? That should work without issues. Also, for the documentation, please follow this link: https://docs.einsteinpy.org/en/latest/.

Thanks for the info! Working on 3.10 as you said. Sounds like the play is wait for Numba.

Numba added support for Python 3.11 -> https://github.com/numba/numba/releases/tag/0.57.0. This issue should be resolved now.


Add PopupMenuTheme to enable theming color, shape, elevation, text style of Menu

Description
This change introduces a PopupMenuEntryTheme that allows you to theme the color, shape, elevation, and text style of a menu. This can be done at the theme level and at call time of showMenu. See the following image for an example:

Related Issues
Closes #36076
Tests
I added the following tests:
*Tests for the theme and modifying the color/shape/elevation/text style of a menu
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

Reset email to pass the CLA check

I'm manually updating the CLA since the PR contributor is a Googler

Overriding CLA as @lisa-liao is a googler


Create documentation for and improve bot configuration for analyzer

During the 3.0 push it was identified that many analyzer team members don't have sufficient understanding of what tests get run on which bots, how to check them, and how to alter the configuration of bots to improve test performance.   There may also be gaps in the team's knowledge as a whole where none of us actually know critical pieces of this.  An analyzer-team specific document that covers frequently encountered problems, links to relevant dashboards and configuration files, and gives some examples might be helpful here.   Writing this document may also identify areas in which the system could be improved to be more intuitive.

/cc @athomas , @whesse
We had to reach out to the infra team to figure out how to get to the test failure logs/messages, as sometimes clicking on the links did not end up with anything useful.
Is there any documentation on how to navigate through the build bots?


drawlinestring not rendering on mobile

Hello-
I use the following to draw lines on the map, works fine on a desktop, however the lines don't appear to render on mobile. Any thoughts on where I might be going wrong?
 renderer.drawLineString({
                    points : points,
                    size : 2.0,
                    ...color && {color:color},  //white line is multiplied by this color so resulting point will be this color
                    depthTest : false,
                    //depthOffset : [-0.01,0,0],
                    screenSpace : false, //switch to physical space
                    blend : false
                });

Line with color property looks wrong. Try something like color:[255,0,255,255] This should draw line with magenta color.
drawLineString should work on mobile devices. Otherwise I would need whole code which demonstrates problem.

No the color works fine- the idea is that it checks that the color variable is not set false or null, and then assigns the color.
I tried on another mobile phone and it works - it seems that my ancient phone isn't able to handle that specific part of the code  but everything else works.


Specifying config overrides on the command line

Why & what
mirrord is currently configured by a JSON file. However, it's often useful to be able to override settings at runtime; two engineers might have to run a service on different ports. Today, they would have to modify the mirrord.json config, or have it gitignored and use a mirrord.example.json in git.
Additionally, ports are often defined by environment variables, something that JSON does not support. Therefore, mirrord should support a --set argument to provide overrides.
By providing mirrord users with the ability to override config at runtime through the CLI, it becomes easier to streamline usage for a team. For example, you may have a team where the port is set in an HTTP_PORT environment variable. With command-line configuration, that team would be able to share a makefile entry similar to this:
run:
	mirrord --set feature.network.incoming.port_mapping="[[$PORT, 8000]]"

How
The --set argument would function like Helm's. For mirrord, this means:

Apply the default configuration
Apply the config file (if specified by -f)
Apply command-line overrides

Additionally, because we're operating on a known schema, mirrord would be able to validate --set arguments and provide good error messages. This is optional, but would be valuable.
How objects should be parsed is up for debate. Personally, I think not accepting objects or arrays is the easiest solution short-term, though it may come with some big pitfalls. The example below ignores all objects. The biggest downside with this is that it allows for weird incomplete values; e.g port_mapping: [[8000]] is not valid; a tuple is required.

Benefits
This solution provides multiple benefits over the alternatives:

No need for additional documentation: the JSON config options are already documented. This would mean no need to document environment variables or new command-line arguments.
Grows with mirrord: as configuration options expand, there's no need to add new command-line options. This reduces both work required, as well as tool complexity.

Alternatives
Config options per feature
In Helm, we use --set because it's operating on an arbitrary data structure that isn't known to helm itself. We could provide command line options for each configuration option.
This could potentially provide even better UX than the proposed solution, as shell completion could be generated for all options. Additionally, it's inline with what mirrord already does; configuration like steal is already available as an option.
The only downside is that it is likely to result in an explosion of command-line options, which will obscure possibly more useful options. It may be better to limit command-line options to the most common configuration overrides, or configuration that cannot be done through the JSON file (if such config exists).
Configuration through stdin
Initially, I considered configuration through stdin. However, this would prevent users from using the feature if their application relies on stdin. Additionally, you'd have to provide a full config, rather than just overrides.
The one benefit of this is that it'd only require adding - as a valid argument to -f, and then just treat it as reading JSON.
Environment variables
Currently, some of mirrord's options can be configured through environment variables. While fine, they can be hard to discover, and does not allow mirrord to provide clear validation of provided options.

Thanks for the elaborate feature request!
I am wondering if configuration templating wouldn't be enough given we already plan to implement #1819

To further contextualise my own personal desire (didn't want to include in the main feature request because I think it's too niche to justify as the main reason to build this): I want to wrap mirrord in my own binary, and pass through options. Being able to use the command line saves me from writing a JSON configuration file to /tmp!

We're accepting contributions on this - we might be able to push it internally, but can't promise it soon.
On implementation side - I'd add a level before parsing the configuration into our internal object, to parse it into a Value enum then apply the --set there, to avoid macro codes.


Module reload with same session.

Hi,
I have a question regarding shader reload with the same session. I have a filewatcher on a shader to be able to do shader hot-reloading and I should keep the same slang session as I have a lot of compiled modules inside this session for type conformances (and I don't want to recompile all the type conformance module). But when reloading the shader (with different code), I think there is a cache of imported module inside the session and it won't recompile with the new shader code. Is there a  way to do that ?
Thanks,
Baptiste

Module unloading is complicated since there can be many dependent objects on a loaded module, so it can't simply be removed from the session. Currently we don't plan to support direct removal of a loaded modlue, and creating a new sesion with precompiled modules is the cleanest way forward. Closing as won't fix.

Ok,
Thank you for the answer !
Best,
Baptiste


1008 add localization support for comments

Hi,
I added the localization support for comments as requested in the issue 1008

Merged! Thank you!


Adding new Transformer breaks compilation

Hi, I was trying to add a new Transformer to spatial that actually does nothing (for experimental reasons) and the code looks as follows:
case class DummyTransformer(IR: State) extends MutateTransformer with AccelTraversal {

  override def transform[A: Type](lhs: Sym[A], rhs: Op[A])(implicit ctx: SrcCtx): Sym[A] = rhs match {
    case _: AccelScope => inAccel {
      super.transform(lhs, rhs)
    }
  }
}

But when I was building the codebase through sbt, I got a huge amount of error messages produced:
[info] Compiling 2 Scala sources to /home/ruizhe/projects/spatial/target/scala-2.12/classes ...
[error] ## Exception when compiling 334 sources to /home/ruizhe/projects/spatial/target/scala-2.12/classes
[error] null
[error] scala.tools.nsc.transform.ExplicitOuter$ExplicitOuterTransformer.transform(ExplicitOuter.scala:362)
[error] scala.tools.nsc.transform.ExplicitOuter$ExplicitOuterTransformer.transform(ExplicitOuter.scala:323)
[error] scala.reflect.internal.Trees.itransform(Trees.scala:1366)
[error] scala.reflect.internal.Trees.itransform$(Trees.scala:1357)
[error] scala.reflect.internal.SymbolTable.itransform(SymbolTable.scala:18)
[error] scala.reflect.internal.SymbolTable.itransform(SymbolTable.scala:18)
[error] scala.reflect.api.Trees$Transformer.transform(Trees.scala:2555)
[error] scala.tools.nsc.transform.TypingTransformers$TypingTransformer.transform(TypingTransformers.scala:44)
[error] scala.tools.nsc.transform.ExplicitOuter$OuterPathTransformer.scala$reflect$internal$Trees$UnderConstructionTransformer$$super$transform(ExplicitOuter.scala:205)
[error] scala.reflect.internal.Trees$UnderConstructionTransformer.transform(Trees.scala:1720)
....
[error] 	at scala.reflect.api.Trees$Transformer.transform(Trees.scala:2555)
[error] 	at scala.tools.nsc.transform.TypingTransformers$TypingTransformer.transform(TypingTransformers.scala:44)
[error] 	at scala.tools.nsc.transform.ExplicitOuter$OuterPathTransformer.scala$reflect$internal$Trees$UnderConstructionTransformer$$super$transform(ExplicitOuter.scala:205)
[error] 	at scala.reflect.internal.Trees$UnderConstructionTransformer.transform(Trees.scala:1720)
[error] 	at scala.reflect.internal.Trees$UnderConstructionTransformer.transform$(Trees.scala:1715)
[error] 	at scala.tools.nsc.transform.ExplicitOuter$OuterPathTransformer.transform(ExplicitOuter.scala:282)
[IJ]sbt:spatial> [error] (Compile / compileIncremental) java.lang.StackOverflowError
[error] Total time: 7 s, completed 11-Apr-2019 17:10:42

I tried to clean up caches by sbt clean, as well as increasing the heap size to 8192 MB, this issue persists.
Could anyone kindly give me a hint about the possible reason? Thanks!

Wow. Looks like you hit a scalac typing bug right out of the gate, sorry about that. Could you try commenting out this new class just to verify that's the cause?
I don't think this is causing the issue, but just for future reference, you should add a
case _ => super.transform(lhs, rhs) as a wildcard case to your match block to avoid a match exception at runtime (otherwise it won't know what to do with things that aren't AccelScope).

Hi @dkoeplin Thank you for your reply!
I have created a new branch in my fork that includes this new transformer (with the revision suggested by you) at https://github.com/kumasento/spatial/tree/test-add-trans. I tried to comment out the initialization of the DummyTransformer while the compilation still cannot pass.

otherwise it won't know what to do with things that aren't AccelScope

Yes indeed, I didn't notice the AccelScope after the wildcard when I was copying this snippet from another Transformer :(
Please let me know if there is anything else I could do

Cool, I'll take a look to see if I can reproduce the problem

Taking a look at what you posted again, the error you're seeing is during scala compilation itself, not while running, and based on what you pasted it looks like a stack overflow error during the scala compiler's typing pass. Naturally, increasing the heap size won't help solve a stack overflow. Could you check what your stack size is and increase it? (I use -Xss1G but that's probably more than necessary)

Ah it is working now, thanks and sorry for this silly mistake!
(PS I attached -J-Xss1G to sbt when running the compilation)


Release 3.2.0

Added

Menu to components
Menu story to storybook

Changed

README index adding Menu and default values for Dialog
README index formatting
Dialog story event names
let prettier redo some formatting

I also added 3.0.1 to the CHANGELOG since the release notes don't get written there by semantic release and had to merge main back into develop to fix some conflicts in package.json and package-lock.json
Semantic-Release should now see v3.1.0 is already a tag with the latest released commit (I pointed it to main which includes 3.0.1) and therefore release 3.2.0

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Uncaught ReferenceError: TimeSync is not defined

This happened when I copied your user-status demo code into my project on line:
Template.status.serverOffset = TimeSync.serverOffset;

I can't figure out the issue as the package is there...

i'm getting this issue with v0.3.4 on meteor 1.2.1, is anyone else?

figure it out -- it's because i was referencing it in a file that's in a shared folder


[FEATURE_REQUEST] Multiple Search Engines Simultaneously

Is your feature request related to a problem? If so, please describe.
Thank you for adding the search function! I was hoping it could be made more multifunctional. With just some text, you could change what search engine you use on the fly. Plus, the user could expand it to encapsulate as many sites as they wish.
Describe the solution you'd like
Here's an example of the idea:
Config File
"appConfig":
  "webSearch": {
    "searchEngine": "multi",
    "multiSearchEngine": {
         "/g": "google",
         "/d": "duckduckgo",
         "/rd": "reddit",
         "/yt": "youtube",
         "/sp": "https://open.spotify.com/search/",
         "/wk": "wikipedia",
         "/md": "https://mangadex.org/titles?q=",
         "/js": "http://jisho.org/search/",
    }
 }

That way the user can add their own engines based on sites they frequently/commonly use.
You could also use bangs (!) if it works better: e.g. "!d": "duckduckgo"
Examples of Use

/rd "jjk movie discussion"
/js "終了"
/yt "how to hold a cat"
/md "naruto"

Priority
Medium (Would be very useful)
Is this something you would be keen to implement
No

Love the idea! I had not thought of this, but it makes sense, and should be pretty easy to implement.
I'll get it done this weekend, and update the ticket when it's released :)

Heya, this is implemented in #224 :)
Once you've updated to V 1.7.6, you can use it with something like:
appConfig:
  webSearch:
    searchEngine: 'duckduckgo'
    openingMethod: 'newtab'
    searchBangs:
      /r: reddit
      /w: wikipedia
      /s: https://whoogle.local/search?q=
      /a: https://www.amazon.co.uk/s?k=
      ':wolf': wolframalpha
      ':so': stackoverflow
      ':git': github

Hope that helps :)


Remove reference to scanned documents pre-verification

ORU no longer provide a service where they check scanned document copies for users before they send the originals via post.
We were not told why this service is being discontinued.

Looks good to me.


Allow installing on Laravel 10

Just installed it locally, tests are passing.

Thanks @antonioribeiro!
Some of our dependencies are not supporting Laravel 10 yet, as noted on https://github.com/area17/twill/pull/2122#issuecomment-1415763778.
lazychaser/nested-set is an optional dependency, so not a blocker, but cartalyst/tags and laravel-translatable would prevent the install at the moment, no?

Yeah, you are right, @ifox , closing this for now.

I think we can keep it open? Definitely want to release support for Laravel 10 on Twill 2.

Sure I'll reopen it as soon as we are able to close all subjects. I'm waiting on the nestedset guys to merge one of those PRs :D

@ifox , all PHPUnit tests are now passing, but we have some flags on roave-backwards-compatibility-check that must be thought before we move forward. This is one example:
    protected $dates = [
        'deleted_at',
    ];

It was deprecated in favor of $casts on Laravel 8, and now removed from Laravel 10, so we are supposed to change the implementation but should we keep supporting Laravel versions that doesn't have $casts, are we still supporting any?

Thanks @antonioribeiro.
We do indeed have to take a closer look at this change, because we also rely on getDates from Eloquent, which implementation has changed in Laravel 10: https://github.com/laravel/framework/blob/10.x/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L1441. Before, it was using the $dates model property: https://github.com/laravel/framework/blob/9.x/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php#L1450. And this is where we rely on it: https://github.com/area17/twill/blob/748467bbf9177e8d1e38086d1c959e2e6bc9f020/src/Repositories/Behaviors/HandleDates.php#L17.
We are not supporting any version that didn't have $casts, as it has been available since 5.0.

@ifox, I just reimplemented getDates() to support Laravel 10 getting from $dates and created some tests to check if it's all working fine.
Most of the other errors can probably be ignored, but I will still look at them all tomorrow

@ifox , here's the analysis of the breaking change errors we get:
BROKEN - Needs a fix -- Please review the fix
Error: Property Illuminate\Database\Eloquent\Model#$dates was removed

Can probably be ignored
Error: Default parameter value for parameter $inverse of Illuminate\Database\Eloquent\Concerns\HasRelationships#morphToMany() changed from false to NULL

Error: Parameter 7 of Illuminate\Database\Eloquent\Concerns\HasRelationships#morphToMany() changed name from inverse to relation

Not being used directly (internal calls)
Error: Method Illuminate\Foundation\Bus\Dispatchable::dispatchNow() was removed

Error: Method Illuminate\Foundation\Bus\DispatchesJobs#dispatchNow() was removed

Error: Parameter 4 of Illuminate\Foundation\Validation\ValidatesRequests#validateWithBag() changed name from customAttributes to attributes

Error: The parameter $parameters of Illuminate\Support\Traits\Macroable#__call() changed from no type to a non-contravariant array

Error: The parameter $parameters of Illuminate\Support\Traits\Macroable#__call() changed from no type to array

Error: Parameter 3 of Illuminate\Foundation\Validation\ValidatesRequests#validate() changed name from customAttributes to attributes


[PORT] Add missing XML documentation to Microsoft.Bot.Connector

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/4299

Related to #4052
Changed projects

Microsoft.Bot.Connector

[BF Docs,R10]

Closing. To be handled as part of #2465


client vs. server config at runtime / command line args

Several (more than not) of the server-only flags I think I actually want on the client side for more flexibility.

Closing since there hasn’t been a lot of activity on this issue. We are sorry about that 😔
If you are still having issues, please reopen!


Add an identity option to registering

Summary
It is tedious to implement the function that returns inputs as it as outputs every time.
Adding an option identity resolves the above issues.
Details and comments
related to https://github.com/Qiskit/arraylias/issues/15.

Indeed, I think that it was a little bit too much to add identity options to register_function, register_default, and register_fallback too.
I am considering the following situation
@alias.register_fallback(path="some_function")
def _(x):
  return x

We can write by using the identity option
@alias.register_fallback(path="some_function", identity=True)

As you mentioned, the current register_fallback can cover almost cases where we want to get the identity output.
It might be too specific to a rare case. I consider that this option is useful for qiskit-dynamics, but we need more of that case.

We will discuss in the future.


Small improvements (tooltip, dex source file)

If multiple files are loaded in Jadx their file paths are now shown as tooltip on the JRoot node
Decompiled classes get a comment from which dex files they have been loaded from. This is useful if the APK files contains dex files in non-standard locations (e.g. in assets or other places).

For 2. I also tried to include the APK source file name in the comment in case multiple files are loaded, but it seems that Jadx does not store this information at least I wasn't able to identify how to access this information.  I assume this would require some bigger changes to DexFileLoader to carry the original source file information through all the different loader methods to save it in the end in DexClassData .

@jpstotz thanks!
Although, I am not sure that everyone will need these additional comments, but it is useful :+1:

@skylot May be I should add an option to enable/disable this type of comments?

@skylot May be I should add an option to enable/disable this type of comments?

Not sure. I don't want to add an option to every small feature. And looks like we need some common approach to add additional info into code and customize it in options. Maybe similar to log level as discussed in #998. Also in jadx-gui we can add a class tooltip or some kind of popup with additional info like in all IDEs.


how to set output file path?

now, i run build_runner. file will auto output ./__generated__. how to set output file path?

Thanks


feat: DEV-4028: Use $fps from task for frameRate

Codecov Report
Base: 9.40% // Head: 9.40% // No change to project coverage :thumbsup:

Coverage data is based on head (ecac277) compared to base (c3ed720).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1141   +/-   ##
======================================
  Coverage    9.40%   9.40%
======================================
  Files         109     109
  Lines        7785    7785
  Branches     1953    1953
======================================
  Hits          732     732
  Misses       5908    5908
  Partials     1145    1145

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore: disable Clerk middleware for everything but API routes

it causes page latency and we don't need it everywhere right now. Going forward if we need to access the user session on all pages we'll have to tackle this.
Description
Music year: 2013

List of changes

Issue(s)
Fixes #
How to test

Go to https://deploy-preview-2788--oak-web-application.netlify.thenational.academy
Click on ______
You should see ______

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.549.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change GridSpace -> Grid and SubSet -> Domain

This PR changes the names of the structure GridSpace and SubSet in Grid and Domain, respectively. Also Grid now contains only the information to make the mapping between pos and coord (i.e., only orig and h). That is, a set of cells now must be defined via a Domain (thus the functions add_pos!, add_set!, etc. apply exclusively on Domain), and SymbolicModel needs Domain's (and not GridSpace's) as fields.

It looks much cleaner indeed

Results are similar: with example_pathplanninggrowth-hard:

Before:

compute_symmodel_from_controlsystem! started
compute_symmodel_from_controlsystem! terminated with success: 23784452 transitions created
  7.586279 seconds (26 allocations: 2.141 KiB)
compute_controller_reach! started
compute_controller_reach! terminated with success
  0.697363 seconds (65 allocations: 25.924 MiB)

After:

compute_symmodel_from_controlsystem! started
compute_symmodel_from_controlsystem! terminated with success: 23784452 transitions created
  7.568163 seconds (23 allocations: 2.078 KiB)
compute_controller_reach! started
compute_controller_reach! terminated with success
  0.688603 seconds (62 allocations: 25.924 MiB)


AutoFixture was unable to create an instance from System.Data.Entity.DbSet`1

I just don't seem to be able to get this to work
[Test]
public void Test()
{
    var fixture = new Fixture();
    fixture.Customize(
        new EntityCustomization(new DbContextEntityTypesProvider(typeof (MyContext))));

    Assert.DoesNotThrow(() => fixture.Create<MyContext>());
}

Expected: No Exception to be thrown
But was:   (AutoFixture was unable to create an instance from
System.Data.Entity.DbSet`1[MyProject.Database.Models.MyModel],
most likely because it has no public constructor, is an abstract or non-public type.

Libraries are all latest versions from NuGet.

To be clear, this library is purely for creating instances of EF entities themselves, not other EF classes like DbContext or DbSet<>. Although it does surprise me that AutoFixture would throw an exception in this case - does it still throw the same error without the customization?

Yes, I did realise that eventually. It does throw an exception, because the DbSet<> constructor is protected. There is a way around that, but you then still have to supply mocks for all the relevant methods on a DbSet<>, which is what I was hoping AutoFixture would do for me.
I guess I will now learn about customising AutoFixture.


Feature: Relay command implementation

Is your feature request related to a problem? Please describe.
Not really.
Describe the solution you'd like
Having an out of the box ICommand implementation  to separate the semantics and the object that invokes a command from the logic that executes the command just seems reasonable.
Describe alternatives you've considered
Different additional packages ..

From the perspective to have everything in one place it seems as a good idea.


Merge dev-integrate -> main

Resolves #284
Resolves #295
Resolves #289

This sync is predominantly populated with updates to the file list (.vf) files, for minor whitespace adjustments and to provide UVM compilation lists.
The only RTL source touched is caliptra_top.sv, to remove some TODO comments.
Other changes include some updates to validation firmware and testbenches.

Currently blocked until #298 completes

@andreslagarcavilla or @bharatpillilli can you complete this PR to main? It is ready to go. Thanks.


Expose Solr readiness/liveness, performance metrics and more to K8s/Prometheus

This is related to #82 and #85.
Very profund and good article with loads of usable stuff: https://lucidworks.com/post/running-solr-on-kubernetes-part-1/

Documenting special handling of Solr in 729a0033  here.
Without any readinessProbe or livenessProbe, the old Solr container will be killed immediately after we start a new one to replace it (e.g. during update). The few seconds between terminating the one old container and core loading on the new instance was sufficient to release the IndexWriter lock (/data/index/write.lock)
Now as we have probes, the old container will not be killed before the new is not ready to serve requests (checked by getting system info). (We cannot ping the core, as it would block due to the lock). The time between "ready" and termination is in turn too large to have the lock released on time for core loading.
Here the livenessProbe kicks in: check will fail, and the container is restarted because of failure treshold set to 1. This restarts the container and that has been enough time to release the lock.
I dunno if a RELOAD would be ok, too - I wanted to make sure that it reaches a workable state again. This might bite back someday... Maybe switch to SolrCloud anyway.

For the Prometheus exporter: https://lucene.apache.org/solr/guide/7_6/monitoring-solr-with-prometheus-and-grafana.html
Not sure if this should run in a sidecar or be a separate deployment.


Refactor to be event-based

The current usage of visitor feels weird along side scripts that are largely event-based. I was thinking about how we could start to move to a more event-based pattern, and here's an idea:
const visitor = require('probot-visitor');

module.exports = robot => {
  // How often to schedule events, and the name of the event to schedule'
  visitor(robot).schedule('daily', 'sweep');

  robot.on('scheduled.sweep', (event, context) => {
    // event.payload.repository - repository object
    // event.payload.installation - installation object
    // context.github - authenticated GitHub client
  });
};

cc @lee-dohm

I like it! :100:
Maybe instead of scheduled we could use visitor as the root name? Perhaps other plugins would like to create synthesized events like this? If so, then having a by-convention namespacing system would help facilitate that.

Maybe instead of scheduled we could use visitor as the root name?

Good point. What would you think about renaming this plugin to probot-scheduler? Original I called it visitor because it visits each repository, but I think that's an implementation detail. What it does is "scheduling". Does that make sense?

It schedules, yes ... but I would tend to assume that something called
scheduler would be more flexible than simply "hourly", "daily", or such.
Maybe "cron"? 😉 Naming is hard ...
On Thu, Jun 8, 2017 at 7:11 AM, Brandon Keepers<EMAIL_ADDRESS>wrote:

Maybe instead of scheduled we could use visitor as the root name?
Good point. What would you think about renaming this plugin to
probot-scheduler? Original I called it visitor because it visits each
repository, but I think that's an implementation detail. What it does is
"scheduling". Does that make sense?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/probot/visitor/issues/6#issuecomment-307115701, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA_XKebRXbshSM506Zlbnugz68u35Jioks5sCAEhgaJpZM4NzEkj
.

Eventually, I think it would allow more flexibility. For example, Lambda has scheduled events, which can be an interval (hour, day, etc) or a cron expression.
I think this plugin should offer the same.

Sounds good! scheduler it is :+1:

Fixed in #7


Added mappings between various representation of languages

This basically adds possibility to find language based on ISO 639-1 and ISO 639-3 code strings. Implementation is not entirely optimal - it would be great to unite the code base only on single language enum and transform to/from ISO codes via maps, but this does not break API and gets the thing done.

Codecov Report

Merging #45 (bdc88b1) into main (cf22a07) will decrease coverage by 10.12%.
Report is 3 commits behind head on main.
The diff coverage is 36.36%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   86.79%   76.67%   -10.12%
===========================================
  Files           8        9        +1
  Lines        1598     1608       +10
===========================================
- Hits         1387     1233      -154
- Misses        156      320      +164
  Partials       55       55

Files Changed
Coverage Δ

language.go
61.61% <ø> (-35.63%)
:arrow_down:

mapping.go
36.36% <36.36%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closed in favor of commit 20e6689ef2fc4fb900bae4da60dccd41983eddbf.


Column 1 was not found error

I could not seem to get this to work after following the instructions to install this on a new Win 10 VM. The VM is not part of and domain.

This is the same as https://github.com/Azure/ccodashboard/issues/175 that has not been resolved either.

You have verified that you use normal organization account and not guest account? The account you use is member in the tenant and not external?

Hi @ChaiSwaddipong,
As I see in the error message the custom connector is not recognized, please take a look to the configuration  before running the dashboard:


Face alignment

We need just a simple example of how to perform a correct face alignment, like this:

FaceMark.Fit function seems to be broken still.  See issue #467


What is the use of this library on Android ? (please read below to understand the question)

Describe your environment

React-Native version "react-native": "0.52.2",
Platform: iOS, Android, both? Android
Device (which one?), simulator? Device
OS version MacOS 10 13 3
react-native-permissions version "^1.1.1"
Devtools: Xcode? Android Studio version? Android Studio 3.0.1
(Android only: buildToolsVersion)  buildToolsVersion "26.0.2"

How to repeat issue and example
Explain what you did:

installed the library in a virgin react-native init project
compared the example provided in this library with my code
changed the buildToolsVersion from 23 to 26

What you expected to happen:

I expected to have a pop up when requesting a particular permission and than the chosen permission to be enabled automatically.

What actually happens:

When using this configuration in Android.Manifest.xml:

<uses-permission android:name="android.permission.INTERNET" />
    <!--<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>-->
    <!--<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>-->
    <!--<uses-permission android:name="android.permission.CAMERA"/>-->
    <!--<uses-permission android:name="android.permission.RECORD_AUDIO"/>-->
    <!--<uses-permission android:name="android.permission.CALL_PHONE"/>-->
    <!--<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>-->
    <!--<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>-->
    <!--<uses-permission android:name="android.permission.READ_CONTACTS"/>-->
    <!--<uses-permission android:name="android.permission.READ_CALENDAR"/>-->
    <!--<uses-permission android:name="android.permission.READ_SMS"/>-->
    <!--<uses-permission android:name="android.permission.RECEIVE_SMS"/>-->

only Storage and Photo permissions are authorized(green) - wonder why that is. All the other are undetermined(gray).

When selecting an unauthorized permission there is pop up saying "Woops! There was a problem getting your permission. Please enable it from settings". When selecting OPEN SETTINGS a warning message is displayed saying "Underhanded Promise Rejection Error: 'openSettings' is deprecated on android". This warning is apparently not an error, the feature is only available on iOS(https://github.com/yonahforst/react-native-permissions/issues/214). Same warning happens when selecting Open Settings from the in-app button.

When the Mannifest.xml permissions above are enabled(uncommented) than the app shows all permission as authorized.

Additional info
On Android 5.0 it is not possible to disable the permissions from the device settings.
When AndroidManifest.xml has all permission disables except for INTERENT and when looking at the app's permission in Application Manager - App info the following permissions are visible:

read phone status and identity (as far as I know this is a dangerous permission)
read, modify or delete the contents of you SD card
full network access
draw over other apps.

On Android 8.1.0 (Pixel XL 2) it is possible to disable the permissions from the devices settings.
When AndroidManifest.xml has all permission disabled except for INTERENT and when looking at the app's permission in Application Manager (App info) the following permissions are visible:

Phone*
Storage

When disabling a permission there is a pop up saying " This app was designed for an older version of Android. Denying permission may cause it to no longer function as intended". When disabling both permission and reloading the application Storage and Photo are still authorized and green highlighted.
*.    inside the application Photo permission is authorized but inside the device settings Phone permission is enabled and there is no Photo permission.

My latest research shows that Phone and Storage permissions are enabled by default in android. The way to disable them is to:
`
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
<uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
<uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="remove" />
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove" />`

Latest update
When cloning react-native-permissions and running the example it works. Initially I copied the example code in a brand new react native project and than npm installed react native permissions, as one would do in a regular project. So now I am comparing the differences between these two projects to find out why the brand new project is now working...

What did you find?

For Android >6 give permissions upfront and they will be enabled when the app is installed. For Android <6 use this library as it seems to be working just fine and permissions are only enabled at run time(OS is responsible for this) . Don't forget to check the table on the readme page for Android compatibility.


Confusing usage of the field slice_axis

Motivation for the feature
A user was not aware of the field slice_axis, which resulted in an improper design of the cropping mask. I think that many users will fall in the same trap, so we might want to consider changing the way we deal with these issues. Few suggestions:

We could get rid of the field slice_axis and assume that the user will always properly prescribe the order of the dimensions for the cropping vector.

More details at: https://github.com/ivadomed/model_seg_ms_mp2rage/issues/26#issuecomment-998867775

I believe this is important and lot of hours of debugging can be saved by fixing this! Currently, this is how the function calls occurs during loading the dataset:

The function that transposes the axes in order to get the 3D matrix into the HxWxD form is given here, which is called in the SegmentationPair class. The SegmentationPair function is itself called during loading in the MRI2DSegmentationDataset here. Now, both 2D and 3D BidsDatasets depend on this class, which makes it a bit difficult to get rid of the slice_axis parameter.
Moreover, slice_axis is more suited for 2D training as it (correctly) defines which set of slices to extract from the 3D Nifti. This is quite handy from the user's perspective, because we just mention "axial/sagittal" and those slices are extracted. HOWEVER, where it gets confusing is with the 3D training.

I have two suggestions to go about this:

We update the Docs by explicitly differentiating between how this key can be modified for 2D and 3D training. In particular, for 2D training, we must say that the goal of slice_axis is to get the matrix in the HxWxD format (for easy slicing) and also mention [this function] where it happens.
Now, for 3D, we introduce an additional optional like "slice_axis": "3d" in the config file, which tells ivadomed that the user is interested in 3D training. In the backend, in this function, we add an if condition such that when it "3d", we return the matrix according to how it is returned in nibabel. Basically, it will be something like

if slice_axis == "3d":
   return data.transpose(1, 2, 0)

This makes sure that shape of the 3D image will be same when printed via nibabel and via ivadomed, hence making it more consistent. Also, in the Docs, we must mention that the output shape corresponds to that obtained by nibabel.
A nice comparison of the output shapes by ivadomed and nibabel for a single subject is shown in this comment.

As seen here, there is already a control statement in ivadomed to determine whether the input shape is 3D or 2D:
if model_params[ModelParamsKW.NAME] == ConfigKW.MODIFIED_3D_UNET \
             or (ModelParamsKW.IS_2D in model_params and not model_params[ModelParamsKW.IS_2D]):

Addressing @naga-karthik's second suggestion, we can use the same here to avoid creating a new field in the config file.

If you decide to move forward with any kind of transformation of the image, I suggest you also apply the same transformation on the center_crop field.


Fixes CGCatalog Filters

CGCatalog's project filters got ruined in a previous commit.

nit: reword to be in imperative mood


heroku-buildpack-go doesn't detect Go projects

Status: Downloaded newer image for gliderlabs/herokuish:latest
       -----> Fetching custom buildpack
       -----> Unable to select a buildpack
ERROR: Job failed: exit code 1

Project : https://gitlab.com/NatoBoram/Go-Miiko/
What are the full requirements for heroku-buildpack-go to detect a Go project? Is there a way to tell it that I'm using Go, and that go build actually works?

The buildpack readme states

There is also another section of the readme for non conforming projects: https://github.com/heroku/heroku-buildpack-go#usage-with-other-vendoring-systems

My suggestion is to use one of the tools listed in the readme to vendor your dependencies (or at least record them). Once that is done then this buildpack should work w/o problem and compile your application


Build React Native in CI

In order to test whether the react native bindings committed actually work.

Partially done in https://github.com/breez/breez-sdk/pull/566


TestWatchErrConnClosed fails

https://semaphoreci.com/coreos/etcd/branches/master/builds/1076
log.txt
=== RUN   TestWatchErrConnClosed
2016-10-11 23:20:02.040819 I | integration: launching node2522201834049211672 (unix://localhost:node2522201834049211672.sock.bridge)
2016-10-11 23:20:02.041431 I | etcdserver: name = node2522201834049211672
2016-10-11 23:20:02.041471 I | etcdserver: data dir = /tmp/etcd506766226
2016-10-11 23:20:02.041512 I | etcdserver: member dir = /tmp/etcd506766226/member
2016-10-11 23:20:02.041550 I | etcdserver: heartbeat = 10ms
2016-10-11 23:20:02.041582 I | etcdserver: election = 100ms
2016-10-11 23:20:02.041611 I | etcdserver: snapshot count = 0
2016-10-11 23:20:02.041649 I | etcdserver: advertise client URLs = unix://<IP_ADDRESS>:21524.16121.sock
2016-10-11 23:20:02.041688 I | etcdserver: initial advertise peer URLs = unix://<IP_ADDRESS>:21523.16121.sock
2016-10-11 23:20:02.041736 I | etcdserver: initial cluster = node2522201834049211672=unix://<IP_ADDRESS>:21523.16121.sock
2016-10-11 23:20:02.060916 I | etcdserver: starting member 2e4b02ca96375a21 in cluster 97a4560d2d323a5f
2016-10-11 23:20:02.060995 I | raft: 2e4b02ca96375a21 became follower at term 0
2016-10-11 23:20:02.061059 I | raft: newRaft 2e4b02ca96375a21 [peers: [], term: 0, commit: 0, applied: 0, lastindex: 0, lastterm: 0]
2016-10-11 23:20:02.061104 I | raft: 2e4b02ca96375a21 became follower at term 1
2016-10-11 23:20:02.062580 I | etcdserver: set snapshot count to default 10000
2016-10-11 23:20:02.062623 I | etcdserver: starting server... [version: 3.1.0-alpha.1+git, cluster version: to_be_decided]
2016-10-11 23:20:02.081248 I | etcdserver/membership: added member 2e4b02ca96375a21 [unix://<IP_ADDRESS>:21523.16121.sock] to cluster 97a4560d2d323a5f
2016-10-11 23:20:02.089753 I | integration: launched node2522201834049211672 (unix://localhost:node2522201834049211672.sock.bridge)
2016-10-11 23:20:02.089834 I | raft: 2e4b02ca96375a21 is starting a new election at term 1
2016-10-11 23:20:02.089904 I | raft: 2e4b02ca96375a21 became candidate at term 2
2016-10-11 23:20:02.089945 I | raft: 2e4b02ca96375a21 received vote from 2e4b02ca96375a21 at term 2
2016-10-11 23:20:02.090001 I | raft: 2e4b02ca96375a21 became leader at term 2
2016-10-11 23:20:02.090046 I | raft: raft.node: 2e4b02ca96375a21 elected leader 2e4b02ca96375a21 at term 2
2016-10-11 23:20:02.096163 W | etcdserver: apply entries took too long [13.066724ms for 1 entries]
2016-10-11 23:20:02.097919 W | etcdserver: avoid queries with large range/delete range!
2016-10-11 23:20:02.098634 I | etcdserver: published {Name:node2522201834049211672 ClientURLs:[unix://<IP_ADDRESS>:21524.16121.sock]} to cluster 97a4560d2d323a5f
2016-10-11 23:20:02.098998 I | etcdserver: setting up the initial cluster version to 3.1
2016-10-11 23:20:02.099473 N | etcdserver/membership: set the initial cluster version to 3.1
2016-10-11 23:20:02.115156 I | integration: terminating node2522201834049211672 (unix://localhost:node2522201834049211672.sock.bridge)
2016-10-11 23:20:02.144478 I | integration: terminated node2522201834049211672 (unix://localhost:node2522201834049211672.sock.bridge)
--- FAIL: TestWatchErrConnClosed (0.11s)
    watch_test.go:589: expected grpc: the client connection is closing, got context canceled

@heyitsanthony @xiang90
In what cases do we expect ErrClientConnClosing from closing watch client?
I've been running this TestWatchErrConnClosed https://github.com/coreos/etcd/blob/master/clientv3/integration/watch_test.go#L610 over 5,000 rounds but cannot reproduce.
func TestWatchError(t *testing.T) {
	defer testutil.AfterTest(t)

	clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 1})
	defer clus.Terminate(t)

	cli := clus.Client(0)
	wc := clientv3.NewWatcher(cli)

	cerr := cli.Close()
	fmt.Println("cli.Close:", cerr)

	wc.Watch(context.TODO(), "foo")
	err := wc.Close()
	fmt.Println("wc.Close:", err)

	clus.TakeClient(0)
}

This both returns nil. TestWatchErrConnClosed always returns nil error.
Am I missing anything?
Thanks!

It should happen if the grpc connection is closed before the watch client. clientv3.Close won't trigger it any more because it's closing the watch client now instead of only closing the grpc connection.
This should do it:
conn := cli.ActiveConnection()
conn.Close()
wr <- wc
// wr.Err() == closing

@heyitsanthony How about changing the test as
diff --git a/clientv3/integration/watch_test.go b/clientv3/integration/watch_test.go
index 1b544ca..4207253 100644
--- a/clientv3/integration/watch_test.go
+++ b/clientv3/integration/watch_test.go
@@ -616,18 +616,21 @@ func TestWatchErrConnClosed(t *testing.T) {
        cli := clus.Client(0)
        wc := clientv3.NewWatcher(cli)

-       donec := make(chan struct{})
+       donec, readyc := make(chan struct{}), make(chan struct{})
        go func() {
                defer close(donec)
-               wc.Watch(context.TODO(), "foo")
-               if err := wc.Close(); err != nil && err != grpc.ErrClientConnClosing {
-                       t.Fatalf("expected %v, got %v", grpc.ErrClientConnClosing, err)
+               <-readyc
+               ch := wc.Watch(context.TODO(), "foo")
+               wc.Close()
+               if wr := <-ch; grpc.ErrorDesc(wr.Err()) != grpc.ErrClientConnClosing.Error() {
+                       t.Fatalf("expected %v, got %v", grpc.ErrClientConnClosing, grpc.ErrorDesc(wr.Err()))
                }
        }()

-       if err := cli.Close(); err != nil {
+       if err := cli.ActiveConnection().Close(); err != nil {
                t.Fatal(err)
        }
+       close(readyc)
        clus.TakeClient(0)

Currently it won't return ErrConnClosing as you said.
I am still not sure how we got the context error. Will try more to reproduce.

@gyuho There's no running watchers in that example since the readyc stuff clobbers the concurrency between closing the client and creating a watch + closing the watch client. The watcher client will never see the closing error because it never tries to establish grpc stream.

Ok got it. Thanks.

Closing via https://github.com/coreos/etcd/pull/6768.
Will reopen if it happens again.

via https://jenkins-etcd-public.prod.coreos.systems/job/etcd-proxy/761/console
=== RUN   TestWatchErrConnClosed
2017-02-24 23:58:32.526682 I | integration: launching<PHONE_NUMBER>066286304 (unix://localhost:40984514280662863040)
2017-02-24 23:58:32.532204 I | etcdserver: name =<PHONE_NUMBER>066286304
2017-02-24 23:58:32.532292 I | etcdserver: data dir = /tmp/etcd959722066
2017-02-24 23:58:32.532465 I | etcdserver: member dir = /tmp/etcd959722066/member
2017-02-24 23:58:32.532532 I | etcdserver: heartbeat = 10ms
2017-02-24 23:58:32.532641 I | etcdserver: election = 100ms
2017-02-24 23:58:32.532768 I | etcdserver: snapshot count = 0
2017-02-24 23:58:32.532947 I | etcdserver: advertise client URLs = unix://<IP_ADDRESS>:2190410462
2017-02-24 23:58:32.533057 I | etcdserver: initial advertise peer URLs = unix://<IP_ADDRESS>:2190310462
2017-02-24 23:58:32.533201 I | etcdserver: initial cluster =<PHONE_NUMBER>066286304=unix://<IP_ADDRESS>:2190310462
2017-02-24 23:58:32.539270 I | etcdserver: starting member 853d55cc9f58ff55 in cluster 1ac23b84f2ded41
2017-02-24 23:58:32.539504 I | raft: 853d55cc9f58ff55 became follower at term 0
2017-02-24 23:58:32.539657 I | raft: newRaft 853d55cc9f58ff55 [peers: [], term: 0, commit: 0, applied: 0, lastindex: 0, lastterm: 0]
2017-02-24 23:58:32.539734 I | raft: 853d55cc9f58ff55 became follower at term 1
2017-02-24 23:58:32.557636 I | etcdserver: set snapshot count to default 100000
2017-02-24 23:58:32.557762 I | etcdserver: starting server... [version: 3.2.0+git, cluster version: to_be_decided]
2017-02-24 23:58:32.560362 I | raft: 853d55cc9f58ff55 is starting a new election at term 1
2017-02-24 23:58:32.560620 I | raft: 853d55cc9f58ff55 became candidate at term 2
2017-02-24 23:58:32.560788 I | raft: 853d55cc9f58ff55 received MsgVoteResp from 853d55cc9f58ff55 at term 2
2017-02-24 23:58:32.560956 I | raft: 853d55cc9f58ff55 became leader at term 2
2017-02-24 23:58:32.561386 I | etcdserver/membership: added member 853d55cc9f58ff55 [unix://<IP_ADDRESS>:2190310462] to cluster 1ac23b84f2ded41
2017-02-24 23:58:32.561759 I | raft: raft.node: 853d55cc9f58ff55 elected leader 853d55cc9f58ff55 at term 2
2017-02-24 23:58:32.565183 I | etcdserver: setting up the initial cluster version to 3.2
2017-02-24 23:58:32.566359 I | etcdserver: published {Name:4098451428066286304 ClientURLs:[unix://<IP_ADDRESS>:2190410462]} to cluster 1ac23b84f2ded41
2017-02-24 23:58:32.567303 N | etcdserver/membership: set the initial cluster version to 3.2
2017-02-24 23:58:32.570859 I | integration: launched<PHONE_NUMBER>066286304 (unix://localhost:40984514280662863040)
2017-02-24 23:58:32.588035 I | integration: terminating<PHONE_NUMBER>066286304 (unix://localhost:40984514280662863040)
2017-02-24 23:58:32.597469 I | integration: terminated<PHONE_NUMBER>066286304 (unix://localhost:40984514280662863040)
--- FAIL: TestWatchErrConnClosed (0.07s)
	watch_test.go:616: expected grpc: the client connection is closing, got context canceled

May be unique to the grpcproxy or the timing is nudged just enough to trigger it.


Please add TypeScript definitions

It would be great if this plugin was usable in typescript projects!
Consider adding it so it can be installed via (@)types/vue-progressbar

Did anyone get this working with Vue & Typescript?
I created a vue-progress.d.ts file in my project and added the following but I'm still getting issues:
import Vue from "vue";

interface ProgressMethods {
  start: void;
  finish: void;
  fail: void;
}

declare module "vue/types/vue" {
  interface Vue {
    $Progress: ProgressMethods;
  }
}

I played around with it a bit more today and came up with this which seems to have satisfied TypeScript.
vue-progressbar.d.ts
declare module "vue-progressbar" {
  import { PluginFunction } from "vue";

  export const install: PluginFunction<{}>;

  interface ProgressMethods {
    start(): void;
    finish(): void;
    fail(): void;
  }

  module "vue/types/vue" {
    interface Vue {
      $Progress: ProgressMethods;
    }
  }
}

Any updates here?

run npm install --save @types/nprogress


troubles with enums

Hi,
There is something I failed to understand with Ron and enums.
Here is what I've done :
use serde::{Serialize, Deserialize};
#[derive(Serialize, Debug, Deserialize, Eq, PartialEq)]
#[serde(from="String")]
enum EnumColors { Red, Blue }

impl Default for EnumColors {
    fn default() -> Self {
        EnumColors::Blue
    }
}

impl From<String> for EnumColors {
    fn from(txt: String) -> Self {
        EnumColors::from(txt.as_str())
    }
}

impl From<&str> for EnumColors {
    fn from(txt: &str) -> Self {
        if txt.eq_ignore_ascii_case("red") {
            EnumColors::Red
        } else {
            EnumColors::default()
        }
    }
}

#[derive(Serialize, Deserialize, Debug)]
struct Test2 {
    color : EnumColors,
}

It's really basic stuff. I deserialize a struct with an enum, and I've setup a default value for the enum to prevent any trouble with wrong values.
This works well with serde_json :
let j:Test2 = serde_json::from_str("{\"color\":\"White\"}").unwrap();
assert_eq!(j.color,EnumColors::default());

and with toml :
let t:Test2 = toml::from_str("color = \"White\"\n").unwrap();
assert_eq!(t.color,EnumColors::default());

but not with ron :
let r: Test2 = ron::from_str("(color:White)").unwrap();
assert_eq!(r.color,EnumColors::default());
`Result::unwrap()` on an `Err` value: Error { code: ExpectedString, position: Position { line: 1, col: 8 } }'

I've probably missed something obvious, but I can't see what.

So either remove the #[serde(from="String")] (which I don't why you would need that, because that's what happens in json and toml automatically) or change your RON input to use strings in place of enum values.

That's expected because you only use #[serde(from="String")], but not the counter part (into).


Move building "latest" Docker images to GitHub action

I didn't break the CircleCI config so this is good to go. Merging.


Review list features shown in 'non-native' kube views

Neil has requested we review the list features provided in more 'non-native' areas such as the Users & Auth product

For instance the Download action available for user's in the auth product (see rancher/dashboard#2526 and rancher/dashboard#2648)

The debate seems to revolve around showing users a feature rich yet busy list experience vs a clean more user welcoming one.
The outcome here might be to have a setting to show 'advanced' features

@richard-cox I noticed this issue is over a year old - does this still apply to v2.7?

@catherineluse yes


Add Vietnamese language

Hi @phund, thanks for the translation. It is available since the 1.5.1 release.
Cheers.


Clarify how to do a standalone docker build

The dockerfiles assume that we are two levels up from where they actually live. This can be confusing for a first time user expecting a docker build to work from inside that directory. This simply clarifies how to do such a build.
Pull Request Checklist

[ x] If this is your first time contributing, we recommend you read the Code
Contribution Guidelines
[ x] All changes are Go version 1.11 compliant
[ x]  The code being submitted is commented according to the
Code Documentation and Commenting section
[ x]  For new code: Code is accompanied by tests which exercise both
the positive and negative (error paths) conditions (if applicable)
[ x]  For bug fixes: Code is accompanied by new tests which trigger
the bug being fixed to prevent regressions
[ x]  Any new logging statements use an appropriate subsystem and
logging level
[ x]  Code has been formatted with go fmt
[ x]  For code and documentation: lines are wrapped at 80 characters
(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
[ x]  Running make check does not fail any tests
[ x]  Running go vet does not report any issues
[ x]  Running make lint does not report any new issues that did not
already exist
[ x] All commits build properly and pass tests. Only in exceptional
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.
[ x] Commits have a logical structure ([see section 4.5, of the Code Contribution Guidelines])

If you're looking to only build the lnd image, there are instructions here: https://github.com/lightningnetwork/lnd/blob/master/docs/DOCKER.md
Also, checkout out https://github.com/lightningnetwork/lnd/pull/2520/files

and https://github.com/lightningnetwork/lnd/pull/2559

Taken over and replaced by #4790, original commit attributed to this PR's author.


replication or sharding?

Hello,
I am interested in Cete for possible use in a highly-scalable P2P system and was wandering if Cete does replication or horizontal-scaling or both?

@lonnietc
There are no plans to do so yet...


Update Random.h

Valid for Clang Compiler

+1, this fixes Issue #14.

+1 for this change. Got the code compiling in Xcode 11.5. I've even got it integrated with Swift.

This needs to get merged, spent over an hour googling around until i realized this pr fixes the problems

Tested on macOS 12.6.2 (21G320)
$ c++ -v
Apple clang version 14.0.0 (clang-14<IP_ADDRESS>)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
$ make
$ ./test | tail -1
Done.


Can't visit master and worker web page

Alluxio Version:
What version of Alluxio are you using?
alluxio version -r
2.5.0-SNAPSHOT-797ece179773a1c559fb7898f81dc606fc7f8946

Describe the bug
A clear and concise description of what the bug is.
When i run alluxio in macos local, i can't visit master and worker , and i already set alluxio.web.ui.enabled=true in alluxio-site.properties
To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
git clone https://github.com/Alluxio/alluxio.git
cd alluxio
sudo mvn -T 32C clean install -DskipTests -Dmaven.javadoc.skip -Dfindbugs.skip -Dcheckstyle.skip -Dlicense.skip
./bin/alluxio-start.sh local SudoMount

$ ./bin/alluxio fsadmin report
Alluxio cluster summary:
    Master Address: localhost:19998
    Web Port: 19999
    Rpc Port: 19998
    Started: 03-05-2021 17:50:22:248
    Uptime: 0 day(s), 0 hour(s), 11 minute(s), and 40 second(s)
    Version: 2.5.0-SNAPSHOT
    Safe Mode: false
    Zookeeper Enabled: false
    Live Workers: 1
    Lost Workers: 0
    Total Capacity: 10.67GB
        Tier: MEM  Size: 10.67GB
    Used Capacity: 0B
        Tier: MEM  Size: 0B
    Free Capacity: 10.67GB

Expected behavior
can visit web
Urgency
Describe the impact and urgency of the bug.
It's not too urgent.

Will close it for now, feel free to reopen it and contact us if this is still valid.


[mempool][documentation] Fixed line break in mempool README.md

Urgent fix needed for 'Zero day notice SEV1 hotfix drill'
https://libra.pagerduty.com/incidents/PWTBYPW
There is an unacceptable line break in the documentation!
Test Plan
CI and manual checking

/land

/land


font type used in oncoplot

Question
Could you please let me know the font type used in oncoplot genename and frequency %? I will be adding some text next to it. Just want to be consistent.
Session info
R version 4.1.0 (2021-05-18)
maftools_2.17.0

Thanks,
Praveen

Hi,
it uses base font family. I believe it's Helvetica - italicised for gene names.


etcdserver: add version enforcement when setting cluster version

Fix https://github.com/coreos/etcd/issues/2716
When setting the cluster version, we detect if the current etcd binary version is at lease as new as the cluster version. Or we can safely know that this etcd member has been started with a newer version of binary and its cluster version has been upgraded. We do not allow downgrade at the moment.
Manually tested. Worked.

@yichengq We now print out the full etcd binary version in current version. PTAL.

lgtm


Enabling remote access breaks struct serialization

Hi there,
I noticed that enabling remote access in the API (VNC console in the control panel) seems to completely break JSON serialization for server details, and instead of an error, only an empty struct is returned. Following example works well when remote access is disabled, but enabling it causes the JSON serialization to fail.
package main

import (
	"fmt"

	"github.com/UpCloudLtd/upcloud-go-api/upcloud/client"
	"github.com/UpCloudLtd/upcloud-go-api/upcloud/request"
	"github.com/UpCloudLtd/upcloud-go-api/upcloud/service"
)

func main() {
	api := service.New(client.New("username", "password")
	server, err := api.GetServerDetails(&request.GetServerDetailsRequest{UUID: "server_uuid"})
	if err != nil {
		fmt.Println(err)
	}
	fmt.Printf("%+v\n", server)
}

I looked at the relevant code and error from json.Unmarshal is left unhandled. Thus, no error is returned to the code utilizing GetServerDetails when serialization fails.
Besides this problem, the upgraded API bindings seem amazing and it's been working perfectly for me. Thank you!

Added error handling in this commit. Also the underlying type error is being fixed in the main API.


Add icons for the new GPU particle attractor and collision nodes

See #46056.
I also have a design for GPUParticlesAttractor3D which I didn't commit here as we decided not to add icons for abstract classes for now: GPUParticlesAttractor3D.zip
Not cherry-pickable to the 3.2 branch since these nodes are new in master.
Preview
100% editor scale.

Thanks!


ReadApi\Item: Retrieve all items

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
partially #80

License
MIT

What's in this PR?
Use the client->getIterator method to retrieve all items, not only the first 50 items (first page).
Why?
During the synchronization, only the first 50 articles have been synced.
To Do
I did a search and it appears that besides the manufactures and now the articles/items, no requests makes use of client->getIterator. This will probably lead to problems, if there are more entities of one kind (e.g. categories).

Hi,
thanks for contributing to our new plentyconnector. I will check the other handlers today.
Greetings,
Jochen


Add cleveland heart disease dataset

http://archive.ics.uci.edu/ml/datasets/Heart+Disease
http://archive.ics.uci.edu/ml/machine-learning-databases/heart-disease/
the cleve.mod file I guess

@xinyuejohn is this done? Or was the dataset bad? I forgot...

Already done