Fresh conda-forge based install unable to import samgeo.

Environment Information

samgeo version: 0.7.0
Python version: 3.10.11
Operating System:  MS Windows Version 22H2 (OS Build 22621.1702)
Visual Studio Code: Version 1.78.2

Description
I want to run samgeo for some planet data. I did a fresh install using conda-forge and mamba. I'm using the input prompt example as a guideline.. This fresh install is failing to call rasterio due to a DLL failure, which I think is related to a rasterio-gdal conflict (conda-forge/rasterio-feedstock#240). Maybe related to #53.
I tried the pip install version but got the MS Visual Studio C++ error documented in the QGIS-SAM plugin FAQ and don't want to install the 9 GB VS C++ development kit if I can avoid it.
P.S. GREAT WORK!
What I Did
In command line:
`mamba create -n samgeo segment-geospatial python leafmap -c conda-forge`

In visual studio code:
import os
import leafmap
from samgeo import SamGeo, tms_to_geotiff

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Untitled-1 in line 4
      [2](untitled:Untitled-1?line=1) import os
      [3](untitled:Untitled-1?line=2) import leafmap
----> [4](untitled:Untitled-1?line=3) from samgeo import SamGeo, tms_to_geotiff

File [~\.conda\envs\samgeo\lib\site-packages\samgeo\__init__.py:8](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/__init__.py:8)
      [4](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/__init__.py?line=3) __email__ =<EMAIL_ADDRESS>      [5](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/__init__.py?line=4) __version__ = '0.7.0'
----> [8](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/__init__.py?line=7) from .samgeo import *

File [~\.conda\envs\samgeo\lib\site-packages\samgeo\samgeo.py:11](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py:11)
      [8](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=7) import numpy as np
      [9](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=8) from segment_anything import sam_model_registry, SamAutomaticMaskGenerator, SamPredictor
---> [11](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=10) from .common import *
     [14](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=13) class SamGeo:
     [15](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=14)     """The main class for segmenting geospatial data with the Segment Anything Model (SAM). See
     [16](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=15)     https://github.com/facebookresearch/segment-anything for details.
     [17](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/samgeo.py?line=16)     """

File [~\.conda\envs\samgeo\lib\site-packages\samgeo\common.py:13](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/common.py:13)
     [11](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/common.py?line=10) import shapely
     [12](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/common.py?line=11) import pyproj
---> [13](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/common.py?line=12) import rasterio
     [14](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/common.py?line=13) import geopandas as gpd
     [15](file:///~/.conda/envs/samgeo/lib/site-packages/samgeo/common.py?line=14) import matplotlib.pyplot as plt

File [~\.conda\envs\samgeo\lib\site-packages\rasterio\__init__.py:28](file:///~/.conda/envs/samgeo/lib/site-packages/rasterio/__init__.py:28)
     [24](file:///~/.conda/envs/samgeo/lib/site-packages/rasterio/__init__.py?line=23)                     os.add_dll_directory(os.path.abspath(p))
     [27](file:///~/.conda/envs/samgeo/lib/site-packages/rasterio/__init__.py?line=26) from rasterio._show_versions import show_versions
---> [28](file:///~/.conda/envs/samgeo/lib/site-packages/rasterio/__init__.py?line=27) from rasterio._version import gdal_version, get_geos_version, get_proj_version
     [29](file:///~/.conda/envs/samgeo/lib/site-packages/rasterio/__init__.py?line=28) from rasterio.crs import CRS
     [30](file:///~/.conda/envs/samgeo/lib/site-packages/rasterio/__init__.py?line=29) from rasterio.drivers import driver_from_extension, is_blacklisted

ImportError: DLL load failed while importing _version: The specified procedure could not be found.

Just fixed this by pinning the python version to 3.9 based on #53. Can now load/import samgeo. Recommend updating docs on installation to pin the conda-forge installation to Python 3.9. Can PR it if you like.
What I did
mamba create -n samgeo segment-geospatial python==3.9 leafmap -c conda-forge

What new docs should be
conda install -n base mamba -c conda-forge
mamba create -n geo segment-geospatial python==3.9 -c conda-forge```

Thanks for reporting. This is probably an issue specific to Windows. The CI seems working fine for Python 3.9-3.11 on Linux. https://github.com/opengeos/segment-geospatial/actions/workflows/ubuntu.yml

Fixed in #77


How is Resource Reaper signalled at the end of tests?

Hi,
I appreciate a question may not be an accepted issue for this project, so apologies in advance if that's the case here.
I spent quite some time trying to understand how Resource Reaper is used to clean up containers and I fail to see how it kicks in at the end of tests. As far as I can see, Resource Reaper is run when a container is started, and it is given the containers to clean at that point. So what stops it from cleaning the containers before the tests are run?
In other words, can you point me at the location in the code that ensures Resource Reaper is invoked only once the tests are complete? I can keep digging into the code but you'd be saving me a lot of time if you could just hint at the correct direction.
Many thanks for such a nice library by the way!

So what stops it from cleaning the containers before the tests are run?

You don't know which resources you need to remove. Even if you label resources from previous runs, you don't know exactly what to remove. Especially if you run multiple tests parallel. In addition to that, it's better to remove resources right away and not within the next start. Removing old resources sounds easy, but there are a lot of use cases to consider.

In other words, can you point me at the location in the code that ensures Resource Reaper is invoked only once the tests are complete?

You can run multiple Resource Reapers in different sessions, but there is always a default Resource Reaper through a singleton. Ryuk (the Docker image of the Resource Reaper) holds a network connection. If this connection is dropped (test process ends) Ryuk removes all resources within this session.

@HofmeisterAn I went through the code after some coffee (magic ingredient ;) ) and just came back to ask if my understanding is correct: it's the infinite loop in MaintainRyukConnection : Ryuk's behaviour is to keep a container alive unless it was queried/accessed for 10 seconds (hard coded in its source code btw, I think), so once the test is completed, Ryuk times out and removes the connections.
Many thanks for such a prompt response. Much appreciated.

Ryuk's behaviour is to keep a container alive unless it was queried/accessed for 10 seconds

To prevent misconceptions. .NET Testcontainers creates and holds a network connection to Ryuk. If this connection drops for more than 10 seconds, Ryukt starts to clean up.


Add atgo-style zooming when term is selected in search bar

For clixo, when user types SLA1, ontology should zoom to show gene

This is not possible because there is no genes in this version.  All of the nodes in the main view are terms, not genes.


[Accessibility]A11y_PowershellEditorServices_Installation_Screenreader:NVDA reads the Tab item control type as Button for the "Details,Contributions,Changelog,Dependencies".

Environment Details:
VSCode Version : 1.25.1
OS Version : Win10,NVDA[2018.2]
MAS1.3.1
Repro Steps:
1.Launch Visual Studio code desktop application.
2.Navigate to "Extension" button of "ActivityBar"->Enter "PowerShell" in "Search Extension" text field and click on "Install" button.
3.Navigate through keyboard such as "Tab" key.
4.Observed that what NVDA reads for the Tab item.
Actual:
NVDA reads the tab item as button for "Details,Contributions,Changelog,Dependencies".
Expected:
NVDA should read the control type as Tab item for "Details,Contributions,Changelog,Dependencies".
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
User will not able to know the correct control type.
MAS Reference:
MAS1.3.1
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Does this issue occur when all extensions are disabled?: Yes
Attachment for Reference:

Should be fixed in latest vscode


why mode='a' is preferred?

Just curious. I noticed in asdf_data_set.py, in __init__(), you wrote:
        :param mode: The mode the file is opened in. Passed to the
            underlying :class:`h5py.File` constructor. pyasdf expects to be
            able to write to files for many operations so it might result in
            strange errors if a read-only mode is used. Nonetheless this is
            quite useful for some use cases as long as one is aware of the
            potential repercussions.
        :type mode: str

Not sure what you mean exactly here...
For example, for the data processing procedure, I will read the raw data and write the processed data into a new file. For the window selection, I will read the observed data and synthetic data, and write out windows. None of them modify the input asdf file. So is it safe to use mode='r' or still better to use mode='a'?

Yes of course. If you only read I would strongly recommend to use mode="r". The documentation should probably be a bit clearer in the documentation. You only need to open it in a writable mode if you modify the file.

Got it. Thanks.


feat(ui): migrate theming to chakra ui

looks like this #2814 was reverted accidentally. instead of trying to revert the revert, this PR can simply be re-accepted and will fix the ui.

Migrate UI from SCSS to Chakra's CSS-in-JS system

better dx
more capable theming
full RTL language support (we now have Arabic and Hebrew)
general cleanup of the whole UI's styling

Tidy npm packages and update scripts, necessitates update to github actions

To test this PR in dev mode, you will need to do a yarn install as a lot has changed.
thanks to @blessedcoolant for helping out on this, it was a big effort.

The mobile UI no longer reflows to single column with this change. Is that intentional?

@neecapp  yes, insofar as this is the unstable main branch you are on. User-facing release is on branch v2.3 while we doing some major works on main.
Need to redo the responsive design stuff still.

:+1: Yes, I know.
Just wondering, since there wasn't any mention of future work or things that were intentionally not addressed that will have follow-on work in the original PR description.

@neecapp sorry, you're right, should have mentioned this as a breaking change. will get it re-implemented soon, maybe tonight.


add Somtochi's lightning talk from GitOpsCon

Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>

Nice work @SomtochiAma


Create messages_ko.py

Thanks for providing this translation. It would be helpful if you can confirm that you have tested these changes in both the installer and the client and that they work as expected. Build for this pull request can be found at: https://github.com/Syncplay/syncplay/actions/runs/4331596259

@MarongHappy Thanks for providing this translation. I've made a few tweaks to get it to work which are at https://github.com/Syncplay/syncplay/actions/runs/4407706296
It would be helpful if you can confirm that you have tested these changes in both the installer and the client and that they work as expected when using the Korean language mode. Can you please test: https://github.com/Syncplay/syncplay/actions/runs/4407706296

The translation is now included in Syncplay 1.7.0 RC 1: https://syncplay.pl/syncplay-1-7-0-release-candidate-1/


sidecars

Describe the bug
The Dockerfile seems to be including the k8s sidecars here:
https://github.com/topolvm/topolvm/blob/master/Dockerfile#L19-L23
But you can use the existing sidecar containers directly in your manifests so they can be cached better when drivers are involved.

We intentionally bundle the sidecar images for better integrity.
If a user wants to use other images for sidecars, they can do so by modifying the manifests.
With kustomize, the following patch replaces the csi-provisioner sidecar image.
apiVersion: apps/v1
kind: Deployment
metadata:
  name: controller
  namespace: topolvm-system
spec:
  containers:
    - name: csi-provisioner
      image: quay.io/k8scsi/csi-provisioner:v1.6.0

Yes, that would work, but it does include all the other drivers in the consumed storage whether you are using it or not. Maybe an option for a "light" version of the container without the extra drivers would work?

Sounds good to me!  Opinions? @zoetrope @satoru-takeuchi @llamerada-jp

I agree to create a "light" version of the container.

It sounds good to me too.

I would like to provide the following two images

topolvm: an image that contains only the smallest components, as you suggest.
topolvm-with-sidecars: An image that contains sidecars, as currently provided.

However, it will take some time to do.


Expander Button should be on the right side

As per google's design, Expansion Panels should have the expand button to the right of the header. Perhaps this could be configurable so the user could choose to have it on either the right or left side?


Revising: Mixing of Control and Data Flow & Pausing

The "Mixing of Control and Data Flow" should be before the "Pausing" section, as the Pausing section uses the concepts of Control Flow and Data Flow. The "Mixing of Control and Data Flow" should be enhanced to have a diagram, to help more clearly explain what is meant by Control Flow and Data Flow.

This issue is being resolved in this PR: https://github.com/CrosschainRiskFramework/CrosschainRiskFramework.github.io/pull/16

In my PR I have:

I have provided a real world example of issues when the proposed advice has not been taken. I think having real world examples will help people to understand the importance of a particular idea.
For the examples, I linked to the analysis by rekt.news . I feel that this is a reliable source of detailed analysis that is likely to be around for some years.
When referring to "hacks", I have only called them "issues". I feel that this is less inflammatory.


[Feature]

Summary
A clear and concise description of what the problem is, and what you solution you want.
Changes
What changes this feature would introduce. Any risks these changes involve. Any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hey there,
Thanks for reaching out and sharing your request with us. I've gone through
the email thread and I understand that you're looking for a clear and
concise description of the problem, along with the desired solution.
I am definitely interested in helping you with this. Could you please
provide me with more information about the changes you're looking to
introduce and any risks involved? Additionally, feel free to share any
alternative solutions or features you've considered.
Please let me know if there's any additional context or screenshots that
would be helpful.
Looking forward to hearing from you!
Cheers,
Mwangi
On Fri, Sep 22, 2023 at 4:31 PM yunfang689 @.***> wrote:

Summary
A clear and concise description of what the problem is, and what you
solution you want.
Changes
What changes this feature would introduce. Any risks these changes
involve. Any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
—Reply to this email directly, view it on GitHub
https://github.com/skills/introduction-to-github/issues/514, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BBHHDL25I5LAYDICWNSIKTLX3WHKNANCNFSM6AAAAAA5DDXT3I.You
are receiving this because you are subscribed to this thread.Message ID:
@.***>


replaced the discussion about superheating/supercooling with one about transitions

@andreistefanescu please revise this now, as it is hot

lgtm

fixed everything, tests passed, ready to merge


Fix steam ID in update check

Previous ID offered updates for Rust Dedicated Server (https://steamdb.info/app/258550/) instead of 7 Days to Die Dedicated Server (https://steamdb.info/app/294420/ )

Nice catch!


Dockerfile / Docker-Compose

Hi guys,
Do you have a dockerfile to test your script with an optimized environment (Docker alpine ) ?
Cheers,
Luc Michalski

Nope. But we'd love one if you have the time!


SADeprecationWarning

renamed dbapi() to import_dbapi()
requires SQLAlchemy 2.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hello @PRICEKRAKEN, is this change backwards compatible with SQLAlchemy 1.4? questdb-connect supports both 1.4 and 2.x


yii Migration alterColumn error

What steps will reproduce the problem?
Use the migration $this->alterColumn function to change a column in your db.
What is the expected result?
What do you get instead?
'SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near
Additional info
I drilled down to see what was going on in the QueryBuilder.php class and I noticed that the $this->db->quoteColumnName($column) was duplicated. in line 472
` return 'ALTER TABLE ' . $this->db->quoteTableName($table) . ' CHANGE '
        . $this->db->quoteColumnName($column) . ' '
        . $this->db->quoteColumnName($column) . ' '
        . $this->getColumnType($type);`

Q
A

Yii version
2

PHP version
5.6

Operating system
ubuntu

Use the migration $this->alterColumn function to change a column in your db.

Could you show you code?

Hi @SilverFire
 $this->alterColumn('mda', 'isSubUnitEnabled', "is_sub_unit_enabled ENUM('True','False') CHARACTER SET latin1 COLLATE latin1_swedish_ci  NULL DEFAULT NULL");

alterColumn can not rename a column, the second argument is only the column type without the name.

Hi @SilverFire
 $this->alterColumn('mda', 'isSubUnitEnabled', "is_sub_unit_enabled ENUM('True','False') CHARACTER SET latin1 COLLATE latin1_swedish_ci  NULL DEFAULT NULL");

@cebe, well I simply commented out the second duplicate $this->db->quoteColumnName($column) .
and it worked out all well :)


new version 271217 causes vertical outline irregularity?

HI,
Is this introduced with the latest update or did i miss this before : vertical alignment of entity icons and name is now not correct, (entity value on the right is ok) and seems to count on another line of text?
wrong looks:

other example:

right looks:

if no second line of extra data is needed, the entity name next to the icon would be better vertically aligned .
Thanks,
Marius

Thanks for the report - I pushed a fixed version yesterday (I kept the name 271217)


HtmlUnit compability

I use HtmlUnit to prerender ionic SPA. All works fine except this polyfill. If i render page through HtmlUnit then exception occurs:
 TypeError: Cannot call method "indexOf" of undefined (line 33)

Going to close since htmlunit support isn't in scope and I don't think that should be a necessary fix :/. Thanks for the PR though!


Profiler - memories/processors/affinity

From Mike  -  Move to a mode where the profiler just logs new processors and memories as it sees them so that we get them in the logs even in the case where we don't exit cleanly - the downside to this approach is that it requires a fast check to see if we already have seen the name of the processor or memory

Fixed with commit e4432e8


Handle Range restrictions in SemTK

I'll need some help with this from @AbhaMoitra et. al. on better organizing and defining this task.
#1  for datatype restrictions (e.g. DAL is a type of int [0,9]. ) help assembling a full definition of what SADL allows for restrictions.
#2 for range restrictions on object properties
a. split to another issue
b. again, what is legal (e.g. only specfiic sub-type(s) of the parent definition),  can they be complex (e.g. parent says range is Animal, and subtype says Dog or Cat or Mouse)
c. should we hunker down and do the whole complex Range of data properties first.   Several week effort, but Jan-Feb 2022 might be an opportune time to tackle it.

@cuddihyge : Sure. Can you set up a call to discuss this.

SparqlGraph is throwing an error when we tried to correct a nodegroup where it is using the parent of the correct class. @cuddihyge has an example.

I believe this was fixed in semtk commit March 11  e5fb84bb468863daecd687f1976c0c7349316689
which went into semtk release 03/11 and RACK 10.0.


no work

win10/amd rx 6900xt
launched both exes, nothing

yus
On Tue, Sep 14, 2021, 4:35 PM everelw @.***> wrote:

Did you unzip it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/elizabwth/win-shader-wallpaper/issues/2#issuecomment-919583926,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABICQCSKQIDFNUU7L2IC6LLUB7L3PANCNFSM5EAJ5TYA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@ottworks hmm... I have some ideas. Will get back to you upon next release


Add tiny maccalc helper tool

This adds a tiny helper tool for handling MAC addresses in user-space.
It can be helpful during manufacturing process and in scripts when updating e.g. PIBs or similar stuff.

General question: it was intended that you contribute via your private mail address?

General question: it was intended that you contribute via your private mail address?

Preparation and initial testing was done outside of working hours. Will change the SoB in edited commits.


[experiment] direct imports

/** @todo */

[x] enable Debug in the scanner/semver modules
[x] enable Debug in the core

Very exciting that this works! I have yet to review it and take a look at what it does in the bundle, but you basically did all of the hard work for us...

There is still an open question with Debug that causes circular imports...

There is still an open question with Debug that causes circular imports...

Can you remind me again what breaks? Though there are some circular things, I don't know that any should crash at this point, besides one scanner thing which can be fixed by moving a helper to another file.
Solving circular imports entirely is a further PR just because that will involve a lot of code moving, but eliminating internal _namespaces imports is one step that lets us start running proper tooling to analyze these cycles.

Can you remind me again what breaks?

Currently, there are approximately 10 _circular dependencies, however, core <-> debug is the circular dependency that
breaks the build, need to investigate this dependency, and other dependencies that import core, and debug. We need to revise the module hierarchy - core is the top module, but it depends on debug, which depends on core, utilities (depends on core and debug), etc. :).

I want to preemptively give this feedback (pending a full review once the beta is out; I'm planning on talking about this PR in an upcoming design meeting); I don't think we should move any of our major files in this PR. I would leave checker.ts, emitter.ts, etc, in place, and then add checkerUtilities.ts or similar where needed in the compiler folder. I'd like this to be as minimal of a PR as possible, just code moves and maybe a few new files where required.

It's also less of a goal to get the tests to do direct imports; just getting the core projects (compiler, services, server, deprecatedCompat, executeCommandLine) would be sufficient as a first good step.

We talked about this at the most recent design meeting; it looks like we're going to take this PR (once it's reviewed and such).
I plan to give this a review post-beta once I'm not scrambling again, but the Debug namespace PR will go first to simplify this one down to just code moves.
Unfortunately I totally forgot to get an answer the Node 12 thing so I'll have to recheck that later.

I also want to merge #52090 and potentially a lint rule for vertical imports too, which should make these changes hopefully easier to manage.

I also want to merge https://github.com/microsoft/TypeScript/pull/52090

Sure., I usually try to keep this PR up to date, so I'll merge conflicts.

We talked about this at the most recent design meeting; it looks like we're going to take this PR (once it's reviewed and such).

It can be used as a starting point for migration, feel free to add your suggestions. Just for context: most of the new files were created to eliminate circular dependencies.

With 5.0 coming out soon, I'd like to try and relook at this to get it in for 5.1 (especially as some amount of this is a prereq for me to test out TS-as-ESM); one thing I'm immediately unsure of is all of the extra utility files being created, especially checkerUtilities.ts; are these strictly required to make the code work? Could some be moved to other files instead, or kept in the checker?
I know that there is some code that should be shifted out of the scanner (or something), but, if they're being created solely to fix cycles, I'm wondering if we'd be better off doing that at a second step to minimize the diff a little.
I'm also planning on sending another partial change that will make this PR smaller, namely, trying something to get rid of most of the _namespaces imports as possible, the ones we can do early.

especially checkerUtilities.ts; are these strictly required to make the code work? Could some be moved to other files instead, or kept in the checker?

(minor) Moving the types to checkerUtilities is necessary to avoid importing the checker into Debug, which causes additional circular imports.
(major) Some files (convertToAsyncFunction.ts, moveToNewFile.ts, symbolWalker.ts, etc.) depend on the getNodeId/getSymbolId utilities, which are not part of TypeChecker. Importing the checker (which includes a lot of other dependencies) into these files causes a crash.

I know that there is some code that should be shifted out of the scanner (or something), but, if they're being created solely to fix cycles

If we are talking about the scanner, some files use utilities (especially files that depend on core/debug/compiler/utilities) from it, which causes circular imports and crashes.

I'm also planning on sending another partial change that will make this PR smaller, namely, trying something to get rid of most of the _namespaces imports as possible, the ones we can do early.

Sounds promising :). Maybe we need to try breaking it up into smaller pieces, however, I'm not sure how granular they should be. Maybe we need to split file by file, however, that adds a lot of new PR and as I recall some cases can't be refactored without touching many files.

getNodeId and getSymbolId can definitely be moved to utilities or something and be fine; I think I'd prefer the most minimal change possible for this.

Ok, I'll try to move these helpers to utilities. What about types? I think it would be better to avoid using checker in debug.

I would think they can be moved to types.ts.


sed: invalid option -- E

$ sed --version
GNU sed version 4.1.5
$ cat /etc/redhat-release
CentOS release 5.8 (Final)

$ cut -c3- ~/.tmux.conf | sh -sx _apply_configuration
...
$ sed: invalid option -- E
...

when using the old versions sed < 4.2, sed is not supported -E yet.
According to http://blog.dmitryleskov.com/small-hacks/mysterious-gnu-sed-option-e/ , it seems like the option -r == -E
There was similar issue reported:
https://github.com/fisherman/getopts/issues/12
https://github.com/rvm/rvm/issues/1410
https://github.com/c9/core/issues/346

Thanks, will look into it

osx 10.13 also same problem
/Users/laputa/.tmux.conf:102: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:105: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:106: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:107: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:114: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:115: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:116: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:117: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:129: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:130: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:131: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:132: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:133: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:134: usage: bind-key [-cnr] [-T key-table] key command [arguments] /Users/laputa/.tmux.conf:11: invalid option: q

update master branch, will be resolve this error (:

@motecshine This issue is related with a sed version, not a tmux command.

Hello @motecshine,
What you pasted doesn't seem related to sed not supporting the -E option (which is macOS specific and you're running macOS 10.13).
So? Are you still having problems?

@gpakosz  thks a lot , i remove .tmux .tmux.conf dir and reclone this repo,resolved my ploblem

Hey @blackb1rd 👋
Honestly, I don't know if it's worth the hassle supporting CentOS < 6 by now 🤷♂

Hi @gpakosz  :wave:,
I think, it may not worth to support CentOS < 6 but I'm not sure if it's worth to make the compatibility with old versions sed < 4.2.

macOS stock's BSD sed doesn't support -r, so... supporting both will add more tests everywhere

Are there many OS distributions that currently use GNU sed < 4.2? In any case those won't have a recent tmux version either and I'm about to raise the minimum required version to 2.4

Are there many OS distributions that currently use GNU sed < 4.2?

I think, not many OS distributions is using GNU sed < 4.2 and there is a Red Hat Enterprise Linux 6.

Hey @blackb1rd 👋
Can you please try the gh-150 branch if you're still running OS distributions for which GNU sed < 4.2 by chance?

Hi @gpakosz
I tried the  gh-150 branch and it works fine. :thumbsup:

So on CentOS 5.8?

Yes.

@blackb1rd awesome, thanks testing 🙏
I'll merge the branch soon.


End crystal pillars not resetting correctly when resummoning end dragon

When resummoning the end dragon, the pillar reset script is causing new pillars to spawn on top of the old ones instead of just resetting them like normal. This causes each dragon respawn to make the pillers taller and taller.

Duplicate of #245


Menu camera scale can be changed

Load a level
(send '(game level fly))
Change the scale
(send '(game menu))

Observe that the scale of the menu camera has changed

The bug is not reproducible anymore


Remove Python 2 support

Fixes: https://github.com/quantumlib/Cirq/issues/1372

Remember to update python_requires in setup.py.

@hugovk I've re-committed your suggestion. Could you please sign the CLA? Thank you.

✅ Already signed, https://cla.developers.google.com/clas gives Feb 18, 2017 06:17 PST as the date signed.

We always have to manually override CLA bot in cases with multiple authors. I'll take care of it when it comes time to merge.

@Strilanc Please let me know if I've missed any.

Closed: https://github.com/quantumlib/Cirq/issues/1372


'extra' data overwritten after payment, when webhook is present

Given a request with a webhook url present and the extra tag is filled
When the invoice is paid, the extra data is overwritten, and initial data is gone.
Steps to reproduce:
Create a satspay request with the following body:
{
  "lnbitswallet": "***",
  "name": "Test1",
  "description": "Test1",
  "webhook": "https://webhook.site/40dca456-0eb9-48cf-b52a-36f82fd99940",
  "completelink": "string",
  "completelinktext": "Back to Merchant",
  "custom_css": "string",
  "time": 1440,
  "amount": 100,
  "zeroconf": false,
  "extra": "{\"product\": \"btc\"}"
}

When you retrieve the charge, before paying it the 'extra' data is returned.
When you retrieve the charge after it's paid, the extra data is gone. It's replaced by the webhook result
Additional:
When you request the example, without the webhook data the extra data is shown, even after the payment

Just checked on legend, but there it's still reproducible. To be clear, It's about the extra data at charge level, not at invoice level.
I started with the request from the example above. The call to the url below results in the response
https://legend.lnbits.com/satspay/api/v1/charge/DfxFXQQ9FGtk4z2AW2mZ3R
{
  "id": "DfxFXQQ9FGtk4z2AW2mZ3R",
  "name": "Test1",
  "description": "Test1",
  "onchainwallet": null,
  "onchainaddress": null,
  "lnbitswallet": "b7171e77ee1a4c639c3d427d114a87f9",
  "payment_request": "lnbc10n1pjafq24sp5yku3d79h3mzn3x94d6u3mnhewym9hvvfrkf4hvuq24umlag328espp5c2s098qvtyqsd670g6ylau3v57tk878ujwyjwfxh406etz09vvysdqg23jhxap3xqyz5vqcqpjrzjq2t02g8hdr7y9zzuextve490q2s4wfsx8m5twdn5dalltql2ct8syrrlguqqncsqqyqqqqqqqqqqqpgq9q9qxpqysgquy7f4ccndn2glcjm4t0kpwm5ucxamypk6u3np4ax669zr2r94as4cvqy365xr29f38xl4yrqqphswtk58luhffjx8tdu0p0f2mee3pcqdar44p",
  "payment_hash": "c2a0f29c0c590106ebcf4689fef22ca79763f8fc93892724d7abf59589e56309",
  "webhook": "https://webhook.site/40dca456-0eb9-48cf-b52a-36f82fd99940",
  "completelink": "string",
  "completelinktext": "Back to Merchant",
  "custom_css": "string",
  "extra": "{\"product\": \"btc\"}",
  "time": 1440,
  "amount": 1,
  "zeroconf": false,
  "balance": 0,
  "pending": 0,
  "timestamp":<PHONE_NUMBER>,
  "last_accessed_at":<PHONE_NUMBER>,
  "time_elapsed": false,
  "time_left": 1439.8,
  "paid": false
}

After the payment the result is:
{
  "id": "DfxFXQQ9FGtk4z2AW2mZ3R",
  "name": "Test1",
  "description": "Test1",
  "onchainwallet": null,
  "onchainaddress": null,
  "lnbitswallet": "b7171e77ee1a4c639c3d427d114a87f9",
  "payment_request": "lnbc10n1pjafq24sp5yku3d79h3mzn3x94d6u3mnhewym9hvvfrkf4hvuq24umlag328espp5c2s098qvtyqsd670g6ylau3v57tk878ujwyjwfxh406etz09vvysdqg23jhxap3xqyz5vqcqpjrzjq2t02g8hdr7y9zzuextve490q2s4wfsx8m5twdn5dalltql2ct8syrrlguqqncsqqyqqqqqqqqqqqpgq9q9qxpqysgquy7f4ccndn2glcjm4t0kpwm5ucxamypk6u3np4ax669zr2r94as4cvqy365xr29f38xl4yrqqphswtk58luhffjx8tdu0p0f2mee3pcqdar44p",
  "payment_hash": "c2a0f29c0c590106ebcf4689fef22ca79763f8fc93892724d7abf59589e56309",
  "webhook": "https://webhook.site/40dca456-0eb9-48cf-b52a-36f82fd99940",
  "completelink": "string",
  "completelinktext": "Back to Merchant",
  "custom_css": "string",
  "extra": "{\"mempool_endpoint\": null, \"network\": null, \"webhook_success\": true, \"webhook_message\": \"OK\", \"webhook_response\": \"This URL has no default content configured. View in Webhook.site.\"}",
  "time": 1440,
  "amount": 1,
  "zeroconf": false,
  "balance": 1,
  "pending": 0,
  "timestamp":<PHONE_NUMBER>,
  "last_accessed_at":<PHONE_NUMBER>,
  "time_elapsed": false,
  "time_left": 1438.4166666666667,
  "paid": true
}

How did you initially set "extra": "{\"product\": \"btc\"}",?

The extra field is not a generic dict, but a strongly typed class:
class ChargeConfig(BaseModel):
    mempool_endpoint: Optional[str]
    network: Optional[str]
    webhook_success: Optional[bool] = False
    webhook_message: Optional[str]

But your usecase is valid. I have added a misc field to extra. In misc one can store any random data.
Will be out on the next release:
https://github.com/lnbits/satspay/releases/tag/v0.2.7

But your usecase is valid. I have added a misc field to extra. In misc one can store any random data.
Will be out on the next release: https://github.com/lnbits/satspay/releases/tag/v0.2.7

Awesome, thanks for this solution!

Deployed to legend.lnbits.com


Fix conversion of epub2/ncx TOCs to  form

Re: Issue 97

Defer for now.  It targets master and we need a reproducible case.

This PR indeed targets the master branch instead of develop. Furthermore, the file epub-modules/epub/src/models/package_document.js now resides at js/epub-model/package_document.js (since a significant refactoring).
However, the fix itself is obviously still valid, and should be reviewed appropriately.
Here is a direct link to the new code location:
https://github.com/readium/readium-js/blob/master/js/epub-model/package_document.js#L178
        // Description: Constructs an html representation of NCX navPoints, based on an object of navPoint information
        // Rationale: This is a recursive method, as NCX navPoint elements can nest 0 or more of themselves as children
        function addNavPointElements($navPointDOM, $ol) {

            // Add the current navPoint element to the TOC html
            var navText = $navPointDOM.children("navLabel").text().trim();
            var navHref = $navPointDOM.children("content").attr("src");
            var $navPointLi = $('

').append(
                $('', { href: navHref, text: navText })
            );

            // Append nav point info
            $ol.append($navPointLi);

            // Append ordered list of nav points
            if ($navPointDOM.children("navPoint").length > 0 ) {

                var $newLi = $("

");
                var $newOl = $("

");
                $.each($navPointDOM.children("navPoint"), function (navIndex, navPoint) {
                    $newOl.append(addNavPointElements($(navPoint), $newOl));
                });

                $newLi.append($newOl);
                $ol.append($newLi);
            }
        }


Improve the liqoctl install command

Description
This PR improves the liqoctl install command, to:

Provide better feedback in case of errors;
Better handle timeout/context cancellation events;
Automatically rollback broken releases.

In addition, it bumps the helm library version (while reducing the custom modifications), and it improves the printer output management, to prevent pretty-printing in case of terminals that do not support escape characters.
@aleoli While looking for other fields, I stumbled upon an UpgradeCRDs flag exposed by the helm library. I currently switched to using that, as it seems to me it performs more advanced checks, but let me also know your thoughts.
Note: this currently includes #1261, to simplify documentation rebasing.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Manually, on kind
[x] Existing tests

/test

/test

/merge


Unlink error

Sometimes an error occurs before the .dockerfile is created, for instance if the user tries to pull an unknown NodeJS version. It will try to unlink the .dockerfile but it rejects the unlink promise at line 86. Because the rejection is not catched, it will not go to last then function here https://github.com/vdemedes/trevor/blob/master/index.js#L89-L98.
A solution would be to just catch the error and do nothing with it or first check if the file exists.
return fs.unlink(tmpPath)
  .catch(function (err) {
    // do nothing
  });

Thank you for pointing this out ;)


Fix: If socket is undefined it will return false. See #1486

See #1486
Short: Socket is undefined (in my case) if I use client.ClientConnected() before I connect and cause error in the webgl version. The change fixes that.

@MrGadget1024 @James-Frowen up to you guys :)


Incorrect command

The command
helm install stable/nginx-ingress \
    --namespace ingress-basic \
    --name nginx-ingress \
    --set controller.replicaCount=2 \
    --set controller.nodeSelector."beta\.kubernetes\.io/os"=linux \
    --set defaultBackend.nodeSelector."beta\.kubernetes\.io/os"=linux

does not work with Helm 3. The option --name is unknown.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd0e7d5a-37e9-07dc-f395-9cb5bb580e45
Version Independent ID: 7e4faf70-9724-7e7b-832b-1cd99a974920
Content: Create a basic ingress controller in Azure Kubernetes Service (AKS)
Content Source: articles/aks/ingress-basic.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@clemensv
Thanks for the feedback! We are currently investigating and will update you shortly.

Use this , although i heard this is no-longer a common way to deploy the controller
helm install nginx-ingress  stable/nginx-ingress     --namespace ingress-basic     --set controller.replicaCount=2     --set controller.nodeSelector."beta.kubernetes.io/os"=linux     --set defaultBackend.nodeSelector."beta.kubernetes.io/os"=linux

@clemensv yes.  Helm 3 has this format  helm install [NAME] [CHART]
If we update the doc, the command wont work with helm 2.
@mlearned  @zr-msft please suggest the way forward

Reference for helm 2 install is here https://v2.helm.sh/docs/helm/#helm-install

@mlearned Please decide on update from helm2 to helm 3 and update the doc as needed

Thank you for the feedback @clemensv
The doc has been updated to use helm 3.
#please-close


1.12.2 Port

Ported to 1.12.2 from master
Tested locally in single player and multipalyer.
Corpses spawn as expected, capture nearby dropped items, break when hit by shovel, and do an excellent job planking

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Shouldn't the README be updated too?

That's a really good point

Why do people always forget about the README...


[red-knot] special-case import of built-in modules

Certain modules are imported by BuiltinImporter, which comes first in sys.meta_path by default (before PathFinder which implements the normal filesystem-based module resolution.) These modules will always take precedence over any module on the filesystem (i.e. first-party code can't ever shadow these modules, unless somebody starts rearranging sys.meta_path, which throws everything out the window and we can't reasonably support.)
So our module resolver should special-case these modules to always resolve to typeshed, and never to user code. The module names are listed at https://github.com/python/cpython/blob/main/Modules/config.c.in#L35 -- currently they are marshal, _imp, _ast, _tokenize, builtins, sys, gc, _warnings, _string.
(I also verified experimentally that I can't override these modules by creating e.g. a gc.py or sys.py or builtins.py file.)

The module names are listed at<EMAIL_ADDRESS>-- currently they are marshal, _imp, _ast, _tokenize, builtins, sys, gc, _warnings, _string.

This isn't a complete list of the modules that are special-cased by the interpreter; I think there must be additional special-casing done elsewhere. A more complete list can be obtained using the sys.builtin_module_names constant. Experimenting locally confirms that there are names included in that list which are not included in your list and are special-cased in the same way when it comes to module resolution.
We should add special-casing for these modules by writing a Python script to generate a Rust function similar to the one in https://github.com/astral-sh/ruff/blob/main/crates/ruff_python_stdlib/src/sys.rs, which can be queried to determine which modules are considered builtin on any given Python version.

It might be worth double-checking the list of paths with the paths that Pyright uses.

It might be worth double-checking the list of paths with the paths that Pyright uses.

From what I can tell, I'm not sure pyright ever respects first-party modules overriding stdlib modules. I can't find any relevant list of paths in the pyright source code; and from local experimentation, pyright appears to resolve random to the stdlib module even if it's locally overridden (despite emitting a warning telling you that the local random.py file is shadowing a stdlib module).
I have high confidence that the list of modules given by sys.builtin_module_names is the correct one, however.

Yeah, sys.builtin_module_names is the right complete list. It's the same special-casing (BuiltinImporter), it's just that the file I linked is the input template to code generation that happens at CPython build time, resulting in an output config.c module that has more built-in modules listed in the inittab. (This is because some built-in modules are conditionally built.)

Status update: https://github.com/astral-sh/ruff/commit/d8cf8ac2ef26bb630b43b095f61662173b2bac2f just added a hardcoded list directly into resolver.rs, based on the builtin modules that I have locally on Python 3.12. We should still change this to be a generated Rust function similar to the one in https://github.com/astral-sh/ruff/blob/main/crates/ruff_python_stdlib/src/sys.rs.


Add zoom in and zoom out controls on map

Add zoom in and zoom out controls on map

Working on this


Night Mode bug?

Hi, i think strava recently updated their ui a bit, Is there a way to fix this?
https://i.imgur.com/YGB3ZVV.png

Fixes are rolling out now.  Thank you for the report!


Testing and owner vs oracle

Description

Seperates oracle from aribtrator (owner)
adds testing for all lines missing (AFAIK)

Checklist

[x] Linter status: 100% pass
[x] Changes don't break existing behavior
[x] Tests coverage hasn't decreased

Refers/Fixes
#208 #210

Pull Request Test Coverage Report for Build 784

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.418%

Totals

Change from base Build 776:
0.0%

Covered Lines:
227

Relevant Lines:
260

💛  - Coveralls


Corrected Italian landing page grammar

Description
Describe in detail what the pull request fixes, adds or removes.
This pull request fixes grammatical errors in the Italian translation of the landing page.
Issues Resolved
Issue #250
Preview Links
https://deploy-preview-251--navcoin.netlify.com/it
Checklist

[x] Have you checked there are no merge conflicts?
[x] Have you tested the changes work across both mobile and desktop?

Could not claim or assign, sorry

needs conflicts resolved because it is stale. reopen if you want to resolve the merge conflicts.


Merge pull request #1 from kata-containers/master

sync-up #2 after clh-driver-001 merge

PR created by mistake.


RNG-176: Enhance the UniformRandomProvider interface

Coverage increased (+0.007%) to 99.791% when pulling 76dfcb770d8b46627a9952cf4a4ec1d93655b6b0 on aherbert:feature-RNG-176 into 22bba87751be8a6fe9b460fef4b5ad7a970ebee5 on apache:master.


Proposal: Investigate cuelang to validate output documents

Problem Statement
Although tests for tern manage to catch issues with analysis, it doesn't validate whether the documents created have the expected content. There isn't much out there that can help with this with regards to python.
Describe the Proposal
Take a look at https://cuelang.org/ to validate tern's document contents.
Steps to Implement Proposal
Take one of the default documents that we have trouble validating by hand and see if we can write cuelang validation tests for it. Then maintainers can make a decision on whether this is feasible to implement for all the document types we support.

@nishakm A little more insight will be helpful, maybe I can be of some help

@sayantani11 I'm actually not sure how much cue would be able to help with checking if our output documents match our expectations. If you'd like you can try writing something in cuelang to check a default document.
To get one of these run:
tern report -i debian:buster -o test_doc.txt

Then write some cue code to check if this line is present:
info: Found 'Debian GNU/Linux 10 (buster)' in /etc/os-release.

You can put your findings in a comment here.


Add ability to user AWS CodeArtifact as upstream

AWS CodeArtifact requires dynamic, temporary credentials. We can enable this by recognizing that it is a CodeArtifact upstrem url and requesting/managing the temporary token.

Note that this will require that the Lambda function have IAM access to the CodeArtifact repository specified in the URL...


Add support for response body streaming

Motivation
Allow large response bodies to be streamed rather than buffering the entire response.
Modifications

Add an EnableResponseStreaming property to IOperationRequest
Use this property to affect parameters pased to HttpClient.SendAsync

Results
If the consumer sets EnableResponseStreaming to true then the response will be returned as soon as headers are received and the body will be streamed to the deserializer rather than buffered.
Resolves #197

/merge


hyprctl command to reset/remove binds

Description
hyprctl command to reset only binds instead of having to reload entire config with hyprctl reload

wat

-> Make bind using hyprctl
-> want to remove that bind
-> run hyprctl reload and make all exec lines run again (a hyprctl resetbind command instead of this that doesn't reload entire config)


默认值怎么修改呢？

比如 00:mm的情况

It's all in the documentation. Please check the Data Binding section here.
P.S. To help other people - not only me but also other latecomers who might raise the same question as you did - understand your question, I'd suggest you use English when commenting or opening a new issue. Thanks!


feat: add writer support for aliyun oss

This PR adds Writer support for aliyun OSS so that it can leverage the multipart upload functionality to append bytes to objects.
This PR fixes #1761

Mostly LGTM! Thank you very much. This pull request can be merged once all the CI tests have passed.

Sorry for the delay. I'm trying to do some tests on oss to ensure the correctness

Sorry for the delay. I'm trying to do some tests on oss to ensure the correctness

This test is included in our behavior tests and can be run using cargo test oss. For more information on the test setup, please visit https://github.com/apache/incubator-opendal/tree/main/core/tests/behavior.

Thanks a lot!


jfes_integer_to_string: static buffer

I don't like the idea of using a static buffer and returning a pointer to its contents.
This results in the possibility of data corruption when jfes_integer_to_string() is called multiple times. Why don't allocate the memory dynamically?
char *jfes_integer_to_string(int value) {
    static char buf[JFES_MAX_DIGITS + 3];
    char *p = &buf[0] + JFES_MAX_DIGITS + 2;
    ...
    return p;
}

Because in this case, it's not necessary to free allocated memory. I think, it's better to do this way. I think I should to add a remark to the function description about multiple using.

I just don't like that if you can unintentionally corrupt your data if you use the code like below (http://ideone.com/6NJyn7):
	char *c1 = NULL, *c2 = NULL;
	c1 = jfes_integer_to_string(123);
	printf("c=%s c2=%s\n", c1, c2);
	c2 = jfes_integer_to_string(765);
	printf("c=%s c2=%s\n", c1, c2);
	strcpy(c1, "abc");
	printf("c=%s c2=%s\n", c1, c2);

If my memory serves me, one of the standard implementations of the itoa works this way.
Memory must be allocated and freed in the same scope.
If you need the returned data, then copy it. If you don't need it, forget it.

Not sure about itoa() but strerror() does work this way, correct.
What about multi-threading? Is jfes going to support it?

Yes, I think in the future I'll add the jfes_(integer/double)_to_string_r() function, like strerror_r() to support multithreading.

Okay.


Wrong names propagated after matrix multiplication

Here I have two matrices with names (y1, u1) and (y2, u2). When multiplying them, it appears as if the names in the result are chosen based on the second argument only, but I expected to get (y1, u2) when multiplying (y1, u1) * (y2, u2). Maybe my understanding is incorrect?
julia> s1.D
1×1 ComponentMatrix{Int64} with axes Axis(y1 = 1,) × Axis(u1 = 1,)
 1

julia> s2.D
1×1 ComponentMatrix{Int64} with axes Axis(y2 = 1,) × Axis(u2 = 1,)
 1

julia> s1.D*s2.D
1×1 ComponentMatrix{Int64} with axes Axis(y2 = 1,) × Axis(u2 = 1,)
 1

julia> s2.D*s1.D
1×1 ComponentMatrix{Int64} with axes Axis(y1 = 1,) × Axis(u1 = 1,)
 1

I'm working on just that, state-space objects with named states, inputs and outputs. It's kind of hopeless to remember the order of states, in particular when concatenating several systems together. It appears as if it's going to require quite a number of custom methods though, in ControlSystems.jl we have in general been careful with the element types, but not the array types. We thus do a lot of concatenation with zeros(T, n, m) which leaves named components behind :/
As long as the hcat,vcat, +,-,* operations are working, as well as perhaps lsim, freqresp I think we're generally at a place where it becomes useful. If nothing else, one can just ask for the indices from the statespace type and use those to index into any array that represents states/control/outputs.


naive implementation of exact greedy gbt

@ogrisel
This is a code dump of tinygbt.
Also, I added a simple benchmark code & data.

/benchmark/bench_exact_greedy.py
/benchmark/data/regression.(test|train)

This data is copy of LightGBM's regression example data.
You can test this with following command.
$git clone https://github.com/lancifollia/pygbm.git pygbm_exact_greedy
$cd pygbm_exact_greedy
$git checkout exact_greedy
$cd benchmarks
$python bench_exact_greedy.py

Thanks. I am currently making some progress on an alternative tree grower implementation with a slightly different API based on histogram splitting for binned numerical features.
I will review your PR in light of that work (probably in a couple of days). I think the main Gradient Boosting loop of your code can be reused almost directly. The exact tree learning will probably need a refactor to match my implementation though.
I'll ping you when I am ready.

@lancifollia sorry for the lack of feedback on this PR. @NicolasHug and I have been working on making the binned feature histogram case as efficient as possible and we want to optimize the global design of the library to suite to make sure that we can get the maximum performance on with binned feature histogram first. Once done we will probably refactor the grower.py / splitting.py modules a bit to allow for exact splits as an option.
As you can see in master we made good progress and running pygbm on the Higgs boson benchmark from the benchmarks/ subfolder yields performance competitive with that of LightGBM.
@NicolasHug will work on adding the missing features such as: adding a proper classification loss, dealing with categorical variables, sparse data and missing values  and so on.
Feel free to chip in to review the ongoing pull request and let us know if there is something else you would like to improve in the mean time.


InvalidBaseValue shouldn't be a ParseError, but its own separate error type (BaseRangeError)

I'm going to close this issue. This would require an outer error type: ErrorType that could hold a ParseError or BaseRangeError and that would not only break users, but over-complicate getting values out of the results.


platform guard requires OS name list, not an array

Previously, it had wrongly matched against a regexp with a
character class.
platform_is_not [:windows, :darwin] was equal to
RUBY_PLATFORM =~ /[:windows, :darwin]/, which was same as
/[:windosar]/.

Good catch, thanks!


Unbound occasionally reports broken stats

Describe the bug
Some of the time stats reported by unbound through the control socket formats floats incorrectly and this broke unbound_exporter for us. The values are unexpectedly negative and in the wrong format.
Example stats:
$ sudo unbound-control -c /etc/unbound.conf stats_noreset | grep -F '0.-'

thread1.recursion.time.avg=0.-402022313
thread2.recursion.time.avg=0.-1726117941
thread3.recursion.time.avg=0.-1813043235
total.recursion.time.avg=0.-701203423

Prometheus exporter failed to parse these lines:
2021/05/06 16:47:22 Failed to scrape socket: strconv.ParseFloat: parsing "0.-1176731538": invalid syntax

The exporter barfs on the first parse error and reports unbound as down.
$ curl -s <IP_ADDRESS>:10062/metrics  | grep unbound_up

# HELP unbound_up Whether scraping Unbound's metrics was successful.
# TYPE unbound_up gauge
unbound_up 0

It's interesting how avg is negative but median is not. That may help us reverse engineer and figure out what happened?
thread1.recursion.time.avg=0.-402022313
thread1.recursion.time.median=0.000276483

I can try to reproduce and find more information if required. Unfortunately the running binary didn't have debug symbols so I couldn't extract all local variables with gdb.
To reproduce

Not sure yet, will try to isolate the issue and report more stats later.

Expected behavior

Report time stats in the correct format
Make sure time stats are always positive.

System:

Unbound version: Version 1.7.3
OS: CentOS

I know its an old version, but it doesn't look like the metrics code changed a lot since then. I couldn't find anything related in the changelog either.
Thanks!

The commit fixes the issue by making sure that the values are not negative. It then turns to 0.
It also casts the size_t to long long to stop what may be an integer overflow causing the negative numbers in the division function. This likely stops the wrong statistic report, but I do not know for sure; I guess it was related to a 32bit compile. Thanks for the report!


RFP - downzemall!

Checklist

[X] The package I am requesting does not already exist on https://chocolatey.org/packages;
[X] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[X] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://setvisible.github.io/DownZemAll/
Direct download URL for the software / installer : https://github.com/setvisible/DownZemAll/releases/download/v2.5.5/DownZemAll_x64_Setup.exe
Software summary / short description: A download manager that's a successor to the legacy DownThemAll!

Probably start menu shortcuts.

I pick up this package :slightly_smiling_face:
I actually already have created a Chocolatey package which is currently waiting for the review of Moderators :wink:

Package approved, thanks for creating the package @Xav83


Update min kubernetes version in the install doc

Changes

https://github.com/tektoncd/website/issues/614
and https://tektoncd.slack.com/archives/CJ62C1555/p1720961833907299
v0.61.0 updated the minimum version of Kubernetes to 1.28.
Update the docs to reflect this so the website has the correct content and avoid confusing users.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] pre-commit Passed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/cherry-pick release-v0.61.x


Introduce ServiceLoader use for TargetClients

#304 represents the intent of this PR towards the larger extensibility improvements.
What is the purpose of the pull request
This change will introduce the use of ServiceLoader by the TableFormatClientFactory to discover the TargetClient implementations by TableFormat which was recently changed from an Enum to a String in preparation for this change.
ServiceLoader will load all implementations on the classpath (built-in to OneTable or added by the user) and select the intended client implementation by name provided for the Sync via argument or configuration.
This will allow users and/or tooling vendors to extend the capabilities without requiring all TargetClient's to be committed to the project.
Brief change log

Refactored TableFormatClientFactory to use ServiceLoader
Refactored existing clients to have a default no-arg ctor and an init() for initializing the client with required config
Removed final qualifiers from members so that init() can set them after construction
Extracted interfaces from PerTableConfig, HudiSourceConfig, IcebergCatalogConfig in order to maintain the decoupling of the api and core modules after needing the config files in the init()
Moved to the use of the PerTableConfig interface wherever possible

Verify this pull request
This pull request is already covered by many existing tests.
Also added a new test in TestTableFormatClientFactory for the factory use in general but also specifically for the use of ServiceLoader.

Happy New Year PR for onetable, @the-other-tim-brown

Resolved most of the review comments, @ashvina .
I've left the two open topics open with comments/questions.

@the-other-tim-brown , @ashvina - addressed those issues that were clear. Left a couple open for resolution of questions.

@the-other-tim-brown , @ashvina - curious where we are on this. I'd rather we get this in before having to rebase it if things move out from under it.


OpenAI server with min_p

How to set properly min_p sampling when using vllm.entrypoints.openai.api_server ? Is it supported?

Hi, @generalsvr. vLLM currently supports min_p params. You can request api server with min_p parameter. For my testing, 0.05 is a proper value, but it depends on your model.

Ok I changed openai python client lib to support min_p arg. Works better. But when I try to set stream=True I get this error:
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/routing.py", line 718, in __call__
    await route.handle(scope, receive, send)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/routing.py", line 69, in app
    await response(scope, receive, send)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/responses.py", line 270, in __call__
    async with anyio.create_task_group() as task_group:
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 597, in __aexit__
    raise exceptions[0]
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/responses.py", line 273, in wrap
    await func()
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/starlette/responses.py", line 262, in stream_response
    async for chunk in self.body_iterator:
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/vllm/entrypoints/openai/api_server.py", line 599, in completion_stream_generator
    response_json = create_stream_response_json(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/vllm/entrypoints/openai/api_server.py", line 548, in create_stream_response_json
    response = CompletionStreamResponse(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/pydantic/main.py", line 164, in __init__
    __pydantic_self__.__pydantic_validator__.validate_python(data, self_instance=__pydantic_self__)
pydantic_core._pydantic_core.ValidationError: 1 validation error for CompletionStreamResponse
usage
  Field required [type=missing, input_value={'id': 'cmpl-0b8b9c924028...e, finish_reason=None)]}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.5/v/missing
INFO 12-27 14:22:13 async_llm_engine.py:111] Finished request cmpl-0b8b9c92402848109fb4983f8758b9b5.

@generalsvr It seems you installed a higher version of pydantic. Please be sure to use version 1.10.x.


add prepared statement test case

Coverage remained the same at 48.335% when pulling a73597d5c99f2cbffa5c591f8efb86e556f61b0f on ascrutae:wu-sheng-patch-db-operationName into 349f78efa43a45598d9c5791f88a515ec6938130 on wu-sheng:wu-sheng-patch-db-operationName.


Make work in hot-module-replacement environments

When using hot module replacement (in my case with Knockout + Webpack) where code and its deps are re-evaluated, swal creates new containers and acts upon those, but they are never inserted into the DOM.

Nicely done @caseyWebb, thank you :beers:

v5.0.6.

Sorry @caseyWebb it's v5.0.7


Minecells

Mod Name
Minecells
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/minecells
Minecraft version
1.20.1
Describe the bug
the game crashes
Steps to reproduce

open launcher with minecells, sinytra, and owo (library needed for sinytra)
press play
game crashes
...

Logs
https://pastebin.com/BjUTTUg0
Additional context
No response

duplicate of #1085


Invalid arguments from lambda in collapsed node.

To reproduce: open the following project:
from Standard.Base import all
from Standard.Table import all
from Standard.Database import all
from Standard.AWS import all
import Standard.Visualization

main =
    operator13208 = enso_project.data/'3686412302.json' . read
    operator80502 = operator13208.get 'bench_run'
    operator42039 = operator80502.get 'id'
    operator9135 = operator80502.get "head_commit" . get "id"
    operator98772 = operator80502.get "head_commit" . get 'timestamp'
    operator27003 = operator80502.get "head_commit" . get 'message'
    operator84402 = operator80502.get "head_commit" . get 'author'
    operator59298 = operator98772.parse_date_time
    operator23880 = [operator42039, operator9135, operator59298, operator27003, operator84402]
    operator96032 = Table.from_rows ["Run ID", "Commit ID", "Date", "Commit Title", "Commit Author"] rows=[operator23880]
    operator95321 = operator13208.get 'label_score_dict'
    operator76512 = operator95321.map_with_key key->val->[key, val]
    operator97928 = Table.from_rows ['Label', 'Score'] operator76512
    operator75059 = operator96032.cross_join operator97928
    operator32822 = operator75059.reorder_columns ['Run ID', 'Label', 'Score'] Position.Before_Other_Columns

and collapse all nodes except the first one. Likely it might be reduced.
Expecting collapse function with single argument.
But instead, we get two operator13208 what is already reported (#9159) but also additional key and val parameters. Those names appear only in lambda, and are not names used outside.

I think this is the same defect
from Standard.Base import all
from Standard.Table import all
from Standard.Database import all
from Standard.AWS import all
import Standard.Visualization

main =
    operator86947 = [1,2,3]
    operator20382 = operator86947.map (x -> x+1)

and try to collapse the map node


Style fixes for enabling PEP8 501

This PR enables PEP8 501.

If I may, could you divide this PR into smaller ones? Usually having a few PRs instead of a big one has several advantages :

The complexity for reviewers increase exponentially as the PR gets bigger.
it's easier to share de reviewing work across reviewers.
big PRs usually means that maintainers will put a low priority on the PR because they ask a lot of work at once. You can see it even in keras.

I'm sure you've notice all that since you are a maintainer of Keras, so it's just a friendly reminder from someone who got scared when he saw "13 files changed" :)

Thank you for the comments @gabrieldemarmiesse. Updated.

Thanks!


Update robinraju/release-downloader to 1.11

Update robinraju/release-downloader to 1.11 (stealing Kichura work)

Shouldn't we add dependabot to auto-pr this kind of maintainence?

Shouldn't we add dependabot to auto-pr this kind of maintainence?

not really important unless updates happen very frequently which in this case here isn't.


import issue on OSX (ValueError: level must be >= 0)

Hi aholkner!
First off, thanks for this nice package, I'm looking forward to using it!
I encountered the following problem, that you might want to know about:
(py3env) me@myhost:~./$ pip install -U bacon
Collecting bacon
Installing collected packages: bacon
Successfully installed bacon-0.3.1

Opening python and importing bacon:
(py3env) me@myhost:~./$ python
Python 3.6.1 (default, Apr 17 2017, 08:59:54)
[GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.41)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

>>> import bacon
WARNING: No logging configuration for "bacon" set; using default
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/mskoenz/.virtualenvs/py3env/lib/python3.6/site-packages/bacon/__init__.py", line 4, in <
module>
    from bacon.all import *

  File "/Users/mskoenz/.virtualenvs/py3env/lib/python3.6/site-packages/bacon/all.py", line 1, in <modul
e>
    from bacon.core import *
  File "/Users/mskoenz/.virtualenvs/py3env/lib/python3.6/site-packages/bacon/core.py", line 152, in <mo
dule>
    lib = native.load(function_wrapper = _error_wrapper)
  File "/Users/mskoenz/.virtualenvs/py3env/lib/python3.6/site-packages/bacon/native.py", line 493, in l
oad
    _lib = _dll_path.get_lib()
  File "/Users/mskoenz/.virtualenvs/py3env/lib/python3.6/site-packages/bacon/native.py", line 428, in g
et_lib
    dll_dir = self.get_dir()
  File "/Users/mskoenz/.virtualenvs/py3env/lib/python3.6/site-packages/bacon/native.py", line 396, in g
et_dir
    _pkg_resources = __import__('pkg_resources', globals(), locals(), [], -1)
ValueError: level must be >= 0

I'm running:

virtual-env python3.6
sys.platform="darwin"
OSX10.12.6, MacBook Pro (13-inch, 2016)

Hope this helps and best regards
mskoenz
EDIT:
import logging
logging.getLogger('bacon').addHandler(logging.NullHandler())
import bacon

yields the same behavior
EDIT2:
I was able to "solve" it by hardcoding (native.py)_DLLPath.get_dir(self) to return the path to Bacon64.dynlib, seems like a python2/3 issue maybe?

how do you solve that problem ? I couldn't solve it just by changing the function , i tried and it give me new errors , can you help me ?


Allow signal bootstrap sends to commands on cancel to be customized

Currently bootstrap sends a SIGTERM to commands when it, itself, is interrupted.
This adds cancel-signal which accepts signals in the form of SIGTERM, SIGHUP, etc.
This is the same config that start accepts, and is based on the PR that added that feature: https://github.com/buildkite/agent/pull/1041
Finally, start passes its cancel-signal to bootstrap, to prevent having to customize the bootstrap-script.

Excuse me while I think this through “out loud”…
The existing buildkite-agent start command has --cancel-signal=SIGTERM which can also be set via BUILDKITE_CANCEL_SIGNAL environment instead. This propagates into AgentWorker → JobRunner → process (where it's called InterruptSignal) and is used when process.Interrupt is called by JobRunner.Cancel. It sends the configured signal to the process group of the bootstrap process. My limited mental model of process groups is that generally all processes in the group would receive the signal — i.e. the bootstrap and all the commands it's running. Or is it only the process leader? Or “it depends”?
JobRunner TL;DR: on job cancellation, the job runner sends the bootstrap process (and its child processes?) the configured signal.
This PR introduces to buildkite-agent bootstrap a new --cancel-signal=SIGTERM which can also be set via BUILDKITE_CANCEL_SIGNAL environment when the bootstrap is started. This PR changes buildkite-agent start to pass its configured cancel signal through to the boostrap. The bootstrap uses this new config to set b.shell.InterruptSignal, which passes it to shell's process.InterruptSignal, which is used during Process.Interrupt, which is called by Shell.Interrupt. That's called when the cancelCh channel is written to (which logs “Received cancellation signal, interrupting”). That channel is written to when Bootstrap.Cancel() is called, which happens in the bootstrap signal handler. That signal handler listens to SIGHUP, SIGTERM, SIGINT, SIGQUIT.
Bootstrap TL;DR: bootstrap signal handler calls bootstrap.Cancel()  → b.shell.Interrupt() → Process.Interrupt() which uses this new bootstrap --cancel-signal / BUILDKITE_CANCEL_SIGNAL instead of being hard-coded to SIGTERM.
So I think the intention of this PR is to make buildkite-agent start --cancel-signal=SIGINT actually send SIGINT to the build commands being run within the bootstrap. That sounds like it was the intention of the original option, and the bootstrap layer was unintentionally getting in the way. It does that by adding the same --cancel-signal option to bootstrap and passing the option through.
So … 👍🏼
My only feedback is that I think we should pass BUILDKITE_CANCEL_SIGNAL from JobRunner to Bootstrap via environment (which might already be happening implicitly?) rather than injecting --cancel-signal into the bootstrap command ARGV. Thoughts?

Something else we should think about is either test coverage, or at least a before/after proof copied/pasted into this comment thread showing that this results in the configured signal being sent to the actual commands being run within the bootstrap.

My only feedback is that I think we should pass BUILDKITE_CANCEL_SIGNAL from JobRunner to Bootstrap via environment (which might already be happening implicitly?) rather than injecting --cancel-signal into the bootstrap command ARGV. Thoughts?

That was what I tried first, but it wasn't being passed through. I would be fine with it working that way, the direct argument call was the easiest for me to get it to work.

Something else we should think about is either test coverage, or at least a before/after proof copied/pasted into this comment thread showing that this results in the configured signal being sent to the actual commands being run within the bootstrap.

I wasn't sure how to do the tests, but I would be supportive of that. I can instead create a little example using traps that shows which signals are being sent (it was how I noticed the issue to begin with). Just lmk.

Sorry for the silence @brentleyjones…
I've pushed a commit to this PR which propagates the option to bootstrap via BUILDKITE_CANCEL_SIGNAL env rather than an argv flag; there's precedent for this in JobRunner.createEnvironment().
I was also unsure how to write tests for this, so I did some local testing. I built a simple binary that reports which signal it was killed by. I ran buildkite-agent start --cancel-signal SIGINT, and cancelled a build running on the main branch (top) and on this PR branch (bottom):

got signal: interrupt looks good 👍🏼

thanks @brentleyjones :heart:

Thanks!