update select menu appends

https://issues.redhat.com/browse/COST-2617
ended up using inline in cases where the menu for sure fits between edges of modal and doesn't go over header/footer of wizard with the new height restriction (scrollable), and parent for cases where it goes off the edge of the modal. both ways work with keyboard and a11y (being close in dom).
the 350 max height currently only affects the currency select, and gives it most of the usable space between wizard header/footer while cutting off at half an item so it's more obvious that scrolling is possible.

Codecov Report

Merging #2380 (214c889) into main (2f0c8ca) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
+ Coverage   68.92%   68.93%   +0.01%
==========================================
  Files         412      412
  Lines        7880     7878       -2
  Branches     1859     1859
==========================================
  Hits         5431     5431
+ Misses       2445     2327     -118
- Partials        4      120     +116

Impacted Files
Coverage Δ

...rc/pages/costModels/components/inputs/selector.tsx
97.14% <ø> (ø)

...odels/createCostModelWizard/generalInformation.tsx
48.48% <ø> (+2.77%)
:arrow_up:

src/utils/cookie.ts
58.33% <0.00%> (ø)

src/utils/format.ts
67.70% <0.00%> (ø)

src/api/orgs/orgUtils.ts
37.50% <0.00%> (ø)

src/api/queries/query.ts
43.85% <0.00%> (ø)

src/utils/localStorage.ts
79.74% <0.00%> (ø)

src/store/metrics/selectors.ts
75.86% <0.00%> (ø)

src/api/resources/resourceUtils.ts
17.18% <0.00%> (ø)

src/components/exports/exportsLink.tsx
43.75% <0.00%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0c8ca...214c889. Read the comment docs.

https://user-images.githubusercontent.com/5322142/168086854-c154ea38-881d-4438-93de-eb02cc1b4d7f.mov

LGTM

added component ids in for qa testers, added aria labels on the generalInfo select toggles, created a maxHeight property in our selector to pass to PF select and setting to 350 for general info items


Update README.md

Added  Table of contents
PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[x] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number:  NA
What is the current behavior?
NA
What is the new behavior?
NA
Other information
NA

@amaljose02, thanks for the PR!
Can we show you some appreciation for the contribution?
Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged.

@tzarebczan thanks for the appreciation. Could you please tell to which mail should I send the details for receiving the goodies.

Hi @tzarebczan , It will be very helpful if you share  the details to contact to receive the goodies and bonuses?

@amaljose02 sorry for not replying earlier, but the links were part of the original reply. Since the promotion is now over, just get us an email over and we'll get some credits over to you for the PR.


Refactor binary data calls in OnAudioPassThru

Fixes #85.  Forward calls to setAPTData to setBulkData and getAPTData to getBulkData.
Signed-off-by: Mike Burke<EMAIL_ADDRESS>

Trivial change is being marked for 3-day offline review.  Anticipated merge date is 2/4/2015 at 3pm.

Oops - hotfix should be PR'd into master, not develop.  Closing this PR and will open a new one.


JSON serialization of Explanation

I think it makes sense to add something like asdict method to Explanation that will return a JSON-serializable object (it will just call attr.asdict(self)).
And also add test that check that it is indeed json-serializable (right now it can have some numpy ints that are not seriazable).

Yeah, that'd be a great feature!
It also has a full-fledged numpy array in TransitionFeatureWeights.

Fixed in #84


Move CI to GitHub Actions

Fixes https://github.com/scikit-optimize/scikit-optimize/issues/1060
Closes https://github.com/scikit-optimize/scikit-optimize/pull/1072
Closes  https://github.com/scikit-optimize/scikit-optimize/issues/1068
Closes https://github.com/scikit-optimize/scikit-optimize/pull/1069
This took a while, but it's often better late than never. :sweat_smile:
The PR looks huge, but it's namely about:

migrating the whole of CI onto GitHub Actions (purging TravisCI and CircleCI machinery so we don't have dead code lying around),
improving setup.py to aid in releasing (specifying dependencies in one single place, version control by version control etc.),
cleaning the code to conform to (hereby finally active!) linting,
some documentation consolidation and improvements (README.rst, CONTRIBUTING.md, ISSUE_TEMPLATE.md ...) to help new users.

I tried my best to simplify, yet continue @holgern's work—what happened, man, have you died?! :D
It's not too pretty, but it's what I can offer. The commits have been roughly squashed by function. The PR is at this point certainly ready for review. You can see all the checks passing on a PR to my fork, here.

Hello @kernc! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file benchmarks/bench_ml.py:

Line 155:80: E501 line too long (88 > 79 characters)
Line 247:80: E501 line too long (85 > 79 characters)
Line 249:80: E501 line too long (96 > 79 characters)
Line 286:80: E501 line too long (87 > 79 characters)
Line 287:80: E501 line too long (86 > 79 characters)

In the file examples/interruptible-optimization.py:

Line 52:1: E305 expected 2 blank lines after class or function definition, found 1
Line 52:80: E501 line too long (99 > 79 characters)

In the file examples/plots/partial-dependence-plot-with-categorical.py:

Line 22:1: E402 module level import not at top of file

In the file examples/plots/visualizing-results.py:

Line 113:1: E402 module level import not at top of file

In the file examples/sampler/sampling_comparison.py:

Line 51:1: E402 module level import not at top of file

In the file setup.py:

Line 13:80: E501 line too long (83 > 79 characters)

In the file skopt/__init__.py:

Line 40:80: E501 line too long (81 > 79 characters)

In the file skopt/tests/test_plots.py:

Line 42:80: E501 line too long (83 > 79 characters)
Line 115:80: E501 line too long (83 > 79 characters)

@pep8speaks in https://github.com/OrkoHunter/pep8speaks/issues/95 says it should follow setup.cfg flake8 configuration, but apparently not the case?
I'd kindly motion toggling off the noise in favor of a more simple lint check. :+1:

Should scikit-optimize leverage this PR to move to the black code-style, like scikit-learn did ?


Devirtualize duplicate methods

The background on this PR is that we have a lot of autogenerated protobufs with the same method over and over again (e.g., MyProtobuf.prototype.getIndex = function () { return this.getFieldValue(this, 'getIndex'); })
Closure Compiler doesn't do a great job optimizing these because it can't figure out how to coalesce the definitions. I'm hoping this will improve the situation.

Thanks Nick, this looks very useful! Can you add a unit test where the multiple definitions also use this? Like the proto definition you mention in the description. (And then squash the commits so we can bring the PR in.)

updated!

LGTM. I'll bring this in and submit it.

wooo thanks!
On Wed, Sep 28, 2016 at 2:17 PM, Ben Lickly<EMAIL_ADDRESS>wrote:

Closed #2041 https://github.com/google/closure-compiler/pull/2041 via
cc3cc90
https://github.com/google/closure-compiler/commit/cc3cc90be12311e82c9a281926a6328881e05556
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/closure-compiler/pull/2041#event-805876320,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARAccfcSSfeancNTw77aDZseSrO-JBrks5quq8igaJpZM4KHpY7
.


UnicodeDecodeError

UnicodeDecodeError: 'cp950' codec can't decode byte 0xba in position 11: illegal multibyte sequence

Please use text in utf8


Feature suggestion: Click on element with cursor to create command

I have a suggestion / feature request.
Goal
Improve (onboarding) experience.
Feature
I'd like to be able to click an element with my mouse cursor, and that would create in the terminal the shortest most obvious command to select this element. I could then press enter in the terminal to actually trigger the click.
Why this implementation
That way I can learn to improve my 'selector skills', but it also makes it easier to start with for people who are a bit intimidated by text only inputs.
My user story on why
I tried it out, coming from Selenium IDE, and wanted to tap a hamburger icon in the top right. I tried different ways, but I did not succeed. Maybe I did the $("#id_name') thing wrong or whatever. Doesn't matter, the problem is that there is no plan B.
Next I went to a page where I could do some stuff like scrolling, checking a checkbox, great. Then I wanted to tap a dropdown, but that didn't work with click("text on dropdown"). Again, I'm probably doing something wrong, but it would be great if I could learn how to do it right just by clicking on the element itself.
Implementation
I have no idea. But I imagine it might not be too much work to at first (as a POC) just get the id if present, or something like that, even if it goes slightly against the Taiko idea.

Closing this as core Taiko does not want to inject any Javascript to the browser for this feature. However, this can be implemented as a plugin.


Unittest model compare Alphafold

When I try to test all unittest, I found that all compare functions are skipped because of the uninstall of alphafold package. Then I try to install the alphafold from deepmind alphafold2 in github. However, when running test I found that severely environment version problem happened. I even can not run the import_alphafold(), it will be stoped when exec the importlib.import_module(submodule_info.name).  So I wanna ask how to fix this problem to run the relative compare test?Cuz I found is really hard to set a environment to run the compare function.  Is there some specified alphafold2 version to use?

I have already fixed this problem by changing jax to CPU version, because of unsupported cuda version. OR upgrade Cuda driver to adapt JAX


Design of property bag

Purpose
The purpose of propert bag is to pack the parameters in a new model when the method has too many parameters.
Background
When service APIs are updated in a new version, it is allowed to add a new optional input parameter. One possible consequence of this is that the API will have more and more input parameters as the version is updated. As we know, too many parameters can make the API difficult to use and increase the possibility of inadvertent switching of parameters in the call, which can lead to the service side returning unexpected results and making it difficult to discover the root cause. Based on above reasons, we decided to use a feature known as property bag to control the total number of method's parameters in the SDK.
Design Details
When to use property bag
We take the number of parameters as the condition to trigger property bag. The detail is that we will use property bag to control the number of parameters once the public API contains more than 5:exclamation: parameters.
What will be changed
Totally, property bag will only change the public API signature and has nothing to do with the internal rest operation. Here two steps will be taken:
Step 1: Changing the public method signature
Suppose we have a method in SampleResource as shown below:
class SampleResource
{
  Response DoSomething(string a, string b = null, string c = null, string d = null, int? e = null, int? f = null);
}

It can be seen that DoSomething has six parameters. It satisfies the condition that we trigger property bag, and at this point, all parameters, whether non-required or required, will be packed into a new required parameter whose name is always options. So the original method signature will be updated to:
class SampleResource
{
  Response DoSomething(SampleResourceDoSomethingOptions options);
}

Step 2: Adding a new class
Since we replace original multiple parameters with one new parameter options, a new class that consists of all the original parameters should also be added to the generated code. The four main rules for generating this new class are:

The name of this new class will be determined by the expression {Resource or Collection or Extensions name}{Method name}Options.
All the properties of this class should be public, the properties corresponding to the original required parameters will only have get accessor and the properties corresponding to the original non-required parameters will have both a get and a set accessor.
All the properties corresponding to the original non-required parameters will be explicitly initialized with honoring x-ms-client-default.
Only one public ctor with required parameters corresponding to read-only properties will be provided.

Based on above rules, the new class generated from step 1 will be:
class SampleResourceDoSomethingOptions
{
  public SampleResourceDoSomethingOptions(string a)
  {
    A = a;
  }

  public string A { get; }

  public string B { get; set; } = null;

  public string C { get; set; } = null;

  public string D { get; set; } = null;

  public int? E { get; set; } = null;

  public int? F { get; set; } = null;
}

[Note]:
There are three exceptions that the parameter should not be included in property bag class, and will always be exposed in the public API：

First parameter of extension method.
LRO parameter: For LRO, a qualifier whose type is defined as WaitUntil will be added as the first parameter of the method to indicate if the user wants to wait for the LRO to simply start or wait for completion.
Request context parameter: Normally, a optional request context parameter will be defined as the last parameter. In management plane, its type will be CancellationToken, and in DPG, RequestContext will be used as more context is needed.

Examples
Non-LRO method
In Azure.ResourceManager.AlertsManagement, AlertsManagementExtensions has an original method which looks like:
class AlertsManagementExtensions
{
  public static async Task<Response<ServiceAlertSummary>> GetServiceAlertSummaryAsync(this SubscriptionResource subscriptionResource, AlertsSummaryGroupByField groupBy, bool? includeSmartGroupsCount = null, string targetResource = null, string targetResourceType = null, string targetResourceGroup = null, MonitorServiceSourceForAlert? monitorService = null, MonitorCondition? monitorCondition = null, ServiceAlertSeverity? severity = null, ServiceAlertState? alertState = null, string alertRule = null, TimeRangeFilter? timeRange = null, string customTimeRange = null, CancellationToken cancellationToken = default);
}

This method signature will be changed into:
class AlertsManagementExtensions
{
  public static async Task<Response<ServiceAlertSummary>> GetServiceAlertSummaryAsync(this SubscriptionResource subscriptionResource, AlertsManagementExtensionsGetServiceAlertSummaryOptions options, CancellationToken cancellationToken = default);
}

And the AlertsManagementExtensionsGetServiceAlertSummaryOptions should be:
public partial class AlertsManagementExtensionsGetServiceAlertSummaryOptions
{
  public AlertsManagementExtensionsGetServiceAlertSummaryOptions(AlertsSummaryGroupByField groupby)
  {
    Groupby = groupby;
  }

  public AlertsSummaryGroupByField Groupby { get; }

  public bool? IncludeSmartGroupsCount { get; set; } = null;

  public string TargetResource { get; set; } = null;

  public string TargetResourceType { get; set; } = null;

  public string TargetResourceGroup { get; set; } = null;

  public MonitorServiceSourceForAlert? MonitorService { get; set; } = null;

  public MonitorCondition? MonitorCondition { get; set; } = null;

  public ServiceAlertSeverity? Severity { get; set; } = null;

  public ServiceAlertState? AlertState { get; set; } = null;

  public string AlertRule { get; set; } = null;

  public TimeRangeFilter? TimeRange { get; set; } = null;

  public string CustomTimeRange { get; set; } = null;
}

LRO method
In Azure.ResourceManager.DeviceProvisioningServices, DeviceProvisioningServicesCertificateResource has an original method which looks like:
class DeviceProvisioningServicesCertificateResource
{
  public virtual async Task<ArmOperation> DeleteAsync(WaitUntil waitUntil, string ifMatch, string certificateCommonName = null, byte[] certificateRawBytes = null, bool? certificateIsVerified = null, DeviceProvisioningServicesCertificatePurpose? certificatePurpose = null, DateTimeOffset? certificateCreatedOn = null, DateTimeOffset? certificateLastUpdatedOn = null, bool? certificateHasPrivateKey = null, string certificateNonce = null, CancellationToken cancellationToken = default);
}

This method signature will be changed into:
class DeviceProvisioningServicesCertificateResource
{
  public virtual async Task<ArmOperation> DeleteAsync(WaitUntil waitUntil, DeviceProvisioningServicesCertificateResourceDeleteOptions options, CancellationToken cancellationToken = default);
}

And the DeviceProvisioningServicesCertificateResourceDeleteOptions should be:
public partial class DeviceProvisioningServicesCertificateResourceDeleteOptions
{
  public DeviceProvisioningServicesCertificateResourceDeleteOptions(string ifMatch)
  {
    Argument.AssertNotNull(ifMatch, nameof(ifMatch));

    IfMatch = ifMatch;
  }

  public string IfMatch { get; }

  public string CertificateCommonName { get; set; } = null;

  public byte[] CertificateRawBytes { get; set; } = null;

  public bool? CertificateIsVerified { get; set; } = null;

  public DeviceProvisioningServicesCertificatePurpose? CertificatePurpose { get; set; } = null;

  public DateTimeOffset? CertificateCreatedOn { get; set; } = null;

  public DateTimeOffset? CertificateLastUpdatedOn { get; set; } = null;

  public bool? CertificateHasPrivateKey { get; set; } = null;

  public string CertificateNonce { get; set; } = null;
}

Close this issue since this has been implemented in https://github.com/Azure/autorest.csharp/pull/2862


Added Memory Accountant

Coverage decreased (-0.009%) to 99.775% when pulling bee9e7b36cdfe1fe9995b10ad27811be54617153 on basvodde:master into 5174a4531553427ba08b9f2d8a4699b67a6bc20c on cpputest:master.


[SPARK-36973][PYTHON] Deduplicate prepare data method for HistogramPlotBase and KdePlotBase

What changes were proposed in this pull request?
Deduplicate prepare data method for HistogramPlotBase and KdePlotBase
Why are the changes needed?
Deduplicate code
Remove 2 TODO comment
Does this PR introduce any user-facing change?
No, only for Dev
How was this patch tested?
Existing tests

CC @HyukjinKwon FYI

Test build #144118 has finished for PR 34251 at commit 0389e42.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48595/

Test build #144182 has started for PR 34251 at commit ab17c01.

Test build #144182 has finished for PR 34251 at commit ab17c01.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class HistogramPlotBase(NumericPlotBase):
class KdePlotBase(NumericPlotBase):

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48661/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48661/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48662/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48662/


[Addition]: Another selfwitnessing Midas cluster of 8 hotspots

Hotspot b58 Addresses
11224iwGKc5JDyzjmddr69AvA5zy9M2TQCoeJRbkXe5XYHxwbJWU
112BhZ3esWEZzGfjSrbnq2TJ5XAKDo5nMLzzPYSv3pMnYsGCgUuP
112hrrh7578raWqKnAWfpP633vrguCMzJN5RVCNTQKuGt9sr3w7n
112PuYXJrxdt8L8BfEmZEBaw6SMb3nVQwrxoNJPzKSK9hAUZAjSC
112WABbPeaJoyUBSCXoZtFNHG4GQxAjoKA6yUgNMFWYU5aGKxXdS
11bQ9uQ51cNpzn1MMrDy38UxeW2CznJm9sFB6WckmcDFqH7BNRo
11JwxwHCnYnGmGVfW6WUwGu8KQgWgwhYNpTDorYQHudZbogModY
11xGQ2jBR89CrYShEFitiU2wLrCzAKnUrWT9N6YEXuCSYaSkJLZ
Discord Handle
No response
Reason(s)
These Hotspots are only witnessing their own brand, have very often a unlikely (perfect) placement, same assertion date-range and usually there are enough real hotspots arround but these do not get witnessed at all.
Below some proof of the clusters:

What can I do to get the cheater's IP, please let me know. I will also report some cheaters.


Fixed code style issues in InProcessNode

Fixed code style issues in lib/InProcessNode folder.

@nnian please, merge this PR once you see that CI builds are green.
PS: if code-coverage goes down for less than 1.0% then it's sage to ignore it.


Latest release missing the option to show names ingame?

in the past there was an option to show names in game which was useful if playing on fullscreen and 1 monitor. i think the hotkey was ALT+S to activate it.
also, when i press Open player list or Set tekken in window mode, my tekken instantly crashes.

Yes, I removed the in-game display feature a few updates ago for various reasons, the biggest reason being that it simply no longer worked. I also thought that the in-game display wasn't needed because the program gave you the option to switch between full-screen and windowed, but since, like you said, that doesn't work either for you, I see how the program can become annoying to use.
As for opening the player list crashing your game: this is very weird to me, I have no idea how this is possible, but I'll check the code again later of course to be sure.
However, changing the window mode crashing your game is concerning. This is something that will happen if the addresses are not correct: in other words, the program is writing data in the wrong places.
Things that can cause this are:
-> Either your game is different then mine, because you are using other mods or programs that change the process which are causing my program to crash your game. (Cosmetic mods should be okay though I think.)
-> Or your version of Player-Displayer doesn't have the correct addresses because it is not the latest version.
Can you tell me if you are getting any errors in the black terminal/console thing, any error codes or error messages?

in the past there was an option to show names in game which was useful if playing on fullscreen and 1 monitor. i think the hotkey was ALT+S to activate it.
also, when i press Open player list or Set tekken in window mode, my tekken instantly crashes.

Are you also running the Tekken Overlay?
If yes, that might be the reason. I had the same issue with the game crashing when running this and the Tekken Overlay at the same time trying to switch to Windowed Mode.
But since I use multiple displays this was never a problem for me.

@Loemnk Thank you, that was the cause of my problem. for some reason tekken overlay causes it to crash, but it functions properly otherwise.
@ParadiseAigo Also thanks for the in-depth response. It would be great to have the in-game display feature back in the future if its possible to fix. You are very kind!


fix: build config

Change Summary
not entirely working yet
https://arethetypeswrong.github.io/?p=frames.js%400.4.3
<EMAIL_ADDRESS>Merge Checklist

[ ] PR has a Changeset
[ ] PR includes documentation if necessary
[ ] PR updates the boilerplates if necessary

@davidfurlong @stephancill now the exports are correct for node16 cjs, node16 esm and bundler typescript module resolvers. The issue is with node10 (node) resolver which is able to resolve only the root import.
In order to fix that we would need to restructure package. Another way users can do is to import those files from dist folder (e.g. frames.js/dist/getFrame).


Consider migrating TravisCI to Azure Pipelines

Due to https://docs.opensource.microsoft.com/tools/github/apps/index.html#travis-ci, getting permissions to have TravisCI installed onto this repo seems unlikely. We need a way of displaying CI build status rather than Travis if we can't get permissions. Consider migrating all CI logic to Azure pipelines.

Seems like travis CI is working now. Closing this.


[DT] fix flaky tests

/azp run python - translation - tests

API change check
API changes are not detected in this pull request.


Start when Windows Starts Issue

If I check the "Start when Windows starts" options the applications will not start.  When I uncheck the option and put a shortcut into the Start Menu Startup folder two copies start.

Audio Switcher requires some permissions to start with Windows.
It's uses a more robust way to set the application for startup than the Startup Folder, but sometimes this isn't allowed as a normal user.
I don't know under what circumstances that this functionality isn't allowed, so can't resolve the issue.
I would advise using the Startup Folder, and disabling the settings to start with Windows.

I tried that and it would run two instances.  I found if I delay start for about 20 seconds it starts fine.
Jeffrey Arnold
Sent from my iPad

On Feb 3, 2015, at 4:45 PM, Sean Chapman<EMAIL_ADDRESS>wrote:
Audio Switcher requires some permissions to start with Windows.
It's uses a more robust way to set the application for startup than the Startup Folder, but sometimes this isn't allowed as a normal user.
I don't know under what circumstances that this functionality isn't allowed, so can't resolve the issue.
I would advise using the Startup Folder, and disabling the settings to start with Windows.
—
Reply to this email directly or view it on GitHub.

I'll see what I can do to reproduce this by using the startup folder.
It's likely that there will be no fix for this, as it's intended behaviour to launch multiple instances of Audio Switcher.

I think I know the reason why "Start when Windows starts" doesn't work.
When I open my Task Manager->Start-up tab (Windows 8.1), Audio Switcher already there, but when I right click and choose "Properties" or "Open file location", there's nothing happens. So my guess is the location might be incorrectly registered.
So I checked the registry, it use forward slash (/) instead of backslash ()

Interesting!
I'll have a look at why it's doing that.
Thanks.,

@andykamezou  Looks like there's a quirk in the .NET libraries which cause directories with a # in the name to reverse the slashes.
There's a way to fix it, and I'll fix it for <IP_ADDRESS>

Oooh. I can confirm that. Tried moving it to a dir without # and the slash appears correctly.
I wonder though if it's the same thing causing @dartharnold start-up issue~

I checked the registry and it looks good.
[image: Inline image 1]
I have tried the startup folder and when it is there two instances are
started.
My current work around is to use the program Starup Delayer 3.0 to start
AudioSwitcher with a 30 second delay on start.
On Tue, Feb 3, 2015 at 11:12 PM, andykamezou<EMAIL_ADDRESS>wrote:

Oooh. I can confirm that. Tried moving it to a dir without # and the slash
appears correctly.
I wonder though if it's the same thing causing @dartharnold
https://github.com/dartharnold start-up issue~
—
Reply to this email directly or view it on GitHub
https://github.com/xenolightning/AudioSwitcher_v1/issues/477#issuecomment-72791977
.

There's still some minor issue with the path with # . It's easy to reproduce.

After enabled "Start when Windows starts", the path correctly registered. "D:#portableApps\AudioSwitcher\AudioSwitcher.exe"

Exit the app, relaunch and see the registry changed to the wrong slash "D:#portableApps/AudioSwitcher/AudioSwitcher.exe"

The wrong slash only registered when the app relaunched after exit/reboot.
I think you forgot to update some line in AudioSwitcher.cs?
https://github.com/xenolightning/AudioSwitcher_v1/blob/master/FortyOne.AudioSwitcher/AudioSwitcher.cs#L633
if (Program.Settings.AutoStartWithWindows){
    if (runKey != null)
    runKey.SetValue("AudioSwitcher", "\"" + Application.ExecutablePath + "\"");
}

That should be the change that fixes it.
I'll have another look at it

@andykamezou Doh! You are correct.
That's a hangover from some older code.
I'll update it tonight :)

Encompassed into <IP_ADDRESS>, which is ready for packaging, along with a slew of other changes.
Hence the version increase


Add SDK_VERSION to package.json

Per convos with @ramya-rao-a, following the style of data-tables to have the SDK_VERSION inserted in the package.json. I am not positive but I assume this somehow ensures the constants.ts file is also updated during version bumps.

Moving the constants file under the utils folder was not required. The only requirement was that the cosntantPaths in the package.json file pointed to the right file where the SDK_VERSION was defined.

gotcha. well now it looks the same as data-table regardless, and I like this organization better anyways. :)


Request access token for Office 365 Germany gives ambiguish error

When I am trying to get access token for Office 365 Germany by API call as described on the
https://docs.microsoft.com/en-in/azure/active-directory/develop/active-directory-v2-protocols-oauth-code#request-an-access-token, but it display irrelevant error like below:
{
    "error": "invalid_client",
    "error_description": "AADSTS70002: Error validating credentials. AADSTS50012: Invalid client secret is provided.\r\nTrace ID: 978ed68d-e8b5-419d-8f5c-a25df8f01200\r\nCorrelation ID: 45ee8bb8-b3a1-4d6f-8499-816739f6d118\r\nTimestamp: 2018-07-05 05:39:29Z",
    "error_codes": [
        70002,
        50012
    ],
    "timestamp": "2018-07-05 05:39:29Z",
    "trace_id": "978ed68d-e8b5-419d-8f5c-a25df8f01200",
    "correlation_id": "45ee8bb8-b3a1-4d6f-8499-816739f6d118"
}

Screenshot: http://funkyimg.com/i/2JcXj.png
I have tried after url encoding client secret and making new secret, but I was failed. I have tried many times.
However, Same flow working fine with Office 365 worldwide account.

I would check the documentation here to see if there is anything that looks like you might have missed it.


[WIP]Improve Coverage of zerver/lib/upload.py

#7089

Looks great, I merged the first couple commits, after moving the resize_emoji tests to a new test class.  Thanks @nkmishra1997!

Oh!. I missed one case in test_get_realm_for_filename. I was about to add it though.
 # Test Key is None case
        delete_message_image(path_id)
        self.assertIsNone(get_realm_for_filename("path_id"))

I hope I can add it with some other function's coverage commit?

Yeah, just add another commit in your test coverage PR.


paket install doesn't discover new http dependencies

Unlike github/gist and nuget dependencies adding a http dependency to paket.dependencies and running paket install doesn't add the HTTP remote to paket.lock. Only paket update works

It shouldn't work for github/gist either. SmartInstall takes the source files only from the lock file. See UpdateProcess.fs#L61
We should add newly discovered added source files from the resolution and remove one not more present in it.

Hm, I could have sworn it actually did work for git

I confirm that install indeed doesn't work for gist. However it half works for GitHub. I added a new dependency and it got downloaded (and its own dependencies) but the lock file wasn't updated.

looking into this again

it was already working, but now we detect if something changed and if not we skip resolver phase.


[Addition]: 7x Heltec Hotspot's self witnessing cheating location between the hills

Hotspot b58 Addresses
11icS7FdtFX18hipMFst8umwZEYcPLBygjLSLmNUXR8Ccya8otL
111471fpixgabyeT9z35n9H94Hr7AxbacYfensruhkFq7deMNpG
11ydVRhdEwjkzoC7BjsGf3nPocdVSwfc9t6S5nF86jCHV3YwWUn
112CSmetRhW8CDnbEcZFb39mZgGZ9dYx9hRvRVBKqfuz81oD4LNy
1135wgS6DXAZj9856MJkb1wX51afUk41wNGi88v2ETXBUNUzSJh
112VfJnFFMWsx8LzdYBm2xT6y7jSsnwvrufdtgCLyaEp8kuE3iWh
1122wU1xLiFqJSPU8o7cE5hwg9hCWgy9hHG5DuzALFxcjhjah4JH
Discord Handle
No response
Reason(s)
I have mapped this area and none of these hotspots appears to be there. The mapping was done on 13 aug 2022. They are all heltec but on different wallets. The area is between hills but i drove all around the area. one of the hotspots seems to have had invalid witnesses in Latvia and Moldova in the past days

https://user-images.githubusercontent.com/59395917/190397762-db894aa8-01b8-45d6-bac5-5e82438057cd.mp4


IE crashes when we load SVG assets

Got this error in Internet explorer 11 (running on laptop with i5 processor, 4gb ram) . I was loading only svg assets from https://www.dropbox.com/sh/9s1xvbsnukx6u70/AAC3lAt_9xkiTfcPkwGM8Jfba?dl=0 .
viewer = Crocodoc.createViewer(element, {
   url: magazinePath,
   layout: Crocodoc.LAYOUT_VERTICAL_SINGLE_COLUMN,
   enableTextSelection: true,
   enableDragging: false,
   useWindowAsViewport: true
});
viewer.load();
scope.currentPage = 1;

viewer.on('ready', function (event) {
   scope.$parent.viewerNumPages = event.data.numPages;
});

viewer.on('pagefocus', function(page) {
   scope.$apply(function() {
      scope.$parent.viewerCurrentPage = page.data.page;
   });
});

@harish278 I can't access the dropbox link to reproduce this issue. Could you share a downloadable View API session or host the file somewhere else? Thanks.

http://www.4shared.com/zip/c3ty5ndpba/content.html

@harish278 please just send the original pdf to<EMAIL_ADDRESS>

@harish278 @lakenen Sent the PDF.

@lakenen Is there anything else that we can do specifically to help you with reproduction of this issue?

@harish278 I was able to reproduce the issue. IE is apparently running out of memory, perhaps because of the number of large images in the document. It can be resolved by unloading the pages fully. There's unfortunately no exposed option in viewer.js for forcing this behavior, but I could patch the library to unload pages fully in IE 11 (currently this only happens in mobile and IE < 10).

@lakenen This is good news (that you can reproduce the issue that was reported). As far as we are concerned, we want to make sure that we have stability on mobile (rather than get Desktop IE to work). We would welcome this patch. Exposing this option would actually allow us to tweak the behaviour for every kind of browser.

@lakenen I don't want to sound pushy, but do you have any estimates when we can expect this? This is still a production issue for us at the moment and I would like to be able to give some kind of resolution to it. If it's not possible at the moment, please also let me know, so I can explain that. Thanks!!

@peetersn sorry about the delays here. I'm nervous about exposing this as an external config, because it's very low level and could change in the future. Instead, I'm probably going to refactor this code a bit such that it'll be possible to write a plugin that modifies this behavior. This could still break with updates to viewer.js in the future, but it makes me feel better knowing that it's not published as an external API.
In the mean time, you could test for IE and force PNG representations.

@lakenen,

Having PNG assets along with the SVG makes the size of the whole file (with all assets) increases the size considerably.

Couldn't have only PNG assets, as the quality was not as good as SVG assets in high end devices.

Tried a hack by having:

if (window.navigator.userAgent.indexOf('MSIE ') || window.navigator.userAgent.indexOf('Trident/')) {
    Crocodoc.getUtility('support').svg = false;
}

for IE which worked, but couldn't have due to problem with size (point 1).

Has there been any progress with resolving this? We are having similar problems with running out memory in IE 11 when using the viewer.

@xgibster No, waiting for @lakenen's code refactoring.


Redis memory alerts

Summary

Adding alerts per https://github.com/sigstore/public-good-instance/issues/1037

Definitely would have caught the last incident (graph)


Create a central collection of constants

We agreed to only move the clippath from Constants.js to the component that uses it. The other two derivation path constants can stay. Everything else also stays on its respective classes as static properties.


Improve Markdown syntax highlight for lists and headings

According to the CommonMark spec, you should not have to add a line break before a list. I personally also fully support this, as having those extra empty lines in the middle of text wastes a lot of vertical space and hurts readability. No line break feels natural and is generally supported by Markdown implementations.
This is the CommonMark description:
https://spec.commonmark.org/0.30/#principle-of-uniformity
(The description about lists interrupting paragraphs starts a few lines above.)
In short, I want to be able to write lists like this:
This is a list
- List item
- Another list item

Not like this:
This is a list

- List item
- Another list item

Cheers!

I've moved the issue to the repository that contains the markdown grammar used for syntax highlighting. Please take a look at updating it to fix this issue

So if I understood that right the first part of this issue is about the formatter; if you format the document it will add a line break between heading and entries of the list as well it adds indention to the entries and you want both of them to be changed.
The second would then be about the highlighting (coloring in this case) which is done automatically. Am I correct with that assumption?
If I am right with that, my question for @mjbvz is the following: Is this repository also responsible for the formatter part or just for the grammar (which includes the coloring part)? I experienced that the markdown formatter is not part of a fresh build of vscode. The formatter you @Stakker are using is likely provided by an external extension e.g. Prettier?

Also why is there a file extensions/markdown-basics/syntaxes/markdown.tmLanguage.json in the vscode repo that also contains a grammar for markdown (they are slightly different)? What's the difference between these two?

I am not using a formatter, this is all about syntax highlight/colors (which uses TextMate grammar, I think?). Let's forget the line break for now — that was just a misunderstanding of what is happening from me :-)
So, it seems that the only problem is that not all of Markdown syntax is implemented in the grammar (or whatever you officially call it... VS Code only highlights some Markdown syntax).
Headlines (using '#') and code blocks are highlighted. Lists are not highlighted at all. At least that's what it looks like.
So, what needs to be done is implement lists into the Markdown grammar. (Start a new line with a dash (minus), plus or an asterisk or a number follower by a period, and it is recognized as a list and colored accordingly. And you should not need to add a line break before a list for it to be recognized as a list.)
If you are going to be poking in the grammar, it would also be great it could also recognize headings underlined with "-----" or "=====", because now the syntax only understands headings that start with '#'.
There is also more (https://www.markdownguide.org/basic-syntax), I think these are the most essential basics.

Allright, implementing the underline to make it a header should be doable.
But how do you like lists to be highlighted? If I run VSCode without other extensions (so just the vscode-markdown-tm-grammar is enabled) at least the dashes (or enumerations like "1.") of the list entries are already colored blue-ish instead of white (stock dark theme).

Ahh, so it does... It seems I'm using a theme (one of the Dayle Rees themes) that doesn't support it.
I did check it out with the default theme earlier, but then I was still misusing the code block syntax thinking they are lists, so I missed that. It also seems that the default theme doesn't implement code block syntax, but it is in the grammar, since the Dayle Rees theme highlights it.
I definitely think just highlighting the first character (especially a tiny dash) is not as clear as highlighting the whole contents of the list though. Attached is an example of how Sublime Text does it, and I think this is just much more useful and clear.
I would also like for the underlined headlines to be highlighted, not just the underline.
But now I'm not sure how much the grammar can change this behavior? Is this actually up to the theme or the grammar to decide how much is highlighted? Sorry about my ignorance here, I don't really know anything about the innards of VS Code.

Okay, I will work on the implementation of entries that are completely colored and headings that are defined with underlinings (with '#' and '-').

I appreciate you looking into this!

@dev-manuel Yes thanks for investigating. VS Code has never provided a built-in markdown formatter so this issue is focused just on the syntax highlighting part of the issue
Also keep in mind that how code is colored is are ultimately up the themes. We just want to make sure the parsed document has the right set of tokens so that themes can color it as they wish

Also looking over the original issue again, both style lists appear to work for me:

@Stakker Have you tested with other themes to confirm this isn't a theme specific problem?

Ah, so it is up to the theme after all... I have tried other themes, but I managed to the pick exactly the ones that don't fully color lists :-P (Like Monokai, and also the default theme.)
Thank you for your patience and sorry about wasting your time with this... At least I learned something :-) I guess I just need to learn how to customize/make themes.

Ok, thanks for following up. Closing as by-design


[cherry-pick] [branch-2.4] [Enhancement] limit the number of migration task sent to BE (#10124)

Add a new configuration tablet_sched_max_migration_task_sent_once
to control the number of migration task sent to BE on every tablet
report.

run starrocks_fe_unittest


High availability of the visibility extension API server

What would you like to be added:
Enable high-availability setup for the visibility API service.
Why is this needed:
It's possible to deploy multiple replicas of the Kueue manager.
High-availability of admission webhooks has been fixed with #1509.
However, more work is required to enable high-availability for the visibility API service, given the stateful nature of the ClusterQueueReconciler.
More context is available in #1509.
Completion requirements:
This enhancement requires the following artifacts:

[x] Design doc
[ ] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

Thanks for raising this issue. Yes, the visibility server needs to access the queuemanager in spite of the kueue-controller-manager doesn't start the queuemanager when that replica isn't primary.
I think we can select the following options:

Launch visibility servers separate from kueue-manager, then that server gets information from the primary kueue-manager.
The secondary kueue-manager gets information from the primary kueue-manager.

@alculquicondor @mimowo WDYT?

Another solution would be for all managers to be able to serve the information. This is possible if every manager can react to the events to update the cache and queues, even though it wouldn't be scheduling.
We do the same in kube-scheduler.
However, I'm not sure if, in controller-runtime, event handlers are registered even if reconcilers aren't running. I would not expect so, otherwise the work queue would grow indefinitely.

Another solution would be for all managers to be able to serve the information. This is possible if every manager can react to the events to update the cache and queues, even though it wouldn't be scheduling.
We do the same in kube-scheduler.
However, I'm not sure if, in controller-runtime, event handlers are registered even if reconcilers aren't running. I would not expect so, otherwise the work queue would grow indefinitely.
Continue the comparison, in kube-scheduler we don't have reconcilers at all.

When all managers can serve the information, is there a synchronization gap between managers In busy clusters?

Yes, some managers might be ahead of others. But it shouldn't really matter, as even the output of the leader can be out of date pretty quickly.

An alternate approach would be to have all webhooks running in a separate Pod, so they can serve in HA. And then we would have the scheduler+visibility server in a different Pod, where only one Pod can be ready at a time.

Another solution would be for all managers to be able to serve the information. This is possible if every manager can react to the events to update the cache and queues, even though it wouldn't be scheduling.

That sounds like the best option functionally, and in an overall eventually consistent system, I agree it's acceptable to have some synchronisation gap between replicas, as they converge toward the stationary state.
I just had a quick look, and it seems like it should be possible to have all the replicas serving the visibility API, with the event watchers running and maintaining the cache / queue manager, but skipping reconcilers altogether in non-leading replicas.
I can work on a PoC to validate the feasibility and share my findings.

/assign

I've open #1554, that gives an idea about the most minimal / less disruptive approach I could come up with. There may be other  ways, like separating the reconciler part from the watchers part of the controllers that contribute to the queue manager, but that felt more disruptive / risky.
I've successfully tested #1554 manually, by checking all replicas correctly serve the visibility API, also checking fail-over to a non leading replica works as expected when the leading replica terminates.
That should ideally be covered by an e2e test. I was thinking we could have a new e2e test dedicated to covering the HA aspects, including webhooks as well, to guarantee non-regression for #1445. WDYT?

We can probably just configure the existing tests to run in HA mode. But we can have a separate suite package to exercise restarts.

Right, running existing tests in HA mode sounds like a good idea. It won't guarantee non-leading replicas work correctly, given the API server can still send traffic to the leading one. Having a separate test suite exercising HA and all replicas specifically  can mitigate that in a second step.

I've updated #1554 so the e2e tests deploy two replicas of the Kueue controller manager. The e2e tests pass, and we can see the two Pods for Kueue deployment in the run below, where their respective logs look correct / as expected to me:
https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1554/pull-kueue-test-e2e-main-1-29/1745014001227534336/artifacts/run-test-e2e-1.29.0/
How would you like to track the work for that dedicated HA e2e suite package? Maybe I can create a separate issue, or you have another suggestion / preference?


Bridge Overhaul using a hard grid

Motivation
Until now we have used a soft-grid approach were the grid is implied but not actually used. This has caused issues in implementation. This is a trial at a new approach using a hard grid. Details about the functionality are found in the wiki at https://github.com/mango-gremlin/arch-enemies/wiki/03-Bridge-Using-Hard‐Grid.
Testing
Here is a short demo. But trying it yourself might be a good idea.
https://github.com/mango-gremlin/arch-enemies/assets/65815628/c985a695-82ca-49ac-852f-6607da5928b5
Additional Information
This is very much just the simple groundwork. Much improvement is possible. Many of the features desired should be much easier to implement in this frame work.

just some observations/questions:

I couldn't figure out how to place something until I realised you place it where the mouse cursor is pointing to and not the animal itself, maybe the animal could follow the cursor more closely?
you can't drag animals again after placing them? (I know about the undo button but it makes bridge building more tedious than before)
you should be able to place the spider in more places (e.g. underneath the snake)
dragging nothing also activates the hitbox visibility

But overall very impressive, well done!

Just in case some others run into the same observations.

I couldn't figure out how to place something until I realised you place it where the mouse cursor is pointing to and not the animal itself, maybe the animal could follow the cursor more closely?

Yes, this is something that can be addressed. It is a bit annoying, because you have to orient the created TRect, but it should be doable. The dragging options already in godot are just inherently janky.

you can't drag animals again after placing them? (I know about the undo button but it makes bridge building more tedious than before)

This would be extremly hard to implement, because then each placed animal would have to create a node that can be dragged and each dragging of an animal would have to check if it makes other animals position illegal. I would not recommend implementing that. Personally, I do not think that using reset and go back is much more of a hazzle and has a charm of its own, but that is something for game-design to discuss and deciede.

you should be able to place the spider in more places (e.g. underneath the snake)

I was not fully caught up with the logic of how and when objects can be placed. But this is an easy fix, if there are zones that are not FORBIDDEN or ALLOWED but instead CONDITIONAL, then you would just have to add that as an Entity-Type and update some functions to account for that.

dragging nothing also activates the hitbox visibility

The dragging currently has the bug that if you place nothing the hitboxes are shown permanently. That is the bigger fix and trying to drag something other can be done as a side fix.

Also added Conditional Zones as mentioned in the comment by aylinfi.


"Look rotation viewing vector is zero" gets printed continuosly in MRTK 3

I was trying to update raystep by collecting the origin from MRTKRayInteractor->rayOriginTransform and endRayposition using MRTKRayReticleVisual->Reticle, "Look rotation viewing vector is zero" is getting printed continuosly in MRTK 3
Below is the sample code,

@hemasree99s why do need to access the ray origin transform and reticle transform?  If this is for obtaining the interactor's intersection points, I would recommend not doing this.
Instead see my response your discussion post here:
https://github.com/microsoft/MixedRealityToolkit-Unity/discussions/11636#discussioncomment-6364662


Feature: Expose a registry configuration option

:gift: Allow folks to specify the registry chainctl uses to facilitate migration to cgr.dev
/kind feature

going to update images to do this directly.


Addition of model building scripts to applications

Hi @farizrahman4u,
I have a few scripts can be used to build keras models of recent papers. Some of them are :
Finished models with weights
Inception v4, Inception-Resnet v1, Inception-Resnet v2 (weights  available for Inception v4 - via https://github.com/kentsommer/keras-inceptionV4, and therefore he should add a PR)
Wide Residual Networks (weights for WRN-16-8 and WRN-28-8 for theano backend are available)
Residual of Residual Networks (weights for RoR-WRN-40-2 is available for theano backend)
DenseNets (weights for DenseNet-40-12 available for theano backend)
Custom Callbacks
Snapshot Ensembles (ensemble weights for CIFAR 10 (Wide ResNet - 16 - 4) and CIFAR 100 (Wide ResNet - 16 - 4) are available for theano backend)
My question is : are they worth the addition to the applications folder? And if so, should the weights be hosted in the original repositories or over here?
Moreover, for snapshot ensemble, the example is more important than the custom callback (snapshot ensemble can be used for any model, it simply requires 3 different callbacks to work). The main difficulty is how to use the ensemble model weights to predict (and or simply calculate accuracy).
So should an example be added as well in the examples directory of keras_contrib?

are they worth the addition to the applications folder?
Yes
should the weights be hosted in the original repositories or over here?

@patyork  What do you think?

So should an example be added as well in the examples directory of keras_contrib?

Yes.

Weights (and any large files, such as datasets) should be hosted elsewhere - not within this repo or in Keras. Another Github repo is okay, although I'd recommend AWS or google drive or something to that effect.
On that note, there should be a test to check that external files still exist (not necessarily download it, just check for a non-404/503 http response). The maintainers should also probably host a copy of the files, and the applications/dataset code should allow fallback to the copies. Ex:
applications = {
     'vgg16' : [
             'http://original_file.com',
             'http://copy1.com' ]
     ...
     ...
}

@farizrahman4u  @patyork Thanks for the input.
I'll start with Snapshot Ensemble, since it is just 1 callback builder. On that note, Snapshot ensembles is basically a collection of 3 callbacks :

A custom model saving callback (SnapshotModelCheckpoint)
A custom learning rate scheduler (use LearningRateSchedule callback with cosine annealing schedule)
(Optional) A ModelCheckpoint callback which saves the weights of the single best model. I say it is optional, but in fact this one alone increases the ensemble score by approximately 0.3 - 0.5 % on average.

It can be seen here : https://github.com/titu1994/Snapshot-Ensembles/blob/master/snapshot.py
I can see that having a builder class build the 3 callbacks is not in the standards of keras or keras_contrib, but it makes it simple to perform snapshot ensemble on any given model.
So, should I split the class into separate callback and schedule, in which case I don't know where to place the custom schedule, or do I add the entire snapshot.py to the callbacks directory?

I think it's fine to have a builder class that returns a list of 3 callbacks, there are no such complicated callbacks previously in the keras repo.

@kemaswill Thanks for the input.
On another important note, should I add an example of how to use the callback? Its pretty straightforward, but it may be helpful for beginners.
A more important example in my opinion is how to use the ensemble weights to improve the accuracy of the model. I have a script here which shows how to optimize the score using the ensemble weights of a  Wide ResNet model, and how weighted classification can improve the score : https://github.com/titu1994/Snapshot-Ensembles/blob/master/predict_cifar_100.py
I fear that may be beyond the scope of what we are trying to do with the contrib repo, so for now I am only considering adding a script to train a classifier with snapshot ensemble classifier.

I'm reviewing @titu1994 's PR now, there're several questions: How should one commit a new example? Should this be pushed to 'keras_contrib/applications' or 'examples'? I think we should only choose one directory, just as the original keras repo does. If so, which models should be pushed to 'keras_contrib/applications' and which should be pushed to 'examples'?

@titu1994 I think a Snapshot Ensemble example is fine for how to use such callback, so you can create one PR consists of an Snapshot Ensemble example and a new callback function.

@kemaswill An example is useful for showing how Snapshot Ensemble callback builder can be used, because there are no other callback builder patterns in either Keras or Keras Contrib.
However, there isn't much need of adding the other examples, for the DenseNet, Wide ResNet and RoR Networks. Shall I remove those examples?

I actually like having both the examples and applications since they serve somewhat different purposes. What do others think?

@titu1994 What do you think about modifying one of your current PR examples to incorporate the Snapshot Ensemble?

@the-moliver Ok if it is valuable to have the training script as well, then I'll keep them in the DenseNet, RoR and WRN PRs.
On the note of modifying one of my PR's to add a Snapshot Ensemble example, if it's OK, I'd like to add that as a separate PR next week. The main reason is I'm a bit tied up with assignment work, and the weights for the ensemble model need to be translated to the different backends first.
Also, the snapshot ensemble needs two examples :

A training example, which shows how to use the SnapshotCallbackBuilder to generate the list of callbacks and train.
An ensemble prediction example, with 2 different flavors.
a) One if straight up even weight scale for all snapshot models, which leads to a pretty high score.
b) Other is using score maximization approach (random weight initialization, and then subsequent application of optimization algorithm to find optimal weights for the snapshot ensemble).

2-b delivers much higher scores than 2-a, but the approach is quite technical, and not really suited as an example. For examples, see Performance table at https://github.com/titu1994/Snapshot-Ensembles
In your oppinion, which of the two examples, 2-a or 2-b should I add as a PR along side the 1st training example?

A separate PR demonstrating both training and prediction is fine. Regarding 2-b, it looks like you are optimizing the weights on each model based on the test set prediction. That is bad practice and not to be encouraged! (This is just fitting to your test data, so of course the performance on the test set will improve) However, you could find these weights on the training data, and I would be curious to see if they result in test set performance improvements. If this does result in significant improvement, I'd love to include it, otherwise we'll go with 2-a.

I can alter the test to look at the training data instead. I dunno what I was thinking making it look at the testing data.
Now that I remember if I did write that code just before my shift to the US so I was quite time strapped. Will edit it once I have some time.

@titu1994 OK, so just keep both the applications and the examples.

@kemaswill So I was wondering, Snapshot Ensemble was originally used on WRN and DenseNets.
I have the pretrained weights of WRN-16-4 models on CIFAR100, so should I just give an example to train on WRN and another script to predict using ensemble weights?
@the-moliver So I fixed the prediction script, and it works well by obtaining the ensemble weights from looking only at the training data and then using those ensemble weights to weigh the test predictions. It offers just about the same improvement as before (slightly less by 0.03%).
Should I add those scripts then as another PR?


Breaks copy and pasting of nodes

I must have something conflicting but this breaks copy and pasting of nodes for me.  It seems like whatever .json gets loaded in the clipboard gets stuck.  Selecting nodes and using Ctrl-C  doesn't reload anything into the clipboard.  This is the error I'm seeing in the console.  Removing the workspace manager restores the function.

looking at it! sorry about this

ok the problem is caused by ChakraProvider, if i remove ChakraProvider from main.ts then it will work. I have no idea why ChakraProvider could affect clipboard.
But I may have to switch to other UI frameworks. This may take 1 day of effort to finish....😕

i just pushed the change that should fix this: https://github.com/11cafe/comfyui-workspace-manager/commit/f1e2ebf9208e3ee43db679c607338a5a38c5f1e1
please pull the latest update and see if the problem goes away. please let me know!!

Looking good!  Testing continues...


Classic Pipeline documentation seems to be missing. Links to it take the user to the release pipeline documentation instead

The documentation for classic pipelines GUI editor seems to be missing. It cannot be found anywhere on the TOC on the left. Additionally, the links on pages such as Create your first pipeline and Use Azure pipelines that are supposed to navigate you to the classic pipelines getting started documentation navigates you to the "release" pipelines documentation instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ad567ab-0513-570b-74dc-a0827815c6a1
Version Independent ID: 5e549605-cac8-98ea-ac5b-89f4a40a5f3c
Content: Create your first pipeline - Azure Pipelines
Content Source: docs/pipelines/create-first-pipeline.md
Product: devops
Technology: devops-cicd
GitHub Login: @steved0x
Microsoft Alias: sdanie

cc @brandonmartinez

@WilliamAntonRohm I tagged @brandonmartinez on my team for awareness only. I'm not sure he's the right person to have this assigned to?

@landonpierce -- Landon, thank you for clarifying.  Steve is the author.
#reassign:steved0x


add vibrant rc pubnet to list of supported wallets

What
This is a change we needed to make when deploying SDP to prd (mainnet).
Why
Known limitations
[TODO or N/A]
Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
[ ] This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

[ ] This PR adds tests for the new functionality or fixes.
[ ] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[ ] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[ ] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[ ] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[ ] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[ ] This is not a breaking change.
[ ] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr43.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr43.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr43.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr43.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr43.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr43.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr43.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr43.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr43.previews.kube001.services.stellar-ops.com


Clean db files add human reads filter method

coverage: 92.814%. remained the same
when pulling e3253cd839ceead409f0abfa3d894569c07d0d58 on antgonza:clean-db-files_add-human_reads_filter_method
into 751e5594b98b62d53beb07518e9b0a4b84ece684 on qiita-spots:dev.


Make default config clearer

Fixed a small typo (... that doesn't shows ...)
Make it clear that it should be without backticks

:fire:

related to #1377


[REVIEW] multi target support for TE

Supporting multiple Target columns for Target Encoding. https://github.com/NVIDIA/NVTabular/issues/303

run tests

Can you add a unittest that tests this functionality out?

Added example in unittest

rerun tests


refactor(query-core): replace indexOf with includes

This PR replaces the use of .indexOf with .includes for cases where the method is used to check if an array contains a particular element. This results in improved code readability and better adherence to modern JavaScript best practices.
The replaced code snippets include:
- `.indexOf(...) === -1`
- `.indexOf(...) !== -1`

There is a prefer-includes rule ^1 that enforces this, but it is in the strict preset.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@00319a1). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5431   +/-   ##
=======================================
  Coverage        ?   91.79%
=======================================
  Files           ?      101
  Lines           ?     3890
  Branches        ?      974
=======================================
  Hits            ?     3571
  Misses          ?      298
  Partials        ?       21

Impacted Files
Coverage Δ

packages/query-core/src/mutation.ts
94.17% <100.00%> (ø)

packages/query-core/src/query.ts
99.03% <100.00%> (ø)

packages/query-core/src/utils.ts
94.11% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: harpoon telescope integration

At the moment if your config doesn't specify enableTelescope in the harpoon options you get the following:
Harpoon config:
      harpoon = {
        enable = true;
        tmuxAutocloseWindows = true;
        keymaps = {
          addFile = "<leader>ha";
          toggleQuickMenu = "<leader>ht";
          navNext = "<leader>hn";
          navPrev = "<leader>hp";
        };
      };

Error:
error:
       … while evaluating a branch condition

         at /nix/store/4smdp3v5a9bcg1hpdhl2hs70rq385ykq-source/lib/lists.nix:57:9:

           56|       fold' = n:
           57|         if n == len
             |         ^
           58|         then nul

       … while calling the 'length' builtin

         at /nix/store/4smdp3v5a9bcg1hpdhl2hs70rq385ykq-source/lib/lists.nix:55:13:

           54|     let
           55|       len = length list;
             |             ^
           56|       fold' = n:

       (stack trace truncated; use '--show-trace' to show the full trace)

       error:
       Failed assertions:
       - Nixvim: The harpoon telescope integration needs telescope to function as intended

I think we should default it to false and make users turn it on.

This seems strange, because mkEnableOption should already default to false

it could be the assertion logic is incorrect ?

yeh i think the assertion logic shouldve been reversed my bad :sweat:
if harpoon extension enabled -> telescope is enabled

Why have you removed the keymapsSilent option ?

my bad fixed now!

good to know! For next time.


Update PR actions

Yet another try to fix the pr actions:

Be more explicit about the branches & remotes used throughout the run
Add some feedback (the otel bot will add comments to the PR before & after (failed) actions)

/fix:format


fix: add auth.jwt() function

What kind of change does this PR introduce?

Add auth.jwt() function to return the user's jwt claims
Add comments to signal deprecating auth.email, auth.uid, auth.role and to use auth.jwt instead

Would auth.uid() be removed at some point after deprecation, or does existing project have access to auth.uid() indefinitely?

hmm yeah i think we've decided to not deprecate the auth.uid() function in view of convenience since doing auth.jwt()->>'sub'::uuid everytime is gonna be pretty annoying
will remove the comment to deprecate that function
cc @kiwicopple

The deprecation notice on auth.uid() still seems to be there and was confusing me today. And I very much agree that having a short-hand for that is worth it. Actually, I tend to think the same for auth.email() even though it's probably used a lot less. And I think, the deprecation notice for auth.role() should point to https://github.com/orgs/supabase/discussions/16703 because using auth.jwt() -> 'role' in RLS rules instead is not the intended effect of the deprecation.


DB-23276 fix CTE queries

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Ah, no because this still hasn't been merged https://github.com/ocient/superset/pull/12


feature: Make recent https calls displayed at the top of the http call list.

Discard using v3.2.0 as a based branch due to there is a dependencies conflict.


FIX password validation min length message

When relying on static config instead of an explicitly set minLength then this message would show without the value, like "it must be  or more characters long".

Just kicking travis, sorry for the noise 😛

Thanks @matt-in-a-hat - I've merged that up to the 4.3 and 4.4 branches for you - should be merged into 4 shortly.


optimized cpu usage and spin loop callback

This patch optimizes cpu usage. Message are processed immediately now which is desired especially for real-time tasks (like balance control) and data synchronization. Before messages have been hold back up to 100ms (sometimes even 1s).

applied to develop branch.


Rename Navs to Navs and Tabs

Fixes #31378
/cc @patrickhlauke

hah, had that issue of mine on my perennial "need to really do a PR when i find a minute..." pile. thanks, will review now.

build fails. i believe you also need to change the title: in the renamed navs-tabs.md file

i believe it also needs changing in the overview.md file for components (see the changes I had to make back when i renamed checks) https://github.com/twbs/bootstrap/commit/490acf60ca149e88e669f2b3f157dd326dad9573


When SendMetrics fails and calls HandleMetricsErrorResponse it throws an exception

Describe the bug
Took a while to find it, the issue started acting up in our system since 2024-11-21 and was introduced by bumping to version 5.0.0
This version deprecated the custom serializers.
All our tests went fine but we didn't notice that sending back metrics started failing. With the following message:
Input string was not in a correct format. Failure to parse near offset 293. Format item ends prematurely.
To Reproduce
Steps to reproduce the behavior:

Create a valid call with the client
Execute the "fetch-feature-toggles-task" manually or automated
Verify a feature using the IUnleash.IsEnabled functionality (not sure if it is needed)
Wait until the report metrics interval is expired, when it is either automated or manually fire the "report-metrics-task"
The response returns that it was not successfull
It fires the HandleMetricsErrorResponse method
If fails at extracting the error

Expected behavior
It shouldn't fail trying to obtain the error but give a hint why it was not successfull instead.
Screenshots
Highlighted the issue as the response.StatusCode although not valid caused it to go to this method.

Desktop (please complete the following information):

C# Containers & lambda

Smartphone (please complete the following information):
N/A

Thank you for raising this @PhbsSmn, we were able to reproduce some aspects (but not all) of this. When metrics were not recorded the SDK would send null metric buckets to Unleash, and Unleash would return a 400 Bad Request. We have a fix on the way out for this.
That said we were able to see the 400 Bad Request error in the SDK when used directly towards an Unleash instance, are you using something between the SDK and Unleash? Proxy/Edge? Some kind of network gateway that could be mangling 400 responses?

I think we are using a proxy but not 100% certain, I will ping to the team responsible for this on our end.
We stumbled by accident also on a massive increase of request but not certain if this is related

@PhbsSmn those are some big spikes indeed, I think you have a separate conversation going about that with our team, is that correct?
We shipped the update to metrics, it now sends default-buckets instead of null buckets. Unleash.Client 5.0.3. Let me know if you are able to update to that and if that helps the issue.


[WIP] HTTP framing implementation

Relates to #22.

Almost done !
Still have to implement ignoring some frame fromated as described in 4.2.10. Reserved Frame Types  and a last check against the specs.


Dockerfile workflow

We can provide a builder which builds a Docker image based on a Dockerfile as the build artifact and generate SLSA provenance for it.

A good point of comparison would be the docker actions for building and pushing images. They use buildx in their case and support building for different architectures using qemu.
https://github.com/marketplace/actions/build-and-push-docker-images

Generating a provenance based off a Dockerfile is a great start. You may also want to see how the same could be done for builds using tools like ko and buildpacks. These are both very popular alternatives to managing Dockerfiles.

For sure. I think @laurentsimon shared https://github.com/laurentsimon/slsa-github-generator-ko with you on slack maybe, but the idea is we will eventually merge that workflow here as well.
Buildpacks is a good idea but I think getting provenance generation for simple Dockerfiles working is probably a higher priority for now. We're happy to take issues and contributions if folks want to take on specific workflows or features.

This sounds like it can be a very useful workflow. Any progress on it? Doesn't look like it has been picked yet.

Is this done?

It is not. @ianlewis started it but it's not complete yet. Maybe in the meantime you could use:

https://github.com/slsa-framework/slsa-github-generator/tree/main/internal/builders/docker. You create an image as a dockerfile and use that to build your artifact. See https://slsa.dev/blog/2023/06/slsa-github-worfklows-container-based
https://github.com/slsa-framework/slsa-github-generator/tree/main/internal/builders/container build the docker image yourself and get an attestation for it


non-cross platform chars in file name.

Trying to clone a repo on windows gives an error because of stream char ":" in
error: invalid path 'public/favicon.ico:Zone.Identifier'

removed, should be fixed.


Take latest Node.js version in shell.nix by default

To resolve
error: Package ‘nodejs-16.20.2’ is marked as insecure, refusing to evaluate.

       Known issues:
        - This NodeJS release has reached its end of life. See https://nodejs.org/en/about/releases/.

Thanks @carlthome !


Generate a STAC for a single overture release.

This PR introduces a script that emits  a STAC Catalog for a single Overture Data release (link)
(read more about stac Catalogs, Collections, Items, and Assets and how they interrelate here)
The PMTiles STAC is pretty much just a straight directory listing of the s3 bucket- The main release catalog has one collection in it per release, each collection has one item per pmtile that contains an asset link to that PM Tile. Pretty simple.
The geoparquet release contains much more interesting stuff, so let's dig in to that:
The basic idea is that each geoparquet release is a Catalog, with sub-catalogs per theme.
flowchart TD
        Catalog(Top-level catalog.json) --Addresses--> Addresses(addresses/catalog.json)
        Catalog --Divisions--> Divisions(divisions/catalog.json)
        Catalog --Buildings--> Buildings(buildings/catalog.json)
        Catalog --Base--> Base(base/catalog.json)
        Catalog --Transportation--> Transportation(transportation/catalog.json)
        Catalog --Places--> Places(places/catalog.json)

The top-level catalog implements the 'Storage' STAC extension, which gives bucket url params for both AWS and Azure use cases, including information about whether the requester pays, etc.
Each theme catalog points to one or more Collections for each of its types.  Addresses is very simple, as it only has one type, 'Address'.
flowchart TD

Catalog(Address Catalog) --> Address(address/collection.json)

Buildings theme has two types, 'building' and 'Building_part':
flowchart TD

Catalog(Buildings Catalog) --> Building(building/Collection.json)
Catalog --> Address(building_part/Collection.json)

Each Type collection has a list of linked items associated with it- each with a distinct id. The Items identify STAC Assets; each asset is a single geoparquet file in an overture release.
For example, the address type collection has the following definition:
{
  "type": "Collection",
  "id": "address",
  "stac_version": "1.0.0",
  "description": "Type information",
  "links": [
    {
      "rel": "root",
      "href": "../../catalog.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00000/00000.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00001/00001.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00002/00002.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00003/00003.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00004/00004.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00005/00005.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./00006/00006.json",
      "type": "application/json"
    },
    {
      "rel": "parent",
      "href": "../catalog.json",
      "type": "application/json"
    }
  ],
  "extent": {
    "bbox": [
      [
        [
          -180.0,
          -90.0,
          180.0,
          90.0
        ]
      ]
    ]
  },
  "license": "ODbL",
  "summaries": {
    "columns": [
      "id",
      "geometry",
      "bbox",
      "country",
      "postcode",
      "street",
      "number",
      "unit",
      "address_levels",
      "version",
      "sources"
    ],
    "schema": "1.1.0"
  }
}

Here is an example address item definition, with the enclosed Asset declaration:
{
  "type": "Feature",
  "stac_version": "1.0.0",
  "stac_extensions": [],
  "id": "00001",
  "geometry": null,
  "properties": {
    "datetime": "2024-09-18T00:00:00Z"
  },
  "links": [
    {
      "rel": "root",
      "href": "../../../catalog.json",
      "type": "application/json"
    },
    {
      "rel": "collection",
      "href": "../collection.json",
      "type": "application/json"
    },
    {
      "rel": "parent",
      "href": "../collection.json",
      "type": "application/json"
    }
  ],
  "assets": {
    "parquet-part-00001-ab657a87-ddf4-44f2-a96c-d573fcab4818-c000.zstd.parquet": {
      "href": "/theme=addresses/type=address/part-00001-ab657a87-ddf4-44f2-a96c-d573fcab4818-c000.zstd.parquet",
      "type": "application/vnd.apache.parquet"
    }
  },
  "collection": "address"
}

Note that the href in the asset specifier is not absolute- This is because the consumer o this manifest might be using either aws or azure base paths (which are specified in the root-level catalog for the release). We leave it to the client to join the base bath with the asset URL.

I should make sure that the relative asset URLs start with ./ to better get across that they should be concatenated.
Or perhaps I should even put a url format specifier in there like
'{blob_storage_base_path}/`?

I should make sure that the relative asset URLs start with ./ to better get across that they should be concatenated.
Or perhaps I should even put a url format specifier in there like
'{blob_storage_base_path}/`?

Done.

Open Questions from 10/29 tf-dataplatform meeting:

Where exactly this manifest will be placed?
What tools will break if we place the manifest inside the release folder?

Open Questions from 10/29 tf-dataplatform meeting:

Where exactly this manifest will be placed?
What tools will break if we place the manifest inside the release folder?

The manifest can be placed anywhere- there's no need for it to be co-located in the same bucket. Heck, it can even be hosted straight from the overture web site.

This is because the top-level catalog.json has the bucket URL defined in it for both Aws and Azure, and down at the lowest asset level (the info for a single geoparquet file) the file path is relative to that top-level bucket.
As far as #2- I don't know!

Ideas for the version 2 of the storage spec- use the name and switch it up for the use of alternate assets for each Geoparquet item.
Also use the themes and tables extensions.


Typo in message after initial sign-in

After signing in with my ORCID for the first time, the following message appeared (emphasis mine):

Before you can submit a notebok to NeuroLibre, you need to add your email address and GitHub handle to your profile →.

The typo seems to be located at:
https://github.com/neurolibre/neurolibre/blob/2a9c8e81d4e9d5ad1cab3902dac25fc212179b87/app/views/shared/_profile.html.erb#L2

Thanks for reporting!


increase timeout for macos

In https://github.com/Lightning-AI/lightning-thunder/actions/runs/8974221177/job/24646125828, the issue was this test (notice the 9 min difference)

which is curious because the test is not that complex: https://github.com/Lightning-AI/lightning-thunder/blob/main/thunder/tests/test_patterns.py#L59-L101
If you have other failed builds I can take a look. This might be caused by test interactions. Worst case I can SSH into the CI runner to try to repro there, but it will be useful to find recurring patterns first

seems to have solved itself.

I'll take a look though for more occurences.


Add spring boot demo application version 2.7.18

https://start.spring.io/ by default supports spring boot version 3.x. 3.x is not compatible with Java 8, so we downgraded the generated  app to 2.7.18 which is compatible. https://www.marcobehler.com/guides/spring-and-spring-boot-versions
We changed the toolchain for inngest-core to Java 8 so that Java 8 apps can consume it. This meant we couldn't use Java httpclient which was introduced in Java 11.
We evaluated a couple of Http clients and went with OkHttp because its API resembles the Java 11 Http client the most (Other clients were Google Http client and Apache Http client)
The current state is that the app syncs correctly to the dev server but when a function is called it fails on steps execution because of two issues that we'll be looking into next:

  Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Handler dispatch failed; nested exception is java.lang.NoClassDefFoundError: kotlin/enums/EnumEntriesKt] with root cause

java.lang.ClassNotFoundException: kotlin.enums.EnumEntriesKt
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[na:na]
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[na:na]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) ~[na:na]
	at com.inngest.OpCode.<clinit>(Function.kt:26) ~[main/:na]
	at com.inngest.InngestFunction.call(Function.kt:124) ~[main/:na]
	at com.inngest.CommHandler.callFunction(Comm.kt:85) ~[main/:na]
	at com.inngest.springbootdemo.InngestController.handleRequest(InngestController.java:40) ~[main/:na]
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[na:na]
	at java.base/java.lang.reflect.Method.invoke(Method.java:578) ~[na:na]
	at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)

The second issue is that reified inline functions cannot be called from Java and step.run currently is.
https://github.com/inngest/inngest-kt/blob/e9a6a15498d742a775a8a5bbd107cada10d9bb31/inngest-core/src/main/kotlin/com/inngest/Step.kt#L28

looks good. could you add the command you use to run spring boot server before you merge?

we need to figure out this out still 😅 , for now we were just running via IntelliJ


Can I serve an Offline page?

I currently have
toolbox.precache([
    '/Offline',
    '/Offline/Json'
]);

toolbox.router.get('/(.*)', toolbox.networkFirst);

How easy is it for me to serve the offline page if the requested HTML is not in the cache already?

Untested, but the following should give you about what you're looking for:
toolbox.router.get('/(.*)', function(request, values, options) {
  // networkFirst will attempt to return a response from the network,
  // then attempt to return a response from the cache.
  return toolbox.networkFirst(request, values, options).catch(function(error) {
    // If both the network and the cache fail, then `.catch()` will be triggered,
    // and we get a chance to respond with our cached fallback page.
    // This would ideally check event.request.mode === 'navigate', but that isn't supported in
    // Chrome as of M48. See https://fetch.spec.whatwg.org/#concept-request-mode
    if (request.method === 'GET' && request.headers.get('accept').includes('text/html')) {
      return toolbox.cacheOnly(new Request('/Offline'), values, options);
    }
    throw error;
  });
});

(Adapted from the vanilla service worker version that doesn't use sw-toolbox.)

Hi @jeffposnick thanks for the quick response the other day. I have implemented the above but it doesn't seem to be getting to the catch callback
I am getting this error for an uncached page
The FetchEvent for "https://<my-url>" resulted in a network error response: an object that was not a Response was passed to respondWith().

@jeffposnick could really do with some help on this as still new sw - could the issue be reopened until fixed?
Could this be an issue with toolbox.networkFirst returning something even though we have a catch event? Do we need to clone the original request first maybe

Sorry, networkFirst wasn't rejecting when it should have, meaning that the .catch() wasn't triggering.
https://github.com/GoogleChrome/sw-toolbox/pull/84 should fix it.

@jeffposnick Your code above works great, thank you very much. May I ask you one question how can I add this to your code please:
networkTimeoutSeconds: 3


Tour + multires with basePath breaks image location

When using Tour with multires images with the following config doesn't load the images from the expected location:
{
    "default": {
        "firstScene": "first",
        "author": "Emil Hemdal",
        "sceneFadeDuration": 500
    },

    "scenes": {
        "first": {
            "type": "multires",
            "compass": true,
            "northOffset": 0,
            "hotSpots": [
                {
                    "pitch": -5,
                    "yaw": 41,
                    "text": "test test!!",
                    "type": "info"
                },
                {
                    "pitch": -20,
                    "yaw": 11,
                    "text": "test test!",
                    "type": "info"
                },
                {
                    "pitch": -6,
                    "yaw": 14,
                    "text": "test!",
                    "type": "info"
                }
            ],

            "multiRes": {
                "basePath": "/view1",
                "path": "/%l/%s%y_%x",
                "fallbackPath": "/fallback/%s",
                "extension": "png",
                "tileResolution": 512,
                "maxLevel": 3,
                "cubeResolution": 1296
            }
        },
        "second": {
            "type": "multires",
            "compass": true,
            "northOffset": 0,
            "hotSpots": [
                {
                    "pitch": -5,
                    "yaw": 41,
                    "text": "test",
                    "type": "info"
                },
                {
                    "pitch": -20,
                    "yaw": 11,
                    "text": "test",
                    "type": "info"
                },
                {
                    "pitch": -6,
                    "yaw": 14,
                    "text": "test",
                    "type": "info"
                }
            ],

            "multiRes": {
                "basePath": "/view2",
                "path": "/%l/%s%y_%x",
                "fallbackPath": "/fallback/%s",
                "extension": "png",
                "tileResolution": 512,
                "maxLevel": 3,
                "cubeResolution": 1296
            }
        }
    }
}

The browser is trying to load the images from http://view1/1/r0_0.png
This is the HTML loading the json file:
<!DOCTYPE html>
<html>
<head>
    <title>Panorama</title>
    <style type="text/css">
        html, body {
            width: 100%;
            height: 100%;
            padding: 0;
            margin: 0;
            border: 0;
        }
    </style>
</head>
<body>
<iframe width="1000" height="720" allowfullscreen style="border-style:none;"
src="/src/standalone/pannellum.htm?config=/tour.json"></iframe>
</body>
</html>

Screenshot:

Add "basePath": "" to the root of your JSON configuration, e.g. right after the opening {, or remove the leading / from your multiRes basePath.
If there's no overall basePath set, the standalone viewer sets it to be the location of the JSON file, in this case /. This base path is then concatenated with the multiRes base path, which also starts with a /, resulting in a protocol relative URL, e.g. //view1/1/r0_0.png.

Ah, I see! It works as expected now. This could be worthwhile to add to the documentation.


Be nice if you could support subdomains

E.g. foobar.example.com
It seems like you only support TLDs

@kaihendry yes, I agree it would be nice. It's unlikely we'll directly work on this since it's not a use-case for us, but I would welcome a PR adding support for it :)

Closing for now, but if anyone feels like to pick this up, I'll gladly review the work.


add ufm rust client

UFM rust client includes a CLI and library written in rust. Currently, it supports part of UFM operations. We will add new features on demand.

Can one of the admins verify this patch?

@kedeme @lennybe @haithamwj any comment on this PR?

What about CI? at least build step, static code analysis.
you can see example in https://github.com/Mellanox/ufm_sdk_3.0/tree/main/.ci
this folder can be copied into your plugin folder with some adaptations.
@mohfh  FYI


#745 Need proxyUrlPrefixToRemove for proxy context url mapping

Fix for #745. The original request mentions using a transformation parameter, but this PR follows a similar pattern as the additionalProxyRequestHeaders option in the response definition.

@tomakehurst Raised: https://github.com/wiremock/wiremock/pull/1696


Component CSS only defined when using extend

new Ractive({
  el: 'body',
  append: true,
  template: `

Red Hello World

  `,
  css: `
    div{
        color: red
    }
  `
});

let BlueComponent = Ractive.extend({
  el: 'body',
  append: true,
  template: `

Blue Hello World

  `,
  css: `
    div{
        color: blue
    }
  `
});

new BlueComponent();

Came across this while doing toCSS work. In the above, the first component is instantiated directly from Ractive and should show up red. The other one is instantiated with a component definition and should show up as blue. However, only the blue one gains color.
Is this intended behavior? Does the css property only apply to extending and not directly creating instances?

Is this intended behavior? Does the css property only apply to extending and not directly creating instances?

Currently that would be the case.

Hmm... might be nice to document which options work where. To the docs!

Until there's a demand, I think we should just limit to extend and include in the docs.
Right now you can do a one-liner and add to a component to get root:
const MyRactive = Ractive.extend( { css: 'li { color: blue; }' } );

We probably should give a warning if css is included as an option to tell people what to do instead.

There should now be a warning when css is used on an instance configuration https://github.com/ractivejs/ractive/pull/2362. Docs pending at https://github.com/ractivejs/docs.ractivejs.org/issues/246

Just stumbled upon this. Do we know why css prop doesn't work on instances? Would be useful to have.

Ahh, I can explain this (just haven't got to it like... forever 😄 ). Long story short, the CSS is currently just generated on a per-component level.One chunk of CSS for all instances of the component, per-component ID, etc.
There's actually no reason we could go per-instance. There's just no one looking for the feature. Per-component CSS is sufficient in most cases since normally, you don't generate hundreds of unique instances with unique CSS, just a hundred instances of a few dozen components.

Not sure if there are implications with per-instance css. One can do a workaround by extending before instantiating:
import css from 'view.css';
let Comp= Ractive.extend({css: css});
let comp = new Comp();

I guess it's just surprising it doesn't work per instance, like 'template'.

Can we reopen this issue if css should be supported per instance?

I think a separate issue would be better. This one is more like verification of the existing functionality.


Project organization

There are several ways to organize a project, therefore, we should define it and document it.

Decidimos utilizar el project de Github para manejar el proyecto.


Format string for blame_line timestamps

Is your feature request related to a problem? Please describe.
I'd like the timestamp in the blame_line popup to use 12 hour (AM/PM) time instead of 24 hour time. This could be solved by allowing me to set a custom time format string.
Describe the solution you'd like
Add a config option to specify the timestamp format string.
Describe alternatives you've considered
Forking the project, I guess? I don't think there's any way to do this without code changes.
 I'd like to be able to see the time in 12 hour (AM/PM) time.

Duplicate of #291


ref #16: fix english name of image crop preset after field was made m…

…ultilingual

Q
A

Branch
master

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed issues
#16

License
MIT

https://github.com/chameleon-system/chameleon-base/pull/263 needs to be merged before this.

Thanks @fabianbarth-esono


Class 'Done' is not defined

I tried your example code but it says Done class is not defined.
MaterialApp(
      home: SplashView(
        backgroundColor: Colors.red,
        loadingIndicator: RefreshProgressIndicator(),
        logo: FlutterLogo(),
        done: Done(Home()), // error
      ),
    ),

The function 'Done' isn't defined.
Try importing the library that defines 'Done', correcting the name to the name of an existing function, or defining a function named 'Done'.

Thank you for reporting. The problem has been fixed.


factory images don't include boot/radio and other image types

Google Factory images contain:

abl.img
aop.img
boot.img
bootloader-crosshatch-b1c1-0.1-4948814.img
cmnlib64.img
cmnlib.img
devcfg.img
dtbo.img
hyp.img
keymaster.img
modem.img
product.img
qupfw.img
radio-crosshatch-g845-00023-180815-b-4956438.img
system.img
system_other.img
tz.img
vbmeta.img
vendor.img
xbl_config.img
xbl.img

Many of these are currently unidentified. Some of them that are generated by the build system are not copied to factory images by device/common/generate-factory-images-common.sh
In particular boot.img and radio.img are currently not in paths the script detects and don't make it into the build.

@thestinger feel free to point me in the right direction here.

I contributed to making android-prepare-vendor work well, mostly with ideas and bug reports, and I'd highly recommend using that. Trying to use Google's incomplete / broken driver releases won't work well. It's better to use android-prepare-vendor to extract from the official factory images.

android-prepare-vendor is now working as expected.


Closing video player without pausing causes power saving mode to remain disabled

cc @ungoldman

Hmm so we should make sure to stop powerSaverBlocker when the window closes, right?

No, closing the window is already causing a pause.
I meant closing the video player and returning to the torrent list view.

Oh really? I thought I was seeing the video-paused event fire in a console.log when I was testing earlier. Will take a look.

Okay I can repro, sorry I missed that one. I guess another ipcRenderer.send from closePlayer() in index.js would do the trick though it doesn't feel super clean.

I think it would make sense to store video playback position when leaving the player in the future so it makes sense to group some actions around that event. For now that's attached to the back event so I'll just add something in that context.

I think we should try to keep the main process unaware of the player state.
If the renderer wants to disable power saving mode, it should just send an
event that does that. That's how most of the events except for the play and
pause ones already work.
On Fri, 11 Mar 2016 at 17:16 Nate Goldman<EMAIL_ADDRESS>wrote:

I think it would make sense to store video playback position when leaving
the player in the future so it makes sense to group some actions around
that event. For now that's attached to the back event so I'll just add
something in that context.
—
Reply to this email directly or view it on GitHub
https://github.com/feross/webtorrent-app/issues/141#issuecomment-195623146
.

#142 should fix this issue, also moves powerSaveBlocker logic into renderer.


Replace deprecated usages of 'dispatchNow'

@driesvints as requested

Thanks!

I just realized, unlike dispatchNow we can not mention the onQueue in 'dispatchSync'. this is mandatory in my case to pass dynamic queue name. so dispatchNow is an essential function for me. Please update dispatchSync to accept queue name.

@amitshah-sgcm this is the wrong repo for that – please raise an issue with laravel/framework