Thread pool is EXHAUSTED

Environment

Dubbo version: 2.5.3
Operating System version: centos6.8
Java version: 7u79

Thread pool is EXHAUSTED! Thread Name: DubboServerHandler-x.x.x.x:20359, Pool Size: 200 (active: 198, core: 200, max: 200, largest: 200), Task: 48143503 (completed: 48143306), Executor status:(isShutdown:false, isTerminated:false, isTerminating:false), in dubbo://<IP_ADDRESS>:20359!, dubbo version: 2.5.3, current host: x.x.x.x

i dump the thread stack，and find there are 170 thread like this:
DubboServerHandler-x.x.x.x:49076-thread-178
priority:10 - threadId:0x00007f1b8c054000 - nativeId:0x57e9 - nativeId (decimal):22505 - state:WAITING
stackTrace:
java.lang.Thread.State: WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0x0000000702e46e88> (a java.util.concurrent.SynchronousQueue$TransferStack)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill(SynchronousQueue.java:458)
at java.util.concurrent.SynchronousQueue$TransferStack.transfer(SynchronousQueue.java:359)
at java.util.concurrent.SynchronousQueue.take(SynchronousQueue.java:925)
at java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1068)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Locked ownable synchronizers:
- None

what is the most cause of  these 170 WAITING thread ?
attachment：the thread stack info : https://fastthread.io/same-state-threads.jsp?state=threadGroup&threadGroup=2&dumpId=1

This problem means that the server is already very busy.
Perhaps you should check why the code is executing slowly ？
refer:
https://www.cnblogs.com/brant/p/11434864.html
https://www.cnblogs.com/tiancai/p/9252780.html


sparql query with invalid value on begin or end parameter is not throwing any error

This sparql query with invalid value on begin or end parameter is not throwing any error. There is no error thrown on server log
...
var myQuery = "PREFIX foaf: http://xmlns.com/foaf/0.1/" +
"PREFIX ppl:  http://people.org/" +
"SELECT *" +
"WHERE { ?s foaf:knows ppl:person3 }"
db.graphs.sparql({
contentType: 'application/sparql-results+json',
query: myQuery,
begin: -1,
end: 10
}).
result(function(response){
...
The graph file is under /test-complete/data/people.ttl

Thanks for catching that.

Verified that -ve values on begin or end throws error


Create cifpaviles.txt

Official website:
https://www.cifpaviles.net
URL of a page on the official website where a long-term (>1 year) IT related course is offered:
https://www.cifpaviles.net/ciclo-formativo-de-grado-superior/informatica-y-comunicaciones-gs/
URL of a page showing that the university recognizes the domain which you are submitting as an official email domain:
https://www.cifpaviles.net/contacto/

@fpdistancia I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host cifpaviles.org not found: 2(SERVFAIL) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!


OpenET API availability and access

The OpenET newsroom has been quiet for over a year, with the exception of one blog post. The official website still says:

OpenET plans to launch an Application Programming Interface (API) in early 2022.

When will the API launch, and is it still possible to gain beta access?
Thanks!

I would suggest using the "Contact Us" link found on that same site to get more information about API access.


clarify difference between gas used and gas charged

Is your feature request related to a problem? Please describe.
unclear what the difference is.
Describe the solution you'd like
used is the true cost. charged is the gas paid - gas refund. due to subsidies gas used can be higher than gas charged for some chains. we should probably add a tooltip, and move the used value in a details section
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

added the tooltip: https://axelarscan-ui-rebuild.vercel.app/gmp/0x923df320c255d17676f837debc0415791104edc155f1b244b7f1b21e119ec883-18


[AutoPR] resources/resource-manager

Created to accumulate context: resources/resource-manager

(message created by the CI based on PR content)
Installation instruction
Package azure-mgmt-resource
You can install the package azure-mgmt-resource of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_resources/resource-manager#egg=azure-mgmt-resource&subdirectory=azure-mgmt-resource"
You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_resources/resource-manager#egg=azure-mgmt-resource&subdirectory=azure-mgmt-resource"
If you have a local clone of this repository, you can also do:

git checkout restapi_auto_resources/resource-manager
pip install -e ./azure-mgmt-resource

Or build a wheel file to distribute for testing:

git checkout restapi_auto_resources/resource-manager
pip wheel --no-deps ./azure-mgmt-resource

Direct download
Your files can be directly downloaded here:

azure-mgmt-resource-6.0.0.zip
azure_mgmt_resource-6.0.0-py2.py3-none-any.whl


step plots with plotly

[x] Closes #415 .
[x] I am familiar with the contributing guidelines.
[x] Tests added.
[ ] Updates entries to docs/source/api.rst for API changes.
[ ] Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

event:

3 months with and without markers


pulsar released package missing configuraion for ranges from bookkie

Describe the bug
Standalone pulsar's bookie creates data/ranges folder even bookkeeper's data path is changed to another folder. This data/ranges folder is used by data.bookkeeper.ranges, which can be configured in the bookkeeper package downloaded from apache bookkeeper but not pulsar.
To Reproduce
Steps to reproduce the behavior:

Go to the conf folder and change all data paths of the bookie. Don't use any path containing data/
Execute standalone with --bookkeeper-dir pointing to other locations outside PULSAR_HOME for some time.

Expected behavior
No data/ranges should exist because bookkeeper's data folder is changed to another location, but I can still see it.

@hanbo1990 yeah, this should be simple fix. do you want to try to make a contribution to this?

Sure, I will do it.


Change delimiters

Is there any way to change express-hbs delimiter?
What I pretend is change default delimiter {{ something }} to [[ something ]]. I need to create an app which needs to "pre-render" templates in server-sidle and then send these templates to AngularJS front-end application.
Thank you.

+1

This is (as you have already discovered) a restriction in the way handlebars works and not something that express-hbs can work around.
The handlebars issue you discovered explains that you may be able to build a custom version of handlebars to do this.


WIP: API workshop

Title: Demystifying APIs for Researchers
Date: 2024-01-24
Description

Pre-workshop checklist:

[ ] Create a Zoom meeting with registration
[ ] Write up announcement and record on the Workshops HackMD
[ ] Advertise

[ ] Edit upcoming workshops section of group website workshops page
[ ] Add to Data Science Institute calendar https://datascience.arizona.edu/calendar
[ ] Send out announcement to mailing list
[ ] Twitter

[ ] Provide homework / background reading as appropriate (installation, references, etc.)
[ ] Send out reminders
[ ] Create pre- and post-workshop surveys
[ ] Send out pre-workshop survey [WIP]

Full checklist here: https://osf.io/tzmhp/wiki/Workshops/
Materials
Create a folder in the format YYYYMM-short-title and include:

[ ] Slides (if applicable)
[ ] Notes

Use .md, .Rmd with output: github_document, or .qmd with format: gfm OR render to RStudio Connect or something like that.

Example API: GBIF? KEGG?


results appearing if I set text on textfield

If I programmatically set the text on the text field, I am finding that the filtered list of matching results appear below the text field.
Is there a way to stop the list appearing when text is set programmatically?
ps love the control - and great work.

I don't think there is a way in this project, currently. You might have to hide the tableView your self at the moment.

@deanezra, finally fixed in 1.0.5. If you want to still showing the results when you set the text programmatically, you must set startVisible to true.


Problem in the X button to close windows on the top right of screen

Describe the bug
While using Files app which uses this service, when I move the mouse over to the top left of the screen even when files is maximised, it focuses on resizing the window(which it is unable to do because window is maximised) instead of focusing on the X button as shown in screenshot below.
Steps to reproduce the bug
Maximise files window and move mouse to top right
Expected behavior
Mouse focuses on the X buttom
Screenshots

What is happening

Expected(as in other software)
(See top right)
NuGet package version
None
Windows version
No response
Additional context
No response

Duplicate of #8805


"Update endpoint" does not respect checkboxes. Updates all forwarding endpoints.

I'm using a somewhat older version of Castle Mock.
When i select a few "Resources" with checkboxes and choose the button "Update endpoint" i do see a correct list, but eventually all Endpoints are updated with the new endpoint-value.
I expected that only the selected resources would be updated.
The issue is still in the latest master-branch..
In this code:
    public ServiceResult<UpdateRestResourcesForwardedEndpointOutput> process(final ServiceTask<UpdateRestResourcesForwardedEndpointInput> serviceTask) {
        final UpdateRestResourcesForwardedEndpointInput input = serviceTask.getInput();
        final List<RestResource> resources = this.resourceRepository.findWithApplicationId(input.getRestApplicationId());

This issue is now resolved and will be part of the next release, v1.47
Thank you once again for reporting this issue.
Best regards,
Karl Dahlgren


perlPackages.XMLParser: cross compilation is broken

Describe the bug
perlPackages.XMLParser fails to cross compile on current nixos-unstable (7827d3f4497ed722fedca57fd4d5ca1a65c38256).
Unfortunately this means that one cannot crosscompile a NixOS system right now, as nixos/modules/system/activation/top-level.nix depends on the package.
To Reproduce
Run nix build nixpkgs.pkgsCross.aarch64-multiplatform.perlPackages.XMLParser.
$ nix log /nix/store/ig0bsk29l8rl5qvqy53n2n8gmnwib2m4-perl5.30.0-XML-Parser-2.46-aarch64-unknown-linux-gnu.drv
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/qmfwv8kx7dxihx6x47lcs5qnfq1x6m9w-XML-Parser-2.46.tar.gz
source root is XML-Parser-2.46
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file XML-Parser-2.46/MANIFEST
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
patching ./samples/xmlfilter...
patching ./samples/canonical...
patching ./samples/xmlcomments...
patching ./samples/xmlstats...
patching ./t/external_ent.t...
patching ./t/decl.t...
patching ./t/parament.t...

Expat must be installed prior to building XML::Parser and I can't find
it in the standard library directories. Install 'expat-devel' (or
'libexpat1-dev') package with your OS package manager. See 'README'.

Or you can download expat from:

http://sourceforge.net/projects/expat/

If expat is installed, but in a non-standard directory, then use the
following options to Makefile.PL:

    EXPATLIBPATH=...  To set the directory in which to find libexpat

    EXPATINCPATH=...  To set the directory in which to find expat.h

For example:

    perl Makefile.PL EXPATLIBPATH=/home/me/lib EXPATINCPATH=/home/me/include

Note that if you build against a shareable library in a non-standard location
you may (on some platforms) also have to set your LD_LIBRARY_PATH environment
variable at run time for perl to find the library.

no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
no Makefile, doing nothing
@nix { "action": "setPhase", "phase": "installPhase" }
installing
install flags: SHELL=/nix/store/zavn4np1jvm79f0rafkv0p1mrag09qkz-bash-4.4-p23/bin/bash pkgconfigdir=/nix/store/q3v25rngsdlaa31vxwxajhgylkqsbm2q-perl5.30.0-XML-Parser-2.46-aarch64-unknown-linux-gnu/lib/pkgconfig m4datadir=/nix/store/q3v25r>
make: *** No rule to make target 'install'.  Stop.

Additional context
I guess 076dc17149af60635d52621e3a2a341af046af2e, caused the issue, at least when I revert it, I can crosscompile the package.
Also this looks related to https://github.com/NixOS/nixpkgs/issues/36675.
For anybody in need of a quick and dirty fix: I use this patch to cross compile my system:
diff --git a/pkgs/top-level/perl-packages.nix b/pkgs/top-level/perl-packages.nix
index 61822351ee2..846495ffc0f 100644
--- a/pkgs/top-level/perl-packages.nix
+++ b/pkgs/top-level/perl-packages.nix
@@ -20070,11 +20070,16 @@ let

   XMLParser = buildPerlPackage {
     pname = "XML-Parser";
-    version = "2.46";
-    src = fetchurl {
-      url = mirror://cpan/authors/id/T/TO/TODDR/XML-Parser-2.46.tar.gz;
-      sha256 = "0pai3ik47q7rgnix9644c673fwydz52gqkxr9kxwq765j4j36cfk";
-    };
+    version = if (stdenv.buildPlatform != stdenv.hostPlatform) then "2.44" else "2.46";
+    src = if (stdenv.buildPlatform != stdenv.hostPlatform) then
+      (fetchurl {
+        url = mirror://cpan/authors/id/T/TO/TODDR/XML-Parser-2.44.tar.gz;
+        sha256 = "05ij0g6bfn27iaggxf8nl5rhlwx6f6p6xmdav6rjcly3x5zd1s8s";
+      }) else
+      (fetchurl {
+        url = mirror://cpan/authors/id/T/TO/TODDR/XML-Parser-2.46.tar.gz;
+        sha256 = "0pai3ik47q7rgnix9644c673fwydz52gqkxr9kxwq765j4j36cfk";
+      });
     patchPhase = stdenv.lib.optionalString (stdenv.buildPlatform != stdenv.hostPlatform) ''
       substituteInPlace Expat/Makefile.PL --replace 'use English;' '#'
     '' + stdenv.lib.optionalString stdenv.isCygwin ''

+    version = if (stdenv.buildPlatform != stdenv.hostPlatform) then "2.44" else "2.46";
+    src = if (stdenv.buildPlatform != stdenv.hostPlatform) then

I would put if (stdenv.buildPlatform != stdenv.hostPlatform) then around whole derivation:
XMLParser_2_44 = buildPerlPackage {
...
};
XMLParser_latest = buildPerlPackage {
...
};
XMLParser = if stdenv.buildPlatform != stdenv.hostPlatform then XMLParser_2_44 else XMLParser_latest;

The reason is 2.46 might be updated to 2.47 and further and that update might change buildInputs, patchPhase which would affect 2.44 too if if is only in src= and version=

BTW, HTTP::Daemon is stuck to 6.01 and not updated for the same reason, the newer versions fail to cross-compile.
So, undoing of XMLParser: 2.44 -> 2.46 is good to

XML::Parser is back to 2.44 as part of https://github.com/NixOS/nixpkgs/pull/73954
so, this issue could be closed (for some reason it was not closed automatically, probably because of merging to staging instead of master).

Thanks!

Was this issue actually resolved? There seems to be no link to a PR or anything.

Was this issue actually resolved? There seems to be no link to a PR or anything.

This conversation is missing pieces due to GitHub removing all interactions by former user @volth. Luckily I had mail notifications enabled on that time, so here are the missing pieces:

volth: BTW, HTTP::Daemon is stuck to 6.01 and not updated for the same reason, the newer versions fail to cross-compile.
So, undoing of XMLParser: 2.44 -> 2.46 is good to

volth: XML::Parser is back to 2.44 as part of https://github.com/NixOS/nixpkgs/pull/73954
so, this issue could be closed (for some reason it was not closed automatically, probably because of merging to staging instead of master).

#73954 is itself unavailable due to the same reasons, but it was essentially a Perl packages mass upgrade (and a downgrade for XMLParser apparently).
So yes, this issue once was resolved.

This conversation is missing pieces due to GitHub removing all interactions by former user @volth. Luckily I had mail notifications enabled on that time, so here are the missing pieces:

volth: BTW, HTTP::Daemon is stuck to 6.01 and not updated for the same reason, the newer versions fail to cross-compile.
So, undoing of XMLParser: 2.44 -> 2.46 is good to

volth: XML::Parser is back to 2.44 as part of https://github.com/NixOS/nixpkgs/pull/73954
so, this issue could be closed (for some reason it was not closed automatically, probably because of merging to staging instead of master).

#73954 is itself unavailable due to the same reasons, but it was essentially a Perl packages mass upgrade (and a downgrade for XMLParser apparently).
So yes, this issue once was resolved.


Add ESD Delegation strategy

Changes proposed in this pull request:

Adds ability to delegate ESD votes via the "esd-delegation" strategy

Forgot I submitted this last night 😂


werkzeug.routing.BuildError

When attempting to log in for the first time, after registering and giving Fitbit permissions:
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask/app.py", line 1625, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask_login.py", line 791, in decorated_view
    return current_app.login_manager.unauthorized()
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask_login.py", line 224, in unauthorized
    return redirect(login_url(login_view, request.url))
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask_login.py", line 640, in login_url
    base = url_for(login_view)
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask/helpers.py", line 332, in url_for
    return appctx.app.handle_url_build_error(error, endpoint, values)
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask/app.py", line 1811, in handle_url_build_error
    reraise(exc_type, exc_value, tb)
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/flask/helpers.py", line 322, in url_for
    force_external=external)
  File "/Users/ghilston/.virtualenvs/fitbit/lib/python3.6/site-packages/werkzeug/routing.py", line 1758, in build
    raise BuildError(endpoint, values, method, self)
werkzeug.routing.BuildError: Could not build url for endpoint 'auth.login'. Did you mean 'main.login' instead?

Performing the same operations a second time worked...


Cannot get my loop to work

var bottlesOfBeer = 99
for (bottlesOfBeer <=99; bottlesOfBeer > 0; bottlesOfBeer--) {
if (bottlesOfBeer > 1) {
var bottleRemaining = bottlesOfBeer - 1;
console.log(bottlesOfBeer + " bottle(s) of beer on the wall, " + bottlesOfBeer + "bottle(s) of beer, if one of those bottle(s) should happen to fall, " + bottleRemaining + "bottle(s) of beer on the wall.");
} else if (bottlesOfBeer = 1) {
console.log("One bottle of beer on the wall, one bottle of beer, if this one bottle of beer should happen to fall, there'll be no more bottles of beer on the wall.");
}

Are you sure you're not just missing a final bracket? It worked for me.
var bottlesOfBeer = 99;

for (bottlesOfBeer <=99; bottlesOfBeer > 0; bottlesOfBeer--) {

  if (bottlesOfBeer > 1) {
    var bottleRemaining = bottlesOfBeer - 1;
    console.log(bottlesOfBeer + " bottle(s) of beer on the wall, " + bottlesOfBeer + "bottle(s) of beer, if one of those bottle(s) should happen to fall, " + bottleRemaining + "bottle(s) of beer on the wall.");
  } else if (bottlesOfBeer = 1) {
    console.log("One bottle of beer on the wall, one bottle of beer, if this one bottle of beer should happen to fall, there'll be no more bottles of beer on the wall.");
  }

}

working bin


Updated ReadMe,Removed repeated imports and the related bugs

Updated the ReadMe file for the description of the application, removed some repeated imports and solved some error in home.dart file.

We'll review it shortly..Meanwhile I am creating an issue..Just comment in it so that I can assign it to for grading

We'll review it shortly..Meanwhile I am creating an issue..Just comment in it so that I can assign it to for grading

Okay sir.

I have created the issue...Please claim it

Approved


allow the zone to be passed as a parameter

This allows you to use the same cloud function for multiple DNS zones by passing {zone: example-com,...} in the request body

Thanks for the PR, it's nice to see people using this project :+1:

My pleasure. Thanks for publishing it!


Improve RTL support

Adding text direction markers so dialing codes look correct on RTL - eg: shown as (+1) instead of (1+)
Implementation is based on https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPInternational/SupportingRight-To-LeftLanguages/SupportingRight-To-LeftLanguages.html#//apple_ref/doc/uid/10000171i-CH17-SW11
To test it, change the simulator's language to Arabic and run the Demo app

Hey @kizitonwose any chance you can review this and merge & release please?

Thank you for fixing this.


proposal: amend extended key usage of CPPKI Root and CA certificates

Currently, the specification of the root and ca mandate that in the Extended key usage extension, id-kp-serverAuth and id-kp-clientAuth must not be present.
This leads to a problem when trying to use CPPKI certificates in TLS handshake, as most implementation will only have a valid verification path from leaf to root certificate, if the extended key usages of the leaf are a subset of the extended key usage of the certificates in the chain. In other words, because CA and Root certificates do not have id-kp-serverAuth set, they cannot really be used for standard TLS without additional work arounds.
This is an oversight and makes CPPKI certificates less ergonomic to use than they could be.
My proposal would be to first adjust the implementation to not validate the absence anymore, and once that has found wide adoption in the network, to adjust the specification accordingly. This needs a phased roll out, because simply starting to create Root and CA certificates with id-kp-*Auth set would lead to verification errors on all relying parties that have not been adjusted yet.

IIUC, most of the TLS implementations mandate that the Extended Key Usage fields on the leaf certificate are also present in the Extended Key Usage field for every certificate in the chain?
How does this work with the RFC?

In general, this extension will appear only in end entity certificates

If this is a common practice in most of the TLS implementations, do they provide some justification for this?

I think you are right. Roots do not have these extend key usages, I will need to dig in more.
Current problem that I'm facing is that Go stdlib does not find a valid verification path if we use our CPPKI as a regular WebPKI root certificate


Dev-->Master USWDS blog

Fixes #
Preview

@eelzi-ONRR @Maroyafaied One URL to our old GitHub no longer works since we switched to DOI-ONRR. It needs to be updated to "https://github.com/DOI-ONRR". I checked all the others, and this is the only one giving me a 404.

I'm not sure I've ever updated a blog while it's in dev, I'm happy to make the update!

@cthomasONRR Please go ahead an make the update in dev, it's the same process you just select the dev branch.

Hi all - I reviewed, checked links, and generally I think it looks good except for 2 links in the "Earn Trust" section: (1) GitHub link that Christine pointed it out previously, and (2) CircleCi link that is giving me a 404 error.

@AlexandracmONRR Interesting, that CircleCi link redirected for me, but I'll go and update it anyways.

@AlexandracmONRR link fixed


Cannot install on Ubuntu 18.04: python3-pyside2.qtwidgets (>= 5.12.0) not installable

I'm trying to set up a syncplay server on headless 18.04 Ubuntu.
Running sudo apt install ./syncplay_1.6.5.deb gives me the following output:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'syncplay' instead of './syncplay_1.6.5.deb'
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 syncplay : Depends: python3-pyside2.qtwidgets (>= 5.12.0) but it is not installable
E: Unable to correct problems, you have held broken packages.

I'm not sure what I can do about this.

I ought to mention I managed to set up a server using the AppImage with the --server option.

This is expected. Pyside2 package which is required is not available in Ubuntu 18.04. Oldest Ubuntu version which includes Pyside2 and is compatible with Syncplay deb package is 19.10.
Appimage works because it bundles Pyside2 (and other things) within its binary.

fair enough. maybe this is a stupid question, but would it be possible to distribute the server binaries separately in releases?

This is expected. Pyside2 package which is required is not available in Ubuntu 18.04. Oldest Ubuntu version which includes Pyside2 and is compatible with Syncplay deb package is 19.10.
Appimage works because it bundles Pyside2 (and other things) within its binary.

Source install also works assuming it requires Qtwidgets >=5.11.0 and no issues so far. Is it safe to match the requirements found in the deb file with the source requirements?

@kathelynn I think Ubuntu 18.04 doesn't have any qtwidgets version in repositories. At least nothing can be found in official search. Development build of deb package on bintray has also switched the qtwidgets dependency to include no version information as all versions should work with exception of 5.15 development version where pyside has a bug mentioned in #321.
For server installation technically pyside2 isn't required because there isn't any GUI anyway. I was thinking of creating a separate package with server components only, but I didn't know if there is any demand for it. I'm leaving this issue open for the time when I get around to setting up automation for building server package.

After some deliberation I decided that creating a separate deb package specifically for this purpose is not worthwhile given that there exist many alternatives.
If somebody else is willing to create such package integrated with our Travis builds, I'd be happy to merge the PR.

https://github.com/Syncplay/syncplay/issues/335#issuecomment-660227578

fair enough. maybe this is a stupid question, but would it be possible to distribute the server binaries separately in releases?

Is this worth opening a new issue for?

Well, strictly speaking Syncplay doesn't need a binary distribution in first place - it's Python code that can be run as is.
With regards to server-only: technically indeed server needs a small subset of files from entire repository, but nobody so far has bothered to list them accurately. Entire codebase with all the icons is under 3 megabytes anyway. Full binary releases (Windows exe, Appimage and OSX dmg) include all dependencies inside (like entire Python3 environment) which is why they are comparably much larger. Deb doesn't include all the dependencies inside, but is set to require them upon installation. This is due to assumption that you will want to use the client with gui.
For server use I find it by far the simplest to just git clone the repository and run sudo make install-server. Though this still includes everything in repository with exception of client wrapper. You need to manually ensure that python requirements for server are met (python3 and python3-twisted, optionally TLS stuff).
With regards to opening new issue - I don't think there is that much use in separate binary distribution with server only. Based on assumption that whoever is running the server either is running it on their personal PC (where they also want the client anyway) or if they run it on their private server elsewhere, they can easily figure out whatever installation method they prefer. Because of that I don't think any of core developers feels pressure to implement it.
Because of all of the above I don't think opening a separate issue will be of much use. That said if you want to make a Pull Request which would integrate making a server-only package into our current Travis build system we could discuss it further :)


check that the packet is large enough for the header encryption sample

Fixes #1701.

Codecov Report

Merging #1702 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1702      +/-   ##
==========================================
+ Coverage   87.36%   87.37%   +<.01%
==========================================
  Files          96       96
  Lines        6298     6300       +2
==========================================
+ Hits         5502     5504       +2
  Misses        565      565
  Partials      231      231

Impacted Files
Coverage Δ

packet_unpacker.go
91.04% <100%> (+0.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2eb76...ba45256. Read the comment docs.


Post slider added

Added a reusable component for images carousel which can be used in future too.
Multiple images post are rendered in carousel
https://user-images.githubusercontent.com/91470808/207350429-a64ba5bf-e0b9-493d-b69c-3ae842a5c044.mp4
The first time it glitched due to images are not loaded once the images are loaded it works smoothly.
Addresed issue #58

In case of a Single Image/Status, you don't need to show a carousal/image slider

Done!


Workflow Creation - V0 Allowed or is it a dry run

Create a workflow (i.e. metadata/workflow POST) with workflow version as 0 ? Apparently a 204 response, which is a successful workflow creation response, is recieved but the workflow isn't persisted. A GET workflow request is performed, the version 0 workflow doesn't appear in the list.
It's there any specific reason for this behaviour?

Workflow with version 0 is supported.

but the workflow isn't persisted.

Can you provide more details about your setup? What persistence layer are you using? Can you also provide your workflow definition?

Hi Anoop
I have tried in memory, embedded MariaDB4j, external MySQL persistence and with all of these, the result is the same.
I will soon try to replicate the issue and provide the workflow json request.


chanfunding: extend PSBT witness input check

Fixes #5287.
The PSBT spec is a bit vague when it comes to the WitnessUtxo field of
an input as it's not strictly required for witness inputs. Therefore
Electrum for example does not include the field.
We need to make the SegWit input check a bit more elaborate by looking
at the output script of the UTXO and also the redeem script in case it's
a nested SegWit spend.

Thanks for doing this, will review


ERROR Database load_schema failed

I use command sudo /opt/traffic_ops/install/bin/postinstall to install traffic_ops but the following error
"Wed Jan 23 13:19:43 2019: INFO Setting up the database data
Wed Jan 23 13:19:43 2019: ERROR Database load_schema failed
"
I can't find any logs so I don't know where to handle them

up

Hi @huyvt5
You never answered my question so I wasn't sure how to proceed:

Were you able to successfully run postinstall after you verified that your database has been created?

Are you still running into the same issue?

closing as this should work fine in more recent versions of TC.


Improve speed of RNA-seq CI (resolves #254)

Improve speed of RNA-seq CI (resolves #254)

@hannes-ucsc — Rebased onto master

Commit title lacks issue reference.
I also think that the PR title is better. You could just use that for the commit title.

@hannes-ucsc Fixed commit message.

Conflicts.

@hannes-ucsc it has the needs work label ;)

@hannes-ucsc — Ready

AFAICT, commits cb4d3b1 and d2fced4 are redundant and should be removed.

jenkins, test this please

AFAICT, commits cb4d3b1 and d2fced4 are redundant and should be removed.

Ya, there was an issue with rebase and it refused to squash those 2 commits. I reset to master and reapplied the commit.


Fix rules rendering to handle case where rule is a tuple

Fixes #1929

Pull Request Test Coverage Report for Build 0bbe1726a104c801a8d15c74ae582e6eec67ffb3-PR-1947

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 70.654%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

apps/fz_wall/lib/fz_wall/cli/helpers/nft.ex
0
1
0.0%

Totals

Change from base Build 5c92e325c46ff90b236932691e9cee281d8555bc:
-0.03%

Covered Lines:
1967

Relevant Lines:
2784

💛  - Coveralls


new relase?

hi,
When will the new version relase?
Will it support new  intel cards?

I am currently packed with lots of other stuff. I could think of a new release somewhere around August. I got a lot of changes coming. Some of them are already working, others need fixing/testing.
Support for new cards is very hard. I do not know about any worthy (high power, good drivers) Intel cards. So no. No support for new Intel cards.


restructured crossbuild containerfile hides segfault

#4 restructured the containerfile and moved the gcc sanity check before the import of native binaries. Therefore, the sanity check became ineffective as it now only checks the non native optimised versions.
In fact this change has already hidden a bug causing gcc to segfault when building amd64 targets on an aarch64 host. (the bug is likely caused by some updates to gcc resulting in a binary layout that patchelf does not handle correctly when replacing needed libs)
we should:

fix the containerfile to perform gcc sanity checks after importing native accelerated executables
investigate and fix the segfault in the patched gcc

Here is a small PR that fix the container file to perform gcc sanity checks after importing native accelerated executables:
https://github.com/gardenlinux/package-build/pull/52
Do you have more info on the segfault in the patched gcc?

Request technical sponsor from @waldiTM  :)


Console Elements flickering on interaction

Hi,
Using the Dotnet Console (and Powershell) while navigating with the mouse and selecting checkboxes or focusing textfields,
the rest of the Gui disappares.
I have no idea whats causing the issue or what im doing wrong.
my Application.Top has a TopLevel and a Menu.
The TopLevel has a TabView and a Label
The TabView (every tab) has a Frame
All the Elements (Textfields, labels, checkboxes) are inside this Frames.
Tried removing all the logic leaving only graphics but it still does it.

[...] while navigating with the mouse and selecting checkboxes or focusing textfields,
the rest of the Gui disappares.

Is it only mouse navigation that causes this issue? Or does keyboard navigation also have issues?

Ok so if I change the code to this:
Application.Init ();

			var win = new Window () { Width = Dim.Fill (), Height = Dim.Fill() };

			var tabView = new TabView () { Width = Dim.Fill (), Height = Dim.Fill () };
			var frame1 = new FrameView ("Frame1") { Width = Dim.Fill (), Height = Dim.Fill () };
			var frame2 = new FrameView ("Frame2") { Width = Dim.Fill (), Height = Dim.Fill () };

			frame1.Add (new Label { Text = "Hi", Y = 0 });
			frame1.Add (new CheckBox ("Option1") { Y = 1 });
			frame1.Add (new CheckBox ("Option2") { Y = 2 });

			tabView.AddTab (new TabView.Tab ("Tab1", frame1), false);
			tabView.AddTab (new TabView.Tab ("Tab2", frame2), false);
			win.Add (tabView);

			Application.Top.Add (win);
			Application.Run ();
			Application.Shutdown ();

Then the problem disapears.

Yes, you right. But if you add the follow code to the end of the FrameView Redraw you will see that works with your original code:
// Checks if there are any SuperView view which intersect with this window.
if (SuperView != null) {
	SuperView.SetNeedsLayout ();
	SuperView.SetNeedsDisplay ();
}

If you want, feel free to submit a PR for this.

That sounds like a simple fix.  Can you create the PR? I'm not sure I understand how/why the fix works so wouldn't feel comfortable creating it.

@tznind, I thought better but the TabView.Tab has any call to the SetNeedsDisplay to SuperView anytime a subview was changes?

So TabView has 2 private field Views.  The first is a TabRowView (called tabsBar) and the second is a regular View (called contentView).  Neither of these views are child views of the main TabView control (i.e. they are not added using Add(tabsBar)) But are instead drawn manually as part of the TabView Redraw implementation:
https://github.com/migueldeicaza/gui.cs/blob/8f66fc07c79c2841a4a9397eaa22796e3719173d/Terminal.Gui/Views/TabView.cs#L165-L184
Maybe this causes problems since from the point of view of the checkbox they aren't going to appear as part of the view hierarchy?
I will have an investigate to confirm this and see if there is a better solution than the current implementation or a workaround.

@tznind, I think is better you do the changes because it concerns to fixing the Redraw method in the TabView.
if (Tabs.Any ()) {
	tabsBar.Redraw (tabsBar.Bounds);
	contentView.SetNeedsDisplay ();
	contentView.Redraw (contentView.Bounds);
}

Ignore my deleted post there, I am talking rubbish.  The subviews of TabView are indeed part of the normal hierarchy and are added in the constructor

Thanks for the help finding that fix, I don't think I would have ever found that myself.
@Paffo there is a PR in to fix this.  In the meantime it might be that you can do a workaround based on one of my above examples?

Fixed in #1345

Fixed in #1345

@tig please correct the fix for this issue. It's hte PR #1354. Thanks.


PLAT-102254: Migrate ui/Cancelable to use hooks

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[x] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Migrate ui/Cancelable to use hooks.
Resolution

Add Cancel for cancelable behavior.
Add useCancel hook to manage the life cycle of the cancelable behavior.
Adopt ui/Cancelable to use useCancel.
Wrap Cancelable functional component with React.forwardRef()
Replace shallow with mount in the unit test.
Add useCancel-specs.js.

Additional Considerations
1> If there is the props, but no context member variable in the Cancel  class, the hasPropsAndContext return false in https://github.com/enactjs/enact/blob/master/packages/core/handle/handle.js#L201 while executing the handleCancel (https://github.com/enactjs/enact/pull/2747/files#diff-7a9525ffab5b0d95304bb442d0aef0a8R27). So this.context = {} was defined in the Cancel constructor. Is there any efficient way without the context? Or it would be just fine.
2> Could you let me know any history why the shallow and the prop were replaced with the mount and the invoke in https://github.com/enactjs/enact/pull/2739/files#diff-eed78280e9a44563cf719509de3fa7e9R119? I also replaced the shallow with the mount in my PR.
3> Cancelable's onCancel configuration could be a function or a string. But use Cancel accepts it as a configuration with onCancelWithStopPropagation property name to distinguish between the props's onCancel and the config's onCancel.
Links
PLAT-102254
Comments

I reverted to pass ref with React.forwardRef.

Responding to the questions in the description:

1> If there is the props, but no context member variable in the Cancel class, the hasPropsAndContext return false in https://github.com/enactjs/enact/blob/master/packages/core/handle/handle.js#L201 while executing the handleCancel (https://github.com/enactjs/enact/pull/2747/files#diff-7a9525ffab5b0d95304bb442d0aef0a8R27). So this.context = {} was defined in the Cancel constructor. Is there any efficient way without the context? Or it would be just fine.

Assigning this.context is the correct approach right now.

2> Could you let me know any history why the shallow and the prop were replaced with the mount and the invoke in https://github.com/enactjs/enact/pull/2739/files#diff-eed78280e9a44563cf719509de3fa7e9R119? I also replaced the shallow with the mount in my PR.

I can't recall off hand. In general, prefer shallow over mount but sometimes mount is required.

3> Cancelable's onCancel configuration could be a function or a string. But use Cancel accepts it as a configuration with onCancelWithStopPropagation property name to distinguish between the props's onCancel and the config's onCancel.

I'm not sure yet how this should be handled. I'm reviewing the PR in more detail now and will update this after that.

Hello @ryanjduffy

3> Cancelable's onCancel configuration could be a function or a string. But use Cancel accepts it as a configuration with onCancelWithStopPropagation property name to distinguish between the props's onCancel and the config's onCancel.

Today I added one more commit to simplify Cancel class by moving forward('onCancel') out of it (https://github.com/enactjs/enact/pull/2747/commits/4de8e13ad3b25d0f4da0d688752da2edfae02dfd).
By doing it,

forward('onCancel') could be called not in useCancel but in Cancelable as we did in Toggleable.
Logically the Cancel class is much simpler.
The useCancel accepted the onCancel for props.onCancel and the onCancelWithStopPropagation for the Cancelable HOC's config before. I thought it could be confusable for users to distinguish them. But for now, the onCancel for the Cancelable HOC's config is only used in the useCancel.


Updating sshj master branch

Problem
delphix/sshj is currently working with 0.34.0 version, and needs to be updated to 0.35.0.
Updating the master branch with hierynomus/sshj master branch

Solution
Creating a PR from the fork

Codecov Report

Merging #5 (830a39d) into master (6e7fb96) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
- Coverage     64.87%   64.78%   -0.09%
+ Complexity     1467     1465       -2
============================================
  Files           210      210
  Lines          8537     8537
  Branches        781      781
============================================
- Hits           5538     5531       -7
- Misses         2589     2596       +7
  Partials        410      410

Impacted Files
Coverage Δ

src/main/java/net/schmizz/concurrent/Promise.java
80.30% <0.00%> (ø)

...java/net/schmizz/sshj/transport/TransportImpl.java
64.87% <0.00%> (-2.07%)
:arrow_down:

...va/net/schmizz/sshj/connection/ConnectionImpl.java
59.34% <0.00%> (-0.82%)
:arrow_down:

src/main/java/net/schmizz/sshj/SSHClient.java
58.52% <0.00%> (-0.57%)
:arrow_down:

...ain/java/net/schmizz/sshj/common/SSHException.java
67.74% <0.00%> (ø)

...net/schmizz/sshj/transport/TransportException.java
44.44% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Clicked on sync fork option, this MR was merged and closed.


In Other News not populating

Plan limit exceeded, need to pay for premium

Paid for premium account because we had maxed out on server calls. Now coming in correctly.


Extensions from OSHPark eagle cam files added.

Learned real fast that the filenames from the OSHpark cam files, resulted in top copper not being found.  The filenames follow this scheme.
Top Solder Paste	.tcream.ger
Top Copper Layer	.toplayer.ger
Bottom Copper Layer	.bottomlayer.ger
Top Silkscreen 		.topsilkscreen.ger
Bottom Silk screen	.bottomsilkscreen.ger
Top Solder Mask		.topsoldermask.ger
Bottom Solder Mask	.bottomsoldermask.ger
Board Outline		.boardoutline.ger
Inner Layer 1		.internalplane1.ger
Inner Layer 2		.internalplane2.ger
Excellion Drill		.drills.xln
OSHPark oddly enough does not have Bottom Solder Paste layer in its eagle cam files, but if they were to, they would probably name it .bcream.ger

Thanks very much for taking the time to contribute this! I'll merge it.


go/token: typos in interval notation in panic messages

CL 262017 improved the panic messages produced by go/token on out of bounds position queries. However, it looks like there's a typo in the bounds notation, for example: panic: invalid Pos value 98 (should be in [1, 75[).  The interval should be [1, 75].  This typo occurs in two locations.
Filing as an issue as this is trivial and it would be nice to fix it for 1.17.  I'll send a CL.
CC @griesemer

This is not a bug, I believe. The notation [a, b[ denotes the half-open interval [a, b).

This is not a bug, I believe. The notation [a, b[ denotes the half-open interval [a, b).

The interval in question is closed.


Is there a way to load the broker properties from a configuration file ?

Is there a way to load the broker properties from a configuration file ?

Depends on the build tool you are using. With Gradle it is possible.


Added missing unit tests

Coverage increased (+2.3%) to 80.908% when pulling 6118cd8e07ab63d2ef7b6e418cabb4dd1e7b939a on alkekkonen:newUnitTests into e7e3cd24d69999a032de1a3ef691ff2c2f561647 on alfa-laboratory:master.

Coverage increased (+2.3%) to 80.908% when pulling 2a10bd6d6b2644a397f51b0424896319cc95a4f0 on alkekkonen:newUnitTests into e7e3cd24d69999a032de1a3ef691ff2c2f561647 on alfa-laboratory:master.

Coverage increased (+2.3%) to 80.908% when pulling dc466b9acabd2323c67e7c468054d317303d0157 on alkekkonen:newUnitTests into e7e3cd24d69999a032de1a3ef691ff2c2f561647 on alfa-laboratory:master.


Decide on increment/decrement operators

++ and -- are tricky. Rust doesn't have them. Should Rhai?

i think += could be overloaded for more types than just numeric.
let x = 1;
x += 1;

but also
let s = "this is a ";
s += "test";

kind of semantics.

Sounds like a great idea!

should this get closed per #40? or wait for more testing and use cases?

The stuff you implemented is awesome, but the main topic here are the ++ and -- operators and whether they should be present at all in Rhai and if yes, how should they behave and where would they be valid. It is a trickly thing in regards to rustic safety
You implemented two of the compound assignment operators, which are tracked in #35

aha! I'm following the distinction now, thanks for clarifying. I will take a look at the rest of #35 and leave this alone for now.


Link to color palette not working

On this page:
https://www.carbondesignsystem.com/guidelines/color/overview#resources
the URL is broken:
https://github.com/carbon-design-system/carbon/raw/master/packages/colors/artifacts/IBM_Colors.zip

this should be resolved once https://github.com/carbon-design-system/carbon-website/pull/2166 goes live


Update chats.ts

Thanks for your contribution 🥰.
The next step is to wait for review and approval to merge it to main repository
The community can help reacting with a thumb up (👍🏻) for approval and rocket (🚀) for who has tested it.
To test this PR you can run the following command below:
# NPM
npm install @shizodevs/shizoweb@shizothetechie/shizoweb#latest_Patch_by_shizo
# YARN v2
yarn add @shizodevs/shizoweb@shizothetechie/shizoweb#latest_Patch_by_shizo

Regards & Loves from
shizoweb 🤭


FAT-1003 Created Karate test for Loans

Purpose
FAT-1003
Create Karate test for Loans: When an loaned item is checked in at a service point that serves its location and no request exists, change the item status to Available (circ-13)
Approach

Reproduced test scenario with UI.
Learned necessary sent requests and then necessary received responses
Based on the request/response created karate test scenario

Learning

learn karate framework from original doc file on the github
looked other scenarios how they are described.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: sherzodn:x: Sherzod NurjonovSherzod Nurjonov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: Save Generator Form State for a Session

This PR makes the generator UI store its state with the sessionStore API so that when re-visiting the form after going to the validator, for example, the entered form values are not lost.
This is rather a WIP since I will probably refactor a bit of the formik state management to make this less ugly.
TODO:

[x] refactor
[x] write e2e tests

Heyho, I finally got some time, added an e2e test and refactored the code a bit.
The form now uses a modified version of useFormik which packs the fields' state manipulation (setting info, warning, etc. messages) and the field value manipulation at one place, the formik object. Also, modifying form array elements (i.e. the redirect URIs and contacts fields) got a bit better in that regard.
Happy for any feedback and improvement suggestions! I hope you have a good christmas time!

Hey Laurin, sorry for the delay here, but it's going to take a while for us to get to this (it's been pushed into our backlog to review), I had been hoping to review this over christmas for you, but I caught covid and was out for 2 solid weeks.


Updated github-git-cheat-sheet.md

Updated definition of git log --follow
Overview
TL;DR

The definition of git log --follow in the github git-cheat-sheet.md was different than the actual meaning. This pull request updates that definition.

closes #759
Questions
<If relevant, write a list of questions that you would like to discuss related to the changes that you have made.>
Next Steps
<If incomplete, create a task list of items that are still being worked on within the Pull Request.>
Review
<If complete, or ready for :eyes:, use @mentions for quick questions, specific feedback, and progress updates.>

Thank you for this clarification, @mainak-debnath!


Replace some of PlatformAbstractions with RuntimeInformation

@pranavkm
Can't replace all references to PlatformServices.Default.Runtime yet see: https://github.com/aspnet/Hosting/blob/98bf64819e6d45b67cf4bf869e89e0ad938dbb2e/src/Microsoft.AspNetCore.Hosting/Startup/StartupExceptionPage.cs#L235

:shipit: if it works locally.


Unicode support

Steps that will reproduce the problem?

Type dl ü

What is the expected result?

Deepl.com should be asked to translate ü or ü

What happens instead?

Deepl.com is asked to translate ü

Possible workaround:

open http://deepl.com

Any additional information:

Should be a tiny code translation in deepl.php

fyi: https://github.com/m9dfukc/deepl-alfred-workflow/pull/13/files/a822dafa92a822a93f6d52027d58f0b1af70f711

Because DeepL API is closed (For more details pls read this issue: #7 ) currently I am not planning to work on this plugin but feel free to contribute and I will be happy to review, merge and publish a new version. ;)

Actually, I‘ve a simplified working version of the plugin: https://github.com/AlexanderWillner/deepl-alfred-workflow2


Add link to kubectl convert

Add link to kubectl convert installation instructions and deprecation notes.
More info here:
https://github.com/kubernetes/website/issues/28724#issuecomment-1511916788

@piradata  Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

/easycla

I think the sign is ok now, but you have send the /easycla before me hahah

Thanks
/label tide/merge-method-squash
/lgtm

/lgtm

If you make the remaining changes, we can merge this. It you know how to rebase against main, doing that is even better.

@sftim done :)

/remove-language zh

hello, there is something i need to do on my side yet?

Hi @piradata
We're short of capacity for people to check changes. If a Kubernetes docs contributor sets their LGTM on this PR, I can approve it.

Preview: https://deploy-preview-40737--kubernetes-io-main-staging.netlify.app/docs/reference/using-api/deprecation-guide/
/approve


fix: change imageryProvider to readonly

Fixes lack of ImageryLayer recreation on imageryProvider prop update by adding it to the cesiumReadonlyProps array, which is where it belongs according to the Cesium and Resium documentation.
 I can add those changes to the PR if necessary.

@TheMrCam We've released v1.18.0. Thank you!


Tiles broken when using the option param

When i am using my own handled map container the tiles are where they should be, but when iam using the option param than the tiles are broken.
This is my working code in the controller (than i get only the error because the directive tries to put another map in there)
var map = L.map('map').setView([0, 0], 2);
		L.tileLayer('altis2/{z}/{x}/{y}.png', {
			minZoom: 1,
			maxZoom: 7,
			attribution: 'ESO/INAF-VST/OmegaCAM',
			tms: true,
			noWrap: true
		}).addTo(map);

And this is the code with using the option param that is not working right.
$scope.defaults ={
			tileLayer: 'altis2/{z}/{x}/{y}.png',
			minZoom: 0,
			maxZoom: 7,
			tms: true,
			noWrap: true
		};
		$scope.center = {
			lat: 0,
			lng: 0,
			zoom: 2
		};

Both are with
<leaflet id="map" tiles="tiles" defaults="defaults" center="center" ></leaflet>
And here are the screenshots of the broken parts:
http://imgur.com/a/DSlZo
So there must be a difference how the L.titleLayer is working and how the tileLayer option is working.
Cheers,

This issue was moved to angular-ui/ui-leaflet#132

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.


Add CRD KongVault to manage custom vaults in Kong gateway

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
Split from #4559.
Kong gateway supports to create custom vaults (https://docs.konghq.com/gateway/3.5.x/kong-enterprise/secrets-management/) to store sensitive data and reference them by vault URI in plugin configurations. So we need to define a KongVault CRD to represent a custom Kong vault. This issue tracks the implementation of KongVault CRD.
Proposed Solution
Add a KongVault CRD in configuration.konghq.com/v1alpha1 group/version to represent a custom Kong vault.
Additional information
No response
Acceptance Criteria

[ ] Has the definition and basical CEL validation rules of KongVault CRD.

@randmonkey A couple of questions:

Why v1alpha1? This feels like a low-risk change to me with a well defined schema.
Why CEL? We need to delegate validation to Gateway's validation endpoint anyway. The two validations could get out of sync

Why v1alpha1? This feels like a low-risk change to me with a well defined schema.

Am I reading this correctly that we'd like to push it up to let's say v1beta1 group to give users a hint that it's a bit more stable/mature API than alpha?
I'd argue that we err on the safe side and release alpha first and after a reasonable soak time push it up to beta. WDYT?

Yep, I'd have defaulted to v1beta1 for this resource. There are maintenance costs for promoting (in code + docs), and I don't see much value here

@randmonkey A couple of questions:

Why v1alpha1? This feels like a low-risk change to me with a well defined schema.
Why CEL? We need to delegate validation to Gateway's validation endpoint anyway. The two validations could get out of sync

Why v1alpha1: I do not have the confidence that there will be no major changes on this API so I first add it in v1alpha1. If we have the common sense that there will be no major changes (say remove or change the semantic of existing fields) on the API, we may move it to v1beta1.
I think the major validation should happen on gateway side, but the CELs are for the most basic validations, like backend cannot be empty, prefix should be unique (This seems not to have a supporting CEL expression?)

👍 on CEL
As soon as this API is shipped, customers will adopt it. I'd prefer to spend extra cycles before shipping and provide something that we're confident with in v1beta1 than ship an alpha and potentially change it


Add More helper functions to TransactionsHandle type

Describe the feature
It can be useful to get an overview of what transactions certain peers know about and to what peers we're connected
https://github.com/paradigmxyz/reth/blob/11ee5d75308d4a7519fdecba4a0fa5f51c61cf0e/crates/net/network/src/transactions.rs#L820-L821
TODO

add new command for retrieving the active peer ids
add new command for propagating a hash to a specific peer PropagateHashTo(H256, PeerId),
add new command for propagating full transactions to a specific peer
add new command for retrieving the tx hashes of peers: https://github.com/paradigmxyz/reth/blob/11ee5d75308d4a7519fdecba4a0fa5f51c61cf0e/crates/net/network/src/transactions.rs#L831-L834

For all Peers, for a specific peer

ref
https://github.com/paradigmxyz/reth/blob/11ee5d75308d4a7519fdecba4a0fa5f51c61cf0e/crates/net/network/src/transactions.rs#L61-L63
Additional context
No response

hello can i take this ? but please if i have problem or not understand something, may i ask about it ?

sure, we can do these commands one by one
start with PropagateHashTo(H256, PeerId)
which is similar to
https://github.com/paradigmxyz/reth/blob/11ee5d75308d4a7519fdecba4a0fa5f51c61cf0e/crates/net/network/src/transactions.rs#L75-L78
if you need some pointers please open a draft and we take it from there

sure, we can do these commands one by one
start with PropagateHashTo(H256, PeerId)
which is similar to
https://github.com/paradigmxyz/reth/blob/11ee5d75308d4a7519fdecba4a0fa5f51c61cf0e/crates/net/network/src/transactions.rs#L75-L78
if you need some pointers please open a draft and we take it from there

Thank you so much !

Hello, I sincerely apologize, but I have decided to discontinue this because i'm not comfortable with this. I want to extend my apologies once more

no worries!
maybe a different issue ;)

Hey, I am interested to take this issue.
(BTW, it seems that #4691 also mentions the same problem.)
I will start from PropagateHashTo(hash, peer_id) as recommended.

Hey, I am interested to take this issue. (BTW, it seems that #4691 also mentions the same problem.)
I will start from PropagateHashTo(hash, peer_id) as recommended.

This issue can be closed by #4668 if I'm not mistaken @mattsse ? But issue #4691 is based precisely on the implementation of helper functions made in #4668: for each new variant, we have to implement the missing logic in TransactionsManager to replace the todo!() in the on_command function.

@mattsse
Can you check the draft PR #4713 ?
Thx in advance!

BTW, what is going on with issue #4691?
I am sure these two issues aim for same goal.

@mattsse
I have a question about this logic. https://github.com/paradigmxyz/reth/blob/main/crates/net/network/src/transactions.rs#L302-L329
As far as I understand, the new_pooled_hashes includes hashes of both blob tx and full tx.
But, when sending transctions, the max_num_full peers receive only full txs, and other peers receive only blob tx hashes.
So, it means that max_num_full peers do NOT receive blob tx hashes, and other peers do NOT receive full txs.
I think this is wrong, since I believe that max_num_full peers not only receive full txs, but also blob tx hashes.
Can you give explanation?

@mattsse
Here is another PR for helper impls - PR #4806 .


Update Readme.md

a typo fix

Hi @pkarda, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Appreciate the PR. Can you re-submit it for develop branch please.


Remove solid-start-mdx package

I'm trying to clean up the MDX story, so it's more clear, and so solid devs can take full advantage of recent development with twoslash, shiki etc, and it came to my attention that solid-start-mdx has become obsolete.
solid-start-mdx is not used in the with-mdx example, or the new docs, where instead we use a combination of these three:
https://www.npmjs.com/package/solid-mdx
http://www.npmjs.com/package/@vinxi/plugin-mdx
https://www.npmjs.com/package/@mdx-js/mdx
And the solid-site repo uses:
https://www.npmjs.com/package/solid-mdx
https://www.npmjs.com/package/@mdx-js/rollup
There have also been a few community efforts in this space:
https://www.npmjs.com/package/vite-plugin-solid-markdown
https://www.npmjs.com/package/solidjs-mdx
More info about solid-start-mdx:

I'll look into that one - might have missed that

Okay, so it's used exclusively in https://start.solidjs.com/ a bit longer.

Yep. That's the only reason exists. But it can go away soon.

Seems like it now would be better for new users now if the url in the start GitHub repo pointed to here where guides and api docs are updated:
https://docs.solidjs.com/solid-start


Piping output of updatecli commands not working

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I have tried several ways to pipe (|) updatecli command's output but it seems like it doesn't work. Output remains same same as the initial command.
Expected Behavior
We would be able to pipe output of updatecli command and use utilities like tail, grep.
Steps To Reproduce

Create an updatecli config with at least source and target
Run updatecli diff or updatecli apply and try to pipe the output to tail or less or grep

updatecli diff | grep "Run Summary" -A7

Expected
Run Summary
===========
Pipeline(s) run:
  * Changed:    1
  * Failed:     0
  * Skipped:    0
  * Succeeded:  1
  * Total:      2

Actual

We get whole output of the command

Environment
- OS: Ubuntu 24.04
- updatecli: 0.86.1

Anything else?
No response

Thanks for opening this issue. You are right by default Updatecli output to StdErr instead of StdOut.
It took me a long time to notice that but I must admit, it wasn't my priority.
The fix is easy but potentially a break change

Thank you for quick response. Much appreciated. I will try the following:

Try and catch the stderr (in shell)
Try redirecting stderr to stdout (in shell)

See if I can find a workaround for now. If you already know something, feel free to share.

Thank you for quick response. Much appreciated. I will try the following:
1. Try and catch the `stderr` (in shell)

2. Try redirecting `stderr` to `stdout` (in shell)

See if I can find a workaround for now. If you already know something, feel free to share.

On short term, you should be able to redirect stderr to stdout which would do the trick:
updatecli diff 2>&1 | grep "Run Summary" -A7

@dduportal it worked. Thanks.


show individual split amount on Bill Split IOU Previews

Details
show individual split amount on Bill Split IOU Previews
Fixed Issues
$ https://github.com/Expensify/App/issues/18706
PROPOSAL: Coming from https://expensify.slack.com/archives/C02NK2DQWUX/p1683711639585659
Tests

Login any account
Create a bill split with 3+ users in any group chat
Look at the IOUPreview
Verify that the Split AMOUNT shows beneath the participant avatars

[ ] Verify that no errors appear in the JS console

Offline tests
Same as Tests
QA Steps
Same as Tests

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/97473779/c629fa27-b653-467d-9e50-0d5290a6cb28

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Running into this issue

but not sure if its related, seems like the chat reportID is not right
The job 1 seems to be failing too

Here's a separate issue for the error

All yours @Santhosh-Sellavel. Signing out/in should resolve the issue seen above 🤞

@0xmiroslav Seems we run into conflicts again.

Cool, thanks will review shortly

Should we show splits only for the last request? @mountiny or @Julesssss

Signing out/in should resolve the issue seen above 🤞

As far as I see, I have no problem creating the split in new group chats, but it happens for old group chats.

Sorry @0xmiroslav We have conflicts again, please resolve them thanks.

@0xmiroslav just to confrim I am not sure if all the code necessary in Staging? Dont want to get merge conflicts wiht the CP

Cool agreed, thanks!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.14-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add support for multiple -from / -to packages

Add support for specifying multiple from / to (source / destination) packages.
Use cases include:

Analyzing imports from multiple binaries in the same project
Search for imports to a specific project, with multiple packages

Note: -toregex essentially solves for multiple destination packages. Still need to support multiple source packages though.


Jest test fails when including 4x.js library

I am not able to get Jest tests to pass while including the library in my jest config as setupFilesAfterEnv: ['path_to_4x.js'] or setupFiles['path_to_4x.js'].
I get the following error:
    TypeError: Cannot read property 'on' of undefined

      1492 |
      1493 |     event: {
    > 1494 |       on: window.bean.on,
           |                       ^
      1495 |       add: window.bean.add,
      1496 |       one: window.bean.one,
      1497 |       off: window.bean.off,

      at path_to_4x/4X.Max.js:1494:23

Thanks, that is odd. I've never used Jest before, so I'll need to do some reading on it.
4X has several internal dependencies that are preloaded before the primary API, Bean is for handling internal events, plus the Promise and Fetch API polyfills for cross browser support. These tie into the current window when processed.
What happens if you change the following in the 4X.Max.js file then run the same test?
on: window.bean.on,

To this instead:
on: bean.on,

Does the same error occur?

I'm still getting an undefined:
ReferenceError: bean is not defined

Thanks, I just pushed a new version of 4X, which uses an internal object reference instead. That should hopefully fix your issue. Please let me know if that does the trick. The new version name is Broken Angels.

Thanks for looking into this. I'm still seeing errors. This is the output now:
  ● Test suite failed to run

    TypeError: $A.event.on is not a function

      1318 |       _parseURLWithSelector: function(u) {
      1319 |         var ss = u.split(/\s+/);
    > 1320 |         return {
           |                           ^
      1321 |           url: ss[0],
      1322 |           selector: u.substring(ss[0].length)
      1323 |         };

      at String.<anonymous> (path_to_js/4X/4X.Max.js:1320:30)
      at Function.loop (path_to_js/4X/4X.Max.js:703:16)
      at Function.<anonymous> (path_to_js/4X/4X.Max.js:1313:20)
      at Function.loop (path_to_js/4X/4X.Max.js:707:16)
      at Document.<anonymous> (path_to_js/4X/4X.Max.js:1310:16)
      at Function.loop (path_to_js/4X/4X.Max.js:703:16)
      at Function.on (path_to_js/4X/4X.Max.js:1307:12)
      at path_to_js/4X/4X.Max.js:4465:8
      at path_to_js/4X/4X.Max.js:4515:5
      at Object.<anonymous> (path_to_js/4X/4X.Max.js:6178:3)

That is so weird. I know the events are working, otherwise nothing would work.
I don't know how to duplicate what you are seeing for testing on my end.
Would it be possible for you to  upload a copy of your repo that includes the Jest config and tests so I can run it on my end? Probably best from your account as your own repo, either public or private as you wish.
I'll need some help in getting it started since I've never used Jest before.
Please feel free to send me an email if that is easier to collaborate. bryan.garaventa @ whatsock . com

Bryan, I've sent an email with an example of what I'm encountering.

test.zip

Here is an example of a simple test failure I’m seeing. If you run npm install and then  npm run test from the project root I’m seeing the following error:
TypeError: Cannot read property 'on' of undefined
  1225 |                           rs = $A.create("style", {
  1226 |                             type: "text/css",
> 1227 |                             id: $A.genId()
       |                       ^
  1228 |                           });
  1229 |                           rs.innerHTML = content;
  1230 |                           if (!nC) $A._cssCache[u] = rs;

  at test/4X/4X.Max.js:1227:23
  at Object.<anonymous> (test/4X/4X.Max.js:4494:3)
  at async TestScheduler.scheduleTests (node_modules/@jest/core/build/TestScheduler.js:333:13)
  at async runJest (node_modules/@jest/core/build/runJest.js:387:19)
  at async _run10000 (node_modules/@jest/core/build/cli/index.js:408:7)
  at async runCLI (node_modules/@jest/core/build/cli/index.js:261:3)

Thanks, I'll give this a swing in the next couple of days and hopefully get things sorted out sooner than later. :)

Hi, I'm totally stumped. I was able to produce the error using the Broken Angels version of 4X, which you would need to switch out for the one in the sample zip which is using Mona Lisa Overdrive.
It looks like the code that Jest is choking on is contained within a promise callback, which is confusing because the code block that is referenced does not actually include any object.on declarations even though that is what the error states in the Jest console.
In researching this, I found the following 2 resources that may help figure out how to load tests that will handle the Fetch API callbacks correctly, which will likely be needed.
https://www.w3resource.com/jest/testing-asynchronous-code.php
https://www.pluralsight.com/guides/test-asynchronous-code-jest
I will need your help to confirm this though, plus anyone else who knows how Jest works to figure this one out. Hopefully there is somebody out there who can help me debug this oddity.

@accdc, thanks for looking into this. I can't guarantee that I'll have a lot of time to investigate, but I will not these resources and can also ask around to the team.

No problem, I'll keep poking at it too as time allows and hopefully something will make sense at some point. I expect those familiare with Jest will have better insights hopefully as to the nature of the issue. Please let me know if you discover anything on your end.

Hi,
Closing this issue since it was fixed with the addition of the standard loading script files within the root repo folder "4X/Standard", which includes a ReadMe file that describes how to implement it.


Check for changes to the public API

We would like to get to a stage where we can commit to the public API. To help us achieve this add a script that generates the public API and checks it against three committed files, one for each feature set: no features, alloc, std.
The idea is that with this applied any PR that changes the public API should include a final patch that is just the changes to the api/*.txt files, that way reviewers can discuss the changes without even needing to look at the code, quickly giving concept ACK/NACKs. We also run the script in CI to make sure we have not accidentally changed the public API so that we can be confident that don't break semver during releases. The script can also be used to diff between two release versions to get a complete list of API changes, useful for writing release notes and for users upgrading.
There is a development burden involved if we apply this patch.

This is the same idea as https://github.com/rust-bitcoin/rust-bitcoin/pull/1880

Definitely need @clarkmoody to weigh in before we can move forward on this :)

There is a fair bit of context in the PR I link to above @clarkmoody, no rush on this one. Thanks

Rebased and added changelog section so this conforms to mkchlog (introduced in #155), please do not merge until after #155.

cc @clarkmoody can you take a look at this?

I can split this up like https://github.com/rust-bitcoin/rust-bitcoin/pull/1880 if its easy for you guys to review.

I can't work out why this is failing. Its giving a different sort order than what is in the PR (ie., I'm getting a different order locally to what the VM in CI is getting)?

See discussion on https://github.com/rust-bitcoin/hex-conservative/pull/34 (looks like we didn't do this for rust-secp; surprised we haven't had problems there). I think we want sort -n which seems to be more consistent between implementations, and then --unique doesn't work properly so we want to pipe into | uniq?
Regardless of reasoning, we should cargo-cult sort -n | uniq from the hex-conservative crate and see if that fixes things.

OMG finally, this sort command got us there SORT="sort --numeric-sort --ignore-case --stable --unique".

Ugh, bollocks.

I'm going to debug this in hex-conservative, sorry for all the noise, I had no idea it would be such a PITA.

@clarkmoody are you ok if we merge this? It adds additional burden to contributors with the stated aim of improving our ability to commit to a stable API.

Gentle bump please @clarkmoody, really don't want to merge this without your consent and I'd love to release a non-beta version of this crate v0.10.0.


Move 'response to other organism' under interspecies interaction

This comes from the request here:
https://github.com/geneontology/go-site/issues/1249
gorule-0000015 checks that if there is a value in the 'interacting taxon' column of the GAF file, the GO term annotated must be 'GO:0044419 : interspecies interaction between organisms' or a child.
This causes problems 'response to other organism', which is not under 'interspecies interaction between organisms'. We will modify the ontology to fix that, since there are no terms that describe 'response to the same organism'.
Thanks, Pascale

Done here:
https://github.com/geneontology/go-ontology/pull/18805/commits/63ec58cd2cfbdaa6ac1407ca0549eadf7b31b06e


Error on Etherscan

Hey, I know this was just a small project for you but I was really interested in trying to get it implemented and maybe do some improvements. But I'm hitting a wall trying to test it out. I can create the dummy implementation. Attach the etherscan facet. All that, even in your example project. But when I actually go on etherscan and try to attach the proxy I get this issue
The proxy contract verification completed with the below message:

This contract does not look like it contains any delegatecall opcode sequence.

The Diamond I deployed is here.
Louper for the Diamond is here
The DummyDiamondImplement is here.
It's when I go to the Diamond etherscan page and try to connect the proxy as 0x962956885a86825Ee65F01dF7ceFc413436750ac that I get that error. Do you see anything that I'm doing obviously wrong here? Or is it possible Etherscan updated how they handle proxies in the past few months?

Hey @jhubbardsf apologies I must have missed this.
Did you end up figuring it out?

I thought I had figured it out but i can't find it in my notes and can't reproduce it where it works.