remove calls to __instancecheck__ on ModelValidator

As of #492 ModelValidator is checking if the input is an instance of BaseModel before doing anything else.
Because BaseModel is an abc, the isinstance rust call is eventually calling the python __instancecheck__ method on BaseModel's metatype.
isinstance checks have significant performance problems, see pydantic/pydantic#3829 and python/cpython#92810.
We should look at removing this check by implementing a faster isinstance check but just looking at the type, and the type's tp_base (or maybe tb_bases) - this would effectively lead to a fast_isinstance method.

Some initial benchmarks indicate this isn't a major issue, although it could lead to memory growth as per https://github.com/python/cpython/issues/92810.
We should look at this before releasing v2.

@samuelcolvin is this a good first issue? I eager to practice my Rust in real life

Probably not, I've tried and this isn't making a big difference to performance.
Honestly they're probably aren't that many good issues if you want to learn rust right now.

you could try looking at https://github.com/pydantic/pydantic-core/pull/584, copy that code and create a new PR?


Unhelpful error message

az storage container metadata update -n vhds --metadata "a=1" --if-modified-since 2018-01-01T00Z
The condition specified using HTTP conditional header

@tjprescott thoughts?
I guess this is related to this https://github.com/Azure/azure-cli/issues/868.

In the storage SDK for if-modified-since it says:

Specify this header to perform the operation only
if the resource has been modified since the specified time.

https://github.com/Azure/azure-storage-python/blob/master/azure/storage/blob/baseblobservice.py#L677

Yes, this is the error returned by the service.

Close the issue due to the idle time. Please reopen if there is still questions.


Poor documentation on DPI awareness

Re DPI adjusting instructions on page: https://learn.microsoft.com/en-us/visualstudio/designers/disable-dpi-awareness?view=vs-2022
Instructions are unclear.  Instructions on the page say: "The preferred solution to this issue is to restart Visual Studio as a DPI-unaware process. Do so by selecting the option on the yellow information bar."
However, there is no option to "restart DPI-unaware".  There is only an option to restart "with 100% scaling" (and "help me decide" which brings to the page in question).  But starting with 100% scaling isn't "the preferred solution"!

Does the "restart w/100%" link actually restart as DPI unaware?
Elsewhere on the page it says: " If an application states that it's not DPI-aware, the operating system scales the application as a bitmap.... The application still thinks that it's running at 100% scaling". Is this what that link means?
Or is there another way to restart "DPI unaware"?

Instructions on the pages should be adjusted to reflect facts on the screen!
I'm using:
VS Enterprise 2019
version 16.11.18
I'm opening WinForms designer in a C# project.
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a2f87f79-412c-6d45-9a5f-e1690a7dce12
Version Independent ID: 708a3cc0-a8eb-3b23-9d11-737d0060d730
Content: Disable DPI-awareness for scaling in forms - Visual Studio (Windows)
Content Source: docs/designers/disable-dpi-awareness.md
Product: visual-studio-windows
Technology: vs-ide-designers
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@GarthOgzewalla -- Garth, thank you for your clear feedback.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@TerryGLee -- Terry, please look into this issue.

@GarthOgzewalla We've updated the page to address the feedback you've provided; hopefully, you'll find the revised content more useful than it was before. We'll close this issue now, with our thanks to you for your help with improving the Visual Studio documentation!


Error when evaluating dataset produced with DateSplitter

Description
I am getting an error AttributeError: 'str' object has no attribute 'copy' when trying to run make_evaluation_predictions on a datset produced with DateSplitter. Example below.
To Reproduce
Running the following code produces the error.
import pandas as pd
import numpy as np
import json
from gluonts.evaluation import Evaluator
from gluonts.evaluation import backtest
from gluonts.dataset.common import ListDataset, TrainDatasets, MetaData
from gluonts.evaluation import make_evaluation_predictions
from gluonts.model.trivial.identity import IdentityPredictor
from gluonts.evaluation import make_evaluation_predictions
from gluonts.dataset.split import DateSplitter

# from gluonTS tutorial: https://ts.gluon.ai/tutorials/forecasting/extended_tutorial.html#Training-an-existing-model
N = 10  # number of time series
T = 24*7  # number of timesteps
prediction_length = 24
freq = "1H"
custom_dataset = np.random.normal(size=(N, T))
start = pd.Timestamp("01-01-2019", freq=freq)

train_ds = ListDataset(
    [{'item_id': str(i),'target': x, 'start': start} for (i,x) in enumerate(custom_dataset[:, :])],
    freq=freq
)

splitter = DateSplitter(
    split_date=pd.Timestamp('01-04-2019', freq=freq),
    prediction_length=24
)
train_split, train_split_rest = splitter.split(train_ds)

predictor = IdentityPredictor(prediction_length=prediction_length, num_samples=1, freq=freq)
forecast_it, ts_it = make_evaluation_predictions(
    dataset=train_split,
    predictor=predictor,  # predictor
    num_samples=1,  # number of sample paths we want for evaluation
)

forecasts = list(forecast_it)
tss = list(ts_it)

Replacing train_split with ex. train_ds does not lead to an error, so somehow this error is due to using DateSplitter.
Error message or code output
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-16-b45b8a96ce8e> in <module>
     37 )
     38
---> 39 forecasts = list(forecast_it)
     40 tss = list(ts_it)

~/conda/derv1_1_0/lib/python3.7/site-packages/gluonts/model/predictor.py in predict(self, dataset, **kwargs)
    162
    163     def predict(self, dataset: Dataset, **kwargs) -> Iterator[Forecast]:
--> 164         for item in dataset:
    165             yield self.predict_item(item)
    166

~/conda/derv1_1_0/lib/python3.7/site-packages/gluonts/transform/_base.py in __iter__(self)
    103     def __iter__(self) -> Iterator[DataEntry]:
    104         yield from self.transformation(
--> 105             self.base_dataset, is_train=self.is_train
    106         )
    107

~/conda/derv1_1_0/lib/python3.7/site-packages/gluonts/transform/_base.py in __call__(self, data_it, is_train)
    126                 yield self.map_transform(data_entry.copy(), is_train)
    127             except Exception as e:
--> 128                 raise e
    129
    130     @abc.abstractmethod

~/conda/derv1_1_0/lib/python3.7/site-packages/gluonts/transform/_base.py in __call__(self, data_it, is_train)
    124         for data_entry in data_it:
    125             try:
--> 126                 yield self.map_transform(data_entry.copy(), is_train)
    127             except Exception as e:
    128                 raise e

AttributeError: 'str' object has no attribute 'copy'

Environment

Operating system: Linux
Python version: 3.7.10
GluonTS version: 0.9.4
MXNet version: 1.7.0.post1

Hi,
.split actually returns an instance of:
class TrainTestSplit(pydantic.BaseModel):
    train: List[DataEntry] = []
    test: List[DataEntry] = []

Which destructured returns tuples of key value pairs.
What you probably want is something like this:
split = splitter.split(train_ds)

predictor = IdentityPredictor(prediction_length=prediction_length, num_samples=1, freq=freq)
forecast_it, ts_it = make_evaluation_predictions(
    dataset=split.train,
    predictor=predictor,  # predictor
    num_samples=1,  # number of sample paths we want for evaluation
)

FYI: We have reworked the split in v0.11, see this notebook for more on that.


Add component diagrams to developer.md

Add diagrams showing all the components, and their relationships. This would look similar to a systems engineering Description View

Hey team! Please add your planning poker estimate with Zenhub @ClifHouck @dejanzele @kannon92 @richscott @Sharpz7 @suprjinx


Respond to https://hypothes.is/a/SroGBjhrEeqGvytQ0j9_pw

Respond to hypothes.is annotation SroGBjhrEeqGvytQ0j9_pw on https://jrnold.github.io/r4ds-exercise-solutions/data-visualisation.html (user<EMAIL_ADDRESS>created: 2020-01-16T14:20:05.322057+00:00, updated: 2020-01-16T14:20:05.322057+00:00)

missing the variable manufacturer, which is also a categorical () variable.

Link: https://hyp.is/SroGBjhrEeqGvytQ0j9_pw/jrnold.github.io/r4ds-exercise-solutions/data-visualisation.html

Already fixed.


Alias3

Essentially we were calling shared_from_this on a unique_ptr by mistake

The rationale is that attributes are not substituted and thus do not need to be stored as a shared pointer. There is an implicit conversion from unique_ptr to shared_ptr, but not the other way around.


More robust and flexible tensor dataloader

Notes
At a high level it looks like train_dataloader.py is the main file that initializes everything and creates the correct dataset and returns it. filter.py is nice - I like a dedicated script for filters we can apply to datasets that either filter based on the streams or metadata. We are still doing cut detection in the dataloader, not sure if we want this since we moved this to the dataset creation stage. Would reduce the amount of code here which I think is positive for a dataloader.
WebDatasetWithChagnedDecoder looks interesting although it seems to only be used when cut detection is happening which if we don't want will mean it won't be used anymore. Need to look into this more.
train_dataloader.py:

no PyTorch dataloader. Do we want that?
cut detection is happening maybe we remove that since we added the subsampler at dataset creation phase
need to figure out how to pass args in

custom_wds.py:

what are other uses of this? seems more general than just cut detection

video_decode.py

https://github.com/iejMac/video2dataset/blob/373a76938f7780bc41d483e18b183c430e0601c7/video2dataset/dataloader/video_decode.py#L85 - are the frames selected randomly?? how does this work?
perhaps we can keep VideoDecoderCutDetection as an example of video decoders and how to write them in video2dataset. Maybe we also need to make a subsamplers type folder for this...

filters.py

maybe if we see more filters being added we can make this into a folder like with subsamplers so we can individually test the filters, not important now but something to think about for the future.

Notes v2

Why do we need shardshuffle nad regular shuffle? Can't we just have one variable that decides if we shuffle at both levels? I don't see when you'd want one but not the other.
Why the need for the VideoResizer? Why not just use torch vision transforms like in - https://github.com/iejMac/video2dataset/blob/5077529e3e82a01db76e7ac71d3c0a4bcf39c348/video2dataset/dataloader/transform.py#L155
Do we need this? https://github.com/iejMac/video2dataset/blob/5077529e3e82a01db76e7ac71d3c0a4bcf39c348/video2dataset/dataloader/video_decode.py#L131 Can't we just read this off from the frames in the VideoResizer?

ok lint is finally fixed

One those questions are answered I'd also like to merge the bytes dataloader into a regular WebDataset with a bytes video decoder

Regarding your questions:

yes we can skip shardshuffle, having one var for this is better
As far as I can see, your transform function is randomly cropping every individual frame independently of the others (is this the case?). This could lead to bad temporal consistency, since frames are not aligned then.  Apart from that, the Resizer offers a couple more combinations of resizing/cropping combinations than the video_transform() function, as far as I could see. But if you think that these are not needed, we can also remove it.
Reading from VideoResizer? --> yes, we can do this.

Ok all issues with current code have been resolved to my best knowledge. Going to try to deprecate the bytes dataloader now and then merge


Check "uses" versions in GitHub Actions

actions/checkout@v3
actions/setup-python@v2
actions/cache@v2

https://github.com/sadikkuzu/local-hook/blob/16ce273c502adef667ec0a7905d052ad0d857609/.github/workflows/localhook.yml#L14-L25

actions/checkout@v3 OK https://github.com/actions/checkout/releases/tags/v3.5.3
actions/setup-python@v2 -> v4 https://github.com/actions/setup-python/releases/tags/v4.7.0
actions/cache@v2 -> v3 https://github.com/actions/cache/releases/tag/v3.3.1


Create README.md

@ManuelFay thanks you so much for adding a dataset card, this is such a cool contribution!
This looks like it uses an old template for the card we've moved things around a bit and we have an app you should be using to get the tags and the structure of the Data Fields paragraph :) Would you mind moving your text to the newer format (we're also asking contributors to keep the full template structure, even if some sections still have [More Information Needed] for the time being)
Here's the link to the instructions:
https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md#tag-the-dataset-and-write-the-dataset-card
Out of curiosity, what was your landing point for filling out the card? Did you follow the "Update on Github" when navigating the datasets? Trying to make the instructions as clear as possible :)

@yjernite
Perfect, I'll follow the instructions when I have a bit more time tomorrow ! I was actually browsing the new contributions after the dataset sprint and realized most of the "old" datasets were not tagged, so I just copied and pasted the readme from another dataset and was not aware there was precise instructions... Will fix !
BTW, amazing job with the retriBert work, I used the contrastive + in-batch negative quite a bit for various projects. Probably neither the time nor place to talk about that but I was curious as to why, in your original work, you prefered using a simple projection in the last layer to differentiate the question vs answer embedding, rather than allowing for dropout in the dense layer or even just to fine-tune 2 different embedders for question + answer ?

Cool! Looking forward to the next version!
Quick answer for retriBERT is that I expected a simple projection to generalize better and more importantly only having to store the gradients for the proj means training with larger batches :) If you want to keep chatting about it, feel free to send me an email!

Hi @ManuelFay !
If you're still interested in completing the FQuAD dataset card, note that we've generated one that is pre-filled.
Therefore feel free to complete it with the content you already have in your README.md.
This would be awesome ! And thanks again for your contribution :)

Yo @lhoestq , just not sure about the tag table at the top, I used @yjernite eli5 template so hope it's okay ! Also want to signal the streamlit app for dataset tagging has a weird behavior with the size categories when filling in the form.
Thanks to you guys for doing that and sorry about the time it took, i completely forgot about it !

Quick idea pitch, dynamic datasets:
I am typically thinking about @yjernite ELI5 dataset which contains Reddit data, which is static once it has been downloaded from the Pushshift dump for the first time. This has 2 potential limitations:

The data does not update with time, which is good for benchmarking but it could be nice to have a dataset that updates with the latest infos and trends.
In terms of data regulations, having downloaded user data from a website (which might be somewhat personal) at one point in time, and then storing it, might hinder the "right of deletion" set forth by the GDPR etc...

A solution could be to have datasets that either automatically re download and process data from their source periodically, or even to have datasets which are not even stored on HF servers but are rather downloaded on the fly by the user, the datasets library being used in this case as a middle-man interface to automate and smooth things out (enabling to circumvent some GDPR restrictions regarding data storage).
Probably not the place to suggest this, sorry :)


Carousels don't work after update Grav

Carousels don't work after update Grav

omg, jquery stop working sometimes

All the sliders are working, I have refreshed the site many times and also tried on different browsers.


Static force-directed graph layout

Static layout may be better for a large graph.

https://bl.ocks.org/mbostock/1667139
https://bl.ocks.org/mbostock/01ab2e85e8727d6529d20391c0fd9a16

The effect is very interesting! 👍

yes, I've implemented it at https://github.com/netjson/netjsongraph.js/commit/1f3959ff33991f73f3282db1a5c9c1c889344bf0


Video file filter

Nice. Looks great. Were you able to test that it works fine?
Also, I was thinking it might be a good idea to provide support for exporting the transcription as an SRT file when the file is a video so that it can be used as subtitles. I'll have a look at that.

Works for me on Ubuntu. I suppose more formats are possible. SRT might be useful for some


IOS 13 shows extra (Not Supported) accessory?

I updated one of my iPhones to IOS 13, and having some issues getting the Harmony to show up correctly.
On my IOS 12 iPhone, I have a perfect working icon Harmony. I can select directly witch input i want.
Same HomeKit on IOS 13 gives now the Hamony tile, but "behind" that is an extra accessory called TV.
When i look into HomeBridge Config UI X, is can see an "Not Supported" accessory, in the properties the name is "Harmony-TV"
Also some info there about Speaker, Mute and Volume.
IOS 12 doesn't seem to do antthing with is, but can it be that IOS 13 is seeing that accessory, and linking it to the Harmony tile ?

Hi, Tvaccessory includes different services (speaker, inputs ..)
I have no problem on iOS13, did you try restarting homebridge / home app ? Can you share screenshots ?
Sent with GitHawk

my current config:
"platform": "HarmonyHubWebSocket",
"name": "Harmony",
"hubIP": "192.168.x.xx",
"showCommandsAtStartup": false,
"cleanCache": false,
"publishAllTVAsExternalAccessory": true,
"showTurnOffActivity": "stateless",
"switchAccessories": true,
"mainActivity": "Radio",
"devicesToPublishAsAccessoriesSwitch": [
"AV-ontvanger Harman Kardon;VolumeUp|100;VolumeUp|100;VolumeUp|100;VolumeUp|100;VolumeUp",
"AV-ontvanger Harman Kardon;VolumeDown|100;VolumeDown|100;VolumeDown|100;VolumeDown|100;VolumeDown",
"Tower Ventilator;PowerToggle",
"Tower Ventilator;Speed",
"Tower Ventilator;Osc"
]

Screenshots from HomeBridge Config UI X:

Ok, maybe it is because it is published as an external device and iOS 13 messed  with it . Try deleting in home app and readd
Sent with GitHawk

Problem solved !
It turns out that I had an activity with the name "TV".
Also an device named TV.
IOS 12 doesn't seem to mind, but in IOS 13 things have changed.
So I renamed the activity, and now things are working like it should be.

Interesting ... iOS 13 is buggy however so might be a bug there :)
Sent with GitHawk


Panda style

Updated gitignore && added support to draw Triangles

This looks good. However, here's how to make it perfect:

Remove swap files ansilib/inc/graphics/.box.h.swp, ansilib/src/graphics/.shapes.c.swp and src/.main.c.swp.
Remove system("clear") at https://github.com/CodeOn-ArK/ansi_anim/blob/df9daeed912b9eb1a249fda1b4b7f09f7f99273f/src/main.c#L63. We need custom function for that that which throws the necessary ANSI codes for clearing the screen.

Check now


chore(deps): use official versions of bufpipe and expr

Related to #12032; there was a license issue that was picked up
Revert of #11971 now that antonmedv/expr is back
Motivation

expr's main fork is back after being temporarily down from GH, so return to using that

bufpipe v1.0.4 added an MIT License

it was added 4 years ago, but there was no GH release until earlier this year (c.f. https://github.com/acomagu/bufpipe/issues/7 and https://github.com/acomagu/bufpipe/issues/8. to clarify, the newest is v1.0.4)
this is an indirect dependency, but FOSSA found it and flagged it as unlicensed

FOSSA screenshot:

go-git uses it, but since we've had some issues with go-git and artifacts in the past (#10763, #11149 etc), I didn't touch it for now

Upgrading go-git would resolve this as well, see Argo CD PR: https://github.com/argoproj/argo-cd/pull/12907

see go mod why output:

$ go mod why -m github.com/acomagu/bufpipe
github.com/argoproj/argo-workflows/v3/workflow/artifacts/git
github.com/go-git/go-git/v5
github.com/go-git/go-git/v5/utils/ioutil
github.com/acomagu/bufpipe

Modifications

Changed go.mod for expr and bufpipe and ran go mod tidy for the go.sum results

Verification

Ran go mod tidy. Otherwise there are no semantic changes in the deps

Thanks. I was planning to do this today. The author's account is back and I have confirmed with him personally that he's planning to keep the repo under antonmedv/expr going forward.


Add warning in development when a result function is x => x.

This PR:

[x] Adds identityFunctionCheck to warn to the user if the result function returns its input. It has the same configuration options as inputStabilityCheck.
[x] Adds unit tests for identityFunctionCheck.
[x] Adds JSDocs for identityFunctionCheck.
[x] Adds documentation for identityFunctionCheck to README.
[ ] Adds documentation to Netlify docs once merged with #641.

BTW I only called it noopCheck to stay consistent with react-redux, if you have a better suggestion I'm all ears :)

we couldn't come up with anything better for react-redux so i doubt we'll do so here :) noopCheck is fine imo

we couldn't come up with anything better for react-redux so i doubt we'll do so here :) noopCheck is fine imo

How about IdentityFunctionWarning or maybe NoTransformationWarning?

I don't know how many more dev checks we'd add in the future, but I think we ought to consolidate this into a single combined setter function just in case we do add more, rather than adding a bunch of individual setters.
I'm thinking something like setDefaultDevCheckFrequency(checks: Partial<Record<DevCheckType, DevCheckFrequency>>).
Let me play with that a bit on this branch.

I don't know how many more dev checks we'd add in the future, but I think we ought to consolidate this into a single combined setter function just in case we do add more, rather than adding a bunch of individual setters.
I'm thinking something like setDefaultDevCheckFrequency(checks: Partial<Record<DevCheckType, DevCheckFrequency>>).
Let me play with that a bit on this branch.

Yeah, I agree. If I put them in different files, would that be problematic?

I'm picturing having a singleton object with the current global check values, and the setter would loop over the incoming options and assign.  (Could even do Object.assign(globalOptions, incomingOptions) if we aren't worried about someone passing in {stability: undefined}, I guess.)

the "should run" check explicitly checks against "always" and "once" so any other values will just function the same as "never", which i think is okay

@markerikson I think I get it, so it would look something like this:
export type DevModeChecks = Record<
  'inputStability' | 'identityFunction',
  DevModeCheckFrequency
>

const globalChecks: DevModeChecks = {
  inputStability: 'once',
  identityFunction: 'once'
}

export const setGlobalChecks = (devModeChecks: Partial<DevModeChecks>) => {
  Object.assign(globalChecks, devModeChecks)
}

then inside createSelectorCreator:
    const {
      memoize,
      memoizeOptions = [],
      argsMemoize = defaultMemoize,
      argsMemoizeOptions = [],
      inputStabilityCheck = globalChecks.inputStability,
      identityFunctionCheck = globalChecks.identityFunction
    } = combinedOptions

@markerikson I'm not too sure about the message warning message in the console, do you think we can improve on it, or leave it as is?


polish release notes

[x] I agree to follow the project's code of conduct.
[- ] I added an entry to rstar/CHANGELOG.md if knowledge of this change could be valuable to users.

Stick with format of previous release notes, and follow the Fixed/Added/Changed categorization like outlined in https://keepachangelog.com

Bors r+


Documentation not available

The link to the documentation doesn't work:  "You don't have permission to access /~elwong/p/snoptMatlab.pdf on this server."

I think the correct link is: snopt matlab documentation


New Testimonial for Eddie Jaoude

Name
eddiejaoude
Title
God Of Github
Description
His videos and his guided path to becoming an open source pro are amazing. His is really a Messiah of all needy guys.

Wow thank you 🎉


Provide linting for standards used in the CLI for creating commands.

Feature or problem description

Lint for fields that should be present
Lint for the configuration patterns for commands etc.

Linter is already being build in aerogear community. We can create PR to show value of the linter and detect some possible problems.

Done by @ankithans


installation fails on linux

when unpacking the deb folder of pandoc in the temp file, the following error occurs:
subprocess.CalledProcessError: Command '['tar', 'xzf', 'data.tar.gz']' returned non-zero exit status 2.
the newest pandoc file unpacks to a file data.tar.xz and "data.tar.gz" does not exist anymore.
When i change line 86 in "pandoc_download.py" from
cmd = ["tar", "xzf", "data.tar.gz"]
to
cmd = ["tar", "xJf", "data.tar.xz"]
it works.

I see that the master branch has fixed the issue in commit 1515c60faf397248120507ee3519aa5fb4d1ea27. Is it possible to make a new release and upload it to PyPi? The latest release is almost 3 years old already.

Would be great with a pypi release :) We're also affected by this issue.

Fix has been merged.
Will tag a release when windows works again -> looks good so far...


Improve Application Builder Image Experience

Currently we allow the user to either use the default paketo builder image or supply their own free text
How can we improve this experience?

Allow the user to manage these as a top level resource
User can select from this list and be shown what languages they support
builder image resource is shown on app details page

I think that we should at least list the list of the available builders (with buildpacks): https://paketo.io/docs/reference/builders-reference/#available-paketo-builders
And we should add a small description that wil be shown to the user when the corresponding builder is selected: https://paketo.io/docs/concepts/stacks/
I would add a select with the six available builders

paketobuildpacks/builder:full
paketobuildpacks/builder:base
paketobuildpacks/builder:tiny
paketobuildpacks/builder-jammy-full
paketobuildpacks/builder-jammy-base
paketobuildpacks/builder-jammy-tiny

something like this:

Not sure how to integrate the custom free-text. The simplest thing would be to still have the other input with the free text, but it will be cool to have an editable select box.

@scures Lets go with free text and the six listed in https://github.com/epinio/ui/issues/65#issuecomment-1440096844. Will leave it up to you on to decide on how the user browses and selects one. Best would be cards (like Workloads list --> Create) but that would need a new step (for both create and edit app wizards). Neatest way is in a select, but the browse experience suffers.

Until https://github.com/epinio/epinio/issues/2153 is fixed we should not include jammy builders


fix: if audio tag has init source it will be setUp in flash_audio mode initialization

Coverage remained the same at 60.982% when pulling 855aad8bf0f55fef3f748ee84190193b1c50e3e0 on astr0junk:master into 932132e97b0c7e101a59801b78e9ffe30ad1d77f on johndyer:master.

hi, @ron666, will you look up PR today?

Yeah I'll check it later

I would like to get a better context of this fix since it involves a new Flash var

In current version mediaelement on flash_audio mode not setup media source from src attribute or  tag. This problem U can see on demo page.
If i not mistake in old flash version of MediaElement src was passed by flashVars too. So, i recover this functionality.

So is this something that could be applied not just to audio, but also to video Flash shims?

@ron666 I don't read video flash code yet. But I think it can be common for both shims. It's typical workaround for flash

PR merged. Just added a conditional missing in the audio file that should always be there. Other than that, good job. I appreciate your help with the shims


Remove explicit tag from EncryptedContent

@omorsi was this fix was submitted to mozilla? be nice to get it merged upstream so we don't have to fork/replace.

Hi Jesse!
The same fix was proposed on Jun 19, 2020 in this PR.


typings.d.ts is not working as described in readme

I tried to add a global typings.d.ts exactly as described in readme but TypeScript compiler says Cannot find module 'typeless-package'.
Maybe the description is outdated?
Do I have to add it manually to tsconfig.json? If so i get the same error:
"typeRoots": [       "../node_modules/@types",       "./typings.d.ts"     ]

Well, you shouldn't actually add in typeless-package but rather your package name. What package are you trying to make work?

A third party library which doesnt have any typings. I tried the example just to make it work first. Could you give a working example please? Is the typings.d.ts automatically added? If so, the import as from is not working as stated in the readme.

I can give you a working example if you tell me the package name... but if you can't do that, then just replace typeless-package by the package name.

Im not sure if module is up to date in typescript? Didnt it got replaced by namespace?
I tried:
export declare namespace TypelessPackage {
export function test():boolean;
}
Then:
import {TypelessPackage} from "../../typings";
TypelessPackage.test();
But it says Module not found: Error: Can't resolve '../../typings' in '/Users/mick/Documents/git/signposserver2011/Pos.SignPos.POSident/src/app/shared'

A more simple example which doesnt work would be:
src/typings.d.ts
export declare let foo: number;

some.component.ts
import * from "../../typings";
console.log(foo);

Let's assume your package is called mickl-package. You're installing via npm install mickl-package or maybe even locally via npm install ../../../mickl-package.
Following the instructions then gets you the following:
// typings.d.ts
declare module 'mickl-package';

The package has an exported function called test. You can use it by doing the following:
// main.ts
// I'm calling it micklPackage but it can be whatever name you want
import * as micklPackage from 'mickl-package';
micklPackage .test();

This should be all you need. If you're trying to do something more complicated and trying to use other declaration features, then you'll need to check out https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html instead.
These instructions on our README are meant as a guide to get installed packages working, not as a guide for writing declaration files in general.

 I have a single js-file which is not installed by npm. And i just wanted to write a declaration file for it so i can use its functions without ts-errors.
Not sure how to do it, but the part of the readme doesnt seem to be what i needed.

I think you can probably do with using one of these templates: https://www.typescriptlang.org/docs/handbook/declaration-files/templates.html
Which one depends on the kind of library your file represents: https://www.typescriptlang.org/docs/handbook/declaration-files/library-structures.html

@MickL I added
"typeRoots": [ "../node_modules/@types", "./typings.d.ts" ]

to tsconfig.json
and in typings.d.ts I added
export = "module-name";
export as namespace "module-name";
declare var "module-name";

and it worked fine

@osadan
When I add typings.d.ts to the typeRoots config I get:
ERROR in E:/Dropbox/angular2-cli/src/typings.d.ts (14,2): Statements are not allowed in ambient contexts.


[SR-13013] swift-format complains of missing punctuation when adding doc comments via the Xcode template

Previous ID
SR-13013

Radar
None

Original Reporter
leisurehound (JIRA User)

Type
Bug

Attachment: Download

Additional Detail from JIRA

Votes
0

Component/s
swift-format

Labels
Bug

Assignee
None

Priority
Medium

md5:<PHONE_NUMBER>005fed6b61e5fdf05425c6

Issue Description:
When adding doc comments to a method via the Xcode shortcut, the template added is:
/// Description
/// - Parameters:
///   - param: param description

However, when entering the description and parameter description keeping the newlines as the template provides, swift format will complain about punctuation at the end of the entire doc comments, and not just the description, even if the description has punctuation.
Parameters descriptions otherwise do not seem to require punctuation.
Adding a new line between Description & - Parameters (and sometimes adding two and the deleting one is required) the swift-format punctuation concerns are alleviated.

Tracked in Apple’s issue tracker as rdar://126948260


rewrite jolt engine debug renderer for cross-platform

I found the debug renderer is used from jolt engine only support DX11. I think it is better to rewrite by using Vulkan to support debug in macos.

Yes, it is better to implement the jolt renderer with the engine's rendering system. It's on our roadmap.

Dumb question is there an interface for doing this at the moment?


#633 - add non-regression unit test

I'm not sure how to fix this as the bug comes from the use of line comments inside a method call, but I'am afraid this will clash with your test framework doing special treatments with required line comments starting with "// BUG".
I hope it will help you to fix #633.

I think the new tests cover my use case. Thanks for fixing the bug.


The number of subsets changes every time I run GGCAT with the same input using multithreading

Hi!
I am obtaining strange behaviors while using multithreading regarding the number of color subsets.
The dataset is composed of 2312 virus genomes (see attached file list).
You can find here the output of 10 executions of the following command: ggcat build -j 16 --kmer-length 21 --min-multiplicity 1 -l virus.txt -c --output-file colored-graph-k21 -e
When I check for the number of color subsets, I obtain:
$ grep subsets script-output.log
Total color subsets: 268729
Total color subsets: 268726
Total color subsets: 268727
Total color subsets: 268738
Total color subsets: 268736
Total color subsets: 268734
Total color subsets: 268728
Total color subsets: 268730
Total color subsets: 268730
Total color subsets: 268729

but I expect the same number for each execution.
Given that it is fine with a single thread (268713 subsets), it seems that the error comes from some race condition. Can we fix this?
version: ggcat_cmdline 0.1.0
OS: Ubuntu 22.04
Machine: Ryzen™ 9 7940HS , 32GB RAM, 1TB SSD

Same issue as #24, sorry.


Weak Frechet Distance

… cases. Expanded the test_includes.h a bit to allow loading polylines from Ipe strings which makes providing test cases a bit easier. Modified squared_distance_d to also compute distances when the arguments are swapped (i.e. not starting with MovetkPoint).

@aniketmitra001 From the discussion in the DTW pull request, I assume we want the implementation in metric/Distances.h?

@aniketmitra001 From the discussion in the DTW pull request, I assume we want the implementation in metric/Distances.h?

@bacusters  yes if we consider  the Weak Frechet Distance to be a metric , it will be better to put it under metric/Distances.h

@bacusters-tue  are you planning to add examples for this as well?
That will help me in replicating the same in Jupyter notebooks


Blazor LifeCycle picture and SetParametersAsync

Description
The picture suggests that SetParametersAsync is only called during the First render. It actually is called on each re-render.
This leads to some misinforamtion, it is stated more directly as a fact here for example.
Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/components/lifecycle?view=aspnetcore-7.0&source=docs
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/components/lifecycle.md
Document ID
4871f4f7-9cf6-ac7a-0f21-c65d34bd1119
Article author
guardrex

Hello @henk787 ... This type of issue appears a few times a year asking about the accuracy of the diagrams and text, and I've checked multiple times with the product unit engineers. Each time, they say that the diagrams and text are an oversimplification and that this is exactly what they want to show and explain. We added the following to the topic to cover it ...

This article simplifies component lifecycle event processing in order to clarify complex framework logic. You may need to access the ComponentBase reference source to integrate custom event processing with Blazor's lifecycle event processing.

The following simplified diagrams illustrate Razor component lifecycle event processing.


Buddhist year format

https://github.com/Vuepic/vue-datepicker/issues/8#issuecomment-1080606901

@gapgag55 You can pass yearRange and set the range you need

@Jasenkoo hi! i try this answer. but next year(2024) February have 29 day, if pass yearRange like the answer, next year 2024 + 543 = 2567 it is year of (Christian-Era (C.E.)) not (Buddhist-Era (B.E.))  , can i overwrite year select text from 2024 to 2567 for showing user select?

Yes you can, use year-overlay-value slot.

Yes you can, use year-overlay-value slot.

i try to follow your example but it doesn't work. what i do wrong

Im already like this way. thank you so mach!! ♥

Im already by this way. thank you so mach!! ♥

@kitisak053 Nice catch, I'll fix it in the docs.

@Jasenkoo @kitisak053 thank you.

[like]  KITISAK YAMANO reacted to your message:

From: Maprangsoft @.>
Sent: Wednesday, June 28, 2023 4:45:48 AM
To: Vuepic/vue-datepicker @.>
Cc: KITISAK YAMANO @.>; Mention @.>
Subject: Re: [Vuepic/vue-datepicker] Buddhist year format (Issue #247)
@Jasenkoohttps://github.com/Jasenkoo @kitisak053https://github.com/kitisak053 thank you.
—
Reply to this email directly, view it on GitHubhttps://github.com/Vuepic/vue-datepicker/issues/247#issuecomment-1610719420, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOW6O26FWWUBTLY42SLXCJDXNOZHZANCNFSM6AAAAAAUCL2WU4.
You are receiving this because you were mentioned.Message ID: @.***>

I can't make year-overlay-value work, please help. Thanks

year slot work fine.

but, when I click the year , the selectionOverlay is not working as expected.

@vuepic/vue-datepicker version 6.1.0
and https://vue3datepicker.com/slots/overlay/#year doesn't show the year ( Chrome 117 , Ubuntu )

@pantoffski Looks like a misspelled slot name, will fix it in the next release, in the meantime, you can use it as year-overlay-val

thanks a lot


Update documentation based on StateMod review

As I was reviewing the StateMod developer documentation I made changes to the StateCU documentation to be consistent.  These changes need to be published.

I updated the documentation and published to the GCP versioned and latest.  Close this issue.


Question about the example in the README

hi,
I replicated the example from the readme to test it with some custom data and I think there's a mistake in it.
At the end of the example it logs the data from the haystack using i directly:
// render pre-filtered but unordered matches
for (let i = 0; i < idxs.length; i++) {
  console.log(haystack[i]);
}

Shouldn't this use idxs[i] to reference the matches?
for (let i = 0; i < idxs.length; i++) {
  console.log(haystack[idxs[i]]);
}

Thank you!

oops! yep, thanks!


Switch worktree doesn't work when using plugins like oil.

I'f i have neotree or oil open, switch doesn't actually work.
Works perfectly from netrw and all other files.

I would recommend reading about the Hooks feature. You can basically combine all the git-worktree events with different plugins and add custom behaviour.
I also use oil and I wrote a simple on switch hook which checks weither my current buffers path starts with oil:/// (which is the prefix of oil buffers) and opens the new working directory in oil.
It's a quite crappy solution but it works for 99% of my use cases but you could probably improve it for you.
local Hooks = require("git-worktree.hooks")

-- register a new hook on SWITCH event
Hooks.register(Hooks.type.SWITCH, function(path, prev_path)
    -- log a nice switch message
    print(prev_path .. "  ~>  " .. path)
    -- check if current buffer is an oil buffer
    if vim.fn.expand("%"):find("^oil:///") then
        -- switch to new cwd in oil
        require("oil").open(vim.fn.getcwd())
    else
        -- use built in hook for non oil buffers
        Hooks.builtins.update_current_buffer_on_switch(path, prev_path)
    end
end)

That is a nice solution, will look into it. I will close the issue if it works for me.

I would recommend reading about the Hooks feature. You can basically combine all the git-worktree events with different plugins and add custom behaviour. I also use oil and I wrote a simple on switch hook which checks weither my current buffers path starts with oil:/// (which is the prefix of oil buffers) and opens the new working directory in oil. It's a quite crappy solution but it works for 99% of my use cases but you could probably improve it for you.
local Hooks = require("git-worktree.hooks")

-- register a new hook on SWITCH event
Hooks.register(Hooks.type.SWITCH, function(path, prev_path)
    -- log a nice switch message
    print(prev_path .. "  ~>  " .. path)
    -- check if current buffer is an oil buffer
    if vim.fn.expand("%"):find("^oil:///") then
        -- switch to new cwd in oil
        require("oil").open(vim.fn.getcwd())
    else
        -- use built in hook for non oil buffers
        Hooks.builtins.update_current_buffer_on_switch(path, prev_path)
    end
end)

Thanks, i didn't realize that i should of used a hook for this, which makes total sense if you think of it.
Tested it yesterday and today and it has worked with no issue!


chore: added rdkafka to initializedTooLateHeuristic

no issue

the regex never matched
added unit proof test
added missing rdkafka

the regex never matched

There is an integration test at https://github.com/instana/nodejs/tree/main/packages/collector/test/tracing/misc/too_late that has been green so far. What exactly do you mean with "the regex never matched"?

nvm the function is working fine :D Added rdkafka and a unit test. I'd suggest to keep a single case in the integration test (it runs 26s) and rely on the unit test for the rest.

nvm the function is working fine :D Added rdkafka and a unit test. I'd suggest to keep a single case in the integration test (it runs 26s) and rely on the unit test for the rest.

Yes, great idea!

Yes, great idea!

Yeah 👍


chore: release main

:robot: I have created a release beep boop
ui5-cc-spreadsheetimporter: 0.30.0
0.30.0 (2023-12-21)
Features

enable spreadsheet importer for ui5 v2 (#440) (763c2c7)
new config to continue batch processing on errors (#441) (25dda51)
new config to send the spreadsheet row to the backend (#439) (44af189)
use events with async attached function s(#435) (2c95615)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/marianfoo/ui5-cc-spreadsheetimporter/releases/tag/ui5-cc-spreadsheetimporter-v0.30.0 :sunflower:


Improved log messages

Reason for the change:
    - To improve the readability and maintainability of the log.
    - To improve performance.

Impact of the change:
    - The log messages are now more concise and readable.
    - The code is now cleaner.

Testing results:
    The changes were tested and passed.

~/code/k8s-vgpu-scheduler% make all
go build -ldflags '-s -w -X 4pd.io/k8s-vgpu/pkg/version.version=unknown' -o bin/scheduler ./cmd/scheduler
go build -ldflags '-s -w -X 4pd.io/k8s-vgpu/pkg/version.version=unknown' -o bin/vGPUmonitor ./cmd/vGPUmonitor
go build -ldflags '-s -w -X 4pd.io/k8s-vgpu/pkg/version.version=unknown' -o bin/mlu-device-plugin ./cmd/device-plugin/mlu
go build -ldflags '-s -w -X 4pd.io/k8s-vgpu/pkg/version.version=unknown' -o bin/nvidia-device-plugin ./cmd/device-plugin/nvidia

Nice PR, we need to refine logs indeed


Pad setup very slow if there are many input blur bindings

in the function initDrawEvents there is a call to $('input').blur().
Which causes every input to get a "blur" event.
If there are many inputs and the blur event is heavy there this can cause a very long delay until drawing can happen.
This happened to me with a very large angular application, which in ever blur causes a "digest cycle" (a way for angular to test if there are any changes).

In general I think that this should be something that the caller should handle.
What if the user wants to keep the focus on something else when initiating the pad? or doesn't want the "keyboard" to be hidden (which is the reason given in the source code for this action).

Yeah, that makes sense to me.


[AVM Question/Feedback]: tags and releases not in sync

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
There are 6 tags, but only 1 release - is that intended?
I am investigating why the OpenTofu registry is not showing the latest version of this module and wondering if it may be related to missing releases here in GitHub.

We have amended the missing releases and will improve our pipeline. Thanks for this suggestion @chopeen !


ci: migrating to GitHub actions

Description
Migrating to GitHub actions from CircleCI as per https://github.com/hypertrace/hypertrace/issues/144
Checklist:

[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] Any dependent changes have been merged and published in downstream modules

Documentation

https://docs.github.com/en/free-pro-team@latest/actions

@pavolloffay I have made changes as per my understanding. feel free to change this as per requirement.

@pavolloffay I have made changes as per my understanding. feel free to change this as per requirement.


TIFF: clean up alpha channel handling

For 2-channel images where the first channel is intensity and the second is
alpha, TIFF output was neglecting to set the TIFF "EXTRASAMPLES" tag to mark
the alpha channel. In particular, it just didn't consider extrasamples for images
that had fewer than 4 channels.
This was in turn causing the file, when re-input, to not realize that
the second channel was "A" or that there was an alpha channel at all
(since TIFF does not store channel names, we infer it all from the
EXTRASAMPLES tag).
One consequence of this mistake was that a grey-alpha image (say, coming
from OpenEXR or PNG or some other format that allows it) and run through
'maketx' (converting to TIFF if not otherwise specified) would lose this
knowledge, which in turn would affect the ability of the TextureSystem's
"gray_to_rgb" mode, which only applies to certain channel combinations.
Also noticed that for TIFF input, 2-channel images where the second is
alpha were still being named "R","A", but we actually changed the convention
some time ago for a single intensity channel to be named "Y", no "R", since
it's almost certainly representing luminance and not "red" per se.

Looks good to me and solves the problem I saw with Y,A textures and TextureSys.

Thanks, merging.


TSC cannot infer type indirectly

Bug Report
🔎 Search Terms
type inference, type parameter, extends
🕗 Version & Regression Information
Every version. including nightly
⏯ Playground Link
Playground link with relevant code
💻 Code
class A<T> {
  a: T | undefined;
}
type TypeOfA<T extends A<unknown>>  = T extends A<infer TA>?TA|undefined:never;

class C<T extends A<number>> {
  fn(x: TypeOfA<T>) {
    if (x !== undefined) {
      x++; //ERROR: An arithmetic operand must be of type 'any', 'number', 'bigint' or an enum type.
    }
  }
}

🙁 Actual behavior
Cannot infer x a number|undefined.
🙂 Expected behavior
x should be inferred as number|undefined.
Because whatever the T of C<T> is, T is extended from A<number>.
So TypeOfA should always be number|undefined.
Also, TypeOfA<A<number>> is number|undefined.

Counterpoint:
const c = new C<{ a: 812 | 1208 }>();

When you pass a generic type to a conditional type resolving it will be deferred until you have an actual type. See #46155 for more information.

Counterpoint:
const c = new C<{ a: 812 | 1208 }>();

Thanks a lot.
But this is only for ++ operation.
Actually, x is not inferred as number.
See: playground

@MartinJohns

When you pass a generic type to a conditional type resolving it will be deferred until you have an actual type. See #46155 for more information.

Thanks a lot.
I've tried my best to understand it (using my poor English), but still confusing...
The code of this issue is a minified version of my real situation.
In my real situation, the type isn't a "generic type" like number, but a class or interface.
So, could someone give me some more information, or a way to solve it ( To make x a number as expected)?

So, could someone give me some more information, or a way to solve it ( To make x a number as expected)?

Drop the generic type.
class C {
  fn(x: TypeOfA<A<number>>) {
    if (x !== undefined) {
      x++;
    }
  }
}

@MartinJohns
This works, thanks a lot.
I personally think that this is a REAL BUG of typescript.
In this playground, I find it acts differently as parameters and arguments.
Expected:
The same parameter and argument should have the same inferred type.
class A<T> {
  a: T | undefined;
}
type TypeOfA<T extends A<unknown>>  = T extends A<infer TA>?TA|undefined:never;

class C<T extends A<number>> {
  fn(x: TypeOfA<T>) { //-Here, `x` is not `number|undefined`
  // ^?
    if (x !== undefined) {//          ↑
      let a = x+1;        //          |
    }                     //          |
  }                       //          |
}                         //          |
let c = new C();          //          ↓
c.fn(123456); //---------But here, `x` is `number|undefined`
// ^?

I personally think that this is a REAL BUG of typescript.

You may think that, but it's simply not. The issue I linked earlier goes into more details. This is at most a design limitation.

fn(x: TypeOfA) { //-Here, x is not number|undefined

Here the compiler doesn't know what type T is, so resolving the conditional type TypeOfA<T> is deferred. In order to resolve this type it must know what type T is.

let c = new C();
c.fn(123456); //---------But here, x is number|undefined

Writing new C() is the same as writing new C<A<number>>(). Here the compiler knows what the type T is, because it's provided: it's A<number>. So now the compiler can resolve the type TypeOfA<T>, because it is known what T is: TypeOfA<A<number>>.

It boils down to the simple question: Does the compiler know what type T is? It is not enough to know what it extends, but what the type actually is.

I agree with you, and I read #46155 again. That is exactly what I mean.
Thanks for your help, I think I've known why it works like that.
However, there are 3 questions in my mind:

Is there some situations that T which extends A<number> has a whose type isn't number|undefined?
Or, is there some situations that T extends A<"SomeTypeIsNotNumber">?
In a nother word, what is missing since @MartinJohns said "It is not enough to know what it extends"? I have no idea as far as I know
If the answer of Q1 is "No, there isn't", can it be a feature of TypeScript to infer TypeOfA<T> and x.a as number|undefined, or it is a limitation of compiler, or there is something bad happends if ts has this feature? I don't know.
In my project, my error code cannot be solved like the reply. Because that will make code worse. Now, I can only solve it via as operator. Is there some better ways to solved it (if Q2's answer is "this can be a feature", I will wait for it)?

Is there some situations that T which extends A<number> has a whose type isn't number|undefined?
Or, is there some situations that T extends A<"SomeTypeIsNotNumber">?

Fatcerberus already gave you an example. A<123>

Fatcerberus already gave you an example. Here's another: A<123>

Oh, I carelessly forgot this. I didn't use to think Fatcerberus's words this way.
Thank you a lot.


Fixed spelling errors in completion steps

Write-host "✅ If the installation completed without error complete the following checklist:"

@fthorntonai can you fix the conflicts please?

marking WIP

@santhoshb-msft Done. Can you validate that I included the correct line after the spelling error change.
Regards,
FT

As discussed with @fthorntonai, closing this PR. Please raise a new one as needed.


@conda-forge-admin, please add user @brendonwaters

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
@conda-forge-admin, please add user @brendonwaters
Installed packages
conda

Environment info
conda

@conda-forge-admin, please add user @brendonwaters

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @brendonwaters in conda-forge/kim-api-feedstock#15.


chore: feedback produce consume

Removing partition and adding offset in simplfied mode.

One comment I have is maybe when you do not set the partition to consume from we show the partition where it is from.


Add Touch events

This may be slightly more involved than I'd anticipated.
MDN Reference:
https://developer.mozilla.org/en-US/docs/Web/API/Touch_events#Specifications
Spec:
https://www.w3.org/TR/touch-events/#touch-interface

What about pointer events?
MDN doc: https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events
This is a slightly newer API that covers more input methods and unifies mouse and touch events.

Thanks for the tip! I'm generally quite behind the times on the latest browser developments, always good to get some steer. 😄
Also compatibility looks to be fine: https://caniuse.com/pointer

Closing this as it will be superseded by @grzegorz-bielski excellent work adding pointer support.


[move-docs] Revise step 7 and 8

Motivation
Revision of step 7 and 8
Have you read the Contributing Guidelines on pull requests?
Yes

/land


Migrate to Vite 5

Closes #17
This PR migrates from Mix to the latest Vite version.
The following changes were made:

README:

Vite is supported as of Laravel 9, therefor the Bump to 3.4+ (you could also consider bumping to 4+)
PurgeCSS removed and updated build instructions

package.json

Installed Vite and Laravel Vite Plugin
Removed Mix, Cross-env and CSS-Loader (as they were no where used)
Updated dev and build script
Moved a dependency to the dev dependency
Enabled ESM module

Migrate to Vite 5

Deleted mix related stuff and added vite related stuff instead.

I tested it with running it in a fresh statamic application.

Thank you!


Implement ZHA entity classes registry

##Description:
Implement ZHA entity classes registry. Simplifies implementation of ZHA entities handling functionality of different ZCL clusters/channels. Allows breaking one big "universal" entity class into smaller simpler classes.
Refactor ZHA sensor to use the registry.
This is the 1st PR of ZHA initialization/discovery refactoring.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

@dmulcahey it might be easier to review it by commits. The gist of it in the 1st two commits and rest are just a clean up.

I’ll review this in the morning... holiday parties...

on the other hand, what kind of parties are those if you are intending to review this in the morning ❓
jk


onDisconnect dispatch causes uProxy to close connection

The issue is arising from a callback to onInputStreamReady that doesn't have data and so closes the socket (https://github.com/freedomjs/freedom-for-firefox/blob/master/providers/client_socket.js#L46). The last possibly relevant thing I see in the logs right beforehand is:
console.log: uproxy-firefox: Updating global settings to {"description":"","stunServers":
[{"url: ["stun:stun.services.mozilla.com"]},{"urls":["stun:stun.stunprotocol.org"]},
 {"urls":["stun:stun.l.google.com:19302"]},{"urls":["stun:stun1.l.google.com:19302"]},
 {"urls":["stun:stun2.l.google.com:19302"]},{"urls":["stun:stun3.l.google.com:19302"]},
 {"urls":["stun:stun4.l.google.com:19302"]}],"hasSeenSharingEnabledScreen":false,
"hasSeenWelcome":true,"allowNonUnicast":false,"mode":0,"version":1,"statsReportingEnabled":false}

console.log: uproxy-firefox: UI sending Command {"cmd":"emit","type":1015,"data":
{"description":"","stunServers":[{"urls":["stun:stun.services.mozilla.com"]},
{"urls":["stun:stun.stunprotocol.org"]},{"urls":["stun:stun.l.google.com:19302"]},
{"urls":["stun:stun1.l.google.com:19302"]},{"urls":["stun:stun2.l.google.com:19302"]},
{"urls":["stun:stun3.l.google.com:19302"]},
{"urls":["stun:stun4.l.google.com:19302"]}],"hasSeenSharingEnabledScreen":false,
"hasSeenWelcome":true,"allowNonUnicast":false,"mode":0,"version":1,"statsReportingEnabled":false},
"promiseId":0}

I think this error probably was happening pre-0.6.11, it's just now we actually dispatch onDisconnect whenever we think the socket was closed, and so the error makes it as far as uProxy and actually causes it to give up.

The (client) socket is closing normally (NS_BASE_STREAM_CLOSED) apparently for reason of not having any bytes left to read, so it's not an error per se - however with the new logic, any and all socket closes result in dispatching an onDisconnect. The possibilities I can conceive:

The socket shouldn't be closing at all
The socket should be closing but uProxy doesn't expect an onDisconnect dispatch from all socket closes
The socket should be closing and dispatch an onDisconnect but is somehow dispatching it to the "wrong" place (corresponding to a different socket or such)

For now I'm going to assume/investigate more the first possibility, but thoughts are welcome on the latter two. In any case, to reiterate I do believe this socket.close call was happening before, and apparently isn't fatal to the uProxy process, it's just now the onDisconnect causes it to be noticed.

@trevj : Can you sync with @soycode to see what we want here. I would expect all socket closes should result in disconnect events.

Yes, all socket closes should dispatch onDisconnect event.
What I just noticed is that the Firefox provider doesn't pass any argument to the onDisconnect event:
https://github.com/freedomjs/freedom-for-firefox/issues/63
This messes up the SOCKS proxy a little and may be the culprit here, too.

Tracing through from the other direction, the actual uProxy shutdown occurs due to:
[XMPPSocialProvider] E [May 5 11:19:42.502] Received unexpected end event
[XMPPSocialProvider] E [May 5 11:19:42.504] received close event,

This is happening at https://github.com/freedomjs/freedom-social-xmpp/blob/master/src/core/socialprovider.js#L188 which means that the social provider is receiving an end event - presumably sent by uProxy due to uProxy receiving the onDisconnect.

It's not uProxy, but rather freedom-social-xmpp that is receiving the onDisconnect and closing the socket - https://github.com/freedomjs/freedom-social-xmpp/blob/4bc8d3596b350a4de0010b67d377dd183af1b971/lib/tcp.js#L11
So the path seems to be:

the tcp socket gets onInputStreamReady with an empty stream, resulting in NS_BASE_STREAM_CLOSED
the tcp provider dispatches onDisconnect
the social (xmpp) provider receives the onDisconnect and executes onread(-1), actually closing the socket and shutting down the social provider
uProxy sees the lack of the social provider and shuts down

The last three steps all make sense, so the problem still lies in the first step (or before). It's not clear to me why the socket is receiving an event w/empty input stream, or if that should always mean a disconnect (or if there are situations where it doesn't).

The flow I've described in the previous path is the bug as I've reproduced it - there was some discussion earlier in the standup that the bug may be different when logging in with Facebook (perhaps only triggering when proxying actually starts). If anyone has more information about this let me know, for now I will focus on this particular flow.

Right. It seems like this initial error manifests both on the xmpp stream, but also on proxying streams.

So we think this is a fix: https://github.com/freedomjs/freedom-for-firefox/commit/474515de8fab3952ee45a0513ca02ea1a96ba143
Securing a socket in Firefox means making a new socket, and evidently abandoning the old one was resulting in it dispatching onDisconnect. This change fixes that and I'm now able to stay logged in to uProxy. I'm actually still having issues proxying, though:
remote-connection W [May 14 14:23:48.548] Invalid signal:  SIGNAL_FROM_SERVER_PEER

I've tried a few different accounts and directions and am still getting the issue, I think it may be unrelated. If someone wants to work with me to test we can get these changes merged.


Add optional callback to Formbot#onChange

Summary

I ran into a situation where I needed to call onChange for field B that depended on the onChange of field A (see example) below. I have also tried unsuccessfully to use the onChange prop on Formbot
to set a local state that I could then query. Adding this optional callback seemed to be the most straightforward way of doing it but other suggestions are always welcome.
<Formbot>
  {({ values, onChange }) => (
    <Fragment>
      <Field>
        <Select
          value={values.status}
          onChange={value => {
            onChange('status', value);

            // `If we had selected a status and then decided to remove it,
            // values` won't update fast enough to reflect the new state and
            // `values.status` would still be set to the old status
            if (values.status.length === 0) {
              onChange('doctor', '');
            }

            // with a callback
            onChange('status', value, newValues => {
              if (newValues.status.length === 0) {
                // works now!
                onChange('doctor', '');
              }
            });
          }}
        />
      </Field>

      <Field>
        <Select value={values.doctor} onChange={value => onChange('doctor', value)} />
      </Field>
    </Fragment>
  )}
</Formbot>;

@erikshestopal Can you elaborate on the functionality you're trying to produce?

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   71.18%   71.18%
=======================================
  Files          10       10
  Lines         118      118
  Branches       18       18
=======================================
  Hits           84       84
  Misses         25       25
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd962e...b347d1d. Read the comment docs.

Kyle and I discussed this offline but there is a better way of handling this without needing the callback.
🤦♂ 😆 It was a good learning moment.


No pretrained model

Could you please offer the pretained model？

Hello:
Thanks for your interest in our work.
The pre-trained model is already provided. The following commands will automatically download the pre-trained model into the ckpt folder.
sudo apt-get install git-lfs # run this if you have not installed git-lfs
git lfs install
git clone https://github.com/QizhiPei/FABind.git --recursive

Or you can manually download it from https://huggingface.co/QizhiPei/FABind_model/tree/main.

Thanks for your kind reminder, :)


Dropdowns should have a more descriptive placeholder text

Framework/code-stack
Native (HTML, CSS, and JS) / React
Scope
Core application
Description
Dropdowns on the homepage don't have a descriptive enough placeholder text. It would be more user friendly if they contained a descriptive placeholder text.
If you see the screenshot, the placeholders say, "Select..." which I feel is not descriptive enough for the user to understand what the dropdown does.
Screenshots

Additional Context
No response

Hi! I’d like to work on this issue and have an approach in mind for solving it. Let me know if you’d like me to proceed or if there are specific guidelines I should follow.

Hi, I want to work this issue. Can you assign it to me


How to remove the "extensions" filed from the subscription payload

Versions:
"@apollo/client": "^3.11.4",
"@vue/apollo-composable": "^4.2.1",
"@vue/apollo-util": "^4.0.0-beta.6",
"graphql": "^16.9.0",
"graphql-tag": "^2.12.6",
"graphql-ws": "^5.16.0",
"vue": "^3.4.29",
When I implemented the subscription feature,I found that my server doesn't support the ”extensions” field. So is there a way to remove the ”extensions” field from payload?
Below is my code and error
const { result,error,onResult,onError } = useSubscription(gql`subscription {
    subscribe(attNames:["sys/tg_test/2/ampli"],modes:[PERIODIC]){
            full_name
            index
            event
            value {
                name
                value
                timestamp
                data_type
                data_format
            }
            subscription_error
        }
    }`,undefined,()=>({
        enabled: enabled.value,
        debounce: 2000,
    }));

If anyone can help me, I will be very grateful to you.

sry,this is graphql-ws problem


Composer issues with package evandotpro/edp-sub-layout

Composer installation has a problem installing evandotpro/edp-sub-layout
php composer.phar install
Loading composer repositories with package information
Installing dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package evandotpro/edp-sub-layout could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <http://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

The necessary screenshot

Searching for it on Packagist showed me the package is not there. Either it's not yet available or it has been removed in the past.

fixed by adding package to packagist

fixed by adding package to packagist


Error "Variable is not declared (see :help E738)" on function name without g: prefix

function! Hoge()
	" Variable is not declared (see :help E738)
	call Hoge()
endfunction

Thanks, @todesking !
This bug was already fixed on #93, but not released yet.
So the bug will be fixed by the next release v0.3.1.

Now v0.3.1 has been released.
You can upgrade Vint by pip install -U vim-vint.


Install Concrete5: composer install vs archive download

Affected Version of Concrete CMS
9.x
Description
I've tried the 2 install methods and end up with a different structure, specially in terms of where the vendor folder is located.
With the archive download method:
project root folder
-- application
-- concrete
-- packages
-- updates
-- composer.json (pointing the vendor folder to be placed under -- concrete: vendor-dir | "./concrete/vendor")
With composer create-project concrete5/composer new_project:
project root folder
-- public
    ---- application
    ---- concrete
    ---- packages
-- resources
-- vendor
-- src (what is this for, custom classes? should it not be under public/application instead?)
-- composer.json
So is this on purpose or was it missed or is the composer install method not up to date?
I would expect that the 2 install methods produce similar folder structures.
How to reproduce

Download the archive and decompress
composer create-project concrete5/composer new_project
Compare the 2 structures

Possible Solution
No response
Additional Context
No response

Yes, this is on purpose. When installing via composer the vendor/ directory is installed outside the webroot (public/ directory). When installing via the .zip method everything has to be contained within the directory that lives in the webroot.

Yes, this is on purpose. When installing via composer the vendor/ directory is installed outside the webroot (public/ directory). When installing via the .zip method everything has to be contained within the directory that lives in the webroot.

Can you please explain what should go on that /src folder that's on root when installing with composer?
I've tried to add the classes that usually go on application/src but that won't work because the namespace Application\Entity seems to be hardcoded to application/src/Entities, on classes like:

Concrete\Core\Database\EntityManager\Driver\ApplicationDriver
Concrete\Core\Database\EntityManagerConfigFactory

and maybe others.
I can see that there's a ConcreteComposer namespace on the /src folder, but not really sure that that's for.
Can you please clarify?


Create a data-supplier component that wraps a collection of others

Investigate into the possibility of creating a component that takes datasource  (strapi, URL to JSON, URL to CSV)  and populate its children components iteratively with that data.   Without:

touching or modifying the styling of its children
having any major assumption about its childrren  (except perhaps an exported data population method)

Hi @Sing-Li , could you give me an example? I would like to work on this issue.

See this ...
https://github.com/RocketChat/RC4Community/issues/79
Simplified to:
<DataLoader  id="dl1" src="strapi://infotiles">
   <Infotile    title={dl1.data.1.title}    desc={dl1.data.1.desc}  />
   <Infotile    title={dl1.data.2.title}    desc={dl1.data.2.desc}  />
   <Infotile    title={dl1.data.3.title}    desc={dl1.data.3.desc}  />
  <Infotile    title={dl1.data.4.title}    desc={dl1.data.4.desc}  />
 </DataLoader>

Hope you get the idea.


UITextView contained in IGListSectionController

class DemoItem {

}
class DemoCell: UICollectionViewCell {
    lazy var textView: UITextView = {
        let newTextView = UITextView()
        newTextView.textContainerInset = UIEdgeInsetsZero
        newTextView.textAlignment = .Center
        newTextView.font = UIFont.systemFontOfSize(20)
//        newTextView.userInteractionEnabled = false
        newTextView.backgroundColor = UIColor.clearColor()
        newTextView.scrollEnabled = false
        self.contentView.addSubview(newTextView)
        return newTextView
    }()

    override func layoutSubviews() {
        super.layoutSubviews()
        textView.frame = bounds
        textView.text = "Demo Text"
    }
}
class DemoSectionController: IGListSectionController, IGListSectionType {
    var item: DemoItem
    init(item: DemoItem) {
        self.item = item
    }
    func numberOfItems() -> Int {
        return 1
    }

    func sizeForItemAtIndex(index: Int) -> CGSize {
        let width = (collectionContext?.containerSize.width ?? 200)
        return CGSize(width: width, height: 50)
    }

    func cellForItemAtIndex(index: Int) -> UICollectionViewCell {

        let cell = collectionContext?.dequeueReusableCellOfClass(DemoCell.self,
                                                                 forSectionController: self,
                                                                 atIndex: index) as? DemoCell
            ?? DemoCell()
        cell.backgroundColor = UIColor.redColor()
        return cell
    }

    func didUpdateToObject(object: AnyObject) {
        self.item = object as? DemoItem ?? DemoItem()
    }

    func didSelectItemAtIndex(index: Int) {
        print("Selected item at index = \(index)")
    }
}

this code shows an UITextView inside an IGListSectionController
uncommenting the following line newTextView.userInteractionEnabled = false fires func didSelectItemAtIndex(index: Int) correctly but doesn't show the keyboard, enabling user interactions shows the keyboard but doesn't notify the section controller of item selection.
Is that an unintended use case, or did I miss something during the setup?

As far as I'm aware that's the base functionality internally, UITextViews will intercept the touch action before it gets to the cell due to its ability to be edited.
By turning userInteractionEnabled to false you're telling the textview to no longer accept touch actions and therefore the cell receives it (triggering the didSelectItemAtIndex)
If you're wanting to detect when a user starts to edit a text view (usually by means of tapping the text view, and keyboard popping up) then you will need to do so using a delegate. Add the protocol UITextViewDelegate to your class, assign it to the textView's delegate property and add one of the delegates functions such as textViewDidBeginEditing.
Apologies if I've misinterpreted your issue!

Thanks @Sherlouk ! 🎉
Also, your SectionController could be the UITextViewDelegate.
@sanboxapps - let us know if this helps 😄

Thanks for the help, the initial intention is to have the sectionController recognize which item (I forgot to mention there could be a multitude of them) was tapped so that when the text changes it knows how to handle the change based on the item. I think 2 possible ways around that would be as @Sherlouk mentioned to rely on the text view'a delegate (in my case by wrapping it in another delegate that contains more info about the item being edited), another approach (which I am not a very big fan of) is to have one item per section controller where the controller is also the delegate

So it depends what information you really need, it's possible to get the index of a UICollectionViewCell by using the collectionContext?.index(for cell: UICollectionViewCell, sectionController: IGListSectionController) -> UInt function.
If you were to have the UITextViewDelegate in the cell it self, which then forwards a message onto the section controller (see our RemoveSectionController for an example of this!) containing the cell then you can use the aforementioned function to receive the index.
From that index you should be able to use your own logic and the object passed to the section controller to handle it which way you seem fit
Does that make sense, @sanboxapps?
Maybe a bit of code to show what you're trying to do if it doesn't!

@sanboxapps are we ok to close this issue? Looks like it's answered.

@rnystrom sure


Add missing appimages

Hello. First time trying app-outlet. Pretty neat idea. I havent found any contact info or IRC/Discord so im opening an issue.
I was wondering where app-outlet was searching for appimages. From what I've read in #70 it seems like the list is hosted on your server, correct? Or does it search from https://appimage.github.io
Anyhow, these appimages could be added:

BeakerBrowser
MuWire
LibreWolf
sc-controller

Hello @danrobi11 . I'm sorry for the delayed response.
We search the apps on https://appimage.github.io/. We maintain a database of applications but only for performance purposes.
3 of the 4 applications are available on AppOutlet.
MuWire is available on https://appimage.github.io/ but does not appear on AppOutlet. This is due there is no Download link provided by the developers.
In order to fix this and the applications start to appear on AppOutlet, please ask the developers to fix this problem with https://appimage.github.io/
Thank you for your support


Setting for changing the keymay/keyboard layout for letter code generation

I noticed that the letter codes seemed to follow an asdfg... pattern similar to home row on the QWERTY keyboard, not everyone uses this, inefficient, layout; both dvorak and colemack are popular; and on mac the dvorak-⌘QWERTY is also possible.
This request similar to #33; but in this case a default for each layout (min QWERTY, and dvorak) would be preferred. Full customization is what #33 seems to be about.
In anycase taking the keymap into consideration when choosing the letter combinations would be very useful, as well as trying to make as many combinations as possible alternate hands so a touch typist can hit one key with each hand in most cases. The other obvious consideration would be how far each key is from home-row; i.e. how far does the finger have to travel to type.

You can check out my fork of the extension to see if you like it.  (You'll have to run it in test mode).
I'll be thankful for any feedback.

@chefables-mark You can use Jump instead, it supports this feature.


feat: allow passing URL as X-Sendfile header value

Reason for This PR
A POC of discussion: https://github.com/orgs/roadrunner-server/discussions/1842
Probably it would be good to abstract if/else block and have some sort of generic struct, but since it's a POC - haven't done it yet
Description of Changes
Allow to pass url as X-Sendfile header value and let roadrunner stream files.
Usage case: backend app generates presigned S3 url and responds with X-Sendfile header, instead of streaming file by itself.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[ ] The reason for this PR is clearly provided (issue no. or explanation).
[ ] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

Hey @rmikalkenas 👋 Thank you for the PR 👍
Might be it would be better to have a separate plugin with RPC bridge to do that? That way, we would be able to handle these links independently and w/o abusing the headers.
Moreover, if someone would be needed to have some different types of uploads, it would be easy to add a new RPC method.

Hey @rmikalkenas 👋 Thank you for the PR 👍 Might be it would be better to have a separate plugin with RPC bridge to do that? That way, we would be able to handle these links independently and w/o abusing the headers. Moreover, if someone would be needed to have some different types of uploads, it would be easy to add a new RPC method.

@rustatian I'm trying to understand how would it work.. Could you elaborate more on your idea?
I agree that maybe separate header and therefore separate plugin could be introduced, but I find it hard to get where the RPC stands in this idea :thinking:

Sure @rmikalkenas 😃
Here you may find a tutorial about how to create a plugin: link.
You may also reach me in our Discord RR channel if you need help 😃
But, I guess since the payload should be streamed as the response... Not sure now. I mean, is that something you currently need to solve some needs using RR at work?

Since we already discussed this functionality, do you @rmikalkenas still need this PR to be opened?


docs: Migrations: How to use EntityManager in migrations?

Why is there no EntityManager available in Migrations?
I want to insert some data in the database and want to use migration instead of seeders, because with migrations I can automate the migration call in CI/CD.  But there are only native methods like nativeDelete and find with string instead of entity name. Whats the reason for this?
If I call this.driver.createEntityManager() and try to use it, it hangs with the error: "knex connection timeout"
For example I have the job to introduce a new project status and then I also need to insert that new data in the database:
async up(): Promise<void> {
    const em = this.driver.createEntityManager(true);
    const projectStatus = new ProjectStatus('reviewNeeded');

    await em.persistAndFlush(projectStatus);
}

async down(): Promise<void> {
    const em = this.driver.createEntityManager(true);
    const projectStatus = await em.findOne(ProjectStatus, 'reviewNeeded');

    await em.removeAndFlush(projectStatus);
}

If I haven't misunderstood seeders, this is a task for migrations because I cannot rollback seeders, right?

You shouldn't be really using EM in your migrations, migrations are meant for schema changes, you can alter the data as well, but those should also use native queries preferably.
The problem you are facing is caused by existing transaction context in the migration scope, that you are ignoring - the EM you create via driver does not know about it. Something like this should fix it:
const em = this.driver.createEntityManager(true);
em.setTransactionContext(this.ctx);

I guess we should have a shortcut in the migration class that is doing this. I haven't added that mainly because of what I said above - this is not really a place where you should be using EM, this will have unnecessary perf penalty, migrations were designed to be mainly about SQL queries.

Hehe I just also found your solution here https://github.com/mikro-orm/mikro-orm/issues/2670#issuecomment-1020463343 right now.
Now it works. Thanks.
But then my question: Why shouldn't you use EntityManager in Migrations and use raw queries instead? In raw queries there can happen type errors, etc. I mean Mikro-orm is an ORM and in ORM you use entities.
Yes a shortcut would be nice: this.getEntityManager() or something like this :)

For schema changes you need raw queries, thats true. But for inserting or removing data in database and easy access to EntityManager would be nice and it should be documented, because now there is something about inserting or removing data in migrations in the docs.

It's just something that feels overcomplicated for a migration, but the bottom line is - use whatever suits the job, especially if you find it more readable and maintainable. It's not like this approach is forbidden or something, but things were not designed with it in mind - the EM factory method on the driver level was added because of something else, and I only realized things can work in migrations because of people finding it first and asking the same question as you did :]
If you want to use it only because of the mapping of field <-> property names, you could use the query builder for that as well, or the em.native* methods like em.nativeUpdate(), as those are basically a query builder shortcuts.
Agreed this should be documented, and we should probably have the EM getter on the migration class to make it easier. It's the same problem as with this.execute() and this.driver.execute(), the former will respect the current context.


Make Undo/Redo system more generic

Instead of sending MakeSnapshot events from everywhere in the app it's better to trigger snapshot when:

Any key is released
Any mouse button is released

Then after a snapshot is made it is compared with previous one to see if anything has changed. If it has, then it would be added as a new snapshot.
This way I can track changes for every interaction that user has with the application.

It's difficult to define "every interaction that user has with the application". Key and mouse button released events are not enough to cover all cases where snapshot should be made (e.g. change to the element made via GUI). Or some clicks and presses may change the element but I wouldn't want it to be treated as a snapshot.
I'm not sure if the undo/redo system should be have that level of autonomy. It's not trivial to check if anything's changed in the Canvas. I would have to implement virtual operator== for all canvas elements.
Making snapshots via events system seems reasonable for now.

Closing this as automating undo/redo snapshot generation would give very unpredictable results in the long run


Obviate the scorecard with more complete code generation

In theory, the scorecard should return 100% for any application built with the operator-sdk. Any code it generates should include everything the scorecard will test for. Reasonable defaults for everything can probably be derived from the CRD. And if not, even "CHANGEME" fields would be better than putting nothing in there.
In other words, give the user something to work with! A score is meaningless and unhelpful, even a little adversarial, especially considering most of the code it's scoring was generated by the operator-sdk itself!
Thanks!

I agree this could be better. I tested out the current master with the default scaffolds:
$ operator-sdk new scorecard-operator
$ cd scorecard-operator/
$ operator-sdk add api --api-version=example.com/v1alpha1 --kind App
$ operator-sdk add controller --api-version=example.com/v1alpha1 --kind App
$ operator-sdk olm-catalog gen-csv --csv-version=0.1.0
$ operator-sdk scorecard --cr-manifest=deploy/crds/example_v1alpha1_app_cr.yaml --csv-path=deploy/olm-catalog/scorecard-operator/0.1.0/scorecard-operator.v0.1.0.clusterserviceversion.yaml
WARN[0000] Could not load config file; using flags
Running for cr: deploy/crds/example_v1alpha1_app_cr.yaml
WARN[0063] Plugin directory not found; skipping plugin tests: stat scorecard: no such file or directory
OLM Tests:
	Spec fields with descriptors: 0/1
	Status fields with descriptors: 0/0
	Provided APIs have validation: 0/1
	Owned CRDs have resources listed: 0/1
	CRs have at least 1 example: 1/1
Basic Tests:
	Status Block Exists: 0/1
	Writing into CRs has an effect: 0/1
	Spec Block Exists: 1/1

Total Score: 30%
SUGGESTION: Add a spec descriptor for size
SUGGESTION: Add CRD validation for spec field `size` in App/v1alpha1
SUGGESTION: Add a 'status' field to your Custom Resource
SUGGESTION: The operator should write into objects to update state. No PUT or POST requests from the operator were recorded by the scorecard.

@AlexNPavel @estroz Are there improvements we could make to our types.go and controller_kind.go scaffolds that would improve the out-of-the-box scores?

#1162 makes it easier to improve the score (adds annotations for types.go files) but there are no fields to add annotations to in new API's, so this won't improve the score out of the box.
We should add more CHANGEME-type notes to scaffolded files. The scorecard depends a lot on how the user has defined their operator, so I doubt the score can be improved much out of the box.

Also, I think #1143 should make the basic tests pass, since it adds the status with a simple "Ready" condition.

As someone working through all this fresh right now, having some CHANGEME notes in the created files would be really helpful.
Example experience:
Notes about changing spec.something leave some potential ambiguity about which spec. Root spec or spec.install.spec or spec.deployments.spec or a spec I don't yet have created. Guess and check works, but I'd be fine skipping that. :-)


Crashes on start

The only other mods I have is sodium and iris which you said should compatible. When using fabric versions ~0.14.15 or newer, the mod fails to recognize fabric and crashes with the error, "CITResewn is missing dependency fabric, install any version of fabric" any older versions creates another crash with a much less explicit crash report.


My Personal Diary

Describe the project you want to add with tech stack
I want to add My Personal Diary Project using HTML, CSS and JS.

Hey  ,I hope this message finds you well. I am writing to express my interest in contributing to an open source project under your guidance and request to be assigned me this project .
I am passionate about open source and believe in its power to foster collaboration, innovation, and social impact. I am confident in my ability to make meaningful contributions to your project. I am excited to work alongside a talented team, learn from experienced contributors, and contribute to the growth of your open source community.


MyHealthClinic

TF200019: The following project already exists on the Azure DevOps Server: MyHealthClinic. You cannot create a new project with the same name as an existing project. Provide a different name.
AB#3951

As the error is showing, the project with the name MyHealthClinic is already present in your selected DevOps Organization.
Please provide a different name and try again.
Thanks


BUG Fix sub-template lookup for includes

Fixes #7383

Added a couple of minor comments, nothing that should block this getting over the line. Happy for this to be merged


Application does not provide a way to use system environment variables, PYTHONPATH, or JUPYTER_PATH

Description

The Jupyter Lab Desktop application is terrific, and a great improvement over command-line launching mechanisms. However, there does not seem to be any way to provide environment variables to the session, including, but not limited to, JUPYTER_PATH.
Expected behavior

The desktop application should pass login shell environment variables to the kernel.
Context

Operating System and version:  macOS 11.6.2
JupyterLab-Desktop version:  3.2.5-2
Installer:  .pkg

No activity here? First thing I noticed when installing Jupyter Lab Desktop in Feb 2023

PS This seems to be because the MacOS application is launched direct from the MacOS UI, so a shell is never invoked to set environment varaibles. This is contrast to regular JupyterLab which is invoked from the command line.
It is not obvious to me what a fix for this would be.

you can now set environment variables with the newest version 3.6.1-2. please install it and check the user guide for instructions.


Use keras_graph when obtaining gradients

See https://github.com/tensorflow/tensorflow/issues/26098.

I'm a little worried about always dropping into graph mode. (I'll respond in more depth in #26098)


Balance and log

What problem does this PR solve?
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update the tidb-ansible repository
Need to be included in the release note

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests tikv=v6.5.0 tidb=v6.5.0 pd=v6.5.0

/run-all-tests tidb=v6.1.0 tikv=v6.1.0 pd=v6.1.0

/run-all-tests

/run-all-tests tidb=v7.1.0 tikv=v7.1.0 pd=v7.1.0

/run-all-tests

/run-all-tests

/run-all-tests


[Task]: Fix issue with save operation failures in Basecake

SubTasks
Right now whenever we do entity save operations in repository, this eventually creates an id if new entity and save in the DB.
Problem is, if any failure like DataIntegrityVoliation happens, id still remains attached to the object which could lead to services believe object is stored and querying with that id will fail.
Eventually, we need to remove this id from entity if save operation fails on certail exceptions.
Detailed thread can be found here: https://theappsmith.slack.com/archives/C06Q3A97USE/p1716905481083899

Fixing it here: https://github.com/appsmithorg/appsmith/pull/33847


[Bug]

Bug Description
绑定域名成功，但是打开网页显示"重定向次数过多"
Steps to Reproduce
1.点击绑定的域名
2.“显示”重定向次数过多"
Expected Behavior
正常访问
Screenshots
No response
Deployment Method

[ ] Docker
[X] Vercel
[ ] Server

Desktop OS
WINDOWS10LTSC
Desktop Browser
EDGE
Desktop Browser Version
124.0.2478.80 (正式版本) (64 位)
Smartphone Device
No response
Smartphone OS
No response
Smartphone Browser
No response
Smartphone Browser Version
No response
Additional Logs
No response

If the dns of your domain is provided by cloudflare, please set the Proxy status to DNS only

把SSL/TLS 加密模式改为完全（严格）就不会出现问题了


feat: add ids key in req

Coverage remained the same at 100.0% when pulling 4fade01d6f1b9b793668b39ea123dfe6ab5b8402 on BlackHole1:feat-add-ids into d138a7b601bcb99fd7df80f7d448e5587df190fa on fastify-userland:main.

Coverage remained the same at 100.0% when pulling 4fade01d6f1b9b793668b39ea123dfe6ab5b8402 on BlackHole1:feat-add-ids into d138a7b601bcb99fd7df80f7d448e5587df190fa on fastify-userland:main.

coverage: 100.0%. remained the same
when pulling 4fade01d6f1b9b793668b39ea123dfe6ab5b8402 on BlackHole1:feat-add-ids
into d138a7b601bcb99fd7df80f7d448e5587df190fa on fastify-userland:main.


Retain meta data set on importer nodes

During the import process, ImporterMeshInstance3D nodes are replaced with MeshInstance3D nodes. This change copies over any meta data that might have been set during the import process, for example, in a GLTFDocumentExtension.
This is a resolution for https://github.com/godotengine/godot-proposals/discussions/6586.

I've updated this pull request to be more thorough with copying over meta data on various imported nodes, not just ImporterMeshInstance3D.

I've updated the pull request to also copy over metadata from ImporterMesh to ArrayMesh. In addition to ImporterMeshInstance3D, ImporterMesh is the other intermediary class used where metadata set in a GLTFDocumentExtension would be lost.
Here's an example use case in a GLTFDocumentExtension that copies over the extras from the gltf json so that it's available in the packed scene in godot:
func _apply_extras_to_meshes(state: GLTFState) -> void:
    for index: int in range(state.meshes.size()):
        var extras: Dictionary = state.json.meshes[index].get("extras", {})
        var mesh: GLTFMesh = state.meshes[index]
        _apply_extras_to_meta(state, mesh.mesh, extras)

This way, custom properties set in blender on the mesh data can be conveyed over to the godot side via gltf.

Looks good and easily digestible so I think it should be safe in 4.3 - Would it be possible to implement the same change in modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp ?
Basically, the GLTFDocumentExtension is the corresponding process for runtime GLTFDocument import, since the editor import pipeline code is not enabled at runtime.
https://github.com/godotengine/godot/blob/master/modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp
It's only in one place, so duplicating the contents of _copy_meta is acceptable in this case.

Looks good and easily digestible so I think it should be safe in 4.3 - Would it be possible to implement the same change in modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp ? Basically, the GLTFDocumentExtension is the corresponding process for runtime GLTFDocument import, since the editor import pipeline code is not enabled at runtime.
https://github.com/godotengine/godot/blob/master/modules/gltf/extensions/gltf_document_extension_convert_importer_mesh.cpp It's only in one place, so duplicating the contents of _copy_meta is acceptable in this case.

Absolutely, I've updated the pull request source branch to reflect this.

Thanks! And congrats for your first merged Godot contribution :tada:

Thanks! And congrats for your first merged Godot contribution 🎉

Wonderful, and thank you!


[docs] Fix scroll issue on expanded live demos

close #35095
This is a follow-up on #34870, fixing this bug:

Open https://mui.com/material-ui/react-tabs/#basic-tabs, e.g. Chrome (I'm using Brave)
Turn the dark mode on

https://user-images.githubusercontent.com/19550456/200823731-69ffddf1-6054-4c9c-82c1-2c015590c448.mov
The solution is to move the style override to the same styled() element so that emotion can inject the styles in the right order in the DOM.
https://deploy-preview-35064--material-ui.netlify.app/material-ui/react-tabs/#basic-tabs

@bharatkashyap How do you reproduce the issue?

@bharatkashyap How do you reproduce the issue?

Trying to scroll in the expanded demos on https://mui.com/material-ui/react-tabs/, for example

@bharatkashyap Ah awesome, I could reproduce, thanks for raising. I have:

updated the PR description to have a clear reproduction
pushed a change that makes the styles injection order deterministic (replace the need for !important).

I'm merging as something is wrong with the GitHub CI action, Bharat won't be able to, I had to use my admin right to override the checks.

FYI this still happening on the live documentation website. Tried the changes on local and seems to be working ok though 👍

@codeinearts we will likely deploy this change tomorrow.


Incorrect href in React learning documentation

https://ko.react.dev/learn/updating-arrays-in-state#making-other-changes-to-an-array
On the above page, the href attribute for '중첩된 JavaScript 객체 업데이트' is incorrect.
It should be corrected to https://ko.react.dev/learn/updating-objects-in-state#updating-a-nested-object.
The translated learning documentation has helped me a lot in my learning.
Thank you.

Hey the Korean translations are being maintained here https://github.com/reactjs/ko.react.dev/issues. I have created a copy for the same. Thanks for raising.

@Illdowhatiwant do you mind closing this copy of the issue, now that it's been moved to the correct repository?
Thanks! 😄


fix: Enabled Circular border around country Selector

What

This PR includes fix of shape changes after the selection of the country is made.

Screenshot

Before Light Mode
After In Light Mode
After In Dark Mode

Fixes bug(s)

#1454

Codecov Report

Merging #1464 (fb3a06b) into develop (721a49b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1464   +/-   ##
=======================================
  Coverage     9.15%   9.15%
=======================================
  Files          158     158
  Lines         6354    6354
=======================================
  Hits           582     582
  Misses        5772    5772

Impacted Files
Coverage Δ

.../smooth_app/lib/pages/onboarding/welcome_page.dart
3.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721a49b...fb3a06b. Read the comment docs.

Hi @M123-dev,
Could Please review it.