ca_cert_dir keyword argument may be passed to HTTPConnectionPool by accident.

Seems like as part of #701 I missed the SSL_KEYWORDS block in poolmanager.py. This means that ca_cert_dir may accidentally be passed to the HTTPConnectionPool.  This leads to the following error when attempting to use ca_cert_dir with a PoolManager and then making a plaintext HTTP connection:
>>> import urllib3
>>> p = urllib3.PoolManager(ca_cert_dir='/usr/local/etc/openssl')
>>> p.urlopen('GET', 'http://http2bin.org/get')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "urllib3/poolmanager.py", line 162, in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
  File "urllib3/connectionpool.py", line 548, in urlopen
    conn = self._get_conn(timeout=pool_timeout)
  File "urllib3/connectionpool.py", line 250, in _get_conn
    return conn or self._new_conn()
  File "urllib3/connectionpool.py", line 211, in _new_conn
    strict=self.strict, **self.conn_kw)
  File "urllib3/connection.py", line 121, in __init__
    _HTTPConnection.__init__(self, *args, **kw)
TypeError: __init__() got an unexpected keyword argument 'ca_cert_dir'

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28626948-ca_cert_dir-keyword-argument-may-be-passed-to-httpconnectionpool-by-accident?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github).

This should also make sure to update the new tests in #751 to include the ca_cert_dir field.

Mmm that is pretty nasty.


feat: devcontainer configuration

This PR adds devcontainer configuration files to the Epic Stack.
You can find a lot more info about devcontainers on the VS Code Docs page about them as well as on the devcontainer specification, but the tl;dr is that this set of configurations allows Epic Stack projects to leverage remote development environments such as GitHub Codespaces, Gitpod, VS Code Remote Containers (machine-local docker container), and a growing list of other supported providers.
This is the underpinning of how GitHub themselves does development on the GitHub web application and it's an incredible value-add, especially for open source repositories because it can lower the barrier to entry significantly for new contributors by getting rid of so many potential stumbling blocks related to environment setup.
For the Epic Stack, the configurations leverage the existing multi-stage docker build setup found in other/Dockerfile so that the development environment provided to developers is nearly identical to that which will run in production (with the minor difference that the devcontainer also adds git and sudo which are utilities not present in the production image.
Test Plan
Spin up your own Codespace in GitHub against this branch, and after a few minutes of bootstrapping (which only happens once at Codespace creation but doesn't happen on subsequent re-starts of the Codespace) you are plopped into the web version of VS Code and everything works just like you were developing locally, except your code will be running on GitHub servers and your dev environment will spin up against real-looking GitHub subdomains instead of "localhost" urls!
Now anybody can code on their Epic Stack application from any device that can run VS Code in the browser (yes, it works on phones)!
Checklist

[ ] Tests updated
[ ] Docs updated

Tests are not really applicable to this change.
Screenshots
Demo in VS Code (running locally with the "remote" environment being a docker container)
https://youtu.be/3R8H_AMZ6PI
Demo in GitHub Codespaces (running in the cloud on GitHub hardware)
https://youtu.be/XP_y0w0wWJk

Thank you.

Thanks for this! I'd welcome an example, but I don't think that I will include this as part of the starter. Would you be interested in converting this to a new PR that makes an example?

No worries, I'll go ahead and close out this PR  - cheers!


NEID & WorldEdit Incompatible

NEID: NotEnoughIDs-1.4.2.jar
WorldEdit: Doesn't matter which one, tested with all of them - latest http://builds.enginehub.org/job/worldedit/last-successful?branch=master
Forge: 1614
If you issue a command that affects a block with an ID greater then 4096 the following happens;
Can't have a block ID above 4095 (xxxx given)
//regen, /replace x y etc doesn't work if within that selection or a block ID is above 4095
Edit: Issue opened also at http://dev.enginehub.org/youtrack/issue/WORLDEDIT-3390

Try this: https://drive.google.com/file/d/0BwY_2FEZWt8dVkJYT1k0S0Z0bVk/view?usp=sharing

Testing it now (I'm UTC+10) I'll edit this comment with results

I am also testing this build. I will let you know if an issue arises.

Its been 24 hours so far and I have tried every single thing in WorldEdit to test this new update that you provided @fewizz .  Not a single issue.
I've done regen, replacing blocks by id and their actual name - everything - and works without a single issue.

Yeah I can confirm this as well; great job on this release. I recommend calling it a stable release.


gato: init at 1.5

Description of changes
GitHub Self-Hosted Runner Enumeration and Attack Tool
https://github.com/praetorian-inc/gato
Related to #81418

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 265520 run on x86_64-linux 1

2 packages built:

gato
gato.dist


🐞[Bug]: Size decrement of Appointment section in index.html  and nav bar text size

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Size decrement of Appointment section in index.html  and nav bar text size.
#894
Expected behavior
Size should be decreased such that to avoid gaps after the footer at right side as shown below

And text size in navbar must be decreased such that UI looks good.
Add ScreenShots

What browsers are you seeing the problem on?
Chrome
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@varshith257 please assign me this issue.

@varshith257 please assign me this issue

@varshith257 please assign me this issue


Something seen in prod can cause horizontal scrolling on mobile

Noticed alongside a code-block bug, but this post is not at fault:

It could be another code block, since nothing else stands out.

The trouble was a very-long link in a post body. This is rare enough (and my own doing) that it's not worth sweating over.


Problem in Eval.py?

Hi, thanks for developing CapsE.
I think that using capsule networks may be the next big thing in Link prediction!
I'm opening this issue because I have the impression that your evaluation strategy, implemented in evalCapsE.py, may suffer from the same controversies emerged in ConvKB under this issue:
https://github.com/daiquocnguyen/ConvKB/issues/5
Am I correct?

This problem is addressed in detail in the following paper:
Z. Sun, S. Vashishth, S. Sanyal, P. Talukdar, Y. Yang, A Re-evaluation of Knowledge Graph Completion Methods, ArXiv:1911.03903 [Cs]. (2019). http://arxiv.org/abs/1911.03903 (accessed November 14, 2019).
If the existence of the mentioned problem is true, then the authors should make this public somewhere (e.g., https://ml-retrospectives.github.io/). I think this is important to advance research in this area.

I have answered this issue at https://github.com/daiquocnguyen/ConvKB/issues/5


Enable showing multiple positions in a same company

I updated the themes to enbale showing multiple positions that I worked in a same company
I also added company alias to show on the tab, and the full company name will be shown in detail section

How do I do that?

Has this been merged into a release version yet?

Has this been merged into a release version yet?

Hi it's not added to release version yet. if you want to do this you can check at my fork repository:
https://github.com/chunghoduc/hugo-profile-customize/tree/features/update-experiences-block


input size

I have such a problem and would like to get any advices:
Here is the model, which I got by seting depth = 10.
nn.Sequential {
[input -> (1) -> (2) -> (3) -> (4) -> (5) -> (6) -> (7) -> (8) -> (9) -> output]
(1): cudnn.SpatialConvolution(3 -> 16, 3x3, 1,1, 1,1)
(2): nn.Sequential {
[input -> (1) -> output]
(1): nn.Sequential {
[input -> (1) -> (2) -> output]
(1): nn.ConcatTable {
input
|-> (1): nn.Sequential {           |      [input -> (1) -> (2) -> (3) -> (4) -> (5) -> (6) -> output]           |      (1): nn.SpatialBatchNormalization           |      (2): cudnn.ReLU           |      (3): cudnn.SpatialConvolution(16 -> 16, 3x3, 1,1, 1,1)           |      (4): nn.SpatialBatchNormalization           |      (5): cudnn.ReLU           |      (6): cudnn.SpatialConvolution(16 -> 16, 3x3, 1,1, 1,1)           |    }           |-> (2): nn.Identity
... -> output
}
(2): nn.CAddTable
}
}
(3): nn.Sequential {
[input -> (1) -> output]
(1): nn.Sequential {
[input -> (1) -> (2) -> (3) -> (4) -> output]
(1): nn.SpatialBatchNormalization
(2): cudnn.ReLU
(3): nn.ConcatTable {
input
|-> (1): nn.Sequential {           |      [input -> (1) -> (2) -> (3) -> (4) -> output]           |      (1): cudnn.SpatialConvolution(16 -> 32, 3x3, 2,2, 1,1)           |      (2): nn.SpatialBatchNormalization           |      (3): cudnn.ReLU           |      (4): cudnn.SpatialConvolution(32 -> 32, 3x3, 1,1, 1,1)           |    }           |-> (2): cudnn.SpatialConvolution(16 -> 32, 1x1, 2,2)
... -> output
}
(4): nn.CAddTable
}
}
(4): nn.Sequential {
[input -> (1) -> output]
(1): nn.Sequential {
[input -> (1) -> (2) -> (3) -> (4) -> output]
(1): nn.SpatialBatchNormalization
(2): cudnn.ReLU
(3): nn.ConcatTable {
input
|-> (1): nn.Sequential {           |      [input -> (1) -> (2) -> (3) -> (4) -> output]           |      (1): cudnn.SpatialConvolution(32 -> 64, 3x3, 2,2, 1,1)           |      (2): nn.SpatialBatchNormalization           |      (3): cudnn.ReLU           |      (4): cudnn.SpatialConvolution(64 -> 64, 3x3, 1,1, 1,1)           |    }           |-> (2): cudnn.SpatialConvolution(32 -> 64, 1x1, 2,2)
... -> output
}
(4): nn.CAddTable
}
}
(5): nn.SpatialBatchNormalization
(6): cudnn.ReLU
(7): cudnn.SpatialAveragePooling(8x8, 1,1)
(8): nn.View(64)
(9): nn.Linear(64 -> 1000)
}
And Network has	9	convolutions.
Then I ran the following line:
  local output = model:forward(input):float()

The input is this size:
input=
1
3
224
224
[torch.LongStorage of size 4]
Now I got such ouput:
output=
2401
1000
[torch.LongStorage of size 2]
I thought it should be 1 * 1000 since the input is just one image, but why 2401 * 1000, any help please?

looks like you're trying to use CIFAR network on ImageNet size images

Thanks, noticed that and "fixed".


feat: enable customizing autoform layout

Description
This changes the default layout of <AutoForm /> from VerticalLayout to FormLayout, this means, if the AutoForm is used without any configurations regarding the layout (e.g. as <AutoForm service={...} model={...} />), it will render the fields using a <FormLayout /> with the default two-column layout and the default responsiveSteps.
Also, this enables two levels of layout customizations via introducing customLayoutRenderer property that can be either of type:
type AutoFormLayoutProps = Readonly<{
  template: FieldColSpan[][] | string[][];
  responsiveSteps?: Array<{ minWidth: string; columns: number }>;
}>;

which helps the developer customizing the underlying FormLayout,
Or
export type AutoFormLayoutRendererProps<M extends AbstractModel> = Readonly<{
  form: UseFormResult<M>;
  children: ReadonlyArray<ReactElement<AutoFormFieldProps>>;
}>;

that enables the developer to provide a function that accepts the form binder instance and the list of already bound fields, to create any custom layout component they desire.
Some examples of how this property can be used:

By defining a template for arranging the fields in the FormLayout, in either of the following shapes:

defining the template as string[][]:
<AutoForm service={service} model={PersonModel}
                customLayoutRenderer={{
                    template: [
                        ['firstName', 'lastName', 'email'],
                        ['city', 'zipCode'],
                     ]
                }}
/>

This creates a FormLayout with 6 columns that renders the fields in two rows accordingly, the first three fields spanning over 2 columns, and the last two spanning over 3 columns.

defining the template as { property: string, colSpan: number }[][]:
<AutoForm service={service} model={PersonModel}
                customLayoutRenderer={{
                    template: [
                        [
                            { property: 'firstName', colSpan: 2 },
                            { property: 'lastName', colSpan: 2 },
                            { property: 'email', colSpan: 2 },
                        ],
                        [
                            { property: 'city', colSpan: 4 },
                            { property: 'zipCode', colSpan: 2 },
                        ]
                    ]
                }}
/>

The above creates a 6 columns FormLayout (due having three fields in the first row of the template, and having two on the second row) that renders the fields in two rows, in which the first row's space is divided equally between those three fields, and in the second row, the city field takes twice the size as zipCode takes.

In addition to the template, it is also possible to configure the responsiveSteps for the form layout to have full control over the FormLayout behaviour:
<AutoForm service={service} model={PersonModel}
                customLayoutRenderer={{
                    template: [
                        [
                            { property: 'firstName', colSpan: 1 },
                            { property: 'lastName', colSpan: 1 },
                            { property: 'email', colSpan: 1 },
                        ],
                        [
                            { property: 'city', colSpan: 2 },
                            { property: 'zipCode', colSpan: 1 },
                        ]
                    ],
                    responsiveSteps: [
                        { minWidth: '0', columns: 1 },
                        { minWidth: '800px', columns: 3 }
                    ]
                }}
/>

The above creates a 3 columns FormLayout when the viewport is wider that 800 pixels, and renders the fields in two rows, in which the first row's space is divided equally between those three fields, and in the second row, the city field takes twice the size as zipCode takes.

By providing a component to introduce any custom layout for the form:

function MyVerticalLayoutRenderer({ children, form }: AutoFormLayoutRendererProps<PersonModel>) {
    return <VerticalLayout>{children}</VerticalLayout>;
}

<AutoForm service={service} model={PersonModel}
                   customLayoutRenderer={MyVerticalLayoutRenderer}
/>

The above replaces the FormLayout with the component returned by the MyVerticalLayoutRenderer which in this example is simply a VerticalLayout. Note that the children are the read-only array of already bound fields to the form and there is no need to bound them here again. The form instance is passed to this function to provide more control to the developer e.g. for defining record level validations, defining custom fields and binding them, and etc.
Fixes #1423
Type of change

[ ] Bugfix
[x] Feature

Checklist

[x] I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
[x] I have added a description following the guideline.
[x] The issue is created in the corresponding repository and I have referenced it.
[x] I have added tests to ensure my change is effective and works as intended.
[x] New and existing tests are passing locally with my change.
[x] I have performed self-review and corrected misspellings.

Additional for Feature type of change

[x] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

For me, this seems to pack two properties into one with customLayoutRenderer supporting both props and renderer use cases. The type definition and the API doc description of such properties is convoluted. Another potentially confusing thing here is that a property named smthRenderer accepts something which is not a renderer.
I would suggest to separate them, so that we have two properties with distinct value shapes / use cases. E. g., layout for the properties, and layoutRenderer for the custom component.

For me, this seems to pack two properties into one with customLayoutRenderer supporting both props and renderer use cases. The type definition and the API doc description of such properties is convoluted. Another potentially confusing thing here is that a property named smthRenderer accepts something which is not a renderer.
I would suggest to separate them, so that we have two properties with distinct value shapes / use cases. E. g., layout for the properties, and layoutRenderer for the custom component.

I'm not completely against having two props, however when I was discussing with @Lodin about it, he suggested to merge them into one so there would be only one prop for customizing how the form is going to be customized. WDYT @Lodin ?

Yes. I believe packing two props is better because we won't need to handle edge cases when two properties are set or not set at the same time. However, I agree that naming is a bit unfortunate here...
Hmm, what about going with a bit unexpected way?
import {constructAutoFormRenderer} from '@hilla/react-crud';

<AutoForm service={service} model={PersonModel}
  customLayoutRenderer={constructAutoFormRenderer({
    template: [
      [
        { property: 'firstName', colSpan: 1 },
        { property: 'lastName', colSpan: 1 },
        { property: 'email', colSpan: 1 },
      ],
      [
        { property: 'city', colSpan: 2 },
        { property: 'zipCode', colSpan: 1 },
      ]
    ],
    responsiveSteps: [
      { minWidth: '0', columns: 1 },
      { minWidth: '800px', columns: 3 }
    ]
  })}
/>

This approach will not only release us from the naming issue but will also allow us to move all the template construction logic to a separate function. What do you think?

Yes. I believe packing two props is better because we won't need to handle edge cases when two properties are set or not set at the same time. However, I agree that naming is a bit unfortunate here...
Hmm, what about going with a bit unexpected way?
import {constructAutoFormRenderer} from '@hilla/react-crud';

<AutoForm service={service} model={PersonModel}
  customLayoutRenderer={constructAutoFormRenderer({
    template: [
      [
        { property: 'firstName', colSpan: 1 },
        { property: 'lastName', colSpan: 1 },
        { property: 'email', colSpan: 1 },
      ],
      [
        { property: 'city', colSpan: 2 },
        { property: 'zipCode', colSpan: 1 },
      ]
    ],
    responsiveSteps: [
      { minWidth: '0', columns: 1 },
      { minWidth: '800px', columns: 3 }
    ]
  })}
/>

This approach will not only release us from the naming issue but will also allow us to move all the template construction logic to a separate function. What do you think?

I like this suggestion, which means that there is only one way of customizing the Auto Form's layout that is through introducing a CustomLayoutRenderer, and for making it easy for the users to use it, we publish a utility called constructAutoFormRenderer that takes in some variants of templates and return the Renderer. WDYT @platosha ?

Generally sounds good, but just one more thing: for me a React thing that receives props and renders something out of them is a component. Is this really a good idea to introduce basically a component in a conceptually different form, or should we just expose <AutoFormLayout/> here?
<AutoForm service={service} model={PersonModel}
  layoutRenderer={(autoForm) => <AutoFormLayout template={...} responsiveSteps={...} {...autoForm} />) } />

or
function CustomAutoFormLayout(props) {
  <AutoFormLayout template={...} responsiveSteps={...} {...autoForm} />;
}

<AutoForm service={service} model={PersonModel} layoutRenderer={CustomAutoFormLayout} />

To clarify: consider my comments as non-blocking here. I think it would be beneficial if we merge this as is, and follow up with the API improvements if needed.

I actually like the second approach:
function CustomAutoFormLayout(props) {
  <AutoFormLayout template={...} responsiveSteps={...} {...props} />;
}

<AutoForm service={service} model={PersonModel} layoutRenderer={CustomAutoFormLayout} />


Phong Shading shaders

Implementation based on http://www.cs.toronto.edu/~jacobson/phong-demo/. Parameters are defined in shaders as they do not match directly to the parameters of the BRDF based on Disney model (Material.h)

Won't do


Tron.TransferTRC20Contract transfer amount overflow

Describe the bug
TRC20 tokens transfer amount is incorrect. Tron.TransferTRC20Contract takes amount as long but it overflows due to 18 decimals.

Tron coin has decimals 6, but TRC20 tokens can have up to 18.
With int64, and 18 decimals, maximum amount is 9.223372036854775808.
Suggestion is to change amount in TransferTRC20Contract and TransferAssetContract to 256-bit ('bytes' type, similar to Eth), but leave to int64 in TransferContract.

Merged.  Only TransferTRC20Contract was modified, TransferAssetContract not.


The bot is not on the inbox server

I have edited the configs so that the inbox server is the same as the main server using the server ID, however, when I go run the bot I keep getting an error saying 'BotError: The bot is not on the inbox server!'
I don't understand how to fix this

Did you save and restart the bot?
If you require more support, it will be best if you visit the support discord server.


openssl: Update Deimos bindings to v2.0.1+1.1.0h

We were using a very outdated bindings of OpenSSL.
Sadly the latest ones don't compile with Vibe.d,
but this is already a step forward.

@omerfirmak : That might be the cause of all our pain and suffering.


Reducing vulnerabilities using snyk tool

Reduced scanned vulnerabilities using snyk tool.
Fixes: upgraded to ubuntu/rolling from ubuntu/20.04

- [ check] [Self-reviewed](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code) the changes for clarity and maintainability
      (variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.

[check] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[check] Each commit is a coherent idea.
[check] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[check] Corner cases, error conditions, and easily imagined bugs.

@hetsonii thanks for the suggestion, but this image is intentionally 20.04 as the oldest Ubuntu release we support for Zulip in production. I think we'll support it for another year or so.
As a side note, in future PRs, I'd appreciate more actual discussion in the commit message of your improvement and less of the scanning tool you used to find the suggestion. Check out the Zulip commit guidelines for more details.


Performance Regression or Improvement: Pytorch image classification on 50k images of size 224 x 224 with resnet 152 with Tesla T4 GPU:mean_load_model_latency_milli_secs

Performance change found in the
test: Pytorch image classification on 50k images of size 224 x 224 with resnet 152 with Tesla T4 GPU for the metric: mean_load_model_latency_milli_secs.
For more information on how to triage the alerts, please look at
Triage performance alert issues section of the README.
timestamp: Wed Mar 15 18:39:24 2023, metric_value:<PHONE_NUMBER>0909091
timestamp: Tue Mar 14 18:20:28 2023, metric_value:<PHONE_NUMBER>7142857
timestamp: Mon Mar 13 18:52:40 2023, metric_value: 124759.4
timestamp: Sun Mar 12 18:17:56 2023, metric_value:<PHONE_NUMBER>7142858
timestamp: Sat Mar 11 18:19:42 2023, metric_value: 136957.125
timestamp: Fri Mar 10 18:21:33 2023, metric_value:<PHONE_NUMBER>857143
timestamp: Thu Mar  9 18:26:05 2023, metric_value:<PHONE_NUMBER>5714287
timestamp: Wed Mar  8 18:25:08 2023, metric_value:<PHONE_NUMBER>5714287
timestamp: Tue Mar  7 18:23:57 2023, metric_value:<PHONE_NUMBER>2857142
timestamp: Tue Mar  7 01:20:20 2023, metric_value:<PHONE_NUMBER>5714287
timestamp: Mon Mar  6 18:24:23 2023, metric_value:<PHONE_NUMBER>172414 <---- Anomaly
timestamp: Sun Mar  5 18:22:04 2023, metric_value:<PHONE_NUMBER>4285713
timestamp: Sat Mar  4 18:18:43 2023, metric_value: 135242.625

.add-labels awaiting triage perf_alert

.add-labels "awaiting triage" "perf-alert"


create github bot

We'll want a bot for things like #3 so users can comment something to the effect of

@nyx merge when green

as @rwjblue pointed out we probably don't need this actually; config + action hooks will be sufficient


Error with the Rviz

Hi, I am getting errors where running ros2 launch unity_slam_example unity_slam_example.py in the terminal.
How can I fix it?
Thank you!

Maybe we have same problem?  And here is my logs when I try to start RViz in docker:
rosdev@0bef63e0e548:~$ ros2 launch unity_slam_example unity_slam_example.py
[INFO] [launch]: All log files can be found below /home/rosdev/.ros/log/2021-12-17-19-34-54-288833-0bef63e0e548-485
[INFO] [launch]: Default logging verbosity is set to INFO
Task exception was never retrieved
future: <Task finished name='Task-2' coro=<LaunchService._process_one_event() done, defined at /opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py:226> exception=InvalidLaunchFileError('py')>
Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 50, in get_package_prefix
    content, package_prefix = get_resource('packages', package_name)
  File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/resources.py", line 48, in get_resource
    raise LookupError(
LookupError: Could not find the resource 'ros_tcp_endpoint' of type 'packages'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_file_utilities.py", line 53, in get_launch_description_from_any_launch_file
    return loader(launch_file_path)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/python_launch_file_utilities.py", line 68, in get_launch_description_from_python_launch_file
    return getattr(launch_file_module, 'generate_launch_description')()
  File "/home/rosdev/colcon_ws/install/unity_slam_example/share/unity_slam_example/unity_slam_example.py", line 16, in generate_launch_description
    os.path.join(get_package_share_directory('ros_tcp_endpoint'), 'launch', 'endpoint.py')
  File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 70, in get_package_share_directory
    return os.path.join(get_package_prefix(package_name), 'share', package_name)
  File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 52, in get_package_prefix
    raise PackageNotFoundError(
ament_index_python.packages.PackageNotFoundError: "package 'ros_tcp_endpoint' not found, searching: ['/home/rosdev/colcon_ws/install/unity_slam_example', '/opt/ros/galactic']"

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 228, in _process_one_event
    await self.__process_event(next_event)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 248, in __process_event
    visit_all_entities_and_collect_futures(entity, self.__context))
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
    futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 38, in visit_all_entities_and_collect_futures
    sub_entities = entity.visit(context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/action.py", line 108, in visit
    return self.execute(context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/actions/include_launch_description.py", line 127, in execute
    launch_description = self.__launch_description_source.get_launch_description(context)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_source.py", line 84, in get_launch_description
    self._get_launch_description(self.__expanded_location)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_description_source.py", line 53, in _get_launch_description
    return get_launch_description_from_any_launch_file(location)
  File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_file_utilities.py", line 56, in get_launch_description_from_any_launch_file
    raise InvalidLaunchFileError(extension, likely_errors=exceptions)
launch.invalid_launch_file_error.InvalidLaunchFileError: Caught exception when trying to load file of format [py]: "package 'ros_tcp_endpoint' not found, searching: ['/home/rosdev/colcon_ws/install/unity_slam_example', '/opt/ros/galactic']"

Yes, I do have exactly the same problem !

From: chengys20 @.>
Sent: Friday, December 17, 2021 11:40 AM
To: Unity-Technologies/Robotics-Nav2-SLAM-Example @.>
Cc: Baldini, Francesca @.>; Author @.>
Subject: Re: [Unity-Technologies/Robotics-Nav2-SLAM-Example] Error with the Rviz (Issue #41)
Maybe we have same problem? And here is my logs when I try to start RViz in docker:
@.***:~$ ros2 launch unity_slam_example unity_slam_example.py
[INFO] [launch]: All log files can be found below /home/rosdev/.ros/log/2021-12-17-19-34-54-288833-0bef63e0e548-485
[INFO] [launch]: Default logging verbosity is set to INFO
Task exception was never retrieved
future: <Task finished name='Task-2' coro=<LaunchService._process_one_event() done, defined at /opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py:226> exception=InvalidLaunchFileError('py')>
Traceback (most recent call last):
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 50, in get_package_prefix
content, package_prefix = get_resource('packages', package_name)
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/resources.py", line 48, in get_resource
raise LookupError(
LookupError: Could not find the resource 'ros_tcp_endpoint' of type 'packages'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_file_utilities.py", line 53, in get_launch_description_from_any_launch_file
return loader(launch_file_path)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/python_launch_file_utilities.py", line 68, in get_launch_description_from_python_launch_file
return getattr(launch_file_module, 'generate_launch_description')()
File "/home/rosdev/colcon_ws/install/unity_slam_example/share/unity_slam_example/unity_slam_example.py", line 16, in generate_launch_description
os.path.join(get_package_share_directory('ros_tcp_endpoint'), 'launch', 'endpoint.py')
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 70, in get_package_share_directory
return os.path.join(get_package_prefix(package_name), 'share', package_name)
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 52, in get_package_prefix
raise PackageNotFoundError(
ament_index_python.packages.PackageNotFoundError: "package 'ros_tcp_endpoint' not found, searching: ['/home/rosdev/colcon_ws/install/unity_slam_example', '/opt/ros/galactic']"
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 228, in _process_one_event
await self.__process_event(next_event)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 248, in __process_event
visit_all_entities_and_collect_futures(entity, self.__context))
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 38, in visit_all_entities_and_collect_futures
sub_entities = entity.visit(context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/action.py", line 108, in visit
return self.execute(context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/actions/include_launch_description.py", line 127, in execute
launch_description = self.__launch_description_source.get_launch_description(context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_source.py", line 84, in get_launch_description
self._get_launch_description(self.__expanded_location)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_description_source.py", line 53, in _get_launch_description
return get_launch_description_from_any_launch_file(location)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_file_utilities.py", line 56, in get_launch_description_from_any_launch_file
raise InvalidLaunchFileError(extension, likely_errors=exceptions)
launch.invalid_launch_file_error.InvalidLaunchFileError: Caught exception when trying to load file of format [py]: "package 'ros_tcp_endpoint' not found, searching: ['/home/rosdev/colcon_ws/install/unity_slam_example', '/opt/ros/galactic']"
—
Reply to this email directly, view it on GitHubhttps://github.com/Unity-Technologies/Robotics-Nav2-SLAM-Example/issues/41#issuecomment-996988431, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOW5A2LA6M2Z6VUTUVAZZDUROG4NANCNFSM5KJPKEHA.
You are receiving this because you authored the thread.Message ID: @.***>

Hi @Baldins, please refer to the Troubleshooting section where you can find your error. You likely did not check out the submodules and need to do a git submodule update --init --recursive and then rebuild the container.

I did that already
On Dec 20, 2021, at 11:47 AM, Devin Miller (Unity) @.***> wrote:

Hi @Baldinshttps://github.com/Baldins, please refer to the Troubleshooting sectionhttps://github.com/Unity-Technologies/Robotics-Nav2-SLAM-Example/blob/main/readmes/run_example.md#Troubleshooting where you can find your error. You likely did not check out the submodules and need to do a git submodule update --init --recursive and then rebuild the container.
—
Reply to this email directly, view it on GitHubhttps://github.com/Unity-Technologies/Robotics-Nav2-SLAM-Example/issues/41#issuecomment-998220689, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOW5A33D5UDMM4CKFWK7GDUR6B4JANCNFSM5KJPKEHA.
You are receiving this because you were mentioned.Message ID: @.***>

Could you double-check that you've completed all the steps listed, and that you don't have any stale containers open?  This error only shows up when the ros_tcp_endpoint package is missing from the colcon ws, which only happens when the package was not checked out locally before the container is built and run. Try navigating into the ros_tcp_endpoint directory to confirm that these files  exist locally before you build.

Yes I did all the steps mentioned there - and I am using the docker.
I followed exactly all the steps as described but still have the same error
On Dec 20, 2021, at 4:00 PM, Devin Miller (Unity) @.***> wrote:

Could you double-check that you've completed all the steps listed, and that you don't have any stale containers open? This error only shows up when the ros_tcp_endpoint package is missing from the colcon ws, which only happens when the package was not checked out locally before the container is built and run. Try navigating into the ros_tcp_endpoint directory to confirm that these files https://github.com/Unity-Technologies/ROS-TCP-Endpoint/tree/09d97b2c95018099e3d2a8d8f1e8b168c895cdc9 exist locally before you build.
—
Reply to this email directly, view it on GitHubhttps://github.com/Unity-Technologies/Robotics-Nav2-SLAM-Example/issues/41#issuecomment-998357575, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFOW5A4XAPU5U3C6WUKC7YDUR67TJANCNFSM5KJPKEHA.
You are receiving this because you were mentioned.Message ID: @.***>

@Baldins, please navigate to your colcon_ws/src/ros_tcp_endpoint directory inside the docker container and confirm that there are files in that directory.

@Baldins, please navigate to your colcon_ws/src/ros_tcp_endpoint directory inside the docker container and confirm that there are files in that directory.

Hi,sorry to bother you,but I encountered with a similar error like this:

as you can see,I was absence of the nav2_bringup package,However,I have checked the ros_tcp_endpoint directory locally and there does have those files：

Besides,I also check it inside the docker container and it still have the files:

So what is the cause of this and how can I fix it, I hope you can give me some advice, I will be very grateful！

@Baldins, please navigate to your colcon_ws/src/ros_tcp_endpoint directory inside the docker container and confirm that there are files in that directory.

Hi,sorry to bother you,but I encountered with a similar error like this:  as you can see,I was absence of the nav2_bringup package,However,I have checked the ros_tcp_endpoint directory locally and there does have those files：  Besides,I also check it inside the docker container and it still have the files:  So what is the cause of this and how can I fix it, I hope you can give me some advice, I will be very grateful！

Same with you. Still looking for a solution.

@Baldins, please navigate to your colcon_ws/src/ros_tcp_endpoint directory inside the docker container and confirm that there are files in that directory.

I have similar error. Yes, the src directory has all the files, the error message seems indidating that it looks file from other directory: colcon_ws/install/unity_slam_example

For me, the package that is not found is 'nav2_bringup'. Any idea? Thanks.

If any one still try to fix, here is more error inside docker:
rosdev@efe8bfc4f7d3:~/colcon_ws$ rosdep install -yrq --from-paths src --ignore-src --rosdistro $ROS_DISTRO
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
unity_slam_example: Cannot locate rosdep definition for [rviz2]
Continuing to install resolvable dependencies...
#All required rosdeps installed successfully

Starting the ROS node and running ros2 launch unity_slam_example unity_slam_example.py does not work.

Hi... I have Same Problems...
I Followed this instructions
https://github.com/Unity-Technologies/Robotics-Nav2-SLAM-Example/tree/main?tab=readme-ov-file
=> I got first problem with git clone, so I set ssh keys on github.
next, i got problem on   docker build -t unity-robotics:nav2-slam-example ./       ..
so i changed docker file, and change user settings..
sudo chmod 666 /var/run/docker.sock
sudo chown root:docker /var/run/docker.sock
and now i have problem in LXTerminal
https://github.com/Unity-Technologies/Robotics-Nav2-SLAM-Example/blob/main/readmes/run_example.md
I Have Ros-TCP-EndPoint folder and scripts...
ros2 launch unity_slam_example unity_slam_example.py
[INFO] [launch]: All log files can be found below /home/rosdev/.ros/log/2024-01-22-14-06-25-127757-64052f25f46c-593
[INFO] [launch]: Default logging verbosity is set to INFO
Task exception was never retrieved
future: <Task finished name='Task-2' coro=<LaunchService._process_one_event() done, defined at /opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py:226> exception=InvalidLaunchFileError('py')>
Traceback (most recent call last):
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 50, in get_package_prefix
content, package_prefix = get_resource('packages', package_name)
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/resources.py", line 48, in get_resource
raise LookupError(
LookupError: Could not find the resource 'nav2_bringup' of type 'packages'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_file_utilities.py", line 53, in get_launch_description_from_any_launch_file
return loader(launch_file_path)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/python_launch_file_utilities.py", line 68, in get_launch_description_from_python_launch_file
return getattr(launch_file_module, 'generate_launch_description')()
File "/home/rosdev/colcon_ws/install/unity_slam_example/share/unity_slam_example/unity_slam_example.py", line 31, in generate_launch_description
os.path.join(get_package_share_directory('nav2_bringup'), 'launch', 'navigation_launch.py')
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 70, in get_package_share_directory
return os.path.join(get_package_prefix(package_name), 'share', package_name)
File "/opt/ros/galactic/lib/python3.8/site-packages/ament_index_python/packages.py", line 52, in get_package_prefix
raise PackageNotFoundError(
ament_index_python.packages.PackageNotFoundError: "package 'nav2_bringup' not found, searching: ['/home/rosdev/colcon_ws/install/unity_slam_example', '/home/rosdev/colcon_ws/install/ros_tcp_endpoint', '/opt/ros/galactic']"
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 228, in _process_one_event
await self.__process_event(next_event)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_service.py", line 248, in __process_event
visit_all_entities_and_collect_futures(entity, self.__context))
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 45, in visit_all_entities_and_collect_futures
futures_to_return += visit_all_entities_and_collect_futures(sub_entity, context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/utilities/visit_all_entities_and_collect_futures_impl.py", line 38, in visit_all_entities_and_collect_futures
sub_entities = entity.visit(context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/action.py", line 108, in visit
return self.execute(context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/actions/include_launch_description.py", line 130, in execute
launch_description = self.__launch_description_source.get_launch_description(context)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_source.py", line 84, in get_launch_description
self._get_launch_description(self.__expanded_location)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_description_source.py", line 53, in _get_launch_description
return get_launch_description_from_any_launch_file(location)
File "/opt/ros/galactic/lib/python3.8/site-packages/launch/launch_description_sources/any_launch_file_utilities.py", line 56, in get_launch_description_from_any_launch_file
raise InvalidLaunchFileError(extension, likely_errors=exceptions)
launch.invalid_launch_file_error.InvalidLaunchFileError: Caught exception when trying to load file of format [py]: "package 'nav2_bringup' not found, searching: ['/home/rosdev/colcon_ws/install/unity_slam_example', '/home/rosdev/colcon_ws/install/ros_tcp_endpoint', '/opt/ros/galactic']"


Removed the extra_args and the savings plans

@athiruma, Can you please add description for this PR ?
What the purpose of removing the saving plan ?


[Desktop Bug] Update for Obsidian 1.6.0

The update altered the base Obsidian interface which introduced some relatively minor theme bugs.

Mobile was also hit, so that will have to be updated


Add docker stats to debug in orchest-ctl

Describe the solution you'd like
It would be nice to have the docker stats in the orchest debug output.
What does your solution aim to solve?
Find out container resource consumption problems.

It is unlikely we will be adding this before the #82 is implemented, after which it is no longer applicable.


[BUG] ? openclibboard failed (0x800401D0 (LCIPBRD_E_CANR_OPEN))

Describe the bug
Pressing any copy button gives me openclibboard failed (0x800401D0 (LCIPBRD_E_CANR_OPEN)) and closes/crashes the app
Version:
v1.3
To Reproduce
Open the app, and press any copy button.
Expected behavior
Copy button should copy text to the clipboard and not crash/close the application
Source Image
Q: Does the error occur on a specific image?
A: No, it happens with any image.
Source Image or Screenshots

Additional context
WIndows 11 (Don't be fooled by the taskbar)
DiffusionToolkit.log

I just tried v1.2.1 and it works on there.

Seems to have been caused when switching to Clipboard.SetText() from SetDataObject(), as a measure of allowing the data to stay on the clipboard after the application exits. Looks like there's a way to do that with SetDataObject(data, true), so I'll revert to that method.

This should be fixed in the latest release


fix: work around LLVM miscompilation

updates our rocksdb dep to work around the llvm 18 miscompilation
https://github.com/Syndica/rocksdb/commit/3793e721c7795b338d9d7808544b75db6bde3548

I added some comments on the commit page you shared.


Relay.QL is cached somewhere hidden possibly by react-native packager.

Also created an issue on relay repo since I am not sure if this is a relay or react-native problem: https://github.com/facebook/relay/issues/1028
I am currently using relay together with react-native.
I have found that whenever I make a change to GraphQL schema, there is a hidden cache somewhere that needs to be manually invalidated for the Relay.QL defined for Relay containers.
I have tried these steps to clear cache:

rm -rf ios/build
"Reset contents and settings" on iOS Simulator
Quit all react-native packager processes
rm -rf $TMPDIR/react-*

These are not enough and still causes invalid relay query error.
I think that I would have to make some changes to all Relay.QL fragments that require change while running react-native packager to invalidate the hidden caches.
I wish there is a easy way to clear all caches and start from scratch.
I am not sure if this is relay or react-native problem.

I have seen this issue. I usually find myself doing rm -rf $TMPDIR/react-* which invalidates the cache but def. not an ideal solution.
cc @skevy thoughts?

Doing rm -rf $TMPDIR/react-* did not work for me :(

Run the packager with --reset-cached.

Yah, FWIW, rm -rf $TMPDIR/react-* doesn't do anything. As far as I'm aware, the packager doesn't store anything useful there anymore. --reset-cache is what you want.

Will try!

@skevy wow! i always did rm -rf $TMPDIR/react-*with --reset-cache. Never realised rm was not doing anything!

I confirm that running react-native start --reset-cache indeed solves this problem!
Thank you all!


Updated the mercury APIs and standards

Why are we updating this out of cycle?

I was unaware this was on a cycle, this will get done prior to release anyway, why would this be an issue?
I’d updated my other branch and pulled these in to that, so figured rather than reverting I’d get this branch in ahead as it’d need to go in sometime anyway.
I can revert and close this if that’s preferable, but would like to understand why this adds complexity.

Its just often we check to see if there are APIs updated by running update APIs in the go no go.  Definitely not an issue to do it out of cycle.  But we need to make sure that we are aware of those changes and include them in the list of changes.  This really isn't a problem I don't think.  Just no one has done it before.


[release/1.2] fix pipe in broken may cause shim lock forever

backport of https://github.com/containerd/containerd/pull/2807 for the 1.2 branch
relates to https://github.com/moby/moby/issues/38064
git checkout -b 1.2_backport_shimlockwhenstdinclose upstream/release/1.2
git cherry-pick -s -S -x b3438f7a6f63849d2179a2a76b804aea460affd9
git cherry-pick -s -S -x e76a8879eb10594113d70556c80dd2e456202e22
git push -u origin

cherry-pick was clean; no conflicts

LGTM

LGTM


kvdb: remove etcd test fixture cleanup calls

Remove the cleanup calls which no longer exist since t.Cleanup is now called from within NewEtcdTestFixture.
Accidentally had this in the second sqlite PR instead of in the first kvdb one 🙈 my bad

Changes look good to me. Though to avoid needing to merge and then tag another version, should we include the etcd version bump (see https://github.com/lightningnetwork/lnd/pull/7280) here as well?

good catch! adding

good catch! adding

Oops, looks like Joost was faster: https://github.com/lightningnetwork/lnd/pull/7353

Seems like the build fails though?

Yes, unfortunately that will only be fixed once we bump the version of kvdb in the root go.mod file. I think the coverage tool doesn't understand go modules correctly.


Support for lobbies.

Guys, please test this out a bit.

@Jaakko-H  @armaanrustami lobbies are operational, test them, please.


CASMINST-4669 document generic rerun strategy for upgrade failures

Summary and Scope
document generic rerun strategy for upgrade failures
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves CASMINST-4669

Testing
List the environments in which these changes were tested.
Tested on:

<development system>
Local development environment
Virtual Shasta

Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
Were continuous integration tests run? If not, why?
Was upgrade tested? If not, why?
Was downgrade tested? If not, why?
Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

This also needs a main branch PR

no, we want to handle this error in 1.3 and not asking installer to "rerun would fix it"

/backport main


Add detection of statically linked python executable

Reference Issue
This is a major change to #1800

What does this implement/fix? Explain your changes.
Detects python linkage and sets up the rdkit linkage appropriately
Any other comments?
cmake should really do this...
Boost dependencies used during testing on osx
requirements:
  build:
    - cmake
    - requests
    - boost 1.65.*
    - py-boost 1.65.*
    - libcxx
    - python
    - numpy {{ '%s.*' % (environ.get('NPY_VER') or '1.11') }}
    - pillow
    - freetype
    - cairo [linux]
    - cairocffi [linux]
    - pandas
  run:
    - boost 1.65.*
    - py-boost 1.65.*
    - libcxx
    - python
    - numpy {{ '%s.*' % (environ.get('NPY_VER') or '1.11') }}
    - cairo [linux]
    - cairocffi [linux]

This was closed on #1808


[StrawberryShake] dotnet 3.1.5  It was not possible to find any compatible framework version

Describe the bug
With StrawberryShake 11.0.0-preview.99 I am unable to generate the models. Upon running dotnet build I was not able to use StrawberryShake since it expected dotnet runtime 2.1
To Reproduce
With a dotnet core class library on dotnet 3.1.5 try and follow https://chillicream.com/blog/2019/11/25/strawberry-shake_2
Expected behavior
I expected to be able to use StrawberryShake with dotnet 3.1.
Desktop (please complete the following information):

OS: Windows 10 Enterprise 1809
Version: 11.0.0-preview.99

Additional context
$ dotnet build

Microsoft (R) Build Engine version 16.6.0+5ff7b0c9e for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  dotnet "${USERHOME}\nuget\packages\strawberryshake\11.0.0-preview.99\build\..\tools\dotnet-graphql.dll" generate -p "${USERHOME}\source\repos\solution\project" -s -l 7.3 -d -n project
  It was not possible to find any compatible framework version
  The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
    - The following frameworks were found:
        3.1.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

  You can resolve the problem by installing the specified framework and/or SDK.

  The specified framework can be found at:
    - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=2.1.0&arch=x64&rid=win10-x64
  HyperAutomation.Library -> ${USERHOME}\source\repos\solution\project\bin\Debug\netcoreapp3.1\project.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.00

At the moment we are using .net core 2.1 for the tooling. But with the next update, we will also have a .net core 3.1 variant.


reactivity: IIFEs should not warn if they are executed in a tracked scope

Describe the bug
The following examples cause reactivity to warn with the message "This function should be passed to a tracked scope (like createEffect) or an event handler because it contains reactivity."
createEffect(() => {
  (() => count())();
});

<div>{(() => count())()}</div>

It is occasionally useful to place IIFEs in JSX if one does not wish to place the function into a variable for some reason. To be clear, while not executing the function is possible, it is undesired as they are compiled differently in certain situtations e.g. passing multiple children to a component or fragment), (() => count())() turns into memo(() => count()) whereas () => count() turns into () => count(), and () => count() is a function, whereas (() => count())() is resolved to a getter when passed as the only child of a component.
Expected behavior
As the functions are immediately executed within a tracked scope there should be no warning.

Hi, thanks for the issue. I made a commit to solve this and added your examples as test cases, but I'm going to see if I can address one or both of your other issues soon before publishing a new package. I'll let you know when the fixed version is published to npm.

This is fixed in v0.4.7!


[lexical-table] Bug Fix: cannot delete content when a table inside selection

$deleteCellHandler blocks content removing.
Steps To Reproduce
Test Case #1:

Open playground
Type any text
Insert a 5x5 table
Select all
Press 'Backspace' or 'Delete'

Text cannot be removed.
Test Case #2

Open playground
Insert a sample image
Insert a 5x5 table
Select a sample image
Press 'Backspace' or 'Delete'

A sample image cannot be removed.

@placeba Your newly added test is failing, otherwise looks good. Please fix your test case and happy to merge.

@ivailop7 $deleteCellHandler removes a table in a selection and then tries to select next node (nextNode.selectStart()).
The test fails because Firefox cannot handle with a new selection.
I can suggest removing these lines:
  if (nextNode) {
	nextNode.selectStart();
  } else {
	parentNode.selectStart();
  }

This fix is actually a bit more involved. Your solution breaks deletion for a few patterns, if you have text and table is the very last node, the editor crashes. If you have the table in the middle of the text, Ctrl + A, delete, it doesn't delete all the text outside of the table. If table is the first node and followed by text, Ctrl +A, delete also doesn't delete cleanly.

@serey-roth this regression was introduced wuth https://github.com/facebook/lexical/pull/6274, any suggestions for fixing this one?

@ivailop7 Removing the node selection after deleting, as @placeba suggested, will fix those three regressions.

@ivailop7 Removing the node selection after deleting, as @placeba suggested, will fix those three regressions.

@serey-roth this regression was introduced with #6274, any suggestions for fixing this one?

@ivailop7 Removing the node selection after deleting, as @placeba suggested, will fix these regressions.

@serey-roth this regression was introduced with #6274, any suggestions for fixing this one?

@ivailop7 Removing the node selection after deleting, as @placeba suggested, should do it.

@serey-roth this regression was introduced with #6274, any suggestions for fixing this one?

@ivailop7 Removing the node selection after deleting, as @placeba suggested, should do it.

Raised https://github.com/facebook/lexical/pull/6471

@placeba can you incorporate the changes from https://github.com/facebook/lexical/pull/6471 and then I'll merge your original PR.


Error: cannot find module 'xcode' with version 2.0.2

While adding plugin to Cordova project:
Error: Cannot find module 'xcode'
Not sure what we're doing wrong?

What fixed it for me was to go into the plugin folder and run npm install. Then I tried building again. Worked.


openpilot failure after overtemp startup

Describe the bug
Had openpilot freak out on me earlier today. Don't know if the overtemp factor is causative or merely correlated.

Started up in a hot environment, offroad danger zone, device stayed offroad as expected
After a short time driving, device went onroad but almost immediately into the onroad red zone (undesirable but expected)
After an additional short time of driving, the UI behaved unexpectedly:

Behavior like a UI crash, saw the comma logo alone for about a minute
UI started up, but very slowly/poor responsiveness?
UI reported the offroad danger temp alert, but I think it was a stale alert
UI ran for maybe 15-20 seconds but never went onroad
"crashed" again and repeated this cycle for the remainder of my drive, maybe three times total?

I actually could not terminate this easily without unplugging the C3. Shutting off the car didn't break the cycle, and I didn't quite manage to get the UI to scroll down to the reboot button before it "crashed" again.
Provide a route where the issue occurs
3cfdec54aa035f3f|2023-05-15--14-59-48
openpilot version
717bc04ddc330c43e794f28ee6ff3a287425112e
Additional info
Unmodified master as of a couple days ago. I haven't tried to do much analysis, other than note there aren't any UI crash dumps uploaded. It also looks like both forward cameras stopped encoding (fcam/ecam plus qcams) but dcams kept going.

Unfortunately, your device is one of the few affected by https://github.com/commaai/openpilot/pull/25959. Blocking startup in this case was actually pretty successful in keeping the CPU/GPU <=90C. The PMIC crossed 100C within a few seconds, and I suspect that caused some of these issues, though this should be handled more gracefully.

While not explicitly logged, about 32 seconds into the drive we can infer that emergency thermal mitigation via CPU hotplug took place. Losing a substantial fraction of our compute does explain the behavior.
(openpilot-py3.8) jyoung@DESKTOP-6JPRDTA:~/openpilot/selfdrive/debug$ ./filter_log_message.py "3cfdec54aa035f3f|2023-05-15--14-59-48" | grep affine
[153674.796061] MAIN 0 kernel - IRQ237 no longer affine to CPU5
[153674.796111] MAIN 0 kernel - IRQ238 no longer affine to CPU5
[153674.796161] MAIN 0 kernel - IRQ239 no longer affine to CPU5
[153674.796400] MAIN 0 kernel - IRQ240 no longer affine to CPU5
[153674.799377] MAIN 0 kernel - IRQ241 no longer affine to CPU5
[153674.799485] MAIN 0 kernel - IRQ242 no longer affine to CPU5
[153674.799538] MAIN 0 kernel - IRQ243 no longer affine to CPU5
[153674.799587] MAIN 0 kernel - IRQ244 no longer affine to CPU5
[153674.799635] MAIN 0 kernel - IRQ245 no longer affine to CPU5
[153674.799701] MAIN 0 kernel - IRQ565 no longer affine to CPU5
[153674.799763] MAIN 0 kernel - process 229086 (selfdrive.contr) no longer affine to cpu5
[153674.810485] MAIN 0 kernel - process 229087 (selfdrive.contr) no longer affine to cpu5
[153676.025024] MAIN 0 kernel - process 229031 (camerad) no longer affine to cpu6
[153676.025519] MAIN 0 kernel - process 229109 (RoadCamera) no longer affine to cpu6
[153676.025839] MAIN 0 kernel - process 229039 (camerad) no longer affine to cpu6
[153676.025985] MAIN 0 kernel - process 229110 (WideRoadCamera) no longer affine to cpu6
[153676.026148] MAIN 0 kernel - process 229108 (DriverCamera) no longer affine to cpu6
[153676.026302] MAIN 0 kernel - process 229107 (camerad) no longer affine to cpu6
[153676.096124] MAIN 0 kernel - process 229036 (ZMQbg/IO/0) no longer affine to cpu6
[153676.637263] MAIN 0 kernel - process 229047 (_modeld) no longer affine to cpu7

Unfortunately, your device is one of the few affected by https://github.com/commaai/openpilot/pull/25959.

How many is a few? Rather than spend time on software, does it make sense for me to send this device in for rework?

Yes, I’d still like to handle this specific scenario better.

Thought about it more, and don't think a specific check makes sense. We already check the things that matter (processes lagging, crashing, etc.)


skylarkstruct: implement to_proto

some people approved

Care to elaborate?

we outside of Google can not see any of your internal issues. Referring to them is not the nicest thing to do.

I appreciate that, but unfortunately some of these discussions are initiated by users of Blaze on Google's internal issue tracker, and it would take too much effort to sanitize and re-report every appropriate Blaze issue as an upstream Bazel issue.

This is the first reference I found for to_* deprecation. While I can think of a few reasons why - it is unclear what the actual reasons are. Could you please create a public issue for that topic somewhere.

There is no official plan to remove them AFAICT.  "Deprecation" usually means little more than "this function is best avoided because it is broken by design and/or poorly maintained."
Here are my personal reasons for disliking the to_json and to_proto methods:

Having them be methods of struct creates questions of how to resolve ambiguity in the namespace: what happens if you create a struct with a field named to_proto?
the JSON and proto conversions are poorly specified.  There's no reason why such conversions shouldn't be accessible to Skylark programs, but there's no reason struct, but not list or dict, is specially deserving of such methods.
to_proto creates an undesirable dependency upon the protocol buffer machinery, which is otherwise not a necessary part of a Skylark interpreter.  Defining it an extension avoids that.  (to_json is similar, but a JSON encoder is much easier to write by hand.)

Do you already have a Skylark (still waiting on the rename to happen) implementation for json.dumps?

I don't.  What is json.dumps?
("Summoning"... I like that.)

So focussing on to_proto, is there any pure-Skylark (what about the rebranding?) implementation yet?
If not I would like to take a shot at that (if you would accept the contribution). Using the same limitations (16 levels of depth), it should be feasible.

It would be best to circulate a sketch of the API

Well API is an overstatement. It probably (for starters) would be a free-standing method named to_proto and accept a struct same as now and also write the same output.
On the plus side:

As a drop-in replacement for struct.to_proto we could unify the impl between Java and Go.
More dogfeeding
Be able to clean up struct long term
Nobody is happy with the current struct behavior.

On the negative side:

Limit to what can actually be achieved with the Skylark exposed Python mechanics
Performance (will probably be degraded)


Have a suggestion to turn on/off error DCX messages

I have a suggestion to add a command, for example: /dcx errors on|off to enable/disable echo of DCX errors. I understand maybe is not so rentable, but it helps in most important cases. For example, I need to disable D_ERROR mIRCLinker::eval() (SendMessage() - failed) when a /halt command occurs. I tried somehow to resolve this issue to delete the error line from Status Window or to halt this messages and nothing helps (was added a suggestion in mIRC forum to add /rline,/dline,/aline to work not only for custom windows, but also for status window, channels and query windows.. Khaled not answered yet to this suggestion).
I understand that I can replace all /halt commands with /return etc. but, as I said, I have tons of code :( I want to add the latest dcx.dll to my mIRC Korona script, because it works very good, but I don't want to change all the codes to avoid /halt command.
Thanks.

Can't change how mIRC returns after a /halt


[Feature] Click DAG connection to add label function

Describe the feature
In order to facilitate the user to mark the DAG connection, click the DAG connection to add the label function

Describe the solution you'd like
I will complete this function development

done


chore(deps): upgrade gtk to 0.18

waiting for muda 0.10

muda 0.10 is released, you can proceed with this PR


LSC: navigation bar

I believe this is supposed to be implemented by LSC, but for some reason it doesn't work.
It used to cause null reference exceptions, and they fixed that by checking for null for location I believe. So it could be that the info returned by the language server is incomplete.

LSC is requesting textDocument/documentSymbol but only handling SymbolInformation[] return type, while Python language server returns DocumentSymbol[].
Filed internal bug 984600.

VS has scheduled this work for 16.5

We are now tracking this task in our internal Pylance Azure DevOps.


clarify name - imports vs. imported scopes

not all of the imported scopes are imports (template mixins)
and not all imports import a scope (static/selective imports)

Just wasted more than an hour on this misleading name, only to find out that it doesn't include all imports.

Renaming looks god to me.
Is it a time to add more clarify comment on Dsymbol.importedScope field?

Improved the comment

Looks good!

Auto-merge toggled on


Clean up Android and Linux app.nit libraries

The prefix in linux_data_store and android_data_store is no longer needed.
Importing only dalvik from an Android module makes it compatible with both implementations: the newer nit_activity and the older native_app_glue still used by games.

+1

+1


Compilation errors in xcode after update from 2.0.0 to 2.1.3

Describe the bug
Compilation errors in xcode after webview update from 2.0.0 to 2.1.3
To Reproduce
Steps to reproduce the behavior:

update webview package in any existing project with RPM from version 2.0.0 to 2.1.3
build for iOS platform
xcode project successfully created
try to run on device
compilation errors:

Expected behavior
no compilation errors
Screenshots

Ready Player Me Core version 6.0.0
Ready Player Me WebView version 2.1.3
glTFast version 6.0.1
Unity Editor version 2023.4.2f1
Render Pipeline and version URP 16
Operating System Mac
Platform: iOS

This will be fixed in the next release
https://github.com/readyplayerme/rpm-unity-sdk-webview/pull/37

This should be fixed in the latest release
https://github.com/readyplayerme/rpm-unity-sdk-webview/releases/tag/v2.2.1


Fix. Decode Unsigned Values as Unsigned

Fix some issues in pysnmp
https://github.com/etingof/pysnmp/issues/190
https://github.com/etingof/pysnmp/issues/357
https://github.com/etingof/pysnmp/issues/384
Example for fast test:
from pyasn1.codec.ber import decoder
from pysnmp.hlapi import *

print(decoder.decode(bytes.fromhex('4104985D4B44'), Counter32()))

On the current master, it will fall into a ValueConstraintError:
pyasn1.type.error.ValueConstraintError: <ConstraintsIntersection object, consts <ValueRangeConstraint object, consts 0,<PHONE_NUMBER>>> failed at: ValueConstraintError('<ValueRangeConstraint object, consts 0,<PHONE_NUMBER>> failed at: ValueConstraintError(-1738716348)') at Counter32

And after correction it is correctly decoded:
(<Counter32 value object, tagSet <TagSet object, tags 64:0:1>, subtypeSpec <ConstraintsIntersection object, consts <ValueRangeConstraint object, consts 0,<PHONE_NUMBER>>>, payload [2556250948]>, b'')

The value that you decode in the example - '4104985D4B44': leaving the type(41) and the len(04) aside the highest bit of the actual value (985D4B44) is 1. Doesn't that require to handle it as a 2s-complement? because Snmp uses ASN.1/BER and ASN.1 knows signed integer only? In that case the exception would be correct because the server actually used an incorrect encoding and sent a negative number (that's at least my current understanding, also  https://pysnmp.readthedocs.io/en/latest/faq/ignored-snmp-packets.html).
Based on which RFC or standard do you now change that behavior?
BR, Gerhard.

answer

Since the ecosystem moved away from here, you should send your pull request to https://github.com/pyasn1/pyasn1.


python3Packages.pre-commit-hooks: init at 3.3.0

Motivation for this change
In order to use the pre-commit-hooks with http://github.com/cachix/pre-commit-hooks.nix, we need to be able to define an entry point that is accessible locally. This pull requests adds the pre-commit-hooks repository as its own Python module so we can access it and run its hooks.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.pre-commit-hooks


[TLM API] Add use_self_reflection to TLMOptions

This is a test to make sure this is implemented correctly, not to be merged.

Closed.  https://github.com/cleanlab/cleanlab-studio/pull/154


create category alphanumeric check not counting characters

3 letters minimum? why tho? 1 letter categories aren't bad... in my case I want to make an "H" category for eroge novels
However... I believe this line was forgotten lol
https://github.com/micah686/VnManager/blob/1f47add17f73588c1c7ee7611ea5559b664a558c/src/VnManager/ViewModels/Dialogs/ModifyGame/ModifyGameCategoriesViewModel.cs#L368
I have 0 experience in C# but taking a look at the other method calls and after googling for a bit I think it should be
input.Count(x => char.isLetter(x))
also I noticed that the games aren't being counted...
https://github.com/micah686/VnManager/blob/1f47add17f73588c1c7ee7611ea5559b664a558c/src/VnManager/ViewModels/UserControls/MainGridViewModel.cs#L68
shouldn't this be .Query().toList().Count()?

The current version of the input.Count() works just fine, even though the x => ... would work fine.
No, I don't need the .Query, because I just need the count. The db.GetCollection<T>() returns an ILiteCollection, which is enough for me to get a count.

I'm not sure if I'll decrease the category minimum to 2 or less

well, I was having an issue with both of these... category just seems to start working now... I tried restarting the program and it didn't fix it but now it fixed without restarting ._.
the game count still doesn't work tho it always shows 0 games...
still I have no knowledge in C# but it seems I was looking in the wrong file... whoops...
I have other issues on my end like weren't appearing as well but now they are... I think the most likely cause is not restarting after installing .NET core... I'll try that to see if it fixes it

The category issue was caused by me not clearing out the categories from the games.
Fixed in 024f76861621c980829fd9cf7c148080a295f375
Should also be fixed in the next release.


[Performance] Paddy causes major performance lags when editing symbols

Noticed performance issues when copying and editing symbols. Whenever I would copy and edit symbols, Sketch would freeze for 10 - 15s. Turned off my plugins one by one and noticed that Paddy was causing the issue.

I've experienced this too. I'm running Sketch 48.2. I've restarted Sketch, disabled plug-ins, re-installed Paddy. Nothing did the trick.

Me too, but not for all files actually. I have no idea what makes paddy do it, but for now I had to disable it.

Downgrading to 1.0.2 solved the problem for me, for now, FYI for anybody who comes across this thread and hasn’t tried it.

Sadly, I've had to uninstall Paddy. I'm working on a very large library and it would literally make my Sketch hang for about 5 minutes every time I tried to interact with a Symbol.

Hey all! Thanks for pointing this out!
At the moment, it can take a little while for Paddy to recalculate the size of a symbol instance, taking into account the padding within the Symbol Master, and its overrides.
However, this is made even worse when you edit the Symbol master directly... because at the moment, whenever you edit the Symbol master, it will recalculate its padding/spacing... and then also tell all of its instances to update their padding too, based on its changes.
Unfortunately this is incredibly non-performant. I have experienced this too.
I am thinking that a possible solution is that after you alter a Symbol Master that has padding in it, an alert would appear saying something like "Do you want to also resize the 10 instances of this Symbol now?" in which case it would be optional to resize all the instances or not.
Thoughts on that approach?

Hey @DWilliames thanks for building Paddy! I freaking love this plugin 😍.
When would you trigger the alert? It could be tricky for someone like me who is constantly tweaking the same symbol.

Alright, until I can come up with a better approach, I've implemented the alert for the user to 'opt in' to resize all the instances.
The alert will only appear if there are 10 or more instances — since in most cases, less than 10 instances don't seem to take too long to update.

Hmm..

first thing that pops to mind is a shortcut "update paddy symbols"
or some sort of passive alert that works on individual symbols

And that's all I got for now.

Hm, 1.0.4 didn’t fix the issue for me. I’ve yet to see the alert, which makes me think my issue isn’t related to 9+ instances. I think I’m seeing the beachball less in 1.0.4 than I was in 1.0.3, but nowhere near as much as 1.0.2 (which I downgraded to after 1.0.3 was released).
Also, I used to be able to select a layer intended for Paddy and hit ESC repeatedly, all the way up to the Symbol root. With 1.0.4, after Paddy does its thing on one layer, the selection drops out, and my layer list collapses almost all the way for that Symbol.
I might be kind of an edge case here because I rarely directly edit any of the layers/groups that are intended for Paddy. I have a custom plugin that updates content to many groups at once, using our site’s JSON API. In 1.0.2, I’d first run my plugin, then select an object that needed to be re-spaced, and then ESC all the way up the tree, and by the time I got to the Symbol root, Paddy would have gotten everything. I can’t seem do that with 1.0.4. An “update Paddy symbols” command mentioned above would solve that problem for me, at least. That command would also be good for people who did get the alert, said no to updating now, and wanted to update later. Rather than having to hunt down all the layers/groups that need attention, one command could get them all.

How about defer the update until you have the elements visible in the viewport? Can you detect which element is currently visible in Sketch vs. the hidden instances? If possible, you could just run the calculations on the elements that are important, and do the other instance re-render in batches to not kill the performance. Not sure if this helps at all.

I'm not sure, if this is directly related to the updating issue, but there seems to be another problem with performance: Had around 8 buttons (groups, not Symbols) on an Artboard, which I told Paddy to take care of.
From that moment on Sketch permanently used 50-100% of my CPU and Sketch was beachballing all the time. I then removed the padding information from the layer names, which made Paddy not update them anymore - but CPU usage/Sketch performance was still the same. Only after disabling Paddy everything is back to normal.
So even if Paddy should not be doing anything, it seems to cause some problems in the background.

There is indeed a performance issue. When you deselect the group/layer on the artboard, it deselects it with some delay. And i'm talking about 1 rectangle in a document. When i disable paddy, it works okay and deselects it immediately as it should.

I have the same issue. Should it be with a small file or a big one (300+ symbols library, 150+ artboards).

Thanks for the suggestions all.
@vic-topcoder that is a great idea. It may take a bit of changing of how Paddy is set up in order to be able to do that; but I think would be worth it.
@dorian-grey that sounds quite strange 🤔 I hope that's not Paddy causing it. It shouldn't be causing that much strain on the computer with such a small amount of elements.


Added my name to contributors list

:warning: This is a Pull Request Template :warning:
This will help you complete a pull request. Please follow the instructions below. And also,make sure that you're bound to code of conduct
Submission Checklist :heavy_check_mark:

[ ] I read the CONTRIBUTIONS.md .
[ ] I've forked the repository.
[ ] I've created a branch in the following format  MY- USERNAME - SHORT-NAME-OF-SUBMISSION.
[ ] I've read the Hacktoberfest's official guidelines regarding making pull request.
[ ] I've added my name into CONTRIBUTORS.md
[ ] I've filled in this form.

Please fill in the pr template! 🤕

Please fill in the pr template! 🤕

Done bro.


vvdecapp build shared can not be executed by old CPU

I have 2 PC: new AMD R5 3600 and old Intel i5 2500s, both use Windows.
I build vvdec on AMD R5 3600 PC using MSYS2 mingw64 environment.
My steps:
git clone https://github.com/fraunhoferhhi/vvdec
mkdir build && cd build
// build static
cmake .. -DBUILD_SHARED_LIBS=0 -DCMAKE_BUILD_TYPE=Release -G "MSYS Makefiles"
vvdecapp.exe file is generated and need follow dll files to be ran: libgcc_s_seh-1.dll, libstdc++-6.dll, libwinpthread-1.dll.
It can be executed by both AMD R5 3600 and Intel i5 2500s cpu.
// build shared
cmake .. -DBUILD_SHARED_LIBS=1 -DCMAKE_BUILD_TYPE=Release -G "MSYS Makefiles"
vvdecapp.exe and libvvdec.dll are generated, also need 3 dll files above to be ran.
This time, AMD R5 3600 runs fine.
Intel i5 2500s doesn't.

If I build shared with -DVVDEC_ENABLE_X86_SIMD=OFF
cmake .. -DBUILD_SHARED_LIBS=1 -DCMAKE_BUILD_TYPE=Release -G "MSYS Makefiles" -DVVDEC_ENABLE_X86_SIMD=OFF
Intel i5 2500s can run it, but decrease performance.
I install MSYS2 on i5 2500s PC and try building shared without -DVVDEC_ENABLE_X86_SIMD=OFF
i5 2500s still can't run it.
i5 2500s can run vvdecapp with static build, so SIMD does work fine on this cpu, but not build shared.

Thats very strange. Does this generate a stack-trace or something (is there a gdb for windows)? Would be very helpful. Maybe a profile build could provide more info (RelWithDebInfo) on where and what problem occures.

Thats very strange. Does this generate a stack-trace or something (is there a gdb for windows)? Would be very helpful. Maybe a profile build could provide more info (RelWithDebInfo) on where and what problem occures.

I'm not a software development, I quite don't understand what you mention about.
Sorry, I can't help much.

Thats alright. I'll see if we can reproduce it eventually.
Possibly related to: https://github.com/fraunhoferhhi/vvdec/pull/8

What output does the vvdecapp produce when you run it? Does it always crash or only when you specify a bitstream to decode? What happens when you run it explicitely specifing --simd 0 or --simd 1 (or --simd 2)? Please provide as much info as possible. I don't have the CPU at hand so it will be hard to reproduce.
Also help would be appreciated from anyone with a similar CPU who could reproduce the issue and provide a stacktrace.

The AMD R5 3600, as far as I understand, supports AVX2, so it seems there are some AVX2 instructions out there that break the compatibility with non-AVX2 CPUs. I'll see if I can find a CPU like that. Which compiler do you use in the MSYS2?

The AMD R5 3600, as far as I understand, supports AVX2

Yes, AMD R5 3600 does support AVX2.

Which compiler do you use in the MSYS2?

mingw-w64-x86_64-gcc

Does it always crash or only when you specify a bitstream to decode? What happens when you run it explicitely specifing --simd 0 or --simd 1 (or --simd 2)?

It crashes immediately and throw error message box.

Could you type vvdecapp.exe --simd 0 and report what happens? That is strange that the decoder app does not produce any output before exiting.

Could you type vvdecapp.exe --simd 0 and report what happens? That is strange that the decoder app does not produce any output before exiting.

No thing at all.

I went around the office yesterday to try and find the oldest working computer. I found one or two candidates I might get my hands on next week, that don't have AVX2 - if that's even the actual problem. Keep you posted.

I have an old laptop at home with a similarly old CPU. I can test it on that machine tomorrow.
Which version of Windows are you using? Could that be the problem?

Window 10 Pro 21H2, build 19044.1889 (both 2 PC)
My binary files: https://mega.nz/folder/l1liBQIR#j7QgZSlb8VYlX1wpCtV1EQ

@ZenKiyoshi, I think I definitely agree with you.
I tried same thing to build ffmpeg vvc static build, but not recognised or found.
Also, I tried build vvdecapp of static, but it does not link for some reason using MSYS2 MinGW only.
Cross compilation of Windows in Linux worked with static without DLL mess.
Cross compiled files of vvenc & vvdec: https://mega.nz/folder/GtUg0LxC#bVCANqxakq4AHgf-3OoNuA
Build with RelWithDebInfo using MSYS2 and share to developers:
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo ..

Martin Eesmaa

I was able to reproduce the error on an old laptop. For some reason the compiler outputs code that uses an unsupported instruction. If I build without link-time optimization the problem disappears. My impression is, that the cause of the problem is a compiler bug.
To disable link-time optimization either:
make release-shared disable-lto=1
or:
add -DVVDEC_ENABLE_LINK_TIME_OPT=OFF to your cmake invocation

@K-os, it seems worked to build FFmpeg vvc without reason, but only vvenc did not recognised of FFmpeg.
https://github.com/MartinEesmaa/FFmpeg-FixVVC
cmake -DVVENC_ENABLE_LINK_TIME_OPT=OFF -DBUILD_SHARED_LIBS=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/mingw64 -G "MinGW Makefiles" ..

error log:
marti@martinhero13 MINGW64 ~/FFmpeg-FixVVC
$ ./configure --enable-libfdk-aac --enable-libvvenc --enable-libvvdec --enable-static --disable-shared --enable-pic --enable-libxml2 --enable-zlib --extra-libs='-lpthread -lm -lz' --extra-ldexeflags=-static --pkg-config-flags=-static --disable-w32threads --extra-version=VVCEasy
ERROR: libvvenc >= 1.4.0 not found using pkg-config

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
<EMAIL_ADDRESS>mailing list or IRC #ffmpeg on irc.freenode.net.
Include the log file "ffbuild/config.log" produced by configure as this will help
solve the problem.

@MartinEesmaa did you build vvenc? This error has nothing to do with how you compiled vvdec.

@MartinEesmaa did you build vvenc? This error has nothing to do with how you compiled vvdec.

I built vvenc without lto and tried to use --enable-libvvenc on my ffmpeg vvc repository and won't recognise, but libvvdec is recognized by FFmpeg vvc. vvenc & vvdec without lto are also working fine.

@MartinEesmaa did you build vvenc? This error has nothing to do with how you compiled vvdec.

I built vvenc without lto and tried to use --enable-libvvenc on my ffmpeg vvc repository and won't recognise, but libvvdec is recognized by FFmpeg vvc. vvenc & vvdec without lto are also working fine.

Why build it static tho? Didn't you state that FFmpeg only works with dynamic builds?

@K-os I compile again and my i5 2500s can run vvdec shared build now.
One more thing.
i5 2500s does have AVX(1), so I think it could run vvdec with --simd 3
but vvdec only allow --simd 2 on this cpu.

Oh yes. AVX detection is disabled for all windows builds, because Visual Studio used to produce code that resulted in invalid instructions. It should probably only be disabled for Visual Studio builds.
But I don't think there would be a significant performance improvement, since there is no specific AVX code in vvdec. It will only allow the compiler to optimize some code using AVX instructions.
You can give it a try by removing the  #ifndef _WIN32 and #endif in CommonDefX86.cpp lines 187 and 190:
https://github.com/fraunhoferhhi/vvdec/blob/3956df5c91fceda76b2f095c999e3ef2b8e8870c/source/Lib/CommonLib/x86/CommonDefX86.cpp#L187-L190
But leave the ext = AVX; there.


Links in Documentation section of Readme now dead

The humblecoder.com domain that the two links in the section point to is not registered anymore. It now redirects to advertisements. It might be rescued with archive.org as an alternative to looking for a new set of examples.

Thanks for reporting. I've updated the links in the README to point to the correct locations.


reimplement std.traits.ParameterStorageClassTuple()

reboot https://github.com/dlang/phobos/pull/5427 by @WalterBright as it is required for the new mangling in https://github.com/dlang/dmd/pull/6998
Maybe something else changes, but locally I cannot reproduce an error with toDelegate!(void function(FreeListRef!(shared(int), true), int delegate(int, int) pure nothrow @nogc @safe, int, int) nothrow @nogc @system) as in the previous attempts build logs.

Maybe something else changes,

The project tester now tests the new v0.8.0 vibe.d release, we should test this with v0.7.31, but otherwise this is great :)

we should test this with v0.7.31,

Tested. Builds fine.

BTW: there is a "little demangler" at the top of the file that seems unused now. Should we ditch it?

I think so, but let's better do this in a different PR. I'm impatient as well and I want to see your great work merged rather sooner than later! It's been in the queue way too long.

but let's better do this in a different PR.

I was already removing it when having the same thought ;-)

@CyberShadow I suspect you are aware of this, but just in case: the documentation tester currently seems to complain about "Pull request SHA mismatch" on every phobos pull request I looked at. Anything we need to fix?

@rainers Yes, please see here and here. GitHub support has been notified and is looking into it.

Merging this now as it has been approved before.

Merging this now as it has been approved before.

Due to our current CI problem here, I will create a new PR to be sure that there aren't any new failures popping up in Jenkins.

Okay sorry - seems that didn't help:

But at least restarting twice seems to work :/

Jenkins failure are due to https://github.com/dlang/druntime/pull/1879#issuecomment-316291564.


fix(ci): Passing ESLint CI Tests

smoothVolume/injection.ts

Disabled ESLint for and added a line to ignore ts-compiler errors

core/VoiceReceiver.ts

Seems like prism-media was missing from package.json so we added it

NPM Install Conflicts

prism-media was using an older version of @discordjs/voice and @discordjs/opus package, so I added the --force argument to npm install

My bad, LGTM!