API Proposal: FromDockerfile and WithBuildArg

Background and Motivation
Developers have requested the ability for Aspire to build a container image on the fly from a Dockerfile (see: https://github.com/dotnet/aspire/issues/1852). DCP added the capability to do this so this change is about adding this feature into the app model.
Current PR: https://github.com/dotnet/aspire/pull/4312
Proposed API
+ public IResourceBuilder<ContainerResource> WithDockerfile(
+    this IResourceBuilder<ContainerResource> builder,
+    string contextPath,
+    string? dockerfilePath = null,
+    string? stage = null)

+    public static IResourceBuilder<T> WithBuildArg<T>(this IResourceBuilder<T> builder, string name, object value) where T : ContainerResource
+    public static IResourceBuilder<T> WithBuildArg<T>(this IResourceBuilder<T> builder, string name, IResourceBuilder<ParameterResource> value) where T : ContainerResource
+    public static IResourceBuilder<T> WithSecretBuildArg<T>(this IResourceBuilder<T> builder, string name, IResourceBuilder<ParameterResource> value) where T : ContainerResource

+ internal class DockerfileBuildAnnotation(string contextPath, string dockerfilePath, string? stage) : IResourceAnnotation
+ {
+     public string ContextPath => contextPath;
+     public string DockerfilePath = dockerfilePath;
+     public string? Stage => stage;
+     public Dictionary<string, object> BuildArguments { get; } = new();
+     public Dictionary<string, object> SecretBuildArguments { get; } = new();
+ }

Manifest output
    // snip
    "mycontainer": {
      "type": "container.v0",
      "image": "myimage:latest",
      "build": {
        "context": "qots",
        "dockerfile": "qots/Dockerfile",
        "args": {
          "GO_VERSION": "{goversion.value}"
        },
        "secrets": {
          "MY_SECRET": "{mysecret.value}"
        }
      }
    }
    // snip

Usage Examples
// Add a container which builds from a Dockerfile given a context path.
var container = builder.AddContainer("mycontainer", "myimage")
                       .FromDockerfile("containers/mycustomcontainer");

// Add a container which builds from a Dockerfile given a context path and a custom Dockerfile name.
var container = builder.AddContainer("mycontainer", "myimage")
                       .FromDockerfile("containers/mycustomcontainer", "Otherdockerfile");

// Add a container which builds from a Dockerfile given a context path and a custom Dockerfile name.
var container = builder.AddContainer("mycontainer", "myimage")
                       .FromDockerfile("containers/mycustomcontainer")
                       .WithBuildArg("SOMEOPTION", 1);

// ... using parameters
var someOption = builder.AddParameter("someOption");
var container = builder.AddContainer("mycontainer", "myimage")
                       .FromDockerfile("containers/mycustomcontainer")
                       .WithBuildArg("SOMEOPTION", someOption);

// ... specifying build stage explicitly
var container = builder.AddContainer("mycontainer", "myimage")
                       .FromDockerfile("containers/mycustomcontainer", stage: "intermediate");

Alternative Designs

We could have implemented a completely custom resource AddDockerfile but this would have meant quite a bit of duplication of extension methods was necessary. Additionally a container image that is built from a Dockerfile is conceptually identical in Aspire other than the fact that the image is built on the fly via DCP ... so this option just adds an annotation to capture the extra detail we need.
Risks
We need to consider what would happen if a deployment tool read the manifest and didn't understand the build arguments and tried to pull the image from a public registry. Could this be an attack vector?
To help mitigate this, should we ... if the build metadata is present change the resource type to dockerfile.v1?

There can be some noticeable differences between how a user might run a container locally for development vs. how they would build and run a container for production. A common pattern for development in many languages is to volume mount your local source into the container to enable the equivalent of hot reload; the Dockerfiles scaffolded by VS and VS Code for .NET projects actually include a stage for development that skips copying files into the container to speed up startup. So the volume and stage settings used for development may not match those needed for production.

How do I set the build directory?
Is "Dockerfile" the best name here, even if I'm using podman?

For 1, the first argument to FromDockerfile is a path to the build directory.
For 2, it’s messy, because Dockerfile has basically become the industry standard and is the only file name you can use if you want full compatibility between Docker and Podman when building an image (.dockerignore vs .containerignore being another similar case).

How would you pass secrets to the docker build with this api.  For example to dotnet restore from an Azure devops feed:
$env:AdoToken = az account get-access-token --resource 499b84ac-1321-427f-aa17-267ca6975798 --query accessToken --output tsv
docker build . --secret id=ado-accesstoken,env=AdoToken

With dockerfile:

RUN --mount=type=secret,id=ado-accesstoken \
    export VSS_NUGET_ACCESSTOKEN=$(cat /run/secrets/ado-accesstoken); \
    dotnet restore

Is the dockerfilePath relative to the contextPath? Or relative to the AppHost directory? On the command line it is relative to the CWD, which in this case is the AppHost directory.

How would you pass secrets to the docker build with this api. For example to dotnet restore from an Azure devops feed:
$env:AdoToken = az account get-access-token --resource 499b84ac-1321-427f-aa17-267ca6975798 --query accessToken --output tsv
docker build . --secret id=ado-accesstoken,env=AdoToken

With dockerfile:
RUN --mount=type=secret,id=ado-accesstoken \
    export VSS_NUGET_ACCESSTOKEN=$(cat /run/secrets/ado-accesstoken); \
    dotnet restore

For build time secrets, --build-arg parameters are treated as environment variables for build commands, but aren't persisted in the final image, so that's one option for passing a secret like an azdo token into a container for build time restore. Otherwise, using RUN --mount=type=secret in a Dockerfile is a way to make specific files available as temporary secrets during build.

In which case, yeah, we'd need to include --secret arguments for buildx to handle the RUN mount. Good point.

For build time secrets, --build-arg parameters ... aren't persisted in the final image, so that's one option for passing a secret like an azdo token into a container for build time restore.

Build Args do end up in the final image - run docker history on an image and it'll show you the build args in clear text.  (If you have a multi stage build, it's possible you've accidently mitigated the issue by copying from a previous layer that used a build arg rather than building on top of that layer)

For build time secrets, --build-arg parameters ... aren't persisted in the final image, so that's one option for passing a secret like an azdo token into a container for build time restore.

Build Args do end up in the final image - run docker history on an image and it'll show you the build args in clear text. (If you have a multi stage build, it's possible you've accidently mitigated the issue by copying from a previous layer that used a build arg rather than building on top of that layer)

If you have an ARG statement in your Dockerfile, docker history will show that and the default value, but it doesn't include overrides passed in via the command line unless they were included verbatim as a command line argument (used as an argument in a  RUN command, for example, rather than as an ambient environment variable, but that's a problem you could encounter with secrets as well).

This is proposing a new builder method prefix, From. We should also consider applicability of existing terms or whether a different new term would be a better fit:

WithDockerfile
Pretty good alignment with existing methods that impact the resource like WithEnvironment, WithLaunchProfile, etc., and we have examples of With methods for container resources that impact the creation of the resource already, e.g. WithImage.
AsDockerfile:
The As prefix seems slightly more aligned with what the resource produces rather than where it comes from, RunAsEmulator, but they're pretty close
AddDockerfile
The Add prefix on an IResourceBuilder<T> represents adding a child resource, e.g. AddDatabase so doesn't seem like a good fit here
UseDockerfile
We don't currently use the Use prefix on IResourceBuilder<T> that I could find but it seems it would be an OK fit for this case but it could be argued it's basically the same as With

Based on above we should probably consider using WithDockerfile unless we feel strongly that this method needs to be differentiated as it's mutually exclusive to methods like WithImage/WithImageTag/WithRegistry for creating a container resource (is it?).

This is proposing a new builder method prefix...

Yeah, I was not sure on the name myself (note the name of the branch on the PR :)). I can easily be persuaded to have WithDockerfile. I'm not sold on AsDockerfile and in fact I think we misnamed this for PublishAsDockerfile (probably should have been PublishAsContainer. AddX and UseX are used in different contexts.

There can be some noticeable differences between how a user might run a container locally for development vs. how they would build and run a container for production...

Very true, although I'm not sure that means we need any API changes here. People can use if/switch/tenary operators to provide customization to the way the container is configured based on whether they are publishing the manifest or any other value.
What we provide here is something they can easily compose into their final solution.

How would you pass secrets to the docker build with this api ....

This isn't something I've modeled with this. I could potentially add something like WithSecretBuildArg(...). But before we could tackle that we would need DCP to support it (@danegsta @karolz-ms?)
Locally I think this could be pretty straight forward - but for manifest publishing scenarios we would need to think how this is going to work. We would probably want to make WithSecretBuildArg(...) only accept an IResourceBuilder<ParameterResource> to ensure that all the secrets are externalized.

If you have an ARG statement in your Dockerfile, docker history will show that and the default value, but it doesn't include overrides passed in via the command line unless they were included verbatim as a command line argument (used as an argument in a RUN command, for example, rather than as an ambient environment variable, but that's a problem you could encounter with secrets as well).

We definitely want to handle secrets with care. I'm thinking that we do a few things here.

We add `IResourceBuilder<> WithSecretBuildArg(this IResourceBuilder, IResourceBuilder) where T: ContainerResource
We make WithBuildArgs throw if the parameter passed in is a secret (with instructions to use WithSecretBuildArg instead.

Thoughts? This is obviously predicated on DCP supporting it - which I think is a good idea.

How would you pass secrets to the docker build with this api ....

This isn't something I've modeled with this. I could potentially add something like WithSecretBuildArg(...). But before we could tackle that we would need DCP to support it (@danegsta @karolz-ms?)
Locally I think this could be pretty straight forward - but for manifest publishing scenarios we would need to think how this is going to work. We would probably want to make WithSecretBuildArg(...) only accept an IResourceBuilder<ParameterResource> to ensure that all the secrets are externalized.

I opened up a DCP PR to add secrets support and use the image ID as the run source, hope to have it make its way upstream early next week.

Awesome. Once that lands in the repo we can get the secrets working end to end in my PR.

If you have an ARG statement in your Dockerfile, docker history will show that and the default value, but it doesn't include overrides passed in via the command line unless they were included verbatim as a command line argument (used as an argument in a RUN command, for example, rather than as an ambient environment variable, but that's a problem you could encounter with secrets as well).

We definitely want to handle secrets with care. I'm thinking that we do a few things here.

We add `IResourceBuilder<> WithSecretBuildArg(this IResourceBuilder, IResourceBuilder) where T: ContainerResource
We make WithBuildArgs throw if the parameter passed in is a secret (with instructions to use WithSecretBuildArg instead.

Thoughts? This is obviously predicated on DCP supporting it - which I think is a good idea.

Technically build args are the only way to pass ephemeral secrets in; the secrets argument is for mounting secret files at build time.

Is the dockerfilePath relative to the contextPath? Or relative to the AppHost directory? On the command line it is relative to the context directory.

The way it works in the current implementation is this:

The contextPath is relative to the app host directory ... unless it is absolute.
The dockerfilePath is relative to the contextPath ... unless it is absolute.
When the values are handed off to DCP they are made absolute.
When the values are emitted into the manifest, they are relative to the manifest file location.

Technically build args are the only way to pass ephemeral secrets in; the secrets argument is for mounting secret files at build time.

Good to know. Is this behavior consistent across Docker and Podman?

@ellismg @vhvb1989 @prom3theu5 @davidfowl
Wanted to call out a specific risk I saw here. Lets say I have the following code:
builder.AddContainer("mycontainer", "myinternalimage").WithDockerfile(...)

And then lets say I run a version of AZD or Aspir8 that does not support the new build: field and skips over it. Then it's going to by default let the container runtime resolve myinternalimage from its default registry.
Potentially a malicious actor could learn of this image name and create a repository that matches in that public registry and whereby inject malicious code into the developers app (possibly in a context where production secrets are exposed to the container).
Doing a schema revision is not sufficient here because current deployment tools do not look at the schema version. In this scenario I think we might have a case for changing the resource version to container.v1.
Thoughts?

WithSecretBuildArg as a name seems a bit ambiguous - are we talking about secrets, are we talking about build args, or are we talking about a build arg that is thought of as a secret?  I'd prefer to see two separate methods - WithBuildArg (--build-arg) and WithSecret (--secret) (or possibly WithBuildSecret).
Agree that ParameterResource on build args shouldn't be blocked outright though --build-arg as are sometimes unavoidable depending on how the image, or if you're using tools purely for local dev, maybe you don't consider the values as a secret but the Aspire APIs force you to plumb them through ParameterResource.
That said, could still encourage the use of secrets over build args by using [Obsolete] attribute or roslyn analyser to warn and recommend the use of secrets if passing a  ParameterResource as a build arg.

Technically build args are the only way to pass ephemeral secrets in; the secrets argument is for mounting secret files at build time.

Good to know. Is this behavior consistent across Docker and Podman?

Yeah, the build secrets argument has the same behavior between Docker and Podman.

Theoretically registry namespaces prevent a user from squatting on an arbitrary image. Single name registries such as node or postgres can only be created by Docker, Inc. and any given registry prefix (such as dpage/ for dpage/pgadmin4) is owned by a specific user/organization. I think the only real attack vectors would be a compromised registry/repository, an image reference to an existing malicious registry, or a reference to a non-existent registry prefix.

And then lets say I run a version of AZD or Aspir8 that does not support the new build: field and skips over it. Then it's going to by default let the container runtime resolve myinternalimage from its default registry.

This is a reason to change the version of the resource. If these properties are added to the manifest it's container.v1, if the v0 compatible properties are added it's v0.

@davidfowl yeah that is what I'm thinking.
@danegsta you are probably right about this being an unlikely threat given the way current major registries work. But I'm wondering whether we should still mitigate the threat instead of relying on that.

@mitchdenny DCP support for build secrets has been merged into main.

When building dockerfiles, should there be any default labels applied to the images - e.g. open container labels, or any aspire specific labels to describe where they came from (e.g. resource name, project name)

@afscrome this change has just merged in but I think your suggestion above is worth considering. Did you want to open up a separate issue?


Link issue still happening v1.5.1

Given the link https://en.wikipedia.org/wiki/Open_Financial_Exchange I am still getting the following rendering

Fixed in 1.5.2 with commit 385b21f282c97d3d90eda9bba44859a3b7a5dfdf


add sandbox reset request payload

According to public documentation, the sandbox reset request needs a payload that is currently missing: https://experienceleague.adobe.com/docs/experience-platform/sandbox/api/sandboxes.html?lang=en#reset

@pitchmuc @skanjila @cmenguy please review when you get the chance


Update endpoint commandEndpoint should be blocked when confirming delete command

Same applies to add, in general we should lock other functions when waiting for a confirmation


Dependency check fails on CVE-2022-1471

https://nvd.nist.gov/vuln/detail/CVE-2022-1471
io.gitlab.arturbosch.detekt:detekt-report-sarif:1.23.0
|    |    |    +--- io.github.detekt.sarif4k:sarif4k:0.4.0
This is since some days marked as critical. Please update.

That's because of our dependency on SnakeYaml. @chao2zhang is it something you can take a look at?

Ack. I will take a look by end of this week

By the way, this issue should be open against https://github.com/detekt/detekt - Sarif4k does not depend on snakeyaml

This issue should have been addressed by https://github.com/detekt/detekt/pull/5751
@rschattauer Would you mind attaching the full errors? According to SnakeYaml's official response, there might be false positives from DependencyCheck https://bitbucket.org/snakeyaml/snakeyaml/wiki/CVE & NIST.md

@chao2zhang , you are right, dependencyCheck is already regressing this issue
https://github.com/jeremylong/DependencyCheck/issues/4435#issuecomment-1564485173
Closing this here, sorry


Perp-Neg for Editing Models

Hey!
I really loved your work on this and think this can be very powerful in the context of image editing with diffusion models, like done by InstructPix2Pix.
There, the authors propose to have two-way CFG between

unconditional generation,
only image-conditional generation, and
image- and text-conditional generation

So you end up with something like this:

How could we apply the Perp-Neg idea there? How would the idea map to this three-way CFG?

hi i met the similar problem with you and i wonder is this perp-neg method WORK for instructpix2pix? how to modify it to adjust this three-way CFG


Catch up with upstream wrk

wrk2 was created in Nov. 2014 as an example of correcting coordinated omission in a load generator. It was basically a quick fork of wrk at the time,  with minimal changes needed to achieve the purpose, created by @giletene and @mikeb01 as a result of a quick conversation at QCon SF.
The project turned out to be way more popular than I thought, or than originally intended. Wrk seems like a very solid base, but people looking for constant-rate capabilities and proper (not susceptible to coordinated omission) latency measurement seem to have picked up wrk2.
But since we had not put any real work into maintaining or enhancing wrk2 over the years, I'm sure wrk has added quite a bit in the 5 years since that we should simply "catch up on".
One simple way to do this is to follow Vizzini's directive and "go back to the beginning". Since applying the changes to wrk 5 years ago was "fairly simple" and since we had not strayed very far from the original work done in 2014, we can just pick up the latest/greatest wrk2, and apply the same logical changes to it that we did back then, to get an "up to date" wrk2 with all the wrk goodies. It took me and @mikeb01 only a few days to do it the first time, and applying it again "should" be even shorter... ;-)
I would prefer that we do this before starting to add any new features from PRs that have accumulated over the years, and any new features we want to add that are wrk2-specific (e.g. I'd really like to add a .hlog output support, which has long been part of hdrhistogram_c). Once we apply those PRs and additions, catching up with wrk will involve much more work...
Does anyone out there want to volunteer to do this "catch up to latest wrk" work?

@giltene I’ll start taking a look at doing this. I agree this a good approach.

Files wrk2/.gitignore and wrk-4.0.1/.gitignore differ
Files wrk2/LICENSE and wrk-4.0.1/LICENSE differ
Files wrk2/Makefile and wrk-4.0.1/Makefile differ
Files wrk2/NOTICE and wrk-4.0.1/NOTICE differ
Looking at the places where wrk2 differs from files that actually existed in wrk 4.0.1, this is the list:
Files wrk2/src/config.h and wrk-4.0.1/src/config.h differ
Files wrk2/src/main.h and wrk-4.0.1/src/main.h differ
Files wrk2/src/net.c and wrk-4.0.1/src/net.c differ
Files wrk2/src/net.h and wrk-4.0.1/src/net.h differ
Files wrk2/src/script.c and wrk-4.0.1/src/script.c differ
Files wrk2/src/ssl.c and wrk-4.0.1/src/ssl.c differ
Files wrk2/src/ssl.h and wrk-4.0.1/src/ssl.h differ
Files wrk2/src/stats.c and wrk-4.0.1/src/stats.c differ
Files wrk2/src/stats.h and wrk-4.0.1/src/stats.h differ
Files wrk2/src/wrk.c and wrk-4.0.1/src/wrk.c differ
Files wrk2/src/wrk.h and wrk-4.0.1/src/wrk.h differ
Seems very approachable.

I wanted to give a quick update that I have started on this. It might take me more than a few days ;-) but I'll update if I run into any issues.


Searching admin in lobbyingchglogcd results in "Related Field got invalid lookup: icontains"

Using package from pypi:
django-calaccess-raw-data==1.4.6
This is my query URL:
http://<IP_ADDRESS>:8000/admin/calaccess_raw/lobbyingchglogcd/?q=test
This is my traceback:
Environment:

Request Method: GET
Request URL: http://<IP_ADDRESS>:8000/admin/calaccess_raw/lobbyingchglogcd/?q=test

Django Version: 1.10.4
Python Version: 2.7.10
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'django.contrib.admindocs',
 'calaccess_raw',
 'my_project']
Installed Middleware:
['django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware']

Traceback:

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/core/handlers/exception.py" in inner
  39.             response = get_response(request)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/core/handlers/base.py" in _legacy_get_response
  249.             response = self._get_response(request)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/contrib/admin/options.py" in wrapper
  544.                 return self.admin_site.admin_view(view)(*args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/utils/decorators.py" in _wrapped_view
  149.                     response = view_func(request, *args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
  57.         response = view_func(request, *args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/contrib/admin/sites.py" in inner
  211.             return view(request, *args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/utils/decorators.py" in _wrapper
  67.             return bound_func(*args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/utils/decorators.py" in _wrapped_view
  149.                     response = view_func(request, *args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/utils/decorators.py" in bound_func
  63.                 return func.__get__(self, type(self))(*args2, **kwargs2)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/contrib/admin/options.py" in changelist_view
  1543.                 self.list_max_show_all, self.list_editable, self,

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/contrib/admin/views/main.py" in __init__
  78.         self.queryset = self.get_queryset(request)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/contrib/admin/views/main.py" in get_queryset
  346.         qs, search_use_distinct = self.model_admin.get_search_results(request, qs, self.query)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/contrib/admin/options.py" in get_search_results
  905.                 queryset = queryset.filter(reduce(operator.or_, or_queries))

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/query.py" in filter
  796.         return self._filter_or_exclude(False, *args, **kwargs)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/query.py" in _filter_or_exclude
  814.             clone.query.add_q(Q(*args, **kwargs))

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/sql/query.py" in add_q
  1227.         clause, _ = self._add_q(q_object, self.used_aliases)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/sql/query.py" in _add_q
  1247.                     current_negated, allow_joins, split_subq)

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/sql/query.py" in _add_q
  1253.                     allow_joins=allow_joins, split_subq=split_subq,

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/sql/query.py" in build_filter
  1178.             lookup_class = field.get_lookup(lookups[0])

File "/Users/cbodkin/.virtualenvs/my_project/lib/python2.7/site-packages/django/db/models/fields/related.py" in get_lookup
  694.             raise TypeError('Related Field got invalid lookup: %s' % lookup_name)

Exception Type: TypeError at /admin/calaccess_raw/lobbyingchglogcd/
Exception Value: Related Field got invalid lookup: icontains

Pretty sure this is happening on admin of a model with a ForeignKeyField, so it's a problem on RawDataFile, FilerToFilerTypeCd and FilerTypePeriodsCd as well.
All of our admins inherit from BaseAdmin, where we've defined a method to make all fields on a given model searchable. For now, I am going to exclude these ForeignKeyFields from being searchable.
If we need to customize any admins to allow searching on field of a related model, we can just override the .get_search_fields() to add those specific fields. Django docs says it is possible for related lookups.
Thanks for the heads up!


Create Design System Layout

Relevant Trello Card
What

Rename application.js and application.scss to legacy-application.scss and legacy-application.js in preparation to use the layout_for_admin component from the govuk_publishing_components gem. Update the configuration manifest and point application.html.erb to the new legacy asset files. Rename application.html.erb
to legacy_application.html.erb and set layout in ApplicationController to the renamed layout.

Create design_system.html.erb layout. Make the ReportsController use the new layout. Create a helper, NavigationItemsHelper, to build the navigation link structure for the navbar. Write tests for the NavigationItemsHelper.

Why
As part of the work to transition publisher to the Design System.
Visual Differences (only if feature flag enabled!!)

⚠ This repo is Continuously Deployed: make su
re you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

Added the missing name link. Needs re-review.


Sidetrail documentation

Description of changes:
Adds documentation to assist in debugging SideTrail CI issues.
Call-outs:
Testing:
This is a doc change only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2184 into master will decrease coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
- Coverage   81.07%   80.77%   -0.30%
==========================================
  Files         248      248
  Lines       18521    18522       +1
==========================================
- Hits        15015    14961      -54
- Misses       3506     3561      +55


realm-settings: Get max invites for realm plan type helper.

There are a few places where we want to set the max_invites for a realm to the default for a realm's plan_type, so this creates a helper function that can be used consistently to get that default value.
Notes:

Follow-up from review comment.
Uses Realm.ALL_PLAN_TYPES dict for check/assertions that a plan_type value is one of the valid plan types. This dict was added for populating realms with different plan types for billing testing (see commit 9ebb3f06b3ad87e91e1f66bb5a94fe377c4196b9).

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks great, merged, thanks @laurynmm!


Add optional Description field for monitors

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature, Other
🔖 Feature description
Add optional Description field for monitor, visible only for admins (not visible on status page)
✔ Solution
I want to add more info for my monitors, like service name on Azure, admin login account, different (private) IP, restart command/script etc., this info should not be visible on Status Page.
This field should be textarea
❓ Alternatives
No response
📝 Additional Context
No response

Looks like there is an Issue for that which also has a Pull Request ready: #482

Duplicate of https://github.com/louislam/uptime-kuma/issues/482


[evm examples] Added Move modules for the ERC165, ERC721 contracts and their interfaces

This PR:

adds the Move modules for ERC165 and ERC721.

One thing to note is that the function ERC721::safeTransferFrom is
overloaded. So, it's indicated as follows:
#[callable(name=safeTransferFrom)]
public fun safeTransferFrom_with_data (...

adds the function supportInterface and proper transfer acceptance
checks for ERC1155.

adds the "interface" modules such as IERC165, IERC721,
IERC721Receiver, IERC1155, IERC1155Receiver. The interface modules contain:

APIs for cross-contract call
(e.g., call_onERC1155Received)
the selectors of the functions (e.g., the first 4 bytes of keccack256("onERC1155...")), and
the interface identifier of the interface.

adds the Result module as a library. A cross-contract call can fail in several ways. So, Result<T, E> is used to wrap the return types of the functions in the interface modules. T is the original return type of the function (for the successful case) while 'E' is the type of error values (for the case where the function fails)

Motivation
To write ERC165 and ERC721 in Move
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
cargo test

/land


Deploy a live labflow instance

TBD, Kubernetes?

I created a new GCP project and just added you to it, you should have just received an email.
Also fine if you don't want to use it!

Thanks! I got in successfully. Will have something deployed today or
tomorrow
On Fri, Oct 16, 2020 at 9:59 PM kathryn-explorable<EMAIL_ADDRESS>wrote:

I created a new GCP project and just added you to it, you should have just
received an email.
Also fine if you don't want to use it!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lab-grid/labflow/issues/2#issuecomment-710749923, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJEXZ2UUTD4ZUWA7QV6WODSLEQCHANCNFSM4SUCNUNQ
.

Upon further consideration, I ended up going with a simple terraform deployed google cloud run stack for now. It probably is best to wait on the kubernetes-ification until we're ready to deploy this for a customer.

Just tested flow.labgrid.com, and when I saw it wasn't working I went to Auth0 to try to allow requests from that URL... So FYI that's why that new url is added to the "Web" application there under origins/callback/logout. But I failed to get it working. I tried to add a new API at api.flow.labgrid.com, it wouldn't let me, and I decided I should stop guessing!

Hey Kathryn,
The application was broken due to some bash scripting duct tape that I put
in place to inject environment variables into the webapp on container start
instead of at container build. It should be fixed now!
Robert
On Tue, Oct 20, 2020 at 4:40 PM kathryn-explorable<EMAIL_ADDRESS>wrote:

Just tested flow.labgrid.com, and when I saw it wasn't working I went to
Auth0 to try to allow requests from that URL... So FYI that's why that new
url is added to the "Web" application there under origins/callback/logout.
But I failed to get it working. I tried to add a new API at
api.flow.labgrid.com, it wouldn't let me, and I decided I should stop
guessing!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/lab-grid/flow/issues/2#issuecomment-713200402, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJEXZYIPNBQCHS7FZRWPNTSLYNWBANCNFSM4SUCNUNQ
.


How to generate ply files after training and rendering

Thanks for the amazing work, but how can i obtain ply files.

Hi, you can find the save_ply method from original 3DGS here: https://github.com/mikeqzy/3dgs-avatar-release/blob/6f57deb6fbd3ad929ce81ab61da8c4e056a5cedd/scene/gaussian_model.py#L248
However there are several points to note:

f_dc and f_rest is not used, since we use MLP instead of spherical harmonics to decode color.
rotation is not correct since the rotation after skinning is not converted back to quaternion, see here. You could convert it back to quaternion before storing to ply.


Add bias gelu

Codecov Report
Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (686ad2d) to head (4e89050).

Files
Patch %
Lines

...ental_experiment/xoptim/patterns_ort/activation.py
69.56%
14 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   73.84%   73.83%   -0.01%
==========================================
  Files         142      142
  Lines       19731    19777      +46
==========================================
+ Hits        14571    14603      +32
- Misses       5160     5174      +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Restructuring

Brought plugin inline with radar-schemas and radar-commons-android

Was it intentional that the sourceId field in the records key is always the same UUID for each device? IMO the MAC address should be the sourceId for devices like Empatica, Biovotion etc.


[cargo vet] Trust Google's aggregated audits instead of just those for Fuchsia and Chromium

Feature
Google is aggregating cargo vet audits from Fuchsia, Chromium, ChromiumOS, and some internal projects, in a single place. We should switch to importing that aggregation.
Benefit
Switching to the aggregation from our current import of the Fuchsia and Chromium audits would give us more coverage now and in an ongoing manner.
Implementation
It's probably as simple as switching the import, but for all I know there might be a need to evaluate some of Google's custom audit criteria and see how to apply them. ("For all I know", because I didn't deeply check whether there's anything new compared to our current imports.)
Alternatives
Keep things as they are

I would be in favor of this.

It's probably as simple as switching the import, but for all I know there might be a need to evaluate some of Google's custom audit criteria and see how to apply them. ("For all I know", because I didn't deeply check whether there's anything new compared to our current imports.)

I skimmed the custom audit criteria and they seem reasonable. I don't think we should adopt their criteria for our uses, but I don't think they will get in our way and I don't think they are lowering audit standards.


Question: Can we make condition based on previous response?

Amazing work guys!!!
I was just wondering if it was possible to propose form inputs based on a previous response?
For example, if for the possible answers for question 3 depends on answer for question 2?
Thanks!

@MuyBien already working on a proposal, please see this thread let me know if you have any thoughts.


Includes all deferred conversion costs in benchmarks

This refactors the helper that returns the callable to benchmark to fully expand Mapping return types. This is needed in case those return types lazily convert values from device to host, so the complete cost can be included in the measured/benchmarked run.  This is similar to exhausting returned generators that deferred computations in NetworkX, and doing this keeps us consistent with benchmarking the full compute and/or conversion costs for both libraries.
I changed the option name from exhaust_returned_iterator to force_unlazy_eval since this is no longer being used only for iterators, but I'm taking suggestions for a better name.

/merge


Make sure for next release branch appveyor runs

This is already added in release/1.3 and release/1.2 was fixed with a
specific branch name at some point.
Signed-off-by: Phil Estes<EMAIL_ADDRESS>

Codecov Report

Merging #3869 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3869      +/-   ##
==========================================
- Coverage   42.35%   42.34%   -0.02%
==========================================
  Files         130      130
  Lines       14683    14683
==========================================
- Hits         6219     6217       -2
- Misses       7539     7540       +1
- Partials      925      926       +1

Flag
Coverage Δ

#linux
45.76% <ø> (-0.02%)
:arrow_down:

#windows
37.82% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

snapshots/btrfs/btrfs.go
57.39% <0%> (-0.9%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b12d46...cfb4f73. Read the comment docs.

LGTM


_interpolate_bads_eeg() runs into an error if no bad channels are set

Hi everybody,
I am using interpolate_bads() on raw eeg data. If I run this function without setting a bad channel, the function runs into an error.
The problem can be found in the file interpolation.py at line 126.
The check: if len(picks) == 0 or len(bads_idx) == 0: misses its pupose, because bads_idx is a boolean ndarray and its length is therefore always greater than 0.
Can someone please fix this? (bads_idx.sum() == 0 would work)
Thanks

I don't follow. Can you provide script to reproduce using the sample data? Thanks.

good catch, fix coming


It adds tab spaces and doesn't allow to change this!

VSCode Version:
OS Version:

Steps to Reproduce:

Well, just try to write function() {
something here
}
It also has to do with html tags and I am sure with many other templates.
Please look at lines 9, 10
Is there no way to change this

to this

After autosaving or saving second variant becomes frist. It's really annoying because I am get used to tabs style as it is displayed in the second image. I tried tabsize, space,
I have changed my settings to

"editor.tabSize": 2,
"editor.insertSpaces": false,
"editor.detectIndentation": false,
However still have this annoying behavior which makes code unconvenient.

Does this issue occur when all extensions are disabled?: Yes/No

Does this issue occur when all extensions are disabled?

If I disable all extensions it's gone


Upgrade Jetty

We're still using Jetty 9.4.10 while the current version is already 9.4.18.
There's at least one breaking change in 9.4.17:

3464 Split SslContextFactory into Client and Server

which blows up my current project for another dependency in my fat jar includes a 9.4.18 jetty leading to a NoClassDefFoundError.
Can we upgrade to the latest jetty version? I'll try to file a PR if I find some spare time.

My crash is gone with dropwizard 1.3.10. I'ma file a PR with some dep updates.

PR here: https://github.com/LivePersonInc/dropwizard-websockets/pull/27


Add Gokaraju Rangaraju Institute of Engineering and Technology,India

@Tejesh18 griet.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


Add doctrine odm support to be able to use mongodb

At the moment this bundle only support Doctrine ORM, it should be extended to support Doctrine ODM as well so we can use MondoDB database.

Implemented and merged by #83


Adding LVS environment for GF180MCU

Adding LVS environment for GF180MCU

LVS runset has been spliited into sections as agreed and included in a main one
New folder structure is added and testcases have been fixed
Regression is changed and could be run multi-threaded now with more detailed results.
Adding all LVS devices except MIMCAP and resistors

@atorkmabrains Ready to review

@FaragElsayed2 If it's hard, please add another file that would contain this list

Thanks @FaragElsayed2


[Enhancement]  Field isn't final but should be [EventMeshTcpRetryer]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
org/apache/eventmesh/runtime/core/protocol/tcp/client/session/retry/EventMeshTcpRetryer.java line 36
analysis and explanation:
This static field public but not final, and could be changed by malicious code or by accident from another package. The field could be made final to avoid this vulnerability.
Describe the solution you'd like
add final modifier field.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@Alonexc  can you assign this to my name , i can work on it


How can i install GLVis on my MacBook Air?

Hi @TongYunzhe,
You need to install XQuarz first, if that's not installed already. Their website is http://www.xquartz.org. This should install the OpenGL headers and you should be able to compile glvis following the instructions in http://glvis.org/building.
When you use glvis as a server, the first connection will take a while because it also has to start the XQuarz app. You can avoid the wait by manually starting XQuarz before glvis.
Hope this helps,
Tzanio

It's very helpful, now i can install GLVis on my MacBook Air, thank you so much. However, when i run the glvis and example 1, the terminal displayed "Can't connect to display! Initializing the visualization failed."

It looks like we can't connect to the X window server. Did you try starting XQuarz manually first? Does it work from the command line, e.g. glvis -m ../mfem/data/start.mesh ?

it works now. thank you so much. I forgot to start XQuarz manually!~

You are welcome. Let us know if you have any further questions.


Cannot update languages - could not find an editable version for 'IOS'

New Issue Checklist

[ ] Updated fastlane to the latest version
[ ] I read the Contribution Guidelines
[ ] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Issue Description
Hi, I got an issue that is exactly this one https://github.com/fastlane/fastlane/issues/17905 but unfortunately it has been closed without any solution/explanation. (cc @brandtdaniels @tomaszpieczykolan if you have some thoughts on it I would appreciate).
When upload to the main App Store (not testflight) I get this:
[20:11:48]: Detected languages: ["default"]
[20:11:48]: Cannot find edit app store version... Retrying after 10 seconds (remaining: 4)
[20:11:59]: Cannot find edit app store version... Retrying after 10 seconds (remaining: 3)
[20:12:09]: Cannot find edit app store version... Retrying after 10 seconds (remaining: 2)
[20:12:20]: Cannot find edit app store version... Retrying after 10 seconds (remaining: 1)
[20:12:30]: Cannot find edit app store version... Retrying after 10 seconds (remaining: 0)

And the final error is:
[20:12:40]: Cannot update languages - could not find an editable version for 'IOS'

On the Fastlane script I have this:
  prepare_deploy(
    scheme: 'Production',
    remote_build_number: 4,
  )

  build_app(
    scheme: 'Production',
    export_xcargs: "-allowProvisioningUpdates",
    output_directory: buildDirectory,
  )
  upload_to_app_store(
    force: true, # Skip HTMl report verification
    skip_screenshots: true,
    skip_app_version_update: true,
    ipa: buildDirectory + 'Production.ipa',
    release_notes: {
      "default": get_changelog,
    },
    submit_for_review: true,
  )

Note that I already have a version published on the store that is fully reviewed, and I made sure the remote_build_number is different. By the way at start I made it incrementing automatically but for the test to debug the issue I set it manually.
Since there is a retry system, I guess that's not something local it tries to find. But what could be missing in my App Store dashboard 🤔  ?
Thank you in advance,
Environment

🚫 fastlane environment 🚫
Stack

Key
Value

OS
11.4

Ruby
3.0.0

Bundler?
false

Git
git version 2.30.1 (Apple Git-130)

Installation Source
~/.rvm/gems/ruby-3.0.0/bin/fastlane

Host
macOS 11.4 (20F71)

Ruby Lib Dir
~/.rvm/rubies/ruby-3.0.0/lib

OpenSSL Version
OpenSSL 1.1.1k  25 Mar 2021

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
12.5.1

Swift Version
5.4.2

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.185.0
🚫 Update available

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.5.0

executable-hooks
1.6.1

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
2.2.3

pathname
0.1.0

atomos
0.1.3

CFPropertyList
3.0.3

claide
1.0.3

colored2
3.1.2

nanaimo
0.3.0

xcodeproj
1.19.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.7.0

terminal-table
1.8.0

plist
3.6.0

public_suffix
4.0.6

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

artifactory
3.0.15

babosa
1.0.4

colored
1.2

highline
2.0.3

commander
4.6.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-net_http
1.0.1

faraday-net_http_persistent
1.1.0

ruby2_keywords
0.0.4

faraday
1.4.2

faraday-cookie_jar
0.0.7

faraday_middleware
1.0.0

gh_inspector
1.1.3

json
2.5.1

mini_magick
4.11.0

naturally
2.2.1

rubyzip
2.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.1

dotenv
2.7.6

simctl
1.6.8

jwt
2.2.3

uber
0.1.0

declarative
0.0.20

trailblazer-option
0.1.1

representable
3.1.1

retriable
3.1.2

mini_mime
1.1.0

multi_json
1.15.0

signet
0.15.0

memoist
0.16.2

os
1.1.1

googleauth
0.16.2

httpclient
2.8.3

webrick
1.7.0

google-apis-core
0.3.0

google-apis-playcustomapp_v1
0.3.0

google-cloud-env
1.5.0

google-cloud-errors
1.1.0

google-cloud-core
1.6.0

google-apis-iamcredentials_v1
0.4.0

google-apis-storage_v1
0.4.0

rake
13.0.3

digest-crc
0.6.3

google-cloud-storage
1.31.1

emoji_regex
3.2.2

tsort
0.1.0

set
1.0.1

uri
0.10.1

excon
0.82.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.4

fastimage
2.2.4

rexml
3.2.5

google-apis-androidpublisher_v3
0.5.0

aws-eventstream
1.1.1

aws-sigv4
1.2.3

aws-partitions
1.466.0

jmespath
1.4.0

aws-sdk-core
3.114.2

aws-sdk-kms
1.43.0

aws-sdk-s3
1.96.1

forwardable
1.3.2

logger
1.4.3

shellwords
0.1.0

cgi
0.2.0

date
3.1.0

timeout
0.1.1

stringio
3.0.0

openssl
2.2.0

io-nonblock
0.1.0

ipaddr
1.2.2

io-wait
0.1.0

zlib
1.1.0

resolv
0.2.0

securerandom
0.1.0

net-protocol
0.1.0

digest
3.0.0

net-smtp
0.2.1

ostruct
0.3.1

english
0.7.1

erb
2.2.0

strscan
3.0.0

optparse
0.1.0

abbrev
0.1.0

io-console
0.5.6

tempfile
0.1.1

delegate
0.2.0

fileutils
1.5.0

tmpdir
0.1.1

base64
0.1.0

time
0.1.0

singleton
0.1.1

open3
0.1.1

nkf
0.1.0

prettyprint
0.1.0

pp
0.1.0

find
0.1.0

yaml
0.1.1

psych
3.3.0

open-uri
0.1.0

mutex_m
0.1.1

generated on: 2021-07-10

EDIT: cannot retry for a few days but I'm wondering if it could come from the:
skip_app_version_update | Don’t create or update the app version that is being prepared for submission

I set to true

Hi @sneko  I think that you've found a reason for it. You currently see on Appstore connect one live version of the app and there is no edit version in Prepare for submission state. When you set skip_app_version_update to true, new edit version cannot be created. If you set it to false, all should be fine.

Oh great @lucgrabowski ! Thank you for the answer 🎆
I won't be able to test it within 8 days (no more Macbook ^^), but will close the issue ASAP after succeeding to upload a new version :)
Thanks!


[JMS] The destination property in a topic subscriber does not work

Following is the code.
Broker : WSO2 MB
Release : 0.88 (08/06/2017)
@jms:JMSSource {
    factoryInitial:"org.wso2.andes.jndi.PropertiesFileInitialContextFactory",
    providerUrl:"file:///home/dilinig/Documents/Ballerina/samples/jms/jndi.properties"}
@jms:ConnectionProperty {key:"connectionFactoryType", value:"topic"}
@jms:ConnectionProperty {key:"destination", value:"MyTopic1"}
@jms:ConnectionProperty {key:"useReceiver", value:"true"}
@jms:ConnectionProperty {key:"concurrentConsumers", value:"1"}
@jms:ConnectionProperty {key:"connectionFactoryJNDIName", value:"TopicConnectionFactory"}
@jms:ConnectionProperty {key:"sessionAcknowledgement", value:"CLIENT_ACKNOWLEDGE"}

Issues

If the destination property is completely removed (as it is an optional parameter), the service will not be started
If the value of the destination property is changed, the service will not be started and a new topic from that name is not created.

This is to track: https://github.com/ballerinalang/ballerina/issues/2528


Add kept check cmd

Mark shared this repo during the last release and I like the idea of automating some of the KEP checks the enhancement team has to do to validate an enhancement. This just adds a kept check command that validates the yaml in a provided KEY vs the template on main. Let me know what you think @salaxander !
Failed check example:
❯ _output/kept-darwin-amd64 check -r v1.23 -s alpha  --url  https://raw.githubusercontent.com/kubernetes/enhancements/master/keps/sig-storage/3333-reconcile-default-storage-class/kep.yaml

❌  stage 'stage' is not set to 'alpha' in KEP yaml.
❌  release 'v1.25' is not set to 'v1.23' in KEP yaml.
✅  correct status set in KEP yaml
Finished KEP checks

Success check example:
❯ _output/kept-darwin-amd64 check -r v1.26 -s beta --url  https://raw.githubusercontent.com/kubernetes/enhancements/master/keps/sig-storage/3333-reconcile-default-storage-class/kep.yaml

✅  correct stage set in KEP yaml
✅  correct milestone set in KEP yaml
✅  correct status set in KEP yaml
Finished KEP checks

This is very cool! Thanks @npolshakova!


[1.4.1] CCTweaks Pre-init crash (modem class missing?)

https://pastebin.com/LT75PqEE
CC Tweaks: 1.4.1
Plethora: 1.1.6
Computercraft: 1.80pr0-2017052315
As you can see, I'm using the latest (as of this post) dev build of CC. Is that relevant to this crash?

A lot of CCTweaks has been (or is in the process of) merged into "actual" ComputerCraft. This has resulted in the equivalent features in CCTweaks breaking (hence your crash here). As CC's code base is still in flux, I don't really want to make a release of CCTweaks - it is likely it would be broken again in a couple of days.
In short, I'm not going to fix this now - I'm waiting for an official release of ComputerCraft before attempting anything.


Issue with web editor

Description

I keep on getting this error while using luck perms web editor:
There was an error loading the data. Either the URL was copied wrong or the session has expired.
Please generate another editor session with /lp editor.
Reproduction steps

In the Console I wrote lp editor and it gave me a link and I followed it. It said loading and then this error message several times for the past 24 hours

Open the config.yml file and set example to true.
Restart the server
Run /lp user example permission set x from the console
See error

Expected behaviour

The web editor should have opened up but it didn't
Environment details

Server version 1.16.4 - Spigot

Server type/version: ExampleSpigot running version 1.12.2 build ???
LuckPerms version: v???

Any other relevant details

If you have ad blockers and/or antivirus, try disabling all of them. If you can, test with another wireless network like using your cellular service instead if home network etc.
This issue you face is usually just down to your network setup and most of the time, there isn't much luckperms can do about it.

Please fill out the last section of the issue template. These are important pieces information.

If you have ad blockers and/or antivirus, try disabling all of them. If you can, test with another wireless network like using your cellular service instead if home network etc.
This issue you face is usually just down to your network setup and most of the time, there isn't much luckperms can do about it.

Let me try that now thanks for that suggestion

Thanks guys I solved it buy using mobile data instead of my wifi


Support non-lifetime binders

Makes it so we stop yeeting non-lifetime binders into the void. Rustfmt already generally supports formatting ast::GenericParam anyways, so this just is piggybacking on that formatting.
Fixes #5721

Thanks!

rustfmt doesn't seem to break lengthy higher-ranked parameter lists (ones that contain long binder names or lots of bounds) into multiple lines yet though at least according to my limited testing.
Slightly unrelated since this seems to concern (the stable) lifetime binders, too. Just something I've noticed. Might require a style edition though.

rustfmt doesn't seem to break lengthy higher-ranked parameter lists (ones that contain long binder names or lots of bounds) into multiple lines yet though at least according to my limited testing.

@fmease it would be great if you could open up a new issue and provide some example code snippets that the team can use to investigate.


403 On Search

Sadly im getting a 403, and its not being caught.

That's not so good. Thanks for bringing it to my attention. I'll take a look at it when I have the time. If you need this fixed soon, submit a PR.

NP, ill look at it soon, have another problem that came up after that :-1:

I was digging around in the code, trying to figure out why I couldn't get it to work. Found I was getting a 403 error returned in the XML from Google CSE, so I added just enough code to catch it. #11
In reading through Google's docs, it seems that my biggest issue is that I need to pay them instead of using the free version:

Use the Google WebSearch service to retrieve results in XML format. (Note: This service is available only to customers of Google Site Search.)


Create a container step throws an error

Error:
The request may be blocked by network rules of storage account. Please check network rule set using 'az storage account show -n accountname --query networkRuleSet'.
If you want to change the default action to apply when no rule matches, please use 'az storage account update'.

console commands
PS C:\GitHub\PossumLab-Results-Uploader\src> az storage account create `
     -n possumlabsblobtest `
     --resource-group TestResultUploader-Ci-rg `
     --location centralus `
     --sku Standard_ZRS `
     --encryption-services blob

works.
PS C:\GitHub\PossumLab-Results-Uploader\src> az storage container create `
     --account-name possumlabsblobtest `
     --name blobcontainertest `
     --auth-mode login

The request may be blocked by network rules of storage account. Please check network rule set using 'az storage account show -n accountname --query networkRuleSet'.
If you want to change the default action to apply when no rule matches, please use 'az storage account update'.

debugging
PS C:\GitHub\PossumLab-Results-Uploader\src> az storage account list --output table
AccessTier    CreationTime                      EnableHttpsTrafficOnly    Kind       Location    Name                 PrimaryLocation    ProvisioningState    ResourceGroup             StatusOfPrimary    SecondaryLocation    StatusOfSecondary

Hot           2020-04-25T03:13:25.967135+00:00  True                      StorageV2  centralus   possumlabsblobtest   centralus          Succeeded            TestResultUploader-Ci-rg  available

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b7631ff-af60-5ab4-ac8b-d44f615308b3
Version Independent ID: a661d456-bf6a-5061-391e-fe7b54b9a01f
Content: Quickstart - Create a blob with Azure CLI - Azure Storage
Content Source: articles/storage/blobs/storage-quickstart-blobs-cli.md
Service: storage
Sub-service: blobs
GitHub Login: @tamram
Microsoft Alias: tamram

This will be a public repo so not worried about any of the info in here.
more info
PS C:\GitHub\PossumLab-Results-Uploader\src> az storage account show -n citestresults --query networkRuleSet
{
"bypass": "AzureServices",
"defaultAction": "Allow",
"ipRules": [],
"virtualNetworkRules": []
}

with --debug it looks like there is a 403 returned.
Getting data service client service_type=BlockBlobService
azure.multiapi.storage.v2018_11_09.common.storageclient : Client-Request-ID=6b6e1228-86a7-11ea-9011-c49ded1ba199 Outgoing request: Method=PUT, Path=/blobcontainertest, Query={'restype': 'container', 'timeout': None}, Headers={'x-ms-blob-public-access': None, 'x-ms-version': '2018-11-09', 'User-Agent': 'Azure-Storage/2.0.0-2.0.1 (Python CPython 3.6.6; Windows 10) AZURECLI/2.4.0 (MSI)', 'x-ms-client-request-id': '6abae45e-86a7-11ea-890a-c49ded1ba199', 'x-ms-date': 'Sat, 25 Apr 2020 03:47:00 GMT'}.
urllib3.connectionpool : Starting new HTTPS connection (1): possumlabsblobtest.blob.core.windows.net:443
urllib3.connectionpool : https://possumlabsblobtest.blob.core.windows.net:443 "PUT /blobcontainertest?restype=container HTTP/1.1" 403 246
azure.multiapi.storage.v2018_11_09.common.storageclient : Client-Request-ID=6b6e1228-86a7-11ea-9011-c49ded1ba199 Receiving Response: Server-Timestamp=Sat, 25 Apr 2020 03:47:01 GMT, Server-Request-ID=3f63bb03-601e-0027-0eb4-1ada17000000, HTTP Status Code=403, Message=This request is not authorized to perform this operation., Headers={'content-length': '246', 'content-type': 'application/xml', 'server': 'Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0', 'x-ms-request-id': '3f63bb03-601e-0027-0eb4-1ada17000000', 'x-ms-version': '2018-11-09', 'x-ms-error-code': 'AuthorizationFailure', 'date': 'Sat, 25 Apr 2020 03:47:01 GMT'}.
azure.multiapi.storage.v2018_11_09.common.storageclient : Client-Request-ID=6b6e1228-86a7-11ea-9011-c49ded1ba199 Operation failed: checking if the operation should be retried. Current retry count=0, Server-Timestamp=Sat, 25 Apr 2020 03:47:01 GMT, Server-Request-ID=3f63bb03-601e-0027-0eb4-1ada17000000, HTTP status code=403, Exception=This request is not authorized to perform this operation. ErrorCode: AuthorizationFailureAuthorizationFailureThis request is not authorized to perform this operation.RequestId:3f63bb03-601e-0027-0eb4-1ada17000000Time:2020-04-25T03:47:01.7924607Z.
azure.multiapi.storage.v2018_11_09.common.storageclient : Client-Request-ID=6b6e1228-86a7-11ea-9011-c49ded1ba199 Retry policy did not allow for a retry: Server-Timestamp=Sat, 25 Apr 2020 03:47:01 GMT, Server-Request-ID=3f63bb03-601e-0027-0eb4-1ada17000000, HTTP status code=403, Exception=This request is not authorized to perform this operation. ErrorCode: AuthorizationFailureAuthorizationFailureThis request is not authorized to perform this operation.RequestId:3f63bb03-601e-0027-0eb4-1ada17000000Time:2020-04-25T03:47:01.7924607Z.
cli.azure.cli.core.util :

@BasHamer Thanks for your comment. We will review your issue and get back to you shortly.

@Thank s for bringing this to our attention, I have assigned the issue to the content author to investigate further and update the document as appropriate.

I got past it using a storage account key
`Write-Host "////// storage account key"
$saKeys =az storage account keys list -g "$($group)" -n "$($storage)" | ConvertFrom-Json
$saKey = $saKeys[0].Value
Write-Host "////// storage account key"
Write-Host "saKey: $($saKey)"
$containerCreate = az storage container create     --n "$($blob)"
--account-name "$($storage)" 	--account-key "$($saKey)" | ConvertFrom-Json"

@BasHamer  We would like to work closer on this issue!I would recommend you to contact support, so If you have a support plan, I request you file a support ticket, else please do let us know, we will try and help you get a one-time free technical support. In this case, could you send an email to AzCommunity[at]Microsoft[dot]com referencing this thread as well as your subscription ID. Please mention "ATTN subm" in the subject field. Thank you for your cooperation on this matter and look forward to your reply.

errr... I assume this is an automated message selling a service.
I worked around this issue, posted my workaround on the 28th of April. I would still recommend that the documentation is updated so that following the steps in the documentation generates the results described in the documentation. I believe that is why you assigned it to the other person on the 28th of April.
Whether you do or don't that is completely up to you, I do not intend to pay for the documentation updates.

@BasHamer - The documentation is correct as written. And I am unable to reproduce your issue.
However, I did find this SO issue, reporting the same problem:
https://stackoverflow.com/questions/61397786/network-rules-of-storage-account-blocking-container-creation
The fact that you were able to "work around" this error by using the account key instead of --auth-mode login suggests that perhaps your RBAC permissions are not configured properly. The response on the SO issue suggests the same, but there's no follow up there.
So please check your RBAC assignment and make sure that you have Storage Blob Data Contributor permissions scoped to the storage account or above.
If that is indeed the problem, then this sounds like a potential issue with the CLI, as that is not a helpful error message. Please report back here on your RBAC permissions, and I will raise the issue to the CLI team.
I will also add a note to the documentation to remind users to assign Storage Blob Data Contributor to themselves in order to create the container using Azure AD credentials.

Awesome, I was not aware from the initial response that this was an issue on my side. Thanks for the info.
here is my setup:

Please note that I hid some stuff, the email does have a capital letter in it, so I made sure to repeat that. I also blanked out Id's nothing else. I can provide the Id's if needed, I did check that the email was the same and the same capitalization.

PS C:\Users\xxx> az account list
[
{
"cloudName": "AzureCloud",
"homeTenantId": "xxx",
"id": "xxx",
"isDefault": true,
"managedByTenants": [],
"name": "Pay-as-you-go",
"state": "Enabled",
"tenantId": "xxx",
"user": {
"name"<EMAIL_ADDRESS>"type": "user"
}
}
]
PS C:\Users\xxx> az role assignment list --assignee<EMAIL_ADDRESS>Cannot find user or service principal in graph database for<EMAIL_ADDRESS>If the assignee is an appId, make sure the corresponding service principal is created with 'az ad sp create --id<EMAIL_ADDRESS>I tried the last command with my id as well and that did not change the response.

@BasHamer - When you run az role assignment list with your user ID, you should be getting back something that looks like this:

If you don't see the Storage Blob Data Contributor role, then you won't be able to create the container. Did you try the instructions that I referenced above to assign that role to yourself? You can also use the portal to assign the role to yourself.
And I am not familiar with the error message you are getting - it's coming from Azure AD/Microsoft Graph, not Azure Storage. But it seems to be saying that the user or service principal you are referencing is not a known entity. If that's true, then you won't be able to use Azure AD credentials for these operations.

yeah curious, I see the user in az account list (there is only one) but it does not exist at all in az role assignment list. I wonder if part of my account is not set up right :/
The account is from Dec 1 2018 and started as an azure free account. Maybe it is time to create a new account and start fresh :/
I tried the commands below and that failed.
PS C:\Users\xxx> az role assignment create --role "Storage Queue Data Reader" --assignee<EMAIL_ADDRESS>--resource-group xxx
Cannot find user or service principal in graph database for<EMAIL_ADDRESS>If the assignee is an appId, make sure the corresponding service principal is created with 'az ad sp create --id<EMAIL_ADDRESS>so yeah it might be time for a new account :)

@BasHamer - I hope you were successful in getting this to work with your new account.
The Azure CLI team is investigating whether the error message can be improved in this case.
Feel free to let us know if you have further issues. I'm closing this issue for now.
#please-close

I experienced the exact same issue. Turns out, it was the RBAC role assignments that hadn't been properly propagated, as is warned about in this document:

RBAC role assignments may take a few minutes to propagate.

I tried this command several times, and it failed with a 403 every time, until suddenly, it didn't:
az storage container create --subscription $SUBSCRIPTION_NAME --name $STORAGE_CONTAINER_NAME --account-name $STORAGE_ACCOUNT_NAME --auth-mode "login" --debug

I didn't change anything, it just worked after running the command many, many times.

By the way, this is the original error message:

The request may be blocked by network rules of storage account. Please check network rule set using 'az storage account
show -n accountname --query networkRuleSet'.
If you want to change the default action to apply when no rule matches, please use 'az storage account update'.

Notice that it mentions nothing about a 403. I only noticed that after reading @BasHamer's comment, and noticed I was getting the same error when running with the --debug flag:

... HTTP status code=403, Exception=This request is not authorized to perform this operation. ErrorCode: Au
thorizationFailure...

So yeah. If it hadn't been for @BasHamer posting this issue, I probably would have given up and used --auth-mode key to create the container, which this guide suggests. Notice, however, that other documentation refers to --auth-mode key as "legacy" and "less secure", and should thus be avoided.
I think the documentation should be updated to reflect this, and ideally, the RBAC propagation should be improved, so that these errors do not occur. Maybe add something like a --wait-until-propagated flag to the az role assignment create command?


Can't find on crates.io

Hi,
I really like this package compared to some others I found. However, I can't seem to find it on crates.io and I wanted to make sure that I somehow didn't skip over it.
Is this package on crates.io?

Hi, the package is not on crates.io

Would you like to publish it so others can find it?

Currently it is what stops me from installing it

cargo install --git https://github.com/yaa110/cb

Some workplaces only allow mirrors of major package repositories, meaning installing from git is not possible if one wants to use this package.
Still, I'll leave it to the author if he wants to publish it to crates.io


showDateRangePicker does not use onPrimary as the header text colour when using a dark theme

Steps to Reproduce

Create a dark theme app with a light primary colour.
Set onPrimary in colorScheme as a dark colour (to contrast with the light primary colour).
Call showDateRangePicker.

Expected results:
Date range picker would use colorScheme.onPrimary as the text colour in the header to contrast with primary colour used as the background for the header.
Actual results:
Date range picker uses colorScheme.onSurface as the text colour for the header, which is invisible on the light primary colour. In fact, it seems to be impossible to get a sensible colour for all parts of the dateRangePicker in this situation, since setting colorScheme.onSurface to a dark colour that shows up on the header will also make the text dark on the body of the date range picker.
This is not the case for light themes, which use onPrimary as the header text colour as they're supposed to.
Setting colorScheme.onPrimary to a dark colour:

Setting colorScheme.onSurface to a dark colour:

Logs

[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.22000.100], locale en-CA)
    • Flutter version 2.2.3 at D:\Portable Programs\flutter
    • Framework revision f4abaa0735 (5 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at D:\Android_SDK
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.10.3)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.10.31424.327
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Ultimate Edition (version 2021.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2021.1.3
    • Flutter plugin version 59.0.4
    • Dart plugin version 212.4746.57

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22000.100]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 91.0.4472.124
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 92.0.902.55

• No issues found!

Code
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        brightness: Brightness.dark,
        primaryColor: Colors.white,
        colorScheme: ColorScheme.dark().copyWith(onPrimary: Colors.black)
      ),
      home: Scaffold(
        appBar: AppBar(
          title: Text("Test"),
        ),
        body: Column(children: [ShowDatePickerButton()],),
      ),
    );
  }
}

class ShowDatePickerButton extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialButton(
      onPressed: () {
        showDateRangePicker(
          context: context,
          firstDate: DateTime(2020),
          lastDate: DateTime.now(),
          builder: (context, child) => Column(
            children: [
              Container(
                child: child!,
                constraints: BoxConstraints(maxWidth: 500, maxHeight: 500),
              ),
            ],
            mainAxisAlignment: MainAxisAlignment.center,
          ),
        );
      },
      child: Text("Pick date range"),
    );
  }
}

Hi @Zarainia, Thanks for filing the issue, I am able to replicate the issue on the latest stable and the master channel.

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (4 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.164

• No issues found!

[✓] Flutter (Channel master, 2.5.0-2.0.pre.69, on macOS 11.4 20F71 darwin-arm, locale en-GB)
    • Flutter version 2.5.0-2.0.pre.69 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ccf6f0353a (10 minutes ago), 2021-07-29 01:50:54 -0700
    • Engine revision 40451453ab
    • Dart version 2.14.0 (build 2.14.0-361.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.58.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (4 available)
    • sdk gphone arm64 (mobile)  • emulator-5554                        • android-arm64  • Android 11 (API 30) (emulator)
    • iPhone 12 Pro Max (mobile) • 6A434744-B348-4FB3-AB10-131292174456 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-4
      (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 92.0.4515.107

• No issues found!

CC @darrenaustin

I've been experiencing the same issue, it seems the AppBarTheme colour can be used to modify the header, but all the colours for text are still a bit off

I fixed my issue by using the code snippet below, by using the builder option to override some of the colours, helping to make the colours readable. It's not ideal but a possible workaround
DateTimeRange? pickedRange = await showDateRangePicker(
  context: context,
  initialDateRange: currentDateRange,
  firstDate: DateTime(1950),
  lastDate: DateTime(2100),
  builder: (context, Widget? child) => Theme(
    data: Theme.of(context).copyWith(
        dialogBackgroundColor:
            Theme.of(context).scaffoldBackgroundColor,
        appBarTheme: Theme.of(context).appBarTheme.copyWith(
            iconTheme: IconThemeData(
                color: Theme.of(context).primaryColorLight)),
        colorScheme: Theme.of(context).colorScheme.copyWith(
            onPrimary: Theme.of(context).primaryColorLight,
            primary: Theme.of(context).colorScheme.primary)),
    child: child!,
  ),
);

I just tried the above code example against the latest on the master branch and it appears to be working fine:

Perhaps this was fixed with other color scheme issues that have been resolved a while back?
Are people still able to reproduce this with the latest master build?

Hi I would like to work on this. I plan to follow the material spec. If there is anything I should know before I start? @HansMuller @darrenaustin

Hi @Mayb3Nots, thanks for volunteering! I would hold off on this until we can verify if this is a still an issue (see previous comment). Also I am currently working on adding a DatePickerTheme and Material 3 support to the date picker, so any work here might overlap with that.


outside map event trigger marker

Hi Juan,
First, your project made our life so much easier!.
I got a question, like yelp.com how can I make an outside of the google map event trigger the marker on the map? any sample code would help a lot
http://screencast.com/t/evi08pijr
Thank you.

Hi @jmingli
That is a very interesting feature. Unfortunately I can not see an easy solution right now because I don't save the reference to the markers and therefore you cannot access to the markers collection out side the control.
In this moment I am working on the "layers feature" specifically on issue #29. After that one I will be glad to implement your request.
Thank for your feedback.

Hi @jmingli
I just pushed the changes to allow access to the markers collection from outside the map.
Please review the sample ExternalReference for more info.
The changes are in the dev branch. please download the latest changes and let me know your thought.

Juan,
Great, Thank you.
-Ming.
On Sun, May 24, 2015 at 9:30 AM, Juan Manuel Elosegui <
<EMAIL_ADDRESS>wrote:

Closed #35 https://github.com/jmelosegui/GooglemapMvc/issues/35.
—
Reply to this email directly or view it on GitHub
https://github.com/jmelosegui/GooglemapMvc/issues/35#event-312598910.


Allow using the mouse for all event loops.

Process mouse clicks in all event loops. Use an external module for mouse processing.
Check all instances of read_event:

[x] worldmap (WIP)
[x] cutscene
[x] showtip
[x] shop
[x] rollcredits
[x] theend
[x] action (WIP)

@cosmologicon See what you think.


looking for maintainers

We don't have enough time to catch up with LSP and Monaco changes regularly, so we would be glad a help with it. If you are interested leave a comment here.
Each maintainer is added as Admin to this project. He is free to help as it suits him in following areas:

upgrading to latest LSP and Monaco
releasing new versions (you will be added as a collaborator on npmjs with publish access right)
reviewing, testing and landing PRs
helping community, i.e. handling issues

Generally, for TypeFox it is important:

that minor releases don't break Theia, i.e. you should identify breaking changes and do a major release
big new contributions are accepted only if a contributor is ready to maintain them, i.e. a contributor should be ready to become a maintainer to help with upgrading and testing examples with new versions of LSP and Monaco; otherwise it is an unnecessary maintenance burden

@rcjsuen  @brokun @johnwiseheart @jroitgrund @gins3000 @zewa666 @gatesn mentioned you because you did contributions before, if you are not interested, sorry for bothering, just ignore it

We'd be happy to maintain it - but probably don't have the resources to keep it up to date outside of what is required by us - eg updating LSP and Monaco when we need the new versions.
Theres not a whole lot of activity here, so handling issues is probably not a huge problem.

I'd be happy to maintain this repo too. @akosyakov @johnwiseheart How do you feel about setting up a slack workspace for the project maintainers, so we can synchronize more easily?

@mofux as you negotiate with others, as far as I understood all of us have other projects to work on, so probably there won't be much chatting going on :)

I cant sadly focus on an additional OSS project due to time constraints, aka the nice way to say that my newborn son eats up all my sparetime ;)
So while I cant help out as maintainer, as part of my job my Team and I can make sure to try out PRs with our product and help out that way.

So while I cant help out as maintainer, as part of my job my Team and I can make sure to try out PRs with our product and help out that way.

@zewa666 any help is welcome, trying out is the big part of maintenance work.

@akosyakov Thank you for including me in this list, and it's good to hear that @johnwiseheart  and @mofux expressed interest in keeping this repo up, even if it is just the minimal maintenance.
Like @zewa666 , at the moment I can only offer to continue using this repo and provide "field feedback" and the occasional PR.
Good luck!

Theia dropped using of monaco-languageclient and switched completely to VS Code extensions. It means that Theia commiters won't be able to assist in the future. Existing committers with merge rights interested in new PRs please feel free to merge them. Each time new next version will be provided.

I am willing to help keeping monaco-languageclient up-to-date!

and https://github.com/TypeFox/vscode-ws-jsonrpc as well (I need to update it first)

Is it possible to get access on vscode-ws-jsonrpc as well?

@akosyakov
could you take a look https://github.com/TypeFox/monaco-languageclient/issues/164#issuecomment-721607947

@CGNonofr Could you fork please vscode-ws-jsonrpc? vscode-ws-jsonrpc is still used in Theia and we don't have capacity to retest it now. Maybe it can be even merged in this repo instead, as another package, i.e. monaco-jsonrpc

Fine, I'll take a look at vscode-jsonrpc, thanks for the tip!

@CGNonofr Could you fork please vscode-ws-jsonrpc? vscode-ws-jsonrpc is still used in Theia and we don't have capacity to retest it now. Maybe it can be even merged in this repo instead, as another package, i.e. monaco-jsonrpc
BTW latest vscode-jsonrpc seems to support web sockets too, so maybe we should use it directly now

For anyone who might be reading this (perhaps future me), vscode-jsonrpc does not appear to natively support websockets, although I'm sure it could be wired up with a little extra work. It provides the following implementations of AbstractMessageReader and AbstractMessageWriter:

ReadableStreamMessageReader
WriteableStreamMessageWriter
BrowserMessageReader
BrowserMessageWriter

The constructors for these objects don't natively accept a WebSocket type.
vscode-ws-jsonrpc on the other hand exports

WebSocketMessageReader
WebSocketMessageWriter

Which both take a WebSocket type, making them very easy to instantiate from the calling code.

I wrote an update to the state of this repository in https://github.com/TypeFox/monaco-languageclient/issues/313#issuecomment-1041232925.
This project is certainly still open to welcoming new contributors and maintainers. We want to establish a transparent open source community around it. But since there is no longer a pressing urge to find new maintainers, I'll close this issue.
Thank you @akosyakov for the initial development of this package, and thank you @CGNonofr for taking it over two years ago.


DO Guide - ERR_CONNECTION_REFUSED - CentOS 7

Hello,
So I installed code-server following this guide - https://www.digitalocean.com/community/tutorials/how-to-set-up-the-code-server-cloud-ide-platform-on-centos-7 Before proceeding onto the subdomain configuration, I wanted to ensure that it's working and to my dismay I'm only getting an ERR_CONNECTION_REFUSED in the web browser.

Web Browser: Google Chrome
Local OS: Windows 7 Professional
Remote OS: CentOS Linux release 7.8.2003 (Core)
Remote Architecture: x86_64
code-server --version: v3.4.1

At first, I'd like to mention that I've a previously running VestaCP installation on that server, so Apache and Nginx were pre-installed and running. Now, I was trying to bind code-server to port 1313, which has been opened in the firewall.
[root@sohamb03 ~]# systemctl status code-server
● code-server.service - code-server
   Loaded: loaded (/usr/lib/systemd/system/code-server.service; enabled; vendor preset: disabled)
   Active: active (running) since Fri 2020-07-10 03:03:27 EDT; 5ms ago
 Main PID: 19902 ((e-server))
   CGroup: /system.slice/code-server.service
           ‣ 19902 [(e-server)]

Jul 10 03:03:27 sohamb03.tk systemd[1]: Stopped code-server.
Jul 10 03:03:27 sohamb03.tk systemd[1]: Started code-server.

But again sudo lsof -i:1313 produces no output. :(
Here's the code-server.service file.
[Unit]
Description=code-server
After=nginx.service

[Service]
Type=simple
Environment=PASSWORD=testpass123
ExecStart=/usr/bin/code-server --bind-addr <IP_ADDRESS>:1313 --user-data-dir /var/lib/code-server --auth password
Restart=always

[Install]
WantedBy=multi-user.target

I've checked issue #737 but doesn't seem to help either.

Are you accessing code-server directly through port 1313 or are you going through Apache or Nginx?

Ah but the lsof command producing no output is suspicious. Could you check code-server's output?

Yeah I was accessing it directly on the public IP.
Also, lsof didn't produce an output bcuz code-server was already broken at that time. As far as I guess, it's something to do with the service file cuz it works when I use code-server --bind-addr <IP_ADDRESS>:1313 manually.

I remember there seemed to be an issue with user systemd units in Centos, maybe that's what's going on. Discussion/solution here: https://github.com/cdr/code-server/issues/1747#issuecomment-639152628

I'm still getting a ERR_CONNECTION_REFUSED
Here's how my /etc/systemd/system/code-server.service file looks like now:
[Unit]
Description=code-server
After=nginx.service

[Service]
Type=simple
Environment=PASSWORD=testpass123
ExecStart=/usr/bin/code-server --bind-addr <IP_ADDRESS>:1234 --user-data-dir /var/lib/code-server --auth password
Restart=always
User=root

[Install]
WantedBy=multi-user.target

Is there any output from code-server when it runs via the systemd service? It should output the version number among a few other things.

Hmm, I don't think. It fails as soon as it starts. Here's the output:
[root@google ~]# systemctl status code-server -l
● code-server.service - code-server
   Loaded: loaded (/etc/systemd/system/code-server.service; enabled; vendor preset: disabled)
   Active: activating (auto-restart) (Result: exit-code) since Tue 2020-07-14 08:13:47 IST; 4ms ago
  Process: 1245 ExecStart=/usr/bin/code-server --bind-addr <IP_ADDRESS>:1234 --user-data-dir /var/lib/code-server --auth password (code=exited, status=203/EXEC)
 Main PID: 1245 (code=exited, status=203/EXEC)

Jul 14 08:13:47 google.tk systemd[1]: code-server.service: main process exited, code=exited, status=203/EXEC
Jul 14 08:13:47 google.tk systemd[1]: Unit code-server.service entered failed state.
Jul 14 08:13:47 google.tk systemd[1]: code-server.service failed.

Interesting, maybe that 203/EXEC has something to do with it. Some sort of issue with executing the code-server script maybe?
What if you tried launching the script directly instead of using the symlink? It should be /var/lib/code-server/bin/code-server (instead of /usr/bin/code-server).
If that doesn't work, maybe running it with Node directly will work: /var/lib/code-server/lib/node /var/lib/code-server.

Umm, I never thought about that. I'll give it a try and update you soon. :)

Umm, I never thought about that. I'll give it a try and update you soon. :)

Just change the line in service:
ExecStart=/usr/bin/code-server --bind-addr <IP_ADDRESS>:1234 --user-data-dir /var/lib/code-server --auth password

to
ExecStart=/usr/bin/code-server/code-server --bind-addr <IP_ADDRESS>:1234 --user-data-dir /var/lib/code-server --auth password

then it will work correctly.
That is because the binary file is in the directory /usr/bin/code-server/, the binary file itself also called code-sever

Going to close as there hasn't been a response in a long time!

Going to close as there hasn't been a response in a long time!


Separate Xcode project and tests for GoogleUtilities

This also needs change to if_changed.sh to trigger the Firebase builds on changes to these files.


Cache JWT token instead of calling acquireAccessToken() for every request. This causes a massive performance hit

For every call of the KustoClient execute(String command) and execute(String database, String command) a new AccessToken is requested and this token is valid for one day.
This adds about 500ms to every request
Please cache this JWT and only renew once expired.

resolved #70


!important attribute?

Hi, I have found a site that is using the !important attribute on several div containers (with obtrusive ads in them). This is causing their attributes to override any custom css I put in. For example: I want to change the visibility of an element. So I use Stylebot to change that element's "display: block !important" attribute. I want to change it to "display: none". Which Stylebot does just fine.
Now comes the problem. Stylebot seems to be unable to add it's own "!important" tag so that my CSS isn't overridden. At least, every time I have tried to use it, the tag does not save into the custom css to be injected, and the element in question pops back up as soon as Stylebot is closed.
Please add support for this attribute as its absence in Stylebot allows it to be selectively used to prevent custom css from changing an attribute, defeating the whole point of your (awesome) extension.
Thanks!

I think the fix would be to include the injected stylesheet at the end of the head tag, rather than at the start.

Stylebot appends the !important override to all of the rules it injects..
If it isn't working for some reason, it means your rule is not specific enough, or that the css being applied which won't go away is actually being injected after the page loads by means of javascript, in which case you can never override it unless you use ajax.
You can almost always override the other !important rules by prefixing your Stylebot rule with an additional class. One which makes your rule even more specific than the one it is meant to override.
In extreme cases, you could use the body tag as a prefix, or even the html tag.
This practice makes page loading times even slower than is normal when using Stylebot on its own, because if a rule lower down includes !important, it forces the browser to parse the stylesheets again to find the most specific rule.


install via go get issue

Using go 1.12, when I follow the instructions to install golint when I am within a go modules managed codebase it adds golint to the codebase which is not what I want. The readme says to run the command:
$ go get -u golang.org/x/lint/golint

This caused golint to be added to my go.mod and go.sum files when what I really wanted was the binary to be installed. This is how the behavior previously worked.

Same issue here, is there a workaround or HOWTO of how to use golint with native go modules?

Try GO111MODULE=off go get -u golang.org/x/lint/golint


Data Capture - soft keyboard of widget type 'decimal' does not have a decimal point

Describe the bug
In a questionnaire, when a field set to type 'decimal' receives focus, the soft keyboard appears but it has not decimal point to select from.
Component
SDC gallery app
To Reproduce
Steps to reproduce the behavior:

Create a questionnaire with a field with the type set to 'decimal'
Open the questionnaire in the app
Set focus on the field
The numeric soft keyboard will appear but without the decimal point

Expected behavior
A numeric keyboard should appear with a decimal point option.
Screenshots
This is what the soft keyboard looks like on a field set to type 'decimal':

This is what the soft keyboard should look like (screenshot taken from the Radio android app):

Smartphone (please complete the following information):

Device: Samsung A12
Android version: 11
Build number: RP1A.200720.012.A127FXXU4AUK1
Version: 30

Additional context
In the Data Capture Gallery app, you can view this in the "Neonate record from New South Wales, Australia" questionnaire. The birth weight field is a decimal but exhibits the same problem.
Would you like to work on the issue?
I don't know who can look into this but I would appreciate if someone looked into this as soon as possible.

i want to work on this, can please assign me ?


merge: dev to master

:tada: This PR is included in version 0.123.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Saving

Anywhere with save icon needs some sort of confirmation like change in icon to inactive or message.

there is actually a message in the status bar, but i can make some spinner if you like

because, errors will appear as popups/notification


LHN - Phone number accounts without name set are showing @Expensify.sms in group chats

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
@expensify.sms should not be visible in any area of the app.
Actual Result:
Phone number accounts without name set are showing @Expensify.sms in LHN
Action Performed:

Create and account in e.cash with a Phone number
Do not set a name or last name in the account.
Log in as another account
Create a new group chat that includes the phone number account.

Workaround:
No need, visual issue.
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.50-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @parasharrajat https://expensify.slack.com/archives/C01GTK53T8Q/p1621543024075700

LHN Is showing @expensify.sms in Names.

Tested and found this too:

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@timszot can this be worked on by a Contributor? (my guess is no but wanted to double check)

Actually, yeah, this should be able to be done by contributors.

Triggered auto assignment to @mitchexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

I have handled it in the https://github.com/Expensify/Expensify.cash/pull/3021. Let me know if you want me create a separate PR for this. Thanks.

@MitchExpensify Just pinging to tell that I have fixed this issue https://github.com/Expensify/Expensify.cash/pull/3021 here.


add social media links, symbols and update footer

social media links and symbols are not present which is a really important part and all the content in footer is adjust vertically, it will look better if it is horizontal.

hey @apu52, please assign this to me, thank you.

@apu52 Please assign this issue to me

@dnyandeepchute assign this to me

@dnyandeepchute this issue has already been assigned to another contributor previously . & want to suggest you to pls use proper issue templates to raise the issues.