Findbugs

Changed the java version.
Enabled the findbugs.
I see in the build output:
Java version: 1.7.0_79, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0\jre
Default locale: en_US, platform encoding: UTF-8
OS name: "windows server 2012 r2", version: "6.3", arch: "amd64", family: "windows"
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8
java -version
java version "1.7.0_79"
Java(TM) SE Runtime Environment (build 1.7.0_79-b15)
So i just specify the java version in the pom.xml.

@sebing Let me find a reviewer for this pull request, thanks for submitting it

@mkordas it's yours,please review

@sebing I'm on it

@sebing please fix the build

@sebing this PR is about FindBugs, why you have some commits with Checkstyle here?

@sebing please link original issue in PR description

@sebing please see couple of comments above

@mkordas I am trying to fix the build
I am getting a compilation error.
[WARNING] /C:/projects/takes/src/main/java/org/takes/rs/RsVelocity.java:[161,50] Possible heap pollution from parameterized vararg type java.util.Map.Entry<java.lang.CharSequence,java.lang.Object>
[WARNING] /C:/projects/takes/src/main/java/org/takes/facets/auth/PsByFlag.java:[128,43] Possible heap pollution from parameterized vararg type java.util.Map.Entry<java.util.regex.Pattern,org.takes.facets.auth.Pass
[ERROR] /C:/projects/takes/src/main/java/org/takes/rs/RsVelocity.java: warnings found and -Werror specified
Should I raise another puzzle?

@mkordas I am not sure about the Checkstyle here. Did i screw up with the merge request? (The diffs looks okay though)

@sebing we need to fix those, we shouldnt leave project in that state

@mkordas I am fixing them

@sebing please let me know if you need any help with fixing those

@mkordas  I think, i need some help.
RsVelocity.java is not having any problem related to java7. this class is compiling locally fine

@mkordas I will convert the CharSequence into strings.

@sebing how do you compile project locally?

@sebing

Did i screw up with the merge request? (The diffs looks okay though)

Yes, diff looks OK, but we should clean up the commits. Can you do interactive rebase and skip all not-relevant commits? I can help with Git commands if needed.

@mkordas I misunderstood the problem. It is not a compilation of java.
I am trying to understand the problem with findbugs and charsequence. If you can give a direction in this regard, it will be greatfull

@sebing from the logs above I see that it is about compilation warnings that are prohibited in jcabi projects. Are you still talking about those or there's new problem?

@sebing

I will convert the CharSequence into strings

Can you tell me about which class and which line you are talking about?

@mkordas  I am talking about same log.
What i understand is, the find bug will convert the warning into error, that is the reason the build fails.
This is the code which fails
private static Map<CharSequence, Object> asMap(         final Map.Entry<CharSequence, Object>... entries) {         final ConcurrentMap<CharSequence, Object> map =             new ConcurrentHashMap<CharSequence, Object>(entries.length);         for (final Map.Entry<CharSequence, Object> ent : entries) {             map.put(ent.getKey(), ent.getValue());         }         return map;

@sebing I will take a look, but can you please format your code correctly?
You need to put it into triple backticks.

@mkordas RsVelocity.asMap is giving the problem

@sebing

What i understand is, the find bug will convert the warning into error

No, it's not FindBugs that convert warnings into errors. It's just our custom compiler configuration used in all Teamed.io projects. We don't want any warnigs, so we turned them into errors to fail the build and demand fixing them.

@sebing

RsVelocity.asMap is giving the problem

Have you read that Stack Overflow question?

@mkordas Thanks.
I added the @SafeVarargs.

@mkordas Regarding the merge problems. I think the problem was, I modified my master fork and made a pull request() which is not accepted yet. I was not aware of the system(we work with lot of tasks).
How can we fix them?

@sebing

regarding the merge problems. I think the problem was, I modified my master fork and made a pull request() which is not accepted yet. I was not aware of the system(we work with lot of tasks).
How can we fix them?

Yeah, you should begin working on each issue with fresh branch created from master. But still we can fix this pull request. Just invoke git rebase origin/master --interactive and skip not relevant commits

@mkordas  I will be back in few hours.(thanks for all your help)

@sebing

I added the @SafeVarargs.

Right, I think it's good approach here. That warning it's kind of new feature of Java 7, please see
http://docs.oracle.com/javase/7/docs/technotes/guides/language/non-reifiable-varargs.html

@sebing

I will be back in few hours.(thanks for all your help)

You're welcome, just ping me when you'll be back, and I'll do code review in the meantime.

@sebing BTW, the code in https://github.com/yegor256/takes/pull/552#issuecomment-176868759 is sill not correctly formatted. Please use that syntax:
```java
code goes here
```

@sebing The build has just failed with the following result:
[WARNING] FindBugs: L B RR: org.takes.tk.TkReadAlways.act(Request) ignores result of java.io.InputStream.skip(long)  At TkReadAlways.java:[line 64]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqWithBody$1.body(): String.getBytes()  At RqWithBody.java:[line 56]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in new org.takes.facets.auth.codecs.CcXOR(Codec, String): String.getBytes()  At CcXOR.java:[line 58]
[WARNING] FindBugs: M B RR: org.takes.http.Options.socket() ignores result of java.io.Reader.read(char[])  At Options.java:[line 121]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.http.Options.socket(): new java.io.InputStreamReader(InputStream)  At Options.java:[line 115]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.http.Options.socket(): new java.io.OutputStreamWriter(OutputStream)  At Options.java:[line 130]
[WARNING] FindBugs: L B Se: The field org.takes.HttpException.status is transient but isn't set by deserialization  In HttpException.java
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsPrint.print(): new String(byte[])  At RsPrint.java:[line 80]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsPrint.printBody(): new String(byte[])  At RsPrint.java:[line 91]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsPrint.printHead(): new String(byte[])  At RsPrint.java:[line 103]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsPrint.printHead(OutputStream): new java.io.OutputStreamWriter(OutputStream)  At RsPrint.java:[line 124]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in new org.takes.rq.RqFake(List, CharSequence): String.getBytes()  At RqFake.java:[line 92]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsXSLT$InClasspath.resolve(String, String): new java.io.InputStreamReader(InputStream)  At RsXSLT.java:[line 256]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in new org.takes.rs.RsSimple(Iterable, String): String.getBytes()  At RsSimple.java:[line 51]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqLive.parse(InputStream): new String(byte[])  At RqLive.java:[line 87]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqLive.newHeader(Opt, ByteArrayOutputStream): new String(byte[])  At RqLive.java:[line 134]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqLive.legalCharacter(Opt, ByteArrayOutputStream, Integer): new String(byte[])  At RqLive.java:[line 154]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.codecs.CcPlain.encode(Identity): String.getBytes()  At CcPlain.java:[line 62]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.codecs.CcPlain.decode(byte[]): new String(byte[])  At CcPlain.java:[line 67]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in new org.takes.rs.RsWithBody(Response, CharSequence): String.getBytes()  At RsWithBody.java:[line 90]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqPrint.print(): new String(byte[])  At RqPrint.java:[line 63]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqPrint.printHead(): new String(byte[])  At RqPrint.java:[line 84]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqPrint.printHead(OutputStream): new java.io.OutputStreamWriter(OutputStream)  At RqPrint.java:[line 94]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqPrint.printBody(): new String(byte[])  At RqPrint.java:[line 111]
[WARNING] FindBugs: L B Se: The field org.takes.facets.forward.RsForward.origin is transient but isn't set by deserialization  In RsForward.java
[WARNING] FindBugs: H M JLM: Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.takes.rs.RsGzip.make()  At RsGzip.java:[line 85]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.RqAuth.identity(): String.getBytes()  At RqAuth.java:[line 79]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.RqWithAuth.make(Identity, String, Request): new String(byte[])  At RqWithAuth.java:[line 111]
[WARNING] FindBugs: H M JLM: Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.takes.rq.RqForm$Base.map()  At RqForm.java:[line 159]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqForm$Base.map(): new String(byte[])  At RqForm.java:[line 164]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.http.BkBasic.failure(Throwable, int): new java.io.PrintWriter(OutputStream)  At BkBasic.java:[line 123]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.fallback.FbLog4j.log(RqFallback): new java.io.PrintWriter(OutputStream)  At FbLog4j.java:[line 69]
[WARNING] FindBugs: H M JLM: Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.takes.facets.forward.TkForward$Safe.load()  At TkForward.java:[line 110]
[WARNING] FindBugs: M B FS: Format string should use %n rather than \n in org.takes.rq.RqMultipart$Base.buildRequests(Request)  At RqMultipart.java:[line 216]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqMultipart$Base.buildRequests(Request): String.getBytes()  At RqMultipart.java:[line 216]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqMultipart$Base.make(byte[]): String.getBytes()  At RqMultipart.java:[line 249]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.PsBasic.enter(Request): new String(byte[])  At PsBasic.java:[line 84]
[WARNING] FindBugs: M B RV: Exceptional return value of java.io.File.delete() ignored in org.takes.http.MainRemote.exec(MainRemote$Script)  At MainRemote.java:[line 86]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.http.MainRemote.port(File): new String(byte[])  At MainRemote.java:[line 145]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.PsCookie.enter(Request): String.getBytes()  At PsCookie.java:[line 103]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.PsCookie.exit(Response, Identity): new String(byte[])  At PsCookie.java:[line 117]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.fallback.FbSlf4j.log(RqFallback): new java.io.PrintWriter(OutputStream)  At FbSlf4j.java:[line 78]
[WARNING] FindBugs: H M JLM: Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.takes.rs.RsPrettyXML.make()  At RsPrettyXML.java:[line 102]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.facets.auth.social.PsTwitter.fetch(): String.getBytes()  At PsTwitter.java:[line 177]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.xe.RsXembly.render(Node, XeSource): new java.io.OutputStreamWriter(OutputStream)  At RsXembly.java:[line 149]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rq.RqMultipart$Fake.fakeStream(Request[]): String.getBytes()  At RqMultipart.java:[line 473]
[WARNING] FindBugs: H M JLM: Synchronization performed on java.util.concurrent.CopyOnWriteArrayList in org.takes.rs.RsPrettyJSON.make()  At RsPrettyJSON.java:[line 90]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in new org.takes.rs.RsVelocity(CharSequence, RsVelocity$Pair[]): String.getBytes()  At RsVelocity.java:[line 83]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsVelocity.render(InputStream, Map): new java.io.InputStreamReader(InputStream)  At RsVelocity.java:[line 145]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsVelocity.render(InputStream, Map): new java.io.OutputStreamWriter(OutputStream)  At RsVelocity.java:[line 139]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsXSLT.transform(TransformerFactory, InputStream): new java.io.OutputStreamWriter(OutputStream)  At RsXSLT.java:[line 157]
[WARNING] FindBugs: H I Dm: Found reliance on default encoding in org.takes.rs.RsXSLT.transform(TransformerFactory, InputStream): new java.io.InputStreamReader(InputStream)  At RsXSLT.java:[line 152]
[WARNING] FindBugs: L P SIC: The class org.takes.http.FtCLI$3 could be refactored into a named _static_ inner class  At FtCLI.java:[lines 134-137]
[WARNING] FindBugs: L P SIC: The class org.takes.rq.RqMultipart$Fake$1 could be refactored into a named _static_ inner class  At RqMultipart.java:[lines 425-443]
[WARNING] FindBugs: L P SIC: The class org.takes.facets.fork.FkRegex$2 could be refactored into a named _static_ inner class  At FkRegex.java:[lines 191-202]
[WARNING] FindBugs: L P SIC: The class org.takes.http.MainRemote$1 could be refactored into a named _static_ inner class  At MainRemote.java:[lines 96-106]

FindBugs detected hell of a lot of bugs in the code :open_mouth:

@mkordas the code format is not working

@mkordas how can i test the code without pushing them locally? Is there an easy way :)

@sebing

the code format is not working

You need need to have newline after ```java

@sebing

how can i test the code without pushing them locally? Is there an easy way :)

Sure, it's very easy, please see https://github.com/yegor256/takes#how-to-contribute

@mkordas As I understand, there are 56 bugs when enabling the findbugs. There are few InputStreamReader issues. But the rest I have to do one by one. So I cannot finish them today.

@sebing please take a look, branch became unmergeable

This branch has conflicts that must be resolved

@sebing

As I understand, there are 56 bugs when enabling the findbugs. There are few InputStreamReader issues. But the rest I have to do one by one. So I cannot finish them today.

Coding should take approximately 30 min and in PR its enough to fix issue partially. For the remaining cases you can use PDD approach.

@mkordas git rebase origin/master --interactive
Now it seems I don't have my changes.

@mkordas  I don't think, I will be finishing this task in 30min :) As the 56 cases may be different.

@sebing

I don't think, I will be finishing this task in 30min :) As the 56 cases may be different.

As I wrote previously, you can use puzzle-driven development approach. Just fix three or four violations and leave the rest for others.

@mkordas But if we didn't fix them all it won't be building. Right?

@mkordas what can be the cause on mvn install
[WARNING] The requested profile "securecentral" could not be activated because it does not exist.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project takes: There are test failures.
[ERROR]
[ERROR] Please refer to c:\java\workspace\takes\target\surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test
 on project takes: There are test failures.

Please refer to c:\java\workspace\takes\target\surefire-reports for the individual test results.
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:483)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to c:\java\workspace\takes\target\surefire-reports for the individual test results.
        at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:91)
        at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:318)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:880)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:739)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        ... 20 more

@sebing

what can be the cause on mvn install

Please put logs from failing test execution, not from summary

@sebing

But if we didn't fix them all it won't be building. Right?

You can exclude some individual classes from FindBugs check and build will pass.

@sebing Please also update PR description with issue number

@sebing

Now it seems I don't have my changes.

What do you mean? For sure you have changes, your branch is ahead of master by 15 commits. Or maybe you need to use command git rebase upstream/master --interactive?

@mkordas can you help me with the merge conflict?
What I have done:

git rebase origin/master --interactive
git rebase upstream/master --interactive

$ git rebase upstream/master --interactive
Interactive rebase already started

-git rebase -i --abort

@mkordas
$ git log --decorate
commit 2427a35107f09c3f6f5a4708bc0cd6f57ff08015 (HEAD, origin/findbugs, findbugs)
Author: sxg<EMAIL_ADDRESS>Date:   Sat Jan 30 10:54:26 2016 +0000

    Find Bugs changes

commit 7651164af78e8d4da0c98927694bf0199dce39b4
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 17:29:18 2016 +0000

    @SafeVarargs

commit a845d5b7500579a81cd00c8a22f520574e842909
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 17:24:58 2016 +0000

    Type safety: Potential heap pollution via varargs parameter entries

commit 1cb4f070c89373f280c7d30161b43309b630edba
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 14:42:21 2016 +0000

    Updating review comments

commit 0f7d59e4d4e0a066220bdceff72e2b7ac6c66a1f
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 09:43:55 2016 +0000

    Revert changes

commit bd06d0a124cb40cace68309c5e9c5658e4b4f74a
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 09:42:59 2016 +0000

    revert changes

commit df9f51faa86bd2406a8b37704d56073d5f11c717
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 09:41:20 2016 +0000

    upstream file.

commit b8a2326edb46cfdd52352aa1354c46e5cb4e1ebe
Author: sxg<EMAIL_ADDRESS>Date:   Fri Jan 29 09:35:01 2016 +0000

    Enabled find bugs
    changed the java version.

commit ea2e6f3393bf1b3901c5e688a2994e0aba764969
Author: sxg<EMAIL_ADDRESS>

@sebing so what exactly does not work for you? Please be more specific

@mkordas after i push the changes, AppVeyor is not building the code.

@sebing because your branch is not mergeable with master. You need to fetch latest upstream and then you have two options: rebase on master or merge master

@sebing and of course during the merge or rebase you need to manually resolve conflicts

@mkordas I cannot find any conflicts.Even in the file changed is not having an issue.

@mkordas I cannot find a clue where the conflicts are and why AppVeyor is failing.
e058937@GH-J768P12 /c/java/workspace/takes (findbugs)
$ git fetch origin

e058937@GH-J768P12 /c/java/workspace/takes (findbugs)
$ git status
# On branch findbugs
nothing to commit (working directory clean)

@sebing the reason for that is poisonous commit bd06d0a124cb40cace68309c5e9c5658e4b4f74a - $Id should never be modified manually, otherwise the branch is not possible to be rebased anymore
What you can do, is git reset --hard origin/master, add your changes manually and then push them with force option to the same branch.

@mkordas  even that is not working. :( can i create another branch and make another pull request)?
when ever I do the rebase i have the problem.

@sebing another PR is not recommended. You don't need to do any rebase. Just reset, commit and push.

@mkordas how do i reset them?

@sebing git reset --hard origin/master

@mkordas
e058937@GH-J768P12 /c/java/workspace/takes (findbugs)
$ git status
# On branch findbugs
nothing to commit (working directory clean)

e058937@GH-J768P12 /c/java/workspace/takes (findbugs)
$ git reset --hard origin/master
HEAD is now at 17012b3 Build Error

e058937@GH-J768P12 /c/java/workspace/takes (findbugs)
$ git push origin findbugs
Username:
Password:
To https://github.com/sebing/takes.git
 ! [rejected]        findbugs -> findbugs (non-fast-forward)
error: failed to push some refs to 'https://github.com/sebing/takes.git'
To prevent you from losing history, non-fast-forward updates were rejected
Merge the remote changes (e.g. 'git pull') before pushing again.  See the
'Note about fast-forwards' section of 'git push --help' for details.

@sebing just after git reset you also need to apply the changes again. And then you need to push with force option, I don't see in your command --force. But remember, code review is not a Git school.

@mkordas sorry for all the trouble

@mkordas I have no clue.. the rebase command completely screwed the branch. I have no merge conflict in my local, but the Appveyor is not building.

@sebing yes, commits are screwed, so as I said, reset changes with --hard back to origin/master, apply all changes manualy, do ONE commit, and push with --force option. This will erase all commits in this PR except the new one.

@mkordas I am not sure what I am doing wrong. If i know what is the problem with appveyor i can google the error.
This is what I did:
$ git reset --hard origin/master
HEAD is now at 17012b3 Build Error

$ git diff origin/master

edited the pom.xml.
$ git status
# On branch findbugs
# Your branch is behind 'remotes/origin/findbugs' by 13 commits, and can be fast-forwarded.
#
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#       modified:   pom.xml
#

$ git commit -am "testing"
[findbugs 57ccf45] testing
 1 files changed, 7 insertions(+), 1 deletions(-)

$ git push origin findbugs --force
Username:
Password:
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 370 bytes, done.
Total 3 (delta 2), reused 0 (delta 0)
To https://github.com/sebing/takes.git
 + 673a130...57ccf45 findbugs -> findbugs (forced update)

$ git status
# On branch findbugs
nothing to commit (working directory clean)

As I have no clue about my problem.. ........

@mkordas I know it is my mistake.

I should not have modified the master(I didnot know that, in the start I will be working in multiple things)
I should not have rebased it :)

@sebing no worries, you don't need to use master branch of your fork. Just add https://github.com/yegor256/takes.git as upstream repo by command git remote add https://github.com/yegor256/takes.git.  Should help.

@mkordas Again I have no clue what is my problem is: is there a way to know what the problem with AppVeyor ?
$ git remote -v
origin  https://github.com/sebing/takes.git (fetch)
origin  https://github.com/sebing/takes.git (push)
upstream        https://github.com/yegor256/takes (fetch)
upstream        https://github.com/yegor256/takes (push)

Why the branch is deleted?

@mkordas this is what i did:

$ git fetch upstream
remote: Counting objects: 94, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 94 (delta 56), reused 56 (delta 56), pack-reused 35
Unpacking objects: 100% (94/94), done.
From https://github.com/yegor256/takes
6953405..48864f1  master     -> upstream/master

- ```
$ git reset --hard upstream/master
HEAD is now at 48864f1 Merge branch '__rultor'

$ git status
On branch findbugs
Your branch and 'remotes/origin/findbugs' have diverged,
and have 4 and 14 different commit(s) each, respectively.

nothing to commit (working directory clean)

- ```
$ git push origin findbugs --force
Username:
Password:
Counting objects: 162, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (80/80), done.
Writing objects: 100% (94/94), 9.69 KiB, done.
Total 94 (delta 58), reused 0 (delta 0)
To https://github.com/sebing/takes.git
 + 57ccf45...48864f1 findbugs -> findbugs (forced update)

Should i create another pull request?

@sebing

is there a way to know what the problem with AppVeyor

There is no problem with AppVeyor, believe me

Should i create another pull request?

Can't you reopen that one?

Why the branch is deleted?

Because you haven't followed my instructions, you pushed changes without any commits...

Reopen the branch

@sebing please always precede your comments with nickname of the person you are talking to and fix the commit above

@sebing I don't quite understand your approach with merging pull request on your fork... You have branch named origin/findbugs and you merge changes to findbugs. Instead, you should push directly to findbugs. origin should be just name of remote repository, not part of branch name.

@mkordas ok

@sebing please add '@mkordas' to your comment "Reopen the branch"

@mkordas I have pushed the changes.
Can you help me to identify why the travis-ci job is failing?

@mkordas  I found the issue..
ERROR: "puzzle pom.xml:360-360 has a very short description of just 6 words while a minimum of 20 is required"
I am fixing them too.

@mkordas Travis CI is failing.
Something wrong with my pdd description
INFO: "reading pom.xml..."

/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd/source.rb:144:in `rescue in puzzles': ["in /home/travis/build/yegor256/takes/pom.xml", #<PDD::Error: Space expected>] (PDD::Error)

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd/source.rb:142:in `puzzles'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd.rb:97:in `block (3 levels) in xml'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd.rb:96:in `each'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd.rb:96:in `block (2 levels) in xml'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/nokogiri-<IP_ADDRESS>/lib/nokogiri/xml/builder.rb:391:in `call'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/nokogiri-<IP_ADDRESS>/lib/nokogiri/xml/builder.rb:391:in `insert'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/nokogiri-<IP_ADDRESS>/lib/nokogiri/xml/builder.rb:375:in `method_missing'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd.rb:95:in `block in xml'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/nokogiri-<IP_ADDRESS>/lib/nokogiri/xml/builder.rb:293:in `initialize'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd.rb:93:in `new'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd.rb:93:in `xml'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/bin/pdd:90:in `<top (required)>'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/pdd:23:in `load'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/pdd:23:in `<main>'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/ruby_executable_hooks:15:in `eval'

	from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/ruby_executable_hooks:15:in `<main>'

@mkordas in my machine mvn clean install is failing
[WARNING]
[WARNING] Some problems were encountered while building the effective settings
[WARNING] Unrecognised tag: 'id' (position: START_TAG seen ...<profiles>\r\n  <id>... @183:7)  @ c:\Data\apache-maven-3.3.3\conf\settings.xml, line 183, column 7
[WARNING]
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building take 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- buildnumber-maven-plugin:1.4:create (jcabi-build-number) @ takes ---
[INFO] ShortRevision tag detected. The value is '7'.
[INFO] Executing: cmd.exe /X /C "git rev-parse --verify --short=7 HEAD"
[INFO] Working directory: c:\java\workspace\takes
[INFO] Storing buildNumber: 7801425 at timestamp: 2016-01-31T11:48:14
[INFO] Storing buildScmBranch: findbugs
[INFO]
[INFO] --- buildnumber-maven-plugin:1.4:create-timestamp (jcabi-build-number) @ takes ---
[INFO]
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ takes ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ takes ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 214 source files to c:\java\workspace\takes\target\classes
[INFO]
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ takes ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 5 resources
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ takes ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.19:test (default-test) @ takes ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.takes.facets.fallback.FbStatusTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec - in org.takes.facets.fallback.FbStatusTest
Running org.takes.facets.auth.PsBasicDefaultTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.055 sec - in org.takes.facets.auth.PsBasicDefaultTest
Running org.takes.rq.RqLengthAwareTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.061 sec - in org.takes.rq.RqLengthAwareTest
Running org.takes.facets.auth.codecs.CcSaltedTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec - in org.takes.facets.auth.codecs.CcSaltedTest
Running org.takes.facets.fork.FkTypesTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.173 sec - in org.takes.facets.fork.FkTypesTest
Running org.takes.facets.auth.PsAllTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.187 sec - in org.takes.facets.auth.PsAllTest
Running org.takes.facets.auth.PsChainTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.takes.facets.auth.PsChainTest
Running org.takes.facets.ret.RsReturnTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec - in org.takes.facets.ret.RsReturnTest
Running org.takes.facets.fork.TkForkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.201 sec - in org.takes.facets.fork.TkForkTest
Running org.takes.facets.auth.codecs.CcPlainTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec - in org.takes.facets.auth.codecs.CcPlainTest
Running org.takes.rq.RqWithBodyTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec - in org.takes.rq.RqWithBodyTest
Running org.takes.facets.auth.PsBasicTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.039 sec - in org.takes.facets.auth.PsBasicTest
Running org.takes.facets.hamcrest.HmRqHeaderTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec - in org.takes.facets.hamcrest.HmRqHeaderTest
Running org.takes.facets.auth.PsCookieTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.023 sec - in org.takes.facets.auth.PsCookieTest
Running org.takes.facets.fork.FkMethodsTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec - in org.takes.facets.fork.FkMethodsTest
Running org.takes.facets.fork.FkAnonymousTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.fork.FkAnonymousTest
Running org.takes.rs.RsWithTypeTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02 sec - in org.takes.rs.RsWithTypeTest
Running org.takes.rs.RsWithHeaderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.rs.RsWithHeaderTest
Running org.takes.rs.RsVelocityTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.198 sec - in org.takes.rs.RsVelocityTest
Running org.takes.facets.fork.FkContentTypeTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.451 sec - in org.takes.facets.fork.FkContentTypeTest
Running org.takes.rq.RqWithHeaderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.212 sec - in org.takes.rq.RqWithHeaderTest
Running org.takes.rs.RsPrintTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rs.RsPrintTest
Running org.takes.facets.fork.RqRegexTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.fork.RqRegexTest
Running org.takes.rq.RqSocketTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec - in org.takes.rq.RqSocketTest
Running org.takes.tk.TkTextTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.tk.TkTextTest
Running org.takes.facets.auth.codecs.CcXORTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.auth.codecs.CcXORTest
Running org.takes.rq.RqLiveTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.rq.RqLiveTest
Running org.takes.http.MainRemoteTest
[INFO] pool-1-thread-23 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49914 /): [200 OK] in 18ms
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.286 sec - in org.takes.http.MainRemoteTest
Running org.takes.tk.TkVersionedTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.takes.tk.TkVersionedTest
Running org.takes.misc.VerboseIteratorTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.misc.VerboseIteratorTest
Running org.takes.facets.auth.TkAuthTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.082 sec - in org.takes.facets.auth.TkAuthTest
Running org.takes.facets.fork.MediaTypesTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.takes.facets.fork.MediaTypesTest
Running org.takes.rq.RqFakeTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec - in org.takes.rq.RqFakeTest
Running org.takes.facets.fallback.FbLog4jTest
[ERROR] pool-1-thread-7 org.takes.facets.fallback.FbLog4j: GET http://www.example.com/ failed with 404: org.takes.HttpException: 404
	at org.takes.facets.fallback.RqFallback$Fake.<init>(RqFallback.java:87)
	at org.takes.facets.fallback.FbLog4jTest.logsProblem(FbLog4jTest.java:52)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec - in org.takes.facets.fallback.FbLog4jTest
Running org.takes.facets.auth.social.XeFacebookLinkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.554 sec - in org.takes.facets.auth.social.XeFacebookLinkTest
Running org.takes.rs.xe.RsXemblyTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.592 sec - in org.takes.rs.xe.RsXemblyTest
Running org.takes.rs.xe.XeTransformTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.311 sec - in org.takes.rs.xe.XeTransformTest
Running org.takes.facets.fork.FkRegexTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.fork.FkRegexTest
Running org.takes.rs.RsWithHeadersTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec - in org.takes.rs.RsWithHeadersTest
Running org.takes.misc.ConcatTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.misc.ConcatTest
Running org.takes.facets.flash.TkFlashTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.flash.TkFlashTest
Running org.takes.rq.RqPrintTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqPrintTest
Running org.takes.rq.RqCookiesTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in org.takes.rq.RqCookiesTest
Running org.takes.facets.auth.XeIdentityTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.173 sec - in org.takes.facets.auth.XeIdentityTest
Running org.takes.tk.TkRedirectTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.takes.tk.TkRedirectTest
Running org.takes.tk.TkMeasuredTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.tk.TkMeasuredTest
Running org.takes.tk.TkCORSTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.takes.tk.TkCORSTest
Running org.takes.rs.xe.XeWhenTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.617 sec - in org.takes.rs.xe.XeWhenTest
Running org.takes.tk.TkHTMLTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.takes.tk.TkHTMLTest
Running org.takes.rs.RsWithStatusTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rs.RsWithStatusTest
Running org.takes.tk.TkSlf4jTest
[INFO] pool-1-thread-23 org.takes.tk.TkSlf4j: [GET http://www.example.com/] thrown java.io.IOException("") in 0 ms
[INFO] pool-1-thread-25 org.takes.tk.TkSlf4j: [GET http://www.example.com/] returned "HTTP/1.1 200 OK" in 0 ms
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec - in org.takes.tk.TkSlf4jTest
Running org.takes.facets.fallback.FbSlf4jTest
[ERROR] pool-1-thread-25 org.takes.facets.fallback.FbSlf4j: GET http://www.example.com/ failed with 404: org.takes.HttpException: 404
	at org.takes.facets.fallback.RqFallback$Fake.<init>(RqFallback.java:87)
	at org.takes.facets.fallback.FbSlf4jTest.logsProblem(FbSlf4jTest.java:46)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.takes.facets.fallback.FbSlf4jTest
Running org.takes.facets.ret.TkReturnTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.takes.facets.ret.TkReturnTest
Running org.takes.rs.RsWithCookieTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rs.RsWithCookieTest
Running org.takes.rq.RqHeadersTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqHeadersTest
Running org.takes.rs.xe.XeAppendTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec - in org.takes.rs.xe.XeAppendTest
Running org.takes.facets.flash.RsFlashTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.takes.facets.flash.RsFlashTest
Running org.takes.facets.flash.XeFlashTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec - in org.takes.facets.flash.XeFlashTest
Running org.takes.rs.xe.XeLinkSelfTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec - in org.takes.rs.xe.XeLinkSelfTest
Running org.takes.rs.RsPrettyJSONTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec - in org.takes.rs.RsPrettyJSONTest
Running org.takes.rq.RqWithoutHeaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqWithoutHeaderTest
Running org.takes.rs.xe.XeLinkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in org.takes.rs.xe.XeLinkTest
Running org.takes.facets.auth.TkSecureTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.auth.TkSecureTest
Running org.takes.rs.xe.XeDateTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in org.takes.rs.xe.XeDateTest
Running org.takes.http.OptionsTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.http.OptionsTest
Running org.takes.facets.auth.social.PsTwitterTest
[INFO] pool-1-thread-21 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:12345 /see-FakeRequest-class): [200 HTTP OK] in 0ms
[INFO] pool-1-thread-21 com.jcabi.http.request.BaseRequest: #fetch(GET api.twitter.com /1.1/account/verify_credentials.json): [200 HTTP OK] in 0ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec - in org.takes.facets.auth.social.PsTwitterTest
Running org.takes.facets.fork.TkConsumesTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec - in org.takes.facets.fork.TkConsumesTest
Running org.takes.facets.fork.TkProducesTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.fork.TkProducesTest
Running org.takes.facets.fork.FkEncodingTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.fork.FkEncodingTest
Running org.takes.facets.fork.RsForkTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.facets.fork.RsForkTest
Running org.takes.rs.xe.XeSLATest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in org.takes.rs.xe.XeSLATest
Running org.takes.http.FtRemoteTest
[INFO] pool-1-thread-30 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49880 /): [200 OK] in 54ms
[INFO] pool-1-thread-7 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49881 /): [200 OK] in 5ms
[INFO] pool-1-thread-29 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49892 /): [200 OK] in 3ms
[INFO] pool-1-thread-14 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49897 /): [200 OK] in 4ms
[INFO] pool-1-thread-9 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49896 /): [200 OK] in 4ms
[INFO] pool-1-thread-4 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49883 /): [200 OK] in 12ms
[INFO] pool-1-thread-6 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49895 /): [200 OK] in 11ms
[INFO] pool-1-thread-12 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49885 /): [200 OK] in 9ms
[INFO] pool-1-thread-1 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49893 /): [200 OK] in 20ms
[INFO] pool-1-thread-32 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49903 /): [200 OK] in 15ms
[INFO] pool-1-thread-24 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49902 /): [200 OK] in 19ms
[INFO] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49904 /): [200 OK] in 48ms
[INFO] pool-1-thread-15 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49886 /): [200 OK] in 49ms
[INFO] pool-1-thread-18 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49907 /): [200 OK] in 47ms
[INFO] pool-1-thread-25 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49899 /): [200 OK] in 33ms
[INFO] pool-1-thread-31 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49889 /): [200 OK] in 54ms
[INFO] pool-1-thread-16 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49901 /): [200 OK] in 48ms
[INFO] pool-1-thread-8 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49884 /): [200 OK] in 47ms
[INFO] pool-1-thread-30 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49900 /): [200 OK] in 68ms
[INFO] pool-1-thread-26 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49910 /): [200 OK] in 63ms
[INFO] pool-1-thread-5 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49882 /): [200 OK] in 71ms
[INFO] pool-1-thread-23 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49887 /): [200 OK] in 74ms
[INFO] pool-1-thread-13 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49890 /): [200 OK] in 73ms
[INFO] pool-1-thread-17 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49912 /): [200 OK] in 67ms
[INFO] pool-1-thread-11 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49906 /): [200 OK] in 50ms
[INFO] pool-1-thread-28 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49909 /): [200 OK] in 80ms
[INFO] pool-1-thread-20 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49908 /): [200 OK] in 82ms
[INFO] pool-1-thread-21 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49891 /): [200 OK] in 80ms
[INFO] pool-1-thread-27 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49911 /): [200 OK] in 53ms
[INFO] pool-1-thread-19 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49894 /): [200 OK] in 56ms
[INFO] pool-1-thread-22 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49898 /): [200 OK] in 88ms
[INFO] pool-1-thread-10 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49905 /): [200 OK] in 87ms
[INFO] pool-1-thread-2 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49888 /): [200 OK] in 73ms
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.164 sec - in org.takes.http.FtRemoteTest
Running org.takes.facets.fork.MediaTypeTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.fork.MediaTypeTest
Running org.takes.rs.xe.XeLinkHomeTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in org.takes.rs.xe.XeLinkHomeTest
Running org.takes.facets.auth.social.PsLinkedinTest
[INFO] pool-1-thread-1 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49913 /uas/oauth2/accessToken): [200 OK] in 44ms
[INFO] pool-1-thread-1 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49913 /v1/people/): [200 OK] in 18ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.065 sec - in org.takes.facets.auth.social.PsLinkedinTest
Running org.takes.rs.RsPrettyXMLTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec - in org.takes.rs.RsPrettyXMLTest
Running org.takes.facets.auth.codecs.CcAESTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.101 sec - in org.takes.facets.auth.codecs.CcAESTest
Running org.takes.facets.fallback.TkFallbackTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.takes.facets.fallback.TkFallbackTest
Running org.takes.tk.TkClasspathTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.tk.TkClasspathTest
Running org.takes.facets.forward.RsForwardTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec - in org.takes.facets.forward.RsForwardTest
Running org.takes.rs.RsWithoutHeaderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.rs.RsWithoutHeaderTest
Running org.takes.tk.TkGzipTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec - in org.takes.tk.TkGzipTest
Running org.takes.facets.auth.codecs.CcStrictTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02 sec - in org.takes.facets.auth.codecs.CcStrictTest
Running org.takes.rq.RqGreedyTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqGreedyTest
Running org.takes.facets.auth.social.PsFacebookTest
[INFO] pool-1-thread-29 com.jcabi.http.request.BaseRequest: #fetch(GET graph.facebook.com /oauth/access_token): [200 HTTP OK] in 0ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.035 sec - in org.takes.facets.auth.social.PsFacebookTest
Running org.takes.facets.auth.PsByFlagTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec - in org.takes.facets.auth.PsByFlagTest
Running org.takes.facets.auth.codecs.CcGzipTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.auth.codecs.CcGzipTest
Running org.takes.misc.TransformTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.misc.TransformTest
Running org.takes.rq.RqMethodTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqMethodTest
Running org.takes.facets.auth.social.PsGithubTest
[INFO] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49918 /login/oauth/access_token): [200 OK] in 17ms
[INFO] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49918 /user): [200 OK] in 3ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.031 sec - in org.takes.facets.auth.social.PsGithubTest
Running org.takes.http.BkParallelTest
[INFO] Thread-102 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49975 /): [200 OK] in 3ms
[INFO] Thread-100 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49975 /): [200 OK] in 4ms
[INFO] Thread-101 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49975 /): [200 OK] in 3ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec - in org.takes.http.BkParallelTest
Running org.takes.rs.RsTextTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.rs.RsTextTest
Running org.takes.facets.auth.codecs.CcCompactTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.auth.codecs.CcCompactTest
Running org.takes.misc.SelectTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.misc.SelectTest
Running org.takes.facets.hamcrest.HmRsStatusTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.hamcrest.HmRsStatusTest
Running org.takes.facets.fork.FkHitRefreshTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.018 sec - in org.takes.facets.fork.FkHitRefreshTest
Running org.takes.facets.hamcrest.HmRsHeaderTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.hamcrest.HmRsHeaderTest
Running org.takes.rq.RqFormTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in org.takes.rq.RqFormTest
Running org.takes.rq.RqWithDefaultHeaderTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqWithDefaultHeaderTest
Running org.takes.facets.fork.FkAuthenticatedTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.fork.FkAuthenticatedTest
Running org.takes.facets.auth.social.XeGoogleLinkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec - in org.takes.facets.auth.social.XeGoogleLinkTest
Running org.takes.misc.VerboseIterableTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.misc.VerboseIterableTest
Running org.takes.facets.auth.codecs.CcHexTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.auth.codecs.CcHexTest
Running org.takes.facets.auth.XeLogoutLinkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in org.takes.facets.auth.XeLogoutLinkTest
Running org.takes.facets.fork.TkMethodsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.fork.TkMethodsTest
Running org.takes.http.FtBasicTest
[INFO] pool-1-thread-28 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49926 /): [500 Internal Error] in 6ms
[INFO] pool-1-thread-23 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49923 /): [200 OK] in 8ms
[INFO] pool-1-thread-22 com.jcabi.http.request.BaseRequest: #fetch(PUT localhost:49925 /): [200 OK] in 7ms
[INFO] pool-1-thread-15 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49924 /): [200 OK] in 6ms
Tests run: 5, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 2.021 sec - in org.takes.http.FtBasicTest
Running org.takes.rq.RqHrefTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqHrefTest
Running org.takes.tk.TkFilesTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.tk.TkFilesTest
Running org.takes.tk.TkVerboseTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in org.takes.tk.TkVerboseTest
Running org.takes.rs.xe.XeLocalhostTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in org.takes.rs.xe.XeLocalhostTest
Running org.takes.rq.RqWithHeadersTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec - in org.takes.rq.RqWithHeadersTest
Running org.takes.misc.HrefTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.misc.HrefTest
Running org.takes.tk.TkWithHeadersTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.tk.TkWithHeadersTest
Running org.takes.rq.RqRequestLineTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.rq.RqRequestLineTest
Running org.takes.facets.forward.TkForwardTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.forward.TkForwardTest
Running org.takes.misc.VerboseListTest
Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec - in org.takes.misc.VerboseListTest
Running org.takes.facets.auth.social.PsGoogleTest
[INFO] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49984 /o/oauth2/token): [200 OK] in 4ms
[INFO] pool-1-thread-3 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49984 /plus/v1/people/me): [200 OK] in 4ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.014 sec - in org.takes.facets.auth.social.PsGoogleTest
Running org.takes.tk.TkRetryTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.214 sec - in org.takes.tk.TkRetryTest
Running org.takes.http.BkTimeableTest
[INFO] pool-1-thread-5 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49916 /): [200 OK] in 508ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.702 sec - in org.takes.http.BkTimeableTest
Running org.takes.facets.auth.IdentityTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.facets.auth.IdentityTest
Running org.takes.tk.TkReadAlwaysTest
[INFO] pool-1-thread-10 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49979 /): [200 OK] in 3ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.007 sec - in org.takes.tk.TkReadAlwaysTest
Running org.takes.rs.RsGzipTest
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec <<< FAILURE! - in org.takes.rs.RsGzipTest
makesCompressedResponse(org.takes.rs.RsGzipTest)  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError:

Expected: "some unicode text: €\n\t"
     but: was "some unicode text: â‚¬\n\t"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
	at org.takes.rs.RsGzipTest.makesCompressedResponse(RsGzipTest.java:60)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Running org.takes.facets.auth.social.XeGithubLinkTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in org.takes.facets.auth.social.XeGithubLinkTest
Running org.takes.tk.TkProxyTest
[INFO] pool-1-thread-16 com.jcabi.http.request.BaseRequest: #fetch(PUT localhost:49974 /): [200 OK] in 2ms
[INFO] pool-1-thread-27 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49973 /a/b/c): [200 OK] in 2ms
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.036 sec - in org.takes.tk.TkProxyTest
Running org.takes.rq.CapInputStreamTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.rq.CapInputStreamTest
Running org.takes.http.FtSecureTest
[INFO] pool-1-thread-11 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49980 /): [500 Internal Error] in 106ms
[INFO] pool-1-thread-21 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49983 /): [200 OK] in 132ms
[INFO] pool-1-thread-30 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49982 /): [200 OK] in 135ms
[INFO] pool-1-thread-19 com.jcabi.http.request.BaseRequest: #fetch(PUT localhost:49981 /): [200 OK] in 113ms
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.206 sec - in org.takes.http.FtSecureTest
Running org.takes.rq.RqMultipartTest
[INFO] pool-1-thread-26 com.jcabi.http.request.BaseRequest: #fetch(POST localhost:49972 /): [200 OK] in 6ms
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.266 sec - in org.takes.rq.RqMultipartTest
Running org.takes.facets.fallback.FbChainTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.facets.fallback.FbChainTest
Running org.takes.http.FtCLITest
[INFO] pool-1-thread-32 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49915 /): [200 OK] in 3ms
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.152 sec - in org.takes.http.FtCLITest
Running org.takes.facets.auth.RqAuthTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in org.takes.facets.auth.RqAuthTest
Running org.takes.rs.RsXSLTTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 sec <<< FAILURE! - in org.takes.rs.RsXSLTTest
org.takes.rs.RsXSLTTest  Time elapsed: 0 sec  <<< FAILURE!
java.lang.AssertionError:
default charset during testing must be UTF-8
Expected: "UTF-8"
     but: was "windows-1252"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.takes.rs.RsXSLTTest.before(RsXSLTTest.java:54)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:387)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Running org.takes.rs.RsJSONTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.048 sec - in org.takes.rs.RsJSONTest
Running org.takes.facets.fork.FkParamsTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in org.takes.facets.fork.FkParamsTest
Running org.takes.http.BkBasicTest
[INFO] pool-1-thread-25 com.jcabi.http.request.BaseRequest: #fetch(GET localhost:49922 /path/c): [404 Not Found] in 4ms
Tests run: 6, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 2.012 sec - in org.takes.http.BkBasicTest
Running org.takes.rq.RqOnceTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in org.takes.rq.RqOnceTest
Running org.takes.facets.auth.codecs.CcBase64Test
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in org.takes.facets.auth.codecs.CcBase64Test

Results :

Failed tests:
  RsGzipTest.makesCompressedResponse:60
Expected: "some unicode text: €\n\t"
     but: was "some unicode text: â‚¬\n\t"
  RsXSLTTest.before:54 default charset during testing must be UTF-8
Expected: "UTF-8"
     but: was "windows-1252"

Tests run: 351, Failures: 2, Errors: 0, Skipped: 5

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14.662 s
[INFO] Finished at: 2016-01-31T11:48:27+00:00
[INFO] Final Memory: 28M/710M
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "securecentral" could not be activated because it does not exist.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project takes: There are test failures.
[ERROR]
[ERROR] Please refer to c:\java\workspace\takes\target\surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

What can be the cause?

@sebing regarding build failing locally - please read instructions for Windows users carefully in README

@mkordas There is still problem with the pom.xml.
/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd/source.rb:144:in `rescue in puzzles': ["in /home/travis/build/yegor256/takes/pom.xml", #<PDD::Error: Too many spaces>] (PDD::Error)

@sebing please indent all lines of puzzle by exactly one space

@mkordas Still puzzle is not working.

@sebing build is failing with
/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/pdd-0.15.4/lib/pdd/source.rb:144:in `rescue in puzzles': ["in /home/travis/build/yegor256/takes/src/main/java/org/takes/rq/RqMultipart.java", #<PDD::Error: Space expected>] (PDD::Error)

@mkordas corrected with the suggestions. Thank you so much for helping me.

@sebing you did it! :) build is finally green

@mkordas  :)) with your help..

@sebing please update PR description with issue number

@sebing please add "@mkordas" here.

@mkordas I think, I fixed all the suggestions. Did I miss any?

@mkordas Travis-ci is taking too much time to complete. Is this because of enabling findbugs?
I thought, AppVeyor is running the find bugs.

@sebing both AppVeyor and Travis run FindBugs, please see configs of those CIs in main repo directory

@sebing why you think that Travis is slow? In the history I see that it took about 10 minutes as usual

@sebing please add @mkordas to your comment "Why the branch is deleted?"

@sebing please see a few additional comments above, we're approaching the end of review

@mkordas I am not a fan of decorative pattern or the misuse of it :) But i think, it is a trivial issue, so I removed the puzzle.

@mkordas When I run Travis in another branch where findbugs are not enabled, it takes 4min and now it is taking 10. I know, findbugs can take some extra time and developers are okay with this :)

@sebing

I am not a fan of decorative pattern or the misuse of it :) But i think, it is a trivial issue, so I removed the puzzle.

We like decorators in Teamed. Please read http://www.yegor256.com/2015/02/26/composable-decorators.html

@sebing now everything looks good, thanks

@rultor merge

@rultor merge

@mkordas Thanks for your request. @yegor256 Please confirm this.

@mkordas Thank you very much for all the help.

@sebing

Thank you very much for all the help

No problem, you're welcome

@yegor256 @davvd Any update on the closure of this merge?

@sebing you just need to chase @yegor256

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@sebing @yegor256 Oops, I failed. You can see the full log here (spent 4min)
fea2902e32c2: Already exists
fe63f5e653d4: Already exists
a3993bd96606: Already exists
afa03f817a39: Already exists
1eefa2535ae7: Already exists
490717c804fe: Already exists
Digest: sha256:b7b81dbc5c2e8bb74d336d568b84a6f4b903bca608c980c6ae231b8a46f5e922
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ grep --quiet '\syegor256_takes_552\s*$'
+ docker ps --filter=status=exited
++ pwd
++ pwd
+ docker run --rm -v /tmp/rultor-igkh:/main '--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g' --env=fork=git@github.com:sebing/takes.git --env=fork_branch=findbugs --env=head=git@github.com:yegor256/takes.git --env=head_branch=master --env=pull_id=552 --env=pull_title=Findbugs --privileged=true --hostname=docker --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-igkh/cid -w=/main --name=yegor256_takes_552 yegor256/rultor /main/entry.sh
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./curl-appveyor.cfg ./end.sh ./entry.sh ./pid ./pubring.gpg ./repo ./run.sh ./s3cfg ./script.sh ./secring.gpg ./settings.xml ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ sudo locale-gen en_US en_US.UTF-8
Generating locales...
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
Generation complete.
+ sudo dpkg-reconfigure locales
debconf: unable to initialize frontend: Dialog
debconf: (Dialog frontend will not work on a dumb terminal, an emacs shell buffer, or without a controlling terminal.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype
Generating locales...
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
Generation complete.
+ export LC_ALL=en_US.UTF-8
+ LC_ALL=en_US.UTF-8
+ export LANG=en_US.UTF-8
+ LANG=en_US.UTF-8
+ export LANGUAGE=en_US.UTF-8
+ LANGUAGE=en_US.UTF-8
+ sudo gem install --no-rdoc --no-ri pdd
Building native extensions.  This could take a while...
ERROR:  While executing gem ... (Gem::RemoteFetcher::UnknownHostError)
    no such name (https://api.rubygems.org/quick/Marshal.4.8/ruby-filemagic-0.7.1.gemspec.rz)
Successfully installed nokogiri-<IP_ADDRESS>
container 33ba9e74d871e97b81718dc3816402b27d75a46707c79080473b818472c3a44c is dead
Wed Feb  3 00:10:45 UTC 2016

@rultor try to merge again

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge again

@sebing @yegor256 Oops, I failed. You can see the full log here (spent 3min)
123213ef0aca: Already exists
861c99bede6c: Already exists
fea2902e32c2: Already exists
fe63f5e653d4: Already exists
a3993bd96606: Already exists
afa03f817a39: Already exists
1eefa2535ae7: Already exists
490717c804fe: Already exists
Digest: sha256:b7b81dbc5c2e8bb74d336d568b84a6f4b903bca608c980c6ae231b8a46f5e922
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\syegor256_takes_552\s*$'
++ pwd
++ pwd
+ docker run --rm -v /tmp/rultor-K2WQ:/main '--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g' --env=fork=git@github.com:sebing/takes.git --env=fork_branch=findbugs --env=head=git@github.com:yegor256/takes.git --env=head_branch=master --env=pull_id=552 --env=pull_title=Findbugs --privileged=true --hostname=docker --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-K2WQ/cid -w=/main --name=yegor256_takes_552 yegor256/rultor /main/entry.sh
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./curl-appveyor.cfg ./end.sh ./entry.sh ./pid ./pubring.gpg ./repo ./run.sh ./s3cfg ./script.sh ./secring.gpg ./settings.xml ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ sudo locale-gen en_US en_US.UTF-8
Generating locales...
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
Generation complete.
+ sudo dpkg-reconfigure locales
debconf: unable to initialize frontend: Dialog
debconf: (Dialog frontend will not work on a dumb terminal, an emacs shell buffer, or without a controlling terminal.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype
Generating locales...
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
Generation complete.
+ export LC_ALL=en_US.UTF-8
+ LC_ALL=en_US.UTF-8
+ export LANG=en_US.UTF-8
+ LANG=en_US.UTF-8
+ export LANGUAGE=en_US.UTF-8
+ LANGUAGE=en_US.UTF-8
+ sudo gem install --no-rdoc --no-ri pdd
ERROR:  Could not find a valid gem 'pdd' (>= 0), here is why:
          Unable to download data from https://rubygems.org/ - no such name (https://rubygems.org/specs.4.8.gz)
container cf01fe92f944575f8684f2079912f45c36b8805b07e3af3c3b72ef96a38dd771 is dead
Wed Feb  3 00:28:01 UTC 2016

@rultor merge

@rultor merge

@mkordas Thanks for your request. @yegor256 Please confirm this.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@sebing @yegor256 Oops, I failed. You can see the full log here (spent 2min)
be116d041cbc: Already exists
b4dbdc5ec79b: Already exists
701726dcdb1d: Already exists
517a4d3ea3f9: Already exists
a8a32e773747: Already exists
db5c0b895629: Already exists
6fa0c834414c: Already exists
Digest: sha256:01f9463ed662c3a6a0f3066fff5008e7434c4d01e798d0be4bd76a5196760e3f
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\syegor256_takes_552\s*$'
++ pwd
++ pwd
+ docker run --rm -v /tmp/rultor-c1H9:/main '--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g' --env=fork=git@github.com:sebing/takes.git --env=fork_branch=findbugs --env=head=git@github.com:yegor256/takes.git --env=head_branch=master --env=pull_id=552 --env=pull_title=Findbugs --privileged=true --hostname=docker --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-c1H9/cid -w=/main --name=yegor256_takes_552 yegor256/rultor /main/entry.sh
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./curl-appveyor.cfg ./end.sh ./entry.sh ./pid ./pubring.gpg ./repo ./run.sh ./s3cfg ./script.sh ./secring.gpg ./settings.xml ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ sudo locale-gen en_US en_US.UTF-8
Generating locales...
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
Generation complete.
+ sudo dpkg-reconfigure locales
debconf: unable to initialize frontend: Dialog
debconf: (Dialog frontend will not work on a dumb terminal, an emacs shell buffer, or without a controlling terminal.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype
Generating locales...
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
Generation complete.
+ export LC_ALL=en_US.UTF-8
+ LC_ALL=en_US.UTF-8
+ export LANG=en_US.UTF-8
+ LANG=en_US.UTF-8
+ export LANGUAGE=en_US.UTF-8
+ LANGUAGE=en_US.UTF-8
+ sudo gem install --no-rdoc --no-ri pdd
Building native extensions.  This could take a while...
ERROR:  While executing gem ... (Errno::EROFS)
    Read-only file system @ rb_sysopen - /var/lib/gems/2.2.0/extensions/x86_64-linux/2.2.0/nokogiri-<IP_ADDRESS>/gem_make.out
container bd3f909bfb432324f70e7ca76c9ef4e34ab732ee5a552afa529dcd00a50d4847 is dead
Wed Feb  3 21:25:02 UTC 2016

@rultor try to merge again

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge again

@yegor256 Done! FYI, the full log is here (took me 16min)

@rultor deploy

@rultor deploy

@mkordas Thanks for your request. @yegor256 Please confirm this.

@elenavolokhova review this ticket please, for compliance with our quality rules

@rultor deploy pls

@rultor deploy pls

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy pls

@davvd Done! FYI, the full log is here (took me 15min)

@davvd Quality is good here!

@davvd Quality is good here!

@elenavolokhova thanks for the review

@mkordas 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 76602915

@davvd can you continue here?

@davvd can you continue here?

@mkordas @yegor256 please help us here

@davvd pls add extra 15 mins to @mkordas

@yegor256 what about par. 8? I should get much more minutes here.

@mkordas it's a bug on our side. can you please calculate how much more?

@yegor256 sure, 128 mins more here

@davvd pls add extra 128 mins to @mkordas

@davvd pls add extra 15 mins to @mkordas

@yegor256 I've paid 15 mins to @mkordas in transaction 56d17058313c2b0cac000356

@davvd pls add extra 128 mins to @mkordas

@yegor256 I've paid 2 hours and 8 mins to @mkordas in transaction 56d17076313c2b578e000016


CRUD operations(raw SQL)

CRUD operations(raw SQL)
It's demo

I'm closing the pull request for now. This will be merged at a later date. First need to merge authentication-fix into master.


Fix duplication and cropped hovercard in user-local-time

Fixes #3634
Fixes #4345
Test URLs
Steps to reproduce the bug:

Clear the extension cache
Go to a page with a lot of usernames, e.g. https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc
Hover over the various usernames until the bug appears (it may take a while)

For #4345: https://github.com/hexalellogram/iPhoneBatteryClient
Screenshot
https://user-images.githubusercontent.com/46634000/120510278-8f014500-c3c9-11eb-8473-c11fe6a42449.mp4
For the comment in the CSS:

Seems like #4345 is caused by user-local-time. Should I fix it in this PR while I'm at it?

Yes

Maybe its just me. But do you get the feeling the the init function should be split into 2?

Maybe its just me. But do you get the feeling the the init function should be split into 2?

Yes I'll hoist the add() callback to the top level :+1:

LGTM

@cheap-glitch thanks for all your great work!

🙌 2 bugs in 1!


Notation fix

Some small notation improvements introducing some consistency rules:

Types are denoted by letters at the beginning of alphabet : a, b, c

Values are denoted by letters at the end of alphabet: x, y, z

Unlifted values are denoted by t, u, v

Lifted functions in Apply are called xy to distinguish from lifted values denoted by single letters like x.

(Partially) fixes https://github.com/fantasyland/fantasy-land/issues/217

In addition I would propose the standard mathematical convention to denote objects (aka types) and functors by capital letters. This is also consistent with the type (aka interface) and functor capitalised names e.g. Maybe, Either.
Further motivation
Functors are fundamentally different from functions (aka morphisms in Category theory). Functors map types to types, whereas functions map values to values. So it is highly beneficial for readability to make a clear notational distinction.

We should be wary of trying to encode information in names. While these changes don't hurt, I don't think they're an improvement.

We should be wary of trying to encode information in names.

Why? Encoding information in names seems very helpful to me. And it is practiced all the time in both math and programming.

As soon as one gives functions and parameters descriptive names, readers will begin to make assumptions based on those names. If those assumptions are correct, fantastic! If those assumptions are incorrect, we'd have been better off sticking with meaningless names. :stuck_out_tongue_winking_eye:
I'm in favour of following existing conventions. I certainly find f(x) easier to parse than x(f), though they're objectively equivalent. This pull request, though, introduces new conventions. The two-letter variable names, in particular, do not sit well with me.

As soon as one gives functions and parameters descriptive names, readers will begin to make assumptions based on those names. If those assumptions are correct, fantastic! If those assumptions are incorrect, we'd have been better off sticking with meaningless names. :stuck_out_tongue_winking_eye:

Well. I personally think that well-chosen names are better than arbitrarily chosen name. Meaningful names are pretty much the norm so maybe users will mistake the arbitrary names for meaningful names and make incorrect assumptions about them anyway?
I do however agree about the two-letter names. What if just those where removed from the PR?

I do however agree about the two-letter names. What if just those where removed from the PR?

That would take me from :pensive: to :neutral_face:.


artifacting around text in front of mr-img

I assumed this was something to do with antialiasing, but I think this popped up around the time masking landed.

@michaelthatsit - is this still open? i think we stated this was resolved from the object change you had done with mr text and textObj in terms of nexting
lmk if not though and i can look back into this at some point

This is still an issue, the previous fix resolved the masking issue. not the weird artifacting.

gotcha

rechecked in office - all good to close ~


can't download the pretrained models

Hello! Your project is very useful!
But I can't download the pretrained models that the page is 404. So can you refresh the link? Thank you very much!

Hi, would you please include details? Which particular links result in 404?
On Sun, Oct 27, 2019, 7:15 PM slliao445<EMAIL_ADDRESS>wrote:

Hello! Your project is very useful!
But I can't download the pretrained models that the page is 404. So can
you refresh the link? Thank you very much!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/akamaster/pytorch_resnet_cifar10/issues/13?email_source=notifications&email_token=AAOPGFGXSCKFTRDT6LBYMPDQQZDMLA5CNFSM4JFUTXVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUUWURA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOPGFEHCEBFHIWO5IXJZUTQQZDMLANCNFSM4JFUTXVA
.

Hi, would you please include details? Which particular links result in 404?
…
On Sun, Oct 27, 2019, 7:15 PM slliao445 @.***> wrote: Hello! Your project is very useful! But I can't download the pretrained models that the page is 404. So can you refresh the link? Thank you very much! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13?email_source=notifications&email_token=AAOPGFGXSCKFTRDT6LBYMPDQQZDMLA5CNFSM4JFUTXVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUUWURA>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOPGFEHCEBFHIWO5IXJZUTQQZDMLANCNFSM4JFUTXVA .

Sorry! When I clicked the link for pretrained resnet 1202 model in the Readme page, it resulted in 404. But now I can download the models from the pretrained models directory. Thank you very much!

Yes, I had the problem.  When I clicked the hyperlinks in README, it resulted in 404.


Support Consumer Deployment type for OCS-OSD deployer

pls rebase

@rewantsoni any other pending for removing 'WIP'?
@nb-ohad could you pls review the PR?

@rewantsoni Please confirm that this PR does not break any existing unit tests and that the changes to the unit tests for this deployment are coming in a later PR

@rewantsoni Please confirm that this PR does not break any existing unit tests and that the changes to the unit tests for this deployment are coming in a later PR

@nb-ohad This PR doesn't break any existing unit tests. I will be sending the unit tests for consumer deployment mode in an upcoming PR.


prompt choice like in v

I don't know the prompt choice of v. Is it similar to n-z?

very intentionally do not have this behaviour. prefer ending up in the "wrong" place sometimes and needing to adjust the mnemonic to having an extra step all the time.
You should be able to wrap z -l to make it a list picker if you really want.


Improve message about required firewall openings

According to netstat (and some other observations) only port 9943 is listened during headset discovery.
In case port 9944 is opened in firewall (but 9943 is not opened) the headset isn't discovered, and existing message ("check the firewall settings (permit UDP/9944)") is very misleading.
Hence the idea to include both ports in the message (this PR contains message where both ports are mentioned).

This PR has been merged in JackD83's fork and released on September 13 (almost 2 months ago).
It is working well (and this is only a text update).


Migrate to fan-template platform

https://esphome.io/components/fan/template
This allows to use https://github.com/denysdovhan/purifier-card

Few commits that have implemented that platform:
https://github.com/esphome/esphome/pull/6310
https://github.com/esphome/esphome-docs/pull/3655
https://github.com/esphome/esphome/pull/6112

sorry ive been very busy. i'll try to have a look at it in the following days

For me, it doesn't sync the fan percentage to the actual value at all but having this setup as a fan entity is the right way in general.

It works but the fan speed slider has no effect. Does it work for you?

Have you set the mode to manual?

I guess so. Clicked the "fan and moved the slider up and down - nothing.

still nothing...

Will check if the code here is the same as mine, or weather I have made any changes. Though it works for me..

only looked at it from hi up in the sky but after
XiaomiPurifierFan->speed = atof(val)+1;
isn't there supposed to be a
call.perform();
?

I've found one some differences between what I use in HA and what was in this draft, could You try that?

it's on now but one suggestion - whenever the slider is moved just change the preset automatically to manual
in this case you do not need to firstly change the preset and then move the slider

I've tried to do that, but I wasn't able to achieve that, since than I have not worked on it, maybe @jaromeyer could figure it out ;)

Yeah that'd be great. Right now if you're in let's say the Medium preset and change the percentage slider, the unit itself stays in that preset and doesn't actually change the speed and on Home-Assistant it goes to an unknown/bogus state for the mode selection
Before adjusting %:

After adjusting % from the medium preset:

    on_speed_set:       - lambda: |-           auto c = static_cast<MiPurifier *>(mipurifier);           c->set_mode("manual");       - delay: 1s       - lambda: |-           auto c = static_cast<MiPurifier *>(mipurifier);           c->set_manualspeed((int)x-1);
I've changed the on_speed_set function to set manual mode every time I change the speed

Thanks @Xploder! I've swapped these lambada, so first the speed is set and than the mode, to prevent going it to a previous speed for that split second :)

Thanks! Works fine within the usual limitations of it not being able to read current mode later etc.
But now we're at least able to easily set percentage from Alexa from any mode!

works great. like this, enough for getting things done

Finally got to test your PR and it works great! Thanks @ireun


HTTP Headers Over Deprecation

Motivation:
As part of recent efforts to rectify performance and make 4.1 headers more similar to 5.0 some methods were deprecated. Some of these methods were deprecated because they used String instead of CharSequence in the signature, which may require casting at the user level. Some of the deprecated methods have no direct alternatives and were done to inform a user the method will go away in future releases.
Modifications:

Remove the deprecated qualifier from methods where no direct replacement exists

Result:
Less warnings in user code.

@normanmaurer - Please review.

@Scottmitch ship it.

@Scottmitch please merge buddy :)

Cherry-picked into 4.1 as (0555b0aefd93d2ddbf68f0163ec9751a5e80b3c8). Thanks @Scottmitch

@normanmaurer - Thanks for cherry-picking ... been busy :(

@Scottmitch no worries buddy :beer:


Update lgrey colours

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[X] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

This commit addresses issue #456
CHANGELOG

Updated the lgrey colours

Changes Unknown when pulling b785e21efaaf2549b08aa60be11bf0e0f615b417 on AdamWard1995:updatePallete into ** on ciena-frost:master**.

Approved

@AdamWard1995 you're going to need to add the stable version of node to the allowed failures in the travis config - @EWhite613 can provide details

Changes Unknown when pulling d901a6bf44884711f0342a7f3f1725c3973feee1 on AdamWard1995:updatePallete into ** on ciena-frost:master**.

Approved


cross-build error on Darwin zhangdeMac-mini.local 16.0.0 Darwin Kernel Version 16.0.0: Mon Aug 29 17:56:20 PDT 2016; root:xnu-3789.1.32~3/RELEASE_X86_64 x86_64

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.7.5
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/willian/go/proxy"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.5/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.5/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4c/xgznys191rsgcfwx16z5rp6m0000gn/T/go-build870210267=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
What did you do?
I compile my project ,with the command
I get this github.com/djimenez/iconv-go library,and do build
CGO_ENABLED=1 GOOS=linux GOARCH=amd64 go build
then
What did you expect to see?
build success
What did you see instead?
runtime/cgo
ld: unknown option: --build-id=none
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Dup of #12888. See Ian's comment.

To cross compile with cgo enabled, you will need a cross compiling
toolchain for linux on OS X.


fix(test): fix expandybird environment variables

When adding additional env to an Cmd you must use append

The reason I did that was so that Python was a little bit more sandboxed, and you could write templates that depend on the $USER or $HOME or $PID or whatever.  It's just a drop in the ocean in the much bigger problem of sandboxing, but it seemed like a good idea.


Examples Projects not compiling

Steps to reproduce

Clone solution as is
Build any wpf project
Build fails

i think this is due to wrong project files, current ones are using Microsoft.NET.Sdk when it should be Microsoft.NET.Sdk.WindowsDesktop also looks like the project is using old build targets
Platform:
.NET version:
.net framework 4.7.2
.net core: 3.0.100-preview-010184

All WPF projects should succeed now.


access $['someid'] in moustage binding

 Issue by zoechi
Originally opened as dart-lang/sdk#20448

I tried to reference a method of a sibling as event handler inside a moustache expression.
articles
Should this work? how?
I get
Transform ScriptCompactor on bwu_polymer_routing|example/example_01.html threw error: Bad state: invalid symbol name: "$['routelink'].parentRoute"
Polymer 0.12.1
Dart VM version: 1.6.0-edge.39058 (Fri Aug  8 15:50:20 2014) on "linux_x64"

 Comment by zoechi

https://github.com/Polymer/polymer/issues/446#event-151646069
seems to be the answer (not supported)

 Comment by zoechi

Seems to be a PR that adds support for exactly my use case.
https://github.com/Polymer/polymer-dev/pull/30/files


List the PackageIdentifier of the package to be added to automation
Streamlabs.StreamlabsOBS
Details about the application
Get releases from https://github.com/stream-labs/streamlabs-obs/tags
Extract version from tag_name
InstallerUrl: https://slobs-cdn.streamlabs.com/Streamlabs+OBS+Setup+$($version).exe

@all-contributors please add @OfficialEsco for ideas


orientation changes cause crash or other issues on iOS

Operating system or device - Godot version:
iPhone 5S, iOS 10.3.1, Godot v2.1.3
Issue description:
There seem to be multiple problems with orientation changes on iOS

If your project supports multiple orientations, when an orientation change occurs on iOS, it seems like there is a 50% or greater chance Godot will crash (see https://github.com/godotengine/godot/issues/7945 for related issue). From what I've observed, "501 error" will be printed to the console many times while the orientation change is occurring. The crash seems to occur when the orientation change should finish.

Additionally, I have a TextureFrame with a screen shader in a project that I am resizing when the viewport size changes. On iOS, this causes nothing to render on that CanvasLayer. Rotating back to the original orientation does not fix it. I am also calling this resizing function once at startup from _ready but that does not cause an issue. FWIW I am using the following project settings and calling set_size_override on the viewport for custom sizing through my Camera2D:

orientation = "sensor"
stretch_aspect = "ignore"
stretch_mode = "2d"

"reverse_portrait" orientation mode does not seem to be supported regardless of the project settings or supported orientations in the Xcode project's .plist

I've tested this on many of the demo projects as well and the first and third issue are still prevalent
Probably doesn't need to be said, but setting a single explicit orientation does not cause any issues
Steps to reproduce:
Enable multiple orientations in the project settings and Xcode project. Run on an iOS device and rotate to different orientations

Yes,really too many issues related to the orientation on iOS,but it seems all these issues are just ignored.Nobody take care of these issues.

Yes,really too many issues related to the orientation on iOS,but it seems all these issues are just ignored.Nobody take care of these issues.

You know the saying, "scratch your own itch"...

Yes,really too many issues related to the orientation on iOS,but it seems all these issues are just ignored.Nobody take care of these issues.

Don't worry, you're not alone ;) :

I know there are too many bugs to fix.
But for these that make every project impossible to publish should take higher priority.
I’m just come across Godot and not familiar with the internal,although I have spent days to track the termination and orientation issues,but without fortune.

First of all thank you for your report and sorry for the delay.
We released Godot 3.0 in January 2018 after 18 months of work, fixing many old issues either directly, or by obsoleting/replacing the features they were referring to.
We still have hundreds of issues whose relevance/reproducibility needs to be checked against the current stable version, and that's where you can help us.
Could you check if the issue that you described initially is still relevant/reproducible in Godot 3.0 or any newer version, and comment about its current status here?
For bug reports, please also make sure that the issue contains detailed steps to reproduce the bug and, if possible, a zipped project that can be used to reproduce it right away. This greatly speeds up debugging and bugfixing tasks for our contributors.
Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.
Thanks in advance.
Note: This message is being copy-pasted to many "stale" issues (90+ days without activity). It might happen that it is not meaningful for this specific issue or appears oblivious of the issue's context, if so please comment to notify the Bugsquad about it.

Our Bugsquad will review this issue more in-depth in 15 days, and potentially close it if its relevance could not be confirmed.

As there was no update since the previous post, we close this issue.
If it is still relevant in the way it was described and discussed above, please comment to ask for it to be reevaluated. If it is only partly relevant, or if the original issue has changed, it would be better to open a new issue (potentially referring to this one) focused on the current state.