BodyParamsMiddleware: Valid JSON containing a scalar value causes InvalidArgumentException

If the request body contains a valid scalar JSON value e.g. string, boolean or int, an InvalidArgumentException is thrown.
Code to reproduce the issue
Using BodyParamsMiddleware with the standard JsonStartegy.
Like described here: https://docs.zendframework.com/zend-expressive/v3/features/helpers/body-parse/
Send a request with the Content-Type header 'application/json' and the body containing any of this:

"string"
false
true
123

Expected results
Expecting to use \Psr\Http\Message\ServerRequestInterface::getParsedBody().
Actual results
InvalidArgumentException
Zend\Diactoros\ServerRequest::withParsedBody expects a null, array, or object argument; received integer

Originally posted by @MrKey at https://github.com/zendframework/zend-expressive-helpers/issues/67

@MrKey Can you create a test case? I can't reproduce it here.

Originally posted by @geerteltink at https://github.com/zendframework/zend-expressive-helpers/issues/67#issuecomment-427035225

Steps to reproduce:

Create the default zend skeleton app like described here: https://docs.zendframework.com/zend-expressive/v3/getting-started/quick-start/
1.1) all defaults
1.2) run webserver
Modify config/routes.php to add a POST route along the two default get routes:

return function (Application $app, MiddlewareFactory $factory, ContainerInterface $container) : void {
    $app->get('/', App\Handler\HomePageHandler::class, 'home');
    $app->post('/', [Zend\Expressive\Helper\BodyParams\BodyParamsMiddleware::class, App\Handler\HomePageHandler::class]);
    $app->get('/api/ping', App\Handler\PingHandler::class, 'api.ping');
};

Make a request with the 'Content-Type: application/json' header and with the body '2' (without any braces):

POST  HTTP/1.1
Host: localhost:8080
Content-Type: application/json

2

Result:
Zend\Diactoros\Exception\InvalidArgumentException: Zend\Diactoros\ServerRequest::withParsedBody expects a null, array, or object argument; received integer in file ...

Originally posted by @MrKey at https://github.com/zendframework/zend-expressive-helpers/issues/67#issuecomment-427044408

Shouldn't you pass valid json? Let me rephrase that...
It is valid json I guess. But as the Exception message says, it expects that json_decode returns null, array or object. json_decode(2, true) returns an integer as the exception tells you.
To have json_decode return something useful, you need to feed it something that translates to an array: {"data":2}.

Originally posted by @geerteltink at https://github.com/zendframework/zend-expressive-helpers/issues/67#issuecomment-427068253


github-actions: Use include_frontend_test check.

I did an audit on all the steps that used matrix.is_bionic check we use after this change and these are the ones left:

Test locked requirements: Based on what I know this was intentionally removed from focal? I am not sure, but we may want to add a comment stating that here.
Store test reports which uploads `/tmp/zulip-test-event-log/`` as an artifact.
Do Bionic hack is self-explanatory.

Finally, we have focal-specific step Check development database build which runs ./tools/ci/setup-backend.

These are all great, merged, thanks @priyank-p!  The CodeQL cron just came from their automated tool making it.


Installing instructions from README.md do not work

While following the instructions in the readme some packages are not found:
~/netzsinus/go/src/github.com/netzinus/defluxio-software$ go install ./...
defluxio-software/cmd/defluxio-exporter/main.go:10:2: cannot find package "github.com/netzsinus/defluxio-software" in any of:
	/usr/lib/go/src/github.com/netzsinus/defluxio-software (from $GOROOT)
	/home/axel/netzsinus/go/src/github.com/netzsinus/defluxio-software (from $GOPATH)
defluxio-software/cmd/defluxio-provider/main.go:10:2: cannot find package "github.com/tarm/goserial" in any of:
	/usr/lib/go/src/github.com/tarm/goserial (from $GOROOT)
	/home/axel/netzsinus/go/src/github.com/tarm/goserial (from $GOPATH)

If I follow the instruction travis uses, it works. Is go get -t -v ./... necessary?

@aAXEe: Thank you for reporting this. The cause was a missing godep entry for the goserial library. I tested this with a separate GOPATH, now the original installation instructions should work as advertised.
-Mathias

Thank you for the quick fix!


Αdd easy limits access and reset in Robot class

Αdd easy limits access and reset in Robot class (+ python fix)..

Merging...


not really major changes but probably needed

title explains itself, since rem is no longer supported and dead

pr to indev pls. I got one or two things left that I have to change.


knex seed:run heap OOM

I have a huge seed file (csv) and am using knex-csv-transformer to import this. Using this tool I already succeeded to import multiple other csv files, but this specific one contains 7,541,147 rows to be exact. I know, quite a lot, but also quite necessary.
It results in the OOM down below.

Security context: 0x16b7713266a1 <JS Object>
    2: _prepInsert [/[redacted]/api/node_modules/knex/lib/query/compiler.js:~579] [pc=0xc65c96132ea](this=0x2023fac6d3f1 <a QueryCompiler_PG with map 0xc0805c503e1>,data=0x2023fac6d459 <JS Array[7541147]>)
    3: insert [/[redacted]/api/node_modules/knex/lib/query/compiler.js:177] [pc=0xc65c96104e5](this=0x2023fac6d3f1 <a QueryCompiler_PG with map 0xc0805c503e1>)
    4: inse...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [knex]
 2: 0x12b81cc [knex]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [knex]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [knex]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [knex]
 6: 0xe647c3 [knex]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [knex]
 8: 0xc65ae4043a7
Aborted (core dumped)```

@Matzu89
You can chunk it to multiple pieces then import each one, there is a module for that csv-chunk

@Matzu89 @absolux is right, you need to start transaction and then read that csv file e.g. in batches of 1000 lines and do multiple inserts.
Also there are probably better tools to import huge amount of csv data to sql db unless you are doing additional normalization/processing for the data in javascript side before inserting.


Unintended Persistence of Control Actions after Experiment Abortion

TeCoLab currently exhibits the behavior of persisting with the same control actions even after an experiment is aborted. The expected behavior, in contrast, should be to set the control actions to zero upon abortion or any other lost of connection with the computer.
Steps to Reproduce:
Run a TeCoLab experiment.
Set the control actions to any non-zero value.
Abort the experiment before completion.
Expected Behavior:
After aborting the experiment or losing connection with the computer, TeCoLab should set the control actions for heaters and the fan to zero, ensuring a safe and controlled state.
Actual Behavior:
The control actions persist with the same values as before the experiment abortion.
Note:
This issue does not impact significantly the system's safety since TeCoLab turns off if the temperature reaches potentially dangerous levels.

The firmware was modified. Now, when the board is in the 'waiting communication status' (green LED blinking), the actuators are ensured to be turned off.


Cyrillic characters are not displayed correctly

Hi! The in-game chat works well with Latin characters, but Cyrillic are not displayed properly (?????? instead).

Pretty weird, this is the font I'm using for the chat, and it says it should support Cyrillic characters. This issue will be resolved soon enough as I'm going to be moving to another font solution that will allow you to select a system font again.


server crashing upon startup

Please provide a brief summary of the bug
i start the server and a few seconds later it crashes
Please provide steps to reproduce where possible
No response
Expected Results
for the server to start
Actual Results
server crashes
What Java Version are you using?
<IP_ADDRESS>
What is your operating system and platform?
windows 10
How did you install Java?
7zip
Did it work before?
No response
Did you test with the latest update version?
yes

Did you test with other Java versions?
No response
Relevant log output
https://mclo.gs/5wvDiAa

Thank you for the report!
It looks like you are reporting that the game Minecraft crashed for you. Please try the following:

Update your graphics drivers, see this Minecraft Help Center article, section "Update your Video Card Drivers";
often Minecraft crashes are caused by outdated graphics drivers
In case you are using mods, try disabling them one by one until you find the mod causing the crash, then report the crash to the mod author
If you are using a third-party launcher, try the official launcher instead

If none of the above helped, and you are still experiencing the crash with the official launcher and without any mods installed, please submit this issue over at the Mojang bug tracker. Please search for existing reports first; in case you do not find any, create a new report and let us know about the issue number here (e.g. MC-123456).
The Mojang team will take the first look. If an OpenJDK bug is identified, the Mojang team will contact the Microsoft Build of OpenJDK team to address the issue.


Updated scripts to download and verify raw data from google drive

See Issue #17

Merging pull request despite decreased test coverage since the only lines untested are in the main block (3 lines). We are confident those lines are written correctly and it is difficult to test them since they are only executed when the script is run by hand.

Mistakenly closed pull request when it should have been merged. Fixed


Stray comma

Summarise the changes this Pull Request makes.
remove a stray trailing comma.
Minor stylistic matter but it bugs me
Please include a reference to a GitHub issue if appropriate.

It might not be objectively right to remove it - it's a matter of taste, but it is consistent with the rest of the code.


fetch beacon chain data from p2p network

Original issue: https://github.com/a16z/helios/issues/59
Original plan: https://hackmd.io/_Wgqr2yWR0u5NQmmXNDIAA

Here, I set the base branch as gr/p2p.
And all other work is merged into this branch.


Allow apps to change the colour of the notch / top bar

Adds a new field to the package.json file: color / colour (also added me as a contributor)

That's all fine and dandy but this request is based off the dev kit, not the full phone, dropping the cell bar, login icon, etc. from the notch.
Redo these edits on the actual phone and I'll take another look.

That's all fine and dandy but this request is based off the dev kit, not the full phone, dropping the cell bar, login icon, etc. from the notch.
Redo these edits on the actual phone and I'll take another look.

Ah right forgot about that lmao

I would be much appreciations as you combined your two commits to kernel.js so I exactly knew what tf you were doing

Thank you dainf... so much

Thank you dainf... so much

np


⚠ Turnos 24x7 has degraded performance

In 0f12b6d, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 2615 ms

Resolved: Turnos 24x7 performance has improved in 2c53358.


Setup pytest, write initial tests for subscription features

🗣 Description

Setup pytest to run locally and in the GitHub actions checks
Load test data
Create tests for subscription features

🧪 Testing

Pytest ran successfully locally and in PR checks
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All future TODOs are captured in issues, which are referenced
in code comments.
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

Good work. Make sure to install pre-commit so you can resolve the linting failures. You can set it up by following the docs here: https://github.com/cisagov/skeleton-generic/blob/develop/CONTRIBUTING.md#setting-up-pre-commit

@mcdonnnj Thank you for the helpful feedback. Can you please give more direction on the acceptance criteria for this pull request?

@jsf9k please review again when you are able. I have tried to match the skeleton project as much as possible

@dav3r Will you please review this pull request in lieu of @jsf9k so there's the same number of dev team eyes?


Filter openstack floating IPs by tenant ID

If the user in question happens to be an admin user, they may see
floating IPs that are from other tenants. Attempts to use such IPs will
result in an error, as the tenant of the IP doesn't match the tenant of
the instance. Filtering by ID limits the returned IPs to those that are
valid for the tenant.
Unfortunately the filtering has to be done by tenant ID, not name, so we
need to interact with the identity end point to map the tenant name to
ID if only the name was provided. Currently this only supports the v2
identity endpoint.
Signed-off-by: Jesse Keating<EMAIL_ADDRESS>

/cc @ggiamarchi

@j2sol can you address @ggiamarchi comments?
@ggiamarchi save your one comment, is this going in the right direction?
Thank you both!

Yup, I'll address it.

Merged with https://github.com/docker/machine/pull/2589


[SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context

branch-3.2 version!
For master version see : https://github.com/apache/spark/pull/34745
Augments the JdbcConnectionProvider API such that a provider can indicate that it will need to modify the global security configuration when establishing a connection, and as such, if access to the global security configuration should be synchronized to prevent races.
What changes were proposed in this pull request?
As suggested by @gaborgsomogyi here, augments the JdbcConnectionProvider API to include a modifiesSecurityContext method that can be used by ConnectionProvider to determine when SecurityConfigurationLock.synchronized is required to avoid race conditions when establishing a JDBC connection.
Why are the changes needed?
Provides a path forward for working around a significant bottleneck introduced by synchronizing SecurityConfigurationLock every time a connection is established. The synchronization isn't always needed and it should be at the discretion of the JdbcConnectionProvider to determine when locking is necessary. See SPARK-37391 or this thread.
Does this PR introduce any user-facing change?
Any existing implementations of JdbcConnectionProvider will need to add a definition of modifiesSecurityContext. I'm also open to adding a default implementation, but it seemed to me that requiring an explicit implementation of the method was preferable.
A drop-in implementation that would continue the existing behavior is:
override def modifiesSecurityContext(
  driver: Driver,
  options: Map[String, String]
): Boolean = true

How was this patch tested?
Unit tests. Also ran a real workflow by swapping in a locally published version of spark-sql into my local spark 3.2.0 installation's jars.

Can one of the admins verify this patch?

ok to test

Test build #146495 has started for PR 34989 at commit 359dbe6.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50971/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50971/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50971/

Test build #146495 has finished for PR 34989 at commit 359dbe6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146495/

Can one of the admins verify this patch?

Merged to branch-3.2


Maybe its time to export ChangeLog to a file of its own say CHANGELOG.rst

Title says it all.

I want to move the change log to its own file when we get out of alpha. Currently it's nice to see how far we've gone. And I'd like to keep it visible on PyPI.

You could keep the file separate and then combine them within setup.py for the long_description field? This is what urllib3 does.

If you have a minute to do this via a pull request, I'll accept that. Just remember to symlink it to docs/, too.

I like Carol's approach with navigation links better.


Custom role not being added as an option when inviting a user

Description
I tried creating a test custom role in an instance and tried assigning a user to that custom role but the newly added custom role was not in the options.
Created Role:

Interface:

To Reproduce
1. Create a "Test Role" using Create Role API on an instance
2. Go to the instance's accounts UI
3. Click on Users
4. Click on Invite User
5. Input name, email, choose role.

Current vs. Expected behavior
Expected: Test Role can be chosen
Actual: Test Role is not part of the list. Only seeing default roles.

Which area(s) are affected? (Select all that apply)
Website
Additional context
No response

The invite endpoint uses accessLevel (1-5) to identify what role they are invited with. That is why currently it is limited to the default (static) roles. Its database as well is limited to an int datatype. I'll be exploring extending accessLevel beyond 5 for custom role and check for any possible implications.

This has been the behavior even with the old accounts-ui. Even though, in the old accounts-ui, you can select a custom role before sending the invite, it will still default to the base (system) role the custom role is created upon invite accept. For example:

Invited user as Test Admin Role (with accessLevel = 1 which is an Admin system role where the custom role is based)
User accepted invite. API will then check the accessLevel value which is 1. So the user will still have the static system role Admin instead of the custom role Test Admin Role.


syntax and error thrown

Hi,
when you execute a statement like the below:
RESTORE DATABASE dummydb
FROM DISK='D:\snapshot_backup\db.bkm'
WITH METADATA_ONLY, FILE=3, DBNAME='testdb1', --> restores testdb3 database
MOVE 'testdb1' TO 'D:\snapshot_backup\testdb1.mdf',
MOVE 'testdb1_log' TO 'D:\snapshot_backup\testdb1_log.ldf'
the following error is thrown:
Msg 3102, Level 16, State 1, Line 1
RESTORE cannot process database 'dummydb' because it is in use by this session. It is recommended that the master database be used when performing this operation.
Msg 3013, Level 16, State 1, Line 1
RESTORE DATABASE is terminating abnormally.
you need to add at the beginning of the script:
use [master]
can you kindly check ?
Regards,
Emad

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8840ba86-332c-33fc-509b-9e7e08671c7a
Version Independent ID: 8840ba86-332c-33fc-509b-9e7e08671c7a
Content: Create a T-SQL Backup - SQL Server
Content Source: docs/relational-databases/backup-restore/create-a-transact-sql-snapshot-backup.md
Product: sql
Technology: backup-restore
GitHub Login: @perrysk-msft
Microsoft Alias: peskount

Prior to that example, you'll see the following text:

If testdb1 already exists on the server, include the REPLACE clause.

Does that resolve your issue?

Different Error:
Msg 3287, Level 16, State 1, Line 1
The file ID 3 on device 'C:\Program Files\Microsoft SQL Server\MSSQL16.MSSQLSERVER\MSSQL\dummydb.bkm' is incorrectly formed and can not be read.
Msg 3013, Level 16, State 1, Line 1
RESTORE DATABASE is terminating abnormally.
i would recommend if someone from Microsoft goes through the SQL Scripts provided again to verify they are working fine with MSSQL 2022 CTP release.
Thanks for your feedback.

@emad-almousa I am unable to reproduce your issue. Please can you check again. In the meantime I am closing this issue. Feel free to respond below if you have anything new to share.


Add: single_number

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #73   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          23     24    +1
  Lines         261    266    +5
=====================================
+ Hits          261    266    +5

Impacted Files
Coverage Δ

problems/single-number/single_number.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5c2b1...e3bef63. Read the comment docs.


Implementation of GithubSynchroIntroComponent class that creates a part of a report (defined in dynpy.utilities.components.guides.github.en module)

GithubSynchroIntroComponent class (report component)  is to implement in dynpy.utilities.components.guides.github.en module. It should provide adaptable part of the report or guide.

Exemplary comment. You can copy example below and close issue with new comment or modify it and close the issue. Remove this message or keep it if new comment is created.

The code was checked with the following call:
from dynpy.utilities.components.guides.github.en import GithubSynchroIntroComponent
GithubSynchroIntroComponent(None)


step and stepplot should accept step size and other stuff

From @baggepinnen on February 23, 2016 19:47
One should be allowed to supply any subset of the following

Initial value
Final value
Step time
Step size

Copied from original issue: mfalt/Control.jl#23

From @baggepinnen on February 26, 2016 10:28
I have an idea of how to solve it using kwargs...

How do you define these options? The time argument and the height is implemented (maybe slightly less convinient) as
stepplot(sys, linspace(0,10,100))
lsimplot(sys,  10*ones(100), linspace(0,10,100))

Do you mean that the step should stop again at a certain time?
Maybe we should instead supply a set of functions to generate inputs, for example
u, t = inputsignal(:step, height=1, stepwidth=10, T=20)
lsimplot(sys, u, t)

and
u1, t1 = inputsignal(:chirp, height=1, T=20, freqstart=1, freqstop=1e3)
u2, t2 = inputsignal(:steptrain, height=3, stepwidth=2, T=20, inputend=10)
u3, t3 = inputsignal(:triangletrain, height=3, stepwidth=2)
u,t = concatsignals(t1=>u1, t2=>u2, t3=>u3)
lsimplot(sys, u, t)

Sure, but it would also be nice to have a general way of generating the inputs instead

I think we will settle on just using lsim and lsimplot futh a function as input, this is probably the most convenient syntax. Closing until someone complains.


stan_csv_reader should skip warmup draws

Summary:
As currently written,  when stan::io::stan_csv_reader encounters a file with saved warmup draws,
the parser will return both warmup and sample draws, but no adaptation information.
Instead, the reader should check the parsed metatdata to determine whether or not there are saved warmup draws.
If there are, these can be discarded, as the consumer of the resulting stan_csv object - stan::mcmc::chains doesn't need them.
Description:
The parser expects to find the following element in the following order:

metadata
header
adaptation
samples, followed by timing.

Function read_adaptation is called after the header line has been consumed.  If the following line is not a comment block, it returns.  An error is written to the supplied stream out and the parser then calls read_samples.   Read samples then reads both the warmup and post-warmup draws.
The returned object contains warmup and post-warmup draws, but no information about step-size or metric.
Reproducible Steps:

Get outputs from 2 runs of a Stan model, w/ and w/out save_wamup=true.
Parse both with stan_csv_reader, examine the returned stan_csv object, e.g.:

TEST_F(McmcChains, stan_csv) {
  std::cout << "bernoulli_default " << bernoulli_default.metadata.num_samples;
  std::cout << " sample size " << bernoulli_default.samples.rows();
  std::cout << " step size " << bernoulli_default.adaptation.step_size << std::endl;
  std::cout << " bernoulli_warmup " << bernoulli_warmup.metadata.num_samples;
  std::cout << " sample size " << bernoulli_warmup.samples.rows();
  std::cout << " step size " << bernoulli_warmup.adaptation.step_size << std::endl;
}

Current Output:
bernoulli_default 1000 sample size 1000 step size 0.932037
bernoulli_warmup 1000 sample size 2000 step size 0
Expected Output:
Both should have sample size 1000, and step size close to 0.93.
Additional Information:
Provide any additional information here.
Current Version:
v2.35.0

additional problems found with stan_csv_reader.hpp - extend to properly parse ADVI samples - per CmdStan https://github.com/stan-dev/cmdstan/pull/972


Incorrect selection of Xcode location

After installing homebrew, it found an incorrect Xcode version and force me to update Xcode although it up-to-date.
Here is the case:
I have one drive with installed OSX 10.9 and there is XCode 5.1 here
I've installed OS 10.12 on second drive and also installed latest XCode 8.1
After installing homebrew on second drive it asking me to update XCode.
$ brew doctor
Warning: Your Xcode (5.1) is too outdated.
Please update to Xcode 8.1 (or delete it).
Xcode can be updated from the App Store.

$ brew config
HOMEBREW_VERSION: 1.1.1
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
Homebrew Ruby: 2.0.0-p648
Clang: 8.0 build 800
Git: 2.9.3 => /Library/Developer/CommandLineTools/usr/bin/git
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby
Java: N/A
macOS: 10.12.1-x86_64
Xcode: 5.1 => /Volumes/MAC X 9/Applications/Xcode.app/Contents/Developer
CLT: <IP_ADDRESS>.1.1476494586
X11: N/A

I've tried to unmount the first drive and then homebrew found correct Xcode, but when I mount it back Homebrew switching to wrong Xcode version from first drive.

What are the full paths of both of your Xcodes? Thanks!

XCode 5.1 - /Volumes/MAC X 9/Applications/Xcode.app
XCode 8.1 - /Applications/Xcode.app
Don't know does it make sense or not but installing sequence was the following:

install homebrew on just installed fresh osx 10.12.1
homebrew asked to install CLT. I've installed it
homebrew said that I have outdated XCode 5.1 and need update it to 8.1
installed XCode 8.1 from App Store.
homebrew still doesn't see XCode 8.1

It might be important to check the xcode-select path by running xcode-select -p on the terminal to see which one is taking priority on the system. That should be based on your boot disk, not any attached disk.

@samdmarshall Thanks for the comment, I think we already factor this in but I'm thinking a general rule to always prioritise e.g. /Applications over /Volumes is the right thing.

To be explicit: @AndrejSoroj can you paste the output of your xcode-select -p here? Thanks!

$ xcode-select -p
/Library/Developer/CommandLineTools

@AndrejSoroj You should probably sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer

Isn't this a duplicate of https://github.com/Homebrew/legacy-homebrew/issues/47579 which was closed: https://github.com/Homebrew/legacy-homebrew/issues/47579#issuecomment-222317018

@ilovezfs Yep, more or less. I might actually try to fix it this time, though 😉

The "broken" behavior is much more fun, though.

@MikeMcQuaid is there any development work that I could help with to move this issue along?
I also wanted to verify with you that the fix that gets implemented properly addresses this case:
If I have Xcode on my computer, but xcode-select is pointed to the CLT, which is a newer version than the Xcode.app, my expectations are that brew will

use the CLT for building.
not complain about Xcode versions being out of date.

@samdmarshall I'd have loved you to help with that but I'd just finished the PR in https://github.com/Homebrew/brew/issues/1816.

use the CLT for building.

This was already the case 👍

not complain about Xcode versions being out of date.

This is not the case because some buildsystems don't require Xcode but will find and use it if it's there. We no longer block installation unless Xcode is extremely outdated but we'll still warn about it (but it can be safely ignored). I appreciate the warning may be annoying but because we don't control upstream build systems we need to optimise for our own support load.

As long as they are not going to prohibit building unless the requirement is on having Xcode.app, not the CLT, then i'm ok with that. My experience was the mere act of having the older version of Xcode.app found on the system prevented any brew installation, regardless of requirements.

That issue should be fixed now (or in the next tag, depending). If it is not, please feel free to chime in because how you describe it is how I want it to be 👍

The brew feature to search and find Xcode.app using spotlight caused an error message and confusion.
Scenario:
Day 1: New Mac install homebrew and many applications using brew.
Day 5: Move a usb drive with Time Machine backups from the old machine to the new machine.
Day 6: brew update reports xcode is out of date.
With a few hours of research[1], I understand how and why brew has discovered a new (old) version of xcode.
brew config
...
Xcode: /Volumes/USB Drive/Backups.backupdb/MBP/2015-12-29-003755/Macintosh HD/Applications/Xcode.app/Contents/Developer
CLT: <IP_ADDRESS>.1.1492020469
...

/Volumes/USB Drive/Backups.backupdb/ is a time machine backup from another machine. In this case it would have been nice for brew to not pull Xcode.app locations out of the time machine backup.
Thanks for all the hard work the brew team puts it, it is very appreciated.
[1] (https://github.com/Homebrew/brew/issues/1587 https://github.com/Homebrew/legacy-homebrew/issues/47579 https://github.com/Homebrew/legacy-homebrew/pull/47752)

@giovino We'll consider rejecting Xcodes from the backup directory. In future please don't comment on closed issues with your own take, thanks.


feat: allow multiple incremental commits in optimize

Currently "optimize" executes the whole plan in one commit, which might fail. The larger the table, the more likely it is to fail and the more expensive the failure is.
Add an option in OptimizeBuilder that allows specifying a commit interval. If that is provided, the plan executor will periodically commit the accumulated actions.

clippy is complaining that create_merge_plan has too many arguments. After looking at that function, and at the MergePlan struct, I noticed that they take and store some things which, rather than describing the plan itself, describe how to execute it: max_concurrent_tasks, max_spill_size, and min_commit_interval.
Should we move those out of MergePlan and create_merge_plan, and add them as arguments to MergePlan.execute()?

Should we move those out of MergePlan and create_merge_plan, and add them as arguments to MergePlan.execute()?

Yeah that sounds like a good idea 👍

Should we move those out of MergePlan and create_merge_plan, and add them as arguments to MergePlan.execute()?

Yeah that sounds like a good idea 👍

Done.

@kvap is this option also exposed to the python bindings?


Create Prototype build with New Flux

We want to rapidly prototype the new Flux syntax. For that we have used the colm project to translate the new Flux syntax to existing syntax. See for details on the new syntax and features https://github.com/influxdata/flux/pull/2617
This is not the final implementation rather a way to prototype what using the new syntax would feel like.
We need a build of OSS that embeds the colm program and translates Flux on the fly so users can try it out.

Prototype merged to master in https://github.com/influxdata/flux/pull/2744. Enabling it causes table flux to be transformed to flux in the main entry point.
Binaries available:
https://s3.amazonaws.com/dl.influxdata.com/experimental/influxd-2.0.0-tableflux.0_darwin_amd64.tar.gz
https://s3.amazonaws.com/dl.influxdata.com/experimental/influxd-2.0.0-tableflux.0_linux_amd64.tar.gz


README.md: pull emoji data accurately

(Nit) Copy and paste lines to update the data in-place without any renaming in the future. 🤠

All around your changes were great, thanks for helping to improve my simple tool
ᕕ( ᐛ )ᕗ

ᕕ( ಠ_ಠ)ᕗ


Linting, round 2

This PR:

adds a bunch of new files up to spec with eslint
adds disables where necessary or where we don't want to change logic without tests yet (with appropriate FIXME notes in the source code
removes the old magellan-director binary, redundant
renames files in form xyz-xyz.js to xyz_xyz.js

/cc @geekdave @archlichking

:+1:


Decouple Cordova from PhoneGap

Waiting on Cordova-Common 1.4.1 release!
Need to publish Cordova-Create and Phonegap-Cordova-Dependence on npm.

closing in favor of https://github.com/phonegap/phonegap-cli/pull/650


lost settings

hi thanks for this its great ,
all was working great up to today when everything went tits up.
all setting gone i tried setting up but kept going funny so had to reinstall . now working great again.
keEp up the good work
thanks
martin

Thank you Martin. We discussing lost setting issue here: https://github.com/widapro/wledPixel/issues/24


Added buttons to pattern library

Fixes #8661.
I have tried to add all the existing buttons in styleguide to our Pattern Library(Storybook).
After:

Couldn't add the buttons with icons because the icon template tag isn't working in buttons.stories.tsx. Might need to hard code them.

Looking good but maybe this would be better in a table?

Columns could be; default, default disabled, small, small disabled
Rows could be each type; default (basic), secondary, positive/yes, negative/no, icon only, longrunning

This will make it easier to visually compare them at a glance.

Classes are way too inconsistent to be in table in my opinion

Note - ready to review


Support for 0.8.0

https://github.com/OpenZeppelin/openzeppelin-contracts seems like 0.8.0 become standard, can we make docgen now support generation for 0.8.0 ?

Hi @JackBekket. You should be able to use 0.8 using the steps shown in the readme for 0.7. Have you tried this?

It seems that it cannot be applied to the version above 0.8.0. When I compile my project, it reminds me: Error: Solidity was unable to compile. contracts/Ownable.sol:3:1: ParserError: Source file requires different compiler version (current compiler is
0.7.6+commit.7338295f.Emscripten.clang)-note that nightly builds are considered to be strictly less than the released version
pragma solidity ^0.8.0;
^---------------------^

I am using the 0.8.0 version of the standard Ownable*

@YanLong-111
I suggest you to check your solc compiler version
Note, that global solc version can be different from solc, that you use locally in your repo
I have been required to install some additional package (don't remember its name), which has allowed me to have several versions of solc and switching between them, in order to make solidity-docgen work

However, generated docs was look.. let's say it was not in good shape, so I decided to refuse using solidity-docgen after all

@JackBekket
Oh, thank you, I generated the document in an inexplicable situation (it returned me an error message, but still generated the document), but this is not what I want, so I support your point of view, and also thank the developers Work hard, hope it will get better

Closing this as support for 0.8 is there.
If you were unhappy with the output please share! This tool requires a lot of customization currently. Feedback is welcome.


Fix bug UpdateBy() doesn't update index correctly

Signed-off-by: yah01<EMAIL_ADDRESS>

Codecov Report

Merging #7 (7a9ceb8) into main (1f48a56) will increase coverage by 18.93%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   56.21%   75.14%   +18.93%
===========================================
  Files           3        3
  Lines         169      169
===========================================
+ Hits           95      127       +32
+ Misses         68       37       -31
+ Partials        6        5        -1

Impacted Files
Coverage Δ

map.go
69.23% <80.00%> (+27.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f48a56...7a9ceb8. Read the comment docs.


Bug:

What happened?
{file.filename} outputs {unknown_property} on embeds.
Example: https://cdn.joshsevero.dev/u/Kvmolw.png
Version
latest (ghcr.io/diced/zipline:latest)
What browser(s) are you seeing the problem on?
No response
Zipline Logs
There we no errors that I could see

Browser Logs
No response
Additional Info
No response

The property is {file.file} not {file.filename}. The docs are a bit outdated, sorry.

Ah, ok. Thanks that fixed it


locate binary with less subprocesses

Q
A

Bug fix?
No

New feature?
No

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

to optimize resource consumption.
before this change, the number of subprocesses required to locate a binary was 2 in the best case and 6 in the worst case.
after this change it always requires 1 process, no matter which command will be used at the end (whether command -v, which or type -p)

@antonmedv any feedback?

Sorry, for delay. Will test it today and merge it.

Ping


Add a "Share Progress" Button on the Audiobook Player Page

Description:
Implement a "Share Progress" button on the audiobook player page that allows users to generate a unique link with the current time in the audiobook.
Users can share the link with friends, and they’ll be able to pick up the audiobook from the same point.
Acceptance Criteria:
Add a "Share Progress" button next to the playback controls.
Generate a unique URL that includes the current playback time.
Ensure the shared link opens the audiobook at the correct timestamp.

Basically I have to build a share a progress button which generates a link to the audio at current time stamp and the link is copied to our clipboard right?

I will merge your pull request @Tomkndn. have you created one ?

@Tomkndn are u working on it ?

@Tomkndn are u working on it ?

yeah working on it

ok @Tomkndn great

one doubt
I should generate a link that will be displayed somewhere or simply the link will be copied to clipboard.

also please suggest the button where to align or color or anything....

?

Hey @Tomkndn Go ahead and fetch the latest  code that add your changes

Add the button with share faviorite and comment Icon below book cover.

have a look

is this okay
should i create PR for this now?

Yes create one but you should fetch the latest code

ok

@Tomkndn 👍🏼


Volume button isn't hiding on iOS.

in version 2.13.0. If you revert to 2.12.0 it works.

@jordanbrown Closing old issues. If you'd like to reopen this, let us know. Thanks!


OpenSSL, DER, Static Linking

Right now, the Windows (and presumably Mac) wallets are static linked, while *nix is dynamic.  Considering that some versions of OpenSSL are known to break blockchains, should we tighten-up our dependencies and make all compiles static?

We should have instructions for building with static and dynamic linked binaries.

Maybe.  The time I joined we had static linking for Windows and Mac and dynamic linking for *nix.  Blak's reported that he hasn't yet been able to generate a static wallet on Ubuntu.


Return key does not work on Windows host

From Instabug bug report 31:
The onscreen keyboard Return key does not work when connecting to an ssh server running on Windows.
When testing on simulator, the Return key on the physical Mac keyboard works as expected.

Thanks for responding the issue. Here attached the image. I’m testing with CMD and PowerShell getting the same results.

I’m using oh-my-posh I will like support for Fonts  like Nerd Font

This should be fixed on the next release


Support minimum contrast ratio of characters

Description of the new feature/enhancement
It would be great if the foreground color of rendered text in terminal change dynamically to meet a specified contrast ratio, like this.

Proposed technical implementation details (optional)

This sounds similar to what issue #2638 evolved into.

Yea I think @j4james has got this right. Thanks!
/dup #2638


NavigationViewTemplateSettings.OpenPaneLength API Spec

API spec for NavigationViewTemplateSettings.OpenPaneLength.

@Karl-Bridge-Microsoft @MikeHillberg @david-risney Any additional comments or ready to merge?

/azp run

@Karl-Bridge-Microsoft @MikeHillberg @david-risney Any additional comments or ready to merge?

Cleaning up old PRs, can we merge in?

/azp run


Invalid CSRF token using Axios

Structuring The Issue
Brief Description
Hello,
i have this sample API
Route.group(() => {
  Route.get('/hello', () => ({
    greeting: 'This is the real hello world '
  }))
  Route.post('/hello', async ({request}) => {
    console.log(request)
    return { greeting: 'Hello from POST!!' }
  })
}).prefix('test');

and when i call it from Axios or Postman
the GET works fine.
the POST show:
HttpException
EBADCSRFTOKEN: Invalid CSRF token

its the same problem when using axios from another frontend app.
its about CSRF token !!  how can i handle this?
thank you.

For those with the same problem you can get the value of the csrfField and set in your request header like below:
xhr.setRequestHeader('x-csrf-token', document.querySelector('[name="_csrf"]').value);
If you use the Key X-XSRF-TOKEN to set the cookie value of XSRF-TOKEN it will not work, even though it's in the docs...

Yeah, it doesn't work. Seems like the XSRF-TOKEN cookie token is much longer than the value from '{{ csrfToken }}'.
I would really like this to work as documented, since the frontend could be hosted separately.

You could add API routes to filtered urls, like this.
in config/shield.js
Modify:
csrf: {
    cookieOptions: {
      httpOnly: false,
      maxAge: 7200,
      path: '/',
      sameSite: true,
    },
    enable: true,
    filterUris: ['/api/(.*)'],
    methods: ['POST', 'PUT', 'DELETE'],
  }

Hey @NadhirBoukhenifra! 👋
It seems that you are building an API Only backend. I recommend you to disable the CSRF protection if it's the case.
You can do that by changing the value in the config/shield.js file.
More information about disabling CSRF protection on a REST API.

Thank you


Error when open admin/user when login as other role except super-admin

I have an issue, when i login as Example User in this case has writer role, and writer role has permission to list user. when i click the Users menu it showed this error:
Too few arguments to function BalajiDharma\LaravelAdminCore\Policies\PermissionPolicy::adminUpdate(), 1 passed in F:\sman2web\vendor\laravel\framework\src\Illuminate\Auth\Access\Gate.php on line 811 and exactly 2 expected
this also happen with other role except super-admin role, although make another role with all permission is not solved the issue.
this issue has no impact on super-admin role as i known this permission managed by Gate:before rule at AuthServiceProvider.
sorry, my english is bad, but maybe you can help me with this issues

@kepinaza try with the latest released version

Still getting this problem where i am using latest version 2.x

@rajucs do the composer update and verify it.

Thank you so much worked fine.


code-editor needs to support full html documents

bc of limitations in
 can hack this though so with their powers combined, they are a full html doc editor

9.0.26 resolves this.


Docker build killed while running setup.py

System Info
OS Version: Ventura 13.4.1 (c)
Information

[ ] Docker
[X] The CLI directly

Tasks

[ ] An officially supported command
[X] My own modifications

Reproduction
Run docker build -f Dockerfile -t text-generation-inference .
I see the following logs. It seems to fail because something went wrong in ninja
 => CANCELED [builder 10/10] RUN cargo build --release                                                         190.1s
------
 > [custom-kernels-builder 3/3] RUN python setup.py build:
#28 15.91 No CUDA runtime is found, using CUDA_HOME='/opt/conda'
#28 16.00 running build
#28 16.00 running build_ext
#28 16.36 /opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py:398: UserWarning: There are no g++ version bounds defined for CUDA version 11.8
#28 16.36   warnings.warn(f'There are no {compiler_name} version bounds defined for CUDA version {cuda_str_version}')
#28 16.37 building 'custom_kernels.fused_bloom_attention_cuda' extension
#28 16.37 creating /usr/src/build
#28 16.38 creating /usr/src/build/temp.linux-x86_64-cpython-39
#28 16.38 creating /usr/src/build/temp.linux-x86_64-cpython-39/custom_kernels
#28 16.51 Emitting ninja build file /usr/src/build/temp.linux-x86_64-cpython-39/build.ninja...
#28 16.52 Compiling objects...
#28 16.52 Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
#28 408.2 [1/1] /opt/conda/bin/nvcc  -I/opt/conda/lib/python3.9/site-packages/torch/include -I/opt/conda/lib/python3.9/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.9/site-packages/torch/include/TH -I/opt/conda/lib/python3.9/site-packages/torch/include/THC -I/opt/conda/include -I/opt/conda/include/python3.9 -c -c /usr/src/custom_kernels/fused_bloom_attention_cuda.cu -o /usr/src/build/temp.linux-x86_64-cpython-39/custom_kernels/fused_bloom_attention_cuda.o -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options ''"'"'-fPIC'"'"'' -arch=compute_80 -std=c++17 -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=fused_bloom_attention_cuda -D_GLIBCXX_USE_CXX11_ABI=0
#28 408.2 FAILED: /usr/src/build/temp.linux-x86_64-cpython-39/custom_kernels/fused_bloom_attention_cuda.o
#28 408.2 /opt/conda/bin/nvcc  -I/opt/conda/lib/python3.9/site-packages/torch/include -I/opt/conda/lib/python3.9/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.9/site-packages/torch/include/TH -I/opt/conda/lib/python3.9/site-packages/torch/include/THC -I/opt/conda/include -I/opt/conda/include/python3.9 -c -c /usr/src/custom_kernels/fused_bloom_attention_cuda.cu -o /usr/src/build/temp.linux-x86_64-cpython-39/custom_kernels/fused_bloom_attention_cuda.o -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options ''"'"'-fPIC'"'"'' -arch=compute_80 -std=c++17 -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=fused_bloom_attention_cuda -D_GLIBCXX_USE_CXX11_ABI=0
#28 408.2 /opt/conda/lib/python3.9/site-packages/torch/include/c10/util/irange.h(54): warning #186-D: pointless comparison of unsigned integer with zero
#28 408.2           detected during:
#28 408.2             instantiation of "__nv_bool c10::detail::integer_iterator<I, one_sided, <unnamed>>::operator==(const c10::detail::integer_iterator<I, one_sided, <unnamed>> &) const [with I=size_t, one_sided=false, <unnamed>=0]"
#28 408.2 (61): here
#28 408.2             instantiation of "__nv_bool c10::detail::integer_iterator<I, one_sided, <unnamed>>::operator!=(const c10::detail::integer_iterator<I, one_sided, <unnamed>> &) const [with I=size_t, one_sided=false, <unnamed>=0]"
#28 408.2 /opt/conda/lib/python3.9/site-packages/torch/include/c10/core/TensorImpl.h(77): here
#28 408.2
#28 408.2 /opt/conda/lib/python3.9/site-packages/torch/include/c10/util/irange.h(54): warning #186-D: pointless comparison of unsigned integer with zero
#28 408.2           detected during:
#28 408.2             instantiation of "__nv_bool c10::detail::integer_iterator<I, one_sided, <unnamed>>::operator==(const c10::detail::integer_iterator<I, one_sided, <unnamed>> &) const [with I=std::size_t, one_sided=true, <unnamed>=0]"
#28 408.2 (61): here
#28 408.2             instantiation of "__nv_bool c10::detail::integer_iterator<I, one_sided, <unnamed>>::operator!=(const c10::detail::integer_iterator<I, one_sided, <unnamed>> &) const [with I=std::size_t, one_sided=true, <unnamed>=0]"
#28 408.2 /opt/conda/lib/python3.9/site-packages/torch/include/ATen/core/qualified_name.h(73): here
#28 408.2
#28 408.2 Killed
#28 408.2 ninja: build stopped: subcommand failed.
#28 408.6 Traceback (most recent call last):
#28 408.6   File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1893, in _run_ninja_build
#28 408.7     subprocess.run(
#28 408.7   File "/opt/conda/lib/python3.9/subprocess.py", line 528, in run
#28 408.7     raise CalledProcessError(retcode, process.args,
#28 408.7 subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
#28 408.7
#28 408.7 The above exception was the direct cause of the following exception:
#28 408.7
#28 408.7 Traceback (most recent call last):
#28 408.7   File "/usr/src/setup.py", line 4, in <module>
#28 408.7     setup(
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/__init__.py", line 87, in setup
#28 408.7     return distutils.core.setup(**attrs)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 185, in setup
#28 408.7     return run_commands(dist)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
#28 408.7     dist.run_commands()
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
#28 408.7     self.run_command(cmd)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/dist.py", line 1208, in run_command
#28 408.7     super().run_command(command)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
#28 408.7     cmd_obj.run()
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/command/build.py", line 132, in run
#28 408.7     self.run_command(cmd_name)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
#28 408.7     self.distribution.run_command(command)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/dist.py", line 1208, in run_command
#28 408.7     super().run_command(command)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
#28 408.7     cmd_obj.run()
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/command/build_ext.py", line 84, in run
#28 408.7     _build_ext.run(self)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 346, in run
#28 408.7     self.build_extensions()
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 843, in build_extensions
#28 408.7     build_ext.build_extensions(self)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 468, in build_extensions
#28 408.7     self._build_extensions_serial()
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 494, in _build_extensions_serial
#28 408.7     self.build_extension(ext)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/command/build_ext.py", line 246, in build_extension
#28 408.7     _build_ext.build_extension(self, ext)
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 549, in build_extension
#28 408.7     objects = self.compiler.compile(
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 658, in unix_wrap_ninja_compile
#28 408.7     _write_ninja_file_and_compile_objects(
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1574, in _write_ninja_file_and_compile_objects
#28 408.7     _run_ninja_build(
#28 408.7   File "/opt/conda/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1909, in _run_ninja_build
#28 408.7     raise RuntimeError(message) from e
#28 408.7 RuntimeError: Error compiling objects for extension
------
executor failed running [/bin/sh -c python setup.py build]: exit code: 1

Expected behavior
the image builds without any error

Sorry building the docker image is something we take care of and have no interest of maintaining on arbitrary envs.
Either use the local CLI or the released docker image.


feature: CLI dispatcher

I made all CLI packages follow a convention:

def make_parser(parser=None, prog=None) either creates a parser or adds arguments to one that’s being passed
def run(args=None) either runs from passed args (argparse.Namespace) or parses sys.argv using make_parser

Together, that allows to maintain backwards compatibility, as python -m hatch_jupyter_builder.migrate is still possible and works the same as the new hatch-jupyter-builder migrate.
Fixes #62
Results:
$ hatch-jupyter-builder -h
usage: hatch-jupyter-builder [-h] {migrate,compare-migrated} ...
...
$ python -m hatch_jupyter_builder -h
usage: /usr/bin/python -m hatch_jupyter_builder [-h] {migrate,compare-migrated} ...

positional arguments:
  {migrate,compare-migrated}

options:
  -h, --help            show this help message and exit

$ hatch-jupyter-builder migrate -h
usage: hatch-jupyter-builder migrate [-h] target_dir
...
$ python -m hatch_jupyter_builder migrate -h
usage: /usr/bin/python -m hatch_jupyter_builder migrate [-h] target_dir
...
$ python -m hatch_jupyter_builder.migrate -h
usage: /usr/bin/python -m hatch_jupyter_builder.migrate [-h] target_dir

positional arguments:
  target_dir  Target Directory

options:
  -h, --help  show this help message and exit

$ hatch-jupyter-builder compare_migrated -h
usage: hatch-jupyter-builder compare_migrated [-h] source_dir target_dir dist_name
...
$ python -m hatch_jupyter_builder compare_migrated -h
usage: /usr/bin/python -m hatch_jupyter_builder compare_migrated [-h] source_dir target_dir dist_name
...
$ python -m hatch_jupyter_builder.compare_migrated -h
usage: /usr/bin/python -m hatch_jupyter_builder.compare_migrated [-h] source_dir target_dir dist_name

positional arguments:
  source_dir  Source Directory
  target_dir  Target Directory
  dist_name   Dist name

options:
  -h, --help  show this help message and exit

Failure is unrelated.  Thanks again!

https://github.com/jupyterlab/hatch-jupyter-builder/releases/tag/v0.6.0

neat, thank you for the quick review!


Add distributed server, add comments, and clean code

Add distributed server with broker, worker, zookeeper, and hdfs.
Replace server with SpringBoot
Add comments
Clean code
Remove dimension variable

I reviewed some code about io and storage layout. Do not delete test data file under test/resources/TestData @NLGithubWP

OK, Added

I reviewed some code about io and storage layout. Do not delete test data file under test/resources/TestData @NLGithubWP

OK, Added

This PR works in my side.
For changes in part of io and storage layout, it is acceptable.
If you want to merge, do not forget to rebase or squash your commit log, which can help us manage the history of commit.

I reviewed some code about io and storage layout. Do not delete test data file under test/resources/TestData @NLGithubWP

OK, Added

This PR works in my side. For changes in part of io and storage layout, it is acceptable. If you want to merge, do not forget to rebase or squash your commit log, which can help us manage the history of commit.

Rebased

The server has been changed from jetty to Springboot

This PR also removes the need for the dimension file.

Just tried the build the project and test the standalone spring server and found the following issues

removal of the shade plugin broke our command line samples. (dependencies not packaged into the jar). However if I add back the shade plugin, I am not able to launch spring server.

022-04-28 20:38:13.592 ERROR 16618 --- [           main] o.s.b.w.e.t.TomcatStarter                : Error starting Tomcat context. Exception: org.springframework.beans.factory.BeanCreationException. Message: Error creating bean with name 'formContentFilter' defined in class path resource [org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.web.servlet.filter.OrderedFormContentFilter]: Factory method 'formContentFilter' threw exception; nested exception is java.lang.NoClassDefFoundError: Could not initialize class com.fasterxml.jackson.annotation.JsonInclude$Value

Incorrect result for health data set selection. I added back the shade plugin and tested the different variation of loading, sogamo query0 and health query1-0. The result of query 1-0 differs from current head of main. (p-1 missing). We need to make sure the results are consistent. @KimballCai @NLGithubWP please check the aggregation, funnel, iceberg results.
Standalone server API: listing and loading seems working. But i cannot run the selection and analysis APIs.

{"timestamp":"2022-04-28T13:06:12.417+00:00","status":415,"error":"Unsupported Media Type","path":"/cohort/selection"}

or
Failed to open/read local data from file/application

even the file exist under the directory

Just tried the build the project and test the standalone spring server and found the following issues

removal of the shade plugin broke our command line samples. (dependencies not packaged into the jar). However if I add back the shade plugin, I am not able to launch spring server.

022-04-28 20:38:13.592 ERROR 16618 --- [           main] o.s.b.w.e.t.TomcatStarter                : Error starting Tomcat context. Exception: org.springframework.beans.factory.BeanCreationException. Message: Error creating bean with name 'formContentFilter' defined in class path resource [org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.boot.web.servlet.filter.OrderedFormContentFilter]: Factory method 'formContentFilter' threw exception; nested exception is java.lang.NoClassDefFoundError: Could not initialize class com.fasterxml.jackson.annotation.JsonInclude$Value

Incorrect result for health data set selection. I added back the shade plugin and tested the different variation of loading, sogamo query0 and health query1-0. The result of query 1-0 differs from current head of main. (p-1 missing). We need to make sure the results are consistent. @KimballCai @NLGithubWP please check the aggregation, funnel, iceberg results.
Standalone server API: listing and loading seems working. But i cannot run the selection and analysis APIs.

I have checked this problem. It is correct that P-1 is missing because we have defined the time window where selected patients must have records of more than 7 days. This problem has been discussed in PR #25.

{"timestamp":"2022-04-28T13:06:12.417+00:00","status":415,"error":"Unsupported Media Type","path":"/cohort/selection"}

or
Failed to open/read local data from file/application

even the file exist under the directory


Strict pyright

Closes #
Successful PR Checklist:

[ ] Tests

[x] (not applicable?)

[ ] Documentation

[x] (not applicable?)

PR label(s):

[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/breaking
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/feature
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/bugfix
[x] https://github.com/ewjoachim/poetry-to-pre-commit/labels/miscellaneous
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/dependencies
[ ] https://github.com/ewjoachim/poetry-to-pre-commit/labels/documentation

CI failed because I used the "new" notation to type with builtin dict instead of from typing import Dict. Sorry, I forgot to check that beforehand :-/

Yeah I find it more readable to use quotes when we need (plus from __future__ import annotations)


Nutrition compartments children under 5 data circle card working incorrectly

Nutrition compartments children under 5 data circle card should not show any data on the hierarchical data table when clicked.

Closing this though need to clarify that the item should be should show data on the hierarchical table. Currently works.


Implement renyi elbo

This pull request adds Renyi Elbo. In the case alpha = 0, we have IWELBO.
I wrote the derivation here for reference. Note that this works with non-parameterizable variables too.
Todo list:

[x] Implement
[x] Add docs, comments
[x] Add tests

To reviewers: I cannot find parameters to pass BernoulliBeta test so I leave an xfail mark there. To be honest, I am not so sure about the correctness of my implementation w.r.t. iarange context in Pyro, so it is hard for me to detect bugs in my code. Please help me debug the code if possible. Thanks in advance!

@fehiepsi: The gradient computation seems to be off by a huge magnitude in test_gradient.py::test_iarange_elbo_vectorized_particles. You can add RenyiELBO to the test parameters to replicate. When you set the weights to 1., you do retrieve the correct gradient (as you should given that it is no different from Trace_ELBO). However, with the importance weights (which seem to be correctly scaled), the gradients are hugely off (maybe there is some unaccounted gradient flowing back?).

Thanks @neerajprad! This gradient off might be relevant to https://github.com/pytorch/pytorch/pull/8721: the log_prob in guide_trace will be expanded to be added into surrogate_loss. I still can not figure out what is the reason now but will go deeper into it in the next couple of days.

I still can not figure out what is the reason now but will go deeper into it in the next couple of days.

Sure, let me know if you face any issues. I will also try debugging this at my end.

@neerajprad I think that this article points out the reason for grad off https://arxiv.org/abs/1802.04537. They showed that "the probability that the gradient is positive or negative becomes roughly equal for larger values of K, meaning the optimizer is equally likely to increase as decrease the inference network parameters at the next iteration." (K is num_particles).

@neerajprad I think that there is something wrong related to log_prob_sum and log_prob.expand(shape).sum(). I will check this.

Yes, in ELBO, we take the log_prob_sum without expanding to independent dimensions. In Renyi, I expand the log_prob for independent dimensions, then take log_prob_sum.

In Renyi, I expand the log_prob for independent dimensions, then take log_prob_sum.

Could you point me to the code where we are expanding site['log_prob']? I think site['log_prob'] should already reflect all the existing batch dimensions, right? With auto_vectorize=True the outermost batch dimension should already be included in log_prob.shape.

I have refactored the code. It is good to review if tests pass.

@neerajprad Did you mean that we will change
        if self.num_particles == 1:
            elbo = elbo_trace[0]
            surrogate_elbo_particles = surrogate_elbo_trace[0]
        else:
            if is_vectorized:
                elbo_particles = elbo_trace[0]
                surrogate_elbo_particles = surrogate_elbo_trace[0]
            else:
                elbo_particles = torch.stack(elbo_trace)
                surrogate_elbo_particles = torch.stack(surrogate_elbo_trace)

            elbo_particles_scaled = (1. - self.alpha) * elbo_particles
            elbo_scaled = log_sum_exp(elbo_particles_scaled, dim=0) - math.log(self.num_particles)
            elbo = elbo_scaled.sum().item() / (1. - self.alpha)

into this
        if not is_vectorized:
            elbo_particles = torch.stack(elbo_trace)
            surrogate_elbo_particles = torch.stack(surrogate_elbo_trace)
        else:
            elbo_particles = elbo_trace[0]
            surrogate_elbo_particles = surrogate_elbo_trace[0]

        if self.num_particles == 1:
            elbo = elbo_particles
        else:
            elbo_particles_scaled = (1. - self.alpha) * elbo_particles
            elbo_scaled = log_sum_exp(elbo_particles_scaled, dim=0) - math.log(self.num_particles)
            elbo = elbo_scaled.sum().item() / (1. - self.alpha)

@neerajprad Did you mean that we will change

I meant something like this (I could totally be oversimplifying! :) ) :
    def loss_and_grads(self, model, guide, *args, **kwargs):
        elbo_particles = []
        surrogate_particles = []
        is_vectorized = self.vectorize_particles and self.num_particles > 1

        for model_trace, guide_trace in self._get_traces(model, guide, *args, **kwargs):
            ...
            # Append to containers
            surrogate_particles.append(surrogate_elbo_particle)
            elbo_particles.append(surrogate_elbo_particle)

        # handle vectorized / non vectorized case
        if is_vectorized:
            elbo_particles = elbo_particles[0]
            surrogate_particles = surrogate_particles[0]
        else:
            elbo_particles = torch.stack(elbo_particles)
            surrogate_particles = torch.stack(surrogate_particles)
        ...
        # compute weights
        scaled_weights = (1 - self.alpha) * elbo_particles
        log_mean_weight = log_sum_exp(scaled_weights) - math.log(self.num_particles)
        weights = (scaled_weights - log_mean_weight).exp()

        if trainable_params and getattr(surrogate_particles, 'requires_grad', False):
            surrogate_elbo = -(weights * surrogate_particles).sum() / self.num_particles
            surrogate_elbo.backward()

        # return losses
        loss = - (1. / (1. - self.alpha) * log_mean_weight)
        warn_if_nan(loss, "loss")
        return loss

Thanks, @neerajprad! I will change it accordingly.

Thanks for all the work you put into this, @fehiepsi! Let me know if this is good to merge.

Yes, it is ready to me. :)


feat: add VIP mac address input panel

Problem:

This PR updates the ISO installation mode to support manual override of the VIP's MAC address in DHCP mode. This allows the installer to request for specific static IP address that is bound to a particular MAC address, over DHCP. It brings parity to the DHCP VIP configuration between the automatic and ISO installation modes.
Solution:

The ISO installer console is updated to include a new MAC Address field on the VIP page in DHCP mode:

If this new field has a MAC address value, the installer will request for the associated static IP address from the DHCP server
Otherwise if this field is left blank, the installer falls back to the current behaviour of determining the VIP and MAC address

On the VIP page, the subsequent input panels that will be shown are based on the method selected by the user:

Choosing DHCP reveals both the MAC Address and VIP input panels:

Choosing Static reveals only the VIP input panel:

Related Issue:
Fix https://github.com/harvester/harvester/issues/6960.
Test plan:

Test Case 1 - Request For Static VIP Address Using Custom MAC Address
Follow the instructions in this gist to add custom MAC/IP address bindings to the local kvm dnsmasq
On the VIP page, input the custom MAC address (32:34:1a:75:7f:64):

Expect the installer to receive the pre-configured static IP (<IP_ADDRESS>) from the DHCP server

Complete the rest of the installation setup to provision Harvester

Expect the management node to be ready

Provision a worker node to join the cluster targeting the static VIP address

Expect the worker to be successfully added to the cluster

Test Case 2 - Let Installer Determine The VIP and MAC Address
On the VIP page, leave the MAC and VIP addresses blank

Expect the installer to receive a new VIP from the DHCP server with a new random MAC address

Complete the rest of the installation setup to provision Harvester

Expect the installation to complete successfully

Provision a worker node to join the cluster via the static VIP address

Expect the worker to be successfully added to the cluster

@w13915984028 let me know what you think of this approach.


Clean up component folder

Closes #165
Closes #180
This branch cleans up the component folder, moved Drawer to our atom component index, moved chips to Chips folder for better folder organization and update the icon for import button

I'll say since we have an approval, we can probably merge this...


Q: Can we move googleapis BUILD rules into googleapis repo?

We currently define our own C++ build rules for the protos in the googleapis repo. Here's our BUILD file for it: https://github.com/googleapis/google-cloud-cpp/blob/master/bazel/googleapis.BUILD
However, it looks like the googleapis repo has a spot where we could put the C++ build rules right in their BUILD files. See here: https://github.com/googleapis/googleapis/blob/cda99c1f7dc5e4ca9b1caeae1dc330838cbc1461/google/spanner/v1/BUILD.bazel#L373-L376
Is there any reason we shouldn't do this? It seems like it shouldn't be too difficult and may be a good idea to move the build rules for the googleapis proto into that repo.

I think the answer is yes, and we have bugs open to do so (#3347)


Hugo: equal column width

added calculation of column width depending on number of columns, up to 4 columns.

For: https://linear.app/usmedia/issue/CUE-183
Preview: https://deploy-preview-341--cue.netlify.app/docs/introduction/tour/validation/

Closed via 2a1716e01144ed433d99c68d5674f0ae491b74fa


Carbonite quest menu support

Add Play button to the bottom right corner of Carbonite quest log menu

Carbonite-WotLK-3.3.5a.zip

Done with Release v1.0.2


Patch kube-vip to use hostname instead of "kubernetes" for apiserver …

…calls
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold for cli-side changes

/unhold


Import library issue

sorry, I forgot to upload jar to jCenter.
for now, you have to use this library importing through my maven repository like this
// set marven url
repositories {
  maven { url 'https://dl.bintray.com/takusemba/maven' }
}

// compile library in dependencies
dependencies {
    compile 'com.github.takusemba:multisnaprecyclerview:x.x.x'
}

Im adding this to jCenter now. After few hours you can import this library just like this below
dependencies {
    compile 'com.github.takusemba:multisnaprecyclerview:x.x.x'
}

added to jCenter, im closing this.


registerNotificationOpened isn't working as expected in iOS

registerNotificationOpened method isn't working as expected in the scenario:
when the app receives a notification in the foreground state and I open the app post killing the app by tapping on a notification.

But the given method is working as expected when the app receives a notification in the killed and background states and opens the app from the killed state by tapping a notification.

Notifications.events().registerNotificationOpened((notification: Notification, completion: () => void, action: NotificationActionResponse) => {
      completion();
});

Using the latest version: 5.1.0
RN version:0.72.5
iOS: 17.1.2

Similar issue here. The workaround was using notifee library for iOS
useEffect(() => {
   if (Platform.OS === 'ios') {
    return notifee.onForegroundEvent(({type, detail}) => {
      switch (type) {
        case EventType.PRESS:
          // Handle notification payload
          }
          break;
      }
    });
     }
  }, []);


NunjucksLoaderMixin will try and convert all templates

Currently NunjucksLoaderMixin will try and apply the njk_to_j2 function on all templates.
This may not necessarily be what we want.

NunjucksLoaderMixin has been deleted and replacement NunjucksExtension only converts Nunjucks templates (filename ending in .njk).


Scanner Support for Forseti Deployed with Folders Access

There are cases when customers only have access to a folder within the organization, and wants to use the Forseti scanners on the resources within the folder.
But to use the scanners, the data models need to be built, which currently can only be built if Forsei is rooted at the organization.

A potential workaround can be to suppress the exception as in PR #1770 in order to enable scanners to have the data needed for scanning.  (Currently, in order to crawl with folder-only access, we must specify the root_resource_id in the yaml config as folders/22222.)
Alternatively, if the customer only has folder access and still define the root_resource_id as organizations/11111, the crawler is unable to retrieve all the folders that the forseti has access to, because forseti is not given permission on the org level, to retrieve all the folders with the GCP API, AND the GCP API does not fallback to give all the folders that forseti has access to.  This workaround works on project-only accesses, because the project.list() API, does allow data model to be built for scanning projects.

@Red-Five and everyone
This has actually been supported since v2.4.0.
https://github.com/GoogleCloudPlatform/forseti-security/releases/tag/v2.4.0
Our documentations are here.
https://forsetisecurity.org/docs/latest/configure/general/non-org-root.html
So, I'm going to go ahead and close this issue.  But please feel free to follow-up with any questions.


UI style update

Connector UI is composed of plain default Bootstrap components. Update stylesheets and layout.

Change current UI to match the look of https://beta.suomi.fi/fi/.


Added armstrong-number.js

Why:
Closes #608 and #607
What's being changed:

Added armstrong-number.js, a JavaScript program to check if a number is an Armstrong Number.
Added armstrongnumber.go, a Go program to check if a number is an Armstrong Number.

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Hey @rossilor95
Thanks for your contributions to this project 👍🏻
This PR will be reviewed and merged shortly


fix(rbac): add patch verb on secrets to issuer clusterrole

Pull Request Motivation
This PR fixes a permission issue for Cluster and ClusterIssuer patching secrets. This fix was already done in the bitnami chart to fix https://github.com/cert-manager/cert-manager/issues/4802
Kind
bug
Release Note

NONE

/ok-to-test

This is a surprising PR, the issuer should only read & create secrets, not patch them: https://github.com/cert-manager/cert-manager/blob/master/pkg/issuer/acme/setup.go#L432-L440
The certificate controller does patch secrets: https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/templates/rbac.yaml#L129-L131

/hold

@inteon we've migrated back to the official helm chart (from the bitnami one) and everything is working fine, so going to close the PR


Doesn't run on Windows XP

I tried the 32 bit version on Windows XP 32bit, and Windows says it's not a valid Win32 application. Maybe it's not supported, but since it doesn't say anywhere, I thought I would file this issue. If not supported, is there an older version that is?

It's a feature not a bug!

I'm sure if you compile using the windows XP toolchain it'll work.


Two different forms, one model

The other questions that are similar to this one don't seem to address this; forgive me if I'm misunderstanding.
If I have a User model and a login view as well as a signup view, how do I make password2 required on the signup view but not on the login view? My model's validation object has password2 set to required: true and it appears to be applying this to both views, even if the login view doesn't have a password2 field to begin with.
I'm binding via Backbone.Validation.bind(this); in the view's initialize() method.

Same as https://github.com/thedersen/backbone.validation/issues/205. Lets keep talking there, please.

I opened this issue again due to a wrong understanding of it. Anyway, I'm taking care of your feature man — it makes sense a lot.

To validate a subset of the attributes is necessary to pass an array to isValid function:
model.isValid(['name', 'password2'])
model.isValid(['name'])
What can be implemented is e.g. an option to be passed when bind is called specifying what attributes to be validated

@blikblum It's time to automate this process. We'll pass an option to check the form based on its fields and then we validate what's within.

I think this feature could be implemented in two steps, so it can be flexible and non invasive:

Allow to pass custom attributes per binding. See WIP at #259
Create a default function that would return the attributes used in the form. Something similar (simpler) to https://github.com/adjohnson916/backbone.stickit.form .

It's important to keep things not coupled because there's no uniform way to store/retrieve attribute names in forms.
This schema would allow, e.g., have a function that gets the attributes from view.validationAttrs field other that reads from the form using input name attribute and a third one that uses an RegExp pattern

@blikblum I see your proposal being implicit and explicit — which is the same thing I thought. Implicit when there's something in the form our users don't want to validate and explicit when the entire form, according to the right field names, should be validated. :+1:
We should to go further discussing how we'll design these solutions. Please, let's talk faster on Gitter.

I +1 this feature.  We have a very similar requirement in our system where the same model in a given single page application might need different validations depending on where it is being loaded in the flow.  We had to fork the repo and ended up making a _validations object on the model that is a map of validations given some key (because the same single page app can load different validations on the given model).  If a key was set, and _validations existed, we loaded that set over the standard model.validation, otherwise we loaded the default.

@SomethingSexy Just wondering, would setting validation to be a function (and changing this library to accept that) also work? You could use properties on the model (or anything else accessible from the model instance) to determine which set of validation rules to return.

@platinumazure we thought about that but for our case (which might be very specific to us) we had to determine the configuration from outside of the model.  We have some components that can be reused with the same view and same model instance but need to load different configurations at run-time.

I am wondering if it possible to pass in your validation sets optionally instead of always pulling them from the model itself? When you are calling preValidate, isValid or validate, you could optionally pass in your validation.


fix: update a QueryBuilder.returning call because of the lucid breaking change

As mentioned here: https://github.com/adonisjs/auth/issues/195, the breaking change of lucid/knex about returning method broke the Auth package, so I fixed it
Migrated to the new version of Japa too

Let's keep PR's focused and small from next time. Makes it easy to revert if we have to :)

Thanks for the PR :)


In-class and off-class in estionian

As a guest I want to undersand better in estonian the difference of in-class and off-class activities

replaced with strings "tunnitöö" ja "muu"


[REQ] Option to pull from web (Https) if the API breaks?

Describe the problem
API is broken and clicking on subscription gets "Oops something is wrong" and retry button that loops the error message.
Users can't access any saved subscriptions or feeds at all from the app if the API is down
Describe the solution
As a fallback,
Can Squawker have an option, either by default or ask user, to try (Https://) to resolve the Page if the API is down?
Or a share option to send to a browser?
Thanks for the wonderful App

Do you mean an option to send to a browser a link to nitter?


rc3

This is not even close to what I would like to call a "release" but this can be finally deployed.

Have you tested your latest changes?

Honestly, I tested only Windows agent with a slightly older version of the registration code.


Do you plan to work on UI of the app?

If yes, I was wondering if you can adopt some of the features from Samsung browser.

Tabs list appears on bottom half of the screen and is scrollable

Settings menu is short and easy to operate also like Microsoft Edge

redesign homepage icons of the pinned website. e.g favicon sits in rectangular shape and is accessible from search bar.

For demo of above list, try Edge and Samsung Browser. They have done good job in this terms but since they do not provide bottom bar facility, I dislike those.
Lets make Kiwi Browser, mainstream browser ❤❤

About tab list I'm thinking of Vivaldi. Which is nice in phone.


EXSWHTEC-12 - Implement additional tests for hipIpcGetMemHandle

Verify that unique handles are returned for consecutive calls
Verify that unique handles are returned for separate allocations at same address
Verify that freed memory causes an error
Verify that out of bounds pointer will cause an error.

@music-dino / @mirza-halilcevic : Some tests failed on CI. Details shared separately.

PR updated, you can proceed with the merge.


[cminpack] not providing a config for debug target

Describe the bug
The cminpack port does not provide a config for debug target. This causes downstream projects to always link to the release library, and vcpkg fails to copy the correct dll to build folder.
Environment

OS: Windows 11
Compiler: MSVC

To Reproduce
Steps to reproduce the behavior:

./vcpkg install cminpack:x64-windows
Observe that there is only CMinpackConfig-release.cmake in vcpkg/packages/cminpack_x64-windows/share/cminpack.
Create a CMake project with find_package(CMinpack CONFIG REQUIRED) and link cminpack with target_link_libraries(main PRIVATE cminpack::cminpack).
Observe that for debug configuration, the generated VS sln still tries to link the release cminpack library cminpack.lib (in lib/) instead of the debug variant cminpack_d.lib (in debug/lib/)
Build the project in debug and observe that no dll is copied to the build folder.
However, everything works in release.

Expected behavior
There should also be a CMinpackConfig-debug.cmake so that downstream projects can correctly link the debug library when in debug configuration.
Failure logs
Applications reports missing the correct cminpack dll and crashes.

Try #30141.

Try #30141.

I think it works. Thanks for the quick fix.


Adding an ambush flag for monsters

This makes monsters quiet and still until they actually see the player.

Logic seems flipped: https://discord.com/channels/266998536632139776/707655151279931392/813134759521812531


Make server component separate and this module just install npm deps

I've moved the replication/mirroring functionality out of this module into ipfs-registry-mirror because it was getting very unwieldy and was starting to lose focus - this is what's currently deployed at https://registry.js.ipfs.io
This PR fixes #50 by making the purpose of this module just to install your npm deps.
When invoked on the command line, this module now:

Makes a request to https://replication.registry.js.ipfs.io to find out what the current CID of the npm index is
Dials the replication master to ensure we can ipfs.files.cp the updated index
Updates the local copy of the registry index
Starts a web server to serve dependencies
Spawns npm in the background configured to connect to us
For every tarball/manifest request, if it exists in our copy of the index, uses the CID stored alongside it to fetch it using IPFS, if not proxies for the public npm registry but updates the local copy of the index with the CID of the newly downloaded module

Some notes:

1 & 2 will go away when js-ipfs can resolve remote IPNS names
There seems to be a bug with ipfs.dag.get, in that it stops responding when invoked loads of times concurrently, but I need to dig in to this further.  Until then this module is best used with the go daemon.  E.g. in your project directory and with go-ipfs on your $PATH:

ipfs-npm --ipfs-type=go

Requesting modules from localhost results in having http://localhost... in your package-lock.json file, might need to rewrite these post-install and replace them with https://registry.js.ipfs.io urls..

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6ea40aa). Click here to learn what that means.
The diff coverage is 84.84%.

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage          ?   77.83%
=========================================
  Files             ?        8
  Lines             ?      185
  Branches          ?        0
=========================================
  Hits              ?      144
  Misses            ?       41
  Partials          ?        0

Impacted Files
Coverage Δ

src/core/config.js
100% <100%> (ø)

src/cli/bin.js
100% <100%> (ø)

src/core/handlers/root.js
42.85% <33.33%> (ø)

src/core/start-ipfs.js
56.52% <56.52%> (ø)

src/core/handlers/tarball.js
51.72% <83.33%> (ø)

src/core/handlers/manifest.js
66.66% <85.71%> (ø)

src/core/index.js
91.37% <90.9%> (ø)

src/core/start-server.js
97.14% <97.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea40aa...ce56654. Read the comment docs.


Upgrade Spring Boot to address various CVEs

Upgrading Spring Boot to latest should address the following severe CVEs (as well as a variety of medium and low CVEs):
CVE-2021-27568 - json-smart
CVE-2021-43466 - thymeleaf
CVE-2021-23463 - h2
CVE-2021-37136 - netty-codec
CVE-2021-37137 - netty-codec
CVE-2021-22119 - spring-security-core
CVE-2021-22119 - spring-security-oauth2-client
CVE-2022-21724 - postgresql
CVE-2021-28170 - jakarta-el
CVE-2020-13956 - httpclient

PR: #1310


Feat-addrxnAnnotation

Main improvements in this PR:

Fix a compartment error as discussed in #169.
Add rxn notes for biolog update; metabolomics update; database new annotation, SLIMEr as discussed in #161.
Update the confidence score for database new annotation update to be 2, since it has related gene annotation.

I hereby confirm that I have:

[X] Tested my code with all requirements for running the model
[X] Selected devel as a target branch (top left drop-down menu)
[X] If needed, asked first in the Gitter chat room about this PR

@BenjaSanchez Yes, you covered all the rxns/mets that it should, go ahead and merge the branch.


doc: publish practices to GitHub

Signed-off-by: Dmitri Pal<EMAIL_ADDRESS>Publishing development practices stored in HackMD https://hackmd.io/team/enarx?nav=overview to Github.

Hi @dpal can you rework the PR please?

@nickvidal, I fixed the links. It just needs a review now.

Thank you @dpal , I hope all is well with you!

Would you like to expose these in the sidebar?

Would you like to expose these in the sidebar?

No. These are internal documents of the project team.


Lobby Example Broken

$ git bisect good
5c00577746f83eadd948383dd478360e96634ea4 is the first bad commit
commit 5c00577746f83eadd948383dd478360e96634ea4
Author: vis2k<EMAIL_ADDRESS>Date:   Fri Mar 22 12:50:35 2019 +0100

    fix: #609 by spawning observers in NetworkServer.AddPlayerForConnection after setting the controller. There is no point in trying to spawn with a null controller in SetReady, because by definition no one can observer something that is null. (#623)

:040000 040000 da4f0a0a32e258317690f5ca6d278bd79aea88c8 a1f33539499e80b6554c5a80d249c6cc42386519 M  Assets

:tada: This issue has been resolved in version 1.4.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Did not find target for sync message for 3 . Note: this can be completely normal because UDP messages may arrive out of order, so this message might have arrived after a Destroy message.
UnityEngine.Debug:LogWarning(Object)
Mirror.ClientScene:OnUpdateVarsMessage(NetworkConnection, UpdateVarsMessage) (at Assets/Mirror/Runtime/ClientScene.cs:563)
Mirror.<>c__DisplayClass37_01:<RegisterHandler>b__0(NetworkMessage) (at Assets/Mirror/Runtime/NetworkClient.cs:295) Mirror.NetworkConnection:InvokeHandler(Int32, NetworkReader) (at Assets/Mirror/Runtime/NetworkConnection.cs:215) Mirror.NetworkConnection:TransportReceive(Byte[]) (at Assets/Mirror/Runtime/NetworkConnection.cs:248) Mirror.NetworkClient:OnDataReceived(Byte[]) (at Assets/Mirror/Runtime/NetworkClient.cs:98) UnityEngine.Events.UnityEvent1:Invoke(Byte[])
Mirror.TelepathyTransport:ProcessClientMessage() (at Assets/Mirror/Runtime/Transport/TelepathyTransport.cs:55)
Mirror.TelepathyTransport:LateUpdate() (at Assets/Mirror/Runtime/Transport/TelepathyTransport.cs:82)

Steps to reproduce

new project with Mirror imported - Do Not Open Any Scenes Yet
in Build Settings, remove all scenes and add all three scenes from Examples/Lobby/Scenes in exactly this order:

OfflineScene
LobbyScene
OnlineScene

Now you you can open the OfflineScene or LobbyScene in Editor
Build and run as LAN Host
Play in Editor as LAN Client - click Ready
in LAN Host click Ready and Start Game
You should see a capsule for the host player and another for the editor client player and movement inputs work
back to client in editor - no capsules and movement keys don't work.  bug

Trying to debug this, I added these warnings to NetworkConnection
Server
public virtual bool Send<T>(T msg, int channelId = Channels.DefaultReliable) where T: IMessageBase
{
    // pack message and send
    byte[] message = MessagePacker.Pack(msg);
    Debug.LogWarning("ConnectionSend msgType:" + msg.GetType().ToString() + "  msgID:" + MessagePacker.GetId<T>());
    return SendBytes(message, channelId);
}

Client
public bool InvokeHandler(int msgType, NetworkReader reader)
{
    if (messageHandlers.TryGetValue(msgType, out NetworkMessageDelegate msgDelegate))
    {
        NetworkMessage message = new NetworkMessage
        {
            msgType = msgType,
            reader = reader,
            conn = this
        };

        Debug.LogWarning("ConnectionRecv con:" + connectionId + " msgType:" + message.msgType + " delegate:" + msgDelegate.GetMethodName());

        msgDelegate(message);
        return true;
    }
    Debug.LogError("Unknown message ID " + msgType + " connId:" + connectionId);
    return false;
}

and I get this result: 40252 ReadyMessage and 45184 SpawnPrefabMessage are not reaching client

will look into this one next (tomorrow)

strange. first two times I tried it I didn't see a player in editor client either.
now if I try it I see one:

reverted all my log messages. now the bug happens again.
almost sounds like a race condition.

seems to occur randomly. strange.

log when it works:

log when it fails:

@MrGadget1024 this is most certainly a race condition caused by one of the many scene loadings in either your lobby example or the NetworkLobbyManager.
from what I can see, it does way too much right now. for example, NetworkLobbyPlayer sends a CmdSendLevelLoaded to the server. Mirror does that stuff internally already with SetReady and Mirror has internal scene loading already.
imho try a lobby version with just one scene. get it work perfectly. then try two scenes.
I have a lobby in my umoba asset too - just one scene and it works perfectly fine.

I don't know what you're looking at, but the Lobby system has exactly one scene change from LobbyScene to OnlineScene, and it uses NetworkManager's built-in mechanism for that where NetworkLobbyManager calls base.ServerChangeScene(sceneName); on line 269, which is only reached by the Start Button being clicked on the host.  The OfflineScene is invoked by NetworkManager in OnStopClient, so that's not part of Lobby.
I can say that game player prefabs always get instantiated on the host, and if I copy the project and run 2 editors, the logging I added to NetworkConnection appears to show the spawn messages going out from the server and never coming into the client.  I have no idea how that's possible.
I'll keep picking at it.

Can this be closed now?