add selinux policy for centos-7

- What I did
Added selinux policy for centos-7. Fixes issue #28406.
- How I did it
Sync with selinux policy for RHEL7 pkg docker-selinux-1.10.3-57.el7.x86_64 because that policy works on RHEL7.3.
I downloaded the SRPM on an Amazon EC2 instance of RHEL7:
$ sudo yumdownloader --enablerepo='*' --source docker-1.10.3-57.el7

And then cracked it open to get to the docker.spec file:
$ rpm2cpio docker-1.10.3-57.el7.src.rpm | cpio -idmv

Found the selinux policy is using lsm5/container-selinux@583a67ffdf9eef9afc233ace0f841d5eeef28fb3.
I use PR #25334 for reference in constructing the diff.
- How to verify it
Build a docker-engine-selinux centos-7 RPM package and install on RHEL7.3 with selinux enabled:
$ make DOCKER_BUILD_PKGS=fedora-25 rpm

Should also make sure this works on CentOS7.2 because CentOS7.3 is not released yet.
- Description for the changelog

Update selinux policy for distros based on RHEL7.3.
- A picture of a cute animal (not mandatory but encouraged)
🐰
Signed-off-by: Andrew Hsu<EMAIL_ADDRESS>

is this also needed for the fedora packages?

@thaJeztah yes, i think we may need to look into updating the fedora 25 selinux policies. Right now the fedora 25 docker-engine rpms are able to install (but show warnings #28099). The fedora 25 selinux policy update should be a separate PR.

Stuff works. Success in build and install on RHEL7.3 with selinux enabled:
$ sudo yum install *.rpm
Loaded plugins: amazon-id, rhui-lb, search-disabled-repos
Examining docker-engine-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.x86_64.rpm: docker-engine-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.x86_64
Marking docker-engine-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.x86_64.rpm to be installed
Examining docker-engine-selinux-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.noarch.rpm: docker-engine-selinux-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.noarch
Marking docker-engine-selinux-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.noarch.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package docker-engine.x86_64 0:1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos will be installed
---> Package docker-engine-selinux.noarch 0:1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos will be installed
--> Finished Dependency Resolution

Dependencies Resolved

=================================================================================================================================================================================================================================
 Package                              Arch                  Version                                                          Repository                                                                                Size
=================================================================================================================================================================================================================================
Installing:
 docker-engine                        x86_64                1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos                 /docker-engine-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.x86_64                         64 M
 docker-engine-selinux                noarch                1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos                 /docker-engine-selinux-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.noarch                 45 k

Transaction Summary
=================================================================================================================================================================================================================================
Install  2 Packages

Total size: 64 M
Installed size: 64 M
Is this ok [y/d/N]: y
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : docker-engine-selinux-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.noarch                                                                                1/2
libsemanage.semanage_direct_install_info: Overriding docker module at lower priority 200 with module at priority 400.
  Installing : docker-engine-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.x86_64                                                                                2/2
  Verifying  : docker-engine-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.x86_64                                                                                1/2
  Verifying  : docker-engine-selinux-1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos.noarch                                                                                2/2

Installed:
  docker-engine.x86_64 0:1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos                                     docker-engine-selinux.noarch 0:1.14.0-0.0.20161202.223924.gitbfe5cab.el7.centos

Complete!

/cc @crosbymichael
Notice the Dockerfile has a test for selinux-policy-devel to get the latest. When centos7.3 is out, this line should be removed.

LGTM

isn't it possible (somehow) to use the rhel packaged docker-selinux directly?

@runcom see https://github.com/docker/docker/issues/29114 I guess

Testing this out on centos7, just getting perm denied on basically anything in the container.
Busybox is the only container that seems to start for me.

Running this in vagrant/vbox, with the same centos release, I'm getting the permissions issues.
Are you sure you have selinux-enabled set on the daemon?

 Seems to be an issue with the vfs driver. Using overlay works ok.
LGTM.

@runcom I would be up for just using the distro package for the selinux policies going forward.  The only reason I think we did this was because oracle did not package the selinux policies so we shipped them ourselves but for RH distros I think we can just use the system packages.
We are open to PRs if anyone has time to help test the change to put fedora, RH, and centos on the distro packages of selinux policies.  Right now @andrewhsu is pretty busy with RCs on the packaging side.

@runcom I would be up for just using the distro package for the selinux policies going forward. The only reason I think we did this was because oracle did not package the selinux policies so we shipped them ourselves but for RH distros I think we can just use the system packages.
We are open to PRs if anyone has time to help test the change to put fedora, RH, and centos on the distro packages of selinux policies. Right now @andrewhsu is pretty busy with RCs on the packaging side.

@crosbymichael awesome, I'll take a look into that hopefully or point the relevant people to this, thanks!

@runcom thanks, I think the change makes a lot more sense going forward.


Watch commands taking too much time within Default task

I'm using WPGulp build script as a base and I've noticed that when I run the default gulp task by running gulp command, each of the dependent task took time in a few milli seconds to finish  but still the default task is taking 4-8 minutes to finish, I tried commenting out watch commands within the default task and turns out these commands were causing all this delay.
How to resolve this? Is it machine specific issue?
UPDATE: The real culprit is projectPHPWatchFiles watch command. If I comment out only this command the build time decreased to only 15 seconds.
PS: My laptop has 4 GB of RAM and 1.7Ghz i3 processor.

@imfaisalkh I am not sure you understand the default behavior. The default task is not a build task. It builds everything and then it sits there to watch for any changes that you might make. While you are developing, this should be watching your files. Once you are done with dev you can press CTRL + C to quit this task.

I do understand the behaviour, perhaps I've not explained it clearly. The default task is taking too much time to "finish", here the word "finish" means when the console prints Finished 'default' after 5.48 min, after this it starts watching files and provide a preview URL.
This task do "watch" the files at the end, but it is taking too much time to get there. As mentioned earlier projectPHPWatchFiles watch command is seems to be the real culprit.

@imfaisalkh Must be your slow computer than. It's pretty weird though. I will soon push an update.

I've tried narrowing down the PHP file selection criteria, like this:
var projectPHPWatchFiles    = ['./**/*.php', '!./.git/**/*', '!./.dist/**/*', '!./.vendors/**/*', '!./node_modules/**/*', '!./styles/**/*', '!./scripts/**/*', '!./languages/**/*', '!./images/**/*', '!./fonts/**/*']; // Path to all PHP files.
Now, as per this criteria, there is almost 25-30 php files to watch in the theme folder but still watch command is taking almost 5 mins now.
I've not tested this script in my main computer but 4GB ram should suffice for such small number of files and CPU usage during script execution is very low, so CPU shouldn't be the bottleneck either.

Takes 1.4sec on my end with Macbook 16 GB RAM :)

Just tested the script on another computer (core i5 3.3Ghz + 4 GB Ram), the default task took about 35sec, so apparently, it is the system specific issue. However, I'm not sure why the script is not using the idle CPU power on my laptop to improve the execution time. Nevertheless, it doesn't seem this script specific issue. Thanks for your help.

Glad I could help!


Use app.setAsDefaultProtocolClient(protocol) API

0.37.4 added this API after I opened an issue. This will let us remove some code!
https://github.com/atom/electron/issues/4857
https://github.com/atom/electron/pull/4896

https://github.com/feross/webtorrent-desktop/issues/83


Cleanup: captured-exceptions

When an unexpected exception is captured, it propagates through the code as a special actual value, which is a map with a special key. That caused this bug: https://github.com/marick/Midje/issues/58  It'd be better if the special value were a "more special" value, perhaps a record.

Re-implemented them with a deftype CapturedThrowable. b4fb5fe2e9cce4125c0198f44d4aaa4109d237ca


May i give a advise for the orm interface what expected for adding a method of native query str like ...

May i give a advise for the orm interface what expected for adding a method of native query str like '$Model->query(select filed1,filed2 from $table where id=? and name=?, $id, $name)' etc. It can be also using for '$Model->query(update/delete/insert...)' .

@fizzcome
I'd like use the orm like the following code
Model::find()->select(['id', 'name'])->where(['id' => 1])->orderBy(['createdAt' => SORT_DESC])->all();
Model::find()->where(['id' => 1])->one();

But now I just want to simplify the find method.
Maybe I will follow the example in the future.

yeah. it will be hard for the query builder like join,left join and so on ...

Yeah, it's hard. But I think we can try.


replace all uses of hardcoded blue with accent color

I looked through the doc pages with the accent color changed, and they seemed good.
Not totally sure about ErrorNotification though. This changes the button text color to the accent color which I think is what I would want but I didn't see a page to test that component in the docs so I haven't actually looked at it.

I don't I have a doc page for it yet, but the change looks good.   Thanks


Where can I define global App.mounted hook (on a level higher than layout component)

Is there a higher level component where I can define mounted hook function than layout? Say I have two layouts and they share same code in their mounted function, where should I extract those code out?

I think you can create a plugin or component and import in all of your layouts.

I thought about using plugin but it seems there no way to do what I wanted. The closest option is to use a mixin and define a mounted hook but that will apply to all components. If you could give me an example, that would be very appreciated.
And I don't understand component and import in all of your layouts.. Could you elaborate in more details?
Thanks

Hi @zzhjerry,
Can you give us more information about what you would like to achieve in the global mounted function?

Workaround for googlers:

Create file utils/extend-vue-app.js:

export default function extend (app, mixin) {
	if (!app.mixins) {
		app.mixins = []
	}
	app.mixins.push(mixin)
}

Create plugins/foo.js:

import extend from 'utils/extend-vue-app'

export default async function ({ app }) {
	extend(app, {
		mounted () {
			console.log('Hooray, Nuxt.js app mounted.')
		},
	})
}

Load your new plugin in nuxt.config.js:

module.exports = {
	...
	plugins: [
		...
		'~/plugins/foo.js',
	],
}

@alexchopin I use this for all kinds of things:

Load external scripts which will adjust DOM, for example twitter.js (because if they load before Vue app inits, this gives "The client-side rendered virtual DOM tree is not matching server-rendered content.")
Add global document event listeners
Deal with client side cookies on page load
Add global data to the app (e.g. for vue-stash)

@IlyaSemenov , thanks


Popup error goes away after reloading the page

The generated popup error description goes away after the page has been reloaded.
There should be a way to force the error to show up after page reload.
Many thanks.

Implemented in https://github.com/fi3ework/vite-plugin-checker/pull/91. Waiting to be released.


extracted sound from pcap is noise

hello, this tool always works file and help me a lot, but not works on this pcap file and no error reported,  could you help find why?
python pcap_parser.py -i /tmp/error5.pcap  -o output-err.amr -c amr-wb -f ietf

sound.zip

Are you sure that the payload is really AMR-WB or AMR? e.g. does the signalling show that AMR-WB is the selected codec?,
Have you tried decoding manually some of the packets to verify that this is actually AMR-WB? , that's quite fast to do with Wireshark decoding the packets as RTP and matching the RTP payload against RFC4867?

it's my fault, this tool is very helpful.


[FLINK-28046][connectors] Mark SourceFunction interface as @Deprecated

This is a trivial change that marks SourceFunction API as @Deprecated.

@afedulov The only thing that's missing is starting your commit message with FLINK-28045

@MartijnVisser that was quick :) 👍

RE: Build Failure:
We will be able to provide proper alternatives for the deprecated versions of the examples when we finalize FLIP-238. I would prefer not to block marking SourceFunction API deprecated because of them. I think it is OK to use warnings suppression for these four deprecation warnings for now. Here is a new follow-up subtask in the umbrella deprecation ticket to address FLINK-28227.

@flinkbot run azure

@flinkbot run azure

@afedulov Will you do another round of rebasing or do you want me to help you out with that?

@MartijnVisser the issue is that @SupressWarnings("deprecation") are not considered by the maven-compiler-plugin and we have (somewhat recently) enabled strict failure on warnings:
https://github.com/afedulov/flink/blob/master/flink-examples/flink-examples-streaming/pom.xml#L154-L155
https://issues.apache.org/jira/browse/FLINK-24833
There are two ways forward:

Postpone marking SourceFunction as deprecated and push for finalizing FLIP-238 to migrate all existing sample sources
Remove the failOnWarning parameter for now and add respective comments explaining the current state

I would say that our original discussion on the ML converged in the direction that supports option 2. - mark SourceFunction as deprecated effective immediately to prevent its further spread and work on closing the gaps as a follow-up.

Update: this effort is currently pending the introduction of the FLIP-238 data generation sources.

@afedulov since FLIP-238 had been resolved, shall we continue this work and make it done in flink-1.17 release?

@Myasuka good idea, thanks for bringing it up. I will resume working on it.

@afedulov Do you think you can still make it before the feature freeze? (That's the 31st of January).

@MartijnVisser Hi Martijn, yes, I'll try to find some time over the weekend to finalize this.

@MartijnVisser https://github.com/apache/flink/pull/21774
@alpinegizmo While reworking the TopSpeedWindowing example I found it pretty convoluted.  I believe we previously had discussions about not promoting the usage of the sophisticated trigger-based Window API. Do you maybe have an idea about how to rework it? I personally would not mind dropping it altogether - it does not feel that we promote best practices with it but might rather confuse new users.

@afedulov I'm not a fan of the TopSpeedWindowing example -- it's not at all obvious what it's doing. I do like that it's a decent example of how to use the FileSource and FileSink, but the SideOutputExample covers that too.
Personally, I'd be happy to drop TopSpeedWindowing. Any idea why it has been a popular example job? For example, if we drop it, then this section of the docs will need to be updated:
https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/resource-providers/native_kubernetes/#starting-a-flink-session-on-kubernetes

@alpinegizmo Ha, good point. My guess is, it is used just because the name sounds good - like it does something interesting, but not overly complex. I do not think anyone actually looks into the details of the example when going through that documentation page and we can easily swap it for something else.

@MartijnVisser unfortunately CI did not capture all failures caused by our strict checks for deprecated APIs in flink-examples at once.
Now that the original sources listed in FLINK-28227 (Azure Build 1) got fixed, it started failing on two more sources from flink-examples-table: Azure Build 2.
Unfortunately, we are missing an integration layer between the new DataGeneratorSource and the Table API needed in order to make it work. For instance, SocketSourceFunction has to be rewritten as a GeneratorFunction, however, we, by design, do not have access to RuntimeContext that is required to initialize the serialization schema in the original implementation:
https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/connectors/SocketSourceFunction.java#L36-L39
https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/examples/java/connectors/SocketSourceFunction.java#L72-L74
This requires a larger effort and won't realistically happen until the release branch cut unless someone who works closely with Table API could take a look.
Another alternative is to disable the strict policy for using deprecated APIs in flink-examples-table.

@MartijnVisser I would like to proceed with the efforts to deprecate the SourceFunction interface. The blocker (FLINK-28227) is now resolved: https://github.com/apache/flink/pull/21774

@flinkbot run azure

@reswqa now that we resolved the blocker in https://github.com/apache/flink/pull/21774 this PR can be merged too.


DCOS-48316: Jobs form

Implements a basic new Jobs form. The modal and form are based on the Services implementations (CreateServiceModal, CreateServiceModalForm).
Included in these commits:

Basic tabbed job form (that can toggle to JSON editor) and modal
General form section component
Modifications to MetronomeClient to upgrade to metronome API v1 spec for job create and update
Job editing

Not included in this PR:

The form doesn't open to it's own dedicated route (do we want this? @AmrAbdelrazik)

This PR overlaps a couple different JIRA tickets. These can be separated into separate PRs if necessary but it's difficult to test the changes end to end without all 3:
DCOS-48316: Jobs form modal

Adds a modal and form component
Create/edit buttons open a full page modal
Form contains one tab (General)
Basic validation and error visibility is set up
Modal can toggle a JSON editor

DCOS-48445: Datalayer changes

Updates the create and update job mutations to be compliant with the metronome v1 API spec (previously was v0)
See https://github.com/dcos/dcos-ui/pull/3599/commits/6ac68557ae19eb7b71c9aedbf4c485ec22d75ddb, https://github.com/dcos/dcos-ui/pull/3599/commits/30a00897fb573ae6479e1f5292f2f16116627751, https://github.com/dcos/dcos-ui/pull/3599/commits/5a05f2c8c63dc7e7caf751c28270207a1b1dae46

DCOS-48352: General form section

Adds the general form section to enter the bare minimum for a job (ID, description, cpus, mem, disk, gpus, command, container Image)
Should be able to edit from both form inputs and JSON
Validation should prevent submission of an invalid form and show errors

Testing
Different scenarios to try:

Create a job (it should work)
When 'Command Only' is chosen, only Command input should be shown below (required)
When 'Container Image' is chosen, both Container Image (required) and Command inputs should be shown below (also, a ucr property should be added to the job JSON - visible in JSON editor)
Try putting the validation to the test (try submitting an invalid form)
Try editing using the JSON editor
Try creating a job and adding properties to the JSON that aren't yet available in the form UI. These should persist when the job is added. For example, try adding a schedule like:

{
"job": {...},
"schedule": {
    "id": "my-schedule-data",
    "cron": "0 4 * * *"
  }
}

Trade-offs
This was put together using existing patterns from the Services form. The tradeoff here is using what is tried & tested & available (fast but comes with its own challenges and potential tech debt) vs coming up with novel form patterns.
Dependencies
Screenshots

not sure I understand what you mean by: "The form doesn't open to it's own dedicated route (do we want this?)"

The service form opens in its own route (/services/overview/create) whereas the jobs form just opens as an overlay on the /jobs/overview page

I don't have any strong opinions here, I am ok with the same behavior like Marathon Form

Looks good. Some observations:

When I open the new form, the Disk input is immediately glowing red as if I did something wrong.

I think that "Container Image" and "Command Only" radio buttons would look better if they were aligned with the other inputs
I can't write in the "Description" input (is this known?)

I can't submit the form, because it requires docker image even though I selected "Command only"

I get "Object is not valid" for Disk and GPU even though I entered integer values (Disk needs to be above 32, but this isn't obvious)

All tabs expect "General" don't work (this might be known)
I think we don't need a tooltip explanation

No message catalog changes (this is probably known)
I don't get an error message when I enter an uppercase job name
I am not sure if we need both a description and a tooltip for command

@GeorgiSTodorov Thanks for the detailed feedback! Looks like the last commit regressed a lot of the validation behaviour - I'll check it out.

@GeorgiSTodorov I pushed the following changes to address your feedback:

fixed validation issues
removed unused tabs (only general left)
added message catalog updates
added validation for job id
re: tooltips, I removed the tooltips on Mem and Disk but to stay true to the design I've kept the tooltips on ID, description, CPUs, Command and Container Image (as well as added one to GPUs with a message clarifying it is only available with UCR) (cc @izharbuendia)
Let me know if any of the issues persist for you

I actually liked the tooltips, but I will leave it to @izharbuendia
On Wed, Feb 20, 2019 at 5:57 PM Natalie Smith<EMAIL_ADDRESS>wrote:

@GeorgiSTodorov https://github.com/GeorgiSTodorov I pushed the
following changes to address your feedback:

fixed validation issues
removed unused tabs (only general left)
added message catalog updates
added validation for job id
re: tooltips, I removed the tooltips on Mem and Disk but to stay
true to the design I've kept the tooltips on ID, description, CPUs, Command
and Container Image (as well as added one to GPUs with a message clarifying
it is only available with UCR) (cc @izharbuendia
https://github.com/izharbuendia)
Let me know if any of the issues persist for you

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dcos/dcos-ui/pull/3599#issuecomment-465830344, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AOMJeQz2rCBBKfPyRxDo5-oKYHuCFHDQks5vPf0GgaJpZM4a8wLK
.

--
Amr Abdelrazik
Director of Product Marketing
<EMAIL_ADDRESS>

Some issues I was running into while testing:

The JSON editor produces a non-estimated output when changing a key field as seen in the JSON.
The other issue is that the JSON editor is reseting every couple of seconds, if I haven't reached a valid new state.

@izharbuendia - we should come up with some guidelines on when to use a tooltip for form hint text versus adding the info as hint text below the input.
For example: the info in the "Description" tooltip is very short and simple, but it's still hidden in a tooltip instead of just being hint text below the input

Updates from today:

parsing number values for cpus, mem, disk, gpus
allow multiple consecutive edits of a job
amend job id regex check to allow single character id
make invalid json errors from editor block form submission
json editor should no longer "reset" when in an invalid state
allow deletion of schedule from a job in json editor
remove min from disk (it was wrong anyway and our validation checks for it separately)
add type="number" to cpus
fix update logic in MetronomeClient so that if a job is being updated and a user adds a schedule where the original job previously didn't have one, it will POST the new schedule instead of trying to PUT it and erroring
change what happens when a job is being created and the JOB creation is successful but the SCHEDULE creation fails: show error in modal, switch to edit state, allow user to modify and resubmit as an update request (cc @AmrAbdelrazik )

@GeorgiSTodorov @mperrotti I was unable to reproduce the 500 error, let me know if it persists. Also, we are not implementing the review screen in this RI so that's why the button says "Submit". Let me know if I've missed anything!

@natmegs , thank you. Most of my concerns are addressed. Some minor things:

CPU and GPU inputs glow red as soon as the form is opened
CPU is red after entering invalid value and changing it to valid
GPU is red when it is below 32 and cannot be changed below 32 using the arrows (is this intended?).
When I am editing the form and I enter a new value for cpu, disk, mem and I click submit, the old values are visible for a split second. This might be misleading, because the user might see this and think that his new values weren't saved.
I am able to enter "abc" value for GPU and the submit succeeds and "abc" is simply not saved (GPU is saved as 0).
When CPU is for example 10, clicking the up arrow changes it to 10.01 and clicking the down arrow changes it to 9.01. This is valid according to the tooltip, but still seems weird to me.

@GeorgiSTodorov I've addressed your comments with a couple limitations:

GPUs: in Chrome, I cannot enter a string into the number input, and if I enter gpus: "abc" in the json editor it throws an error on submit (I think this is how it should work). In Firefox, I can enter a string in the number input (yikes, what's the point of a number input in that case) but it won't add it to the JSON (I think this is also behaving as it should given the browser limitation).
Firefox does some really weird stuff with html form validation so I put novalidate on the form and removed the min restraints on the inputs (we check for these in our own validation). CPUs will now increment by 1 using arrows (and I changed default to 1 as indicated in designs) but user can still enter 1.01 (in firefox this sometimes causes the input to highlight red for unknown reasons but it still is added to the json). Now when I open the form, nothing glows red in either Chrome or Firefox, let me know if this is different for you.

@natmegs , looks good.

I think that the id field should be disabled when editing the job
When I delete a value in the JSON (for example CPU) and click Submit, the old value is back, but the error won't go away and I can't submit the form even when changing the value

If I open JSON editor, save the job and then edit it, JSON editor isn't open (it is in the old form and I think it makes sense to be)
npm run commitlint is failing
If I enter a negative value for GPUs, it says "Object is not valid"

@GeorgiSTodorov Some good points here but not all are things we can address in this PR as they are working as designed or are separate features.

Disable ID on edit: I agree with this one! But that's not how our jobs or services forms work currently so we can extract that into a separate ticket if it's a product priority (cc @AmrAbdelrazik )
Invalid JSON issue: Good catch, I've pushed a fix so that the JSON editor won't get overwritten (https://cl.ly/cee893e9a70c)
Open JSON editor on edit if it was last used when creating the job: if I'm understanding correctly, this is a user preference that we have no way of storing for jobs
The 'object is not valid' message for negative gpus is from the server (since it's not valid 🙂). This is expected and if you change it to a valid value and submit it will work. I've changed the error message extraction to retrieve the detailed server error message if it exists rather than the generic one (here's an example of a server error being surfaced https://cl.ly/bd2f1e18d9ba). As additional security I also added a validation check for gpus > 0 (https://cl.ly/09701ab28e85).

@mperrotti @juliangieseke let me know if your concerns have been addressed :) Mike, if it's ok I'd like to upgrade to the ui-kit modal in a separate ticket since it will likely break integration/system tests and I don't have a reliable way to run system tests locally right now.

Disable ID on edit: I agree with this one! But that's not how our jobs or services forms work currently so we can extract that into a separate ticket if it's a product priority (cc @AmrAbdelrazik )
We disable it for services.

And there is a bug about it not being disabled for jobs - https://jira.mesosphere.com/browse/DCOS-39292 .

Open JSON editor on edit if it was last used when creating the job: if I'm understanding correctly, this is a user preference that we have no way of storing for jobs

It works in the old form:

I pushed a commit that should fix the system tests.

@GeorgiSTodorov thanks so much for fixing those system tests! Very appreciated. Those are all good points but have been determined to be non-blockers for this particular PR:

Disabled ID: since it's not disabled in the current jobs form, and we are trying to reach feature parity with the existing jobs form, this can be fixed separately (thanks for linking the ticket!)
JSON editor state: that's actually a bug in the current jobs form where the state isn't being reset correctly 🙂
3 errors: that is actually by design. The user has 3 options for how to remedy that error
Browser width: that is how the services form looks at that browser width, and mobile browser layouts are not a priority for this particular PR
Hope this addresses your concerns! Happy to talk about them further if there are questions.

@GeorgiSTodorov

The Id field disable we might not be doing in this round since we are aiming for feature parity first.
That the JSON editor is active seems to me actually more of a bug than an actual feature. It seems we forgot to reset the JSON editor flag.

It's not a Bug it's a Feature. – Someone from the internetz

About the 3 errors for one field
The responsive design is okay, it is the same problem for the service form.

We will fix those issues in a future PR and they should not be blocking this PR from moving forward.

On first glance, it looks good, I will do an extensive review tomorrow.

These are probably not blocking changes, but I still think they would be nice to haves:

As @mperrotti said, the "Submit" button is supposed to be "Review"
Design document: https://mesosphere.invisionapp.com/share/Y6Q8EFKBA3G#/screens/341644097
Also in the design doc, GPUs is not disabled if we have selected "Command only"
If I try to submit a "command only" job without a command, I get an error. When I switch to "container image", the command is no longer required, but still shows an error. The error goes away if I enter a container image
I still think we need the little tooltips that say "Description info", "CPUs info"
If I enter a super high value in CPUs, it says Minimum value is 0.1. and the JSON for cpu is an empty string (same for other inputs)
Console warnings when I open the modal

@mperrotti

i removed the newly introduced console-warnings and all type errors that would still be there after https://github.com/dcos/dcos-ui/pull/3623 is merged.

How do we push commits without removing the approval? Is it because it's not pointed to master?

@GeorgiSTodorov right, target branch is not protected

@nLight , is this intentional?

@GeorgiSTodorov we protect only master and release branches. We can install a protection for that branch if needed. Everyone should have admin access to do it

…and CI is red :(


Resizing doesn't work correctly sometimes

Repro steps:

Create a layout so it looks like this

Drag the marked slider up/down and notice that plugin 2 bar is also moving up/down which it shouldn't

Notice that this behavior is not consistent and work sometimes and sometimes not.

This happens due to Viewdock structure: it only allows splits in two parts. In this case structure is as follows: (50% Plugin 0) / (50 % (50% Plugin 1 / 50% Plugin 2)). When you move first slider, you decrease size of Plugin 0 and increase size for both Plugin 1 and Plugin 2. That is the reason for border between Plugin 1 and Plugin 2 to move.

@SlNPacifist Ah yes that actually make sense. Do you think you can do that as part of your restructuring of the data layout?

I'll think about it today. It seems to simplify some things in data structure but I could be wrong.

Alright. Sounds good.


Set label text to button

Given a label string the label would not be set to the created button. Added the label text to the button.

Wow, that's an oldie 👍

Yeah. Sorry about that. I wasn't getting email notifications and then recently discovered notifications icon in the uppper right corner!


Receiving 'Congratulations' confirmation page and should not be

Expected behavior
When checking out with regular products, user should receive the normal confirmation page.
Actual behavior
After starting down the join path and navigating away, and checking out with regular products I receive the 'Congratulations' confirmation page.
Steps to reproduce behavior
Cleared cookies  - went directly to join and did the sign up:

Went to personal info page, did not fill out any info, clicked on recipes, then clicked blog, then clicked shop and went to dressings and oils and added an item to my cart. I get the pop up:

Selected I don’t wish to join at this time:
The pop is removed and I still see both the join kit and the avocado oil in my cart:

I click checkout:
The bbok is removed as it should be:

Entered same email address I did on sign up and checked out as a guest:

I receive the 'Congratulations' confirmation page:

https://razoyo.atlassian.net/browse/TST-294

Followed steps above and I got the correct confirmation page


Night CI 2023-04-05: Failed

action url: https://github.com/spidernet-io/spiderpool/actions/runs/4622490025

It seems like that the moment the spiderpool-controller not ready when running the e2e case "the IP can be reclaimed after its deployment, statefulSet, daemonSet, replicaSet, or job is deleted, even when CNI binary is gone on the host" .
The current source codes lack some logs, we need to add additional logs to make it clear in the next re-produce time.


[Feat] wants to create contact us page

Description
currently the contact us page does not exist I want to create the page for you
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[ ] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

Hey @Kratik1093 It already exists please check again.


Amazing Martial Artist test

change to getting from new bestiary

Updated, had to change martial artist and Talent data type to dict in creature.csv


Double HTML escaping in blog titles

Hello 👋
I found this blog post in the electronjs.org blog, and its title contains a colon, which is escaped to :, but the HTML window title is escaped again somewhere, which results in <title>... &#58; ...</title>
This makes the actual window title have a literal : instead of a colon.

This issue seems to exist in all blog posts from before 2017 which contain a colon, but since 2017 this stopped happening.
I've looked at the code and found the relevant places, but I'm not sure where the double escaping occurs.
Maybe the actual blog post file itself contains an escaped colon in the title because before 2017 you needed to escape special characters yourself?
The raw blog files don't seem to be open source so I can't check this on a local copy.

The raw blog files don't seem to be open source so I can't check this on a local copy.

They are public and can be founded in https://github.com/electron/electronjs.org/tree/master/data/blog, this problem in the blog post itself, feel free to find them and send a PR.


Received email has a Random text in the sender's email address

The email received has a random text,
Ich schrei sonst! beside the sender's mail address.
Below, is a part of my config file,
[general]
notify = smtp
[smtp]
host = smtphost
port = 25
security = none
from =<EMAIL_ADDRESS>to =<EMAIL_ADDRESS>timeout = 10

Am I missing something?

The email received has a random text, Ich schrei sonst!
That’s not random. isso stems from that sentence: Ich schrei sonst as far as I remember.

It should work using the following in your configuration
[smtp]
from = Name to show<EMAIL_ADDRESS>
Of course you could replace "Name to show" with the email address.

Thank you @KaiserBarbarossa . Worked like a charm.
Also one more doubt,
If I have to send notification to multiple users,
[general]
notify = smtp
[smtp]
host = smtphost
port = 25
security = none
from = "Name to show"<EMAIL_ADDRESS>to =<EMAIL_ADDRESS><EMAIL_ADDRESS>timeout = 10

But only one receiver<EMAIL_ADDRESS>seems to get the notification.
Am I missing something?


feat(exposition): add max content size to octets:store

Close #688

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 60.37736% with 21 lines in your changes missing coverage. Please review.

Project coverage is 49.49%. Comparing base (a59a16f) to head (40d0abe).
Report is 174 commits behind head on dev.

Files
Patch %
Lines

...sions/exposition/source/directives/octets/Store.ts
0.00%
13 Missing :warning:

...ons/exposition/source/directives/octets/Context.ts
0.00%
3 Missing :warning:

extensions/exposition/source/HTTP/exceptions.ts
66.66%
2 Missing :warning:

...xtensions/exposition/source/directives/io/Input.ts
0.00%
2 Missing :warning:

...tensions/exposition/source/directives/io/Output.ts
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #692      +/-   ##
==========================================
- Coverage   50.18%   49.49%   -0.70%
==========================================
  Files         358      367       +9
  Lines       11886    12582     +696
  Branches     1276     1333      +57
==========================================
+ Hits         5965     6227     +262
- Misses       5921     6355     +434

Flag
Coverage Δ

unit
49.49% <60.37%> (-0.70%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Disable transfer progress output in Maven

While testing this action and debugging our configuration for it, my team has found it difficult to read the log output, because a large amount of it consists of transfer progress indicators, such as this:
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 4.1/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 8.2/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 12/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 16/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 20/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 24/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 28/41 kB
  Progress (4): 24/58 kB | 20/55 kB | 20/109 kB | 32/41 kB
  Progress (4): 24/58 kB | 24/55 kB | 20/109 kB | 32/41 kB
  Progress (4): 24/58 kB | 28/55 kB | 20/109 kB | 32/41 kB
  Progress (4): 28/58 kB | 28/55 kB | 20/109 kB | 32/41 kB
  Progress (4): 32/58 kB | 28/55 kB | 20/109 kB | 32/41 kB
  Progress (4): 32/58 kB | 28/55 kB | 25/109 kB | 32/41 kB
  Progress (4): 32/58 kB | 28/55 kB | 29/109 kB | 32/41 kB
  Progress (4): 32/58 kB | 28/55 kB | 33/109 kB | 32/41 kB
  Progress (4): 32/58 kB | 28/55 kB | 33/109 kB | 36/41 kB

This could be suppressed by passing Maven the --no-transfer-progress flag (which only disables this specific output) or the --batch-mode flag (which does that and also prevents Maven from ever prompting for input, just in case).

Nice! I will work on this improvement soon, thank you :))

@colinphill-mdsol Unfortunately I cannot use --batch-mode because this GitHub Action greps the Maven output, but I have added the flag -ntp, --no-transfer-progress to reduce the noise in the logs. I hope this can improve your UX :)


Component detection does not scan Linux file system if the image is not a docker image.

Hello,
We were trying to create SBOM for our production image using sbom-tool but it seems we have hit a blocker.
Our image is not created using docker, its a VM image created using packer.
SBOM tool uses component-detection tool to get the dependencies and for Linux it seems only way is passing docker image to the tool.
We tried running to  component-detection tool directly on the VM from which we create the image but it does not capture any Linux packages installed on the image.
Linux scanner logs "No instructions received to scan docker images." and then returns.
syft tool does support scanning of a file system which is what component-detection tool uses for Linux scanner.
What is the workaround to detect Linux packages from the filesystem? We are blocked on this currently and unable to meet our SBOM requirement.
AB#2088307

Unfortunately, this is by design. Component Detection does not support scanning Linux file systems, only docker containers at the moment.
We can investigate utilizing Syft to also scan the current Linux file system with a CLI flag, but this isn't currently on our roadmap. This is also a bit tricky as Syft will also pick up dependencies similiar to Component Detection, but does not provide a graph output.
As a workaround, can you just use Syft to generate your SBOM?

Unfortunately for the same reason SBOM generated by syft is not according to schema for microsoft's sbom requirements.
Also, it seems component detection tool parses the output produced by syft to generate the cgmanifest.

We discussed in our Community Meeting that in the future we might forgo a dependency on Syft and manually scan container images ourselfves. The issue with using Syft is the output is in a different format than CD uses internally, and can be nondeterministic depending on the scan location.


HHH-11816 - JoinProcessor considers table names with colons dynamic filter parameters

https://hibernate.atlassian.net/browse/HHH-11816

@breglerj Let me know what you think of this Pull Request.

@vladmihalcea Looks good to me.
One more thing I thought of is that hasDynamicFilterParam() should also check if the match ends with a single quote. Otherwise the same error occurs with a join condition like this:
... inner join User u on r.lastUpdateBy = u.username and u.username!='user:name' ...

@breglerj You can grab this PR and add a new test that fails for this new use case. Send the PR when you have it and I'll integrate it.

@vladmihalcea I've created PR #2016


About PCLLosses

About PCLLosses  line 198
https://github.com/ppengtang/pcl.pytorch/blob/b78e1ef8f16fc71fa0e4b62b79bb44cb6e4f4bdb/lib/model/pcl/pcl.py#L190-L199
The condition should be pc_labels[0, i] == c
I have found the c version.
https://github.com/ppengtang/pcl.pytorch/blob/b78e1ef8f16fc71fa0e4b62b79bb44cb6e4f4bdb/lib/model/pcl_losses/src/pcl_losses_kernel.cu#L24-L49

Hi, sorry for the delayed reply. The shapes of pc_labels in Python codes and C/CUDA codes are different.


Add a set data structure

Currently Phel has Tuples, Arrays and Tables. It would be nice to have a Set data structure based on PHP Arrays. For example:
(set :a :b :c)

Methods on a set:

union
intersection
difference
join

Actually there is already an implementation of Set in PHP with the methods you quoted. Why not just use this instead of arrays?

Thank @paullaffitte! I know of this. However, this is part of a separate module and these modules are mostly not part of cheap hosting providers. Therefore, I would go for a custom implementation based of PHP Arrays, just like the Table and PhelArray.

Oh ok I see. Should I consider performances in the first implementation or do you prefer to have something working quickly and improve its perfs later on?

Regarding performance there are two aspects.

Runtime performance: This should as good as PHP itself because the code is compiled to PHP and than executed. The only thing that is slowing down are sub optimal implementations of the core libraries.
Compile time performance: This is the time the compiler needs to compile the program. If optimized it already, but PHP currently has it's limitations on this one. However, PHP 8 is on it's way and is coming with an JIT Compiler. This improves the compile time of Phel drastically.

If you have more questions on that, consider making a new issue.

Closed with PR #62


How to use dart:_internal:ExternalName in dart sdk inner ?

Notice that the bytecode interpreter has some performance optimizations for the ExternalName Annotation, but it doesn't seem to be used directly in the dart source code.

ExternalName are generated by CFE when it parses native "aaaa" syntax.


Reply URL not taken into account

Hi,
I have tested the configuration on a SharePoint 2016 farm.
For some reason, the "Reply URL" is not taken into account.
The authentication works but I am redirected to https://<IP_ADDRESS>:444/applications/default.aspx (default value) instead of the URL that I configured https://[SPWebApp].westeurope.cloudapp.azure.com/_trust/default.aspx.
The web app is configured with HTTPS on the default zone using bindings, AAM and self-signed certificate.
Any clue?
Thanks in advance
Regards
Jeff P

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f079fa08-284c-3f14-be4a-1f32d5b0e7b9
Version Independent ID: 707cbeee-d311-d430-6119-e9ae8b8aeae5
Content: Using Azure AD for SharePoint Server Authentication
Content Source: Enterprise/using-azure-ad-for-sharepoint-server-authentication.md
Service: o365-solutions
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

Hi again,
I have resolved the permission issue.
I had to choose the ClaimType "given name" instead of "Name" when giving permission.
This was for users in a Microsoft demo tenant.
When giving access to a guest/external user from another tenant, I had to choose the ClaimType "Name" for giving permission.
If anyone can explain, I will be interested!
Does this have anything to do with the fact that the user’s email address is contained in:
The “Name” claim type for a work account.
The “Email” claim type for a social/personal account contains.
?
Best regards
Jeff P

Thanks for the good questions, Jeff-Pironneau. We are looking into this.

Added pull request: https://github.com/MicrosoftDocs/OfficeDocs-Enterprise/pull/52

I believe Kirk Evans' recent update addressed this issue.

AADSTS50011: The reply uri specified in the request is not a valid URL. Allowed schemes: 'http,https'
My Reply URL is - https://projects-dev02.piedmontng.com/   Why would I be getting the error above?

@denisebmsft please close. Update did address this issue. @moojjoo commented but also has duplicate issue.


Unable to handle large libraries

My plex music library is extensive and the app "encounters a problem" every time I try to list Albums or Artists.
Also playlists with a couple of hundred tracks get split into these weird "0-100, 100-200" type of categories but they also do not always load.
Could a longer timer be configured to allow for larger collections, and could we please have the possibility to browse our catalogs without these "0-100, 100-200" categories and instead see the artist and album names as a list?

when you say "extensive", roughly how large is that and how many playlists do you have?
the splitting by index (0-100, ...) is due to a size restriction on Android Automotive. it doesn't allow lists to exceed a rough length, so if there are too many songs in a playlist, it has to be split up in some way. I chose by index because a playlist is typically ordered, although I'm open to changing the split logic while possibly keeping the playlist ordering if there are any preferences.

Hi!
I currently have 498 artists, with 2504 albums, totalling 34.244 tracks (if
the stats from PlexAmp is correct), and the collection is growing.
If I select one of the "0-100"-categories then the app waits for some
seconds and then goes back to the main start screen.
Short playlists have so far been fine, but I have not created more than a
few of them.
Some indication of where in will end up when selecting a category of 0-100
or 5-600 would be nice.
Even better, a search function so I can quickly get to the artist
I'm looking for.
On Tue, Sep 17, 2024 at 12:02 AM Joey Berkovitz @.***>
wrote:

when you say "extensive", roughly how large is that and how many playlists
do you have?
the splitting by index (0-100, ...) is due to a size restriction on
Android Automotive. it doesn't allow lists to exceed a rough length, so if
there are too many songs in a playlist, it has to be split up in some way.
I chose by index because a playlist is typically ordered, although I'm open
to changing the split logic while possibly keeping the playlist ordering if
there are any preferences.
—
Reply to this email directly, view it on GitHub
https://github.com/joeyberkovitz/plex-aaos/issues/23#issuecomment-2354106276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQTB5MX4CPXYCBCER5AWKLZW5IQ5AVCNFSM6AAAAABOJ2R73GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJUGEYDMMRXGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I am having the same issue. I also have a rather large library. I cannot get anything at all to play.
I can go to a somewhat smaller playlist, see it is broken into 100 ranges, when I go into a range and select it, it brings up a track, but refuses to play, then gives an error, and pretty much locks up and dies.

i got this to partially work. My goal is to just randomly play music from my large collection of songs. I created a play list in plex with a filter of "Not played in the last 2 weeks" and limited it to 100 songs. If i select this playlist in Plex AAOS it renders the list and will sometimes play song and sometimes say something like and error has occured, try again later.


Add CodeBeat badge, remove unused whitespace from Readme

Reason of change: We use CodeBeat by default. I've fixed problems with whitespaces in Readme BTW.

@tomajask could you merge it?


GhidraDev Jython creates Java project

I tried to create Ghidra module project and selected Jython to use. But after pressing Finish button it creates the same project as for Java. So, how to use Python in modules?

All Eclipse Ghidra projects created by the GhidraDev plugin are Java projects.  When you enable Python for your Ghidra project, GhidraDev is simply adding the Python nature to the project, and adding Ghidra to Jython's path.  This allows you to use PyDev to edit/debug Python Ghidra scripts that live in your project.
The only aspect of a module project that can be written in Python is Ghidra scripts.  Other parts of the module such as Analyzers, Loaders, Plugins, FileSystem's, etc. must be written in Java.

It would be great to use python loaders/analyzers, etc.


Fix build for golang 1.10

Was getting the error
Errorf format %s has arg metadata.ApiVersion of wrong type

When running tests locally.

LGTM thanks!


refactor this code to use modern code (es6+) and typescript?

are you willing to accept pull requests to migrate incrementally to typescript or more modern code like es6+?
I find kind of "weird" the bits folder (is there all the code is located right now?)
can we also move it inside packages\xlsx?

When the question was posed years ago, the tooling wasn't great.  Older versions of VSCode and github just choke on the xlsx.flow.js script among others.   You can see it in action, https://github.com/SheetJS/sheetjs/blob/master/xlsx.flow.js takes seconds to load and the blamelog literally gives you a 504

The tooling has improved a lot since then, and I think we could start "modernizing" the codebase.  The key requirements are preserving IE compatibility in a standalone script and reproducible builds (easy to do when you're just concatenating scripts)
For historical reasons, the project is split up into multiple repos (The original discussion was in the xls repo and transferred to https://github.com/SheetJS/sheetjs/issues/1834).  Now that the two parts are merged in one project, we should move all of the parts into the repo, and I agree that this should live in the packages directory.
So to start, we could probably make a TS version of bits/04_base64.js

I'd like to help with this refactor. What would be the first step? Starting with the TS version of bits/04_base64.js, the idea is to create a bits/04_base64.ts?

An ESM build has been added to the repo.  It's not 100% yet due to limitations of ES6 import.


GEODE-2657: Execute Region Function sends incorrect message format

TcrMessageExecuteRegionFunction is missing a call to set m_hasResults. This causes the message response to be parsed synchronously and not asynchronously chunked. The synchronous parser does not support this message type and it barfs.

@echobravopapa We're only human.
Our unittest didn't catch it originally because the output that's written to DataOutput in the constructor is the same with/without this variable set.  It's likely when the message is sent that client checks this variable and performs some magic.  I'm guessing our integration-tests that cover this aren't running.  Else we might have had a chance.

@dgkimura I would suggest getting a few of those integration tests updated to test this. They were marked flaky a long time ago when the tests ran through several iterations with different configurations. Now that we don't do that anymore it should be easy to stabilize the tests.

@pivotal-jbarrett Okay. Fair enough. That's going to add some cycles to this pull-request.

@dgkimura It will give the CI something to chew on to prove that this message actually works with the server now. ;)

@dgkimura I will pull this and work on some of the tests.

This will get closed when pull #63 is committed.


Check also if an local nginx is running

Add ability to check for an existing and running local nginx service which may block port 80.

Merged, thanks for your contribution.


Remove unused components and files

Who is this for?
Maintenance
Relates to #10272
What is it doing for them?

Removes unused components (MessageBar, RadioGroup)
Removes unused file (Promo/README.md), although I wonder if the information it contains is still of value? (Think it's 5 years old). @gestchild if you could have a look 🙏
Moves SelectContainer inside Select as it's the only place it is used in.

@rcantin-w Do you need this approved or are you waiting for Gareth to check the readme?

Could be approved if @gestchild doesn't mind having a look anyway, if he thinks there is value in it we can bring it back! (And maybe just have it live somewhere else)


docs: Update langserve to 0.3 and pydantic to 2+ in cli project template

Thank you for contributing to LangChain!

[x] PR title: docs: Update langserve to 0.3 and pydantic to 2+ in cli project template

[x] PR message:

Description: Update langserve to 0.3 and pydantic to 2+ in cli project template
Issue: when using poetry to install something after new an app, it will run into conflicts as the pydantic version required by the template app is too old.

[ ] Add tests and docs: If you're adding a new integration, please include

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/docs/integrations directory.

[ ] Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

Make sure optional dependencies are imported within a function.
Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
Most PRs should not touch more than one package.
Changes should be backwards compatible.
If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@langchain-infra @ccurme could you please help to review this PR? Thanks!

templates are in the 0.2 branch - similar comment to your other PR. Will leave template as-is, and these commands have a warning now about this


Repeatedly collapsing/expanding folders in tree-view crashes the editor

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description

Steps to Reproduce

Open a project with at least two nested folders inside the project
Expand the two nested folders
Start rapidly and repeatedly collapsing/expanding the outer folder of the two

Expected behavior: Folders would expand/collapse
Actual behavior: Editor crashes
Versions
Running Windows 10 with latest Atom beta
Atom    : 1.8.0-beta2
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

I think it's a duplicate. Look in tree view repo?

This should be reported to atom/tree-view, but I'm not sure it's a duplicate (there is a related one though).  I may have been able to reproduce this accidentally before, but I'll double-check later today.


Refactor Input amounts

Currently join inputs have TokenAmount as amountsIn type, but this adds too much complexity for the user to properly build the input. This task aims to replace that with a struct with more basic types:
InputAmount: {     address: Address;     decimals: number;     rawAmount: bigint; }

@lgahdl - note you will have to update the CS Exit PR to match the same type (once this PR is approved/merged)

@lgahdl - note you will have to update the CS Exit PR to match the same type (once this PR is approved/merged)

done


Missing documentation and example for Roles when adding users.

[Enter feedback here]
summary of option list Roles
but details section is missing them.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9087cfbe-fb1f-97d4-051e-b066401c95d1
Version Independent ID: aac162db-a9c0-fbfb-dd40-526e94d3bef8
Content: Add-TeamUser (MicrosoftTeamsPowerShell)
Content Source: teams/teams-ps/teams/Add-TeamUser.md
Service: teams-powershell
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

ignore this -- it there now -- must of missed it.


Train problem

Hello! The following issues were encountered during the training process. Could you give me some guidance？

It seems that you haven't correctly linked the dataset to the required place. You can create a link as suggested in the readme.md.

Thank you for your reply! The dataset soft link seems to be successful because I can preprocess the dataset.

According to the information in your screenshot, the model fails to read the sign language images and raises an error "list index out of range". To locate the issue, you can check the type of the input data in the dataloader_video.py by 'print(type(video))' after line 107. You will mostly get a None output. Call me if you have further problems.

Thank you for your reply! The problem has been resolved. I used an RTX3080 with 10GB memory for training, and in order to prevent OOM, I set the batchsize to 1. However, after the first epoch ended, the following error occurred, and I suspect it was OOM again.

It seems that you don't have enough space on the disk.
---Original---
From: @.>
Date: Wed, Jun 28, 2023 10:52 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [hulianyuyy/SEN_CSLR] Train problem (Issue #7)
Thank you for your reply! The problem has been resolved. I used an RTX3080 with 10GB memory for training, and in order to prevent OOM, I set the batchsize to 1. However, after the first epoch ended, the following error occurred, and I suspect it was OOM again.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Thank you for your reply! Not due to insufficient disk space. The problem has been resolved as follows:
https://github.com/parlance/ctcdecode/issues/124

Many thanks. Hope you can enjoy the work!
---Original---
From: @.>
Date: Thu, Jun 29, 2023 17:27 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [hulianyuyy/SEN_CSLR] Train problem (Issue #7)
Thank you for your reply! Not due to insufficient disk space. The problem has been resolved as follows:
https://github.com/parlance/ctcdecode/issues/124
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Hello! I am here again. I have replaced a new device to run this project. But I have encountered some inexplicable errors. The error message is as follows.

Could you give me some guidance？

Thank you for your reply. The problem has been resolved. This is the problem with sclite. I have another question, can I execute the following command to continue training with the saved weights when my training process unexpectedly terminates.
python main.py --load-weights work_dir/baseline_res18/dev_23.60_epoch15_model.pt

You may use "python main.py --load-checkpoints  work_dir/baseline_res18/dev_23.60_epoch15_model.pt"
---Original---
From: @.>
Date: Fri, Jul 21, 2023 14:23 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [hulianyuyy/SEN_CSLR] Train problem (Issue #7)
Thank you for your reply. The problem has been resolved. This is the problem with sclite. I have another question, can I execute the following command to continue training with the saved weights when my training process unexpectedly terminates.
python main.py --load-weights work_dir/baseline_res18/dev_23.60_epoch15_model.pt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Haha. Thank you. I used the wrong command.

You

Thank you for your reply! Not due to insufficient disk space. The problem has been resolved as follows: https://github.com/parlance/ctcdecode/issues/124

Hello, I have also encountered such a problem. The link is invalid. How was it resolved

You may refer to this issue and this.

Thank you very much for taking the time to reply to me. I will try it out


Mention autoexec.cfg that is created automatically

It won't cause conflicts, as VPKs will always override the loose files in tf. But it may be good to say that it's not used, so users can clean it up.

It won't cause conflicts, as VPKs will always override the loose files in tf. But it may be good to say that it's not used, so users can clean it up.

Alright, I will add another commit.


minor tweaks for browser end support of binary

Seems to work for my versions of chrome safari and firefox at least. Now hopefully also works on node though it might need adjusting with a conditional statement checking the type of data before the buffer is created.

I can't seem to get the tests working even on master so it's hard for me to tell what is required for node.

All tests passing under Node v5.7.0.
Can you post the error messages you're receiving, if any, so I can help troubleshoot?


Data generators and dynamic padding

This PR allows for what I'll call dynamic padding.  This means that padding only happens at a batch level.  If you sort instances by size and then sample slices from this list, you should be able to dramatically decrease runtime, because the amount of padding you actually need is minimized.
So far I've implemented everything but the sorting, for the simplest model case.  Individual models will have to do a little bit of work, probably, to support this for particular padding dimensions, but the changes should be minimal in most cases.

Note that this handles more than just what dynamic_rnn does.  In this particular setting, we're not doing RNNs at all - we're distributing a character-level CNN encoder across an unknown number of words.  This isn't something you would do with dynamic_rnn.
I agree that we need to be careful with this, though, which is why there's so much documentation about how you should probably use TimeDistributed if it works for you.  This limits the kinds of reshaping you can easily do in your models.  I should probably use the EncoderWrapper by default in the word and character tokenizer if use_dynamic_padding is False, actually, otherwise you just won't be able to build certain kinds of models that use character-level encoders.

Yeah sure, you're right. Feel free to merge.


Edit company details

An option to edit the company object with additional details like URL, type (enterprise, SMB...), and even some weight

I understand it can be useful. Added it to our backlog for prioritization.
Quick question: how would you use weight?

A specific company can be more relevant to our product than another company, and the fact that the user is working in that company can increase both its gravity and reach


API: Register User with External IDP

As a developer I am able to register a user with external idp through the api, so I can build my own register ui.
Acceptance Criteria

[ ] I am able to request a list of possible idps (already implemented by #5465 ?)
[ ] I am able to start idp registering
[ ] I am able to create the user with idp linked
[ ] I am able to link the idp to an existing user

Additional Information
Flow:

An endpoint to start the auth flow for xy provider (including success/endpoint url), will send an url back where you have to go
This url will include the provider url and a param with the callback url to get back to ZITADEL backend
Frontend has to call the url where user authenticates on provider xy
Automatically provider xy redirects to callback (ZITADEL backend)
ZITADEL handles all the infos (code exchange, userinfo, etc provider specific)
ZITADEL redirects to success/error page (sent in point 1)
Create user with infos returned from ZITADEL (including provider infos)

/idps/{idp_id}/start
  body: success and failure url
  return: oneOf? (auth_url e.g. https://google.com?...&redirect_uri=https://zitadel.cloud/idps/id/callback)

extend user creation
/users/human
 body: idp_link (idp_id, idp_user_id)?

/users/{user_id}/link_idp
  body: idp_link (idp_id, idp_user_id)?

how to solve callback?
/callback

+1 on this. Would be really nice to have an API to link users with IDPs.


seed schema

Running dbt seed generates a query test_static instead of test.static
dbt_project.yml
seeds:
+schema: static
+database: test
Log
1 of 1 OK loaded seed file test_static.DateDimension.......... [CREATE 2191 in 4.98s]

Hi @cbarry85, check out the docs on using custom schemas.
By default, dbt will append custom schema names to your target.schema, rather than replacing it entirely. Why? If your colleagues were to run dbt seed with the same objects, we want to be sure to avoid collisions—so the default behavior is to populate cbarry85_static and jtcohen6_static, rather than both of us into a single static schema.
Of course, it's understood that, in certain environments, you may want dbt to create objects straight into the static schema, with no prefix, suffix, or any-other-fix. dbt gives you the ability to define the pattern of schema name generation via a macro named generate_schema_name, and it even ships with an alternative pattern built-in: generate_schema_name_for_env. You can see the code for both of these macros here.


Added name switch into readme

I knew this got added but had to hunt around to find #29, it's an awesome feature and this should make it more discoverable.

Thanks for the addition!


Peress/zassume

Add a zassume* API to ztest which parallels zassert* API. The main difference is that a failed condition of the assume API will cause the test to skip instead of fail. This drastically reduces the noise of failed tests when a core feature becomes broken.
Issue #42472

Setting this to a draft as it also includes PR #44954 as a base. The last 4 commits here are ready for review, but the PR needs to wait for the other one to merge first.

@yperess - will it be possible to call zassume from a before_fn() and skip the test?

@yperess - will it be possible to call zassume from a before_fn() and skip the test?

Yes, you can call it from the setup, before, or in the test. It'll stop execution just like a failed assert, but mark the test skipped instead of failed. Note that failing in setup (which runs once per suite) will mark the entire suite skipped.

@yperess - will it be possible to call zassume from a before_fn() and skip the test?

Yes, you can call it from the setup, before, or in the test. It'll stop execution just like a failed assert, but mark the test skipped instead of failed. Note that failing in setup (which runs once per suite) will mark the entire suite skipped.

This would be a good complement to zassert inside of a before_fn() as well, because in some cases it makes sense to skip the test (as in #46960), but then in other cases it would make sense to fail the test as well. Would it be a lot of work to get zassert to fail a test in a before_fn(), but continue with other test cases in the suite?

zassert in a before is 100% fine. Since the before function runs in the same thread as the test it's contextually no different. Setup, after, and teardown run in the main thread and should not have asserts in it.


Moving reference assemblies causes compile to fail for .NETCore portable profiles (7, 78, 259)

Opened at CodePlex by latkin
This repros for new profiles 78, 259, as well as shipped profile 7.
If all referenced assemblies reside in the same directory, compilation works.
If you move one of those assemblies to another directory and reference from there, compilation fails, claiming the assembly is not referenced.
Note - so far I have only reproed for System.Threading.Tasks. This likely does not affect all possible reference assemblies.
Repro (ZIP file attached):
// PortableLibrary1.fs
namespace TypeResIssue

module ABC =
    let f n = async { do! Async.Sleep(n) } |> Async.RunSynchronously

Build against profile 7, using standard reference assemblies (works):
set fscore=%PROGRAMFILES(x86)%\Reference Assemblies\Microsoft\FSharp\.NETCore\<IP_ADDRESS>\FSharp.Core.dll
set sysruntime=%PROGRAMFILES(x86)%\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.5\Profile\Profile7\System.Runtime.dll
set systhread=%PROGRAMFILES(x86)%\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.5\Profile\Profile7\System.Threading.dll
set systhreadtasks=%PROGRAMFILES(x86)%\Reference Assemblies\Microsoft\Framework\.NETPortable\v4.5\Profile\Profile7\System.Threading.Tasks.dll
fsc -a --noframework --targetprofile:netcore -r:"%fscore%" -r:"%sysruntime%" -r:"%systhread%" -r:"%systhreadtasks%" PortableLibrary1.fs

Now simply move System.Threading.Tasks.dll to the local directory and recompile (fails):
xcopy /y "%systhreadtasks%"

fsc -a --noframework --targetprofile:netcore -r:"%fscore%" -r:"%sysruntime%" -r:"%systhread%" -r:"%cd%\System.Threading.Tasks.dll" PortableLibrary1.fs
Error:
PortableLibrary1.fs(4,27): error FS0074: The type referenced through 'System.Threading.CancellationToken' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Threading.Tasks'.

PortableLibrary1.fs(4,47): error FS0074: The type referenced through 'System.Threading.CancellationToken' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Threading.Tasks'.`

file attachments

repro.zip

comments
cameron_tachyus wrote Jan 5 at 1:30 PM [x]
I get a similar error FS0074 when building for the new Xamarin iOS Unified API. It puts the references in different directories. See https://github.com/fsharp/fsharp/issues/367

Closing this very old issue that seems to be an msbuild issue in any case


Adding a fullwidth article with no image below a fullwidth article with an image causes the image to be shown on the lower article

Home page blocks avoids this issue by removing the image block when there is no image. I believe that the issue stems from the template trying to call for an image that doesn't exist.


Adding user to org.yaml does not generate an invite to join the org

I submitted and merged a PR that adds "james-jwu" to org.yaml. I expect that I am able to access https://github.com/orgs/kubeflow/teams/pipelines/members, but cannot. It looks like I am not added to kubflow/members, and I should receive an invite to join but did not.

The sync looks to have completed successfully; here are the logx.
synclogs.txt

Actually looks like there is an error from the most recent sync.
{"component":"peribolos","file":"prow/cmd/peribolos/main.go:201","func":"main.main","level":"fatal","msg":"Configuration failed: failed to configure kubeflow members: all team members/maintainers must also be org members: imjohnbo","time":"2019-09-09T18:20:32Z"}

So looks like imjohnbo is a member of a group but not the org so the config is invalid.
@james-jwu do you want to submit a PR to fix this.

Reopen still broken
{"component":"peribolos","file":"prow/cmd/peribolos/main.go:201","func":"main.main","level":"fatal","msg":"Configuration failed: failed to configure kubeflow members: all team members/maintainers must also be org members: cspavlou","time":"2019-09-09T22:50:33Z"}

Probably due to #145

@james-jwu Can you open up an issue to also add your py_test to the presubmits?
Here's instructions basically you need to add an Argo workflow that would run the test you wrote.
You could take a look at this unittest workflow for kubeflow/kubeflow
https://github.com/kubeflow/kubeflow/blob/5b652b18892c7b49af48ecc365b0af1080e0cb06/prow_config.yaml#L109
(Note its using ksonnet to express the Argo workflow; we don't want to use ksonnet anymore).

@jlewi I opened issue #151. I will fix this issue by updating the org.yaml file, and work on #151 afterwards.


Link FK to the users table

@pyoner wrt https://github.com/basf/metis-bff/commit/dfbf39b444feca259a824fffedfe018b8d7049d6#r124599819

@pyoner ping, is it okay?

@pyoner ping, is it okay?

It looks good


Idea: overview list of interesting INBO-packages

I think that a page ('article') with a simple (short)list could suffice. In order to provide one central overview of the main packages in which INBO has a large ownership / contribution and which are useful to many colleagues (and other people). The primary purpose then, is raising awareness. It could provide one or at most a few lines per package to characterize the package's purpose and provide a link to the package docs.
Examples probably include inborutils, INBOmd, INBOtheme, pydov, git2rdata, ... To be kept up to date.
What do you think?

Having this overview is a great idea I think. From our team, the following R/python packages are probably in scope:

[ ] https://github.com/ropensci/wateRinfo
[ ] https://github.com/DOV-Vlaanderen/pydov
[ ] https://github.com/inbo/pywhip
[ ] https://github.com/inbo/niche_vlaanderen
[ ] https://github.com/inbo/uvabits
[ ] https://github.com/inbo/etn
[ ] https://github.com/inbo/pyinaturalist
[ ] https://github.com/inbo/inborutils

I'll see with the rest of my team to extend the list of packages, later this month.

The following packages are to be added:

https://github.com/inbo/inbomd
https://github.com/inbo/inboggvegan
https://github.com/inbo/inbotheme
https://github.com/inbo/git2rdata
https://github.com/inbo/inlatools
https://github.com/inbo/multimput
https://github.com/ThierryO/grts

The provided link will be the documentation website, if available.
I will make a draft in a PR, for further review.

This has been realised some time ago: https://inbo.github.io/tutorials/articles/inbo_software/


How to calculate mAP in coco style on pascal voc dataset?

Pascal VOC dataset and COCO has different evaluation metric.
How can I calculate mAP in coco style on pascal voc dataset on current mmdetection?

you can convert voc to coco style and calculate mAP in coco style.

@BIGWangYuDong Do you think replacing this line of the code to iou_thrs = [0.5, 0.55, 0.6, 0.65, 0.7, 0.75, 0.8, 0.85, 0.9, 0.95]will do the same job? https://github.com/open-mmlab/mmdetection/blob/f3817df55709e4b13098ebaa9cf72a77b68ce994/mmdet/datasets/voc.py#L63
I've got results from the replaced code like below.
OrderedDict([('AP50', 0.794), ('AP55', 0.774), ('AP60', 0.75), ('AP65', 0.719), ('AP70', 0.666), ('AP75', 0.59), ('AP80', 0.487), ('AP85', 0.35), ('AP90', 0.176), ('AP95', 0.031), ('mAP', 0.533679335564375)])

I remember that COCO metric and VOC metric are not same, it is suggested to use coco style to check whether they are same.


Clientnbts stored in the wrong place

I'm no expert on this but apparently in the fabric version certain nbts are stored in playerdata, not having that breaks just, so much and is making me do a lot extra work, please can you fix this

What exaxtly do you mean by this?
If you're saying that ForgeCaps and cardinal_components should be the same, unfortunately that's something that shouldn't be fixed because we should be using standardised Forge things when possible, even if there is a minor difference.

Well, my example is that the mod figura cannot communicate with origins on forge but can with origins on fabric due to where something is stored, some form of data, the quote from the person who was explaining this to me is as follows: "figura cannot access random data. The only reason this works is because official origins graciously puts all it's data into a common data area: player nbt"

Well, my example is that the mod figura cannot communicate with origins on forge but can with origins on fabric due to where something is stored, some form of data, the quote from the person who was explaining this to me is as follows: "figura cannot access random data. The only reason this works is because official origins graciously puts all it's data into a common data area: player nbt"

Origins Forge should too. I don't have access to my pc atm, but search through the ForgeCaps nbt tag.
The location won't be changed because of loader differences, but, Origins are stored in player nbt here too.

This should probably be written somewhere though

Yeah sorry I don't now what else to tell you other than it doesn't work with forge origins

Must be desync then. I think I understand this now.

I hope so, can you make sure theres a 1.19.2 version with it fixed, that's really important for my like, everything

/data get entity @s ForgeCaps

This screenshot is on 1.20.1, but it should be the same


E723 occurs when there is a line continuation in the argument of extend() in a file read by hooks_files

Description
The error in the screenshot appears when starting with vimrc, described below.
To Reproduce
gvim.exe -N -u ~/vimfiles/vimrc-min-dein-hooks_file -U NONE -i NONE
Expected behavior
Starts without error.
Screenshots

Ignore the "OFF" in screenshot.
Desktop:

OS: Windows11
Vim or Neovim version: Vim v9.0.1425
Commit/Version: https://github.com/Shougo/dein.vim/commit/f8091f4119f23611a10667cba3851aad149a6a2e

Minimal Config
~/vimfiles/vimrc-min-dein-hooks_file
set nocompatible
set runtimepath+=C:\Users\hokorobi\_vim\dein\repos\github.com\Shougo\dein.vim
let g:testdic = {}
call dein#begin('~/_vim/dein')
call dein#add('tweekmonster/helpful.vim', #{
      \ hooks_file: '~/vimfiles/vimrc-min-dein-hooks_file_helpful.vim',
      \ })
call dein#end()
filetype plugin indent on
syntax enable

~/vimfiles/vimrc-min-dein-hooks_file_helpful.vim
" hook_add {{{
call extend(g:testdic, #{
   \ test: 'test',
   \})
" }}}

The line feed code for both files is LF.

The same result with CRLF.

Fixed.


collect tests that dont mod 4

cc @zapu

cc @oconnor663

i'm  not sure what will happen if we roll back the UPAK version

very frustrated about this, i don't know what's broken about my pr
out for most of the day thogh
On Mon, Oct 16, 2017 at 11:03 AM, Mike Maxim<EMAIL_ADDRESS>wrote:

@mmaxim https://github.com/mmaxim requested your review on:
keybase/client#9069 https://github.com/keybase/client/pull/9069 collect
tests that dont mod 4.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/9069#event-1295027168, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_1MoXgWQoy6f9f_CRT3z8x5xp-FIks5ss3BIgaJpZM4P6vXa
.

@maxtaco LMKWYT


Using 'laravel-mongodb' plugin in Laravel Notifications

Is there a possibility that we could achieve adding notification to the database via this plugin?
https://laravel.com/docs/5.3/notifications#database-notifications

Do you have a solution ?

@jenssegers Is this going to be released anytime soon? I see it's merged to master, but we don't have an official version with this included.

@jenssegers as a follow up to @dmitov's comment, any idea when there will be an official release to support notifications?

@jenssegers could you please release an official version with this merged? Would really appreciate it :)

Actually after reviewing it i think it would be better extend the notifiable trait and to remove the hasDatabaseNotifications. The implementation would then look like this:
use Foundation\Models\MongoDatabaseNotification;

trait Notifiable
{
    use \Illuminate\Notifications\Notifiable {
        \Illuminate\Notifications\Notifiable::notifications as baseNotificationsMethod;
    }

    public function notifications()
    {
        if (config('database.default') === 'mongodb') {
            return $this->morphMany(MongoDatabaseNotification::class, 'notifiable')
                ->orderBy('created_at', 'desc');
        }
        return $this->baseNotificationsMethod();
    }
}

It is still not a part of jenssegers/laravel-mongodb for some strange reason.
Eventually sorted it out for temp solution. Should create custom class and traits as per pull request provided and use this custom Notifiable class in order for Laravel Notifications to work.

@jenssegers could you please release an official version with this merged? Would really appreciate it :)

@dean-x what do you mean? Please don't reply in old closed issues

@jenssegers could you please release an official version with this merged? Would really appreciate it :)

@dean-x what do you mean? Please don't reply in old closed issues

I am sorry, I am trying to store notification on db, and facing the same issue, it is not working in monogdb, I checked the suggested answer and it been merged but not being pushed i think?

If you have a problem, please create new issue or go to slack channel for this project


Issue-1016: Update all junit-jupiter dependencies to use new dependen…

Fixes #1016.

@ptirador I'm guessing the checks failed because this wasn't merged yet https://github.com/strongbox/strongbox-parent/pull/13.

Let me merge the strongbox-parent.

Thanks for your help! :)


test_wamr.sh: bump wasi-testsuite version

On posix-like platforms, the rest of wasi-threads tests should pass after the recent changes including the following PRs:
https://github.com/bytecodealliance/wasm-micro-runtime/pull/2516 https://github.com/bytecodealliance/wasm-micro-runtime/pull/2524 https://github.com/bytecodealliance/wasm-micro-runtime/pull/2529

FYI: https://github.com/bytecodealliance/wasm-micro-runtime/pull/2484

i will take a look at failures later

a fix: https://github.com/bytecodealliance/wasm-micro-runtime/pull/2571

see also: https://github.com/bytecodealliance/wasm-micro-runtime/pull/2576

see also https://github.com/bytecodealliance/wasm-micro-runtime/pull/2582

@loganek is this PR good to you? Should we merge it?

@loganek is this PR good to you? Should we merge it?

Just found you mentioned the similar change in #2484, so let's merge this PR first.

@wenyongh sorry for late reply, I'm currently on holidays. Thanks for merging the PR


Vertical white lines between tabbar buttons

Hi!
Our team found an issue with vertical white lines as shown on the picture below. It happens only on big displays such as iPhone 7 plus. On small screens such as iPhone 5s, iPhone 7 no lines are displayed.

I've tried to debug styles both in the app and in the library code and no clue where those lines are coming from.
Would be awesome to understand how to fix this :)

+1 having the same issue here

@maksim-harakhovich-itechart @karimbutt  Is it me or only happens after every two items?

@andresteves yea, seems to happen every 2 items for me

I also have this problem

If someone could provide me with a running working example I could take a look at fixing this

Will close since this issue is more than a year, feel free to a open a new if this is still a issue.

@ptomasroos it happens on larger sized screens like iPhone 7 or 8 Plus for me but works fine on smaller screens. We have an app in production that has this issue - are you looking to just see the issue (i.e., I can give you creds to check it out) or are you looking for the code (in which case I can send you snippets rather than the whole repo)?

I prefer a expo repo I can reproduce it on! Would love to help out if I can reproduce it. Please open a new issue


forc init needs more coloured output

There's a little bit of green here but we can make this look much better with more colours!

I think this is a critical priority

Currently, the init message is printed with tracing::info! but we don't have a solid way of coloring this output with tracing. Maybe, for now, we can switch back to good old print. We likely need coloring with tracing, so I am opening a new issue to track that. Once that is closed, we can also output with colors with tracing.


Export & import favorites

It would be nice if it was possible to export your favorite comics and what ifs into a file and also to import again from such a file for backups or moving to a different device.
I haven't looked into other xkcd viewer apps so I'm not aware of file formats already in use, but since this is basically just a list of numbers, many formats could be possible.

That's already possible! When in the favorites tab, you can select "Favorites Export/Import" from the menu, that will export them to a file


Feature Suggestion: Dark Mode

Option to make the spreadsheet dark mode.

+1

+1 for this feature!


[Bug] ZShot Displacy doesn't return the markup

Summary
The displacy.render method should return the rendered HTML markup, but currently isn't returning anything
Describe the bug
The displacy.render method should return the rendered HTML markup when is not in Jupyter Notebook, but currently isn't returning anything.
To Reproduce
from zshot.utils.data_models import Entity
from zshot.linker import LinkerSMXM
from zshot import PipelineConfig
from zshot.utils.displacy import displacy

nlp = spacy.blank('en')
config = PipelineConfig(
    entities=[
        Entity(name="company", description="The name of a company"),
        Entity(name="location", description="A physical location"),
        Entity(name="chemical compound", description="any substance composed of identical molecules consisting of atoms of two or more chemical elements."),
        Entity(name="organic compound", description="Any of a large class of chemical compounds in which one or more atoms of carbon are covalently linked to atoms of other elements, most commonly hydrogen, oxygen, or nitrogen. The few carbon-containing compounds not classified as organic include carbides, carbonates, and cyanides. See chemical compound.")
    ],
    linker=LinkerSMXM()
)
nlp.add_pipe("zshot", config=config, last=True)

text_acetamide = "CH2O2 is a chemical compound similar to Acetamide used in International Business " \
        "Machines Corporation (IBM) to create new materials that act like PAGs."

doc = nlp(text_acetamide)
res = displacy.render(doc, style="ent", jupyter=False)
print(res is None)

True

Expected behavior
It should return the HTML Markup of the visualization.
from spacy import displacy

nlp = spacy.blank('en')
config = PipelineConfig(
    entities=[
        Entity(name="company", description="The name of a company"),
        Entity(name="location", description="A physical location"),
        Entity(name="chemical compound", description="any substance composed of identical molecules consisting of atoms of two or more chemical elements."),
        Entity(name="organic compound", description="Any of a large class of chemical compounds in which one or more atoms of carbon are covalently linked to atoms of other elements, most commonly hydrogen, oxygen, or nitrogen. The few carbon-containing compounds not classified as organic include carbides, carbonates, and cyanides. See chemical compound.")
    ],
    linker=LinkerSMXM()
)
nlp.add_pipe("zshot", config=config, last=True)

text_acetamide = "CH2O2 is a chemical compound similar to Acetamide used in International Business " \
        "Machines Corporation (IBM) to create new materials that act like PAGs."

doc = nlp(text_acetamide)
res = displacy.render(doc, style="ent", jupyter=False)
print(res is None)

False

Hey @marmg change the code from res = displacy.render(doc, style="ent", jupyter=False) to res = displacy.serve(doc, style="ent") and it will work and show the renders in the browser tab.  I would suggest only use displacy.render() when using in a jupyter notebook .
Below is the ouput image of the render.

Thanks for the comment @AkashKhamkar , this bug should be fixed in #10

you changed and pushed it already, that some fast bug fixing!  :)

Hello @AkashKhamkar. Thank you for your answer.
The displacy.serve function will indeed show the result in the browser, but it doesn't return anything. If the user wants to save the HTML of the visualization, the displacy.render function shall be used, and it should return the HTML like the original displacy.

@AkashKhamkar indeed, all the arguments are passed to the original Spacy method, the only function of our wrapper is to automatically add colors to user defined entities.

@AkashKhamkar indeed, all the arguments are passed to the original Spacy method, the only function of our wrapper is to automatically add colors to user defined entities.


Failure on multibyte UTF-8 characters

Hello,
I installed the module but I'm damned to have non ascii characters in my password so the following happened:
Password: Malformed termination of UTF-8 string
in sub unix-getpass at <path> (Terminal::Getpass) line 27

Indeed - if you only read one byte of an UTF-8 character, you might try to decode something that isn't even valid - and even if it were, nothing good could follow from adding it to the output.
I think this is easy to fix: the processing should either be more byte-like or more character-like.

https://github.com/titsuki/raku-Terminal-Getpass/pull/16 addresses this issue

Fix by #16


In order to build the binaries from source in ubuntu, I needed to add 'installerType = "deb"' for linux in build.gradlew

I had an error with jpackage when trying to build the binaries from source on ubuntu. Error: Invalid or unsupported type: [rpm]
I added in installerType = 'deb' under if(os.linux) and then it built the binary.

Did you run
sudo apt install -y rpm

as instructed?

Did you run
sudo apt install -y rpm

as instructed?

I don't think I did and looking through my terminal history, I did not.

Please take care to read the instructions before opening issues. This is not a support desk - Github issues are for reporting bugs or feature requests.


Boolean slicing of array

Is there any plan to support Boolean slicing of an array?
from numba import jit, prange
import numpy as np

@jit(nopython=True, parallel=True)
def internal_loop(result, values, xy):
    for i in prange(len(result)):
        result[i] = np.max(values[xy == i])
    return result

result = np.zeros(1000)
values = np.random.random((2048, 2048))
xy = np.random.randint(0, 1000, (2048, 2048))
internal_loop(result, values, xy)

Gives an error
numba.errors.InternalError: unsupported array index type array(bool, 2d, C) in [array(bool, 2d, C)]

It is certainly something we can do, and would be useful.  I've marked this as a feature request issue.

Thank you very much!

In the meantime, whilst convoluted, this might work/think it is doing something similar:
from numba import njit, prange
import numpy as np

def func(values, xy, i):
    mask = np.where(xy.ravel() == i)
    return  np.max(values.ravel()[mask])

def internal_loop(result, values, xy):
    for i in prange(len(result)):
        result[i] = func(values, xy, i)
    return result

# setup
np.random.seed(0)
values = np.random.random((204, 204))
xy = np.random.randint(0, 1000, (204, 204))

# numpy version
result = np.zeros(100)
npres = internal_loop(result, values, xy)

# wipe result
result = np.zeros(100)
# set parallel for the outer function
pnjit = njit(parallel=True)
#overwrite func global so njit can find it
func = njit(func)
# jit the func with prange
jit_internal_loop = pnjit(internal_loop)
# numba result
nbres = jit_internal_loop(result, values, xy)

np.testing.assert_allclose(npres, nbres)

using this I got the following times
from numba import njit, prange
import numpy as np
import time

def func(values, xy, i):
    mask = np.where(xy.ravel() == i)
    return  np.max(values.ravel()[mask])

def internal_loop(result, values, xy):
    for i in prange(len(result)):
        result[i] = func(values, xy, i)
    return result

# setup
np.random.seed(0)
size = 204
values = np.random.random((size, size))
xy = np.random.randint(0, 1000, (size, size))

# numpy version
result = np.zeros(100)
ts = [time.time()]
npres = internal_loop(result, values, xy)
ts.append(time.time())

# wipe result
result = np.zeros(100)
# set parallel for the outer function
pnjit = njit(parallel=True)
#overwrite func global so njit can find it
func = njit(func)
# jit the func with prange
jit_internal_loop = pnjit(internal_loop)
# numba result
ts.append(time.time())
nbres = jit_internal_loop(result, values, xy)
ts.append(time.time())

np.testing.assert_allclose(npres, nbres)
print([t1 - t0 for t0, t1 in zip(ts[:-1], ts[1:])])

[0.003907680511474609, 0.017543792724609375, 0.9217896461486816]
(numpy seems faster than numba)
If I increase the size to 2048
I get [0.405731201171875, 0.017040729522705078, 1.195162296295166]

Think you are including the time to compile the function along with the time to run the function? The first call to a jitted function will hit the dispatcher and trigger compilation, compiling takes time. To time the actual execution, you have two options, either run the call once and then run it again and time that, or specify the type signature up front.
Timing actual execution for 2048/1000, on a not very good processor I get:
numpy=8.1843581199646
parallel=5.206227779388428
njit=10.682238578796387

Fundamentally this code is doing a linear search and a then random lookup on large arrays, I would not expect massive improvement in performance as it is probably waiting on memory a lot of the time.
You may want to use this to present your times as the start/stop are pairwise?:
[te - ti for te, ti in zip(ts[1::2], ts[::2])]

Hope this helps.

Incidentally, this is why I like writing benchmarks using %timeit in Jupyter notebooks, or (for more involved benchmarks that need to scan a range of inputs) using numba_bench in the numba-examples repo: https://github.com/numba/numba-examples
Both will automatically run your code many times to get a more accurate estimate.

There are actually serveral issues here:

2D boolean slicing is not supported by Numba, but 1D is.

Currently parallel=True will not parallelize 1D boolean selection. I have been working on this, and will submit a PR soon.

With parallel=True and 1D boolean array, it'll actually trigger bug #2529.

Thank you very much!

I guess I could ravel everything
Out of curiosity, why won't parallelizing inner_loop help the speed?
Hmm ok.

For posterity, I was able to speed this up a bit by sorting the flattened xy array, using bincount to extract the number of unique bins and then slicing the values array by the bincount.

Was this issue resolved?

Any solution?

@PJY-609  @LucaCappelletti94 as of 0.51.2 this issue is still open and support has not been implemented I'm afraid, once it is this ticket will be closed.

Tiny bump because it would be really appreciated if this feature could be implemented at some point ! :)


mobile view is buggy

on real mobile devices menu is hidden to late (means it flashes one time)
on some mobiles login don't work ->leads to kind of code page (Source code like)

no flashing in mobile -> jumping in browser...
no jumping in browser -> flashing in mobile

bringt es was das js umzubauen?
von $(document).ready zu window.menuapp =
und das dann gleich nach dem navframe laufen zu lassen mit <script>menuapp.run();</script> ?

i think i got it via css

fail =(

done it almost nice^^ with min height