doctring improvement

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi,
I see that those changes have already been overridden and the docstring reset to what it was before, probably by your automation workflows.
Should I understand that it is not possible to improve your documentation then?

@Brunner246 C interfaces should be updated. Can you rerun the parser and see if it picks up the overrides?

@jspaquet
At some point i made a full "rebuild" of the python interfaces, so that everything is identical to the c++ interfaces. We have also updated the syntax of the docstrings. It also uses the c++ docs (doxygen) to create the python docstrings (single source of truth), so it seems like this "errors" in the docs are also in the c++ interfaces.
Sorry for the inconvenience @pierreBodineau , but we had to do some modifications during that time. You could either change it again and start a PR on develop or we adjust that for a next release in cpp and generate the python interfaces again from it.
# changed docstrings syntax
def get_volume(element_id: int) -> float:
    """Gets the element real volume

    Parameters:
        element_id: element_id

    Returns:
        element real volume
    """

@Brunner246 I already made the changes to the C interfaces doxygen comments. That should get picked up next time we generate right?

@jspaquet https://github.com/cwapi3d/cwapi3dpython/blob/develop/src/geometry_controller/init.pyi#L544


Preprocess census

Added comments.

Hi! I appreciate the use of folktables and the work you put into this.
Is there anything specific to this preprocessing that you think it should part of the main codebase?
From reading it, it looks to me like this is one reasonable way to preprocess the data. There are many others that could be suitable depending on application. The main code base is not the right place to collect these. My sense is that this code is best off in the repository for whatever project you're using it for.
If you're looking for a dataset that's very similar to UCI Adult, you may want to consider adult_reconstruction.csv.


Add temporary hack to resolve Go import path in google/api

Types in protobuf package google.api is laid out differently in Go.
The proto files defining these types will need go_package option
so that we can generate imports properly.
This commit introduce a hack so that we can generate services while
waiting for this option to be added.

Current coverage is 78.84% (diff: 0.00%)

Merging #536 into master will decrease coverage by 0.07%

@@             master       #536   diff @@
==========================================
  Files           247        247
  Lines          9067       9076     +9
  Methods           0          0
  Messages          0          0
  Branches       1178       1183     +5
==========================================
  Hits           7156       7156
- Misses         1606       1613     +7
- Partials        305        307     +2

Powered by Codecov. Last update e3cb288...8fd7094

LGTM


Spotify' object has no attribute 'playlist'

The problem

Environment

Home Assistant release with the issue: 105.1
Last working Home Assistant release (if known): 104.x and below, old spotify integratoon
Operating environment (Hass.io/Docker/Windows/etc.):  Home Assistant
Integration causing this issue: Spotify
Link to integration documentation on our website:  https://www.home-assistant.io/integrations/spotify/

Problem-relevant configuration.yaml
spotify:
  client_id: !secret spotify_id
  client_secret: !secret spotify_secret

Traceback/Error logs
2020-02-07 11:29:48 ERROR (MainThread) [homeassistant.helpers.entity] Update for media_player.spotify fails
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 279, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 461, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/spotify/media_player.py", line 83, in wrapper
    result = func(self, *args, **kwargs)
  File "/usr/src/homeassistant/homeassistant/components/spotify/media_player.py", line 338, in update
    self._playlist = self._spotify.playlist(current["context"]["uri"])
AttributeError: 'Spotify' object has no attribute 'playlist'

@frenck  , can you have a look at it, not urgent :-)

@pergolafabio have you followed the documentation and activated your account?

I'm having similar issues with the new integration. Rolling back the old integration still works as expected. I even created a new application on Spotify Dev to no avail.

@pergolafabio have you followed the documentation and activated your account?

Yeah, folllwed new installation steps, all is working and authorized with new callback url...
Everything also works as expected, just my log file is flooding when I am listening to spotify

@pergolafabio on which device are you playing the music? Please describe the problem more thoroughly and add it to the issue.

I am playing it on a Denon receiver with Spotify connect

i now tried the spotify webplayer, as soon as a start playing on my laptop, the error mesagges are beginning

Pffffff,
El dom., 9 de feb. de 2020, 3:51 a. m., pergolafabio <
<EMAIL_ADDRESS>escribió:

i now tried the spotify webplayer, as soon as a start playing on my
laptop, the error mesagges are beginning
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/31582?email_source=notifications&email_token=AKU5V2POKYACSFKNS3UX343RB67XXA5CNFSM4KRMFV62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGGMMI#issuecomment-583820849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKU5V2IPG7CV5DAECNJL64LRB67XXANCNFSM4KRMFV6Q
.

Thanks for reporting this in guys. I'll take a look if I can see what is going on.

Thnx in advance, am I the only one with issue? Since no one else is reply ing

I also have this issue, however it only affects one of my accounts, the other one works fine

I'm also having this issue. Spotify is sometimes not available and when its available would say it's idle, even though it's currently playing.

spotify: Error on device update! Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 304, in _async_add_entity     await entity.async_device_update(warning=False)   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 461, in async_device_update     await self.hass.async_add_executor_job(self.update)   File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run     result = self.fn(*self.args, **self.kwargs)   File "/usr/src/homeassistant/homeassistant/components/spotify/media_player.py", line 83, in wrapper     result = func(self, *args, **kwargs)   File "/usr/src/homeassistant/homeassistant/components/spotify/media_player.py", line 338, in update     self._playlist = self._spotify.playlist(current["context"]["uri"]) AttributeError: 'Spotify' object has no attribute 'playlist'

The problem for me right now, is that I'm unable to reproduce this.
I've tried the following:

Set up an integration with a premium account
Start a (private) playlist on the desktop client
Start a (public) playlist on the desktop client
Start an album on the desktop client
Start Spotify radio on the desktop client

I've repeated the above for the following as well:

Using a free Spotify account
Using a Sonos Beam
Using a Google Home

my testings are with a premium account, testing when i start a playlist from chrome or if i use the receiver
what can i do to test or provide you more info ?

@frenck i'm not sure if my problem is related however i can't get the new integration to work either.
I end up getting this error everytime i start playback from a device
Error doing job: Task exception was never retrieved Traceback (most recent call last):   File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 424, in _async_add_entity     await entity.async_update_ha_state()   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 284, in async_update_ha_state     self._async_write_ha_state()   File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 327, in _async_write_ha_state     attr.update(self.state_attributes or {})   File "/usr/src/homeassistant/homeassistant/components/media_player/__init__.py", line 793, in state_attributes     for attr in ATTR_TO_PROPERTY   File "/usr/src/homeassistant/homeassistant/components/media_player/__init__.py", line 794, in <dictcomp>     if getattr(self, attr) is not None   File "/usr/src/homeassistant/homeassistant/components/spotify/media_player.py", line 160, in media_content_id     return self._currently_playing.get("item", {}).get("name") AttributeError: 'NoneType' object has no attribute 'get'

No that is not related, @Waseh. Please don't stack things in the same issue. Please open up a separate issue for that.

AttributeError: 'Spotify' object has no attribute 'playlist'
This error made me think. playlist is not an attribute to the Spotify object, but a method. So that message makes no sense. The only reason why Python would throw that error is when the methods & attributes both don't exist.
But that makes no sense, since well.. the method is hardcoded in the codebase, and thus cannot be missing.
This methods, however, was introduced in Spotipy (the library used) 2.6.0+. The current version used by the integration is 2.7.1. The previous version of the integration did have an older version, which indeed does not have the playlist method.
So, that makes me think, why do you guys have a possibly older version?
Are you using a custom component or integration that does something with Spotify? Maybe an issue with a virtual environment (if used)?

i have indeed this sensor :
https://github.com/dnguyen800/spotify-playlist-sensor
and also playing with those 2 cards as a test:
https://github.com/dnguyen800/spotify-playlist-card
and
https://github.com/custom-cards/spotify-card

Are you using a custom component or integration that does something with Spotify?

I did. I'm also just recently installed the spotify-playlist-sensor.
I uninstalled it but now the integration doesn't list an entity to integrate.

I'm using Home Assistant via Docker running on Ubuntu 18.04.

I am going to unload the custom and try again tomorrow his evening, keep you posted...

But maybe if I comment the sensor, maybe the spotipy will not update?

This custom component: https://github.com/dnguyen800/spotify-playlist-sensor
Will cause these issues for sure.

Uninstalled the custom component and also the two lovelace cards that @pergolafabio also used. Restarted Home Assistant a few times, reinitiated the integration a few times. But even with spotify-playlist-sensor removed I still got the error message from the beginning.
AttributeError: 'Spotify' object has no attribute 'playlist' in the logs.
media_player.spotify stuck in unavailable state

@holnburger If you are on Home Assistant Supervised or Operating System (previously called Hass.io), you will need to rebuild the core container to get rid of it.
hassio ha rebuild from the SSH add-on console.

I don't think that is the issue in my case. I'm running in docker and pip show spotipy outputs this
bash-5.0# pip show spotipy
Name: spotipy
Version: 2.7.1
Summary: A light weight Python library for the Spotify Web API
Home-page: http://spotipy.readthedocs.org/
Author: @plamere
Author-email<EMAIL_ADDRESS>License: LICENSE.md
Location: /usr/local/lib/python3.7/site-packages
Requires: six, requests
Required-by:

I will try the custom component, with a changed requirement manually to new spotipy, that should resolve also?

@roflcoopter
pip show spotipy-homeassistant ? That would be the conflicting package.
@pergolafabio The problem is that the original spotipy-homeassistant might still be installed at that point.

Ok, I will try and keep you posted...
But that custom one should be updated with new requirement anyway? I'll create an issue there then

@roflcoopter
pip show spotipy-homeassistant ? That would be the conflicting package.
@pergolafabio The problem is that the original spotipy-homeassistant might still be installed at that point.

Bingo, Recreated my container and now it works

Still with that custom installed?

@holnburger If you are on Home Assistant Supervised or Operating System (previously called Hass.io), you will need to rebuild the core container to get rid of it.
hassio ha rebuild from the SSH add-on console.

This did solve it! It's working again! Thank you

i did a rebuild, it was succesfull
allthough issie is still happening
i cant do a pip ... , running hassos here, pip not found

what are my best steps?
unload the custom, restart hassos, rebuid, then load custom again?

You can't use the custom @pergolafabio, it will break things.

Crap, what needs to be done at the custom component to not have those errors then?

Contact the custom component creator? This is really out of scope for me and/or Home Assistant.
We don't support custom integrations in general.

Ok, Will do
Thnx in advance for the feedback

@frenck maybe off-topic, but isn't it possible maybe with the new integration you created to retrieve the playlists from Spotify, that's what the custom does... So then maybe we don't need the custom anymore at all


[BXMSPROD-1353] --ignore-scripts to install-locktt script

https://issues.redhat.com/browse/BXMSPROD-1353
opencv4nodejs-prebuilt post install is making install-locktt script to fail.

@Ginxo This dependency you mentioned on the description is not on the repository anymore, can you please re-check if we still need this PR?

@tiagobento you can check https://eng-jenkins-csb-business-automation.apps.ocp4.prod.psi.redhat.com/job/PROD/job/kogito-tooling.nightly/job/master/50
npm ERR! code 1
npm ERR! path /home/jenkins/workspace/OD_kogito-tooling.nightly_master/kiegroup_kogito-tooling/node_modules/vscode-extension-tester-native/node_modules/opencv4nodejs-prebuilt
npm ERR! command failed
npm ERR! command sh -c prebuild-install || (node ./install/dependencies.js && node ./install/install.js)
npm ERR! Installing prebuilt OpenCV vundefined for plattform linux

anyway the --ignore-scripts flag is a good to have in order not to interfere on the lock-tt installation.


Chooser buttons focus colour is too dark in dark mode

Is your proposal related to a problem?
Chooser buttons become dull after being visited leading editors to think the button is disabled.
To replicate, click a chooser, dismiss the modal.
Before:

After:

Describe the solution you'd like
CSS has the following rule:
.button.chooser__choose-button {
    align-items: center;
    border-color: #0000;
    color: var(--w-color-text-label);
    color: var(--w-color-text-button-outline-default);
    display: flex;
    font-size: .875rem;
    font-weight: 500;
    line-height: 1.3;
    padding: .375rem;
}

Amend the selector to include the visited state:
.button.chooser__choose-button, .button.chooser__choose-button:visited {
    align-items: center;
    border-color: #0000;
    color: var(--w-color-text-label);
    color: var(--w-color-text-button-outline-default);
    display: flex;
    font-size: .875rem;
    font-weight: 500;
    line-height: 1.3;
    padding: .375rem;
}

Buttons retain original colouring on tests.
Tested with image, page and generic choosers.

@enzedonline Hey made a pr.
Can you check and let me know for further corrections?

@subhajit20  @enzedonline
I think that the visited styling may appear to fix things but does not fix the real problem.

Buttons should not really be styled with the :visited pseudo class, this is for links usually - https://developer.mozilla.org/en-US/docs/Web/CSS/:visited
The actual 'dull' styling comes with the button hover/focus styles, which must actually be visibly different.

As such, I think there needs to be a change to the theme colours used.
// client/scss/components/_chooser.scss
.button.chooser__choose-button {
  // ...
  &:hover,
  &:focus {
    color: theme('colors.surface-button-hover');
    background-color: theme('colors.surface-page');
  }

see client/src/tokens/colorThemes.js
I think here we will need some guidance from either @thibaudcolas or @benenright
Sorry @subhajit20 but for now, I recommend closing your PR until there is a bit of a clearer direction here, changing those colours may have other impacts elsewhere. I agree it's a problem but it needs a bit more design guidance.

True, this is a bug. Looking at the button element on opening/closing the modal, the button gets disabled=true while the modal is open. This clears after closing the modal but the disabled style remains. If I click outside of the window (e.g. in the inspect panel) the standard button styling is restored.

Please assign me this issue. I want to work on this issue

@codesmith25103 as per the other issue, please avoid spamming issues with claim requests. Please also read the issue and comments in full also, you may note that this issue is waiting on a UI design confirmation for what colours to use.

Hi
This relates to some work on dark mode colour variables we are doing here: https://github.com/wagtail/wagtail/issues/11060
I have added updates to the outline button hover styling (as discussed above) to this spreadsheet: https://docs.google.com/spreadsheets/d/16CY8ClwPgywN5aJrXZ57ePrAXGpeDpPaXsaUjWgTXnM/edit#gid=1503114917
Screenshot of my proposed hover state in dark mode:

And in Light mode for ref:

Ben

This looks good. Has the :focus style also been looked at? This was the cause of the initial problem. Since the button retains focus after the modal has been dismissed, this is the style used.

I would suggest we use the same styling for :focus as we are suggesting for :hover... but also, shouldn't it retain the focus outline? -

@rohitsrma  I think you are on the right track, feel free to prep a PR and we can test it out.

Thanks @lb- I've created a PR #11288


Error when running main

I got the following error:
File "main.py", line 24, in <module>     app = Application()   File "main.py", line 19, in __init__     self.slowMarket = GUIslowtick(self)   File "C:\Users\User\Desktop\Bittrex-Notify-master\src\GUIslowtick.py", line 14, in __init__     misc.delete_ancient_pickles('slowtick_history')   File "C:\Users\User\Desktop\Bittrex-Notify-master\src\misc.py", line 69, in delete_ancient_pickles     raise ValueError('folder does not exist or incorrect folder name') ValueError: folder does not exist or incorrect folder name

@Sile25 Can you confirm if you have a "slowtick_history" folder in the /src/ folder? It's probably an issue on my end, I'll look into this in the coming days.

@Sile25 What os/platform are you using? I've made some changes that should fix the issue, let me know if you have any more problems.

Sorry for not answering, i did not see the mail! I'm using Windows 10 with python 3.6, i tried again but i got the same error. I think that i'm doing something wrong. I open the folder > open src > open main > run it > got the error

@Sile25 Ok, there should be 3 folders in the /src/ directory:
"fasttick_history"
"media"
"slowtick_history"
There is also "slowtick.py" and "fasttick.py" files but they aren't causing the error.
Now that I think about it, at some point I refactored/renamed almost everything so if you downloaded this before then I can see why it potentially wouldn't find the folder. If you don't have a fasttick_history/slowtick_history folder you can just create one, or just clone/unzip the latest version.

So i created the two folders and now it's running perfectly! I love the GUI and it's an awesome idea, i still did not see something like this on python yet, so good work!
Two questions: i have been running it for some minutes but i still did not get updates, is it because i am missing something?
Second: do you know if this bot could be deployed to Heroku in order to host it there and have it running 24/7? I managed to run a bunch of python scripts there but i don't know if it could be possible in this case, i'll try however!

@Sile25

i have been running it for some minutes but i still did not get updates, is it because i am missing something?

Not necessarily, because fasttick(the lower section) takes a measurement every 20 seconds and uses a maximum of 10, it'll take about 3 minutes to reach "full accuracy". In my last refactor I also upped the threshold to .45 from (.30 I think) and some days the market is slow and it shows. You can change that value in config.py named FASTTICK_MIN_RATE and restart, I'll add an menu option at some point for that.

do you know if this bot could be deployed to Heroku in order to host it there and have it running 24/7?

Possibly, I haven't heard of it until now. I've solved(I hope lol) all the stability issues when making a request to bittrex and have left it running for 4-5 days no problem.

Awesome, thanks!

I'll try it. Thanks for solving my problem!


typo Optimize the upgrade documentation

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


How to add a custom popup?

Looking through the documentation, I already know this is how you disable the default popup
var cal = new Calendar('#calendar', {
    useCreationPopup: false,
    useDetailPopup: false,
...
});

However, not mentioned in the documentation is how to add the replaced one afterwards. I have a modal made in bootstrap
that has bespoke form entries, that I got to work already with createSchedules. But how would I make that modal be the one that would pop up when I clicked on a given date to create an event?
Not sharing full modal because it's made from bootstrap and therefore massive, but what it involve using the id of the modal to link it to the calendar object?
<div class="modal fade" id="create_event" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">

check it out
// event handlers
cal.on({
    'beforeCreateSchedule': function(e) {
        console.log('beforeCreateSchedule', e);
        // open a your creation popup
        /*...*/

        // then close guide element(blue box from dragging or clicking days)
        e.guide.clearGuideElement();
    },
});

Thanks 👍. Realized I was using the wrong event handler. beforeCreateSchedule works like a charm


handle failures to find a user home directory

In certain environments (notably, the bazel sandbox on windows), it is possible for pathlib.Path('~').expanduser() to fail to find the user home directory and raise a RuntimeError. This causes distutils (and ultimately, setuptools) to fail.
With this patch, we catch and handle the exception by logging a warning and continuing without a user's config file.
motivated by https://github.com/bazelbuild/rules_python/pull/1067

In other scenarios, I've taken measures to explicitly set the home dir to a known location.

That's pretty much the workaround I implemented in https://github.com/bazelbuild/rules_python/pull/1067/files#diff-a92cc6468f47191b8e22d4bbe2564d3968d3dd4bbc383b9f3df3c4c520e1583eR157-R165.

Wouldn't it be better for bazel sandbox to provide a suitable (empty) home directory and thus address this concern for any project running in the sandbox?

Personally, I can't think of a reason for setuptools/distutils to put the burden of ensuring a home directory exists on its users and/or other projects (rules_python/bazel).
Failing to find a home directory that might contain a user config file and failing to find a user config file within a located home directory are both ways that setuptools/distutils might fail to find a user config file. I would expect setuptools/distutils to behave the same (continue the build without using user configuration) in both cases.
For what it's worth, other Python build backends (eg: flit, hatchling) do not fail in the event that you attempt to build without a valid home directory.

Personally, I can't think of a reason for setuptools/distutils to put the burden of ensuring a home directory exists on its users and/or other projects (rules_python/bazel).

I think I agree with you here. However, there's another factor to consider. Do you want rules_python to be sensitive to settings in the user's home directory? The reason I created those exclusions was not because the project failed when there was no home directory, but because the user's configuration changed the default behaviors, affecting tests that were meant to run in isolation. My guess is that rules_python would want the same isolation, which you'll lose if we roll out this change and then you remove the workaround.
That said, you make a compelling argument. There's not a very good reason for distutils not to be resilient under such conditions.

Do you want rules_python to be sensitive to settings in the user's home directory?

Personally, no. But my understanding is that bazel's sandbox prevents reads/writes outside of the sandbox (plus, bazel builds are often performed remotely, in which case the home directory of the user invoking bazel build <TARGET> won't be present). In either case, this should now silently fail to find the user's config file (as desired!)


kubecontext default color not set

Introduced with #576
Default value of SPACESHIP_KUBECONTEXT_COLOR_GROUPS sets the color to () and overrides SPACESHIP_KUBECONTEXT_COLOR.
Current behavior

Expected behavior

Relevant Zsh configuration (.zshrc)
SPACESHIP_PROMPT_ORDER=(dir kubecontext line_sep char)

Environment
Spaceship version: https://github.com/denysdovhan/spaceship-prompt/commit/4a7aaf8769e171909febbd52ae2938525cf808ae
Zsh version: 5.5.1
Zsh framework: None
Zsh plugin manager: None
Trace
+spaceship_kubecontext:15> local section_color i color pattern
+spaceship_kubecontext:16> local len=1
+spaceship_kubecontext:18> i = 1
+spaceship_kubecontext:18> i <= 1
+spaceship_kubecontext:19> color='()'
+spaceship_kubecontext:20> pattern=''
+spaceship_kubecontext:21> [[ "$kube_context" -regex-match "$pattern" ]]
+spaceship_kubecontext:22> section_color='()'
+spaceship_kubecontext:23> break
+spaceship_kubecontext:27> [[ -z '()' ]]
+spaceship_kubecontext:29> spaceship::section '()' 'at ' '☸  spaceship-testing' ' '

Possible solution

Exit loop if length of array is 1, Since we require at least pair of values (color-pattern) to check for pattern.

 for ((i = 1; i < $len; i+=2)); do

// @maximbaz @nomaed

Why it wasn't checked before merging?

Had trouble setting up testing environment while doing review due to local issues. Identified this as soon as I was able to test it out locally.

It was tested, technically. At length even. But then different approaches were tried and it wasn't retested... Sorry, gonna submit a fix in a moment.
There's a weird thing now that SPACESHIP_KUBECONTEXT_SHOW is "false" even if I explicitly set it to "true" in my .zshrc... Trying to find where it can come from.


format source

hey @rafoli  I've made a few slight changes.  Can you do the following to help move this forward?

confirm that I haven't broken anythign with my changes :)

can you replicate this project in other directories?  liferay-workspace, and maven?
don't worry just yet about the tests just the bundles diff is the only one we need right now

after you have made your changes you can test it (to make sure everything is the same between gradle/worksapce/maven) by doing this:
$ build-notests.sh

Just started reviewing :) :octocat: Sent from GH.

see https://github.com/gamerson/liferay-blade-samples/pull/342


Change the default matrix test goals to include running failsafe

Description
Adds failsafe:integration-test and failsafe:verify to the default TestGoals. This runs integration testing, and we should be doing that as a normal pipeline run. This also allow for sdk/core and sdk/clientcore to remove their matrix replaces.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - cosmos

/azp run java - spring


signalbackup-tools: 20231002-1 -> 20231003

Description of changes
Update to latest version. No changes that effect build.
Diff: https://github.com/bepaald/signalbackup-tools/compare/20231002-1...20231003
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.


Dups in raw__xpro__openedx__tracking_logs

While working on staging raw__xpro__openedx__tracking_logs, I noticed that over 1 million events are loaded twice for some reason
select count(*), username, event_type, context, time
from  "ol_data_lake_production"."ol_warehouse_production_raw"."raw__xpro__openedx__tracking_logs"
where username != ''
group by username, event_type, context,  time
having count(*) > 1
order by time desc

I checked a few events and can confirm that these only appear once in the raw file. Since we stage this table as an incremental model, it's best to not have to dedup in dbt as it would add extra work and complexity to our code.
Expected Behavior

raw__xpro__openedx__tracking_logs should not contain dups
Current Behavior

raw__xpro__openedx__tracking_logs contains 1,367,948 dups as of 07/21/2023

@quazi-h @blarghmatey Can you take a look at this?

For now, I will handle the dups in the staging model. But that is not an ideal solution because the dups are introduced by our Airbyte load process, not caused by actual changes in underlying event data. Also, the newly duplicated data have the same value for the cursor field _ab_source_file_last_modified, just a nanosecond difference in vector_timestamp. so I don't quite understand why Airbyte would duplicate that because the cursor field is the same.

I've handled dups in https://github.com/mitodl/ol-data-platform/pull/769. There are two types of dups I've seen in the raw table so far

Events are identical except for nano-second differences in vector_timestamp. For these, they appear twice in the raw file as well. I am wondering if these dups are caused by the log connector.

e.g.
select * from "ol_data_lake_production"."ol_warehouse_production_raw"."raw__xpro__openedx__tracking_logs"
WHERE time like '2023-07-24T23:29:35.045089+00:00'

Events are identical except for airbyte internal fields like _ab_source_file_last_modified. For those, they seem to be introduced by airbyte as these only appear once in the raw file.

e.g.
---identical events
select *
from  "ol_data_lake_production"."ol_warehouse_production_raw"."raw__xpro__openedx__tracking_logs"
WHERE time like '2023-06-01 14:45:57.987843'

As discussed with Tobias, we don't need to worry about which process introduced duplicates. I should just dedup data on staging


Android: Migrate away from MANAGE_EXTERNAL_STORAGE permission

Google rejected any update from v1.14.0 onwards because MANAGE_EXTERNAL_STORAGE is used.
I do agree that LocalSend can use less permission to operate, however, Android 11 requires scoped storage which Flutter doesn't fully support (https://github.com/flutter/flutter/issues/147037). (very funny because Flutter and Android are both developed by Google)
This permission was added in this commit 8ebec6f2, so that arbitrary folders can be created and read.

Can't set save folder to Download anymore? (/storage/emulated/0/Download)

I cannot reproduce this @sudoshindo
It somehow works on my Samsung phone and also in the Android emulators.

@Tienisto sorry, I should have been more clear about what I said.
I don't have a bug or issue with the apps.
I'm just asking if this permission you removed will stop users from picking /storage/emulated/0/Download as the Save Folder.
A lot of apps can't use Download directly anymore because Android/Google doesn't allow it. You have to make a subfolder under Download, like Download/Localsend.

Thanks for your input. I've noticed that you don't have read access to the Download folder but you can write anything. So if you keep the default setting, then everything should work as before.


Fix refreshFormData with Enum

Description

If you use refreshFormData on values that are cast as Enums in the Model, the enum will be loaded instead of its value, which will cause a problem when submitting the form.
My PR fixes this problem by iterating through the values to refresh and taking ->value in the case of an Enum.
The solution is certainly not perfect for Filament's framework.
I'll let the experts correct this properly :)

[ ] Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

[X] composer cs command has been run.

Testing
See my previous comment for this.

[ ] Changes have been tested.

When the form is first loaded, the value is an enum instead of a string. Right?

Nope, the first time the component is loaded with the form, it is indeed a string, even if the field is of type Enum.
The issue only occurs when using the refreshFormData function with a casted Enum field.

Thanks


Feat/add delay between signals

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add functionality of delay between signals requested by a community member
Tests performed by the developer:
run a directional strategy that returns all the time 1 and check that the script waits until the next signal
Tips for QA testing:

HI @cardosofede i tried to run the Github CI and getting this result 2/2

@rapcmia fixed!

Merged PR on behalf of the foundation team to development and will be available on release version 1.18.0


Freezing with many LineStrings im MemoryLayer

Hi, I'm new to MapsUI, trying to find out, if it could replace the old mapengine in my apps.
To display gps-tracks I created a MemoryLayer. In the ctor the gps-tracks are loaded from my source source, the LineStrings are created and then geometries and features. I even create a simplified copy for each resolution for each linestring.
In GetFeatures, just the features according to box and resolution are returned.
It works fine, but only if its not too many tracks. For example if its maybe more then 50 tracks with 1000 points each, the mapcontrol freezes. Funny enough I see in the debugger windows, that GetFeatures is still called and also the process is running with maybe 20% cpu-load.
Am I doing something wrong? Is there a better way to render many linestrings?
I also found this issue #1705, which might be similar?
I'm working with 4.0.0-beta5 on UWP, didn't test other platforms yet.

public class TrackLayer : Mapsui.Layers.MemoryLayer
    {
        Dictionary<double, GeometryFeature[]> _features;

        public TrackLayer(IMarkEx markex, Mapsui.Map map)
        {
            try
            {
                this.Tag = markex;
                this.Name = markex.Mark.Name;
                this.Style = markex.LineStyle();

                // TODO: projection??

                // TODO: one linestring for each tracksegment
                var coordinates = markex.Track.GetList().Select(t => SphericalMercator.FromLonLat(t.Lon, t.Lat).ToCoordinate()).ToArray();
                var linestrings = new GeometryFactory().CreateLineString(coordinates);

                var lastcount = 0;
                _features = new Dictionary<double, GeometryFeature[]>();
                foreach (var resolution in map.Resolutions)
                {
                    var simplifiedlinestrings = TopologyPreservingSimplifier.Simplify(linestrings, resolution);
                    var count = ((LineString)simplifiedlinestrings).Count;
                    if (count != lastcount)
                    {
                        var features = new[] { new GeometryFeature { Geometry = simplifiedlinestrings } };
                        _features.Add(resolution, features);
                        lastcount = count;
                        //Debug.WriteLine(linestrings.Count + " " + count + "  " + res);
                    }
                }
            }
            catch (Exception ex)
            {
                var message = HelperX.CreateExeptionMessage(ex);
                Debug.WriteLine(message);
            }
        }

        public override IEnumerable<IFeature> GetFeatures(MRect box, double resolution)
        {
            // Safeguard in case BoundingBox is null, most likely due to no features in layer
            if (box == null) { return new List<IFeature>(); }
            if (_features == null) { return new List<IFeature>(); }

            var biggerRect = box.Grow(
                    SymbolStyle.DefaultWidth * 2 * resolution,
                    SymbolStyle.DefaultHeight * 2 * resolution);

            // find feature closest to resolution
            var minresolution = _features.Keys.Min(i => (Math.Abs(resolution - i), i)).i;
            var features = _features[minresolution];
            var feature = features.Where(f => f.Extent?.Intersects(biggerRect) == true);
            return feature;
        }
}

So, the MapControl does not show any updates while it seems the rest of the app behaves correctly?
Do you see exceptions anywhere? Could you try to attach to the Mapsui logging https://mapsui.com/documentation/logging.html?

I added a simple handler to logging:
Mapsui.Logging.Logger.LogDelegate += (level, message, ex) =>
      Debug.WriteLine("Mapsui.Logging: " + level + " " + message + " " + QvX.HelperX.CreateExeptionMessage(ex));

And the output is loads of:
Mapsui.Logging: Information Time for drawing control [ms]: 916.469
Mapsui.Logging: Information Time for drawing control [ms]: 911.9809
Mapsui.Logging: Information Time for drawing control [ms]: 916.6611
Mapsui.Logging: Information Time for drawing control [ms]: 958.6009
Mapsui.Logging: Information Time for drawing control [ms]: 941.7189
Mapsui.Logging: Information Time for drawing control [ms]: 936.5741
Mapsui.Logging: Information Time for drawing control [ms]: 953.7888

GetFeatures()  just seems to be too busy with many linestrings. This was actually my question, how to make it easier. I read somewhere, that you guys are working on a GetFeaturesAsync? Or should I simplify the geometry  more? What is the most efficent way to render some amount of linestrings? Didn't try RasterLayer yet.

The problem is, that you try to redraw all the lines as much as often possible. Each time you have to get the Features, convert them to SKPath and draw them. This needs much time.
You could use your own renderer, that saves the SKPath if they are created.

Ok, thanks. I'm still trying to understand, how the workflow is in Mapsui.
Is there a sample of an own renderer? And for how long are the SKPaths valid? Until the resolution changes?

All the renderers are implemented as "own" renderers. So you could look into the source code itself.
Another possibility, that come into mind could be to cut the big LineStrings into shorter ones. If you have one big LineString, all the Points inside of it have to be converted each time. Think about a LineString of 1000 Points, from which only two are visible. So try co create a new Feature with only the visible points of the LineString. Perhaps this speeds the things up.

Look in LineStringExtension.ca in the function ToSkiaPath what each time happens, when a LineString is draw on the screen. The whole LineString is converted in screen coordinates (not sure, if it is reduced to the viewport) and then clipped to the screen. If you do this each time for 50*1000 Points, then you need some time.

Possible Workarounds would be to use the RasterizingTileLayer or the RasterizingLayer, so the Features are rendered into a Bitmap
which could be fast rendered. See the Samples how to use it.

@charlenni  Ok, thanks.
I see actually two bottle necks.
First the skpaths should be cached, in case the viewport was not changed (too  much).
And second, there seem to be no cancelling of rendering all geometries currently, when the viewport continues to change while rendering is still busy.
Like with BruTiles, which is ultra fast and very responsive.
@inforithmics rasterizing is actually no option for us, because we really want fast and nice vector rendering.
I'll play a bit with own renderer..

You could look on my vector tile renderer to see, how I did it. Is for Mapsui V3, but should work with some changes.

I assume this is not a bug but a performance issue. The question mentions 50 tracks with 1000, so I assume 50000 vertices. This could indeed be slow.
Solution:
Use RasterizingTileLayer.
Future improvements:
Convert to Skia outside of render loop. There will always be some limit however.


npm version out of date

Hello,
Thank you for this terrific work! I have installed foundation-apps from npm and notice the contents of the 'scss' folder are out of date.
The 'components/_forms.scss' file, for example, does not have the exports code added several months ago.
My preferred approach is installing the source code via npm for version tracking and combining with my own scss files, so was wondering if that folder could get synced to the latest version.
Thanks!

The current version (1.1) is the correct one, it's just been a while since we put out a patch.
We're trying to get one out in the next week or two, but the Foundation team is fairly resource-constrained right now working on Foundation for Sites 6, which is launching very soon.


Contenttype Restriction

Added the ability to restrict access based upon the content type. It can be easily specified in the config.yml.

Thank you! :+1:


Bugfix

+Problems loading images with a lot of metadata. Discovered duplicated metadata.
+Bugfix Travis with Py3.4

Hello @matteobachetti! Thanks for updating the PR.

In the file srttools/core/tests/test_calibration.py, following are the PEP8 issues :

Line 198:5: E303 too many blank lines (2)


⚠ Jenkins Plugins Artifactory has degraded performance

In 3f9b113, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2554 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 75249a6 after 12 minutes.


tutone generate calls fetch (not documented?)

Description
I am trying to generate from an existing schema.json:
$  tutone generate -c shopify/tutone.yml -p shopify -s shopify/schema.json
INFO   [2024-08-28T11:41:32-04:00] fetching schema from endpoint:
FATAL  [2024-08-28T11:41:32-04:00] unable to fetch from empty URL

There is no documentation mentioning generate runs both fetch and generate and there is no URL flag/param.
Go Version
go version go1.22.5 linux/amd64
Current behavior
tutone generate command is not behaving as documented
Expected behavior
generate go graphql code from a schema.json
Steps To Reproduce
Steps to reproduce the behavior:

Manually download your GraphQL schema into a schema.json
Run tutone help and tutone generate help to understand the flags
Run tutone generate -c shopify/tutone.yml -p shopify -s shopify/schema.json
Get an error:

INFO   [2024-08-28T11:41:32-04:00] fetching schema from endpoint:
FATAL  [2024-08-28T11:41:32-04:00] unable to fetch from empty URL

I second this. I already have a json introspection file from my tooling. All I need it to do is generate the models from it.


fix(Topology): Added test to verify if unique vertices linked to an i…

…nternal component are also linked to its embedding(s) component(s).

:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create an image with spacy en_core models

Build an image with the following models baked in:

https://huggingface.co/spacy/en_core_web_trf
https://huggingface.co/spacy/en_core_web_lg
https://huggingface.co/spacy/en_core_web_md
https://huggingface.co/spacy/en_core_web_sm

Images built and pushed: https://github.com/aishwaryaprabhat/goku/pkgs/container/mlbakery/237822329?tag=spacy_en_core


omxplayer: remove hardcoded tune and arch from Makefile

Fixes: #428
Signed-off-by: Martin Schuessler<EMAIL_ADDRESS>
- What I did
Removed the hardcoded arch and tune settings from Makefile
- How I did it
Patching the Makefile

Can one of the admins verify this patch?

@jenkins-ag ok to test

Thanks @c0ffee. Merged in master.


Amino acid transporter and transport terms

Hi,
Just a question about the L-amino acid transmembrane transporter terms and corresponding BP terms for L-amino acid transmembrane transport.
Would it be possible to flesh out the BP terms so that all L-amino acid transmembrane transporter MF terms had a corresponding entry in BP for L-amino acid transmembrane transport?
It looks like some are there in BP, but not all.
Thanks,
--Kimberly
Reported by: vanaukenk
Original Ticket: geneontology/ontology-requests/11706

@vanaukenk
Hi Kimberly,
I'm going to close this ticket. If you did create BP 'chemical_transmembrane_transport' terms and if these are still not linked to corresponding 'chemical_transmembrane_transporter' terms, please let me know (or make a new ticket). Thanks!
Paola

Hi Paola,
Thanks for checking about this ticket.
The terms I created for annotating the paper were:
id: GO:1904271
name: L-proline import across plasma membrane
id: GO:1904272
name: L-tryptophan import across plasma membrane
id: GO:1904273
name: L-alanine import across plasma membrane
Right now, I don't see the F-P links in the ontology between the L-proline transmembrane transporter activity, etc. terms and these BP terms.  Do you think they are still appropriate?
Thanks,
--Kimberly

Hi Kimberly,
Looking at L-proline,
L-proline transmembrane transporter activity is part_of proline transmembrane transport
and
L-proline import across plasma membrane is_a proline transmembrane transport
But if I create the term L-proline transmembrane transport, the latter link will be added automatically, and I can then place L-proline transmembrane transporter activity more granularly as part_of L-proline transmembrane transport.
I'll add the missing (intermediate) terms via TG and revise the part_of links...
Paola

Just added
ID: GO:1904555 Label: L-proline transmembrane transport
ID: GO:1904556 Label: L-tryptophan transmembrane transport
ID: GO:1904557 Label: L-alanine transmembrane transport
@cmungall , @hdietze ,
Could you please remind me where we are with the issue of inferencing the correct (granular) part_of link automatically? Pardon my juvenile Alzheimer, but I've lost track of that discussion... Did we resolve that we should still do it manually? (No problem if so.)
Thanks,
Paola


gnss-sdr: init at 0.0.9 (and patch armadillo's buildInputs)

Motivation for this change
This open-source implementation of a software-defined radio receiver for GPS and other GNSS signals was not yet packaged.
In order to get a usable build of gnss-sdr, I had to change armadillo's buildInputs to add liblapack; otherwise several important functions fail at runtime. Perhaps @juliendehos or @knedlsepp will want to comment on that change?
I've tested the resulting gnss-sdr binary against the sample 2013_04_04_GNSS_SIGNAL_at_CTTC_SPAIN dataset linked from http://gnss-sdr.org/my-first-fix/.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Afaik openblas should include all lapack routines, so I think we should check why armadillo depends on an extra library for that.Am 19.07.2017 9:30 nachm. schrieb Jamey Sharp notifications@github.com:Motivation for this change
This open-source implementation of a software-defined radio receiver for GPS and other GNSS signals was not yet packaged.
In order to get a usable build of gnss-sdr, I had to change armadillo's buildInputs to add liblapack; otherwise several important functions fail at runtime. Perhaps @juliendehos or @knedlsepp will want to comment on that change?
I've tested the resulting gnss-sdr binary against the sample 2013_04_04_GNSS_SIGNAL_at_CTTC_SPAIN dataset linked from http://gnss-sdr.org/my-first-fix/.
Things done
Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)Built on platform(s)
NixOS macOS Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" Tested execution of all binary files (usually in ./result/bin/) Fits CONTRIBUTING.md.
You can view, comment on, or merge this pull request online at:
  https://github.com/NixOS/nixpkgs/pull/27505
Commit Summary
armadillo: Include optional LAPACK dependency.gnss-sdr: init at 0.0.9
File Changes
A
pkgs/applications/misc/gnss-sdr/default.nix
(59)

M
pkgs/development/libraries/armadillo/default.nix
(6)

M
pkgs/top-level/all-packages.nix
(2)

Patch Links:
https://github.com/NixOS/nixpkgs/pull/27505.patchhttps://github.com/NixOS/nixpkgs/pull/27505.diff
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Afaik openblas should include all lapack routines, so I think we should check why armadillo depends on an extra library for that.

Huh. All I know so far is that the armadillo build reports "LAPACK_FOUND = NO" (for instance in http://hydra.nixos.org/build/56592131/log), and that adding liblapack to its buildInputs is all that's necessary to make it not die with error messages like "svd(): use of LAPACK must be enabled", which are reported using arma_stop_logic_error.
Any suggestions on how to investigate this?
(Also, I botched my fetchurl call, so I've pushed a revised version that should actually build this time...)

Openblas includes an optimized implementation of Lapack. Opencv (with Openblas enabled) finds it:
...
--     Use Lapack:                  YES (/nix/store/priv29ycsiagyc4f9pamblym16v4az16-openblas-0.2.19/lib/libopenblas.so)
...

It seems armadillo doesn't know about openBLAS's lapack functionality yet. I've filed an issue:
https://github.com/conradsnicta/armadillo-code/issues/30
In the meantime we could fix the armadillo build via:
  cmakeFlags = let
    libSuff = if stdenv.isDarwin then "dylib" else "so";
  in [
    "-DLAPACK_LIBRARY=${openblasCompat}/lib/libopenblas.${libSuff}"
    "-DDETECT_HDF5=ON"
  ];

I have only tested this on darwin currently. So if you could try it out on linux I'd create a PR to fix our armadillo library.

Looking at the commit history for our armadillo derivation I just realized that this should have been fixed long ago, but I accidentally reverted it: https://github.com/NixOS/nixpkgs/commits/82e760a3d613ec9e82ab48131f8b94b1119dc535/pkgs/development/libraries/armadillo/default.nix

@jameysharp @juliendehos @knedlsepp
Unfortunately it can't be guaranteed that OpenBLAS comes with LAPACK. Last time I checked, the super-wise folks at Debian build their version of OpenBLAS without LAPACK. Debian stuff then propagates to Ubuntu, and we end up with a royal mess.
Armadillo needs to support various Linux-based operating systems, so it can't assume that OpenBLAS comes with LAPACK built in.
Armadillo's cmake installer simply enables LAPACK support if LAPACK is detected.  If an untainted version of OpenBLAS is on the system, it should use LAPACK functions from OpenBLAS instead of standard LAPACK. This is due to the linker simply finding the appropriate functions in OpenBLAS first.
In other words, in addition to OpenBLAS, I suggest having a standard version of LAPACK on the system.

just using openblasCompat instead of openblas seems to solve the problem :
//testarma.cpp
#define ARMA_USE_LAPACK
#define ARMA_DONT_USE_WRAPPER
#include <armadillo>
using namespace arma;
int main() {
    mat U, V, X = randu<mat>(9, 9);
    vec s;
    svd(U,s,V,X);
    return 0;
}

#default.nix
with import <nixpkgs> {};
with pkgs; stdenv.mkDerivation {
    name = "testarma";
    src = ./.;
    buildInputs = [ armadillo openblasCompat ];  # ok
    #buildInputs = [ armadillo openblas ];       # svd(): decomposition failed
    buildPhase = "g++ -std=c++11 -o testarma testarma.cpp -larmadillo -lopenblas";
    installPhase = "mkdir -p $out/bin; cp testarma $out/bin";
 }

@juliendehos: The fix I'm proposing here in nixpkgs would mean that you could get rid of:
#define ARMA_USE_LAPACK
#define ARMA_DONT_USE_WRAPPER

and -lopenblas. If we add this fix the ARMA_USE_LAPACK would be encoded in the armadillo installation and linking with -larmadillo would transitively link the openBLAS routines.

Ok, good idea. I've tested your fix and it seems ok. Thanks.

@jameysharp: Could you rebase your PR to exclude the armadillo lapack addition, now that the fix was merged?

I've rebased and re-tested just adding gnss-sdr, dropping my patch to armadillo, and with the version of armadillo that's on master everything works great. Thank you!
I also finally turned on nixos.useSandbox, so AFAICT this test build was even sandboxed.
Got any other concerns before merging this?

You're absolutely right @knedlsepp, thanks! I've tested and pushed your suggested fixes. Do you think this is ready to merge now?

Looks good to me. 🍻

Thanks!

And thank you too, @Mic92!


local arch="x86_64"

    this doesn't work on mac, it should be `local arch="x86_64"`:

/opt/homebrew/Cellar/sbt/1.8.2/libexec/bin/sbt: line 174: local: `=': not a valid identifier

Originally posted by @fredfp in https://github.com/sbt/sbt/pull/7111#discussion_r1065780262

Maybe an idea would be to integrate https://github.com/marketplace/actions/shellcheck into ci.yml ?

Ups, sorry that was my fault :roll_eyes:

Fixed by #7134


visual genome dataset

@jwyang, I noticed you are doing experiments on visual genome dataset. May I ask how you split the dataset for training and validation as there is severe class imbalance?

they use a split method as vg_1600-400-20 in https://github.com/peteanderson80/bottom-up-attention but in this project, the code use vg_150-50-50. It seems that the model provided can not be used directly


[nix-darwin/home-manager] manual-combined.xml fails to validate

Steps To Reproduce
Steps to reproduce the behavior:
I use nix flakes to manage my local darwin config, and started getting that manual-combined.xml to validate error. After doing a bit of git bisect I tracked it to commit https://github.com/NixOS/nixpkgs/commit/6259b29f290e27b8853982bfded52d3f0653bdc2
Build anything after https://github.com/NixOS/nixpkgs/commit/6259b29f290e27b8853982bfded52d3f0653bdc2  when using both nix-darwin and home-manager to manage your local system and you will see the error.
Build anything before, such as https://github.com/NixOS/nixpkgs/commit/46e516e4434ca65e31ecb1e3df4f03c7e2fe953d and the error goes away.
NOTE: this does not appear to be an issue with either nix-darwin or home-manager
Build log
error: builder for '/nix/store/38i5bxw4h8d5ngijf9j6pbqvfin5vcz5-darwin-manual-combined.drv' failed with exit code 3;
       last 10 log lines:
       > manual-combined.xml:14: element variablelist: Relax-NG validity error : Did not expect element variablelist there
       >     10         <para>Nix modules for darwin.</para>
       >     11   </preface>
       >     12      <chapter xml:id="sec-options">
       >     13   <title>Configuration Options</title>
       >     14    <variablelist xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink" xml:id="configuration-variable-list" xml:base="generated/options-db.xml"><varlistentry><term xlink:href="#opt-_module.args" xml:id="opt-_module.args"><option>_module.args</option></term><listitem><para/><para><emphasis>Type:</emphasis> lazy attribute set of raw value</para><para><emphasis>Declared by:</emphasis></para><simplelist><member><filename xlink:href="https://github.com/LnL7/nix-darwin/blob/ef56fd8979b5f4e800c4716f62076e00600b1172/">
       >     15                <lib/modules.nix>
       >     16               </filename></member></simplelist></listitem></varlistentry><varlistentry><term xlink:href="#opt-documentation.enable" xml:id="opt-documentation.enable"><option>documentation.enable</option></term><listitem><para>Whether to install documentation of packages from
       >
       > manual-combined.xml fails to validate
       For full logs, run 'nix log /nix/store/38i5bxw4h8d5ngijf9j6pbqvfin5vcz5-darwin-manual-combined.drv'.
error: 1 dependencies of derivation '/nix/store/pxy9rw964rsmlrd5ab26iqrdhh6gz996-darwin-manpages.drv' failed to build
error: 1 dependencies of derivation '/nix/store/jccwswlfp1k8m2zmd9l7dqalcmsqclz1-darwin-manual-html.drv' failed to build
error: 1 dependencies of derivation '/nix/store/1caq3s3xdpy7zp49k8ky7x126p7g2nmq-system-applications.drv' failed to build
error: 1 dependencies of derivation '/nix/store/nf85fcnmciky8d2na8yinlcn0b0qbdc0-darwin-system-22.11.20221018.5c77b29+darwin4.ef56fd8.drv' failed to build

Additional context
I'm using nix flakes to manage my local configuration. I'm using github:NixOS/nixpkgs/nixpkgs-unstable channel in most cases. Rest of the steps are in the reproduce section
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 21.6.0, macOS 12.6`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.11.0`
 - channels(root): `"nixpkgs"`
warning: Nix search path entry '/nix/store/nfnv71kd0559a68d6vxqgcris30kdjm0-source' does not exist, ignoring
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

@roberth and @Ma27 (Notifying as requested by ticket)

Same issue here. Reverting #194035 fixes it for unstable.

Same issue here, I had to disable manual on home-manager as a workaround.
manual.manpages.enable = false; on my home-manager

I can confirm @themaxhero temp solution works.
manual.manpages.enable = false; # in home-manager
still looking for a fix so i can re-enable man

So... strictly speaking it is a hm/nix-darwin issue because these manpages don't quote their " correctly in option names (which is now necessary and the whole point of the PR in question).
I'll file a patch for rycee/nmd later that should ifx it for home-manager.

So... strictly speaking it is a hm/nix-darwin issue because these manpages don't quote their " correctly in option names (which is now necessary and the whole point of the PR in question).
I'll file a patch for rycee/nmd later that should ifx it for home-manager.

ahh, sorry about that and thank you for fixing!!

OK, home-manager upstream seems fixed, I'd wait until the nix-darwin PR is merged and then I'd close this issue.

Fixes landed in both nix-darwin and home-manager. I guess there's nothing more actionable here, so I'll close this.
If I forgot about something, please let me know!

I've weirdly started hitting something like this on my WSL home-manager running 22-x state version. It mentions some darwin XMLs and it's all very confusing. How to disable building manual-combined entirely?

Had the same issue on WSL <IP_ADDRESS> as well when updating home-manager from e7eba9cc46547ae86642ad3c6a9a4fb22c07bc26 to c43d4a3d6d9ef8ddbe2438362f5c775b4186000b

Could you provide the complete error log please?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/segmentation-faults-when-building-with-flake-on-raspberry-pi-3b/27069/5

I just downgraded from unstable to 22.11 and I have this issue when moving over the home-manager stuff. My system flake switch'd fine, and nix profile upgrade also worked fine.
I guess the fix is only for unstable?

22.11 will be EOL by the end of July iirc, so I don't think this is worth fixing. You could probably work around the issue by disabling the documentation build in your config. You'll be looking to set options like these to false.

https://daiderd.com/nix-darwin/manual/index.html#opt-documentation.enable
https://nix-community.github.io/home-manager/options.html#opt-manual.html.enable

FWIW I just upgraded, and I encountered this issue for the first time. I found this thread using Google and the workaround of disabling man pages in home-manager config works (thanks!).
My upgrade:
    'github:nix-community/home-manager/e0034971f9def16bbc32124147787bc0f09f0e59' (2023-06-14)
  → 'github:nix-community/home-manager/d2b6f2d154bf6b27a93ed895392f80c503df7cfa' (2023-06-23)

system:
 - system: `"aarch64-darwin"`
 - host os: `Darwin 22.5.0, macOS 13.4.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.15.1`
 - channels(user): `""`
 - channels(root): `""`
 - nixpkgs: `/nix/store/fqjg9y9pwh9cg2izs76kkv0wwwpsqp1v-source`

Yes, the new instance is being tracked in https://github.com/nix-community/home-manager/issues/4142


Docs micro-update

Added small updates to docs
Moved the npm global installation example down.
Added tsx and jsx extensions

Thanks!


Fidelity golden screenshot update automation is not running

Our GCP-based fidelity golden screenshot update automation is currently out of commission. Unfortunately, we haven't automated spinning up this infrastructure yet, so others won't be able to diagnose the issues for themselves without a lot of manual work.
Until this problem is addressed, we will have to manually update the fidelity test goldens using the appropriate npm scripts.

I'm okay with manual golden updates.


[traffic-gen-in-vm] Build system: remove traffic-gen pod

Following the removal of the traffic-gen pod, there is no longer a need to build it.

Remove its build and push jobs from our CI (GitHub actions).
Remove its build and push targets from our Makefile.
Remove the directory that is used to build its image.

Depends on PR #119, please review only the last three commits.

Change: Removed unused variables from the Makefile.

Change: Rebase


Remove .nvmrc and add to .gitignore

The node version specified in .nvmrc was in conflict with the one specified in package.json, as we forgot to update it.
Rather than keeping them in sync, we can remove the .nvmrc file and add it to .gitignore for any developers who want to continue to use this tool. Generally as a team we are moving towards asdf anyway.

Do we need this now we have directed asdf for all?

Possibly not. I've not switched to asdf yet, but even so, we could remove it as it'd mean only having to set the node version in one place.
Is asdf smart enough to read the node version from package.json and the ruby version from Gemfile, or does it require a .tool-versions file?

asdf has a feature legacy_version_file (http://asdf-vm.com/manage/configuration.html#legacy-version-file) which has it read from .ruby-version or .nvmrc (or whatever) if not present. But this is a migration stopgap. All things being equal I would like to drop .nvmrc altogether as it's pure duplication.
package.json is a slightly different matter because it does have to duplicate the info — FWIW I think this comment is probably fair. BUT yarn will refuse to run if the .tool-versions and package.json versions are incompatible, with an error like this:
error apply-for-teacher-training@: The engine "node" is incompatible with this module. Expected version "^16.14.0". Got "16.13.0"

So given they have to be compatible or the project won't even build, I think it's ok to have the duplication. Tho it is untidy. Removing .nvmrc would make it tidier.

@duncanjbrown yeah that error (after running nvm use) was what alerted me to the discrepancy.
I’d agree that asdf and similar tools would ideally read the language version from the native dependency files (package.json, Gemfile, requirements.txt etc) where possible.
In the meantime, let’s remove .nvmrc and maybe even add it to .gitignore?

@duncanjbrown pushed a commit to remove .nvmrc and add it to .gitignore. PR title and description updated.


cyborgs no longer have access to their headlamp

Description
Borgs no longer have a light action. Looking in the action menu shows no light as well.
Screenshots

sorry this seems to be a repost of https://github.com/space-wizards/space-station-14/issues/20446#issue-1909990480


docs: reformat documentation

What kind of change does this PR introduce?
Cleanup documentation formatting
Changes applied:

Fixing some typos
Apply 80 column limit on text lines
Remove some tabs
Remove some duplicated empty lines
Capitalise SQL keywords

I used hard line limit on 80th column as it was easiest to automate. However it may be beneficial to use something like semantic line breaks if there is will in the team.


About Teapot Sample

Can you provide a Teapot sample that we can learn below things.

How to use textures with 3D Teapot model with a use of "bitmap" and ".tga" file ?

i mean that how to bind textures with a use of .bmp  or .tga files to 3D Model via NDK code.

adding @hak

less than 2 years, got chance to address this one  with https://github.com/googlesamples/android-ndk/pull/555
Loading file from assets probably is the only one specific to Android; this one avoids the reading from disk because I like to avoid to get too much Java code into it ( Run time permission is only available from Java ).


Cleans up some unused imports, adds a null check for protocol info, c…

…hanges the error messages that are sent to the SMA to something meaningful and updates shared module.
fixes #155

All is well.


Handled differently default color and backgroundColor, if referred to one of the predefined types

Currently when statuses is set, redefining some extra values for one of the current types, then a different color and background color is set.
Now, since types contain a predefined color and background color in the constant defaultStatuses of default.ts file, in case they are not overwritten, they inherit the default values.
defaultColor and defaultBackground are used only for custom types.

Seems sensible! Thank you :pray:


S3 config format

I am trying to set this up with an S3 bucket.  I have provided my keys.  I get:
| failed to provision volume with StorageClass "csi-s3": rpc  error: code = Unknown desc = failed to initialize S3 client: Endpoint:   does not follow ip address or domain name standards.
-- | --
I have:
endpoint=s3.eu-west-2.amazonaws.com
which is clearly wrong, but what would be RIGHT?

Hi @HelenCousins , apologies that this part is not very clear in the documentation.
The endpoint you provided, should be like this:
https://s3.eu-west-2.amazonaws.com or http://s3.eu-west-2.amazonaws.com

well, now it isn't throwing errors but it is endlessly pending with no reason given.  I know I have the right credentials, as I can use them with rclone...

Hi @HelenCousins is kubectl describe dataset/<YOUR_DATASET> giving anything useful output?
Also would you mind sharing the Dataset spec without your credentials?

apiVersion: com.ie.ibm.hpsys/v1alpha1
kind: Dataset
metadata:
name: example-dataset2
spec:
local:
type: "COS"
accessKeyID: "SECRET"
secretAccessKey: "SECRET"
endpoint: "s3.eu-west-2.amazonaws.com"
bucket: "atestbuckethc7"
region;
kubectl describe datasets example-dataset2
Name:         example-dataset2
Namespace:    default
Labels:
Annotations:
API Version:  com.ie.ibm.hpsys/v1alpha1
Kind:         Dataset
Metadata:
Creation Timestamp:  2021-03-19T14:34:47Z
Generation:          6
Managed Fields:
API Version:  com.ie.ibm.hpsys/v1alpha1
Fields Type:  FieldsV1
fieldsV1:
f:status:
.:
f:caching:
.:
f:info:
f:status:
f:provision:
.:
f:status:
Manager:      dataset-operator
Operation:    Update
Time:         2021-03-19T14:34:52Z
API Version:  com.ie.ibm.hpsys/v1alpha1
Fields Type:  FieldsV1
fieldsV1:
f:metadata:
f:annotations:
.:
f:kubectl.kubernetes.io/last-applied-configuration:
f:spec:
.:
f:local:
.:
f:accessKeyID:
f:bucket:
f:endpoint:
f:region:
f:secretAccessKey:
f:type:
Manager:         kubectl-client-side-apply
Operation:       Update
Time:            2021-03-19T15:13:30Z
Resource Version:  9020433
Self Link:         /apis/com.ie.ibm.hpsys/v1alpha1/namespaces/default/datasets/example-dataset2
UID:               07cb2b92-dadc-453f-bb1c-900792ec150a
Spec:
Local:
Access Key ID:      SECRET
Bucket:             atestbuckethc7
Endpoint:           http://s3.eu-west-2.amazonaws.com
Region:             eu-west-2
Secret Access Key:  SECRET
Type:               COS
Status:
Caching:
Info:    No DLF caching plugins are installed
Status:  Disabled
Provision:
Status:  Pending
Events:

Thanks @HelenCousins can you try instead the following:
apiVersion: com.ie.ibm.hpsys/v1alpha1
kind: Dataset
metadata:
  name: example-dataset2
spec:
  local:
    type: "COS"
    accessKeyID: "XXXXXXXXXXXXXXX"
    secretAccessKey: "XXXXXXXXXXX"
    endpoint: "https://s3.amazonaws.com"
    bucket: "atestbuckethc7"
    region: "eu-west-2"

Also, does is atestbuckethc7 an existing bucket?

it is a bucket, it contains junk, but ... existing junk

Haha okay! can you try the spec I suggested above? basically I think you need to use endpoint=https://s3.amazonaws.com and region=eu-west-2

Okay :( can you paste the output of this command: kubectl get pods -n dlf ?

NAME                                READY   STATUS    RESTARTS   AGE
csi-attacher-nfsplugin-0            2/2     Running   0          6d4h
csi-attacher-s3-0                   1/1     Running   0          6d4h
csi-nodeplugin-nfsplugin-h8h2h      2/2     Running   0          6d4h
csi-nodeplugin-nfsplugin-tc26l      2/2     Running   0          6d4h
csi-provisioner-s3-0                1/1     Running   0          6d4h
csi-s3-jgpvw                        2/2     Running   0          6d4h
csi-s3-ktjb2                        2/2     Running   0          6d4h
dataset-operator-797d8c88f4-vvrlj   1/1     Running   0          6d4h

Ok!
I0325 15:58:33.966529       1 utils.go:98] GRPC request: {"capacity_range":{"required_bytes":5368709120},"name":"pvc-4455b38c-b97b-4839-b025-66e091de759c","parameters":{"mounter":"goofys"},"secrets":"stripped","volume_capabilities":[{"AccessType":{"Mount":{}},"access_mode":{"mode":5}}]}
I0325 15:58:33.968280       1 controllerserver.go:67] Got a request to create volume pvc-4455b38c-b97b-4839-b025-66e091de759c
E0325 15:58:33.968329       1 utils.go:101] GRPC error: failed to initialize S3 client: Endpoint:  does not follow ip address or domain name standards.
I0325 16:03:33.973106       1 utils.go:97] GRPC call: /csi.v1.Controller/CreateVolume
I0325 16:03:33.973166       1 utils.go:98] GRPC request: {"capacity_range":{"required_bytes":5368709120},"name":"pvc-4455b38c-b97b-4839-b025-66e091de759c","parameters":{"mounter":"goofys"},"secrets":"stripped","volume_capabilities":[{"AccessType":{"Mount":{}},"access_mode":{"mode":5}}]}
I0325 16:03:33.975720       1 controllerserver.go:67] Got a request to create volume pvc-4455b38c-b97b-4839-b025-66e091de759c
E0325 16:03:33.975768       1 utils.go:101] GRPC error: failed to initialize S3 client: Endpoint:  does not follow ip address or domain name standards.

Can you confirm one more thing? Did you edit the endpoint field of the existing Dataset or you deleted and created a new one?

I edited it.

Ah okay, its not supported yet (apologies that is not stated anywhere in the documentation)
Is it possible to try deleting and recreating the Dataset?

oh, yes, I will try that

oh wow, I have a pvc! thank you so much! (er, now to test it has my objects in it)

oh great, I made a pod with ubuntu and told it to mount my pvc...
MountVolume.SetUp failed for volume "pvc-53d7eb9b-2701-4220-865b-f4e8955d1978" : rpc error: code = Unknown desc = Error fuseMount command: goofys args: [--endpoint=https://s3.amazonaws.com --profile=pvc-53d7eb9b-2701-4220-865b-f4e8955d1978 --type-cache-ttl 1s --stat-cache-ttl 1s --dir-mode 0777 --file-mode 0777 --http-timeout 5m -o allow_other --region eu-west-2 atestbuckethc7 /var/lib/kubelet/pods/f17dcc61-55eb-4829-8b7a-b250985d7541/volumes/kubernetes.io~csi/pvc-53d7eb9b-2701-4220-865b-f4e8955d1978/mount] output: 2021/03/26 16:01:25.259621 main.FATAL Unable to mount file system, see syslog for details

I hadn't.  Now I have, it worked

Would it be possible to share the command you used? without the credentials file.

s3fs atestbuckethc7 folder -o passwd_file=${HOME}/.passwd-s3fs
(my objects are in 'folder' now; the credentials are the same as the json file for the dataset)

it should be an entirely public bucket btw, it contains a picture.

Hi @HelenCousins I figured out the correct format. Can I ask that you delete and create a new dataset (one final time!) using that spec:
apiVersion: com.ie.ibm.hpsys/v1alpha1
kind: Dataset
metadata:
  name: mybucket-yiannis
spec:
  local:
    type: "COS"
    accessKeyID: "XXXXXXXXXX"
    secretAccessKey: "XXXXXXXXXXXXXXXXx"
    endpoint: "http://s3.eu-west-2.amazonaws.com"
    bucket: "atestbuckethc7"

Notice that I removed the region section and the change that I made in the endpoint.
Also make sure that you first delete the pod that tried to mount the old dataset.
Please let me know if this works.

Hi @HelenCousins is it working as expected?

appologies I had a vacation (in my lounge...) yes, it does now work, wow, this is very clever, and I can put my bucket contents into a daft web page.  thank you.

Great news! Thanks for your feedback!


Do not report conditional elvis continue statements - Closes#2388

Codecov Report

Merging #2389 into master will decrease coverage by <.01%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #2389      +/-   ##
============================================
- Coverage     82.82%   82.82%   -0.01%
- Complexity     2138     2142       +4
============================================
  Files           352      352
  Lines          6080     6083       +3
  Branches       1109     1111       +2
============================================
+ Hits           5036     5038       +2
  Misses          475      475
- Partials        569      570       +1

Impacted Files
Coverage Δ
Complexity Δ

...ekt/rules/bugs/UnconditionalJumpStatementInLoop.kt
83.33% <71.42%> (-5.56%)
15 <11> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a83d3...49c49bc. Read the comment docs.


flaky TestTransportFaultySyscallConn

--- FAIL: TestTransportFaultySyscallConn (0.00s)
    transport_test.go:412:
        	Error Trace:	/Users/runner/work/quic-go/quic-go/transport_test.go:412
        	Error:      	Should be empty, but was map[udp <IP_ADDRESS>:4321:<nil>]
        	Test:       	TestTransportFaultySyscallConn
FAIL

Might be the same as #4806.


Vault instances with large number of leases are unable to start

Describe the bug:
On a vault cluster with a large number of leases, the vault pods enter CrashLoopBackoff state due to the liveness probe failing during startup. Likely this could be fixed by adding a startup probe to the container to grant it additional time on first startup before the liveness probe takes over.
Expected behaviour:
Vault should be allowed a reasonable amount of time to fully start before the liveness probe can kill it.
Steps to reproduce the bug:
Populate a vault cluster with a large amount of leases, on our cluster we saw this at around 40-50k leases.
Restart a vault container
Environment details:

Kubernetes version (e.g. v1.10.2): 1.24.9
Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE etc): GKE
bank-vaults version (e.g. 0.4.17): 1.13.1
Install method (e.g. helm or static manifests): Helm
Logs from the misbehaving component (and any other relevant logs):

Liveness probe failed: Get "https://<ip redacted>:8200/v1/sys/init": dial tcp <ip redacted>:8200: connect: connection refused
Back-off restarting failed container

/kind bug

Did you find a workaround?


feat: tradingview logging level configuration

Description

This will allow to configure the logging level of the tradingview container by passing an environment variable "TRADINGVIEW_LOG_LEVEL". the accepted values for log level can be viewed here: https://docs.python.org/3/howto/logging.html#logging-levels
Related Issue
#435

Motivation and Context
To be able to configure the logging level of tradingview

How Has This Been Tested?
Tested in my local machine

Screenshots (if appropriate):

Thanks @azorpax
It looks good. I've also tested on my end.
I will merge and release.

Released! https://github.com/chrisleekr/binance-trading-bot/releases/tag/v0.0.88

Good job @azorpax


Python support for rds-tools

Would be great if we can have pypi package published for it to make it use inside python based CDK projects.

@mbonig Can we have efforts on it please ?


[C++][Parquet] Add encrypted parquet files to apache parquet-testing repository

Add encrypted parquet files to apache parquet-testing repository (https://github.com/apache/parquet-testing) for the purpose of testing.
Reporter: Revital Sur / @revit13
Assignee: Revital Sur](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=eres) / @revit13
PRs and other links:

GitHub Pull Request #7

Note: This issue was originally created as PARQUET-1621. Please see the migration documentation for further details.

Revital Sur / @revit13:
Pull request: https://github.com/apache/parquet-testing/pull/7

Micah Kornfield / @emkornfield:
It looks like the PR is merged, can should this be closed?


App crashes when opening manga details page

Steps to reproduce
1- On any page from the app, be it recents, library or search page search for "Mushoku Tensei Isekai Ittara Honki Dasu"
2- Open the page for the above mentioned manga
3- The app crashes
Expected behavior
The app shouldn't crash
Actual behavior
The app crashes
Crash logs
neko_crash_logs.txt
Neko version
App version: 2.16.3
Android version
Android version: 13 (SDK 33)
Device
Samsung Galaxy S20 FE (SM-G780F)
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

Can you try now?  I think there was bad data on mangadex because this works fine for me

It doesn't crash when I open the page now but the chapter list is empty. Info about the manga is there like the title, description, tags and alt titles.

you could have just swipe refreshed the manga detail page.

It also crashed when I swipe refreshed


Docs: Top Codepen link should include a template definition

Summary
The existing Codepen link is an empty template, but having an example definition could be a greater starting point (rather than a completely empty page).
Not sure if we should include other parts of the API here, most likely we could just focus on just including a basic component, like the following:
<script src="https://unpkg.com/tram-lite@4"></script>

<template tl-definition>
  <x-button>
    <button>
      Click Me!
    </button>
  </x-button>
</template>

<x-button></x-button>

This has been added 👍
If there are any suggestions or feedback, feel free to make a thread in the Tram-One discord!


Move elements

This is a PR to move all elements of the dashboard at the same time :)

After some test this work on desktop but not on phone

I was thinking that this feature should be more useful if it is possible to select elements. So for example  manually select elements and then use this feature to only move them.
I write this down in my TODOs and close for now.
Thanks!!

I actually was planning to use it to move the whole dashboard. For example, when elements are outside the visible screen because the flowchart is large


Release notes migration

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[X ] Tested Locally
[ ] Optional Screen Shoot.

Thanks for making the changes! @wei-harness can validate the RSS. In the docusarus.config.js, will need to update the Release Notes dropdown to match the new URLs. Cheers!

Thanks for making the changes! @wei-harness can validate the RSS. In the docusarus.config.js, will need to update the Release Notes dropdown to match the new URLs. Cheers!

I updated the docusaurus.config.js file. It should be good now.

Preview environment: https://ci.pr.harness.io/pr-222

Preview environment: https://ci.pr.harness.io/pr-222

Preview environment: https://ci.pr.harness.io/pr-222


Add search to UI. - [closed]

In GitLab by @wknet123 on Sep 13, 2017, 06:02
Merges dev-search-ui-component -> dev

In GitLab by @wknet123 on Nov 13, 2019, 09:58
closed


Uses PHP 5.4 array syntax on line 411 of Minify.php, but docs specify compatibility with php 5.3+

Not sure if this is an oversight in the docs. Can be easily fixed by editing that line.

Want to send a pull request? As we bring in more dependencies it's going to be harder to stick to 5.3.

I figured it might just be that the docs weren't updated yet. I've created a pull request.

Fixed via #485


Update Spring Boot dependency

FREME uses a quiet old version of Spring Boot. @davidwabnitz asked for an update to the latest version for better compatibility with his technology stack.
This involves

Update the dependency in freme-parent
Run all tests
Manually test FREME

I updated first to Spring Boot 1.5.3, then to Spring Boot 1.4.6. Both updates required some small code changes in FREME Common. Further the unit tests of basic services / internationalization failed. Some API calls "get stuck" somewhere deep in the Spring framework after the FREME codes was executed. I could not find out what is the problem and therefore estimate a major effort for this upgrade. Therefore I leave this task for later.

i finished the upgrade and create a new freme release


[feature request]: The test app should be more clearly named

Contact Details
No response
Is your feature request related to a problem? Please describe.
The test app should be more clearly named
Describe the solution you'd like
The test app should be more clearly named
Describe alternatives you've considered
No response
Additional context
No response
Priority Level
Medium
Code of Conduct

[x] I agree to follow this project's Code of Conduct

@jwdonahue I was thinking remove application test to unit test and give then make clearly named. What do you think?

I fully agree, this is what now is made on #87

I think all of that functionality could be moved into separate unit tests and the entire project deleted.

See #97 [feature request]: Add an Examples folder to the project hierarchy.

The current CryptoNet.Cli project contains a mix of good example code and a program that reads like a list of unit tests. We should fix that.
Are you okay with me dropping some examples into an Example folder and adding unit tests for each of them?

@jwdonahue  go a head it is all fine with me,

Okay.
I should have that built by EOD (UTC-8), tomorrow morning at the latest.

This is still a WIP.
Draft PR: https://github.com/maythamfahmi/CryptoNet/pull/103/files
I have not removed CryptoNet.Cli yet. I still need to evaluate the coverage situation.

I like the new folder structure.


add misssing eventsub export for EventSubUserAuthorizationGrantEvent

Type: Bugfix
Fixes: -
Add export for EventSubUserAuthorizationGrantEvent. I didn't create an issue for such a small fix. Hope there is no problem.

Already done in bd2a74cc.


Fix 'Navigation Process' monitor initialization

Fixes this issue:

by setting the initial value to 0
CC @smix8

Thanks!


Update build-expiration.md

Added clean installation of Windows 11 and typo

@bleblancMSFT Please merge this PR. Thanks

Any news here @bleblancMSFT? 😊


Is the framework still actively being developed?

Besides the occasional patches, I have hardly seen any major activity on the framework for the past couple of years. Should one consider it obsolete?

@preslavrachev active development has died down, though we still have items on the roadmap we'd like to do to make Revel more future proof. Eg @notzippy did a lot of refactoring to abstract the HTTP server engine and template engine with other similar refactors on the backlog.
The big reason for the inactivity is a lack of volunteers. I took this project over in 2013 from the original author (Rob F) and actively used it and developed it. Most of my effort turned into recruiting and managing core volunteers as well as community patches and feedback.
Is it obsolete? No. I believe Revel has a real value to developers of web apps, specific Ruby on Rails like MVC apps. However, we've always had critics that Revel was going against the grain re:golang semantics. I've argued this with critics in the past.
I'd like to resume my effort on what originally attracted me to Revel: a performant and relatively simple language with a polished and familiar web framework. I'd like to keep enhancing features and performance on benchmarks to continue to attract developers as users and developers.
All that said, I have other priorities such as work and family, so my time is quite limited. This is why volunteer effort is so critical. I'm not fully confident we can secure volunteers given there are now MANY web framework options like Gin, Echo, Beego (IMO a Revel clone), etc. Not to mention node.js, PHP, etc, etc other platform options.
I'm open to feedback and advice!

@brendensoares Yeah, I know exactly what you mean. I have been actively looking for the Rails/Django-like experience in Go for quite some time myself. Talking to clients of mine that I help bootstrap projects, I think that there is an opportunity left on the table. And no one wants to claim it. I think that a similar fate is following @markbates' Buffalo. It is still being actively developed, but it looks like the initial excitement has died down a little.
I just wanted to say the following: Not everyone wants to use Go for hyper-focused microservices. I am a perfect example of that, and so are the people and teams I work with. Most of them will pick either Rails, Django, or Laravel not because of their backing languages, but because there is an active ecosystem behind any of them. It's reassuring to know that the framework you picked has a vibrant community of helpers, and will be around for the next few years.
I have not seen that same momentum in the Go community. Most people will argue that this is because "Go does not need frameworks", or "frameworks lead to un-idiomatic Go", or "Rails style frameworks are obsolete", or other sorts of ungrounded nonsense. Go is general-purpose enough, and if a feature was added to it, it means it can be used to solve problems in any way, regardless of whether some people find it idiomatic or not. I suppose, the same was for Ruby before Rails - few people could say whether what DHH made was idiomatic or not. Did it solve a problem? Hell, yeah. Was it the best, most well-engineered piece of code out there - probably not.
All this is to say that we should work towards educating people that there are other kinds of problems that Go could solve, outside single-function lambdas, or a 100-LoC microservice. I think that this is what is missing in the Go community in general - good education outside of the scope of writing Go code. This is something you see very strongly among Rails, Django, Laravel folks - the entrepreneurial spirit, which drives curiosity, and lets them explore the boundaries of the tech, in the name of solving real human problems.
It's time to end my rant here. I think the only way to drive volunteer effort up is to show a real business need. If Revel, Buffalo, or whichever other Rails-like framework Go wants to grab the lion share, it needs to solve the non-tech problem first.

100% agreed that the focus of software should be on solving problems and NOT art for art's sake.
People in general easily get lost in stereotypes and quickly forget that life is not black in white 99.9% of the time. Purists are lost wanderers.
As a professional software engineer, we need to consider the needs/goals of each project and select the right tools for the job. Microservices/SOA have their own strengths and weaknesses and don't always benefit a product. Not all products want to manage the scale and complexity of distributes services.
That all said to emphasize that I agree, there is a niche to fill outside of whatever trend is popular in the moment.
I'd like to promote having a clear domain layer in web apps. Doing so allows the app layer to evolved eg from monolithic MVC to whatever is beneficial next (such as SOA). So there is more to explore there for Revel, too; moving fast early on while building a modular base for the future.
Thanks for sharing your perspective. If you'd like to join the core Revel team to shape the project's future, let me know ;)

I think I'd like [this guy][(https://www.youtube.com/watch?v=75NjCfLLftw) if I met him in person lol.
"use the standard library...RTFM" lol

Absolutely! It's just sad that there are so few of us that think that way. You can use pure Go from scratch, and use a kitchen-sink framework when you need to. I don't see why the majority think it should be an either-or-situation.


ActionController::Responder (NameError) - Rails 4.2 (4.1 OK)

Hi @apotonick,
Huge fan of your work!
Running into issues with Rails 4.2.  I haven't had time to investigate, but passing this on in the mean time...
No issues with Rails 4.1 app, but errors on a brand new app with Rails 4.2.
Run into this with a "rails c":
/Users/user/.rvm/gems/ruby-2.1.1/gems/roar-rails-0.1.6/lib/roar/rails/rails4_0_strategy.rb:2:in <module:Rails>': uninitialized constant ActionController::Responder (NameError) 	from /Users/user/.rvm/gems/ruby-2.1.1/gems/roar-rails-0.1.6/lib/roar/rails/rails4_0_strategy.rb:1:in <top (required)>'
from /Users/user/.rvm/gems/ruby-2.1.1/gems/roar-rails-0.1.6/lib/roar-rails.rb:34:in require' 	from /Users/user/.rvm/gems/ruby-2.1.1/gems/roar-rails-0.1.6/lib/roar-rails.rb:34:in module:Rails'
from /Users/user/.rvm/gems/ruby-2.1.1/gems/roar-rails-0.1.6/lib/roar-rails.rb:21:in <module:Roar>' 	from /Users/user/.rvm/gems/ruby-2.1.1/gems/roar-rails-0.1.6/lib/roar-rails.rb:20:in <top (required)>'
from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler/runtime.rb:76:in require' 	from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler/runtime.rb:76:in block (2 levels) in require'
from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler/runtime.rb:72:in each' 	from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler/runtime.rb:72:in block in require'
from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler/runtime.rb:61:in each' 	from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler/runtime.rb:61:in require'
from /Users/user/.rvm/gems/ruby-2.1.1@global/gems/bundler-1.6.1/lib/bundler.rb:132:in require' 	from /development/test_app/config/application.rb:7:in <top (required)>'
from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application.rb:82:in require' 	from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application.rb:82:in preload'
from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application.rb:143:in serve' 	from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application.rb:131:in block in run'
from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application.rb:125:in loop' 	from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application.rb:125:in run'
from /Users/user/.rvm/gems/ruby-2.1.1/gems/spring-1.3.2/lib/spring/application/boot.rb:18:in <top (required)>' 	from /Users/user/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in require'
from /Users/user/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in require' 	from -e:1:in '

You need to add the responders gem to your Gemfile.

Fantastic.  Many thanks!

My pleasure!! :stuck_out_tongue_winking_eye:


Add Enum.[] convenience constructor

Resolves #12892
Related to https://github.com/crystal-lang/crystal/issues/12884
Also deprecates Enum.flags which is replaced by Enum.[].

What's the point of doing this with a non-flags enum? Maybe the old method should have raised a compile error in that case. And now I'm thinking flags is a better name than brackets.

I'm worried about the amount of deprecation messages that we will throw in the face of the entire Crystal ecosystem's devs. I wonder if we shouldn't allow ourselves to have two ways of doing it for a while, mention in the docs that .flags is deprecated, and wait for a while until doing the actual deprecation.

What's wrong with keeping the name flags?

Sure, let's keep Enum.flags for now.
@asterite It's effectively an alias for Enum.[] now, which is preferable for its conciseness.


A failed match returns Any, but Regexes says Nil

Probably related to #1134. In the Regexes, the last line before the "Wildcards and character classes" heading says:

Match results are stored in the $/ variable and are also returned from the match. The result is of type Match if the match was successful; otherwise it is Nil.

The actual result is Any:
my $result = 'abcdef' ~~ / de /;
say "Result is { $result.^name }";

my $result2 = 'abcdef' ~~ / dex /;
say "Result2 is { $result2.^name }";

Output:
Result is Match
Result2 is Any

See #1134. It does return Nil, but sorted in $result you end up with the variable type.


Cell resize activation on cell :hover

Currently, cell resizing is started and ended with the "resize" entry in the cell context dialog. This works, but the workflow is inconvenient.
The idea is to exploit the mouse hovering over the cell to trigger resizer visibility. On the other hand, the resizer must be accessible from touchscreen devices.

Implemented in spreadsheet-interactive.js in mouse down and up event handlers.
Needs additional tweaks for touchscreens, where cell resizing works, but not yet perfectly.


Unclear how to add this on a existing deployed cluster

Hi,
You are encouraged to add this property into the ARM, but in my case, I already have a deployed cluster. What would be the right way to proceed in this case? It would be great to explain this in the document.
Kind Regards,
José.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f98acbcd-3d9a-cc4e-390a-c2f1886d30bb
Version Independent ID: 687b9b92-f23b-3ff6-2c24-2423d88af6c8
Content: Profile live Azure Service Fabric apps with Application Insights - Azure Monitor
Content Source: articles/azure-monitor/app/profiler-servicefabric.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @cweining
Microsoft Alias: cweining

@jfalameda , Thanks for brining this to our attention. We will investigate it further and update you shortly.


Replacing images

/replaceimg ip doesn't work

📷 Please send the image you want to replace others with:
*.jpg
lanGhost, [01.03.18 15:04]
Starting attack with ID: 1
lanGhost, [01.03.18 15:04]
Type /stop 1 to stop the attack.
lanGhost, [01.03.18 15:04]
🔥 Replacing images for 172.28.ip.212...
lanGhost, [01.03.18 15:04]
🔥 Attacks running:
ID: 1 ➖ replaceimg ➖ 172.28.ip.212

Terminal:
[+] Routing 172.28.ip.212 into mitmdump with iptables...
[+] ARP Spoofing 172.28.ip.212...
Bot says, that everything works fine. But actually nothing happens, during the attack.
tested on http sites, like bbc.com

Hi, ARP spoofing can sometimes work problematically depending on your network setup. As I said for other people, I unfortunately can't debug that remotely.
As for the actualy image replacing, bbc.com uses https for images, only the basic site is in HTTP. I tried testing that before and had this same problem. Try it on some image which you are sure is HTTP.


401 Permissions Error upon trying to configure google drive

I am unable to finishing configuring the latest build of google drive over HTTP and AWS. I keep getting a permissions error.
I have checked with Liz Segura on her instance, and it is working fine. However it does not work for me, and I am trying to figure out why.
We have narrowed down the issue to it being related to the app not recognizing my sys_admin credentials despite confirming that I am a system admin. See screenshot below for error.

@Flinch Can you still reproduce this issue?

Resolved.


Minor language tweak

No issue number, just a very small suggested word change.

Thank you for the fix, @michaelrp! Your change will go live later today.