Fix tear down of envoy on exit

Defered funcs won't be called when os.Exit() is invoked in the
same method.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @holgero. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@holgero: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
dcac8c8f634f4685a9a3b2516bc761fce5d63931
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
dcac8c8f634f4685a9a3b2516bc761fce5d63931
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
dcac8c8f634f4685a9a3b2516bc761fce5d63931
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
dcac8c8f634f4685a9a3b2516bc761fce5d63931
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
dcac8c8f634f4685a9a3b2516bc761fce5d63931
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
dcac8c8f634f4685a9a3b2516bc761fce5d63931
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andraxylia
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [andraxylia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

good find!

/retest

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
822834fd8c6d88aab989ebea617f08210702f917
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@holgero: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
51b7c88194fd94a3d335c1f50db378cc7ef554bb
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm TestMain will run all tests, the change is correct

@costinm I second what @andraxylia said. This should 'just' fix a hanging process and lead to exactly the behaviour that you describe.

/retest

@costinm : The envoy is only used in xds_test.go, namely in TestEnvoy. No other test in the package calls startEnvoy, they only call initLocalPilotTestEnv.  Also it looks to me as if the tests done with this envoy instance are done in subtests of TestEnvoy only and called there explicitly.
To preserve the original intention, we can also do the change like this:
func TestMain(m *testing.M) {
	result := m.Run()
	// tear down cannot be done in a deferred function, because we call os.Exit() at the end
	testEnv.TearDown()
	os.Exit(result)
}

Would this be preferred?


Each slide using wrong link

I am finding that the links of my slides are in the wrong order. For some reason Slide 1 uses links from Slide 2 etc. When looking at the HTML generate all looks fine. Here is a test page showing this result:
This is my Slider code

<link href="/js/slippry/slippry.css" rel="stylesheet">

The links should actually link to other pages, there is no real link to a slide


Fix darwin build and bumup nixpkgs

I'm going to fix the PR of https://github.com/tweag/jupyterWith/pull/173 problem.

@guaraqe  ready to review.

@teto Do you confirm this corresponds to what you expected from the PR?

thanks a lot for looking into it ! super appreciated.
If I do nix build .\#jupyterEnvironment --out-link result
jupyterWith on  use-ihaskell-flake
➜ nix build .\#jupyterEnvironment --out-link result
jupyterWith on  use-ihaskell-flake
➜ result/bin/jupyter-lab
[I 2021-12-13 10:55:02.409 ServerApp] jupyterlab | extension was successfully linked.
[I 2021-12-13 10:55:02.428 LabApp] JupyterLab extension loaded from /nix/store/kdbj6hkdn8sc8agmd0jpwwf4byjwnb13-python3.9-jupyterlab-3.2.3/lib/python3.9/site-packages/jupyterlab
[I 2021-12-13 10:55:02.428 LabApp] JupyterLab application directory is /home/teto/jupyterWith/.jupyterlab
[E 2021-12-13 10:55:02.429 LabApp] JupyterLab application assets not found in "/home/teto/jupyterWith/.jupyterlab"
[E 2021-12-13 10:55:02.429 LabApp] Please run `jupyter lab build` or use a different app directory
[I 2021-12-13 10:55:02.431 ServerApp] jupyterlab | extension was successfully loaded.
[I 2021-12-13 10:55:02.431 ServerApp] Serving notebooks from local directory: /home/teto/jupyterWith
[I 2021-12-13 10:55:02.431 ServerApp] Jupyter Server 1.11.2 is running at:
[I 2021-12-13 10:55:02.431 ServerApp] http://localhost:8888/lab?token=c6622280e0d5329b37bc7251e7d609f8bbce904036b611a5
[I 2021-12-13 10:55:02.431 ServerApp]  or http://<IP_ADDRESS>:8888/lab?token=c6622280e0d5329b37bc7251e7d609f8bbce904036b611a5
[I 2021-12-13 10:55:02.431 ServerApp] Use Control-C to stop this server and shut down all kernels (twice to skip confirmation).
[C 2021-12-13 10:55:02.516 ServerApp]

    To access the server, open this file in a browser:
        file:///home/teto/.local/share/jupyter/runtime/jpserver-408549-open.html
    Or copy and paste one of these URLs:
        http://localhost:8888/lab?token=c6622280e0d5329b37bc7251e7d609f8bbce904036b611a5
     or http://<IP_ADDRESS>:8888/lab?token=c6622280e0d5329b37bc7251e7d609f8bbce904036b611a5

and the webpage content is
JupyterLab Error
JupyterLab application assets not found in "/home/teto/jupyterWith/.jupyterlab"
Please run `jupyter lab build` or use a different app directory

so I think either we miss a flag or we should remove a flag from the ihaskell flake. We should fix this before merge other than that it's good. We can refine later (use same python in ihaskell and jupyterWith for instance, add ihaskell cache to jupyterWith flake etc) but it will be easier once this gets in.

so I think either we miss a flag or we should remove a flag from the ihaskell flake. We should fix this

first, you can remote the local flag and build the jupterlab directory in nix store with the impure of nix-shell. or give the local directory a shellhook to run the jupyter lab build automatically.

@teto This means we can close the other PR, right?

@guaraqe yes but apparently it was closed automatically. Thanks for merging this. I have a custom ihaskell I wanted to try with jupyterWith and this makes it so much easier !


Vertical margin: leads to wrong height of items

Describe the bug
If vertical margin is set (e.g. margin={[0, 10]}) - the height of an items calculated wrong (items are bigger than expected).
There is no such issue with horizontal margin.
Your Example Website or App
https://codesandbox.io/s/agitated-nova-6qg68h
Steps to Reproduce the Bug or Issue
See example app above: expected item size is marked as red square, but real item size is bigger (gray area below each red square)
Expected behavior
Item height should match height from config multiplied by row height.
react-grid-layout library version
1.3.4
Operating System Version
any
Browser
Chrome
Additional context
No response
Screenshots or Videos
No response

That's not an issue, but I also "encountered" it in my project and wanted to find fix for this :)
it is intended as written in docs https://github.com/react-grid-layout/react-grid-layout#grid-item-heights-and-widths
You can check basic example to easily reproduce it where margin is 10px, rowHeight 30px and every element has different height based on rows it takes
1 row -> 30px
2 rows -> 70px (230px + 110px margin)
3 rows -> 110px (330px + 220px margin)


:recycle: refactor: enable custom page extensions

Motivation
Colocation, i.e. placing code as close to where it's used as possible, is often a good way to keep projects from growing unwieldy, e.g. by not having to maintain components that are not used anywhere, but it's hard to tell because they're in a top level directory. I recommend this short article for more information
This is also the approach that NextJS will favor in the future, see Layouts RFC. It is possible to accomplish this today by using custom page extensions.
Changes

Add pageExtensions to next.config.js to allow file colocation within pages, i.e. not every file in pages has to be a page.
Rename every file in pages from <pagename>.tsx to <pagename>.page.tsx
Move NextPageWithLayout to lib/next

NextJS 13 beat me to it


chore: Update registry.access.redhat.com/ubi9/s2i-base Docker digest to 16c04ac

This PR contains the following updates:

Package
Type
Update
Change

registry.access.redhat.com/ubi9/s2i-base
final
digest
ba798a9 -> 16c04ac

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Issue after upgrading to Flutter 3.8.0-10.1.pre

Platform:

[ ]  Dart
[x]  Flutter Android or iOS
[ ]  Flutter Web

IDE:

[x]  VSCode
[ ]  IntelliJ/AS
[ ]  XCode
[ ]  Other, which one?

split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):

[ ]  Enabled
[x]  Disabled

Platform installed with:

[x] pub.dev
[ ] GitHub

Output of the command flutter doctor -v below:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 3.8.0-10.1.pre, on macOS 13.2 22D49 darwin-x64, locale en-US)
    • Flutter version 3.8.0-10.1.pre on channel beta at ..../flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1a0a03a41d (6 days ago), 2023-02-16 22:03:58 -0600
    • Engine revision 639e313f99
    • Dart version 3.0.0 (build 3.0.0-218.1.beta)
    • DevTools version 2.21.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at ..../Library/Android/sdk
    • Platform android-33, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554                        • android-x64    • Android 12 (API 31) (emulator)
    • iPhone 14 (mobile)           • 169C1954-61A6-4793-BDD6-FE384F8AF1EB • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)              • macos                                • darwin-x64     • macOS 13.2 22D49 darwin-x64
    • Chrome (web)                 • chrome                               • web-javascript • Google Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

The version of the SDK (See pubspec.lock):
sdks:
  dart: ">=3.0.0-134.0.dev <4.0.0"
  flutter: ">=3.3.9"

I have the following issue:
I am on beta channel of flutter, and after the most recent upgrade, I can't build on iOS and Android.
The main issue seems to be that 'SentryAssetBundle' is missing implementations for sentry_asset_bundle.dart:37
console logs below:
iOS:
Launching lib/main.dart on iPhone in debug mode...
main.dart:1
Automatically signing iOS for device deployment using specified development team in Xcode project: ...
Xcode build done.                                           108.7s
Failed to build iOS app
Could not build the precompiled application for the device.
Error (Xcode): ../../../.pub-cache/hosted/pub.dev/sentry_flutter-6.20.1/lib/src/sentry_asset_bundle.dart:37:7: Error: The non-abstract class 'SentryAssetBundle' is missing implementations for these members:
sentry_asset_bundle.dart:37

Error launching application on Jae-Min’s iPhone.
Exited

Android:
Launching lib/main.dart on Pixel 7 in debug mode...
main.dart:1
: Error: The non-abstract class 'SentryAssetBundle' is missing implementations for these members:
sentry_asset_bundle.dart:37
 - AssetBundle.loadStructuredBinaryData
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class SentryAssetBundle implements AssetBundle {
      ^^^^^^^^^^^^^^^^^
: Context: 'AssetBundle.loadStructuredBinaryData' is defined here.
asset_bundle.dart:110
  Future<T> loadStructuredBinaryData<T>(String key, FutureOr<T> Function(ByteData data) parser) async {

            ^^^^^^^^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception
2

FAILURE: Build failed with an exception.

* Where:
Script '..../flutter/packages/flutter_tools/gradle/flutter.gradle' line: 1154

* What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.
> Process 'command '..../flutter/bin/flutter'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 30s
Exception: Gradle task assembleDebug failed with exit code 1
Exited

This will be fixed by https://github.com/getsentry/sentry-dart/pull/1272


Remove proxy test suite

Move proxy tests out of their own suite into other relevant suites.

Helps reduce the size of the pipeline

lgtm


Unable to start a nanoserver container on Windows 10 Insider Preview build 14390

I've followed the instructions up until running the container. The command and error are:
C:\>docker run -it nanoserver cmd
C:\Program Files\docker\docker.exe: Error response from daemon: container
4a82b38a3304e43473975941f54dd047bbf0c57ed8e3322d5f819122edf43071 encountered an error during
Start failed in Win32: The system cannot find the path specified. (0x3).

How would I find out what path it's referring to?
I previously had docker running via boot2docker and then Docker for Windows however both have been uninstalled.

tried removing old virtual nat switches?
check for remove-containernetworks and also retry with current updates to win10 and conainer engine.

Yeah, updates since I opened this issue have fixed it. It works now.
I did try removing old virtual nat switches. And all other network-related configuration. Whatever the problem was it's all good now.


[BUG] sendMessage in status broadcast

how can I send or create stories in this baileys module.  in the example on github they changed the function from id to status@broadcast but my try failed and the code was stopped

afaik it's not possible atm

The flow to do this is the same of sending a message to group, but we need define manually the contact list.

The flow to do this is the same of sending a message to group, but we need define manually the contact list.

Can you provide an example of the code for me. I don't understand a bit

There are no code to do it, we need to develop it

There are no code to do it, we need to develop it

come on, just make it when sending messages or videos and pictures because on all the web nothing explains about this
what I mean is just like the sample code, just an example conn. send Message(status@broadcast, {text: 'halo pren'})

@siTotes , what I mean is: There are no code in Baileys to handle messages for status/broadcast, we need to modify the Baileys to do it. I don't have enough time to it.

@siTotes , what I mean is: There are no code in Baileys to handle messages for status/broadcast, we need to modify the Baileys to do it. I don't have enough time to it.

Ok thanks then

Added support in https://github.com/WhiskeySockets/Baileys/pull/249


[smithsonian] Set minimum nodepool size to 5

ref: https://github.com/2i2c-org/infrastructure/issues/2854
I have performed the scale up.
However, because the jsonnet file is written in such a way that nodepool definitions are defined in a loop, I had to scale all notebook nodepools to a minimum of 5. Whereas I think scaling just the r5.xlarge nodepool would have sufficed. I'm not sure what the simplest way to achieve this in jsonnet would be though.

The jsonnet config for each node (https://github.com/2i2c-org/infrastructure/blob/47042f827b255455dd390a005e4e36fbdbb99974/eksctl/smithsonian.jsonnet#L28) is deep merged with the default config, so you can set minSize here: https://github.com/2i2c-org/infrastructure/blob/47042f827b255455dd390a005e4e36fbdbb99974/eksctl/smithsonian.jsonnet#L28.
If possible, can you also find a place to document this? Sorry it isn't already documented!

https://github.com/2i2c-org/infrastructure/blob/0dfc2045ba0c7d740886519e57d8ff6281735182/eksctl/carbonplan.jsonnet#L39 is an existing example

Cool, thanks @yuvipanda! Yep, I can document that too

I will open a new PR for docs, so we can just revert this PR at the end of the event. This is now ready to be merged.

docs PR: https://github.com/2i2c-org/infrastructure/pull/2864


PR:  Improve push down filter of join #13184 introduces correctness issues

Describe the bug
Recently merged PR "Improve push down filter of join #13184" introduces correctness issues.
I did not look closely at the code, but the example in the PR description seems incorrect. See reproducer for why.
To Reproduce
> CREATE TABLE t1 (c0 CHAR, c1 INT) AS VALUES ('a', 1);
CREATE TABLE t2 (c0 CHAR, c1 INT);
SELECT * FROM t1 LEFT JOIN t2 ON t1.c0 = t2.c0 WHERE abs(t2.c1) > 5;

0 row(s) fetched.
Elapsed 0.011 seconds.

0 row(s) fetched.
Elapsed 0.006 seconds.

+----+----+----+----+
| c0 | c1 | c0 | c1 |
+----+----+----+----+
| a  | 1  |    |    |
+----+----+----+----+

Expected behavior
Before that commit Datafusion correct produced empty output
DataFusion CLI v42.2.0
> CREATE TABLE t1 (c0 CHAR, c1 INT) AS VALUES ('a', 1);
CREATE TABLE t2 (c0 CHAR, c1 INT);
SELECT * FROM t1 LEFT JOIN t2 ON t1.c0 = t2.c0 WHERE abs(t2.c1) > 5;

0 row(s) fetched.
Elapsed 0.015 seconds.

0 row(s) fetched.
Elapsed 0.008 seconds.

+----+----+----+----+
| c0 | c1 | c0 | c1 |
+----+----+----+----+
+----+----+----+----+
0 row(s) fetched.
Elapsed 0.019 seconds.

Additional context
No response

FYI @JasonLi-cn  and @Dandandan

Oops... we need to revert it, will probably do so the weekend if noone else does it.

Created https://github.com/apache/datafusion/pull/13229 for reverting


Can you do the automapper.odata support or is it redundant?

I am using "odata" in my web api project. and "automapper" has that data support.
https://github.com/AutoMapper/AutoMapper.Extensions.OData
my method:
[HttpGet]
[EnableQuery]
public IActionResult Get(ODataQueryOptions<MyInternetHatlariDto> options)
{
//I don't want to use "context" how can I use your library here.
return Ok(_context.MyInternetHatlaris.Get(_mapper, options));
}

I also use your library. but since this is not supported, I have to use the database object directly. Do you think support should come or is it unnecessary?

@mansurdegirmenci Thank you so much for your issue. Currently, we don't have any plans.


The hashtag Add button should become dark green when text is input in the text field

see PR 38 for potential fix.


Firefox extension is broken/abandoned

Hi!
Very fun idea!
Unluckily it doesn't seem to be working anymore right now in GitHub for my version of Firefox (I'm on the beta channel).
Am I the only one?
Thanks!

Might need the same fixes as I've made for #68. I'll take a look at that if my PR gets merged.

The Firefox version is unfortunately abandoned following a lack of interest. I don't actively maintain the project any more, but there are enough Chrome users (like Ben here) using it and contributing fixes that the project's still alive. I think the Firefox version peaked at about 100 downloads so it just hasn't had the same support.
I've changed the Readme to reflect this, sorry for the confusion. If you or anybody else wants to port the current version of the Chrome extension into the Firefox part of the repo, I'd gladly merge it and reupload. Until then, we can keep this issue open to track Firefox support.

Travis,
I'll see if I can't revive the FF plugin today. :-)
-Ben
Sent from my phone

On Dec 13, 2015, at 5:32 AM, Travis Thieman<EMAIL_ADDRESS>wrote:
The Firefox version is unfortunately abandoned following a lack of interest. I don't actively maintain the project any more, but there are enough Chrome users (like Ben here) using it and contributing fixes that the project's still alive. I think the Firefox version peaked at about 100 downloads so it just hasn't had the same support.
I've changed the Readme to reflect this, sorry for the confusion. If you or anybody else wants to port the current version of the Chrome extension into the Firefox part of the repo, I'd gladly merge it and reupload. Until then, we can keep this issue open to track Firefox support.
―
Reply to this email directly or view it on GitHub.

@thieman, quick question - were you using cfx or jpm to package the FF extension?

I see a jetpack tag on the project in the developer hub, which makes me think I probably used jpm.

This is the face I make when I have to deal with the Firefox Addon SDK (posted from Firefox, obviously :wink:)

This is how I feel after another hour of wrestling with nsIHttpChannel. (Also posted from Firefox)

Testing...

More testing...

haha cool!!
Thanks for the effort guys!! :)

This should be resolved by #69 now.


x/crypto/openpgp: ReadEntity(): returning error on first invalid self-signature

After having a key expire and then resetting the expiry using GPG commandline. The openpgp package can no longer read secring.gpg.
http://play.golang.org/p/StEcvGUCvF
Which errors with:
$ go run secring.go
panic: openpgp: invalid data: user ID self-signature invalid: openpgp: invalid signature: hash tag doesn't match

goroutine 1 [running]:
main.main()
/Users/james/Development/Projects/goplay/secring.go:25 +0x237

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
/usr/local/Cellar/go/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1
exit status 2

I've created a new private key with a 1 day expiry. I should hopefully be able to upload a failing secring.gpg tomorrow.
As discussed https://groups.google.com/d/msg/golang-nuts/ZG1WgG7NwRg/ZvrOH2OZWu8J

CC @agl

This isn't as simple as letting a key expire and resetting it. It doesn't seem cause additional self-signatures.

It appears this is still a problem.  When I try to use sops:
Could not load secring: openpgp: invalid data: user ID self-signature invalid: openpgp: invalid signature: hash tag doesn't match

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.
If this is a security issue, please email<EMAIL_ADDRESS>and we will assess it and provide a fix.
If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.
If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.


cmd/scollector: fix empty host= tags not working after PR #1856

The add function in cmd/scollector/collectors/collectors.go uses host= to indicate that tag should be omitted
See https://github.com/bosun-monitor/bosun/blob/ac7f667fa1e649b877b77bfab7f2a643f5d8e615/cmd/scollector/collectors/collectors.go#L292
This should fix the vsphere errors on ny-bosun01:
error: collectors.go:256: Invalid tagset discovered: {disk=CO-EQL,host=}. Skipping datapoint. Added from: vsphere.go:138
error: collectors.go:256: Invalid tagset discovered: {disk=datastore1,host=}. Skipping datapoint. Added from: vsphere.go:105
error: collectors.go:256: Invalid tagset discovered: {disk=datastore1,host=}. Skipping datapoint. Added from: vsphere.go:136
error: collectors.go:256: Invalid tagset discovered: {disk=datastore1,host=}. Skipping datapoint. Added from: vsphere.go:138

My only worry is that the invariant for Clean is now violated. Clean should always result in a valid datapoint (can be sent and accepted by opentsdb as is), or an error. A solution more specific to AddTS  might be to move the host fixing up above the call to Clean.

Ah... I couldn't find that (bit scatter brained). Let me try that instead.

Yep... that works and is much better. I'll let this run on ny-bosun01 overnight as well but don't expect any issues


Add tests and documentation for sparse-array bulk construction

Original issue: https://charm.cs.illinois.edu/redmine/issues/798

Feature #554 added bulk construction for spare arrays in Charm++. Need to ensure that documentation and tests are up to date.

Original date: 2015-10-27 02:33:53

Implemented in changes 879 and 873, just waiting for a merge.

Original date: 2015-11-11 03:05:17

Set status back to Merged so that we can distinguish whether the code was changed in some way, or the fix was elsewhere. Both are non-open states from Redmine's perspective.

Original date: 2016-08-04 02:36:54

For ease of cross-reference: ~~https://charm.cs.illinois.edu/gerrit/879~~ https://github.com/UIUC-PPL/charm/commit/1d3dc7558ce2c080373f7da7d565cc9a6423e09f


Smart spaces do not save after creating and attempting to add more folders

Create a smart space. Add some folders. Edit the smart space to add more folders, cannot click save. Clicking the X or cancel adds no folder.

Thanks, I was able to reproduce it and will be patching it in the next patch today.

On Nov 1, 2023, at 11:09 AM, Giacomo Lawrance @.***> wrote:
Create a smart space. Add some folders. Edit the smart space to add more folders, cannot click save. Clicking the X or cancel adds no folder.
—
Reply to this email directly, view it on GitHub https://github.com/Make-md/makemd/issues/201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHKNTD5JACBC6Z7OQPIXTYCJQ4BAVCNFSM6AAAAAA6ZN4DHCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3TENJWGUYDONA.
You are receiving this because you are subscribed to this thread.

Thanks very much

Fixed in 0.8.6

Thanks so much.
Fixed 9fe488b00dbf01f57f9a1def0604b855f7451436


Fix get state(machine) from non-canonical chain

What was wrong?
When importing a block, we use head state instead of the state of it's parent block to apply state transition.

Rationale: Because there could be empty slots between the block and it's parent block, this could save us some work by not having to apply those per_slot_transitions again.

However one slot can only map to one state - state of canonical chain. If we are going to process a block from a non-canonical chain, we shouldn't use the head state to apply state transition because the head state is the state of canonical chain.
How was it fixed?
When importing a block, first check if the block is part of canonical chain.

If it is, use the head state.
If not, use the state of it's parent block and apply the per_slot_transitions to get the "head state" of the non-canonical chain.

Cute Animal Picture

But for the BeaconStateMachine, you could remove BeaconStateMachine.state by replacing it with chain.get_head_state() as #732. It will make it easier to keep state_cache in BeaconChain level.

This makes sense. So we can basically remove slot, block and state from BeaconStateMachine and instead passing in state to BeaconStateMachine .import_block() as in #732 .
Though if we are going to create a BeaconStateMachine that does not come with state, get_state_machine_by_slot seems to do the job just fine, i.e., we don't need get_state_machine_by_block

@hwwhww @ChihChengLiang Rebase after #800 is merged.


ios: qmake script contains non-resolvable target path for Qt 6.2.x

Describe the bug
Qt 6.2.x (maybe earlier versions as well) seems to have changed regarding the ios architecture compared to 5.15.2:
1, $OUTPUT_DIR/6.2.3/ios/bin/qmake is no longer independent, instead, the macos/desktop architecture has to be installed additionally. That's fine (although a bit unintuitive, but I guess there is not much which can be done about it). Maybe aqt could warn about that or even install the required archive (macos/desktop/qtbase) automatically?
2. It looks like $OUTPUT_DIR/6.2.3/ios/bin/qmake is supposed to find the macos desktop qmake, but currently it doesn't due to path changes.
#289 seems related, but apparently isn't enough to fix this.
To Reproduce
Steps to reproduce the behavior:

python3 -m pip install "aqtinstall==2.0.6"
python3 -m aqt install-qt --outputdir "/usr/local/opt/qt/" mac ios "6.2.3" --archives qtbase qttools qttranslations
/usr/local/opt/qt/6.2.3/ios/bin/qmake

Expected behavior
qmake only works when manually creating a symlink from the expected location to the new location like that:
https://github.com/hoffie/jamulus/commit/6c7e4751a1b5461e62e17600e2047919a2ce7f4f#diff-ad84ad4ff36c1685f58e8d153980cb299a85fd0f851681459248564f4d3a9b13R27
Another workaround would be not calling ios/bin/qmake by users, but if this is the advise, then ios/bin/qmake should probably not be there in the first place. :)
aqt should insert the proper path into the qmake script.
I believe that this place has to be adjusted with version-specific logic:
https://github.com/miurahr/aqtinstall/blob/1a82a92e4c44b0891b6df03f1f5ff371eff2de50/aqt/updater.py#L176
clang_64 should be macos for Qt 6.2.x.
I may try to submit a PR this evening (but feel free to go ahead if you don't hear from me).
aqt output
/usr/local/opt/qt/6.2.3/ios/bin/qmake: line 7: /usr/local/opt/qt/6.2.3/clang_64/bin/qmake: No such file or directory

Desktop (please complete the following information):

macOS 10.15 with ios target
aqtinstall(aqt) v2.0.6 on Python 3.9.10 [CPython Clang 12.0.0 (clang-1<IP_ADDRESS>)] (Update: 2.1.0rc2 shows the same behavior)

Additional context
Of course, I might be missing something; I've just noticed that simply replacing 5.15.2 by 6.2.3 no longer leads to a working qmake setup for ios.

I wonder if #332 is relevant here? The Updates.xml file for Qt 6.2.3 ios contains this:
<Dependencies>
qt.tools.qtcreator, qt.qt6.623.clang_64, qt.qt6.623.doc, qt.qt6.623.examples
</Dependencies>

Qt 6.2.2 for ios also depends on the equivalent qt.qt6.622.clang_64, but it looks like Qt 6.2.1 and below do not.
The equivalent dependencies for android do not have anything like this, so maybe this isn't an issue on the android side of things:
<Dependencies>
qt.tools.qtcreator, qt.qt6.623.doc, qt.qt6.623.examples
</Dependencies>

I wonder how the official Qt installer handles this. From what I understand of the xml file, I would expect the official installer to just install the whole qt.qt6.623.clang_64 package (127 MB compressed, 818 MB decompressed). Since qtbase is only a small part of that (21 MB compressed), I am skeptical that a naive "just download all stated dependencies" approach is what we want.
If possible, I would rather leverage the Updates.xml files to decide which packages/archives to install (as proposed in #332), as opposed to adding a lot of one-off conditional code that installs package X when you request package Y. However, I think we will need to provide users a way to filter which packages and which archives from the dependency list they actually want.

clang_64 should be macos for Qt 6.2.x.

Honestly, I'm a little surprised that the Updater.patch_qmake_script() method works at all without being told what directory to use. That function looks like it's choosing a directory based on what OS the installation is for, which works fine for linux and mac below Qt 6.1.2. I don't see how it makes any sense on Windows; the mingw81_64 directory should not exist if you're not installing that particular architecture:
https://github.com/miurahr/aqtinstall/blob/893440cf3c56401fef2b641fd1ca34b190aefd4f/aqt/updater.py#L178-L184
In any case, I think it's time to add some more ios build jobs (perhaps Qt 6.2.2) to the Azure Pipeline script here:
https://github.com/miurahr/aqtinstall/blob/1a82a92e4c44b0891b6df03f1f5ff371eff2de50/ci/generate_azure_pipelines_matrices.py#L271

If possible, I would rather leverage the Updates.xml files to decide which packages/archives to install (as proposed in https://github.com/miurahr/aqtinstall/issues/332), as opposed to adding a lot of one-off conditional code that installs package X when you request package Y.

Understood. (1) from my issue description is the less-relevant part. It is workaroundable by the user by choosing to install the proper dependencies. It's not optimal, but still clean, IMO.
The broken qmake script (2) is what I think would be good to fix in the sort-term, as custom symlinks do not sound like a clean solution... :)

Honestly, I'm a little surprised that the Updater.patch_qmake_script() method works at all without being told what directory to use. That function looks like it's choosing a directory based on what OS the installation is for, which works fine for linux and mac below Qt 6.1.2.

Yes, I was wondering as well as I was trying to derive the proper values from other variables, but wasn't able to (especially for Windows). How should we go forward here? I feel confident adding a conditional there and can provide a PR. I don't feel confident reworking that part completely as I lack history, context and knowledge... :)

The broken qmake script (2) is what I think would be good to fix in the short-term, as custom symlinks do not sound like a clean solution... :)

Indeed. I think you deserve a very big thank-you for pointing this problem out.

Yes, I was wondering as well as I was trying to derive the proper values from other variables, but wasn't able to (especially for Windows). How should we go forward here? I feel confident adding a conditional there and can provide a PR. I don't feel confident reworking that part completely as I lack history, context and knowledge... :)

I think we need a centralized, reusable function that returns the folder name for the desktop version of Qt, i.e. gcc_64 for linux, clang_64/macos for mac depending on the version, and for now we can stick to the existing mingw81_64 for windows. mingw81_64 is undoubtedly not the right choice for all situations; that architecture does not even exist for several versions of Qt. I would prefer an approach that checks what desktop Qts are available and chooses one, but that's a job for another day.
I've started a PR, #510, that adds tests for this. I think the tests are appropriate; you can see a failure to build an iOS project due to an incorrect patch here: https://dev.azure.com/miurahr/github/_build/results?buildId=5074&view=logs&j=1ea727ed-2050-5877-9d96-adddb35f7943&t=b67eabc5-7e7e-54c5-0f88-bc35772ccffe&l=41. The equivalent build for Qt 5.15.2 passes. @hoffie, if you'd like to work on this, please pull my branch at https://github.com/ddalcino/aqtinstall/tree/fix-mac-qmake-patch and see what you can do with aqt/updater.py. I will leave #510 as a draft for a week to give you time to work on it, if you'd like. If you aren't interested, I can do it. It should be a pretty quick fix.
Additionally, if you think my tests could use improvement, I'd appreciate the feedback. I don't know if accelbubble is the best example to use for iOS; maybe you know of a better one. I used accelbubble because we're already using it to test Android versions of Qt.

@hoffie I hope #510 fixed this for you. Can you please let us know if https://github.com/miurahr/aqtinstall/releases/tag/v2.1.0rc4 has solved this for you?

Sorry for responding so late, got caught up with real life stuff.

@hoffie, if you'd like to work on this, please pull my branch at https://github.com/ddalcino/aqtinstall/tree/fix-mac-qmake-patch and see what you can do with aqt/updater.py. I will leave https://github.com/miurahr/aqtinstall/pull/510 as a draft for a week to give you time to work on it, if you'd like. If you aren't interested, I can do it. It should be a pretty quick fix.

Having looked at the PR now, I don't think I could have done in that way. Thanks for working on this!

Additionally, if you think my tests could use improvement, I'd appreciate the feedback. I don't know if accelbubble is the best example to use for iOS; maybe you know of a better one. I used accelbubble because we're already using it to test Android versions of Qt.

Sorry, I'm not deeper into iOS or mobile Qt stuff (I don't even own an Apple device ;)).

I hope https://github.com/miurahr/aqtinstall/pull/510 fixed this for you. Can you please let us know if https://github.com/miurahr/aqtinstall/releases/tag/v2.1.0rc4 has solved this for you?

v2.1.0 works without symlink workarounds. Thanks!


chore: Template upgrade

https://pawamoy.github.io/copier-pdm/changelog/

support for Python 3.7 is dropped (EOL tomorrow)
Python 3.12 added to tests matrix (though not supported yet, so allowed to fail)
code of conduct updated
use pdm-multirun plugin instead of shell script
use Ruff instead of Flake8 and Isort
duties updated
use mkdocs-material and mkdocstrings-python insiders transparently (use what's installed)
fix code quality (noqas, future annotations)

I'm OK with changes if there are things you don't like, but as usual it's easier for me to maintain if it doesn't diverge too much from my copier-pdm template :slightly_smiling_face:


Export endpoint constants

Describe your motivation
Currently, generated endpoints contain a hard-coded paths to the service and the method to be called, as well as a constant Hilla-specific prefix.
Generated endpoints can't currently be called from service workers because of CSRF information needed from the document head (or a cookie), but once the CSRF token is supplied to the service workers, there's nothing preventing the service worker from calling the endpoint method. This just means that the fetch call needs to be built manually, which can be done based on the information found from the generated sources plus the CSRF token. This is prone to breaking if anything changes either in the endpoint methods or in Hilla internals.
Describe the solution you'd like
The simplest approach would be to alter the endpoint generation in a way that the generated modules export the constant values used in there: the service name, the method name, and the clientconnect prefix. This would make any custom code calling the endpoints more stable and changes in the generated artifacts or in Hilla internals would be less likely to break usage.
Describe alternatives you've considered
Most use cases won't need the exported constants, and the generated codebase will be slightly larger than without this feature, so it could be beneficial to make the exports configurable, e.g. with a special annotation like @ExportConstants, an annotation argument in @BrowserCallable like @BrowserCallable(exportConstants = true) or a configuration option in application.properties.
Additional context
No response

That's an improvement, but let's focus on enabling endpoint calls from the service worker context instead. Using low-level fetch does not seem to be a good idea.


Reducing Cerebro cpu and memory requests

Hi all 👋
I'm opening this little PR to reduce cerebro requests in cpu and memory (is too high on not so big clusters)

LGTM!


$default link click handling for web container didn't work

Jasonette will hang when a link is clicked inside $default type link handling web container.

Can you share a minimal simplest example I can try?

I test it with the "$default Link Click Handling" demo (the Regular Browser demo), however the selective link click handling is working fine.

FYI, I test it using the emulator and actual device.

Thanks for reporting, this was a bug that happens on a unique configuration, and the example happened to stumble upon that unique configuration.
It should be fixed now https://github.com/Jasonette/JASONETTE-Android/commit/8cb6abbd7b3aa7d264ea0138c3ca1de6762e89f5
Let me know if it's still broken.

Thank you, It's working now.


using tf.GPUOptions in tf 2.x

what is the proper call for this in version of tensorflow 2.x ?
tf.GPUOptions(per_process_gpu_memory_fraction=0.3) # i used this with tf.compat.v1 , GPUOptions is not available in 2.x , can someone help me use my gpu cores without using gpuoptions ,coz i dont want to use compat v1

@glennford49
Can you please go through the link and see if it helps you.This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there and provide better and faster support for such issues. Thanks!


Verify if the documentation commands work on Windows

Hi there!
It is important to make sure the documentation / commands run on Windows as well. If not, we can create alternative instruction paths, create a Makefile for Windows users etc.

Please feel free to reopen this if this is still an issue.


Breadcrumbs Issues - About Pages

@MarquiseRosier a new issue just appeared on this page - https://main--shredit--stericycle.aem.live/en-us/about/careers/our-culture
There's some weird breadcrumbs being added and it's not styled properly. Can you see that this entire white breadcrumb section is removed. I don't see it in the document to delete it.
This seems to happening across our all of our about pages. A few examples:
https://main--shredit--stericycle.aem.live/en-us/about/news-articles
https://main--shredit--stericycle.aem.live/en-us/about/press-releases
https://main--shredit--stericycle.aem.live/en-us/about/social-responsibility/diversity-inclusion

@colinvlasak Its somehow not reproducible for me.

@jindaliiita looks like it is fixed!


Mewbase auth

Finished the authentication part.
Flag in ConnectionImpl has been removed.
CheckAuthorized method has changed, it doesn't only log errors now.
I've also added some documentation.

Good stuff. Just a few comments inline

Other than comments looks good.
Would be nice to see some more tests around the MewBaseAuthProvider interface and also testing auth on all protocol commands, not just pubsub, as this is what someone would try if trying to exploit mewbase.
Can you add an issue for that?

I'll merge it and correct the above

Hi Tim,
I've now pushed commit https://github.com/Tesco/mewbase/pull/90/commits/6b32afc014fffcf67c1608fa80d210fa2c8d4ec4
I've run the full test suite and got no failures.
I did spot two stacktraces regarding ShiroPropertiesAuthenticationTest regarding the SecurityManager. Unfortunately, I couldn't get to the bottom of it even though the configuration looks to be the same as the tests in Vertx.
Would you be able to assist in that?

Hi Nuno,
I am doing other stuff most of today but hopefully can take a look later or
tomorrow.
On Mon, Nov 28, 2016 at 6:16 PM, Nuno Santos<EMAIL_ADDRESS>wrote:

Hi Tim,
I've now pushed commit 6b32afc
https://github.com/Tesco/mewbase/pull/90/commits/6b32afc014fffcf67c1608fa80d210fa2c8d4ec4
I've run the full test suite and got no failures.
I did spot two stacktraces regarding ShiroPropertiesAuthenticationTest
regarding the SecurityManager. Unfortunately, I couldn't get to the bottom
of it even though the configuration looks to be the same as the tests in
Vertx.
Would you be able to assist in that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Tesco/mewbase/pull/90#issuecomment-263349037, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq10pMIq2kN03bGECyR0kn_5goemWdGks5rCxqbgaJpZM4K5-ka
.

Tim, I've merged latest master which should have fixed all conflicts.
From my side, looks good to go.

Thanks!


[BROKEN!] 'New Annotation' not working

Issue
The transcription bar does not appear when I click on 'new annotation' on the transcription page.
Also, the page doesn't display the rectangles that I had previously drawn. It looks as though I have never been on that page despite the fact that I have entered 17 annotations (according to the annotation count).

Sounds like an error in the JS. Can I get the URL of the page you were transcribing? I need more details to be able to replicate this. Please try to include a url for the page in question for all issue reports. If it's an issue with the field options or transcriptions, please open your javascript console and report and errors or messages present there. Thanks!

Sounds like an error in the JS. Can I get the URL of the page you were transcribing? I need more details to be able to replicate this. Please try to include a url for the page in question for all issue reports. If it's an issue with the field options or transcriptions, please open your javascript console and report and errors or messages present there. Thanks!

Yes, my bad. I thought the issue was generalized to all pages.
Url: http://test.citsci.geog.mcgill.ca/transcriptions/27/edit
JS-Console:

fixed in 609454ae5917de407454129cee6ef8b874e7698d, it's working now


SAP SQL Anywhere 17.0.11: Liquibase incorrectly reports that TIMESTAMP requested precision is longer than TIMESTAMP supported precision

Search first

[X] I searched and no similar issues were found

Description
I am trying to generateChangeLog from a SAP SQL Anywhere 17.0.11 database which contains TIMESTAMP WITH TIME ZONE columns having a default of DEFAULT UTC TIMESTAMP.
Liquibase incorrectly complains that the supported precision is shorter than the requested precision:
liquibase.exception.LiquibaseException: liquibase.exception.CommandExecutionException: java.lang.RuntimeException: java.lang.RuntimeException: liquibase.exception.DatabaseIncapableOfOperation: Using a TIMESTAMP data type with a fractional precision of 33 is not supported on asany: A timestamp datatype with 33 fractional digits was requested, but SQL Anywhere only supports 9 digits.

The message was true for older versions of SQL Anywhere which did not support "WITH TIME ZONE", but since current versions support "WITH TIME ZONE" this message is wrong now.
Steps To Reproduce
generateChangeLog using SQL Anywhere 17.0.11 having a column with the definition TIMESTAMP WITH TIMEZONE DEFAULT UTC TIMESTAMP.
Expected/Desired Behavior
Successfully accepts both, the type TIMESTAMP WITH TIMEZONE and the default value UTC TIMESTAMP.
Liquibase Version
latest
Database Vendor & Version
SAP SQL Anywhere 17.0.11
Liquibase Integration
Maven Plugin
Liquibase Extensions
none
OS and/or Infrastructure Type/Provider
Windows 10
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

Thanks for the issue. There is similar "timestamp with time zone" logic for postgresql that will need to be adapted to sap sql now that it supports it.

There is similar "timestamp with time zone" logic for postgresql that will need to be adapted to sap sql now that it supports it.

Does "that need to be adapted" mean that a committer will work on it, or does it mean that the project team expects the reported (me) to provide that fix?

I have startet work in this issue in my private fork: https://github.com/mkarg/liquibase/tree/mkarg/sap-sql-anywhere-liquibase-3971. Comments very welcome! 😃

Hi @mkarg, thank you for reporting this issue and for creating a PR for it. Is there anything we can do to help you to move forward with this PR?

Hi @mkarg, thank you for reporting this issue and for creating a PR for it. Is there anything we can do to help you to move forward with this PR?

Thank you for this kind offer, I really appreciate it. @filipelautert is already supporting me. Unfortunately I do not see how you can help right now, as the next step is that I need to check the JDBC driver's actual behavior. Once that is known, we can decide how to work around.

Yeah, I talked with Filipe after posting my comment. Cool, if there is anything I can help with please let me know.
Thanks,
Daniel.


Replace Accessible Media Player with pure Youtube embed iframe

TODO: update tests to account for Youtube API async loading
TLDR: this replaces Accessible Media Player with a pure Youtube iframe player
Embed video preview url: https://govuk-publishing-compon-pr-908.herokuapp.com/component-guide/govspeak/with_youtube_embed
Embed-disabled preview url: https://govuk-publishing-compon-pr-908.herokuapp.com/component-guide/govspeak/with_youtube_embed_disabled
Why
There are a number of accessibility issues with the current video player, so a prototype of shortlisted players was reviewed against the criteria in https://docs.google.com/document/d/1ZhrZH-nKCXs-uMz8HIXPx7FgAs4p3fsrmNMItDj_dt0/edit - and the recommendation was to use just the Youtube iframe player with some tweaks:

Add a title attribute to the iframe, taken from the fallback link text,
Disable option to allow single key shortcuts (disablekb) due to WCAG SC 2.1.4
use the no-cookie version

Bonus improvements:

rewritten in vanilla JS, so no longer depends on jQuery
remove import of jQuery-ui dependency

Accessibility testing

Summary
work by @selfthinker
I have implemented all 4 contending video players (Plyr, Able Player, MediaElement.js and Video.js) plus the default YouTube player and looked a bit deeper into things, especially accessibility.
There are a couple of things which all the other players inherit from YouTube. I've only tested YouTube videos with them as that is where the majority of GOV.UK videos are hosted (or maybe even 100% of them?).
Keyboard access
The YouTube video starts with an image with the generic name "photo image of" that is linked to the channel and then a hidden heading with the name of the channel that is also linked to the channel. That means if you navigate the page without a screen reader, the second tab within the iframe is always hidden. If you navigate the page with a screen reader, the first link never makes sense and the second link rarely makes sense, depending on how well the channel is named, although it always misses the information that it is the name of the channel.
It's nice that YouTube and Able Player show labels for most controls when they have focus or when you hover over them. That way it will be clearer for people with cognitive impairments. Plyr has a setting that would show them as well.
The focus ring on some of MediaElement.js's controls is quite faint.
All video players keep keyboard focus within the fullscreen view and loop to the top when you've reached the end of that screen.
Most of the players have keyboard shortcuts. YouTube uses a single key, which would be against WCAG SC 2.1.4, but that can be disabled. Plyr only uses such shortcuts when the focus is on the player, but that can also be disabled. And Able Player uses modifier keys which can also be changed, so it is never a letter just on its own.
Screen readers
I have so far tested with NVDA in Firefox and VoiceOver on iOS.
It is interesting how the various players announce that there is a video. The only way how you might know there is one with Plyr (and also the current Nomensa player) is because you will stumble upon a "play button". Not great.
YouTube is a bit better as at least you will know there is a frame (whatever might be in it). Mediaplayer.js has the words "video player" just before it and has given the player a role of "application" with the same title, and Able Player has a heading saying "media player". Much better.
All players have some kind of feedback after clicking the play button to announce that the button has changed to a pause button.
Except Plyr gives no feedback at all and even says "button play" after the button has visibly changed to a pause button. YouTube adds the letter "k" which will probably be confusing to screen reader users. On the tooltip the "k" is in brackets which makes it a bit clearer that it's the keyboard shortcut. Able Player goes a bit further and doesn't just announce what the button was changed to but also what clicking it has done to the video, i.e. "pause playing", which I find a bit confusing.
Some labels in the YouTube player are announced after the button, which is confusing. The amount of subscribers is a hidden heading, also confusing. The Plyr player often doesn't provide any feedback after activating a control, which is especially confusing when you are supposed to do something afterwards as in a dropdown menu.
MediaElement.js has half a keyboard trap. When a video has started the up and down arrows turn the volume up and down but cannot be used for the standard NVDA navigation. Tabbing still works, though.
All players show the "related videos" etc including the close button for those when pausing, but Plyr and MediaElement.js doesn't allow you to interact with them in any way, neither via clicking nor tabbing or via navigating with a screen reader. That means there is some functionality visible which cannot be accessed at all. Not good.
All players use the internal iOS video player (although that is often configurable) when used in Safari on iOS. Only Plyr doesn't do that. Plyr's fullscreen implementation still allows you to navigate the rest of the page with VoiceOver, which can be disorientating.
Voice control
I only tested with Windows Speech Recognition as I was testing when I was working from home and didn't have access to Dragon. I will re-test this with Dragon when I'm in the office.
I'm not too familiar with voice control tools, so might easily have missed something.
I could get every player to work with either "play" or "click play" or "play video" except Able Player. It wasn't working most of the time, it seems to only work with "click" when already hovering over the controls. ("Mousegrid" always works, though.)
I had trouble getting Plyr to pause. The YouTube player seemed to work best in this case.
Changing colours
None of the players are usable at all when changing colours in Firefox. Most elements are completely invisible.
Colours are not great but usable when changing colours via the Windows "high contrast" settings. Only MediaElement.js in IE11 is mostly invisible.
Captions
The only players which support switching captions on and off when they are hosted on YouTube are the YouTube player and Able Player.
Browser tests
Everything works in our supported browsers. In order for Plyr to work in IE11, we would need to implement a polyfill which I haven't bothered with for this test. So, Plyr on my playground won't work in IE11 but adding support is possible.
MediaElement.js on my playground isn't responsive. But there is a responsive setting which doesn't seem to be the default.
Conclusion
Just judging by these findings, Able Player or the YouTube player seem to be the best choice.
The question is, how much better is Able Player and in what areas that might justify choosing it over the native YouTube player? It seems to be better for screen reader users but worse for voice control users. It has support for transcripts (even interactive ones), audio descriptions (text-based or audio/video-based) and sign language (via synchronising a second video). But which of those would we actually use?
As far as I can see, both players would fail WCAG but the only proper barrier is the voice control issue with Able Player. (And invisible controls when changing colours, but all players have that issue.)

Discussion
Additionally, we'd like to add a visually hidden heading before the iframe so it's clearer to screen reader users that there is a video, e.g. "Video player".
Issue is, the heading level needs to fit into the heading hierarchy (e.g. an h2 if the heading before is an h1, an h3 if the heading before is an h2, etc, but I think we cannot programmatically establish the heading before.
Youtube Iframe API  implementation
Note to reviewers: This works fine in this application, but the locally modified gem in another application didn't show videos (access blocked). Wondering what the best way to test this is.

@kr8n3r woop this is an exciting change - be glad to say goodbye to the extra dependencies.
As part of your checks for whether this is good to merge could you co-ordinate with Publishing Workflow team (myself or @alex-ju are good candidates) so we can check it works in our app still. We use it to preview documents and need to re-initialise the component each preview. I ask this because it was quite delicate getting the original version to work with this. Thanks.

@kevindew yeah will check with the team once I have it in a state that's passing test and is ready for review.

Outstanding work:

test the functionality

Previous test only tested for the existence of the container (which is govspeak) and it didn't test if the video (iframe) actually gets created.
Currently the test fails is it completes before the API finishes (player is ready) as its async.
Any ideas how to test this would be appreciated.  Jasmine 2.4 is used here.

This will need to be updated with the new cookie work happening

https://github.com/alphagov/govuk_publishing_components/pull/916
https://github.com/alphagov/govuk_publishing_components/pull/912

While we are using the `no-cookie' youtube domain for embedding videos that don't store cookies when the videos are embedded, it DOES store them once you hit play.

@kevindew FYI this should be ready to test now 👍

@kevindew I think I've fixed the problem with rendering multiple identical videos and the invalid HTML. Would you be able to check again the issues you were having in Content Publisher and see if they're resolved now?

@kevindew I think I've fixed the problem with rendering multiple identical videos and the invalid HTML. Would you be able to check again the issues you were having in Content Publisher and see if they're resolved now?

Thank you! I'll try check it out by the end of the day.

@kevindew I think I've fixed the problem with rendering multiple identical videos and the invalid HTML. Would you be able to check again the issues you were having in Content Publisher and see if they're resolved now?

Thank you! I'll try check it out by the end of the day.

Hey @vanitabarrett, sorry for the delay. I've checked it out and the problem where the same video doesn't load is resolved however the problem where videos can't be re-initialised persists.
Here's a capture of what happens:

@kevindew The changes in your branch look good, I just had one comment which I've left there. Happy for you to push them to this branch 🙂

@kevindew The changes in your branch look good, I just had one comment which I've left there. Happy for you to push them to this branch 🙂

Great thanks. I've just done so.
With regards to your comment:

I think I'm getting a bit confused here... it looks like we're renaming $element to $jqElement (which I'm assumig stands for 'jQuery Element'), but we've changed the logic to pass HTML rather than a jQuery object?

Yup you're correct that it refers to a jQuery element - would there be a nicer way to make that clearer? I know we use a $ prefix to refer to a jQuery result and for a HTML element so I wanted to make that a bit clearer.
I changed YouTubeLinkEnhancement to accept a HTML element rather than a jQuery one since it no longer uses any jQuery and it means we can lose
https://github.com/alphagov/govuk_publishing_components/pull/908/commits/a6f9a635f03b01e9388dc3e7e79ab5be6a9803e4#diff-b4722dbdd6fe718214588e4addc706d4L14
where it looks like we have an array of elements and meant it had to be tested with jQuery: https://github.com/alphagov/govuk_publishing_components/pull/908/commits/a6f9a635f03b01e9388dc3e7e79ab5be6a9803e4#diff-ee8d4d8b36beb87a40beebb8b4e9c665L31

thanks everyone for taking this on and making it solid 👍


Update README.md (updated latest node version to 22)

Node.js 22 is now available!
The latest tag is pointing to the node v 22.x now
https://nodejs.org/en/blog/announcements/v22-release-announce

It sure is, thanks for the PR @aminsaedi <3


upgrade possibilty? and thx

hello friend thx for hard work and lovely scope..   is it possible to make more analog channels in the same page (either with other boards or even spliting the 5 adcs  into 5 channels?  that would be great??        I know about the trigger sync but its not duable to open more then one page in a screen ...

You are very welcome!  You can open two web-pages and switch them to "background" mode with the button so that they can both run and capture,, even if only one is visible at a time (ordinarily javascript pauses the non-foreground web-page, which totally breaks the trigger logic) -- I realize it is a bit clunky to do that.
I think a couple of analog channels from two different flea-scopes on the same page is a great possible enhancement...  Possibly in place of digital capture...  There are some challenges as well -- with gathering twice as much data from USB, and handling independent triggers, and handling two different sets of calibration values, but it could be doable.
As for 5 adc's into 5 channels, that would require very different hardware.  And unfortunately the "raw adc input" is quite low impedance, (like 10k ohm or less) making it probably unsuitable for any kind of measurements -- and adding 5x op-amps as front-ends for 5 adc's starts to get pricey...
Possibly for the future mosquito-scope if I can do it on dsPIC33A, which should have 2x 40 Msps adc's, it might make sense to have 2 channels of 40 Msps -- that's be a nice balance of cost and performance.

by the looks the bea-scope will be pure honey....lol
Thx for answer and I understand the limitations, almost all diy scopes are 1 or 2 channels thats why I was looking for 3 or 4 max channels
For automotive work theres no need for high sampling but more channels are appreciated
when we buy the fabricated pcb its minimum 4 pcbs so it would be great improvement more channels
love the simplistic way of altering the gui page (did it in notepad, decreasing the font sizes for better split screenl) and the easy of taking measurements but that all change with more channels I know
Anyway you already have a fan just by making it opensource and being a teacher that teaches and cares about the students
You deserve to teach in the university as your dream...   Big thanks from Portugal

I also love the automotive target -- I have done some you can see here -- I totally agree more channels (rather than more sample rate) gets nicer.  I do hope to make it to teaching somehow -- it is especially nice when folks are grateful, so thank you for that!


Consistency nits

Spell out destination
authority is used when either owner or delegate may exercise an action. In this case, only owner is authorized.

Thanks!


K8s-tools: bump k8s version to 1.21.10

Description
Changes proposed in this pull request:

bump k8s version to 1.21.10

Related issue(s)

/assign

/cla-recheck

/retest

/assign @dekiel
/assign @ressetkk

/test pre-main-tpi-k8s-tools

/retest

/cc @dekiel
/cc @Ressetkk


Background Image POD Install

Hello,
The last add "Add custom background image function" is not included in tag 0.4.0.
Can you upgrade RevealingSplashView.podspec for checkout the last update ?
Thanks !

Thanks for the report, will get it done this week!

New version 0.5.0 its up! 🎉


No method to cancel a message that was previously scheduled via API-triggered Canvases
What is the new behavior?
Method to cancel a message that was previously scheduled via API-triggered Canvases: braze.canvas.trigger.schedule.delete()
Checklist:

[x] Conventional Commits
[x] Tests
[x] Documentation

Codecov Report

Merging #39 (efb6522) into master (680c735) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           39        40    +1
  Lines          188       194    +6
  Branches         5         5
=========================================
+ Hits           188       194    +6

Impacted Files
Coverage Δ

src/Braze.ts
100.00% <100.00%> (ø)

src/canvas/trigger/schedule/delete.ts
100.00% <100.00%> (ø)

src/canvas/trigger/schedule/index.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix: expose fuse config

Could possibly fix #942

What do you mean? It is overwritten by app.config

Misread, looks great!
Would you mind adding it to the docs too?


⚠ AVS (kty) has degraded performance

In 4162c3c, AVS (kty) (https://avus.com.br) experienced degraded performance:

HTTP code: 200
Response time: 13124 ms

Resolved: AVS (kty) performance has improved in 2c04445.


added solution in java and updated readme

Solved issue #457
In Language- JAVA

[x] Updated README Link
[x] Added code with comments

Thanks for contributing!

Algorithms/Implementation/

Algorithms/Implementation/

oh, surely. I think even the python slution for the same is in the wrong directory.


how to make underline in all tabview

how to make underline bottom on all tabview like this ?

oke.. i will try it.. thank you

options.tabView.additionView.padding =  UIEdgeInsets(horizontal: 25.0, vertical: 0)
play with values

You can make a UIView with height of 1px or 0.5px and add a top constraint with offset of tabView height


I updated the logo for this project! I think it looks a little bit more modern.

(I still like the other one too...)

Thanks for your proposition, we appreciate it. Unfortunately, this is a standard logo that we can't change.


npm install error?

npx create-proton-app quickBuild

and then I get the error：
Creating a new Proton Native app on E:\workspace2017\myproject\quickBuild

Installing packages... This may take a few minutes.

An error ocurred:
 npm.cmd install --save --loglevel error proton-native babel-cli babel-preset-env babel-preset-stage-0 babel-preset-react has failed.

How can i deal with it?

@albe-rosado

mmmm, let me see @liaoyongfu  , will get back to you very soon

@liaoyongfu  tested it in linux and macos and works. @mischnic  are you having the same problem?

Works on Mac with create-proton-app installed globally

Try executing the command normally. It may be something to do with how your permissions are set or something like that.

Thank you all. I'm sure create-proton-app has installed globally:
F:\>npm list -g create-proton-app
D:\nodejs
`--<EMAIL_ADDRESS>
I also try create-proton-app my-app, but also get the error. I don't know what's going on?

i will  find a windows pc to test this, and will get back to you asap @liaoyongfu

@albe-rosado Thanks a lot. After running npm install --global --production windows-build-tools it was successful：
C:\Users\Administrator>npm install --global --production windows-build-tools

><EMAIL_ADDRESS>postinstall D:\nodejs\node_modules\windows-build-too
ls
> node ./lib/index.js

Downloading BuildTools_Full.exe
[============================================>] 100.0% of 3.29 MB (3.29 MB/s)
Downloading python-2.7.14.amd64.msi
[============================================>] 100.0% of 20.17 MB (1.34 MB/s)
Downloaded python-2.7.14.amd64.msi. Saved to C:\Users\Administrator\.windows-bui
ld-tools\python-2.7.14.amd64.msi.

Starting installation...
Launched installers, now waiting for them to finish.
This will likely take some time - please be patient!

Status from the installers:
---------- Visual Studio Build Tools ----------
Successfully installed Visual Studio Build Tools.
------------------- Python --------------------
Successfully installed Python 2.7
+<EMAIL_ADDRESS>added 132 packages in 1028.132s

@liaoyongfu  your welcome, I will make a PR to update the docs to reflect the need for the dependencies for windows and linux.

It's only needed for Windows if you don't have a suitable compiler/python.
On Tue, Apr 10, 2018, 12:38 PM Alberto Rosado<EMAIL_ADDRESS>wrote:

@liaoyongfu https://github.com/liaoyongfu your welcome, I will make a
PR to update the docs to reflect the need for the dependencies for windows
and linux.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kusti8/proton-native/issues/81#issuecomment-380167364,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJW73FUiyBcq004bWhgRBHw0wjm8Vl-Nks5tnOAMgaJpZM4TMYc9
.


Babbage property tests

Test the new Babbage features with property tests.

Resolved by #2698 and #2758


SSR Router does not work when there is basepath

Describe the bug
SSR Router does not work when there is basepath
Your Example Website or App
https://stackblitz.com/edit/tanstack-router-xzjwqs?file=src%2Frouter.tsx
Steps to Reproduce the Bug or Issue
Modify the SSR example https://tanstack.com/router/v1/docs/examples/react/basic-ssr-file-based

add basepath
Refresh the StackBlitz browser
Route content does not show up even though Rendering: /app/ is logged to console.
Inspect the script injected by DehydrateRouter. Only __root route is matched.

window.__TSR_DEHYDRATED__ = {"router":{"state":{"dehydratedMatches":[{"id":"__root__","status":"success","updatedAt":1704684196926}]}}}

Expected behavior
SSR works with basepath.
Screenshots or Videos
No response
Platform
NA
Additional context
No response

Fixed with 4ebcf4ca160678e1763c5a834b0bab1623340f10


Add source Winx Club Magazine BR

Source name
Winx Club Magazine BR
Source link
https://winxclubmagazinesbr.blogspot.com/?m=1
Source language
Portuguese PT-BR
Other details
No response
Acknowledgements

[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I will fill out all of the requested information in this form.

Blog website without a proper structure for an extension.


fix(helm): helm pull --repo to use repo creds from helm repos file

Up to this point, helm pull --repo required --username and --password
even if the repository had already been added via helm repo add.
From now on, check repositories in the repositories file and if the URL
matches, pull the chart from the configured repository.
In case of a URL match ...
helm pull --repo repo.URL chart
... will become:
helm pull repo.Name/chart
Fixes #9599
Signed-off-by: Andreas Karis<EMAIL_ADDRESS>
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

I can't assess much from the technical perspective here, my only concern is:
When we run helm dep update, the exact same thing occurs (Helm tries to find repos with credentials already set in which matches the repo url set in the dependencies). So maybe, this does not need to be reimplemented, but reused from the helm dep update.

The code for helm dep update that's in charge of this is here:
https://github.com/helm/helm/blob/e87f81563788f311e7a5a7640385c003d5d6096b/pkg/downloader/manager.go#L243
and that calls findChartURL:
https://github.com/helm/helm/blob/e87f81563788f311e7a5a7640385c003d5d6096b/pkg/downloader/manager.go#L689
It then uses DownloadTo to download the chart:
https://github.com/helm/helm/blob/e87f81563788f311e7a5a7640385c003d5d6096b/pkg/downloader/manager.go#L355
These methods are all private to the downloader package so they can't be reused.
The suggested code merely browses the repository .yaml file, looks for the first match for the repository's URL (exact match) and then returns the repository name. It then prepends the repository name to the chart name and then calls c.DownloadTo as if the user had called this with repository_name/chart_name. So it mostly recycles existing logic.
The alternative would be to fetch the username and password from the file in p.Settings.RepositoryConfig and to set them in repo.FindChartInAuthAndTLSRepoURL   instead of p.Username and p.Password.

Methods being private does not mean they their access can not be changed, right? But anyway, your approach does the trick for me, as I said, I can't assess much from the implementation perspective.

I'm not a maintainer here, either. I'm just looking into helm and I'm chasing for some low-hanging fruit bug reports.
I changed it a bit and I think its cleaner now.
This now checks if username and password are both not provided and if they are not provided, then it will attempt to find a repository entry in the RepositoryConfig file and it will use the username and password which are provided there.
Before:
[akaris@linux helm]$ helm pull  --repo http://localhost:8080 test
Error: looks like "http://localhost:8080" is not a valid chart repository or cannot be reached: failed to fetch http://localhost:8080/index.yaml : 401 Unauthorized
[akaris@linux helm]$
[akaris@linux helm]$ helm pull  --repo http://localhost:8080 test --username test
Error: looks like "http://localhost:8080" is not a valid chart repository or cannot be reached: failed to fetch http://localhost:8080/index.yaml : 401 Unauthorized
[akaris@linux helm]$
[akaris@linux helm]$ helm pull  --repo http://localhost:8080 test --username test --password test2
Error: looks like "http://localhost:8080" is not a valid chart repository or cannot be reached: failed to fetch http://localhost:8080/index.yaml : 401 Unauthorized
[akaris@linux helm]$
[akaris@linux helm]$ helm pull  --repo http://localhost:8080 test --username test --password test
[akaris@linux helm]$ rm -f test-0.1.0.tgz

After:
[akaris@linux helm]$ bin/helm pull  --repo http://localhost:8080 test --username test --password test
[akaris@linux helm]$ rm -f test-0.1.0.tgz
[akaris@linux helm]$ bin/helm pull  --repo http://localhost:8080 test --username test --password test2
Error: looks like "http://localhost:8080" is not a valid chart repository or cannot be reached: failed to fetch http://localhost:8080/index.yaml : 401 Unauthorized
[akaris@linux helm]$ bin/helm pull  --repo http://localhost:8080 test --username test
Error: looks like "http://localhost:8080" is not a valid chart repository or cannot be reached: failed to fetch http://localhost:8080/index.yaml : 401 Unauthorized
[akaris@linux helm]$ bin/helm pull  --repo http://localhost:8080 test
[akaris@linux helm]$ rm -f test-0.1.0.tgz

This looks cool!

No offense, as I understand it, you shouldn't read data in the local configuration when using --repo (it may cause additional understanding issues).
As in this comment of mine
https://github.com/helm/helm/issues/9762#issuecomment-852943160

@cndoit18 what would be your solution for the problem stated on https://github.com/helm/helm/issues/9599 so?
I still believe this is the best way to do it, the same way docker and podman reuses your local defined credentials when you try to pull an image from a repository specifying its url.

@cndoit18 what would be your solution for the problem stated on #9599 so?
I still believe this is the best way to do it, the same way docker and podman reuses your local defined credentials when you try to pull an image from a repository specifying its url.

(it may cause additional understanding issues)

That can be easily solved by writing a proper help description to the parameter.

I've replied in your issue

@andreaskaris could you please fix the conflict

@mattfarina Done
With current master:
[akaris@linux helm-upstream]$ git log --oneline | head -1
eb994345 Merge pull request #9871 from mattfarina/logging-for-creds
[akaris@linux helm-upstream]$ make
make: Nothing to be done for 'all'.
[akaris@linux helm-upstream]$ bin/helm pull  --repo http://localhost:8080 test
Error: looks like "http://localhost:8080" is not a valid chart repository or cannot be reached: failed to fetch http://localhost:8080/index.yaml : 401 Unauthorized

With the fix rebased:
[akaris@linux helm]$  git log --oneline | head -2
8af97d56 fix(helm): helm pull --repo to use repo creds from helm repos file
eb994345 Merge pull request #9871 from mattfarina/logging-for-creds
[akaris@linux helm]$ make
make: Nothing to be done for 'all'.
[akaris@linux helm]$ bin/helm pull  --repo http://localhost:8080 test
[akaris@linux helm]$

I added this PR and the corresponding issue to the next Helm developer call. I think it's worth discussing to come to a quick resolution so we can see when a change would go in.

Moving this to 3.7.0 as it is a feature request.

@andreaskaris We are looking at this for the 3.8.0 release in January. There's a small amount of feedback on the PR. Would you be able to update it?

@mattfarina I created a follow-up PR addressing the comments: https://github.com/helm/helm/pull/10406

Moving to 3.9.0 as we are cutting the January release today. @felipecrs will do the same with your PR, and we can discuss on an upcoming Helm dev call whether your follow-up PR can supersede this one.

@scottrigby thank you. Whatever is needed to get this fixed. :)


Reducing n_mel_channels to 40: Error of size mismatch

Hi, I'm trying to model a 8khz tacotron2 and waveglow model. In this scheme, I also reduce the n_mel_channels to 40.
"waveglow_config": {
        "n_mel_channels": 40,
        "n_flows": 12,
        "n_group": 8,
        "n_early_every": 4,
        "n_early_size": 2,
        "WN_config": {
            "n_layers": 8,
            "n_channels": 256,
            "kernel_size": 3
        }
    }
}

At the start of waveglow training, i got the error:
  RuntimeError: Given transposed=1, weight of size 40 40 1024, expected input[12, 80, 81] to have 40 channels, but got 80 channels instead
I guess there is a place in the project where, a fixed mel size of 80 is expencted but i could not figure out where it is.
Thanks.

https://github.com/NVIDIA/waveglow/search?q=80&unscoped_q=80

change
https://github.com/NVIDIA/waveglow/blob/master/mel2samp.py#L70#L74
        self.stft = TacotronSTFT(filter_length=filter_length,
                                 hop_length=hop_length,
                                 win_length=win_length,
                                 sampling_rate=sampling_rate,
                                 mel_fmin=mel_fmin, mel_fmax=mel_fmax)

to include
n_mel_channels=40
        self.stft = TacotronSTFT(filter_length=filter_length,
                                 hop_length=hop_length,
                                 win_length=win_length,
                                 n_mel_channels=40,
                                 sampling_rate=sampling_rate,
                                 mel_fmin=mel_fmin, mel_fmax=mel_fmax)

You should also update the denoiser
https://github.com/NVIDIA/waveglow/search?q=80&unscoped_q=80

@CookiePPP, Thank you, it worked flawlesly.


Fixed starting activity / linkify / design support library

Added delegation of Activity-specific Context methods in InternalContextWrapper.

Fix for https://github.com/square/flow/issues/198 and https://github.com/square/flow/issues/193

Hm, the Ci doesn't see android stuff. How weird.

Should use Activity as base context for FlowContextWrapper, apparently


Understand better D3.js force graphs

https://www.pluralsight.com/guides/creating-force-layout-graphs-in-d3
https://www.d3indepth.com/force-layout/
https://gramener.github.io/d3js-playbook/layouts/force.html
https://observablehq.com/@d3/temporal-force-directed-graph
https://observablehq.com/@d3/zoomable-circle-packing
https://observablehq.com/@d3/pack/2?intent=fork
https://observablehq.com/@d3/mobile-patent-suits
https://gist.github.com/hahastudio/68426ce79aabe771ebfeb04cf15b60a6
https://github.com/d3/d3/tree/main/docs/d3-force
https://blog.theodo.com/2015/03/introduction-to-d3js-force-layout/
https://bensullins.com/d3-force-layout-basics/

https://codepen.io/jabrena/pen/zYMWpJw


Add first set of methods that require authentication

Coverage decreased (-4.03%) to 95.966% when pulling fe16f8d2b4ae84e0242eb94ed73d862ccf419bf8 on add-auth-methods into cfa8b186441280e303d09c6ceeaf78143d328ff5 on master.

Coverage remained the same at 100.0% when pulling dc5b1f615e78fcc7c472ea35cbfb4c1716a39558 on add-auth-methods into cfa8b186441280e303d09c6ceeaf78143d328ff5 on master.

@claudiob Do you plan on providing a way to pass access_token/refresh_token as a param to Yt::Channel.new? Using a global setting is awkward when you have multiple users.
I could help with a PR, if you have an idea how that API should look.

I do not plan to do that. I couldn't come up with a good idea for an API.


Follow similar code practices as in utilities package

Signed-off-by: David Cassany<EMAIL_ADDRESS>

I added a NewLogger function that returns a plain sirupsen/logrus instance. This way we can initialize a logger from the our own utilities by default without depending on anything beyond our own types.
@Itxaka @mudler do you think it makes sense merging the partitioner into the utils package? I have mixed feeling with this idea, from one side having everything in one place makes it easier to follow the equivalent coding practices and with a single import you get everything. From the other side if the client utilities grow a lot I'd like not to have everything thrown in a huge package. What you think? Do you have any better argumentation towards one options? mines are pretty weak 😅


Verify sender is properly configured in email

Warn during lakefs load, if the emailer params are not properly configured.

#3302 closes this one


Adding CancellationToken support to async methods

Hi,
I think it would be great if the library had CancellationToken support. After all, EF Core supports this already. It would just be a matter of forwarding the cancellation token to EF Core.

Developer shouldn't use the AuthPermissionsDbContext at all, but use the Roles, Tenant and AuthUser services. Also, cancelling a  CancellationToken in EF Core throws an exception, which isn't a nice outcome - I try to return human-friendly errors.
For those reasons I don't think adding CancellationToken support is worth it.

I meant adding CancellationToken support for the admin services.
For the exception, the exception is a TaskCancelled exception which is the default exception when an exception is cancelled. This is a developer issue not a user issue if a Task is cancelled. So IMO it shouldn't be an IStatusGeneric but an exception that the developer can easily catch and decide what to do.

For example methods like this: https://github.com/JonPSmith/AuthPermissions.AspNetCore/blob/ab4d37f30500707ea9d618b1927cabc305173ce2/AuthPermissions/AdminCode/IAuthUsersAdminService.cs#L29
They could benefit from a CancellationToken so that if a developer uses this, he can decide to cancel the operation after x seconds or simply when the data is no longer needed. And it shouldn't be a IStatusGeneric because then how do you simply catch when the operation is cancelled? With the exception is just a try{} catch(TaskCancelled ex) {} code block, and the developer has the choice of what to do. Either log it, or display an error or whatever. But with the StatusGeneric it's nice for when it's a problem shown to the user directly as you say on the wiki but it has a few downsides like not been able to localize the error messages if displayed to users, or doing all the things you'd do with a simple try catch block are now more difficult.

Hi @emorell96,
I have thought about this and I just don't think its worth it. All the methods access a normal database, not some microservice or HTTP api. Sorry.
If you want to do it then please have your own clone.

Why would this only apply to an http api or a microservice? There's a reason the EF Core team uses cancelation tokens, it avoids having to waste database resources when the data is no longer needed, say the user navigates away before loading the data. This is a backend library and these features are c# features and best practices which allow the library to be used in high load scenarios as well.
I do not understand the reticence specially since it isn't a breaking change and something that I'd be happy to contribute even after you are done with the dev branch to make sure I do not work against what you are doing.
I will still have my own clone but it feels like a shame to have the code diverge on simple things like this :/
Get Outlook for Androidhttps://aka.ms/ghei36

From: Jon P Smith @.>
Sent: Tuesday, June 7, 2022 8:00:14 PM
To: JonPSmith/AuthPermissions.AspNetCore @.>
Cc: Henry @.>; Mention @.>
Subject: Re: [JonPSmith/AuthPermissions.AspNetCore] Adding CancellationToken support to async methods (Issue #44)
Hi @emorell96https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Femorell96&data=05|01||418dfbeca6e3424078b008da48af92ee|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637902216172864595|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=Lk8MP4f1RtV1%2BVD%2BDARliO%2F3IeeMT%2FFGLmt1eYw9tdI%3D&reserved=0,
I have thought about this and I just don't think its worth it. All the methods access a normal database, not some microservice or HTTP api. Sorry.
If you want to do it then please have your own clone.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJonPSmith%2FAuthPermissions.AspNetCore%2Fissues%2F44%23issuecomment-1148997207&data=05|01||418dfbeca6e3424078b008da48af92ee|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637902216172864595|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=vHlhAzVjEZoPachrGm0L5JgOvOVc7sT5PIAnpx0s1x0%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEZXY5ZCMOULJVVF2JSNAA3VN6E25ANCNFSM5YCJTHPQ&data=05|01||418dfbeca6e3424078b008da48af92ee|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637902216172864595|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=mG7yJm1BhhnHae6MGgbOBkW3lnW%2F3w0gNUVJY1RDXzA%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


Fixes issue #2624 (WordNet offset validation)

In issue #2624 @poke1024 asks: "nltk.corpus.wordnet.synset_from_pos_and_offset broken in NLTK 3.5?"
The function is not broken, but the problem is that there is no check of the offset parameter, so when users pass an offset that does not correspond to an existing WordNet synset, a ValueError is (correctly) raised.
However, we can easily do better by checking that the offset parameter is an actual synset offset, since valid offsets equal the 8-digit 0-padded integer found at the start of the corresponding line in the WordNet db, and this allows to eventually return a more helpful error message.

THanks @ekaf (and @poke1024)


Python intellisense fails to find module

Issue Type: Bug
Behaviour
Python intellisense cannot find a module when there exists a directory with the same name of that module in the root of workspace.
Expected vs. Actual
Actual

Expected

Steps to reproduce:
See previous section.
Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.8.6
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Global
Value of the python.languageServer setting: Pylance

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Experiment 'pythonaacf' is active
Experiment 'pythonTensorboardExperiment' is active
Experiment 'PythonPyTorchProfiler' is active
LSP Notebooks experiment is disabled -- Jupyter disabled or not installed
Python interpreter path: .\Python\Python38\python.exe
Starting Pylance language server.

User Settings

languageServer: "Pylance"

terminal
• activateEnvironment: false

What do you have for python.languageServer setting? Please follow the instruction here when filing bugs.

Pylance.
More informations are provided now.

What do you have for python.languageServer setting? Please follow the instruction here when filing bugs.


improved logging controls

The new logging is nice because it's so flexible, but we should still add back in command line -v support to maybe do full logs of everything, or other options like -v for light verbose, -vv for medium, -vvv for heavy, etc.

should maybe also alias debug: true to file_log: full

Please also bring back -v for unit tests (see MpfTestCase::setUp)

What should -v do? Everything set to full logging? Or just what's set as the console_log: settings in the test?

I guess similar to what we had previously. Set everything to log info (but do not overwrite debug if it is set).

Added the unit test switch in the next branch