add setting to make terminal mode  by default

Type: Feature Request

make this checked by default

Marking this as a duplicate of #119. Thanks!


Memory leak in the JDBC client

I'm digging into an issue with OOM errors and a memory leak of some kind using the java-client and jdbc connections to Pinot.  Eventually our Spring Boot application dies with:
Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "AsyncHttpClient-timer-1820-1"
In digging into this I found https://github.com/AsyncHttpClient/async-http-client/issues/1658, the important part (considering I see hundreds of threads marked AsyncHttpClient-timer-X-1) of which is:
AsyncHttpClient-x-x: I/O (twice number of cores)
AsyncHttpClient-timer: timer for timeouts (only one)

Any different number means you're creating multiple clients.

I dug into the Pinot code where this issue seems to be coming from and found where it's creating an AsyncHttpClient:

https://github.com/apache/pinot/blob/3e1aba37deee21ccb2e764afce789e463098246f/pino[…]/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java
https://github.com/apache/pinot/blob/3e1aba37deee21ccb2e764afce789e463098246f/pino[…]rg/apache/pinot/client/controller/PinotControllerTransport.java
https://github.com/apache/pinot/blob/master/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java#L120

The problem here as I see it is that the docs for AsyncHttpClient say
AsyncHttpClient instances are intended to be global resources that share the same lifecycle as the application. Typically, AHC will usually underperform if you create a new client for each request, as it will create new threads and connection pools for each.
which the Pinot java client is clearly not doing, and looking at the classes that create these client it's up to other code that's using them to close them. I think this is resulting in client (and their respective threadpools) being kept around in parallel causing memory leakage.

Since reporting this issue to Slack I have since copied the JDBC Driver into our repository and modified it to only keep a single static copy of the AsyncHttpClient.
This has resulted in a significant reduction in leaked memory, though the issue does not seem 100% solved.
See https://apache-pinot.slack.com/archives/C011C9JHN7R/p1681761095987249 for the original Slack thread on this problem.

Our configuration:
`public DataSource pinotDatabase(PinotConfig pinotConfig) {
Map<String, PinotClientProperties> clients = pinotConfig.getClients();
Optional client = clients.values().stream().findFirst();
    String host;
    Properties props = new Properties();
    props.put("headers.Authorization", toBasicAuthToken(pinotConfig.getUsername(), pinotConfig.getPassword()));
    if (client.isPresent()) {
        PinotClientProperties clientProperties = client.get();
        host = String.format("jdbc:pinot://%s:%s", clientProperties.getHosts().get(0), client.get().getPort());
    } else {
        throw new DataLabException(false,
                "Unable to find cluster name configured under key 'pinot.clients' in application.yml.");
    }

    DriverManagerDataSource dataSource = new DriverManagerDataSource();
    dataSource.setUrl(host);
    dataSource.setDriverClassName("org.apache.pinot.client.PinotDriver");
    dataSource.setConnectionProperties(props);
    return dataSource;
}`

@KKcorps Can you help take a look?


Developer Studio Red Hat Central Installer

skip ci

Codecov Report

Merging #1103 into master will decrease coverage by 0.58%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
- Coverage   94.07%   93.48%   -0.59%
==========================================
  Files          39       40       +1
  Lines        4269     4390     +121
  Branches      468      747     +279
==========================================
+ Hits         4016     4104      +88
- Misses        253      266      +13
- Partials        0       20      +20

Impacted Files
Coverage Δ

browser/model/devstudio-p2.js
76.47% <88.88%> (ø)

browser/model/devstudio-autoinstall.js
97.29% <0%> (-2.71%)
:arrow_down:

browser/model/helpers/hash.js
85.29% <0%> (-2.59%)
:arrow_down:

browser/pages/install/controller.js
79.85% <0%> (-1.73%)
:arrow_down:

browser/model/helpers/downloader.js
96.13% <0%> (-1.66%)
:arrow_down:

browser/pages/account/controller.js
82.11% <0%> (-1.33%)
:arrow_down:

browser/model/jbossfusekaraf.js
95.09% <0%> (-0.83%)
:arrow_down:

browser/services/data.js
91.5% <0%> (-0.79%)
:arrow_down:

browser/pages/confirm/controller.js
87.59% <0%> (-0.78%)
:arrow_down:

browser/model/cdk.js
99.24% <0%> (-0.76%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d94ac...1badc0c. Read the comment docs.

test this

test this

test this

test this


Integer -> Union{Integer,StaticInt}

Sorry, I'm realizing my mass find and replace did a lot of dumb changes.

I should add downstream tests.
(T, #= /home/chriselrod/.julia/dev/LoopVectorization/test/miscellaneous.jl:967 =# @__LINE__()) = (Float32, 967)
Miscellaneous: Error During Test at /home/chriselrod/.julia/dev/LoopVectorization/test/miscellaneous.jl:10
  Got exception outside of a @test
  MethodError: no method matching (LayoutPointers.FastRange{Int32})(::Int64, ::Static.StaticInt{1})
  Closest candidates are:
    (LayoutPointers.FastRange{T})(::F, ::S, ::O) where {T, F, S, O} at ~/.julia/dev/LayoutPointers/src/stridedpointers.jl:229
  Stacktrace:
    [1] memory_reference
      @ ~/.julia/dev/LayoutPointers/src/stridedpointers.jl:238 [inlined]
    [2] stridedpointer_preserve
      @ ~/.julia/dev/LayoutPointers/src/stridedpointers.jl:97 [inlined]
    [3] (::var"#sumprodavx#57")(x::UnitRange{Int32})
      @ Main ~/.julia/dev/LoopVectorization/test/miscellaneous.jl:580

and
typeinf_edge at ./compiler/typeinfer.jl:895
abstract_call_method at ./compiler/abstractinterpretation.jl:601
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:161
abstract_call_known at ./compiler/abstractinterpretation.jl:1695
abstract_call at ./compiler/abstractinterpretation.jl:1767
abstract_call at ./compiler/abstractinterpretation.jl:1732
abstract_eval_statement at ./compiler/abstractinterpretation.jl:1888
typeinf_local at ./compiler/abstractinterpretation.jl:2341
typeinf_nocycle at ./compiler/abstractinterpretation.jl:2418
_typeinf at ./compiler/typeinfer.jl:230
typeinf at ./compiler/typeinfer.jl:213
typeinf_edge at ./compiler/typeinfer.jl:895
abstract_call_method at ./compiler/abstractinterpretation.jl:601
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:161
abstract_call_known at ./compiler/abstractinterpretation.jl:1695
abstract_call at ./compiler/abstractinterpretation.jl:1767
abstract_call at ./compiler/abstractinterpretation.jl:1732
abstract_eval_statement at ./compiler/abstractinterpretation.jl:1888
typeinf_local at ./compiler/abstractinterpretation.jl:2341
typeinf_nocycle at ./compiler/abstractinterpretation.jl:2418
_typeinf at ./compiler/typeinfer.jl:230
typeinf at ./compiler/typeinfer.jl:213
typeinf_edge at ./compiler/typeinfer.jl:895
abstract_call_method at ./compiler/abstractinterpretation.jl:601
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:161
abstract_call at ./compiler/abstractinterpretation.jl:1764
abstract_call at ./compiler/abstractinterpretation.jl:1732
abstract_eval_statement at ./compiler/abstractinterpretation.jl:1888
typeinf_local at ./compiler/abstractinterpretation.jl:2341
typeinf_nocycle at ./compiler/abstractinterpretation.jl:2418
_typeinf at ./compiler/typeinfer.jl:230
typeinf at ./compiler/typeinfer.jl:213
typeinf_ext at ./compiler/typeinfer.jl:986
typeinf_ext_toplevel at ./compiler/typeinfer.jl:1019
typeinf_ext_toplevel at ./compiler/typeinfer.jl:1015
jfptr_typeinf_ext_toplevel_15682 at /home/chriselrod/Documents/languages/juliamaster/usr/lib/julia/sys.so (unknown line)
_jl_invoke at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:2392 [inlined]
ijl_apply_generic at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:2574 [inlined]
jl_apply at /home/chriselrod/Documents/languages/juliamaster/src/julia.h:1841 [inlined]
jl_type_infer at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:317
jl_generate_fptr_impl at /home/chriselrod/Documents/languages/juliamaster/src/jitlayers.cpp:344
jl_compile_method_internal at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:2106
jl_compile_method_internal at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:2050 [inlined]
_jl_invoke at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:2384 [inlined]
ijl_apply_generic at /home/chriselrod/Documents/languages/juliamaster/src/gf.c:2574
jl_apply at /home/chriselrod/Documents/languages/juliamaster/src/julia.h:1841 [inlined]
do_call at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:126
eval_value at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:215
eval_stmt_value at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:166 [inlined]
eval_body at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:612
eval_body at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:522
eval_body at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:522
jl_interpret_toplevel_thunk at /home/chriselrod/Documents/languages/juliamaster/src/interpreter.c:750
macro expansion at /home/chriselrod/.julia/dev/LoopVectorization/test/miscellaneous.jl:1117
jl_toplevel_eval_flex at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:912
jl_toplevel_eval_flex at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:856
ijl_toplevel_eval at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:921 [inlined]
ijl_toplevel_eval_in at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1349
_include at ./loading.jl:1409
include at ./client.jl:472
unknown function (ip: 0x7f07f01fe5e2)
macro expansion at ./timing.jl:267 [inlined]
macro expansion at /home/chriselrod/.julia/dev/LoopVectorization/test/grouptests.jl:73 [inlined]
macro expansion at ./timing.jl:267 [inlined]
macro expansion at /home/chriselrod/.julia/dev/LoopVectorization/test/grouptests.jl:70 [inlined]
macro expansion at /home/chriselrod/Documents/languages/juliamaster/usr/share/julia/stdlib/v1.9/Test/src/Test.jl:1385 [inlined]
macro expansion at /home/chriselrod/.julia/dev/LoopVectorization/test/grouptests.jl:9 [inlined]
top-level scope at ./timing.jl:267
jl_toplevel_eval_flex at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:903
jl_toplevel_eval_flex at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:856
ijl_toplevel_eval at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:921 [inlined]
ijl_toplevel_eval_in at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1349
_include at ./loading.jl:1409
include at ./client.jl:472 [inlined]
top-level scope at /home/chriselrod/.julia/dev/LoopVectorization/test/runtests.jl:54
jl_toplevel_eval_flex at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:903
jl_toplevel_eval_flex at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:856
ijl_toplevel_eval at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:921 [inlined]
ijl_toplevel_eval_in at /home/chriselrod/Documents/languages/juliamaster/src/toplevel.c:971
eval at ./boot.jl:370 [inlined]
include_string at ./loading.jl:1349
_include at ./loading.jl:1409
include at ./Base.jl:428
jfptr_include_37280 at /home/chriselrod/Documents/languages/juliamaster/usr/lib/julia/sys.so (unknown line)
exec_options at ./client.jl:299
_start at ./client.jl:516
jfptr__start_32975 at /home/chriselrod/Documents/languages/juliamaster/usr/lib/julia/sys.so (unknown line)
jl_apply at /home/chriselrod/Documents/languages/juliamaster/src/julia.h:1841 [inlined]
true_main at /home/chriselrod/Documents/languages/juliamaster/src/jlapi.c:566
jl_repl_entrypoint at /home/chriselrod/Documents/languages/juliamaster/src/jlapi.c:710
main at /home/chriselrod/Documents/languages/juliamaster/cli/loader_exe.c:59
__libc_start_call_main at /lib64/libc.so.6 (unknown line)
__libc_start_main at /lib64/libc.so.6 (unknown line)
_start at /home/chriselrod/Documents/languages/juliamaster/usr/bin/julia (unknown line)
┌ Warning: #= /home/chriselrod/.julia/dev/LoopVectorization/test/copy.jl:182 =#:
│ `LoopVectorization.check_args` on your inputs failed; running fallback `@inbounds @fastmath` loop instead.
│ Use `warn_check_args=false`, e.g. `@turbo warn_check_args=false ...`, to disable this warning.
└ @ Main ~/.julia/dev/LoopVectorization/src/condense_loopset.jl:995
ERROR: LoadError: Some tests did not pass: 2489 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /home/chriselrod/.julia/dev/LoopVectorization/test/grouptests.jl:7
in expression starting at /home/chriselrod/.julia/dev/LoopVectorization/test/runtests.jl:9
Julia Version 1.9.0-DEV.633

with the top of that trace caught in a loop/repeating endlessly.

Is that one an issue with the recent change to LayoutPointers?

Is that one an issue with the recent change to LayoutPointers?

Yes. https://github.com/JuliaSIMD/LayoutPointers.jl/commit/327ebf0312463d38da256748c7af8664ca9413a7
I'm manually running more tests locally to make sure releasing all of these won't cause regressions.

Is that one an issue with the recent change to LayoutPointers?

Yes. JuliaSIMD/LayoutPointers.jl@327ebf0 I'm manually running more tests locally to make sure releasing all of these won't cause regressions.

Sorry. It looks like you've already taken care of it, but let me know if you need me to do anything.

I thought that Int was the fastest type for iteration because it matched the machine's bit size? Is there some other advantage to indexing with other bit types?

I thought that Int was the fastest type for iteration because it matched the machine's bit size? Is there some other advantage to indexing with other bit types?

LoopVectorization assumes UpperBoundedIntegers are smaller than a statically known upper bound.
Octavian uses them: https://github.com/JuliaLinearAlgebra/Octavian.jl/blob/82a68e727f1ec2647664c801df661359c08c376a/src/macrokernels.jl#L41

But, yeah, generally Int/UInt should be "fastest".
Some operations on Int32 may actually be faster on x86, because some e versions of instructions are 1 byte smaller than the r versions, reducing code size.
However, actually indexing requires 64 bit integers (except for some SIMD instructions like gather/scatter that can use 32 bit or 64 bit); cleaned a bit:
# @code_native debuginfo = :none syntax = :intel Base.unsafe_getindex(x, 3)
	mov	rax, qword ptr [rdi]
	vmovsd	xmm0, qword ptr [rax + 8*rsi - 8] # xmm0 = mem[0],zero
	ret

# @code_native debuginfo = :none syntax = :intel Base.unsafe_getindex(x, 3 % Int32)
	movsxd	rax, esi
	mov	rcx, qword ptr [rdi]
	vmovsd	xmm0, qword ptr [rcx + 8*rax - 8] # xmm0 = mem[0],zero
	ret

The 64 bit index version loads the pointer to the array x, and then indexes into it.
The 32 bit index version is the same, except it first extends the 32 bit index into a 64 bit index.
Obviously using 32 bits isn't going to decrease code size if it adds more code.

With respect to FastRange, it is to represent ranges of different types.
FastRange is used when you're doing something other than using integers to index, so it wants to represent the type of the original range. If you're SIMD-ing it, smaller types are of course faster.

Is there any benefit to using floats instead of integers for indexing?

Is there any benefit to using floats instead of integers for indexing?

Ha ha, no, integers are definitely way better.
But JavaScript and R both default to floats.

Gotcha. Thank you for patiently answering my questions.

No problem.
Maybe "way" is an exaggeration, because converting floating point to integers isn't that expensive, but floating point cannot be used directly. Thus, it's nicer to avoid the need for conversion in the first place.
Also, consider that an Alder Lake performance core can do 5 integer adds/clock cycle, with a latency of a single clock cycle vs 2 floating point adds/clock cycle, with a latency of 3 cycles.


[Bug] Shift-Mouse Wheel throws an error on macOS

When I try to rotate a token using shift + mouse wheel, I’m getting the error Model Validation Errors [TokenDocument.rotation]: must be a finite number
The error message in the console:

This is maybe related to this: https://github.com/foundryvtt/foundryvtt/issues/8111
I’m on Foundry v10.291 with Zoom/Pan Options v1.8.4. Does not happen when I disable Zoom/Pan Options.
I’m using a high-resolution mouse with the Trackpad mode.
Thanks!

Huh, what do you know. I don’t know how I missed the update. Sorry about that. Works with 1.86. Thanks!


feat: ToC icons

Describe the feature
If I add an icon component before a header:

The icon could also show up in the table of contents.
Additional information

[ ] Would you be willing to help implement this feature?

Currently there is no way to do this unfortunatly. Nuxt content ignores everything that is not text in the headers when generating TOC.
An alternative is to use emojis instead.
p.s. there is an issue in Nuxt Content about this: https://github.com/nuxt/content/issues/2842

Thanks for the suggestion!
Unfortunatly, there is currently no way to do this. Nuxt content ignores everything that is not text in the headers when generating TOC. An alternative would be to use emojis instead.
p.s. there is an issue in Nuxt Content about this: nuxt/content#2842

Ah, damn ☹

Should probably mark this with the upstream label @ZTL-UwU


Combine installation files into a single JSON Fragment Extension

Since version 1.7, Windows Terminal added support for JSON Fragment Extensions

Windows Terminal version 1.7 Release
Windows Terminal version 1.7 Blog post

This allows for a user to put a single file into a local config directory that extends the default configuration JSON.
Pros:
This could streamline the installation to only moving a folder instead of copying and pasting from multiple files, also Windows users are more used to drag and droping instead of editing config files.
Cons:
As "Themes" is a relatively new feature to Windows Terminal, it is not yet implemented in JSON Fragment Extensions, their inclusion seem to be coming until version 1.20 (Source).
This could either mean we can only streamline half of the process at the time, or complicate the installation more by introducing a second method.
I'll add a PR to this issue with the schemes as a JSON Fragment Extension and we can leave it cooking until v1.20 releases and I can add the schemes to the fragment too.
In the meantime I'll leave this issue for consideration.

PR for this issue


[DE] Test sentences for "Beschattung" in cover_HassTurnOn.yaml

please add these test sentences in #2463


BUG - runs fail with error in int_zendesk__field_history_pivot

Are you a current Fivetran customer?
Yes. Maria Riolo, Data Analyst at Zearn
Describe the bug
Upon running, we get the error:
Database Error in model int_zendesk__field_history_pivot (models/ticket_history/int_zendesk__field_history_pivot.sql)
  syntax error at or near "pivot"
  LINE 123: ), pivot as (
               ^

Our daily runs started failing Dec 10, 2021, but at the time we hadn't made any changes to our own code since Dec 3.
Steps to reproduce
dbt run -m int_zendesk__field_history_pivot
(or just dbt run)
Project variables configuration

# Name your package! Package names should contain only lowercase characters
# and underscores. A good package name should reflect your organization's
# name or the intended use of these models
name: 'zearn_redshift'
version: 1.0.0
config-version: 2

# This setting configures which "profile" dbt uses for this project. Profiles contain
# database connection information, and should be configured in the  ~/.dbt/profiles.yml file
profile: 'zearn-redshift'

# These configurations specify where dbt should look for different types of files.
# The `source-paths` config, for example, states that source models can be found
# in the "models/" directory. You probably won't need to change these!
source-paths: ["models"]
analysis-paths: ["analysis"]
test-paths: ["tests"]
data-paths: ["data"]
macro-paths: ["macros"]

target-path: "target"  # directory which will store compiled SQL files
clean-targets:         # directories to be removed by `dbt clean`
  - "target"
  - "dbt_modules"

on-run-start:
  # create schemas so we don't run into errors with the on-run-end hooks
  # if only doing a partial build or e.g. just running dbt seed
  - "CREATE SCHEMA IF NOT EXISTS \"{{ target.schema }}_marts\""
  - "CREATE SCHEMA IF NOT EXISTS \"{{ target.schema }}_staging\""
  - "CREATE SCHEMA IF NOT EXISTS \"{{ target.schema }}_exports\""
  - "CREATE SCHEMA IF NOT EXISTS \"{{ target.schema }}_zendesk_staging\""
  - "CREATE SCHEMA IF NOT EXISTS \"{{ target.schema }}_ad_hoc\""

on-run-end:
  - "GRANT USAGE ON SCHEMA \"{{ target.schema }}_marts\" to group looker, group zearn_analytics, group zearn_product"
  - "GRANT USAGE ON SCHEMA \"{{ target.schema }}_exports\" to jitterbit_sfdc_export, group looker, group zearn_analytics, group zearn_product"
  - "GRANT USAGE ON SCHEMA \"{{ target.schema }}_staging\" to group looker, group zearn_analytics, group zearn_product"
  - "GRANT USAGE ON SCHEMA \"{{ target.schema }}_zendesk_staging\" to group looker, group zearn_analytics, group zearn_product"
  - "GRANT SELECT ON ALL TABLES IN SCHEMA \"{{ target.schema }}_marts\" TO group looker, group zearn_analytics, group zearn_product"
  - "GRANT SELECT ON ALL TABLES IN SCHEMA \"{{ target.schema }}_exports\" TO jitterbit_sfdc_export, group zearn_analytics"
  - "GRANT SELECT ON ALL TABLES IN SCHEMA \"{{ target.schema }}_staging\" TO group zearn_analytics, group looker"
  - "GRANT SELECT ON ALL TABLES IN SCHEMA \"{{ target.schema }}_ad_hoc\" TO group zearn_analytics, group looker"
  - "GRANT SELECT ON ALL TABLES IN SCHEMA \"{{ target.schema }}_zendesk_staging\" TO group zearn_analytics, group looker"

# You can define configurations for models in the `source-paths` directory here.
# Using these configurations, you can enable or disable models, change how they
# are materialized, and more!

# In this example config, we tell dbt to build all models in the example/ directory
# as views (the default). These settings can be overridden in the individual model files
# using the `{{ config(...) }}` macro.
models:
  +bind: false

  zearn_redshift:
    +materialized: view
    staging:
      +materialized: view
      +schema: staging
      classification:
        +materialized: table
        support_tables:
          +materialized: table
      rostering:
        +materialized: table
      usage:
        +materialized: table
        +dist: user_id
        +sort: event_type, event_type_clean, created_at
    marts:
      +materialized: view
      +schema: marts
      summaries:
        +materialized: table
        +dist: user_id
        +sort: daydate
      exports:
        +materialized: table
        +schema: exports
    ad_hoc:
      +materialized: table
      +schema: ad_hoc
  zendesk:
    +schema: staging
    intermediate:
      +schema: staging
    sla_policy:
      +schema: staging
    ticket_history:
      +schema: staging
vars:
  school_years: ['2012-2013', '2013-2014', '2014-2015', '2015-2016', '2016-2017', '2017-2018', '2018-2019', '2019-2020', '2020-2021', '2021-2022']
  rostering_school_years: ['2016-2017', '2017-2018', '2018-2019', '2019-2020', '2020-2021', '2021-2022']
  random_seed:<PHONE_NUMBER>989899184
  burbio_table_date: "2020-01-01" #default value needed to generate docs
  burbio_file_name: fake_file.csv #default value needed to generate docs
  district_student_info_district_id: 0 #default value needed to generate docs
  zendesk_source:
    zendesk_database: production
    zendesk_schema: ft_zendesk

Package Version
packages:
  - package: dbt-labs/dbt_utils
    version: [">=0.3.0"]
  - package: fivetran/zendesk
    version: [">=0.7.0"]

Warehouse

[ ] BigQuery
[x] Redshift
[ ] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Please indicate the level of urgency
We do use our zendesk data. It's not an emergency right now, but it would be a big help to get it resolved before the end of the week so that our nightly syncs will be up and running over our winter break.
Are you interested in contributing to this package?

[ ] Yes, I can do this and open a PR for your review.
[ ] Possibly, but I'm not quite sure how to do this. I'd be happy to do a live coding session with someone to get this fixed.
[x] No, I'd prefer if someone else fixed this.  I don't have the time and/or don't know what the root cause of the problem is.

Hi @annichia thanks so much for opening this issue!
this is actually an issue we saw come up in another Redshift package user a few days ago. The next release of the Zendesk package (this week) will rename the pivot CTE to pivots so this issue will no longer happen for Redshift users. I will post back here once we have merged and released the fix.

Hey @annichia 👋
Thanks again for opening this issue. I wanted to share some news that this fix have been applied to the latest v0.7.1 release of the zendesk package! Feel free to upgrade to the latest version and you should see the error be resolved.
Feel free to open another issue if you encounter any other bugs or want to chat more about this ticket. Thanks again!


Fix typo in relic locations

Castle 2 was being listed as 0x18-0x1c instead of 0x17-0x1b
You can see the changes in logic here: https://docs.google.com/spreadsheets/d/13RDlbX7yqajZNZJiAsGe2VIx7kHEMbr9sJjnp0R-E4A/edit?usp=sharing
Notice how Echo of Bat could end up at Heart of Vlad location before but not after this change (sheet 1 vs sheet 2)

This is really helpful, thanks a lot


model: removed redundant field is_update

Thank you for the PR. I understand your motivation behind this change. However, we need this for literature, as it helps us determine if an update is needed.

Understood, I though it was about the origin (as literature also has HEP_CREATE and HEP_UPDATE), not about the state of it.
Closing


Make getter/setters to fit RFC 344

Relative link RFC/0344.
Clearly, we just need to rename set_ methods in normal structs.

You might be able to reduce some boilerplate with https://github.com/Hoverbear/getset/ :)


add documentation link

trivial change: adds documentation link in connector metadata
Will not become effective until next release

Skipping review, as this is trivial change


syntax highlighting not working with zsh 5.9 and zsh-vi-mode

After updating to the latest zsh version. The zsh-syntax-highlighting does not work anymore.
OS: Archlinux
Version: zsh 5.9 (x86_64-pc-linux-gnu)

Related Config:
plugins=(
    zsh-autosuggestions
    zsh-syntax-highlighting
    # vi-mode
    zsh-vi-mode
    git
    # forgit
    # sudo
    # macos
    web-search
    # copydir
    # copyfile
    # copybuffer
    dirhistory
    colored-man-pages
    # vscode
    # xcode
)

Same issue. Also on Arch. Updated zsh to 5.9 a few hours ago. Not using ohmyzsh or anything.
Haven't changed anything config related. Also using  dracula zsh-syntax-highlighting theme
ZSH_HIGHLIGHT_HIGHLIGHTERS=(main cursor)
typeset -gA ZSH_HIGHLIGHT_STYLES

ZSH_HIGHLIGHT_STYLES[builtin]='fg=#8BE9FD'
ZSH_HIGHLIGHT_STYLES[reserved-word]='fg=#8BE9FD'
ZSH_HIGHLIGHT_STYLES[hashed-command]='fg=#8BE9FD'

ZSH_HIGHLIGHT_STYLES[commandseparator]='fg=#FF79C6'
ZSH_HIGHLIGHT_STYLES[command-substitution-delimiter]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[command-substitution-delimiter-unquoted]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[process-substitution-delimiter]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[back-quoted-argument-delimiter]='fg=#FF79C6'
ZSH_HIGHLIGHT_STYLES[back-double-quoted-argument]='fg=#FF79C6'
ZSH_HIGHLIGHT_STYLES[back-dollar-quoted-argument]='fg=#FF79C6'

ZSH_HIGHLIGHT_STYLES[command-substitution-quoted]='fg=#F1FA8C'
ZSH_HIGHLIGHT_STYLES[command-substitution-delimiter-quoted]='fg=#F1FA8C'
ZSH_HIGHLIGHT_STYLES[single-quoted-argument]='fg=#F1FA8C'
ZSH_HIGHLIGHT_STYLES[single-quoted-argument-unclosed]='fg=#FF5555'
ZSH_HIGHLIGHT_STYLES[double-quoted-argument]='fg=#F1FA8C'
ZSH_HIGHLIGHT_STYLES[double-quoted-argument-unclosed]='fg=#FF5555'
ZSH_HIGHLIGHT_STYLES[rc-quote]='fg=#F1FA8C'

ZSH_HIGHLIGHT_STYLES[dollar-quoted-argument]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[dollar-quoted-argument-unclosed]='fg=#FF5555'
ZSH_HIGHLIGHT_STYLES[dollar-double-quoted-argument]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[assign]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[named-fd]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[numeric-fd]='fg=#F8F8F2'

ZSH_HIGHLIGHT_STYLES[unknown-token]='fg=#FF5555'
ZSH_HIGHLIGHT_STYLES[path]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[path_pathseparator]='fg=#FF79C6'
ZSH_HIGHLIGHT_STYLES[path_prefix]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[path_prefix_pathseparator]='fg=#FF79C6'
ZSH_HIGHLIGHT_STYLES[globbing]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[history-expansion]='fg=#BD93F9'
#ZSH_HIGHLIGHT_STYLES[command-substitution]='fg=?'
#ZSH_HIGHLIGHT_STYLES[command-substitution-unquoted]='fg=?'
#ZSH_HIGHLIGHT_STYLES[process-substitution]='fg=?'
#ZSH_HIGHLIGHT_STYLES[arithmetic-expansion]='fg=?'
ZSH_HIGHLIGHT_STYLES[back-quoted-argument-unclosed]='fg=#FF5555'
ZSH_HIGHLIGHT_STYLES[redirection]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[arg0]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[default]='fg=#F8F8F2'
ZSH_HIGHLIGHT_STYLES[cursor]='fg=#FFFFFF'

source $HOME/.config/zsh/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh

Here is an alternative for zsh-syntax-highlight. It works fine on my machine.
https://github.com/zdharma/fast-syntax-highlighting
I guess the issue is casued by the deprecated zsh funcitons in version 5.9. There is a compatability section in 5.9 release note.

I'm running on 5.9 without issues. Since you're also running z-asug, the issue may be related to zsh-users/zsh-autosuggestions#529 . Can you see if syntax highlighting returns with z-asug commented out?

I'm also running zsh 5.9. For me syntax highlighting works fine until I add zsh-vi-mode to the plugins list in my zshrc. (Using oh-my-zsh plugins). Before zsh 5.9 both zsh-syntax-highlighting and zsh-vi-mode worked like a charm together.

I am also getting this same issue
plugins=(
zsh-syntax-highlighting
zsh-autosuggestions
zsh-vi-mode
sudo
command-not-found
)
Commenting out zsh-autosuggestions did not fix it for me

Are y'all running the latest z-sy-h master?  If so, say so explicitly.  If not, upgrade and try again.
Excuse brevity.  Will reply more later.

Yes running the latest version on master installed with the oh-my-zsh installation directions (commit id "caa749d030d22168445c4cb97befd406d2828db0"). For me it is still broken.

I'm using the latest commits for both plugins, and am experiencing the same bug.
zsh-syntax-highlighting = caa749d
zsh-vi-mode = 9e909d0
If I set the zsh-vi-mode option, ZVM_INIT_MODE='sourcing', then syntax highlighting works again.
Hopefully this help debug.

@kstolp Thanks a lot.
I'm going to tentatively assume that everyone here uses the zsh-vi-mode plugin.  (The third-party plugin linked above; not merely the builtin bindkey -v functionality.)  If that's not the case for anyone, speak up.
I suspect the problem has to do with how the zsh-vi-mode plugin's use of zle-line-pre-redraw, since that widget is used by default by z-sy-h under zsh 5.9 but not (by default) under older zsh's.
There seem to be several problems with the zsh-vi-mode plugin's approach:

zvm_define_widget() lacks ${(q)}'s on its eval.
zvm_zle-line-pre-redraw() doesn't inspect $rawfunc (set by zvm_widget_wrapper(), which zvm_define_widget() arranges to be called), so any pre-redraw hooks installed prior to zsh-vi-mode aren't run at all. (They probably shouldn't fix that by changing those functions I just named but by removing those functions altogether and using add-zle-hook-widget instead.)
That also goes for the zsh-vi-mode plugin's zle-line-init and zle-line-finish wrappers, at least.
zvm_zle-line-pre-redraw() calls zvm_update_highlight() which, if I'm reading its code correctly, could remove some $region_highlight entries from plugins other than itself.  (Note that multiple highlights can sometimes combine; e.g., region_highlight=("0 5 fg=red" "0 5 bold,underline").)  It should use the memo= feature of zsh 5.9 to only remove its own entries.  (Note that z-sy-h doesn't use redrawhook on zsh versions that lack the memo= feature precisely in order to avoid breaking other plugins.)

The most important of these is (2) which, if I'm reading the zsh-vi-mode plugin's correctly, causes that plugin to trample on plugins installed prior to itself.
I don't see anything z-sy-h can do about a plugin that runs after z-sy-h's init code and arranges for z-sy-h's add-zle-hook-widget-registered hook not to be called.
/cc @jeffreytse

Perhaps the following?  I don't have an environment to test it in:
diff --git a/zsh-vi-mode.zsh b/zsh-vi-mode.zsh
index c8cce0b..abea50f 100644
--- a/zsh-vi-mode.zsh
+++ b/zsh-vi-mode.zsh
@@ -3253,7 +3253,8 @@ function zvm_init() {
   zvm_define_widget zvm_switch_keyword

   # Override standard widgets
-  zvm_define_widget zle-line-pre-redraw zvm_zle-line-pre-redraw
+  autoload add-zle-hook-widget
+  add-zle-hook-widget zle-line-pre-redraw zvm_zle-line-pre-redraw

   # Ensure the correct cursor style when an interactive program
   # (e.g. vim, bash, etc.) starts and exits

Here is an alternative for zsh-syntax-highlight. It works fine on my machine.
https://github.com/zdharma-continuum/fast-syntax-highlighting

FWIW there's been a proposal to merge that back into this project.  See https://github.com/zdharma-continuum/fast-syntax-highlighting/issues/8

I guess the issue is casued by the deprecated zsh funcitons in version 5.9. There is a compatability section in 5.9 release note.

Deprecations wouldn't cause regressions; incompatible changes would be required for that.
The one entry in zsh's list of incompatibilities [in its README file] that's related to z-sy-h is the region_highlight change.  It's possible we could see 5.9-only bugs caused by the zsh_highlight__memo_feature probe starting to succeed.  I don't think that's what's actually happening here (see above), but still, good call.

Don't know if this might be the cause for someone as well but, I solved this issue by copying the zsh-syntax-highlight file from this repo to my machine.
As you can see, apparently there was some random code, I don't really know why.
I do not know how to see the version of the plugin, but will be happy to update this comment if someone tells me how.
164a165
> <<<<<<< Updated upstream
169a171,176
> =======
>         # On zsh version <IP_ADDRESS> between the aforementioned commit and the
>         # first Config/version.mk bump after it (which, at the time of writing,
>         # is yet to come), this condition will false negative.
>         if is-at-least <IP_ADDRESS> $ZSH_VERSION.0.0; then
> >>>>>>> Stashed changes
417c424
< #    function — a catch-22.
---
> #    function — a catch-22.
418a426
> <<<<<<< Updated upstream
420a429,433
> =======
> #    See _zsh_highlight for the magic version number.  (The use of <IP_ADDRESS>
> #    rather than <IP_ADDRESS> as in the _zsh_highlight is deliberate.)
> if is-at-least <IP_ADDRESS> $ZSH_VERSION.0.0 && _zsh_highlight__function_callable_p add-zle-hook-widget
> >>>>>>> Stashed changes

The information that I know is that I use the plugin with oh-my-zsh and my system is Arch Linux 5.17.9
This is the first time that I try to do something like this, so if it's wrong or I can do something better, I'll be happy to do it.

@jhony75 Let's break this down:

Don't know if this might be the cause for someone as well but, I solved this issue by copying the zsh-syntax-highlight file from this repo to my machine.

In general, replacing a single file is not guaranteed to work, since the various files may have interdependencies.

As you can see, apparently there was some random code, I don't really know why. I do not know how to see the version of the plugin, but will be happy to update this comment if someone tells me how.

typeset -p ZSH_VERSION ZSH_PATCHLEVEL ZSH_HIGHLIGHT_VERSION ZSH_HIGHLIGHT_REVISION.  If that prints HEAD, then run git rev-parse HEAD in the plugin's directory as well (see #863).

164a165
> <<<<<<< Updated upstream
169a171,176
> =======
>         # On zsh version <IP_ADDRESS> between the aforementioned commit and the
>         # first Config/version.mk bump after it (which, at the time of writing,
>         # is yet to come), this condition will false negative.
>         if is-at-least <IP_ADDRESS> $ZSH_VERSION.0.0; then
> >>>>>>> Stashed changes
417c424
< #    function — a catch-22.
---
> #    function — a catch-22.
418a426
> <<<<<<< Updated upstream
420a429,433
> =======
> #    See _zsh_highlight for the magic version number.  (The use of <IP_ADDRESS>
> #    rather than <IP_ADDRESS> as in the _zsh_highlight is deliberate.)
> if is-at-least <IP_ADDRESS> $ZSH_VERSION.0.0 && _zsh_highlight__function_callable_p add-zle-hook-widget
> >>>>>>> Stashed changes

OK.  First of all, the is-at-least <IP_ADDRESS> must be from https://github.com/zsh-users/zsh-syntax-highlighting/issues/857#issuecomment-1038295881, as no other place in this repository has <IP_ADDRESS> here.
The diff posted shows that the second file (the bar in diff foo bar) had conflict markers.  So, you probably applied the patch in the linked comment, then updated (pulled), which caused a text conflict, which you "resolved" by manually downloading the conflicted file.  This would "work" for now, but you won't be able to pull any further changes to that file to your worktree.  (The fetch would succeed but the fast-forward merge wouldn't.)
You probably need to resolve the conflict now.  Run git status without arguments in z-sy-h's directory and it should tell you what to do.  If that doesn't work, you can always clone the z-sy-h repository anew.  (It's possible to solve conflicts without re-cloning, of course, but the incantations for that are more likely to cause inadvertent data loss if used incorrectly.)

The information that I know is that I use the plugin with oh-my-zsh and my system is Arch Linux 5.17.9
This is the first time that I try to do something like this, so if it's wrong or I can do something better, I'll be happy to do it.

You'll almost always want to run diff -u foo bar rather than merely diff foo bar (unified diffs are the de facto standard, and they include context which helps both human readers and patch(1)), and git diff rather than diff -u foo bar when the files being diffed are in git.  (Nevertheless, there's no need to post the above diff again.)

Met this problem on MacOS too.

I've got this problem as well with zsh 5.9 (x86_64-pc-linux-gnu) but I'm not using zsh-vi-mode. I've only got 3 plugins setup (and some color customizations) but even just using zsh-syntax-highlighting by itself I'm still not getting any syntax highlighting anymore (since about a month back). Strangely zdharma-continuum/fast-syntax-highlighting does still work.

I have the same problem. On my Mac, the version of Zsh is  zsh 5.8.1 (x86_64-apple-darwin21.0)。
I tried almost everything I could find, but Zsh syntax highlighting still didn't work

@mohkale You don't have zsh-vi-mode so you're seeing a different issue.  Open a new ticket please and continue there.  Post there a minimal reproduction recipe please (without zgen; just source manually as few plugins and other settings as needed to reproduce the problem).

@yuze1216 z-sy-h won't use the redrawhook code under 5.8.1 by default, so you're probably seeing another issue.  Open a new ticket please with the details requested in my comment to @mohkale just now.

@yuze1216 z-sy-h won't use the redrawhook code under 5.8.1 by default, so you're probably seeing another issue. Open a new ticket please with the details requested in my comment to @mohkale just now.

Sorry, I tried in mine Find Zsh syntax highlighting Zsh to make it work, but it still doesn't work

Thank you very much. I think I know the problem. It's my fault. Thank you

Perhaps the following? I don't have an environment to test it in:
diff --git a/zsh-vi-mode.zsh b/zsh-vi-mode.zsh
index c8cce0b..abea50f 100644
--- a/zsh-vi-mode.zsh
+++ b/zsh-vi-mode.zsh
@@ -3253,7 +3253,8 @@ function zvm_init() {
   zvm_define_widget zvm_switch_keyword

   # Override standard widgets
-  zvm_define_widget zle-line-pre-redraw zvm_zle-line-pre-redraw
+  autoload add-zle-hook-widget
+  add-zle-hook-widget zle-line-pre-redraw zvm_zle-line-pre-redraw

   # Ensure the correct cursor style when an interactive program
   # (e.g. vim, bash, etc.) starts and exits

It seems to work for me.

Perhaps the following? I don't have an environment to test it in:
diff --git a/zsh-vi-mode.zsh b/zsh-vi-mode.zsh
index c8cce0b..abea50f 100644
--- a/zsh-vi-mode.zsh
+++ b/zsh-vi-mode.zsh
@@ -3253,7 +3253,8 @@ function zvm_init() {
   zvm_define_widget zvm_switch_keyword

   # Override standard widgets
-  zvm_define_widget zle-line-pre-redraw zvm_zle-line-pre-redraw
+  autoload add-zle-hook-widget
+  add-zle-hook-widget zle-line-pre-redraw zvm_zle-line-pre-redraw

   # Ensure the correct cursor style when an interactive program
   # (e.g. vim, bash, etc.) starts and exits

It seems to work for me.

This fixes the issue for me too,

Sorry to co-opt this issue, I fixed the unrelated issue I described above and didn't think it made sense to make a new issue just to close it. In my case I had zsh-users/zsh-autosuggestions setup after zsh-users/zsh-syntax-highlighting and that was causing the issue. The FAQ mentioned zsh-syntax-highlighting should be sourced last and moving it to the end of the list of plugins I setup fixed it for me. Don't know why this wasn't an issue before (I suspect zsh-autosuggestions changed how they interact with zle and it inadvertently broke my zsh-syntax-highlighting setup).

It seems to work for me.

This fixes the issue for me too,

Thanks for reporting back.  As the patch is to zsh-vi-mode, could someone open an issue or PR there, please, and cross-link this issue and that one?

@mohkale Thanks for following up.  I'll say no more as it's an unrelated issue :)

Perhaps the following? I don't have an environment to test it in:
diff --git a/zsh-vi-mode.zsh b/zsh-vi-mode.zsh
index c8cce0b..abea50f 100644
--- a/zsh-vi-mode.zsh
+++ b/zsh-vi-mode.zsh
@@ -3253,7 +3253,8 @@ function zvm_init() {
   zvm_define_widget zvm_switch_keyword

   # Override standard widgets
-  zvm_define_widget zle-line-pre-redraw zvm_zle-line-pre-redraw
+  autoload add-zle-hook-widget
+  add-zle-hook-widget zle-line-pre-redraw zvm_zle-line-pre-redraw

   # Ensure the correct cursor style when an interactive program
   # (e.g. vim, bash, etc.) starts and exits

Thank you very much!! That solved the problem. Now I can use zsh-syntax-highlighting and zsh-vi-mode together without any problem.

Triage: issue is in another codebase; nothing we can do on our end to fix it or to work around it; patch for the other project has been devised, tested, and PR'd to that project; thus: closing as "nothing further for us to do".  The issue is still reproducible with latest z-sy-h and latest zsh-vi-mode, true; if that affects you, apply the above patch to your copy of zsh-vi-mode.
@fbearoff Thanks for submitting the patch upstream as a PR!

enable auto-suggestions based on the history
if [ -f /usr/share/zsh-autosuggestions/zsh-autosuggestions.zsh ]; then
. /usr/share/zsh-autosuggestions/zsh-autosuggestions.zsh
# change suggestion color
ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE='fg=102'
fi
replace ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE
to this value:
ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE='fg=102'


feat(notification): add notification and header-notification-panel components

Summary

Notification panel inside header flyout menu
Added separate Notification component with story
As per discussion with UX, Made changes in and use <kyn-card> as wrapper for notification component
Added Header story for Notification panel
used foundation <kd-card> for notification component

ADO Story
https://dev.azure.com/Kyndryl/Shidoka - Bridge Design System/_workitems/edit/1625672
Checklist

[x] Used Conventional Commit messages as outlined in the contributing guide.

[x] Noted breaking changes (if any).

[x] Documented/updated all props, events, slots, parts, etc with JSDoc.

[x] Ran the analyze command to update Storybook docs.

[x] Added/updated Stories with controls to cover all variants.
[x] Added/updated a basic unit test, at least, for each component.
[x] Added/updated the Figma link for the Story's Design tab.
[x] Added any new component exports to the src/index.ts file

One help required regarding emit the on-notification-click event. Right now its not emitting when we do <kyn-notification><kyn-card> </kyn-card> </kyn-card> structure.
I also Tried bubble up on-card-click event from <kyn-card> but if we do bubble: true then inside elements are not clickable of card
@brian-patrick-3

Left a few comments, looking pretty good overall. Once Card gets moved to Foundation, we'll need to update the foundation version and point to the new card.

yes will keep this in mind and change that after 2.0 release.

Left a few comments, looking pretty good overall. Once Card gets moved to Foundation, we'll need to update the foundation version and point to the new card.

yes will keep this in mind and will change that after 2.0 release.

Nope we'll do that as soon as we move it to foundation

Left a few comments, looking pretty good overall. Once Card gets moved to Foundation, we'll need to update the foundation version and point to the new card.

yes will keep this in mind and will change that after 2.0 release.

Nope we'll do that as soon as we move it to foundation

ok so no need to wait untill 2.0 then its ok will move that after foundation PR merge.

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Exemplar how to download other instructLab curated models like granite and use as default

Changes
During a recent taxonomy meeting, some attendees wanted to use the granite model (non-default, but curated/supported by instructLab) and were confused on how to download it and make it avail. to the other commands they used (in order to test new, prospective Q&A skills).  As this seemed to be a common concern for attendees, I promised to provide a PR to add this info. to the docs. to hopefully help them and others via a docs. PR.
Which issue is resolved by this Pull Request:
Resolves #1282
Description of your changes:
Added and explained how one would download another supported model, i.e., "granite", into the models subdir and subsequently use ilab init to make it the default by reference.
Note This is a second attempt at the PR I closed in order to account for merge conflicts and have a clean review/discussion (see https://github.com/instructlab/instructlab/pull/1232).

Thanks for clarifying the doc! Could you please update your commit message so that it matches the content of the PR description? Thanks!

AFAIK, the default on a squash/merge is to adopt the PR title (i.e., https://github.blog/changelog/2022-05-11-default-to-pr-titles-for-squash-merge-commit-messages/) and have never been asked to change commit descriptions and would have to ask for how to actually do such if my belief is correct.

Thanks for clarifying the doc! Could you please update your commit message so that it matches the content of the PR description? Thanks!

AFAIK, the default on a squash/merge (to main) is to adopt the PR title (i.e., https://github.blog/changelog/2022-05-11-default-to-pr-titles-for-squash-merge-commit-messages/) and have never been asked to change commit descriptions in a PR (and would have to ask for how to actually do such if my belief is correct).

We don't do squash merging. Our Mergify bot merges the PR as-is. You can read more about it here.
Also, my request was not about squashing (which you should do before we merge) but to update the initial commit message (currently empty) with the description you added in the PR. Thanks!

Closed in favor of PR https://github.com/instructlab/instructlab/pull/1334

Closed in favor of PR #1334

You should have been able to just force push your updated changes to the same branch instead of opening a new PR, just FYI


scriptURL is null when building for Release with Xcode

Current Behavior

When building with the release build configuration in Xcode, I'm getting the following build error:
Terminating app due to uncaught exception 'RCTFatalException: Unhandled JS Exception: null is not an object (evaluating 't.match(/(^.+)\/index/)[1]')

The error is referring to the minified version of this line, so it seems that NativeModules.SourceCode.scriptURL being imported from react-native is null.
I'm getting this when using haul version 1.0.0-beta-12. With 1.0.0-beta-11, it works just fine (it doesn't include the line that is causing the error).
Expected Behavior

The build should complete without error as it does in beta-11.
Haul Configuration (webpack.haul.js)

const eslintFormatter = require('react-dev-utils/eslintFormatter')
const paths = require('./paths')

module.exports = ({ platform }, defaults) => ({
  entry: `./index.js`,
  module: {
    ...defaults.module,
    rules: [
      ...defaults.module.rules,
      {
        test: /\.(js|jsx)$/,
        enforce: 'pre',
        use: [
          {
            options: {
              formatter: eslintFormatter,
            },
            loader: require.resolve('eslint-loader'),
          },
        ],
        include: paths.appSrc,
      },
      {
        test: /\.graphql$/,
        exclude: /node_modules/,
        loader: 'graphql-tag/loader',
      },
    ],
  },
})

Your Environment

software
version

Haul
1.0.0-beta-12

react-native
0.52.0

node
8.9.4

npm or yarn
yarn

We have the same bug

@Bolik Can you give your configuration?
@mattpetrie Can you create a repository in which it appears?

const path = require('path'),
webpack = require('webpack')
module.exports = ({ platform }, {module, resolve, plugins}) => ({
entry: './src/index.tsx',
devtool: false,
module: {
...module,
rules: [
{
test: /.ts(x?)$/,
use: [
{loader: 'babel-loader'},
{
loader: 'ts-loader'
}
]
},
...module.rules
]
},
resolve: {
...resolve,
symlinks: false,
extensions: [".ts", ".tsx", ...resolve.extensions],
alias: {
core: path.resolve(__dirname, 'node_modules/medarchive-client-core/dist'),
assets: path.resolve(__dirname, 'node_modules/medarchive-client-core/dist/assets'),
etc: path.resolve(__dirname, 'etc'),
components: path.resolve(__dirname, 'src/components'),
        globalize$: path.resolve(__dirname, 'node_modules/globalize/dist/globalize.js'),
        globalize: path.resolve(__dirname, 'node_modules/globalize/dist/globalize'),
        cldr$: path.resolve(__dirname, 'node_modules/cldrjs/dist/cldr.js'),
        cldr: path.resolve(__dirname, 'node_modules/cldrjs/dist/cldr')
    }
},
plugins: [
          new webpack.DefinePlugin({
              'process.env': {
                  'API_URL': JSON.stringify('https://mb.medarhiv.ru'),
                  'API_WSURL': JSON.stringify('https://mb.medarhiv.ru')
              }
          }), ...plugins
         ]

});

It's produces only in production mode

Makes sense that scriptURL is not available in production. Changing global.DEV_SERVER_ORIGIN = scriptURL.match(/(^.+)\/index/)[1]; to global.DEV_SERVER_ORIGIN = scriptURL ? scriptURL.match(/(^.+)\/index/)[1] : null; should fix the issue. What do you think @zamotany ?

Not exactly because scriptUrl is always a string but regex not matched then we try to get [1] element form null and BOOM!  I created PR to fix this.


Fix #1079 multiple administrations.

There was a bug that multiple medication administrations were not being output on a patient record unless that medication was also ended for each administration.
However, ending the medication after every administration is not a good idea, because that patient could also have an open prescription for that medication.
This fix ensures that MedicationAdministrations and open ongoing prescriptions of the same medications do not conflict, and both are recorded in the output files.
You can replicate the error on master and the fix on this branch using the below module (looking for an annual inpatient encounter called "Dummy Encounter" and Medication/MedicationAdministration named "Administered Injection").
medication_administration_example.json.zip

Don't merge this yet... investigating one more thing...

This PR also makes it so that all the FHIR Claims associated with a MedicationRequest also have an ExplanationOfBenefit. This means there could be more (perhaps a lot more) EoB resources.
FHIR Claims associated with Encounters already had an ExplanationOfBenefit.
Finally, the EoB data does not match the calculations in our HealthRecord claims. The FHIR Exporter just assumes 80/20 copay and deductibles and random garbage. 🙄


Tussenvoegsel should be lowercase in Guido's name

Dutch spelling rules dictate that when used in combination with my first name, "van" is not capitalized: "Guido van Rossum". - https://gvanrossum.github.io/
Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks so much for your first contribution!  You rock, @ethanhs!

Thank you for your kind words :)


Add pulsar-client 2.4.1 wheels to pypi

Add pulsar-client 2.4.1 wheels to
https://pypi.org/project/pulsar-client/#history

@pouledodue please stay tuned for 2.4.1. The 2.4.1 vote was just closed a couple of hours ago. Jia is still working on the remaining steps for completing the release process and he will announce the release in the mailing list once he completed the process.

thanks for the hard work @jiazhai

ref #5129

this is resolved

mac?

there is issue with the cmake script.
https://github.com/apache/pulsar/pull/5263
It should be fixed and mac binaries releases as part of 2.4.2 which will be
soon.
On Sat, Sep 28, 2019 at 2:29 AM Poule Dodue<EMAIL_ADDRESS>wrote:

mac?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/pulsar/issues/5114?email_source=notifications&email_token=AB5DK7NWWFK5ET3ISTONAXTQL4PWPA5CNFSM4ITS7VT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72U3NA#issuecomment-536169908,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB5DK7PXFKV234UU6T2OX2TQL4PWPANCNFSM4ITS7VTQ
.

--
-Ali

there is an issue with the cmake script.
https://github.com/apache/pulsar/pull/5263
It should be fixed and mac binaries releases as part of 2.4.2 which will be soon.


Update avpop_mono defaults

@aphearin I thought the updated params looked good, but I pulled the changes and made some diagnostic plots and realized the parameters needed to be modified further. This should do it, but you should take a look before I merge.

This code change confused me, because in #65 I thought I set these parameter values so that Av=0.1 for all galaxies. But I guess that's not true? The reason I thought that was because I thought the meaning of the parameters I changed controlled the value of suav, where Av = jax.nn.softplus(suav). And so when I set the parameter values to all equal -2.25, I thought I was setting Av=0.1=jax.nn.softplus(-2.25). But it looks like I must have gotten turned around. Maybe what these parameters actually control is the value of an unbounded parameter?

@gbeltzmo I think I see what happened. In f53ed7bb38852f51732e0b10c776f99c13c350a6 I fixed what I think was the actual bug.

but I pulled the changes and made some diagnostic plots and realized the parameters needed to be modified further.

Could you use repeat the diagnostic plot checks you did using this new code?

@aphearin can do!


Feature/force download last wf

Changelog Description
Adding a Force download last workfile feature, which forces openpype to download the last workfile (using the pre copy last workfile hook) even if there already are local workfiles. This doesn't check if the last local workfile is the same as the one downloaded, as a design choice. The point of this feature is to allow users to easily ensure they get a brand new download of the last published workfile, for instance in case their last local workfile is borked, or if they already know their workfile is not the latest and they will need to download a new one anyway.
Newly downloaded workfile version number will either be:

Last local workfile + 1 if any local workfile is found.
Last published workfile + 1 if no local workfile is found (i.e. what the pre copy last workfile hook already does even without this feature).

This feature available in the launcher by right clicking on the host app icon and ticking Force download last workfile. A small download icon then appears to the lower right of the host app icon to show the user that this feature is active for the selected project, asset, task and host, along with (Force download last workfile) added to the app tooltip.
This is compatible with the existing Skip opening last workfile feature in case not only you need a force download, but you also need to open the workfile directly from the DCC.
This PR also includes some refactor the Skip opening last workfile feature, in order to make some of the code more reusable and accommodate required changes for the Force download last workfile feature. It would now be easier to add more options to the context menu, but it would still require quite a bit of work and understanding of the implementation compared to the system used for plugins.
Finally the Skip opening last workfile marker visible on the host app button has been moved to be closer to the icon.
Known limitations
When activating both Skip opening last workfile and Force download last workfile at the same time:

Sometimes Force download last workfile gets unticked automatically (I don't understand why).
The order in which these feature appear in the host app tooltip depend on the order in which these features have been activated.

Testing notes:

Open the launcher and select any asset and task.
Right click on the host app and tick Force download last workfile, a download icon should appear and the host app tool tip should contain (Force download last workfile).
Click on the host app, the last published workfile should be downloaded and opened. Its version number should be last local workfile + 1 (If there were local workfiles already) or last published workfile + 1. No workfile should ever be overwritten when doing this.
Close the DCC.
Right click on the host app and untick Force download last workfile, the download icon should disappear, the tooltip should no longer contain (Force download last workfile) (may require to hover out and hover back in).
Click on the host app, it should launch without downloading a new workfile.

Newly downloaded workfile version number will either be:

Last local workfile + 1 if any local workfile is found.
Last published workfile + 1 if no local workfile is found (i.e. what the pre copy last workfile hook already does even without this feature).

Few notes or questions about this.
Always increment publish version + 1 unless a newer workfile version already exists
Wouldn't you expect maybe that if the publish version is v010 and you do have a workfile v001 that the new workfile still ends up being v011 or did you find that more confusing?
Allow settings to specify a subversion/comment string for downloaded files.
Should it download to a version with a subversion string like download or allow in settings to define if a subversion/comment string should be appended to the filename when it's a downloaded file?
It'd basically be what Work Files tool allows to set via subversion here:

Set Artist Note for downloaded files
Additionally - it'd be epic if we can make it so that the downloaded file also gets an "Artist Note" (like you can set in the Work Files tool) and the Artist Note would e.g. be: "Download of published file X Y Z" to really clarify the situation?
E.g. like:

Always increment publish version + 1 unless a newer workfile version already exists
Wouldn't you expect maybe that if the publish version is v010 and you do have a workfile v001 that the new workfile still ends up being v011 or did you find that more confusing?

Yes now that I think about it, what you describe would make more sense. I'll see what I can do about it.

Allow settings to specify a subversion/comment string for downloaded files.
Should it download to a version with a subversion string like download or allow in settings to define if a subversion/comment string should be appended to the filename when it's a downloaded file?
It'd basically be what Work Files tool allows to set via subversion here:

Set Artist Note for downloaded files

That's a good idea, I'll make that change.

Additionally - it'd be epic if we can make it so that the downloaded file also gets an "Artist Note" (like you can set in the Work Files tool) and the Artist Note would e.g. be: "Download of published file X Y Z" to really clarify the situation?
E.g. like:

Might as well try that too.

Since artist notes are pretty much implemented within the UI, I think it would be tricky to use them cleanly in this context. So I think it might be best not to use artist notes for this feature.
Besides that, versioning has been fixed, and subversions are used as requested.

I am not sold on this. It seems as a lot of code to solve an issue that could be solved by single hit on Delete key.

I am not sold on this. It seems as a lot of code to solve an issue that could be solved by single hit on Delete key.

There's no delete option within the launcher as far as I know. If you suggest going to the workfile directory to delete workfiles. the whole point is to avoid it. It's much simpler for users to have a button that does what they need than to fidget around in files, and what I'm proposing is non destructive. I also consider risky to expect user to manually do these file operations. This would be prone to human error, in fact I already had to fix human errors due to the lack of a feature such as the one I'm proposing.

There's no delete option within the launcher as far as I know. If you suggest going to the workfile directory to delete workfiles. the whole point is to avoid it. It's much simpler for users to have a button that does what they need than to fidget around in files, and what I'm proposing is non destructive. I also consider risky to expect user to manually do these file operations. This would be prone to human error, in fact I already had to fix human errors due to the lack of a feature such as the one I'm proposing.

Having said that - would you be ok if this were an individual launcher action? So that in the launcher there's an extra entry "download last workfile" instead of adding the 'force download toggle' and everything? I feel like you'd rarely want to always have force download enabled the whole time and it's a on-off thing anyway?

There's no delete option within the launcher as far as I know. If you suggest going to the workfile directory to delete workfiles. the whole point is to avoid it. It's much simpler for users to have a button that does what they need than to fidget around in files, and what I'm proposing is non destructive. I also consider risky to expect user to manually do these file operations. This would be prone to human error, in fact I already had to fix human errors due to the lack of a feature such as the one I'm proposing.

Having said that - would you be ok if this were an individual launcher action? So that in the launcher there's an extra entry "download last workfile" instead of adding the 'force download toggle' and everything? I feel like you'd rarely want to always have force download enabled the whole time and it's a on-off thing anyway?
Like you said - that'd make it just a simple button they could press - which could even then offer them options like, which workfile and show some little info - what site did it copy from? what will it save it as? maybe even prompt to the artist note field and file suffix etc so they can customize if they want.

Yes I agree. I chose a tick box to keep the current design of the skip opening last workfile feature. But what you're describing sounds even better. However it would take more development time, and the feature freeze is in just two weeks. I guess for now a download button that just downloads the last published workfile might be more realistic (I don't know if I'll have time to do it though), and the more feature rich menu you're proposing could be done directly in Ayon. What do you think?

Because we're splitting OpenPype into ayon-core and individual host addons, this PR would have to be re-created to target one of those. Also, similarly to @kalisp I'm not convinced that this logic should even make it to the main codebase. We should find a more robust way of handling the core problem here in AYON
We're closing it down, but we'll he happy for a new PRs to ynput/ayon-core repository once it's up.


Tweak logo for dark mode

Fixes #11791. I made the text a bit lighter (60% gray), which makes it easier to read in dark mode. It should be still quite readable in light mode as well.
Old (current) light:

Old (current) dark:

New light:

New dark:

Looks very nice!!!

Actually. Shouldn't we get rid of the tagline. Or change it: Brain analysis ... or something like that?

I cannot generate the updated logo:
findfont: Generic family 'sans-serif' not found because none of the following families were found: Primetime
/Users/clemens/Projects/mne-python/logo/generate_mne_logos.py:111: MatplotlibDeprecationWarning: The collections attribute was deprecated in Matplotlib 3.8 and will be removed two minor releases later.
  for coll in cs.collections:
findfont: Generic family 'sans-serif' not found because none of the following families were found: Cooper Hewitt
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
File ~/Projects/mne-python/logo/generate_mne_logos.py:181
    178 patch.remove()
    180 # modify to make an icon
--> 181 ax.patches.pop(-1)  # no tag line for our icon
    182 patch = Ellipse(xy, r, r, clip_on=False, zorder=-1, fc="k")
    183 ax.add_patch(patch)

AttributeError: 'ArtistList' object has no attribute 'pop'

And yes, I did install the font.

Maybe you need to refresh the MPL font cache?

Thanks, that was it!
Now I saw that the logo also needs the "Primetime" font, which is only free for personal use. I'm not sure that our logo qualifies for personal use.

Replacing the Primetime font is not a good idea, the PNGs look terrible...

@larsoner please feel free to take over! Regarding your first point, I think you need to look at it with white background, because it get's hard to read because of the checkered background IMO.
Also, the SVG diffs are still massive even though they were generated with the script (but apparently, a lot has changed in how MPL renders SVGs?). But I guess that's OK.

Now I saw that the logo also needs the "Primetime" font, which is only free for personal use.

from the designer's website:

With a free for Personal use version, you can't use PRIMETIME © for a commercial purpose.

MNE is not commercial software, so as I said long ago as long as we're not fundraising, selling the stickers, or start charging for MNE I think we're in the clear.

@drammock okay with the switch away from PrimeTime? I think it looks fine/comparable to me but IIRC you chose the fonts originally

I chose CooperHewitt but I think @agramfort chose Primetime (and I recall being discouraged from changing it when I was scripting the logo generation because "Alex likes Primetime").  Anyway I don't think we need to change it, see above.

Let's not touch Alex's Primetime then 🎉🍹

Okay I think I'm happy now. @drammock @cbrnr feel free to look -- GitHub has a nice image diff nowadays! Changes:

Tweaked tagline the weight upward slightly -- I've noticed especially on HiDPI screens (my mac) that the Light font is difficult to read.
Added a little sanity check that matplotlib probably/hopefully finds the correct font. On my system I had several weights and it always used Thin even though I had thin/light/book/medium installed and I think it was supposed to pick Light. So I had to rm the other variants then fc-cache update and rerun. Now I have it using Book.
To offset this, I moved from black to "0.2" and from white to "0.8" which I think helps reduce the prominence close to what it was before without sacrificing readability on HiDPI displays.
Added mne_logo_gray.svg that lives in doc/_static. Once it deploys tonight we can change our README.rst to use mne.tools/dev/_static/mne_logo_gray.svg.

Okay I'll actually stop pushing commits now!

@larsoner OK by me if you merge when happy

Wait, why am I seeing this on my phone in dark mode:

No idea, I can't replicate on my mobile or on macOS in inspection mode as an iPhone, or in Safari

You mean that gray bar underneath the tagline?

Looks like this for me now in the browser and GH app:

You mean that gray bar underneath the tagline?

No, I meant the white (gray?) text, which is 100% readable (on main). But apparently, this is a dark mode feature on my Android phone, because I cannot replicate on my Mac. Still, pretty neat!

I cannot read the tagline in dark mode 🥲 (see my screenshots above)

Yes, I think it's something my phone does.

Yeah but … wasn't that something this PR aimed to address too? 😅

Yes, but as @larsoner mentioned here, we merged this prematurely. I'm not entirely sure what the plan is, but he created a third logo variant mne_logo_gray.svg, which I think we need to include in README.rst. Previously, I modified mne_logo.svg directly, which is the logo currently included in README.rst.

#12184

Ah okay! I missed that!

Only slightly related but I thought it was funny:


No sources in sourcemap when files passed using hash method

I'm trying to minify multiple sources, then create a source map for those files.
The files themselves don't have source maps.
Is this functionality supported/supposed to be supported? I had a look at the tests and nothing covered this use case.
Using the filename directly in an array works, but using the filename + contents fails.
new CleanCSS({ sourceMap: true, target: '.' }).minify({
  'source1.css': {
    styles: 'contents of source1.css'
  },
  'source2.css': {
    styles: 'contents of source2.css'
  },
});

the source map output:
{
  "version": 3,
  "sources": ["$stdin.css"],
  "names": [],
  "mappings": "mapping code here"
}

It's covered by tests, so it should work, see https://github.com/jakubpawlowicz/clean-css/blob/master/test/source-map-test.js#L876
I assume you use the latest clean-css - 3.1.5?

Yes, I'm using the latest.
The tests you linked to explicitly use an input source map, whereas I'm not using any here.

Ah, right! Do you get a correct minified output though?

Yep, the minified output is correct.

And are keys of a hash passed to minify function correct? If you don't do pass a source map you can equally well pass an array of source locations, e.g.: https://github.com/jakubpawlowicz/clean-css#passing-an-array

I'd like to pass these files 'virtually', for example, when there is no file on the disk.
but I'd also like to have source maps so that in the browser I can see these virtual files in their original state.
I looked at the code a little bit, and found by changing https://github.com/jakubpawlowicz/clean-css/blob/master/lib/utils/source-reader.js#L54-L58
to:
if (outerContext.options.sourceMap) {
  var absoluteSource = path.resolve(source);
  styles = outerContext.sourceTracker.store(absoluteSource, styles);
  if(inputSourceMap) {
    outerContext.inputSourceMapTracker.trackLoaded(absoluteSource, inputSourceMap);
  }
}

It would then track these files passed using hash which don't have source maps attached.

styles = outerContext.sourceTracker.store(absoluteSource, styles);

This works fine, all tests pass.
It's the exact same way the array method tracks items: import each url, then the import inliner fetches the source and tracks it. (inliner.js line 318)

when there is no file on the disk.

Reading up on the source map specification, it seems that this is possible, but clean-css doesn't currently support it: issue #397
I suppose that means that this issue would only be half solved if #397 remains open, at least for the purposes that I want to use it for.

It seems the way I'd like to use it (virtual files, nothing on disk/server) would only work if clean-css also support source-map's SourceMapGenerator.setSourceContent so that browsers would never request the files.

@AdamBurgess Good spot! Yes, we need #397 to fully support this use case, which is coming in 3.2 soon.

@AdamBurgess it's implemented on master now! https://github.com/jakubpawlowicz/clean-css/commit/9c74966ff7bc2a0fafcf94277a8e5ac321b4a0cc#diff-9eb831640e84d334de8c721591bfb179R1143 seems to be your use case.


add protocol chinese version

as title , we use beanstlkd in our project ,so we translate it into chinese for more chinese developer.
I have sent a email to @kr before.

Merged! Thank you so much. :100: :8ball: :balloon:

:smiley:
:thumbsup:


Fancy behaviour

When browsing through the documentation, all images that are resized can be clicked on and then show full size. But when I use the images module on my site it doesn't work like this. Is there anything else that need setting up?
I couldn't find the (hugo) sources for the documentation site online so I can't find out myself.

When browsing through the documentation, all images that are resized can be clicked on and then show full size.

Hi, the docs site is built on top of HB themes, and this feature is one of modules (bigger-picture) of HB themes, it's not related to this images module.


Really quick and dirty first-pass on inline videos

Done reviewing; had a few small comments, good to go after addressing them.

nice!
(did not review, just happy this feature is happening)

Release Note:
Added support for inline video playback.


"Unspecified error" when converting WSL1 to WSL2

Please use the following bug reporting template to help produce issues which are actionable and reproducible, including all command-line steps necessary to induce the failure condition. Please fill out all the fields! Issues with missing or incomplete issue templates will be closed.
If you have a feature request, please post to the UserVoice.
If this is a console issue (a problem with layout, rendering, colors, etc.), please post to the console issue tracker.
Important: Do not open GitHub issues for Windows crashes (BSODs) or security issues.  Please direct all Windows crashes and security issues to<EMAIL_ADDRESS> Ideally, please configure your machine to capture minidumps, repro the issue, and send the minidump from "C:\Windows\minidump".
Please fill out the below information:

Your Windows build number:  18917

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

wsl --set-version reported unspecified error when converting a WSL distro from WSL1 to WSL2 when a WSL2 Distro is opening.

What's wrong / what should be happening instead:

It should display an error that a distro is running.

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

For WSL launch issues, please collect detailed logs.

See our contributing instructions for assistance.

The error code seems to be similar with #4102.

Some additional information: After completing the conversion, Ubuntu went back to install state (which I have already complete installing) and giving error code 0x80080005

Let's keep all the conversation in #4102.


Unable to continue log in on Linux client

Keybase GUI Version: 1.0.36-20171120211059+9c5671ec9
Hello I am using the Keybase app for Linux on Fedora 26 (kernel verison 4.13.13-200.fc26.x86_64). I am unable to log in using the Desktop app.
Steps to reproduce:

Open Keybase app
Click the "Log in" link
Enter my id -> Continue
Select the laptop device I am using
Set a public name for this device "Work laptop" for example -> Continue
Type in text code. The app gives me words to type but I don't know where to type them. No text box in this window.

The Keybase app gives me the advice:
"In the Keybase app on your computer, go to Devices > Add new..."
I am already in the Keybase app on my computer, and the app does not have a menu named "Devices" (only File, Edit, Window, Help) or any sub menu "Add new".
Clicking on another Keybase window I see a menu button that gives me the following options "Open folders, Keybase.io, Report a bug, Help/Doc, Quit"
I also tried to add a device at Keybase.io but the web app told me to use the desktop app and I am unable to do that. Please advise if you need more information. Thanks!

Your issue sounds like a similar issue to #9352. Have you every installed the Keybase client before? If so, you may need to log in to your account in that other client and add the Desktop app using the process described in the app. As in #9352, if you no longer have access to the previous install, then you may end up stuck in this catch-22 (which I believe is a bug, but am waiting for the Keybase team to comment on).

This is insanely confusing. I have no idea what this error message is trying to tell me. There is no such menu.
Yes I have keybase installed on another machine, does that one need to priv this one? If so, how... what's happening?


tf.nn.seq2seq. cannot be found with tf version 1.0

In 09_Recurrent_Neural_Networks\03_Implementing_LSTM\03_implementing_lstm.py ,
there could not find seq2seq. I think maybe update to version 1.0 of tf caused this problem.
"
--> 166         decoder = tf.nn.seq2seq.rnn_decoder
167         outputs, last_state = decoder(rnn_inputs_trimmed,
168                                       self.initial_state,
AttributeError: module 'tensorflow.python.ops.nn' has no attribute 'seq2seq'
"

Two things are now apparent to me.
(1) TensorFlow's automatic upgrade script that upgrades python code to be 1.0.0 compliant does not address all issues.
(2) The seq2seq functions have changed dramatically.
After a bit of digging, it appears the seq2seq functions are in the following location:
 tf.contrib.seq2seq
I would try the function: tf.contrib.seq2seq.simple_decoder_fn_train() for the training and tf.contrib.seq2seq.simple_decoder_fn_inference() for evaluation.
If that fails, you can also try tf.contrib.seq2seq.dynamic_rnn_decoder(), but read up on the documentation for that on the arguments.
I will attempt to go through all of chapter 9's code this weekend, as time permits.  Thanks!

I was able to get this script working and also create a jupyter notebook in the process. It should work now.  For reference, I'm running Python 3.6.0 and TensorFlow 1.0.1.  If you are still running into errors, please let me know and also post your Python/TensorFlow version numbers.  Thanks!

Why i run my code in  tensorflow 0.12.0 still meet this error?
module 'tensorflow.python.ops.nn' has no attribute 'seq2seq'


Is there a maximum number of RX igns per day?

I am not able to get the amount of RX fire I need. The fire sizes are pretty heavily skewed towards the smaller sizes, so I need to light ALOT of RX fires and am not able to ever hit my target

The limit is one fire per day.
Rob Scheller
<EMAIL_ADDRESS>On Fri, Jul 20, 2018 at 11:15 AM Alec Kretchun<EMAIL_ADDRESS>wrote:

I am not able to get the amount of RX fire I need. The fire sizes are
pretty heavily skewed towards the smaller sizes, so I need to light ALOT of
RX fires and am not able to ever hit my target
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/LANDIS-II-Foundation/Extension-SCRAPPLE/issues/74,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALo2mpe5wZVOajLHz1VfvfRDGl_p9v-aks5uIfP0gaJpZM4VYM7T
.


Return 304 for request with current header

Feature Description: Dynmap could return 304 code to those request with correct 'If-Modified-Since' header, which could boost much performance.

Additional context: This feature comes from the client-side cache and CDN.  CDN has a feature that it could refresh all the modified resources, such as tiles with players building, but not touch those tiles in the wild. This feature is so awesome that it could make the map loading faster meanwhile keep the necessary tiles fresh. CDN also need server-side to response a 304 when using 'If-Modified-Since' header.

From my understand this is an issue that needs to be resolved on Dynmap's side rather than LiveAtlas.
LiveAtlas is currently loading tiles via <img> tags, which means the browser is in control of the request and LiveAtlas cannot add additional headers. The browser will choose to add If-Modified-Since headers to these requests if it has previously received headers that indicate it should, such as Last-Modified  and appropriate Cache-Control headers. It is up to dynmap to send these headers.
Looking at Dynmap's PHP files for tile requests, it does set a Last-Modified header, but does not explicitly set a Cache-Control header. This causes the default PHP setting for this header to be used instead, which is typically to not allow caching at all (no-cache, no-store, must-revalidate). Adding a more appropriate cache control header into the script itself, such as public, resolves this problem and allows the browser to cache the tiles and send If-Modified-Since headers. I have not checked how the internal server handles this but I imagine it is similar.
Even if the headers are all correct however, it is still up to dynmap to respond to them appropriately. In the php files there is currently no logic to check for any If-Modified-Since header, or to return a 304 if the tile hasn't changed. This could theoretically be added, but falls outside of the scope of LiveAtlas at this time.
If LiveAtlas ever provides its own version of Dynmap's PHP files in the future then this could be an improvement to consider.

Could you solve this problem(maybe a pr in dynmap repository)? I am trying to write a serverless function to refresh those tiles which has been changed on cdn, so it cloud both boost hit chance and bandwidth efficiency🙄.


Use -DGPR_BACKWARDS_COMPATIBILITY_MODE in gRPC.

This avoids using secure_getenv(), which prevents building on
operating systems with a GLIBC < 2.17.

@tensorflow-jenkins test this please.

@girving: This should fix #1307.

LGTM, though I'd add "Fixes #..." to the commit message.

@girving: Thanks, I'll do that in the merge commit message (after tests pass).


Using Google Play Subscription Offers

Thanks for all your hard work on this plugin!
Is there a way to use Google Play offers via this plugin?
For example, I have a subscription with a product id of "basic5". That subscription is currently setup with a base plan with an id also of "basic5" for $9.99. Below that I have two offers. Offer id "basic5free" gets you 1 year free.  Both offers revert to the base plan after the first year.
If I call GetProductInfoAsync with "basic5" i get a price of $9.99. If I try to do the same call with one of the offer id's, I get nothing.
I have to admit that I didn't try calling PurchaseAsync, because I figured if I couldn't get the product info for the offers, I probably can't purchase them either.

looks like it might be a work in progress: https://github.com/jamesmontemagno/InAppBillingPlugin/blob/android-v5/src/Plugin.InAppBilling/InAppBilling.android.cs#L277 granted this just uses the first offer instead of letting you specify one

yes, you can pull down version 7.0.3-bet and start  trying there.
for purchasing i think i need to have folks pass in an offertoken or something like that.

Awesome thank you! I'll try it out next week

sounds good, let me know how it goes and feel free to post on the PR

Merging with #521


Hotfix/tutorial tweaks

Summary of the PR
Two changes to the tutorial example code:
The removal of superfluous Use() calls from the tutorial Shader SetUniform definitions. These can cause confusion when debugging. (Use calls the shaders UseProgram)
Assorted small spelling and grammar tweaks, primarily commas, apostrophes and the occasional "tho" -> "though"
Related issues, Discord discussions, or proposals
Perksey was happy for me to make this pull request.
https://discord.com/channels/521092042781229087/607634593201520651/831162386195021845
Further Comments

Awesome, thanks so much for this contribution! See below some questions (the PR looks good as is, just want to do some sanity checks).
Finally, have you ran through these tutorials after your changes to make sure they work? A simple dotnet run should suffice, don't bother opening the Silk.NET.sln.

I have indeed called dotnet run on them to ensure they all still work, no issues I can spot.


Project Compilation on Windows

Hi Juan,
First of all I want to congratulate you on such a project, your fastest-lap looks really cool!
I've found it very interesting and I would like to deepen it. Because of this, I would like to build the project on my Windows machine, not just use the binaries you've provided.
I've seen that one of the third-party packages used by fastest-lap -lion- requires a Fortran compiler. Do you have any suggestions for any specific Fortran compiler on Windows as you have for Linux and Mac?
Thanks for you time!

Hello Michele. Thank you for your very kind words.
A full compilation requires a Fortran compiler, but this is only to compile a third party -Mumps- required by Ipopt. You might wanna bypass this and skip this step by downloading their pre-compiled binaries: https://github.com/coin-or/Ipopt/releases/download/releases%2F3.14.9/Ipopt-3.14.9-win64-msvs2019-md.zip
Otherwise, if you want to compile everything yourself (I do it this way personally, I use Intel Parallel studio)

Hello Juan, thank you for your quick reply
I've actually found out already some first info to build the project on Windows in the release info of 0.1.0 version.
I've therefore installed the Intel Fortran Compiler 2022.1.0, I had instead Visual Studio 2019 with C++ and CMake workflow already installed.
That said, I haven't unfortunately managed to build the project, could you please share some more details?
For instance, which CMake generator are you using? Ninja or Visual Studio itself?
Do you have any CMakePreset.json config file to share?
Thanks, Michele

I am not using CMake to compile on Windows, I just use Microsoft Visual Studio GUI, by setting the appropriate include dirs, macros, and linking libraries.
I do not have my windows computer with me right now, so probably if I tell you the steps, I will miss some. So maybe you can install WSL (windows subsystem for linux) in the mean time, and explore the code from linux. If you want to use it directly on windows, you can just use the pre-compiled binaries
Cheers!


Skip config complete when we don't need it

This change skips the config compile step when we don't need it.

Fixes #51


Create a new pull request by comparing changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

114 of 118 (96.61%)  changed or added relevant lines in 4 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 94.897%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

js/src/modal.js
32
36
88.89%

Files with Coverage Reduction
New Missed Lines
%

js/src/dom/event-handler.js
1
92.27%

js/src/tooltip.js
5
92.55%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
1985

Relevant Lines:
2044

💛  - Coveralls


Confused about directory structure

Thanks for the quick response. I am a bit confused about the next step, because the instructions are not clear about where to place the training data you've pulled off your phone. What's the difference between "train_data" and "test_data"? Which one (or both) should the images and sensor data folders go into?
I've set up my directory structure as follows,

with the images and sensor folders in the train_data folder and nothing in the test_data folder. But that doesn't seem to work.

Can you add a sample screenshot of the correct directory structure and file locations? The text-tree you've provided so far and the instructions in the Jupyter notebook don't explain this

The folder structure is explained here. Basically, inside each, the train_data and test_data folder, you can make folders for each dataset you collect and give it a name such as "my_openbot_1", "my_openbot_2", etc. Inside these folders, you drop all the zip files from that recording session and unpack them. I can add a screenshot to the repo to make it more clear.

The reason for the train_data and test_data folder is to have some data for validation/testing during training that has not been seen. This then gives you an indication during training of how well this policy may transfer. The
common split is 80% training data and 20% test data.

Also, you might find issue #31 helpful for getting the training to work.

Just to be clear, since I can't tell from the screenshot, I should place the same Images and Sensor Data folders and files in both the Test and Train folders?  Or should I some runs in Test and others in Train so that they have different data to look at, as your note suggests?

Reading as much as I can, I think the clearer way to put this in the documentation would be with an example, perhaps like this:

Collect five data sets (five runs over the same area, pressing record for each one)
Copy all those zip files to your PC
Unzip them and put four of them in the Train folder, each as an Images (containing all the images) and Sensor Data (containing all the sensor data text files) folder within a folder with the run number
Put the remaining run in the Test folder, also within Images and Sensor data folders inside a run number folder.

This ratio of 80% training/20% testing data is a good rule of thumb for all your data gathering going forward

The data in the train_data and test_data folders should be different. As you can see in the screenshot in the folders with the different runs (my_openbot_1, my_openbot_2) are just the extracted log folders that come from the OpenBot phone. The folder names correspond to the timestamp of when the log was started (trigger on the controller). I did update the description in the Readme yesterday. Let me know if this is easier to understand.

Thanks for the explanations (and sorry for being dim ;-) It is clearer now, although I still like the idea of providing an example, as I did above, for those who really want it spelled out.

Ok, thanks for your feedback, will see how I can incoporate that.

Having now put the files in a directory structure as instructed, I'm getting this error. There seems to be some confusion: should the Sensor Data folder be within the Images folder, as this error suggests, or at the same level as the Images folder, as the documentation says?

No, it should be as the documentation says. You are missing one level of directories. Right now you put the extracted zip files directly into dataset/train_data/. But there should be subfolders corresponding to the recording sessions. So for example you collect some data for learning to drive around your kitchen block in the morning. Then you create the folder dataset/train_data/kitchen_morning and then extract all of the zip files into that folder. Then you may collect more data in the evening, and will put it into dataset/train_data/kitchen_evening. By default, you will train on all data. However, you can also specify in the notebook to train only on specific folders. This is useful if you want to train different policies with data collected in different environments (e.g. another subfolder living_room_morning).
Similarly, you might have different openbots, e.g. my_openbot_1, my_openbot_2, etc. This is the example from the documentation and what I posted a screenshot of above. I hope this makes sense now.

Sorry for being so dim! I guess I was just confused by the example screenshot you provided, where you have different OpenBot numbers in the Test and Train directories.  Wouldn't it be clearer and simpler to use the same OpenBot number for both, which I presume is the most common case (people only have one)?
Like this:

Yes, you are probably right.


Enhancement Request: CYDIA - Change default web address to https:// when adding Repo's

Cydia request: It'd be great to change the default 'add source' field to "https://" rather than "http://" - most repos these days are https.  Not sure if it's for you to change, or if it's a Saurik IP thing.
Very very minor, but would save 10 seconds every time we add a new repo.

I believe it has already been confirmed that https will not be necessary as there have been proper file integreation checks implemented in Cydia already. Also not everyone has the ability to purchase an SSL certificate (let’s not count in Let’s Encrypt for now, which is clearly an exception), especially for private repo owners. Maybe someone else can clarify this further?

Not trying to force the use of https, just wanting it to be the default address that pops up when adding a new repo.  Most of my repos are https, and failing to add the ‘s’ meant I couldn’t add them.
This is a usability-driven enhancement request, not security-based.

@chrislinke I have a tweak to do this, If I get time, I'll get my repo up and running again this weekend.

Brilliant! Would you mind pasting a repo link here once up and running? Love your work

@chrislinke Remind me this weekend on twitter @Cryptiiiic or via discord Cryptic#6293.

@chrislinke https://cryptiiiic.com/repo/

Thanks heaps mate! Running beautifully