x/tools/gopls: disable code actions from gopls

gopls version
Build info
----------
golang.org/x/tools/gopls v0.16.1
<EMAIL_ADDRESS>h1:1hO/dCeUvjEYx3V0rVvCtOkwnpEpqS29paE+Jw4dcAc=
<EMAIL_ADDRESS>h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak=
<EMAIL_ADDRESS>h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
<EMAIL_ADDRESS>h1:2O2DON6y3XMJiQRAS1UWU+54aec2uopH3x7MAiqGW6Y=
<EMAIL_ADDRESS>h1:5+9lSbEzPSdWkH32vYPBwEpX8KwDbM52Ud9xBUvNlb0=
<EMAIL_ADDRESS>h1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M=
<EMAIL_ADDRESS>h1:3Wt8mZlbFwG8llny+t18kh7AXxyWePFycXMuVdHxnyM=
<EMAIL_ADDRESS>h1:a94ExnEXNtEwYLGJSIUxnWoxoRz/ZcCsV63ROupILh4=
<EMAIL_ADDRESS>h1:Kd+Z5Pm6uwYx3T2KEkeHMHUMZxDPb/q6b1m+zEcy62c=
<EMAIL_ADDRESS>h1:SP0mPeg2PmGCu03V+61EcQiOjmpri2XijexKdzv8Z1I=
<EMAIL_ADDRESS>h1:9MDAWxMoSnB6QoSqiVr7P5mtkT9pOc1kSxchzPCnqJs=
<EMAIL_ADDRESS>h1:G3QvahNDmpD+Aek/bNOLrFR2XC6ZAdo62dZu65gmwGo=
<EMAIL_ADDRESS>h1:lyBNOm8Wo71UknhUs4QTFUNNMyxy2JEIaKKo0RWOh+8=
go: go1.22.4

go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='-- private --'
GOROOT='/usr/local/go'
GOSUMDB='-- private --'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/data/project/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4255324789=/tmp/go-build -gno-record-gcc-switches'

What did you do?
There are two code actions from gopls on every single line of the source code, which will drown out the truly useful ones:

What did you see happen?
Refer to the previous section.
What did you expect to see?
I would like to be able to disable certain specific code actions of gopls through configuration.
Editor and settings
No response
Logs
No response

Related Issues and Documentation

x/tools/gopls: Implement action should ignore importing the current package #61830 (closed)
x/tools/gopls: codeAction returns invalid text edits #35458 (closed)
x/tools/gopls: Add refactor "move to a new file" #65707 (closed)
x/tools/gopls: gopls falls behind user input in large repository #45089 (closed)
x/tools/gopls: negated build flag causes error #59346
x/tools/gopls:  #52425 (closed)
x/tools/gopls: Is there any way to filter errors? #68624 (closed)
x/tools/gopls: completion often uses all of 1s time budget #68063
x/tools/gopls: gopls becomes unresponsive from time to time #61969 (closed)
x/tools/gopls: gopls walks entire filesystem of a go module #52993 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

cc @adonovan

I would like to be able to disable certain specific code actions of gopls through configuration.

Such control is supported directly by the Language Server Protocol: a CodeAction request has a field, only, that allows the client to choose a subset of the code action kinds supported by the server. The default set can be found in the gopls source at gopls/internal/settings/default.go (unfortunately this list is not directly reflected in the documentation); if you remove "source.doc" and "source.assembly", then the server will not return these code actions.
I'll leave this issue open to address the question of whether the new defaults are inappropriate for a significant fraction of our users.

@xtrats which editor and LSP client are you using? In VS Code, these actions are less obtrusive, only appearing in the nested source action menu. It may be that they are more distracting in your editor than in others.

@xtrats which editor and LSP client are you using? In VS Code, these actions are less obtrusive, only appearing in the nested source action menu. It may be that they are more distracting in your editor than in others.

I'm using neovim v0.10.1 with "neovim/nvim-lspconfig" plugin, using the "glepnir/lspsaga.nvim" and "aznhe21/actions-preview.nvim" plugins to discover and preview code actions.
When there are available code actions for the current line where the cursor is located, a lightbulb icon will be displayed, so a lightbulb icon will be shown on every line.

the new commit makes extract function,extract method disappear in neovim builtin lsp vim.lsp.buf.code_action()

That's surprising; the missing "only" and the triggerKind=1 (invoked) should cause the server to return all code actions. I will investigate.

Ah, sorry, ignore this, I'm running an outdated branch..


No warning for weird connection state

I'm using Baqend with next.js which leads to the problem that my code is run server side and client side which makes connecting to Baqend a bit of a problem because I don't have one single point in my applications lifecycle where I can connect.
My solution was this piece of code
BaqendApi.connect = function() {
  return new Promise((resolve, reject) => {
    if (DB.User) {
      resolve();
    } else {
      DB.ready(resolve);
      if (!BaqendApi.connecting) {
        BaqendApi.connecting = true;
        BaqendApi.connected = true;
        console.log("Connecting to Baqend");
        DB.connect(Config.baqendApp);
      }
    }
  });
};

As you can see this function returns a promise that resolves once Baqend is connected (mostly immediately).
While I was developing I forgot to call this function before doing some Baqend stuff and I could still load objects from Baqend but not update them.
DB.Page.load("/db/Page/d42c5a70-d301-41ab-bb8e-9fc47def0d4e").then(response => {
    response.route = "/test";
    response.save().then(r => {
      console.log(r);
    })
  });

This code would print the correctly updated object on the console but there was only one GET request being made. No update or save request was sent to Baqend.
let thing = new DB.Thing({type: "Test", data: data});
return thing.insert();

This code however would correctly insert the object. My ACL was set to public on everything so that was not the cause.
I'm sure this has something to do with the whole server side connection, client side connection, hot reload jimbo jambo that is going on on my end but it would still be nice to get an error of some kind if I call update and there isn't even a request being send.

Sorry, it seems the connection was not the error.


fix Big-o-notation from exponential time to polynomial time in videos/big-o-notation-a-few-examples

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace 9655 with an issue no): Closes #9655

Description

Editied the question concerning big-o-notation from exponential time(previous incorrect reference) to polynomial time.

@RP99 Thanks for the PR -- however, I have concerns about making the lesson text and quiz diverge from the video which I have expressed here. I'm going to mark this as blocked until we get some more input in there.
Thanks for your patience!

@atjonathan was this covered by your hikes recording session the other day?

@Bouncey, no. I don't believe we need to worry about diverging, these kind of changes have been made before.


Fixed bug when getting DOF resolutions

It looks like you missed one other reference to GetDOFResolutions. I believe this line should also be updated to GetActiveDOFResolutions.
@Stefanos19 Can you make this change and verify that the planner still works?


group by method not working with Grafana 8.4.x

Hi!
I really like your plugin and it does exactly what I need.
In some (graph / bar chart ) panels, I am using the experimental functions to group by different metrics.
This was working perfectly fine until I upgraded Grafana to the 8.4.x branch.
The panel labels are not shown properly anymore, but just the repeated field alias.
Plugin version: 1.3.1
Working Grafana version: 8.3.7
Non working Grafana version: 8.4.x
How it should look like:

The issue:

Plugin / datasource settings:

PS: I always need to do an additional group by / count for the metrics by using the transform option. Otherwise the graph is not shown and only the legend is populated (with wrong numbers):

Is there a way to not depend on / add the transformation, as I always have to add the "count" transformation per metric, which can be dynamic in my case. Meaning for new metrics, I have to add another setting in the transformation to do the count calculation.
Many thanks!

I will also like to know what about this functionality. For me V8.3.4 its working. I have to upgrade to 8.5. I also raised this few days ago https://github.com/marcusolsson/grafana-json-datasource/issues/275#issue-1210080703

@marcusolsson Can you please help here regarding group by?

hi, as this has been a very old issue, could you please check with the current grafana and plugin version, and see if it works or not? if not, could you please provide a way to reproduce it? i mean, the exact configuration of the datasoure-plugin, and also the JSON file that we fetch. thank you!


[Feature Request] Option to hide name of app in today view widget

I didn't take this picture, but the idea is to hide what's circled in it on the homescreen. The widgets have been added to it through HSWidgets. Could this be hidden on just the homescreen by an update to this tweak? If this is off-topic, I apologise.

Image

HSWidgets is mostly responsible for providing the widgets on your homescreen, any UI customizations for those widgets would either be up to the widget or other UI customization tweaks. In this case I think there are a few tweaks that customization how today widgets look which should work with HSWidgets. Those tweaks probably change how it looks for both homescreen (today widgets using HSWidgets) and today page (today widgets on today page). If you want it to only change homescreen that would be a compatibility issue for that tweak.
I personally think that shouldn't be added to HSWidgets, however it is possible if someone wanted to though it would most likely conflict with almost all those UI customization tweaks.


Update README

The README currently doesn't have any technical details abbout the python backend or Android app frontend

and ensure you have a repository fork


remove unused field which prevents successful build

Since there's a #[deny(warnings)] the build fails because of a unused field in a struct.

Thanks for the PR! DriverSession.driver is actually held so it is dropped when DriverSession is dropped. I just pushed a1cb1311ca97ca65945da420862d3b3f11578de5 to master that should fix this. Please let me know if that works for you.

I also pushed that change as v0.2.2, so cargo update should fix it for you.

Yes, now everything builds fine. Thanks


add robot-simulator

Curious why you used if compare(robot[3], "north") = 0 then rather than if equal(robot[3],"north") then, especially seeing as you only appear to be interested in  = 0 and not in < 0 or > 0. It's not a big issue, but wanted to know why you chose one over the other

I was having trouble comparing the sequences with = so I figured I needed to do something special. I came across compare first in the docs so that’s what I used. I’ll update the example later today.


kv(cdc): set enableOldValue correctly

Signed-off-by: qupeng<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: ref #5610
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-all-tests

/merge

/run-integration-test
/run-kafka-integration-test
/run-unit-test


Unexpected situation arose thrown when module transformer is enabled.

There seems to be a major issue right now when accidiently enabled the module transformer.
It just throws with this error:
An unexpected situation arose. Please raise an issue at https://github.com/rollup/rollup-plugin-babel/issues. Thanks!

which is neither helpful or correct as it seems.
In this case it seems that Babel Plugin Rollup is unable to match the generated code to one of the snippets. The code throwing this error looks like this:
var inputCode = 'class Foo extends Bar {};\nexport default Foo;';
var check = core.transform( inputCode, options ).code;

if ( ~check.indexOf('class ') ) {
	options.plugins = (options.plugins || []).concat( fallbackClassTransform );
	check = core.transform( inputCode, options ).code;
}

if ( ~check.indexOf( 'import _inherits' ) ) { helpers = RUNTIME; }
else if ( ~check.indexOf( 'function _inherits' ) ) { helpers = INLINE; }
else if ( ~check.indexOf( 'babelHelpers' ) ) { helpers = EXTERNAL; }
else {
	throw new Error( 'An unexpected situation arose. Please raise an issue at https://github.com/rollup/rollup-plugin-babel/issues. Thanks!' );
}

I understand that the code has to check something here to figure out wether to target helpers, the runtime, etc.
The code being generated when modules are transformed looks like this:
"use strict";

var _interopRequireDefault = require("@babel/runtime/helpers/builtin/interopRequireDefault");

exports.__esModule = true;
exports.default = void 0;

var _inherits2 = _interopRequireDefault(require("@babel/runtime/helpers/builtin/inherits"));

class Foo extends Bar {}

var _default = Foo;
exports.default = _default;

I figure we could improve the situation by adding alternative matchers to the if-else construct:
if ( ~check.indexOf( 'import _inherits' ) || ~check.indexOf( 'helpers/builtin/inherits' ) ) { helpers = RUNTIME; }

This modification is for Babel v7 with runtime helpers enabled. I am not sure whether there is something we could change for the other options, too.
After adding this the real error from Rollup is showing up that the module transformer is the real issue:
Error: It looks like your Babel configuration specifies a module transformer. Please disable it.

Would love to accept a PR to improve the current situation 😉 Although the additional check could be improved (I think).

I'll have a look!

Playing with your test suite... adding my preset to one of the class tests I see the following output code being generated:
"use strict";

var _interopRequireDefault = require("@babel/runtime/helpers/builtin/interopRequireDefault");

exports.__esModule = true;
exports.default = void 0;

var _inheritsLoose2 = _interopRequireDefault(require("@babel/runtime/helpers/builtin/inheritsLoose")),
    Foo =
/*#__PURE__*/
function (_Bar) {
  (0, _inheritsLoose2.default)(Foo, _Bar);

  function Foo() {
    return _Bar.apply(this, arguments) || this;
  }

  return Foo;
}(Bar);

var _default = Foo;
exports.default = _default;

WIP

Seems like I found the smallest .babelrc combination which crashes:
{
  "presets": [ "@babel/env" ],
  "plugins": [ "@babel/external-helpers", "@babel/transform-runtime" ]
}

PR is ready. Please check whether this is okay. Thanks!

Fixed by #225


help(mat-table): Why does matColumnDef not need the asterisk notation?

What are you trying to do?
I was currious was *matCellDef, *matHeaderCellDef, and *matRowDef are all using structural/asterisk notation but the matColumnDef is not? Is it because the former are using some template container and matColumnDef basically just gets/sets the class name? Could you give an explanation with an example?
What troubleshooting steps have you tried?
N/A
Reproduction
N/A
Environment

Angular: 12.0.0
CDK/Material: 12.0.0
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS

Sort of - it's a necessity to provide templates to the table but also give a way for the table to grab references. It's not the clearest API but its as simple as Angular will let us make it


Device discovery stopped working / internal server error

At some point since recently upgrading HomeAssistant to 2021.4.x, Airsonos device discovery has stopped working and are no longer being offered on my local network.
Add-on version: 3.0.0
System: Home Assistant OS 5.13  (armv7 / raspberrypi4)
Home Assistant Core: 2021.4.6
Home Assistant Supervisor: 2021.04.0
The log indicates a successful start-up of the add on (but does not mention any specific devices being discovered...not sure if it ever did) and even with DEBUG level turned on there are no entries that would suggest a problem, just regular "Presence checking" messages.
One thing I noticed, but am not sure if it's indicative of a problem, is that when I visit http://<IP_ADDRESS>:49152 in my browser (where <IP_ADDRESS> is the IP of my HA device), I get an HTTP 500 response:
HTTP/1.1 500 Internal Server Error
SERVER: Linux/5.4.83-v7l, UPnP/1.0, Portable SDK for UPnP devices/1.6.19
CONNECTION: close
CONTENT-LENGTH: 60
CONTENT-TYPE: text/html

But, I am not sure if that is supposed to work or if it worked before when devices could be discovered.
I realize this may not be a problem with this addon but am posting here in case others are experiencing the same.

Noting that this issue continues. A few more data points:
Today I restarted the add-on multiple times just to change log levels, and in some cases, it found some of the sonos devices, but not all of them. Here's what one startup looked like where it found two devices:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-banner.sh: executing...
-----------------------------------------------------------
 Add-on: AirSonos
 AirPlay capabilities for your Sonos (and UPnP) devices.
-----------------------------------------------------------
 Add-on version: 3.1.0
 You are running the latest version of this add-on.
 System: Home Assistant OS 5.13  (armv7 / raspberrypi4)
 Home Assistant Core: 2021.5.4
 Home Assistant Supervisor: 2021.04.3
-----------------------------------------------------------
 Please, share the above information when looking for help
 or support in, e.g., GitHub, forums or the Discord chat.
-----------------------------------------------------------
[cont-init.d] 00-banner.sh: exited 0.
[cont-init.d] 01-log-level.sh: executing...
Log level is set to DEBUG
[cont-init.d] 01-log-level.sh: exited 0.
[cont-init.d] airsonos.sh: executing...
[cont-init.d] airsonos.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[22:09:56] INFO: Starting the AirSonos server...
[22:09:56.511592] main:1420 Starting airupnp version: v<IP_ADDRESS> (Mar 13 2021 @ 17:30:02)
[22:09:56.513620] Start:1130 Binding to <IP_ADDRESS>:49152
[22:09:56.842295] AddMRDevice:1008 [0xb2b34008]: adding renderer (Playroom)
[22:09:56.842773] bind_socket:791 socket binding 10 on port 58137
[22:09:56.843325] UpdateThread:871 Updating configuration /config/airsonos.xml
[22:09:56.861659] MasterHandler:669 [0xb2b34008]: subscribe success
[22:09:57.041143] AddMRDevice:1008 [0xb2b36358]: adding renderer (Living Room)
[22:09:57.041592] bind_socket:791 socket binding 12 on port 59341
[22:09:57.042091] UpdateThread:871 Updating configuration /config/airsonos.xml
[22:09:57.063601] MasterHandler:669 [0xb2b36358]: subscribe success
[22:10:16.018132] UpdateThread:726 Presence checking
[22:10:16.374699] UpdateThread:779 [0xb2b34008] UPnP keep alive: Playroom+
[22:10:16.500860] UpdateThread:779 [0xb2b36358] UPnP keep alive: Living Room+

After another few minutes, it found one more of the Sonos devices. (I have more that it hasn't found.) There were also a few messages like this:
[22:12:41.005512] MasterHandler:646 [0xb2b386a8]: Auto-renewal failed, re-subscribing
[22:12:42.007916] MasterHandler:646 [0xb2b36358]: Auto-renewal failed, re-subscribing

I can't tell why it would behave differently between restarts, and have no idea why it's finding some speakers but not others.

Confirming that this issue is still present with the latest version of everything:

core-2021.6.5
supervisor-2021.06.3
AirSonos 3.1.1

Confirming that this issue is still present.

Confirming that this issue is still present with the latest versions of everything.

Confirming that this issue is still present with the latest versions of everything. But, it seems like it's not something that's going to get attention, so I'm closing this and will look at switching to another tool. Thank you.


Deploy BGP Spine/Leaf infrastructure on a HV

This patch includes changes in the libvirt_manager role to deploy VM
that simulate a spine/leaf infrastructure using the reproducer.yaml
playbook.
The main change is that the VMs created on the hypervisor from a certain
type (computes, ocp, etc) can have interfaces connected to different
networks. Example:

compute-0 is connected to leaf-0
compute-1 is connected to leaf-1
ocp-0 is connected to leaf-2
ocp-1 is connected to leaf-3
etc

This patch also includes values.yaml.j2 templates included in the
ci_gen_kustomize_values role that will be used to generate BGP CRs using
kustomize.
Finally, a new scenario file, bgp-4-racks-crc.yml, is included with the
parameters necessary to use the previously described changes.
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running
[X] Appropriate documentation exists and/or is up-to-date:

[X] README in the role

recheck

/test pre-commit

@eduolivares heya! would it be possible to get a "small" molecule scenario to ensure the boolean, and related tasks, are working correctly? Not that I don't trust the code, but that would also ensure no regression arise in the future.
To do that, you can:

copy the current directory in molecule to, for instance, spin_leaf
modifiy the "prepare.yml" and "converge.yml" accordingly

That new scenario will be triggered directly from molecule, in the same run. Maybe ensuring things are properly cleaned before would be good (calling the cleanup_layout.yml from a cleanup.yml play in the molecule scenario directory).
No need to deploy 10th of thousands of NIC, just a couple, to ensure things are properly attached.

@eduolivares heya! would it be possible to get a "small" molecule scenario to ensure the boolean, and related tasks, are working correctly? Not that I don't trust the code, but that would also ensure no regression arise in the future.
To do that, you can:

copy the current directory in molecule to, for instance, spin_leaf
modifiy the "prepare.yml" and "converge.yml" accordingly

That new scenario will be triggered directly from molecule, in the same run. Maybe ensuring things are properly cleaned before would be good (calling the cleanup_layout.yml from a cleanup.yml play in the molecule scenario directory).
No need to deploy 10th of thousands of NIC, just a couple, to ensure things are properly attached.

ok, I have just added something for this. I haven't been able to test it, so most probably it won't work yet.

/approve
@eduolivares we'll have to figure out the impact of this patch on IPv6 support addition, especially #1649 (and subsequent tasks not yet started)

/lgtm


Remove ppx_tools again

It was introduced by 26f12520e58461f64b92fcccb161bc64f2c877d5 to patch
1.13.7's release into 1.13.8. We don't need it in master anymore

Sorry for adding that back in!

Np at all =)


Support for AudioMixerGroupController and etc.

I noticed there does not seem to be support for Audio Mixer groups, Support for them would be appreciated.

@theclashingfritz thanks for PR.
Yep all those classes aint implemented yet. It is pretty easy to implement basic class structure using https://github.com/mafaca/TypeTreeGenerator if you need it for your own purposes. However, regarding utinyripper main problem here is those new asset types require to find all version changes, some of them require special converters. It takes abnormal amount of time.

Closing because there is an issue https://github.com/mafaca/UtinyRipper/issues/143 with similar enhancement.


fix: update user agent values to be consistent across plugins

Issue #

Description

add missing framework meta data that provides the user agent string in the Geo and Logger plugin
update API plugin to get the user agent string from framework meta data to be consistent with the rest of the plugins

General Checklist

[ ] ~Added new tests to cover change, if needed~
[x] Build succeeds with all target using Swift Package Manager
[x] All unit tests pass
[x] All integration tests pass
[x] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] ~Documentation update for the change if required~
[x] PR title conforms to conventional commit style
[ ] ~New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()~
[ ] ~If breaking change, documentation/changelog update with migration instructions~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3178 (1846cbe) into main (2dc5996) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 92.85%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #3178   +/-   ##
=======================================
  Coverage   64.16%   64.16%
=======================================
  Files        1068     1067    -1
  Lines       36149    36128   -21
=======================================
- Hits        23196    23183   -13
+ Misses      12953    12945    -8

Flag
Coverage Δ

API_plugin_unit_test
66.52% <91.66%> (-0.30%)
:arrow_down:

AWSPluginsCore
69.55% <ø> (ø)

Amplify
48.01% <ø> (ø)

Analytics_plugin_unit_test
86.39% <ø> (ø)

Auth_plugin_unit_test
74.56% <ø> (+0.08%)
:arrow_up:

CoreMLPredictions_plugin_unit_test
59.44% <ø> (ø)

DataStore_plugin_unit_test
80.06% <ø> (-0.02%)
:arrow_down:

Geo_plugin_unit_test
54.06% <100.00%> (+0.13%)
:arrow_up:

Logging_plugin_unit_test
62.61% <100.00%> (+0.03%)
:arrow_up:

Predictions_plugin_unit_test
35.17% <ø> (ø)

PushNotifications_plugin_unit_test
69.43% <ø> (ø)

Storage_plugin_unit_test
54.10% <ø> (ø)

unit_tests
64.16% <92.85%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

.../RequestInterceptor/IAMURLRequestInterceptor.swift
11.62% <50.00%> (+2.10%)
:arrow_up:

...questInterceptor/APIKeyURLRequestInterceptor.swift
45.00% <100.00%> (-2.62%)
:arrow_down:

...stInterceptor/AuthTokenURLRequestInterceptor.swift
91.30% <100.00%> (+0.39%)
:arrow_up:

...n/Operation/AWSGraphQLSubscriptionTaskRunner.swift
71.16% <100.00%> (+0.21%)
:arrow_up:

...tionGeoPlugin/AWSLocationGeoPlugin+Configure.swift
100.00% <100.00%> (ø)

...Plugin/AWSCloudWatchLoggingSessionController.swift
38.59% <100.00%> (+0.54%)
:arrow_up:

... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Updates to HasPages and RelatesObjectTags

Updates to HasPages concern

Making improvements to make sure that the page_url is always up to date.
Only setting page_url when the page is published, before it would set when page was draft.
Allowing you to unset the primary page. Automatically unsets now when page is deleted.
Adding more comprehensive specs.
Adding a new with_primary_page scope to filter out objects without page_urls.

Updates to RelatesObjectTags concern

Updating the by_object_tags method, making it less inclusive.
Adding a new related_objects helper method for finding related objects by class.

:+1:


[cxx-interop] NFC: Remove unused method

importer::hasUnsafeAPIAttr is being used instead of this method.

@swift-ci please smoke test


Bug: LoggedUser does not save or work

Please make sure your bug isn't already listed on HASS.Agent's issue tracker:
https://lab02research.youtrack.cloud/
There's a list of open bugs & features on the right. On the left you can see what's being worked on, what's planned and what's ready for the next release.
If you're not sure, don't worry, just go ahead and we'll discuss :)

Describe the bug
Adding the sensor "LoggedUser" in the satellite service doesn't seem to work, when I add it it generates an error in the log, and although it appears added nothing is sent via MQTT and when you exit and return to the Satellite Service Config page, the sensor is gone. Readding it results in the same.
To Reproduce
Steps to reproduce the behavior:

Go to Satellite Service Config, Sensors.
Add new sensor "LoggedUser"
Send and Activate Sensors
Exit back to desktop
Repeat step one
Sensor is missing.

Expected behavior
Expect the sensor to return the value of the current logged in user, if no user is logged in "SYSTEM"
If the same sensor is added in hass agent, it saves but the output is meaningless, because the sensor does not work when a user is not logged in, and also it does not change when the user is changed.
Screenshots
If applicable, add screenshots to help explain your problem.

Misc info (please complete the following information):

Windows' UI language:  English International
HASS.Agent version: 2022.12.0

Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[x] Problem occurs in HASS.Agent
[x] Problem occurs in Satellite Service

Additional context
Add any other context about the problem here.
log.txt
Logs
If possible, please provide the logs of HASS.Agent and - if applicable - the Satellite Service. You can find HASS.Agent's logs by going to the main window, then Configuration -> Logging -> open logs folder. The Satellite Service's logs are in the same window, but the Satellite Service tab -> open service logs folder. If you want, you can mail them to<EMAIL_ADDRESS>

Did it work, problem solved?

Thanks for coming back to me!
I'm not sure, at the moment, only because I'm not certain that the "loggeduser" returns the user thats logged in. I'm looking to
use HASSagent as a replacement for IOT Link, and the features that I use are not exactly replicated in HASSagent.
Namely, I want to know what user is signed on, I have automations based on the user logged in, and SYSTEM which appears in IOT Link when the log on screen is displayed, and also IOT link has immediate shutdown, hibernate and restart scripts with when run immediately perform the action requested. I've done the immediate shutdown with a custom command shutdown /p /f the others I cannot replicate.
Logged user just shows this:

and not the user, and loggedusers shows this:

If someone else logs on then it adds them to the list.
I explictly want to know the user, that is logged in and using the machine, so I don't know if thats possible.
It seems to work better on the beta though, although I'm getting a few exception errors and its crashed a couple of times.
Thanks!

Can you send me the exceptions?
I agree that it's useful to know who's actually using the machine, might need to make a seperate sensor for that.

Its only done it a couple of times after I installed the beta, I will try and find them and send them along.

Hey @shuntfield, is this still an issue with the latest release?

@LAB02-Admin I haven't had chance to check yet, I don't know if I am configuring the satellite sensor right.
I want it to show the current user, it shows all users that are logged on but not the current user, is that correct?

I'm not sure that I am configuring the sensor correctly or if HASS Agent does what I want it to do:

The Top one is the Satellite service, it shows what users are actually logged into the machine, the bottom one is IOT Link.
What IOT Link shows is the user that is currently using the machine, if its on the login screen then it shows "system" so if you look at the coloured bands, you see on IOT link Purple which is "system" and Magenta which is "Home User" and "graha" when I am logged in on HASS satellite as I am logged in and also home user I get both, not just one.
It might be useful in another context but I only want to see what actual user is using the computer.
If that makes sense!
The Exception error hasn't appeared since the first time I got one.
Hope this helps!

You're right @shuntfield, I forgot the actual-logged-on part, created a ticket so I won't forget: hassagent-166
Thanks @blair287, I'll look into that as well

You're right @shuntfield, I forgot the actual-logged-on part, created a ticket so I won't forget: hassagent-166
Thanks @blair287, I'll look into that as well

Great stuff 👍🏻

Should be fixed in the latest beta if you want to test:
https://github.com/LAB02-Research/HASS.Agent/releases/tag/2022.14.0-beta1

@LAB02-Admin yup just tested it, and it works fine, it swaps to "None" when no user is logged in, but that is fine, I can use that - great stuff!


[discussion] Standardizing the sx style language across MUI

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
With the deprecation of makeStyles(), there are a few things we lose as far as reusability and fidelity:

How do we create reusable components with portable styles and props? We used to do this with makeStyles() but now we can’t/shouldn’t?
Where do we define other non-theme global styles? Maybe some utility classes like text or flexbox alignment, or reusable styles you want to be present throughout your app?

How do we add classNames? (I realize that there's a debate whether named styles are meaningful, and perhaps they're not).

This post explores some of that rationale, the challenges/pain, and some possible solutions.
Examples 🌈
No response
Motivation 🔦
(This is a tactical abstract of a story I wrote about this suggestion).
The pain
With the deprecation of makeStyles(), there are a few things we lose as far as reusability and fidelity:

How do we create reusable components with portable styles and props? We used to do this with makeStyles() but now we can’t/shouldn’t?
Where do we define other non-theme global styles? Maybe some utility classes like text or flexbox alignment, or reusable styles you want to be present throughout your app?

How do we add classNames? (I realize that there's a debate whether named styles are meaningful, and perhaps they're not).

Now, we can of course use styled() to wrap components in a style, but even then, that's not a set of reusable styles; they're individually defined on each element, and you'd have to define them again for every component you make.
Some ways I've considered working around this:
Workaround 1
Add a custom style property to a theme object and using the spread operator (...), mix it into the rest of your style. I don’t mind this, but it doesn’t quite feel the same as adding a class to your component, because we never use the className prop. It also doesn’t know anything about the class name you’ve given it, so the generated HTML on the page never includes it in the class tag.
You also have to be careful with the spread operator and deep copies. Depending on what you’re doing, you might be better off using deepmerge here instead.
Workaround 2
Create a higher scoped variable and reference it from the sx property . The upside to this is it’s fast and we can use the power of sx again (🥳), but the downsides are that we can’t do it globally—it only works in your local component file (unless we made a separate module… maybe?), and the generated code will make a copy of the style for each of the sx references.
But also, while spread/deepmerge are fine, they're not very idiomatic, and there's a fair amount of room for error.
I also have found some REALLY weird things when using pre-defined sx props, and I don't know if this is bug-worthy or not, I can't repro it very well. In this case, I was mixing in a color prop { color: 'primary.main' } with a const { flexDirection: 'column' }. But I digress.
Workaround 3
Use an external CSS file. I’m not sure I like this, though:

Adding an external stylesheet means you (probably) end up with a separate build step to manage your plain CSS. You might lose TypeScript validation checking fidelity here (e.g., a typo in your .css file might appear to be valid in your React component’s className prop), and more moving parts means more things that could go wrong.
You break the opinionated model of React components and the MUI system, which could lead to a bunch of weird problems that are difficult to troubleshoot. External styles load in a different order, so you’ll spend your time wondering why styles aren’t applying, or why others are clobbering things you didn’t intend them to. There’s also the namespace conflict and collision risk.
Styling the component HTML for MUI components is tough. They often contain multiple nested elements, with MUI-specific names like .MuiSlider-thumb, and you’ll have to figure out what they all are. Difficult to maintain, difficult to write.

Ask
(Disclaimer: because sx is wrapping Emotion, there is maybe another better way of doing this I don't know about. If so, please let me know!)
I wish there were a way to fix this pain using sx everywhere, with true support for reusable styles. Why?

sx is awesome, and I love it.
I don’t want to context switch. I want to know that whatever styles I’m writing are all using the same superset of CSS so that there’s no chance of getting confused. This is arguably the most important of all my pain points.
I want linting to work everywhere. If I write an sx style block in a theme declaration, the system should be able to tell me if I made a mistake. (Maybe less relevant for .js, but definitely for .ts).
Naming things doesn’t always matter, but it’s often helpful for debugging styles, and coming from a plain HTML/CSS background, not using identifiable class names feels like a loss? Not a deal breaker though.
MUI is opinionated about a lot of things, but how to declare global styles and utility classes doesn’t seem to be one of them. We should fix that.
I don’t understand the performance implications of the myriad ways of putting styles into an app. Are some better than others? Probably—and I’d rather the system just told me what to do, rather than me having to think about it.

So how could we make this better? These might be throwaway ideas, but at least could spark some ideas.
Idea 1
A new hook like makeStyles() that uses the sx superset.
import * as React from 'react'
import { styled } from '@mui/system'

const useStyles = styled.sx({
  flexCenter: {
    display: 'flex',
    alignItems: 'center',
    justifyContent: 'center',
    flexBasis: 'fit-content',
    flexDirection: {
      xs: 'column',
      sm: 'row',
    }
  }
})

export default function MyComponent(props) {
  const classes = useStyles(props)
  return

}

Or perhaps there's a way we can create variables with all our reusable styles?
import * as React from 'react'
import { styled } from '@mui/system'

const flexCenter = styled.sx({
  display: 'flex',
  alignItems: 'center',
  justifyContent: 'center',
  flexBasis: 'fit-content',
  flexDirection: {
    xs: 'column',
    sm: 'row',
  }
})

const flexCenterDiv = flexCenter(MyComponent)( {
  return
My content

})

Idea 2
Support all of the sx superset in theme objects. (Note that this doesn't solve for reusability).
import * as React from 'react'
import { styled, createTheme, ThemeProvider } from '@mui/system'

const MyThemeComponent = styled('div')(({ theme }) => ({
  color: 'primary.contrastText',
  backgroundColor: 'primary.main',
  paddingX: {
    xs: 1,
    sm: 2,
    md: 3,
  },
  borderRadius: theme.shape.borderRadius,
}))

export default function ThemeUsage() {
  return (
    <ThemeProvider theme={customTheme}>
      <MyThemeComponent>Styled div with theme</MyThemeComponent>
    </ThemeProvider>
  )
}

Idea 3
Create a wrapper or dedicated section in a theme to support utility or global classes.
import { createTheme, styled } from '@mui/material/styles'

let theme = createTheme({
  shape: {
    borderRadius: 4,
  },
})

theme = createTheme(theme, {
  classes: styled.sx({
    flexCenter: {
      display: 'flex',
      alignItems: 'center',
      justifyContent: 'center',
      flexBasis: 'fit-content',
      flexDirection: {
        xs: 'column',
        sm: 'row',
      }
    },
    makeItRound: {
      borderRadius: theme.shape.borderRadius,
    })
  },
})

If we didn't want to worry about naming things, this idea works just as well without classNames, if we wanted to define sx props at the root:
import { createTheme, styled } from '@mui/material/styles'

let theme = createTheme({
  sx: {
    borderRadius: 4,
  },
})

theme = createTheme(theme, {
 sx: {
   display: 'flex',
   alignItems: 'center',
   justifyContent: 'center',
   flexBasis: 'fit-content',
   flexDirection: {
     xs: 'column',
     sm: 'row',
   }
   borderRadius: theme.sx.borderRadius,
 },
})

Thanks for kicking off the discussion. Here are some thoughts that I have on the matter.

How do we create reusable components with portable styles and props? We used to do this with makeStyles() but now we can’t/shouldn’t?

For reusable components, I would use the styled() API.

Where do we define other non-theme global styles? Maybe some utility classes like text or flexbox alignment, or reusable styles you want to be present throughout your app?

Whatever you had previously in the makeStyles input can now be a simple object/function. You can reuse them anywhere.

How do we add classNames? (I realize that there's a debate whether named styles are meaningful, and perhaps they're not).

I don't really understand this, you can add className on each component via the prop. You can reference that className in your styles.

For reusable styles you can still use the theme's mixins, and reference them anywhere in your components. For reusable styles per component, you can use the theme.components[MuiComponent]variants key. - https://mui.com/customization/theme-components/#adding-new-component-variants you can use the API for adding style overrides for different props combination too.

On using sx in the styled()/or anywhere else for that matter, we started a discussion here - https://github.com/mui-org/material-ui/issues/28678#issuecomment-971660852 I plan to work on it this week, feel free to share your thoughts on it.

Thanks for the reply @mnajdova, I finally have a few moments to sit down with your comments!
I agree for overriding and defining universal styles at the global level makes perfect sense, but one gap in coverage here is that we can't explicitly turn a style on and off, like you would with a class name. Consider:
<Box sx={{ display: 'flex', flexDirection: 'column', alignItems: 'center', justifyContent: 'center' }}>
    <Button>I <3 MUI!</Button>
</Box>

I can make a box have this style via a global theme override, either defining some style there (but not with sx notation!), or overriding the Mui class name.
But what if I wanted to have a generic utility class for use in some Box elements, or maybe a Container element, or even some Typography. I could create custom components for these using styled():
const CenteredBox = styled(Box, {
    display: 'flex',
    flexDirection: 'column',
    alignItems: 'center',
    justifyContent: 'center'
})

But even here, I have to do this for each different component type. Which is fine, but feels like a lot of overhead compared to a single CSS class.
I think there are several ways to work around this, and maybe if nothing else, having an MUI opinion on what the right way of doing it in the docs is worth even more than trying to make a code change to support something new. (Adding sx support to global styles and theme objects notwithstanding!). You allude to this in

Whatever you had previously in the makeStyles input can now be a simple object/function. You can reuse them anywhere.

so maybe that's the best way to do it, and it should just be prevalent in the docs? The only thing I wasn't super confident on is the duplication of styles. A CSS class can be written once and used everywhere, but this still looks to me like each component where it's used is going to get its own unique class, potentially duplicating a lot of generated code. If I'm wrong, let me know!

There are differences in styled() vs. sx vs. makeStyles that really do make context switching hard, which you covered in your reference to consolidating these (yay!), but this doesn't seem like it covers using those in theme as well? Context switching the different syntaxes is HARD, and I do really hope we can get to a point where everything uses the same syntax and we don't have to context switch.

The rest of what you've replied with mostly makes sense, perhaps the only thing that stands out is that the class naming syntax on styled() via the slot and name props, which just feels a little awkward, but it works, so 🤷♂ !

@brandonscript we just merged https://github.com/mui-org/material-ui/pull/29833 which adds the possibility to use the sx syntax in styled() (and variants too, or basically anywhere else where a function of the theme is accepted :))

A CSS class can be written once and used everywhere, but this still looks to me like each component where it's used is going to get its own unique class, potentially duplicating a lot of generated code. If I'm wrong, let me know!

You are correct, when I said the <GlobalStyles /> component, I meant the scenario where you would define a custom class and use it where necessary. For example:
<GlobalStyles styles={`
  .some-custom-class {
    display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
  }
`} />

// somewhere in your code:
<Box className="some-custom-class" />
<Typography className="some-custom-class" />

Note just that the GlobalStyles are injected first, so you may need to bump specificity to override some things if that is the intention.

There are differences in styled() vs. sx vs. makeStyles that really do make context switching hard, which you covered in your reference to consolidating these (yay!), but this doesn't seem like it covers using those in theme as well, which means in theme, we still can only use standard CSS syntax? Context switching the different syntaxes is HARD, and I do really hope we can get to a point where we can use the same sx superset everywhere.

You can use them in the variants for example, see https://github.com/mui-org/material-ui/pull/29833/files#diff-f8a5f0719307210a712f3796197c8dbfaaf5b3dc6bcea2a3ca9cd7e4e410fe28R99 (I don't see other use-case there at this moment, I wouldn't add them in the styleOverrides as we want to slowly move developers to use the variants and have one API for overriding styles via theme.

Not a fan of styled(). I just refer the sx styles like this -
import { SxProps, Theme } from '@mui/material';

type SxStyles = Record<string, SxProps<Theme>>;

export function sxStyles<T extends SxStyles>(arg: T): T {
  return arg;
}

const styles = sxStyles({
  loading: (theme) => ({
    mt: 4,
    zIndex: (theme) => theme.zIndex.drawer + 1
  }
});

<Box sx={styles.loading} />

code autocomplete works except for the breakpoints sm, xs, etc.
It would be nice if an utility (like sxStyles above) can be provided out of the box.

@vinayr you can do this using the experimentalSx. See https://mui.com/system/styled/#how-can-i-use-the-sx-syntax-with-the-styled-utility

Is there a plan to un-experimental the experimental_sx?


New code button

I added a few style changes to the navbar, and content change to make it clearer how to add a new editor.

I'm working on adding the ability in the "Add new" dropdown to also add here, as that's my goto when I don't know what to click.

I'm not familiar with *.pug style templates, and I don't know to make a new source code appear by clicking a button inside the source code.
Closes #1162

I like the menu option, good choice of icon.
For the code you'll need to edit static/panes/editor.js and add in Editor.protottype.initButtons somewhat the following:
var addEditorButton = this.domRoot.find('.btn.add-editor');

    this.container.layoutManager
        .createDragSource(addEditorButton , getCompilerConfig)
        ._dragListener.on('dragStart', togglePaneAdder);

    var getEditorConfig = _.bind(function () {
        return Components.getEditor();
    }, this);

    addEditorButton .click(_.bind(function () {
        var insertPoint = this.hub.findParentRowOrColumn(this.container) ||
            this.container.layoutManager.root.contentItems[0];
        insertPoint.addChild(getEditorConfig);
    }, this));

I think... main.js uses hub.addAtRoot(), don't know if that makes more sense than just the usual insert code, but I suggest to try and see what happens!

Had a bit of trouble with the initButtons, I went ahead redefined this that is scoped to the InitButtons since there were a few different this scopes in the Init function. Also refactored a few duplicate functions  and ordered the calls and variable creations so the order is the same and based on how the UI is .
Save first
Add New button tab:
Compiler
conformance
editor.

So! I like this change: thank you! I'm glad everything fits in nicely and it just about fits on slim windows (before the styling kicks in and everything becomes a hamburger icon). One thing we might consider is turning all the "add" things at the top into a single "Add" drop-down (with "Editor" and "Diff view" submenus). If you agree, feel free to make it part of this PR, or not, as you see fit. If you don't agree, that's also cool! Let's get the last few scopedThis/this things sorted (it's javascript confusion; I hope we can move to a newer JS version soon enough, or else transpile...but til then...) and then I'll look to final review and merge on Monday. Or, as I'm happy with the UX change, anyone can merge once we're happy with the code!
Thanks so much for this!

I'll try and get to it today or tomorrow. I would  like to give the dropdown an attempt but I'm not very familiar with this framework and it would take me a good while to implement that. I think I could look how the "More" button is done and go from there.
I'd be concerned that you have two different add buttons that do almost the same thing and it's kind of duplicated.

I'm surprised how easy you had it to add a new dropdown, went ahead and did that I'm open to suggestions for text:

I've also found lately that sometimes I just want to have two sessions side by side and I didn't like to click the UI reset.

How do I verify locally the policies dropdown is rendering correctly and the reset UI layout works correctly?

Set ```
cookiePolicyEnabled=true
privacyPolicyEnabled=true
In your `etc/config/compiler-explorer.local.properties` (Create it if needed, or change the values from the file named `compiler-explorer.default.properties` in the same folder, but remember not to push those changes then)

I'm not convinced on the borders around the buttons, doesn't feel consistent with the rest of the buttons on the site.
Code looks good to me.

As someone new to this project and website, I implemented this in a way to make people who weren't familiar with it have an easier time.
The goal was to make the actions that can be done easier to perform and more intuitive for a new user.  Right now I feel the buttons are unclear that they are buttons until you hover over them.

I took a look at this: I think I like the look of this. I am going to merge and put this on beta for further comment :)


Simplfied m2m_recursive.tests.

Hey @felixxm.
Diff looks nice, but there's a test error (on MySQL/MariaDB, SQLite by the looks of it):
$ ./runtests.py m2m_recursive
...
======================================================================
ERROR: setUpClass (m2m_recursive.tests.RecursiveM2MTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  ...
  File "django/db/models/fields/related_descriptors.py", line 840, in __init__
    (instance, self.pk_field_names[self.source_field_name]))
ValueError: "<Person: Anne>" needs to have a value for field "id" before this many-to-many relationship can be used.

From the bulk_create docs:

If the model’s primary key is an AutoField it does not retrieve and set the primary key attribute, as save() does, unless the database backend supports it (currently PostgreSQL).

@carltongibson Thanks! Ahh, I wanted to be too clever :wink:


NIFI-11965: Remove ignite tests which are always stuck

Summary
NIFI-11965
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

As discussed on the jira ticket, I removed the problematic Integration tests


Filter issue with multiple exclude values

Work on #421 and #440, still in progress...

Hello,
i want to propose a complete solution of your pull request:

The main problem is line 585 of zcl_excel_converter_alv in the attached code of the pull request.
ls_filt-fieldname is still there. Must be changed to <fs_field_range>-fieldname.

I prefer to read the first line of the data table to get the component types for the first loop
like for example method zcl_excel_converter->create_table does it too.
Also i have an easy check if the fieldname of wt_filt exists in the data table.
This is unfortunately gone in the attached code. if you insits on this please catch at least
the exception COMPONENT_NOT_FOUND of method get_component_type and insert a CHECK sy-subrc = 0
below.

Modus filter = abap_undefined: Using the advantage of collecting all values for each fieldname
i delete the table line immediately if not selected. Now it is really as simple as that.

I included a sort for wt_filt by fieldname and a corresponding fieldname compare in the first loop
to have no need of reading lt_field_range again. Therefore now this table is a standard table.

I included an append initial line for the range table of lt_field_range.
That avoids the data reference for the range WA.

zcl_excel_converter_alv-get_filter.txt
Do you like to continue the work on your pull request or shoud i open a new issue ?

Thanks, please create a new pull request. I will retire all my old draft pull requests.

Too old and reworked by @darnoc312, so retiring my draft PR.


configure path to /usr/bin

Enable to use command nginx when nginx is installed via source compile.

Thanks for opening this PR. With the merge of the chef_nginx codebase back into the nginx cookbook I believe it’s no longer necessary. I’m going to close this out now, and I hope you can check out the massive changes that landed on master here https://github.com/chef-cookbooks/nginx/pull/435


Py4JJavaError: An error occurred while calling o108.load. : org.elasticsearch.hadoop.EsHadoopIllegalArgumentException: Cannot find mapping for netflow-*/ - one is required before using Spark SQL

hi，I am a beginner in spark.
I tried to deploy using ELKSJ, but I encountered a problem【My operating environment is a ubantu18.04 virtual machine (VMware)】

`---------------------------------------------------------------------------
Py4JJavaError                             Traceback (most recent call last)
 in
----> 1 flowDF = es_reader.load("netflow-*/")
/usr/local/spark/python/pyspark/sql/readwriter.py in load(self, path, format, schema, **options)
164         self.options(**options)
165         if isinstance(path, basestring):
--> 166             return self._df(self._jreader.load(path))
167         elif path is not None:
168             if type(path) != list:
/usr/local/spark/python/lib/py4j-0.10.7-src.zip/py4j/java_gateway.py in call(self, *args)
1255         answer = self.gateway_client.send_command(command)
1256         return_value = get_return_value(
-> 1257             answer, self.gateway_client, self.target_id, self.name)
1258
1259         for temp_arg in temp_args:
/usr/local/spark/python/pyspark/sql/utils.py in deco(*a, **kw)
61     def deco(*a, **kw):
62         try:
---> 63             return f(*a, **kw)
64         except py4j.protocol.Py4JJavaError as e:
65             s = e.java_exception.toString()
/usr/local/spark/python/lib/py4j-0.10.7-src.zip/py4j/protocol.py in get_return_value(answer, gateway_client, target_id, name)
326                 raise Py4JJavaError(
327                     "An error occurred while calling {0}{1}{2}.\n".
--> 328                     format(target_id, ".", name), value)
329             else:
330                 raise Py4JError(
Py4JJavaError: An error occurred while calling o108.load.
: org.elasticsearch.hadoop.EsHadoopIllegalArgumentException: Cannot find mapping for netflow-*/ - one is required before using Spark SQL
at org.elasticsearch.spark.sql.SchemaUtils$.discoverMappingAndGeoFields(SchemaUtils.scala:105)
at org.elasticsearch.spark.sql.SchemaUtils$.discoverMapping(SchemaUtils.scala:91)
at org.elasticsearch.spark.sql.ElasticsearchRelation.lazySchema$lzycompute(DefaultSource.scala:229)
at org.elasticsearch.spark.sql.ElasticsearchRelation.lazySchema(DefaultSource.scala:229)
at org.elasticsearch.spark.sql.ElasticsearchRelation$$anonfun$schema$1.apply(DefaultSource.scala:233)
at org.elasticsearch.spark.sql.ElasticsearchRelation$$anonfun$schema$1.apply(DefaultSource.scala:233)
at scala.Option.getOrElse(Option.scala:121)
at org.elasticsearch.spark.sql.ElasticsearchRelation.schema(DefaultSource.scala:233)
at org.apache.spark.sql.execution.datasources.DataSource.resolveRelation(DataSource.scala:403)
at org.apache.spark.sql.DataFrameReader.loadV1Source(DataFrameReader.scala:223)
at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:211)
at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:178)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
at py4j.Gateway.invoke(Gateway.java:282)
at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
at py4j.commands.CallCommand.execute(CallCommand.java:79)
at py4j.GatewayConnection.run(GatewayConnection.java:238)
at java.lang.Thread.run(Thread.java:748)`
This is an error that occurs when running the code in Jupiter
Seems to be the problem with this line of code：
flowDF = es_reader.load("netflow-*/")
It seems that something is not loaded
From the log, it seems that the data in elasticsearch is not found or the data format is wrong. But I am not sure if this is the problem, and after the mirror deployment is completed, I cannot access elasticsearch through port 9200, and I have no idea to solve it.
In addition, I have never found the deployment location of the netflow mirror
Has anyone encountered a similar problem?

Hi @DAYceng, you must first feed some netflow records to the collector, so that the pipeline pushed the data to an appropriate ES index. Then you can define the ES mapping for this particulart index using Kibana UI.
After that everything should fall in place! Hope you will find the above useful :)

thanks for your answer


Release 1.20

Q
A

Bug fix?
no

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
-

License
Apache 2.0

What's in this PR?

Release 1.20 chart versions.
Checklist

[X] Code meets the Developer Guide
[X] User guide and development docs updated (if needed)
[X] Related Helm chart(s) updated (if needed)

Let's see if we can merge some of those dependabot PRs first.


luci-app-mwan3: bugfix

make use of luci.model.uci to fix #1740

Signed-off-by: Dirk Brenken<EMAIL_ADDRESS>

@hnyman @feckert just in case we need this for 18.x

I have seen that /var/state is deprecated. But i have talked to jow- that this is OK for now but in the new master i have to re-factory luci-app-mwan3.
If we need this the we could merge this.

Currently /var/state seems to be used in LuCI only by mwan3, luci-app-splash, Freifunk stuff and meshwizard. Of these, probably only mwan3 has really wide usage.


[BUG] Unifi OS 4.0.6 on UDM PRO Not getting device details

Checklist

[X] I'm using the latest Zabbix Server Release.
[X] I'm using a local UniFi Account with at least RO permission on Zabbix.
[X] I have configured the template following README.md instruction.

Describe the Bug
When using the template with Network Application 8.4.54 / Unifi OS 4.0.6, the device details are not displayed, giving the error:

Preprocessing failed for: {}

Failed: cannot extract value from json by path "$.data[0].adopted": no data matches the specified path

I saw that there was a problem here recently with Unifi OS 4.0.3, is it possible that it is a similar problem?
MACROS

Context

Zabbix Template Release: ex. main
Zabbix Server Release: 7.0.2
UniFi Network Release: 8.4.54
UniFi Network Type: UDMP 4.0.6

Hi @roalvesrj,
I was experiencing the same issue using Zabbix Server 7.0.2. After a little bit of troubleshooting, it seems like it was a bug related to the "HTTP agent" on that specific Zabbix Server version that caused the error. Today I have upgraded Zabbix Server to 7.0.3 and it solved the issue.
Can you try to do the same and let me know if it solves the issue? Thanks 🙏🏻

I experienced the same problem, but it's working now with Zabbix server 7.0.3

Zabbix Server 7.0.3 release solve this issue.

I have the same error on zabbix 7.0.4 server


Optimize initial compilation warning prompts

Search before asking

[x] I searched the issues and found no similar issues.

The initial compilation should not give people a wrong feeling. Although it can be compiled in the end, try to use green or ordinary information to express the missing libprotoc information.
初始编译不应该给人一种错误的感觉，虽然最后是可以编译的，但是尽量使用绿色或者普通信息的方式表达缺失libprotoc的信息
What happened + What you expected to happen
friendly reminder
友好的提示
Reproduction way
Anything else
Are you willing to submit a PR?

[x] Yes I am willing to submit a PR!

fixed in this PR: https://github.com/alibaba/yalantinglibs/pull/483


Need some help setting this up... (Possible JSON error)

I tried using this the original way it was intended. I changed the settings to correspond with the server I am currently in and installed discum and even got it on Python as well. I tried running the main .Py file after doing those prerequisites but it would immediately close out. So I looked at the page and found you said to run it in IDLE mode. I did that and it continues to give me this error. Sorry for the inconvenience but can I get some help with this issue.

On the read me there is a link for a Json validatior so copy the content of your json file into the text box and it will point out errors in ur json file
Sent from my iPhone

On Jul 18, 2021, at 7:46 PM, 75hrtz @.***> wrote:

I tried using this the original way it was intended. I changed the settings to correspond with the server I am currently in and installed discum and even got it on Python as well. I tried running the main .Py file after doing those prerequisites but it would immediately close out. So I looked at the page and found you said to run it in IDLE mode. I did that and it continues to give me this error. Sorry for the inconvenience but can I get some help with this issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Alright. So i did what you said and fixed it up but now its giving me this error

Wait im sorry, turns out i had named it 'Channel_id' instead of 'Channel_ids' i changed it and its working properly now. Thank you very much for your super quick response and help!


STREAMS-429 - fix failing tests in streams-plugins

progress on STREAMS-430 - update jenkins to run advanced integration testing

merging now, in the interest of promptly restoring https://builds.apache.org/job/streams-project/ to stable


Profile for CentOS - Digital Ocean

Initial creation of bootstrap scripts for CentOS and sample profile.
Still needs inclusion in cmd/create.go

Hi, thank you very much for your contribution.
Looking from the mobile, this looks good. The only thing missing is VPN. Do you plan on adding it, do you need any help? (you can take a look at #217)
If not, you will have to change private IP gathering from tun0 to eth1 (or to use Metadata API for Private Networking IP).

Got it. I was basing this bootstrap from the simple example.
Will use your bootstrap as a base and push. Better to use OpenVPN than not.

That sounds good. If you need any help, I'll be glad to help you. If you need more resources on OpenVPN, take a look at #178.
The only thing it's missing is that one certificate is used across all nodes. I have plan how to fix it, but we agreed to keep it simple for this PR and to fix it in new one.

Yes let's add the VPN using #217 as an example please

Can we also add an integration test for this please? It can be a separate PR, just need an issue in place

Can we please add this to cmd/create.go please? We will also need to start working on a piece of documentation that is a large table like /docs/envvar.md that will serve as the directory of all of the cloud/operating system permutations we get with kubicorn

Should we keep different scripts per distro for openvpn (openvpnMaster.sh and openvpnNode.sh) or adapt the existing one to support multiple distros?

The bootstrap scripts are a bit undecided at this point.. for now can we please go with the

keep it simple
philosophy?

Do whatever makes the most sense for you, if it means another script, please code it in. I really want to encourage this.

I decided to use separate scripts. Easy to maintain and customize when dealing with multiple distros.

LGTM - excellent work here. Thank you so much :rainbow_flag: :heart:


Fix paths in readme

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master     #3   +/-   ##
=======================================
  Coverage       100%   100%
- Complexity        0     41   +41
=======================================
  Files             2      2
  Lines            92     92
=======================================
  Hits             92     92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a12b5...64edefc. Read the comment docs.


Unauthorised response when clicking save in data table

@jongpie I've setup the Data Table component in a screen flow to display a custom metadata type and configured it to be editable. The 'save' action kicks off a deployment and it is successful in the org. However, the table's loading spinner is stuck showing.

My org has the My Domain feature enabled. In the logs I can see "System.HttpResponse[Status=Unauthorized, StatusCode=401]" and in the browser console I can see "Malformed JSON: Expected '{' at the beginning of object"

From your guide, am I right in thinking that I don't think I need to do anything else in setup to authorise that connection?

After some investigation, I came to the conclusion that you can no longer connect to the API directly regardless of the My Domain settings as per the user guide. I managed to get this working by using:

A connected app in the same org
A named credential with OAUTH2 that is pre-authorised with the system admin access. Use a Permission Set to assign the named principle to the System Admin user
Updated the code to use a Named Credential in the callout.

I've updated the error handling a little using showToast (WIP) to handle the error better if the call to the Deploy Result API still doesn't authenticate. Previously, it was failing and then not telling the user why it was failed unless you looked at the debug logs.
See the PR with some proposed changes.


@jest/console 25.2.4 build output ts3.4 contains error

🐛 Bug Report
@jest/console 25.2.4 build output contains an error
To Reproduce
Install jest in a npm project.
Open<EMAIL_ADDRESS>look at line 22:
 assert(value: unknown, message?: string | Error): asserts value;
It produces:
ERROR in node_modules/@jest/console/build/ts3.4/CustomConsole.d.ts:22:61 - error TS1144: '{' or ';' expected.

22   assert(value: unknown, message?: string | Error): asserts value;

Expected behavior
Does not fail with compilation error.
envinfo
  System:
    OS: Windows 10 10.0.18363
    CPU: (12) x64 AMD Ryzen 5 2600 Six-Core Processor
  Binaries:
    Node: 10.15.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.15.2 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^25.2.4 => 25.2.4

This has to be a dirty working directory when I published. Bah. Will fix

I am also seeing this with version 25.2.4

I'll publish a fixed package today. You can upgrade to<EMAIL_ADDRESS>to unblock in the meantime

Fixed in 25.2.6


Add a throw_if_any_failed kwonly argument in delete_blobs.

throw_if_any_failed should be a boolean which defaults to True, and when set should throw an error even if there's a single failure in the batch.

Please sync on the exact parameter name with the rest of the storage crew.


Vote:- Angshu Bhadra

Vote for Angshu Bhadra @angshuBHADRA

Hey @hashAMAN you can vote by hitting the emoji buttons or leaving a comment in the related issue of @angshuBHADRA
https://github.com/EddieHubCommunity/awesome-github-profiles/issues/464
I will close this issue :)


Move llvm_ext.o to .build

llvm_ext.o is not a source file, it's a binary build artifact. Thus it should not be in the src folder.
This has caused a need for several workarounds like https://github.com/crystal-lang/distribution-scripts/blob/8bc01e26291dc518390129e15df8f757d687871c/docker/alpine.Dockerfile#L40 to exclude this artifact when packaging the src folder for distribution.

Needs some testing if you can still build a compiler out of the compiler sources shipped in the standard library though.

@jhass Sorry, I don't follow what you mean. llvm_ext.o is not part of any distribution package (if it is, that's only by accident). All you need to do to build the compiler is to run make crystal. The Makefile makes sure to build llvm_ext.o if it's missing, whatever path it's placed at.

I'm talking about usecases outside running make inside this repository but using the fact that the compiler is shipped as part of the standard library. The only real example I have the experimental doc generator I have in crystal-gobject:  https://github.com/jhass/crystal-gobject/blob/main/src/generator/doc.cr

Yeah, they would continue to work. Assuming the library is built and placed a the expected path (.build/llvm_ext.o). The path in lib_llvm.cr is hard coded relative to that file, so there's no difference there. If you're building the library without the compiler's Makefile, you'll have to adjust the target path, though.

You're arguing to not package it anymore. How can it be at any expected path then.

It actually is not supposed to be packaged. And it's effectively only available in some distribution channels, and probably just by accident, because it happens to be placed in the source folder.
It doesn't make sense to package this binary file, because it's built for a specific LLVM version which might not even be available where the package is installed.
Fixing that is the whole point of this PR.
If we actually want to package this library, it should be done in the same way as we ship libgc and must make sure to install the matching LLVM version. It would probably be good to ship it in the *-build docker images.

Having the matching LLVM version is a no brainer in regular packaging. Daily bread and butter of distribution packaging. General cross distribution packaging is the special case, it should not stand in favor for any arguments just because that's the only type we do ourselves.
Shipping this is essential if we want to support reusing parts of the compiler as part of what we offer in the standard library. If we drop shipping this we should not pretend and stop shipping anything but the parser in the standard library too.

If we want to ship this, we should make sure to ship it correctly in the appropriate packaging workflows. But it's definitely not a source file and shipping it as part of the stdlib/compiler source distribution is a hack at best.

Shipping this is essential if we want to support reusing parts of the compiler as part of what we offer in the standard library. If we drop shipping this we should not pretend and stop shipping anything but the parser in the standard library too.

The compiler is entirely private code. It's technically possible to use it, because it lives alongside stdlib and can be required from user code. But it's not an official public API and it may break at any moment without notice.
So yes, we should perhaps remove the compiler source code from distribution. I don't think it's a big issue, though.

I always understood https://github.com/crystal-lang/crystal/commit/2a227fb5e2e675f09529dca897d714c799e0b754 as specifically making the compiler part of stdlib.

I don't know the intention of that change. But anyways the compiler code is nodoc.

There are examples on how to use the compiler:
https://github.com/crystal-lang/crystal/tree/master/samples/compiler
How os that related to this change? I'd like the compiler to be used from other shards. I understand it's nodoc, but eventually it could be documented.

That's really just a packaging problem. If the compiler is to be compiled with the Crystal distribution package, that package has to provide the necessary libraries. But the packages we currently provide don't even depend on/provide llvm, so having llvm_ext would do nothing (except for the *-build docker images).
The compiler examples don't do codegen, so they don't need LLVM at all. Same applies for any other tool using only non-codegen parts of the compiler (ameba would come to mind, for example).

Just because a part of stdlib is depending on some other dependency that does not make it a hard dependency for the package. There's the concept of optional dependencies in about any package management system out there for a reason.

I feel like your argument is missing the scope here. Neither this PR nor any of my comments speaks against shipping a pre-built ˋllvm_extˋ in distribution packages. But this needs to be implemented in the packaging workflow. It's not a feature for source distribution.
The only necessary prerequisite in the source repository is to remove the hard-coded path to ˋllvm_ext.oˋ and allow discovery via regular library path. But that's orthogonal to this change. This doesn't change the nature of the lib path, it just changes the location.

In an ideal world you're right, but pragmatically applying this without a path forward, without the additional changes you propose will result in a regression of the status quo.

A regression only concerns some distribution packages which happened to ship the library in the src path. If that's supposed to continue, the fix is easy to implement in the respective distribution workflow.

I would argue it not being present is an omission in any existing packaging.
For example the Archlinux package installs stdlib to /usr/lib/crystal directly. This change forces it to either use a meaningless subdirectory like /usr/lib/crystal/std and a confusing hidden directory at /usr/lib/crystal/.build or worse to install it at /usr/lib/.build.

The motivtation is quite practical, actually. Some package build tools complain about an architecture-dependent file in ˋ/usr/share/ˋ which should never have been in the ˋsrcˋ folder in the first place. Of course, this is easy to work around by removing the file. But this requires an extra step in the distribution workflow and this PR is supposed to fix the problem at its root.

That only seems like one more argument to not install stdlib to /usr/share to me :P

I must add, the packaging problem is also a problem of library discovery. Currently, the path to llvm_ext.o is hard-coded to a file relative to the stdlib source code (before and after this PR).
For proper re-usability we must remove this hard-coded path. It should probably be just the library name and we must make sure to have the directory in the lib path. That would be .build for the compiler repository and $ORIGIN/../lib/crystal for distribution packaging (with #10877).

I agree with @jhass and this would be a regression. Things like https://github.com/bcardiff/crystal-tool-demo would be more complicated to build/use unless you are also a compiler developer.
If the llvm_ext needs to be moved out of the std-lib it should be put on lib as with the gc.a, and not removed. Then it can continue to be used (when there is a matching llvm installed).

This change by itself can't really be a regression. It might be considered a regression if we don't ship llvm_ext.o in the tar.gz. This could be arranged regardless of this change.
But considering that llvm_ext.o strictly depends on the available libraries on the target system (most importantly the LLVM version), it's very likely to be broken already. Unless a matching LLVM version is available, it's useless.
If we want to distribute an object file depending on a specific LLVM version, we should only do that if we also ship the respective LLVM version with it.

If the llvm_ext needs to be moved out of the std-lib it should be put on lib as with the gc.a, and not removed. Then it can continue to be used (when there is a matching llvm installed).

The major problem is that llvm_ext.o depends on the LLVM version is was linked against. We simply cannot ship a single llvm_ext.o unless we hard wire it to the respective LLVM version and ship that as well. Its usefulness is limited because users can't choose which LLVM version to link against.
I think we can mitigate that by versioning the llvm_ext, so that we have separate libraries (llvm_ext-10.o, llvm_ext-13.o etc.). Then we can link against the one matching LLVM_CONFIG.
These libraries should typically be bundled in the distribution packages, so that using the LLVM stdlib module works out of the box. The package maintainers can decide which versions to ship.
Alternatively, we could consider building missing libraries on demand when lib_llvm_ext.cr is included but no matching library can be found. This could also be an addition to shipping pre-built libraries, as it allows shipping only libraries for the most important LLVM versions, and others works as well.

Closing. llvm_ext is no longer necessary when linking LLVM 18+ since #13946 and it's being phased out.


Make the Appcenter Android SDK compatible with the Material Components library

Describe the solution you'd like
At the moment using the Google Material Components library together with Appcenter does not work.
The Material Components library (https://github.com/material-components/material-components-android) helps developers to use a consistent material design on all devices regardless of Android version.
Using this library enables Buttons to deal with text colors that enable a ripple animation on a button click.
This makes it mandatory that all UI elements that use the new styles are Material Components.
At the moment the Update Dialog can not deal with the Material Component styles leading to a white Button text on a white Background.
It would be nice if the appcenter SDK works out of the box even with the modern Material Design Components.
Describe alternatives you've considered
An alternative would be to create the Dialog ourselves to ensure the components can deal with modern styles.
Additional context

I would have liked to file this as a bug instead of a feature request. Your support sadly could not help with this and asked me to file a feature request to future proof the SDK.

We implemented our own update dialog but the next dialog that comes up:
Asking me to deactivate security settings is still a broken dialog from Appcenter:


Add script to automate publish msal-core files to CDN

Script to automate upload msal-core generated files to the CDN. Requires a .env file in the msal-core folder including environment variables with SAS keys for the cdn.

Coverage remained the same at 80.998% when pulling 4f844f4a5a2fabdb4a0b8e1edcc0e8bb3e9f27b9 on automate-cdn-core into 0f352a074dff709304d87e3543c89472a1bcf875 on dev.


When closing a crowdsale, write info to debug log, not file

Storing extra information about a crowdsale, when closing one, in a file provides no gain, and this information is instead written to the log.

LGTM, ok to merge


Fix typo in platforms

Just a minor typo :)

@AndyButland can you merge this one as well? 👍

Will do - thanks.


Redirect console.error to stderr

<EMAIL_ADDRESS>commented:

Which version of PhantomJS are you using? 1.1 and 1.2
What steps will reproduce the problem?

Have a webpage with console.error calls in it

What is the expected output? What do you see instead?
All output comes to stdout
Which operating system are you using?
*NIX (OSX and Linux)
Did you use binary PhantomJS or did you compile it from source?
Both

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #150.
:star2:   13 people had starred this issue at the time of migration.

Confirmed to still be an issue in 2.0:
$ cat test-cerr.js
console.log("This should go to stdout");
console.error("This should go to stderr");
phantom.exit(0);
$ ./bin/phantomjs test-cerr.js 2> /dev/null
This should go to stdout
This should go to stderr

  :0 in error

There is also console.warn. In node, it is directed to stderr too.

@kawing-chiu, even with console.warn, it seems like you would still have to apply the same hack with something like:
console.warn = function () {
    require("system").stderr.write(Array.prototype.join.call(arguments, ' ') + '\n');
};

Did you actually find a shorter way to do it?

No. I think your method is quite good and I've been using it for while. :)

bug still exists at v2.1.1
These hot patch saved me!
console.warn = function () {
    require("system").stderr.write(Array.prototype.join.call(arguments, ' ') + '\n');
};

console.error = function () {
    require("system").stderr.write(Array.prototype.join.call(arguments, ' ') + '\n');
};

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed. In the future, if we see the need to attend to this issue again, then it will be reopened.
Thank you for your contribution!


⚠ Bofrost.at has degraded performance

In afb1b58, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1386 ms

Resolved: Bofrost.at performance has improved in 5bfb92b.


Fold errors where using vimdiff

Hi when I diff two SQL files in VIM with vorax loaded I get the following error occurring every few seconds:
Error detected while processing function <SNR>51_CreateFolds:
line    8:
E352: Cannot erase folds with current 'foldmethod'
Error detected while processing function <SNR>51_CreateFolds:
line   13:
E350: Cannot create fold with current 'foldmethod'
Press ENTER or type command to continue

If I don't have vorax loaded it doesn't happen. I guess the folding done by vorax is interfering with the folding done by the diff. I wonder if there is an easy way to fix this, or at least turn off vorax when vim is used for diffing two files?
Thanks,
Michael

Hi,
Does it work if you disable vorax folding by setting the g:vorax_folding_enable = 0?
Alec.

Yes that works. Do you think it's possible to set this only when vim is used for diff (i.e. when it's launched with vim -d)?

Not sure how, but you can write your own wrapper script for that. Not that elegant, I admit, but it should work...


Adds create action container shown in flyout

Signed-off-by: Drew Baugher<EMAIL_ADDRESS>Description

Check List

[ ] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Another flaky rollup unit test..
FAIL public/pages/RollupDetails/containers/RollupDetails/RollupDetails.test.tsx (5.428 s)
●  spec › can delete a rollup job
TestingLibraryElementError: Unable to find an element by: [data-test-subj="deleteTextField"]


HI, Im on the freecodecamp challenge where you make a deadlink with a # and the line is not able to be edited... so I can't go on can you help?

Challenge Make Dead Links using the Hash Symbol has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.


feat(sandbox): added UI to chat example

added UI to chat-notification example
gh-345
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[x] Performed a self-review of my own code
[x] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

@AnkurBansalSF fix sonar issue


adding support for initial centered Windows

Hi @mojbro are you still active here? It feels a little bit strange to merge my own PRs ;-).
Otherwise I need this for another project though.

Sorry @phaus - I am certainly not active here but I see you’re working. That’s great! Feel free to just merge as you wish!


Added an alternative way to initialize/load some models (for non-…

Added an alternative way to initialize/load some models (for non-Android codes), tokens, hotwrods and keywords, that initializing/loading from memory buffers. The original usage of model initialization unchanged.
Basically, I just added additional "const char* $_buf_begin, const char* $_buf_end" vars ($ == encoder/decoder/joiner/model), if they are non-nullptr, sherpa will attempt to init the models from the memory starting from "$_buf_start" to "$_buf_end" in priority to the original filename strings.
Also, I added "tokens_buf_str, hotwords_buf_str and keywords_buf_str", if they are non-empty, sherpa will attempt to treat them as the content directly, and using istringstream rather than iftream.
the supported models are:
online models:
OnlineTransducerModel
OnlineParaformerModel
OnlineWenetCtcModel
OnlineZipformer2CtcModel
OnlineNeMoCtcModel
offline models:
  OfflineTransducerModel
  OfflineParaformerModel
  OfflineNemoEncDecCtcModel
  OfflineWhisperModel
  OfflineTdnnModel
  OfflineZipformerCtcModel
  OfflineWenetCtcModel
  OfflineSenseVoiceModel

keywordspotter models:
  KeywordSpotterTransducer

Could you also add tests for your changes?

By the way, I suggest that you change one model config per pull-request and add test for the changes.
Otherwise, the pull-request is very large and you need to write lots of tests to cover your changes.


Line #5 in main.tf tagsnot expected here

Locally I ended up commenting out the tags line
Error: Unsupported block type
on .terraform/modules/transfer-server/terraform-aws-transfer-server-0.0.4/main.tf line 5, in resource "aws_transfer_server" "transfer_server":
5:   tags {
Blocks of type "tags" are not expected here. Did you mean to define argument
"tags"? If so, use the equals sign to assign it a value.

Thank you for your bug report, problem fixed.


Improved rendering of README

Not all markdown formatting is supported.
Would it be possible to support the following styles?
https://markdown-it.github.io/
Thanks

What in particular isn't supported?
Directory Lister is using Parsedown for fast, GitHub flavored markdown processing. This limits support to the full markdown spec + GitHub specific markdown which I believe is sufficient. However, we may have missed some styling and would be happy to fix it if so.

After a quick look I just found Parsedown Extra. This may be a drop-in replacement that will accomplish a lot of the extra features. I will look into this.

I have implemented the change to Parsedown Extra and this is now available in the beta.5 release. Please try this out and let me know of any specific issues you still have.

It's clean! Thank you very much for your reactivity and your work.


output.globalObject set to this is undefined when "use strict" #8608

Describe the bug
#7742 by @kentcdodds changed the webpack config for output.globalObject to be this instead of webpack's default window, so that webpack chunk loading would work in Workers.
Unfortunately, making the assumption that this is the global object isn't always safe because if the code is concatenated or otherwise wrapped into code that has "use strict" strict mode will also apply to inner functions within that scope, and this will be undefined in some cases, most notably in the webpack runtime chunk/code since itself contains code that executes inside of an IIFE and so this === undefined
I admit, this is very much an edge case and outside the normal usage of CRA. But if there's a fairly trivial way for us to solve this, it would notably help my use case because I cannot control the code provided to me--I would have to no longer support users who use CRA unless they ejected so that they could change that webpack config option. That's not your problem of course lol just clarifying why I'm checking in.
Wanted to at least open the dialog and see if someone had thoughts on a simple solution?
Did you try recovering your dependencies?
n/a
Which terms did you search for in User Guide?
globalObject, runtime, webpack, etc.
Environment
n/a
Steps to reproduce
Build a CRA project
Concatenate one or more of the chunks together, with the runtime.
Put "use strict" at the the top of the code.
Run the code in any supported JS env.
See error of this being undefined due to strict mode.
Expected behavior
Something other than this is used. I'm not immediately sure, since globalThis isn't supported in IE (which CRA supports) and forcing folks to include a polyfill is presumably off the table.
Actual behavior
TypeError: Cannot read property 'webpackJsonpsomeproject' of undefined because this is undefined under strict mode.
Reproducible demo
Non-trivial to provide, but if required I can consider making one. I think those who are familiar with how CRA + webpack builds work will likely know immediately what I'm referring to, but maybe not hehe 😄

webpack debug
webpack debug
ok,this is the solutions, but i do not thing it is a good job.

cra webapck config is :
globalObject: 'this',
if use strict, "this" will be undefined.
But I found that your compiled code didn't use strict mode，How did you do it？


Setup code coverage reporting with coveralls

Setup the code coverage reporting to coveralls

This issue is closed by: https://github.com/ciena-blueplanet/ember-block-slots/pull/14


SELF_SIGNED_CERT_IN_CHAIN problem

I'm starting to integrate Danger with our Bitbucket Server. I'm seeing this issue when call danger-swift pr https://bitbucket.server/pr/50
Error:  { FetchError: request to xxxxx failed, reason: self signed certificate in certificate chain
    at ClientRequest.<anonymous> (/snapshot/danger-js/node_modules/node-fetch/lib/index.js:1444:11)
    at ClientRequest.emit (events.js:182:13)
    at TLSSocket.socketErrorListener (_http_client.js:382:9)
    at TLSSocket.emit (events.js:182:13)
    at emitErrorNT (internal/streams/destroy.js:82:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  message:
   'request to xxxxx failed, reason: self signed certificate in certificate chain',
  type: 'system',
  errno: 'SELF_SIGNED_CERT_IN_CHAIN',
  code: 'SELF_SIGNED_CERT_IN_CHAIN' }

Anyone knows how to resolve?

ok I saw this in source code of danger-js https://github.com/danger/danger-js/blob/258cde31bed5047f68a9f5c9f9ebc425a567c896/source/platforms/bitbucket_server/BitBucketServerAPI.ts#L346


[Enhancement] Fix log error

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[x] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/streamload/StreamLoadTask.java
1
1
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Feature request: cofigurable time field

Thanks for your great plugin.
Is it possible to define the time in a field, so that I can get something like this:
[KW14] Samstag, 23. März 2024, 08:35 Uhr

I think the biggest challenge with this would be styling and sizing on smaller screens.
Right now, only the time is displayed. Am I understanding correctly that you're looking to put in the full date?

Yes. On smaller screens you can try the shorter
[KW14] Sa., 23.03.2024, 08:35 Uhr
or
[KW14] Sa., 23.03.2024 08:35 Uhr
or


Testing: adding a fake func, but verify the prow

Fixes #
Proposed Changes

Release Note

/retest all

/test all


Check is it work correctly with signed values

https://github.com/linksplatform/Numbers/blob/845de22950f44d97a8aa739c0857602bc8ed147f/Platform.Numbers/Integer.cs#L8

This struct is obsolete and removed from the library.


Bug: Application is linked to winspool.dll instead of winspool.drv

Which crate is this about?
windows
Crate version
master branch
Summary
Attempt to use any winspool functions (e.g. SetDefaultPrinterW) results in application linking to winspool.dll instead of winspool.drv and it fails to start.
Expected behavior
The winspool.drv DLL name must be used for imported functions.
Actual behavior
The winspool.dll DLL name is used for imported functions which is missing.
Additional comments
No response

@riverar I thought you already opened a bug for this on win32metadata but I can't find it.

Related to https://github.com/microsoft/win32metadata/issues/714


Fixed Typo

updated "fucion" to function
Summary
Please include a summary of the change and which issue is fixed. Please provide the motivation for why this change is necessary at this stage of the product development cycle.
Fixes # (provide jira link which is addressed with this change)
Documents # (provide links to document if any)
Testing
Please describe the new tests introduced if any.
Please describe manual test execution if any.
Next Steps
Please describe follow up changes if any.

Closing this because we have updated the README


The Harvey wiki has imprecise references around networking

Expected behavior
The section https://github.com/Harvey-OS/harvey/wiki/Getting-Started#running-harvey refers to a "class C network". While this is at least technically correct, it is quite likely imprecise use and should be removed.
It is my belief that the author was referring to the subnet size, and that (should this belief be accurate) the author is mistaken. In this case, please refer to RFC1519 which has superceded the RFC791 definition for a number of decades.
In the alternate case, please update the document to be clearer about this usage.
Further information or detail may be gleaned in the links below:

https://en.wikipedia.org/wiki/Classful_network
https://networkengineering.stackexchange.com/a/6502

Steps to reproduce

click links
read
???
profit!

Fixed, thanks.


Parsing multiple programs concurrently

I recall that some time ago, I was not able to parse in multiple boogie programs because the Parser was populating static variables. That is not the case anymore. Does anyone know if it is safe to parse in multiple programs concurrently (with no synchronization)?

Closing due to inactivity.