{"protobuf"=>{" Build error"=>nil}}

Hello,
I am trying to install on Windows with vcpkg because it is a dependency of this library: https://github.com/ros-industrial/abb_libegm
 C:\dev\vcpkg\vcpkg install protobuf:x64-windows
Computing installation plan...
The following packages will be built and installed:
protobuf[core]:x64-windows -> 3.19.4
Detecting compiler hash for triplet x64-windows...
Restored 0 packages from C:\Users\inse9\AppData\Local\vcpkg\archives in 326.9 us.
Use --debug to see more details.
Starting package 1/1: protobuf:x64-windows
Building package protobuf[core]:x64-windows...
-- Using cached protocolbuffers-protobuf-v3.19.4.tar.gz.
-- Cleaning sources at C:/dev/vcpkg/buildtrees/protobuf/src/v3.19.4-3d4c96d55c.clean.
Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/dev/vcpkg/downloads/protocolbuffers-protobuf-v3.19.4.tar.gz
-- Applying patch fix-static-build.patch
-- Applying patch fix-default-proto-file-path.patch
-- Using source at C:/dev/vcpkg/buildtrees/protobuf/src/v3.19.4-3d4c96d55c.clean
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:128 (message):
Command failed: ninja -v
Working Directory: C:/dev/vcpkg/buildtrees/protobuf/x64-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
C:\dev\vcpkg\buildtrees\protobuf\config-x64-windows-out.log                                                                                Call Stack (most recent call first):
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:415 (vcpkg_execute_required_process)
ports/protobuf/portfile.cmake:33 (vcpkg_cmake_configure)
scripts/ports.cmake:145 (include)
Error: Building package protobuf:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `.\vcpkg update`.
Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+protobuf
You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title[protobuf]+Build+error
including:
package: protobuf[core]:x64-windows -> 3.19.4
vcpkg-tool version: 2022-03-25-d9702d9d89b9468c32efc3f18fb84c3021d7dbae
vcpkg-scripts version: 9d9a6f486 2022-03-30 (17 hours ago)
Additionally, attach any relevant sections from the log files above.

Can you help me how to solve?

@kappa95 I cannot reproduce this issue. Could you please provide the failure log and the sample repro code.
C:\dev\vcpkg\buildtrees\protobuf\config-x64-windows-out.log

Here it is
[1/2] "C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -E chdir "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-dbg" "C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -S "C:/dev/vcpkg/buildtrees/protobuf/src/v3.19.4-3d4c96d55c.clean/cmake" "-Dprotobuf_BUILD_SHARED_LIBS=1" "-Dprotobuf_MSVC_STATIC_RUNTIME=0" "-Dprotobuf_BUILD_TESTS=OFF" "-DCMAKE_INSTALL_CMAKEDIR:STRING=share/protobuf" "-Dprotobuf_BUILD_PROTOC_BINARIES=1" "-Dprotobuf_BUILD_LIBPROTOC=ON" "-Dprotobuf_WITH_ZLIB=OFF" "-DCMAKE_MAKE_PROGRAM=C:/dev/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/protobuf_x64-windows/debug"
FAILED: ../../x64-windows-dbg/CMakeCache.txt
"C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -E chdir "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-dbg" "C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -S "C:/dev/vcpkg/buildtrees/protobuf/src/v3.19.4-3d4c96d55c.clean/cmake" "-Dprotobuf_BUILD_SHARED_LIBS=1" "-Dprotobuf_MSVC_STATIC_RUNTIME=0" "-Dprotobuf_BUILD_TESTS=OFF" "-DCMAKE_INSTALL_CMAKEDIR:STRING=share/protobuf" "-Dprotobuf_BUILD_PROTOC_BINARIES=1" "-Dprotobuf_BUILD_LIBPROTOC=ON" "-Dprotobuf_WITH_ZLIB=OFF" "-DCMAKE_MAKE_PROGRAM=C:/dev/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/protobuf_x64-windows/debug"
-- The C compiler identification is MSVC 19.24.28315.0
-- The CXX compiler identification is MSVC 19.24.28315.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe - broken
CMake Error at C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/share/cmake-3.22/Modules/CMakeTestCCompiler.cmake:69 (message):
  The C compiler

    "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: C:/dev/vcpkg/buildtrees/protobuf/x64-windows-dbg/CMakeFiles/CMakeTmp

    Run Build Command(s):C:/dev/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe cmTC_8099d && [1/2] Building C object CMakeFiles\cmTC_8099d.dir\testCCompiler.c.obj
    [2/2] Linking C executable cmTC_8099d.exe
    FAILED: cmTC_8099d.exe
    cmd.exe /C "cd . && C:\dev\vcpkg\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_8099d.dir --rc=rc --mt=CMAKE_MT-NOTFOUND --manifests  -- C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo CMakeFiles\cmTC_8099d.dir\testCCompiler.c.obj  /out:cmTC_8099d.exe /implib:cmTC_8099d.lib /pdb:cmTC_8099d.pdb /version:0.0 /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
    RC Pass 1: command "rc /fo CMakeFiles\cmTC_8099d.dir/manifest.res CMakeFiles\cmTC_8099d.dir/manifest.rc" failed (exit code 0) with the following output:
    Impossibile trovare il file specificato
    ninja: build stopped: subcommand failed.

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:24 (project)

-- Configuring incomplete, errors occurred!
See also "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-dbg/CMakeFiles/CMakeError.log".
[2/2] "C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -E chdir "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-rel" "C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -S "C:/dev/vcpkg/buildtrees/protobuf/src/v3.19.4-3d4c96d55c.clean/cmake" "-Dprotobuf_BUILD_SHARED_LIBS=1" "-Dprotobuf_MSVC_STATIC_RUNTIME=0" "-Dprotobuf_BUILD_TESTS=OFF" "-DCMAKE_INSTALL_CMAKEDIR:STRING=share/protobuf" "-Dprotobuf_BUILD_PROTOC_BINARIES=1" "-Dprotobuf_BUILD_LIBPROTOC=ON" "-Dprotobuf_WITH_ZLIB=OFF" "-DCMAKE_MAKE_PROGRAM=C:/dev/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/protobuf_x64-windows"
FAILED: ../CMakeCache.txt
"C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -E chdir "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-rel" "C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe" -S "C:/dev/vcpkg/buildtrees/protobuf/src/v3.19.4-3d4c96d55c.clean/cmake" "-Dprotobuf_BUILD_SHARED_LIBS=1" "-Dprotobuf_MSVC_STATIC_RUNTIME=0" "-Dprotobuf_BUILD_TESTS=OFF" "-DCMAKE_INSTALL_CMAKEDIR:STRING=share/protobuf" "-Dprotobuf_BUILD_PROTOC_BINARIES=1" "-Dprotobuf_BUILD_LIBPROTOC=ON" "-Dprotobuf_WITH_ZLIB=OFF" "-DCMAKE_MAKE_PROGRAM=C:/dev/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x64-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v142" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x64" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=C:/dev/vcpkg" "-D_VCPKG_INSTALLED_DIR=C:/dev/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DCMAKE_DISABLE_SOURCE_CHANGES=ON" -G "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/dev/vcpkg/packages/protobuf_x64-windows"
-- The C compiler identification is MSVC 19.24.28315.0
-- The CXX compiler identification is MSVC 19.24.28315.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe - broken
CMake Error at C:/dev/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/share/cmake-3.22/Modules/CMakeTestCCompiler.cmake:69 (message):
  The C compiler

    "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: C:/dev/vcpkg/buildtrees/protobuf/x64-windows-rel/CMakeFiles/CMakeTmp

    Run Build Command(s):C:/dev/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe cmTC_e2735 && [1/2] Building C object CMakeFiles\cmTC_e2735.dir\testCCompiler.c.obj
    [2/2] Linking C executable cmTC_e2735.exe
    FAILED: cmTC_e2735.exe
    cmd.exe /C "cd . && C:\dev\vcpkg\downloads\tools\cmake-3.22.2-windows\cmake-3.22.2-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\cmTC_e2735.dir --rc=rc --mt=CMAKE_MT-NOTFOUND --manifests  -- C:\PROGRA~2\MICROS~2\2019\COMMUN~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo CMakeFiles\cmTC_e2735.dir\testCCompiler.c.obj  /out:cmTC_e2735.exe /implib:cmTC_e2735.lib /pdb:cmTC_e2735.pdb /version:0.0 /machine:x64  /debug /INCREMENTAL /subsystem:console  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
    RC Pass 1: command "rc /fo CMakeFiles\cmTC_e2735.dir/manifest.res CMakeFiles\cmTC_e2735.dir/manifest.rc" failed (exit code 0) with the following output:
    Impossibile trovare il file specificato
    ninja: build stopped: subcommand failed.

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:24 (project)

-- Configuring incomplete, errors occurred!
See also "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-rel/CMakeFiles/CMakeOutput.log".
See also "C:/dev/vcpkg/buildtrees/protobuf/x64-windows-rel/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

@kappa95  See the required Visual Studio components in https://github.com/microsoft/vcpkg-tool/pull/314.

@kappa95  any updates?

You have right. Some visual studio components were missing. Thank you so much!!


Add new base abilities to override list

GSE stores the base ability in macros as when You cast the base ability, the temporary or proc/talent updated version of the macro is cast by the game client automatically.  Eg if you have Crusade and /cast Avenging Wrath, Crusade is cast by WoW instead.  Unfortunately the reverse is not true.  If you /cast Crusade and don’t have the talent, it won’t cast Avenging Wrath.
There are some new talents and abilities, need to compile any changes.
Warrior:
Cleave -> Sweeping Strikes
Warbreaker -> Colossal Smash

Shadowlands Talents Name Base Spell Changes
https://docs.google.com/spreadsheets/d/1rJibHQBxvvNkNu1QfgBdurUvQl_egKczerd4Rx7eEGU/edit?usp=sharing

I added 3 more lines in the spreadsheet  at the bottom that I encountered recently that were not explicitly commented in the talent but did change/updated the macro names.

Could you tell me which lines they were as they may already be covered in the code.
TimothyLuke

On 13 Oct 2020, at 5:01 am, Luis Cestou<EMAIL_ADDRESS>wrote:

I added 3 more lines in the spreadsheet at the bottom that I encountered recently that were not explicitly commented in the talent but did change/updated the macro names.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sorry Timo, sure thing.
Lines in spreadsheet:
34
35
36

Im on a phone and cant see the spreadsheet 8-)  (I'm literally doing the
release via a today phone as I wont be home.)
On Tue, 13 Oct 2020 at 06:56, Luis Cestou<EMAIL_ADDRESS>wrote:

Sorry Timo, sure thing.
Lines in spreadsheet:
34
35
36
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/698#issuecomment-707329084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMCFPISPQ4X5ENPP4KY4DSKNRALANCNFSM4SHK3UUQ
.

--
Timothy Minahan**M 0406 413 680  |  *E<EMAIL_ADDRESS>

Oh lol, I did also installed today google sheets in the phone to add those haha.
Anyway I'm off from work, these are the lines I was talking about:
New Moon | Half Moon | Balance
New Moon | Full Moon | Balance
Shadowform | Voidform | Shadow

I forgot to add this one also:
Void Eruption | Void Bolt | Shadow Priest

Shadow and void I have will add the other two before the release
TimothyLuke

On 13 Oct 2020, at 8:32 am, Luis Cestou<EMAIL_ADDRESS>wrote:

Oh lol, I did also installed today google sheets in the phone to add those haha.
Anyway I'm off from work, these are the lines I was talking about:
New Moon | Half Moon | Balance
New Moon | Full Moon | Balance
Shadowform | Voidform | Shadow
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

NEw Moon, Full Moon and Half Moon don't replace each other - they are unique abilities that enable and disable each other but its not a Base -> upgrade thing.  You need to manage this in the macro.

The behavior I got with New Moon and Half Moon / Full Moon is the same as others. I had to put "/use" so it wouldn't change if for some reason you do not use all the charges and stays half way and the macro happens to update the name.
The macro spell got renamed at some point to Half Moon or Full Moon once and it would not fired up that spell anymore until I changed it back to New Moon. New Moon it works for both but not backwards if that makes sense.

The problem is they are a smart spell but they are not a base/override spell.  They each have their own spell Id and are available at all times.  They do have conditions that need to be met and using a /use on these is only a placebo.  You think it’s doing something but it actually isn’t doing anything except breaking it for non English macros.
TimothyLuke

On 13 Oct 2020, at 11:22 pm, Luis Cestou<EMAIL_ADDRESS>wrote:

The behavior I got with New Moon and Half Moon / Full Moon is the same as others. I had to put "/use" so it wouldn't change if for some reason you do not use all the charges and stays half way and the macro happens to update the name.
The macro spell got renamed at some point to Half Moon or Full Moon once and it would not fired up that spell anymore until I changed it back to New Moon. New Moon it works for both but not backwards if that makes sense.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


DB: append time is inaccurate

Because we pull the timestamp before taking the write lock, a particular timestamp is not reflective of when the data was written to the DB, rather when we started waiting for the write-lock.
Simple fix is to pull the timestamp directly after acquiring the lock.

Actually, this should probably happen after spilling to disk, not directly after taking the lock.

Fixed in 0f2eefd6696c6474f79b01d841a35f224b278ac0


Adjust vue auth flow for new backend auth library

Auth endpoint returns access instead of token.  Auth header format should also be changed to JWT -> Bearer

this was fixed in latest release. We now have two endpoints for authenticating, each of which returns different format (for backwards compatibility).


[PE-D][Tester A] UG disallows editing of data files

Project requires “human editable text file” which would “allow advanced users to manipulate the data by editing the data file”, but UG disallows “editing the JSON data file directly”.

Labels: severity.Medium type.FeatureFlaw
original: Professional-Procrastinat0r/ped#6

In FAQ, just discourage


The "69" easter egg is broken

Easter egg disabled:

Easter egg enabled:

Minecraft version: 1.16.5
Fabric loader version: 0.11.1
Fabric API version: 0.30.0
Mod Menu version: 1.16.0

Fixed in v1.16.1


Please Review my GtHub Profile and Portfolio

Items we can review on a live stream:

GitHub profile: https://github.com/NehaKoppikar
Portfolio: https://nehakoppikar.github.io/

Couple of tips on your portfolio -

The "PortFolio" on the top left corner is entirely unnecessary, I'd suggest removing it
typed.js for your bio doesn't make sense when all it's typing out is "Aspiring Data Scientist" over and over again. Add some points, or remove it entirely

The skill progress bars add no value. To anyone that's looking, what does 85% in Python mean? That you know 85% of everything in Python? Seems unlikely. I've seen a lot of recruiters get turned off by this, so either just list your skills out or divide them into "proficient in" and "familiar with".

Have you considered using a different template? Alignment is all over the place, and a fair bit hard to read tbh

Some more examples of bad alignment

Kaggle logo looks out of place here

This feels like it would belong more with the About section

If you're going to continue using this template (or for that matter, whatever you use), replace the stock background image with something that has a bit of your personality in it

Couple of tips on your portfolio -

The "PortFolio" on the top left corner is entirely unnecessary, I'd suggest removing it
typed.js for your bio doesn't make sense when all it's typing out is "Aspiring Data Scientist" over and over again. Add some points, or remove it entirely

The skill progress bars add no value. To anyone that's looking, what does 85% in Python mean? That you know 85% of everything in Python? Seems unlikely. I've seen a lot of recruiters get turned off by this, so either just list your skills out or divide them into "proficient in" and "familiar with".

Have you considered using a different template? Alignment is all over the place, and a fair bit hard to read tbh

Some more examples of bad alignment

Kaggle logo looks out of place here

This feels like it would belong more with the About section

If you're going to continue using this template (or for that matter, whatever you use), replace the stock background image with something that has a bit of your personality in it

Thanks, @sreekaransrinath:
I have noted all your points and added them as issues on my GitHub repository to
I have used an existing bootstrap template {this one} as I learned HTML and CSS during MLH Local Hack Day: Build. What templates would you recommend to have a better alignment?

Thanks, @sreekaransrinath:
I have noted all your points and added them as issues on my GitHub repository to
I have used an existing bootstrap template {this one} as I learned HTML and CSS during MLH Local Hack Day: Build. What templates would you recommend to have a better alignment?

Portfolio is great but I think the heading " Portfolio" must be changed to "Project", as below the heading you are showing projects.

Portfolio is great but I think the heading " Portfolio" must be changed to "Project", as below the heading you are showing projects.

Thanks, @sreekaransrinath:
I have noted all your points and added them as issues on my GitHub repository too!
I have used an existing bootstrap template {this one} as I learned HTML and CSS during MLH Local Hack Day: Build. What templates would you recommend to have a better alignment?

Consider building a jekyll site. There's a bit of a learning curve, but it's definitely worth it, since there are some great portfolio templates out there built with jekyll (Just google "jekyll portfolio site github").
If you want to stick to HTML / CSS, take a look at https://html5up.net and https://templated.co

Thanks, @sreekaransrinath:
I have noted all your points and added them as issues on my GitHub repository too!
I have used an existing bootstrap template {this one} as I learned HTML and CSS during MLH Local Hack Day: Build. What templates would you recommend to have a better alignment?

Consider building a jekyll site. There's a bit of a learning curve, but it's definitely worth it, since there are some great portfolio templates out there built with jekyll (Just google "jekyll portfolio site github").
If you want to stick to HTML / CSS, take a look at https://html5up.net and https://templated.co

Thanks @Nitesh-thapliyal . I have made the change!

Thanks @Nitesh-thapliyal . I have made the change!

Thanks, @sreekaransrinath. I will start learning to build a website using Jekyll.

Thanks, @sreekaransrinath. I will start learning to build a website using Jekyll.

Thank you everyone for your inputs. As I am learning Jekyll (now) to build a new portfolio, closing this issue

Thank you everyone for your inputs. As I am learning Jekyll (now) to build a new portfolio, closing this issue

Hi @NehaKoppikar , I can review this on a live stream in the future if you like? If so, you can leave the issue open for now 🤓

Hi @NehaKoppikar , I can review this on a live stream in the future if you like? If so, you can leave the issue open for now 🤓

Sure! I have re-opened the issue

Sure! I have re-opened the issue

The title and favicon can be updated to a N in the same style as B 😆

Checkout my Portfolio which has a JD as a favicon

The title and favicon can be updated to a N in the same style as B 😆

Checkout my Portfolio which has a JD as a favicon

it looks great btw

Could you fix the typo in the title?

NOOO github-actions, it's still to be reviewed on a livestream


[spaceship] IAP creation with "WW" doesn't work

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Trying to create an IAP with pricing interval defined for country "WW" creates the IAP without any prices on it.
app = Spaceship::Tunes::Application.find("myapp")
app.in_app_purchases.create!(type: Spaceship::Tunes::IAPType::RECURRING,
                             versions: {
                                 "en_US"=>{
                                     name: "My IAP Name",
                                     description: "My IAP description"
                                 }
                             },
                             reference_name: "all_countries",
                             product_id: "all_countries",
                             cleared_for_sale: true,
                             review_notes: nil,
                             review_screenshot: nil,
                             family_id:0, # using real one in my code
                             subscription_free_trial: nil,
                             subscription_duration: nil,
                             pricing_intervals: [
                             {
                                 country: "WW",
                                 begin_date: nil,
                                 end_date: nil,
                                 tier: 1
                             },
                             ]
                             )

Checking in AppConnect website, the IAP was created without any pricing information.
Environment
🚫 fastlane environment 🚫

### Stack

| Key                         | Value                                                          |
| --------------------------- | -------------------------------------------------------------- |
| OS                          | 10.14.2                                                        |
| Ruby                        | 2.3.7                                                          |
| Bundler?                    | false                                                          |
| Git                         | git version 2.17.2 (Apple Git-113)                             |
| Installation Source         | /usr/local/bin/fastlane                                        |
| Host                        | Mac OS X 10.14.2 (18C54)                                       |
| Ruby Lib Dir                | /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib |
| OpenSSL Version             | LibreSSL 2.6.4                                                 |
| Is contained                | false                                                          |
| Is homebrew                 | false                                                          |
| Is installed via Fabric.app | false                                                          |
| Xcode Path                  | /Applications/Xcode.app/Contents/Developer/                    |
| Xcode Version               | 10.1                                                           |

### System Locale

| Error                       |
| --------------------------- |
| No Locale with UTF8 found 🚫 |

### fastlane files:

**No Fastfile found**

**No Appfile found**

### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.112.0 | ✅ Up-To-Date  |

### Loaded fastlane plugins:

**No plugins Loaded**

Loaded gems

| Gem                       | Version      |
| ------------------------- | ------------ |
| did_you_mean              | 1.0.0        |
| slack-notifier            | 2.3.2        |
| atomos                    | 0.1.3        |
| CFPropertyList            | 3.0.0        |
| claide                    | 1.0.2        |
| colored2                  | 3.1.2        |
| nanaimo                   | 0.2.6        |
| xcodeproj                 | 1.7.0        |
| rouge                     | 2.0.7        |
| xcpretty                  | 0.3.0        |
| terminal-notifier         | 1.8.0        |
| unicode-display_width     | 1.4.1        |
| terminal-table            | 1.8.0        |
| plist                     | 3.5.0        |
| public_suffix             | 2.0.5        |
| addressable               | 2.5.2        |
| multipart-post            | 2.0.0        |
| word_wrap                 | 1.0.0        |
| tty-screen                | 0.6.5        |
| tty-cursor                | 0.6.0        |
| tty-spinner               | 0.9.0        |
| babosa                    | 1.0.2        |
| colored                   | 1.2          |
| highline                  | 1.7.10       |
| commander-fastlane        | 4.4.6        |
| excon                     | 0.62.0       |
| faraday                   | 0.15.4       |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20180417 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 2.1.5        |
| gh_inspector              | 1.1.3        |
| json                      | <IP_ADDRESS>      |
| mini_magick               | 4.5.1        |
| multi_json                | 1.13.1       |
| multi_xml                 | 0.6.0        |
| rubyzip                   | 1.2.2        |
| security                  | 0.1.3        |
| xcpretty-travis-formatter | 1.0.0        |
| dotenv                    | 2.5.0        |
| bundler                   | 1.17.2       |
| faraday_middleware        | 0.12.2       |
| naturally                 | 2.2.0        |
| simctl                    | 1.6.5        |
| uber                      | 0.1.0        |
| declarative               | 0.0.10       |
| declarative-option        | 0.1.0        |
| representable             | 3.0.4        |
| retriable                 | 3.1.2        |
| mime-types-data           | 3.2018.0812  |
| mime-types                | 3.2.2        |
| jwt                       | 2.1.0        |
| signet                    | 0.11.0       |
| memoist                   | 0.16.0       |
| os                        | 1.0.0        |
| googleauth                | 0.6.7        |
| httpclient                | 2.8.3        |
| google-api-client         | 0.23.9       |
| google-cloud-env          | 1.0.5        |
| google-cloud-core         | 1.2.7        |
| digest-crc                | 0.4.1        |
| google-cloud-storage      | 1.15.0       |
| emoji_regex               | 0.1.1        |
| io-console                | 0.4.5        |
| libxml-ruby               | 2.9.0        |
| psych                     | <IP_ADDRESS>      |

*generated on:* **2018-12-26**

Does it work for other countries?
What output are you getting?


update URLs to piste portal

As the aife.economie.gouv.fr URLs are deprecated and will be retired in september 2023

Well this was irritating -- I had to fumble quite a bit with the formatting tooling. I thought CI was failing due to this issue: https://github.com/omnilib/ufmt/issues/127 but the behavior seems to have been related to an older version of black somehow getting installed: https://github.com/psf/black/issues/2531
Anyhow, setting explicit (transitive) dependencies for ufmt seems to have solved the issue.

I think I'll go ahead and self-merge this given the CI is now passing.


"List all versions" no longer working

With entries that have more than one version, the landing page has an "Other versions" field, where you have a drop down menu "List all version", which should show you all the versions of the resource, cf. e.g. http://hdl.handle.net/11356/1210
With (probably) the latest commit, this drop-down menu no longer works, it shows the spinning wheel forever. Tested on Firefox and Chrone.

Well well, this is a mysterious one. After some investigation, including being puzzled by this only occurring on fido, I decided to try reverting to the previous commits on fido in the evening, despite being skeptical that it would help. But it did help. But then it also worked fine when I restored the commits right back ... The only change I made in between was to do the routine weekly ubuntu system updates and reboot fido. These updates did include apache and java, hmm ...
Well, closing this, though it wouldn't hurt, @TomazErjavec, if you also check that it works for you now.

@TomazErjavec, if you also check that it works for you now.

Works fine now, thanks. A mystery why it came about...


Supports Sorting in API Requests

This pull request is for addressing this issue https://github.com/iPriceGroup/ocapiplugin/issues/6

@sandyandi I've changed the way to indicate sort order to inside the brackets to make it consistent with the feature in this PR https://github.com/iPriceGroup/ocapiplugin/pull/13
The format should be ?sort[]=position&sort[desc]=created_at

Tested in QA environment. The sorting is working as expected. QA passed


[NEW] Provides more color options

Hi @divyanshub024 ,
I have searched for a really good drawing library, to be used in note taking app project (Is a closed source project) - https://play.google.com/store/apps/details?id=com.yocto.wenote
One of the most requested features of the note taking app, is the capability to insert hand-drawn picture as attachments.
I have tested your library and I'm truly impressed with it. I decide to embed it into the note taking app.
May I request for more coloring option. One of my favorite note taking apps - Google Keep, is using the following approach to provide more coloring options.
Before expanding

After expanding, to provide more coloring options

Thank you very much. Please kindly let me know if there's anything I can contribute. Kotlin is a pretty new thing for me, but I'm quite comfortable in Android development using Java.

you can use color piker


Rotating Game Error, not working

[Rotating Game Error!]Could not find a part of the path "(unreachable)/Shavisi/data/playinglist.json".
Even though file exists.

Potential bug with mono version. See issue: #14


Uploading template to Weaver produces yml with uppercase first letter?

More than once I have the Weaver to create an interview package.
I did not notice at first, but I think that when I do this, the first letter of the yml the Weaver produces is uppercase.
I tried to figure out which field the Weaver uses when it creates the yml name and couldn't. This led me to wonder if we could also maybe show in the Weaver itself, or perhaps documentation for the Weaver, where Weaver puts the values for Weaver fields into the yml it creates.

This did change recently and unintentionally.


Getting "Mailbox name too short" on a 4-digit mailbox name

I've read through the source code and it looks to me like a 4-digit mailbox name should be considered valid. By default it looks like it's set to 1..64, however, I still get this error:
irb(main):098:0> EmailAddress.error<EMAIL_ADDRESS>=> "Mailbox name too short"

I'm using Rails 4.2.8 and email_address (0.1.10).

I am getting this on my emails also, since upgrading from 0.1.9
I suspect it's due to your (and my) nameservers resolving to Google, which is configured to default to a minimum of 5: https://github.com/afair/email_address/blob/master/lib/email_address/config.rb#L136

@tspacek good catch. Our emails are working fine however, even with shorter mailbox names. Just not passing validation with the gem. I'll try bumping back down to  0.1.9.

Thanks for finding this. Release v0.1.11 has this fix.


Multiple gpu training Sagemaker

Hi,
I try to scale the training job in Sagemaker and I found two process in gpu rank 0
!python train_net.py --config-file /home/ec2-user/SageMaker/SparseInst/configs/self_data.yaml --num-gpus 4
Below is the summary of nvidia-smi
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                                              Usage      |
|===============================================|
|    0   N/A  N/A     17861      C   ...3/envs/python3/bin/python    10725MiB |
|    0   N/A  N/A     36695      C   ...3/envs/python3/bin/python     4263MiB |
|    1   N/A  N/A     36696      C   ...3/envs/python3/bin/python     4679MiB |
|    2   N/A  N/A     36697      C   ...3/envs/python3/bin/python     4349MiB |
|    3   N/A  N/A     36698      C   ...3/envs/python3/bin/python     4635MiB |
+---------------------------------------------------------------+
Just want to know if you experience similar issue since I can only set IMS_PER_BATCH: 8 otherwise CUDA memory is received.
Thanks.

Hi @Tungway1990, thanks for your interest in SparseInst.
We will check this problem ASAP.

Seems this post  can solve the issue


How to get only console logs in output?

From @wpitallo on Thursday, May 30, 2019 8:44:22 PM
How to get only console logs in output?
Hi, currently I have set my logs to only log program output but I am still getting a lot of unwanted information. Is there a way to get just my logs and also none of the namespaces etc

Also is there an easy way like in Node.js to log in color without having to configure custom providers?
Copied from original issue: dotnet/core#2814

Hi @Pilchie, hope that you are well! Not sure if its possible but can't we get a unified logging experience across MST, products. Especially on Azure, I have been using Azure Cosmos DB and Azure functions and the logging experience is really really bad. On cosmos db in the data explorer does not even support multi-line logging which is mind boggling.

Hi, currently I have set my logs to only log program output but I am still getting a lot of unwanted information

This output is controlled by the "Debug Window Logger". You can disable it and replace it with your own (which can output the text in whatever format you'd like):
Host.CreateDefaultBuilder(args)
    /* other configuration ... */
    .ConfigureLogging(logging =>
    {
        // Removes ALL the default providers
        logging.ClearProviders();

        // Add back any providers you'd like, such as the standard console logger
        logging.AddConsole();

        // Add a custom provider, which is a class that implements ILoggerProvider
        logging.Services.AddSingleton<ILoggerProvider, MyCustomLoggingProvider>();
    });

Also is there an easy way like in Node.js to log in color without having to configure custom providers?

The default console provider does use colors for highlighting the log level, but there's no built-in way for you to include specific colors. On Linux/macOS (and recent Windows 10 versions) you could embed ANSI escape codes to set certain colors, but it would depend on your terminal supporting them.

can't we get a unified logging experience across MST, products

ILogger is fairly unified now, Azure Functions supports it natively. I can't speak to Azure Cosmos DB, that would be a good question for them. I'm not sure what logging needs they provide. If you're referring to logging from their client SDK, perhaps filing an issue on their repo would be a good way forward.

Closing inactive discussion thread.

Note: Inactive closed issues are locked after 30 days since we don't triage closed issues and new comments tend to be lost. Feel free to post a new issue if this issue is locked and you have further questions/discussions. See our issue management policies for more details.


Async matcher does not handle rejections

Rejections thrown by async matchers are not handled correctly. They end up as Uncaught (in Promise) type errors
To reproduce this:

go to https://zxcvbn-ts.github.io/zxcvbn/demo/
In the chrome developer toolbar, disable your internet connection
Type something in the password field
You'll notice the uncaught errors popping up in the developer toolbar

Not having a proper mechanism for error handling means that we cannot use things like the pnwd matcher in production

Not sure about @RossCurry (on holiday atm), but I'd expect the promise to be rejected. Are there any considerations for not propagating errors like that?

The problem is that if an error is thrown inside zxcvbn-ts it will not be further executed. Which means a user won't get a scoring for the password.
I would assume in most cases the Form has a validation for the password strength.
For example this would mean the user can not register anymore and will be pretty annoyed. An error like "Our password scoring is currently not working" is not something that the user will understand.

That's a fair point, and I agree it's a sensible default for most usecases. For other usecases it's a dangerous default though as we'd fail silently. If we'd apply zxcvbn on a server with incorrect network policies (e.g. whitelisting domains that the server is allowed to access, where the pwnd domain is not whitelisten), then a sysadmin would never detect this misconfiguration.
That being said, I'm not sure how to best cater to all usecases though. Possibly a configuration function handleNetworkError: (error:Err) => boolean | Error (where the default is false)?

I thought about a config parameter too but this is a bit tricky so first let's get rid of the major issue and than make it better 👍

@LaurensRietveld i published a new version for the pwned matcher

Thanks a lot!


bukut: fix incorrect sha256 hash

Motivation for this change
In the previous PR to add bukut, after switching to the tag, I forgot to update the sha256 hash.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@legendofmiracles

Result of nixpkgs-review pr 156093 run on x86_64-linux 1

1 package built:

bukut


TheOdinProject/css-exercises/foundations: add indent to the  and  tags within  for readability

[x] I have thoroughly read and understand the CSS Exercises Contributing Guide
[x] The title of this PR is in file/exercise/folder: brief description of changes format e.g. 01 flex center: add hint for XYZ

[ ] If one exists, I have linked a related open issue to this PR in Step 2 below
[ ] If changes were requested, I have made them and re-requested a review from the maintainer (top of the right sidebar)

1. Description of the Changes

Adjust the  and  indent inside the index.html files and solution.html files in the exercises.
2. Related Issue

Closes #XXXXX

Took a look at a couple of files you updated before realizing how many you updated! Thank you for fixing the indents on all of those, and for the first time contribution! It may take a bit to go through.
Also thank you for making me realize I should change the verbiage of the second checkbox 😆; the intention was file OR exercise OR folder rather than what you did here (don't worry, your title is fine, though!).

Hey, it was a lot of fun learning how to do that quickly. I'm happy to
contribute when I can, I've been doing TOP for 3 days, officially. I look
forward to the coming months!
Yeah, the Pull Request form is a bit confusing, at least for me who takes
clear instruction well haha.
I think it might be useful to indicate which parts of the template you wish
to remain, even if they're not applicable in the specific request. Like, do
I just leave the "Closes XXXXX"?
I learned a lot! Thanks for responding to the request!
Cheers,
ZebraMilk
On Sun, Jan 30, 2022, 21:03 Eric Olkowski @.***> wrote:

Took a look at a couple of files you updated before realizing how many you
updated! Thank you for fixing the indents on all of those, and for the
first time contribution! It may take a bit to go through.
Also thank you for making me realize I should change the verbiage of the
second checkbox 😆; the intention was file OR exercise OR folder rather
than what you did here (don't worry, your title is fine, though!).
—
Reply to this email directly, view it on GitHub
https://github.com/TheOdinProject/css-exercises/pull/125#issuecomment-1025332678,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUAKRMUPP6M43JVXRP4QN73UYX3XTANCNFSM5NERGUHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, @ZebraMilk , just wondering if there is an update on the above request?

Apologies! I just got the notification about this. I will look into it later tonight, it will be fun to learn how to resolve conflicts like this, seems like a common thing that would happen in a production environment. Cheers!

No worries, I can't reprimand you after how long it took me to get back to you 😆 These should be relatively simple merge conflcits to resolve, but if you have any questions/are unsure about anything, just let me know.

I have done most of the steps needed to fix this conflict, but I ran into some trouble. I posted about it in the #git-help channel on the discord, if you'd like I can re-post my question here.
Please advise :)

Not entirely sure whether following the instructions mentioned in this PR by GitHub (there should be a "command line instructions" button below the "This branch has conflicts..." message), but otherwise just making a completely new PR and doing the changes again may be easier.
In the future, though, in addition to being sure you don't delete your fork/branch, keep in mind that once you make a PR from a branch on your fork, any additional changes you make and push on that branch will reflect on the PR as well (this came up for another user so figured I would mention it in case).

I do not have any CLI instructions underneath the
## This branch has conflicts that must be resolved
Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.

I was able to use the gh pr checkout 125 from the <> code button at the top of the PR to get it onto my machine, but I can't push it anywhere because the fork/repo doesn't exist anymore. I do know now not to wantonly delete repositories haha. This has been a delightful hassle for something so non-critical, as you say, though I am wildly more comfortable working in git/github now than I was when I made this PR.
I think I will wait a day for GitHub to do their thing, and if no response, I will just make a new fork/new PR and we can let this one go.
Thank you for your patience! I promise future PRs from me will be smoother. Cheers!

Gotcha, it may be only available to maintainers then.
No worries, though. It's better to run into this sort of issue and gain that learning experience for an issue and repo like this! Just leave a comment in here once you get a response from GitHub and let us know what steps you'd like to take from there 🙂

GitHub was delightfully helpful. Done!


Update kube-linter-sample.yml to working version of upload-sarif@v3

Fixes error
This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

@thomast1906 Thanks!


Update FluentUI Blazor Components to 4.4

Resolves #2064
I did a pass through all the pages to make sure things rendered correctly and they did seem to. @jamesnk I couldn't repro the issue with the filter overflow on metrics to see if it was fixed - the box seems always wide enough to list all of them (though maybe I missed a metric somewhere with more filters).
Microsoft Reviewers: Open in CodeFlow

Obsolete by #2301


[error] [File Watcher (chokidar)] terminated unexpectedly and is restarted again...

Issue Type: Bug
Using VS Code with the WSL extension to connect to a Ubuntu 20.04 distribution.
Log (Remote Server) displays the following message approximately every 2-3 minutes.
[error] [File Watcher (chokidar)] terminated unexpectedly and is restarted again...
Additionally the .../out/bootstrap-fork --type=watchService process in WSL is running constantly at 100% CPU load.
The setting files.watcherExclude has been used to exclude all .git folders and other large folders of the project. However this did not help.
Retrying with VS Code Insiders with no extensions (besides WSL) did not help either.
 In that other bug I included some more info that seems to imply its not an inotify issue.

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

//cc @aeschli this seems WSL specific and is maybe addressed

@surban Can you check what the setting remote.WSL.fileWatcher.polling is configured to?
If it's true, can you disable is and see if that makes a difference?


Test for demonstrating: InstantClick always fetches page when hovering same link within the turbo-prefetch-cache-time window

Demonstrating https://github.com/hotwired/turbo/issues/1176 with a test case.
I've noticed that the current InstantClick behavior is to fetch the page on each link hover (even when hovering multiple times within the 10 seconds cache window).
I thought on link hover InstantClick would fetch the page from the server store it to cache for 10 seconds.
Here is a test case showing the issue.
I'll try to come up with a code change that would make it pass.

Thanks @afcapel for taking the time to explain the reason behind this behavior.
What if :

On link hover page is cached with ttl = turbo-prefetch-cache-time
On any non GET request clear the prefetch cache.

I'm closing this as I don't see a path forward.

Thanks for explaining! This was really helpful to understand the reasoning behind it. It would be amazing to have some examples on how we can change this behavior: I agree to have a "safe default", but for some links I'd be totally fine in caching the page for 2 or 3 seconds. How could I achieve that?
Also, what about expiring if the mouse clicks somewhere else? 😄

This is preventing me from using this feature, it causes too many requests.
What's the point of turbo-prefetch-cache-time if it's only the time the user has not left the link element?
Also it'd be great to be able to set turbo-prefetch-cache-time on the link element (or ideally a parent element)


Question about toDo

Reviewing the public static void toDo(@Scope int scope, String tag) function specification it says "if it has already marked to do or been done within that scope then it will not be marked." but the actual implementation does not involve the THIS_APP_SESSION scope. I'm wondering why the implementation does not check if the tag was done within that scope? Maybe we should have a session start timestamp in order to do that... what do you think?

Well spotted, looks like a bug.
That should probably check the sessionList if the THIS_APP_SESSION scope is provided and only add the tag if it doesn't exist in the list.
longer term, I'd like to change how the sessionList works and shift to how you described, so you have a session timestamp and it mirrors how the version scope check works.
Other work here is that toDo doesn't work with timestamps yet, which would make it nice and symmetric with beenDone

@dernster I've just checked the code, we have a test around this. It's not obvious from the code (because as you've seen the implementation doesn't explicitly check THIS_APP_SESSION), but actually because we only mark a tag as todo if its either it's never been done before, or if the scope is VERSION and we last saw the tag before the last update.
As I said this could use a refactor :) but it should be functional (check here: https://github.com/jonfinerty/Once/blob/master/once/src/test/java/jonathanfinerty/once/ToDoTests.java#L59 for validation)

@dernster I'll going to close this, if that's ok? I'll do the refactoring at some point, but outside of this issue as it's more an enhancement.

@jonfinerty You are right! Thanks for clarifying that :)
It's ok to close this.
I was reviewing your code since I was thinking about implementing this library for Swift. Our Android team use this Once component a lot and for iOS there was nothing like this.
Finally did it! You can check out Ecno (Once in reverse :)). In the README file we have a reference to your library so I hope it's all fine.
Thanks!

Amazing, thanks for the link, it's really cool someone is building upon something I built.


Pass in payload for start handler

Is it possible to pass in a payload to be used in the start handler? My use case is I have a function that does a fetch for a specific item in a list, and I want it to display that particular item as loading in the list, so start needs to know which item was passed in. I can achieve this by creating a synchronous action and dispatch it alongside the async one, but this seems to add some bloat to the set of actions; is there a better way? Thanks!

Oh oops, I read the source and docs more carefully and I think I understand it. Not an issue!
(for those who didn't get it, you can add a payload member to the action alongside promise (and meta) and it will get passed onto the onStart handler).


Try aquaplanet DYAMOND simulation on GPU

Purpose
Try aquaplanet DYAMOND simulation on GPU

[x] I have read and checked the items on the review checklist.

bors r+


Google One VPN can't connect, while IPFS is running (Windows)

System Details

OS: Windows 11 Home, Version: 22H2
Version of IPFS Desktop: v0.30.2

Describe the bug
If the IPFS daemon is stopped, Google One VPN is working fine, but as soon as I start IPFS via the context menu, Google One VPN will disconnect.
I've tried to:

Disable MDNS discovery
Change the swarm ports
Change the Gateway port
Change the API port

To Reproduce
Steps to reproduce the behavior:

Start Google One VPN
Start IPFS Desktop
Get an error message, that the VPN has disconnected after 5-10 seconds
Stop IPFS Desktop
Reestablish Google One VPN
See it working again
Start IPFS Desktop
Get an error message, that the VPN has disconnected after 5-10 seconds

Expected behavior
I don't think the two programs should interfere with each other.
Screenshots

"Connection not possible. Restart VPN to reestablish connection" is the rought translation of the error message.

@RubenKelevra thanks for this report.
I don't have Google One so I can't run the VPN (correct me if i'm missing something).
However, I doubt this is something specific to IPFS-Desktop, and more related to Kubo. Could you confirm by running Kubo more directly (outside of IPFS-Desktop) with something like npx kubo@latest daemon ?

Yeah you need to subscribe to Google Drive for 2 TB, which unlocks Google's VPN.
Will do asap I'm home.


Allow Remote Database Configuration

Allow option to connect to a remote database.
This might require an additional environment variables to be passed into containers.

We'll need some extra config options:

Host
Username
Password

We will eventually want an option to run a production environment, that doesn't spin up a docker db.
I'm envisioning something like
make prod
Which might read a docker-compose.prod.yml file, which omits the db container


Add mempool infra crate

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.78%. Comparing base (630d83e) to head (e13755b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   36.78%   36.78%
=======================================
  Files          12       12
  Lines         386      386
  Branches      386      386
=======================================
  Hits          142      142
  Misses        242      242
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use with tailwindcss

I use tailwindcss and I need to specify h1, ol, ul styles, I do it like this in my component:
<style>
.editor h1 {
  @apply text-3xl;
}
</style>

It works:

But when I press print, the styles are not applied. How can this be fixed?

Thanks

Hello!
When printing, all of the <body> content is replaced temporarily by the document itself, with a different stylesheet adapted for printing.
So I would guess that maybe part of your CSS has been located in the <body> section and is not kept during the print operation.
Otherwise it could be a style overload but it is less probable.
If this doesn't help, can you provide me a link to your work so I could check what is going wrong?

Well actually I just checked the before_print method and it doesn't take the class nor style into account...
I have to patch it for your use case to work. I can look at it probably tomorrow.
https://github.com/motla/vue-document-editor/blob/80451dcf88eb173e3ca0c84161bc055eb29b277d/src/DocumentEditor/DocumentEditor.vue#L423-L477

Hi!
It should be fixed in v1.2.8 (Vue2) and v2.0.6 (Vue3).
Please let me know if you still have issues.


Fix documentation of popup_centered_ratio

resolve #70451 by changing the documentation to describe the implementation.
Changing the implementation could be considered a breaking change, so adjusting the documentation seems more reasonable at this stage.

Thanks!


Select all and delete Server Selected don't work

From Webmin -> Webmin Servers Index, when i click to select all and click to delete selected, they don't work. Say me this error message:

Failed to delete servers : None selected

And if i want to select one to one, it's not possible, because they open a blank page.

To select one, you can click right mouse button. I will test Select All deletion and let you know. As workaround you could open module's settings and change the view. It should work as expected.
Get back to your issue a bit later.
Thanks for reporting.

What version of the theme are you using? Also what is your browser and OS?

OS: CentOS Linux 6.7
Theme: Authentic 16.01
Right click good :+1:

Alright, I see. I already debugged it. I couldn't reproduce it in version 17.02.
Example:
https://rostovtsev.ru/pub/src/authentic/17.xx/issue-278/Screencast_from_11-06-2015_11:08:32_AM.webm
Turn on theme automatic updates notification in theme's settings.
Update to the latest version. Feed this link to Webmin->Webmin Configuration->Themes->Install Theme: https://raw.githubusercontent.com/qooob/authentic-theme/master/.build/authentic-theme-latest.wbt.gz


Nuitka Module Importing External Numba .so file

Nuitka Version 2.4.5, Python version 3.12.0
I am stuck on a question of having a Nuitka .so module import code outside of the module package that is compiled, specifically I want the compiled code inside a nuitka-ized module to reference code in a numba AOT-ized module.
Thanks for the help in advance. I am trying to work around using both numba and nuitka for my project. See the project structure below:
└── 📁nuitka_testing

    └── run_func.py

    └── 📁.venv

    └── 📁src

        └── 📁nuitka_funcs
            └── __init__.py
            └── test_nuitka_imports.py

        └── numba_modules.cpython-312-x86_64-linux-gnu.so
        └── __init__.py

I have used numba's AOT capabilities to create numba_modules.cpython-312-x86_64-linux-gnu.so which houses all my numba code, which I then import in nuitka_funcs/test_nuitka_imports.py, the content of which is below:
## test_nuitka_imports.py ##

from ..numba_modules import identity

def run(x):
    y = identity(x)
    return y

I can run my main function run_func.py (simply from src import run; run(5) ) when the nuitka_funcs folder is not compiled, but when i try to compile the nuitka_funcs folder into a .so using  python -m nuitka --module nuitka_funcs --include-package=nuitka_funcs I get an assertion error AssertionError: <ModuleName ''>, crash report is attached:
nuitka-crash-report.txt
I gather it is because the code being compiled in the nuitka_funcs folder is importing code outside itself? If anyone could please help out on the right direction it'd be most appreciated. I just want to be able to reference outside, non-compiled code from inside a nuitka-ized .so module file, or any work-around for this use case. I have looked through other issues and they are either too vague to help me or don't seem to help me.
Thank you!

The example looks good to me, I will be trying to add Numba JIT support in the coming releases, so this will be useful as a starting point at least, before we see what larger packages also do.


TrackGraph.add_node / add_edge different to TrackGraph(networkx_graph)

prev_edges and next_edges are not set in add_edge. add_node seems to do the same as when constructing from a networkx graph, except that hyperedge nodes are not supported. This might be okay (hyperedges can be added using add_edge), but then it would make sense to check for the frame attribute in add_node.

Also, _graph_changed is not set when calling add_node/add_edge.


First build in watch mode is very slow

If i launch jumpsuit watch for the first time in a project it has to build a lot of things, then every time a file changes it rebuilds in less time.
If I close the development server and open it again on the same project it still takes a lot of time, It could use some caching so the time to build is more like in succesive builds.
% jumpsuit watch
     _                       _ _
    |_|_ _ _____ ___ ___ _ _|_| |_
    | | | |     | . |_ -| | | |  _|
   _| |___|_|_|_|  _|___|___|_|_|
  |___|         |_|

▸   running at http://localhost:8000
▸   building... ✓ (7259ms)
▸   building... ✓ (1416ms)
▸   building... ✓ (1425ms)
▸   building... ✓ (1014ms)
▸   building... ✓ (967ms)

This would be great, but I'm not sure if that's possible with browserify or webpack. Thoughts @jsonmaurer?

I can get this fixed later today probably
On Thu, Nov 10, 2016 at 8:34 AM Hugo Chinchilla Carbonell <
<EMAIL_ADDRESS>wrote:

I'ts pretty anoying because of #51
https://github.com/jumpsuit/jumpsuit/issues/51 I have to restart it a
lot, maybe fixing #51 https://github.com/jumpsuit/jumpsuit/issues/51
would make this less of a problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jumpsuit/jumpsuit/issues/50#issuecomment-259721272,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCQZUSQ0Q5zAzBSixvYGhFUK2A4i4ks5q8zmhgaJpZM4KuyjO
.

@hugochinchilla, #51 is fixed now.  Hopefully that eases the pain of the first build.  npm install jumpsuit-cli -g to try it out

Aside from buying a computer with a faster CPU, I'm not sure how this could be fixed. I'm not aware of any way to reuse old builds to make startup time faster; seems like a bad idea anyway, as it could cause a lot of issues with stale code, etc. Which is why we delete the entire dist folder and rebuild stuff on startup--to ensure we're starting from a clean slate. We do cache after the initial build though, which helps a ton when developing.

Also, I'm assuming you have no third-party dependencies and are using a fresh install of Jumpsuit? Adding new libraries (especially hefty ones like D3) will have a big impact on the build times.

@tannerlinsley works great, #50 is less of a  problem now, I will only start the server once a day now :)

@jsonmaur I'm only using a fresh install of jumpsuit with no additions so far


Upgrade Kitematic (Beta).app to v0.9.6

Thank you for the contribution. It was merged directly as 6f88c076d2c49495b5c3b431092d0662ff6c890c to keep commit history cleaner. Your contribution is still credited to you.


React 19 support

Hi, it would be awesome to add react 19 support since it's stable and launched now. I am using Mantine and this is one of the deps that it's raising a warning because of peerDeps

Yeah, I almost tried to make a PR to update the peer deps because there haven't been updated in forever until I realized, same author... So I've seen that this package support react 19, but the two peer deps do not yet...
"use-composed-ref": "^1.3.0",
"use-latest": "^1.2.1"

Thanks!

All of those should be resolved now.

All of those should be resolved now.

I don't see a release of this package using the newer version of the dependencies.

Isnt this available on npm? https://github.com/Andarist/react-textarea-autosize/pull/405

I'm not a npm expert, and I haven't tested my assumption here (I can't atm)...
I don't think it's going to update the peer deps in a project using this package unless you set the minimum versions of the peer deps in this project to the new versions that were just released for the two peer dependencies.


Reorder Nginx handlers to apply SELinux contexts before start

Back in April, the PR #567 was opened to allow the playbook to run successfully even if SELinux was enabled, to configuring the /var/log/alfresco folder to properly contains logs for HTTPD/Nginx. Following this PR merge, another PR #573 was created to move the execution of the restorecon command from roles/nginx/tasks/main.yml to roles/nginx/handlers/main.yml.
This second PR breaks the initial one that I opened. The handlers aren't executed right whey they are notified but they are executed at the end of the play (before the post_tasks). And from what I saw, it seems that the order of the handlers in the file roles/nginx/handlers/main.yml matters, since all handlers that were notified will be executed from top to bottom, no matter if they were notified first or not... Therefore, since the Restart-nginx handler is before the Apply new SELinux file contexts one in the handler file, then Nginx fails to startup and it doesn't work. My initial PR worked because the reload of the context was before the handlers execution.
Friday 30 June 2023  09:36:51 +0000 (0:00:03.156)       0:00:56.067 ***********
 [started TASK: ../roles/nginx : Set httpd_can_network_connect flag on and keep it persistent across reboots on aws/mop-alf-ce-nginx]

TASK [../roles/nginx : Set httpd_can_network_connect flag on and keep it persistent across reboots] **************************************************************************************************************************
changed: [aws/mop-alf-ce-nginx]
Friday 30 June 2023  09:37:00 +0000 (0:00:08.856)       0:01:04.923 ***********
 [started TASK: ../roles/nginx : Allow nginx to write logs under /var/log/alfresco on aws/mop-alf-ce-nginx]

TASK [../roles/nginx : Allow nginx to write logs under /var/log/alfresco] ****************************************************************************************************************************************************
changed: [aws/mop-alf-ce-nginx]
Friday 30 June 2023  09:37:06 +0000 (0:00:06.419)       0:01:11.343 ***********
 [started TASK: ../roles/nginx : Vhosts configuration on aws/mop-alf-ce-nginx]

TASK [../roles/nginx : Vhosts configuration] *********************************************************************************************************************************************************************************
included: /workspace/yak/component_types/alfresco_ecm/roles/nginx/tasks/vhosts.yml for aws/mop-alf-ce-nginx
...
...
TASK [../roles/nginx : Remove legacy vhosts.conf file.] **********************************************************************************************************************************************************************
ok: [aws/mop-alf-ce-nginx]
Friday 30 June 2023  09:37:19 +0000 (0:00:01.584)       0:01:23.451 ***********
 [started HANDLER: ../roles/nginx : enable-nginx on aws/mop-alf-ce-nginx]

RUNNING HANDLER [../roles/nginx : enable-nginx] ******************************************************************************************************************************************************************************
changed: [aws/mop-alf-ce-nginx]
Friday 30 June 2023  09:37:21 +0000 (0:00:02.387)       0:01:25.838 ***********
 [started HANDLER: ../roles/nginx : restart-nginx on aws/mop-alf-ce-nginx]

RUNNING HANDLER [../roles/nginx : restart-nginx] *****************************************************************************************************************************************************************************
fatal: [aws/mop-alf-ce-nginx]: FAILED! => {"changed": false, "msg": "Unable to start service nginx: Job for nginx.service failed because the control process exited with error code.\nSee \"systemctl status nginx.service\" and \"journalctl -xe\" for details.\n"}

The systemctl status nginx.service command shows that the write access is denied in the log folder:
Jun 30 09:24:36 mop-alf-ce-nginx nginx[26097]: nginx: [emerg] open() "/var/log/alfresco/nginx.alfresco.access.log" failed (13: Permission denied)

And to confirm the status of the /var/log/alfresco folder, it is still with unlabeled_t:
[root@mop-alf-ce-nginx ~]# ls -ldZ /var/log/alfresco
drwxr-x---. 2 alfresco alfresco system_u:object_r:unlabeled_t:s0 6 Jun 30 11:34 /var/log/alfresco
[root@mop-alf-ce-nginx ~]#

If we change the order of the handlers, then it is set properly as 1st handler and the permissions are correct with httpd_log_t before Nginx starts:
[root@mop-alf-ce-nginx ~]# ls -ldZ /var/log/alfresco/
drwxr-x---. 2 alfresco alfresco system_u:object_r:httpd_log_t:s0 6 Jun 30 12:03 /var/log/alfresco/
[root@mop-alf-ce-nginx ~]#

sorry, we completely missed this PR, seems fine to merge


build: bump indirect dependencies

Codecov Report

Merging #66 (e32d776) into main (a1eb424) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   81.13%   81.13%
=======================================
  Files           6        6
  Lines         371      371
=======================================
  Hits          301      301
  Misses         48       48
  Partials       22       22


Fix save method setting wrong id on model

Fixes #221
This PR changes how the ModelToQueryMapper sets the "where id" so that the id key can be kept in the $fields variable (->bindings) and thus mapping out correctly to the model.
I think this solution works (tests say so at least) but please let me know if I have missed something :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 76.496%

Files with Coverage Reduction
New Missed Lines
%

src/Tempest/Http/Mappers/RequestToPsrRequestMapper.php
1
88.89%

src/Tempest/Database/IsModel.php
1
98.51%

src/Tempest/Console/Highlight/TempestTerminalTheme.php
1
96.77%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
2493

Relevant Lines:
3259

💛  - Coveralls

Thanks!


[Bug] adapter.get_relations not working as expected

Is this a new bug in dbt-redshift?

[X] I believe this is a new bug in dbt-redshift
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
As seen in this dbt_ad_reporting issue discussion it seems that the adapter.get_relations component is not working as expected when trying to reference a relation in a database that is separate from the target database where the models are being written.
I would expect that running the below code would result in the properly formatted relation.value. However, we always end up seeing None as the value. I was able to recreate this error on my end and the OP of the Ad Reporting issue also was able to share the below code resulted in an unexpected empty relation.
{% set relation = namespace(value="") %}
{%- set relation.value=adapter.get_relation(
    database=source('fivetran_reddit_ads', 'campaign_report').database,
    schema=source('fivetran_reddit_ads', 'campaign_report').schema,
    identifier='campaign_report'
) -%}

with source as (

    select * from {{ relation.value }}

),

renamed as (

    select * from source

)

select * from renamed

Please note the adapter.get_relation is not being used directly in this capacity, but I have simplified it here to narrow in the issue. You can see the true origin of this code is found here and leveraged across a number of the Fivetran dbt packages.
Expected Behavior
I would expect the above query to return the proper database.schema.table relation result from the adapter.get_relation query.
Steps To Reproduce

Configure the above mentioned query to reference a valid source that is in a different Redshift database on the same cluster.
Run the model
See some sort of error indicating that the query was not successful
See in the compiled code that the relation.value compiled to None

Relevant log output
relation "none" does not exist

Environment
- OS: Mac OS
- Python: Python 3.10.11
- dbt-core: 1.8.1
- dbt-redshift: 1.8.0

The above are my specific to my environment. The OP may differ.

Additional Context
No response

@fivetran-joemarkiewicz has this worked in the past? This sounds like the feature request for dbt-redshift to support cross-db querying which we don't support today well.

@amychen1776 thanks for the response! In all the Fivetran dbt packages we offer the flexibility to define the schema and database via variables which doesn't have any restriction on cross-db querying. I've experienced the cross-db functionality working as expected in other adapters (such as BigQuery and Snowflake), but I don't know if we've ever encountered someone attempting this in Redshift until now. I can't be sure if this has worked in the past since we didn't attempt this ourselves, and this is the first time we've seen a bug report regarding this limitation.
You mention this cross-db isn't supported in Redshift today, I wasn't fully aware of this and I noticed there is an open Issue #742 which mentions the following is not supported (which is the scenario resulting in the creation of this ticket).

a source table is defined in a database different than what's given in profile

Given this and as you mentioned, it seems like this is not a supported feature of dbt-redshift and this should fold into the existing feature request. If that's the case, I can inform the OP within the Ad Reporting Issue and be sure to call this out in our documentation for anyone attempting to cross-database query when using Redshift and a Fivetran dbt package.

Yes - it does work seamlessly on the other adapters but for Redshift, unfortunately we need to update how we manage the metadata which is a bigger project. Happy to mention this in the other feature request (unfortunately I don't have a timeline to share for this feature just yet). I think it's the right call to update your documentation on this. For now, I'll close this issue up.


zoombot: add support doc

can you leave a comment as to where this is going to be hosted? keybase.pub?


Please release a requirements.txt for dependencies

Hi! I wanted to reproduce the result on SentEval, but failed because of the following error:
Traceback (most recent call last):
  File "scripts/run_senteval.py", line 732, in <module>
    app()
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "scripts/run_senteval.py", line 714, in allennlp
    overrides="{'trainer.use_amp': true}",
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/archival.py", line 191, in load_archive
    cuda_device=cuda_device,
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/model.py", line 354, in load
    config["model"] if isinstance(config["model"], str) else config["model"]["type"]
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/common/params.py", line 436, in __getitem__
    raise KeyError
KeyError

I think is the caused by the incompatible version of packages? I noticed the allennlp1.1.0 is released in September but your paper is released in June.
So could you release a requirements.txt, please?
Thanks!

Hi @leerumor,
Which version of AllenNLP are you using? I can't really tell what is happening from the error, but it looks like it may be because you are using a version of AllenNLP before they introduced the use_amp param.
We have a setup.py that serves the same purpose as a requirement.txt. Did you install following the instructions here?

Hi @leerumor,
Which version of AllenNLP are you using? I can't really tell what is happening from the error, but it looks like it may be because you are using a version of AllenNLP before they introduced the use_amp param.
We have a setup.py that serves the same purpose as a requirement.txt. Did you install following the instructions here?

Thanks for your reply.
I did following the instructions, here are the versions:
allennlp                  1.1.0                    pypi_0    pypi
allennlp-models           1.1.0                    pypi_0    pypi
pytorch-metric-learning   0.9.96                   pypi_0    pypi
typer                     0.3.2                    pypi_0    pypi
validators                0.18.2                   pypi_0    pypi
torch                     1.6.0                    pypi_0    pypi

I downloaded SentEval toolkit and moved declutr-base to output folder. Then run command:
python scripts/run_senteval.py allennlp "SentEval" "output" \
 --output-filepath "output/senteval_results.json" \
 --cuda-device 0 \
 --include-package "declutr"

Thanks for your reply.
I did following the instructions, here are the versions:
allennlp                  1.1.0                    pypi_0    pypi
allennlp-models           1.1.0                    pypi_0    pypi
pytorch-metric-learning   0.9.96                   pypi_0    pypi
typer                     0.3.2                    pypi_0    pypi
validators                0.18.2                   pypi_0    pypi
torch                     1.6.0                    pypi_0    pypi

I downloaded SentEval toolkit and moved declutr-base to output folder. Then run command:
python scripts/run_senteval.py allennlp "SentEval" "output" \
 --output-filepath "output/senteval_results.json" \
 --cuda-device 0 \
 --include-package "declutr"

The error was because there is no "model" key in config dict:
Params({'trainer': {'use_amp': True}, 'hidden_dropout_prob': 0.1, 'vocab_size': 50265, 'type_vocab_size': 1, 'hidden_act': 'gelu', 'gradient_checkpointing': False, 'attention_probs_dropout_prob': 0.1, 'layer_norm_eps': 1e-05, 'initializer_range': 0.02, 'bos_token_id': 0, 'eos_token_id': 2, 'output_hidden_states': True, 'max_position_embeddings': 514, 'model_type': 'roberta', 'intermediate_size': 3072, 'hidden_size': 768, 'architectures': ['RobertaForMaskedLM'], 'num_attention_heads': 12, 'num_hidden_layers': 12, 'pad_token_id': 1})

but when I added config["model"]="declutr", another error occured:
Traceback (most recent call last):
  File "scripts/run_senteval.py", line 732, in <module>
    app()
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "scripts/run_senteval.py", line 714, in allennlp
    overrides="{'trainer.use_amp': true}",
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/archival.py", line 191, in load_archive
    cuda_device=cuda_device,
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/model.py", line 369, in load
    return model_class._load(config, serialization_dir, weights_file, cuda_device)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/model.py", line 285, in _load
    vocab_dir, vocab_params.get("padding_token"), vocab_params.get("oov_token")
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/data/vocabulary.py", line 328, in from_files
    base_directory = cached_path(directory, extract_archive=True)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/common/file_utils.py", line 175, in cached_path
    raise FileNotFoundError(f"file {url_or_filename} not found")
FileNotFoundError: file output/vocabulary not found

The error was because there is no "model" key in config dict:
Params({'trainer': {'use_amp': True}, 'hidden_dropout_prob': 0.1, 'vocab_size': 50265, 'type_vocab_size': 1, 'hidden_act': 'gelu', 'gradient_checkpointing': False, 'attention_probs_dropout_prob': 0.1, 'layer_norm_eps': 1e-05, 'initializer_range': 0.02, 'bos_token_id': 0, 'eos_token_id': 2, 'output_hidden_states': True, 'max_position_embeddings': 514, 'model_type': 'roberta', 'intermediate_size': 3072, 'hidden_size': 768, 'architectures': ['RobertaForMaskedLM'], 'num_attention_heads': 12, 'num_hidden_layers': 12, 'pad_token_id': 1})

but when I added config["model"]="declutr", another error occured:
Traceback (most recent call last):
  File "scripts/run_senteval.py", line 732, in <module>
    app()
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/typer/main.py", line 214, in __call__
    return get_command(self)(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/typer/main.py", line 497, in wrapper
    return callback(**use_params)  # type: ignore
  File "scripts/run_senteval.py", line 714, in allennlp
    overrides="{'trainer.use_amp': true}",
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/archival.py", line 191, in load_archive
    cuda_device=cuda_device,
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/model.py", line 369, in load
    return model_class._load(config, serialization_dir, weights_file, cuda_device)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/models/model.py", line 285, in _load
    vocab_dir, vocab_params.get("padding_token"), vocab_params.get("oov_token")
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/data/vocabulary.py", line 328, in from_files
    base_directory = cached_path(directory, extract_archive=True)
  File "/home/hadoop-aipnlp/anaconda3/lib/python3.7/site-packages/allennlp/common/file_utils.py", line 175, in cached_path
    raise FileNotFoundError(f"file {url_or_filename} not found")
FileNotFoundError: file output/vocabulary not found

Great, thanks for the extra info.
Will you call ls on whether the "output" folder is on your system and let me know the output? If you downloaded declutr-base from [here[(https://github.com/JohnGiorgi/DeCLUTR/releases), it should contain everything you need.
In the meantime, I will work on adding a notebook to the repo that evaluates the pre-trained models on SentEval.

Great, thanks for the extra info.
Will you call ls on whether the "output" folder is on your system and let me know the output? If you downloaded declutr-base from [here[(https://github.com/JohnGiorgi/DeCLUTR/releases), it should contain everything you need.
In the meantime, I will work on adding a notebook to the repo that evaluates the pre-trained models on SentEval.

Closing this because the notebook should provide enough information to evaluate any of the pre-trained models (or your own models) against SentEval. Please re-open if you are still having difficulties!


Difference between this and cssify?

Hey @cheton,
Can you explain any differences/benefits between your package and https://github.com/davidguttman/cssify ? Just curious, thanks!
(Firstly, it seems like cssify doesn't include the clean-css transforms. Anything else?)

In addition to using clean-css for minifying CSS files, it can concatenate, inline, and rebase urls in CSS files using @import statements. For example:
index.css
@import url("node_modules/bootstrap/dist/bootstrap.css");
@import url("components/foo/index.css");
body {
    background-color: #fff;
}

index.js
require('./index.css');

The above code will produce only one <style /> tag within HTML.
The browserify-css transform also provides the processRelativeUrl option that allows you to copy font and image files within node_modules. Here is the Bootstrap example:
node_modules/
    bootstrap/
        dist/
            css/
                bootstrap.css
            fonts/
                glyphicons-halflings-regular.eot
                glyphicons-halflings-regular.svg
                glyphicons-halflings-regular.ttf
                glyphicons-halflings-regular.woff
                glyphicons-halflings-regular.woff2

You cam check out my sample code here.


Aggregate lighthouse stats per audit to support multiple urls

Previously we were creating one aggregator per config, so configurations which had more than one url in them would mix the results of each url together and produce incorrect summaries for each.  (See: https://github.com/sitespeedio/plugin-lighthouse/issues/54)

Haha that was fast :)

Thank you @andrewmee for the PR !


How can I use it with lazy module?

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [X ] feature request

OS and Version?

Versions

Desired functionality

Mention any other details that might be useful

Hi,
I just wanted to know how to install the module for lazy modules. It seems to work otherwise but when I use it in Lazy Modules, the dom elements I try to animate remain hidden with opacity 0. I can't see any error in the console.
I tried to add .forRoot() to the import but I got the error saying that this property does not exist.
I hope you can help.
Thanks
Christele

I managed to fix my problem.

Hi,
I'm glad you fix your problem, sorry I didn't have time to help...
Can you elaborate how you did? (for future readers)


Area Light Specular not working with material properties

The rectangular area light does not seem to correctly work with the specular component, nor does it respond to the standard material properties. I think this is a regression but can't verify for certain
Steps to reproduce
Example
Project
Ground material with 'Use Metalness' off
Note how changing the ground plane materials Glossiness property has no effect on the light. Also note how the shape of the specular component is not correct. It should be a blurred reflection of the square plane

Ground material with 'Use Metalness' on with 'Metalness' set to 1
Note how the diffuse component responds to the Metalness property of the material, but againthe Glossiness component has now effect

What's expected
Material should correctly respond to Glossiness/roughness property and reflect the specular component properly.
I think this was working in the original PR, but I haven't been able to check this. It looks like the dGlossiness is incorrect somehow. There is also some redudant code in the shader relating to the area lights that can be removed, and this method seems to be called per area light, which I think only needs to be called once for the entire material

Actually @mvaligursky  @raytranuk this is because I've not updated with the new binary LUT's 🤦. Let me double check this first and I'll close this if it's no longer valid

Yes, exactly as I thought. I was missing the binary luts 🤦

@marklundin - great! And what about this .. do you think it's still valid and should be investigated?
There is also some redudant code in the shader relating to the area lights that can be removed, and this method seems to be called per area light, which I think only needs to be called once for the entire material

Yes actually these are still valid. Should I open a separate issue?
On Fri, 12 Mar 2021 at 11:23, Martin Valigursky @.***>
wrote:

@marklundin https://github.com/marklundin - great! And what about this
.. do you think it's still valid and should be investigated?
There is also some redudant code in the shader relating to the area
lights that can be removed, and this method seems to be called per area
light, which I think only needs to be called once for the entire material
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/playcanvas/engine/issues/2957#issuecomment-797428679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADJFLF6IDIM4N4BSCS77ATTDH2SVANCNFSM4ZAH6TTQ
.

--
Mark Lundin - Creative Director
*Kuva | *An Experience Design Studio
4 Colston Yard, Bristol
@wearekuva https://twitter.com/wearekuva kuva.io https://www.kuva.io/

I'll reopen this one. Feel free to modify description, otherwise I'm sure we'll figure it out. Cheers!


[cart] Custom line item quantity is missing error is thrown when no quantity is provided

Describe the bug
When there is no quantity provided for custom line item in a cart, a NPE is thrown. However according to the docs for CustomLineItemDraft, it should default to 1 when nothing is provided: https://docs.commercetools.com/api/projects/carts#customlineitem
Place where it happens:
https://github.com/commercetools/commercetools-sdk-java-v2/blob/12a33604df6d30d766a746ebb67990fdcfc5f2a9/commercetools/commercetools-sdk-java-importapi/src/main/java-generated/com/commercetools/importapi/models/orders/CustomLineItemDraftBuilder.java#L429

Fixed in 13.0.0