Build reports invalid certificate

After version 7.1.0 my macOS developer certificate seems to be invalid for anyone who downloads my software, my certificate is definitely valid though.
I set the osx-sign member to true (as described in the API documentation) and a dmg+app is produced. But anyone who downloads it they get the security warning.
I'm on electron 1.3.3, 15.6.0 Darwin Kernel Version 15.6.0:RELEASE_X86_64 x86_64

Thanks for filing an issue! In order to help you with your problem, we're going to need more information about it. In particular:

Console output when you run electron-packager with the environment variable DEBUG=electron-packager.
Please verify that it works with version 7.0.4. This problem sounds odd to me, mostly because there wasn't a change in the signing code around 7.1.0.

+1

@ErikBoesen I appreciate the +1, but using the GitHub reactions feature is preferred to more GitHub notifications than is necessary.

Whoops. Sorry.

Another question: a DMG is produced? I assume that's not related to this (considering that electron-packager does not generate DMG files).

I accidentally wiped out the issue template but when i refreshed it wouldn't come back. Anyway, 7.0.4 also works just fine. A working DMG is produced by both 7.0.4 and 7.1.0. The DMG produced by anything above 7.1.0 says the following...
“voltra.app” can’t be opened because the identity of the developer cannot be confirmed.
Your security preferences allow installation of only apps from the Mac App Store and identified developers.

You've probably already noticed this, but you seem to have a failing build. I updated all my plugins which is what caused the crash.

@ErikBoesen I'm not sure what you're referring to.

@malept ah! haha yeah, sorry, im using another module to produce the DMG. I guess that's not an important detail at all :)

Sorry, should have specified. In your readme, Travis CI is reporting a failing build.

@0x00A I take it the latest version of electron-packager doesn't work for you either?

@ErikBoesen the failing build is unrelated to this issue and is being investigated in #468.

@malept yeah, basically it appears to create the right output, it runs on my local computer just fine. The only thing wrong is just the certificate reporting as invalid on other people's computers.

Understood.

@0x00A Could you please run
CC: @sethlu

Aside from apple spelling my name wrong, it seems to find my certificate...
[OK] compressed Javascript
[OK] removed temporary files
[OK] pruned node modules directory
Making OSX App...
Packaging app for platform darwin x64 using electron v1.3.3
App created OK
Signing App...
  electron-osx-sign Signing application... +0ms
  electron-osx-sign > application         /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app +1ms
  electron-osx-sign > platform            darwin +1ms
  electron-osx-sign > entitlements        undefined +0ms
  electron-osx-sign > child-entitlements  undefined +0ms
  electron-osx-sign > additional-binaries undefined +0ms
  electron-osx-sign > identity            Developer ID Application: Paulo Fragomeni (3CPSKTF8W5) +0ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework +156ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib +2s
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib +890ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/crashpad_handler +688ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework +487ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle +2s
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Mantle.framework +503ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa +485ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/ReactiveCocoa.framework +602ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework/Versions/A/Resources/ShipIt +619ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel +523ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework +707ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper EH.app/Contents/MacOS/voltra Helper EH +595ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper EH.app +518ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper NP.app/Contents/MacOS/voltra Helper NP +531ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper NP.app +496ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper.app/Contents/MacOS/voltra Helper +552ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper.app +470ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/MacOS/voltra +579ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Resources/app/node_modules/leveldown/build/Release/leveldown.node +1s
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Resources/app/node_modules/taglib2/build/Release/taglib2.node +538ms
  electron-osx-sign Signing... /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app +506ms
  electron-osx-sign Verifying code sign... +1s
  electron-osx-sign Verification displayed below:
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper NP.app
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper NP.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper EH.app
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper EH.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper.app
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app: valid on disk
/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app: satisfies its Designated Requirement
 +887ms
  electron-osx-sign Application signed. +1ms
App Signed OK
Creating Image...
1/20 Looking for target...OK
2/20 Reading JSON Specification...SKIP
3/20 Parsing JSON Specification...SKIP
4/20 Validating JSON Specification...OK
5/20 Looking for files...OK
6/20 Calculating size of image...OK
7/20 Creating temporary image...OK
8/20 Mounting temporary image...OK
9/20 Making hidden background folder...OK
10/20 Copying background...OK
11/20 Reading background dimensions...OK
12/20 Copying icon...OK
13/20 Setting icon...OK
14/20 Creating links...OK
15/20 Copying files... 			OK
16/20 Making all the visuals...OK
17/20 Blessing image...OK
18/20 Unmounting temporary image...OK
19/20 Finalizing image...OK
20/20 Removing temporary image...OK
Finished OK
App   => /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app
Image => /Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.dmg

OK, hopefully this debug information will help @sethlu figure out what the problem is (he is the maintainer of electron-osx-sign which what signs apps for electron-packager).

Hi @0x00A and @malept, I think the code signing process is carried out successfully; the app is correctly signed. However, would you try the following command and let us know the results?
codesign --verbose=4 --deep --strict /path/to.app

Ref: http://tech.byreach.com/node/2594 (in Chinese)

Hey @sethlu! Ok, here is the output from that command (the .app was produced by electron-packager 7.1.0).
$codesign --verbose=4 --deep --strict ./pkg/1.10.2/voltra-darwin-x64/voltra.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Mantle.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Squirrel.framework/Versions/Current/.
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper EH.app
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper EH.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper NP.app
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper NP.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper.app
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/voltra Helper.app
--prepared:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
--validated:/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
./pkg/1.10.2/voltra-darwin-x64/voltra.app: valid on disk
./pkg/1.10.2/voltra-darwin-x64/voltra.app: satisfies its Designated Requirement

@0x00A I guess your app is signed alright... Usually with that command codesign tells where in the app is there something missing.
Would you try remove your signing certs from Keychain and retrieve a new download/copy from Apple Developer? Additionally, mind trying the following command?
codesign --display --verbose=4 /path/to.app

I suspected that perhaps my cert was corrupted or something and I already tried removing them and re-adding them, i know that keychain isn't the most reliable app. Here is the output...
Executable=/Users/paolofragomeni/workroot/voltraco/voltra/pkg/1.10.2/voltra-darwin-x64/voltra.app/Contents/MacOS/voltra
Identifier=com.electron.voltra
Format=app bundle with Mach-O thin (x86_64)
CodeDirectory v=20200 size=275 flags=0x0(none) hashes=3+3 location=embedded
Hash type=sha256 size=32
CandidateCDHash sha1=bb0f59...
CandidateCDHash sha256=20e3bd...
Hash choices=sha1,sha256
CDHash=20e3bd...
Signature size=8917
Authority=Developer ID Application: Paulo Fragomeni (3CPSKTF8W5)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=Aug 22, 2016, 6:05:11 PM
Info.plist entries=21
TeamIdentifier=3CPSKTF8W5
Sealed Resources version=2 rules=12 files=2638
Internal requirements count=1 size=180

@0x00A sorry for my late reply. I tried to investigate a bit further on this issue but have thus far found no luck with previous cases. 😢 I would recommend your issue to Apple Developer and staff there may have a more comprehensive view on this?

/ dks /

@sethlu here's why it's absolutely not an issue for apple support: I'm using electron-osx-sign (0.4.0-beta4) after i package everything with electron-packager (7.1.0) and it works just fine. There are no complaints about the package not being signed.

Which version of electron-osx-sign is being used by Electron Packager when it doesn't work?

@malept looks electron-packager since 7.1.0, is using electron-osx-sign version ^0.3.0 (link to code). It's using that version currently (link to code). And the version that works for me uses that version too. So I'm guessing that how we're using electron-osx-sign in electron-packager has changed somehow.

Here is every single code change between 7.1.0 and 7.2.0. As you can see, nothing changed with regards to OSX signing changed in that release.
You mentioned that you use electron-osx-sign separately from Electron Packager? What happens when you use Electron Packager 8.0.0 and electron-osx-sign 0.4.0-beta4 separately?

Hmm, yeah thats interesting. when I use it separately, it works. right now this is the only way I can code sign my app.

I'd like to chime in that I'm experiencing this issue too, code sign verifies that the app is signed correctly but gatekeeper still gives an 'unidentified developer' message.
Debug output of osx-sign
 electron-osx-sign:warn No `entitlements` passed in arguments, will not sign with entitlements. +0ms
     electron-osx-sign Signing application... +2ms
     electron-osx-sign > application         /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app +1ms
     electron-osx-sign > platform            darwin +0ms
     electron-osx-sign > entitlements        undefined +0ms
     electron-osx-sign > child-entitlements  undefined +0ms
     electron-osx-sign > additional-binaries undefined +0ms
     electron-osx-sign > identity            3rd Party Mac Developer Application: MyIdentity +0ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework +121ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib +1s
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib +500ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Resources/crashpad_handler +653ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework +480ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/MyApp Helper EH.app/Contents/MacOS/MyApp Helper EH +1s
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/MyApp Helper EH.app +489ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/MyApp Helper NP.app/Contents/MacOS/MyApp Helper NP +484ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/MyApp Helper NP.app +475ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/MyApp Helper.app/Contents/MacOS/MyApp Helper +477ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/MyApp Helper.app +484ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle +515ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Mantle.framework +514ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/ReactiveCocoa.framework/Versions/A/ReactiveCocoa +484ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/ReactiveCocoa.framework +481ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Squirrel.framework/Versions/A/Resources/ShipIt +505ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel +475ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/Frameworks/Squirrel.framework +485ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app/Contents/MacOS/MyApp +481ms
     electron-osx-sign Signing... /var/folders/86/kd44ssfs30z5fmv0r_6zhbmr0000gn/T/electron-packager/darwin-x64/MyApp-darwin-x64/MyApp.app +511ms
     electron-osx-sign Verifying sign... +510ms

@TheMSB which version of Electron Packager is this?

@malept @TheMSB The darwin build should be signed with Developer ID Application rather than 3rd Party Mac Developer Application because the latter will be rejected by Gatekeeper.
@TheMSB would you try to codesign your app again with Developer ID Application instead and see if it works?

@sethlu indeed, seems the build script was using the wrong certificate. Thank you for pointing that out.


Export ReCaptchaComponent

Fixes issue 54

I think the better approach is to not change index.ts but export it from angular2-recaptcha.ts.

I thought that file was just to declare the module - but I am happy to follow your suggestion.

My understanding is that index.ts just serves as a shortcut so that one can do import ... from 'angular2-recaptacha instead of import ... from angular2-recaptcha/angular2-recaptcha. With the latter being the main file, I think it would be better to export all public classes from there.

Done

Nice work @BeheadedKamikaze :+1:


communicate  socketcluster  from non-socketcluster processes ?

can socketcluster communicate with other language process（like python）？

Use Redis events - or something else - and rely the events through the Broker process.
I am not a python expert, but this should work.
Just remember, this is pseudo-code. o.o
script.py
import redis
redisCon = redis.connect()
channel = redisCon.subscribe("SCBridge")
channel.publish({ "toChannel": "foo", "data": "My Message" })

broker.js
module.exports.run = function(broker) {
    var redis = require("redis");
    var conn = redis.createClient();
    conn.on("message", function(channel, data){
        if(channel == "SCBridge") {
            // Assuming that the sent data is JSON
            try {
                var o = JSON.parse(data);
                broker.publish(o.toChannel, o.data);
            } catch(e) {
                // Nope, not a JSON.
                console.error("Data has been sent to SCBridge that is no JSON.");
                console.error(data);
            }
        }
    });
}

I did not see a way to do actual eventing... But I bet you could utilize a Worker for this. Although it is not entirely their task, you could theoretically create a similar setup like above, except that instead of using broker.publish, you'd use something like worker.scServer.global.emit(evName, evData)...
Docs:
Broker http://socketcluster.io/#!/docs/api-broker
SCSocket on Worker http://socketcluster.io/#!/docs/api-scsocket-server


regexp support in nodejs

    var Arango = require("arangojs").Database;
    var arangoconn = new Arango("http://username:password@localhost:8529");
    var search1 = async (key) => {
        return new Promise((resolve, reject) => {
            arangoconn.useDatabase("db").query({
                query: "FOR data IN keywords FILTER data.keyword LIKE @key RETURN data",
                bindVars: {
                    key: "%" + key + "%"
                }
            }).then(
                cursor => cursor.all()
            ).then(
                res => resolve(res),
                err => reject(err)
            );
        });
    };
    var search2 = async (key) => {
        return new Promise((resolve, reject) => {
            arangoconn.useDatabase("db").collection("keywords").byExample({
                keyword: new RegExp(key)
            }).then(
                cursor => cursor.all()
            ).then(
                res => resolve(res),
                err => reject(err)
            );
        });
    };
    var data1 = await search1("keyword");
    var data2 = await search2("keyword");
    console.log(data1);
    console.log(data2);

search1 functions worked fine, but search2 failed.
i think, arrangodb must support regex search as in search2 function.

byExample() maps to the endpoint PUT /_api/simple/by-example. This belongs to the HTTP interface for Simple Queries. All /_api/simple routes are deprecated from 3.4.0 on. Simple Queries in the JS API were deprecated in 3.0 already. Support for regular expressions in the by-example route on the server side is therefore not to be expected.
On the driver side it might be possible to transform the query, but I am against such a solution. You should use an AQL query with a regex function instead:
                query: "FOR data IN keywords FILTER REGEX_TEST(data.keyword, @key) RETURN data",
                bindVars: {
                    key: "#[0-9a-fA-F]{6}"
                }

In order to support regular expressions for example queries, those queries would need to support regular expressions on the ArangoDB side. As the simple queries are no longer being developed and will be removed in a future version of ArangoDB, I don't see anything actionable here.


DSP-1106 Update Permission

resolves DSP-1106
Add the following routes for both default object access permission (doap) and administrative permission (ap)

[x] Put admin/permissions/<permissionIri>/group update a permission's group (doap or ap)

[x] Put admin/permissions/<permissionIri>/hasPermissions update a permission's hasPermissions (doap or ap)

[x] Put admin/permissions/<permissionIri>/resourceClass update a doap permission's resource class

[x] Put admin/permissions/<permissionIri>/property update a doap permission's property
For Put requests, the new values must be given in the request body

[x] add tests

[x] add test data

[x] add documentation

This isn't something that was changed in this PR, but I just noticed that in PermissionsResponderADM.userAdministrativePermissionsGetADM, there's something that looks like a bug:
    val permissionsPerProject: Iterable[Future[(IRI, Set[PermissionADM])]] = for {
      (projectIri, groups) <- groupsPerProject

      /* Explicitly add 'KnownUser' group */
      extendedUserGroups = OntologyConstants.KnoraAdmin.KnownUser ++ groups

      result = calculatePermission(projectIri, groups)

    } yield result

The variable extendedUserGroups is defined but its value is never used.

Thanks for pointing this out, I believe since KnownUser is most of the time already in the groups of the project,  this bug has not shown itself.
However, one should make sure that administrative permissions for KnownUser is also returned by calculatePermission method. Therefore, extendedUserGroups including KnownUser should be passed as its parameter.

@benjamingeer Thanks for reviewing this!


Include France in the list of supported countries

Hi,
Would it be possible to include France in the list of supported countries? It would be great if the service also returns BIC's for IBAN's from France :)

Hi,
do you have any pointers towards some official list of french banks (including BIC, bank code etc.) that could be used as a data source?
For Germany, the Bundesbank provides such a list as a download: https://www.bundesbank.de/en/tasks/payment-systems/services/bank-sort-codes/download-bank-sort-codes-626218
I took a quick look but couldn't find anything similar for France.

Hi,
it's sad but the french list is not free.
It seems we have to buy the official list from "Banque de France" or we have to use an unofficial list of "Code Banque/Code Guichet" to calcultate BIC from french IBAN.
I don't think that you have found an issue to this request ?
Thank you

Fyi, the European Central Bank is providing this list: https://www.ecb.europa.eu/stats/financial_corporations/list_of_financial_institutions/html/monthly_list-MID.en.html

I have created an easily importable go package to check an IBAN/BIC locally https://code.pfad.fr/swift/ (it uses code generation instead of a local database).
Supported country codes:
AT (Austria)
BE (Belgium)
CH (Switzerland)
DE (Germany)
ES (Spain)
FR (France)
LI (Liechtenstein)
LU (Luxembourg)
MC (Monaco)
NL (Netherlands)
Play with the demo in the browser, powered by JS+Wasm.


What is the difference between this and using TypeScript?

I don't really understand which TypeScript features are not supported. Since functions and string interpolation are included, how is this different from TypeScript itself? Maybe it would be helpful to specify what is not included in TSON.
In other words, is a JS runtime needed to parse TSON?

A lightweight runtime is required but it is bundled as part of the TySON libraries, so that users of TySON don't need any external dependencies (no dependencies on Node or V8). I'll work on documenting the differences w/ full TypeScript, but at a high-level, TySON only supports ES5-ES6 features.
As an example, async/await is not part of TySON.

It'd also be nice to have a comparison with deno, as it share some similarities with tyson's. for example, deno runs scripts sandboxed by default, and require fine-grained permission control:
 ~/r/e/deno-security  deno run --no-prompt io.ts     2023년 08월 11일 (금) 오후 05시 59분 50초
hello
error: Uncaught PermissionDenied: Requires read access to "io.ts", run again with the --allow-read flag
const text = await Deno.readTextFile('io.ts')
                        ^
    at Object.readTextFile (ext:deno_fs/30_fs.js:749:29)
    at file:///home/scarf/repo/etc/deno-security/io.ts:2:25
 !  ~/r/e/deno-security  deno run --no-prompt net.ts
error: Uncaught PermissionDenied: Requires net access to "www.example.com", run again with the --allow-net flag
await fetch("https://www.example.com")
      ^
    at opFetch (ext:deno_fetch/26_fetch.js:73:14)
    at mainFetch (ext:deno_fetch/26_fetch.js:182:59)
    at ext:deno_fetch/26_fetch.js:461:9
    at new Promise (<anonymous>)
    at fetch (ext:deno_fetch/26_fetch.js:424:18)
    at file:///home/scarf/repo/etc/deno-security/net.ts:1:7
 !  ~/r/e/deno-security  deno run --no-prompt run.ts
error: Uncaught PermissionDenied: Requires run access to "deno", run again with the --allow-run flag
await new Deno.Command("deno", { args: ["--version"] }).output()
                                                        ^
    at spawnChildInner (ext:runtime/40_process.js:162:17)
    at spawn (ext:runtime/40_process.js:348:10)
    at Command.output (ext:runtime/40_process.js:421:12)
    at file:///home/scarf/repo/etc/deno-security/run.ts:1:57

tho deno is quite heavy (109MiB as of in v1.36.1) due to V8 and tools being built-in, so tyson definitely have advantages here. interested to see how tyson grows!

It'd also be nice to have a comparison with deno, as it share some similarities with tyson's. for example, deno runs scripts sandboxed by default, and require fine-grained permission control:
 ~/r/e/deno-security  deno run --no-prompt io.ts     2023년 08월 11일 (금) 오후 05시 59분 50초
hello
error: Uncaught PermissionDenied: Requires read access to "io.ts", run again with the --allow-read flag
const text = await Deno.readTextFile('io.ts')
                        ^
    at Object.readTextFile (ext:deno_fs/30_fs.js:749:29)
    at file:///home/scarf/repo/etc/deno-security/io.ts:2:25
 !  ~/r/e/deno-security  deno run --no-prompt net.ts
error: Uncaught PermissionDenied: Requires net access to "www.example.com", run again with the --allow-net flag
await fetch("https://www.example.com")
      ^
    at opFetch (ext:deno_fetch/26_fetch.js:73:14)
    at mainFetch (ext:deno_fetch/26_fetch.js:182:59)
    at ext:deno_fetch/26_fetch.js:461:9
    at new Promise (<anonymous>)
    at fetch (ext:deno_fetch/26_fetch.js:424:18)
    at file:///home/scarf/repo/etc/deno-security/net.ts:1:7
 !  ~/r/e/deno-security  deno run --no-prompt run.ts
error: Uncaught PermissionDenied: Requires run access to "deno", run again with the --allow-run flag
await new Deno.Command("deno", { args: ["--version"] }).output()
                                                        ^
    at spawnChildInner (ext:runtime/40_process.js:162:17)
    at spawn (ext:runtime/40_process.js:348:10)
    at Command.output (ext:runtime/40_process.js:421:12)
    at file:///home/scarf/repo/etc/deno-security/run.ts:1:57

tho deno is quite heavy (109MiB as of in v1.36.1) due to V8 and tools being built-in, so tyson definitely have advantages here. interested to see how tyson grows!
Yeah, I can write up a comparison with deno, but I think you have similar thoughts already to mine. Basically, deno is awesome, and I whole-heartedly recommend it for someone developing a typescript application. If you are writing an application instead of configuration, go use deno, not tyson. But as an embedded interpreter that can be used from a host-language, deno is very heavy.

tyson is exclusively focused on configuration, so that might lead to other differences down the road too: say, the tyson "standard library" might include utilities useful for defining and validating schemas (something like https://github.com/colinhacks/zod or https://github.com/sinclairzx81/typebox)


Add Database EOL info banner

Add an info banner for all databases running on EOL versions.

This needs to be merged after https://github.com/aptible/deploy-api/pull/1517 is released.


Add a field for Linux support

It'd be nice if packages are marked as OS X-like (iOS, ...) only or whether they also support (and have been tested on) Linux.

Thanks for your suggestion! I've added tag support that allows supported OSs to be set on packages. I still have to work on integrating this into the post index view, but I already have an issue (#5) for that. Closing this one.


Feature/security settings

Adding CCAI Security Settings Class

@kmaphoenix tagged you in 3 comments above, both LGTM otherwise!


Pass existing SurfaceTexture to TextureRegistry

[✓] Flutter (Channel master, v1.8.2-pre.242, on Linux, locale en_US.UTF-8)
    • Flutter version 1.8.2-pre.242 at <install location>
    • Framework revision 9bb7142ef7 (21 hours ago), 2019-07-30 14:45:00 -0700
    • Engine revision c41bbc63d9
    • Dart version 2.5.0 (build 2.5.0-dev.1.0 1e43d65d4a)

Is it possible to call registerTexture to register a surface that was created outside of Flutter so that Flutter knows how to render it? It seems to be possible using a plugin via the registrar (?) but I think it should be possible to do so in an app directly.
Sorry if there is a way, I haven't been able to spot one. My thought is that FlutterView should have a set of register and unregister functions for this purpose.

Is this issue still relevant?

Yeah. No one replied or looked at it so I assume it is still relevant.

I also hope that Flutter has this ability very much. Because I want to use external texture to display image, I want to create a SurfaceTexture with singleBufferMode.

Closing this issue as fixed in the linked PR


[QUESTION] assetbundle CRC & Hash

This is not an issue with sssekai, but a question regarding the data retrieved from the game's assetbundle-info endpoint.
Do you know how the crc and hash values contained within this data for each assetbundle are calculated?
Example excerpt from the JP assetbundle info for version <IP_ADDRESS>:
{
    "bundleName": "area/area16",
    "cacheFileName": "773649635f5fe7f5a8752b3e1e069447",
    "cacheDirectoryName": "4b82",
    "hash": "4048fd0edd7c9b611a7f100a352101ee",
    "category": "StartApp",
    "crc":<PHONE_NUMBER>,
    "fileSize": 1832748,
    "dependencies": [],
    "paths": [
        "StartApp/area/area16",
        "StartApp/area/area16/Material",
        "StartApp/area/area16/Prefab",
        "StartApp/area/area16/Texture"
    ],
    "isBuiltin": false
}

I have tried to calculate the hash value manually using MD5 and MD4 on both encrypted and unencrypted assetbundles, but always receive a different hash value than is reported in the assetbundle info.
If you have a local copy of every assetbundle from version <IP_ADDRESS> and wanted to update that copy to, say, <IP_ADDRESS>, knowing this would allow one to only download the assets that changed between versions.

I assumed the game never updated the files based on their content  - instead they kept track of a local version of AssetBundleInfo, storing the mapping of downloaded ABs (w/ hashes and other stuff) instead.
Decompiled code suggested the same - though I could be missing out on things. I didn't find anything concrete on calculating the downloaded bundles' hashes.
I assume doing so would avoid the extra IO for integrity check since the ones stored are (typically) guaranteed to match the hash values unless otherwise tampered.
Tbh it might be better to do the updates this way too

I see, so in the scenario that we are updating from asset version <IP_ADDRESS> -> <IP_ADDRESS>:
The game takes the AssetBundleInfo for version <IP_ADDRESS> and compares the computed hashes for each assetbundle to the new computed hashes in the AssetBundleInfo for version <IP_ADDRESS>, downloading any differences.
It's honestly pretty ingenious.
That makes a lot more sense now, thanks for the clarification on that.
Amazing blog post series by the way. I read that part, but Google Translate made it pretty vague.


Allow FormField labelWidth to override min width.

I moved the application of the min width out of the css and into JS, and only apply it if a specific labelWidth has not been provided. This maintains the current expected behaviour, while allowing labels narrower than 80px.
Another potential solution would be to remove the concept of a min width entirely - labels are either sized explicitly, or use their natural size. This may be a simpler API, but may potentially be a breaking change to any apps currently depending on the min width.

Thanks for fixing. I agree that the minWidth might is likely not adding much at this point, and I would support removing it if we found ourselves bumping up against this again and wanting to change it.
For now, I am happy to merge this as a clear incremental improvement.  We can keep an eye on it.


Feature/new react polymorph bubble component

Starts work on #26.  It just creates the Bubble component, simple skin, theme, and stories.  @DominikGuzei Let me know if this is along the lines of what you had in mind, and any feedback you have.  If it looks good, I can use it in the Options component, and create the Tooltip component.

Ah, sorry, there was an issue with my monitor.  I was confused why I had to halve the border radius 😂

Latest version is looking correct for me on my laptop's display.  I've also included the work to use the Bubble component in the Options component - I've tested it in all of the stories for Autocomplete and Select and it works for me.  I'll work on the Tooltip component later tonight, let me know if you have any other items to note!

Yeah i just reviewed the other changes you made regarding the Options component and this looks good 👍  At the moment we only need the Tooltip additionally (you could do this in a separate PR).

Sounds good.  I just fixed one last bug I noticed where the first element of an Options#isOpeningUpward component wouldn't update the arrow colour.  I'll submit a second PR for the Tooltip component!

Thanks for the fixes @bendyorke! Please add an entry to the CHANGELOG.md, then i will merge this! 👍


Add support for BlackKite protocol.

BlackKite is closely based on the Galileo protocol. We derive code
from the Galileo protocol and make changes as required to meet
BlackKite protocol specifications.

Thanks for the pull request. Can you provide some information about the brand or device? Is there an official website?

@tananaev The device information is available from http://www.zilogic.com/blog/blackkite-fleet.html The user manual is should become available shortly.


Why don't you import from diffusers instead of using relative imports?

if you replace imports like from ...models import AutoencoderKL, UNet2DConditionModel with from diffusers.models import AutoencoderKL, UNet2DConditionModel you can copy paste the pipeline files in your code and simply run it without patching diffusers
Should i open a PR to do this?
Also, why not add these pipelines to the diffusers package with a PR instead of keeping them in a separate repository?

Because this repo is implemented before the diffusers officially supports. I will update this repo ASAP to be compatible with the lastest version of diffusers. @remorses


Python API: create_reader() argument reader_listener causes exception

Describe the bug
Python API describes option reader_listener but it causes an exception when used.
To Reproduce
Steps to reproduce the behavior:
import pulsar

client = pulsar.Client('pulsar://localhost:6650')

msg_id = pulsar.MessageId.earliest

def foo(*a, **b):
    pass
reader = client.create_reader('my-topic', msg_id, reader_listener=foo)

while True:
    msg = reader.read_next()
    print("Received message %r id=%s" % (msg.data(), msg.message_id()))

Generates the following exception:
Traceback (most recent call last):
  File "read.py", line 9, in <module>
    reader = client.create_reader('my-topic', msg_id, reader_listener=foo)
  File "/usr/local/lib/python3.6/dist-packages/pulsar/__init__.py", line 684, in create_reader
    conf.reader_listener(_listener_wrapper(reader_listener, schema))
AttributeError: 'ReaderConfiguration' object has no attribute 'reader_listener'

Expected behavior
To configure reader successfully
Screenshots
N/A
Desktop (please complete the following information):
N/A
Additional context
Issue separated out from #5365
pulsar-client-cpp/python/src/config.cc says:
    class_<ReaderConfiguration>("ReaderConfiguration")
            .def("message_listener", &ReaderConfiguration_setReaderListener, return_self<>())

But the python code in pulsar-client-cpp/python/pulsar/__init__.py calls conf.reader_listener instead:
        conf = _pulsar.ReaderConfiguration()
        if reader_listener:
            conf.reader_listener(_listener_wrapper(reader_listener, schema))

I suspect the former is a typo and should change to .def("reader_listener")
(I don't have a build env setup to test this.  Also, probably should have a test case adding to pick this problem up)

Thanks @candlerb for the help. Nice reporting and analysis for this issue, will you provide a PR for the fix?


fix for skippable ads

making sure onAdComplete_() is called when ad is skipped.

Hi there - I'm not sure that the code change you submitted will result in the behavior that you want. The COMPLETE event should be fired every time an ad finishes, whereas the ALL_ADS_COMPLETED event will only fire after all ads have been finished. So for example if you have a playlist with a pre-roll and a mid-roll, this change makes it so that onAdComplete_ will only be called after the mid-roll, not after the pre-roll.

ok that makes sense. I could use the SKIPPED event instead. see my last commit https://github.com/tape-tv/videojs-ima/commit/4b4b9df422b4c34dfd7feac3ef82a3947c0f441c

@shawnbuso i hope i addressed all of your issues. Thanks for looking into this so thoroughly.

Added one line note, other than that LGTM.


ll40ls for rpi3

is the ll40ls compatible with the posix platform (rpi3) because when I compile I get error about (nuttx/clock.h and nuttx/wqueue.h).

You'll need to go through and fix those issues. Remove the nuttx headers first, then readd generic headers as needed.

Or in other words: It is reasonably easy and a pull request would be appreciated.

sorry I am not an expert. So I just have to remove the headers ? because after that several problems concerning the variable or function 'work' appear .

@belaidH yes remove those headers, and in that case add #include <px4_workqueue.h>.

Okey thank you. I will try it

I think now it's okay for the workqueue. but I get an other error
about the irqstate_t on the LidarLiteI2C.cpp file (I would use the I2C of the rpi).

@belaidH you can replace the critical sections with ATOMIC_ENTER/ATOMIC_LEAVE.
On NuttX it's the same thing - https://github.com/PX4/Firmware/blob/master/src/drivers/device/nuttx/cdev_platform.hpp#L10
On other platforms it's a lock - https://github.com/PX4/Firmware/blob/master/src/drivers/device/posix/cdev_platform.hpp#L6

@dagar thank you. after some tries it's compiled. Is there manip to start the ll40ls after launching the ./px4 because I don't see his topic when I use the "uorb top" command.

Does it work if you start it manually ll40ls start?
Once you're sure it's working you could add it to the raspberry pi configs here. https://github.com/PX4/Firmware/tree/master/posix-configs/rpi


We must be able to accept and reject a request for connection (includes accept and reject message generation)

As a market actor
We want to be able to connect a consumption metering point
So that we can start the delivery of power
Acceptance criteria

[x] We can accept a request from a balance supplier
[x] We can generate an accept message

[x] Move-in is completed with todays date

[x] We can reject a request from a balance supplier
We can perform the following validations:

[x] The identification of a metering point is mandatory (rejection code E10)
[ ] The physical status of the metering point to which the master data applies must change from new to connected (Rejection code D16)

[ ] The consumption metering point with  supply obligation to which the master data information applies may only be connected if a balance supplier is registered on the effective date. (Rejection codeD36)
[ ] The data information must be received within the correct time frame  (rejection code E17)

[x] We can generate a reject message

Tasks
Create command handler https://github.com/Energinet-DataHub/geh-metering-point/issues/160
Perform input validations https://github.com/Energinet-DataHub/geh-metering-point/issues/161
Create result handler https://github.com/Energinet-DataHub/geh-metering-point/issues/162
Integration event https://github.com/Energinet-DataHub/geh-metering-point/issues/163

Issue is in wrong repo


RE-184 Ensure that user_defaults are copied

Currently the user_defaults file is only
implemented in the AIO bootstrap, but it
should be implemented for all deployments.
This patch switches the implementation into
the deploy script to cover all deployments.

Can one of the admins verify this patch?


[BUG] air-gapped infrastructure installation not downloading for ubuntu-18.04

Hi Team,
I'm trying to trigger air-gapped script for ubuntu-18.04 but seems like it is not working out,

This is just a message stating that the OS you want to install a specific version of Epiphany on is not supported. We have some restrictions which operating systems are supported by different versions of Epiphany. Check point 2 in the following links:

1.0.x
2.0.x

Closing as this is not an issue.


Support the publishing of Message attributes

Allow SNS Message Attributes to be specified and published.
This is an iteration that will eventually enable message filtering as requested in #26
I referenced the AWS SNS in the Message base class, as I thought it was much cleaner to simply pass MessageAttributes around rather than implement an abstraction on top of this. This can be changed if there's disagreement.

I think it's important to keep Message clean of AWS types, as it can be used in lots of simple models contracts, it already a bit much asking people to reference JustSaying.Models.
I made a suggestion here around filtering which would require the attributes to be configured at a publisher level, rather than per publish, but I'm not sure how I feel about it:
https://github.com/justeat/JustSaying/issues/351#issuecomment-377028548
This is a design decision that needs solving soon, there is the concept of a "message envelope" where you have a type that exposed the raw AWK types, and also presents a property of T where T is your message, this has been with regards to handlers, but could also be used for publishing. Or another proposal is to have some sort of mapper, where you can configure what properties go in the body, vs attributes. We need to pick something soon.

I think it's important to keep Message clean of AWS types, as it can be used in lots of simple models contracts, it already a bit much asking people to reference JustSaying.Models.

I agree, it would be much nicer to get rid of JustSaying.Models.Message, and my current feeling is that adding a further abstraction over MessageAttributes makes this harder, not easier.

I made a suggestion here around filtering which would require the attributes to be configured at a publisher level, rather than per publish, but I'm not sure how I feel about it:
#351 (comment)

I saw that and actually started with that as a solution, however I noticed difficulties in implementing it. And I'm strongly against it, but I'll comment there, not here!

This is a design decision that needs solving soon, there is the concept of a "message envelope" where you have a type that exposed the raw AWS types, and also presents a property of T where T is your message, this has been with regards to handlers, but could also be used for publishing. Or another proposal is to have some sort of mapper, where you can configure what properties go in the body, vs attributes. We need to pick something soon.

Yeah, personally I would love to get rid of the generic types altogether.
Anyway, this is the smallest, simplest and cleanest change I could make to implement the ability to support MessageAttributes.

Cool, we are agreed on most things 😃 This is simplest in terms of code, but not in terms of the implications. First because of the SNS package dependency for projects containing models. Secondly because it forces a decision on the message envelope discussion (@AnthonySteele your view?)
If we tweaked this so that we have our own type for MessageAttributeValue, I'd be in favour.

I'm literally just going to take your comments and turn them into code.
As you have strong opinions around justsaying that I can't possibly have, then perhaps you could make any appropriate changes and we can close this long feedback loop?

😄 I'm not sure I have strong opinions, just like to discuss code changes like this. I'm happy to make tweaks to this PR.
One thing I'd need some input on from other is what we do about versions, currently there is a 6.0.0-beta1 out, that should really be released before moving ahead with a beta release of this.
Can those at Just Eat who are trailing this confirm it's suitable for release.

I have no objection to this PR, two things to consider

putting the attributes on the message base class is probably the right call for now. It's not perfect but until we make breaking changes to how / if this base class is used, it's where things like this metadata are stored.

This only affects publishing? The attributes will still be there on the message base class when reading, should be populated then as well at that point?

After the last long-lived V5 branch, I would be cautious about versioning to 5.1 while there's a 6.0 beta as well. We can do it, but if we do, have a plan to make it very short lived and to keep  the branches in sync.

Agreed on point 1 @AnthonySteele 👍
Point 2, good question, at the moment it will not be populated, it could be done as I understand by asking for All attributes when doing the receive request, then populating it manually, or maybe explicitly requesting the attributes that are wanted. The thing with the Message base class is that it's already asymmetric in the way we use it today.
Point 3, I think the intention here was to release it as 6.1.0 (and JustSaying.Models as 5.1.0), which would follow the 6.0.0 rtm. So we should look to get that out soon-ish (or should it include whatever breaking change #358 requires?).

MemoryStream > byte[] and Models version set to 5.1.0

This is good to merge, but

For simplicity, version number of models assembly should be same an the main JustSaying version number.

We will merge this to a 6.0 beta unless there's a good reason to lock down 6.0 beforehand. So version number would be 6.0


INT B-19780 CSV Export for Queue Tables

B-19780

[!NOTE]
Minor additional work will be needed to support CSV export on the queues visible to HQ users. This will be added once B-20011 B-20013 and B-20014 are PO accepted.

Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the office app
Login as a Counselor (ideally in KKFA due to available test data)
Locate the "Export to CSV" button to the top right of your queue table, press it and make sure it exports a CSV that matches the data in the table. The file should contain every move in your queue, not just those on the current page.
Apply your choice of filters or sorting, export to CSV again and ensure the data exported matches with applied filter and/or sorting.
Repeat for the SC's PPM Closeout Queue
Repeat for the TOO's Queue
Repeat for the TIO's Queue

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Accidentally created this with the wrong base branch so the wrong tests were running.

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against e8b3875c8eab9a05d08b1c075b8e5005977cf6bb


Try introducing Typescript

Initial conversion of files from Flow on https://github.com/Psigio/iD/commit/8ce8b03023d7df230b44b74f6ad0703a1e007a9e

Due to an issue reported on rollup-plugin-typescript (#43) - moved to https://github.com/ezolenko/rollup-plugin-typescript2 - this seems to work correctly in that typescript errors cause the build to fail.


TestRunWithKernelMemory failed

It seems that the commit 8dd3d634556427c22769125ef2b0aa2ce613a2a7  (https://github.com/opencontainers/runc/commit/8dd3d634556427c22769125ef2b0aa2ce613a2a7 )broke the TestRunWithKernelMemory test:
--- FAIL: TestRunWithKernelMemory (0.13s)^M
    exec_test.go:671: runContainer failed with kernel memory limit: process_linux.go:291: setting cgroup config for ready process caused "cannot set kmem.limit_in_bytes after task have joined this cgroup"^M

@rhatdan, @mrunalp, PTAL.


Build(deps-dev): Bump @types/react-syntax-highlighter from 15.5.10 to 15.5.13 (#5813)

Pull request opened by the merge tool on behalf of #5813

Merged in e737b67742497e179ccb418af787ca93d6f52c6d


Improve summary and description

Updated with feedback.

I’ll merge this now, but additional feedback (like :+1:s) is still welcome.


Changes after impl Trait type alias become stable

RFC: https://github.com/rust-lang/rfcs/pull/2071
After this RFC gets merged, it will be possible for vulkano users to store strongly-typed structs such as the GraphicsPipeline<_, _, _> (as a impl GraphicsPipelineAbstract), the PersistentDescriptorSet<_, _> (as a DescriptorSet) or the struct generated by single_pass_render_pass! (as a impl RenderPassAbstract).
Therefore we will be able to add associated types and generics to these traits, which allows lots of nice changes:

GraphicsPipelineAbstract will take an associated type VertexDefinition, which will finally make strong typing possible for vertex sources.
Instead of implementing RenderPass and PipelineLayout directly on the pipeline objects and the framebuffer, add new traits AsRenderPass and AsPipelineLayout and implement them instead.
The various lock()/unlock() functions can be replaced with a proper Lock associated type. Also requires the HKTs RFC that was recently approved (which I can't find the link for).

The HKTs RFC is rust-lang/rfcs#1598 which will be merged soon (FCP ended).

It seems that Vulkano's designed has changed enough in the meantime that this issue doesn't really make sense anymore.


SyN-SDC fails for non-default template spaces

See Neurostars #4381.
traits.trait_errors.TraitError: The ‘transforms’ trait of an ApplyTransformsInputSpec instance must be a list of items which are an existing file name or ‘identity’, but a value of [’/scratch/fmriprep_wf/single_subject_01_wf/func_preproc_task_facelocalizer_wf/sdc_wf/syn_sdc_wf/ref_2_t1/transform0GenericAffine.mat’, ‘/scratch/fmriprep_wf/single_subject_01_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registration/ants_t1_to_mniInverseComposite.h5’, ‘/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat’] <class ‘list’> was specified.

Error setting node input:
Node: atlas_2_ref
input: transforms
results_file: /scratch/fmriprep_wf/single_subject_01_wf/func_preproc_task_facelocalizer_wf/sdc_wf/syn_sdc_wf/transform_list/result_transform_list.pklz
value: [’/scratch/fmriprep_wf/single_subject_01_wf/func_preproc_task_facelocalizer_wf/sdc_wf/syn_sdc_wf/ref_2_t1/transform0GenericAffine.mat’, ‘/scratch/fmriprep_wf/single_subject_01_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registration/ants_t1_to_mniInverseComposite.h5’, ‘/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat’]

We're missing affine transformations from the fieldmap atlas to other templates.

This should go into TemplateFlow (it is one of its inception principles and requirements)

Hi all,
I just realized this is still not working; is there a way around this for now?

Node Name: fmriprep_wf.single_subject_NDARAU530GLJ_wf.func_preproc_task_rest_run_2_wf.sdc_wf.syn_sdc_wf.atlas_2_ref
File: /out/fmriprep/sub-NDARAU530GLJ/log/20190707-141844_d5b13a54-1df0-4efa-8851-0b634a2e2e6b/crash-20190708-094223-root-atlas_2_ref-593063a6-e1ca-48d4-80e2-4dde6cfe0d1e.txt
Working Directory: /tmp/work/fmriprep_wf/single_subject_NDARAU530GLJ_wf/func_preproc_task_rest_run_2_wf/sdc_wf/syn_sdc_wf/atlas_2_ref
Inputs:
args:
default_value: 0.0
dimension:
environ: {'NSLOTS': '7'}
float: False
input_image: /usr/local/miniconda/lib/python3.7/site-packages/fmriprep/data/fmap_atlas.nii.gz
input_image_type:
interpolation: Linear
interpolation_parameters:
invert_transform_flags: [True, False, False]
num_threads: 7
out_postfix: _trans
output_image:
print_out_composite_warp_file:
reference_image:
transforms:

Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 69, in run_node
    result['result'] = node.run(updatehash=updatehash)
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 410, in run
    cached, updated = self.is_cached()
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 296, in is_cached
    hashed_inputs, hashvalue = self._get_hashval()
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 493, in _get_hashval
    self._get_inputs()
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 540, in _get_inputs
    self.set_input(key, deepcopy(output_value))
  File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 278, in set_input
    setattr(self.inputs, parameter, deepcopy(val))
  File "/usr/local/miniconda/lib/python3.7/site-packages/traits/trait_handlers.py", line 172, in error
    value )
traits.trait_errors.TraitError: The 'transforms' trait of an ApplyTransformsInputSpec instance must be a list of items which are an existing file name or 'identity', but a value of ['/tmp/work/fmriprep_wf/single_subject_NDARAU530GLJ_wf/func_preproc_task_rest_run_2_wf/sdc_wf/syn_sdc_wf/ref_2_t1/transform0GenericAffine.mat', '/tmp/work/fmriprep_wf/single_subject_NDARAU530GLJ_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registration/ants_t1_to_mniInverseComposite.h5', '/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat']  was specified.

Error setting node input:
Node: atlas_2_ref
input: transforms
results_file: /tmp/work/fmriprep_wf/single_subject_NDARAU530GLJ_wf/func_preproc_task_rest_run_2_wf/sdc_wf/syn_sdc_wf/transform_list/result_transform_list.pklz
value: ['/tmp/work/fmriprep_wf/single_subject_NDARAU530GLJ_wf/func_preproc_task_rest_run_2_wf/sdc_wf/syn_sdc_wf/ref_2_t1/transform0GenericAffine.mat', '/tmp/work/fmriprep_wf/single_subject_NDARAU530GLJ_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registration/ants_t1_to_mniInverseComposite.h5', '/usr/local/miniconda/lib/python3.7/site-packages/fmriprep/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat']

Dear all,
This issue is still present on v. 1.5.0
I suspect it failing because I also use aroma and it seems to be looking for the template aroma adds.
I'm trying to re-run now everything with an explicit --output-spaces with all spaces in correct order:
singularity run --cleanenv  ${VSC_DATA}/fmriprep.simg --output-spaces MNI152NLin2009cAsym anat MNI152NLin6Asym:res-2 --nthreads 36 \ --output-spaces anat --use-aroma --fs-license-file ./license.txt --use-syn-sdc \ --work-dir . --resource-monitor --nthreads 36 --mem-mb 189000 --fs-no-reconall \ data fmriprep_out2 participant
I will keep you updated how this works.
For now the error-log I get:
`191112-11:05:41,737 nipype.workflow WARNING:
Error while checking node hash, forcing re-run. Although this error may not prevent the workflow from running, it could indicate a major problem. Please report a new issue at
https://github.com/nipy/nipype/issues adding the following information:
Node: fmriprep_wf.single_subject_Ct07_wf.func_preproc_task_rest_wf.sdc_wf.syn_sdc_wf.atlas_2_ref
Interface: niworkflows.interfaces.fixes.FixHeaderApplyTransforms
Traceback:

Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/base.py", line 337, in _local_hash_check
cached, updated = self.procs[jobid].is_cached()
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 297, in is_cached
hashed_inputs, hashvalue = self._get_hashval()
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 494, in _get_hashval
self._get_inputs()
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 541, in _get_inputs
self.set_input(key, deepcopy(output_value))
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 279, in set_input
setattr(self.inputs, parameter, deepcopy(val))
File "/usr/local/miniconda/lib/python3.7/site-packages/traits/trait_handlers.py", line 172, in error
value )
traits.trait_errors.TraitError: The 'transforms' trait of an ApplyTransformsInputSpec instance must be a list of items which are a pathlike object or string representing an existing fi
le or 'identity', but a value of ['/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/ref_2_t1/tran
sform0GenericAffine.mat', '/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registrati
on/ants_t1_to_mniInverseComposite.h5', '/usr/local/miniconda/lib/python3.7/site-packages/sdcflows/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat'] <class 'list'> was specified.
Error setting node input:
Node: atlas_2_ref
input: transforms
results_file: /ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/transform_list/result_transform_li
st.pklz
value: ['/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/ref_2_t1/transform0GenericAffine.mat',
'/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registration/ants_t1_to_mniInverseCo
mposite.h5', '/usr/local/miniconda/lib/python3.7/site-packages/sdcflows/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat']
191112-11:05:46,208 nipype.workflow INFO:
[Node] Setting-up "fmriprep_wf.single_subject_Ct07_wf.func_preproc_task_rest_wf.sdc_wf.syn_sdc_wf.atlas_2_ref" in "/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmr
iprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/atlas_2_ref".
191112-11:05:47,639 nipype.workflow ERROR:
Node atlas_2_ref failed to run on host r23i27n18.
191112-11:05:47,650 nipype.workflow ERROR:
Saving crash info to /ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_out2/fmriprep/sub-Ct07/log/20191112-110350_f89f92b4-7a2c-4acd-9d71-4cac4172f9ce/crash-20
191112-110547-vsc32466-atlas_2_ref-137b4a86-7a53-49b8-b65c-e1bd0a02bf93.txt
Traceback (most recent call last):
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/plugins/multiproc.py", line 69, in run_node
result['result'] = node.run(updatehash=updatehash)
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 411, in run
cached, updated = self.is_cached()
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 297, in is_cached
hashed_inputs, hashvalue = self._get_hashval()
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 494, in _get_hashval
self._get_inputs()
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 541, in _get_inputs
self.set_input(key, deepcopy(output_value))
File "/usr/local/miniconda/lib/python3.7/site-packages/nipype/pipeline/engine/nodes.py", line 279, in set_input
setattr(self.inputs, parameter, deepcopy(val))
File "/usr/local/miniconda/lib/python3.7/site-packages/traits/trait_handlers.py", line 172, in error
value )
traits.trait_errors.TraitError: The 'transforms' trait of an ApplyTransformsInputSpec instance must be a list of items which are a pathlike object or string representing an existing fi
le or 'identity', but a value of ['/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/ref_2_t1/tran
sform0GenericAffine.mat', '/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registrati
on/ants_t1_to_mniInverseComposite.h5', '/usr/local/miniconda/lib/python3.7/site-packages/sdcflows/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat'] <class 'list'> was specified.
Error setting node input:
Node: atlas_2_ref
input: transforms
results_file: /ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/transform_list/result_transform_li
st.pklz
value: ['/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/func_preproc_task_rest_wf/sdc_wf/syn_sdc_wf/ref_2_t1/transform0GenericAffine.mat',
'/ddn1/vol1/site_scratch/leuven/324/vsc32466/testfmriprep/fmriprep_wf/single_subject_Ct07_wf/anat_preproc_wf/anat_norm_wf/_template_MNI152NLin6Asym/registration/ants_t1_to_mniInverseCo
mposite.h5', '/usr/local/miniconda/lib/python3.7/site-packages/sdcflows/data/fmap_atlas_2_MNI152NLin6Asym_affine.mat']
191112-11:05:49,638 nipype.workflow ERROR:
could not run node: fmriprep_wf.single_subject_Ct07_wf.func_preproc_task_rest_wf.sdc_wf.syn_sdc_wf.atlas_2_ref`

Hi - just wondering if there is a solution to this in any of the newer releases? We are doing analysis in subject space and would like to use syn-sdc for distortion correction. Thanks.

Hi - just wondering if there is a solution to this in any of the newer releases? We are doing analysis in subject space and would like to use syn-sdc for distortion correction. Thanks.

The work-around works perfectly, just specify explicitly the necessary atlas space

Hi - just wondering if there is a solution to this in any of the newer releases? We are doing analysis in subject space and would like to use syn-sdc for distortion correction. Thanks.

The work-around works perfectly, just specify explicitly the necessary atlas space

@JeroenBlommaert : could you elaborate on this please. What is the work around?

Hi - just wondering if there is a solution to this in any of the newer releases? We are doing analysis in subject space and would like to use syn-sdc for distortion correction. Thanks.

The work-around works perfectly, just specify explicitly the necessary atlas space

@JeroenBlommaert : could you elaborate on this please. What is the work around?

I was referring to this thread mentioned above.
Basically, you have to add MNI152NLin2009cAsym to your output spaces


Add TypeScript typings

A heads up, I've found some errors running: npx tsc --checkJs true --noEmit --target es2020 --module nodenext test/all.js.  (The target and module options are just to minimize the noise.)
The most interesting ones are on the statements:

Buffer.alloc(i).subarray(i),
[Buffer.from([1, 2, 3]), Buffer.from([4, 5, 6], [7, 8, 9])],
Buffer.alloc(i).subarray(i).equals(Buffer.alloc(i).subarray(i)),

Good catches! Buffer.alloc(i).subarray(i) and Buffer.alloc(i).subarray(i).equals(Buffer.alloc(i).subarray(i)) are both expected to fail type checking as Uint8Array.subarray() is declared as returning a Uint8Array rather than this, which is a bug in the core ES typings. Buffer.from([4, 5, 6], [7, 8, 9]) is an actual issue though in the sense that from(data) doesn't accept a second argument. I've removed it from the test.


Include watchOS 4.0 in @available check

Include watchOS in the availability check for sortedKeys allowing the library to compile under watchOS.
This wouldn’t normally be necessary given that watchOS snapshots are not currently supported.
However Xcode seems to try and compile test targets when generating SwiftUI previews and so those targeting Apple Watch weren’t rendering.
This was making it difficult to work with SwiftUI previews inside modules containing views intended for both phone and watch platforms.

I also faced the need for these changes. Snapshots are an iOS-only dependency and I can run tests for watchOS without any issues. But somehow the SwiftUI preview for watchOS requires these changes.
It would be nice if someone could review and merge it.

Thanks!


fix bug in start-autoscale.sh since it lack of add hpa to beekeeper

fix bug in start-autoscale.sh since it lack of add hpa to beekeeper
Signed-off-by: linzhinan<EMAIL_ADDRESS>

Coverage remained the same at 93.75% when pulling 7acb2fb5e50dbe08b3c6200e35c0222cbe98f296 on zenlinTechnofreak:fixbug into affb9c925e9647621b90d01f80563b3840ae42f6 on ServiceComb:master.


add some languages

please alphabetize the lists

"inne" (en. other) is on bottom list on purpose.

sorry, I should be more specific. the items in the lists should be in alphabetical order by title. it should be OK to have the "inne" list at the end.
So instead of putting "Blog Majstra" at the end of the HTML list, it should be at the beginning.
See the Travis output for details.

I will say yes, it resources from request, come from https://git.io/v5sKa users polish version stackoverflow about name passion IT. Yes, many of them are like blogs (even kurshtml.edu.pl which true the whole site is like a book but is update how plain blog). However polish tutorials they are rarely ever books (or I did not meet them, usually was it outdated sites - eg. http://kurs-c-plus-plus.cba.pl/ which is very rich in information about programming windows applications in c++ but latest update is from 2013)

May I suggest that the other polish-language resources be gathered into a "free-programming-resources-pl.md" file?
If this would remove any possible doubts then I'm too.

Great, I look forward to a revised PR.


Add an option to have tipping

Having an option to tip on the cartbox which also shows in the order details for both admin and customer.

+1

+1

My buddy Jabed is working on this now.

+1

This is a required feature in the US.

1

@sampoyigi I can work on this if you haven't started it?

Go for it! I actually left this to the community :)

This is being actively worked on here, feel free to contribute if you want to see it improve: https://github.com/tastyigniter/ti-ext-cart/pull/7

Added.


fix(protocol): Foundry has an issue with the seed

A trial branch to fix the tests in-house - most probably a foundry issue tho.

@davidtaikocha is it possible to update cargo in ci config ?
(I conclude something like this happens to us as well: https://stackoverflow.com/questions/72896871/cargo-test-keeps-failing-on-github-actions-but-passes-on-local-machine)


Add redirects array to the response

Adds a redirect array allowing users to see where it goes
Image of why this is useful

Added redirects array

hmm it seems that github doesn't like imgur urls (well for me at least) heres the link just in case https://imgur.com/a/BK9siIF
Thanks for the quick reply!
I like your idea of the headers
maybe a array of objects?
{
  url: "",
  response: {}
}

or not the whole response just the headers?

hmm it seems that github doesn't like imgur urls

You can just paste an image, and GitHub takes care of the uploading for you.

I like your idea of the headers
maybe a array of objects?

Makes sense.

or not the whole response just the headers?

Just the headers, I'd say. Perhaps status code too.

Does this look good?
https://imgur.com/a/ZK3hZAE

Why the screenshot, just text is easier to read 😄
But yes, looks good. Now let's make that configurable, have tests, and we're good to go.

Merged as d18d79db7555d70796796557a7227eb9cd2cbcdd.


Using WoodburyMatrices, take 2

This PR superseeds #56 - it does the same thing, but only loads the WoodburyMatrices package on Julia versions that don't have Woodbury matrices in base.

Coverage decreased (-20.61%) to 76.51% when pulling 7300a93c1f5eebf4ec609ce14b6e0f7be11ec2fc on woodbury into 2c7a96ce2563065748f2c5178cdb77e2182bf311 on master.

Coverage decreased (-15.86%) to 81.26% when pulling 7300a93c1f5eebf4ec609ce14b6e0f7be11ec2fc on woodbury into 2c7a96ce2563065748f2c5178cdb77e2182bf311 on master.

Thanks!


I cant authenticate

Im trying authenticate in my firebase whit a created user.
authentication =<EMAIL_ADDRESS>True, True)
firebase = FirebaseApplication('https://admt.firebaseio.com/', None)
firebase.authentication = authentication

and the error is
File "/usr/lib/python3/dist-packages/requests/models.py", line 940, in raise_for_status
   raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url:

there is a way to auth whit master apikey account? or how to auth whit user and password?

I had the same problem and posted this question and my solution here: https://stackoverflow.com/questions/57530684/firebase-database-401-for-all-get-and-post-requests-using-auth-version-2/57530708#57530708


Fix crossProject support

Classes were not being packaged properly for natchez-log module.  This was
discovered after doing local testing.
Need to make sure that the -2 directory is added to sources so they are released.
natchez-log for 0.0.14-M3 did not contain any classes.

Can you explain this a little bit more? All the projects have scala-2 and scala-3 directories, added higher up in the build. Why do the js projects need special handling?

@tpolecat the scalajs projects have shared/src/main, the shared directory is "special" to crossProject projects.  By default, it picks up shared/src/main, but one needs to override it to pick up source directories for scala2 vs. scala3.
I did some poking around in other projects, and sbt-spiewak seems to take care of this very well, so I dug into the Plugin and found this - https://github.com/djspiewak/sbt-spiewak/blob/7048b251e96773b6ebdc1100b243608628326351/core/src/main/scala/sbtspiewak/SpiewakPlugin.scala#L458
Following this into crossProject - the sharedSrcDir is set based on the cross project CrossType, which by default is Full in order to support cross compiling to scalajs and scala (as well as native if so desired) - https://github.com/portable-scala/sbt-crossproject/blob/e1ec68f1321a313abeb27c7bb7f7bca1a5ac9d91/sbt-crossproject/src/main/scala/sbtcrossproject/CrossType.scala#L62
tl;dr have to explicitly add cross compile options for custom source directories scala-2 and scala-3 when using crossProject

@tpolecat wanted to bump this to fix the "natchez-log artifact empty" issue opened #208

Sorry for the delay on this. I'm not sure what the issue with resolution is. Can you ensure that the sbt-dotty plugin is updated to latest?

Sorry for the delay on this. I'm not sure what the issue with resolution is. Can you ensure that the sbt-dotty plugin is updated to latest?

@tpolecat I will make sure to update the dotty plugin

@tpolecat I will make sure to update the dotty plugin

subsumed by #246

subsumed by #246


runtime cosock?? error in Zigbee Sensor driver

2021-08-31T22:31:44.574557453+00:00 TRACE Zigbee Motion Sensor  Received event with handler zigbee
2021-08-31T22:31:44.595245120+00:00 INFO Zigbee Motion Sensor  <ZigbeeDevice: 25931f2c-e1d6-4a73-9786-2209b583f13a [0x03BD] (Aqara Motion Illuminance Sensor)> received Zigbee message: < ZigbeeMessageRx || type: 0x00, < AddressHeader || src_addr: 0x03BD, src_endpoint: 0x01, dest_addr: 0x0000, dest_endpoint: 0x01, profile: 0x0104, cluster: IlluminanceMeasurement >, lqi: 0x8C, rssi: -65, body_length: 0x0008, < ZCLMessageBody || < ZCLHeader || frame_ctrl: 0x18, seqno: 0x3E, ZCLCommandId: 0x0A >, < ReportAttribute || < AttributeRecord || AttributeId: 0x0000, DataType: Uint16, MeasuredValue: 0x0012 > > > >

2021-08-31T22:31:44.625621787+00:00 FATAL Zigbee Motion Sensor  Lua: runtime error: [string "cosock"]:241: [string "socket"]:64: attempt to call a nil value (field 'warning')
stack traceback:
[string "socket"]:64: in local 'cb'
[string "st.driver"]:741: in function <[string "st.driver"]:700>
stack traceback:
[C]: in function 'error'
[string "cosock"]:241: in field 'run'
[string "st.driver"]:749: in method 'run'
[string "init.lua"]:43: in main chunk

Thanks for opening this issue! I am looking through the code and not seeing any references to a field named warning so far but I am going to keep looking.
Looking at the traceback, it seems like the error might be coming from inside of a callback, would you mind confirming for me that your code doesn't have reference to a property warning?

Thanks again for the report @veonua, there was some confusion at first as the change was on the release branch for the 0.39 beta and not upstreamed internally as of yet.  We are see the problem and the team should have a fix included in the next update to the 0.39 beta.
Thanks for your patience and for reporting this issue and helping us smoke out some of these issues during the beta.

seems to be fixed now


Theming for the VSCode 1.13 release

This PR fixes a couple of issues. Most of the stuff are only supported in the Insiders build so we should probably wait with publishing a new release of the theme until VSCode 1.13 has been released.
These are the new theming colors added in 1.13: https://github.com/Microsoft/vscode/issues/27445
Fixes #12
Active:

Inactive:

Fixes #13

Fixes #14

Fixes #15

Fixes #16

Changed back to use old color for section headers in the sidebar:

Added theming of welcome page and interactive playground now too.

Have you had time to test it @teabyii ?

Here's a package if someone would like to try it with the latest Insiders build of VSCode. https://www.dropbox.com/s/2wao51jp31qh4mo/ayu-0.3.1.vsix?dl=1

VSCode 1.13 has been released now. See https://code.visualstudio.com/updates/v1_13
So it would be awesome if you could have a look at this PR and maybe create a new release of the theme @teabyii :)

Sorry，I am busy recently. I will make it as soon as possible. Thank you very much.

No problem! Here are updated screenshoots for the themes too:

Would be nice to have this out soon @teabyii :)

Thanks! :)


net, e2e: Remove VMI with custom MAC address in non-conventional format

What this PR does
Remove "VirtualMachineInstance with custom MAC address in non-conventional format".
Enhance unit tests to make sure this scenario is covered.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/uncc @AlonaKaplan
/cc @EdDev @ormergi


--system-site-packages should be customizable by virtualenv_create

Provide a detailed description of the proposed feature
https://github.com/Homebrew/brew/pull/11611 specifies --system-site-packages when creating a virtual environment. This makes Azure CLI installed by Homebrew conflict with Ansible collection for Azure installed to system site-packages using pip. (https://github.com/Azure/azure-cli/issues/19027, https://github.com/Homebrew/discussions/discussions/2009).
This makes Homebrew less flexible, even though it fixes https://github.com/Homebrew/brew/issues/1790.
What is the motivation for the feature?
To makes Homebrew more flexible.
How will the feature be relevant to at least 90% of Homebrew users?
No
What alternatives to the feature have been considered?
Let the users create virtual env by themselves when installing with pip.

I had come to the same conclusion after our discussion at Homebrew/discussions#2009. This would be good to have, and should be straightforward to implement.


Refernces to uncovered material in Mix reading

In the reading/mix.livemd macros are referenced frequently without any prior exposure to the concept.
Lessons may require refactoring or reordering.

Thank you for raising this issue. I'll make sure to fix this in my content review.


Fluentd forward Output Plugin: active/standby issue.

Hi!
We'd like to have an Active-Standby log servers pair.
configuration of our forwarder hosts is the following:
...

<match **>
  @type forward

  heartbeat_type tcp
  send_timeout 60s
  recover_wait 10s
  heartbeat_interval 1s
  phi_threshold 16
  hard_timeout 60s

  <server>
    name logs1
    host logs1
    port 8889
    weight 60
  </server>

  <server>
    name logs2
    host logs2
    port 8889
    weight 60
    standby
  </server>

...
</match>

Fluentd documentation says

standby
Marks a node as the standby node for an Active-Standby model between Fluentd nodes. When an active node goes down, the standby node is promoted to an active node. The standby node is not used by the out_forward plugin until then.

That works perfectly. When I switch off logs1 node, Fluentd starts to send  logs to logs2 node. However when I switch logs1 node back on, Fluentd starts to distribute logs among both logs1 and logs2 nodes. It looks like both of them become active. And no standby nodes are present.
Is it a normal behaviour?
Thank you!
Regards,
Sergey

That's weird.
I will check it after finished KubeCon.

I found a bug of heartbeat handling for TCP and send a patch: https://github.com/fluent/fluentd/pull/1784


It makes sense, you want to preserve the temperature on the sides and want to reflect the sun's on top.
So this envelope is wrong:
https://user-images.githubusercontent.com/64334/164951029-c35a8d58-5089-434b-9fed-50f34c978db6.png
What hints I need to double check all envelopes to fix them (the Octo is the rule).
Example of wrong texturing:

Only OMG_Airship (DeathStarBattery) was affected.

Fixed!! It's easy when you finally grasp the thing - but it took me a lot of tries until I get it.

Closed/Fixed


Feedback and support for PermanentlyClearPreviousMailboxInfo switch

The feedback is that I am very interested in a first-party tenant to tenant migration option. The information here is a great resource. My perfect possible future for this article is for it to contain a script that does everything for me aside from authenticate to the endpoints needed to run the script, after I populate a few variables, or as close to that as possible within reason (no need to spend 3h to find a way to do something that can be done in a portal in 30s)
Currently, I'll need to digest all this information and then build a script. Once I have that, I'll share feedback of the working script, unless someone beats me to it. :)
Regarding support for the PermanentlyClearPreviousMailboxInfo switch, I'm not quite sure how critical this is to the overall process. But, according to this issue I opened earlier this year, that switch is not supported by Exchange Online.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c61c960c-f5c3-76f7-ac18-dfeaf30230e4
Version Independent ID: 3dc607b2-869e-976f-80da-d73cfb1210e5
Content: Cross-tenant mailbox migration - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/cross-tenant-mailbox-migration.md
Product: microsoft-365-enterprise
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

I'm not denying that the command does stuff. But it does not work as
intended when working with an online only mailbox.
I created an online mailbox, checked the 3xchange guide, next i removed the
license and ran this command, then readded the license and checked the
exchange guid. It matched the original guid and the mailbox content was
back.
As you noticed the command ran successfully and said no changes were made.
In my scenario it does not say 'no changes were made' and yet the
experience is that the exchange guid does not change.
Feel free to discuss with the owners of the other issue, and I can put you
in touch with the owners of my support ticket who told be it doesn't work
as described.
On Tue, Mar 30, 2021, 12:59 PM Sriraman M S @.***>
wrote:

@jonwbstr https://github.com/jonwbstr Thank you for your feedback. The
switch is available in exchange online. I tested it a few minutes ago.

Delete all existing information about user "test1"?. This operation will
clear existing values from Previous home MDB
and Previous Mailbox GUID of the user. After deletion, reconnecting to the
previous mailbox that existed in the cloud
will not be possible and any content it had will be unrecoverable
PERMANENTLY. Do you want to continue?
[Y] Yes [A] Yes to All [N] No [L] No to All [?] Help (default is "Y"):
WARNING: The command completed successfully but no settings of 'test1'
have been modified.
Thanks
Sri
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/4502#issuecomment-810423877,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXTPAG2VWVQQ26E42WI24TTGH7P5ANCNFSM4ZVN4HIQ
.

@jonwbstr I tested this and the Guid Remains after cleaning the mailbox info. I will work with the author and provide you an update.

@georgiahuggins, Can you help with this issue? Thanks

@jonwbstr  Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Bump SoLoader to 0.8.0

Summary
This PR bumps bumps Soloader to 0.8.0. This fixes white screen/ crash issues when downloading from Google Play.
Related to:
#25927 #26400
Changelog
[Android] [Changed] - Bump Soloader to 0.8.0
Test Plan
A few CI tests fail, but I don't see the link with what I changed, especially the ios tests.
It's working locally though, and for people on github who tried this solution as well.

Tested this in my apps and it did no harm but fixed linked issues.

LGTM, CC @ejanzer

Is that available on some RN released version bad surprise in production for me…

Hi.. I am currently using RN 0.61.4. I am trying to upgrade to latest SoLoader to fix some ANR is loadLibrary. Then I saw an upgrade to SoLoader was reverted for 0.61.4. Any reason as to why this was reverted?

Hi.. I am currently using RN 0.61.4. I am trying to upgrade to latest SoLoader to fix some ANR is loadLibrary. Then I saw an upgrade to SoLoader was reverted for 0.61.4. Any reason as to why this was reverted?


Generated CSS works once, then subsequently fails

Disclaimer: I'm new to this theme.
It's working well so far except that after the initial gulp command, any further changes to the SCSS cause the theme to break, rendering apparently binary data into the generated main.css. Killing the gulp process and restarting generates a working file.

What version of node are you running on?
Does it do this even with just the default files?

Upgrading Node worked. Thank you!

On Aug 31, 2015, at 7:08 AM, Max G J Panas<EMAIL_ADDRESS>wrote:
What version of node are you running on?
Does it do this even with just the default files?
—
Reply to this email directly or view it on GitHub https://github.com/MozaikAgency/wp-theme-bootstrap/issues/12#issuecomment-136381445.

:+1: :smile:

The same thing is happening again now even with node 0.12.7. There's only a "main.scss" in the complied CSS folder. I'm trying to install another site with the theme as well, and running npm install gives me a long list of WARN unmet dependency

Can you try a fresh download of the theme, does it do this even with the default files?

When I try a fresh download of the theme, it throws two WARN optional dep failed, continuing<EMAIL_ADDRESS>then Killed. I did npm rebuild and it gives me this:
><EMAIL_ADDRESS>postinstall /var/www/tyler/coop/wp-content/themes/coop_dev/node_modules/object-fit
>

><EMAIL_ADDRESS>install /var/www/tyler/coop/wp-content/themes/coop_dev/node_modules/gulp-sass/node_modules/node-sass
> node scripts/install.js

module.js:338
    throw err;
          ^
Error: Cannot find module 'mkdirp'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/var/www/tyler/coop/wp-content/themes/coop_dev/node_modules/gulp-sass/node_modules/node-sass/scripts/install.js:6:13)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)

npm ERR! Linux 3.13.0-57-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "rebuild"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: `node scripts/install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node scripts/install.js'.
npm ERR! This is most likely a problem with the node-sass package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node scripts/install.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-sass
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /var/www/tyler/coop/wp-content/themes/coop_dev/npm-debug.log

I can send you the file referenced at the end if you'd like.

We couldn't replicate your issue on our machines.
It may be any number of things, in the error msg, it says:

npm ERR! This is most likely a problem with the node-sass package

So you can maybe try posting the issue there as well.
Probably what would work in your case is to npm install all the modules that didn't for some reason get automatically installed. Like it says in the error message:

Error: Cannot find module 'mkdirp'

So if you npm install mkdirp it should fix this specific error. If it throws a new error for another missing module, follow the same steps until it works.

This happens intermittently but I'm chalking it up to the server configuration. It doesn't happen when I run everything locally on my Mac. On some remote servers it still happens but it's not greatly inconvenient at this point.


init containers

Init containers are not part of PodSpec, we should consider supporting them.
Istio makes an extensive use of this feature.

Istio makes an extensive use of this feature.

Istio uses initializers now, so this may be less relevant, but this is a general feature we probably might like to support in the future anyway.

I've recently bump into this. For example a init container is used to run migrations and another one to copy the application code (php) into a shared volume for nginx to pic it up.

Needs https://github.com/squaremo/kubeyaml/issues/1

Note how the YAML processing is done by https://github.com/squaremo/kubeyaml/, and there is an appropriate issue opened there already: https://github.com/squaremo/kubeyaml/issues/1

This got resolved by #1258.


Document how long deprecated methods should be kept

          Btw @alamb we should have a policy for `deprecated` modules, how long we keep them, the similar as we do for MSRV

Originally posted by @comphead in https://github.com/apache/datafusion/issues/13056#issuecomment-2430233472

2 or 3 might be too short? Reg to https://crates.io/crates/datafusion/versions
DF gets released every month sometimes longer, changing API can be challenging. WDYT about 6 months or 6 major versions whichever is lower?

2 or 3 might be too short? Reg to https://crates.io/crates/datafusion/versions DF gets released every month sometimes longer, changing API can be challenging. WDYT about 6 months or 6 major versions whichever is lower?

Sounds like a good place to start with me


Benchmarking: QC on data before entering database or inside as a temporary table

Do Quality Control in outside of formal database (like in memory) or inside of it?
Which is better from a performance point of view. We can run some testing to see which we should use.

We decided to start the web app from scratch after the major design/architecture decisions and changes we made. No longer relevant.


specify zip pattern instead of zip length in config

Maltese config:
{   "BASE_URL": "coronastatusmt.com",   "LANGUAGE": "en-MT",   "LOCALE": "en-MT",   "COUNTRY_CODE": "mt",   "COUNTRY": "Malta",   "MAP_CENTER": "14.3582, 35.9401",   "MAP_ZOOM": 10,   "MAP_MAX_ZOOM": 14,   "TWITTER": "coronastatusMT",   "ZIP_PATTERN": "[A-Za-z]{2,3}",   "ZIP_PLACEHOLDER": "Example: VLT (no numbers)",   "ZIP_GUIDE": true,   "REDIRECT_TO_GOVERNMENT": false,   "PASSCODE_LENGTH": 3,   "DB_PATH": "./covid_db" }
It's probably best if you double check my regex ;)

{ "BASE_URL": "coronastatusmt.com", "LANGUAGE": "en-MT", "LOCALE": "en-MT", "COUNTRY_CODE": "mt", "COUNTRY": "Malta", "MAP_CENTER": "14.3582, 35.9401", "MAP_ZOOM": 10, "MAP_MAX_ZOOM": 14, "TWITTER": "coronastatusMT", "ZIP_PATTERN": "[A-Za-z]{2,3}", "ZIP_PLACEHOLDER": "Example: VLT (no numbers)", "ZIP_GUIDE": true, "REDIRECT_TO_GOVERNMENT": false, "PASSCODE_LENGTH": 3, "DB_PATH": "./covid_db" }

Thanks, looks good! So zip code can only be letters?

Thanks, looks good! So zip code can only be letters?

Yes, at least the ones that were provided from the service you linked to. In reality they are three letters (for the locality), then four digits. But due to the small size of Malta, if you include the full post code I think you in many cases could identify the individual houses, which wouldn't preserve the privacy of the users.
So yes, for our purposes I think it makes sense to only use the three initial letters (which match what was provided).


Changing price on existing activity

When changing a price on an existing activity the members already enrolled still get charged the old price. This is due to the fact the price is directly saved on your personal tab. When changing the amount on the activity it does not change the already saved price on the personal tabs.j

Related: #314 and #56


Delete user access

This PR adds a user lifecycle to properly clean up cluster, global, and
project role bindings after a user is deleted from rancher.  This is to
prevent a user from still having access to a k8s cluster after
they have been deleted.
It also adds retry logic to user_store so that the system will retry
creating a user if it fails due to the user lifecycle updating the user
with annotations after it is created.
Also fixed a bug where the admin user would fail to be created on
cluster startup.
Issue:
#11378
Depends on:
https://github.com/rancher/norman/pull/113

LGTM