Initial build 2.7.12

Jira: https://anaconda.atlassian.net/browse/PKG-2047
Upstream: https://github.com/fastai/fastai
❄ Uploading to Snowflake channel.

Python 3.11, ppc, and s390x are unsupported by torchvision, skipping those archs.
Small adjustments to dependency pinnings to match upstream.
packaging is included in run dependencies upstream.

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:17: pip_install_args: pip install should be run with --no-deps and --no-build-isolation.
ERROR: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:23: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:26: python_build_tool_in_run: The python build tool pip is in run depends
WARNING: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool packaging is in run depends
ERROR: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:54: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:54: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:54: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_155ydajps8/clone/recipe/meta.yaml:54: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_3ah59vmztc/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool packaging is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_a6jlg8x2me/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool packaging is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_43m8n3oybj/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool packaging is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_90_npzu222/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool packaging is in run depends
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_459oeutz4g/clone/recipe/meta.yaml:27: python_build_tool_in_run: The python build tool packaging is in run depends
Warnings were found


Grave not generated for player

Describe the bug
Basiccally the grave doesn't generate, not even registered in the grave restore menu yet we can see they died and they have a waypoint in their xaero map as well.
To Reproduce
I haven't found a specific step to reproduce yet, the player had many graves work fine beforehand and after.
Expected behavior
I would expect the grave to generate, if no physical grave can generate
Desktop (please complete the following information):

OS: Linux (Server)
Minecraft Version: 1.18.2
Version: 1.3.5

Additional context
The only thing I noted is that these deaths were in a structure (a shipwreck) and at somewhat high coordinates (3000x, -1800z, for eg). Although I tried dying many times in that area and wasn't able to trigger the same issue.
Screenshots

I think this is related to #47. Here I would prefer as much information as possible. What items the player was wearing, dimension they died in (I'm guessing overworld in this case), mods present, server logs, yigd_grave_data.dat file, configs, cause of death, and so on. If you can't send all this data that's fine, but the more information I get the easier it will be for me to reproduce this, and fix it. Perhaps understand why or where the issue comes from.


THRIFT-4592: [JS] change readI32 to use Array.reverse/Array.pop vs Array.shift

THRIFT-4592: [JS] change readI32 to use Array.reverse/Array.pop vs Array.shift, which is expensive for big arrays in V8
https://issues.apache.org/jira/browse/THRIFT-4592
readI32 ( https://github.com/apache/thrift/blob/master/lib/js/src/thrift.js#L1311-L1341 ) performance is extremely poor in Chrome when reading values from large arrays. This is due to the use of Array.shift ( https://github.com/apache/thrift/blob/master/lib/js/src/thrift.js#L1322 ) which seems to have performance issues in V8/Chrome.
As Chrome is a high market share browser I propose either changing this to use reverse/pop or detect the appropriate strategy given array length. I think this is due to how V8 handles large arrays and the heuristics used to determine whether data should be stored in a C-backed array or hash map.

@jeking3 thank you! appreciate it.


feat(protocol): incorporate L1 base fees into L2 fee structure

This PR proposes incorporating L1 base fees on top of the native L2 EIP-1559 base fee. The key challenge addressed is handling L1 base fees in the context of preconfirmation, where real-time access to L1 fees in the protocol is not feasible due to multiple L2 blocks being built for later submission.
To solve this, I implemented a caching mechanism for L1 base fees. This ensures that regardless of the anchoring block chosen by the proposer, the L1 base fees used in L2 blocks remain consistent and manipulation-resistant.
The change aims to create a more holistic fee structure reflecting both L1 and L2 costs. However, if the current epoch has very high base fees and the next epoch has lower base fees, the current implementation is buggy in that users pay more gas fee to the proposers in the next epoch, not the current epoch. The impact of L1 base fees to L2 base fees are always delayed by 1 epoch.
Optimism's approach (https://docs.optimism.io/stack/transactions/fees) actually breaks our type-1 claim as calldata cost and computational cost are decoupled and they use different gas-price (L1 cost contributes to L2 call data gas price). I'm not against such an approach, but I would argue that we need a lot more changes to go-ethereum and taiko-reth.
@Brechtpd @dantaik @davidtaikocha Please let me know if you have/prefer another approach.

@Brechtpd could you share some feedback/ideas?

No feedback yet because I wanted at least some concrete answer. :)
How fees should be paid is a tricky thing, so hard to find good rules of something the protocol can enforce, because things can quickly change if certain things are optimized.

Proposing cost ~= data publishing costs (which in an efficient rollup would ideally be the biggest part of the cost) would not really be related to the L1 base/blob fee * gas_used, instead it would be blob basefee * bytes used by the transaction. And even the bytes used by the transaction is dependent on how data availability is achieved (how much bytes the tx will actually use after compression, but also higher level tx list vs state delta if this would change). Some normal normal gas would also be used here, but should be very minimal, though because blobs are basically free now it currently could still be the bulk of the cost depending on how blocks are proposed.
Proving cost: gas used here is also not an accurate way to approximate the actual cost (especially for zk proofs where the proving cost/gas is different depending on what the block does) and with proof aggregation the onchain cost calculation also gets complicated quickly.
L2 basefee: measures congestion, so as long as it goes up and down based on how much gas the L2 uses should be fine
L2 tip: within an L2 block, there could still be a tip based gas auction to get included in a block, so how much the tip should be is still hard to predict.
In the future, there may even be a separate preconfirmation tip.

And then on top you have that these costs often need to be predicted in advance, maybe up to 32 L1 blocks in advance in the worst case.
So currently all these costs are part of the tip. And this tip somehow needs to pay for the combination of ~5 independent markets going on for the actual L2 tx cost: L1 gas market, L1 blob market, proving market, L1 tip market, L1/L2 preconfirmation tip market. For sure this already breaks the normal fee market of an L1 tx (but it was already broken because of MEV anyway, so no way back).
Some open questions:

Is gas_used * some L1 basefee a good estimation that solves a problem? Is a single offer from the user not good enough that the proposer can reject/accept? I don't see people still waiting for >12 seconds for their transaction to be included on an L2 and hope for the best that the basefee goes down.
Is it fair to let users pay a higher L2 basefee to the protocol just because the L1 basefee goes up?
What problem are we trying to solve that currently cannot be handled by the tip?
Can the protocol enforce a reasonable cost or should it be done offchain somehow? And if it can enforce it, should it be done on that level?

To me it seems almost impossible to have some protocol enforced mechanism that guarantees "fair" pricing to users/proposers. Maybe you can get a bit closer to it, but seems like a losing battle where truly efficient builders will just have to work around any protocol enforced mechanism. It could very well be that less is more in this case.
This doesn't mean that users have to be fully dependent of the builders now however! For example I really like this recent work of flashbots that will allow users to get a refund for their transaction if it turned out that they paid too much, and the code that decides this is run in a TEE so no need to even trust flashbots to do this, and the code is open source so people know what they will be getting: https://x.com/SheaKetsdever/status/1810680518360314190
As an L2, we could even enforce builders to build blocks like this (though perhaps that is too limiting to builders). And this code could be used to 100% accurately price the actual cost of a tx to ensure fairness. The only slight improvement needed on the L2 side is to have a separate field for actual tip used, so we don't have to always do max tip payment and then allow users to withdraw their refunds, but that's only a small improvements because tip estimation could also run in a TEE.
So this is a well of text, sorry. But my current conclusion: The current fee payment mechanism we have on L2 right now might be close to optimal on the protocol level exactly because it does not enforce anything it does not need to enforce. It just needs to be used well offchain in some way where we have all the data available to accurately calculate costs.


C wishlist: attribute((noreturn))

Seen under Infer 0.2.0 on Ubuntu 14.10 x86_64.
I'm working with code that has its own error handling (e.g. implements its own assert()), and I see a fair number of cases where something like 'assert(p != NULL)' doesn't stop Infer from complaining about a later dereference of p.   E.g.:
#include <stdlib.h>

extern void error_path() __attribute__((noreturn));

void f(void)
{
    int *p = malloc(sizeof *p);

    if (!p)
        error_path();

    /* This is reported as a NULL_DEREFERENCE,
     * although we can't reach here with p == NULL. */
    p[0] = 1;

    free(p);
}

It would be nice to have this Just Work[tm]. :)

When I check CRuby with infer, there's some false-positive NULL_DEREFERENCE because infer doesn't understand noreturn attribute.

Were there any updates on this issue? Seems stuck for many ears already.


transaction commit error

error info:
Could not dispatch event: io.shardingsphere.core.transaction.listener.TransactionListener@15ee8861 to public void io.shardingsphere.core.transaction.listener.TransactionListener.listen(io.shardingsphere.core.transaction.event.TransactionEvent) throws java.sql.SQLException
use 3.0.0.M2  version , transaction commit error
use 3.0.0.M1 version, normal transaction commit

transaction feature is for 3.1.0, in 3.0.0 is not stable, we have already remove it.


Ablation Study on Tank and Temple datasets

Hi，
thanks for your great work! i have some questions about applying this work on some large scale datasets.
1.In your paper you did ablation study on LLFF datasets about IE OD PRD, did you do the ablation study on Tank and Temple dataset ?
2.Is it feasible to apply this work on some large scale datasets without initial poses by colmap?
3.In BARF: Bundle-Adjusting Neural Radiance Fields  paper, they mention that it's hard to optimize nerf  and poses because of the position encoding, in your experienments, do you think it is necessary to change the position encoding function as BARF said ?
@chrischoy @minsucho @soskek @joonahn
Looking forward to your reply!

Oh, Hi. I'm the first author of this paper.

We have not done ablation studies on TNT.
Hmm.. we cannot guarantee whether our method works fine on various conditions.
Our concurrent work, NeRF--, also has shown successful performance on similar conditions. So my answer is "it depends."

Please reopen the issue whenever you have more questions. Thanks :)


Moved on from lazy shared HttpClient initialization using a null check to using an enum in HttpClientProvider implementations

Fixes: #39766.
Also updated tests.

/azp run java - clientcore - ci

API change check
API changes are not detected in this pull request.


Update pstn-usage-report.md

Export to excel changed to COMMA delimited file, so removed TAB delimiter statements.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@tonysmit
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


URL Categories Feature Implementation

Expected Behavior:
Users should be able to create and assign categories to their shortened URLs. The categories should be displayed in the user's profile, and URLs can be filtered based on these categories.
Tasks:

Design the user interface for creating and managing URL categories.
Implement the backend logic to associate URLs with categories.
Add filtering options to view URLs by category.

Hey! @DhananjayThomble can you assign to me


after the creation of the second Layer the “drop-down” Parent menu it is no more updated; it is necessary to refresh the page.

The Parent dropbox next to the Name editbox on the left panel.When the platform refresh the list of layers, it does not refresh the dropbox list content
When the user deletes a layer, this list is refreshed.
The problem appears when the user creates 2 layers consequently. For example:

create layer
create layer
delete layer
create layer
Works
create layer
create layer
create layer
Fails, the 3rd layer does not appear in the list


Default icon is displayed when icon tag is empty

I found a bug when I loaded a KML file containing the following
<IconStyle> <Icon></Icon>     </IconStyle>
No icon is specified, and if I import that KML into Google Earth, the placemark icon is not shown.  However, when I import the KML into an app using Cesium, a yellow placemark icon is shown.

Thanks for reporting this @josh-bernstein!

@hpinkos My pleasure!  I have a branch with a fix that I would like to push up, but I'm having GitHub difficultiies atm

Great, thanks @josh-bernstein!  We're always happy to review pull requests.  We have some details for opening a pull request in our contributing documentation here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#opening-a-pull-request
Hope you're able to figure out your GitHub issues without too much trouble.  I'm not sure if this would help, but we have instructions for getting started and building the code base here: https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/BuildGuide#build-guide


REMOTE Request Duplicated. Discard! for step 1 type 176 peer.

@herlesupreeth Greetings comrade! Have you ever encountered a connection failure after the fourth call in VoLTE? In my opinion, SGW-U loses the tunnel bearer from UPF FID key to ENB. I use a configuration identical to this branch and I can't debug for a month. I will be grateful for your advice.

Hey @zikkuratti if you could send me a wireshark trace for that scenario I can take a look

look at that, install  UMLet i make an lil card of main lines of processes ( also im confused why requests all go double from to dest u got same?
4Git.zip


CAMEL-12462

See ticket: https://issues.apache.org/jira/browse/CAMEL-12462
Anyone is welcome to take a peak and provide feedback. This PR can be squashed and merged when its done.
We can do this kind of optimisation for other components as well, for example JMS with the CamelJmsDestination header for the JMS queue/topic. However JMS uses a connection pool so its fairly optimised as well, but it would still use a new producer per different queue/topic.

Nice. I really like this feature.
How difficult would it be to also make camel-jetty support this optimization ?

The camel-jetty producer is deprecated (not the jetty consumer) - so consider switching to another component for http. But I do think its possible to add support for it, let me take a look.

Ohh I missed that. No need for adding support for it then, I just switch to another http component.

Okay added support for jetty as well, as it was easy. Updated the toD docs a bit more about cache size is not your solution, and added a solution with static to.


Run broker reconciler when spec is changed.

Fix for #1018

/retest

This PR needs to be rebased in order for the tests to run correctly, see #1023 for more info!

Thanks for the rebase pointer. At least we can confirm that the retest command works!

This is LGTM to me.

LGTM

@MHBauer PTAL

added "in-progress" label since there are some outstanding questions and I'm not sure if they're supposed to be addressed before merging or not.

kubernetes.io seems to be down right now, which is causing travis to fail. will kick it on monday.


crash server

Could not load plugin '/home/container/plugins/PiggyCustomEnchantsShop_dev-74.phar': Invalid plugin manifest: Invalid Plugin "permissions": Nested permission declarations are no longer supported. Declare each permission separately.

Same error


Remove customise a node tutorial

Remove the tutorial, fix a formatting issue. New recommendations on node customisation will be given by #111
Fixes #113
Discussion

I'm not going to remove the code of the examples in case it is potentially useful. I don't know if we want to add like an 'archived tutorials' folder that we can say 'these still work but are not best practice' in case people think there is something useful in them?

@dalonsoa any idea what's causing the tests to fail? this seems to be across multiple repos that this has started happening (and if I rerun old tests that were passing they now fail). I fixed it on another repo with below, but that's just chatgpt whatever, I don't actually know what is happening.

Yep. pre-commit action is failing everywhere due to recent updates to "something". Unclear what. The maintainer is pretty rude, so we are all pretty pissed.
In any case, being this repo public, you don't need to use pre-commit action. Just delete that action altogether and I'll setup pre-commit.ci, as we did with SWMManywhere.

I've just done it myself. It should all work, now, and run pre-commit via pre-commit.ci.

Sorry, I missed that part of the description. I'd personally ditch the file altogether. If it is not best practice, we should not even show how it is done. But up to you.
If you do so, put them in an archive subfolder and, within, a README.md file explaining this.


[0.66.1] Fetch doesn't return or throw an error

Description
The fetch() method simply doesn't go through. The await method will wait forever (or just super long).
Version
0.66.1
Output of react-native info
System:
OS: macOS 11.6
CPU: (24) x64 Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
Memory: 68.76 MB / 12.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.4.2 - /usr/local/bin/node
Yarn: Not Found
npm: 8.1.0 - /usr/local/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 15.0, DriverKit 20.4, macOS 11.3, tvOS 15.0, watchOS 8.0
Android SDK:
API Levels: 29, 30
Build Tools: 29.0.2, 30.0.2, 30.0.3, 31.0.0, 31.0.0
System Images: android-30 | Google APIs Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7678000
Xcode: 13.0/13A233 - /usr/bin/xcodebuild
Languages:
Java: 11.0.10 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.66.1 => 0.66.1
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Mobx is used in the project and the presenter is fetching a remote json file which is accessible. The fetch() method is defined but somehow, nothing is returned from it so the view is never updated. I tried adding console.log() around it but the line under it is never called. Strangely, it worked in another environment but after reinstalling everything and it doesn't work again. However, it never worked on this environment.
The remote url is https so I don't think it is related to the usesCleartextTraffic. This issue occurs on both Android and iOS.
Snack, code example, screenshot, or link to a repository
const res = await fetch('https://google.com');
const text = await res.text();

The same thing happens with me. I installed version 0.55 and networking started working, but apparently due to a mismatch in dependency versions, I was getting the error Malformed calls from JS: field sizes are different
Is there any solution to this problem?

The problem is only with ios, with android all requests are successful

@HenryQuan @Harshpinder-singh Hi. Were you able to fix the problem?

@Movsar-Khalakhoev I fixed the issue by using XMLHttpRequest but it is temporary. See what @Harshpinder-singh did.

I wasted 1 day trying all solutions to fix this issue, if I set "inlineRequires": false, in metro config, fetch started working, WTF, now I don't know if I should keep that false or look for some other solution.

Using inlineRequires: false didn't make any difference for me. I see that this is a long running issue that has never been explained or entirely fixed.
https://github.com/facebook/react-native/issues/21862
https://github.com/facebook/react-native/issues/20405
I'm suffering it now. My conjecture is a config that is automatically generated has two different competing library versions causing a conflict. This problem seemingly emerged out of no where, where a build one day works, the builds the next day break. I'm experiencing this issue in both Android and iOS and suspect the errant config is in react-native files, not ./ios or ./android

after taking apart the whatwg-fetch repo that react-native uses, I've been trying out XMLHttpRequest and can see that is not working as well, which leads to Fetch failing. XMLHttpRequest never calls 'onload' or 'onreadystatechange' even after a server has responded.

This is affecting us as well. We upgraded from 0.63.2 to 0.66.3 and now any fetch doesn't work. From what we see new repo works fine.


ERROR: cannot launch node of type [msf_updates/pose_sensor]: msf_updates

ERROR: cannot launch node of type [msf_updates/pose_sensor]: msf_updates

I git cloned this repo https://github.com/ethz-asl/ethzasl_msf.git for noetic and it worked. But first I couldn't do catkin_make and ı made a quick search and I find that I should clone 2 repo with this repo for to do catkin_make.
All the git clones to catkin_ws/src:
git clone https://github.com/ethz-asl/glog_catkin.git
git clone https://github.com/catkin/catkin_simple.git
git clone https://github.com/ethz-asl/ethzasl_msf.git


0.7.4 to pypi

The latest version of pygrok is not on pypi.  I would be nice if it was up there so we dont have to install it via the github link.

Thank you for you feedback @nickmaccarthy , I will upload the latest version on pypi this week.

@nickmaccarthy pygrok 1.0.0 is available in pip now


The commondir option no longer appears to have any effect

There are references to commondir in the docs and in the code, but it doesn't appear to be used at all anymore.

Yes, it appears it should either be removed or renamed (though it does have an impact on potentially breaking source maps per #895 ).


Installer package name

What does this PR?
it can check that in which platform app will be installed
Where should the reviewer start?
it will be check on testing mode
Steps to reproduce
Issue number
fixes #2682
Screenshots/Video

lgtm, @feruzm please verify non store installation redirect link.... https://github.com/ecency/ecency-mobile/releases

Yes, that is correct. Of course if we could detect latest release and depending on platform, download it for user, that would be better experience. But let's keep it simple for now.


Docs: Add Spyogenes multiplot

Add Spyogenes multiplot example to the documentation.
Implement multiplot across all backends.

I moved the spyogenes test data to the Release Assests under v0.1.3. Will merge this now.


drivers: intel_gna: Intel GNA Neural Network Accelerator Driver

drivers: intel_gna: Intel GNA Neural Network Accelerator Driver
This PR adds APIs and a driver implementation for the Intel GNA neural network accelerator in Intel S1000 ASIC.

Codecov Report

Merging #11071 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11071   +/-   ##
=======================================
  Coverage   53.22%   53.22%
=======================================
  Files         217      217
  Lines       26733    26733
  Branches     5926     5926
=======================================
  Hits        14228    14228
  Misses      10086    10086
  Partials     2419     2419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdb878...b97e429. Read the comment docs.


translation bugs on Sites page

Search field label & submit button
http://<IP_ADDRESS>:8000/workflow/siteprofile_list/0/0/

This bug is really weird. I've isolated the code ensured the strings are appropriately in the .po file & regenerated the .mo…but it still doesn't work. I blame Crispy forms. I am totally OK deferring this for a later release.

Agreed, let's defer. Those seem minor and we can come back to this.


Developer README: Add valgrind example

Signed-off-by: Till Maas<EMAIL_ADDRESS>

Coverage remained the same at 69.87% when pulling 65c21dbbefc6c7b5606502ace5ed63b374b6906a on tyll:valgrind into 8699c48e80450683bb8d163f73d37a7a6bbd15f2 on nmstate:master.


Update docs content

Related: https://github.com/zeta-chain/docs/issues/358
Refactor Validate docs.

Renamed Validate -> Operate.
Restructured the whole Validate section.
Add readTime and readType to docs.
Replaced ' with ’ for consistency.

ci

Addressed all comments, thanks for reviewing


Planning for 1.0.0a5 features

Discussed in Planning for 1.0.0a5 features

In the next release, the C++ kernel for Jupyter will have these features I planned so far:

Install C++ header from PyPI. That sounds weird, but believe me, once the headers can be installed from PyPI and directly interpreted with the C++ kernel, this helps a lot in implementation into the real application
Minimalize the time of execution of each cell in the C++ kernel
Remove unnecessary pre-installed headers
Secure RegEx on adding user I/O
Important for Windows user: Wide support for Windows still continues, but the help by @Welding-Torch for local GCC! Let's welcome him~

Note that not all new features can be implemented in the next release. They may be looked over, because of many various reasons that I will provide once the new version is published.

Solved in #16


Best Practices

I am trying to set up an experiment that uses ingredients for some of the housekeeping work, specifically I will be fitting a lot of model and I'd like to save their parameters.
Since I will be creating a lot of models I figured that I should factor out the part of the experiment that saves the model for me, and my initial impression was that I can achieve that using post_run_hook.
To accomplish this I wrote a function that accepts a model and outputs an ingredient that provides both model, config of model parameters and lastly hook for saving that model.
from experiments.models import Model
from inspect import signature
from pathlib import Path
from sacred import Ingredient

def create_model_ingredient(model):
    _err = 'You can only build ingredients out of tensorflow.keras.Model subclasses'
    assert type(model) == type and issubclass(model,Model), _err

    ing = Ingredient('model_config')
    ing.add_config({'model':model})

    init_parameters = signature(model.__init__).parameters
    init_config = { k:v for k,v in init_parameters.items() if k != 'self'}
    ing.add_config(init_config)

    @ing.post_run_hook
    def save_model(model, _log, _run, _seed):
        _log.info("Saving Model")

        model = _run.result

        model_output_path = Path(f'artifacts\\{_seed}.h5').resolve()

        model.save_weights(
            filepath=str(model_output_path)
        )

        for file in model_output_path.glob("**/*"):
            if file.is_file():
                _log.info(f"Adding artifact: {str(file)}")
                _run.add_artifact(str(file))

    return ing

This code ALMOST works issue here is that I am getting model into my post hook through _run.result and that does not seem the right way (I am using SQL Observer which tries to save experiment result as a number, throws an error if that's not possible).
Finally my question, how can I save my model after experiment runs without specifying this in each experiment?
UPDATE:
As I'm writing this I figured I can try decorating a class as my @ex.main maybe I can save my model as object property, but this feels like I'm going around a missing feature in sacred, any thoughts?

I would suggest to put the code from your hook into a function, say save_model(model), and call this function at the end of your main. This is not longer than return model, easier to implement and makes much clearer what happens. You can still factor out the configuration to an ingredient and capture the save_model with the ingredient.


implemented second section of landing page

This changes for #62 Implement new landing page second section according to new ui design.
The background color will be changed when the first section is changed.

LGTM! It just needs a few minor edits, thank you so much for taking care of it 🚀

Thank you for your contribution! LGTM too. 3 more section to go for this epic, after that we can merge this pull request!

congratulations and we thank you very much for taking care of this issue 🎉

Thank you so much, if I have more time, I would like to get more issues 😃


Traces - Options to customize trace listeners

Adding options to customize Trace listeners for our traces when running on NET Core environment would be great, and also, to disable all trace listeners (including DefaultTraceListener).
If users want to send traces to a particular sink, in NET Core, today it's extremely complex. When running in NETFX, this can be achieved by web.config/app.config.
It requires some weird hack like:
Type defaultTrace = Type.GetType("Microsoft.Azure.Cosmos.Core.Trace.DefaultTrace,Microsoft.Azure.Cosmos.Direct");
TraceSource traceSource = (TraceSource)defaultTrace.GetProperty("TraceSource").GetValue(null);
traceSource.Switch.Level = SourceLevels.All;
traceSource.Listeners.Clear();
traceSource.Listeners.Add(... my desired listener);

Ideally, we could expose some config APIs like:

CosmosClientOptions.DiagnosticOptions.DisableTraces: It would disable all tracing and any machine wide default trace listeners from the SDK trace source.
CosmosClientOptions.DiagnosticOptions.AttachTraceListeners(IEnumerable<TraceListener>): Would attach the listeners to our trace source programmatically.

For performance reasons, any application that does not want to collect traces can disable them to avoid any lock contention on the default machine-wide tracing.

This is similar to this issue:
https://github.com/Azure/azure-cosmos-dotnet-v3/issues/1224

I think there is confusion. This is not related to CosmosDiagnostics. This is only referring to the DefaultTrace inside the SDK. CosmosDiagnostic levels will need to be handled separately. I think the naming will need to be clear to avoid confusion.

Yes, this has no relationship with Diagnostics in the operations, but rather the SDK usage of DefaultTrace across the code.

I think it needs to be renamed to CosmosClientOptions.TraceOptions to avoid confusion with CosmosDiagnostics.

@ealsur I have a hard time to follow. I cannot find this options with the package Microsoft.Azure.Cosmos version 3.27.0.
Has this been implemented or do we still have to use reflection ?
Also has any implementation with Microsoft.Extensions.Logging.ILoggerFactory and Microsoft.Extensions.Logging.ILogger are planned ? I think this SDK is used a lot in WebServices and it would be great to have a dependency injection compatible SDK.

@RamenTurismo not implemented. The team is working on AI (Application Insights) and Open Telemetry integration, PRs for that are in progress.


jacoco-report-aggregation should allow for exclusions

Expected Behavior
When a subproject specifies a file or pattern to be excluded from the test coverage report (jacocoTestReport), the jacoco-report-aggregation should not include the specified file or pattern in the output html report.
Current Behavior
The jacoco-report-aggregation plugin's output seems to ignore the excluded files that were specified in the subproject's build script.
Example: If I have subprojectA that uses the jacoco plugin and the following in subprojectA/build.gradle.kts...
val coverageExcludes = listOf("somelib/**)
tasks.jacocoTestReport {
    reports {
        html.required.set(true)
        xml.required.set(true)
        csv.required.set(false)
    }
    classDirectories.setFrom(
        classDirectories.files.map {
            fileTree(it).matching {
                exclude(coverageExcludes)
            }
        }
    )
}

... the report that is output to subprojectA/build/reports/jacoco/test/html/ has the classes in somelib/** excluded. They do not appear, which is what I expected. However, when the testCodeCoverageReport task is run (invoking the jacoco-report-aggregation plugin functionality), the somelib/** classes are included in the report. I wish they were excluded!
This plugin's documentation is a little sparse and I have tried to figure out if the allCodeCoverageReportSourceDirectories or allCodeCoverageReportClassDirectories could help, but I cannot figure out how to use those and I don't see any samples or examples anywhere.
Context
The jacoco aggregation report is showing coverage for lots of classes that I don't want to be on my report and so code coverage numbers are way off.
This is especially difficult because I am moving a project from a single project setup to a multi-project setup and team members are wondering why we can't have nice coverage reports anymore.

Have you tried using the extension on the test task to exclude the classes from analysis?
test {
    jacoco {
        excludes = [ "somelib/**" ]
    }
}

We need to update the JaCoCo plugin's docs to show how to do this in an easier way.

I'm having the same issue.
@big-guy , I tried your solution, but it doesn't work

I'm having the same issue.
To "solve" to me i wanted put the exclusion package in all phases, but when I open the report there is the "uncoverage" package.

@big-guy I think that's only a partial solution based on this https://github.com/gradle/gradle/issues/14760#issuecomment-704205886

You only exclude the classes from jacoco but the report still sees the whole classpath and thus assumes there they have no coverage (as the coverage data for those classes is missing). You need to exclude the classes from the report as well.

I don't think approach will work as is because it seems the allCodeCoverageReportClassDirectories configuration actually resolves output JARs from projects and not the actual class directories, so it's not possible to exclude individual class files from classDirectories on the JacocoReport task used to generate the aggregated report.

@3flex Any update on this one? The issue you linked seems to be fixed already

#20432 is fixed but I haven't had the need to try exclusions so I'm not sure if this issue is also fixed.

Hmmm, I see, thanks for the fast reply. Do you happen to know how allCodeCoverageReportClassDirectories is supposed to be used? Can't find 1 single example

I based out project config on this doc and the linked samples: https://docs.gradle.org/current/userguide/jacoco_report_aggregation_plugin.html
For a real example: https://github.com/detekt/detekt/blob/main/code-coverage-report/build.gradle.kts
Everything from line 47 onwards can be removed when Gradle 7.6 is out, which includes the fix for #20432.

Workaround that I found for now is
testCodeCoverageReport {
	getClassDirectories().setFrom(files(
		subprojects.collect {it.fileTree(dir: "${it.buildDir}/classes", exclude: excludedCoverage)}
	))
}

Confirm that the workaround posted by @appdirect-kasidit works.
It will include sources from all the modules though, even if the module is not configured as
dependencies {
    jacocoAggregation project('<module name>')
 }

leading to some modules ending up in the final report with 0 code coverage.

Note also that the workaround posted by @appdirect-kasidit works under the assumption that the project that generates the report is the parent project of the projects that are covered by the report.
If that is note the case (e.g. Gradle's example project), the projects can be manually listed:
testCodeCoverageReport {
    getClassDirectories().setFrom(files(
            [project(':application'),
             project(':utilities'),
             project(':list')
            ].collect {
                it.fileTree(dir: "${it.buildDir}/classes", exclude: [
                        'foo/*',
                        'bar/*',
                ])
            }
    ))
}

Hi everyone!
Let's introduce new simple config like this:
tasks.jacocoTestReport {
    exclusions = ["**/my/ignore1", "/generated/**"]
}

and implement exclusion logic in JacocoReport#generate() method. It will allow to exclude files on execution task phase instead of configuration phase, which all necessarily files will be created, such as generated files from wsdl2java plugin and others. I can take it! So, what do you think?

I was able to get this working on the kotlin dsl with the following:
reporting {
	reports {
		val testCodeCoverageReport by creating(JacocoCoverageReport::class) {
			testType.set(TestSuiteType.UNIT_TEST)
			reportTask.get().classDirectories.setFrom(reportTask.get().classDirectories.map {
				fileTree(it).matching {
					exclude(listOf("**/foo/**", "**/bar/**"))
				}
			})
		}
	}
}

By using the reportTask.get().classDirectories.setFrom(reportTask.get().classDirectories you can filter the classes that are in the current report already.

Another workaround to exclude a whole submodule:
(for this sample project)
dependencies {
    jacocoAggregation(project(":application")) {
        exclude(module = "list")
    }
}


License

Hi,
I am interested in integrating Uni-Dock in a docking workflow, but I wanted to check the license to see whether it is compatible with commercial usage. I haven't been able to find the license in the GitHub repo and wanted to check with you what the terms are.
Thanks beforehand!

Hi @RaulFD-creator ,
Uni-Dock is released under LGPL license. Please check the LICENSE file under subdirectory.

Hi @caic99, thank you so much! I hadn't seen it, sorry for the inconvenience.


Runtime errors with the C-API Function: helicsGetPublicationKey()

@phlptp  I am attaching the test-value-federate1.cpp file that I am currently testing as part of the C-API testing task. As I discussed with you on Gitter, when helicsRegisterPublication is called without the type and units (which are specified as "" in the call), helicsGetPublicationKey throws an exception.
test-value-federate1.txt

when you leave off the type, it routes to a generic publication, which just works with raw data through the core. the get PublicationKey function doesn't check that like it should and instead calls the Publication object which doesn't actually exist.
This will be fixed in the C_unit_tests branch later today

Thanks @phlptp

@HimanshuJain17 can you verify this is fixed when you get the chance, and if so close the issue

@phlptp Will work on it today and close the issue if the problem is fixed.

@phlptp The issue is fixed. The value_federate_publication_registration test passes without error. Closing the issue


Testing Jenkins CI process on v0.5-developer-preview - [ do not merge ]

Description

Testing CI process on new branch (v0.5-developer-preview)
Motivation and Context

Fixes #
NA
How Has This Been Tested?

Checklist:

[x] I have added a Signed-off-by
[ x] Either no new documentation is required by this change, OR I added new documentation
[ x] Either no new tests are required by this change, OR I added new tests
[ ] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by<EMAIL_ADDRESS>

reverify jenkins

reverify jenkins

reverify jenkins

reverify jenkins

reverify jenkins

reverify jenkins

Closing this PR..


#10333: Migrate prod_bw to TTNN

Issue : #10333 [ Unary Backward Issue : #9874 , Master issue : #9322 ]
https://github.com/tenstorrent/tt-metal/actions/runs/9956820079 - passed

https://github.com/tenstorrent/tt-metal/actions/runs/9968954613 - passed


Per tensor quantization in smoothquant

Hello community,
I've tried the smoothquant flow on  an OPT-125m model with the default setting. Unsurprisely the activations are quantized per tensor and weighs are per channel. According to the following table from the SmoothQuant paper I see weights can be also quantized per tensor (smoothquant-O3). Is it possible to apply smoothquant by setting the QuantizeConfig or other stuff? I really aim a per_tensor quantization on both activations and weights due to a limitation of my hardware. Thanks!

Hi Chen, thanks for your response.
Currently weights could only be quantized per-channel in INC SmoothQuant. Please refer to SmoothQuant_doc for more details of our implementation.
Thanks!

I see, thanks for your reply!


Add GetContainers function

Add GetContainers to get a list of containers running on the system. This returns all containers including template containers and is needed to fix https://github.com/docker/docker/issues/28087
Signed-off-by: Darren Stahl<EMAIL_ADDRESS>

/cc @jhowardmsft @jstarks

LGTM


Webumenia 1070 visual editor for placing items within topic

just first iteration

with working editor
migrations
events
saving

this can be also kind-of entry point for WEBUMENIA-1101

Ahh, now I see! For show, it does make sense to have it top-level or under téma/.
As for the other routes, I'd probably keep them under admin/topics/... and perhaps even in a separate controller
Ernest Walzel
——
Slovenská národná galéria
Riečna 1, 815 13 Bratislava
Dočasné pracovisko:
Kollárovo nám. 10, 811 07
E<EMAIL_ADDRESS>W sng.sk
webumenia.sk
On Tue, Nov 5, 2019 at 12:44 PM +0100, "Igor Rjabinin"
<EMAIL_ADDRESS>wrote:
@igor-kamil commented on this pull request.
In
routes/web.php:

+Route::get('/{slug}', 'TopicController@show')->name('topic.show');

+Route::get('/{slug}/visual-editor', 'TopicController@visualEditor')->name('topic.editor');
+Route::post('/{slug}/save', 'TopicController@save')->name('topic.save');
First of all - I was really unsure about the router names
and maybe you are right
however - in frontend it will be all in slovak language - and I don't like mixing up slovak and english in urls in frontend (if not neccessary)
but from the domain perspective you are absolutely right.
and what do you think just trye to compare:
https://1989.sng.sk/hranica
https://1989.sng.sk/topics/hranica
https://1989.sng.sk/téma/hranica
what do you think?
@eronisko
@ustengrav
@martin-havala ?
—
You are receiving this because you were mentioned.
Reply to this email directly,
view it on GitHub, or
unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/SlovakNationalGallery/1989.sng.sk/pull/35?email_source=notifications\u0026email_token=AAKPUGJ7VF4JF2UQRRGZ2O3QSFMCNA5CNFSM4JI4EFE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKJ4YUY#discussion_r342518654",
"url": "https://github.com/SlovakNationalGallery/1989.sng.sk/pull/35?email_source=notifications\u0026email_token=AAKPUGJ7VF4JF2UQRRGZ2O3QSFMCNA5CNFSM4JI4EFE2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKJ4YUY#discussion_r342518654",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]


Revise bootstrap_form field hints and double validation message error

Some leftover side effects of adding bootstrap_form to the project from the merge #221 that need addressing.
Tasks

Move hints below labels in  app/views/devise/registrations/edit.html.erb
Also move the hints below the labels in app/views/devise/registrations/new.html.erb
Remove extra asterisk and realign remaining asterisk in app/views/devise/registrations/new.html.erb
Remove extra validation in app/views/organizations/pets/_form.html.erb

I would like to handle this issue.

All yours! @reyes-dev


Support fuzzy search

Search should support finding similar strings instead of doing exact match:

characters could be deleted
characters could be inserted
characters could be swapped

For example: boddelansd should find Borderlands.

That would be nice!   i would love something like this!      Its soooo annoying when a site doesnt support fuzzy search


Consider adding op== to SqlStatement

In #103 we added SqlStatement, but didn't include support for equality. This makes it a "semiregular" type. In general, we should prefer regular to semiregular types whenever possible. See this item from the C++ Core Guidelines.
We probably want to add equality support to SqlStatement, but we need to decide how to handle the case sensitivity of the sql string. Spanner's case sensitivity docs are here. Some options for SqlStatement that I see are:

Do nothing, and do not support equality of SqlStatement. This leaves the class semiregular.

100% case sensitive. That is "select Foo" != "select foo". This is simple to implement in C++ and it's not unexpected behavior (case sensitivity is typical). However, this behavior differs from what Spanner does on the server side.

100% case insensitive. That is "select Foo" == "SeLEcT FoO". This is also easy to implement in C++, but this behavior also differs from what Spanner does on the server side.

Parse the SQL string, and do equality exactly as Spanner does it on the server side. This would be harder to implement in C++, more difficult to keep exactly in sync w/ Spanner on the server side, but it would match what spanner does on the server.

FWIW,  I lean toward option 1. I think the only downside is that the behavior in C++ differs from the behavior on the Spanner servers. I wouldn't expect this to be an actual problem in practice. Additionally, there's precedent in other cases to do things differently in the client library than spanner does on the server. For example, spanner's STRUCT objects on the server ignore field names when doing equality comparisons, whereas our Value class (and the Value class for all the other client libraries) include the field name when doing equality comparison.

Note: the lack of op== for SqlStatement makes the type "semi-regular". Adding op== would make the type "regular", which is generally preferred.
FTR: I think we should proceed with option (1) above and add case sensitive equality.


Selection UI improvements

Continuous highlight, blue selection, round ends, etc - closer to descript UI, our own UI designs, and just closer to something nice to use in general
Out of scope for this: performance of selection/highlight - it's not terrible but could be improved
Also taking Riley's suggestion of using a more standard blue colour for the highlight, so that the orange 'currently playing' marker stands out more, and so that the user is not swamped with yellow.
Feel free to provide feedback on both implementation and looks - will clean up a bit and post screenshots tomorrow

Basic screenshot

Basic screenshot

These improvements make a huge impact on the UI! It looks so good - are we able to include the delete makers in the continuous highlight please? i really like the rounded corners of the highlight blue - can we translate that to the yellow playback aswell. Happy for @rileykeane  and @emmapainter  to add in their UI perspectives here

Do we have the ability to change the on hover blue highlight to rounded corners as well? Just saw the on hover and drag select UI is a bit different - on hover square corners and drag select is round

I thought the delete marker interrupting the highlight looked alright but on second thought it makes more sense to keep it continuous - will do.
Yellow playback I can make rounded but ultimately want to change this to a little playback marker (like a cursor between words or something, similar to how video editors do it) since the UX of the playback marker is a bit meh overall.
On hover highlight with corners makes sense too - will do!
Checklist, will update as I do them:

[ ] Edit marker continuous highlight
[ ] Playback highlight rounded corners
[ ] Hover select rounded corners


[AUTOMATED] Update Version Pinning for Terraform to support 0.13

What

Update Version Pinning for Terraform to support 0.13

Why

This is a relatively minor update that the CloudPosse module already likely supports.
This allows module consumers to not individually update our Terraform module to support Terraform 0.13.

/test all

Seems this project didn't get the actual version pinning update... Not sure how that happened, but I'll do a manual update.

/test all

/test all


Workspace Administration and Tenancy: Prefill APIs

Use Case: Workspace Administration and Tenancy
Objectives:

[x] https://github.com/kcp-dev/kcp/pull/302: An admin can prefill a workspace with a set of APIs that match a type
[ ] A user can be granted workspace access with minimal object/etcd fanout, depending on https://github.com/kcp-dev/kcp/issues/278 without tons of RBAC objects in every workspace (bootstrap policy).
[x] https://github.com/kcp-dev/kcp/pull/302: A workspace can be typed as “organizational” and contain other workspaces.  Initially there will be a single org workspace, admin
[ ] https://github.com/kcp-dev/kcp/pull/302: Lack of workspace in org workspace gates user access, depending on

workspace authz (first authz level), part of https://github.com/kcp-dev/kcp/issues/278, checking the existence of Role+RoleBinding in the org workspace
existence of org workspaces (could be admin for the prototype).

Details

[x] 1. Add a field on Workspace that references a logical cluster to inherit types from, update the API virtualization logic to look there instead of root cluster, merge the default types still
[ ] 2. Add internal machinery for logical cluster abstraction into the serving chain to support “can user access this logical cluster”
[x] 3. /apis decoration with CRDs depending on logical cluster
[x] 4. apiextensions-apiserver logical cluster inheritance

Notes from slack:
I think I have 2 remaining pieces to the API inheritance puzzle:
Undo my SetCRDClient hack
Fix OpenAPI so it includes inherited CRDs
I did find & fix an issue w/OpenAPI not getting updated correctly for all logical clusters - https://github.com/ncdc/kubernetes/commit/a5f6a340084296b2105319a6cd8e15cca3926528

#302 covers details 1, 3, and 4.
I'd recommend we file a separate issue for detail 2. Thoughts?
Also, my PR does not cover "organizational" workspaces - it hard codes the admin logical cluster as the only place that supports API inheritance via Workspaces. If that is sufficient for prototype 2, could we create new issue(s) for fleshing out org workspaces post-prototype 2?
@pweil- @smarterclayton

Also, my PR does not cover "organizational" workspaces - it hard codes the admin logical cluster as the only place that supports API inheritance via Workspaces. If that is sufficient for prototype 2, could we create new issue(s) for fleshing out org workspaces post-prototype 2?

Inheritance only from admin was fine during the last discussion so I think we're good to file a new issue to refine that post-prototype2.
Created https://github.com/kcp-dev/kcp/issues/307, please refine as necessary

I'd recommend we file a separate issue for detail 2. Thoughts?
https://github.com/kcp-dev/kcp/issues/306

Remaining (2) of details and 3rd objective is basically https://github.com/kcp-dev/kcp/issues/278, i.e. @s-urbaniak.

This is done.


Should run Checkstyle on the tests too

The Maven configuration has already been fixed. Now I only have to fix all the violations I just found out about.
Closes #297

Current coverage is 25.69% (diff: 100%)

Merging #298 into master will not change coverage

@@             master       #298   diff @@
==========================================
  Files           174        174
  Lines          4729       4729
  Methods           0          0
  Messages          0          0
  Branches        779        779
==========================================
  Hits           1215       1215
  Misses         3417       3417
  Partials         97         97

Powered by Codecov. Last update a3bf3ee...c300160


Get repo into a maintainable state

There are some tasks we should do to get this project into a more maintainable state:

Do https://github.com/DiamondLightSource/rtc6-fastcs/issues/2 and https://github.com/DiamondLightSource/rtc6-fastcs/issues/10
Get the branch of dodal merged into dodal main (first, specify what needs to be done for this)
Add documentation for: Purpose of the repo; how to develop and release changes; where the IOC is installed
Add unit tests where appropriate, eg  for the python parts

Here's a brief list of the changes needed to get the dodal branch merged:

Create a daq_configuration directory to put the oav parameters in, and use that instead of the OAV.json in dodal

Use as much of the oav_detector.py as possible instead of the custom OAV made in the other branch, as there's lots of repeated code.

Same as above with the Robot

Give the Goniometer device a more specific name based on its functionality. Maybe SixAxesGoniometer or the name of the actual hardware? Consider sharing some of the code that the Smargon uses, to create a base Goniometer class

Confirm that MJPG_URL_RBV is a valid PV for other beamlines which use MJPG.py. Same thing for robot RESET.PROC

Create a beamline module (analogous to i03.py or i04.py where we can instantiate devices from, to use in our plans

I probably missed some stuff but this will do for the time being!


Migrate offline example to vite

Codecov Report

Merging #3959 (d85dc68) into main (eab6e2c) will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3959      +/-   ##
==========================================
+ Coverage   96.36%   96.77%   +0.41%
==========================================
  Files          45       57      +12
  Lines        2281     2666     +385
  Branches      640      782     +142
==========================================
+ Hits         2198     2580     +382
- Misses         80       84       +4
+ Partials        3        2       -1

Impacted Files
Coverage Δ

src/react/useMutation.ts

src/react/QueryClientProvider.tsx

src/core/mutationObserver.ts

src/react/logger.native.ts

src/devtools/styledComponents.ts

src/devtools/utils.ts

src/core/notifyManager.ts

src/react/setBatchUpdatesFn.ts

...rc/createWebStoragePersistor-experimental/index.ts

src/core/queryCache.ts

... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2861b53...d85dc68. Read the comment docs.


Add full response for directions api

Added a feature that allows 'return_type: :all' to be passed into the client.directions method, which returns the full Hash output, rather than just the [:routes] entry
Can change the argument to be 'return_type: :status' if you just want the status, or leave it blank to get the [:routes] value (i.e. the same output as is the case without this change)

Coverage decreased (-0.3%) to 99.73% when pulling a86563b02954803a7aeec97f4d6f810a51a51e16 on jguthrie100:add_full_response_for_directions_api into 46746fd72e90c75855baa88aee04e41c84ff32c9 on edwardsamuel:master.

Coverage decreased (-0.3%) to 99.73% when pulling a86563b02954803a7aeec97f4d6f810a51a51e16 on jguthrie100:add_full_response_for_directions_api into 46746fd72e90c75855baa88aee04e41c84ff32c9 on edwardsamuel:master.


Editable props would be a nice improvement

Hi, thank you for the nice tool!
I noticed that we can't set props from devtools as we can in https://devtools.vuejs.org/ .

Is there any plan to thave the same functionality in devtools-next?

I wonder why v7 was released without this feature, this is an annoying regression.

We've gonna support it soon.


Fix built-in HttpClient metrics documentation

Summary
Right now docs say that the network protocol version for http.client.request.duration metric is always available, which isn't true: https://github.com/dotnet/runtime/blob/55fbb23f8c4e05a17ee27ea19679813f7f5cf285/src/libraries/System.Net.Http/src/System/Net/Http/Metrics/MetricsHandler.cs#L113

Internal previews

📄 File
🔗 Preview link

docs/core/diagnostics/built-in-metrics-system-net.md
System.Net metrics

cc @JamesNK @antonfirsov

@lmolkova we cannot populate network.protocol.version when HttpResponseMessage is missing because of an exception. Can we keep the attribute's Requirement Level Recommended in the spec, or shall we change it to Conditionally Required? https://github.com/open-telemetry/semantic-conventions/blob/main/docs/dotnet/dotnet-http-metrics.md#metric-httpclientconnectionduration

We can keep Recommended level - it implies that instrumentation can have good reasons not to populate it. It also means that observability backends should not expect it to be there.
I'll send a tiny PR to the spec to add a description on the level.

@antonfirsov @xakep139  does this change apply to all client metrics or to http request duration only?

@antonfirsov @xakep139 does this change apply to all client metrics or to http request duration only?

I've found only these usages:

MetricsHandler
ConnectionMetrics
SocketsHttpHandlerMetrics

@antonfirsov can you please check whether last two are available if there's no response?

BTW, any reason to report response version and not a request.Version?
since it's a request duration, it seems reasonable to report request version there, no?

@antonfirsov thanks for the explanation! Do you think otel semconv should be more specific and specify that the actual protocol version after negotiation should be used?

Also, is there any benefit in falling back to request.Version if there was no response? I'm thinking about misconfigured clients/buggy servers/routers that don't respond when protocol is not supported and then you would be interested in request.Version. Super edge-case, but why not use request version as a fallback?

Do you think general otel semconv could be more specific and specify that the actual protocol version after negotiation should be used

This kind of clarification never hurts, but one should look at version management in other libraries/APIs to phrase it correctly.

Also, is there any benefit in falling back to request.Version if there was no response?

IMO this would be misleading. Imagine the following scenario:

A user sets request.Version = 2.0
It falls back to  1.1 during negotiation, and an HTTP/1.1 connection starts serving the request
Something goes wrong in the middle (eg. invalid response) and an exception is thrown
Telemetry would log network.protocol.version=2.0 which was not the actual protocol version used for the failing communication attempt

Folks, I opened this PR to fix the actual documentation and to reflect the current behavior there.
I'm all for improving the logic, but I guess it's better to discuss these discrepancies in the related issue: https://github.com/dotnet/runtime/issues/97395

Apologies for delaying the merge, I wanted to make sure we are on the same page before going ahead.


dummy change to test job selection

/cc noone
/hold DNM

/pj-rehearse refresh

/pj-rehearse refresh


Cannot find a way to create endpoints ?

Currently creating an application which will have a web form on it. This then needs to be submitted into Salesforce Pardot. I would like to do this via AJAX request rather than a normal form submit.
However there is CORS issues with doing this ajax request on the front end.
I cannot seem to figure out , searching through every single nuxt documentation page, where to simply put some backend node.js code which simply runs on the backend rather than the client.
From my Q above  you can gather i need to send the formData to some backend code on the same nuxt server and then do a server axios request to get the data into pardot.
Any ideas or anything i am missing ?

It might be a little outdated, but there is an express example

Hello @manniL  , this seems to be maybe what im after, however it uses another package called backpack, im very reluctant to install more packages to this project But thank you anyway for the response!

https://github.com/nuxt-community/hapi-nuxt is a good starting point


[Integration] colors for indent-blankline

Hello! Is there a way to integrate highlight colors for indent-blankline through g:indent_blankline_char_highlight_list? like an option in the config.

Good idea! I'll add it as an optional setting for the Indent Blankline integration :)

Looking good!

f5e342ac172af93e1d5fc4b480db5be3613046ad resolves this.


/usr/bin/bash: line 167: gcovr: command not found

installing gcovr from spec 'gcovr==6.0'...
⚠  Note: '/root/.local/bin' is not on your PATH environment variable. These
    apps will not be globally accessible until your PATH is updated. Run `pipx
    ensurepath` to automatically add it, or manually modify your PATH in your
    shell's config file (i.e. ~/.bashrc).
done! ✨ 🌟 ✨
  installed package gcovr 6.0, installed using Python 3.10.12
  These apps are now globally available
    - gcovr

see https://gitlab.com/ClausKlein/cmake_template/-/jobs/5032411110#L2349

You should source ~/.cpprc. It should be added to the PATH automatically.

done, but
Successfully installed argcomplete-3.1.1 click-8.1.7 packaging-23.1 pipx-1.2.0 userpath-1.9.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
[command]/usr/bin/python3 -c import sys;print(sys.base_exec_prefix);
/usr
"/root/.local/bin" was added to "/root/.cpprc"
/root/.local/bin is already in PATH.
⚠  All pipx binary directories have been added to PATH. If you are sure you
want to proceed, try again with the '--force' flag.
Otherwise pipx is ready to go! ✨ 🌟 ✨
Installing venv  via pip
ERROR: Could not find a version that satisfies the requirement venv (from versions: none)
ERROR: No matching distribution found for venv
Installing python3-venv  via apt-get

.setup_cpp: &setup_cpp |
  curl -LJO "https://github.com/aminya/setup-cpp/releases/download/v0.35.2/setup-cpp-x64-linux"
  chmod +x setup-cpp-x64-linux
  echo -e "section_end:"`date +%s`":.setup_cpp\r\e[0Ksection_start:"`date +%s`":hidden_section\r\e[0K setup cpp"
  export PATH="$HOME/.local/bin:$PATH"
  ./setup-cpp-x64-linux --compiler $compiler --cmake true --ninja true  --ccache true \
    --clangtidy true --clangformat true --cppcheck true --gcovr true
  source ~/.cpprc
  echo -e "section_end:"`date +%s`":hidden_section\r\e[0Ksection_start:"`date +%s`":.setup_cpp\r\e[0K"
  clang-tidy --version
  cmake --version
  ninja --version
  gcc --version

but the most problems with v0.35.2 are using github-action:
https://github.com/cpp-best-practices/cmake_template/actions/runs/6102132450
      - name: Setup Cpp
        uses: aminya/setup-cpp@v1
        with:
          compiler: ${{ matrix.compiler }}
          vcvarsall: ${{ contains(matrix.os, 'windows' )}}

          cmake: true
          ninja: true
          vcpkg: false
          ccache: true
          clangtidy: ${{ env.CLANG_TIDY_VERSION }}

          cppcheck: true

          gcovr: true
          opencppcoverage: true

Could you try with the new version? @ClausKlein

Could you try with the new version? @ClausKlein

Works fine on gitlib-ci:
Installing collected packages: ninja, cmake, MarkupSafe, lxml, jinja2, gcovr
Successfully installed MarkupSafe-2.1.3 cmake-<IP_ADDRESS> gcovr-6.0 jinja2-3.1.2 lxml-4.9.3 ninja-1.11.1
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
cmake version 3.27.4
CMake suite maintained and supported by Kitware (kitware.com/cmake).
1.11.1.git.kitware.jobserver-1
/usr/local/bin/gcovr
gcovr 6.0
Copyright (c) 2013-2023 the gcovr authors
Copyright (c) 2013 Sandia Corporation.
Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,
the U.S. Government retains certain rights in this software.


cooking: add vendor plugin

Coverage decreased (-0.2%) to 94.556% when pulling 4f480ccc88096f93b363950faf0d8ebcec3b178e on feat/vendor-chunk into 1dbcfe6fcea7283e5013d68b667d2e0db5ba8dda on master.


appgyver logo on iOS ad hoc installation

have been away for a while and trying to recreate an old build using the 4.0.0 client. in iOS settings, i have uploaded new custom images everywhere they exist but it seems like something is missing. neither of the following happened with my previous build of the same code using 3.5.3-rc3:

testflight displays the appgyver icon instead of the app icon
while installing an ad hoc build, the appgyver icon is displayed but once the installation is finished, it is replaced by the app icon

any ideas?

nothing? just tried a build with 4.0.3-edge3 and the issues is still there. i have provided a list of icons in the ipa, can someone at least confirm whether the list is complete?

The list of icons you provided is correct. There are no other icons.
Is the problem you're facing: "The app icon is not being displayed until install has finished. " ?
When you install from Testflight, you will see the correct app icon once the installation is completed. The placeholder icon comes either from iOS or Testflight, it is not submitted by AppGyver. However, this is expected behaviour and not a bug.
I'm still having hard times trying to understand what is the problem here. If you could post a screenshot or visualise it somehow, I could probably understand. If the issue is something else than what I wrote above, I'm confused.

I think the confusion is simply about what is expected and what is a bug but screen shot attached. I suspect it is the same as the issue you refer to. Testflight is being positioned as the main iOS testing platform by Apple and expected behavior is for Steroids apps to be missing an asset it needs? As I mentioned earlier, 3.5.3-rc3 and below displays the correct icon (see custom 3.1.6 scanner icon in the screenshot), 4.0.0 displays the Appgyver icon and anything newer seems to be simply missing whatever icon it is looking for so i would say this is a case of Steroids going backwards. Is there any confirmation that the missing asset won't get in the way of a store submission?

exact same problem using diawi for testing as well.

That is not an AppGyver logo, but a TestFlight logo.
Now when you posted this screenshot I finally understood your issue. When we introduced support for iPhone6 and iPhone6+ assets, we removed all the deprecated iOS6 icons. It seems that TestFlight is using one of those for the app icon, therefore, the custom icon does not exist and a TestFlight placeholder icon is displayed instead.
This is an issue with TestFlight. While we could return the deprecated icons, I think we're not going to do that, instead we'll wait for TestFlight to stop using the deprecated icon sizes. This will probably happen with TestFlight2 which is currently in beta -- have you tried that?
BOTTOM LINE:
This is a TestFlight placeholder icon. It will NOT be displayed when your application is installed from the Apple App Store.

"exact same problem using diawi for testing as well."
"4.0.0 displays the Appgyver icon and anything newer seems to be simply missing whatever icon it is looking for" - screenshot displays what newer versions do.
bit pointless reporting problems if no-one can be bothered even reading the comments properly. thanks for confirming it was a smart move to dump steroids.

@osusoy I'm sorry for the disappointment. I just want to let you know that it was unclear for me what the problem was. If you read the problem description now again, you can see that it also lead into wrong direction.
More time wasn't spent investigating this problem, because the wrong icon was visible only to TestFlight users and did not / will not affect installations from Apple App Store. The problem will solve itself when the new Apple-branded TestFlight will launch -- the current TestFlight service seem to have ceased development in favor of the new platform and therefore this kind of issues pop up.
Sorry to hear about your Steroids experience.
All the best & have nice spring . :)

We have confirmed that this issue is fixed in the new TestFlight in itunesconnect.apple.com.
The old TestFlight (testflightapp.com) is shutting down tomorrow 26th Februrary, so this issue is no longer a problem for anyone.


Android Start Google Sign In failed.

On method onActivityResult of mi MainActivity.java  show this
            } else {                 // Google Sign In failed                 Log.e(TAG, "Google Sign In failed.");

Well finally login , make a new project, after get the sha1 code in Gradle->Android-start->Tasks->singningReports, put the new google-services.json on src folder and uninstall app ..... Run the project! and voilà , happy coding!

@kroikie

finally works.. close thx

👍


KeyInterceptor: Simplify setup

Feature request type
Other
Component name
No response
Is your feature request related to a problem?
Thinking about ways to make it simpler to set up the KeyInterceptor. Will use it more with #8901 so am looking at small ways to make it easier to maintain and stay consistent between components with less chance for subtle bugs due to misconfiguration.
Describe the solution you'd like
Usage Before:
private string _elementId = "switch_" + Guid.NewGuid().ToString().Substring(0, 8);
private IKeyInterceptor? _keyInterceptor;

[Inject]
private IKeyInterceptorFactory KeyInterceptorFactory { get; set; } = null!;

protected override async Task OnAfterRenderAsync(bool firstRender)
{
    if (firstRender)
    {
        _keyInterceptor = KeyInterceptorFactory.Create();

        await _keyInterceptor.Connect(_elementId, new KeyInterceptorOptions
        {
            //EnableLogging = true,
            TargetClass = "mud-switch-base",
            Keys = {
                new KeyOptions { Key="ArrowUp", PreventDown = "key+none" }, // prevent scrolling page, instead increment
                new KeyOptions { Key="ArrowDown", PreventDown = "key+none" }, // prevent scrolling page, instead decrement
                new KeyOptions { Key=" ", PreventDown = "key+none", PreventUp = "key+none" },
            },
        });

        _keyInterceptor.KeyDown += HandleKeyDown;
    }
    await base.OnAfterRenderAsync(firstRender);
}

protected override void Dispose(bool disposing)
{
    base.Dispose(disposing);

    if (disposing)
    {
        if (_keyInterceptor != null)
        {
            _keyInterceptor.KeyDown -= HandleKeyDown;
            if (IsJSRuntimeAvailable)
            {
                _keyInterceptor.Dispose();
            }
        }
    }
}

Usage After (first draft):
private string _elementId = "switch_" + Guid.NewGuid().ToString().Substring(0, 8);
private IKeyInterceptor? _keyInterceptor;

[Inject]
private IKeyInterceptorFactory KeyInterceptorFactory { get; set; } = null!;

protected override async Task OnAfterRenderAsync(bool firstRender)
{
    if (firstRender)
    {
        _keyInterceptor = await KeyInterceptorFactory.Connect(
            "mud-switch-base",
            //enableLogging: true,
            new("ArrowUp", preventDown: "key+none"),
            new("ArrowDown", preventDown: "key+none"),
            new(" ", preventDown: "key+none", preventUp: "key+none")
        );

        _keyInterceptor.KeyDown += HandleKeyDown;
    }
    await base.OnAfterRenderAsync(firstRender);
}

protected override void Dispose(bool disposing)
{
    base.Dispose(disposing);

    if (disposing)
    {
        if (_keyInterceptor is not null)
        {
            _keyInterceptor.KeyDown -= HandleKeyDown;
            _keyInterceptor.Dispose(); // IsJSRuntimeAvailable is implied?
        }
    }
}

Just the difference in creation (first draft):
-_keyInterceptor = KeyInterceptorFactory.Create();
-await _keyInterceptor.Connect(_elementId, new KeyInterceptorOptions
-{
-    //EnableLogging = true,
-    TargetClass = "mud-switch-base",
-    Keys = {
-        new KeyOptions { Key="ArrowUp", PreventDown = "key+none" }, // prevent scrolling page, instead increment
-        new KeyOptions { Key="ArrowDown", PreventDown = "key+none" }, // prevent scrolling page, instead decrement
-        new KeyOptions { Key=" ", PreventDown = "key+none", PreventUp = "key+none" },
-    },
-});

+_keyInterceptor = await KeyInterceptorFactory.Connect(
+    "mud-switch-base",
+    //enableLogging: true,
+    new("ArrowUp", preventDown: "key+none"),
+    new("ArrowDown", preventDown: "key+none"),
+    new(" ", preventDown: "key+none", preventUp: "key+none")
+);

Eliminates KeyInterceptorOptions which is used homogenously so shouldn't be a problem.
Eliminates the elementID field so there is one less piece of setup to keep track of
Less pieces overall
Keys array is turned into params.

Could also

turn  _keyInterceptor.KeyDown += HandleKeyDown; into a callback parameter.
create _elementId from KeyInterceptorFactory.Connect via a tuple

Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

My idea was to completely rewrite it, make it scoped service and use ObserverManager, and to subscribe you a callback either an Action or Func(to support Task and non task callbacks) overload, just like BrowserViewportService does. The elemendId is the unique subscription identificator. I have even done it, but just being lazy with the tests.

My idea was to completely rewrite it, make it a scoped service to throw the factory and use ObserverManager, and the subscribe would have a callback either an Action or Func(to support Task and non task callbacks) overload, just like BrowserViewportService does. The elemendId is the unique subscription identificator. I have even done it, but just being lazy with the tests.

@ScarletKuro Please let me know if I can help finish it so I can use it in more components

Crated a draft https://github.com/MudBlazor/MudBlazor/pull/9003
Idk if we want this in v7 or v8, but I just wanted to show how I see the API should be done

Idk if we want this in v7 or v8

If it isn't breaking we can do it anytime after v7 has stabilized.

If it isn't breaking we can do it anytime after v7 has stabilized.

I planned to keep the old service aka just mark it as obsolete.
It's better to keep old services for a while until you are completely sure the news ones are mature and has not bugs, just like with the PopoverSerivce and BrowserViewportService.

FWIW I want to implement keyboard handling in several controls so I would be glad to use it in v7


balsamina, amanda

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 5
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[a,b]

/trunk merge


Single nucleotides are not clickable when located under a highlighted region

When I try to click the 'G' I am not able to.
When I move the track to the side and the G is no longer under the grey area, I can click it.
Not clickable

Clickable

I have the same problem for a month now. Removing the rules doesn't make a difference.


Twitter bridge - threads in one feed

Is your feature request related to a problem? Please describe.
When someone on Twitter creates a long thread, the Twitter bridge then gets very cluttered.
Describe the solution you'd like
Twitter bridge option:
"Put the entire thread in one feed item".
or
"Show only the first post from the thread and add a link to expand the thread"
Describe alternatives you've considered
There is no solution to this. You have to scroll, scroll, scroll....
Additional context
Add any other context or screenshots about the feature request here.

What is thread in Twitter?

What is thread in Twitter?

@em92 E.g. this:
https://twitter.com/uwteam/status/1484154841769209857
Consists of 16 combined twitts, on one and the same topic.

@lukaszpolowczyk I interpret this as a collapsable <details> element that is closed by default for the rest of the thread.

@dvikan "I interpret this as a collapsable  element that is closed by default for the rest of the thread."
I think that might be the answer.

This sounds fairly complex to implement, and of no value/interest to me personally. Pretty much all my feeds have Replies excluded.
Perhaps if @arnd-s or someone else implements it in TwitterBridge, I can crib their code for TwitterV2Bridge.

Threads are a complex topic.
Theoretical its possible to combine tweets based on conversation_id field. When using V2 API, you can even search all threads, which are related to a conversation (thread).
But there are also practical issues. Threads are sometimes written over a longer time. What happens, when you pull tweets between posts and an additional time after new posts where added ? It's currently not implemented, to remember which posts where already combined in a rss item. Adding a new rss item with only the new posts in this thread is not possible (at the moment)
So, you would have to update the already existing rss item (with a new timestamp), but not all rss news reader will then show it as new/unread


Memory leak and double free problem of TiM240 ROS driver

Can you help with this error?

This ticket belongs to sick_scan. I close the ticket here and reopen it under sick_scan (see https://github.com/SICKAG/sick_scan/issues/157 )