Change Font size in Weather/Clock widgets

Thx for clock Widget.
Would be Great to change Font size of Clock and weather widget.
Is it possible to add created HomeKit scenes as well?

I can't do HomeKit scenes are they are locked away in your Apple iCloud account. I'll look into the font size.

Not urgent at all, but when you get a chance could we be able to get the option to change the date format from MM/DD/YYYY to DD/MM/YYYY? Like I said, not urgent at all :)

It should be taking the date format from your browsers .toLocalDateString() function which here in Australia returns the date in the correct (and logical) DD/MM/YYYY format.
I can add an option to change it though and I'll set the default to DD/MM/YYYY.

Maybe something changed on my last browser update, explains why suddenly it was trying to spell check ‘colour’ to ‘color’ recently :) I will look at how to change it there.

Many date format options now available:

Hi, @oznu
Could you please add the date formats:
DD.MM.YYYY
14 January 2020
Thuesday, 14 January 2020
It's most used in our country.
By the way… i saw localisation of dates in javascript code. Will be good to use it.

@Caribsky - added the new date formats, in @test now. The date localisation is in another open issue.


Gamma Strategies Polygon issue on deployment

I deployed gamma strategies to polygon, but I have run into this error upon deployment.

I'll look into it.

This seems to be failing as the subgraph utilises the price lib which does not have support for polygon at the moment.  In fact it also doesn't support optimism so we should expect that to fail as well.
I have spoken to @this-username-is-taken and i think the decision for now is to wait for enhancements to the price lib.  Should we remove this from the deployment config meanwhile?  This would mean only deploying mainnet and arbitrum for now.

fixed with polygon price lib support


[Proposal] secure image reposirory

I was reading about Docker private repository, and the need for certificates, TLS, etc. Has anyone thought about this much more elegant protocol, SRP:
https://en.m.wikipedia.org/wiki/Secure_Remote_Password_protocol

ping @dmcgowan @endophage perhaps you could have a quick look

Closing as nobody interested :(


Statement handles aren't cleaned up leading to max_prepared_stmt_count exception

rdbi doesn't appear to actually clean up the prepared statements it creates when results are fetched.  It's trivial to get this error when running a process which has to run a lot of independent queries in a long running process.
Error in query - exception:Can't create more than max_prepared_stmt_count statements (current value: 16382).
In dbi, you have select_one (for the extremely common, fetch xxx,yyy where id = xx case) and select_all for the other common case.  RDBI has a more flexible fetch mechanism.  Fine.  However, rdbi never cleans up the prepared statement it creates for every execution!
If you're saying that something as trivial as this in dbi:
rows = db.select_all('select xxxx where ...', xx, yyy)
Must be turned into:
res = db.execute('select xxxx where ...', xx, yyy)
rows = res.fetch(:all)
res.finish
in RDBI then I would argue RDBI has a very serious problem.

Thanks, pbennett.  What version of RDBI?

rdbi (0.9.1)
rdbi-driver-mysql (0.9.2)

"...then I would argue RDBI has a very serious problem."
[or at least in need of other apis that allow easy single and full fetches that don't leak prepared statement handles  :D]


Make services async

The way you coded this you need to specify resources in a file. It would be useful to do http calls to get a dynamic list of servers to ping.

I see this issue was opened 3 years ago... is this actively maintained?

@ericelliott Yes, it is. I guess nobody has issued a PR for this yet... If you do, I will happily review it and merge it.

:+1:

Thanks for raising this issue. This has been Implemented in b8b5bb59c54e5355e6de1e4f499dc60c4e5aeb1e


KOGITO-6427, KOGITO-7372 : Improvements on Generics

Hi @hasys @domhanak can you review this PR? It has the improvements of both tickets for Generics

@kiegroup/gatekeepers hello, this PR is ready for merge. Thank you!

does this need to be backported to kie-wb-common repository too? @inodeman @hasys @domhanak

@mareknovotny Afaik this is related to Kie Tools only so no need to backport


Offline/on prem installation of dependencies

There seems to be a requirement to "download dependencies" when launching it.
Could these be bundled with the vsix or as an additional download?
We aren't able to access internet on our dev boxes so this means we've been unable to get this working because it relies on dep downloads!
Thanks :)

Hello, Unfortunately we do require clients to unblock at least some download locations to install and use live share.
I'll put a note on this scenario though as we are considering how to handle this better.

We’ve made improvements in this area since this issue was filed. Those dependencies have been removed for the VS Code client. We believe this may have improved your experience and are closing this issue. If this issue still persists for you, please reopen the issue and let us know. Thank you.


type 'Future' is not a subtype of type 'Future' in type cast

DeviceApps.isAppInstalled(packageName)

Thanks for the report.
I'm currently working on a fix

Fixed in 2.0.1 :)


Create a timeline

Add a list of all your activities, achievements, work experience.
Add as much info as you can remember.
In case you don’t have working experience tell about your pet-projects or student projects. Don’t be shy :)

Task is now in 'Ready' status, waiting for action.


Breadcrumb documentation is inconsistent

https://docs.sentry.io/platforms/php/enriching-events/breadcrumbs/#manual-breadcrumbs
Passes regular parameters to the Breadcrumb constructor with no documentation of what types or levels are available, in the order "level, type, unknown, unknown"; does not document what the strings are doing; then states that the available "keys" are "type, category, message, level, timestamp, and data" (notice not only the additional 2 elements but also the different ordering), despite there being no keys because there is no array.
https://docs.sentry.io/platforms/php/enriching-events/breadcrumbs/#automatic-breadcrumbs
Mentions what the JS SDK does even though it's about the PHP SDK
Quite frankly I don't know how you expect anyone to use Sentry when your documentation is this awful.

Meanwhile, in complete contrast to what the documentation says, looking at the code (which is the only way to have any idea how to use the SDK) reveals:

public function __construct(string $level, string $type, string $category, ?string $message = null, array $metadata = [])

With a magical, unmentioned "$metadata" (defined in your usual wonderfully informative way as "Additional information about the breadcrumb") (presumably this should be "$data"),


Create a docker image with Java + XSpec

Does someone know how to create a docker image and register with official docker hub?
It would be great to have this as a pre-configured docker image for CI environments like GitLab-CI etc.
If someone knows how to do this, I'm volunteering to test it. It should imho be another repo in xspec org.

I am familiar with Docker and would be very keen to implement this. I have an account on Docker Hub but I think it would be better to register an official account for XSpec. I agree that a different repository within the XSpec organisation would be ideal for this.
I can’t promise when I can start working on this but I am very keen to do it and it would be great you could test it once I’ve got something working.

Awesome! No hurries - just let me know when you need my testing skills ;-)

@tofi86: I created a Docker repository inside the XSpec organisation at https://github.com/xspec/docker and submitted the Dockerfile, the documentation is in the README file. Would you be able to test it and provide feedback?
At the moment the Docker image needs to be built (there are instructions in the README file) and is not yet available on Docker Hub. I'm looking at how to submit the Docker image for XSpec to the Docker official image repository but the image needs to be approved first (see https://github.com/docker-library/official-images).

Awesome! I will try to test it in the next couple of days... or opefully by the end of next week... ;-)

Pull request #135 contains a solution for the limitation regarding the CSS file that is mentioned in the readme.

Thanks @tofi86 and @vincentml. I'll review #135, that should hopefully solve the CSS limitation.

Awesome! I'll wait for that...

I submitted a request to add the XSpec's Docker image to Docker Hub so that it can be automatically pulled from there.
Regarding the CSS issue, I'll have a look but in order to be included in the XSpec image for Docker we need to release the next version of XSpec. In fact, the Dockerfile builds XSpec from the tar file for v0.5.0. I decided to use that version of XSpec rather than pulling the latest code from master to avoid issues like this one - @tofi86 may remember it 😉 Therefore feel to review it when you have time.

Ah, right... Yeah, using a stable tag for the docker image should be the right way to go! Thanks!
I'll have to see whether I need to manually configure the image for my CI pipeline or whether I can use the approved official image in a couple of days...

I haven't been able to test this yet, sorry... 🙈
Is it already available from dockerhub?

Not yet. You can check the status of the pull request on the Docker official repositories in https://github.com/docker-library/official-images/pull/3303.


MassTransit.StructureMap uses 2.6.2 but Nuget Installs 2.6.3

This causes an issue when you try to start the MassTransit application with a container.
sub.LoadFrom(container)

I get the following error:
Could not load file or assembly 'StructureMap, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=e60ad81abae3c223' or one     of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

This could also be an issue with StructureMap needing an assembly redirect in the configuration.

thanks for this update, really looking forward to using MassTransit.


Remove redundant sections from REQUEST-901-INITIALIZATION.conf

Describe the bug
The IP reputation rules were removed from CRS v4.0 (see #2433).
File REQUEST-901-INITIALIZATION.conf still contains rules that set default values for IP reputation variables. These rules are now redundant, as those rules no longer exist in (core) CRS. They are being moved to a plugin and any variables and default values must be handled there, instead.
Steps to reproduce
Note that the following rules are still part of REQUEST-901-INITIALIZATION.conf:
# Default do_reput_block
SecRule &TX:do_reput_block "@eq 0" \
    "id:901150,\
    phase:1,\
    pass,\
    nolog,\
    ver:'OWASP_CRS/4.0.0-rc1',\
    setvar:'tx.do_reput_block=0'"

# Default block duration
SecRule &TX:reput_block_duration "@eq 0" \
    "id:901152,\
    phase:1,\
    pass,\
    nolog,\
    ver:'OWASP_CRS/4.0.0-rc1',\
    setvar:'tx.reput_block_duration=300'"

These lines should be removed.
Suggestion: Wait until #2813 has been merged before creating a PR for this, otherwise I think merge conflicts will occur, and nobody likes those…
Expected behaviour
We shouldn't be setting variables that are never used (specifically, variables that have been removed).
Additional context
For information on the future IP reputation plugin, see #2680.
Your Environment

CRS version (e.g., v3.2.0): v4.0
Paranoia level setting: n/a
ModSecurity version (e.g., 2.9.3): n/a
Web Server and version (e.g., apache 2.4.41): n/a
Operating System and version: n/a

How can we formalize this condition? I mean, how can we decide that a variable is unnecessary or not with an algorithm?
Eg. take a look this similar rule:
SecRule &TX:crs_setup_version "@eq 0" \
    "id:901001,\
    phase:1,\
    deny,\
    status:500,\
    log,\
    auditlog,\
    msg:'ModSecurity Core Rule Set is deployed without configuration! Please copy the crs-setup.conf.example template to crs-setup.conf, and include the crs-setup.conf file in your webserver configuration before including the CRS rules. See the INSTALL file in the CRS directory for detailed instructions',\
    ver:'OWASP_CRS/4.0.0-rc1',\
    severity:'CRITICAL'"

Can we say if a rule has a condition like this and those above, AND does not have any disruptive action, then it's unused?
Btw. there is no other variable, which created but not used within a transaction, only those two above, and the crs_setup_version.

Hmm, yes.
I think for this issue, I will keep it simple and just remove the offending lines in a PR.
In this example, I checked by doing this:
$ grep -Ri "do_reput_block" 2>/dev/null
rules/REQUEST-901-INITIALIZATION.conf:# Default do_reput_block
rules/REQUEST-901-INITIALIZATION.conf:SecRule &TX:do_reput_block "@eq 0" \
rules/REQUEST-901-INITIALIZATION.conf:    setvar:'tx.do_reput_block=0'"

So, the variable is set in one rule in one file. It is never modified, tested, or reference in any way ever again. Therefore, it must be redundant.
crs_setup_version is referenced in two files:
$ grep -Ri "crs_setup_version" 2>/dev/null
crs-setup.conf.example:# The CRS checks the tx.crs_setup_version variable to ensure that the setup
crs-setup.conf.example:# you must manually set the tx.crs_setup_version variable before including
crs-setup.conf.example:    setvar:tx.crs_setup_version=400"
rules/REQUEST-901-INITIALIZATION.conf:# The CRS checks the tx.crs_setup_version variable to ensure that the setup
rules/REQUEST-901-INITIALIZATION.conf:# manually set the tx.crs_setup_version variable before including
rules/REQUEST-901-INITIALIZATION.conf:SecRule &TX:crs_setup_version "@eq 0" \

I'm not sure if that can be used as a 'formal' or automated method to determine this, though :thinking:

PR open to resolve this: #2833.

I added some more logic to the check, now crs_setup_version isn't marked as unused (because the rule which checks has a disruptive action).
There is only the real_ip variable which is still unused. It set here.
SecAction \
    "id:901321,\
    phase:1,\
    pass,\
    t:none,\
    nolog,\
    ver:'OWASP_CRS/4.0.0-rc1',\
    initcol:global=global,\
    initcol:ip=%{remote_addr}_%{tx.ua_hash},\
    setvar:'tx.real_ip=%{remote_addr}'"

I found a new unused variable: tx.942521_full. This variable set here:
SecRule ARGS_NAMES|ARGS|XML:/* "@rx (?i)^(?:[^\"]*?(?:\"[^\"]*?\"[^\"]*?)*?\"|[^']*?(?:'[^']*?'[^']*?)*?'|[^`]*?(?:`[^`]*?`[^`]*?)*?`)\s*(\w+)\b" \
    "id:942521,\
    phase:2,\
    block,\
    capture,\
    t:none,t:urlDecodeUni,\
    msg:'Detects basic SQL authentication bypass attempts 4.1/4',\
    logdata:'Matched Data: %{TX.0} found within %{MATCHED_VAR_NAME}: %{MATCHED_VAR}',\
    tag:'application-multi',\
    tag:'language-multi',\
    tag:'platform-multi',\
    tag:'attack-sqli',\
    tag:'OWASP_CRS',\
    tag:'capec/1000/152/248/66',\
    tag:'PCI/6.5.2',\
    tag:'paranoia-level/2',\
    ver:'OWASP_CRS/4.0.0-rc1',\
    severity:'CRITICAL',\
    setvar:'tx.942521_lhs=%{TX.1}',\
    setvar:'tx.942521_full=%{TX.0}',\
    chain"
    SecRule TX:942521_lhs "@rx ^(?:and|or)$" \
        "t:none,\
        setvar:'tx.sql_injection_score=+%{tx.critical_anomaly_score}',\
        setvar:'tx.inbound_anomaly_score_pl2=+%{tx.critical_anomaly_score}'"

with commit 81d5e4 by @lifeforms.
Walter, is there any reason why do we need this variable?
@RedXanadu please do not merge #2833 while this is not clarified.

Sorry, these variables (above) are not placed in REQUEST-901-INITIALIZATION.conf, but I think these connected to the topic.
I think this is the last affected variable. There is a tx.anomaly_score variable in rule 980099:
SecAction \
    "id:980099,\
    phase:5,\
    pass,\
    t:none,\
    nolog,\
    noauditlog,\
    ver:'OWASP_CRS/4.0.0-rc1',\
    setvar:'tx.blocking_anomaly_score=%{tx.blocking_inbound_anomaly_score}',\
    setvar:'tx.blocking_anomaly_score=+%{tx.blocking_outbound_anomaly_score}',\
    setvar:'tx.detection_anomaly_score=%{tx.detection_inbound_anomaly_score}',\
    setvar:'tx.detection_anomaly_score=+%{tx.detection_outbound_anomaly_score}',\
    setvar:'tx.anomaly_score=%{tx.blocking_inbound_anomaly_score}',\
    setvar:'tx.anomaly_score=+%{tx.blocking_outbound_anomaly_score}'"

These lines were inserted with this commit.
@studersi, can you help me to understand the point of these variables?

@airween Hmm, I cannot remember why tx.942521_full is there. I see that I committed it but the commit is titled "fix(942120): bring back accidentally removed rules<PHONE_NUMBER>22". So I made a mistake and messed up the Git history, the original code was not authored by me. Perhaps it was set for log data but then mistakenly unused? It looks to me like it can be safely removed.

@lifeforms, thanks for the reply,

Perhaps it was set for log data but then forgotten? It looks to me like tx.942521_full can be safely removed.

thanks, this is enough for me.

These lines were inserted with this commit.

@airween The variable tx.anomaly_score is not initialized earlier because it really isn't used anywhere other than here it sums up the entire anomaly score for the JWall GUI. Since some people still use this GUI, we decided to keep the variable. See discussion here: https://github.com/coreruleset/coreruleset/issues/2319#issuecomment-987107459.

I think setting the variable to 0 in REQUEST-901-INITIALIZATION.conf should be fine. Another option we discussed was setting the variable in a separate jwall-compatibility-plugin.


Remove leftover debug logging

Fixes #8

Oops I was too slow, closing! :)
I'm working on the content-encoding bug now.


Documentation site structure and permalinks

The Sandcastle Help File Builder (SHFB) tool we're using generate a nice doesn't a nice file structure.  The problems are:

The home page and the index topic file names are GUIDs.
All of the content pages are in an html subfolder.

It would be really nice to replace the GUIDs with nice file names and remove the html folder and relocate all files contained within up one folder.
Both of these look kind of nasty and if we publish documentation sites like this now and decide to change the layout (e.g. by relocating the HTML files to the root and/or using nice names for conceptual files) we'll break any links other people have made to our pages.
Normally, I'd put this on the backlog but it will be tough to change after this content has been out in the wild for a while.
Here's some ideas:

Drop the current GitHub Pages implementation in favor of a ASP.NET (or other) hosting environment that allows us to route nice incoming references to the icky layout.

Retain the static layout and relocate/rename the files.  We'd also have to munge them all by adjusting all link references:
index.html: replace this with the actual index file
search.html: replace a href="html/6e0122fd-beb8-4334-9fa2-43a79c330dd9.htm">Back</a> with a reference to index.html
WebKI.xml: replace: Url="html/  --> Url="
WebTOC.xml: replace: Url="html/  --> Url="

The second approach would be easier to implement right now and also has the advantage of continuing with (free) GitHub hosting.  The file transforms look straight forward.
The only remaining issue is transforming the GUIDs for the conceptual topics into something nice.  One approach would be to have the munger tool examine the ContentLayout.content XML file and use the content titles to rename the files.  We'd need to assume that each title is unique and then we'd need to URL escape the title when munging links.

#711

I'm going to go with the static site munge approach for now.  I'm going to replace the index.html file contents so that it won't need to redirect to an GUID named file.  Also, rather than assuming that the conceptual topic title is unique so it can be the file name, I'm going to have the munger examine each content file, looking for a special HTML comment that specifies the topic file name.  This should be located at the top of the *.aml file and be formatted like this (one line):
<!-- topic-filename="NAME.htm" -->

This is almost working.  I published the new site layout to GitHub and that failed because apparently GitHub the top-level directory to only 1000 files, and we have over 8K topics.
I'll have to think about this.  Perhaps, I'll need to abandon GitHub pages and host a regular site.  I'm reluctant to reintroduce the html folder because this will make permalinks less nice.

I thought about this more during the drive to work and decided that I don't want to move away from GitHub pages right now.  I'd have to deploy a Kubernetes cluster to host it or host it elsewhere and the new deployment scripts would be more work than I want to do right now.
I'm going to go back to having a sub-folder for the HTML files,  Rather than calling this html, I'm going to call this doc (which seems less techie).  I'm also going to modify index.html so that it references pages in the doc directory rather than redirecting to another file in the doc like stock SHFB does.

NEVER MIND: I started to make these changes and then realized that the changes I pushed to GitHub pages actually worked.  It just took longer to go live than I waited.
The 1000 file limit appears to be a GitHub  portal limit.  All of the files are actually there.

DONE


Feature request: let tf.contrib.layers.batch_norm normalize over more axes than just the last one

When using tf.nn.batch_normalization and tf.nn.moments it's possible to choose which axes are aggregated and thus which dimensions are normalized over. For tf.contrib.layers.batch_norm and tf.contrib.layers.layer_norm the assumption is that only the last dimension will be normalized over. This is standard practice for filters in ConvNets, or the features in fully-connected layers, but there are use cases where it would be nice to independently normalize across both width and filters (for example audio spectrograms, where "width" could be seen as the time axis). Could the layers API be changed to be a little more flexible or is the current consensus that tf.nn.batch_normalization is the way to go?

It seems useful, ie, there's Layer Normalization which got good performance which is transpose of batch normalization, and Weight Normalization
I wonder if it should be called something else though, since batch in batch_norm refers to batch dimension (0'th dimension).
I don't see a way to specify axis in tf.nb.batch_normalization
tf.nn.batch_normalization(x, mean, variance, offset, scale, variance_epsilon, name=None)

According to its docstring tf.nn.batch_normalization infers the axes from the input tensors (I assume x', mean, varianceetc. and that they're expected to match), so it didn't really need anaxis` parameter, I guess?
By the way, my feature request applies to the layer norm layer too. That too is useful to be able to apply to several dimensions instead of just the last, particularly for RNNs where batch norm is... tricky.

Oh, good point, it looks like it can normalize over arbitrary axis, taking specification from the missing dimension in mean/variance tensors

What is the problem with using tf.nn.batch_normalization?

tf.nn.batch_normalization is more low-level. Unlike the layers version it doesn't handle estimation of population statistics as decaying moving averages during training; it doesn't make a distinction between test time and train time statistics on its own; it requires you to manually introduce trainable variables for beta and gamma, and so on. It's rather tricky to setup, in fact, as it's basically just the mathematical operation and nothing more.

Could you outline what the API change would look like?

I'd expect tf.contrib.layers.batch_norm(..., axis=[0, 1, 2]) to work, just it it does for tf.nn.moments.
For backwards compatibility (where all but the last dimension should be reduced) axis=None is necessary as the default argument because the shape of the input tensor is not known, with documented behavior that it aggregates every dimension except for the last.

Or preferably a new normalization layer, that takes mode and axis so we could choose layer norm, batch norm, weight norm and not consider the particular implementation details of the competing normalization methods (they have the same purpose of minimizing covariate shift AFAIK, but with different tradeoffs in code complexity / normalization "quality"):
tf.contrib.layers.normalize(..., mode='batch', axis=None)
tf.contrib.layers.normalize(..., mode='layer', axis=[0, 1, 2])
tf.contrib.layers.normalize(..., mode='weight', axis=[0, 1])

@fchollet what do you think about this?

For backwards compatibility (where all but the last dimension should be reduced) axis=None is necessary as the default argument because the shape of the input tensor is not known

I don't understand this part? What does this mean?
The default value for axis should be -1, which is the feature axis is essentially every situation except convolution layers in data_format NCHW.
I had not heard before that one would want to normalize on more than the features axis. But we can consider the API change if it seems worth it.

What does this mean?

Say tensors are [batch_size, frames, height, width, channels] (video). Then axis=None could assume the user want means/variances as [batch_size, frames * height * width * channels] and not [batch_size, frames, height, width] (axis=-1).
Uh, I'm confusing myself. :koala:

I had not heard before that one would want to normalize on more than the features axis. But we can consider the API change if it seems worth it. By which I mean we can consider allowing a tuple of axes as the axis argument: the axes to normalize over, e.g. [-2, -1] or [1, 2].

A common use case could be RNNs for audio and video, where you'd like to normalize whole sequences.

This would be a good feature to add to the existing batch_norm (in contrib).


Search Options

The search box always defaults to "Personal" names in the drop-down menu.
Ideally, it would be nice to have the default be unlimited, i.e., search across all names or for any kind of name.

On top of the search defaulting to an unlimited search, it is clear from within the code that after a search is performed, the search option should be remembered for subsequent searches. This is not the case. Might as well kill two birds with one stone here. (no birds will actually be harmed)

Oh, Yay. It has also bothered me that if I choose a type up front, the search doesn't default to that type; but if the default is "any" it wouldn't matter.
Sent from my iPhone
On Mar 29, 2017, at 11:07 AM, Gio Gottardi <notifications<EMAIL_ADDRESS>wrote:
On top of the search defaulting to an unlimited search, it is clear from within the code that after a search is performed, the search option should be remembered for subsequent searches. This is not the case. Might as well kill two birds with one stone here. (no birds will actually be harmed)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/unt-libraries/django-name/issues/113#issuecomment-290139106, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZOIhYRTlRVvZ5GI9srlCnSClAqvjlGlks5rqoG2gaJpZM4MenM4.


question: suppress module path expansion

Merlin often expands paths to the longest possible form, for instance, Containers.CCVector instead of Vector and  Containers.CCList instead of List when Containers is opened at the top level. I really do not want these superfluous long paths in my source. Is there a way to prevent this?

When printing types? You can activate -short-paths by passing this flag or adding it in .merlin:
FLG -short-paths

actually, when using tab-expansion while editing (i use supertab for that). i'll try -short-paths

So you would like Containers.CCV to be rewritten to CCVector automatically when Containers is opened?
That can be done the API will need some rework. But why not start with CCV directly?
This is related to #396 for which I have a prototype in the work.

well actually, the shortest way to use Containers.CCVector after opening Containers is simply as Vector. note that Containers also defines extensions to many standard library modules, which are included and then shadowed. so after opening Containers, the List module contains some functions that actually come from the std lib and some extra ones which come from Containers.CCList but all are available as List.soandso; and this is how the library is meant to be used. i think with batteries it's the same.
so basically, i would want to always use the shortest version when expanding a name. actually, #396 looks really useful too!

But then, just don't type Containers.. During completion, merlin will show you the short names too.
I think I am missing your point.

ok, i think i wasn't clear. what i do is i type
let aa = List.app<tab> and this is completed as
let aa = Containers.List.append which is the same as List.append since Containers was opened. i really wanted List.append.

Oh I see, something wrong is going on.
Merlin should keep the short form.
I will try to reproduce, can you share more information about your setup?

ok, here is the merlin section of my .vimrc
" merlin runtime path settings
let g:opamshare = substitute(system('opam config var share'),'\n$','','''')
execute "set rtp+=" . g:opamshare . "/merlin/vim"
" redundant but what the hell.
execute "helptags " . g:opamshare . "/merlin/vim/doc"

" merlin extras
let g:syntastic_ocaml_checkers=['merlin']
let g:syntastic_auto_loc_list=2
let g:merlin_completion_arg_type = "always"
augroup ocamlmerlin
	au!
	au FileType ocaml call SuperTabSetDefaultCompletionType("<c-x><c-o>")
	" list the expected argument type when completing
	" highlighting of type selections; only works for light bg...
	" problems in the terminal
	"au FileType ocaml hi EnclosingExpr ctermbg=17 guibg=Green
				"\ ctermfg=bg guifg=bg
	" useful bindings
	au FileType ocaml nmap <buffer> <localleader>T :MerlinGrowEnclosing<cr>
	au FileType ocaml nmap <buffer> <localleader>yt :MerlinYankLatestType<cr>
	au FileType ocaml nmap <buffer> <localleader>l :MerlinLocate<cr>
	au FileType ocaml nmap <buffer> <localleader>r <plug>(MerlinRename)
	au FileType ocaml nmap <buffer> <localleader>o :MerlinOccurrences<cr>
	au FileType ocaml nmap <buffer> <localleader>d :MerlinDestruct<cr>
	au FileType ocaml nmap <buffer> <localleader>e <plug>(MerlinErrorCheck)
	au FileType ocaml nmap <buffer> <localleader>ce :lclose<cr>
	" set the local ocamlbuild directories automatically
	"au FileType ocaml silent SourcePath %:p:h
	"au FileType ocaml silent BuildPath %:p:h/_build
	" the text object for navigating types
	au FileType ocaml let g:merlin_textobject_shrink='m'
	au FileType ocaml let g:merlin_textobject_grow='M'
	au CursorMoved *.ml MerlinClearEnclosing
	au CursorMoved *.mli MerlinClearEnclosing
  au FileType ocaml nmap <localleader>*  <Plug>(MerlinSearchOccurrencesForward)
  au FileType ocaml nmap <localleader>#  <Plug>(MerlinSearchOccurrencesBackward)
augroup END

do you need anything else?

another bit of information: if IH is generated via the functor CCHashtbl.Make then if i type
IH.rep<tab> i get CCHashtbl.Make.replace which is also not helpful...

I have no idea how this is possible. Which version of merlin are you using?

:MerlinVersion gives Merlin toolkit version 2.2 for Ocaml 4.02.3. i installed merlin via opam.

my .merlin:
PKG batteries
PKG containers
PKG sequence
PKG gsl
S .
B _build
FLG -short-paths

i could post a gist with the module and .mli if that would help...

Don't worry, I'll try my best and ask if I need more :)

I know what you can do :):
Run merlin after export MERLIN_LOG=merlin.log.
It will log communication between vim and merlin.
Trigger the problem once (to not make the log too big), close and share merlin.log.
(Be aware that your source code will be partially included, send by mail or filter "tell" lines if you prefer, e.g. grep -v '"tell"' merlin.log).

ok, here are the lines with 'tell'. i started vim and invoked the completion once.
{"time":2,"level":"info","section":"general","title":"monitor start","content":["general","info"]}
{"time":2,"level":"info","section":"general","title":"available logging sections","content":["general","destruct","dot_merlin","typedtrie","project_load","parser","locate","recover","protocol","explain","main"]}
{"time":2,"level":"info","section":"general","title":"monitor start","content":["protocol","info"]}
{"time":2,"level":"info","section":"protocol","title":"input","content":{"delta":0,"body":["reset","auto","/Users/nbecker/Tresors/Code/bd/bd.ml"]}}
{"time":5,"level":"info","section":"protocol","title":"output","content":{"delta":2,"body":["return",{"cursor":{"line":1,"col":0},"marker":false}]}}
{"time":5,"level":"info","section":"protocol","title":"input","content":{"delta":0,"body":["project","get"]}}
{"time":5,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"result":["/Users/nbecker/Tresors/Code/bd/.merlin"]}]}}
{"time":5,"level":"info","section":"protocol","title":"input","content":{"delta":0,"body":["reset","auto","/Users/nbecker/Tresors/Code/bd/bd.ml"]}}
{"time":5,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1,"col":0},"marker":false}]}}
{"time":5,"level":"info","section":"protocol","title":"input","content":{"delta":0,"body":["seek","exact",{"line":1,"col":0}]}}
{"time":5,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1,"col":0},"marker":false}]}}
{"time":5,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1,"col":0},"marker":false}]}}
{"time":21,"level":"info","section":"protocol","title":"output","content":{"delta":15,"body":["return",{"cursor":{"line":1006,"col":0},"marker":false}]}}
{"time":21,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1006,"col":0},"marker":true}]}}
{"time":21,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1006,"col":0},"marker":false}]}}
{"time":225,"level":"info","section":"protocol","title":"input","content":{"delta":203,"body":["project","get"]}}
{"time":225,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"result":["/Users/nbecker/Tresors/Code/bd/.merlin"]}]}}
{"time":225,"level":"info","section":"protocol","title":"input","content":{"delta":0,"body":["seek","exact",{"line":1005,"col":0}]}}
{"time":225,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1003,"col":5},"marker":false}]}}
{"time":225,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1001,"col":9},"marker":false}]}}
{"time":225,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1006,"col":0},"marker":false}]}}
{"time":225,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1006,"col":0},"marker":true}]}}
{"time":225,"level":"info","section":"protocol","title":"output","content":{"delta":0,"body":["return",{"cursor":{"line":1006,"col":0},"marker":false}]}}

Ok, it seems merlin is never used for completion.

So, the problem comes from somewhere else, which is a bit reassuring.

oh! this means i mis-configured the completion somehow? do you know how to fix it?

Check the value of :set omnifunc?.
If you try C-x C-o directly, do you have a better behavior?

aha! i think we have the culprit. it's ocpindex#complete. sorry for making a fuss. it seems that this line in my .vimrc:
execute "au FileType ocaml set rtp+=" . g:opamshare . "/ocp-index/vim"

sets the omnifunc!? is ocp-index redundant or conflicting with merlin in general?

Yes to both.
2015-10-13 16:41 GMT+01:00 nilsbecker<EMAIL_ADDRESS>
aha! i think we have the culprit. it's ocpindex#complete. sorry for
making a fuss. it seems that this line in my .vimrc:
execute "au FileType ocaml set rtp+=" . g:opamshare . "/ocp-index/vim"
sets the omnifunc!? is ocp-index redundant or conflicting with merlin in
general?
—
Reply to this email directly or view it on GitHub
https://github.com/the-lambda-church/merlin/issues/447#issuecomment-147754580
.

ok, removed the line, completion works as expected again! thanks for the help! i guess this can be closed then...


lustre2py: embed result into an intrepyd.circuit.Circuit

Lustre designs are translated with stand-alone top nodes, but they'd better be presented as Circuits, to allow test generation and equivalence checking

Solved with commit 51dae4b8ad9dd290e1b5d1b7431ed667d0eddb5b


Experiment with hangs

This is experimental PR.

/azp run java - core - tests

API change check for com.azure:azure-storage-common
API changes are not detected in this pull request for com.azure:azure-storage-common

API change check for com.azure:azure-storage-blob-cryptography
API changes are not detected in this pull request for com.azure:azure-storage-blob-cryptography


Model training performance does not improve.

Hello! I downloaded your preprocessed Synapse dataset and trained according to the instructions, but the training results did not improve. What could be the reason for this?

Hi, due to class-imbalance, the training of the Synapse dataset is highly unstable when using early-stopping (influenced by randomness), maybe you can change the validation interval to a smaller number, e.g., 5 or 2 or even 1 in https://github.com/xmed-lab/DHC/blob/975641335b902cd7fcd97ffc332ce97b0a6169ce/code/train_dhc.py#L364, or enlarge the early_stop_patience.

May I ask if this data is too low? The best eval dice is 0.13395972549915314.
I modified line 340, but it seems that it did not help improve the performance

Is this data too low? The best evaluation dice is 0.13395972549915314.
I modified the validation interval, but it seems it didn't help improve performance

Yes, it should be around 0.4, you can check our training logs in the weights downloading link.

Maybe you need to check whether the data is correctly processed, e.g., through visualization.

Thank you for your response. I have two more questions to ask: 1. The results of running another AMOS dataset are similar to yours, but the Dice score for the Synapse dataset is still around 0.15. Why is there such a difference when I move your dataset and code to my computer? Is this related to the small number of samples in the Synapse dataset? Would you give me some advice? 2. Why does the loss during training appear negative, even as large as -9 or -10?


Use prepareCriteria in SeoActionController

1. Why is this change necessary?
The Criteria changes in a SeoUrlRoute are not done when calculating the context dropdown.
2. What does this change do, exactly?
Use the criteria as intended.
3. Describe each step to reproduce the issue or behaviour.
Create custom SeoUrlRoute with multiple entities (through relations). The dropdown in the admin will only show your main entity, no matter how many are described in the getMapping method.
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hey @runelaenen , thank you for creating this pull request!
Please add some tests for your change and make sure the existing ones aren't failing :slightly_smiling_face:

Hey @runelaenen, we are closing this PR due to inactivity. Should you still be interested to contribute your changes to the project please resolve the remaining issues and create a new PR.


Loot tracking issue also wall esp issue

I have loot on, I have gone into console and user either tracksr * or trackr *.  Nothing ever shows in game except some of the options under the loot tab (corpses etc.)  I have tried to reinstall I have also tried to create a track save file and load that still same outcome.
wall esp for enemies seems to completely disappear when using certain weapons.

which map?

I was having issues on factory and customs as those were the only maps I was playing on this morning

Could you share your %LOCALAPPDATA%Low\Battlestate Games\EscapeFromTarkov\Player.log

Player.log

Wall ESP should be fixed, could you use the save command after your tracklist is set, and share your Documents\Escape from Tarkov\trainer.ini

wouldn't let me paste as a .ini so I copied the contents to .txt

It works for me

works now.  Thank you

I'm going to check if something regressed regarding this. If we save full transparent colors it's weird.


Update DG with ImageStorage and ImagePath changes

Codecov Report

Merging #131 (e10415b) into master (6235d65) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage     60.81%   60.81%
  Complexity      756      756
=========================================
  Files           131      131
  Lines          2958     2958
  Branches        319      319
=========================================
  Hits           1799     1799
  Misses         1069     1069
  Partials         90       90

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[AIRFLOW-3270] Allow passwordless-binding for LDAP auth backend

Make sure you have checked all steps below.
Jira

[x] https://issues.apache.org/jira/browse/AIRFLOW-3270

Description

[x] Because the bind password came from the config parser it was impossible
to set it as None, it would come through as "", which is not the same
(to the ldap3 lib) as not providing a password.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: no tests -hard to test, but tested by author of Jira ticket.

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes flake8

Codecov Report

Merging #4133 into master will decrease coverage by 6.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4133      +/-   ##
==========================================
- Coverage   77.49%   70.55%   -6.94%
==========================================
  Files         199      199
  Lines       16233    18116    +1883
==========================================
+ Hits        12579    12782     +203
- Misses       3654     5334    +1680

Impacted Files
Coverage Δ

airflow/hooks/mysql_hook.py
61.03% <0%> (-29.35%)
:arrow_down:

airflow/operators/docker_operator.py
72.17% <0%> (-25.48%)
:arrow_down:

airflow/www_rbac/views.py
51.83% <0%> (-20.55%)
:arrow_down:

airflow/www/views.py
50.42% <0%> (-18.38%)
:arrow_down:

airflow/sensors/external_task_sensor.py
81.57% <0%> (-15.3%)
:arrow_down:

airflow/models.py
78.35% <0%> (-13.81%)
:arrow_down:

airflow/settings.py
78.18% <0%> (-2.98%)
:arrow_down:

airflow/jobs.py
77.09% <0%> (-0.28%)
:arrow_down:

airflow/configuration.py
89.05% <0%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea0d97...618f82d. Read the comment docs.

@ashb Would it be possible to test this?

If we're deprecating the old non-RBAC api this might not matter on master anymore anyway :D

Good point :-)


feat: contact page

Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling

[ ] Desktop screenshots
[ ] Mobile width screenshots

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes https://github.com/mitodl/ocw-hugo-themes/issues/340
What's this PR do?

Responsive Contact page created
Used bootstrap to keep css minimum
Contact form is rendered via Wufoo  (some Wufoo limitations are mentioned here)
View Deployed PR

How should this be manually tested?

Verify that contact nav button in navbar redirects to contact page
Verify that page is rendered fine on different screen sizes.
Verify that all links are redirected to appropriate targets.
Verify that form is working fine and an entry is created in Wufoo each time user submits a form.

Screenshots (if appropriate)

Is this confirmation page part of your code, or is it provided by wufoo?

@pdpinch I got an email of your comment but can't see it here.
The confirmation part of contact form is also provided by wufoo.

Sorry, I deleted my comment after I read your note on the issue.
I’m working on getting access to the wufoo form builder.

LGTM! Just one thing, The horizontal line is still visible which is not a part of the design However, I dont think that can be removed from this from our own css.

Yup, and we will improve the styling later on as discussed here


How to change the background color of specific date?

app:compactCalendarCurrentSelectedDayBackgroundColor

Hi @ABhayBohra, Add Empty event to that date and in XML add this app:compactCalendarEventIndicatorStyle="fill_large_indicator"


improve changeset notes

closes transitland/transitland#17

@meghanhade a small improvement to review and merge in when you have a min.
BTW, this is using ES6 template strings: https://developers.google.com/web/updates/2015/01/ES6-Template-Strings?hl=en


wiki:These two articles is invalid

These two articles in Category of Chinese is invalid.
Ready? Go! 上篇：大道至简
Ready? Go! 下篇：多核并起

Cloudflare just says that site is down. It might come back up.


@conda-forge-admin,please add bot automerge

[x] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/backrefs-feedstock#10.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/backrefs-feedstock#10.


[README] Add more hosted PostgreSQL support

There is a growing number of hosted PostgreSQL providers. I took a look at supported extensions, and added some more providers that currently do and do not support postgresql-hll

Hey @andyatkinson, thanks for the PR! Created a thread for providers that support it here: #4


[C++][Python] Sporadic asof_join failures in PyArrow

Describe the bug, including details regarding any error messages, version, and platform.
We see sporadic CI failures in test_dataset_join_asof_empty_by. Example:
https://github.com/ursacomputing/crossbow/actions/runs/8597009571/job/23554761859#step:10:787
=================================== FAILURES ===================================
_______________________ test_dataset_join_asof_empty_by ________________________

tempdir = PosixPath('/tmp/pytest-of-root/pytest-0/test_dataset_join_asof_empty_b0')

    @pytest.mark.dataset
    def test_dataset_join_asof_empty_by(tempdir):
        t1 = pa.table({
            "on": [1, 2, 3],
        })
        ds.write_dataset(t1, tempdir / "t1", format="ipc")
        ds1 = ds.dataset(tempdir / "t1", format="ipc")

        t2 = pa.table({
            "colVals": ["Z", "B", "A"],
            "on": [2, 3, 4],
        })
        ds.write_dataset(t2, tempdir / "t2", format="ipc")
        ds2 = ds.dataset(tempdir / "t2", format="ipc")

        result = ds1.join_asof(
            ds2, on="on", by=[], tolerance=1
        )
>       assert result.to_table() == pa.table({
            "on": [1, 2, 3],
            "colVals": ["Z", "Z", "B"],
        })
E       assert pyarrow.Table...null,"Z","B"]] == pyarrow.Table...["Z","Z","B"]]
E
E         Use -v to get more diff

usr/local/lib/python3.9/site-packages/pyarrow/tests/test_dataset.py:5154: AssertionError

The useful information is unfortunately truncated by stupid pytest, but we can still see that there is a null value somewhere in the colVals result, which is probably unexpected.
Component(s)
C++, Python

cc @judahrand @ZhangHuiGui @JerAguilon @rtpsw

Also @raulcd

It's not the same test that's failing, though the underlying cause might be the same.

Ah, I didn't actually look at the test output you posted here, sorry ;)
The ones that I have been noticing the last days was the one with the nulls in the output, so the one described in https://github.com/apache/arrow/issues/40675

From playing around with this locally a bit I can reproduce the flake. However, if I force use_threads=False in the Python code I can't. To me this suggests the failure is threading related and on the C++ side rather than the Python side.

Yes, it's certainly on the C++ side since PyArrow is a wrapper.

I don't think this is a blocker so I've created RC0 for 16.0.0 without it.

Is someone looking into this?
Those failures are quite annoying for the python CI, so maybe we could allow them (both this one and https://github.com/apache/arrow/issues/40675) to fail for now? (although that's also an easy way to forget about it then ..)

I managed to make a C++ unit test, which fails as the CI does, at a fair chance. I'll keep looking, though I can't tell how long I'm going to take as I'm not quite familiar with asof join. If anyone else is interested as well, feel free to go ahead.
TEST(AsofJoinTest, Flaky) {
  std::vector<TypeHolder> left_types = {int64(), utf8()};
  auto left_batch = ExecBatchFromJSON(
      left_types, R"([[1, "a"], [1, "b"], [5, "a"], [6, "b"], [7, "f"]])");
  std::vector<TypeHolder> right_types = {int64(), utf8(), float64()};
  auto right_batch =
      ExecBatchFromJSON(right_types, R"([[2, "a", 1.0], [9, "b", 3.0], [15, "g", 5.0]])");

  Declaration left{
      "exec_batch_source",
      ExecBatchSourceNodeOptions(schema({field("colA", int64()), field("col2", utf8())}),
                                 {std::move(left_batch)})};
  Declaration right{
      "exec_batch_source",
      ExecBatchSourceNodeOptions(schema({field("colB", int64()), field("col3", utf8()),
                                         field("colC", float64())}),
                                 {std::move(right_batch)})};
  AsofJoinNodeOptions asof_join_opts({{{"colA"}, {{"col2"}}}, {{"colB"}, {{"col3"}}}}, 1);
  Declaration asof_join{"asofjoin", {left, right}, asof_join_opts};

  ASSERT_OK_AND_ASSIGN(auto result, DeclarationToExecBatches(asof_join));

  std::vector<TypeHolder> exp_types = {int64(), utf8(), float64()};
  auto exp_batch = ExecBatchFromJSON(
      exp_types,
      R"([[1, "a", 1.0], [1, "b", null], [5, "a", null], [6, "b", null], [7, "f", null]])");
  AssertExecBatchesEqualIgnoringOrder(result.schema, {exp_batch}, result.batches);
}

This is causing wrong result so I'm adding critical label.
My first label added as a collaborator, please correct me if it's not proper :)

Issue resolved by pull request 41614
https://github.com/apache/arrow/pull/41614


What's kind of message?

I saw some Bot can post message like below format, I do not look like normal message.

Can we do that with botkit?
Thanks

Yes, you can do this using attachments.
See here for an example:
https://github.com/howdyai/botkit/blob/master/examples/demo_bot.js#L82


Bot

Would it be possible to create a bot to automatically update the final year in the license? Just so we don't get CI failures unnecessarily. :)

Do you refer to the ci failure that was introduced when 2023 ended and 2024 began?

@lbittarello when you just re-run CI on an existing code base, CI will be green even if on New Year's Day: see, e.g., https://github.com/Quantco/quantcore.geo/actions/runs/7383898495/job/20583083902 (which I just re-ran before you merged your PR).
For each file, insert-license-header only complains if the year in the header is behind the last modification date (based on the git history of the file).

The reason why this was initially failing on New Year's Day is that the checkout github action did only checkout the last commit, suggesting that every file was modified on this day.
That's why fetch-depth: 0 needs to be set in pre-commit CI.

Thanks, I was aware. :)
I was just thinking that it'd be easier to have a bot swoop in on 1 January and fix the license across all files in one go rather than relying on a precommit hook to fix files as we modify them.

Looping in @xhochy
I could definitely create such a bot, I'm just not sure if it's worth the effort

The bot seems a bit useless to me. We should make sure the CI never fails. Otherwise, we will have failing CI until the bot has come around.
Yearly runs of a sweep are not likely to work. They happen so seldomly, it is more likely that they break because the infrastructure is out of date than they will actually succeed.


enhance home page and add testimonial #125

enhance home page

add review page using html,css,javascript

can you accept my pull request??


HDFS-17454. Fix namenode fsck swallows the exception stacktrace, this can help us to troubleshooting log.

When I used hdfs fsck /xxx.txt -move, missing error, but I can't kown the reason, because the exception stacktrace doesn't append to LOG, original code:

When I fix it, look, we can see the exception stacktrace:

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
51m  5s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 27s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 33s

trunk passed

+1 :green_heart:
shadedclient
42m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  9s

the patch passed

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
42m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
268m 55s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

432m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5ea6cfbdebcf 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 41fa5cb805156f5df8e0c60106c982d713d5c040

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/1/testReport/

Max. process+thread count
3016 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 31s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 21s

trunk passed

+1 :green_heart:
shadedclient
41m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
41m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
270m  0s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

429m 15s

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.TestDFSAdmin

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 672a536b9e66 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 880699a9bc61727d79f9c9908dd58677ae63d5e0

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/4/testReport/

Max. process+thread count
2734 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 14s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
36m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 14s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 26s

the patch passed

+1 :green_heart:
shadedclient
36m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
304m 23s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

448m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 20c8310f094d 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e0e05aadea76e37124f11930a670f3769f745b76

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/2/testReport/

Max. process+thread count
2883 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 49s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
36m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
37m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
302m 35s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

449m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5af967045041 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4c5dee325e327595ada3a22daa82f2eb1410cb37

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/3/testReport/

Max. process+thread count
2970 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 58s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
36m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
37m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
231m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

389m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cbc24e121190 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d3b4744de37b64fd717794b217c99d10dfb1eac4

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/5/testReport/

Max. process+thread count
3703 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 33s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
41m 22s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
41m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
268m 50s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

426m 44s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 257d69861710 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1a04adda0ac48a99a5cfd06cba3a84a54ea13757

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/6/testReport/

Max. process+thread count
2445 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 48s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 45s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
35m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
35m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
277m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

437m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cad6a7ee4c8f 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9175c03e59c15cccbc5166645b9e7c203fab19cc

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/7/testReport/

Max. process+thread count
3340 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Can you add a test for this, considering now we are propagating the real error back to the client.
I think if the actual error is being thrown in that case on the client side we can live with just the message, rather than having the entire trace.

ok, I'll add a test class for this PR later.
Besides, It's not HDFSClient that's actually causing an error, but NameNodeFsck, which uses a DFSClient object that doesn't support Kerbeors. And I will submit another PR to solve the NameNodeFsck's bug later.

Can you add a test for this, considering now we are propagating the real error back to the client.
I think if the actual error is being thrown in that case on the client side we can live with just the message, rather than having the entire trace.

ok, I'll add a test class for this PR later.
Besides, It's not HDFSClient that's actually causing an error, but NameNodeFsck, which uses a DFSClient object that doesn't support Kerbeors. And I will submit another PR to solve the NameNodeFsck's bug later.

Can you add a test for this, considering now we are propagating the real error back to the client.
I think if the actual error is being thrown in that case on the client side we can live with just the message, rather than having the entire trace.

ok, I'll add a test class for this PR later.
Besides, It's not HDFSClient that's actually causing an error, but NameNodeFsck, which uses a DFSClient object that doesn't support Kerbeors. And I will submit another PR to solve the NameNodeFsck's bug later.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 39s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
40m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 67 unchanged - 0 fixed = 69 total (was 67)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 16s

the patch passed

+1 :green_heart:
shadedclient
42m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
264m 20s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
asflicense
0m 48s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

422m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux c4383051ab8b 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bf31b0654b294a3987fdfa7f014dcf7d8bde15ea

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/8/testReport/

Max. process+thread count
2539 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
51m 44s

trunk passed

+1 :green_heart:
compile
1m 43s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 48s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 44s

trunk passed

+1 :green_heart:
shadedclient
44m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 27s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 10s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 67 unchanged - 0 fixed = 68 total (was 67)

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
46m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
273m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

446m 54s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1a12b8099213 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a5cbff8dfdacd0802693746be8fa4ec9bc222077

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/10/testReport/

Max. process+thread count
2447 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 38s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
41m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 35s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
41m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
267m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

426m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFsck

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 0f203c12c309 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d1b50f01a9ec635128adf2f54c66f882f39eb0b3

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/11/testReport/

Max. process+thread count
2467 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6709/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 00s

No case conflicting files found.

+0 :ok:
spotbugs
0m 01s

spotbugs executables are not available.

+0 :ok:
codespell
0m 01s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 00s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
91m 59s

trunk passed

+1 :green_heart:
compile
6m 20s

trunk passed

+1 :green_heart:
checkstyle
4m 50s

trunk passed

+1 :green_heart:
mvnsite
6m 42s

trunk passed

+1 :green_heart:
javadoc
6m 03s

trunk passed

+1 :green_heart:
shadedclient
150m 01s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 38s

the patch passed

+1 :green_heart:
compile
3m 36s

the patch passed

+1 :green_heart:
javac
3m 36s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 23s

the patch passed

+1 :green_heart:
mvnsite
4m 14s

the patch passed

+1 :green_heart:
javadoc
3m 39s

the patch passed

+1 :green_heart:
shadedclient
161m 09s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 28s

The patch does not generate ASF License warnings.

430m 52s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6709

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 c868f865a709 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / d1b50f01a9ec635128adf2f54c66f882f39eb0b3

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6709/1/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6709/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Rework ExtractionFilter to adept to boolean values

With #422, 'free_access' is computed correctly. Because not all publishers set this information correctly, I felt the need to rework the extraction filter again.

I added a new parameter to Requires, skip_boolean which enables one to skip boolean values for evaluation
There are now two predefined extraction filters: Requires, RequiresAll,
RequiresAll is a name wrap for Requires() and propagates the skip_bool parameter to the user.

I would suggest also updating the default value for the only_complete attribute in the crawl() method of crawler.py

Hmm, what would be the reasoning behind this? Maybe I'm missing something, but the behavior of Requires("title", "body", "publishing_date") doesn't change at all with this PR.

Hmm, what would be the reasoning behind this? Maybe I'm missing something, but the behavior of Requires("title", "body", "publishing_date") doesn't change at all with this PR.

From what I see, the current default value is Requires("title", "body", "publishing_date", [skip_bool = False]). As far as I understood, the goal of this PR was to update the Requires() functionality to ignore the boolean values per default.

From what I see, the current default value is Requires("title", "body", "publishing_date", [skip_bool = False]). As far as I understood, the goal of this PR was to update the Requires() functionality to ignore the boolean values per default.

Yeah, that's right, but neither title,  body nor publishing_date is a boolean value.

Yeah, that's right, but neither title, body nor publishing_date is a boolean value.
Update: Wait, maybe there is a misunderstanding here. Requires shouldn't ignore booleans per default so that Requires("free_access") actually requires the articles to have free_access=True. RequiresAll() should skip booleans per default.

OK, I think I see my mistake. So the expected behavior of Requires("title", "body", "publishing_date") is the same as Requires("title", "body", "publishing_date", "free_access", skip_bool = True)?

OK, I think I see my mistake. So just to be sure: the expected behavior of Requires("title", "body", "publishing_date") is the same as Requires("title", "body", "publishing_date", "free_access", skip_bool = True)?

No, Requires checks only passed attributes. So Requires("title", "body", "publishing_date") behaves differently than Requires("title", "body", "publishing_date", "free_access") in a way that the latter checks the extraction for the free_access attribute as well. skip_boolean only determines if boolean values are evaluated with bool or checked if they are present in the extraction at all.

OK, now I think I got the idea. I guess the name confused me a bit, perhaps we could change it to something along the lines of eval_bools or eval_bool_values? Also, should we mention this change in the docs?

OK, now I think I got the idea. I guess the name confused me a bit, perhaps we could change it to something along the lines of eval_bools or eval_bool_values? Also, should we mention this change in the docs?

That's a good point. I agree, skip_boolean seems quite bad 😅. Do you have any ideas? IMO eval_bools fits better but isn't quite there.

Do you have any ideas?

Not really, but maybe something like filter_by_bool_value or require_existence