[BUG] Custom QR Template LNURLw misplaced

Wanted to insert an own png as custom design to a voucher and tried to find out how the png should look like.
A DIN A4 sized png input is not filled correctly.
Prints are again different.
lnbits/extensions/withdraw/templates/withdraw/print_qr_custom.html
Input File

output shown before printing

print

Smth wrong with a DINA4 Input ?
Is there a png somewhere, that people can easily change to their needs ?

Is this a bug with the image or with the printer?

With two ppl we each tried different printers, both same same

What is the file your trying to use as custom design?
Unless you mess with the html/css you should use this design as your template! https://www.figma.com/file/GdrmgnSg27VmhnvVZlkXz7/LNVoucher_Template?node-id=0%3A1
https://github.com/lnbits/lnbits/blob/main/lnbits/static/images/default_voucher.png
https://github.com/lnbits/lnbits/blob/main/lnbits/static/images/voucher_template.svg

@arbadacarbaYK have you tried the files listed above? Is this issue still relevant or can it be closed?

This worked, thanks for the links! My assumption that this must be a DINA4 template was just wrong 😅

🙈 stopped working for whatever reason on legend and on own lnbits :(
Templates are not used when linked. Not your links and not mine.
Tried a few ways

Downloaded the voucher.svg from above link, saved as png in the size of the .png in above link
Used above figma and copied it to ps, saved 1:1 as .png in the size of the github .png, linked from drive
downloaded the png from above github link and linked from my drive
https://drive.google.com/file/d/1Vki5V5Xaw31PLUdbkOQTYKGCw0K8FVum/view?usp=sharing
Used above figma and copied it to ps, saved with changed design as .png in the size of above .png, linked from drive
https://drive.google.com/file/d/1zHrXT4CWoLgC1xnyIlS8JFt1AzTVcg7e/view?usp=sharing
inserted the github link to above file

None of this did work.
It should show up on clicking "the eye" and then "print", right ?
The QR is shown (to be exact two with an overlay which itself is an error) but no design t is shown.
https://legend.lnbits.com/withdraw/print/9fzXTnquqN9xBkYpm24xFk

Github does some weird thing to the images, if using an image from github try and add ?raw=true to the end of the link:
https://github.com/lnbits/lnbits/blob/main/lnbits/static/images/default_voucher.png?raw=true
Best bet, upload image to imgur, or something similar, and use an URL that opens the image in the browser, not a page with the image inside!

worked thanks! Would be nice to have that as a hint to the URL-Input-field


Buttons "Next" / "Previous" click-bug.

When I clicked on the button "next year" (<th), the years changed, but by clicking the arrow on the button (<span), calendar disappeared. In a word - the button's event is not inherited by the arrow.
I have not tested whether it has the same problem behavior with other such navigation buttons.

@oldfogy
I have the same problem after deployed to the real server, but locally it's working all the time. Have you solved this? I'm very appreciate that you teach me how to.


Limited number of flashcards generated despite large input

Ya, I did the 'open demo' and i put in a good couple of paragraphs of content. It never generated more than3 questions. 😬

It might be useful to feed individual paragraphs in the thing. This way, the question answering check has a better chance of succeeding, because it won't find answers in other places and invalidate the flashcard candidate.

Autocards supports dividing input into paragraphs.


Foxit Reader hash fails and installer seems to silently hang

Create issues related to the winget.exe client here

Brief description of your issue

winget install Foxit.FoxitReader reports a hash mismatch.
If the --force flag is used, the installer hangs silently in the background.
Steps to reproduce
winget install Foxit.FoxitReader
Expected behavior
Expected to install cleanly
Actual behavior
Installer hangs silently in background and software does not install
Environment
Windows Package Manager v0.2.10771 Preview
Copyright (c) Microsoft Corporation. All rights reserved.
Windows: Windows.Desktop v10.0.19042.870
Package: Microsoft.DesktopAppInstaller v1.11.10771.0

I think I just resolved this in #10087, once it merges, can you try this again?

Hi @jedieaston. Just gave it a shot and got the following:
❯ winget install Foxit.FoxitReader
Found FoxitReader [Foxit.FoxitReader]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://www.foxitsoftware.com/downloads/latest.php?product=Foxit-Reader&platform=Windows&package_type=exe&language=L10N
  ██████████████████████████████  95.4 MB / 95.4 MB
Installer hash does not match; to override this check use --force

And with show:
❯ winget show Foxit.FoxitReader                                                                                Found FoxitReader [Foxit.FoxitReader]
Version: latest
Publisher: Foxit
Description: Industry’s Most Powerful PDF Reader.
Homepage: https://www.foxitsoftware.com/pdf-editor/
License: 2020 © Foxit Software Incorporated. All rights reserved.
Installer:
  Type: Exe
  Download Url: https://www.foxitsoftware.com/downloads/latest.php?product=Foxit-Reader&platform=Windows&package_type=exe&language=L10N
  SHA256: 69728969a674271794843694b6588aadb8f4517d7eefd16bd22309c1e8ae8cb5

I've only been using winget for a day or two, so please let me know if I'm missing something.

Your command syntax is correct, we'll have to wait for the manifest marked "latest" (which isn't actually the latest manifest) to be removed since WinGet just assumes any manifest marked latest is the version it should install.
If you want to get around it for now, you should be able to do winget install Foxit.FoxitReader --version <IP_ADDRESS>598.

I had to wait a day or so, but running the command with the explicit version worked. Thank you! Closing out my issue.


update proxy of master to raftstore-proxy

What problem does this PR solve?
Issue Number: ref #4982
Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy 1253b471ae..d3c6a06291:

Merge pull request #343 from CalvinNeo/merge-tikv-near-7.3-2
Remove the copied raft log if the FAP process timeout (#342)

What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests


Provide a way to customise display for specific builds

Occasionally there can be deployments which are manually adjusted or otherwise different because of production concerns. It would be useful for true dashboard to allow some customisation here.
Some ideas:

Picking up colours from a property
Reading tags to customise output
Ability to mark a deployment as cancelled
Using properties to highlight differences, e.g. deployment is to different region

Most of this can be done by the new custom property feature implemented in #21.


Created ikram_celal_keskin's homework py files

Describe your changes
Checklist

[X] I have read the [CONTRIBUTING]
[X] I have performed a self-review of my own code
[X] I have run the code locally and it works as expected
[X] I have commented my code, particularly in hard-to-understand areas

Screenshots (if appropriate)

pyramid_ikram_celal_keskin.py

sequences_ikram_celal_keskin.py

I will sync the my repo and submit the pr again


Forgotten tag "Authentication" for google-auth plugin

Fixed, thank you!
Your store contents may be cached for up to 24 hours, after that the label should appear


Mapping configuration issue

I'm trying to migrate a classic page to modern experience. In the classic page, I have two zones, one occupies two-thirds, and the other, one-thirds. I'm trying to migrate it using a xml mapping file, in which I set the first zone "column" propertie to 1, and the second zone to 2 and 3, but when I migrate it, the layout it's two equal columns, instead of the two-thirds/one-thirds that I expected. I also tried to set the first zone "column" propertie to 2 and the second one to 3 but the result it's the same.
This is the XML code that I'm talking about:
<WebParts>         <Field Name="PublishingPageContent" TargetWebPart="SharePointPnP.Modernization.WikiTextPart" Order="1" Row="1" Column="1">           <Property Name="Text" Type="string" />         </Field>       </WebParts>
<WebPartZones>         <WebPartZone ZoneIndex="2" Order="2" ZoneId="g_3EABBA081F5C47FCBEE3A54DE44829EA" Row="1" Column="3" />       </WebPartZones>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15e4e027-ceb5-5e46-9b68-f09344d5ef20
Version Independent ID: e6479d50-7e92-62de-49b4-23fcc697803e
Content: Transform classic pages to modern client-side pages using PowerShell
Content Source: docs/transform/modernize-userinterface-site-pages-powershell.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

As the top of the document states, this would be best to be submitted => https://github.com/SharePoint/sp-dev-modernization/issues


The unit tests are dotnetapp2.0 and that is EOL.

When building on a brand new laptop with only Visual Studio 2019 16.10.x
You will get this in the build log during testing:
A total of 1 test files matched the specified pattern.
Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.0.0' was not found.
Expected Behavior
The tests should be run.
Current Behavior
Tests fails and teardown is run.
Possible Solution
Change the TargetFramework tag to netcoreapp3.1
Alternatively change the tag to TargetFrameworks and value to net50;netcoreapp3.1 to run the unit tests both on dotnet core 3.1 and 5.0.
I suggest to leave out 2.1 as dotnet core 2.1 is end of life in August 2021.

I can fix this @augustoproiete

Awesome! Thanks @escarls. Assigning to you then

🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on:

GitHub Release
NuGet Package


Oscar dialogues

Revamped the dialogue system.
Try the game, it works from the start to the ending (with an ending cinematic)
It supports events so if anyone wants the story can be expanded.
Also in sweetsvylvania I put 2 pink gummies near the character, they have a dialogue script also, one says the dialogue only once and the other each time the player touch it.
I can explain to whomever wants to expand the story how to use the scripts.

I'll wait for a review to merge, just try it and if something brokes tell me, if not just accept the review


[BUG] Doesn't save data on repeater fields

I got a website that use repeater fields a lot. I tried to configure my contenttypes.yml like this:
repeater:
	type: repeater
	is_translateable: true
	fields:
		repeattitle:
			type: text
			is_translateable: true

Maybe I'ts not supported but I couldn't find anything in the docs.
Thanks for keeping this plugin so great, cheer mate!

I think, that repeaters are not yet implemented, see #24

I see, still this counts as a bug right? I wasn't aware it was mentioned there.

@zomars They should be implemented on the backend, but not on the frontend due to bolt/bolt/issues/5533. Do they not work on the backend for you?

I think the reason it wasn't working in the backend was because of #32. I'll update and test it again.

As of bdac3fa repeaters should work both in front and back end, @zomars could you check if the issue is solved for you? Perhaps I can then tag a release of the ext :)

Backend is working fine, but somehow translated repeaters are not rendering at all in the front, only the default locale.

Some additional info:
repeater:
    type: repeater
    group: repeater
    is_translateable: true
    fields:
        repeattitle:
            type: text
        repeatcontent:
            type: html
        repeatimage:
            type: image
            extensions: [ gif, jpg, png ]
        repeatlink:
            type: text
        repeatbgcolor:
            type: select
            values: [ "white", "light-gray" ]

Also my current theme is css only modified version of the current base-2016 theme

@zomars Just to make debugging easier/more precise could I get your bolt version (and latest commit if using dev-master or release/3.0), database type and php version? Also, does other content in that contenttype (non-repeaters) translate correctly?
Also it seems like 5542 has not been "up-merged" into master (as of the time of writing) so if you are using bolt/master could you check if switching to latest release/3.0 fixes the issue?
Sorry if this is a lot to ask of you!

Sure! I'm using Bolt (dev-release/3.0 2193fa7), MySQL and PHP 5.5.34. The other content is translating just fine, no problems with routing, labels and forms.

Hmm, before I setup a php 5.5 and MySQL server, could you try to turn on/show all php errors/warnings (if not on already) and see if it gives you anything and also check in the DB if the "$locale_data" column shows the repeaters in the json data for that locale?
Thank you so much for your bughunting :)

Also, (forgot about this) if possible please post which commit of translate you are on!

Yes, the json data is appearing in the en_locale column (in this case), and php is not showing any errors.

Also, I'm using the translate (dev-master 24fe997).

zomars: Just to be sure about one detail... You are getting untranslated/original repeaters, not empty ones when going to non-default locales, right?

I'm getting nothing at all on non-default locale repeaters.

Back-end is fine tho.

Turned out to be an outdated file, so resolved via slack :) please let me know if you have any other issues with the extension @zomars!

Will do! Thanks for your help!


Support Startup Probes

Description
Defining a startup probe with mTLS enabled results in pod indefinitely waiting for a failing probe (port and path are not rewritten).
This is a basic feature of pod lifecycle.
https://github.com/kumahq/kuma/blob/master/pkg/plugins/runtime/k8s/webhooks/injector/probes.go#L16
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-startup-probes

Opened https://github.com/kumahq/kuma/issues/4020


Classification metrics overhaul: input formatting standardization (1/n)

This PR is a spin-off from #4835. It should be merged before any other spin offs, as it provides a base for all of them
What does this PR do?
General (fundamental) changes
I have created a new _input_format_classification function (in metrics/classification/utils). The job of this function is to a) validate, and b) transform the inputs into a common format. This common format is a binary label indicator array: either (N, C), or (N, C, X) (only for multi-dimensional multi-class inputs).
I believe that having such a "central" function is crucial, as it gets rid of code duplication (which was present in PL metrics before), and enables metric developers to focus on developing the metrics themselves, and not on standardizing and validating inputs.
The validation performed on the inputs basically makes sure that they fall into one of the possible input type cases, that the values are consistent with both the type of the inputs and the additional parameters set (e.g. that there is no label higher than num_classes in target). The docstrings (and the new "Input types" section in the documentation) give all the details about how the standardization and validation are performed.
Here I'll list the parameters of this function (many of which are also present on some metrics), and why I decided to use them:

threshold: The probability threshold for binarizing binary and multi-label inputs.

num_classes: number of classes. Used to either decide the C dimension of inputs, or, if this is already implicitly given, to ensure consistency between inputs and number of classes the user specified when creating the metric (thus ignoring either having to chech this manually in update for each metric, or raising error when updating the state, which may not be very clear
to the user).

top_k: for (multi-dimensional) multi-class, if predictions are given as probabilities, selects the top k highest probabilities per sample. It's a generalization of the usual procedure, with k=1. This will be used by the Accuracy metric in subsequent PRs.

is_multiclass: used for transforming binary or multi-label input to 2-class multi-class and 2-class multi-dimensional multi-class, respectively. And vice versa.
Why? This is similar to multilabel argument that was (is?) present on some metrics. I believe this is a better name for it, as it also deals with transforming to/from binary. But why is it needed? There are cases where it is not clear what the inputs are: for example, say that both preds and target are of the form [0,1,0,1]. This actually appears to be multi-class (could be the case that is simply happened in this batch that there were only 0s and 1s), so an explicit instruction is needed to tell the metrics that this is in fact binary. On the other hand, sometimes we would like to treat binary inputs as two class inputs - this is the case used in confusion matrix.
I also experiemented with using num_classes to determine this. Besides this being a very confusing approach, requiring several paragraphs to explain clearly, it also does not resolve all ambiguities (is setting num_classes=1 with 2 class probability predictions a request to treat the data as binary, or an inconsitency of inputs that should raise an error?). So I think is_multiclass is the best approach here.

Documentation
Instead of metrics being organized into "Class Metrics" and "Functional Metrics", they are now organized by topics (Classification, Regression, ...), and within topics split into class and functional, if necessary. This allows to add special topic-related sections - in this case I have added a section on what type of inputs are used for classification metric - a section that metrics can link to, in order to not repeat the same thing 100 times, and to keep docstrings short and to the point.
A second half of the Input types section with examples from StatScores metric will be added in the metric's PR.

Thanks for splitting off the PR! Reviewing now

Hello @tadejsv! Thanks for updating this PR.

In the file pytorch_lightning/metrics/classification/utils.py:

Line 98:9: E128 continuation line under-indented for visual indent

@Borda I made some changes to cut down the number of lines in formatting function down to absolute minimum - let me know if you prefer the new or the old version.

@Borda I made some changes to cut down the number of lines in formatting function down to absolute minimum - let me know if you prefer the new or the old version.

sorry if I confused you about nb lines, the main aspect is code readability... :]

@Borda I made some changes to cut down the number of lines in formatting function down to absolute minimum - let me know if you prefer the new or the old version.

sorry if I confused you about nb lines, the main aspect is code readability... :]

Absolutely, that's why I ask whether you prefer the old or new version. Just looking for some feedback :)

Is there anything else that needs to be done before this PR can be merged?
I think I've addressed all issues that arised so far, so we can bring the review process to an end - as I'm very anxious to finally get to the good stuff ;)
@Borda @SkafteNicki @teddykoker

@tadejsv, thanks for the further description of the is_multiclass parameter. I am fine with merging this PR now, so please go ahead and solve the conflicts and I will approve it.

@tadejsv mind resolve conflicts :] probably after #4549
@SkafteNicki @justusschock @teddykoker @ananyahjha93 mind do the final review?

Alright, merge conflicts resolved, ready for final review. @SkafteNicki please double check that docs are ok (git diff not useful there).


fix(head): Meta tag content declaration

This PR adds a ; in the declaration of the content properties of the meta tag. This correction was necessary because when testing some emails on the Email On Acid platform, I noticed along with my coworker (@thudf) that some email providers were not recognizing words that had an accent. Here's an example:
The purpose was to write "olá".

Nice catch @larisoliveira , thanks for fixing!


[HOLD for Payment 2024-05-29] [HIGH] [Groups] Frontend: Migrate off of participantAccountIDs to participants format in the front end

This is a sister issue to https://github.com/Expensify/Expensify/issues/341000.
As part of the Group Chats design doc we are migrating all report.participantAccountIDs to report.participants with a new data structure that can be used to show:

all participants of a report
whether they are "visible" or not
what their role in the chat is i.e. 'admin'|'member'

Holding on back end changes:

[ ] https://github.com/Expensify/Expensify/issues/341000

The general roll out of this should be as follows:

The backend will start by sending both data structures
The App will be updated to never use the deprecated one
We will also need an Onyx migration to create the new participants object for all reports.
After merging the App PR and deploying it we will force all production app versions to switch to the latest (Internal engineer will coordinate this once the native apps are deployed to production)
We can then stop sending the deprecated data structures report.participants (old version where it is an array of emails), report.participantAccountIDs & report.visibleChatMemberAccountIDs

@arielgreen this one would be good to get a contributor to work on. Perhaps someone with experience working on performance or typescript refactors as the changes will be a little surgical and quite large.
Similar to other issues - we can technically launch without this and the feature will be the same for users (but it should be done).

@marcaaron do you know what is the current progress on the first step: The backend will start by sending both data structures? just trying to get a rough idea, and I would be happy to help clearing this up after I finish with other high priority issues.

Hey thanks @aldo-expensify !
We are pretty close - this issue gives a good idea -> https://github.com/Expensify/Expensify/issues/341000
What's left is to...

Merge your OpenReport changes
Add some more updates to Auth and then merge this PR.
Address the concerns in this issue.
And some clean up*

Clean up

Investigate moving participants Onyx updates to a "lower level" + write tests. Suggested by @flodnv here.
Remove any places that are returning duplicate jsonResponse['someOnyxUpdate'] (e.g. here and here - but there are a few more). These are not needed as the updates always get passed to the API caller in the PHP $response.

I will work on creating some issues for these tasks if you want to help there. Tbh kind of planned on doing it myself since I'm very invested in cleaning up everything, but appreciate the help for sure ❤

@s77rt curious if you'd be interested in picking this one up once we are done with the main feature work. 90% of the backend changes are done we just need to go in and re-wire all the references to participantAccountIDs and visibleChatMemberAccountIDs. Let me know if so! I think you have some good context on what would need to be tested.

Sure I'd like to work on this

🦸 We can start after the second front end PR gets merged, but I'll assign you now.

Will look into this today

Update: Raised a Onyx PR fixing a bug that I encountered working on this https://github.com/Expensify/react-native-onyx/pull/537

⚠ Automation failed: This was deployed to production today here, therefore should be [HOLD for Payment 2024-05-29] and have Awaiting Payment label. Additionally, it's missing the Bug label -> doesn't have a BZ team member assigned.
cc @marcaaron

Thanks! Assigned you and adding the correct labels to get this sorted.
@miljakljajic this was a new feature not a Bug so I added that label.
Other details:
@s77rt is working with me and @mallenexpensify directly on this one
@ikevin127 worked as the C+ on the review so he needs to get paid for that

Payment summary as follows:

$500 to @ikevin127 for the C+ review

Is that correct?

Also, after paying this out we can close the issue? (Sorry, there's a bunch of PRs linked here)

I think that's correct! The reported deploy blocker from https://github.com/Expensify/App/issues/34692#issuecomment-2113623335 was not related to the participants migration based on https://github.com/Expensify/App/issues/42232#issuecomment-2113709747.

Also, after paying this out we can close the issue? (Sorry, there's a bunch of PRs linked here)

✅
cc @marcaaron @s77rt Please, correct me if I'm wrong on any of the questions!

Alright, I've sent an offer in the meantime. I can always amend the price after the hipcheck.

@trjExpensify Is this enough for payment to be issued today or we're waiting for Marc's confirmation too ?

Yeah, the latter. I'm coming in pretty cold on this one. I reached out to Marc earlier and I'll settle this after. 👍

Alright, Marc got back to me. Paid!


Documentation: Notes on Client v3 Phase-Out

Pull Request type

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] WHOSUSING.md
[x] Other (please describe):

Documentation
Changes in this PR
Added deprecation and relocation notes in client and sdk modules

@Haven-King this is based on your suggestion https://github.com/conductor-oss/conductor/pull/255#issuecomment-2355125692

While the existing Java SDK will not be deprecated, I would still probably add a line to the README of that module along the lines of "see incubating SDK" with a link to this new one.

Looks good?


hls/xls/test: remove wildcards

Fixes #339
/cc @cdleary @QuantamHD

Merging since this fixes the build.


npm can't start, web pack version issue?

	throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);
	^

WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

configuration has an unknown property 'debug'. These properties are valid:
object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }
The 'debug' property was removed in webpack 2.
Loaders should be updated to allow passing this option via loader options in module.rules.
Until loaders are updated one can use the LoaderOptionsPlugin to switch loaders into debug mode:
plugins: {
new webpack.LoaderOptionsPlugin({
debug: true
})
}
configuration.module has an unknown property 'preLoaders'. These properties are valid:
object { exprContextCritical?, exprContextRecursive?, exprContextRegExp?, exprContextRequest?, loaders?, noParse?, rules?, unknownContextCritical?, unknownContextRecursive?, unknownContextRegExp?, unknownContextRequest?, wrappedContextCritical?, wrappedContextRecursive?, wrappedContextRegExp? }
Options affecting the normal modules (NormalModuleFactory).
configuration.resolve.extensions[0] should not be empty.
at webpack (/Users/wayliu/src/goodmom/private/my-new-project/node_modules/webpack/lib/webpack.js:16:9)
at Object. (/Users/wayliu/src/goodmom/private/my-new-project/node_modules/webpack-dev-server/bin/webpack-dev-server.js:236:12)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
at Module.runMain (module.js:590:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)

Looks like a duplicate of #46, try npm install<EMAIL_ADDRESS>then npm start again

Thank you @eastbayjake this should do the trick, @mkliu can you confirm?

Closing this, webpack is stable now, this should no longer be an issue - at least in develop


Separate dev dependencies and add pre-commit support

What's changing
I realized that we were introducing dev dependencies to the image, like pytest. At the same time, I also discover that we weren't installing anywhere the pre-commit dependency, and we didn't configure it.
So, I fix it. I modified the compose and the Dockerfile and the compose, and I created a new uv/python project in the root of the repo only including the pre-commit. When we execute make local-up, it also configures the pre-commit.
As long as the pre-commit is configured at a repo level inside .git/webhooks/, after execute the make local-up you can go to whatever folder and follow the development instructions uv sync, etc.
How to test it
Clean the .venv folders if you already have one (or more), just to make sure, and execute make local-up, go to the backend folder, run uv sync, and start developing!
Additional notes for reviewers
I already...

[ ] added some tests for any new functionality;
[ ] updated the documentation.

@macaab26 can you hold before merging this, I think it needs further discussion.


Simulator tutorial message box displayed improperly

Describe the bug
On opening the simulator of circuit verse for the first time(or on incognito mode) , the last tutorial message box is not displayed properly.
To Reproduce
Steps to reproduce the behavior:

Open a new incognito window / Private Window.
Go to https://circuitverse.org/simulator .
Click on Next until the last tutorial message box .
See error (Message box hangs at the top) .

Expected behavior
The last message box of the tutorial should be displayed properly inside the window like previous boxes.
Screenshots

Uploading CircuitVerse - Digital Circuit Simulator online - Personal - Microsoft Edge 2022-01-12 00-21-28.mp4…
Device Information [optional]:

Windows 11
chrome Version 97.0.4692.71 (Official Build) (64-bit) &
brave V1.34.80
Edge 96.0.1054.62

Are you working on this issue? (Yes/No)
Yes

Hey @Traitor000 This is already begin raised #2348 and PR is also being raised and waiting for merge #2360

Sure ! So I am closing this issue @vedant-jain03 . Let me know if you have some issues in mind that I can work on or any other way I can contribute.


Support hiding cursor in inactive terminal

Sometimes it is hard to tell what terminal is active, so i suggest adding an option to automatically hide the cursor from the inactive terminal
    "terminal.displayCorsor": "onlyActive"

always: always render render cursor - this is the default
onlyActive: only render cursor of the active terminal (with user input focus)

As you can see, there is no way to tell wich one is currently active..
Related : #178378

You can use a block cursor and cursor blinking to help with this
https://user-images.githubusercontent.com/29464607/228019496-4f45f632-7d1f-47b2-8946-ce6fbc0f9703.mov


Log response from Imagebuilder compose

Codecov Report

Merging #370 (c79bbe0) into main (c872d33) will decrease coverage by 1.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   27.67%   26.11%   -1.56%
==========================================
  Files          30       31       +1
  Lines        2775     2902     +127
==========================================
- Hits          768      758      -10
- Misses       1924     2050     +126
- Partials       83       94      +11

Impacted Files
Coverage Δ

pkg/clients/imagebuilder/client.go
38.42% <100.00%> (+14.30%)
:arrow_up:

pkg/routes/imagesets.go
33.33% <0.00%> (-2.46%)
:arrow_down:

pkg/routes/devices.go
28.57% <0.00%> (-0.30%)
:arrow_down:

pkg/services/updates.go
35.12% <0.00%> (-0.09%)
:arrow_down:

pkg/services/errors.go
0.00% <0.00%> (ø)

pkg/services/files/uploader.go
0.00% <0.00%> (ø)

pkg/services/thirdpartyrepo.go
0.00% <0.00%> (ø)

pkg/models/ownershipvoucher.go

pkg/ownershipvoucher/deserializer.go

pkg/services/ownershipvoucher/ownershipvoucher.go
100.00% <0.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c872d33...c79bbe0. Read the comment docs.


Feature request: support for psutil 6.0

psutil 6.0.0 just came out! It'd be great if we could update requirements.txt to support it so codes depending on psij-python can update.

Thank you @Andrew-S-Rosen for keeping an eye on this. It is appreciated.
I have added psutil 6.0 to the requirements file along with 5.9 in #473. Based on a quick local test, there do not appear to be any visible issues with it.


DoInDirectory Extension to DSL

I have created an extension that I think makes sense to include in the BuiltIn DSL of Cake.
https://github.com/pitermarx/Cake.DoInDirectory
    DoInDirectory("Some/Sub/Directory", () =>
        Npm.RunScript("test")
    );

It changes the current directory for some action and then changes it back
What do you think?

@pitermarx  PR  #1009 added ability to set working directory for tools, think that covers most scenarios and has a lower risk for race conditions if we in the future would allow to do tasks in parallel.
But good scenario for an addin and we appreciate the feedback :+1:


allow config with console stdin

hi @GearsAD, this PR forces keyword loadGraffConfig(filename=...) for what used to be a default first parameter.  Hope that is okay?

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff          @@
##           master   #91   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files          12    12
  Lines         825   825
====================================
  Misses        825   825

Impacted Files
Coverage Δ

src/GraffSDK.jl
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8008672...f1016f1. Read the comment docs.

:+1:

Thanks for the contrib!


Ignore guest sessions.

Prevent the bot from greeting undefined guest users.

Fixes #98

Thanks @Benzi !


Regenerate java

Bump grpc version to 0.1.5
Include latest toolkit ( and https://github.com/googleapis/toolkit/pull/844)

PTAL

LGTM

@michaelbausor , there are no generated grpc maven packages for most APIs at 0.1.5, so this doesn't build for me.

I went through the release process but it seems like I missed the last step, they are now released


I18n-id for Code Flow.ts, Functions.ts, Hello World.ts, Objects and …

Overview
Part of #938
Changes
Provides Indonesian translation for:

Code Flow.ts
Functions.ts
Hello World.ts
Objects and Arrays.ts

LGTM


Something went wrong

Seems like entering my username does not work.

It should be fixed now: https://www.githubwrapped.io/YanniTheDev. Let me know if the issue persists.


ADD Movie Trivia Game #317

fix: ##317
https://www.loom.com/share/87b5d37e94be4840a5a2732e987a5143?sid=1c582508-238d-47ce-b96a-2f01418f437a

@shubhagarwal1 can you help me to make a page similar to gssoc?
I will sponsor you.


Flutter shorthand

This is not meant to be a "JSX or not" question, but more a question of if there is any way to reduce boilerplate in flutter with pure dart. Note: I am naiive to most of Dart's language features
The goal of this issue is not for me to just propose my own form of shorthand, but simply to ask how something like this could work today, and to throw an idea into the wind and see if it goes anywhere.
Is it possible for us to roll our own modifiers? (like async, await)
StatelessWidget today
class MyText extends StatelessWidget {
  final String title;

  MyText(this.title);

  @override
  Widget build(BuildContext context) {
    return Text('title');
  }
}

tomorrow?
MyText (String title) widget {
  build => Text('title');
}

StatefulWidget today
class MyOtherText extends StatefulWidget {
  String title;

  MyOtherText(this.title);

  @override
  _MyOtherTextState createState() => _MyOtherTextState();
}

class _MyOtherTextState extends State<MyOtherText> {
  bool isShown;

  _handlePressed(){
    setState(() {
      isShown = !isShown;
    });
  }

  @override
  void initState() {
    super.initState();
    isShown = false;
  }

  @override
  Widget build(BuildContext context) {

    return isShown ?
      RaisedButton(
        child: Text("Click me"),
        onPressed: ()=>_handlePressed
      )
    : Container();
  }

  @override
  void dispose() {
    isShown = null;
    super.dispose();
  }
}

tomorrow?
MyOtherText (String title) widget* {
  bool isShown;

  initState => isShown = false;

  build => isShown ?
    RaisedButton(
      child: Text('Click me'),
      onPressed: ()=> setState=> isShown = !isShown
    )
  : Container();

  dispose => isShown = null;
}

I think that kind of boilerplate is not really the problem. Your code is really hard to understand, and putting props and state into the same logical block is problematic.
Even today, you could do something like this to shorten your first example:
Widget buildMyText(String title) => Text(title);

I think what really causes a lot of boilerplate are the child/children constructor arguments, and in general the composition of widgets with all of those brackets.
Also, when it comes to constructors with named arguments, it would be great to have this kind of shorthand:
final color = Colors.blue;
final padding = EdgeInsets.all(16.0);

return Container(
  color,
  padding,
  child: Text('Hello World'),
);

FutureBuilder and StreamBuilder also generate quite a lot of boilerplate, for example compared to Angular 6:
<child-widget [time]="time$ | async"></child-widget>

vs.
StreamBuilder<DateTime>(
  stream: time$,
  builder: (context, snapshot) {
    if(snapshot.hasData) {
      return ChildWidget(time: snapshot.data);
    }
    else {
      return Container();
    }
  },
);

Also, you pointed out the functional widget. I use those a lot but (and this may be a misunderstanding on my part) it seems like context isn't passed through? If context is passed through then I see no reason to use class based StatelessWidgets

You don't need to add @override.
@override is only enforced by a linter rule that can be disabled,
bit @override helps to avoid bugs which is usually much more important than writing less code.

dispose() => isShown = null;

is just not the same code as
  void dispose() {
    isShown = null;
    super.dispose();
  }
}
```dart
and such kind of "magic" is terrible because it makes it hard to reason about code.

Explicit
```dart
super.dispose();

makes it clear that there is a super implementation that is also executed.
Special-casing all kinds of Flutter methods is IMHO a bad thing.
One time you want super.xxx() be called before the other time after the code in the method.

I haven't seen anyone call super.dispose() before, and I've never seen anyone call super.initState() after, but perhaps my experience is limited. Also, these questions come up a lot in the community and I think they will continue to do so. Templating languages like xml/JSX exist to reduce boilerplate and code noise. I'm not saying we should use JSX, but I am saying that I think there is a lot of room for improvement on keeping things pure Dart while reducing boilerplate. At least, I hope there is, and Im interested in exploring it.

What about a modifier?
dispose() super => isShown = null;

I haven't seen anyone call super.dispose() before, and I've never seen anyone call super.initState() after, but my experience is definitely limited.

Special casing everything where a line of code could be saved by some language magic would make a gigantic mess out of Flutter and Dart.
This kind of optimizations buys you nothing but confusion from users who have to memorize and understand all special cases.

dispose() super => isShown = null;

Honestly I haded stenography in school and this is exactly that ;p
Dart has simple to understand mostly unambiguous syntax.
Such stuff would break that and doesn't provide any value whatsoever.
Writing code is the simplest part of the whole software development workflow.
I don't think it's worthwhile to optimize here in such dangerous ways.
Most other areas provide more potential for optimizations.

Duplicate of https://github.com/flutter/flutter/issues/20865


Pipeline DSL documentation

The documentation for the new Jenkins 2.x documentation is all over the place.
There is this blog post, which is now wrong and outdated: https://blog.openshift.com/pipelines-with-jenkins-2-on-openshift/
This lists bldCfg as the parameter for openshiftBuild but your README references buildConfig
https://jenkins.io/doc/pipeline/steps/openshift-pipeline/
Which one is correct?
In the RedHat OpenShift Workshop it says the best practice is to build the image then run your tests inside the image to control for environment changes, and the workshop shows that process with the OpenShift plugin running in Jenkins 1.x not using pipelines but I see no way to do that with the new 2.x pipeline DSL
Is there any good examples or documentation to how to best apply the OpenShift specific DSL?

Some responses embedded below.  @bparees and @jupierce fyi
On Monday, September 12, 2016, James English<EMAIL_ADDRESS>wrote:

The documentation for the new Jenkins 2.x documentation is all over the
place.

We are working a trello card this sprint to capture all the ci/cd related
tidbits in a concentrated section of the openshift docs.

There is this blog post, which is now wrong and outdated:
https://blog.openshift.com/pipelines-with-jenkins-2-on-openshift/
This lists bldCfg as the parameter for openshiftBuild but your README
references buildConfig
https://jenkins.io/doc/pipeline/steps/openshift-pipeline/
Which one is correct?

Both are correct.  "bldCfg" was the original name with a pre release
version.  API review switched to "buildConfig" but we kept "bldCfg" for
early adopters.  I just double checked the readme and it lists both.

In the RedHat OpenShift Workshop it says the best practice is to build the
image then run your tests inside the image to control for environment
changes, and the workshop shows that process with the OpenShift plugin
running in Jenkins 1.x not using pipelines but I see no way to do that with
the new 2.x pipeline DSL
Is there any good examples or documentation to how to best apply the
OpenShift specific DSL?

When i can get my laptop on a network Tuesday (i was traveling today I will
post the current example unless @bparees beats me to it.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/jenkins-plugin/issues/63, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADbadPy5Rvl9HouhjlHCrW0iYIZu5-WOks5qpby8gaJpZM4J7Be4
.

@jamestenglish are you just looking for more details on the openshift plugin pipeline DSL syntax?
https://github.com/openshift/jenkins-plugin#jenkins-pipeline-formerly-workflow-plugin
we don't have a rich set of examples of using it, our primary pipeline example is here:
https://github.com/openshift/origin/tree/master/examples/jenkins/pipeline
https://github.com/openshift/origin/blob/master/examples/jenkins/pipeline/samplepipeline.json#L46

I was looking for a more rich set of examples, but I guess it is was it is.

Ah - in that case, we have some in progress work this sprint that is focused just on that.
The trello card for it is here if you wish to track to on going work.
@csrwng FYI


Delete old package @kungfooman/esm-worker

Was @kungfooman/esm-worker, gotta see how it's possible to delete a package on NPM.

That was easy on https://www.npmjs.com/


fix(rate-limiting): counters accuracy with redis policy & sync_rate

Summary
When the periodic sync to redis feature is turned on, using the sync_rate configuration option, keys are incremented by 2 instead of 1 for requests that arrive after the sync_rate interval has expired.
This happens because after each sync, the key is loaded from redis using incr (see: https://github.com/Kong/kong/pull/10559) however the next call to increment also adds 1 to the counter, so the key is incremented twice every time it's loaded from redis. In other words there can be 2 increments for the same request: here and then here.
This fix sets a negative delta for the key when
conf.sync_rate ~= SYNC_RATE_REALTIME and the key was loaded from redis to account for the prior increment.
Checklist

[x] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[x] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

Issue reference
KAG-2906

the PR is ready. Holding on merge for a while, since the same logic is being investigated in https://github.com/Kong/kong-ee/pull/6253 just in case it requires any adjustments. @ADD-SP @StarlightIbuki let me know when you think this can be moved forward.


Please add a discussion of dask security to the docs

Feature Request:
I am considering creating a dask cluster that will be sending tasks over an insecure public network.  Since a dask task essentially tells my worker to execute arbitrary code, there is a naive opportunity for, e.g. MITM attacks.  I presume that there has been a lot of effort on the part of dask developers to ensure the security of communications between dask nodes.  However, I cannot seem to find any documentation of any security stuff.  Where can I find a discussion of how dask communications are secured, and can such a thing be added to the docs?

@csbrown just in case you haven't the page.  Dask has security docs here: https://distributed.dask.org/en/latest/tls.html


feat: resolve node builtin module without node: scheme

part of https://github.com/denoland/deno/issues/20566
This PR updates the resolution of bare specifiers. If the module specifier is node builtin module as a bare specifier, resolve it as node:<module_name>. Also it prints the warning message like Warning: Resolving "path" as "node:path". If you want to use a built-in Node module, add a "node:" prefix.

Tested with the below change in Deno CLI repo:
index 36dccab10..6bbdc96c0 100644
--- a/cli/Cargo.toml
+++ b/cli/Cargo.toml
@@ -49,16 +49,16 @@ deno_ast = { workspace = true, features = ["bundler", "cjs", "codegen", "dep_gra
 deno_cache_dir = "=0.6.0"
 deno_config = "=0.3.1"
 deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
-deno_doc = "=0.67.0"
-deno_emit = "=0.28.0"
-deno_graph = "=0.55.0"
+deno_doc = { path = "../../deno_doc" }
+deno_emit = { path = "../../deno_emit/rs-lib" }
+deno_graph = { path = "../../deno_graph" }
 deno_lint = { version = "=0.51.0", features = ["docs"] }
 deno_lockfile.workspace = true
 deno_npm.workspace = true
 deno_runtime = { workspace = true, features = ["dont_create_runtime_snapshot", "exclude_runtime_main_js", "include_js_files_for_snapshotting"] }
 deno_semver.workspace = true
 deno_task_shell = "=0.13.2"
-eszip = "=0.53.0"
+eszip = { path = "../../eszip" }
 napi_sym.workspace = true

 async-trait.workspace = true

It works like the below:
$ cat a.js
import fs from "fs";
import path from "path";
console.log(fs.write);
$ ./target/debug/deno run a.js
Warning: Resolving "fs" as "node:fs". If you want to use a built-in Node module, add a "node:" prefix.
Warning: Resolving "path" as "node:path". If you want to use a built-in Node module, add a "node:" prefix.
[Function: write]

Now this change uses is_builtin_node_module_name and on_resolve_bare_builtin_node_module from NpmResolver trait for checking builtin node module and printing warnings.
I skipped supporting the same thing with wasm/js version as npm resolver doesn't seem configured for them.

@dsherret Thank you for your review! I'll land this and release it as v0.56.0 tomorrow my time (and will continue working on dependent crates, such as eszip, deno_emit, deno_doc, etc).

https://github.com/denoland/eszip/pull/149
https://github.com/denoland/deno_doc/pull/352
https://github.com/denoland/deno_emit/pull/140


Build ready tarballs and releases

I'm sure its on the roadmap, but I'd like to ensure it is, first.
Build ready release tarballs will be necessary for it to be adopted into Linux distributions.  By build ready I mean tarballs with any submodules already included.
I'm not sure what the roadmap for this project actually entails, but I am excited!

Hello. Which submodules are missing, and from which repo? I'm happy to make tarballs if you let me know what's currently wrong and what those tarballs need to include. Thanks.

Well, sysmonCommon for example.

Hi - Can you provide more details around this ask? Is it asking: For each new release make a TAR ball available that contains all (incl. submodules) of the sources for Sysmon for Linux? I am not super familiar with the process of adding into Linux distribution, if you have a link to example docs I could look at that would be great.

Hi - Any updates on the above? Starting with 1.1, we are publishing the RPM and DEB package as part of the release.

Closing for now. Please reopen if the issue persists with the latest changes.


Use in C-style for loop heads seems error-prone

First I should say that I am pretty happy with this proposal as it stands. This is a narrow concern.
I am worried about allowing these declarations in C-style for(;;) loop heads. Specifically, the not-per-iteration semantics of disposing seem error prone. People already get tripped up by var not creating a per-iteration binding, which is why we made let be per-iteration here (somewhat magically); going back to not-per-iteration semantics seems fraught. And variables declared in the loop head are normally reassigned in the body or update of the loop, which doesn't work with using declarations.
Besides which, it just doesn't seem that necessary. If you really want the not-per-iteration semantics, it's easy enough to do:
{
  using init = foo();
  for(; init.x = next(init.x); init.x != null) {
    // use init
  }
}

This just doesn't seem likely to come up enough to be worth the potential confusion to readers.
Per-iteration dispose semantics would also be confusing, given how the scoping works. I would be in favor of just not allowing this syntax in this specific position, unless there is some important use case I'm overlooking.
(These concerns don't apply to either kind of for of loops, which do have per-iteration semantics, and also can reasonably be const.)

I am worried about allowing these declarations in C-style for(;;) loop heads. Specifically, the not-per-iteration semantics of disposing seem error prone. People already get tripped up by var not creating a per-iteration binding, which is why we made let be per-iteration here (somewhat magically); going back to not-per-iteration semantics seems fraught. And variables declared in the loop head are normally reassigned in the body or update of the loop, which doesn't work with using declarations.

A using declaration is an immutable binding like const, and we don't create per-iteration bindings for const in a for statement, only for let per Step 9 of ForLoopEvaluation.
I think it's perfectly reasonable to do something like the following (not unlike your example):
for (using walker = getWalker(); walker.hasMoves; walker.advance()) {
  ...
}

Besides which, it just doesn't seem that necessary. If you really want the not-per-iteration semantics, it's easy enough to do:
{
  using init = foo();
  for(; init.x = next(init.x); init.x != null) {
    // use init
  }
}

This just doesn't seem likely to come up enough to be worth the potential confusion to readers.

We support const here, so I'm not sure why we wouldn't support using. If the semantics are clearly defined, leaving it out seems somewhat arbitrary. I disallow it in for..in because you can never produce a value via for..in iteration that satisfies the constraints of using, yet you can produce such a value in the initializer of a for statement.

Per-iteration dispose semantics would also be confusing, given how the scoping works. I would be in favor of just not allowing this syntax in this specific position, unless there is some important use case I'm overlooking.

Per-iteration dispose would be the wrong semantics and isn't what's currently specified.

The walker example is reasonably compelling, I suppose. I'm still worried about people being surprised the disposal doesn't happen per-iteration, given that let is per-iteration in that position (and const might as well be; it's not observable that it isn't).
I can bring it up in plenary and if people don't generally agree with me I'll withdraw the concern.

I do still kind of feel this way but there was not unanimous agreement in committee. Since this opinion isn't super strongly held, in the interests of having fewer things which need to be resolved for this proposal to advance I'll withdraw this concern.


Could not find file exception when Table Object exists

Hello,
I'm using FastReport.OpenSource 2021.3.1 in WPF (.NET 5). When there are some table objects in a frx template, some exceptions will be raised in Prepare() function. But it seems to be fine in some other environment such as .Net 5 console application.
Here is the message.
Message = "Could not find file 'E:\Development\XXXXX\output\net5.0-windows\System.dll'."
Message = "Could not find file 'E:\Development\XXXXX\output\net5.0-windows\System.Drawing.dll'."
Message = "Could not find file 'E:\Development\XXXXX\output\net5.0-windows\System.Data.dll'."
......
Here is the call stack.

The report seems to be OK.
Thanks.

Hello!
We have not been able to reproduce this problem on the latest version
Best regards
Marat


Unable to determine Swift version for Pod

how can i fix that?

I will resolve this issue with you:
1- run npm uninstall react-native-in-app-review  to remove old package.
2 after that, run npm install git://github.com/MinaSamir11/react-native-in-app-review.git#solve-bug-unable-to-determine-swift-version --save  to install the beta of the new version package before update the package to your issue.
3- try again to run npx pod-install, to see if the issue resolved or still exists.

Pod install is now working properly.
But i still cant run the project. This generated 52 erros.

what's your react native version ?

"react-native": "0.61.4"

try these steps:
1- Open ios/YourAppName.xcodeproj in Xcode
2- Right-click on Your App Name in the Project Navigator on the left, and click New File…
3- Create a single empty Swift file to the project (make sure that Your App Name target is selected when adding)
4- when Xcode asks, press Create Bridging Header and do not remove Swift file then. re-run your build.
This should fix the problem

try these steps:

1- Open ios/YourAppName.xcodeproj in Xcode
2- Right-click on Your App Name in the Project Navigator on the left, and click New File…
3- Create a single empty Swift file to the project (make sure that Your App Name target is selected when adding)
4- when Xcode asks, press Create Bridging Header and do not remove Swift file then. re-run your build.
This should fix the problem

It's working now!
Thanks

Remove installed current package.
and install new version v3.2.2 now. Update live now.

I also face this issue when adding v3.2.3
I have created the file as you suggested and created the Bridge Header, but it did not help.
RN 0.63.4, Xcode 13.0, M1 MacBook Air
Podfile platform :ios, '10.3'

@ttristan
if you remove a package, it builds successfully !!


Code coverage fixes

This PR aims to address 3 main issues:

To fix the exception being raised when one tries to run instrumented tests with code coverage turned on.
java.lang.NoClassDefFoundError: Failed resolution of: Lorg/jacoco/agent/rt/internal_3570298/Offline;
at com.microsoft.identity.client.Logger.$jacocoInit(Unknown Source:13)
at com.microsoft.identity.client.Logger.<clinit>(Unknown Source:0)
...

Adding the ability to turn code coverage on or off easily without affecting the rest of the pipelines - https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/1635/files#diff-824c1e8ad11e20caed0bec7162a99779b9a4bcf1178d99fae3e39f69889f8959R21 & https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/1635/files#diff-de2d54ff1759d86cbb48be44d1dc5757fbc00c1775efea9862854297630c9676R31

Moving the code coverage pipeline from Github Actions to Azure Pipelines - this is because there was the need to run e2e tests which require the test automation credentials only available to Azure Pipelines

Should we see a change to use the build property here?

Should we see a change to use the build property here?

This has been added

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@44768f5). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev    #1635   +/-   ##
======================================
  Coverage       ?   13.34%
  Complexity     ?      298
======================================
  Files          ?      165
  Lines          ?     7435
  Branches       ?      702
======================================
  Hits           ?      992
  Misses         ?     6301
  Partials       ?      142

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44768f5...20ccf83. Read the comment docs.

Could you please give a brief description of the issue (root cause), and how you fixed it?

This is already done, kindly read through the PR description and if it still doesn't make sense I will add more elaborations


unable to run toyctf.ipynb interactive

I try running the first cell and receive the error ModuleNotFoundError: No module named 'cyberbattle'

Not the official answer, but I think there's two ways you can solve this:

Add the cyberbattle folder to your path in your notebook (it's located in the root directory of the repo)
Run pip3 install -e CyberBattleSim one folder outside the repo.

Thank you for this! The second option seemed to fix it however I now run into another error on cell 15. The ValueError says 'mime type rendering requires nbformat>=4.2.0 but it is not installed' Even though I had 4.4.0 installed. I upgraded to 5.1.3 however the error still occurs. Any ideas?

@fcheong283 You want to run the init.sh script first to install all the required components.
For the second error you get, have you tried reinstalling ipykernel as suggested at https://stackoverflow.com/questions/66557543/valueerror-mime-type-rendering-requires-nbformat-4-2-0-but-it-is-not-installed ?

I have tried running the init.sh script however there's a syntax error in line 6:
pushd "$(dirname "$0")"
^
SyntaxError: invalid syntax

@fcheong283 Which shell are you using? Have you tried running it under the bash shell?

@fcheong283 I am closing it for now. Please try running the init.sh script from a Linux bash shell. If that stills reproes you can reopen the issue and share your logs/errors.


color-picker-swatch-only="true" does not work properly

On your demo site, the color-picker-swatch-only="true" shows only the swatch, but when I use the latest version, the text label remains visible
tested on version 0.6.6

Thanks for reporting the issue. I did break it in the v0.6.6 release. Fixed in commit 9bcefba92e1bbf6309fe51376d53c2a0f84cc48a and released in v0.6.7


Remove Ubuntu 12.04 support

The seed repo doesn't actually have packages for Precise, but the declared support for it means we run all our tests again unnecessarily.

:+1:


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter discord for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.discord
   -
ERRORS:

[X] :heavy_exclamation_mark: [E124] Main file not found under URL: https://raw.githubusercontent.com/crycode-de/ioBroker.discord/main/build/main.js
[ ] :heavy_exclamation_mark: [E157] js-controller 4.0.0 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.

WARNINGS:

[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.
[X] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W505] setTimeout found in "build/main.js", but no clearTimeout detected

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 20 Sep 2024 02:31:40 GMT based on commit 9b7a98b2d50a02a6aad53cf3b0652473ecd1aacb
ioBroker.repochecker 3.0.7

This issue has been updated by ioBroker Check and Service Bot
The following issues are new and have been added
[E124] Main file not found under URL: https://raw.githubusercontent.com/crycode-de/ioBroker.discord/main/build/main.js

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[E124] Main file not found under URL: https://raw.githubusercontent.com/crycode-de/ioBroker.discord/main/build/main.js
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.

@iobroker-bot recheck


fix(TDI-38560): Fixed handling of property values in runtime

What is the current behavior? (You can also link to an open issue here)

NetSuite incorrectly handles 'account' property value in runtime

What is the new behavior?

NetSuite correctly handles 'account' property value in runtime, it allows to specify value as string and as number

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[X] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information:
JIRA issue: https://jira.talendforge.org/browse/TDI-38560

Pull request test result: success :star:


Exception when the database is non-existant

Letting the exception be raised will break most tasks, including rake db:create

I’m going to close this issue since I don’t think this use case is very common.

lol. You can't even run rake db:migrate on CI but sure.


gmcrouter crash

gmc-router v0.7 docker hub image results in deployment failure but can be successfully deployed with source code build.

currently the opea/gmcrouter:latest has the problem, update the image will fix this


Check links

Release Playbook

[ ] Rebase against master
[ ] Code review
[ ] Merge into master
[ ] Verify changes at http://site-staging.convox.com
[ ] Promote release on site-production in the convox/production Rack

Check entire site with a 404-finder tool, update all broken links.
Note: There's a lot of links to grid.convox.com; I'm not sure what to do about those.
Also, there's a ton of broken links in the blog posts.

 Broken links on site


package.json is copied to the output directory

package.json and package-lock.json files are copied to the output (bin/Debug/net6/) directory when npm run start is executed. They are also copied to the dist/ directory when npm run build is executed.
This produces an unnecessary clutter in the VSCode NPM Scripts section:

Is there any need for these files to be in the output folder? Can they be excluded from the build?

Oh, we no nedd the package.json in the output directory

Oh, we no nedd the package.json in the output directory

Good to know, I will take a look how it can be excluded from the build, then.


Update TestPyPi workflow

Follow-up to #3358
The TestPyPi job still uses the token approach

This should be up-for-grabs if someone has the necessary five minutes, but I would say please feel free to take it yourself

This should be up-for-grabs if someone has the necessary five minutes, but please feel free to take it up yourself is what I would say

I will take this one @prady0t

@kratman are you still on this? If not I can take it up?

@casualPhysics Yeah I am still going to do this task


docs: Switch to StackPath's URL for the CDN.

While the old one will keep working, better switch to the new one.
@jdorfman: I'm thinking we should first do the related changes on BootstrapCDN and then start using the new URL. It might be confusing otherwise to some people.

All right, I made https://github.com/MaxCDN/bootstrapcdn/pull/988, so when we merge and deploy, we can merge this one here too.

@mdo: this shouldn't have been merged yet.


function name is not being hygienically renamed in some situations

I ran across this while playing with @jlongster's es6-macros:
let f = macro {
	rule { $params $body } => { $params $body }
}
let function = macro {
	rule { $name $params $body } => {
		function $name f $params $body
	}
}
function foo(x) {x}
// --> no renaming for `foo` or `x`!
function foo(x) {
    x;
}

I suspect what is happening is that the function is not being enforested as a function term tree because it doesn't match the pattern of a function before the f macro is expanded.
I think the right solution here is to disallow macros that appear in odd positions like this (where it splits a primitive form). Similarly you shouldn't be allowed to put a macro in the middle of an if statement: if m (cond) { body }.

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.


chore: add more gcongr attributes

This PR tags (analogues of) lemmas tagged with mono also with gcongr.

Thanks for your fixes! They look good to me. If you agree with my changes, the could maintainer merge this one "together" :-)

I agree with your changes 😄
maintainer merge

(Last commit also LGTM.)

Please fix the build

Fixed now (thanks, Yael!).

Cleaning up after a bors crash.
bors r+


Is have the public result website?

Can i upload the result when the test finish?

No, there's no public results web site.  If you want to put your results in BigQuery, you can display them with PerfkitExplorer.


Preliminary dark mode support

TODO:

[ ] Make button less ugly
[ ] Move the button downwards slightly so it's not right next to the top of the page
[ ] Make the dark mode consistent across all pages

Preview is available at https://meghan06.github.io/docs/

@meghan06 Make dark standard, mode better. Sorry Translator used bad English.


Use "Content-Type" headers to parse response

There has been a few cases where relying on a static expected response type is problematic. @SammyK mentioned that Facebook is inconsistent between API versions, so we added a dynamic way to get the response type in #301.
This pull request takes that one step further, and determines the response type by looking at the content-type headers returned by the response. I believe that this is more reliable and allows handling of API's / hosts that send multiple content types (for example Reddit sending image/png for some endpoints).

Makes sense to me. I would suggest squashing your two commits into one.

Okay will do.


Added a contributing guide and vs2017 related files.

Like I commented in #102 the information written in README.md is far from enough to get others started on this project. I guess that's why most PRs only come from the maintainers.
By adding a contributing guide and a VS2017 specific batch file, I expect that at least people like me can now help debug/fix simple issues and send you PRs.
I have to leave a few TODOs in the doc, as I don't have VS2012/2013/2015 any more. Others can later fill the gaps if they like.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

FYI finding this PR allowed me to actually fix a bug that was blocking me from using this tool. Thanks for the docs, worked perfectly.


Add ExecuteStoreSql extension method to RelationalDatabaseFacade

Adding new extension for #1863

Could I have you take a look at this one @AndriySvyryd ?

:shipit:


Created API

Made it into an API so that developers can more easily adopt this typing method into their app.
Basically there is a single function exposed void tertiary_text_prompt( const char* title, TertiaryTextCallback callback, void* extra );
It opens a Tertiary Text window (with the title supplied at the top of the window) and allows input. Once the user holds select that input is send to the provided TertiaryTextCallback function along with the supplied 'extra' data.

Thank you! This will come in handy. :)
I will be revising the documentation over the next few days.


New features

https://github.com/PowerOfUniverse/Surviv.io-Cheats
You should take a look at this repo
There is some interessting features 👍

Auto open doors
Switch weapons by right clicking
Switch to fist by pressing E

I used to use that one and now on this new one i cant switch the guns as fast as before because i cant right click to change weapons

To the last two, scroll down this issue for how to accomplish those #49


Deleting digits in the middle of a number can be confusing

Say you have typed the number<PHONE_NUMBER> but then you realised you made a mistake in the 3rd digit, so you go back and delete it, you get (704) 181-234. Should it be (70) 418-1234? But that wouldn't work if they had accidentally typed an extra digit that they just wanted to get rid of.
Other solutions: try to keep the formatting somehow - insert an X or a space in the place of missing digits? Same problem if you just wanted to go back and delete an extra digit.
Or: add a timeout which is reset every time you hit delete/backspace, but when it hits a threshold (maybe 1 second?) it only then does the re-format.
Again with this issue: we need to decide if it's worth the extra filesize for this edge-case feature.

After thinking about this for some time, I don't think it's worth the additional filesize to worry about potential small confusions like this.


Release 0.12.2

fixes #142

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage     75.61%   75.61%
  Complexity      259      259
=========================================
  Files            48       48
  Lines           849      849
  Branches         40       40
=========================================
  Hits            642      642
  Misses          183      183
  Partials         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6526416...f727b20. Read the comment docs.

👍

:+1:


howard-hinnant-date: CMake configuration points to out instead of dev for includes

Describe the bug
I'm trying to use howard-hinnant-date from a CMake project. Its build fails because the include (.h) files are under a prefix which is not referenced from the installed CMake config file. Removing the outputs = [ "out" "dev" ]; fixes this bug.
Steps To Reproduce
Steps to reproduce the behavior:

download CMakeLists.txt and yay.cpp (might need removing the trailing .txt on github)
store them into, say, ~/temp/nix-howard-date
get a nix-shell -p cmake howard-hinnant-date
try to build via cmake ~/temp/nix-howard-date

Here's how it fails on my NixOS:
$ nix-shell -p cmake howard-hinnant-date
$ rm -rf xx; mkdir xx; cd xx; cmake ~/temp/nix-howard-date
-- The CXX compiler identification is GNU 10.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/pja9g36cy32z3d51942jqk91a6l2d5nv-gcc-wrapper-10.3.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Configuring done
CMake Error at CMakeLists.txt:5 (add_executable):
  Cannot find source file:

    /nix/store/wjkxpmp3x7rg7zl6apsl6v4h6pjif3sr-howard-hinnant-date-3.0.1/include/date/date.h

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
  .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

CMake Error in CMakeLists.txt:
  Imported target "date::date" includes non-existent path

    "/nix/store/wjkxpmp3x7rg7zl6apsl6v4h6pjif3sr-howard-hinnant-date-3.0.1/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

I think that this is similar to, e.g., #97534 and that not splitting the output into several packages will help.
Notify maintainers
maintainer: @r-burns
cc: @jtojnar (is the upstream package using CMake properly?)

Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.24, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.6.1`
 - channels(root): `"nixos, nixos-21.11-21.11"`
 - channels(jkt): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

$<INSTALL_INTERFACE:include> should be $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}> in https://github.com/HowardHinnant/date/blob/9ea5654c1206e19245dc21d8a2c433e090c8c3f5/CMakeLists.txt#L66

https://github.com/HowardHinnant/date/blob/9ea5654c1206e19245dc21d8a2c433e090c8c3f5/CMakeLists.txt#L122 as well

This was probably fixed by #199323. The example passes on NixOS 23.05, x86_64-linux:
[user@host:~/test/uu]$ nix-shell -p cmake howard-hinnant-date
[nix-shell:~/test/uu]$ mkdir build && cd build
[nix-shell:~/test/build]$ cmake ..
-- The CXX compiler identification is GNU 12.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/lcf37pgp3rgww67v9x2990hbfwx96c1w-gcc-wrapper-12.2.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: ~/test/build
[nix-shell:~/test/build]$ make
[ 50%] Building CXX object CMakeFiles/yay.dir/yay.cpp.o
[100%] Linking CXX executable yay
[100%] Built target yay
[nix-shell:~/test/build]$ ./yay
[nix-shell:~/test/build]$ echo $?
0


[Feature Request]: Icon Colors

Description
Can you add a subtle tint to the toolbar icons in dark mode to match Chrome's color scheme?
Also, the following is unrelated, but I want to move my icon/searchbar closer to the top of my screen.
Is this something I can do in my custom.css file?

Additional info (Optional)
1.31.0
MacOS 15.0.1

Check it out in the latest version.

Is there any way to change the color of these icons

Is there any way to change the color of these icons

Yes, try these variables: --md-icon-color-primary or --md-icon-color-secondary


UX Improvement: Downloading/ Uploading files

One bug and 2 improvement suggestions:
Bug: When downloading from the shell (and likely the log tab too but did not test that specifically) - the formatting is messed up:

Improvement suggestion:
It wasn't immediately clear to me that the "Download File" button (on the SHELL tab) downloads CLI output from the provider and allows saving it locally - I tended to think that the button let's me download files on to the provider (since I am SSH'ed into the provider at the time) - in other words I thought this was an "upload function" - could be just me though :) -- this brought up two things in my mind:

Should we rename the buttons to "Save CLI Output Locally" or something?
Should we offer an easy upload function? - in my case, I was experimenting with ComfyUI and needed to upload checkpoint files, VAE files and Upscaler files to 3 different sub directories on the provider. The process was to cd into each and use wget. Having a way to hit a button, enter the destination (or better still have a navigable UI) and select the file(s) to upload from the local file system, might be helpful.

Improvement have been done in #36 to try and make it more clear.

Improved error handling, should no longer stay in the "Downloading..." state forever when an error happen.
Added validation to the input to indicate that a valid file path is required and not an url.
Added a "Experimental feature" warning since it can still be a bit buggy in some cases.

Thanks @Redm4x! - still working on upload feature, I assume?


TransPowerBase: correct path to java files

The path TransPowerBase/src does not exist.
Changing it to point at ../common/src like how it is done for LOCAL_RESOURCE_DIR makes the app build.

@jzoran

Thanks for catching this. It's an omission on my part during release, but it requires a bit more massaging than adding correct path. Could you, please, submit an issue? I'll take care of it first thing Monday. (We're on holiday here till Monday.)

sure :)
https://github.com/sonyxperiadev/transpower/issues/4

Hi, I've made a symlink in TransPowerBase/src -> ../common/src. I was trying to build bootimage, so I guess I don't need the apk. Thanks for the suggestion, ugly but did the trick. :)


[only test]Pipeline x test2

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


fix: iOS async popup

📦 Pull Request
[Provide a general summary of the pull request here.]
Fix iOS Async popup (ref: https://www.lexo.ch/blog/2021/08/fix-how-to-use-window-open-in-safari-inside-async-call/#:~:text=Safari blocks any window.,that a popup gets blocked.)
✅ Fixed Issues

[List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions
[Describe any additional context required to test the PR/feature/bug fix.]
⚠ Don't forget to add a semver label!
Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

patch: Bug Fix?
minor: New Feature?
major: Breaking Change?
skip-release: It's unnecessary to publish this change.

Special Note
Please avoid adding any of the Priority labels as they conflict with the labels above ☝

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:


fix typo also in .mo file

the previous fix does not modify the .mo file, so actual 0.4.5 version still shows the wrong translation.

Thanks, recompiled in https://github.com/django-import-export/django-import-export/commit/3324413c53da043c3736376d3c406bf39c5b989c


Add dockerfile

Add docker to be used with docker nvidia 2.  This allows to use ROS kinetic if you are working from ubuntu 18.04 (for example)

I am really sorry, I wanted to create this PR to our fork. If you are insterested in using the setup, please feel free to re open it.


Please provide Example that uses the Identity Parameter

As Title - Please provide Example that uses the Identity Parameter

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed0dce05-8bfd-0bfa-3753-0eb193852703
Version Independent ID: 50e0366c-46b0-71da-b6f6-f422adaad785
Content: Connect-MicrosoftTeams (MicrosoftTeamsPowerShell)
Content Source: teams/teams-ps/teams/Connect-MicrosoftTeams.md
Service: teams-powershell
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

Hello @kilasuit Ryan, how are you? hope you are doing good 👍
I have been digging into this, it seems that currently, the -Identity parameter is not ready, the team behind the module is working on this and, as soon as it is, I'll update the article including an example using the -Identity parameter.
Thank you

@pupara Please help us in resolving this issue. Thanks

@pbafna03 @get-itips Kindly address this issue. Thanks

@pbafna03 @get-itips Please comment. Thanks

It is only supported for non *-Cs cmdlets till now.

@get-itips

It is only supported for non *-Cs cmdlets till now.

Thanks @pbafna03 as that is already noted in the description, I think adding an example that will not work for *-Cs cmdlets is not the best at this time, when the functionality is extended for all the cmdlets, I'll propose an example. Thanks @kilasuit


Error in processing Gistic files

Hi,
I am using your awfully useful tools to visualize my CNV Data in Mac OS:
R version 3.4.3 (2017-11-30)
Platform: x86_64-apple-darwin16.7.0 (64-bit)
Running under: macOS Sierra 10.12.5

I run the following codes  to read my Gistic result,
mydata.gistic = readGistic(gisticAllLesionsFile = "res_cnv/all_lesions.conf_75.txt",
                         gisticAmpGenesFile = "res_cnv/amp_genes.conf_75.txt ",
                         gisticDelGenesFile = "res_cnv/del_genes.conf_75.txt",
                         gisticScoresFile = "res_cnv/scores.gistic.txt ",
                         isTCGA = TRUE)

but meet an error:
Processing Gistic files..
Processing amp_genes.conf_75.txt ..
Error in data.table::fread(input = gisticAmpGenesFile, stringsAsFactors = FALSE,  :
  File is empty: /var/folders/sp/m5bgx1hn1nx2pjvng7dw4n940000gn/T//Rtmp7i3XSB/file15575b5b15c2
sh: res_cnv/amp_genes.conf_75.txt: Permission denied

I have checked the permission of amp_genes.conf_75.txt, It is rw-rw-rw. And it is not an empty file.
Thanks in advance.

Hi,
Is the file empty ?
Can you try read amp_genes.conf_75 with read.table or similar function and see if you still have this error ?
P.S: any reason why you find the package awful ? It will help me to improve it.

No problem :)
Did you try reading amp_genes.conf_75.txt with read.table function ?

Yes, I can read the file. with following code :
mydata.amp_genes <- read.table("res_cnv/amp_genes.conf_75.txt", sep = '\t')
dim(mydata.amp_genes)
[1] 322  52

head(mydata.amp_genes)
                    V1                     V2                       V3                       V4
1             cytoband                 6p22.3                   8q22.3                   1q23.3
2              q value             1.1204e-76                1.417e-46               1.9537e-50
3     residual q value             5.0412e-74               1.5074e-43               2.1374e-37
4 wide peak boundaries chr6:21561062-21645511 chr8:100842877-100880377 chr1:161062362-161105116
5   genes in wide peak                   SOX4                  [YWHAZ]                    PFDN2
6                                                                                NECTIN4

Here is the file.
res_cnv.zip

Hi,
Sorry for the delay, I tested your files and I have no problem processing them.
Maybe post your sessionInfo after loading maftools ?

I used the res_cnv.zip data to test, and get similar error
> library(maftools)
> mydata.gistic = readGistic(gisticAllLesionsFile = "all_lesions.conf_75.txt",
+                            gisticAmpGenesFile = "amp_genes.conf_75.txt ",
+                            gisticDelGenesFile = "del_genes.conf_75.txt",
+                            gisticScoresFile = "scores.gistic.txt ",
+                            isTCGA = TRUE)
Processing Gistic files..
Processing amp_genes.conf_75.txt ..
Processing del_genes.conf_75.txt..
Processing scores.gistic.txt ..
'scores.gistic.txt' 不是内部或外部命令，也不是可运行的程序
或批处理文件。
Error in data.table::fread(input = gisticScoresFile) :
  File is empty: C:\Users\wangshx\AppData\Local\Temp\RtmpENLxqX\file294c6f6918e6
In addition: Warning message:
In (if (.Platform$OS.type == "unix") system else shell)(paste0("(",  :
  '(scores.gistic.txt ) > C:\Users\wangshx\AppData\Local\Temp\RtmpENLxqX\file294c6f6918e6' execution failed with error code 1

This seems related to system created the files.
> sessionInfo()
R version 3.5.0 (2018-04-23)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1

Matrix products: default

locale:
[1] LC_COLLATE=Chinese (Simplified)_People's Republic of China.936
[2] LC_CTYPE=Chinese (Simplified)_People's Republic of China.936
[3] LC_MONETARY=Chinese (Simplified)_People's Republic of China.936
[4] LC_NUMERIC=C
[5] LC_TIME=Chinese (Simplified)_People's Republic of China.936

attached base packages:
[1] parallel  stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] maftools_1.6.07     Biobase_2.40.0      BiocGenerics_0.26.0

loaded via a namespace (and not attached):
  [1] nlme_3.1-137                bitops_1.0-6                matrixStats_0.53.1
  [4] cmprsk_2.2-7                bit64_0.9-7                 httr_1.3.1
  [7] progress_1.1.2              doParallel_1.0.11           RColorBrewer_1.1-2
 [10] GenomeInfoDb_1.16.0         tools_3.5.0                 R6_2.2.2
 [13] DBI_1.0.0                   lazyeval_0.2.1              colorspace_1.3-2
 [16] GetoptLong_0.1.6            prettyunits_1.0.2           gridExtra_2.3
 [19] mnormt_1.5-5                bit_1.1-12                  compiler_3.5.0
 [22] DelayedArray_0.6.0          pkgmaker_0.22               slam_0.1-43
 [25] rtracklayer_1.40.2          scales_0.5.0                survMisc_0.5.4
 [28] psych_1.8.4                 NMF_0.21.0                  stringr_1.3.1
 [31] digest_0.6.15               Rsamtools_1.32.0            foreign_0.8-70
 [34] XVector_0.20.0              pkgconfig_2.0.1             changepoint_2.2.2
 [37] BSgenome_1.48.0             rlang_0.2.0                 GlobalOptions_0.0.13
 [40] RSQLite_2.1.1               shape_1.4.4                 bindr_0.1.1
 [43] zoo_1.8-1                   mclust_5.4                  BiocParallel_1.14.1
 [46] dplyr_0.7.4                 VariantAnnotation_1.26.0    RCurl_1.95-4.10
 [49] magrittr_1.5                GenomeInfoDbData_1.1.0      wordcloud_2.5
 [52] Matrix_1.2-14               Rcpp_0.12.16                munsell_0.4.3
 [55] S4Vectors_0.18.1            stringi_1.1.7               yaml_2.1.19
 [58] SummarizedExperiment_1.10.1 zlibbioc_1.26.0             plyr_1.8.4
 [61] blob_1.1.1                  grid_3.5.0                  ggrepel_0.8.0
 [64] survminer_0.4.2             lattice_0.20-35             cowplot_0.9.2
 [67] Biostrings_2.48.0           splines_3.5.0               GenomicFeatures_1.32.0
 [70] circlize_0.4.3              knitr_1.20                  ComplexHeatmap_1.18.0
 [73] pillar_1.2.2                ggpubr_0.1.6                GenomicRanges_1.32.2
 [76] rjson_0.2.18                rngtools_1.2.4              biomaRt_2.36.0
 [79] reshape2_1.4.3              codetools_0.2-15            stats4_3.5.0
 [82] XML_3.98-1.11               glue_1.2.0                  data.table_1.11.2
 [85] foreach_1.4.4               gtable_0.2.0                purrr_0.2.4
 [88] tidyr_0.8.0                 km.ci_0.5-2                 assertthat_0.2.0
 [91] ggplot2_2.2.1               gridBase_0.4-7              xtable_1.8-2
 [94] broom_0.4.4                 survival_2.42-3             tibble_1.4.2
 [97] iterators_1.0.9             GenomicAlignments_1.16.0    AnnotationDbi_1.42.1
[100] memoise_1.1.0               registry_0.5                IRanges_2.14.8
[103] KMsurv_0.1-5                bindrcpp_0.2.2              cluster_2.0.7-1


Goals

What does this do, or what will it do? Is this project still alive?

@mysterlune I am going to be needing pdfjs functionality soon. This addon seems to be in its's infancy and has not been committed to for 3 months.
I'd much prefer we combine efforts rather than have two separate addons with the same intentions.
What are your plans here?  Are you planning on actually maintaining this repo?
If I start contributing to it extensively, will you be around to review and merge PR's?
/cc @knownasilya

Yes. I'm very much in favor of collaborating on this. I have not had a lot of time to focus on this in the last few months, though prior to that my research into using PDFJS with Ember was primarily exploratory.
I've experimented using PDFJS to render a pdf into an Ember ListView (and have faced some challenges keeping my skunkworks project up-to-date as that project has undergone heavy development). I would be interested in your thoughts on ways that we could optimize the rendering of pdfs (whether in a list or a "paged" orientation) into Ember views or components. ListView seemed like a great starting point, though the goals of that project seem a bit thin for supporting something like a pdf.
I am very interested in making something useful here.
Basically my goals for this project are to:

supply a template/component that uses the src for a pdf resource
render the pdf (lazy-optional) into a list of pages (canvases)
provide interactivity for highlighting the "hidden" text
as a bonus, I'd like to be able to have active links in a pdf remain active (whether linking to an external resource or a section within the same document (which will probably be harder than it initially sounds))

My organization's instructor/student client application provides rich interactivity for documents currently (highlighting, inline and bubble comments, capturing audio feedback, decorating with human and machine feedback on submitted works). It's pretty amazing stuff, and rather specialized in terms of features. It's in no way a simple "reader" application.
I'd like to hear what you are working on, and what you think this addon could benefit from.

Go components all the way, views are "going away" for 2.0.

(nods)

In this addon project, there is a set of components that all should be implemented in a way that allows for flexible UI composition. For example (though this is not a complete list, but what I have in mind for a start), in addition to the pdf-document component, also a pdf-pagination, pdf-find (or pdf-search?) and pdf-print-download components. Basically, the set of features PDFJS's own viewer implements, but built as Ember components that tie together with the EventBus injected as a dependency for messaging events to all participating pdf-* components.
In this way, a consumer of this addon could put the pagination component anywhere in the layout -- since we'll use dependency injection to share the EventBus with the document component. A search box (pdf-find [or -search?] could be placed by the pagination in a footer -- or in the header, side panel, or the top of a thumbnail list view…).
An admirable example of this kind of component addon is https://github.com/bustlelabs/ember-mobiledoc-editor. This one is for Mobiledoc Kit what ember-pdfjs should be in the end for PDFJS. The component structure allows you to compose a layout in a very flexible way. The trick the project solves elegantly is inter-component messaging. This is done in the ember-mobiledoc-editor project by ensuring that participating components (the toolbar or layout cards) are passed the editor object as an argument.
The addition of the EventBus object to the PDFJS library adds pub/sub/event-management feature. the EventBus was implemented to provide centralized messaging across the PDFJS viewer and libraries.
It does feel that PDFJS is the primary source of interactivity with the pdf object, which makes the role of Ember much more about "how do we lay out toolbars, side panels, thumbnail scroll views, etc" than it does about "how do we compose rich components to use within a PDFJS viewer context. Prior versions of ember-pdfjs seemed to try to lift the DOM and pdf management out of PDFJS and into Ember-land in a way that was off direction.
You will see in the latest version (v0.4.0) that I've update the ember-pdfjs addon to support the later version(s) of PDFJS including the EventBus, and have all but ripped out the old way of rendering individual pages for the document (component-within-component style rendering) which forced us to do suboptimal list handling in order to manage the DOM outside of PDFJS.
The Ember part really should be about layout, routing, adaptation to the service backend, dependency injection. As much as possible, I believe PDFJS's UI libs should do the lifting for in-document elements (like anchors, highlight, possibly annotations?)
I think there is discussion to be had about where Ember components vs PDFJS-managed DOM objects fit.

@collegeimprovements, @DarrenDrumm, I'd like to know if you have any comment as to whether this project's goals are in alignment with your project.
Please leave your comments here, or file an issue. I'd be happy to work with you to ensure the goals of this project encompass yours.


TypeError: dtype '<class 'pandera.dtypes.Float128'>' not understood

I installed these tools via $ pip install gwas-sumstats-tools on macOS. I tried to run gwas-ssf validate but got the following error:
$ gwas-ssf validate outfile.txt

Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/pandera/engines/pandas_engine.py", line 160, in dtype
    return engine.Engine.dtype(cls, data_type)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pandera/engines/engine.py", line 217, in dtype
    raise TypeError(
TypeError: Data type '<class 'pandera.dtypes.Float128'>' not understood by Engine.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/homebrew/bin/gwas-ssf", line 5, in <module>
    from gwas_sumstats_tools.cli import app
  File "/opt/homebrew/lib/python3.11/site-packages/gwas_sumstats_tools/cli.py", line 13, in <module>
    from gwas_sumstats_tools.validate import validate
  File "/opt/homebrew/lib/python3.11/site-packages/gwas_sumstats_tools/validate.py", line 7, in <module>
    from gwas_sumstats_tools.schema.data_table import SumStatsSchema
  File "/opt/homebrew/lib/python3.11/site-packages/gwas_sumstats_tools/schema/data_table.py", line 15, in <module>
    class SumStatsSchema:
  File "/opt/homebrew/lib/python3.11/site-packages/gwas_sumstats_tools/schema/data_table.py", line 41, in SumStatsSchema
    'p_value': Column(Float128, [
               ^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pandera/schema_components.py", line 88, in __init__
    super().__init__(
  File "/opt/homebrew/lib/python3.11/site-packages/pandera/schemas.py", line 1772, in __init__
    self.dtype = dtype  # type: ignore
    ^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pandera/schemas.py", line 1880, in dtype
    self._dtype = pandas_engine.Engine.dtype(value) if value else None
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pandera/engines/pandas_engine.py", line 178, in dtype
    np_or_pd_dtype = pd.api.types.pandas_dtype(data_type)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/pandas/core/dtypes/common.py", line 1702, in pandas_dtype
    raise TypeError(f"dtype '{dtype}' not understood")
TypeError: dtype '<class 'pandera.dtypes.Float128'>' not understood

has there been any development on this issue?
I am experiencing something very similar, except I am not even able to get gwas-ssf to print the help function.
I am commenting on this issue as I suspect it may be the same underlying issue.
If you need me to provide any information please let me know.

We will investigate whether we can replicate this locally. In the meantime could you try running in Docker?

I found it a bit difficult to use docker on Windows.
Do you know any good tuto for it?

Having the same issue here (also windows if that helps)

Apologies for the delay in fixing this issue while we await recruitment of a new staff member. In the meantime, if you are unable to validate your files please contact<EMAIL_ADDRESS>and we will be happy to support you further.

I appreciate the offer and good luck with recruitment.
I have had to use a linux based system (the HPC cluster I work on) to validate the sumstats there, as I was unable to get it to work on my local (windows) machine. On the linux system, it work with any problems. However, I still hope the issue for windows can be solved in the future.