The separate indexing and alignment interface.

Related to  #59 but wasen't sure if I should post it there or create separate issue, went with the latter.
I was just attempting to benchmark commit ddf90e5 but ran into a snag.
First, it took me a while to figure out that --use-index takes the ref.fasta and infers if a ref.fasta.sti is present and use it. It complains if --use-index ref.fasta.sti is provided with  the error message strobealign: FASTA file must begin with '>' character, not 'S'. I guess the confusion came from the documentation
reference     A pregenerated strobemers index file (.sti) or a reference in FASTA
                    format

Second, and more pressing, one advantage with the old interface of naming the index file manually is if we have indexes for different read lengths we name and use them as -i ref.fa.100.sti --use-index ref.fa.100.sti and so on (which is e.g. how my previous benchmarks were set up for the old interface). The limitation with the current is that we could have at most one index present with the current interface.
Third, a small issue is that the current version creates an index without complaining if -i ref.fa is specified without -r or read files. This generates a default 150bp index but it is not ideal.
The more pressing of these three items is number 2, as I would prefer not to redesign the benchmark rules again. I think it is kind of neat to have the indexing and alignment in separate rules for easy measure of peak memory etc. Should we either:

Name the indexes by appending the inferred read length like  -r 100 -i ref.fa would automatically yield an index file ref.fa.100.sti. A slight problem with this is when read length is inferred from reads. It would then be better to append the read length in some of the boundary conditions of the if statements controlling the ranges and check if they are equal for the provided reads and pre-generated index.
Or revert/revise to previous interface where -i requires a manually specified .sti file name

The first problem (documentation) is on my to-do list (I have a separate list with small things that I didn’t want to post as issues here). I have submitted PR #134 as temporary workaround for the second issue. This is mentioned in #109, but we should possibly split it out. The third issue (index can be created without -r) is tracked in #109.

Name the indexes by appending the inferred read length like  -r 100 -i ref.fa would automatically yield an index file ref.fa.100.sti. A slight problem with this is when read length is inferred from reads. It would then be better to append the read length in some of the boundary conditions of the if statements controlling the ranges and check if they are equal for the provided reads and pre-generated index.

Hi, I’m working on this at the moment. I’m not sure I understand the last sentence, but I think what you mean and what I thought in any case was that strobealign would only create one of six different indexes depending on read length. So for example, for any read length between 76 to 125, the output would always be ref.fa.100.sti.
100 represents the middle of that range and I call it "canonical read length" in the code.
I noticed that at the moment, the indexing parameters differ because the max_dist indexing parameter is directly derived from the read length (as read_length - 70). So one index created with -r 101 would not be usable with -r 100.
I don’t think indices created with different max_dist settings are really compatible, or are they? If not, we would need to change this so that max_dist is computed not from the actual read length, but from the canonical one. So for read lengths 76 to 125, it would always be 100-70=80 (or perhaps a bit higher?). What’s your opinion?

I’m not sure I understand the last sentence

Not sure what my sentence was supposed to say. But I have the same conclusion as you. We would name the index to whichever of the six(?) classes of seed parameters the read dataset was assigned to.

I noticed that at the moment, the indexing parameters differ because the max_dist indexing parameter is directly derived from the read length (as read_length - 70). So one index created with -r 101 would not be usable with -r 100.

Oh good catch.. It depends on how often the set of downstream syncmers (to link) span over max_dist. I don't remember how often that occurred, but I don't think it was too often. If a syncmer occur every 5th base on avg and the sampling window of the second syncmer is [6,12] syncmers downstream, they would (on average) be on positions [30,60] downstream. Some outliers may cause max_distto be hit.
As you say, with different max_dist,  the extracted seeds may differ in some regions when: (i) max_dist is active due to set of downstream syncmers too sparse ,and (ii) the linking also chooses the end syncmer to link with which with different max_dix may be different.
This gets worse the further away the read lengths are in the same class. For example, -r 76 may hit max_dist much more often than  -r 125, hence more different seeds, compared to -r 100 vs  -r 101 which I guess would be near identical.

I don’t think indices created with different max_dist settings are really compatible, or are they?

So per above, you are right. They are not.

If not, we would need to change this so that max_dist is computed not from the actual read length, but from the canonical one. So for read lengths 76 to 125, it would always be 100-70=80 (or perhaps a bit higher?). What’s your opinion?

This is tricky. A change to this will definitely cause a change in the results, for the better or worse. I did not benchmark this much, so there could be room for improvement with a bit of testing. Of course, the way it is currently set is more dynamic, so I guess setting a good canonical max_dist it is about minimising losses for some read lengths.
I think 125 and 150 are pretty common read lengths(?), if so could be worth setting parameters favourable to those lengths. Unfortunately I don't have a good guess. Would require some testing.
As a general point (which I think you are also making here with your comment) is that strobealign should complain if any parameters affecting the seeding are different between index and what the user wants, including max_seed_len.

Thanks, this makes sense.
I’m happy the fruit fly dataset we’re using for testing has a slightly odd read length of 151 bp, otherwise I may not have noticed that this problem exists ...
On the 100'000 fruit fly reads, the alignment results change a tiny bit when we force the read length to -r 150 instead of letting it use 151:
      18059 reads were unmapped before and after
*         3 reads became mapped
*         2 reads became unmapped
     172539 reads were mapped to same locus before and after
*      6620 reads were multimapper before and after, same alignment score (AS)
*        25 reads were multimapper before and after, better alignment score (AS)
*        27 reads were multimapper before and after, worse alignment score (AS)
*      2725 reads changed in another way
     200000 total reads

As discussed previously, the large number of "reads changed in another way" is (I’m sure) just due to a different sort order.
To get an idea of the effect on accuracy, I did something similar for the CHM13 150 bp dataset by running strobealign on it with different settings for the read length and got these numbers:

-r 126: 94.1444
-r 150: 94.1317
-r 175: 94.14615

Admittedly, this is the "wrong direction", that is, we check "reads have 150 bp but we use a max_dist appropriate for a different read length". What we should check is "reads have different read length but max_dist would be appropriate for 150 bp". But I think it still conveys that the effect should be minor.

What stands out is 2725 reads changed in another way. I would hope that only (or near only) multimapping reads would change, but this column refers to reads that are not multimappers and still change something, right? Do you know what is going on with those reads?

This number is similar to what the comparison script reports for the switch to pdqsort and also #191.
It looks a bit alarming because I ran the script on a dataset for which I don’t have the truth (I need to change that). So these "other changes" can be both "became incorrect" and "became correct" (and also "was not a multimapper, but should be one" or similar).  Here is how the report looks for CHM13 (2x150) when I use it to compare -r 150 ("before") with -r 126 ("after") and also provide the truth:
       2250 reads were unmapped before and after
*         8 reads became mapped
*         5 reads became unmapped
    1921514 reads were mapped to same locus before and after
*     65906 reads were multimapper before and after, same alignment score (AS)
*      1022 reads were multimapper before and after, better alignment score (AS)
*       922 reads were multimapper before and after, worse alignment score (AS)
       6935 reads were incorrect before and after (relative to truth)
*       733 reads became correct (relative to truth)
*       705 reads became incorrect (relative to truth)
    2000000 total reads

Regarding accuracy: As long as the changes are in the order of 1 in 10,000 it's ok for me. I am assuming runtime could change also. Two notes on your check:
* I suspect differences will be larger for shorter reads, eg the range 75-125.

I can check that range as well.

* Also, I am always concerned about how this translates to repetitive genomes such as maize or rye. Although you did benchmark on CHM13 which should be complex enough.

I will run a test on rye.

Admittedly, this is the "wrong direction", that is, we check "reads have 150 bp but we use a max_dist appropriate for a different read length". What we should check is "reads have different read length but max_dist would be appropriate for 150 bp". But I think it still conveys that the effect should be minor.

Didn't get what you meant by this but maybe because I am switching between too many tasks today :)

Rephrased: The index is going to be created with, for example, r=150. We should test what happens when the actual read length is 175 (or 126). But I did something else: I created the index with r=126 and then tested what happens when the actual read length is 150. (Because it was easier that way.)

It looks a bit alarming because I ran the script on a dataset for which I don’t have the truth (I need to change that). So these "other changes" can be both "became incorrect" and "became correct" (and also "was not a multimapper, but should be one" or similar). Here is how the report looks for CHM13 (2x150) when I use it to compare -r 150 ("before") with -r 126 ("after") and also provide the truth:

I see, and from the numbers you reported it did not look like big changes (given 2M reads).

The index is going to be created with, for example, r=150. We should test what happens when the actual read length is 175 (or 126). But I did something else: I created the index with r=126 and then tested what happens when the actual read length is 150. (Because it was easier that way.)

Right, that makes perfect sense and I agree.


Limit the size of icyname and streamtitle when using an OLED display

Hello Edzelf
The length of the icyname and streamtitle provided by some Radio Stations is too big to be correctly show when using the supported OLED displays. This change limits the length of icyname to 42, and the streamtitle to 64 characters, when the user selects one of the supported OLED displays on the config.h
Possibly this could be done in a better way, but it works.
Rgs.
Werk_AG

Hopefully ES accepts my big commit.  It handles the overflow on tiny displays pretty gracefully.
Figured I'd message you here if you want to take a look at it.


Generate exporter_master_secret after server Finished

Fixes #4925
I'd like to start the discussion to make exporter_master_secret available after server Finished because it is required for QUIC development.
In this PR, I moved the creation of exporter_master_secret from client_application_traffic to server_application_traffic.  It works for me, but I have no idea it is really a correct fix.
In tls13_export_keying_material, I just removed !SSL_is_init_finished(s), but it may be too loose.
I think I should add another condition to prevent misuse, but I have not come up a good one.
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Did the requested nit fixes and pushed. Thanks.


As a drunk user, gendo should filter my requests

Use Case 1:
Request includes "image" and any term from our predetermined phallic dictionary
i.e. Drunk user enters "@gendo image me cat dicks", gendo responds "Go home  you're drunk"
Use Case 2:
Request includes a personal attack on your friends that slightly crosses the line
i.e. username is "alleycat" and request includes at least two typos

@allisonBrenner I think this should be an epic

Need hours estimate, thanks

+1


Re-pin EF dependencies

not shipping this time around
also bump a few versions to match newer 'release/2.1' dependencies

System.Diagnostics.DiagnosticSource
System.Security.Principal.Windows
System.Threading.Tasks.Extensions

I think you mean "Pin ef dependencies"

Customers not using standalone apps will get the latest from the shared framework i.e. roll-forward will help for the most part. Does that mean we don't need to rebuild Microsoft.AspNetCore.Server.HttpSys?
W.r.t . SharedFx: Assemblies for the 3 updated packages have file and product version 4.6.27818.2 in aspnetcore-runtime-2.2.6-win-x64.zip

seems newer than the 4.6.27818.1 versions in aspnetcore-runtime-2.1.12-win-x64.zip but it's hard to be sure


usb3.0 patch     thanks

can you add usb3.0 patch? ams since hos13, usb3.0 is not working, i found that by patching i can turn on usb3.0, installation speed 70MB/S in awoo, maybe i'm wrong, you can check it out, thanks for the guide, i didn't quite understand it yet.
This is hos version 14.0.0 -
PATCH magic：50  41  54  43  48
Offset： 00  76  34
Size of patch：00  08
Patch to be applied：20  00  80  52  C0  03  5F  D6
EOF magic： 45  4F  46
Sorry, I don't quite understand.

can you add usb3.0 patch? ams since hos13, usb3.0 is not working, i found that by patching i can turn on usb3.0, installation speed 70MB/S in awoo, maybe i'm wrong, you can check it out, thanks for the guide, i didn't quite understand it yet.
This is hos version 14.0.0 -
PATCH magic：50 41 54 43 48 Offset： 00 76 34 Size of patch：00 08 Patch to be applied：20 00 80 52 C0 03 5F D6 EOF magic： 45 4F 46
Sorry, I don't quite understand.

https://github.com/Atmosphere-NX/Atmosphere/blob/master/fusee/program/source/fusee_setup_horizon.cpp#L571-L590
https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/ams_mitm/source/set_mitm/settings_sd_kvs.cpp#L312-L315
https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/loader/source/ldr_patcher.cpp#L125-L142
https://github.com/Atmosphere-NX/Atmosphere/blob/master/stratosphere/loader/source/ldr_embedded_usb_patches.inc#L47-L55

Atmosphere already has code for this, no need for a separate patch.
the buildid for 14.x.x is 1C97AFF30D48AFFEB74B28A530D30ABA0ABB9FFF (according to atmosphere source code)
and the patch applied are (again, according to atmoshere source code, which includes usb 3 patches):
offset 007414; size 00 08, patch 20 00 80 52 c0 03 5f d6
offset 0074A4; size 00 08, patch 20 00 80 52 c0 03 5f d6

Thank you very much, 1C97AFF30D48AFFEB74B28A530D30ABA0ABB9FFF.ips took effect, however, need to enable usb30_force_enabled = u8!0x1 in system_settings.ini, thank you very much for the guide, thanks!

Well you don't need 1C97AFF30D48AFFEB74B28A530D30ABA0ABB9FFF.ips, all you need to do is enable it in system_settings.ini and place it in the atmosphere config folder.

If I just enable it in system_settings.ini and put it into config, it won't work and awoo installs at 40MB/S. Putting 1C97AFF30D48AFFEB74B28A530D30ABA0ABB9FFF.ips into atmosphere/esefs_ patches/, the installation speed of awoo is 70MB/S.

If I just enable it in system_settings.ini and put it into config, it won't work and awoo installs at 40MB/S. Putting 1C97AFF30D48AFFEB74B28A530D30ABA0ABB9FFF.ips into atmosphere/esefs_ patches/, the installation speed of awoo is 70MB/S.

I will consider generating them and distributing them if that is the case, if anything that sounds like an atmosphere bug

@lsp199308 https://github.com/borntohonk/SigPatches/commit/84e276a13152f2cc81ef3bc89b5b2059bc556c65
After reviewing the patches for 14.0.0, I came to notice that atmospheres 14.0.0 patches do not account for the 0x100 header that all other exefs ips patches account for, so
"50 41 54 43 48 00 74 14 00 08 20 00 80 52 C0 03 5F D6 00 74 A4 00 08 20 00 80 52 C0 03 5F D6 45 4F 46"
should be
"50 41 54 43 48 00 75 14 00 08 20 00 80 52 C0 03 5F D6 00 75 A4 00 08 20 00 80 52 C0 03 5F D6 45 4F 46"
usb build-id: 1C97AFF30D48AFFEB74B28A530D30ABA0ABB9FFF
usb offset and patch at:<PHONE_NUMBER>20008052C0035FD6 and 0075A4000820008052C0035FD6
could you verify that the new one gives you the correct speed?

@lsp199308 from what i can tell this patch should not fix usb 3 speed, as the patch must be applied earlier, which is what system_settings.ini is for

@borntohonk I'm very sorry, I may be wrong, was able to enable usb3 in ams1.3.2, I tested it this morning with the latest version of ams, only to find out that it is possible to enable usb3, I haven't upgraded ams,ams1.3.1 usb3 doesn't work. Sorry.
However, I hope you can keep the usb3 patch, thanks, very sorry

@borntohonk I'm very sorry, I may be wrong, was able to enable usb3 in ams1.3.2, I tested it this morning with the latest version of ams, only to find out that it is possible to enable usb3, I haven't upgraded ams,ams1.3.1 usb3 doesn't work. Sorry.
However, I hope you can keep the usb3 patch, thanks, very sorry

Yeah, I already added a patch generator for it, but from what I can tell, it's not needed, so I will not distribute the patches by default.


errors underlined in repl plus more news you can use

As promised.
$ ./bin/ergotop
Welcome to ERGOTOP version 0.1.2
ergo$ return 1 + 1  ;
[RuntimeError at line 1 col 7] Binary operation failed.
return 1 + 1  ;
       ^^^^^
ergo$

The refactoring here is that now both the compiler and the repl use the same string_of_error function, which is written in OCaml rather than in Coq. @jeromesimeon could you convert the compiler's code to use string_of_error_plus? You just need to give it the full source as the second argument so that it knows the string to underline. After that, we can delete the old string_of_error and rename string_of_error_plus to string_of_error. I'll then add better formatting (eg colorization iff stdout is a tty).

@kach Could you please open an issue about string_of_error_plus in compiler!

#324


updated to use juttle 0.7.0

no changes required since we're not using any built in filtering
features and instead checking for the simple appearance of the single
name=/~value in the filter AST.

@bkutil @demmer @dmajda easy enough to fix since graphite doesn't use any of the fancy filtering features and the tests passed.

+1
As part of the review I looked at the filter-processing code. It should still work with 0.7.x, but this condition could be improved a bit:
if (left && right) {
    if (left.name === 'name' && right.type === 'StringLiteral') {
        name = right.value;
    }
}

The left & right check is unnecessary (these will be always present in BinaryExpression). More importantly, it would be good to replace left.name === 'name' with left.type === 'Field' && left.name === 'name' to be more robust and future-proof (we may end up having other nodes in filters which have a name property).

@dmajda I'll fix that filter-processing code in this PR then before merging.


Ask for a question and wait for response based on that question.

Is there any way i can ask my bot a question and make it wait for a response to that particular question so i could do some more things on that particular message?

@Olamyy, yes there is!
Just call the .startConversation() method and then call convo.ask() inside of its callback function.
Quick (pizza) example:
controller.hears(['pizza'], 'message_received', function (bot, message) {
  // start a conversation to handle this response
  bot.startConversation(message, function (err, convo) {
    if (err) console.log(err)
    // start a question
    convo.ask('Did you just say pizza?', function (response, convo) {
      if (response.text === 'yes') {
        convo.say('I knew it! :D I want pizza. NOW!')
      } else {
        convo.say('Oh... okay. I thought I heard... nevermind, sorry :(')
      }
      convo.next() // always call this to keep things flowing (check the readme for more info)
    })
  })
})

Check out the Control Conversation Flow section of the readme.md for a better, more detailed explanation.
Hope this helps. :)

If you still have any questions please let us know!


Grid Layout has no contains param

On my path of creating a touch keyboard for the TFT Featherwing after laying out the keyboard saw there's no .contains param like there are for widgets and buttons.  Requesting contains add to grid layout or some advice on completing this with touch capability.

forkawesome_font = bitmap_font.load_font("/fonts/forkawesome-12.pcf")
# Quick Colors for Labels
TEXT_BLACK = 0x000000
TEXT_BLUE = 0x0000FF
TEXT_CYAN = 0x00FFFF
TEXT_GRAY = 0x8B8B8B
TEXT_GREEN = 0x00FF00
TEXT_LIGHTBLUE = 0x90C7FF
TEXT_MAGENTA = 0xFF00FF
TEXT_ORANGE = 0xFFA500
TEXT_PURPLE = 0x800080
TEXT_RED = 0xFF0000
TEXT_WHITE = 0xFFFFFF
TEXT_YELLOW = 0xFFFF00

def make_my_label(font, anchor_point, anchored_position, scale, color):
    func_label = label.Label(font)
    func_label.anchor_point = anchor_point
    func_label.anchored_position = anchored_position
    func_label.scale = scale
    func_label.color = color
    return func_label

hello_label_change_wifi = make_my_label(
    terminalio.FONT, (0.5, 1.0), (DISPLAY_WIDTH / 2, 15), 1, TEXT_WHITE)
input_change_wifi = make_my_label(
    terminalio.FONT, (0.0, 0.0), (5, 50), 1, TEXT_WHITE)
input_new_cred = make_my_label(
    terminalio.FONT, (0.0, 0.0), (100, 50), 1, TEXT_WHITE)

# Grid Layout Labels.
That's the gist of it.  Full code can be viewed on my Github which I've been working on daily.
Having grid layout the capability for touch contains would have made this much easier.  I'm all ears for ideas if there's a better way.

@DJDevon3 first of all, That's looking awesome :tada: Nice Job!
I think there are a few different ways this could work. Typically the contains() would only tell you True or False weather the given coordinates are within the bounds of the "View" object (be it a button or anything else that extends Control). With GridLayout you'd need something a bit different because you're wanting to discern which cell within the grid (if any) are located at the x,y coordinates given rather than just the True / False for the bounds of the entire Grid.
Theoretically a new kind of Label could be created that has a contains method (or contains() added to existing ones) and then your code could call contains on each label within the Grid to find out which one matches the coordinates.
Another option that wouldn't require any library modifications could be to use Buttons instead of Labels inside of your Grid cells. That way they will have a contains() function that you could call on each Button to determine which one matches the coordinates. I think you could set up the Buttons with transparent or black background and white label color so that they'll end up looking the same as a Label would visually.
With all of that being said I do think there is an opportunity for GridLayout to have a function that helps make this easier to achieve. I would opt for a name other than specifically contains() since it'll have different behavior (returning a cell instead of just True/False) So maybe somethying like grid_layout.which_cell_contains(x,y). You pass in the x,y coordinates and it returns either the cell that contains those coordinates or None if the point is outside all cells.

I can add a ton of spritebuttons but they weren't my first choice for RAM reasons.  There woiuld be about 100 of them plus 100 labels. While it would look nice, I fear the 1000+ other lines for displaying sensor data, weather API, MQTT, etc.. it wold be too much to handle.
Another method I thought about was a BMP background of a keyboard and adding touchpoint coordinates layered on top of the bmp.
You know the libraries the most intimately so I trust you to come up with a solution that benefits everyone and not just my use case.

I have previously successfully implemented SpriteButtons with a popup menu. I'm not unfamiliar with them.  Grid layout seemed the best method for the keyboard layout vs a ton of SpriteButtons. I know I can do it but also know it's going to take the page 30 seconds to load.  Before a new page loads the previous page must pop() or remove() the previous layers.  The more labels and images on the previous page the more time it takes to unload and then load the new layers.

@DJDevon3 Sorry, I did not mean to use Buttons instead of GridLayout, but rather Buttons with the GridLayout. Essentially using Button's inside of each cell of the Grid rather than a Label.
Anyhow, while I do think that route is possible. I do think there's opportunity for a GridLayout enhancement to make an easier way to do it and not require the Buttons.
I've copied out your keyboard layout code to use for developing a proof of concept of the functionality. I'm intending to work on that during Deep Dive tonight if you're interested in watching along.

@FoamyGuy I've been up all night trying different things with no progress and might not be awake to watch the stream. :(  Wouldn't buttons inside the grid layout create just as many labels or is it 1 button reused per cell?  That would definitely be more efficient!  Wish I knew you'd be covering this already took some sleeping pills.  Hope you use the whole feather weather script so you can see how much work I've put into it... and perhaps some ways to improve it?  I'm particularly proud of getting the RSSI scan to work properly.  The plan is to make SSID's s electable to change networks like a mobie phone does. It's a work in progress. Hope you'd get a chuckle out of my use of literal uppercase SHOUTY named variables, did that just for you. :P

In that other approach, it would need to be 1 Button per cell, they could not be re-used. And indeed each button contains a Label so in the end it will use just as many Labels in total. But the benefit would be that on those buttons you could call their contains method to test touch points and determine if they were on that item.
I cannot use the full script right now because I don't have the right hardware for everything that' sin your project. I'm using a PyPortal Titano which has the same screen size as the Featherwing you're project uses. But it doesn't have native wifi, and I don't have the the other componenets to connect to it, nor the openweather / mqtt infrastructure set up at the moment.
I'll try to get the full thing put together at some point to give it a go, but for now I must work wit only the Grid.

Sounds good. I'm drinking coffee and will be awake.  Sugar, lots of sugar.  Cant' wait to see what you come up with.

Running your example but I'm getting multiple key presses where as you seem to get single presses.  Unsure if that's a difference within the other libraries I'm using.  I used it in my full script and didn't try for the minimal version you made.  Will try your softkbd version by itself next.  Was able to get it to work somewhat with my full script though. I like the name soft kbd name you came up with too.  You did more in a single session than I could do in weeks.  Thank you for the feature addition!

This was resolved by https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout/pull/92 and resulted in https://github.com/FoamyGuy/CircuitPython_SoftKeyboard


use \thmt@define@thmuse@key for listhack key

Closes #53.
@muzimuzhi any thoughts?

Looks promising.
I'm too lazy to set a l3build config and write a test suite for thmtools...


a typings mirror for china should be greated!

If you living in china,when you run "typings install dt~ --save --global",For some reason,you will get below error:
typings ERR! message Unable to connect to "https://api.typings.org/entries/dt/<any moudel>/versions/latest"
typings ERR! caused by getaddrinfo ENOTFOUND api.typings.org api.typings.org:443

There are millions of developers in China,I hope you'll consider!

@phevose I don't see how there's anything Typings can do here. If it's not accessible in China, what can I do? That error normally means you don't have a network connection, can you check it's not just your computer?

According to the few sites I checked, it should be accessible within China: http://viewdns.info/chinesefirewall/?domain=api.typings.org. I don't really know much more than that though, since I've never lived in China. Hopefully someone else can give you a hand.

I test github.com on  http://viewdns.info/chinesefirewall/,it display  "blocked over HTTP(s)",but i can comment now,so http:viewdns.info/chinesefirewall  is not accurate,But still thank you for your reply!

I solved the problem by modifying the hosts file.
<IP_ADDRESS>   api.typings.org
<IP_ADDRESS>  raw.githubusercontent.com

closed!

Try to learn about the GF, maybe this is caused by other services (by other people) hosted on the same server.

The root causes maybe that  DNS was polluted,

Some things cannot be changed, but we(chinese programmer、github、typings) can change.so i hope typings  can create mirror site in china.


tcp connection abnormally interrupted， tcp connect reset

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

in this env:
vip is <IP_ADDRESS>, located at  <IP_ADDRESS>, this host's cilium_host ip is <IP_ADDRESS>, export by metallb
mysql client is <IP_ADDRESS>
mysql server's pod ip is <IP_ADDRESS> at host <IP_ADDRESS>
I have tcpdump on <IP_ADDRESS>'s cluster eth0, and pod's eth0, found some problem:
host_204_10.pcap, is decode with vxlan by port 8472
and both search by  tcp.port==32789

Here is the pcap file:
_root_host_204_10.pcap(1).gz
_root_mysql_204_10.pcap.gz
I used to think that the data packets were too big, but after checking the historical data packets, I found that it was normal to have large packets.

So I think it may be that cilium has an abnormality in packet processing.
Cilium Version
1.12.7
Kernel Version
4.19
Kubernetes Version
1.18.17
Sysdump
Uploading later
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

cilium sysdump: https://drive.google.com/file/d/1YFvrzZ998S6UMUxrEuEWdhiySWPijWSC/view?usp=drive_link

@lmb During normal tcp communication, an rst packet suddenly appeared, causing the connection to be disconnected. This rst packet was not initiated by the client, and the data packet returned by the server was not returned normally.

Have you tried newer versions?

This is a production environment and cannot be upgraded at will.

@lmb What other information do you need? I have already uploaded the relevant information.

@llhhbc, since the version you are running, there have been 12 releases, each with more than a hundred fixes. There is a reasonable chance that whatever is causing your issue has already been fixed. Without you upgrading to the latest patch release and checking that the problem still exists, it's not possible to do much troubleshooting.

@youngnick At present, this has affected the customer's production system. We need to give the customer a clear conclusion report, including how the problem occurred and whether it has been fundamentally resolved. I'm not sure if it's caused by too many connections, because we don't know the cause now, and we can't reproduce this problem.

And I'm not sure why this map size is so big? Does cilium automatically expand based on the environment?

I'm sorry @llhhbc, but we can't help you troubleshoot an issue with your environment.
We can help if you can confirm that there is a bug, and that it persists in the most recent release of Cilium 1.12, 1.12.7, with a reproduction.

@youngnick Because we don’t understand the underlying logic, we can only know the phenomenon now. Moreover, this problem cannot be reproduced in the test environment, so we cannot be sure and cannot narrow down the scope of the problem. Can you help locate the problem? We also want to confirm if the new version has resolved the issue. Can we communicate on slack?

my slack account is longhui.li

I'm sorry @llhhbc, but I cannot interactively troubleshoot this issue with you on Slack either. As I said, if you can find a reproduction, then I can assign this issue out to someone. But I am unable to spend time troubleshooting with you.

May be worth a try if you still have no clue:
sudo pwru --output-tuple --output-meta --filter-track-skb 'host $mysql_pod_ip and port 3306 and tcp[tcpflags]&tcp-rst!=0'

@jschwinger233 pwru require kernel > 5.3, this kernel is 4.19

It has been solved. It was other components that modified the cilium data package.

@llhhbc

It has been solved. It was other components that modified the cilium data package.

I think I'm seeing something similar.  Can you elaborate on "other components that modified the cilium data package"?


Jupyter used to show my plots in VS Code now it doesn't

Environment data
Version: 1.42.1
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:44:27.652Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.3.0
Expected behaviour
Show my torchviz plots on VS code
Actual behaviour
Says:
<graphviz.dot.Digraph at 0x124421490>

instead of displaying the image.
Steps to reproduce:
self contained code to reproduce:
import torch

from torchviz import make_dot

x = torch.randn(1)

y = 3*x

make_dot(y)

instead of displaying image it prints:
<graphviz.dot.Digraph at 0x128cc40d0>

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
EMPTY OUTPUT
Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:01: Activating Environment to capture Environment variables, . /Users/brandomiranda/miniconda3/envs/automl-meta-learning/bin/activate && conda activate base && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python /Users/brandomiranda/.vscode/extensions/ms-python.python-2020.2.63072/pythonFiles/printEnvVariables.py
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:01: parseEnvironmentOutput, Class name = S, completed in 0ms
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:01: getActivatedEnvironmentVariables, Class name = S, completed in 1579ms, Arg 1: undefined, Arg 2: {"architecture":3,"path":"/Users/brandomiranda/miniconda3/envs/automl-meta-learning/bin/python","version":{"options":{"loose":false,"includePrerelease":false},"loose":false,"raw":"3.7.6-final","major":3,"minor":7,"patch":6,"prerelease":["final"],"build":[],"version":"3.7.6-final"},"sysPrefix":"/Users/brandomiranda/miniconda3/envs/automl-meta-learning","fileHash":"d6fcec69eb45106b78c8b7e2bdc1a01e7ec3e18c1891b180796455cb288051a6c198219bb18a867ffb6d9a6488901a5ad21f316f65277c27de3c4ccef07d7d00","companyDisplayName":"Anaconda, Inc.","type":"Conda","envPath":"/Users/brandomiranda/miniconda3/envs/automl-meta-learning","envName":"base","displayName":"Python 3.7.6 64-bit"}, Arg 3: true
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Submitting code for 7627e4a1-eb0d-41d8-aab7-8f9e617fa3c3
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Waiting for jupyter server and web panel ...
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Cached data exists getEnvironmentVariables, <No Resource>
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Getting jupyter server options ...
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Connecting to jupyter server ...
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Connected to jupyter server.
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:11:29: Finished execution for 0651c08b-fab6-4f76-a9cf-aaae3959bedf
console.ts:137 [Extension Host] Info Python Extension: 2020-02-18 10:12:21: Cached data exists getEnvironmentVariables, tasks
log.ts:197   ERR No application in the Launch Services database matches the input criteria.: Error: No application in the Launch Services database matches the input criteria.

I'm unsure if I have the most recent version of everything cuz I am using this debugger: https://github.com/microsoft/ptvsd/issues/1706
although things were working perfectly well last night so I am unsure what happened overnight...

related bug, but VS code doesn't save my images either:
(automl-meta-learning) brandomiranda~/automl-meta-learning/prototyping_tests_playground/trainable_optimizers ❯ env PTVSD_LAUNCHER_PORT=55117 /Users/brandomiranda/miniconda3/envs/automl-meta-learning/bin/python /Users/brandomiranda/.vscode/extensions/ms-python.python-2020.2.63072/pythonFiles/lib/python/new_ptvsd/wheels/ptvsd/launcher /Users/brandomiranda/automl-meta-learning/prototyping_tests_playground/trainable_optimizers/torch_viz_graph.py

with script:
import torch

from torchviz import make_dot

x = torch.randn(1)

y = 3*x

make_dot(y).render('image', format='png')

but running the file directly from the integrated terminal seems to work:
automl-meta-learning) brandomiranda~/automl-meta-learning/prototyping_tests_playground/trainable_optimizers ❯ python torch_viz_graph.py
(automl-meta-learning) brandomiranda~/automl-meta-learning/prototyping_tests_playground/trainable_optimizers ❯ ls
__pycache__                             cifar10_tutorial.ipynb                  detached_deepcopy.ipynb                 differentiable_mdl.py                   image                                   sample_torchviz.ipynb                   torch_viz_same_graph.ipynb
backprop_through_optimizer.py           clone_playground.ipynb                  diff_over_backward.py                   extracting_gradients_as_data.ipynb      image.png                               scheduler.ipynb                         visualize_complicated_detach.ipynb
backward_twice.ipynb                    data                                    differentiable_mdl.ipynb                grad_test_sympy.py                      is_leaf.ipynb                           torch_viz_graph.py                      visualize_pytorch_graphs.ipynb

@brando90 thanks for the report on this. I see the issue. I think that we regressed something in our last release. I'll look at getting a fix out quick.

Validated


Add G1HeapRegionSize property to the JVM defaults

As it is suggested in Presto documentation https://prestodb.io/docs/current/installation/deployment.html. Omitting this property might potentially cause GC issues.

You should check out the unit/product tests, they're going to fail unless you update these properties in the results

thanks for fixing this though :)

@cawallin I'm going to wait for the tests to fail, and than i will fix all the failures at once =)


Change the application name

💩 How it is currently developed
We're using business, which basically says nothing.
🌟 What is the optimal solution
We should name it execution, since it handles all execution context.
😓 Why we did that way
Because we were learning about our domain.
💣 What are the possible impacts
Confusion.

Closed since we're now managing our engineering priorities on this Jira board.


Feedback and diagnostics if analysis server crashes or spins

Let's signal to the user if the analysis server crashed (or is spinning at 100%), so the user can restart. Or, let's automatically restart AS and let the user know.
What kind of heartbeat should we send? How best to know when we should restart the AS?
Also, it might be helpful to send a ping to the AS and get a dump from the observatory, which we can then give to the user to include in their bug report. We have an easy single HTTP GET to get stack traces from all isolates in the VM.

We've plumbed in a bunch of this.


Input irregularly shaped point clouds

Hi，@drprojects.
Sorry to bother you when you're out of office, but I have a few questions that I urgently need your help with：
How shoud I set the xy_tiling/pc_tiling( or other parameters if possible) while the input point clouds are not a regular rectangle?
like this:

Meanwhile, I also want an example where the predicted point cloud can be output as a PLY file with full resolution position( as issue #78 ).
Hope you can @ me after completing this useful example！
Thanks a lot！

Tiling
Here is how our 2 tiling strategies work. Tiling is optional, if you do not need it, keep xy_tiling=None and pc_tiling=None. Tiling arguments can either be XY tiling or PC tiling but not both.
XY tiling will apply a regular grid along the XY axes to the data, regardless of its orientation, shape or density. The value of xy_tiling indicates the number of tiles in each direction. So, if a single int is passed, each cloud will be divided into xy_tiling**2 tiles.
PC tiling will recursively split the data wrt the principal component along the XY plane. Each step splits the data in 2, wrt to its geometry. The value of pc_tiling indicates the number of split steps used. Hence, 2**pc_tiling tiles will be created.
In your specific case, I would go for PC tiling, this is what I use for the lightweight KITTI-360 11G config.
Full-resolution output
I will work on fixing the issue identified in #78, for comments regarding this specific topic, please use the associated thread.
PLY output
We do not provide support for PLY output, because this would require dealing with too many edge cases that would open the door to person-specific issues. If you simply want to store the full-resolution output XYZ and predicted labels to PLY, you should be able to code this yourself, with minimal understanding of the project (ie see the docs/data and commented code). Again, keep an eye on #78 until the full-res indexing issue is fix (I already proposed a workaround for solving it in the thread).


Sentinl and ELK OSS

Hi
Enybody try to install  Sentinl plugin on OSS ELK version ? It is possible ?

@arekstuka Yeah go ahead I did that on last week and it's working perfectly fine. I deployed this o on kubernetes see the below link you will get more idea
https://blog.webischia.com/2017/08/25/installing-kibana-with-sentinl-on-kubernetes/
I know, they didn't use the OSS image but i replace it with OSS image and it works fine
Thanks


Not possible to pass a specific type (eg: "password")  in the InputControl.

Hello,
thanks a lot for this lib !
I'm trying it and i cant add a password type for the inputControl.
Like this :
 <InputControl type="password" name="password" label="password" />
There is a Typescript error :
Property 'type' does not exist on type 'IntrinsicAttributes & BaseProps & { inputProps?: InputProps | undefined; } & { children?: ReactNode; }'
It's possible to do it on Chakra :
`function PasswordInput() {
const [show, setShow] = React.useState(false)
const handleClick = () => setShow(!show)
return (

<Input
pr="4.5rem"
type={show ? "text" : "password"}
placeholder="Enter password"
/>

{show ? "Hide" : "Show"}

)
}`
Thanks a lot !

Any update on a fix for this issue?

@Charlesdoiron @dimitriharding
You need to put the type inside the inputProps.
<InputControl               name="password"               label="Password"               inputProps={{                 type: "password",               }}             />
if you see the code in the package, you can see that InputControl receive this props.
export type InputControlProps = BaseProps & { inputProps?: InputProps };
That BaseProps is basically FormControlProps from chakra.


ledgerNotFound in transaction_entry after ledger_request

Hi there, is it possible to get transaction entry on a ledger, that already cleaned ?
On a local node we made /opt/ripple/bin/rippled  ledger_request 37888900 and answer is
{
   "result" : {
      "ledger" : {
         "accepted" : true,
         "account_hash" : "C0511932022DAC08AA6328A697D48AF0BFD7319F3387B05D47534EB8E49BA1C8",
         "close_flags" : 0,
         "close_time" : 576780371,
         "close_time_human" : "2018-Apr-11 16:46:11",
         "close_time_resolution" : 10,
         "closed" : true,
         "hash" : "1517BD8C139F16C723F39AF16025407AB1AB291E828E8FDE739C1C53026B644D",
         "ledger_hash" : "1517BD8C139F16C723F39AF16025407AB1AB291E828E8FDE739C1C53026B644D",
         "ledger_index" : "37888900",
         "parent_close_time" : 576780370,
         "parent_hash" : "B9675FB23D82162F32CA5C2BCA14EB3453AB2EEEFB805125C511DA8A155F7E31",
         "seqNum" : "37888900",
         "totalCoins" : "99992355360185433",
         "total_coins" : "99992355360185433",
         "transaction_hash" : "BC98AE34C3A46690BCD8EC958FA5951739573E33022C34E9FE30E0A3F114670B"
      },
      "ledger_index" : 37888900,
      "status" : "success"
   }
}

but after /opt/ripple/bin/rippled  transaction_entry some_transaction_hash_in_this_ledger 37888900 answer is
{
   "result" : {
      "error" : "lgrNotFound",
      "error_code" : 21,
      "error_message" : "ledgerNotFound",
      "request" : {
         "command" : "transaction_entry",
         "ledger_index" : 37888900,
         "tx_hash" : some_transaction_hash_in_this_ledger
      },
      "status" : "error"
   }
}

See #1873

@MarkusTeufelberger thanks. Do you know any way to get transactions from missing ledger ?

As long as the ledger is still in the range that your node is configured to store(!), you can take a look at ledger_cleaner.

afaik you can connect to one of ripples public node which had a full history (s2.ripple.com i believe?) using the connect command and then you can request the missing ledger

#2800 is a duplicate of this.

Closing in favor of #2800


Crash with Just Enough Dimensions when teleporting to Lost City

Minecraft crashed when I tried to teleport to the "Overworld". I used JED to set the Initial Spawn Dimension to id 2. Then I used the command /tpj 0 to teleport to Dimension 0 which should be a Lost City World. In the World creation GUI I selected the "The Lost Cities" Worldtype but also used the JED dimensions.json to override Dimension 0 with "lostcities" Worldtype.
I'm sorry if I made the mistake or if another mod caused the crash (mentioning @maruohon the JED dev)
crash-2017-06-09_20.54.50-server.txt
dimensions.json

Overriding the overworld (specifically dimension 0) might have some (more) issues that overriding the Nether or the End for example. So I would try not overriding the overworld, unless it's simply necessary for something you want to achieve. It might be safer just setting up the lost cities as a custom dimension, and maybe simply "lock out" the regular overworld  (disable teleporting to, and set the respawn dimension ids to something else), if you don't want the regular overworld to be accessible in addition to the Lost Cities and the other dimensions.
Based on your dimensions.json config, it seems that you mostly want to raise the cloud height and disable respawning in the lost cities world. It should also be noted that setting keeploaded: false for dimension 0 is a bad idea since lots of vanilla code expects it to always be loaded, but I think I'm force setting it to true for dimension 0 in JED anyway.

Thanks for your answer. My goal is to have a Garden of Glass dimension as the initial spawn and the respawn dimension and additionally a Lost Cities dimension. Ideally, I would then use the World Drop mod (no 1.11.2 version) to teleport between them. The cloud height was just a bonus to indicate that the Garden of Glass is above the Lost City.
I didn't test yet if I can build a Nether Portal in another dimension than the Overworld but I guess not, that is why I have the Lost City as Dimension 0.
I also don't know if I can change the Nether with JED to what I would like to have. I would like to have an infinite Lava Ocean with Nether Fortresses but I think the WorldProviderHell(JED) can't make flat worlds and the WorldProviderSurface(JED) doesn't generate Nether Fortresses, Lava flows slow and I can place Water.

I think you are correct in all counts. I could at least add support for selecting any of the vanilla ChunkProviders for use in any dimension. It should allow for at least a flat infinite-lava-ocean "Nether" dimension. If you want to talk more about this without clogging up this issue report, here is an invite to my Discord server: https://discorg.gg/2FgywHj


Update nippy to 2.9.1 & disable headerless serialization

cc @bcotton @ptaoussanis

NetflixOSS » PigPen » PigPen-pull-requests #13 SUCCESS
This pull request looks good


Project counts do not filter according to the query.

Was just browsing prod and it looks like there is some dissonance between the number of fastqs shown (~200k) and total files (~60k).
Talking with Dave, he suggested it’s because the project numbers are not filtered, but if they're filtered by pancreas it should match.

The current design is that the counts under the "Data" columns are per-project and don't change with the selected facets, unlike the summary counts at the top.

@theathorn It's a bit confusing.

It's a bit confusing.

This behavior is consistent across the UI.  Nowhere in the UI do the values displayed in the cells of the  main result table change in response to the filters. The filters affect which rows are displayed not whats in each row. I could see a use case for adjusting the cell values to the filters. But I could also see a use case for not adjusting them: For example, a user may want to see how many BAMs are in projects that also contains fastqs.  If we were to display the # of BAMs as 0 when the user selects fastq in the file type facet, that use case would not be possible, or harder to achieve (one  would  have to fixate on each  project and deselect the file type facet again.


Question on the paper

First of all, great work David! I was wondering if I can ask a question about the paper here or this is only for the web page's code?

Feel free to ask questions about the paper!

Thanks! Maybe I misunderstood something but it is not clear to me how the whole optimization works and from where the (real) actions of the agent are sampled from.
In the Appendix it seems to me that π(w,θ) is a policy function that "actions" w are sampled from. At the Method section of the paper: "Hence the weights w we need to learn will be the parameters of the agent’s policy network combined with the environment’s parameterization vector". It seems from the appendix that w is not learned but sampled from a probability distribution parametrized by θ and treated as additional "actions". Did I misinterpreted something here?

Hi @ConstantinosM
π(w,θ) is the same as g(y, μ, σ), where w = y and θ = [μ, σ] of Section 6 of REINFORCE.
I think the confusion here is that π(w,θ) is not the policy network (apologies if my notation makes it unclear, I followed the notation in (1) and (2) this paper).
If it makes it more clear, I can change the name π(w,θ) to g(w,θ) so that readers don't confuse π(w,θ) as the policy network (which was the terminology used in (Wierstra, 2014)].

Thank you for your reply @hardmaru,
My confusion mainly caused of the π  and also because I'm more familiar with the notation for distributions g(x|θ) and g(x,θ) for joint distributions but Williams explains very well his notation and by looking at Wiestra's notation there is no confusion anymore as to which quantities are being sampled and which are learned.
Just to confirm, you mention at the beginning of the paper  that you follow a joint optimization scheme between environment and policy network parameters so w=env_params + policy_params. Eventually, we are trying to find the parameters θ of a factored multivariate Gaussian dstr. in order to maximize the cumulative reward obtained by using samples (w) from that dstr.
By any means, I do not mean for you to change anything in this great work as perhaps it was my own only confusion. It is just my personal view that it might be more clear using g instead of π which is usually assigned to a policy in the context of RL.

Hi!
“Just to confirm, you mention at the beginning of the paper that you follow
a *joint *optimization scheme between environment and policy network
parameters so w=env_params + policy_params. Eventually, we are trying to
find the parameters θ of a factored multivariate Gaussian dstr. in order to
maximize the cumulative reward obtained by using samples (w) from that dstr.
“
Yup that is what we are doing-
On Mon, Nov 5, 2018 at 2:56 AM Constantinos<EMAIL_ADDRESS>wrote:

Thank you for your reply @hardmaru https://github.com/hardmaru,
My confusion mainly caused of the π and also because I'm more familiar
with the notation for distributions g(x|θ) and g(x,θ) for joint
distributions but Williams explains very well his notation and by looking
at Wiestra's notation there is no confusion anymore as to which quantities
are being sampled and which are learned.
Just to confirm, you mention at the beginning of the paper that you follow
a joint optimization scheme between environment and policy network
parameters so w=env_params + policy_params. Eventually, we are trying to
find the parameters θ of a factored multivariate Gaussian dstr. in order to
maximize the cumulative reward obtained by using samples (w) from that dstr.
By any means, I do not mean for you to change anything in this great work
as perhaps it was my own only confusion. It is just my personal view that
it might be more clear using g instead of π which is usually assigned to a
policy in the context of RL.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/designrl/designrl.github.io/issues/2#issuecomment-435691085,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGBoHrqaJdFrBnK1S3Teqpt8nnxrUjQlks5uryowgaJpZM4XYp8Q
.

Thank you David for all your answers :)


Dont shift canvas after it has been autoshifted

Fixes #496

I've tested this and improves the situation (no more dancing), but now the nodes run away :)

Even when you don't chase them:

Can reproduce... :(

@2opremio please give it a whirl when you have the time

Good news: the dancing in the radial view seems to be gone
Bad news: Now I have difficulties repositioning the layout (I used to do that by dragging a container). In fact I run into some sort of graph "drag-teleportation" in which the nodes go away when I try to move them and after which all views are empty (container, host, image ...):

I haven't been able to check whether zooming in and out still works since I am at home without a trackpad. Will try that on Monday.

It works beautifully now :)
In fact scrolling zooms in and out now with my mouse at home (which means it was also working).


Batching algorithm

What is the batching algorithm you are using?
Any links or references are appreciated.

No links of reference, it's something simple I came up on my own. It just tries to merge draws defined by a bounding boxes as long there is no different draw call overlapping in between. The algorithm has to be simple to not put too much heavy work at runtime.


Add a plugin: tig

This plugin adds tig command completion for zsh. The core functionality is taken from the official tig bash completion and it works just fine with zsh.
Tig is an awesome text-mode interface for git, if you don't know about it yet.

+1

Hi @adamme, and thanks for contributing.
You must realize that the file you want to include bears a copyright notice at the top. This is a clear indication that some rules may apply to copying the source.
Indeed, the repository where I assume you copied this from contains a COPYING file, indicating the source distributes under GPLv2.
But GPL is less permissive than the MIT license under which OMZ distributes, and thus cannot be simply integrated as such.
I advise you close this PR and put those files in $ZSH_CUSTOM.

@ncanceill Hi there,
Thanks for bringing up the license compatibility issue to my attention. I'll close this PR, even though I'd like very much to see it merged, which is clearly not feasible for the moment.


Regression: tab completion in SBT 1.4.5 terribly slow compared to SBT 1.3.10

steps
Update build.properties from 1.3.10 to 1.4.5
problem
I have several inputTasks with the same prefix.
I press 5 characters, and press tab, and I must wait for over 1 minute.  Before it was about 1 second.
On the other side, completing arguments to input tasks has good performance.
Completing task names has bad performance.
I press tab in the middle of a line: now no completion, before: it completed.
expectation
Same fast response.
notes
If necessary, I can provide privately my build config (it isn't simple).

@DavidPerezIngeniero Thanks for the report. I'm guessing that this is related to our update to JLine 3, but don't know exactly how.
Does the slow completion only happen for input tasks?

If I press e.g. "comp" and press tab, the result is immediate.
> com
commands                    compileEarly                compileScalaBackend
compile                     compileIncSetup             compileSplit
compile:                    compileIncremental          compilers
compileAnalysisFile         compileJava                 completions
compileAnalysisFilename     compileOutputs              compruebaCron
compileAnalysisTargetRoot   compileProgress

but if I press "distr", it takes 10 seconds:
> distribuye
distribuye               distribuyeFuentes        distribuyeLibreOffice    distribuyeSudoers
distribuyeAmm            distribuyeGit            distribuyeLimites        distribuyeSwapiness
distribuyeConfigApache   distribuyeGuionesRoot    distribuyePostix         distribuyeZk
distribuyeCron           distribuyeHomeEma        distribuyeServicio

sometimes much more.  All of them are input tasks.

I have noticed that tab completion on ++ is quite slow. Over in https://github.com/scala/scala-parser-combinators, this:
sbt:root> ++2<TAB>
++2.11.12   ++2.12.12   ++2.13.4

takes seven long seconds.

@SethTisue Thanks. I confirmed locally that downgrading to sbt 1.3.13 (after downgrading sbt-dotty too), ++2 would complete immediately, so there's something going on with sbt 1.4.x.

edf43a473b18f5c185475aa39d227eeb94e3ea8e is the offending commit according to bisect:
$ git bisect start
$ git bisect good ab5e57a
$ git bisect bad  31dc975ec
Bisecting: 74 revisions left to test after this (roughly 6 steps)
[a59d9fbb9784ce32403daa3124f0d3c7a4682cd4] Merge branch 'develop' into wip/versionscheme
$ git bisect bad
Bisecting: 38 revisions left to test after this (roughly 5 steps)
[9fbef411bf1a4b102ddc1ccdcb20663a3c67c708] Comment out test that is timing out
$ git bisect good
Bisecting: 20 revisions left to test after this (roughly 4 steps)
[4963f22cc65c3a04014919d83beec02c69af02be] Merge pull request #5714 from eatkins/scripted-improvements
$ git bisect good
Bisecting: 11 revisions left to test after this (roughly 3 steps)
[6c89d7416d56432e2e2ce193f962e5e3630c0d3b] Merge pull request #5723 from eatkins/watch-state-map
$ git bisect good
Bisecting: 6 revisions left to test after this (roughly 3 steps)
[3a9d3490657dd7db33cb62f916d0ebef4d7cb549] Check server test project scalafmt on travis
$ git bisect bad
Bisecting: 2 revisions left to test after this (roughly 1 step)
[775cdd598af2d6f244e450855773de79b95f7e30] Catch IOExceptions in consoleLog
$ git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[edf43a473b18f5c185475aa39d227eeb94e3ea8e] Set complete flag in completions
$ git bisect bad
edf43a473b18f5c185475aa39d227eeb94e3ea8e is the first bad commit
commit edf43a473b18f5c185475aa39d227eeb94e3ea8e
Author: Ethan Atkins<EMAIL_ADDRESS>Date:   Mon Aug 3 16:50:31 2020 -0700

    Set complete flag in completions

    JLine 3 automatically appends a space character to the completion
    candidate unless you tell it not to by setting its 'complete' parameter.
    This behavior is generally nice because it will automatically complete
    something like 'foo/testO<TAB>' to 'foo/testOnly ' which allows the user
    to start typing the testname without having to enter space. It does,
    however, break scripted completions because it will complete
    'scripted wat<TAB>' to 'scripted watch/ '

    This commit updates the custom completer to append a " " to the initial
    completions and check if there are any additional completions available.
    If so, we set the complete flag to true and jline will append a space to
    the input when the user presses <TAB> or <ENTER>. Otherwise the old
    jline2 behavior where no spaces are ever appended is preserved.

 .../src/main/scala/sbt/internal/util/LineReader.scala       | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Fixed in https://github.com/sbt/sbt/pull/6214


Refactor input and selection components to use design tokens

We need to convert the existing Figma design system components, into utilizing design tokens, in order to have a more flexible design system that embraces multiple platforms and products.


Fix for Clan().trophies

I thought it was better to limit API calls when retrieving members from a clan to avoid unexpected json decode errors (that just happened to me)


License MIT (?)

Hello,
there is no offical license file in the repository. It would be nice to activate it in GitHub.
I found the "MIT" license inside the project file.

@climblinne I'm very ignorant in how to properly define licenses for a repo. Is the correct way to have one at the root of the repo as opposed to banners in source?

Done https://github.com/AaronRobinsonMSFT/DNNE/commit/236974815bbefd80d844d9c38f8fb154df33684b


Recommend using git clone --recursive in README

Using git clone --recursive directly clones the whole repository including submodules, which makes using them a bit less error-prone (and less tedious to type ;) ). Small change, but I hope this is still helpful.

Thanks!


Add validation for untrusted input in path #62 #81

Summary
Jacks found a vulnerability with path module. This change ensures safe path.

Test plan

To verify Jacks report should no longer detect this vulnerability

Coverage decreased (-0.4%) to 92.704% when pulling 720c0f38ca02412a8aa84577ba5e42476027e2dd on jacks-untrusted-path-#62-#81 into 3c52f8b71e6565015efe593a3471ec9524625349 on master.

Coverage decreased (-0.4%) to 92.704% when pulling 720c0f38ca02412a8aa84577ba5e42476027e2dd on jacks-untrusted-path-#62-#81 into 3c52f8b71e6565015efe593a3471ec9524625349 on master.

Coverage decreased (-0.4%) to 92.704% when pulling 720c0f38ca02412a8aa84577ba5e42476027e2dd on jacks-untrusted-path-#62-#81 into 3c52f8b71e6565015efe593a3471ec9524625349 on master.


Doesn't work with capped collections

Apparently you can't remove documents from a capped collection: https://docs.mongodb.org/manual/core/capped-collections/
I'm getting this error:
MongoError: cannot remove from a capped collection: meteor.useful:logs/logs
  @ Object.Future.wait (/Users/joshua/.meteor/packages/meteor-tool/.<IP_ADDRESS>rio88++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:398:15)
  @ packages/meteor/helpers.js:119:1
  @ packages/xolvio_cleaner.js:41:5

The annoying thing is that this crashes my entire test, the only way to get my tests working is to temporarily convert my collection to an ordinary collection by commenting out the code that makes a capped collection.
If I get a chance I'll look into adding a pull request for this, it looks like it should be pretty simple to fix.
In the mean time fixing #6 would be a nice workaround.

I think 0.2.0 includes already the excludedCollections option. Let me know if not.

Cool, I'll check it out.


Update golangci-lint version to 1.58.1

Change Description
Update golangci-lint version to 1.58.1.
It also requires changing gomnd to mnd, and goerr113 to err113 (to solve warnings).
Background
Using the latest go version (1.22.3) breaks make checks-validator.
Upgrading golangci-lint version to 1.58.1 solves this.

About this failure:

@github-actions Enforce issue link to pull request / Check linked issues (pull_request) Failing after 2s

PRs either need a label "minor change" or an issue which they will fix.  Personally I would probably open an issue that golangci-lint panic on Go 1.22, and then say that this PR fixes that issue: it will be easier for devs who run into this to find.  But either way works.


Doc tweaks

@brauner probably fine to merge too, it's not like jenkins is going to find something here


Xml docs for IntelliSense

Totally missing them... Shouldn't be a big thing to add?

I will gladly accept a pull request if you want to take this task on.

I was hoping you could add some summaries since you are the author. I'm not as good in describing LinqKit as you are.

I am not the author. I found this code from some samples from a book. I talked to the authors about maintaining it on GitHub and they agreed.

Added XML-comments to package.
05420063b2691c573b46dcd30ca18501296bfa8a
If you have better descriptions, just create PR. :-)


feat: add liara provider

🔗 Linked issue

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)

📚 Description
add new provider to docs, named Liara with too much easy deployment missions
📝 Checklist

[x] I have updated the documentation accordingly.

Thanks for the PR. TODO list:

PR needs to rebased against v2 (default) branch
We need to actually add a provider to officially recognize it

Thanks
I'll do these changes and pull a new request 💯


Timing tool that adds the flag “--enable-timing" for a detailed report

Detailed timing report printed to the terminal for the entire onnx-mlir execution process, including setup in main() in onnx-mlir.cpp, input file processing before compilation, the passes run in the pass manager, and finally, the lower level compilation/generation stages (LLVM, Object, Shared Library, JNI). This tool will print the detailed execution report as a tree of all the timed stages to the terminal with the (wall time) and (relative percentage of program execution) for each timed stage and the total execution time of the onnx-mlir compiler. I used the DefaultTimingManager from llvm-project “timing.cpp” and timing scopes to time and name essential code sections where work is being done.
Example:

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@ParamvirSran follow the instruction here to fix DCO: https://github.com/onnx/onnx-mlir/pull/2801/checks?check_run_id=24080750134.
For Clang Format, you can run git clang-format to format the code, see https://github.com/onnx/onnx-mlir/blob/main/docs/Workflow.md#code-style

Can one of the admins verify this patch?

@jenkins-droid  test this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Jenkins Linux s390x Build #14756 [push] Timing tool that adds th... started at 01:06

Jenkins Linux ppc64le Build #13751 [push] Timing tool that adds th... started at 01:17

Jenkins Linux amd64 Build #14726 [push] Timing tool that adds th... started at 00:06

Jenkins Linux amd64 Build #14726 [push] Timing tool that adds th... passed after 1 hr 11 min

Jenkins Linux s390x Build #14756 [push] Timing tool that adds th... passed after 1 hr 23 min

Jenkins Linux ppc64le Build #13751 [push] Timing tool that adds th... passed after 1 hr 59 min


iOS 14 CWA Home screen Widget

Here is just a quick idea how the CWA could use the new home screen widgets coming with iOS 14.

Duplicate of #26
#closerequest

Yes, we‘ll close that. But would be great if you could add the mockup to #26, @Bohne9 ?


[ACR] Make AAD resource scope match cloud

We are currently hard-coding the resource id for the token scope in our client library.  This won't work for non-public Azure clouds.
We'll need to use a different resource id per cloud as described in this document.
We will obtain the cloud identity from the registry URI suffix as follows:

"AzureCloud": ".azurecr.io"
"AzureChinaCloud": ".azurecr.cn"
"AzureUSGovernment": ".azurecr.us"
"AzureGermanCloud" : ".azurecr.de"

This has been shipped.


Close figure after saving to improve memory and speed of similar_images #3

After approximately 20 images, the code uses a lot of memory (>10GB) and becomes incredibly slow. This is because the figure objects are not closed.

Added a plt.close() line to plot_utilities file

Good find. Thanks a lot ouzoh!


fix(UpdatePrompt): long changelog error

Long changelogs resulted in Unity logging an error. The fix is to
add pagination to the changelog so less text is rendered at one
point.
Additionally the changelog is updated to follow the markdown look a
bit more.


[Recorder] Take changes from<EMAIL_ADDRESS>

Previously, afterEach was skipped if the test is skipped, the behavior is changed with<EMAIL_ADDRESS>afterEach gets executed even if the test is skipped.
This breaks the playback tests since the skipped tests do not have the recordings for the HTTP requests in afterEach.
Update the tests with recordings so that we don't have to check if the test is pending in afterEach. ( !this.currentTest?.isPending() )
Reference - https://github.com/Azure/azure-sdk-for-js/pull/8108/files#r400580853

Related #9509

Closing this as it is not relevant for recorder v2


Tweaks to issue forms

A few issues with #2367

[ ] "validations" needs to go up one level to be right under "type" instead of under "attributes"
[ ] Some other required fields are missing from the "Feature Request" template
[ ] Remove the default value from title in the Save Issue template. Currently it auto-populates with Save Error: which users will probably ignore and we'll end up with every save issue with the same title. Leave it blank so we can require users to put some thought into it with the "validations" setting.
[ ] Add "validations" to the Save Issue template.
[ ] Link from editPage.jsx doesn't quite work.

[ ] Change labels from "saving" to "Saving"
[ ] Change template from "template=save_issue.yaml" to "template=save_issue.yml"

done
done (namely a 'attributes' key on the checkboxes)
done...except I can't set a validation property but a title will still be required by Github I assume.
done
done

PR #2377


how to support Vec

Describe the Bug
the trait bound Vec<f32>: RefFromWasmAbi is not satisfied
the trait RefFromWasmAbi is not implemented for Vec<f32>rustcE0277
the trait bound Vec<f32>: RefMutFromWasmAbi is not satisfied
the trait RefMutFromWasmAbi is not implemented for
A clear and concise description of what the bug is.
Steps to Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

If applicable, add a link to a test case (as a zip file or link to a repository we can clone).
Expected Behavior
A clear and concise description of what you expected to happen.
Actual Behavior
A clear and concise description of what actually happened.
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.

Is there a reason you can't use f64 and later convert it to f32 (if really needed)

With a vector of million of points, you probably don't want to use twice the memory.

Both &[f32] and Vec<f32> can be used as arguments, but not &Vec<f32>, which is what you seem to be trying to do. Using &[f32] or Vec<f32> instead should work.

Thx for the hint.
I think i am using a *f32 + unsafe block now, ill make a second try with a Vec then.


feat(module/transit-gateway): support for retrieving existing TGWs by ID only

Description
Add ability to retrieve an existing Transit Gateway using it's ID.
Motivation and Context
Required in situations where to Name tag is present or TGW is a shared one - in this case only referencing by ID is possible.
How Has This Been Tested?
All 3 scenarios were tested:

create a TGW
retrieve existing by name
retrieve existing by ID

Screenshots (if appropriate)
Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

What do you think about adding a section in a README that describes in more details the use of the module with an existing TGW - when to refer name vs. id, that a use still has to provide some name, even if id is provided, etc.?

@michalbil - that is a good point. It would be good to provide some flexibility in the name variable - make it optional only in situations where create = false and id !=null.


SPARKC-490 Pushdown filter for composite partition keys doesn't work …

SPARKC-490  Pushdown filter for composite partition keys doesn't work when IN is used
I have a cassandra table with PRIMARY KEY - ((date,billing_country,offering,category,name),ts,realm_id)
Running a spark Query - val results = spark.sql("select * from event where dt in ( to_date('2018-02-14'),to_date('2018-02-15')) and billing_country ='us' and  offering ='qbn subscription' and category ='billing' and name = 'billing_attempt' and ts in (cast ('2018-02-14 01:19:40.000000+0000' as timestamp),cast('2018-02-14 01:19:41.000000+0000' as timestamp)) and realm_id > '783813150'")
18/03/13 17:50:52 DEBUG CassandraSourceRelation: Final Pushdown filters:
C* Filters: [In(ts, [2018-02-13 17:19:40.0,2018-02-13 17:19:41.0], GreaterThan(realm_id,783813150), In(dt, [2018-02-14,2018-02-15], EqualTo(category,billing), EqualTo(name,billing_attempt), EqualTo(offering,qbn subscription), EqualTo(billing_country,us)]
Spark Filters [IsNotNull(category), IsNotNull(billing_country), IsNotNull(realm_id), IsNotNull(name), IsNotNull(offering)]
18/03/13 17:50:52 DEBUG CassandraTableScanRDD: Created total 1 partitions for htap.event

@jtgrabowski I know you were work in this space, could you take a look please?

sure, will do

@sambekar15 it looks good but pushing down more than one IN clause is not supported in Cassandra 2.1.x and apparently Connector should support this Cassandra version. Could you please add fallback (based on protocol version) to previous push down definition?

@jtgrabowski Sorry for the delay . I have made changes to add fallback (based on protocol version) to previous push down definition. Can you please review

@jtgrabowski  addressed comments.

test this please

Build against Scala 2.10 finished with success

Build against Scala 2.11 finished with success

Thank you @sambekar15  for your contribution!


Patch to support xNVMe

Hi, I used autopxd over at xNVMe, and needed to patch a few things to make it work, and I thought it could be of use to others.
The commits should be self-contained and have each the functionality they describe.
An overview:

--regex on command-line to allow arbitrary conversions. Some datatypes or syntax just doesn't get parsed correctly by autopxd. As a quick solution, I can hotfix something easily without making full and proper support in autopxd -- for example an opaque pointer in a function I don't need. (--regex 's/FILE \*/void */g').
Flattening members of unnamed unions and structs. Cython just cannot express these, so I made a "hack" where these members become accessible at least in some manner. See example below.
Make enums into cpdef to make them accessible from Python as well as Cython for free.
Ignore StaticAssert. Simply skip them. They don't make much sense in Cython and currently it makes autopxd output faulty code.
Possible to ignore known/defined declarations. Maybe there's a better way to do this, but I needed this to support multiple .h files. This way, I can provide the declarations from other headers, so they are not repeated. There is a better way. The whitelist kwarg.
Replace wget in favor of urllib. Not all distros has wget (nor cURL) installed, so I opted for a native Python implementation. This works across all distros I have tried (xNVMe test run).

I would love to get feedback from you, especially on the part I will highlight.
struct test_struct {
    int a;
    struct {
        int b;
        int c;
    }
}

cdef struct test_struct:
    int a
    int b
    int c

@Baekalfen this is great! Can you get tests passing?

@Baekalfen this is great! Can you get tests passing?

Yes, I'll get it fixed. I realize the thing with anon nested structs (like below) isn't totally correct. I'll investigate further if it needs to be narrowed down or removed.
    int nested__d
    int nested__e

They should be fixed now to get the best of both worlds.  The confusing came from trying to print the structs.
This will work for any struct as long as it only has named nested structs inside it.
cdef test_struct A = ...
A.nested.x = 2
print(A)

But the same setup with a struct that contains a nested anon struct will result in a compile error along the lines of:
test_cython.c:4240:18: error: conflicting types for '__pyx_convert__to_py_struct___xnvme_opts_css'
static PyObject* __pyx_convert__to_py_struct___xnvme_opts_css(struct _xnvme_opts_css s) {

But dropping the print of the entire struct, will make it work. I believe this is either a bug in Cython or an accepted limitation from there side.
cdef test_struct A = ...
A.nested.x = 2
print(A.a)
print(A.b)
print(A.c)
print(A.nested.x)

@elijahr The tests and the formatting should all be done now, but there's something with the linting step in GHA.

I removed the additional ignore thing. Using the whitelist kwarg was much easier once I got it to work.  You have to add '<stdin' to the whitelist to allow declarations from the .h file you are providing. Otherwise it only takes declarations from the whitelisted includes.

This is great! Thanks so much for the contribution!

@Baekalfen this has been released in https://pypi.org/project/autopxd2/2.1.1/


using cpp to read file failed

I use ifstream in(filename); to read file in my cpp code,  the filename refers to the path in my android phone,  in returned false, I checked that I did have filename in my phone.
Is it possible to use this method to read file from android?
If possible, why in return false?
Thanks

this would be a guess: in logcat, do you see any permission errors? ( or you check to make sure you have requested write access at run-time ). In one sample, tried to use the C to do I/O once here, seems to be ok once requested access right.

Permission is the cause!
Thank you very much!!


Allow using http (vs https) for hosts that are not "localhost"

Please see https://github.com/helm/helm/issues/6324

Fixed by #122


Please tag a release

for Py3.12 compatibility

Done. Tag pushed and PyPI release done.

 It's gone now.

thank you


AADSTS65001: The user or administrator has not consented to use the application with ID 'c628c6f3-59aa-444d-93f0-e36d72996461' named 'SharePoint Online Client Extensibility Web Application Principal'. Send an interactive authorization request for this user and resource.

I am a attempting to get a access token in my SPFX webpart.  Can you offer any insight on what I'm missing from this document?
I am hitting this error.
Uncaught (in promise) Error: AADSTS65001: The user or administrator has not consented to use the application with ID 'c628c6f3-59aa-444d-93f0-e36d72996461' named 'SharePoint Online Client Extensibility Web Application Principal'. Send an interactive authorization request for this user and resource.

this.context.aadTokenProviderFactory
.getTokenProvider()
.then((tokenProvider: AadTokenProvider): Promise<string> => {
  // retrieve access token for the enterprise API secured with Azure AD
  return tokenProvider.getToken('2e887b5a-f782-4dcf-9ba2-6091805ad0cc');
})
.then((accessToken: string): void => {
	console.log("GOT ACCESS TOKEN", accessToken);
});

My package-solution.json file has requested permissions
"webApiPermissionRequests": [
{
  "resource": "Windows Azure Active Directory",
  "scope": "User.Read"
},
{
  "resource": "Microsoft Graph",
  "scope": "User.Read.All"
},
{
  "resource": "Microsoft Graph",
  "scope": "User.ReadBasic.All"
},
{
  "resource": "Microsoft Graph",
  "scope": "profile"
}

I have approved all requested permissions:

I have also for good measure manually added and approved User.Read permission on Azure Active Directory.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 064cdc5a-e118-ceab-c42b-ae06ae3297c6
Version Independent ID: 95afcc6d-fd0b-90a0-5775-4871869abc83
Content: Connect to API secured with Azure Active Directory (Azure AD)
Content Source: docs/spfx/web-parts/guidance/connect-to-api-secured-with-aad.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

I want to say that the resource name "Windows Azure Active Directory" looks wrong - what are you wanting to access with it?  Can you tell which resource request is failing?

I was following the thread here which references adding that resource scope: https://github.com/SharePoint/sp-dev-docs/issues/2473#issuecomment-419327768
I would like to see if this authentication method allows for silent SSO in the mobile application.
Right now when using adal-angular in the native mobile application you're redirected to sign in (since it seems the native mobile application does not share the authentication context?)

In your code, you're requesting an access token to an API, that isn't among the permissions you requested. Could it be that you're missing an API permission grant to your enterprise API?

@butchmarshall
try to call method getToken with 'https://graph.windows.net' to get the JWT token
return tokenProvider.getToken('https://graph.windows.net');

facing the same issue
@VesaJuvonen

@butchmarshall
try to call method getToken with 'https://graph.windows.net' to get the JWT token
return tokenProvider.getToken('https://graph.windows.net');

I am getting token through graph.windows.net But how can I validate it manually in ASP.Net WCF application?

I actually had a support call with Microsoft around this.
Basically, you can't validate it.

Ooookay! Thank you for your response.
I tried with graph.windows.net because I am getting below error while trying to get a token for my registered azure app. I have been tried below code to get a token for my azure app.
this.props.context.aadTokenProviderFactory
    .getTokenProvider()
    .then((tokenProvider: AadTokenProvider): Promise<string> => {
       return tokenProvider.getToken(<AppID>);
})
.then((accessToken:string):void => {
     console.log('Token received - ' + accessToken);
})

Error: AADSTS65001: The user or administrator has not consented to use the application with ID 'bb0e5f77-d3b6-470b-b79b-994ae0da5838' named 'SharePoint Online Client Extensibility Web Application Principal'. Send an interactive authorization request for this user and resource.
I have WCF web service hosted in our dedicated server and I have registered the app on Azure AD with redirect URL to web service domain path.
Could you please tell me a cause or advice on, why I am getting AADSTS65001 error when trying to get an access token. And if somehow I manage to get the token, then I am planning to pass it through Authorization header to a web service call from SPFx. And then I will validate the token in WCF implementation, Is it possible? We have chosen to host WCF web service on on-prem server, please advice if you have any alternative, in that case, to make it work. The final goal is to secure WCF web service hosted on-premises server.

Appears OP's question was answered... there may be another question in this issue but can't tell. If so, please open a new issue.


Running ./checklist_graph.sh --technology=lz--format=json results in a number of compliant=undefined results

I ran ./checklist_graph.sh --technology=lz--format=json in a azure cloud bash shell, but a number of the results had  "compliant": "undefined". After a quick look it appears a number of the graph queries in lz_checklist.en.json use Compliant as the projected column (e.g https://github.com/Azure/review-checklists/blob/main/checklists/lz_checklist.en.json#L135), but checklist_graph.sh seems to expect it to be compliant https://github.com/Azure/review-checklists/blob/main/scripts/checklist_graph.sh#L256 (note the casing difference).

CC @fskelly
@hamish-omny I have created PR #226 to fix this


Send download emails on mobile

Replaces the reverted #1456, check out that for a detailed description of the original feature.
This PR also unifies the small modal CSS so that it's shared nicely across the page, and is no longer terrible. I've also unified the Share dialog JS so that the map and country page use the same (hopefully nicer) code.
I forgot to mention in the other PR, this uses a mailer for the download emails and will need some sort of SMTP config, can someone (@apercas @mbarrenechea) with knowledge of the deploy process sort that out, or let me know how you normally configure stuff like that.

@adammulligan Yes: you can check here gfw/config/application.rb that we're using Mandrill for everything email related.

Oh, perfect, shouldn’t need any further config then.

On 26 Mar 2015, at 14:53, Adrián<EMAIL_ADDRESS>wrote:
@adammulligan https://github.com/adammulligan Yes: you can check here gfw/config/application.rb that we're using Mandrill for everything email related.


KCS: backend FS abstraction

Lets build a diff tool that backends can reuse that replaces serviceChangeTracker ***** FORVER ****
@hanamantagoudvk
DETAILS
Problem:
IPVS backends dont use serviceChangeTracker but need a diff solution for
AddSessionAffinity -- ..
InternalTrafficPolicy
ExternalTrafficPolicy
TopologyAwareHints

Solution:
talking w/ @hanamantagoudvk @mcluseau @knabben @dougsland

kpng backends get SetService/SetEndpoint for every single K8s delta
its cheap and easy to cache these in Go locally
its cheap to just calculate a "diff" on the fly
we thus dont probably need the dang serviceChangeTracker anymore
that said we use it for iptables, we can eventually replace it with the byproduct of this issue which is

A client side cache-diff-tool KCS
Nice to have
we should throw a burial party for SCT when this is completed

This is a good newcomer issue for the india team i think - so once the library is done maybe we can add unit tests after the fact as a follow on good-first-issue @hanamantagoudvk please decompose if you can so we can leverage this to grow the overall group of folks that know how to do this


Update invoice payer_email and description as optional

https://github.com/xendit/xendit-php/blob/e4df989aac9e71512a544e7cb69f863d51adcfe3/src/Invoice.php#L49

This resulted in inconsistencies between the documentation ( https://developers.xendit.co/api-reference/?php#create-invoice ) and the actual result, without parsing payer_email and description (marked as optional in the docs), invoice won't be created

I also experienced the same thing, need fix it

#147

Closing as resolved~


Installation as zip, portable installation

Summary of the new feature/enhancement
Distribute releases in a zip file. When extracted the command can be executed right away without any installation process. At first run, the necessary integration with explorer etc. can be installed.
This would make it easier to use across multiple machines as I can simply update in one place and synchronize files (like via OneDrive).

Hi @DavidXanatos
thanks for the suggestion.

no plans to do this at this time

It would be better for the integration not to happen during install/run, but from an action in the configuration view. This gives people the most knowledge and control of what's happening.

Also having settings be saved in the root folder instead of AppData and persist throughout different Windows installs.
This is the kinda tool that needs portable functionality the most.

no plans to do this at this time

@crutkas Is this a "final" statement for the repo? If not I suggest to reopen and tag with "patches accepted" or similar. As mentioned in the referenced issues: It may not be possible to support a portable mode for every of the PTs (I doubt that FileExplorerAddOns would), but it should be possible at least for some applications.

It is a scenario we would have to support and have to continually test against. Due to that, it is not something we plan to do. If you submit a PR, our team still needs to test it every release moving forward. If it breaks, it is on us to fix it then.
Fyi Some utilities currently can be run as standalone and how we dev against most. But things like issue #6060 and making sure we overcome elevated apps end to end is proving interesting for mouse / key hooks. And one proposed solution would need an installer.

It would be great if we could have a PortableApps package of the PowerToys.

This was closed five years ago, but it seems people continue to request a portable version repeatedly.
As we approach 2025, could this be reconsidered?


Disable ability to play mix and race at the same time using the same account

I thought SDK put a stop too this once?

I don't know @f1madkiller
Can't check right now

Players who play only mix server come to race server and ask for their accounts to play only mix for double-gc

It should either block the login when the account is already in-use, or it should sign-out at the 'first' location.

@AleksCore this can be fixed now as it is done i tested it otherday on my pc and laptop it logs out the account signed in first

Like mad says I added the 'sign-out at first location' method a long time ago, if something is wrong let us know


Save and Return UX

User feedback - when returning to a claim, users are returned to page 1, rather than the page they left. Details are saved, but users comment that they would rather return to the page they left.

You could add a navigation_stack similar to the one in the tax tribunals-datacapture repo.
This implementation is super simple and adds two key pieces of functionality: 1) saves the current step so that I can take the user directly to it, and 2) adds a working back button.
The only difference in my implementation is that I call the update function explicitly within the "show" step page rather than using a before_action callback.
Here's how it gets saved on the db:
navigation_stack: [
   "/profiles/16/steps/name",
   "/profiles/16/steps/email",
   "/profiles/16/steps/do_you_have_a_linkedin",
   "/profiles/16/steps/linkedin",
   "/profiles/16/steps/use_linkedin_as_resume",
   "/profiles/16/steps/are_you_currently_in_pr",
   "/profiles/16/steps/current_location"
]


Resume for chunked upload replaces file with remaining bytes

Hi,
Context:
I forked this project with the hope of creating a specialized version focused mainly on XHR2 chunked (blobsliced) uploads including cross-domain capability. I need to properly implement or configure resume (not restart) on network or server error.
Environment:
I setup the project on my MacbookPro (running Apache) and I'm accessing it by its LAN IP address (not localhost) so that I can manually disconnect the network (turn off wifi) on my machine to test resuming uploads upon network error.  I'm also simulating a real connection's latency/bandwidth on my laptop (via SpeedLimit app) I'm using Firefox 8 in my tests.
Question:
All seems to be working fine except the "resume" portion, which I need (for very large files a 'restart' from scratch upon network/server error is not acceptable)
I've plugged in the replacement to 'fail' handler in application.js (not sure if 'fail' is actually triggered upon network interruption and actual server errors or if it's only triggered upon encountering {fail: true} from the Ajax call, i.e. I'm asking if 'fail' is only called on application error or also on network/server error) << can you clarify?
I also setup multi-part to false and chunk size to 20000 (very low since I only have small image files < 500Kb to test with right now so I need this low value to see detailed chunk by chunk progress visually)
What happens when I turn off wifi then turn it back on is that the uploading does indeed seem to resume (the progress bar resumes its progress from where it stopped) but when it's done what I see is always a file less than 20000 bytes, sometimes 14.7k and other times 19.2k etc.... I suppose this is the last remaining chunk that is overwriting the uploaded file in php/files.
I set the 'discard_aborted_uploads' in index.php to false but that only has an effect on the regular case of chunked uploads, not when I cause a network interruption.
Thanks for your help.

The fail handler is the equivalent of the $.ajax error callback.
It's triggered for network errors (timeouts, HTTP error codes), upload abortion and parsing errors.
The UI version of the plugin also manually triggers it for canceling uploads that have not been started yet.
Thanks to your report I tested automatic resume and found a bug in the data.submit function, which prevented manually setting uploadedBytes during chunked uploads.
I will release an updated version (5.5.2) which fixes this issue.
I've also updated the guide for chunked file uploads and added an example on how to automatically retry and resume uploads:
https://github.com/blueimp/jQuery-File-Upload/wiki/Chunked-file-uploads


gradle: 7.1 -> 7.1.1

Motivation for this change
update!
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 132680 at 59091b77 run on x86_64-linux 1

1 package marked as broken and skipped:

impressive

7 packages built successfully:

diffoscope
gradle (gradle_7)
gscan2pdf
jadx
pdfchain
pdftk
scenic-view

3 suggestions:

warning: fixup-phase
fixupPhase should not be overridden, use postFixup instead.
Near pkgs/development/tools/build-managers/gradle/default.nix:30:5:
   |
30 |     fixupPhase = if (!stdenv.isLinux) then ":" else
   |     ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/tools/build-managers/gradle/default.nix:50:5:
   |
50 |     meta = {
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/build-managers/gradle/default.nix:19:5:
   |
19 |     installPhase = ''
   |     ^


Minor bug fix + lodash update

Removing unwanted padding in case of too many items in the chart

please add webpack.statistics.prod.html  file to .gitignore


"Required key not available" can't unzip tor tar.xz package :/

To get more online anonymity I have discovered Tor in kali linux, which i installed with
sudo sh -e ~/Downloads/crouton -r kali-rolling -t xfce
Im not used to kali, and im really confused as to why i can't unzip the package through the terminal or even open it with Xarchiver.
please help
all it says is just required key not available and that it is exiting the failed "objective?" im not sure xd

Same.

this might be redundant, the fix should be the same as #3860


Not call meh() from rak()

Would it be better to not call meh() from inside rak()? meh() calls exit and that wouldn’t make it possible to a user using rak() on its own module or code to handle that. Could it be an exception?

Good point!   :-)

Actually, I'm thinking of makingrak return a Supply, and instead of say emit to that.  Would that make sense?

Version 0.39 now on zef.  It still calls meh, but will die instead of exit if called as rak (well, if the $*REAL-MEH environment variable isn't set, but that's an implementation detail).


Add doubleclick handler on canvas

Allow doubleclick listener on canvas. When you double click on the canvas the click handler is given the time position where the click happens and the group. Ideally it allows creating of new items to the click position.

0.7.3 released!

is it a good idea to have onCanvasClick(groupId, time, e) but onCanvasDoubleClick(time, groupId)? Would it not be better to have onCanvasDoubleClick(groupId, time, e)? see: https://github.com/namespace-ee/react-calendar-timeline/pull/52


Microsoft.Azd version $(WinGetVersion)

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

cc @danieljurek: It looks like it's not getting the correct version.

Indeed our automation is not substituting the variable. I'll get a fix in. Thanks!

/azp run


Test refactor

Refactor unit tests

Yes, I will refactor. On Jan 12, 2023, at 3:49 PM, Boris Glimcher @.***> wrote:
Merged #97 into main.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Yes, I will refactor

cool, thanks!
and we should probably repeat that for https://github.com/opiproject/opi-marvell-bridge and https://github.com/opiproject/opi-nvidia-bridge as well