Wrong position of generated include guards and extern "C" blocks in the Evercrypt sources

Thank you for adding
#if defined(__cplusplus)
extern "C" {
#endif

blocks in commit 1797f62
However, the placement of the header inclusion guards and those extern "C" blocks currently seems incorrect.
For example, in Hacl_Hash.h, I see
 /* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

#include "evercrypt_targetconfig.h"
#include "libintvector.h"
#include "kremlin/internal/types.h"
#include "kremlin/lowstar_endianness.h"
#include <string.h>
#include "kremlin/internal/target.h"

#ifndef __Hacl_Hash_H
#define __Hacl_Hash_H

#include "Hacl_Kremlib.h"
#include "Hacl_Spec.h"
#if defined(__cplusplus)
extern "C" {
#endif

void Hacl_Hash_MD5_legacy_update_multi(uint32_t *s, uint8_t *blocks, uint32_t n_blocks);

//...

#if defined(__cplusplus)
extern "C" {
#endif

While the correct ordering should be:
 /* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */
#ifndef __Hacl_Hash_H
#define __Hacl_Hash_H

#if defined(__cplusplus)
extern "C" {
#endif

#include "evercrypt_targetconfig.h"
#include "libintvector.h"
#include "kremlin/internal/types.h"
#include "kremlin/lowstar_endianness.h"
#include <string.h>
#include "kremlin/internal/target.h"

#include "Hacl_Kremlib.h"
#include "Hacl_Spec.h"

void Hacl_Hash_MD5_legacy_update_multi(uint32_t *s, uint8_t *blocks, uint32_t n_blocks);
//...

#if defined(__cplusplus)
extern "C" {
#endif

kind regards,
Niek

Thanks Niek for the report, HACL* will be refreshed automatically by the nightly job within 24h.

Fixed by fstarlang/kremlin@37db01d199323d9cc4f57b4b6ed4e6ad57ef2865

Dear Jonathan/Evercrypt-devs.
Thank you for addressing this; however, it seems that the issue is still there: some #include statements still appear before the include guards (and the 'extern "C" '-macros):
For example in dist/gcc64-only/EverCrypt_CTR.h I see
/* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

#include "evercrypt_targetconfig.h"
#include "libintvector.h"
#include "kremlin/internal/types.h"
#include "kremlin/lowstar_endianness.h"
#include <string.h>
#include "kremlin/internal/target.h"

#ifndef __EverCrypt_CTR_H
#define __EverCrypt_CTR_H

#if defined(__cplusplus)
extern "C" {
#endif

#include "Hacl_Chacha20.h"
#include "Hacl_Kremlib.h"
#include "Vale.h"
#include "EverCrypt_AutoConfig2.h"
#include "EverCrypt_Error.h"
#include "Hacl_Spec.h"

typedef struct EverCrypt_CTR_state_s_s EverCrypt_CTR_state_s;

bool
EverCrypt_CTR_uu___is_State(Spec_Agile_Cipher_cipher_alg a, EverCrypt_CTR_state_s projectee);
//...

I.e., the following includes should be below instead of above the include guards / extern "C" macro
#include "evercrypt_targetconfig.h"
#include "libintvector.h"
#include "kremlin/internal/types.h"
#include "kremlin/lowstar_endianness.h"
#include <string.h>
#include "kremlin/internal/target.h"

Kind regards,
Niek

Pushed another fix, hopefully we're all good now. Thanks for the bug report!

Dear Jonathan / Evercrypt-devs,
Thank you for updating, however, unfortunately, issues remain.
After this change, the include guards, like
#ifndef __EverCrypt_CTR_H
#define __EverCrypt_CTR_H

are still in the wrong position. They should come directly after the license header.
Als near the end of the header file(s) there is an ordering issue between the include guards and the "extern C" closing-brace ('}') block.
This is the current situation:
/* ...
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

#if defined(__cplusplus)
extern "C" {
#endif

#include "evercrypt_targetconfig.h"
#include "libintvector.h"
#include "kremlin/internal/types.h"
#include "kremlin/lowstar_endianness.h"
#include <string.h>
#include "kremlin/internal/target.h"

#ifndef __EverCrypt_CTR_H
#define __EverCrypt_CTR_H

#include "Hacl_Chacha20.h"
#include "Hacl_Kremlib.h"
#include "Vale.h"
//...
#define __EverCrypt_CTR_H_DEFINED
#endif

#if defined(__cplusplus)
}
#endif

The correct ordering would be:

#ifndef __EverCrypt_CTR_H
#define __EverCrypt_CTR_H

#if defined(__cplusplus)
extern "C" {
#endif

#include "evercrypt_targetconfig.h"
#include "libintvector.h"
#include "kremlin/internal/types.h"
#include "kremlin/lowstar_endianness.h"
#include <string.h>
#include "kremlin/internal/target.h"

#include "Hacl_Chacha20.h"
#include "Hacl_Kremlib.h"
#include "Vale.h"

//...

#define __EverCrypt_CTR_H_DEFINED

#if defined(__cplusplus)
}
#endif

#endif

Thanks Niek, I've pushed another attempt at this, thanks for the detailed suggested fix.

The nightly build should push a refresh in about half an hour.

This caused regressions, so I had to back it out. Currently looking at it.

I've convinced myself that my proposed patch in kremlib is good, so I'm going to go with that. Also had an Everest green.

Apologies for my delayed response.
I just tested in my C++ codebase and the 'extern "C"'-macros work like a charm!
Thanks again for upstreaming this..!


Add Census Web Data Connector

Add Census Web Data Connector for all census information available through census apis

listing new community created connector to Census data


Mesh rendering

Following would be required to render a mesh. It is a .obj file. It contains vertex list and .mtl file to use for material. .mtl file contains path to the texture image to be used and some attributes. We can make an object like pyglet.graphics.vertex_list to store the vertices and its attributes. This object can later be used while rendering.

[x] Getting texture from an image
[x] Rendering arbitrary meshes (ie vertices) with given texture

Arbitrary Mesh Rendering is available in ap/examples branch. It is not efficient but a minimal working version.

This will be handled correctly once #8 is merged. Performance is still an issue but needs to be handled separately.


new (docs): initial commit of Dapr review

Co-authored-by: @mrbobbytables
Signed-off-by: Ed Robinson<EMAIL_ADDRESS>

Review requested from @dzolotusky @TheFoxAtWork @angellk

cc @msfussell @yaron2
xref: https://github.com/cncf/toc/issues/1354


Visually hide unstyled or undocumented slots

🧹 Tech Debt
We don't style all the slots that are available in our controls from the fast-foundation templates. For example many controls use the start slots for icon placement but not the end slots.
Ideally we would not expose slots we do not use but that currently requires forking the templates and is not a maintenance burden we currently want to take on for all controls (only as a last resort). FAST is also not currently planning on making that kind of configuration directly available.
For now we should make sure to style our unused slots with display:none and make sure our supported slots and use-cases are documented. This issue should specifically address that unused slots are marked dispaly:none.

We should hide the start slot of the nimble-tabs and nimble-anchor-tabs controls, but we must leave the end slot, because the nimble-tabs-toolbar targets that slot.


Renormalize: CrystalIDEASoftware.UninstallTool version 3.6.1

null
Microsoft Reviewers: Open in CodeFlow

@vedantmgoyal2009  - looks like this is redo of https://github.com/microsoft/winget-pkgs/pull/72919.


Does not know angular('foo').component()

I'm using this polyfill https://github.com/toddmotto/angular-component
It would be great that ng-annotate could work with
angular('foo').component('hello', {
    controller: function($scope) {
    }
});

For more info, see https://toddmotto.com/exploring-the-angular-1-5-component-method/

That's supported since ng-annotate 1.1.1 (but use angular.module('foo').component or myMod.component).
~/projects/ng-annotate % cat tests-issues/issue216.js
angular.module('foo').component('hello', {
    controller: function($scope) {
    }
});
~/projects/ng-annotate % ./ng-annotate-harmony -a tests-issues/issue216.js
angular.module('foo').component('hello', {
    controller: ["$scope", function($scope) {
    }]
});


JDK 11 build fail

Hi, I've to compile JDK11 for arm32 target (cross compiling) ...
So firstly, i'm trying to compile a jdk11 only for same arch and os which is for example a centos7 and i face an issue during the build.
I execute "./makejdk-any-platform.sh jdk11u" cmd and i have following output:

Creating support/modules_libs/java.desktop/libjsound.so from 18 file(s)
/bin/ld: cannot find -lasound
collect2: error: ld returned 1 exit status
gmake[3]: *** [/home/badman/openjdk-build/workspace/build/src/build/linux-x86_64-normal-server-release/support/modules_libs/java.desktop/libjsound.so] Error 1
gmake[2]: *** [java.desktop-libs] Error 1
ERROR: Build failed for targets 'product-images legacy-jre-image test-image' in configuration 'linux-x86_64-normal-server-release' (exit code 2)
Stopping sjavac server
=== Output from failing command(s) repeated here ===

For target support_native_java.desktop_libjsound_BUILD_LIBJSOUND_link:
/bin/ld: cannot find -lasound
collect2: error: ld returned 1 exit status
All command lines available in /home/badman/openjdk-build/workspace/build/src/build/linux-x86_64-normal-server-release/make-support/failure-logs.
=== End of repeated output ===
No indication of failed target found.
Hint: Try searching the build log for '] Error'.
Hint: See doc/building.html#troubleshooting for assistance.
make[1]: *** [main] Error 1
make: *** [product-images] Error 2

Any hints ?

DISCLAIMER: We don't cross-compile anything, so we can't assist too much with getting it working ... Saying that if you can make it work that would be good to document for others ;-)
asound is the ALSA sound library for which you'd normally need the alsa-lib-devel package on CentOS/RHEL

@otmanel31 - any further luck with this or shall I close?

closing due to inactivity. @otmanel31 please feel free to re-open this if it's still an issue


"Ten simple actions to make NanoSafety Cluster Research Output more Findable"

@thomasexner, I could not get the bundle working locally, with the error message Could not find gem 'github-pages (~> 226)' in cached gems or installed locally.
So, I hope you can give it a quick check. It now has all the references, and the two images. Should be good to go.

@egonw: I made some corrections to the references to make it work. If this is okay with you, I would now merge it into main,

I made some corrections to the references to make it work. If this is okay with you

@thomasexner, where can I see those changes?

@egonw: Sorry my mistake. I now merged your changes into the ten-simple-actions branch (without addition/) and removed the conflicts I created. Hope everything is fine now.

Ah, found it. Thanks! Yes, I'm happy for it to be merged in.


Move constants to a dedicated constants file

Currently, there are some constants at the top of src/extension.ts but that list will grow and should be moved to its own file and follow proper TypeScript naming conventions.

I'm going to expand the scope of this issue a bit to include just generally pulling code out of src/extension.ts into separate files. We want to follow a good separation of concerns so that src/extension.ts doesn't become extremely long and bloated.


[Feature] make it more convenient

I want Cocopasty to have the following features so that it is more convenient:

Automatically focus on the input text area once the webpage is loaded.
Press Ctrl + C to copy whole text even when no text is selected or the text area is not focused.
Press Ctrl + Enter to save text.

Those are actually some great ideas, I will see if I can implement them :)


[ZEPPELIN-3631] Increase the maven-shade-plugin version to 3.1.1

What is this PR for?
Increase the maven-shade-plugin version to 3.1.1
What type of PR is it?
Bug Fix
Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3631
How should this be tested?
Check if build succeeds
Screenshots (if appropriate)
N/A
Questions:

Does the licenses files need update?
No

Is there breaking changes for older versions?
No

Does this needs documentation?
No

LGTM

Can you rebase your PRs from the latest master branch? We have fixed CI and you might get green.

You'd better rebase it, not merge master into your branch. Can you do that?


[DNM 2.6.5] Fix timing issue with few control plane nodes

Fixed the case where there is only a single control plane node running in rancher. In this configuration, the rke2-server does not need to be restarted, only the kube-apiserver pod. Also made some general improvements to leader election as well as provisioning, and added a forced wait between rotation phases because the leader will get stuck on reencrypt_active if the commands are run too quickly. I am currently experimenting with lower this. Additionally, if a control plane requires re-provisioning, it will not happen until encryption key rotation either succeeds or fails.
Related Issue: https://github.com/rancher/rancher/issues/35436

@thedadams There is still some weirdness in this PR regarding Conditions on the control plane, as well as general concerns regarding individual machine statuses, but some of those concerns have considerable overlap with this issue https://github.com/rancher/rancher/issues/36993

Just pushed one final update to re-run plans on followers if encryption key rotation was restarted.


DateTime popup dont open automatically when triggered by icon

The error: { TypeError: Cannot read property '_focusActiveCell' of undefined } is thrown when trying to popup calendar date/time by icon, but when the input field is clicked many times the popup shows up, this happens even when outside *ngif tag, code below follows as template/example model:
    <mat-form-field *ngIf="boolean" fxFlex>
        <mat-label>Choose Date/Time</mat-label>
        <input matInput formControlName="dt_to_pick" [matDatetimepicker]="dt_to_pick"
               required>
        <mat-datetimepicker-toggle matSuffix [for]="dt_to_pick"></mat-datetimepicker-toggle>
        <mat-datetimepicker #dt_to_pick type="datetime" openOnFocus="true" timeInterval="5"></mat-datetimepicker>
    </mat-form-field>

An yarn add @mat-datetimepicker/core was made on 21/02/2020 to try on  the most recent version from repository, but the error still persists.

Which exact version are you using? And do you have any code in order to reproduce the problem?
I am generally not doing anything except testing/accepting pull-requests in this repository. Just got the contributor role because the maintainer was inactive for a long time.


Remember hydrometer calibration temp. Fixes #55.

Giving the Hydrometer calculator fragment access to global prefs could probably be done more elegantly, but this is simple and works.

O have updated the files as requested - you were right on both counts.


Update Rust version used in CI

This adjusts the CI to use the stable Rust release from 6 months ago (currently 1.70.0) so that maybe it doesn't need to be updated manually.
The installation of cross is adjusted to use its lockfile, in line with indy-vdr and askar.

Unlike the other repos, this one does not appear to override the Rust version in the Android build for platform version compatibility. That could be added in another PR, but would need a lockfile to be generated with that Rust version.


[Bug]: Scrolling Behavior is Not Move From Bottom to Top Smoothly

Description
GSSOC'23
Issue Description: When Click on Scrolling Top to Bottom Icon, Scrolling Behavior is Not Move From Bottom to Top Smoothly.
Screenshots
When I am Clicking on Below Scroll Bar Icon:

Actual Behavior: ( When Click on Scroll Bar Icon, It stops at the Respective Below Image)

Expected Behavior: (Expect Scroll Bar Fully Stops At the Join us on Discord Header Bar)

Additional information
Note:

One way of Better To Solve This Issue is, I have already Raised One Issue . It's Close to This Present Issue.
Another Way , By Reference That Issue No < #242 > and Solve More Conveniently.

Do you want to work on this issue?

[ ] I want to work on this issue.

assigned @NarendraKoya999

Are you still up?


fix bug #3262  When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled

[Bug][dolphinscheduler-common] When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled #3262

Codecov Report

Merging #3264 into dev will decrease coverage by 0.16%.
The diff coverage is 19.83%.

@@             Coverage Diff              @@
##                dev    #3264      +/-   ##
============================================
- Coverage     34.54%   34.37%   -0.17%
  Complexity     2464     2464
============================================
  Files           443      444       +1
  Lines         20641    20739      +98
  Branches       2532     2541       +9
============================================
  Hits           7130     7130
- Misses        12849    12946      +97
- Partials        662      663       +1

Impacted Files
Coverage Δ
Complexity Δ

...phinscheduler/common/utils/KerberosHttpClient.java
0.00% <0.00%> (ø)
0.00 <0.00> (?)

...pache/dolphinscheduler/common/utils/HttpUtils.java
61.90% <61.53%> (-10.32%)
3.00 <2.00> (ø)

...g/apache/dolphinscheduler/dao/utils/DagHelper.java
27.11% <0.00%> (-1.63%)
18.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2667b...e0a368c. Read the comment docs.

Hi,
Please change the title according to the pr specifications[1]. Thx a lot~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html

ok
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 12:42
主题: Re: [apache/incubator-dolphinscheduler] fix bug #3262 When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Hi,
Please change the title according to the pr specifications[1]. Thx a lot~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Please add the for new code, sonar request 33.3% coverage for new code.

Is that ok？
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 14:07
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Please add test case code the for new code, sonar request 33.3% coverage for new code.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Is that ok？ 原始邮件 发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 14:07 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Please add test case code the for new code, sonar request 33.3% coverage for new code. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

Please add the
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClientTest.java to root pom surfire plugin to run this test.

Thank you very much
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 14:55
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Is that ok？ 原始邮件 发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 14:07 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Please add test case code the for new code, sonar request 33.3% coverage for new code. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Please add the
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClientTest.java to root pom surfire plugin to run this test.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Can you review the code for me？
原始邮件
发件人<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS><EMAIL_ADDRESS>抄送: State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 12:45
主题: Re: [apache/incubator-dolphinscheduler] fix bug #3262 When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
ok
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月22日(周三) 12:42
主题: Re: [apache/incubator-dolphinscheduler] fix bug #3262 When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Hi,
Please change the title according to the pr specifications[1]. Thx a lot~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi~,
There is a ut error, you can check this error.

Please try to remove some meaningful code smell of this pr.

https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3264&resolved=false&types=CODE_SMELL

Hi,
You can try to delete this test case from pom, and try run ci again to check whether it is the oom caused by WorkerRegistryTest.

Hi,
It maybe the error caused by embedded zk according the compile error info, and you can also try to rebase your branch from the newest dev branch and try run the pr ci again.

Hi,
It maybe the error caused by embedded zk according the compile error info, and you can also try to rebase your branch from the newest dev branch and try run the pr ci again.

i see  ，thx

please revert the code format changes, and only keep your changes. it will make our submission records confusing.

please revert the code format changes, and only keep your changes. it will make our submission records confusing.

please revert the code format changes, and only keep your changes. it will make our submission records confusing.

The code format changes have been completed ，Please check the code for me again，thank you

Hi,
Good job,
I create an issue #3332  about HttpClient and KerberosHttpClient can further optimize singleton mode.

Hi,
Good job,
I create an improvement issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode.

Can I continue to optimize my patch

Should I continue to optimize my patch or  create a new patch?
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 19:49
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Hi,
Good job,
I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .

ok, I can do singleton model  optimization 。
I will also implement httpClient support for HTTPS, which I have some experience with.
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 21:53
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Support for HTTPS means that httpClient can access httpClient normally in the case of HTTPS where the gift book is a self-built certificate。
原始邮件
发件人<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS><EMAIL_ADDRESS>抄送: State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 22:03
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
ok, I can do singleton model  optimization 。
I will also implement httpClient support for HTTPS, which I have some experience with.
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 21:53
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Support for HTTPS means that httpClient can access httpClient normally in the case of HTTPS where the gift book is a self-built certificate。
中文：
支持https 是指，在使用自建证书的情况下，也可以通过https url访问。一般自建证书程序会认为非安全会报错。
原始邮件
发件人<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS><EMAIL_ADDRESS>抄送: State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 22:07
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Support for HTTPS means that httpClient can access httpClient normally in the case of HTTPS where the gift book is a self-built certificate。
原始邮件
发件人<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS><EMAIL_ADDRESS>抄送: State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 22:03
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
ok, I can do singleton model  optimization 。
I will also implement httpClient support for HTTPS, which I have some experience with.
原始邮件
发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 21:53
主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264)
Should I continue to optimize my patch or create a new patch? 原始邮件 发件人: Yichao<EMAIL_ADDRESS>收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>State<EMAIL_ADDRESS>发送时间: 2020年7月28日(周二) 19:49 主题: Re: [apache/incubator-dolphinscheduler] [Fix-3262][common] When yourequest the URL through applicationID to get the application status, youcannot get it if Kerberos authentication is enabled (#3264) Hi, Good job, I create an issue #3332 about HttpClient and KerberosHttpClient can further optimize singleton mode. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Hi~,
I think this pr is just for fixing the bug of #3262 , and at present this pr LTGM.
But the issue #3332 is for httpClient singleton optimize, it is not for #3262 , so I create #3332 .
And it will be better if you are interested in optimizing the singleton in this pr, if you want to optimize it, please leave a message, after that I will close #3332 .
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Refactor enricher configuration.

Instead of using String keys sprinkled around all over the code,
typesafe enum are used now. These are defined as inner classes in the
enricher, and provide an overview as well as type safety. Default
values are supported, too.
By accident it forces a certain naming convention. It could be that
this is to strict, but we can relax the constraints later, too.

[merge]


Eval Footer

User story
As a site user with any evaluation role, in order to build my trust using challenge.gov site, I would like to see consistent branding and styling from any page of the site.
Acceptance criteria:

[x] Challenge.gov footer is displayed for logged-in users using Eval capability

Definition of Done
Doing (dev team)

[x] Code complete
[x] Code is organized appropriately
[x] Any known trade offs are documented in the associated GH issue
[x] Code is documented, modules, shared functions, etc.
[x] Automated testing has been added or updated in response to changes in this PR
[x] The feature is smoke tested to confirm it meets requirements
[] Database changes have been peer reviewed for index changes and performance bottlenecks N/A
[x] PR that changes or adds UI

[x] include a screenshot of the WAVE report for the altered pages
[x] Confirm changes were validated for mobile responsiveness

[x] PR approved / Peer reviewed
[x] Security scans passed
[x] Automate accessibility tests passed
[x] Build process and deployment is automated and repeatable
[ ] Feature toggles if appropriate
[x] Deploy to staging
[x] Move card to testing column in the board

Staging

[x] Accessibility tested (Marni)

[x]  Keyboard navigation
[x]  Focus confirmed
[x] Color contrast compliance
[x] Screen reader testing

[x] Usability testing: mobile and desktop (Tracy or Marni)
[x] Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)

[x] Windows/Chrome
[x] Windows/Edge
[x] Mac/Chrome
[x] Mac/Safari
[x] iOS/Safari

[ ] AC review (Renata)
[ ] Deploy to production (production-like environment for eval capability) (dev team)
[ ] Move to production column in the board

Production

[ ] User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
[ ] PO / PM approved (Jarah or Renata)
[ ] AC is met and it works as expected (Jarah or Renata)
[ ] Move to done column in the board (Jarah or Renata)

Figma link: https://www.figma.com/design/VfdBFG8ShVnOStdSNYy9fR/Challenge.Gov-Component-Library?node-id=783-40675&t=OWoWYiIk449UTAiv-0

@r-bartlett-gsa Cross browser complete and passing to you for AC review.


Support null values

Since some properties can be nullable, the default value can be null. We need to check for it explicitly. Otherwise the command will fail with a runtime exception.
Below is the schema to reproduce the issue
openapi: 3.0.1

info:
  title: sample schema
  version: LATEST

components:
  schemas:
    abstractName:
      type: integer
      format: int64
      nullable: true
      default: null

@antonk52 are you able to provide a test for this? I don’t think this PR will have its intended effect.
Also, what should the generated types look like for this? Currently I think it would be:
components: {
  schemas: {
    abstractName?: number;
  }
}

But you’re saying it should be abstractName?: number | null?
Or something else?

> I don’t think this PR will have its intended effect.

not sure I understood this, can you paraphrase it?
The type you provided is incorrect. I did not get why the abstractName is optional in your type example. It is missing the required property, which is by default has value true. the property is nullable though. Therefore the correct type would be
components: {
  schemas: {
    abstractName: ?number; // number | null
  }
}

please note that question mark moved to the right from :.
I am happy to cover this case with a unit test.

It is missing the required property, which is by default has value true

Ah you know what? In the current master we make things optional by default in OpenAPI 3.0, a carryover from Swagger 2.0. But you’re right the schema dictates that all properties are required unless specified otherwise. I’ll make that change in another PR! 🙏

please note that question mark moved to the right from :.

I don’t think that ?number is valid TypeScript; I think it would need to be number | 'null'.

not sure I understood this, can you paraphrase it?

Sorry; I didn’t go into detail before because it was a rather long explanation.
This library uses JSON.stringify()’s replacer parameter, which transforms from the bottom-up.
Your code has if (node === null), which will only transform default: null into default: "null" (the node here is the value).
Then, because it’s bottom-up transformation, it’ll move to the parent node:
abstractName: {
  type: "integer",
  default: "null"
}

Its parent node is of type object, not null, and the the current code finds type: "integer" which will be currently transformed into number. So the previous transformation will be undone.

Anyway I think we should ignore default altogether and just focus on the nullable: true bit. That will actually be pretty far-reaching, because it could affect all types. Basically we need to append a  | 'null' at the end of every possible type this library could generate, which means we need to write a lot of tests for this.
Are you up to the challenge? 😄 I’m happy to let you take on as much as you’d like. I’d really appreciate the help and would love for you to run with this, but also want to be sensitive of your time and contributions, too!
Also, thank you for your feedback and comments! You are right this is important, and something we should definitely handle before we release 3.0 support.

You're right regarding the ?number, I've spent too much time with flowtype recently 😅
Got your point about the default property. I believe it is ignored right now any way, but since there was no explicit check for the null value the bin was failing with a runtime exception.
I've pushed another commit with a draft decision, I would like to hear your thoughts on it before writing any tests.

I think this is the perfect direction! I agree with this. Now it’s just writing tests!
Like we also discussed, it seems like we should probably remove all the ? from the type generation altogether, since if nullable: true that means that it will return  | 'null' as a value, rather than optional. Is my thinking correct?
Or in OpenAPI 3.0, are properties only optional if required: [] is present, otherwise they’re all required? That part I’m confused on. Also, to me that behavior feels wrong I’m also not super familiar with how 3.0 handles required properties (we still use 2.0 at my company).
Either way I’m not saying we have to tackle that in this PR, too, but I am wondering how that’ll affect the tests and whether or not to think about it.

If I got your idea right I'll do the suggest change
- if (node === null) return null;
+ if (node === null) return undefined;

Your assumption about nullable values is correct. As the spec goes
A true value adds "null" to the allowed type specified by the type keyword, only if type is explicitly defined within the same Schema Object.

Therefore the key is still present and we need to change ?: to : when defining the property type.
To determine the optionality of a property in an object we need to check the required field on the Schema Object. The OAPv3 spec notes that it reuses required property exactly as it is specified in the json schema. From which we can come to the conclusion that if not set explicitly in required field, all properties should be treated as optional. This does go out of scope of this PR though 😅

To determine the optionality of a property in an object we need to check the required field on the Schema Object. The OAPv3 spec notes that it reuses required property exactly as it is specified in the json schema.

OK if that’s the case then I think the ? is working as intended? That’s how we treat it now—add ? unless the field name is found within required: [].

Also sorry—my example above was confusing. We do add ? but only for nested properties, not top-level schemas. But other than top-level properties I think it’s working now as the spec intended.

I've updated manifold.ts to have nullable types actually nullable. I have an issue with prettier and escaped string quotes. I think it is related to [un]escape utils but not too sure, any idea on why this is happening?

I have an issue with prettier and escaped string quotes. I think it is related to [un]escape utils but not too sure, any idea on why this is happening?

Ah yeah that’s the most confusing implementation detail of this library—I’m actually wondering if there’s a way to avoid that now, but for this PR, how they work is:
Say you want to transform something to a string TS type. That will be turned into 'string' with JSON.stringify(). So the way to avoid that is by using escape('string') which is just a way of saying “this should be TypeScript, not a string.”
If that’s the issue you’re having then that may be a fix; if not I’m happy to take a closer look later tonight.

As we discussed in the other branch, this PR was on the right track but couldn’t land due to a flaw in the library itself. It’s been resolved in #223


Voyager can't find app.css, app.js, and images

Version information

Laravel: latest
Voyager: latest
PHP: 7.2
Database: MySQL-5.6

Description:
Voyager can't find app.css, app.js, and images. It tries to find it in this directory:
http://projectname/admin/assets/css/app.css. But I have some previous projects with voyager and  there is another path: http://projectname/vendor/tcg/voyager/assets/js/app.css. Also in my current project there is no such a folder: domains\projectname\public\vendor\tcg\voyager\assets, but it should be there, because it is in my previous projects. I reinstall laravel project and voyager several times, but it didn't help. My env: APP_URL=http://shop.project
Additional context
Please help me

https://docs.laravelvoyager.com/getting-started/upgrading#final-steps

Thanks, I have already understood this, but I still have a problem. My voyager panel has no styles.

and no js and no images

Which errors does your browser console show?

I have this issues, too

We need more informations and maybe some debugging.
Latest and latest is not useful for us to help you.
The route is here:
https://github.com/the-control-group/voyager/blob/00c7b80855589b98dca6a692c9abcdd000c6fb7f/routes/voyager.php#L139
And the method here:
https://github.com/the-control-group/voyager/blob/00c7b80855589b98dca6a692c9abcdd000c6fb7f/src/Http/Controllers/VoyagerController.php#L75

I suggest:

Make sure the Voyager directory exists in the vendor directory: vendor/tcg/voyager/
Make sure you have the correct permissions level as described in the Laravel documentation.
Clean your project and reinstall Voyager.

The assets method in VoyagerController read asset files by using path from the Controller directory
$path = __DIR__.'/../../../publishable/assets'.$path;
If you have change config/voyager.php >  controllers > namespace , the asset will be read from your project dir
$path = (Your Controller DIR ).'/../../../publishable/assets'.$path;
You can probably change the asset method from (Your Controller DIR )/VoyagerController.php
At line $path = __DIR__.'/../../../publishable/assets'.$path;
replace _DIR_ with 'TCG\\Voyager\\Http\\Controllers'
It is different from voyager version 1.1 where assets_path can be set at config/voyager.php

Are you using Voyager on nginx ?
try add this code to /etc/nginx/conf.d/YOUR-SERVER.conf
location ~* .(js|css|jpg|png|gif|svg|woff|ttf)$ {
	try_files $uri $uri/ /index.php?$args;
}

Voyager works well if I start php artisan serve and if I add port in browser like this http://shop.project:8000/admin.

I have same problem:
My version information
Laravel: 5.8
Voyager: 1.2.2
PHP: 7.3
Database: PGSQL-11

in order to waiting, i've change my namespace Controller, then in VoyagerController::assets i made
$path = str_start(str_replace(['../', './'], '', $path), '/');
$path = base_path('vendor/tcg/voyager/publishable/assets').$path;

instead of:
$path = str_start(str_replace(['../', './'], '', $path), '/');
$path = __DIR__.'/../../../publishable/assets'.$path;

also i change the proxy mode of nginx in order to use the @akat03 solution upper and now it work

If you override all controllers (what we dont recommend to do anyway) just do
class VoyagerController extends TCG\Voyager\Http\Controller\VoyagerController
and remove the assets() method from your custom controller.

I change same as @FlickTheManual  solution, it work. But I don't like updating like that.
Finally, Any other way? Or ```The Control Group`` should fix this issue and can consider it as a bug.

If you override all controllers (what we dont recommend to do anyway) just do
class VoyagerController extends TCG\Voyager\Http\Controller\VoyagerController

@emptynick, I've got some specific need in the controller, so I used what the team got to me: a Namespace Configuration that's work great, unless this issue, And for sure! It already extends the TCG\Voyager\Http\Controller\VoyagerController

and remove the assets() method from your custom controller.

for sure, I would like to! But I got an error with the original assets() function;
This is why I post it here, just like a temp solution, I loved to help anybody here, but I don't know if it's a problem with my env configuration, or the core framework with this version.
So:

Did you understand that is not the rewrite function 's got a problem, but the original...
Optionally, why I shouldn't do some specific work with a tool you got me to do some custom I want?

and I've searching in the all github repository to show if it's a problem come to mine, but nope, We all got the idea at the same times, I'm sure, to make an issue here about this problem...

I face the same issue with
Laravel 5.7.28
Weird thing is that when i go to admin panel at local machine, everything is fine, issue only happens when i publish to production server and try to go admin panel. All files from /admin/.... are 404 not found.
i already composer update, clear every cache, etc.

Faces same issua as guy above me. Everything is fine on local computer (on windows) and 404 error on production (linux). Tips about change VoyagerController::assets now working for me.

I found this inside routes/voyager.php in vendor folder:
//Asset Routes
Route::get('assets/{path}', ['uses' => $namespacePrefix.'VoyagerController@assets', 'as' => 'assets'])->where('path', '(.*)');

But what if my web-server sendind css/js directly?

Okay, I solved it. But any way, The Control Team, what the ****?! Who write code like this?!
So problem is nginx configuration file. Solution is next additional configuration inside your server{ } directive:
location ^~ /admin/assets/ {
       try_files $uri $uri/ /index.php?$query_string;
}

So now laravel will process queries to /admin/assets URL's.

Okay, I solved it. But any way, The Control Group, what the?.. I think Laravel should NOT route to css, js and image files. I think it's not the best practice.
So "problem" is nginx configuration file for my website. Solution is to add the following strings to your server{ ... } section:
location ^~ /admin/assets/ {
       try_files $uri $uri/ /index.php?$query_string;
}

So now laravel will process queries to /admin/assets URL's and Route::get (that I posted above) will work correctly.

This solution should add into document or user guide

I don't think this is a solution. A laravel package should not require editing nginx config. I am guessing something to do with route cache. Clearing route cache might fix.
php artisan route:clear

I don't think this is a solution. A laravel package should not require editing nginx config. I am guessing something to do with route cache. Clearing route cache might fix.
php artisan route:clear

@nemrutco I already did it, also for any question of caching I did php artisan optimize:clear, but unlucky, it don't work.
also, I'm agree with the @innerdev  answer, unless in the provider, like all route you're done on the core package, i guess the public assets should not come from any of object package by default,  unless it can be publishable and so we can work on this public assets, like the laravel original package work.
I prefer to do as the old 1.1 configuration assets, IMO

https://laravel.com/docs/deployment#nginx

@emptynick and this is for answer what please?

Its the answer to

A laravel package should not require editing nginx config.

And

This solution should add into document or user guide

Yeah! 😄 OK, now, we know!
And so for the assets' problem?
Because it's only on this part, for mine, where I have a problem, unless if I do the solution #4004 .
my nginx config file is significantly the same but the requirement for laravel production is done.
and like the @lohchansiang comment, I've seen the same comportment. and like this comment

It is different from voyager version 1.1 where assets_path can be set at config/voyager.php

and this is, IMO, a better solution, or the package asset configuration come from laravel (here the 5.6 configuration)

We did not change the way how we load assets because we like to make our users angry.
Before, loading assets was done that way, meaning we can not change anything in JS or CSS files without forcing users to re-publish assets.
So changing assets was only possible in a minor version (1.1, 1.2 and so on). Strictly following semver it would only be possible in a major version.
Now for the problem:
If I go to google and search for Laravel Nginx I get a bunch of tutorials on how to configure Nginx applying the exact same "fix" as mentioned above

Now for the problem:
If I go to google and search for Laravel Nginx I get a bunch of tutorials on how to configure Nginx applying the exact same "fix" as mentioned above + the guide from Laravel itself mentioning exactly the same.

I think if this works, we didn't call on this issue, so why not?
for some user, this is the better solution.

Before, loading assets was done that way, meaning we can not change anything in JS or CSS files without forcing users to re-publish assets.
So changing assets was only possible in a minor version (1.1, 1.2 and so on). Strictly following semver it would only be possible in a major version.

And so what the problem with that? Your upgrade guide is well documented, also the documentation entirely are pretty awesome, but some parts missing. It's not a judgement, just an improvement way.  So we can do it for an upgrade, because you've done the assets better! This is not a problem for anybody who want use your framework in a lifetime!
And for semver, it a sort of "code of versioning conduct", not a prisoner chain, isn't it? In this part, you've got some change on asset, so what? You come from 0.11 to 1.1 to 1.2; Some big change on each version, and no one come to judge TCG for that, so what's the problem to do a new forcing publishing asset, especially when you find yourself in a situation like this?
This is a problem, and some done a solution, each in their own way. But, finally, somebody feels that the old configuration is better, so, for the time of an improvement on it, why did you answer like this?

We did not change the way how we load assets because we like to make our users angry.

I don't think of that, as I prefer to consider the improvement of such a tool like voyager, than the feel of somebody mood. And I'm sure that you do your best to improve a nice jewel like voyager.

why did you answer like this?

Like what?

for some user, this is the better solution.

For most, the current is the better.
Again, we don't make such changes to downgrade the user-experience.
Take a look at Laravel Nova, even the makers of Laravel don't use publishes functionality. Coincidence?

What are your current server.location configs?

same as https://laravel.com/docs/5.8/deployment#nginx

Again, we don't make such changes to downgrade the user-experience.

and the new change dowgrade the user-experience too much as a ... so?

Take a look at Laravel Nova, even the makers of Laravel don't use publishes functionality. Coincidence?

hum, not sure about this: https://nova.laravel.com/docs/2.0/installation.html#updating-nova

For the asset() method issue,
I replace the asset routes,

Route::group(['prefix' => 'admin'], function () {
    Voyager::routes();

    Route::get('assets/{path}', [
        'uses' => 'custom\CustomVoyagerController@assets',
        'as' => 'voyager.assets'
    ])->where('path', '(.*)');
});

and add a controller extended from VoyagerController, replace asset() method

$path = str_start(str_replace(['../', './'], '', $path), '/');
$path = resource_path('assets'.$path);

Using this will not required to change the config/voyager > controllers > namespace .

Using this will not required to change the config/voyager > controllers > namespace .

This problem (one of it) only occurs because that value was changed.
Is anyone with the Nginx problem in our Slack group and wants to try some things out?
Please pm me then.

@emptynick i did pm you

Thanks to @nemrutco we figured out that https://github.com/the-control-group/voyager/pull/4004 fixes the problem.
A URL like admin/assets/app.css makes Nginx think that there should be a physical file on disk and doesn't process the request through PHP.
With this PR, assets are loaded as admin/assets?path=app.css

It should be because you have more specific location for img, css and js in your nginx config.
I got the same issue and I had this to resolve :
    location ^~ /voyager-admin/assets/  {       try_files $uri /index.php$is_args$args;       access_log off;       expires 30d;     }

I had to downgrade to 1.1 because in this version I'm unable to extend the logo and background.

Okay, I solved it. But any way, The Control Group, what the?.. I think Laravel should NOT route to css, js and image files. I think it's not the best practice.
So "problem" is nginx configuration file for my website. Solution is to add the following strings to your server{ ... } section:
location ^~ /admin/assets/ {
       try_files $uri $uri/ /index.php?$query_string;
}

So now laravel will process queries to /admin/assets URL's and Route::get (that I posted above) will work correctly.

thanks bro,i fix my problem!!

@emptynick

Have you ever seen this before, and the asset url like
http://www.ic-u.cn/admin/works/2/undefined?path=js/skins/voyager/content.min.css
My nginx have add this:
	location ^~ /admin/assets/ {
       		try_files $uri $uri/ /index.php?$query_string;
	}

Need your help!

If you are on 1.2.3 you can remove this Nginx config again.
Should work then.

@emptynick Hi，i have remove the Nginx config below
	location ^~ /admin/assets/ {
       		try_files $uri $uri/ /index.php?$query_string;
	}

My Nginx config is:
server
    {
        listen 80;
        #listen [::]:80;
        server_name www.ic-u.cn *.ic-u.cn;
        index index.html index.htm index.php default.html default.htm default.php;
        root  /home/www/icu/public;

         location / {
             try_files $uri $uri/ /index.php?$query_string;
         }
        #error_page   404   /404.html;

        # Deny access to PHP files in specific directory
        #location ~ /(wp-content|uploads|wp-includes|images)/.*\.php$ { deny all; }

        include enable-php-pathinfo.conf;

        location ~ .*\.(gif|jpg|jpeg|png|bmp|swf)$
        {
            expires      30d;
        }

        location ~ .*\.(js|css)?$
        {
            expires      12h;
        }

        location ~ /.well-known {
            allow all;
        }

        location ~ /\.
        {
            deny all;
        }

        access_log  /home/wwwlogs/www.ic-u.cn.log;
    }

I am using voyager 1.2.3 ，but it still not work，do i have to make anthing else?

@emptynick wait , I thought of something hha

@emptynick I have override the controller and view，now it work thaks

i have same problem now but on  "nginx:mainline-alpine" docker image
"tcg/voyager": "^1.2"
"laravel/framework": "5.7.*",
ENV NGINX_VERSION 1.15.12
ENV NJS_VERSION   0.3.1

i have tried but no one of them work
location ~* .(js|css|jpg|png|gif|svg|woff|ttf)$ {
        try_files $uri $uri/ /index.php?$args;
}

location ^~ /admin/assets? {
       try_files $uri $uri/ /index.php?$query_string;
}

i have same problem now but on "nginx:mainline-alpine" docker image
"tcg/voyager": "^1.2"
"laravel/framework": "5.7.*",
ENV NGINX_VERSION 1.15.12
ENV NJS_VERSION 0.3.1

i have tried but no one of them work
location ~* .(js|css|jpg|png|gif|svg|woff|ttf)$ {
        try_files $uri $uri/ /index.php?$args;
}

location ^~ /admin/assets? {
       try_files $uri $uri/ /index.php?$query_string;
}

sorry，buy have you solved your problem？

Same symptoms as above, I also get some error logs:
[2019-07-30 14:36:39] production.ERROR: File does not exist at path /usr/share/nginx/xxxxx/vendor/tcg/voyager/publishable/assets/ {"exception":"[object] (Illuminate\\Contracts\\Filesystem\\FileNotFoundException(code: 0): File does not exist at path /usr/share/nginx/xxxxx/vendor/tcg/voyager/publishable/assets/ at /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php:41)
[stacktrace]
#0 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(237): Illuminate\\Filesystem\\Filesystem->get('/usr/share/ngin...')
#1 /usr/share/nginx/xxxxx/vendor/tcg/voyager/src/Http/Controllers/VoyagerController.php(87): Illuminate\\Support\\Facades\\Facade::__callStatic('get', Array)
#2 [internal function]: TCG\\Voyager\\Http\\Controllers\\VoyagerController->assets(Object(Illuminate\\Http\\Request))
#3 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): call_user_func_array(Array, Array)
#4 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(45): Illuminate\\Routing\\Controller->callAction('assets', Array)
#5 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Route.php(219): Illuminate\\Routing\\ControllerDispatcher->dispatch(Object(Illuminate\\Routing\\Route), Object(TCG\\Voyager\\Http\\Controllers\\VoyagerController), 'assets')
#6 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Route.php(176): Illuminate\\Routing\\Route->runController()
#7 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Router.php(680): Illuminate\\Routing\\Route->run()
#8 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\\Routing\\Router->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#9 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(41): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#10 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Routing\\Middleware\\SubstituteBindings->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#11 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#12 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(75): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#13 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Foundation\\Http\\Middleware\\VerifyCsrfToken->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#14 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#15 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#16 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\View\\Middleware\\ShareErrorsFromSession->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#17 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#18 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(56): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#19 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Session\\Middleware\\StartSession->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#20 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#21 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#22 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Cookie\\Middleware\\AddQueuedCookiesToResponse->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#23 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#24 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(66): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#25 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Cookie\\Middleware\\EncryptCookies->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#26 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#27 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(104): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#28 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Router.php(682): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#29 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Router.php(657): Illuminate\\Routing\\Router->runRouteWithinStack(Object(Illuminate\\Routing\\Route), Object(Illuminate\\Http\\Request))
#30 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Router.php(623): Illuminate\\Routing\\Router->runRoute(Object(Illuminate\\Http\\Request), Object(Illuminate\\Routing\\Route))
#31 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Router.php(612): Illuminate\\Routing\\Router->dispatchToRoute(Object(Illuminate\\Http\\Request))
#32 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(176): Illuminate\\Routing\\Router->dispatch(Object(Illuminate\\Http\\Request))
#33 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(30): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}(Object(Illuminate\\Http\\Request))
#34 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#35 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#36 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#37 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#38 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#39 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#40 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#41 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#42 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#43 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(62): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#44 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Illuminate\\Foundation\\Http\\Middleware\\CheckForMaintenanceMode->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#45 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#46 /usr/share/nginx/xxxxx/vendor/fideloper/proxy/src/TrustProxies.php(57): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#47 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(163): Fideloper\\Proxy\\TrustProxies->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#48 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Routing/Pipeline.php(53): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#49 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(104): Illuminate\\Routing\\Pipeline->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#50 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(151): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#51 /usr/share/nginx/xxxxx/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(116): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter(Object(Illuminate\\Http\\Request))
#52 /usr/share/nginx/xxxxx/public/index.php(55): Illuminate\\Foundation\\Http\\Kernel->handle(Object(Illuminate\\Http\\Request))
#53 {main}
"}

The weird thing is I've confirmed the directory exists and the files inside. Not sure why it's erroring.

This error was missing on your page. should be include tag bellow
 <meta name="assets-path" content="{{ route('voyager.assets') }}"/>


Feature request: add labels to init job pod in helm chart

Proposal for adding labels to init job pod in helm chart
Motivation
The helm chart allows custom labels to be added for every kind available in this chart, except for the init job.
Proposed Change
Add a podLabels field (like so) to values.yaml under the init: field and inject these labels here like it's done for annotations.
New or Changed Public Interfaces
This would change the values.yaml of the helm chart.

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. I'm not sure if you were planning to tackle this, or if it was more of a feature request, but we're happy to revisit and reopen this thread if warranted.


[BugFix]Change the RapidsDiskBlockManager in ShuffleBufferCatalog to guarantee the shuffle files can be cleaned successfully..

fix bug described in issue #6240.

@zengruios for us to accept this PR you need to sign it as described here.

@revans2 @abellina Thanks, I will sign and commit in a new PR.


vaultwarden-vault: 2022.6.2 -> 2022.11.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.8.1 with grep in /nix/store/a3fnsl5cq9jqvizljmlsqrxc84w628ry-vaultwarden-vault-2022.8.1
found 2022.8.1 in filename of file in /nix/store/a3fnsl5cq9jqvizljmlsqrxc84w628ry-vaultwarden-vault-2022.8.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a3fnsl5cq9jqvizljmlsqrxc84w628ry-vaultwarden-vault-2022.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/e0e3efb0635b8100c7c96661ac82bea764bb9323.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a3fnsl5cq9jqvizljmlsqrxc84w628ry-vaultwarden-vault-2022.8.1
ls -la /nix/store/a3fnsl5cq9jqvizljmlsqrxc84w628ry-vaultwarden-vault-2022.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault (bitwarden_rs-vault)

Maintainer pings
cc @msteen @Mic92 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.9.0 with grep in /nix/store/h8pkvnvjby3285ynzwri5li2zhqbzi4n-vaultwarden-vault-2022.9.0
found 2022.9.0 in filename of file in /nix/store/h8pkvnvjby3285ynzwri5li2zhqbzi4n-vaultwarden-vault-2022.9.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h8pkvnvjby3285ynzwri5li2zhqbzi4n-vaultwarden-vault-2022.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/68a1ad6202c1dcd3fea1cba8c62b71b787aec795.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h8pkvnvjby3285ynzwri5li2zhqbzi4n-vaultwarden-vault-2022.9.0
ls -la /nix/store/h8pkvnvjby3285ynzwri5li2zhqbzi4n-vaultwarden-vault-2022.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault (bitwarden_rs-vault)

Maintainer pings
cc @msteen @Mic92 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.9.2 with grep in /nix/store/g4c6hh4lf7s6ja0036z6hzczwamfnzsk-vaultwarden-vault-2022.9.2
found 2022.9.2 in filename of file in /nix/store/g4c6hh4lf7s6ja0036z6hzczwamfnzsk-vaultwarden-vault-2022.9.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g4c6hh4lf7s6ja0036z6hzczwamfnzsk-vaultwarden-vault-2022.9.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/25c804250684b6c02e11dd484965aac68ad9cae7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g4c6hh4lf7s6ja0036z6hzczwamfnzsk-vaultwarden-vault-2022.9.2
ls -la /nix/store/g4c6hh4lf7s6ja0036z6hzczwamfnzsk-vaultwarden-vault-2022.9.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault

Maintainer pings
cc @msteen @Mic92 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.10.0 with grep in /nix/store/jj6sb66is2mzmzqby4bvpcf459xiva9d-vaultwarden-vault-2022.10.0
found 2022.10.0 in filename of file in /nix/store/jj6sb66is2mzmzqby4bvpcf459xiva9d-vaultwarden-vault-2022.10.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jj6sb66is2mzmzqby4bvpcf459xiva9d-vaultwarden-vault-2022.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/53930f465a81a8d0ba1c3f36dfee7349c2220d41.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jj6sb66is2mzmzqby4bvpcf459xiva9d-vaultwarden-vault-2022.10.0
ls -la /nix/store/jj6sb66is2mzmzqby4bvpcf459xiva9d-vaultwarden-vault-2022.10.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault (bitwarden_rs-vault)

Maintainer pings
cc @msteen @Mic92 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.10.1 with grep in /nix/store/00kfc1dxfnqzabkcfddip5pb7c2rhxsk-vaultwarden-vault-2022.10.1
found 2022.10.1 in filename of file in /nix/store/00kfc1dxfnqzabkcfddip5pb7c2rhxsk-vaultwarden-vault-2022.10.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/00kfc1dxfnqzabkcfddip5pb7c2rhxsk-vaultwarden-vault-2022.10.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/534115f6ecc2305d7e53ffaf98cca1d910233089.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/00kfc1dxfnqzabkcfddip5pb7c2rhxsk-vaultwarden-vault-2022.10.1
ls -la /nix/store/00kfc1dxfnqzabkcfddip5pb7c2rhxsk-vaultwarden-vault-2022.10.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault (bitwarden_rs-vault)

Maintainer pings
cc @msteen @Mic92 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.10.2 with grep in /nix/store/dvqrh0913y3anii38bndj5b11ip4hvpl-vaultwarden-vault-2022.10.2
found 2022.10.2 in filename of file in /nix/store/dvqrh0913y3anii38bndj5b11ip4hvpl-vaultwarden-vault-2022.10.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dvqrh0913y3anii38bndj5b11ip4hvpl-vaultwarden-vault-2022.10.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/563d0129b7af47cce24b3cd6b679595b20ac6f46.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dvqrh0913y3anii38bndj5b11ip4hvpl-vaultwarden-vault-2022.10.2
ls -la /nix/store/dvqrh0913y3anii38bndj5b11ip4hvpl-vaultwarden-vault-2022.10.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault (bitwarden_rs-vault)

Maintainer pings
cc @msteen @Mic92 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dani-garcia/bw_web_builds/releases.
meta.description for vaultwarden-vault is: "Integrates the web vault into vaultwarden"
meta.homepage for vaultwarden-vault is: "https://github.com/dani-garcia/bw_web_builds"
meta.changelog for vaultwarden-vault is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2022.11.1 with grep in /nix/store/1lgqhjskgwic2y1yckahpacrqi1xk7pz-vaultwarden-vault-2022.11.1
found 2022.11.1 in filename of file in /nix/store/1lgqhjskgwic2y1yckahpacrqi1xk7pz-vaultwarden-vault-2022.11.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
vaultwarden-vault

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1lgqhjskgwic2y1yckahpacrqi1xk7pz-vaultwarden-vault-2022.11.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vaultwarden-vault https://github.com/r-ryantm/nixpkgs/archive/fabbb53a3ed2329d13e039021778e33fdf1078db.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1lgqhjskgwic2y1yckahpacrqi1xk7pz-vaultwarden-vault-2022.11.1
ls -la /nix/store/1lgqhjskgwic2y1yckahpacrqi1xk7pz-vaultwarden-vault-2022.11.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vaultwarden-vault (bitwarden_rs-vault)

Maintainer pings
cc @msteen @Mic92 for testing.

Broke nixosTests.vaultwarden.

Even worse, the new frontend has subtle incompatibilies with the backend. These packages need to kept in sync according to the release notes.
2022.10.0 is what is currently supported for 1.26.0.

Broke nixosTests.vaultwarden.

Warning: a test defined in passthru.tests did not pass

Interesting I had it applied to my server afaik.

Adding an update script in #205943 to keep them in sync. Not sure why selenium can't find the window with the "Create Account" title.


Ctrl-Z in web app undoes other people's latest changes

Description
When working with multiple people at once in the web app, if you press Ctrl-Z, you will undo the latest change done by anyone on the document, not your latest change (which would be more consistent and predictable in general). For example, I'll often be working with other people in a document, and suddenly my latest code disappears because someone made a typo and they pressed Ctrl-Z, which undid my code (more recent), not their typo.
Ctrl-Z should, ideally, be restricted to your own changes, especially because it'll be almost impossible to make sure your change is the latest when multiple people are typing at the same time.
With that said, I can see how it would be useful to undo possible damage done by other people too. That could, however, be a separate keybind or button - or even just be restricted to a future version control feature.
Reproduction URL
No response
Browsers
Firefox, Chrome
OS
No response

My idea would be a normal Ctrl+z and a no-matter-who-did-it "power" Ctrl+Shift+z to have both

Ctrl + Shift + Z is already bound to redo, at least on my keyboard layout (German).

Perhaps Ctrl + Alt + Z ?

Fixed. There is no no-matter-who-did-it power now, but I also don't think it's really useful.


Allow user to specify "localhost:9991" as a realm

... and in the process, unify the URL parsing logic between SmartUrlInput and url.js.
This permits simpler use of the iOS simulator, which has also been documented.

Note that despite GitHub's ordering of these commits, the docs update is indeed a child commit of the "do not append domains" commit.
I've left off converting to const {prefix, suffix} = ..., on the theory that I've done enough violence to recorded history as it is; that can easily be added in a separate commit, if you still think it's worth doing.

Note that despite GitHub's ordering of these commits, the docs update is indeed a child commit of the "do not append domains" commit.

Yeah, GitHub unfortunately has a bug that they've ignored reports of forever, where they show commits inappropriately ordered by author date.
(My guess has always been that someone decided topo-sorting was too hard and/or complicated, and didn't understand Git committer dates -- sorting by committer date would be implemented almost exactly the same, and fix the problem in almost all cases. But who knows.)
Workaround is to ignore the lies on the GitHub UI :disappointed: and take one more reason to look at PRs with git itself.


Explanation for why this package is only compatible with Windows?

I have puppeteer running on a remote Linux based server and would like to be able to change the fingerprint of the browser running in this environment. I understand that this package only works for Windows, but I was hoping you could elaborate on why this is the case.
Is there work that the community can help you with to help unlock additional OS support? If not, are there any other fingerprinting solutions for non Windows environments that you can recommend?
Thanks!

All plugins depend on bas-remote-node which itself depends on BAS engine.
The last one only supports the Windows operating system and it may not change in the future.
Only developers can fix this completely, so the community will not be able to implement full support.
Personally, I can't suggest other solutions than puppeteer-extra-plugin-stealth, but it is much worse in terms of anonymity and provides only a minimum of features compared to the engine in these plugins.

In order to replace fingerprint reliably, browser source must be changed.
If it was done through js injections, such type of substitution is easy to detect.
Linux support requires several time consuming tasks:

Porting OS specific patches, like font replacement, dynamically changing DPI, etc.
Additional patches which will make Linux system look like Windows and Android. We already maintain one direction Windows - Android and it requires a lot of code.
We have several patches which prevents detection of running software on Windows server instead of desktop. And there should be much more for Linux.
Chrome source is constantly changes. All this new patches must be merged each month with new Chromium release.

And of course there will be new Linux specific bugs.
My recommendation is to start browser on same OS that you are trying to emulate, otherwise it will be much easier to detect.


Difference in layout if incollection is referenced via crossref to collection

We have two versions of a @incollection entries in our biblatex database.
Version one (Crossref):
@incollection{lobsinger_two_2013,
	title = {Two Cambridges: Models, Methods, Systems, and Expertise},
	pages = {652--85},
	shorttitle = {Two Cambridges},
	author = {Lobsinger, Mary Louise},
	crossref = {lobsinger_two_2013_main}
}

@collection{lobsinger_two_2013_main,
	location = {Cambridge, MA},
	title = {A Second Modernism: {MIT}, Architecture, and the “Techno-Social” Moment},
	publisher = {{MIT} Press},
	editor = {Dutta, Arindam},
	date = {2013},
	langid = {english},
}

Version two (all data in one entry):
@incollection{lobsinger_test,
	title = {Two Cambridges: Models, Methods, Systems, and Expertise},
	pages = {652--85},
	shorttitle = {Two Cambridges},
	author = {Lobsinger, Mary Louise},
	location = {Cambridge, MA},
	booktitle = {A Second Modernism: {MIT}, Architecture, and the “Techno-Social” Moment},
	publisher = {{MIT} Press},
	editor = {Dutta, Arindam},
	date = {2013},
	langid = {english}
}

I'm wondering why the two entries are laid out differently:
Here's the output of version one - with Crossref:

Here's the output of version two - without Crossref:

With crossrefs the editor ends up after the booktitle. Without crossref, the editor is in front of the booktitle.
The Question: Is there a possibility to change this to a consistent behaviour (in our case: editor after booktitle?). I searched for configuration options but could not find any.
Thanks for any help!
(Duplicate of https://tex.stackexchange.com/questions/684163/biblatex-and-windicity-incollection-editor-before-after-booktitle-depending-on)

Thanks for asking!
The behavior you describe is intended, but there's a way to fix your second example.
When you have just one editor and cross reference entries, as in your first example, Windy City assigns editor to the title of the entry in which it appears. Your first example gives the correct output because you listed editor in lobsinger_two_2013_main.
But when you want to put all the bibliographic information in a single entry, Windy City needs to choose which title editor is responsible for. By default, it chooses title. That's what happened in your second example.
If you want to assign editor to a different title, you need to use the editortype field. For booktitle, the solution is:
@incollection{lobsinger_test,
	title = {Two Cambridges: Models, Methods, Systems, and Expertise},
	pages = {652--85},
	shorttitle = {Two Cambridges},
	author = {Lobsinger, Mary Louise},
	location = {Cambridge, MA},
	booktitle = {A Second Modernism: {MIT}, Architecture, and the “Techno-Social” Moment},
	publisher = {{MIT} Press},
	editor = {Dutta, Arindam},
	editortype = {booktitle},
	date = {2013},
	langid = {english}
}


Handling sparse matrices

I'm getting unexpectedly high memory usage with flox. Here's what I've been doing:
import dask.distributed as dd
import dask.array as da
import numpy as np
import flox

cluster = dd.LocalCluster(n_workers=3)
client = dd.Client(cluster)

M, N = 1_000_000, 20_000

X = da.random.normal(size=(M, N), chunks=(10_000, N))
by = np.random.choice(5_000, size=M)

res, codes = flox.groupby_reduce(
    X.T,
    by,
    func="sum",
    fill_value=0,
    method="map-reduce",
    reindex=True,
)

res_comp = res.compute()

This always warns about memory usage then fails on my dev machine with 64 gb of memory. However, I'm able to do plenty of other operations with an array this size (e.g. PCA, simple reductions). To me, a tree reduction here should be more than capable of handling this size of array.
Is this just me and my compute being odd, or do I have an incorrect expectation here?
cc: @ilan-gold

You're starting with 1.5GiB chunk sizes on X. I would reduce that to the 200MB range.
Also try installing numbagg. It'll be a bit slow to compile but should be faster and make less memory copies.

Running this locally, I also spot a dask scheduling bug where it doesn't treat normal as a data generating task and runs way too many of them initially before reducing that data. Can you open a dask issue please?

Ah I keep forgetting this numbagg only helps with nan-skipping aggregations, so it won't really help here.
I think this is a dask scheduling issue.

I also spot a dask scheduling bug where it doesn't treat normal as a data generating task and runs way too many of them initially before reducing that data.

In my real world use case, I get this just loading data from a zarr store.

I think this is a dask scheduling issue.

Me too, but I'm not sure why flox seems to be triggering it. In the dask issue I show that other tree aggregations with this array (X.sum(axis=0)) seem fine.

Your last comment is important context! (the zarr bit in particular). I would add that to the other issue

Reproducer here: https://gist.github.com/ivirshup/eb4f5beb1bb33724b8c11bd0eacf03a6 from https://github.com/dask/dask/issues/11026#issuecomment-2151141540

This works on my laptop with 32GB RAM with some spilling
res, codes = flox.groupby_reduce(
    X_dense.T,
    by,
    func="sum",
    fill_value=0,
)

If you turn on logging with
import logging
logger = logging.getLogger("flox")
logger.setLevel("DEBUG")
console_handler = logging.StreamHandler()
logger.addHandler(console_handler)

you'll see it automatically chooses method="cohorts" and it just works albeit with spilling. There seems be a densification of each sparse block that could be improved. I'll have to look in to it.
EDIT: your choice of reindex=True was using way more memory than necessary to run this reduction.  You have 2390 unique groups, but there are O(10) groups in the output chunks with cohorts. That means reindex=True was inflating each block to ~ 2390/~10 = 200X larger than it needed to be.

EDIT2: I guess you're densifying on your own...
EDIT3: Memory issues can be controlled by using numbagg and nansum. It's also 5X faster (approx). I guess we should look in to how to make flox just handle sparse matrices directly.
res, codes = flox.groupby_reduce(
    X_dense.T,
    by,
    func="nansum",
    fill_value=0,
    engine="numbagg",
)

How would flox handle sparse matrices directly? graphblas sparse matrix product? We can construct the sparse matrix from by really quickly (we know where the ones are already).

graphblas can be nice, since we can pretty easily define a semi-ring for many tasks here (though, not so sure about median) and it's very fast. But it's always going to be only 2d, and is GPL.
In scanpy right now we are just doing matrix multiplication (code) for in-memory aggregation, but I suspect will end up using some numba kernels since we can get better performance and numerical stability.
@Intron7 may have some thoughts here as he wrote some CUDA kernels for these aggregations in memory.

graphblas can be nice, since we can pretty easily define a semi-ring for many tasks here (though, not so sure about median) and it's very fast. But it's always going to be only 2d, and is GPL.

I was thinking of using it through python-graphblas which is Apache-2.

n scanpy right now we are just doing matrix multiplication (code) for in-memory aggregation, but I suspect will end up using some numba kernels since we can get better performance and numerical stability.

Oh nice! We can move your code into flox as an "engine". "engine"s handle the in-memory part of the aggregation.

I was thinking of using it through python-graphblas which is Apache-2.

The wrapper is apache-2, but it pulls in graphblas which is GPL. So effectively same distribution issues is my understanding.

We could move your code into flox as an "engine"

That's how I've been thinking this sort of thing would work.
Would it be weird to have a "sparse" engine that only works with sparse chunks? Or would you want to add it to another engine?

your choice of reindex=True was using way more memory than necessary to run this reduction. You have 2390 unique groups, but there are O(10) groups in the output chunks with cohorts. That means reindex=True was inflating each block to ~ 2390/~10 = 200X larger than it needed to be.

I am trying to remember why I was using reindex=True. I think it may have just been for a memory usage I could estimate as I had a lot of trouble getting this to work without running out of memory at all.
FWIW, if there is sparse support, then we can increase the chunk sizes, which means we end up hitting more groups.
Also, we don't really have set expectations about the distribution of groups per chunk, so I'd like to be sure this works in the worst case where the labels are well shuffled.

Would it be weird to have a "sparse" engine that only works with sparse chunks?

Don't think so. In general, I'd like users to not set it at all (the default is None now). Constructing a sparse "weights" matrix is another way to do a groupby anyway (Ken Iversion stuck it in his "notation as a tool of thought" paper too!) and flox has scipy as a dependency already.

Also, we don't really have set expectations about the distribution of groups per chunk, so I'd like to be sure this works in the worst case where the labels are well shuffled.

Yeah that would be nice. But it would also be good to get a real example. We might instead look to speed up the reindex=False case to reduce memory usage, and have that be chosen by default.