menu refactor

remove code duplication in the menus using the MenuCommon struct and a MenuBuilder trait.
related #706.

the api for the menus is pretty much the same. the only breaking change is that the common builder functions (with_name, with_marker...) are now in a trait.

Thanks @maxomatic458. We'll take a look at this soon.
/cc @ysthakur I think you were thinking about going in this direction too. Your review would be helpful.

I'll take a look too. I was actually working on that issue too, just hadn't made a PR yet, lol. I only made some helpers, though, so this PR and my branch aren't doing the same thing

i mostly got rid of code duplication by moving the builder methods in a trait (which i guess is somewhat a breaking change)
If you are ok with that, then i can move this PR over to @ysthakur's fork.

That'd be cool. I'd made a completer_input helper function to help with update_values (gets the input that needs to be passed to the completer), a replace_in_buffer helper, and a can_partially_complete helper (for the columnar and IDE menus). They're all after this line in menu_functions.rs. completer_input and can_partially_complete could now become methods on MenuCommon. Caveat: the completer_input helper I made doesn't replace newlines, because I think that might screw up the history completer. Instead, I changed the DefaultCompleter to replace \r and \n with spaces. Other completers would also have to be updated to handle newlines.
Also, to avoid breaking changes, would it be possible to keep Menu the same as before, but have a MenuWithCommon trait for Menus that have a MenuCommon? And then there could be an implementation of Menu for any menu that implements MenuWithCommon. Not sure if that's doable in Rust. It would still mean that anyone building the columnar, list, or IDE menus would need to use the new MenuBuilder, but it'd be less of a breaking change, at least

If you are ok with that, then i can move this PR over to @ysthakur's fork.

@maxomatic458 No need, you can take the stuff from my fork instead since this PR is already up

@maxomatic458 @ysthakur once you all are in a good state with this PR I will review and test as well...
thanks for taking this one for a spin 😄
it will certainly help clean up the code a bit...

@maxomatic458 I reviewed your code so far and it looks really good !  Great job...

Also, to avoid breaking changes, would it be possible to keep Menu the same as before, but have a MenuWithCommon trait for Menus that have a MenuCommon? And then there could be an implementation of Menu for any menu that implements MenuWithCommon. Not sure if that's doable in Rust. It would still mean that anyone building the columnar, list, or IDE menus would need to use the new MenuBuilder, but it'd be less of a breaking change, at least

I think we might just be able to do this here:
pub trait Menu: Send {
    fn common(&self) -> MenuCommon {
        panic!("Not implemented for this Menu");
    }

    fn name(&self) -> &str {
        self.common().name;
    }
    ...
}

this would not break any existing menus, (because the functions common is optional as it has a base implementation and we can expect the menus to already have the name function implemented, so it will be overwritten).
and this could also then be used in a seperate builder trait, which only only be breaking for the reedline included menus (and would be simply fixed by importing the MenuBuilder trait)

@stormasm do you think this panic would be ok here?
if we do it like this we make sure that we stay fully backwards compatible with existing menus

@maxomatic458 Ah, whoops, I didn't read closely enough to see name and other methods were being kept in Menu.
I'm a bit nervous about the panicking. Someone could forget to implement common() as well as name(), indicator(), and the other getters. That said, making new menus is rare, and I think it's unlikely someone would implement an entire menu while forgetting to implement both common and the getters. They'd surely catch it while testing out their menu before the users get it, since nothing would work.
By the way, how about turning MenuCommon into MenuSettings, and only keeping the setting-like fields in there that don't need to be changed? It would mean each menu maintaining its own input, values, and longest_suggestion fields, but I don't think it's a huge deal, since those don't have setter/builder methods like with_name(). You'd then be able to do self.values directly instead self.common.values, and also get rid of common_mut().

I'm a bit nervous about the panicking. Someone could forget to implement common() as well as name(), indicator(), and the other getters. That said, making new menus is rare, and I think it's unlikely someone would implement an entire menu while forgetting to implement both common and the getters. They'd surely catch it while testing out their menu before the users get it, since nothing would work.

The idea is, for new menus you just implement common and common_mut; the other methods (including all the builder methods, and stuff like name(), marker()) dont need to be implemented again because they have their base implementation already;
old menus would continue to work just fine (because the base implementations are overwritten, and the panic basically makes the function optional)

By the way, how about turning MenuCommon into MenuSettings, and only keeping the setting-like fields in there that don't need to be changed? It would mean each menu maintaining its own input, values, and longest_suggestion fields, but I don't think it's a huge deal, since those don't have setter/builder methods like with_name(). You'd then be able to do self.values directly instead self.common.values, and also get rid of common_mut().

we could do this (so we only have the values that we actually need for the builder functions for example), but this would still lead to the structs all having the same fields, but i guess thats not too bad.

The idea is, for new menus you just implement common and common_mut; the other methods (including all the builder methods, and stuff like name(), marker()) dont need to be implemented again because they have their base implementation already

Right, I was just afraid someone making a new menu wouldn't get warned by their IDE to implement common and common_mut. But it's probably not a big deal, it would panic immediately when they tested it so they can't really forget.

but this would still lead to the structs all having the same fields

That's true, only 4 fields would be left in MenuCommon then and that does take away from the point of having it in the first place.

And at least for the builder we need a way to get a mutable reference of this settings object

Ah, didn't realize common_mut was still needed for that

@maxomatic458 code is looking good --- if you are ready to start testing nushell I created a branch pointing to your code so you can see the compiler errors...
https://github.com/stormasm/nushell/tree/menu_refactor_01
After reviewing the compiler errors --- it might give you some more ideas as to how to clean up or improve your menu refactor code --- and then once the reedline code is good and you are happy with it...
If you feel like / or when you feel the time is right...
Go ahead and create your own branch off nushell main just like I did and start working on getting nushell to compile...
Once we have a built version of nushell on your own nushell branch then we can start testing the menu stuff in nushell.
Thanks !  This is looking great so far 😄

@maxomatic458 I made a PR from my branch in case you want to copy the helper functions from there into this PR. I haven't actually finished adding tests, though.
I kinda wish active, event, and only_buffer_difference/input weren't handled by the menu. The event unfortunately can't be passed straight into update_working_details because the list menu needs to know the event when update_values() is called (also, breaking change). And making the only buffer difference thing a responsibility of the completer would be pretty tough to implement :(. Removing is_active() is the only one that seems doable, although it would break code (but as far as breaking changes go, it's not the worst, since you'd only have to remove the active field from your menu). Maybe it could be handled by the engine instead, by keeping one list of inactive menus and a separate list of active menus instead of a single list of all menus.

@ysthakur all great suggestions --- thanks for those and I am sure @maxomatic458 and you will get the code to a place you are both happy with...
We are also not in any hurry to land this code --- its much more important that you feel comfortable with the changes you both are making --- so take as much time as you both need to figure out the best path forward...
I merely did the nushell branch just so we can see so far what compiler errors are showing up on the nushell side of things.
Thanks to both of you for pursuing the refactor --- its looking good so far...

Ok, so i made a MenuSettings struct that looks like this
pub struct MenuSettings {
    /// Menu name
    name: String,
    /// Menu coloring
    color: MenuTextStyle,
    /// Menu marker when active
    marker: String,
    /// Calls the completer using only the line buffer difference difference
    /// after the menu was activated
    only_buffer_difference: bool,
}

which gets rid of all the duplicate builder functions
and i made these changes here to the Menu trait
pub trait Menu: Send {
    /// Get MenuSettings
    fn settings(&self) -> &MenuSettings;

    /// Menu name
    fn name(&self) -> &str {
        &self.settings().name
    }

    /// Menu indicator
    fn indicator(&self) -> &str {
        &self.settings().marker
    }
    ...

to also get rid of those two functions, but this is a breaking change, because now each menu needs a implementation for settings (which could be made optional via the panic approach)
and i also added all the changes from @ysthakur
and for nushell, you basically just need to bring the MenuBuilder trait into scope and thats pretty much it

@maxomatic458 @ysthakur Super fantastic job !!
I got everything compiling on my nushell branch --- and ran through all of the menu types on the Nushell side of the world...
Everything appears to be working fine...  Although it is preliminary testing, I haven't found any issues so far...
The nushell side of the world could probably use a bit more testing....
before we land this PR  on the Reedline side!
Would you all mind running nushell off my branch which is up and running and working...
And see if you see any oddities / weirdness on the nushell side of the world...

Then we will finalize the nushell side of the world to make sure that is good...
And then I will land the nushell side after that....
Again --- wow !  really cool 😄
@fdncred if you feel like doing some testing as well that would be cool...

found an unrelated bug  #727 (but thats on that also happens on the current reedline version)
tested all menu types with different configs and didnt find any bugs (apart from that)

Were we able to avoid breaking changes?

Were we able to avoid breaking changes?

currently the only breaking changes are:

MenuBuilder trait needs to be imported where a menu is built
Menu trait has a new function that needs to be implemented (that could be fixed with a base implementation see above, e.g by panicing)

@maxomatic458 Everything looks good to me too! I guess we'll have to go with panicking since there's no other obvious ways to avoid a breaking change.

Were we able to avoid breaking changes?

@fdncred The completer_input helper that was added to help with update_values doesn't replace newlines with spaces anymore. Either the columnar, IDE, and description menus could do the newline-replacing before calling that helper, or we could leave it to be handled by completers downstream (DefaultCompleter in Reedline has already been changed to handle newlines)

Were we able to avoid breaking changes?

Breaking changes were pretty much non-existent except for some very minor issues which I already dealt with in my Nushell branch....

@stormasm i added a panic, so existing menu implementations (outside of nushell) will not break.
should i leave it in or should i remove it?

@stormasm i added a panic, so existing menu implementations (outside of nushell) will not break. should i leave it in or should i remove it?

Lets leave it in for now....
And see if anyone complains later 😄
Then we can worry about it...
And deal with it...
Unless others feel strongly the other way...
@maxomatic458 What do you think we should do ?

@maxomatic458 @ysthakur
I will plan on landing your PR sometime tomorrow morning (Sunday) my time --- I live in Oregon, USA
I will test your branch more this evening and in the morning...
Then I will play around with the Reedline main branch in nushell tomorrow post landing...
And plan on updating Nushell with the Reedline main branch Sunday evening or Monday morning...
If no one who is testing finds any issues...
Unless someone disagrees --- or for some reason you all don't feel its ready...
This has been an incredible job !  I am impressed 😄
Thanks kindly for both of your efforts...
I think the menu code base will be a lot more solid moving forward...
Meaning it will be a lot easier for us to maintain / others to use and understand better
and just overall a much cleaner menu design for the entire Reedline community...

I'd like to add a couple test cases for the can_partially_complete helper before then. It's not a priority, since the columnar menu already has tests for that and we'd just be moving them from there into menu_functions.rs, but it might make more sense for tests for that helper to live with the other tests for helpers in menu_functions.rs rather than with the tests specific to the columnar menu.

You know what, never mind, it's fine if the can_partially_complete tests live in columnar_menu.rs. I don't want to delay this PR further.

we don't have to do it in this PR but it would be great to have more tests. it seems that tests are the only thing these days that guarantees other changes don't affect previous changes. i know reedline is kind of a special case since it's a line editor but we need to figure out how to do more thorough testing and have more coverage in our tests. i don't want to hold this PR up either but it would be nice to get back to tests at some point.

@fdncred Absolutely, it just so happens that the columnar menu is already thoroughly testing can_partially_complete, and I think the other two helpers we added have all their edge cases covered too. There is the edge case of calling replace_in_buffer where the insertion point isn't the same as the end of the span that's being replaced, but I'm not sure how that'd happen or what the expected behavior should be in that situation (currently, it moves the insertion point around according to the offset but doesn't mess anything up)

That's good to hear. Thanks.

@maxomatic458 @ysthakur We are up and running in nushell with your newest amazing menu code !! 😄


duplicate events after disconnect / connect

Here my code :
socket = io.connect(host);
socket.on('connect', function () {
socket.on('msg', function(data) {
// do something
})
});
If I stop & relaunch my server script (using forever) all msg events will be fired twice ...
If I stop & relaunch again I will see 3x the same event
and so on ...  4x, 5x, etc ...
I'm using socket.io 0.8.7

I think thats probably because you are applying them on each connect and basically a reconnect event is a connect event so when it reconnects it re-applies the event listeners to the same event and u get ghost events..

Yes right, but how to prevent this behavior ?
I used the sample provide by the documentation !?

Ok found it ! :
socket.on('connect', function () {
...
});
socket.on('refresh', function(data) {
...
});
socket.on('msg', function(data) {
...
});
is better
Thank you for your help !


Lowercase the unit_of_measurement for aqi.

While I agree that 'AQI' feels like a better choice this change matches the values reported by the official AirNow integration, allowing values from both to appear on the same graph.

The current unfortunate situation on my dashboard that this would fix:

I've actually removed AQI as the unit and have implemented the AQI Sensor device class instead. There really shouldn't be a AQI or "aqi" unit as it was written before.
I rewrote the majority of the code and will be pushing out an update shortly.

@smmalis37 New release has been pushed out. Be sure to read up on the changes as there are several breaking changes.
The reason the AirNow integration is showing aqi is because the developer manually made that change. By normal standards the AQI unit is capitalized. If you want it to be aqi then just add that as the native unit of measurement in your own code.

https://github.com/home-assistant/core/issues/67302


[ICE: 5] Users cannot view their Pool positions on Arb and do not receive any rewards

Users said they have communicated with our developers!
User wallet address：0xa6c7bb04e35d98ed775fe78efe330ebfe7d059a4

Intercom: https://app.intercom.com/a/inbox/qge2vd8z/inbox/admin/7253511/conversation/1081?view=List

I see it if I impersonate their account


Support for yaml based configuration

I see that you have xml based configuration as shown here - https://github.com/logstash/logstash-logback-encoder/blob/master/src/test/resources/logback-test.xml
Just curious to know if the library supports yaml based configuration instead of XML. If not, would that be considered down the road?

Reji Mathews

logstash-logback-encoder relies on logback for configuration.  Logback configuration supports xml, groovy, and programmatic.  You'll need to file a request for logback for additional configuration formats.


App support of x64-bit Android devices

Hi there, In order to support my android app for x64-bit android devices, I have added
defalutConfig{
.....
ndk.abiFilters 'armeabi-v7a','arm64-v8a','x86','x86_64'`
...
}

in my app/build.gradle file.
But, when I uploaded App Bundle to playstore  onlyarmeabi-v7anative paltform is showing up and also an Warning stating about 64-bit.

Am I missing something! How to support all native platforms??

have the same issue. Hope any one help.

Hi,
I have added this changes:
In gradle.properties:
ABI_FILTERS=armeabi;armeabi-v7a;mips;arm64-v8a;x86;x86_64

Then in build.gradle:
buildTypes {
        release {
            ...
            ndk {
                abiFilters = []
                abiFilters.addAll(ABI_FILTERS.split(';').collect{it as String})
            }
        }
}

thank you @giovannibozzo ! @harshapulikollu did it help?

Duplicate of https://github.com/flutter/flutter/issues/9253


[STORM-1544] Document Debug/Sampling of Topologies

Added documentation for logging/sampling events in a topology.

+1
I think we can add a note about performance issue regarding #1217 when we're sure it does have performance hit.

It looks good can we add a link to this in docs/index.md as well?  Otherwise it will not be easy to find in the UI.

@revans2 The yaml front matter documentation: true should take care of that.
+1

@ptgoetz Not for the release specific docs.  At least I didn't end up setting it up that way, and so if I missed something, then I am happy to go back and try and fix it.

@revans2 Okay. I didn't realize that had changed, I'm okay with either approach.
One thing I did notice is that the documentation dropdown is missing from the home page, and the downloads page is now a 404.
(sorry for hijacking this pull request)

@ptgoetz I didn't realize that we were generating an index using the docs tag.  I am happy to go back and add something in again for it.
Also everything is working fine for me.  what browser are you using?  is there something in your cache that is messed up? Just FYI I renamed the download.html to releases.html, because it includes more then just download links, but the download button points to the proper place.  I am happy to revert that change too if you had other stuff pointing to it.

@revans2 we should add redirection from downloads.html to release.html.

@revans2 It was a caching issue. Sorry for the noise.
I agree with @harshach, we may want to consider a redirect from downloads.html to release.html to keep from breaking external links and bookmarks.
I think we need to add a link to the KEYS file for releases, and it might help to add maven information like we did in the old downloads page.

@revans2 @ptgoetz added a link in docs/index.md

+1 again.
I think we can grep issues on website and raise an issue to follow up.

Appears that some html pages are broken. E.g. http://storm.apache.org/releases/1.0.0-SNAPSHOT/State-checkpointing.html beyond the section "IStateful bolt hooks", the formatting and sections headings are lost. Do we need to fix something in the scripts that generate the html files ?

@arunmahadevan That's likely a typo or formatting error in the markdown file.

@ptgoetz updated the doc to reflect the new (disabled by default) behavior. Please review.

+1


initial config for netlify cms

started adding name attr to frontmatter
set netlify-cms as merge branch right now for testing

I've setup netlify cms oauth to work with this branch...
going to merge to main to see what happens on other branches & on fleek deploys...


KeyError when finding group name

I uncounted a traceback when trying to convert a VOLT file
Traceback (most recent call last):
  File "/home/bobby/.local/bin/volto", line 11, in <module>
    load_entry_point('Volto', 'console_scripts', 'volto')()
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 590, in main
    fea = converter.convert()
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 150, in convert
    self._collectStatements(doc)
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 78, in _collectStatements
    self._groupDefinition(statement)
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 197, in _groupDefinition
    glyphs = self._enum(group.enum)
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 184, in _enum
    return ast.GlyphClass(self._coverage(enum.enum))
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 174, in _coverage
    items.append(self._groupName(item))
  File "/srv/bobby/builds/volto3/Lib/volto/__init__.py", line 166, in _groupName
    return ast.GlyphClassName(self._glyphclasses[name.lower()])
KeyError: 'cons'

The files used are at https://github.com/silnrsi/font-namdhinggo, The command line (running from the source folder) was volto archive/NamdhinggoSIL1006.vtp master-volto.fea. I did not use pip3 to install Volto, instead I used python3 setup.py develop --user. I can reproduce (exactly) the generated .fea from both Nutso.vtp and Nutso.ttf so I would suspect that my installation is functional.

The group AllCons references other groups that are defined after it. I guess this is valid in VOLT but Volto does not handle this well. A simple workaround is to move the definition of AllCons after the definition of the groups it references.

It is not valid for feature files to reference yet to be defined groups, so fixing this will require changing the order of glyph classes when writing them.

VOLT stores groups in alphabetical order, so reordering as a workaround might require renaming the groups in the VOLT project.
Khaled, how difficult would it be to parse the group contents for this kind of reference, and reorder in the .fea code conversion?

What I did in my [similar] tool was to sort the groups alphabetically (so the FEA was more friendly), then before outputing a group I verify I've already output all the groups it contains. If not I set it aside for later and go on to the next group. Eventually (strategies vary but I took a simple one) I re-visit the ones I set aside to see if I can output them yet. Repeat until done.

Yes, something like this should work. I’ll look into it once I have some time, unless someone else beat me to it.

(I was thinking of some sort function that would sort a group that references other group after them.)

We have a VOLT source file that contains this snippet:
DEF_LOOKUP "isol_arab.ARA" PROCESS_BASE PROCESS_MARKS "NONE" DIRECTION RTL
IN_CONTEXT
 LEFT GROUP "PreHehContext"
END_CONTEXT
AS_SUBSTITUTION
SUB GLYPH "aHeh.alt"
WITH GLYPH "aHeh"
END_SUB
END_SUBSTITUTION

Volto blows up on the same line. I personally don't know VOLT, but https://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=VOLT_Tutorial sound like NONE and ALL are special values or something?

The NONE/ALL issue is a voltLib bug, I applied a workaround here and submitted https://github.com/fonttools/fonttools/pull/1732 to fix the root issue.

https://github.com/fonttools/fonttools/releases/tag/4.0.2

I released Volto 0.1.2 with the fix. The original issue reported here still unfixed though, will look into it later.


Update autovacuum settings

We are currently using the default:

autovacuum_vacuum_threshold and autovacuum_analyze_threshold
These parameters determine the minimum number of updates or deletes in a table for the table to be scheduled for an autovacuum and autoanalyzer, respectively. The default for both is 50.
autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor
These parameters determine the percentage of a table that needs to have changes for the table to be scheduled for an autovacuum and autoanalyzer, respectively. The default for autovacuum_vacuum_scale_factor is 0.2 (20%), and autovacuum_analyze_scale_factor is 0.1 (10%).

That can lead to some very incorrect estimates.
@mattwiller comments:
https://github.com/medplum/medplum/pull/2075#issuecomment-1555182144

The defaults are probably reasonable in general, but may not give us tight enough estimates without tuning.  This query should give us all the parameters we could consider tuning and their current values:
select category, name,setting,unit,source,min_val,max_val from pg_settings where category = 'Autovacuum' ;

If we really want the estimates to be reasonably accurate, we may need to use settings like this to force period autovacuum runs:
autovacuum_analyze_scale_factor = 0
autovacuum_analyze_threshold = 10000

This should make Postgres reanalyze the tables to compute statistics about every 10k row writes, no matter how big the table gets.  Do we have logs around autovacuum currently that we could use to diagnose any issues with it?

AWS Aurora Postgres docs:
https://aws.amazon.com/blogs/database/understanding-autovacuum-in-amazon-rds-for-postgresql-environments/

To calculate the threshold, use the following formula:
vacuum threshold = vacuum base threshold + vacuum scale factor * number of live tuples
Use the following values:
Vacuum base threshold – autovacuum_vacuum_threshold
Vacuum scale factor – autovacuum_vacuum_scale_factor
Number of live tuples – The value of n_live_tup from pg_stat_all_tables view

Hypothetically, let's say that we have 1m rows in a table.
Current settings:
autovacuum_vacuum_threshold = 50
autovacuum_vacuum_scale_factor = 0.2
row_count = 1000000
vacuum_threshold = 50 + 0.2 * 1000000 = 200050

@mattwiller's recommended settings:
autovacuum_vacuum_threshold = 10000
autovacuum_vacuum_scale_factor = 0
row_count = 1000000
vacuum_threshold = 10000 + 0 * 1000000 = 10000

Related, we can introduce some basic intelligence here too:

total must always be greater than or equal to the current number of results
when filtering on _lastUpdated, we may always want to use accurate, or perhaps when the cutoff is recent

Background reading:

https://www.postgresql.org/docs/current/routine-vacuuming.html
https://www.enterprisedb.com/postgres-tutorials/postgresql-autovacuum-too-aggressive
https://dba.stackexchange.com/questions/317382/is-there-any-impact-on-postgresql-database-to-run-auto-vacuum-frequently


GLTF 3D models not loading on my server

Hi master Hiukim,
I´m having issues in playing a GLTF 3D model from my server. Your example works fine, but after moving your gltf (Bear and Raccoon) to my server, things stop to work...  Do I need a 3D viewer installed in the same directory of the GLTF file on my server? Why is not loading the 3D files from my server?
Thanks a lot

Hi! did you manage to make it work? I can't seem to find a solution :(

Hi there, yes, the solution that I found was to load your GLTF file on GitHub and place a file called "GLTFLoader.js" next to it. Your 3d model needs to get this name "scene.gltf", after this is placed on GitHub get the link and placed it on your code. Sometimes the 3D model is too small and you don´t see it on the AR experience. hope it helps. Look into Hiukim and follow his trail....
https://www.jsdelivr.com/github

Thank you so much!! it was super helpful! I couldn't find any info related to that issue before! My best regards!


Fine tuning the model : unfreeze layers

Feature request
Ability to fine tune Resnet or other turicreate provided models by unfreezing layers. Hopefully this will help with data sets that are not similar to imagenet.

This is a great feature request. Do you have some particular datasets on which you don't see good performance?

I am using a medical data set.  In Pytorch - unfreezing layers of Resnet50 and retraining it with my data I was able to get better results compared to TuriCreate model. But it is hard to deploy a Pytorch model in iOS.  Tried Onnx but was not successful.

How many layers did you unfreeze? Was it the top 3 layers?

Tried 2 different ways

http://pytorch.org/tutorials/beginner/transfer_learning_tutorial.html
Used different learning rates (lr) for different layers. For earlier layers lr/9 then lr/6 then for top layers lr as described in fastai tutorials.


ausweisapp2 does not see smartphone as network-device

Describe the bug
The ausweisapp2 has the feature that you can use a smartphone in the same wifi network as a authorization device. This does not work on nixos for me right now.
My smartphone successfully connected to AusweisApp2 on Windows, however nixos ausweisapp2 fails to see the smartphone altogether.
Steps To Reproduce
Steps to reproduce the behavior:

install nixos 21.05
install ausweisapp2 on nixos
install ausweisapp2 on android smartphone
follow the instructions of ausweisapp2 for pairing the desktop app with the smartphone https://www.ausweisapp.bund.de/ausweisapp2/help/1.22/en/Windows/settings-remote-reader.html
The step "Your smartphone should now show up in the list of available remote devices." unfortunately does not work - nothing pops up

instead of the desired result

it stays like this for me

Notify maintainers
@B4dM4n  can you help?
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
/nix/store/wzach25vwapl3sa6f7gylqank3jhhsin-bash-interactive-4.4-p23-dev
copying path '/nix/store/wzach25vwapl3sa6f7gylqank3jhhsin-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
- system: `"x86_64-linux"`
- host os: `Linux 5.13.12, NixOS, 21.05.2693.d5aadbefd65 (Okapi)`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.3.15`
- channels(root): `"nixos-21.05.2693.d5aadbefd65"`
- channels(ssahm): `"nixos-21.05.1226.f77036342e2"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Hi,  it seems to be necessary to open port 24727 to be able to use a smartphone as a reader.
https://github.com/Governikus/AusweisApp2/blob/08d15199489e13b084fa515a6490787bcf3414fb/docs/installation/README.en.rst#used-network-ports

worked immediately! thank you very much for your help

Is there any place where this could be documented? So future users do not have to search for the solution again?

would be nice if it could appear hear: https://search.nixos.org/packages?channel=21.05&from=0&size=50&sort=relevance&type=packages&query=ausweisapp2
I guess this just grabs the meta information of the derivation

@schlichtanders @wnklmnn In case https://github.com/NixOS/nixpkgs/pull/136726 gets merged, this should be documented at
https://search.nixos.org/options?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=ausweisapp
Feel free to test/review the PR.


gradio_web_server is outdated

https://github.com/Luodian/Otter/blob/8b386816ec67b15833cde3dcd1d7ca6a752d2451/pipeline/serve/gradio_web_server.py#L16 -- this no longer works since pipeline.constants doesn't exist.
But LOGDIR is defined in https://github.com/Luodian/Otter/blob/8b386816ec67b15833cde3dcd1d7ca6a752d2451/pipeline/serve/serving_utils.py#L11
ETA: gradio_patch starts with a comments saying Adopted from https://github.com/gradio-app/gradio/blob/main/gradio/components.py, and gradio/components.py doesn't exist. Nor does gradio/components/components.py
ETA: Ah, yes, pipeline/serve/examples doesn't exist either

hi you could take a look at this branch:
https://github.com/Luodian/Otter/tree/model_serving/pipeline/serve/examples
Your suggestions on code polish is quite good and I will definitely take them to refine our code. Current issue is due to the shift from previously Otter's serving method into OtterHD's serving method.


dnssec_keyscan.go:149:18: undefined: ed25519.SeedSize

Hi.
When trying to go get github.com/miekg/dns on OSX, I get the following errors:
[2] % go get github.com/miekg/dns                                                      ~/www/tools
# github.com/miekg/dns
../../go/src/github.com/miekg/dns/dnssec_keyscan.go:149:18: undefined: ed25519.SeedSize
../../go/src/github.com/miekg/dns/dnssec_keyscan.go:152:8: undefined: ed25519.NewKeyFromSeed
../../go/src/github.com/miekg/dns/dnssec_privkey.go:86:24: p.Seed undefined (type ed25519.PrivateKey has no field or method Seed)

go version go1.14 darwin/amd64
go env                                                                           ~/www/tools
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/User/Library/Caches/go-build"
GOENV="/Users/User/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/User/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/kt/x9cp3xx52wg9xt7y61187fbh0000gn/T/go-build748959206=/tmp/go-build -gno-record-gcc-switches -fno-common"

Any ideas on how to fix this?

Sorry. It's a dupe of this issue:
https://github.com/miekg/dns/issues/744
and the solution is to go get -u golang.org/x/crypto/ed25519
thank you, guys.

/close
On Sun, 22 Mar 2020, 04:29 aels<EMAIL_ADDRESS>wrote:

Sorry. It's a dupe of this issue:
#744 https://github.com/miekg/dns/issues/744
and the solution is to go get -u golang.org/x/crypto/ed25519
thank you, guys.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/miekg/dns/issues/1093#issuecomment-602142333, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWIW5YNA2M6FDAGY3FUCTRIWAZVANCNFSM4LREQW2A
.


Update portalfx-telemetry-getting-started.md

adding programmatic onboarding instructions

OPS Build status updates of commit 5ce8905:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Publish service's config file: .openpublishing.publish.config.json is not found. Exception:

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support for comments through isso

isso is an open source alternative for discuss that people can selfhost. It works great for weblogs, rather easy to set up, just using a sqlite database.

@aquatix, thank you for your suggestion!
I think this feature should better be implemented via THEME_TEMPLATES_OVERRIDES instead of including it into main Alchemy codebase. There are many different comment engines, and maintaining support for all of them is not feasible.
Documentation for such cases should be written though. I'll look into it again a week from now when I'll be near a real computer again.

Ah cool, good point indeed. I was maybe thrown off a bit because there's Discuss in there, including config for pelicanconf.
As the weekend is now over, I'll await your documentation. It works for me for now with a really nice look (thanks for this theme!). See it here if you like.
Let me know if I can help out somehow!

I'm sorry I worded my previous comment poorly - I'll be travelling for this whole week and I'll get back home on December, 1st.

Maybe I wasn't clear either, as it was the end of the evening and I was really sleepy. I just meant that I'll gladly change it to your preferred way when I looked into your (updated ;) ) documentation, but that currently I'm happy with my 'hack' (I'm using my forked version of alchemy for a bit).
Have fun travelling, and I'm looking forward to trying those overrides when I have some time again.

@aquatix, here is what I meant when talking about THEME_TEMPLATES_OVERRIDES: documentation draft. That way Alchemy can support any comment engine without modifying the theme itself.
Please try it and let me know if that document may be improved in any way.

I think that howto is perfectly clear, thanks. Maybe add a remark about the ISSO_URL setting in pelicanconf.py?
I already thinkered a bit with those overrides a few days ago to get some other functionality implemented, and will add isso this way too. Thanks for your time!

Ok. I will merge the docs and close this PR after that.
Docs will be merged after #84 is closed.

Sure thing!


Fix some copy-paste errors in Bamei Pig breed info

There are some copy-paste errors in the Bamei Pig breed info text.
This PR applies a similar fix to the Bamei Pig breed as was previously applied to other affected Pig breeds (commit a1c23bd).
Example on sandbox: http://wp-np2-25.ebi.ac.uk:5092/Sus_scrofa_bamei/Info/Annotation
Example on staging: https://staging.ensembl.org/Sus_scrofa_bamei/Info/Annotation

Not sure how that got there.
But all seems fine after the patch.
Thanks @twalsh-ebi.


How to add line space between variables and functions

Hi all, i am using fixmyjs to format my code. It is removing all spacing between multiple function, I want to keep one line spacing.
var fn1 = {};
var fn1 = {};
after running fixmyjs its becomes
var fn1 = {};
var fn1 = {};

I need it too. @sbansal6, you fixed this? Thanks

Try the v2.0 branch.

can you merge it to master  :+1:  :)

@goatslacker in v2.0 the same bug :/
👎


Smoke: sometimes enter is not picking the result

This happened in https://dev.azure.com/monacotools/Monaco/_build/results?buildId=146945&view=logs&j=3792f238-f35e-5f82-0dbc-272432d9a0fb&t=07088cf7-fede-5f74-0d50-155edd53af7d&l=76
[2021-12-15T04:59:57.757Z] setValue .quick-input-widget .quick-input-box input readme.md
[2021-12-15T04:59:57.768Z] getElements .quick-input-widget .quick-input-list .monaco-list-row .label-name
[2021-12-15T04:59:57.908Z] getElements .quick-input-widget .quick-input-list .monaco-list-row .label-name
[2021-12-15T04:59:58.117Z] getElements .quick-input-widget .quick-input-list .monaco-list-row .label-name
[2021-12-15T04:59:58.151Z] dispatchKeybinding enter

We see readme.md as search result but dispatching enter does not open the editor.
//cc @Tyriar

My message from the linked issue:

the above screenshot shows the quick access util to open a file is failing, any ideas how this could happen?
https://github.com/microsoft/vscode/blob/224701f74d0f275bbe814f3689729ec323499478/test/automation/src/quickaccess.ts#L82-L88
Enter might be getting triggered before the result is ready for the enter?

Is it possible that the input box didn't have/lost output somehow? Looks similar to this https://github.com/microsoft/vscode/issues/139216#issuecomment-995307679

This needs some investigation as soon as possible because many smoke tests rely on quick pick for opening files.

I can look into this today

Looking into some changes to be more consistent what we do when picking an element, might help for this one: https://github.com/microsoft/vscode/pull/139368

@bpasero the change for openFile looks great and inspiring, especially that it doesn't necessarily rely on element focus. I wonder if we can do the same for https://github.com/microsoft/vscode/blob/2d77c9e23ab39c3eb1ade77215af02359ef6b7ac/test/automation/src/quickaccess.ts#L154-L155
For example, in https://github.com/microsoft/vscode/issues/139216#issuecomment-997078687, we search for a command then want to run the command by pressing enter, however it's blocked by the notification sealing the focus. The focus stealing can happen anytime, by any component. If we can pick the first result and run, it would make the tests less flaky.

@rebornix but a notification toast is never stealing keyboard focus, otherwise users would constantly complain that typing in the editor stops working once a toast shows up?
In https://github.com/microsoft/vscode/issues/139216#issuecomment-997078687, the picker would actually close if it had lost focus, so I doubt that this is the issue here.
The method waitForQuickInputElementFocused is mainly assuring that there is a result item selected in the picker as far as I can tell (I did not add that method).
I wonder what the test failure in https://github.com/microsoft/vscode/issues/139216#issuecomment-997078687 is specifically? Then we can look at the smoke-test-runner.log.

I think this one is probably fine to close, the smoke tests had a lot of green runs lately...


VSphere Multi Endpoint

VSphere
Status

pack extension

Description
Expansion of the vsphere pack to allow for the configuration of multiple vsphere environments.
using the "vsphere" action parameter these environments can be selected.
Checklist (tick everything that applies)

[X] Metadata: pack.yaml, icon, structure (required for new packs)
[X] Version bump (required for changed packs)
[X] Code linting (required, can be done after the PR checks)
[x] Tests (not required but really recommended)

Thanks for the contribution.
Now that we support dynamic values in the new pack configuration (https://docs.stackstorm.com/pack_configs.html), we could perhaps also utilize that (as an alternative to the static config values provided in config.yaml).

Hi Kami. just to follow up our chat on slack. I think to use the new dynamic config for what this is intended would just be a hack of it's functionality right now. I'm not after user level variations. I'm after end point variations. one user - multiple end points. I agree the next iteration could look at using it for individual use creds within each end point though. That is unless i'm missing something on what dynamic config can do.

Think it's ready to review/merge. I have spotted a bug in one of the actions but unrelated to this PR. so i'll fix that in 0.4.1/0.5 (added to read me fo now).

I'll go ahead and merge this into master, but when you get a chance it would be great if you can address things we discussed on Slack :)

Merged, thanks again.


Fix json encoding to follow the spec

The current json encoding is incorrect and should follow the spec. https://github.com/Comcast/wrp-c/wiki/Web-Routing-Protocol#simple-request-response-definition
For example Destination is currently encoded as Destination and it should be dest, also empty fields should show as empty instead of null or empty value.

fixed in https://github.com/Comcast/wrp-go/pull/19


Work around for the issue with close_wait

This is a fix for the issue with connection to the remote endpoint (HOST:PORT) being randomly (actually not) reset or timed out. Described below.

An app running in a container opens a connection to HOST:PORT on a remote server or load balancer
Remote server closes the connection at some point and the app instance keeps it in close_wait state (some libraries and frameworks do this intentionally to save resources by reusing sockets)
In 60 seconds (net.netfilter.nf_conntrack_tcp_timeout_close_wait) mapping between container ip:port and VM ip:port expires however on remote server (or load balancer, or firewall) it usually expires after longer time (defaults for load balancers varies from 180 to 600 seconds, for firewalls even longer)
If something running in another container (completely different unrelated application) on the same cell is given the same source port for a new connection to HOST:PORT it will not only fail, it will also refresh the expiration period on some types of load balancers and it gets back to maximum TTL (for example A10 behaves this way). Normally an ephemeral port is chosen an N+1 to the one which is in use now. In case of failure (timeout or reject) the counter will not be increased so next time the same port will be chosen and it will fail again with refreshing expiration time on load balancer. This can keep happening in a loop for very long (sometimes days) making most of containers on the celll failing to connect to HOST:PORT. This is especially critical for microservices where all the apps connect to the same endpoint (usually load balancer).

To prevent the issue from happening we increase nf_conntrack_tcp_timeout_close_wait from 60 (default) to 900 which is bigger than default timeouts on typical load balancers.

See also https://github.com/cloudfoundry/routing-release/issues/138

Error log sample:
2018-10-31T00:32:43.76+0000 [APP/PROC/WEB/64]OUT 2018-10-31 00:32:43.767  WARN [provider-domain,,,,] 7 --- [gistrationTask1] d.c.b.a.c.r.ApplicationRegistrator       : Failed to register application as Application(name=provider-domain, managementUrl=http://my.domain.local/provider-domain/actuator, healthUrl=http:///provider-domain/actuator/health, serviceUrl=http://my.domain.local/provider-domain/) at spring-boot-admin ([http://my2.domain.local/spring-boot-admin//instances]): I/O error on POST request for "http://my2.domain.local/spring-boot-admin/instances": Connection refused (Connection refused); nested exception is java.net.ConnectException: Connection refused (Connection refused). Further attempts are logged on DEBUG level

Number of errors before (a lot) and after (zero) the change:

@giner Would you consider applying this sort of change to os-conf-release instead?
Though diego-release does have some of these sorts of low level kernel settings we enable/set, it would probably be better if we had a practice of doing these sorts of things in something like os-conf-release and not doing them in other releases as we could have conflicting settings be applied by different components.

As the change is needed only for Diego Cells it should be done either in diego-release (this is probably better) for an instance group in cf-deployment (harder to maintain).

Though diego-release does have some of these sorts of low level kernel settings we enable/set, it would probably be better if we had a practice of doing these sorts of things in something like os-conf-release and not doing them in other releases as we could have conflicting settings be applied by different components.

I agree about conflicts and here is an idea how to solve (or at least detect) them.

@sunjayBhatia As the change is needed only for Diego Cells it should be done either in diego-release (this is probably better) for an instance group in cf-deployment (harder to maintain).

Though diego-release does have some of these sorts of low level kernel settings we enable/set, it would probably be better if we had a practice of doing these sorts of things in something like os-conf-release and not doing them in other releases as we could have conflicting settings be applied by different components.

I agree about conflicts and here is an idea how to solve (or at least detect) them.

PR for os-conf: https://github.com/cloudfoundry/os-conf-release/pull/47

Any progress on this? kube-proxy adjusts the timeout to 1 hour by default for just the same reason.


Downgrade google-auth

Signed-off-by: Paul Belanger<EMAIL_ADDRESS>

Pull-request updated, HEAD is now ced2bef0e0ffd3310d3d3ad7a8f84c380138f2c2


Add piecewise_interpolate_schedule, linear_onecycle, and cos_onecycle.

Closes #19.

The parameters/docstrings for cos_onecycle and linear_onecycle are based on the PyTorch version.
I'm not sure whether to name the methods *_onecycle or *_onecycle_learning_rate. The referenced paper also proposes a onecycle momentum schedule (implemented by PyTorch as well). If optax implements onecycle momentum in the future, it may be confusing.
I tried to keep the API for piecewise_interpolate_schedule as close to piecewise_constant_schedule as I could. Please let me know if the arguments should be re-ordered, renamed, etc. In fact, now the piecewise_constant_schedule is just a special case of piecewise_interpolate_schedule (with a constant interpolation).
What code format/linter does this library use? I just used Google's pylintrc and formatted manually, would be nice to include a setup.cfg or .style.yapf to auto-format code.

Hi @n2cholas !
Apologies for the delay and thanks for the great contribution!

The parameters/docstrings for cos_onecycle and linear_onecycle are based on the PyTorch version.

These look good!

I'm not sure whether to name the methods

Current names seem fine

I tried to keep the API for piecewise_interpolate_schedule as close to piecewise_constant_schedule as I could

perfect!

If you could fix a couple of small formatting issues I can then merge the PR!
Thanks a lot for contributing these!

Thanks @mtthss for the review! I've fixed the formatting and resolved all your comments.

This is now merged! Thanks for your contribution!


DPW-10068 Return response url on error

Tests are failing after coverage check:
Jest: "global" coverage threshold for statements (100%) not met: 99.54%
Jest: "global" coverage threshold for branches (100%) not met: 98.8%
Jest: "global" coverage threshold for lines (100%) not met: 99.66%
Jest: "global" coverage threshold for functions (100%) not met: 99.26%


metrics: update warning messages to debug level

Which issue(s) this PR fixes:

Issue Longhorn/longhorn#8266
What this PR does / why we need it:
Metric collector emits warning messages if the engine is not found during the transition state. Update these messages to debug level to prevent flooding in longhorn-manager.
Special notes for your reviewer:
Additional documentation or context

@mergify backport v1.6.x v1.5.x


chore: fix docker builds for arm64

Overview
Now, this is finally fixed
Ref: https://github.com/rollkit/local-celestia-devnet/pull/63
Closes https://github.com/celestiaorg/devops/issues/527

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

cc: @jcstein and @nashqueue - next releases with this will get us back on track in devX for linux arm64 users

Thnak you !


Deprecated ClusterService and Using NodeClient to fetch meta data

Signed-off-by: penghuo<EMAIL_ADDRESS>Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #774 (699f0ac) into 2.1 (808813d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.1     #774      +/-   ##
============================================
- Coverage     97.71%   97.71%   -0.01%
  Complexity     2801     2801
============================================
  Files           270      271       +1
  Lines          6912     6908       -4
  Branches        439      438       -1
============================================
- Hits           6754     6750       -4
  Misses          157      157
  Partials          1        1

Flag
Coverage Δ

sql-engine
97.71% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ch/sql/opensearch/client/OpenSearchNodeClient.java
100.00% <100.00%> (ø)

.../opensearch/sql/opensearch/executor/Scheduler.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Added config for base path for web UI

Description
Added FLAGR_WEB_PREFIX env so it is possible to serve the static web UI from another path different to /
Motivation and Context
For example, if deploying flagger in ECS behind and ELB it wouldn't be possible to deploy Flagr anywhere but in the /* listener since the Web UI is served in / and the API in /api/v1, this would allow to server the UI from /web/flagr/* for example.
How Has This Been Tested?
Built the code in a docker image, set the environment variable to /web/flagr and the UI was loading from that prefix
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[?] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[?] All new and existing tests passed.

I'm unsure if I am following the code style or if this change needs a test, please let me know, or any other comments. Thanks

Codecov Report

Merging #170 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage      93%   93.02%   +0.02%
==========================================
  Files          25       25
  Lines        1330     1334       +4
==========================================
+ Hits         1237     1241       +4
  Misses         63       63
  Partials       30       30

Impacted Files
Coverage Δ

pkg/config/middleware.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63609e8...144f5bf. Read the comment docs.


Move prom-client to devDependencies

The dependency is pulled in even if you don't use it, but we only use it for the type.
With this change it'll be consistent with how we deal with fastify dependency.

Wait, this will break stuff


Can I extend buildCredentials function?

I looked into buildCredentials function source code:
  buildCredentials(req, username) {
    const usernameField = this.options.usernameField;
    return new Promise(function(resolve) {
      const params = {
        query: {
          [usernameField]: username
        }
      };
      resolve(params);
    });
  }

can I use "extend" here?
let config = app.get('auth')
  app.configure(authentication(config).extend({
    buildCredentials(req, username) {
      //Some customized logic here
    }
}))

@aa403210842 that's what it was designed to do, actually.  Have you tried it out, yet?

@marshallswain seems .extend not working, according to FeatherJs doc, extension function is provided by Uberproto, so I was wandering if we can add Uberproto in to this?

@aa403210842 if you are using ES6 syntax you don't need to use the uber proto style extend but in either case you definitely should be able to extend. I'll have to see what is going on and probably add a test for this.

So I actually had the need to try and extend the local service and it's not really possible with the way that things are structured and the services are initialized. Going to look at how we can refactor to make this more flexible. This is directly related to #226

buildCredentials no longer exists in the new version of auth. Instead you can simply extend the verifier for each auth provider if you need to query by different information.


cmd/link: how are the symbols of the same name in cgo and go processed?

What version of Go are you using (go version)?

go version devel +ef38e21eb5 Sun Apr 7 18:55:23 2019 +0000 linux/arm64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
GOARCH="arm64"
GOBIN=""
GOCACHE="/home/hostname/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/hostname/gopath"
GOPROXY=""
GORACE=""
GOROOT="/home/hostname/go-master"
GOTMPDIR=""
GOTOOLDIR="/home/hostname/go-master/pkg/tool/linux_arm64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build999942006=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I'm trying to enable PIE buildmode with internal linking mode on arm64 (patch url: https://go-review.googlesource.com/c/go/+/163579).  The patch failed to pass the test "pie_internal_cgo" in cmd/dist/test.go. One of the reasons is that the implementation of  relocation type ARM64_TLS_IE is wrong.  Another reason is that the name of the function pointer  (*setg_gcc) in the file runtime/cgo/gcc_linux_arm64.c is the same as the name of the function  setg_gcc in the  file runtime/asm_arm64.s, which causes the link or dynamic linker (I don't know the exact location) to misuse the two symbols. And then leading to another check moduledataverify1 in runtime/symtab.go fails.
When I rename the function pointer variable to a different value, and correct the implementation of relocation type ARM64_TLS_IE, all tests passed.
I have spent some time on this issue but I didn't understand how this issue produce. I think except for x86 and amd64, the issue exists on other platforms too. Any suggestion is appreciate.
/cc @cherrymui @ianlancetaylor
What did you expect to see?
All tests passed.
What did you see instead?
function symbol table not sorted by program counter: 0xaaaab8adae70 setg_gcc > 0xaaaab85febc0 runtime.abort
0xaaaab85a8000 _cgo_3298b262a8f6_Cfunc__Cmalloc
0xaaaab85a8050 _cgo_3298b262a8f6_Cfunc_free
0xaaaab85a8058 _cgo_3298b262a8f6_Cfunc_mygetgrgid_r
0xaaaab85a80a8 _cgo_3298b262a8f6_Cfunc_mygetgrnam_r
0xaaaab85a80f8 _cgo_3298b262a8f6_Cfunc_mygetpwnam_r
0xaaaab85a8148 _cgo_3298b262a8f6_Cfunc_mygetpwuid_r
0xaaaab85a8198 _cgo_3298b262a8f6_Cfunc_realloc
0xaaaab85a81e0 _cgo_3298b262a8f6_Cfunc_sysconf
0xaaaab85a8228 _cgo_3298b262a8f6_Cfunc_mygetgrouplist
0xaaaab85a8278 fatalf
.....
0xaaaab85fe8b0 gosave
0xaaaab85fe8e0 runtime.asmcgocall
0xaaaab85fe9d0 runtime.cgocallback
0xaaaab85fea20 runtime.cgocallback_gofunc
0xaaaab85feb30 _cgo_topofstack
0xaaaab85feb70 runtime.setg
0xaaaab8adae70 setg_gcc
fatal error: invalid runtime symbol table
runtime: panic before malloc heap initialized
runtime stack:
runtime.throw(0xaaaab869c2b3, 0x1c)
/home/erifan01/go-link-test/src/runtime/panic.go:714 +0x54 fp=0xffffea3924e0 sp=0xffffea3924b0 pc=0xaaaab85d31d4
runtime.moduledataverify1(0xaaaab8aad920)
/home/erifan01/go-link-test/src/runtime/symtab.go:451 +0x4c8 fp=0xffffea3925f0 sp=0xffffea3924e0 pc=0xaaaab85ed428
runtime.moduledataverify()
/home/erifan01/go-link-test/src/runtime/symtab.go:416 +0x34 fp=0xffffea392610 sp=0xffffea3925f0 pc=0xaaaab85ecf34
runtime.schedinit()
/home/erifan01/go-link-test/src/runtime/proc.go:537 +0x68 fp=0xffffea392680 sp=0xffffea392610 pc=0xaaaab85d5b48
runtime.rt0_go(0xffffea3934d6, 0x0, 0xffffea3934e2, 0xffffea39350d, 0xffffea393540, 0xffffea393560, 0xffffea393576, 0xffffea39359e, 0xffffea3935d3, 0xffffea3935e1, ...)
/home/erifan01/go-link-test/src/runtime/asm_arm64.s:70 +0xb8 fp=0xffffea3926b0 sp=0xffffea392680 pc=0xaaaab85fc198

I think it's a bug that setg_gcc in runtime/cgo/gcc_linux_arm64.c is not marked static.  Most of the setg_gcc variables in runtime/cgo/*.c are static, and as far as I can tell they all should be.

Yeah, thanks. Marking setg_gcc as static works. I will submit a patch to turn all setg_gcc variables that are not marked as static into static.  In addition, I wonder if the linker needs to do something for such a naming conflict caused by a cgo variable that is not marked as static.

The linker ought to report an error if it sees the same symbol name defined in multiple object files.  I'm surprised that it doesn't.


fix: lint script to emit error

Description of changes
Fix the issue of lint error not emitting

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I've tested this with a couple of open PRs.

Has JS/TS files to lint: curl -fsSL https://api.github.com/repos/aws-amplify/amplify-category-api/pulls/2666/files |  jq -r '.[] | select(.status!="removed") | .filename' | grep -E '\.(js|jsx|ts|tsx)$' | xargs yarn eslint || true
Does not have JS/TS files to line: curl -fsSL https://api.github.com/repos/aws-amplify/amplify-category-api/pulls/1665/files |  jq -r '.[] | select(.status!="removed") | .filename' | grep -E '.(js|jsx|ts|tsx)$' | xargs yarn eslint || true


Support customizations to CSV per operator

To deploy configure-alertmanager-operator I had to edit the CSV to set  MultiNamespace true so it's deployable in openshift-monitoring NS.  Otherwise OLM cannot find an OperatorGroup match.  We cannot deploy two OperatorGroups, see https://github.com/openshift/osd-operators-registry/issues/22

This is a duplicate of #22. See also #25 and #21.


Unable to use after facebook phishing block

Unable to use after facebook blocked my account temporarily for suspicious phishing activity
Steps to Reproduce

run messer
I get this

Error: Failed to login: Error retrieving userID. This can be caused by a lot of things, including getting blocked by Facebook for logging in from an unknown location. Try logging in with a browser to verify.     at facebook_chat_api_1.default (/usr/local/lib/node_modules/messer/node_modules/messen/dist/api.js:51:39)     at /usr/local/lib/node_modules/messer/node_modules/facebook-chat-api/index.js:447:7     at tryCatcher (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/util.js:26:23)     at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/promise.js:510:31)     at Promise._settlePromiseAt (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/promise.js:584:18)     at Promise._settlePromises (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/promise.js:700:14)     at Async._drainQueue (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/async.js:123:16)     at Async._drainQueues (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/async.js:133:10)     at Immediate.Async.drainQueues (/usr/local/lib/node_modules/messer/node_modules/bluebird/js/main/async.js:15:14)     at processImmediate (timers.js:637:19)     at process.topLevelDomainCallback (domain.js:126:23)
Expected behavior: to log in
Actual behavior: can't log in
Versions

npm 6.7.0
node v11.11.0
messer 0.5.0

I'm using Mac OS Mojave

Hey @sormazi , sorry to hear that! Unfortunately, this happens sometimes, and there's nothing we can do about it 😢


Add player and color

Hello Cody!
I watched your video and enjoyed it a lot! Thank you very much for your help!
I had a question and would like to know how I can add players? For example that 3 players would play or even 4?
kind regards,
Vincent

Connect 4 is typically a game for two players, if you want more than two players, you would need to change the grid size and add as many players as you want.


chore(print): removed batchID from print log

I recently started seeing incremental numbers in the logs of a test application. After spending a few hours debugging, I realized the numbers in the logs were from the swift-otel library.

Remove batchID from the console.

@slashmo Please take a look when you have a chance. I think a few folks will be confused just as I did after version 0.10.0 was released.

Apologies for the confusion! This should have never made it into main 😬 Thanks for the PR 🙏

No need to apologize! Thanks for the hard work you've put into making this library the best OTEL libs for Swift on server.

Thanks for the kind words 😊 I tagged a 0.10.1 release with your fix: https://github.com/slashmo/swift-otel/releases/tag/0.10.1


Task1 and Task2

Task 1 : Log message
Task 2 : Created a PDD for Login validator task

5 Points are assured. No Errors found by AI system, you must be really good in writing uipath code. An expert need to review your code and it will be done before next sunrise :)

@gayathrigundaveni please mention task id in the pr

SourceCode/2024/May 2024/Projects/gayathri/Task1_Projects/project.json
file: Main.xaml

The workflow starts correctly
There are no obvious errors or issues with the main logic of the workflow

file: Process1.xaml

The workflow has a high level of repetition in its activities (e.g., multiple ForEach loops)

Consider refactoring to reduce repetition and improve code readability

Some activities could be grouped together into a reusable component

This would make the code more modular and easier to maintain

file: Process2.xaml

There are several unused variables declared throughout the workflow

Remove any unnecessary variables to declutter the code and prevent confusion

The use of Wait For Child Activity is heavy-handed; consider using a more targeted approach (e.g., Wait Until)

This would improve the performance and reliability of the workflow

file: Settings.xaml

The settings file has some redundant or unnecessary key-value pairs

Simplify the settings by removing any unused or duplicate information

There are no obvious errors with the settings data

Score: 4/5

SourceCode/2024/May 2024/Rajendra/Task1/project.json
main.xaml
Log messages are not used in workflow Main.
To improve understanding of the workflow flow path and error identification during development and after release, consider using log messages.
score: 4/5
Dependency packages
The following dependency packages are not used:

UiPath.Excel.Activities
UiPath.Mail.Activities
UiPath.Testing.Activities
UiPath.UIAutomation.Activities

Removing unused packages can improve process execution time and reduce complexity. Consider removing these packages.
score: 4/5
Activity Input Dialog
The default name of the Activity Input Dialog could be improved for better understanding.
Add a more descriptive title to make it easier to understand what the activity does.
score: 4/5
Activity Message Box
The default name of the Activity Message Box could be improved for better understanding.
Add a more descriptive title to make it easier to understand what the activity does.
score: 4/5
Total score: 16/20

@gayathrigundaveni
Task -1
Code verified.
Task -2
Document verified. Need to complete try to fill important tabs


Java indexer: make use of StatisticsCollector [phab:D326]

Created by schroederc at 2015-06-09 19:22:06:

schroederc wrote at 2015-06-09 19:26:13:
Don't preprocess statistic names

schroederc wrote at 2015-06-09 19:29:34:
Remove duplicate counter

shahms commented inline (context lost during migration) at 2015-06-09 19:56:39:
[off-topic] Why are we using ad-hoc command line parsing? Isn't there a decent library for doing this in Java?

shahms accepted this revision at 2015-06-09 19:56:39

schroederc commented inline (context lost during migration) at 2015-06-09 19:58:46:
We had JCommander, but it was deleted during the Bazel migration.
These binaries are pretty simple, though.  Any more flags, and I'll reimport it.

schroederc closed via commit ed3e3aafa8d97f723847608c4e508e8b34dbdc55 at 2015-06-09 19:59:45


2023-10-11 commit

Name Added to README.md

closing due to inactivity feel free to reopen at any time


Manual testing of Assessments

There have been a number of issues reported with Assessments. Let's take some time to aggressively test, document any bugs and then fix.
We are not testing the admin journey nor the Notify email sending. Our journey starts once the Assessor has received an email containing a link to upload their assessment.
The Assessor should be able to follow the link, view instructions for what they need to do, download a template, upload their assessment and submit it. Each assessment has a due date and a hard limit date. An assessor should be able to upload before and after the due date but not after the hard limit date. [TODO: we need to better document the scenarios and expected journeys here]
The format of the link that's emailed to the assessor is:
ASSESSMENTS_URL + '/sign-in?email=' + EMAIL + '&ref=assessments/' + ASSESSMENT_ID

Note: See documentation#18 for more info on documenting the journey being tested and on capturing the results.

WE tested thoroughly the Assessments on the sprint. I am closing this task.
If some other test is needed on another sprint we should create a new task and story point it accordingly.


Added a new sub workflow #annotation_statistics.nf that outputs the annotation statistics in the gff3 file  to solve issue #121

Added  a new sub workflow called annotation_statistics.nf
modified the nextflow.config file with added parameter "params.annotation_set" - the path to the gff3 file
added a new module from nf_core - gt/stat

This PR was created in error and has been superceeded by #133


Fix polling HomeKit devices with multiple services per accessory

Description:
While testing the new beta to see if #25249 helped with scaling and stability issues with many homekit entities @niemyjski reported seeing this traceback:
2019-08-01 07:54:51 ERROR (MainThread) [homeassistant.components.homekit_controller] Exception in async_state_changed when dispatching 'homekit_controller_43:0A:AB:59:F0:BC_state_updated': ()
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/__init__.py", line 126, in async_state_changed
    char_name = escape_characteristic_name(self._char_names[iid])
KeyError: 66

HomeKit accessories are made up of Accessories, Services and Characteristics. Most of the devices i work with are either a single accessory with a single service or for a bridge like Hue, many accessories each with a single service. But there are also devices with many accessories and many services and also 1 accessory with many services. Sensors often have CO2, temperature and humidity as a single accessory with multiple services.
The code in #25249 didn't adequately consider these devices and failed when encountering a characteristic from another service on the same accessory. This PR handles that case.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the [development checklist][dev-checklist]

Can this be go in 0.97.0 too as its a regression.


Unit tests for Utils.JSON.TJSONHelper

DUnit test project for Utils.JSON.TJSONHelper

Two of the test cases do not pass as I believe TJsonHelper.Equals(a, b) should throw an EArgumentNilException when either a or b is nil

Thanks for contributing! Would you mind exchanging the TABs with spaces, before I merge your PR?

Two of the test cases do not pass as I believe TJsonHelper.Equals(a, b) should throw an EArgumentNilException when either a or b is nil

I would rather like the unit test to not expect an exception in this case. The reason I designed the method like this, is to match the behaviour of TObject.Equals for the nil edge-case:
function TObject.Equals(Obj: TObject): Boolean;
begin
  Result := Obj = Self;
end;

What do you think?

Would you mind exchanging the TABs with spaces

I have never done such a hideous thing before so I have to ask: Is converting ↹ to two spaces correct?

I would rather like the unit test to not expect an exception in this case.

Sure, that's legit. I have altered the test case. But to be in line with .NET or Java, it should return true if both arguments are nil. For now, it throws an access violation.

I have never done such a hideous thing before so I have to ask: Is converting ↹ to two spaces correct?

Yes, that would be great.

it should return true if both arguments are nil. For now, it throws an access violation.

Oh, that indeed is a bug on my side. I'll fix this after merging your PR.

Thanks! Merged. The bug should be fixed as well.


HighestMp Reinforce Strategy not working

Hello Cocco!
The .env option USER_1_TEAM_1_REINFORCE_STRATEGY="HighestMp" is not working, it still reinforces HighestBp.
In order for this strategy to work, I am currently replacing ReinforceStrategy.py to supply "HighestMp" as a strategy name.
  # Create the strategy object and use it to get the crab to borrow     strategy: ReinforceStrategy = makeReinforceStrategy("HighestMp", mine, maxPrice)     return strategy.getCrab(lootingOrMining)
Additionally (for looting), reinforceAttack is not working. Automating reinforce on looting and settling is a big help already, we can just find match manually.
I have tried the fix suggested here https://github.com/coccoinomane/crabada.py/commit/269275c572bfbb21ba71dea1d6c2e3edf6ae95be#r68697734 but it can't find any crabs despite high availability of Bulks (HighestBp)

Hi @nikojaro , thank you for your feedback!
I did not manage to reproduce your issue with the reinforce strategy, it all works fine for me.
I have pushed a new test, could you please try to run it:
python3 -m src.tests.strategies.reinforce.testMakeReinforceStrategy

The test will print the strategy that will be used to reinforce & print the crab that the strategy will choose.
I have run the test on my side and it correctly selects a high MP crab when USER_1_TEAM_1_REINFORCE_STRATEGY="HighestMp", here's a screenshot.

PS: As for reinforceAttack , there was indeed a bug and I fixed it in the last commit.
Could you please try reinforceAttack again and open a new issue (separate from this one) if you still have problems?
Cheers,
Cocco

Hi @nikojaro , thank you for your feedback!
I did not manage to reproduce your issue with the reinforce strategy, it all works fine for me.
I have pushed a new test, could you please try to run it:
python3 -m src.tests.strategies.reinforce.testMakeReinforceStrategy

The test will print the strategy that will be used to reinforce & print the crab that the strategy will choose. I have run the test on my side and it correctly selects a high MP crab when USER_1_TEAM_1_REINFORCE_STRATEGY="HighestMp", here's a screenshot.

Hi Cocco,
Thanks, I’ll try it out. I’ll clear pycache before running. Do you think that should be included in the README section?

PS: As for reinforceAttack , there was indeed a bug and I fixed it in the last commit.
Could you please try reinforceAttack again and open a new issue (separate from this one) if you still have problems?
Cheers, Cocco

Hi Cocco,
I am getting the following error for reinforceAttack
Traceback (most recent call last):   File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main     return _run_code(code, main_globals, None,   File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code     exec(code, run_globals)   File "/home/ec2-user/crabada-niko/bin/looting/reinforceAttack.py", line 28, in                                                                                <module>     nReinforced = reinforceAttack(userAddress)   File "/home/ec2-user/crabada-niko/src/bot/looting/reinforceAttack.py", line 40                                                                                , in reinforceAttack     strategyName = user.getTeamConfig(mine["team_id"]).get("reinforceStrategyNam                                                                                e") AttributeError: 'NoneType' object has no attribute 'get'
Tried clearing python cache but I'm still getting the errors.
find . | grep -E "(pycache|.pyc|.pyo$)" | xargs rm -rf

Hi @nikojaro , thank you for your feedback!
I did not manage to reproduce your issue with the reinforce strategy, it all works fine for me.
I have pushed a new test, could you please try to run it:
python3 -m src.tests.strategies.reinforce.testMakeReinforceStrategy

The test will print the strategy that will be used to reinforce & print the crab that the strategy will choose. I have run the test on my side and it correctly selects a high MP crab when USER_1_TEAM_1_REINFORCE_STRATEGY="HighestMp", here's a screenshot.

Working correctly now.
src.common.logger - INFO - Borrowing crab 9230 for mine 2440900 at 20 TUS... [strategy=HighestMp, BP=220, MP=82]
src.common.txLogger - INFO - 0xd125d79d182af35c0c8099fcc1b3c99cd121f9e7556ebbad0485802e0f82b5c6
src.common.logger - INFO - Mine 2440900 reinforced correctly
src.common.logger - INFO - Borrowing crab 9230 for mine 2440894 at 20 TUS... [strategy=HighestMp, BP=220, MP=82]
src.common.txLogger - INFO - 0xd911b2ce591f0ef328f1af667b1ca4ee60f3a5fa73cc2b09a4dd95f6bbbdb97d
src.common.logger - ERROR - Error reinforcing mine 2440894
src.common.logger - INFO - Borrowing crab 9230 for mine 2440848 at 20 TUS... [strategy=HighestMp, BP=220, MP=82]
src.common.txLogger - INFO - 0x40b497232a8e68da31903d11947f756efef4bd04ecfa442fc3b4c23eb3702258
src.common.logger - ERROR - Error reinforcing mine 2440848

P.S I have also tested reinforceDelay yesterday and it was working stable for about 20 hours.

Closing this issue now.


Mention that colon is not for instrumentation use

The colon is intended for use in a naming convention for aggregation on the Prometheus side, not by instrumentation. That is to say it's reserved for user use.
We should specify this, as it's not uncommon to see instrumentation use this where they should have used an underscore.

This is in between implementation-specific and BCP, and it becomes non-trivial to explain why federating job:up:count is valid without falling back to "this is how Prometheus does it". If someone were to cache/proxy using this format "that's one more hop" becomes a non-argument, and an exporter might choose to simply pass things on; without being instrumentation so not covered by your statement.
SHOULD-level of "this is reserved", please use snake_case with this charset unless you must use something else might be an acceptable trade-off.


Described menus don't exist on MacOS VS

This guide described in the purple "Note" section is not correct for MacOS

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d2642c7f-04bb-56eb-0f26-d867703cf2f4
Version Independent ID: 9c3f65b2-143b-8053-35ad-866152ea905e
Content: Encoding and line break characters - Visual Studio (Windows)
Content Source: docs/ide/encodings-and-line-breaks.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@jelmerS2 Thanks for your feedback. The page you reference is specifically for Visual Studio for Windows, and not for Visual Studio for Mac:

For information about Visual Studio for Mac, i.e. the MacOS, please see the content set for it, here: https://docs.microsoft.com/en-us/visualstudio/mac/.


JSON format outputs a line delimited JSON.

This PR is a solution of #379 .
Currently, if designate json to format and multiple files, output of tslint is not a JSON.
I propose the line delimited JSON.
The line delimited JSON is machine readable than currently.

well, it's still not producing valid JSON even after this change, right?
instead of:
{ ... }{ ... }

we now have
{ ... }
{ ... }

so what has been solved here? just readability for humans?

Yes, still not valid JSON.
I improved readability for humans and machines.
After this change, we can use readline module for parsing the Line delimited JSON.
https://nodejs.org/api/readline.html
for example.
// parse.js
var readline = require('readline');

var rl = readline.createInterface({
  input: process.stdin,
  output: process.stdout
});

rl.on('line', function(line) {
  var parsed = JSON.parse(line);
  DoSomething(parsed);
})

$ tslint | node parse.js

I think we can handle the output of tslint more easily.

Is using tslint like that with unix pipes a common use case? Wouldn't you be better off using the programmatic API?

Wouldn't it be better to have the formatter handle all the files at once (#680 would enable this?)

@lbesson yes, it would, which is why i'm opposed to this PR. This change is a band-aid that doesn't address the real problem. Closing for now.


Make global site font size configurable via theme

Make it so and the tell @StevenCannon-USDA all about it.

@StevenCannon-USDA The requested feature has been implemented in the configurable-font-size branch; the global font size can now be modified using the style.font_size variable in your site's _config.yml file. It looks like there's several other font sizes that this does not affect, so have a look and see if it's good enough or if we need to wrangle a few more.

Thanks! That was quick. @maxglycine will also be happy to have this.

Bumping this to see if @StevenCannon-USDA or @maxglycine had a chance to try it out.

Not yet. Probably later this week, after I clear a few other things.

Just for grins I went extreme and set the font_size = 64px for demo purposes here in _config.yml:
UIkit theme customization (sets colors, font size, etc.)
style:
link_color: '#0071B3'
link_hover_color: '#018fe2'
global_muted_color: '#666'
primary_background: '#87a96b'
invert_navbar_text: true
font_size: '64px'             <------------
which definitely worked:
https://jekyll.dev.lis.ncgr.org/
On 9/18/23 09:30, Rex Nelson wrote:

I am a neophyte so where would I try it out?
—
Reply to this email directly, view it on GitHub
https://github.com/legumeinfo/jekyll-theme-legumeinfo/issues/27#issuecomment-1723716430, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLFFA3WNLDKBWCERNIWDLDX3BSHTANCNFSM6AAAAAA4XCRS2E.
You are receiving this because you are subscribed to this thread.Message ID:
@.***>

Could we also have the ability to choose the “font-family”?

Thanks for setting up an example @sammyjava. It demonstrates that some of the font sizes aren't affected by the $global-font-size UIkit parameter that the style.font_size variable in the config file is bound to. Are you, @maxglycine, and @StevenCannon-USDA OK with this or do you want control over these other font sizes are well?

Could we also have the ability to choose the “font-family”?

Yes. I'll push a commit that does that.

The configurable-font-size branch has been updated so that the global font family can now be modified using the style.font_family variable in your site's _config.yml file. Similar to the font size feature, there's other font families in the site/theme that this does not affect. Let me know if you want control of those as well. Also, it's good to specify a series of fonts (via comma separated list) so that there's similar fonts to fallback to if one or more aren't present on the end-user's system; see the theme's _config.yml file for an example.

Fabulous!  Thanks so much!

That sounds good to me

I apologize for the delay on this; I've been preoccupied with a grant proposal. Would someone else be willing to tackle this? Maybe @svengato?

I will look into this and estimate the workload.

Thanks @svengato!

I checked out the configurable-font-size branch, and can update the font size and font family through _config.yml.
Just to confirm, is the goal to do the same for global-small-font-size through global-2xlarge-font-size, either by allowing the user to set each one by hand, or by automatically scaling them from the specified font_size? Does anyone strongly prefer one method over the other? I think automated scaling would be cool.
What about the "base" font sizes (for preformatted text like code samples)? We could scale these to font_size as well.

We also need default global font sizes for when the user does not specify font_size. I can restore that.

Just to confirm, is the goal to do the same for global-small-font-size through global-2xlarge-font-size, either by allowing the user to set each one by hand, or by automatically scaling them from the specified font_size? Does anyone strongly prefer one method over the other? I think automated scaling would be cool (otherwise one could make the "large" fonts smaller than the "small" ones).

Correct; we want to make the global-small-font-size through global-2xlarge-font-size configurable as well. I think by default these should scale relative to global-font-size, with the ratios being derived from what's currently in our theme. This means only global-font-size will need a default value, which is already being set in the theme's _config.yml and, thus, will be passed on to any site using the theme.

What about the "base" font sizes (for preformatted text like code samples)? We could scale these to font_size as well.

I think for now we should limit it to the sizes we've already discussed. There's so many that going beyond these fundamental ones is a slippery slope!

Automatic font scaling tentatively works, using Liquid operations rather than Sass calc().
{% assign fs = site.style.font_size | replace: "px", "" %}
$global-2xlarge-font-size: {{ fs | times: 2.5 }}px;
[...]

Next: handle case(s) where units are other than 'px'.

Automatic font scaling tentatively works, using Liquid operations rather than Sass calc().
{% assign fs = site.style.font_size | replace: "px", "" %}
$global-2xlarge-font-size: {{ fs | times: 2.5 }}px;
[...]

Next: handle case(s) where units are other than 'px'.

Nice. It's pretty cool we can use Liquid in Sass.

Liquid instead of Sass.

On further investigation,

calc() is part of CSS, though there are Sass extensions. I prefer this approach over Liquid times because it automatically handles the units.

Unfortunately, it causes syntax errors which I traced to uikit/src/scss/variables-theme.scss not using calc() in lines like

$article-title-font-size: $article-title-font-size-m * 0.85 !default;

This should really be
$article-title-font-size: calc($article-title-font-size-m * 0.85) !default;

which works as expected. For now, we would have to make this correction everywhere we use uikit, but a long term solution would be to either make our own fork of uikit or submit a pull request.

The !default syntax seems to mean that default values exist, so I can remove the current ones (as @alancleary did for '15px' in commit 394c625db2cc6221b4d9f1c7b690f29031253925). In other words, you may ignore the "We also need default global font sizes" comment above.

According to uikit/src/scss/variables-theme.scss, the font scaling factors are
$global-2xlarge-font-size: 2.625
$global-xlarge-font-size: 2
$global-large-font-size: 1.5
$global-medium-font-size: 1.25
$global-small-font-size: 0.875
which slightly disagree with our current hard-coded font sizes, but I will stick with them.

Done in PR #40.


Cleanup email classes

rename email_delivery_activity to email_activity
replace receiver/sender hostname/ip attributes with dst/src endpoint attributes

@ablyler did we want to move the peripheral event from the system category to the network category?

Should we get rid of the email_url and email_file event classes and just add optional url and file to the email class? This would be cleaner and those classes have just one additional attribute.

@ablyler did we want to move the peripheral event from the system category to the network category?

Good catch, I hadn't rebased which caused this issue. That should be fixed now.

@ablyler did we want to move the peripheral event from the system category to the network category?

Good catch, I hadn't rebased which caused this issue. That should be fixed now.

The the peripheral event is not a "network" event --peripheral devices are things like printers, usb drives, fax machines, etc.

Should we get rid of the email_url and email_file event classes and just add optional url and file to the email class? This would be cleaner and those classes have just one additional attribute.

We could consider that for sure, it would probably need to be an array of urls and files. I guess the only downside is that you can't then map a specific threat to a specific url or file. For instance, if an email contained malware in one attachment and the other attachment was clean.

We can discuss this before moving from dev to main.


Color bar with colormap gradient

How to add a bar with color gradient equivalent with Matlab's colorbar that shows up when we plot a surface in Matlab?
Like the image below, but vertically.  No associated surface plot needed.

You can do this using the Cairo renderer by passing in a list of colors in colorscale, like this:
from manim import *
import numpy as np

class Test(ThreeDScene):
    def construct(self):
        resolution_fa = 42
        self.set_camera_orientation(phi=75 * DEGREES, theta=-60 * DEGREES)

        axes = ThreeDAxes(
                x_range=(-3, 3, 1),
                y_range=(-3, 3, 1),
                z_range=(-5, 5, 1)
                )

        def param_trig(u, v):
            x = u
            y = v
            z = 2 * np.sin(x) + 2 * np.cos(y)
            return z

        trig_plane = axes.plot_surface(
            param_trig,
            resolution=(resolution_fa, resolution_fa),
            u_range = (-3, 3),
            v_range = (-3, 3),
            colorscale = [BLUE, GREEN, YELLOW, ORANGE, RED],
        )

        self.add(axes, trig_plane)

Just change the list of colors to match the colorscale you want.
This can also be done using the OpenGL renderer, but there is a bug.  In fact, I found this issue by searching to see if someone else logged the OpenGL bug yet.  The short explanation is that doing this in OpenGL works as long as you don't rotate or move the surface.

Opened issue #3115 regarding the issues with surface colorscale in OpenGL.
Rereading your question, you just want the bar, not the surface.  In that case you could just create a rectangular surface using colorscale and not show the axes.  Does that work?

There is no issue here.


feat(ack): bump aws sdk v1 to 1.44

Description of your changes

Bump AWS SDK to the latest version 1.44. After this PR we can add new resources like FunctionURLConfig and others.
Added all new resources created with this bump to the generator-config.yaml ignore.resource_names
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
make run against an existing cluster and deployed a few resources

@chlunde possible that we can brng in first https://github.com/crossplane-contrib/provider-aws/pull/1472 ?
Then we can go here with the nice work from @pintonunes

@haarchri good idea and thanks for the reminder, done!

@pintonunes can you rebase and Check makefile for go-sdk Version ? Thanks

Guys, any news on this PR review?

i will check this week - need to check for breaking changes

looks like no breaking changes on the CRD level - @pintonunes did you drive any kind of test with resources ?

I tested a couple of basic resources and everything look ok. Impossible to test everything.

@haarchri, any news? Sorry for keep pushing but I have another PR waiting to add some missing resources using the code gen and this new SDK version.


Implement support for BAZELISK_FORMAT_URL

This new configuration setting provides a format-like string to compute the URL from which to fetch Bazel.  Takes precedence over BAZELISK_BASE_URL as this is a more general concept.
Fixes #423.

Alright! @fweikert This should now be ready for review again after a rebase + merge conflict resolution. Tests pass. Thanks!


Support building swift-format as part of Swift

There are 3 changes to support building swift-format as part of the Swift project:

Migrate other Swift project dependencies (swift-syntax and swift-argument-parser) to depend upon the master branches of those projects, so that they can be built as part of a single checkout.
Create a build script that can be invoked by the Swift project's build system to build and test swift-format.
Conditionally support building with local checkouts of Swift project dependencies (swift-syntax and swift-argument-parser).

When developing just for swift-format, it's still possible to use a recent DEV snapshot of the Swift toolchain to build and test without using local checkouts of the dependencies. That is the default behavior used by the Swift PM package (see the dependencies added with and without the SWIFTCI_USE_LOCAL_DEPS env var.
I ran into some trouble when using multiroot-data-file for Swift PM when combining swift-format with the other swift-syntax dependent projects, because the other projects rely on test discovery. Test discovery seems to work fine for swift-format, so I've enabled it when using the build script. The LinuxMain testing support file is preserved because other existing workflows rely on that file to test on Linux when test discovery isn't supported.
This follows the instructions for incorporating swift-format into the Swift project's CI system:
https://forums.swift.org/t/testing-swift-format-as-part-of-swift-s-ci-infrastructure/30619
Open Question
I'm not sure what is the best way to document the fact that master branch now depends on the latest build of Swift as opposed to a specific snapshot. I updated the README to note that the latest snapshot is necessary, but let me know if you think of a better way to document that.

I wonder if that table cell should just say "Swift at master".

That sounds like a good idea to me. I updated it.

@benlangmuir could you take a look at the build-script changes?
Also /cc @ahoppen for fyi