Re-evaluate Route53 loadbalancing

DNS based failover takes 45-120 seconds + corner case DNS caching making it unpredictable
Talk to Red Hat internal people to get input on Cloudflare or Akamai usage.
Other reasons to use a CDN/proxy instead of DNS: Deflect denial of service, WAF/security, performance, load shedding, ...
We might then use AWS Global Accelerator in our setup.
We also might need a way of the active site preventing the stale passive site to become active accidentially, and implement something like https://en.wikipedia.org/wiki/STONITH - see #534
More reading: https://cloud.redhat.com/blog/global-load-balancer-approaches
Internal issue which might contain information on how to set it up: CIAM-2516

For a Multi-AZ szenario (not multi-region), a ELB might be more cost effective and simpler to set up: https://aws.amazon.com/elasticloadbalancing/

For a Multi-AZ szenario (not multi-region), a ELB might be more cost effective and simpler to set up: https://aws.amazon.com/elasticloadbalancing/

I don't think using an ELB is an option as it does not support exclusive failover on health check failures and seemingly it will continue to forward requests to unhealthy endpoints if no healthy ones exist. See below from the AWS knowledge centre.

Note: The Application Load Balancer distributes traffic to the target groups based on weights. If all targets in a target group fail health checks, then the Application Load Balancer doesn't route or fail over the requests to another target group. If a target group has only unhealthy registered targets, then the load balancer nodes route requests across its unhealthy targets. When all the targets in a target group are unhealthy, don't use a weighted target group as a failover mechanism.

It's possible to use the AWS Global Accelerator to workaround the limitations of a DNS based approach.
Architecture
An accelerator requires a "Listener" to be defined that dictates which ports traffic can be received on. The Listener then routes traffic to an "Endpoint Group" defined per region, which specifies the Endpoints that traffic should be routed to. Each Endpoint definition has a weight associated with it, with 100 determining that all traffic should be routed to the endpoint and 0 meaning no traffic should be routed to the endpoint.
Endpoint failover works as follows:

If there are no healthy endpoints in an endpoint group that have a weight greater than zero, Global Accelerator tries to failover to a healthy endpoint with a weight greater than zero in another endpoint group. For this failover, Global Accelerator ignores the traffic dial setting. So if, for example, an endpoint group has a traffic dial set to zero, Global Accelerator still includes that endpoint group in the failover attempt.

Therefore, we define our primary cluster endpoint to have a weight of 100 and the backup cluster to have a weight of 0. This means that in the event of the primary AZ failing, all traffic will be handled by the backup cluster hosted on a different AZ.
Further reading:

Deploying multi-region applications in AWS using AWS Global Accelerator

Traffic management with AWS Global Accelerator

Implementation
https://github.com/keycloak/keycloak-benchmark/pull/586
Summary:

A Network Load Balancer is exposed by each of the ROSA clusters via a Kubernetes Service of type LoadBalancer with the annotation service.beta.kubernetes.io/aws-load-balancer-type: "nlb".

We can't use an Application Load  Balancer as this requires a VPC with at least two availability zones.
We cannot use the Load Balancer of the ROSA cluster itself as the health checks will only fail if the cluster goes down, not the Keycloak deployment.

After further experimentation, it seems the Global Accelerator is not suitable for an Active/Passive configuration without additional enhancements to the architecture described above. This is because the accelerator continues to route some traffic to the Primary ROSA cluster with a weight of 100 even when all nodes are unhealthy. From the AWS docs:

If there are no healthy endpoints in an endpoint group that have a weight greater than zero, Global Accelerator tries to failover to a healthy endpoint with a weight greater than zero in another endpoint group. For this failover, Global Accelerator ignores the traffic dial setting. So if, for example, an endpoint group has a traffic dial set to zero, Global Accelerator still includes that endpoint group in the failover attempt.

If Global Accelerator doesn't find a healthy endpoint with a weight greater than zero after trying the three closest endpoint groups (that is, AWS Regions), it routes traffic to a random endpoint in the endpoint group that is closest to the client. That is, it fails open.

To workaround ^ limitation, it is possible to create an AWS Lambda that flips the weight of the Primary and Backup endpoints on failover, or removes the failed Primary endpoint entirely. This requires a CloudWatch alarm to be created when unhealthy nodes are detected by the NLB, which in turn is used to trigger a Lambda that checks that all nodes within the NLB are down and then updates the Accelerator configuration accordingly.
For the initial Active/Passive implementation, we will proceed with Route53 based failover/loadbalancing.

With #594 it should be good enough for the initial A/P release.


Close  #266 move developer tools menu item to less used dropdown

Summary
Best I could do to update menu items, only managed to move developer tools menu item to less used dropdown
Closes #266
Description for the changelog
move developer tools menu item to less used dropdown
Other info

Very minor pull request, so going ahead with the merge


request - open card webpage on mkm when double clicking card in Mkm Oversight

One click, cards détail.
2 click browse to mkm


It doesn't pass robot protection on some websites

Describe the bug
It doesn't pass robot protection on some websites. Here is a good example https://www.bloomberg.com/news/articles/2022-05-17/elon-musk-says-twitter-must-prove-bot-claims-for-deal-to-proceed
Here is what I am getting in response, see "Bloomberg - Are you a robot?"
{     "data": {         "url": "https://www.bloomberg.com/tosv2.html?vid=&uuid=a0651c3d-d82c-11ec-bb03-4a7a46654c6c&url=L25ld3MvYXJ0aWNsZXMvMjAyMi0wNS0xNy9lbG9uLW11c2stc2F5cy10d2l0dGVyLW11c3QtcHJvdmUtYm90LWNsYWltcy1mb3ItZGVhbC10by1wcm9jZWVk",         "title": "Bloomberg - Are you a robot?",         "mediaType": "website",         "contentType": "text/html",         "images": [],         "videos": [],         "favicons": [             "https://www.bloomberg.com/favicon.ico"         ]     } }
To Reproduce
Steps to reproduce the behavior:
Just pass this url https://www.bloomberg.com/news/articles/2022-05-17/elon-musk-says-twitter-must-prove-bot-claims-for-deal-to-proceed to getLinkPreview function
Expected behavior
Expecting to get same results as Twitter, Facebook or Google news gets

Facebook, Google, and Twitter are probably trusted domains by Bloomberg. Nothing this library can do about it.


Incorrect transform of ]

Consider the following AsciiMath formula
⟨text(-)2 , 4 ]

Now if I transform it as follows:
AMTparseAMtoTeX('⟨text(-)2 , 4 ]')
--> ⟨\text{-}{2},{4}{\]}

Now, the issue here is the \], which should be (I think) just ]. The problem is that MathJax renders the slash. Is this a transform issue ?

Just so I can replicate it properly, what is the symbol you're putting before the text(-)?  It's not showing properly.
That said, the issue here is that the AMTgetTeXsymbol function assumes that every symbol should get backslashed unless it has the val property set.  It looks like some of the brackets need that property set.  I've never run into this because I usually have matched brackets, which get transformed into \left[ \right].  Whatever symbol you're using on the left must not be something the parser recognizes as a left bracket.

Here is more info on that first character: latex demo more info or if the last link doesn't work here is the info on that site about that character:
Character	⟨
Character name	MATHEMATICAL LEFT ANGLE BRACKET
Hex code point	27E8
Decimal code point	10216
Hex UTF-8 bytes	E2 9F A8
Octal UTF-8 bytes	342 237 250
UTF-8 bytes as Latin-1 characters bytes	â <9F> ¨
According to the name it seems like some kind of bracket

Ahh, yeah, AsciiMath doesn't understand Unicode characters for the most part.
AMTparseAMtoTeX("(:3,5]") would return "{\left\langle{3},{5}\right]}", which is probably the output you were wanting.
Even so, unmatched brackets should still be handled better.  I'll try to get that fixed.

Yep, that is the correct output. Thanks a lot!! Hope you have the time to work on this +1

I also found this one
AMTparseAMtoTeX('[2,8rangle')
--> "{\left[{2,8}\rightrangle}"

Which is incorrect, and should be
"{\left[{2,8}\right\rangle}"

Yup, somewhat related issue.  In that case, since the tex wasn't the symbol.input, then when the symbols get initialized the info needed for the AMTgetTeXbracket function gets lost.
It looks like I need to revamp that function to use the symbol.val attribute instead, make sure it gets copied over on the symbol initialization, and add the symbol.val attribute to the plain brackets as noted earlier.  I'll see if I can get that to work.
 On Thursday, July 9, 2015 1:28 AM, Lucas Calje<EMAIL_ADDRESS>wrote:

I also found this oneAMTparseAMtoTeX('[2,8rangle')
--> "{\left[{2,8}\rightrangle}"
Which is incorrect, and should be"{\left[{2,8}\right\rangle}"
—
Reply to this email directly or view it on GitHub.

Also related
'langletext(-)2 , 4 ]' --> {\leftlangle\text{-}{2},{4}\right]}

Any plans yet to fix this ? If not, and it is not too much work / complicated you can give me some hints were to like so I can fix this!

Sorry it took me so long to get this fixed; I had it basically done several months ago but forgot to get it finalized and pushed out.


"Version control with Git and GitHub" section

Add a "version control with Git and GitHub" section to the Welcome panes to aid discoverability of the GitHub package functionality without eating a bunch of screen real estate on that crucial first launch. See atom/github#872.

/cc @simurai

Sweet! Thanks, @simurai! 🙇


Implement installation report

We need to track installations of CSUI somehow. To discuss.

Removed. Implemented managed repo link.


Formal equiv diff Function2Returns_top.sv

Test UHDM-integration-tests/tests/Function2Returns/top.sv
The plugin sends an incorrect definition of the function to the Yosys AST based on the UHDM non-elaborated tree. It sends both return statements.
Surelog UHDM elaborated model contains the correct value.

Fixed


Create Desmos query client

https://github.com/desmos-labs/desmjs

@ivanng-oursky what's the two conflicting packages

@hochiw
@desmoslabs/desmjs has @cosmjs/* v0.27.1 but we are currently using v0.28.4. Is there anyway to resolve this other than downgrading our @cosmjs/*?


requirements/dependencies

would be nice to have a more complete description of requirements for using all the aspects of androguard. I have a dockerfile that I maintain for most of the features that I use https://github.com/dweinstein/dockerfile-androguard/blob/master/Dockerfile if it's helpful at all. probably it needs to be updated a bit as well.
for the normal androguard install yara, openssl, requests, ipython, ptrace shouldn't be needed (I use them for some of my own stuff) but I do think there's pygments, pyfuzzy, chilkat, pydot, magic, numpy, sklearn that could be made a little easier in the requirements.txt
OS X:

sparsehash (for elsim) - brew install google-sparsehash
muParser (for elsim) - brew install muparser
snappy (for esim/libsimilarity) - brew install snappy
lzma bz, ... (for elsim/libsimilarity -- but actually included in the repo) - brew install xz

FWIW I try to maintain the official mitmproxy Dockerfile https://github.com/mitmproxy/docker-base/blob/master/Dockerfile if someone wants me to help with the official androguard dockerfile as well...

@dweinstein I am willing to help you, what do you need to maintain the androguard docker? The proper build instructions ?

I have build instructions in my personal dockerfile that I shared above, but could use help reviewing for accuracy and coverage of all the different use cases to make a proper official one. ISTM that there's a dev build and a normal build (i.e., maybe everyone doesn't need the libsimilarity functions for example).
I'll open up a PR with a starting place to discuss more with you @subho007

Agreed. Willing to help :+1:

I documented the dependencies in #208
@dweinstein If you could document how to install androguard on OS X, I would add that to the documentation too. Or would you just suggest to use a docker/vagrant/other VM solution as described in  #156?

We should give an overview about the (optional) dependencies for androguard and seperately for elsim. Maybe it is also a good idea to specify minimum versions as seen in #177 and also dependencies for different OS types, like in #156 .
A good starting point is the debian package: https://packages.debian.org/androguard
as well as #208 which states also some dependencies.
The dependencies should be in the setup.py file as well, for users who just want to install it using pip.
Should the requirements file lists all dependencies too?

I think the requirements are now good.
If you like to write setup instructions for other OS, feel free and create a PR!


Make a list of better prompts

based on the methodology , and the baseline prompts , we should produce :

a list of prompts for gemini for each default prompt

as our project has expanded, so too has our list of prompts, so we should identify them and catalogue them @Zochory @JohnnyPere @MN-Noor

i am making "new prompts" listed in these branches, especially for the planners

https://github.com/microsoft/TaskWeaver/blob/main/taskweaver/code_interpreter/code_generator/code_generator_prompt.yaml
add to default prompts in taskweaver

Open tasks :

add prompts from taskweaver planner
add prompts from semantic-kernel planner
add prompts from autogen


[FEATURE] Show post likers list

Description
Show post liker list on clicking likes quantity.
Screenshots
No response
Additional information
It could be a modal with list of usernames who liked the post and clicking those username should open their profile(this is an already existing feature, just implement it here)

I would like to work on this issue if it involves only frontend as GSSOC contributor. Let me know please

okay it shall be on react,but you'll be calling a function to the database.You won't need to go out of react which means it is technically frontend.
Let me give you a snapshot of the database

as you can see going from left to right in database snapshot, in an individual post, there's a field likecount, in which user id of users who liked the post is stored.
So one way to display them would be to display a modal which fetches the user details of the users whose userIds are present in the likecount array. and those list items can be clicked as a button to navigate to their profile.
I hope this helps in making a decision. :)

I would like to work on this issue under GSSOC'23. I am comfortable with both frontend and backend.

I would like to work on this issue if it involves only frontend as GSSOC contributor. Let me know please

okay it shall be on react,but you'll be calling a function to the database.You won't need to go out of react which means it is technically frontend. Let me give you a snapshot of the database  as you can see going from left to right in database snapshot, in an individual post, there's a field likecount, in which user id of users who liked the post is stored. So one way to display them would be to display a modal which fetches the user details of the users whose userIds are present in the likecount array(you may take inspiration from profile component). and those list items can be clicked as a button to navigate to their profile.
I hope this helps in making a decision.Feel free to make any decision :)

I will take it up !

I would like to work on this issue under GSSOC'23. I am comfortable with both frontend and backend.

Prakriti it's claimed, sorry, You can work on the other issue assigned to you

I would like to work on this issue if it involves only frontend as GSSOC contributor. Let me know please

okay it shall be on react,but you'll be calling a function to the database.You won't need to go out of react which means it is technically frontend. Let me give you a snapshot of the database  as you can see going from left to right in database snapshot, in an individual post, there's a field likecount, in which user id of users who liked the post is stored. So one way to display them would be to display a modal which fetches the user details of the users whose userIds are present in the likecount array(you may take inspiration from profile component). and those list items can be clicked as a button to navigate to their profile.
I hope this helps in making a decision.Feel free to make any decision :)

I will take it up ! Kindly assign it to me

Yes, sure go ahead!

@Prakriti2003 are you working on this issue or can I take this up if you are not?

@Prakriti2003 are you working on this issue or can I take this up if you are not?

we're trying to resolve this issue using Firebase admin SDK but it's having conflicts with normal SDK, so searching for the workaround.

Ohkk. Got it

Hey @narayan954  I think I can solve this issue. Can you please assign it to me.

Hey @narayan954 I think I can solve this issue. Can you please assign it to me.

Hey,  I have already completed half of the work (UI part). However, I'm stuck with the firebase admin setup part. Perhaps we can collaborate together to close this issue. You can handle the setup part, and I can focus on the displaying in UI. Let's work together to resolve the issue effectively @Palakkgoyal  .
@narayan954

Yes, sure I would love to collab but, the problem is with the distribution of score. I think you should change this issue to display of post likes and I will create a new issue for admin setup. Then, we will connect both.
What do you think?

Hey @narayan954 I think I can solve this issue. Can you please assign it to me.

Hey, I have already completed half of the work (UI part). However, I'm stuck with the firebase admin setup part. Perhaps we can collaborate together to close this issue. You can handle the setup part, and I can focus on the displaying in UI. Let's work together to resolve the issue effectively @Palakkgoyal .
@narayan954

that works!

Yes, sure I would love to collab but, the problem is with the distribution of score. I think you should change this issue to display of post likes and I will create a new issue for admin setup. Then, we will connect both. What do you think?

I agree on this as well. Also, it'd be level 2 prs each, is that okay?

Ok for me, What about you @VijayalakshmiGanesh?

Ok for me, What about you @VijayalakshmiGanesh?

Works for me as well.

Can I work on this now?

Yes, sure. I think level2 is enough for it.


After deleting all nodes from custom cluster , not able to add new nodes to the cluster.

**Rancher versions: Build from master
Steps to Reproduce:
Create a custom cluster with 2 nodes:
node1 - > control and etcd
node2 - > worker
Delete node1.
Node gets deleted successfully.
Delete node2.
Node gets deleted successfully.
Add a new node with all roles to this cluster.
Cluster gets stuck in "Updating" state forever.

Cluster provisioning is updated multiple times with same errors:
2018/09/07 22:50:20 [INFO] Provisioning cluster [c-hqmlb]
2018/09/07 22:50:20 [INFO] Updating cluster [c-hqmlb]
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: Building Kubernetes cluster
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [state] Found local kube config file, trying to get state from cluster
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [state] Fetching cluster state from Kubernetes
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [state] Successfully Fetched cluster state to Kubernetes ConfigMap: cluster-state
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [certificates] Getting Cluster certificates from Kubernetes
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [certificates] Successfully fetched Cluster certificates from Kubernetes
2018/09/07 22:50:20 [INFO] cluster [c-hqmlb] provisioning: [network] Deploying port listener containers
2018/09/07 22:50:21 [INFO] cluster [c-hqmlb] provisioning: [network] Successfully started [rke-etcd-port-listener] container on host [<IP_ADDRESS>]
2018/09/07 22:50:21 [INFO] cluster [c-hqmlb] provisioning: [network] Successfully started [rke-cp-port-listener] container on host [<IP_ADDRESS>]
2018/09/07 22:50:21 [INFO] cluster [c-hqmlb] provisioning: [network] Successfully started [rke-worker-port-listener] container on host [<IP_ADDRESS>]
2018/09/07 22:50:21 [INFO] cluster [c-hqmlb] provisioning: [network] Port listener containers deployed successfully
2018/09/07 22:50:21 [INFO] cluster [c-hqmlb] provisioning: [network] Running control plane -> etcd port checks
2018/09/07 22:50:22 [INFO] cluster [c-hqmlb] provisioning: [network] Successfully started [rke-port-checker] container on host [<IP_ADDRESS>]
2018/09/07 22:50:22 [INFO] cluster [c-hqmlb] provisioning: [network] Running control plane -> worker port checks
2018/09/07 22:50:22 [INFO] cluster [c-hqmlb] provisioning: [network] Successfully started [rke-port-checker] container on host [<IP_ADDRESS>]
2018/09/07 22:50:22 [INFO] cluster [c-hqmlb] provisioning: [network] Running workers -> control plane port checks
2018/09/07 22:50:22 [INFO] cluster [c-hqmlb] provisioning: [network] Successfully started [rke-port-checker] container on host [<IP_ADDRESS>]
2018/09/07 22:50:23 [INFO] cluster [c-hqmlb] provisioning: [network] Skipping kubeapi port check
2018/09/07 22:50:23 [INFO] cluster [c-hqmlb] provisioning: [network] Removing port listener containers
2018/09/07 22:50:23 [INFO] cluster [c-hqmlb] provisioning: [remove/rke-etcd-port-listener] Successfully removed container on host [<IP_ADDRESS>]
2018/09/07 22:50:23 [INFO] cluster [c-hqmlb] provisioning: [remove/rke-cp-port-listener] Successfully removed container on host [<IP_ADDRESS>]
2018/09/07 22:50:23 [INFO] cluster [c-hqmlb] provisioning: [remove/rke-worker-port-listener] Successfully removed container on host [<IP_ADDRESS>]
2018/09/07 22:50:23 [INFO] cluster [c-hqmlb] provisioning: [network] Port listener containers removed successfully
2018/09/07 22:50:24 [INFO] cluster [c-hqmlb] provisioning: [reconcile] Reconciling cluster state
2018/09/07 22:50:24 [INFO] cluster [c-hqmlb] provisioning: [reconcile] Check etcd hosts to be deleted
2018/09/07 22:50:24 [INFO] cluster [c-hqmlb] provisioning: [remove/etcd] Removing member [etcd-ip-172-31-0-109] from etcd cluster
2018/09/07 22:50:24 [ERROR] cluster [c-hqmlb] provisioning: [reconcile] Failed to delete etcd member [etcd-ip-172-31-0-109] from etcd cluster
2018/09/07 22:50:24 [INFO] cluster [c-hqmlb] provisioning: [reconcile] Check etcd hosts to be added
2018/09/07 22:50:24 [INFO] cluster [c-hqmlb] provisioning: [certificates] Regenerating new etcd-<IP_ADDRESS> certificate and key
2018/09/07 22:50:25 [INFO] cluster [c-hqmlb] provisioning: [certificates] Successfully generated new etcd-<IP_ADDRESS> certificate and key
2018/09/07 22:50:29 [ERROR] NodeController c-bbv8m/m-sq668 [node-controller] failed with : waiting for node to be removed from cluster
2018/09/07 22:50:30 [INFO] cluster [c-hqmlb] provisioning: [add/etcd] Adding member [etcd-ip-172-31-9-30] to etcd cluster

We should look into better API validation to mitigate deleting the final etcd node. Workaround will be to delete the cluster and create a new one.


Added suggested_quantity keyword argument to SignalEvent in order to …

…transmit quantity information to PositionSizer. Added NaivePositionSizer to 'blindly' accept suggested quantities from SignalEvents.

Coverage decreased (-0.3%) to 72.594% when pulling 487eef6aedd7b414b87a20543a6851823efd4b8b on mean_rev_pos_sizer into eba678980e8485ec25924bf46d6f00404f66769c on master.


TC: Add nightly documentation promotion for release

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.

The merge queue build has failed. Click here to see all failures.

The merge queue build has started. Click here to see all failures if any.

The relevant job: https://builds.gradle.org/buildConfiguration/Gradle_Release_Promotion_NightlyDocumentation?branch=&mode=builds


Support PCKh and compare to each model(PoseEstimationForMobile, PoseNet, Fritz's pose estimation, ARKit3's pose estimation etc.)

plz give me any good idea 😎
Dataset

COCO 2017 dataset? (19GB.. OMG)

Metric

<EMAIL_ADDRESS>Inference time for each device

Devices

iPhone XS, iPhone XS Max
iPhone X, iPhone 8, iPhone 8+
iPad...

Models

PoseEstimationForMobile(cpm, hourglass) by (edvardHua)[https://github.com/edvardHua]
PoseNet by Google
Pose Estimation by (Fritz)[https://www.fritz.ai/features/pose-estimation.html]
Body Tracking by ARKit3


[Net] Move RPC, Node cache out of MultiplayerAPI.

Now uses two interfaces so it can be overridden in the future, and core no longer depends on Node.
The interfaces are implements in scene/multiplayer.
Replaces root_node with root_path.
Remove all Node references from MultiplayerAPI.
EDIT: Partially address #53295 (core/multiplayer)

Thanks!


Fix use-after-free in DestroyHoisting

Due to mismatch in the instructions handled in DestroyHoisting::getUsedLocationsOfInst
and MemoryLocations::analyzeLocationUsesRecursively, certain users of addresses
were not considered and the destroys were hoisted before valid uses causing use-after-frees.

@swift-ci test

@swift-ci benchmark

@swift-ci test

@swift-ci benchmark

I found a real bug due to unhandled cases with switch_enum_addr. Other instructions I handle in this PR like witness_method etc are dead and will be cleaned up by DCE later on. But the fix is needed to have a valid SIL after this pass, unless we decide to clean up such instructions in this pass.

Performance (x86_64): -O

Regression
OLD
NEW
DELTA
RATIO

DictionaryOfAnyHashableStrings_insert
2254
3864
+71.4%
0.58x (?)

Set.isDisjoint.Box25
285
401
+40.7%
0.71x (?)

Set.isDisjoint.Int50
201
241
+19.9%
0.83x (?)

Improvement
OLD
NEW
DELTA
RATIO

FlattenListLoop
3025
2748
-9.2%
1.10x (?)

Calculator
156
143
-8.3%
1.09x (?)

Data.hash.Medium
29
27
-6.9%
1.07x (?)

Code size: -O

Regression
OLD
NEW
DELTA
RATIO

FlattenList.o
4058
4106
+1.2%
0.99x

Improvement
OLD
NEW
DELTA
RATIO

ArraySubscript.o
3140
3108
-1.0%
1.01x

Performance (x86_64): -Osize

Regression
OLD
NEW
DELTA
RATIO

Data.append.Sequence.64kB.Count.RE.I
20
29
+45.0%
0.69x

Data.append.Sequence.64kB.Count.RE
20
29
+45.0%
0.69x

DataAppendSequence
5400
6900
+27.8%
0.78x (?)

Data.append.Sequence.809B.Count.RE.I
54
67
+24.1%
0.81x (?)

Data.append.Sequence.809B.Count.RE
54
66
+22.2%
0.82x (?)

SequenceAlgosRange
1960
2390
+21.9%
0.82x

SequenceAlgosContiguousArray
1710
1930
+12.9%
0.89x (?)

CSVParsing.UTF16
34
37
+8.8%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

Data.init.Sequence.2047B.Count.I
98
52
-46.9%
1.88x

Data.init.Sequence.2049B.Count.I
98
52
-46.9%
1.88x

Data.init.Sequence.64kB.Count.I
58
31
-46.6%
1.87x

Data.init.Sequence.64kB.Count
58
31
-46.6%
1.87x

Data.init.Sequence.809B.Count
84
51
-39.3%
1.65x

Data.init.Sequence.809B.Count.I
84
52
-38.1%
1.62x

Data.init.Sequence.513B.Count.I
93
63
-32.3%
1.48x

Data.init.Sequence.511B.Count.I
93
63
-32.3%
1.48x

Code size: -Osize
Performance (x86_64): -Onone

Regression
OLD
NEW
DELTA
RATIO

ArrayValueProp
2546
2904
+14.1%
0.88x (?)

Ackermann
1049
1186
+13.1%
0.88x (?)

ArrayLiteral2
1501
1672
+11.4%
0.90x (?)

ArrayValueProp4
3342
3633
+8.7%
0.92x (?)

ArrayValueProp3
3382
3676
+8.7%
0.92x (?)

ArrayValueProp2
3715
4027
+8.4%
0.92x (?)

COWArrayGuaranteedParameterOverhead
5000
5400
+8.0%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

ArrayAppendLatin1Substring
33624
30744
-8.6%
1.09x (?)

Data.hash.Medium
39
36
-7.7%
1.08x (?)

Code size: -swiftlibs

Improvement
OLD
NEW
DELTA
RATIO

libswiftStdlibUnittest.dylib
344064
327680
-4.8%
1.05x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

Build failed
Swift Test Linux Platform
Git Sha - 131e4cd874ad5ca8bc19fa5d1164ad7516cc43b4

Build failed
Swift Test OS X Platform
Git Sha - 131e4cd874ad5ca8bc19fa5d1164ad7516cc43b4

@swift-ci test

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - 6534779dbd126422b38ba21cbe5030a0b1d381b6

Build failed
Swift Test OS X Platform
Git Sha - 6534779dbd126422b38ba21cbe5030a0b1d381b6


support count aggregation function

Hi, I want to try it.

Recently, I've been learning about Risinglight, and I have a certain understanding of SQL, and if I want to try it, it may take some time


feat: Faculty feedback

What
A hack-ish method to submit faculty feedback all at once, with a fixed rating.
Why
Filling faculty feedback twice every semester can be a painful experience for many,
especially considering that they can have about a dozen faculty and the form is long,
unfriendly and irrelevant to most people.

Not very well designed but I'd rather get it out now than later


Set up CI testing

There's a .travis.yml file in the travis-ci branch, but it doesn't work yet. The difficulty is that Travis-CI uses Ubuntu 12.04 LTS VMs, which don't have an easy way of installing WebKitGTK+ 2.
See also: https://github.com/sourcegraph/go-webkit2/issues/1

is this project still alive? most CI services are using docker now, it might be easier today than in 2014

Yep, this project is still alive. Indeed, it would be easier now.


U256 support

Resolves #62

can you run prettier please

Looks good - assuming nothing is broken in the example app?


[Bug]: The settings in the SQL window are inconsistent with the design draft

ODC version
odc431
OB version

What happened?

What did you expect to happen?

How can we reproduce it (as minimally and precisely as possible)?
Open SQL window to view settings
Anything else we need to know?
No response

Fixed In Commit b8310dbf525090e447de8ab108fba352e21af1e0
------
畅晚
Mon Jul 8 09:36:58 2024 +0800

pass


Rotate the covered area

I changed the covered area from a circle to half one. When rotating the robot, the covered(white) area's direction is always facing the same direction not rotating as the robot rotates.
Does anyone have an idea on how to do it?

您的邮件已经收到，我将尽快回复！
                                                      ——李应林


Accessibility for removable chips

Bug, feature request, or proposal:
feature
What is the expected behavior?
User should be able to use keyboard to remove a chip.
What is the current behavior?
User cannot user keyboard to remove a chip
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Delete key is used to remove a chip. Closing this issue


Add rules for DHCPv6 traffic (in/out)

Maybe it makes sense to provide as well nftables::dhcpv6 or similar to make it easier to activate the rules. It's something generic and wide-spread enough to justify it I'd say. Your call.

Maybe it makes sense to provide as well nftables::dhcpv6 or similar to make it easier to activate the rules. It's something generic and wide-spread enough to justify it I'd say. Your call.

So is this something that you want rather to use together? I mean if you want to request dhcpv6 the out are enough, not?

So is this something that you want rather to use together?

Not sure I understand your point but I think it's perhaps I didn't express correctly what I was proposing to do. I was asking if as part of this patch you'd like me to add a parameter to the class nftables called in_dhcpv6 (or maybe in_out_dhcpv6) to be consumed in inet_filter.pp to include nftables::rules::dhcpv6 and nftables::rules::out::dhcpv6 (similar to what you're doing for ssh, for example). In our particular case we're not going to use it because the caller of the nftables module configures an all out accept policy and then we're including nftables::rules::dhcpv6 directly to accept the traffic coming from the DHCP server. We're happy to get the patch accepted as it is now :)

I mean if you want to request dhcpv6 the out are enough, not?

Ah, got you now. Yes, it's the client initiating in all cases so the packets back from the server will be accepted as things stand now because they're part of an established "connection" (quoted because it's UDP). It's corrected, the patch only contains a rule for the output chain.
So yes, the only pending issue is to know if you'd like to have a parameter out_dhcpv6 in the nftables class.

Confused as to why only out is required. Given we already allow everything out why are we logging blocks now.

Uhm, not convinced. The initial packet from the client is sent to the multicast addr ff02::1:2 but the response has the link scope addr of the server as source so connection tracking might not apply and a explicit INPUT rule for NEW traffic like the one initially proposed might be in order.

I've reintroduced the input rule class and a parameter dhcpv6 in nftables (to be discussed)

Our idea with the parameters for the nftables class is, that you should be able to get a as locked down as possible host by including the nftables class. Now, what you need always from our view, is putgoing dns resolution, yum repos (thus https) and ntp, as well as incoming ssh. This is what we defined as our standard baseline.
We understand that there are situations, where you want to have any outgoing connection allowed, which is why there is a global option.
Now with regard to the dhcpv6 option, one could argue that in certain environments it is necessary, on the other hand in most server environments, you likely have some kind of static assignment. Thus the dhcpv6 rule would definitely be too much to enable (I assume) by default. And also we would not want to have for every rule a parameter in the main class. So if you do not have strong arguments to have dhcpv6 somehow enabled when just including the nftables class (and setting a hiera value), I don't think it is really necessary to do so.

Makes total sense. I've removed the commit adding the parameter. Next time you're in Genf beers are on me :)

Happy to do s/dhcpv6/dhcpv6c to make clear that the rules are for the DHCPv6 client.

Happy to do s/dhcpv6/dhcpv6c to make clear that the rules are for the DHCPv6 client.

Question: I understand you (and dhcpv6) correctly, that you will always need both (in&out) so that a host is able to do dhcpv6, right? So I would propose to merge them together to one class (e.g. nftables::rules::dhcvp6_client) so one need only to include one class to enable dhcpv6 client. Or what do you think?
Sorry for the back and forth and thank you a lot for the contribution! The module is quite fresh and thus not everything is yet settled how it should be.

So I would propose to merge them together to one class (e.g. nftables::rules::dhcvp6_client) so one need only to include one class to enable dhcpv6 client. Or what do you think?

Yes, however one might be setting nftables::out_all and therefore only needing the input rule so perhaps having them separate is a good idea.

Sorry for the back and forth and thank you a lot for the contribution! The module is quite fresh and thus not everything is yet settled how it should be.

No worries at all, patches should be discussed and agreed 👍

So I would propose to merge them together to one class (e.g. nftables::rules::dhcvp6_client) so one need only to include one class to enable dhcpv6 client. Or what do you think?

Yes, however one might be setting nftables::out_all and therefore only needing the input rule so perhaps having them separate is a good idea.

Good point, let's keep the classes separate, but then let's add one that combines the two, then we have all use-cases simplified.

let's add one that combines the two, then we have all use-cases simplified.

I've renamed nftables::rules::dhcvp6 to nftables::rules::dhcvp6_client and nftables::rules::out::dhcvp6 to nftables::rules::out::dhcvp6_client.
Since rules in  manifests/rules seem to be all input rules whereas those in manifests/rules/out are output ones, where do you suggest to put the class combining both and how to name it?

Since rules in manifests/rules seem to be all input rules whereas those in manifests/rules/out are output ones, where do you suggest to put the class combining both and how to name it?

Yeah, that was also not clear to me. But maybe it would also be ok, to have a class param for that low-level option? I mean Boolean $nftables::dhcpv6_client = false (which is what you proposed earlier, but as I said, let's figure out how to best structure the module :-/ ) and then we just include both and don't have to think about the class name. But maybe there will be classes like that? E.g. for services. So maybe it could also go into a class: nftables::services::dhcpv6_client and this would be the place where we put such classes that combine in & out rules?

So maybe it could also go into a class: nftables::services::dhcpv6_client and this would be the place where we put such classes that combine in & out rules?

Makes sense. It's implemented.

Thank you!


Avoid cgo dependencies

following https://ops.tips/notes/glibc-golang-learnings/#how-can-i-see-what-requires-cgo
I see these cgo dependencies for ocis:
crypto/x509
github.com/mattn/go-sqlite3
os/user
plugin
runtime/cgo

Ideas howto remove those?

os/user dependency could be potentially removed by https://github.com/cs3org/reva/issues/964

From https://golang.org/doc/go1.11

The os/user package can now be built in pure Go mode using the build tag "osusergo", independent of the use of the environment variable CGO_ENABLED=0.

After further research it seems that we can't get rid of cgo fully as the glibc is requried for LDAP-DNS queries and mDNS lookups via golang stdlib.
https://golang.org/pkg/net/#hdr-Name_Resolution
Generally all of cgo can be disabled by CGO_ENABLED=0 but any problems with linking will surface during runtime.
There are some very hacky workarounds which embed the dynamic lib in to the binary:
https://www.arp242.net/static-go.html
https://www.osso.nl/blog/golang-statically-linked/

todo: add tradeoffs from not using cgo

todo: add tradeoffs from not using cgo

bump

update: these are the current packages using CGo:
~/code/owncloud/ocis/ocis/cmd/ocis master
❯ go list -f "{{if .CgoFiles}}{{.ImportPath}}{{end}}" $(go list -f "{{.ImportPath}}{{range .Deps}} {{.}}{{end}}") ./...
github.com/mattn/go-sqlite3
net
os/user
plugin
runtime/cgo

@refs could you check again and close if applicable?


Add missing Arabic translations

Changes

Add missing Arabic translations.

I cannot speak Arabic, so I trust your skills, that the solution is correct, thanks for the PR.


Add simple demonstration setup to README?

Since many people (like me) are unfamiliar with RabbitMQ, would it make sense to either suggest a simple setup or link to one? The simple setup suggestion could be a gist, or perhaps a README in a subdirectory?
We'd probably all be interested to know how you as the maintainer use rabbitmq.

Yes, i want to use it in TYPO3 for testing purposes at the moment. We may use it in produciton at some point.


[.packit.yaml] remove no longer needed keys:values

Some keys in the Packit config file are no longer mandatory since the default values are just fine.
One can also use aliases for dist-git branches and/or copr build targets.

it seems that we may need to replace rhel8 beta with epel8

Thank you @jpopelka !


Notifications don't work

Wasn't sure until now, but notifications don't show on my mac (2014 rmbp 15", Sierra). The sound is made though and notifications from other apps come through.

On Macbook Pro 2010 on Sierra, this problem also occurs to me.

Same here on Macbook Pro 2012 (non-retina) on Sierra 10.12.4 Beta.
Sometimes closing app with command + Q and reopening solves problem for about 15 minutes

I heard that from several people, but can't reproduce. Seems like Facebook is A/B-testing something there. Would be great if someone having this issue can help debugging.

I observed now that this occurs after closing some fullscreen apps e.g. atom.
Also when I have notifications I can't click on them to open goofy

@danielbuechele tell me what you need! I'd like to help debugging

What I need, is a scenario to reliable reproduce this behavior and all steps that happen in this scenario.

Alright, I'll be one the lookout to see if I can get a scenario in which the notifications do work, so I can make one where they don't.

The notifications are working properly for me now all of a sudden.  Although the red circle does not go greater than 1, even when the same person sends multiple messages.

Version 3.1.0 implements notification a little different. Let me know if the problem still exists.

Notification doesn't work all the time for me. Seems like Facebook runs several versions of Messenger in other countries and the element classes are different in each version.
I am running 3.2.1 on my Sierra from Vietnam.

This problem has returned. Facebook changed their code. PRs welcome.

The reason for this was that previously, Notifications were created by Goofy when it detected that the DOM had changed a new message was created.  What it does now is hijack the Web Notification that Facebook sends, does some slight tweaks to make it native, and then present that Notification to the user - hopefully this will be more reliable than previously 🤞
Fixed in 3.3.4


Docs: “Mergo in the wild” inaccurate

“Mergo in the wild” lists cli/cli as its first item, but I believe that this has been false advertising since May this year, as GitHub CLI did not ever have mergo as a dependency. We received one PR from an external contributor that proposes making use of mergo in our codebase, but the PR hasn't been merged yet.
Ref.<PHONE_NUMBER>31c1a5c8ff8e059ae75fc2fc2a04f7

Oh, that's a shame. Maybe I got the wrong repository, but I was granted of the one-time sponsorships the past year from GitHub.

@mislav You were right. I checked the official repos and it only appears in two repositories:

I was sure it was also in cli/cli but I don't see it in the time I was sure it was. So, I'm removing it from the section.


Stream logs from the ScenarioSimulator WebJob

This works with the current code.

Although, waiting the 5 minutes between events is tedious. :-P


draggable markers?

any ideas on how a marker could be dragged and update its new position.

That is a good question @jnachman123. I think it is possible to achieve this using https://react-dnd.github.io/.
It would require a spike. I'd appreciate it if you want to contribute to the project and play with React DND and open a PR if there is anything we need to implement on our side to make it work.


Render raw string

Is there a way to render a raw string from the Model? Razor keeps html-encoding it. This is outside MVC and templates don't have access to HtmlHelper.

You can use @Raw(), see https://antaris.github.io/RazorEngine/Encoding.html.
Or you can directly return new RawString(rawString) which is what Raw does internally.


Drug feature implementation

Orange Book from the FDA

Proposed workflow:

Doctor enter in a field entitled drug name a drug name, which may be any trade name, and this will be auto completed and validated
The next field will be route of administration

json {   "ingredient": "string",   "tradeNames": "string[]",   "routesOfAdmin": "string[]" }

https://www.fda.gov/drugs/drug-approvals-and-databases/orange-book-data-files

Canadian drug data, https://www.canada.ca/en/health-canada/services/drugs-health-products/drug-products/drug-product-database/what-data-extract-drug-product-database.html


phone_id

Shouldn't the phone_id be tied to the Device ?
I see in some requests it's sent always using Helpers.generateUUID()
In the readme it's written that the Device class handles the phone_id.

@israellot actually it should, good point. Didnt realize that during development...


[Explore] Chart style options get their own tab

and then

This way we can keep style configurations out of the way of data configurations, while also making it easier to see all the style configurations in one place!
Open questions: what should the names of these tabs be?
test plan:

go to line chart, bar chart and pie cahrt
verify style and data configurations are in the correct spots
verify style configurations are all expanded by default now that they get their own tab

reviewers:
@michellethomas @mistercrunch @graceguo-supercat

Future work:
this will enable us to add a third tab, data preview!

Nice! I've been meaning to do something like this for way too long.

closes https://github.com/apache/incubator-superset/issues/4296

@GabeLoins the build is failing because of some js lint issues

@michellethomas PTAL when you have the chance, rearranged so we depend entirely on renderTrigger

this lgtm


Fix sample file name on developers documentation

Description
This PR fixes the file name of the sample configuration json provided from orchestrator.conf.json.sample to orchestrator-sample.conf.json in the developers documentation, assuming this is the correct file:
https://github.com/github/orchestrator/blob/master/conf/orchestrator-sample.conf.json
cc @shlomi-noach

Closing to create a fork instead.


Keyboard shortcuts in new embed UI

The new embed UI does not support keyboard shortcuts (Cmd-enter to run, for example) as well as the playground UI. It should be brought into alignment.

Via several PRs, the following keyboard shortcuts now work in the new embed UI:
Ctrl-enter, Cmd-enter: Run
Alt-enter: Show quick fixes
Ctrl-space, Cmd-space: Show completions
Ctrl-/, Cmd-/: Comment-out code
FWIW, the first three are done by explicit Dart keybindings, while the last one is done through CodeMirror itself.

Another note for refactoring shortcut to be included: alt+enter
Thanks @johnpryan for sharing this tip.

related to https://github.com/dart-lang/dart-pad/issues/1134


Examples should not be "published" by default

The code for loading examples, similar to the #391 issue, should ignore the published field and set it to false.

The problem here is that the examples are published. I'll just fix that.

Resolved in v1.6.12-alpha


Support SQL for alerting

 Issue by y3n11
Wednesday Jan 27, 2021 at 23:39 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/341

It will be preferable to create monitors using SQL queries

Closing this issue as it's a duplicate of https://github.com/opensearch-project/alerting/issues/27


Aww Shucks cf logs error

    Tell us that you ran this command:

            cf login -u<EMAIL_ADDRESS>-p xxxx -o FORD_DDS -s DEV

    using this version of the CLI:

            6.13.0-e68ce0f

    and that this error occurred:

            runtime error: invalid memory address or nil pointer dereference

    and this stack trace:

            goroutine 1 [running]:
    main.generateBacktrace(0x0, 0x0)
            C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:127 +0xbb
    main.handlePanics(0x1d0038, 0xc08255f0a0)
            C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/main/main.go:111 +0x183
    github.com/cloudfoundry/cli/cf/net.getBaseDomain(0xc0825542d0, 0x2a, 0x0, 0x0)
            C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/net/http_client.go:99 +0x141
    github.com/cloudfoundry/cli/cf/net.PrepareRedirect(0xc082286000, 0xc082296008, 0x1, 0x1, 0x0, 0x0)
            C:/GoAgent/pipelines/Win64-Unit-Tests/src/github.com/cloudfoundry/cli/cf/net/http_client.go:36 +0x227
    net/http.(*Client).doFollowingRedirects(0xc082567c50, 0xc082530540, 0xe4aee8, 0xc0822902d0, 0x0, 0x0)
            c:/go/src/net/http/client.go:368 +0xb0b
    net/http.(*Client).Do(0xc082567c50, 0xc082530540, 0xc082567c50, 0x0, 0x0)
            c:/go/src/net/http/client.go:175 +0xa3
    github.com/cloudfoundry/cli/cf/net.Gateway.doRequest(0x1d0470, 0xc082290bd0, 0xe4a498, 0x1, 0x12

I got this error when trying to monitor logs on my IBM Bluemix application running on Tomcat.  My co-worker does not get this error from this mac book.  I have my proxy settings correctly enabled.  Unsure why I am getting this error.

Hi,
Could you reproduce using CF_TRACE=true? It will help us debug the problem.
Cheers.

CLI Team

Closing this issue. Feel free to reopen when you have more details.

CLI team


[Version 1.857] - Drawer cannot be opened when the album list area is collapsed.

Expected Behaviour
The drawer should remain functional in all areas of the application to allow users to navigate the application using the drawer options.
Actual Behaviour
The drawer is not triggerable when the album list area is collapsed.
Steps to reproduce

From a fresh install (existing will work, but my steps are based on a fresh install).
Launch the application and indicate that you would like to enter the application without signing in. This can be achieved by clicking on the "Or continue to the library without an account" link.
When presented with the warning that some features will not be available, click "continue".
You will be presented with a list of popular artists and shown album artwork, swipe up on the albums until the album area has been fully collapsed (swipe from the bottom of the albums container).
Click on the drawer icon (hamburger) located at the top left of the page.
Note that the icon will not be clickable and the drawer will not function.

Environment
This bug has been tested and replicated on the following devices and Android versions:
Device 1

Device: Pixel 2
Android Version: 8.0
Device Type: Emulated
Application Version: 1.857

Device 2

Device: Motorola 3 (3rd Generation)
Android Version: 6.0.1
Device Type: Physical
Application Version: 1.857

Recording of the issue
The following video shows this issue in more detail:
https://www.youtube.com/embed/L1bHO7QzZ8U

Thanks for the report. It seems the text from the tab layout is overlapping the drawer button. I will look for a possible fix.

Fixed with new 1.860 release.


Add leads to component pages to present a summary of what each component does

To-dos

It looks like .lead is not overridden in our DS styles yet. @EilidhIsla @pmor80 Can either of you update this PR with the necessary CSS changes?

Lead styling looks quite out of place: https://design-system-git-leads-nihruk.vercel.app/component/alert. What do you think?

@pmor80 @EilidhIsla @VincentBreen  So the light font weight comes from Bootstrap, which does indeed make its leads look pretty skinny by default. Considering the style and font size we're going for, would it makes sense to ensure the font weight is at least the same as that of regular paragraph text? Take also NHS pages as an example: https://service-manual.nhs.uk/design-system/styles/typography#headings


fix: Split Bill - Group members disappeared in a split bill when make second split bill in a row

Details

Removing transaction draft merge to null on success and failure to prevent ui resetting while user is editing a new draft.
Fixed Issues

$ https://github.com/Expensify/App/issues/33518
PROPOSAL: https://github.com/Expensify/App/issues/33518#issuecomment-1867998289
Tests

Same as QA steps

[x] Verify that no errors appear in the JS console

Offline tests
Same as QA steps.

QA Steps

Create a group chat
Send a split bill
Immediately after try to send a new one, issue used to be that it would get reset but now instead it's showing a loading screen. (which should no longer be the case with this fix, instead the ui should not get reset/loading screen)
(Best way to reliably reproduce the issue is to throttle the network requests)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/12114889/5cb48e07-5c51-4d31-8f27-61003e8a089f

Android: mWeb Chrome
https://github.com/Expensify/App/assets/12114889/8eeb0211-a4d2-430e-a4a2-fc3276555605

iOS: Native
https://github.com/Expensify/App/assets/12114889/953fa1d6-690d-4918-8f03-1db45a4a5af3

iOS: mWeb Safari
https://github.com/Expensify/App/assets/12114889/1e6fa9bf-c281-4966-bb58-1c5740d8ba6d

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12114889/d8c8ce91-1f46-44b2-b8d8-85a8f746b90f

MacOS: Desktop
https://github.com/Expensify/App/assets/12114889/ee34ccef-a166-41ae-8503-5ac4faceca2e

I have read the CLA Document and I hereby sign the CLA

recheck

ready @abdulrahuman5196 , optimistic draft was removed from failure and success data, and added instead to optimistic data.

@adriancova
Kindly remove the draft from failureData as mentioned here as well. It should fix other issue as well
#35064 (comment)

@adriancova This comment isn't addressed yet. Could you kindly add this?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/58816620-eb4c-48d4-9bbd-b5f42b5de2db

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/ce3b239f-cb37-4219-b94f-aa958ceb216e

iOS: Native

https://github.com/Expensify/App/assets/46707890/9d83778c-318e-4672-8dc1-673598a28ff1

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/ba90e477-4934-4a83-b4f4-3b43360e743f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/91254ff0-c79f-43f5-87e9-d6672d0873f6

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/1ae425d4-aee2-428d-93ef-a0f19ccb63a4

Kindly run the workflows before approval since it needs a maintainer to run them.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/dangrous in version: 1.4.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Create Welcome “foo.stories”

Automatically generated by Netlify CMS

👷 Deploy Preview for eloquent-brahmagupta-73fcc0 processing.
🔨 Explore the source changes: 621b8a8e9710a096e59edefee3ae5617a228209b
🔍 Inspect the deploy log: https://app.netlify.com/sites/eloquent-brahmagupta-73fcc0/deploys/623a1cf995fcd60009125f2c


Change format of event group page token.

This change is

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt, line 168 at r1 (raw file):
Previously, wangyaopw (Yao Wang) wrote…

eventGroupPageToken.toByteArray().base64UrlEncode()

PageToken should only be set if there are remaining elements not returned yet.
One way of doing that is

try to get limit+1 items.
if the query returns limit+1 items, return the first limit items and set the nextPageToken
if the query returns less than limit+1 items, return all of them and don't set the nextPageToken.

Used the suggested method.

src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/queries/StreamEventGroups.kt, line 54 at r1 (raw file):
Previously, wangyaopw (Yao Wang) wrote…

          (ExternalDataProviderId >= @$EXTERNAL_DATA_PROVIDER_ID_AFTER
          AND ((ExternalDataProviderId > @$EXTERNAL_DATA_PROVIDER_ID_AFTER)
          OR (ExternalDataProviderId = @$EXTERNAL_DATA_PROVIDER_ID_AFTER
          AND ExternalEventGroupId > @$EXTERNAL_EVENT_GROUP_ID_AFTER)))

isn't this the same as
(
ExternalDataProviderId > @$EXTERNAL_DATA_PROVIDER_ID_AFTER)
OR (ExternalDataProviderId = @$EXTERNAL_DATA_PROVIDER_ID_AFTER AND
ExternalEventGroupId > @$EXTERNAL_EVENT_GROUP_ID_AFTER)
)

?

I suppose this is premature optimization. I switched to the simpler version.

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt, line 143 at r2 (raw file):
Previously, wangyaopw (Yao Wang) wrote…

          // get 1 more than the actual page size for deciding whether or not to set page token
<EMAIL_ADDRESS>+= 1

just do limit = pageSize + 1 above

I need more than just that above since I may use the page token's page size instead. Added some extra +1's when checking the page token.

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt, line 167 at r2 (raw file):
Previously, wangyaopw (Yao Wang) wrote…

sortedDescending(

why sorting here?

Think this is from some testing I was doing. Removed.

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt, line 156 at r2 (raw file):
Previously, wangyaopw (Yao Wang) wrote…

      // nothing for next page so page token isn't set
      if (results.size < streamRequest.limit) {
        eventGroups += results.map(InternalEventGroup::toEventGroup)
        // next page has at least 1 result so page token is set
      } else {
        eventGroups +=
          results.subList(0, streamRequest.limit - 1).map(InternalEventGroup::toEventGroup)
        val eventGroupPageToken = eventGroupPageToken {
          this.pageSize = streamRequest.limit - 1
          externalDataProviderId = streamRequest.filter.externalDataProviderId
          for (externalMeasurementConsumerId in
            streamRequest.filter.externalMeasurementConsumerIdsList.sortedDescending()) {
            externalMeasurementConsumerIds += externalMeasurementConsumerId
          }
          lastEventGroup =
            previousPageEnd {
              externalDataProviderId = results.last().externalDataProviderId
              externalEventGroupId = results.last().externalEventGroupId
            }
        }
        nextPageToken = eventGroupPageToken.toByteArray().base64UrlEncode()

How about
eventGroups += results.subList(0,  min(results.size, pageSize)).map(InternalEventGroup::toEventGroup)
if (results.size == pageSize+1) {
        val eventGroupPageToken = eventGroupPageToken {
          this.pageSize = pageSize
          externalDataProviderId = streamRequest.filter.externalDataProviderId
          externalMeasurementConsumerIds += streamRequest.filter.externalMeasurementConsumerIdsList
          lastEventGroup =
            previousPageEnd {
              externalDataProviderId = results[pageSize-1].externalDataProviderId
              externalEventGroupId = results[pageSize-1].externalEventGroupId
            }
        }
        nextPageToken = eventGroupPageToken.toByteArray().base64UrlEncode()
}

Used the limit of the stream request instead of pageSize because pageSize is not necessarily the final limit depending on the page token in the request.

src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/EventGroupsServiceTest.kt, line 323 at r2 (raw file):
Previously, wangyaopw (Yao Wang) wrote…

containsAnyOf(eventGroup1, eventGroup2)

If you use FixedIdGenerator, you can check against a specific eventGroup

I decided not to used a FixedIdGenerator, I would have to change a lot more than just this to get it to work since some tests create 3 certificates and each one would need a different id so I would be constantly changing the ids.


why pricing = df.loc[:, 'Open'].iloc[1:].unstack('asset')?

Hi, in this tutorial,it has:
pricing = df.loc[:, 'Open'].iloc[1:].unstack('asset')
I wonder why it exclude index 0. I think the following should be ok. anyone can correct me?
pricing = df.loc[:, 'Open'].unstack('asset')

The idea here is that only next day's open price would be available to trade on signals computed using today's close price.


Pre-populate and ship a Jitify cache?

Heard some people complaining about the one-time only cost
https://docs.cupy.dev/en/stable/upgrade.html#modernized-cccl-support-and-requirement
which appears as if it hangs.
As a stop-gap solution, we should print a warning "jitify cache building, it may take a while..."
Short-term, I am thinking to extend @kmaehashi's idea that we implemented

generate a hash string of all cupy/_core/include/** files at the build time and set it as a key

and build the json-based Jitify cache at build time, and ship it as part of the wheel and conda package.
Long term, I am afraid Jitify's default compile-fail-search loop is too expansive and we might have to either implement it ourselves or use the WIP (https://github.com/NVIDIA/jitify/pull/131).

IIRC the problem with pre-generated cache is that some headers depend on files under /usr/local/cuda/include which is user environment dependent. 😢

I am thinking about this too. I think the bigger problem is that the cache keys can contain includes with relative paths (or truncated paths in the bracket form <...> that requires the compiler to search, which makes it very hard to identify the source of the headers. If we normalize all keys to absolute path, maybe it'd make things easier/safer? However, we'll pay a price during cache lookup (de-normalizing an absolute path to relative/truncated path).

If we normalize all keys to absolute path, maybe it'd make things easier/safer?

I think there's no formal way to do that... If A/B/C.h has a #include <D.h> line, we only get D.h as a key, so we don't have knowledge of which file tried to include D.h nor which directory D.h is in.

Right, so when I noted

we might have to either implement it ourselves or use the WIP (NVIDIA/jitify#131).

I meant we'll no longer rely on NVRTC to find headers, but instead roll out a search logic that mimics the compiler behavior. This is the only way we can gain knowledge about header location. I think NVIDIA/jitify#131 did quite a bit of the work, I just don't know if in the long term we'd still want to use Jitify, or just vender that search loop implementation in CuPy and move on.

 How to fix this? @leofang
(rapids_new) (base) azureuser@ryanshrott1:~/cloudfiles/code/propertyca_space$ python
Python 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import dask_cudf
import cudf
import cupy as cp
s = cudf.Series([1, 2, 3, None, 4])
s = cudf.Series([1, 2, 3, None, 4])
ds = dask_cudf.from_cudf(s, npartitions=2)
/anaconda/envs/rapids_new/lib/python3.11/site-packages/cupy/cuda/compiler.py:233: PerformanceWarning: Jitify is performing a one-time only warm-up to populate the persistent cache, this may take a few seconds and will be improved in a future release...
jitify._init_module()

@ryanshrott could you file a new issue with requested information provided (see the issue template)? This warm-up should not exceed ~1 min.

New thought, recorded here in case I forget. I am getting more and more concerned with the performance of building a cache...
We needed Jitify back then because lots of Thrust/CUB headers could not be compiled using NVRTC (#3408, #4228). While today most of Thrust still cannot be compiled using NVRTC (not even with Jitify turned on): https://github.com/cupy/cupy/blob/c39c2d40ce7ca61040a8243f37b61af2966fd905/cupyx/jit/thrust.py#L14
CUB can be! Given that we figure out how to redirect std libraries to use libcudacxx, perhaps the way to go should be:

Unconditionally include cupy/cuda_workaround.h whenever CUB code is compiled
Avoid calling jitify._init_module() in CuPy routines
Only allow jitify=True in user code based on RawKernel/RawModule

This way we could perhaps sort of restore the pre-v13 performance without breaking changes in the user land that we can't test. _init_module() is deferred indefinitely (to the first invocation of RawKernel/RawModule).

There are a few places where the similar treatment can be done to avoid using Jitify

Done in https://github.com/cupy/cupy/pull/8467. I am thinking this issue can be closed, now that the chance of firing Jitify is significantly reduced. Thoughts, @kmaehashi?

Yeah, sounds good to close this one!

FYI, I was stuck at conda-forge's CuPy forever like @ryanshrott :
/root/micromamba/envs/py311/lib/python3.11/site-packages/cupy/cuda/compiler.py:233: PerformanceWarning: Jitify is performing a one-time only warm-up to populate the persistent cache, this may take a few seconds and will be improved in a future release...
  jitify._init_module()

Uninstall them with micromamba remove cupy:
  Prefix: /root/micromamba/envs/py311

  Removing specs:

   - cupy

  Package      Version  Build            Channel          Size
────────────────────────────────────────────────────────────────
  Remove:
────────────────────────────────────────────────────────────────

  - cupy        13.2.0  py311he5a987b_1  conda-forge     357kB
  - cupy-core   13.2.0  py311h3bdf873_1  conda-forge      42MB
  - fastrlock    0.8.2  py311hb755f60_2  conda-forge      38kB

  Summary:

  Remove: 3 packages

... and install the pip version instead with pip install cupy-cuda12x:
Successfully installed cupy-cuda12x-13.3.0 fastrlock-0.8.2

Immediately worked.

@SnzFor16Min it's not about conda-forge. It's v13.3.0 skipping building the Jitify cache in most cases. If you can help confirm, please check with pip install "cupy-cuda12x==13.2.0" and see if it is stuck too. If it does, please let's follow up in the issue that @ryanshrott opened: https://github.com/cupy/cupy/issues/8322 and share your environment config with us (since the Jitify cache is not gone, just less likely that it's needed) to help us diagnose.

Just to clarify is the pip install meant to be 13.3.0 too?

When @SnzFor16Min installed from pip v13.3.0 was installed and it worked (no surprise). I was asking to install v13.2.0 from pip, in which case it should fail and this failure would be independent of the package source (conda/pip) but depend on something else that the discussion we had in #8322 might help.

Thanks @leofang for pointing that out. I created a fresh-new environment and checked v13.2.0 from both; surprisingly they all worked it out, albeit slower than the claimed "a few seconds". Seems that I have to check my dev env. Also, conda-forge always ran slower than pip. For later debugging I'll leave the commands here:
# Environment for pip:
micromamba create -n test_pip python=3.11 -c "https://conda.anaconda.org/conda-forge" --override-channels
micromamba activate test_pip
pip install "cupy-cuda12x==13.2.0" -i "https://pypi.org/simple/"
rm -rf ~/.cupy/ && time python -c "import cupy; cupy.sparse.rand(200,200).tocsr()"

/root/micromamba/envs/test_pip/lib/python3.11/site-packages/cupy/cuda/compiler.py:233: PerformanceWarning: Jitify is performing a one-time only warm-up to populate the persistent cache, this may take a few seconds and will be improved in a future release...
  jitify._init_module()

real    1m25.747s
user    0m52.264s
sys     0m8.065s

# Environment for conda-forge:
micromamba create -n test_conda python=3.11 cuda-version=12.1 cupy=13.2.0 -c "https://conda.anaconda.org/conda-forge" --override-channels
micromamba activate test_conda
rm -rf ~/.cupy/ && time python -c "import cupy; cupy.sparse.rand(200,200).tocsr()"

/root/micromamba/envs/test_conda/lib/python3.11/site-packages/cupy/cuda/compiler.py:233: PerformanceWarning: Jitify is performing a one-time only warm-up to populate the persistent cache, this may take a few seconds and will be improved in a future release...
  jitify._init_module()

real    1m50.185s
user    1m14.954s
sys     0m8.270s


[Camera] Update README.md

Slightly improved the documentation by listing the feature the camera plugin supports
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Snimm are you still working on this? This needs a CLA and a version bump.

I did sign the cla.


Container Run Issue

Hello,
after building a "go" binary i suceeded to build also a docker image. But as i wanted to run the container i recieved this message:
"docker: Error response from daemon: Container command '/apache_exporter' not found or does not exist".

Hi. I also encountered the same problem when trying to run Docker along the README.
Normally, when go is built in a Linux environment such as Ubuntu, a binary linked to glibc is created.
# ldd apache_exporter
    linux-vdso.so.1 =>  (0x00007ffe1b728000)
    libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fd5d3798000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd5d33ce000)
    /lib64/ld-linux-x86-64.so.2 (0x000055d0978e2000)

However, since alpine uses musl instead of glibc, it does not work if you just moved the binary. If you just need to run apache_exporter, it is easiest to use golang:alpine docker image.
If you need a lightweight DockerImage, it is easy to use a multi-stage build as below, but you can not build it unless the Docker version is 17.05 or later.
https://docs.docker.com/engine/userguide/eng-image/multistage-build/
In any case, because there are cases where it does not work well with the method of README, I will send a pull request to fix the problem.


ignore remove only first child

If I set the ignore property to select all nodes with the class. Only the first node has been removed from the target image.

It should be fixed now, but I haven't tested it


[HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] 0 is showing up in black small font in split bill preview

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.37-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @alitoshmatov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707150156382219
Action Performed:

Open group with 2 other accounts
Split bill
Scan receipt

Expected Result:
0 shouldn't show up like that for amount
Actual Result:
In split preview there is a zero showing small black font
Workaround:
UNknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01071057525b16cfaa
Upwork Job ID:<PHONE_NUMBER>662765568
Last Price Increase: 2024-02-06
Automatic offers:

situchan | Contributor | 28146438

Cool, confirming @VickyStash we're handling it here right? https://github.com/Expensify/App/pull/35916
@situchan, shall I assign you both here?

yes please

@trjExpensify yes, mentioned PR should fix the issue

Cool, done! Are we tracking the deploy blocker on the OG issue or need it here?

May need it here

Merged the fix: https://github.com/Expensify/App/pull/35916

Requested CP here: https://expensify.slack.com/archives/C07J32337/p1707243919696259

Confirmed that it got fixed by https://github.com/Expensify/App/issues/35915#issuecomment-1930521210

@situchan confirming there's nothing for us to do on this regression issue, right? We can close it out as the OG issue is where any payment and what not will happen?

I am eligible here as I was not involved in offending PR

Ah cool, okay. Settled up $500 with you for the review. Closing!


Curio crash

the mod causes a crash if installed alongside Create and Curios api, those are the only 3 mods i had installed. If i click on the curio head slot with this mod installed, it just outright crashes the game
MC 1.20.1, Forge 47.2.20

Fixed a while ago, You reported this issue in the wrong repository that I rarely checked so sorry for missing this but I archived that repo and left a disclaimer in the ReadMe. Thanks for letting me know though :)


[BUG] Bloxstrap new instance memory issue

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
I've noticed my ram increase slowly whilst using bloxstrap and after checking task manager I see 100+ bloxstrap instances using 3-50 mb's of Ram.
Note: I'm using a python script to teleport into roblox places that have welcome badges, since im badge grinding, and it opens a new instance of bloxstrap to smoothly teleport. Unfortunately it doesnt seem like it fully closes the previous instance or something like that.

Do you have the option to run multiple instances enabled?

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.


Want to Add Blog Page

We need to add a new Blog Page to this website. This page will display a list of blog posts with titles, excerpts, and publication dates. Each blog post should be clickable, leading to a detailed view of the post. The design will be clean, responsive, and consistent with the overall site aesthetics.

Want to do dynamic

Hey @thestarsahil Actually there is a  problem whenever user login /signup his information is not getting stored in realtime database it is just getting authenticated so i am raising new issue for that after that only i could make this page .

@nishant0708 ok


move tutorial guide to book chapter

it's currently just a markdown file in the repository root, but not rendered on the website.
https://github.com/uwhackweek/jupyterbook-template/blob/main/tutorial_guide.md
on a related note, it would be good to turn the current 'example' notebook into a template notebook with required section headings
https://github.com/uwhackweek/jupyterbook-template/blob/main/book/tutorials/example/intro-ipyleaflet.ipynb

As discussed today with @aaarendt and @jomey , some suggested improvements:

[ ] example .ipynb notebook should be simple, but include some common things such as embedding an image in markdown, adding a markdown table
[ ] Move open source software and open science to references, since they fit into that structure better


viro not support expo lastest vetsion?

Requirements:
Please go through this checklist before opening a new issue

[x] Review the documentation
[x] Search for existing issues in: ViroCommunity/viro
[x] Use the latest ViroReact release

Environment
Please provide the following information about your environment:

Development OS: Mac
Device OS & Version: tried ios 18.1.1 and 18.2
Version: ViroReact version 2.41.1 and React Native version 0.76.5
Device(s): iphone 11pro

Description
Describe your issue in detail. Include screenshots if needed. If this is a regression, let us know.
it's success to expo build below command, and can play vino at old version 50 in this sample this repository
but i want to use latest expo version 52.
expo run:ios --device

so i try to update expo to52, rewrite package.json like below...
{
  "name": "expo-starter-kit-typescript",
  "version": "1.0.0",
  "main": "node_modules/expo/AppEntry.js",
  "scripts": {
    "start": "expo start",
    "clear": "expo start --clear",
    "android": "expo run:android",
    "ios": "expo run:ios",
    "web": "expo start --web",
    "run:ios": "expo run:ios --device",
  },
  "dependencies": {
    "@expo/cli": "0.22.7",
    "@react-native-community/cli": "^15.1.3",
    "@reactvision/react-viro": "^2.41.6", // ← replace from @viro-community/react-viro
    "expo": "52.0.21",
    "expo-status-bar": "~2.0.0",
    "npm-check-updates": "^17.1.11",
    "react": "18.2.0",
    "react-native": "0.76.5"
  },
  "devDependencies": {
    "@babel/core": "^7.26.0",
    "@types/react": "^18.2.6",
    "typescript": "^5.7.2"
  },
  "private": true
}

And change import to "@reactvision/react-viro" from  "@viro-community/react-viro".
import {
  ViroARScene,
  ViroText,
  ViroTrackingStateConstants,
  ViroARSceneNavigator,
  ViroTrackingReason,
--- } from "@viro-community/react-viro";
+++ } from "@reactvision/react-viro";

finally, There is success to build.

Click to toggle contents of build success log
$ expo run:ios --device

><EMAIL_ADDRESS>run:ios
> expo run:ios --device

✔ Select a device › 🔌 Dev1のiPhone (3) (18.1.1)
› Using --device 00008030-000A19D40E20802E
› Auto signing app using team(s): "V52HY42TDL"
› Planning build
    Run script build phase '[CP-User] [Hermes] Replace Hermes for the right configuration, if needed' will be run during every build because it does not specify any outputs. To address this issue, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'hermes-engine' from project 'Pods')
› Executing react-native Pods/hermes-engine » [CP-User] [Hermes] Replace Hermes for the right configuration, if needed
› Executing react-native Pods/hermes-engine » [CP] Copy XCFrameworks
› Preparing Pods/RCT-Folly-RCT-Folly_privacy » ResourceBundle-RCT-Folly_privacy-RCT-Folly-Info.plist
› Preparing Pods/boost-boost_privacy » ResourceBundle-boost_privacy-boost-Info.plist
› Preparing Pods/glog-glog_privacy » ResourceBundle-glog_privacy-glog-Info.plist
› Preparing Pods/React-cxxreact-React-cxxreact_privacy » ResourceBundle-React-cxxreact_privacy-React-cxxreact-Info.plist
› Preparing Pods/React-Core-React-Core_privacy » ResourceBundle-React-Core_privacy-React-Core-Info.plist
    Run script build phase '[CP-User] [RN]Check rncore' will be run during every build because it does not specify any outputs. To address this issue, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'React-Fabric' from project 'Pods')
› Executing react-native Pods/React-Fabric » [CP-User] [RN]Check rncore
› Executing expo-starter-kit-typescript Pods/ReactCodegen » [CP-User] Generate Specs
› Compiling expo-starter-kit-typescript Pods/ReactCodegen » RCTModulesConformingToProtocolsProvider.mm
› Compiling expo-starter-kit-typescript Pods/ReactCodegen » FBReactNativeSpec-generated.mm
› Compiling expo-starter-kit-typescript Pods/ReactCodegen » FBReactNativeSpecJSI-generated.cpp
› Packaging expo-starter-kit-typescript Pods/ReactCodegen » libReactCodegen.a
    Run script build phase '[CP-User] [RN]Check rncore' will be run during every build because it does not specify any outputs.  To address this issue, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'EXConstants' from project 'Pods')
› Build Succeeded

› 0 error(s), and 5 warning(s)

Starting Metro Bundler
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
█ ▄▄▄▄▄ █▀▄██▀  ▀  █▄ ▀▄▄█  ▀ ▀█▄ █ ▄▄▄▄▄ █
█ █   █ █▀ ▀▄ ▄▀█ ▄▄█ ▄███▀█ ▄▀ █▄█ █   █ █
█ █▄▄▄█ █▀██████ ▀▄ █▀▄▄▄ ▀▄▀█▄ █▄█ █▄▄▄█ █
█▄▄▄▄▄▄▄█▄█ █ █▄▀▄█ █▄▀ █ █▄▀ █ ▀▄█▄▄▄▄▄▄▄█
█▄▄  ▄▀▄▄ ▀▀ █▄▄▄▀▄█▀▀▀▄▀▄▄█▄▀▄█▀▀ ▀ ▀ ▀ ▀█
█ ▄█▄  ▄▄███  █▀ ▀█▄▀  ▀█ █▀ ▀██▀▀▀█  ▄█ ██
█ ▀▄▀█▄▄   ▀█▄▀▀▀▀█▄▄▀ █▀▀ █▄▄▄▄ ▄█▀ ▀▀ ▀▀█
██▄▀▀▄█▄▀▄▄▄ ▄█ █▀█  ▀▀▀█ █ ▄▀█ █ ▄ █▄▄▄█▀█
█▀  ▄▀█▄▄▄ ▀ ▄ ▄█▀ ▀ ██  █ ▄▄ ▄▀▀█▀▀ ▀  █ █
█▀▀▄▄▄▄▄██▄██▄ ▄   ▀▀ █▄█▀▄▄▄█▄ ▀ ▀█▄▄▀▄▀▀█
█  ▀ █ ▄█ ▀█▄▀█▄ ▄▀▀▄▄ ▄ ▀ ▀▄▄▀▀ ██▀▀▀  ▀ █
█▀ █ ▄ ▄██▀██▀█  ▄▄██▄▀██▀▄▀▄▀▄██▄▄▄ ▄ ▄█▀█
█▀▄▄ ▀█▄ ▄▀ ▀▄▄▄▄▀▄ ▀█▀▄▀█▄▄█ ▄ ▀▀▀▀ ▀ ▄ ▀█
██▄▄██ ▄█▄█ ▀▀█▀▄▀█▄▀█ ▀█▄█▄ ▄▄▀▀▀ █ █▀████
█▀▀███ ▄▄▀█ █▄▀▀ ▀▀▄▄▀▄▀█▄ ▀▄█ ▄▄▀ ▀▄▀▀▄▀▀█
█ █▄█  ▄ █▀▀ ▄▄▄█▀██ ▀ ▀▀▀█▀ ███▀▄▄ ▀▄ ██▀█
█▄████▄▄█  █ ▄  █  ▀ ▄█ ▀█▄ ▄▀▄██ ▄▄▄     █
█ ▄▄▄▄▄ █▄████ ▄   ▀█▀█▄██▄▄ ▀█▄  █▄█  ▄███
█ █   █ █ █▄▄▀█▄ ▄█▀█▄ ▄ ▀▄█▄▄▄▄▀▄▄▄▄▄█▄  █
█ █▄▄▄█ █ ▀▄█▀█▄ ▄█▀█▄ ████▄ █▄▄▀ ▄▄  ▀▄▀██
█▄▄▄▄▄▄▄█▄▄██▄▄█▄█▄██▄█▄█▄▄█▄▄▄█████▄██▄███

› Metro waiting on com.tomoyukikino.expo-starter-kit-typescript://expo-development-client/?url=http%3A%2F%2F<IP_ADDRESS>%3A8081
› Scan the QR code above to open the project in a development build. Learn more

› Using development build
› Press s │ switch to Expo Go

› Press a │ open Android
› Press i │ open iOS simulator
› Press w │ open web

› Press j │ open debugger
› Press r │ reload app
› Press m │ toggle menu
› shift+m │ more tools
› Press o │ open project code in your editor

› Press ? │ show all commands

› Installing /Users/tomoyuki/Library/Developer/Xcode/DerivedData/expostarterkittypescript-dalayycyfsarfmhjrdvyrvcqrgiy/Build/Products/Debug-iphoneos/expostarterkittypescript.app
✔ Complete 100%

› Logs for your project will appear below. Press Ctrl+C to exit.
› Reloading apps
No apps connected. Sending "reload" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.
› Reloading apps
No apps connected. Sending "reload" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.
› Reloading apps
No apps connected. Sending "reload" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.
› Reloading apps
No apps connected. Sending "reload" to all React Native apps failed. Make sure your app is running in the simulator or on a phone connected via USB.
iOS Bundled 811ms node_modules/expo/AppEntry.js (713 modules)
iOS Bundled 45ms node_modules/expo/AppEntry.js (1 module)
iOS Bundled 47ms node_modules/expo/AppEntry.js (1 module)
iOS Bundled 43ms node_modules/expo/AppEntry.js (1 module)
iOS Bundled 57ms node_modules/expo/AppEntry.js (1 module)
iOS Bundled 46ms node_modules/expo/AppEntry.js (1 module)
iOS Bundled 493ms node_modules/expo/AppEntry.js (711 modules)
 (NOBRIDGE) LOG  Bridgeless mode is enabled
 (NOBRIDGE) ERROR  TypeError: Cannot read property 'setJSMaterials' of null
 INFO
 💡 JavaScript logs will be removed from Metro in React Native 0.77! Please use React Native DevTools as your default tool. Tip: Type j in the terminal to open (requires Google Chrome or Microsoft Edge).
 (NOBRIDGE) WARN  🚨 React Native's New Architecture is always enabled in Expo Go, but it is not explicitly enabled your project app config. This may lead to unexpected behavior when you create a production or development build. Set "newArchEnabled": true in your app.json.
Learn more: https://docs.expo.dev/guides/new-architecture/

So I opened app in my iphone by expo development build, but crashed.
viro not support expo lastest vetsion?
Reproducible Demo
Let us know how to reproduce the issue. Include a code sample, screen capture, video recording. The more information you provide, the better we can support you.
https://github.com/user-attachments/assets/185b0eec-d05f-46a1-99bc-4389b2469bef

same issue here.

viro may not support latest version react-native?


Fix bug in ZBoxRule

Parameter modification wasn't applied correctly due to typo in dispatch on symbol.

Codecov Report

Merging #77 (8b6eca1) into master (e6061e5) will increase coverage by 0.93%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   91.47%   92.41%   +0.93%
==========================================
  Files          12       12
  Lines         352      356       +4
==========================================
+ Hits          322      329       +7
+ Misses         30       27       -3

Impacted Files
Coverage Δ

src/utils.jl
67.85% <75.00%> (+2.85%)
:arrow_up:

src/lrp_rules.jl
95.55% <100.00%> (+7.91%)
:arrow_up:

src/compat.jl
0.00% <0.00%> (-25.00%)
:arrow_down:

src/lrp.jl
95.65% <0.00%> (-0.19%)
:arrow_down:

src/input_augmentation.jl
95.74% <0.00%> (-0.18%)
:arrow_down:

src/canonize.jl
96.42% <0.00%> (-0.13%)
:arrow_down:

src/gradient.jl
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6061e5...8b6eca1. Read the comment docs.


Make image loading asynchronous.

The UX isn't great right now, especially when you open a project file with a bunch of images in it. It doesn't even draw the window properly first, it just freezes until all the images are loaded. It would be better if the images appeared as they were loaded and possibly have a progress bar.
Would have to make sure that you can't break things by modifying stuff while it's still loading.
Could also look into multithreading? It may not be possible for this purpose.

Closed by 16bf3224e9ef6f5f9931137d4123cbd01bcb2dac (multi-threaded image loading).


Adding Algolia search engine support

Using Google Custom Search Engine (https://cse.google.com/cse/) instead of Algolia.


Should fix #17

Thanks, we had to create a new branch and do some more changes as the version of pace that we were using was a fork of the original repo.


[MOO-1199] Update Native Template release note

We haven't released the NT yet; I'll inform you when we do

@ConnorLand FYI; I will update the release date when we release NT


why downloading vscode application transfer to bing search

VSCode Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

/needsMoreInfo