API-M 4.4.0 Migration Effort

Description
This issue is created to track the tasks for APIM 4.4.0 migration.

[x] Creating migration data population script for APIM 4.3.0.
[x] Creating initial DB script for migration based on the new changes to the product from features and dependency upgrades.
[x] Manual Migration Testing with the populated data. APIM 4.2.0 - APIM 4.4.0 direct migration.

[x]  Mysql testing
[x]  Postgresql DB testing
[x]  Mssql DB testing
[x]  Oracle DB testing
[x]  DB2 DB testing

[x] Manual Migration Testing with the populated data. APIM 4.3.0 - APIM 4.4.0

[x]  Mysql testing
[x]  Postgresql DB testing
[x]  Mssql DB testing
[x]  Oracle DB testing
[x]  DB2 DB testing

[x] Fixing the code to support the migration based on the new changes introduced to the product.
[x] Fixing issues encountered during migration testing.
[x] Creating migration documentation.
[ ] Creating automation for migration testing.

Version combinations to test :

APIM 4.2.0 - APIM 4.4.0
APIM 4.3.0 - APIM 4.4.0

Affected Component
APIM
Version
4.4.0
Related Issues
No response
Suggested Labels
No response

Update

An APIM 4.2.0 setup was done with the data population.
Created the MYSQL script for direct migration from APIM 4.2.0 to APIM 4.4.0.
Tested the APIM 4.4.0 setup after the migration. This was tested in an APIM 4.4.0-alpha pack.
The following issues were encountered.

Issue 1 : Error during startup
The following exception was thrown during startup when trying to load an API Product. The issue happens after the fix https://github.com/wso2/carbon-apimgt/pull/12416. This is the same for APIM 4.3.0 as well. This is because the Product versioning concept was introduced from APIM 4.3.0 onwards and due to that, the formation of the product context has changed. Previously the context did not have the version appended. But now it has.
[2024-10-03 18:18:22,858] ERROR - Framework FrameworkEvent ERROR
java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 15
	at java.lang.String.checkBoundsBeginEnd(String.java:3319) ~[?:?]
	at java.lang.String.substring(String.java:1874) ~[?:?]
	at org.wso2.carbon.apimgt.gateway.internal.DataHolder.addAPIMetaData_aroundBody46(DataHolder.java:199) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.internal.DataHolder.addAPIMetaData(DataHolder.java:1) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.listeners.GatewayStartupListener.lambda$1_aroundBody48(GatewayStartupListener.java:236) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.listeners.GatewayStartupListener.lambda$1(GatewayStartupListener.java:1) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at java.util.ArrayList.forEach(ArrayList.java:1541) ~[?:?]
	at org.wso2.carbon.apimgt.gateway.listeners.GatewayStartupListener.retrieveAllAPIMetadata_aroundBody10(GatewayStartupListener.java:236) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.listeners.GatewayStartupListener.retrieveAllAPIMetadata(GatewayStartupListener.java:1) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.listeners.GatewayStartupListener.completedServerStartup_aroundBody8(GatewayStartupListener.java:196) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.listeners.GatewayStartupListener.completedServerStartup(GatewayStartupListener.java:1) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.core.internal.CarbonCoreServiceComponent.notifyAfter(CarbonCoreServiceComponent.java:264) ~[?:?]
	at org.wso2.carbon.core.internal.StartupFinalizerServiceComponent.completeInitialization(StartupFinalizerServiceComponent.java:214) ~[?:?]
	at org.wso2.carbon.core.internal.StartupFinalizerServiceComponent.serviceChanged(StartupFinalizerServiceComponent.java:309) ~[?:?]

Issue 2 : Error when loading the shared scopes page in Publisher
The following error was encountered when loading the shared scopes page in Publisher portal when there are shared scopes used by one or several APIs and API Products. The issue is a result of the fix https://github.com/wso2/carbon-apimgt/pull/12452. API Product url mappings were not considered.
java.lang.NullPointerException: null
	at org.wso2.carbon.apimgt.impl.dao.ApiMgtDAO.getSharedScopeUsage_aroundBody830(ApiMgtDAO.java:17125) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.impl.dao.ApiMgtDAO.getSharedScopeUsage(ApiMgtDAO.java:1) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.impl.APIProviderImpl.getSharedScopeUsage_aroundBody394(APIProviderImpl.java:5172) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.impl.APIProviderImpl.getSharedScopeUsage(APIProviderImpl.java:1) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.impl.UserAwareAPIProvider.getSharedScopeUsage(UserAwareAPIProvider.java:1) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.impl.ScopesApiServiceImpl.getSharedScopeUsages(ScopesApiServiceImpl.java:184) ~[?:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.ScopesApi.getSharedScopeUsages(ScopesApi.java:106) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]

Issue 3 : No APIs listed when creating an API Product
When trying to create a new API Product or when trying to edit resources of an API Product, the UI does not list any API. The message says No REST APIs are created yet. The reason is, for migrated APIs, the gatewayType and gatewayVendor fields are null when retrieving all APIs to the UI. We check the gatewayType when displaying the APIs for API Product resource editing UI. Since gatewayType is null in the search result set, no APIs are displayed.
Issue 4 : Error when loading an API which has maxTps defined.
In Publisher, the following exception is thrown when loading an API which has maxTps values defined in Runtime page.
[2024-10-04 14:50:40,688] ERROR - GlobalThrowableMapper An unknown exception has been captured by the global exception mapper.
java.lang.NullPointerException: null
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.common.mappings.APIMappingUtil.setMaxTpsFromModelToApiDTO(APIMappingUtil.java:1676) ~[org.wso2.carbon.apimgt.rest.api.publisher.v1.common_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.common.mappings.APIMappingUtil.fromAPItoDTO(APIMappingUtil.java:1447) ~[org.wso2.carbon.apimgt.rest.api.publisher.v1.common_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.common.mappings.APIMappingUtil.fromAPItoDTO(APIMappingUtil.java:1059) ~[org.wso2.carbon.apimgt.rest.api.publisher.v1.common_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.impl.ApisApiServiceImpl.getAPIByID(ApisApiServiceImpl.java:3701) ~[?:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.impl.ApisApiServiceImpl.getAPI(ApisApiServiceImpl.java:244) ~[?:?]
	at org.wso2.carbon.apimgt.rest.api.publisher.v1.ApisApi.getAPI(ApisApi.java:678) ~[?:?]

Issue 5 : Error when trying to invoke an API
The following error is encountered when trying to invoke an API for both tenant and super tenant. The reason is the change in the Product versioning concept.
[2024-10-04 20:40:33,944] ERROR - ServerWorker Error processing GET request for : /t/adpsample.com/pizzashack/1.0.0/menu.
java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 15
	at java.lang.String.checkBoundsBeginEnd(String.java:3319) ~[?:?]
	at java.lang.String.substring(String.java:1874) ~[?:?]
	at org.wso2.carbon.apimgt.keymgt.model.impl.SubscriptionDataStoreImpl.getAllAPIsByContextList_aroundBody92(SubscriptionDataStoreImpl.java:779) ~[org.wso2.carbon.apimgt.keymgt_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.keymgt.model.impl.SubscriptionDataStoreImpl.getAllAPIsByContextList(SubscriptionDataStoreImpl.java:1) ~[org.wso2.carbon.apimgt.keymgt_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.handlers.Utils.getSelectedAPIList_aroundBody58(Utils.java:700) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.handlers.Utils.getSelectedAPIList(Utils.java:1) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.handlers.DefaultAPIHandler.handleRequestInFlow_aroundBody0(DefaultAPIHandler.java:77) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.gateway.handlers.DefaultAPIHandler.handleRequestInFlow(DefaultAPIHandler.java:1) ~[org.wso2.carbon.apimgt.gateway_9.30.10.jar:?]
	at org.apache.synapse.core.axis2.Axis2SynapseEnvironment.invokeHandlers(Axis2SynapseEnvironment.java:1202) ~[synapse-core_4.0.0.wso2v128.jar:4.0.0-wso2v128]

Issue 6 : Error when loading the Scope Assignments page in Admin portal
The following warnings are thrown when loading the Scope Assignments page in the Admin portal. This is due to the missing scopes coming from new features introduced in APIM 4.3.0 and APIM 4.4.0. This behaviour is the same for APIM 4.3.0 migrated setup as well.
[2024-10-04 20:34:19,154]  WARN - SystemScopesMappingUtil The scope apim:gateway_policy_manage does not exist in tenant.conf
[2024-10-04 20:34:19,154]  WARN - SystemScopesMappingUtil The scope apim:gateway_policy_view does not exist in tenant.conf
[2024-10-04 20:34:19,155]  WARN - SystemScopesMappingUtil The scope apim:api_provider_change does not exist in tenant.conf
[2024-10-04 20:34:19,155]  WARN - SystemScopesMappingUtil The scope apim:llm_provider_manage does not exist in tenant.conf
[2024-10-04 20:34:19,155]  WARN - SystemScopesMappingUtil The scope apim:llm_provider_read does not exist in tenant.conf

Issue 7 : Error when loading the Change API Provider page in the Admin portal
The following error is thrown when loading the Change API Provider page in Admin portal. The reason is the artifacts become null for documents. This behaviour is the same for a non migrated default APIM 4.4.0 pack as well when an API has a document attached. The same issue persists for APIM 4.3.0.
[2024-10-04 20:32:40,009] ERROR - GlobalThrowableMapper An unknown exception has been captured by the global exception mapper.
java.lang.NullPointerException: null
	at org.wso2.carbon.apimgt.persistence.RegistryPersistenceImpl.searchContentForAdmin(RegistryPersistenceImpl.java:3971) ~[org.wso2.carbon.apimgt.persistence_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.impl.APIAdminImpl.searchPaginatedApis_aroundBody154(APIAdminImpl.java:1528) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.impl.APIAdminImpl.searchPaginatedApis(APIAdminImpl.java:1) ~[org.wso2.carbon.apimgt.impl_9.30.10.jar:?]
	at org.wso2.carbon.apimgt.rest.api.admin.v1.impl.ApisApiServiceImpl.getAllAPIs(ApisApiServiceImpl.java:69) ~[?:?]
	at org.wso2.carbon.apimgt.rest.api.admin.v1.ApisApi.getAllAPIs(ApisApi.java:54) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]

Thanks,
Tharika.

Update
The fixes and comments regarding each of the above errors are as follows.
Issue 1 : Error during startup
This issue was fixed with the code https://github.com/wso2/carbon-apimgt/pull/12635/files#diff-2b416597458d994d9b8a486b337595f4b0a5381b3e76d55ed712642a1eddd94dR198-R202
Issue 2 : Error when loading the shared scopes page in Publisher
This issue was fixed with the code https://github.com/wso2/carbon-apimgt/pull/12635/files#diff-ac8fc1b7b2d10089084f9f842ad03ac096b64f8c555798aa18a926e0ec663a4cR17132-R17138
Issue 3 : No APIs listed when creating an API Product
This issue was fixed with the code https://github.com/wso2/carbon-apimgt/pull/12635/files#diff-f366598ae991e829fe8295cfee12176f8a8fa05a0644057f687491a411216935R177
Issue 4 :  Error when loading an API which has maxTps defined
This issues was fixed with the code https://github.com/wso2/carbon-apimgt/pull/12635/files#diff-1bd7039dfec986964ddba692c98bdebfcf30062e42f4d30e6b6a6e39ea197631R1694
Issue 5 : Error when trying to invoke an API
This issue was fixed with the code https://github.com/wso2/carbon-apimgt/pull/12635/files#diff-47915adaff738f6d7b3bccea8d0456399f7ef09e62e7522543d5923246dcf363R778-R783
Issue 6 : Error when loading the Scope Assignments page in Admin portal
To fix this issue we have to manually add the scope mappings to the tenant-con from Admin Portal. This has to be done for all tenants. However since this warning is harmless and if required, the scopes can be added manually based on the usage of the new feature, no further action is required.
But we can look into some on the fly tenant-conf changes if needed.
Issue 7 : Error when loading the Change API Provider page in the Admin portal
This issue is fixed from the code https://github.com/wso2/carbon-apimgt/pull/12635/files#diff-e193f41af36b63c9f226e35c981eeae30ee45850c880876c502785b547dbe00cR3971-R3974. Although the initial loading issue is fixed, there is another issue that happens for a migrated setup.
No APIs are listed after loading the Change API Provider page. Even if a new API is created, no APIs are listed here. This issue does not occur in a normal non migrated APIM 4.4.0 setup. When searching for content for Admin, only the previously migrated document resources are returned from the persistence layer. No new resource is returned.
I have attempted reindexing as well, but the issue persists. This is the same for APIM 4.3.0.
This issue needs to be fixed.
Thanks,
Tharika.

Hi all,

An APIM 4.2.0 pack has been migrated to 4.4.0 with PostgreSQL using the latest master pack.
The database script for the 4.2.0 to 4.4.0 PostgreSQL live migration has been created.
No startup errors were observed, and further testing will be performed.

Environment Details

Database Version: 14.12
Connector Version: postgresql-42.7.3.jar

Testing

[ ] Admin UI walkthrough
[ ] Publisher UI walkthrough
[ ] Developer Portal UI walkthrough
[ ] Migrated API/API product invocation
[ ] New API/API product creation
[ ] New API/API product deployment
[ ] New API/API product invocation

Thank you
Avishka

Hi All,
I have attempted to migrate a 4.2.0-4.4.0 pack using DB2. However, following error was observed while deploying Sample PizzaShack API on 4.2.0.
[2024-10-09 13:48:26,993] ERROR - GatewayArtifactsMgtDAO Failed to Add Artifact to Database
com.ibm.db2.jcc.am.SqlSyntaxErrorException: DB2 SQL Error: SQLCODE=-798, SQLSTATE=428C9, SQLERRMC=TIME_STAMP, DRIVER=4.27.25
	at com.ibm.db2.jcc.am.b7.a(b7.java:810) ~[db2jcc4.jar:?]
	at com.ibm.db2.jcc.am.b7.a(b7.java:66) ~[db2jcc4.jar:?]

Environment Details
Db Version: v<IP_ADDRESS>
Connector Version: db2jcc4.jar
This is suspected to be an issue with the DB version or the connector used. Will further analyze this and provide an update
Thank you
Avishka

MSSQL
Hi All,
The migration based on MSSQL 2022 is ongoing. I have completed APIM 4.2.0 data population and backups of said dbs
Thank you
Avishka

Update
This is an update regarding the follow up issue under Issue 7 reported in comment [1] and is reproduced in every migration DB testing above.
This is an issue in the Change API Provider feature when multiple (more than 10) documents, and API Products are available in the system. This is not related to migration. I have created a public issue[2] to track it.
[1] https://github.com/wso2/api-manager/issues/3139#issuecomment-2394924817
[2] https://github.com/wso2/api-manager/issues/3241
Thanks,
Tharika.

DB2
Hi all,

An APIM <IP_ADDRESS> pack has been migrated to 4.4.0 (latest) with DB2.
The database script for the 4.2.0 to 4.4.0 DB2 live migration has been created.
Observed several changes required to 4.2.0 db2 scripts as current script does not work. Issue is open to fix those
Also, observed changes required to 4.2.0-4.3.0 migration db script. Changes will be sent with PR
Created a db script for 4.2.0-4.4.0 migration
After successfully populating 4.2.0 with data was able to migrate the pack to 4.4.0 with no issues at start up

Environment Details

Database Version: V11.5
Connector Version: db2jcc.jar 4.27

Testing

[ ] Admin UI
[ ] Publisher UI
[ ] Developer Portal UI
[ ] Migrated API/API product invocation
[ ] New API/API product creation
[ ] New API/API product deployment
[ ] New API/API product invocation
[ ] Create, deploy, publish and invoke a new AI API

Issues
01 - Error when loading the Change API Provider page in the Admin portal
The same error observed with MySQL migration was observed with Postgres as well
Thank you
Avishka

Update
The issue[1] was encountered during migration testing for all DB versions tested so far. This is a bug in APIM versions 4.2.0, 4.3.0 and also 4.4.0. Since the Jmeter script used to execute the data population has the same event order as mentioned in [1], the issue happens in the source version (APIM 4.2.0) itself. Hence this is not an issue triggered from migration. Created the public issue [1] for this.
[1] https://github.com/wso2/api-manager/issues/3247
Thanks,
Tharika.

Update
I have tested the APIM 4.3.0 to APIM 4.4.0 migration for MySQL. We had to do few changes to the data population jmeter script. The same jmeter change applies to APIM 4.2.0. The manual tests pass with the fixes introduced in [1].
[1] https://github.com/wso2/api-manager/issues/3139#issuecomment-2394924817
Thanks,
Tharika.

Update
Added the initial changes for the existing migration docs with PR [1].
[1] https://github.com/wso2-enterprise/migration-docs/pull/265
Thanks,
Tharika.

Oracle
Hi all,

An APIM <IP_ADDRESS> pack has been migrated to 4.4.0 (latest) with Oracle:XE 18.
The database script for the 4.2.0 to 4.4.0 Oracle live migration has been created.
After successfully populating 4.2.0 with data, was able to migrate the pack to 4.4.0 with no issues at start up

Environment Details

Database Version: Oracle:XE 18
Connector Version: ojdbc8.jar

Testing

[x] Admin UI
[x] Publisher UI
[x] Developer Portal UI
[x] Migrated API/API product invocation
[x] New API/API product creation
[x] New API/API product deployment
[x] New API/API product invocation
[x] Create, deploy, publish and invoke a new AI API

Issues
01 - Error when loading the Change API Provider page in the Admin portal
The same error observed with MySQL migration was observed with Postgres as well
Thank you
Avishka

Update - Issue
Notice the following behavior on Oracle migrated pack, observed the same in the Postgres Migrated pack as well
Use tenant<EMAIL_ADDRESS>
In the migrated set up, deploy and publish the pizzashack API if you have not done so
Go to ADPAPIProduct :1.0.0 -> Resources -> Edit Resources -> Add 'menu' from pizzashack API -> Select 'Save and Deploy'
Go to dev portal and subscribe to ADPAPIProduct :1.0.0
Try to invoke resource 'menu'.

Following error could be observed
[2024-10-13 22:10:59,717] ERROR - APIAuthenticationHandler API authentication failure due to Unclassified Authentication Failure
org.wso2.carbon.apimgt.gateway.handlers.security.APISecurityException: Unclassified Authentication Failure
	at org.wso2.carbon.apimgt.gateway.handlers.security.APIAuthenticationHandler.isAuthenticate_aroundBody64(APIAuthenticationHandler.java:616) ~[org.wso2.carbon.apimgt.gateway_9.30.43.SNAPSHOT.jar:?]

Thank you
Avishka

Update
The data populator scripts for APIM 4.2.0 and 4.3.0 are added via PR [1].
[1] https://github.com/wso2-enterprise/apim-migration-resources/pull/487
Thanks,
Tharika.

Update
The 4.2.0-4.4.0 db migration scripts have been added via PR [1]
[1] https://github.com/wso2-enterprise/migration-docs/pull/266
Thank you
Avishka

Update - Oracle

Migrated the <IP_ADDRESS> to 4.4.0 successfully.
Created the db script for the migration as well.
No migration issues detected.

Env Details

Database Version: Oracle:XE 18
Connector Version: ojdbc8.jar
Java Version: openjdk 11.0.19

Thank you
Avishka

Update - MSSQL

Migrated the <IP_ADDRESS> to 4.4.0 successfully.
Created the db script for the migration as well.
No migration issues detected.

Env Details

Database Version: Microsoft SQL Server 2022
Connector Version: mssql-jdbc-12.8.1.jre11.jar
Java Version: openjdk 11.0.19

Thank you
Avishka

Update - DB2

Migrated the <IP_ADDRESS> to 4.4.0 successfully.
Created the db script for the migration as well.
No migration issues detected.

Env Details

Database Version: V11.5
Connector Version: db2jcc.jar 4.27
Java Version: openjdk 11.0.19

Thank you
Avishka

Update - DB2

Migrated the <IP_ADDRESS> to 4.4.0 successfully.
Created the db script for the migration as well.
No migration issues detected.

Env Details

Database Version: 14.12
Connector Version: postgresql-42.7.3.jar
Java Version: openjdk 11.0.19

Thank you
Avishka

Update
The 4.3.0-4.4.0 db migration scripts have been added via PR [1]
[1] - https://github.com/wso2-enterprise/migration-docs/pull/268
Thank you
Avishka

Hi all,
The issue reported https://github.com/wso2/api-manager/issues/3139#issuecomment-2409047946 is not related to migration but rather to the payload used to create the API Product in the JMeter data populator script. The script did not account for the versioning support for products introduced in version 4.2.0, and it failed to include the version in the payload when creating the API Product. The JMeter script was fixed with [1], and this error has not been observed in migrations from 4.3.0 to 4.4.0 following the fix.
[1] - https://github.com/wso2-enterprise/apim-migration-resources/pull/487
Thank you
Avishka

Update
The automation scripts used for APIM 4.3.0 release migration testing were used to check the migration automation. Only 7 test cases were configured to run. No issues were encountered.
The migration DB scripts were changed to accommodate the new DB script changes done against the latest APIM 4.4.0-SNAPSHOT pack. The PR is https://github.com/wso2-enterprise/migration-docs/pull/269
The data populator scripts for APIM 4.2.0 and APIM 4.3.0 were modified to correct a behaviour with https://github.com/wso2-enterprise/apim-migration-resources/pull/488
Thanks,
Tharika.

Closing the issue as the required tasks are done.


fix dynamic properties on php 8.2+

PHP 8.2+ has deprecated dynamic properties. This PR addresses the issue by using the extensionData['dynamicProperties'] array for the dynamic properties.

Still need to add the unit tests, but looks like this is working beautifully.

@bennothommo any idea where the errors in Code Analysis come from ?

Nope - try merging in the develop branch maybe?

It already is.

Is there anything left on this @mjauvin @bennothommo or is it ready for review?

It's ready for review

@bennothommo @LukeTowers do you know if this line here necessarily refers to a real class property or if it could be a dynamic property?
https://github.com/wintercms/storm/blob/develop/src/Extension/ExtendableTrait.php#L383

@mjauvin that's looking for a real property on the actual extension class (ie. the behaviour). It allows the public properties of the behaviour to be included in the extended class (like what would happen with a trait).

@mjauvin that's looking for a real property on the actual extension class (ie. the behaviour). It allows the public properties of the behaviour to be included in the extended class (like what would happen with a trait).

Ok, so I don't need to convert this to use $extensionObject->propertyExists() to also account for dynamic properties that would have been added to the behavior since currently behaviors are not extendable.
Thanks for confirming this.


Fix pubKeyHash...Address

The staking credential component of pubKeyHashBaseAddress appears to be incorrect. For example, getWalletAddress and payPubKeyHashBaseAddress networkId <$> ownPaymentPubKeyHash don't match

The difference is because paymentCred and delegationCred are constructed from the same StakeCredential  in pubKeyAddress. This stake credential is in turn received from addressPaymentCred which calls payment_cred() on given a BaseAddress constructed from Address.
So I guess pubKeyAddress should just be fixed, everything depending on it should pass two arguments for two types of credentials.


Upsert always inserts model with default value

Hi,
I have next model:
@Entity
public abstract class AbstractModule implements Parcelable{
    @Key
    Long mId;

    @Column(value = "0")
    boolean mAllowCreateEntity;
}

Then I make upsert this model (in version 1.4.0)
Module model = new Module();
model.setAllowCreateEntity(true);
store.upsert(model)

Table column "mAllowCreateEntity" always saves with default value (false).

What about this bug? I have such problem in version 1.5.1. When it will be fixed?


Avoid ClassCastException in OneTimeTokenAccount

The CompareToBuilder cannot compare ArrayLists since they do not implement the Comparable interface. Executing this method causes an immediate ClassCastException in CompareToBuilder.append.
If you know a better way to fix this problem, you are welcome to abandon my proposal! ;)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much.
Please:

Fix build failures
Write test cases that show before/after scenarios.
Post the same patch to the master branch when you're ready.

I see you're a first-time contributor. If you need help with any of the above, please post back.

Thanks for your feedback. The build failure should be fixed. I am wondering what test cases you would like to see. I assume you are refering to Unit Tests. I saw your commit of OneTimeTokenAccountTests in the master. Those should be just what is needed. Do you still need more test cases?
(Or did you mean a textual description of the actual and the expected behavior?)

I assume you are refering to Unit Tests. I saw your commit of OneTimeTokenAccountTests in the master. Those should be just what is needed. Do you still need more test cases?

Correct. I think that test is a good starting point, too. If you could backport it to your branch and continue on the build, we should be good to go here.
Thanks again.

Hi there. Have you been able to make progress here? Need help?

Hi. I have backported your Testcase to my patch-1 branch. I hope copying it was the right way to do it! I'm not too familiar with github.
I couldn't find any TestSuite to add the testcase, like you did in the master. I hope the tests are collected automatically... :-)
Do you need anything else?

Thank you very much for the contribution. Keep 'em coming!


Ocean Strategy (to fix mining/resource collection in oceans)

Bug Description
We need an ocean strategy setting for dealing with oceans. They can be ignored and treated just like anything else, but you can also blacklist ore/mining resources that are below an ocean.

Handled to an extent, there's an ignore oceans setting.


Provide more information about failures in the report console output

Would be great if browser output would be in the report as well, could be a seperate file?
II could have used that yesterday. :)

The browser console.log is actually saved in a csv file inside the folder associated to the test execution

@ArnaudBuchholz We also would like to see more information about failures in the report console output. Would be great if you could improve this.

@marianfoo depending on the browser command, the console output is extracted inside a folder associated to the page execution. I modified the text output to provide the folder name (since it is a hash, it is difficult to guess).
For instance :
[https://ui5.sap.com/test-resources/sap/m/demokit/teamCalendar/webapp/test/integration/opaTests.qunit.html                                                   ]
Page execution folder name : JjE$q8NMfno
Team Calendar ▶ Should see the Planning Calendar initially set
The Planning Calendar rows are not equal to the team members
Opa timeout after 15 seconds
This is what Opa logged:
Found 0 blocking out of 159 tracked timeouts -  sap.ui.test.autowaiter._timeoutWaiter#hasPending


Saka Key violates the Brave Web Store policy

Navigating to brave://extensions shows a message under the Saka Key item: "This extension violates the Brave Web Store policy."
Please see image below:

Unfortunately, same on Chrome!

Thanks for the report, please see https://github.com/lusakasa/saka-key/issues/331 I believe these are related.


CameraInstance is not open

Description of the problem:
3.5.0
Moto G (5) Plus Android 7.0
Does the same happen on other devices or an emulator? Several devices.
Can you reproduce the issue in the sample project included with the library? If not, can you
provide your own sample project or sample code that produces this error? No - can't reproduce.
In the case of an error do you have a stack trace or adb logs?
com.journeyapps.barcodescanner.camera.CameraInstance.validateOpen (CameraInstance.java:181)
com.journeyapps.barcodescanner.camera.CameraInstance.requestPreview (CameraInstance.java:169)
com.journeyapps.barcodescanner.DecoderThread.requestNextPreview (DecoderThread.java:129)
com.journeyapps.barcodescanner.DecoderThread.decode (DecoderThread.java:173)
com.journeyapps.barcodescanner.DecoderThread.access$000 (DecoderThread.java:22)
com.journeyapps.barcodescanner.DecoderThread$1.handleMessage (DecoderThread.java:38)

I had the same problem. I dont have the fix for it right now. When I faced this issue, I thought why not open the existing camera app provided by the manufacturer, when I opened that app, it presented me a dialog that camera is not available and ask me to reboot the device. Now the camera app is working but my app with this library is not.

Duplicate of #272.


Added @BecomingDataSci on tweeps to follow section

Forget it! I now see that it was already there... doh!


chore: add changesets config and setup

Resolves: https://github.com/Shopify/core-issues/issues/40727
🍐 with @jakemoves, add Changesets to manage generating changelogs and versioning in discount-app-components. We followed the steps outlined in this document. This PR, should help improve step 1. And a follow up pr will be created to automate this flow.
This PR includes:

Changeset installation and config

To create a new changeset:
npx changeset

This allows you to lump a few commits together, e.g. a small feature or change.
To create a new version:
npx changeset version

Lump all changesets and cut a new version.
Next steps

Automate this process with a GH action: https://github.com/Shopify/polaris/blob/main/.github/workflows/changelog.yml

https://github.com/Shopify/core-issues/issues/40727


Cannot read property 'Plugins' of undefined in magento

Hello, i'm experiencing this error when i try this in magento, what could be the cause of this problem? thank you very much

Fix this issue by updating my jquery to 2.1.4


improveimprove is_ip_address_in_range for inverted ind…

…ex speed (#41768)
Proposed changes
speed up is_ip_address_in_range with inverted index
Proposed changes
Issue Number: close #xxx

run buildall

run p0

run cloud_p0

run p0


add meshsync version at buildtime

Signed-off-by: Rudraksh Pareek<EMAIL_ADDRESS>Description
This PR fixes #86
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Yay! 🎈

Is v0.1.15 hadrdcoded somewhere? Or is that value coming from Meshery Operator?

Wow. Abishek really took some shortcuts.


Remove short confused smiley from replace list

The short confused smiley :/ interferred with pasing links in HexChat. This commit removes this smiley from the list.
Fixes https://github.com/alexandrevicenzi/hexchat-emoji/issues/2

I think that the proper fix would be the regex expression, some sort of exact match.

That would be indeed the better solution but requires some more effort. For me this one works fine, but feel free to overwrite my proposal with a proper fix for the issue :slightly_smiling_face: :+1:

As this is not a lib, just a file that you copy to addons folder, I think you can fix it the way you need it locally.
I'll look up a better solution, otherwise, I may merge this one.

Thanks for taking care!


Can't login into forum

I can't log in into the OrientDB Community anymore since some days ago. I can't log in with a password because I don't have one, I always logged in using my GitHub account but now the result is an error page with the following message:
Oops

The software powering this discussion forum encountered an unexpected problem. We apologize for the inconvenience.

Detailed information about the error was logged, and an automatic notification generated. We'll take a look at it.

No further action is necessary. However, if the error condition persists, you can provide additional detail, including steps to reproduce the error, by posting a discussion topic in the site's feedback category.

Trying the "with email" option, it says that my account was found and "should receive an email with a login link shortly", but the email is never received.

It seems that now the login is working again.

Hi @johny65
Sorry for this inconvenience and yes, we just fixed it
Thanks
Luigi


Add curve secp256K1

Add new curve secp256K1, and update the documentation
Checklist

[X] App update process has been followed
[X] Target branch is develop
[X] Application version has been bumped

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.27%. Comparing base (d080e4f) to head (9f91786).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #99   +/-   ##
========================================
  Coverage    27.27%   27.27%
========================================
  Files            1        1
  Lines          209      209
========================================
  Hits            57       57
  Misses         152      152

Flag
Coverage Δ

unittests
27.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug] Cannot run validator locally due to missing directory

🐛 Bug
I have been trying unsuccessfully to run validator nodes locally on Ubuntu 18.04 with docker by running the docker/validator/run.sh command but it fails because the script refers to a directory which does not exist(/../../terraform/validator-sets/dev/). This directory was removed in commit acc5798084cd961ef7ead3abca5d8e24bccd1a80 back in August 2019. I reverted to that commit and even previous commits but the build failed due to compatibility issues(for example with rust). So I am wondering how everyone else is able to run validator nodes locally without encountering this issue? Please let me know if I am missing something.
To reproduce
I did the following:

Download and install Docker.
From the top level directory, run docker/validator/build.sh
From the top level directory, run docker/mint/build.sh
To test the validator image locally, run docker/validator/run.sh
This is where it fails.

Stack trace/error message
$ ./docker/validator/run.sh
+ IMAGE=libra_e2e:latest
+ dirname ./docker/validator/run.sh
+ CONFIGDIR=./docker/validator/../../terraform/validator-sets/dev/
+ sed s,SEED_IP,<IP_ADDRESS>, ./docker/validator/../../terraform/validator-sets/dev//seed_peers.config.toml
sed: can't read ./docker/validator/../../terraform/validator-sets/dev//seed_peers.config.toml: No such file or directory
+ SEED_PEERS=

Expected Behavior
Docker container running the validator node image started
System information
Please complete the following information:

Libra Version: latest from master branch
Rust Version: 1.39.0
Computer OS: Ubuntu 18.04.3 LTS

We should delete the run.sh from docker/validator. Instead, continue the process by building the docker/validator-dynamic and using the run script within there.

Thanks for your reply @davidiw , I appreciate. I was able to build and run the validator nodes using the validator-dynamic scripts. I am also able to build the mint image but I cannot run it with
docker/mint/run.sh because of the same issue, the directory libra/terraform/validator-sets/dev/ does not exist. consequently I cannot add coins to the accounts which I created... could you please suggest an alternative to this? Is there a way to run the mint container differently?

@princeulrich2 did you find a solution for this?
Btw @davidiw  in validator-dynamic there are some seems unused scripts (build.sh)
when I try to run docker-run-dynamic I get:

declare -a params
'[' -n '' ']'
'[' -n '' ']'
'[' -n '' ']'
'[' -n '' ']'
'[' -n '' ']'
'[' -n '' ']'
'[' -n '' ']'
'[' -n '' ']'
/opt/libra/bin/config-builder validator --data-dir /opt/libra/data/common --output-dir /opt/libra/etc/
docker/validator-dynamic/docker-run-dynamic.sh: line 33: /opt/libra/bin/config-builder: No such file or directory

Thanks for your reply @davidiw , I appreciate. I was able to build and run the validator nodes using the validator-dynamic scripts. I am also able to build the mint image but I cannot run it with
docker/mint/run.sh because of the same issue, the directory libra/terraform/validator-sets/dev/ does not exist. consequently I cannot add coins to the accounts which I created... could you please suggest an alternative to this? Is there a way to run the mint container differently?

This is unfortunate, let me flag a couple people and see if we cannot fix this... but the short stick of it is that this should likely be using config-builder too, I am confused as to why it is not.

@milonite, this seems unrelated to the issue above and I should have probably closed it and asked @princeulrich2 to open a new issue.
Could you open a new issue, feel free to assign to me, detailing how you built your docker container? Because I don't see any reason for your error otherwise.

@milonite yes I was able to run the validator nodes using the validator dynamic scripts:
docker/validator/build.sh
docker/validator-dynamic/build-dynamic.sh
@davidiw indeed I will close this bug

@princeulrich2  Thanks, may I ask you to post the output of docker/validator/build.sh and how do you connect the cli to it?  eg.cargo run --bin cli -- -u http://localhost:6180


Version Bump

I've seen changes and a version bump to 0.26.0 but I haven't yet seen the release public. Was this intentional? I was hoping to get a couple of those changes.

Will be dropping soon.

Awesome, Thanks

0.26.1 is now up on pypi. Thanks for the nudge and changes that made it into this version.


🐛 BUG: Uncaught Error: Dynamic require of "node:crypto" is not supported

Which Cloudflare product(s) does this pertain to?
Workers Runtime, Wrangler core
What version(s) of the tool(s) are you using?
<EMAIL_ADDRESS>What version of Node are you using?
v20.2.0
What operating system are you using?
Linux
Describe the Bug
Some time ago, I wrote a Cloudflare worker. Today, I added one small change to it. However, I wasn't able to deploy it because wrangler-cli showed me a message that it is too old and refused to work. After upgrading and spending a couple of hours trying to figure out how I could deploy previously working code with the new tool, I gave up.
Basically, this is my .js file, which I can't deploy:
const crypto = require('crypto');

addEventListener('fetch', async function (event) {
    event.respondWith(main(event.request, event).catch(function (error) {
        const m = crypto_encrypt_aes256('SECRET', JSON.stringify({...error, message: error.message, stack: error.stack}, null, 4));
        return new Response(`Failed\n\n${m.toString('base64')}\n`, {status: 400, 'Content-Type': 'text/plain'});
    }));
});

async function main(request, event)
{
    [...]
}

function crypto_encrypt_aes256(password, data)
{
    const iv = crypto.randomBytes(16);
    const key = crypto.createHash('sha256').update(password).digest();
    const cipher = crypto.createCipheriv('aes-256-ctr', key, iv);
    if (iv.length > 255) {
        throw new Error('iv size is too big');
    }
    return Buffer.concat([Buffer.from([iv.length]), iv, cipher.update(data), cipher.final()]);
}

With the old wrangler-cli I used webpack. How could I do it with the new version of wrangler?
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
 ⛅ wrangler 3.22.3
-------------------
Your worker has access to the following bindings:
- Vars:
  - xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
Total Upload: 3.72 KiB / gzip: 1.46 KiB

✘ [ERROR] A request to the Cloudflare API (/accounts/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/workers/scripts/xxxxxxxxxxxxxxxxx) failed.

  Uncaught Error: Dynamic require of "node:crypto" is not supported
    at null.<anonymous> (worker.js:7:11)
    at null.<anonymous>
  (file:///xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/src/index.js:1:16)
    at null.<anonymous> (worker.js:78:3)
   [code: 10021]

  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

It looks like you're trying to use Node's crypto module, which isn't supported by default in the Workers runtime. The best path forward will be to enable Node.js compatibility mode by adding this snippet to your wrangler.toml:
compatibility_flags = [ "nodejs_compat" ]

and modifying your import to be require("node:crypto") instead of require("crypto").

I did all of this. The message I got I put into title.
The solution, which worked for me, is custom build:
wrangler.toml
name = "xxxxxxxxxxx"
main = "build/index.js"
compatibility_date = "2022-07-12"

account_id = "xxxxxxxxxxxxxxx"
workers_dev = true

[build]
command = "npm run build"
# cwd = "build"
# watch_dir = "build"

[vars]
XXXXXXXX = "YYYYYYYYYY"

webpack.config.js
const path = require('path');
const pkg = require('./package.json');
const webpack = require('webpack');

const config = {
    mode: 'production',
    target: 'webworker',
    entry: './src/index.js',
    output: {
        path: path.resolve(__dirname, 'build'),
        filename: 'index.js',
    },
    plugins: [
        new webpack.ProvidePlugin({
            Buffer: ['buffer', 'Buffer'],
        }),
        new webpack.DefinePlugin({
            __NAME__: JSON.stringify(pkg.name),
            __VERSION__: JSON.stringify(pkg.version),
            __COMPILED_AT__: JSON.stringify(new Date()),
        })
    ],
    resolve: {
        fallback: {
            buffer: require.resolve('buffer'),
            crypto: require.resolve('crypto-browserify'),
            stream: require.resolve('stream-browserify'),
        },
    },
    performance: {
        hints: false,
    },
};

module.exports = config;

package.json
{
  "name": "xxxxxxxxxxxxxxx",
  "version": "0.0.0",
  "scripts": {
    "build": "webpack",
    "watch": "wrangler --config=wrangler.dev.toml dev",
    "deploy-dev": "wrangler --config=wrangler.dev.toml deploy",
    "deploy-prod": "wrangler --config=wrangler.prod.toml deploy"
  },
  "devDependencies": {
    "buffer": "^6.0.3",
    "buffer-browserify": "^0.2.5",
    "crypto-browserify": "^3.12.0",
    "stream-browserify": "^3.0.0",
    "webpack": "^5.89.0",
    "webpack-cli": "^5.1.4",
    "wrangler": "^3.22.3"
  }
}

For others experiencing a similar error message, make sure your using 'import' instead of 'require'. Unfortunately many npm packages still use the 'require' format.

I'm experiencing this as well but the require statement is in the remix package so I am not able to change that. Any suggestions?
Specifically<EMAIL_ADDRESS>on remix v2.7.2

I'm facing the same issue. I've added compatibility_flags = [ "nodejs_compat" ] to wrangler.toml, following the instructions on https://developers.cloudflare.com/workers/runtime-apis/nodejs with import { Crypto } from 'node:crypto'; and I get exactly that error as well locally. So either something's still not supported here or the docs are wrong - or I don't get it.

Trying to deploy a remix-run app to cloudflare with @remix-run/cloudflare also brought me to this thread

Hit this issue today. I'm guessing the exact reason has to do with the file to bundle.

For me this happened with a ESM file containing require('crypto').
Wrangler (and maybe esbuild in it) emits this which apparently fails without a real require in runtime:
var __require = /* @__PURE__ */ ((x) => typeof require !== "undefined" ? require : typeof Proxy !== "undefined" ? new Proxy(x, {
  get: (a, b) => (typeof require !== "undefined" ? require : a)[b]
}) : x)(function(x) {
  if (typeof require !== "undefined")
    return require.apply(this, arguments);
  throw new Error('Dynamic require of "' + x + '" is not supported');
});

...

var crypto = __require2("crypto"); // FAIL

If the input file contains import 'crypto' instead, wrangler emits fine code that imports from polyfilled crypto.
IMO wrangler could do better to either support this imperfect input (this is not rare, not every npm packages ships perfect ESM). At least the error message could be improved.

@jokester what error do you see when you use Wrangler v3.80.0 (https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%403.80.0)
See: https://github.com/cloudflare/workers-sdk/pull/6872

@irvinebroque Thanks. I tested with wrangler 3.80.0 and realized my previous report could be invalid (the input to wrangler was already a dynamic require).
Wrangler 3.80.0 has no problem recognizing non-dynamic requires like require('node:crypto') , and provide them with polyfills.


Add a Github action for running code linters

The code was currently not passing npm run lint, so I added some lint rule suppressions to the markdown lint. Long-term, we can remove them and make the linters more strict, but I figured that it's better to have the linters start with a basic set of rules to enforce and then tighten them up in subsequent PRs.

Thanks, @mtlynch. I originally turned off the linters because they seemed too strict but relaxing the rules is probably a better idea.


Is It Possible to provide service video chat one to one using API in Mobile

Dear Team,
Any try to implement easeRTC from mobile and access private room using API?
Private room is one to one video call, so i only access specific room id from mobile
If any one proven the wat please let me know,
Regards

@adesurya you can join room
`
//Join room
easyrtc.joinRoom(roomid, null, function (a, b, c) {
////console.log("join room ", a, b, c)
}, function (a, b, c) {
    //console.log("Join room Error", a, b, c)
});

//Watch room accupants
easyrtc.setRoomOccupantListener(watchRoom);`
thats all

Thank you @rtarta


Update Set-MigrationBatch.md

Finished making StartAfter cloud-only per  #4949

Docs Build status updates of commit ef33529:
:clock10: Full build: the average full build time is 13 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit ef33529:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/move-and-migration/Set-MigrationBatch.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4acb9de:
:clock10: Full build: the average full build time is 13 min(s) 54 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 4acb9de:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/move-and-migration/Set-MigrationBatch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance-content-search/New-ComplianceSearchAction.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ab98a0d:
:clock10: Full build: the average full build time is 14 min(s) 1 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit ab98a0d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/move-and-migration/Set-MigrationBatch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance-content-search/New-ComplianceSearchAction.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Extract validation error detail

Various changes to obtain information about the context of error so that more detail than "this is valid" or "this is not valid" can be provided.

Merging into validate-data-based so that the diff is more manageable.
This is because validate-data-based is a PR going into dev, which also has the large number of XML files in it. Merging is easier than trying to merge the other way due to merge conflicts. Ideally dev should have been merged through a different series of branches, but oh well...


Add utility functions to read truth files, compute AUPR

We will also need a strategy for combining read counts from nr and nt for the purpose of abundance estimate reporting (so far in this PR I have only used nt counts). @katrinakalantar could you advise on the best way to do this?

Good question. Here are a few general thoughts on this. I can see a few ways of doing this, each with pros/cons...

Compute metrics for NT and NR separately - given that algorithmic changes specific to the alignment databases will only affect single metrics, there may be utility to track the metrics separately. Of course, this doesn't reflect the value of combining the metrics.
Apply a minimal threshold filter to require concordance on NT and NR (specifically, require NT > 0 and NR > 0 for any particular taxa). Then, use the NT counts. This is an approach that many users take when actually interpreting the data in the IDseq reports to improve specificity. However, it does not enable detection of divergent taxa where counts on NR alone may be of interest. It also does not reflect "raw results".
Apply the algorithm for combining NT/NR that was implemented here: https://github.com/chanzuckerberg/idseq-workflows/pull/51. This is the most rigorous method of combining NT and NR because it gives one taxID to each read. However, it is under active refinement to improve performance for a small number of divergent viral edge cases and is not currently used for presentation of production results.

Another more naive approach that I'm not certain about would be to sum together the NT and NR counts - unfortunately this means that single reads would potentially be counted twice. This does allow you to inherit the sensitivity from each, but will take a hit on perceived specificity.

Built on this in #83


calculate min max date feature also nowIndicator

@comeonlnw Thank you, can you use our prettier setting? The code changes too much.
Also, will this PR close this? https://github.com/acro5piano/react-native-big-calendar/issues/1053

@comeonlnw Thank you, can you use our prettier setting? The code changes too much.
Also, will this PR close this? #1053

I'm not sute about I Phone 15 Pro Max But I have tested  in my android Phone and IPhone 15 it work totally fine.

@comeonlnw Thank you for your contribution!!


error on install

after using yarn add -D shellcheck i get the following error:
[5/5] 🔨  Building fresh packages...
[10/16] ⠈ husky
[7/16] ⠈ ursa-optional
[11/16] ⠈ ejs
[4/16] ⠈ fsevents
error /Users/b0m01v7/Code/glass/walmart/node_modules/shellcheck: Command failed.
Exit code: 1
Command: ./install.sh
Arguments:

Hey Ben,
I couldn't reproduce. Can you please try it on an empty repository? I would love to hear about it. There might be something we can do to prevent this problem from happening to other people too.
Cheers,
Gunar

yeah on an empty repository it seems to work.  Sorry I can't provide any more info @gunar, we found another solution using hadolint.
Cheers
Ben

Good to know! Thanks for circling back. Today I learned about hadolint. Glad your problem is solved.
Cheers,
Gunar

Sorry I couldn't be more help. 😔


Made bounds control more overridable

Made four functions in boundscontrol.cs protected virtual.
This is necessary for adding custom translation, rotation and scaling logic for bound controls behavior.

/azp run

@HossamBasion, please re-target your pull request to target the main branch

@shaynie Sounds good.

Recreating and retargetting to latest main branch


System Statistics

"System Statistics" link appears in the left panel of "Virtualmin" when using GPL version. Clicking presents the error screen on the right "You are not allowed to view historic system statistics".
This bug is NOT present when clicking the "Webmin" tab.

Will be fixed on the next Virtualmin release.


problems with SSR if(!window.ace) not work

Can't start SSR with Ace editor on Angular 6. I'm afraid that there I need some wrapper for SSR, but in Ace lib which used by AceEditorModule already exist some conditions for existing the window.ace or not, but it not work properly.

"ng2-ace-editor": "^0.3.8"
Angular 6.0.7

any ideas how to fix this?
npm run start:ssr

><EMAIL_ADDRESS>start:ssr I:\FRONTEND\Projects\Github\my-project - UNEXPECTED ERRORS
> node dist/server.js

I:\FRONTEND\Projects\Github\my-project - UNEXPECTED ERRORS\dist\server.js:254298
                    if (!window.ace)
                    ^

ReferenceError: window is not defined
    at I:\FRONTEND\Projects\Github\my-project - UNEXPECTED ERRORS\dist\server.js:254298:21
    at _acequire (I:\FRONTEND\Projects\Github\my-project - UNEXPECTED ERRORS\dist\server.js:235317:37)
    at Object.acequire (I:\FRONTEND\Projects\Github\my-project - UNEXPECTED ERRORS\dist\server.js:235322:26)

IIFE which produce this error and try to handle window object with ace lib inside: node_modules/ace-builds/src/ace.js
(function() {
  window.require(["ace/ace"], function(a) {
    if (a) {
      a.config.init(true);
      a.define = window.define;
    }
    if (!window.ace)
      window.ace = a;
      for (var key in a) if (a.hasOwnProperty(key))
        window.ace[key] = a[key];
        window.ace["default"] = window.ace;
        if (typeof module == "object" && typeof exports == "object" && module){
          module.exports = window.ace;
        }
     });
})();

also npm package use brace as dependency, and in it also we see this code, but its different a little bit. And I don't know how to check which of lib's code produce this error.
node_modules/brace/index.js:
(function() {
                ace.acequire(["ace/ace"], function(a) {
                    if (a) {
                        a.config.init(true);
                        a.define = ace.define;
                    }
                    if (!window.ace)
                        window.ace = a;
                    for (var key in a) if (a.hasOwnProperty(key))
                        window.ace[key] = a[key];
                });
            })();

We create a fork of ng2-ace-editor where we prevent to this problem, you can use it:
https://www.npmjs.com/package/@supermemo/ng2-ace-editor


RegistryMock is not abstract and does not override abstract method getOrThrow(NamespacedKey) in Registry

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest version of MockBukkit?

[X] I am using the latest version of MockBukkit.

Minecraft Version
1.21
Describe the bug
When attempting to build the latest version of MockBukkit at the time of writing, I get a build error:
RegistryMock.java:42: error: RegistryMock is not abstract and does not override abstract method getOrThrow(NamespacedKey) in Registry
public class RegistryMock<T extends Keyed> implements Registry<T>
       ^
  where T is a type-variable:
    T extends Keyed declared in class RegistryMock
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files additionally use or override a deprecated API that is marked for removal.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
100 warnings

(I'm also getting 100 deprecation warnings, but that's another problem)
Things that were working a few hours ago, stopped working due to this error.
Reproducible Test
Simply checkout the latest version of the branch and run the ./gradlew clean build task to see this happen.
Anything else?
I'm not experienced enough with how Bukkit makes releases to know whether this is a Bukkit issue or a MockBukkit issue. Either way, MockBukkit simply isn't overriding the appropriate methods anymore.

This is an issue from mockbukkit: we need to constantly be on par with the paper api, which will change in the same release.
We are currently preparing for a new major release, the patch has already been done in that branch. It might still take some days until this is released (no ETA), I therefore recommend explicitly defining exactly the api version that works with mockbukkit

@Thorinwasher this makes sense, and it's what I suspected. I need advice though, I can't figure out how to specify an earlier API version. Every tutorial I find just says to use R0.1-SNAPSHOT, which downloads the latest one.

There's an extra tag you need to use I don't remember exactly what it is. I recommend going to our discord and asking this if you want a quick response

#1171 fixed this


Provide ability to configure the ACA resource properties through C# code

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
Currently, we can configure the Azure resources properties through Aspire.Hosting.Azure.{*ResourceType}. They are generated as *.module.bicep.
What about the built-in resources for azd deployment, including ContainerAppEnvironment, ContainerRegistry, LogAnalyticsWorkspace and so on? They are basically defined in resources.bicep.
In addition, what about the configuration for each container app service, such as the scale rule and custom domain? They are defined in *.tmpl.yaml.
Describe the solution you'd like
Provide ability to configure auto-generated resources and container app properties through C# code.
Additional context
No response

I was able to configure that manually after editing files generated by infra synth, but as you've mentioned on discord channel, it's far from optimal since it's getting overwritten on every infra synth generation.
It would be nice to have an option to configure those services for dev/prod scenarios where control over provisioned resources is necessary.

You can read the details here https://github.com/Azure/azure-dev/issues/3292

@davidfowl I took a quick look at your pull request, it only focuses on the container app. What about the ResourceGroup, ContainerAppEnvironment,  ContainerRegistry,  LogAnalyticsWorkspace,  and ManagedIdentity?

We’re scoping the feature to just the container app for aspire 9. The idea is to design the feature in such a way that we can gradually remove more bicep generation from azd. That will take several releases to get right


Read up on GRIP and computer vision

http://wpilib.screenstepslive.com/s/4485/m/24194/l/463566-introduction-to-grip
https://github.com/WPIRoboticsProjects/GRIP/wiki
http://wpilib.screenstepslive.com/s/4485/m/24194/l/682949-vision-processing-on-an-arm-coprocessor

https://github.com/robovikings2607/FRC2016-VisionTracking

Aggregated a bunch of links on the wiki : https://github.com/frc4571/FRC2017Robot/wiki/Computer-Vision


atom feed?

Is there a way to generate an atom feed for blog posts with the hugo academic theme? Thanks.

Academic uses RSS by Hugo. See https://gohugo.io/templates/rss/


Patch export of link dependencies

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

ELSI is reexporting symbols from ELPA and maybe other (https://gitlab.com/elsi_project/elsi_interface/-/issues/57)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Ignore Forbidden Markings also ignores zone restrictions

Rimworld: 1.4.3901 rev238 (+ Royalty, Ideology, Biotech)
Harmony: Lib <IP_ADDRESS> / Mod <IP_ADDRESS>
Achtung: 3.8.7
AlllYourBase.
No other mods.
Steps To Reproduce

Enable option "Ignore Forbidden Markings", ensuring "Ignore Zone Restrictions" is disabled.
Start new game / Dev quicktest.
Create small stockpile zone to ensure hauling is possible.
Create zone that excludes one or more forbidden item stacks.
Assign test colonist to zone from step 4.
Select the test colonist and right-click a forbidden item stack that is inside the permitted zone for the colonist.
Select the test colonist and right-click a forbidden item stack that is outside the permitted zone for the colonist.

Expected Behaviour

Right-click menu for the item stack inside the permitted zone displays as normal and permits issuing of 'prioritize...' instructions.
Right-click menu for the item stack outside the permitted zone displays "outside permitted area", as per vanilla behaviour.

Actual Behaviour

:heavy_check_mark: Right-click menu for the item stack inside the permitted zone displays as normal and permits issuing of 'prioritize...' instructions.
:x: Right-click menu for the item stack outside the permitted zone displays as normal and permits issuing of 'prioritize...' instructions.

Debug Log
Command line arguments: -popupwindow
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Message (string)
Verse.Root:CheckGlobalInit ()
Verse.Root:Start ()
Verse.Root_Entry:Start ()
RimWorld 1.4.3901 rev238
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Message (string)
RimWorld.VersionControl:LogVersionNumber ()
Verse.Root:CheckGlobalInit ()
Verse.Root:Start ()
Verse.Root_Entry:Start ()
Achtung v<IP_ADDRESS> Info: To make Achtung log some performance info, create an empty 'AchtungPerformance.txt' file in same directory as Player.log
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Message (string)
AchtungMod.World_FinalizeInit_Patch:Prefix ()
(wrapper dynamic-method) RimWorld.Planet.World:RimWorld.Planet.World.FinalizeInit_Patch1 (RimWorld.Planet.World)
RimWorld.Planet.WorldGenerator:GenerateWorld (single,string,RimWorld.Planet.OverallRainfall,RimWorld.Planet.OverallTemperature,RimWorld.Planet.OverallPopulation,System.Collections.Generic.List`1<RimWorld.FactionDef>,single)
Verse.Root_Play:SetupForQuickTestPlay ()
RimWorld.MainMenuDrawer/<>c:b__18_13 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:b__27_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()
Initializing new game with mods:

brrainz.harmony
Ludeon.RimWorld
Ludeon.RimWorld.Royalty
Ludeon.RimWorld.Ideology
Ludeon.RimWorld.Biotech
brrainz.achtung
Mehni.AllYourBase
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Message (string)
Verse.Game:InitNewGame ()
Verse.Root_Play/<>c:b__1_2 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:b__27_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

Expected behaviour. The settings should be seen as THIS or THIS or THIS. Which means as soon as at least one of the condition is true (outside of allowed zone, forbidden) and you issue a command on it, you can do it. This avoids confusion as at least one condition is met and users often do not realize that the complex combinations hinder them from doing things.
In the end its more of a convenience. You can allow things that other would not be possible and the final decision is up to the user issuing the command.

PS: I will not remodel the code to follow the complex combinations of settings as it is already a pain to offer this functionailty while at the same time be efficient with it and patching the different areas of game code that are spread all over the place. There is no simple method that contains the logic in one place.

OK, that makes sense then. Just a miscommunication/misunderstanding due to how other mods often handle things. I'm certainly not going to demand you change things, I simply raised the issue due to it not working how I understood it should. Since that understanding was actually in error, there is no issue. :)


nuget: Local feed for debugging

Now that we're working on sister projects in addition to neonKUBE, we really need a way to be able to work on new Neon features required by sister projects without needing to publish Neon packages to the public feed more often than we'd like.  I've been finding myself incubating entirely new libraries and code in the sister project (which will be OK for a while) and then integrating these changes back into neonKUBE and then needing to publish packages publicly so the sister project can get the changes.
We've had the neon-nuget-local.ps script that publishes packages to a local filesystem feed but we haven't use this because it requires the package versions to be incremented in some way so that solutions will see the updates.  The problem is that there's no nice way to increment the package versions,  Here are the problems:

Individual developers working in parallel will also need to increment these the version in parallel.  The current publishing mechanisms required a version file to be incremented and will update the .csproj files for the libraries with the new version.  We don't want to do this because .csproj files are tracked by git and this will result in annoying merge conflicts.

I was originally thinking that we'd use a special preview string like **a-####for this, where we'd increment the build version immediately **_after_** publishing packages publicly (we currently increment this just **_before_** publishing), and then incrementing the####` part for each local feed release.  I don't like this because it's just too easy to publicly publish packages by accident this way (has happened in the past).  The nice thing about the current scheme is that nuget won't allow to to republish packages with versions that have already been published.
Doing this also runs in to the problems identified in point 1 above.

The neon-nuget-local.ps script currently publishes packages to %NF_BUILD%\nuget.  This isn't a great place for a couple reasons: 1: the build folder gets wiped during full builds (by script) and 2: this implies that there will eventually be multiple local nuget feeds which will be a pain to manage.

I believe the best solution is to add a nuget-purge command to neon-build that clears specific packages from the package cache in a solution as well as from the machine/user cache at %USERPROFILE%.nuget\packages.  I'll describe how we'll use this further below.
To address point 3, I'm going to modify the buildenv.cmd script to create a common local feed directory at C:\NugetFeed and point %NUGET_FEED% at it and then modify the neon-nuget-local.ps script to publish packages there.
I'll also modify neon-nuget-local.ps script to check for the presence of a C:\NugetFeed\onpublish.ps1 script that will be called for each package version being published.  The idea here is that individual developers will add a script that uses the new neon-build command to remove published packages from the machine/user cache as well as the caches for the solutions the developer is working on.  I'll modify the buildenv.cmd to create a default script file, if one doesn't already exist.
DEVELOPER WORKFLOW
So here's how this will work.  Let's assume that a neonKUBE developer is working on two sister solutions, one at C:\Solution1\solution1.sln and the other at C:\Solution2\solution2.sln.
Prerequisites

The developer has modified the C:\NugetFeed\onpublish.ps1 by adding the paths to the other two active solutions:

[CmdletBinding()]
param (
    [Parameter(Position=0, Mandatory=1)]
    [string]$packageName,
    [Parameter(Position=1, Mandatory=1)]
    [string]$packageVersion
)
neon-build nuget-purge $packageName $packageVersion "C:\Solution1" "C:\Solution2"

The developer has configured the local nuget feed to appear before the public feed in Visual Studio.

Update workflow

The developer has made some changes to neonKUBE that need to be tested in these solutions.

The developer executes neon-nuget-local.cmd which publishes the Neon packages to the local feed directory and then calls  C:\NugetFeed\onpublish.ps1 for each package published with this script removing any cached packages.

The developer will then go to each of the solutions and restore all packages (which will install the locally published packages) and do a clean rebuild.

That's all there is to it: a pretty tight inner developer loop.  Much better than the 1.5-2 hours it takes to do a public release these days and we'll also avoid confusing the community with too many releases.

NuGet feeds are not working as I expected.  Although Visual Studio looks like it allows you to order how the nuget feeds are searched, that doesn't actually work.  Apparently, it queries all feeds in parallel and retrieves packages from the feed that returns first (although you'd think that local feeds would always return first and they don't seem to).
I was hoping that by removing the locally published packages from the machine caches and having the local feed first in the list that I'd be able to republish packages locally without updating the version and that other solutions would then pick up the new package without having to upgrade packages.  This doesn't to work because VS seems to favor nuget.org over local feeds and we always get the original package,  nuget fundamentally assumes that packages are invariant after being published, so the developers say that it shouldn't matter where a package comes from since it should always be the same.
I don't think there's really a way to accomplish this cleanly with packages.  The only remaining options are:

Disable the nuget.org package feed while working in dependent solutions.

Increasing the version number for locally published packages to something like 1000.0.0-####, where #### is incremented for every time packages are published locally.  Developers will need to update packages in their solutions to pick these up.

Have the dependent solutions reference the (probably debug) builds of the Neon library assemblies directly while developing and debugging and then restoring the package referenced afterwards.

Include neonKUBE library projects in the sister solutions.  We'll need to be careful to replace these direct project references with package reference before merging into master and especially before publish the neonLIBRARY packages.  I'm not entirely convinced that this will work.

Option 2 is probably the best choice.  By auto incrementing the preview tag version, we won't be subverting the nuget package impotence requirement and the only requirement for developers will be to upgrade their solution package references to use the locally published packages and the be sure to downgrade the packages back to the release versions before merging to master or release branches.
One consequence of managing this tag version locally is that different developers will end up with different tag versions.  This means that developers won't be able to work with locally published packages on the same branch.  This sucks, but I can't think of anything better outside of maintaining our own NuGet server and managing the version number there too.
I'm going to go with Option 2 without deploying our own NuGet server at first.  I'm not entirely sure how often we'll actually be doing this anyway.  If this ends up being important, we'll just implement our own package server which will be as clean is this possible can be.

DONE


Sliced batch w/ bool column doesn't roundtrip through IPC

Describe the bug
It seems that the IPC writer doesn't correctly account for sliced boolean columns.
To Reproduce
#[test]
fn encode_bools() {
    let val_bool_field = Field::new("val", DataType::Boolean, false);

    let schema = Arc::new(Schema::new(vec![val_bool_field]));

    let bools = BooleanArray::from(vec![true, false]);

    let batch =
        RecordBatch::try_new(Arc::clone(&schema), vec![Arc::new(bools)]).unwrap();
    let batch = batch.slice(1, 1);

    let mut writer = StreamWriter::try_new(Vec::<u8>::new(), &schema).unwrap();
    writer.write(&batch).unwrap();
    writer.finish().unwrap();
    let data = writer.into_inner().unwrap();

    let mut reader = StreamReader::try_new(Cursor::new(data), None).unwrap();
    let batch2 = reader.next().unwrap().unwrap();
    assert_eq!(batch, batch2);
}

This fails with:
thread 'writer::tests::encode_bools' panicked at 'assertion failed: `(left == right)`
  left: `RecordBatch { schema: Schema { fields: [Field { name: "val", data_type: Boolean, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, columns: [BooleanArray
[
  false,
]], row_count: 1 }`,
 right: `RecordBatch { schema: Schema { fields: [Field { name: "val", data_type: Boolean, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }], metadata: {} }, columns: [BooleanArray
[
  true,
]], row_count: 1 }`', arrow-ipc/src/writer.rs:1953:9

Expected behavior
Test passes.
Additional context
Tested on commit https://github.com/apache/arrow-rs/commit/eae993fd196d0a8df8a90857bc4a7ae8f5a3e845 .
Originally observed in https://github.com/influxdata/influxdb_iox/issues/6515 . There we've also looked into the raw IPC data which lead to the conclusion that this is likely related to boolean columns (since other columns seem to work) and a writer issue (not a reader issue).

I'm working on a fix.

label_issue.py automatically added labels {'arrow'} from #3498


Release prebuilt cargo-zng to support cargo-binstall

To support cargo-binstall we need:
Match the Release name with the cargo-zng version
It is very convenient to have the cargo-zng crate in the same repo because it depends on other crates (zng-env, more in the future, .zr-render idea). These dependencies are managed by 'do publish'. If we move to a different repo will need to manually keep track of dependencies.
Lets try using the zng version for cargo-zng, but only when it needs to release. Only those releases get a prebuild too.
Prebuild in all platforms
We can just copy cargo-about workflow.

Wil not do this for now. The zr-render tools will be implemented as a separate crate too.


SAK-29801 - Remove the reference to the global bootstrap.css in resources

I would like Uday to take a look at this one.

Looks good to me.


Master issue for TAUTO-1

Security review of PDF/Image/Audio conversion techniques (actual to future) - comparing results to see what's recommended for newer version of CIRCLean

https://github.com/CIRCL/PyCIRCLean/blob/master/bin/filecheck.py#L463 - https://github.com/CIRCL/PyCIRCLean/blob/master/bin/filecheck.py#L497


Unable to Switch to TV Source

I'm not able to switch from any source to 'TV' all other sources work fine but when selecting TV the source changes for a few seconds in the UI but then goes back to whatever it was previously and the TV doesn't change.

@Saggerus can you leave your YAML configuration for your tv where you have this issue?

closing this due to inactivity, @Saggerus if you still want to address this issue, you can paste your config and reopen the issue

I have exactly the same situation, all sources works fine beside TV.
This is my configuration:
media_player:

platform: samsungtv_tizen
name: Samsung TV
host: <IP_ADDRESS>
port: 8002
mac: EDITED
api_key: EDITED
device_id: EDITED

I added next code to the end and it's working
source_list: '{"TV": "KEY_EXIT+2000+KEY_TV+KEY_EXIT"}'


Use try/except to get Gurobi iterations

Quick fix #1194 .
It looks like Gurobi does not create the attributes BarIterCount and IterCount when the problem is large.

Thanks, @bstellato! Merging in.


Bank account - Able to proceed with invalid information in company information

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login with any account
Open Settings => Workspace => Connect Bank Account => Connect Manually => Enter valid information for first 3 steps.
Press back go to step 2, now enter invalid information for phone number (or Zipcode, Tax Id ), after that press X to close.
Go back to Settings => Workspace => Connect Bank Account => Continue with setup, now you are at step 3.  Try to press Save & Continue
Notice that it still let you go to the next step.
From Scan document screen, click X  to go to previous steps, click back again to go to steps 2.
Notice that at the steps 2 it's invalid phone number.

Expected Result:
After pressing Continue with setup, it should navigate to the invalid screen information.
Actual Result:
You still can go to Scan Document Screen with invalid information.
Workaround:
Only save user information (Steps 2,3) when user press Save or we need to navigate user to the invalid information screen after press Continue with setup
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] iOS / native

Version Number: 1.2.50-2
Reproducible in staging?: y
Reproducible in production?: Could not check
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/211127819-c840bfcf-1dc3-4d29-8339-60a5a5f249f7.MP4
https://user-images.githubusercontent.com/43996225/211127844-340ccc06-c2fd-4848-a0f4-84a5e599e531.mp4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673019074038549
View all open jobs on GitHub

Will take a look at this one!

Sorry, I was OOO when this was assigned to me 😬. I'm running into the following error when trying to replicate this, are you able to replicate it @yuwenmemon or should I take it to the team to see if someone else can?

Not overdue.

As pointed out here and observed first hand, we're not actually saving the invalid information when you close out the form with it. So I guess the real issue is here that we're not calling to attention the invalid form field immediately when you press the back button? However at the end of the day that's a pretty small bug...

Curious what @marcaaron and @luacmartins since they worked on the Forms Design Doc - should we consider this a bug? That an invalid draft value is not immediately flagged as invalid?

Not overdue.

As pointed out, we just showing a draft value that hasn't been saved yet. I think this follows our form validation guidelines and is not a bug.

I don't think this is a bug so gonna close. We don't validate the draft values when a form opens just when you blur a field or submit the form. If we want to change the way that works then it's more of a feature request than a bug. I don't really see much value in doing that though. Feel free to reopen if anyone disagrees!


Receiving sensor position data

Hi,
I have cloned your project, compiled and created the hex file. How can I get the sensor position details in to the command line?
Teensy_loader_Cli is not working on my PC.
I'm working on windows 10 and I have used Teensy 3.2 same as you.
Thank you!!!

Hey Hiruni, does the official uploader app work for you?
https://www.pjrc.com/teensy/loader.html
Try to load some other program first, see if it works.
--
Alexander Shtuchkin
On Mon, Jun 11, 2018 at 7:08 AM, HiruniNuwanthika<EMAIL_ADDRESS>wrote:

Hi,
I have cloned your project, compiled and created the hex file. How can I
get the sensor position details in to the command line?
Teensy_loader_Cli is not working on my PC.
I'm working on windows 10 and I have used Teensy 3.2 same as you.
Thank you!!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ashtuchkin/vive-diy-position-sensor/issues/50, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAmVHayAzujCXa6nrFZoCRlZ1L3EnWVpks5t7nnegaJpZM4UixAZ
.

Hi Alexander,
Thank you for answering..
I have tried few programs with Teensy loader as well as the Teensyduino.
Blink _fast and Blink_slow programs with Teensy loader
Simple program with a photo diode circuit using Teensyuino.
What should I do to run a program in teensy_loader_cli?
Can you please help me?
Thank you!!!

how did you create .hex file?

yes... It worked for me
On Mon, May 27, 2019 at 3:26 PM Jayaraman r p<EMAIL_ADDRESS>wrote:

how did you create .hex file?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ashtuchkin/vive-diy-position-sensor/issues/50?email_source=notifications&email_token=AEYGYTTA5YVBCYCI7HQNUKDPXOV6DA5CNFSM4FELCAM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJLZFQ#issuecomment-496155798,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEYGYTVX7ST2OA32TRJGCT3PXOV6DANCNFSM4FELCAMQ
.

How to use tycmd in windows ?
How can I configure the module as you stated in https://github.com/ashtuchkin/vive-diy-position-sensor/blob/docs/docs/manual.md ?

Can the arduino serial port be able to view the debug output information?


Add Elastic support to Collect Processor

Add Elasticsearch as a location for processed data in the Collect Processor

done


Don't save unnecessarily with save_before_running

When save_before_running is enabled, it will save all scenes, which can lead to longer running times if you have many opened scenes. That's rather absurd.
This PR changes that mechanism to only save when there are unsaved changes in the scene (which we can detect pretty reliably).

This PR changes that mechanism to only save when there are unsaved changes in the scene (which we can detect pretty reliably).

With editor plugins, this may not be the case: https://github.com/godotengine/godot-proposals/issues/2153

Excited to see this change come in! I am wondering if rather than changing the behavior only for save_before_running it might make more sense to change the implementation of "Save All Scenes" instead (with the same caveats @Calinou pointed out)?
The current behavior of "Save All Scenes" is really "Re-Save All Open Scenes" and that's not super useful. I'd expect it to either 1) save all dirty scenes (strict subset of open ones so I think that's why the current implementation is what it is) or 2) Re-Save All Scenes regardless of open status. Doing a full re-save but only of open scenes feels like a weird in-between that isn't correct for either reasonable interpretation.
Personally I'd prefer to have it just do option #1 (hence this suggestion) but I could see a use case for full re-save too. Most applications that support multiple documents simply have a "Save All" option which essentially just takes care of dirty docs so I think it's reasonable to expect users would interpret it as this.
Also I noticed it technically resaves everything that's open (including shaders and scripts) so "Save All" might be a more correct name as well.

This change works like a charm for scenes and scripts. In testing, however, I noticed that any open shaders always re-save any time any scene is saved (whether or not they are modified). I tracked it down to needing an is_unsaved check in ShaderEditorPlugin::save_external_data() i.e.
void ShaderEditorPlugin::save_external_data() {
	for (EditedShader &edited_shader : edited_shaders) {
		if (edited_shader.shader_editor) {
			if (edited_shader.shader_editor->is_unsaved()) {
				edited_shader.shader_editor->save_external_data();
			}
		}
	}
	_update_shader_list();
}

It might be worth including that in this PR also for completeness sake.

How does this work with changes to resources, instead of scenes? Currently I think a lot of the Godot workflow hinges on scene saving actually saving all dependent resources, even if there's no change to the scene itself. Saving changes to resources specifically is pretty cumbersome currently with just the save button in the inspector IIRC.

Apparently if you make a change in external resource, the editor will save the current scene which will also save that resource 🤔
And if you have no open scenes, the external changes are not saved when running. But this is the same behavior as before this PR, so it can be fixed separately.


logging improved.

Hello Team,
I can't launch app and below code in cmd:
logging improved.
No module 'xformers'. Proceeding without it.
ControlLDM: Running in eps-prediction mode
DiffusionWrapper has 859.52 M params.
making attention of type 'vanilla' with 512 in_channels
Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
making attention of type 'vanilla' with 512 in_channels
Loaded model config from [./models/cldm_v15.yaml]
Traceback (most recent call last):
File "gradio_scribble2image.py", line 18, in
model.load_state_dict(load_state_dict('./models/control_sd15_scribble.pth', location='cuda'))
File "C:\Experiment\ControlNet\cldm\model.py", line 18, in load_state_dict
state_dict = get_state_dict(torch.load(ckpt_path, map_location=torch.device(location)))
File "C:\Users\Adda.conda\envs\control\lib\site-packages\torch\serialization.py", line 699, in load
with _open_file_like(f, 'rb') as opened_file:
File "C:\Users\Adda.conda\envs\control\lib\site-packages\torch\serialization.py", line 230, in _open_file_like
return _open_file(name_or_buffer, mode)
File "C:\Users\Adda.conda\envs\control\lib\site-packages\torch\serialization.py", line 211, in init
super(_open_file, self).init(open(name, mode))
FileNotFoundError: [Errno 2] No such file or directory: './models/control_sd15_scribble.pth'

You can download pre-trained models here.