Problem with using cargo tarpaulin

There is a problem somewhere, if you've previously done a cargo build|test|run
you must do a cargo clean before a cargo tarpaulin will succeed. And then you
may get a link error if you subsequently do a cargo build. This too can be resolved
by doing a cargo clean before the first subsequent cargo build :(

Here is the error I'm seeing:
wink@3900x:~/prgs/rust/projects/binance-auto-sell (main)
$ cargo tarpaulin --follow-exec
Apr 13 17:48:22.451  INFO cargo_tarpaulin: Running Tarpaulin
Apr 13 17:48:22.451  INFO cargo_tarpaulin: Building project
   Compiling autocfg v1.0.1
   Compiling proc-macro2 v1.0.26
...
   Compiling clap v3.0.0-beta.2
   Compiling binance-auto-sell v0.1.0 (/home/wink/prgs/rust/projects/binance-auto-sell)
error: could not compile `binance-auto-sell`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
thread 'main' panicked at 'already borrowed: BorrowMutError', src/tools/cargo/src/cargo/util/config/mod.rs:307:20
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Apr 13 17:48:30.124 ERROR cargo_tarpaulin: Failed to compile tests! Error: binance-auto-sell: linking with `cc` failed: exit code: 1
Error: "Failed to compile tests! Error: binance-auto-sell: linking with `cc` failed: exit code: 1"

After a cargo clean I see:
wink@3900x:~/prgs/rust/projects/binance-auto-sell (main)
$ cargo clean ; cargo tarpaulin --follow-exec
Apr 13 17:50:45.333  INFO cargo_tarpaulin: Running Tarpaulin
Apr 13 17:50:45.333  INFO cargo_tarpaulin: Building project
   Compiling autocfg v1.0.1
   Compiling proc-macro2 v1.0.26
   Compiling version_check v0.9.3
...
   Compiling clap v3.0.0-beta.2
   Compiling binance-auto-sell v0.1.0 (/home/wink/prgs/rust/projects/binance-auto-sell)
    Finished test [unoptimized + debuginfo] target(s) in 8.25s
Apr 13 17:50:53.842  INFO cargo_tarpaulin::process_handling::linux: Launching test
Apr 13 17:50:53.842  INFO cargo_tarpaulin::process_handling: running /home/wink/prgs/rust/projects/binance-auto-sell/target/debug/deps/binance_auto_sell-8b2f8d3614c3ece0

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Apr 13 17:50:54.416  INFO cargo_tarpaulin::process_handling::linux: Launching test
Apr 13 17:50:54.416  INFO cargo_tarpaulin::process_handling: running /home/wink/prgs/rust/projects/binance-auto-sell/target/debug/deps/cli-595a799ae4fee77f

running 4 tests
test test_no_params ... ok
test test_help ... ok
test test_req_params_as_env_vars ... ok
test test_req_params ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.30s

Apr 13 17:50:57.732  INFO cargo_tarpaulin::report: Coverage Results:
|| Tested/Total Lines:
|| src/main.rs: 6/6
||
100.00% coverage, 6/6 lines covered

Added issue #736 to trapaulin repo.

Added issue #736 to trapaulin repo.

Semi fixed as tarpaulin now automatically cleans so just do a cargo tarpaulin.
BUT you must do a cargo clean before doing any subsequent cargo build|run|test.
What I do now is use a trivial shell script cargo-precommit:
echo clippy ; cargo clippywink@3900x:~/prgs/rust/projects/binance-auto-sell (main)
$ cat ./cargo-pre-commit
#!/usr/bin/env bash
set -e
echo check ; cargo check
echo fmt ; cargo fmt
echo test ; cargo test
echo tarpaulin ; cargo tarpaulin
echo clean ; cargo clean
echo clippy ; cargo clippy

Which does a cargo clean before cargo clippy as the last operation, so I don't need to worry about it.
If you copy it to ~/.cargo/bin/:
wink@3900x:~/prgs/rust/projects/binance-auto-sell (main)
$ cp ./cargo-precommit ~/.cargo/bin/

And then just do a cargo pre-commit before commiting:
wink@3900x:~/prgs/rust/projects/binance-auto-sell (main)
$ cp ./cargo-precommit ~/.cargo/bin/
...


make infinite scroll not so infinite (enhancement)

Originally reported by: lisa ballard (Bitbucket: basilleaf, GitHub: basilleaf)

think i want the infinite scroll to only page for up to 5 or so and then prompt to keep doing that. see instagram.com

Bitbucket: https://bitbucket.org/ringsnode/opus2/issue/135

nope.


fix(parser): fix parse error on JSXText preceded by JSXFragment

Current implement was unable to parse
<></>foo
, as foo was identified as Identifier.

Thank you! I'm now super interested on what you're working on 😃


Update the SQL script used for generating latest snapshot II

This is a follow up from #703 , rebasing against current next branch.
@dackers86 as discussed, this is my first PR to this repos, happy to follow any guidelines you have. I also did not manage to run the tests locally (if you can point me to env setup and instructions I'd appreciate)

Hello @dgilperez @dackers86
I have a collection that I've exported to BQ using the extension. The raw changelog has 6.88 MB with ~1000 rows.
Currently querying is taking 47-90 seconds slot time to query the raw_latest view. I'm not sure if I've messed up anything in the schema creation process, but was wondering whether this commit could help with that or if it's something deeper? Is there any ETA for this PR to be released?

I ended up removing all views generated with this extension and recreated
them using the code in this PR. That's working apparently fine in my end.
You can try on new views with this code and check the results of both
queries for consistency if you wish.
About the PR, it's unclear to me. It's my first contribution to the repo
and I don't know how the process goes.
In my opinion, current released view queries are not usable, so I'd push
this asap, but like I side we have our workaround.
El jue., 31 mar. 2022 19:15, tgpsantos @.***> escribió:

Hello @dgilperez https://github.com/dgilperez @dackers86
https://github.com/dackers86
I have a collection that I've exported to BQ using the extension. The raw
changelog has 6.88 MB with ~1000 rows.
Currently querying is taking 47-90 seconds slot time to query the
raw_latest view. I'm not sure if I've messed up anything in the schema
creation process, but was wondering whether this commit could help with
that or if it's something deeper? Is there any ETA for this PR to be
released?
—
Reply to this email directly, view it on GitHub
https://github.com/firebase/extensions/pull/915#issuecomment-1084873491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACATDSWRWWLFSU5WLGXEK3VCXMUXANCNFSM5QWNVPYQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Delta return 0 when stick is release

When stick is release, is still return last delta.
With this fix when stick is release, delta's return 0

👍


Engine Start/Stop not working

Since a few days the engine start/stop service is not working anymore. The other services like lock doors, climate, etc. are working.
Maybe Lynk&Co changed something in the function call?

I used it this morning and it worked

Interesting. Maybe they deactivated it for the germans. We tried the last days different times with completly charged and lower soc. We will observe it.
The other Services are working Fine. Even the pre climate with charging cable plugged in is working. Only the Engine Start/stop does nothing.

And you have experimental features turned on and cable not plugged in to the car?

Yes exp.features are on and cable not plugged in. I already activated debug logging. Log says that the command was successfully sent.
maybe it is something with our car or a deactived thing on german market. I will keep an eye on it.
But our fuel is nearly empty. Maybe that is the cause. We will refill it this evening.

We have now filled up the fuel and the engine start function is working again. So it seems that if the tank reserve warning is active the function is disabled by the car.

It is really good that the car actually has some limitations since this feature is not documented or supported by the official app!
Closing this issue and updating README with this info


Add link to source show page on Top Sources

Add a link embedded in the name for the Top Sources Chart

closed with pr #601


Document keyboard shortcuts

This could be a page on https://sleipnirgroup.github.io/Choreo/, an in-app dialog, or both.

Oh it should also be an in app dialog.

In-app keyboard shortcut docs is now a separate issue: https://github.com/SleipnirGroup/Choreo/issues/373

In-app keyboard shortcut docs is now a separate issue: #373. This issue is now only concerned with the documentation website.

We currently have this: https://sleipnirgroup.github.io/Choreo/usage/controls-shortcuts/


[folly] Fix dependency issue in config file

Fix related  issue https://github.com/microsoft/vcpkg/issues/10169
Add glags dependency to config file.
All features test pass with x64-windows.

@ayermolo, could you help test the changes and see if it works for you?

@PhoebeHui sure, let me know when it is merged.

LGTM! Thanks!


pass runtime configs & variables to BeamSqlSeekableTable

fixes #28145

R: @Abacn

R: @bvolpato

precommit

Thanks! No major concerns from me -- just one note is that relying on PipelineOptions will allow configuring behavior for the entire job.
Sometimes it's better to use a specific configuration class / instance, so you could likely have multiple JOINs in the same job and each handle different things.

LGTM. It's totally reasonable to add the method as they corresponding the dofn lifecycle methods. Probably we should add them at the beginning.

One thing to note when implementing youe own BeamSqlSeekableTable. startBundle can be called many times, so if initializing a connection in it, it's good to use a connection pool otherwise there could be too much connection - a common issue seen in Beam IO implementation

also, its nice to have a test checking dofn lifecycle is effective with BeamSqlSeekableTable methods.

thanks very much. I will add initialized flag to startBundle in our own BeamSqlSeekableTable to avoid too much connection.


how to Execute command and quit

hi all:
how to use mssql-cli command to show like "mysql -e 'show databases'"

maybe related: https://github.com/dbcli/mssql-cli/issues/139#issuecomment-531748110

This is one the roadmap, but there is not ETA adding this.

Closing as a duplicate of https://github.com/dbcli/mssql-cli/issues/242, which will be used to track this issue.


Feature/bes graphql

Removed the helper functions and updated readme. @andrechrist please check, if we need more examples for the usage. If this is OK, I will copy it to dev.leanix.net

@bernd-s Please add example for muation as well.

@rwe17, @dllx and @maikschwan  I've added the missing example. Please review the changes this morning, so that I can create a new release in the afternoon. Thank you


Modified navbar of the AgroBlogs page.

Related Issue
Solves #1006
Description
Now the navbar on the agro blogs page is similar to other pages with properly working hamburger icon.
Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Hamburger menu option is not working on clicking.

@Suchitra-Sahoo it is working

Also the navbar options are overflowing.

https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/143121854/9d393473-d10b-452d-ab1e-c9a48a5ca428

@Suchitra-Sahoo hamburger menu is working fine.

Please don't revert this PR
If you say I will create another issue to fix the navbar overflowing options.

Hi @Suchitra-Sahoo  can you tell me what to do for this issue.


CxSCA-Remediation

Packages updated by CxSCA-Remediation
package.json:

body-parser: 1.18.3 🠚 1.19.0 (Fixes: Cx14b19a02-387a)
marked: 0.3.9 🠚 0.3.17 (Fixes: Cxee7cbf9f-8b8d)

good to go


Swift error reporting style removed complete path:line:col information

Description
The new error formatting does the following:
=== /Users/ktoso/code/swift-project/swift/stdlib/public/core/SIMDVector.swift ===
     ┆
  61 │
  62 │ /// A type that can be used as an element in a SIMD vector.
  63 │ public protocol SIMDScalar {
     ∣                 ├─ warning: protocol 'SIMDScalar' should be declared to refine 'Decodable' due to a same-type constraint on 'Self'
     ∣                 ├─ warning: protocol 'SIMDScalar' should be declared to refine 'Encodable' due to a same-type constraint on 'Self'
     ∣                 ╰─ warning: protocol 'SIMDScalar' should be declared to refine 'Hashable' due to a same-type constraint on 'Self'

which is missing a crucial feature of the previous format, including the:
/Users/ktoso/code/swift-project/swift/stdlib/public/core/SIMDVector.swift:61:16

information as one string where the error was located.
This is important because terminals and IDEs are able to understand this format and e.g. in iterm2 you can click such "path:line:col" to open up your editor at the exact line where the error was simplifying editing by a lot when working from the terminal (which always do for example).
Including this in the "header" where the fullpath is would be good enough I think 👍
Thanks in advance for bringing back this info the new formatter is quite pleasant, looking forward to it!

Hmm, I’m not sure if the header is the right place to put it because a source file rendered by this diagnostic formatter could show multiple errors at different lines. But I don’t know where else we could put it either.

wouldn't one expect to have one error per one listing tbh?
But even if multiple perhaps at least offer the first one as that'd jump to the "right location" mostly?

rdar://106434704


chore: reenable pp_nodot where porting note disabled it.

Moreover, removing a stray porting note from a test about disabling the "unused variable" linter

The execution is straightforward; thanks for doing this clean-up. I'd like another pair of eyes if this change is still needed in Lean 4, there's anything I'm overlooking etc - so let's
maintainer merge

Oh, sorry, I wasn't expecting anyone to clean up pp_nodot porting notes and neglected to check the queue!

All good, I think we created them almost simultaneously, after the stats about porting notes got published😁


Critters dont work if the url has a prefix

if you have a build that puts a url in front of the css, this is the assetsPrefix option in astro, you will have this difference
<link rel="stylesheet" href="http://localhost:4321/_astro/index.Bd8XMnIY.css">

<link rel="stylesheet" href="/_astro/index.Bd8XMnIY.css">

and when you have a prefix with the url or domain dont works well, and don't inline nothing

I'll take a look. Thank you.

Critters has an option for this, you can pass publicPath as a string that will be remove from the original path, just need to add this option in the plugin for these cases

Does it work if you pass it in the integration's options? You can override them like this:
export default {
 	integrations: [
 		(await import("@playform/inline")).default({ 			Critters: { publicPath: "https://yoururl.com" },
 		}),
 	],
 };

yeah that works, didn't know that you can override the critters options, is not as an example in the readme


Update Developer Guide link implementation

Add activity diagram for link implementation
Add link activity diagram puml and image

Minor bug :

Fix link command displaying all internships/persons (if previously filtered) after linking

Codecov Report

Merging #282 (9f721e0) into master (1170d24) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #282      +/-   ##
============================================
+ Coverage     64.04%   64.46%   +0.41%
- Complexity      622      626       +4
============================================
  Files           102      102
  Lines          2417     2417
  Branches        326      326
============================================
+ Hits           1548     1558      +10
+ Misses          691      681      -10
  Partials        178      178

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/LinkCommand.java
74.07% <100.00%> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
95.29% <0.00%> (+11.76%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


tests/kernel/timer/timer_api/kernel.timer  sporadically (high frequency) fails in CI on qemu-xtensa

***** Booting Zephyr OS zephyr-v1.14.0-1113-g8806967aed2e *****
Running test suite timer_api
===================================================================
starting test - test_timer_duration_period
PASS - test_timer_duration_period
===================================================================
starting test - test_timer_period_0

    Assertion failed at ./tests/kernel/timer/timer_api/src/main.c:167: test_timer_period_0: tdata.expire_cnt == 1 is false

FAIL - test_timer_period_0
===================================================================
starting test - test_timer_expirefn_null
PASS - test_timer_expirefn_null
===================================================================
starting test - test_timer_periodicity
PASS - test_timer_periodicity
===================================================================
starting test - test_timer_status_get
PASS - test_timer_status_get
===================================================================
starting test - test_timer_status_get_anytime
PASS - test_timer_status_get_anytime
===================================================================
starting test - test_timer_status_sync
PASS - test_timer_status_sync
===================================================================
starting test - test_timer_k_define

    Assertion failed at ./tests/kernel/timer/timer_api/src/main.c:394: test_timer_k_define: tdata.expire_cnt == 4 is false

FAIL - test_timer_k_define
===================================================================
starting test - test_timer_user_data
PASS - test_timer_user_data
===================================================================
starting test - test_timer_remaining_get
PASS - test_timer_remaining_get
===================================================================
Test suite timer_api failed.
===================================================================
PROJECT EXECUTION FAILED

I don't think this should be high, only seen with QEMU which is known to have timing issues since we don't use icount

I'll take spurious bugs, regardless.  Drop to medium for now, will do another pass with a modified rig to rule out timing on tests like this again.


Meta image is not displaying in Twitter

We need to fix this for twitter:

Follow the convo here:
https://fightpandemics.slack.com/archives/C015BC1EMMG/p1595966724089300

Hi @idjevm, do we need to use absolute path for twitter image?
Here is reference: https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/summary-card-with-large-image

This has been resolved maybe with #1378 ?


split item abilities

output: https://pastebin.com/raw/DhX9gPsb

can you also run it to generate the new file?

ok something didnt work.
let me have a look at it

nevermind, it did work....


Add support for tracking people visiting odo.dev

What type of PR is this?
/kind feature
What does this PR do / why we need it:
This PR adds support for tracking people visiting odo.dev
Which issue(s) this PR fixes:
Fixes #5106
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[x] Documentation

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:
Run the server locally and check if data is visible on segment. Ensure that the user IP is set to <IP_ADDRESS>.

/lgtm

Run the server locally and check if data is visible on segment.

Where on segment should I expect to see the data?

Ensure that the user IP is set to <IP_ADDRESS>.

Where does one have to set this?
@valaparthvi do you think it would have been better if only @kadel reviewed this PR?
Unassigning myself from this PR.

Run the server locally and check if data is visible on segment.

Where on segment should I expect to see the data?
Look for odo_website

Ensure that the user IP is set to <IP_ADDRESS>.

Where does one have to set this?
Check the raw data on segment. Look for .context.ip in the raw.

@valaparthvi do you think it would have been better if only @kadel reviewed this PR?
Not really. It's alright for everyone to review it.

Kubernetes Tests finished.
View logs: TXT HTML

Unit Tests finished.
View logs: TXT HTML

OpenShift Tests finished.
View logs: TXT HTML

Kubernetes Tests finished.
View logs: TXT HTML

Unit Tests finished.
View logs: TXT HTML

OpenShift Tests finished.
View logs: TXT HTML

Kubernetes Tests finished.
View logs: TXT HTML

Unit Tests finished.
View logs: TXT HTML

OpenShift Tests finished.
View logs: TXT HTML

/approve
/lgtm


SDDM through services.displayManager does not inherit XKB layout.

Describe the bug
When using SDDM and Plasma 6 in nixos-unstable, SDDM does not inherit the keyboard layout I have set with services.xserver.xkb.layout. It instead uses the default of en-us. I can confirm that the correct layout is set with localectl status.
Steps To Reproduce
Steps to reproduce the behavior:

Enable SDDM with services.displayManager.sddm.enable = true;
Set a keyboard layout with services.xserver.xkb.layout
Rebuild and reboot into SDDM

Expected behavior
SDDM inherits the keyboard layout from my system locale.
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.28, NixOS, 24.05 (Uakari), 24.05.20240427.58a1abd`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/801l7gvdz7yaibhjsxqx82sc7zkakjbq-source`

Add a :+1: reaction to issues you find important.

You probably need to run the following to fix that:
sudo cp ~/.config/kwinoutputconfig.json /var/lib/sddm/.config/
sudo cp ~/.config/kcminputrc /var/lib/sddm/.config/
sudo chown sddm:sddm /var/lib/sddm/.config/kcminputrc
sudo chown sddm:sddm /var/lib/sddm/.config/kwinoutputconfig.json

It would actually be ~/.config/kxkbrc

I am on SDDM with Wayland only and copying the two files fixes keyboard and display configuration for me.

Neither of those 2 files store the KDE keyboard layout config, so I can't see why they'd work here. What I'm specifically looking for is for SDDM to inherit the keyboard layout (E.g. English (US)) that I set in my system locale OR some way to specifically declare keyboard layout in SDDM.

🤔 I think I remember now. Those where for the display configuration and for the touchpad to work correctly.
The keyboard layout is done through xkb and we needed to move it here https://github.com/NixOS/nixpkgs/blob/2e9d7dca27336d8b75baa53c782e9ba94f8da2ab/nixos/modules/services/misc/graphical-desktop.nix#L23-L32 so using services.xserver.xkb options should fix that.

using services.xserver.xkb options should fix that.

But my initial report here is that SDDM isn't inheriting what I have set in the xserver.xkb options (neither is plasma 6, but that can be configured in settings).

Is the layout in /etc/X11/xorg.conf.d/00-keyboard.conf correct?

I'm also having this issue and for me atleast everything seems to be set correctly in /etc/X11/xorg.conf.d/00-keyboard.conf:
Section "InputClass"
  Identifier "Keyboard catchall"
  MatchIsKeyboard "on"
  Option "XkbModel" "pc104"
  Option "XkbLayout" "de"
  Option "XkbOptions" ""
  Option "XkbVariant" ""
EndSection

It worked for me (I had confused layout with variant) to choose the variant, I don't see why the layout would act differently.


[devops:bot] update deps in nix/sources.json (from: rhino-core@f4a9ced

update nix refernces for rhino-core and|or nixpkgs to match https://github.com/rhinofi/rhino-core/blob/f4a9ced4dc0e7b9f4fa5808c5683191c0917c301/nix/sources.json (branch: dev)

superseded by #129


[SPARK-37099][SQL] Introduce the group limit of Window for rank-based filter to optimize top-k computation

What changes were proposed in this pull request?
introduce a new node WindowGroupLimit to filter out unnecessary rows based on rank computed on partial dataset.
it supports following pattern:
SELECT (... (row_number|rank|dense_rank)()
    OVER (
PARTITION BY ...
ORDER BY  ... ) AS rn)
WHERE rn (==|<|<=) k
        AND other conditions

For these three rank-like functions (row_number|rank|dense_rank), the rank of a key computed on partial dataset always <= its final rank computed on the whole dataset，so we can safely discard rows with partial rank > k, anywhere.
This PR adds a per-window-group limit before and after the shuffle to reduce the input data of window processing.
More specifically, the before-shuffle per-window-group limit:

adds some row comparison to determine window group boundaries and rank values.

applies per-window-group limit to reduce the data size of shuffle, and all the downstream operators.

This is beneficial, assuming the per-window-group data size is large. Otherwise, the method to determine window group boundaries is pure overhead. The config spark.sql.window.group.limit.threshold could avoid the overhead if the per-window-group data size is small enough.
The after-shuffle per-window-group limit just applies a per-window-group limit to reduce the data size of window processing. This is very cheap as it only needs to iterate the sorted data (window operator needs to sort the input) once and do some row comparison to determine group boundaries and rank values. It's more efficient to merge it into the window operator, but probably doesn't worth it as the overhead is small.
This PR also take over some functions from https://github.com/apache/spark/pull/34367.
Why are the changes needed?

reduce the shuffle write
solve skewed-window problem.
improve the performance and TPC-DS.

Does this PR introduce any user-facing change?
'No'.
Just update the inner implementation and add a new config.

This improvement is valid for TPC-DS q67 and no regression for other test cases.

TPC-DS Query
Before(Seconds)
After(Seconds)
Speedup(Percent)

q44
29.945
28.862
3.75%

q67
997.7585
412.046
142.15%

q70
20.149
19.955
0.97%

All TPC-DS
7076.6715
6472.0535
9.34%

There is an extreme case for this optimization. If the window group size is small enough, we still sort by partition key, order by key before shuffle. The worst case scenario is that there is only one row of data in each window group. I changed the partition of the window frame in q67 of TPC-DS from i_ The category is replaced by the store_ Primary key ss of sales table_ ticket_ Number, you can test this worst-case scenario.

TPC-DS Query
Before(Seconds)
After(Seconds)
Speedup(Percent)

q67-changed
2655.285
3062.245
-13.29%

ping @zhengruifeng cc @cloud-fan

Very happy to see this optimization work restart

This PR basically adds a per-window-group limit before and after the shuffle to reduce the input data of window processing.
More specifically, the before-shuffle per-window-group limit:

adds an extra local sort to determine window group boundaries
applies per-group limit to reduce the data size of shuffle, and all the downstream operators.

This is beneficial, assuming the per-group data size is large. Otherwise, the extra local sort is pure overhead.
The after-shuffle per-window-group limit just applies a per-group limit to reduce the data size of window processing. This is very cheap as it only needs to iterate the sorted data (window operator needs to sort the input) once and do some row comparison to determine group boundaries and rank values. It's more efficient to merge it into the window operator, but probably doesn't worth it as the overhead is small.
I think the key here is to make sure the before-shuffle per-group limit is very unlikely to introduce regressions. It's very hard to know the per-group data size ahead of time (can CBO help?), and we need some heuristics to trigger it. Some thoughts:

shall we add a config as the threshold of the limit? e.g. we can set the config as 10 and then where rn = 11 won't trigger it.
shall we have a special sort that stops earlier when the input is very distinct? This means the per-group data size is small and we shouldn't do this optimization.

+1 on add a separate config as the threshold to trigger this optimization.
since new logical and physical plans are added, should also consider how it affect existing rules.
thanks for taking this over @beliefer

since new logical and physical plans are added, should also consider how it affect existing rules.

How about we do this optimization as a planner rule? then logical plan won't change.

I just image a special case: if the child's (e.g a SMJ) output ordering happens to satisfy the requirement of this filter, then there will be no extra SortExec, is it always beneficial to apply this optimization?

I just image a special case: if the child's (e.g a SMJ) output ordering happens to satisfy the requirement of this filter, then there will be no extra SortExec, is it always beneficial to apply this optimization?

WindowGroupLimitExec need the child 's output ordering like WindowExec.

I just image a special case: if the child's (e.g a SMJ) output ordering happens to satisfy the requirement of this filter, then there will be no extra SortExec, is it always beneficial to apply this optimization?

Fixed.

The failure GA is unrelated with this PR.

ping @cloud-fan

Does this one have a chance to Spark 3.4?

Does this one have a chance to Spark 3.4?

Maybe. I testing the performance now.

there are 3 tpc queries having plan change, what's their perf result?

there are 3 tpc queries having plan change, what's their perf result?

thanks, merging to master!

@cloud-fan @zhengruifeng @LuciferYang @ulysses-you Thank you for review.


Switch to Lyo 6

PR not really ready for review but marking it such to start CI checks.

https://github.com/OSLC/lyo-samples/actions/runs/8498767441

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project lyo-client-samples: Compilation failure: Compilation failure:
Error:  /home/runner/work/lyo-samples/lyo-samples/main/lyo-client-samples/src/main/java/org/eclipse/lyo/samples/client/automation/AutomationAdapter.java:[575,57] cannot access jakarta.ws.rs.core.Response
Error:    class file for jakarta.ws.rs.core.Response not found

@jadelkhoury could you please take a look?

Interesting. Why is this code already calling jakarta classes?
I can have a look.

But @berezovskyi I don't have the bandwidth a the moment to migrate these projects to 6.0.0.SNAPSHOT.
I think we can set them on 6.0.0.Alpha1 to make sure they can still run.
Focus (for now) should be to test with the refImpl. If we make job too big, we won't finish it.

@Jad-el-khoury I understand. I was only thinking about upgrading https://github.com/OSLC/lyo-samples/tree/master/lyo-client-samples as we test this client code against multiple Jazz installs.

@Jad-el-khoury I understand. I was only thinking about upgrading https://github.com/OSLC/lyo-samples/tree/master/lyo-client-samples as we test this client code against multiple Jazz installs.

I see! I can look into it. Remember that the refImpl has a client that tests all 4 servers (but I only migrated rm & the client). So, we are testing the client (but not lyo-samples).

@berezovskyi ! It builds fine locally. I can't even see a trace of "jakarta" in either pom.xml or java files - throughout the whole repo.
Could it be a problem in the Workflow configuration?

Are you on the b-lyo6 branch?

Are you on the b-lyo6 branch?

Believe so. this b-lyo6 's only change was to switch to 6.0.0.SNAPSHOT!

I am running the code under this repo.
I could see from error above that you are running this
/home/runner/work/lyo-samples/lyo-samples/main/lyo-client-samples/src/main/java/org/eclipse/lyo/samples/client/automation/AutomationAdapter.java

I can't even see a trace of "jakarta" in either pom.xml or java files - throughout the whole repo.

I think the error is that the client sample code is using lyo-client 6.0.0-SNAPSHOT that depends on jakarta stuff with the provided scope but the sample POM is still supplying Jersey 2.35 deps, thus jakarta classes cannot be found.

I finally understand what was causing the differences. The CI results are correct, our local are not (I also got this branch to work locally). The reason is that our local mvn builds pull 6.0.0-SNAPSHOT from maven repos, but the CI config in question builds the latest Lyo commit from a given branch (I was using branch b153-migrate-jaxrs-api-to-jakarta in my CI launch instructions).
In other words, these are the errors you will see on this project/PR after the jakarta branch is merged into Lyo master.


Provide a way to get all the extract emoji by aliases

What feature are you proposing?
As far as I can tell, EmojiManager#extractEmojisInOrder only extract unicode emojis.
I think what should be added is either a method that extract emojis by their aliases, or EmojiManager#extractEmojisInOrder should extract both unicode and aliases.
I would also like if it was possible to get the index of the extracted emojis.
Do you have any additional material for your feature proposal?
My use case is I need to extract unicode & alias emojis, amongst other things, while keeping their order, I would need the indexes so I can sort all the tokens by their index

Hi, this is not as easy as it sounds because it depends on the actual platform you want to use the alias from. For example :call_me_hand::skin-tone-2: discord an slack both have this alias for 🤙 with a tone. But both platforms treat them different and display a different tone for this kind of emoji. Which one should be used in this case? So I don't think there's really a reliable way to do this without having a dedicated method that tries to extract the emojis by alias for the specific platform.

I would also like if it was possible to get the index of the extracted emojis.

Getting the index of something is a pretty broad term. Internally JEmoji uses an array of codepoints and iterates over it to determine whether something is an emoji. You probably want to get the index of the String where the emoji appears?
Regardless of that, I think that's a good addition with the only (probably) diadvantage of performance loss due to trying to find the index in the String. I will add EmojiManager#extractEmojisInOrderWithIndex to my to do list 🙂

Getting the index of something is a pretty broad term. Internally JEmoji uses an array of codepoints and iterates over it to determine whether something is an emoji. You probably want to get the index of the String where the emoji appears? Regardless of that, I think that's a good addition with the only (probably) diadvantage of performance loss due to trying to find the index in the String.

Yes, I'd want the index of the String where the emoji appears, if I read the source correctly, it should be the textIndex variable

I'll do a PR, I have some idea on how to refactor this


Failed To Mount Vendor!

how do i mount the vendor

If your vendor partition is fucked, flash the ROM and it will be okay
Also you may need to change the filesystem of your /data and /cache partitions to EXT2 and EXT4 or TWRP will not recognize them.

If your vendor partition is fucked, flash the ROM and it will be okay
Also you may need to change the filesystem of your /data and /cache partitions to EXT2 and EXT4 or TWRP will not recognize them.

how do i mount the vendor

If your vendor partition is fucked, flash the ROM and it will be okay
Also you may need to change the filesystem of your /data and /cache partitions to EXT2 and EXT4 or TWRP will not recognize them.

how do i mount the vendor

If your vendor partition is fucked, flash the ROM and it will be okay
Also you may need to change the filesystem of your /data and /cache partitions to EXT2 and EXT4 or TWRP will not recognize them.


Phantom strange error "An error has occurred when reading existing sub-variable "loginAction"

Hello there!
Sometimes, we are getting some strange error during "UPDATE_PASSWORD" action with default text and in logs there are such messages:

We are using keycloakify. Do you have any thoughts on that?

Hi @hookenful,
Thanks for reporting,
Those errors can be easily fixed, I just need some good soul like you to report them when they arise.  🙂
What I need is, on the pages that generates the error, the code that generate the kcContext:
You would obtain it like this:
https://user-images.githubusercontent.com/6702424/169353165-8d2ea0e2-5f5d-4ef5-aee4-2e07963d430a.mov
If you can copy and past it here, I can release a patch.
Anyway, that error is just noise, they can be safely ignored, but it's annoying noise.

Thank for your fast reply. Do I need to catch code from page only during error or anytime?

Thank you! Seem like this error have been fixed already c583b83 Try updating keycloakify, the issue should be gone.

How are you going to fix this?

With
I can see that trying to dereference url.loginAction on the error.ftl page makes Java throw.

What is this version where that was fixed?

It was fixed in version 4.8.5 but you should update to v5.
There is no major breaking changes.