Missing fields from JSON serialization

If enum is set to its default value it seems that the field is missing from the JSON.
For example:
syntax = "proto3";

message MyMessage {

	enum MyEnum {
		FIRST_VALUE = 0;
		SECOND_VALUE = 1;
	}

	MyEnum e = 1;
}

If the code is:
let c = MyMessage.with {
    $0.e = .firstValue
}

print(try! c.jsonString())

then the output is wrong and the field is missing:
{}
However if change the value of e to $0.e = .secondValue then the output is correct: {"e":"SECOND_VALUE"}

This is standard protobuf behavior.  Proto3 compresses the output by omitting any field that has a default value.  This applies to both the binary protobuf encoding and to JSON encoding.
From https://developers.google.com/protocol-buffers/docs/proto3#json

If a value is missing in the JSON-encoded data or if its value is null, it will be interpreted as the appropriate default value when parsed into a protocol buffer. If a field has the default value in the protocol buffer, it will be omitted in the JSON-encoded data by default to save space.

@tbkka - does it mean that if change the default value later and the deserialization of an old serialized data will produce wrong results?

In proto3 syntax, the only possible default values are the zero values, so they can't really be changed.
In proto2 syntax, you can state explicit default values (non zero). But since any value that is explicitly set is sent over the wire (JSON, binary, etc.), the conditions are a little different.  The proto2 guide talks about changing defaults in the section on updating a proto definition.

ok, thank you for the clarification

@thomasvl
Sorry to comment on an old issue.
The specification seems to mention that implementations can allow default values to be encoded in the JSON as an option.
The last sentence of:
"When generating JSON-encoded output from a protocol buffer, if a protobuf field has the default value and if the field doesn’t support field presence, it will be omitted from the output by default. An implementation may provide options to include fields with default values in the output."
From here: When generating JSON-encoded output from a protocol buffer, if a protobuf field has the default value and if the field doesn’t support field presence, it will be omitted from the output by default. An implementation may provide options to include fields with default values in the output.
Would it be possible to have it added as an option to this function call:
  public func jsonString(
    options: JSONEncodingOptions = JSONEncodingOptions()
  ) throws -> String

Or specifically a property here:
/// Options for JSONEncoding.
public struct JSONEncodingOptions {

  /// Always print enums as ints. By default they are printed as strings.
  public var alwaysPrintEnumsAsInts: Bool = false

  /// Whether to preserve proto field names.
  /// By default they are converted to JSON(lowerCamelCase) names.
  public var preserveProtoFieldNames: Bool = false

  public init() {}
}

If the answer is yes but limited resources, I'd be happy to try make a PR.


Implement some shell commands

Related to https://github.com/tursodatabase/libsql/issues/142.

thanks!


remove deprecated util.extend

util.extend is deprecated since v3.0.0.

If there won't be backward compatibility problems (since it was deprecated) I agree with removing it. I can open a PR..

It should've been removed in v4.0.0, but I'm fine with removing it in 4.1.0.

I can open a PR..

Please do.


{Pipeline} Bump version pipeline

Description

Add a new pipeline for bumping version. The related doc is also added.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

bump version pipeline

/azp run


Default values for environment variables.

Hello!

Sometimes these needs to have some defaults.
As a workaround i made a keyword with OperatingSystem.Get Environment Variable and try to load the env var there or put default. The cons of it is -- any keyword, which uses my env var's value need to get that 'loading' keyword running. It seems to be silly.
I'd like to have some default value feature in the %{} structure.
For example:
*** Variables ***
${var_uses_everywhere}    %{MY_ENV_VAR:default_value_if_missing}

or
%{MY_ENV_VAR:-default_value_if_missing}
to mimic bash ${a:-b} structure.
It seems not so hard to implement such behavior.

Although it shouldn't be overly complicated to make sure all needed environment variables are set before execution, I can see this could sometimes be useful and make configuration easier. I got a feeling that : is actually allowed in environment variable name (shell may not like it), but = shouldn't be so %{VAR=default} would be a bit better.
Are you interested to implement this and provide a PR? I can help if needed.

One of my project consists of lot of services, each of them running the same RF-tests repository (all of them have common keywords, resources, libraries, etc.) with different tags which helps to start the correct tests. The main issue is -- each service can be started on different envs and have lot of configuration differences (here are several dev teams creating these services) -- so defaults is very important for me.
As for PR -- i would like to try! Anyway, you can always say what i did wrong in PR. However, i didn't contribute in RF code earlier so if you have some suggestions -- i'd appreciate!

@pekkaklarck pls see https://github.com/robotframework/robotframework/pull/3384 PR
i'd also added two test-cases

Yeah, there definitely are use cases where this would help. Robot's own acceptance test runner sets a Python interpreter and OS specific TEMPDIR environment variable, and sometimes when running tests directly, without the runner, you need to explicitly set it as well. We could change the current usages of %{TEMPDIR} to %{TEMPDIR=${TEMPDIR}} to use the OS default temporary directory in these cases.
Implementing this would actually be pretty simple. The code related to finding environment variables is pretty simple and editing it to split the possible default value from the name and returning it if there's no match shouldn't be hard either. You'd need to also create some acceptance tests and update docs.
To get started, see the contributing guidelines. If you have questions, don't hesitate to ask here or on the #devel channel in our Slack.

Didn't see you earlier comment or the PR when I wrote my previous comment. Good start with the PR but some changes are needed.

@pekkaklarck pls review #3384 one more time...

This was implemented by the great PR #3384 by @VVasyaev!


MM-52949 - Calls: Blank screen after ending a call and exiting its thread

Summary

Fixing a small bug where ending a call while in the thread view would leave the user on an empty call screen.

Ticket Link

https://mattermost.atlassian.net/browse/MM-52949

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information

Android: 13, Pixel 6
iOS: 15.7, iPhone 7 plus

Release Note
Calls: Fix for blank screen after ending a call and exiting its thread

/update-branch


The 0.7.2 build does not correspond to the real 0.7.2 code version

I found that you do imports in fastapi_sso.__init__.py
But actually, this build from PyPi does not have those changes:

👉 After I made a build by myself I found that it worked exactly how I expected.

Could you please publish the correct version to the Pypi?

Oh darn, thank you so much @parfeniukink! The 0.7.2 tag actually does not have those imports yet, I've just been really busy these last couple of weeks and didn't make a new release yet.
https://github.com/tomasvotava/fastapi-sso/blob/0.7.2/fastapi_sso/__init__.py
I'll create a 0.7.3 now, I'll try to setup a pipeline so that releases are published automatically, so that my laziness does not affect this project this much 🙄

0.7.3 released https://github.com/tomasvotava/fastapi-sso/releases/tag/0.7.3
Thanks again!

0.7.3 released https://github.com/tomasvotava/fastapi-sso/releases/tag/0.7.3 Thanks again!

Nice! Really halpful!
Whait for some PRs :)


Maybe unbreak MySQL 8 specs failing due to implicit order

I saw test failures in ecto_sql's CI such as https://github.com/elixir-ecto/ecto_sql/runs/814700353 that seem to be due to tests assuming that records are returned in a given order, but the query does not specify any order as far as I can tell.
I believe this should fix those tests, but I didn't want to go through all the hoops to get the MySQL integration tests running locally, so I haven't fully verified. Perhaps someone with everything set up could do so.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


TypeError when running sim agent tutorial

I encounter numerous TypeErrors while working with the sim agent tutorial, predominantly associated with protobuf and TensorFlow typing issues...
For example, in
https://github.com/waymo-research/waymo-open-dataset/blob/9d0be7c4aeed2ef5e11f2e739537bf2d27cec65b/src/waymo_open_dataset/utils/sim_agents/converters.py#L63-L72
the TypeError can be fixed by converting everthing to numpy
  for idx in range(trajectories.object_id.shape[0]):
    simulated_trajectories.append(sim_agents_submission_pb2.SimulatedTrajectory(
        center_x=trajectories.x[idx].numpy(),
        center_y=trajectories.y[idx].numpy(),
        center_z=trajectories.z[idx].numpy(),
        heading=trajectories.heading[idx].numpy(),
        object_id=trajectories.object_id[idx].numpy(),
    ))
  return sim_agents_submission_pb2.JointScene(
      simulated_trajectories=simulated_trajectories)

Similarly, I don't get why some entries are not converted to numpy.
https://github.com/waymo-research/waymo-open-dataset/blob/9d0be7c4aeed2ef5e11f2e739537bf2d27cec65b/src/waymo_open_dataset/wdl_limited/sim_agents_metrics/metrics.py#L174-L188
fixed by
  return sim_agents_metrics_pb2.SimAgentMetrics(
      scenario_id=scenario.scenario_id,
      metametric=metametric.numpy(),
      average_displacement_error=average_displacement_error.numpy(),
      min_average_displacement_error=min_average_displacement_error.numpy(),
      linear_speed_likelihood=linear_speed_likelihood.numpy(),
      linear_acceleration_likelihood=linear_accel_likelihood.numpy(),
      angular_speed_likelihood=angular_speed_likelihood.numpy(),
      angular_acceleration_likelihood=angular_accel_likelihood.numpy(),
      distance_to_nearest_object_likelihood=distance_to_obj_likelihood.numpy(),
      collision_indication_likelihood=collision_likelihood.numpy(),
      time_to_collision_likelihood=ttc_likelihood.numpy(),
      distance_to_road_edge_likelihood=distance_to_road_edge_likelihood.numpy(),
      offroad_indication_likelihood=offroad_likelihood.numpy(),
  )

Hi @jchengai, could you please provide me some more info on where and how this if failing?

What version of the repo did you install? Could you check the TF version and protobuf versions?
Which cell of the notebook is failing specifically?

I tried running the tutorial with the libraries packaged by pip and it's working correctly. If you could help me reproduce locally I'll update the code (casting to numpy is probably less error prone anyway).
Thanks!

Hi @nicomon24, thanks for your kind response.  It's strange that I cannot reproduce the typing error in a clean docker environment.
However, I can confirm that another issue continues to occur.

The Dockerfile to reproduce:
FROM ubuntu:22.04

RUN apt-get update && \
    apt-get install -y git python3 python3-pip libopenexr-dev

WORKDIR /home
RUN git clone https://github.com/waymo-research/waymo-open-dataset
RUN pip install waymo-open-dataset-tf-2.11.0==1.5.0 ipykernel

I'll what caused the typing error in my env. Thanks.

It's an internal problem of the vscode notebook, sorry.


Player Status Effects and Health Preservation Methods

Summary
This PR implements (as described in task #117) a health decay feature, status effects and health preservation methods.

Changes include a health decay [where health decreases naturally over a period of time]. It adds status effects to the player character based on the amount of hp the player has, for example the lower the health of the player the more transparent and slower [linearly based on health %] it becomes (implemented by MrTup). Furthermore, to combat the health decay  as outlined in the task, you can equip your goggles or take a bath which reduce health decay by 50% when done alone and by 100% if both the conditions are met (implemented by goat_man_king). The bath status timeouts to false in about 30 seconds. Lastly, all of the health decay and bath status timeout values are easily configurable via src.settings.
Media
Player becomes transparent according to health

Health decay in action
https://github.com/user-attachments/assets/ac9fe8f0-2116-451f-8209-e436f9f9e18d
Checklist

[✅] I have tested this change locally and it works as expected.
[✅] I have made sure that the code follows the formatting and style guidelines of the project.

Labels
type: feature, game-player

Moreover, you will need to get your branch up to date with main by fetching from it and then rebasing your work onto the incoming commits


Error with Negative Profit

When givePrice is disabled and unknown incoming offers that are not part of the bots pricelist are received it shows the price as "0 keys, 0 ref". This is proper. However if the invalid offer gets accepted and the item becomes part of the pricelist and furthers to still dissipate the amount of value that item/items had. It shows as a negative profit after doing !stats after that invalid offer trade.
Steps to reproduce the behavior:

givePrice=false
autoAcceptOverpay=true
Offer a trade with multiple items where one of those items is not part of the pricelist.
!stats
Check if profit became negative.

I expected that the bot recognized that the items were not actually worth "0 keys, 0 ref" and understood that I have profited from that invalid trade.
The image below is !stats before the invalid offer trade.

Version: 3.7.0

Thanks for the report

Thanks for the report

No problem. I want the github contributor role for doing nothing now lmao


[BUG] Default import is an ES module

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins.
[x] I use package manager yarn (Fill in: npm, yarn, pnpm, etc).
[x] I run Snowpack on OS Mac (M1) (Fill in: Windows, Mac, Linux, etc).
[x] I run Snowpack on Node.js v12+

Describe the bug
An import statement such as import Head from "next/head" assigns Head the value {__esModule: true, defaultHead: function, default: function} instead of the expected function.
To Reproduce

Clone https://github.com/fwouts/snowpack-next/tree/7e497046aea009b172a04bd0b479cf183a510cac
Run yarn snowpack dev
See error!

Expected behavior
The expected behaviour can be experienced by running yarn dev, which runs this Next.js app with Webpack instead.
Anything else?
I investigated this, and found that it's caused by node_modules/next/head.js having the following code:
module.exports = require('./dist/next-server/lib/head')

The bug fixes itself if I replace it with:
export * from './dist/next-server/lib/head'
export { default } from './dist/next-server/lib/head'

I wonder if this could be an issue with Rollup?

Unfortunately this is a casualty of CommonJS <-> ESM interop. From the TypeScript docs:

the ES6 modules spec states that a namespace import (import * as x) can only be an object, by having TypeScript treating it the same as = require("x") then TypeScript allowed for the import to be treated as a function and be callable. This breaks the spec’s recommendations.

So the .default is expected, is somewhat of a loose standard, and actually does solve a lot of problems. But it’s just something to expect whenever you try and import CommonJS code into ESM.


Few controller optimizations and cleanup

See commits for details.

@haukepetersen

replaced asm with __asm__ since RIOT uses std=c99 and used local labels in inline assembly to fix build errors in optimized code

forgot to update also for nRF51 :-)


User's kept products

What's this PR do?
closing #50
Where should the reviewer start?
Run npm run db:reset and npm run test:reset in the /Create/code/api directory
How should this be manually tested?
No testing has been added, please use graphiql-online to manually test for endpoint.
Any background context you want to provide?
A status was added to userProducts with a status of kept or returned depending on if the user has kept or returned an item. The default is kept.
What are the relevant tickets?
#50 #36
Screenshots (if appropriate)
Questions:

Thanks for exposing this interface! It shall be used to conditionally render user products.


Use cleaned version of terms, not original

Some whitespace changes crept in here too.  The only non-whitespace change is using terms.terms, not mf.terms.terms.  The local variable terms has random-effects and response terms dropped.

Looks good to me, pending green CI.

Looks like the appveyor builds are failing in RDA.jl and are unrelated to these changes.

Yep. Looking forward to getting RDA out of here.

Sorry for the whitespace mess and thanks for catching the mf.terms. Probably should also add some tests with random effects to make sure that they're dropped as expected.

Could you rebase (and merge) this?


ZFIN-8699: Genotype Naming Rules Changes

Closing for now. We can reintroduce this when naming conventions are hammered out


Detect venv set to $VIRTUAL_ENV

Setting a path to a venv to $VIRTUAL_ENV is a common way to signify a "global" venv, which should be used if a project-level venv is not present. This is especially true after system level python installs have become externally managed PEP668 on almost all platforms (debian, ubuntu, brew, etc.)

This is different from when you activate a venv and it automatically sets this variable to itself. Am talking about a user setting this variable in their dotfiles.
One could put this "global" venv on the $PATH but this leads to various undesirable side-effects.

Setting a path to a venv to $VIRTUAL_ENV is a common way to signify a "global" venv, which should be used if a project-level venv is not present.

I wouldn't say it's "common", but is a hack some people have used to work around code which checks that variable as a way to determine if a virtual environment is set. But as the docs point out, that environment variable is only meant to signify when a virtual environment is activated and not as a way to tell other apps, "use this system install".
We also wouldn't want to promote working around externally-managed Python installs as the OS vendors set that specifically because they don't want users installing into them and some tools assume virtual environments can bn installed into.

"use this system install"
We also wouldn't want to promote working around externally-managed Python installs as the OS vendors set that specifically because they don't want users installing into them

Where did system installs or OS pythons come from? I am specifically talking about a venv here.
From the docs:

You don’t specifically need to activate a virtual environment, as you can just specify the full path to that environment’s Python interpreter when invoking Python. Furthermore, all scripts installed in the environment should be runnable without activating it.

As you can see, activating a venv isn't mandated.
You surely are not saying that a large amount of use cases (data science, etc) don't require the presence of a global venv (pyenv, etc install their venvs to a central location for a reason), are you? For tools that don't have a central location for venvs like uv, setting a venv to this env var becomes critical to the workflow. Also, uv (which strives strictly to abide by PEPs) uses this env var to locate venv, why can't pet?

Also, just fyi, setting an externally-managed installation to this env var won't make it not externally managed xD
Even if it did, pet has got nothing to do with that use case because it is supposed to locate installations (which it already does for externally managed installs anyway) and not install packages into it. pet is not pip.

Just like pet tries to locate venvs in various places like the workspace itself, many central locations used by tools, user paths like XDG_BIN_HOME, the $PATH env var, etc. pet should also use this env var to locate venvs. And this is exactly what the doc says:

When a virtual environment has been activated, the VIRTUAL_ENV environment variable is set to the path of the environment. Since explicitly activating a virtual environment is not required to use it, VIRTUAL_ENV cannot be relied upon to determine whether a virtual environment is being used.

It says "use this env var to locate venvs except when it is not set for some reason". Currently, pet doesn't even check this env var to begin with. If anything, pet is going against the docs here.

Where did system installs or OS pythons come from?

Sorry, misread  '"global" venv' as '"global" env'.

As you can see, activating a venv isn't mandated.

I'm aware as I am the one who opened the issue on CPython to make that abundantly clear in the docs.

You surely are not saying that a large amount of use cases (data science, etc) don't require the presence of a global venv (pyenv, etc install their venvs to a central location for a reason), are you?

What does "global" mean to you in this instance? A virtual environment that is shared across multiple projects or a virtual environment that's meant to be used for a single project, but having it stored outside of the project directory?

uv (which strives strictly to abide by PEPs)

As someone who wrote a bunch of those PEPs, I'm acutely aware of what uv does and does not implement based on specs, convention, and what they just chose to do simply because they thought it was a good idea.

uses this env var to locate venv, why can't pet?

It could. I'm just pushing back on your assertion that people manually setting VIRTUAL_ENV is "common" when not fully activating a virtual environment (i.e. updating PATH).

Let me explain my case.
In fields like data science, a global environment with a certain set of packages are always needed for quick prototyping, running notebooks, etc. (imagine a bunch of tightly nit packages like numpy, scikit-learn you get the idea). This used to be the system python install before externally managed installs came along. Then tools like pyenv were used to create a venv with this environment and put it on the $PATH using pyenv global venv_name. But not all tools (like uv) use this approach, they tend to go with the traditional approach of having venvs inside the project root (and I like this approach).

What does "global" mean to you in this instance?

So a virtual environment that is used as a fallback for when a project specific venv is not present. Like how the system install used to be used when a venv was not activated back in the days.

updating PATH

This is the first solution that comes to mind, why not put it on $PATH?  For instance: now we have an environment on $PATH that can be inadvertently modified and cause all types of headaches.
Plus, we get one more problem with this approach: venvs created using the python on $PATH will now be pointing to a venv! And if you have been following this, you'll know it's a hot mess of symlinks pointing to symlinks, etc, etc (mainly due to a lack of PEP for this IMO). And there are many other small degradations to user experience in daily use with this approach.
So what we need is a way to locate/use this global venv without putting it on $PATH or forced to use a tool that pet supports. Reading $VIRTUAL_ENV also has the potential benefit of detecting a venv that is activated but not locatable by pet maybe due to its "unconventional" location, apart from being tool-agnostic (for users who choose to set it manually).

Also, I am exposed to pet via vscode and zed, which are editors. So whenever I open a data science script to have a quick look, I should not be expected to create a venv (each time, for a script) and then install those same packages repeatedly that I know I already have in a venv but the editor (actually pet) is not able to locate that even if I activate it.


Receipt Generator

Enter calculator name -
Receipt Generator
Describe calculator functionality -
Creating a receipt Generator
Under which category you wish to place it -

[ ] Computer Science
[ ] Mathematics
[ ] Physics
[ ] Chemistry
[ ] Biology
[x] Finance
[ ] Scientific
[ ] Health
[ ] Sports
[] Let project owner decide
[ ] Suggest a new category - (Answer here)

Kindly assign the issue to me

Hey @anushka-srivastava22,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\finance\receiptGenerator
Issue completion deadline - 15th Oct 8:00:00 am IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant


OR filtering between facets

https://trello.com/c/6TVdjgew/93-spike-work-out-options-for-how-we-might-continue-to-usefully-group-content-if-we-changed-the-finder-logic-to-work-like-other-fin

Preview app

http://finder-frontend-pr-1122.herokuapp.com/find-eu-exit-guidance-business

@steventux I guess this PR can be closed now, since it was just a prototype that's now been implemented?

Closing as this PR was intended to produce a Heroku prototype app


Updating Mods When Factorio Run Causes MMF Crash

crash-log.txt
This might be intended behavior, but I just want to point out that even with Factorio run without turning on any mods, when it tries to update mods (with deletion of old ones on), it crashes.
Possible solutions to prevent crash:

Somehow detect that factorio is not using any mods being updated, and bypass that error-throwing.

Keep the used mods for now despite the customized settings, and figure it out later.

Ignore these mods being used and warn the user.

Well I never designed ModMyFactory to work while Factorio is running.
I will look into displaying an actuall error message instead of it just crashing, but this is basically a non-issue.

Yes I agree, I just thought it shouldn't just crash but display error message as you said.


Installing mrv2 breaks theming in Pop!_OS.

Describe the bug
The installation somehow breaks theming completely, I track it down to the process gsd-xsettings stopping to work and initialize all-together, trying to execute the process manually prompts you with the error shown in the attached screenshot.
This happened to me several times until I was able to figure out the root cause, don't exactly know how or why it happens but installing Mrv2 1.2 causes this issue, the screenshot is from a virtual-machine with fresh Pop! installed that I was using to figure out what was breaking the theming.
To Reproduce
Install Mrv2 1.2
Expected behavior
No problems..
Screenshots

Desktop (please complete the following information):

OS: POP!_OS
Version 22.02LTS

First, are you running under Wayland or X11?  I would expect the issue to happen with Wayland, but not X11.
mrv2 patches:
/usr/share/glib-2.0/schemas/org.gnome.settings-daemon.plugins.xsettings.gschema.xml
as it would create problems on Ubuntu 22.04 LTS with Wayland.
You should be able to find the original non-patched file as, I believe:
 /usr/share/glib-2.0/schemas/org.gnome.settings-daemon.plugins.xsettings.gschema.xml.orig.mrv2
See if replacing it back fixes the issue and I will remove the patching from the installer.
When installing from dpkg or rpm, you should have gotten the warnings about it, like:
"Deprecated antialiasing found in $file"
"Must patch for newer Wayland."
Also, when you answer, please attach the orig.mrv2 non-patched file so I can compare it to Ubuntu's.

I'm running X11 but I did a refresh install since I couldn't fix the issue back then but the VM is giving me the error so I can try this, I'll come back with some updates soon.

I've updated the installer.   You can try downloading the latest v1.2.2 beta from:
https://sourceforge.net/projects/mrv2/files/beta/


Markdown parser enhancement

Handle tabs and soft/hard line breaks

Thanks for the patch.  With this patch, it looks like the length calculated for some text properties is -1, leading to an invalid argument error.  This can be reproduced using the following steps:
-------- x.txt ----------------
From `<stdio.h>`
Write formatted output to STREAM.
This function is a possible cancellation point and therefore not marked with \_\_THROW.
-------- x.txt ----------------

$ vim
 :pedit x.txt
 :wincmd P
 :set filetype=lspgfm

You should see the E474: Invalid argument error with the above steps.

Found the error, sorry for the mistake.
In the new PR I have fixed an old error as well.


how to parameterize the complex query options?

hi, i am tying to achieve something like below:
let complexQuery:IQueryBuilder<T>
for(eachQueryOption:IQueryBuilder<T> in queryOptions:Array<IQueryBuilder<T>>)
{
//each query option: whereGreaterThan(...,...)/whereLessThan(...,...)/...
 complexQuery += this.collection[eachQueryOption]
}
return complexQuery.find()

not sure how can i achieve this? thanks so much!

Hi! I'm not sure what you're trying to accomplish, can you expand a bit? thanks!


[WIP] Add GitHub workflows

This PR adds basic GitHub actions to run bazel targets as well as verify commit signing.

⚠ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).
If you're new to commit signing, there are different ways to set it up:
Sign commits with gpg
Sign commits with ssh-agent
Sign commits with 1Password

If you want to sign this and re-push, let me know when you are ready for merge.

@electronjoe Yes exactly, this was basically a test whether the signing checks works (as with tests, they should first be red :D ) and this seems to be the case!
So I checked and I updated the PR to remove my test for using the basic protobuf linter definition. Those definitions would require to:

rename the service Federaton to service FederationService which requires a lot of changes.
suffix all 0 enum fields with _UNSPECIFIED (since those will be the default values)

If you think this is reasonable, I'll reactivate this in a followup PR and fix the protobufs


synchronized local variables or parameters should be set to final

Signed-off-by: slievrly<EMAIL_ADDRESS>What is the purpose of the change
synchronized local variables or parameters should be set to final
Brief changelog
optimize synchronized obj
Verifying this change
ci
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4325 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4325      +/-   ##
============================================
- Coverage     62.93%   62.86%   -0.07%
+ Complexity      506      504       -2
============================================
  Files           769      769
  Lines         32995    32995
  Branches       5215     5215
============================================
- Hits          20765    20742      -23
- Misses         9831     9848      +17
- Partials       2399     2405       +6

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/apache/dubbo/common/bytecode/Proxy.java
72.22% <ø> (ø)
0 <0> (ø)
:arrow_down:

...he/dubbo/registry/multicast/MulticastRegistry.java
67.87% <100%> (ø)
0 <0> (ø)
:arrow_down:

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
95.45% <100%> (ø)
0 <0> (ø)
:arrow_down:

...apache/dubbo/common/extension/ExtensionLoader.java
79.11% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ache/dubbo/remoting/p2p/support/AbstractGroup.java
45.45% <0%> (-11.37%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyServerHandler.java
61.9% <0%> (-9.53%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

...onfig/spring/extension/SpringExtensionFactory.java
80.48% <0%> (-4.88%)
0% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
61.17% <0%> (-4.71%)
0% <0%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3a05c...bd8e8bd. Read the comment docs.


getLayerAttr("layerVectorPointData") returns incorrect data in Photoshop 2021 and 2022

We are using generator-core to create SVG files. getLayerAttr("layerVectorPointData") of generator-core returns incorrect data in Photoshop 2021 and 2022. The immediate zeros following the decimal point and the negative signs are getting stripped. This is resulting in the deformed SVGs. Following is the data from Photoshop 2022 and Photoshop 2020 to compare the values.
2022:
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
width="18px" height="19px">
<path fill-rule="evenodd"  fill="rgb(0, 0, 0)” d="M8.270,13.80 L9.99,12.260 C9.210,12.157 9.330,12.4 9.372,11.910 C8.723,11.867 8.56,11.559 7.501,11.4 C6.185,9.688 6.194,7.817 7.501,6.501 L11.30,2.980 C12.337,1.664 14.209,1.656 15.525,2.972 C16.849,4.305 16.849,6.176 15.533,7.483 L13.952,9.47 C14.123,9.662 14.123,10.320 14.12,10.953 L16.567,8.381 C18.438,6.509 18.456,3.843 16.559,1.938 C14.662,0.41 11.996,0.58 10.124,1.929 L6.458,5.595 C4.587,7.466 4.570,10.132 6.467,12.29 C7.14,12.585 7.638,12.952 8.270,13.80 ZM1.443,17.62 C3.340,18.959 6.6,18.942 7.885,17.62 L11.543,13.405 C13.423,11.525 13.440,8.859 11.543,6.962 C10.987,6.407 10.364,6.48 9.740,5.911 L8.894,6.757 C8.791,6.860 8.680,6.996 8.637,7.90 C9.287,7.133 9.953,7.441 10.509,7.996 C11.825,9.312 11.816,11.183 10.500,12.499 L6.980,16.20 C5.672,17.336 3.792,17.344 2.485,16.28 C1.169,14.687 1.161,12.833 2.477,11.517 L4.57,9.944 C3.886,9.338 3.878,8.680 3.998,8.47 L1.443,10.611 C0.436,12.491 0.462,15.157 1.443,17.62 Z”/>
2020:
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
width="18px" height="19px">

@swapnadnk it looks like the path data got truncated in your bug description.  Would it be possible for you to post a PSD file and code snippet that can reproduce this issue?

@mcilroyc here is the test.psb and code snippet
Archive.zip

Cory would you like us to submit a bug report for this for tracking purposes or has one already been made?

@samgannawayA I tried exporting an SVG using the standard "image assets" generator plugin and it seemed to work fine.  I added an .svg suffix to the layer name in your PSB, and then turned on File > Generate > Image Assets.  The output file looked right to me when I opened it in Photoshop. Can you confirm that works as you would expect, and does that help clarify the issue you're seeing in your own code?

@mcilroyc I added .svg to the layer as you said and turned on File > Generate > Image Assets. The output is still distorted and path data is truncated.

.


Add json decode/encode blocks to dictionaries/lists drawer

Description
Closes #2123
Adds blocks in dictionaries drawer to encode/decode JSON. These blocks will reuse the functionality implemented in JsonUtil (and already used by the Web component).
In dictionaries drawer:

[x] dictionary to JSON

[x] dictionary from JSON

In lists drawer:

[ ] list to JSON
[ ] list from JSON

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@ArjunInventor Thanks for the PR. Once you've addressed the discussion on the issue, please update this PR. Further, update the BLOCKS_LANGUAGE_VERSION in YaVersion.java and specify a no-op upgrader in versioning.js under blocklyeditor.

@ArjunInventor Thanks for the PR. Once you've addressed the discussion on the issue, please update this PR. Further, update the BLOCKS_LANGUAGE_VERSION in YaVersion.java and specify a no-op upgrader in versioning.js under blocklyeditor.

@ArjunInventor Thanks for the PR. Once you've addressed the discussion on the issue, please update this PR. Further, update the BLOCKS_LANGUAGE_VERSION in YaVersion.java and specify a no-op upgrader in versioning.js under blocklyeditor.

Sure, will do!

@ArjunInventor Thanks for the PR. Once you've addressed the discussion on the issue, please update this PR. Further, update the BLOCKS_LANGUAGE_VERSION in YaVersion.java and specify a no-op upgrader in versioning.js under blocklyeditor.

Sure, will do!


[FR] Ability to setup header for Json Request Body Example

Is your feature request related to a problem?
Our server works with a specific application/vnd.api+json header. And because of that we have no way to show our users a sample request body, because the library only handles application/json.
/packages/docusaurus-plugin-openapi-docs/src/openapi/openapi.ts:172

Describe the solution you'd like
I want to offer the possibility to customize which headers will be used for requestBody via plugin settings or something like that.
Describe alternatives you've considered
n/a
Additional context
Structure example:

Hi @johnnyswan, thanks for the feature request.
Expanding MIME support for both request and response is something we've discussed internally. My initial thought it that maybe we can find a way to detect/iterate through all available MIME types and give readers the option to choose which one to view. If we repurpose the Tabs component for this, it's possible we could even persist the user's choice in localStorage so it's automatically chosen throughout the documentation.

@sserrata How can I help you with this? Maybe you have some ideas or discussions so I can work with this and make a merge request

Thanks! Would it be possible to get a copy of the OpenAPI spec with the vendor MIME type (or an example)? I'm mainly interested in seeing if it's more or less compatible with our createSchemaDetails function.

You can find it here

Thanks! I might have a PR for you to preview soon. Will keep you posted.

Hi @johnnyswan, PR #195 is currently opened. Would like to get your feedback on whether or not it addresses the issues you were having. The UI/UX is not final but the solution appears to work, no matter what MIME type is presented. Thanks!
Here's a demo:
https://user-images.githubusercontent.com/9343811/183216849-6af529db-1778-4cbd-908a-77987293d099.mov

It's a good idea to show Tabs with MIME type selection. But we also need to fix the Body component that used in the ApiDemoPanel component. In the video that you provided you can see that this component is empty.

@sserrata Do you have a plan for fixing an issue that Johnny described? I mean, with an empty body, in the right block of the example

Hi @TarasMelnyk, yes, there's a fix on the way. Hopefully will be ready to merge today.

Making some progress...
https://user-images.githubusercontent.com/9343811/183656898-df5dbaf0-735b-45e9-844d-ec0fd1fb464c.mov

I appreciate your work on this

Canary release 0.0.0-418 has been published, with support for multiple content/mime types. Interested to hear your feedback on how well it works for you. Thanks!

Thanks. It works perfectly. I think it's a great solution because the user will always have information about the necessary header

The solution for a body works very well. But I found some regression, we update to 0.0.0-418, and all parameters in the request and response bodies now are marked as required but in the openapi file it does not have a "required" attribute and before the update, they were not marked as required

Thanks @TarasMelnyk, I was able to isolate the bug and opened #198 to address it. Going to do a bit more testing before merging but I appreciate any help. You should be able to pull the PR branch, run yarn build-packages and use the demo to test with your OpenAPI spec. Let me know if you have any questions. Thanks!

In my quick test it appears to be back to the way it was before the update:

Here's a new canary release to test with: 0.0.0-419


Suppress ComplexWarning

See log:
08:42:43 =============================== warnings summary ===============================
08:42:43 tests/cupy_tests/padding_tests/test_pad.py::TestPad_param_0::test_pad
08:42:43   /usr/local/lib/python3.4/dist-packages/numpy/lib/arraypad.py:1066: ComplexWarning: Casting complex values to real discards the imaginary part
08:42:43     arr = np.round(arr).astype(int)
08:42:43   /usr/local/lib/python3.4/dist-packages/numpy/lib/arraypad.py:1066: ComplexWarning: Casting complex values to real discards the imaginary part
08:42:43     arr = np.round(arr).astype(int)
08:42:43
08:42:43 -- Docs: http://doc.pytest.org/en/latest/warnings.html

This problem is solved by #689 and #688.


Setting to get cargo proxy info from git?

cargo depends on a working git (in most cases).
git only works if the proxies are set up correctly.
Would people like / object to a cargo setting that says read git's proxy settings and use them?
Why: In a corporate env with various different proxy setups you would have a .cargo/config that would be portable between them.
At the moment it all feels not as simple as it could be to get everything up and running...
For users they typically have to set up HTTP_PROXY, .cargo/config's proxy settings and git's proxy settings before they're up and running. It would be great if we could tell cargo to just piggy back off git's proxy settings (which it depends on anyway).
Keen to hear people's thoughts.

Cargo should honor the http_proxy environment setting for all network operations.  I don't think Cargo would want to look at the git configuration for non-git operations, that seems like it could be confusing.  Perhaps I'm misunderstanding what you are asking?
It does appear that Cargo ignores git's configuration, though.  It may be as simple as setting ProxyOptions::auto, though it may be tricky to coordinate with Cargo's own proxy handling.  However, even if Cargo did honor that, the user would still need to configure proxy settings for non-git operations.

Hello. I feel it necessary to set specific proxy for github.com.
In most case, we can switch crate source to somewhere near us. I can connect to my crate source without proxy.
But I also need a specific proxy to github because of some network problem.
For example, something like this in ~/.gitconfig
[http "https://github.com"]
  proxy = socks5://<IP_ADDRESS>:1080
[https "https://github.com"]
  proxy = socks5://<IP_ADDRESS>:1080


Issue with CySimpleEllipseDispatcher During Test Case Execution

I am currently testing the RidePy project and have encountered an issue with the CySimpleEllipseDispatcher during the execution of the test case test_same_location_with_detour. The installation was verified following the instructions provided, but the test case fails with an assertion error. I would really appreciate if you could please help me resolve this: Below are the details:
Environment
OS: macOS
Python Version: 3.9.19
RidePy Version: Latest from the repository
Below is the output of the test case:
================================================================================================ test session starts ================================================================================================
platform darwin -- Python 3.9.19, pytest-8.2.2, pluggy-1.5.0
rootdir: /Users/bhagyashritushir/PycharmProjects/ridepy/ridepy
configfile: pytest.ini
plugins: hypothesis-6.104.2, anyio-4.4.0
collected 9 items
test/test_simple_ellipse_dispatcher.py .....F...                                                                                [100%]
===================================================================================================== FAILURES ======================================================================================================
______________________________________________________________________________________ test_same_location_with_detour[cython] _______________________________________________________________________________________
kind = 'cython'
@pytest.mark.parametrize("kind", ["cython"])
def test_same_location_with_detour(kind):
    # fmt: off
    # location, cpat, tw_min, tw_max, occupancy
    stoplist_properties = [
        [(0, 0), 0, 0, inf],
        [(0, 1), 1, 0, inf],
        [(0, 1), 1, 0, inf],
        [(0, 5), 5, 0, inf],
        [(0, 5), 5, 0, inf],
    ]
    # fmt: on
    eps = 1e-4

    request_properties = dict(
        request_id=42,
        creation_timestamp=1,
        origin=(0, 1),
        destination=(0, 5),
        pickup_timewindow_min=0,
        pickup_timewindow_max=inf,
        delivery_timewindow_min=0,
        delivery_timewindow_max=inf,
    )
    (
        space,
        request,
        stoplist,
        _,
    ) = setup_insertion_data_structures(
        stoplist_properties=stoplist_properties,
        request_properties=request_properties,
        space_type="Manhattan2D",
        kind=kind,
    )
    min_cost, new_stoplist, *_ = CySimpleEllipseDispatcher(loc_type=space.loc_type)(
        request, stoplist, space, seat_capacity=10, max_relative_detour=1
    )

    assert min_cost == 0
    assert new_stoplist[1].location == request.origin

  assert new_stoplist[-3].location == request.destination

E       assert (0.0, 1.0) == (0.0, 5.0)
E
E         At index 1 diff: 1.0 != 5.0
E         Use -v to get more diff
test/test_simple_ellipse_dispatcher.py:355: AssertionError
================================================================================================= warnings summary ==================================================================================================
src/ridepy/init.py:1
/Users/bt/PycharmProjects/ridepy/ridepy/src/ridepy/init.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
from pkg_resources import get_distribution, DistributionNotFound
../../../../../opt/anaconda3/envs/ridepy/lib/python3.9/site-packages/pkg_resources/init.py:2832
/opt/anaconda3/envs/ridepy/lib/python3.9/site-packages/pkg_resources/init.py:2832: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('sphinxcontrib').
Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
declare_namespace(pkg)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================================================== short test summary info ==============================================================================================
FAILED test/test_simple_ellipse_dispatcher.py::test_same_location_with_detour[cython] - assert (0.0, 1.0) == (0.0, 5.0)
====================================================================================== 1 failed, 8 passed, 2 warnings in 1.29s ======================================================================================

Thanks for posting this, looks strange indeed. I will look into this.

@fxjung Thanks. Looking forward to it. Let me know if you need more information.

I have just tried to reproduce the problem, and unfortunately failed. Under Linux, using the exact same Python version, the test passes. Have you created a fresh virtual environment? If not, you could try to do so. Also, if you have a Linux or Windows installation at hand, you could try to see whether the error persists there.
Could you please post the output of pip freeze in the environment you were using? Maybe this caused by some change in a third-party package...


Simplifies theme next storybook toolbar

We're going to introduce 3 different toggles for theme next, which can be too wide for small screens for ease of use. Add as a single list.

[x] For some reason, prod build this doesn't show up

@origami-z is this still something being looked at?

@origami-z is this still something being looked at?

Worked now, not sure whether this is actually better lol


Set Maximum size of all iframes

Iframe 등의 동영상의 최대 사이즈를 640px x 480px로 제한함.

@yous any ideas?

Does this code keep the aspect ratio of iframe?

maybe, yes i think

Then I think it's okay.


⚠ Bofrost.at has degraded performance

In ce8b9ae, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1511 ms

Resolved: Bofrost.at performance has improved in 41b817a after 1 hour, 5 minutes.


Unable to use getProperty function

I am unable to use the getProperty function on JSON object

I am unable to use the getProperty function on JSON object to get the value
I am using Azure Rest API which returns me the response I am able to use jPath to retrieve this json
{
  "lgType": "Activity",
  "text": [
    "ABC",
    "rg-cddb",
    "DefaultResourceGroup-eastus",
    "NetworkWatcherRG",
  ]
}

Now I want to only get the text element so I can use the array. I used getProperty but it does not work.
2.1.2

emulator

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS
windows 11

[ ] macOS
[] Windows
[] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

@rajaniesh - I will take a look at this and attempt a repro. I will let you know what I find.

@rajaniesh - I will take a look at this and attempt a repro. I will let you know what I find.

Yes, it is really stopping my work and I want to finish it. I am calling a Rest API which will me this output but when I try to use the output in the multi-choice it si not displaying the list of items.

Im also trying to do something similar but its not working for this scenario
Also having trouble with jpath expression

@rajaniesh - I'm wondering if the multi-choice prompt is displaying before the API has returned a response. If so, you may need to use a loop to test if the response has been returned before displaying the prompt.
Can you test the following:

Take the REST API response and hard-code for use in the multi-choice. Does that work?
If the above does work, can you implement a loop that checks for the response before continuing on to display the prompt?

Closing due to inactivity.


Add GraphData attribute to datagraphs

Currently, DataGraphs.jl supports NodeData and EdgeData, but it does not support saving GraphData. Need to add a struct for GraphData and corresponding APIs

Also should add an API for getting a subset of the NodeData or EdgeData


Update Semantic UI React to version 2.1.5

@ichim-david @pnicolli @tiberiuichim @davisagli I checked the changelog and seems safe. Even for 17, I'd say. What do you think?
The version we are using is broken when used with TS.

@sneridagh I am testing this change on Volto 16.30.1 and so far no crash anywhere throughout my local development.
As such I see no issue porting the change also to the 17.x.x branch.
Maybe wait a bit longer to see also what the guys from RedTurtle reply and if they have checked their demo project how the upgrade behaves

@plone/volto-team any feedback yay or nay? :)

@ichim-david I'd say we merge this for 18, then wait for more feedback before backporting it to 17.


Planks + Creosote infusion yields unusable Treated Planks

Clearly some other unused forms of treated planks are being added to the ore dictionary - a good reason to add the ability to specify specific registered items in recipes.

Fixed!


Request for integration with Honeycomb

Is your feature request related to a problem?
We use honeycomb as our observability tool for Trace currently.
Having an integration for Honeycomb with Playbook will help us  add more context during investigation of an issue.
Describe the solution you'd like
We would like to have an integration of playbook with Honeycomb
Describe alternatives you've considered
We currently don't use Playbook with Honeycomb as there isn't an integration available.
Additional context
Add any other context or screenshots about the feature request here.
Thank you for your feature request!

Hey @AkshayD110,
I am working on this issue. I have 2 questions that will help me assess the priority for this.

What are you looking to query from Honeycomb as part of a Playbook?
Is your organisation using Enterprise version for Honeycomb? Currently, they allow querying the traces data via an API only in their Enterprise version.

Thanks

Closing this for now as we couldn't get a sandbox for Honeycomb to test out the APIs. If anyone is interested to pick this up or request this, please re-open it.


Make system test deterministic in how many compactions and splits are performed

During the system test, the timing of when compactions are created can result in a different number of compactions being run. This has a big impact on the observed rate of compaction. We could remove this variance by explicitly triggering compaction job creation instead of letting the scheduled function run.
See also the comments on https://github.com/gchq/sleeper/pull/313

The current system test is useful as it is as it allows the system to perform as it normally would, and allows manual testing of stacks such as the query stack. Can we leave the system test script as it is (maybe call it system test-all), and create another system test script (systemtest-compaction-speed-test) specifically for testing compaction speed? That script can cut down the stacks that are deployed to the bare minimum (e.g. no QueryStack). I suggest initially not deploying the PartitionSplittingStack and just testing the speed of non-splitting compactions.


[BUG] ExpressRoute CrossConnection Azure Ports not writable

API Spec link
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/network/resource-manager/Microsoft.Network/stable/2024-03-01/expressRouteCrossConnection.json
API Spec version
2024-03-01
Describe the bug
As stated inside the ExpressRoute documentation, it should be possible to change the PrimaryAzurePort and SecondaryAzurePort of a ExpressRoute CrossConnection.
Although, they are defined as read-only
See: https://learn.microsoft.com/en-us/azure/expressroute/circuit-placement-api#move-a-target-expressroute-circuit-to-a-specific-port-pair
This is especcially a problem when using the Azure SDK for .NET since there is no way to change the Ports without the properties being writable.
I already created the PR #31478  for this but i am not sure if people outside Microsoft are allowd to merge changes into this repo.
Expected behavior
The PrimaryAzurePort and SecondaryAzurePort of a ExpressRoute CrossConnection should be writable.
Actual behavior
The PrimaryAzurePort and SecondaryAzurePort of a ExpressRoute CrossConnection are readonly.
Reproduction Steps
Look at the API Spec. There the properties are set to read-only.
Environment
No response

@GuptaVertika please help take a look, thanks.


[11.x] Introduced ensure() helper method

As generics and static analysis tools like PHPStan are increasingly getting more popular, this ensure() method can help with mixed return types. A clear example is in Form Requests, where you can resolve the authenticated user, but the framework theoretically can return null:
class ProfileUpdateRequest extends FormRequest
{
    public function rules(): array
    {
        $user = $this->user();

        return [
            'username' => ['required', Rule::unique(User::class)->ignore($user->id)],
        ];
    }
}

You may overcome this by type hinting the variable or by using assert(). I saw the latter being used in Pinkary, which passes PHPStan at level max:
/** @var User */
$user = $this->user();

// or

$user = $this->user();
assert($user instanceof User);

The ensure() method is more strict like assert(), but its main advantage is that it returns the value. Due to the generics, PHPStan and IDEs understand that the return value is of the expected type.
$user = ensure($this->user(), User::class);

I named it ensure as there's a similar method on the Collection class.

If this would pass, I'd expect it to behave more similar to the ensure method on the Collection class...

I do think people would expect this to have parity with Collection@ensure at least.

I've updated the PR so it supports multiple types and scalar types:
ensure(10, 'int');
ensure([], ['array', Collection::class]);

Talked a bit about this with @nunomaduro and we're going to table this idea for now. Feel free to ship a package that provides this type of thing!

Totally understandable! For future readers: check out type-guard


Funding 2021: Created Astroquery Maintenance proposal

This is a proposal to support maintenance of astroquery.
It's current a work in progress - I don't have final $ requests yet.  I'm submitting the WIP to make sure this is really what was intended in the instructions sent by @hamogu.

This looks very much on track to me -- thanks for getting things started!
Regarding the actual idea, I think it would be useful to know if this funding would be to support about the same amount of time that y'all are already dedicating or if this funding would enable some of you to dedicate more time. Either way, I think it will be a very compelling, I would just like the expectations to be as clear as possible.

Alright, we can add that.  For me, it's same amt of time.  For Brigitta and Clara, we're still working that out - but it's not clear we'll know the payment path (and therefore the funding requirements and available time) by March 20.  If we put in a ballpark estimate, can we iterate on the total commitment with the finance committee later?  Is it better to over- or under-ask, for your planning purposes? (of course, an exact number is best, but that may not be available)
Is this the right folder / location in this repo to put the document?

I think it would be best to give the range. E.g., bracket the budget and let folks know the range of the potential cost. At this point, I think it's most important that the community have a good sense of the order of magnitude of what is being requested. The implementation details and exact costs can be worked out with the finance committee later.
I don't currently have any opinions about the location of these PRs.

Is this the right folder / location in this repo to put the document?

Yes, this is a good location. 👍

@kelle  For me this would be the same amount of time, just next year I won't be supported by STScI for the work as I am now (starting a PhD program).

My part from this maintenance proposal is included in #192 along with new projects for astroquery. This is in agreement within the maintainer group for easier logistic, the two PRs are not in competition with each other and could be merged if preferred.

Please react to this comment to vote on this proposal (:+1:, :-1:, or no reaction for +0).

Congratulations @keflavich!  This proposal has the support of the Astropy Community and has been awarded  $27,200 to implement.  This PR will be merged, and you can contact<EMAIL_ADDRESS>or reach out on Slack to arrange financial details (see more details in the email to astropy-dev).


Implement POST /v2/flush

Coverage: 89.62% (+0.5%) from 89.133% when pulling 3193d697880de7742c027181a4177818f43f2680 on add-flush-endpoint into d26b27aad25b7ad7389be3b85aad221a8a0b9382 on extract-cache-directions-calculation.


Approval on environment when the process is skipped

When setting up an approval on a environment. The approval is checked before the condition added to the job.
I think the condition should be run first before the approval.

I faced this issue this morning and I share @maikvandergaag thinking. If condition is evaluated first, and the environment is skipped, then there is no need to request approval.
My use case is a CI/CD process where CI is also use as PR validation.

i need that feature, now i am realizing that it may be a problem, because i have several deployment setup in the pipeline, each with its own condition and environment and when the pipeline is activated by the PR, azure asks for approval in every environment when only one approval is needed.
The only workarount that i found is splitting the yml


chore(deps): update Skia to fix XCode 12 bug

Picks up revery-ui/esy-skia#25
Fixes #2508 and #2550

Awesome - thanks for investigating and unblocking this, @zbaylin ! 💯


Suggestion: Layered items in the layouts

If possible add the ability to add multiple items to one space similar to quest helper plugin:
Example:
Weapon: Whip > Dragon Scim > Brine Saber > Rune Scim
If whip is missing it will display dragon scimitar and so on.
Glory (6) > Glory (5) > Glory (4)
If you don't have a glory 6, it will display a 5 and so on.

I would love a feature of displaying degradable/charged items to only display item with least charges.
For example a ring of dueling, I would only want it to pick the lowest charged one it can find in the tag collection, whereas now I have an entire row of rings in my layout


tropical cyclone TH

Noting the BUFR sequence under validation for tropical cyclones (https://github.com/wmo-im/BUFR4/issues/201) we do not have a WIS2 topic. To start the conversation I'd like to propose:
./weather/prediction/forecast/specialised-products/deterministic/tropical-storm-tracks
./weather/prediction/forecast/specialised-products/probabilistic/tropical-storm-tracks

cc @sebvi for info.
Previous discussion here: https://github.com/wmo-im/tt-nwpmd/issues/12

@sebvi @david-i-berry - this is the proposal from TT-NWPMD:
Add trajectory topic as a sister to global and limited-area topics at the last level.

/weather/prediction/forecast/medium-range/deterministic/trajectory
/weather/prediction/forecast/medium-range/probablistic/trajectory
/weather/prediction/forecast/short-range/deterministic/trajectory
/weather/prediction/forecast/short-range/probablistic/trajectory

update branch and create PR for FT2024-2

@wmo-im/tt-nwpmd  -- Trajectory topic needs a definition.
@sebvi @yhonda21
Name,Description,Source
global,A prediction system that covers the entire globe,
limited-area,A prediction system that does not cover the entire globe,
trajectory,tbd,

TT-NWPMD meeting notes:
The team likes using the IMV vocabulary but has some suggestions for revising the definition slightly to be more generic. @amilan17 to find out if it's possible to update IMV.

@amilan17 update description and open PR

combine 1 & 2 --

Line in space tracing the successive positions of a moving particle in the air or the centre of a weather system.
Eunha will double check with english editor.

@EunhaLIM @sebvi I updated the branch with the following definition. I decided to not use the air mass one.
trajectory,"Line in space tracing the successive positions of (i) moving particles in the air, such as radioactive particles from a nuclear accident or (ii) the centre of a weather system, such as a tropical cyclone.",

CORRECTION:
@EunhaLIM @sebvi I updated the branch with the following definition. I decided to not use the air mass one, because I think "positions" could be represented as an air mass. I also changed "tracing" to "representing" because this is under the prediction topic.
trajectory,"Line in space representing the successive positions of (i) moving particles in the air, such as radioactive particles from a nuclear accident or (ii) the centre of a weather system, such as a tropical cyclone.",

TT-WISMD 2024-10-22:

@tt-wismd to provide feedback in next 1-2 days on #184


Ability to create a "report" containing simplified list of resources + status on every cycle

So we can get a view over the whole day about which resources were found, and whether they were running.  The resources CSV (with append=true) is close, but doesn't have a timestamp.

Solved by PR


[release-1.5] Add missing required CNI fields to helm charts for Openshift 4.3.5

Similar to https://github.com/istio/installer/pull/669/files but for release 1.5

cc @fpesce
This would be considered a regression of someone were to upgrade from 1.4.8 to 1.5.2.


Review transactions

Changes:

changed new public methods to be closer to the existing non-transactional methods
removed some transactional methods that don't have non-transactional counterparts or cannot be atomic
moved documentation to the main README.md file
added more specs

@ckhsponge
Finally I am ready to release this new transactions API. Thank you for your contribution!
There are still a few small items in my TODO list for the next release so it will take some time.

@andrykonchin I'm looking forward to it! I have some projects running now that use transactions and I'd be happy to test a release candidate if you want.

Yeah, it will be great!


release planning: v1.18.0

See milestone at https://github.com/sparklemotion/nokogiri/milestone/32
Keeping the scope of this release pretty small because time is tight.

[x] drop Ruby 3.0, add Ruby 3.4 - #3273

[x] drop Ruby 3.0

https://github.com/sparklemotion/nokogiri/pull/3368

[x] #3369

https://github.com/sparklemotion/nokogiri/pull/3374

[x] add Ruby 3.4

[x] https://github.com/rake-compiler/rake-compiler-dock/pull/130
[x] release rake-compiler-dock 1.6.0 dropping manylinux
[x] use rcd 1.6.0 and ship musl native gems - https://github.com/sparklemotion/nokogiri/pull/3375
[x] revert musl compat hacks - https://github.com/sparklemotion/nokogiri/pull/3384
[x] release rake-compiler-dock 1.7.0 adding ruby 3.4

[x] https://github.com/rake-compiler/rake-compiler-dock/pull/131

[x] https://github.com/sparklemotion/nokogiri/pull/3376

focus on performance improvements

[x] #3266

[x] https://github.com/sparklemotion/nokogiri/pull/3378

[x] go through other candidates

not going to add any more scope at this time

remaining hack day / kwarg PRs and methods

decided not to do this in 1.18

Released v1.8.0.rc1: https://github.com/sparklemotion/nokogiri/releases/tag/v1.18.0.rc1

Release v1.18.0 / 2024-12-25 · sparklemotion/nokogiri


Update theme_text_entry_line.rst

I noticed that the "text_entry_line" working colour option "normal_bg" is instead "dark_bg".

Well spotted. I should probably also update the image in the docs which has the same error.


Check function: exportCharacterizaton

Function documentation in order with SRS (Roxygen2)
Functionality in order with function documentation
Unit test in order with TestPlan (usethis, testthat)
Code review of function (other dev than whoever picked up this ticket) (lintr)

Could replace with:
CohortDiagnostics:::exportCharacterization

Function is deperecated


Fully Support Semver Versioning (for prerelease)

Both cocoapods and carthage allow alpha and beta versioning, but the fastlane tools currently won't allow bumping versions that conform to that.
For example, 3.0.0-beta.1 is not a supported version in fastlane, but is supported with cocoapods and carthage.
I think this would be a two step process:

Replace the regex in the multiple actions that pull out an existing version number. There is an example of semver regex here.
Update the actions that take in a bump type parameter.

Currently, the bump types are major, minor, and patch. The tricky part will be a sensible description for the prerelease bump type. I don't have a good idea yet, but wanted to open this issue in hopes someone else did.

This is a great point @kcharwood! We will mark this as a feature request and hopefully get to it for a release in the near future. If you would like to submit a PR to make this change that would be amazing. Let us know and we would be happy to help! I am going to close this issue for now, and feel free to reopen it if you want to discuss implementation or we will reopen when we get to it. Thanks!! :ocean: :octopus:


npm error: npm ERR! invalid<EMAIL_ADDRESS>

I keep receiving the following invalid error when I try to install zone.js:
Command:
$ npm list --depth=0

└──<EMAIL_ADDRESS>invalid
npm ERR! invalid<EMAIL_ADDRESS>/Users/my-username/my-repo/node_modules/zone.js

My package.json shows:
"zone.js": "~0.6.17" in dependancies section
I have tried everything from removing zone.js and doing an npm install with my package.json (zone.js version ~0.6.17) and even putting zone.js : "*" which then installs 0.6.26 and still shows invalid.
Because the github repo shows latest version as .25 but npm shows latest version as .26, I also tried setting it manually to zone.js : "0.6.25" but this then shows the error as the same, but with the .25 version:

npm ERR! invalid<EMAIL_ADDRESS>/Users/my-username/my-repo/node_modules/zone.js

I have also removed my node_modules folder completely and done npm cache clean
Nothing seems to get rid of the invalid error
System: Macbook Pro 15" running OSX El Capitan v 10.11.6
npm version (using nvm): v6.3.1, but also tried v6.9.0

+1


OCaml 4.06.0 compatibility fix

Since OCaml 4.06.0 the -safe-string has been turned on by default, meaning that strings are immutable (by default). As a further consequence it is no longer meaningful to use strings as mutable character buffers.
This patch uses a bytes buffer rather than string.

Could you merge this, please?

Sorry, i just saw this PR. I'm no longer maintaining this project. I'm happy to give the commit rights to whoever wants to maintain it

Any news about merging this by the way?

Still the same, I'm no longer maintaining this project. Moving forward, you can switch to one of the following project that is still maintained:

cppo: https://github.com/mjambon/cppo
ppx_optcomp: https://github.com/janestreet/ppx_optcomp

Alternatively, I'm happy to transfer the project to whoever would want to maintain it.


Dotenv license compliance

https://github.com/motdotla/dotenv/tree/master?tab=BSD-2-Clause-1-ov-file#readme
Probably there will be reused bits so it's appropriate to recite the BSD-2-clause notice some way.

Hopefully addressed by https://github.com/2colours/toml-env/commit/fb9a2bdc81bff2eb49bcb3c4a6fa03362a798c8a


Console Error when UpArrow is pressed in emoji picker - reported by @sobitneupane

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Emoji Picker.
Press down arrow to highlight emoji.
Now Press UpArrow

Expected Result:
there should be no console errors
Actual Result:
Console error when press UP
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.1.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/161472017-7505293f-c879-4b63-b987-9c38648641e7.mov
Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648122317605959
View all open jobs on GitHub

Solution:
Proposing solution as I reported this issue.
As the error statement suggests, error is occuring in following code segment. Addition of the following lines of code will solve the issue.
https://github.com/Expensify/App/blob/6e9d429ad47044d71cb028fb14d5defc2de0af8a/src/components/EmojiPicker/EmojiPickerMenu/index.js#L256-L259
           do {
               newIndex += steps;
+               if (newIndex < 0) {
+                   break;
+               }
           } while (isHeader(this.state.filteredEmojis[newIndex]));
       };

Hello @Justicea83 @NicMendonca, Looks like code was deployed to production 9 days ago. Waiting for my payment.

@sobitneupane sorry! Can you please apply for the job so we can issue payment: https://www.upwork.com/jobs/~018897a01f0bd438e7

@sobitneupane sorry! Can you please apply for the job so we can issue payment: https://www.upwork.com/jobs/~018897a01f0bd438e7

Applied.

paid!


No autorization for Discover method

Hello,
When running the cript I have an error with Tabular Editor 2.25 saying that I have no autorization to call Discover method. It induce taht all BIM files are not downloaded and linked analytic is missing :-(

This should be ok and is expected if it's not a premium workspace or you don't have permissions within the workspace.
The later steps handle this by downloading the model via a PBIX report and extracting the BIM using PBI-tools within the config folder.
At the very end, do you see a bim file in the Model Backups folder or within the Power BI governance model, is the model an option to explore?

C:\Power BI Backups\Model Backups<Date> folders are all umpty :-(
Perhaps linked to line 548
547           Write-Output "Generating .bim for $cleanWorkspaceName ~ $cleanReportName using $driveLetter"
548            pbi-tools generate-bim $driveLetter -transforms RemovePBIDataSourceVersion
Is $DriveLetter the correct variable as there is no reference to the Bim file we want to generate within pbi-tools command line?

Yes - When using PBI-Tools alongside the 'Workspace Name ~ Report Name.pbix' format, when the report is extracted to a folder structure, it sometimes will go beyond the 255 character limit within Windows.
The script helps get around this by creating a temporary Q drive and extracting the pbix files to the base Q:\ instead of C:\Power BI Backups\Report Backups Backups\Date\Report Name

Great to hear!
For clarity, 'Download Reports' and 'Export to Excel' are enabled in organizations by default within the tenant admin settings. (I recently set up a new tenant to understand what is enabled by default and help ensure this works for the majority of people)
However, only 'Download Reports' is required to be enabled. 'Export to Excel' can be disabled and the script run without issues. I just tested this.

Closed and resolved!

Discover Method errors are due to not being a Premium, Fabric, or PPU Workspace. This is not an issue because the script handles Pro workspaces later in the script.
'Download Reports' should be enabled within the Tenant settings. This is enabled by default within the Tenant - and if disabled, no user can download reports or models from the Power BI (i.e. it would be rare to have this disabled since it means no one in the org can download PBIX files, even developers).

Closed and resolved!

Discover Method errors are due to not being a Premium, Fabric, or PPU Workspace. This is not an issue because the script handles Pro workspaces later in the script.

'Download Reports' should be enabled within the Tenant settings. This is enabled by default within the Tenant - and if disabled, no user can download reports or models from Power BI (i.e. it would be rare to have this disabled since it means no one in the org can download reports from workspaces, even developers).


Add an isTouching() method

Method should have two possible parameters:
isTouching(x,y);
or
isTouching(sprite);

Did we solve this?

I thought I remember you texting me about it.

We never added it... But someone on Stack Overflow wrote a pretty good solution which still needs to be modified and implemented with Scratch-JS
However, I think we should work on more core / essential features for now (mouse click and key press events, lists, costumes and more pen functionality), and focus on more time consuming and non essential features.
I'm gonna create a new milestone for us with various task issues so we can keep track of everything.

K.

Bump

Whats the overflow link?

http://stackoverflow.com/questions/40952985/how-can-i-check-if-two-partially-transparent-images-intersect-touch-each-other

Yeah, I have no idea how to use that either.

http://stackoverflow.com/questions/26834244/how-do-i-test-if-two-img-are-touching-each-other

haha... It's hard but try your best to make it work or comment on his answer asking for clarification or whatever.
We really need this feature.

No, that link is for something else. Based on that answer we would only be able to check if they outlines of the image elements, not the actual non-transperent parts.


Iterator for Character

Character::begin, Character::end etc.

Character will not have iterator. Instead, it contains code point sequence which have iterators.


[NFC] Add display name for custom React components

This improves readability of "Components" tab from React Development Tools extension for Chrome

Cool. This seems to work just fine. Merging!
Thanks.
Since you're making a revisit to the project, we've been trying to make sure any PRs have an Issue made for them first to allow for discussion and feedback. We had a big string of PRs recently that people put a lot of time into but weren't solving any existing issues, and ended up needing a different direction or weren't working properly due to unforseen conflicts, with upcoming features, etc. We're hoping to reduce wasted work for both contributors and reviewers.

Since you're making a revisit to the project, we've been trying to make sure any PRs have an Issue made for them first to allow for discussion and feedback. We had a big string of PRs recently that people put a lot of time into but weren't solving any existing issues, and ended up needing a different direction or weren't working properly due to unforseen conflicts with upcoming features, etc. We're hoping to reduce wasted work for both contributors and reviewers.

Thanks! Noted


Bug in Reliability Diagram

The ReliabilityDiagram creates bins with values which are not in the input.
Code to reproduce it:
import numpy as np
import matplotlib.pyplot as plt
from netcal.presentation import ReliabilityDiagram
# Generate true and predicts values
y_true = np.random.randint(0, 2, 100).astype(np.float32)
# Generate perfect predictions:
y_pred = y_true.copy()
n_bins = 10
diagram = ReliabilityDiagram(n_bins)
_ = diagram.plot(y_pred, y_true)

I experienced the same issue. A quick fix is to just comment line 291 and 292 in ReliabilityDiagram.py
https://github.com/EFS-OpenSource/calibration-framework/blob/82e65dc225c7b4443dcd748836ed6b302af12fd2/netcal/presentation/ReliabilityDiagram.py#L291
https://github.com/EFS-OpenSource/calibration-framework/blob/82e65dc225c7b4443dcd748836ed6b302af12fd2/netcal/presentation/ReliabilityDiagram.py#L292

Hi @cdiazbas, at the time of development, this was intended behavior since missing bars might be confusing. But I see your point that bars might be misleading which have no underlying data. I will think about it and proabably add either an option to disable this behavior or to mark "empty" bins as such. Thanks for raising attention.

Since this is not a bug, I close this issue for now.


Validate Item ID Uniqueness

When loading items, the item IDs should be validated to not cause interference with other mods or the base game. The simplest solution that does take performance into account would be to populate a HashSet with existing item IDs and throwing an exception when attempting to add an item with an ID that's already registered.

Don't think we've got a local AllItems dictionary, so would need to implement that but wouldn't be difficult.
Would probably be then a case of having an explicit 'Replace' directory which tries to replace loaded assets for replacing base items.


Implement a simple policy for deleting old DWHs snapshots

Currently the way that the controller handles incremental runs is by recreating another copy of DWH each time. We need to have a simple policy for deleting old DWHs not to consume too much disk space.

Documented the solution here

Documented the solution here

@chandrashekar-s does this cover the re-creation of new dumps for every time the pipeline is initiated manually?

@ageryck Thanks for your question. Yes, the solution should take care of this re-creation scenario as well. It just treats the newly re-created snapshot as the latest snapshot and the old snapshots will be deleted as per the retention policy. I have added this as a note to the solution doc.

Bumping to P1 based on need.


build failed

This project is using an incompatible version of the Android Gradle plugin.
To continue importing this project (Jetcaster), Android Studio will upgrade the project's build files to use version 4.2.0-alpha12 of Android Gradle plugin (you can learn more about this version of the plugin from the release notes).

Thanks for the bug report, this will be fixed in #192


Update Policy

as found on a rdp site on a big funiture company.

I personally find this list too long and detailed. IMHO the list should only provide a general guideline of relevant vulnerabilities. Also, I disagree with some of the criteria. In general I would consider a vulnerability that can be used for DoS as relevant. I tried to include the essence of the list in a78397585bd33f5653fe1654038aab5b805acca1


Localization updates for 4.0.0

Commit<PHONE_NUMBER>4fcd0145e9babb822285407f5092a8 only documentates the -profile switch for the english/default message properties file, but not for the localizations.
Localizations need to be updated by maintainers:

[x] English
[x] German (@tofi86, #599)
[x] Japanese (@takahashim, #598)
[ ] Spanish (@Cuadratin, #612, #592)
[ ] French (@vincent-gros)
[ ] Italian (@pettarin)

There are also another couple of new and changed text strings. Have a look at the Transifex system for epubcheck translation (#479, https://www.transifex.com/idpf/epubcheck/) to identify the new/changed text strings and create a PullRequest with your changes.
With a Transifex account you're able to either translate the strings in their webapp or identify the changed/new strings and add them to your PullRequest.

when translating messages, especially in com/adobe/epubcheck/messages/MessageBundle.properties, make sure you have the History tab opened on the right in Transifex so you can see previous translations for the current message.

This is useful in case @rdeltour only changed a word in the message but not the whole message itself...

Japanese updates from PR #598 were suqashed and merged to master in 4c32d1b

Hi all. I'll prepare a bugfix release soon (say at the end of next week). I'd like to include any localization update contributed so far. Please let me know if there's anything ongoing before I release. And thanks all for the contribs!

People from LIA/AIE stated that they will take care of the Italian translation (here and at Readium), so I am calling myself out of this task.

@pettarin ok, thanks for the info. Any contact info? Are they following this thread or the epubcheck list? I basically want to make sure they don't miss the 4.0.1 opportunity...

It is not clear to me who is in charge of what over there. Asking the Italian member of the IDPF board might help. (If I remember correctly, it was their spoke person who tweeted me that they would have taken care.)

@pettarin ok, thanks!

Just wrote messages to the other Transifex translatiors and asked for their contribution until Oct. 7
So last but not least asking @vincent-gros, @tledoux, @rdeltour whether the three of you see any chance to finish the french translation on Transifex? Thanks :)

@rdeltour Sure, you are welcome. BTW, here in epubcheck (generic)you are using the "ping the prev translators/public call for translations (with deadline)" that I suggested for Readium ( https://github.com/readium/readium-js-viewer/pull/40#issuecomment-38809647 ) but AFAICT there it has not been adopted yet. Since I understand (DAISY)you are in both projects, you might want to push it forward. Just saying. Bye.

@tledoux, @rdeltour I can finish the french translation this weekend if iit is needed.

@tledoux, @rdeltour I can finish the french translation this weekend if iit is needed.

Great, thanks Vincent! Let me know if you need help...

@vincent-gros Thanks! I think it's the best to finish the translation on Transifex. Otherwise you'll have to watch the file and character encoding closely, as some files are UTF-8 and some not and you would have to manually escape non-ASCII chars...
Let me know if I can help you with anything...

@tofi86 I finalized the french translation (it took a bit longer than expected, with all the new strings from Jing). let me know when you can integrate those!

@rdeltour great! I can integrate the changes this evening. Stay tuned.

I'm also adding the new Dutch translation by Transifex contributor Merijn de Haen also it's still missing the Jing messages.
Nevertheless, thanks Merijn! :tada:

I'm closing this in favor of a quick 4.0.1 release and we're looking forward to integrate the italian translation in a next release.

Waiting for translations for the only changed text string in 4.0.1:
https://github.com/IDPF/epubcheck/commit/39c93b23b9d31d68dfeb36768224d1f92a5edfa4#diff-d690896c18b58160491906e560600966L14
Updated:
en, fr, de, es
Pending:
ja, nl

Pulled translations from Transifex and pushed the processed properties files with 406a200955bd5ce45aba64eb25093719d7ab4f10 to master


Update InitializingState.md

One of the code blocks missing the JavaScript tag for syntax highlighting.

Thanks!


默认的children如果为空会有一些问题

报错信息：Another exception was thrown: 'package:extended_wrap/src/extend_render_wrap.dart': Failed assertion: line 702 pos 12: 'runCount > 0': is not true.
Another exception was thrown: RenderBox was not laid out: ExtendedRenderWrap#5b5d7 relayoutBoundary=up5 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
Another exception was thrown: RenderBox was not laid out: RenderPositionedBox#ccce5 relayoutBoundary=up4 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
Another exception was thrown: RenderBox was not laid out: RenderPadding#ab233 relayoutBoundary=up3 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
Another exception was thrown: RenderBox was not laid out: RenderFlex#a9ba2 relayoutBoundary=up2 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
Another exception was thrown: RenderBox was not laid out: RenderFlex#15a9d relayoutBoundary=up1 NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
Another exception was thrown: RenderBox was not laid out: RenderFlex#a9ba2 relayoutBoundary=up2
Another exception was thrown: RenderBox was not laid out: RenderFlex#15a9d relayoutBoundary=up1 NEEDS-PAINT

判断数据是否为空， 为空就别用这个就OK了

也行


[go_router_builder] Creating a TypedGoRoute with non nullable queryParameter generates an invalid _fromState extension

Using go_router_builder: 1.0.15 and generating this route:
enum HomeTab { home, profile, settings }

@TypedGoRoute<HomeRoute>(path: '/')
class HomeRoute extends GoRouteData {
  const HomeRoute({this.tab = HomeTab.home});
  final HomeTab tab;

  @override
  Widget build(BuildContext context) => HomeScreen(tab: tab);
}

which resolves to the following generated code:
GoRoute get $homeRoute => GoRouteData.$route(
      path: '/',
      factory: $HomeRouteExtension._fromState,
    );

extension $HomeRouteExtension on HomeRoute {
  static HomeRoute _fromState(GoRouterState state) => HomeRoute(
        tab: _$HomeTabEnumMap._$fromName(state.queryParams['tab']),
      );

  String get location => GoRouteData.$location(
        '/',
        queryParams: {
          if (tab != null) 'tab': _$HomeTabEnumMap[tab]!,
        },
      );

  void go(BuildContext context) => context.go(location, extra: this);

  void push(BuildContext context) => context.push(location, extra: this);
}

const _$HomeTabEnumMap = {
  HomeTab.home: 'home',
  HomeTab.profile: 'profile',
  HomeTab.settings: 'settings',
};

extension<T extends Enum> on Map<T, String> {
  T _$fromName(String value) =>
      entries.singleWhere((element) => element.value == value).key;
}

The problem here is that it straight doesn't compile.
the _fromState extension we're using  _$HomeTabEnumMap._$fromName(state.queryParams['tab']) which should take a String while state.queryParams['tab'] returns a String? causing a compile error.

Thanks for the report. Seeing same behavior using code sample provided.

 stable, master flutter doctor -v
[✓] Flutter (Channel stable, 3.3.9, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.3.9 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (12 days ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.7.0-5.0.pre.25, on macOS 12.2.1 21D62 darwin-x64,
    locale en-GB)
    • Flutter version 3.7.0-5.0.pre.25 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 92aebc953d (2 hours ago), 2022-12-11 22:24:23 -0500
    • Engine revision 922546c919
    • Dart version 3.0.0 (build 3.0.0-12.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Closing this issue has it has been fixed by adding this method to go_router_builder that handles this edge case correctly.
T? _$convertMapValue<T>(
  String key,
  Map<String, String> map,
  T Function(String) converter,
) {
  final value = map[key];
  return value == null ? null : converter(value);
}


perf(derive): Prevent duplicate batch validity checks

Overview
Prevents duplicate batch validity checks by caching the result of the first check in the BatchWithInclusionBlock type. If the validity has already been determined, it will be returned immediately rather than repeating the work.

#353  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.9%.

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

We will not be including this in our first release for the upcoming alpha deployment. Please do not merge this PR just yet.
Waiting on https://github.com/ethereum-optimism/optimism/pull/11055


help

if anyone has access to this paper, could you send me a copy? thank you in advance

I've sent one to your gmail, hope this helps.

@w3nhao thank you Wenhao!


[warning] failed package validation and/or copy for commit<PHONE_NUMBER>a8d21531affd4e978eee3b5ce80039

Hi @conda-forge/python-graphblas! This is the friendly automated conda-forge-webservice!
It appears that one or more of your feedstock's outputs did not copy from the
staging channel (cf-staging) to the production channel (conda-forge). :(
This failure can happen for a lot of reasons, including an outdated feedstock
token. Below we have put some information about the failure to help you debug it.
Rerendering the feedstock will usually fix these problems.
If you have any issues or questions, you can find us on gitter in the
community chat room or you can bump us right here.
output validation (is this output allowed for your feedstock?):

noarch/python-graphblas-2022.4.1-pyhd8ed1ab_1.tar.bz2: False

copied (did this output get copied to the production channel?):

noarch/python-graphblas-2022.4.1-pyhd8ed1ab_1.tar.bz2: False

error messages:

output noarch/python-graphblas-2022.4.1-pyhd8ed1ab_1.tar.bz2 not allowed for conda-forge/python-graphblas-feedstock

Things seem to be working now (I think), so closing.

Hi @conda-forge/python-graphblas! This is the friendly automated conda-forge-webservice!
It appears that one or more of your feedstock's outputs did not copy from the
staging channel (cf-staging) to the production channel (conda-forge). :(
This failure can happen for a lot of reasons, including an outdated feedstock
token. Below we have put some information about the failure to help you debug it.
Rerendering the feedstock will usually fix these problems.
If you have any issues or questions, you can find us on gitter in the
community chat room or you can bump us right here.
output validation (is this output allowed for your feedstock?):

noarch/python-graphblas-2022.5.0-pyhd8ed1ab_0.tar.bz2: False

copied (did this output get copied to the production channel?):

noarch/python-graphblas-2022.5.0-pyhd8ed1ab_0.tar.bz2: False

error messages:

output noarch/python-graphblas-2022.5.0-pyhd8ed1ab_0.tar.bz2 not allowed for conda-forge/python-graphblas-feedstock

@beckermr, do you know what is going on here?

Check the feedstock outputs repo. The mappings may be wrong or outdated.

The feedstock went through renaming ( https://github.com/conda-forge/staged-recipes/pull/18672 ). Think something is still missing from that process, but not sure what

You need to submit a pr to adjust the feedstoutputs map.

Thanks for taking a look :heart: .  I'm pretty sure this is due to my impatience.  My bad.  TIL about feedstock-outputs repo.
See: https://github.com/conda-forge/feedstock-outputs/pull/32

This system is less than well documented. That's my fault!

@eriknw, can you please send a PR to update the renaming docs? Would include this feedstock-outputs step and anything else that you had to do that isn't already covered there :)

Good suggestion.  I'll do you one better ;)

https://github.com/conda-forge/conda-forge.github.io/pull/1758
https://github.com/conda-forge/conda-forge-webservices/pull/499

Cool, now this feedstock is working.  Closing.  Thanks again for your help, and I'm glad I was able to help in turn.

Indeed thanks Erik. Hopefully that makes it easier for the next person in this situation
Thanks Matt for the guidance here


plan to run your code on our own dataset.

thanks for your great work. I plan to run your code on our own dataset. I recognize that you have preprocessed code for ZJU-Mocap dataset and H36M dataset. Could you please provide me with a brief guide on how to modify my own dataset to meet ARAH requirements? Or I should simply change my own dataset into the format of ZJUMocap or H36m and this will work for me? Much appreciate.

Is your problem solved


[NFC] Reduce SIL's reliance on FunctionType::getInput

@swift-ci please test and merge

@swift-ci please smoke test

#10889 and John's changes make this patch pretty useless.


process subsequent futures when partially progressing a pool

fixes #1737

What about merging this? It's a vital fix for two affected functions.

Thanks for the fix here, and sorry for missing this PR. In the future, cc'ing me or one of the other maintainers if you don't get a response quickly should help.


kernel/Kompile, KBMC, KEq: refactored to Guice injections

There are 2 @RequestScoped added: for KBMC and KEq. These objects have 1-to-1 relationship with their respective front-end, so no reason why they shouldn't be RequestScoped. The only additional thing FrontEnd is doing is to open the DefinitionScope.

This mostly looks fine but I don't understand your comment about RequestScoped. When there is only a single place where a dependency is constructed is exactly the place where you /don't/ want to use RequestScoped, because you are not changing behavior at all, but you are replacing a simple constructor call with a complex operation calling out into the scope.

I didn't know this is your position. Removed all @RequestScoped.


what should I do?