GH-1981: Optionally Don't Start the DLT Container

Resolves https://github.com/spring-projects/spring-kafka/issues/1981

Hi @garyrussel, so it turns out there is a use case for not having a simple logging consumer after all! 😄
I like the approach of creating the DLT consumer and not starting. My initial thought was to simply not create the consumer,
but this way the consumer is there if the user wants to start it, and this should also work if it's a custom DLT handler.
What I'm thinking is, what if instead of having an autoStartup flag, we let the users optionally choose a dedicated listener container factory for the DLT consumer in the annotation / builder? It might give the users even more configuration flexibility for the DLT and leverage the already existing autoStartup flag from the factory.
Of course that might be an overkill - I like the solution as is too!


namespace for control variables, refactor getControls()

A parallel issue to #761.
Currently, in getControls(), control variable values are assigned to the object as attributes.
In line with architecture changes like #760, this should become a dedicated collection, e.g. self.controls as a dictionary.

I want to note that while I think having a separate namespace for states, control, and shock variables is the right first next step to be consistent with the current design, I'm not as certain this is the right way to organize things longer term.
As @llorracc has observed, there's times at which the status of a model variable seems to change, or else is superficial.

#836 only addresses states; this is the corresponding issue for controls
Related to need to rethink relationship between states, controls, and shocks

I'm looking at this now.
In the basic ConsIndShockModel case, two values are set in getControls().
cNrmNow is clearly a control variable.
I think MPCnow is not a control variable, but rather is something that's being computed out of economic interest. It's an 'epiphenomenal' property, something that depends on the action taken but has not endogenous effect on the system.
Is that interpretation correct?
It would be nice if there was a namespace for these properties. They are not really the same thing as model variables.


Gf animation not working

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.
If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
Windows x86_64
What version of the game are you using? Look in the bottom left corner of the main menu.
KE 1.4.2
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.
idk how to recreate it
Please describe your issue. Provide extensive detail and images if possible.
When I load into a song while the 3 2 1 go start its normal the after it finishes the gf justs keep repeating the danceLeft animation
https://user-images.githubusercontent.com/85022591/139757055-bb122465-7bdf-4949-ab1a-bcb7c8f21aca.mp4

Wouldn't it be better to just use 1.8's modcore feature?

Wouldn't it be better to just use 1.8's modcore feature?

i would but most mods aren't compatible with it bc every update something changes

Your version is outdated, try using 1.8 of KE to see if the bugs go away.

Your version is outdated, try using 1.8 of KE to see if the bugs go away.

its alright i found a solution for my self
I replaced gf dance animation code with this
if (animation.curAnim.name != 'danceRight')
{
danced = !danced;
					if (danced)
						playAnim('danceRight');
					else
						playAnim('danceLeft');
				}
				else if (animation.curAnim.name != 'danceLeft')
				{
					danced = !danced;

					if (danced)
						playAnim('danceLeft');
					else
						playAnim('danceRight');
				}


Package request: Thorium-browser

Project description

It's a super fast chromium-based browser. Apparently, it's the fastest browser out there.
Metadata

homepage URL: https://thorium.rocks/
source URL: https://github.com/Alex313031/thorium
license: mit, bsd, gpl2+ , ...
platforms: unix, linux, darwin, ...

It must be added to NixOS immediately

duplicate of #184823


removing Bootstrap - custom bootstrap

How can i remove bootstrap without ruing the carousel you have implemented?

https://github.com/angular-ui/bootstrap/blob/master/README.md#need-help


Request should map to Event

The Request DB model needs a navigational property to link it to an event.
A request can link to a single event. An event can have many requests.

Did you cover this in the last PR?

@tonysurma No this needs a small extra PR. You can assign this and #814 to me. I have a PR in my head, just need to type it out when I get home.


[GO]: OTel API operation naming: Unskipped / Fixed the tests in accordance to OTel attributes remapping

Description

Motivation

Workflow

⚠⚠ Create your PR as draft
Follow the style guidelines of this project (See how to easily lint the code)
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Once your PR is reviewed, you can merge it! :heart:
Reviewer checklist

[ ] Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
[ ] CI is green

[ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)

[ ] if any of build-some-image label is present

is the image labl have been updated ?
just before merging, locally build and push the image to hub.docker.com

[ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

/merge

/remove

@dianashevchenko please ping me if you need any help to solve the egg-chicken


Bugfix for domain_enforces_https() logic

Remove an extraneous call to is_http_redirect_domain(domain).  It's unclear to me why that function call is there, but it is not needed.  When this logic was originally simplified by me in #180, the existing logic was:
return is_domain_supports_https(domain) and (
    is_strictly_forces_https(domain) and
    (
        is_defaults_to_https(domain) or
        is_redirect(domain)
    ) or (
        (not is_strictly_forces_https(domain)) and
        is_defaults_to_https(domain)
    )
)

For some reason the extra call to is_http_redirect_domain(domain) was added in commit a65544b47665eaadf839bb4f02c9fb5026ca147b.  With this bugfix, the logic is now reverted back to:
return is_domain_supports_https(domain) and (
    is_defaults_to_https(domain) or (
        is_strictly_forces_https(domain) and is_redirect_domain(domain)
    )
)

A quick-but-tedious logic test using the eight possible values of A = is_strictly_forces_https(domain), B = is_defaults_to_https(domain), and C = is_redirect(domain) shows that the old and new expressions are now in agreement.
Another way to look at this is to notice that the old logic can be written as (remembering that and has higher precedence than or):
(A and (B or C)) or (not A and B)

Note that if B is True then the statement becomes (A and True) or (not A and True), which reduces to True regardless of the value of A.  If B is false then (not A and B) evaluates to False, and the larger statement can only be true if A and (False or C) evaluates to True, which would mean that A and C is True.  Therefore the original statement must be equivalent to
B or (A and C)

This was noticed thanks to a comment by @climber-girl.

@echudow, if there is a reason for including the call to is_http_redirect_domain(domain) that I am missing, please chime in.

I don't remember all the specifics at the moment, but I think there was a case something along the lines of the site's http endpoint redirected to HTTPS on a different site but also had a live https endpoint on its own site without redirecting, so the domain was was failing the enforce HTTPS check because is_redirect_domain() was False.  So I added is_http_redirect_domain() instead.  Logically, as long as that's ok, the is_redirect_domain() could be removed and just replaced with is_http_redirect_domain() and the refactor that @jsf9k did should work fine with just replacing is_redirect_domain() with is_http_redirect_domain().  I don't have time now, but I'll try to dig up the specific details over the weekend or next week.

I don't remember all the specifics at the moment, but I think there was a case something along the lines of the site's http endpoint redirected to HTTPS on a different site but also had a live https endpoint on its own site without redirecting, so the domain was was failing the enforce HTTPS check because is_redirect_domain() was False. So I added is_http_redirect_domain() instead. Logically, as long as that's ok, the is_redirect_domain() could be removed and just replaced with is_http_redirect_domain() and the refactor that @jsf9k did should work fine with just replacing is_redirect_domain() with is_http_redirect_domain(). I don't have time now, but I'll try to dig up the specific details over the weekend or next week.

We probably need @h-m-f-t to weigh in as to whether we should count such a case as "enforcing HTTPS".  In the case that caused me to investigate this, the site in question redirected all four endpoints to HTTPS except for the http://www endpoint.  That endpoint was being redirected to an HTTP site, and hence was being given credit for "enforces HTTPS."  In that case I don't think the code was doing the correct thing.

Thanks for the input, @echudow!
We probably need @h-m-f-t to weigh in as to whether we should count such a case as "enforcing HTTPS". In the case that caused me to investigate this, the site in question redirected all four endpoints to HTTPS except for the http://www endpoint. That endpoint was being redirected to an HTTP site, but was being given credit for "enforces HTTPS" (because of the presence of is_http_redirect_domain()). In that case I don't think the code was doing the correct thing.
It sounds like in your case the host did not default to HTTPS, in which case I don't think we want to count it as "enforcing HTTPS."

One of the sites that caused me to add the http_redirect was cloudservices.disa.mil.  The http endpoint immediately redirects to https://www.milcloud.mil/, but the https endpoint is live and doesn't redirect, and both www endpoints are down, so it isn't a "redirect_domain".  It seems to me like it enforces HTTPS though since both live endpoints are either https or redirect to https, but fails the old check because the http endpoint is live so it doesn't default_to_https and it isn't a redirect_domain.
@jsf9k, for the case that you were looking into, shouldn't the site still fail to enforce_https because it doesn't strictly_forces_https since the www endpoint redirects to an HTTP site?  strictly_forces_https is in an "and" with the (http_)redirect_domain, so it should still fail the overall domain_enforces_https check.
@jsf9k, sorry for losing your refactor since I was working on an earlier version of the code and then neglected to merge in all the upstream updates.  The refactor looks good to me, but I think could be okay with is_http_redirect_domain rather than is_redirect_domain.

@echudow - I'm trying to compare our two cases, but the site that caused me to investigate this (malware.us-cert.gov) is now returning a 503 instead of a redirect on the www endpoint.  I think that's possibly related to a power/internet issue at one of their physical locations.
I'm told things will be back up tomorrow.

@jsf9k, for the case that you were looking into, shouldn't the site still fail to enforce_https because it doesn't strictly_forces_https since the www endpoint redirects to an HTTP site? strictly_forces_https is in an "and" with the (http_)redirect_domain, so it should still fail the overall domain_enforces_https check.

I think you are correct, @echudow.  The presence of is_http_redirect_domain() vs is_redirect_domain() does not affect my malware.us-cert.gov example.  Digging into that example in more detail, I found the following.
The domain malware.us-cert.govstill results in a domain_enforces_https value of True with the code in develop.  This is actually because the canonical domain is an https domain, and therefore is_defaults_to_https() is True.  (See here).
Why is the canonical domain an https domain in this case?  Well, because it satisfies these rules.
The issue I have is that malware.us-cert.gov is emerging as BOD 18-01 compliant even though it redirects one of the http endpoints to an http site.  Maybe this is OK, but @climber-girl and I both think it is suspect.  I think either (1) those canonical domain rules need to be updated, or (2) the domain_enforces_https logic needs to be changed, or (3) we need to update the logic for BOD 18-01 compliance.
Right now, for BOD 18-01 compliance we require "supports_https", "domain_enforces_https", "domain_uses_strong_hsts", and "no crappy crypto".  Should we change "domain_enforces_https" to "strictly_forces_https" when calculating BOD 18-01 compliance?
@h-m-f-t, can you weigh in here?

I think the thing to do is to (1) keep my refactor, but (2) revert back to using is_http_redirect_domain(), so that the code becomes:
return is_domain_supports_https(domain) and (
    is_defaults_to_https(domain) or (
        is_strictly_forces_https(domain) and is_http_redirect_domain(domain)
    )
)

This will have the simplification from the refactor but will give the same results as what is currently in develop.  The issue I raised in my previous comment can then be taken up in a separate pull request.
Are you OK with this, @echudow and @h-m-f-t?

@jsf9k, @h-m-f-t, I think that would be great.  That's what I suggested above and I already made that change in my fork a few days ago.
For the malware.us-cert.gov issue, I think the actual issue isn't is_defaults_to_https() but actually is_domain_supports_https() which checks for downgrades using is_downgrades_https() that only checks the canonical endpoint.  I'm not sure that I fully understand the intent of is_domain_enforces_https() and how it is supposed to be different from is_strictly_forces_https().  Is it meant to do the is_strictly_forces_https() check and also check that the https endpoints are valid and don't downgrade?  If so, then I think the code should require that by being:
    return is_domain_supports_https(domain) and is_strictly_forces_https(domain) and (         is_defaults_to_https(domain) or is_http_redirect_domain(domain)     )

Hmm, yeah, malware.us-cert.gov should not be True for Domain Enforces HTTPS because the httpwww endpoint doesn't eventually land on an https hostname.

IIRC, the difference between Domain Enforces HTTPS and Strictly Enforces HTTPS was one of the immediacy of redirects.

Domain Enforces HTTPS should be False when there are endpoints that don't eventually force the user onto HTTPS, which could be on a hostname different than the one being scanned
Strictly Enforces HTTPS is when the two HTTP endpoints are down or immediately redirect to HTTPS.

So, should we change Domain Enforces HTTPS to require Strictly Forces HTTPS so that the check for immediate redirects to HTTPS will apply to all endpoints rather than how it is now where it just applies to the canonical endpoint?  What about if further in the redirect chain an endpoint downgrades the HTTPS to HTTP, should that cause it to fail Domain Enforces HTTPS?  Should Domain Enforces HTTPS fail if any of the endpoints redirect externally to non-HTTPS sites?
Are we good with the change from is_redirect_domain(domain) to is_http_redirect_domain(domain)?

So, should we change Domain Enforces HTTPS to require Strictly Forces HTTPS so that the check for immediate redirects to HTTPS will apply to all endpoints rather than how it is now where it just applies to the canonical endpoint? What about if further in the redirect chain an endpoint downgrades the HTTPS to HTTP, should that cause it to fail Domain Enforces HTTPS? Should Domain Enforces HTTPS fail if any of the endpoints redirect externally to non-HTTPS sites?
Are we good with the change from is_redirect_domain(domain) to is_http_redirect_domain(domain)?

@echudow, I think changing Domain Enforces HTTPS to require Strictly Forces HTTPS sounds like a good idea.  I'm also good with changing is_redirect_domain(domain) to is_http_redirect_domain(domain).  I'd like to get @h-m-f-t's opinion, though, since most of this logic was put in place before my time.  I'm not sure if there are specific corner cases they were trying to handle.

LGTM. I'd recommend a test run to check for surprises.

@h-m-f-t, what do you think about changing Domain Enforces HTTPS to require Strictly Forces HTTPS?  That change hasn't been made yet.

@jsf9k, can you run a test using https://github.com/cisagov/pshtt/pull/192/commits/46954e38f7f3686ddddc24c7fb728cc723c31535 to see which sites would now fail Domain Enforces HTTPS so we can look into if those results make sense and we should require Strictly Forces HTTPS or if the results don't make sense so we shouldn't require Strictly Forces HTTPS?

@echudow, I will kick that test off on Monday.  I should have results Tuesday.

Looking at the results of the full test run, I still think changing Domain Enforces HTTPS to Strictly Forces HTTPS makes sense.  The sites whose score changes appear to be mostly ones where, for example, the http://example.gov endpoint redirects to http://www.example.gov, which in turn redirects to https://www.example.gov.  I think it's OK to require folks to tighten up those redirects and redirect immediately to an HTTPS endpoint.

Time, how does it work 🕦
Layer 8 comment: frustration could be expressed by those whose scores this negatively changes. "I haven't changed anything; why don't I pass now?"
Prior communication (sent generally) about the change can help lessen frustration and give notice that action needs to be taken.

Another example that can be used to check logic changes during tests is studentsabroad.state.gov, which should be failing Supports HTTPS because it’s https-www endpoint should be flagging for BadHostname (cert is issued to *.state.gov, which wouldn't cover www.studentsabroad.state.gov).
However, a manual pshtt scan through docker that I just ran shows it as meeting Supports HTTPS because the plain domain endpoints are good to go.
$ curl --head https://www.studentsabroad.state.gov
curl: (51) SSL: no alternative certificate subject name matches target host name 'www.studentsabroad.state.gov'

Why do you have to hate on State as your example?? :(

From: Genevieve Marquardt<EMAIL_ADDRESS>Sent: Wednesday, May 22, 2019 4:48:00 PM
To: cisagov/pshtt
Cc: Subscribed
Subject: Re: [cisagov/pshtt] Bugfix for domain_enforces_https() logic (#192)
Another example that can be used to check logic changes during tests is studentsabroad.state.gov, which should be failing Supports HTTPS because it’s https-www endpoint should be flagging for BadHostname (cert is issued to *.state.gov, which wouldn't cover www.studentsabroad.state.govhttp://www.studentsabroad.state.gov).
However, a manual pshtt scan through docker that I just ran shows it as meeting Supports HTTPS because the plain domain endpoints are good to go.
$ curl --head https://www.studentsabroad.state.gov
curl: (51) SSL: no alternative certificate subject name matches target host name 'www.studentsabroad.state.gov'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/cisagov/pshtt/pull/192?email_source=notifications&email_token=AKUO3SOSTWPIDGUZDH6TAHDPWWWQBA5CNFSM4HKVAFA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAJO4Q#issuecomment-494966642, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKUO3SPLC2IKC2PKSIAYL5LPWWWQBANCNFSM4HKVAFAQ.


[HOLD for payment 2024-05-06] Group - Wrong number of members seen on group details page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Click on FAB > Start chat
Search for 2 non-existing users and click on add to group
Create the group
Open the group details page and observe the number besides "Members" button

Expected Result:
Correct number of members is visible, in this case 3
Actual Result:
Incorrect number of members is seen, in this case 5
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/71395108-f30e-427e-922e-c002e17fc1f1

View all open jobs on GitHub

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this bug might be related to #vip-vsb

Hmm I can
https://github.com/Expensify/App/assets/5201282/8daaa62b-654e-4795-8b3b-5e7934a7ed73
I think we are not clearing the optimistic created accountIDs?

Ooh I think this is part of moving away from participantAccountIDs to participants. The participantAccountIDs has only 3 members.

Anyway, this happens only for accounts that are created on this flow, so I don't think this should be a blocker. Removing the label.

Should we use report?.participantAccountIDs instead then ?

No, that is being deprecated here https://github.com/Expensify/App/issues/34692.

We should be clearing the optimistic accountIDs after inviting here:
https://github.com/Expensify/Web-Expensify/blob/6fe504f9aa17f8a3945bd4e2ba1fe2b155f5011a/lib/ReportAPI.php#L5949-L5967
We could check the logs though to make sure the params are correct and nothing happened to the Auth request

Seems like we are not sending the optimistic accountID list, will finish the PR tomorrow.

@johncschuster @ahmedGaber93 reviewed the PR.

Thanks, @rlinoz!

Summary:
Contributor+: @ahmedGaber93  $250 - Upwork Offer


Bugs: "Hard Drivin"/"Race Drivin" various issues

There are various bugs and issues related to games of the harddriv.cpp driver. (Unless mentioned otherwise, I tested them in the default cockpit versions.)
- drift makes car skid too long
The steering in the Atari arcade games "Hard Drivin" and "Race Drivin" in MAME behaves  odd. Once the car started to drift for a while and left the road, it often keeps spinning (even on the grass) like a carousel and becomes very hard to control for the rest of the game like driving on ice. This can only be stopped by braking the car to complete halt (0 mph). I am not sure if this is a MAME or game bug, or if this was even intentional game design, simulating excessive tyre wear or other car damage affecting steering - possibly exaggerated as a penalty for bad players.
(I control it by mouse on a slightly underpowered laptop with 1.6GHz Core2Duo and Intel graphics. The game plays well but often at about 90% speed. Setting steering wheel sensitivity "6" works best.)
Strange is that seems to happen mainly in the cockpit versions. The upright versions AFAIK don't skid forever on grass, so this seems to be a MAME bug. I suspect that the car physics DSP somehow gets out of sync with the game engine or isn't resetted properly. It feels like when it acts like a state machine that by driving faults (strong steering at too high velocity/offroad) switches into a "strong skidding" mode which is intended to be switched back to regular driving mode when the car slows down enough (possibly by resetting that chip with a special signal??) but fails. Please fix this.
- "Street Drivin" brake pedal miswired
In "Street Drivin" the brake pedal does nothing, which makes the Super Stunt Track impossible to finish. The test mode shows that the brake in MAME is miswired; it moves a wrong bargraph instead of "brake pedal". Please fix this.
Also the shifter can not be used, but this is likely a game bug, because in this prototype game it is nowhere mentioned in test mode and was likely not implemented.
- controls calibration fails (test mode)
In "Race Drivin" upright and "Street Drivin" (also "Panorama"?) the controls calibration in test mode fails with a message that the brake pedal is out of specs or such ("wait 10 minutes"), which prevents calibration of the steering wheel sensitivity.
- gearshift behaves odd
In cockpit versions of "Hard Drivin"/"Race Drivin" the shift lever is hard to set into neutral ("N") position through keyboard. When I shift into or out of reverse gear (needs to be enabled in test mode control settings), I have to double-clutch (push clutch and accelerate) in neutral position before I can shift to a forward gear again. When not in neutral during this, it will stay in reverse despite the dashboard displays a forward gear. Even in auto-transmission mode intermediate throttle in neutral mode is necessary to properly shift in and out of reverse gear. (I like to drive stunts and need it.) Technically the shift lever is an analogue joystick that would need more finetuning to be emulated on keyboard keys or mouse buttons.
Also the gas and brake pedals behave odd when set as digital buttons. Brake often is stuck after MAME start (press once to release), and IMO there should be separate settings for down and up rate e.g. to release the brake faster to reduce skidding.
- save state not working
When in "Hard Drivin" or "Race Drivin" I save a game state, after reload the game shows a GSP board timing(?) error and resets itself. I enjoy to train stunt tricks and want to load gamestates at different spots. Please fix this.
- car crash into invisible object
In these games when on the "race track" the car crashes somewhere near the grey drawbridge, after the usual "instant replay" the car is dropped back onto the road (falling 1m out of the sky?) at a certain spot with the drawbridge in sight. But if I push the gas pedal (rolling about 1m in any direction) the car keeps crashing into an invisible barrier (windshield shatters), is dropped back on the very same spot and so on; crashing from there again and again until time runs out. I am not sure if this is a MAME bug or game bug or even nasty little prank played by a poorly simulated Slapstick chip.
The car also can fall through the road in various other spots when slightly offroad. E.g. on the original track when after the U-turn your car slowly drives down the talus at the right road side (a bit like a bicycle jamming its wheel in a tram rail?), it plummets down a timehole and keeps spinning and tumbling in the sky with graphics mess for about 30s(?) while gaining >30k points(!). This may be a cheat but is likely just a pug. The car finally will explode and is put back on the road.
- graphic glitches (flowers in the sky)
In "Race Drivin" on the "original track" driving down the trough, sometimes shows flowers floating in the sky. This does not happen in "Hard Drivin". Is this a Slapstick bug?
In "Hard Drivin" cockpit there are small rocks (milestones?) on the orange sides of the road. But in all other game variants (upright, "Race Drivin" etc.) there are none. Is this authentic game behaviour or a MAME bug? (The rock looks flat when seen from the side and seems to be the only pixel graphics sprite in the entire game, so it was likely a leftover from early graphics engine experiments with textures.)
Generally these games have many graphics glitches. Particularly polygon priority bugs also exist on the arcade machine (and home versions). But occasionally the road and other objects look "bent" when driven onto from an unexpected angle. Is this a game bug or do helper chips in MAME run out of sync (like suggested by the save state bug)?

Two things:
!. You opened this issue against the www.mamedev.org repo, which is the website. You should have opened your issue against the "mame" repo at https://github.com/mamedev/mame ... except:

Except that this sort of gamer-centric issue is much better suited for the end user issue ticket tracker at https://mametesters.org . Please send such issues there in the future, The github issue tracker is better suited to developer/coder-related issues.

Closed.


GitHub action with check annotation

I'd like to create a GitHub action which is similar to https://github.com/actions-rs/clippy-check
This will be in another GitHub repo.
Biome has implemented this: https://biomejs.dev/blog/biome-v1-5/#the-command-biome-ci-now-prints-diagnostics-in-github-prs

@Boshen another approach could be to check in the environment for GITHUB_ACTION and output the ::error string(s) as part of stdout. That way you'd just run the binary in CI and it'd Just Work.

@Boshen Hello! I would like to address this issue!

@Boshen Hello! I would like to address this issue!

Assigned 😁

@Boshen Hello! I would like to address this issue!

Assigned 😁

Thanks! By the way, where should I create a repository?

First, I'll create it privately, and if @Boshen decides it's a good idea, I'll import it into oxc-project.
Create it in oxc-project from the beginning

@re-taro Do you wanna take a look at how biome does it? It seems like all we need to do is detect for github CI and dump things differently

@Boshen another approach could be to check in the environment for GITHUB_ACTION and output the ::error string(s) as part of stdout. That way you' run the binary in CI and it'd Just Work.

The text should be wrapper here I think
https://github.com/oxc-project/oxc/blob/4cd5f1a05ecf11d34cc881d0181bd29a220131b4/crates/oxc_diagnostics/src/service.rs#L127

@re-taro Do you wanna take a look at how biome does it? It seems like all we need to do is detect for github CI and dump things differently

@Boshen another approach could be to check in the environment for GITHUB_ACTION and output the ::error string(s) as part of stdout. That way you' run the binary in CI and it'd Just Work.

Ah, I see, my apologies, you mean to respond with a Biome-like approach. Yes, sir.

hmm... If you can escape &err_str and get file name, line number and column number in output.push_str(&err_str); inside crates/oxc_diagnostics/src/service.rs It would be nice, but it is not simple because line number and column number are obtained in crates/oxc_diagnostics/src/graphic_reporter.rs and are nicely hidden.

hmm... If you can escape &err_str and get file name, line number and column number in output.push_str(&err_str); inside crates/oxc_diagnostics/src/service.rs It would be nice, but it is not simple because line number and column number are obtained in crates/oxc_diagnostics/src/graphic_reporter.rs and are nicely hidden.

Can you help me with what's needed to be printed / outputted on the screen?

Can you help me with what's needed to be printed / outputted on the screen?

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-notice-message

Sorry for the hassle. As @jbergstroem posted the link, you need to get the file name, column number and line number inside crates/oxc_diagnostics/src/service.rs (if you wrap output.push_ str(&err_str); if you wrap it...). For workflow-command, you can get it from diagnostic.severity().


Unecessary messages in queue handling

Suppose you want to have one or multiple threads to preload/preprocess images and push them into an image queue that is going to be consumed by your main process, running on the GPU. A simple way of doing so would be:
def load_image(session, image_list, enqueue_op, image_data_placeholder, coord):
  index = 0
  while not coord.should_stop():
    idata = image_list[index]
    session.run(enqueue_op, feed_dict={image_data_placeholder: idata})
    index = (index + 1) % len(image_list)

Eventually, your optimization is finished and you want all threads to end, but if you have threads feeding your queue, they are most likely blocked at the enqueue_op, waiting for an image to be consumed, so they can finally insert theirs in the queue.
Since closing the queue doesn't unblock them (surprisingly), your most evident choice is to use the timeout option to limit how long the enqueue_op can block your thread, with something like this:
def load_image(session, image_list, enqueue_op, image_data_placeholder, coord):
  index = 0
  while not coord.should_stop():
    idata = image_list[index]
    try:
      session.run(enqueue_op, feed_dict={image_data_placeholder: idata}, options=tf.RunOptions(timeout_in_ms=1000))
      index = (index + 1) % len(name_list)
    except:
      pass

And it does work: the thread will continue trying to push the same image until either it succeeds (and moves on to the next one) or coordinator says it should stop everything and finish.
The problem is that the timeout not only throws an exception saying that the time has been exceeded, but TF also "manually" prints a warning message. Bad news, you have 3 options: (1) manually edit TryAttemptLocked in queue_base.cc to remove the message from your tensorflow copy, (2) accept that this pesky message is going to flood your logs with useless information or (3) force TF_CPP_MIN_LOG_LEVEL to be at level 2, suppressing all information messages and warnings that could be important, only to get rid of this one message. There is also a 4th option: open an issue here in hope there is a better way of handling this, or that some dev changes this behavior — the exception should be enough for any situation, the forced message doesn't seem to do any good. :-)
Disclaimer: I know it's far from optimal to pass a list of features (image_list) to be enqueued. This is just for the sake of simplicity in this example.

I think the log message here is intentional, especially for running in distributed settings where the log message might be printed on a parameter server and you want to diagnose a worker failure.
Here's a 5th option: we could figure out how to make your code work without using timeouts.
Let's say your queue is called queue. I think all that's necessary is to define your queue.close() op as:
close_op = queue.close(cancel_pending_enqueues=True)

Does that solve the problem?

Yes, it gracefully solves the problem — I didn't know this parameter existed. But unfortunately the solution was included in option 4 ("... there is a better way of handling this ..."). :-P
Thank you @mrry for the clarification about the log and for the solution. Closing the issue.


Error when converting pretrained model: (raise ValueError("'%s' is not a valid scope name" % name) and 'functional_9/conv1/conv/Conv2D__6:0' is not a valid scope name

I tried to use the following code to change my onnx model to a keras model. I am using tensorflow version 2.1.0. My model is a densenet model that has been retrained for a new dataset. Let me know if additional information would be helpful. Thank you for your help!
#%% Load packages
import tensorflow as tf
import tf2onnx
import onnx
#%%
from onnx2keras import onnx_to_keras

#%% Load onnx model
onnx_model=onnx.load("Test_10_DC_R_Image.onnx")

#%% Convert to keras model
k_model = onnx_to_keras(onnx_model, input_names=['input'])

This is the error I recieved:
raise ValueError("'%s' is not a valid scope name" % name)

ValueError: 'functional_9/conv1/conv/Conv2D__6:0' is not a valid scope name

Did you solve this error


Unable to validate multiple documents in same file.

Hi,
I have a scenario where I need to validate multiple yaml documents in same file.
It fails with below error:
11:02:44  + ./node_modules/.bin/yamllint test-service.yml 11:02:45  ✖ expected a single document in the stream, but found more
e.g.
---
test1: abc
---
test1: ac
test2: pyx

is it possible to enhance the CLI?

Better late than never: this has finally been fixed in v1.6.0 which was published a few minutes ago. Sorry for the delay! 🙈


Add upon_error and upon_stopped implementations.

Adds upon_stopped and upon_error implementations with the corresponding testing.

@miscco Thanks, will take a look.

@ericniebler  The changes regarding _Fun to be callable instead of tag_invocable should also be propagated to upon_error too, right?

@ericniebler  Thanks a lot! I kinda figured while working on it today.


[BUG][UI] Oversized error message shown when failing to fetch task details

Describe the bug
When failing to fetch task details for a NodeExecution in the table, we show a large NotFound error for all components which consume the value via WaitForQuery.
Expected behavior
Some type of fallback text.
Flyte component

[ ] Overall
[ ] Flyte Setup and Installation scripts
[ ] Flyte Documentation
[ ] Flyte communication (slack/email etc)
[ ] FlytePropeller
[ ] FlyteIDL (Flyte specification language)
[ ] Flytekit (Python SDK)
[ ] FlyteAdmin (Control Plane service)
[ ] FlytePlugins
[ ] DataCatalog
[ ] FlyteStdlib (common libraries)
[x] FlyteConsole (UI)
[ ] Other

Screenshots

fixed by lyft/flyteconsole#146
available in flyteconsole v0.19.4

fixed by lyft/flyteconsole#146
available in flyteconsole v0.19.4


feat: make instance methods public

Currently, the methods are private and "cannot" be used properly when you use Typescript. This change makes them public and then it actually also makes sense to list them in docs.

reviewed, tested and merged. thank you :)


Gundb load testing

gundb - GoodGun

existing loadtesting script at GoodGun repo. loadtest.js
add SEA writing tests (ie gun.user())
make sure client CPU is not the bottleneck
different heroku mongo plans

expected report

results based on number of total web workers/ type of webworker/type of mongodb backend
how much concurrency before requests timeout
latency(avergae time requests takes to complete) and TPS ( transactions per second)

frameworks

heroku web workers

@StanislavShevchenko @AlexeyKosinski
The load test should be based on the loadtest.js in GoodGunReceiver repository
The current tests creates clients then  in a roundrobin over the clients sends .put requests.
I would like the SAME test just that clients also "login" to gun. and the puts requests are made via the client SEA module ie client.user().get('x').put({...}), this causes the puts to be cryptographically signed and verified on the gun server. (so it should be more stressful to the server)

https://github.com/GoodDollar/GoodGunReceiver/pull/27

@AlexeyKosinski can you compare atlas as backend vs heroku?
also on heroku can you temporarily select a higher mongodb plan (for dev) and test it against it

@AlexeyKosinski you can compare atlast vs heroku on goodgun-dev, change the mongo url
i've added mongo instance to goodgun-dev on heroku, remove it once tests are donem dont forget to change the env variable to the correct mongo db

here the report
heroku sanbox VS heroku dedicated cluster VS atlas sandbox
https://docs.google.com/spreadsheets/d/1snLfkASaoUDAGDFPaoGVHk4fZAAnqfEvkqRym-ZaYw0/edit?usp=sharing

@AlexeyKosinski lets test this with a more performant heroku node. i've changed goodgun-dev node type to 2x.


Non-English characters don't render properly

There are no support for Cyrillic characters in the Fakt font. So on Windows even in the interface it replaced by some built-in font (Arial, I suppose) and looks terrible and out of style.
For details please find the screenshot attached.

Oh man that does look awful. We're in touch with the font foundry that makes Fakt, but we may not be able to get Cyrillic characters into it. Is there another font that would be better for us to fall back to for characters in that range? We could definitely provide a font-face alternate for that unicode range.

@bengotow I'm not a designer (not even a dilettante) and not sure that the listed fonts are suitable for the interface but personally I like [Formular] (https://www.fontshop.com/families/formular), [Museo Sans] (http://www.exljbris.com/museosans.html), [20 Kopeek] (https://yurigordon.com/en/shop/fonts/20kopeek), [Raleway] (http://www.impallari.com/projects/overview/matt-mcinerneys-raleway-family), [Geometria] (http://brownfox.org/?p=789). Hope it can help somehow.

Japanese characters in screenshot mode: https://github.com/nylas/N1/issues/2314

Chinese characters: #2025

Cyrillic again: https://github.com/nylas/N1/issues/2615

Hi, Bengali characters are also not showing well, specially the joint characters are breaking apart.


Create 4nNVfQ9eWidZXkBKZN5li4

Please add this too!

Looks good, thanks for contributing!

Looks good, thanks for contributing!


Empty page for each product  from Gear or Training category

Current behavior
Page without content for each product  from Gear or Training category

Expected behavior
"The product has been added to the cart!" occurs always when user adds product to the cart.
Steps to reproduce the issue

Run develop branch
Go to Gear or Training category
Open any PDP

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[x] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

It's OK with 1.11.2; for the 1.12.rc1 it requires you to re index the database so I guess that was the reason as we spoken on Slack

oh, yeah, you are right @pkarw 👍


Fix from_bdd for cudd

The dd cudd interface does not have a to_expr() method for dd.cudd.Function objects. It only has to_expr for managers.
Previous version raised errors, this is a simple workaround.

Codecov Report

Merging #28 into master will decrease coverage by 0.19%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master      #28     +/-   ##
=========================================
- Coverage   93.87%   93.67%   -0.2%
=========================================
  Files          14       14
  Lines         441      443      +2
=========================================
+ Hits          414      415      +1
- Misses         27       28      +1

Impacted Files
Coverage Δ

aiger_analysis/bdd.py
93.44% <66.66%> (-1.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005ad6d...ff2e814. Read the comment docs.


squares: subsequent calls should have same value

Since the API calls for a Squares object to be instantiated with a specific max value, it seems to be implied that the instance methods of a given instance should have the same result on subsequent calls. While not common, I have seen more than one submission that didn't have this property.

Thanks!


Death Knight Tank Sim Master of Ghouls Rotation Issue

Describe the bug
When Master of Ghouls is talented, the new version of Raise Dead is not selectable under the Cast sub-menu in the rotation creator.
To Reproduce
Steps to reproduce the behavior:

Go to DK Tank Sim
Talent into Master of Ghouls in the Unholy Tree
Notice that the "Raise Dead" in the rotation tab towards the bottom for the Blood threat rotation has a hazard icon
Click the spell and look for the new version granted by Master of Ghouls and see it is not there

Expected behavior
Permanent pet version of Raise Dead should be selectable when Master of Ghouls is talented.

Permanent pet version is summoned automatically before combat and is not required to be casted as a spell.


Add JSDocs for all methods.

There are still many methods whose JSDocs need to be added

done : https://github.com/noveens/js-owncloud-client/commit/09136bf74baf0ac4bc071a06c544ae24ff2c0eaf


XASX: Added National Day of Mourning for Her Majesty the Queen

This PR adds the National Day of Mourning for Her Majesty the Queen (2022-09-22) to XASX. Source: https://www2.asx.com.au/markets/market-resources/trading-hours-calendar/cash-market-trading-hours/trading-calendar
Workflow to modify an existing Exchange Calendar

[X] Modify calendar class as required.
[X] Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
[X] Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
[X] Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

Thanks for another one @philiptromans.

@philiptromans Can you add this to XNZE (New Zealand) please?
https://www.nzx.com/services/nzx-trading/hours-boards

@philiptromans Could you copy this into XNZE please? https://www.nzx.com/services/nzx-trading/hours-boards


Add ignore functionallity

You can run tests from a specified list of directories. This way you can exclude some directories.
Please see the example.
You can look into the following examples in the knapsack_pro gem if you need a more advanced solution.

KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN
KNAPSACK_PRO_TEST_FILE_LIST_SOURCE_FILE


Fix setup.py so only main executable goes in bin and put version check in setup.py

The previous implementation had all scripts in the package (parser_gromacs,py, etc.) placed in the bin directory (i.e., /usr/bin or /usr/local/bin). This fixes that behavior.

Also I can remove all the extra comments, but I didn't know if those were helpful to keep there

Ah, excellent. I'm not used to using a setup.py (OK, haven't done much code development of anything significant) so it didn't occur to me to put the version check in there.
Is this ready to merge?

Also I can remove all the extra comments, but I didn't know if those were helpful to keep there

I also don't have any problem with the current level of commenting.

It's ready to merge now.

@wesbarnett - this broke something for me, and I'm not totally sure what, so I had to revert the merge. Here's what I currently get after installing it:
alchemical_analysis -h
Traceback (most recent call last):
  File "/Users/dmobley/anaconda/bin/alchemical_analysis", line 9, in <module>
    load_entry_point('alchemical-analysis==1.0.2.dev0', 'console_scripts', 'alchemical_analysis')()
  File "/Users/dmobley/anaconda/lib/python2.7/site-packages/setuptools-19.6.2-py2.7.egg/pkg_resources/__init__.py", line 547, in load_entry_point
  File "/Users/dmobley/anaconda/lib/python2.7/site-packages/setuptools-19.6.2-py2.7.egg/pkg_resources/__init__.py", line 2719, in load_entry_point
  File "/Users/dmobley/anaconda/lib/python2.7/site-packages/setuptools-19.6.2-py2.7.egg/pkg_resources/__init__.py", line 2379, in load
  File "/Users/dmobley/anaconda/lib/python2.7/site-packages/setuptools-19.6.2-py2.7.egg/pkg_resources/__init__.py", line 2385, in resolve
  File "/Users/dmobley/anaconda/bin/alchemical_analysis.py", line 4, in <module>
    __import__('pkg_resources').run_script('alchemical-analysis==1.0.2.dev0', 'alchemical_analysis.py')
  File "/Users/dmobley/anaconda/lib/python2.7/site-packages/setuptools-19.6.2-py2.7.egg/pkg_resources/__init__.py", line 724, in run_script
  File "/Users/dmobley/anaconda/lib/python2.7/site-packages/setuptools-19.6.2-py2.7.egg/pkg_resources/__init__.py", line 1641, in run_script
pkg_resources.ResolutionError: No script named 'alchemical_analysis.py'

It's possibly it's an environment issue of some sort for me...? After reverting, alchemical_analysis.py -h works fine.

(I'm OK with the general idea, and with the version check going in setup.py, but am ambivalent about the switch from alchemical_analysis.py to alchemical_analysis and I certainly only want to do it if it actually works.)

Without this pull request it is populating the user's bin directory with both alchemical_analysis.py and alchemical_analysis (plus a few other scripts). So alchemical_analysis should work with either one.
I think the issue is that the scripts unixlike.py, parser-gromacs.py, and alchemical_analysis.py are still in the bin directory when you manually upgrade and this somehow confuses the program (something's not in the right spot). To get it to work I had to uninstall and then reinstall again:
sudo pip uninstall alchemical_analysis
sudo python setup.py install

OK. Er, to save me time git-wrangling, do you mind pulling down master again (I just made another bugfix) and then resubmitting your PR? Since I already merged/closed it, it's not totally obvious to me how I re-awaken it. I could certainly figure it out eventually but you should be able to submit another with just the click of a button, which is a lot faster than waiting for me to figure it out.
Thanks.

PR #77


Invalid main field in package.json

Since nodejs 16.0.0 has been released, this message started to appear:
(node:31065) [DEP0128] DeprecationWarning: Invalid 'main' field in '/Users/oz/n/lib/node_modules/npm-check/node_modules/find-parent-dir/package.json' of 'find-parent-dir.js'. Please either fix that or report it to the module author

There's a pull request (#5) since 2018 that fixed the issue but it got never merged since the project is probably abandoned.

@thlorenz anything we can do to help?
thanks

Fixed in #5


Possible incompatiblity with WorldThreader

Is it a mod compatibility issue?
Yes
If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)
https://github.com/2No2Name/worldthreader
Minecraft version
1.20.1
Describe the issue
Possible incompatibility with worldthreader, it does the error below for every dimension since world threader gives each dimension it's own thread.
Though I have not found this actually being an issue in gameplay. Both seem to work properly and you can cross dimensions without issue. So I am not sure if it's just immersive portals warning that this could be an issue when it might not be.
error:
[13:36:42] [worldthreader_immersive_portals:alternate1/ERROR]: Called in a non-server-main thread. java.lang.Throwable: null 	at qouteall.imm_ptl.core.chunk_loading.ImmPtlChunkTickets.flushThrottling(ImmPtlChunkTickets.java:169) ~[imm_ptl_core-3.3.5-fe5e07efa11dee9e.jar:?] 	at net.minecraft.class_3204.handler$zla000$imm_ptl_core$onRunAllUpdates(class_3204.java:1053) ~[client-intermediary.jar:?] 	at net.minecraft.class_3204.method_15892(class_3204.java:146) ~[client-intermediary.jar:?] 	at net.minecraft.class_3215.method_16155(class_3215.java:286) ~[client-intermediary.jar:?] 	at net.minecraft.class_3215.method_12127(class_3215.java:323) ~[client-intermediary.jar:?] 	at net.minecraft.class_3218.method_18765(class_3218.java:333) ~[client-intermediary.jar:?] 	at _2no2name.worldthreader.common.ServerWorldTicking.tickThreaded(ServerWorldTicking.java:71) ~[Worldthreader-1.5.0.jar:?] 	at _2no2name.worldthreader.common.ServerWorldTicking.runWorldThread(ServerWorldTicking.java:46) ~[Worldthreader-1.5.0.jar:?] 	at _2no2name.worldthreader.common.thread.WorldThreadingManager.lambda$new$0(WorldThreadingManager.java:42) ~[Worldthreader-1.5.0.jar:?] 	at java.lang.Thread.run(Thread.java:833) ~[?:?]
latest.log

Currently, It's not recommend to use this mod with WorldThreader, as thread safety issue can occur rarely, but when it occurs the game state may become valid and it has the chance to corrupt the world saving. If you really want to use ImmPtl with WorldThreader, it's recommended to backup frequently.

I made some changes that may fix the thread check of ImmPtlChunkTickets

Thanks for the reply. Yes I do hourly backups on my server. Just looking to optimize however I can, but having everything on a single thread is really limiting so separating dimensions to different threads would be so nice for my server but I understand it is extremely complicated to make sure everything works properly.

I compiled a version of the mod that has the threading code you added. It works super well! ran into no issues or errors thus far personally. Thanks again :)


Strange audio transcriptions when silent

It seems during the moments of silence, the transcription goes insane and writes this kind of stuff:

[2024-08-01T10:34:41Z INFO  screenpipe_audio::stt]   0.0s-...:  I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other side of the screen. I'm going to use the other

[2024-08-01T10:37:11Z INFO  screenpipe_audio::stt]   0.0s-...:  I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this. I'm going to do this

[2024-08-01T10:37:41Z INFO  screenpipe_audio::stt]   0.0s-...:  I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video. I'm going to make a video about the next video.  Could be picking up the white/brown noise from that.

yes sorry about that we added a noise filter in new version
you can upgrade to latest version using brew upgrade and brew upgrade screenpipe
note that then when running the CLI it is now using by default Deepgram which is a cloud model much more powerful than the local one
you can keep local model using screenpipe --cloud-audio-off

CLI it is now using by default Deepgram

Does that need an API key?

CLI it is now using by default Deepgram

Does that need an API key?

@moltar nope, we have bunch of credits after winning hackathon(s) so we offer it for free!

Do they use that data in some nefarious ways? ;)


debug just with -vv

Show debug messages just with -vv. This also prevents fails, when this role is invoked on remote targets.

thanks!


fix data race in scale command

Changes

Fix possible data race in scale cmd

/kind bug
Release Note

NONE

@julz can you take a look at this fix please? thx

/lgtm
/approve

cc @maximilien


Fix unused variable 2

For real this time!
Same approach as last time, suppress the unused variable warning by using the unusued variable.
I've benchmarking using clang but could detect virtually no difference.
GitHub issues
https://github.com/doctest/doctest/pull/575
I've tested it using the Intel compiler and it correctly suppresses the warning!

This is cool! I wonder when some compiler would start complaining in Release that the variable is still never used :D


[ci skip] updated spelling error bellow -> below

What does this PR do?
Update spelling error in datadog-agent/pkg/config/config.go
Motivation
I like the words a spelled correctly
Additional Notes
I hope the [ci skip] is working, I do not want to waste time for everyone.
Describe how to test your changes
Change is pure cosmetic, no need for tests
Checklist
Note: Adding GitHub labels is only possible for contributors with write access.

Moving milestone to 7.32.0 since we don't have a CLA signed yet.

@bundgaard We appreciate your contribution but we will close this PR since it has been many months since it was opened and we have not yet received a signed CLA. Feel free to reopen this PR once that's done.


Getting errors on import

I'm trying to run an app using the most recent version of flexx from this repo and getting the following error:
Traceback (most recent call last):
File "C:/Users/Shipping/Documents/Integration Dev/SquarespaceUploader/FlexxInventoryGui.py", line 12, in
from flexx import app, ui, event
File "C:\Python37\lib\site-packages\flexx\ui_init_.py", line 143, in
from ._widget import Widget, create_element
File "C:\Python37\lib\site-packages\flexx\ui_widget.py", line 44, in
class Widget(app.JsComponent):
File "C:\Python37\lib\site-packages\flexx\event_component.py", line 54, in init
cls._init_hook2(name, bases, dct)
File "C:\Python37\lib\site-packages\flexx\app_component2.py", line 153, in _init_hook2
cls.JS.CODE = cls.get_js()
File "C:\Python37\lib\site-packages\flexx\app_component2.py", line 248, in get_js
c = create_js_component_class(cls.JS, cls_name, base_class_name)
File "C:\Python37\lib\site-packages\flexx\event_js.py", line 543, in create_js_component_class
code = mc.py2js(val, prototype_prefix + name)
File "C:\Python37\lib\site-packages\flexx\event_js.py", line 61, in py2js
code = py2js(*args, **kwargs)
File "C:\Python37\lib\site-packages\pscript\functions.py", line 145, in py2js
return py2js(ob)
File "C:\Python37\lib\site-packages\pscript\functions.py", line 110, in py2js
p = Parser(pycode, (filename, linenr), **parser_options)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 259, in init
raise(err)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 249, in init
self._parts = self.parse(self._root)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 435, in parse
res = parse_func(node)
File "C:\Python37\lib\site-packages\pscript\parser1.py", line 736, in parse_Module
code += self.parse(child)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 435, in parse
res = parse_func(node)
File "C:\Python37\lib\site-packages\pscript\parser2.py", line 974, in parse_FunctionDef
code += self.parse(child)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 435, in parse
res = parse_func(node)
File "C:\Python37\lib\site-packages\pscript\parser2.py", line 478, in parse_If
code += self.parse(stmt)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 435, in parse
res = parse_func(node)
File "C:\Python37\lib\site-packages\pscript\parser1.py", line 619, in parse_Assign
code += self.parse(node.value_node)
File "C:\Python37\lib\site-packages\pscript\parser0.py", line 435, in parse
res = parse_func(node)
File "C:\Python37\lib\site-packages\pscript\parser1.py", line 222, in parse_Dict
raise JSError('Computed dict attributes are not supported on IE :/')
pscript.parser0.JSError: Error processing Dict-node in function "_create_pointer_event" in "C:\Python37\lib\site-packages\flexx\ui_widget.py", line 939, col 18:
Computed dict attributes are not supported on IE :/
Since it's on import I'm pretty certain it's not my code, is a fix possible?

Nevermind, different issue on update now

I think the error is due to code that looks something like this:
foo = 'mykey'
d = {mykey=3}
# or
d = {'my'+'key'=3}

However, this limitation has been removed recently, so it's probably a matter of updating flexx.

Correction: update pscript (e.g. via pip install pscript --upgrade)


[WIP] Better mechanism to configure logging

Solves #71

Is this still a work in progress or are you done adding code?

Yeah, sorry. Just waiting for feedback.

+1, looks good.
We can create an issue to remove the option to set environment variables for 'type': 'dict' and 'type': 'list' once this is merged since that doesn't have anything to do with logging.


error in file: sh scripts/test_cluster_det.sh

run : sh scripts/test_cluster_det.sh,it  give errors as follows:
trainer@f7c6756f593f:/data/raid/learn-to-cluster$ sh scripts/test_cluster_det.sh [2019-07-26 01:13:57,415] Set random seed to 42 [./data/labels/part1_test.meta] #cls: 8573, #inst: 584013 [Time] read meta and feature consumes 1.5541 s read proposals from folder:  ./data/cluster_proposals/part1_test/faiss_k_80_th_0.7_step_0.05_minsz_3_maxsz_300_iter_0/proposals/ read proposals from folder:  ./data/cluster_proposals/part1_test/faiss_k_80_th_0.75_step_0.05_minsz_3_maxsz_300_iter_0/proposals/ [Time] read proposal list consumes 0.5840 s #cluster: 34578, #output: 1, feature shape: (584013, 256), norm_adj: True, wo_weight: False Traceback (most recent call last):   File "dsgcn/main.py", line 80, in <module>     main()   File "dsgcn/main.py", line 76, in main     handler(model, cfg, logger)   File "/data/raid/learn-to-cluster/dsgcn/test_cluster_det.py", line 48, in test_cluster_det     for i, data in enumerate(data_loader):   File "/home/trainer/anaconda3/envs/pytorch_py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 281, in __next__     return self._process_next_batch(batch)   File "/home/trainer/anaconda3/envs/pytorch_py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 301, in _process_next_batch     raise batch.exc_type(batch.exc_msg) TypeError: Traceback (most recent call last):   File "/home/trainer/anaconda3/envs/pytorch_py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 55, in _worker_loop     samples = collate_fn([dataset[i] for i in batch_indices])   File "/data/raid/learn-to-cluster/dsgcn/datasets/build_dataloader.py", line 39, in collate_graphs     pad_feat = default_collate(pad_feat)   File "/home/trainer/anaconda3/envs/pytorch_py36/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 137, in default_collate     raise TypeError((error_msg.format(type(batch[0])))) TypeError: batch must contain tensors, numbers, dicts or lists; found <class 'torch.autograd.variable.Variable'>

pytorch version  error, solved it


Prevent printing of original pdf document when pdf is rendered as jpg viewer type

Please, fill the following sections to help us to reproduce and fix the issue
What happened:
Clicking on Print button actually attempts to print original pdf.
What you expected to happen:
Jpg images rendered in the angular viewer needs to be printed.
How to reproduce it:
Source code sample:
Environment:

.NET Core version 8
GroupDocs.Viewer.UI version
Operative system:
Others:

It appears print button on legacy viewer prints images but not original pdf. This is to secure direct access to file.

@sacerande
I got your point, and I believe it is valid when you want to protect the data from being copied.  We'll take a look at how it can be  fixed. As a temporary fix you can hide download and print buttons.
var builder = WebApplication.CreateBuilder(args);

builder.Services
    .AddGroupDocsViewerUI((config) =>
    {
        config.DisableFileDownload();
        config.DisablePrint();
    });

You can use this sample-app.zip as example.


Question: react-scripts start constantly @ 30% CPU

This is a general question (and first time using create-react-app) - I've been using it for about a month, but I notice that when the react-scripts start is running, in an idle state, the CPU is running about 30% for the node process.
Is that normal?
Environment
Run these commands in the project folder and fill in their results:

npm ls react-scripts (if you haven’t ejected<EMAIL_ADDRESS>node -v: v7.0.0
npm -v: 3.10.8 (but using yarn for installs - v0.15.1)

Then, specify:

Operating system: Mac 10.10.3 (14D136)
Browser and version: Chrome stable (but doesn't affect CPU usage when tab is closed)

Do you have node_modules/fsevents? I've heard reports Yarn fails to install it, and without it the watcher has to use an expensive polling mode.

I would recommend running rm -rf node_modules and then npm install and try again. If it helps then it's that Yarn bug.

Huh. That was it. Wow. I had to wait a fair bit for npm to install (switched to yarn some time ago and haven't looked back), but yeah, CPU is totally normal now with an npm based install. Thanks (pretty sure nodemon relies on fsevents somewhere in the stack, so useful to know).

Can you provide a tiny project that reliably reproduces this issue? I'm not sure we ever filed this problem with Yarn so would be nice to have it.
I tried to create a new project with Yarn, and fsevents seems to be there. So I'm curious what's the accurate way to repro this.

Gosh…okay. The project I'm working on has grown (number of files) quite a bit, so I'll have a crack, but can't guarantee anything.
Actually a thought, are the react-scripts watching the entire directory for changes? It might be related to that, and potentially including large node_module dir and some large data files (though, I'm fairly sure the size of the file doesn't affect the watching process…)

It normally should only watch the dependency graph, but yes, this includes files in node_modules that your app imports (since those can change if you bump the package version).
It may be related to that. If it’s too much effort to trim down, please don’t worry.

I'll still give it a go, it's fairly easy to copy then delete stuff out, take a 50/50 approach.

Thanks, I really appreciate it. I know it’s annoying to spend time on this.

It quite hard to reproduce the issue.. I also see this, but after a reinstall it works fine again.
However, this might help: I notice that it seems in my previous install, fsevent is failed to run (it said something about the binary). This means the fsevent folder is existed in my node_modules folder, but it still using a lot of CPU, so I think check if fsevent is installed is not enough..
Also, I reinstall with Yarn, so maybe it not because Yarn or NPM, at least in my case. They works both fine this time (run fsevent succesfully)

Also @gaearon , regarding this:

It normally should only watch the dependency graph, but yes, this includes files in node_modules that your app imports (since those can change if you bump the package version).

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/scripts/start.js#L278
Doesn't this line mean we don't watch files in node_modules?

I'm not sure to be honest 😛

I'll close this; let me know if this still happens!


Update get-started.md

fair point :D We could also add that directly to the readme while we're at it.


Events should pass language key that succeeded or failed

Hello,
From inside a language change or load event handler, how can you determine the language key that was changed or loaded successfully or unsuccessfully?
If there is no easy way, then perhaps something like this should be implemented:
$rootScope.$emit('$translateChangeSuccess',{key:key});

This feature has been added.


controlsContainer option is broken

Issue description:  Specifying custom controls using controlsContainer has been broken since 2.8.7. There everything worked fine, but some commits in master breaks this feature.
Demo link/slider setting: I have something like this:
var controls = document.getElementById('#foo');
var carousel = tns({
  controlsContainer: controls
});

where #foo looks like this (simplified):

  <button class="...">prev</button>
  <button class="...">next</button>
  ..."

Inside .nav there are pages, they still do work correctly. But prev and next buttons are broken. Buttons are not recognized and default buttons are created insted. In 2.8.7, this king of setup worked. I tried to specify buttons using prevButton and nextButton, but that worked neither. I believe it's broken since this commit https://github.com/ganlanyuan/tiny-slider/commit/bdf8bcdf22041a0001e16526ae6dbf68a1080a1b.
Since 2.8.7 there are few bugs fixed, that's why I have tried to use master version of plugin.
Tiny-slider version:   master
Browser name && version:  Chrome, whatever

Confirming it works. Thank you!

Thanks


Update README with an example Cartfile

Thank you! I totally forgot about this. 😞 I did change the text a bit, hope you don't mind. 😉


[WIP/RFC] Fix calling XMapWindow before XSetClassHint

Add new context CONTEXT_PLAYER, move the XMapWindow call to the
set_context function in os_x11.cpp. Add another set_context call for
when you hit the play button.
Resolves #4827
NOTE: This pull request really needs to be reviewed/tested as it might lead to other bugs. There might also be better ways of doing this than what I have done here.

The changes look good a priori, though I'm no X11 expert to assess it. I'll test the patch on Linux X11 to see how it behaves.

It seems to work fine, but there are some notable changes. When opening a project in the project manager, before this PR, the behaviour (somewhat confusing) was to spawn the child window, maximize it, and load the contents; with the patch, the behaviour is that the project manager window is killed, nothing happens visually for a few seconds, and then the editor window is created and shows up non maximized.
It might be a better behaviour than the previous one, but needs to be discussed, as it also kinds of gives the feeling that the project manager crashed and that something is off when you need to wait several seconds to get any further visual feedback.

@akien-mga Both behaviors is kind of bad tbh. It's just the way it's coded plus how long it takes for the project/editor to load, in any case it looks like the program is about to crash/freeze. I don't know about the non maximized thing as I'm using a tiling wm, I really think godot should remember it's last window state, so that might be worth looking into.
Something I would like to see tested is the x11 export template and see if the xprop tool returns "Godot_Player". I don't know how to build those myself, and have no time to look into it for a few days.
As for the change itself, I think it's important because it makes godot more compliant with xorg standards, or at least more compatible with highly customizable linux desktop environments.
Thanks for the feedback though, will try to fix that whitespace issue as soon as possible.

Some input from an X11 guru would be nice :)
(sneak ping to @Hinsbart :p)

Just a small update to this issue. I tried to resolve the merge conflict, but due to the new changes I was unable to make this work properly again, so either we just close this pull request or someone with more knowledge than me could look into it.

Let's close for now; it's linked in the bug report #4827 so a potential contributor willing to fix it can use this closed PR as a reference.


Create Readme.md

hello people!
Description

[x] I have added a folder(Named it as my GitHub user id)
[x] I have added a Readme.md file inside the folder
[x] I understand the GitHub Forking Concept fully

this is the last one


MicrosoftDocs/azure-docs#58967

Changes have been made in below declarations as per the customer's suggestion to remove the confusion between 'SqlConnection' class and 'MySqlConnection' class:

'mySqlConnection.Open' ---> 'SqlConnection.Open'
'mySqlConnection.Execute' ---> 'SqlConnection.Execute'

@AnuragSharma-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change. @dalechen

GitHub

@itechedit Could you please review the PR and approve if find appropriate. Thanks

Hi @daleche-sh @MashaMSFT @CarlRabeler - Could one of you review this pull request? Note that the metadata author attribute should be the author's GitHub user name. Automated notification failed because the current value (dalechen) isn't a valid value for this attribute. Thanks!

#sign-off

@stevestein: I'm sorry - only the author of this article, @dalechen, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


feat: a simple REPL for debugging purpose

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Before removing SQL interface from Datanode ( #1010 ), we need something as a substitute to mysql-cli. This REPL can serve the purpose. It's largely inspired by influx-iox. Simple, yet powerful, has history and hint, can directly execute SQL via our grpc interface.
Some screenshots:
start and help:

the subcommand is "cli" and then "attach"
hint based on history ("tab" to complete it):

multiline support:

executing sqls:

Checklist

[x]  I have written the necessary rustdoc comments.
[x]  I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)
#1010

The code looks good to me. Just wonder if there is any benefit if we move cli to a separated module? Is there any footprint on size of greptime binary after adding this?

➜  my-greptimedb git:(feat/cli-repl) lh target/debug/greptime
-rwxr-xr-x  1 luofucong  staff   370M Feb 24 15:42 target/debug/greptime
➜  my-greptimedb git:(develop) lh target/debug/greptime
-rwxr-xr-x  1 luofucong  staff   369M Feb 24 15:45 target/debug/greptime
Adding CLI REPL feature will increase 1MB to the binary size, which is negligible. @sunng87

https://github.com/GreptimeTeam/docs/pull/214 @killme2008


Profiling on GPU.

Hi all,
As I strive to make my forwards models faster I am finding results that are counter-intuitive. For example, a vectorised version running slower than a non-vectorised version. I am starting to wonder if this is a CPU thing so I would like to do some testing on GPU.
Hit me up if you have a free GPU to run some code.
Regards
Jordan.

We have GPUs at SMP, or you can try Colab (but it will only work in 32 bit).
———————————————
Dr Benjamin Pope (he/him)
Lecturer in Astrophysics
University of Queensland
benjaminpope.github.io

From: Jordan Dennis @.>
Sent: Thursday, January 5, 2023 10:50:28 AM
To: LouisDesdoigts/dLux @.>
Cc: Subscribed @.***>
Subject: [LouisDesdoigts/dLux] Profiling on GPU. (Issue #179)
Hi all,
As I strive to make my forwards models faster I am finding results that are counter-intuitive. For example, a vectorised version running slower than a non-vectorised version. I am starting to wonder if this is a CPU thing so I would like to do some testing on GPU.
Hit me up if you have a free GPU to run some code.
Regards
Jordan.
—
Reply to this email directly, view it on GitHubhttps://github.com/LouisDesdoigts/dLux/issues/179, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN6YFIZ6VLEE4DA45UGX3LWQYEEJANCNFSM6AAAAAATRK4OUI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Colab is probably the easiest, but comparing performance across different hardware is kind of apples to oranges...
I'm a little suspicious that a vectorised version is running slower though, where is this in the code?

Here are two implementations,
@ft.partial(jax.jit, inline=True)
def soft_square_aperture(width: float, ccoords: float) -> float:
    pixel_scale: float = get_pixel_scale(ccoords)
    acoords: float = jax.lax.abs(ccoords)
    x: float = jax.lax.index_in_dim(acoords, 0)
    y: float = jax.lax.index_in_dim(acoords, 1)
    square: float = ((x < width) & (y < width)).astype(float)
    edges: float = ((x < (width + pixel_scale)) & (y < (width + pixel_scale))).astype(float)
    return ((square + edges) / 2.).squeeze()

@ft.partial(jax.jit, inline=True)
def _soft_square_aperture(width: float, ccoords: float) -> float:
    pixel_scale: float = get_pixel_scale(ccoords)
    acoords: float = jax.lax.abs(ccoords)
    square: float = (acoords < width).prod(axis = 0).astype(float)
    edges: float = (acoords < (width + pixel_scale)).prod(axis = 0).astype(float)
    return (square + edges) / 2.

Running this on my machine I find that,

Which is nearly a factor of ten.

Similar results on colab

The vectorisation thing seems to be really prevalent. Here is another example with similar results,
import jax

@jax.jit
def hypotenuse_v0(coords: float) -> float:
    return jax.lax.sqrt(jax.lax.integer_pow(coords, 2).sum(axis = 0))

@jax.jit
def hypotenuse_v1(ccoords: float) -> float:
    x: float = ccoords[0]
    y: float = ccoords[1]
    return np.hypot(x, y)

@jax.jit
def hypotenuse_v2(ccoords: float) -> float:
    x: float = ccoords[0]
    y: float = ccoords[1]
    x_sq: float = jax.lax.integer_pow(x, 2)
    y_sq: float = jax.lax.integer_pow(y, 2)
    return jax.lax.sqrt(x_sq + y_sq)

@jax.jit
def hypotenuse_v3(ccoords: float) -> float:
    x: float = jax.lax.index_in_dim(ccoords, 0)
    y: float = jax.lax.index_in_dim(ccoords, 1)
    x_sq: float = jax.lax.integer_pow(x, 2)
    y_sq: float = jax.lax.integer_pow(y, 2)
    return jax.lax.sqrt(x_sq + y_sq)

%%timeit
hypotenuse_v0(ccoords)

%%timeit
hypotenuse_v1(ccoords)

%%timeit
hypotenuse_v2(ccoords)

%%timeit
hypotenuse_v3(ccoords)

The builtin version as a benchmark showed similar performance to v2 and v3. The builtin version actually checks for zeros to avoid calling integer_pow on them. This is all really confusing me and I am thinking that I might make a jax issue since it is very counter intuitive.

Yes mostly. I often forget it the first time though.

Here is my times,

You can see it is a significant difference. What's more is the jaxpr looks really nice for v0 at just three lines. Many less than the others.

So @jakevdp ran my code on a GPU and they all had very similar performance. He implied that XLA compiler has seen a lot more work on GPU than on CPU. @benjaminpope is there any chance I can use some of the SMP GPUs (or just send the code to you)?

Honestly it colab would be the quickest and easiest

Last time I tried colab I got the same results, but that might have been instance specific.

Similar results on colab

Colab CPU:

Colab GPU:

Relative times appear the same

I musn't have set up COLAB correctly. I'll look into it a bit more since I don't normally use it.


[BUG]:  Make build fail in goicicle

Description
When attempting to compile the CUDA code within goicicle using make all, the process fails with the following error:
/usr/local/cuda/bin/nvcc -DG2_DEFINED -Xcompiler -fPIC -std=c++17 -shared ../icicle/curves/bn254/lde.cu ../icicle/curves/bn254/msm.cu ../icicle/curves/bn254/projective.cu ../icicle/curves/bn254/ve_mod_mult.cu -o libbn254.so
gcc: error: ../icicle/curves/bn254/lde.cu: No such file or directory
gcc: fatal error: no input files
compilation terminated.
make: *** [Makefile:22: libbn254.so] Error 1

Cause
The error message indicates that the required bn254 curve files (lde.cu, msm.cu, projective.cu, ve_mod_mult.cu) are not found in the expected directory (../icicle/curves/bn254/).
Context
Caused by latest updates to Icicle.  Bindings compile fine on commit f8610dd5.

@bigsky77 having a look at this

Known issue, use V0.1.0


generalized steps for storage class change

As PVCs change from version to version, the generalized steps for storage class change will be applicable for any PVCs in any namespaces.

This change is

fixes #1323

/ok-to-test
/assign
Preview: https://deploy-preview-1409--competent-brattain-de2d6d.netlify.com/docs/other-guides/kubeflow-on-multinode-cluster/

Thanks!
/lgtm
/approve


Any plans to build deeplinks?

Do you have any plans to build deeplinks to the core actions of the app?

We do for plugins https://github.com/wulkano/Kap/issues/697, what use case do you have in mind?

hello
I might have a use case that only concerns deeplink to start recording in kap that does not concern plugins.
I want to create a deeplink from raycast to start recording.


Update irsa docs to follow best practices and address any security concerns

Issue #, if available:
https://t.corp.amazon.com/P167988780
Description of changes:
This PR addresses two security concerns:

Using S3 ACL to grant public read access to bucket objects is no longer a recommended way of making files public. The recommended best practice is to disable all ACL policies and provide access using bucket policies.

General best practice for IAM role trust policy is to have both the "aud" and "sub" conditions. Access Analyzer has a policy check rule that detects when the "aud" condition is missing from the policy: https://docs.aws.amazon.com/IAM/latest/UserGuide/access-analyzer-reference-policy-checks.html#access-analyzer-reference-policy-checks-suggestion-confirm-audience-claim-type

Testing (if applicable):
make -C docs build

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/cherry-pick release-0.21

/cherry-pick release-0.20

/cherry-pick release-0.19


Variables view after execution is terminated doesn't clear itself and next the Variables view becomes unusable in next execution.

VSCode Version: 1.35.1
OS Version: windows 8

Steps to Reproduce:

using custom debug adapter
when program terminates debug adapter sends Terminate Request to client.
when debug adapter received Disconnect request it closes the session with client.
before the terminate there was one variables request pending as its response was not sent.
once disconnect the execution stops but the variable view keeps showing loader and it never clear the loader as the response to variables request was never sent.

Does this issue occur when all extensions are disabled?: Yes/No

This is fixed with latest vscode. You are using version 1.35 which is like a year old.
If you can reproduce with vscode insiders let us know and we can  reopen.
Thank you


Support for non blocking mode

Support for non blocking mode in case one wants to use the main thread for other things. I use it to handle a Pygame application and have the MQTT stuff run in its own thread.
I also took the liberty of handling the naughty behaviour of the Paho MQTT library to silently eat exceptions in the user callback.

Great! Glad to be able to contribute.


stay in 1 location

can make stay in 1 location?

Would be very useful since there are some known locations with frequent good spawns. This feature would require the ability to spin pokestops and engage pokemon from a distance.

Yeah I'm thinking of coding an algo to generate a cycle optimal for around 5+min so that you can just travel in circles around the same area. Is anyone doing this @pokemongo-dev

actually there's nothing do anything for walk random
i hope can stay in 1 location
in scan circle have 3 or 4 pokestop for farming poke

similar to existing #95 and #830 , oh, and  #334

close this


Add * to valid jvm pattern for debug address, self-hosted

I am quite sure * inside [] is a literal match, not a quantifier, so no escaping
did not yet run all unit tests, can hold merge for now

When deploying, I get
Success: Deployed target/application.zip
WARNING Invalid or misplaced JVM options in services.xml: -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005. See https://docs.vespa.ai/en/reference/services-container.html#jvm

but deployment succeeds, and I am able to debug, so it is OK self-hosted - but I think it is better without the warning unless this has side-effects

* should be allowed, agreed, moved it so that - is not used to create a range

right! running all unit tests with this now. This is from the Intellij defaults

all tests passed


Support for projects in board view

I was wondering if supporting board projects is on the roadmap.  I love using the shortcuts, and it feels so sluggish when working on a project in board view. Thank you so much for this amazing project!

Hey, glad you appreciate it!  todoist-shortcuts is in maintenance mode, though, so mostly fixes to existing functionality.
This would be a big undertaking, and it's hard for me to motivate doing it when I don't use board mode.  Certainly a PR adding this would be appreciated

+1. Love this plugin as-is, but alternating List/Board view would be a huge QoL improvement. 🙏

I second @rich88.  A keyboard shortcut to at least switch between list and board view would be a huge improvement.  It's a pretty cumbersome manual operation that I find myself doing a lot during project cleaning.

@mgsloan can you point in the right direction - what code needs to be changed to support board view?

@tonyxiao hey, sorry about the delay, added this to my todos got a bit backlogged hah

Add a new keymap and logic in updateKeymap to detect that it's in board view and switch to the board view keymap

Implement the action functions needed to make the keymap work.  Reference the actions in the other keymaps may be helpful.


<EMAIL_ADDRESS>decompress error

Hi, when I try to install wingetui I have this issue. It start at 3.1.1
I use NanaZip.
When I'm trying to install manually I don't have any problem.
PS C:\Users\xxx\Desktop> scoop install extras/wingetui
Installing 'wingetui' (3.1.2) [64bit] from 'extras' bucket
WingetUI.Installer.exe (52,9 MB) [============================================================================] 100%
Checking hash of WingetUI.Installer.exe ... ok.
Extracting WingetUI.Installer.exe ... ERROR Exit code was 1!
Failed to extract files from C:\Users\xxx\scoop\apps\wingetui\3.1.2\WingetUI.Installer.exe.
Log file:
innounp.log
~\scoop\apps\wingetui\3.1.2\innounp.log
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=wingetui%403.1.2%3A+decompress+error

Duplicates #13709.


Race condition in Find

Seen on 611e613459953787a01c2afc82835aa0ba01a045. With users table on local Postgres (but actually happens with any struct, backing SQL table not required).
t.go:
package main

import (
	"fmt"
	"os"

	_ "github.com/lib/pq"

	"github.com/jinzhu/gorm"
)

var db gorm.DB

type User struct{}

func find() {
	var u User
	fmt.Println(db.Find(&u, 1).Error)
}

func main() {
	var err error
	db, err = gorm.Open("postgres", os.Getenv("DB"))
	if err != nil {
		panic(err)
	}

	go find()
	find()
}

bodhi$ ./e_d go run -race t.go
==================
WARNING: DATA RACE
Write by main goroutine:
  github.com/jinzhu/gorm.(*Scope).GetModelStruct()
      $GOPATH/src/github.com/jinzhu/gorm/model_struct.go:393 +0x13d3
  github.com/jinzhu/gorm.(*Scope).TableName()
      $GOPATH/src/github.com/jinzhu/gorm/scope.go:282 +0x2a6
  github.com/jinzhu/gorm.(*Scope).QuotedTableName()
      $GOPATH/src/github.com/jinzhu/gorm/scope.go:292 +0x1e2
  github.com/jinzhu/gorm.(*Scope).prepareQuerySql()
      $GOPATH/src/github.com/jinzhu/gorm/scope_private.go:305 +0x19a
  github.com/jinzhu/gorm.Query()
      $GOPATH/src/github.com/jinzhu/gorm/callback_query.go:44 +0x6c3
  github.com/jinzhu/gorm.(*Scope).callCallbacks()
      $GOPATH/src/github.com/jinzhu/gorm/scope_private.go:319 +0x98
  github.com/jinzhu/gorm.(*DB).Find()
      $GOPATH/src/github.com/jinzhu/gorm/main.go:215 +0x102
  main.find()
      $GOPATH/src/github.com/theplant/hsm2-backend/t.go:18 +0x165
  main.main()
      $GOPATH/src/github.com/theplant/hsm2-backend/t.go:29 +0x252

Previous read by goroutine 7:
  github.com/jinzhu/gorm.(*Scope).TableName()
      $GOPATH/src/github.com/jinzhu/gorm/scope.go:282 +0x323
  github.com/jinzhu/gorm.(*Scope).QuotedTableName()
      $GOPATH/src/github.com/jinzhu/gorm/scope.go:292 +0x1e2
  github.com/jinzhu/gorm.(*Scope).prepareQuerySql()
      $GOPATH/src/github.com/jinzhu/gorm/scope_private.go:305 +0x19a
  github.com/jinzhu/gorm.Query()
      $GOPATH/src/github.com/jinzhu/gorm/callback_query.go:44 +0x6c3
  github.com/jinzhu/gorm.(*Scope).callCallbacks()
      $GOPATH/src/github.com/jinzhu/gorm/scope_private.go:319 +0x98
  github.com/jinzhu/gorm.(*DB).Find()
      $GOPATH/src/github.com/jinzhu/gorm/main.go:215 +0x102
  main.find()
      $GOPATH/src/github.com/theplant/hsm2-backend/t.go:18 +0x165

Goroutine 7 (running) created at:
  main.main()
      $GOPATH/src/github.com/theplant/hsm2-backend/t.go:28 +0x24c
==================
pq: zero-length delimited identifier at or near """"

(pq: zero-length delimited identifier at or near """")
[2015-11-14 00:52:52]
pq: zero-length delimited identifier at or near """"
Found 1 data race(s)
exit status 66

+1

+1

This data race is a fine, won't cause anything wrong. but I know it is kind of annoying to get this error, will look into it later.

Yes, this is pretty annoying - it would be good to get it silenced.

I think you're falling afoul of this data race, where the read side of the race is a copy of the ModelStruct which happens as you call (ModelStruct).TableName() . And I don't believe there is such a thing as a harmless data race, even aside from the noise!
As a bonus, the required fix for this race is tiny.

After fixing the original race, there is another race with exactly the same code:
==================
WARNING: DATA RACE
Read by main goroutine:
  github.com/jinzhu/gorm.(*Scope).Fields()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/field.go:74 +0x262
  github.com/jinzhu/gorm.(*Scope).whereSql()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope_private.go:160 +0xfd
  github.com/jinzhu/gorm.(*Scope).CombinedConditionSql()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope.go:298 +0x119
  github.com/jinzhu/gorm.(*Scope).prepareQuerySql()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope_private.go:305 +0x36d
  github.com/jinzhu/gorm.Query()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/callback_query.go:44 +0x9a5
  github.com/jinzhu/gorm.(*Scope).callCallbacks()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope_private.go:319 +0x95
  github.com/jinzhu/gorm.(*DB).Find()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/main.go:215 +0x10f
  main.find()
      /home/pwaller/tmp/t/t.go:18 +0x166
  main.main()
      /home/pwaller/tmp/t/t.go:29 +0x254

Previous write by goroutine 7:
  github.com/jinzhu/gorm.(*Scope).GetModelStruct()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/model_struct.go:394 +0x100b
  github.com/jinzhu/gorm.(*Scope).TableName()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope.go:282 +0x2b8
  github.com/jinzhu/gorm.(*Scope).QuotedTableName()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope.go:292 +0x1eb
  github.com/jinzhu/gorm.(*Scope).prepareQuerySql()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope_private.go:305 +0x342
  github.com/jinzhu/gorm.Query()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/callback_query.go:44 +0x9a5
  github.com/jinzhu/gorm.(*Scope).callCallbacks()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/scope_private.go:319 +0x95
  github.com/jinzhu/gorm.(*DB).Find()
      /home/pwaller/.local/src/github.com/jinzhu/gorm/main.go:215 +0x10f
  main.find()
      /home/pwaller/tmp/t/t.go:18 +0x166

Goroutine 7 (running) created at:
  main.main()
      /home/pwaller/tmp/t/t.go:28 +0x24f
==================

This kind of race is not harmless.


Support the last version of Android Studio with Dagger 2

Hello guys are you going to fix this plugin for dagger 2? It will be so great!

No plans, no. If you have a specific problem please file specific bugs. There's already some Dagger 2 ones like #25.

Got it, it's very sad.
Unfortunately this plugin does not work at all with AS 3.0.1 and Google Dagger 2.14.1


LibWeb: Fix MouseEvent position values

The clientX and clientY values are, as per the spec, the offset from the viewport.
This makes them actually be that and also fixes up the calculations for offsetX, offsetY, pageX and pageY.
I assume all of these got messed up in some sort of refactor in the past.
The spec comment from the now-removed compute_mouse_event_client_offset() function sadly has no convenient place to be anymore so, for now, it is just gone as well.
Personally, I think it'd make sense to refactor a lot of this file so that not every mouse event repeats a large chunk of (almost) identical code. That way there'd be a nice place to put the comment without repeating it all over the file.
But that is out of the scope of this PR.
Also: I know, offsetX and Y are not fully fixed yet, they still don't ignore the element's CSS transforms but I am working on that in a new PR.

could you add a test for this change?

I've added a test over in #2372 (essentially part 2 of this commit) that takes care of all the mouse position values at once.
I hope that's ok.

I've added a test over in #2372 (essentially part 2 of this commit) that takes care of all the mouse position values at once. I hope that's ok.

I'd rather have a (partial) test in this PR so we don't depend on merging another PR for this code to be tested.

I've split the test into two now and added the relevant half here.

could you include the text from the PR description in the commit message? the current commit message is a bit sparse, and since the commit message is more important than the PR description, it would be better to provide a detailed explanation there.

could you include the text from the PR description in the commit message? the current commit message is a bit sparse, and since the commit message is more important than the PR description, it would be better to provide a detailed explanation there.

Also done.


Document Data Ingestion Pipeline

The data ingestion pipeline must be documented (in the EcoPylot Sphinx documentation pages) before we start to implement

https://github.com/sustainableaviation/EcoPyLot/issues/6

This documentation will then serve as the technical specification of the data ingestion pipeline.

[!NOTE]
This documentation is distinct from any API documentation (based on Python docstrings) that will be auto-generated from the data ingestion classes/functions. It should provide (technical) users a straightforward way to understand the data ingestion pipeline in the context of the entire project.

Ideally, this would include:

[ ] sample data (input/output)
[ ] a Mermaid diagram, if applicable
[ ] a short explanation of our choices behind the logic

@iamsiddhantsahu, as discussed please start from the docs/content/structure.md file.


add Pbp job agent

I am sending this PR as a formality after our last demo. I am not sure how to set it up as a branch on your repo. I developed a job agent utility for SOUNDTRAP and NRS, incorporating new datetime formats and regex patterns. Most of the code is new and doesn't interfere with your existing work. I only took the liberty of modifying the Windows-based routines in your code base which I improved upon by utilizing the Path library in places where it belonged.

Hi @spacetimeengineer - Seems like there's a failed check.
More in general, when do you think you will be completing your changes (and providing instructions) so @danellecline , @ryjombari and I we can plan on reviewing/testing? If possible, we would like to advance that review exercise in preparation for our meeting this Thursday. Thanks!

@spacetimeengineer – I checked out your branch in my local dev env.

all looking good to me so far. As you say, all is pretty much new code with no, or very minimal adjustments in pre-existing code.

seems like a file needs reformatting (you can run just format)

consistent with the failure in CI, there's a failed test:

tests/test_file_helper.py .
tests/test_json_support.py ...
tests/test_meta_generator.py .F...
tests/test_metadata.py ...
tests/test_misc.py ..
tests/test_simpleapi.py ..

with that a failed test being:
========== FAILURES ==========
___ test_soundtrap_generator_local _____________
...
>       assert len(json_files) == 1
E       assert 0 == 1
E        +  where 0 = len([])

tests/test_meta_generator.py:129: AssertionError
----------------------------------------------------------------------- Captured stderr call ------------------------------------------------------------------------
2024-12-16T15:08:20.894095-0800 INFO Coverage plot saved to tests/json_generator_tmp/soundtrap_s3/soundtrap_coverage_20230715_20230716.jpg
2024-12-16T15:11:42.895969-0800 INFO Searching in file:///Users/carueda/github/mbari-org/soundscape-repos/pbp/tests/wav/soundtrap/*.wav for wav files that match the prefixes ['6716']* ...
Searching : / |#                                      | 0 Elapsed Time: 0:00:00
Searching : - |#                                      | 0 Elapsed Time: 0:00:00
2024-12-16T15:11:42.899441-0800 INFO Found 0 files to process that covers the expanded period 2022-11-15 00:00:00 - 2022-11-17 00:00:00
2024-12-16T15:11:42.899736-0800 INFO No data found between 2022-11-16 00:00:00 and 2022-11-16 00:00:00

@spacetimeengineer – We have just updated the main branch with incorporation of the end-user documentation setup and markdown sources (which were previously maintained in a separate repo).
You will see a new pbp-doc/ directory when you sync your branch.
It would be great if you could also add some documentation for the new job agent in that setup, which is based on mkdocs, with mkdocs-material. In a nutshell, under pbp-doc/, it would be a matter of:

creating a pbp-job-agent/ dir and adding an index.md file there
under the nav section in mkdocs.yml, adding something like:  - Job Agent: pbp-job-agent/index.md

adding documentation in pbp-job-agent/index.md

Thanks for considering.


Document ReFrame flags used on different machines

It seems there are a few quirks that require passing flags to ReFrame on each system that aren't currently included in the documentation. The way we advise to run in README by reframe -c apps/BENCH_NAME -r --performance-report rarely works out of the box and may confuse new users. For example, most systems require you to specify an account or a queue type, the syntax varies by system and can't be easily abstracted. We should document system specific flags in one place, I'd say in a separate markdown file that is linked from README.

This is done, see systems