vimPlugins: Automate git commits when updating.

Motivation for this change
This is a followup and continuation of the work and discussion in #83119. Highlights:

A new --commit flag eliminates the need for a multi-step process for updates and updating redirections.
A new --add argument eliminates the need for a multi-step process for updates and adding packages and also eliminates the need for manually editing vim-plugin-names.
A minor bugfix in the deprecation script.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@timokau

The roadmap I envision going forward is to break out the --add functionality  so a single package can be added without updating the whole package set. I suspect this will be a large diff so I'd rather hold off for another PR and just automate the current process in this PR. Once we have a bot doing updates contributors would then be able to do single-commit PR's to add packages. My premise is that the processes of updating and adding packages should be completely separated.

The roadmap I envision going forward is to break out the --add functionality so a single package can be added without updating the whole package set. I suspect this will be a large diff so I'd rather hold off for another PR and just automate the current process in this PR. Once we have a bot doing updates contributors would then be able to do single-commit PR's to add packages. My premise is that the processes of updating and adding packages should be completely separated.

That would be nice. I think it would be even better to save every plugin in a separate file. That way we wouldn't have to worry about merge conflicts any more (though your proposal would already help with that).
One downside is that we currently get semi-regular updates "for free" whenever someone adds a plugin. But that could be done better with appropriate automation.

Also I want to say that I think the contribution, code and git commits are of very high quality, which might get lost in my nitpickyness here.

I'd like to say that the review has been of very high quality which might get lost in my defensive responses to many of the review comments. :)

Everything else looks good to me, but this needs a rebase because of #83798 and there's the outstanding issue with the dirty/master check.

I agree with you to a certain extent about the dirty/master checks and at the very least the flag should be renamed.
I'm concerned that this auto-committing behavior is going to be a footgun for people who just want to add a damn package. For example I would probably run this script on whatever branch I have checked out at the time, stash the changes, and checkout a new branch to make a PR. The git experts are going to figure out what happened (eventually) and be able to rebase --onto X Y Z but the majority are going to be confused and frustrated.
I think we should be particularly conscious of this kind of user in our interface choices, not only because we'll be fielding their questions and PR's, but because vim configuration in nixos is already uniquely complicated compared to any other operating system. Would it be too much to ask those of us with advanced use cases to pass a --force/-f flag?

I agree with you to a certain extent about the dirty/master checks and at the very least the flag should be renamed.
I'm concerned that this auto-committing behavior is going to be a footgun for people who just want to add a damn package. For example I would probably run this script on whatever branch I have checked out at the time, stash the changes, and checkout a new branch to make a PR. The git experts are going to figure out what happened (eventually) and be able to rebase --onto X Y Z but the majority are going to be confused and frustrated.

That's a good point I hadn't thought about. The current solution is not only inconvenient though,  its also not very reliable. For example, I never use a local tracking branch for master. I just use the remote upstream/master directly.
$ git show master
fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

So I would still rather remove those checks. Maybe print a warning that commits were created on the current branch. If there was a mistake, there's no complicated rebasing necessary. The contributor can just repeat the changes on the appropriate branch. If you think this is necessary, you could also ask for confirmation interactively (with a flag to disable this).
And the other part of the issue, the dirty tree, is not really affected by this. Is there any downside to only checking the relevant files for "dirt"?

I think we should be particularly conscious of this kind of user in our interface choices, not only because we'll be fielding their questions and PR's, but because vim configuration in nixos is already uniquely complicated compared to any other operating system. Would it be too much to ask those of us with advanced use cases to pass a --force/-f flag?

Keep in mind that this complexity is opt-in though. Users can still use and configure vim as they do on any other distro, including plugin management. We should still try to make the experience as frictionless as possible of course.

The particular scenario you describe could be worked around:
    try:
        if not allow_dirty and (
            repo.head.ref == repo.heads.master
            or repo.head.commit != repo.heads.master.commit
        ):
        raise Exception(
            "Please create a new branch based off master before running this tool."
        )
    except AttributeError:
        raise Exception(
            "For advanced use cases, please pass the --allow-dirty flag."
        )

If there was a mistake, there's no complicated rebasing necessary. The contributor can just repeat the changes on the appropriate branch.

They would also need to reset HEAD on the branch they were on.

And the other part of the issue, the dirty tree, is not really affected by this. Is there any downside to only checking the relevant files for "dirt"?

My thinking is that a dirty tree is indicative of being unprepared to commit. If you checked out a fresh branch, why would the tree be dirty?
My thinking here is that "indicative" is good enough. IMO, if these checks are helpful (or benign) for the vast majority of use cases, making the minority pass a flag to bypass them is acceptable. Any kind of safety device is a trade off that is somewhat annoying to "power users".

My thinking is that a dirty tree is indicative of being unprepared to commit. If you checked out a fresh branch, why would the tree be dirty?

I agree. If I did have unstaged changes, it was likely something else i was working on and not related to running the plugin update script

The particular scenario you describe could be worked around:

How does this work around it? Or do you mean that the workaround is telling the user to use --alow-dirty? I wouldn't consider my use case advanced, I think its quite common (for a read-only branch its more convenient to just use the remote directly).

They would also need to reset HEAD on the branch they were on.

True. Or they could use the XKCD approach: https://xkcd.com/1597/

And the other part of the issue, the dirty tree, is not really affected by this. Is there any downside to only checking the relevant files for "dirt"?

My thinking is that a dirty tree is indicative of being unprepared to commit. If you checked out a fresh branch, why would the tree be dirty?

Uncommitted changes are preserved when checking out a fresh branch. I might have some unstaged package update that I haven't gotten around to committing yet. I don't see much value in this check. Its not a very reliable indicator of "not being on the correct branch" and I do see it as being annoying often enough. Though it seems I'm outvoted on this one, and I don't feel that strongly about it as long as there's a short -f flag to get around it. So I won't insist.

My thinking here is that "indicative" is good enough. IMO, if these checks are helpful (or benign) for the vast majority of use cases, making the minority pass a flag to bypass them is acceptable. Any kind of safety device is a trade off that is somewhat annoying to "power users".

There's a tradeoff here though. I think the indicator is unreliable, the benefit is small and we can expect some git competence from committers here. Resetting a branch is very basic. They'll have to find a way to do it eventually anyway. At the same time I'm pretty sure I would've unnecessarily tripped up these safety checks several times already.
The other advantage is that it makes the --allow-dirty flag unnecessary for infrastructure development.

I wouldn't consider my use case advanced, I think its quite common (for a read-only branch its more convenient to just use the remote directly)

If it's common then it could be more explicitly supported by the check.

True. Or they could use the XKCD approach: https://xkcd.com/1597/

Yeah, that's best avoided with 200,000+ commit projects.

Uncommitted changes are preserved when checking out a fresh branch. I might have some unstaged package update that I haven't gotten around to committing yet.

Interesting. I never intentionally do this this myself but perhaps git just supports too many workflows for checks like these to have high indicative value.

I wouldn't consider my use case advanced, I think its quite common (for a read-only branch its more convenient to just use the remote directly)

If it's common then it could be more explicitly supported by the check.

Then you'd have to worry about identifying the correct remote. There may be multiple to choose of. For example I have upstream and timokau.

True. Or they could use the XKCD approach: https://xkcd.com/1597/

Yeah, that's best avoided with 200,000+ commit projects.

Tongue-in-cheek of course.

Uncommitted changes are preserved when checking out a fresh branch. I might have some unstaged package update that I haven't gotten around to committing yet.

Interesting. I never intentionally do this this myself but perhaps git just supports too many workflows for checks like these to have high indicative value.

Yes, in my opinion that is the case.

Ok, I'm convinced. The checks are removed. I don't see much value in checking just the committed files status as that doesn't seem like that probable of an issue to have. I can squash the review commits if desired.

Great, looks good to me! Yes I think squashing would be good. Some history can (and should) be preserved, but everything that changed due to review can be squashed. For example, I think the --add commit should remain separate from the auto-commit one.

There's still one commit that only contains review changes. Is that intentional? If so, that's also fine by me.

Yes, it was intentional because I don't know how to rebase it into the other commits in a reasonable way.

If you need a review in the future or you have reviewed a PR that is ready for merge, feel free to ping me. No guarantees of course.


feat: Add endpoints for sequence metadata

Specifically, api/get_oeis_name_and_values/<OEIS_ID> is guaranteed
to give the correct official OEIS name of the sequence, and
api/get_oeis_metadata/<OEIS_ID> which returns the official name,
cross references, and beack references to the sequence.
Documents these in the README (as there isn't really any other documentation
place at the moment).
Also removes the obsolete TODO.md (it only had one item, which is done, and
we mostly rely on GitHub issues for todos now anyway).
Resolves #17.
Basically, this is just a version of #26 compatible with the new resolve to only store data in the database, and that PR should be closed once this is merged.

I got this weird error at the same URL which was previously working (I loaded this url, then tried the "and_name" endpoint in another tab, then came back and reloaded this tab).

Another comment:  could we put a full example URL for a safe (not too many crossrefs) sequence in the readme, so people can click something and see it in action?  I know the base URL may change, but that would work, for example, on my system.  Or is this bad practice?

I got this weird error at the same URL

Not too much I can do about this directly with the limited info. I will put in a trap for a non-integer where that happened and issue what will hopefully be a more informative error in case it happens again.

Another comment: could we put a full example URL for a safe (not too many crossrefs) sequence in the readme, so people can click something and see it in action? I know the base URL may change, but that would work, for example, on my system. Or is this bad practice?

Sure, I will add an example to each of the URL sections with a not-too-big sequence ID.

OK, I've made the fixes described above. Feel free to request further action on the items you brought up that I responded to merely with an explanation, so far.

I got this weird error at the same URL

Not too much I can do about this directly with the limited info. I will put in a trap for a non-integer where that happened and issue what will hopefully be a more informative error in case it happens again.

I was not able to reproduce it this time around, although I tried to do a bit of stress-testing and managed the attached screenshot, which means things are working as described. :)

Ok, here's a mystery for you.  When I look at the markup directly, I don't see "COUNT" in the first endpoint.  But when I look in the diff of changes on github, or in my local directory, I see it.  Am I losing my mind?

I was not able to reproduce it this time around

Ah but you did. That must be the message that was causing the error before. So my trap is working, and revealing the issue. So yes, it seems as though the OEIS is detecting that we generate a lot of hits and protecting itself, and so if one just waits and tries again it works. That state of affairs seems OK to me; I think we can just go ahead with this scheme and if any difficulties seem to arise in what actually ends up in the database we can track them down when it happens. Sound OK?

Ok, here's a mystery for you.

Must be something about how github markdown works. I will try to fix in the next commit.

Thanks for the excellent review. I think I have taken care of everything as discussed, although there was one point where I proposed leaving the documentation as is. So let me know if that's OK, and if everything else seems resolved.

I was not able to reproduce it this time around

Ah but you did. That must be the message that was causing the error before. So my trap is working, and revealing the issue. So yes, it seems as though the OEIS is detecting that we generate a lot of hits and protecting itself, and so if one just waits and tries again it works. That state of affairs seems OK to me; I think we can just go ahead with this scheme and if any difficulties seem to arise in what actually ends up in the database we can track them down when it happens. Sound OK?

Oh cool!  Ok, great!  Yes, the error message is plenty informative now.  One more question, though:  would it be good to trap this and prevent further requests for a period of time when this error arises (in this PR or as a separate issue for later)?

One more question, though: would it be good to trap this and prevent further requests for a period of time when this error arises (in this PR or as a separate issue for later)?

Yes, that is a very good idea. I think it is outside the scope of this PR, but absolutely we should file an issue for this. I don't offhand know how to implement something like that (I'm not really experienced with concurrent/multithreaded programming) but it's well worth looking into, particularly from the "don't upset the folks you eventually want to work with" point of view.

One more question, though: would it be good to trap this and prevent further requests for a period of time when this error arises (in this PR or as a separate issue for later)?

Yes, that is a very good idea. I think it is outside the scope of this PR, but absolutely we should file an issue for this. I don't offhand know how to implement something like that (I'm not really experienced with concurrent/multithreaded programming) but it's well worth looking into, particularly from the "don't upset the folks you eventually want to work with" point of view.

Ok, great, then let's file that issue (and the other one mentioned in this conversation).  The only other outstanding thing then for me on this is the missing  in the markup... let's face it, anyone taking an interest will read it via github, and that's very confusing.  Is there a workaround?

the missing COUNT in the markup

Did my fix not work? Can you send another screenshot? We should definitely fix this before merging -- the README needs to look right.

the missing COUNT in the markup

Did my fix not work? Can you send another screenshot? We should definitely fix this before merging -- the README needs to look right.

Oh it's fixed!  I needed to refresh something.


chore: add github workflow for buf linting & push

Something like that @maoueh?
Since you guys are using github releases anyways, why don't you use the release trigger for your workflows to tag docker images, gitpod images & this? That would imho be a better match.
There are currently a few linting errors in buf lint. Do we/you care about those? Do we want to fix them?

I'm not against release but I always feel that tags are more useful with similar flow. Main diff is that it enables doing ad-hoc tag, but I could agree it's limited (we could still do -rc, -beta release).
I leave you the final decision, I'm good with both. Tell me.

The rest is all good.

The rest is all good.

Let's stick to the current branch, pr & tags model. If we feel like there are signfiicant benefits to using release fully in the future across all your repos then we can do that for all of them in one go. I think it's better to just keep them all aligned for now. Less confusing.

What is the update on the fix of linting? We are using linting in a repository that is dependent on this one and it forces us to have linting on substreams disabled or maintain a fork of the code.
I can create a PR if there is enough demand. Would renaming of folder intern to internal as per the docs mean breaking changes for depending libs?
cc @maoueh @fubhy


visualise UCE embeddings of a new dataset in the existing large graph

Is it possible to visualise UCE embeddings of a new dataset in exactly the same existing IMA embedding graph ? as illustrated in the Fig. 2a of Zero-Shot Same Representation. Thanks.

We uploaded an anndata of that IMA sample (https://github.com/snap-stanford/UCE?tab=readme-ov-file#data)
For the exact same UMAP, there are parametric versions of UMAP that you could try to use, which could maybe create that kind of visualization, but I have had trouble installing and running them before.


[feat] Implement OP_RESERVED opcode

Implement the OP_RESERVED opcode using the opcodeReserved reference implementation from btcd
References
Guide on how to add an opcode in shinigami

hello @b-j-roberts i would love to work on this issue 🚀


Client: Marathon

Create a client that talks to Marahon.
Marathon REST API is described at https://mesosphere.github.io/marathon/docs/generated/api.html

Done


Docs: Tidy up docs-related make targets

[ ] I added CHANGELOG entry for this change.
[X] Change is not relevant to the end user.

Changes
Make targets to check and / or generate docs can be confusing since:

We have target called check-docs which however also generates and formats docs
We have docs target, which generates docs but this target is unused at the moment

The suggested way to improve this is:

Introduce a generate-docs target which takes care of generating docs
Change docs target to generate, format and check docs for white noise. Use this target as the authoritative target for CI.

Also fixes CHANGELOG formatting issue that is currently in main.
Verification
Ran the targets locally.

LGTM


after exiting a game and trying to randomize it crashes

what the title says. also closes before I can read the error

fixed with latest update


Enable linter for every module

Problem
9f931233016b1d699ea9ca37228dff1c0917440c
Solution
Make it green.

Error: ./nns_test.go:161:6: i declared and not used

NNS linter is still failing, but it's fixed in #3604.

Makefile should be updated as well then.

Not fixed yet, I need to read about proper configuration.

Let's see if re-run helps with CodeQL.


[Autocomplete] Dropdown list obstructs the label when displayed above

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Your Environment 🌎

Tech
Version

Material-UI
v4.9.2

React

Browser

TypeScript

etc.

Interesting, thanks for raising. I think that we could add a small margin/padding bottom to the popup. Do you want to work on it? :)

No problem, I’ll handle it this weekend.

Maybe?
diff --git a/packages/material-ui-lab/src/Autocomplete/Autocomplete.js b/packages/material-ui-lab/src/Autocomplete/Autocomplete.js
index b4ad82ef7..4112c7e6b 100644
--- a/packages/material-ui-lab/src/Autocomplete/Autocomplete.js
+++ b/packages/material-ui-lab/src/Autocomplete/Autocomplete.js
@@ -152,6 +152,7 @@ export const styles = theme => ({
   /* Styles applied to the popper element. */
   popper: {
     zIndex: theme.zIndex.modal,
+    marginBottom: 4,
   },
   /* Styles applied to the popper element if `disablePortal={true}`. */
   popperDisablePortal: {

@oliviertassinari
Thanks for your solution!
As outlined TextField and normal TextField's height is different, normal TextField needs at least 12px.
Should we consider adding a margin prop or just set a fixed margin?

Ah, ok, in this case, let's ignore the problem.


can "retract" contact request (bug?)

^ screenshot from after clicking the retract-button

not reall sure if the message should even be proposable... in anyway i think we should not allow it


Create a Chrome DevTools Extension for Horizon

Inspired by VueJS img1 img2
It would be very helpful to see:

a list of your working .watch() queries and what's flowing through them
see when they actually received information
the token currently being used
a list of all queries that have been run

I'm sure there's plenty more that would be useful.

Great idea!
Might be good for inspiration:
https://github.com/rrdelaney/horizon-devtools

Created a connector for Redux DevTools extension: horizon-remotedev.

To use it just specify the horizon instance to monitor like:
hzRemotedev(horizon("react_messages"))

To clarify, Redux DevTools extension can be used with any architecture which handles the state. We're just sending data to it, which also offers the ability to use it not only for the browser, but also for React Native, hybrid, desktop and server side apps.

Just an update: I added user support in my dev tools (https://github.com/rrdelaney/horizon-devtools)
Im going to start the work to make it more modular this weekend, so hopefully I can put it in the chrome devtools panel.


Add a favicon in the same style as other apps

In Integration with this branch deployed, the favicon looks like:

I thought we'd need loads of different sizes, but transition doesn't so this looks good. :+1:

I wish we'd had LOL :-(


Import/Export file to a Page (.docx, .txt...)

Hi there,
I need to import .docx file as a page. But Bookstack doesn't support.
I think everybody need this feature. Thank you!

Hi @wisoez,
Exporting to more formats is already open under #1273.
As far as importing goes, I'll likely not officially support other file formats such as docx due to their complexity and likelyhood to raise many more issues. Ideally, once we have expanded the BookStack API, people will create scripts to import from various formats.


Ignore veth in network I/O metrics on Linux. (Docker creats a lot)

network metrics on veth are not useful
Docker creates a lot of veth interfaces
Ignore "vethXXX" interfaces in network metrics

LGTM!


Malformed response

Right now, there's an error at http://wttr.in/berlin-kreuzberg?lang=de
2017/10/05 21:48:46 invalid character '<' looking for beginning of value
2017/10/05 21:48:46 Malformed response.

The english report works. If you use a + instead of a -, it works too.

There were probably some problems on the data sources side. Does it work for you now?

Yup works


Why is selectItem not public?

void selectItem(int position) {

Why is this not public?
File: NavigationDrawerFragment.java
Line: 147

For the same reason google uses it as a private method:
{sdk}\tools\templates\activities\NavigationDrawerActivity\root\src\app_package\NavigationDrawerFragment.java.ftl
Line 191:
private void selectItem(int position) {
    mCurrentSelectedPosition = position;
    if (mDrawerListView != null) {
        mDrawerListView.setItemChecked(position, true);
    }
    if (mDrawerLayout != null) {
        mDrawerLayout.closeDrawer(mFragmentContainerView);
    }
    if (mCallbacks != null) {
        mCallbacks.onNavigationDrawerItemSelected(position);
    }
}

However, just like any template, feel free to change it to public.


Capitalisation error on word "ToolTip" when we hover on Gates in Simulator

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When we hover on the gates  icon in simulator a toast (ToolTip) appears on the bottom right corner where the capitalisation error is
present somewhere it is "Tooltip" and somewhere "ToolTip"
Steps To Reproduce
1.Go to simulator.
2.Hover on gates.
3. See the toast (Tip) that appears on bottom right of the screen
Expected Behavior
It should say "ToolTip" in all the toasts.
Screenshots

Device Information [optional]
- OS:Ubuntu 20.04
- Browser:chrome
- version:22

Additional context
No response
Are you working on this issue?
Yes

@tanmoysrt  it is a small fix pls assign me it would be my first open-source contribution

can i work upon this issue ? @tanmoysrt

Hi @assetlover I didn't get the issue. Can you explain a bit, what is currently and what is expected ?

Hi @assetlover I didn't get the issue. Can you explain a bit, what is currently and what is expected ?

A small toast appears when we hover on gates in simulator somewhere it is written Tooltip (small t in tip word) and somewhere it is ToolTip(captial T in tip word) it's is a typo basically

Hi @assetlover I didn't get the issue. Can you explain a bit, what is currently and what is expected ?

A small toast appears when we hover on gates in simulator somewhere it is written Tooltip (small t in tip word) and somewhere it is ToolTip(captial T in tip word) it's is a typo basically

oh ok fine you can work on that.


chore: add baoyuan in committer list

Changes:
Add @Baoyuantop on the team page : )
Thanks.
By the way, the team.js file is formatted.

Congratulation！


Add Sanity colors, logo, and assets

There's one tiny issue with the SVG logo where a red value is hardcoded as a fill and does not render correctly when the mobile nav is open, but I don't think that should be a blocker.
This also adds missing dependencies to the the plugin's package.json

And while I agree that the logo thing isn't a blocker, I don't see why we can't get around that issue pretty easily.

@fk can you re-export the logo with the shapes expanded, using a single color and opacity for the mid color? (Can show you what I mean if that's unclear)

Let's use the existing "product logos"

for the nav, plis:


livestyle dies on fileWatch on windows

I hope 2259241 fixes this. Can someone confirm?

@walling: Turns out Adblock for Chrome likes to inject a data: url stylesheet, which wasn't being filtered, and that freaked out fs.watch on Windows.
If you're using Chrome with AdBlock that would explain your troubles. In that case, could you please try again with livestyle 0.0.12? It works for me in Windows 7 now.

I tested livestyle 0.0.14 in Chrome on Windows 7 with and without AdBlock Plus enabled. The first change in the CSS (after I start livestyle) is applied correctly, but after that it doesn't update the CSS anymore. There is no error traces / messages from the livestyle server and in the Chrome console.

When I refresh the web page, the next change in the CSS is applied as well and then it stops working. I don't need to restart the livestyle server.

@walling: We just added a debug mode (included in 0.0.14), could you try again with livestyle --debug and gist the output?

@walling: The debug mode also turns on logging a bunch of useful info in the client (goes to console.log). Would be very helpful if you included that in the gist, too :)

https://gist.github.com/1901214
The funny thing is that the client seems to get the event that the CSS file changed, but it is not updated in the browser.

Maybe it has something to do with the change event firing twice. Why is that? :-)

@walling: Thanks a lot, turned out I could reproduce it with node 0.6.x. I'm usually stuck on 0.4.12.

I tested livestyle 0.0.16 with node 0.6.8 on windows 7 and it works great! Actually I'm going to use it today on some website design I'm doing.


Is sqlcoder-7B-2 supported in ollama?

I only found sqlcoder-7B in the ollama models, unfortunately it is outdated.

Supported, I'm using it


Test stream coverage of fractional frame rates

Do we need test streams for fractional frame rates that cover all the content options?

If we have full coverage at 60Hz, would it be sufficient to have just enough to test CMAF switching sets at 29.97/59.94? e.g. For AVC, 1920x1080 and 1280x720 in each of 59.94 and 29.97?
Hence what tests would be worth running for the fractional frame rates?

September 15th meeting
Expect that implementations that support 60Hz will support fractional rates as well.
Conclusion
Start with limited support for fractional and expand later if there is a need.


Path Suggestions have duplicates and errors

Configuration Information

Windows 10 X64 Enterprise Edition

VScode version

1.33.0

Problem Description

Each suggestion item is repeated twice.
Irrelevant Suggestions will appea.

The problem record the screen

In .js & .ts files duplicates come from
"typescript.suggest.paths": true,
"javascript.suggest.paths": true,

Any chance to filter them out without setting false, because these settings also provide autocomplete for node_modules.

@ihodev
After changing the configuration, the problem persists

My problem is the same in HTML files, you should add an easy option to understand and configure in which you can disable the suggestions in different types of files, I tried to do it by the documentation that brings the extension but I could not.

@COD3BREAK3R have you tried the ignoredFilesPattern option ?
    "path-autocomplete.ignoredFilesPattern": "**/*.{css,scss,html}",

@ionutvmi

This setting does solve the problem of suggesting duplicates.

Would you like to say something different about your plugin and the plugin below?

I see that the functions of these two plugins are highly similar.
Do I need to use them at the same time?
PathIntellisense

Finally, ask if your plugin doesn't seem to work in the vue file.

@liby , path intellisense was the starting point for this extension.
Since they are doing the same thing (providing path competitions you should only use one at a time.
For the vue file issue can you please open a new issue with more details on how to reproduce ?

 "path-autocomplete.ignoredFilesPattern": "**/*.{css,scss,html}",

For now the recommended solution for handling duplicates would be to disable path autocomplete based on the extensions where vscode provides completions out of the box.

@COD3BREAK3R have you tried the ignoredFilesPattern option ?
    "path-autocomplete.ignoredFilesPattern": "**/*.{css,scss,html}",

I tried to do it, but it did not work, I did not understand very well how it was put. I read the Readme again and again but I could not, I'm going to try your configuration to see if it works, thanks.

@COD3BREAK3R , in that list you can add file types where you don't want path autocomplete to provide suggestions.
css,scss,html} means that it will not provide suggestions in css, scss and html files.
On what type of files are you working on ?

@COD3BREAK3R , in that list you can add file types where you don't want path autocomplete to provide suggestions.
css,scss,html} means that it will not provide suggestions in css, scss and html files.
If that doesn't work please open a new issue with more details.
Include the file type you are working on and the configuration that you tried.

I already tried the configuration and it worked, this should be implicit in the documentation and if you can add it already by default in an update it would be great.


Add "Temporary Storage" requirement to Service Fabric's "Virtual Machine Sizing" section

Service Fabric writes system diagnostics and logs to temporary storage. If MaxDiskQuotaInMB is not configured then it defaults to 64gigs. Therefore, the Virtual Machine Sizing section should talk about the importance of picking a VM size with enough temporary storage (64+ gigs) and/or provide a link to more information about MaxDiskQuotaInMB

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 658de695-0927-175f-0419-dcf7b6bece9d
Version Independent ID: 8166322c-774b-9434-3df5-5501b7dd9cf1
Content: Service Fabric cluster capacity planning considerations - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-cluster-capacity.md
Service: service-fabric
GitHub Login: @sukanyamsft
Microsoft Alias: pepogors

@sdolenc
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@sukanyamsft
Can you please check and add your comments on this doc update request as applicable.

Hi @sdolenc,
Sorry for the delayed response.  We have updated the document in the PR - https://github.com/MicrosoftDocs/azure-docs-pr/pull/202600
Thanks!
#please-close this issue


Add Lazy component

Current dependencies on/for this PR:

master

PR #44   👈

This comment was auto-generated by Graphite.


[BEAM-1112] Improve Python E2E Test Framework

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[ ] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

IT tests should not failed python setup.py test.

Skip IT(integration test) if --test-pipeline-options is not specified in command line arguments.

+R: @aaltay

@aaltay PTAL

LGTM (please wait for tests to finish).

@dhalperi please merge if looks good to you.

LGTM, merged, thanks.


for weather app

generate or add feature to it .. can you assign work to me ? or any issue ton fix it

can you assign this work to me?


Fixed #34405 -- Fixed setting Content-Type header in FileResponse for compress and brotli.

ticket-34405
Thanks Chamal De Silva for the report.

@chamalsl Does it work for you?

@chamalsl Does it work for you?

Yes. Now bug is fixed.

Thanks both for checking :+1:


Add namespace option to search attributes operations

What changed?
Added namespace option to search attributes operations.
Added custom_search_attribute_alias map to namespace config to be able to set alias in the namespace.

Why?
Advanced visibility with SQL: search attributes will have to be set by namespace.

Breaking changes
No.

For elasticsearch, it will work as it is currently.
We're not pre-allocating custom search attributes, nor exposing the concept of alias, so no point in having search attributes per namespace. Basically, passing namespace option when calling those commands will no-op when using elasticsearch.

As discussed during standup, we will eventually make ElasticSearch backed search attributes namespace specific to match the experience for SQL based visibility but that will not be a part of the 1.20 server release.


Changes for deployment of VPN2 after rewrite to Go.

How to categorize this PR?

/area control-plane
/kind enhancement
What this PR does / why we need it:
The rewrite of the bash scripts to Go in vpn2 brings some changes in the deployment of the vpn-seed-server and vpn-shoot-client deployments.
These adjustments must be applied together with the new release of VPN2 containing

[x] the rewrite to Go (PR https://github.com/gardener/vpn2/pull/84)
[x] support of IPv6 transfer network (PR https://github.com/gardener/vpn2/pull/99)
[x] release 0.27.0 of the VPN2 component

The feature gate NewVPN is introduced for the gardenlet component to enable the new implementation.
Co-authored-by: @dergeberl
Co-authored-by: @hown3d
Co-authored-by: @mreiger
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

The feature gate `NewVPN` is introduced for the `gardenlet` component. If enabled, the new VPN implementation (Golang rewrite) is used for all `Shoot`s of the respective `Seed`. In this case, the old implementation can be disabled for a single `Shoot` by annotating the shoot resource with `alpha.control-plane.shoot.gardener.cloud/disable-new-vpn=true`. For `Seed`s with disabled feature gate, the new implementation can be enabled for a single shoot by annotating it with `alpha.control-plane.shoot.gardener.cloud/disable-new-vpn=false`.

/remove-lifecycle stale

/retest

/assign

/test pull-gardener-integration

/test pull-gardener-e2e-kind-migration-ha-single-zone

/test pull-gardener-integration


AnimatablePresentationController

AnimatablePresentationController can support the user in prototyping and designing Modal View ( UIPresentationController) in Interface Build.
It may have the following properties.

[x] cornerRadius, shadowColor, shadowRadius, shadowOpacity, etc. for the Modal View, most of properties are supported by AnimatableView
[x] dimmingViewBackgroundColor, dimmingViewOpacity, dimmingViewBlurEffect, etc for background dimming view
[x] animationType, e.g. Pop(direction) and all supported transition animators
[x] dismissGestureType, e.g. Swipe, Tap
[x] Custom size / position
[x] observeKeyboard, up the modal when keyboard is opening
[ ] useDynamics, use UIKit Dynamics when panning the view
[ ] OverCurrentContext  / fullscreen

Just some initial idea, feedback is welcome. Don't know which Milestone will work on it, so put "help wanted" 😉
Relative to #172, #281 and #20

There's definitely some ideas to take from MZFormSheetPresentationController.
For the milestone, why not add it to the 2.4, or 4.0 if we don't have a 2.4?

@tbaranes I tag it to 4.0, but can be done earlier if needed.

@JakeLin I might take this on - in some part - during the upcoming week, depending on time. Would be a really cool feature to have.

Thanks guys, should we swap 4.0 with 3.0? I don't have many ideas on the goal of Sketch plugin. If yes, we can just change the number in the milestone.

I think so, we can still move on the plugins once we determine a clear roadmap for them.

@tbaranes I have swapped 3.0 and 4.0. Let's don't worry about Sketch plugin first.

I'd like to add more examples to cover all the features supported by our presentation controller. Which one should be the best:

A list containing different ready use cases (like the current transition examples): animations, custom dimming view, ... we can easily create at least 20 examples using a list
Creating a list of textfield for each customisation available, and creating the popup based on the values entered by the user

Any preferences?

I like the examples what @lastMove did for other features, how about we have a list of fields to let the user select

animationType (picker view)
modalPosition (picker view)
modalSize (picker view)
cornerRadius (slider)
dismissOnTap (toggle)
backgroundColor (don't know how to present this, color picker or hex code)
opacity (slider)
blurEffectStyle  (picker view)
blurOpacity  (slider)
shadowColor (the UI is same as backgroundColor)
shadowOpacity (slider)
shadowRadius (slider)
shadowOffset (two silders?)

Just an idea, feel free to make any feedback 😊

@tbaranes shall we close this issue now since we have a powerful AnimatablePresentationController. We can create another card if we need to work on other features. Some of the features are original thoughts.

There just one more featureI that I think is important enough: OverCurrentContext / fullscreen implemented, otherwise, can close it if you want :)

@tbaranes thanks, either we close this one can create a new one for OverCurrentContext / fullscreen or leave this one.
I think we can leave this one for now.

PresentationModalSize - custom size is not working.. kindly have a look

@abdulKarim002 Can you open a new issue about this including as much details as you have?

Yes sure...


Allow specify number of options with respect to selected direction

In geography open question is allowed only in one direction, this is currently not possible with proso_flashcards.

to remove open questions for flashacards with direction "from description to term" add following  to you config file:
option_selector:
    class: proso.models.option_selection.ConfusingOptionSelection
        parameters:
            max_options: 6
            allow_zero_options_restriction: True


NotImplementedError: Unsupported Ops of type: Unpack,Select

I am trying to convert the squeezeDet model as per the repository Here.
While converting a file from the .pb to .mlmodel I am getting the errors as below.
The command is as follow:
tf_converter.convert(tf_model_path = tf_model,                      mlmodel_path = out_mlmodel,                      output_feature_names = ['bbox/trimming/bbox','probability/score','probability/class_idx'],                      input_name_shape_dict = {'batch' : [1, 640, 480, 3]})
Traceback (most recent call last):
  File "converter.py", line 11, in <module>
    output_feature_names = ['bbox/trimming/bbox','probability/score','probability/class_idx'])
  File "/home/ubuntu/target_TFInstall/tf-coreml/tfcoreml/_tf_coreml_converter.py", line 483, in convert
    predicted_probabilities_output=predicted_probabilities_output)
  File "/home/ubuntu/target_TFInstall/tf-coreml/tfcoreml/_tf_coreml_converter.py", line 149, in _convert_pb_to_mlmodel
    _check_unsupported_ops(OPS, output_feature_names)
  File "/home/ubuntu/target_TFInstall/tf-coreml/tfcoreml/_tf_coreml_converter.py", line 117, in _check_unsupported_ops
    ','.join(unsupported_op_types)))
NotImplementedError: Unsupported Ops of type: `Unpack,Select`

both with the output as above and the input as below, I get the error of unsupported op type.
Is there something in the model operations that is not setup correctly ?
Traceback (most recent call last):
  File "converter.py", line 12, in <module>
    input_name_shape_dict = {'batch' : [1, 640, 480, 3]})
  File "/home/ubuntu/target_TFInstall/tf-coreml/tfcoreml/_tf_coreml_converter.py", line 483, in convert
    predicted_probabilities_output=predicted_probabilities_output)
  File "/home/ubuntu/target_TFInstall/tf-coreml/tfcoreml/_tf_coreml_converter.py", line 149, in _convert_pb_to_mlmodel
    _check_unsupported_ops(OPS, output_feature_names)
  File "/home/ubuntu/target_TFInstall/tf-coreml/tfcoreml/_tf_coreml_converter.py", line 117, in _check_unsupported_ops
    ','.join(unsupported_op_types)))
NotImplementedError: Unsupported Ops of type: Unpack,Select

Yes, unfortunately these ops are currently not supported by CoreML.
I think these ops are being used in the pre or post processing steps, so you should be able to remove them from the graph (e.g.: ssd_example and convert rest of the network.
Maybe discussion here could also be helpful: issue #107

You can use custom layers for unsupported ops: PR #179

This issue should be resolved with the latest coremltools. Close due to inactivity. Feel free to re-open if you still see the issue. Thanks!

any update about this issue

These ops are supported, please use the minimum_deployment_target as '13' as indicated here : https://github.com/apple/coremltools/blob/master/examples/NeuralNetworkGuide.md#tensorflow-conversion

@aseemw I'm use minimum_ios_deployment_target as '13'  but get error
ValueError: Shape of required input ImageTensor is not provided. I think this error related to ops
my script
tf_converter.convert(tf_model_path = tf_model_path,
mlmodel_path = 'myfrozen_model.mlmodel',
output_feature_names = ['SemanticPredictions0'],
input_name_shape_dict = {'ImageTensor0' : [1, 227, 227, 3]},
minimum_ios_deployment_target='13',)


[MINOR][BUILD] Remove invalid infor in run-tests.py

What changes were proposed in this pull request?
========================================================================
Building Spark
========================================================================
[info] Building Spark (w/Hive 1.2.1) using SBT with these arguments:  -Phadoop-3.2 -Pkubernetes -Phive-thriftserver -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos test:package streaming-kinesis-asl-assembly/assembly

(w/Hive 1.2.1) is incorrect when testing hadoop-3.2, It's should be (w/Hive 2.3.4).
This pr removes (w/Hive 1.2.1) in run-tests.py.
How was this patch tested?
N/A

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10183/
Test PASSed.

Test build #104874 has started for PR 24451 at commit 9c353cc.

Test build #104874 has finished for PR 24451 at commit 9c353cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104874/
Test PASSed.


Info panel stories need Avatar

@keybase/react-hackers , although I'll probably just merge once CI passes


Trademarks.  How to convert <347> to a symbol ?

Customer has  <347> for the trade mark symbol.  How can this be converted to show up on the spreadsheet correctly?
Thanks,
Greg Sharpe

Hi Greg,
try to generate the xlsx manually and check with package explorer the
corresponding translation
Check this document
http://officeopenxml.com/WPtextSpecialContent-symbol.php
Ivan
On Tue, Apr 12, 2016 at 8:33 AM, gsharpe2000<EMAIL_ADDRESS>wrote:

Customer has <347> for the trade mark symbol. How can this be converted to
show up on the spreadsheet correctly?
Thanks,
Greg Sharpe
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ivanfemia/abap2xlsx/issues/432

I've just inserted the ® symbol in my unicode ABAP system and had no issues. Can you perhaps exchange <347> to ® before handing it over to abap2xlsx?

Hi Gregor,
How did you insert that symbol in your ELSX?  If you don’t mind sharing. :)
With warmest regards,
Greg Sharpe
GFI Consulting Limited
Skype: gsharpe2000
Mobile:<PHONE_NUMBER>
Fax       :<PHONE_NUMBER>
http://lnkd.in/bCT-dm
From: Gregor Wolf<EMAIL_ADDRESS>Sent: Tuesday, April 12, 2016 11:04 AM
To: ivanfemia/abap2xlsx<EMAIL_ADDRESS>Cc: gsharpe2000<EMAIL_ADDRESS>Subject: Re: [ivanfemia/abap2xlsx] Trademarks. How to convert <347> to a symbol ? (#432)
I've just inserted the ® symbol in my unicode ABAP system and had no issues. Can you perhaps exchange <347> to ® before handing it over to abap2xlsx?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/ivanfemia/abap2xlsx/issues/432#issuecomment-208950934 https://github.com/notifications/beacon/ANZ0We7DrmHTIhZKNNLwfOqeVCvcX8EAks5p27RfgaJpZM4IFZCJ.gif

Would be great if symbols logic was in a ZDEMOnnn

I simply added it to the string literal.

Oh thank you
I thought you concerted it somehow
Cheers,
Greg Sharpe
(902) 322-4102
Sent from my iPhone

On Apr 12, 2016, at 1:10 PM, Gregor Wolf<EMAIL_ADDRESS>wrote:
I simply added it to the string literal.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Let's close the question, it's answered. Most of symbols are Unicode characters so there should be no problem to get them into Excel.
Demo:
REPORT.
CONSTANTS gc_save_file_name TYPE string VALUE 'issue_432.xlsx'.
INCLUDE zdemo_excel_outputopt_incl.
START-OF-SELECTION.
  DATA(lo_excel) = NEW zcl_excel( ).
  DATA(lo_worksheet) = lo_excel->get_active_worksheet( ).
  lo_worksheet->set_cell( ip_column = 'A' ip_row = 1 ip_value = '®' ). " trademark symbol
  lcl_output=>output( lo_excel ).

Result:


Fb reset index

This change is

Current coverage is 58.20% (diff: 45.61%)

Merging #532 into master will decrease coverage by <.01%

@@             master       #532   diff @@
==========================================
  Files          1929       1930     +1
  Lines         99277      99287    +10
  Methods           0          0
  Messages          0          0
  Branches      12351      12351
==========================================
+ Hits          57785      57787     +2
- Misses        38421      38429     +8
  Partials       3071       3071

Powered by Codecov. Last update 111dca9...97b3de9


Rights value of 'All rights reserved' uses Europeana RR-R URI that is no longer supported

Descriptive summary
Europeana no longer supports the Rights Reserved - Restricted Access statement used in Hyrax as 'All rights reserved." http://www.europeana.eu/portal/rights/rr-r.html  (gives 'Forbidden' error)
https://github.com/projecthydra-labs/hyrax/blob/master/lib/generators/hyrax/templates/config/authorities/licenses.yml
Looks like they actually dropped support in 2014 (last paragraph here: http://pro.europeana.eu/blogpost/europeana-digital-objects-to-have-valid-rights-statement-by-july )
(Oregon Digital recently switched to an equivalent form at opaquenamespace.org: http://opaquenamespace.org/ns/rights/rr-r  as a temporary solution, until we can fully evaluate how rightsstatements.org figures in. The main factor for this was having a URI with a label that was fetchable. I'm not advocating Hyrax or anyone else use this.)
A likely replacement is In Copyright: http://rightsstatements.org/vocab/InC/1.0/

@wickr What changes do you think Hyrax should make?
Cc @anarchivist

Gotta love those stable URIs

I'll doublecheck, but I think InC is a good replacement. The previous text was as follows:

Rights Reserved - Restricted Access
This item is protected by copyright and/or related rights. This item is only accessible through registration or some other form of controlled access and subject to the licensing conditions set by the organization giving access to it.
Unless expressly stated otherwise in the licensing conditions, you are free to make any of the acts permitted by your national copyright and related rights act, including browsing, printing and making a copy for your own personal purposes.
All other acts of reproduction and communication to the public are subject to the licensing conditions attached to the work.

I'll also note that "Rights Reserved - Paid Access" (http://europeana.eu/rights/rr-p.html) was also removed (ref):

The existing Rights Reserved - Paid Access can no longer be supported by Europeana. Europeana will get into contact with all data partners who currently make use of the Rights Reserved - Paid Access statement to discuss the how to manage the transition from the old rights statement to a new one.

@jcoyne I think Hyrax should change to In Copyright unless there's a better suggestion. That's what Europeana switched to as well.
In Copyright isn't a license like Creative Commons, but it does give the status of the work.

More thoughts on the above, @projecthydra-labs/hyrax-code-reviewers?

unless there are objections or other comments, i think we should follow @wickr's comment above and follow what Europeana did with their switch for consistency.

I agree with @wickr and @vantuyls - In Copyright from rightsstatement.org seems like the best option.

We suggest marking the Europeana RR-P license in Hyrax as inactive. This will prevent users from selecting this license going forward, but will not invalidate current data or cause a data migration. Users can now use the Rights Statement field to more clearly assert users' rights to a work.

Closed by #1517


Stuck in package picker submenu

Windows 11, Powershell.
Can only select or deselect the first option with space, but nothing more with arrow keys or Enter

ignite create --name=dino_game --org=org.system32uwu.games --create-folder=true --flame-version=1.8.0 --extra-packages="flame_audio" this also fails with this message:
Unhandled exception:
type 'String' is not a subtype of type 'List<String>?' in type cast
#0      getMultiOption (package:ignite_cli/utils.dart:86:29)
#1      createCommand (package:ignite_cli/commands/create_command.dart:54:25)
#2      mainCommand (package:ignite_cli/main.dart:73:11)
<asynchronous suspension>

Same problem is observed when using cmd and git-bash as well

same here


HBASE-27353 - opentelemetry-context jar missing at runtime causes MR jobs to fail

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.


remux to webm or mkv

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[x] Question
[ ] Other

Description of your issue, suggested solution and other information
Is it possible to convert the output file to webm if possible (vp9/vp8+opus/vorbis) or else to mkv? Not working "alternatives":

-f "webm/mkv" is just a filter for the input streams and
--merge-output-format allows only one option.

This is the default behavior, it outputs original container if possible or uses mkv otherwise.

it outputs original container
Yes, that's why im asking for this feature.

You can try setting the output container to mkv or manually copying to mkv with ffmpeg.

manually copying to mkv with ffmpeg.

that's what im doing right now (using mkvtoolnix gui to convert it to mkv). that's kind of a workaround, but it's working. i just wondered if there is a more convenient way to do that.

@chpio could you paste an example video for what's your expectation and the actual results?


Bug fixes and cleanups around exit_validator

Cleanups

Use state.slot over current_slot.
Specify new_status
Segregate ejection processing

Bug fixes:

Put ejections at the end of the per-slot processing (TODO: per-slot processing should come after per-epoch processing)
Immediately exit ejections
Include ACTIVE_PENDING_EXIT as an active state
Renamed two State to BeaconState

I've resolved conflicts with master.

@djrtwo We also need to:

Replace the code under # Exit validator with a call to exit_validator
Only remove validator from persistent committees and update validator_registry_delta_chain_tip if there's an actual exit event (i.e. EXITED_WITH_PENALTY or EXITED_WITHOUT_PENALTY).
Abstract away all the grunt work around status changes (e.g. regarding validator_registry_delta_chain_tip, status, latest_status_change_slot) into an update_validator_status function.

Feel free to merge this one first to avoid a huge PR.


Sync APIs. @tag-name=gloo-fed-v1.9.0-beta1

How will this tag be imported into solo-projects? Will this be used instead of the existing<EMAIL_ADDRESS>tag?

How will this tag be imported into solo-projects? Will this be used instead of the existing<EMAIL_ADDRESS>tag?

Yes - it will work the same as rate-limiter, in that this 'updates' the gloo-fed apis. Currently, the master branch of solo-apis is at gloo-v1.8.6 and (the latest rate-limiter) rate-limiter-v0.1.2 and gloo-fed (8 months old unreleased version). Once this goes in, it'll be at: gloo-v1.8.6 and (the latest rate-limiter) rate-limiter-v0.1.2 and gloo-fed v1.9.0-beta1.


A little cleanup work to get the package usable as an esm

removed npm from dependencies. The package manager itself shouldn't be listed in dependencies (or devdependencies).
removed the dist folder from .gitignore then built and added the dist files as this is literally the usable package from the consumers' point of view.

@amsik

Hi! Thanks for your request.
Could you please explain about dist folder? We have 2 ways to include the library:

via npm (npm i liquor-tree)
using CDN

In other cases user cloning the repo and uses at his own discretion. He could install all modules and build a library using npm scripts or its own builder. For instance to use with babel:

// installed via npm (npm i liquor-tree)
import LiquorTree from 'liquor-tree'

// clone a library and use its source code
// in this way developer is able to make some changes to a library and so on :)
import LiquorTree from '../SUPER-COMPONENTS/liquor-tree/src/main'

Maybe I'm wrong. Please give me more details for this case. Thanks!

In package.json, you list dist files for the values of "module" and "main" yet those files aren't a part of the package. If they simply
import LiquorTree from 'liquor-tree'

they will get a file/module not found error since "module" points to a file in a folder that doesn't exist.


Move Amazon.Corretto.11 <IP_ADDRESS>.1 to Amazon.Corretto.11.JDK <IP_ADDRESS>.1

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,
This manifest removes Apps and Features entries that are present in previous PR versions. These entries should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.
(Automated response - build 886.)


docs: add conclusion

Motivation

Modifications

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

@zhyncs - QQ, how is ITL measured and how is it measured as compared to TPOT?
I thought these were the same concept: https://docs.nvidia.com/nim/benchmarking/llm/latest/metrics.html#inter-token-latency-itl

Hi @robertgshaw2-neuralmagic
For example, Engine A returns 1 token per second, for a total of 50 tokens. Engine B returns 10 tokens at once every 10 seconds, for a total of 50 tokens. At this point, the TPOT for A is 1 second, and the ITL is also 1 second. On the other hand, the TPOT for B is also 1 second, but the ITL is 10 seconds. Here, the definition of ITL is "the average latency between streaming chunks," not "the average latency between two tokens," to account for the effect of multi-token streaming. It is somewhat counterintuitive, which is why you are confused. We used this naming because it is adapted from the original vLLM benchmark scripts. I agree a better name should be "Inter-Chunk-Latency". This will introduce choppiness during online serving, leading to degraded user experiences. cc @ywang96

Hi @robertgshaw2-neuralmagic
Under the honest and clear communication of the SGLang Team and vLLM Team, we have reached an agreement. Thank you very much! And we have summarized the following lessons learned.
Common Mistakes in Benchmarking LLM Inference Engines

incomplete reporting of optimization trade-offs
misleading plots from inappropriate scaling of the figure's y-axis
biased hyperparameter tuning

Hope that in the future, both SGLang Team and vLLM Team can continue to improve in terms of functionality, performance, usability, and scalability. Cheers!
ref
https://x.com/lmsys_oss/status/1832133545655202288
https://docs.google.com/document/d/1fEaaIQoRQLbevRu3pj1_ReOklHkoeE7ELqZJ3pnW-K4
https://github.com/vllm-project/vllm-project.github.io/commit/2103980f8eed92e383e7ee838aa7e83983863072

@zhyncs thanks! I agree the choppiness is not good. We will resolve this in v0.6.1. Thanks for calling it out, as it helps us to improve.

Hi @robertgshaw2-neuralmagic For example, Engine A returns 1 token per second, for a total of 50 tokens. Engine B returns 10 tokens at once every 10 seconds, for a total of 50 tokens. At this point, the TPOT for A is 1 second, and the ITL is also 1 second. On the other hand, the TPOT for B is also 1 second, but the ITL is 10 seconds. Here, the definition of ITL is "the average latency between streaming chunks," not "the average latency between two tokens," to account for the effect of multi-token streaming. It is somewhat counterintuitive, which is why you are confused. We used this naming because it is adapted from the original vLLM benchmark scripts. I agree a better name should be "Inter-Chunk-Latency". This will introduce choppiness during online serving, leading to degraded user experiences. cc @ywang96

Just be curious, even if Engine B returns tokens in a bigger granularity, such differences will be eliminated if the frontend ui decide to simulate same user experiences as Engine A, i.e. the frontend will render one token per second even if it gets 10 tokens at hands.
The differences will be time to the first decoding chunk will be different. Engine A is better for the first chunk.
In a conclusion, I did not see significant differences between ITL(TBT) and TPOT if we do the frontend simulation tricks.
Is there any other reasons why we care so much about the TBT stability?

@icavanyu Nope. Simulation trick not work for this situation.

@icavanyu Nope. Simulation trick not work for this situation.

Thanks for your response. Could you help explain more about the differences on end-users' perspective?


[subset]

Clean up --unicodes etc option parsing.  In particular, currently entering font file after --unicodes etc doesn't work.  Use option parser of some sort.

.


Use PowerApps Portal Web API authentication settings

Hello,
I'm reaching you as I would like more information regarding how to authenticate on the PowerApps Portal Web API, the official documentation only mention that the presence of CSRF token is required (https://docs.microsoft.com/en-us/power-apps/maker/portals/web-api-overview#authenticating-portals-web-api-requests) but this is not true.
It seems the web api requires some cookies to be present in the request as well, could we have more information on that ?
The main purpose is to be able to call the web api of Portal 1 from Portal 2.
Thank you,

@nickdoelman and @neerajnandwana-msft any news on this ?

Thank you for your feedback but using the Portal Web API to communicate from one portal to another is not supported. You can log this as an idea on https://aka.ms/mpp_ideas


How can I add custom controller and templates?

Laravel Version: 5.4
Voyager Version: 1.0.9
PHP Version: 7.0
Database Driver & Version: MySQL 5.7

Description:
How can I add custom controller and templates? I installed Voyager to existing project. I tried to use documentation, but I have an error like “class MyController does not exist”.
Steps To Reproduce:

What did you try?

I used this one https://voyager.readme.io/docs/using-custom-http-controllers
But I have no changes

Try this.  Change the controller to non-sense characters.  If it doesn't break, php doesn't know about your new class yet. Runcomposer du.
Once you get it to break with non-sense characters, change it to your new controller and try again.  If it still breaks with the same error, then run the composer command again.  If it starts working, great.  If it's a different error, then you'll have to start debugging that instead, but it won't be a Voyager problem at that point.

Thanks a lot for answer. I reinstall package and it works fine. It seems an error occurred during installation


cmd/govim: autoindent and curly brace issues

I'm not certain if this is a Vim or Govim issue - I'm new to both, so apologies if this shouldn't be an issue created here.
What version of Vim/Gvim are you using?
$ vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Jul 27 2019 00:46:03)
What version of Go are you using (go version)?
go version go1.12 darwin/amd64
What operating system and processor architecture are you using (go env)?
GOHOSTARCH="amd64"
GOHOSTOS="darwin"

What did you do?
When creating, say, a for loop, I'd like for vim/govim to behave similarly to an IDE. Currently, I have the following situation( "|" represents cursor)
// Some other code, the following is nested..
            for _, something := range slice {
|

1.) The corresponding } curly brace isn't automatically created.
2.) When pressing enter for newline, the cursor will be kicked all the way back on the next line - rather than indenting properly compared to the nesting level
What did you expect to see?
// Some other code, the following is nested..
            for _, something := range slice { | // I press enter here

Then, upon pressing enter
// Some other code, the following is nested..
            for _, something := range slice {
                 | // Curly brace is set automatically at correct nesting level and cursor is bumped in by a tab
            }

Again apologies if this is "just" a vim setting I'm not aware of. Obviously I'd like to be pointed towards the correct approach to solve it either way :-)
Edit: Oddly, upon creating a new function, this works completely as intended. But I do not find it as working inside functions, f.e. nested for loops and so on.

Thanks for raising this @ChristianLindLarsen - your question I think points to the fact we need to do more work for newcomers to Vim, newcomers to govim etc.
Regarding auto-indent: this is a Vim feature; I've just raised https://github.com/myitcv/govim/pull/432 to suggest settings that should be part of a user's out-of-the-box .vimrc
Regarding auto-brace insertion: this is not currently a core part of Vim, nor is it something we do in govim. I use https://github.com/jiangmiao/auto-pairs. In the future we might look at distributing this with govim for a good out-of-the-box default experience.

Also just added https://github.com/myitcv/govim/wiki/vimrc-tips#-tip-auto-insert-closing-parentheses-braces-quotes-etc


Fetch & Decode

Description
Fetch & Decode is to:

Get instruction from memory
Parse the opcode to instructions
Prepare data that prepared for execution
Move the program counter.

As we discussed, Fetch & Decode can be independent function, or merged together.
Memory and Program Counter should be passed by parameters of reference.
Definition can be stored in an independent header file.
Product
One or more functions, within Fetch, Decode namespace

Decoding  Instructions

Decode structure finished!


no sound but consider

when the game is finished, or maybe as support at all times
@pburke8 @qqmav

+1


Prebuilt package for Linux CPU

Thank you for your great work. I see that there is already a prebuilt package available for windows. Can it be available for Linux CPU version? I know that GPU version for building packages might be very difficult. But it would be good to have linux version for CPU implementation.
Thanks in advance.

Building glomap should be relatively straightforward on the popular Linux distributions. I appreciate the request but I don't think we have the cycles to provide pre-built Linux packages. We may address this request throgh a future pyglomap package that will run on most Linux machines.

@ahojnnes Thanks for reply and yes it is a great idea to have pyglomap package.

!pip install -q condacolab
import condacolab
condacolab.install()

!mamba install -y glomap

!glomap -h
GLOMAP -- Global Structure-from-Motion

Usage:
  glomap mapper --database_path DATABASE --output_path MODEL
  glomap mapper_resume --input_path MODEL_INPUT --output_path MODEL_OUTPUT
Available commands:
  help
  mapper
  mapper_resume


How is Hosted Cloud Data Secured?

Hi! First of all, let me say that as a long-time-fan of Dexie, Dexie Cloud seems like a dream come true. I’ve long been searching for a simple way to add syncing capabilities to an offline-first PWA without having to manage all that data and auth by myself.
I am wondering, however, how that data that will be stored on the hosted form of Dexie Cloud will be secured. Will it be encrypted so only users with access to it can read it? Will it be stored redundantly?
Thank you for your time and incredible efforts!

Thank you Amadeus for your nice words!
Dexie Cloud is backed by Postgres with encryption at rest, meaning that the data is stored encrypted on hard disks. I'm currently using Microsoft Azure's RDS service for Postgres which also includes continuous backups that makes sure data is stored redundantly in the case of hardware failure.
On top of the infrastructure, Dexie Cloud adds access control that protects users from accessing each other's data. This can be overridden dynamically per database object. The default is that every user works against their own data and everything they sync is private. To make objects shared between users, realms can be created and members can be invited to those realms. Any object can then be 'moved' into a realm by specifying the realmId property to the id of a realm in order to get them shared with the members of the realm. Most of the access control model can be read about here.
Access control is one thing that separates Dexie Cloud from alternative sync solutions where privacy needs to be implemented using one-database-per-user concepts. Some objects can be private while others can be shared in the same model and the same app. Much like it is in real world apps like Slack, Wunderlist, Jira etc.
There's an example todo-list app written in React that use Dexie Cloud to sync todo-lists. It uses a relational model with todoItems and todoLists tables and I'm currently extending that app so that users can create lists and share them with their friends.
I see you are on the waitlist for Dexie Cloud! When milestone 3 is out and todo-list sample has been updated, I plan to release more users into it from the wait list.

Thank you for your quick and detailed reply David!
I’m looking forward to being able to try it out for myself when it’ll be my turn.


Type for consume token sometimes optional even though not

Very much an edge case, but just noticed that the generated types are slightly off: If a token is consumed in any path of an option, it's not optional - it will always exist. In the produced type file, however, the field will be listed as optional type (i.e. may be undefined) which leads to extra type checking vs. typescript errors :-)
ex.:

export interface AmountCstNode extends CstNode {
  name: "amount";
  children: AmountCstChildren;
}

export type AmountCstChildren = {
  DASH?: IToken[];
  CommodityText?: (IToken)[];
  Number?: (IToken)[];
};

Hello @jonestristand
What do you expect the generated type definitions to be in this case?

I would expect it to be:
export type AmountCstChildren = {
  DASH?: IToken[];
  CommodityText?: IToken[];
  Number: IToken[];
};

Though the logic for sorting this out would be more complicated, but I think that it should be possible by walking all possible routes in the graph, and listing consumed tokens. The problem would be that for large rules the time-complexity to that approach scales poorly...

I'm not sure if this analysis complexity would be more than linear.
But I am also not sure how important this is and/or worth the effort to fix and maintain, because normally once the optional parts get too complex, you would split them up into separate grammar rules, e.g:

https://github.com/Chevrotain/chevrotain/blob/master/examples/grammars/ecma5/ecma5_parser.js#L359-L387

So this issue would "disappear" if you utilize that pattern.

Yeah fair enough, I agree it's very much a non-essential edge-case, just bothered me because it wasn't correct :-D
I think in the case of my example the rule is small enough and logically 'the same' enough, that it makes sense to write as is, or do you think it would be better written (more 'canonical') as two separate rules even for this kind of case?

Your rule is small enough and you likely extract the same data from either alternative
so it is fine to keep it all in one rule.
On a related note, in the case of error recovery, everything could be optional.
Perhaps the dts generation API should expose an option to make everything optional

https://chevrotain.io/documentation/10_3_0/types/GenerateDtsOptions.html

I'll close this as its a minor edge case which may be still be valid for error recovery scenarios.


"Bad Cast" error on list_keys

list_keys throws an exception.
curl http://localhost:8888/v1/wallet/list_keys
{"code":500,"message":"Internal Service Error","error":{"code":7,"name":"bad_cast_exception","what":"Bad Cast","details":[{"message":"Invalid cast from object_type to Array","file":"variant.cpp","line_number":535,"method":"get_array"}]}}
used version: v1.0.2

list_keys now requires an argument, which is your wallet password.
curl --request POST --url http://localhost:8900/v1/wallet/list_keys --data '["default","PWxxxxxxxxxxxxx"]


Mention Redis inspection in yserguide/monitoring

Heh, forgot to push this before. It's already in master.

Thanks, but you don't have to create pull requests for the 2.4 branch, I will backport patches to 2.4 when appropriate later.


Fixed Font awesome 5 dependencies for the new font-awesome-picker

My last pull request was only for the font-awesome picker
Your font-awesome is still the old one and caused a lot of font missing
I updated the menu.blade.php without the prefix of fa every time adding item['icon'] because it breaks in FA 5, with the fontawesome picker it includes all of the prefix of the new FA 5 (fas, fab, etc).
I also updated each default font with the correct classes
Checked and test, love your work btw
Thanks!

fixed another bug


Subclassing issues

When subclassing the web browser view controller in Swift, the library seems to not access the resources anymore, making back / forward bar button images disappear.

After a quick digging in the code, I can see that in line 408 in KINWebBrowserViewController.m you implicitly get the class of the bundle using self, which won't work when subclassing. Explicitly specify the class name solves the issue:
NSBundle *bundle = [NSBundle bundleForClass:[KINWebBrowserViewController class]];
instead of:
NSBundle *bundle = [NSBundle bundleForClass:[self class]];
I can make a PR for you if you're okay.

Duplicate of #57


Fix TOC order for concepts and tasks landing pages

Fixes #8237
This might have significant overlap with other in-flight PRs and issues. :(

/assign @steveperry-53
/assign @Bradamant3
(because I think we are all working on the same stuff)

@mistyhacks This does overlap with my work on the Tasks section. See Issue #8398.

@mistyhacks I think you should hold off on this, because it's going to conflict with other work that's in flight. Sorry for the confusion.
@steveperry-53 is working on getting the Tasks left nav in order.
@Bradamant3 is working on getting the Reference left nav in order.
@cnegus is working on getting the Concepts left nav in order.


Elixir 1.15 and OTP 26 ssl connect error

I'm getting this error (ssl is default value of false) with Elixir 1.15 and OTP 26.
11:23:24.532 [error] Mongo.MongoDBConnection (#PID<0.980.0>) failed to connect: ** (Mongo.Error) ac-0knwhng-lb.kellgcp.mongodb.net:27017 ssl connect: Options (or their values) can not be combined: [{verify,verify_peer},
                                                {cacerts,undefined}] - {:options, :incompatible, [verify: :verify_peer, cacerts: :undefined]}

Anyone else seeing this problem?

The issue is fixed by the way if I supply: ssl_opts: [verify: :verify_none], maybe we should pass this as default when ssl is false?

I guess the default values regarding ssl have been changed since OTP 26. As far as I now the certs are not verified by default and it is up to the developer to configure it.
See for more information here:
https://youtu.be/0jzcPnsE4nQ

Thanks for the link to the talk, always wanted to find out more about this :)
However, I still think we should add the suggested defaults because as a user of the library, I don't expect ssl errors when I see that the default is ssl: false. Before it was not necessary to have ssl_opts: [verify: :verify_none] but now we should right?

I assume you use ssl: true. The  ssl_opts options are only used if you use ssl!

Hmm, I must have been confused then, because I created this issue because I thought the error appeared even if ssl=false. But I can't reproduce it anymore.


Change script for link

I fixed a script tag that needed to be link to be able to import slides.min.css

Thanks!


JTD fails validation of discriminated union

What version of Ajv are you using? Does the issue happen if you use the latest version?
8.11.0
Ajv options object

{}

JSON Schema

{
    "discriminator": "dicriminatorProperty",
    "mapping": {
        "manual": {
            "properties": {
                "first": { "type": "uint16" },
                "second": { "type": "uint16" },
                "third": { "type": "uint16" },
                "fourth": { "type": "uint16" },
                "fifth": { "type": "uint16" },
                "sixth": { "type": "uint16" },
                "additionalOne": { "type": "uint16" },
                "additionalTwo": { "type": "uint16" }
            }
        },
        "auto": {
            "properties": {
                "first": { "type": "uint16" },
                "second": { "type": "uint16" },
                "third": { "type": "uint16" },
                "fourth": { "type": "uint16" },
                "fifth": { "type": "uint16" },
                "sixth": { "type": "uint16" },
                "additionalThree": { "type": "uint16" }
            }
        }
    }
}

Sample data

 {
      "dicriminatorProperty": "manual",
      "first": 17,
      "second": 17,
      "third": 17,
      "fourth": 17,
      "fifth": 17,
      "sixth": 17,
      "additionalOne": 17,
      "additionalTwo": 17
}

Your code
const commonProperties = {
    first: { type: "uint16" },
    second: { type: "uint16" },
    third: { type: "uint16" },
    fourth: { type: "uint16" },
    fifth: { type: "uint16" },
    sixth: { type: "uint16" }
};

const schema = {
    discriminator: "dicriminatorProperty",
    mapping: {
        manual: {
            properties: {
                ...commonProperties,
                additionalOne: { type: "uint16" },
                additionalTwo: { type: "uint16" }
            }
        },
        auto: {
            properties: {
                ...commonProperties,
                additionalThree: { type: "uint16" }
            }
        }
    }
};

const Ajv = require("ajv/dist/jtd");
const ajv = new Ajv();
const validate = ajv.compile(schema);

const data1 = {
    dicriminatorProperty: "manual",
    first: 17,
    second: 17,
    third: 17,
    fourth: 17,
    fifth: 17,
    sixth: 17,
    additionalOne: 17,
    additionalTwo: 17
};

const data2 = {
    dicriminatorProperty: "auto",
    first: 17,
    second: 17,
    third: 17,
    fourth: 17,
    fifth: 17,
    sixth: 17,
    additionalThree: 17
};

// ---------------------------------------------------
// This validation passes
// ---------------------------------------------------
console.log("Valid data1? ", validate(data1));

// ---------------------------------------------------
// This validation fails
// ---------------------------------------------------
console.log("Valid data2? ", validate(data2));

Validation result, data AFTER validation, error messages
{
    instancePath: "/dicriminatorProperty",
    schemaPath: "/mapping/manual",
    keyword: "properties",
    params: {
         error: "additional",
         additionalProperty: "dicriminatorProperty"
    },
    message: "must NOT have additional properties"
}

What results did you expect?
The number of properties in the object seems to be affecting the validation result. This should not happen and discriminator should not be recognised as an additional property.
Are you going to resolve the issue?
Resolution of this issue is non actionable by me

not reproducible on smaller example: https://runkit.com/esp/637163192eb1b90008da2666
seems to need exactly that number of properties, for me data1 fails that has more properties, data2 passes.


space.path is not set when fetching space from backend

I'm submitting a ...
[ x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

What is the current behavior?
The path of every space on http://fabric8.almighty.io/pmuir/spaces is 'undefined'

What is the expected behavior?
The path is the name of the space, converted to a URL (i.e. spaces etc. removed)

@VineetReynolds ^^^

@VineetReynolds is going to remove space.path

I think this is fixed.


YOLOros turns red staffs into blue staffs

It seems that red exchanges with blue.
The left picture runs on yolo, the rights picture is the raw image which is in the correct color

i dont know how to solve it, so i decide to reinstall yoloros and i will comment if this problem is solved
probably the problem is input picture using opencv in yolo

I solve this problem。
AlexAB Daknet based on RGB and opencv read pictures on BGR
Alex has already converted BGR into RGB, so darknet works well.
But in YoloObjectDetector.cpp line:377 rgbgr_image(buff_[buffIndex_]);
RGB flips back to BGR,so just notes this sentence and the result turns great.

I solve this problem。 AlexAB Daknet based on RGB and opencv read pictures on BGR Alex has already converted BGR into RGB, so darknet works well. But in YoloObjectDetector.cpp line:377 rgbgr_image(buff_[buffIndex_]); RGB flips back to BGR,so just notes this sentence and the result turns great.

I am facing this problem too.
rgbgr_image() turns rgb into bgr and I try to use cvtColor with cv::COLOR_BGR2RGB to turn the color back in publishInThread().
However, I still get the image of the wrong color that red exchanges into the blue.


feat(ORM): outofband topology manager

What type of PR is this?
Enhancements
What this PR does / why we need it:
Add topology manager with policies(none, best-effort, restrict, single-numa-node, numeric) for ORM.
Pods added by ORM should GetTopologyHints from QRM plugins and generated a best hint by topology manager policy before allocate resource. Dedicated-cores pods with numaBinding can be allocated resource by this way in ORM.

@caohe pls have a look for this pr


Choosing USB audio source

This is a request for help rather than an issue.
I want to record audio off a USB device.  I've seen code that populates the available devices using AudioManager. However, I have found that AudioManager reports only the inbuilt devices - the list doesn't change when I plug in the USB device.
How do I get hold of the attached USB device as an audio source? I've looked at UsbManager and see the events of the device being plugged in / detached, but I can't figure out how to get a device identifier that I can pass through to Aaudio (from UsbManager -> UsbDevice -> UsbInterface...). Or should I be doing something altogether different?
Many thanks for any help.

Solved. Turns out AudioManager does report devices plugged in over USB - this didn't happen only because of a bug in my code. The device id in the returned instance of AudioDeviceInfo can be used with native code.
I'd delete this issue if I could but there appears to be no way of doing so!


Create S3Client and DynamoDBClient in cache.ts

Currently S3Client and DynamoDBClient are created in server-adapter.ts and passed into cache.ts via globalThis.
https://github.com/sst/open-next/blob/1ce30f6289b43d803aefa51b6a860c8af1b9e65e/packages/open-next/src/adapters/server-adapter.ts#L38-L45
Any benefit over creating them directly in cache.ts?

Yes, i think it was this that was causing an issue when the lambda was up for a very long time and with enough request, the lambda was crashing with EMFILE too many open files.
The problem is that the incremental cache is recreated on every request and required on every request (And the require cache is also cleared). It was causing some file to stay open which after enough time would cause the issue. It was also making the memory grow out of control
Unfortunately i haven't been able to successfully reproduce this issue since it requires enough traffic to a single lambda instance

Documented above explanation in the comment.
https://github.com/sst/open-next/blob/746d73a8eb8b0e9e0c5d1101c441ec22315dd093/packages/open-next/src/adapters/server-adapter.ts#L38-L43


Upgrade to Babel 7 & package install fix

Ciao,
I'm so glad I found this project yesterday -  amazing thing!
One problem - when installing via npm/yarn it simply did not run (at least on my Windows) 😭
Error: Cannot find module 'samba'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:571:15)
    at Function.Module._load (internal/modules/cjs/loader.js:497:25)
    at Module.require (internal/modules/cjs/loader.js:626:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (E:\samba\bin\samba.js:5:15)
    at Module._compile (internal/modules/cjs/loader.js:678:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:689:10)
    at Module.load (internal/modules/cjs/loader.js:589:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:528:12)
    at Function.Module._load (internal/modules/cjs/loader.js:520:3)

It looks, that babel-plugin-module-resolver did not really worked for me. I symlinked cloned repro, and after taking samba for a spin and seeing how great it works - I thought I would fix it, before investing time in building some scripts for my personal projects.
Here's what I did:

Cut babel-plugin-module-resolver - it was really only used in one line in bin/samba.js and probably caused aforementioned issue. Also, as not part of official @babel monorepo it's not so cool/safe to use, esspecially with Babel 7 open Issue about Babel 7

I simply used this to resolve Samba in bin

const Samba = require(`${__dirname}/../src`).Samba;

As I was tuning babel, I thought I could bump it to Babel 7

It's in beta for last half a year, but rc should be any day now.
Babel 7 moved all deps to monorepo @babel so I changed them.
The preset is env & flow + plugins for proposal features you used. I dropped preset-stage-0 as not really necessary.
Added babel-core@bridge (backward api compatibility layer) for babel-jest that has babel-core in deps

After all that it looked that registerBabel.js was ready for some cutting

module resolver plugin is gone
path mapping is not necessary, because shape of babelrc match exactly what should be passed to register (what a surprise 😄 )  i.e. "plugins": ["@babel/plugin-proposal-class-properties"]
ignore option only support array now, so ignore fn needed to be transformed into some regex/glob pattern. I looked it up and 'node_modules' are default ignored and ignore pattern match is done relative to cwd() - so it look the whole thing could also be cut.

I wanted to make a commit and outdated 'lint-staged' did not think node 10 > node 6 so I upgraded it too.

What do you think?

Hey Jakub, I'm glad you liked the project and decided to contribute :). I hope it will speed up development for your personal projects as much as it has for me.
Your PR looks great, and upgrading to Babel 7 is definitely a good thing! I'll test it later and if nothing breaks I'll merge it.

I just noticed it's still not fixed. I jumped a bit and did not thought about test and samba dirs that rely on this module resolver plugin ...
Surprisingly tests passes so it looks  recursive samba module reference is all ok even without setting module aliases.
I'll try to tweak it and see if I can solve it (maybe the issue is only on my machine, need to try) and submit PR revision and if not I'll cut this PR only for babel upgrade, because it's a breeze,

Hey @vadistic,
Just tested and unfortunately it didn't work. Inside the samba itself it works, but when I tried going to another folder and calling sb g init, it doesn't resolve the paths as intended.
The babel setup on this project is quite tricky. I guess it would be good to have a more detailed explanation about it somewhere.
About the tests
I have to admit that I'm not quite sure how 'samba' gets resolved on the tests. Seems to be some serious wizardry 🍀
The tests that are in place are only for File and they don't test commands directly, so the tests can pass and the actual commands still fail. It would be nice to have tests that actually run commands at
some point.
Testing from scratch
I tried setting up my environment from scratch and npm install -g samba and it works for me, but I'm on OSX, so I'm not sure it counts since you had issues on Windows.
Cloning the repo however, brought to my attention to the fact that there were steps missing on the Contributing.md guide, so I updated it. For samba to work with npm link, you need to perform both npm link and npm link samba.
https://github.com/pedsmoreira/samba/blob/master/CONTRIBUTING.md#development
About module-resolver
I guess it still needs to be there to resolve which files should be parsed by babel and which don't. I wasn't quite sure if Babel 7 would work without it, since there are differences from Babel 6 and Babel 7, but looks like it still needs the module resolver.
Because samba is installed and gets placed inside node_modules somewhere, babel understands that it doesn't need to be parsed, therefore, no files inside src/ and samba/ get parsed, so they throw syntax errors. The same would be true if you downloaded a set of commands and tried to import them on your samba-setup.js.
Also, samba is imported from generators inside each individual project and, because samba is not installed on the project itself, not having the alias implies that Babel can't find it.
I'm not a Babel expert and I'm still a bit confused with all the changes that happened between Babel 6 and 7, so some of these statements above may not be true for Babel 7 anymore.
Why not just pre-compile it?
The idea is that both the samba module, and everything that's inside a samba/ folder (generators), should get parsed by babel-register. We wouldn't need to do that if those files were compiled before being published to npm, but the intention is to make development easier, so the more steps are needed in order to make it work, the less people will be encouraged to use Samba. It's important to take into account that this project is intended to serve all languages and frameworks, so not everyone will be a savvy javascript developer.
...
Thanks for all your effort to figure this stuff out @vadistic.
Windows can be tricky with these things, so I'll see if I can get my hands on a Windows machine to test this module resolution issue. If you can find the fix that would be awesome, in that case, please update this PR :)
If you still want to pursue upgrading the project to Babel 7, I encourage you to do so. I'm not sure it would be possible at this moment, given the issue with babel-loader you pointed, but it would be nice to have Babel 7.

Thank you for really detailed explanation.
Anyway, I'll try to fix that, but till now I have moderate luck :)
My current commit is working from github install by using kind of a hack in babelResolver to look for dependencies in partent - global node_modules (test also pass, I undid my commit and this confused travis)
function buildPath(name) {
  return normalize(`${__dirname}/../../${name}`);
}

There should be a cleaner way to do that and, because now it breaks running samba locally/via yarn link... And it breaks my ignore glob **/samba/node_modules/** for babel.
But I think I'm closer 😄

Hey @vadistic,
I got a Windows machine to perform some tests and I believe I found the issue.

Windows paths can be \\ or \ instead of /, here's the fix:
https://github.com/pedsmoreira/samba/blob/master/bin/registerBabel.js#L7

require('samba') did not work on bin/samba.js on Windows. Seems like the symlinking is tricky there, here's the fix:
https://github.com/pedsmoreira/samba/blob/master/bin/samba.js#L6

It's still necessary to have samba linked through babel, since we perform import 'samba' from the generators and samba-setup.
Please let me know if this fixes your errors and feel free to continue the Babel 7 upgrade if you wish to.

Since there have been no more updates, I'm closing this PR.


Update to Wine 9.9 development to support wayland native.

Update to Wine 9.9 development to support wayland native.
Move Config check ealier to allow for env settings in config file better.
Fix Icon showing intask bar when started from menu
Allow wine version fix in docker build (fixed to 9.9)

Ill merge this and build zwift from scratch which will from this point onward create a new zwift image with wine 9.9.
:crossed_fingers:

https://github.com/netbrain/zwift/actions/runs/9299444600

I'll try without mono I think it was needed before because it auto installs on wineboot.  But will  check :)

Build failed I ahve seen that before it is getitng a previous version from the web site and updating to the current version in this case zwift is 1.65 from the website and 1.66 is the actual.
I updated the line to not use cache but still :(

I am updateing to add a better check that checks that one version is equal to or greater than


Label and Description Customization

Where can i customize the Bubblemap Labels and Title label? How to enter Metadata? in which format?
I have my CSV file, here https://github.com/RCGTDev/A-donde-Van-Mis-Impuestos/blob/gh-pages/csv/by-cofog1-then-cofog2.csv
How can I visualize the labels of cofog_level1_name and cofog_level2_name?

Hello! Thanks for your excellent question. I'm currently thinking very hard about this very topic, and it is a work in progress.  In an attempt to address your use case, I thought one way toward this would be to slightly alter your aggregated CSV to only include the code names.  Example:
"01","01.1",232151758
"01","01.2",402301000
"01","01.3",1385618086
...

And then separately pass a labels key in your visualization initialization code.  Example:
 var data = {
    currency: "GBP",
    aggregated_csv_url: "csv/by-cofog1-then-cofog2.csv",
    amount_col_name: "amount",
    labels: {
      "root": "Total",
      "01":	"Servicios públicos generales",
      "02":	"Defensa",
      "03":	"Orden público y seguridad",
      ...

What do you think about this solution?

Hi danfowler,
Thanks a lot for the feedback. That solution would work for us for the time being (I'm currently working on the project that raised the issue).
We couln't get it to work though. Is your work in progress already available on your repo? Maybe on a specific branch?
We're currently testing with the built version of the master branch, but I can't seem to locate where the labels key is being processed.
As far as I could follow the code the label's <div /> element for each bubble is created in BubbleTree.Bubbles.Icon show function, which uses the node.shortLabel property (set in the init function, from the node.label property).
Since we're using a local CSV instead of the APIs Aggregator, each node is built with the CSV value as name, and so as label.
Would you mind pointing me on the right direction towards getting this example to work as in the image on your reply?

Hi @hectorh30 sorry for the delay.  I had to have a think and then many other things got in the way :disappointed:.  I have added the front-end labeling to 0.5.1 and pushed it to master.  Please let me know if this helps and is what you were looking for.
There is a demo here: http://labs.openspending.org/openspendingjs/demo/bubbletree/#/~/total
HTML here: https://github.com/openspending/openspendingjs/blob/master/demo/bubbletree/index.html

@danfowler, we ended up making the local changes we needed to get it working for a little demo we had two weeks ago. But I'll have a look at the new version and update accordingly as soon as I get green light to go on.
Thanks a lot, and keep up the good work :-)

:+1: gracias. Keep me updated :)


 This PR puts all that in one place so i can link to it when others are going to be contributors.
@elizabethmcd am I missing anything?
@mezarque would this have been helpful when you dev'd your phenom python materials?
@mertcelebi any thoughts?

great point, i'll add attribution!


Qh rk miv

Second Try at the MIV branch

See if you like or hate my ApiUtils class addition and its use in sitefarm api.