Laravel 5.3 on Valet

Try to install it with composer require rinvex/fort. Got this error message:
[InvalidArgumentException]

Could not find package rinvex/fort at any version for your minimum-stability (stable). Check the package spelling or your minimum-stability

When I try with : composer require rinvex/fort ~1.0@dev, I get:
Problem 1
    - Installation request for rinvex/fort ~1.0@dev -> satisfiable by rinvex/fort[1.0.x-dev].
    - rinvex/fort 1.0.x-dev requires rinvex/support dev-develop -> satisfiable by rinvex/support[dev-develop] but these conflict with your requirements or minimum-stability.

On Homestead, where I have a test project with Laravel 5.2, installation passes with no problem.
PHP version 7.0 on both.

Greetings @dinogit
Until this package is being tagged, you can add "minimum-stability": "dev" in your project's composer.json & it will install normally. Make sure to get latest version since we've pushed new important commits in the past few minutes.
Feel free to re-open this issue or another if you've anything else 👍


Merge autonomous code into master

TODO:

[ ] Test autonomous code on the water
[ ] Adjust parameters as needed based on water test results

Will leave as is for now since this project iteration has ended. If anyone wishes to continue where we left off, feel free to reopen this.


queue.js has errors when processed with ES2015

See babel

repl: Unexpected token (45:30)
function notify() {
  if (error != null) await(error);
  else if (all) await(error, tasks);
  else await.apply(null, [error].concat(tasks));
}

You’re using an ancient version (1.0.7, January 2014). The code was rewritten in 1.1.0 (January 2016) fixing this problem, and the latest release is 2.0.3 (March 2016).

My apologies! I was chasing this down from a Meteor package which had incorporated queue-async. Quite a rabbit hole.


About the total epoch

Thank you for your excellent work! When I check the number of epochs in the AcfNet configs for training on SceneFlow dataset, I found total_epochs is 20, but the checkpoint is set to epoch_10.pth. May I ask how many epochs the network is trained for the final paper results? Thank you so much!

Hi, @xy-guo ,
As the paper claimed, for a fair comparison with other state-of-the-art stereo matching methods on scene_flow, we only trained 10 epochs, the corresponding checkpoint is here: 10 epochs. But for submission on KITTI, we further trained 20 epochs and the corresponding checkpoint is here: 20 epochs

Thank you so much!


Change button text for commenting and closing an issue at the same time (#23135)

Backport #23135
Close  #10468
Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could be changed when content changes.
After introducing SimpleMDE/EasyMDE, there is no code  for updating the button text.

Please wait for https://github.com/go-gitea/gitea/pull/23168 together, it fixes a regression bug of undefined-checking.
🙏


Not ignoring vue inside nested code blocks in markdown

Try something like this in a markdown file:
````md
```html

    {{ todo.text }}

```
````

Working fine with one-level code blocks.
I'm on<EMAIL_ADDRESS>

Straightforward to fix :)


Update docker image to 1.3.0

@lmachens Could you please update docker image to 1.3.0?
And README contains 1.1.0, but last version is 1.2.0 in docker hub.

Done
docker push asosnovskiy/meteor-apm-server:1.4.0


Does not work when upgrading jackson-module-kotlin

15.2.2 version is now compatible / pkg upload fixed.


UX Refactor | Hide unfinished tabs for IDIR users |1|

https://trello.com/c/WSBoX0PG/627-ux-refactor-hide-unfinished-tabs-for-idir-users-1
For IDIR users, we should hide the following:

Hide Dashboard tab
Hide Notifications tab
Hide Settings tab

None of these tabs have any meaningful content on them. To reduce Branch confusion we should just hide them for now

 UX Refactor | Hide unfinished tabs for IDIR users |1|

 UX Refactor | Hide elements for IDIR users on the Credit Transactions page |1|


Skip pattern matching tests when running on older versions of Rubocop

Follow up to https://github.com/rubocop/rubocop-minitest/pull/294
I don't know why but these two pattern matching tests throw parsing errors on Rubocop <1.52 - I can't find anything in the changelog to indicate what actually changed in v1.52, nor can I reproduce this locally outside of the test suite; I've also checked the versions of other gems (notably rubocop-ast) and confirmed the issues seems to be within rubocop itself.
Since there are only two tests impacted I think this is fine - even if no one spends the time figuring out the specifics to improve this, eventually it'll go away when support for Ruby 2.7 and older versions of Rubocop are dropped 🤷

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] ~Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.~

Actually, the parsing of the source code depends on the Ruby version used for analysis, not the runtime Ruby version. Can you update it to refer value of target_ruby_version instead of RuboCop's version?

I'm not at my laptop right now so can't double check, but I did my testing using Ruby 2.7 and went through every version of RoboCop - so unless the bug is with RoboCops detention of Ruby features I'm not sure that's it...
(Also, all the other CIs are passing with latest RuboCop which includes Ruby 2.7)

Ok right I see what you mean - it's the (default) version of Ruby being targeted by Rubocop, which got changed to 2.7 in v1.50 which is why those versions pass.
I've updated my check :)

Ah, I'm sorry, it seems I misunderstood this. Can you revert to the previous implementation?
https://github.com/rubocop/rubocop-minitest/compare/91950bb2a23dcdb5f97f9ccc6f014cb62898b296..8847638552bd2faf9512572a774f19a18c6bdab9
However, it appears the tests fail with RuboCop 1.50, not 1.51. And,
    segments = Gem::Version.new(RuboCop::Version.version).segments

-   # pattern matching cannot be parsed until v1.52 for some reason
-   skip if segments[0] <= 1 && segments[2] <= 51
+   skip 'Pattern matching tests fail for some reason until version 1.51.' if segments[0] <= 1 && segments[2] <= 50
    segments = Gem::Version.new(RuboCop::Version.version).segments

Note: The following is repro steps with RuboCop 1.50:
% bundle exec ruby -Itest test/rubocop/cop/minitest/multiple_assertions_test.rb
(snip)

  1) Error:
MultipleAssertionsTest#test_does_not_register_offense_when_single_assertion_inside_pattern_matching:
RuntimeError: Error parsing example code
    /Users/koic/src/github.com/rubocop/rubocop-minitest/lib/rubocop/minitest/assert_offense.rb:165:in `inspect_source'
    /Users/koic/src/github.com/rubocop/rubocop-minitest/lib/rubocop/minitest/assert_offense.rb:98:in `assert_no_offenses'
    test/rubocop/cop/minitest/multiple_assertions_test.rb:471:in `test_does_not_register_offense_when_single_assertion_inside_pattern_matching'

  2) Failure:
MultipleAssertionsTest#test_registers_offense_when_multiple_expectations_inside_pattern_matching [test/rubocop/cop/minitest/multiple_assertions_test.rb:429]:
--- expected
+++ actual
@@ -1,6 +1,5 @@
 "class FooTest < ActiveSupport::TestCase
   test 'something' do
-  ^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [3/1].
     case variable
     in pattern1
       assert_equal(foo, bar)

  3) Failure:
MultipleAssertionsTest#test_registers_offense_when_multiple_expectations_inside_assigned_pattern_matching [test/rubocop/cop/minitest/multiple_assertions_test.rb:450]:
--- expected
+++ actual
@@ -1,6 +1,5 @@
 "class FooTest < ActiveSupport::TestCase
   test 'something' do
-  ^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [3/1].
     _ = case variable
         in pattern1
           assert_equal(foo, bar)

37 runs, 36 assertions, 2 failures, 1 errors, 0 skips

Ah, I'm sorry, it seems I misunderstood this

I don't think you did? I agree with the new change - the issue is with the version of Ruby that Rubocop is targeting, and it happens the default changed in v1.50 (which yes I realised I mixed up with v1.51); both versions of my fix would work but checking the RuboCop target version is the better one because technically just because the default target Ruby version is now 2.7, you could change it back to 2.6.

As indicated by the failing test, it was not the Ruby version or pattern matching that caused the flaky tests:
https://github.com/rubocop/rubocop-minitest/actions/runs/8134207387/job/22226821848?pr=304
The issue is a race condition caused by the implementation of the AssertOffense testing module. As a workaround, I have opened #305. Thank you for investigating.


[Feature] Multithread memmap

TODO:

[ ] Doc
[ ] Tests
[ ] hide the executor logit under a private _memmap_
[ ] Make a memmap version that does not change the tenosrdict inplace

@laurencer thanks for the review.
I created the futures (execution time is roughly identical as before). I thought that executor.__exit__() would wait for submitted jobs to complete but after testing it, it doesn't seem to be the case. Do we want to optionally let users proceed with the main script without waiting for the futures to complete (and return the futures)?
I also prevented conflicting executor and num_threads, but eventually I think executor will only be an arg of a sub-call to a new _memmap private function (as well as futures to restrict the args of the public method to what they should be).

@vmoens Thanks for the information. Just out of curiosity, have you try to compare the performance if the target storage is a memory file system?

That would be memmap_() (without file associated). I can check that!


Minor selection_exposure optimisations by caching properties

Simulated optimisations by moving runner lookup to where it is needed

Coverage decreased (-0.02%) to 94.46% when pulling e367b13581f96dbccf72ee0c3dc1c3beea66ed35 on release/1.16.2 into dff610d5929d1c98cd39aa57ae1cab05ca7c4a87 on master.


doc: update book link

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@erossignon could you sign the CLA, would love to upstream your change?


training

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dmitryagapov , could you please resolve conflicts and make the CI green?
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR!
npm ERR!
npm ERR! Missing<EMAIL_ADDRESS>npm ERR!

@dmitryagapov , you add a migration file and remove it in next commit. It is missing now.

@dmitryagapov , could you please commit your latest changes and resolve conflicts?

@dvkruchinin could you please check why ESLint doesn't create report?

@dmitryagapov

could you please check why ESLint doesn't create report?

Because you have the error in the log:
npm ERR! cipm can only install packages with an existing package-lock.json or npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or later to generate it, then try again.

Since this npm ci failed with an error, there was no cd to the root directory of the project. Because of this, errors
cd: ./cvat-canvas: No such file or directory
cd: ./cvat-data: No such file or directory
cd: ./cvat-core: No such file or directory

followed.

Before reviewing the PR, please add a meaningful name and update the description (at least need to click checkboxes and perform corresponding conditions if applicable). Also need to fix CI checks (Bandit, ESlint) and some REST API tests failed as I can see.

@dmitryagapov
Please, pull the latest changes. I've merged develop, resolved conflicts and fixed package-lock files.

Coverage decreased (-1.2%) to 70.994% when pulling 15fdf69bf33cb6fc025c3fe1ae7b81dbf06394bb on da/training into 86eef84717fc901a1910a0c0290758b774835164 on develop.

LGTM, please fix eslint issues https://github.com/openvinotoolkit/cvat/pull/2785/checks?check_run_id=2096339397

@nmanovic could you please review pr?

@dmitryagapov , I will do till EOW. Thanks for the great contribution!

@nmanovic
I do not see critical issues, but some pieces of client code are better to be refactored.
Maybe better to do it in a separated PR.


HIVE-25980: Reduce fs calls in HiveMetaStoreChecker.checkTable

What changes were proposed in this pull request?
Remove unnessary fs.exists call in HiveMetaStoreChecker.checkTable
Why are the changes needed?
Currently HiveMetaStoreChecker.checkTable checks fs.exists for all the existing partitions one by one, This can be a costly operation for Object/Cloud storage if there are 1000s of partitions overcall it could run for long time. Changing it to run multithreaded will improve performance.
We currently get all the partition directories in table path as part of https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java#L398
Output from this call can be used to get the difference and reduce fs.exists call significantly.
PS: In worse case if user removes all partitions dirs from table and runs msck repair table there would not be any perf gain, we can still add multi threaded calls to check multiple paths at once, however it is not usual to see 1000s of partitions being removed and then run msck.
Does this PR introduce any user-facing change?
No
How was this patch tested?
For stability of the patch added new clientpositive test case -> msck_repair_multi_thread.q
additionally the patch was tested manually in terms of performance.
i.e with 33k partitions without patch MSCK operation took 2000 seconds vs with Patch <150 seconds.

Try to squash merge all the commits into one single commit.

@cravani: I was on a long PTO, and I do not remember our status here. Are you waiting for me?

@cravani - I have an optimized solution for this. If you are not working on this, Can i take it forward?

@cravani - I have an optimized solution for this. If you are not working on this, Can i take it forward?

Hello @shameersss1  My apologies for the delay on this request, I have been on a long vacation and plan to start the work this weekend. Feel free to add your commits if I am unable to move this forward by end of next week (June 05).

@cravani: Left a few small comments, also please rebase. The failing test will be fixed by the rebase

@cravani: Only a small nit, then we are ready.
Thanks!

I feel moving the loop of partition iteration from metastore to findUnknownPartitions method would require less changes than the other way around!

The changes LGTM +1.
@cravani  - Great work :)


iOS app crashes on device with latest nightly 01.02.2015 (was working before)

The game which was successfully working crash on the real device (iPhone 5s) with the latest nightly 01.02.2015 right at the start. At the same time it works fine in simulator of the same device. Here is the simbolication of crash report:
11: [J]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V (in Ted the Jumper) + 180
12: [j]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V[clinit] (in Ted the Jumper) + 84
13: [J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.debug(Ljava/lang/String;Ljava/lang/String;)V (in Ted the Jumper) (/IOSApplication.java:348)
14: [J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z (in Ted the Jumper) (/IOSApplication.java:123)
15: [J]com.badlogic.gdx.backends.iosrobovm.IOSApplication$Delegate.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z (in Ted the Jumper) + 112
16: [J]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z (in Ted the Jumper) (/Unknown source:1048629)
17: [j]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z[callback] (in Ted the Jumper) + 236

The issue was got using last libGDX and roboVM snapshot. From the history It is probably that the problem is exactly in the commit 2 days ago: 41708a5. It do the opposite to what it is named :) libGDX 1.5.3 with roboVM beta-03 works just fine. Latest SNAPSHOTS (libGDX & roboVM) fail with this issue.
This is connected to roboVM issue #737

What's the device?
On Feb 1, 2015 11:27 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

The game which was successfully working crash on the real device (iPhone
5s) with the latest nightly 01.02.2015 right at the start. At the same time
it works fine in simulator of the same device. Here is the simbolication of
crash report:
11: [J]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V (in Ted the Jumper) + 180
12: [j]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V[clinit] (in Ted the Jumper) + 84
13: [J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.debug(Ljava/lang/String;Ljava/lang/String;)V (in Ted the Jumper) (/IOSApplication.java:348)
14: [J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z (in Ted the Jumper) (/IOSApplication.java:123)
15: [J]com.badlogic.gdx.backends.iosrobovm.IOSApplication$Delegate.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z (in Ted the Jumper) + 112
16: [J]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z (in Ted the Jumper) (/Unknown source:1048629)
17: [j]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z[callback] (in Ted the Jumper) + 236
The issue was got using last libGDX and roboVM snapshot. From the history
It is probably that the problem is exactly in the commit 2 days ago:
41708a5
https://github.com/libgdx/libgdx/commit/41708a5e801cac069e7b742c35f1ad4a57f937e1.
It do the opposite to what it is named :) libGDX 1.5.3 with roboVM beta-03
works just fine. Latest SNAPSHOTS (libGDX & roboVM) fail with this issue.
This is connected to roboVM issue #737
https://github.com/libgdx/libgdx/pull/737
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800.

This should be reproducible with a blank application too, no?

It is iPhone 5s.
02 февр. 2015 г. 6:28 пользователь "Mario Zechner"<EMAIL_ADDRESS>написал:

What's the device?
On Feb 1, 2015 11:27 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

The game which was successfully working crash on the real device (iPhone
5s) with the latest nightly 01.02.2015 right at the start. At the same
time
it works fine in simulator of the same device. Here is the simbolication
of
crash report:
11:
[J]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V
(in Ted the Jumper) + 180
12:
[j]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V[clinit]
(in Ted the Jumper) + 84
13:
[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.debug(Ljava/lang/String;Ljava/lang/String;)V
(in Ted the Jumper) (/IOSApplication.java:348)
14:
[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z
(in Ted the Jumper) (/IOSApplication.java:123)
15:
[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication$Delegate.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z
(in Ted the Jumper) + 112
16:
[J]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z
(in Ted the Jumper) (/Unknown source:1048629)
17:
[j]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z[callback]
(in Ted the Jumper) + 236
The issue was got using last libGDX and roboVM snapshot. From the
history
It is probably that the problem is exactly in the commit 2 days ago:
41708a5
<
https://github.com/libgdx/libgdx/commit/41708a5e801cac069e7b742c35f1ad4a57f937e1>.

It do the opposite to what it is named :) libGDX 1.5.3 with roboVM
beta-03
works just fine. Latest SNAPSHOTS (libGDX & roboVM) fail with this
issue.
This is connected to roboVM issue #737
https://github.com/libgdx/libgdx/pull/737
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388285.

iOS 7 or 8? :)
On Feb 1, 2015 11:39 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

It is iPhone 5s.
02 февр. 2015 г. 6:28 пользователь "Mario Zechner" <
<EMAIL_ADDRESS>написал:

What's the device?
On Feb 1, 2015 11:27 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

The game which was successfully working crash on the real device
(iPhone
5s) with the latest nightly 01.02.2015 right at the start. At the same
time
it works fine in simulator of the same device. Here is the
simbolication
of
crash report:
11:

[J]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V

(in Ted the Jumper) + 180

12:

[j]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V[clinit]

(in Ted the Jumper) + 84

13:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.debug(Ljava/lang/String;Ljava/lang/String;)V

(in Ted the Jumper) (/IOSApplication.java:348)

14:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) (/IOSApplication.java:123)

15:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication$Delegate.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) + 112

16:

[J]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) (/Unknown source:1048629)

17:

[j]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z[callback]

(in Ted the Jumper) + 236

The issue was got using last libGDX and roboVM snapshot. From the
history
It is probably that the problem is exactly in the commit 2 days ago:
41708a5
<

https://github.com/libgdx/libgdx/commit/41708a5e801cac069e7b742c35f1ad4a57f937e1>.

It do the opposite to what it is named :) libGDX 1.5.3 with roboVM
beta-03
works just fine. Latest SNAPSHOTS (libGDX & roboVM) fail with this
issue.
This is connected to roboVM issue #737
https://github.com/libgdx/libgdx/pull/737
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388285.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388879.

The latest. 8.1 I suppose. I'm in the plain now and do not have device with
me...
02 февр. 2015 г. 6:41 пользователь "Mario Zechner"<EMAIL_ADDRESS>написал:

iOS 7 or 8? :)
On Feb 1, 2015 11:39 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

It is iPhone 5s.
02 февр. 2015 г. 6:28 пользователь "Mario Zechner" <
<EMAIL_ADDRESS>написал:

What's the device?
On Feb 1, 2015 11:27 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

The game which was successfully working crash on the real device
(iPhone
5s) with the latest nightly 01.02.2015 right at the start. At the
same
time
it works fine in simulator of the same device. Here is the
simbolication
of
crash report:
11:

[J]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V

(in Ted the Jumper) + 180

12:

[j]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V[clinit]

(in Ted the Jumper) + 84

13:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.debug(Ljava/lang/String;Ljava/lang/String;)V

(in Ted the Jumper) (/IOSApplication.java:348)

14:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) (/IOSApplication.java:123)

15:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication$Delegate.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) + 112

16:

[J]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) (/Unknown source:1048629)

17:

[j]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z[callback]

(in Ted the Jumper) + 236

The issue was got using last libGDX and roboVM snapshot. From the
history
It is probably that the problem is exactly in the commit 2 days ago:
41708a5
<

https://github.com/libgdx/libgdx/commit/41708a5e801cac069e7b742c35f1ad4a57f937e1>.

It do the opposite to what it is named :) libGDX 1.5.3 with roboVM
beta-03
works just fine. Latest SNAPSHOTS (libGDX & roboVM) fail with this
issue.
This is connected to roboVM issue #737
https://github.com/libgdx/libgdx/pull/737
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388285.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388879.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388911.

P.S. The build is 64 bit if it matters.
02 февр. 2015 г. 6:41 пользователь "Mario Zechner"<EMAIL_ADDRESS>написал:

iOS 7 or 8? :)
On Feb 1, 2015 11:39 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

It is iPhone 5s.
02 февр. 2015 г. 6:28 пользователь "Mario Zechner" <
<EMAIL_ADDRESS>написал:

What's the device?
On Feb 1, 2015 11:27 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

The game which was successfully working crash on the real device
(iPhone
5s) with the latest nightly 01.02.2015 right at the start. At the
same
time
it works fine in simulator of the same device. Here is the
simbolication
of
crash report:
11:

[J]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V

(in Ted the Jumper) + 180

12:

[j]org.robovm.apple.foundation.Foundation.log(Ljava/lang/String;Lorg/robovm/apple/foundation/NSObject;)V[clinit]

(in Ted the Jumper) + 84

13:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.debug(Ljava/lang/String;Ljava/lang/String;)V

(in Ted the Jumper) (/IOSApplication.java:348)

14:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) (/IOSApplication.java:123)

15:

[J]com.badlogic.gdx.backends.iosrobovm.IOSApplication$Delegate.didFinishLaunching(Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) + 112

16:

[J]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z

(in Ted the Jumper) (/Unknown source:1048629)

17:

[j]org.robovm.apple.uikit.UIApplicationDelegate$ObjCProxy.$cb$application$didFinishLaunchingWithOptions$(Lorg/robovm/apple/uikit/UIApplicationDelegate;Lorg/robovm/objc/Selector;Lorg/robovm/apple/uikit/UIApplication;Lorg/robovm/apple/uikit/UIApplicationLaunchOptions;)Z[callback]

(in Ted the Jumper) + 236

The issue was got using last libGDX and roboVM snapshot. From the
history
It is probably that the problem is exactly in the commit 2 days ago:
41708a5
<

https://github.com/libgdx/libgdx/commit/41708a5e801cac069e7b742c35f1ad4a57f937e1>.

It do the opposite to what it is named :) libGDX 1.5.3 with roboVM
beta-03
works just fine. Latest SNAPSHOTS (libGDX & roboVM) fail with this
issue.
This is connected to roboVM issue #737
https://github.com/libgdx/libgdx/pull/737
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388285.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388879.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72388911.

If it is log, why doesn't this crash on 120 of IOSApplication?

Yeah, that's a really good question :/ I have no idea. I'll try to reproduce this. If someone else could reproduce it with a plain RoboVM app that just does logging, please let me know.

I'll try to reproduce it with a blank app or to avoid it by disable
logging. But I can do it only on weekend when I'll be back...
03 февр. 2015 г. 2:11 пользователь "Mario Zechner"<EMAIL_ADDRESS>написал:

Yeah, that's a really good question :/ I have no idea. I'll try to
reproduce this. If someone else could reproduce it with a plain RoboVM app
that just does logging, please let me know.
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72506861.

That would be awesome. No stress :)
On Feb 2, 2015 7:47 PM, "titovmaxim"<EMAIL_ADDRESS>wrote:

I'll try to reproduce it with a blank app or to avoid it by disable
logging. But I can do it only on weekend when I'll be back...
03 февр. 2015 г. 2:11 пользователь "Mario Zechner" <
<EMAIL_ADDRESS>написал:

Yeah, that's a really good question :/ I have no idea. I'll try to
reproduce this. If someone else could reproduce it with a plain RoboVM
app
that just does logging, please let me know.
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72506861.

—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-72513264.

I'm back and have done a simple test. The test device is iPhone 5s, firmware: 8.1.3 (12B466).
I have used the simple empty app with test logging at the very beginning of the launcher:
@Override
protected IOSApplication createApplication()
{
	Foundation.log("BEGIN");
	Foundation.log("%@", new NSString("test1"));
	Foundation.log("END");
	...
}

This code works fine when compiled to 32 bit IPA. However, it DOES CRASH at the second logging line (with "%@") when compiled to 64 bit IPA. So only "BEGIN" is logged before crash.
As a last test I have disabled the logging in my app at the early step like this:
@Override
protected IOSApplication createApplication()
{
	...
	final IOSApplication app = new IOSApplication(Game.instance, cfg);
	app.setLogLevel(Application.LOG_NONE);
	return app;
}

And now it also works in both 32 & 64 bit IPAs (but without logging).
The conclusion is that Foundation.log with formatting string IS BROKEN in 64 bit mode. This is a question to roboVM and not libGDX, I suppose. Should we reopen the issue report on roboVM side?

great job boiling it down! Yeah, i guess we can close this and opn one on
the RoboVM tracker.
On Sunday, February 8, 2015, titovmaxim<EMAIL_ADDRESS>wrote:

I'm back and have done a simple test. The test device is iPhone 5s,
firmware: 8.1.3 (12B466).
I have used the simple empty app with test logging at the very beginning
of the launcher:
@Override
protected IOSApplication createApplication()
{
Foundation.log("BEGIN");
Foundation.log("%@", new NSString("test1"));
Foundation.log("END");
...
}
This code works fine when compiled to 32 bit IPA. However, it DOES CRASH
at the second logging line (with "%@") when compiled to 64 bit IPA. So only
"BEGIN" is logged before crash.
As a last test I have disabled the logging in my app at the early step
like this:
@Override
protected IOSApplication createApplication()
{
...
final IOSApplication app = new IOSApplication(Game.instance, cfg);
app.setLogLevel(Application.LOG_NONE);
return app;
}
And now it also works in both 32 & 64 bit IPAs (but without logging).
The conclusion is that Foundation.log with formatting string IS BROKEN in
64 bit mode. This is a question to roboVM and not libGDX, I suppose. Should
we reopen the issue report on roboVM side?
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/issues/2800#issuecomment-73397587.

Moved to roboVM tracker (#748)

Hello!
You have a new message, please read http://como-funciona.es/choice.php?tpha
<EMAIL_ADDRESS>


failed to cherry pick PR 4172 from ty-dc, to branch release-v0.8

commits 9b6c48a2903090fe3ab921caadc327ae6c994c2f of ty-dc conflict when merging to branch release-v0.8, please manually cherry pick it by yourself.
PR https://github.com/spidernet-io/spiderpool/pull/4172 ,  action https://github.com/spidernet-io/spiderpool/actions/runs/11452647523
Auto-merging test/e2e/common/constant.go
Auto-merging test/e2e/common/pod.go
CONFLICT (content): Merge conflict in test/e2e/common/pod.go
Auto-merging test/e2e/common/spiderpool.go
Auto-merging test/e2e/coordinator/macvlan-underlay-one/macvlan_underlay_one_test.go
CONFLICT (content): Merge conflict in test/e2e/coordinator/macvlan-underlay-one/macvlan_underlay_one_test.go
Auto-merging test/e2e/reclaim/reclaim_test.go
CONFLICT (content): Merge conflict in test/e2e/reclaim/reclaim_test.go
Auto-merging test/e2e/reliability/reliability_test.go
CONFLICT (content): Merge conflict in test/e2e/reliability/reliability_test.go
Auto-merging test/scripts/debugEnv.sh
error: could not apply 9b6c48a2... Merge pull request #4172 from ty-dc/fix/optimize-e2e
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

#4195


Warning 'php-console-color' and 'php-console-highlighter' is abandoned.

Question:
Much as the package installs successfully, why do I get a warning about the usage of abandoned dependencies?
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
PS C:\xampp\htdocs\api-myapp\api> composer require --dev barryvdh/laravel-ide-helper
Using version ^2.7 for barryvdh/laravel-ide-helper
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 14 installs, 0 updates, 0 removals
  - Installing doctrine/event-manager (1.1.0): Loading from cache
  - Installing doctrine/cache (1.10.2): Downloading (100%)
  - Installing doctrine/dbal (2.10.2): Downloading (100%)
  - Installing seld/phar-utils (1.1.1): Downloading (100%)
  - Installing seld/jsonlint (1.8.0): Downloading (100%)
  - Installing justinrainbow/json-schema (5.2.10): Downloading (100%)
  - Installing composer/xdebug-handler (1.4.2): Downloading (100%)
  - Installing composer/spdx-licenses (1.5.4): Downloading (100%)
  - Installing composer/semver (1.5.1): Downloading (100%)
  - Installing composer/ca-bundle (1.2.7): Downloading (100%)
  - Installing symfony/filesystem (v5.1.3): Downloading (100%)
  - Installing composer/composer (1.10.9): Downloading (100%)
  - Installing barryvdh/reflection-docblock (v2.0.6): Downloading (100%)
  - Installing barryvdh/laravel-ide-helper (v2.7.0): Downloading (100%)
doctrine/cache suggests installing alcaeus/mongo-php-adapter (Required to use legacy MongoDB driver)
barryvdh/reflection-docblock suggests installing dflydev/markdown (~1.0)
barryvdh/reflection-docblock suggests installing erusev/parsedown (~1.0)
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Writing lock file
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: barryvdh/laravel-ide-helper
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: fruitcake/laravel-cors
Discovered Package: laravel/passport
Discovered Package: laravel/tinker
Discovered Package: laravel/ui
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Package manifest generated successfully.

What does composer depends --tree jakub-onderka/php-console-color (and same for jakub-onderka/php-console-highlighter) say?

@mfn
composer depends --tree jakub-onderka/php-console-color
PS C:\xampp\htdocs\api-myapp\api> composer depends --tree jakub-onderka/php-console-color
jakub-onderka/php-console-color v0.2
└──jakub-onderka/php-console-highlighter v0.4 (requires jakub-onderka/php-console-color ~0.2)
   ├──nunomaduro/collision v4.1.3 (requires jakub-onderka/php-console-highlighter ^0.4)
   │  └──laravel/laravel dev-master (requires (for development) nunomaduro/collision ^4.1)
   └──psy/psysh v0.9.12 (requires jakub-onderka/php-console-highlighter 0.3.*|0.4.*)
      └──laravel/tinker v2.2.0 (requires psy/psysh ^0.9)
         └──laravel/laravel dev-master (requires laravel/tinker ^2.0)

composer depends --tree  jakub-onderka/php-console-highlighter
PS C:\xampp\htdocs\api-myapp\api> composer depends --tree  jakub-onderka/php-console-highlighter
jakub-onderka/php-console-highlighter v0.4 Highlight PHP code in terminal
├──nunomaduro/collision v4.1.3 (requires jakub-onderka/php-console-highlighter ^0.4)
│  └──laravel/laravel dev-master (requires (for development) nunomaduro/collision ^4.1)
└──psy/psysh v0.9.12 (requires jakub-onderka/php-console-highlighter 0.3.*|0.4.*)
   └──laravel/tinker v2.2.0 (requires psy/psysh ^0.9)
      └──laravel/laravel dev-master (requires laravel/tinker ^2.0)

My composer.json
{
    "name": "laravel/laravel",
    "type": "project",
    "description": "The Laravel Framework.",
    "keywords": [
        "framework",
        "laravel"
    ],
    "license": "MIT",
    "require": {
        "php": "^7.2.5",
        "fideloper/proxy": "^4.2",
        "fruitcake/laravel-cors": "^1.0",
        "guzzlehttp/guzzle": "^6.3",
        "laravel/framework": "^7.0",
        "laravel/passport": "^8.4",
        "laravel/tinker": "^2.0",
        "laravel/ui": "^2.0"
    },
    "require-dev": {
      "barryvdh/laravel-ide-helper": "^2.7",
        "facade/ignition": "^2.0",
        "fzaninotto/faker": "^1.9.1",
        "mockery/mockery": "^1.3.1",
        "nunomaduro/collision": "^4.1",
        "phpunit/phpunit": "^8.5"
    },
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true
    },
    "extra": {
        "laravel": {
            "dont-discover": []
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/"
        },
        "classmap": [
            "database/seeds",
            "database/factories"
        ]
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "scripts": {
        "post-autoload-dump": [
            "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
            "@php artisan package:discover --ansi"
        ],
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "@php artisan key:generate --ansi"
        ]
    }
}

As you can see, neither is related to ide-helper so you're coming to the wrong place asking about the warning!
I guess you should talk to either nunomaduro/collision or psy/psysh which use it!


Better CI Architecture

The current architecture for CI builds is a bit fragile and a lot of fail fast errors happen to jobs that are not tied to each other.
I think I should split up the matrix and single builds (i.e. cron and push builds)

Oops, this is closed by #9


Expose publish context on FastRender export

We ran into an issue using this SSR router for react when trying to publish data from our rest2ddp package. By exposing the publish context we were able to use remote data in connection with fast render!

Add a comment once you do this. Github doesn't notify us.


Use backslash instead of whitespace for hard breaks.

The only formatting change is to add breaks on the weak keywords in
keywords.md.

Alternative solution to #363. Arguably not as pretty when looking at the raw markdown, but possibly less likely to make mistakes.

Soo much whitespace. 💟 Thanks for changing to backslashes and normalizing ending space in other places too.


select2 working is not good with bootstrap popover and modal

display in "webui popover" , it's not good

display in "bootstrap dialog",  Can't input character!!

This is a duplicate of https://github.com/select2/select2/issues/600#issuecomment-102857595.


Update cesiumjs version in bower

Now I see only 1.17. Can you add 1.19?

We do not officially support a bower package and have no role in its maintenance.  I'm not sure who author's such a package, but you should contact them instead.


Are you open to some negative Symbol filters?

I am still perfecting my Services generation template and I just realized that I have some Webhook Controllers that are being converted into Typescript Services because they are getting caught up in my data.Classes | Types.ThatInheritFrom query.
I notice that all of your SymbolFunctions are positive and none are negative. I could use a Symbols.WhereNameSpaceDoesNobBeginWith query for instance, to filter out my Webhooks.
I am willing to do a PR for some negative SymbolFunctions if you would like them as part of NTypewriter.
I don't explicitly need it right now because I ended up doing an if with a continue in my loop.
If I had the negative query, I would have done something like this:
{{for controller in data.Classes | Types.ThatInheritFrom "OurBaseApiController" | Symbols.WhereNamespaceDoesNotStartsWith "path"}}

I am open to the concept of negative filters, but I need to think about how to expose them in the API.

I would also like to see negative symbol filters. Specifically Symbols.ThatDoNotHaveAttribute so that I can exclude certain classes when generating models.


fix(CLI): fix tilde issue with create command

What?

Why?
JIRA: EXT-

How to test? (optional)

Current dependencies on/for this PR:

main

PR #231

PR #233

PR #234   👈

This comment was auto-generated by Graphite.

@eunjae-lee started a stack merge that includes this pull request via Graphite.

@eunjae-lee merged this pull request with Graphite.


Reword README.md (for all workspace projects)

Reword README so people should understand what Bastion does and what is the point of it.

Reword as in rephrase everything/whatever is necessary?

@yavrib I'll let @vertexclique answer that, but for the Getting Started, the example used in bastion::Bastionshould probably be used.

Reword as in rephrase everything/whatever is necessary?

Yes. Main things are:

[ ] the small storylike entry in readme
[ ] rewording what project does (I've rewritten the main doc header, you can take a look – https://github.com/bastion-rs/bastion/blob/master/bastion/src/lib.rs#L6)
[ ] Writing README for bastion-executor and lightproc.
[ ] In main README using the example used in bastion::Bastion should be used. (https://github.com/bastion-rs/bastion/blob/master/bastion/src/bastion.rs#L15)

This is done. Let's close this one.


Dropdown null errors on first time added

When adding a component that has a dropdown of a nullable type (tested with strings) - there are null errors until the first successful serialization (with the default value)
Fixed this in a fork, will submit a PR soon

I merged the PR 08efcae01bef12dd3f1740de6066f72718525ae5


rfc: external library for command parsing

Introduction
ArgumentTokenizer is poorly implemented and using ArgumentMultimap results in Optional and try/catch hell, especially when considering optional flags.
ArgumentTokenizer also does not support positional arguments, which means otherwise trivial commands such as that to add a task requires redundant prefixes in add -m -c <module code> -n <name> -cr <mcs>.
I created CommandParser in #62 to standardize validation for required arguments, but adding support for aliasing (see #72) as well as the positional arguments would need a full parser implementation, i.e. non-trivial.
Proposal
I propose that we request for JCommander in the CS2103T forum and ditch the stopgap CommandParser and ArgumentTokenizer altogether.
Alternatively, Apache Commons CLI has already been approved (here), but JCommander has a more modern interface with annotations and built-in validation (!!).
Thoughts?

Let's discuss this after tutorial today

Requested in CS2103T forum as decided.

Closed as approved.


feat: return HTTP code 422 if timeout due to throttling

Description
Instead of return HTTP 500, return HTTP code 422 if check request timeouts due to throttling
References
https://github.com/openfga/api/pull/151
Note

[x] DO NOT MERGE until https://github.com/openfga/api/pull/151 is merged (and go.sum/go.mod use the official reference) -- Merged

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev] (https://github.com/openfga/openfga.dev) -- changes to https://github.com/openfga/api/pull/151 will generate new swagger file and loaded to openfga.dev
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

@adriantam we have a bug with the config.

If you set --request-timeout=20ms and leave all other configs at their defaults, then the server starts up just fine.

If you set --http-upstream-timeout=20ms and leave all other configs at their defaults, then you get an error because http-upstream-timeout has to be greater than listObjects-deadline.

If the resolved timeout value between the --request-timeout and --http-upstream-timeout is less than listObjects-deadline then you should get an error. The ListObjects deadline should always be shorter than the timeout of the request.


Fixing issue 97 by updating autoscale images

@selvasingh Please kindly review this PR to fix Issue 97.


Alert timeouts: not imlemented yet

Implement alert timeouts

Implemented in last commit. Pause implementation follows next.


book circulation table (#235)

this PR adds a "circulation" tab to the book detail page, with a table similar to the other activity tables for members.
the implementation doesn't quite match the design for mobile; I fought with it for a couple hours but wasn't able to achieve this split-column look with s. it might be possible using grid, but I'm not sure how.

testing out some prefetching strategies - I went for something based on the strategy in BorrowingActivities:
        return super().get_queryset() \
                      .filter(work__slug=self.kwargs['slug']) \
                      .select_related('borrow', 'purchase', 'account', 'edition') \
                      .prefetch_related('account__persons')

4479ms with no prefetching at all
2953ms with account, edition, account__persons
2231ms with borrow and purchase also (shown above)
lmk if there's a better way to approach this.

@thatbudakguy seems like the query improvement is substantial, and looks like what I would expect. The only other thing I can think of would be to look at the queries in django debug toolbar and see if there's anything else going on you might be able to improve — but this looks like you're pulling everything you're using in the template.

for positioning, none of the other layouts use grid - just flex, with some weird margin trickery. I tried the same technique used on borrowing activities, which absolute-positions content on the right side, but that doesn't work for long edition titles:

the main issue is that the layout implies columns or other structure that wraps parts of the row, but
 aren't allowed inside
, so we can't use them to break up the s into groups that can then be sized accordingly.
it gets even more complicated because we have to give the appearance of collapsing start and end dates into one dash-separated field, but that field usually needs to take a whole line even though either one of its "parts" could be empty.
unfortunately, in investigating this I found a bug in production showing what happens if one of the date fields is empty for membership activities:

i think we may need to compromise on some of these designs - the need to represent them semantically as a table make it quite difficult to achieve other complex, non-tabular representations.

about the sorting - is this actually happening because, for that particular item, there's a borrow with no end date? would that cause the purchase to sort above it?
my expectation would be that the sort would be stable - so, if you sorted by event type, borrows would be first, and then sorted by date, the secondary order would be preserved. but that doesn't seem to happen.
i wonder if we need to treat purchases as not having an end date for the purposes of sorting - and maybe also display? I can see it being confusing that purchases have both dates, but some borrows don't.

@thatbudakguy wow, thanks for explaining the problems with the mobile layout. (I thought I started with flex with order and you shifted to grid! I must be misremembering...)
I'd like to tinker with it a briefly myself - do you mind? Is there a way to share what you've done or would it be better if I just start from the version you've pushed?
That said: I think we should use your single column layout so we can move forward with testing this feature. I'm looking at the design in Zeplin, and the mobile card isn't showing the full end date — and including it obviously takes up more space.
Could you document the production bug you found? I think we already have another bug on the mobile version we need to address, maybe they can be handled at the same time.
As for the sorting — I don't think the missing end date should impact the sorting, but I think this is also kind of an edge case. The only solution I thought of was to add a suffix to purchase dates in case there is a borrow with the same date, but I'm not sure that's a good solution. I think we should ignore this for now.

please do tinker! if there's a solution here I'd love to find it. I think the easiest thing is probably just to start on this branch.
opened a new issue for the bug; agree about the sorting.


New entity sync to Alexa broken in HA cloud 0.104.0b2

Home Assistant release with the issue:

0.104.0b2
Last working Home Assistant release (if known):
0.103.6
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io
Integration:

cloud:
Description of problem:
A new entity/scene does not sync to Alexa when picked in cloud integration and syncing manually. Went back to 0.103.6 and the same worked immediately.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:

Anything in your logs ?

Nothing unfortunately. I can try debug if that might help.

I haven't pulled this release to test it locally yet; but I looked though the recent commits for the Alexa integration and couldn't determine any reason to cause this.
Just to rule out some common issues with scene discovery:

Do you have more than 12 scenes? If so you can go to scenes category in the mobile app, and click Discover Scenes to load addition scenes filters during general discovery.
Did you override the description, the word scene is required in the description.

I have give scenes and no overrides on them. Some overrides on switches to the light domain.
I ran into this when I renamed a scene and found it didn't sync to alexa.
On 0.103.6 when I retried it I immediately got a push message on the alexa app that new devices/scenes are available.

These are the Alexa related PRs in 104:

sort imports according to PEP8 for alexa #29618
Proactively report Alexa Endpoint Health properties #29736
Implement Alexa.EventDetectionSensor for Alexa #28276
Refactor Alexa capabilityResources object into class, Implement Alexa semantics object #29917
Explicitly include Alexa interface for image_processing entities. #30101
Add support for input_number entities in Alexa integration #30139
Implement EqualizerController in Alexa for media_player #30159
Migrate alexa tests from coroutine to async/await #30332
Implement supported locales for Alexa capabilities #30285

There has been no changes to class SceneCapabilities(AlexaEntity). The only change to AlexaSceneController is the addition of the locales in https://github.com/home-assistant/home-assistant/pull/30285. I have verified those with the docs and they match up.

@olbjan can you set the cloud integration to debug and sync Alexa entities and grab the scene entry for both 103 and 104?
logger:
  default: info
  logs:
    homeassistant.components.cloud: debug
    homeassistant.components.cloud.iot: debug

@balloob I did what you asked, only I tried syncing a new entity instead of scene. As expected, no new entity synced to alexa in 0.104.0b3 but it did sync in 0.103.6.
Unfortunately there was no log entry whatsoever from homeassistant.components.cloud in either 0.104.0b3 or 0.103.6

@balloob I pulled down 0.104.0b3. Tested discovery with existing entities and new scenes via yaml, results as expected.
I found an issue attempting to add new scenes via the front end configuration. I was not able to save a new scene. Opened new issue for that with details: #30737
My Environment:
Hass.io 0.104.0b3
Alexa configuration through custom skill (haaska)
All configuration done via YAML.
smart_home:
#  locale: en-US
  endpoint: https://api.amazonalexa.com/v3/events
  client_id: !secret alexa_client_id
  client_secret: !secret alexa_client_secret

Note: I did not have the locale enabled, allowing it to default to en-US for these steps.
Steps Taken

Tested discovery of existing entities.

Forced Discovery from Alexa app.
Every entity shown in discovery as expected.

Tested Discovery with new scene.

added New scene via YAML.
Uploaded.
Reloaded scenes via configuration UI (no restart).
New scene discovered as expected.

Test discovery after re-start.

Restarted HA.
Every entity shown in discovery as expected, including new scene.

@ochlocracy is it possible we're talking about different things?
I'm just using the nabu casa cloud setting for syncing entities to Alexa.

@olbjan I'm trying to help rule out where to look.
Release 0.104 has several changes to Alexa I contributed PRs for. I'm just doing my due diligence to rule out if the issue is within the Alexa platform.

@balloob I think the JSON formatting coming from the cloud integration is the problem. There are line breaks throughout primarily in the description property in between "Home" and  "Assistant". vs. the minified version that comes from the Alexa component.
Trying to track down the root cause now...
2020-01-13 21:10:26 DEBUG (MainThread) [hass_nabucasa.iot] Received message:
{'handler': 'alexa',
 'msgid': 'REDACTED',
 'payload': {'directive': {'header': {'messageId': 'REDACTED',
                                      'name': 'Discover',
                                      'namespace': 'Alexa.Discovery',
                                      'payloadVersion': '3'},
                           'payload': {'scope': {'token': 'REDATED',
                                                 'type': 'BearerToken'}}}}}

2020-01-13 21:10:26 DEBUG (MainThread) [hass_nabucasa.iot] Publishing message:
{'msgid': 'REDACTED',
 'payload': {'event': {'header': {'messageId': 'REDACTED',
                                  'name': 'Discover.Response',
                                  'namespace': 'Alexa.Discovery',
                                  'payloadVersion': '3'},
                       'payload': {'endpoints': [{'capabilities': [],
                                                  'cookie': {},
                                                  'description': 'scene.turn_down_service '
                                                                 'via Home '
                                                                 'Assistant',
                                                  'displayCategories': ['SCENE_TRIGGER'],
                                                  'endpointId': 'scene#turn_down_service',
                                                  'friendlyName': 'Turn Down '
                                                                  'Service',
                                                  'manufacturerName': 'Home '
                                                                      'Assistant'},
                                                 {'capabilities': [],
                                                  'cookie': {},
                                                  'description': 'scene.sexy_time '
                                                                 'via Home '
                                                                 'Assistant',
                                                  'displayCategories': ['SCENE_TRIGGER'],
                                                  'endpointId': 'scene#sexy_time',
                                                  'friendlyName': 'Sexy Time',
                                                  'manufacturerName': 'Home '
                                                                      'Assistant'},
                                                 {'capabilities': [],
                                                  'cookie': {},
                                                  'description': 'scene.dinner_time '
                                                                 'via Home '
                                                                 'Assistant',
                                                  'displayCategories': ['SCENE_TRIGGER'],
                                                  'endpointId': 'scene#dinner_time',
                                                  'friendlyName': 'Dinner Time',
                                                  'manufacturerName': 'Home '
                                                                      'Assistant'},
                                                 {'capabilities': [],
                                                  'cookie': {},
                                                  'description': 'scene.kitchen_dishes '
                                                                 'via Home '
                                                                 'Assistant',
                                                  'displayCategories': ['SCENE_TRIGGER'],
                                                  'endpointId': 'scene#kitchen_dishes',
                                                  'friendlyName': 'Kitchen '
                                                                  'Dishes',
                                                  'manufacturerName': 'Home '
                                                                      'Assistant'},
                                                 {'capabilities': [],
                                                  'cookie': {},
                                                  'description': 'scene.foo '
                                                                 'via Home '
                                                                 'Assistant',
                                                  'displayCategories': ['SCENE_TRIGGER'],
                                                  'endpointId': 'scene#foo',
                                                  'friendlyName': 'foo',
                                                  'manufacturerName': 'Home '
                                                                      'Assistant'},
                                                 {'capabilities': [],
                                                  'cookie': {},
                                                  'description': 'switch.wled_dc4f227e73cd_nightlight '
                                                                 'via Home '
                                                                 'Assistant',
                                                  'displayCategories': ['SWITCH'],
                                                  'endpointId': 'switch#wled_dc4f227e73cd_nightlight',
                                                  'friendlyName': 'wled-dc4f227e73cd '
                                                                  'Nightlight',
                                                  'manufacturerName': 'Home '
                                                                      'Assistant'}]}}}}

Doh 🤦♂ PR incoming…


L3V8 reproduction, initial attempt

This Pull Request is related to issue #210.
This pull request is not ready to review yet.
Code is not tested and it is still in progress.
Changes proposed in this Pull Request:

Implementation of preprocessing steps according to the project description

Checklist:

[x] Descriptive title
[x] Targets the main branch
[x] Changes are functional
[x] My code is explicit and comments were added to it
[ ] Code conforms with PEP8
[ ] Tests were added for the changes and they complete successfully
[ ] Existing tests were updated (if needed) and they complete successfully
[ ] Documentation was updated

Implemented and tested the preprocessing part.


Stylus Version

Don't know if this possible.

There is also this: https://github.com/mojotech/sass2stylus


Build JEPMap using JIRA Rest API

OpenJDK issue tracker is a JIRA instance and offers a rest API to  search issues. We can filter on issueType = JEP and query the all  JEPs to build the JEPMap instead of parsing OpenJDK html pages.
TODO

Project IDs are currently not handled. It is possible to get the project ID from discussion field. But the other way of parsing the JEP description may not be useful with the API because I cheked a couple of JEPs and links were missing. I'll need to look further to find an example JEP which is mapped that way and see if its possible to retrieve the info from rest API.

Thanks for submitting, I'll review properly asap :)


parse error by constraints with check

/home/wlodek/.local/bin/pg_diagram --format svg -o lolo.svg lolo.sql
Could not parse statement:
CREATE TABLE public."tp_timeentry" (
id integer NOT NULL,
line_no integer,
date date NOT NULL,
worked double precision NOT NULL,
billable double precision NOT NULL,
comment text NOT NULL,
sub_account_id integer NOT NULL,
time_file_id integer NOT NULL,
CONSTRAINT "tp_timeentry_line_no_check" CHECK ((line_no >= 0))
);
I opened already following issue by sqlparse (s.: https://github.com/andialbrecht/sqlparse/issues/729 ) but the author proved, that it is not an error in psqlparse.
By the way: thanks for pg_diagram!!!!

ran into this as well, I wonder if there is a workaround

Same problem. Python 3.11

Same problem

Oh sorry, I wasn't following this project. It's probably too late but I fixed the bug with parsing


fix path argument must be of type string error

This PR contains a:

[X] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case

Intermittently the call to this.outputs.get(file); is undefined.  Checking for the presence of this file and waiting if its not there fixes the problem.
10 12 2020 18:37:17.496:ERROR [karma-server]: UnhandledRejection
infrastructure_error TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.join (path.js:1147:7)
    at Plugin.<anonymous> (/Users/me/my-app/node_modules/karma-webpack/dist/karma-webpack.js:318:70)
    at Plugin.readFile (/Users/me/my-app/node_modules/karma-webpack/dist/karma-webpack.js:334:5)
    at /Users/me/my-app/node_modules/karma-webpack/dist/karma-webpack.js:353:19
    at executeProcessor (/Users/me/my-app/node_modules/karma/lib/preprocessor.js:28:11)
    at runProcessors (/Users/me/my-app/node_modules/karma/lib/preprocessor.js:41:23)
    at /Users/me/my-app/node_modules/karma/lib/preprocessor.js:144:9
    at module.exports (/Users/me/my-app/node_modules/isbinaryfile/index.js:29:12)
    at readFileCallback (/Users/me/my-app/node_modules/karma/lib/preprocessor.js:116:7)
    at /Users/me/my-app/node_modules/graceful-fs/graceful-fs.js:90:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
From previous event:
    at Promise.map (/Users/me/my-app/node_modules/karma/lib/file-list.js:89:51)
From previous event:
    at Promise.map (/Users/me/my-app/node_modules/karma/lib/file-list.js:89:25)
    at runCallback (timers.js:705:18)
    at tryOnImmediate (timers.js:676:5)
    at processImmediate (timers.js:658:5)
From previous event:
    at FileList._refresh (/Users/me/my-app/node_modules/karma/lib/file-list.js:64:8)
    at FileList.refresh (/Users/me/my-app/node_modules/karma/lib/file-list.js:158:29)
    at Server.refreshFiles (/Users/me/my-app/node_modules/karma/lib/server.js:146:44)
    at Plugin.notifyKarmaAboutChanges (/Users/me/my-app/node_modules/karma-webpack/dist/karma-webpack.js:250:16)
    at Plugin.done (/Users/me/my-app/node_modules/karma-webpack/dist/karma-webpack.js:193:12)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/me/my-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)
    at AsyncSeriesHook.lazyCompileHook (/Users/me/my-app/node_modules/tapable/lib/Hook.js:154:20)
    at Watching._done (/Users/me/my-app/node_modules/webpack/lib/Watching.js:98:28)
    at compiler.emitRecords.err (/Users/me/my-app/node_modules/webpack/lib/Watching.js:73:19)
    at Compiler.emitRecords (/Users/me/my-app/node_modules/webpack/lib/Compiler.js:499:39)
    at compiler.emitAssets.err (/Users/me/my-app/node_modules/webpack/lib/Watching.js:54:20)
    at hooks.afterEmit.callAsync.err (/Users/me/my-app/node_modules/webpack/lib/Compiler.js:485:14)
    at _promise0.then._result0 (eval at create (/Users/me/my-app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:13:1)

Breaking Changes

Additional Info

@patrick99e99 can you make this pull request against the next branch?

Is this still something you're interested in?

Is this still something you're interested in?

The cases where this happens should be handled in v5, thanks for your contribution though!


Rename "dnu bundle" to "dnu publish"

https://github.com/aspnet/dnx/issues/1474
@muratg  @Praburaj @davidfowl

:shipit:


Update MLC and fix changelog links

Codecov Report

Merging #288 (1aa9c42) into master (e919d07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   95.30%   95.30%
=======================================
  Files          12       12
  Lines         724      724
=======================================
  Hits          690      690
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e919d07...1aa9c42. Read the comment docs.


Adding SearchClientBuilderExtensions

Fixes #10848

Should also add something to the CHANGELOG.md.

I updated the changelog and put the release date in there as well for good measure.

(Merging to keep things moving, but happy to continue the discussion about SearchIndexerClient and add that as separate PR if we decide to.)


rejection in add() and update() has two parameters

I'm wondering why add() and update() reject onerror with 2 parameters. Is there a reason for this?
https://github.com/aaronpowell/db.js/blob/master/src/db.js#L111
https://github.com/aaronpowell/db.js/blob/master/src/db.js#L155
I would expect it to reject with:
reject(e) instead of reject(records, e)

This is an error, it should be only rejecting with a single argument to be compliant with the ES6 promises.

same with the 2 onabort handlers
Would like a PR for this?

Yep! Everywhere should only have a single argument (resolve and reject). I just haven’t had time to address it yet
From: Martijn van de Rijdt<EMAIL_ADDRESS>Sent: Friday, 23 January 2015 7:26 AM
To: aaronpowell/db.js
Cc: Aaron Powell
Subject: Re: [db.js] rejection in add() and update() has two parameters (#97)
same with the 2 onabort handlers
Would like a PR for this?
—
Reply to this email directly or view it on GitHubhttps://github.com/aaronpowell/db.js/issues/97#issuecomment-71092106.

Merged and on npm + bower as v0.10.0


escapeshellarg(): Escaped argument exceeds the allowed length of 0 bytes

Hello,
i did get the "escapeshellarg(): Escaped argument exceeds the allowed length of 0 bytes" php- error in swiftmailer/swiftmailer/lib/classes/Swift/Transport/MailTransport.php. I do not know what to do about it ...

Okay, my problem was that "downgraded" my PHP version form 5.6 to 5.4 in my .htaccess and apparently there is a bug in 5.4 with the escapeshellarg() function.


Eve Quick Start Tutorial BUG

On tutorial page in the last example, where you handling form submit, form fields does not reset.

Duplicate of #486, that I opened 2 days ago. Same problem than you. Could you close this issue and follow the other ?

Yea, sure.


The fate of /libp2p-webrtc-direct

@diasdavid IIRC it doesn't work, so should we remove it?

It works™, just not how we wanted it to. It is still a WebRTC transport with 0 signalling server.

Cool then! :+1: Needs docs btw :)


Comma separated list of primary keys not working for field comparison.

data-validation validate row
-sc BQ_CONN
-tc BQ_CONN
-tbls $PROJECT_ID.$DATASET_ID.Employees=$PROJECT_ID.$DATASET_ID.Employees1
--primary-keys 'employee_id'
-comp-fields first_name,last_name,hire_date,department
The above command works. But when I pass comma separated list in primary_keys.
data-validation validate row
-sc BQ_CONN
-tc BQ_CONN
-tbls $PROJECT_ID.$DATASET_ID.Employees=$PROJECT_ID.$DATASET_ID.Employees1
--primary-keys 'employee_id,first_name,last_name,hire_date,department'
-comp-fields first_name,last_name,hire_date,department
Getting this error : raise IntegrityError(f'Duplicate column name(s): {duplicate_names}')
ibis.common.exceptions.IntegrityError: Duplicate column name(s): ['first_name', 'last_name', 'hire_date', 'department']

This is happening because your comparison fields are the same as your primary keys. We treat primary keys as comparison fields already, so this results in a query with duplicate column names. (See the query with the --verbose option)
The fix for this is to use a config file (-c config.yaml) and edit the PK values to have an alias to avoid duplicate column names like so:
primary_keys:
  - cast: null
    field_alias: first_name_pk
    source_column: first_name
    target_column: first_name

This is happening because your comparison fields are the same as your primary keys. We treat primary keys as comparison fields already, so this results in a query with duplicate column names. (See the query with the --verbose option)
The fix for this is to use a config file (-c config.yaml) and edit the PK values to have an alias to avoid duplicate column names like so:
primary_keys:
  - cast: null
    field_alias: first_name_pk
    source_column: first_name
    target_column: first_name

So if have to use multiple columns as primary keys, should config file be like this ?
primary_keys:

cast: null
field_alias: first_name_pk
source_column: first_name
target_column: first_name
cast: null
field_alias: last_name_pk
source_column: last_name
target_column: last_name
cast: null
field_alias: hire_date_pk
source_column: hire_date
target_column: hire_date

and so on...

So if have to use multiple columns as primary keys, should config file be like this ?
primary_keys:
cast: null
field_alias: first_name_pk
source_column: first_name
target_column: first_name
cast: null
field_alias: last_name_pk
source_column: last_name
target_column: last_name
cast: null
field_alias: hire_date_pk
source_column: hire_date
target_column: hire_date
and so on...

This isn't due to multiple PKs - it's because your PK columns overlap with your comparison field columns. For example,
'first_name,last_name,hire_date,department' are both PKs and comparison-fields.
If you have an overlap, you need to provide an alias for your PKs like the config you suggested above.

Hi @mayanksroy01! Were you able to solve your problem?
Please let us know so we can either further assess it or close the issue, thank you!

Yes, it was resolved. Thank You.

Thanks for the update!

Hi @helensilva14
If any column in the comma separated list provided in primary keys is null, will DVT still produce correct results.
I'm getting some incorrect results for my use case when one column is null.


I believe this is supposed to be Flow not Source

https://github.com/modelint/dataflow-semantics/blob/ace067e5042e81b2157e59353d1a0c6882ce7e4f/graph-subsystem/graph.xmm#L179

Models are consistent now


Add VoyageDB to contributor list

Adds VoyageDB for their multiple contributions: https://github.com/R2Northstar/NorthstarMods/commits?author=DBmaoha

@DBmaoha thoughts? Just to double check that you're fine with getting added from your side ^^

Thanks very much! also really appriciate reviewing my pull requests. I'm making a pr about bounty hunt fix, will try to do better formatting by myself


added Rank observation

Discussed 2/4/2021 Examples Task Force Call
Gay Dolin/John D'Amore - 11/0/0


Drop OpenAPI from Fulcio

Signed-off-by: Matt Moore<EMAIL_ADDRESS>Release Note
Fulcio no longer uses OpenAPI.
The generated client in ./pkg/client has been replaced with an artisan hand-crafted client in ./pkg/api.NewClient

This needs fairly careful testing and scrutiny before it goes in.  This drops a number of things on the floor, some of which we clearly need a replacement for including:

pkg/client: Used by cosign, so kinda important.  We probably don't need swagger for this, but we need something.
Discovery docs: I think the API used to serve this, but now it doesn't.  We should confirm if this is a problem, and probably add test coverage if we want it.

I like the whole "dropping 3500 LoC outside of vendor/" aspect of this change, though. 🤣

Alright, I think that this is relatively complete, assuming we're cool with ditching the discovery stuff.  I staged the update to cosign to consume the new client library here: https://github.com/sigstore/cosign/pull/1126
I'm not sure what else might be relying on the existing fulcio client logic, so any feedback would be appreciated.

TODO: incorporate: https://github.com/sigstore/fulcio/pull/264

Fixed the two suggestions, thanks!

I'll start dusting off my changes to import this into sigstore/cosign


Use JDK 17 for sonar check

Description
This PR is fixing this warning.

coverage: 48.052%. remained the same when pulling 0fbea8658bd4fbef0a332b2a8d3004aff82f6c9d on HTHou-patch-2 into 9fb01f5674edc3bb1a73460c281b802670627dca on master.


Cleanup DrawBatch.Append/JIT Logic

Summary
The current Append logic for draw batches is a bit of a mess, partially for compatibility reasons, partially because there hasn't been a lot of engineering in there for a while. Clean it up, refactor and improve performance where possible.
Analysis

Make sure appending two batches does not put the resulting one into the Large Object Heap.
Also, consider introducing a proper size limit for batches, so we don't get the overhead of copying large arrays.
Check if an array resize needs to occur for merging two batches. If not, the merge is essentially free and can be done regardless of array size considerations.
Is there a reasonable way to streamline append logic for better performance, especially AppendJIT?

Might also do an overall refactoring of the IDrawBatch / DrawBatch<T> pair with an eye on potential performance improvements. Keep the interface for extensibility reasons, but avoid virtual calls and the like as much as possible while dealing with only the internal batch type.

This might be easier to do after issue #487 is finished, since that will likely involve moving batching logic into its own class.

After findings of heavy memory allocation in issue #552 mainly due to dynamic batching, reducing or preventing allocations as part of gathering vertex data / batches should be a priority.
One way to get around this would be to transform AddVertices calls into a form that "rents" a segment from a pre-existing internal array of the appropriate type, rather than registering and merging one that the renderer allocated. Ownership of dynamic vertex data would then be in IDrawDevice, as opposed to ICmpRenderer.

It will be very important to have fast retrieval of a segment of the appropriate type. Potentially have a compile-time mapping from T to an index for a lookup or similar.
Ideally, we'd use Span<T>, but this will have to wait until Duality v4.0, as this is way too experimental right now to make it into the stable main release soon. Come up with something custom or use ArraySegment<T>, to be considered.
This will probably make CanvasBuffer obsolete.

Rough draft on how this could be approached, probably subject to change:

Create a DynamicVertexStore class that encapsulates one array per vertex type and provides "renting" and retrieval functionality. Could probably use some tests for this.
Transform DrawBatch<T> to no longer store an array locally, but instead store the rented part of the DynamicVertexStore.
Transform the rendering system so that all contents of the dynamic vertex store are uploaded at once, prior to rendering, one internal vertex buffer per vertex type. DrawBatch<T> upload functionality will be empty. Rendering will be vertex setup and GL.DrawArrays, but double-check whether the vertex setup is really necessary for rendering, or whether that's somehow stored in the VBO.
Consider removing upload functionality from IDrawBatch altogether, remove then-obsolete IVertexUploader as well.

Up to this point, most of the public drawing API can still stay the same, with AddVertices still receiving an array and just copying it over to a rented region of the DynamicVertexStore. Going forward, an update to the draw device API to leverage the new data flow would be required, introducing changes all over the codebase.

Transform IDrawDevice into a form where AddVertices doesn't accept vertex data anymore, but instead "rents" a segment of some internal array.
Update all the points in code where this becomes relevant.
Remove the now-obsolete CanvasBuffer.

After this change, there should be next to no allocations anymore in the rendering cycle and way less copying due to dynamic batching.
One thing that still needs to be considered is how to handle very large, mostly static vertex arrays where a re-generate and re-upload every frame would be wasteful and unnecessary. This use case is not currently implemented and can be considered a new feature, but it would be neat if that option existed. Probably go into more detail as part of issue #487.

Progress

Created the develop-3.0-vertexgather branch to work on this.
Started experimenting and implementing parts of this change. Previous benchmark sample report, for later reference: BenchmarkTestReport.txt
Implemented a VertexSegment<T> struct that will be used for "renting" parts of a shared vertex array. Investigated how to achieve maximum performance when accessing it and optimized for inline friendliness, low (JIT-)compiled instruction counts and low complexity at the cost of safety. Documented this.
Found that type erasure will be an implementation issue to be solved, since the DynamicVertexStore would end up with an object[], each being a different generic RawList<T> with no way to get back to the actual types. This is not a problem when gathering vertices, as each renderer call specifies the type as a generic parameter, but it will be a problem when uploading vertices later. There will likely be the need for a generic-class-and-non-generic-interface combo.
To simplify things a bit, transformed IVertexUploader API from a generic one requiring the vertex type into a non-generic one that accepts an IntPtr, as type information beyond what VertexDeclaration offers isn't actually needed for this.

Immediate ToDo

Create a DynamicVertexStore class that encapsulates one array per vertex type and provides "renting" and retrieval functionality. Could probably use some tests for this.
Transform DrawBatch<T> to no longer store an array locally, but instead store the rented part of the DynamicVertexStore.
Transform the rendering system so that all contents of the dynamic vertex store are uploaded at once, prior to rendering, one internal vertex buffer per vertex type. DrawBatch<T> upload functionality will be empty. Rendering will be vertex setup and GL.DrawArrays, but double-check whether the vertex setup is really necessary for rendering, or whether that's somehow stored in the VBO.
Consider removing upload functionality from IDrawBatch altogether, remove then-obsolete IVertexUploader as well.
Transform IDrawDevice into a form where AddVertices doesn't accept vertex data anymore, but instead "rents" a segment of some internal array.
Update all the points in code where this becomes relevant.
Remove the now-obsolete CanvasBuffer.

Progress

Introduced VertexBatchStore, VertexBatch and IVertexBatch types, as well as a first implementation.
Wrote tests for the above types basic functionality.
Introduced PinnedArrayHandle struct as a general helper for safely pinning and unpinning managed arrays for direct IntPtr data access.
Renamed VertexSegment to VertexSlice.
Added debugger display rules for VertexSlice.
Wrote XML docs for VertexDeclaration, VertexElement, VertexBatchStore, VertexBatch, IVertexBatch and PinnedArrayHandle.

Immediate ToDo

Transform DrawBatch<T> and DrawDevice so that incoming vertices are stored in a VertexBatchStore in the device, and each batch only has a token referring to vertex declaration, index and count.
Upload all vertices in the VertexBatchStore at once, prior to rendering.
Removing upload functionality from IDrawBatch altogether.
Remove IVertexUploader and replace it with regular graphics backend API.
Transform IDrawDevice into a form where AddVertices doesn't accept vertex data anymore, but instead "rents" a segment of some internal array.
Update all the points in code where this becomes relevant.
Remove the now-obsolete CanvasBuffer.

Progress

Transformed DrawBatch<T> and DrawDevice so that incoming vertices are stored in a VertexBatchStore in the device, and each batch only has a token referring to vertex declaration, index and count.
Now uploading all vertices at once, rather then per-batch.
Removed upload functionality from IDrawBatch altogether.
Removed IVertexUploader, as the graphics backend can now do this itself using the VertexBatchStore it receives in BeginRendering.
Prototyped a transformation of the IDrawDevice API so that AddVertices provides a vertex slice instead of accepting a vertex array, but found it to be unsatisfying overall.

The API felt a lot harder to use, more confusing. AddVertices calls required more parameters and line length.
Code defining vertices was a lot less readable. No direct array index access with a slice, can't group lines by vertex attribute anymore.
With the new API, there is no way for someone giving out a vertex slice to perform an operation on the vertices since they're not defined yet. This is especially painful for picking overrides in DrawDevice.
Performance gains were negligible (< 0.2 ms)

Reverted the draw device API prototype, a patch file containing its previous WiP state is available here, ideally apply at this commit.
New benchmark results are available here: BenchmarkTestReport.txt

Performance is about the same as before.
Allocations and GC pressure were greatly reduced.

Immediate ToDo

Review the changes of the develop-3.0-vertexgather-wip branch and do some polishing when and where necessary.
Do some more profiling to see where the new allocation and performance hotpaths are.
Merge develop-3.0-vertexgather-wip back to develop-3.0

Progress

Fixed the bug that was reported by DeathKiller, which turned out to be the same bug as the one that produced glitchy hover highlights in the editor.

Immediate ToDo

Check the major rendering-related sample projects to make sure they're still working as expected.
Review the changes of the develop-3.0-vertexgather-wip branch and do some polishing when and where necessary.
Do some more profiling to see where the new allocation and performance hotpaths are.
Merge develop-3.0-vertexgather-wip back to develop-3.0

Progress

Fixed the bug that was found in the DualStickSpaceShooter sample. Turned out to be a missing check that sometimes led to JIT batching even though the vertices were disjoint in the internal vertex store.

Immediate ToDo

Check the major rendering-related sample projects to make sure they're still working as expected.
Do some more profiling to see where the new allocation and performance hotpaths are.
Investigate whether batching can be streamlined a bit more. Feels like there's still a lot of overhead right now.
Review the changes of the develop-3.0-vertexgather-wip branch and do some polishing when and where necessary.
Merge develop-3.0-vertexgather-wip back to develop-3.0

Progress

Removed IDrawBatch abstraction, as there's nothing useful to abstract right now. The graphics backend now accepts a list of DrawBatch instances directly.
A DrawBatch can now express rendering multiple disjoint slices of a vertex buffer as long as there is no state change.
Rewrote DrawDevice vertex gathering code to only generate DrawBatch instances on the very last step and use private arrays-of-structs before that for reduced allocation count and improved efficiency.
Simplified IDrawDevice API and moved the previous overloads to extension methods.
New benchmark report is available here: BenchmarkTestReport.txt

Slight performance improvements.
Cut worst-case allocations / GCs in half again.

Immediate ToDo

Do some more profiling to see where the new allocation and performance hotpaths are.
Review the changes of the develop-3.0-vertexgather-wip branch and do some polishing when and where necessary.
Merge develop-3.0-vertexgather-wip back to develop-3.0

Progress

Introduced some additional ReflectionHelper methods to allow quickly determining whether a type can contain any references.
Optimized RawList<T> clear and remove behavior to not actually clear the internal arrays now off-limits sections unless it's a reference type.
Introduced a simple RawListPool<T> class for local, single-owner pooling.
Re-implemented CanvasBuffer as a thin wrapper around RawListPool<VertexC1P3T2>.
DrawDevice now pools the vertex range lists that are used in batch generation internally to not allocate all that memory every frame.
New benchmark results are available here: BenchmarkTestReport.txt

About the same performance as before. Seems slightly faster, but not significantly.
Reduced allocations / GC pressure in worst-case scenario to about 25%

Immediate ToDo

Consider introducing IDrawDevice API that provides access to the rented vertex slice directly and avoid the extra copy, rather than accepting a T[] - only this time as something optional, not "the" way to go.
Conclude the issue by doing some more testing on samples.
Briefly review the changes of the develop-3.0-vertexgather-wip branch and do some polishing when and where necessary.
Merge develop-3.0-vertexgather-wip back to develop-3.0

Progress

Reviewed potential new slice-based IDrawDevice API and profiled the multi-sprite renderer case with no significant performance improvements. Discarding the idea for now.
Merged develop-3.0-vertexgather-wip back to develop-3.0


Merge release1.15 into master

Sync release-1.15 into master
Sync with en version

This change had checked on release-1.15 version. For keeping the master is always use newest document. Please let me merge them into master

/lgtm
/approve
thanks!

/hold

/hold cancel


Filter quests for which you meet the requirements

Is your feature request related to a problem? Please describe.
I would like to complete all of the quests for which I already meet the requirements. Finding which quests I can do involves looking up each quest on  the wiki and tediously cross-checking with my skill levels.
Describe the solution you'd like
I would like to be able to filter the quest list in Runelite to show the quests which I have not completed and for which I have all of the requirements.
Describe alternatives you've considered
No better solution comes to mind.
Additional context
This was previously requested in #5779 and #6466 which where closed of duplicates of #1905. #1905 added filters for the quest list, but only based on quest status, not whether the requirements are met.

Duplicate of #10475


Add beta and sample to the list

Good candidates for suggestions.
Beta: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/p/preview
Sample: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/s/sample-vs-preview

Thanks -- this looks good.
(By v1.0.0, I'd like to remove Vocab.yml altogether in favor of the ideas I outlined in #15 but we're still pretty far from that.)


Redis::CommandError: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.

Hi, we're using this gem in combination with hiredis v0.6.0. We've imported about 100k items previously using add_to_matrix (no bang), and now we're trying to process the entire dataset. With the lua processor, the code runs, then after a minute or so crashes:
[7] pry(main)> recommender.process!
Redis::CommandError: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.

Now interestingly, I tried chunking the processing, and it still seems to happen:
[7] pry(main)> recommender.all_items.each_slice(100) {|r| recommender.process_items!(*r); puts "chunk!" }
chunk!
chunk!
Redis::CommandError: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.

Possibly related to some sort of a timeout in the redis client?

@chanks any ideas here?

A timeout sounds like a likely culprit. It looks like the default Redis client's timeout is five seconds and can be overridden with an option, e.g. Redis.new timeout: 30.
Does that fix your issue? If so, we'll probably want to add it to the docs about the lua processing strategy.

Yeah, that seems to have fixed it! Due to the blocking nature, we're probably going to go with union anyhow. I'll close the issue now.

:+1:


Transparent top and bottom bars

Basically a glassy effect. User-toggled.

This will be complicated with the navigation bar, as you need edgesForExtendedLayout to not be .none, causing offset issues everywhere


Simplify appending to env var JAVACMD_OPTIONS

In default Bash, it is not an error to refer to an undeclared (or empty) variable. In that case, it will just expand to an empty string.
So there's no need to do the prior check, you can just append the new value right away.
Also, in Bash you can safely set and export on the same command.

Thanks. I love the conciseness of this! PR #90 adds -o nounset to this file, so when that is merged, this won't work as is. But it could still be a one-liner.

@jongiddy thanks for the heads-up!
In that case, the ${foo:-} parameter expansion should do the trick to avoid raising error when unset.
Since it will also work even when -o unset is not active, I'll update this PR with the fix.