Checklist On Various Bugs and Feature Request needs to be worked upon immediate basis to make kiwi flawless gold standard browser on android

I Personally Never Thought I Will Use Kiwi As Daily Browser. But Due To Ignorance Of Brave Devs After 3 Years Of Turmoil I Finally Switched To Kiwi. Adapted Myself To Kiwi UI And Now Its 1 Year Since.
But Here For Kiwi Same Story All Devs Just Spend Time In Adding Complex Features To Their Browser.
Now That I Have And Many More Brave Users That I Know Have Started Using Kiwi I Would Love To See Kiwi As Gold Standard On Android Browser, Atleast In Terms Of Basic Browser Core Features
But Some Basic Features That Makes A Browser A Browser
Bugs And Feature Request

[ ] 1) Quick Tab Switching
->  https://Github.Com/Kiwibrowser/Src.Next/Issues/1147
->  https://Github.Com/Kiwibrowser/Src.Next/Issues/1137
In Settings Where We Can Toggle On/Off There Whether All Links Thats Have Target '_Blank' Be Opened In Same Group Tab -> Right Next To Currently Opened Tab

[ ] 2) Default Extension Page And Devtools Page Must Open In Group Next To Current Tab That Allows For Quick Switching Via Group Bubble  And Improve Productivity

[ ] 3) Stale Devtools Page  Whose Connection To Opener Tab Is Closed Due To Closing Ad Reopening Of Kiwi Must Be Discarded Automatically
**Because I Have Experienced That When Stale Devtools Page Are Open I See Network Connectivity Issue,  Means When I Try To Open Webpage It Doesnt Open And Also The 4G In My Android Notification Toolbar Keeps Greying Out And Fluctuating And It Affects Other Browsers On My Device  But As Soon As I Close The Kiwi Other Browsers Starts Working Normally And Internet Connectivity Gets Stable.
I Ruled Out That Closing The Stale Devtools Page Also Restores Normal Functioning

[ ] 4) Increase The Recent Tabs Time Period
**In Case Of Accidental Crash (When Enabling Bottim Toolbar For Example) Kiwi Closes All Tabs And Resets In That Case We Have To Relaunch Kiwi And Immediately Click Recent Tabs And Restore But It Needs To Be Done Quickly Upon Restart If Not Or Of We Open New Tab / Url  Kiwi Removes All Previous Tabs Cache From Most Recemt Tab Menu And We Cannot Restore And Lost

[ ]  5) Bug: Fullscreen Video Previous Tab Overlay  : Also In Other Chromium Based Browsers. When On Certain Movie Or Video Site I Fullscreen My Video And It Shifts To Landscape Mode The Previous Tab As Image Is Seen On Half Of Device Screen Covering Partial Video

https://Github.Com/Kiwibrowser/Src.Next/Issues/469
Not Fixed In Latest Kiwi Build

[ ]  6) Exit/Quit Button Bug Closes All Tabs When Exit
-> https://Github.Com/Kiwibrowser/Src.Next/Issues/1123

[ ]  7) External Download Manager (Termux Support) - Possible We Can Send Final Download Link To Termux  App Maybe Along With Cookies So That We Can Use Wget/Curl/Aria2C Like Command Line Tools For For Parallel Multithreaded Download

[ ]  8) Full Export Import Of Whole Browser Profile Without Root (History, Bookmarks, Opened Tabs, Passwords, Settings) So That We Can Backup And Restore (If Possible Auto+Periodic)

[ ] 9) Heavy Lag When Switching Back To Kiwi
https://Github.Com/Kiwibrowser/Src.Next/Issues/1145

[ ] 10) Group Tab Api Support Extensions

Ease Of Ui Accessibility

[ ] A) One Hand Browsing - Bottom Toolbar. In Kiwi If In Setting I Enable Bottom Toolbar And Relaunch It Closes All Tabs Just Resets Everything It Occured 3 Times With Me And Also There Is Git Issue If Dev Had Read And Not Ignored. Right Now In Latest Kiwi Version I Had 500 Tabs Opened I Want To Enable Bottom Toolbar But Not Willing To Take Risk Of Losing Tabs

[ ] B) Ability To Select All Tabs So We Can Backup Them (Related To Above If I Can Backup Opened Tabs I Can Test If Enabling Bottom Toolbar Still Closes Tabs (Risk)
-> https://Github.Com/Kiwibrowser/Src.Next/Issues/1125

[ ] C) Quick Add Bookmark (Brave Allows For Justquick Bookmarking Directly From Toolbar) Just One Button Click,

[ ] D) Quickly Open New Tab From Toolbar

[ ] E) Bookmark Sorting  And Create Bookmark Folder  And Select All Bookmarks In Folder And  Bulk Delete Them (Most Needed)

[ ] F)  When All Tabs Are Closed Automatically Open New Tab. Lemur Has This Settings. Because After Closing All Tabs Its Anmoying To Click Menu And Them Add New Tab.

[ ]  G) On Startup Automatically Open New Tab. When We Have 100s Of Tab Open On Startup Kiwi Lags Freezes For A Minute Or More And We Cant Immediately Start Surfing Web Because We Cant Create New Tab We Have To Surf Through Existing Foremost Tab But If It Had Some Page Opened We Dont Want To Change It Then We Ned To Open New Tab But It Kiwi Freeze Before Loading All Tabs And We Cant Open New Tab

Like This Setting in Lemur

[ ]   H) Chromium Tab Discarding Feature. Previous Session Tabs Were In Discarded State When We Start Kiwi So We Cannot Access Those Tab We Perform Chrome.Tabs.Query Using Extension Api. Even Some Extensions That Claim That When We Creare New Tab They Turn Of autoDiscard =  false But It Fails. Tabs Unloading Policies Are Enforced By Default.
I Know This Is Necessary To Prevent Memory Adhoc And Lagging.
But If Possible Provide Some Way To Just Retrieve List Of Tab Urls From Previous Sessions Just As Text/Json Backup
Extensions Like Session Managers Etc Are Not Ui Friendly Either, So Right Now I Have To Cutom Implement Extension That Maintains Log Of Every Session Tabs

[ ]  I) Web Search In Group Tab - Select Text And Web Search Must Open In Group Tab Next To Opener Tab

[ ]  J) Web Search For Link Text - For Links Text We Want Web Search Option. Currently We Have To Long Click Link -> Copy Link Text -> Open New Tab -> Click Address Bar -> Long Click And Paste To Search. Its Tedius

[ ] K) Brave Like Bottom Toolbar With Address Bar At Top And **Search Button In Bottom Toolbar To Quickly One Handed Search

[ ] L) Web Search In Incognito - On Selected Text Context Web Search For Incognito Tabs

[ ] M) Select Tabs (Multiple) And One Click Transfer All Tabs From Incognito To Regular And Vice Versa

Extension api support flaws (some that i experienced)

[ ] Some Extensions Exist But None Work On Kiwi Because The Extension Support On Kiwi Has Several Limitations. Its Still Not Full Fledged As Desktop Browsers
Eg.
Tabgroups Api -> Not Working At All
Tabs.Query -> Returns Only Newest Session Tab. Means After A Restart Of Browser All Previous Tabs Are Unloaded (Which Is Enforced By Chromium Policy) And Thus Are Not Available In Query.
Context Menu Related Extensions -> Wont Work Normally As On Android There Is No Right Click Instead Long Touch
Omnibox Apis -> Not Working. Neither Suggestions Are Working Not Preferences For Searches. Because For Omnibox Extensions Completions Requires Typing Keyword And Press 'tab' , But On Android Regular Keyboards Dont Have Tab Key Facility, Also Tried Hacker's Keyboard Tab Key Not Detected

Two More: A) The inbuilt dark mode is broken and keeps inverting colours of web contents. #968
B) The browser keeps disabling the monet theming for some reason. #969

I just wonder: are the maintainers still alive? Or they've forgotten their passwords?

https://github.com/kiwibrowser/src.next/issues/1101#issuecomment-2016552061


Configure the color of file paths and links in VS Code's integrated terminal

At present, the color of the output content from the VS Code terminal is the same. I want to match the output content from the PyCharm terminal: the color of the output file path will be specially marked, how should I set it?
such as : The "/xxx/file/path" color is red

This is not possible given the way we do links since we evaluate them lazily only on mouse hover in order to improve performance. You could request the Python CLI to improve the formatting of the files


Include 'Overall Profit' in online Loot Tracker view

Is your feature request related to a problem? Please describe.
Issue: A player may want to track loot  amounts >1000 and currently the plugin does not allow for that.  However, when logging into RL online you can view all synced loot data, but prices aren't included.
Describe the solution you'd like
The 1000 loot limitation of the Loot Tracker plugin (inside the client) could be improved by making a slight change to the .json that is synced with your Google account to also include "Overall" profit gained from loot.
It does seem that the item id's are included in the json, so they might be able to be queried against a GE lookup service (I'm assuming that exists since there is already a plugin for it)
Describe alternatives you've considered
Aside from manually looking up each item on the GE/GE Tracker/etc it would be fairly painful to lookup your total profits over time.  This can also be expanded on in the future possibly into graphs of profit over time with specific monsters which would be interesting.
Additional context
None currently.

Duplicate of https://github.com/runelite/runelite.net/issues/213


oven-media-engine: 0.14.14 -> 0.14.16

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AirenSoft/OvenMediaEngine/releases.
meta.description for oven-media-engine is: "Open-source streaming video service with sub-second latency"
meta.homepage for oven-media-engine is: "https://ovenmediaengine.com"
meta.changelog for oven-media-engine is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.14.15 with grep in /nix/store/48ah060grlxyzs2q3p2x6d3vk39vnhqc-oven-media-engine-0.14.15
found 0.14.15 in filename of file in /nix/store/48ah060grlxyzs2q3p2x6d3vk39vnhqc-oven-media-engine-0.14.15

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
oven-media-engine

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/48ah060grlxyzs2q3p2x6d3vk39vnhqc-oven-media-engine-0.14.15 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A oven-media-engine https://github.com/r-ryantm/nixpkgs/archive/d9d4d58e4f2661fcecd254f8c5d03d6e3706cd34.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/48ah060grlxyzs2q3p2x6d3vk39vnhqc-oven-media-engine-0.14.15
ls -la /nix/store/48ah060grlxyzs2q3p2x6d3vk39vnhqc-oven-media-engine-0.14.15/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

oven-media-engine

Maintainer pings
cc @lukegb for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AirenSoft/OvenMediaEngine/releases.
meta.description for oven-media-engine is: "Open-source streaming video service with sub-second latency"
meta.homepage for oven-media-engine is: "https://ovenmediaengine.com"
meta.changelog for oven-media-engine is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.14.16 with grep in /nix/store/gzpjglq58mxza54d45pikiih31yx27w3-oven-media-engine-0.14.16
found 0.14.16 in filename of file in /nix/store/gzpjglq58mxza54d45pikiih31yx27w3-oven-media-engine-0.14.16

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
oven-media-engine

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gzpjglq58mxza54d45pikiih31yx27w3-oven-media-engine-0.14.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A oven-media-engine https://github.com/r-ryantm/nixpkgs/archive/b8ed02ec49205f8d1de620d1d2281fce3c9375fb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gzpjglq58mxza54d45pikiih31yx27w3-oven-media-engine-0.14.16
ls -la /nix/store/gzpjglq58mxza54d45pikiih31yx27w3-oven-media-engine-0.14.16/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

oven-media-engine

Maintainer pings
cc @lukegb for testing.


Document error handling

So, I looked to see what Serde does, as I've never used it and don't know what its error messages look like.  If I'm reading this correctly, serde_derive_internals/src/attr.rs -> impl Container -> fn from_ast() - that one checks for the rename you mentioned.  If a parse error occurs it just aggregates a string for the error into the Ctxt.
Later, serde_derive/src/ser.rs in expand_derive_serialize() calls ctx.check(), which is what produces a Result<..., with_that_chain_of_error_strings>.
Finally, serde_derive has this in one of its entry points:
#[proc_macro_derive(Serialize, attributes(serde))]
pub fn derive_serialize(input: TokenStream) -> TokenStream {
    let input: DeriveInput = syn::parse(input).unwrap();
    match ser::expand_derive_serialize(&input) {
        Ok(expanded) => expanded.into(),
        Err(msg) => panic!(msg),
    }
}

It's just doing a panic! with the resulting string.  I have two questions :smile:

I guess Serde should be doing compile_error! there, both instead of unwrap() and the panic!?
Strategies for handling/presenting errors at various levels.  Okay, this is like a million questions.

From the way the gnome-class code is turning out, it looks like it will have places that generate errors at various levels.  I suppose Serde is in the same situation.

Errors during parsing, like your serde(rename()) example.  For these it is convenient to just bubble up a Result until you extract the error description from it at the toplevel, and return quote! { compile_error!(#descr); }.  I think in all cases the compiler will present such an error as spanning the whole invocation of the macro, which is suboptimal?  E.g. I'd like an error to come from Syn's innards to say something like, "expected 'fn' but found 'blah' instead".  I haven't looked closely enough at the synom sources to see if this is possible.

Errors detected during an "analysis" stage.  Implementations of proc macros will more or less create their own AST out of the parsed stuff, and then validate it / transform it in other ways.  The lazy_static example shows that to present good, spanned error messages for those, one should call problematic_token.span().unstable().warning("blah blah").emit() (or error()), and then quote that token into the final TokenStream as if everything were okay.  Then the compiler will present the warnings/errors in the right place.  Is this correct?

Related to the above - if the analysis stage just cannot proceed after detecting an error, i.e. if it can't generate a TokenStream "as if everything were okay"... I suppose one can bail out, and just emit the usual quote! { #problematic_token_with_the_span_error_already_called }?

I'm happy to write these docs; I'd just like confirmation that I'm understanding things correctly :smile: I need to write more examples for myself and see what happens!


patch push_data target_rot_speed

add _push_data function to send a list with target_rot_speed.setter

This PR is related to https://github.com/Luos-io/Examples/pull/79


App Id

I need the App I'd but how do I get it??

Please refer to http://forum.magicmirror.builders for support and troubleshooting.
I'm closing this issue for now. If you feel this issue should remain open, please let me know.

@Mahieedaboss   for what module?


Task31

@Bhargavi-reddy-uipath
Task -31
Code verified.
Task -32
Code verified.
Task -33
Code verified.


[PE-D][Tester E] Wrong error message for fav

When executing the command "fav<PHONE_NUMBER>213232132132321321321321323213" the error message given is not the typical message that the index is too large (eg. "fav 2213")

Labels: type.FunctionalityBug severity.Low
original: yockcheng/ped#5

Interesting bug!

Duplicate of #229 INDEX Parsing Bug.


Adding Pod lib lint to CI

Hey @SD10 :))
Fixes #1765

          3 Messages

:book:
iOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.318 (11.479) seconds

:book:
tvOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.274 (11.414) seconds

:book:
macOS: Executed 254 tests, with 0 failures (0 unexpected) in 11.340 (11.455) seconds

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #1767 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1767   +/-   ##
=======================================
  Coverage   90.83%   90.83%
=======================================
  Files           5        5
  Lines         131      131
=======================================
  Hits          119      119
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130a183...dae9447. Read the comment docs.


Please add a note for Network Shared

Please add a note that the Network Share can not be on a none Windows server (such as a SMB Appliance).  In order to work with such appliance, use a drive mapping to the NetShare instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af5cf2ac-3328-4c0f-486a-20975ae1f2f7
Version Independent ID: 3d7aaf0f-7da3-c06b-565e-b0239ded63c3
Content: Use the PST Collection tool to find, copy, and delete PST files - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/find-copy-and-delete-pst-files-in-your-organization.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@D-Jeffrey Thanks for the heads up and the suggestion. I updated the CopyLocation parameter description with your suggested fix.
https://docs.microsoft.com/en-us/microsoft-365/compliance/find-copy-and-delete-pst-files-in-your-organization?view=o365-worldwide#step-3-copy-the-pst-files-to-a-collection-location


Subscribing for OUTLINE often doesn't result in data until next modification

Currently it's not possible to request outlines from the analysis server on-demand - there's #27064 about adding this, but at the time is wasn't really important as we had a workaround. This week I noticed some strange behaviour in Dart Code - the symbol list was working rather intermittently (it seemed to just hang quite a lot).
I didn't get chance to investigate, but today I was trying to implement something else that requires outlines and I discovered that subscribing for outlines does not immediately cause a notification with the current outlines (I presume it used to, since when the symbol list was implemented nobody spotted any issues with it) however it does send them immediately on the next buffer change.
Here's a (trimmed) log:
[6:13:23 PM]: ==> {"id":"11","method":"analysis.setSubscriptions","params":{"subscriptions":{"OUTLINE":["/Users/danny/Dev/Testing/test_breakpoints/lib/main.dart"]}}}
[6:13:23 PM]: <== {"id":"11"}
[6:13:51 PM]: ==> {"id":"12","method":"analysis.updateContent","params":{"files":{"/Users/danny/Dev/Testing/test_breakpoints/lib/main.dart":{"type":"change","edits":[{"offset":304,"length":0,"replacement":" ","id":""}]}}}}
[6:13:51 PM]: ==> {"id":"13","method":"analysis.updateContent", // SNIP
[6:13:51 PM]: ==> {"id":"14","method":"completion.getSuggestions","params":{"file":"/Users/danny/Dev/Testing/test_breakpoints/lib/main.dart","offset":305}}
[6:13:51 PM]: <== {"id":"12","result":{}}
[6:13:51 PM]: <== {"event":"server.status","params":{"analysis":{"isAnalyzing":true}}}
[6:13:51 PM]: <== {"id":"13","result":{}}
[6:13:51 PM]: <== {"id":"14","result":{"id":"0"}}
[6:13:51 PM]: <== {"event":"analysis.errors","params":{"file":"/Users/danny/Dev/Testing/test_breakpoints/lib/main.dart","errors":[]}}
[6:13:51 PM]: <== {"event":"completion.results","params": // SNIP
[6:13:51 PM]: <== {"event":"analysis.outline","params":{"file":"/Users/danny/Dev/Testing/test_breakpoints/lib/main.dart", // SNIP
[6:13:51 PM]: <== {"event":"server.status","params":{"analysis":{"isAnalyzing":false}}}

Subscription is made at 6:13:23 but results don't appear until 6:13:51 immediately after an updateContent was sent. This wasn't fluke, it's totally* reproducible, I can leave it 10 minutes and then type a character and it'll come through.
* It's actually intermittent, I don't know why but sometimes it seems to work, but mostly it does not - possible it's affected by timing with setPriorityFiles, I haven't dug into this yet as I'm not sure if considered a bug.
It is very possible that this behaviour is by design (it's not documented that outline will be immediately sent for a file when you subscribe), however without either #27064 or the data being sent reliably, it breaks our ability to do things like get the symbol list (or the new Flutter decorations I'm testing out). Given the choice, I'd rather get the on-demand option, since (ab)using subscriptions this way could introduce our own races (we may soon have multiple things trying to subscribe/unsubscribe for the notifications, and they could end up unsubscribing each other!), but I don't know the difference in implementing them.
There is another workaround I can try which involves subscribing to OUTLINE always, and keeping the data for any open files in a cache, and then providing access to it from there. I'm not against doing this but since nothing else currently works this way and our usage is generally "only once" for each file I thought I should ask about this first.
(FYI @bwilkerson - not sure if notifying you on analyzer service issues makes it easier for you to pick them up?)

I found an easier workaround for now; just force an empty edit:
	let files: { [key: string]: as.ChangeContentOverlay } = {};
	files[editor.document.fileName] = {
		type: "change",
		edits: [{ offset: 0, length: 0, replacement: "", id: "" }]
	};
	this.analyzer.analysisUpdateContent({ files: files });

While testing I found another drawback to using the notifications instead of a request/response here... With notifications I have no ability to tie the results to a "version" of the document, so if the user is typing quickly, I often get back data that is "old" and therefore has incorrect offsets. This results in bad things.
If I could send a request/response then I could easily ensure the data returned is for the "latest" version of the document and discard it if it's not (eg. if the editor content "version" is different to the one I had when I initiated the request).
TL;DR: #27064 would be significantly more useful than changing this behaviour.

(Sorry for the spam!)
I did a refactor - I now just subscribe to outline/highlights/occurrences for all priority files. When I need the data, I send a dummy edit (insert an empty string at position 0) which seems to force an update. This somewhat turns this into request/response and eliminates all the races we had where different functions with subscribe/unsubscribe each other (by calling setSubscriptions). It means more traffic over the wire, but it seems to work reliably (actually, I think I can change it to just be the current active file and reduce this further).
So, I think for now I'm good. If you believe this is by design I'm happy for you to close it. It's slightly wonky that we're turning three notification functions into request/response but as long as you'll keep accepting a dummy edit to force a re-send of this data, I don't think it's causing any issues.

It isn't by design. When a client subscribes it ought to get a notification within a reasonable period of time.
@scheglov Looking at AnalysisServer.setAnalysisSubscriptions, it looks like it's using AnalysisDriver.getResult to try to force a new result to be computed so that the result will be sent across the result stream and the notification from server will happen. I suspect that if the cached result of analysis is valid that we're no longer producing any event on the stream and hence the notification never happens. Does that seem reasonable to you, and if so, any suggestions for how to fix it? (I suppose it's better to have multiple identical notifications than it is to miss one.

@bwilkerson Yes, your analysis is correct. When the file is a priority file, we cache its analysis result.  And AnalysisDriver.getResult() does not send the cached result to the results stream.
However it would be expensive to send it every time, because navigation through the same file causes assists and fixes requests, which call getResult(). We don't want recompute and resend navigation every time when the caret moves.
So, we need another way to fix it.
I will write a test and add a fix.

https://codereview.chromium.org/2989633002

Currently I'm sending a dummy edit to force the update. It would be good to remove this, but if I do it always, people on older SDKs will get broken behaviour (hangs in the symbol list, etc.). An ideal solution would be that I can use the analysis server version and only send the dummy edit for "older" versions.
Is it reasonable to bump the analyzer server version for this? Or, has the recent bump from @bwilkerson not shipped yet and I could just use that version number?

The fix has been landed.
I leave it to @bwilkerson to decide about the version, I'm not sure what was changed in this area recently.

The current version number was included as part of 1.25.0-dev.5.0, 1.25.0-dev.6.0, 1.25.0-dev.7.0, and 1.25.0-dev.8.0. If your users only use stable versions of the SDK (something I don't know how to determine), then using the current number would be sufficient. It's safer if we update the version number.

Done: https://codereview.chromium.org/2985003002/

Great, thanks! 👍


Guac demo expected output differs from actual

The second Guac demo  "What is Known and Unknown about your Software Supply Chain instructs the user to ingest an SBOM from guac-data-main/top-dh-sboms/vault.json. In Step 2, it asks the user to search for an artifact by hash (here), but that hash is not present in the SBOM, and as a result the expected output does not appear.
It seems that this hash is present in guac-data-main/docs, which the demo suggests to ingest in the setup page, but not in the Known and Unknown demo.

hmmm since that part of it is asking for a SLSA attestation, i think i'd be more inclined to update step 1 to collect the docs as usual and skip the additional "vault.json" SBOM and query something within the docs corpus to avoid confusion. Thoughts @pxp928 @jeffmendoza ?

hmmm since that part of it is asking for a SLSA attestation, i think i'd be more inclined to update step 1 to collect the docs as usual and skip the additional "vault.json" SBOM and query something within the docs corpus to avoid confusion. Thoughts @pxp928 @jeffmendoza ?

One of the requirements for the "What is Known and Unknown about your Software Supply Chain is:
Completion of the [Expanding your view of the software supply chain demo](https://docs.guac.sh/expanding-your-view/)

where the vault data is ingested.
We could instead add to step 2 that ingest the "guac-data" if not already ingested before continuing

created PR to address


ReorderableListView.builder not accessible

I was trying to create a ReorderableListview, but found that there is no "physics" property available in it.
Later figured out that we have ReorderableListview.builder constructor which has "physics" property defined: https://api.flutter.dev/flutter/material/ReorderableListView/ReorderableListView.builder.html
Now, the issue is I cannot access ReorderableListview.builder.
Has anyone has the example of ReorderableListview.builder ? Or worked with it?
My main moto is to add physics to ReorderableListview.
An example of ReorderableListview.builder will be helpful and appreciated.
Thanks in adavance.

Now, the issue is I cannot access ReorderableListview.builder.

What do you mean by that?
Does that answer your question?
      ReorderableListView.builder(
        physics: BouncingScrollPhysics(),     // Add your physics here!
        itemBuilder: (context, index) {},
        itemCount: itemCount,
        onReorder: onReorder,
      ),

@pedromassangocode  Hi, when I try to access ReorderableListview.builder it show the following message :
The method 'builder' isn't defined for the type 'ReorderableListView'.  Try correcting the name to the name of an existing method, or defining a method named 'builder'.
Please find the attached file for reference

:

Can you please provide your flutter doctor -v?
Thank you

@pedromassango Here you go:
Flutter (Channel unknown, 1.22.3, on macOS 11.2.1 20D74, locale en-IN)
• Flutter version 1.22.3 at /Users/sunflower/Documents/flutter
• Framework revision 8874f21e79 (4 months ago), 2020-10-29 14:14:35 -0700
• Engine revision a1440ca392
• Dart version 2.10.3
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/sunflower/Library/Android/sdk
• Platform android-30, build-tools 30.0.3
• ANDROID_HOME = /Users/sunflower/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 12.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.4, Build version 12D4e
• CocoaPods version 1.10.1
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin installed
• Dart plugin version 201.9317
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

This constructor was added recently by https://github.com/flutter/flutter/pull/74697. And looks like your Flutter version is too old.
Please upgrade your Flutter version.
Thank you


Unexpected unindentation.

Amazing plugin! THX a lot :D

Hi, sorry about it. I am not really sure what the issue is. Can't really tell from your video.

Hi, sorry about it. I am not really sure what the issue is. Can't really tell from your video.

The original block "333" should be at level-3 in the outline, which is a child-block of '222'.
After swaping, the ref become level-2, which is brother-block of '222.

The point is that the indentation changes, which I don't want...

Ah I see. The problem with gifs is that you can never know when the gif starts and when it ends.
Will look into this.

Upvote this, encounter the same problem.  It makes more sense for the level of indentation to be the same before and after swap for both origin and swapped one, i.e. the indentation structure is preserved. It is not the case currently:
before swap

after swap - the indentation structure is not preserved

Hi all,
Please update to v1.2.2 and see if the issue still persists?

Hi all, Please update to v1.2.2 and see if the issue still persists?

It works! THX <3


[FEATURE] support VM backup and restore

Is your feature request related to a problem? Please describe.

support VM snapshot., backup, and restore using the build-in distributed block storage
Describe the solution you'd like

Work process in the UI:

need to specify a backup target(both NFS and S3 are supported) before config the backup.
Users can take a snapshot of an existing VM without downtime.
Users can take a backup of an existing VM without downtime.
Users can use the backup to roll-back the existing VM to a certain point in time [VM should be stopped].
Users can use a backup to restore a new VM.

Describe alternatives you've considered

Additional context

There are problems with this scenario @guangbochen
Restoring a new vm after multiple backups of the same vm successfully
Steps

Create vm successfully and login
add back1.txt to save and backup vm to vm-back1
add back2.txt to save and backup vm to vm-back2
install docker on vm, backup vm to vm-back3-with-docker
wait for vm-back1, vm-back2, vm-back3-with-docker to finish backup
restore vm-back1, vm-back2, vm-back3-with-docker to vm-back1-restore, vm-back2-restore, vm-back3-with-docker-restore in order

Results

See vm-back1-restore, vm-back2-restore and vm-back3-with-docker-restore as the same with docker

Question 2
Whether NFS or S3 is used as backup-target, deleting backups on the UI will not actually change the size of backup-target.

@WuJun2016
Steps

Successfully create a VM
Use the VM to create two backups with the same name

Results

There will be two alert boxes, success and failure
No backups were eventually created

Expectation

only failed box

Whether NFS or S3 is used as backup-target, deleting backups on the UI will not actually change the size of backup-target.

this actually is managed by the longhorn and will check it with @yasker, since we are deleting the volumesnapshot CR directly on the Harvester side, just wondering if there is any other object we need to handle from the longhorn side, maybe cc @shuo-wu.

@TangStone Backup blocks are referenced and GCed, so as long as one block is still being used by any backup, it's not going to be freed. Can you try if you delete all backups, does it clean up the directory and free the space?

I delete all backups, it doesn't clean up the directory and free the space @yasker  It seems that volumesnapshot is not deleted @guangbochen

@innobead Can someone help to look into this?

https://github.com/longhorn/longhorn/issues/2417 created.
@TangStone Next time. Please help also create a corresponding issue on longhorn, then the issue will be tackled. Thanks.

I delete all backups, it doesn't clean up the directory and free the space @yasker It seems that volumesnapshot is not deleted @guangbochen

@TangStone,
I didn't deploy Harvester to test it but I create a Longhorn cluster with version v1.1.0 and v1.1.1-preview1 respectively and deploy an Elasticsearch cluster (StatefulSet) on it. However, I can't reproduce the issue you described. I delete all VolumeSnapshot CR of specific volume, the backups/ and blocks/ folder both got deleted in MinIO.
Questions:

For the directory that doesn't clean up: do you mean the backups/ and blocks/ folder in MinIO?
The space did not free: could you please capture the screen to us about this?
Do you know which Longhorn version Harvester is using?

Validate the version in master-67244e23-head
Backup rename prompt problem solved https://github.com/rancher/harvester/issues/385#issuecomment-804058048

I will take a look at the backup clean up issue first, thanks

@jenting
Questions:

For the directory that doesn't clean up: do you mean the backups/ and blocks/ folder in MinIO?
The space did not free: could you please capture the screen to us about this?
Do you know which Longhorn version Harvester is using?

First question answer
The backup and baocker folders are not cleaned
Answer to the second question

Before creating a VM backup

After creating a VM backup

After deleting the VM backup

If you manually delete the volumesnapshot in the harvester host using the command

it clean up the directory and free the space

Answer the third question

Before creating a VM backup
After creating a VM backup
After deleting the VM backup
If you manually delete the volumesnapshot in the harvester host using the command
it clean up the directory and free the space

Ok. Because the volumesnapshot operation works (the K8s interface to operate LH), this should be related to Longhorn integration at Harvester. Please check if the API integration correctly from the frontend to the backend at Harvester.

Validate the version in v0.2.0-rc1
Solved the problem of deleting all backups and not releasing the target space  https://github.com/rancher/harvester/issues/385#issuecomment-810092427

Validate the version in v0.2.0-rc1
Solved the issue  https://github.com/rancher/harvester/issues/385#issuecomment-801860005


Transform getHomepageData function into homepageData object

We currently have every text of the website inside the data folder, separated in different files.
The one for the homepage is the data/homepage.js. It exports a function called getHomepageData which doesn't receive any argument. This is legacy code, and we would like to rework it in order to have an object instead.
What we have to do is:

Transform the getHomepageData  function of the data/homepage.js file into an object
Rename getHomepageData into homepageData in every file that uses it (including the stories folder used by Storybook)

Can I work on this?

Hello @FilipePfluck  👋
Sure go ahead!
Just note that we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages volunteer contributors to open a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.
We are looking forward to reviewing your PR!

Hey @mdubus I believe I already made all the changes needed, and I was going to test just to make sure everything is working properly. I tried to install the dependencied and I got this error:

I didn't want to try to solve it myself, since I don't want to mess the dependencied up. Do you have any recommendation?

Hello @FilipePfluck  👋
I see that you are using npm, can you try with yarn instead? Also, can you open your PR with the changes, so that we can discuss it there? It would be a more appropriate place I think 😀
Thanks a lot! 🙏

Done with 550


fixing relative imports and cPickle to pickle for python3

Hi Rushil,
I was able to get this code to run, but had to make some changes to how you do imports. It wouldn't run out of the box in python 3.6.8.
This shouldn't have any effect on your model or data.  As you can see, I fixed your your imports to be relative so that you don't need to manipulate the PYTHONPATH to get the imports to work, like:
from .model_AVB import *

and
from .utils import spectral_norm as SN

Also I changed imports of cPickle to pickle.
The rest of the changes are just reordering your imports to be in the order: std, tf, custom.
Now I am able to run your ipynotebook out of the box like:
git clone git@github.com:rreece/macc.git
cd macc
cd data
tar xzf icf-jag-10k.tar.gz
cd ..
jupyter notebook --no-browser --port=8000

And locally ssh forwarding:
ssh -NfL 8000:localhost:8000 ryan@<remote_IP>

Thanks Ryan, this is helpful. I am working on getting things compatible with Python 3.x. I am merging the PR


 tag under section from ccda file is not converted to FHIR

 tag under section from ccda is not converted to FHIR.
we are processing Consultation_Note.ccda and we have couple of  tag under sections, those are not gettting converted to FHIR. We are not gettting any output for those tags.
Exmaple from Consultation_Note.ccda below:

ALLERGIES AND ADVERSE REACTIONS

Substance
Reaction

Resolved.


Fix broken links in status section of README.md

My first pull request ever for any project.  Please be gentle.  :-)

Please fix DCO

@jonathanmanton see: https://github.com/helmfile/helmfile/pull/1618/checks?check_run_id=27189591187

@jonathanmanton see: https://github.com/helmfile/helmfile/pull/1618/checks?check_run_id=27189591187

I cannot follow these instructions.  It asks me to check out the pull request (gh pr checkout 1618).  If I do this in a local copy of the helmfile/helmfile repository, it (mostly) works (there is no HEAD-3 branch), but when I take the steps requested I get an HTTP 403 error on the push because I (rightly) do not have access to write to that repository.  If I try to do this in my repository (jonathanmanton/helmfile), it does not recognize the pull request checkout, since the pull request is in the helmfile/helmfile repository, not in my fork.
I'll use this as an opportunity to learn more about rebasing commits.  If I can't figure it out in an hour or so I may just delete this pull request and create a new one that has the commit properly signed in the first place.

Looks like my eyes are getting old.  HEAD~3 and HEAD-3 are not equivalent...  Hopefully will be fixed now.

@jonathanmanton fixed. thanks so much.


Improve stats convert performance for Binary/String arrays

Which issue does this PR close?

Closes #11281
Rationale for this change
Improve the stats convert performance as possible.

What changes are included in this PR?

Use string builder directly to eliminate some tmp Vecs and Strings(for example, Utf8 and LargeUtf case in both row group or page stats).
Eliminate some unnecessary collect to avoid tmp Vec creation

Are these changes tested?
Test by exist tests.

Are there any user-facing changes?
No

I suspect the remaining cases where we are using collect could be made more efficient using the Builder pattern?

I think the reason the Builder is faster for Strings / Binary is that due to how the references worked out, we can avoid copying the strings via value.to_string()
I don't think the Builder pattern is fundamentally better/worse than the from_iter (under the covers they all end up doing the same thing in arrow-rs I think)

I suspect the remaining cases where we are using collect could be made more efficient using the Builder pattern?

I think the reason the Builder is faster for Strings / Binary is that due to how the references worked out, we can avoid copying the strings via value.to_string()
I don't think the Builder pattern is fundamentally better/worse than the from_iter (under the covers they all end up doing the same thing in arrow-rs I think)

Yes, I tested the Uint64Array case in my POC, use Builder directly is a bit slower than use from_iter actually.
https://github.com/Rachelint/arrow-datafusion/blob/70b9f05e737e81c514259e70a8bd2e9f0ad8e725/datafusion/core/src/datasource/physical_plan/parquet/statistics.rs#L790

@efredine @alamb I made an bench about using Builder instead of collect, performance improved!

use collect

Extract data page statistics for Boolean/extract_statistics/Boolean
                        time:   [11.392 µs 11.403 µs 11.411 µs]

use Builder

Extract data page statistics for Boolean/extract_statistics/Boolean
                        time:   [10.089 µs 10.092 µs 10.096 µs]


fix: do not return uuids in urn format

Checklist

[x] Tests have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Bug fix
What is the current behavior? What is the new behavior?
type: string
format: uuid

never returns the uuid in its urn form
Closes #365

@StefanDywersant, I've bumped JSF and added that ^ to the tests, can you take a look?

@lag-of-death Can you also add a line in the changelog file?


Autotests: Displaying modified nucleotide chains in sequence representation

Source task(s):

https://github.com/epam/ketcher/issues/3734

Description:
These bunch of tests validates that system correctly display modified nucleotide chains in sequence representation
Test case 1:

Switch to Macromolecules view
Load from file (unzip first): 1. All types of modifications.zip
Switch to Sequence mode
Validate canvas

Test case 2:

Switch to Macromolecules view
Load from file (unzip first): 2. All types of connection between CHEM and RNA.zip
Switch to Sequence mode
Validate canvas

Test case 3:

Switch to Macromolecules view
Load from file (unzip first): 3. All types of connection between Sugar and RNA.zip
Switch to Sequence mode
Validate canvas

Test case 4:

Switch to Macromolecules view
Load from file (unzip first): 4. All types of connection between Base and RNA.zip
Switch to Sequence mode
Validate canvas

Test case 5:

Switch to Macromolecules view
Load from file (unzip first): 5. All types of connection between Phosphate and RNA.zip
Switch to Sequence mode
Validate canvas

Automated.


Add robot mesh detections to NUsight visual mesh display

The NUsight mesh colours are hardcoded with environment in the fourth position. Now that the network has an extra class, robots are the fourth index and environment is the fifth. This is consistent across the networks we have currently.
NUsight has been displaying robots as black and ignoring environment (resulting in also black).
This PR changes this so that robots appear in a different colour to the environment.
Currently dark magenta, but this may change.

Doesn't this invalidate old nbs recordings? Is there a reason robot wasn't added as the 5th/last class?

That's the way the mesh was trained. It makes sense to me to have background as the last one. This has been like this for a long time. NUsight has been technically broken for that long. This is also why I want positions of classes to be dynamic based on the proto, not hardcoded. Any nbs file that is that old will have more problems than that.


OCPBUGS-26437,OCPBUGS-26438: [release-4.14] CVE-2023-45142,CVE-2023-47108: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.46.1

This is manual cherry-pick of
https://github.com/openshift/azure-disk-csi-driver-operator/pull/107
https://github.com/openshift/azure-disk-csi-driver-operator/pull/107
@openshift/storage

/jira cherry-pick OCPBUGS-25237,OCPBUGS-22560

/label backport-risk-assessed

/close
we've decided not to fix 4.14.z and wait for 4.15 GA instead. The amount of dependency changes is too big to be safe for a z-stream and moderate CVE.


Please add decimal point to lat / long values

MQTT lat / long data contains no decimal points rendering Home Assistant unable to render the location when used as a device tracker.
Can a decimal point be inserted in the values please.
(Using the Python version)

By using the python gateway there's already a device tracker (mqtt autodiscovery). Take a look at the mqtt integration in Home Assistant.
Additionally there are three mqtt topics which contain the position, longitude and latitude with a decimal point.
So there's nothing to do for me :)

Wow ! I have no idea how i missed that !
Well, thank-you for pointing that out AND for developing this add-on.
It's very much appreciated.


Can't view people.

Keybase GUI Version: 4.0.0-20190507193726+6614a49937
Whenever I click on a person, I get this:

I looks like it loads their page for a moment, but then it's replaced by this.

Keybase GUI Version: 4.0.0-20190507193726+6614a49937
Whenever I click on a person, I get this:
I looks like it loads their page for a moment, but then it's replaced by this.

I have the same issue - it looks like my profile was deleted but only in some cases. I can login with Desktop App and also on the Web bud I cannot view my Profile page.

It was a Keybase server outage, should be fixed now/ASAP.

I was in fact that thing @cjb said and appears to be all better now.


Allow Prefix (or Suffix) for commit messages

Right now, we're using this plugin to push content changes to the master branches of a site, that also has some CI/CD pipelines defined and attached to that branch. So every commit the plugin makes and pushes triggers a building pipeline what right now is, frankly, really not necessary.
We could stop the pipelines from running by adding a tag link [skip ci] to the commit messages the plugin generates. So at the end of the day, we'd need the option to add some kind of prefix or suffix to the generated commit messages.
Since this is a special request and I don't know if your own usages of the plugin would benefit from this, would you still be open to accepting a PR for this?

Hi, for sure! Maybe it’s a good idea to make all commit message configurable. For example with placeholders like :action: :item: :url: so the current pattern would be :action:(:item:): :url: and you can easily configure that to be like :action:(:item:): :url:\n\n[skip ci] for your use case.
What do you think?

Sound very reasonable to me.

I created PR #64 for this

Thank you! I’ll have a look at it…


update to use accessible-autocomplete 1.6.1

hiya - could you please update the version of accessible-autocomplete to 1.6.1? Theres a bugfix in there we need.
Also, could you publish a new version to npm?
Thanks.

Hi @revilossor, PR is open :) https://github.com/alphagov/govuk-country-and-territory-autocomplete/pull/26

Merged and published @revilossor


Update LSP to support compiler 0.1.35

The test failure reflects a change that occurred earlier in clvm_tools_rs.  I made the same change in the nightly branch.

Neat.


Merge session-related declarations/statements with ada module

The declaration and statement classes introduced in #47 have a high overlap with the classes in the ada module. This code duplication should be removed.

As both implementations require different features, we should keep them separate. The ada module should only contain functionality needed for code generation.


Update sbt to 1.4.4

Updates org.scala-sbt:sbt from 1.4.1 to 1.4.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #6 (deb5d97) into master (4d7a553) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files          23       23
  Lines         895      895
  Branches        6        6
=======================================
  Hits          872      872
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7a553...deb5d97. Read the comment docs.


Document S3 S3_REGION constant

This gave me a lot of grief recently as the AWS Region for S3 is controlled by an undocumented constant S3_REGION which defaults to us-east-1 unless defined on the system-level. Extra frustrating as it departs from the common naming practice: AWS_REGION:
https://github.com/tensorflow/tensorflow/blob/79422ab39b5fe0e1491abb8deabc7ecb5fd9f3a2/tensorflow/core/platform/s3/s3_file_system.cc#L52
If somebody could suggest where to document this, I'd be happy to contribute.

@jhseu, do you think we should support both and just fallback?

Yeah, if there's a common practice here, we should use that and deprecate the other environment variable in TF 2.0.

The S3_REGION was introduced in PR #11089. Sorry about the confusion on AWS_REGION vs. S3_REGION.  I will create a PR to add AWS_REGION support shortly.

Added a PR #14984 for the fix. Please take a look.


drivers: wifi: esp_at: Some issues on Passive Receive mode

Describe the bug
ESP8266 supports Passive Receive mode (CONFIG_WIFI_ESP_AT_PASSIVE_MODE).
Without enable, ESP8266 shield will continuously push data to board (+IPD) anyway on receive and board's Rx buffer can get OOM easily. However, current driver implementation on Passive Receive mode has the following issues:
Issue 1:
On <conn_id>,CLOSED, driver closes the socket prematurely and buffered Rx data on ESP8266 shield gets unable to fetch (AT+RECVDATA).
https://github.com/zephyrproject-rtos/zephyr/blob/56284d7017dc593f18c3aaa128d2c4e596a8e4c8/drivers/wifi/esp_at/esp_offload.c#L510-L511
https://github.com/zephyrproject-rtos/zephyr/blob/56284d7017dc593f18c3aaa128d2c4e596a8e4c8/drivers/wifi/esp_at/esp_socket.c#L154-L158
Issue 2:
On +IPD, driver doesn't consider available Rx buffer and straight schedules to fetch buffered Rx data on ESP8266 shield, still causing Rx buffer OOM. One approach may pre-allocate Rx buffer before the schedule.
https://github.com/zephyrproject-rtos/zephyr/blob/56284d7017dc593f18c3aaa128d2c4e596a8e4c8/drivers/wifi/esp_at/esp.c#L659-L663
To Reproduce
The issues are re-produced on one Cortex-M4 board which is to plan to add into Zephyr, but I think another board with ESP8266 shield can also re-produce the issues.
Issue 1:

Add WiFi connection into samples/net/sockets/http_get
Build with CONFIG_WIFI_ESP_AT_PASSIVE_MODE=y and ESP8266 shield enabled.
Flash and run

Issue 2:

Add WiFi connection into samples/net/sockets/big_http_download
Add k_msleep(8000) in big_http_download.c download() while loop.
Build with CONFIG_WIFI_ESP_AT_PASSIVE_MODE=y and ESP8266 shield enabled.
Flash and run

Expected behavior
Issue 1:
You will see http request is sent but http response is not received.
Issue 2:
You will see net_pkt: is failed to allocate.
Logs and console output
Issue 1:
Note http response is not received.
Preparing HTTP GET request for http://google.com:80/
getaddrinfo status: 0
addrinfo @0x20009bc8: ai_family=1, ai_socktype=1, ai_protocol=6, sa_family=1, sin_port=5000
sock = 0
Response:

Issue 2:
Note net_pkt is failed to allocate.
Preparing HTTP GET request for http://archive.ubuntu.com:80/ubuntu/dists/xenial/main/installer-amd64/current/images/hd-media/vmlinuz
addrinfo @0x2000bc88: ai_family=1, ai_socktype=1, ai_protocol=6, sa_family=1, sin_port=5000

Iteration 1 of 3:
sock = 0
[00:00:13.867,000] <err> wifi_esp_at: Failed to get net_pkt: len 1394
Download progress: 3581 Bytes; 3 KiB; 0 MiB

Environment (please complete the following information):

OS: Windows 10
Toolchain: GNU Arm Embedded Toolchain 10.3-2021.07
Commit 3f0e8dda3d72bd9dda069bc0c013d7d67f593c7e

Closing with the correct reason as this was improperly marked as "completed".


Compiling issue in linux

Compiling on my ubuntu 20.04 fails.
It seems the components are compiled correctly, but the main is not compiled, nor found by the linker.
See the error below.
marco@Latitude-E6440:/media/marco/DATA/programming/riscv/bl_iot_sdk-master/customer_app/bl602_demo_wifi$ make use existing version.txt file LD build_out/bl602_demo_wifi.elf /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/lib/rv64imafdc/lp64d/crt0.o: in function.L0 ':
(.text+0x2e): undefined reference to main' collect2: error: ld returned 1 exit status make: *** [/media/marco/DATA/programming/riscv/bl_iot_sdk-master/make_scripts_riscv/project.mk:420: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/customer_app/bl602_demo_wifi/build_out/bl602_demo_wifi.elf] Errore 1

Missing main is a symptom, not the problem. The linker is being invoked to build an rv64 executable when this is an rv32 system. (It's confusing because the entire chain is called "riscv64" but the flags should be setting flags to build and link in 32-bit mode. The hint is the "...lib/rv64imacfd" part of the pathname.
run  make  V=1 and show us the lines leading up to that linker invocation. It will be called by collect2 which is called by the gcc front-end.
Do you have any environmental variables like CFLAGs or LDFLAGS that are polluting the build environment?

Also, it's known that some examples are not possible to compile, although this one if I remember correctly should work fine.

Thank you for the quick reply.
I found that indeed I had the LDFLAGS set, therefore after doing
unset LDFLAGS
the bl602_boot2 compiled flawlessly.
However, when going to the bl602_demo_wifi it still does not compile, with following errors
'make V=1
...
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/components/bl602/bl602_wifi/lib/libbl602_wifi.a(cfg_api.o): in function cfg_api_element_set': /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:91: undefined reference to _ld_bl_static_cfg_entry_start'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:91: undefined reference to _ld_bl_static_cfg_entry_end' /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:164: undefined reference to _ld_bl_static_cfg_entry_start'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:167: undefined reference to _ld_bl_static_cfg_entry_end' /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/components/bl602/bl602_wifi/lib/libbl602_wifi.a(cfg_task.o): in function dump_cfg_entries':
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:24: undefined reference to _ld_bl_static_cfg_entry_start' /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:28: undefined reference to _ld_bl_static_cfg_entry_end'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:24: undefined reference to _ld_bl_static_cfg_entry_start' /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:27: undefined reference to _ld_bl_static_cfg_entry_end'
collect2: error: ld returned 1 exit status
make: *** [/media/marco/DATA/programming/riscv/bl_iot_sdk-master/make_scripts_riscv/project.mk:420: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/customer_app/bl602_demo_wifi/build_out/bl602_demo_wifi.elf] Errore 1
'

Awesome. Glad we got that fixed without a lot of pain.
That failure is due to missing pieces within the blob of the wifi trying to
use symbols that aren't provided by flash.ld. I get the exact failures on
my system. I took the problem to the developer chat room last night about
3am and haven't heard back yet. My guess is that it falls into what Marek
is describing: a code block that just doesn't work.
We've thus solved the original problem. The ability to
build bl602_demo_wifi is a different problem and it's not solved. I don't
know if people will scroll back in the IRC thing to read my description
when they awaken, but that's where I took the conversation.
On Wed, Nov 25, 2020 at 2:20 AM Marco Merlin<EMAIL_ADDRESS>wrote:

Thank you for the quick reply.
I found that indeed I had the LDFLAGS set, therefore after doing
unset LDFLAGS
the bl602_boot2 compiled flawlessly.
However, when going to the bl602_demo_wifi it still does not compile, with
following errors
'make V=1
...
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/components/bl602/bl602_wifi/lib/libbl602_wifi.a(cfg_api.o):
in function cfg_api_element_set':
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:91:
undefined reference to _ld_bl_static_cfg_entry_start'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:91:
undefined reference to _ld_bl_static_cfg_entry_end'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:164:
undefined reference to _ld_bl_static_cfg_entry_start'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_api.c:167:
undefined reference to _ld_bl_static_cfg_entry_end'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/components/bl602/bl602_wifi/lib/libbl602_wifi.a(cfg_task.o):
in function dump_cfg_entries':
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:24:
undefined reference to _ld_bl_static_cfg_entry_start'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:28:
undefined reference to _ld_bl_static_cfg_entry_end'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:24:
undefined reference to _ld_bl_static_cfg_entry_start'
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld:
/home/rjwang/work/bl_iot_sdk.release/components/bl602/bl602_wifi/ip/cfg/cfg_task.c:27:
undefined reference to _ld_bl_static_cfg_entry_end'
collect2: error: ld returned 1 exit status
make: ***
[/media/marco/DATA/programming/riscv/bl_iot_sdk-master/make_scripts_riscv/
project.mk:420:
/media/marco/DATA/programming/riscv/bl_iot_sdk-master/customer_app/bl602_demo_wifi/build_out/bl602_demo_wifi.elf]
Errore 1
'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pine64/bl_iot_sdk/issues/81#issuecomment-733544988,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCSD3ZB23UO3AT43LU6VC3SRS45LANCNFSM4UBPSFVA
.

Thank you Robert for your help and comment.
Do you mean that this example does not work even in the original SDK ?

Correct. See my (lonely) conversation on matrix.io from maybe six or seven
hours ago.
I didn't loop backward to see how long this failure has existed.
libbl602_wifi.a(cfg_task.o) inside the binary blob is linking against those
symbols and they don't exist. Similar symbols are provided by the flash.ld
script, but this app doesn't link because nothing provides those symbols.
It looks to be configuration data (something like a compiled foo.ini tree)
that the WiFi module is wanting, but isn't finding it. Those symbols don't
appear in the source tree that I can find.
On Wed, Nov 25, 2020 at 9:15 AM Marco Merlin<EMAIL_ADDRESS>wrote:

Thank you Robert for your help and comment.
Do you mean that this example does not work even in the original SDK ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pine64/bl_iot_sdk/issues/81#issuecomment-733767680,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCSD37Z2NKVVGVQPO5ICQDSRUNPRANCNFSM4UBPSFVA
.

I just pulled the Boufallou tree and tried to build demo_wifi. It fails in almost the same way[1].
I then did a git checkout ee4a10b1a1e3609243bd5e7b3a45f02d768f6c14 to revert to their first public release and it failed in the identical way.
I have no reason to think this is a Mac-only thing (wait, @bat52  is on Linux) but it's my suspicion this directory has never built in a publicly released version.
As an aside, @bat52, do I know you with a slightly different name?
[1] Why "almost"? Because Bouffalo accepted a commit today that broke the tree in a slightly overlapping way. :-/ See https://github.com/bouffalolab/bl_iot_sdk/issues/18. It's awesome debugging two trees that are broken in three different ways.

Thank you for your comments @robertlipe !

As an aside, @bat52, do I know you with a slightly different name?
I do not think I have ever known you before this discussion... but nice to meet you! :-)

"_ld_bl_static_cfg_entry_start" happens when you compile without CONFIG_LINK_ROM=1

Thank you for the comment @gamelaster.
I have tried compiling again after calling
export CONFIG_LINK_ROM=1
but I still get the linker error below.
What am I doing wrong?
marco@Latitude-E6440:/media/marco/DATA/programming/riscv/bl_iot_sdk-master/customer_app/bl602_demo_wifi$ make CONFIG_LINK_ROM=1 use existing version.txt file LD build_out/bl602_demo_wifi.elf /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/bin/ld: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/toolchain/riscv/Linux/bin/../lib/gcc/riscv64-unknown-elf/8.3.0/../../../../riscv64-unknown-elf/lib/rv64imafdc/lp64d/crt0.o: in function .L0 ':
(.text+0x2e): undefined reference to main' collect2: error: ld returned 1 exit status make: *** [/media/marco/DATA/programming/riscv/bl_iot_sdk-master/make_scripts_riscv/project.mk:420: /media/marco/DATA/programming/riscv/bl_iot_sdk-master/customer_app/bl602_demo_wifi/build_out/bl602_demo_wifi.elf] Errore 1

Hi @bat52
Did you cleaned the project before compiling?

yes i did!
Il sab 28 nov 2020, 20:25 Marek Kraus<EMAIL_ADDRESS>ha scritto:

Hi @bat52 https://github.com/bat52
Did you cleaned the project before compiling?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pine64/bl_iot_sdk/issues/81#issuecomment-735279873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALPNWJOMIDKMUYX54QYCC3SSFFDJANCNFSM4UBPSFVA
.

I've stumbled upon the same issue, @bat52. Make sure to make clean after changing the CONFIG_LINK_ROM variable.

My build returned same error, verified that CPPFLAGS and LDFLAGS are clean.
I've set the export CONFIG_LINK_ROM=1 but forgot to clean!
Build returned same error.
4. make clean && export CONFIG_LINK_ROM=1 && ./genromap and voilá it works.

thank you @suculent , it ended up working as you said.
It was not clear to me I should have used genromap, and indeed I had LDFLAGS still defined in my environment.
cheers!


Feature: Bank Management

Your application is great, and I think adding bank features to track each bank's transaction is better.

Thanks for the feedback. Yes, it's planned in the future but maybe in v2 or v3 of the project.


RuTorrent RPC

Does this script support RPC? For things like Sonarr and CouchPotato, they have better intergration with rutorrent RPC instead of torrent blackhole.
I couldn't find any info on this, so was just wondering.
If not, don't worry, but if so, any idea? (Ports, web url, etc)
Thanks!

Not sure what you need but rtorrent is compiled with xmlrpc, and the RPC port in rtorrent is set to 5000 for the initial user, and +1 for subsequent users in a multi-user environment.
The port is set in ~/.rtorrent.rc and /var/www/rutorrent/conf/users//config.php
Let me know if this information helps

Thanks for your reply.

CouchPotato requires these settings for rTorrent. I've tried different combinations of the recommended settings, but nothing seems to work.
edit before posting: scrap that, I just figured it out. For anyone wondering:
I added the following to /etc/nginx/sites-available/default: (under both 80 and 443)
       location /RPC2 {
                scgi_pass   <IP_ADDRESS>:5000;
                include     scgi_params;
                auth_basic "Restricted";
                auth_basic_user_file /etc/nginx/.htpasswd;
                include /etc/nginx/conf.d/php;
                include /etc/nginx/conf.d/cache;

        }

and used the following for CouchPotato:

...and for Sonarr:

For a second user you would need to add an entry for RPC3 using port 5001, and so on for additional users.
You don't need these entries just for rutorrent as their is a plugin httprpc which takes care of it for you, but obviously for other apps, you need to.
Thanks for posting the solution.

I don't believe this solution still works when trying to connect to sonarr

I have triple checked my settings, but I still get this error: "Unknown exception: Unable to connect to rTorrent, please check your settings" when I try to setup Sonarr.

Followed this but still getting "Unable to connect to rTorrent" when trying to add the client on sonarr

Followed this but still getting "Unable to connect to rTorrent" when trying to add the client on sonarr


operator project-quay (3.9.0-nightly.20230325)

Add 3.9.0-nightly.20230325 to community operators

/merge possible

/merge possible

/merge possible

/merge possible


Inconsistent Fanbox file name syntax?

[Newest release 2020-07-12, Windows 7]
Had to re-do my config from scratch, and came across an error while trying to get Fanbox naming to work.
It seems that using the %image_id% tag in the filenameformatfanboxcontent option produces this error:
2020-07-24 00:07:32,255 - PixivUtil20200712 - ERROR - Failed to read configuration.
Traceback (most recent call last):
  File "PixivUtil2.py", line 1491, in main
  File "PixivConfig.pyc", line 223, in loadConfig
  File "PixivConfig.pyc", line 34, in process_value
ValueError: ('Illegal value for', 'filenameFormatFanboxContent', ':', '%member_id% [%member_token%]\\%member_token% - %image_id%')

This was slightly difficult to figure out, because the %image_id% tag is allowed in both the filenameformatfanboxcover and filenameformatfanboxinfo fields. Perhaps they could be consistent? Or the ValueError output could identify which tag is illegal, in stead of returning the entire file name string.
It was also difficult to start tracking down, because it completely crashes the program, even when not doing anything related to Fanbox. The Failed to read configuration message appears in the init heading, but then this fatal error occurs when doing something like correctly-configured member-id downloading:
2020-07-24 00:07:59,878 - PixivUtil20200712 - INFO - Member id mode.
2020-07-24 00:08:04,288 - PixivUtil20200712 - ERROR - Unknown Error: 'NoneType' object has no attribute 'numberOfPage'
Traceback (most recent call last):
  File "PixivUtil2.py", line 1628, in main
  File "PixivUtil2.py", line 1325, in main_loop
  File "PixivUtil2.py", line 621, in menu_download_by_member_id
  File "PixivHelper.pyc", line 1033, in get_start_and_end_number
AttributeError: 'NoneType' object has no attribute 'numberOfPage'

I guess it's good to disallow illegal file naming schemes, but perhaps the program could still run its other functions if an error is made in fanbox file naming?
Anyway, guess all this isn't necessarily even a bug if one knows the peculiarities of Fanbox tag mappings, but there are some ideas about how it presents the errors to users, in any case. ^^

filenameformatfanboxcontent

From the code, you need to use %urlFilename%, %page_index%, or %page_number% in the filename format to avoid duplicated filename (in case multiple images in single post). Might need to enhance to add custom error messages in the config parser.

The Failed to read configuration message appears in the init heading, but then this fatal error occurs when doing something like correctly-configured member-id downloading:

I guess need to change the behaviour to exit if the config is not setup correctly.

Hmm.. Sorry when I changed PixivConfig.py I should have put
https://github.com/Nandaka/PixivUtil2/blob/ed9630b0eb9a582a3a1af3a0c68ece749851ecb5/PixivConfig.py#L223
inside the try...except... clause above, so the item would be set to default value if it is not "legal".

Aha! So if that is implemented, should %image_id% be usable for Fanbox?

%image_id% should be ok, it should be the post id for fanbox.

Ah ok! So to circle back to my original problem (and for anyone else looking for answer to this):
filenameformatfanboxcontent is like filenamemangaformat, and assumes posts have multiple images (even if only have 1 besides the cover/thumb). So %urlFilename% works, or %image_id% ONLY IF followed by/included with %page_index% or %page_number%.
filenameformatfanboxcover and filenameformatfanboxinfo work with %image_id% alone, I guess because they can only have a single file per post id.

The Failed to read configuration message appears in the init heading, but then this fatal error occurs when doing something like correctly-configured member-id downloading:

I guess need to change the behaviour to exit if the config is not setup correctly.

Mm nope! It already does that. When I said "fatal error" I meant that the program gives the same error as in the log, then says 'press any key to exit.' I included that more as a suggestion that an error in the fanbox subsection needn't require a mysterious error when doing something on the main pixiv site. But it sounds like @bluerthanever might have fixed that. Or indeed, more user-readable error messages with regard to config options/filename syntax would be helpful, especially if the program will exit upon any error.
PS. not worth making another issue for, but the readme (which was renamed readme.txt -> readme.md in April) was not included with the last few releases packages ^^

Another minor idea might be to highlight error and new version messages in the init headers, with a box of ASCII stars or something. Maybe putting the message last in the init, or even down by the entry cursor. When one runs this program for many years, I don't read every line of the header as it scrolls quickly by ;3

added colorama packages, so by right it should highlight the error message in red on latest commit 5044008.

Woooah, very snazzy looking! Looks like some awesome config.ini handling there too! :3
Also while on the subject (so not to make another tiny new issue #), it appears that every fanbox login re-writes the config.ini file, along with the backup. Primary pixiv login doesn't seem to do this. Maybe it's re-writing the cookie value every time, even if not altered?
Not a huge problem, but is confusing if trying to determine when I actually altered my configuration, as when I compare to every new version.

I think it need to update oAuth token, not sure the validity for that, but usually oAuth need to be refreshed every 1hour (at least that is the default for Firebase). I don't use Fanbox, so I'm not sure about that 😛
check the log file for this line Not logged in to FANBOX, trying to update FANBOX cookie. ?

Well, sometimes FANBOX cookie string would also expire, so it will retrieve a new one with the valid pixiv.net main cookie string, and update configuration.


Handle the ATW case where the client does not pass in a context

Not sure what has to happen here. Seems like we just need to create the context ourselves like normal for and D3D RenderManager. Once the ticket letting us not have to double-buffer is completed, we can test this using one of the standard D3D present applications.
This may mostly have been fixed already when refactoring the ATW class.  It may still be disallowed in the createRenderManager() function, but it probably should work.

Fixed in commit 35d5d3b32ea369d68ca06943c94c59e43a39e173 which is currently in the atw-improvements branch.


sync brew formula and current release

Hi,
would it be possible to keep release and brew formula in sync? https://formulae.brew.sh/formula/helmfile
Thanks!
Naseem

@naseemkullah Thanks for suggestion! Although I do believe the brew formula for helmfile is useful and important, unfortunately, I have no bandwidth to manually create a PR on each new helmfile release. It's so frequent!
So, would you be possible to open a PR to the formulas repo when you think you need an update?

Yes of course, thanks @mumoshu!


how to support 0-rtt at goquic's example

I have test goquic example(server and client), and i find it takes 2-rtt to fetch a page, my question is how to take 1-rtt to down a page, and connect cost 0-rtt, thanks a lot.

@hodduc


Native Notebook - Allow Extension to Set Default Diff Content

Based on our diffing QPs + diffing feedback the Jupyter extension would like to be able to make the default for notebook diffing to be to have metadata off and outputs on.

@rebornix is there an update on this item per chance?

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


增加国产数据库GoldenDB支持

希望可以增加国产数据库Goldendb的支持，目前goldendb兼容mysql，可以按照mysql处理，后续会一点点开始区分goldendb和mysql，这是第一次提交

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CI test失败，麻烦再验证下提交的代码


ISSUE-111: Fixed runtime permissions.

Upgraded runtime permissions as per https://github.com/Reedyuk/blue-falcon/issues/111
Android docs on Runtime Permissions: https://developer.android.com/training/permissions/requesting
also, see discussion on this issue here:
https://github.com/Reedyuk/blue-falcon/discussions/109

Looks good, thanks for contributing


2.0 vrf.add_*() APIs are not safe to call repeatedly with same object

Environment

Nautobot version (Docker tag too if applicable): 2.0.5
Python version:
Database platform, version:
Middleware(s):

Steps to Reproduce

Create a VRF and a Prefix in the same Namespace
Call vrf.add_prefix(prefix)
Call vrf.add_prefix(prefix) again with the same vrf and prefix

Expected Behavior
No operation on the second call, similar to calling a typical ManyToManyField .add() method

Observed Behavior
django.core.exceptions.ValidationError: {'__all__': ['Vrf prefix assignment with this Vrf and Prefix already exists.']}
Same issue appears likely for VRF.add_device and VRF.add_virtual_machine though I haven't tested those explicitly.

Same problem probably exists in dcim.Interface.add_ip_addresses


added binding syntax for marionette.js

Support of Marionette.js syntax same as for events and triggers
does not brake Backbone only usage
now bindings can have selector like<EMAIL_ADDRESS>and value for this selector gets from view.ui object
see on http://marionettejs.com/docs/v2.4.3/marionette.view.html#viewevents

Thanks for the pull but closing for the same reasons as #295.


Handle yanked gems in a clear way

Today, when a gem is yanked, we throw the exact same error as when you manually enter a version number into your Gemfile that doesn't actually exist. If a gem is yanked, we have evidence that the version used to exist (in the lockfile), and so we should be able to print an error message that is much more informative, something along the lines of:

Your bundle is locked to foo-1.2.3, but that version could not be found in any of the sources listed in your Gemfile. If you haven't changed sources, that means the author of foo-1.2.3 has removed it. You'll need to update your bundle to a different version of foo that hasn't been removed in order to install.

@RochesterinNYC I'm interested in implement this ;)

@allenzhao Go ahead, let me know if you need any help/guidance.

@RochesterinNYC Hi, I think I need a little help on where to look at. Where do you think is the correct location to handle this?

I think here might be a good place to start looking? https://github.com/bundler/bundler/blob/master/lib/bundler/definition.rb#L339

@allenzhao A good starting place might be: https://github.com/bundler/bundler/blob/master/lib/bundler/installer.rb#L183

@allenzhao How is the progress on this going?

@sstern6 Sorry, but I'm still getting familiar with the code base and working on it. It took me more than expected. So if you've already got an idea on how to work on it, please go ahead. If not, I'm trying to deliver one next week ;)

@allenzhao no worries, I am also very new to the code base and having trouble getting all tests to pass.  Just wanted to see status on your progress.  I will go try and help out on other issues.
However, if you would like to pair or work on this together feel free to email me.

@allenzhao what's your status on this? This would be a good first issue for you to fix/implement as an official GSoC student.

@RochesterinNYC I'll start to work more next week. Been busy with school stuff. Sorry for the delay


Switch to crc-universal

backwards compatible in the end?

@mafintosh Functionality is the exact same, yes, just with ARM hardware acceleration.

nice! will test it out tmw

Just Works ™


Rename rootCA to caCert

The CRD has been updated.

/merge-when-ready delete-branch

/merge-when-ready delete-branch

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it.

I'm sorry but I failed delete the branch after merging the pull request.

I'm sorry but I failed delete the branch after merging the pull request.


Add reduxDevtoolsConfig token to customize setup of Redux devtools extension

Some applications need to configure the behavior of Redux Devtools Extension. Allow customization of opting out of the setup altogether.
Resolves WPT-6128

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

+@rtsao / @ganemone

@ganemone let us know how we can get this into a canary build so we can move forward

@chrisirhc: Can you sign the contribution agreement so we can get this landed?

@chrisirhc: Can you sign the contribution agreement so we can get this landed?

Done

!land

!import


#164694219 Enable Social login via Google, Facebook and Twitter

What does this PR do?

Enable socials login and signup via google, facebook, twitter

Description of Task to be completed?

Setup social API credentials
register or login with email password combinations plus username for signup

How should this be manually tested?

Access the http://<IP_ADDRESS>:8000/acounts/login/.URL to log in then http://<IP_ADDRESS>:8000/acounts/signup/ to signup.
Login with google access http://<IP_ADDRESS>:8000/acounts/google/login/ and http://<IP_ADDRESS>:8000/acounts/facebook/login/ with facebook

Any background context you want to provide?

Setting Environmental variables builds confidence where security measures are taken.

What are the relevant pivotal tracker stories?
[ft #164694218]
Screenshots

Coverage remained the same at 93.837% when pulling 89a7ce3872dc9ec029b65a3ba8e7f05d0c7fa144 on ft-enable-social-login-via-google-164694219 into d6cee24ebf88dbfb9a846e0f25395c29467c21f1 on develop.


Allow creation of local users (non microsoft-account user)

Hey, would it be possible to specify a local user through env variables? I see you are using unattended xml files, so i guess, adjusting them and adding the needed lines for a pre-configured username+password should be possible using some kind of text file manipulation tool like sed or something.

Ohh, and btw, is the unnattend file automatically used, as i just tried reinstalling my win11 instance, deleted everything and rerun the docker run command and it seems not to be working correctly. The bypass nro feature doesnt seem to work to be precise. I tried installing windows 11 and i could only install it using a microsoft account. I tried installing the netkvm driver before and tried without it. No luck. In both situations, i was unable to get beyond the "login with your microsoft account" or the "you are not connected through the internet" message.

I had to place a custom win11 iso in the /storage folder, as i got banned by microsoft for automatic downloading. Will try without the iso

Though wouldnt it be possible to add the unattended xml even to a custom.iso file?

Maybe there could be an env variable to overwrite any existing unattended.xml for custom.iso if the version variable is set aswell? This could make it easier to identify the version of windows. Afaik the unattended options only change between larger windows updates (so 10->11) and not between smaller uipdates (11 22h2 -> 11 23h2).
Or the default behaviour could be to replace any custom.iso with the pre-configured unattended.xml if the version varialbe is set, and dont do it, if another variable is set. Something like "overwriteUnattended", which is true by default and can be set to false. So users who had to download a custom.iso due to download limitations can still use your modifications, IF they set the version parameter correctly.
I knows this would imply, that users would have to configure this correctly, but i think it might be more useful than doing nothing for custom.iso´s. But thats just my opinion :)


Add Mailer.deliver_now! and deliver_later!

Closes: https://github.com/thoughtbot/bamboo/issues/355, https://github.com/thoughtbot/bamboo/issues/409, https://github.com/thoughtbot/bamboo/issues/505
Possibly helps: https://github.com/thoughtbot/bamboo/issues/403, https://github.com/thoughtbot/bamboo/issues/346
Supersedes PR: https://github.com/thoughtbot/bamboo/pull/393
What changed?
We update deliver_now and deliver_later to not raise on errors. They now return an {:ok, email} (or {:ok, email, response} with response: true) or {:error, error}.
We also introduce deliver_now! and deliver_later! for those who liked the previous behavior. Thus, for those who don't want to change the behavior of Bamboo, it should be possible to simply replace what used to be deliver_now and deliver_later with the ! equivalents.
Those who want to handle errors can receive ok/error tuples with deliver_now and deliver_later.
Note on deliver_later and deliver_later!
deliver_later now returns an {:ok, email_to_send} or {:error, error} if there is an error in the email validations before we schedule the email sending.
If you want to keep the existing behavior, use deliver_later!. deliver_later! will raise an error if we have email validation failures before we schedule the email.
Regardless of whether you choose deliver_later or deliver_later!, TaskSupervisorStrategy raises an error because the delivery happens in a separate process. Thus the behavior of the TaskSupervisorStrategy does not change with this commit.
Note on empty recipients (not nil)
While working on this update, I noticed we do not raise an error when to, cc, bcc are all empty lists (after formatting). We decide to keep in line with this behavior, so we do not return an error in those cases either.
We do not want to raise on scenarios the recipient list is empty because that means the user of bamboo interacted with those lists. If all of those fields are nil, we do return an error or raise an error because it means the user of bamboo might not have set anything accidentally (nil is the default value for all of those). That has always been the case, and will continue to be.
Bamboo.ApiError.build_api_error for adapters
We also add a Bamboo.ApiError.build_api_error function that is the counterpart to the raise_api_error. That way, adapters can use the build_api_error function to return {:error, %Bamboo.ApiError{}} tuples instead of raising errors.
Adapter-specific PRs:

[x] SendGrid https://github.com/thoughtbot/bamboo/pull/572
[x] Mailgun https://github.com/thoughtbot/bamboo/pull/573
[x] Mandrill https://github.com/thoughtbot/bamboo/pull/574

@lady3bean

Do you think that since this is a breaking change, there should be more documentation or process when it comes to releasing this?

Yes, the plan is to do a major bump (to 2.0). Hopefully that causes people to check the changelog. My plan right now (though happy to hear alternatives) was to write a little migration guide from 1.x to 2.0, include that guide in hex docs (just like we include the readme), and link to that guide from the changelog. That way, the migration guide lives with the docs and is also discoverable from the changelog. What do you think?

@lady3bean

Do you think that since this is a breaking change, there should be more documentation or process when it comes to releasing this?

Yes, the plan is to do a major bump (to 2.0). Hopefully that causes people to check the changelog. My plan right now (though happy to hear alternatives) was to write a little migration guide from 1.x to 2.0, include that guide in hex docs (just like we include the readme), and link to that guide from the changelog. That way, the migration guide lives with the docs and is also discoverable from the changelog. What do you think?

@lady3bean

Do you think that since this is a breaking change, there should be more documentation or process when it comes to releasing this?

Yes, the plan is to do a major bump (to 2.0). Hopefully that causes people to check the changelog. My plan right now (though happy to hear alternatives) was to write a little migration guide from 1.x to 2.0, include that guide in hex docs (just like we include the readme), and link to that guide from the changelog. That way, the migration guide lives with the docs and is also discoverable from the changelog. What do you think?

That sounds great!

@lady3bean

Do you think that since this is a breaking change, there should be more documentation or process when it comes to releasing this?

Yes, the plan is to do a major bump (to 2.0). Hopefully that causes people to check the changelog. My plan right now (though happy to hear alternatives) was to write a little migration guide from 1.x to 2.0, include that guide in hex docs (just like we include the readme), and link to that guide from the changelog. That way, the migration guide lives with the docs and is also discoverable from the changelog. What do you think?

That sounds great!


ipad does not see msfs but iphone does

Occasionally I can see msfs as a device on my ipad pro v15.5 and I can usually see it on my iphone, but most of the time it won't display as a device in FF even though the IP for my FF is correct in FS2FF.  You mentioned making sure a port was not blocked.  How do I ensure that?

Try to see if you have Local Network enabled on the iPad (Settings -> Privacy -> Local Network).

Yes, it is.  ForeFlight is selected.  Like I said, it sometimes works, it seems that if I'm careful about when I open FS2FF and the tablet.  Is there a way to do it where it's not so tempermental?

While I don't see FS2FF on my iPad, it's working just fine on my iPhone.


transparent background

Is it possible to make the background transparent, so you can see how long the line is below the map

Maybe it's a option.

I think this is something that should be resoved through CSS rather than with an option, the new v4 version is using the flex layout of the editor to position itself properly. To achieve what you ask it's necessary to make the minimap out of the flow (position: absolute) so that the editor can flow below it.
But this can be true only when the minimap is displayed on the right.

ah ok, so its not an overlay its a new pane on the right side.

Exactly, the v3 was behaving like an overlay, but it was clearly suboptimal given that the default behavior users were expecting was that the editor doesn't flow below the minimap.

Closing it for now as there's no real solution for that.

What if we just set a z-index : -1  for the minimap?

Tried it, didn't work as simply as I'd hoped : (


Add verisure ethernet status

Breaking Change:
No breaking change
Description:
Add a binary_sensor to know the ethernet connection status.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11135
Example entry for configuration.yaml (if applicable):
verisure:
  username: USERNAME
  password: PASSWORD
  ethernet_status: true/false

Checklist:

[X] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[X] Tests have been added to verify that the new code works.

The first impression, while reviewing the documentation, why add an option to enable/disable this sensor?
Is there a problem with having it always enabled?

Hi,
there is no problem with having it always enabled. It doesn't require any extra queries to verisure API.
I just wanted to keep the same behavior (like door_windows, smartplugs etc.)

We don't allow config options anymore that control what entities to create. There are some exceptions to that rule, like the one mentioned.
https://github.com/home-assistant/architecture/blob/master/adr/0003-monitor-condition-and-data-selectors.md

Ah sorry my bad.
I removed the option, I guess I can drop the PR for the doc ?

The branch now contains many unrelated commits. Please rebase and remove the stray commits or start over in a fresh branch and PR.

So, it should be ok now.
What is the problem with CheckFormat ?

Please run black code formatter from the project root.
black --fast homeassistant tests

Please update the config example in the PR description to not include the option.

Please update the config example in the PR description to not include the option.

Done !
Thanks for your input :)


3.0 - Final Phase, stage continued

This pull-request introduce a demonstrative Module called Demo, which contains our Demo Controllers and complete the support for Hooks Legacy/Compatibility Layer in \Nova\Events\Manager, using, of course, the Events API.
To note that we do not recommend the use the EventManger's HLCL, instead we strongly suggest to port the existent code to the much more powerful native Events API, that HLCL existing only as quick&dirty solution to port the existing code to Nova Framework.
The usage of HLCL is simple. The Hooks should be registered using:
EventManager::addHook("topnav", "\Modules\Broadband\Controllers\Broadband@nav");

And to run a Hook, we have:
$args = '';

$topnav = EventManager::runHook("topnav", $args);

Also, there exists a Hook existing checking method, called hasHook, who, similar with hasEvent, return true when one or more Listeners are registered  to this Hook and can be used as:
if(EventManager::hookHook("topnav")) {
    // do shiny things there about TOPNAV
}

To note that, in comparation with the original Hooks helper, being written on top of Events API, there are some subtle differences on HLCL, for example, there are no Hook Domain, literally a Hook "where" being an Event Name.
Also, as difference to native Event deploying, the HLCL pass to the Listener Method, as argument, the  Result, in loop, similar with the original Hooks Helper style.
Module demonstration
With this pull-request, our Demos are moved, like I said, in a Module called Demo, who have also the role to demonstrate the Design of a Module on the Framework, after we introduced our enhancements.

Let me know when to merge.

@daveismyname OKay, Dave!

@daveismyname Please, merge this pull-request, being complete as objectives! :smile:
I will open another devel pull-request in short time... :smirk:


finished challenges showing up in Find Challenges list

Example https://maproulette.org/browse/challenges/5254 has no open tasks but still appears in a search https://maproulette.org/browse/challenges?query=rheinland

It used to be that when a challenge was rebuilt via overpass but there were no results, the challenge would end up with no tasks but not actually marked as finished, so we could end up with these open challenges with no tasks. That was fixed in v3.7.0 going forward, but not applied retroactively.

Related to #986


Add c_int-based tests to increase coverage

Changes Unknown when pulling 18bd6b792a330ccb01d791a4cbb12af8e4563ee3 on develop into ** on master**.

Changes Unknown when pulling 21aa23d2731ffea2f55c7b9d69d246b562d0fa54 on develop into ** on master**.