fixed overlapping

Description
Fixed overlapping of the services page
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Closes #868

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have performed a self-review of my code
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

Why navbar got misaligned?

Is there any large gap after first section to second section in service page?

Is there any large gap after first section to second section in service page?

I don't think so. I just checked the deploy preview it looks as expected. However if you want changed you can let me know @varshith257

Is home also got misaligned? I am viewing it in mobile can't able to understand what happened

Is home also got misaligned? I am viewing it in mobile can't able to understand what happened

No the homepage is fine. @varshith257

Ok, will review this PR later as code changes are more

Ok, will review this PR later as code changes are more

Okay thank you so much. I've  many open pull requests in this repo. If you get time please review them too #869 & #842


Remove existing CREATE2 deployments from script

Component
Forge
Describe the feature you would like
This feature would allow developers to use solidity-native create2 deployments (by calling new Contract{salt: salt}() without needing to build workaround solutions for whether the contract already exists.
One solution would be that you manually calculate the CREATE2 address, such as through the code below:
keccak256(abi.encodePacked(bytes1(0xff), address(this), salt, keccak256(abi.encodePacked(
    type(MyContract).creationCode,
    abi.encode(<constructor params>)
))));

Then check if code exists at this address and finally, if no code exists, deploy the contract.
Currently, when trying to create a contract the above way without the workaround, it will fail if the deployment fails. There is an existing issue on the solidity repo (https://github.com/ethereum/solidity/issues/13521) which kind of attempts to achieve the same goal. However, in the context of Solidity it seems like this feature will not be implemented anytime soon (for understandable concerns mentioned on the issue. In the context of a Foundry script, it could make sense to replace these failing creations with the address at which the contract has already been created.
Additional context
No response

Marking as out of scope
It is expected that the user handles this in their script if they rely on this functionality
https://book.getfoundry.sh/tutorials/create2-tutorial#create2-factory


Merge matterport_ga branch to main

What this PR does / why we need it:
Prepare main for release of new features: data overlay, tag resize, matterport integration
Which issue(s) this PR fixes:
None
Fixes #
Special notes for your reviewer:

Hi there, I'm noticing an error on the Video Player that I don't see on main
TypeError: (0 , aws_sdk_service_error_classification__WEBPACK_IMPORTED_MODULE_1_.isServerError) is not a function

great!


Fix for issue "Suspend causes oxide to crash on RM2 #113"

Any chance you could work on testing the timings soon?

Tested this build with rm2fb shim with the two attached files (the first is solid grey, the second is noisy), and it works fine for me (compared to the toltec build which does crash).

Waking could also be #97
What timing are you using where it doesn't have enough time? And is it for both images or just one?

That's with this artifact: https://github.com/Eeems/oxide/pull/114/checks?check_run_id=1623126791 which I think is 0.6s. I only noticed it on the solid grey screen, though it wasn't happening consistently (just got it to render fine) so it could also be an issue on the noisy one. I'll run it a few more times to see. I did notice a little ghosting on the noisy image along the top bar that doesn't seem to appear when I suspend with xochitl.
#97 seems right, though I've actually had it happen where the SSH either does or doesn't respond after the wake. It could just be that I'm fiddling with the power button and re-suspending it without realizing.

ahh this is frustrating, I just got it to render the grey image correctly 15 times in a row, can't seem to reproduce the broken render now. I do think if there's any way to get rm2fb to send a "finished drawing" signal, that's the right way to do this. Otherwise we'll have to cater to the 99th percentile of draw times, which isn't even going to be consistent for one device with one suspend screen.

ahh this is frustrating, I just got it to render the grey image correctly 15 times in a row, can't seem to reproduce the broken render now. I do think if there's any way to get rm2fb to send a "finished drawing" signal, that's the right way to do this. Otherwise we'll have to cater to the 99th percentile of draw times, which isn't even going to be consistent for one device with one suspend screen.

I've asked for the ability to wait for drawing to finish. Just waiting to see if @ddvk or @raisjn figure out how to make it work properly with the current API

@SyntaxBlitz, @Witos, or @raisjn would you be able to test this PR to see if it'll work properly on a rM2? I think we might even be able to get away with removing the nanosleep call if EPFrameBuffer::waitForLastUpdate(); actually works under rm2fb

@SyntaxBlitz, @Witos, or @raisjn would you be able to test this PR to see if it'll work properly on a rM2? I think we might even be able to get away with removing the nanosleep call if EPFrameBuffer::waitForLastUpdate(); actually works under rm2fb

Thanks @PeterGrace for testing!

Thanks @PeterGrace for testing!


Copy event

Eventin voi kopioida ja siirtää raahaamalla kirjautuneena käyttäjänä.
Eventtiä ei voida siirtää jos sillä on varauksia.

Codecov Report

Merging #118 (8cc60f1) into main (004b864) will increase coverage by 49.17%.
The diff coverage is 76.76%.

@@             Coverage Diff             @@
##             main     #118       +/-   ##
===========================================
+ Coverage   28.13%   77.30%   +49.17%
===========================================
  Files          24       17        -7
  Lines         654      520      -134
  Branches      181       65      -116
===========================================
+ Hits          184      402      +218
+ Misses        416      108      -308
+ Partials       54       10       -44

Flag
Coverage Δ

backend
77.30% <76.76%> (+1.90%)
:arrow_up:

frontend
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

backend/models/event.js
66.66% <ø> (ø)

backend/models/visit.js
60.00% <ø> (ø)

backend/models/extra.js
60.00% <60.00%> (ø)

backend/models/formSubmissions.js
60.00% <60.00%> (ø)

backend/models/forms.js
60.00% <60.00%> (ø)

backend/graphql/resolvers.js
69.25% <64.78%> (-7.27%)
:arrow_down:

backend/services/mailer.js
90.90% <87.50%> (-9.10%)
:arrow_down:

backend/utils/mailSender.js
89.18% <89.18%> (ø)

backend/graphql/typeDefs.js
100.00% <100.00%> (ø)

backend/tests/testData.js
100.00% <100.00%> (ø)

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c23647...8cc60f1. Read the comment docs.


Catalog2Registration throw NullReferenceException

mylog.txt

Theory: The success rate for blob storage is between 60%-80%. According to logs, there is an often failure to load a registration blob, and same blob time after time. The job progress continues when the cursor is moved away from the failing blob.
Next steps: better error messages for storage errors, retries for storage access

Issue has been resolved. The success percentage may be related to 404's (and in turn to this: https://github.com/NuGet/Home/issues/2038)


exploitdb: 2023-05-19 -> 2023-05-24

Description of changes
update to 2023-05-24
commit tagged as 2023-05-24: https://gitlab.com/exploit-database/exploitdb/-/commit/0a7adaa3fcdd8a907b3f89e0fdfc59ab67f6ffab

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233713 run on x86_64-linux 1

1 package built:

exploitdb


Use resources as bower package instead of copying them to repository

There's a bower package you can use.

I'm waiting for author to add bower so I can use it https://github.com/GetmeUK/ContentTools/issues/29
(unless there is a method to do this without him)

Make a pull request. It will speed things up. Also check https://hacktoberfest.digitalocean.com/ ;)

Cheers :)


Minor bugfix

The previous code was generating an error when the try/except clause was being invoked, and job_status wasn't ever defined

I would prefer a different approach, but have resolved the bug


upload syslog-migration link is broken

Forth step is incorrect
4.upload syslog-migration release 11
bosh upload-release https://github.com/pivotal-cf/syslog-migration-release/releases/download/v8/syslog-migration-11.tgz
Link https://github.com/pivotal-cf/syslog-migration-release/releases/download/v8/syslog-migration-11.tgz  is broken. This release has been depricated in favor of syslog-release.
Also "ops-file adds a GCP specific vm_extension: public_ip" there is no public_ip properties for gcp vm_extention.
https://bosh.io/docs/google-cpi/#vm-types

Hi @SergeyMuha
This is much appreciated feedback. We've, sadly, let our README get out of date and there was delay between how we changed things with the syslog release and the public_ip vm extension.
I've updated the README to reflect that.
Thank you for bringing these to our attention and we'll try to be better open source citizens going forward!


Replace connection-string.png for the service bus docs

#26020

@L-Dogg : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Thank you @L-Dogg
#sign-off

@spelluru: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


docs: add inference refs (Torchserve, TGI Benchmark, Raycast)

Add inference references :

TorchServe is a PyTorch official serving infrastructure, highly integrated in kubernetes-based environments, robust and scalable.
TGI Benchmarks overviews the configuration of TGI for performance optimization, but this video is not easy to find on YouTube. This should help choosing and optimizing production setups.

Other :

Raycast. I couldn't find a fitting category for this one, but my guess is that could help developers used to ollama usage extending its capabilities to apps outside of the terminal. The initial app doesn't seem open source, but all community extensions are.

Thank you! ^_^

Thanks for this repo! If it's okay, I might suggest additions from time to time.


Add docs for Drill Metastore

Add Drill Metastore documentation (note: no Jira is required since this is updated to the Drill site).

@vvysotskyi overall good regarding analyze command but I think we need to add more info about Drill Metastore notion in general. I suggest we create separate section where we'll describe what is Drill Metastore, how to configure it, which one is used by default. Plus add examples, how all these including analyze command is used together (create table, collect metadata, show that it is present via info schema tables, show that is is used when executing the query in query plan etc).

@paul-rogers is anything else @vvysotskyi need to address? Could you please take a look?

Tested HTML build locally. Merging and I'll build and publish the site.

@bbevens that for merging the changes but I don't think @paul-rogers has finished the review. Vova has addressed code review changes but Paul could not a chance to review the changes...

oh no...sorry...I thought the doc was complete. Should I remove the Iceberg Metastore topic from the site?

@arina, @bbevens, no harm done. As Bridget knows, I can keep reviewing docs forever.
In fact, it is probably better to review the docs outside of Git: far too many messages get sent to the dev list if we do the review in Git.
Maybe just do a second PR with the next round of revisions.

I'll open a new PR with addressed CR comments soon.


pnpm build fail, windows 目录文件路径过长导致构建错误

Describe the bug
构建错误
  • electron-builder  version=24.13.3 os=10.0.22631
  • loaded configuration  file=F:\_REMOVE_\test123000000000000001\electron-builder.yml
  • writing effective config  file=dist\builder-effective-config.yaml
  • skipped dependencies rebuild  reason=npmRebuild is set to false
  • packaging       platform=win32 arch=x64 electron=31.3.0 appOutDir=dist\win-unpacked
  • building        target=nsis file=dist\dev-client-1.0.0-setup.exe archs=x64 oneClick=true perMachine=false
  ⨯ C:\Users\_REMOVE_\AppData\Local\electron-builder\Cache\nsis\nsis-<IP_ADDRESS>\Bin\makensis.exe process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
Exit code:
1
Output:
Command line defined: "APP_ID=com.electron.app"
Command line defined: "APP_GUID=_REMOVE_"
Command line defined: "UNINSTALL_APP_KEY=_REMOVE_"
Command line defined: "PRODUCT_NAME=dev-client"
Command line defined: "PRODUCT_FILENAME=dev-client"
Command line defined: "APP_FILENAME=dev-client"
Command line defined: "APP_DESCRIPTION=An Electron application with Vue and TypeScript"
Command line defined: "VERSION=1.0.0"
Command line defined: "PROJECT_DIR=F:\_REMOVE_\test123000000000000001"
Command line defined: "BUILD_RESOURCES_DIR=F:\_REMOVE_\test123000000000000001\build"
Command line defined: "APP_PACKAGE_NAME=dev-client"
Command line defined: "MUI_ICON=F:\_REMOVE_\test123000000000000001\build\icon.ico"
Command line defined: "MUI_UNICON=F:\_REMOVE_\test123000000000000001\build\icon.ico"
Command line defined: "APP_64=F:\_REMOVE_\test123000000000000001\dist\dev-client-1.0.0-x64.nsis.7z"
Command line defined: "APP_64_NAME=dev-client-1.0.0-x64.nsis.7z"
Command line defined: "APP_64_HASH=_REMOVE_"
Command line defined: "APP_64_UNPACKED_SIZE=300029"
Command line defined: "COMPANY_NAME=example.com"
Command line defined: "APP_INSTALLER_STORE_FILE=dev-client-updater\installer.exe"
Command line defined: "COMPRESSION_METHOD=7z"
Command line defined: "ONE_CLICK"
Command line defined: "RUN_AFTER_FINISH"
Command line defined: "SHORTCUT_NAME=dev-client"
Command line defined: "UNINSTALL_DISPLAY_NAME=dev-client"
Command line defined: "RECREATE_DESKTOP_SHORTCUT"
Command line defined: "ESTIMATED_SIZE=300028"
Command line defined: "COMPRESS=auto"
Command line defined: "BUILD_UNINSTALLER"
Command line defined: "UNINSTALLER_OUT_FILE=F:\_REMOVE_\test123000000000000001\dist\__uninstaller-nsis-dev-client.exe"
Processing config: C:\Users\_REMOVE_\AppData\Local\electron-builder\Cache\nsis\nsis-<IP_ADDRESS>\nsisconf.nsh
Processing script file: "<stdin>" (UTF8)

Error output:
!include: could not open file: "F:\_REMOVE_\test123000000000000001\node_modules\.pnpm\app-builder-lib@24.13.3_dmg-builder<EMAIL_ADDRESS>Error in script "<stdin>" on line 87 -- aborting creation process
  failedTask=build stackTrace=Error: C:\Users\_REMOVE_\AppData\Local\electron-builder\Cache\nsis\nsis-<IP_ADDRESS>\Bin\makensis.exe process failed ERR_ELECTRON_BUILDER_CANNOT_EXECUTE
Exit code:
1
Output:
Command line defined: "APP_ID=com.electron.app"
Command line defined: "APP_GUID=_REMOVE_"
Command line defined: "UNINSTALL_APP_KEY=_REMOVE_"
Command line defined: "PRODUCT_NAME=dev-client"
Command line defined: "PRODUCT_FILENAME=dev-client"
Command line defined: "APP_FILENAME=dev-client"
Command line defined: "APP_DESCRIPTION=An Electron application with Vue and TypeScript"
Command line defined: "VERSION=1.0.0"
Command line defined: "PROJECT_DIR=F:\_REMOVE_\test123000000000000001"
Command line defined: "BUILD_RESOURCES_DIR=F:\_REMOVE_\test123000000000000001\build"
Command line defined: "APP_PACKAGE_NAME=dev-client"
Command line defined: "MUI_ICON=F:\_REMOVE_\test123000000000000001\build\icon.ico"
Command line defined: "MUI_UNICON=F:\_REMOVE_\test123000000000000001\build\icon.ico"
Command line defined: "APP_64=F:\_REMOVE_\test123000000000000001\dist\dev-client-1.0.0-x64.nsis.7z"
Command line defined: "APP_64_NAME=dev-client-1.0.0-x64.nsis.7z"
Command line defined: "APP_64_HASH=_REMOVE_"
Command line defined: "APP_64_UNPACKED_SIZE=300029"
Command line defined: "COMPANY_NAME=example.com"
Command line defined: "APP_INSTALLER_STORE_FILE=dev-client-updater\installer.exe"
Command line defined: "COMPRESSION_METHOD=7z"
Command line defined: "ONE_CLICK"
Command line defined: "RUN_AFTER_FINISH"
Command line defined: "SHORTCUT_NAME=dev-client"
Command line defined: "UNINSTALL_DISPLAY_NAME=dev-client"
Command line defined: "RECREATE_DESKTOP_SHORTCUT"
Command line defined: "ESTIMATED_SIZE=300028"
Command line defined: "COMPRESS=auto"
Command line defined: "BUILD_UNINSTALLER"
Command line defined: "UNINSTALLER_OUT_FILE=F:\_REMOVE_\test123000000000000001\dist\__uninstaller-nsis-dev-client.exe"
Processing config: C:\Users\_REMOVE_\AppData\Local\electron-builder\Cache\nsis\nsis-<IP_ADDRESS>\nsisconf.nsh
Processing script file: "<stdin>" (UTF8)
     Error output:
!include: could not open file: "F:\_REMOVE_\test123000000000000001\node_modules\.pnpm\app-builder-lib@24.13.3_dmg-builder<EMAIL_ADDRESS>Error in script "<stdin>" on line 87 -- aborting creation process
         at ChildProcess.<anonymous> (F:\_REMOVE_\test123000000000000001\node_modules\.pnpm\builder-util@24.13.1\node_modules\builder-util\src\util.ts:252:14)
    at Object.onceWrapper (node:events:632:26)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess.cp.emit (F:\_REMOVE_\test123000000000000001\node_modules\.pnpm\cross-spawn@7.0.3\node_modules\cross-spawn\lib\enoent.js:34:29)
    at maybeClose (node:internal/child_process:1098:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:303:5)

解决方案：
.npmrc 目前还需要添加该设置才能解决兼容性。
node-linker=hoisted

pnpm: 9.6.0
资料：
https://github.com/nodejs/node/issues/50753#issuecomment-2039791858
Electron-Vite Version
2.3.0
Electron Version
31.3.0
Vite Version
5.3.1
Validations

[X] Follow the Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

脚手架默认已有配置

脚手架默认已有配置

我初始化脚手架的配置只有
electron_mirror=https://npmmirror.com/mirrors/electron/
electron_builder_binaries_mirror=https://npmmirror.com/mirrors/electron-builder-binaries/
shamefully-hoist=true

补上这个才成功的
node-linker=hoisted

脚手架默认配置

我初始化脚手架的配置只有
electron_mirror=https://npmmirror.com/mirrors/electron/
electron_builder_binaries_mirror=https://npmmirror.com/mirrors/electron-builder-binaries/
shamefully-hoist=true

补上这个才成功的
node-linker=hoisted

大佬 请问下我补上了这个还是同样的问题 还请您指导一下

脚手架默认配置

我初始化脚手架的配置只有
electron_mirror=https://npmmirror.com/mirrors/electron/
electron_builder_binaries_mirror=https://npmmirror.com/mirrors/electron-builder-binaries/
shamefully-hoist=true

补上这个才成功的
node-linker=hoisted

大佬请问下我补上这个还是同样的问题还请您指导一下
node：18.0.2
pnpm：9.0.6

大佬请问下我补上这个还是同样的问题还请您指导一下 node：18.0.2 pnpm：9.0.6

我的npmrc配置，环境 node: 20.17.0; electron: 31.7.3; pnpm: 9.x
electron_mirror=https://npmmirror.com/mirrors/electron/
electron_builder_binaries_mirror=https://npmmirror.com/mirrors/electron-builder-binaries/
shamefully-hoist=true
node-linker=hoisted

建议把完整错误找出来贴一下。


Reapply changes to Welsh Individual po originally made in PR2296

As per title.. this was inadvertently regressed.

 Add Welsh individual PO file (S)


Some of the format read commands are ill advised.

                b0 = (byte)stream.read();
                if (stream.available() <= 0) {
                    break;
                }
                b1 = (byte)stream.read();

This bit from FormatExp for example. The .available function tells how many bytes are left before it has to do a blocking read. But, you want a blocking read. You want to keep reading things until there's no bytes left in the stream and read returns a -1. If for some reason a loading stream had to hit a block this would kill the reading rather than wait a bit for more data. That's an error.
Or for example in FormatDst:
                if(stream.read(b) != 3) {
                    break;
                }

This could as a quirk if the stream looses some bytes give you 2 bytes, then block and read the next time around. Which would give you 2 good bytes, a byte of gibberish and the next triplet of dst code will be total gibberish forever. Moving forward.
If the DataInputStream thing is off the table, might I recommend adding a function to the BinaryHelper to readFully()
    public static int readFully(InputStream in, byte[] data) throws IOException {
        int offset = 0;
        int bytesRead;
        boolean read = false;
        while ((bytesRead = in.read(data, offset, data.length - offset)) != -1) {
            read = true;
            offset += bytesRead;
            if (offset >= data.length) {
                break;
            }
        }
        return (read) ? offset : -1;
    }
    public static int readInt32BE(InputStream stream) throws IOException {
        byte fullInt[] = new byte[4];
        readFully(stream, fullInt);
        return (fullInt[3] & 0xFF) + ((fullInt[2] & 0xFF) << 8) + ((fullInt[1] & 0xFF) << 16) + ((fullInt[0] & 0xFF) << 24);
    }

Things like reading a bigendian int, could also, if the stream isn't all there, read 3 bytes rather than 4 and give you gibberish. Basically outside of a context of loading from file on disk, this code hits problems. Streaming a file from the net doesn't work, and reading from a zip file doesn't work either. They both stutter the stream and then corrupt things.
Also, though minor the PES isn't flagged as a writer, though I checked it and it totally seems to do solid output. I'm trying to get the last critical parts of my next Touch Embroidery release done, and combating some of these same issues. ( I wrote a couple easy wrappers for the formatting differences and basically can drop the functionality in. )

The code built into the EmbReader class could properly fix this issue. It's still a thing and still wrong.
https://github.com/Embroidermodder/MobileViewer/pull/75


Improve interpolation performance

replace scipy.interpolate.RegularGridInterpolator by scipy.ndimage.map_coordinates for a substantial improvement
of binning performance with momentum correction
Closes #357

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 91.538%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
5982

Relevant Lines:
6535

💛  - Coveralls

I tested this again on the maxwell jhub, and there the speedup is really tremendous. Old version is ~70-80 s per iteration, new is 10:

And indeed, both produce identical results.

It isn't quite clear to me why the map_coordinates is faster than scipy's interpolate method. But of course, those are seperate modules and seem to have very different implementations.
The parallelization is a nice addition. Everything seems good

For comparison of different methods see e. g. here: https://stackoverflow.com/questions/53857403/scipy-interpolation-speed-is-there-anything-faster-than-rectbivariatespline


Bug: App Crash after "Time-Left" Button was clicked

The app crashes when the view is still loading and one presses the "Time-Left" button in the bottom right corner.

Implemented and merged


Remove unnecessary caching in plan_inv of test plans

There is no need to do the caching in plan_inv as it should be handled by AbstractFFTs. The current logic leads to the following error which is now fixed.
julia> using AbstractFFTs
[ Info: Precompiling AbstractFFTs [621f4979-c628-5d54-868e-fcf4e3e8185c]

julia> using AbstractFFTs: Plan

julia> include("test/testplans.jl")

julia> p = plan_fft(rand(3))
TestPlan{ComplexF64, 1}(1:1, (3,), #undef)

julia> inv(inv(p).p)
ERROR: TypeError: in typeassert, expected AbstractFFTs.ScaledPlan{ComplexF64, TestPlan{ComplexF64, 1}, ComplexF64}, got a value of type TestPlan{ComplexF64, 1}
Stacktrace:
 [1] inv(p::InverseTestPlan{ComplexF64, 1})
   @ AbstractFFTs ~/repos/AbstractFFTs.jl/src/definitions.jl:237
 [2] top-level scope
   @ REPL[5]:1

as it should be handled by AbstractFFTs

Can you explain this?

It seems like the inv function in AbstractFFTs (lines 237-238 in the main branch currently) wraps plan_inv and takes care of the caching in pinv automatically, so plan_inv should be a pure function that just constructs the inverse plan

Ah, I see now that those lines were pre-caching pinv for the inverse plan, not the original plan.
Nevertheless, given how the caching is implemented in AbstractFFTs, I don't think we are allowed to do that (as evidenced by the error). In particular, plan_inv is expected to output the same type as the pinv field, because of that hack being done in pinv_type.
So the simplest solution seems to be to get rid of those lines (such that the inverse is not cached automatically for inv(p)), which matches what is done in FFTW.

I agree that ideally that hack shouldn't be necessary. But shouldn't that be left to a separate PR? i.e. this discussion seems to be more appropriate for https://github.com/JuliaMath/AbstractFFTs.jl/issues/20
All this PR is doing is getting the test plans to conform to whatever the current design of AbstractFFTs expects plans to do: namely, have a pinv field but do not do anything with it, as this is required for tests to pass in https://github.com/JuliaMath/AbstractFFTs.jl/pull/67.

All this PR is doing is getting the test plans to conform to whatever the current design of AbstractFFTs expects plans to do: namely, have a pinv field but do not do anything with it, as this is required for tests to pass in #67.

I don't see where the API and implementation of AbstractFFTs disallows setting the inverse of the inverse in plan_inv. Even more so since the field for the inverse is not concretely typed, so there are no issues with type parameters either. Therefore I think that even with the current, probably suboptimal design it should not be necessary to remove it from the tests. I assume the issue is not that pinv is set but rather that it is set incorrectly - as it does not seem to confirm with the pinv_type that AbstractFFT expects. Probably related to the scaling since that would also explain why it expects a ScaledPlan and complains that it only got an TestPlan.

Okay. Tonight (or time zone agnostically, in 10 hours) I'll take a stab at modifying things so that pinv_type works, but without removing the caching.

As you suggested, there was a correctness issue with the plan caching, and fixing that without removing the caching works. I've updated the PR description accordingly.


[RFC][Devbox] computeEnv: remove __ETC_PROFILE_NIX_SOURCED=1

Summary
This was introduced in #635 (cc @ipince). I don't think its needed anymore.
It seems to be used in the /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh script, at the very top to prevent re-execution:
  1 # Only execute this file once per shell.
  2 if [ -n "${__ETC_PROFILE_NIX_SOURCED:-}" ]; then return; fi
  3 __ETC_PROFILE_NIX_SOURCED=1
  4

Perhaps it has other use-cases as well? RFC.
From my casual usage of a Devbox binary built with this change, it all seems to still work fine.
How was it tested?

I can't remember why this was explicitly added either. Does nix-daemon.sh still only run once in devbox shell and devbox shell --pure? I think a good way to check is to see if there are duplicate paths in NIX_PROFILES.

My observations.
# start with devbox global
 % env | grep NIX_PROFILE
NIX_PROFILES=/nix/var/nix/profiles/default /Users/savil/.nix-profile

# go to devbox repo and start the shell
% cd ~/code/jetpack/devbox
% devbox shell
Starting a devbox shell...
 % env | grep NIX_PROFILE
NIX_PROFILES=/nix/var/nix/profiles/default /Users/savil/.nix-profile

no duplicates

Thanks for double checking!


Nested optgroups

Make support of nested optgroups

Would be nice to have it

I really need this one right now 👍

This is an alternative hack for now
https://jsfiddle.net/caddydz/zxcr0yx2/

This is something I would like to add, but currently nested optgroups are not supported by browsers. A potential workaround would be to add support for a data-group attribute on each optgroup. Example:
<select class="form-control">
	<optgroup label="Egypt" data-group="Africa">
		<option value="" style="margin-left:23px;">Alexandria</option>
		<option value="">Cairo</option>
	</optgroup>
	<optgroup label="Morocoo" data-group="Africa">
		<option value="">Casablanca</option>
		<option value="">El Rabat</option>
	</optgroup>
	<optgroup label="USA" data-group="North America">
		<option value="">New York</option>
		<option value="">Nashville</option>
	</optgroup>
	<optgroup label="Canada" data-group="North America">
		<option value="">Toronto</option>
	</optgroup>
</select>

+1

This is something I would like to add, but currently nested optgroups are not supported by browsers. A potential workaround would be to add support for a data-group attribute on each optgroup.
Any thoughts when this feature will be published, since multi level trees are really common nowadays?

Wait a couple of years maybe


load and save buttons regression in 0.2.6

Dear Robert, thank you for this incredible tool, it is changing everything in how to share my work with my colleagues in the lab !
I have updated today to releas 0.2.6 and the "load" and "save" buttons are not working anymore... back to release 0.2.5 it works perfect... (I have uninstalled the release 0.2.6 with the napari tool and re install with pip "install git+git:// ... @0.2.5")
All the best and happy new year...

Hi Leon @leec13 ,
thanks for reporting this issue! I also discovered that with @jo-mueller just today. I just uploaded version 0.2.7 where the buttons should work again. If one of you two could just try and confirm, we can close this issue here.
Thanks again!
Best,
Robert

Hello ! Its is working perfect in release 0.2.7
(Mac OS 10.15.7  Napari installed in conda environment with python 3.9)
All the best !
Leon
PS. Humm, what about a "scripts" site ? Like imagej/plugins page ?
Leon Espinosa
@.***
Equipe IAM
Instruments et Analyses pour le Microbiologie
LCB CNRS UMR 7283
31, Chemin Joseph AIGUIER
13009 MARSEILLE
Tel : 04 91 16 45 13
Cell : 06 79 25 97 40
Tel sécr.: 04 91 16 40 77
Fax : 04 91 71 89 14

Le 3 janv. 2022 à 16:00, Robert Haase @.***> a écrit :
Hi Leon @leec13 https://github.com/leec13 ,
thanks for reporting this issue! I also discovered that with @jo-mueller https://github.com/jo-mueller just today. I just uploaded version 0.2.7 where the buttons should work again. If one of you two could just try and confirm, we can close this issue here.
Thanks again!
Best,
Robert
—
Reply to this email directly, view it on GitHub https://github.com/haesleinhuepf/napari-script-editor/issues/6#issuecomment-1004149435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUZNL7T3K3F3LAXICZ42ATUUG2X7ANCNFSM5LFES2IQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.

Thanks for checking!

PS. Humm, what about a "scripts" site ? Like imagej/plugins page ?

If you have a script that could be of general interest, feel free to send it as github pull-request to this repository/folder:
https://github.com/haesleinhuepf/napari-script-editor/tree/main/example_scripts
If it's a more complex thing, I would recommend turning it into a proper napari-plugin, e.g. using the cookie cutter:
https://github.com/napari/cookiecutter-napari-plugin
You can then publish the plugin on the napari hub: https://napari-hub.org
Let me know if you need assistance with cookie cutting ;-)

Thanks !

If you have a script that could be of general interest,

I have started to code some simple commands like "image_invert", "intensity under shapes", "crop under shape", that I need when I forgot to prepare/pre-process my image  for a specific plugin. I will see if they are stable enough to share with the community.

Cool to hear @leec13 !

I have started to code some simple commands like "image_invert"

You may have seen that already, "invert image" is a command also contained in napari-segment-blobs-and-things-with-membranes (nsbatwm), napari-simpleitk-image-processing and napari-pyclesperanto-assistant:

In the assistant, it has a different name, its "subtract image from scalar":

"crop under shape"

Some collaborators are working on this in napari-crop. I bet they would be happy about feedback if this works or doesn't work for your usecase!

"intensity under shapes"

I'm not sure what this does, so again, feel free to send a PR or turn it into a plugin. The more useful examples, the better. And: nobody else has to program it if you publish it open source :-)

👍 !


Make a new release with latest code

Hello! :wave:
Was wondering if it was possible to make a new 1.x release with the latest code.
Last one is from Aug 2021. :thinking:

I guess it's a question about the status of the repository that seems to be abandonned

There's nothing new in the repo that would warrant a release. New isn't always better, localForage should still work fine 😏


PR explanation

It would be nice if SL had an explanation about PRs im the help section.
Like, I am a noob and I don't really know what it does, but people keep suggesting I should use them, but when I try, it says it will clone the repo, which does not sound like something I want, but I have no idea.

Yes. You fork the repo actually (Github does) and you commit your modifications to your repo, then you open a PR from your repo with these changes to the original repo for integration in there.
Read about how Github works.

That's what I thought, but I wasn't sure. It wouldnbe nice if you influded that text (more or less) in the current help.
On June 5, 2018 7:58:16 AM GMT+02:00, Licaon_Kter<EMAIL_ADDRESS>wrote:

Yes. You fork the repo actually (Github does) and you commit your
modifications to your repo, then you open a PR from your repo with
these changes to the original repo for integration in there.
Read about how Github works.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/LonamiWebs/Stringlate/issues/227#issuecomment-394591045

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Which is the point of this issue.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Sorry for noobing around, just wanted to be sure.
Sent from my Android device with K-9 Mail. Please excuse my brevity.


KAFKA-8985; Add flexible version support to inter-broker APIs

This patch adds flexible version support for the following inter-broker APIs: ControlledShutdown, LeaderAndIsr, UpdateMetadata, and StopReplica.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

3 flaky failures in one build and the other 2 failed with what looks like an unrelated exception.

org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testAddAndRemoveWorker
kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
kafka.api.SslAdminClientIntegrationTest.testCreateTopicsResponseMetadataAndConfig

retest this please

A minor note, can we please mention in the PR description that we removed the version checking because the generated Data classes do that already?


FailoverClustering Bulk Fixup (3/4) - Line formatting updates

Bulk reflowed text and header formatting update before applying further quality updates.
This will be followed by separate PRs for
1. Text formatting updates
a. Bulk formatting checklist update before applying further quality updates:
- cmdlet name - Change bolds to code spans
- cmdlet/vars - Change bar ecmdlet/var to code spans
- parameters - change italic formatting to bold
- parameters - change code span formatting to bold
- change italics to use underscores
- change bold-underscores to asterisk
- change bold keystrokes to kbd
- Use contractions
- Fix indented code blocks
- Find bad syntax reflows
2. Update example formatting
a. Bulk updating example formatting before content updates

Learn Build status updates of commit 945be53:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/failoverclusters/Remove-ClusterCheckpoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterFaultDomain.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupFromSet.md
:white_check_mark:Succeeded

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupSet.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupSetDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResource.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResourceDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResourceType.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterSharedVolume.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Repair-ClusterStorageSpacesDirect.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Reset-ClusterVMMonitoredState.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Resume-ClusterNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Resume-ClusterResource.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterFaultDomain.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterFaultDomainXML.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterGroupSet.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterLog.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterOwnerNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterParameter.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterQuorum.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterResourceDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterStorageSpacesDirect.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit bd03e75:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/failoverclusters/Remove-ClusterCheckpoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterFaultDomain.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupFromSet.md
:white_check_mark:Succeeded

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupSet.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupSetDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResource.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResourceDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResourceType.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterSharedVolume.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Repair-ClusterStorageSpacesDirect.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Reset-ClusterVMMonitoredState.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Resume-ClusterNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Resume-ClusterResource.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterFaultDomain.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterFaultDomainXML.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterGroupSet.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterLog.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterOwnerNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterParameter.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterQuorum.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterResourceDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterStorageSpacesDirect.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Hi @michaeltlombardi / @sdwheeler,
I believe this PR is release ready if you would be kind enough to review and if appropriate sign-off/merge 😊
The main update was to reflow and fix any line return issues.
Please let me know if you have any questions or if I need to apply any other updates.
Thanks Robin

Learn Build status updates of commit 22219d4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/failoverclusters/Remove-ClusterCheckpoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterFaultDomain.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroup.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupFromSet.md
:white_check_mark:Succeeded

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupSet.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterGroupSetDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResource.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResourceDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterResourceType.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterSharedVolume.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Remove-ClusterVMMonitoredItem.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Repair-ClusterStorageSpacesDirect.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Reset-ClusterVMMonitoredState.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Resume-ClusterNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Resume-ClusterResource.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterFaultDomain.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterFaultDomainXML.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterGroupSet.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterLog.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterOwnerNode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterParameter.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterQuorum.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterResourceDependency.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/failoverclusters/Set-ClusterStorageSpacesDirect.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Change jorge's Author link

No problem! I greatly empathize with the feeling of not wanting particular social media shared.
I was also able to make the change in the web UI so it was really easy.


Update for Upbound Cloud and UXP

Description of your changes
Update the README and code to take into account the release of Upbound Cloud and Upbound Universal Crossplane.

update namespace to upbound-system from crossplane-system
update version to v0.2.0
update documentation links to 1.3 (which will be released shortly)

How has this code been tested

install test package: kubectl crossplane install configuration registry.upbound.io/steven-upboundio/platform-ref-aws:0.2.0
created the following examples on the cluster:

kubectl apply -f examples/network.yaml
kubectl apply -f examples/postgres-claim.yaml
kubectl apply -f examples/cluster.yaml

-verified that resources and secrets were created.

Need to clean up the .git history a bit.

After merging, do you want to use the new Actions that @turkenh added to tag a new v0.2.0 build?

Yes, I'll reach out to @turkenh. Just updated the PR with an ignore for the new GitHub workflows.


php 8.0 support

Please add "php": "^5.4|7.|8." support here

Hey @darkperis
PR #8 was just merged, which adds PHP 8 support. If you want to use this you'll need to update your composer package version to ^2.0.0 🙂

Hey @darkperis
PR #8 was just merged, which adds PHP 8 support. If you want to use this you'll need to update your composer package version to ^2.0.0 🙂


GLPT2 correlation energy in pyscf

Hi all,
I was just wondering if its possible to calculate the Gorling Levy 2nd order perturbation theory correlation energy on Kohn-Sham orbitals including the single excitation contributions rather than just the MP2 correlation energy in pyscf?
Thanks!

This feature is currently unavailable and is unlikely to be supported in the near future.
Feel free to reopen the issue if you would like to suggest adding this functionality to PySCF, and please add the "feature request" label.

Is there a way to add the single excitation contributions manually after calculating the MP2 correlation energy on Kohn-Sham orbitals?


Mapping UI Usability Issues

From @siuc-nate
On this screen:

Shouldn't the tool already know which properties go with which class(es), based on the schema:domainIncludes data?
There is way too much empty whitespace here, especially vertically. It should not take this many pixels to show ~6 properties.
Why is the origin displayed? I uploaded the properties, I don't need to see that they came from my organization (especially if they have a different namespace but were in my JSON document)
Why do I need to select a property first, and then drag it over? Shouldn't I be able to just drag them?
It wasn't immediately obvious that the intended workflow was first to select several properties, and then drag them as a set.  The instructions in the orange box should probably be updated to say that instead of saying "drag the individual properties..." as that implies that the intended workflow is to click a property once to select it, then click/drag it over, then click another property to select it, drag that over, etc. (which is especially problematic when selecting properties further down the list, as you would need to scroll to the top each time and then back down).

Additionally:

Why am I seeing properties that have a range of Organization rather than just those with a domain of Organization?
Why am I seeing the Credentialing Action class (and a few other random classes) at all? Shouldn't this screen only be displaying properties, not classes?

Same issue when trying to align the competency class (the "hasTopChild" property has a domain of CompetencyFramework and a range of Competency, but it displays in this list for some reason):

@jbaird123 if the mapping UI is showing classes instead of only properties and controlled vocabularies, that's a big bug not an enhancment.  Also, if it's true that properties are showing that are not included with classes that were uploaded, that's another big bug not an enhancement.  Need to look at this and if it's not functioning  intended, it does need to be fixed.

Ignoring issues that are duplicates or already fixed and questions, suggested resolutions:

[ ] There is way too much empty whitespace here, especially vertically. It should not take this many pixels to show ~6 properties.

I suspect we will fill some of that space with new text, but for now reduce borders and padding to make more compact; would can reduce the size of the heading font so long as we make it a little bolder so that it still stands out:

[ ] Why is the origin displayed? I uploaded the properties, I don't need to see that they came from my organization (especially if they have a different namespace but were in my JSON document)

Do not display this, (which shows as origin:DSO2 in above image) on this view; it should be displayed on other views of the property information such as when in the spine and on mapping result pages.

[ ] Why do I need to select a property first, and then drag it over? Shouldn't I be able to just drag them?

Support drag and drop as well as click to select. We still need the latter for when several properties are being added.

[ ] It wasn't immediately obvious that the intended workflow was first to select several properties, and then drag them as a set. The instructions in the orange box should probably be updated to say that instead of saying "drag the individual properties..." as that implies that the intended workflow is to click a property once to select it, then click/drag it over, then click another property to select it, drag that over, etc. (which is especially problematic when selecting properties further down the list, as you would need to scroll to the top each time and then back down).

Text currently says:

«nn» properties have been selected from the original specification
The items below have been added to the Person domain. Now you can align them to the spine.

change it to say:

«nn» properties have been selected from «name of schema».
Now you can drag and drop them to map them individually a property in the spine or click on several and drag them to map them as a group.


Update MacOS instructions to use curl

MacOS comes with curl which makes it more convenient than wget.
This change is in response to #7275

/assign @zacharysarah It's my first PR, :whale: :joy:

/assign @zacharysarah

Congrats on your first PR, @pmallory! :tada:
/lgtm

woo hoo :whale:


Change in postFeedElement v36

#4

Thank you very much @JAertgeerts and apologies for the slow turnaround time on my part. I'm also going to create a separate subdirectory for v35 in case anyone still needs to compile that version, but I'll do it in a separate PR.


Add generator for multiples and factors #942; Move `kotlintest-assert…

…ions` tests to its module #949
Closes #942
Closes #949

Added regex generator.
Closes #912

Merging so I can continue work. Build is green. Nothing controversial here.


broken link

For detailed reference documentation, please visit the Pulumi registry.

This link in the README (last line) is broken 😢

Hi @zvictor,
Thanks for reporting this! The Koyeb Pulumi provider is not yet published in the Pulumi registry, this is why you can't access this page. We plan to list it in the next few weeks.


Fails to store Thread operational credentials in KVS on platforms that does not support 0 length writes

Problem
When sending the Thread operational dataset during pairing, an unknown error is returned if the platform does not support KVS writes with length set to 0.
The changes introduced in https://github.com/project-chip/connectedhomeip/commit/ce654029a4fae7e46df049b5b48a0cd8b67cbfbf removed the handling of 0 length writes and seems to expect that KVS rejects this nicely rather then returning an error. (Specifically the change on line 213 is problematic for some platforms)
Proposed Solution
Re-introduce the empty write if the mStagingNetwork is empty or make sure all platforms nicely rejects KVS writes of 0 length.

Sure, if that is the agreement then that is the place to fix it. What is the agreed handling of 0-length writes, just return CHIP_NO_ERROR?

Yes, but the subsequent read of such a value should also return CHIP_NO_ERROR despite not returning any bytes, so you must store something on such a write :). See PersistentStorageAudit.cpp, the line commented with "Attempt an empty key write with either nullptr or zero size works".

How many platforms has this been tested on?
Looking a bit around in the different KeyValueStoreManagerImpl files I do see a few implementations which looks like it would fail the test you are referencing:
Darwin:
CHIP_ERROR KeyValueStoreManagerImpl::_Put(const char * key, const void * value, size_t value_size)
{
    ReturnErrorCodeIf(key == nullptr, CHIP_ERROR_INVALID_ARGUMENT);

EFR32:
CHIP_ERROR KeyValueStoreManagerImpl::_Put(const char * key, const void * value, size_t value_size)
{
    VerifyOrReturnError(key != nullptr, CHIP_ERROR_INVALID_ARGUMENT);

CC13x2_26x2:
CHIP_ERROR KeyValueStoreManagerImpl::_Put(const char * key, const void * value, size_t value_size)
{
    VerifyOrReturnError(key, CHIP_ERROR_INVALID_ARGUMENT);
    VerifyOrReturnError(value, CHIP_ERROR_INVALID_ARGUMENT);

ESP32:
CHIP_ERROR KeyValueStoreManagerImpl::_Put(const char * key, const void * value, size_t value_size)
{
    VerifyOrReturnError(value, CHIP_ERROR_INVALID_ARGUMENT);

You can see platforms whose maintainers claim to pass the audit in https://github.com/orgs/project-chip/projects/3.
Darwin and EFR32 just validate that the key is not null, but value can be null, right? ESP32 indeed seems to require that value be not null, but the size isn't checked. The audit on ESP32 probably passes because KvsPersistentStorageDelegate makes sure that the value passed to KeyValueStoreManager is not null (although the size can be 0). Thus if I'm not mistaken, only CC13x2_26x2 doesn't correctly handle zero-length values out of those listed by you.

I do not have access to the link.
But you are completely correct, Darwin and EFR32 checks the key and not the value so they are fine, my mistake. ESP32 still seems a bit tricky to me, since it would return CHIP_ERROR_INVALID_ARGUMENT on the storage.SyncSetKeyValue with nullptr but the test expects CHIP_NO_ERROR, but if I understand you correctly there is an additional layer which handles this or?
CC13x2_26x2 indeed have issues with the 0-length. I have not checked all platforms, but If this is only a CC13x2_26x2 issue, I can rename the title of the issue to indicate this.

The underlying storage mechanism for NVS on the CC13X2_26X2 can't handle an element of zero length. It doesn't really make sense to set an empty value.
This reminds me of: https://wiki.c2.com/?NullConsideredHarmful
We can implement this by checking if a key exists without a value assume it is a zero length element in that case.

It doesn't really make sense to set an empty value.

While this may be your opinion, we rely on this in several places and I have a lot of products here that allow empty values.
Consider the humble Python dict:
{
   "a": ""
}

This is definitely different than
{ }

@srickardti We also struggled with that too as Zephyr's settings API also doesn't support empty values. In Zephyr's implementation of the KVS we worked around this by putting magic bytes into the store as the representation of the empty value. You can probably do something similar. It is not ideal, but good enough solution.

It doesn't really make sense to set an empty value.

While this may be one opinion, we rely on this in several places and I have a lot of products here that allow empty values.

Yeah, the difference is really just in the assumptions each system makes. The NVS system in our SDK doesn't have a default value option so deleting an item is logically equivalent to setting it to empty. Having a NULL in the storage system for the ConfigurationManager should mean use the default value. So I understand that we need to be able to set a "" value.

Or at minimum fake it by using some magic value as @Damian-Nordic is talking about?

Sorry for coming in late here... For some reason I am not getting emails/notification when I am mentioned. I will work on fixing that.
Thanks Damian for making all the points I would have made. PersistentStorageDelegate::SyncSetKeyValue was defined to allow setting values of 0 size (and when value is nullptr). This decision was made before I started working on matter, but I am guessing this decision was made earlier on so that application relying on this could depend on this being available. Just like tcarmelveilleux mentioned there are cases where this is important. This has been in the API contract of PersistentStorageDelegate for quite some time.
Overall my two cents is this issue should be renamed to have CC13X2_26X2 pass the PersistentStorageDelegate audit:
To run the audit on your device you simply need to add the gn build arg chip_support_enable_storage_api_audit=true to your build.
To build for Linux, for example:
In SDK root: scripts/examples/gn_build_example.sh examples/all-clusters-app/linux out/debug/standalone chip_config_network_layer_ble=false chip_support_enable_storage_api_audit=true
Then ./out/debug/standalone/chip-all-clusters-app and the audit will run in early init. You can observe it in the logs.
The output of the Audit is a log:

==== PersistentStorageDelegate API audit: SUCCESS ====
==== PersistentStorageDelegate API audit: FAILED: %d/%d failed assertions ====

@tehampson In the past the persistent-storage example application was the audit for the KVS system. Has that changed? If so, should we just remove that example to avoid confusion?

I think I see the issue. We actually never fixing discrepancies between PersistentStorageDelegate and KeyValueStoreManager. It seems like we made it very clear about PersistentStorageDelegate but never made that clarification in KeyValueStoreManager.
The audit is more for PersistentStorageDelegate and that example uses KeyValueStoreManager. Overall the reason we did the audit the way we did is that it allowed all platforms to quickly test to make sure they are compliant. There is no good way for platforms to use a common device test that runs across platforms. I don't have enough background to make this call, but I would say the test in examples/persistent-storage/ is not as robust as the audit.
I think that maybe we should make sure to make KeyValueStoreManager APIs inline with PersistentStorageDelegate at this point.

KeyValueStoreManager is platform level. You could implement a platform without ever using it, but most examples show it.
PersistentStorageDelegate is a storage abstraction used by all common code above the platform layer. That one is the only one whose API contract we "uniformly" try to validate.

Based on what tcarmelveilleux@ is saying I think we cannot make the same assumptions about KeyValueStoreManager based on APIs and audit of PersistentStorageDelegate. So while CC13X2_26X2 does need to pass the PersistentStorageDelegate audit and that should be a github issue on it's own, it doesn't mean that KeyValueStoreManager has the same API contract :/
For that reason maybe BackupConfiguration() should handle the 0 size case differently. Sorry for the back and forth here.


Invalid url once refresh from module but not home page

module.exports.initLocalVariables = function (app, agenda) {
  ...
  // Passing the request url to environment locals
  app.use(function (req, res, next) {
    res.locals.host = req.protocol + '://' + req.hostname;
    res.locals.url = req.protocol + '://' + req.headers.host + req.originalUrl;
    next();
  });
};

The value of res.locals.url will be module related once you refresh it.
And below url related will be impacted.
  <!-- Facebook META -->
  <meta property="fb:app_id" content="{{facebookAppId}}">
  <meta property="og:site_name" content="{{title}}">
  <meta property="og:title" content="{{title}}">
  <meta property="og:description" content="{{description}}">
  <meta property="og:url" content="{{url}}">
  <meta property="og:image" content="{{url}}{{logo}}">
  <meta property="og:type" content="website">

  <!-- Twitter META -->
  <meta name="twitter:title" content="{{title}}">
  <meta name="twitter:description" content="{{description}}">
  <meta name="twitter:url" content="{{url}}">
  <meta name="twitter:image" content="{{url}}modules/core/img/brand/logo.png">

@emmansun I believe this was fixed with this commit https://github.com/meanjs/mean/commit/e6a5732698815411ec328b8708fb00c7b3fe42d9 which was a part of the 0.4.2 release.
Have you encountered this behavior with some other module/reference in the application? If not, does this solve the problem for you?

Yes, this should solve the problem, thx @mleanos !


Speed up tests/end_to_end/test_repo_manager.py

Right now it uses the subprocess module; go a level lower to speed things up

Fixed in #905


Minor tweaks and additions

Hi @Fueled, thanks for this great resource! It’s very handy as I just started with the introduction of Combine into my ReactiveSwift-based codebase. This pull request fixes #2, corrects the mapping for Signal, and adds Signal.pipe(), which I was a heavy user of.

Thanks for your contribution @lukaskubanek ! Glad you find this cheatsheet useful 👍


feat: no_std compatibility

Overview

[!NOTE]
#1 Will require a rebase after this is merged.

Makes the crate no_std compatible.

noice 👍


add image classification tutorial for jetson

Description
This PR adds an image classification tutorial using MXNet's v1.6 wheel with Jetson support.

@samskalicky @leezu @sandeep-krishnamurthy please review! thanks!

@samskalicky thanks for the review. I have addressed your comments. Can you give it another pass? Thanks!

@mxnet-bot run ci [all]

Thanks @mseth10 for the contributions. Content looks good to me. Can you please post a preview given that this is website change?
@ys2843 FYI

@mseth10 @sandeep-krishnamurthy Here is the preview: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/deploy/inference/image_classification_jetson.html


Maybe unsound in set_argv_index and set_omit

hello, thank you for your contribution in this project, I am scanning the unsoundness problem in rust project.
I notice the following code:
pub fn set_argv_index(&mut self, i: i32) {
        unsafe { (*self.usage).argvIndex = i };
    }
    pub fn set_omit(&mut self, value: bool) {
        unsafe { (*self.usage).omit = u8::from(value) }
    }

Considering that pub mod table and usage is a pub field, I assume that users can directly manipulate this field, and that set_argv_index is a public function. This potential situation could result in self.usage being a null pointer, and directly dereferencing it might trigger undefined behavior (UB). For safety reasons, I felt it necessary to report this issue. If you have performed checks elsewhere that ensure this is safe, please don’t take offense at my raising this issue.

here is my PoC:
use std::ptr;

pub struct sqlite3_index_info_sqlite3_index_constraint_usage {
    pub argvIndex: i32,
    pub omit: u8,
}

pub struct Constraint {
    //pub constraint: sqlite3_index_info_sqlite3_index_constraint,
    pub usage: *mut sqlite3_index_info_sqlite3_index_constraint_usage,
    // needed for sqlite3_vtab_* methods
    //index_info: *mut sqlite3_index_info,
    constraint_idx: i32,
}

impl Constraint {
    pub fn set_argv_index(&mut self, i: i32) {
        unsafe { (*self.usage).argvIndex = i };
    }
    pub fn set_omit(&mut self, value: bool) {
        unsafe { (*self.usage).omit = u8::from(value) }
    }
}

fn main(){
    let a:*mut sqlite3_index_info_sqlite3_index_constraint_usage= ptr::null_mut();
    let mut b=Constraint{usage: a, constraint_idx: 0};
    b.set_argv_index(1);
}

I annotated and modified parts of the implementation for convenience, but I believe the overall framework is consistent.

Maybe same unsoundness problem for https://github.com/asg017/sqlite-loadable-rs/blob/2c5c049c0c9e010a70b458fde459facf294befce/src/table.rs#L253
but this is because the new method didn't varify the pointer validity.
and if pass a null pointer it may cause UB in
https://github.com/asg017/sqlite-loadable-rs/blob/2c5c049c0c9e010a70b458fde459facf294befce/src/table.rs#L267


Add more info to containers

As pointed out in #1929 , we should add the following info to the pods:
Pod List:

[ ] Add quick status for each container (design TBD)

Pod Details:

[x] Add exit code for containers
[x] Add started/finished times
[x] Add restart reason

@joaquimrocha Hi
for point "Pod Details (for those with completed containers)" I would say not only with complited but also for running, the container could have been killed and restarted, but is currently running so it is also useful to get restart reason

Reopening for tackling the last item.

Most parts are done, but there's one item left open. Moving this to the next release milestone.


Resonite

Can this be ported over for Resonite please!!!

OKOKOOOKOKOKOKO

Oh looks like it is no longer needed.
Resonite Update 2<IP_ADDRESS>

Added copy button for text messages (I've been busy sorting out a bunch of Patreon linking issues and I need to copy some diagnostic data we get through the bot, so I really needed this one)
-- To copy message, hover over it, which will make a copy button appear

Thank you Frooxius san
This is the update
tears are flowing


Adding Netris

Netris is an automatic netops software with Kubernetes API integration
This contribution will be useful for Kubernetes users that running local private clusters.

I signed it

I signed it

I signed it

@alex-netris thanks for your contribution! 🎉 We really would love to have it, unfortunately to continue we need to have your (or your company's) signature on a CLA! For now I'm going to close this, but fret not! You can re-open whenever you have a chance. Thanks!
(Also I believe @jimangel provided the instructions to troubleshoot the problem)
/close


Firebase Messaging iOS SDK v7.0 will no longer support the FCM Direct Channel API

Hey guys, I received an email from Firebase with the above subject. I was wondering if this is because I have not updated the plugin? My plugin version is 4.1.1. This is the full email for reference:

We are writing to let you know that Firebase Messaging iOS Direct Channel API support is marked for deprecation. Firebase Messaging iOS SDK version 7.0 will be a breaking change where the SDK will no longer support iOS Direct Channel API.

What do I need to know?
Firebase Messaging iOS Direct Channel has been used for sending data to apps when they are in the foreground and for upstream messages. The Firebase Messaging iOS SDK v7.0 (slated to be released in September 2020) will no longer support the iOS Direct Channel API. Your app will break if you update to the Firebase Messaging iOS SDK v7.0 without migrating off the iOS Direct Channel API.

We are removing this feature in favor of natively supported messaging features provided by Apple Push Notification Service.

To prevent disruptions to your users, we recommend that you discontinue use of the iOS Direct Channel API as soon as possible. Please note that for the time being, your existing users can still continue to receive messages via the iOS Direct Channel API. However, within the next year, we will follow up this announcement with plans to deprecate the backend service support which may break your app with older versions of the Messaging iOS SDK (prior to v7.0).

What do I need to do?

To prevent disruptions to your users, we recommend that you discontinue use of the iOS Direct Channel API and use an alternative such as FCM’s APNs interface for downstream data message delivery.
If you are not using FCM HTTP v1 API, we strongly recommend that you do so. FCM HTTP v1 API provides full APNs support. If you need to continue using FCM Legacy API, you can:
Add the content_available key to your payload if you continue to use the legacy sender API.
For upstream messages, make arrangements to send messages directly from your app to your servers.
For real time updates, you can use Cloud Firestore, Realtime Database, or other services.

For the app side:
Nothing should break, unless you were using the briefly supported onFirebaseDataNotificationIOS.
Since v5, all the deprecated iOS Direct Channel API methods were removed from this plugin.
But it's always recommended to keep up with the newer versions, currently v6.4.0.
When you update the cordova-plugin-fcm-with-dependecy-updated, please don't forget to add the call to request user's push permission requestPushPermissionIOS();, which now doesn't have to be at start.
From the server side
I'd have to know how do you send the push payloads to FCM.
From the email, it recommends, that you use the FCM HTTP v1 API (https://firebase.google.com/docs/cloud-messaging/server https://firebase.google.com/docs/cloud-messaging/migrate-v1).
If there is any questions, let me know.

Hey! this is how I did it on the server side. I'm pretty sure it uses the FCM HTTP v1 API
var FCMAdmin = require("firebase-admin");
var FCMServiceAccount = require("./service-account.json");
var topic = req.body.target;

var payloadWithTopic = {
    'notification': {
        'title': req.body.title,
        'body': req.body.message
    },
    topic: topic
};

FCMAdmin.messaging().send(payloadWithTopic)
        .then(function(response) {
            console.log("Topic message sent successfully");
        }).catch(function(err) {
            console.log(err);
        });

I tried to update the plugin by removing and adding the plugin to my project again, but when re-adding the plugin I encountered an error. Something like ruby gems 2.7.0 cocoapods-core 1.9.2 URI.escape is obsolete and Error: pod: Command failed with exit code 31. So, I reverted all changes by running git reset head --hard and discarding all new files that were created from removing and adding the plugin using GitHub Desktop. But now when I run my app on my iPhone 7 Plus, I'm not receiving any push notifications, despite the log says "subscribe to topic successful" and being able to receive the APNS token. When I put the app in the background, the log says 'Disconnected from FCM' and FIRMessaging received data message, but FIRMessagingDelegate's-messaging:didReceiveMessage: not implemented.
What could be the problem? Everything was working fine until I tried to update the plugin. It even works when I install a previous build from Testflight.

So I've managed to update the plugin. I re-installed cocoapods and ran pod setup before removing and re-adding the plugin. I added the requestPushPermissionIOS(); function when initializing my app like this:
var app = new Framework7({
	root: '#app', // App root element
	id: 'io.framework7.appname', // App bundle ID
	name: 'App Name', // App name
	theme: 'auto', // Automatic theme detection
	// App routes
	routes: routes,
	// Input settings
	input: {
		scrollIntoViewOnFocus: Framework7.device.cordova && !Framework7.device.electron,
		scrollIntoViewCentered: Framework7.device.cordova && !Framework7.device.electron,
	},
	// Cordova Statusbar settings
	statusbar: {
		iosOverlaysWebView: true,
		androidOverlaysWebView: false,
	},
	on: {
		init: function () {
			var f7 = this;
			if (f7.device.cordova) {
				// Init cordova APIs (see cordova-app.js)
				cordovaApp.init(f7);
				FCMPlugin.requestPushPermissionIOS(function(wasPermissionGiven) {
					console.log("Was permission given: "+wasPermissionGiven);
					window.localStorage.setItem('hasPermission', wasPermissionGiven);
				  },
				  function(error) {
					console.error(error);
				  }
				);
			}
		},
	},
});

And then call the subscribeToTopic(); function when the login button is clicked. In my Xcode logs, permission given returns true and subscribe to topic is successful, but I am unable to receive push notifications when app is in the background? Any idea why?

That's certainly strange.
Would you:

Try to send a push notification by token, instead of topic, just as a test?
Share your ios' runtime log?
Share your package.json?
Share the version(s) of the iOS you are running your app on?

I'll try to send push notification by token and update you later, along with the runtime log. I'm running on iOS 13.4.1. This is my package.json:
{
  "name": "bundleid",
  "displayName": "App Name",
  "version": "1.0.0",
  "description": "A sample Apache Cordova application that responds to the deviceready event.",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [
    "ecosystem:cordova"
  ],
  "author": "Apache Cordova Team",
  "license": "Apache-2.0",
  "dependencies": {
    "cordova-android": "^8.1.0",
    "cordova-ios": "^5.1.1",
    "cordova-plugin-camera": "^4.1.0",
    "cordova-plugin-fcm-with-dependecy-updated": "^6.4.0",
    "cordova-plugin-keyboard": "^1.2.0",
    "cordova-plugin-splashscreen": "^5.0.3",
    "cordova-plugin-statusbar": "^2.4.3",
    "cordova-plugin-wkwebview-engine": "^1.2.1",
    "cordova-plugin-wkwebview-file-xhr": "^2.1.3"
  },
  "cordova": {
    "plugins": {
      "cordova-plugin-statusbar": {},
      "cordova-plugin-keyboard": {},
      "cordova-plugin-wkwebview-file-xhr": {},
      "cordova-plugin-whitelist": {},
      "cordova-plugin-camera": {
        "ANDROID_SUPPORT_V4_VERSION": "27.+"
      },
      "cordova-plugin-splashscreen": {},
      "cordova-plugin-wkwebview-engine": {},
      "cordova-plugin-fcm-with-dependecy-updated": {
        "FCM_VERSION": "19.0.0",
        "GRADLE_TOOLS_VERSION": "3.5.3",
        "GOOGLE_SERVICES_VERSION": "4.3.3",
        "SUPPORT_LIBRARY_VERSION": "28.0.0",
        "ANDROID_DEFAULT_NOTIFICATION_ICON": "@mipmap/ic_launcher"
      }
    },
    "platforms": [
      "android",
      "ios"
    ]
  },
  "devDependencies": {
    "cordova-plugin-whitelist": "^1.3.4"
  }
}

I logged in to my app and sent notification via topic, and magically, it works? all I changed was adding
FCMPlugin.onNotification(function(data){
        console.log(JSON.stringify(data));
});

FCMPlugin.onNotificationReceived(function(payload){
        console.log(JSON.stringify(payload));
});

But I don't understand why that would affect it because I can receive push notification without implementing the above in the previous version?

The method FCMPlugin.onNotificationReceived shouldn't be called from the app.
Calling the FCMPlugin.onNotification with a callback as argument should not cause this impact.
It looks a bit absurd, unless this is somewhat test/debugging code not coming from the plugin itself. As the log suggests:
2020-05-24 16:26:34.913209+0800 Trienekens[1288:254944] Device FCM Token: FCM token
2020-05-24 16:26:34.913327+0800 Trienekens[1288:254944] notifyFCMTokenRefresh token: FCM token
2020-05-24 16:26:34.913382+0800 Trienekens[1288:254944] stringByEvaluatingJavaScriptFromString FCMPlugin.onTokenRefreshReceived('FCM token');
2020-05-24 16:26:34.916172+0800 Trienekens[1288:254944] Received token refresh
2020-05-24 16:26:34.916334+0800 Trienekens[1288:254944] FCM token
2020-05-24 16:26:36.996415+0800 Trienekens[1288:254944] Device APNS Token: token

APNS token would never be "token" and FCM token would never be "FCM token". 🧐

why shouldn't FCMPlugin.onNotificationReceived be called from the app?
also, I purposely change the value of APNS and FCM token values for this purpose, the actual value is a real token

why shouldn't FCMPlugin.onNotificationReceived be called from the app?

Because, the native implementation calls FCMPlugin.onNotificationReceived(token).
So as you can see in the javascript file https://github.com/andrehtissot/cordova-plugin-fcm-with-dependecy-updated/blob/master/www/FCMPlugin.js
onNotificationReceived is the callback function that is called with the token.
FCMPlugin.prototype.onNotificationReceived = function (payload) {
  console.log("Received push notification");
  console.log(payload);
};

While onNotification just replaces the default function above with the one given as argument.
FCMPlugin.prototype.onNotification = function (callback, success, error) {
  FCMPlugin.prototype.onNotificationReceived = callback;
  exec(success, error, "FCMPlugin", "registerNotification", []);
};

I'm sure that these definitions could be much better, and I'll probably refactor it with more convenient solutions like observables and promises. And make more clear which methods are internal and which are the supported for public use. It's just been kept for legacy reasons.

also, I purposely change the value of APNS and FCM token values for this purpose, the actual value is a real token

It got me confused. For those cases I usually replace with "[REDACTED]".
... but still, don't know why it would fail without calling onNotification. Maybe it just took some time to relate that toked id to a topic? I did check the ios' implementation of the above mentioned registerNotification method, but there was nothing that would "activate" the plugin or anything.

yeah, maybe I didn't give it enough time for the token to subscribe to a topic. I'll remove FCMPlugin.onNotificationReceived() and try again later and let you know the result. Thanks for all the information you've given me!

Thank you for reaching out.
I'll close as there is nothing much to go on and you got it working.
If you get any issues, let me know.

Hi, just want to update you that I can still receive push notification even when FCMPlugin.onNotificationReceived() and FCMPlugin.onNotification() are removed. I guess the problem was not giving it enough time to subscribe to a topic after all

Thank you for letting me know.
If you face other issues, I'm here.

Hi,
I was using this plugin, until I had issues of conflicts with 'cordova-plugin-local-notifications', and I saw a suggestion to switch to the fork of this plugin - https://github.com/Shashank2406/cordova-plugin-fcm-with-dependency-updated-apns and all issues were resolved.
Now, I got the same email described in this issue "Firebase Messaging iOS SDK v7.0 will no longer support the FCM Direct Channel API".
I'm not sure what should I do... and if something will be deprecated on the forked plugin...
There is no option to ask there.
Any idea?
Thanks!

Thank you for linking the fork. Unfortunately, it is based on v2.4.0, which although was quite good for the time, it does still implements deprecated SDK features and lack many current features.
What @Shasheank2406 has included, that the current plugin of cordova-plugin-fcm-with-dependecy-updated doesn't contain, is to present the notification when received. Instead of giving it to the JS context, and, from the JS context, calling something like cordova-plugin-local-notifications.
@Shasheank2406's approach is by consequence a little more performant, but it has the downside of restricting how the app, in the JS context, handles the notification event and how it chooses to present the notification.
Using @Shasheank2406's fork is not recommended, but can serve until the incompatibility with current cordova-plugin-local-notifications is fixed.
Just to understand a bit better your specific case. How were you using cordova-plugin-local-notifications and on which version.

@andrehtissot, thank you very much for your answer!
Our app is using Ionic 3.
We're using cordova-plugin-local-notifications version 0.9.0-beta.3.
The usage is for showing notifications on the foreground on iOS.
When the onNotification() callback is being received, we call the local notification plugin to show notification on iOS. Otherwise we couldn't solve showing notifications on the foreground for iOS.
I remember that initially I was using this specific plugin, and there was a conflict with the local notifications plugin, so after searching, I found the below suggestions which suggested to replace it.

https://github.com/katzer/cordova-plugin-local-notifications/issues/1759
https://github.com/fechanique/cordova-plugin-fcm/issues/509
https://forum.ionicframework.com/t/ionic-3-local-notification-not-working-in-ios-with-fcm/147377/5

Meantime it's working perfect, but after getting this email from google Firebase, I wasn't sure if this fork includes code that won't be supported soon.
I understand that there are things to modify on our Backend, but on the plugin I wasn't sure if there is deprecated code.
Thanks.

@andrehtissot Thanks a lot, I appreciate it!
I will check and update.


So you need to choose and kill the rigth pig into each of 4 levels
Which level the number of pigs increase
With "a" you move left
With "d" you move rigth
With "j" you throw the ray
Enjoy and good dinner :)

Great art and fun little narrative which comes across well. I think it could feel a little more game like if there was a memory component, perhaps if every level you had to complete all the preceding levels.
Welcome to the gallery!


Supporting absolute import for Typescript

I created this issue to learn about the challenges and some of the ideas to support this.
https://github.com/facebook/create-react-app/blob/87e3d4fd1080d290f675d0461e3d3656752628ab/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L127

Duplicated

@tanduong Can you direct me to the open duplicate of this issue?

@csharptest: this one: https://github.com/facebook/create-react-app/issues/5645#issuecomment-435201019

And also this: https://github.com/facebook/create-react-app/issues/5637

And this: https://github.com/facebook/create-react-app/issues/5585
I saw quite many similar requests. :)


Problem connecting to SROS device when using encryption

I have the same problem as the user had I case #59.
When I look at a wireshark of the data that is send with gnmic that is working it is using tls 1.2, but when I use pygnmi it is using TLS 1.
It works when I add the os value in case #59 (os.environ["GRPC_SSL_CIPHER_SUITES"] = "HIGH"), but is there not a way where pygnmi can negotiate the tls version with the devices, so we do not have to change this for what device we are talking to?

Hello @cliff-ha ,
Thanks for raising that up. Let us investigate that. We rely on the default behaviour of grpc library for that. Maybe there is a way to alter that.
Best,
Anton

Hey @cliff-ha ,
We've embedded and tested automatic change of cipher to high in case of failure. We have published the new release 0.7.0 which has this feature. Could you please give it a go and let us know your results, please?
Thanks,
Anton

Hello @cliff-ha ,
please, reopen the ticket if you have any issues.
Best,
Anton

I just updated to 0.7.1 but I am still unable to connect without setting the cipher suite.

Hey @cliff-ha ,
can you please post the output of the script's execution?
Best,
Anton

Sure it looks like this:
Traceback (most recent call last):
File "/git/python/code/Test/test-forbindelsen.py", line 15, in
with gNMIclient(target=(hostname, 57400), username=username, password=password, path_cert=certpath) as gc:
File "/git/python/venv/acl-venv/lib/python3.9/site-packages/pygnmi/client.py", line 94, in enter
return self.connect()
File "/git/python/venv/acl-venv/lib/python3.9/site-packages/pygnmi/client.py", line 146, in connect
self.wait_for_connect(timeout)
File "/git/python/venv/acl-venv/lib/python3.9/site-packages/pygnmi/client.py", line 156, in wait_for_connect
grpc.channel_ready_future(self.__channel).result(timeout=timeout)
File "/git/python/venv/acl-venv/lib/python3.9/site-packages/grpc/_utilities.py", line 139, in result
self._block(timeout)
File "/git/python/venv/acl-venv/lib/python3.9/site-packages/grpc/_utilities.py", line 85, in _block
raise grpc.FutureTimeoutError()
grpc.FutureTimeoutError

Hey @cliff-ha ,
hope you are doing well. I did a bit of research and, to be honest, a bit puzzled with your
os.environ["GRPC_SSL_CIPHER_SUITES"] = "HIGH"

So the default values are ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384, which seems sane. At the same time, there is no cipher called "HIGH".
With this, can you please share your code where you set the environment and the connection to Nokia SR OS starts working fine, please? I'd like to see the working example to figure out if I can back port it.
Best,
Anton

Closed due to inactivity


refactor(tests_integration): separate sequencer setup from test setup

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2299  👈 (View in Graphite)
#2242
#2253
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/starknet_integration_tests/src/utils.rs line 63 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
PTAL
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_sequencer_node/src/config/test_utils.rs#L8-L15
I was suggesting to use this struct to handle the passing of required parameters to the test.

I think it is unnecessary once we use the config crate


Implemented config struct. Added methods to parse and validate config.

Closes #5 - Implemented Config, Context and Auth structs. Added methods to parse and validate config.

@g4s8 please review this PR

@OrlovM thanks! Please check some minor comments

Done!


[QUESTION] Permissions

Hi,
When installing, you'll need to set a persmission scope. The guide says this is only for installation. Is there a discription or declaration that nothing will be send to another party? 2. is there a way to disable rights after installation?
We work in a company with a medical files stored on SharePoint.
Thank you
Jesse

Sorry for the delay in my response I was verifying the first part of your question.  Unfortunately, there is no official statement I can point you to that says nothing will be sent to another party, that just doesn't exist... I can tell you that the reason for the permission scope is so that the automation engine can provision the site collection and deploy the solution to your app catalog for you. Unfortunately to do that, the amount of permissions needed is quite broad. That said you can absolutely remove the app registration(s) after the fact by going into the Azure Portal, to Azure Active Directory -> Enterprise Applications and deleting it. The one called SharePointPnP.ProvisioningApp.Tenant would have been the one used for provisioning learning pathways.  It is never used again other than to provision.  That said if that isn't enough you can manually deploy learning pathways you just will not get the templated site pages with translations. They are not needed to make the solution run but some people like the "getting started" nature of it.

Sorry for the delay in my response I was verifying the first part of your question.  Unfortunately, there is no official statement I can point you to that says nothing will be sent to another party, that just doesn't exist... I can tell you that the reason for the permission scope is so that the automation engine can provision the site collection and deploy the solution to your app catalog for you. Unfortunately to do that, the amount of permissions needed is quite broad. That said you can absolutely remove the app registration(s) after the fact by going into the Azure Portal, to Azure Active Directory -> Enterprise Applications and deleting it. The one called SharePointPnP.ProvisioningApp.Tenant would have been the one used for provisioning learning pathways.  It is never used again other than to provision.  That said if that isn't enough you can manually deploy learning pathways you just will not get the templated site pages with translations. They are not needed to make the solution run but some people like the "getting started" nature of it.

I'm going to close this issue as answered. If you have further issues, please feel free to create a new issue and reference this one.

I'm going to close this issue as answered. If you have further issues, please feel free to create a new issue and reference this one.

Thanks for the reply!

Thanks for the reply!


[Storage] Samples need to be updated for STG73

The samples will need to updated to reflect the most recent API updates. For example blob query:
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/storage/azure-storage-blob/samples/blob_samples_query.py

Samples have been updated since and we will continue to add as requested samples from cxs come in


[4183] Trainee summary view bugs

Context
https://trello.com/c/ZKEGWHsN/4183-trainee-summary-view-bugs
Changes proposed in this pull request

Update the page title to 'Funding - Trainee summary 2021 to 2022'
Correct the typo on the Summary table - 'ITT scholarships'

On the EYITT table:

Make the table full-width (like the bursaries and scholarships tables)
Add a new first column which displays the route
Sort table by route and then tier

Guidance to review

View the funding trainee summary for a provider
Check that the above issues have been addressed

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Trainee summary view bugs


[Feature Request] keep "Repeat on interval" running even when moving between request

Insomnia Version: 6.0.2
Operating System: Linux

Details
I need to fetch new authentication cookies periodically during the entire day. I can do that with "Repeat on interval" but that stops as soon as a move to another request.
I would like it to continue to run forever in the background, feeding new cookies into the cookie jar continuously.

This seems like a good idea. The "Repeat on Interval" wasn't a very well designed feature originally and could use some work.

I had a go at this, and was able to get it working - the request runs in intervals in the background as needed. I added an intervalID: IntervalID property to the request model, since storing interval info in the React component will carry over the interval to the next request too. The component property now mirrors the request model property on mounts and prop changes.
The issue is that if the app is shut down without stopping the interval, on app restart the component has no way to know or check that the interval ID stored in request model is not really an active interval, and thus mirrors a non-functioning interval ID, showing the Stop button.
@gschier Is there some way to null the intervalID of all requests when the app starts (or exits)? Or is there a better implementation?


Remove unreleased "arrayvec" code

Modify the embedded no-allocator test to use the new primitives module, once that is done we can remove all the code feature gated on "arrayvec" that was recently added (and unreleased) to support allocationless encoding/decoding.

I think you are right to review and merge this one @apoelstra, its non-controversial to remove unreleased unrequired code.