Add a GitHub action to lint phpdocs

Add a GitHub action to lint phpdocs

It works !
https://github.com/williamdes/silverstripe-framework/runs/1591161577?check_suite_focus=true#step:5:1301

Nice work!
A few comments:

the action is nice & quick, the core "build" step is only 6 seconds, so this seems a good price to pay for keeping the code compliant with api doc generation - especially if we were to introduce other things like phpstan lining that might inadvertently break it

why, however, are using the "ignore parse errors" option? Surely that's exactly what we would want to pick up?

more a question for the core team - is there anything we need to do to make this more efficiently shared across the various modules that have their docs on api.SS.org?

Thank you !

why, however, are using the "ignore parse errors" option? Surely that's exactly what we would want to pick up?

There is errors I can not fix, this is to make the action pass but still output errors, for example on pull-requests
More a warning more until all errors are removed

cc @chillu

cc @chillu

Thank you William! I would rather have this in the Travis config, since it'll be far easier to roll out across our large number of modules - see https://github.com/silverstripe/silverstripe-framework/issues/9174. But then again, this is a great starting point - and we're only running a handful of modules where PHPDoc linting is important (those going on api.ss.org)
@steve-silverstripe @dnsl48 Since you worked on the shared Travis config stuff, keen on your thoughts.

Thank you William! I would rather have this in the Travis config, since it'll be far easier to roll out across our large number of modules - see https://github.com/silverstripe/silverstripe-framework/issues/9174. But then again, this is a great starting point - and we're only running a handful of modules where PHPDoc linting is important (those going on api.ss.org)
@steve-silverstripe @dnsl48 Since you worked on the shared Travis config stuff, keen on your thoughts.

The guts of it is the beautiful github action sudo-bot/action-doctum, which uses the docker container underneath:
runs:
    using: "docker"
    image: "docker://botsudo/action-doctum:latest"
    args:
        - latest
        - "${{ inputs.config-file }}"
        - "${{ inputs.method }}"
        - "${{ inputs.cli-args }}"

I guess we could run that container in our Travis shared configs. That would allow us to easily scale that lint to the hundred modules. With GitHub actions that would require us to copy-paste this PR and make a hundred others - separately for each repository.
Another potential problem is - GitHub Actions are out of sight for the maintainers. E.g. we won't remember to update the doctum action version. Now it's sudo-bot/action-doctum@v5, but when v6 gets released - we may have to do a hundred PRs to update it everywhere and wouldn't remember to actually do that.

The guts of it is the beautiful github action sudo-bot/action-doctum, which uses the docker container underneath:
runs:
    using: "docker"
    image: "docker://botsudo/action-doctum:latest"
    args:
        - latest
        - "${{ inputs.config-file }}"
        - "${{ inputs.method }}"
        - "${{ inputs.cli-args }}"

I guess we could run that container in our Travis shared configs. That would allow us to easily scale that lint to the hundred modules. With GitHub actions that would require us to copy-paste this PR and make a hundred others - separately for each repository.
Another potential problem is - GitHub Actions are out of sight for the maintainers. E.g. we won't remember to update the doctum action version. Now it's sudo-bot/action-doctum@v5, but when v6 gets released - we may have to do a hundred PRs to update it everywhere and wouldn't remember to actually do that.

+10 for try to get this into travis shared config rather than github actions

+10 for try to get this into travis shared config rather than github actions

+10 for try to get this into travis shared config rather than github actions
https://github.com/silverstripe/silverstripe-travis-shared

I will keep that in mind, but this will have some delay before I fix that :)

+10 for try to get this into travis shared config rather than github actions
https://github.com/silverstripe/silverstripe-travis-shared

I will keep that in mind, but this will have some delay before I fix that :)

I can assist to create the script but I am too far away from this organization to understand well how the shared repo works.
But ping me on the PR that will add it


Producing an Anti Injection Query

Hello, i am currently using SQLX for my SQL Client and I wanted to produce a query like this
SELECT * FROM "table_name" WHERE id = $1
because I trust SQLX for the sanitation (anti SQL Injection)
instead of producing a query like that, the generator generate this
SELECT * FROM "table_name" WHERE ("id" = '1')
the value have been injected into the query, I am no security expert but I am not with the query security"
are there a way to generate query like that? thank you
I know that toSQL() method returns query, params, and error but mine does not return any other than query
my implementation
query := builder.From("table_name").Where(goqu.C("id").Eq("1")).
		Select("*")

	// Generate the SQL and parameters
	sql, params, _ := query.ToSQL()

	fmt.Println("Generated SQL:", sql)
	fmt.Println("Parameters:", params)

should be something like query.Prepared(true).ToSQL() right


fix: mWeb - Chat - Keyboard is not dismissed when pasting an image on compose box.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/45471
PROPOSAL: https://github.com/Expensify/App/issues/45471#issuecomment-2230816028
Tests
Pre-requisite: copy an image from the phone gallery or from desktop

For mWeb

Go to any chat
Tap on the compose box for the keyboard to be displayed
Paste the image you copied before
Verify keyboard is closed and image is shown in modal

For Web/Desktop

Go to any chat
Tap on the compose box to focus
Paste the image you copied before
Verify Image is shown in modal

Cannot paste images on native app

[x] Verify that no errors appear in the JS console

Offline tests
Pre-requisite: copy an image from the phone gallery or from desktop

For mWeb

Go to any chat
Tap on the compose box for the keyboard to be displayed
Paste the image you copied before
Verify keyboard is closed and image is shown in modal

For Web/Desktop

Go to any chat
Tap on the compose box to focus
Paste the image you copied before
Verify Image is shown in modal

Cannot paste images on native app

QA Steps
Pre-requisite: copy an image from the phone gallery or from desktop

For mWeb

Go to any chat
Tap on the compose box for the keyboard to be displayed
Paste the image you copied before
Verify keyboard is closed and image is shown in modal

For Web/Desktop

Go to any chat
Tap on the compose box to focus
Paste the image you copied before
Verify Image is shown in modal

Cannot paste images on native app

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/e0d616cf-0811-4707-958c-a92b3f80e02d

Android: mWeb Chrome
https://github.com/user-attachments/assets/3f459717-12ab-45d2-896f-4174a4f6f201

iOS: Native
https://github.com/user-attachments/assets/843f6e67-369f-4876-b9b5-256a59be91ee

iOS: mWeb Safari
https://github.com/user-attachments/assets/21037963-1979-4610-912a-226cf37171bd

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/552e47a4-4f02-44d3-b33c-e7a9311bcb02

MacOS: Desktop
https://github.com/user-attachments/assets/99cf2e99-d13b-42b6-8a68-c3915a27a7de

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


NavigationView PaneTitle bug on open

Describe the bug
PaneTitle gets full width, but doesn't expand with NavigationVIew
Steps to reproduce the bug

Go to XAML Controls Gallery
Find NavigationView page
Scroll to "API in action"
Close and open NavigationView

Expected behavior
PaneTitle expands with NavigationView
Screenshots

Version Info
Windows 10 1903
Windows 10 1909
Windows 10 2004
NuGet package version:
[Microsoft.UI.Xaml 2.5.0]
[Microsoft.UI.Xaml 2.4.0]

Windows app type:

UWP
Win32

Yes
Unchecked

Windows 10 version
Saw the problem?

Insider Build (21292.1010)
Yes

May 2020 Update (19041)
Yes

November 2019 Update (18363)
Yes

May 2019 Update (18362)
Unchecked

October 2018 Update (17763)
Unchecked

April 2018 Update (17134)
Unchecked

Fall Creators Update (16299)
Unchecked

Creators Update (15063)
Unchecked

Device form factor
Saw the problem?

Desktop
Yes

Xbox
Unchecked

Surface Hub
Unchecked

IoT
Unchecked

Additional context
No context

@Alkanores The screenshot you provided is mid animation correct?
I think that the issues is that the Hamburger button back plate changes size immediately but the panel expands with an animation. This isn't present in with the 2.6 style since the backplate for this component is being removed.

@Alkanores The screenshot you provided is mid animation correct?
I think that the issues is that the Hamburger button back plate changes size immediately but the panel expands with an animation. This isn't present in with the 2.6 style since the backplate for this component is being removed.

Yes, panel expands with normal animation.

@StephenLPeters any news?

Actual for WinUI 2.5/WinUI 2.6
@StephenLPeters

@StephenLPeters any news?

@karenbtlai FYI
This hasn't met our prioritization bar yet. We would accept a contribution which fixed the issue but are currently working on things we've deemed more important.

Thanks for filing the bug. This animation bug is a known issue, but we are prioritizing other fixes.
The other issue is that we are currently deciding whether we should fix this animation bug or refactor the template so that the backplate for the PaneToggleButton is only the hamburger icon and not the entire line as per design spec.

@karenbtlai This bug is actual for winui 3 & Windows 11
https://user-images.githubusercontent.com/49155506/189407428-9e997112-50a9-4018-8b79-548d38726bb0.mov

@StephenLPeters


user fixes to run query to register

I am able to run a query with Apollo server on my end to register.

Query works


[dbus] dbus-daemon and dbus-launch are runtime executables and should be provided in both release and debug versions

Is your feature request related to a problem? Please describe.
dbus-daemon and dbus-launch are only installed in release versions in ${VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/tools/dbus. This matches the recommendations in installation-tree-layout#layout-tools, but the recommendations should be updated to depend on whether the executables are needed at runtime. Tools that applications will be using at runtime should be installed in both release and debug versions.
Proposed solution
Update the dbus port to also install debug versions of all tools, but at least dbus-daemon and dbus-launch.
Describe alternatives you've considered
If the software needs to be able to be able to run from an install prefix then the only alternatives I can think of is to use a system provided version of dbus-launch and dbus-daemon. This is not great and also does not work on all platforms.
Additional context
No response

I've made a PR to update the documentation: https://github.com/microsoft/vcpkg-docs/pull/292


flexible pricing: too many decimal places

Steps to Reproduce

As a learner, submit a request for flexible pricing with a low income on https://rc.mitxonline.mit.edu/courses/course-v1:MITx+14.100x/microeconomics-request-flexible-pricing/
As an admin, approve the request

Expected Behavior

The price on the enroll pop-up should be "$250"

Actual Behavior

The price on the enroll pop-up is "$250.00000"

Screenshot or Screencast

This also shows up in the email:


Setter parameter error recovery causes analyzer tests to fail

After the error recovery introduced in the fix for https://github.com/dart-lang/sdk/issues/31069, the eight tests in pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart having to do with illegal setter parameters fail. The tests expect the kernel to contain the erroneous parameters, which it doesn't with the new error recovery.
We should investigate whether these tests still make sense. A fix might depend on explicit illegal function and/or parameter nodes as described in https://github.com/dart-lang/sdk/issues/29840.

@scheglov @bwilkerson WDYT?

... the eight tests in pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart having to do with illegal setter parameters fail.

I don't know which tests you're referring to, so it's hard for me to say whether they still make sense.
I can only give you the generalized answer that analyzer maintains as much of the structure of invalid code as reasonable in order to provide the best possible UX for the majority of users. Our philosophy is that users should not be required to have valid code before features other than error reporting can be used.
For example, one of the tests you might be referring to tests invalid code similar to:
set x({param}) {}

A setter's parameter cannot be optional. However, if the user wants to type code in the body of the setter, they ought to be able to type p and get a code completion suggestion to enter the parameter name. And if the user has used param in the body of the setter, they should be able to rename the parameter in spite of the fact that it was not correctly declared.
Supporting this kind of functionality requires that analyzer treat the invalid parameter as if it were valid.


Diags naming

Output file names are now normally chosen in a central place, a new file form_filenames.py.  Graphics file names are the same as before.  NetCDF output file names are now very similar to the corresponding graphics file names.   I changed filenames in the automated test baselines so that the tests will all pass.  We still need more work on file names as well as titles and so forth; but this resolves the worst problems and will make it easier to work on file names in the future.

All of the tests pass.

While testing the name I found an issue. When running metadiags with
metadiags --package AMWG --set 5 --model path=$HOME/uvcmetrics_test_data/cam35_data/,climos=yes,name=junk --obs path=$HOME/uvcmetrics_test_data/obs_data/,climos=yes --outputdir $HOME/diagout/
All of them failed for example
DEBUG (from plotplan.py 312): now composite plot
INFO (from diags 351): --------------------------------- res is not none
STDOUT and STDERR
CDMS I/O error: Determining type of file /Users/mcenerney1/uvcmetrics_test_data/obs_data/NCEP.xml.orig; must specify dictionary (control) file
jfp
jfp running this python: /Users/mcenerney1/anaconda/bin/python
UV-CDAT Diagnostics, command-line version
/Users/mcenerney1/anaconda/bin/diags --model path=/Users/mcenerney1/uvcmetrics_test_data/cam35_data,climos=yes,type=model --obs path=/Users/mcenerney1//uvcmetrics_test_data/obs_data/,climos=yes,filter=f_startswith('NCEP') --logo no --colormaps diff=bl_to_darkred model=rainbow obs=rainbow --package AMWG --set 5 --seasons ANN --vars PSL --outputdir /Users/mcenerney1//diagout/amwg --prefix set5 --postfix NCEP --log_level DEBUG --log_file /Users/mcenerney1//diagout/amwg/DIAGS_OUTPUT/42e8208b93005d3fa6095699b9509e40/AMWG_5_NCEP_PSL_ANN.log
Traceback (most recent call last):
File "/Users/mcenerney1/anaconda/bin/diags", line 762, in
run_diags(o)
File "/Users/mcenerney1/anaconda/bin/diags", line 356, in run_diags
postn=postname, region=r_fname, aux=[aux] )
File "/Users/mcenerney1/anaconda/lib/python2.7/site-packages/metrics/frontend/form_filenames.py", line 133, in form_file_rootname
fname = ''.join( basen, season, ''.join(vars), '_'.join(aux), postn )
TypeError: sequence item 0: expected string, NoneType found

I ran the same metadiags command, with slightly different paths, and did not get this sort of error.  I did get errors about certain requested variables not existing - that's basically ok, and anyway is addressed by another branch.  I also tried the specific diags command mentioned above, and it worked fine.
@mcenerney1, would you please try again?  But first run an "anaconda activate" so your Python is in a suitable UV-CDAT environment (anaconda/envs//bin/python), and reinstall uvcmetrics there.  Just running the above diags command should be enough to tell whether that helps.

After a couple more builds I could reproduce the problem which @mcenerney1 reported.  More to come...
BTW, I've removed lots of print statements including those seen by @doutriaux1

I'll pull it and give it a try.

All is fixed now - at least everything which @mcenerney1 , @doutriaux1 , or I have caught.

wait a bit longer.  After running many minutes, your metadiags line had an error, looks easy to fix though

When I run metadiags each execution of diags reports an error with "failed with code of 1".
But in fact they do run.  This must be some issue with multiprocessing. I'll look into it.

In AMWG_5_NCEP_TS_ANN.log I'm seeing a join issue
Traceback (most recent call last):
File "/Users/mcenerney1/anaconda/bin/diags", line 762, in
run_diags(o)
File "/Users/mcenerney1/anaconda/bin/diags", line 356, in run_diags
postn=postname, region=r_fname, aux=[aux] )
File "/Users/mcenerney1/anaconda/lib/python2.7/site-packages/metrics/frontend/form_filenames.py", line 133, in form_file_rootname
fname = ''.join( basen, season, ''.join(vars), '_'.join(aux), postn )

The "code 1" is pretty much meaningless so far as I can tell.  The vast majority of the failures are about requested variables which do not exist in the data.  If we use this extensively for testing purposes in the future (and we should), we should clearly separate errors like that from others.

@mcenerney1 the log file you saw, AMWG_5_NCEP_TS_ANN.log, refers to obsolete code - line 133 of form_file_rootname no longer looks like that; it calls underscore_join.  Would you please re-run?

My hunch is that there is some sort of benign error but the logger is interfering. For now we'll put this on the back burner.

The join error is gone.

This includes the templatefactory PR also. All tests passed!


Datagrid Expandable rows manually trigger

Select one ...  (check one with "x")
[ ] bug
[x] feature request
[ ] enhancement

Expected behavior
have a binding exposed so that I can expand specific row/rows with javascript.
Actual behavior
can only open rows by click on the carret.

@youdz
Please triage. I was under the impression users could already do this...

It already exists, we have a [(clrDgExpanded)] two-way binding on the rows themselves.


Update integration test for GLAuth to include SSSD

Description
Updates the integration test to include SSSD and shows a user being added through the ldap-client relation.
How was the code tested?

Ran on<EMAIL_ADDRESS>Juju 3.1.2
tox -e integration

Related issues and/or tasks
See linked Projects
Checklist

[x] I am the author of these changes, or I have the rights to submit them.
[x] I have added the relevant changes to the README and/or documentation.
[x] I have self reviewed my own code.
[ ] All requested changes and/or review comments have been resolved.

The kwarg for deploy is just base, not bases. Other than that your integration should pass no problem.
await asyncio.gather(
        ops_test.model.deploy(
            str(await glauth_charm),
            application_name=GLAUTH,
            num_units=1,
            resources=res_glauth,
            base=bases,
        ),
        ops_test.model.deploy(
            SSSD,
            application_name=SSSD,
            channel="edge",
            num_units=1,
            base=bases,
        ),
        ops_test.model.deploy(
            UBUNTU,
            application_name=UBUNTU,
            channel="edge",
            num_units=1,
            base=bases,
        ),
    )


Miscellaneous v0.12.0

I removed uninitialized(...) from perfect radix decoding. Don't do this, basically:
var error = false
let value = Self.uninitialized(as: UInt.self) {
    guard ... else { return error = true } // uninitialized move() is UB™
}

The safer version is also faster. Like, pre-trying-to-get-Swift-5.7-to-work faster.

See https://forums.swift.org/t/uninitialized-memory-trivial-types/66849/8

I removed uninitialized(_:) from perfect radix decoding. Don't do this, basically:
var error = false
let value = Self.uninitialized(as: UInt.self) {
    guard ... else { return error = true } // unenforced (?) UB because move()
}

The safer version is also faster, like pre-trying-to-get-Swift-5.7-to-work faster.

I realized while working on (#81) that I can de-duplicate lots of tests by calling Self tests from Digit tests:
func NBKAssertAdditionByDigit(...) {
     NBKAssertAddition(lhs, NBKDoubleWidth<H>(digit: rhs), partialValue, overflow)
     ...
}


AttributeError: UTime object has no attribute 'loss_functions'

I'm getting this error at the end of the first epoch when using the "MCP_Clean" callback .
Without (comment this callback), it doesn't crash.
(Tensorflow 2.4)

Hi,
Thanks for reporting this. You should be able to temporarily avoid this issue by downgrading to the recommended TF version 2.1. However, I will look into a better solution in 1 or 2 weeks when back from other activities.
Cheers,
Mathias

Now fixed, see https://github.com/perslev/U-Time/issues/39.


mbyte character support

Would you please add mbyte character support?
Underline all the same single character  in range [\u4e00-\u9fa5] is all I need.
Thank you very much.

This plugin already supports some multi-byte alphabets. But I cannot accept adding such a wider range characters because it doesn't work with set regexpengine=1. I don't think adding Chinese characters is useful because the entire line will be underlined.

You are right, underline a character is meaningless, I should find a way to achieve it when using *.


CORS error when access parquet from s3

I am using https://shell.duckdb.org/ to read a parquet from S3.
SET s3_region='us-east-1';
SET s3_access_key_id='xxx';
SET s3_secret_access_key='xxx';
select count(*) from read_parquet('s3://xxx/part-1.gz.parquet');

I also followed https://docs.aws.amazon.com/AmazonS3/latest/userguide/enabling-cors-examples.html to set CORS for S3. However, I still got the error
duckdb-browser-eh.worker.9db3d2ba08abf891a1f4.js:2 Access to XMLHttpRequest at 'https://eth-chain.s3.amazonaws.com/xxx/part-1.gz.parquet' from origin 'https://shell.duckdb.org' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Are you able to see what the actual response is in the network tab in your browsers devtools? You might be actually getting an auth error, for example

@Mause I attached the response above.

@hustnn as you can see in the screenshot, your actual issue is an authentication one. I would suggest making sure your aws credentials can actually access that s3 bucket

@Mause Actually I can access the S3 the same way with duckdb cli so I think s3 is accessible. Are you able to access the parquet in s3 from https://shell.duckdb.org/?

Perhaps verify that the headers being sent are the expected ones in the network console?

I currently have the exact issue @hustnn. I see swallowed auth headers for the OPTIONS request, and consequently a 403. Have you been able to solve this?

I currently have the exact issue @hustnn. I see swallowed auth headers for the OPTIONS request, and consequently a 403. Have you been able to solve this?

Before you can make cross origin requests to your bucket, you have to add cors config: https://docs.aws.amazon.com/AmazonS3/latest/userguide/ManageCorsUsing.html

Yes, I did. I experimented with different settings regarding allowed methods and headers. The only way I could get it to work was adding * to both, which isn’t ideal but works for now. Thanks!

Oddly, I couldn't get this to work with the wasm shell, but once I installed duckdb wasm lib in my local app it worked just fine with the same s3 parquet files-

Getting same error on local minio. Allowed all methods and '*' on the config and still getting CORS blocked with same error as the first comment

Can you share your config @medeirosjoaquim ?

@dude0001 I am running into the same issue even making my bucket public and setting up cors to be allow all origins. I am currently on duckdb-wasm 1.28.1-dev106.0. For my error, I always get the following: FAIL WITH: HEAD and GET requests failed:
Doesn't work on shell.duckdb.org either. Let me know how I can help debug.

@dude0001 I am running into the same issue even making my bucket public and setting up cors to be allow all origins. I am currently on duckdb-wasm 1.28.1-dev106.0. For my error, I always get the following: FAIL WITH: HEAD and GET requests failed: Doesn't work on shell.duckdb.org either. Let me know how I can help debug.

@Haklim733 what do you see in the S3 access logs? Can you share your exact CORS policy?

@dude0001 i made a silly mistake and didn't set the bucket policy to allow s3:ListBuckets. Works now.


Removed superfluous repetition

Having 4 examples which are solved by copy & paste is tiring

Makes sense @hellrich but this does not compile, also the test would have to change . thanks. https://github.com/scala-exercises/exercises-stdlib/blob/master/src/test/scala/stdlib/ObjectsSpec.scala#L14

I fixed my typo and updated the tests

thanks @hellrich !


Rez test release hook

A simple pre-release test hook that we have been using at AL for more than a year.
It just run rez test packageName==Version if the package that is being released contains the tests field
Related to https://github.com/nerdvegas/rez/issues/665

Isn't this actually a post-release hook? The package is already installed before its tests are run.
I think we're gonna need to test via a temp install, and abort the actual release if test(s) don't pass.

Maybe this code does not make sense without the point #2 in this other PR https://github.com/nerdvegas/rez/pull/759
When we run rez test, we do a local install and use that package (contents and metadata) to run the test, when this fails this pre-release hook aborts the release.

actually reading the code now, I just realize that this is using install_path which in our case that is a temp area.
We do have a specialized rez-unleash command that does a rez-release in a temp area and then if the tests passes get the package and checks it in our asset management system that puts it in the final destination.
I'll have a look when I'm back to work if I can make this more general for the community

I have to decline this PR as it's superseded by https://github.com/nerdvegas/rez/pull/811
To give context - the way this is now managed in rez-test avoids the need to build/install the package twice. Unfortunately this cannot be implemented as a pre-release hook, because the hook is not called at the appropriate time (and changing that would not make sense for most hook plugins).
Please see that PR for more details.
Thx
A


Upper tx validity could be very big on close

fix #592
To check before merging:

[ ] CHANGELOG is up to date
[x] Up to date with master

closing in favor of working on this in ensemble


set js2-additional-externs?

js2-mode has this handy js2-highlight-external-variables that lets you fairly easily notice undeclared variables, but it requires setting js2-additional-externs to stuff defined outside the file. I currently do

  (add-hook 'js2-parse-finished-hook
            (defun my-js2-post-parse-cb-tern ()
              (let* ((externs (mapcar (lambda (w)
                                        (when (equal (last w) '(js2-external-variable))
                                          ;; '(name . position)
                                          (cons (cadar w)
                                                (cadr w))))
                                      js2-parsed-warnings))
                     (car-equal (lambda (a b)
                                  (equal (car a) (car b))))
                     (externs-u (seq-uniq (remove nil externs)
                                          car-equal))
                     (define-extern (lambda (data)
                                      (when-let ((name (cdr (assoc 'name data))))
                                        (add-to-list 'js2-additional-externs name))))
                     (get-type (lambda (e)
                                 (tern-run-query define-extern
                                                 "type"
                                                 (cdr e)))))
                (mapc get-type externs-u))))

so I only look up symbols that actually have warnings, but perhaps there's a simpler/faster way that could be built in to tern-mode?

That might be possible, but I am not going to work on it (I don't use js2-mode, and this seems out of scope for the basic tern-mode)


fix(script): Enabling core dump for ndm daemon-set

When env GOTRACE was used, the ndm daemon set was not receiving the environment variable. Now we export the variable so that it is set in the environment where ndm daemon-set binary is run.
Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>

Codecov Report

Merging #219 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   51.61%   51.16%   -0.45%
==========================================
  Files          43       43
  Lines        1798     1798
==========================================
- Hits          928      920       -8
- Misses        805      811       +6
- Partials       65       67       +2

Impacted Files
Coverage Δ

cmd/ndm_daemonset/probe/eventhandler.go
34.69% <0%> (-12.25%)
:arrow_down:

cmd/ndm_daemonset/probe/udevprobe.go
63.24% <0%> (-1.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0414e0...c2a85af. Read the comment docs.


Symfony\Component\Debug\Exception\FatalThrowableError in GET /mship/auth/verify

Error in VATSIM-UK/Core (Laravel)
Symfony\Component\Debug\Exception\FatalThrowableError in GET /mship/auth/verify
Call to undefined method App\Exceptions\Handler::unauthenticated()
View on Bugsnag
Stacktrace
app/Exceptions/Handler.php:68 - App\Exceptions\Handler::render
app/Http/Controllers/BaseController.php:50 - App\Http\Controllers\BaseController::App\Http\Controllers\{closure}
app/Http/Middleware/TrackInactivity.php:41 - App\Http\Middleware\TrackInactivity::handle

View full stacktrace

An error linked to this issue has been marked as fixed in Bugsnag
Symfony\Component\Debug\Exception\FatalThrowableError in GET /mship/auth/verify


Models and data

What is the required format of this script for velocity models and data. How should the acquisition geometry be given?

For the sake of a good abstraction I believe we need a generic class that provides a handle on the model and data. Within this we have to implement/instantiate the appropriate reader for each dataset (possibly pass it into the constructor). This way we can process different datasets without cluttering the top-level API.
Thus - for the sake of interoperability with your code I'm happy for you to tell me what your "native" format is. If you give me a 2D dataset along the lines we discussed yesterday then I'll implement a concrete implementation of a reader to illustrate this.
Related question - I have a seg y reader in but it currently does not have a good home as it's required in different places. Is this a good home for I/O in general as it is here that we also have to integrate with containers from other data frameworks (e.g. TensorFlow).


Solve the prepared statement automatic-release difficulty

Note: This is not an especially high priority unless someone discovers a real need to release prepared statements from the server. Since the server treats prepared statements as being specific to a connection (and connections eventually end), this seems unlikely.

Suppose we want to use automatic resource management (ie, a scoped/RAII/refcounted/etc. wrapper) for Prepared to automatically release the statement from a connection when it's done being used (again, AFAIK, this shouldn't be necessary, but suppose we want to do it). This poses a problem:
What if the prepared statement becomes ready for release while there is already data pending on the connection? That is, while a result set input range has not yet been completely read. (This has been demonstrated as a realistic possibility, by @schveiguy.)
Commands cannot be sent to the server while data is pending for retreival. The usual solution mysql-native takes (as of v1.1.4) is to auto-purge any pending data when a command needs to be issued. For the most part, this has worked out well, because:

Issuing a command is explicit in user code, and
Attempting to read from a resultset which has been purged results in an exception, not a surprise end-of-data.

But the problem is, if we use automatic resource management to release a prepared statement, then issuing the command "release this prepared statement" becomes implicit and hidden. In situations such as the demonstration mentioned above, this hidden auto-purge would cause surprising problems that can be difficult or messy to deal with.
In an attempt to avoid this problem, ever since v1.1.4, mysql-native has implemented a "queued for release" system. When mysql-native is told to release a prepared statement, it doesn't release it immediately. Instead, it saves it in a queue (but mysql-native still treats it as having been released, from the user code's perspecive). Then, mysql-native waits until the next time an explicit command is issued. At that point, any pending data is auto-purged and any prepared statements queued for release are finally released for real.
Unfortunately, this create a new problem when the cleanup happens to be triggered during a GC cycle. We don't know ahead of time how many prepared statements might need to be released. So queuing one for release involves appending an item (ie which statement to release) to an array. This may trigger an allocation, but...
Allocations cannot be performed during garbage collection (it will throw an InvalidMemoryOperationError). If the cleanup (and thus, queueing it for release) happens to be triggered during a GC cycle, boom: InvalidMemoryOperationError.
So this cycle needs to be broken. I'm hesistant to hardcode the size of the "to be released" queue, because for anything short of soaking up several gigabytes (ie, not realistic) it still leaves the difficult question of: What should happen when the hardcoded limit's exceeded? I'm not sure I like any of the possible ways to answer that question.

I was just going to post this as a "to be mulled over", but in the process of writing this I think I may have actually come up with a solution:
As long as we never queue duplicates, nor statements that haven't been registered on the given connection, then we're quaranteed the release queue will never exceed the number of statements actually registered. So if the queue is resized upon registration of prepared statements, then it should never need to allocate when queueing for release. Thus, marking it @nogc should be possible, thereby enabling safe, reliable automatic cleanup. ~Also, switching the array to an AA should prevent O(n) complexity when checking the queue for duplicates.~(no good: "indexing an associative array...may cause GC allocation")
Hooray for pausing to take a step back.
Have I missed anything?

Ok, so this is unfortunately stalled again for now.
I think I could fix this, as I indicated above, by using a plain array, rejiggering things so allocations only occur upon registration or actual release, keeping duplicates out, and doing a bunch of string comparisons. But in terms of big-O, I don't like the algorithmic complexity that involves. Especially for something that seems to have questionable merit anyway.
As above, associative arrays are out, because apperently, merely indexing them can somehow cause GC allocation (from automatic re-hashing, maybe?).
So before I can move forward with this I'll need one of two things:
A. The right data structure. It must have good time complexity for this use-case and never allocate on lookup.
or better yet:
B. Compelling evidence that releasing prepared statements within a connection's lifetime actually does have practical benefit (and that closing and re-opening the connection isn't good enough).

Hm... you don't need the GC to store an array of integers (which is really all this is). Why not C malloc/realloc/free?
In any case, there is a separate problem besides the nogc problem, the GC can be running in any thread, not just the one that allocated the connection. So you potentially could be running into race conditions.
The way phobos solves this is...  But without help from the GC (setting thread affinity for a heap object for example), there's no good way to solve this without resorting to defensive locking for everything.
My recommendation: just use a C array, and avoid the GC altogether, and warn people about the dangers of putting the RC object in a GC destructed heap object.

indexing an associative array...may cause GC allocation

It's not the way it currently works, only adding or removing elements may use the GC. I suppose that's to allow for future implementation details. But in any case, using an AA I think is overkill. I can't imagine cases where you are going to have more than a few stale prepared statements.

the GC can be running in any thread, not just the one that allocated the connection. So you potentially could be running into race conditions.
The way phobos solves this is... Don't put RC structs in heap objects :)

Ah, ok, I see. I guess in some ways that does simplify the problem, then.

But in any case, using an AA I think is overkill. I can't imagine cases where you are going to have more than a few stale prepared statements.

True, but generally speaking, I don't like leaving open the possibility of pathological cases when I can avoid it. They just increase the number of dank, dark corners in a design.
But, it may not matter anyway: With the Prepared redesign in #157, I already need to use an AA anyway to lookup per-connection prepared statement info (such as the statement ID handle). So I just tossed another field into the payload to indicate "queued for release?", and ripped out all the old statement queue stuff. Based on everything you've said above, it sounds like that (along with the "don't put RC structs in heap objects" warning) should be suficcient.

So I just tossed another field into the payload to indicate "queued for release?"

Ooh, nice idea. You can store a pointer to the actual bool in the prepared statement object, then you don't need to bother with the AA from the Prepared side, and it becomes almost thread-safe (you could be truly thread-safe with atomics, but the worst I can see happening is that the connection skips releasing the first time and gets it the next time). Still not safe to call within the GC (it's possible the connection is already collected, and the bool is part of some other allocated memory).

I'm pretty sure this is a wontfix. The current system I have been using for a while, and it works awesomely. I don't think there's a good reason to proactively release prepared statements, but even if there is, it's possible to do it synchronously without RAII help.

I'm pretty sure this is a wontfix. The current system I have been using for a while, and it works awesomely. I don't think there's a good reason to proactively release prepared statements, but even if there is, it's possible to do it synchronously without RAII help.


Highlight Closer Deadlines (Frontend Styling)

Task

Provide a visual distinction to show deadlines that are approaching

Deliverables

CSS implementation for tasks (either a separate section for deadlines approaching or color coding)

Related to front end visualization task

Merged into release


Tracking results of existing trackers?

I noticed that the converted *.txt results are coming out. Is it still on the schedule?

Hello, I upload some  results of trackers for txt format to Baidu Driver.
Link:https://pan.baidu.com/s/1cl_7KabuKSUqVIjHysgPJA
Code:5ic7

Hello, I upload some results of trackers for txt format to Baidu Driver.
Link:https://pan.baidu.com/s/1cl_7KabuKSUqVIjHysgPJA
Code:5ic7

Hello, I upload some results of trackers for txt format to Baidu Driver.
Link:https://pan.baidu.com/s/1cl_7KabuKSUqVIjHysgPJA
Code:5ic7

Thanks.

Hello, I upload some results of trackers for txt format to Baidu Driver.
Link:https://pan.baidu.com/s/1cl_7KabuKSUqVIjHysgPJA
Code:5ic7

How do you convert it?

Can not unzip the rar file.

@ShiLongCheng Hi, could you supply some .txt format results of different trackers on UAV123 dataset?  thanks a lot!


Sweep: use 114514 spaces to indent

Sweep: you should edit prettier config instead.

Sweep: you should edit prettier config instead. Revert current changes.


Proposal for advice provider support for tiered-SMT

Describe your changes
A draft PR serving as a POC of how the tiered-SMT constrcution could be integrated as a MerkleSet.
Checklist before requesting a review

Repo forked and branch created from next according to naming convention.
Commit messages and codestyle follow conventions.
Relevant issues are linked in the PR description.
Tests added for new functionality.
Documentation/comments updated according to changes.

Closing this as we now have MerkleStore in the advice provider which is a backing store for the tiered SMT.


Add Xcelium support

Using enums instead of strings would avoid the need for the workaround in 6f8d1c5. Are there limitations here with any of the other tools?

I didn't include prim_assert.sv in the TB top, as it was already in ibex_dv.f.
(Comment: This looks fishy, as the file contains both macros and a package. This can cause issues when compiling using multiple compilation units.)


Terminal error when calling clasp logs with invalid projectId

Please search existing issues before creating a new one.
DON'T DELETE THIS! FILL THESE SECTIONS OUT!

Expected Behavior
When calling "clasp logs" with an invalid projectId, an error should be thrown, but the terminal should not lock down while perpetually trying to access logs that it can't find.
Actual Behavior
When executing "clasp logs" with an invalid projectId,  an error code is thrown like the following:
(node:8314) UnhandledPromiseRejectionWarning: Error: field [name] has issue [Invalid project resource name]
    at createError (/usr/local/lib/node_modules/@google/clasp/node_modules/axios/lib/core/createError.js:16:15)
    at settle (/usr/local/lib/node_modules/@google/clasp/node_modules/axios/lib/core/settle.js:18:12)
    at Unzip.handleStreamEnd (/usr/local/lib/node_modules/@google/clasp/node_modules/axios/lib/adapters/http.js:201:11)
    at Unzip.emit (events.js:194:15)
    at endReadableNT (_stream_readable.js:1103:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
(node:8314) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:8314) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are nothandled will terminate the Node.js process with a non-zero exit code.

but then the terminal continues to be locked on "Grabbing logs..."
Steps to Reproduce the Problem

Provide an invalid projectId string (for example, with a leading space)
execute "clasp logs"

Specifications

Node version (node -v): v10.15.1
Version (clasp -v): 2.0.1
OS (Mac/Linux/Windows): Mac

Thanks for the report! I can take a look at this.

Ok, I've looked into this, and see a handful of errors.
UnhandledPromiseRejectionWarning: Error: Project does not exist: project-id-396147393262364424
UnhandledPromiseRejectionWarning: Error: The caller does not have permission
UnhandledPromiseRejectionWarning: Error: field [name] has issue [Invalid project resource name]
The place this is failing is here:
https://github.com/google/clasp/blob/master/src/commands.ts#L450-L456
const logs = await logger.entries.list({
  requestBody: {
    resourceNames: [`projects/${projectId}`],
    filter,
    orderBy: 'timestamp desc',
  },
});

We can wrap this with a try/catch and additionally do some validation on projectId on our side.
I'm going to tag this as a good first issue and allow someone else to fix it.

Hi. Thanks for the fix. Do you have any idea when the next release with the fix will be available? I'm having such a hard time without clasp logs.
Thank's again.


OPCT-242: Introduce command 'get images'

Introduce opct get images to export all images used by OPCT (not for OCP cluster). It includes the flag --to-repository to export in the mirror format:

[x] create get images command
[x] update documentation
[x] patch plugins to support mirrors on etcdfio and MGM https://github.com/redhat-openshift-ecosystem/provider-certification-plugins/pull/48

Default:
$ ./build/opct-linux-amd64 get images
quay.io/ocp-cert/sonobuoy:v0.56.10
quay.io/ocp-cert/openshift-tests-provider-cert:v0.4.1
quay.io/opct/must-gather-monitoring:v0.1.0
quay.io/openshift-scale/etcd-perf:latest
registry.k8s.io/pause:3.8

with mirror flag --to-repository

$ ./build/opct-linux-amd64 get images --to-repository registry.example.com/validation
quay.io/ocp-cert/sonobuoy:v0.56.10 registry.example.com/validation/sonobuoy:v0.56.10
quay.io/ocp-cert/openshift-tests-provider-cert:v0.4.1 registry.example.com/validation/openshift-tests-provider-cert:v0.4.1
quay.io/opct/must-gather-monitoring:v0.1.0 registry.example.com/validation/must-gather-monitoring:v0.1.0
quay.io/openshift-scale/etcd-perf:latest registry.example.com/validation/etcd-perf:latest
registry.k8s.io/pause:3.8 registry.example.com/validation/ocp-cert:e2e-28-registry-k8s-io-pause-3-8-aP7uYsw5XCmoDy5W

/assign @rvanderp3

I think the documentation change will break compatibility with older versions for those reasons:

main branch does not have a CD release
documentation describing old versions will not be covered since the merged code is released. The long term solution is to versioning the documentation (planning in OPCT-251 )
short term solution is to split the doc changes in this PR to a buffer, or create new sections describing the changes for each OPCT release.
/hold

I think the documentation change will break compatibility with older versions for those reasons:

main branch does not have a CD release
documentation describing old versions will not be covered since the merged code is released. The long term solution is to versioning the documentation (planning in OPCT-251 )
short term solution is to split the doc changes in this PR to a buffer, or create new sections describing the changes for each OPCT release.
/hold

Problem resolved in https://github.com/redhat-openshift-ecosystem/provider-certification-tool/pull/83/commits/af7dc32a81d368bb622076aa5415ba20dcd3e715
/unhold

/lgtm
/approve


Global bloc/cubit instance access with named routes

First of all my apologize for creating this issue, but I am newbie in Flutter and haven't found any information in th net. I hope you can help me.
Preconditions:

There is an app which uses named routing and multiple pages
App uses bloc, hooked_bloc and get_it + injectable

What I want to achieve is to have globally accessible bloc/cubit instance (let it be some UserData data bloc which is needed on all pages). I ahve used HookedBlocConfigProvider (as described in your example). But realized that each page creates new instance of the cubit. Then I have tried to mark cubit with "@singleton" instead of "@injectable", but got an error that I tried to emit value on disposed bloc. So the only way I was able to achieve the result is to provide "closeOnDispose: false" to every call of useBloc hook. This works but I am not sure that this is a true way. There are a lot of recepies how to do this directly with BlocProvider and BlocProvider.value() (e.g. enclose MaterialApp with BlocProvider) but there are no solutions at all how to share same instance of cubit to all or multiple specific routes/pages with hooked_bloc + get_it + injectable.
Is it possible to implement such solution somehow?
Thank you in advance!

Hi @andrui
Sorry for a late response, we are quite busy right now.
One thing to mention is the current user data mostly should be accessible for any recreated cubit from another data source. So we should not tie data state with cubit state.
This approach allows cubits to be garbage collected along with pages, so no extra memory is kept. That's why there are no much examples how to do it.
Assuming that you really need that single, globally accessible cubit:
We agree that @singleton with flag closeOnDispose: false is one of proper solutions.
Just do not forget to close that Cubit when it is not needed anymore.


ModelOrderByInput is not generated

plugins v4.0.8
genrating crud and inputs with generateInputsString.
Given model:
model Petition {
  id String @id @default(cuid())
  user UsersUser?      @relation(name: "PetitionToUsersUser", fields: [userId], references: [id])
  user_temp String?
  createdAt DateTime   @default(now())
  updatedAt DateTime    @updatedAt
  source PETITION_SOURCE
  no Int?  @unique
  no_bak Int?  @unique
  title String?
  status PETITION_STATUS?
  category Category      @relation(name: "PetitionCategory", fields: [categoryId], references: [id])
  publicationDate DateTime?
  body String?
  signatureRequired Int?
  signatureDays Int?
  photo File?      @relation(name: "PetitionPhoto")
  gallery Attachment[]      @relation(name: "PetitionGallery")
  attachments Attachment[]      @relation(name: "PetitionAttachments")
  responsibleType String?
  responsible String?
  response String?
  responseDate DateTime?
  responseAttachments Attachment[]      @relation(name: "ResponsePetitionAttachments")
  votes Vote[]      @relation(name: "PetitionVotes")
  votesCount Int?     @default(0)
  history History[]      @relation(name: "PetitionHistory")
  categoryId String
  userId String?
}

Query:
type Query {
   # ...
    petitions(
      where: PetitionWhereInput
      orderBy: [PetitionOrderByInput!]
      cursor: PetitionWhereUniqueInput
      distinct: PetitionScalarFieldEnum
      skip: Int
      take: Int
    ): [Petition!]
}

in generated inputs following are present:

PetitionOrderByWithRelationInput
PetitionOrderByWithAggregationInput
PetitionOrderByRelationAggregateInput

But PetitionOrderByInput is not present (obviously leading to an error  Unknown type: "PetitionOrderByInput")

please see the release notes https://github.com/paljs/prisma-tools/releases/tag/v4.0.0

@AhmedElywa but it generated query with [PetitionOrderByInput!]

it's not back to plugins v4.0.8
you need to upgrade the @paljs/cli

@AhmedElywa oooh, sorry. that was old generated crud. I use custom generator as an extension to yours to be OpenCRUD compatible and after update it seems to be broken :( Will dig further. Sorry

@AhmedElywa fixed, thank you


Failed to create HNSNetwork in flanneld

Version:
PS C:\var\vcap\jobs\flanneld-windows\bin> (Get-WmiObject Win32_OperatingSystem).Version
10.0.17763

Description:
In Flanneld, we need to create HNSNetwork named cbr0. In the system, that network cannot be found:
PS C:\var\vcap\jobs\flanneld-windows\bin> Get-HNSNetwork
PS C:\var\vcap\jobs\flanneld-windows\bin>

Then flanneld attempts to create an network using HNSNetworkRequest method (see here), with the following request json:
{"Name":"cbr0","Type":"L2Bridge","Subnets":[{"AddressPrefix":"<IP_ADDRESS>/24","GatewayAddress":"<IP_ADDRESS>"}]}

Then flannel returns an error indicating that cbr0 already exist:
E0716 13:54:33.083784    2472 main.go:291] Error registering network: failed to create HNSNetwork cbr0: hnsCall failed in
 Win32: A network with this name already exists. (0x803b0010)

Please help us to get more insights on the issue, thanks!

@ksubrmnn or @daschott, can you please take a look?

Does this error persist after a restart-service HNS ? Can you run https://github.com/microsoft/SDN/blob/master/Kubernetes/windows/debug/collectlogs.ps1 ?
@Keith-Mange FYI.
One of the following should also be available on RS5 (can't recall which one)

Can you check if there are any NICs under RegKey:
\\Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\vmsmp\parameters\NicList

HNS.data file:
C:\ProgramData\Microsoft\Windows\HNS\HNS.data


how to replace the checkbox image

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

I need this for custom checkbox image
Current behavior
The library generate
<label class="datatable-checkbox">
        <input type="checkbox">
      </label>

Expected behavior
I want to
<label class="datatable-checkbox"> </label>
<input type="checkbox">

Reproduction of the problem

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Table version: 0.7.x
7.1.1

Angular version: 2.0.x

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

You can't currently unless you were to add a checkbox to your header template and build you own custom logic around that.
What you're asking for falls under theming the datatable. It is much easier to change a stylesheet than it is to provide a solution that can be restructured to fit every stylesheet.

If this is related to #645 you should probably close that issue as well.

What you're asking for falls under theming the datatable. It is much easier to change a stylesheet than it is to provide a solution that can be restructured to fit every stylesheet.

@adammedford Show the code me, please.How to set a picture on the checkbox.

If you link me the CSS framework you're using (Foundation/Material/Bootstrap/etc) I will fix it for you.

@adammedford  http://getbootstrap.com/getting-started/#download version 3.3.7.Thanks

I don't understand what you're asking for. Bootstrap doesn't have a custom image that it uses for check boxes.
Are you using Swimlane's included Material theme? If you aren't using it then bootstrap checkboxes will appear as normal.
Also, Bootstrap's checkboxes are inside labels, not after them as you asked for.

@adammedford  I have done custom template cell and replace image how I want


Fix issue in Java codegen where selectors returned ImmutableMapBuilder instances instead of Map

Added missing build statement to generated code. This issue caused JsonWriter.writeAny to fail as it doesnt handle the case where we pass in an ImmutableMapBuilder.

@anderssandven: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Thanks a lot for this! 🙏 I've pushed the .expected + one little repro test


Error in /collections endpoint

Hi,
when accessing https://openeo.mundialis.de/api/v1.0/collections the current server response is:
[
  {
    "description": "An internal error occurred while catching strds layers!"
  },
  400
]

It would be nice if:

the HTTP status code would not be a 200 OK but some 500, so that accessing clients treat it as "gone wrong" straight away,
the response was formatted as a proper error from the API spec,
that wouldn't happen at all of course :angel:

The error response for the collections endpoint is fixed in #72

Kept open till the server response is correct (there is still a deployment issue)

Deployment fixed, collections are back:
https://openeo.mundialis.de/api/v1.0/collections


Exporter/OcAgent: Handle null resource.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ad508e1). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #1763   +/-   ##
=========================================
  Coverage          ?   82.27%
  Complexity        ?     1977
=========================================
  Files             ?      291
  Lines             ?     9169
  Branches          ?      885
=========================================
  Hits              ?     7544
  Misses            ?     1330
  Partials          ?      295

Impacted Files
Coverage Δ
Complexity Δ

.../metrics/ocagent/OcAgentMetricsExporterWorker.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad508e1...2c91d82. Read the comment docs.


ERROR on <IP_ADDRESS>

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.22631.0
IntPtr Length: 8
x64: True
Date: 2023/12/04 9:45:47
Exception:
System.IO.FileNotFoundException: Could not find file 'C:\Users\bigsky\AppData\Local\PowerToys\Assets\PowerLauncher\app_error.dark.png'.
File name: 'C:\Users\bigsky\AppData\Local\PowerToys\Assets\PowerLauncher\app_error.dark.png'
at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode)    at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode)
at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
at System.Windows.Media.Imaging.BitmapDecoder.SetupDecoderFromUriOrStream(Uri uri, Stream stream, BitmapCacheOption cacheOption, Guid& clsId, Boolean& isOriginalWritable, Stream& uriStream, UnmanagedMemoryStream& unmanagedMemoryStream, SafeFileHandle& safeFilehandle)
at System.Windows.Media.Imaging.BitmapDecoder.CreateFromUriOrStream(Uri baseUri, Uri uri, Stream stream, BitmapCreateOptions createOptions, BitmapCacheOption cacheOption, RequestCachePolicy uriCachePolicy, Boolean insertInDecoderCache)
at System.Windows.Media.Imaging.BitmapImage.FinalizeCreation()
at Wox.Infrastructure.Image.ImageLoader.Initialize(Theme theme)
at PowerLauncher.App.<>c__DisplayClass19_0.b__0()
at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
✔ Expected Behavior
PowerToys AutoRun 0.75.1
❌ Actual Behavior
Autorun <IP_ADDRESS> insted of  0.75.1
Other Software
No response

/needinfo

Up dated.
Tanks.
2023年12月5日(火) 3:53 Heiko @.***>:

@BJ256 https://github.com/BJ256
Please update to the latest version. Maybe the bug is fixed there.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/30129#issuecomment-1839270603,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEN6ZZYIUPKDD3W7UDKBFFTYHYL2JAVCNFSM6AAAAABAFGPEE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGI3TANRQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

as @bj256 didn't respond, i'm going to believe this hasn't happened agian


POC mongo to bigquery operators and DAG

.... lol I should really stop pushing to git at 5pm on Friday. please feel free to perma-delete


SyncToy

Description of the new feature / enhancement
Please bring SyncToy back.
Scenario when this would be used?
Syncing between local folders / files and Sharepoint
Supporting information
No response

/dup #26


Simple Python Programs

can you assign this to me under hacktoberfest 2024 need contribution bro

Program to add two matrices using nested loop
X = [[12,7,3],
[4 ,5,6],
[7 ,8,9]]
Y = [[5,8,1],
[6,7,3],
[4,5,9]]
result = [[0,0,0],
[0,0,0],
[0,0,0]]
for i in range(len(X)):
for j in range(len(X[0])):
result[i][j] = X[i][j] + Y[i][j]
for r in result:
print(r)

Please contribute to the repo!

Assigned to you under hacktoberfest!

Happy contribution!

X = [[12,7,3],
[4 ,5,6],
[7 ,8,9]]
Y = [[5,8,1],
[6,7,3],
[4,5,9]]
result = [[0,0,0],
[0,0,0],
[0,0,0]]
for i in range(len(X)):
for j in range(len(X[0])):
result[i][j] = X[i][j] + Y[i][j]
for r in result:
print(r)

can u assign me under hacktoberfest-2024 with lable

can u assign me under hacktoberfest-2024 with lable

I have already assigned this issue to you under Hacktoberfest, please send PR of the code that you want to contribute!

i already send u

i already send u

You have just commited your changes and pushed in your own forked repo, please create a PR to this repo by clicking on contribute button on your forked repo! @uddipbisht

check it

check it

You have created PR in your own repo, please create in this repo!

Please assign this issue to me under Hacktoberfest2024


add missing log4j properties files for tests

This PR adds log4j properties files to test resources to avoid "no appenders" warnings.

Please resolve the merge conflicts. Thanks for your contribution.

I updated the license year and fixed merge conflicts. Thanks!

Pull Request Test Coverage Report for Build 3600

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 69.592%

Files with Coverage Reduction
New Missed Lines
%

common/src/main/java/com/netflix/conductor/common/metadata/tasks/TaskDef.java
1
98.98%

common/src/main/java/com/netflix/conductor/common/metadata/workflow/WorkflowDef.java
1
87.8%

core/src/main/java/com/netflix/conductor/core/execution/mapper/TaskMapperContext.java
3
53.52%

Totals

Change from base Build 3593:
-0.03%

Covered Lines:
11024

Relevant Lines:
15841

💛  - Coveralls


Update wallet request/responses to be simpler

POST /wallet/spend request now allows CurrencyCode or a full Currency definition
GET /wallet/estimatefee response is flatter (removed top-level key)
POST /wallet/spend response is less verbose (removed definition from amount, confirmed, unconfirmed keys and included only once)

Coverage decreased (-0.03%) to 38.054% when pulling bac13a199c4c34e6e7d05f239c9922ed9e549956 on wallet-resp into 52978121cedb432bb288afe4750507f10b82c384 on ethereum-master.

Lgtm


Release() in Plugin.cs never been called

Release() in Plugin.cs never been called, so when I close AB, it's not really closed, the plugin and AB instance still in task list

One of the users noticed that this problem happens when Broker OLE object is accessed (atleast that's what I think this object is).
Anyway, I use a workaround in my plugin where I simply watch AmiBroker process' (Broker.exe) window handle and when it becomes 0x0 I call "System.Environment.Exit(0)" (I assume that if AmiBroker closed it's window, my plugin should be disposed). Far from ideal but works for now.
In the distant future I plan to listen for WM_CLOSE event of AmiBroker window instead of polling process continuously and then I will probably contribute this to the project.

One of the users noticed that this problem happens when Broker OLE object is accessed (atleast that's what I think this object is).
Anyway, I use a workaround in my plugin where I simply watch AmiBroker process' (Broker.exe) window handle and when it becomes 0x0 I call "System.Environment.Exit(0)" (I assume that if AmiBroker closed it's window, my plugin should be disposed). Far from ideal but works for now.
In the distant future I plan to listen for WM_CLOSE event of AmiBroker window instead of polling process continuously and then I will probably contribute this to the project.

Hi, have you by any chance implemented a solution to this issue?

@n1ghthawk only what I described above, which is monitoring of the window handle and exiting when I detect that it became 0x0. It was good enough solution for me. Unfortunately, I've lost the source code so I can't give you the snippet.

@n1ghthawk only what I described above, which is monitoring of the window handle and exiting when I detect that it became 0x0. It was good enough solution for me. Unfortunately, I've lost the source code so I can't give you the snippet.

@triforcely thanks for replying. If I figure out a way I will post it here.


it is possible to use html in rasa webchat?

I'm needing to send HTML , i used markdownify but i didn't use all functionalities the HTML. Is it possible to use html?

me to

Hi, the webchat supports makrdown but not html


Thermal shield not plot in poloidal cross-section

The 'Thermal shield' is not shown on the Poloidal cross-section but is shown in the toroidal cross-section.
This image shows there is a grey line between the inboard blanket and VV in the toroidal cross-section, but there is no similar grey component in the poloidal cross-section.

@chris-ashe any ideas?

The Thermal shield should be flush with the TF coil (ie follow the inner edge of the TF coil)


Danger.systems

Setting up http://danger.systems/guides/getting_started.html#setting-up-an-access-token
@polydice/ios could you please add @polydicebot's DANGER_GITHUB_API_TOKEN to Travis CI env for this repo too? Thanks!

Merged, thanks!


fix(generated): make extend import into es6 compliant

Automated PR triggered by new code generation.
fix(generated): make extend import into es6 compliant
Generated SDK source code using:

Generator version 3.84.0
Specification version 1.0.0-dev0.1.5
Automation (cloudant-sdks) version 3466cbd

yeah, no, a side effect of automation. the fix is coming shortly.


.cirrus.yml: update runner to FreeBSD-11.3

simple update on 11 branch image.

the CI failed on the new 11-3 image.  want to take a look ?

@vapier looks like CI is the problem itself, agent is not responding. Already tried to re-launch it yesterday, trying again.

It looks like this failed, can you check it?
Thanks.

it keeps timing out without even starting, not sure anything can be done except getting lucky with free quota.

if their CI can't handle any real load, then trying to run against but always failing is going to just add noise and confusion to all our PRs right?

what's strange is that 11.2 and 12.0 check works fine, something with scheduling 11.3 image on their gcloud.
I'll close this for now and revisit later, checking 11.2 is still ok, and it did not create any confusion before.

thanks. happy to upgrade if we can rely on it :).


README updated with SPA info

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Just light update to README featuring how easy you can build SPA using AngularJS
What is the current behavior? (You can also link to an open issue here)
It just does not mention about SPA at all
What is the new behavior (if this is a feature change)?
A new paragraph added with the info about SPA
Does this PR introduce a breaking change?
No, very light README update
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

I signed it!

The Travis CI build failed, however I did not commit anything that might cause it. It's only readme text change. What should I do?

The Travis CI build failed, however I did not commit anything that might cause it. It's only readme text change. What should I do?

@vpavlov1199 The Travis build failed due to an incorrect commit message.
See: https://travis-ci.org/angular/angular.js/jobs/255645397
Validate commit messages in PR:
yarn run v0.27.5
$ "/home/travis/build/angular/angular.js/node_modules/.bin/commitplease" "e6d5fe7dea795d02eb2eab6ac69aca81a3edc99d..388b61785883115f052bc7a0566be89e9dac96ed"
Invalid commit message, please fix:
- First line must be <type>(<scope>): <subject>
Need an opening parenthesis: (
Commit message was:
README updated with SPA info

I'm not sure if this is necessary at this time. Most people know that AngularJS is best used for Single Page Applications, but new projects should be started with Angular. So it doesn't make sense to claim that AngularJS is the major JavaScript framework for SPAs.
The official docs  are also written on the assumption that you are building an SPA, so I don't know how useful it is to mention this specifically.
What we could do is mention SPA somewhere in the existing readme, as the word is currently not used at all.
But I don't think we need a complete paragraph.

I think it's a great thing to direct people to Angular as the go-to framework for SPA's these days. Mentioning SPA's for AngularJS wouldn't hurt (but I don't think it has alot of added value), but it definitely isn't the major SPA framework atm.

I'm going to close this PR because we cannot merge it in its current state, as we are either waiting for more information, tests are missing, or required code changes haven't been made.
Feel free to reopen this PR or open a new one if you have remdied the issues pointed out.


How to continue a learning?

How to load a existing genome file?

Ops. It's not in the docs, but here is the how to:

Click the window context in the Terminal
Navigate with up/down arrows
Click enter to load

Ok, tks!


Update README.md

Fix default configuration block.
Use lazy's opts =  functionality.

Good catch, thanks!


Remove updateStrategy in favor of strategy object

.Values.pod.updateStrategy is not being used anymore across the chart.
The leak of a strategy object causes https://github.com/authelia/chartrepo/issues/98

I have no clue how to access buildkite to fix those checks above.

Hey you just need to bump the chart version. Also thanks for the fix!

Chart version bumped.

I'll test the interaction today, but pretty sure it was just missed in some changes and you've fixed it.

@fernandopn I've had a deep dive into this section, and I believe I've made some rather bad decisions in the implementation here. I'll take over this locally.
Basically we need to cater for each of the apps/v1 types. Which currently we're not. Looking at the  API spec it looks like DaemonSet and StatefulSet's are similar, and Deployments are on their own.

@fernandopn can you test https://github.com/authelia/chartrepo/pull/101
You should be able to check it out using:
git clone https://github.com/authelia/chartrepo.git authelia_chartrepo
cd authelia_chartrepo
git checkout fix-strategy
helm template charts/authelia --values /path/to/values.yaml

See here for values format: https://github.com/authelia/chartrepo/pull/101/files?authenticity_token=Qw7kTRDdsIwin2gH4KnHZc5fJA6TCvf8ese1DDuyFhXcvPEZt9FtcE%2BFsGFGreMFETphAJQwpSV%2BYvG8W70MhQ%3D%3D&file-filters[]=.yaml#diff-520daef2a5af78cf9541eb9e868b8ba035141c39dea7a55030772d6c2a0797b5R205-R210

No problem at all!
Thanks @james-d-elliott for addressing the issue! =)


update Tessera version and ubuntu for xl-machine-executor

Signed-off-by: Sally MacFarlane<EMAIL_ADDRESS>
Update tessera docker image version to 22.1.6
Update ubuntu version on xl machine executor in Circle CI config - this update is required for the tessera 22.1.6 docker image to run

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

[x] I thought about the changelog and included a changelog update if required.

with the ubuntu change reverted, the Tessera enclave tests fail https://app.circleci.com/pipelines/github/hyperledger/besu/16658/workflows/4205df7c-3355-4e46-b206-0dacfa2535d0/jobs/99852
org.testcontainers.containers.ContainerLaunchException: Container startup failed
	at app//org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:345)
	at app//org.testcontainers.containers.GenericContainer.start(GenericContainer.java:326)
	at app//org.hyperledger.enclave.testutil.TesseraTestHarness.start(TesseraTestHarness.java:83)


1.9.2-RC2: Macos m1 Failed to load the librdkafka native library.

Description
Using https://www.nuget.org/packages/Confluent.Kafka/1.9.2-RC2, gives me
System.DllNotFoundException
Failed to load the librdkafka native library.
   at Confluent.Kafka.Impl.Librdkafka.TrySetDelegates(List`1 nativeMethodCandidateTypes)
   at Confluent.Kafka.Impl.Librdkafka.LoadOSXDelegates(String userSpecifiedPath)
   at Confluent.Kafka.Impl.Librdkafka.Initialize(String userSpecifiedPath)
   at Confluent.Kafka.Producer`2..ctor(ProducerBuilder`2 builder)
   at Confluent.Kafka.ProducerBuilder`2.Build()

on Macbook M1 Pro.
How to reproduce
Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[x] Confluent.Kafka nuget version. 1.9.2-rc
[x] Apache Kafka version. latest
[ ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[x] Critical issue.

RC2 lacks an M1 build, will be available in a later RC

resolved in 1.9.2


Fixes a cache issue in CacheState

Here the initial context for Cull StateAttribute
enable = true , mode = BACK
-> state.applyCullAttribute (enable = true, mode = back)
state.enable = true , state.mode = BACK ( buffer.enable = true, buffer.mode = back )
-> state.applyCullAttribute (enable = false, mode = back)
state.enable = true , state.mode = BACK ( buffer.enable = false, buffer.mode = back )
-> state.applyCullAttribute (enable = true, mode = front)
state.enable = true , state.mode = BACK ( buffer.enable = false, buffer.mode = front )
The code to check the update was like that:
if (state.enable !== enable) {
  buffer.enable = enable;
  data.changed = true;
}

if (!enable) return;

if (state.mode !== attribute._mode) {
  buffer.mode = attribute._mode;
  data.changed = true;
}

The logic was wrong because if new state is not different from last state
applied then buffer.enable was not updated. The problem was if mode was
different then buffer.enable did not have the good value. So the general logic
should be is something change, then update all buffer field to be sure to be up
to date when applying it to gl.

not easy to understand each stateCache member variable, and the fast it's applied only on draw call
perhaps an exlplanation over an abstract state cache would help
StateCache{
buffer: {} // comments what "state" (gpu, state or stateCache to be applied to GPU)
state {}, // comments what "state" (gpu, state or stateCache to be applied to GPU)
enabled : // enabled gpu/ cache / state
}


Platform Support: Android, iOS, Web-assembly

Regarding the Platform Support I believe Android, iOS, Web-assembly should be at a higher tier at least 2 but ideally, they should be tier 1. Windows should be a tier 1 platform.
Also, there should be at least 1 BSD variant as a tier 1 platform.

The is more of page is a status page, not a roadmap :) Also putting everything on the highest point takes out focus and makes such a categorization useless in the first place.
For a lot of discussion about WebAssembly support see #829.
This feels like something for our forum, have a look at it. Meanwhile closing here since there's nothing technical to discuss really or if they would be then the issue is in too broad scope to do it effectively :)


Add opengraph et al

See: https://forum.indiebits.io/t/rereading-documentation-client-arguments-largely-redundant/39

Hey, thanks for quickly picking this up!
Wouldn't that rather go into https://github.com/boringproxy/boringproxy.io/issues ?

Ah yes you are correct.


Update comments after closing or opening a thread

After close or open a thread there is an error in the url for comments.

The error is showing
No route found for "GET /mi-admin/proyecto/313/undefined/proyecto_313/comments"

If I define a value to variable fos_comment_thread_api_base_url
var fos_comment_thread_api_base_url = '/web/app_dev.php/api/threads';

when you update the thread does not show the buttons to manage
Before closing the thread

After closing the thread

Reloading the comment tree will show the correct buttons.


[Issue #4284] Removed HAVE_CX11

Removed #ifndef HAVE_CXX11
Issue #4284

Thanks for the patch. There should be many more such instances.


serializer example on @jsonObejct

I used serializer on @jsonObejct, but it has error below,
Argument of type '{ serializer: (myClass: MyClass) => any; }' is not assignable to parameter of type 'ParameterlessConstructor<{}>'.
  Object literal may only specify known properties, and 'serializer' does not exist in type 'ParameterlessConstructor<{}>'.ts(2345)

My codes like
@jsonObject({
  serializer: MyClass.toJson // error spot
})
export class MyClass extends BaseEntity {
  static toJson(myClass: MyClass): any {
    //serialization from MyClass to json.
  }
 :
}

Anyone give me some example using serializer on @jsonObejct?
Or any idea?

Hey Chris-runn, unfortunately serializer option on jsonObject is not available. You can use it on a jsonMember decorator. Could you describe what you are trying to achieve?

Depending on a boolean variable in MyClass, I want to decide whether to serialize MyClass itself.
Is it possible jsonMember decorator?

It should be. You can provide a custom function to serializer option in jsonMember. In there you could check your variable and depending on the value call TypedJSON for further serialization or return undefined to skip this property.

class Obj {
  @jsonMember
  public selected: boolean;
}

class MyClass {
  @jsonArrayMember(Obj)
  public objArray: Obj[];
}

Can you write custom serialization?
I want to decide whether to serialize Obj in objArray, depending on selected variable in Obj.

You could have something like this. I've also added a test for that. So, you can take a look in the repository.
    @jsonObject
    class Inner {
        @jsonMember
        prop: string;

        shouldSerialize: boolean;
    }

    function objArraySerializer(values: Inner[]) {
        return TypedJSON.toPlainArray(
            values.filter(value => value.shouldSerialize),
            Inner,
        );
    }

    @jsonObject
    class Obj {
        @jsonArrayMember(Inner, { serializer: objArraySerializer })
        inners: Inner[];

        @jsonMember
        str: string;
    }

I applied your code to my project and it works well!
Thanks a lot!

And I have another question.
Can I exclude specific variables from serializing by annotation?
@jsonObject
class Obj {
    @jsonMember({ serializer: value => null })
    str: string;
}

This result is { "str": null }.
But, I want to the variable itself not to be serialized. How to?

I found it out. Instead of "null", you can use "undefined".
@jsonObject
class Obj {
    @jsonMember({ serializer: value => undefined })
    str: string;
}

The result of serializing this code is blank { }.


[npm / enterprise proxy] Allow download of electron binaries from a custom URL

Hi guys,
we are currently facing enterpriseland issues with the electron binaries donwloaded seperately by the npm install package.
We have a strict proxy and firewall in place. npm packages are tunneled via our private repository. Sadly electron doesn't support (or it isn't documented) a way to dowload it's binaries from a custom location. That's why the npm install of electron can never succeed on our servers behind the security layers.
Take a look at phantomJS parameters that solve that issues:
https://www.npmjs.com/package/phantomjs#downloading-from-a-custom-url
Please consider adding such a parameter to electron as well so that users behind proxy and firewall can provide the binary from an internal server.
Thanks alot, best regards,
Jan

See the README of electron-download.

You can set the ELECTRON_MIRROR or NPM_CONFIG_ELECTRON_MIRROR environment variable or mirror opt variable to use a custom base URL for grabbing Electron zips. The same pattern applies to ELECTRON_CUSTOM_DIR and ELECTRON_CUSTOM_FILENAME:

https://github.com/electron-userland/electron-download
There are environment variables / npm config variables for overriding all aspects of the Electron download URL 👍 You can also configure electron download to use your proxy correctly 👍

RTFM FTW, thank you :-)


API deployer is failing (v1.1)

Since the update to v1.1 the deployer of type API seems to have issues.
We are using this deployer type as publishing connection for our projects.
No matter the URI specified, an error message is shown:

Using docker-compose -d up locally:

Using our production server:

The production environment used to work fine before the upgrade.

@silend does this error come up when you publish content, or somewhere else? Can I see the connection's JSON from the "advanced" view?

@silend can you check with the lastest master? It seems the Path.join function in the HashBrown.Models.Deployer::getPath method was to blame. It was appending a "/" to the "https"

@mrzapp Yes, the current version in master works just fine 👍

@silend OK, then I'll create a new release tag with the fix on stable


Manual upgrade to 7.4.3

PR Summary

PR Context

Ping @TravisEz13 @StevenBucher98

Superseded by #1250, closing.


Bundled Protractor Binary Not Working in 4.0.3

Using a Windows 10 machine with Node v4.4.4, I recently updated our Protractor test project from protractor v3.3.0 to v4.0.3. Now, when I run a globally installed instance of protractor
protractor my.conf.js

everything works as before. When I run the protractor binary installed as part of the project
cd myproj
npm install
my_project/node_modules/.bin/protractor my.conf.js

I get strange behaviour. Either the test run crashes with an error 100 or all tests pass but run nearly instantly and protractor finishes with an error 100.
Both protractor binaries are v4.0.3.
This behaviour did not happen with protractor v3.3.0. This occurs when using Chrome and running against an instance either on a Selenium Grid or a local instance.

Hi! This looks like a support question. Please ask your support questions on StackOverflow, Google Group discussion list, or Gitter. For more information please reference https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions
Thank you!


gradio/webui support

any chance to have a one click installer?
something like automatic1111

Terrific idea! We're actively exploring solutions to develop a standalone desktop application that can be easily installed with a single click. In reference to "automatic1111," are you referring to the GitHub repository at https://github.com/AUTOMATIC1111/stable-diffusion-webui?

Yes I mean automatic1111, thank you for quick replay bro. Using gradio

Thank you for the information, I will look into that as soon as possible.


Add a macro to reduce the lazy_static boilerplate

The documentation recommends the use of lazy_static. This makes for quite a heavy code and it often breaks the reading flow:
fn some_helper_function(text: &str) -> bool {
    lazy_static! {
        static ref RE: Regex = Regex::new("...").unwrap();
    }
    RE.is_match(text)
}

Compare this to other languages where regular expressions are built-in.
I think a macro could make using regexes in rust more enjoyable:
fn some_helper_function(text: &str) -> bool {
    regex!("...").is_match(text)
}

It could be named otherwise, for example lazy_regex!, if we want to keep regex! for when we also get compile-time regex compilation.
An implementation of the macro could be this (thanks Shepmaster for the fix):
macro_rules! regex {
    ($s: literal) => {{
        lazy_static! {
            static ref RE: Regex = Regex::new($s).unwrap();
        }
        &*RE
    }};
}

A downside is that it adds a dependency but lazy_static has virtually no cost and is already advocated in the documentation.
A variant that I didn't investigate would be to wrap the call to RegexBuilder instead and allow flags in the construct.

I appreciate the request, but I 1) do not want to add a dependency on lazy_static! and 2) I am holding out hope that once_cell will supplant lazy_static!. The only reason I haven't migrated everything to it yet (including the docs) is because it requires a bit newer version of Rust that I haven't moved to.
My take is that if you are bothered by the use of lazy_static!, then I'd advise just defining your own macro for this.

I am holding out hope that once_cell will supplant lazy_static!

In such a world, would you implement a macro that uses once_cell, or does the dependency concern still reign?

Not sure. Adding a dependency would still be a concern, although it could be behind a feature gate I suppose. The other issue here is that the API suggested hides an unwrap. Some related discussion on that. Another concern is really whether this "should" be in the domain of the regex library itself. I think it's reasonable to ask folks to compose crates like this, although I don't feel that strongly and certainly see the value in coupling.


Consuming Bond with FindPackage (and using modern CMake)

I am trying to integrate Bond with our buildsystem to evaluate it properly, but I am running into various problems:

Bond installation does not provide a BondConfig.cmake file, which can be consumed by other projects
Bond does not export CMake functions to generate code from bond files (though they are defined in cmake/Bond.cmake, like the add_bond_codegen function.
Bond exports its targets to bond.cmake (which is good), but they include absolute paths to the boost library. Hence, the bond package is not relocatable, and I cannot distribute a bond package build by a CI server to be consumed by the users.

If bond used modern CMake, imported targets for libraries, code generation functions and provided a BondConfig.cmake file, it would be much easier to integrate.
Would you be interested for me to work on a PR to address this issues? I am not quite sure how much work it will be,  I have not yet looked at all of the CMake files for this project yet.

Yes, please submit PRs for these. No one who works on Bond is a CMake expert, so we're happy to have help!
For the add_bond_codegen, we'll want to make sure that the interface that we ship publicly is a sound one, as the Bond project considers build rules part of its interface and we try to minimize breakage.

Thank you for the feedback!
I totally agree that if bond exposes an API for cmake code generation, that it should be stable (and backwards compatible).
The options that you currently provide for "add_bond_codegen" make a lot of sense, though I don't really get the TARGET one.
Also I'd prefer to add another function, maybe called bond_target_cpp(my_exe [same arguments as add_bond_codegen] file1.bond [fileX.bond]) which basically works similar to add_bond_executable, but the files can be added to any target (e.g. shared / static library, executable...).
Also are you set on the bond generation functions to be called add_bond_.... It would be more in line with other generators (such as protobuf, capnproto), to call the functions bond_generate_<language>.
Also, do you have any requirements on the cmake_minimum_required? Currently it is set to 3.1 but since then CMake has added multiple nice features, especially declaring boost targets in the provided FindBoost.cmake script. Are you set on this version or would it be acceptable to upgrade it? And which version would be acceptable? (Ubuntu 16.04 comes with 3.5.1, 18.04  with 3.9.1 but they now provide ppa's to upgrade, on Windows it needs to be installed manually anyways.).
Also I can just see how far I get, create a PR and we can discuss the changes.

I have made a first draft which allows installation / consumption of Bond via CMake.
It's not yet mergeable, but I do have a few question:

Are RapidJSON and Boost public dependencies of Bond (e.g. do public headers of bond include both RapidJSON and/or Boost)? (Some of the includes of the samples do, but again I am not sure if they are all part of the public API)
Should all Bond examples (from the examples folder) be buildable against a bond installation? Or do some of them rely on Bond internals?
(e.g. the import example, the file import.bond includes import "bond/core/bond.bond" but this currently raises an error, because it cannot be found.)
The info about CMake miminum required version is very important
Thanks for the feedback 😄

Thank you for your patience. I've been traveling for the Thanksgiving holiday in the United States and am just catching up on things now.

The options that you currently provide for "add_bond_codegen" make a lot of sense, though I don't really get the TARGET one.

The TARGET argument is used to create an explicit codegen target in the build dependency graph. It's currently used, for example, in the CMakeLists.txt for the unit tests, as the tests all share a bunch of .bond files in common. In the unit tests, we generated the C++ files once with different options for some files, then we use them in various unit tests. Without something like this, each unit tests would perform its own code generation. If there's a more CMakey way to do this, I'm all ears.

Also I'd prefer to add another function, maybe called bond_target_cpp(my_exe [same arguments as add_bond_codegen] file1.bond [fileX.bond]) which basically works similar to add_bond_executable, but the files can be added to any target (e.g. shared / static library, executable...).

That makes sense to me. The pattern would be something like this, I assume:
add_library(foo source1.cpp source2.cpp)
bond_target_cpp(foo source3.bond)

add_executable(bar source3.cpp)
target_link_libraries(bar foo)
bond_target_cpp(bar source4.bond)

Would target_bond_cpp fit the CMake naming scheme better?

Also are you set on the bond generation functions to be called add_bond_.... It would be more in line with other generators (such as protobuf, capnproto), to call the functions bond_generate_<language>.

The name can be changed. bond_generate_cpp &c sound good to me.

Also, do you have any requirements on the cmake_minimum_required? Currently it is set to 3.1 but since then CMake has added multiple nice features, especially declaring boost targets in the provided FindBoost.cmake script. Are you set on this version or would it be acceptable to upgrade it? And which version would be acceptable? (Ubuntu 16.04 comes with 3.5.1, 18.04 with 3.9.1 but they now provide ppa's to upgrade, on Windows it needs to be installed manually anyways.).

We still need to stay compatible with Ubuntu 16.04. Raising the minimum to CMake 3.5.1 is fine, but beyond that is a larger discussion where we'd need to weigh pros and cons.

Are RapidJSON and Boost public dependencies of Bond (e.g. do public headers of bond include both RapidJSON and/or Boost)? (Some of the includes of the samples do, but again I am not sure if they are all part of the public API)

Bond requires Boost to be findable on the system both to build Bond and to consume Bond. A CMake install of Bond should not install Boost. Similarly for RapidJSON. However, historically, RapidJSON has been provided by Bond via a submodule and its headers have been installed by a CMake install, unless -DBOND_FIND_RAPIDJSON=TRUE is set. We should preserve that behavior.

Should all Bond examples (from the examples folder) be buildable against a bond installation? Or do some of them rely on Bond internals?
(e.g. the import example, the file import.bond includes import "bond/core/bond.bond" but this currently raises an error, because it cannot be found.)

None of the examples rely on Bond internals. The import example's import "bond/core/bond.bond" line is how that file should be imported in a consuming project. This probably means that bond_generate_cpp needs to make sure that the installed location of bond/core/bond.bond is added to gbc's search path when its being used from an installed version.
The C# MSBuild code generation targets have a similar pattern using a MSBuild variable BOND_INCLUDE_PATH:

BOND_INCLUDE_PATH definition for use from NuGet packages
BOND_INCLUDE_PATH use
BOND_INCLUDE_PATH override used when building Bond itself


Fixed issue in Cloud SQL pyspark test job

Fixed DataFrame filter to make the job pass

I signed it!

Thanks! Sorry for the delay. Tested cleanly.


Fix keyboard navigation after back button used.

Fixes #325

FWIW I couldn't repro the issue 🤷♂ (Desktop Safari)