Decorating views

How about we use decorators instead of having an explicit registry?
# quick example of a ping pong bot
from bottery.conf.patterns import DefaultPattern, Pattern

@Pattern('ping')
def pong(message):
    return "pong!"

@DefaultPattern
def not_found(message):
    return "Sorry, I didn't understand you :/"

@nicoddemus  Correct me if I am wrong, but to use this guys in that way, we will need to have a global var inside bottery.conf.patterns, or make a kind of filter using a property inside the function. Isn't better do something like:

from bottery.conf.patterns import BotPatterns

bp = BotPatterns()

@bp.Pattern('ping')
def pong(message):
    return "pong!"

@bp.DefaultPattern
def not_found(message):
    return "Sorry, I didn't understand you :/"

patterns = bp.get_patterns()

This approach open space to insert params in get_patterns() and BotPatterns() call :)

Hey @guidiego!

Correct me if I am wrong, but to use this guys in that way, we will need to have a global var inside bottery.conf.patterns

Yes, but very much as we have a patterns global variable now 😉

make a kind of filter using a property inside the function

You mean make the decorator add an attribute to the decorated function (func._bottery_pattern = True) and then we just dir() the module and get all functions with that attribute set? Yes that's another possibility.
Your BotPatterns() suggestion is good, but complicates usage a little bit I think... do we have an idea of a custom configuration for a set of patterns we could have?
FWIW I like the "decorated attribute" approach (but not by a large margin), but we might want to decide first if we want to have this API before delving too deep into the implementation.

@nicoddemus like your comment!

do we have an idea of a custom configuration for a set of patterns we could have?

Maybe some whatsaap and github stuff as well. Slack, Telegram e Messenger are the only 3 platforms that I know that support buttons, and custom stuffs in body. We can have a option to doesn't sent a kind of message to unsupported platforms, or, to use a custom parser.
Another good point about decorators (we can open another issue for it), is if one day we decided to go to this kind of approach:

@bottery.Pattern('ping')
class MyView():
     def parser():
          # return basic_parser
     def telegram_parser():
          # return message for telegram
     def slack_parser():
          # return message for slack

Today I Implement a class called Response, that receive the parsed message as attributes:
https://github.com/rougeth/bottery/pull/78

Howdy @guidiego!

Maybe some whatsaap and github stuff as well. Slack, Telegram e Messenger are the only 3 platforms that I know that support buttons, and custom stuffs in body. We can have a option to doesn't sent a kind of message to unsupported platforms, or, to use a custom parser.

I'm not sure how this comment maps to a set of patterns, which is what I understood from your earlier example:
bp = BotPatterns()
bp._custom_config = 'bleh'

Can you provide an example what you mean by "support buttons" in this case? And why it would be a good idea to have this defined in different BotPatterns? Perhaps that will clarify things for me.
About your class decorator example, I believe having different ways to parse bodies was one of the benefits of having explicit Pattern classes (like RegexPattern, NTLPattern, etc), although I don't think they do anything about parsing the response from the view.

Sure that I can @nicoddemus, lets start with a example:
from bottery.conf.patterns import Pattern
from bottery.response import Response
from bottery.widget.telegram import telegram_response, reply_keyboard_markup

def pong(message):
    telegram_kb = reply_keyboard_markup([['First'], ['Second']])
    telegram = telegram_response(message.user.id, 'test', reply_markup=telegram_kb)

    return Response(telegram=telegram)

patterns = [
    Pattern('ping', pong),
]

In #78 this is how I insert custom keyboard buttons on telegram response. Let's imagine that one day we will do something like that for Slack or Messenger. I my mind bottery wants to be a easy way to do that cross-platform bots, so I need to understand that telegram.reply_keyboard_markup is similar to an another widget in other platform, something like slack.foo_bar_reactions and both represents something like default.keyboard_custom. Once that I add default.keyboard_custom, I will call telegram.reply_keyboard_markup to telegram response and slack.foo_bar_reactions to slack one. But let's imagine that I have a whatsapp message to be delivered too, and whatsapp didn't support this kind of addon, so I have 2 options:
1 - Create a custom parser (add some more text to receive the options in other hand)
2 - Omit the message
In BotPatterns() approach we can use something like:
bp = BotPatterns()
bp._whatsapp.omit = #logic
bp._whatsapp.widget.keyboard_custom = customImplementation

@guidiego In your example, you'll want that the bot respond or act in some way depending on which button the user clicked, right? If whatspp doesn't implement that kind of button, there is no way to continue the flow like telegram, so, we would need two different views.
I believe that trying to make this relations on features that each platform implement will be something really hard to do and maybe out of our scope.


support Hermetic build mode

/retest

closing as the changes in this PR are already incorporated by #201


Deploy Seaport Module for use with NFTEarth Exchange

Deploy Seaport Module contract for exclusive use with NFTEarth exchange.
NFTEarth Contracts and Information:
Conduit    address    0xFA29f9A402157672C2F608d193526A00C6B429Af
Channel    address    0x0f9b80fc3c8b9123D0aEf43Df58ebDBC034A8901
isOpen     bool       true
Conduit Controller    0x3E173b825ADEeF9661920B91A8d50B075Ad51bA5
Seaport Module deployed on Optimism Mainnet currently reflects OpenSea's marketplace only at this contract address 0x00000000006c3852cbEf3e08E8dF289169EdE581:
ISeaport public constant EXCHANGE =
ISeaport(0x00000000006c3852cbEf3e08E8dF289169EdE581);
function acceptERC20Listings(
ISeaport.AdvancedOrder[] calldata orders,
ERC20ListingParams calldata params,
Fee[] calldata fees
)
external
nonReentrant
refundERC20Leftover(params.refundTo, params.token)
chargeERC20Fees(fees, params.token, params.amount)
{
// Approve the exchange if needed
_approveERC20IfNeeded(params.token, address(EXCHANGE), params.amount);

We have decided to go with our own router to be injected to SeaportModule. So here are the contracts deployed:
Router: 0x7c173d178B437287608d6105886DdC77CD40c089
SeaportModule: 0x2140Ea50bc3B6Ac3971F9e9Ea93A1442665670e4


Feature/api

What has changed and why?

Removed a few values in CSP (public/index.html) which were not being used
Removed HashRouter as no longer using redux wizard on forms, now the last page is being accessed via window.location

How to test this change

[ ] has automated tests
[ ] at least one a reviewer ran the code
[ ] tested in small screen

noting I'm still getting the address loook up not working -- but we can look at that when we map it to valuation_id.

I think it's the internet being crap here -- but hey the app needs to work when the internet is snails pace and flaky

Sweet. all posted and came through on the rails app


Setting the calender's scope/view according to admin demands.

Setting the calender's scope/view according to admin demands.

lior, when the time comes I want you to get the calendar settings from the database and assign them to the current calendar design when generating it.

o.k. this part is required cooperation from the sever team.

tell me what do you need to pull from DB.

thank you all the, see the matter as closed


IDENTITY-6377:Add db2 changes to the migration script

Add db2 changes to the migration script

This PR has some 5.4.0 script changes also. That must be removed since this is 5.2.0 to 5.3.0 migration script. Removed the 5.4.0 changes with https://github.com/wso2/product-is/pull/1386


fix: Direct calling of node stop and start commands

Description
Fixes the way flags are being passed in the declaration of the solo node start and solo node stop commands.
Related Issues

Closes #635

:tada: This PR is included in version 0.31.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Integration showing twice, while one unauthenticated?

What can I do to remove the unauthenticated integration?
Alexa is working fine, but I cannot remove the unauthenticated integration as there is no remove button for it. Which file do I have to edit to remove it?

I have same issue... and reconfigure won't work. All the time it say password incorrect. (password is correct, tried login on Amazon itself also)

Removing the integration, reboot HA and add it again won't work also ... keeps saying password incorrect

Please fill out the template.


Dark mode

This will require a significant branding collaboration and update, so let's park this until we've got more availability.


Nav bar to wide (mobile]

With browser in Android , Brave and /e/OS Browser (Cromite fork) the hamburger menu button is out of the normal view, I have to swipe far to the right.
No matter if I enable the container fluid in the theme settings (admin panel).
I did a diff and only the following are the differentes in the code.
Enable container fluid : deaktive

…

Enable container fluid : enabled

…

How can I fix this?
With custom.css?
TIA

Hello.
You have checked that you do not have text strings that are too long, such as a very long email address. This causes the text to overflow on small screens, causing the width of the page to be greater than that of the screen.
If you have already checked this and can't find a solution, could you put the site in an online address so I can see it?

Here you are some information about the containers on bootstrap used in Mundana theme.
The decision about using one of them is yours.
Mundana theme has implemented container-lg and container-fluid


Bugfix: Model spatial column update using Expression

closes #79

@MatanYadaev Needs this in 2.10.0

@MatanYadaev PR for version 2 https://github.com/MatanYadaev/laravel-eloquent-spatial/pull/86


Fix cursor in image modal

Details

Cursor changes in Image Modal
https://github.com/Expensify/App/issues/10513#issuecomment-1230344451
Fixed Issues

$ https://github.com/Expensify/App/issues/10513
Tests

1. Go to profile
2. Tap on avatar > Upload photo
3. Hover over the Avatar Image > Cursor should be move
4. Hover over the Slider knob > Cursor should be pointer

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

1. Go to profile
2. Tap on avatar > Upload photo
3. Hover over the Avatar Image > Cursor should be move
4. Hover over the Slider knob > Cursor should be pointer

[x] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/111683206/187513138-c85f4b24-271d-4427-a1bb-ffc2f0ab5f45.mp4
Mobile Web

Desktop

https://user-images.githubusercontent.com/111683206/187513367-0e478470-c9d2-4f48-acf7-be4d79c38d9d.mp4
iOS

Android

I have read the CLA Document and I hereby sign the CLA

recheck

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA.

recheck

You put a . at the end of the message. It needs to be exactly this
I have read the CLA Document and I hereby sign the CLA

Also no need to say "recheck" 😄

I have read the CLA Document and I hereby sign the CLA

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Luke9389 in version: 1.1.97-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Have dispatch return a value

This is related to #26.
A return value has been added to the dispatch and all related middleware functions. These are necessary to be able to be able to await the result of an async process (as asked in this issue on how to redux_thunk).
dynamic return value has the following advantages:

does not break existing API (Minor version change seems to be enough)
middleware return values can be chained

Dart's type system is not complex enough (as opposed to TypeScript's) to be able to write union types when you want to chain together a middleware that may return an object of type A and another that may return an object of type B. So I don't see any other meaningful way to implement return values other than dynamic.
@johnpryan Hope this can be merged soon. Thanks.

Hey, thanks so much! We're working on version 4.x and would love to include this change. Great work!

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #52   +/-   ##
======================================
  Coverage    92.1%   92.1%
======================================
  Files           2       2
  Lines          38      38
======================================
  Hits           35      35
  Misses          3       3

Impacted Files
Coverage Δ

lib/src/utils.dart
100% <100%> (ø)
:arrow_up:

lib/src/store.dart
88% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2bbdac...01f5ad5. Read the comment docs.


Compare JuiceFS to S3FS/Goofys

S3FS/Goofys provides partial POSIX interface to S3. Even they are much different than JuiceFS, it's better to clarify that.

Fixed by #1772


Include annotations in the existing UK Average house price chart

We want to include annotations as horizontal lines for the COVID-19 lock-downs and specific custom shaped annotations to indicate house price, date and house to income ratio metric next to specific dates in the UK average house price chart

Actions required to close this issue:

Update existing data and chart to include November 2023 UK House price (latest data release by ONS)
In the ggplot2 line charts created for median uk house price and also for monthly and yearly price variation: Include in the plot the last value of each line as label.

Included 2023 Nov data


Add timeouts to all HTTP calls

This PR is related to user story DST-
Description
Add timeouts to all http calls:

10 sec towards Azure
120 sec towards 4insight

Checklist

[x] PR title is descriptive and fit for injection into release notes (see tips below)
[x] Correct label(s) are used

PR title tips:

Use imperative mood
Describe the motivation for change, issue that has been solved or what has been improved - not how
Examples:

Add functionality for Allan variance to sensor_4s.simulate
Upgrade to support Python 9.10
Remove MacOS from CI

I would suggest increasinging the backoff_factor, to allow the retry mechanism to increase timeout between calls.
I would also suggest testing it throughly, it is my experience that these mechanism seldom work excactly as intended if not tested properly.

There is a more granular version, too, that we could look at later, that separates connection times from total time, so we could have connect to be like 5 seconds or even shorter, and then allow for a longer read time. https://urllib3.readthedocs.io/en/stable/user-guide.html


v4.3.0

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #151   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines          73     73
  Branches       15     15
=====================================
  Hits           73     73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca5ce37...51b935f. Read the comment docs.


Infinite rerenders when using ref={(el) => observe(el)}

Bug Report
Describe the Bug
This hook continually rerenders components when using ref={(el) => observe(el)}. The problem does not exist when using ref={observe}.
I need to use ref={(el) => observe(el)} because I need to observe a specific element with both useInView and useDimensions, so in the end I'll have something like this:
ref={(el) => {
    observeInView(el);
    observeDimensions(el)
}}

I've started having this issue with react-cool-dimensions v2.x.x, and react-cool-inview v2.x.x. Previously, I simply shared the same ref between both hooks, and everything was much easier to handle.
How to Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Go to https://codesandbox.io/s/loving-wave-zlokm?file=/src/App.js
Click on Console on the browser preview
Observe "Rendering..." being printed continuously...

Expected Behavior
It should render only when ìnView` changes.
Your Environment

Device: Desktop PC
OS: Windows 10
Browser: Firefox v89
Version: v2.0.3

@rfgamaral Oops! Will fix it soon.


Bugfixes: v5.1 has missing unit test cases and error code coverage

Version where bug was found:
e.g "5.1.4"
Describe the bug
Spawned during testing #1425

We are missing unit test cases for Segment Controller, we need to add that.
We are also missing various non-happy paths error codes coverage, still we need to verify if all the swagger error codes are relevant or not. Below are the list of error codes missing in unit test cases as per swagger document: https://docs.google.com/spreadsheets/d/1hER9O-4fqguM_e8Ls7LzHCKevJKbGSM7GfTR0d0EvxI/edit?usp=sharing
We also need to add test cases for 400 errors due to validators.
The export experiment api unit test case is hitting post request for import api instead of get request for export.
Swagger details are missing for various new apis.
Analytics Controller tests has post request details for export csv data.

Expected behavior
All these admin endpoint tests should be properly covered.
Screenshots

@amurphy-cl This is an improvement in the unit test cases for the backend we should add this in the next release. This will take some time for implementation and testing.


encoding/binary: Read fails to detect a non-pointer 'data' argument

What version of Go are you using (go version)?

$ go version
go version go1.12.5 darwin/amd64

Does this issue reproduce with the latest release?
It does on play.golang.org
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/martin/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/martin/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/r2/nz7__kld2qq9w4dhg19fmx5h0000gn/T/go-build214042936=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I was trying to read a value with binary.Read. That function need a pointer for the Data parameter. I was using that function faulty by passing a non pointer value to it.

var value int32
err := binary.Read(input, binary.LittleEndian, value)

https://play.golang.org/p/ZFNQ4PjM9H-
What did you expect to see?
An error message saying that Data need to be a pointer
What did you see instead?
No error and and my value was zero. The method doesn't do anything at all.

CC @griesemer for encoding/binary

Looks like binary.Read should return an error when passed data interface is not a pointer or slice.
intDataSize handles the case when dst arg is a simple/primitive value but binary.Read not.

It is not clear to me that the CL chose the right approach. Given that the Read function panics when other conditions that must be satisfied are not satisfied, it seems ok to panic in this case as well.
Marked as NeedsDecision.

My point is that in the case when a pointer to a struct is passed and struct itself is incorrect then the reflect-related code may (or may not) panic.
It seems to me that documentation on Read is a little bit unclear.

I think we should do the same thing we do in the fallback case, which is
	if size < 0 {
		return errors.New("binary.Read: invalid type " + reflect.TypeOf(data).String())
	}

Shouldn't the behaviour be equal to other packages? Both encoding/json and encoding/xml is returning error.
https://play.golang.org/p/o9hl4rmIUDA

encoding/json and encoding/xml with int32 instead of struct{} : https://play.golang.org/p/KKE6ssLsBmy

Hello @griesemer, I am just prodding you about this issue. From the precedent, it seems to be that returning an error is alright. This issue is marked for Go1.14 and there is already a CL that's just waiting for your blessing https://go-review.googlesource.com/c/go/+/184957/, please take a look and thank you.

@odeke-em Thanks. On it.


some questions about interface design

Hi author! I know fluentjdbc from CodeProject.com. Thanks for you sharing.
I implement it again following your code and then I have some questions about the design.
why  need interface Setter , Comsumer and function apply?
I think there are two reasons:
1.Simplify exceptions handling，which we handle them in function apply.
2set(Setter) provides programer a way to set some types not included in function set and
PreparedStatement must be used like ps.setXXX(index, xxx) .
3.Comsumer and apply also provide programer a way to configue preparedStatement
am i right?

Custom interfeces are required, because standard java.util.function functional interfaces do not throw checked exceptions.
2. You're correct
3. You're correct

thanks for your ans!


Change high resolution image with preview

Details

We have observed significant lag when displaying and interacting with high-resolution images in the modal. This PR aims to modify the behavior when handling high-resolution images.
Fixed Issues

$ https://github.com/Expensify/App/issues/38180
PROPOSAL: https://github.com/Expensify/App/issues/38180#issuecomment-2126395141
Tests

Standard resolution image

Go to any report chat
Select + Icon and select Add Attachment
Upload this image (4000x4000.png)
Verify original image displayed and zoomable
Select Send button
Select successfully uploaded image
Verify original image displayed and zoomable
If there are multiple attachments, verify it can be navigated through arrow buttons and swipe/drag action

[x] Verify that no errors appear in the JS console

High resolution image

Go to any report chat
Select + Icon and select Add Attachment
Upload this image (10000px)
Verify that image name shown with left image icon
Verify that there is info text at the bottom of the image with text: This image is too large to preview before uploading.
Select Send button
Select successfully uploaded image
Verify thumbnail image displayed (1024px version) and zoomable
Verify that there is info text at the bottom of the image with text: This image has been resized for previewing. Download for full resolution.
If there are multiple attachments, ensure they can be navigated using arrow buttons and swipe/drag actions, with the information text appearing or hiding based on the image resolution threshold (5000px)

[x] Verify that no errors appear in the JS console

Offline tests

Standard resolution image

Turn off the network
Go to any report chat
Select + Icon and select Add Attachment
Upload this image (4000x4000.png)
Verify original image displayed and zoomable
Select Send button
The Uploading attachment.. text will appear
Turn on the network
Select successfully uploaded image
Verify original image displayed and zoomable
If there are multiple attachments, verify it can be navigated through arrow buttons and swipe/drag action

[x] Verify that no errors appear in the JS console

High resolution image

Turn off the network
Go to any report chat
Select + Icon and select Add Attachment
Upload this image (10000px)
Verify that only image name shown with left image icon
Select Send button
The Uploading attachment.. text will appear
Turn on the network
Select successfully uploaded image
Verify thumbnail image displayed (1024px version) and zoomable
Verify that there is info text at the bottom of the image with text: This image has been resized for previewing. Download for full resolution.
If there are multiple attachments, ensure they can be navigated using arrow buttons and swipe/drag actions, with the information text appearing or hiding based on the image resolution threshold (5000px)

[x] Verify that no errors appear in the JS console

QA Steps

Same as Test

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1719953316322399

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/11847279/577ba18f-0a75-485e-aa4a-4f76bc837a85

Android: mWeb Chrome
https://github.com/Expensify/App/assets/11847279/d58c7752-c6de-47c0-a859-b122c1e24732

iOS: Native
https://github.com/Expensify/App/assets/11847279/741b34e0-dfdc-4b36-9ac5-c7f3f7632c92

iOS: mWeb Safari
https://github.com/Expensify/App/assets/11847279/6cc1bb7e-708a-4631-b6b3-04763e7b7230

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/11847279/22fa5372-7671-4dec-8761-db3a92d4b6da

MacOS: Desktop

https://github.com/Expensify/App/assets/11847279/919c3256-95e8-4441-8843-fcbaea81d0e7

@Expensify/design

I'm wondering if on this screen we should put some kind of message letting users know that the file is too big to preview before upload. @Expensify/design what do you think about something like that?
If you watch the video it feels weird that you get a preview for the 4000x4000 image and then don't for this one (with no explanation).

That makes sense to me, perhaps we could use a similar style for the message as we're using once you view it post-upload?

Nice, I think that looks great!

Nice improvement. #context!

@sobitneupane updated code with refactoring and added info text for non-uploaded high-resolution images (ref)

Arrow moves up for the attachment with size info.

That's because it's not part of carousel content; moving the carousel container along with the arrow icon. This issue can be avoided if HighResInfo is included in the content, but there is a drawback: the text will move each time we swipe/navigate.
https://github.com/Expensify/App/assets/11847279/061cd5a6-c725-4698-bffd-612563ea6e8a
@sobitneupane @Julesssss @dannymcclain Should we include the text in the carousel item content? If it is part of the item content, we do not need to consider the scrolling state here.

This issue can be avoided if HighResInfo is included in the content, but there is a drawback: the text will move each time we swipe/navigate.

@wildan-m just to clarify, the problem you are highlighting is that the 'This image has been resized...' text is locked to the image, and does not remain in place? Unless I misunderstand, this looks great to me in the video and I would expect this to happen, rather than have the text remain static and dissapear/reappear depending on the content.
@dannymcclain it would be good to get your thoughts here though.

just to clarify, the problem you are highlighting is that the 'This image has been resized...' text is locked to the image, and does not remain in place?

@Julesssss that is correct, I would also prefer that method as it will not cause any delays in displaying/hiding the text, especially for native.

Unless I misunderstand, this looks great to me in the video and I would expect this to happen, rather than have the text remain static and dissapear/reappear depending on the content.

Totally agree—I feel like this is how I would expect it to work!

@sobitneupane The PR updated.

Move the HighResInfo into attachmentview
Remove changes related to attachment carousel listener (ref)
Resolve issue arrow moves (ref)

@wildan-m The app crashes when I try to open an attachment. There are few console errors as well. Can you please test it in your end?

@sobitneupane I have tested them, have you made sure to set USE_REACT_STRICT_MODE to false?
It's in src/CONFIG.ts
Some people have also experienced the same thing:
https://expensify.slack.com/archives/C01GTK53T8Q/p1719513440587919

Maybe I've missed something, but do we really need this warning?

Maybe I've missed something, but do we really need this warning?

I agree that we should add the warning Danny suggested above here, but I don't think the user cares that we're downscaling their preview. Feels a bit too technical for the average user.
Keen to hear if @Expensify/design agrees.

@wildan-m App is quite slow on IOS and it keeps crashing on Android. It might not be related to the PR. But Can you please retest it in your end?
Also, lets add some padding in the warning message (especially on Android/native and IOS/native)

@wildan-m App is quite slow on IOS and it keeps crashing on Android. It might not be related to the PR.

Hmm @dubielzyk-expensify I do think you make a totally fair point... I don't feel too strongly one way or the other.

I don't think the user cares that we're downscaling their preview. Feels a bit too technical for the average user.

I think the reason we decided to include this is because the zooming/panning is going to look much much worse on the resized image vs. the high res image the user uploaded. But if you feel like really no one will care we can ditch it. Alternatively we could change it to just say This image has been resized. Download for full resolution.

I think the reason we decided to include this is because the zooming/panning is going to look much much worse on the resized image vs. the high res image the user uploaded. But if you feel like really no one will care we can ditch it. Alternatively we could change it to just say This image has been resized. Download for full resolution.

It's not like we're showing the a 300x300 image though? Isn't just the preview more manageable but still reasonably decent?
I guess I kinda just expect all internet services to process image or resize them. Feels like it'd be weird if Instagram or Slack said something similar which is why I'm calling it out. I guess this warning only shows for very high resolution so maybe it's fine and more transparent.
I trust you know this better than me. Just wanted to add my perspective 😄

@dubielzyk-expensify Consider this case where there are significant differences between width and height. Since the preview image version should maintain its aspect ratio, the compressed image might not be readable even when zoomed in. Without text describing that a higher resolution is available for download, the user might assume that the downloaded version will also be blurry.
https://github.com/Expensify/App/assets/11847279/756ae0c1-3e7c-4fa3-b7d5-89b4cdcdd808

Very fair point! Hadn't considered that.
Sorry if I missed this earlier, what's the threshold for when we show this preview warning then? Is it based on the width/height of the image? If so what's the threadshold?

@dubielzyk-expensify currently 7000 pixels in either width or height. (ref)

@sobitneupane The PR has been updated.

Update video test
Adjust padding for native
Merge main

I guess I kinda just expect all internet services to process image or resize them. Feels like it'd be weird if Instagram or Slack said something similar which is why I'm calling it out.

Totally see what you mean, but I think what we have here still makes sense. Slack for example just doesn't show you a preview AT ALL for really big images.

If you want to see the image, you have to download it. We're kinda taking a different approach where we still want you to be able to see something, but I think it's important to let you know that it is not the actual/proper image file, so it's going to be degraded a bit.

I trust you know this better than me. Just wanted to add my perspective 😄

LOL I'm not sure I'd go as far as to say I know better 😂 but I do appreciate you sharing your perspective! Again, I think this treatment still makes sense because it takes a massively large image to even cause this behavior. So I'd imagine most people will never even see this at all.

Makes sense. Thanks for going on the journey. Having seen this example I see the value in the UI given so many of our attachments are likely to be long or PDF like.

Screenshots feel pretty good to me, let's see what the rest of the @Expensify/design team thinks too.

Looking good to me!

Thanks all for your help!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.7-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


npm dependencies shared with smk given absolute versions

Related PR in smk: https://github.com/bcgov/smk/pull/169


PXP-599: [CLI] Logs panel: Support time filtering (Reopen to base on the main branch)

Summary

The hotkey on the ticket is Ctrl+s, but it is conflicted with the search input which is using the same hotkey, so for now I use the Ctrl+r for the time filter (it is temporary, we should change the hotkey).

Ticket: PXP-599
What's Changed

Added

[x] Add time filter support

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jk-gan
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jk-gan It seems the hotkey is not working. I pressed it and it does nothing. Also, don't see the hotkey in the header pane.

@jk-gan It seems the hotkey is not working. I pressed it and it does nothing. Also, don't see the hotkey in the header pane.

Ok, I saw the bug here, I mistakenly added the hotkey on the empty state (which mean non of the panels is being selected), but it should be enabled when the log panel is selected.

fixed

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jk-gan, onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


⚠ Bofrost.at has degraded performance

In 45ba3ed, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1984 ms

Resolved: Bofrost.at performance has improved in 59a459d.


How use it with Mapbox ?

Hello,
I am using mapbox and will use it to show some map from Fisbroker into my map. I can ee my map on mapproxy interface:

This map works :
	map.addSource('wms-test-source', {
				type: 'raster',
				tiles: ['https://tiles.codefor.de/berlin-2022-dop20rgbi/{z}/{x}/{y}.png'],
				tileSize: 256
			});

But not works locally with tile: // tiles: ['http://<IP_ADDRESS>:8080/tms/bnp_0/webmercator/{z}/{x}/{y}.png'], or another local.

And I have this issues on all layer if try it locally.
Someone can help ?

Hey @CarlosZiegler unfortunately I don't know enough bout how this system works to help. I hope you found a solution. I will close this here since it is not directly related to the repo.


Add course purchasing system

Please add a feature to purchase course by students using amazon pay or Paypal gateway

Hello, there are not plans to add payments in the future.


Can't implement OnProgressBarListener

Excuse Me
I have a issue
I can't implement OnProgressBarListener after import your library from  gradle,Can tell me how to implement for fix the issue please
sorry my english is bad
<EMAIL_ADDRESS>

Same problem, OnProgressBarListener not imported from Gradle!

Try with https://github.com/Dona278/NumberProgressBar

Fixed in version 1.3. (Because old version wasn't include the latest code.)


Sulu urls language behaviour

I'm questioning the current handling of the returned content urls.
Default Webspace setup sulu.lo/{localization}
Sulu currently return all urls without the location. So I want to use smart_content need to call sulu_content_path I want to use Internal links need to call sulu_content_path want to get my current url or just the other language urls need to call sulu_content_path.
So the data of the view are just incomplete. And the url prefixes are needed.
I know that symfony it self handles it also so that you need to call path but there the advantage is that all urls in all language are the same which is in sulu to 99% not that english or e.g german have the same urls so you cant just call `path('...', {_locale: 'de'}).
In my opinion sulu should return the correct urls to the view.
For the sitemap it could be handled over extension for the domain prefix but the sitemap is not a daily business thing and also will not be changed in any project.

That's basically the same issue as https://github.com/sulu-io/sulu-standard/issues/365, I am closing the other one, since this one describes the problem in more detail.

Closed in favor of sulu/sulu#3133


Credential registry and schema management API requests

Task List:

[ ] credential registry requests
[ ] schema management requests

Depends on https://github.com/WebOfTrust/keria/issues/20


gpvtg message parsing should record if altitude is empty or 0.

currently if amplitude wasn't provided by GPS field is empty and parsed value is 0.
we have a logic which changes frequency of APRS messages based on altitude. It should take into account if altitude was actually present and parsed successfully and ignore empty altitude.
(parsing code returns flag if empty value was detected, so we can keep it for future use).

This mitigation is already present, the message rate is only increased if the altitude is positive. See main.c:192.


Fix on 0.6

This gets CPLEX passing its own tests on 0.5 and 0.6. It also passes all of JuMP's tests except for a nice segfault at the end...

Hopefully the segfault is only on v0.6...?

Yep
On Dec 21, 2016 21:36, "Joey Huchette"<EMAIL_ADDRESS>wrote:
Hopefully the segfault is only on v0.6...?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JuliaOpt/CPLEX.jl/pull/101#issuecomment-268703335, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABp0MyXDF9pSo7H_oC252XdAS9N_e3Rpks5rKeIfgaJpZM4LTXWb
.


Create damage roll messages with multiple rolls in.

This would probably be pointless until the system allows applying damage per roll rather than per message.

To pull from Minimal Rolling Enhancements description, does this issue seek to replicate this functionality?

To pull from Minimal Rolling Enhancements description, does this issue seek to replicate this functionality?

Yes.

Ideally this would not need to be part of a module at all, but all damage rolls would split into multiple rolls by default in the system, using the system.damage.parts array -- each element of the array being one roll.

This will be added to the system, albeit slowly, so is best left out of a module.


IPD and other user profile data

related to/depends on #146
IPD long ago lived in display descriptor, but that was clearly wrong: it's user data independent of display device. It now apparently lives nowhere, which is an unfortunate oversight that was unnoticed for so long because of the ad-hoc way integrations were parsing display descriptor data and producing their projection matrices. This is the minimum parameter we need, but others that some have used, and their rationale:

Height (presumably standing) - for tracker calibration?

Perhaps seated height as well? SteamVR looks to have a seated vs. standing distinction that I haven't fully teased out.

Sex (oculus actually asks for gender, but they may not know the distinction) - presumably for a better default height and IPD? Should be optional in any case.

Some have also brought up a custom neck model (would that be measurements from yourself?) and other devices might want other information

We may want a default center of projection in the display descriptor so we know what the optics were designed for.


I had Quora blocked from search results but now..

Apparently different things like
Example.quora.com
Have to be blocked separately and it's not being broadly blocked by having quora.com on my blacklist. I don't want to have a blacklist full of quora variants. Is there a way to correct this?

Is *://*.quora.com/* what you want ?

That's the first thing I tried, but for some reason it keeps showing those quora variants as a separate blockable site. I don't know what else to try.

I have the same issue with *://*.quora.com/* and Google. The site's content shows up under www.quora.com urls, so subdomains is not part of it. On Duckduckgo there is no such problem.


Active tab after postback

Is there any good method to use form control inside the tab with postback
for example
I use 4 tabs and placed a form elements inside them
my issue is how to remain the active tab selected after doing postbak.
I use diffrenet solution in stackoverflow community but I did not success
here is an example
check here

Hello @EngBadr , still facing this issue ?

We will close this for now but you can reopen it anytime if you need to.


fix: memory leak

closes #7189
The version bump to bookshelf 0.10.0 and knex 0.11.10 in Ghost 0.9.0 has caused a memory leak. This PR fixes the memory leak. We also need to downgrade lodash, because of this issue #7158.
We will investigate further what is causing the problem, but with this PR everything should be back to normal memory usage.

thanks a lot! can we merge this and fix asap?

@gergelyke sure 👍

@gergelyke would it be possible for you to deploy this fix and confirm it resolves the issue for you?

Thanks so much for digging into the memory leak issue!

@ErisDS sure thing! going to do it right now


[Fork help/No waterfall issue] Need help with resolve conflict with patches.

Hello! Может кто-то помочь разрешить конфликт с патчем?
error log:
fatal:
sha1 information is lacking or useless (proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java).
error: could not build fake ancestor
Patch failed at 0043 russian
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
  Something did not apply cleanly to Waterfall-Proxy.
  Please review above details and finish the apply then
  save the changes with rebuildPatches.sh

my fork: https://github.com/Dimatert9/Waterfall
Thanks.

You'll need to resolve the merge conflict.

But how?? I dont know how.

Looks like https://git-scm.com/book/en/v2/Git-Branching-Basic-Branching-and-Merging should explain

https://i.gyazo.com/7e48bae8b17abaee4fc899b10cbe5e6e.png

I think that the error in line 1 and 8
, but i dont know how fix this.

If you do some research on merge conflicts you should be able to get this resolved ;)

My english is bad. I really dont know how fix conflicts in patches.

I found a Russian tutorial - https://githowto.com/ru/resolving_conflicts

I dont have source, i have only patch, and i dont can apply this patch because i get error:
sha1 information is lacking or useless (proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java).
error: could not build fake ancestor

I'm not completely sure as to what you mean but assuming I do: the source is under Waterfall-Proxy this is where you will have to fix the conflicts.
Alternatively if you really can't resolve the merge conflict you could rewrite the commit.

in WaterFall-Proxy i dont have "<<<<<<< HEAD"
Alternatively if you really can't resolve the merge conflict you could rewrite the commit.
how i can do this?


Add CONTRIBUTING.md file

Add a CONTRIBUTING.md file

it is already here: https://github.com/osl-incubator/makim/blob/main/docs/contributing.md


PeerId param type mismatch between spec and implementation

Version: 0.28.2
Platform: Darwin Kernel Version 17.7.0: Wed May 27 17:00:02 PDT 2020; root:xnu-45<IP_ADDRESS>~1/RELEASE_X86_64 x86_64,
nodejs v12.13.0
Subsystem: libp2p/peerId

Type: Bug
Severity: Low
Description:
The ts type declaration for the id param of PeerId disagrees with the implementation.
Steps to reproduce the error:
peer-id/src/index.d.ts has this  (claims to accept Buffer or string for id):
declare class PeerId {
  constructor(id: Buffer | string, privKey?: PrivateKey, pubKey?: PublicKey);

but the actual implementation does this:
class PeerId {
  constructor (id, privKey, pubKey) {
    if (!Buffer.isBuffer(id)) {
      throw new Error('invalid id provided')
    }

It throws when given a string id param
So, which is it?  Remove string from the declaration, or change the class to convert string to buffer?

Thanks for raising this.
The correct is only accepting a Buffer, as detailed in libp2p/js-peer-id#new-peeridid-privkey-pubkey.
Would you like to open a PR in peer-id to fix the typescript declaration file?
It is important pointing out that our work to better support typescript users is still in its beginning. We will move away from the declaration files, and leverage JS docs to achieve them in a cleaner way while also guarantee that they are updated with the code. More Info

@jacobheun can you transfer this issue to the peer-id repo. I don't have permissions for it


TaskDriver - Improve Safety of JobData Query Operations

In a job configured and run through IJobConfig/AbstractJobData (usually a job in a TaskDriver) it's currently on the developer to remember to add [ReadOnly] attributes to any NativeArray's they are populating from a query when they don't plan to write to the elements. For example via AbstractJobData.GetIComponentDataNativeArrayFromQuery and AbstractJobData.GetEntityNativeArrayFromQuery.
Unity uses the prsence of a [ReadOnly] attribute on the field to determine if the component is read only even if the query only specified read only access (Ex: ComponentType.ReadOnly<MyComponent>)
If a developer forgets the attribute  NativeArray<T>.FailOutOfRangeErrror will eventually trigger when two jobs go to get read access to the component at the same time.
Ideally, the developer shouldn't have to remember to add the atribute. If they do have to remember then our safety system should let them know if the discrepency as soon as possible. Waiting until a race condition actually comes up at runtime is too late.
Some possible approaches:

Wrap array access in a type reader. We're not sure whether putting the [ReadOnly] attribute on the field inside the wrapper will correctly inform Unity's safety system but this is ideal.
On each Get*FromQuery<> request check the destination field's attributes and ensure they align with the access type requested in the query.

Wrap array access in a type reader. We're not sure whether putting the [ReadOnly] attribute on the field inside the wrapper will correctly inform Unity's safety system but this is ideal.

I think this does work correctly. We're using it on our CDFEReader and other "Reader" wrappers today. I've definitely gotten errors before where I didn't specify the access on an inner field in the wrapper and then tried to use it in a context where it needed to be marked as ReadOnly.


Linter Rule: Admin user names can't be literal value

There should be a linter rule to meet parity with arm-ttk test https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-test-cases#admin-user-names-cant-be-literal-value

From TTK:

Test name: adminUsername Should Not Be A Literal
When setting an adminUserName, don't use a literal value. Create a parameter for the user name and use an expression to reference the parameter's value.
The following example fails with a literal value.
JSON
"osProfile":  {
"adminUserName": "myAdmin"
}
The following example passes with an expression.
JSON
"osProfile": {
"adminUsername": "[parameters('adminUsername')]"
}

sw/adminusername-rule


Support channel groups in convolutional layers

This PR implements the channel groups in convolutional layers (Conv1D, Conv2D, Conv3D, Conv2DTransposed).
The grouped convolution was firstly implemented in AlexNet as a way to share filter parameters across feature maps. A detailed discussion on this feature can be found on here. This feature is supported by Caffe (doc) and used in its reference caffenet. Adding this feature to TensorFlow makes it easier to compare models on two different frameworks and migrate from Caffe to TensorFlow.

Can one of the admins verify this patch?

Francois, mind commenting whether this would be useful to add?

I don't think it's currently widely used enough to justify becoming part of the core layers. The proposed implementation would also not be useful in any practical setting, because it relies on manually splitting tensors, running independent convolutions ops, and concatenating the outputs. This will be very slow and inefficient.
When we want to add support for convolution groups, it should happen at the op level, not be manually implemented as a graph of ops on the Python side. In theory, a convolution with groups (e.g. 8 groups in a 128-big channel space) should be significantly faster than a regular convolution, but with this setup it would be dramatically slower. Since the added speed / efficiency is the core reason for using them, that is clearly a big issue.

Thanks for the pull request! If you'd like to add support for this feature in the meanwhile, consider adding it to contrib, or reopening the feature request and discussing it there.

The lack of group convolution prevents migrating many pre-trained models from Caffe to TensorFlow. For example, 3 out of 5 example Caffe models use this feature. The users have to manually split the Caffe kernel to multiple TensorFlow conv layers, which is especially laborious and error-prone for large networks.
In terms of performance, if the group number is set to 1 (as default), there is no performance difference from the current version. It would be ideal to implement this feature in the op. Supporting
this feature on the API can be a first step. It allows users to migrate to TensorFlow. Then we can profile and optimize.

@bowang
I think its much slower when group is large when using your codes.
For example, group=32 is used in pvanet
group convolution is more than 2 times slower than normal convolution
(total_ops is 128% and total_params is 34% for group=32 & group=1 in my case)
Is there any way for optimization?

@sleepfin do you mean a 32-group convolution is 2x slower than 32 normal convolutions?

Again, if we add it, it should be done at the op level and should be fast.
If we add a feature as part of the core API then users should have a reasonable expectation that the feature does what it claims to do. People's motivation for using convolution groups is that they should result in cheaper, faster convolutions. If we provide this option but the result is actually slower convolutions, we are not answering user expectations.

@bowang
But in a real case, we usually replace "one single-group 128-channel convolution" with "32-group 4-channel convolution" like PVANET, which means the param:group =1 or 32.
And notice that on CPU divece,  "32-group 4-channel convolution" is faster than "one single-group 128-channel convolution" but the opposite on GPU device

@bowang
Another question:
BN & Activation & Bias_add layer are applied to:
1 -> The output of a single path of conv groups ?
2 -> The output of final concat layer ?
In your codes, I think it will be the first case if I use with arg_scope
I'm not sure if its correct and more efficent to apply those layers to the final concat output.

@sleepfin Thanks for the performance measurement! My hypothesis on the GPU/CPU performance difference is caused by the change of per-op and total computation workload in group convolution.
As in the current implementation that a single large convolution is decomposed into a number of small convolutions, the workload for a single small convolution may not be able to fully utilize a GPU to its limit. Thus, the GPU utilization decrease may lead to the slowdown.
Meanwhile, when comparing the total amount of workload, that of the group convolution is smaller than that of a single convolution. Since CPU has much lower computation power, it is always saturated. Thus, the speedup on CPU was due to the reduction of total workload.
This is just my hypothesis. Hope it may generate some ideas for further performance debugging.

@sleepfin Bias and activation are applied on the concatenated results of conv groups as you may find on line 194 (concat), line 218 (bias add), and line 221 (activation). BN is implemented as a separate layer which I think is out of the scope of conv layers.

A recent paper highlights the possible usefulness of group convolutions for mobile uses: https://arxiv.org/abs/1707.01083
Looking forward to see a possibility of group convolution implemented in TF.

Again, if we add it, it should be done at the op level and should be fast.
@fchollet Do you have a typical pathway to recommend for people interested in efficiently implementing a layer in TF (i.e. where in specific in the op level should one implement)?

@fchollet  #25818 Added support for Conv2D Group Convolutions using CUDNN on GPUs. Would you be open to revisit this addition for Keras?

@lgeiger @fchollet It would be great to have group convolutions and their transposed version in Keras. There are at least depth-wise convolutions, but no DepthwiseConv2DTranspose to build image decoders.


IpVersionsCientType/TcpGrpcAccessLogIntegrationTest.BasicAccessLogFlow/1 flaked on coverage

https://circleci.com/gh/envoyproxy/envoy/296599?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification
[----------] 1 test from IpVersionsCientType/TcpGrpcAccessLogIntegrationTest
[ RUN      ] IpVersionsCientType/TcpGrpcAccessLogIntegrationTest.BasicAccessLogFlow/1
test/extensions/access_loggers/grpc/tcp_grpc_access_log_integration_test.cc:146: Failure
Value of: fake_upstream_connection->waitForHalfClose()
Actual: false (Expected half close event, but got a different event.)
Expected: true
Stack trace:
0x4ccd5c3: __llvm_coverage_mapping
0xa789ff6: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
0xa7777f4: testing::internal::HandleExceptionsInMethodIfSupported<>()
0xa75efd2: testing::Test::Run()
0xa75fcfe: testing::TestInfo::Run()
... Google Test internal frames ...
[  FAILED  ] IpVersionsCientType/TcpGrpcAccessLogIntegrationTest.BasicAccessLogFlow/1, where GetParam() = (4-byte object <00-00 00-00>, 4-byte object <01-00 00-00>) (830 ms)
[----------] 1 test from IpVersionsCientType/TcpGrpcAccessLogIntegrationTest (830 ms total)

Lizan can you take a look to see if you can repro using the deflake instructions?


Add orphan user message for user without organizations

📖 Description and motivation
If, for some reason, a user is able to log in but has no organization memberships, we would show them an internal error message.
Now we show a custom message for this situation.
👷 Work done
Tasks

[x] Prevent internal error on orphan user login
[x] Show custom message

🎉 Result

🦀 Dispatch
#dispatch/rails

🦀 Requesting reviewers for this pull request:

@Boubalou (reviewer for the rails stack)


Set value programmatically

Hello,
first of all thanks for your work. I have a simple question, in one of my forms I'm using your filestyle plugin and trying to set it's input field value when the user clicks edit button. I mean here's the flow:

User enters some fields including one or more file inputs then saves them.
User wants to see what he/she chose and clicks edit button.
Now I want to set file input field's value with the existing choice of user (which I've saved already)

How to set file input value programmatically ?

The file input field is only used for selecting files, this means that the field does not receive values unless your own operation.
If you have questions still send the link to an example in jsfiddle.net

I've resolved this by changing dialog without input option. And put an input myself. (Setting file name value by myself to input = text field)
Thanks


Describe the issue

Problem:
Using s2n-quic as a dependency in a project/crate on macOS doesn't build successfully by default. Unclear what's needed to get it to build with the default s2n-tls provider. Building s2n-quic on it's own from a clone builds fine though.
error: failed to run custom build command for `s2n-tls-sys v0.0.8`

Caused by:
  process didn't exit successfully: `/Users/jerome/AstroProjects/Experiments/cryptotest/target/debug/build/s2n-tls-sys-a3e92bdd97e4c1c6/build-script-build` (exit status: 101)
  --- stdout
  CMAKE_TOOLCHAIN_FILE_aarch64-apple-darwin = None
  CMAKE_TOOLCHAIN_FILE_aarch64_apple_darwin = None
  HOST_CMAKE_TOOLCHAIN_FILE = None
  CMAKE_TOOLCHAIN_FILE = None
  CMAKE_GENERATOR_aarch64-apple-darwin = None
  CMAKE_GENERATOR_aarch64_apple_darwin = None
  HOST_CMAKE_GENERATOR = None
  CMAKE_GENERATOR = None
  CMAKE_PREFIX_PATH_aarch64-apple-darwin = None
  CMAKE_PREFIX_PATH_aarch64_apple_darwin = None
  HOST_CMAKE_PREFIX_PATH = None
  CMAKE_PREFIX_PATH = None
  CMAKE_aarch64-apple-darwin = None
  CMAKE_aarch64_apple_darwin = None
  HOST_CMAKE = None
  CMAKE = None
  running: "cmake" "/Users/jerome/.cargo/registry/src/github.com-1ecc6299db9ec823/s2n-tls-sys-0.0.8/lib" "-DCMAKE_INSTALL_PREFIX=/Users/jerome/AstroProjects/Experiments/cryptotest/target/debug/build/s2n-tls-sys-bd9766d5bca2f190/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -arch arm64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -arch arm64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -arch arm64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Debug" "-DBUILD_TESTING=off"
  -- Detected CMAKE_SYSTEM_PROCESSOR as arm64
  -- Detected 64-Bit system
  -- madvise() support detected
  -- minherit() support detected
  -- Configuring incomplete, errors occurred!
  See also "/Users/jerome/AstroProjects/Experiments/cryptotest/target/debug/build/s2n-tls-sys-bd9766d5bca2f190/out/build/CMakeFiles/CMakeOutput.log".
  See also "/Users/jerome/AstroProjects/Experiments/cryptotest/target/debug/build/s2n-tls-sys-bd9766d5bca2f190/out/build/CMakeFiles/CMakeError.log".

  --- stderr
  cargo:rerun-if-env-changed=S2N_TLS_DIR
  cargo:rerun-if-env-changed=S2N_TLS_LIB_DIR
  cargo:rerun-if-env-changed=S2N_TLS_INCLUDE_DIR
  cargo:rerun-if-env-changed=CARGO_FEATURE_CMAKE
  cargo:rerun-if-env-changed=CARGO_FEATURE_PQ
  CMake Error at /opt/homebrew/Cellar/cmake/3.22.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find crypto (missing: crypto_LIBRARY crypto_INCLUDE_DIR)
  Call Stack (most recent call first):
    /opt/homebrew/Cellar/cmake/3.22.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
    cmake/modules/Findcrypto.cmake:67 (find_package_handle_standard_args)
    CMakeLists.txt:499 (find_package)

  thread 'main' panicked at '
  command did not execute successfully, got: exit status: 1

  build script failed, must exit now', /Users/jerome/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.48/src/lib.rs:975:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

Solution:
Ideally it should build without issue, or if it requires openssl for example to be installed via homebrew, docs/readme could mention that. Though installing it I haven't had luck for it finding it yet.
Requirements / Acceptance Criteria:

Out of scope:

Maybe these links can help you.
https://stackoverflow.com/questions/29651258/install-openssl-devel-on-mac
https://stackoverflow.com/questions/16248775/cmake-not-able-to-find-openssl-library/69268455#69268455

Hi Jeremy,
Could you provide the Cargo.toml you are using in your project?

Are you wanting to use s2n-tls or rustls? If you're using rustls then it shouldn't be building s2n-tls at all. Is that identity-manager crate also depending on s2n-quic?
(as a side-note, you really only need features = ["provider-tls-rustls", "provider-address-token-default"], rather than listing all of those packages)
If you are trying to use s2n-tls, CMake should really only be used when the post-quantum feature is enabled, so I'm not sure why it's being used here... Is there something else in your tree enabling that feature (inside of identity-manager, perhaps?) If I build your cargo.toml on my x86 macbook, it successfully builds and doesn't use CMake.
In any case, we depend on the openssl-sys crate to resolve the openssl package: https://github.com/aws/s2n-tls/blob/aa8f7fbb5e8afb649230f70917dd6bbe31702019/bindings/rust/s2n-tls-sys/build.rs#L154. So if that's giving us an invalid or unexpected location for the artifact we may not properly link to it.

so gave a try on my intel mac just to be sure there isn't something weird with aarch64, but seems to be same. I have openssl installed via homebrew on both, tried clean & re-building with default features for s2n-quic and it still can't find openssl. I also tried setting these as homebrew mentioned after installing openssl:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
also identity-manager doesn't include quic/s2n/etc at all, it only uses rustls and some other crates to deal with certificates only.

I am running into this issue on Linux when using cargo workspace.
Could NOT find crypto (missing: crypto_LIBRARY)

I added two cargo projects with cargo new, so the basic hello world. It didn't matter if I tried to use rustls, it's still trying to configure s2n-tls. In either case, the configuration step fails with the error above. I only had one dependency in all tests.
#s2n-quic = "1"
s2n-quic = { version = "1", features = ["provider-tls-rustls"] }

Without a cargo workspace project, the same kind of hello world app builds and runs as expected.

I just tested this on a current MBP:
On a fresh project with only a s2n-quic dependency,  attempting to build with provider-tls-rustls  results in the project still attempting to compile s2n-tls.
When I set default-features=false it doesn't, but then s2n-quic fails to compile because of missing dependencies:
cuckoofilter, hash_hasher, zerocopy, zeroize,
I was able to get things compiling with s2n-tls using
brew upgrade openssl
brew link --force openssl
pkg-config --modversion openssl

export LDFLAGS="-L/opt/homebrew/opt/openssl@3/lib"
export CPPFLAGS="-I/opt/homebrew/opt/openssl@3/include"

You need to also enable the default address token provider as well, as shown in the rustls example.
https://github.com/aws/s2n-quic/blob/9e5372e2655ae00490a7bbc1e97a5dd19114a232/examples/rustls-provider/Cargo.toml#L9
We do need to improve the error message there.


Update the Readme file to improve visualization

Update the Readme file to improve visualization.

@Vanethos we should keep the keys.dart file with placeholder (non working) keys and the user would just replace it on their local project. This will also allow the builds to build properly on the CI. I'll commit those changes and suggest @BrayanMamani to update the README accordingly.


Use EventContext for enrichment

Allow context reference in by field option.

[Current coverage][cc-pull] is 75.20%

Merging [#159][cc-pull] into [master][cc-base-branch] will increase coverage by 0.12%

@@             master       #159   diff @@
==========================================
  Files           128        128
  Lines          4523       4542    +19
  Methods           0          0
  Messages          0          0
  Branches        493        497     +4
==========================================
+ Hits           3396       3416    +20
  Misses         1022       1022
+ Partials        105        104     -1

Powered by Codecov. Last updated by [1fdca10...1d00060][cc-compare]
[cc-base-branch]: https://codecov.io/gh/SpineEventEngine/core-java/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/SpineEventEngine/core-java/compare/1fdca10d7be369138742954c32b0845082304c40...1d000609cd5267a7b49ebee1d8489ea631ccb0c1
[cc-pull]: https://codecov.io/gh/SpineEventEngine/core-java/pull/159?src=pr

Other than that, LGTM.


Add the ability to export diagram to xml

Description
Please add an endpoint to retrieve graph data as xml
Additional Context
No response

@hamletbarsamyan
I added a method to the FlowComponent called getFlowState. You can read more on FFlowComponent Documentation.

Thank you very much
On Sun, 15 Sept 2024 at 19:16, Siarhei Huzarevich @.***>
wrote:

@hamletbarsamyan https://github.com/hamletbarsamyan
I added a method to the FlowComponent called getFlowState. You can read
more on FFlowComponent Documentation
https://flow.foblex.com/docs/f-flow-component.
—
Reply to this email directly, view it on GitHub
https://github.com/Foblex/f-flow/issues/46#issuecomment-2351634137, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYHIBDSMYDWX543YSOCZFTZWWQE5AVCNFSM6AAAAABOE5AEL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGYZTIMJTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


routerlink delay in md-nav-list (wraped anchor element in )

Bug, feature request, or proposal:
I created a md-nav-list based on the angular material docs for a more complex navigation list and added a routerlink to the anchor tag.
https://material.angular.io/components/component/list

For more complex navigation lists (e.g. with more than one target per item), wrap the anchor element in an .

What is the expected behavior?
The routerlink should be resolved immediately when hover over or click the element.
What is the current behavior?
When you hover over the element or click on it, it is not getting resolved. Only after a short period of time (2 seconds or so) or after clicking multiple times on the element.
What are the steps to reproduce?
Here is a plunker, but it does not work with a routerlink. Nevertheless, the code is in place:
The first list in the template works fine, but in the second list (where the anchor tag is wrapped into a md-list-item, the delay happens)
http://plnkr.co/edit/mPAVdd125AAohyKC2mWf
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
I use beta 6
Is there anything else we should know?

We do this exact thing on our guides page: https://material.angular.io/guides
https://github.com/angular/material.angular.io/blob/master/src/app/pages/guide-list/guide-list.html
Not seeing any delay there; likely something within your app.

Ok, thanks for having a look on it.


[models] Ensure all TensorFlow models are ONNX exportable

Most users of the library are more interested in existing pretrained models to use for inference rather than training. For this reason, it's important to ensure we can easily export those trained models.

General

[ ] Add a unittest/CI job to check that all models can be exported with ONNX

Classification

[x] VGG
[x] ResNet
[ ] MobileNet V3
[x] MAGC ResNet

Text Detection

[ ] LinkNet
[ ] DBNet

Text Recognition

[ ] CRNN
[ ] SAR
[ ] MASTER

@frgfm update to Onnx i think that's ok !? :)

If that's the case, would you mind linking all the PRs to the issue description? :pray:

Closed with #1182


[gardening] Remove conditional casts from Error to NSError.

Since Swift 3 (IIRC) Error can always be casted to NSError, so the
conditional casts are always going to succeed and they produce warnings.
However because in macOS SwiftFoundation.NSError is not the ObjC
NSError, the compiler misses this, and might fail to mark some catch as
exhaustives.
To avoid one warning per use of NSError, move all the warnings into a
single one in a utility function, used from all the places when Error
needs to be transformed into NSError. In a couple of cases, the code is
simplified because a branch disappears.
This should remove a lot of warnings while compiling the tests.

@swift-ci please test

I will try to have a look at what you are saying. I might be able to avoid the warnings while keeping the compatibility.

@millenomi: I think I found what you were referring to. Could it be #2158? I think the current solution will be better than the previous one. It still produces a warning, but it was a clear comment that the warning cannot be removed, but at least removes the multiple warnings and reduces noise a lot.
@swift-ci please test

Rebased on top of current master. I checked if any other of this warning appeared in the mean time and it looks like it still covers all of them.
@millenomi: do you have some feedback about these changes? If you prefer not to apply, that's fine with me. I can abandon this PR in that case.
@swift-ci please test Linux platform

@swift-ci please test Linux platform


[WIP] Adding support for SAM Account Name AD Authentication

miq_ldap changes
ldap_domain changes
UI changes for new SAM Account Name user type pulldown
Allows for optional domain\username to be specified on login screen

https://bugzilla.redhat.com/show_bug.cgi?id=1169937

@dclarizio @h-kataria please review UI code.
Harpreet, for the initial form with no changes, hidden_div_if wasn't working for me, I ended up hiding the rows with javascript as you see at the end of the haml file.  There's probably a better way.

@lfu please review MiqLdap changes made for Domain Prefix.  Thanks.

@abellotti UI changes look good, tested in UI.


[Semantic API] Add support for getting the annotation attachment values at source-only attach points

Currently when you get the annotations of a particular symbol, it only gives the symbol(s) of the annotation(s) attached to that construct. Need to improve this to be able to provide the value of the annotation at the attach points.

FE changes will be introduced in https://github.com/ballerina-platform/ballerina-lang/pull/35189. The annotation value will be available (as a constant symbol) for all const annotations (not only source-only annotations).


can not used in<EMAIL_ADDRESS>

cannot use

@dinhani - this isn't working in 1.41.1 either, dated 2019-12-18; is there any chance you can update?

@jameshueston
Maybe it is conflicting with something else?
My environment is almost similar to yours, the only difference is the minor version of Windows and it worked fine.
Version: 1.41.1 (system setup)
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:58:56.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362


Foundation.toggler.js is causing: TypeError: Cannot read property '0' of undefined when using ES6 modules

When importing foundation plugins using ES6 modules, foundation.toggler.js is causing: TypeError: Cannot read property '0' of undefined if input is undefined on line 55 in js/foundation.toggler.js. This is the simple fix:
  if (input) {
    // Allow for a . at the beginning of the string
    this.className = input[0] === '.' ? input.slice(1) : input;
  }

I think the fix is not correct, because the use case here is not quite right - toggler as designed is supposed to listen for the toggle event and simply toggle a class. Calling it without a class as an argument should not be valid!
However, I do think it should accept that class as an option and not only as a data attribute, which would allow us to wrap it up more nicely in a vue directive

@ncoden Is this resolved by https://github.com/zurb/foundation-sites/pull/10952 which is merged?

Yes, thanks for the bumb.


Start preparing 2.0

This PR merges the changes from 2.x-jdk8-master to master.
With this, we prepare for Spine release 2.0.

@armiol, PTAL.

@armiol, PTAL.


Networkname not found exception

Entering a network path in the open settings dialog at the beginning results in an unhandled exception when the path points to a network computer name that does not exist.

This is no longer an issue, as implementation has changed completely.


Build broken on Windows 10 platform

Build is broken on Windows platform.
After cloning repo for commit 807953db8911c2a8b320b372a4f2ff74c2452046
running .\build.ps1 throws:
PowerShell version: 5.1.15063.502
Free physical memory: 11573 MB out of 16300 MB

Loading personal and system profiles took 1746ms.
PS C:\> E:
PS E:\> cd src\ms\dotnet\src-bld
PS E:\src\ms\dotnet\src-bld> .\build.ps1
Get-Content : Cannot find path 'E:\src\ms\dotnet\src-bld\.cliversion' because it does not exist.
At E:\src\ms\dotnet\src-bld\build.ps1:5 char:15
+ $SdkVersion = Get-Content (Join-Path $ScriptRoot ".cliversion")
+               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (E:\src\ms\dotnet\src-bld\.cliversion:String) [Get-Content], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetContentCommand

& : The term 'E:\src\ms\dotnet\src-bld\bootstrap\bootstrap.ps1' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At E:\src\ms\dotnet\src-bld\build.ps1:7 char:3
+ & "$ScriptRoot\bootstrap\bootstrap.ps1"
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (E:\src\ms\dotne...p\bootstrap.ps1:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

& : The term 'E:\src\ms\dotnet\src-bld\Tools\dotnetcli\dotnet' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At E:\src\ms\dotnet\src-bld\build.ps1:8 char:3
+ & "$ScriptRoot\Tools\dotnetcli\dotnet" restore "$ScriptRoot\tasks\Mic ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (E:\src\ms\dotne...otnetcli\dotnet:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

& : The term 'E:\src\ms\dotnet\src-bld\Tools\dotnetcli\dotnet' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At E:\src\ms\dotnet\src-bld\build.ps1:9 char:3
+ & "$ScriptRoot\Tools\dotnetcli\dotnet" build "$ScriptRoot\tasks\Micro ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (E:\src\ms\dotne...otnetcli\dotnet:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

& : The term 'E:\src\ms\dotnet\src-bld\Tools\dotnetcli\dotnet' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At E:\src\ms\dotnet\src-bld\build.ps1:10 char:3
+ & "$ScriptRoot\Tools\dotnetcli\dotnet" "$ScriptRoot\Tools\dotnetcli\s ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (E:\src\ms\dotne...otnetcli\dotnet:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

& : The term 'E:\src\ms\dotnet\src-bld\Tools\dotnetcli\dotnet' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At E:\src\ms\dotnet\src-bld\build.ps1:11 char:3
+ & "$ScriptRoot\Tools\dotnetcli\dotnet" "$ScriptRoot\Tools\dotnetcli\s ...
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (E:\src\ms\dotne...otnetcli\dotnet:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Attempt to initialize Tools via init-tools.cmd fails with the following error:
Running init-tools
Installing 'https://dotnetcli.azureedge.net/dotnet/Sdk/2.0.0-preview3-006845/dotnet-dev-win-x<IP_ADDRESS>-preview3-006845.zip' to 'e:\src\ms\dotnet\src-bld\Tools\dotnetcli\dotnet-dev-win-x<IP_ADDRESS>-preview3-006845.zip'
Exception calling "DownloadFile" with "2" argument(s): "The remote server returned an error: (404) Not Found."
At line:1 char:48
+ ...  do { try { (New-Object Net.WebClient).DownloadFile('https://dotnetcl ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : WebException

Fixed by #213


Change how config errors are displayed

Rather than rejecting the promise, which results in an Atom toast error message, treat the error like a lint error and display it in the footer.
This becomes far less annoying when opening projects that don't include an .eslintrc.json file.
Fixes #166

Hi @bsyk,
That's a really nice solution to this problem, thanks !
Can you please just squash your commits and add a header to your commit message that follow Angular JS convention.
Like this one:
fix(errors): change how config errors are displayed

This will allow me to merge it has is and the CI will create a new release with your fix automatically 👍


1.5.1

Link to deployed service?

Sorry, here's the link: https://platform.civisanalytics.com/spa/#/reports/services/78452


Can't build the project

I've followed through from chapter0 to chapter 1 of the new edition but was not able to compile the project
https://osblog.stephenmarz.com/ch1.html
Then I downloaded from GitHub chapter 1 from here
https://github.com/sgmarz/osblog/tree/master/risc_v/chapters/ch1
and when I do make run it gives me this error:
cargo build
   Compiling sos v0.1.0 (/home/paulefou/other_projects/rust-os)
error: language item required, but not found: `eh_personality`

error: aborting due to previous error

error: could not compile `sos`

To learn more, run the command again with --verbose.
make: *** [Makefile:28: all] Error 101

I also had to change asm! to llvm_asm! as compiler complained about legacy syntax.

This problem should be reported in the project repository (https://github.com/sgmarz/osblog), not here. And to fix compilation problems you have to update the syntax asm!

Oh yeah, my bad,  sorry.
I will reopen in the appropriate repo


slash commands: Add /ping and fix /day and /night

Merged, thanks @showell!  Some natural follow-ups:

We could eliminate do_widget_pre_save_actions by moving stats to this system.  Currently, I don't see a good reason why we would want to keep that old mechanism, so this seems like a good idea.
We should have a discussion about what the zcommand endpoint should be called, since that's one name in this API that we will eventually be pretty stuck with.
We should talk through what we want display styling to be for these; at the very least, probably we want the background color to depend on the result :).

For zcommand, I'm open to better names, although it's tricky to avoid overloaded names for that.
For the styling, I'm definitely up for something better than the tell_user hack, and that's probably a good task for somebody like Cynthia.  For things like hitting /day when you're already in day mode, I don't know if we need to distinguish that stylistically from the true success case of actually toggling the mode, but we could certainly pass back something in the response to indicate that.
For whether we make /stats work like /day and /night (and then remove that hook), I'm kind of wait-and-see on that.  For things like /day that clearly only affect the current user, we want to avoid stream spam.  But I think for other potential slash commands, you may intend for public stuff.  A good example would "/welcome_noob", where the slash command expands out into a canned message that everybody on the stream sees (and thus you avoid welcoming the newbie multiple times).


Baseline refactoring to prepare for cleanups

Doesn't change any behavior, just prepares the codebase a bit by moving a few things to new files and beginning to add a new class for a generic GPTMessage. I need to experiment with how we will use this with images and context.
Instead of passing things through, now that we have one larger function, we can just set a state variable at the start, check it right before the query, and then reset it at the end of the query. I think this might be easier and we don't need to pass things around. Will explore this later.

Merging since this doesn't affect any user-facing behavior


[Working] List of mods

Log: https://smapi.io/log/766fbccc67ec4b2f9706305075cce5a1
Mod name: Miru's Krobus Portraits and Characters
Working Status: old_version
Working Download link: https://www.nexusmods.com/Core/Libs/Common/Widgets/ModRequirementsPopUp?id=69770&game_id=1303
Working version: 1.0.0
Latest version: 1.1
Mod name: Part of the Community
Working Status: old_version
Working Download link: https://www.nexusmods.com/stardewvalley/mods/923?tab=files&file_id=33459
Working version: 1.1.6-3
Latest version: 1.2.0
Mod name: Chests Anywhere
Working Status: alternate_version
Working Download link: https://www.nexusmods.com/Core/Libs/Common/Widgets/ModRequirementsPopUp?id=77888&game_id=1303
Working version: 1.22.9
Latest version: 1.23.3
Mod name: Better Workbenches
Working Status: fully however the scaling is off for me and the workbench text does not lineup how it should.
Working Download link: https://www.nexusmods.com/stardewvalley/mods/4830/?tab=files&BH=0
Working version: 1.0.2
Latest version: 1.0.2
Mod name: Destroyable Bushes
Working status: fully
Working Download link: https://www.nexusmods.com/stardewvalley/mods/6304?tab=files&file_id=74560
Working version: 1.2.2
Latest version:  1.3.1
Mod name: Combat Made Easy Suite (Content Patcher)
Working status: fully
Working Download link: https://www.nexusmods.com/Core/Libs/Common/Widgets/ModRequirementsPopUp?id=58963&game_id=1303
Working version: 5.0.1
Latest version: 6.0.3
I wasn't sure what UniqueID meant.

The uniqueID is the uniqueid field in the manifest