Request Operation from EnvoyFilter not appearing in Envoy Configuration for Ingress Gateway

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
I'm applying the following EnvoyFilter for ingressgateway:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: istio-attributegen-filter
spec:
  configPatches:
  - applyTo: HTTP_FILTER
    match:
      context: GATEWAY
      proxy:
        proxyVersion: '^1\.8.*'
      listener:
        filterChain:
          filter:
            name: "envoy.http_connection_manager"
            subFilter:
              name: "istio.stats"
    patch:
      operation: INSERT_BEFORE
      value:
        name: istio.attributegen
        typed_config:
          "@type": type.googleapis.com/udpa.type.v1.TypedStruct
          type_url: type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm
          value:
            config:
              configuration:
                "@type": type.googleapis.com/google.protobuf.StringValue
                value: |
                  {
                    "attributes": [
                      {
                        "output_attribute": "istio_operationId",
                        "match": [
                          {
                            "value": "PatchEndUser",
                            "condition": "request.url_path.startsWith('/example/')"
                          },
                          {
                            "value": "GetOperationTest",
                            "condition": "request.method == 'GET'"
                          }
                        ]
                      }
                    ]
                  }
              vm_config:
                runtime: envoy.wasm.runtime.null
                code:
                  local: { inline_string: "envoy.wasm.attributegen" }

I also applied the following telemetry change:
values:
    telemetry:
      v2:
        prometheus:
          configOverride:
            gateway:
              disable_host_header_fallback: true
              metrics:
                - name: requests_total
                  dimensions:
                    request_operation: istio_operationId

However, when I go to see my metrics in Prometheus, the request_operation is always empty. After some debugging with folks on Slack, I pulled the envoy configuration for the ingressgateway and found the telemetry change was there, but my attribute gen filter was not:
[
    {
        "name": "<IP_ADDRESS>_8443",
        "address": {
            "socketAddress": {
                "address": "<IP_ADDRESS>",
                "portValue": 8443
            }
        },
        "filterChains": [
            {
                "filters": [
                    {
                        "name": "envoy.filters.network.http_connection_manager",
                        "typedConfig": {
                            "@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager",
                            "statPrefix": "outbound_<IP_ADDRESS>_8443",
                            "rds": {
                                "configSource": {
                                    "ads": {},
                                    "resourceApiVersion": "V3"
                                },
                                "routeConfigName": "http.443"
                            },
                            "httpFilters": [
                                {
                                    "name": "istio.metadata_exchange",
                                    "typedConfig": {
                                        "@type": "type.googleapis.com/udpa.type.v1.TypedStruct",
                                        "typeUrl": "type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm",
                                        "value": {
                                            "config": {
                                                "configuration": {
                                                    "@type": "type.googleapis.com/google.protobuf.StringValue",
                                                    "value": "{}\n"
                                                },
                                                "vm_config": {
                                                    "code": {
                                                        "local": {
                                                            "inline_string": "envoy.wasm.metadata_exchange"
                                                        }
                                                    },
                                                    "runtime": "envoy.wasm.runtime.null"
                                                }
                                            }
                                        }
                                    }
                                },
                                {
                                    "name": "envoy.filters.http.cors",
                                    "typedConfig": {
                                        "@type": "type.googleapis.com/envoy.extensions.filters.http.cors.v3.Cors"
                                    }
                                },
                                {
                                    "name": "envoy.filters.http.fault",
                                    "typedConfig": {
                                        "@type": "type.googleapis.com/envoy.extensions.filters.http.fault.v3.HTTPFault"
                                    }
                                },
                                {
                                    "name": "istio.stats",
                                    "typedConfig": {
                                        "@type": "type.googleapis.com/udpa.type.v1.TypedStruct",
                                        "typeUrl": "type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm",
                                        "value": {
                                            "config": {
                                                "configuration": {
                                                    "@type": "type.googleapis.com/google.protobuf.StringValue",
                                                    "value": "{\n  \"disable_host_header_fallback\": true,\n  \"metrics\": [\n   {\n     \"name\": \"requests_total\",\n     \"dimensions\": {\n       \"request_operation\": \"istio_operationId\"\n     }\n   }]\n}\n"
                                                },
                                                "root_id": "stats_outbound",
                                                "vm_config": {
                                                    "code": {
                                                        "local": {
                                                            "inline_string": "envoy.wasm.stats"
                                                        }
                                                    },
                                                    "runtime": "envoy.wasm.runtime.null",
                                                    "vm_id": "stats_outbound"
                                                }
                                            }
                                        }
                                    }
                                },
                                {
                                    "name": "envoy.filters.http.router",
                                    "typedConfig": {
                                        "@type": "type.googleapis.com/envoy.extensions.filters.http.router.v3.Router"
                                    }
                                }
                            ],
                            "tracing": {
                                "clientSampling": {
                                    "value": 100
                                },
                                "randomSampling": {
                                    "value": 1
                                },
                                "overallSampling": {
                                    "value": 100
                                }
                            },
                            "httpProtocolOptions": {},
                            "serverName": "istio-envoy",
                            "streamIdleTimeout": "0s",
                            "accessLog": [
                                {
                                    "name": "envoy.access_loggers.file",
                                    "typedConfig": {
                                        "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog",
                                        "path": "/dev/stdout",
                                        "logFormat": {
                                            "jsonFormat": {
                                                "authority": "%REQ(:AUTHORITY)%",
                                                "bytes_received": "%BYTES_RECEIVED%",
                                                "bytes_sent": "%BYTES_SENT%",
                                                "connection_id": "%CONNECTION_ID%",
                                                "connection_termination_details": "%CONNECTION_TERMINATION_DETAILS%",
                                                "downstream_direct_remote_address": "%DOWNSTREAM_DIRECT_REMOTE_ADDRESS%",
                                                "downstream_local_address": "%DOWNSTREAM_LOCAL_ADDRESS%",
                                                "downstream_remote_address": "%DOWNSTREAM_REMOTE_ADDRESS%",
                                                "duration": "%DURATION%",
                                                "method": "%REQ(:METHOD)%",
                                                "path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%",
                                                "protocol": "%PROTOCOL%",
                                                "referer": "%REQ(REFERER)%",
                                                "request_duration": "%REQUEST_DURATION%",
                                                "request_id": "%REQ(X-REQUEST-ID)%",
                                                "requested_server_name": "%REQUESTED_SERVER_NAME%",
                                                "response_code": "%RESPONSE_CODE%",
                                                "response_code_details": "%RESPONSE_CODE_DETAILS%",
                                                "response_duration": "%RESPONSE_DURATION%",
                                                "response_flags": "%RESPONSE_FLAGS%",
                                                "response_tx_duration": "%RESPONSE_TX_DURATION%",
                                                "route_name": "%ROUTE_NAME%",
                                                "start_time": "%START_TIME(%Y-%m-%d %H:%M:%S.%6f)%",
                                                "upstream_cluster": "%UPSTREAM_CLUSTER%",
                                                "upstream_host": "%UPSTREAM_HOST%",
                                                "upstream_local_address": "%UPSTREAM_LOCAL_ADDRESS%",
                                                "upstream_service_time": "%RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)%",
                                                "upstream_transport_failure_reason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%",
                                                "user_agent": "%REQ(USER-AGENT)%",
                                                "x_forwarded_for": "%REQ(X-FORWARDED-FOR)%"
                                            }
                                        }
                                    }
                                }
                            ],
                            "useRemoteAddress": true,
                            "forwardClientCertDetails": "SANITIZE_SET",
                            "setCurrentClientCertDetails": {
                                "subject": true,
                                "cert": true,
                                "dns": true,
                                "uri": true
                            },
                            "upgradeConfigs": [
                                {
                                    "upgradeType": "websocket"
                                }
                            ],
                            "normalizePath": true
                        }
                    }
                ]
            }
        ],
        "trafficDirection": "OUTBOUND",
        "accessLog": [
            {
                "name": "envoy.access_loggers.file",
                "filter": {
                    "responseFlagFilter": {
                        "flags": [
                            "NR"
                        ]
                    }
                },
                "typedConfig": {
                    "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog",
                    "path": "/dev/stdout",
                    "logFormat": {
                        "jsonFormat": {
                            "authority": "%REQ(:AUTHORITY)%",
                            "bytes_received": "%BYTES_RECEIVED%",
                            "bytes_sent": "%BYTES_SENT%",
                            "connection_id": "%CONNECTION_ID%",
                            "connection_termination_details": "%CONNECTION_TERMINATION_DETAILS%",
                            "downstream_direct_remote_address": "%DOWNSTREAM_DIRECT_REMOTE_ADDRESS%",
                            "downstream_local_address": "%DOWNSTREAM_LOCAL_ADDRESS%",
                            "downstream_remote_address": "%DOWNSTREAM_REMOTE_ADDRESS%",
                            "duration": "%DURATION%",
                            "method": "%REQ(:METHOD)%",
                            "path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%",
                            "protocol": "%PROTOCOL%",
                            "referer": "%REQ(REFERER)%",
                            "request_duration": "%REQUEST_DURATION%",
                            "request_id": "%REQ(X-REQUEST-ID)%",
                            "requested_server_name": "%REQUESTED_SERVER_NAME%",
                            "response_code": "%RESPONSE_CODE%",
                            "response_code_details": "%RESPONSE_CODE_DETAILS%",
                            "response_duration": "%RESPONSE_DURATION%",
                            "response_flags": "%RESPONSE_FLAGS%",
                            "response_tx_duration": "%RESPONSE_TX_DURATION%",
                            "route_name": "%ROUTE_NAME%",
                            "start_time": "%START_TIME(%Y-%m-%d %H:%M:%S.%6f)%",
                            "upstream_cluster": "%UPSTREAM_CLUSTER%",
                            "upstream_host": "%UPSTREAM_HOST%",
                            "upstream_local_address": "%UPSTREAM_LOCAL_ADDRESS%",
                            "upstream_service_time": "%RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)%",
                            "upstream_transport_failure_reason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%",
                            "user_agent": "%REQ(USER-AGENT)%",
                            "x_forwarded_for": "%REQ(X-FORWARDED-FOR)%"
                        }
                    }
                }
            }
        ]
    }
]

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
I would expect the metric istio_requests_total to include a non-unknown operation, and for my gateway's proxy configuration to contain my envoy filter.
Steps to reproduce the bug
Apply the above envoy filter, and observe the configuration
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
client version: 1.8.2
control plane version: 1.8.2
data plane version: 1.8.2 (22 proxies)

How was Istio installed?
The following istio operator config was rendered as a manifest (istioctl manifest generate -f istioconfig.yaml > manifest.yaml) and applying using k apply -f
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: istiocontrolplane
spec:
  profile: default
  meshConfig:
    accessLogFile: "/dev/stdout"
    accessLogEncoding: JSON
    accessLogFormat: |
        {
          "start_time": "%START_TIME(%Y-%m-%d %H:%M:%S.%6f)%",
          "request_id": "%REQ(X-REQUEST-ID)%",
          "connection_id": "%CONNECTION_ID%",
          "authority": "%REQ(:AUTHORITY)%",
          "protocol": "%PROTOCOL%",
          "method": "%REQ(:METHOD)%",
          "path": "%REQ(X-ENVOY-ORIGINAL-PATH?:PATH)%",
          "referer": "%REQ(REFERER)%",
          "route_name": "%ROUTE_NAME%",
          "requested_server_name": "%REQUESTED_SERVER_NAME%",
          "bytes_received": "%BYTES_RECEIVED%",
          "bytes_sent": "%BYTES_SENT%",
          "user_agent": "%REQ(USER-AGENT)%",
          "duration": "%DURATION%",
          "request_duration": "%REQUEST_DURATION%",
          "response_duration": "%RESPONSE_DURATION%",
          "response_tx_duration": "%RESPONSE_TX_DURATION%",
          "response_code": "%RESPONSE_CODE%",
          "response_code_details": "%RESPONSE_CODE_DETAILS%",
          "response_flags": "%RESPONSE_FLAGS%",
          "connection_termination_details": "%CONNECTION_TERMINATION_DETAILS%",
          "upstream_cluster": "%UPSTREAM_CLUSTER%",
          "upstream_host": "%UPSTREAM_HOST%",
          "upstream_local_address": "%UPSTREAM_LOCAL_ADDRESS%",
          "upstream_service_time": "%RESP(X-ENVOY-UPSTREAM-SERVICE-TIME)%",
          "upstream_transport_failure_reason": "%UPSTREAM_TRANSPORT_FAILURE_REASON%",
          "downstream_remote_address": "%DOWNSTREAM_REMOTE_ADDRESS%",
          "downstream_direct_remote_address": "%DOWNSTREAM_DIRECT_REMOTE_ADDRESS%",
          "x_forwarded_for": "%REQ(X-FORWARDED-FOR)%",
          "downstream_local_address": "%DOWNSTREAM_LOCAL_ADDRESS%"
        }

    enablePrometheusMerge: false
  components:
    pilot:
      enabled: true
      k8s:
        replicaCount: 3
        strategy:
          rollingUpdate:
            maxSurge: 25%
            maxUnavailable: 0%
        podDisruptionBudget:
          minAvailable: 1
          selector:
            matchLabels:
              app: istiod
              istio: pilot
        hpaSpec:
          maxReplicas: 5
          metrics:
          - resource:
              name: cpu
              targetAverageUtilization: 50
            type: Resource
          minReplicas: 3
    ingressGateways:
      - name: istio-ingressgateway
        enabled: false
      - enabled: true
        namespace: istio-system
        name: external-ingressgateway
        label:
          app: external-ingressgateway
          istio: external-ingressgateway
        k8s:
          replicaCount: 5
          env:
          - name: ISTIO_META_ROUTER_MODE
            value: sni-dnat
          podDisruptionBudget:
            minAvailable: 5
            selector:
              matchLabels:
                app: external-ingressgateway
                istio: external-ingressgateway
          hpaSpec:
            maxReplicas: 50
            metrics:
            - resource:
                name: cpu
                targetAverageUtilization: 50
              type: Resource
            minReplicas: 5
            scaleTargetRef:
              apiVersion: apps/v1
              kind: Deployment
              name: external-ingressgateway
          resources:
            limits:
              cpu: 6000m
              memory: 1024Mi
            requests:
              cpu: 1000m
              memory: 1024Mi
          serviceAnnotations:
            service.beta.kubernetes.io/aws-load-balancer-ssl-cert: CERT-XXXXXXXXXXXXXXXXXX
            service.beta.kubernetes.io/aws-load-balancer-ssl-negotiation-policy: ELBSecurityPolicy-TLS-1-2-2017-01
            service.beta.kubernetes.io/aws-load-balancer-backend-protocol: tcp
            service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: "*"
            service.beta.kubernetes.io/aws-load-balancer-ssl-ports: "443"
            service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"
            service.beta.kubernetes.io/aws-load-balancer-type: nlb
          service:
            ports:
            - name: https
              port: 443
              targetPort: 8443
            - name: http
              port: 80
              targetPort: 8080
            externalTrafficPolicy: Local
          strategy:
            rollingUpdate:
              maxSurge: 25%
              maxUnavailable: 0%
  values:
    telemetry:
      v2:
        prometheus:
          configOverride:
            gateway:
              disable_host_header_fallback: true
              metrics:
                - name: requests_total
                  dimensions:
                    request_operation: istio_operationId

Environment where the bug was observed (cloud vendor, OS, etc)
EKS
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

Could you run kubectl get envoyfilter -n istio-system? Just first want to make sure the envoyfilter is there.

⫸ kubectl get envoyfilter -n istio-system
NAME                        AGE
istio-attributegen-filter   199d
metadata-exchange-1.4       225d
metadata-exchange-1.5       225d
metadata-exchange-1.6       225d
metadata-exchange-1.7       14d
metadata-exchange-1.8       14d
stats-filter-1.4            225d
stats-filter-1.5            225d
stats-filter-1.6            225d
stats-filter-1.7            14d
stats-filter-1.8            14d
tcp-metadata-exchange-1.5   225d
tcp-metadata-exchange-1.6   225d
tcp-metadata-exchange-1.7   14d
tcp-metadata-exchange-1.8   14d
tcp-stats-filter-1.5        225d
tcp-stats-filter-1.6        225d
tcp-stats-filter-1.7        14d
tcp-stats-filter-1.8        14d

@jaronoff97 Could you try delete and recreate istio-attributegen-filter? Wondering if age would make a difference, because it is configured to be positioned relative to istio.stats filter, which is created after istio-attributegen-filter.

WOW that did it! Did a delete and recreate, and that was the problem

This won't be an issue if we make stats filters config first class: https://github.com/istio/istio/issues/28410 but that won't happen in short term.
Inter dependencies between filters applied by envoyfilter is unlikely going to be stable. Maybe you simply insert this Envoyfilter at the first with INSERT_FIRST. That should make it work even after upgrading.

Since this issue has been resolved, I'm going to close. Please feel free to reopen if more is needed here.

Hi @bianpengyuan, I'm having a related issue and using INSERT_FIRST instead of INSERT_BEFORE patch operation didn't help.
I have live traffic flowing through my prod environment and I'm trying to migrate from Telemetry V1 to V2 (including the use of attribute gen filter). I was hoping that I can pre-emptively apply the attribute gen filter into my cluster before performing the actual migration via istioctl, so that I won't lose any observability on my cluster at any one point in time. However, using INSERT_FIRST didn't work; The attributes will only be properly registered if I apply it after the creation of istio.stats filter.
This is how my filter roughly looks like:
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: istio-attributegen-filter
  namespace: istio-system
spec:
  configPatches:
    - applyTo: HTTP_FILTER
      match:
        context: ANY
        listener:
          filterChain:
            filter:
              name: envoy.http_connection_manager
              subFilter:
                name: istio.stats
        proxy:
          proxyVersion: ^1\.7.*
      patch:
        operation: INSERT_FIRST
        value:
          name: istio.attributegen
          typed_config:
            "@type": type.googleapis.com/udpa.type.v1.TypedStruct
            type_url: type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm
            value:
              config:
                configuration:
                  "@type": "type.googleapis.com/google.protobuf.StringValue"
                  value: |
                    {
                      "attributes": [...]
                    }
                vm_config:
                  code:
                    local:
                      inline_string: envoy.wasm.attributegen
                  runtime: envoy.wasm.runtime.null

For benefit of those having the same issues, I managed to resolve it with the following filter configuration. Basically I had to remove the subFilter match option (because this filter doesn't yet exist).
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: istio-attributegen-filter
  namespace: istio-system
spec:
  configPatches:
    - applyTo: HTTP_FILTER
      match:
        context: ANY
        listener:
          filterChain:
            filter:
              name: envoy.http_connection_manager
        proxy:
          proxyVersion: ^1\.7.*
      patch:
        operation: INSERT_BEFORE
        value:
          name: istio.attributegen
          typed_config:
            "@type": type.googleapis.com/udpa.type.v1.TypedStruct
            type_url: type.googleapis.com/envoy.extensions.filters.http.wasm.v3.Wasm
            value:
              config:
                configuration:
                  "@type": "type.googleapis.com/google.protobuf.StringValue"
                  value: |
                    {
                      "attributes": [...]
                    }
                vm_config:
                  code:
                    local:
                      inline_string: envoy.wasm.attributegen
                  runtime: envoy.wasm.runtime.null


Please add ColdFusion / CFML language support

Hi! Thank you for your work on this tool! Could you please add ColdFusion / CFML language support?
ColdFusion is the official language from Adobe. It's been in use since 1995 (and has been the core language I've used since '97.)
https://helpx.adobe.com/coldfusion/user-guide.html
Lucee CFML is an alternative open-source CFML platform and has some tags & functions that differ slightly from Adobe's.
https://docs.lucee.org/

thank you, will investigate

Yeah, it will be a great edition. A lot of ColdFusion programmers I know will certainly benefit from this.

What's required in order for a language to be supported by jscpd?  (Is there any documentation regarding this?)
I see a list of languages here. They all appear to reference the RePrism project.
https://github.com/kucherenko/jscpd/blob/master/packages/tokenizer/src/grammar-loader.ts
The RePrism project is a tweaked version of PrismJS.  A "cfscript" language file (which support script syntax) was merged back in early 2021.
https://github.com/PrismJS/prism/blob/master/components/prism-cfscript.js
Does the RePrism project (which hasn't push any updates in the last 6 years) need to be requested to include the new cfscript language file?
Thanks.


Document inline stylesheets

What kind of changes does this PR include?

New or updated content

Description

Adds a section to the Styles & CSS page which explains inlining.

I like this section, and I like it where it's located!
One quick thing that comes to mind is whether there are any Tailwind implications with this, since so many people will be using Tailwind. Is there something relevant or useful to say about whether or how this does/doesn't include/affecvt your Tailwind styles?

Stylesheets created by tailwind would be treated the same as those created by any other source.

I haven't used tailwind, so I can't get in the mindset of a user. Whether a reassurance is necessary depends on whether astro+tailwind users are used to things not working without fiddling.


Rotation estimation

Is there a way to estimate a detected object's rotation(custom dataset)? I know that it is not a 3D object detection project.
For example with a detected object's key features, like a human's eyes but with an object's typical part, so something that is clearly associated with the front. I don't have 3D CAD Models.

@Kanyade, that sounds like an interesting idea! I can imagine it's doable if you have 3D models to match the feature points, but it's also doable in a computer vision way if only targeting a few objects.
You can set up a dataset that includes rotation labels to train your Yolo model. Like this example label set:
[person-front, person-back, car-front, car-back]
I think it will work if you have enough data.

I don't have 3D models, it is a great idea, thank you!


Add new version to F-Droid

F-Droid only has the old version at https://jecelyin.github.io/920-Text-Editor-old
Can this version be added to F-Droid?

What are your thoughts on adding it?

It has been deprecated, I no longer update it.

Yes, can this version be added to F-Droid since the old one is deprecated?

what's Android version of your F-Droid phone?

KitKat


Create solution to check that book does not exist in database (title-check)

Unittests for title-check passes. In UI not possible to add same title twice.
This pr added onto previous merged pull request https://github.com/Wincewind/ohtu-s23-miniprojekti/pull/32, merged approx. 1h ago. Should not be any conflicts.
.env.test set back to original form

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1c546ca) 97.80% compared to head (f54bdc8) 95.32%.

Files
Patch %
Lines

src/dataprocessing.py
75.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   97.80%   95.32%   -2.48%
==========================================
  Files           5        5
  Lines          91      107      +16
  Branches        6        8       +2
==========================================
+ Hits           89      102      +13
- Misses          2        5       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


extract lighthouse plugin?

Depending on the outcome of #3 it might make sense to extract the lighthouse functionality into its own plugin

Won't do in the foreseeable future. Closing.


MSL: Inline uniform blocks in Metal argument buffer containing structs need padding if std140 alignment

When using the ComplierMSL::add_inline_uniform_block() function to embed block data directly into a Metal argument buffer, if std140 alignment is enabled, structs and array elements are required to be aligned (padded) to 16 bytes. However, Metal's default struct alignment is simply that of its member with the largest alignment.
For example, in the following generated MSL, Metal will assume the size and alignment of the first two members of spvDescriptorSetBuffer0 is 4 bytes, but GLSL, SPIR-V, and Vulkan assume they are 16 bytes:
struct _10
{
    int _m0;
};

struct _22
{
    int _m0;
};

struct _30
{
    int _m0;
};

struct spvDescriptorSetBuffer0
{
    _10 m_12 [[id(0)]];
    _22 m_24 [[id(1)]];
    device _30* m_32 [[id(2)]];
};

SPIR-V, MSL & GLSL conversion output for the source of this example is here: MSLArgBuff-InlineUniformBlock.txt
If std140 alignment is active, these structs need to be aligned or padded to 16 bytes in the generated MSL. This is not required if using std430 alignment.
I expect this behaviour should also be optional via CompilerMSL::Options to allow it to be turned off if the Vulkan uniformBufferStandardLayout feature has been enabled.
I wonder if this padded alignment might be done using the alignas specifier on the members of spvDescriptorSetBufferN that are structs, using the minimum of the largest struct element or 16 when std140 is active.

I wonder if this padded alignment might be done using the alignas specifier on the members of spvDescriptorSetBufferN that are structs, using the minimum of the largest struct element or 16 when std140 is active.

This will align the struct itself to that. We need to align the members of that struct that are themselves structs--or arrays.
Unfortunately, it won't work for arrays, because for arrays we need to align the element itself, not the array as a whole. There is no way to make alignas apply to an array element. I've filed FB8847491 asking for this.

This will align the struct itself to that. We need to align the members of that struct that are themselves structs--or arrays.

Which struct are you saying will be aligned? I was suggesting to add the alignas to each member of spvDescriptorSetBufferN that are themselves structs, expecting that it would align only that member (ie- pad between members of spvDescriptorSetBufferN).
Are you indicating the entire spvDescriptorSetBufferN would be what is aligned? Therefore we'd need to add the alignas to say the struct _10 definition above?
And yes...arrays are even more problematic and harder to deal with. I wonder if putting the alignas on the struct definition (ie- struct _10 above) would solve that?

instead of using alignas, we could also just add appropriate padding members between the actual members of spvDescriptorSetBufferN, as we sometimes do elsewhere in MSL generation.

Are you indicating the entire spvDescriptorSetBufferN is what would be aligned?

No. I'm saying that, when we have an inline uniform block, the struct for the block is embedded in the argument buffer. That's the struct that will get aligned, and that's the struct whose composite members need explicit alignment.

Therefore we'd need to add the alignas to say the struct _10 definition above?

No. We'd need to add it to the members of struct _10. And struct _22.

And yes...arrays are even more problematic and harder to deal with. I wonder if putting the alignas on the struct definition (ie- struct _10 above) would solve that?

If the IUB itself is arrayed, that might work. If the IUB has an array that is a member, that's a problem--especially if that member's elements are of a scalar or vector type.

We'd need to add it to the members of struct _10.

Okay. Gotcha. In my example, I was dealing only with the alignment of the elements of the Metal argument buffer itself, not with the members of those elements. Fair enough...and good catch.
So we'll need to do both. Because in the example above, we don't need to align the int _m0, but we do need to align the members of spvDescriptorSetBuffer0.

Is it even required to support more than one inline uniform buffer per descriptor set? If only one inline UBO is used, there is no alignment issue I think?

Is it even required to support more than one inline uniform buffer per descriptor set? If only one inline UBO is used, there is no alignment issue I think?

Is it even required to support more than one inline uniform buffer per descriptor set? If only one inline UBO is used, there is no alignment issue I think?

The SPIR-V that I included a link for above includes a descriptor set that contains two Block bindings. These become inline structs in an MSL argument buffer.
I've worked around this issue for now by using temporary MTLBuffers for blocks. Once things are farther along, we can revisit this further.

Is it even required to support more than one inline uniform buffer per descriptor set? If only one inline UBO is used, there is no alignment issue I think?

The SPIR-V that I included a link for above includes a descriptor set that contains two Block bindings. These become inline structs in an MSL argument buffer.
I've worked around this issue for now by using temporary MTLBuffers for blocks. Once things are farther along, we can revisit this further.


to_zip does not include remote resources

Overview
to_zip ignores remote resources:
from frictionless import Package
p = Package('https://zenodo.org/record/7078768')
p.to_zip('/tmp/myfiles.zip')

It ignores the remote resources and doesn't include it in the zipped file.
The to_zip function should include remote url/resources as well while zipping the package. The proposed solution would be
package.resolve() # Download remote resource and update metadata accordingly
package.to_zip()

Thanks @shashigharti! I'll investigate


Cython compile error when python build/build.py

I ran $ python build/build.py --enable_cuda and the following error was occurred.
Error compiling Cython file:
------------------------------------------------------------
...

  cdef int lwork = heevd_work_size(n)
  cdef int lrwork = heevd_rwork_size(n)
  cdef int liwork = syevd_iwork_size(n)
  zheevd(&jobz, &uplo, &n, a_out, &n, w_out, work, &lwork, rwork, &lrwork,
         iwork, &liwork, info_out)
                        ^
------------------------------------------------------------

jaxlib/lapack.pyx:837:25: Converting to Python object not allowed without gil
Target //build:install_xla_in_source_tree failed to build

How to resolve?

What version of Cython do you have? Since this is a Cython error, it might be a good idea to make sure that's up-to-date.

@mattjj 0.28.5
I will upgrade cython to latest version and try to build again.

The most likely explanation is you don't have scipy installed. Can you install scipy and try again?

@hawkinsp if we require scipy, should we add it to setup.py?

This failure was due to the version of cython. Thanks!

Glad to hear you got it solved!

I m also getting the error:
Error compiling Cython file:
------------------------------------------------------------
...
      lwork * sizeof(double complex))

  for i in range(b):
    memcpy(a_work, a_in, n * n * sizeof(double complex))
    zgeev(&jobvlr, &jobvlr, &n, a_work, &n, w_out, vl_out, &n, vr_out, &n,
          work, &lwork, r_work, info_out)
                               ^
------------------------------------------------------------

jaxlib/lapack.pyx:1590:32: Converting to Python object not allowed without gil

I have cython and scipy installed and updated to the latest version

@mtthss Can you share the exact versions of your operating system, Python, Cython, and scipy and how you installed them? This has always so far been a symptom of not having scipy visible to python for some reason.

Python 2.7.16 (default, Apr  6 2019, 01:42:57)

>>> import scipy
>>> scipy.__version__
'1.2.2'
>>> import cython
>>> cython.__version__
'0.29.13'

All installed in a clean virtualenv with pip

I have the same with cython from python 3.8.5, 0.29.21.

I am also experiencing this issue.
Python 3.9.6 (tags/v3.9.6:db3ff76, Jun 28 2021, 15:26:21) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

import scipy
scipy.version
'1.7.0'
import cython
cython.version
'0.29.24'

I got this error when installing other libs

Converting to Python object not allowed without gil

then I upgrade scipy and work well.
So i leave a note here in case someone need it


Enhancement - Add "Undo"

Add "undo" capability, particularly for deleted items.

That'll be a tough one. I think it's doable for a defined number of changes back.


System merge sequences while replacing selected monomers from the library in view mode

Steps to Reproduce

Go to Macromolecules mode - Sequence mode
Load from file: System merge sequences while replacing selected monomers from the library in view mode.zip

Select last monomer

Click on C peptide on the library

Actual behavior
System replace A monomer on C peptide and merges two sequences

Expected behavior
System replace A monomer on C peptide, two sequences remain in place

As per requirement:

If the user selects any number of monomers in view mode, and clicks on the monomer card in the library, all selected monomer on the canvas are replaced by chosen monomer from the library each

Versions

Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
Windows 10 Pro
Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - https://github.com/epam/ketcher/issues/4878

Fixed.

Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
Chrome Version 127.0.6533.100 (Official Build) (64-bit)
Win10


Double quotes in attribute

In its current form, pyjade converts
div(ng-hide='status == "Live"')

into
<div ng-hide="status == "Live"")

This seems like incorrect behavior, since it returns incorrect html.
It seems like this can be fixed by changing line 124 of nodes.py to something like:
return ("'%s'" if '"' in string else '"%s"') % string

or by escaping attributes. Normal jade turns such an attribute into:
<div ng-hide="status="Live""

Let me know if I'm missing something or if this seems like a worthwhile fix.
Thanks!

This bug is a problem when sharing the same jade files bw a JS project and python project (and JS is the main source) e.g for buildbot custom_template_dir:
http://docs.buildbot.net/latest/manual/cfg-www.html#web-server
How is it difficult to fix?

+1 for fixing it


avoiding JNDI errors when testing with uberfire code

This use of the InitialContext is causing errors in my tests, and simple-jndi (scope:test) fixes them. :)
See for more info: http://fandry.blogspot.nl/2011/03/junit-based-integration-testing-with.html

@psiroky Apologies -- the PR has been fixed.

+1


CI-Pipeline: Push a new version of an operator package

So, how big do we want this to be? I see this getting kind of KEP-worthy, if we think more about it:

At the moment, we have a helm style release path, right? Build the package, rebuild the repo-index, push new package + index-file

I see at least the following questions we need to solve:

Do we want users and operator-devs to provide their own repositories or do we want to provide some kind of a main repository where everybody can release their (public) operators?

If we want a main repository, how do we generate the index and fetch the packages?

Either keep a list of remote kudo repositories or git repos and fetch artifacts from there and generate a main index
Provide a repository server (something like https://chartmuseum.com/ ), a nexus with a plugin, jfrog artifactory with plugin, etc. where authorized accounts can upload new artifacts


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/787 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 54645e0:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-03-15-03-53-00 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


CNV-21974: clone in progress label

📝 Description
Forward also cloning DS and add label to them in the template list
Do you think other states will be added in the future? Maybe better to consider forwarding all the DS and filtering based on states later?
🎥 Demo
Before

After

/retest

/approve


Move Utf8BufferTextReader to corefx

Hi,
I was wondering if it would be possible to move Utf8BufferTextReader and Utf8BufferTextWriter to corefx and make them public, so other libraries could consume them. These depend on System.Memory and System.Buffers.
Thanks!
Elad

Hi. It is not up to us to make that decision. Raise an issue on the corefx repo and the team who maintain corefx will consider whether those types would be useful for general users.

Will do.
BTW, How do you guys expect people to use System.IO.Pipelines in order to implement their own protocols? Given that these classes are internal and the fact the examples call the ToArray() method, it is likely that people would implement their protocols in an inefficient way.
Not criticizing you guys, just wondering.

Copying our code until we add more bcl types. Things like this take time to permiate through the ecosystem. That’s why there’s so much custom code in here.

There is nothing stopping you from copying Utf8BufferTextReader and Utf8BufferTextWriter into your own implementation.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Fix error message in strict int filter

The filter displayed name of filter as the database filter, not what
user specified.
JIRA: PDC-999

Looks good to me.
A unit test would be better.

I added a check to existing test.

:+1:


Align XML with spec - Update Color control revision

Fixes #26598
The spec revision added clarifications to Scenes support. No change to the implementation, scene must be fully implemented (targetted for 1.3)
This pr does
commit 1
Update colorcontrol cluster revision to 6, with scripts/tools/zap/update_cluster_revisions.py --cluster-id 0x0300 --new-revision 6 --old-revision 5
commit 2
scripts/tools/zap_regen_all.py

Just one question why this diff looks so big ?

@jmeg-sfy Some Zap file were not refreshed/updated in a long time. Zap version changes and name changes in XML are causing all those diff in zap files.


get_best_lr - argmax

Why do you use the argmax method within get_best_lr? Since we are interested in the fastest decrease in the loss shouldn't we use argmin?

It does use argmin:
https://github.com/surmenok/keras_lr_finder/blob/3c8fe719d7e3291a1f72ff8a9a1c51e9fc5d520b/keras_lr_finder/lr_finder.py#L146-L149

Thank you, there seems to be an error on my end with my last pull with vs code.


the jump vision effect of the Exodar should be made longer to persist for the duration of the cast time

@SebastianTanoni Arguably a bug, not a feature request. Your call.

i mean, it would be cool, but im not sure how to make it work, il play around with it
@HerrDave do you know how to do this? just with object editor

@SebastianTanoni No clue, man
I'm still trying to get Unstable Transformation to behave itself


Jade rename to pug

Currently getting the following warning
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade

The Jade repo says:
Jade has been renamed to Pug. You can find the new repo here: https://github.com/pugjs/jade

Appearently Jade HAS to be renamed in the next few months (very few)

I'll contact to npm.

BTW there's also https://github.com/maxknee/hexo-render-pug, which is linked from Hexo's documentation https://hexo.io/docs/themes.html. It's even published to npm @ https://www.npmjs.com/package/hexo-render-pug with an installation description pointing to the wrong package made (hexo-renderer-pug vs. hexo-render-pug.
Le sigh, this confusion seems so unnecessary.

Any news about this?

@demurgos as the hexo-renderer-pug has been registered by others. We decide to continue use the hexo-renderer-jade, but it support pug.

Thanks for the reply.
I've seen that it is registered but this package is not actively maintained. I was mainly wondering @Surgo had a reply or someone else tried to send an email. I'll try to contact the current maintainer.

Hi,
As mentioned in my previous message, I sent an email to @iwarner.
He just replied and sent invitations to a few core maintainers ( @NoahDragon @JLHwung ). Could you check if you have access rights to the npm package? If so, could you reopen this issue to plan a migration path?

@demurgos Thank you for the communications.
@iwarner We don't have access to the npm package since we are not the collaborators of https://www.npmjs.com/package/hexo-renderer-pug, though we do have gained access to the GitHub repository.
@NoahDragon Any consideration on 4.x to migrate all these hexo-* package to scoped package?

Give me an NPM username and I can add

@iwarner Thank you. My NMP account is abnerchou, and @JLHwung is jlhwung. You could add any of us. We may also need your help to move the package to hexojs org. https://www.npmjs.com/org/hexojs
But we will see.

Hexobot is now an owner so you can manage the others now.
➜  hexo-renderer-pug git:(master) ✗ npm owner ls
hexobot<EMAIL_ADDRESS>iwarner<EMAIL_ADDRESS>

Just seen the above - added abnerchou

@JLHwung Using an npm scope would indeed be a great idea for hexo: it would prevent this sort of issues in the future. It would also add a way to find all the hexo packages. npm recently allowed the creation of free organizations (with the limitation that the packages must be public). I'd recommend that one you create a hexo organization even if you don't plan to migrate right away: just to be sure that it is owned by one you.

@demurgos We have registered @hexojs but @hexo seems to be registered by someone.

Ok, yes I've seen there could be a problem with hexo. Organization and user names share the same namespace and there is a user named hexo. At least it's consistent with the Github organization.

@iwarner Thanks. Could you please do me a favor? I couldn't add the package to hexojs org, as I'm not the main contributors. I have added you to the hexojs as admin. Could you please login to the page https://www.npmjs.com/org/hexojs/team/collaborators and add the packages?


[c-sharp] plugin may produce invalid C# code

Describe the bug
Some field names in the schema may contain reserved keywords in C#. When generating code from such schema it will result in invalid C# code. Example reserved keywords are do, in, as, int, protected, etc.
// Invalid C# code
public enum Visibility {
  private,
  public
}

To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:

schema {
  query: Query
}

enum Visibility {
  private,
  public
}

type Query {
  int: Int
  fixed: Boolean
}

My codegen.yml config file:

generates:
  src/main/c-sharp/my-org/my-app/Types.cs:
    plugins:
      - c-sharp

Expected behavior
Reserved keywords should be prefixed with an @, eg @int. From above sample it would be
public enum Visibility {
  @private,
  @public
}

Alternative is using upper case and use JsonProperty to keep the original name. May require more work. And may not be possible everywhere.
public enum Visibility {
  [JsonProperty("private")]
  Private,
  [JsonProperty("public")]
  Public
}

Note, only keywords cannot be used. Seems that the contextual keywords can be used.
Environment:

Can use the current online GraphQL code generator. In the dropdown choose C# Schema Types.

Solved with #4250

Mmm, exploring the typescript code and it's set up differently than in C# plugin (cleaner). For this case maybe I should not introduce that getSafeFieldName function and instead create a converter similar to the upper case, pascal case, etc so it only uses convertName feature to transform value names.
Did not yet figure out how to do chaining/pipe in converter. Any thoughts?

Updated the code and rebased onto master. Also took the chance to clean up the unit test so format looks cleaner (new unit tests for this bug solution are added).
@dotansimha code is ready for review/merge, thanks.

Fixed in v1.16.0


[Dataset] NonMatchingChecksumError due to an update in the LinCE benchmark data

Hi,
There is a NonMatchingChecksumError error for the lid_msaea (language identification for Modern Standard Arabic - Egyptian Arabic) dataset from the LinCE benchmark due to a minor update on that dataset.
How can I update the checksum of the library to solve this issue? The error is below and it also appears in the nlp viewer:
import nlp
nlp.load_dataset('lince', 'lid_msaea')

Output:
NonMatchingChecksumError: ['https://ritual.uh.edu/lince/libaccess/eyJ1c2VybmFtZSI6ICJodWdnaW5nZmFjZSBubHAiLCAidXNlcl9pZCI6IDExMSwgImVtYWlsIjogImR1bW15QGVtYWlsLmNvbSJ9/lid_msaea.zip']
Traceback:
File "/home/sasha/streamlit/lib/streamlit/ScriptRunner.py", line 322, in _run_script
    exec(code, module.__dict__)
File "/home/sasha/nlp-viewer/run.py", line 196, in <module>
    dts, fail = get(str(option.id), str(conf_option.name) if conf_option else None)
File "/home/sasha/streamlit/lib/streamlit/caching.py", line 591, in wrapped_func
    return get_or_create_cached_value()
File "/home/sasha/streamlit/lib/streamlit/caching.py", line 575, in get_or_create_cached_value
    return_value = func(*args, **kwargs)
File "/home/sasha/nlp-viewer/run.py", line 150, in get
    builder_instance.download_and_prepare()
File "/home/sasha/.local/share/virtualenvs/lib-ogGKnCK_/lib/python3.7/site-packages/nlp/builder.py", line 432, in download_and_prepare
    download_config.force_download = download_mode == FORCE_REDOWNLOAD
File "/home/sasha/.local/share/virtualenvs/lib-ogGKnCK_/lib/python3.7/site-packages/nlp/builder.py", line 469, in _download_and_prepare
File "/home/sasha/.local/share/virtualenvs/lib-ogGKnCK_/lib/python3.7/site-packages/nlp/utils/info_utils.py", line 36, in verify_checksums
    raise NonMatchingChecksumError(str(bad_urls))

Thank you in advance!
@lhoestq

Hi @gaguilar
If you want to take care of this, it very simple, you just need to regenerate the dataset_infos.json file as indicated in the doc by running (from the root of the repo):
python nlp-cli test ./datasets/lince --save_infos --all_configs

And then you can open a pull-request with the updated json file.
Otherwise we'll do it sometime this week.

Hi @thomwolf
Thanks for the details! I just created a PR with the updated dataset_infos.json file (#550).

Thanks for updating the json file. Closing this one


BUG: android:windowSoftInputMode="adjustResize" will not work when StatusBar hidden="true"

AndroidManifest.xml
android:windowSoftInputMode="adjustResize"
I found this bug while playing with StatusBar
if you set StatusBar hidden="true" the keyboard push the header out of the screen instead of resizing.
hidden="false"

hidden="true"

"react": "15.4.2",
"react-native": "0.41.0",

Same here..
http://stackoverflow.com/questions/42840555/how-to-avoid-keyboard-pushing-layout-up-on-android-react-native

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported. Specifically, a code sample or Sketch would be ideal here.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

Can you open a new issue?

@hramos no need.
This ended up being my problem: facebook/react-native#12980
Apparently, StatusBar doesn't play nicely with KeyboardAvoidingView on android.
If at any point you app hides the status bar, all bets are off with your KeyboardAvoidingView

@hramos they did open a new issue but you closed that one as well - https://github.com/facebook/react-native/issues/13000

Understood. I just found it funny that we are asking for them to create a new issue after already closing their new issue. :P haha

shrug I was talking to @rcorrie, who bumped this closed issue.

I understand. I didn't mean to point out or anything, i just wanted to share a laugh :P I know thats from your boss, he tells you to close things. You do amazing work in bring RN to us, thanks @hramos!


Envoy v1.20.0 slower to re-initialize dynamic listeners

Description:
It appears Envoy v1.20.0 is a bit slower to re-initialize dynamic listeners for which configuration has changed.
As part of regular dependency bumps, when bumping Contour's dependency on Envoy from v1.19.1 to v1.20.0 (see PR) we have seen our end-to-end tests fail/take quite a lot longer to run to completion. These test repeatedly create/delete k8s Ingress/Contour HTTPProxy/Gateway API *Route objects that the Contour controller programs Envoy dynamically with over xDS. The tests update these k8s resources and then assert requests to Envoy succeed. We've seen the time taken for requests to succeed when config is updated increase substantially when bumping to v1.20.0 with the same Contour controller code.
With a git bisect of commits betwen v1.19.0 and v1.20.0, it seems that we can narrow this slowdown to this commit that for one changes the default for Envoy to use the SO_REUSPORT socket option but also changes how listener updates work. Granted this is not the most exact/minimal test case but it appears this commit might be related.
Repro steps:
I can try to work up a smaller repro but for now, running the Contour e2e tests has been how we have experimented, capturing logs and fiddling with timeouts etc.:

Clone https://github.com/projectcontour/contour
Ensure Docker, kind, go, and ginkgo are installed
Run make e2e
Note run time of test suites
Update Envoy image to v1.20.0 here
Re-run make e2e
Note increased run time of test suites/failures

Theories/mitigations

We are using the default Go HTTP client in tests and logging request errors in our test suite we see TLS handshake timeout errors for HTTPS requests/plain HTTP requests hang forever (Go default client has no request timeout, oops on our part using that!)
It appears the updated listener update/worker logic holds open connections that never succeed, maybe as part of what is described in the linked change in the effort to not drop connections on draining listeners
In the Contour tests, we can mitigate slowdowns by adding more strict timeouts to HTTP requests, though we still see listener updates as much slower anecdotally

We are seeing the same in Istio. Essentially it looks like when a listener drains, some (maybe 50%, but I didn't get a large sample size to say exactly 50/50) hang. netstat shows them stuck in Recv-Q.
Suspecting the reuseport stuff, we disabled it via runtime flag. When we did this, we got a different error - NACKs from address already in use.
cc @mattklein123 @lambdai

Suspecting the reuseport stuff, we disabled it via runtime flag. When we did this, we got a different error - NACKs from address already in use.

Same for Contour

The underlying expectation is that kernel should requeue the socket of the dying passive socket(old listener) to another passive socket(new listener). What's importantly, the libevent should somehow be notified and wake 1+ worker thread.

Unfortunately this is not the way it works. Sockets are not re-queued. A lot of care was put into make sure that we don't wind up with dead socks that are never accepted, and I'm surprised to hear this is happening. I'm happy to look into this if we can come up with a more self contained repro?

a more self contained repro

working on something smaller, was able to get a little spike to do what is happening with Contour, but now its not reproducible  😅

I transfer the ownership of listen socket factory to the in place updated new listener, all looks good until I hit the case updating an updating listener. Still fixing...

OK lmk if you need help fixing. Just ping me on Slack.


Voxel picking

Description
This PR implements picking of individual cells from a VoxelPrimitive.
The new method Scene.pickVoxel returns an instance of the new class VoxelCell. The VoxelCell instance exposes getters that report information about the voxel rendered at the cursor position.
See the previous staging PRs:

#11754
#11784
#11800

Issue number and link

Testing plan

Make sure specs run through locally (some use a no-op matcher on CI)
Load this local Sandcastle and verify that mouseover picking works and is performant.

Author checklist

[x] I have submitted a Contributor License Agreement
[x] I have added my name to CONTRIBUTORS.md
[x] I have updated CHANGES.md with a short summary of my change
[x] I have added or updated unit tests to ensure consistent code coverage
[x] I have update the inline documentation, and included code examples where relevant
[x] I have performed a self-review of my code

Many of the properties of the FragmentInput struct for a voxel CustomShader are undocumented, including two new properties tileIndex and sampleIndex added in this PR.
However, rather than documenting them separately, I think it would be a similar level of effort to rework the struct to be consistent with the already-documented FragmentInput struct used for Cesium3DTileset and Model.
Either way, I think it may be out of scope for this PR. I opened https://github.com/CesiumGS/cesium/issues/11832 to discuss further.

I added a local Sandcastle for testing. This should be ready for final review.

@jjhembd Should the Sandcastle example you have in your comment be added as a developer Sandcastle?

@jjhembd I'm seeing some flickering when picking. Any idea what may be causing it?
https://github.com/CesiumGS/cesium/assets/4439461/5caae909-72a2-4884-9084-9bed692e87a9

Thanks for the feedback @ggetz. I addressed everything except the flickering.
I agree the flickering looks wrong. Unfortunately I'm not able to reproduce it on my machine. Perhaps we should leave that as a separate issue?

@jjhembd Sure, OK to open as a separate issue, though sometime soon we'll need to understand how often it arises ion order to prioritize.

See https://github.com/CesiumGS/cesium/issues/11841 for the flickering issue


Added a note on Insights query API

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)
DOC-2255

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-338

Preview environment: https://ci.pr.harness.io/pr-338

Incorporated review comments by @michaelcretzman


Package Request: Fantomas

Project description
FSharp source code formatter. It's the last piece needed to use Ionide on VSCode.

I already tried to package it, however I'm facing an error:
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/zsfnm3a90nyi3vzaj5nn1dallh2myfz6-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
  Determining projects to restore...
  Restored /build/source/src/Fantomas/Fantomas.fsproj (in 334 ms).
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Microsoft (R) Build Engine version 16.11.2+f32259642 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

/build/source/src/Fantomas/Fantomas.fsproj(43,3): error MSB4019: The imported proj>

Build FAILED.

/build/source/src/Fantomas/Fantomas.fsproj(43,3): error MSB4019: The imported proj>
    0 Warning(s)
    1 Error(s)

This is the code I've been trying to run:
# default.nix
buildDotnetModule rec {
  pname = "fantomas";
  version = "4.6.0";

  src = fetchFromGitHub {
    owner = "fsprojects";
    repo = pname;
    rev = "v${version}";
    sha256 = "sha256-TFX5a4tgSnbPAirXaClezvC4+6uLrgVkiWk+O+TTlpw=";
  };

  projectFile = "src/Fantomas/Fantomas.fsproj";
  nugetDeps = ./deps.nix;

  meta = with lib; {
    description = "FSharp source code formatter.";
    homepage = "https://fsprojects.github.io/fantomas-tools/";
    license = licenses.asl20;
    maintainers = with maintainers; [ ratsclub ];
  };
}

---
# deps.nix
{ fetchNuGet }: [
  (fetchNuGet { pname = "FSharp.Core"; version = "5.0.0"; sha256 = "10qjk9rc950prnf7m8lndcr1qxihz4jcwzfrz8q7m5997h3zx28x"; })
  (fetchNuGet { pname = "Microsoft.NETCore.Platforms"; version = "1.1.0"; sha256 = "08vh1r12g6ykjygq5d3vq09zylgb84l63k49jc4v8faw9g93iqqm"; })
  (fetchNuGet { pname = "NETStandard.Library"; version = "2.0.3"; sha256 = "1fn9fxppfcg4jgypp2pmrpr6awl3qz1xmnri0cygpkwvyx27df1y"; })
]

Would you be able to give me a little help? @IvarWithoutBones

It seems like we need a paket2nix of some sort. I'll see if I can do something about it.

I guess that it's better to wait for some activity on this end: https://github.com/fsprojects/Paket/issues/4093


Error after yarn install

An unexpected error occurred: "https://stg-gke-eu.voxeet.net/nexus/repository/npm-group/moment/-/moment-2.26.0.tgz: Request failed "401 Unauthorized"".

anas-mac-pro:code anasahmar$ cd voxeet-uxkit-web-mixerlayout/
anas-mac-pro:voxeet-uxkit-web-mixerlayout anasahmar$ yarn install
yarn install v1.10.1
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error An unexpected error occurred: "https://stg-gke-eu.voxeet.net/nexus/repository/npm-group/moment/-/moment-2.26.0.tgz: Request failed \"401 Unauthorized\"".
info If you think this is a bug, please open a bug report with the information provided in "/Users/anasahmar/code/voxeet-uxkit-web-mixerlayout/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

The yarn.lock file was pushed with the wrong configuration, it will be removed soon but to unblock more quickly just delete the yarn.lock file and run yarn install again


Add @ku.th

Kasetsart University's new Google Apps mail service

@benwrk The similar request is already merged. Next time please do not forget .txt in the filename (see https://github.com/JetBrains/swot/pull/1703 for a good reference). I am closing this request. Thank you!


UADetect 2.0 Main PR

This is the main PR for UADetect 2.0.0. Feel free to contribute, but all other branches MUST merge into this one before the final merge into "mega"

I added the housekeeping branch to merge into this with the new docs ( #3 )


Find Support

See:
http://doc.qt.io/qt-4.8/qwebview.html#findText
http://stackoverflow.com/questions/22837073/qwebviewfindtext-qt-c-example
http://stackoverflow.com/questions/29126537/qwebview-find-text-inside-invisible-elements
http://www.qtcentre.org/threads/55195-find-text-with-regexp-in-qwebview-highlight
http://stackoverflow.com/questions/2940232/qwebview-is-it-possible-to-highlight-terms-and-do-keyboard-navigation

basic finding is done.


refactor: refactored did management component

Fixes #976
Desktop:

Mobile:

Signed-off-by: Anton Biriukov<EMAIL_ADDRESS>

You would need to squash the commits @birtony

After discussion with @sudeshrshetty, we created https://github.com/trustbloc/wallet/issues/993 as a follow-up task


Add Polish translation

sorry, I missed this pull request.
Merged. http://waifu2x.udp.jp/

sorry, I missed this pull request.
Merged. http://waifu2x.udp.jp/


Fix bug when job callback is triggered in web server and job node is …

…running in flow2.0 & under embeded flows
When using projectManager.getJobOverrideProperty or projectManager.getProperties, the flow should be the direct parent flow of node instead of ancestor flow of the node in flow2.0.

Pull Request Test Coverage Report for Build 6936

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 45.354%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-common/src/main/java/azkaban/executor/ExecutionControllerUtils.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/executor/ExecutableFlowBase.java
1
87.71%

azkaban-exec-server/src/main/java/azkaban/execapp/event/FlowWatcher.java
1
93.75%

Totals

Change from base Build 6935:
0.0%

Covered Lines:
18136

Relevant Lines:
39988

💛  - Coveralls


Fix flaky tests fail_percent

fail_percent for flakes from master (checked against PR runs) should include the total number of jobs.
Consider also calculating it over a sliding window, that is, for every week, calculate frequencies over this and last one or two weeks.
Consider adding a count with time decay, as count ^ 1/(current_date-last_seen_date)

Done in 4d107485b014381f710cb00382883814e51f4365


add shortcuts and formatting guide to docs

Added a short doc on keyboard shortcuts and formatting to the docs directory - still currently has the  tags, though not sure if they'll show correctly on Github or not.

Thanks so much for taking the time to put this together!


DEtection TRansformer with Faster-RCNN on VOC dataset

homework.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

请问DETR可以和faster-rcnn结合吗


mesa: 21.3.5 -> 21.3.6

Motivation for this change
Notes: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14505 is now merged and backported via https://gitlab.freedesktop.org/mesa/mesa/-/commit/9b50b320d1db19c8c00be0e5476ef58c55db6e49 (required for https://github.com/NixOS/nixpkgs/issues/153377).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg test tinywl sway

Note: master..staging-next is empty right now.

@vcunat sorry, I'm still too unfamiliar with our staging process to properly understand all of the implications.
Does that mean I should target staging instead (or wait for a PR to merge staging-next back into master (as staging was merged into staging-next at that point)) to avoid causing unnecessary rebuilds on staging-next (simplified summary)?

TL;DR: I simply retargeted it, as I expect it's to be merged very soon – before the next cycle starts. (the bump looks ready to me, though I haven't tested it)
Longer explanation:

merges master -> staging-next -> staging happen automatically ever 6 hours (if conflict-less)
the rest is manual
actually we have a nice diagram in the manual: https://nixos.org/manual/nixpkgs/unstable/#idm140737315051616

@vcunat thank you for the reply. My question was why it's a problem to merge this into staging-next instead of staging. That part isn't clear to me yet. From the workflow (that part I do know based on the manual and RFC) it should be no problem (it'll automatically land in staging and also manually in master after the next staging-next -> master PR). So my assumption was that staging is preferred if there's no staging-next PR yet as merging it would cause 1001-2500 rebuilds after the next staging-next evaluation but all of them will likely have to be repeated for the next staging-next PR as staging will get merged into staging-next. Is that the reason or am I missing something else?

Yes, Hydra would start those useless rebuilds.


Fix linting errors

Tests are failing for me locally, pushing to see if it somehow works on Travis

Badges diff:
Old:

New:

Ok, passes on Travis. The instructions for psql need an update in the readme then, this happens for me locally after following them:


Fix import dependency loop

At the moment, forNode (dispatch wrapper) refers to Considered (namespace) which refers to Array (node type) which refers to forNode.
While the JS version of this project used an import that was robust against this kind of thing, the one that Typescript uses isn't, so:

array.ts compile starts
for-node.ts import starts
for-node.ts loads in-progress file array.ts
Undefined returned
for-node.ts loads other files (successful)
forNode now does not contain Array

Need a sane way of working around this

JS version actually uses var rather than const to make sure references are updated in-place. The negative of this is that it has never had the correct (unwritable) semantics

Mutual reference between for-node and array is essentially unavoidable.

Less of a mess if they are self-registering?

IOW, throwing away "export" for this.

Plugin style has done the job here


Unskip Roslyn excerpt tests.

Going to run this a few times in the PR to see if things are less flakey.

aspnet/AspNetCore#7768

when youre confident it's passing. I think we have a repeat attribute you can deploy.

Tried using it but looks like it only operates via the FlakyTest attribute in AspNetCore. Will just wrap these method bodies in for loops

Tried using it but looks like it only operates via the FlakyTest attribute in AspNetCore. Will just wrap these method bodies in for loops

lol still fails locally after running them 50 times in a loop. Still blocked.


Not attempt to read from fd when channel is closed during read loop. …

…Related to [#5031]
Motivation:
We need to break out of the read loop for two reasons:

If the input was shutdown in between (which may be the case when the user did it in the
fireChannelRead(...) method we should not try to read again to not produce any
miss-leading exceptions.

If the user closes the channel we need to ensure we not try to read from it again as
the filedescriptor may be re-used already by the OS if the system is handling a lot of
concurrent connections and so needs a lot of filedescriptors. If not do this we risk
reading data from a filedescriptor that belongs to another socket then the socket that
was "wrapped" by this Channel implementation.

Modification:
Break the reading loop if the input was shutdown from within the channelRead(...) method.
Result:
No more meaningless exceptions and no risk to read data from wrong socket after the original was closed.

@trustin PTAL

Cherry-picked into 4.0 (900db0acff95cc8c6334180024ad6d3ab12f220f) and 4.1 (4950a523a77f920134a47175322578895a48e918)


Process OTLP metrics

Addresses parts of #1163

This PR is somewhat stale, and was intended to further reduce the footprint of metrics collection, but in reality this doesn't matter.


Relation between intents and entities

Rasa NLU version 0.11.3
Used backend / pipeline mitie with sklearn
Operating system (ubuntu):
I have noticed that the intent classifier is trained then the entities classifier is trained, but there may be a correlation/relation between some intents and entities, how is this case handled if both are trained separately?

Currently, they are separate classifiers that do not share any information. More discussion about that can be found here #732


Log query text for POST requests

Currently, the HTTP handler for /query logs query text for GET requests but not for POST. The handler should be changed to log query text for both.

Hey, I'd like to contribute to this issue. There are any points that I have to know before tackling this issue?

Proposed new format for POST:
2021-03-18T01:48:38.057192Z	info	Executing query	{"log_id": "0SxlABN0000", "service": "query", "query": "SELECT * FROM TestData.autogen.a"}
[httpd] <IP_ADDRESS> - - [17/Mar/2021:18:48:38 -0700] "POST /query?pretty=true HTTP/1.1" {"db": "[TestData]", "q": "[SELECT * FROM a]"} 200 1217 "-" "curl/7.68.0" 0eedc737-878c-11eb-8001-002b67685b12 1349


Add CI status badge and filter build runs

Add CI status badge and filter build runs
Describe your change:
This PR does various small things:

reflect the current CI status coming from Github Actions in the README
filter when the CI pipeline is run
simplify PR template structure

Checklist
Pull Request

[x] PR description is meaningful.
[x] There are no more than a few commits to merge.
[x] There are no more than a few lines of code to review.

Code style

[x] Maximum line length does not require horizontal scrolling in Github
[x] Compliant to FMT, ScalaStyle and ScalaFix

Testing

[ ] Unit tests for the added/modified code
[x] Overall unit test coverage good
[x] Unit tests are passing

Dependencies

[x] The safety plugin is happy
[ ] New dependencies do not have vulnerabilities

Security

[x] There is no known vulnerability being added to this project
[ ] Everything on this list is checked

@leobenkel I'm wasn't sure if it is better to exclude what we don't want or trigger on what we want. I went with the former.
As for the PR template - I feel that GIthub's frontend already caters for titles, hence I removed the duplication.
Feel free to disagree with the suggestions :)


10% boost for Zul-andra teleports when killing Zulrah

Unsure if this was the best way to do it, I couldn't see any examples of consumableCosts to speed up kills that were optional. Happy to re-write if an example can be provided.
Description:
Added in a case for using zul-andra teleports to speed up Zulrah kills. Only used if there are enough to cover all kills. 10% was found from 25s of travel time (house/quest cape -> fairy ring) compared to 1s from teleport.
Changes:
Added clause in k.ts to check if the target monster is Zulrah and if the user has enough teleports to cover the kills.
Other checks:

[x] I have tested all my changes thoroughly.

Needs more thought about values and optional usage before merging.


malware

https://www.virustotal.com/gui/file/3812bd0c72e8e2e58b73aeda2c03b7758290320fb64da57cfdb036bf0ef21ae5/detection

This is likely a false positive, as the code contains no malicious code and is freely available to view and build yourself.


heat maps vs. confidence maps

How to visualize heat maps vs. confidence maps

Hi! Heatmap and confidence map is the same thing. You can call cv2.imshow directly with heatmap array or normalize it to 0-1 range before.

You may follow #235 thread, it has such code for visualization.


How to retry call with interceptors mechanism?

In wiki says "Interceptors are a powerful mechanism that can monitor, rewrite, and retry calls". How I can retry call if I receive json like a {"status":2,"response":""}? Where status == 2 means un unready response.

After parsing the result, just call chain.proceed() again with the same, updated, or completely new request.

Thanks. But I have another problem with parsing status in interceptor. I have interceptor:
private static Interceptor statusInterceptor = new Interceptor() {
        @Override
        public com.squareup.okhttp.Response intercept(Chain chain) throws IOException {

            com.squareup.okhttp.Response originalResponse = chain.proceed(chain.request());
            if (originalResponse.code() == HttpURLConnection.HTTP_OK) {
                ObjectMapper objectMapper = new ObjectMapper();
                JsonNode jsonNode = objectMapper.readTree(originalResponse.body().charStream());
                if (jsonNode.get("status").asInt() == 2) {
                    // handling
            return originalResponse;
        }
    };

and I receive exception in objectMapper.readTree():
01-16 11:34:31.911    2097-2119/ru.gnivc.lkip D/Retrofit﹕ java.io.IOException: closed
            at okio.RealBufferedSource$1.read(RealBufferedSource.java:294)
            at java.io.InputStream.read(InputStream.java:162)
            at retrofit.Utils.streamToBytes(Utils.java:43)
            at retrofit.Utils.readBodyToBytesIfNecessary(Utils.java:81)
            at retrofit.RestAdapter.logAndReplaceResponse(RestAdapter.java:483)
            at retrofit.RestAdapter.access$500(RestAdapter.java:107)
            at retrofit.RestAdapter$RestHandler.invokeRequest(RestAdapter.java:338)
            at retrofit.RestAdapter$RestHandler.access$100(RestAdapter.java:220)
            at retrofit.RestAdapter$RestHandler$2.obtainResponse(RestAdapter.java:278)
            at retrofit.CallbackRunnable.run(CallbackRunnable.java:42)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at retrofit.Platform$Android$2$1.run(Platform.java:142)
            at java.lang.Thread.run(Thread.java:841)
01-16 11:34:31.911    2097-2119/ru.gnivc.lkip D/Retrofit﹕ ---- END ERROR

Our server send response successfuly and don't close connection.

Main problem is this IOException throwed by ResponseBody methods produce RetrofitError. But this is not error case, I am able to read status. How I can supress this IOException?

Your interceptor is consuming the response body stream. You can't do this without providing a new response body for Retrofit to consume.

return originalResponse.newBuilder().build();

Right?

You need to create a new body. Mostly likely with a cloned or copied Buffer which was created from buffering the initial response so you could parse it.

Buffer buffer = new Buffer();
buffer.writeAll(originalResponse.body().source());

ObjectMapper objectMapper = new ObjectMapper();
JsonNode jsonNode = objectMapper.readTree(responseBuffer.inputStream());

It works. Thanks!

how retry will be handled when two api call come at same time

@JakeWharton  if i try to chain.proceed(request) again i get:
Suppressed: java.lang.IllegalStateException: network interceptor must call proceed() exactly once
https://stackoverflow.com/questions/69063298/retrofit-how-do-i-retry-the-request-again-from-okhttp-interceptor

@shahwaiz90 The key words in the sentence are "network interceptor"
https://square.github.io/okhttp/interceptors/

Application interceptors
Permitted to short-circuit and not call Chain.proceed().
Permitted to retry and make multiple calls to Chain.proceed().

Thanks, i was eventually able to make a request again with this line:
chain.call().clone().execute()


Support downloading enrichment tables from a web server

Currently we are supporting downloading enrichment tables from hdfs only. It can be interesting to remove this deployment dependency and allows to download tables from web server too.

Closed in Upgrading java modules to java 11 #405


fix bug #192, oss-fuzz/9827 : MemorySanitizer:DEADLYSIGNAL

==4908==ERROR: MemorySanitizer: SEGV on unknown address 0x730fffffffff (pc 0x0000004b1b97 bp 0x7ffd4bf59a00 sp 0x7ffd4bf598a0 T4908)
==4908==The signal is caused by a READ memory access.
#0 0x5a0599 in fizzle_matches zlib-ng/deflate_medium.c:168:12
#1 0x59ea27 in deflate_medium zlib-ng/deflate_medium.c:296:21
#2 0x5901c5 in zng_deflate zlib-ng/deflate.c:951:18
#3 0x586955 in zng_compress2 zlib-ng/compress.c:59:15
#4 0x5861eb in LLVMFuzzerTestOneInput zlib-ng/test/fuzz/compress_fuzzer.c:18:3
#5 0x4e9b48 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:575:15
#6 0x4a2f66 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/libfuzzer/FuzzerDriver.cpp:280:6
#7 0x4b3adb in fuzzer::FuzzerDriver(int*, char***, int ()(unsigned char const, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:715:9
#8 0x4a2091 in main /src/libfuzzer/FuzzerMain.cpp:20:10
#9 0x7fa3d7ff582f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/libc-start.c:291
#10 0x41ec68 in _start

Looks good and passes my tests


ARROW-18098 [C++] Vector kernel for "intersecting" two arrays

@jorisvandenbossche
I've commented out a few things that aren't yet working, which I'd summarize as:

Null Handling - by default numpy's intersect1d discards NaN, but here NULL would be returned. Its worth discussing whether we want NULL to be included here or not; I think we should and give the user the ability to control where it appears via SortOptions
Boolean Type - had issues with the call to Buffer::Wrap complaining that the const qualifer on the vector was being discarded. Didn't fully troubleshoot this, but wasn't sure an intersect on BooleanTypes is all that useful either
Temporal Types - got a segfault that I need to trouble shoot.

There likely is a better way of constructing the result that could naturally solve issues 2 and 3 above.

Putting aside for now - will come back later


Add flavor menu blog post

https://github.com/user-attachments/assets/6bc5ea5d-cf70-43fe-8337-9b59cb86e6fd
https://github.com/user-attachments/assets/9f479030-dce7-4712-a2b0-596b984a7c37

I'd like to upload the videos to the youtube channel because it makes it easier to share but I don't have access yet


Error in installaing (Failed to detect the version of Linux)

When I run the install.sh script i get the following error:
root@test:#tools/install.sh
Failed to detect the version of Linux
This installer only supports the following Linux distributions:

BackBox
CentOS
Debian
Fedora
Kali
Red Hat
Ubuntu
Arch

If the current version of Linux is one of these flavors but it is
not recognized, please open a support ticket and include the version.
Here is the output to show OS version:
root@test:# cat /etc/issue
Debian GNU/Linux buster/sid \n \l
root@test:# uname -a
Linux labman 4.9.0-5-amd64 #1 SMP Debian 4.9.65-3+deb9u2 (2018-01-04) x86_64 GNU/Linux

From the out put of /etc/issue you are running a none standard version of Debian. King Phisher only supports the operating systems here.
Please note that it is only the current versions are supported, as buster is in testing and is not in stable release yet King Phisher does not currently support it.


Gene accession id not recognized.

Thank you for publishing this tool. In principle it could be very useful for my research. However,
I'm not able to get it to work. Every protein I put in gives the 'Attention: please check the gene accession id!' error
When I try to run the programme with the example fasta file without the pregenerated blast file I get the following error:
This is gene 1------------------
AAT92670
Traceback (most recent call last):
File "/Users/marijn/HGTphyloDetect/example/HGT_workflow.py", line 212, in
main()
File "/Users/marijn/HGTphyloDetect/example/HGT_workflow.py", line 114, in main
for accession in accession_number[:200] :
UnboundLocalError: local variable 'accession_number' referenced before assignment.
Other proteins I tried are for example Q1DFT5 and Q50900, these give the 'Attention: please check the gene accession id!' error.
Do you know how to solve this issue?
Thank you in advance!

Thanks for trying our computational tool.
If you try to run the programme with the example fasta file without the pre-generated blast file, then one error was out shown as above. After checking the logs, I think: 1) Firstly, you can check whether the blast file was generated after running this program although one error was out. If there exist such a blast file, it means that the code before line 114 has no any issues and blastp has been run normally for the case. 2) If there exist such a blast file, but one error occurs like that, then you can add one line accession_number,evalue = parse_NCBI(gene) in line 89 after line 88 os.system(myCmd) with the same identification.
For our second issue, you are now trying Q1DFT5 and Q50900, it looks like that these two proteins are Uniprot ID. However, the program now only supports gene/protein ID from the GeneBank database. But in the next version, we will also try to integrate the Uniprot ID.
Thank you!
Best regards,
Le


Update the protocol with a general purpose header string maps

Base for https://issues.redhat.com/browse/ISPN-13725

Thanks for the review @pruivo. Changed it!

Integrate into #10196 closing it


fix pod manifest

What does this PR do?
Fix a bug introduced by https://github.com/DataDog/datadog-agent/pull/23823
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Add SettingsLayout to Groovy DSL doc

Also:

tweak javadoc for SettingsLayout
fix service scope for SettingsLayout

Issue: #16506

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Cookie path is hardcoded to / limiting to one use the -cookie-domain field.

When installed multiple instances of oauth-proxy in the same k8s cluster, for example one instance for dev and a second one for qa purposes, the cookies generated for the two instances will have the same Domain yourcompany.com. The browser will submit both cookies with different names, given by the -cookie-name parameter.
Scale this with multiple instances used for various purposes, the cookie size increases unnecessary breaking the nginx proxy default configuration.
Expected Behavior
The configuration of the cookie being generated by one oauth-proxy instance should allow enough flexibility for the cookie to take into consideration the domain and path, standard attributes of the cookie.
In the scenario described above, the cookie generated by the dev instance of the proxy should have Domain yourcompany.com and Path /dev while the one for the qa instance should have Domain yourcompany.com and Path /qa. Thus, only the correct cookie generated by the oauth-proxy instance is being sent by the browser.

Current Behavior
Multiple cookies are being sent to the oauth-proxy instance increasing the header size, breaking the nginx proxy configuration.
The current implementation is hardcoding the Path to / thus removing the Cookie's flexibility to be specific for one path.
    return &http.Cookie{
        Name:     name,
        Value:    value,
        Path:     "/",
        Domain:   p.CookieDomain,
        HttpOnly: p.CookieHTTPOnly,
        Secure:   p.CookieSecure,
        Expires:  now.Add(expiration),
    }

Possible Solution
Expose the standard Path attribute as oauth-proxy configuration parameter under -cookie-path to allow customisation of the Cookie's standard attribute. If left empty, then the Path should be defaulted to / as it is now.

Steps to Reproduce (for bugs)

Install oauth-proxy instance to k8s cluster for the dev environment under -proxy-prefix=/dev/oauth,
Install oauth-proxy instance to k8s cluster for the qa environment under -proxy-prefix=/qa/oauth,
Invoke an application secured by the qa proxy. Check for the cookies being sent by the browser,
Both cookies are being sent not only the qa one. There is no way to configure the cookie with the current implementation.

Context

Your Environment

Version used: 3.1.0

I will create a PR with the solution proposed in the description, creating a new config optional parameter called -cookie-path , defaulted value being set to / , allowing the Path attribute of the Cookie to be configured.

This was fixed in #122


Using pyBaMM for modeling supercapacitors

I am interested in modeling a supercapacitor whose cyclic voltammetry is as follows:

I am able to capture the overall shape with a simple heat equation and effective properties through Bruggeman, but the bottom slanted line remains elusive. I have been told that it could be due to side reactions or leakage resistance. Can pyBaMM be applied for this type of models? Apologies if this is not the right place for user questions.

I am not hugely familiar with cyclic voltammetry but it sounds doable. How do you solve the model (or perform the experiment) to generate the above plot? Just a triangular current profile?

Sorry I should have added details on that. A cyclic voltammetry is simple an applied voltage that increases/decreases with time until a certain threshold/zero voltage is reached and then repeat. So yes, a triangular current profile.

Any ideas of what do add to the modeling equations to capture the bottom slanted line? My current modeling equation is

where $\kappa$ is the conductivity in the electrode, $\phi$ is the potential and $a C_{D L}$ is the capacitance times specific area.

Would be great to have a special Experiment called CyclicVoltammetry which automatically solves the model with this voltage profile. Then you can test out the different models in pybamm (which are all a fair bit more complex than the simple parabolic equation you have) to see if any give you the slanted line. I don't have enough intuition with these plots to know what the effect is off the top of my head

I am not super familiar with supercapacitors, but aren't they sometimes modelled similarly to batteries, just with an additional capacitance term which, for supercaps, is dominant?

I use pybamm to model cyclic voltammetry and other similar input voltage waveforms (like Fourier transformed large amplitude AC voltammetry). A special Experiment class for cyclic voltammetry would be useful. For the moment I just write the equation directly, in which case specifying the voltage input term is straightforward, for example:
Edc_forward = -pybamm.t
Edc_backwards = pybamm.t - 2*t_reverse
Eapp = E_start + \
    (pybamm.t <= t_reverse) * Edc_forward + \
    (pybamm.t > t_reverse) * Edc_backwards


Add Crowbar as Item for Ducks

can you further explain what needs to be done here?
i would like to help with this project

new developer trying to get some open-source work under my belt

Hey @S0han, sorry for the late reply. It's really up to you with how you want to go about this. But, the final result should be an SVG file with a 200x200 size that follows these rules.


[Rosetta] Replace new line with space instead of empty string in GraphQL

This pull request replaces new line characters with spaces instead of empty strings in Rosetta's GraphQL client. This change ensures that the resulting string does not contain any newline characters and that words are separated by a space, thus fixing an existing issue where some words were wrongfully joined.

!ci-nightly-me

!ci-build-me


Fill deprecated permissions info

Hi @adesnos ,
In this PR I try to fill in details about the permissions that were deprecated in the used TargetSDK, but not in the MinSDK.
Example 22c17f521f68553a157dfb161af5915bf402806f250515c60a74fc9a1fbebea6.

MinSDK: 15
TargetSDK: 27

This apk has permissions like android.permission.WRITE_SMS or android.permission.PACKAGE_USAGE_STATS which are deprecated in the SDK 27 but not in SDK 15.
With this change we fill in the missing details.
For permission android.permission.WRITE_SMS:
Before:

full_description: ""
permission_type": "normal"
short_description: ""

After:

full_description: "Allows application to write\n      to SMS messages stored on your phone or SIM card. Malicious applications\n      may delete your messages."
permission_type: "dangerous"
short_description: "edit SMS or MMS"

Fixed _fill_deprecated_permissions

Nice !!!


Add a necessary condition "working in small batches"

Is your proposed change related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I don't agree with[...]
=> Working in small batches is described as a necessary condition to continuous integration and trunk-based development in DORA research and Accelerate (see https://cloud.google.com/architecture/devops/devops-process-working-in-small-batches)
Describe the solution you'd like
A clear and concise description of what you want to happen.
=> Add an item "Working in small batches" in the list of minimum activities for CI
=> Eventually add it also for the list of minimum activities for CD
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
=> Mention the importance of working in small batches in the introductory text

Duplicate of issue https://github.com/Minimum-CD/cd-manifesto/issues/132.


Certain application errors will now notify the user with a notification.

Fix for #490
========
Some application functionality was silently failing instead of letting the user know what failed and why. Added some error handling that will create a notification with information about the error.

Pull Request Test Coverage Report for Build 77

22 of 32 (68.75%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 39.257%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/app/client/src/commands/emulatorCommands.ts
2
5
40.0%

packages/app/main/src/protocolHandler.ts
2
5
40.0%

packages/app/client/src/ui/helpers/activeBotHelper.ts
18
22
81.82%

Totals

Change from base Build 67:
0.06%

Covered Lines:
2556

Relevant Lines:
4842

💛  - Coveralls


Fix persistence of received share update #3747

Update the model before persisting it.
Fixes https://github.com/cs3org/reva/issues/3747

Great! I'll try it out
CC @mahdibaghbani


Add documentation for DATE, SIN and PV functions

Please have a look at serial-numbers.md, which is linked from the Overview section of DATE.md.

Are we happy with where I have located the serial-numbers.md file in the folder structure?
How could I get useful previous and next page links at the bottom of the Serial Numbers page?

Need to apply comments from #169 before merge.

Closed this PR which will, in due course, be replaced by other PRs to update the descriptions for these three functions.


Added necessary changes to migrate from 2.x to 3.0.0 in UPGRADE.md

added changes that need to be made to migrate from 2.x to 3.0.0 (namely to rename two static codes)

Thanks for contributing