Handle OS errors gracefully

Closes #1795
Introduced changes

Handle OS errors gracefully

Checklist

[x] Linked relevant issue
[x] Updated relevant documentation
[x] Added relevant tests
[x] Performed self-review of the code
[x] Added changes to CHANGELOG.md

Panics in ForkCache::save are not changed due to the fact it's called on drop and there is no way to propagate errors

Panics in ForkCache::save are not changed due to the fact it's called on drop and there is no way to propagate errors

We can change the logic there if it's required for errors to bubble. It's not necessary to have it on drop

Panics in ForkCache::save are not changed due to the fact it's called on drop and there is no way to propagate errors

We can change the logic there if it's required for errors to bubble. It's not necessary to have it on drop

But then it's easy to forget calling save(). Either propagate or check if saved by compiler


Possible typo in Documentation

In the use-with-fastapi-security guide,
it is implemented to redirect to url="/prot" in the /auth/logout/ endpoint function,
If the intention is to show that access to pages that require authentication fails after logging out, shouldn't it be redirected to url="/protected"?
@app.get("/auth/logout")
async def logout():
    """Forget the user's session."""
    response = RedirectResponse(url="/prot")
    response.delete_cookie(key="token")
    return response

Hi @libera826! Thanks for that, that's a good catch, it will be fun to try git blame and see who did it. It was me, already know it was me. 😁 I'll fix it in a minute.


Issues with Z level

Since the last update, I'm having troubles walking on some points, or even teleporting.
It happens on multis and statics.
Here you have some footage about the issue:
First gif, I used .fix.
https://i.imgur.com/dtTL8Z5.gifv
Second gif, just teleport.
https://i.imgur.com/ftcUar4.gifv
It's related to the fix of npcs with mt_swim not able to walk on water.

NOTE: Unable to reproduce with player account. Only when .GM is enabled.

Confirmed , as a GM when going through teleporters my chars z level seems to go to the base terrain. or teleporting onto a roof I end up at the ground z level for the terrain and not the statics on top.

teleport to player via admin menu same problem - falling tru the floor, but players stay in this point fine

Confirmed. Also my sphere crashed once i tried teleport as a GM on player via admin menu. No errors or anything.

players falling tru the stairs now

confirmed they get stuck in stairs and can't walk up them.

Seems fixed in the latest version you sent in the x-branch channel at 6:15 am on April 2, 2019

This is fixed in the debug/nightly builds over discord.
Closing it as the commit comes soon.


[feat] Refactor dialogs to mobile first

Refactor dialogs - settings and add patient to be more mobile friendly, probable left panes or bottom dynamic panes (?)

Partially done as for Settings dialog, yet to come for New Patient Dialog


Manually specified priorites for sorting

Is your feature request related to a problem? Please describe.
I've just found this card and it's creating some amazingly clear charts, however I did struggle a little with sorting to ensure the chart always looks aesthetically pleasing, functional and avoiding unnecessary crossovers.
Describe the solution you'd like
The current sort parameters work well enough, but don't give exact control of ordering.
For example, if I have a Power point circuit, and a bunch of devices on that power point circuit, the sort works nicely by organising them highest power to lowest which works well.
However I'd then have a catchall entity representing any un-monitored usage, and I might want that always on the right as a convention so I always know where the "other" usage is.
Or if I have a particular order in mind for a section, it may be easiest to simply number the entities in the appropriate order to explicitly control the order.
This could be handled relatively easily with a "sort_priority" parameter for each entity. If two entities have the same priority then regular sort rules apply, and the sort_priority would default to 0.
So for the example of "sort all devices normally, but with the catch-all last", something like this would work well:
  - entities:
    - entity_id: device_1
      type: entity
      sort_priority: 0 // the default value
    - entity_id: device_2
      type: entity
    - type: remaining_parent_state
      entity_id: other_usage
      sort_priority: 1

Or to explicitly order a section you'd just set sort_priority as 1, 2, 3, etc... as desired.
I haven't checked the relevant sort code yet, but rather than just sorting as per the existing sort rules, it could be broken in to two steps, first sort by sort_priority, then inside each group of entities with the same sort_priority then follow the existing rules.
Describe alternatives you've considered
Looking over the examples and documentation, I don't see any currently existing alternative way to get better control over sorting, however I may have missed it.

Just for further context, what I'd hope to avoid is this:

Due to how I've got it set up, if the grid (red, top) is always sorted first (lower priority), and the house (blue) is sorted last (higher priority) then it would be impossible for unnecessary waviness when there's many values that are close together jumping around.

I see your point but TBH I don't want to complicate this even more. This is why I don't use sorting myself.
I added sorting based on requests, then I had to add sort_by_parent. Your chart has overlapping parents so even that option is not enough.
I hate adding more complexity and the card is already too complicated for most people and maintenance is hard.
At this point I would advise to just not use sorting or only use it in the last section with sort by parent.

No worries, that's understandable. :)
It'll be a bit more tedious to achieve the desired result without it but I'll fiddle and see what I can do with my config.


Phantomjs scales/zooms page when creating PDF in Azure Worker Role

Phantom version 2.1.1
This might be too specific for a Github issue but every avenue of investigation I have explorer has got me nowhere.
The scenario

Microsoft Azure worker role
Phantomjs installed as nuget package
Running phantom process from worker role to convert given webpage to pdf
viewport size is hard coded in rasterize.js
setting page size to A4 in arguments

The Problem

The page is scaled/zoomed which results in the edges being cropped off the page
Setting the zoomFactor does not counter this (or work at all)

Observations

I have RDPd on to the worker role and ran phantomjs through the command line - this produces a normal output
I have created a console application that runs the phantom process and ran it both locally and on the worker role - this produces a normal output
I have ran the worker role in the compute emulator locally - this produces a normal output
I have tried changing the region of my PC to US (to match azure and as opposed to UK) - this produces a normal output

Any help or ideas what so ever would be greatly appreciated.

I think it should be fixed in the master branch.

Is this a known issue then?
Do you know when the next release is due?


Startpage link to login

Fixed it by adding a authenticateUser to the server.js! If you are not logged in, the only pages you can visit are startpage, login and register.


mesos/storm docker images: Upgrading to Mesos v1.1.0

I see there are serveral docker images in docker hub, but didn't get a document how to upgrade and make it work with mesos 1.1.0.
https://hub.docker.com/r/mesos/storm/tags/

Is there any dockerfile that was used? Or any tips about how to upgarde https://github.com/mesos/storm/blob/master/Dockerfile?

@chjhaijiang : we haven't updated for the new Mesos version yet.  We can do that pretty easily if it works to build (it just requires modifying .travis.yml in this repo to have some extra mesos versions, or changing the latest mesos version to be 1.1.0 from 1.0.2).   If you wanna test yourself locally you can follow the instructions in the repo's README.

When this Travis-CI build completes, the artifacts will be available in DockerHub as well as on the GitHub releases page for this repo.


Rollouts Delete Timeout Setting

Timeouts that are set on the HTTPRoute seem to be deleted when Argo Rollouts makes updates to the HTTPRoute. The reference for the timeouts can be found here https://gateway-api.sigs.k8s.io/api-types/httproute/#timeouts-optional. It looks like potentially in the code the timeouts are not being pulled or copied over to the new definition.

Hello
Maybe create one or more Pull Requests with your changes? This way we can integrate the fix here as well.

Hi @mattbrandman, can you make local build and be sure that it solve your problem, please
https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/pull/50

@mattbrandman I merged branch to the main so you can try to make local build from main

Great thanks! I'm currently on vacation but next week can check!

Apologies I wasn't able to submit myself had some other things get in the way hopefully the fork was a slightly useful if messy guide

Can confirm this fixed my issue @Philipp-Plotnikov

Will update when a new release is cute have a 0.5.0 in the fork thats built from most recent main if you want to pull it that way as well


comments on React lessons 4, 7

Please see this link:
https://forum.freecodecamp.com/t/react-tutorial-cokmments-lessons-4-7/74678/3

Hey @sabrawer I replied to you on the Forum, I'm going to close this now.


Strings

Title:  Strings
Name: Sushmitha N J
Label: Feature Request
Assignee: ''
Define You:
✅ DevIncept Participant
Contributor
Is your feature request related to a problem? Please describe.
Its a new feature.
Describe the solution you'd like...
In Python, Strings are arrays of bytes representing Unicode characters. However, Python does not have a character data type, a single character is simply a string with a length of 1. string is an immutable sequence data type.  Square brackets can be used to access elements of the string.
Describe alternatives you've considered?
Approach to be followed (optional):
This program contains of operations on string methods:
isupper() | Returns True if all characters in the string are upper case
lower() method returns a string where all characters are lower case.
replace() method replaces a specified phrase with another specified phrase.
isnumeric() method returns True if all the characters are numeric (0-9), otherwise False.

Can you be particular about the issue, as strings is itself a vast topic. Just edit up with the project you will be working and change details accoringly. Be specific about the topic. @sushmithanjayaram

I will implement
Isupper()
lower()
replace()
Isnumeric()
Methods

Good work, issue assigned. @sushmithanjayaram

Its been 20days and no PR from you yet. @sushmithanjayaram

Its been 25 days. 9th is the last date to accept PR's. If you wouldn't do it by then, obviously you can submit later but points won't be counted towards DCP program. @sushmithanjayaram

Exactly 27 days, Max time is 5 days. And you are unassigned from this issue as time is up for DCP program and you had held it for long time. Next time express interest only if you like to submit it timely. Holding an issue for long is never a right thing. @sushmithanjayaram


Blazor templates missing TemperatureF data

The Blazor (server-side) and Blazor (ASP.NET Core hosted) templates show 0 for the entire TemperatureF column. The data isn't returned by the server and it isn't calculated on the client.

Hosted templates look okay, it was only the server-side template that was missed. Perhaps it should be moved to src/Components/Blazor/Templates/src/content/ so it's in the same area as the other Blazor templates?


MAINT: sparse: reformat str and repr for sparse arrays, correct 1D coords, improve dtype looks

Fixes #20378
Fixes #20377
Currently, str(A) for sparse A with no stored elements returns the empty string.
In repr(A), for 1D arrays, the shape does not appear nicely, e.g. "958 sparse array of type ...". 2D is "4x3 sparse array of type".
This PR puts in repr: format and dtype in first line, nnz and shape in 2nd line.
For str, the text from repr is the start, followed by coord/value column titles followed by coord/value info as before, but now it works for 1D. Also, if no stored values exist, the repr text is returned.

When changing the str/repr format, I didn't change the refguide doctests to match. The CI reports 47 doctests that need to be updated. I've updated/corrected them.
I also changed the term "type" to "dtype" because that is what we are showing... not idx_type or the object's type.
The diff is bigger now, but hopefully still reasonable for review.

The CI failure seems not to be related to this PR. I believe this str/repr PR is ready for review again.

Let me restart the failing CI job for sparse/linalg/tests/test_expm_multiply.py::test_expm_multiply_dtype. I think that one is a known flake (https://github.com/scipy/scipy/issues/18880), but sparse namespace makes me want to re-run it.

Good thanks!  Rerunning the test seems to have let it pass. :)

The "add unittests" commit adds tests that expose the change in str for numpy 2.0. (somehow doctests are not being tested using numpy 2.0 yet)
The "fix numpy 2 printing" commit converts values to python numeric before printing (using ndarray.tolist() which uses i.item()). Only converting the maxprint number of values. Maintenance on this is helped by the removal of the override method of __str__ in _lil.py.  We now have a single definition of __str__ for sparse arrays. Yay...
If these tests pass I think we're good to start a re-review by @perimosocordiae due to the numpy changes.


Event Loop Is Closed crash

Summary
Event Loop Is Closed prevents starting bot.
Reproduction Steps
Use the current version
Start your bot
Code
bot.run(token=token)

Expected Results
The bot starts up
Actual Results
this error:
Traceback (most recent call last):
File "K:\coding\Other\notificationBot\sb.py", line 117, in
bot.run(token=token)
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\client.py", line 938, in run
asyncio.run(runner())
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\runners.py", line 44, in run
return loop.run_until_complete(main)
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 647, in run_until_complete
return future.result()
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\client.py", line 927, in runner
await self.start(token, reconnect=reconnect)
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\client.py", line 857, in start
await self.login(token)
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\client.py", line 698, in login
data = await state.http.static_login(token.strip())
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\http.py", line 991, in static_login
await self.startup()
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\http.py", line 562, in startup
self.super_properties, self.encoded_super_properties = sp, _ = await utils._get_info(session)
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\utils.py", line 1446, in _get_info
bn = await _get_build_number(session)
File "K:\coding\Other\notificationBot\venv\lib\site-packages\discord\utils.py", line 1474, in _get_build_number
build_url = 'https://discord.com/assets/' + re.compile(r'assets/+([a-z0-9]+).js').findall(login_page)[-2] + '.js'
IndexError: list index out of range
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x000001FF7C6C38B0>
Traceback (most recent call last):
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 751, in call_soon
self._check_closed()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 515, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x000001FF7C6C38B0>
Traceback (most recent call last):
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 751, in call_soon
self._check_closed()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 515, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x000001FF7C6C38B0>
Traceback (most recent call last):
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 751, in call_soon
self._check_closed()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 515, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x000001FF7C6C38B0>
Traceback (most recent call last):
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 751, in call_soon
self._check_closed()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 515, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x000001FF7C6C38B0>
Traceback (most recent call last):
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 751, in call_soon
self._check_closed()
File "C:\Users\salma\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 515, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
System Information
- Python v3.9.13-final
- discord.py-self v2.0.0-final
- aiohttp v3.9.1
- system info: Windows 10 10.0.19045
Checklist

[X] I have searched the open issues for duplicates.
[X] I have shared the entire traceback.
[X] I am using a user token (and it isn't visible in the code).

Additional Information
No response

Duplicate of #619


follow-up(PR771): quick freeze/unfreeze

Follow-up to #771.
TBD.
Still TODO:

[x] Handle frozen/unfrozen expired/non-expired fidelity bonds correctly
[x] Handle bond tags correctly (i.e. not using the translated display string for identification)
[x] ShowUtxos should not use ConfirmModal (instead use an own/new distinct modal component?)
[ ] Should ShowUtxos refactored to be external to SourceJarSelector?
[ ] Rename ShowUtxos -> QuickFreezeUtxoModal?
[ ] etc.

Hey @amitx13! Appreciate the valuable feedback!

Wow, the code looks way cleaner and has a precise approach! The improvements are really clear. I did notice a few UI-related aspects that might need some attention:
1. The checkbox is too close to the border.

Changed when switching from ConfirmModal to an own modal. Did not give too much attention to UI details yet, but will definitely take care of it, once the code is "ready". Thanks!

2. The tags are positioned too close to the balance.

:+1:

3. The cancel button is larger than the confirm button.

Ha, how could I not notice that! Thanks :smiling_face_with_tear:

4. I also remember having a meeting with Edi where he mentioned that initially, only 5 UTXOs should be visible, and the rest should be scrollable.

Yes. Good idea. I am still unsure how to make it more obvious that the list is scrollable and there are more UTXOs below..

I am nowhere near @editwentyone when it comes to UI, so I think it might be helpful if @editwentyone could take a look at the modal.

Yes, feedback from @editwentyone is highly appreciated :pray:

Lastly, just a thought: Previously, users were not allowed to unfreeze the last UTXO and proceed with the transaction, but now they can. Considering this change, I came across two conclusions:
1. Maybe we shouldn’t restrict users from doing what they want, as they’re ultimately responsible for their actions.

2. Most users tend to learn by tinkering around rather than reading documentation. So, in my opinion, we should restrict users from doing that.
   What do you think?

Like you clear thinking on this one. But yes, this is intentional, however, open for discussion. Personally, I'd go for option 1.

Ready for review.. it's not yet in the shape I would like it to be, but it's better than before and should be good enough to build on. Especially the tag handling should be improved and refactored in a follow-up PR.

Isn't there supposed to be a tick symbol here?

Isn't there supposed to be a tick symbol here?

Yes, you are right - this is done in a follow-up PR. Can you review and add feedback for #815?

Also, if you want I can fix the UI issues here.

Any contribution is welcome! Best would be to focus on bringing your current PRs on master but any improvement is nice to have and if you see some defect, fixing them is always appreciated.


Ensure each controller gets a globally unique ID

Where were you hitting this, in a multi-root workspace? It's good to have controllers use the same label across reloads, otherwise results will get cleared on each reload.

Yes, this was an issue in a multi-root workspace - Test Explorer doesn't have the requirement that the root suite labels are unique and in fact I think most adapters don't have unique labels for their root suites.

It's good to have controllers use the same label across reloads, otherwise results will get cleared on each reload.

Ah, yes, I understand. In that case it probably makes sense to use both the root suite label (to distinguish between adapters from different extensions for the same workspace) and the path of the workspace folder (to distinguish between adapters from the same extension for different workspaces).

Ok, cool. Would you like to make that change in this PR, or shall I stick it in?

I just did.

Perfect 🙂 I'll publish later today


[ACS][CallAutomation] Live Test Updated V2

Live Test Updated for CallAutomation + Recorded

LocalAuth disabled for ServiceBus
PhoneNumber test now randomized to avoid duplicated tests
Various Bug Fixes

API change check
API changes are not detected in this pull request.


Update the Documentation

Could you add more details about the project in the Readme. This does not contain enough information about the project. @money8203.
Thank you!

As in what ? Can you reference some @tobySolutions !!

Looks good now @money8203. Thanks for this!!

Fixes issue #372


[PTRun][Docs] Add WebSearchShortcut to Third-Party plugins

Summary of the Pull Request
Add WebSearchShortcut to Third-Party plugins for powertoy run

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Can someone review this PR?


Difficulty generating local data

(benchmarks) benchmarks:~$ python tests/tpch/generate_data.py --scale 10
Scale: 10, Path: tpch-data/scale-10-strict, Partition Size: 128 MiB
Generating TPC-H data
Generating TPC-H data
2024-03-22 12:43:41,696 - distributed.nanny - WARNING - Restarting worker
Generating TPC-H data
Generating TPC-H data
Generating TPC-H data
Generating TPC-H data
2024-03-22 12:43:42,050 - distributed.nanny - WARNING - Restarting worker
Generating TPC-H data
2024-03-22 12:43:42,051 - distributed.nanny - WARNING - Restarting worker
Generating TPC-H data
2024-03-22 12:43:42,067 - distributed.nanny - WARNING - Restarting worker
Generating TPC-H data
Generating TPC-H data
2024-03-22 12:43:42,391 - distributed.nanny - WARNING - Restarting worker
Generating TPC-H data
Generating TPC-H data
Generating TPC-H data
Generating TPC-H data
Generating TPC-H data
Generating TPC-H data
2024-03-22 12:43:42,786 - distributed.nanny - WARNING - Restarting worker
2024-03-22 12:43:42,798 - distributed.nanny - WARNING - Restarting worker
Generating TPC-H data
Generating TPC-H data
2024-03-22 12:43:43,129 - distributed.scheduler - ERROR - Task _tpch_data_gen-38c7b57d4862ed3c06b5d86b41e48aab marked as failed because 4 workers died while trying to run it
2024-03-22 12:43:43,131 - distributed.nanny - WARNING - Restarting worker
2024-03-22 12:43:43,558 - distributed.worker.state_machine - WARNING - Async instruction for <Task cancelled name="execute('_tpch_data_gen-ca2a7818e09d1620d908fe93c8cc8d27')" coro=<Worker.execute() done, defined at /Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/worker_state_machine.py:3615>> ended with CancelledError
2024-03-22 12:43:43,558 - distributed.worker.state_machine - WARNING - Async instruction for <Task cancelled name="execute('_tpch_data_gen-563c42036a6cdb159368164534049814')" coro=<Worker.execute() done, defined at /Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/worker_state_machine.py:3615>> ended with CancelledError
2024-03-22 12:43:46,758 - distributed.nanny - WARNING - Worker process still alive after 3.1999995422363288 seconds, killing

Traceback (most recent call last):
  File "/Users/mrocklin/workspace/benchmarks/tests/tpch/generate_data.py", line 80, in generate
    tpch_from_client(client, **kwargs)
  File "/Users/mrocklin/workspace/benchmarks/tests/tpch/generate_data.py", line 93, in tpch_from_client
    small_tables = client.gather(jobs)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/client.py", line 2372, in gather
    return self.sync(
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/client.py", line 2232, in _gather
    raise exception.with_traceback(traceback)
distributed.scheduler.KilledWorker: Attempted to run task '_tpch_data_gen-38c7b57d4862ed3c06b5d86b41e48aab' on 4 different workers, but all those workers died while running it. The last worker that attempt to run the task was tcp://<IP_ADDRESS>:52238. Inspecting worker logs is often a good next step to diagnose what went wrong. For more information see https://distributed.dask.org/en/stable/killed.html.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mrocklin/workspace/benchmarks/tests/tpch/generate_data.py", line 342, in <module>
    main()
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/mrocklin/workspace/benchmarks/tests/tpch/generate_data.py", line 338, in main
    generate(scale, partition_size, path, relaxed_schema, compression)
  File "/Users/mrocklin/workspace/benchmarks/tests/tpch/generate_data.py", line 85, in generate
    time.sleep(5)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/client.py", line 1517, in __exit__
    self.close()
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/client.py", line 1775, in close
    sync(self.loop, self._close, fast=True, callback_timeout=timeout)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/utils.py", line 428, in sync
    raise TimeoutError(f"timed out after {timeout} s.")
asyncio.exceptions.TimeoutError: timed out after 60 s.
2024-03-22 12:44:43,159 - distributed.client - ERROR -
Traceback (most recent call last):
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/asyncio/locks.py", line 226, in wait
    await fut
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/deploy/spec.py", line 359, in _correct_state_internal
    await asyncio.gather(*tasks)
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/utils.py", line 832, in wrapper
    return await func(*args, **kwargs)
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/client.py", line 1722, in _close
    await self.cluster.close()
  File "/Users/mrocklin/mambaforge/envs/benchmarks/lib/python3.9/site-packages/distributed/deploy/spec.py", line 448, in _close
    await self._correct_state()
asyncio.exceptions.CancelledError

Not an urgent issue, but somewhat concerning
This is after running installation as in #1493 on a MacBookPro

I did some digging into this. A couple of observations

The files (by default) are actually a little larger than what the "Partition Size" suggests. I have files that are 200-200MiB each
This translate to about 2-2.5GiB in memory data
I'm running on a M1 with 8 cores and 16GiB of RAM leaving just 2GiB of RAM per thread
We are employing a rather aggressive partition compaction here that aims to fuse partitions based on how much data we cut off using projection / filtering. Beyond the actual memory usage, I saw this pattern causing us to fuse so dramatically that we're not even utilizing all cores necessarily.

So, we're running on relatively large files already and are merging those partitions way too aggressively.

To this I also had to sent n_workers to 6 or something to generate scale 100. Didn't look further into it as I had other goals in mind at the time.

Ah sorry, forget my earlier comment. I was referring to the actual run of the TPCH data. The failures during generation originate from running duckdb on multiple threads which triggers a segfault. just running with one thread does the trick. This is fixed with https://github.com/coiled/benchmarks/pull/1490


Is there any way to check if user has chosen the file?

I thoroughly saw whole croppa object. But it doesn't have any boolean property like hasChosenImage or hasImage set.
So can you guide ?

Take a look at imageSet. It might be what you need.
this.croppa.imageSet

@zhanziyang Will look at it !

Yes it's working @zhanziyang !

Great. Then I'm going to close this.


feat: add objectstorage pkg

Description

Add objectstorage pkg.
Add object storage config to manager.
Refactor manager config validation.
Refactor scheduler config validation.

Related Issue
#1249

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #1366 (01cf6dc) into main (ebc0ea5) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   45.79%   45.70%   -0.09%
==========================================
  Files         140      140
  Lines       11984    12000      +16
==========================================
- Hits         5488     5485       -3
- Misses       5873     5892      +19
  Partials      623      623

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.70% <0.00%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

manager/config/config.go
0.00% <0.00%> (ø)

scheduler/config/config.go
47.41% <0.00%> (ø)

client/daemon/peer/peertask_conductor.go
58.14% <0.00%> (-0.31%)
:arrow_down:


How to deal the paired-end data

From the  4C-ker paper, we know "For paired-end sequencing experiments the read containing the bait and the primary restriction enzyme was mapped as single-end data" . Is it meaning we should treat the paired-end data as single-end data ?

Hey!
I have this question too.
My data was sequenced with paired-end and I want to use this package but I not know how to deal with paired-end sequencing with R.4C-ker package.
Can you help me?
Thanks, R

Hi,
If this is not allele specific 4C then you can just use the read that contains the primer sequence and treat is as single-end sequencing.

So, your suggestion is not consider the fastq file R2 and only use the R1 that contain the primer sequence?
Thanks for the quick answer!


DeployBlockerCash: Add labels, comment in slack, comment on issue

Details
Previously, when an Expensify.cash Deploy Blocker was created, we would just add the issue to the open StagingDeployCash checklist. This PR makes it so that we:

Add it to the StagingDeployCash checklist
Give it the Hourly and Demolition labels
Post the issue in Slack in the #deployer room
Comment on the issue with instructions that clarify the expectation for assignees.

Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/163893
QA Steps

Merge this PR
Label an issue DeployBlockerCash
Verify that the issue is given the Hourly and Demolition labels
Verify that someone from the Engineering Demolition team is auto-assigned to the issue.
Verify that the issue is posted in the #deployer slack room
Verify that OSBotify comments in the issue with a comment that looks like this:

Tested On
Can be live-tested on GitHub only (although I did test the issue comment in another repo I use for testing GH Actions).

@deetergp Since Andrew is OoO I'm requesting your review since I know you have some familiarity with the GH Actions YAML syntax.

Looks good to me!

@Gonals In the spirit of #Urgency I'm going to go ahead and self-merge this so that any deploy blockers created today get auto-assigned with a high degree of urgency.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging in version: 1.0.46-1🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@roryabraham Heyo!
Added the deploy blocker to this issue that was found around the IOU transactions. Seems like this PR is a fail but wanted to verify with you first https://github.com/Expensify/Expensify.cash/issues/2969

Hi @isagoico . That PR was indeed a fail. I have a (hopefully) better one here.


Terminal closes when pwsh crashes with PSReadLine module imported after window session resume

Windows Terminal version
1.16.2642.0
Windows build number
10.0.22621.0
Other Software
pwsh 7.3.0
PSReadLine 2.26
Steps to reproduce
Open terminal
Open a tab with pwsh and a tab with cmd
Close lid (Surface Book 3) or get OS to sleep
Wake up and log in to session
Expected Behavior
WT is there and all tabs are open
Actual Behavior
WT is closed. I will add more details in the comment below.

In Event Viewere I see such log events:
Application: pwsh.exe
CoreCLR Version: <IP_ADDRESS>805
.NET Version: 7.0.0
Description: The process was terminated due to an unhandled exception.
Exception Info: System.InvalidOperationException: Cannot read keys when either application does not have a console or when console input has been redirected. Try Console.Read.
   at System.ConsolePal.ReadKey(Boolean intercept)
   at Microsoft.PowerShell.Internal.VirtualTerminal.ReadKey()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadOneOrMoreKeys()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadKeyThreadProc()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

and
Faulting application name: pwsh.exe, version: <IP_ADDRESS>0, time stamp: 0x634eda42
Faulting module name: Microsoft.PowerShell.ConsoleHost.dll, version: <IP_ADDRESS>0, time stamp: 0xa3a9c435
Exception code: 0x80131623
Fault offset: 0x000000000004de7b
Faulting process id: 0x0x1E08
Faulting application start time: 0x0x1D90A2ACCE8B73D
Faulting application path: C:\Program Files\PowerShell\7\pwsh.exe
Faulting module path: C:\Program Files\PowerShell\7\Microsoft.PowerShell.ConsoleHost.dll
Report Id: 5e2b0c3e-cc6d-4c2a-b974-66fcc4c47110
Faulting package full name:
Faulting package-relative application ID:

I see crash dumps:
Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           12/6/2022  2:21 PM        6728840 pwsh.exe.12880.dmp
-a---           12/6/2022  2:21 PM        7108647 pwsh.exe.14556.dmp
-a---           12/5/2022  5:48 PM        6921187 pwsh.exe.17304.dmp
-a---           12/5/2022  5:48 PM        7264709 pwsh.exe.19560.dmp
-a---           12/7/2022  9:40 AM        6484570 pwsh.exe.21780.dmp
-a---           12/6/2022  8:29 PM        6904897 pwsh.exe.5368.dmp
-a---           12/5/2022  8:35 PM        6699049 pwsh.exe.6360.dmp
-a---           12/5/2022  5:48 PM        6735171 pwsh.exe.6592.dmp
-a---           12/7/2022  5:03 PM        6949380 pwsh.exe.7688.dmp
-a---           12/5/2022  7:31 PM        7017435 pwsh.exe.9936.dmp

dotnet-dump shows such stacktrace:

> clrstack -all
OS Thread Id: 0x1c8c
        Child SP               IP Call Site
000000316EF7E0E8 00007ff9de00f954 [HelperMethodFrame: 000000316ef7e0e8] System.Threading.WaitHandle.WaitOneCore(IntPtr, Int32)
000000316EF7E1F0 00007FF91F9A3908 System.Threading.WaitHandle.WaitOneNoCheck(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitHandle.cs @ 120]
000000316EF7E250 00007FF97C8EA146 System.Management.Automation.Runspaces.PipelineBase.Invoke(System.Collections.IEnumerable)
000000316EF7E290 00007FF97C9F90E6 System.Management.Automation.PowerShell+Worker.ConstructPipelineAndDoWork(System.Management.Automation.Runspaces.Runspace, Boolean)
000000316EF7E360 00007FF97C9F8BE4 System.Management.Automation.PowerShell+Worker.CreateRunspaceIfNeededAndDoWork(System.Management.Automation.Runspaces.Runspace, Boolean)
000000316EF7E3D0 00007FF97CBC829C System.Management.Automation.PowerShell.CoreInvokeHelper[[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib]](System.Management.Automation.PSDataCollection`1<System.__Canon>, System.Management.Automation.PSDataCollection`1<System.__Canon>, System.Management.Automation.PSInvocationSettings)
000000316EF7E450 00007FF97CBC8705 System.Management.Automation.PowerShell.CoreInvoke[[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib]](System.Management.Automation.PSDataCollection`1<System.__Canon>, System.Management.Automation.PSDataCollection`1<System.__Canon>, System.Management.Automation.PSInvocationSettings)
000000316EF7E4D0 00007FF97C74BD85 System.Management.Automation.PowerShell.Invoke(System.Collections.IEnumerable, System.Management.Automation.PSInvocationSettings)
000000316EF7E530 00007FF988B4955F Microsoft.PowerShell.ConsoleHostUserInterface.TryInvokeUserDefinedReadLine(System.String ByRef)
000000316EF7E580 00007FF988B48CB7 Microsoft.PowerShell.ConsoleHostUserInterface.ReadLineWithTabCompletion(Microsoft.PowerShell.Executor)
000000316EF7E6B0 00007FF988B530D9 Microsoft.PowerShell.ConsoleHost+InputLoop.Run(Boolean)
000000316EF7E760 00007FF988B52C73 Microsoft.PowerShell.ConsoleHost+InputLoop.RunNewInputLoop(Microsoft.PowerShell.ConsoleHost, Boolean)
000000316EF7E7B0 00007FF988B40655 Microsoft.PowerShell.ConsoleHost.EnterNestedPrompt()
000000316EF7E810 00007FF988B415FE Microsoft.PowerShell.ConsoleHost.DoRunspaceLoop(System.String, Boolean, System.Collections.ObjectModel.Collection`1<System.Management.Automation.Runspaces.CommandParameter>, Boolean, System.String, System.String)
000000316EF7E8B0 00007FF988B414D2 Microsoft.PowerShell.ConsoleHost.Run(Microsoft.PowerShell.CommandLineParameterParser, Boolean)
000000316EF7E920 00007FF988B3F745 Microsoft.PowerShell.ConsoleHost.Start(System.String, System.String, Boolean)
000000316EF7E990 00007FF988B4DDB1 Microsoft.PowerShell.UnmanagedPSEntry.Start(System.String[], Int32)
000000316EF7E9F0 00007FF99AE6110D Microsoft.PowerShell.ManagedPSEntry.Main(System.String[])
OS Thread Id: 0x39ec
        Child SP               IP Call Site
000000316F87FD20 00007ff9de00f954 [DebuggerU2MCatchHandlerFrame: 000000316f87fd20]
OS Thread Id: 0x278
        Child SP               IP Call Site
000000316FBBF628 00007ff9de00f954 [HelperMethodFrame: 000000316fbbf628] System.Threading.WaitHandle.WaitOneCore(IntPtr, Int32)
000000316FBBF730 00007FF91F9A3908 System.Threading.WaitHandle.WaitOneNoCheck(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitHandle.cs @ 120]
000000316FBBF790 00007FF97D9FC289 System.Threading.PortableThreadPool+GateThread.GateThreadStart() [/_/src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.GateThread.cs @ 48]
000000316FBBFAC0 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame: 000000316fbbfac0]
OS Thread Id: 0x2d14
        Child SP               IP Call Site
000000317033F5A8 00007ff9de00f954 [HelperMethodFrame:<PHONE_NUMBER>33f5a8] System.Threading.WaitHandle.WaitOneCore(IntPtr, Int32)
000000317033F6B0 00007FF91F9A3908 System.Threading.WaitHandle.WaitOneNoCheck(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitHandle.cs @ 120]
000000317033F710 00007FF97D9F7FE2 System.Threading.TimerQueue.TimerThread() [/_/src/libraries/System.Private.CoreLib/src/System/Threading/TimerQueue.Portable.cs @ 92]
000000317033F9F0 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>33f9f0]
OS Thread Id: 0x13bc
        Child SP               IP Call Site
000000317063F928 00007ff9de00f954 [HelperMethodFrame:<PHONE_NUMBER>63f928] System.Threading.WaitHandle.WaitOneCore(IntPtr, Int32)
000000317063FA30 00007FF91F9A3908 System.Threading.WaitHandle.WaitOneNoCheck(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitHandle.cs @ 120]
000000317063FA90 00007FF97A4826D1 Microsoft.ApplicationInsights.Channel.InMemoryTransmitter.Runner()
000000317063FB00 00007FF97D9EC878 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 183]
000000317063FB70 00007FF97DA043C4 System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs @ 2345]
000000317063FE60 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>63fe60]
OS Thread Id: 0x40d4
        Child SP               IP Call Site
000000317067FB20 00007ff9de011d94 [InlinedCallFrame:<PHONE_NUMBER>67fb20]
000000317067FB20 00007ff97d9fe040 [InlinedCallFrame:<PHONE_NUMBER>67fb20]
000000317067FAE0 00007FF97D9FE040 System.Threading.PortableThreadPool+IOCompletionPoller.Poll() [/_/src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.IO.Windows.cs @ 188]
000000317067FE40 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>67fe40]
OS Thread Id: 0x59c8
        Child SP               IP Call Site
00000031707FF368 00007ff9de00f954 [HelperMethodFrame_1OBJ:<PHONE_NUMBER>7ff368] System.Threading.Monitor.ObjWait(Int32, System.Object)
00000031707FF490 00007FF97D9EE9C9 System.Threading.ManualResetEventSlim.Wait(Int32, System.Threading.CancellationToken) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs @ 575]
00000031707FF530 00007FF97DA050FD System.Threading.Tasks.Task.SpinThenBlockingWait(Int32, System.Threading.CancellationToken) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs @ 3021]
00000031707FF5B0 00007FF97DA04EF2 System.Threading.Tasks.Task.InternalWaitCore(Int32, System.Threading.CancellationToken) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs @ 2956]
00000031707FF630 00007FF97DA58DB2 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task) [/_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs @ 140]
00000031707FF660 00007FF97A25E4D0 System.IO.Pipes.NamedPipeServerStream.WaitForConnection() [/_/src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeServerStream.Windows.cs @ 171]
00000031707FF6B0 00007FF97C8847BB System.Management.Automation.Remoting.RemoteSessionNamedPipeServer.ProcessListeningThread(System.Object)
00000031707FF810 00007FF97D9EC878 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 183]
00000031707FFAD0 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>7ffad0]
OS Thread Id: 0x57cc
        Child SP               IP Call Site
00000031710FF308 00007ff9de00f484 [HelperMethodFrame:<PHONE_NUMBER>0ff308] System.Threading.Thread.SleepInternal(Int32)
00000031710FF400 00007FF91FFA14B5 System.Threading.Thread.Sleep(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs @ 372]
00000031710FF440 00007FF97A453DBC Microsoft.ApplicationInsights.Metrics.DefaultAggregationPeriodCycle.Run()
00000031710FF4D0 00007FF97D9EC878 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 183]
00000031710FF790 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>0ff790]
OS Thread Id: 0x4470
        Child SP               IP Call Site
0000003171A8EE78 00007ff9db97acf4 [HelperMethodFrame:<PHONE_NUMBER>a8ee78] System.Threading.WaitHandle.WaitMultipleIgnoringSyncContext(IntPtr*, Int32, Boolean, Int32)
0000003171A8EFA0 00007FF91FFE0BD6 System.Threading.WaitHandle.WaitMultiple(System.ReadOnlySpan`1<System.Threading.WaitHandle>, Boolean, Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/WaitHandle.cs @ 250]
0000003171A8F070 00007FF91FFE2680 Microsoft.PowerShell.PSConsoleReadLine.ReadKey()
0000003171A8F220 00007FF91F970E24 Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
0000003171A8F2E0 00007FF91F96C5D1 Microsoft.PowerShell.PSConsoleReadLine.ReadLine(System.Management.Automation.Runspaces.Runspace, System.Management.Automation.EngineIntrinsics, System.Threading.CancellationToken, System.Nullable`1<Boolean>)
0000003171A8F3C0 00007FF91FC5D7B8 SOS Warning: Loading symbols for dynamic assemblies is not yet supported
<unknown>
0000003171A8F450 00007FF97CB845F7 System.Management.Automation.Interpreter.DynamicInstruction`5[[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib],[System.__Canon, System.Private.CoreLib]].Run(System.Management.Automation.Interpreter.InterpretedFrame)
0000003171A8F500 00007FF91FFD53CA System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
0000003171A8F5A0 00007FF91FFD53CA System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(System.Management.Automation.Interpreter.InterpretedFrame)
0000003171A8F640 00007FF92001C1A8 System.Management.Automation.Interpreter.Interpreter.Run(System.Management.Automation.Interpreter.InterpretedFrame)
0000003171A8F6B0 00007FF92001BCA0 System.Management.Automation.Interpreter.LightLambda.RunVoid1[[System.__Canon, System.Private.CoreLib]](System.__Canon)
0000003171A8F730 00007FF97C7EDAD0 System.Management.Automation.DlrScriptCommandProcessor.RunClause(System.Action`1<System.Management.Automation.Language.FunctionContext>, System.Object, System.Object)
0000003171A8F7D0 00007FF97C7ED462 System.Management.Automation.DlrScriptCommandProcessor.Complete()
0000003171A8F850 00007FF9200180F3 System.Management.Automation.CommandProcessorBase.DoComplete()
0000003171A8F8A0 00007FF920180F92 System.Management.Automation.Internal.PipelineProcessor.DoCompleteCore(System.Management.Automation.CommandProcessorBase)
0000003171A8F970 00007FF9201800E9 System.Management.Automation.Internal.PipelineProcessor.SynchronousExecuteEnumerate(System.Object)
0000003171A8F9E0 00007FF91E8839E2 System.Management.Automation.Runspaces.LocalPipeline.InvokeHelper()
0000003171A8FAC0 00007FF97C8E7A47 System.Management.Automation.Runspaces.LocalPipeline.InvokeThreadProc()
0000003171A8FB20 00007FF97C8E8C0F System.Management.Automation.Runspaces.PipelineThread.WorkerProc()
0000003171A8FB50 00007FF97D9EC878 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 183]
0000003171A8FE10 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>a8fe10]
OS Thread Id: 0x5568
        Child SP               IP Call Site
000000317208F478 00007ff9de00f954 [HelperMethodFrame:<PHONE_NUMBER>08f478]
000000317208F570 00007FF91F9AB9B9 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() [/_/src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs @ 53]
000000317208F5A0 00007FF97D9EC8F2 System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs @ 207]
000000317208F860 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame:<PHONE_NUMBER>08f860]
OS Thread Id: 0x21e8
        Child SP               IP Call Site
000000316F0FF328 00007ff9de00ef24 [InlinedCallFrame: 000000316f0ff328] Interop+Kernel32.<GetQueuedCompletionStatus>g____PInvoke|50_0(IntPtr, UInt32*, UIntPtr*, IntPtr*, Int32)
000000316F0FF328 00007ff91f9a67ee [InlinedCallFrame: 000000316f0ff328] Interop+Kernel32.<GetQueuedCompletionStatus>g____PInvoke|50_0(IntPtr, UInt32*, UIntPtr*, IntPtr*, Int32)
000000316F0FF2F0 00007FF91F9A67EE System.Threading.LowLevelLifoSemaphore.WaitForSignal(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.cs @ 200]
000000316F0FF3D0 00007FF91F9A355F System.Threading.LowLevelLifoSemaphore.Wait(Int32, Boolean) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.cs @ 44]
000000316F0FF490 00007FF97D9FEEF2 System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart() [/_/src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.WorkerThread.cs @ 71]
000000316F0FF7F0 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame: 000000316f0ff7f0]
OS Thread Id: 0x14fc
        Child SP               IP Call Site
000000316F9FF2D8 00007ff9de00ef24 [InlinedCallFrame: 000000316f9ff2d8] Interop+Kernel32.<GetQueuedCompletionStatus>g____PInvoke|50_0(IntPtr, UInt32*, UIntPtr*, IntPtr*, Int32)
000000316F9FF2D8 00007ff91f9a67ee [InlinedCallFrame: 000000316f9ff2d8] Interop+Kernel32.<GetQueuedCompletionStatus>g____PInvoke|50_0(IntPtr, UInt32*, UIntPtr*, IntPtr*, Int32)
000000316F9FF2A0 00007FF91F9A67EE System.Threading.LowLevelLifoSemaphore.WaitForSignal(Int32) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.cs @ 200]
000000316F9FF380 00007FF91F9A355F System.Threading.LowLevelLifoSemaphore.Wait(Int32, Boolean) [/_/src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.cs @ 44]
000000316F9FF440 00007FF97D9FEEF2 System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart() [/_/src/libraries/System.Private.CoreLib/src/System/Threading/PortableThreadPool.WorkerThread.cs @ 71]
000000316F9FF7A0 00007ff97e35e423 [DebuggerU2MCatchHandlerFrame: 000000316f9ff7a0]
OS Thread Id: 0x5c54
        Child SP               IP Call Site
000000316FB7FDA0 00007ff9de00ee84 [DebuggerU2MCatchHandlerFrame: 000000316fb7fda0]
>

After I removed PSReadLine module the pwsh did not crash (yet).

Windows Terminal is open all the time, for several days or weeks, until Windows restarts after updates. Usually there are several tabs open.
wt 1.16.2642.0

 > $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.0
PSEdition                      Core
GitCommitId                    7.3.0
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

 > (Get-Module PSReadLine).Version.ToString()
2.2.6

Mine just crashed again with no PSReadLine.
Application: pwsh.exe
CoreCLR Version: <IP_ADDRESS>805
.NET Version: 7.0.0
Description: The application requested process termination through System.Environment.FailFast.
Message: The Win32 internal error "No process is on the other end of the pipe." 0xE9 occurred while getting console output buffer information. Contact Microsoft Customer Support Services.
Description: The process was terminated due to an unhandled exception.System.Management.Automation.Host.HostException: The Win32 internal error "No process is on the other end of the pipe." 0xE9 occurred while getting console output buffer information. Contact Microsoft Customer Support Services.
 ---> System.ComponentModel.Win32Exception (233): No process is on the other end of the pipe.
   --- End of inner exception stack trace ---
   at Microsoft.PowerShell.ConsoleControl.GetConsoleScreenBufferInfo(SafeFileHandle consoleHandle)
   at Microsoft.PowerShell.ConsoleHostRawUserInterface.get_CursorPosition()
   at Microsoft.PowerShell.ConsoleHost.InputLoop.Run(Boolean inputLoopIsNested)
   at Microsoft.PowerShell.ConsoleHost.InputLoop.RunNewInputLoop(ConsoleHost parent, Boolean isNested)
   at Microsoft.PowerShell.ConsoleHost.EnterNestedPrompt()
   at Microsoft.PowerShell.ConsoleHost.DoRunspaceLoop(String initialCommand, Boolean skipProfiles, Collection`1 initialCommandArgs, Boolean staMode, String configurationName, String configurationFilePath)
   at Microsoft.PowerShell.ConsoleHost.Run(CommandLineParameterParser cpp, Boolean isPrestartWarned)
   at Microsoft.PowerShell.ConsoleHost.Start(String bannerText, String helpText, Boolean issProvidedExternally)
   at Microsoft.PowerShell.UnmanagedPSEntry.Start(String[] args, Int32 argc)
Stack:
   at System.Environment.FailFast(System.String, System.Exception)
   at Microsoft.PowerShell.UnmanagedPSEntry.Start(System.String[], Int32)
   at Microsoft.PowerShell.ManagedPSEntry.Main(System.String[])

The stack here looks very similar to https://github.com/PowerShell/PowerShell/issues/16818, though, that issue does seem to specifically reference the alt buffer[1].
~If you set "closeOnExit": "never" for the profile, does the Terminal stick around? I wonder if this is pwsh crashing, and the Terminal closing as a result, or the other way around. That setting might help ID~ er, no, that's probably not relevant. If there's a pwsh tab and a cmd tab that both exit, then that's probably something Terminal-side that's causing the app to exit. This makes me thing of https://github.com/microsoft/terminal/issues/14436#issuecomment-1337476068, where there was a XAML stowed exception taking the Terminal down, but not in a way that created a windowsterminal.exe dump (for whatever reason).
I might be able to track a /feedback hub submission back to an unrelated crash from your machine. It's worth a shot.
@stevel-msft any ideas here?
[1]: Interestingly, I think when that pwsh issue had been originally authored, the Terminal didn't support the alt buffer yet.

Now I have WT's crash dump. Let me know where I can post it.  ; Followup set based on attribute [Is_ChosenCrashFollowupThread] from Frame:[0] on thread:[PSEUDO_THREAD]

FAULTING_THREAD:  ffffffff

STACK_TEXT:
00000000`00000000 00000000`00000000 WRONG_SYMBOLS!WRONG_SYMBOLS+0x0

STACK_COMMAND:  ** Pseudo Context ** ManagedPseudo ** Value: ffffffff ** ; kb

BUGCHECK_CODE:  a97a9ed6

EXCEPTION_CODE_STR:  A97A9ED6

EXCEPTION_STR:  WRONG_SYMBOLS

IMAGE_NAME:  ntdll.wrong.symbols.dll

MODULE_NAME: ntdll_wrong_symbols

SYMBOL_NAME:  ntdll_wrong_symbols!A97A9ED6214000

FAILURE_BUCKET_ID:  WRONG_SYMBOLS_X64_22621.1.amd64fre.ni_release.220506-1250_TIMESTAMP_600207-131918_A97A9ED6_ntdll.wrong.symbols.dll!A97A9ED6214000

OS_VERSION:  10.0.22621.1

BUILDLAB_STR:  ni_release

OSPLATFORM_TYPE:  x64

OSNAME:  Windows 10

FAILURE_ID_HASH:  {90a1e60c-1a60-d8e9-c755-95911af0d991}

Followup:     MachineOwner
---------

Now that's the strangest stack I've ever seen! We're blowing up during an orderly shutdown (!!) trying to decom the tooltip on the min/max/close buttons.
What's puzzling is that AppHost is explicitly tearing down. It only does that if the last tab exits... or, it should.

Yep, it was differente before WinDbg downloaded pdb files. Here is the same dump but with lldb:
(lldb) bt
* thread #1, stop reason = Exception 0xc0000005 encountered at address 0x7ffb72f6ce69
  * frame #0: 0x00007ffb72f6ce69 Windows.UI.Xaml.dll`DllMain + 734649
    frame #1: 0x00007ffb736d4b1e Windows.UI.Xaml.dll`GetStringRawBuffer + 4166398
    frame #2: 0x00007ffb736d44f2 Windows.UI.Xaml.dll`GetStringRawBuffer + 4164818
    frame #3: 0x00007ffb72f2407e Windows.UI.Xaml.dll`DllMain + 436174
    frame #4: 0x00007ffb72ba06a2 Windows.UI.Xaml.dll`GetErrorContextIndex + 125426
    frame #5: 0x00007ffb72bb071f Windows.UI.Xaml.dll`GetErrorContextIndex + 191087
    frame #6: 0x00007ffb72bae8ef Windows.UI.Xaml.dll`GetErrorContextIndex + 183359
    frame #7: 0x00007ffb72bae74b Windows.UI.Xaml.dll`GetErrorContextIndex + 182939
    frame #8: 0x00007ffb72baca5c Windows.UI.Xaml.dll`GetErrorContextIndex + 175532
    frame #9: 0x00007ffb72bac042 Windows.UI.Xaml.dll`GetErrorContextIndex + 172946
    frame #10: 0x00007ffb72bab03f Windows.UI.Xaml.dll`GetErrorContextIndex + 168847
    frame #11: 0x00007ffb72baa59d Windows.UI.Xaml.dll`GetErrorContextIndex + 166125
    frame #12: 0x00007ffb72c9e6eb Windows.UI.Xaml.dll`DllGetActivationFactory + 203547
    frame #13: 0x00007ffb72c4219d Windows.UI.Xaml.dll`GetErrorContextIndex + 787693
    frame #14: 0x00007ffb511615f8 TerminalApp.dll`DllCanUnloadNow + 137752
    frame #15: 0x00007ffb51178049 TerminalApp.dll`DllCanUnloadNow + 230505
    frame #16: 0x00007ffb5117a50a TerminalApp.dll`DllCanUnloadNow + 239914
    frame #17: 0x00007ffb51178172 TerminalApp.dll`DllCanUnloadNow + 230802
    frame #18: 0x00007ffb51178e9d TerminalApp.dll`DllCanUnloadNow + 234173
    frame #19: 0x00007ffb77f7ef20 CoreMessaging.dll`CoreUICreateEx + 176
    frame #20: 0x00007ffb77fa6244 CoreMessaging.dll`CoreUICallReceive + 8244
    frame #21: 0x00007ffb77fa5cbe CoreMessaging.dll`CoreUICallReceive + 6830
    frame #22: 0x00007ffb77fb360f CoreMessaging.dll`CoreUICallReceive + 62463
    frame #23: 0x00007ffb77fb1a63 CoreMessaging.dll`CoreUICallReceive + 55379
    frame #24: 0x00007ffb77fb23ef CoreMessaging.dll`CoreUICallReceive + 57823
    frame #25: 0x00007ffb77fb0033 CoreMessaging.dll`CoreUICallReceive + 48675
    frame #26: 0x00007ffb77fafbf6 CoreMessaging.dll`CoreUICallReceive + 47590
    frame #27: 0x00007ffb77fad0ac CoreMessaging.dll`CoreUICallReceive + 36508
    frame #28: 0x00007ffb8cbb8271 user32.dll`DispatchMessageW + 1857
    frame #29: 0x00007ffb8cbb7f2c user32.dll`DispatchMessageW + 1020
    frame #30: 0x00007ffb8cbc2ded user32.dll`GetClassLongW + 1421
    frame #31: 0x00007ffb8e8b2e44 ntdll.dll`KiUserCallbackDispatcher + 36
    frame #32: 0x00007ffb8c3514d4 win32u.dll`NtUserPeekMessage + 20
    frame #33: 0x00007ffb8cbc190f user32.dll`PeekMessageW + 463
    frame #34: 0x00007ffb8cbc17dc user32.dll`PeekMessageW + 156
    frame #35: 0x00007ffb8b6e91d9 InProcessClient64.dll
    frame #36: 0x00007ffb8b6e9248 InProcessClient64.dll
    frame #37: 0x00007ffb8b6e911c InProcessClient64.dll
    frame #38: 0x00007ffb631114f5 Microsoft.Toolkit.Win32.UI.XamlHost.dll
    frame #39: 0x00007ffb631139b9 Microsoft.Toolkit.Win32.UI.XamlHost.dll
    frame #40: 0x00007ff71533c4d1 WindowsTerminal.exe
    frame #41: 0x00007ff715338f2f WindowsTerminal.exe
    frame #42: 0x00007ff715328813 WindowsTerminal.exe
    frame #43: 0x00007ff71531dfe2 WindowsTerminal.exe
    frame #44: 0x00007ffb8c61247d kernel32.dll`BaseThreadInitThunk + 29
    frame #45: 0x00007ffb8e86dfb8 ntdll.dll`RtlUserThreadStart + 40

Turned out I had two PSReadLine modules. One was a part of pwsh 7 (2.2.6) and another was installed previously (2.2.0). I removed the older one and left only the one that is part of pwsh. Will check how it works now.

The state of things is: pwsh uses PSReadLine 2.2.6 from pwsh installation, I turned off some services like RuntimeBroker, attached WinDbg to pwsh and openconsole and things are stable so far. Looks like it was not caused by WT or pwsh but some wndows related issues.

Thanks so much for following up! If it does come back & we can get line of sight on it being Terminal's responsibility, please do reopen/let us know!

@DHowett thanks, but I am still not happy about what is happening. Something strange. I have 3 terminals - WT, Alacritty and WezTerm. All use the same pwsh.exe. But when I close the lid or computer goes to sleep, it is only WT that is being closed. Now I think that it is closing for some reason and causes pwsh.exe to be closed. I see there is trace logging capability in WT. What is the best doc page to read on how to turn it on? I tried using WinDbg and bp on AppHost::_Quit... methods, but WinDbg disappears as well. Tried using procdump with -t. Same outcome, it just goes away and no dump is generated. Trying to catch what is causing some apps to close. Skype is closing as well. I have to run it on every log in. Annoying.

Excellent observations! We've got a quick doc on capturing a trace at https://github.com/microsoft/terminal/wiki/Capturing-a-Debug-ETL-Trace :)
I've reopened the issue for now as it looks pretty darn likely that it's us :P

I did the WPR, but I think I found something that is almost embarrassing - in the Settings - Apps - Installed Apps - WindowsTerminalPreview, the setting "Let this app run in background" was set to Never. Same was done for Skype. Checking could this impact the working on WT or no.

Yes, that was it :) You can close the ticket.
Though I have a suggestion - maybe WT can check that settings (it is available via registry, get appx name and it is here - HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\BackgroundAccessApplications\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe
The settings are DisabledByUser and Disabled.
At least warn the user. And another observation, looks like there is .net crash, when its pipe losing the other side and cannot read the data. It crashes.

For some reason, only recently this problem has been closing WT. I did set the background permission to "Always", but seems that shouldn't be necessary to prevent my terminal from tearing down and taking any ephemeral env vars with it. This has been happening a lot in the last few days (though nothing I've noticed has otherwise changed other than a recent .NET 7 update). Just a bit ago I walked away from lunch in the middle of some testing, came back, and WT was gone. Same as this morning. The only trace of a problem was from the Application event log:
Application: pwsh.exe
CoreCLR Version: 7.0.323.6910
.NET Version: 7.0.3
Description: The process was terminated due to an unhandled exception.
Exception Info: System.InvalidOperationException: Cannot read keys when either application does not have a console or when console input has been redirected. Try Console.Read.
   at System.ConsolePal.ReadKey(Boolean intercept)
   at Microsoft.PowerShell.PSConsoleReadLine.ReadOneOrMoreKeys()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadKeyThreadProc()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

At least in this case, pwsh was the only tab open. I often have wsl (Ubuntu / bash) open as well, though I don't recall off hand if WT was terminated or not. I only started suspecting that I didn't accidentally type exit myself and that something else was amiss.
pwsh is 7.3.3 and PSReadLine is 2.2.6. /cc @stevel-msft, though I didn't see any similar bugs in powershell/powershell.

Per offline discussion, I'm going to try to downgrade to PowerShell 7.3.2 and run that way for a while, but whatever caused wt.exe to ultimately terminate (whether pwsh.exe's fault or not) seems to have deadlocked WSL2. No wsl.exe commands - not --list, --status, --shutdown, and some others I tried - would do anything. Command just "hung" until Ctrl+C. I'm using the Windows Store version of the linux kernel.

For me it continues to happen even after all updates, incl windows update, pwsh update and so on. At the same time, the same issue happens with Skype installed through MS Store. After I switched to Skype for Desktop, it is now only the WT that crashes during sleep. And I talk about sleep, not hibernate:
❯ powercfg /a
The following sleep states are available on this system:
    Standby (S0 Low Power Idle) Network Connected

Skype (from MS Store) does crash because it keeps the icon in the notification area, just as if process was killed and did not clean up the resources properly.
Actually, it would be interesting to try WT with cmd shells, no pwsh. Will try that. But at the same time, I have wizterm open and it never crashes. So it seems to me like there is something related to the apps installed from MS Store. I tried disabling developer mode, but that did not help (there are some advices on how to do that).

@DHowett even after downgrading to PowerShell 7.3.2 the problem still happened i.e., that might laptop went to sleep and when I woke it up, wt.exe was closed. Seems like it happened around the time the laptop would've entered S1 given the .NET Runtime application log event.
I'm also seeing a lot of the TextInputHost.exe crashes, though whether it's the cause or a symptom I couldn't say. But lots of them I hadn't noticed before.
@wisemanny what OS/version are you on?

Hmmmm... Terminal 1.16 didn't have the conpty lifetime changes in it... does it?

Should this bug be reopened, or should I open a new one if this might be a different cause?

I'll reopen it for now. Thanks for all the info, and sorry it's persisted!

@wisemanny what OS/version are you on?

WindowsProductName WindowsVersion OsHardwareAbstractionLayer

Windows 10 Pro     2009           10.0.22621.819

I posted this to another issue (https://github.com/microsoft/terminal/issues/12513)
Maybe this can be helpful, I used DebugDiag tool to try to get dump upon WT termination, but in the log I see such exceptions (I can provide the complete file):
1 ***********************
  2 *  EXCEPTION DETAILS  *
  3 ***********************
  4
  5 DetailID = 1
  6     Count:    2
  7     Exception #:  0X000006BF
  8     Stack:
  9         KERNELBASE!RaiseException+0x6c
 10         RPCRT4!RpcRaiseException+0x50
 11         RPCRT4!RpcRaiseException+0x14
 12         RPCRT4!NdrSendReceive+0x66
 13         RPCRT4!NdrClientCall3+0xc6a
 14         RPCRT4!NdrClientCall3+0xeb
 15         AppXDeploymentClient!Ordinal1+0x32e3
 16         AppXDeploymentClient!VerifyPackage+0x2b
 17         AppExtension!<lambda_b1ef69a29c93702515289cac97ab3bfc>::operator()+0x3f
 18         AppExtension!Windows::Internal::COperationLambdaVar<0,<lambda_b1ef69a29c93702515289cac97ab3bfc>,Windows::Internal::CMarshaledInterfaceResult<Windows::Storage::IStorageFolder> >::Run+0x23 19         AppExtension!Windows::Internal::AsyncOperation<Windows::Foundation::IAsyncOperation<Windows::Storage::StorageFolder * __ptr64>,Windows::Foundation::IAsyncOperationCompletedHandler<Window    s::Storage::StorageFolder * __ptr64>,Windows::Internal::CMarshaledInterfaceResult<Windows::Storage::IStorageFolder>,Windows::Internal::ComTaskPoolHandler,Windows::Internal::INilDelegate,Microsof    t::WRL::AsyncOptions<-1,0,&GUID_CAUSALITY_WINDOWS_PLATFORM_ID,2> >::_Run+0xfa
 20         AppExtension!Windows::Internal::AsyncOperation<Windows::Foundation::IAsyncOperation<Windows::Storage::StorageFolder * __ptr64>,Windows::Foundation::IAsyncOperationCompletedHandler<Window    s::Storage::StorageFolder * __ptr64>,Windows::Internal::CMarshaledInterfaceResult<Windows::Storage::IStorageFolder>,Windows::Internal::ComTaskPoolHandler,Windows::Internal::INilDelegate,Microsof    t::WRL::AsyncOptions<-1,0,&GUID_CAUSALITY_WINDOWS_PLATFORM_ID,2> >::Run+0x69
 21         shcore!WorkThreadManager::CThread::ThreadProc+0x26a
 22         shcore!WorkThreadManager::CThread::s_ExecuteThreadProc+0x22
 23         shcore!<lambda_9844335fc14345151eefcc3593dd6895>::<lambda_invoker_cdecl>+0x11
 24         KERNEL32!BaseThreadInitThunk+0x1d
 25         ntdll!RtlUserThreadStart+0x28

There are a few more:
1 DetailID = 2
  2     Count:    1
  3     Exception #:  0XE06D7363
  4     Stack:
  5         KERNELBASE!RaiseException+0x6c
  6         ucrtbase!CxxThrowException+0x9a
  7         Bcp47Langs!Bcp47Normalize+0xfe5c
  8         Bcp47Langs!NormalizeLanguageTag+0x81
  9         Bcp47Langs!ApplicationLanguages::GetApplicationLanguageOverride+0x58
 10         Bcp47Langs!GetApplicationLanguageOverride+0x43
 11         Windows_Globalization!Windows::Globalization::ApplicationLanguages::get_PrimaryLanguageOverride+0x11 [onecoreuap\base\win32\winnls\winrt\dll\applicationpreferences.cpp @ 44]
 12         TerminalApp!DllGetActivationFactory+0x1f150
 13         TerminalApp!DllGetActivationFactory+0x59c59
 14         TerminalApp!DllGetActivationFactory+0x425c4
 15         TerminalApp!DllCanUnloadNow+0xd7a6
 16         WindowsTerminal+0x3264c
 17         WindowsTerminal+0x8540
 18         WindowsTerminal+0x34d24
 19         WindowsTerminal+0x7d40
 20         WindowsTerminal+0x71d1
 21         WindowsTerminal+0xad97
 22         user32!DispatchMessageW+0x741
 23         user32!DispatchMessageW+0x3fc
 24         user32!IsRectEmpty+0x9a

and longer stack

and this one
  1 DetailID = 3
  2     Count:    1
  3     Exception #:  0XE06D7363
  4     Stack:
  5         KERNELBASE!RaiseException+0x6c
  6         ucrtbase!CxxThrowException+0x9a
  7         Bcp47Langs!Bcp47Normalize+0xfe5c
  8         Bcp47Langs!NormalizeLanguageTag+0x81
  9         Bcp47Langs!ApplicationLanguages::GetApplicationLanguageOverride+0x58
 10         Bcp47Langs!GetApplicationLanguageOverride+0x43
 11         Windows_Globalization!Windows::Globalization::ApplicationLanguages::get_PrimaryLanguageOverride+0x11 [onecoreuap\base\win32\winnls\winrt\dll\applicationpreferences.cpp @ 44]
 12         TerminalApp!DllGetActivationFactory+0x1f150
 13         TerminalApp!DllGetActivationFactory+0x59c59
 14         TerminalApp!DllGetActivationFactory+0x425c4
 15         TerminalApp!DllCanUnloadNow+0xd7a6
 16         WindowsTerminal+0x3264c
 17         WindowsTerminal+0x8540
 18         WindowsTerminal+0x34d24
 19         WindowsTerminal+0x7d40
 20         WindowsTerminal+0x71d1
 21         WindowsTerminal+0xad97
 22         user32!DispatchMessageW+0x741
 23         user32!DispatchMessageW+0x3fc
 24         user32!IsRectEmpty+0x9a
 25         ntdll!KiUserCallbackDispatcherContinue
 26         win32u!NtUserGetMessage+0x14
 27         user32!GetMessageW+0x2a
 28         InProcessClient64+0x97516
 29         InProcessClient64+0x97455
 30         WindowsTerminal+0x6877
 31         WindowsTerminal+0xef62
 32         KERNEL32!BaseThreadInitThunk+0x1d
 33         ntdll!RtlUserThreadStart+0x28

Huh. That's a weird stack for sure. The call to AppLogic::_ApplyLanguageSettingChange (which is where we call into get_PrimaryLanguageOverride) is wrapped in a try/catch, so I wouldn't expect that to be able to crash the Terminal. The StorageFolder one is a little trickier, I can't put my finger on that one exactly. Both of those are places that are likely to crash when the Terminal is running unpackaged, but that seems unlikely if the Terminal was installed from the Store.
Perhaps this is just that PLM/{someone} bug that recently regressed and got really aggressive at killing the Terminal (and other packaged apps), and the stack just so happened to be there when the Terminal got taken down.

According to winget, I did install WT on this machine where it's crashing directly via the MSIX. Store takes forever to make updates available - even a week after release announcement, at times - so I guess I got impatient and upgraded via winget. I can uninstall and re-install from the Store, but at this point it seems better to leave it in this state and help find the bug. I talked with @DHowett offline and will trace pwsh.exe and OpenConsole.exe.

I think mine was installed from the github, but for sure it was updated via winget. I am attaching the complete log files from the debugdiag tool just in case. I set it up now to log all exceptions from openconsole, pwsh and wt. If those may be helpful I am happy to send a attach a copy of them as well.
[WindowsTerminal__PID__8516__Date__03_12_2023__Time_11_26_52AM__841__Log.txt
WindowsTerminal__PID__26980__Date__03_12_2023__Time_06_18_06PM__772__Log.txt
](https://github.com/microsoft/terminal/files/10966003/WindowsTerminal__PID__8516__Date__03_12_2023__Time_11_26_52AM__841__Log.txt)

I notice this on my Surface Pro 9 (SQ3) but not on my Lenovo Intel machines

I am going to collect a new set of logs and attach "powercfg /sleepstudy" report as well. It would be interesting to see with what sleep event it coincides with.

OK, so some observations.

These are the timings of the sleep events

Time
Dur
State
Reason

12:27:46
0:00:00
Screen Off
Lid

12:27:46
0:06:28
Sleep
Transition To Sleep

12:34:14
0:00:48
Active

OpenConsole and WT processes terminated at 12:27:48, but pwsh terminated at 12:34:25. I.e. WT and OpenConsole closed right after sleep event, pwsh died when windows went back to Active state (after log in, thus 10s delay). I think that explains that pwsh cannot read from the channel - meaning OpenConsole is gone so it crashes.

wt_openconsole_pwsh.zip

@wisemanny nice analysis, and confirms what I was thinking given the pwsh termination message, "Cannot read keys when either application does not have a console or when console input has been redirected."

Yesterday came out KB5023778, so far looks like the issue is fixed. I will continue observing.


[3.x] Alternative way to execute commands

Currently commands are restricted to beyond:make:command {schema}. We should provide an alternative way since not everybody is used to "Laravel Beyond CRUD" and may not know the schema.

php artisan beyond:make:model should ask for Domain and Class Name and creates a class based on these information

This could be also enhanced with autocompletion or multiple choice questions based on the existig Domains and Apps.

Thank you for your contribution. We also thinking about these two options. 🙌

@regnerisch I did not find any issues in beta version. I think we are ready to publish and close this issue.

I would like to do a final test and also solve #35.

This will be implemented in 3.0.0.


make roach icons on docs landing page responsive

On mobile and tablet, the critters should stack vertically.
http://www.cockroachlabs.com/docs/
cc: @knz

Fixed.


milestone 2 feedback

Awesome work!
tiny issue:

readme file: please use rmarkdown features to make it look better. for example, check how to edit things that are code (inline or as a chunk of codes to run). for example here

Thanks! We have done so :)


Algolia

Replace simple JSON search with Algolia

Deploy preview for vibrant-yonath-a27de1 ready!
Built with commit 593610f62764051df7ece5a7a2b37327c4f46b96
https://deploy-preview-10--vibrant-yonath-a27de1.netlify.com


campaign update price

When i using you API update campaign price always shows me   following error message:
{
"message": "["Campaign pricing minimum CPM price for Afghanistan is 0.500€."]"
}
My test update campaign data is following , campaign is target by country Afghanistan only with some carrier.
"pricing": {
"model": 2,
"price": 1.2
},

Hi @larrygrandslammedia, the issue with the above code is that the price parameter should be written in cents. To get a value of €1.2 euro we would need "price": 120. We hope this helps.
We have checked the documentation and identified that we do not clearly explain the format, which we will update as a result.

Thanks for help, cents works. Does the possible update campaign api can provide update "Marketing Material" function. it will be great for us.

@larrygrandslammedia: The ability to manage assets is coming very soon in an upcoming API release.
Closing issue.


PHP extension PECL swoole

@navarr
Adobe Commerce Cloud uses PHP extension swoole, not openswoole
https://experienceleague.adobe.com/en/docs/commerce-operations/performance-best-practices/concepts/application-server
https://developer.adobe.com/commerce/php/development/components/app-server/

https://github.com/AdobeDocs/commerce-operations.en/pull/126
https://github.com/AdobeDocs/commerce-operations.en/pull/126

https://github.com/markshust/docker-magento/blob/83d238aa7cb843edd1b4e01c361e1e285487fdfc/images/php/8.3/Dockerfile#L46

@bap14 I see you approved this.  Just want to double check that you've considered it against the reason you brought in OpenSwoole and that this'll be fine.
If you're on board with that, feel free to merge it!

@navarr I didn't really have a particular reason to use openswoole vs swoole. I have no issues swapping it from openswoole to swoole. I did read up on the controversy around swoole and openswoole, and the supposed security issue, and feel it's been settled. I approved it after doing some reading up on that.

@navarr, @bap14, as swoole is being used by Adobe Commerce, GraphQL Application Server, also I had to opportunity to use https://github.com/swoole/library, https://wiki.swoole.com/en/#/coroutine/coroutine?id=functions, coroutine > batch for an specific task of custom xml feed and processed faster rather than not using it, swoole is a great PHP extension for event-driven, asynchronous, non-blocking I/O model.


[bug]: VERSION 3.0 CANNOT GENERATE IMAGES ON UNIFIED CANVAS WHEN GIVEN A SEED NUMBER

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
6GB
What version did you experience this issue on?
3.0
What happened?
I WANT TO MODIFY AND EXTEND PARTS OF IMAGES ON UNIFIED CANVAS. I USED PREVIOUSLY GENERATED IMAGES AND NEED TO FIX ERRORS AND EXTEND THE IMAGE SIZE. I USED TO DO IT FINE WITH VERSION 2.  I WANT TO GENERATE 5 TO 10 IMAGES AND SELECT THE BEST.
NOW WHEN I USE THE SEED NUMBER IS NOT ABLE TO GENERATE AN IMAGE. GETS STUCK.
I HAPPENS EVERY TIME THAT I WANT TO USE A FIX SEED.
Screenshots
Exception in thread invoker_processor:
Traceback (most recent call last):
File "C:\Users\aferl\AppData\Local\Programs\Python\Python310\lib\threading.py", line 1016, in _bootstrap_inner
self.run()
File "C:\Users\aferl\AppData\Local\Programs\Python\Python310\lib\threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File "C:\Users\aferl\invokeAI7.venv\lib\site-packages\invokeai\app\services\processor.py", line 50, in __process
self.__invoker.services.graph_execution_manager.get(
File "C:\Users\aferl\invokeAI7.venv\lib\site-packages\invokeai\app\services\sqlite.py", line 79, in get
return self._parse_item(result[0])
File "C:\Users\aferl\invokeAI7.venv\lib\site-packages\invokeai\app\services\sqlite.py", line 52, in _parse_item
return parse_raw_as(item_type, item)
File "pydantic\tools.py", line 82, in pydantic.tools.parse_raw_as
File "pydantic\tools.py", line 38, in pydantic.tools.parse_obj_as
File "pydantic\main.py", line 341, in pydantic.main.BaseModel.init
pydantic.error_wrappers.ValidationError: 1 validation error for ParsingModel[GraphExecutionState]
root -> execution_graph -> nodes -> 51cca1bf-6f28-4e21-a4be-782973399642 -> InpaintInvocation -> seed
ensure this value is less than or equal to<PHONE_NUMBER> (type=value_error.number.not_le; limit_value=2147483647)
INFO:     <IP_ADDRESS>:50000 - "GET /api/v1/images/c58f8638-2552-4dc4-82e9-c83be27a53ec.png HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50000 - "GET /api/v1/images/c58f8638-2552-4dc4-82e9-c83be27a53ec.png/full HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50001 - "DELETE /api/v1/sessions/f59839a4-1e32-4629-8e66-501adf016a87/invoke HTTP/1.1" 202 Accepted
INFO:     <IP_ADDRESS>:50002 - "POST /api/v1/images/?image_category=general&is_intermediate=true HTTP/1.1" 201 Created
INFO:     <IP_ADDRESS>:50002 - "POST /api/v1/images/?image_category=mask&is_intermediate=true HTTP/1.1" 201 Created
INFO:     <IP_ADDRESS>:50002 - "POST /api/v1/sessions/ HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50002 - "PUT /api/v1/sessions/3fc988b9-4157-455e-9c91-9f1cd379a17c/invoke?all=true HTTP/1.1" 202 Accepted
INFO:     <IP_ADDRESS>:50003 - "DELETE /api/v1/sessions/3fc988b9-4157-455e-9c91-9f1cd379a17c/invoke HTTP/1.1" 202 Accepted
INFO:     <IP_ADDRESS>:50004 - "GET / HTTP/1.1" 304 Not Modified
INFO:     connection closed
INFO:     <IP_ADDRESS>:50004 - "GET /socket.io/?EIO=4&transport=polling&t=OdBkKlX HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50004 - "GET /api/v1/images/e5d8e1e5-b1c9-4d33-9e73-e2e384d3dbce.png HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50005 - "GET /api/v1/app/version HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50006 - "GET /api/v1/models/?model_type=embedding HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50007 - "GET /api/v1/boards/?all=true HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50008 - "GET /api/v1/models/?model_type=main HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50004 - "GET /api/v1/models/?model_type=controlnet HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50005 - "GET /api/v1/models/?model_type=lora HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50009 - "GET /api/v1/models/?model_type=vae HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50006 - "GET /api/v1/app/config HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50005 - "POST /socket.io/?EIO=4&transport=polling&t=OdBkKms&sid=aHg-OEz6n-o01V0mAAAE HTTP/1.1" 200 OK
INFO:     ('<IP_ADDRESS>', 50010) - "WebSocket /socket.io/?EIO=4&transport=websocket&sid=aHg-OEz6n-o01V0mAAAE" [accepted]
INFO:     connection open
INFO:     <IP_ADDRESS>:50009 - "GET /socket.io/?EIO=4&transport=polling&t=OdBkKmu&sid=aHg-OEz6n-o01V0mAAAE HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50009 - "GET /socket.io/?EIO=4&transport=polling&t=OdBkKoh&sid=aHg-OEz6n-o01V0mAAAE HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50009 - "GET /openapi.json HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50011 - "POST /api/v1/images/?image_category=general&is_intermediate=true HTTP/1.1" 201 Created
INFO:     <IP_ADDRESS>:50011 - "POST /api/v1/images/?image_category=mask&is_intermediate=true HTTP/1.1" 201 Created
INFO:     <IP_ADDRESS>:50011 - "POST /api/v1/sessions/ HTTP/1.1" 200 OK
INFO:     <IP_ADDRESS>:50011 - "PUT /api/v1/sessions/0ee8ca99-3a1b-4f4a-99a9-7efe359ee96b/invoke?all=true HTTP/1.1" 202 Accepted
Additional context
No response
Contact Details
No response

Are you using a seed greater than<PHONE_NUMBER>?

Yes! It started with 219 . Can remember the whole number now.
Is<PHONE_NUMBER> an upper limit for the seed?
Thank you for your reply

I believe it is as the moment - give a lower number a try and go from there!

thank you for your help


Updating readme by updating some sections and fixing some typo.

Links to the examples and reviewer info were updated. Getting Started and Running Examples sections were updated. Some typo were fixed.

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #737. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/737-202011111715090.17292308807373-911f065950ed94742d92024612347284d0916358/report/misspelling_result.txt.

:octocat: cibot: @meteozay, One of the module of prebuild group is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nntrainer/wiki/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/737-202011111717160.073678970336914-86efcd9ea468750085fc2c6d0e1830c8617a0653/report/misspelling_result.txt.

:octocat: cibot: @meteozay, One of the module of prebuild group is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nntrainer/wiki/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/737-202011111720440.5755820274353-6d56bb79f4189349d8950f373fbae1b8e9741a54/report/misspelling_result.txt.

:octocat: cibot: @meteozay, One of the module of prebuild group is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nntrainer/wiki/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/737-202011111729360.48583793640137-82ef8c54bc9dc1fd89405042664d4e63b03aeca4/report/misspelling_result.txt.

:octocat: cibot: @meteozay, One of the module of prebuild group is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nntrainer/wiki/.


Only define ValueStorageMap::dump in DEBUG.

NFC

@swift-ci please benchmark

@swift-ci please test

Running benchmarks just because that's a place where the build failure can be seen currently.  ( https://ci.swift.org/job/swift-PR-macos-perf/91/consoleText )

Benchmark still fails with
/Users/ec2-user/jenkins/workspace/swift-PR-macos-perf/swift/lib/SILOptimizer/Mandatory/AddressLowering.cpp:369:23: error: out-of-line definition of 'dump' does not match any declaration in 'swift::ValueStorageMap'
but it is showing the old line number, indicating maybe that that is from attempting to build ndebug without this patch.

Merged to unblock CI


Update Wiki and Powershell installation file to remove the ReportViewer/CLR types prerequisite installation

Related to #140  and #273

Resolved
https://github.com/microsoft/SqlNexus/wiki/Installation#for-sql-nexus-version-7240218-and-later-the-following-must-be-installed-for-sql-nexus-to-function-properly


Implement DamageEntityEvent for armor stands.

Input wanted because armor stands don't use the regular health system for damage, but it seems like the regular damage system to users.
In vanilla:

Armor stands are immediately destroyed upon taking damage from the void or an explosion. I implement this by firing an event with a very large damage value (1000) and then changing it to fire damage if someone reduces it.
Armor stands take regular damage from fire, but use a custom method for that damage. I pass the damage specified for that through an event and then pull the final value back from the event.
Armor stands are usually destroyed from two punches or arrow hits from a player within 5 ticks of each other, but the first push or arrow hit does not affect the armor stand's health. For the first punch, I fire a damage event with 0 damage and then ignore the resulting value. For the second, I do the same procedure as explosions/void damage.

Fixes #1644.

I suppose we should handle boats and minecarts in some similar fashion as well.

I'm planning to do those entities as well once we decide on this (or something else) as precedent.

Armor stands are usually destroyed from two punches

I don't know if it's important but creative players will only need one hit.

@felixoi Right... forgot to implement that one. Should be up now.

Mahh, i found another bug.  All other entites (Cow, Zombie, etc.) will not die.

@Zidane Updated. I changed the base to stable-7 since there are no API breakages; let me know if this should be reverted.

Could we get this done somewhen in the near future?

Thanks for updating, I’ll review the injections, is it possible to make some of the slices use both to and from?


[Master] Update Keymanager compatibility

@Sarangan0219 , the removal of prepackaged WSO2 Identity Server as a Key Manager needs to be mentioned in the about this release page as well, because that this the common place that specifies what has changed in the release.

I created https://github.com/wso2/docs-apim/issues/2197 to track the last comment


Fixed implementation so that effort_controllers/GripperActionController works.

Fixed implementation so that effort_controllers/GripperActionController works.
Fixed #694

@bmagyar
Could you advise me on the merge request?
Is there any chance to merge?

Codecov Report

Merging #756 (e652475) into master (e7f9962) will decrease coverage by 4.90%.
Report is 362 commits behind head on master.
The diff coverage is 25.91%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   35.78%   30.88%   -4.90%
==========================================
  Files         189        7     -182
  Lines       17570      832   -16738
  Branches    11592      505   -11087
==========================================
- Hits         6287      257    -6030
+ Misses        994      133     -861
+ Partials    10289      442    -9847

Flag
Coverage Δ

unittests
30.88% <25.91%> (-4.90%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...ontroller/test/test_load_diff_drive_controller.cpp
11.11% <0.00%> (ø)

...ive_controller/test/test_diff_drive_controller.cpp
12.66% <7.81%> (ø)

diff_drive_controller/src/odometry.cpp
42.16% <11.11%> (ø)

diff_drive_controller/src/speed_limiter.cpp
46.55% <11.11%> (ø)

...iff_drive_controller/src/diff_drive_controller.cpp
47.13% <46.94%> (ø)

...de/diff_drive_controller/diff_drive_controller.hpp
100.00% <100.00%> (ø)

...troller/include/diff_drive_controller/odometry.hpp
100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

I opened a new issue for adding tests. @bmagyar can we backport this to humble?


Bech32 to address

Add Contract.Address.addressWithNetworkTagFromBech32 :: String -> Maybe AddressWithNetworkTag and Contract.Address.addressFromBech32 :: String -> Contract r (Maybe String). The latter should assert that the network tag corresponds to the contract environment network id.

Is the type signature for the snd function correct? given the function name, shouldn't it return an Address


feat: Moved PA-accounts service to 121-service AB#8934

I think also a big chunk of changes to the CHANGELOG-file would need to be included in this branch/PR.
This would've been a good place to document big changes "over time" with separate commits etc...

See #2326


Added salesforce icon

Added salesforce icon.
Updated README to include running fontcustom from Docker. (I had some problems with installing fontcustom on MacOS Catalina via homebrew, so I found a way to do it using a docker container.

@smcllns Any feedback on this PR? Let me know if there's anything I can do to get it in a better state to accept. Thanks!

Looks great, thanks for contributing @xgp!


fix: use redis standalone

Description
This PR updates the internal package and factoryinsight, as well as the factoryinsight deployment, to address the changes to redis added in #1505
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Deployed
[x] CI

Checklist:

[ ] I have made corresponding changes to the documentation
[ ] I have made corresponding changes to the changelog (if needed).
[ ] I have made corresponding notices to the upgrade instructions (if needed)

Changelog changes
Upgrade instructions

Codecov Report

Merging #1516 (67aa404) into main (2b22e36) will increase coverage by 0.00%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main    #1516   +/-   ##
=======================================
  Coverage   11.11%   11.11%
=======================================
  Files          31       31
  Lines        9842     9839    -3
=======================================
  Hits         1094     1094
+ Misses       8690     8687    -3
  Partials       58       58

Impacted Files
Coverage Δ

golang/internal/cache.go
0.80% <0.00%> (+<0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


enable feature gate for registration webhook

Signed-off-by: ldpliu<EMAIL_ADDRESS>

@ldpliu would you also check the rbac permission of the registration controller

@ldpliu would you also check the rbac permission of the registration controller

Yes, we already have clusterset create permission in both registration and registrition-operator

/approve
/lgtm

/hold

/lgtm

/unhold


Update CommandBarFlyout close and open animations.

I've updated the CommandBarFlyout's close and open animations to be an 83ms opacity animation, instead of the previous clip animation.

/azp run

/azp run

/azp run

/azp run

I've updated the CommandBarFlyout's close and open animations to be an 83ms opacity animation, instead of the previous clip animation.

So no more slick and smooth resizing (grow and shrinking), we are just going to fade in and out of view now?
EDIT: Or are we fading out the shadow before resizing the CommandBarFlyout?

Checked the latest commit, and the main entrance animation is now a fade.
Whilst I understand it was felt this change was needed, it is unfortunate.  But now it begs the question, what about the Menu Flyouts, these still have a slide and resize animation.  Do these change too, or is CommandBarFlyout a special case that needed dealing with?
Also what about the entrance animations for CalendarView Flyout, Date and Time picker flyouts?


Secure WebSocket gives a connection reset by peer response

We need to add TLSv1.1,TLSv1.2 to SecureWebSocketInboundEndpoint.xml.
In addition, in order to call a secured web socket endpoint, having the server's public certificate is sufficient. We need remove the parameter  "wss.ssl.trust.store.file" from the SecureWebSocketInboundEndpoint.xml as well.


More helpful type errors

Often unification fails on the last stretch, being almost finished. This leads to unhelpful error messages like "A = B but it should be A = B". I am not sure if this is a race condition, but I have seen a lot of these errors. Also, type errors could be more helpful in general.

I think the right approach here is to work on the "human-readable language", to output the full program with the current state of inferred types, and the error line highlighted somehow.
Trying to output isolated error messages that somehow capture a type inference error is hopeless because of how incredibly non-local type inference is.

We should experiment to see if the way we use unification arrows results in weird error messages.

Type variables get names of the form disconnect_b_10 where disconnect is the combinator type, b is the type variable of disconnect (from the tech report) and 10 is an index. The index is different for each variable, so it can be that the same disconnect has variables disconnect_b_10 and disconnect_c_42. We should try to give all variables of the same combinator the same index. Ideally, the nodes in question are shown with their index when there is an error.
Many types are also copied from existing arrows. We could use this to construct a provenance graph that captures where the type bound originally comes from. This can help users understand why a type became what it is.