macOS 12.0.1 & Kap 3.4.1: Camera is not showing up when recording and camera video is not getting recorded

macOS version:        12.0.1
Kap version:          3.4.1
Step to reproduce:    Activate the Camera Plugin, start the recording
Current behavior:     The camera window is not showing up when recording neither is the camera recorded when playing back the recorded video.
Expected behavior:    The camera window is showing up while recording and the image of the camera is actually getting recorded.
Workaround:           none

This sounds like an issue with permissions, I'd check in your Security & Privacy preferences to ensure Kap is allowed access to your camera. If that doesn't resolve it, please open the issue in the kap-camera repository: https://github.com/karaggeorge/kap-camera

@skllcrn thank you, already checked permissions but this doesn't resolve the issue. I will open an issue in the kap-camera repo.


nixpkgs manual: add an alternative example in stdenv-separateDebugInfo

This change gets rid of the indirect reference to nix-env -i usage and shows how to achieve the same goal with a shell expression.
Closes #255130
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@fricklerhandwerk I applied all your proposals. The example rendering looks a bit wonky but I guess this can improve in future iterations of the documentation renderer.

For me this weird underline only appears when hovering the mouse. Yeah, that needs an independent fix. Thanks a lot!


Containerless Kantra Distribution for Java Analysis

Closes #188

"I think this genuinely improves on what I've heard previously discussed. I do somewhat wonder what prevents us from creating a new command altogether (separate go module) and whether that may give us some more flexibility even if in the same repository."
@djzager This is an interesting idea. It would make it more light-weight as well if we do not have to build the entirety of kantra for this distribution. I'd be curious to know what others think @pranavgaikwad @shawn-hurley


DateTimes not being scrubbed by default

Describe the bug
DateTimes are supposed to be scrubbed by verify by default. Whatever I try though they are not being scrubbed. Tried adding extra formats to cover them but even then it does not work.
Minimal Repro
If I have configured no global or local Verify settings and I run this:
await Verifier.Verify(DateTime.Now.ToString("F"));
I get the then unscrubbed date:
15 December 2023 16:43:58

root objects are not scrubbed. since it makes no sense to have a verified file with the only content being scrubbed.
If you nest it, it will be scrubbed
await Verifier.Verify(
    new
    {
        Value = DateTime.Now.ToString("F")
    });

@SimonCropp Ok, my apologies looks like I went too far in my simplification of the perceived issue. My problem is not with a datetime as a root level object but with an HTML table where a cell (td) contains a date time. Basically I am wanting to verify a web page that contains a date time in the HTML but I do not know what the datetime will be and was expecting it to be scrubbed as per the documentation. So for example:
VerifyAngleSharpDiffing.Initialize();

var html = @"
    <!DOCTYPE html>

        Company
        Contact
        Country
        Date
        Guid

        Alfreds Futterkiste
        Maria Anders
        Germany
        15/12/2023 16:43:58
        b1c6cba5-de16-430b-9c01-6271443e7cd4

        Centro comercial Moctezuma
        Francisco Chang
        Mexico
        12/04/2023 11:41:58
        71727c10-9643-43e9-bdac-a4e55cf74450

    ";

await Verifier.Verify(html, "html").PrettyPrintHtml();

This will NOT scrub the date times in those cells. Is that your expectation? Perhaps date times inside strings are not supposed to be scrubbed. The Guids in the next column are not scrubbed either.
Interestingly though if I instead verify it as:
await Verifier.VerifyXml(html);
Then the Guids and date times are scrubbed.
If all is working as it should am I perhaps wanting to do something odd? Would supporting this be a bad idea? I guess for now at least I can implement some kind of custom scrubber.

you can scrub inline guids https://github.com/VerifyTests/Verify/blob/main/docs/serializer-settings.md#snippet-scrubinlineguids
i have not implemented scubbing of inline dates due to the perf impact. essentially do a tryparse on every combo of characters in a large string

@SimonCropp thanks. For me the performance is not going to be an issue as other components of my tests are orders of magnitude slower so this would go unnoticed. If this feature were disabled by default then is there really any harm in having it? Perhaps if developers had to define specific date time formats it could be faster with specific defined Regex patterns for those formats rather than just looking for absolutely everything as above. Anyway thanks for your help

@MJB222398 fare enough. try this   https://github.com/VerifyTests/Verify/blob/main/docs/dates.md#inline-dates

@SimonCropp I'm not seeing the global methods on VerifierSettings.

have u updated to the latest nuget?

have u updated to the latest nuget?

Yes, I'm on 22.10.1.
I do see the methods on SettingsTask and VerifySettings, but not the static methods in VerifierSettings.

sigh. yeah i screwed up. new release incoming

try 22.10.2. pending nuget updating

Thanks for adding it.
When I tested the SettingsTask version earlier, I could swear that it replaced the date with {Scrubbed}, but unfortunately it's using the DateTimeOffset_1 format, so I won't be able to use this feature. (ref)
Maybe a future change could be to allow the replacement string to be specified, for example:
VerifierSettings.ScrubInlineDateTimeOffsets("yyyy-MM-ddTHH\\:mm\\:ss.fffK", replaceWith: "{Scrubbed}");


Sort out unit tests

They seem to be failing. We also needs a button at the top of readme.  I'm not gonna institute coveralls, but at least some set of minimal unit tests.

Now fixed with spherical_sim merge.


Add the command to determine whether the system has netstat

Description
Add the command to determine whether the system has netstat，Can automatically select commands on the system for log prompt output.

Related issues/PRs
fixes  #8653
Todos

[x] Tests
[x] Documentation
[x] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Thanks for the PR! I have suggested a cleaner way to do this

This method is just a modification of the current code, which I think is reasonable. If you need to modify it, I can submit it according to the content of my screenshot

/sem-approve

@caseydavenport
This is my first time to contribute to Calico. I am not sure how to solve this CI part. Please tell me how to solve this problem.

The CI is complaining that the diags.go file is "dirty"
make check-dirty01:47
make[1]: Entering directory '/home/semaphore/calico'01:47
The following files are dirty01:48
 calicoctl/calicoctl/commands/node/diags.go | 22 +++++++++++-----------01:48
 1 file changed, 11 insertions(+), 11 deletions(-)01:48
make[1]: *** [lib.Makefile:1125: check-dirty] Error 101:48
make[1]: Leaving directory '/home/semaphore/calico'01:48
make: *** [Makefile:41: ci-preflight-checks] Error 2

CI runs a code formatter to make sure that the code is following standard formatting rules and it seems like something is being picked up here.
Looks like it's 22 lines, which means it's probably all of the lines of code. My guess is that it's complaining about tabs instead of spaces?

Removing "merge-when-ready" label due to new commits

@caseydavenport
I have replaced all tab characters, please continue to review.

/sem-approve

Removing "merge-when-ready" label due to new commits

@caseydavenport
I don’t know how to modify it anymore. The places I modified are now not tab characters.

/sem-approve

Removing "merge-when-ready" label due to new commits

Hi @caseydavenport
I confirmed that there are no tab characters.
Please continue to review。

/sem-approve

Hopefully that's it! If not I will try to reproduce locally :crossed_fingers:

@caseydavenport
Is it possible that the standard just uses tab characters?
Because I ran the command below to check that all other files contain tab characters.

I've reverted the code to its original submission state. I'm hoping you can assist me in pinpointing where the formatting issue lies. The CI check failed at the same position because the modified code lacks tab characters.

@opencmit2 thanks for sticking with this - I put up a fork of this PR and merged it here: https://github.com/projectcalico/calico/pull/8725
I think it was actually extra spaces at the end of the line that was the problem.


Add a search box to Run and Debug view for searching launch configurations

it will be inconvenient if you have many launch configurations. have to look for each items in drop down list painfully.
would it be nice to have a  search box for it?

That would be almost the same as the command Debug: Select and Start Debugging (workbench.action.debug.selectandstart) but without starting. It might be good enough for you tho.
A version of the same command without starting would be good enough for me and nice to have in the meantime.


Added German Translation

I really love this editor and so I want to support as well bring forward
this lovely editor!
So I made a translation for German.
I now have an enconding issue with the following letters:
öäüÖÄÜß
I don't find a way to fix this issue, I holp someone can help me ;)

Thanks!

By the way please test if the text is to long in some place. I couldn't tested it, because my Windows is set to English and I don't know how to change it for this application explicit ;)


Fix uppercase from_secrets

Secret names where matched based on their lowercase value already just the conversion to lowercase for from_secrets was missing.

Codecov Report

Merging #842 (f9ef9b2) into master (80c72b5) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   51.76%   51.68%   -0.09%
==========================================
  Files          80       80
  Lines        6054     6054
==========================================
- Hits         3134     3129       -5
- Misses       2741     2746       +5
  Partials      179      179

Impacted Files
Coverage Δ

server/logging/log.go
48.83% <0.00%> (-5.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49e2fd...f9ef9b2. Read the comment docs.

please backport ;)

I will try to fix the image filtering in from_secret first and then backport both to 0.15


iOS and android use the same js

now，i pod react in my iOS project.i user the url http://localhost/index.ios.boundle.
can i use like this  http://localhost/index.boundle,which iOS and android use it both.

git grep for index.ios.js and change all references to index.js. In the future please use Stack Overflow and tag your question with react-native for asking these kinds of questions: http://stackoverflow.com/questions/tagged/react-native
Many people from the community hang out on Stack Overflow and will be able to see and likely also answer your question. Using Stack Overflow for questions also helps us use Github issues to keep track of bugs that need to be fixed.

thanks.


plugin freezes during scanning

Hello,
during scanning of one component of our java application, the plugin is freezing. We try dependency check cli and Jenkins plugin and the result is the same. After 30 minutes, scanning ends with an error "[ERROR] Analysis task was cancelled."

Logfile in attachments
logs.txt

Looking at the log - things don't make sense to me...  In that we have:
2020-09-30 18:11:14,815 org.owasp.dependencycheck.data.nvdcve.CveDB:412
DEBUG - Entering finalize
2020-09-30 18:41:14,638 org.owasp.dependencycheck.Engine:1159
ERROR - Analysis task was cancelled.

CveDB line 412 is just calling some fairly straightforward resource cleanup. I just added a bunch more logging that will be included in 6.0.3.

I have rerun scanning with the 6.0.3 plugin version. Logs in attachments
debug.log

This looks to be getting hung on bundle.js with the RetireJS analyzer. My guess is bundle.js is a fairly large file?
There is a hard 30 minute timeout that can be extended:
export JAVA_OPTS='-Dodc.analysis.timeout=90'

This looks to be getting hung on bundle.js with the RetireJS analyzer. My guess is bundle.js is a fairly large file?
There is a hard 30 minute timeout that can be extended:
export JAVA_OPTS='-Dodc.analysis.timeout=90'


Permission denied on RHEL based OS

After installing the LPP and initializing the PVC with pod, I receive an error for directory creation via helper:
mkdir: can't create directory '/data/local-path-provisioner/pvc-7a3c3fd8-6564-4bd6-a655-8a967e000a4b_default_volume-test-pvc': Permission denied

To fix it, I had to give SELinux attribute to the directory with command:
chcon -Rt container_file_t  /data/local-path-provisioner

I have seen several issued for the same error, but none of them related to the chcon command and RHEL based distributions like Fedora.

you saved me a lot of time!

Tried to be as clear as possible:) nice to hear that it helped🫶


Removing admin_password_for_smoketest to use admin_password

Currently the deployment fails because the spec file is providing a variables it's not setting.
This PR removes that provides references and then modifies the smoke test to just use the admin password.

Please do not remove the admin_password_for_smoketest,  add parameter in deployment manifest yml like that:
instance_groups:
- name: harbor-app
  azs: [az-1]
  instances: 1
  jobs:
  - name: harbor
    release: harbor-container-registry
    properties:
      hostname: ((hostname))
      db_password: ((harbor_db_password))
      admin_password: ((harbor_admin_password))
      admin_password_for_smoketest: ((harbor_admin_password))
      clair_db_password: ((clair_db_password))
      with_clair: true
      with_notary: true


Friendlier SQL encoding for google wrappers

We've forked this library to add some automatic conversion for google's wrapper types/timestamps such that they get encoded as more SQL-friendly types. For example google.protobuf.Int32Value is represented as an IntegerType rather than a StructType with a nested value (enabling SELECT my_int_field instead of SELECT my_int_field.value). This is a workaround so that we can preserve NULLability but not require the manual unwrapping at query time. Additionally we encode google.protobuf.Timestamp as a TimestampType so that the SQL date functions work natively without converting in the query.
@thesamet is this something you'd welcome as a PR (gated behind an option)?

Sounds great. would be interested in seeing a PR. Thank you!

I added a change that supports better encoding for primitive wrappers. It is now optional, but will become the default on 0.11.x.

@thesamet awesome! Sorry that I never found the time to port over our solution.


AsPath and Community Test

Pull Request Functional Test Report for #2751 / 0f732fe87106462f3b9e7fef098f0844bf2a387f
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set
deb84bee
Log

Cisco 8000E

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set
9f1cbb38
Log

Cisco XRd

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set
6673695a
Log

Juniper ncPTX

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set
67b45c16
Log

Nokia SR Linux

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set
16042f3a
Log

Openconfig Lemming

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set
b5b483e0
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set

Cisco 8808

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set

Juniper PTX10008

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set

Nokia 7250 IXR-10e

RT-7.4: BGP Policy AS Path Set and Community SetRT-7.2: BGP Policy Community Set

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.102%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1729

Relevant Lines:
3256

💛  - Coveralls


Make OnCheckEscape apply to all human classes, including Guards, Cadets, Lieutenants, and Commanders

I wrote an OnCheckEscape method that is supposed to allow Facility Guards to escape the facility to become cadets, and Cadets to become Lieutenants and Lieutenants become Commanders if they are Patreon supporters.
Is this possible, or does the server only run OnCheckEscape for d-class and scientists? Would it be possible to make this apply to all humans?
		public void OnCheckEscape(PlayerCheckEscapeEvent ev)
		{
			switch (ev.Player.TeamRole.Role)
			{
				case Role.FACILITY_GUARD:
					ev.ChangeRole = Role.NTF_CADET;
					ev.AllowEscape = true;
					break;

				case Role.NTF_CADET:
					if (this.plugin.rewardTiers[3].Contains(ev.Player.SteamId) ||
						this.plugin.rewardTiers[4].Contains(ev.Player.SteamId) ||
						this.plugin.rewardTiers[5].Contains(ev.Player.SteamId))
					{
						ev.ChangeRole = Role.NTF_LIEUTENANT;
						ev.AllowEscape = true;
					}
					break;

				case Role.NTF_LIEUTENANT:
					if (this.plugin.rewardTiers[3].Contains(ev.Player.SteamId) ||
						this.plugin.rewardTiers[4].Contains(ev.Player.SteamId) ||
						this.plugin.rewardTiers[5].Contains(ev.Player.SteamId))
					{
						ev.ChangeRole = Role.NTF_COMMANDER;
						ev.AllowEscape = true;
					}
					break;
			}
		}

Escape detection is mostly clientside afaik

Yeah, the client runs CharacterClassManager.CallCmdRegisterEscape() from Escape.EscapeFromFacility() when it gets within the escape zone and is an escapable class which triggers the server-side check. We could modify server-side to support it but it'll just like scp173_ignored_roles: requires client-side modification to truly work.

Thanks for the input guys! I'll see if I can ask the devs for it.


USB Support

Implements issue #3.
May need to review LocalStorageDeviceViewModel.LoadDetailsAsync(); It doesn't get data from USB devices currently.

Let me run what's done and I will approve and then we can make new issues.


Bad inputs (same character used for two meanings)

Some bad inputs cannot be handled reasonably, or may need a lot of care to handle correctly.  Examples are mainly if things like quote, delimiter, or comment have the same character, their order must be either defined or an error raised.  In some cases defining the order may be hard or impossible (e.g. a multi-character quote that starts with a delimiter).
We should probably write some tests for this, make almost all of them errors and then see if there are some reasonable ones that loadtxt currently handles correctly and that we should worry about.

My current plan: Wait on tests and see what the fallout is, then fix up whatever is necessary.


Remove PHPStan ignoreErrors: Unsafe usage of new static()

Description
Removes PHPStan ignoreErrors: Unsafe usage of new static().
See https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

I thought this is okay, but PHP 7.3 complains:

Fatal error: Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0, ?Throwable $previous = NULL) in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16
S
https://github.com/codeigniter4/CodeIgniter4/pull/4357/checks?check_run_id=1992185571

$<EMAIL_ADDRESS>vendor/bin/phpstan analyse
Note: Using configuration file /Users/kenji/work/codeigniter/CodeIgniter4/phpstan.neon.dist.
 372/372 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 -- --------------------------------------------------------------------------------------------------------------
     Error
 -- --------------------------------------------------------------------------------------------------------------
     Child process error (exit code 255):
     Fatal error: Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16
     PHP Fatal error:  Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16

     Child process error (exit code 255):
     Fatal error: Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16
     PHP Fatal error:  Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16

     Child process error (exit code 255):
     Fatal error: Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16
     PHP Fatal error:  Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16

     Child process error (exit code 255):
     Fatal error: Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16
     PHP Fatal error:  Declaration of Error::__construct($message = NULL, $code = NULL, $previous = NULL) must be
     compatible with CodeIgniter\Exceptions\ExceptionInterface::__construct(string $message = '', int $code = 0,
     ?Throwable $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DatabaseException.php on line 16

 -- --------------------------------------------------------------------------------------------------------------

 [ERROR] Found 4 errors

This is breaking LSP?? Maybe we can set the defaults to null instead to be LSP-compliant in php 7.3

If I change the ExceptionInterface:
--- a/system/Exceptions/ExceptionInterface.php
+++ b/system/Exceptions/ExceptionInterface.php
@@ -22,5 +22,5 @@ use Throwable;

 interface ExceptionInterface
 {
-   public function __construct(string $message = '', int $code = 0, Throwable $previous = null);
+   public function __construct($message = null, $code = null, $previous = null);
 }

$<EMAIL_ADDRESS>vendor/bin/phpstan analyse
Note: Using configuration file /Users/kenji/work/codeigniter/CodeIgniter4/phpstan.neon.dist.
 -- ------------------------------------------------------------------------------------------------------------------
     Error
 -- ------------------------------------------------------------------------------------------------------------------
     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Encryption\Exceptions\EncryptionException::__construct(string $message =
     '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Encryption/Exceptions/EncryptionException.php on line 21
     PHP Fatal error:  Declaration of CodeIgniter\Encryption\Exceptions\EncryptionException::__construct(string
     $message = '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Encryption/Exceptions/EncryptionException.php on line 21

     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Exceptions\FrameworkException::__construct(string $message = '', int
     $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Exceptions/FrameworkException.php on line 22
     PHP Fatal error:  Declaration of CodeIgniter\Exceptions\FrameworkException::__construct(string $message = '',
     int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Exceptions/FrameworkException.php on line 22

     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Encryption\Exceptions\EncryptionException::__construct(string $message =
     '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Encryption/Exceptions/EncryptionException.php on line 21
     PHP Fatal error:  Declaration of CodeIgniter\Encryption\Exceptions\EncryptionException::__construct(string
     $message = '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Encryption/Exceptions/EncryptionException.php on line 21

     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Database\Exceptions\DataException::__construct(string $message = '', int
     $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DataException.php on line 17
     PHP Fatal error:  Declaration of CodeIgniter\Database\Exceptions\DataException::__construct(string $message =
     '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DataException.php on line 17

 -- ------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 4 errors

$<EMAIL_ADDRESS>vendor/bin/phpstan analyse
Note: Using configuration file /Users/kenji/work/codeigniter/CodeIgniter4/phpstan.neon.dist.
 -- ------------------------------------------------------------------------------------------------------------------
     Error
 -- ------------------------------------------------------------------------------------------------------------------
     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Exceptions\FrameworkException::__construct(string $message = '', int
     $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Exceptions/FrameworkException.php on line 23
     PHP Fatal error:  Declaration of CodeIgniter\Exceptions\FrameworkException::__construct(string $message = '',
     int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Exceptions/FrameworkException.php on line 23

     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Database\Exceptions\DataException::__construct(string $message = '', int
     $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DataException.php on line 23
     PHP Fatal error:  Declaration of CodeIgniter\Database\Exceptions\DataException::__construct(string $message =
     '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DataException.php on line 23

     Child process error (exit code 255):
     Fatal error: Declaration of CodeIgniter\Database\Exceptions\DataException::__construct(string $message = '', int
     $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DataException.php on line 23
     PHP Fatal error:  Declaration of CodeIgniter\Database\Exceptions\DataException::__construct(string $message =
     '', int $code = 0, ?Throwable $previous = NULL) must be compatible with
     CodeIgniter\Exceptions\ExceptionInterface::__construct($message = NULL, $code = NULL, $previous = NULL) in
     /Users/kenji/work/codeigniter/CodeIgniter4/system/Database/Exceptions/DataException.php on line 23

 -- ------------------------------------------------------------------------------------------------------------------

 [ERROR] Found 3 errors

Why not just change the constructor to final, in DebugTraceableTrait. As far as I know, exceptions here are only extended to add new methods for late static binding.

Why not just change the constructor to final, in DebugTraceableTrait.

I thought if I do so, we will not be able to change the constructor when we inherit from it.
But I changed it, because I was not able to solve the compatibility puzzle.
I deleted system/Cache/Exceptions/ExceptionInterface.php, because I didn't see the need for it.
But it is technically BC break. Should I revert?

I deleted system/Cache/Exceptions/ExceptionInterface.php, because I didn't see the need for it.
But it is also technically BC break. Should I revert?

Yes please. Just deprecate it instead.

With the interface being deprecated, I think Cache should now be implementing the framework's generic ExceptionInterface instead. I have seen you made that in one of your commits but now it's gone?

With the interface being deprecated, I think Cache should now be implementing the framework's generic ExceptionInterface instead. I have seen you made that in one of your commits but now it's gone?

Yes, I deleted the commit.

I think Cache should now be implementing the framework's generic ExceptionInterface

Okay, I will do it again.

Changed interface to implement:

CacheException

Made the constructor final:

Cookie
CookieStore
CacheException
CastException
CLIException
ConfigException
DataException
DownloadException
EncryptionException
FileException
FileNotFoundException
FormatException
FrameworkException
PageNotFoundException

Depreacted:

CodeIgniter\Cache\Exceptions\ExceptionInterface

Why the final on Cookie and CookieStore? This seems unnecessarily limiting.

@MGatner Because they have new static().
https://github.com/codeigniter4/CodeIgniter4/blob/7b9a7b25072066eccd0c497a1acb3fe63b05712c/system/HTTP/Cookie/Cookie.php#L225-L236

🤦♂

As a cookie has predefined attributes, except for the raw option here, which we pass to the constructor of Cookie, I don't think it is necessary for users to add additional arguments in their own implementations.

It think this is ready? @paulbalandan if you're good with it please proceed.


 They have no natural enemies so they were able to breed to insane amounts.
I used a mod thinking rabbits breeding on their own was a good idea. Not so smart since i can't get rid of them now. A command to kill everything, including passive, hostile, and dropped items would be really great. Thank you.

/minecraft:kill @e[type=Rabbit]

Thank you.


fix(component-index): fix horizontal scrolling on component index page

Closes #1628
Fixes the jumping around of the index page on mobile. The issue came from the tags in the component view adding some random extra space.
Changelog
Changed

changed the tags in the footers to absolute positioning.

Check mobile component index page

I removed the file and it doesnt seem to mess anythign up. Mind giving it one more look :) @joshblack


Align support for SED-ML with SED-ML files exported by pyNeuroML

PyNeuroML can convert LEMS files to SED-ML L1V1
Example:
pip install pyneuroml
pynml tests/fixtures/LEMS_NML2_Ex5_DetCell.xml -sedml

This creates a file in the same folder as the LEMs file with the .sedml extension ( tests/fixtures/LEMS_NML2_Ex5_DetCell.sedml).
I don't think PyNeuroML can read these files.
We should try to align our usage of NeuroML/SED-ML with this (specifically targets for model elements).

This package is aligned with the SED-ML exported by pyNeuroML with the one exception that pyNeuroML uses urn:sedml:language:neuroml2 rather than a URN for LEMS. See also NeuroML/pyNeuroML#101.

Reported as NeuroML/org.neuroml.export#76


Feat/radio

Added components DSFRRadioButton, DSFRRadioGroup and DSFRRadioGroupFormField
Added colors and typographies
Updated Icons
Created custom widgets builder based on DSFRThemeDataWidget to easily write golden tests and override properties:

DSFRButtonStyleTheme
DSFRColorsTheme
DSFRSizesTheme
DSFRTypographyTheme

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

137 of 176 (77.84%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.1%) to 88.905%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/components/radio_group/radio_group_form_field.dart
33
36
91.67%

lib/src/components/radio_group/radio_group.dart
38
46
82.61%

lib/src/theme/typography.dart
8
20
40.0%

lib/src/theme/colors.dart
8
24
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
1835

Relevant Lines:
2064

💛  - Coveralls


Fea/refactor repo

project structure refactor to consolidate the spec, validators, adapters, etc into the core repo
added spec and validators from old repo, moved ocpdiag to adapters/
added github actions for spec/validators CI

mind if we just keep "apis" as folder name? it's shorter, and it can be specified in the main readme that those are references that can be used in diag implementations

Discussed offline and here is what we aligned on:
1. rename "adaptors" to "referenceapis"

2. remove the converters repo for now until we have "real converters"

Sounds good


Add Missing GitHub Urls

Adds GitHub URLs for the following advocates:

Barnam Bora
Burke Holland
Chris Nwamba
Christina Warren
David Blank-Edelman
Gustavo Cordido
Lims Wang
Pierre Roman
Ruth Yakubu
Thomas Lewis
Todd Anglin

Docs Build status updates of commit 6472518:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/barnam-bora.yml
:white_check_mark:Succeeded
View

advocates/burke-holland.yml
:white_check_mark:Succeeded
View

advocates/chris-nwamba.yml
:white_check_mark:Succeeded
View

advocates/christina-warren.yml
:white_check_mark:Succeeded
View

advocates/david-blank-edelman.yml
:white_check_mark:Succeeded
View

advocates/gustavo-cordido.yml
:white_check_mark:Succeeded
View

advocates/lims-wang.yml
:white_check_mark:Succeeded
View

advocates/pierre-roman.yml
:white_check_mark:Succeeded
View

advocates/ruth-yakubu.yml
:white_check_mark:Succeeded
View

advocates/thomas-lewis.yml
:white_check_mark:Succeeded
View

advocates/todd-anglin.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


New Gamble roll type (Razors Edge Gamble)

One of the Action Flicks (Neon Noir) adds a more extreme type of Gamble roll, which might be something that would be best made available on the dice roller via a game control rather than always being present - though it's obviously easy enough  to ignore if hiding it is fiddly.

Best
Matt

@babel2uk
So on a roll the Gamble option would become No, Yes and Razor's Edge (rather than just No & Yes)?
It's easy enough to add a game setting to activate Razor's Edge as an option (and it's hidden unless this is turned on).
Have I got that right?

That's right. It's basically just an upgraded version of a Gamble, so an extra option in the drop down sounds perfect. 🙂On 21 Sept 2024 15:50, Genii-Locorum @.***> wrote:
@babel2uk
So on a roll the Gamble option would become No, Yes and Razor's Edge (rather than just No & Yes)?
It's easy enough to add a game setting to activate Razor's Edge as an option (and it's hidden unless this is turned on).
Have I got that right?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Here you go - tested the damage and it works

Awesome work
Thanks 😀

Thank you for your input.  Now fixed in release V2.08.  I will close the issue.


TypeScript: Consider using ReadonlyArray instead of Array

Similar to Flow, TypeScript also provides an immutable ReadonlyArray (introduced in v2.0 that could be used to type GraphQL lists. Would you consider using ReadonlyArray instead of Array? Or a union of both, so I don't have to manually cast all ReadonlyArrays to Arrays to match the QueryVariable type.

One thing to consider is that the Apollo Client update API actually depends on results being mutable. For example, you would make changes to the result of readQuery and write them back with writeQuery.
There is an existing discussion about this in a PR for Flow, but the same reasoning applies to TypeScript, and we probably want a common solution.

I may not understand all the nuances to the readQuery/writeQuery API, but this is only an issue for variables, not for results.
Results should certainly be mutable. When I query apollo, I want mutable results. As @martijnwalraven points out, I may wish to mutate the result, or simply pass it to a function which takes an Array<T> – which implies to typescript that it needs the mutation functions, even if it doesn't actually mutate its arguments. Using a readonly type for results unnecessarily constrains my use of data returned by apollo, so it should continue to use Array, and not ReadonlyArray.
But for the variable types, you'd only use them as a structure I'm about to pass into Apollo. Apollo should let me pass in as a variable any value that matches the constraints. Apollo does not mutate it's variables, so it should allow immutable values to be passed as arguments.
I was just bit by this same issue, when using an immutable set structure implemented as a ReadonlyArray. We were using an array instead of a Set so that values could be used as query variables and results, but the overly restrictive variable type didn't allow it.
Is there something I'm missing?

Making query results immutable would be a huge benefit to apps embracing immutabilty and the OnPush changeDetection strategy.

How about just adding a feature flag to codegen:generate ?
Something like apollo codegen:generate --immutable and then all generated typescript (or any other language that supports it) interfaces will be readonly.
In Typescript this should add Readonly to all properties, and replace all [] (or Array<...>) with ReadonlyArray<...>. Like this:
export interface Foo_bars {
  readonly id: string;
  readonly name: string | null;
}

export interface Foo {
  readonly bars: ReadonlyArray<Foo_bars>;
}

I am not sure why this issue is closed without any response, but for those who might be looking for a solution, there is an option called --useReadOnlyTypes that can be used with apollo client:codegen --useReadOnlyTypes.


Encapsulate the details of background runtime

Motivation
Currently, Tsukuyomi does not provide APIs for spawning new tasks, so the users need to use the API provided by Tokio runtime (like tokio::spawn, tokio_threadpool::blocking) directly.
Since details of the background may change depending on the situation (for example, the current_thread runtime is used at the time of testing), there is a possibility of inducing some runtime errors by the mismatch of used APIs).
Tasks

[x] blocking (#83)
[ ] TaskExecutor

pub enum TaskExecutor {
    ThreadPool(tokio::runtime::TaskExecutor),
    CurrentThread(tokio::runtime::current_thread::Handle), // FIXME: replace with tokio_current_thread::TaskExecutor
}

impl<T> futures::future::Executor<T> for TaskExecutor { ... }

thread_local!(static EXEC: Cell<Option<NonNull<TaskExecutor>>> = Cell::new(None));

pub fn with_current_task_executor<R>(f: impl FnOnce(Option<&mut TaskExecutor>) -> R) -> R {
    ...
}

pub fn spawn(f: impl Future<Item = (), Error = ()> + Send + 'static) {
}

pub struct DefaultTaskExecutor { ... }

impl<F> futures::future::Executor<F> for DefaultTaskExecutor<F> {
    fn execute(&self, f: F) -> Result<(), ExecutoError<F>> {
        with_current_task_executor(|exec| {
             match exec {
                 Some(exec) => exec.execute(f),
                 None => tokio::spawn(f),
            }
        })
    }
}

The implementation of test server is currently used the multi-threaded Tokio runtime and blocking is always available.


Allow specifying target consumer_group when creating a test consumer with #karafka_consumer_for

When multiple consumer groups are configured to consume from the same topic, as in the example below, the #karafka_consumer_for method will register its returned consumer only to the consumer group is defined last in the Karafka configuration file.
my_app.rb
class MyApp < Karafka::App
  consumer_groups.draw do
      consumer_group :group_one do
        topic("incoming_events") { consumer EventProcessingConsumer }
      end

      consumer_group :group_two do
        topic("incoming_events") { consumer EventReportingConsumer }
      end
    end
end

event_processing_consumer_spec.rb
RSpec.describe EventProcessingConsumer do
  subject(:consumer) { karafka_consumer_for("incoming_events") }

  # consumer is registered to the topic for  consumer group two
  # since it is the last one defined in the consumer_group.draw block
  consumer.topic.consumer_group # => group_two
end

I think this issue occurs because of the way the method iterates over the available topic names here, which seems to disregard the consumer_group for which the topic is registered. I would be helpful to be able to optionally pass a target consumer_group_name arg to this method in order to ensure the consumer was registered to the correct group/topic combination.

Yes, you are right and it's worth implementing. Will do.

@mrfarmer777 would you mind giving it a run? https://github.com/karafka/karafka-testing/pull/93 :) just want to make sure. I did test it out on the example apps, and seems to satisfy all the cases:

[x] no API changes for anyone that uses it without problems
[x] raises an exception when the same topic is used in multiple consumer groups but not limited when specified (so no mistakes)
[x] allows for the specification of the target consumer group
[x] raises an exception when within a given consumer group topic is not found


Deprecate the Size validators in favour of DataSize validators

Size is deprecated in favour of DataSize so it makes sense to also deprecate the corresponding validators.

This reduced the number of sonar code smells by ~4% from 405 to 389


Correct the wrong chinese translation about [rush publish dry-run mode]

The previous translation swapped the meaning between rush publish and rush publish --apply.
the right meaning is:

rush publish  dry run mode
rush publish --apply  non dry run mode

Thank you for fixing this!


New patch release of Golang: v1.20.9

Update EKS Go Patch Version: v1.20.9-10
SPEC FILE STILL NEEDS THE '%changelog' UPDATED
PLEASE UPDATE WITH THE FOLLOWING FORMAT
* Wed Sep 06 2023 Cameron Rozean<EMAIL_ADDRESS>- 1.20.8-1
- Bump tracking patch version to 1.20.8 from 1.20.7

/lgtm

/approve

/approve


hotfix: fix pointer to temporary

Description
Hotfix: Fixes a pointer to temporary issue

How Has This Been Tested?
Detected while running the tiglviewer-report script with adress sanitizer enabled.
Screenshots, that help to understand the changes(if applicable):
Checklist:

[ ] A test for the new functionality was added.
[ ] All tests run without failure.
[ ] The new code complies with the TiGL style guide.
[ ] New classes have been added to the Python interface.
[ ] API changes were documented properly in tigl.h.

Codecov Report

Merging #805 (5b4971c) into master (ba33933) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   62.32%   62.32%   -0.01%
==========================================
  Files         290      290
  Lines       23418    23419       +1
==========================================
  Hits        14595    14595
- Misses       8823     8824       +1

Impacted Files
Coverage Δ

src/engine_nacelle/CCPACSEnginePosition.cpp
14.28% <0.00%> (-0.53%)
:arrow_down:


receive  an error while catkin_make to your package

Hi Wolfgang,
I'm following your article "Flying Multiple UAVs Using ROS" and receive  an error while catkin_make to your package:
CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
Could not find a package configuration file provided by "crazyflie_cpp"
with any of the following names:
crazyflie_cppConfig.cmake
crazyflie_cpp-config.cmake

Any idea?
Thanks,  Yoni.

Sorry,
Just saw your new installation instructions here..

Hi, yes it does.
By the way, we're trying to pass VRPN messages from Motive to a virtual machine running ROS, but it's not quite working. Are you familiar with a short tutorial on this issue (configurations of the motive and the VM)?
Thank you,  Yoni.

I don't have motive myself, so I cant comment on that problem. One general hint might be to run some network tests (ping each other, traceroute, etc.).


Additional Ingress gateway is missing service port

Hello,
I have a terraform project, which sets up multiple ingress gateways on our GKE cluster.
resource "kubectl_manifest" "istio-operator" {
  #language=YAML
  yaml_body = <<YAML
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  name: istio-operator
  namespace: "${kubernetes_namespace.istio-system.metadata[0].name}"
  labels:
    app.kubernetes.io/part-of: "service-mesh"
    app.kubernetes.io/managed-by: "Terraform"
spec:
  profile: default
  components:
      ingressGateways:
        - name: istio-ingressgateway
          enabled: true
        - name: internal-ingressgateway
          namespace: istio-system
          enabled: true
          label:
            istio: internal-istio-ingressgateway
            app: internal-istio-ingressgateway
          k8s:
            serviceAnnotations:
              "networking.gke.io/load-balancer-type": "Internal"
              "cloud.google.com/load-balancer-type": "internal"
              "cloud.google.com/neg": "{\"ingress\": true}"
              "beta.cloud.google.com/backend-config": '{"default": "internal-ingress"}'
            env:
            - name: ISTIO_META_ROUTER_MODE
              value: sni-dnat
            hpaSpec:
              maxReplicas: 5
              metrics:
              - resource:
                  name: cpu
                  targetAverageUtilization: 80
                type: Resource
              minReplicas: 1
              scaleTargetRef:
                apiVersion: apps/v1
                kind: Deployment
                name: istio-internal-ingressgateway
            resources:
              limits:
                cpu: 2000m
                memory: 1024Mi
              requests:
                cpu: 100m
                memory: 128Mi
            service:
              ports:
              - name: status-port
                port: 15022
                targetPort: 15022
              - name: http2
                port: 80
                targetPort: 8080
              - name: tls
                port: 15444
                targetPort: 15444
              type: NodePort
            strategy:
              rollingUpdate:
                maxSurge: 100%
                maxUnavailable: 25%
  values:
    gateways:
      istio-ingressgateway:
        serviceAnnotations:
          "cloud.google.com/neg": "{\"ingress\": true}"
          "beta.cloud.google.com/backend-config": '{"default": "main-ingress"}'
        type: NodePort
YAML

  depends_on = [
    helm_release.istio-operator
  ]
}

Both Ingress are created and visible in kubectl. The Problem I'm having now is that the internal ingress is not serving on Port 8080, which is required for our health check.
See netstat outputs from both docker containers:
Internal-Ingress
istio-proxy@internal-ingressgateway-7f4f96b4ff-6swm7:/$ netstat -tupln
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:15021           <IP_ADDRESS>:*               LISTEN      19/envoy
tcp        0      0 <IP_ADDRESS>:15090           <IP_ADDRESS>:*               LISTEN      19/envoy
tcp        0      0 <IP_ADDRESS>:15000         <IP_ADDRESS>:*               LISTEN      19/envoy
tcp6       0      0 :::15020                :::*                    LISTEN      1/pilot-agent

External Inggress
istio-proxy@istio-ingressgateway-7cc49dcd99-8lnn6:/$ netstat -tupln
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:15021           <IP_ADDRESS>:*               LISTEN      17/envoy
tcp        0      0 <IP_ADDRESS>:8080            <IP_ADDRESS>:*               LISTEN      17/envoy
tcp        0      0 <IP_ADDRESS>:15090           <IP_ADDRESS>:*               LISTEN      17/envoy
tcp        0      0 <IP_ADDRESS>:15000         <IP_ADDRESS>:*               LISTEN      17/envoy
tcp6       0      0 :::15020                :::*                    LISTEN      1/pilot-agent

What am I doing wrong, that the External Ingress is serving on Port 8080, but the not the internal ingress?
Thank you for your help!

It will only serve on ports that are exposing in a Gateway object. If you are using the Kubernetes Ingress, only the gateways with label istio: ingressgateway will be exposed.

@howardjohn thank you for the help, that was indeed the issue!
I have been looking everywhere in so many documentations for that issue. Do you know if it is documented somewhere? If yes, can you provide me a link?


Improve README for each PHP auto-gen library along with Client Lib Reference Content

ISSUE
Currently, the README for PHP client libraries have minimal information (especially for auto-gen). Here's an example with Monitoring:

The content of this README is also used for the Client Library Reference:

EXPECTED RESULT
We can add more content to the README and use that same content on the Client Library Reference. The README for Ruby is one such example. That README is in fact auto-generated too. We should hence create a template for PHP as well - and where we can add a line telling users to install gRPC (since PHP is special). Therefore the auto-gen template might need to be slightly different for PHP, but still very similar to the Ruby one.

We ran through and updated our documentation in our latest release. This should be good to go now :).


Mermaid support

Description
Add suport for mermaid markdown in Power BI
Exemples
flowchart LR
   A--->B
   A--->C
   B--->D
   C--->D

Code:
```mermaid
flowchart LR
   A--->B
   A--->C
   B--->D
   C--->D
```

Thank you for the suggestion, @felipegambini.
The latest version now supports mermaid diagrams. Try it out and let me know what you think!

@emil-eklund that was incredible, how quickly you implemented the improvement, congratulations and thank you very much!
I just tested it and it works great!


refactor: implementing  in Noir structs

Implementing deserialize in a few structs

Current dependencies on/for this PR:

master

PR #4384   👈

This stack of pull requests is managed by Graphite.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 5a71bb95 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,412
179,524
716,068

l1_rollup_calldata_gas
221,632
866,584
3,448,144

l1_rollup_execution_gas
314,119
984,324
3,667,801

l2_block_processing_time_in_ms
1,149 (-1%)
4,347
17,199

note_successful_decrypting_time_in_ms
300 (-2%)
958 (-4%)
3,614 (-2%)

note_trial_decrypting_time_in_ms
10.9 (-29%)
90.5 (-27%)
141 (-3%)

l2_block_building_time_in_ms
17,695
70,137
281,577

l2_block_rollup_simulation_time_in_ms
13,041
51,667 (-1%)
207,779

l2_block_public_tx_process_time_in_ms
4,625
18,399
73,514

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,822 (-7%)
26,344 (-6%)

note_history_successful_decrypting_time_in_ms
2,404 (+1%)
4,756 (+3%)

note_history_trial_decrypting_time_in_ms
111 (+14%)
233 (+6%)

node_database_size_in_bytes
17,326,160
33,206,352

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
309
44,481
26,193

private-kernel-ordering
194 (+1%)
44,513
14,929

base-rollup
1,404
128,970
881

root-rollup
82.4
4,088
677

private-kernel-inner
415
71,640
26,193

public-kernel-private-input
239
32,615
26,193

public-kernel-non-first-iteration
238
32,657
26,193

merge-rollup
7.59
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.2 (-1%)
11.3
12.7
17.1
22.8 (-1%)
64.4 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.593 (-1%)
0.629
0.541
0.531
0.478
0.443 (+1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
74.6 (-2%)
47.5 (-1%)
239
462
897
3,557

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.461 (-2%)
0.487 (-1%)
0.436
0.432
0.428
0.428

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
106 (+2%)
56.4 (-1%)
350
689
1,366
5,403

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.502 (+1%)
0.495 (-1%)
0.474 (-1%)
0.474
0.475
0.471

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
56.4
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
94.1
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
0.577
N/A
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,575
37,974

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
544 (-4%)
1,220

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.510 (-20%)
570


Fix cufft callback manager error in Windows

pfnCI, test this please.

This needs to be backported to hotfix-v9.0.0a3 branch

Jenkins CI test (for commit 366aa13567bdf1152b0348eaee12753ab3cbf227, target branch master) succeeded!


GitHub's CodeQL checks are failing in master

See https://github.com/stellar/go/runs/3736748989

All the problems except one (fixed at https://github.com/stellar/go/pull/3969 ) were false positives.
I marked the false positives as such

BTW, is there a reason not to run CodeQL in PRs so that we don't merge code with failing checks? (CC @leighmcculloch )

They should be running on PRs:
https://github.com/stellar/go/blob/0a091b90b4da54707aab1c44c0f05f9929fa4ea7/.github/workflows/codeql-analysis.yml#L8
We don't block merging on a codeql failure, we could though.
Assuming the PR is #3963 it looks like CodeQL did run and it passed. If it was another PR that didn't run it could you link to it?

I didn't check if they ran on PRs, but the problem is that the check appears as failed in master but not in PRs
e.g. no errors here https://github.com/stellar/go/pull/3963 , but it failed here https://github.com/stellar/go/commit/e55e42a98f197e3d5313b605a1d5a01dad42f41b


RDDRONE-FMUK66 enable i2c and spi sensors.

This PR includes code to add following functionality on rddrone_fmuk66 board -

Makes 3.3V onboard power supply for sensor enablement to be regulated by the zephyr regulator driver.
Resolves issues related to working of I2C based sensors on internal I2C bus.
Adds support for fxos8700 and fxas21002 sensors over SPI bus.
Adds rgb leds for indicating pwm outputs

Makes 3.3V onboard power supply for sensor enablement to be regulated by the zephyr regulator driver.
Resolves issues related to working of I2C based sensors on internal I2C bus.
Adds support for fxos8700 and fxas21002 sensors over SPI bus.

Please split up these changes into separate commits

@danieldegrasse do you have any insight on to why the twister-build-prep is failing:
INFO: Error found: samples/sensor/fxos8700/sample.sensor.fxos8700.hybrid on frdm_k64f (No hardware support but is one of the integration platforms)
INFO: Error found: samples/sensor/fxos8700/sample.sensor.fxos8700.accel on bbc_microbit (No hardware support but is one of the integration platforms)
INFO: Error found: samples/sensor/magn_polling/sample.sensor.magn_polling on stm32f411e_disco (No hardware support but is one of the integration platforms)

@danieldegrasse do you have any insight on to why the twister-build-prep is failing:

@bperseghetti Take a look at line 4 of the sample.yaml for the fxos8700:
depends_on: i2c gpio spi fxos8700

Note that fxos8700 is absent from the supported list in frdm_k64f.yaml:
supported:
  - adc
  - arduino_gpio
  - arduino_i2c
  - arduino_serial
  - arduino_spi
  - can
  - counter
  - dac
  - dma
  - gpio
  - i2c
  - netif:eth
  - nvs
  - pwm
  - spi
  - usb_device
  - watchdog

I would guess this is what's causing your failure. The depends_on property is compared with a board's supported list by twister. Twister cannot prepare a test plan for these tests because the integration platform (frdm_k64f) does not appear to support the sample. I would drop fxos8700 from your depends_on property for these samples.

As an aside, your commits still need to be updated to follow Zephyr's commit guidelines:

The subject line must include a prefix that identifies the subsystem being changed, followed by a colon, and a short title, for example: doc: update wiki references to new site

Your code also needs to utilize tabs for indentation. To speed up fixing these compliance issues, you can run checkpatch locally on a Linux machine (or via WSL) with ${ZEPHYR_BASE}/scripts/checkpatch.pl

@MaureenHelm @gmarull
I just requested for re-review from both of you, as this page showed 2 changes requested from your side which we have already done.
Kindly suggest us what needs to be done in order for these commits to go through to the open source.

Two minor requests, but otherwise LGTM. Thank you!

Awesome! Made the requested changes and rebased.

Please fix the failed compliance check

@MaureenHelm @danieldegrasse @gmarull Thank you all once again for the great reviews and suggestions on our PR. I hope that we have managed to fix all the remaining issues and suggestions.

@gmarull @MaureenHelm : Kindly let us know if you require any further changes from our side..

@gmarull can you revisit your review items?

@gmarull should be good to merge in now.

@MaureenHelm .. I think I mistakenly asked for a re-review from you, so can you please approve once again.

@gmarull .. thanks for helping us out. Really appreciated!


[json schema] Missing supports for a feature

When using our JSON schema I get a warning that supports is not allowed for features. This is no longer true and the schema needs to be updated.

Which editor are you using?

VS code

I randomly found a vcpkg.json file and tried to add "supports" field to the feature avx, but I didn't encounter the problem you mentioned.

This is my VS Code:

What's the version of yours?

Hi @Cheney-W,
Sorry for the confusion but this is indeed a bug: The JSON schema is missing the property supports of the object features. You can confirm this by searching for feature inside the schema: https://raw.githubusercontent.com/microsoft/vcpkg/master/scripts/vcpkg.schema.json

It's here: https://github.com/microsoft/vcpkg-tool/blob/3e843923eef525d1c5c23a5768b00f8072145fdc/docs/vcpkg-schema-definitions.schema.json#L296-L298
Thanks :)


Image tile computation slow for chunked, compressed source data

It currently takes up to 0.5 seconds (!) to compute a single 220 x 220 pixels image tile for a analysed_sst variable from e.g.<PHONE_NUMBER>0000-ESACCI-L4_GHRSST-SSTdepth-OSTIA-GLOB_LT-v02.0-fv01.0.nc, read with xarray. It has the following encoding:
$ analysed_sst.encoding
{'_FillValue': -32768,
 'add_offset': 273.14999,
 'chunksizes': (1, 663, 1327),
 'complevel': 1,
 'contiguous': False,
 'dtype': dtype('int16'),
 'fletcher32': False,
 'original_shape': (1, 3600, 7200),
 'scale_factor': 0.0099999998,
 'shuffle': True,
 'source': 'D:\\EOData\\SST\\20000714120000-ESACCI-L4_GHRSST-SSTdepth-OSTIA-GLOB_LT-v02.0-fv01.0.nc',
 'zlib': True}

Here is the performance analysis output generated while computing the tile:
PERF: >>> Tile: res_1-analysed_sst-0-jet-0.0-1.0 0 0 0
tile "arr-res_1-analysed_sst-0/0/0/0": computed, took 4.3165 sec
tile "tra-res_1-analysed_sst-0/0/0/0": computed, took 4.3172 sec
tile "tra-res_1-analysed_sst-0/0/0/0": stored in cache, took 0.0000 sec
tile "rgb-res_1-analysed_sst-0-jet-0.0-1.0/0/0/0": computed, took 4.3218 sec
tile "rgb-res_1-analysed_sst-0-jet-0.0-1.0/0/0/0": stored in cache, took 0.0010 sec
PERF: <<< Tile: res_1-analysed_sst-0-jet-0.0-1.0 0 0 0 took 4.322905492520917 seconds

I'm writing a test for automatic dask chunking upon opening a dataset, then I'll make a pull request for the branch, maybe this will also help in this issue, as theoretically you'd have to deal with better aligned chunking. Currently a single dask chunk that's being opened when constructing any tile woud be the whole time slice, irrespective of chunking on disk. With dask-chunked xarray dataset it would be less.
Notice also that constructing a 220x220 pixel large tile might involve ~500 redundant disk reads, in case each tile is handled separately.
The open_dash_chunk branch is now up to date with master, just lacks the test, so I guess you can try switching to it and see if it makes any difference!

To elaborate what I said about 220x220 pixel tile.
When I tried using dask chunking initially I used very small chunks thinking that the smaller the chunk, the less memory I use. Then SHoyer explained that having many dask chunks in a single chunk on disk is not ideal, as that would mean that when working with each chunk dask would load in the whole chunk on disk resulting on many redundant reads, slowing the application down. So, the 'ideal' dask chunk is one that either holds an exact number of 'not-big' chunks on disk in it, or, close to that.
I don't know how you get the tile, but depending on the way it's done, it might involve reading the same chunk on disk (or with dask chunk size equal to time slice - the whole time slice, e.g. all chunks on disk) repeatedly.
So, trying larger tile sizes might actually be a good idea.

@JanisGailis thanks for your comments! Please have a look at https://github.com/CCI-Tools/cate-core/blob/master/notebooks/xarray-and-chunks.ipynb and maybe try yourself.

also that constructing a 220x220 pixel large tile might involve ~500 redundant disk reads, in case each tile is handled separately.

Yes, I'll try to get around this by creating an image pyramid's tile layout based on chunksizes. Currently, the tile size 220x220 is computed from lat/lon dimension sizes.

I don't know how you get the tile,

https://github.com/CCI-Tools/cate-core/blob/5974287f16bdbad792cf813717b32b0dce97d4ab/cate/util/im/image.py#L629-L658

The current workaround gives a little better results:
PERF: >>> Tile: res_1-analysed_sst-0-jet-0.0-1.0 0 0 0
tile "arr-res_1-analysed_sst-0/0/0/0": computed, took 0.1870 sec
tile "tra-res_1-analysed_sst-0/0/0/0": computed, took 0.1967 sec
tile "tra-res_1-analysed_sst-0/0/0/0": stored in cache, took 0.0000 sec
tile "rgb-res_1-analysed_sst-0-jet-0.0-1.0/0/0/0": computed, took 0.2017 sec
tile "rgb-res_1-analysed_sst-0-jet-0.0-1.0/0/0/0": stored in cache, took 0.0012 sec
PERF: <<< Tile: res_1-analysed_sst-0-jet-0.0-1.0 0 0 0 took 0.20303941936074565 seconds

I looked into the notebook you made and added the same tests with using 'autochunking'. A few observations.

In your explorations you're not using dask at all. If you use xr.open_dataset without any chunking information given (even chunks={}), it defaults to using a NumPy array in the background. See the line where I call 'analysed_sst.data'.

So in this case chunks on disk are not used in any way.

With 'autochunking' there does not seem to be a difference in whether you do .load() beforehand or not, the time taken is ~120ms in both cases.

In your explorations you're not using dask at all.

Then it is very strange that the tile.load() call is now consuming 99% of the tile load time. Before I added the call, the 99% of the time was spend when data was actually pulled from xarray by mapping raw data to RGBA arrays and then to PNG image tiles.

So in this case chunks on disk are not used in any way.

I believe, that is not entirely true because chunking is part of the encoding of the data on disk and therefore it is something the underlying decoding engine must deal with (which is netCDF4 by default).

Current performance is now accepatable


chore: empty commit

🕳

Our theory is that causing assets to rebuild will fix a problem we're only seeing in staging:
https://artsy.slack.com/archives/C01ADJNCS5D/p1647962153021399?thread_ts=1647960456.291119&cid=C01ADJNCS5D


Add Panel docs

Panel docs are in an incomplete state, and here as a proposal.. I'd find this info really helpful when reading the documentation
edit moved meadowphysics change to #213 since this is likely a larger discussion

Sorry if this wasn't clear in the description; I meant that the panel docs presented here in the PR aren't complete -- these still need actual values for voltage ranges, slew rates, sample rates, etc, and for a couple of the panel images.
@tehn is this info you have on-hand, or that's otherwise discoverable so I can add in another PR?

yikes was reading too fast and clicking too much!
let me see what I can fill in


add height css

This PR fixes #16025
The issue was caused by this new height setting from vscode merge: https://github.com/microsoft/azuredatastudio/blob/3cb2f552a6f004dccd153577aecfd75f3d1bacae/src/vs/base/browser/ui/toolbar/toolbar.css#L7.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 42.733%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26166

Relevant Lines:
55605

💛  - Coveralls


Mixlib-Install based updater functionality

This is based off the work done in https://github.com/chef-cookbooks/omnibus_updater/pull/105, but updated for some of the new mixlib-install functionality and updated to be a custom resource. This allows simple update functionality without the mess of the ruby implementation in the omnibus_updater cookbook. It is going to require additional testing and functionality, but I wanted to get this 1/2 working bit out there.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Looks promising and functionally fits with this cookbook 👍

Closing this one out in favor of a chef_client_updater cookbook. This will allow us to support Chef clients all the way back to 12.1 vs. 12.11 in this cookbook.


Update servo parameters - studio_ws

This PR allows Studio to use the new acceleration-based smoothing plugin for servo. The hard joint limits need to be tested and verified.
Requires:

[x] https://github.com/ros-planning/moveit2/pull/2651

Not sure if we need a streaming controller at all (more in the comments) but maybe I am missing something. CI probably fails due to ros-planning/moveit2#2651 not yet being merged

The problem is that the streaming controller is referred to in the behaviors, like here. If we want the servo controller to be configurable, then it needs to be done this way.

Not sure if we need a streaming controller at all (more in the comments) but maybe I am missing something. CI probably fails due to ros-planning/moveit2#2651 not yet being merged

The problem is that the streaming controller is referred to in the behaviors, like here. If we want the servo controller to be configurable, then it needs to be done this way.

Let's call it servo_controller in that case and add a comment that describes why it is necessary to have it in addition to the default JTC

Not sure if we need a streaming controller at all (more in the comments) but maybe I am missing something. CI probably fails due to ros-planning/moveit2#2651 not yet being merged

The problem is that the streaming controller is referred to in the behaviors, like here. If we want the servo controller to be configurable, then it needs to be done this way.

What do you think about calling it servo_controller in that case and add a comment that describes why it is necessary to have it in addition to the default JTC

@sjahr I renamed the controller to servo_controller. I think it is a better and more descriptive name.


bounddvi needs adaption to new latex version

bounddvi manipulates \@begindocumenthook to prepend and append code. This will no longer work in the next latex version, as \@begindocumenthook is no longer used directly. Your code there will be silently ignored.
Please check if you can change the code to make use of the new additional hooks  and hook management provided by LaTeX.
The bounddvi code contains a comment that one of the hook is only there to ensure that the code is behind the geometry code. This can for example be implemented with a hook rule:
      \DeclareHookRule{begindocument}{geometry}{before}{bounddvi}

If you have problems or think that the  provided hooks are not sufficient open please an issue at the latex2e github.

@aminophen gentle reminder that the LaTeX release is drawing nearer.

Thanks for the head-up; I know the problem but I haven't worked on it yet, because we (@texjporg) are addressing a number of incompatibilities related to LaTeX2e 2020-10-01 \shipout changes.  Adjustment of bounddvi.sty would take more time.
FYI: the current pLaTeX redefines \AtBeginDvi with an addition of \yoko to avoid low-level pTeX errors (see mail "[graphics] New dvips.def and Japanese pLaTeX" which I sent in June 2016).  However, that redefinition must be removed to avoid breaking your new definition.  Nevertheless, we are still unable to find the appropriate place in the new \shipout code to insert \yoko safely without causing any low-level pTeX errors.

Not sure what exactly \yoko does (it seems to be a primitive) but given its current position wouldn't the right place be shipout/firstpage?

\yoko is a pTeX-specific direction change primitive (JP vertical writing -> JP horizontal writing), but the use of that primitive is disallowed when the node list or the page is non-empty.
\AddToHook{shipout/firstpage}{\yoko}
% => ! Incompatible direction list can't be unboxed.
\documentclass[dvipdfmx]{tarticle}% vertical writing document class
\begin{document}
\begin{figure}
\caption{キャプション}
\end{figure}
\end{document}

\AddToHook{shipout/before}{\yoko}
% => ! Use `\yoko' at top of list.
\documentclass[dvipdfmx]{tarticle}% vertical writing document class
\begin{document}
\begin{figure}
\caption{キャプション}
\end{figure}
\end{document}

Using platex-dev, similar problems occur with lots of \unvbox inside the new shipout code, so we are still examining what needs to be changed.

ah, understood. So in that case atbegshi was never working with platex (because that code largely comes from that package)?
Maybe we do need some additional hooks for setting/altering direction (in the right places)

Yes, and that was why I developed "pxeveryshi.sty" and "pxatbegshi.sty" (both in platex-tools) which can cope with pLaTeX vertical writing (with some known subtle incompatible behaviors).  Those two packages are also broken with platex-dev now ... investigating.

Maybe we do need some additional hooks for setting/altering direction (in the right places)

I guess so, but we are still not able to find "the right places", sorry.  If we reach there, I'll let you know.

But if you managed to get pxatbegshi working, wouldn't that be a model on what needs changing in ltshipout? (but I guess you stried that already so I better leave you to it). Let me know when you found the "right places" so that we can work out something to accomodate.

@FrankMittelbach @u-fischer
FYI: our new implementation (called "candidate 3") is ready in platex.cfg; it seems to work, for most of our test cases prepared in the same directory.  A mere addition of \yoko is not enough, so we don't think "some additional hook in the kernel" is useful.  Therefore, we will do that patch in our pLaTeX kernel (plcore.ltx) instead.  Many thanks for your kind cooperation.

In 2020-09-25, bounddvi is adapted.


Tab component

Consider https://ui.reach.tech/tabs

That for me to consider? Or a note for yourself?

Not to self 😂


Add support to insert virtio-net devices

This PR gives the users two ways to insert virtio-net devices:

Insert before VMM launched. The parameter is
--virnets '[{"iface_id":"eth0","host_dev_name":"tap0","num_queues":2,"queue_size":0,"allow_duplicate_mac":true}]'.
Insert hotplug devices after VMM launched. The parameter is
--hotplug-virnets '[{"iface_id":"eth0","host_dev_name":"tap0","num_queues":2,"queue_size":0,"allow_duplicate_mac":true}]'

Both of these parameters receive an array of VirtioNetDeviceConfigInfo in the
format of JSON to make them more configurable.
Fixes: #15
Signed-off-by: Xuewei Niu<EMAIL_ADDRESS>

Hi @justxuewei ,could you also add the intruction under README.md so that others could know how to use this feature?

Hi @studychao, I've pushed code to supplement use cases about how to create virtio-net devices.


suffix validator only model generation with _validator

closes #578

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


On the problem of Karabiner-Elements trackpad

[Environment]

MacBook Pro (15-inch, 2017)
macOS Sierra 10.12.6
Karabiner-Elements 0.91.13

[Related issues]
https://github.com/tekezo/Karabiner-Elements/issues/903
https://github.com/tekezo/Karabiner-Elements/issues/893
https://github.com/tekezo/Karabiner-Elements/issues/891
[Details]
It is a problem frequently occurring when using Emacs key binding in Karabiner-Elements.
If you touch Trackpad even a little, the key binding will be incorrect.
(Ctrlkey's flag will be raised)
While using Emacs key binding, normally you press and hold Ctrl + F, Ctrl + B, etc. The left and right cursor keys will repeat, but due to this problem Ctrl + cursor key is pressed and the cursor Jump to the end of line-end line.
If you use a MacBook with a larger Trackpad after the MacBook Pro 2016, you just touch the Trackpad even if you place your hand at the normal home position.

I'm seeing this, too. Kudos for finding the relation to the trackpad. It looked completely random to me.

This still happens in Version 11.0.1.

NEWS.md
Version 11.0.1
Fixed an issue that modifier flags state is not changed properly in pointing device events from Apple trackpads.

It has occurred in 11.0.2 as well.

Thank you for feedback!
This issue is strongly related with macOS key repeat behavior, thus we need to handle events scrupulously
I believe this issue has been gone in v11.0.3.
Please try the latest beta version.
https://pqrs.org/osx/karabiner/document.html#check-for-updates

Now it works! Thanks a lot @tekezo:smile:

Great！！
Thank you tekezo!! 😄
I tried v11.0.3.
This problem seems to be solved.
I will continue validation for a while.
If the problem does not occur, close the issue.
I can not think of living without karabiner.
Thank you for taking the time away.
A little, I donated!

confirmed the fix.
Thank you @tekezo.


Actual 3D pointcloud creation

Hi,
I am new to Cartographer, I've tested the demos and I was disappointed to see what they call 3D SLAM since I was expecting to see the pointcloud of an actual 3D museum, not just the floor...
I've read lots of issues here and I don't understand all of them. I think the closer one to my goal is this one (1168).
I don't understand how to process things explained here.
My goal is to get a .ply file out of my lidar data (ie bagfiles), I am not "fluent" in this developping  environment words : asset, pipeline.
Can you explain me what should I do ? what should I precisely type, execute ?
thanks.

I am moving this issue to Cartographer_ROS, so I'm closing.

Hey I can explain you what I have done. But I have to tell you that I have errors so it's not working but I think I came to the solution closer:
1.first of all you need a bag file
2.Start your online node for your cartographer
3.type this command: rosservice call /finish_trajectory 0
4.then this: rosservice call /write_state "{filename: 'dir to your bag.pbstream'}" This is the directory where you want to save your pbstream
5. launch your bag file with these -> bag_filenames:= directory and pose_graph_filename:= directory to your pbstream
-So you need to use the assets_writer_backpack_3d.lua which you can find in the config_files of cartographer_ros (or you can write your own script)
-you need a launch file for your assets_writer: they have also one in the launch folder -> assets_writer_backpack_3d.launch
Nevertheless I couldn't configure it well enough or I'm doin somethin wrong with the bagfile, because I get an error which says: assets_writer_main.cc:53] Check failed: !FLAGS_bag_filenames.empty() -bag_filenames is missing
REQUIRED process [cartographer_assets_writer-1] has died!
I'm recording my bagfile with this command: rosbag record -a maybe this is the problem but I'm not sure

To write an .ply file, add:
{
    action = "write_ply",
    filename = "points.ply",
},

To write an .xyz file, add:
{
    action = "write_xyz",
    filename = "points.xyz",
},

I agree that it's not very clear how the configuration needs to look like from the code or the documentation, this is something that can be improved.

Based on  assets_writer_backpack_2d.lua., I got this so I can get a .ply file:
    {
      action = "write_ply",
      filename = "points.ply",
},

I edited assets_writer_backpack_3d.lua with this code and assets_writer_backpack_3d.launch to call my new .lua file.
I've got a 1.7 Go .ply file that I open with CloudCompare (maybe I'll try point_cloud_viewer
later) , it seems fine:

I will try the xyz format and let you know, I need to be able to reduce the size of the file also!

I need to be able to reduce the size of the file also!

You should run a filter on the raw pointcloud, in CloudCompare you can use for example an SOR filter (https://www.cloudcompare.org/doc/wiki/index.php?title=SOR_filter).
There is a "fixed ratio sampler" that you can use to filter directly in the assets writer, but it's not very smart. It just drops a fixed ratio of points:
    {
      action = "fixed_ratio_sampler",
      sampling_ratio = 0.5,
    },

But I would rather recommend to use something like the SOR filter instead of this.

Hey @jattiogbe how did you get the pointcloud? What were your first steps?
What I am doing is:

record the bagfile
stop recording
launch the bagfile
then finishing trajectory
writing state
6 stop bag file
launch assets_writer with the bag file and pbstream

But this is not working for me

Hi @Semih67 ,
I can't get a proper pointcloud of my own, I don't even passe the rosbag_validate step, I don't know what's wrong with my recordings.

I am in Lidar_mode 1024x20

I do :
roslaunch ouster_ros os1.launch os1_hostname:=os1-991838000761.local os1_udp_dest:=<IP_ADDRESS> viz:=true scan_dur_ns:=50000000
and
 rosbag record /os1_node/imu_packets /os1_node/lidar_packets

then

when I want to validate :
rosrun cartographer_ros cartographer_rosbag_validate -bag_filename ~/cat_ws/demo_2019-02.bag
which returns nothing.
I guess I'm stuck there until I manage to validate my bagsfiles.

It woked for me now. I was publishing a tf static from world to map. And this was the issue. When I deleted this it worked

Are you using default launch files or the modified ones we can find on github?
What lidar model do you have ? I have an Ouster OS1.
I resolved my problem of validating bagfiles, I'm nowhere further this step.
What file did you delete the "tf static from world to map" line ?

I'm using a tof camera not a lidar. I'm recording it like this: rosbag record /tf /tf_static /imu /scan_matched_points2
And yes this -> "tf static from world to map" was not necessary and I deleted it.

@jattiogbe
Hello, how do you get the pointcloud? I am using a 16-lines LIDAR and IMU to build 3D map by cartographer.
I tun the parameters and run it with no error, the results are as follows:

There is a big gap with the real environment.
This is the validate result of my bag:

E0227 22:30:57.092067 19056 rosbag_validate_main.cc:365] Average IMU linear acceleration is 10.6084 m/s^2, expected is [9.5, 10.5] m/s^2. Linear acceleration data should include gravity and be given in m/s^2.
I0227 22:30:57.093359 19056 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/IMU" (frame_id: "imu"):
Count: 37968  Min: 0.004133  Max: 0.016211  Mean: 0.010000
[0.004133, 0.005340)	                    	Count: 2 (0.005268%)	Total: 2 (0.005268%)
[0.005340, 0.006548)	                    	Count: 3 (0.007901%)	Total: 5 (0.013169%)
[0.006548, 0.007756)	                    	Count: 8 (0.021070%)	Total: 13 (0.034239%)
[0.007756, 0.008964)	                    	Count: 828 (2.180784%)	Total: 841 (2.215023%)
[0.008964, 0.010172)	 ###################	Count: 35958 (94.706070%)	Total: 36799 (96.921089%)
[0.010172, 0.011380)	                    	Count: 345 (0.908660%)	Total: 37144 (97.829750%)
[0.011380, 0.012588)	                    	Count: 820 (2.159714%)	Total: 37964 (99.989464%)
[0.012588, 0.013796)	                    	Count: 1 (0.002634%)	Total: 37965 (99.992096%)
[0.013796, 0.015004)	                    	Count: 0 (0.000000%)	Total: 37965 (99.992096%)
[0.015004, 0.016211]	                    	Count: 3 (0.007901%)	Total: 37968 (100.000000%)
E0227 22:30:57.094650 19056 rosbag_validate_main.cc:382] Point data (frame_id: "rslidar") has a large gap, largest is 0.101409 s, recommended is [0.0005, 0.05] s with no jitter.
I0227 22:30:57.094745 19056 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/rslidar_points" (frame_id: "rslidar"):
Count: 3766  Min: 0.100213  Max: 0.101409  Mean: 0.100801
[0.100213, 0.100333)	                    	Count: 1 (0.026553%)	Total: 1 (0.026553%)
[0.100333, 0.100452)	                    	Count: 1 (0.026553%)	Total: 2 (0.053107%)
[0.100452, 0.100572)	                    	Count: 9 (0.238980%)	Total: 11 (0.292087%)
[0.100572, 0.100691)	                    	Count: 33 (0.876261%)	Total: 44 (1.168348%)
[0.100691, 0.100811)	      ##############	Count: 2717 (72.145515%)	Total: 2761 (73.313858%)
[0.100811, 0.100931)	               #####	Count: 972 (25.809877%)	Total: 3733 (99.123741%)
[0.100931, 0.101050)	                    	Count: 25 (0.663834%)	Total: 3758 (99.787575%)
[0.101050, 0.101170)	                    	Count: 6 (0.159320%)	Total: 3764 (99.946892%)
[0.101170, 0.101289)	                    	Count: 1 (0.026553%)	Total: 3765 (99.973450%)
[0.101289, 0.101409]	                    	Count: 1 (0.026553%)	Total: 3766 (100.000000%)

Here are my files:
demo_rsldiar_3d.launch
rslidar_3d.launch
mydemo_3d.rviz
rslidar_2d.urdf
rslidar_scan_3d.lua
my data bag
Do you know the problem about it?


feat(internal/server): dynamically refresh containerd, docker, kubelet components

code lgtm, doing more testing on it


Update oceanographic conditions regarding age-1 index in 3.4.2 Model Fit subsection

We had a nice paragraph for 2021 age-1 index (kept in for now with a TODO and mention of this issue). Needs updating, with updated California Current Ecosystem Status Report if available (looks like it's produced annually like GOA one is). I can look into unless someone already knows the Status Report well.

https://www.pcouncil.org/documents/2023/02/h-1-a-cciea-team-report-1-electronic-only-2022-2023-california-current-ecosystem-status-report-and-appendices.pdf/
https://www.youtube.com/watch?v=tJUhi-NT3sI

We could probably get a draft of the 2023-2024 CCIEA report as it is due about the same time as our assessment.  It would be citable in by the time we finalize the assessment document.

Some highlights from the draft 2023-2024 CCIEA report (in prep):

"Basin-scale indices suggest average conditions for productivity in 2023: the ONI and PDO were negative for most of the year, while the NPGO remained neutral to negative."
"In contrast, hake larvae were above average for the second consecutive year and at their highest abundance since 2011." - from CalCOFI survey in southern California current area
"Consumption of hake was well above average for bluefin and swordfish in both 2021 and 2022."
"Overall, 2023 saw lower total integrated upwelling compared to previous years (Fig. F.8), except for the most southern region. However, upwelling events were highly variable in strength and timing, consisting of periods of strong upwelling, interspersed with several periods of significant upwelling relaxation, or even downwelling (Fig. 2.4)."  - weaker upwelling was associated with positive hake recruitment from Vestfals paper.
"Total krill abundances in 2023 were the second lowest since the start of the time series in 2007, although most of that overall reduction was due to lower numbers to the northern and southern portions of the sampled area. "

I'm thinking that this paragraph in the assessment should be moved to the Ecosystem Considerations section and removed from section 3.4.2.  If needed, this Model Fit section could reference the Ecosystem Considerations section.

completed with aa939756ffcffedac5cd3c50470f10d1e5c7ee0a


Token calculation is WAY OFF

Currently I am calculating the tokens by the number of spaces.
This is very wrong. dump_dir said some code way 1k tokens, then upon pasting it into lm studio it said there was 3.5k input tokens.

Fixed in https://github.com/fargusplumdoodle/dump_dir/pull/12, now its just a little bit off


Falcon40b decode hang if prefill on device

[Updated]
Here is what I am observing on the latest main (8f3e70e2830b817cde040adef6417921e205d765):

prefill on device with Bfp8 -> hang in the decode
prefill on device with Float16 -> RuntimeError: Problem getting initial line from hexfile stream. It may be reading a file that doesn't exist or ulimit -n too low. (this might be a regression after the attention changes since demo worked with FP16 yesterday)

Prefill on host gives normal output.

cc @skhorasganiTT @johanna-rock-tt @pavlejosipovic I will be off next week, so tagging you guys to be aware of the current status

Results from investigating this hang with different Falcon40b commits from April 26:
On commit fbf8aae: Demo did not hang after 50 runs
On commit 6d1ba2b: Demo hung after 32 runs
On commit 793d842: Demo hang after 6 runs
Since the last two of these commits modified compute kernel configs, it is possible that this is timing related and could overlap with #7066 and #6795.

I am longer seeing this hang (ran demo 100 times) after updating to the new firmware (bundle version <IP_ADDRESS> - details: https://github.com/tenstorrent/tt-metal/issues/4968#issuecomment-2087318566) running at 1GHz (made available in 13193c1247a8713b9bd77e4856fe97cf14d89202).

Closing this issue as I have not seen any more demo hangs since the last update (last commit checked: 12ad5a528)
Command tested:
WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml pytest --disable-warnings -q -s --input-method=cli --cli-input="How do I get better at piano"  models/demos/t3000/falcon40b/demo/demo.py

@johanna-rock-tt is this hanging with FD2 on main?

Yes, I've been a hang for the demo yesterday. @skhorasganiTT how often did you run it? Unfortunately I can't test it now because my machine is still in a bad state. Will update once I have it back.

That's the ci ran from yesterday where the demo hung at the first token decode iteration: https://github.com/tenstorrent/tt-metal/actions/runs/8967693679/job/24625680892#step:7:11266

I deterministically hang with this test/input:
pytest --disable-warnings -q -s --input-method=cli --cli-input="Tell me a joke." models/demos/t3000/falcon40b/demo/demo.py

Unlike the original bug description this also hangs with prefill on host. So it seems to be a decode only hang. However dependent on the input prompt.

Re-opening based on the issue comment that this still repro. Are we able to follow these steps to narrow things down:
1. try op by op by blocking ops (try to make a op-only repro)
  2. try to enable the watcher (navigate with watcher setting)

@skhorasganiTT and I are working on reproducing this. I might have had a bad machine/build state. We'll comment here as soon as we confirmed whether the hang is still there or not.

The local deterministic hang that Johanna was seeing was due to a bad built (compiled kernels) state (removing that directory made the hang go away), and the CI failure that was posted was due to using an older commit than the one I last posted as passing. Johanna and I re-ran the demo tests on CI (passed 15 times) and we are no longer able to reproduce so I am closing this issue.

I just checked, it was on. I'm gonna disable it for all our tests.

Persistent cache is required for inference perf, we shouldn't disable it. Also, I believe the metal team is considering removing the option to disable it as it should always be on.

Are you talking about the program cache? It's two different types of caches.
Apparently the persistent kernel cache caches the compiled kernels over multiple runs and stores that in the built directory, the suspicion is that that's the reason why we sometimes need to remove the built directory after rebasing to get rid of hangs. Perf after the first iteration should not be impacted by this as far as I understood.

I was talking about the persistent kernel cache (which is independent of program cache). Previously, it was my understanding that if the persistent kernel cache is disabled, the kernel binaries would need to be recompiled every time. However, I just spoke to @aliuTT and I think that is now no longer the case. Disabling it will result in not saving to disk (to built), but still save to RAM, and increase the time for the compile run each time the test is run (but not for the subsequent inference run in the same test). So I believe you're right, it should be okay to disable if the increase in compile run time is acceptable.

Both correct

@skhorasganiTT points out that the built directory is specific to persistent_cache and the fact that the hang does not occur when we delete it means that the hang was due to the persistent_cache. No action to take for now.


Mechanism to control "max cursors" setting

We should add a configuration option to allow the "max cursors" parameter to %SSC_INIT to be customized without having to rebuild replicator.

Added new -maxcursors command line option and REPLICATOR_MAX_CURSORS environment variable.


Use ModelSignal instead of Signal in signals.py

Closes #158
It's backwards compatible, the signal will act the same if a class is given rather than a string.

Sorry, that's not a part of django public api.


[firebase_remote_config] Add macOS support

Description
Adds macOS support to the firebase_remote_config plugin
Related Issues
Fixes FirebaseExtended/flutterfire#2697, also related to FirebaseExtended/flutterfire#1653
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@balconywood thanks for the PR! Before we can support macos we should move the Remote Config Plugin to platform interface. I would be happy to review a PR that does that then look at adding different platform support. Would you be interested in providing a platform interface implementation for Remote Config?

@kroikie Sure, I'll see what I can do

MacOS support for Remote Config has landed on master from another PR of mine and a pre-release is available, so I'm going to go ahead and close this PR, sorry 🙈 thanks for contributing though!
https://firebase.flutter.dev/docs/remote-config/overview