c_nnz overflowing

Trying to multiply two sparse matrix using cupy.cusparse.csr2gemm that results in<PHONE_NUMBER> non-zero elements. During debugging, I found that the array that keeps track of the non-zero elements of the output array (c_nnz - check the snippet below) has a data type of int32 which has a maximum limit of<PHONE_NUMBER>.
https://github.com/cupy/cupy/blob/770ff2d295637ef6791b8f90c487749f586cc38a/cupy/cusparse.py#L727-L739
This results in an overflow and throws the following error. I tried changing it to int64 everywhere in the function, however, since it has multiple dependencies, it leads to illegal memory access error.

Traceback (most recent call last):
File "runSparseDNNchallenge.py", line 103, in
scores = inferenceReLUvec(layers, bias, featureVectors);
File "reference_implementation/SparseDNN/python/cupy/inferenceReLUvec.py", line 23, in inferenceReLUvec
Y = Y @ W[i]
File ".conda/envs/horovod/lib/python3.8/site-packages/cupyx/scipy/sparse/base.py", line 126, in matmul
return self.mul(other)
File ".conda/envs/horovod/lib/python3.8/site-packages/cupyx/scipy/sparse/csr.py", line 156, in mul
return cusparse.csrgemm2(self, other)
File ".conda/envs/horovod/lib/python3.8/site-packages/cupy/cusparse.py", line 751, in csrgemm2
c_indices = _cupy.empty(int(c_nnz), _numpy.int64)
File ".conda/envs/horovod/lib/python3.8/site-packages/cupy/_creation/basic.py", line 22, in empty
return cupy.ndarray(shape, dtype, order=order)
File "cupy/_core/core.pyx", line 150, in cupy._core.core.ndarray.init
ValueError: Negative dimensions are not allowed

Sorry for the inconvenience, but currently sparse matrices have 32-bit limit. These routines are written using deprecated cuSPARSE APIs (which have 32-bit limit) and need to be rewritten using generic APIs introduced in CUDA 11.0. (#3513)

We're going to work on this targeting v12 release. #3513


Support overloaded functions in gas report

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.1.0 (db909f2 2022-03-18T00:07:32.053844+00:00)
What command(s) is the bug in?
forge test --gas-report
Operating System
macOS (amd)
Describe the bug
Not sure if this is a bug or feature request. I have an overloaded function called getHp that accepts either one or three parameters. I see that the gas results are combined into one function.
Heres an example gas report with getHp as an overloaded function:

and heres me splitting getHp into two separate functions (getHp and getHp1), this is more how I would expect forge to show the gas cost for an overloaded function:

Hey looking for a good first issue, could I take this one?

@onbjerg Hey looking for a good first issue, could I take this on


fix(cart): loads correct cart for logged in/logged out user in all views

Assignee Tasks

fixes issue where logging in, logging out, or refreshing the page would load cart before loading user.

Very nice!


Update Visio Sample Query

Changed Visio Query from %Visio% to Microsoft%Visio% because the former can have lots of false positives when certain updates are installed on the PCs.
Related Issue #940

@alayac : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

Thanks @alayac for your contribution! This looks good, #sign-off
Fixes #940
Once merged, this should be live with the next daily publishing process. Right now that should be tomorrow (Friday, 19 October) around 11:00 Pacific time. No further action needed from you.


Sec Hardsuit resprite

About the PR

resprited the security hardsuit. the new look is a combination of the wizden sec hardsuit and the current goob station hardsuit. the hardsuit has the basic form of the wizden suit but with the color palate and extra elements of goob station suits.
Why / Balance

I just thought that the look of the basic sec hardsuit look strange. i think this version suits sec better
Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

resprited sec hardsuit
resprited sec hardsuit helmet

Summary by CodeRabbit

New Features

Updated copyright information for security hardsuit textures, providing clearer attribution to the sprite creators.

Bug Fixes

Corrected attributions in the metadata for both the head and outer clothing hardsuits to reflect the latest contributions and redesigns.

check failure seems unrelated

check failure seems unrelated

i dunno why is it showing failure i didn't remove any script

Dark Samus, no way.

check failure seems unrelated

i dunno why is it showing failure i didn't remove any script

not your fault, check failure unrelated to this pr


Dr8g0n

Short Description:
Currently, if it falls into the if (seconds_since_last_check < self.MIN_SECONDS_ALLOWED_FOR_CELL_CHECK) statement, the wait time is around 1 second and that does not give enough time for the Pokemon to show up. It ended up missing some of the Pokemon.
Added wait time between 5-10 second to allow the Pokemon to show up
Fixes/Resolves/Closes (please use correct syntax):
#5669

Oh, and by the way... Please give the PR a descriptive name. Just putting your name into it without any real contents is nad habit.


Markers in radius of circle?

I'm trying to know if a MapView.marker is inside of the radius of a MapView.Circle. I don't see any documentation explaining how to do this. Please give me something to try to figure out how to implement this feature.

Share a snippet :)

@nikolas7892 https://www.movable-type.co.uk/scripts/latlong.html

Do you have any example, bro?

i used isPointInCircle function of react native geolib.
https://github.com/manuelbieh/Geolib/blob/master/README.md

did u solve it? iam trying the same but i dont have a clue how to do it :/

Do you have sample code? I need it urgently, unable to do it. Please help me

This can be achieved using Circle component of maps
Here is an example
import MapView, {Marker, Circle} from 'react-native-maps';

<MapView
  initialRegion={{
    latitude: 21.239724,
    longitude: 72.9382757,
    latitudeDelta: 0.0922,
    longitudeDelta: 0.0421,
  }}
  >
  <Marker coordinate={{latitude: 21.239724, longitude: 72.9382757}} />
  <Circle
    center={{
      latitude: 21.239724,
      longitude: 72.9382757,
    }}
    radius={5000}
    fillColor="#5A66CD1A"
    strokeWidth={0}
  />
</MapView>


10s超时,配置文件修改

Coverage decreased (-11.8%) to 30.675% when pulling b856304f87152ea4b6e8f57c943b02879e429009 on 87439247:dev into f52fc87a56969d8365b17cab3f896d616ac6c1b8 on knightliao:dev.

Coverage decreased (-11.8%) to 30.675% when pulling b856304f87152ea4b6e8f57c943b02879e429009 on 87439247:dev into f52fc87a56969d8365b17cab3f896d616ac6c1b8 on knightliao:dev.


Part 1 of Network Transform improvements

JesusLuvsYooh Edit V1.1  March 11 2021
1: targetComponent.transform changed to targetComponent
(targetComponent is a transform)
2: syncScale boolean
(Off by default, it should be very rare cases that people want continuous sync scale, instantly saves ~25% bandwidth (12 bytes) )
3: smoothScale boolean
(Use-case: Instant flipping of sprites that use -X and +X for direction, added by popular demand)
4: Removed some static's from functions, alternative was to set the booleans above as statics?
(which would you prefer, open to change)
5: CmdClientToServerSync [Command] changed to [Command(channel = Channels.DefaultUnreliable)]
(because why not?  unreliable channel is great for mass un-important data, use and abuse it if possible)

I'l happily go through each change with someone and explain, i am splitting these NT changes up into smaller chunks already, please don't make me submit each boolean individually.

1: targetComponent.transform changed to targetComponent

This was fixed in master.

1: targetComponent.transform changed to targetComponent

This was fixed in master.

Super.  Noticed you fixed it on NTE, was strange to see it still in NT.

Maybe create a command function that can be used to flip syncScale? Otherwise it cant be changed during the game

Additionally if the value for syncScale is changed on one side only it might break this code in NetworkIdentidy if there are multiple networked components:
        internal void OnDeserializeAllSafely(NetworkReader reader, bool initialState)         {             // deserialize all components that were received             NetworkBehaviour[] components = NetworkBehaviours;             while (reader.Position < reader.Length)             {                 // read & check index [0..255]                 byte index = reader.ReadByte();                 if (index < components.Length)                 {                     // deserialize this component                     OnDeserializeSafely(components[index], reader, initialState);                 }             }         }
I also believe if you change the value in a command you would need to send an acknowledgement to make sure you only start sending when its confirmed to be changed.

Maybe create a command function that can be used to flip syncScale? Otherwise it cant be changed during the game

Even when they did that, network transform would still smooth transition the sprite scale, looking weird on flat images as you can imagine.
They could turn off scale (if the boolean gets accepted), and then send cmd/syncvar for scale -X or scale +X.
But with the smooth scale boolean it will solve that for them  :)

Additionally if the value for syncScale is changed on one side only it might break this code in NetworkIdentidy if there are multiple networked components:
internal void OnDeserializeAllSafely(NetworkReader reader, bool initialState) {
            // deserialize all components that were received
            NetworkBehaviour[] components = NetworkBehaviours;
            while (reader.Position < reader.Length) {
                // read & check index [0..255]
                byte index = reader.ReadByte();
                if (index < components.Length)
                {
                    // deserialize this component
                    OnDeserializeSafely(components[index], reader, initialState);
                }
            }
        }

I also believe if you change the value in a command you would need to send an acknowledgement to make sure you only start sending when its confirmed to be changed.

It sure does break, but only on the person thats altered their project (just tested it), but you could argue same happens with regular commands, sync vars or any other code, if i go and change CmdDamage(int) to CmdDamage(string).
If server and client don't match up, errors are expected.
However i'l go and add some checks.

@JesusLuvsYooh targetComponent.transform is great, thanks.
networktransform based on the glenn fiedler article is coming soon. fully unreliable.
let's not do any more possible breaking on this one here.
just changing to unreliable isn't enough, we need unreliable ordered etc.
give me a few more weeks. slowly getting there. see roadmap :)

I'l continue to give people the changes manually for now then, when they need them.


Add support for Configurable Slots and Slot prompts

Amazon Lex bots & Alexa skills use intents to encapsulate the purpose of an interaction and slots to capture elements of information from the interaction.
QnABot has a single purpose, to answer a user’s question, so we (currently) define just one intent.
This intent has a single slot which is trained to capture the text of the question.
But this simple model has limitations. It doesn’t support concept of ‘clarifying questions’ when the initial question is missing key information needed to provide an answer... like this:
User: 		“When is your next training class?”
QnABot: 	“For which course?”
User: 		“Building Bots on AWS”
QnABot:	 “Which city?”
User: 		“Las Vegas”
QnABot: 	“The next AWS Bot Building class in Las Vegas is on July 20, 2018”
It also can’t parse specific fields in the question to use as parameters:
User: 		“What is 3 times 4?”
QnABot: 	“I don’t know, you didn’t give me the answer to that question.”
For these scenarios, we should probably use Lex (with custom intents/slots) to parse out slot values, and prompt for required slots.  We should consider using automatically created nested bots for these types of interactions, not just adding intents to the QnABot bot - nested bots will provide better isolation and less risk of mismatched intents. QnABot Lambda hooks can 'route' requests to the correct nested bot, and relay responses back to the client.
Design to be discussed and determined

would these customer user intents be another document type?
or set some other page?


Feature request/question: Ability to mark some code to not be pre-initialised

Howdy 👋
Is there a way to mark some code to not be pre-initialised? For example, any code which is in the optimization path but is trying to make host calls?
I came across an issue with using Fastly's js-compute-runtime which stems from some code being optimized by Wizer that ideally shouldn't be.
I can work around the issue by changing parts of my program's code to no longer be optimisable by Wizer
but I do wonder if this will be a common enough scenario that perhaps Wizer could be instructed to not pre-initialise some code paths.

I think this might not be possible—at least I can't think of a way to do it.
However, what I think should be happening is that we trap whenever content tries to call a hostcall that's not actually available—which is what's happening here. @fitzgen I thought that's what we're doing, but apparently not?
@JakeChampion to be clear, trapping on these hostcalls wouldn't fix anything—it'd just fail earlier :) I'll comment on the js-compute-runtime issue on how to fix the issues you're running into with that.

Yeah there isn't really a good way for Wizer to determine which state should be snapshotted and which shouldn't. The best thing to do is to write your program such that it only makes changes you want to be snapshotted in the wizer.initialize function.

@JakeChampion the next release of js-compute-runtime will address this by throwing on attempts to use request-handler-only functionality.
Given that this isn't really something that can be improved further in Wizer, I'll go ahead and close this issue.


Read password property from file

I propose a simple update to read password from files. I need this to be able to read password from files  created with docker secrets. If you accept this a similar change would be needed in the DT repo as well, to handle HTTP_PROXY_PASSWORD_FILE.

Thanks for the PR. I think the approach is solid, although I'm not a fan of having a separate method for this type of query. But I understand why it was done.

@jozseftiborcz I just happened to be prepping for a release anyway, so I was able to include this functionality (along with the corresponding change in DT) in Alpine 1.7.0 and DT 3.7.1

@stevespringett Thank you! I will update then my compose file to the new version.


Updated obsolete package instructions

Full message on Ubuntu:
Package libqtcore5 is not available, but is referred to by another package. This may mean that the package is missing, has been obsoleted, or is only available from another source
However the following packages replace it:
libqt5core5a:i386  libqtcore5a

On which Ubuntu Release do you get this message?

14.04 LTS

Can you rework this to include a new section for 14.04 and above? ie, just like the "for Ubuntu >= 12.04"

Sure how does that look?

sweet. thanks!


Update the yoga /meditation project using html , bootstrap and vanilla js

##Is your feature request related to a problem? Please describe.
No its not a problem. I tried to add a meditation app
Describe the solution you'd like
It is a meditation app which will allow users to choose the time limit and type of music they want for meditating.
Additional context
I am a GSSOC'21 participant, please assign this issue to me. @Vishal-raj-1 @harshgupta20 @urvashi-code1255 @991rajat

@Vishal-raj-1 @harshgupta20 can i start working on it?

I think the project exist. Named yoga app.
Please checkout. If you want to improve upon it comment here. Will be happy to assign you.

yes @991rajat i would like to improve the yoga app by adding more music options along with different time limits to do meditation and also a days wise calendar to check that the user doesnt forget to do mediation any day.

@anshika208 Its great project, but since this project already exist we can't make another one with same concept but you can improve the existing project.

yes I will improve the existing one @harshgupta20

hey! @991rajat i have made a pr regarding this issue 5 days ago ... pls do have a look. thanku!!


Fixes https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4163
Docs PR Checklist

[x] This PR is for a documentation page whose authoritative copy is in the
opentelemetry.io repository.

PTAL @open-telemetry/go-maintainers

@pellared I am currently working on a larger PR towards the registry including this change, to avoid merge conflicts can we have it in one?

@pellared I am currently working on a larger PR towards the registry including this change, to avoid merge conflicts can we have it in one?

LGTM

see #3292


Added singleton design pattern in Java

Sure
On Sun, 3 Oct 2021, 11:23 Sonu, @.***> wrote:

@.**** commented on this pull request.
Hi @Deshan-Chathuranga https://github.com/Deshan-Chathuranga
Could you please briefly explain all the 3 ways in the readme?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/craplab/WeirdScripts/pull/33#pullrequestreview-769547961,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP2ZQ64OPR7UMPXV3ZNCPX3UE7VT7ANCNFSM5FGRSWBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[LLVMGPU] Workaround wrong signed extension of buffer offsets

Buffers can currently only have 32bits unsigned offset but we mistakently signe extend them to 64bits for 64bits targets. In order to prevent getting a negative offset we force trunc the offset to 32bits and drop the higher bits.
The proper fix would be to support zero extended casting for i32 to index. The proper fix will be tracked here:
https://github.com/iree-org/iree/issues/10615

Let me know if you have any thoughts on this workaround

Is this still needed?

Is this still needed?

no, sorry forgot to update. Looks like people are fine with adding a new IndexCastOp upstream so I'm going that route.


transformers

This PR enables transformers example.
For optimum lib, see: https://github.com/huggingface/optimum/pull/2064
For transformers lib, see: https://github.com/huggingface/transformers/pull/35012
Apply the 2 changes and this PR can run the example transformers_usage.py

@jiqing-feng Ran out of time today. We will check the two prs and test tomorrow and see if there is anything we should change. The only thing that I see that I may want to change is to make sure transformers/optimum not call any internal methods such as select_quant_linear directly. Want to expose a more stable api, maybe even just a wrapper to select_quant_linear like hf_select_quant_linear so that we can play and fudge with internal api all we want and not breakhf_select_quant_linear.

@jiqing-feng Ran out of time today. We will check the two prs and test tomorrow and see if there is anything we should change. The only thing that I see that I may want to change is to make sure transformers/optimum not call any internal methods such as select_quant_linear directly. Want to expose a more stable api, maybe even just a wrapper to select_quant_linear like hf_select_quant_linear so that we can play and fudge with internal api all we want and not breakhf_select_quant_linear.

Agree, I have integrated hf_select_quant_linear in the same place.

Hi @Qubitium . The optimum and transformers PR have been verified on CPU, do you mind verifying it on cuda? I always met building issues when I built gptqmodel from source.

@jiqing-feng Ok. Can you show me your cuda compile errors? I want to check if related to our compiler flags and/or env.

@jiqing-feng Ok. Can you show me your cuda compile errors? I want to check if related to our compiler flags and/or env.

  /usr/local/cuda/include/cuda_bf16.hpp(3736): note #3326-D: function "atomicAdd(__nv_bfloat162 *, __nv_bfloat162)" does not match because argument #1 does not match parameter
    static __attribute__((device)) __inline__ __nv_bfloat162 atomicAdd(__nv_bfloat162 *const address, const __nv_bfloat162 val)
                                                             ^
  /usr/local/cuda/include/cuda_fp16.hpp(3390): note #3326-D: function "atomicAdd(__half2 *, __half2)" does not match because argument #1 does not match parameter
    static __attribute__((device)) __inline__ __half2 atomicAdd(__half2 *const address, const __half2 val) {
                                                      ^
  /usr/local/cuda/include/sm_20_atomic_functions.hpp(82): note #3326-D: function "atomicAdd(float *, float)" does not match because argument #1 does not match parameter
    static __inline__ __attribute__((device)) float atomicAdd(float *address, float val)
                                                    ^
  /usr/local/cuda/include/device_atomic_functions.hpp(224): note #3326-D: function "atomicAdd(unsigned long long *, unsigned long long)" does not match because argument #1 does not match parameter
    static __inline__ __attribute__((device)) unsigned long long int atomicAdd(unsigned long long int *address, unsigned long long int val)
                                                                     ^
  /usr/local/cuda/include/device_atomic_functions.hpp(110): note #3326-D: function "atomicAdd(unsigned int *, unsigned int)" does not match because argument #1 does not match parameter
    static __inline__ __attribute__((device)) unsigned int atomicAdd(unsigned int *address, unsigned int val)
                                                           ^
  /usr/local/cuda/include/device_atomic_functions.hpp(105): note #3326-D: function "atomicAdd(int *, int)" does not match because argument #1 does not match parameter
    static __inline__ __attribute__((device)) int atomicAdd(int *address, int val)
                                                  ^
            detected during instantiation of "void VecQuant8MatMulKernel(const scalar_t *, const int *, scalar_t *, const scalar_t *, const int *, const int *, int, int, int, int, int) [with scalar_t=double]" a
t line 489

  4 errors detected in the compilation of "/workspace/jiqing/GPTQModel/gptqmodel_ext/cuda_64/gptqmodel_cuda_kernel_64.cu".
  ninja: build stopped: subcommand failed.
  Traceback (most recent call last):
    File "/workspace/jiqing/GPTQModel/setup.py", line 219, in run
      urllib.request.urlretrieve(wheel_url, wheel_filename)
    File "/usr/lib/python3.10/urllib/request.py", line 241, in urlretrieve
      with contextlib.closing(urlopen(url, data)) as fp:
    File "/usr/lib/python3.10/urllib/request.py", line 216, in urlopen
      return opener.open(url, data, timeout)
    File "/usr/lib/python3.10/urllib/request.py", line 525, in open
      response = meth(req, response)
    File "/usr/lib/python3.10/urllib/request.py", line 634, in http_response
      response = self.parent.error(
    File "/usr/lib/python3.10/urllib/request.py", line 563, in error
      return self._call_chain(*args)
    File "/usr/lib/python3.10/urllib/request.py", line 496, in _call_chain
      result = func(*args)
    File "/usr/lib/python3.10/urllib/request.py", line 643, in http_error_default
      raise HTTPError(req.full_url, code, msg, hdrs, fp)
  urllib.error.HTTPError: HTTP Error 404: Not Found

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 2104, in _run_ninja_build
      subprocess.run(
    File "/usr/lib/python3.10/subprocess.py", line 526, in run
      raise CalledProcessError(retcode, process.args,
  subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

  The above exception was the direct cause of the following exception:

  Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "/workspace/jiqing/GPTQModel/setup.py", line 237, in <module>
      setup(
    File "/usr/local/lib/python3.10/dist-packages/setuptools/__init__.py", line 117, in setup
      return distutils.core.setup(**attrs)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/core.py", line 183, in setup
      return run_commands(dist)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/core.py", line 199, in run_commands
      dist.run_commands()
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/dist.py", line 954, in run_commands
      self.run_command(cmd)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/dist.py", line 995, in run_command
      super().run_command(command)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/dist.py", line 973, in run_command
      cmd_obj.run()
    File "/workspace/jiqing/GPTQModel/setup.py", line 234, in run
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/command/build.py", line 135, in run
      self.run_command(cmd_name)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/cmd.py", line 316, in run_command
      self.distribution.run_command(command)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/dist.py", line 995, in run_command
      super().run_command(command)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/dist.py", line 973, in run_command
      cmd_obj.run()
    File "/usr/local/lib/python3.10/dist-packages/setuptools/command/build_ext.py", line 99, in run
      _build_ext.run(self)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/command/build_ext.py", line 359, in run
      self.build_extensions()
    File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 868, in build_extensions
      build_ext.build_extensions(self)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/command/build_ext.py", line 476, in build_extensions
      self._build_extensions_serial()
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/command/build_ext.py", line 502, in _build_extensions_serial
      self.build_extension(ext)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/command/build_ext.py", line 264, in build_extension
      _build_ext.build_extension(self, ext)
    File "/usr/local/lib/python3.10/dist-packages/Cython/Distutils/build_ext.py", line 135, in build_extension
      super(build_ext, self).build_extension(ext)
    File "/usr/local/lib/python3.10/dist-packages/setuptools/_distutils/command/build_ext.py", line 557, in build_extension
      objects = self.compiler.compile(
    File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 681, in unix_wrap_ninja_compile
      _write_ninja_file_and_compile_objects(
    File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 1784, in _write_ninja_file_and_compile_objects
      _run_ninja_build(
    File "/usr/local/lib/python3.10/dist-packages/torch/utils/cpp_extension.py", line 2120, in _run_ninja_build
      raise RuntimeError(message) from e
  RuntimeError: Error compiling objects for extension
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: /usr/bin/python -u -c '
  exec(compile('"'"''"'"''"'"'
  #   setuptools doesn'"'"'t think the script is `-c`. This avoids the following warning:                                                                                [210/1924]
  #     manifest_maker: standard file '"'"'-c'"'"' not found".
  # - It generates a shim setup.py, for handling setup.cfg-only projects.
  import os, sys, tokenize

  try:
      import setuptools
  except ImportError as error:
      print(
          "ERROR: Can not execute `setup.py` since setuptools is not available in "
          "the build environment.",
          file=sys.stderr,
      )
      sys.exit(1)

  __file__ = %r
  sys.argv[0] = __file__

  if os.path.exists(__file__):
      filename = __file__
      with tokenize.open(__file__) as f:
          setup_py_code = f.read()
  else:
      filename = "<auto-generated setuptools caller>"
      setup_py_code = "from setuptools import setup; setup()"

  exec(compile(setup_py_code, filename, "exec"))
  '"'"''"'"''"'"' % ('"'"'/workspace/jiqing/GPTQModel/setup.py'"'"',), "<pip-setuptools-caller>", "exec"))' bdist_wheel -d /tmp/pip-wheel-tapcuacz
  cwd: /workspace/jiqing/GPTQModel/
  Building wheel for gptqmodel (setup.py) ... error
  ERROR: Failed building wheel for gptqmodel

@CSY-ModelCloud I see a 404 urllib error. Caused by our whl download code?

@jiqing-feng Please change the tranaformer and optimum Pr into draft mode until it passes tests. Right now it is not passing and some changes are required.

@jiqing-feng Please change the tranaformer and optimum Pr into draft mode until it passes tests. Right now it is not passing and some changes are required.

Got it.

@jiqing-feng biggest issue right now that is gptqmodel's internal format is gptq_v2 so directly using the quant-linear doesnt work for old quanted models such as thebloke or other gptq quantizers that use gptq v1.
The fix is that gptqmodel needs to receive the full GPTQConfig to post_init so we can upconvert v1 to v2.

Unit tests https://github.com/ModelCloud/GPTQModel/pull/724
quantization and inference for GPTQ and GPTQ_v2 have been fixed. Created two PRs requesting to merge into jiqing-feng's branch:
jiqing-feng/optimum,  https://github.com/jiqing-feng/optimum/pull/1/files
jiqing-feng/transformers, https://github.com/jiqing-feng/transformers/pull/1


README typo fix (meta file is json)

Yep, good catch. I was up until like 4am that night and apparently the README suffered for it. Merged.


Moto missing new EC2 Subnet attribute "Ipv6Native"

The EC2 Subnet data model was updated to support the launch of IPv6-only subnets as seen in the Response Syntax here: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.describe_subnets
As part of this release a new attribute was added to indicate that a subnet is IPv6 only.
While it would be nice to add full support for ipv6 only subnets to moto over time, in the short term it would be great if the relevant describe responses included this new attribute with value set to False

Hi @davidaah, thanks for raising this - will mark it as an enhancement.
If you want to contribute this to Moto, PR's are always welcome!


Bypass content warning

I spent a while trying to use this to download the amazing words at http://brucecameronelliott.blogspot.com/
I managed to bypass the content warning by copying the interstitial parameter from the button and appending it to the url before downloading.
I also used the mobile version of the site because the script's pattern matching doesn't work on the desktop version.
Posting here in case anyone wants it: https://github.com/rosano/blogspot2epub/commit/687fe1e82d14224a9dc171d8b0a732452657382f

And one more change to allow the script to find older posts: https://github.com/rosano/blogspot2epub/commit/b161f1da99707f1395394e0cf200cdfcf3cda337

As I wrote in comment to your pull request I'm working currently on code refactor.
This script evolved directly from kind of "proof of concept" thing... so this kind of bugs don't surprise me at all ;-)
Idea of scraping mobile version looks really cool to me. I think I will add this to next version.

Added support for atom feed - interstitial cookie value is setted but logic behind that is more complex.
Currently blogs with "interstitial" landing page are crawled to 25 last posts only, but half a loaf is better than nothing!


Stopped working when navigate

Hello,
I'm with the following problem...
The LazyLoad component is working well in same page, but when I click in a button and navigate to another screen and then I click on navigate back to previous screen, it doesn't reload my lazyloaded components.
I already tried to use forceCheck on componentDidMount of my container.

Anyone can help-me? Thank you

is there any console error?

That was a problem with height property.... I don't know why... But when I removed this property it worked fine...


to fix edit this page link

Accidentaly discovered the issue in edit this page. Unsure if this is acceptable for you guys. Don't hesitate to reject in case you've other plans or a better fix.
FYI @cdoan1

/assign @qiujian16

/assign @qiujian16

thanks!

thanks!

It was nothing!

It was nothing!


Fixes #1386 - not being able to serialize IReadonlyCollection while using CollectionStorage.AsArray

As in the description - see more details in #1386
Besides providing the fix and adding test for the described case, I updated inner collection queries tests to be sure that this case won't be missed again.

So first off, big kudos for the test coverage. Other than that, as long as the tests all pass, I can't see any issue with the change.


Linux/Windows bots are stuck

In #11459 we noticed that both the Linux and the Windows bots are having troubles; see https://github.com/mozilla/pdf.js/pull/11459#issuecomment-571196047. We also noticed this in https://github.com/mozilla/pdf.js/pull/11465#issuecomment-571108988.
@brendandahl @yurydelendik Could one of you restart both bots?

Also, looking at the logs it seems that Google Chrome hasn't been updated in quite some time (note the excerpts below), which probably explains some of recently seen failures as well.
While it seems that Firefox updates automatically as expected (to track the Beta release channel), that doesn't seem to happen with Google Chrome (since the current Beta release is 80).
Linux bot:
User agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.71 Safari/537.36

Windows bot:
User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36


[FormBuilderTypeAhead] suggestion list is not adjusting

Hi,
Then type ahead field is focused and keyboard is visible, suggestion list gets wrong size

How to scroll up more on field focus and give more space between field and keyboard?
Arnoldas

This is a configuration of external dependency
Try take a look on this readme https://github.com/AbdulRahmanAlHamali/flutter_typeahead#customizing-the-suggestions-box


cd /work/data/ at initialization of Docker container

At initialization of Docker container, the following response is generated immediately:
bash: cd: /work/data: No such file or directory

Apparently, the container is tasked with changing directory to /work/data at initialization. But I don't know where this command is coming from; there is no .bashrc in the container.

Maybe it is the ENTRYPOINT of the Alpino Docker? I'll check that

Yes, it is:
CMD ["/bin/bash", "--rcfile", "/init.sh"]


Metadata search doesn't work in Exasol

System information:

Operating system (distribution) and version Win10
DBeaver version 7.2.4 EA

Connection specification:

Database name and version Exasol

Steps to reproduce, if exist:
Open metadata search and try to find an existed object
Expected: the object is found
Actual result:  Found 0 objects

works as expected - default schema should be selected


Add LocalAccessTokenValidation authentication scheme

https://github.com/Kahbazi/IdentityServer4.Contrib.LocalAccessTokenValidation/issues/2
To improve it we can add AuthenticationEvents and RequireHttpsMetadata to options.

The PR needs to be done against dev. thanks!


commands: submit_tuxbuild: Use build_name if set

If a build has a build_name defined by Tuxbuild (originally from tuxsuite build --build-name NAME, then use that as the name for the kernel configuration that identifies the build.

assuming you just have to add
"build_name": "gcc-11-lkftconfig",
in the tests/data/submit/tuxbuild/build.json

Can I drop this?

Yes


Feature/dist config enhancements

Add a default local dist config. Minor housekeeping of main dist config. Updated README mentioning the local dist.

I'm not completly sure if this pull request should be merged.
The distributable global config file is just an example so that users can see how to structure every configuration section. Anyone who has worked for a week with ZF2 knows how global and local configuration works, and knows how to properly rename provided file. Indeed, the global and local config works only because it has been defined that way in the skeleton application.
Having two distributable config files makes it harder to maintain, since any change in the configuration structure will need to be updated in two different files. This is why I think I'm not going to merge this.
However, I appreciate your effort, thank you :-)

What about if I remove the duplicate settings, so the server-specific ones are only in the local? It seems to me that I will always want those settings to be environment specific, and I guess others will too. Another alternative would be to annotate them more clearly in the example file, so it's easier to distinguish the app-specific settings from the environment-specific ones.

But that separation is not up to the module. It depends on what each user wants to do.
Of course, there are concrete settings (like SMTP passwords) that should be placed in local config files, but as I said, each project will work in a different way.


⚠ Bofrost.fr has degraded performance

In 61e55b2, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 865 ms

Resolved: Bofrost.fr performance has improved in 7bf653e after 6 minutes.


Added demo and Content : CopilotMate

Hacktoberfest submission

Hi @AkashJana18, excellent job!
Can you please unlink the issues
We want to leave them open until Hacktoberfest ends.

Sure @NathanTarbert :)

@AkashJana18, please remove all files except markdown.

@NathanTarbert i don't see any other files attached to PR except the copilotmate.md

@quest-bot loot #645

@quest-bot loot #634

@quest-bot loot #644

@quest-bot loot #626


JCenter/Maven support

Any intention to support JCenter/Maven distribution?

Hi @amouly - I'll be honest, I'm still learning how to do that.


v2 Roadmap

This is a placeholder for potential major changes in the next version

Split PDF export into a separate, optional package #157
Refactor & simplify components codebase
Handle focus trapping #93
New UI for presenting and modes, including touchscreen UI #6
Update layout styles, simplifying custom layout components

Would love the ability to easily combine layouts like:
---
export Split,Invert`

# Heading
---

or something similar

Multiple themes per deck ((deck with two kind of slides))
Video-Component ((make it pop 🦄))

I have two points:

it would be nice to utilise default mdx/loader
extract mdx-deck as a standalone package for easier integration into other frameworks (CRA, next)

@QuentinRoy I built kinda something like this when playing around with "one slide per step" PDF export.
Currently looks like this, steps are derived from whether the a component constructor calls setSteps (current behavior, abstraction could be better)
// Simple Appear, internally using steps

  <Appear>

One

Two

Three

Four

  </Appear>

// Using the `AppearComponent` directly
<Steps>
  {({ step, setSteps }) => {
    return (

        <AppearComponent step={step} setSteps={setSteps}>

One

Two

Three

Four

        </AppearComponent>

    )
  }}
</Steps>

---

is this something wanted? (cc: @jxnblk) I could make a PR out of it easily, but would like to discuss some state management concept, which would be subject to "Refactor & simplify components codebase"

@zcei I am open to it. It would enable me to do what I need. Does <Step> also accept class components (and still give it step and setSteps as argument)? If not that means a sub component needs to be created if one want to have access to componentDidUpdate. It is OK, but I think it would be nicer if one does not need that.
Something that bothered me a bit however is having setSteps as an argument. That implies it can it be called by the subcomponent multiple time. From what I have seen in the code, it seems it implies significant change (maybe that is what your refactor is about). Also, it is a bit unclear what would happen if setSteps is called with a value lesser than the current step? Would mdx-deck switch to the next slide?
These are the reasons I thought a Higher Order Component would be easier. It seems it can be implemented in a few line of codes. Though I agree that it requires a bit more React mastery from users.

The problem I saw with the HOC is that is required mdx to understand any arbitrary JS. As far as I know it only looks at import & export statements plus the < JSX indicator.
So one would always need to move that code out of the presentation into its own file.
The componentDidUpdate thing is something I have to look into, did not consider it for the PDF export.
Yes, my refactor is about setSteps (or better the metadata management in itself). It should accept multiple components having steps, basically adding up the individual step counts to a total amount. How that would exactly looks like: don't know yet.
In general it's about the question whether the user should explicitly define the number of steps or it should be derived from the components on that slide. Open for discussion 🙂

Ah! Good point. I didn't thought about that.
I believe setSteps can only be derived automatically in the case of adding elements (which I think is already pretty well done by <Appear>). But my use case requires more than that. What if elements shouldn't be added but replaced, and what if something else needs to be done using the step argument (e.g., again, updating a D3 chart).

I believe setSteps can only be derived automatically in the case of adding elements

Yes, that's why I exposed it, as a lot of use-cases won't have this luxury.

What if elements shouldn't be added but replaced, or what if something else needs to be done using the step argument

I think then you need a component that in the contructor sets the steps and if necessary during the lifetime it would call setSteps again to update it current totals? 🤔 This way we would definitely need to store the steps per component in the state, so that it can later be updated.
Would you know the exact steps up front for D3 stuff? And do you trigger the next step by yourself, or should D3 say that the next step starts by emitting some event? Just trying to get a solid understanding of different use-cases.

Would you know the exact steps up front for D3 stuff?

Yes. In my case I would always know. Maybe there is cases where you do not but, I do not have any in mind..

And do you trigger the next step by yourself, or should D3 say that the next step starts by emitting some event?

No in my use case I want to trigger the even myself. This being said, having and API to programmatically change step would be interesting as well. But I think that is something else.

Would you mind opening another issue related to a render prop based API for Appear? I want to make sure the thoughts related to that don't get lost

Done, see #193. I tried to briefly summarize the discussion.

Would like the placement of content in Layout like it gitpitch snaplayouts - https://medium.com/@gitpitch/snap-layouts-for-gitpitch-markdown-presentations-29800f642586
As you already captured, layouts could use more love.

Just published v2 beta, which should resolve some of the things mentioned here. Feel free to open other new issues with any additional feature requests

@jxnblk can you update either CHANGELOG.md or GitHub releases with more details about what has been released?


Explain engine variable

Hello there,
Your documentation is really wonderful, the best I've seen - Even better than MSDN
In your Chapter 1 you talk about the scene and you have the following code:
const scene = new BABYLON.Scene(engine);

You don't seem to explain what the engine variable is, unless I missed it, I noticed from a later code snippet that it is a BABYLON.Engine but I think you need to explain that in Chapther 1

Really great suggestion! @PirateJC can we had something here?

I concur, I didn't understand what an "engine" is supposed to be or why I as a beginner should care about it either back when I started using BabylonJS.
IMHO, the following questions should be answered:

What is the Engine?
Why is it needed?
What else can I do with it (link to API docs/further reading, too much information otherwise)?

Awesome suggestions everyone! Sorry for the delay in getting to this.
I've added a description of why the engine variable is needed in the scene constructor:
https://github.com/BabylonJS/Documentation/pull/404


请务必支持简体字

希望可以同时支持繁体和简体字，以及繁简体的互相转化。

Explain why? Is it not natural to support only the TRADITIONAL characters, since the point of the project is to write in TRADITIONAL chinese?

As the README said, it should be Classic Chinese.

文言宜以繁體書之。蓋簡體有異字無別之弊，易有歧義。

簡繁體誠無大礙，然以「「」」為引號，余實感不便

然。吾亦以「」為不便。如語法嚴謹，料引號非必須也。若恐閱讀不便，不妨於變量邊緣留空，蓋文言本無空白，亦無句讀。

@melop quotes are necessary to distinguish identifiers from keywords. Imagine if you have an identifier, whose substring happens to be a keyword, then ambiguity would be introduced. The only way would be to forbid any identifier to contain any character from keywords, which is obviously a bad idea. Not to mention if more keywords are added to the language, old code will keep breaking.
Most English-based programming languages doesn't have this problem because English naturally have spaces. For Chinese, spaces would look even less appealing than the quotes in my opinion.
Thanks everyone for the discussion!


Open boundary condition in mfem

Dear developer,
We are trying to develop a pressure correction based NS solver based on MFEM, and I have a question regarding to the implementation of open boundary for flow simulation.
My problem is the following:
Assume we have a time dependent stokes equation on a pipe:
u_ t - \laplace (u) + \grad(p) = f
div(u) = 0
on the inlet we have Dirichlet boundary condition u = u_in
on the wall we have no slip boundary condition u = 0
on the outlet we have open boundary, namely \grad(u) n  = p n, here p is the outgoing normal vector
In pressure correction method, inlet and wall are standard Dirichlet boundary conditions. The outlet boundary can be treated as the nonhomogeneous Neumann boundary condition when solving velocity diffusion:
(u^(k+1) - u^(k))/dt - \laplace (u^(k+1)) + \grad(p^(k)) = f
My question is for the implementation of this step in mfem.
More specifically, to implement \grad(u^{k+1}) n  = p^{k} n on boundary, I think the best way in mfem is using
b->AddBoundaryIntegrator(new VectorBoundaryLFIntegrator(f));
here f = p^{k} n
Here comes the problem: based on the iterative pressure correction method, p^{k} is a scalar gridfunction on whole domain and boundary. However,  the input of VectorBoundaryLFIntegrator() should be a vector valued function defend only on boundary. To simplify the problem let's say we know exactly what n is on the outlet boundary. How can I construct my boundary condition using mfem?
Thanks.

If I understand correctly you are probably looking for a (not yet existing) VectorBoundaryNormalLFIntegrator.
You can modify VectorBoundaryLFIntegrator to multiply you input, in this case p^{k}, with the normal vector. The source of BoundaryNormalLFIntegrator should help accomplishing that.

If I understand correctly you are probably looking for a (not yet existing) VectorBoundaryNormalLFIntegrator.
You can modify VectorBoundaryLFIntegrator to &multiply you input, in this case p^{k}, with the normal vector. The source of BoundaryNormalLFIntegrator should help accomplishing that.

@jandrej Thank you for the reply. I would like to clarify my question a bit. At the moment the main problem is not finding the normal vector on the boundary. In my case it is a known constant vector. My main problem is the API of VectorBoundaryLFIntegrator.
Please correct me if I'm wrong, the input of vectorboundaryintegrator cannot be a gridfunction defined on the domain. Its input has to be a vector valued function defined on the boundary. As the result
'VectorBoundaryLFIntegrator(p^{k} n)' is not correct.
The same restriction applied to boundarynormallfintegrator as well. 'BoundaryNormalLFIntegrator(p^{k})' is also wrong.
Thus from coding perspective, I think my question is: how can I construct a vector valued function from a gridfunction by only using its boundary points.

Hi @gzict,
If I understand you need the boundary linear form integrator (p, v.n) where p is a scalar GridFunction and v is an H1 vector test function. Does VectorBoundaryFluxLFIntegrator work for you?
(See https://mfem.org/lininteg/#vector-field-operators)
Tzanio


Fix jumbled legends and colors in workflow dags

Prior to this, colours and labels for jobs in the two DAG graphs were
jumbled up.
The code incorrectly assumed that iterating over a dict would iterate in
the order that the entries appear in a hard-coded literal dict in the
source tree.
For example:
The code assumed that the first element added to the node_traces list, and
thus the element referred to by node_traces[0], would be the element in
groups_list with value (0,...)
This incorrect assumption led to adding DAG nodes to the wrong Scatter
object.
This patch changes the way that the node_traces list is constructed by
populating it with marker places and then using index notation to set the
appropriate entry in the list based on hard-coded index.
Further, that wrong scatter object then had its colour mutated. This patch
sets the colour correctly on initial creation and does not change it again.
For the DAG coloured by state plot, the naming if-statement had no final
else: case, leading to some nodes being incorrectly labelled. This patch
adds an 'Unknown' case which is reached, for example, in jobs which are
never launched due to dependency failure.

Tried that on a machine. The color=None looks fine.


Not working when UBM is used

After UBM is loaded, enroll task gives following error:
python2: src/gmm.cc:177: real_t Gaussian::probability_of_fast_exp(std::vector&, double*): Assertion `(int)x.size() == dim' failed.
Aborted (core dumped)
gmm_order=32
UBM_MODEL_FILE = 'gui/model/ubm.mixture-32.utt-300.model'

duplicate of #32


Update content of About Us page for Swahili

The about us page doesn't have the leadership section on it.
Also please note that there is an issues in the mission text that needs to be corrected. I'll work on making this change ASAP. Please wait until it is finished.

[ ] #224

cc: @kazz54

Got it, currently working on translating the missing stuff on the home page and fixing the broken URL

@kazz54 Take as reference the Translation for the articles in Spanish

Yes I used that as reference you can merge the pull request


Update akka-actor, akka-slf4j, akka-stream, ... to 2.6.19

Updates

com.typesafe.akka:akka-actor
com.typesafe.akka:akka-slf4j
com.typesafe.akka:akka-stream
com.typesafe.akka:akka-stream-testkit

from 2.6.18 to 2.6.19.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.6.18).
You might want to review and update them manually.
dependency-check/dependency-check-report.html

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
80 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-23.03%) to 53.353%

Files with Coverage Reduction
New Missed Lines
%

core-s3/src/main/scala/io/aiven/guardian/kafka/s3/Config.scala
1
90.63%

cli-backup/src/main/scala/io/aiven/guardian/kafka/backup/App.scala
2
0%

core-restore/src/main/scala/io/aiven/guardian/kafka/restore/KafkaProducer.scala
5
22.22%

restore-s3/src/main/scala/io/aiven/guardian/kafka/restore/s3/RestoreClient.scala
8
0%

core-backup/src/main/scala/io/aiven/guardian/kafka/backup/KafkaClient.scala
12
39.13%

core-backup/src/main/scala/io/aiven/guardian/kafka/backup/BackupClientInterface.scala
14
75.65%

backup-s3/src/main/scala/io/aiven/guardian/kafka/backup/s3/BackupClient.scala
38
0%

Totals

Change from base Build<PHONE_NUMBER>:
-23.03%

Covered Lines:
183

Relevant Lines:
343

💛  - Coveralls


feat: upgrade django and python to latest stable versions

This PR upgrades the Scaf template to the latest stable Django and Python versions.
Most importantly, I removed the pins in the *.in files to ensure that a newly generated project always has the latest Django version. This is not a cause for concern since running make compile after project creation will immediately pin all package versions. Additionally, this forces us to perform regular tests of Scaf-generated projects with the latest versions.
I tested the changes in the PR by creating a new project and verifying that both the frontend and backend sites work and that NextJS can make GraphQL queries against Django.

I think my only concern is that folks will now need to be aware that if they run subsequent pip-tools compile against the project they will bring in newer versions of these base deps. This will happen often as you add new deps to the project.
I wonder if there would be a way to post process the .in files and add a sane upper bound like Django<5.1 if a pin was originally chosen like Django==5.0.7?

In practice, pinned versions stay pinned for far too long. We've had Django 4.1 (the sane default back many years) pinned since 18 August 2022. Having unpinned versions forces you to move forward, and it should be a non-issue if we have good test coverage. The packages we depend on help to keep the version sane since they will limit the required versions to the ones they have been tested with. The project should decide to pin versions. Scaf shouldn't decide that for the project.

I can agree with that, we should highlight this as a major feature of scaf so that folks are very aware of the thoughtfulness that went into that decision

Cool! I'll add the decision as a note to our main README.


top Friends

hello sir,
How could I find top friends using this api or how could I check who liked or commented on my posts

https://www.youtube.com/watch?v=U9dVtyd_TYw this would help you to get likes and comments for users you need user_posts permission


[Web][HTML] Components flicker on some ipad models

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Prepare an iPad 9th or 10th generation device with iPadOS 17.0.2 installed.
Build the following code sample using the flutter build web --web-renderer html command and deploy it to any location.
Open it in Safari or Chrome.
Tap various components.
The components flicker when tapped.

The attached sample code is an excerpt from Material 3, where the issue occurs. Additionally, from my observations, there is no flickering on the 7th generation iPad.
The attached logs are from when it was deployed to Vercel.
https://github.com/flutter/flutter/assets/20528630/e8dadff2-099f-49b3-ab14-1bc277681f4b
Expected results
Tapping components should not result in any screen flickering.
Actual results
The components flicker when tapped.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text('Button Widgets Example'),
        ),
        body: SingleChildScrollView(
          scrollDirection: Axis.horizontal,
          child: Row(
            mainAxisAlignment: MainAxisAlignment.spaceAround,
            children: <Widget>[
              ButtonsWithoutIcon(isDisabled: false),
              ButtonsWithIcon(),
              ButtonsWithoutIcon(isDisabled: true),
              TopAppBars(),
            ],
          ),
        ),
      ),
    );
  }
}

class ButtonsWithoutIcon extends StatelessWidget {
  final bool isDisabled;

  const ButtonsWithoutIcon({Key? key, required this.isDisabled}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.symmetric(horizontal: 5.0),
      child: IntrinsicWidth(
        child: Column(
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: <Widget>[
            ElevatedButton(
              onPressed: isDisabled ? null : () {},
              child: const Text('Elevated'),
            ),
            Divider(),
            FilledButton(
              onPressed: isDisabled ? null : () {},
              child: const Text('Filled'),
            ),
            Divider(),
            FilledButton.tonal(
              onPressed: isDisabled ? null : () {},
              child: const Text('Filled tonal'),
            ),
            Divider(),
            OutlinedButton(
              onPressed: isDisabled ? null : () {},
              child: const Text('Outlined'),
            ),
            Divider(),
            TextButton(
              onPressed: isDisabled ? null : () {},
              child: const Text('Text'),
            ),
          ],
        ),
      ),
    );
  }
}

class ButtonsWithIcon extends StatelessWidget {
  const ButtonsWithIcon({super.key});

  @override
  Widget build(BuildContext context) {
    return Padding(
      padding: const EdgeInsets.symmetric(horizontal: 10.0),
      child: IntrinsicWidth(
        child: Column(
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: <Widget>[
            ElevatedButton.icon(
              onPressed: () {},
              icon: const Icon(Icons.add),
              label: const Text('Icon'),
            ),
            Divider(),
            FilledButton.icon(
              onPressed: () {},
              label: const Text('Icon'),
              icon: const Icon(Icons.add),
            ),
            Divider(),
            FilledButton.tonalIcon(
              onPressed: () {},
              label: const Text('Icon'),
              icon: const Icon(Icons.add),
            ),
            Divider(),
            OutlinedButton.icon(
              onPressed: () {},
              icon: const Icon(Icons.add),
              label: const Text('Icon'),
            ),
            Divider(),
            TextButton.icon(
              onPressed: () {},
              icon: const Icon(Icons.add),
              label: const Text('Icon'),
            )
          ],
        ),
      ),
    );
  }
}

class TopAppBars extends StatelessWidget {
  const TopAppBars({super.key});

  static final actions = [
    IconButton(icon: const Icon(Icons.attach_file), onPressed: () {}),
    IconButton(icon: const Icon(Icons.event), onPressed: () {}),
    IconButton(icon: const Icon(Icons.more_vert), onPressed: () {}),
  ];

  @override
  Widget build(BuildContext context) {
    return ComponentDecoration(
      label: 'Top app bars',
      tooltipMessage:
      'Use AppBar, SliverAppBar, SliverAppBar.medium, or  SliverAppBar.large',
      child: Column(
        children: [
          AppBar(
            title: const Text('Center-aligned'),
            leading: const BackButton(),
            actions: [
              IconButton(
                iconSize: 32,
                icon: const Icon(Icons.account_circle_outlined),
                onPressed: () {},
              ),
            ],
            centerTitle: true,
          ),
          Divider(),
          AppBar(
            title: const Text('Small'),
            leading: const BackButton(),
            actions: actions,
            centerTitle: false,
          ),
        ],
      ),
    );
  }
}

class ComponentDecoration extends StatefulWidget {
  const ComponentDecoration({
    super.key,
    required this.label,
    required this.child,
    this.tooltipMessage = '',
  });

  final String label;
  final Widget child;
  final String? tooltipMessage;

  @override
  State<ComponentDecoration> createState() => _ComponentDecorationState();
}

class _ComponentDecorationState extends State<ComponentDecoration> {
  final focusNode = FocusNode();

  @override
  Widget build(BuildContext context) {
    return RepaintBoundary(
      child: Padding(
        padding: const EdgeInsets.symmetric(vertical: 10.0),
        child: Column(
          children: [
            Row(
              mainAxisAlignment: MainAxisAlignment.center,
              children: [
                Text(widget.label,
                    style: Theme.of(context).textTheme.titleSmall),
                Tooltip(
                  message: widget.tooltipMessage,
                  child: const Padding(
                      padding: EdgeInsets.symmetric(horizontal: 5.0),
                      child: Icon(Icons.info_outline, size: 16)),
                ),
              ],
            ),
            ConstrainedBox(
              constraints:
              const BoxConstraints.tightFor(width: 450),
              // Tapping within the a component card should request focus
              // for that component's children.
              child: Focus(
                focusNode: focusNode,
                canRequestFocus: true,
                child: GestureDetector(
                  onTapDown: (_) {
                    focusNode.requestFocus();
                  },
                  behavior: HitTestBehavior.opaque,
                  child: Card(
                    elevation: 0,
                    shape: RoundedRectangleBorder(
                      side: BorderSide(
                        color: Theme.of(context).colorScheme.outlineVariant,
                      ),
                      borderRadius: const BorderRadius.all(Radius.circular(12)),
                    ),
                    child: Padding(
                      padding: const EdgeInsets.symmetric(
                          horizontal: 5.0, vertical: 20.0),
                      child: Center(
                        child: widget.child,
                      ),
                    ),
                  ),
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[19:29:56.677] Running build in Washington, D.C., USA (East) – iad1 (Hive)
[19:29:56.789] Cloning github.com/compass-inc/bug_sample (Branch: test/material_sample, Commit: e5286e2)
[19:29:57.345] Cloning completed: 556.151ms
[19:29:57.525] Restored build cache
[19:29:57.592] Running "vercel build"
[19:29:58.596] Vercel CLI 32.3.1
[19:29:59.486] Running "install" command: `if cd flutter; then git pull && cd .. ; else git clone --branch 3.13.4 https://github.com/flutter/flutter.git; fi && ls && flutter/bin/flutter doctor && flutter/bin/flutter clean && flutter/bin/flutter config --enable-web`...
[19:29:59.494] sh: line 0: cd: flutter: No such file or directory
[19:29:59.496] Cloning into 'flutter'...
[19:30:21.388] Note: switching to '367f9ea16bfae1ca451b9cc27c1366870b187ae2'.
[19:30:21.389]
[19:30:21.389] You are in 'detached HEAD' state. You can look around, make experimental
[19:30:21.389] changes and commit them, and you can discard any commits you make in this
[19:30:21.389] state without impacting any branches by switching back to a branch.
[19:30:21.389]
[19:30:21.389] If you want to create a new branch to retain commits you create, you may
[19:30:21.389] do so (now or later) by using -c with the switch command. Example:
[19:30:21.389]
[19:30:21.389]   git switch -c <new-branch-name>
[19:30:21.389]
[19:30:21.389] Or undo this operation with:
[19:30:21.389]
[19:30:21.389]   git switch -
[19:30:21.390]
[19:30:21.390] Turn off this advice by setting config variable advice.detachedHead to false
[19:30:21.390]
[19:30:22.119] analysis_options.yaml
[19:30:22.119] flutter
[19:30:22.119] lib
[19:30:22.119] pubspec.lock
[19:30:22.119] pubspec.yaml
[19:30:22.119] README.md
[19:30:22.120] test
[19:30:22.120] vercel.json
[19:30:22.120] web
[19:30:22.132]    Woah! You appear to be trying to run flutter as root.
[19:30:22.132]    We strongly recommend running the flutter tool without superuser privileges.
[19:30:22.132]   /
[19:30:22.133] 📎
[19:30:22.254] Downloading Linux x64 Dart SDK from Flutter engine 9064459a8b0dcd32877107f6002cc429a71659d1...
[19:30:22.261]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[19:30:22.261]                                  Dload  Upload   Total   Spent    Left  Speed
[19:30:23.269]
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 90  198M   90  179M    0     0   188M      0  0:00:01 --:--:--  0:00:01  188M
100  198M  100  198M    0     0   197M      0  0:00:01  0:00:01 --:--:--  197M
[19:30:28.208] Building flutter tool...
[19:30:28.357] Resolving dependencies...
[19:30:33.269] Got dependencies.
[19:30:48.403] Downloading Material fonts...                                      319ms
[19:30:48.469] Downloading Gradle Wrapper...                                        9ms
[19:30:48.642] Downloading package sky_engine...                                  155ms
[19:30:48.958] Downloading flutter_patched_sdk tools...                           258ms
[19:30:49.279] Downloading flutter_patched_sdk_product tools...                   232ms
[19:30:50.819] Downloading linux-x64 tools...                                   1,450ms
[19:30:51.711] Downloading linux-x64/font-subset tools...                         138ms
[19:30:51.860] Doctor summary (to see all details, run flutter doctor -v):
[19:30:51.930] [!] Flutter (Channel [user-branch], 3.13.4, on Amazon Linux 2 5.10.174, locale en_US.UTF-8)
[19:30:51.930]     ! Flutter version 3.13.4 on channel [user-branch] at /vercel/path0/flutter
[19:30:51.930]       Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
[19:30:51.930]       If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
[19:30:51.930]     ! The flutter binary is not on your path. Consider adding /vercel/path0/flutter/bin to your path.
[19:30:51.930]     ! The dart binary is not on your path. Consider adding /vercel/path0/flutter/bin to your path.
[19:30:51.930]     ! Upstream repository unknown source is not a standard remote.
[19:30:51.931]       Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
[19:30:51.933] [✗] Android toolchain - develop for Android devices
[19:30:51.933]     ✗ Unable to locate Android SDK.
[19:30:51.933]       Install Android Studio from: https://developer.android.com/studio/index.html
[19:30:51.933]       On first launch it will assist you in installing the Android SDK components.
[19:30:51.933]       (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
[19:30:51.933]       If the Android SDK has been installed to a custom location, please use
[19:30:51.933]       `flutter config --android-sdk` to update to that location.
[19:30:51.933]
[19:30:51.935] [✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
[19:30:51.935]     ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[19:30:52.237] [✗] Linux toolchain - develop for Linux desktop
[19:30:52.237]     ✗ clang++ is required for Linux development.
[19:30:52.238]       It is likely available from your distribution (e.g.: apt install clang), or can be downloaded from https://releases.llvm.org/
[19:30:52.238]     ✗ CMake is required for Linux development.
[19:30:52.238]       It is likely available from your distribution (e.g.: apt install cmake), or can be downloaded from https://cmake.org/download/
[19:30:52.238]     ✗ ninja is required for Linux development.
[19:30:52.238]       It is likely available from your distribution (e.g.: apt install ninja-build), or can be downloaded from https://github.com/ninja-build/ninja/releases
[19:30:52.238]     ✗ pkg-config 0.29.0 or later is required.
[19:30:52.238]     ✗ GTK 3.0 development libraries are required for Linux development.
[19:30:52.238]       They are likely available from your distribution (e.g.: apt install libgtk-3-dev)
[19:30:52.238] [!] Android Studio (not installed)
[19:30:52.238] [✓] Connected device (1 available)
[19:30:52.273] [✓] Network resources
[19:30:52.273]
[19:30:52.273] ! Doctor found issues in 5 categories.
[19:30:52.303]    Woah! You appear to be trying to run flutter as root.
[19:30:52.304]    We strongly recommend running the flutter tool without superuser privileges.
[19:30:52.304]   /
[19:30:52.304] 📎
[19:30:52.552]    Woah! You appear to be trying to run flutter as root.
[19:30:52.552]    We strongly recommend running the flutter tool without superuser privileges.
[19:30:52.552]   /
[19:30:52.552] 📎
[19:30:52.702] Setting "enable-web" value to "true".
[19:30:52.703]
[19:30:52.703] You may need to restart any open editors for them to read new settings.
[19:30:52.741]    Woah! You appear to be trying to run flutter as root.
[19:30:52.742]    We strongly recommend running the flutter tool without superuser privileges.
[19:30:52.742]   /
[19:30:52.742] 📎
[19:30:55.393] Downloading Web SDK...                                           2,491ms
[19:30:57.012] Resolving dependencies...
[19:30:58.825]   collection 1.17.2 (1.18.0 available)
[19:30:58.825]   cupertino_icons 1.0.5 (1.0.6 available)
[19:30:58.825]   material_color_utilities 0.5.0 (0.8.0 available)
[19:30:58.825]   meta 1.9.1 (1.10.0 available)
[19:30:58.825]   stack_trace 1.11.0 (1.11.1 available)
[19:30:58.825]   stream_channel 2.1.1 (2.1.2 available)
[19:30:58.825]   test_api 0.6.0 (0.6.1 available)
[19:30:58.825]   web 0.1.4-beta (0.2.1-beta available)
[19:30:58.827] Got dependencies!
[19:30:59.123]
[19:31:33.611] Compiling lib/main.dart for the Web...
[19:31:33.611] Font asset "CupertinoIcons.ttf" was tree-shaken, reducing it from 283452 to 1272 bytes (99.6% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
[19:31:33.612] Font asset "MaterialIcons-Regular.otf" was tree-shaken, reducing it from 1645184 to 8200 bytes (99.5% reduction). Tree-shaking can be disabled by providing the --no-tree-shake-icons flag when building your app.
[19:31:34.276] Compiling lib/main.dart for the Web...                             35.1s
[19:31:34.323] Build Completed in /vercel/output [2m]
[19:31:34.430] Deploying outputs...
[19:31:34.994] Injected preview comments middleware, you can disable this in your project settings.
[19:31:35.722] Deployment completed
[19:31:38.592] Uploading build cache [29.00 B]...
[19:31:38.976] Build cache uploaded: 383.932ms

Flutter Doctor output
Doctor output
[Paste your output here]

I can reproduce this issue on my iPad Air 5th Generation only with the HTML renderer. It worked as expected with the canvaskit renderer. See the recordings below.
This did not reproduce on my iPhone XS.
I don't have any devices running lower than iOS 17 at this point so I could not confirm if this was only on iOS 17.
Labeling for further investigation.

canvaskit
html

flutter doctor -v
[✓] Flutter (Channel stable, 3.13.5, on macOS 13.6 22G120 darwin-arm64, locale en-GB)
    • Flutter version 3.13.5 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 12fccda598 (8 days ago), 2023-09-19 13:56:11 -0700
    • Engine revision bd986c5ed2
    • Dart version 3.1.2
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-15.0.0-Release.Candidate.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.2)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 75.1.4
    • Dart plugin version 232.9559.10

[✓] VS Code (version 1.82.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (4 available)
    • Nexus (mobile)       • 00008020-001875E83A38002E • ios            • iOS 17.0.1 21A340
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E • ios            • iOS 17.0.1 21A340
    • macOS (desktop)      • macos                     • darwin-arm64   • macOS 13.6 22G120 darwin-arm64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 117.0.5938.92

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.15.0-10.0.pre.12, on macOS 13.6 22G120 darwin-arm64, locale en-GB)
    • Flutter version 3.15.0-10.0.pre.12 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bea63d7c81 (12 hours ago), 2023-09-26 20:46:25 -0400
    • Engine revision 0a8ad236e4
    • Dart version 3.2.0 (build 3.2.0-199.0.dev)
    • DevTools version 2.28.0-dev.12
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode-15.0.0-Release.Candidate.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.2)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 75.1.4
    • Dart plugin version 232.9559.10

[✓] VS Code (version 1.82.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (4 available)
    • Nexus (mobile)       • 00008020-001875E83A38002E • ios            • iOS 17.0.1 21A340
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E • ios            • iOS 17.0.1 21A340
    • macOS (desktop)      • macos                     • darwin-arm64   • macOS 13.6 22G120 darwin-arm64
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 117.0.5938.92

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I conducted a compatibility test with iPadOS 17.1, which was released on 9/28, and confirmed that this issue no longer occurs. Therefore, by waiting for the official release for another 1 to 2 months, this problem may be resolved.

Will there be any updates in the near future?

I confirmed that this issue has been resolved in the officially released iPadOS 17.1 today. You can go ahead and close this issue.

I can also no longer reproduce this issue on my iPad on iPadOS 17.1.
Closing this as fixed by iPadOS 17


Environment variable overwritten

cf-meteor-buildpack/bin/release
extract_root_url()
Custom domains are ignored. If I set an user variable with ROOT_URL, it is ignored and only the VCAP application is taken. While this is nice with the standard settings it causes problems if you want to overwrite this with a custom domain on purpose. (using bluemix, not sure if this is a common problem)
It would be nice to have a check if there is an existing environment variable and only set a new one if there is not.

I have the same problem. I'm using a custom domain and the ROOT_URL environment variable that I set through 'cf env' is overridden by the standard settings from the buildpack. Any solution for this?

Just implemented a work around using a BLUEMIX_ROOT_URL env variable, then, in my init script on server side:
if (process.env.BLUEMIX_ROOT_URL) {   Meteor.originalAbsoluteUrl = Meteor.absoluteUrl;   Meteor.absoluteUrl = function (path, options) {     if (!options) {       options = {};     }     options.rootUrl = process.env.BLUEMIX_ROOT_URL;     return Meteor.originalAbsoluteUrl(path, options);   };   process.env.ROOT_URL = process.env.BLUEMIX_ROOT_URL; }


Feature Workload scheduler policy support move action

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall


Fix issues with meta tags

References

Fixes #1197

Description
Implement Google Scholar review suggestions for meta tags
Instructions for Reviewers
The following meta tags were changed:

citation_pdf_url: select Bitstreams ~ MIME type allowlist (if more than one option and no primary in ORIGINAL Bundle)
citation_abstract_html_url: use dc.identifier.uri if available, fall back to current URL
citation_publisher: use dc.publisher (except dissertations & tech reports, those use other tags)
citation_date → citation_publication_date
Remove og:title and og:description meta tags

Testing

Open some Item pages and inspect the head > meta in their HTML

[ ] citation_abstract_html_url should not contain links to localhost, but should contain links ~ the Item's handle dc.identifier.uri is filled out. Otherwise, it should match the Item page URL
[ ] citation_publisher should be present if dc.publisher is filled out
[ ] citation_publication_date should be present
[ ] The following meta tags should not be present: citation_date, og:title, og:description

For Items with one ORIGINAL Bitstream

[ ] citation_pdf_url should contain a link to that Bitstream

For Items with more than one ORIGINAL Bitstream

[ ] If a primary Bitstream is specified, citation_pdf_url should link to it
[ ] Otherwise, citation_pdf_url should contain a link to the first ORIGINAL Bitstream with one of these MIME types

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@art @tdonohue LGTM & unit test fix incoming

@ybnd and @artlowel : Overall, this fixes the issues you've described, but I've noticed an odd caching issue when testing with this PR. It seems the <meta> tags don't always refresh when you browse to a new page

@tdonohue @artlowel  After a bit of poking around on the current demo7.dspace.org I only ever saw the <title> meta tag change, and not even consistently.
Looks like this distinctUntilKeyChanged filters out way more changes than it should, e.g. when going back/forward between a Collection & an Item I see the DSO change in that pipe but it doesn't pass that filter... not sure what that's about.

@tdonohue and @ybnd I fixed the issue. The reason was not only the distinctUntilKeyChanged issue @ybnd mentioned, but the fact that the responded both to the route changing, and calls for DSO page components initializing. With the second call often starting before the first had finished processing, resulting in unexpected results.
I fixed it removing the calls on DSO pages, and only listening to route changes, that's possible now (but wasn't when the metadataservice was originally written) because we're using resolvers on those pages, and they all put the resolved object in the dso property in the route data.
I spent an additional 4 hours on this though, most of that not on the solution itself, but on the tests. They were basically integration tests in a unit test file. Didn't mock anything which caused them to break with the slightest change. I practically had to rewrite them from scratch, getting rid of anything that isn't strictly necessary for the test.

Thanks @artlowel . I'll add 4 hours to the original ticket and re-test this as soon as possible.

@tdonohue Should be fixed now 👍

Merging this immediately, as it was previously discussed as 1 approval in meetings (it includes a large number of refactored/updated specs), and I'd like to get it in place for final quick tests from Google Scholar.


[solution pending] Extra lines in email submissions

A participant using JAWS found unexpected extra lines between question and response pairs, and between questions and responses themselves. This made it difficult to understand how different pieces of text were related to each other.
Hillary wasn't able to reproduce this using voiceover or find the extra lines using outlook, but there did appear to be a table break in some areas. Requires more investigation.


ACPCore.h not found when importing <RCTACPCore/ACPCore.h>

Expected Behaviour
ACPCore should be found.
Actual Behaviour
ACPCore is not found.
Reproduce Scenario (including but not limited to)
npm i @adobe/react-native-acpcore
react-native link @adobe/react-native-acpcore
Steps to Reproduce
npm i @adobe/react-native-acpcore
react-native link @adobe/react-native-acpcore
press play in xcode
Platform and Version
MacOS 10.14.6
Xcode 11.1
React Native 0.59.9
Sample Code that illustrates the problem
#import <RCTACPCore/ACPCore.h>
Logs taken while reproducing problem

Hi @BoilingOil, any chance you're using cocoapods? If you may need to pod install in your iOS directory.

@BoilingOil I wasn't able to reproduce this issue on RN 0.59.9 following the steps provided. I tested this in Xcode 10.2 and the latest version of Xcode.
Here is that app: https://github.com/nporter-adbe/gitissue50

I'm not using cocoapods.
What I've tried:
Cleaning the build folder: This will remove the error from AppDelegate, but upon pressing build and run, the build will fail and the error returns.
I've unlinked 1.1.1, uninstalled 1.1.1, installed 1.1.2, and linked 1.1.2.
I continue to have the error.
What I believe to be strange: I am able to jump to definition and land on ACPCore.h

@BoilingOil  Sounds like when react native linked the library it didn't update your header search paths? Make sure you have a recursive header search path of $(SRCROOT)/../node_modules/@adobe/react-native-acpcore/ios/src
You can see an example of this in the app I linked above, even though I didn't need to manually add the header search path.

I have that entry in header search paths. I will compare the gitissue50 project to my own and see what's changed.

Closing this.

#import "ACPCore.h" and added recursive header search path of $(SRCROOT)/../node_modules/@adobe/react-native-acpcore/ios/src
but still getting issue.


Add catalyst sample

This pull requests adds a sample entry to the plugin.

I have moved the 2 big functions into the class now.


Removing tabs from template compilation markup

I wanted to see what your opinions are on removing tabs (white space) from the templates when they are compiled. This would reduce the size of the javascript objects.
Considerations:

Performance of using .replace()
Could this break anything in the templates

The proposed change:
function TmplObject(markup, options) { - Line 603
tmpl = $extend(
				{
					markup: markup.replace(/\t/g, ''),
					tmpls: [],
					links: {},
					bnds: [],
					render: renderContent
				},
				options
			);

Closing "After V1.0" issues for now - to reopen as appropriate.


Error log for network-attachment-definition

Corrected the error for missing network-attachment-definition

This is awesome! Thanks for the detailed eye on these PRs, we appreciate them a lot!

@dougbtv thanks for quick review!


Implement dev branch and release process

Once we are ready for public launch, we should make a 1.0 version and move all development to a dev branch such that any changes to the main branch go through a controlled release process.

Here's the release process.  Will add this to the project docs.  Install https://github.com/release-it/release-it
$ npm install -g release-it

Then create the release branch from dev and push it as a new PR.  Say you want to release version 1.2.3
$ git checkout dev
$ git pull --all
$ git branch -b release-v1.2.3 origin/dev
$ git push -u origin release-v1.2.3
$ release-it 1.2.3

Then create the PR and make sure that the PR will merge into main.
This could be automated with a github action, but this is pretty lightweight.
Afterwards there should be a sync PR from main back into dev with any hotfixes, but usually it'll just be the version number in package.json.


Create tfidf-scikit

initial commit

Overall, the content is clear and concise. However, providing a specific example would enhance the clarity of the explanation. For instance, you could consider using a simple sentence as a sample document and demonstrate what the resulting TF-IDF matrix would look like.

Thanks for your feedback! I will make some changes and do a new commit.

Looks good! You can merge it now.

In step 4, could you provide a more detailed explanation of the parameters?

Looks good! Could you also include more specific use cases for it?


[Dev] Add a workflow that compile the ruby code and make a release.

Add a workflow that compile and pre release a p2p binary.

useless


Fixed incorrect deflate header bits being sent

    Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value.
      Results might not be an expected value.

Moved to #618.


Updated comment index

Updating the comment index to say review and submit and having a dynamic count of how many comments you have.

Flagging this for copy review, @jehlers @brittag. In particular, it seems loopy to say you have "3 comments, are you ready to submit your comment"
Merging, though.

@cmc333333 Does this context help? https://github.com/eregs/notice-and-comment/issues/136#issuecomment-209085009


Top-level await needed for installation?

Trying to install Rose in a new package that uses Vite and immediately run into this error when I run vite:
12:05:12 PM [vite] error while updating dependencies:
Error: Build failed with 1 error:
../../../../node_modules/@rose-lang/wasm/dist/browser.js:3:0: ERROR: Top-level await is not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari14" + 2 overrides)

Does Rose need TLA? If so, can this be added to the docs?

Resolved by 3ae4bc106ca6306a4f0ecb8c63f4ff82e945ab7f.


add batchSize option

added missing batchSize option for MarkerClusterer.js

Hi @tomchentw I created a new PR https://github.com/tomchentw/react-google-maps/pull/544

Closed by #544

Relesed v7.2.0


Unable to pass build context as tar with overlay2 graph driver

Output of docker version:
$ docker version
Client:
 Version:      1.12.0-rc4
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:        Wed Jul 13 03:41:15 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc4
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   e4a0dbc
 Built:        Wed Jul 13 03:41:15 2016
 OS/Arch:      linux/amd64

Output of docker info:
$ docker info
Containers: 6
 Running: 1
 Paused: 0
 Stopped: 5
Images: 105
Server Version: 1.12.0-rc4
Storage Driver: overlay2
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.6.0-1-amd64
Operating System: Debian GNU/Linux stretch/sid
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.958 GiB
Name: localdev
ID: 2GH4:KUEP:Q5HH:I6T7:KZM6:2AOC:MA5S:QSVV:FJ72:IPR5:7ABX:4MR2
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: mbentley
Registry: https://index.docker.io/v1/
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Debian Sid VM running on VirtualBox
Steps to reproduce the issue:

Try to build an image from a tar file (https://docs.docker.com/engine/reference/commandline/build/#/build-with)
Get error

Describe the results you received:
Using a basic Dockerfile:
FROM alpine:latest
COPY Dockerfile /Dockerfile

$ tar -cz Dockerfile | docker build -
Sending build context to Docker daemon    165 B
Step 1 : FROM alpine:latest
 ---> 4e38e38c8ce0
Step 2 : COPY Dockerfile /Dockerfile
stat /var/lib/docker/overlay2/4adddf69508af614c5fd03e5bee893d4d9b8a3bdbbd5ad55f32ca65143927a9a/merged/Dockerfile: no such file or directory

Describe the results you expected:
I expect the build to succeed (it works on aufs):
$ tar -cz Dockerfile | docker build -
Sending build context to Docker daemon 10.24 kB
Step 1 : FROM alpine:latest
 ---> 13e1761bf172
Step 2 : COPY Dockerfile /Dockerfile
 ---> ffe6f7814e84
Removing intermediate container d45bf063c843
Successfully built ffe6f7814e84

Additional information you deem important (e.g. issue happens only occasionally):

ping @dmcgowan

@mbentley is this happening for you consistently? Also does it occur with overlay as well. I do not see this occurring on my machine so any extra information which may help me reproduce will be useful.

@dmcgowan Yes, it is happening consistently for me.  I just tested with overlay and I am not able to reproduce the issue:
$ tar -cz Dockerfile | docker build -
Sending build context to Docker daemon    165 B
Step 1 : FROM alpine:latest
 ---> 4e38e38c8ce0
Step 2 : COPY Dockerfile /Dockerfile
 ---> e987bad314df
Removing intermediate container 4d6fe90ded1b
Successfully built e987bad314df

docker info:
$ docker info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 2
Server Version: 1.12.0-rc4
Storage Driver: overlay
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.6.0-1-amd64
Operating System: Debian GNU/Linux stretch/sid
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.958 GiB
Name: localdev
ID: 2GH4:KUEP:Q5HH:I6T7:KZM6:2AOC:MA5S:QSVV:FJ72:IPR5:7ABX:4MR2
Docker Root Dir: /data/docker/overlay
Debug Mode (client): false
Debug Mode (server): false
Username: mbentley
Registry: https://index.docker.io/v1/
Insecure Registries:
 <IP_ADDRESS>/8

So actually, this might be a sid issue.  I can't reproduce the error anymore after upgrading.  Sorry for the possible false alarm.  I'll reopen if I can figure out a way to reproduce it.

Mentioning this error here since it's the only place I see this stubborn overlay2 error. I was getting it when using docker-compose rm / down. I could only get past that by restarting the docker service.
+ docker-compose stop
+ docker-compose rm --force -v --all
--all flag is obsolete. This is now the default behavior of `docker-compose rm`
stat /var/lib/docker/overlay2/81138dc2c5eda89786ad6937e1cd9036e33df5ce005b9b303f34155c75857a89: no such file or directory
+ docker-compose down
stat /var/lib/docker/overlay2/81138dc2c5eda89786ad6937e1cd9036e33df5ce005b9b303f34155c75857a89: no such file or directory

 sudo docker info
Containers: 37
 Running: 33
 Paused: 0
 Stopped: 4
Images: 2045
Server Version: 1.12.3
Storage Driver: overlay2
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null bridge host overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-36-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.66 GiB
Name: docker.example.com
ID: 26H4:NJWM:5X2M:G4N4:AXNJ:IXPB:2QIY:NLOK:G6I7:VAIH:NYLY:ETF2
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Labels:
 provider=generic
Insecure Registries:
...

$ docker-compose version
docker-compose version 1.9.0-rc3, build fcd38d3
docker-py version: 1.10.6
CPython version: 2.7.9
OpenSSL version: OpenSSL 1.0.1t  3 May 2016


[issue] python api sample code run failed

Describe the bug
when I run the python samples(01-load_map.py and 02-Apollo-v7.py), with error messages that failed load maps;
Useful debug information from command line
python 01-load_map.py
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 20.04
Version of SVL: 2021.03

Additional context

@lee-wei
Hi, thanks for posting the issue. Looks like the client is able to download files from the server but the SVL client is having issue with the downloaded file.
I see in assets/maps directory you have both XXX.zip and XXX. How did you transform XXX.zip into XXX? Did you unzip these files? If so, this is incorrect, please use https://github.com/YuqiHuai/SORA-SVL/blob/main/toolset/correct_maps_dir.py to remove .zip extension instead of unzipping them.

Lg svl local test ok
Only Py API ok
Env: Ubuntu 22, humble
My blog
https://m.blog.naver.com/mdc1020/223051592709

@theikim
Thanks for sharing!


Dynamic data on pagination, it's possible?

I am looking for a good jQuery Grid plugin and I believe this one is awesome. Before I start using it I would like to know if there is any way to get data dynamic. What I mean? Most of the datagrid I've found load all the data on a single query and then process it through JS/jQuery and with too many data this is insane. So I am looking for one that makes possible to load data as soon as I move in pagination by making a request to the server for get the data. Also I am using PHP is there any example around?

As I understand you are talking about loading data by pages - yes this is basic scenario for js-grid, checkout this option http://js-grid.com/docs/#pageloading-default-false.
There are sample projects for js-grid http://js-grid.com/samples/ (php among them).


Add missing whitespace control char

Why:
Closes #15896
What's being changed:
Added a missing whitespace control char that breaks the table rendering.
Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

yorum

👋  I pushed the same fix https://github.com/github/docs/pull/15854

@Ameausoone Ah I'll close my PR. Should I also close my corresponding issue #15896, or perhaps you can link your #15854 to it?