[FLINK-10357][tests] Improve StreamingFileSink E2E test stability.

What is the purpose of the change
Previously, we relied on checkpoint statistics to decide when to re-check the number of files written by the sink under test. However, side effects are triggered asynchronously, i.e., it can happen that statistics are updated before side effects are triggered (rolling of files). This can lead to test failures due to hash mismatches. We now wait until the number of expected lines were written to the file system.
Brief change log

It is fairly obvious. Also see the commits.

Verifying this change
This change added tests and can be verified as follows:

I am changing a test. I ran the test, and it passes more often now. There are more things that need fixing. See ticket.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for reviewing @azagrebin. Merging as soon as build is green.


Searching by publication id

Is it possible to query, not by publication title, but by publication id?
For example, from a list of author's publications I get the field author_pub_id, which combines author_id and publication_id. Is it possible to use then this publication_id for the search?

You can just do a scholarly.fill(p) (with p being the publication object) and you will get back the filled publication.
For example, something like the code below:

author = next(scholarly.search_author('foster provost'))
author = scholarly.fill(author)
top_ten_pubs = author['publications'][:10]
for p in top_ten_pubs:
  scholarly.fill(p)

for p in top_ten_pubs:
  scholarly.pprint(p)
  print("\n\n-------\n\n")

You can just do a scholarly.fill(p) (with p being the publication object) and you will get back the filled publication.
For example, something like the code below:

author = next(scholarly.search_author('foster provost'))
author = scholarly.fill(author)
top_ten_pubs = author['publications'][:10]
for p in top_ten_pubs:
  scholarly.fill(p)

for p in top_ten_pubs:
  scholarly.pprint(p)
  print("\n\n-------\n\n")

But I asked about a different thing. My question if it's possible to query by publication_id? Because when I query by publication_title I get a list of publications, which I don't want later to process.

But I asked about a different thing. My question if it's possible to query by publication_id? Because when I query by publication_title I get a list of publications, which I don't want later to process.

Searching using publication id will return the author page of the publication, with all the elements that you see.
For example, when you search for the publication id -Km63D4AAAAJ:u5HHmVD_uO8C you use the URL
https://scholar.google.com/citations?view_op=view_citation&hl=en&user=-Km63D4AAAAJ&citation_for_view=-Km63D4AAAAJ:u5HHmVD_uO8C&tzom=300
and you get back the parsed publication object
{'author_pub_id': '-Km63D4AAAAJ:u5HHmVD_uO8C',
 'bib': {'abstract': 'In real-world environments it usually is difficult to '
                     'specify target operating conditions precisely, for '
                     'example, target misclassification costs. This '
                     'uncertainty makes building robust classification systems '
                     'problematic. We show that it is possible to build a '
                     'hybrid classifier that will perform at least as well as '
                     'the best available classifier for any target conditions. '
                     'In some cases, the performance of the hybrid actually '
                     'can surpass that of the best known classifier. This '
                     'robust performance extends across a wide variety of '
                     'comparison frameworks, including the optimization of '
                     'metrics such as accuracy, expected cost, lift, '
                     'precision, recall, and workforce utilization. The hybrid '
                     'also is efficient to build, to store, and to update. The '
                     'hybrid is based on a method for the comparison of '
                     'classifier performance that is robust to imprecise class '
                     'distributions and misclassification costs. The ROC '
                     'convex hull (ROCCH) method combines …',
         'author': 'Foster Provost and Tom Fawcett',
         'journal': 'Machine learning',
         'number': '3',
         'pages': '203-231',
         'pub_year': '2001',
         'publisher': 'Kluwer Academic Publishers',
         'title': 'Robust classification for imprecise environments',
         'volume': '42'},
 'citedby_url': '/scholar?cites=17970352882167184968',
 'cites_id': '17970352882167184968',
 'cites_per_year': {2001: 23,
                    2002: 34,
                    2003: 64,
                    2004: 65,
                    2005: 74,
                    2006: 98,
                    2007: 110,
                    2008: 121,
                    2009: 83,
                    2010: 104,
                    2011: 72,
                    2012: 63,
                    2013: 76,
                    2014: 88,
                    2015: 71,
                    2016: 67,
                    2017: 62,
                    2018: 67,
                    2019: 62,
                    2020: 79},
 'eprint_url': 'https://link.springer.com/content/pdf/10.1023/A:1007601015854.pdf',
 'filled': True,
 'num_citations': 1510,
 'pub_url': 'https://link.springer.com/article/10.1023/A:1007601015854',
 'source': 'AUTHOR_PUBLICATION_ENTRY'}

It seems that you want to do something else, though, but I do not quite understand what.

Searching using publication id will return the author page of the publication, with all the elements that you see.
For example, when you search for the publication id -Km63D4AAAAJ:u5HHmVD_uO8C you use the URL
https://scholar.google.com/citations?view_op=view_citation&hl=en&user=-Km63D4AAAAJ&citation_for_view=-Km63D4AAAAJ:u5HHmVD_uO8C&tzom=300
and you get back the parsed publication object
{'author_pub_id': '-Km63D4AAAAJ:u5HHmVD_uO8C',
 'bib': {'abstract': 'In real-world environments it usually is difficult to '
                     'specify target operating conditions precisely, for '
                     'example, target misclassification costs. This '
                     'uncertainty makes building robust classification systems '
                     'problematic. We show that it is possible to build a '
                     'hybrid classifier that will perform at least as well as '
                     'the best available classifier for any target conditions. '
                     'In some cases, the performance of the hybrid actually '
                     'can surpass that of the best known classifier. This '
                     'robust performance extends across a wide variety of '
                     'comparison frameworks, including the optimization of '
                     'metrics such as accuracy, expected cost, lift, '
                     'precision, recall, and workforce utilization. The hybrid '
                     'also is efficient to build, to store, and to update. The '
                     'hybrid is based on a method for the comparison of '
                     'classifier performance that is robust to imprecise class '
                     'distributions and misclassification costs. The ROC '
                     'convex hull (ROCCH) method combines …',
         'author': 'Foster Provost and Tom Fawcett',
         'journal': 'Machine learning',
         'number': '3',
         'pages': '203-231',
         'pub_year': '2001',
         'publisher': 'Kluwer Academic Publishers',
         'title': 'Robust classification for imprecise environments',
         'volume': '42'},
 'citedby_url': '/scholar?cites=17970352882167184968',
 'cites_id': '17970352882167184968',
 'cites_per_year': {2001: 23,
                    2002: 34,
                    2003: 64,
                    2004: 65,
                    2005: 74,
                    2006: 98,
                    2007: 110,
                    2008: 121,
                    2009: 83,
                    2010: 104,
                    2011: 72,
                    2012: 63,
                    2013: 76,
                    2014: 88,
                    2015: 71,
                    2016: 67,
                    2017: 62,
                    2018: 67,
                    2019: 62,
                    2020: 79},
 'eprint_url': 'https://link.springer.com/content/pdf/10.1023/A:1007601015854.pdf',
 'filled': True,
 'num_citations': 1510,
 'pub_url': 'https://link.springer.com/article/10.1023/A:1007601015854',
 'source': 'AUTHOR_PUBLICATION_ENTRY'}

It seems that you want to do something else, though, but I do not quite understand what.

I have really the same request as @nd7141.  At present with an author id I can use, e.g., scholarly.search_author_id('jRwNfxwAAAAJ') (and perhaps subsequently use fill) to learn what there is to learn about that author.
I'm surprised that there's not an analogous method along the lines of scholarly.search_pub_id('u5HHmVD_uO8C').    Ideally this would parse the information from https://scholar.google.com/citations?view_op=view_citation&hl=en&citation_for_view=u5HHmVD_uO8C.
At present one can feed urls of the above form into scholarly.search_pubs_custom_url(), but the parser breaks.
The custom url solution you offer above does work, but requires knowledge not only of the publication id, but also the author id of at least one of the authors.


Should onError be an async function?

Just ran into an issue where I found myself wanting onError to be async so I could use an await in there.
https://github.com/threepointone/partyserver/blob/main/packages/partyserver/src/index.ts#L524
Does this seem reasonable, and if so hopefully it's not a big change?

yeah it should be doable, but go on, what was your usecase


How long will Dropwizard v1 continue to be supported?

I opened another issue (#3335) that I believe is blocking for me to upgrade to Dropwizard 2. After encountering this issue and looking around, I wanted to see if 1.3.X is continuing to receive security updates, etc.
Currently, the migration to v2 seems to be a substantial effort (see #3335), one that I don't have time for at the moment. However, it is important to me that we complete the update before security fixes stop for the 1.3 branch.
In looking at the releases history, it looks like 1.3.27 was released after 2.0 came out, which was great to see. However, I am still curious whether there are clear plans for continuing to provide updates and backports for v1. Is this documented some place that I am missing?
BTW aside from creating a couple of issues recently, I've been really enjoying working with this project. Thank you for all the hard work!

Is this documented some place that I am missing?

I looked here to see the security policy, which calls out which versions are supported.
https://github.com/dropwizard/dropwizard/security/policy

Thank you, this is great. I can see that it is currently supported, but I am wondering if there is any plan for sunsetting v1.3 in the near- or mid- future. For example, can we reasonably expect that 1.3 will be supported through the end of the year? Longer? Shorter? Basically, I'd like to know as much as there is to know about the projected end of support (or whatever the maintainers know about it) so we can prepare and aren't surprised by it and can plan our updates accordingly :slightly_smiling_face:

@mikeholler Thanks for this question and sorry that it took us so long to come back to you.
Dropwizard 1.3.x will be supported until December 31, 2020.
Please see https://groups.google.com/g/dropwizard-user/c/6gpDMuSb4_Y/m/poqbA4T9BQAJ for the official announcement on the dropwizard-user mailing list.


BUG:etcd cluster reliability

I use 3 machines(A/B/C) to set up etcd cluster.
Machine A create temp node A on etcd cluster and update TTL every 300ms.
Machine B create temp node B on etcd cluster and update TTL every 300ms.
Machine c create temp node C on etcd cluster and update TTL every 300ms.
Then reboot machine A, machine B update node B TTL failed, httpcode is 404, machine C update node C TTL failed, httpcode is 404.

@xiang90 ,hi, my etcd version is etcd-2.2.4. I will write a simple script to reproduce the issue i described later.
If machine A is not the leader, we can update the key?

@ffbin

If machine A is not the leader, we can update the key?

It should.

103_log.txt
176_log.txt
177_log.txt
@xiang90 .Hi, I create etcd cluster with machine 103/176/177, start command is "nohup ./etcd --initial-advertise-peer-urls http://${LOCAL_DSS_ADDR}:${DSS_LEAD_PORT} --initial-cluster default=http://${LOCAL_DSS_ADDR}:${DSS_LEAD_PORT} --advertise-client-urls http://${LOCAL_DSS_ADDR}:${DSS_LISTEN_PORT} --listen-peer-urls http://${LOCAL_DSS_ADDR}:${DSS_LEAD_PORT} --listen-client-urls http://${LOCAL_DSS_ADDR}:${DSS_LISTEN_PORT} >> log.out".
Then machine 103/176/177 create tmp node on  etcd cluster and update TTL every 300ms.
I use command "curl -L http://<IP_ADDRESS>:4001/v2/stats/leader" to find leader is machine 176.
This is result:
{"leader":"36e86ab78717bf20","followers":{"26830401b52980be":{"latency":{"current":0.001846,"average":0.0036024973302822205,"standardDeviation":0.0019507177054984759,"minimum":0.000844,"maximum":0.043545},"counts":{"fail":2,"success":3933}},"7658919be10a9cbd":{"latency":{"current":0.002288,"average":0.0033704399999999967,"standardDeviation":0.001743021193018436,"minimum":0.000804,"maximum":0.02294},"counts":{"fail":0,"success":3950}}}}
Then i reboot machine 103, machine 177/176 update tmp node TTL failed, httpcode is 404.

2016-09-13 20:38:43.695456 W | rafthttp: the clock difference against peer 7658919be10a9cbd is too high [10.708373022s > 1s]
2016-09-13 20:39:13.689414 W | rafthttp: the clock difference against peer 36e86ab78717bf20 is too high [7.186010049s > 1s]
2016-09-13 20:39:13.695635 W | rafthttp: the clock difference against peer 7658919be10a9cbd is too high [10.709596053s > 1s]
2016-09-13 20:39:43.690531 W | rafthttp: the clock difference against peer 36e86ab78717bf20 is too high [7.18504036s > 1s]
2016-09-13 20:39:43.695772 W | rafthttp: the clock difference against peer 7658919be10a9cbd is too high [10.710260094s > 1s]
2016-09-13 20:40:13.690751 W | rafthttp: the clock difference against peer 36e86ab78717bf20 is too high [7.184552696s > 1s]
2016-09-13 20:40:13.695927 W | rafthttp: the clock difference against peer 7658919be10a9cbd is too high [10.710672614s > 1s]
2016-09-13 20:40:43.690942 W | rafthttp: the clock difference against peer 36e86ab78717bf20 is too high [7.184582131s > 1s]
2016-09-13 20:40:43.696097 W | rafthttp: the clock difference against peer 7658919be10a9cbd is too high [10.710553353s > 1s]
2016-09-13 20:41:13.691130 W | rafthttp: the clock difference against peer 36e86ab78717bf20 is too high [7.184457263s > 1s]
2016-09-13 20:41:13.696192 W | rafthttp: the clock difference against peer 7658919be10a9cbd is too high [10.710938898s > 1s]

etcd printed out quite a few warnings. Please fix your clock (using ntp for example) and try again. I believe the clock difference is the root cause. Closing this issue.

@xiang90 ,i fix my  clock using ntp and have a try.
Machine 103/176/177, 176 is the leader.
Before i reboot 103, i use command "curl -L http://<IP_ADDRESS>:4001/v2/keys/master" on machine 176 can get the message:
{"action":"get","node":{"key":"/master","value":"\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u000e\u00001\u00000\u0000.\u00001\u00007\u00007\u0000.\u00001\u00001\u00002\u0000.\u00001\u00007\u00007\u0000\u001\u0001\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u000e\u00001\u00000\u0000.\u00001\u00007\u00007\u0000.\u00001\u00001\u00002\u0000.\u00001\u00007\u00007\u0000\u001\u0002","expiration":"2016-09-14T06:41:39.127717195Z","ttl":1,"modifiedIndex":622,"createdIndex":11}}
After i reboot 103, i use command "curl -L http://<IP_ADDRESS>:4001/v2/keys/master" on machine 176 can get the message:{"errorCode":100,"message":"Key not found","cause":"/master","index":645}.
Update tmp node TTL failed is failed, httpcode is 404.
103_log.txt
176_log.txt
177_log.txt

Try with 5 seconds TTL with 1 second update time. Let me know if the problem still exists.

@xiang90 , I have try with 5 seconds TTL with 1 second update time, the problem still exists.
103_log.txt
176_log.txt
177_log.txt

I cannot reproduce this. I created a 3 member clusters. Setting TTL keys, keep on updating it, and kill random member periodically, but everything seems to be fine.
Can you please provide a script that I can run to reproduce your issue on any local machine?
I should be able to do ./reproduce.sh to reproduce the issue you see.

@xiang90 , Can you share me your code about created a 3 member clusters and set TTL keys and keep on updating it. I want to compare your code and my code to find the difference. And I will provide reproduce.sh later.

@ffbin
Well. Ideally you should provide the reproduce script as I mentioned before. Since you did not, we have to guess what you did. I have no idea why you would like to compare them, I hope you can share us what you had at hand.
But anyway, here is my simple script:
on one member's machine:
./etcdctl set foo bar -ttl=5
for i in `seq 1 100000`;
        do
                ETCDCTL_API=2 ./etcdctl update foo bar -ttl=5
		sleep 1
        done

Kill the other members randomly, and expect the script always succeeds.
It works for me.

@xiang90 , my code is like this:
SPS_INT32 WriteToString
(
const SPS_CHAR *pcData,
SPS_SIZE_T   size_tSize,
SPS_SIZE_T   size_tLen,
std::string *pstrReturn
)
{
if (SPS_NULL_PTR != pstrReturn)
{
pstrReturn->append(pcData, size_tSize * size_tLen);
SPS_RET_VAL(size_tSize * size_tLen);
}
else
{
SPS_RET_VAL(0);
}
}
typedef signed int              SPS_INT32;
typedef long                    SPS_LONG;
int main()
{
while (1)
{
CURL *pCurl;
curl_global_init(CURL_GLOBAL_ALL);
pCurl = curl_easy_init();
    std::string strUrl("<IP_ADDRESS>:4001/v2/keys/master");
    std::string strBuffer;
    curl_easy_reset(pCurl);
    curl_easy_setopt(pCurl, CURLOPT_URL, strUrl.c_str());
    curl_easy_setopt(pCurl, CURLOPT_WRITEFUNCTION, &WriteToString);
    curl_easy_setopt(pCurl, CURLOPT_WRITEDATA, &strBuffer);
    curl_easy_setopt(pCurl, CURLOPT_TIMEOUT, 2L);

    SPS_LONG  i64HttpCode;
    SPS_INT32 i32CurlCode = curl_easy_perform(pCurl);
    if (CURLE_OK == i32CurlCode)
    {
        printf("curl_easy_perform success.\n");
        SPS_INT32 i32Ret;

        i32Ret = curl_easy_getinfo(pCurl, CURLINFO_RESPONSE_CODE, &i64HttpCode);
        rapidjson::Document jsonDocReturn;
        jsonDocReturn.Parse(strBuffer.c_str());
        if (i64HttpCode / 10 == 20)
        {
            printf("Curl get success.\n");

            /* update ttl */
			....
        }
        else
        {
            printf("Curl get failed.\n");
        }
    }
    else
    {
        printf("curl_easy_perform failed.\n");
    }
}

return 0;

}
I get node content first, if success, then update ttl.But if i reboot one machine, get node content will failed.If my use mode is error?

Can you provide a simple script that I can use to reproduce the issue?
There might be a bug in your user code. I would suggest you to use etcdctl to reproduce it.


CSS styling doesn't work in Handlebars chart

Bug description
CSS code defined in "CSS styles" section of Handlebars chart settings isn't applied to HTML template. It is shown as plain text on the chart instead.
How to reproduce the bug

Disable ESCAPE_MARKDOWN_HTML, enable HTML_SANITIZATION, allow CSS with HTML_SANITIZATION_SCHEMA_EXTENSIONS in superset_config.py as follows:

FEATURE_FLAGS = {
    "ESCAPE_MARKDOWN_HTML": False,
    "HTML_SANITIZATION": True,
}

HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
    "attributes": {
    "*": ["style","className"],
    },
    "tagNames": ["style"],
}

Create a Handlebars chart with one column ("descr" in this example) added from any dataset.
Set up HTML template as follows:

  {{#each data}}

{{descr}}

  {{/each}}

Set up CSS for the chart:

.data-list {
    background-color: yellow;
}

Observe your CSS code in the preview as a plain text.

Screenshots/recordings

Superset version
master / latest-dev
Python version
3.11
Node version
18 or greater
Browser
Chrome
Additional context
While investigating this issue, I dived into Handlebars code. There is a section in superset-frontend/plugins/plugin-chart-handlebars/src/components/Handlebars/HandlebarsViewer.tsx at lines 35-43 that seemingly retrieves HTML sanitization and schema overrides. I went to the browser console and printed these variables with this snippet:
const appContainer = document.getElementById('app');
const { common } = JSON.parse(
    appContainer?.getAttribute('data-bootstrap') || '{}',
);
const htmlSanitization = common?.conf?.HTML_SANITIZATION;
const htmlSchemaOverrides =
    common?.conf?.HTML_SANITIZATION_SCHEMA_EXTENSIONS;

console.log(htmlSanitization);
console.log(htmlSchemaOverrides);

The output returns true and empty object respectively despite the overrides are configured (see "How to reproduce the bug" section). It appears that either I'm doing something wrong, or the overrides are not read from the superset_config.py.
Checklist

[x] I have searched Superset docs and Slack and didn't find a solution to my problem.
[x] I have searched the GitHub issue tracker and didn't find a similar bug report.
[x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

@dosu
Yep, I've seen that similar issue and tried the steps described there. HTML is parsed just fine in my case, it's just CSS malfunctioning.
I've accidentally posted the issue too early and edited in some additional info in the "Additional context" section that may be useful in this case. Despite HTML_SANITIZATION_SCHEMA_EXTENSIONS is configured, it seems that this parameter is not taken into account.
If I disable HTML sanitization completely, the CSS is not applied as well.

@dosu
Can you provide an example of full superset_config.py with sanitization configured?

@dosu
Oh I see, HTML_SANITIZATION is not a feature flag, but a top level variable. I've fixed that in my config and double checked HTML_SANITIZATION_SCHEMA_EXTENSIONS, but the issue is still there.
Where in the project codebase can I find the bridge that passes HTML_SANITIZATION_SCHEMA_EXTENSIONS from the Python backend to the frontend? I'd like to try to check if the parameter is actually passed.

@dosu
Which file in the Superset codebase defines Common Bootstrap Payload? Could you provide the path to it?

@dosu
There was a mistake on my side: I was passing wrong config file while starting Superset. Fixed that. Now I can see that HTML_SANITIZATION_SCHEMA_EXTENSIONS is sent to the frontend correctly.
Anyway, when I pass the config file with
HTML_SANITIZATION = True
HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
    "attributes": {
    "*": ["style","className"],
    },
    "tagNames": ["style"],
}

the class attribute is blank for processed HTML template.
My chart config is as follows. HTML:

  {{#each data}}

{{descr}}

  {{/each}}

CSS:
.data-list {
    background-color: yellow;
    list-style: none;
}

Output HTML in the chart is:

Quisque vehicula pharetra velit, vel pharetra erat pellentesque a. Maecenas molestie maximus sem, ac dapibus.

Aliquam posuere malesuada pharetra. Pellentesque id vulputate elit. Proin tristique fringilla odio vel vehicula. Cras.

If I disable sanitization, the CSS is applied properly. It points out that my HTML_SANITIZATION_SCHEMA_EXTENSIONS is probably missing something.

@dosu
I've included class to allowed attribute list and restarted Superset. Updated config looks like this:
HTML_SANITIZATION = True
HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
    "attributes": {
    "*": ["style","className","class"],
    },
    "tagNames": ["style"],
}

The class attribute in the output HTML is still empty.

@dosu
className was there because it was present in other issues and in official article regarding Handlebars security in Superset here. Anyway, I've tried excluding className and this trick didn't work.

@dosu
Should xss library be configured somewhere in config files? I've checked superset-frontend/packages/superset-ui-core/src/utils/html.tsx and its contents match with the snippet you have provided. class attribute is there in the whitelist.

Seems like at this moment I've hit the wall with the bot. I would really appreciate if the community could help me to proceed with this issue.

Hi!  You got somewhere with the bot at least, I was gonna say HTML_SANITIZATION = True is in my top level superset_config.py, not a Feature Flag.  But looks like you got that.
I have this, which includes some options for iFraming you might not need.  I think this is nothing new but just to share in case:
HTML_SANITIZATION = True
HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
  "attributes": {
    "*": ["style", "className", "src", "width", "height", "frameborder", "marginwidth", "marginheight", "scrolling", "target"], # this enables basic CSS styling for Handlebars text charts and iFrame embeds for our feedback forms
  },
  "tagNames": ["style", "iframe", "h1", "h2", "h3", "h4", "h5", "h6"],
}

You might need to enable unsafe-eval in your Talisman CSP, see https://github.com/apache/superset/issues/27299#issuecomment-1978075353 and https://github.com/apache/superset/issues/25205 for instance

Hi, @sfirke! I've modified HTML_SANITIZATION_SCHEMA_EXTENSIONS and added Talisman config like this:
HTML_SANITIZATION = True
HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
  "attributes": {
    "*": ["style", "className", "class", "src", "width", "height", "frameborder", "marginwidth", "marginheight", "scrolling", "target"],
  },
  "tagNames": ["style", "iframe", "h1", "h2", "h3", "h4", "h5", "h6"],
}

TALISMAN_ENABLED = True
TALISMAN_CONFIG = {
    "content_security_policy": {
        "default-src": ["'self'", "'unsafe-inline'", "'unsafe-eval'"]
    }
}

I can see updated schema extensions at the client side:

However, these adjustments didn't do the trick for me. The class attribute is still empty.

I've also noticed an error in the browser console:
Uncaught NetworkError: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'http://localhost:8088/static/assets/worker-css.js' failed to load.
    at 408b31b0-bd74-41d2-bcda-02d1e74d554e:1:1

Wonder if it has something to do with the missing attribute.

If you are just working locally for now, can you try setting Talisman enabled to False? Then that's one thing we can remove from consideration if that doesn't fix it.

Also I see you are working on master / latest. I am working on 4.0.2 the latest official release. Maybe a bug has been introduced since then? Can you try 4.0.2?

Yep, it's local installation based on master without Docker. Disabled Talisman, class is still empty and the same error is present in the console.
Switched to 4.0 branch, rebuilt the app (both frontend and backend) and restarted the service. Same outcome :(

My colleague has managed to set everything up at our corporate instance, which uses 4.0.2. The config is pretty much the same, so it's either something wrong with my local installation, or with master. I lean towards the former.

Well I'm glad it's working elsewhere for your team.  One more possibility for something that could be wrong with a local installation: I saw someone mention in a comment recently (can't find it again) that they had to turn off a flag like DEBUG_MODE or similar, that when it was true it was overriding their Talisman settings.  Though when I look at the code, it looks like if you set TALISMAN_ENABLED = False that would take care of things.

Thanks for your help, @sfirke !
I couldn't find a flag similar to DEBUG_MODE in the documentation. But as CSS styling actually works at 4.0.2 production and this issue is mostly caused by my own local setup, I think it will be easier to just disable HTML_SANITIZATION for now.

Thanks for your help, @sfirke !
I couldn't find a flag similar to DEBUG_MODE in the documentation. But as CSS styling actually works at 4.0.2 production and this issue is mostly caused by my own local setup, I think it will be easier to just disable HTML_SANITIZATION for now.

@goldjee Hey goldjee can you tell me what worked for you what is the config you followed to make it worked?

@mahesh-babu-drivex
These are related settings in my local config:
FEATURE_FLAGS = {
    'ENABLE_TEMPLATE_PROCESSING': True,
    'ESCAPE_MARKDOWN_HTML': False
}

HTML_SANITIZATION = False
HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
  "attributes": {
    "*": ["style", "className", "class"],
  },
  "tagNames": ["style"],
}

TALISMAN_ENABLED = False
TALISMAN_CONFIG = {
    "content_security_policy": {
        "default-src": ["'self'", "'unsafe-inline'", "'unsafe-eval'"]
    }
}

Works fine for my purposes, but probably is not safe to use in production.


New first aid kits

About the PR
This adds a bunch of first aid kits based on TG but in a few cases customised to be more representative of the contents.
I created sprites for the burn, toxins, o2 and radiation kits and tried to make inhands sprites where possible for them plus for combat and purple kits.
See screenshot for kits but for list:

Black Kit - Combat medical kit (can be used to easily create a fill for syndicate meds (e.g. injectors and advanced stuff).
White Kit - Generic first aid kit
White + Red kit - Advanced first aid kit (has advanced healing items for quick healing).
Yellow kit - Burn treatment kit
Pink kit - Brute trauma treatment kit
Red kit - Radiation treatment kit
Blue kit - Oxygen deprevation treatment kit
Green kit - Toxin treatment kit

Corrected fills filepath from entities / specific to catalog and created basic fills for regular and burn kit. Remaining kits don't have relevant items but left comments on where to find the ideal loadouts for them. Also signposted with comments where to find the resources and entities so it can be easily modified in future.
Also removed old icon and added gauze as a medical item.
Screenshots

Icons total 11.2 KB

The O on the O2 kit sprite feels a little blurry and washed out, as if due to bad AA.

The O on the O2 kit sprite feels a little blurry and washed out, as if due to bad AA.

Same goes for burn, toxin and rad kit.

I think the rad one is absolutely fine, the toxin one is similar. The burn one sort of has that problem, but I'm fine with it... the O2 one I can see the case against, but I can also see why it might be hard to make it look decent while keeping it better defined. All in all, I'd say they're fine.

I just realized that you'll probably have to change the red cross on one of those sprites to... not be a red cross. Video games aren't allowed to use the symbol (violates Geneva Convention) and from time to time this does get enforced. Better not to take the risk.

SS14 almost commiting war crimes 😳

Quite dumb but actually true, but what could we have instead of the cross?

Quite dumb but actually true, but what could we have instead of the cross?

White cross. Just can't be red I guess.

What about an orange cross? Most people wouldnt notice that much of a difference

What about an orange cross? Most people wouldnt notice that much of a difference

Wikipedia actually lists that US ambulances used to use an orange cross but it was decided that was too close to red and was changed. So...

What about an orange cross? Most people wouldnt notice that much of a difference

Wikipedia actually lists that US ambulances used to use an orange cross but it was decided that was too close to red and was changed. So...

Does dark blue and black tickle your fancy? For the advkit.

Not gonna lie, dark blue looks awesome!

Fix your RSI meta.json and conflicts and this should be g2g. I like the sprites.

Fix your RSI meta.json and conflicts and this should be g2g. I like the sprites.

All fixed and good to go


Upstream 20160930

Context
Upstream has moved on and so must we
Considerations
Heroku scheduler will need updating

Only call seal once per day
Command-line is simply ./bin/seal.rb

Cc
@envato/marketplace

+1

+1

:+1: :tropical_fish:

Thanks folks.


卸载磁盘时忽略云上磁盘已经被删除的错误

这个 PR 实现什么功能/修复什么问题:
卸载磁盘时忽略云上磁盘已经被删除的错误
是否需要 backport 到之前的 release 分支:

release/2.11
release/2.10.0
release/2.9.0
release/2.8.0

/area region
/cc @swordqiu @yousong

Codecov Report

Merging #1840 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1840      +/-   ##
=========================================
- Coverage     7.6%    7.6%   -0.01%
=========================================
  Files         412     412
  Lines       63629   63631       +2
=========================================
  Hits         4841    4841
- Misses      58378   58380       +2
  Partials      410     410

Flag
Coverage Δ

#aFlag
7.6% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/managedvirtual.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c149ea2...56723f7. Read the comment docs.

/lgtm
/approve

/lgtm


Note Postgres' (current) RLS limitations for views

This is a pretty major caveat for views which ought to be noted (see #172).
I did not  note the read-only workaround (create a stored procedure with the "SECURITY INVOKER" option).
Relevant chatter about this:

https://stackoverflow.com/a/33863371
https://www.postgresql.org/message-id/flat/CABFpK629xHR-jbgO0tiprMr9aZLiofMkQ3E7QxqHFRVFNcqnSQ%40mail.gmail.com

Thank you! The SECURITY DEFINER analogy is really apt.
Note, however, that RLS will only be bypassed if the role that owns the view has SUPERUSER or BYPASSRLS privileges, so views can work with RLS if we define a less privileged role for them, check my comment https://github.com/PostgREST/postgrest-docs/issues/81#issuecomment-385497947 for the workaround.

i.e. the text in this PR is not correct, it implies RLS does not work for views. Closer to the trough would be text like: "in order for RLS to be applied/used, the owner of the view can not be a SUPERUSER"
This behaviour is logical and the same thing happens when you try to "observe RLS in action" and connect to the database as a superuser.

Tweaked:
"Views are invoked with the privileges of the view owner, much like stored procedures with the "SECURITY DEFINER" option. When created by a SUPERUSER role, all row-level security will be bypassed unless a different owner is specified."

Thanks, that's detail I wasn't aware of. Changed to:
"Views are invoked with the privileges of the view owner, much like stored procedures with the "SECURITY DEFINER" option. When created by a SUPERUSER role, all row-level security will be bypassed unless a different, non-SUPERUSER owner is specified."


Event seems not working

According to the document, the event can be handled like this. But I don't get the resource as described as below.
chimera: {
      users: {
        url: '/users',
        on: {
          'success': (resource) => {
              console.log(resource) // THIS IS UNDEFINED.
          }
        }
      }
    }

Upgrade to latest version v2.4.3
If issue still exists let me know.
Thanks


Update BeagleBone.md to fix spelling and grammar.

Update BeagleBone.md to fix spelling and grammar.

Thank you timvb3. would you leave your email address so that I can send coupon to you?


(PUP-9813) Performance test for ModuleTool::Tar::Mini

Adding a pending performance test that clearly shows that ModuleTool::Tar::Mini is about 100x times slower then system tar xzvf command.
Test should be unskipped if performance of ModuleTool::Tar::Mini is fixed.
As a walkaround I'm switching to ModuleTool::Tar::Gnu implementation as default.
Issue: https://tickets.puppetlabs.com/browse/PUP-9813

Can one of the admins verify this patch?

CLA signed by all contributors.

Thanks for your contribution @cardil! We currently default to minitar to prevent problems like https://tickets.puppetlabs.com/browse/PUP-7390 and https://tickets.puppetlabs.com/browse/PUP-3198. I thought I read somewhere that the ruby minitar implementation performs fsync unnecessarily for each file and directory it extracts. I say unnecessarily, because puppet extracts tar entries into a temp directory and then renames the directory to commit the changes. So we don't need to perform all of those intermediate fsync operations.

Using minitar:
# time puppet module install puppetlabs-stdlib --version 4.25.1
Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Notice: Installing -- do not interrupt ...
/etc/puppetlabs/code/environments/production/modules
└── puppetlabs-stdlib (v4.25.1)

real	0m8.973s
user	0m1.360s
sys	0m0.132s

Using patched minitar to avoid fsync calls:
# time puppet module install puppetlabs-stdlib --version 4.25.1
Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Notice: Installing -- do not interrupt ...
/etc/puppetlabs/code/environments/production/modules
└── puppetlabs-stdlib (v4.25.1)

real	0m2.352s
user	0m1.172s
sys	0m0.076s

I don't think we can directly compare the above times to executing the tar system command, because the puppet module install time include the time to load ruby, load puppet code and providers, apply settings catalogs, etc. However, it does provide the fastest time to unpack a module:
# time bash -c 'curl -s https://forge.puppet.com/v3/files/puppetlabs-stdlib-4.25.1.tar.gz -o puppetlabs-stdlib-4.25.1.tar.gz && tar xzf puppetlabs-stdlib-4.25.1.tar.gz'

real	0m0.157s
user	0m0.036s
sys	0m0.020s
root@lbshku31ofxu

If we include puppet --version to force ruby/puppet/facter loading, then using system tar is 2.3 times faster than optimized minitar (2.352/1.003)
# time bash -c 'puppet --version && curl -s https://forge.puppet.com/v3/files/puppetlabs-stdlib-4.25.1.tar.gz -o puppetlabs-stdlib-4.25.1.tar.gz && tar xzf puppetlabs-stdlib-4.25.1.tar.gz'
6.7.0

real	0m1.003s
user	0m0.768s
sys	0m0.084s

Given that I'm inclined to fix minitar, as in the maintenance costs with having different tar implementations (gnu/bsd/ustar/pax) outweighs the 2.3x performance benefit.

@joshcooper I think Roby native implementation should be default as it is, but only when it performs well. Unfortunately now it performs awful.
Switching to Gnu implementation on compatible platforms (Linux, Macos) should be a temporary solution. I can rewrite the code to default Minitar on other platforms (Windows, Solaris, HP-UX). Minitar performance should be boosted as a final solution.

Given that I'm inclined to fix minitar, as in the maintenance costs with having different tar implementations (gnu/bsd/ustar/pax) outweighs the 2.3x performance benefit.

I've actually written in PUP-9813 that "t might be at most 2x times slower then system command" so I think your fixed minitar implementation achieve that goal :beers:

@joshcooper I've written a test in this PR that isolate extraction with minitar and compares it to tar system command.
I'm wondering how your patched minitar performs in that test. Could you execute that test?

Thanks for submitting this @cardil. I'm going to close this as we need to update puppet to call the new minitar method that allows us to skip fsync'ing every file and directory. See https://tickets.puppetlabs.com/browse/PUP-10013. We'll be sure to compare that performance with similar native tar. Hopefully minitar should be less than 2x slower than native tar.


Factoring the individual DefinitionWithGroup sub-interfaces out...

...into a standalone interface to use as the base.
Updating all the affected interfaces and implementations
(per Jianghao's suggestion)

Can one of the admins verify this patch?

never mind - we're undoing the inGroup stuff


[VS Code] [Audio] HTTPS request failed for SkypeToken: Parse Error: JS Exception

Press F1 (or Ctrl-Shift-P), type "export logs" and run the "Live Share: Export Logs" command.
Drag and drop the zip to the issue on this screen and wait for it to upload before creating the issue.
For feature requests, please include enough of this same info so we know if the request is tool or language/platform specific.-->

Error:
HTTPS request failed for SkypeToken: Parse Error: JS Exception
Steps to Reproduce:
1.Click start audio call

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.84

applicationName
VSCode

applicationVersion
1.44.2

platformName
Windows

platformVersion
10.0.18363

@Talon-Marathon : thanks for reporting this issue! We have a fix that will be released shortly. I'm resolving this issue as a duplicate of #3432 to consolidate the communication.


please fix comment in mset function

there is this line
    HMSET replaces old values with new values.

in mset function in which is MSET command executed
this comment looks not correct to me

Thanks, comment seems to be incorrect. Fixed in #118


initial versioning of docs

Signed-off-by: Aditya Chaterjee<EMAIL_ADDRESS>Description
initial commit for versioning docs
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 1caa739fd8ee524fa3413ffd2a7ed8c4370acc4a at: https://6182660fa55a13cb426539a2--meshery-docs-preview.netlify.app

🚀 Preview for commit c4cb5e4116ec34216423a43af403a93b7ba1b338 at: https://618268f4425e32aca468ad01--meshery-docs-preview.netlify.app

🚀 Preview for commit 15f76d1d2cca78ce3659fcb1d4a2b2a3680e89b1 at: https://61827847af5e23d4fdf563a6--meshery-docs-preview.netlify.app

preview: https://61827847af5e23d4fdf563a6--meshery-docs-preview.netlify.app/v0.6/

🚀 Preview for commit 18505346d71bcfa69902a1cea65b94cdbabfb98d at: https://6188b2cd41845aa8adca1cae--meshery-docs-preview.netlify.app

@warunicorn19 you need to look at this and see if we can do this in our case too 👀
https://github.com/justwriteclick/versions-jekyll

Yeah @alphaX86  this is exactly what I'm trying to do rn, not sure if it works though, cause if you have a look that repo their website doesn't work.

Yeah @alphaX86 this is exactly what I'm trying to do rn, not sure if it works though, cause if you have a look that repo their website doesn't work locally.

 Here's a link to graphics you might incorporate into the article - https://drive.google.com/drive/u/0/folders/1QeevEVbVjkyvEkVNkHkRratVV-5oXdpH

🚀 Preview for commit 146353a13b3293136b5bbf5a4f1627e7d434e8f6 at: https://6194c2a9467babf0547d3799--meshery-docs-preview.netlify.app

🚀 Preview for commit 9ceca31decb0fb7a8faa527fb6f1ae460310b711 at: https://6194d7f587b68d08b2f1563d--meshery-docs-preview.netlify.app

🚀 Preview for commit eb4c1599bb4b132d4d63df3618c81cb738c3b9fa at: https://6194e0a5ca3a721ee7009202--meshery-docs-preview.netlify.app

Instead of "0.6" in the selector, will you use "latest"?
Will you add "v" I front of the version numbers in the selector?

Great changes, I couldn't review line by line :') so I just saw the output. I noticed that for older versions, the page is taking a lot time to fetch and render. Did you imported a lot of old files and used them? Or alt way? And the delay for fetching the pages can be reduced...
That's what I feel from my side

@alpha are you sure it's not an internet issue? it seems to be running quite fast for me

@Alpha are you sure it's not an internet issue? it seems to be running quite fast for me

Well, since it's a new page a cached copy isn't present, so it took a while to load a page (not main page) in old versions. Plus, my username is not correct BTW :') it's someone

oops sorry my bad. I checked on incognito as well, seems to be running for me. Anyway, i don't that'll be the case when it's deployed it's just happening now because of netlify.

🚀 Preview for commit f2dd4ad8bf83ccfdbb66bf0987bc7a92561dd67e at: https://619517cb8f5c5618930d7f41--meshery-docs-preview.netlify.app

🚀 Preview for commit ceebec63089588eb29880f15bb54be3c154ab790 at: https://61952098b09a22216cc0534a--meshery-docs-preview.netlify.app

🚀 Preview for commit 6fd966b5d2b34cca51f95940460e4edc78fd268e at: https://619522b13dd0b722d6c74924--meshery-docs-preview.netlify.app

@leecalcote so for the broken link which popped up in the dev call, in v0.4 there is no page for window(in supported platforms) so I'll just remove it from the sidebar right?

@leecalcote so for the broken link which popped up in the dev call, in v0.4 there is no page for window(in supported platforms) so I'll just remove it from the sidebar right?

Right, assuming that this was just a bug that we were carrying at the time.

🚀 Preview for commit 39da6ea4e3968d51d86db5d210dd12370748e101 at: https://61953b0fff7ebf429f1ec2c8--meshery-docs-preview.netlify.app


Add [Phishing] #malicious GAONYL…RDCXLM

Address: GAONYLWLW47QNKFNXLCJMEKN63OOIR2CKGWZ44R26RKDMFGU6NRDCXLM
Tags: malicious
Title: Phishing
Requested by @sysmanalex

Multi-Sign account for scammer

Can you please give more details about this address as to its fraudulent activities. Do they have a website?


datafs: info: raise better FileNotFoundError

Codecov Report
Patch coverage: 50.00% and project coverage change: +0.03% :tada:

Comparison is base (1483f63) 61.41% compared to head (4034c6e) 61.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   61.41%   61.45%   +0.03%
==========================================
  Files          57       57
  Lines        3802     3803       +1
  Branches      672      671       -1
==========================================
+ Hits         2335     2337       +2
  Misses       1330     1330
+ Partials      137      136       -1

Files Changed
Coverage Δ

src/dvc_data/index/index.py
66.20% <ø> (+0.53%)
:arrow_up:

src/dvc_data/fs.py
63.10% <50.00%> (-0.90%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create an advanced part tutorial for Mutual TLS

Create an advanced part tutorial for Mutual TLS

We can close this since the PR has been already merged.


Update proportions of the fluent logo

PR Summary
The original version looked a bit too wide.  Moved the cursor a bit under the prompt and reduced the width.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

@iSazonov didn't notice that, will resize

There's still a small gap o the left side.  Couldn't figure out how to fix that since selecting the image includes that gap.

@SteveL-MSFT Is it possible to post the before and after SVG in the description?


pre-commit.ci failing - poetry lock

The pre-commit.ci action is failing because of the poetry lock hook.
https://results.pre-commit.ci/latest/github/phytest-devs/phytest/main
HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /pypi/openpyxl/json (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7fc35c2adfa0>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))

Doh! Sorry about that. I'm not sure if this is a temporary issue with the precommit CI service but, until we know more, I will disable this during CI as soon as I can get in front of a computer.

No worries! not a major issue, just flagging it.

Closed by #23


CI auto-merge-dependabot: Only run on dependabot branches

@runephilosof-abtion
FYI: This change caused automerge to only run on PRs that were targeting branch starting with "dependabot/".
I've now made the following change which appears to make it work as intended:
https://github.com/abtion/rails-template/commit/6f3164e06f08602fd42752d2cba4ed7fff1cea85
Based on the last paragraph in this section:
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-your-pull_request_target-workflow-based-on-the-head-or-base-branch-of-a-pull-request


Add a license to the repository

I recently came across your project Qiskit_Global_Summer_School_2022 and I noticed that the repository github.com/zain2864/Qiskit_Global_Summer_School_2022 currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Thank you for your issue, I have added the License.


Resolves Issue #650

Fixes #650
@Tanish0019 @ReimarBauer
Removed Email field from admin window in mscolab.
Screenshot of the current look

@nakul-shahdadpuri I see you're populating table by removing emails from the response sent back in the frontend. It will be better if you instead update the mscolab api for this and not do the filtering on the frontend. Also can you play around with the window/table sizes in the UI so that username column is not so stretched. It looks a bit weird right now. Thanks!

Also we never change the ui files by hand. Always use the Qt designer to update the .ui files. This is a helpful article on getting started with qt designer

@ReimarBauer yup I'll do that.
@Tanish0019 I initially had started by changing the models.py file, but I wasn't sure if the API was being called anywhere else, so I just removed it from the admin window frontend. I'll try tinkering with the models now. Yup, the UI looked a little stretched I'll work on that too. :)

@nakul-shahdadpuri no need to update models.py that defines the schema. We need to update 2 apis which are used to populate these two tables. You can just remove email from the response in those apis 😀

@Tanish0019 @ReimarBauer
This is how the admin tab looks now. I removed the emailid attribute from the response by changing the API.

I can't reproduce the proposed solution.

@Tanish0019 or/and @Marilyth please can you try out the proposed solution. Perhaps my setup can have issues

@ReimarBauer @Tanish0019 @Marilyth
I am still getting the following output.
I had removed the email field from file_manger.py in fetch_users_with_permission and fetch_users_without_permission which was being called in server.py
I am not sure why the email field is still present in your version.

I get a new clone tom. and try again.

I'm not sure if you are on our slack channel. If you want an invite send me a mail to<EMAIL_ADDRESS>If you are there ping me. (https://open-mss.github.io/contributing/)
We should find what makes this difference. I tried to debug the behaviour with the yourmss server.
My server sends as second attribute the email address.

Got it. My failure. yourmss is on the 2.0.1 server version ;)


Error while updating TI process in TM1 < 11

Hi,
I'm getting the following error when trying to create/update a process with the following json body.
Exception:
...\TM1py\Services\ProcessService.py", line 121, in create
del body['Parameters'][p]['Type']
TypeError: list indices must be integers or slices, not dict
Process JSON:
'{"Name": "Admin - Start GL Forecast1", "PrologProcedure": "\\r\\n#****Begin: Generated Statements***\\r\\n#****End: Generated Statements****\\r\\n\\r\\n", "MetadataProcedure": "\\r\\n#****Begin: Generated Statements***\\r\\n#****End: Generated Statements****\\r\\n", "DataProcedure": "\\r\\n#****Begin: Generated Statements***\\r\\n#****End: Generated Statements****\\r\\n", "EpilogProcedure": "\\r\\n#****Begin: Generated Statements***\\r\\n#****End: Generated Statements****\\r\\n", "HasSecurityAccess": false, "UIData": "CubeAction=1511\\fDataAction=1503\\fCubeLogChanges=0\\f", "DataSource": {"Type": "None"}, "Parameters": [{"Name": "pStartPeriod", "Prompt": "", "Value": ""}], "Variables": [], "VariablesUIData": []}'
TM1 Version 10.2.2 FP6 IF7

Hi Tomasz,
thanks for the catch!
I think I found it. Could you try to replace
for _, p in enumerate(body['Parameters']):
with
for p in range(body['Parameters']):
in line 120 in the ProcessService? Does it solve the issue?
I curretly don't have TM1 10.2.2 installed.

Hi Marius,
I tested and received a 'list' object cannot be interpreted as an integer` exception. Line 104 because I'm updating the TI process.
...\TM1py\Services\ProcessService.py", line 104, in update     for p in range(body['Parameters']): TypeError: 'list' object cannot be interpreted as an integer

Hi,
sorry what meant was:
for p in range(len(body['Parameters'])):

Hi,
it is better, but as Type was added in TM1 v11 it does not exists in my JSON and the next statement fails.
'..\TM1py\Services\ProcessService.py", line 121, in create
del body['Parameters'][p]['Type']
KeyError: 'Type' '

Hi Marius,
the issue has been fixed by introducing the drop_parameter_types class.
Thanks for that.
BR
Tomasz


Change webpack to devDependency and react to peerDependency

Cool, thanks for the update @VolodymyrPliuta.
This makes the project feel completed. 🙂
You can publish from specific component folders in a react project.
Also thank you for your efforts testing the project on an Ubuntu Linux machine. 💯


OTR remove parent 'multi-organism cellular process' from 'viral process'

Hello,
After discussion with the ViralZone group, we propose to remove the parent 'multi-organism cellular process' from 'viral process'; this way viral processes are not cellular (which is consistent with the fact that viruses are not cells).
Any comments/objections ? @jimhu-tamu
(not sure who else to tag).
Thanks, Pascale

I don't object to removing that parent, but not for that reason (see below). The definition of multi-organism cellular process  is "Any process that is carried out at the cellular level which involves another organism of the same or different species". To me, that only requires that the process in question happen at the cellular level, not that it involve two cellular organisms, or even that the main interacting organisms be cellular (e.g. GO:0098669 superinfection exclusion).  If both have to be at the cellular level, it's not clear to me how the virus infection processes are different from things like GO:0035915 pore formation in membrane of other organism.
I think viral process should not be an is_a child of multi-organism cellular process because I think that viral processes are not all at the cellular level. For example: There are viruses that use host extracellular proteases for their maturation (see https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4328142/). I believe that the protease doesn't gave to originate from the infected cell, but rather from the tissue being infected.

@pmasson55 : any comment ?

I guess it's fine if we all agree that this branch should be removed.

Hi @jimhu-tamu ,
just so I am clear: you do agree that no viral process should be a child of 'multi-organism cellular process' ? I am starting to remove all connections that cause this link as well. See also
https://github.com/geneontology/go-ontology/issues/13468
Thanks, Pascale

@pgaudet
I think you're not clear about what I'm saying because it's not clear in my own mind!
I do not agree that no viral process should be a child of 'multi-organism cellular process'. Clearly, some viral processes occur in host cells.  However, the example was to illustrate that some viral processes are extracellular.
I think that means I would remove the multi-organism cellular process parentage as you proposed, some but not all of the child terms for viral process should be reconnected to multi-organism cellular process either directly or via an NTR for one or more intermediate umbrella terms.
I think that how to do that is beyond the scope of this tracker item

Hi Jim,
The issue is with cellular. In GO (and elsewhere) "cell" is defined as "The basic structural and functional unit of all organisms. Includes the plasma membrane and any external encapsulating structures such as the cell wall and cell envelope.", which excludes viruses. Moreover, "virion" is a sibling of "cell".
GO has a concept "host cell" to represent processes that occur in the host's cellular environment. So, since in CC the virion is disjoint from the cell, to be consistent this should also be the case in BP (see attached diagram of a few examples of relevant terms).

Does that clarify my point ?
Thanks, Pascale

I'm afraid I'm still confused. While it seems to me that there is clearly an issue with cellular, I'm not sure how it relates to the posted image. Are you saying that a process that occurs in a host cell is not cellular because it is occurring in a component in the host cell branch and not in the cell branch? So there should be a distinction between cellular and host cellular?
I would think that GO would not want to replicate the parallel host cell structure from CC to BP. There's a note on GO:0044215 ! other organism that talks about plans to obsolete that term.  But independent of the note, one of the things that is pushing us toward trying to be more LEGO/GO-CAF compliant for CACAO is how the host cell stuff leads toward an internal duplication in the CC tree. I'm thinking it makes more sense to collapse to a single concept of cell and use some kind of occurs_in added info to distinguish host from symbiont.

Hi @jimhu-tamu ,
What I am saying is that right now there is a distinction between cellular and host cellular, so the changes I am proposing are consistent with this structure.
Also, since viruses are not cells, they cannot have cellular processes without breaking the logic of the ontology.
There is another issue discussing cellular processes: https://github.com/geneontology/go-ontology/issues/12849
We can make further modifications according to decisions there.
Makes more sense ?
Thanks,
Pascale

testing notifications


How to add API key?

Hello,
I don't see any reference to the API key in the JS code or examples. If I dive deep into the examples, I see:
iOS: Go to the Info.plist within the iOS native project and add your ApiKey,{'\n\n'}
Android: Then go to the manifest.xml within the Android native project and add your ApiKey.

This is still confusing, it tells us the value (api key) but not the key.
Would be great to add all this to README.

For iOS here is where your key goes.
For Android your key goes here
I will fix those docs now since they cause confusion!

The docs actually tell you about the API key, on the iOS docs  and on the Android docs.

Perfect, thanks!


Added getAll operation

The getAll operation is used by the db-syncer to retrieve offset information.

Rebasing.

Rebased, just let me test again the putAll method

Including a change that wraps the uses of SearchBackend in an Instance.

I reverted the putAll change, and I'll do it on another PR.

The TimerMetric needs to use the rule name during registration. Since every rule has the same name, the MetricsResourceTest is failing. Since my test does some operations, the metric of another rule is affected.


Add testing

I've added a default scenario for testing with molecule. No tests have been added.
Also added a conditional to address #2
Addresses #1

I think I've rebased... waiting for checks to finish.

Moving this to #5, to have a nicer history


feat: ✨ add support for folder dnd in syn-file

enable folder dropping
change button and drop-area text according to webkitdirectory
added story for folder drop

Pull Request
📖 Description

Adds dnd support for folders
🎫 Issues
#583

👩💻 Reviewer Notes

Have a look at the new "Directory" story
📑 Test Plan

set webkitdirectory
set accept
drag a folder with accept-files and not accept files onto the drop area
the number of files should match the number of proper accept files

✅ DoD

[x] I have tested my changes manually.
[ ] I have added automatic tests for my changes (unit- and visual regression tests).
[x] I have updated the project documentation to reflect my changes (e.g. CHANGELOG, Storybook, ...).
[x] I have added documentation to the DaVinci migration guide (if need be)
[x] I have made sure to follow the projects coding and contribution guides.
[ ] I have made sure that the bundle size has changed appropriately.
[ ] I have validated that there are no accessibility errors.
[ ] I have used design tokens instead of fix css values

Just had a look at this, seems to work pretty well. However, I noted that with the following tests:

set webkitdirectory
set accept
drag a folder with accept-files and not accept files onto the drop area
the number of files should match the number of proper accept files

I do get a valid input field when setting accept to *.png and uploading a folder full of woff files. Currently, it adds all the files in the folder to the files property of the <syn-file>. This was intended as far as I know. However, there is no user feedback about errors (e.g. if there where files selected that are not available in the accept property. Maybe we should at least emit a syn-invalid or something like this? As far as I can see, I did not do this for the original implementation, too, so we might have to discuss this in another issue.


Explore if removing the XSI Schema Location from XML fixes AASX Package Explorer Issue

As discussed in the Committer meeting on 7.11., it is not possible to provide a permanent URL to the XSD document right now. Thus, a trivial fix for https://github.com/eclipse-aas4j/aas4j/issues/186 would be to completely remove the schema location attribute.
However, it needs to be checked if this also fixes the issue with the AASX Package Explorer.

See my comment in the other issue: https://github.com/eclipse-aas4j/aas4j/issues/186#issuecomment-1803588259
Given that I did not miss anything, removing the XSI Schema Location would not make any difference.


Version conflict

The version is relying on transformers 4.34 dependency at the moment, but is requiring transformers 4.35 as per requirement parser. Please fix!

Thanks @kithogue , would you mind give us more details about the conflict you found? In some cases we have to constrain transformers to 4.34, but in most cases we didn't have such limitation. What's your use case?

Hi @kithogue , can you share your use case?

Close it first until the user provide details


[Feature] Add option to disable the automatic restart of the proxy containers

I'm using HAProxy and the restart of the container creates a downtime of 1-2s (due to the container restart).
Currently HAProxy using the option -sf allows some kind of configuration refresh.. that makes useless the container restart.
(I'm using an approach similar to https://github.com/million12/docker-haproxy to detect configurarion file changes)
Having this feature allows to have almost no downtime when containers are added/removed

We used to do this when HAProxy was embedded.  Since we moved to use external proxy images we can no longer control the life cycle of the container to that level.  We could look at possibly allowing Interlock to manage launching the proxy containers as an alternative that would allow control over how HAProxy is started.
In an ideal world, HAProxy should be able to handle a SIGHUP and "just work" like nginx does.  Then we could do the same thing we use for nginx instead of this reload hassle.

currently im using this bug https://github.com/ehazlett/interlock/issues/189 to achieve the feature :smile:

We used to do this when HAProxy was embedded. Since we moved to use external proxy images we can no longer control the life cycle of the container to that level.

currently i'm using a custom image of haproxy... of course handling signals is cool but adding an option to the extension as example "DoNotRestartContainer=1" will allow users to do their implementation of the restart policy
Adding a simple "exit" in https://github.com/ehazlett/interlock/blob/master/ext/lb/haproxy/haproxy.go#L66 will be enough
[[Extensions]]
Name = "haproxy"
ConfigPath = "/usr/local/etc/haproxy/haproxy.cfg"
PidPath = "/var/run/haproxy.pid"
TemplatePath = "/usr/local/haproxy.cfg.template"
BackendOverrideAddress = "<IP_ADDRESS>"
MaxConn = 1024
Port = 80
AdminUser = "admin"
AdminPass = "interlock"
DoNotRestartContainer=1

https://gist.github.com/goetas/8a6c95b7fc0d25f2e866db385fee467a is my modified version of the official HAProxy


Binance API does not work when downloading in publish-flow-restapi.md

After publishing the rest API asset on mumbai, file info couldn't be fetched from provider and it crashes at the download part (in Ocean Market and also from ocean.py console) https://market.oceanprotocol.com/asset/did:op:c5cc054e0e1eab4a0e4a6669e697c14b27061d0aca6fd4c01f2a767a331b9376. It is due to the URl, because Binance API has some limitations and it's not available anymore in some places.
Created another one based on Kraken API URL and it worked https://market.oceanprotocol.com/asset/did:op:3447dc6a8761ec5b22d55510ff39d734e9f89b61eee1772628e08dc21a0342b5
Update the URL from the README to avoid the errors.

As far as I know, this issue has been encountered before. I remember Trent creating a Binance API readme a few months ago, but we decided to change it due to the same limitations. Am I remembering this correctly, @trentmc? Or was it an entirely different thing?
How should we proceed here? If the link is not "stable" we can not guarantee anything from within the Ocean tools.

Example api url (without start time & end time params): https://api.binance.com/api/v3/klines?symbol=ETHUSDT&interval=1d
Works for me.
Christian reported: it blocks him from usa - "restricted region"

Tested with  https://api.binance.com/api/v3/klines?symbol=ETHUSDT&interval=1d and it failed at download again. The URL is accessible and I can publish the asset, but the problem is at the initialize part. Maybe these URLs have an encoding that cannot be decrypted by provider.
Error from provider: NoneType :)
2023-03-21 16:26:22
NoneType: None
ERROR Error: Asset URL not found, not available or invalid. Payload was: ImmutableMultiDict([('documentId', 'did:op:577761687ddee26bf0a9ba7260916cb9f293a6f312dbcc5b72fdc98751351476'), ('serviceId', '0'), ('fileIndex', '0'), ('consumerAddress', '0xCa757bFbF46E2de1f171e1eBcc70C15Fc0F28096')])

UPDATE: Provider is hosted in U.S., so it won't work with Binance API.

We discussed in planning, we all agreed the solution will be:
Switch to using kraken not binance
Other potential solutions:

move Provider to EU data center
tell the user: if region problem, run your [REDACTED]
don't use Provider lol (Template 3)


getMessages always return null

all of there methods (getMessages , getContacts and getChats) return null

@Engx-eg ok i will check

Fixed in latest Version : 2.0.1


[cherry-pick] Get hive column statistics downgrade policy (#4409)

What type of PR is this：

[ ] bug
[x] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
https://github.com/StarRocks/starrocks/pull/4409
Problem Summary(Required) ：

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage check]
:disappointed: fail : 0 / 23 (00.00%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/external/hive/HiveMetaClient.java
0
23
00.00%

@Mergifyio backport branch-2.3


Cannot invoke localhost endpoints

@http:GET {}
    @http:Path {value:"/reserve"}
    resource reserveAppointment (message m) {
        http:ClientConnector healthCareEP = create http:ClientConnector("http://localhost:8080/healthcare/ent");
        m  = http:ClientConnector.get(healthCareEP, "/", m);
        reply m;
    }

Request to above service responds as "Cannot GET /healthcare/ent/".
If, endpoint url is changed to the IP address, this works.

Tried with the given config and it works. Could be something related to the back-end.

Cannot reproduce in latest. Hence closing the issue.


Fix redirect path issue for AddBrokerPage in OpenShift console

Currently, in the OpenShift console, our custom forms redirect to the Broker list page upon clicking the Create or Cancel buttons, which is incorrect. Update the logic so that the redirection always navigates back to the previous location after broker creation or cancellation, across all instances where the custom form is used.

Closed as completed via PR#318


PeoplePicker seems to query People incorrectly

Hi, I am having trouble getting the People Picker component working. I am wondering if this might be a bug, or if I am just using the component incorrectly.
Category
[ ] Enhancement
[x] Bug
[x] Question
Might be a bug, or I am misusing the component
Version
Please specify what version of the library you are using: [3.10.0]
Expected / Desired Behavior / Question
I expect the PeoplePicker component to correctly query people from the SharePoint and display them when searching for a user.
Observed Behavior
When I start typing in the people picker, no suggestions are made. And I can observe the following in the console:
The PeoplePicker tries to make a POST request to this endpoint: https://<myTenant>.sharepoint.com/sites/teamtestsite/_api/SP.UI.ApplicationPages.ClientPeoplePickerWebServiceInterface.clientPeoplePickerSearchUser
with the following request content:
{
  "queryParams": {
    "AllowEmailAddresses": true,
    "AllowMultipleEntities": false,
    "AllUrlZones": false,
    "MaximumEntitySuggestions": 5,
    "PrincipalSource": 15,
    "PrincipalType": 1,
    "QueryString": "test",
    "SharePointGroupID": null
  }
}

the server then responds with the following:
{
  "error": {
    "code": "-1, Microsoft.OData.Core.ODataException",
    "message": "A null value was found for the property named 'SharePointGroupID', which has the expected type 'Edm.Int32[Nullable=False]'. The expected type 'Edm.Int32[Nullable=False]' does not allow null values."
  }
}

Visually no people are suggested in the PeoplePicker.
Also here is my code for using the PeoplePicker:
        <PeoplePicker
          context={context.webPartContext}
          titleText="People Picker"
          personSelectionLimit={3}
          ensureUser={true}
          showtooltip={true}
          required={true}
          onChange={handlePeoplePickerChange}
          showHiddenInUI={false}
          principalTypes={[PrincipalType.User]}
          resolveDelay={1000}
        />

To me this seems like, that the SharePointGroupId should not be part of the request. Or maybe this property has become mandatory. I am kind of lost on where to even begin investigating. Hoping someone is able to help me out here. Tyvm in advance.
Steps to Reproduce
This happens every time

@SmarterJB Thank you so much for pointing me to that PR. This is exactly what I was looking for, but couldn't find it.


Updated layer meta-edison-bsp

Signed-off-by: Sebastian Panceac<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@resin-jenkins add to whitelist


made start a toggle button without modifying anything else

This is the better PR of the same functionality i was trying to execute can you review this plz

solve the conflict and add screen shot of changes

closing the pr :)
fork again and then make changes

OK hope third time's the charm:)


Walk PE files' sections instead of using swift_enumerateAllMetadataSections().

On Windows, the platform provides sufficient API for us to walk images at runtime looking for those that contain Swift metadata (similar to what we do on Darwin.) Therefore, we don't need to use the swift_enumerateAllMetadataSections() function from the Swift runtime on Windows.
This change also plumbs through an imageAddress argument to the discovery callback function. We're not currently using it, but it should be useful in the future for diagnostics (e.g. indicating that some data from a given image is malformed, or for passing to downstream testing tools that can make use of it.)
This change also also plumbs the stop argument down into the platform implementations so that we don't keep iterating images after the caller has told us to stop. In practice this has not been a correctness problem, but it does impact performance of type discovery.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test


Problem with ImportError: No module named 'httplib' from securitycenter import SecurityCenter5

To: Paragbaxi
Thank you for taking the time and giving me a reply.
I’m still new to python and I’m having a problem figuring out how to solve this problem.
So I will take a guess.
Error message below:
File "C:\Python34\lib\site-packages\securitycenter_init_.py", line 1, in
File "C:\Python34\lib\site-packages\securitycenter\sc4.py", line 6, in
ImportError: No module named 'httplib'
So, I went to GitHub: pySecurityCenter / securitycenter / sc4.py
On line 6 I found:
import os, sys, ssl, random, httplib, logging, mimetypes, urllib2, calendar
Does this mean I have to remove httplib from the mod?
Do I copy and paste all of: sc4.py into my program below?
Then copy all of:  init.py?
++++++++++++Program Below+++++++++++++++++++++++
from securitycenter import SecurityCenter5
#import securitycenter
#from securitycenter import Client
#sc = SecurityCenter5('https://<IP_ADDRESS>:8834')
#sc.login('swtest','P@ssw0rd!')
#response = sc.get('status')
#print('response=%s'%(response))
import http.client
#from securitycenter import SecurityCenter
#from .nessus import Nessus
sc = securitycenter.SecurityCenter('https://<IP_ADDRESS>:8834','swtest','P@ssw0rd!')
#sc = securitycenter.SecurityCenter('https.client.HTTPConnection://<IP_ADDRESS>:8834','swtest','P@ssw0rd!')
print('Finish')
++++++++++++Program End+++++++++++++++++++++++
Objected: Login to Tenable Security Center and run a Nessus Scan
Running: Python 3.4 and Security Center 5.3.2
I’m not sure what to do to solve this problem.
Thanks for your help
Pythoncode17

https://github.com/SteveMcGrath/pySecurityCenter/pull/27
On Tue, Jun 28, 2016 at 4:20 PM pythoncode17<EMAIL_ADDRESS>wrote:

To: Paragbaxi
Thank you for taking the time and giving me a reply.
I’m still new to python and I’m having a problem figuring out how to solve
this problem.
So I will take a guess.
Error message below:
*File "C:\Python34\lib\site-packages\securitycenter__init__.py", line 1,
in *
*File "C:\Python34\lib\site-packages\securitycenter\sc4.py", line 6, in *
ImportError: No module named 'httplib'
So, I went to GitHub: pySecurityCenter / securitycenter / sc4.py
On line 6 I found:
import os, sys, ssl, random, httplib, logging, mimetypes, urllib2,
calendar
Does this mean I have to remove httplib from the mod?
Do I copy and paste all of: sc4.py into my program below?
Then copy all of: * init.py*?
++++++++++++Program Below+++++++++++++++++++++++
from securitycenter import SecurityCenter5
#import securitycenter
#from securitycenter import Client
#sc = SecurityCenter5('https://<IP_ADDRESS>:8834')
#sc.login('swtest','P@ssw0rd!')
#response = sc.get('status')
#print('response=%s'%(response))
import http.client
#from securitycenter import SecurityCenter
#from .nessus import Nessus
sc = securitycenter.SecurityCenter('
https://<IP_ADDRESS>:8834','swtest','P@ssw0rd!')
#sc = securitycenter.SecurityCenter('https.client.HTTPConnection://
<IP_ADDRESS>:8834','swtest','P@ssw0rd!')
print('Finish')
++++++++++++Program End+++++++++++++++++++++++
Objected: Login to Tenable Security Center and run a Nessus Scan
Running: Python 3.4 and Security Center 5.3.2
I’m not sure what to do to solve this problem.
Thanks for your help
Pythoncode17
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SteveMcGrath/pySecurityCenter/issues/25, or mute the
thread
https://github.com/notifications/unsubscribe/AA6R8cez8S6jfOOI7AuOwdQQE1jQgRY5ks5qQYIGgaJpZM4JAfqv
.

--
Parag


Duplicated PR created for a dependency present in just one of several packages in a monorepo

Package ecosystem
npm
Manifest location and content prior to update

/package.json
/packages/daemon/package.json

dependabot.yml content
https://github.com/relaycorp/awala-gateway-desktop/blob/master/.dependabot/config.yml
Updated dependency
@relaycorp/relaynet-testing from 1.1.4 to 1.1.5
What you expected to see, versus what you actually saw
@relaycorp/relaynet-testing is only used in /packages/daemon/package.json, not in /package.json, so I expected to see just one PR for this dependency. Instead, I got 2 PRs, and the one for the root package.json doesn't actually change /package.json, but /packages/daemon/package.json -- so the two PRs are identical except for the PR titles.
Images of the diff or a link to the PR, issue or logs
The PR I'd expect: https://github.com/relaycorp/awala-gateway-desktop/pull/64
The additional PR I wouldn't expect: https://github.com/relaycorp/awala-gateway-desktop/pull/63

This sounds very similar to #1408 which means that this problem is not limited to npm packages.

I don't see this issue in any of the 40+ repos we have, except for the one repo where we use a monorepo. And roughly 50% of our repos use NPM and around 40% Gradle.

Given the path to the dependabot config file mentioned in the original post, that was for Dependabot preview, before the service was rewritten native to GitHub.
I see on the repo (thankfully it's public) that you're still using Dependabot... Are you still seeing this?

Thanks for looking into this @jeffwidman. I haven't seen this issue in ages so I'll go ahead and close this.

That's great news! Thanks for letting us know.


About checkpoints to be used by finetune

Hello! I am very interested in your work and see that you release the weight of Show-o before fine-tuning on LLaVA instructional tuning datasets.
I have the following two questions:

I see that you recommend in the README to go to finetune on the basis of the  show-o-512x512-wo-llava-tuning  checkpoint, so why don't go to finetune on the basis of the  show-o-512x512. Is it because there is a performance degradation on certain downstream tasks after fine-tuning on LLaVA instructional tuning datasets?

If I want to fine-tune on certain visual downstream tasks, which checkpoint should I use?

Hi, thanks for your interest in our work. If you'd like to reproduce our results, you can try the pre-trained one. Besides, because the final checkpoint was fine-tuned on the llava data, further fine-tuning will degrade the performance (overfitting).


How to load an existing model?

Sorry for being so dumb, but I see a lot of documentation on how to create and save models, but not load them and use them for new predictions--is that documented somewhere?
For example, I have the following adme models:
(p36) user@computer :~/TDC/adme_models$ ls
bioavailability_ma_model       cyp1a2_veith_model                    cyp2d6_substrate_carbonmangels_model  half_life_obach_model               pgp_broccatelli_model
caco2_wang_model               cyp2c19_veith_model                   cyp2d6_veith_model                    hia_hou_model                       ppbr_az_model
clearance_hepatocyte_az_model  cyp2c9_substrate_carbonmangels_model  cyp3a4_substrate_carbonmangels_model  hydrationfreeenergy_freesolv_model  solubility_aqsoldb_model
clearance_microsome_az_model   cyp2c9_veith_model                    cyp3a4_veith_model                    lipophilicity_astrazeneca_model     vdss_lombardo_model

(p36) user@computer:~/TDC/adme_models$ cd caco2_wang_model/
(p36) user@computer:~/TDC/adme_models/caco2_wang_model$ ls
config.pkl  model.pt

I'd like to load the caco2_wang_model and then load new smiles compounds for predictions. Any pointers would be appreciated!

i don't think it is automatically downloaded. can you please provide the command you use? thanks!

Hi @futianfan I didn't automatically download a model. I generated them all via:
from DeepPurpose import utils, CompoundPred
from tdc.single_pred import ADME
from tqdm import tqdm

from tdc.utils import retrieve_dataset_names
adme_datasets = retrieve_dataset_names('ADME')
bad= ['bbb_martins']
adme_datasets = [x for x in adme_datasets if x not in bad]

for dataset_name in tqdm(adme_datasets):
    X, y = ADME(name = dataset_name).get_data(format = 'DeepPurpose')
    drug_encoding = 'Morgan'
    train, val, test = utils.data_process(X_drug = X,
                                      y = y,
                                      drug_encoding = drug_encoding,
                                      random_seed = 2)
    config = utils.generate_config(drug_encoding = drug_encoding,
                         train_epoch = 20,
                         LR = 0.001,
                         batch_size = 128,
                         mpnn_hidden_size = 32
                        )
    model = CompoundPred.model_initialize(**config)
    model.train(train, val, test)
    model.save_model('adme_models/' + dataset_name + '_model')

The models I listed above were all generated using the above script. I'd like to now (for example) load the caco2 model I generated, load some new SMILES patterns, and make predictions. How would I go about doing that?
Also, is there a way to modify the above code so that the model is generated using all of the data? I don't want to automatically lose ~20/30% of the data to get a validation set that I dont need.

Hi, this seems to be an issue for DeepPurpose, instead of TDC. TDC has no support for loading the pretrained model. For DeepPurpose, you can load a pretrained model via
net = CompoundPred.model_pretrained('./cyp1a2_veith_model')

You can also specify the fraction of train/valid/test via specifying frac=[0.9,0.0,0.1] in data_process function. if you want no test set at all, do split_method  = 'no_split' in the data_process function


System Admninistration >> Security Groups broken

produces runtime error

Commented out the following line at line 83 in Controllers/AdministrationController.cs
[Microsoft.AspNetCore.Authorization.Authorize(Roles = "SystemAdministrators")]

In Program.cs, changed builder.Services.AddAuthentication() to:
builder.Services.AddAuthentication(CookieAuthenticationDefaults.AuthenticationScheme)
.AddCookie(o => o.LoginPath = new PathString("/account/signin"));
Uncommented previous code.

C


adminservice 和configserver绑定公网ip后无法使用

You may check the system information page for more information.

@nobodyiam check success

apollo-portal log

You need to also check the admin service logs.


Bump Studio Pro's .NET version requirement to 6.0.0

As this is now the minimum required version starting with Mendix 9.11.0.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Joeri Hendriks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Change of visibility for InternalBody of region entity

Changed the visibility for InternalBody from internal to public to allow LINQ queries to be performed on the serialized region body. This is referenced in issue #365 .

Hi there! Back from vaccation :) Do you think you could send a new pull request for this to the 2.2.5 branch which is the next version to be released! If it's not possible I can fix it manually on my end!
Regards
/Håkan

Yes, I will fix it when I have time, i.e. tonight or tomorrow.


[TW#18951] WIFI readme possibly misleading

In the section https://github.com/espressif/esp-idf/blob/master/docs/api-guides/wifi.rst#system_event_sta_disconnected the sentence in bold states that the application sockets must be re-created when the SYSTEM_EVENT_STA_DISCONNECTED event is received.
In the second last paragraph of this section it is stated that the application (socket operations?) should only be restarted on the SYSTEM_EVENT_STA_CONNECTED event.
Surely this is incorrect since sockets can only be recreated once the L3 IP connectivity has been restored, event SYSTEM_EVENT_STA_GOT_IP.
Or has improvements been made to the lower level (L1 & L2) code such that the L3 & L4 structures have not been torn down in case of a short L2 disconnect ?
EDIT: Unless I am wrong and the events do not correlate to activities on specific layers?

HI @ammaree you are right, it's mis-leading. Since IDFv3.0/lastest IDF, it's not a must that the applications close the sockets when SYSTEM_EVENT_STA_DISCONNECTED happens and recreate it on receiving SYSTEM_EVENT_STA_CONNECTED, the application can close the socket when SYSTEM_EVENT_STA_LOST_IP and recreate it on receiving SYSTEM_EVENT_STA_GOT_IP.
We will amend the description in IDFv3.1.

Hi @liuzfesp
Tried your suggestion but it does not work.
The device never sees a SYSTEM_EVENT_STA_LOST_IP event, only ..
SYSTEM_EVENT_STA_DISCONNECTED -> SYSTEM_EVENT_STA_CONNECTED -> SYSTEM_EVENT_GOT_IP
Closing sockets in SYSTEM_EVENT_STA_LOST_IP does not work since the event does not occur, hence we get a string of fatal errors when we try to re-open the sockets on event SYSTEM_EVENT_STA_GOT_IP.
What are we missing ?

Hi @liuzfesp
Do you have any suggestions for why we do not see the SYSTEM_EVENT_STA_LOST_IP  event?
We have moved out code handling the closing of sockets back to SYSTEM_EVENT_STA_DISCONNECTED as a temporary measure, but not an ideal or correct solution.
Andre

Hi @ammaree, the  SYSTEM_EVENT_STA_LOST_IP will be raised after CONFIG_IP_LOST_TIMER_INTERVAL seconds if the WiFi is disconnected from the AP, or if the DHCP failed to rebind/renew the IP address. The default value of CONFIG_IP_LOST_TIMER_INTERVAL is 120s, in your example, if the WiFi is disconnected for more than 120s, the event will be raised; on the other hand, if the IP is re-got within 120s, no SYSTEM_EVENT_STA_LOST_IP.


Deprecate CUDA 11.6 from CI, move to 11.7

Remove cuda 11.6 from CI replace with 11.7
Following the Release readme here: https://github.com/pytorch/pytorch/blob/master/RELEASE.md#release-compatibility-matrix

Validated all the failures are pre existing


test-branch/execute-job/wrong-commit-sha-on-pr/6fa0ecc7-5e4e-4a66-b603-afb4edd8262f

PR for testing 28a2854d51416d27a45db4de71ee50d0f3054854

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


cannot import prsaw

Hi, i have installed prsaw via the cmd but when i open my project in visual studio, it does not recognize prsaw as you can see on the picture below?


Bug_NativeSelect > Inverse /Has Error Inverse /Helper Message Inverse > Dropdown options are not visible until the user hovers the mouse on it.

Describe the bug:
Dropdown options are not visible as the options are appearing in white colour.
To Reproduce:
Steps to reproduce the behavior:

Go to 'https://storybook-preview-dev--upbeat-sinoussi-f675aa.netlify.app/iframe.html?id=nativeselect--inverse&args=&viewMode=story'
Launch the dropdown menu.
Observe that dropdown options are not visible until the user hovers the mouse on it.

Expected behavior:
Dropdown options should appear appropriately.
Screenrecording:
https://somup.com/c3iqIqu3po
Desktop:
OS: [Win 10],Browser [chrome][Version 98.0.4758.82 (Official Build) (64-bit)]
OS: [Mac 12], Browser [Safari][Version 15.2]

The issue is fixed.
See screen-cast : http://somup.com/c3iYf8u0kQ
Thanks!

@Uditsingh67 The issue was with NativeSelect and not Select. Do you mind re-verifying this? https://storybook-preview-dev--upbeat-sinoussi-f675aa.netlify.app/?path=/story/nativeselect--inverse

The issue is fixed.
See screen-cast : http://somup.com/c3irfauT6M
Thanks!


Update trezor-agent guide

Updates the trezor-agent guide with Info on using the trezor-agent to SSH over Tor
What
The v3 guide added optionality to SSH to your node over Tor. This pull request shows how to use trezor-agent as part of this process
Why

Relatively easy way to securely SSH to your machine over Tor from any machine that supports Tor.

Even if the SSH hidden service onion address gets leaked, an attacker won't get access to your pi.

Make it easier to secure the SSH keys

How
Updated trezor-agent bonus guide
Scope

[ ] significant change to core configuration
[ ] independent bonus guide
[x] simple bug fix

Fixes # (link issue)
Test & maintenance
Testing:

Follow the guide and attempt SSH through trezor, does it work?

I only have access to Trezor HW-wallet, would be nice if someone with ledger/keepkey/onlykey checked

I'm willing to maintain the guide

Unfortunately, I don't have a Trezor. Is anyone else able to test this?

Would appreciate the feedback - and improvement suggestions.
From my experience the tor method of connecting works ~90% of the time, when it doesn't disconnecting the trezor and trying again usually solves the problem

We an't find any tester for this PR.. What shall we do? merge it as is..? LGTM.

@DanielPX1,
It does

@DanielPX1, It does

aight, can test that later. Should have time this week


libc: Conditionally compile float support in printf

Libs doing float computations take a lot of text space,
so it shouldn't be compiled by default.

Test this please


fix(article): remove dynamic image path replacement, update static data

On top of #64.
This PR is for @javamind.
It removes the dynamic image path replacement done at runtime by a simple static data update.

It would have been nice to have a review from @javamind: he's a one who knows what's going on.


parallel=True incompatible with caching and AOT compilation

As part of the gufunc rewrite, we should investigate how to allow ParallelAccelerator functions to be cached.  (This will likely also solve the problems with ahead of time compilation.)

@sklam We didn't do this as part of gufunc rewrite but isn't caching working with parellel=True now?  Can close this?

Yes, caching does seem to work:
 💣 zsh» ls __pycache__
issue2712.prange_test-5.py38.1.nbc  issue2712.prange_test-5.py38.nbi

I'll close this now, as I believe it has been resolved. If this is not the case, please feel free to re-open the issue. Thanks!


Previous breakpoint

Pull Request Test Coverage Report for Build 24

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 19:
0.0%

Covered Lines:
26

Relevant Lines:
26

💛  - Coveralls


Freezing on startup

Indium is making the game freeze when the game is trying to reload ResourceManager
Happens with both the newest release of Sodium and Iris from Modrinth
Log file: https://paste.ee/p/tW5UA (Indium + Iris, it also includes my laptop specs if it matters, Indium + Sodium would freeze at that stage also)

Are you sure the freeze does not occur when Indium is not present? I don't think Indium would cause this.

Did more testing. Figured out that the issue was on my end, sorry for wasting anyone's time with this issue. Closing.


Native resource handles + command buffer

The Babylon Native half of this change is here: https://github.com/BabylonJS/BabylonNative/pull/873
Engine related resources created by Babylon Native (such as textures, vertex arrays, index buffers, etc.) are all treated as opaque objects. JavaScript doesn't do anything with them other than store them and pass them back to other Babylon Native functions. With this change, those opaque resources are now assumed to be numeric handles (see the associated Babylon Native changes). Since these handles are numeric, they can now easily be encoded into a "command buffer." The command buffer accumulates commands over the course of a single scene.render call, and then "submits" the command buffer to native at the end. For more complex scenes, this reduces the number of calls into native from thousands to just one. Additionally, since the command arguments are just read as numeric values out of typed arrays, the cost of retrieving args on the native side is pretty much eliminated. When profiling the JavaScript with Safari on iOS (for a scenario where I have a single mesh with ~250 submeshes), it claims that ~65% of CPU time is spent making those native calls. After this change, it claims 0.4% of CPU time is spent making those native calls. That said, with the profiler not attached, this change does not triple the frame rate (as the previous numbers might suggest), but does increase frame rate by about 50% which is still substantial.
There is a bunch of work to do to finish this change:

[ ] Convert a bunch more functions to use the command buffer (not everything, but probably all functions that set state or delete resources (creating resources needs to continue to be synchronous, or the numeric resource handles need to be generated on the JS side and passed to the native side)).
[ ] The command and argument buffers are just a fixed size that was big enough for my test scene. The buffers need to grow as needed, and we need a heuristic for shrinking them as well (e.g. at the end of a scene render, after calling submitCommandBuffer, maybe call a resizeCommandBuffers function that shrinks them down to the size needed for the last submit, or maybe the max of the last five submits, or something like that).
[ ] Delete shader programs at the right time (maybe from _releaseEffect). Probably need input from @bghgary on this.
[ ] We may want to have some kind of command buffer validation. The command and command arg encoding and decoding must happen in the same order or things will be totally broken, and this is hard to diagnose. Command validation could do something like record the order of encoding operations in another buffer (a validation buffer) which the native side could use to ensure decoding happens in the same order. We'd want this to be an explicit opt-in from JS, like a call to nativeEngine.enableCommandBufferValidation() that perhaps would replace the command buffer encoding functions to do extra work (so there is no overhead when not doing validation) and pass the validation buffer to native so it has it and knows to do the extra validation work.
[ ] Remove all the commented out code (left there to make testing the old code path easy).
[ ] Merge master.

@Popov72 @RaananW Thank you for the context, I was just trying to get the observables to behave how I expected with stereo rendering and didn't spend enough time looking into the expected behavior engine-wide. I'm going to back out the change for this PR and find another way of approximating what we're trying to achieve for the command buffer scope without causing any breaking changes, since it seems the implications of the observables changes lie out of the scope of this already massive PR-- although I do think it's an important topic of discussion that I'd be happy to open in another PR.


Clarifying readDecodedResponse and writeDecodedRequest

Type of change

Enhancement / new feature

Description
I was loosing the filter chains themselves between the ternary operators. So I wanted to try and make the chain more explicit.
Additional Context
I think this PR is very much my twist on things so I'm not going to be offended if you don't want to include this.
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

Good improvement, thank you. I've cherry picked your change to the PR.