Prebuilt wheels

How about prebuilt wheels for PCs without OpenJDK and/or VisualStudio?

On 09/19/2017 02:03 PM, KOLANICH wrote:

How about precompiled wheels for PCs without OpenJDK and/or VisualStudio?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/originell/jpype/issues/261, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKZL6myToD60Dw6M59auQ3aK6Keqd_uks5sj618gaJpZM4PcSQe.

currently this is not planed, because one needs a sophisticated build
system to do so. We provide conda binaries for Windows/Linux/OSX.

I don't understand how does this prevent you from spreading prebuilt wheels. Are this wheels valid only for the computer they are built are?

The problem with prebuilt binaries is that you need compatible run-time libraries, this is easy to achieve for C, but hard for C++. Anaconda solves this problem, by shipping the mandatory libs.
If you have a lot of time, we are most happy to accept a PR creating and pushing these binaries (wheels) to PyPI. In the meantime I'm closing this.

The problem with prebuilt binaries is that you need compatible run-time libraries, this is easy to achieve for C, but hard for C++.

Doesn't using the same compiler solve the problem? I mean Windows builds of python are built with Visual Studio, so the native modules have to be built with VS.

If you have a lot of time, we are most happy to accept a PR creating and pushing these binaries (wheels) to PyPI.

What we need is just to setup Appveyor CI (or maybe GitLab CI using community edition of VS build tools with under Wine).

If we are only talking about windows you are correct, we can solve like
you proposed. Do you have the time to hack this?

Do you have the time to hack this?

No.

https://github.com/paleozogt/MSVCDocker may be useful


[BUG] additionalInterceptors is not iterable

Describe the bug
I'm following the steps here, and after deploying my stack and trying to run awscurl my lambda is failing with:
ERROR	Invoke Error
{
    "errorType": "TypeError",
    "errorMessage": "additionalInterceptors is not iterable",
    "stack": [
        "TypeError: additionalInterceptors is not iterable",
        "    at Runtime.handler (/var/task/index.js:504:42)",
        "    at Runtime.handleOnceNonStreaming (/var/runtime/Runtime.js:74:25)"
    ]
}

All additionalInterceptors references are generated. It is not something I added explicitly in my code.
My lambda implementation:
export const handler = sayHelloHandler(async ({ input }) => {
  return {
    statusCode: 200,
    headers: {
      "Access-Control-Allow-Origin": "*",
      "Access-Control-Allow-Headers": "*",
    },
    body: {
      message: `Hello ${input.requestParameters.name}!`,
    },
  };
});

Expected Behavior
Lambda should not with generated boilerplate code.
Current Behavior
Fail with additionalInterceptors is not iterable
Reproduction Steps

Set up a new npx projen new --from  aws-prototyping-sdk nx-monorepo
Add API and infra

import {
  ClientLanguage,
  DocumentationFormat,
  SmithyApiGatewayTsProject,
} from "@aws-prototyping-sdk/open-api-gateway";
import { nx_monorepo } from "aws-prototyping-sdk";
import { AwsCdkTypeScriptApp } from "projen/lib/awscdk";

const monorepo = new nx_monorepo.NxMonorepoProject({
  defaultReleaseBranch: "main",
  devDeps: ["aws-prototyping-sdk", "@aws-prototyping-sdk/open-api-gateway"],
  name: "project",
});

const api = new SmithyApiGatewayTsProject({
  clientLanguages: [ClientLanguage.TYPESCRIPT],
  defaultReleaseBranch: "main",
  documentationFormats: [DocumentationFormat.HTML2],
  name: "api",
  parent: monorepo,
  outdir: "packages/api",
  serviceName: {
    namespace: "com.project",
    serviceName: "ApiService",
  },
});

new AwsCdkTypeScriptApp({
  defaultReleaseBranch: "main",
  parent: monorepo,
  outdir: "packages/infra",
  name: "infra",
  cdkVersion: "2.1.0",
  deps: [api.package.packageName],
});

monorepo.synth();

Update infra to include SampleApi

new SampleApi(this, "sample-api");

awscurl awscurl --service execute-api --region us-east-1  https://[ID].execute-api.us-east-1.amazonaws.com/prod/hello\?name\=boooo

Possible Solution
No response
Additional Information/Context
No response
PDK version used
0.12.33
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
macOS Monterey Version 12.5

Good catch! With the recent handler router change it seems I broke the standalone handler wrappers. Looks like since the lambda handler is called with (event, context, callback), the default value for additionalInterceptors is not being used!
I'll publish a PR to fix this ASAP!
In the mean time, feel free to either downgrade to 0.12.24, or make use of the handlerRouter (docs here) instead.

@cogwirrel thank you for the quick reply.

or make use of the handlerRouter (docs here) instead.

that worked.

The fix is available in 0.12.34 - let me know if you have any other issues! :)

Hi @cogwirrel
Thanks for the quick fix. I want to replace the handlerRouter with your fix. How would you update .projenrc.ts to use 0.12.34?
My .projenrc.ts
import {
  ClientLanguage,
  DocumentationFormat,
  SmithyApiGatewayTsProject,
} from "@aws-prototyping-sdk/open-api-gateway";
import { nx_monorepo } from "aws-prototyping-sdk";
import { AwsCdkTypeScriptApp } from "projen/lib/awscdk";

const monorepo = new nx_monorepo.NxMonorepoProject({
  defaultReleaseBranch: "main",
  devDeps: ["aws-prototyping-sdk", "@aws-prototyping-sdk/open-api-gateway"],
  name: "project",
});

const api = new SmithyApiGatewayTsProject({
  clientLanguages: [ClientLanguage.TYPESCRIPT],
  defaultReleaseBranch: "main",
  documentationFormats: [DocumentationFormat.HTML2],
  name: "api",
  parent: monorepo,
  outdir: "packages/api",
  serviceName: {
    namespace: "com.project",
    serviceName: "ApiService",
  },
});

new AwsCdkTypeScriptApp({
  defaultReleaseBranch: "main",
  parent: monorepo,
  outdir: "packages/infra",
  name: "infra",
  cdkVersion: "2.1.0",
  deps: [api.package.packageName],
});

monorepo.synth();

Hey @phstc
No worries! There are a couple of different options - you could either specify the version in your .projenrc.ts, eg:
devDeps<EMAIL_ADDRESS>"<EMAIL_ADDRESS>
Or, you can update the package.json files (either manually or with a tool like npm-check-updates) as projen won't change the versions in the package.json when they're not specified in your .projenrc.ts.
Hope that helps!
Cheers,
Jack


Ruby 3.0 breaks on use usage

We have the following (pseudo) code
module BaseHelper
  extend Grape::API::Helpers

  params :type do |type:|
    type = type.to_s
    requires :type,
             type: String,
             values: { value: [type], message: "must have the value `#{type}`" }
  end
end

class API < Grape::API
  helpers BaseHelper

  desc 'Missing keyword error'
  params do
    use :type, type: :api
  end
  get 'error' do
    'This throws a missing keyword error in Ruby 3.0'
  end
end

When upgrading from ruby 2.7.5 to 3.0.3 the use :type, type: :api line leads to the following error:
`block in <module:BaseHelper>': missing keyword: :type (ArgumentError)

I created a repo which shows this error: https://github.com/mobilutz/grape-ruby3
With ruby 2.7.5 the error is not thrown and we are using the code successfully on production.
As far as I know, there are some ArgumentError raised in 3.0.3 but the ones I found do not correlate to the implementation detail here:
https://www.fastruby.io/blog/ruby/upgrades/upgrade-ruby-from-2.7-to-3.0.html#language-changes
Is there something else needed to debug this?

it looks like we need "double splat" for options here.

Thanks @dm1try for the quick fix.
I stumbled over the missing ** this morning as well, but you have been faster 😉


Alternative GNU Sed Location

Changes

Allowing users to export SED_BIN environment variable, so macOS users can use gsed instead
Updating ko usage example (ko auth login)

Plus, a few other minor  #changes.
Submitter Checklist

[x] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

Release Notes
NONE

/assign @adambkaplan

/approve


phpExtensions.memprof: init at 3.0.2

Description of changes
This PR adds memprof PHP extension: https://github.com/arnaud-lb/php-memory-profiler
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build phpExtensions.memprof


nvidia dataset image resolution

Hey author,
What's the image resolution you used for nvidia dataset experiment in the paper? Is it 2x or 1x?
Thanks for clarification!

nvm I saw a downscale_factor=2 in the config file

Great! Thanks for the explanation


Sort and Print Boundary Elements of 2D Matrix

Program to sort and print the boundary/border elements of a 2-Dimensional Matrix.
The dimensions of the matrix are taken from the user as inputs.
Issue Id you have worked upon -
#212
Briefly explain your program logic -
The idea is to store the boundary elements of input matrix in array. The next stop is to sort the array. Finally, print the new matrix using the sorted array as the boundary elements.
Screenshots(Attach 2 screenshots of your own input and output) -

Checklist:
Eg - If your code follow the below guidelines. Kindly change [] to [x]
All the conditions should be fulfilled for considering your code for merging -
[x] I have mentioned the question as comment in my solution file.
[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code.
[x] My code gives the correct output.
x[] I confirm that I have not copied the code from anywhere. In case its found that I have copied I can be banned from the repository.
[x] I affirm that I strictly follow contributing guidelines and code of conduct.

Unable to get the select menu to select the issue id while entering the PR template.


Logging both request and response in a single line

Hi,
I tried a custom solution to log both request and response in the same log statement. Not sure if this is the right way to go about it. See attached code and please advise. I am using Spring-Boot with maven.
Thanks
Chandra
//Implementation of custom Sink class
import java.io.IOException;
import org.json.JSONObject;
import org.zalando.logbook.Correlation;
import org.zalando.logbook.HttpLogFormatter;
import org.zalando.logbook.HttpLogWriter;
import org.zalando.logbook.HttpRequest;
import org.zalando.logbook.HttpResponse;
import org.zalando.logbook.Precorrelation;
import org.zalando.logbook.Sink;
import lombok.AllArgsConstructor;
@AllArgsConstructor
public class LogRequestAndResponseTogetherSink implements Sink {
private final HttpLogFormatter formatter;
private final HttpLogWriter writer;
@Override
public boolean isActive() {
    return writer.isActive();
}

@Override
public void write(final Precorrelation precorrelation, final HttpRequest request) throws IOException {
    //writer.write(precorrelation, formatter.format(precorrelation, request));
}

@Override
public void write(final Correlation correlation, final HttpRequest request, final HttpResponse response)
        throws IOException {
    //writer.write(correlation, formatter.format(correlation, response));
	String requestMessage = formatter.format(correlation, request);
	JSONObject reqJson = new JSONObject(requestMessage);
	String responseMessage = formatter.format(correlation, response);
	JSONObject respJson = new JSONObject(responseMessage);

	JSONObject combinedReqResp = new JSONObject();
	combinedReqResp.put("requestMessage", reqJson);
	combinedReqResp.put("responseMessage", respJson);
	writer.write(correlation,  combinedReqResp.toString());
}

}
//bean configuration
@Bean
public Sink logRequestResponse() {
return new LogRequestAndResponseTogetherSink(
new JsonHttpLogFormatter(),
new DefaultHttpLogWriter());
}

@chaninja what is your motivation for doing that?

I want to have both request and response captured in a single log. So we can monitor/search and analyze api endpoints for various parameters like duration, failure rate, etc,
Chandra

From: Thomas Skjølberg @.>
Sent: Saturday, September 25, 2021 1:58 AM
To: zalando/logbook @.>
Cc: chaninja @.>; Mention @.>
Subject: Re: [zalando/logbook] Logging both request and response in a single line (#1170)
@chaninjahttps://github.com/chaninja what is your motivation for doing that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/zalando/logbook/issues/1170#issuecomment-926993540, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANSJ3JS3FVKKSOFZMNZ3XTUDUUETANCNFSM5EUOFTBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Ok, that is normally done by adding ids to the request/response statements, not by outputting them together on a single line, you'll not be happy with the results of that because you normally want some log statements inbetween request and response.
Did you see the correlation?

@chaninja The answer that @skjolber gave is what I'd suggest as well. Correlation IDs within both the request and the response log lines is the way that should work for most users and give you the best of everything:

Requests are logged as soon as they arrive
Requests and responses can be correlated

If you're willing to accept the following consequences, there is a way to do it cleanly:

Requests are logged only when a response is logged (might be out of order with your normal application logging)
Requires more manual coding (see below)
Correlation is easier to do

Steps you should be looking into to log both requests and responses on the same line:

Custom strategy
Implement a custom Strategy that calls Sink#writeBoth instead of Sink#write.
You might get away with using one of the existing Strategy implementations and configure them in a way that makes them behave like that (e.g. StatusAtLeastStrategy with a minimum status of 0).
Custom Sink
Implement a custom Sink that formats both the request and response in whatever format you want to combine them before handing them over to the Logger or HttpLogWriter.
You might be able to re-use the existing formatters and writers and use them a bit differently, like produce two JSON bodies and hand-craft the enclosing document by hand. Or you use full custom formatters that produce data structures (maps).


Auto-add $ANS if OmniBox empty and operator like +, -, /, *, etc entered

TI calculators do this. E.g.,
Enter something like
2 + 3 = 5
then Enter, then when the Box is blank, hit the / key and input becomes
"$ANS / "
Or at least, a toggle for this somewhere

this already works, it just doesn't show the $ANS in the entry

My bad. You can delete this issue

This has been added to my documentation list, though

I'm going to make it add $ANS to the history when $ANS is implied


Ecto.Query! with ARRAY_AGG returning random string

Environment

Elixir version (elixir -v):

Erlang/OTP 21 [erts-10.1.3] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe] [dtrace]
Elixir 1.7.4 (compiled with Erlang/OTP 21)

Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.):
PostgreSQL 10.5
Ecto version (mix deps): 2.2.11
Operating system: macOS Mojave 10.14.1

Current behavior
Repo.query!("SELECT hash, ARRAY_AGG(DISTINCT image_url), page_id, ARRAY_AGG(id) FROM captures WHERE hash IS NOT null GROUP BY hash, page_id HAVING COUNT(1) > 1 AND COUNT(DISTINCT image_url) > 1")

[
  [
    "36184bef2156c61f",
    ["15_d60d90e0-f4a3-11e8-a970-e7d3d5226480.png",
     "9_b9c6cbe0-f4a3-11e8-a970-e7d3d5226480.png"],
    2,
    [15, 9]
  ],
  [
    "695edc8caf53ec1d",
    ["13_ca4e3610-f4a3-11e8-a970-e7d3d5226480.png",
     "7_ad04ce20-f4a3-11e8-a970-e7d3d5226480.png"],
    3,
    '\r\a'
  ]
]

Expected behavior
[
  [
    "36184bef2156c61f",
    ["15_d60d90e0-f4a3-11e8-a970-e7d3d5226480.png",
     "9_b9c6cbe0-f4a3-11e8-a970-e7d3d5226480.png"],
    2,
    [15, 9]
  ],
  [
    "695edc8caf53ec1d",
    ["13_ca4e3610-f4a3-11e8-a970-e7d3d5226480.png",
     "7_ad04ce20-f4a3-11e8-a970-e7d3d5226480.png"],
    3,
    [13, 7]
  ]
]

Single quotes in Elixir represent a list of characters. When in doubt, you can put the term on IEx preceeded by an i:
iex(1)> i '\r\a'
Term
  '\r\a'
Data type
  List
Description
  This is a list of integers that is printed as a sequence of characters
  delimited by single quotes because all the integers in it represent valid
  ASCII characters. Conventionally, such lists of integers are referred to
  as "charlists" (more precisely, a charlist is a list of Unicode codepoints,
  and ASCII is a subset of Unicode).
Raw representation
  [13, 7]
Reference modules
  List
Implemented protocols
  IEx.Info, Inspect, String.Chars, List.Chars, Collectable, Enumerable

In other words, it is the list [13, 7], it is just printed between single quotes. :)


Allow for setting Gotenberg environment variables

Hey. Thanks for the Gotenberg chart!
It would be great if it were possible to set Gotenberg environment variables using helm values. I noticed the other charts in this repo allow it but not the Gotenberg one.

Thanks for the quick response. I've tested v3.0.0 of the gotenberg chart using the following values.yaml
gotenberg:
  image:
    tag: 6.2.1
    repository: thecodingmachine/gotenberg
  env:
    open:
      MAXIMUM_WAIT_TIMEOUT: '250.0'
      DISABLE_UNOCONV: 'true'
  resources:
    limits:
      cpu: 2000m
      memory: 2048Mi
    requests:
      cpu: 600m
      memory: 512Mi

Seems to work well for me!

@Kurt108 just in case you hadn't seen my response

thx @timmw


Adding more japanese channels

Hello !

[!NOTE]
This is once again part of the issue Animenosekai/japanterebi-xmltv#1 and the pull request iptv-org/epg#2409

I added a bunch of missing channels which were found on SkyPerfect!

JLC channels [^1]

JLC ch.680
JLC ch.681
JLC ch.682
JLC ch.683
JLC ch.684

Local Horse Racing Nine channels [^2]

Local Horse Racing Nine ch.701
Local Horse Racing Nine ch.702
Local Horse Racing Nine ch.703

Dlife
Music Gaffiti
Phoenix TV JP [^3]
Select Shopping
TSS
Shop Channel
Shop Channel +
SkyPerfect! Promo 599
Speed Channels [^4]

Speed Channel ch.690
Speed Channel ch.691
Speed Channel ch.692
Speed Channel ch.693
Speed Channel ch.694
Speed Plus One (ch.695)

I also updated the ABEMA logos removed and updated the Animal Planet logos.
[^1]: The JLC.jp channel already existed but the different variations all have different programs
[^2]: A LocalHorseRacingNineSELECT.jp channel existed, which refers to channel 775, different from the channels added here.
[^3]: Other versions from other countries already existed, added the Japanese version
[^4]: Some kind of variations of Speed Chanel already existed but didn't match

🎐

Fixed the problems, should be fine now 👍

"package-lock.json" & "yarn.lock", unless necessary for the change, shouldn't be in this PR.

@BellezaEmporium Reverted 👍


Allow blacklisting within a TimeWindow

1: Hello! Thank you for contributing!
2: I believe https://github.com/kickstarter/rack-attack has this functionality as well as much more & I'm on the fence about suggesting people use that instead.
3: If you really love rack-throttle & want this functionality I'd like to know more about the decision to put the safelist above the blocklist. I want to document why in the case of some actor in both of these lists would we want to accept them? :) Thank you!

Closing as stale!


feat: support document as startNodes in browsingContext.locateNodes

https://github.com/w3c/webdriver-bidi/pull/705

WPT to be updated in https://github.com/web-platform-tests/wpt/pull/46345


References not showing above variables in a C# script (Unity project)

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.80.2
OS Version: macOS 13.3

Steps to Reproduce:

Open a C# script from unity

References counts should be visible above all variables, but there is nothing. There is no error. CodeLens is already enabled from settings.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/extC#

It looks like this is caused by the C# extension. Please file the issue to the C# extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!

C# extension repository

This is not causing by extension. All extensions are disabled.

It looks like this is caused by the C# extension. Please file the issue to the C# extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!

This is not causing by extension. All extensions are disabled.

This is not causing by extension. All extensions are disabled.

Then what is going to derive the references?


Best for private repos 😁

Merge if you like it 😁

You know well about these GitHub workflows na 👀

Yes Bhaiya but not more than you 😁


feat: add build args for browser variables

Browser variables are set at build time through NEXT_PUBLIC variables - https://nextjs.org/docs/pages/building-your-application/configuring/environment-variables#bundling-environment-variables-for-the-browser
As the build arguments are currently not exposed in the Dockerfile the only way to set these variables during build is through the .env.local file.
Adding the NEXT_PUBLIC as build arguments in the Dockerfiles makes it possible to use environment variables instead and makes for a flexible solution when building a pipeline.

:tada: This PR is included in version 1.171.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Issue with peer dependencies

Attempting to install while using Vue 3 is giving me trouble, due to the peer dependency requirements for Vue 2. Since Vue 2 is now end of life, you may be able to commit a 'last supported' version and then drop the Vue 2 peer dependencies to resolve this. Here's the error I received:
❯ npm install @vue-youtube/core                                                                                ─╯
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vue
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@hcaptcha/vue3-hcaptcha
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>|| 3.x" from<EMAIL_ADDRESS>npm ERR!   node_modules/@sentry/vue
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   13 more (@tato30/vue-pdf, @vitejs/plugin-vue, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! @vue-youtube/core@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/vue
npm ERR!   peer vue@">= 2.5 < 2.7" from<EMAIL_ADDRESS>npm ERR!   node_modules/@vue/composition-api
npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@vue-youtube/core
npm ERR!       @vue-youtube/core@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/fox/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/fox/.npm/_logs/2024-03-03T17_20_14_015Z-debug-0.log

Ah yeah, I guess it makes sense to drop Vue 2 support then.
I will update this issue when I released a new version without Vue 2 support.

This seems to be related to #14. What Vue version do you use for your project? This plugin currently requires ^3.2.47, but I was considering to slightly lower the minimum required version.

@techassi I'm currently updating to 3.4.21. It's possible that I was using a lower one when filing this issue. I ended up just sticking the standard embed code in for the meantime, which works mostly fine. I can try again soon with the latest version if you like.

I would be happy to hear if it works for you with a version above 3.3.7. Let me know how it goes!

@Techassi It installs with the current version of Vue, 3.4.21, yes.

Alright, good to hear! Can this issue be closed then?


OSBS 2: Improve exception handling

Raise RetryException on build error.
Include Brew task ID and URL in the error message.

/lgtm


Support io_uring for Linux IO

In the current version, we observe a performance degrade on Linux version due to the usage of libaio on async IO handling. It has been a known issue that libaio is not very efficient.
Recently, io_uring is released with Linux kernel 5.1, which advertise to be a high performance aysnc IO library. We should try it and see if we can improve linux version performance by replacing libaio with it.

More details for io_uring can be found here:
http://kernel.dk/io_uring.pdf


Corrected some mistakes

Just fixed some typos present with admin template-extension.

Thanks for this patch, however we try to avoid trivial wording changes unless it's a big problem as it creates extra work for translators.

Sir,
I would contribute towards complete translation of mistakes i changed by
writing a script
Looking forward for more contributions towards django
Thanks to you!
On Tue, Nov 10, 2020, 6:09 PM Mariusz Felisiak<EMAIL_ADDRESS>wrote:

Thanks for this patch, however we try to avoid trivial wording changes
unless it's a big problem as it creates extra work for translators.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/django/django/pull/13662#issuecomment-724676222, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOATQIAIQH364HXWXHK3DCLSPEYAPANCNFSM4TQMFN3Q
.


Don't check when failing to create election proposal.

Is this related to #644? Update the commit message to say something about fixing it, if so?

LGTM


 It's meant to simulate when the device cannot connect to the internet. The Success case is a "success" in that the API returns some data. it's agnostic to the idea that a 404 would be a failure – it succeeded because it returned data.

Fully agree with you. It's quite confusing to see success, when actually there is no relevant data in json.

In general:
Response 3xx says that for the successful execution the request is necessary to take additional action. - it's not an error.
Response 4xx says that the client, making the request, did something wrong. - this is error behaviour.

True, but there are also error conditions in The iOS network stack that we want to simulate. Maybe we should rename these two cases then.

Concerning the endpoint documentation:
I'm working on an iOS application that fetches data from the GitHub API and I've already OAuth authentication.  Originally I was planning on using Alamofire to make the authenticated requests to GitHub, but I've been wanting to use Moya for a while in a larger project.  Anyway, I was going over the documentation on endpoints and I saw the OAuth example but it is not very clear to me how to implement it in an actual application.  Perhaps the Artsy application would be a good place to look?

That's a good idea, @damianesteban. I don't believe we actually use OAuth; we only need to add an HTTP header.
I feel generally that Moya is spreading in a few different directions, and we don't have a set of best practices that demonstrate or implement common practices, like OAuth. I don't think we need to implement MoyaOAuth or anything :grimacing: but some examples of using common libraries would be very useful, too.

So, thanks for the suggestion!

You are welcome.  Yes, I completely agree that Moya doesn't need a separate OAuth component to it :smile: .  I have OAuth up and running with good old NSURLSession and I plan on eventually moving over to Moya once I get the rest of the requests a but more fleshed out.  Thanks!

Awesome! Let us know how it goes!

I definitely will.

It just happened two days ago that one of my colleagues took over a project I implemented a new API class for using Moya and he was completely confused by the fact that an API error (regardless of 4xx or 5xx) was returned within the .Success case. Although I understand and like the fact that Moya only forwards network errors to the .Failure case what about renaming the generic .Success and .Failure cases to something more clear? For example simply adding Network as a prefix resulting to .NetworkSuccess and .NetworkFailure should already improve the clarity a lot. What do you think?

@Dschee it's a good question, and it's one that we've faced before. I'm up for the change, but it would mean abandoning the Result dependency and the nice functions that accompany it like flatMap. It's too bad we can't typealias specific cases of an enum.

Hmm, I understand now why those are named the way they are.
But the good news is that the Result dependency has exactly the same license as Moya does (MIT). :) Therefore what about we create our own fork with only the renamed cases and use that? Should be a straight forward find & replace. And in case we want to update the dependency rebasing shouldn't be hard either. Also if I remember correctly I read about plans for the Swift Package Manager to support dependencies with alterations, so maybe we can even drop maintaining the fork sometime?
Not very happy about the suggestion myself, but that would definitely solve the main problem.

Yeah, we definitely can (I'm on the Result team) but I'm not sure it's a great idea, as you mention. Then again, I don't see any alternatives (I'm not a fan of documenting our way out of this – basically just blaming the user). Let's sleep on it and see if we think of any alternatives?

Sure, no hurry on my side. I think we have two more options: First we could of course try to convince the Swift community that we need support for typealias for enum cases via the Swift evolution mailing list. Second option is we create a wrapper around Result that simply passes through all features we need for Moya from the Result project.
The first option (if it would be successful which we can't be sure of) would delay the support for a better naming until at least September so I think we could also discuss the second alternative. What do you think about a wrapper?

Result seems to be a pattern now, actually Alamofire has its own modified version of Result, see https://github.com/Alamofire/Alamofire/blob/master/Source/Result.swift
So, maybe improving Moya.Error is a better way, to clear what failure is, currently, Moya will wrap all Alamofire's error to Error.Underlying.
Consider that if we add more error types, such as Timeout, Cancelled
provider.request(.UserProfile) { result in
  switch result {
    case let .Success(response):
      doSuccess(response)
    case let .Failure(error):
      switch(error) {
        case .Timeout:
          // tip timeout
        case .Cancelled:
         // tip cancelled
        default:
         // tip unknown
      }
  }
}

does it more make sense?

@jasl Although I like the suggestion about improving the failure case with pre-defined cases that still doesn't solve the issue that API errors (4xx/5xx) are still accessed via something simply called .Success. The confusion therefore wouldn't be reduced with Timeout and Cancelled cases imo.

@Dschee  The definition of Result is Result<Response, Error>, means errors of API's shouldn't be handled, because you've got the response.
But your question is right, we need to handle API errors, for now Moya has provided some functions to help filter the status code, codes here, but that can't be used for pattern-matching. so we could do a small extension
public enum ResponseClass {
    case Informational
    case Success
    case Redirection
    case ClientError
    case ServerError
    case Undefined

    public init(statusCode: Int) {
        switch statusCode {
        case 100 ..< 200:
            self = .Informational
        case 200 ..< 300:
            self = .Success
        case 300 ..< 400:
            self = .Redirection
        case 400 ..< 500:
            self = .ClientError
        case 500 ..< 600:
            self = .ServerError
        default:
            self = .Undefined
        }
    }
}

public extension Response {
    public var responseClass: ResponseClass {
        return ResponseClass(statusCode: self.statusCode)
    }
}

then, we could
provider.request(.UserProfile) { result in
  switch result {
  case let .Success(response):
    switch(response.responseClass) {
    case .Success:
      doSuccess(response)
    case .ClientError:
      // tip user provided data invalid
    default:
      // tip error
    }
  case let .Failure(error):
    switch(error) {
    case .Timeout:
      // tip timeout
    case .Cancelled:
      // tip cancelled
    default:
      // tip unknown
    }
  }
}

@jasl Thanks for adding cases for the success part as well. I continue to think those are great suggestions.
But again, that still doesn't solve the problem that the outer let .Success(response) case is named in a way people may be confused. To repeat the example with my colleague two days ago: I implemented a Moya provider class and he used it. But at the moment he wrote the first outer .Success and .Failure cases he already was convinced that he had handled API errors within the .Failure case and couldn't understand why the .Success case was called but didn't provide any data he was expecting from a successful API response.
To put it in code, here's what I would expect your code to look like:
provider.request(.UserProfile) { result in
  switch result {
  case let .NetworkSuccess(response):
    switch(response.responseClass) {
    case .Success:
      doSuccess(response)
    case .ClientError:
      // tip user provided data invalid
    default:
      // tip error
    }
  case let .NetworkFailure(error):
    switch(error) {
    case .Timeout:
      // tip timeout
    case .Cancelled:
      // tip cancelled
    default:
      // tip unknown
    }
  }
}

There might be a better name than "Success", but having it broken out based on the status code implies knowledge of the server. I've worked with an app (a terrible one), where all responses were "200", and other servers use 404 for empty "array resources".
But, instead of "Success", would "Response" be more appropriate?

On Mar 25, 2016, at 9:48 AM, Cihat Gündüz<EMAIL_ADDRESS>wrote:
It just happened two days ago that one of my colleagues took over a project I implemented a new API class for using Moya and he was completely confused by the fact that an API error (regardless of 4xx or 5xx) was returned within the .Success case. Although I understand and like the fact that Moya only forwards network errors to the .Failure case what about renaming the generic .Success and .Failure cases to something more clear? For example simply adding Network as a prefix resulting to .NetworkSuccess and .NetworkFailure should already improve the clarity a lot. What do you think?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

"Response" sounds appropriate. I don't want to impose semantics on top of Alamofire, so maybe have Response and Incomplete?

@Dschee your issue I also meet too, but I think there is two parts, one is the codes that I just provided is the right way (at least for me), the other part is this really make some people confusing.
In my opinion, there are too many kinds of errors could be occured, but we don't need to handle those one per one, let's regrouping them (remember, this relies on your business and the restful-api design)
enum APIResult {
    case Ok // the request with success but no content (e.g. status code 204)
    case Success(NSData) // success with content
    case Failure(APIError) // the request success but with 4xx, 5xx status
    case NetworkError(Moya.Error) // the request is failure
}

then I wrapped Moya's provider (just for demo)
func request(provider: Provider = Provider.defaultInstance(), completion: (result: APIResult) -> ()) -> Moya.Cancellable {
        return provider.request(self) { result in
            var apiResult: APIResult

            switch result {
            case let .Success(response):
                let json = response.mapSwiftyJSON()

                if json["ok"].int != nil {
                    apiResult = .Ok
                } else if let errorMessage = json["error"].string {
                    apiResult = .Failure(APIError(statusCode: response.statusCode, message: errorMessage))
                } else if let entity = parseResponse(json) {
                    apiResult = .Success(entity)
                } else {
                    apiResult = .Ok
                }
            case let .Failure(error):
                apiResult = .NetworkError(error)
            }

            completion(result: apiResult)
        }
    }

so my colleagues could use like
request(.UserProfile) { result in
  switch result {
  case .Ok:
  case let .Success(data):
  case let .Failure(error):
  case let .NetworkError(error):
  }
}

you could see my project for learning https://github.com/jasl/RubyChinaAPP/blob/master/RubyChinaApp/Controllers/Topics/TopicsViewController.swift#L127 (It's for Ruby Community of China, and the repo may not be passed to compiling because I using my forked Moya, but you could see how I wrapping Moya's Provider)
In my opinion, I don't like a library to do too much, if you think it's too complex to use, you can wrap it, that should be easy, but a library do too much, if there are some not suit for your needs, hack it would be hard. I think Moya is a balance choice,

Since there hasn't been any activity on this thread for some time, I am going to go ahead and close it. Please re-open or create a new issue if you would like to discuss further. Thanks.


Never-resolved spinners in "Your Farm Overview"

chia-blockchain-gui 041ac79be4af360d856a6527a4b8f4a074415a9a
The GUI is waiting for the following fields to be resolved, but they are never resolved:

XCH Total Chia Farmed
XCH Block Rewards
XCH User Transaction Fees
Last Height Farmed

Looking into it

chia-blockchain-gui 041ac79
The GUI is waiting for the following fields to be resolved, but they are never resolved:

XCH Total Chia Farmed
XCH Block Rewards
XCH User Transaction Fees
Last Height Farmed

Do you have any mode detailed information like logs?

Do you have any more detailed information like logs?

There are no warning messages in ~/.chia/mainnet/log/debug.log and no messages in gui's console.

Do you have any more detailed information like logs?

There are no warning messages in ~/.chia/mainnet/log/debug.log and no messages in gui's console.

i was able to reproduce it

thanks!

@atomsymbol I just did a lot of patching and bug fixes for the gui. I would just run the gui on latest for now until i have a chance to fix the api requests

did branch removed get_farmed_amount routing in get_wallet_balance

add it back should be fine

Ya I'm working on it but I'm waiting for my current pull to get submitted

Adding to the ticket : experiencing same problem, spinners never resolve. chia version : 1.2.6.dev33.
Thanks

Adding to the ticket : experiencing same problem, spinners never resolve. chia version : 1.2.6.dev33.
Thanks

we know exactly what the issue is but it isnt going to be fixed until 1.2.7

Adding to the ticket : experiencing same problem, spinners never resolve. chia version : 1.2.6.dev33.
Thanks

just use latest for now

we have a bunch of changes coming so we are just focusing on those for now

That's fine. No rush here.

Loading on the farm page is fixed via https://github.com/Chia-Network/chia-blockchain-gui/pull/547

Merged, I am closing this issue


deps: alpine 3.19.1

I also updated the description, but re-tagging the image will only update the alpine layer as latest JRE is the same build as before.

@reta hmm odd.. I wonder if there's an non-determinism issue in the package selection, as you can see 21.0.1 in the breaks part despite the ultimate expression used being ~openjdk21-jdk-21.0.2_p13 and ~openjdk21-jmods-21.0.2_p13 (where the tilde says get this prefix, which we need because it reduces maintenance when there's a package re-do)
 0.943 ERROR: unable to select packages:
0.945   openjdk21-jmods-21.0.2_p13-r2:
0.945     breaks: world[openjdk21-jmods~21.0.1_p12]
0.945     satisfies: openjdk21-jdk-21.0.2_p13-r2[openjdk21-jmods]
0.945   openjdk21-jdk-21.0.2_p13-r2:
0.945     breaks: world[openjdk21-jdk~21.0.1_p12]

I think we don't need to separately add the jmods things, because it is already a dependency of the jdk
https://pkgs.alpinelinux.org/package/edge/community/x86_64/openjdk21-jdk Maybe this will reduce the issue

can someone with intel machine, run from this branch ./build-bin/test 21.0.2_p13? from my macbook zero issues, but obviously something is happening here on x86, and not sure if there's some change in the runner or if something else is at play

@reta hmm odd.. I wonder if there's an non-determinism issue in the package selection, as you can see 21.0.1 in the breaks part despite the ultimate expression used being ~openjdk21-jdk-21.0.2_p13 and ~openjdk21-jmods-21.0.2_p13 (where the tilde says get this prefix, which we need because it reduces maintenance when there's a package re-do)

Yeah, it confused (and derailed) me as well, not sure what is happening

I think it is repository order, since openjdk is now not only in edge/community.. will do a quick change to verify, then maybe update the base layer

can someone with an x86 machine, run from this branch ./build-bin/test 21.0.2_p13? from my macbook zero issues, but obviously something is happening here on x86, and not sure if there's some change in the runner or if something else is at play

No issues on Linux with  ./build-bin/test 21.0.2_p13 for me

lol force-broken-world just doesn't do anything

so this isn't about 3.19.1 as same error reverting to 3.19.0... there's something funny and I don't think it is the mirror as I already switched that. Maybe something changed in the runner 🤷

ok it had to do with the github workflow run. basically it ran install twice, once with a slightly older patch and then again with the current one. I guess the change in build-args isn't tainting the layers?

ok good to go. sorry about the thrash, I forgot build-arg cache invalidation behavior


Limit AdditionalSignContent device_type choices

Limit device_type choices to TrafficControlDeviceType instances to
instances that have target_model set to AdditionalSign
Refs LIIK-163

Codecov Report

Merging #114 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   97.06%   97.07%
=======================================
  Files          97       97
  Lines        5968     5986   +18
  Branches      237      237
=======================================
+ Hits         5793     5811   +18
  Misses        157      157
  Partials       18       18

Impacted Files
Coverage Δ

traffic_control/models/additional_sign.py
100.00% <ø> (ø)

traffic_control/models/common.py
99.47% <ø> (ø)

traffic_control/serializers.py
100.00% <100.00%> (ø)

...l/tests/models/test_traffic_control_device_type.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6016358...6f17982. Read the comment docs.


setVolume sets the wrong value that is passed

Hello! I can't set the volume I want. I need it to be accurate, it's very important, but neither setVolume nor lowerVolume sets values like 0.1 or 0.2 etc. the value is always long and wrong.
Even if I manually set the volume to exactly 100%, to the end, then any method makes the volume not correct.
await FlutterVolumeController.setVolume(0.1);
print(await FlutterVolumeController.getVolume()); // Result is 0.09803921729326248
await FlutterVolumeController.setVolume(0.2);
print(await FlutterVolumeController.getVolume()); // Result is 0.19607843458652496

Hi, may I ask in what platform you face this issue?

Hi, may I ask in what platform you face this issue?

Oh sorry.
Platform - Windows (tested only on win 11)

[√] Flutter (Channel stable, 3.3.9, on Microsoft Windows [Version 10.0.22000.1281], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Build Tools 2019 16.11.17)
[√] Android Studio (version 2021.3)
[√] VS Code (version 1.74.0)
[√] Connected device (4 available)
[√] HTTP Host Availability

in 1.2.1+1 issue is fixed. Thank you 😊

I still find some issues on volume floating point precision, I will fix them on upcoming releases.

I still find some issues on volume floating point precision, I will fix them on upcoming releases.

Yes, I saw there is a small error, but it is no longer critical (at least for me). Of course, if you can fix it and make it 100% accurate, then I will be glad. Thank you very much


fix(nearest): target that matches the scrolling frame height should scroll

Fixes #432

:tada: This PR is included in version 2.2.19 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support keyword arguments in rez python

Fixes #492.
@bpabel You were right there wasn't a lot missing to get this to work.
I added some more docstrings and tests as well.

I am closing this as I've addressed it another way in https://github.com/nerdvegas/rez/pull/523
I've updated subcommands so they can parse cli args differently where necessary. This comes with some advantages:

commands like rez-python now support passing args directly through to underlying proc (python in this case);
other commands (eg rez-config) no longer accept rez-env-style arg groupings, ala "rez-env pkg1 -- command -- other stuff". They only did before as a matter of convenience, and these extra args were ignored.


In README.md the URL for IDEA research is linked to Meta AI

https://github.com/IDEA-Research/Grounded-SAM-2/blob/de62b7fb0bda7700e66dfeae8eb85deeca86545a/README.md?plain=1#L3
Hello, just realized the affiliation``IDEA research'' in README.md is linked to Meta (https://ai.meta.com/research/).
Are these two institutions actually related or is it a mistake?

Sorry, this is our typo, we will fix it later.


User data not saved into ForceUser.json

Build: 0.3.9
Problems happens when Force save or load user data, it actually saved in as empty file, so when user runs Force again it requires to open project, and not that was previously closed (if user set this as option in Preferences).

Fixed 27.11.22 (1:40).


Dropped recordset BLOB hash column in recordset table

Changes in this pull request:

Dropped recordset BLOB data_hash column in recordset table, as its no longer use.

This is a potentially breaking change. Anyone that has run v10.5 or higher may have a data_hash column in their recordset table.
If this causes problems, workarounds include:

Update the column to make it nullableALTER TABLE recordset
    MODIFY data_hash varchar(40) NULL;

OR, delete the column outrightDROP INDEX data_hash_index ON recordset;

ALTER TABLE recordset
    DROP COLUMN data_hash;


Tugboat CLI -> Review Commands

Add a section about viewing logs
Create links to this section from Troubleshooting page

Added sections to CLI page about viewing Preview logs and Services logs, and then added links to these items from the Troubleshooting -> How to view logs section. Pushed the changes to new-docs.


Use ec_group_do_inverse_ord() in SM2

This PR build on top of #6116 :

d6db841580 moves the ec_group_do_inverse_ord() declaration from crypto/ec/ec_lcl.h to a newly created crypto/include/internal/ec_int.h. The new header is meant to include private but inter-submodule accessible functions: up until now the SM2 submodule was using only public function from the EC submodule.
313e72e39a updates the SM2 implementation to use ec_group_do_inverse_ord() instead of BN_mod_inverse(), mitigating a SCA leakage.

It's 1.1.1 only.
TODOs:

[x] reshape commit AuthorDates so github history is coherent with git commit history
[x] gather feedback on the new commits
[x] add documentation for ec_group_do_inverse_ord() in crypto/include/internal/ec_int.h
[x] decide on documentation text: https://github.com/openssl/openssl/pull/6521#discussion_r197213329
[x] rebase once #6116 is merged
[x] rebase on master to fix some [-Wstrict-prototype] warnings
[x] remove "WIP:" prefix for proper review

Ping to @mattcaswell and @bbbrumley

I just rebased on the latest #6116 developments and added a new commit (2a6bdb3) which moves the ec_group_do_inverse_ord() declaration from crypto/ec/ec_lcl.h to a newly created crypto/include/internal/ec_int.h. The new header is meant to include private but inter-submodule accessible functions.
I then rebased the old commit that was including crypto/ec/ec_lcl.h breaking submodule separation, to instead include the new inter-submodule header.
As a side-note: In my mind these 2 commits shouldn't be squashed together before merging.
@mattcaswell @dot-asm would you care to provide more feedback?

does the new header look good to you?
does it need extra (#ifndef/#define) guards?
are there conventions I am unaware of for naming these guards?
does this fix your previous concern(s)?
is the build system tracking header files too? should the new internal header be listed somewhere?

Added documentation for ec_group_do_inverse_ord() in crypto/include/internal/ec_int.h.

Rebasing this now that #6116 is merged.

About lifting the WIP, I'd like to finalize the documentation on the header before that::we might possibly need to discuss if the "contract" I wrote is too restrictive considering existing implementations and cornercase applications, and decide how to address that.

@mattcaswell @dot-asm @richsalz I have lifted the WIP, it should be now ready for proper review.
@bbbrumley could you once again comment on the current text for the documentation?

Merged. Thanks!


Latest version not published to NPM yet

The current version on NPM is v3.3.0 which is the same as the version on Github but the code is not the same, the changes done to the transform are not available on the NPM version

https://github.com/taskrabbit/elasticsearch-dump/releases/tag/v3.3.1 is now up


Mode changes not working on Firefox

In the Firefox add-on, that is, not the GM version.

Fixed in fca4986cd0da5430409ebc86baad85ec4d17bb2e.


PR for STACK-276

This was generated off a recent branch of the master branch, so I'm not sure why there is such a large difference. Looks like the previous gen didn't have descriptions, nor did it require port and protocol to be provided.

Needs to be generated with 4.1.4


tn.reachable breaks when given tuples containing edges

Here's a minimal working example to show what goes wrong:
import numpy as np
import tensornetwork as tn

node = tn.Node(np.eye(2))
edge_tuple = (node[0], node[1])
reachable_nodes = tn.reachable(edge_tuple)

Everything works fine when I use a list for edges, and it appears the issue is tn.reachable assuming that any list-like collection of edges is necessarily a list. Should be an easy fix, thanks :)

thanks @jemisjoky, should be fixed by today

thanks @jemisjoky, should be fixed by today


Documentation for sparse fieldsets

Super awesome that this was considered and included, but it's not documented anywhere!  Just figured I would try it for fun, and lo and behold fields[users]=first_name,last_name,email works perfectly!

@arcreative https://github.com/cerebris/jsonapi-resources/wiki/JSONAPI::Resources-Querystring-Examples

Ok cool, just feels like it should be in the readme.  There's so much in the readme that I don't tend to go anywhere else.  Would suggest either adding it there or removing all but the basics from the readme to maintain consistency.

Agreed. There is an open PR and it's been on my todo list to move this into the readme for a while. I'll get to it today.

Ping. Sounds like this is almost solved.. can we get it ticked off,..  get this issue list down a little.
Thanks @utilityboy :)


[Fix] broken assets path

Fixes #6326
This fixes broken usage of imagetools and possibly other vite plugins as well - when asset paths are used with the static adapter.
The breaking PR was #4250.
This fix introduces a new config option rootRelativeAssets relativeAssets, which defaults to true false, restoring the way things worked prior to the breaking PR, => namely: non-relative asset paths (or a "root-based asset path").
EDIT: Changed option name and logic
This approach may or may not be the correct one and may be up for discussion or be rejected completely. For that reason, I have not written a test for that, yet. But I have tested the fix successfully on a project which suffered that issue.
If this is a viable fix, I'll gladly complete this PR with anything else needed.
...and thank you all for this amazing project :1st_place_medal:

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Can you check if https://github.com/JonasKruckenberg/imagetools/pull/400 would fix the issue you're facing?

Thank you for your input. You were right.
I tested https://github.com/JonasKruckenberg/imagetools/pull/400 with adapter-static and it seems to work now.


[Rancher] Ensure rancher images are portable, agents do not need internet access

I have agents behind firewalls that can't access github.  The agents are trying to access github to obtain files such as host-api, rancher-dns.

Hi @mryuha we are currently working on a version of Rancher that will exactly what you need. All the binaries we attempt to download will be packaged into the container(s). We'll update this issue when it is completed. I don't have know the issue number for this feature off hand, but I'll find it and post it.
We also currently have a solution where you can send the Internet bound traffic through a proxy. Not sure if it will work for you, but some of our other users have found it to be a reasonable solution. Here's the details: http://docs.rancher.com/rancher/rancher-ui/infrastructure/hosts/custom/#hosts-behind-a-proxy

Here's the feature that @cjellick was mentioning. It's basically running Rancher server without internet. https://github.com/rancher/rancher/issues/924

:+1:
#924 is specifically for the Server, our issue is running agents in networks that because of their security level are not allowed to access the internet, even through proxies.

Closing as this was implemented with #924.
http://docs.rancher.com/rancher/installing-rancher/installing-server/no-internet-access/


Remove region limit in AwsS3.php

This change remove the "one" region limit. The best connection and region is now selected automatically.

You only need the region for the upload. I just tested it. The line 27 in the file AwsS3.php can also be deleted.
$region = $this->adapter->getClient()->getRegion();
You can test my changes at community.teklab.de . Create a new post and upload a file.

You create a bucket in AWS and it is automatically accessible from all other regions. You don't have to create extra permissions for regions.

Who uses its bucket under s3.amazonaws.com/regionxyz/bucketname, can this at any time also over bucketname.s3.amazonaws.com
s3.amazonaws.com/regionxyz/bucketname/foldername = bucketname.s3.amazonaws.com/foldername

@exsisto could you confirm this when you have the chance? Much appreciated 😘

After some consideration with a dear friend working for AWS I concluded the following:
Not adding the region to the link will cause it to always hit the default region "US east 1" and receive a 307 redirect to the correct region. Aside from increased loading times due to the redirect your assets might be even more impacted in case the region has connection troubles.
On these grounds I think it's unwise to merge. Thank you for the PR and taking the time to explain the reasoning behind it.

For small communities, the region is certainly okay. But if users come from europe, asia, ..., then the region is not the best way. If the files are bigger than just a few small pictures, you will notice the difference. But ok ;)


changed http to https in HTML5 & CSS3

As described in title.
closes #7584

@AkiraLaine Seems you missed out on some of the reversals.
I'll take this up.

This looks good by the diff and apparently should not break anything, but needs to be tested, while other wise good to go.
If anyone is available, please go ahead, else I'll be taking this up later today.

Also this PR closes 7616.

Thanks @bugron for finding those. Updated description and PR :smile:

:+1: Thanks @AkiraLaine @bugron


Exclude cv-frontend-vue from Jest & ensure jsdom environment

Summary
This PR updates the Jest configuration to:

Ignore the cv-frontend-vue folder, which contains Vue tests using Vitest
(ES modules) and is not intended for Jest.
Use testEnvironment: 'jsdom' to ensure a browser-like environment for the
existing simulator/spec tests.

Changes

jest.config.js

Added testPathIgnorePatterns: ['<rootDir>/cv-frontend-vue/'] so Jest won't pick up
the ES module tests in cv-frontend-vue.
Set testEnvironment: 'jsdom' and switched to setupFilesAfterEnv for better
reliability when referencing window/document.

jest.setup.js

Retained the same setup logic, but confirmed that jsdom is in place before the tests run.

Why?

The ES module syntax under cv-frontend-vue/src/simulator/spec triggers
“Cannot use import statement outside a module” errors if Jest tries to parse them.
Those Vue tests run under Vitest, so they're best excluded from the main Jest test suite.
Setting testEnvironment: 'jsdom' ensures that simulator tests have a
browser-like environment for referencing window/document.

How to Test

Run yarn test (or npm test) in the project root.
Confirm that all legacy simulator tests pass without ESM import errors.

Let me know if you have any questions or feedback.

Output of yarn run test BEFORE CHANGES :

Output of yarn run test AFTER CHANGES :

Summary by CodeRabbit

Bug Fixes

Improved module resolution for CodeMirror hinting functionality in tests.
Ensured global context aligns with the window context for testing.

New Features

Added global jQuery accessibility for tests.
Introduced several global variables with default values for testing.

Documentation

Enhanced readability of HTML file reading in the setup configuration.

@tachyons please review.

@tachyons
ALSO :
The CI is failing due to a vulnerability in actionpack <IP_ADDRESS> (CVE-2024-54133). To fix this, we’d need to update Rails to at least <IP_ADDRESS>. Should I go ahead and make that change, or would you prefer we leave it as‐is for now?

@salmoneatenbybear Could you fix that in another PR ?

@salmoneatenbybear Could you fix that in another PR ?

Thanks for confirming @tachyons ! I'll go ahead and update Rails to at least <IP_ADDRESS> to address the CVE-2024-54133 vulnerability and get CI passing. Let me know if there are any concerns.


Synchronize parallel smallfile operations and samples using ripsaw redis sidecar

Fixes https://github.com/cloud-bulldozer/snafu/issues/98 together with https://github.com/cloud-bulldozer/ripsaw/pull/259
The code here uses the ripsaw's redis to synchronize smallfile samples and operations, so that all of them will be executed in parallel.
Closes #98

Can one of the admins verify this patch?

ok to test

Results for SNAFU CI Test

Test
Result
Runtime

cluster_loader
FAIL
00:00:00

fio_wrapper
PASS
00:06:12

fs_drift_wrapper
PASS
00:06:48

hammerdb
FAIL
00:06:35

iperf
PASS
00:05:22

pgbench-wrapper
PASS
00:06:46

smallfile_wrapper
FAIL
00:05:55

sysbench
PASS
00:05:21

uperf-wrapper
PASS
00:06:27

ycsb-wrapper
PASS
00:05:19

What failed here?, I've been able to run ./smallfile_wrapper/ci_test.sh successfully in my local.

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

cluster_loader
FAIL
00:00:00

fio_wrapper
PASS
00:06:18

fs_drift_wrapper
PASS
00:06:46

hammerdb
FAIL
00:06:46

iperf
PASS
00:05:14

pgbench-wrapper
PASS
00:06:48

smallfile_wrapper
PASS
00:05:59

sysbench
PASS
00:05:17

uperf-wrapper
PASS
00:06:27

ycsb-wrapper
PASS
00:05:19

@aakarshg @bengland2 LGTM can someone else throw eyes on this?

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

cluster_loader
FAIL
00:00:00

fio_wrapper
FAIL
00:06:46

fs_drift_wrapper
PASS
00:07:18

hammerdb
FAIL
00:13:52

iperf
PASS
00:05:46

pgbench-wrapper
PASS
00:07:13

smallfile_wrapper
FAIL
00:08:09

sysbench
PASS
00:05:33

uperf-wrapper
PASS
00:07:05

ycsb-wrapper
PASS
00:05:54

This PR depends on https://github.com/cloud-bulldozer/ripsaw/pull/259
  File "/opt/snafu/smallfile_wrapper/smallfile_wrapper.py", line 59, in __init__
    self.redis_host = os.environ["redis_host"]
  File "/usr/lib64/python2.7/UserDict.py", line 23, in __getitem__
    raise KeyError(key)

Once the previous is merged, we can move forward with this.

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
FAIL
00:06:51

fs_drift_wrapper
PASS
00:07:21

hammerdb
FAIL
00:13:46

iperf
PASS
00:05:44

pgbench-wrapper
PASS
00:08:29

smallfile_wrapper
PASS
00:06:22

sysbench
PASS
00:05:35

uperf-wrapper
PASS
00:06:56

ycsb-wrapper
PASS
00:05:56

needs a rebase and resolving conflicts.

needs a rebase and resolving conflicts.

Done ;-)

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
FAIL
00:06:52

fs_drift_wrapper
PASS
00:07:17

hammerdb
FAIL
00:13:45

iperf
PASS
00:05:48

pgbench-wrapper
PASS
00:07:14

smallfile_wrapper
PASS
00:08:26

sysbench
PASS
00:05:31

uperf-wrapper
PASS
00:07:01

ycsb-wrapper
PASS
00:06:00

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
FAIL
00:07:25

fs_drift_wrapper
PASS
00:07:48

hammerdb
FAIL
00:14:15

iperf
PASS
00:05:51

pgbench-wrapper
PASS
00:07:33

smallfile_wrapper
PASS
00:06:32

sysbench
PASS
00:05:32

uperf-wrapper
PASS
00:08:25

ycsb-wrapper
PASS
00:06:06

I'm confused, is this being thrown away or is it still active?  I thought we had sorted this out and it was ready for merge, it only affects smallfile so no big deal right?

I'm confused, is this being thrown away or is it still active? I thought we had sorted this out and it was ready for merge, it only affects smallfile so no big deal right?

My fault, I mistakenly closed it.

Results for SNAFU CI Test

Test
Result
Runtime

smallfile_wrappe
FAIL
00:20:43

I'm working in some minor changes to avoid snafu to hang when redis_host variable is not defined to make Snafu able to run even outside of ripsaw.  I'll make you know when ready.

Results for SNAFU CI Test

Test
Result
Runtime

smallfile_wrappe
PASS
00:17:14

I had to change some details of the implementation. Since the migration to python3, redis channel messages are now bytes instead of strings.

@rsevilla87 can you please fix the linting issue and also rebase this ? I am not able to do any merge because of conflict/.

@rsevilla87  ok, I'll take a look while I wait for my cluster to be repaired...

@rsevilla87 this conflict is trivial to resolve, just adding the "self.redis_host, self.redis_timeout, self.clients, " arguments to the trigger_smallfile call + some reformatting.
[bengland@localhost snafu]$ git diff
diff --cc smallfile_wrapper/smallfile_wrapper.py
index e45e1be,66cf5f7..0000000
--- a/smallfile_wrapper/smallfile_wrapper.py
+++ b/smallfile_wrapper/smallfile_wrapper.py
...
@@@ -74,10 -70,10 +73,8 @@@
              sample_dir = self.result_dir + '/' + str(s)
              if not os.path.exists(sample_dir):
                  os.mkdir(sample_dir)
 -            trigger_generator = trigger_smallfile._trigger_smallfile(logger, self.operations,
 -                                                                     self.yaml_input_file,
 -                                                                     self.cluster_name,
 -                                                                     self.working_dir, sample_dir,
 -                                                                     self.user, self.uuid,
 -                                                                     s)
 +            trigger_generator = trigger_smallfile._trigger_smallfile(
 +                    logger, self.operations, self.yaml_input_file,
 +                    self.cluster_name, self.working_dir, sample_dir, self.user,
 +                    self.uuid, self.redis_host, self.redis_timeout, self.clients, s)
              yield trigger_generator
-
-

Results for SNAFU CI Test

Test
Result
Runtime

smallfile_wrappe
PASS
00:11:54

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

smallfile_wrappe
PASS
00:12:38

Results for SNAFU CI Test

Test
Result
Runtime

requirements.txt
FAIL
00:00:00

smallfile_wrapper
PASS
00:11:45

uperf-wrapper
PASS
00:11:12

@aakarshg added some doc & diagram. PTAL

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
FAIL
00:13:20

fs_drift_wrapper
PASS
00:09:50

hammerdb
PASS
00:10:12

iperf
PASS
00:07:12

pgbench-wrapper
PASS
00:07:26

smallfile_wrapper
PASS
00:11:18

sysbench
PASS
00:05:13

uperf-wrapper
PASS
00:11:13

ycsb-wrapper
PASS
00:16:02

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
PASS
00:13:50

fs_drift_wrapper
PASS
00:09:50

hammerdb
PASS
00:10:52

iperf
PASS
00:07:16

pgbench-wrapper
PASS
00:07:35

smallfile_wrapper
PASS
00:10:52

sysbench
PASS
00:05:07

uperf-wrapper
PASS
00:11:12

ycsb-wrapper
PASS
00:17:35

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
PASS
00:15:49

fs_drift_wrapper
PASS
00:10:23

hammerdb
PASS
00:11:51

iperf
PASS
00:07:03

pgbench-wrapper
PASS
00:07:27

smallfile_wrapper
PASS
00:11:02

sysbench
PASS
00:05:38

uperf-wrapper
PASS
00:11:31

ycsb-wrapper
PASS
00:14:22

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
PASS
00:15:23

fs_drift_wrapper
PASS
00:09:29

hammerdb
PASS
00:10:51

iperf
PASS
00:06:45

pgbench-wrapper
PASS
00:07:19

smallfile_wrapper
PASS
00:10:42

sysbench
PASS
00:04:57

uperf-wrapper
PASS
00:23:47

ycsb-wrapper
PASS
00:14:50

Results for SNAFU CI Test

Test
Result
Runtime

smallfile_wrapper
PASS
00:12:45

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
PASS
00:15:45

fs_drift_wrapper
PASS
00:09:30

hammerdb
PASS
00:11:22

iperf
PASS
00:06:50

pgbench-wrapper
PASS
00:06:57

smallfile_wrapper
PASS
00:10:47

sysbench
PASS
00:04:40

uperf-wrapper
PASS
00:24:00

ycsb-wrapper
PASS
00:16:52

/rerun all

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
PASS
00:15:44

fs_drift_wrapper
PASS
00:09:50

hammerdb
PASS
00:11:44

iperf
PASS
00:06:44

pgbench-wrapper
PASS
00:07:21

smallfile_wrapper
PASS
00:10:21

sysbench
PASS
00:04:59

uperf-wrapper
PASS
00:24:01

ycsb-wrapper
PASS
00:14:57

@rsevilla87 can you please rebase this ?

Results for SNAFU CI Test

Test
Result
Runtime

fio_wrapper
PASS
00:15:40

fs_drift_wrapper
PASS
00:09:29

hammerdb
PASS
00:11:03

iperf
PASS
00:06:41

pgbench-wrapper
PASS
00:07:01

smallfile_wrapper
PASS
00:10:35

sysbench
PASS
00:05:08

uperf-wrapper
PASS
00:23:58

ycsb-wrapper
PASS
00:12:06


Link from VSCode Extensions page for asking questions gives 404

Steps:

navigate to https://marketplace.visualstudio.com/items?itemName=pluralsight.live-share-mob-timer&ssr=false#qna
Click on Ask a Question or Github Repository link and I get a 404.

URL when click on Github: https://github.com/ps-dev/liveshare-mob-timer/issues?utm_source=vsmp&utm_medium=ms web&utm_campaign=mpdetails and
URL when click on Ask a Question: https://github.com/ps-dev/liveshare-mob-timer/issues?utm_source=vsmp&utm_medium=ms web&utm_campaign=mpdetails

As Allan said, these issues are for our VS Code extension which is currently in preview and kept in a private repository. We hope to make that open source in the near future. This repo is for our open source desktop electron mob timer.
Closing as not an issue for this repo


feat: Support different formats for append

Context: #44

I also want to do a Hex version for both.


Remove flaky test

This test fails intermittently due to how Antlr4 works (compared to Antlr3)

Looks good


Node missing from scene/not position correctly

Godot version
4.0.1
System information
Windows 10
Issue description
I had a strange issue happen.
FYI i started this project in 4.0 earlier today, I upgraded after the problem happened as I was gonna just use the RC til I saw it went to stable in hopes it would fix this maybe.
I created an animation for something I had centered at the bottom of my game screen.
the animation was to move the position down 32px and bring it back up, upon playing this animation during testing the game, my scene which the animation was in and for, went to 0, 0 on the screen, animated, and then flew up into no where land, never to be seen again during gameplay, except at 0, 0 if it has no script associated, with it, but the script can just be set to extend and it'll disappear with everything else commented out.
This is so weird because you'd think til you play the animation again after resetting it would show again...it shows in the scene for editing, and the node is loaded when you test, but it's at 0, 0 instead of where it should be or no where to be found other then just exisiting in the scene tree
One time just before I caught on to way more details of what is going on I was messing with hiding it in the remote scene tree along with everyother node and it actually appeared and where it should be.
Steps to reproduce
It must have been the animation...but I can't be sure position is the most basic of animations, this seems like a freak accident that happened and I'm reporting it though, because whether I delete the scene or remove from my other scene this one scene seems to be broken permanently and recreating the scene over again with the same name doesn't fix it if you save in the same folder from what I've found.
You can get around it, but it's annoying as anything I've ever ran into yet.
In the project I have provided, in case it's not on for you you'll need to have visiable colliders on during debug, or else you will see NOTHING lol I don't have sprites setup yet as I was just working on basics lol.
You will see that I created my paddle in the scene itself and that works, I created the paddle scene in another folder and thankfully THAT works, the res://paddle.tscn jumps to 0, 0 when you start the game. If you delete that scene copy and paste to it the old one (which is what I did for the others I didn't make from scratch because of the polygon collider I have) It will break still if you resave to res://
I'm so sorry if something isn't clear it's been a long night I will do my best tomorrow to clarify anything if needed.
Minimal reproduction project
Project.zip

I found that deleting the scene in res:// and then replacing with one I had in test and renaming it to what it was from there, allows it to start working again, but why it broke in the first place, I hope we can figure out so no one else has to deal with this headache.

Your res://paddle is animating the root node, while test/paddle is animating the collider. Animating root node will reset the position of the node to the one you set in animation.

I mean that's fair for that part, but then why did it fly off the tip top corner of the screen from the animation happening at 0, 0 after the animation and then just never show in the scene again properly. It seems after during another test that the scene shows if I have the script attached it's just high enough over 0, 0 that you only see if while animating.
If not script at all which without input doesn't change anything it'll sit at 0, 0 but again the scene position regardless is in the middle of the parent scene and yet it shows in the top left wether 0, 0 or just above so you only see during animation.

Ok I don't understand the problem.
What I have to copy where? Give names.

So I may have resolved this, but I'm having a hard time determining if AnimationPlayer is supposed to play [RESET] sometime before or during the ready process? I feel like this morning I just am not searching for info on this in the correct area, or maybe it's not documented/suppose to happen. Basically when I've animated the root node, [RESET] had a position for it of 0, 0 (which doesn't look like was unintended, this was a me issue, but didn't realize this happens/plays when it seems to be playing)
Basically I think if we have a real issue or not comes down to the behavior of AnimationPlayer and the [RESET] animation during loading everything (I'm gonna assume this is intended) as it seems I can't find if this should happen or not, if it should then this can be closed, everything that happened was a mistake on my part/not realizing a behavior of AnimationPlayer. Otherwise I will update with more information tonight

Yeah I just found this just a little earlier too. Upon further information I finally found today I see the bigger picture now. This should be able to be closed. Thank you for pointing me in the right direction.


Contracts page can't handle a large number of contracts

Description
A clear description of the bug is:

The contract list can't load a large amount of contracts well (contracts were made from TFRobot).
Maybe the contract list should be the same as other tables, with pages and items per page, to prevent the loading of that large amount of contracts all at once.

The error message should be improved because it was not me who aborted anything.

The total cost of contracts is stuck on loading like that.

Must include any relevant identifiers, like:
Network: Mainet, Ninja.
Version: 2.3.0-alpha6
Twin ID: 7189
Steps to reproduce

Navigate to the dashboard.
Connect your wallet (account with a lot of contracts).
Navigate to the Your Contracts page.

Logs/Alerts
Must include, if available:

Logs/Alerts.

Error while listing contracts due: The user aborted a request.
Screenshots or screen records.
screen-capture.webm

Work In Progress :

handle pagination from grid_client.

Work In Progress:

The pagination won't be handled from grid_client.
I will get contracts form grid proxy and it's already paginated there.
working on preparing data from proxy and update table to paginate.

Work Completed:

I added function for getting contracts from proxy.
added v-data-table-server for handling pagination

Blocked:

blocked on this issue https://github.com/threefoldtech/tfgrid-sdk-go/issues/911 to be able to get and paginate on both Created and GracePeriod together.

Work In Progress:

Copying changes to new branch (old one has many conflicts).
update changes after pagination is done from proxy client.

Work In Progress:

Table update to v-data-table-server to handle pagination.
Normalized Contract Interface updated to match data from grid proxy.
handling loading each type of contracts separately.
updating normalizeContract function.
fixing bug in pagination.
updating gridproxy types to filter with array of contract states

Work Completed:

Pagination handled and all functionalities are working right.

verified and fixed on devnet
version : ad30945
contracts pages performance enhanced and loads requests fine now,
https://github.com/threefoldtech/tfgrid-sdk-ts/assets/110984055/c73238ce-00f3-4f7e-b627-d9a6a728a4ee


Milestones and versioning

I'm a little bit confused about this project's milestones.
What I see:

The last released version was 0.34.0 (by @martinmoene)
PR #172 by @mbeutel increased the gsl_lite_MINOR macro to 35
There is no 0.35 milestone, but there are 0.36 and 1.0 milestones

My questions are:

Do you plan to release v0.35, or will the next release be 0.36?
I there will be a v0.35, which issues are to be in it, and when do you plan to release it?
What is the versioning policy, what triggers the release of a new version? Are released versions supposed to be more stable in some way? Are there additional checks before a release?

After I'm finished with my not_null-related modifications, I plan to integrate the new version of GSL-Lite into our company's codebase. I'm curious if I should wait for a "named release", or if simply grabbing the HEAD from master is safe enough.

(First, sorry about the nonsense with me editing your post. It should be back to the original state now.)
In my own projects I usually increment the version number in HEAD after a release and keep it until the next release. This was why I bumped the version number to 0.35 in my PR. But then I noted that Martin used to increment the version number in the final commit for a release (with message "Release X.Y"); following this reasoning, my PR would constitute version 0.35.
I wanted to get a few things straightened out (most notably the Vcpkg integration) before making a release myself, so I didn't push out a release 0.35.

Do you plan to release v0.35, or will the next release be 0.36?

My plan is to skip 0.35 and to make 0.36 the next release to avoid version confusion.

What is the versioning policy, what triggers the release of a new version? Are released versions supposed to be more stable in some way? Are there additional checks before a release?

Perhaps Martin can comment on how this was handled in the past. This is what I'd like to do:

There is no stability guarantee for changes only in HEAD, i.e. anything added since the last release may be renamed, removed, have the semantics changed, etc. without further notice.
A minor-version release should be compatible (in both ABI and API) with the previous minor-version release. Thus, once a change is released, it becomes part of the contract, and subsequent releases should not break anyone relying on it.
The next major-version release is kept in a separate branch (currently "develop").

I'm curious if I should wait for a "named release", or if simply grabbing the HEAD from master is safe enough.

If we go with my approach, you should probably await a tagged release. But I'm open for other suggestions :)
In either case, I think our release and versioning policy should be mentioned in the readme.

Versioning in the past
I incremented the version number just before release. I did have some vague idea that continuing development under that number was not 'ideal', but never thought of incrementing it immediately after a release nor have noticed it's use elsewhere. Looks like a good idea to me :)
My notion of releases does not go much further than the division in major, minor and bug-fix releases. I usually released when I had done a block of work, when someone asked for it, or some such, and so far these have all been minor and bug-fix releases, be it right or not. I haven't had and still haven't enough notion of ABI to include that into versioning :(
You can imagine I'm quite happy to see the thought and effort you are putting into better organizing 'what not' :)

Martin, thank you for clarifying this.
Would you consider "no stability guarantees for code not under a release tag" an acceptable and reasonable stance? Otherwise we'd need a different branching strategy (e.g. using "develop" for not-yet-final changes).
(In any case, the branch for the next major version should probably be called "vNext" or so, not "develop".)

I haven't had and still haven't enough notion of ABI to include that into versioning :(

ABI is a difficult thing, and I'm not always quite sure myself where to draw the line. In theory, almost every change we apply could break ABI for someone, but most of those breakages only occur in pathological situations (like taking the address of a particular member function) which we can probably ignore. Also, we always risk ODR violations when we change function definitions, but these are rarely problematic because most functions in gsl-lite are probably expanded inline. Sometimes we explicitly accept ODR violation, e.g. when compiling different translation units with different contract settings.
I think we should be mostly concerned with changes to types that are instantiated in user-defined code (as opposed to being used only for metaprogramming). Changes to template parameters, base classes, data members, virtual member functions are usually ABI-breaking and should be avoided.
KDE's guide to ABI compatibility is very helpful:
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

Moritz, thanks for the pointer to KDE's guide to ABI compatibility.
I'd rather not branch for non-major (version) developments, so as a consequence it is acceptable to have "no stability guarantees for [new] code not under a release tag" :)


Monitors and datasets import/export improvements

Change in the handling of datasets and monitor import/export through json configuration.
Changes suggested by @dcrawforAtAnsys so that the configuration file can be validated by a schema.
Previously, the name of monitors and datasets was used as key. Hence, it was impossible to write a schema with unique keys.
Backward compatibility is maintained. No deprecation warning is displayed as I'm not 100% sure it is appropriate. We are changing the format of the json and not actually deprecating anything.

@lorenzovecchietti This PR is linked to any Issue?

@lorenzovecchietti This PR is linked to any Issue?

No, @dcrawforAtAnsys reached out to me directly

LGTM. This will require more testing against the schema which will come in a subsequent PR.

Do we want/neet to wait for this other PR (if it is coming soon) before merging? @Samuelopez-ansys @dcrawforAtAnsys


Switch from postgresql.crt to root.crt

It's already root.crt on the orchestrator (where it works), so let's be consistent

Backported to lasker in commit 864b5adc636e51fc39f0df6634a5a23e2681bdfa.
commit 864b5adc636e51fc39f0df6634a5a23e2681bdfa
Author: Jason Frey<EMAIL_ADDRESS>Date:   Wed May 12 08:57:03 2021 -0400

    Merge pull request #21214 from bdunne/postgresql_cert_path

    Switch from postgresql.crt to root.crt

    (cherry picked from commit 5ad6608a431a565e29e90341f4c22ee5bb1f70e1)


Balloon brick game project

Related Issue
Project idea: Balloon and Brick Game
Closes: #1232
Describe the changes you've made
I have implemented a fully working game as described in my issue.
Link to the work done : https://akanchhabhadani.github.io/Pop-the-Balloon/
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

@991rajat Please review it.


NetworkPolicies are not deleted when Namespace is removed from Project

Rancher versions:
rancher/server or rancher/rancher: latest
rancher/agent or rancher/rancher-agent: v2.0.6
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA rancher
Steps to Reproduce:

create a namespace: kubectl create namespace np-test
Open Rancher web ui and move namespace np-test to a Project
found NetworkPolicies are created for np-test: kubectl -n np-test get networkpolicyNAME         POD-SELECTOR   AGE
hn-nodes     <none>         45m
np-default   <none>         45m

Open Rancher web ui and move namespace np-test to None

Results:
NetworkPolicies still exists: kubectl -n np-test get networkpolicy
NAME         POD-SELECTOR   AGE
hn-nodes     <none>         45m
np-default   <none>         45m

Tested with latest build from master.

Create a cluster with "Project Network Isolation" enabled.
Create a namespace : kubectl create namespace test1
Open Rancher web ui and move namespace test1 to a Project
NetworkPolicies get created for this namespace.
Open Rancher web ui and move namespace test1 to None.
NetworkPolicies get deleted from the namespace as expected.


Feature/row select

Implemented the option rowSelect to handle case in comment of #409
rowSelect default is false. When true, the row will cause the mouse to change to pointer to indicate that the row is selectable (an onClick will fire)

And, when the user clicks on the row, it will highlight a different color to indicate that the row is being pressed like a button.

The reason for this solution instead of just overriding the theme as suggested here is my usecase involves many different tables across the application -- some of which have clickable rows and some which do not. So this seemed like the best solution overall.
This also includes an update to the documentation to include event as a parameter in the onRowClick function as mentioned in issue #438
Will close PR #693

Closed because I didn't realize i was on a suuuuper old build


navbar width issue

hey,  in small screen (tab, and mobiles) navbar goes out of screen,  so we should to fix it...
tab

mobile L and mobile m (mobile medium screen)

mobile s    (mobile small screen)

Thanks for creating the issue in WildGuard! The issue has been assigned to you.
Before you start working on your PR, please make sure to:

⭐ Star the repository if you haven't already.
Pull the latest changes to avoid any merge conflicts.
Attach before & after screenshots in your PR for clarity.
Include the issue number in your PR description for better tracking.

Don't forget to follow @anuragverma108 – Project Admin & @PriyaGhosal -Project Collaborator  – for more updates!
We're excited to see your contribution as part of Hacktoberfest 2024! 🎉
Happy open-source contributing!

thanks @PriyaGhosal for assigning it to me


Support transaction_log_retention_days and backup_retention_settings fields

Add support for transaction_log_retention_days and backup_retention_settings.
Closes https://github.com/terraform-google-modules/terraform-google-sql-db/issues/199.

Please check the contributing guide and ensure tests pass: https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/CONTRIBUTING.md

@tjokimie - are you still working on this PR?

Anyupdate on this request? i tried the code not wokring for me.

@waqas105 The PR needs to be rebased and edited to make sure tests pass.

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_documentation
The documentation needs to be regenerated. Please run make generate_docs.

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/mssql/README.md /tmp/tmp.p3GJYits9K/generate_docs/workspace/modules/mssql/README.md
17c17
< | backup\_configuration | The database backup configuration. |
object({
    binary_log_enabled             = bool
    enabled                        = bool
    point_in_time_recovery_enabled = bool
    start_time                     = string
  })
 |
{
  "binary_log_enabled": null,
  "enabled": false,
  "point_in_time_recovery_enabled": null,
  "start_time": null
}
 | no |
---
> | backup\_configuration | The database backup configuration. |
object({
    binary_log_enabled             = bool
    enabled                        = bool
    point_in_time_recovery_enabled = bool
    start_time                     = string
    transaction_log_retention_days = string
    backup_retention_settings      = map(string)
  })
 |
{
  "backup_retention_settings": null,
  "binary_log_enabled": null,
  "enabled": false,
  "point_in_time_recovery_enabled": null,
  "start_time": null,
  "transaction_log_retention_days": null
}
 | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/mysql/README.md /tmp/tmp.p3GJYits9K/generate_docs/workspace/modules/mysql/README.md
15c15
< | backup\_configuration | The backup\_configuration settings subblock for the database setings |
object({
    binary_log_enabled = bool
    enabled            = bool
    start_time         = string
    location           = string
  })
 |
{
  "binary_log_enabled": false,
  "enabled": false,
  "location": null,
  "start_time": null
}
 | no |
---
> | backup\_configuration | The backup\_configuration settings subblock for the database setings |
object({
    binary_log_enabled             = bool
    enabled                        = bool
    start_time                     = string
    location                       = string
    transaction_log_retention_days = string
    backup_retention_settings      = map(string)
  })
 |
{
  "backup_retention_settings": null,
  "binary_log_enabled": false,
  "enabled": false,
  "location": null,
  "start_time": null,
  "transaction_log_retention_days": null
}
 | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/postgresql/README.md /tmp/tmp.p3GJYits9K/generate_docs/workspace/modules/postgresql/README.md
14c14
< | backup\_configuration | The backup\_configuration settings subblock for the database setings |
object({
    enabled                        = bool
    start_time                     = string
    location                       = string
    point_in_time_recovery_enabled = bool
  })
 |
{
  "enabled": false,
  "location": null,
  "point_in_time_recovery_enabled": false,
  "start_time": null
}
 | no |
---
> | backup\_configuration | The backup\_configuration settings subblock for the database setings |
object({
    enabled                        = bool
    start_time                     = string
    location                       = string
    point_in_time_recovery_enabled = bool
    transaction_log_retention_days = string
    backup_retention_settings      = map(string)
  })
 |
{
  "backup_retention_settings": null,
  "enabled": false,
  "location": null,
  "point_in_time_recovery_enabled": false,
  "start_time": null,
  "transaction_log_retention_days": null
}
 | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/modules/safer_mysql/README.md /tmp/tmp.p3GJYits9K/generate_docs/workspace/modules/safer_mysql/README.md
173c173
< | backup\_configuration | The backup\_configuration settings subblock for the database setings |
object({
    binary_log_enabled = bool
    enabled            = bool
    start_time         = string
    location           = string
  })
 |
{
  "binary_log_enabled": false,
  "enabled": false,
  "location": null,
  "start_time": null
}
 | no |
---
> | backup\_configuration | The backup\_configuration settings subblock for the database setings |
object({
    binary_log_enabled             = bool
    enabled                        = bool
    start_time                     = string
    location                       = string
    transaction_log_retention_days = string
    backup_retention_settings      = map(string)
  })
 |
{
  "backup_retention_settings": null,
  "binary_log_enabled": false,
  "enabled": false,
  "location": null,
  "start_time": null,
  "transaction_log_retention_days": null
}
 | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
Running terraform validate
terraform_validate ./examples/mssql-public
Success!
The configuration is valid.
terraform_validate ./examples/mysql-ha
Error:
Failed to install provider
Error while installing hashicorp/google-beta v3.71.0: unsuccessful request to
https://releases.hashicorp.com/terraform-provider-google-beta/3.71.0/terraform-provider-google-beta_3.71.0_linux_amd64.zip:
500 Service Not Found
terraform_validate ./examples/mysql-private
Success!
The configuration is valid.
terraform_validate ./examples/mysql-public
Success!
The configuration is valid.
terraform_validate ./examples/postgresql-ha
Success!
The configuration is valid.
terraform_validate ./examples/postgresql-public
Success!
The configuration is valid.
terraform_validate ./examples/postgresql-public-iam
Success!
The configuration is valid.
terraform_validate ./modules/mssql
Success!
The configuration is valid.
terraform_validate ./modules/mysql
Error:
Failed to install provider
Error while installing hashicorp/google-beta v3.71.0: could not query provider
registry for registry.terraform.io/hashicorp/google-beta: failed to retrieve
authentication checksums for provider: the request failed after 2 attempts,
please try again later: 500
terraform_validate ./modules/postgresql
Success!
The configuration is valid.
terraform_validate ./modules/private_service_access
Success!
The configuration is valid.
terraform_validate ./modules/safer_mysql
Success!
The configuration is valid.
terraform_validate ./test/fixtures/mssql-ha
Success!
The configuration is valid.
terraform_validate ./test/fixtures/mssql-public
Error:
Failed to install provider
Error while installing hashicorp/google v3.71.0: unsuccessful request to
https://releases.hashicorp.com/terraform-provider-google/3.71.0/terraform-provider-google_3.71.0_linux_amd64.zip:
500 Service Not Found
terraform_validate ./test/fixtures/mysql-ha
Error:
Failed to install provider
Error while installing hashicorp/random v2.3.1: could not query provider
registry for registry.terraform.io/hashicorp/random: failed to retrieve
authentication checksums for provider: the request failed after 2 attempts,
please try again later: 500
Error:
Failed to install provider
Error while installing hashicorp/null v2.1.2: unsuccessful request to
https://releases.hashicorp.com/terraform-provider-null/2.1.2/terraform-provider-null_2.1.2_linux_amd64.zip:
500 Service Not Found
terraform_validate ./test/fixtures/mysql-private
Success!
The configuration is valid.
terraform_validate ./test/fixtures/mysql-public
Success!
The configuration is valid.
terraform_validate ./test/fixtures/postgresql-ha
Error:
Failed to install provider
Error while installing hashicorp/null v2.1.2: could not query provider
registry for registry.terraform.io/hashicorp/null: failed to retrieve
authentication checksums for provider: the request failed after 2 attempts,
please try again later: 500
terraform_validate ./test/fixtures/postgresql-public
Success!
The configuration is valid.
terraform_validate ./test/fixtures/postgresql-public-iam
Success!
The configuration is valid.
terraform_validate ./test/setup
Error:
Failed to install provider
Error while installing hashicorp/google v3.71.0: could not query provider
registry for registry.terraform.io/hashicorp/google: failed to retrieve
authentication checksums for provider: the request failed after 2 attempts,
please try again later: 500

@waqas105 The PR needs to be rebased and edited to make sure tests pass.

@morgante  Sorry, finishing this took quite a bit longer than I anticipated. I fixed the issue, rebased the PR, updated the examples and added some tests.
Some of the tests seem to have some network issues, e.g:
Error while installing hashicorp/null v2.1.2: unsuccessful request to
https://releases.hashicorp.com/terraform-provider-null/2.1.2/terraform-provider-null_2.1.2_linux_amd64.zip:
500 Service Not Found

In addition I run the tests locally but I couldn't figure out what triggered this one to fail:
×  Postgres SQL pubic instance has just one assigned IP address

     expected: 1
          got: 2

     (compared using ==)

The ipAddresses block seems to be [{"ipAddress"=>"<IP_ADDRESS>", "type"=>"PRIMARY"}, {"ipAddress"=>"<IP_ADDRESS>", "type"=>"OUTGOING"}]. Do you have any ideas what could cause this?

Rebased with master again.