Track downloads of vdk

What is the feature request? What problem does it solve?
PyPI has pretty nice stats about downloads.
But we cannot differentiate user downloads from CICD-caused downloads - https://pypistats.org/packages/quickstart-vdk
It would be nice if we can
Suggested solution
Try to identify what is causing downloads by our CICD and possibly ignore them or identify them.

Triaged. We will keep it, as being a feature that is inline with the current VDK roadmap and we would like to address.

From the PyPI FAQ

What about downloads due to CI/CD tools?
Downloads from CI/CD tools are included in all metrics. There is currently no easy way to attribute downloads to build/deployment tools.

I have added a monthly download badge to each of the readmes, including each plugin. I was not able to distinguish from CI/CD downloads, but that seems to be the case for others as well, as seen by the comment above.
https://github.com/vmware/versatile-data-kit/pull/2983

I tried to chew at the CI/CD download issue at a few different angles and landed on using the BigQuery dataset. Here is the query I am running
#standardSQL SELECT   file.project,   COUNT(*) as download_count FROM   bigquery-public-data.pypi.file_downloads WHERE   file.project IN ('vdk-core',   'vdk-control-cli',   'vdk-heartbeat',    'airflow-provider-vdk',   'quickstart-vdk',   'vdk-audit',   'vdk-control-api-auth',   'vdk-dag',   'vdk-data-sources',   'vdk-gdp-execution-id',   'vdk-huggingface',   'vdk-ingest-file',   'vdk-ipython',   'vdk-jupyter',   'vdk-lineage',   'vdk-meta-jobs',   'vdk-oracle',   'vdk-postgres',   'vdk-server',   'vdk-smarter',   'vdk-sqlite',   'vdk-test-utils') AND   DATE(timestamp) BETWEEN DATE_SUB(CURRENT_DATE(), INTERVAL 1 MONTH) AND CURRENT_DATE() AND   details.installer.name NOT LIKE '%pip/x.y.z Python/x.y.z Linux/x.y.z%' AND   details.installer.name NOT LIKE '%actions/setup-python%' GROUP BY   file.project ORDER BY   file.project ASC
Here is the result

The quote is 3.2 GB when run. At $6.25 per TiB processed, that comes out to $0.018 per run.
Importantly, the result doesn't match the page on PyPI stats. What would you recommend?
@yonitoo Thanks for your comments on the PR, I would appreciate your feedback on this.

Is this closed by #2983 ? Also thanks to @yonitoo for fixing the closing tags


Restore BN export

The BN export was removed in #398. I hadn't anticipated at the time that this would constitute a breaking change. It turns out that this export was relied upon in mobile in one place.
It has been temporarily restored, along with a comment that suggests we remove it in the next major version.

Here's where I found it being used: https://github.com/MetaMask/metamask-mobile/pull/2416/files#r599951773

It turns out that this export was relied upon in mobile in one place.
we should definitely fix that.


Update ERC-7066: Move to Last Call

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot rerun

Thanks a lot for the reviews @Joeysantoro @SamWilsn!
Your pointers are looked into and resolved.


Plugin not working as expected.

I have a fresh installation of builder plugin on my development website. But after I installed it, and navigate to the plugin, the page isn't working as expected.
I have been following this tutorial https://octobercms.com/blog/post/say-hello-builder, and was stuck on the builder plugin page. See here (https://imgur.com/a/zkdGZMX) for reference.
Initially, the builder plugin page is shown on the 2nd screenshot. But, after I clicked the icon on the left sidebar and added a plugin, then clicked on the page builder menus, the plugin page turns unresponsive as shown on the 3rd screenshot. And the menu preview section will automatically close/hide.
Please help me on this. Thank you!

Sorry, this is a duplicate issue on https://github.com/rainlab/builder-plugin/issues/253.


[BUG]: Operator e2e scenario for powerscale driver with second set of alternate values is failing in OpenShift cluster

Bug Description
In OCP clusters, the master nodes have the taint - key: "node-role.kubernetes.io/master" and not - key: "node-role.kubernetes.io/control-plane" so the controller pods are looking for a taint that doesn't exist in the E2E test scenarios that uses existing alternate values file. The toleration - key: "node-role.kubernetes.io/master" should be added.
Logs
In OCP clusters, the master nodes have the taint - key: "node-role.kubernetes.io/master" and not - key: "node-role.kubernetes.io/control-plane" so the controller pods are looking for a taint that doesn't exist in the E2E test scenarios that uses existing alternate values file. The toleration - key: "node-role.kubernetes.io/master" should be added.
Screenshots
No response
Additional Environment Information
No response
Steps to Reproduce
Execute the specified e2e scenario in OpenShift cluster
Expected Behavior
Controller pods should be successfully scheduled in Openshift cluster
CSM Driver(s)
CSI-Powerscale
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
OpenShift Server Version: 4.17
Operating System
RHCOS

link:30361

Bug associated with it is resolved and closed hence closing the issue.


Underscore in metadata qualifier prevents adding new metadata values

The user interface allows you to create a field with an underscore but does not allow you to add the field. I've seen this occur on DSpace 7.6, DSpace 8.0, and the screenshot was taken from the sandbox.
Steps to reproduce:

Create a new schema metadata field which includes an underscore in the metadata qualifier, for example local.custom-element.snake_case_field
Edit the metadata of an item and add that new field.

Expected behaviour:
Either:

The field is added and can be saved.
Or one shouldn't be able to create the metadata field in the metadata registry (step 1 should error).

Observed behaviour:
An error occurs because validation fails in the frontend user interface - the UI thinks the field does not exist.

The reason why I've posted this here and not in dspace-angular is because the /server/api/core/metadatafields/search/byFieldName endpoint seems to be returning no results when it's supposed to return metadata about the metadata field.
I came to this conclusion by comparing what happens when it works and doesn't work. I've included the json when it fails.
When it fails
https://sandbox.dspace.org/server/api/core/metadatafields/search/byFieldName?schema=&element=&qualifier=&query=local.custom-element.snake_case_field&exactName=

{
  "_links" : {
    "self" : {
      "href" : "https://sandbox.dspace.org/server/api/core/metadatafields/search/byFieldName?schema=&element=&qualifier=&query=local.custom-element.snake_case_field&exactName="
    }
  },
  "page" : {
    "size" : 20,
    "totalElements" : 0,
    "totalPages" : 0,
    "number" : 0
  }
}

When it works
https://sandbox.dspace.org/server/api/core/metadatafields/search/byFieldName?schema=&element=&qualifier=&query=dc.contributor.illustrator&exactName=

Based on the description above, this does sound like a bug in the REST API / Java code.  Needs a volunteer to investigate and find a solution.


MAINT: Fully qualify std::move invocations to fix clang -Wunqualified-std-cast-call

Reference issue
n/a (discovered by compiling with clang locally)
What does this implement/fix?
Clang implemented a warning last year to detect bare move and forward calls, as they have the potential to be error prone: https://github.com/llvm/llvm-project/commit/70b1f6de539867353940d3dcb8b25786d5082d63. This warning should be available in clang-15.
Additional information
See similar cleanups here: https://github.com/antlr/antlr4/pull/4101 and https://github.com/IntelRealSense/librealsense/pull/11416

Sounds good -- given brief discussion above, CI is green, and straightforward reviews/merges for similar patches in the other large/popular projects in cross-linked PRs, this seems reasonably safe.

Thanks for your first contribution to SciPy


where is the Exchange Rate for each currency?

I have seen in Spree3 that this Gem take in the admin interface you should put the price for each currency. Is there any currency rate approach like there use to be before? could someone tell me when did this change took place?  Is there any fork for Spree3 working with the exchange rate approach.
I think the rates are a better way to make the approach, don´t know the reasons why this change was made, but the older is more standard, more international and extended.
thank you very much

Not knowing enough about Rails, I will venture to ask if this can be temporarily be done programmatically, as in:
product.price(Product_ID,EUR)=FXRATE*product.price(Product_ID,USD)
Can this be done directly on the database or would it have to pass through some Rails layer?

There is my gem, it expands spree_multi_currency functionality https://github.com/itbeaver/spree_fx_currency


updated github-initer to main branch[ISSUE]

Issue custom template:
[Describe your issue here]
updated github-initer to main branch

updated github-initer to main branch


Create indicator runner main function

Description
Creates a main function that runs an arbitrary indicator.
Changelog

runner.py:  Adds a main function that can be invoked with python -m delphi_utils.runner [indicator module]
archive.py:  Refactor to have an archiver creator function

I made a bunch of changes to the logic that decides what archiver to use to the point that it needed associated tests.  Please take a look now.

Looks like you hit #896, restarted tests and they passed now


Validate bundle

Summary

Ticket Link
https://mattermost.atlassian.net/browse/MM-49470

@hanzei , both make dist and make dist-dev are working now in commit 946f15d
Invoke policy document:
{"Version":"2012-10-17","Statement":[{"Sid":"AllowS3","Effect":"Allow","Action":["s3:GetObject"],"Resource":["arn:aws:s3:::mattermost-aws-apps/manifests/*","arn:aws:s3:::mattermost-aws-apps/static/*"]},{"Sid":"AllowS3list","Effect":"Allow","Action":["s3:ListBucket"],"Resource":["arn:aws:s3:::mattermost-aws-apps"]},{"Sid":"AllowLambda","Effect":"Allow","Action":["lambda:InvokeFunction"],"Resource":["arn:aws:lambda:us-east-1:255909515137:function:trello_0-0-1_trello","arn:aws:lambda:us-east-1:255909515137:function:pagerduty_v1-0-0_pagerduty","arn:aws:lambda:us-east-1:255909515137:function:pagerd_v1-0-0_pagerd","arn:aws:lambda:us-east-1:255909515137:function:opsgenie_1-0-0_bundle","arn:aws:lambda:us-east-1:255909515137:function:pagerduty_1-0-0_bundle","arn:aws:lambda:us-east-1:255909515137:function:trello_1-0-0_bundle","arn:aws:lambda:us-east-1:255909515137:function:google-drive_1-0-0_bundle"]}]}

You can now install it in Mattermost using:
  /apps install listed google-drive

Will continue working on this PR once https://github.com/mattermost/mattermost-app-google-drive/pull/2 is merged.


change the name of pagination fields.

Is your feature request related to a problem? Please describe.
It is a really good idea to rethink and potentially change our naming conventions for naming fields. In the GraphQL doc, in the best practices, under the "Complete connection model" it is worth noting that it is naming the fields like this:
pluralNameConnection

For example it uses friendsConnection and not friends.

[!NOTE]
Unfortunately I did not where I read/heard for the first time that it is a good idea to add the Connection suffix to the name of your field that needs to have pagination enabled :smiling_face_with_tear:.

Have you read the Contributing Guidelines?
Yes.
Describe the solution you'd like
I guess it's gonna be fairly simple, instead of todos we're gonna have todosConnection. And then we can let devs to use one over another (I mean now we can have the normal todos field to do an offset pagination or alternatively we can add Offset suffix to these fields as well).
This gives us the ultimate flexibility that we need. Think of it this way, you're now developing a GraphQL API, and your in love with the concept of not having to deal with versioning anymore. So with that in mind now you've implemented the cursor based pagination and so far everything is cool but then you need to switch to offset pagination for some unknown reasons. So now if we switch from cursor based pagination to the offset base pagination as describe in the docs with @QueryOptions({ pagingStrategy: PagingStrategies.OFFSET }) you're gonna introduce breaking change.
And this is not a desirable outcome. Let's also forget about the fact that we have @deprecated directive just to enable our clients to have a much smoother transition to the new API.
Describe alternatives you've considered
I am not sure and have not tried it yet I could always go with @Relation('todoItem', () => TodoItemDTO, { connectionName: 'todoItemsConnection' }).
Additional context
But my point here is our default behaviors, and possibly supporting two different kind of pagination strategy at the same time.

Hmmm, in fact now that I think about it this should be possible for the devs. I mean you can do something like this:
import { ID, ObjectType } from '@nestjs/graphql'
import { FilterableField, PagingStrategies, Relation } from '@ptc-org/nestjs-query-graphql'
import { TodoItemDTO } from '../todo-item/dto/todo-item.dto.ts';

@ObjectType('Test')
@Relation('todoItem', () => TodoItemDTO, {
  connectionName: 'todoItemsConnection',
  pagingStrategy: PagingStrategies.CURSOR,
})
@Relation('todoItem', () => TodoItemDTO, {
  connectionName: 'todoItemsOffset',
  pagingStrategy: PagingStrategies.OFFSET
})
export class TestDTO {
  @FilterableField(() => ID)
  id!: number

  @FilterableField()
  title!: string
}

Although I cannot see how I can flag one of the @Relations as deprecated. I can see description and other options though.

Just had some discussions in the GraphQL Discord serve and the outcome was just do not get overboard and just develop you API. When the time comes to introduce a breaking change follow this pattern: postsV2 or whatever your Object type might be called.
https://discord.com/channels/625400653321076807/1322503283117654079/1323001563840516331
@TriPSs Do you have any comment on this?


Unused params in eosio.token

Removes unused stats table reference passed to add_balance and sub_balance

Header files modified.

Still has build problems.

Greg just gave me access to buildkite, the build is now passing.


aiobotocore releated test failures

Some of our tests have started failing with
AttributeError: module 'aiobotocore' has no attribute 'AioSession'

due to the new aiobotocore 2.0.0 release. Working on a fix now, just wanted to surface this for others

Turns out this was already fixed upstream in s3fs but, for some reason I'm still not sure of, we've been pulling in an older version of s3fs in CI (specifically s3fs==0.6.0). I've proposed we add an s3fs version constraint to our CI environments over in https://github.com/dask/dask/pull/8336. For an example of the current test failures see the CI builds in https://github.com/dask/dask/pull/8337

Do we want to unpin at some point or are we happy to just close this?

I'm dealing with this issue as well and I believe I'm using the latest version of s3fs. Is there a fix for this?

I'm checking over in https://github.com/jrbourbeau/dask/tree/unpin-s3fs whether we can unpin s3fs today or not

I believe the issue is occurring again. I was not receiving this error previously but the issue is occurring again as of a few hours ago @ian-r-rose.

Do you have a link to a failure in the dask/dask test suite? aiobotocore has a history of releasing API breaking changes, but this issue meant to track its usage in the test suite here.

No I do not, sorry this wasn't test related.
AttributeError: module 'aiobotocore' has no attribute 'AioSession'

This issue is replicated on both pandas and dask when I read parquet_files from s3. I've posted a separate issue on s3fs's github repo

Looks like you've resolved it in s3fs, glad you got it working @abhishek815 !

Still getting this error when running cell 5 of this: https://nbviewer.org/github/NOAA-OWP/AORC-jupyter-notebooks/blob/master/jupyter_notebooks/AORC_Zarr_notebook.ipynb


Serverless Framework integration

Hi @choonkeat and thanks for developing elm-webapp, it’s awesome to see something like Lamdera open-sourced!
I’d like to contribute with a suggestion about the deployment process. It could be interesting to support the Serverless Framework for deployment since it already supports different cloud providers:

AWS
Azure
Tencent
Google
Knative
Alibaba Cloud
Cloudflare Workers
Fn
Kubeless
OpenWhisk
Spotinst

and supports offline development. It would also ease elm-webapp development by delegating the boilerplate code to an already established framework.
It already exists the-sett/elm-serverless that uses this tool, but I don’t think it’s actively maintained anymore and it doesn’t offer an end-to-end experience as elm-webapp does.
I hope this is helpful!

supporting deployment targets will be great but I'm very concern about dependencies upgrade rat race.
perhaps it can be done in separate repos, or various instructions.md files? wdyt?

Yes, I agree with you about dependencies management issues.
I think the best way would be to have a simple index.js and then instructions about deployment that could fit different use cases.
Could that be feasible?

... since it already supports different cloud providers:
[...]

Cloudflare Workers

[...]

Hi @MattiaVerticchio,
how is it possible to deploy it to Cloudflare Workers? I'm very interested in doing that.
And @choonkeat: Thanks for the development of elm-webapp from my side, too! Fantastic and very helpful!


Add vmId to VirtualMachine

Per customer request: https://github.com/Azure/azure-sdk-for-java/pull/619
The vmId field is available via REST - but it is not part of the SDK, to be more precise, the VirtualMachine object does not have a String vmId member, so when the REST call is returned, though available via REST, this value is not present on the virtual machine.
I need this value in order to uniquely identify this virtualMachine object - and I cannot use the id value since it is based on the vm's name.
@noaml2gitHub

@jianghaolu - thanks for the help.
I really hope this gets fixed ASAP.
Thanks again

Hi @noaml2gitHub @jianghaolu
I also asked for this in Azure Feedback forums (long time ago!) https://feedback.azure.com/forums/216843-virtual-machines/suggestions/6750343-retrieve-vm-internaluuid-from-rest-api
Let's hope it gets more interest now.

@hyonholee can you provide an update on this issue?

@hyonholee  - Can you please update here if/when you're planning of adding this?

Can someone from the Azure team please comment here about my request?

@huangpf can you take a look at this?
Thanks,
Amar Zavery
On Apr 7, 2016, at 1:35 AM, "noaml2gitHub" <notifications<EMAIL_ADDRESS>wrote:
Can someone from the Azure team please comment here about my request?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/Azure/azure-rest-api-specs/issues/188#issuecomment-206760037

OK. Got a sample here.
{
  "properties": {
    "vmId": "cbd1d46f-7336-45ff-9a04-2a020b5a228c",
    "hardwareProfile": {
      "vmSize": "Standard_A2"
    },
...

@singhkay @mahthi This is a gap to fill between API and spec (for SDKs in all languages). Please help triage. Thanks.

I believe this can be closed since #230 has been merged.

Thanks for the reply, so when will it be available in the SDK? I saw that the released version is 0.9.3 and I still didn't see this code in 0.9.4-SNAPSHOT

@jianghaolu Please help follow up with the Java SDK. Thanks.

@noaml2gitHub This is added since 1.0.0-beta2 release: https://github.com/Azure/azure-sdk-for-java/blob/v1.0.0-beta3/azure-mgmt-compute/src/main/java/com/microsoft/azure/management/compute/VirtualMachine.java#L211.
0.9.x SDKs are not generated from the swagger specs. A fix here will have no effect there.
Also, this is available in 2016-03-30 api version, while 0.9.x uses 2015-06-15.


Function filterList

We need extensions for function filterList.
Arguments:

isHtml,
isSimpleArray,
keyChildren,
keyLabel,
keyLabelCallback,
listClass,
separator,
tag
und documentation.
URL: https://ilia-brykin.github.io/aloha/#/filter-list
Translations: DE, RU

Ready. Documentation for languages DE and RU can be tested.
Russian grammar should be tested

Ok

Ready. Documentation for languages DE and RU can be tested.
Russian grammar should be tested

@zdilarr Can you please check the JSDoc for filterList?
src/filters/filterList.js
After this, we will adjust the translations again.


Add basic NameList to TOML file conversion

PULL REQUEST
Purpose and Content
This PR enables conversion from NameList Dicts to TOML files as part of the larger parameter refactoring. It does not affect how NameList or TOML are used in the current model code.
Benefits and Risks
In the future, this will be used to remove NameList usage and switch over to TOML, making for a more unified parameter file system.
However, parsing a NameList Dict into a flat TOML file requires renaming some parameters, and I am not sure what kind of naming conventions to use. ClimaParameters TOML docs also state that there is only very limited support for different types, so this will need to be expanded.
At the moment there are no risks because this doesn't change how anything is run, but removing NameList later on might cause issues for some users.
Linked Issues
 Refactor the TurbulenceConvection argument handling in ClimaAtmos #721
PR Checklist

[x] This PR has a corresponding issue OR is linked to an SDI.
[x] I have followed CliMA's codebase contribution and style guidelines OR N/A.
[x] I have followed CliMA's documentation policy.
[x] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
[x] I linted my code on my local machine prior to submission OR N/A.
[x] Unit tests are included OR N/A.
[x] Code used in an integration test OR N/A.
[x] All tests ran successfully on my local machine OR N/A.
[x] All classes, modules, and function contain docstrings OR N/A.
[x] Documentation has been added/updated OR N/A.

the created flat TOMLs from the namelists that you have converted

Can we make the toml files have only the overrides?

Can we make the toml files have only the overrides?
This would actually be better, since I'm only currently testing the overrides and the TOML files should only have overrides in practice anyway. Thanks @charleskawczynski

bors try

bors try

Alright, I think I’m fine with this after squashing, good work, @nefrathenrici!

Alright, I think I’m fine with this after squashing, good work, @nefrathenrici!

@charleskawczynski Do you mind taking a look at my rebase? I'm not sure I squashed everything correctly. 277d48c

bors try

Alright, I think I’m fine with this after squashing, good work, @nefrathenrici!

@charleskawczynski Do you mind taking a look at my rebase? I'm not sure I squashed everything correctly. 277d48c

Sure, I can help squash, I'll force push a squashed commit. Don't delete your local version!

There were a lot of conflicts, and I didn't want to mess things up so I pushed to a separate branch, here, first. @nefrathenrici, let me know if it's alright to force-push here

@charleskawczynski Sounds good to me. Thanks for the help

Oh, whoops, I forgot to re-apply the formatter. I'll do that and re-push now

LGTM. Should the project hash be reverted?

bors try

LGTM. Should the project hash be reverted?

I think it's fine, maybe it's due to adding the toml file


Swift comments are not output by the visitors

Hi, it appears that swift comments (and also whitespace) are just ignored by the various visitors, e.g. swift-ast -print-ast filename. This makes it unusable as a simple swift-to-other-language translator, which is a stated goal of the project.
How can I enable comments to be included in the output?
Thanks.

Hi @corliss, comments and whitespaces are not part of the AST, so you can't use visitor to traverse it. However, the comment content and locations can be retrieved by topLevelDeclaration.comments (https://github.com/yanagiba/swift-ast/blob/master/Sources/AST/TopLevelDeclaration.swift#L21). There is currently no easy way to restore the whitespaces, but you might be able to calculate them by subtracting the node source range and comments range.
We acknowledged its inconvenience, so @angelolloqui and I are working towards a better way to expose the comments and whitespaces for code transformation.
On another note, if your tool only requires the high-level syntax of the Swift language, I suggest you look into Apple's intuitive https://github.com/apple/swift/tree/master/tools/SwiftSyntax started 3 months ago. The transformation we will achieve here in this project is to translate the semantics of the language, instead of token replacement, if that makes sense.


TextFrame.fit_text exceptions

I realize this feature is still under development and has some constraints (as per https://python-pptx.readthedocs.org/en/latest/dev/analysis/features/txt-fit-text.html) --
I'm using python-pptx to populate a template, mostly with long decimal numbers, and fit_text runs into some problems when called on TextFrames with long strings that can't be broken up; it looks like it happens in the part of the library that calculates the text that can fit on the current line and the remainder.
If you use a PowerPoint template similar to the attached image, the following script reproduces the problem:
from pptx import Presentation

def get_target_shape(slide, name):
    for shape in slide.shapes:
        if shape.name == name:
            return shape

    raise Exception("Shape '{0}' not found in slide {1}"
                    .format(name, slide.name))

def set_autofit(shape):
    text_frame = shape.text_frame
    for paragraph in text_frame.paragraphs:
        paragraph.font.name = "Calibri"
    text_frame.fit_text(font_file=r"c:\windows\fonts\calibriz.ttf")

if __name__ == "__main__":
    ppt = Presentation("template.pptx")
    slide = ppt.slides[0]
    shape = get_target_shape(slide, "Oval 3")

    # This works, although the font size is still too big:
    shape.text = "this string is too long and needs to be resized"

    # This crashes:
    #shape.text = "thisstringistoolongandneedstoberesized"

    # This also crashes:
    #shape.text = "thisstring is toolong and needs toberesized"

    set_autofit(shape)
    ppt.save("template_populated.pptx")

(oops, attachments don't seem to work - template.pptx is a single slide containing an oval autoshape with dimensions H: 0.75", W: 1")

I've got a fix for this now that I'm working a PR for.


Removed Kanter from showcase list

The project has moved away from OrbTk.
I haven't updated the repository with the version without OrbTk yet, but I will very soon.

Ok that is a pity. Good look with your project. Nice to see it going further.

My time with OrbTk was great, thanks for everything!
Good luck with all your current and future projects. :)


Need docstrings.

Got it all working, got in a hurry, skipped writing docstrings. Need that.

completed with commit c0e6011558dcb89c8f6770fd926b93d030d28de2
Author: Drew Conner<EMAIL_ADDRESS>Date:   Wed Apr 17 19:56:25 2019 -0400
added docstrings to helper functions in resume_build.py


Handle function with return type Task

I have a lambda function that only returns Task and so I cannot implement LambdaHandler. Could a handler be added for functions with no return type? I'm changing my return type to return an int in the meantime as a hack.

Hi @patoncrispy, thank you for taking the time to open an issue !
You can use EpsagonHandler.Handle, it has an overload that takes in a Func<Task> and returns the inner Task which is your use case if i'm correct, if you have any issues with it let me know


[clkmgr] swap most clkmgr resets to lc root

only keep the clock divider logic on POR
also tweak pwrmgr fsm sequence slightly to accommodate such
a switch

This PR is dependent on #13108 , which fixes a constraint issue that surfaces after making the clock change.

@matutem i hacked around some of the DV stuff, would you mind having a look if it's okay to leave in this state or if you would prefer I did something else?

how does the latest look?


[STY] Improve object formatting in the glossary

Closes None. I'm hoping that these changes will make the glossary more useful, since we'll be linking to it more and more as time goes by.
Changes proposed:

Include object type-specific fields in glossary entries, such as "Allowed values" for enums.
Bold categories in entries.
Add format field.
Prettify the schema information.

I agree that we should link to the README more, but I'm not sure how to do that. I guess I could link to the master schema README, but I think it would be better to link to the appropriate commit's version.
I'm sure we'll update the README at the end of the sprint or some time next week.

@Remi-Gau WDYT about pushing that off until we have #1154 dealt with? That way, we can just link to another page, instead of trying to hunt down the appropriate version on GitHub?

Totally fine with me.

Cool! I'll merge this now then.


feat: add pending swap transaction to homefeed

Description
As the title. The UI already exists for this, so this PR simply dispatches the action to add standby tx after the swap has been submitted.
I added a small tweak in the swap saga to expect the to and from token to always exist in the redux state, so that we can use the token decimals etc. in the saga. This should be the case anyway, if the tokens did not exist in the redux state then the user wouldn't have been able to select them earlier in the swap flow.
I also noticed that sometimes the unvalidatedSwapTransaction returns token addresses with capital letters, so included a toLowerCase so that the token lookup can be done successfully.
Test plan
https://github.com/valora-inc/wallet/assets/20150449/cf1eaccb-fc3d-474f-ab80-57aeedad999f
Related issues

Fixes RET-894

Backwards compatibility
Y

LGTM! ⏳
But in the user flow it looks confusing enough that after cheerful "Swap success" screen we navigate to the feed to find pending animation on the tx entry.

i know 🙈 IMO it's a little better than the current situation where we say that the TX is completed but there is nothing on the homescreen. take comfort in that the flow is changing (to become non blocking after swap submit) with the new designs :)


Bot can't read old deleted messages – DiscordAPIError[10008] Unknown Message

I am encountering an issue in my bot when handling the messageDelete event. The bot works fine for recently cached messages, but for older messages or messages that are not cached, it throws the following error:
DiscordAPIError[10008]: Unknown Message

The error occurs when trying to fetch messages that have already been removed from cache, which is common in busy guilds or after the bot has been running for a long time.

The problem was solved


Document implementation breaking footnotes in rustdocs

working with a macro generating rustdoc, it is using macro quote!{ #[doc= ...]) to produce the corresponding tokenstream.
Looking at the result using "cargo expand" the generated block is added to rustdoc as block comment using "/** ....*/",  the following is a minimalistic example, the quoted doc-fragment using block-quote instead of surrounding line-quotes:
/// This is a comment.
///
/// This is a diagram[^1]:
/**
 <script> const x = 1;</script>
*/
/// [^1]: This is a footnote.
pub fn example_with_footnote() {}

This is causing a switch between line-comment style and block-comment-style. The  footnote feature is loosing the context  and footnote references are not placed correctly.

Instead of

Is there a way to tell quote!{ #[doc=..] } to produce line-comments?

I was not able to reproduce this based on that description.

Many thanks for your time, I am a bit puzzled, you are right, the minimalized example does not show the issue with the block-comment (manually added),  but still I can reproduce the issuel with the proc-macro "aquamarine::aquamarine" using quote!
I am not sure now, it might be a rustdoc issue, maybe you can tell me.
I set up a demonstrator, please execute the following two steps:
git clone https://github.com/frehberg/aquamarine-demo.git; cd aquamarine-demo/; cargo doc
firefox ./target/doc/aquamarine_demo_crate/fn.example_fail_with_aquamarine.html
The browser will show this, the footnote at bottom should not be empty

Quote is behaving correctly as far as I can tell. That #[aquamarine::aquamarine] must be doing something incorrect.


emacs orgmode org-clock bugs

(setq org-time-clocksum-format
'(:hours "%d" :require-hours t :minutes ":%02d" :require-minutes t))
this variable is not a string, cause emacs report error when using org clock.
like this.
org-clock-get-clock-string: Wrong type argument: stringp, (:hours "%d" :require-hours t :minutes ":%02d" :require-minutes t

Thanks. How can I reproduce this? I'm using org clock with this configuration, and I haven't seen this problem.

I have no ideal.
I will check this tommow.
May becouse the version of orgmode I used.
Steve Purcell<EMAIL_ADDRESS>下午1:44写道：

Thanks. How can I reproduce this? I'm using org clock with this
configuration, and I haven't seen this problem.
—
Reply to this email directly or view it on GitHub
https://github.com/purcell/emacs.d/issues/277#issuecomment-117442479.

Yes, it could be. I'm using the org-mode included in recent Emacs versions.

i upgrade my orgmode from 7.9 to 8.2
it seems everything works fine.
thanks for help☺
Steve Purcell<EMAIL_ADDRESS>上午4:36写道：

Yes, it could be. I'm using the org-mode included in recent Emacs versions.
—
Reply to this email directly or view it on GitHub
https://github.com/purcell/emacs.d/issues/277#issuecomment-117817962.

Great!


[BUG] When running NET6 WPF, it errors: Could not load type 'System.Reactive.Concurrency.DispatcherScheduler'

Describe the bug
I'm trying to test a project using the latest preview of NET6. When I launch my WPF project that uses RxUI, it crashes with the error:
System.TypeInitializationException: 'The type initializer for 'ReactiveUI.RxApp' threw an exception.'

TypeLoadException: Could not load type 'System.Reactive.Concurrency.DispatcherScheduler' from assembly 'ReactiveUI, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'.

I did some investigation and it appears as the HAS_WPF flag in ReactiveUI.csproj is limited to net5.0-windows:
  <PropertyGroup Condition=" $(TargetFramework.StartsWith('net46')) or $(TargetFramework) == 'net47' or $(TargetFramework) == 'net471' or $(TargetFramework) == 'net5.0-windows'">
    <DefineConstants>$(DefineConstants);HAS_WPF</DefineConstants>
  </PropertyGroup>

... and since HAS_WFP evaluates to false, it fails to create the dispatcher as expected.
I cloned the source and added net6.0-windows to the condition, built a test version, and it still failed. However, when I changed the <targetframework> in my csproj...
 from: `<TargetFramework>net6.0-windows</TargetFramework>`
 to: `<TargetFramework>net6.0-windows10.0.19041</TargetFramework>`

...everything works fine. I'm not sure why that is though. It was a shot in the dark based on some advice given on here to people during the migration from netcore 3.1 to NET5.0
Steps To Reproduce
Provide the steps to reproduce the behavior:

Create a NET6.0 WPF project with RxUI
Use something via RxApp (i.e. RxApp.SuppressViewCommandBindingMessage = true)
See error

Expected behavior
Run correctly on NET6 WPF instead of only NET6 MAUI (I think?).
Environment

OS:       Windows 10 Enterprise 20H2
Version   RxUI 15.1.1

Well, reviewing my post, I realize I never tried just changing my csproj:
from: <TargetFramework>net6.0-windows</TargetFramework>
to: <TargetFramework>net6.0-windows10.0.19041</TargetFramework>
The special version that added the condition to HAS_WPF seems to un-needed. I just happened to try that first and never removed it before testing the other option. Sorry for the confusion.

We are working on getting .net 6 support for Winforms and WPF via #2887 this should be ready in the next couple of days.

Yeah the 10.0.19041 is the version that code is included from Rx.net. I didn't want all the support calls about people forgetting to add that version so I added the Rx code into our repo for those doing -windows.
You can see #2887 I already handle this scenario


OCPBUGS-28548: Install ecr-credential-provider from artifacts instead of stub script

Depends on https://github.com/openshift/release/pull/48496

/retest

/override ci/prow/e2e-gcp-upgrade
Disruption
/lgtm

/cherrypick release-4.15


Runtime field-level validation in Form Validation Component

Suggestion / feature request
Hi Team
As per documentation available on ix.siemens.io, Form validation components works at a global form level(using 'was-validated' class to be utilized at form level). This means if a validation tooltip needs to be shown, it will be shown only when form is submitted. We have a requirement where we need a feature for runtime field level validation.
By runtime field level validation, we suggest something where as soon as user is typing in an input field, it is getting validated and if invalid, the ix-validation-tooltip is coming.
This field level validation comes in handy for other requirements as well, where only one field needs to be validated at a time, rather than on complete form submission.
Please consider this feature request and let us know future implementation plans for the same.

Duplicate #981


install from cargo broken

'cargo install cargo-crev' is broken. I think that published crate may not be using a cargo.lock file in the root repository making the build unstable.
error[E0107]: wrong number of type arguments: expected 0, found 1
  --> /home/ac/.cargo/registry/src/github.com-1ecc6299db9ec823/crev-data-0.4.0/src/id.rs:55:33
   |
55 |                 pubkey.verify::<blake2::Blake2b>(content, &signature)?;
   |                                 ^^^^^^^^^^^^^^^ unexpected type argument

error[E0599]: no function or associated item named `from_secret` found for type `ed25519_dalek::public::PublicKey` in the current scope
   --> /home/ac/.cargo/registry/src/github.com-1ecc6299db9ec823/crev-data-0.4.0/src/id.rs:156:56
    |
156 |         let calculated_pub_key: PublicKey = PublicKey::from_secret::<blake2::Blake2b>(&sec_key);
    |                                             -----------^^^^^^^^^^^------------------- function or associated item not found in `ed25519_dalek::public::PublicKey`

error[E0107]: wrong number of type arguments: expected 0, found 1
   --> /home/ac/.cargo/registry/src/github.com-1ecc6299db9ec823/crev-data-0.4.0/src/id.rs:169:21
    |
169 |             .sign::<blake2::Blake2b>(&msg)
    |                     ^^^^^^^^^^^^^^^ unexpected type argument

error[E0107]: wrong number of type arguments: expected 1, found 2
   --> /home/ac/.cargo/registry/src/github.com-1ecc6299db9ec823/crev-data-0.4.0/src/id.rs:188:75
    |
188 |         let keypair = ed25519_dalek::Keypair::generate::<blake2::Blake2b, _>(&mut csprng);
    |                                                                           ^ unexpected type argument

   Compiling tokio-reactor v0.1.9
error: aborting due to 4 previous errors

Some errors occurred: E0107, E0599.
For more information about an error, try `rustc --explain E0107`.
error: Could not compile `crev-data`.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `cargo-crev v0.4.0`, intermediate artifacts can be found at `/run/user/1000/cargo-installlzaEkU`

Caused by:
  build failed

Try now? There has been some crypto woes https://github.com/dalek-cryptography/ed25519-dalek/issues/69#issuecomment-475118492, and I've just pushed some workarounds to master, until proper way forward is implemented.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/224 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit fd8c4a6:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-11-19-12-58-58 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Archive_master_2019-11-19-12-58-58

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Plugin Install Error

Using Phonegap 7.1.1, when i run phonegap plugin add phonegap-plugin-push
Plugin version
2.1.1
Logs taken while reproducing problem
Failed to install 'phonegap-plugin-push': Error [ERR_UNHANDLED_ERROR]: Unhandled error. (The platform "browser" does not appear to be a valid cordova platform. It is missing API.js. browser not supported.)

@qwe123wsx remove your browser platform, install the latest, then try to install the plugin


Improve sf::Event documentation and parameter naming

Inspired by https://github.com/SFML/SFML/issues/3120. This PR improves the documentation and parameter naming of sf::Event in a few ways:

Consistently uses the "subtype" terminology to talk about event variant alternatives
Renames T template parameters to a more descriptive EventSubType and documents them
Uses backticks for inline code in Doxygen comments
Minor wording improvements

SFMLBuildMaster: Build this please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.221%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11671

Relevant Lines:
19695

💛  - Coveralls

SFMLBuildMaster: Build this please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.211%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11669

Relevant Lines:
19688

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.211%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11669

Relevant Lines:
19688

💛  - Coveralls

SFMLBuildMaster: Build this please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 56.199%

Totals

Change from base Build<PHONE_NUMBER>:
-0.008%

Covered Lines:
11673

Relevant Lines:
19694

💛  - Coveralls

SFMLBuildMaster: Build this please.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.201%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11673

Relevant Lines:
19693

💛  - Coveralls


Make rails version more explicit in gemfile

Rails was upgraded to 5.2.3 as part of #601
closes #741

Coverage remained the same at 100.0% when pulling 31bc7571d18129e42901deba3afc045d4e2453a5 on 741-rails-5.2 into ed3761b8b73bf4ab5a1e499cdbbcd670db85fd45 on master.


VS Code doesn't prompt on close if a file has been changed

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

cpptools
ms-vscode
0.10.1

csharp
ms-vscode
1.7.0

PowerShell
ms-vscode
0.9.0

debugger-for-chrome
msjsdiag
2.5.3

cmake
twxs
0.0.15

cmake-tools
vector-of-bool
0.9.2

Steps to Reproduce:

Open a file from windows explorer into VS Code
Edit the file
Close the file.
No prompt for save.

Then if I open the file again, VS code opens two windows. One with the change I made, and one without.

The first thing you describe is expected behavior. It can be controlled with the files.hotexit setting.
The second, are you saying that VS Code opens two windows with the same file, and only one instance has the change?

Why would it not ask for a file I changed? That seems busted to me. I think I may switch my default editor back to notepad++ then.
Yes. Opening the same file has the change in one window and the "old" version in another.

You can easily disable this with "files.hotExit": "off". From what I understand, notepad++ has this feature too.
It should only open one instance, with your change, though.

Well my vote would be "files.hotExit" to default to "off". Notepad++ for me doesn't behave this way and I can't find how to make it behave that way. In fact every other editor I've ever used doesn't behave this way. I can't imagine anybody would find the "hotExit" option nor think to look for it.

The conservative hot exit option is enabled by default, you can disable it completely or enable it under more circumstances in settings. You can read more about why this decision was made here https://github.com/Microsoft/vscode/issues/101, basically this was the direction because this is similar to how Notepad++, Sublime Text and Atom behave and because it's easier to switch off if you're someone who is not a fan than realize it's supported and switch it on.
You would have also received a prompt when you first exited vscode with unsaved files saying that hot exit is now the default and how you can go about disabling it.
On multiple windows opening, this is likely because one window is being restored and the other is the window that you requested to open, for example if you opened a file/folder via explorer.

So you're saying that not only is hotexit the default because people will complain about if it they don't like it, but also the other behavior is by design too.
I did this

Opened multiple files through Windows explorer
Edited some of them (over the course of an hour or so while I was also doing two other things at same time)
Closed VS Code not realizing I had not saved some of the edits. Figuring that if I hadn't, it would have prompted.
Ran some tests that depended upon said edits.
Spent half an hour trying to figure out why the tests weren't behaving
Reopened one of the files through Windows explorer

VS Code then opened two instances of that file because I happened to not have saved it.
I looked at the discussion for the hotexit https://github.com/Microsoft/vscode/issues/101 and found I agree with some of the points, but I'd still want it to prompt on exit.
Visual Studio handles this by remembering the files/tabs opened, and any unsaved files will prompted next time you open to be recovered. But it always asks when you close VS.
I don't like the idea of making edits and then I have to open VSCode again in order to get those edits back. In my situation I didn't even realize I hadn't saved the files.
I think what you should do is have an auto backup but still prompt on exit. Does this mean on reboot VS Code will not cause the machine to stop restart?

So you're saying that not only is hotexit the default because people will complain about if it they don't like it

I did not say that. For the small portion of users who don't like they can change the setting and this is a very small portion based on telemetry and tracking our feedback channels.
There's an easy fix to your preferred way of working and that's to disable the setting. We committed to the behavior change and provided a prompt to users the first time hot exit occurs that explains what it is and how to configure it. If you like Visual Studio's behavior then set "files.hotExit": "off", Visual Studio Code is not Visual Studio and the default behavior aligns with lighter weight editors that it's more similar to.
Backups are always happening regardless of whether hot exit is enabled in order to provide crash protection.

I have a better suggestion. Always keep track of the undo stack (even on close) but always be saving my files so I never have to hit save again. Although that would essentially mean an infinite history. Perhaps an undo from close to close.
I like the way onenote just saves, I stop thinking about having to hit CTRL+S in one note. I wish onenote had the full history of a note though.
At least hotExit should keep the undo stack since the last save.

Adding undo stack support is captured in https://github.com/Microsoft/vscode/issues/15135
You might also be interested in enabling auto save, that way you don't have to worry about saving your files at all: "files.autoSave": "afterDelay"


Booting Solaris from the UTM gallery gives a long error message

Created using UTMbotQuestioner: stinger1456#8045Moderator: BluDood#0001

Ah I’m guessing this is UTM SE? It doesn’t support SPARC but we should improve the error message.


close-as-unplanned looks unexpected

Description
The idea behind close-as-unplanned is great, but I think something went wrong with the design in some cases:

Does it potentially not cover the with comment case?
How to replicate the issue + URL
Screenshot is from: https://github.com/prisma/prisma/issues/21744
Extension version
23.11.1
Browser(s) used
Chrome, Version 118.0.5993.117 (Official Build) (64-bit), Windows

I can reproduce as well on Firefox, on macOS
Before entering text

With text in the comment textarea, it shows the same as what Jan mentioned. I find it confusing to have the text twice.

Now removing the text goes back to the first state, but the icon is actually missing

This has been fixed by @kidonng and will be released probably tomorrow


Question - can I initialize faster?

A WindowsSystemInfo.initWindowsInfo(). method takes around 30_60 seconds. ( in release mode either )
can I make it faster?

I just need "WindowsSystemInfo.system?.model", also "WindowsSystemInfo.system?.uuid"
but the WMI command takes a long time, how can I get those two faster?

I'll make an effort to integrate this in the upcoming version.
Currently, you can reuse the library model without initializing it. However, we advise going deep into the source code so you can reuse the library's helper functions for your use case.
Run this PowerShell command at https://github.com/Abdulazeezvp/windows_system_info/blob/7004e8d75b6eba1feeadeba1881b2ffa64dadeff/lib/src/general_helper.dart#L15 or this command prompt at https://github.com/Abdulazeezvp/windows_system_info/blob
https://github.com/Abdulazeezvp/windows_system_info/blob/7004e8d75b6eba1feeadeba1881b2ffa64dadeff/lib/src/general_helper.dart#L472 Using this function will give you a string with the information you needed.
and pass the string to https://github.com/Abdulazeezvp/windows_system_info/blob/7004e8d75b6eba1feeadeba1881b2ffa64dadeff/lib/src/general_helper.dart#L398 will return a Mapstring,dynamic> and pass this to https://github.com/Abdulazeezvp/windows_system_info/blob/7004e8d75b6eba1feeadeba1881b2ffa64dadeff/lib/models/system_info.dart#L4 The values you need will be returned by this model. Running in isolate mode is also advised.

bnag!! thanks a lot :) 👍


[1.12.2] Not playing signle MP3

Trying to pay m3u and m3u8 playlist it is not working. Then i tryed to play a single web-hosted mp3 track, and when i am pressing play button, in console i see message SERVER and no audio.

Could you copy the actual log line?
Also, please provide the mod version you're running and forge version. The url used will also help with reproducing the issue

In  my opinion the problem actually in unsupported mp3 codec. I'm trying other bitraits of same song, still don not work. Same songs in ogg working well. The mod do not support m3u playlists, he is playing only first song.
Forge: 1.12.2-<IP_ADDRESS>36
Mod: OpenFM-1.12.2-<IP_ADDRESS>
Song: http://classic.nukepowered.info:8080/music/test1/KikKuU-Flat.mp3
Log:
[11:14:26] [Client thread/INFO]: [CHAT] [OpenFM] Selected Speaker [11:14:27] [Client thread/INFO]: [CHAT] [OpenFM] Speaker Added [11:14:31] [Client thread/INFO]: [pcl.OpenFM.GUI.GuiRadio:actionPerformed:296]: http://classic.nukepowered.info:8080/music/test1/KikKuU-Flat.mp3 [11:14:31] [Client thread/INFO]: [pcl.OpenFM.network.message.MessageRadioPlaying:onMessage:27]: CLIENT [11:14:31] [Server thread/INFO]: [pcl.OpenFM.network.message.MessageRadioPlaying:onMessage:27]: SERVER


Setup Appraisal

Summary
This sets up Appraisal in order to facilitate testing multiple Rails versions.
Other Information
This has been decided here: https://github.com/github/view_component/pull/1098#issuecomment-988295192 and will allow conditional dependencies (required for Tailwind support, see #1098)

The failing checks will be solved by #1224. I'll rebase here when #1224 is merged.

Am I right in saying this would help to resolve the issue I'm facing in #1227 where we should only use turbo-rails for Rails versions greater than 5? I suppose I'd add them to Appraisals, right?

Yes, exactly!

You might also want to add Appraisals and the gemfiles folder to your section under CODEOWNERS.

Will do.


Range Param of Http Header may be Denied by Many Router

i pull a docker image from here

but when i run it use the sample code provided by funasr project, an error occured as below:

i did a lot of debug and find out the result finally. here comes the truth below:

i make a summary here:
many company have some policy to limit employees of accessing internet. so many routers was setup for this purpose.
in my situation, the range param will cause the router blocking the request to  file "am.mvn" of modelscope.
when i modify the source code of "modelscope/hub/file_download.py" and remove the "Range" parameter, everthing goes well.
the welcome screen of funasr has appeared.
i think there may be some solutions to solve this problem, because the limit of routers will always exist.
for my opinion,  it should detect wheter the range request was success or not.  may be shoud remove the range param if range request was failed. or you shoud set a value to decide whether to make a range request.  it shoud not to make a range request if the file requested was very small. this is my thought. you guys must have more advanced solutions. ：）
good luck! guys. ：）

thanks for bringing this to our attention.
agree that range should not apply for smalled files (say less than 50MB), we shall incorporate this adatatbility in later release.

@yingdachen Amazing! 🤝😄


v0.3.4 candidate

See #2527

Coverage decreased (-0.1%) to 81.952% when pulling 5fef99567028dfd9040a89ab451f0cdae767b147 on rust-av:v0.3.4-candidate into 80573d2bf733494b69c27cc3fd87f4b31e71d1d1 on xiph:0.3.

It's missing #2494.

It does not apply cleanly, help rebasing it welcome :)


Autostart and Daemonize

I really like the information provided by this plugin.  How are people setting up Linux systems to autostart the agent and run in the background?
Two problems I've encountered.  First, the path to newrelic_plugin.yml is relative to the current working directory, which makes it difficult to start via an /etc/init.d script.
Second, while I got an /etc/init.d script to work, starting the agent blocks, rather than running as a headless daemon.
How have others addressed this?

Information on starting a daemonized agent is added to the README.


Update the version for a release candidate

Per Larry's suggestion on the OCIO v2 mailing list, we should tag a version as a first release candidate to facilitate testing.  We first need a PR to adjust the version to identify itself as the 2.0.0rc1 version.
Here is the request from Larry that provides the more detailed rationale:

Really testing this in a studio setting means making an internal release, then building the various downstream packages using that release, and so on, until we can really put it through its paces.
It would be very helpful if there were versioning and tagging support for this -- for example if you could tag a "developer preview" or "beta" and set a unique version number for it. This serves several purposes for the studios who are testing:

It gives testers a hint about exactly which points the OCIOv2 dev team thinks are relatively stable testing points, versus just randomly picking whatever commit is at the top of tree (example: yesterday's top of OCIO master broke the build of OIIO, but tomorrow's will not).

If we report problems, it gives us a precise nomenclature for telling you which of several possible snapshots exhibits the problems.

It gives us a way to distinguish releases for our build and distribution process. For example, if the version today is reporting that it is 2.0.0, and that number will not change or be in any way distinguishable until the very day that the final v2 is released, how can our build systems and downstream packages tell the difference between the November testing preview, versus the final 2.0? How can we make a proper #if OCIO_SOMETHING > XYZ to do proper conditional compilation if the API or behavior changes between now and the release? How can a downstream package build request the testing previews versus the final release (once several "flavors" of 2.0 are installed on our systems)?

All the reasons that make a studio need a different reported version for 1.0.0 and 1.0.1 also make us desire unique reported versions for testing previews.

Thanks this is great, I can now point to a particular version :)

Following discussion at the TSC, it was decided to use 'beta1' rather than 'rc1' for this first tag.  This has now been implemented.  The tag (on the master branch) is 'v2.0.0-beta1'.


Add tours for the general metagenomics tutorial

ping @shiltemann
You can test them on any Galaxy instance with the tourbuilder extension

cool! :)

awesome, thanks for making these @bebatut :)

@shiltemann It was a good way to test in depth the tourbuilder extension :)
Can we merge this one?


Can compile the go pow to run on gpu?

From what I have heard, the GPU support in the Giota library does not work properly and produces incorrect hashes. So, unfortunately, that is not possible right now.


Add the modularScale helper

Adds the modularScale helper using the lovely simple-modular-scale package by jxnblk. (not tagged so he doesn't get annoyed by the notification)
Also implements caching the computed scales so we don't recompute the scale everytime somebody requests the same one with different steps. I have not benchmarked this or anything, but essentially the second time somebody gets a value from a scale with the same base and ratio the function is just an array lookup; that should be much cheaper than recomputing the entire scale for every single value! :tada:
I was talking absolute bullshit, we don't need a module for this, simply doing base * ratio * steps is good enough. Fixed and vastly simplified in the last commit!

CI is failing due to these totally unnecessary rules since they are actually documented in the flow types:
  49:1  error  Missing JSDoc @returns for function  valid-jsdoc
  49:1  error  Missing JSDoc for parameter 'steps'  valid-jsdoc
  49:1  error  Missing JSDoc for parameter 'base'   valid-jsdoc
  49:1  error  Missing JSDoc for parameter 'ratio'  valid-jsdoc

Should we just disable that eslint rule and merge it into master to fix this?

Uhh, something went really wrong here with the commits 😱 any idea how we can resolve this? I obviously did something wrong 😕

You could cherry pick your modular scale commits onto a new branch from master and do a new pull request. Would probably be the easiest way. If you wanted to keep this PR you could force reset it to master, and  then cherry pick those commits back onto it.

Current coverage is 100% (diff: 100%)

Merging #45 into master will not change coverage

@@           master   #45   diff @@
===================================
  Files          11    12     +1
  Lines          30    40    +10
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits           30    40    +10
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 6ce39a5...6da9841

Replaced by #48!


Support for compressed MFEM-format mesh files?

I've run into an interesting problem while prepping some larger production runs I'm planning on doing where I've got around a 27e6 element linear hex mesh. I've noticed that when saved this mesh is around 3 GBs in size using the MFEM mesh file format v1.0. So, I was wondering if there was a way to save this off in a compressed format that could later be read and then have some pre-processing done on it like suggested within #934 (also where that could be saved off in a compressed format) before I run these on a HPC system like Summit?
Alternatively, do you know if the CUBIT file format can be read in the parallel? I might be able to convert mesh over to that format with the parallel partitioning already done on the CUBIT side of things, and then load the mesh up that way in parallel. Although, I might run into some issues related to having to define the boundary element attributes over again.

If you build with MFEM_USE_ZLIB you can just gzip e.g. the mesh file and read it with the ifgzstream classes. I believe this "just works" in example 1:
> gzip ../data/escher.mesh
> ./ex1 -m square-disc.mesh.gz

There is also compression in @pazner's ParaView output, though that's just for visualization.

Alternatively, do you know if the CUBIT file format can be read in the parallel? I might be able to convert mesh over to that format with the parallel partitioning already done on the CUBIT side of things, and then load the mesh up that way in parallel. Although, I might run into some issues related to having to define the boundary element attributes over again.

Right now it is not possible to read a pre-partitioned exodus mesh. But that was a good reminder to put that on the todo list.

The outstanding item here is to create a miniapp that can partition a parallel mesh in P pieces and save the P files so they can compressed and read later in parallel.
We can do that now if the miniapp runs on P MPI tasks, but it is desirable to be able to run the miniapp with less MPI tasks (and maybe even a single MPI task).
Anyone interested to take on this?

The parallel mesh format read/write example is here: https://github.com/mfem/mfem/pull/1561/files#diff-acdeb0d83bfa7eabdf562ce5149e36fb

This has been taken as in internal todo item.

See https://github.com/mfem/mfem/pull/2669.


Microsoft Teams Rooms Pro Management

Proposed name of the new command
rooms
Description
Microsoft Teams Rooms Pro Management
The Microsoft Teams Rooms Pro Management service is a cloud-based management solution that proactively monitors and updates Microsoft Teams Rooms devices and their peripherals. The Pro management solution is for organizations looking to optimize meeting room experience for end users and rapidly scale their footprint enabled by real-time monitoring and management for Microsoft Teams Rooms devices.
Category
Microsoft Teams
Url
https://portal.rooms.microsoft.com/

Done


Caching images from disk?

First of all, great work here @onevcat 🍻
I was wondering if Kingfisher allows for loading and caching images from disk (local paths) as well as downloading. Maybe I skipped some part of the docs where it's said, but I can't quite find it.

Hi,
The main purpose of Kingfisher is downloading/caching images from web. Since you can use the components in Kingfisher separately, there is an ImageCache type to help you manage the cache for images, either from web or local. However, there is not a component to load a local image directly currently. You may need to use image APIs from Cocoa/CocoaTouch to load an image and then send it to the ImageCache, if it is not already in the cache.

Sounds about right. Would you be interested in somebody implementing this particular feature? I think it'd be a nice thing to have within the main framework.

Hi,
Thanks for considering to contribute! We could discuss it.
In fact I am not quite sure about whether it could be useful to have a feature to load from local disk. It will not boost your loading process.
If you are using UIImage(named:), the image will automatically cached in memory. If you are using a path or data object to create an image, it could be also very easy to implement a cache by using NSCache, instead of introducing a lot of unrelated (web-oriented) code from Kingfisher.
Could I know something more your use case? Why do you need to cache an image from disk which is already there?

In my case, my app handles images coming from both disk and web (like iCloud Photo Library optimization behaves), so it'd pretty convenient not to have to worry about the source of the images when loading and displaying them. I could build some abstraction on top of Kingfisher and my own local caching mechanism, but I like how other caches provide this out of the box (e.g. Haneke).

Ah,
Yes, it makes sense that you have a mixed source of images.
Sure, it could be a useful feature in your case to have a framework to handle. Since I am not quite familiar with loading an image from photo library or iCloud, I will investigate them first to see whether we could keep using current API for it as well as make it back compatible. If not, we may need to add some new APIs for it.
And cool, if you'd like, a p-r for this will be warmly welcome! :)

I wasn't actually meaning loading photos from iCloud or the photo library, but rather loading them from a local path (Documents folder). I don't believe this would require any breaking changes, just a new mechanism similar to KingfisherManager.sharedManager.downloader.

Hi there,
I would like to be able to determine synchronously whether I can immediately access a cached image. I don't want to wait for an async block to complete (albeit very quickly if cached—or at indeterminate length if downloading) before deciding how to proceed. I think this is along the lines of your discussion. Any suggestions? Thanks!

The ImageCache for disk is not using the main queue for IO, so there is no synchronous way to load image from disk safely. The only reliable method of loading an image is retrieveImageForKey(_:options:completionHandler:). You could use it at any time to load an image correctly, even you just add it into the cache.

First of all, great work here @onevcat 🍻
I was wondering if Kingfisher allows for loading and caching images from disk (local paths) as well as downloading. Maybe I skipped some part of the docs where it's said, but I can't quite find it.

i think you need this for locally image show on image view:-
extension KingfisherWrapper where Base: ImageView{

    public func setLocalImage(withUrl url: URL?){
        if let url = url{
            do {
                let imageData = try Data(contentsOf: url)
                self.base.image = UIImage(data: imageData)
            } catch {
                print("Unable to load data: \(error)")
            }
        }
    }
}

@jaipee1 Thanks for commenting. But now for Kingfisher 5, we have a LocalFileImageDataProvider for this task, which works better and seamlessly with existing Kingfisher features. See this.


NFS mount Read-only file system

Hello
I have new in ceph. I user branch reef to run ansible preflight and follow step from  https://docs.ceph.com/en/latest/cephadm/install/#install-cephadm .
Now kube csiand object it work but cephnfs can mount  with Read-only file system.
Have anyone cah help me.

Sorry but this is unrelated to cephadm-ansible.


Post release automated changes for network releases

Post release automated changes for azure-arm-network

API change check
API changes are not detected in this pull request.


Failed sending configuration

The previous problem has been well solved with your help. Thank you very much. Now there are two new problems. The configuration file cannot be sent to the board. I use iwr1642 and mmwave_ sdk_ 03_ 05_ 00_ 04, which is slightly different from what you use, so do I need to change the configuration file.
In addition, during flash operation, the console only displays' Ping mmwave ', and the version information should be displayed according to the code.
Such as' get version...
          Done

          Version:

          Done’

Thanks again!
hfutball

Are SOP0 and SOP2 closed?

I tried another board iwr1843, and the flush was normal, but I still couldn't send the configuration successfully

Are SOP0 and SOP2 closed?

I tried another board iwr1843. The flash writing was normal, but I still couldn't send the configuration successfully.

Have you removed jumper from SOP0 after flashing, and restarted the power?

I have solved this problem and completed the reproduction with your help , thank you for sharing such a perfect source code.

Hello vilari-mickopf and hfutball.
When I see your problem, I find that the problem is the same as mine.
I'm also using 1642, but when I turn off SOP0 and 2 in Ubuntu, I can write.bin files to flash and execute start normally. However, flash cannot be executed in Windows.

After I wrote the.bin file to flash in ubuntu system, I directly executed the start command in Windows system and found that sending the configuration file failed.

I am very sorry to bother you and look forward to your reply.

Have you removed SOP0 after flashing?

It's been removed

I have no win on my pc, so this is only tested on linux. I remeber testing it once on windows few years ago, and it worked, but i do remeber that data and cli ports have been in reverse order, so i've added this to console's mmwave_init method:
if platform.system() == 'Windows':
    ports.sort(reverse=True)

Maybe there is no consistency with the order of detected ports in win, so you can try and comment that. If that's the case, then you will have to connect your board manually every time (there is connect option).
Also, i will push a lot of changes soon (probably beginning of the august) so there might be some fixes for your issues.

Also, just to be sure, you have reseted the board after removing sop0?

After I removed SOP0, I reset both the data cable and the power cable.
I'll try it now, manually connecting the port.

I changed True to False, can do flash, and can do start and send configuration files
if platform.system() == 'Windows':
ports.sort(reverse=False)

Thank you very, very much for your answer.

Yup, order of detected ports in windows is unreliable then. This means flashing will probably work as well on win with this change.
There is not much that can be done by me in terms of making connection automatically. For cases like this i have implemented connect option in console which will let you manually select port/rate for cli/data. I will add some small q/a section, explain this issue and how it can be solved.

Actually, in new version of the code i am checking the baudrate of the connection, and if detected baudrate is different than selected one, i warn the user about it. However, this auto rate detection can only be done for open ports, and before sending sensorStart command to the board, data port is closed. But still, if ports are reversed, it should be detected that selected baudrate for cli is not good, and that can indicate this issue, stop autoconnection, and force the user to connect manually.

Yes, there is a lot of uncertainty about automatic connection. Different devices have different problems. Manual connections avoid this problem to some extent.


PEP572

THIS is compelling!

https://github.com/Xython/YAPyPy/issues/17

emmmm, copy all tokenizer for a spec version =、=

change it straight


ISSO_CORS_ORIGIN doesn't work as advertised

According to the documentation, you can use an ISSO_CORS_ORIGIN environment variable to set e.g. wildcards for the Access-Control-Allow-Origin CORS header. However, it doesn't work in practice, because the code that uses it is as shown in this fragment:
    def func(environ):
        if 'ISSO_CORS_ORIGIN' in environ:
            return environ['ISSO_CORS_ORIGIN']

However, the environ passed into func() is a restricted WSGI environment (request.environ) rather than the full process environment (os.environ). Therefore, the code should use os.environ in the above fragment rather than just environ. Or is there some other way that an ISSO_CORS_ORIGIN OS environment variable is supposed to find its way into a request.environ?

Using ISSO_CORS_ORIGIN=*.example.tld as written in isso's documentation is seemingly against spec anyway, see this Stackoverflow answer.
I've prepared a branch that rectifies isso's behaviour, see ix5/isso@cors-from-os-environ but that will still result in browsers refusing wildcard subdomains.
The correct way to do this would be to check if the originating URL matches the wildcard of ISSO_CORS_ORIGIN and then return a fully qualified URL (with everything after and including the slash chopped off).

This is strange...
On my side, it works fine:
$ cat /etc/systemd/system/isso.service
[Unit]
Description=isso comments daemon

[Service]
Environment=ISSO_CORS_ORIGIN=*.chezsoi.org
WorkingDirectory=/usr/share/nginx/html/lucas/isso
ExecStart=/usr/local/bin/pew in isso isso -c isso.cfg run
Restart=always

[Install]
WantedBy=multi-user.target

$ curl -v -o /dev/null 'https://chezsoi.org/lucas/isso/?uri=/lucas/blog/pages/bienvenue.html'
...
< access-control-allow-origin: http://chezsoi.org

@ix5 Maybe you could create a PR from your branch?

CORS
First off, a bit of explanation how CORS is supposed to work, since there might have been a few misunderstandings that lead to this.
CORS stands for "Cross-Origin Resource Sharing". It is implemented as a series of HTTP headers called Acces-Control-Allow-Origin (and related ones, see code snippet below).
It is essentially a mechanism to avoid bad actors sniffing credentials or running non-idempotent actions such as PUT or POST by sending credentialed(!) XmlHttpRequests to your domain.
Example: You login to service.example.com, receive a login cookie. You visit evil.site, which makes an XmlHTTPRequest POST request to service.example.com/deleteAccount with {confirm: yes} using the browser's cookie jar for service.example.com.)
Note that modern browsers have other layers of security to prevent this.
Before the browser allows a request from a JS context (and others? not sure) to succeed, it will send an OPTIONS request with the originating URL to the target server, which is then supposed to check if the originating URL is in its allow-list for that resource and answer with an Access-Control-Allow-Origin header that matches the protocol+domain+port part of the originating URL (i.e. with path information stripped), or, if the URL is not allowed to request that content, the default server URL.
If you want to defeat the whole purpose of CORS, you can also return a wildcard with a literal * as the header content. Note that *.mydomain.com however is not a valid response!
For further information and a better explanation, see MDN: CORS.
Isso Implementation
Since Isso is commonly served from a subdomain or maybe even from other domains, CORS is needed for modern browsers.
The part that implements CORS in Isso is inside a "middleware" which modifies werkzeug requests on-the-fly:
https://github.com/posativ/isso/blob/568debf6737d2f3462bdd9baa5ace45031b8ed95/isso/wsgi.py#L125-L137
This appends the result of the origin() function call as a header to the request.
https://github.com/posativ/isso/blob/568debf6737d2f3462bdd9baa5ace45031b8ed95/isso/__init__.py#L134-L135
The list of hosts is constructed from your [general] host config list:
https://github.com/posativ/isso/blob/568debf6737d2f3462bdd9baa5ace45031b8ed95/isso/__init__.py#L204-L207
Finally, the origin() function checks if the request origin is in the list of allowed origins, else returns invalid.local or the first host in the allowlist:
https://github.com/posativ/isso/blob/568debf6737d2f3462bdd9baa5ace45031b8ed95/isso/wsgi.py#L66-L92
This is the critical part, Isso already does the right thing for you:
https://github.com/posativ/isso/blob/568debf6737d2f3462bdd9baa5ace45031b8ed95/isso/wsgi.py#L86-L88
This compares the request (with path and query stripped) against the [general] host config items and returns the first match.
Conclusion:

Options
I've thought about this for a bit and came to the following conclusion:
The most sane way of running Isso is either a) via a WSGI server or b) through a WSGI server behind a reverse proxy, which might or might not do TLS termination, or c) via the built-in isso server. Supporting other configurations should be "beware dragons" territory - not "forbidden", but not actively encouraged either.
For a) Isso will already know the request origin, so no issue here
For b) Isso should know the request origin, since anything else than a transparent proxy is probably a misconfiguration and will bring problems later on.
Example transparent proxy config:
proxy_set_header Host $host;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_pass http://<IP_ADDRESS>:8080;

At least the Host info should be passed to the proxy (=Isso). Isso cannot figure out the right thing if you don't let it know which environment it is running inside. Solving that shortage of information via config options as requested by @vsajip in https://github.com/posativ/isso/issues/735 is not smart and doesn't solve the root issue.
For c) Isso will also already know the request origin, also no issue here
It isn't worth it to introduce another config for people to pair hosts with CORS responses. The proper way is to pass the original request URI all the way through to Isso.
Decision
We should remove the ISSO_CORS_ORIGIN env variable and accompanying docs (you can revert both of those commits). Then, document that Isso will already do the correct thing and ensure consistency regarding proxies in the docs.

Very detailed explanation, thanks @ix5 !
While I knew well about CORS, your comment is utterly accurate and a very nice refresher on how isso handle things.
For the record, I originally wanted to be able to use my self-hosted isso instance at chezsoi.org from a website hosted at subdomain.chezsoi.org. This was this original motivation behind #393.
Hence I think there is a valid use case behind ISSO_CORS_ORIGIN,
but I'm OK with either fixing it or removing it.

For the record, I originally wanted to be able to use my self-hosted isso instance at chezsoi.org from a website hosted at subdomain.chezsoi.org. This was this original motivation behind #393.

So you mean you wanted to avoid listing all possible sites where you would allow commenting and embed the embed.min.js from? I.e. not have this:
[general]
host =
    subdomain.chezsoi.org
    baguette.chezsoi.org
    chezlucas.chezsoi.org
    brioche.chezsoi.org
    [...]

But instead of ISSO_CORS_ORIGIN=*.chezsoi.org.
I can see why you would want that, since that syntax is valid for e.g. CSP headers, but IMO there aren't too many users out there who have more subdomains than they could list in the conf file.
Happy to be convinced otherwise, but that's where I currently stand on this.

That's exactly what I wanted yes 😊
Could this host configuration entry by used for other purposes than CORS HTTP headers?
For example, it is used in SMTPConnection and in the HTTP connection check in make_app.
I wonder if adding hosts there could have unexpected consequences.

Could this host configuration entry by used for other purposes than CORS HTTP headers?
For example, it is used in SMTPConnection

[...]
self.conf = isso.conf.section("smtp")
[...]
with SMTPConnection(self.conf):
[...]
        klass = (smtplib.SMTP_SSL if self.conf.get(
            'security') == 'ssl' else smtplib.SMTP)
        self.client = klass(host=self.conf.get('host'),
                            port=self.conf.getint('port'),
                            timeout=self.conf.getint('timeout'))

Different host, this one is from the [smtp] section:
https://github.com/posativ/isso/blob/568debf6737d2f3462bdd9baa5ace45031b8ed95/share/isso.conf#L133-L148

and in the HTTP connection check in make_app.

Only uses the first reachable host for a one-time connectivity check.

I wonder if adding hosts there could have unexpected consequences.

That's... honestly never been a concern to me ;)

Alright 😊
Then go and nuke that useless configuration setting !

Maybe you could also use some bits from your excellent comment above in order to better explain CORS handling in isso docs?

Would you mind helping out with that? I don't mean to bully you into spending time on this project you're ready to spare, but me committing most of the code to this project as of late, with practically no one pushing back or looking over the code, is something I'm not really comfortable with.
It isn't sustainable in my eyes, and as you've probably already experienced yourself, interest in OSS contribs comes and goes in waves ;)

I'm OK to review a PR that would do the cleanup

The change is already merged, see https://github.com/posativ/isso/pull/803

[but] I cannot promise to take the time to submit it myself anytime soon

Don't worry, thank you for your review for the webpack and Jest migration so far, that's also much appreciated! The only thing missing now is an entry into the docs that kind of integrates my previous remarks about CORS.


Leader Migration to GA

This PR updates the documentation as a result of GA graduation of Leader Migration.
https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/2436-controller-manager-leader-migration

This one is risky. Not sure if it will make its way into 1.24.

This was discussed and approved in the SIG meeting yesterday: https://docs.google.com/document/d/1KLsGGzNXQbsPeELCeF_q-f0h0CEGSe20xiwvcR2NlYM/edit

/assign @jimangel
Could you take a look?

/approve

/assign @cheftako @jpbetz
could you take a look too?

/remove-area blog

/milestone 1.24
/assign @chrisnegus

Hello, this is a friendly reminder from the 1.24 docs release team that the Docs’ complete deadline — All PRs reviewed and ready to merge — is EOD Tuesday, April 12th, 2022. Please finish up any remaining technical reviews and edits, and reach out if you need any help.

/lgtm


Fix exception string to include a missing word

Tiny change, the string was missing a word so the message was not clear.

Thanks! 👍


docs: clarify imports for useTable core examples

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:
This PR adds import statements to the useTable documentation under Core API/Hooks/useTable, as some properties are only available with import { useTable } from "@refinedev/core". For example, changing examples such as:
useTable({
    pagination: {
        pageSize: 20,
    },
});

to:
import { useTable } from "@refinedev/core"
useTable({
    pagination: {
        pageSize: 20,
    },
});

Explain the details for making this change. What existing problem does the pull request solve?
It was confusing for myself while using the useTable hook referencing the examples without clarifying which packages to import.

Test plan (required)
Demonstrate the code is solid. If not, please add WIP: in its title.

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Self Check before Merge
Please check all items below before review.

[x] Corresponding issues are created/updated or not needed
[x] Docs are updated/provided or not needed
[x] Examples are updated/provided or not needed
[x] TypeScript definitions are updated/provided or not needed
[x] Tests are updated/provided or not needed
[x] Changesets are provided or not needed

Closes: #5216


Blueprint Support

Hey, I need to use Flask-Discord in a blueprint but I am not sure if that is possible.
I get the error AttributeError: 'Flask' object has no attribute 'discord'  and I think its because it uses current_app instead of the blueprint itself.
Thanks

Hello, I had the same problem with quart_discord.
All you need to do is move
discord = DiscordOAuth2Session(app)

to your main file, and then import discord from main in your blueprint file.
Also to prevent circular imports remember to wrap import of blueprint and app.run() in if statement, something like that
if __name__ == "__main__":
    from blueprints.api import api
    from blueprints.dashboard import dashboard

    app.register_blueprint(api)
    app.register_blueprint(dashboard)

    app.run(host="localhost", port=5000, debug=True)

For me it works perfectly
Your blueprint should look like that
...
from flask.blueprints import Blueprint
from main import app, discord

dashboard = Blueprint('dashboard', __name__, url_prefix='/dashboard', template_folder="../templates/dashboard/")
...

And your main
app = Flask(__name__)

...

discord = DiscordOAuth2Session(app)

if __name__ == "__main__":
    from blueprints.api import api
    from blueprints.dashboard import dashboard

    app.register_blueprint(api)
    app.register_blueprint(dashboard)

    app.run(host="localhost", port=5000, debug=True)

Hey, thanks for your reply. I fixed the issue in the end by just using oauthlib and doing it from scratch just because for my case, I can't have discord imported in the main file.


Does macOS still need 'legacy' Ogre2RayQuery path force-disabled?

This discussion is about Garden and/or later.
Ogre2RayQuery uses the GPU when possible to perform ray queries.
However currently this path is disabled for macOS:
#ifdef __APPLE__
  return this->ClosestPointByIntersection(_forceSceneUpdate);
#else
   ...
#endif

I strongly suspect the cause was either that OpenGL3+ path was malfunctioning on macOS, or that we didn't have the proper Metal shaders for SelectionCamera (which we should now, because the code was moved from using Low Level Materials to Hlms pieces for Garden).
In other words, if I'm right, using the GPU path for Metal should "just work".
The "legacy" version is still needed; in fact the Lens Flare effect I'm working on needs to force it (I'm adding an API to set whether using the GPU is preferred).

Can we just enable it with metal in CI and see what happens?

Yeah, I was also thinking we could do just that.

Can we just enable it with metal in CI and see what happens?

+1. It was disabled because the test was failing. I remember it was with OpenGL3+ and we didn't have proper metal support at the time. So we should just try enabling it.

enabled in https://github.com/gazebosim/gz-rendering/pull/758


removed stackgres-operator due to wrong naming

Hello, we would like to remove the operator due to a wrong naming of the folder is it possible?

As written, this PR would remove all versions of the operator from this GitHub repo. Do you also require unpublishing the operator from the OpenShift OperatorHubs?


Add optional adminuser and fix ads join error

thank you for the pull request ^^

I've done the necessary testing.
The new version (0.2.0) is available on puppetforge
thank you again ^^


Enable Reinitialize causing an infinite loop

Are you submitting a bug report or a feature request?
Bug report
What is the current behavior?
When onChange is passed a function that modifies the value that is passed in to initialValues AND enableReinitialize is set to true, this is triggering an onChange action with outdated initial values. This causes an infinite loop with the form continually calling onChange using the previous value.
What is the expected behavior?
The expected behavior is that when enableReinitialize is set to true, it should not trigger an onChange event when reinitializing values. The context for this expected behavior is a form that updates optimistically but ultimately is reinitialized with the value that is returned from an API call. This will make the form stay in sync with the DB.
Sandbox Link
https://codepen.io/anon/pen/JawaGp
What's your environment?
Redux Form Version 7.4.2
Google Chrome Version 69.0.3497.100

Any reason you're setting onChange={...} on <Form> instead of on <Field>? I think that might be the cause of your problem

confirmed on Formik v2.1.4

@handhikadj is related to redux-form?

@iamandrewluca sorry. i thought this post was about formik. really sorry. I will delete it


Can't enter location for meetup

Subject: Can't enter location for meetup
Description:
Nothing. Why did I have to do something? It says "please enter or click the icon, then select a location from the list. There is no list.
Results:
Evidently, a list should have appeared. But none did. And the page won't accept the location I typed in.
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Page: https://couchers.org/event/new
User: bobl (859)

not enough info or can't reproduce


Random User Generator #339

Hi @991rajat, I completed task #339 please reviews the code. I have added some screenshots hope you can help in the code review

Hey @Vishal-raj-1  Please Review the code I have completed #339 task

Good Work
Resolve the conflict please.

Congratulations of merging of your first PR. :tada:
Keep Contributing


added simple POST support for monkey testing

added simple POST support for monkey testing. pls merge.

Merged the pull request, will add some unit tests later.


Html is empty

I made a main.html file and app.py file. Chrome is opening but that window is empty. My main.html is that:

	<title>My title</title>

Hello!

But when I run the app.py, the html of opened window is always that:

	<title>App</title>

Thanks for helps.

It is very interesting that i am renamed html file as main.html to myhtml.html and edit that
 ell.start('main.html')

to
ell.start('myhtml.html')

and it is working now. I wonder why??

I'm having some similar issues where eel.start("main.html") is referencing older or cached? versions of main.html and the associated js and css files and not the current files

I agree it sounds like a caching issue. I have a feeling that caching should be disabled by default. I'll investigate - hopefully this weekend - and find out what's happening.
Can you share what version of Eel you're using please?

I managed to work around the issue by just disabling caching in chrome and refreshing the page with CTRL-F5. The eel version I'm using is 0.10.4

I think 1.0.0 switched to defaulting to caching off

@ChrisKnott we've only released pre-release v1.0.0-a1 actually - so people installing via pip install eel probably won't be getting it. Might be time to bump it up to a full v1.0.0 so that everyone gets it by default.

I'm going to include the "default to caching off" in a v0.11.0 release. While this is technically a breaking change, given that we're below v1.0.0 and we think it's generally useful for most users, I think it's acceptable.
I'll close this issue off when I've released v0.11.0


Clarify how the grid calculation functions works

The function grid-width was unused but defined. I renamed it to flex-width to be consistent in naming with the other grid functions and used it to calculate the width values that are used in flex-grid and flex-gutter because the way these calculations work is always the same.

Hhhhm, I don’t know why the CircleCI build fails. I ran the tests locally with Ruby 1.9.3-p448 and I get a lot of deprecation warnings like in CircleCI:
DEPRECATION WARNING:
Sass 3.5 will no longer support Ruby 1.9.3.
Please upgrade to Ruby 2.0.0 or greater as soon as possible.

But all tests are fine.

@tow8ie good catch. Looks like someone got started on that function but never wrapped things up. I ran my test on this branch locally and everything passed. Can you rebase this off master and as long as Ci chills out, we'll merge

@whmii ✅ Done.

thx. merging


Please document PIPELINE_ENABLED in directions for upgrading to 1.4

The flag is being used in a different way from 1.3, which creates a backwards incompatibility in some set-ups:
http://stackoverflow.com/questions/27771184/x-amz-acl-being-set-incorrectly-when-using-collectstatic-with-latest-version-of
Thank you!

PipelineMixin don't use PIPELINE_ENABLED anymore, so I guess this is not a problem anymore.


[Feature Request] A way to add Javascript or CSS to just one Operation page, for a particular CRUD

Feature Request
What's the feature you think Backpack should have?
We already have a way to add Javascript or CSS to ALL admin panel pages.
And developers can also:

edit the public/packages/backpack/crud/js/create.js file for example, to add some JS to the Create operation;
edit the public/packages/backpack/crud/css/create.css file for example, to add some CSS to the Create operation;

But because there's this one css/js file for that operation, it gets loaded for ALL CRUDs. Which is not what you need, sometimes. I think we could use a more flexible way of including custom CSS/JS files inside operations.
How about if we create a Widget that allows you to push things inside the before_styles, after_styles, before_scripts and after_scripts stacks? The way I see it, you could do something like:
    // To include custom JS from a blade file
    Widget::add()->type('script')->stack('after_scripts')->view('path.to.a.certain.view');

    // To include custom JS from a JS file - public/assets/js/some_custom_thing.js
    Widget::add()->type('script')->stack('after_scripts')->file('assets/js/some_custom_thing.js');

    // To include custom CSS from a blade file
    Widget::add()->type('style')->stack('after_styles')->view('path.to.a.certain.view');

    // To include custom CSS from a CSS file - public/assets/js/some_custom_thing.css
    Widget::add()->type('style')->stack('after_styles')->file('assets/css/some_custom_thing.css');

I think the above would be pretty easy to create as a non-breaking change. And it would allow a lot more flexibility. I'm open to different ways of implementing this - the Widget solution is something I just came up with.
Alternatively (or additionally) we could create a syntax inside CRUD that also does the above:
CRUD::addScriptFile('assets/js/some_custom_thing.js');
CRUD::removeScriptFile('assets/js/some_custom_thing.js');

CRUD::addStyleFile('assets/css/some_custom_thing.css');
CRUD::removeStyleFile('assets/css/some_custom_thing.css');

Not sure this is needed though - it might complicate the process unnecessarily, when behind the scenes it's doing the same thing - adding a widget.
Have you already implemented a prototype solution, for your own project?
No
Do you see this as a core feature or an add-on?
Core Feature

PS. This could be a possible alternative to https://github.com/Laravel-Backpack/addons/issues/11 and https://github.com/Laravel-Backpack/CRUD/pull/165
Rather than adding a new field to toggle stuff, you could add a Javascript file to the page in question, and inside the Javascript file you'd code the logic you need. It wouldn't be as fast as the add-on, but it would definitely be more flexible.


[feat] add the ability to check if the AsyncSignal is initialized or not

i don't know if that possible or not but i came around a use case that i get some events from a socket and upon this event i should update an AsyncSignal
i say should because if the user isn't in that screen where this AsyncSignal is used, then there's no need to create/access this signal and update it since it's not initialized
what do you think Rody ?

For signals you should always update the value. Even 1000s of time a second.
Updating a value does not always result in effects.
If you update a signal but no one is watching or listening then no computations happen.
In other words you have signals for all the places where values change over time, and you query them in UI or setup effects or change detection