Refactor signature code

Separate low-level signing code from encoding and formatting code once and for all. (:
This makes the code more readable and less confusing, and will hopefully saving a good bit of encoding debugging time....
This TUF fork PR should be applied in tandem (so the build may fail, since it won't do that).

Comments addressed (along with some changes made to respond to your comments made on the TUF PR which are equally applicable here).

I had one or two additional review comments.  Other than those, this LGTM.


Keerthiyanda/spark3.4

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

Codecov Report

Merging #2052 (6b1bb0d) into master (c6d5882) will decrease coverage by 10.48%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           master    #2052       +/-   ##
===========================================
- Coverage   87.07%   76.60%   -10.48%
===========================================
  Files         306      306
  Lines       16063    16221      +158
  Branches      852     1456      +604
===========================================
- Hits        13987    12426     -1561
- Misses       2076     3795     +1719

Files Changed
Coverage Δ

...a/com/microsoft/azure/synapse/ml/nn/BallTree.scala
83.17% <ø> (+0.32%)
:arrow_up:

...spark/ml/recommendation/RecommendationHelper.scala
36.70% <0.00%> (-50.14%)
:arrow_down:

...osoft/azure/synapse/ml/core/env/PackageUtils.scala
100.00% <100.00%> (ø)

...se/ml/exploratory/DistributionBalanceMeasure.scala
96.42% <100.00%> (+0.06%)
:arrow_up:

.../azure/synapse/ml/io/binary/BinaryFileFormat.scala
98.86% <100.00%> (ø)

...spark/ml/source/image/PatchedImageFileFormat.scala
89.28% <100.00%> (-1.46%)
:arrow_down:

... and 104 files with indirect coverage changes

/azp


Add client_config to Speech factory methods

Add client_config to Speech since it uses GAPIC/GAX, and remove non-functional retries.

Appreciate the quick action @blowmage! LGTM, will merge when green.


Semantic versioning

Hello,
I think to have a better change management, this role should be driven with releases and/or tags using the semantic versioning (ex: 0.1.0) ?
What do you think about that ? If you're agree, can you set the first release/tag please ?
Thanks

I think this is a great idea. I'll create the first tag as 1.0.0.

I just pushed it out. Previously I've been using the commit id, but usually do prefer tags. Closing this issue.


New version: MSI.Kombustor.4 version 4.1.27

Pull request has been created with komac v2.0.3 :rocket:

Resolve: #137774

Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

/AzurePipelines run


replication slot does not exist

PGSync version: 1.1.31
Postgres version: 13.1
Elasticsearch version: 7.10.1
Redis version: 6.2.1
Python version: 3.7
Problem Description:
After updating from 1.1.29 version to 1.1.31, pgsync throws the following error:
pgsync_1         | 2021-04-04 22:25:01.642:ERROR:pgsync.base: Exception (psycopg2.errors.UndefinedObject) replication slot "test_items" does not exist
pgsync_1         |
pgsync_1         | [SQL: SELECT xid, data
pgsync_1         | FROM PG_LOGICAL_SLOT_PEEK_CHANGES(%(PG_LOGICAL_SLOT_PEEK_CHANGES_1)s, NULL, NULL)
pgsync_1         | WHERE CAST(CAST(xid AS TEXT) AS BIGINT) < %(param_1)s]
pgsync_1         | [parameters: {'PG_LOGICAL_SLOT_PEEK_CHANGES_1': 'test_items', 'param_1': 3334}]
pgsync_1         | (Background on this error at: http://sqlalche.me/e/14/f405)
pgsync_1         | Traceback (most recent call last):
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1706, in _execute_context
pgsync_1         |     cursor, statement, parameters, context
pgsync_1         |   File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 691, in do_execute
pgsync_1         |     cursor.execute(statement, parameters)
pgsync_1         | psycopg2.errors.UndefinedObject: replication slot "test_items" does not exist

If "items" is not database table (it is only an index in elasticsearch), "test_items" pg replication slot is not created (when I use select * from pg_replication_slots, it is not there). If "items" is database table, everything works fine.
NOTE: versions 1.1.29 and 1.1.30 do not throw this error, 1.1.31 and 1.1.32 (latest) do.

Oh yes, you'll need to create it first with the bootstrap command.
bootstrap -c /path/to/config

The case sensitivity should not really matter. Can you connect direty to yout database and run this query.
Also try lowercase names.
SELECT tgname FROM pg_trigger
WHERE NOT tgisinternal AND tgrelid = 'public.destinationSeasons'::REGCLASS
AND tgname = 'destinationSeasons_notify'

Can you also try using the latest version on master please.

It looks like case sensitivity does matter. When I tried to run query you posted above, it did't work. I tried a few different forms and it worked only if it was like that: tgrelid = 'public."destinationSeasons"'::REGCLASS (table name in quotes)

Also tgname = 'destinationSeasons_notify' condition seems not working. It returned empty result, I had to change it to tgname = 'destinationseasons_notify' (all letters are lowercase)

This is parially addressed in master. Can you please again.  I tried different setting under postgres.conf but got different beheviour from yours.

I tried latest master version and I got new error:

Still getting error (result of print(tables) command is at the top in the image)

Are you running Postgres 13.1?
Also can you connect directly to your db and run these queries below
SELECT * FROM pg_trigger WHERE tgrelid = CAST('destinationseasons' AS regclass)
SELECT * FROM pg_trigger WHERE tgrelid = CAST('destinationSeasons' AS regclass)
\d destinationseasons
\d destinationSeasons

My guess is that you might have created your tables names
quoted. i.e
CREATE TABLE "destinationSeasons" (
    ....
);

I would recommend the vanilla format i.e
CREATE TABLE destinationSeasons (
    ....
);

@toluaina hi I got the same error here is my env and example code
PGSync version: master branch commit b5ae33f8dbdcd1dadb0397443af8ffb5144342b9
Postgres version: 13.1
Elasticsearch version: 7.10.1
Redis version: 6.2.1
Python version: 3.9.2
schema:
[
	{
		"database": "test",
		"index": "my_index",
		"nodes": [
			{
				"table": "myTable",
				"schema": "public",
				"columns": []
			}
		]
	}
]

for creating tables I use ORM and default camelCase naming if I create db table without quotes database do not create table with camelCase naming it will transform the table name to lowercase nameming

I think that the hot fix for this case would be add quotes into this sql statement. In this case fixed the error successfully

If you see any issue why this is not good idea let me know otherwise I can create PR for this hotfix just let me know

I feel this might solve it here but create other problems elsewhere. I have not found a good way to create a trigger if it is not already present.
I am starting to thinkc  ecking for trigger existence is not necessary and the original error had another error earlier.

I have removed the trigger check from the master version.
For the original post, it would be useful to see the full traceback logs.

I changed table names as you recommended. I also checked current master version, where you removed trigger_exists function and it works. Issue can be closed, thank you

Closing this.Thanks


[PWN-7044] Put minimumRelayAccountBalance fee into accountCreation fe…

…e instead of transaction fee
https://p2pvalidator.atlassian.net/browse/PWN-7044

@TrGiLong @lisemyon let me review this. It is just not that simple. I have thought about adding account relay creation fee into accountBalances, but for some reason I was forced to put relay account creation fee into transaction.


Updated  BnDropLin to LinBnDrop

Thanks, though in general you don't have to manually change the html files, they are built with build_docs.py.


Release container fixes

Description

Add python-docx to the examples conda env, this package is used by examples/llm/vdb_upload/module/content_extractor_module.py
Ensure the /opt/conda/conda-bld dir exists

By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

/ok to test

/merge


[Bazaar] implement BazaarPinner service

(this is an off-repo issue -> will move to its own repo probably)
Bazaar uses IPFS to distribute shop metadata and images. The chain only stores one IPFS hash per Shop/Article. Content is usually created on mobile where it can't be hosted because mobile devices go offline and have limited battery capacity.
System components:

mobile phone running encointer wallet app and publishing/querying content
centralized web interface for browsing Bazaar. read only (scans chain for Shops/Articles and fetches content from IPFS)
pinning service

centralized, (content publishers must have account with i.e. https://pinata.cloud)
unpermissioned/unmetered:

mobile phone runs full IPFS node and publishes locally (temporarily and with possible interruptions)
a Bazaar-Pinner listens to Shop/Article updates onchain and pins all IPFS content linked within (recursively: json and links within json, i.e. images)
community-run, not incentivized to store content (assumed to be paid for by onchain fees to register Shops/Articles)

BazaarPinner

use substrate-api-client to write a Rust service reading ShopRegistry and ArticleRegistry and listening to events for new entries
run an IPFS node and use api with rust-ipfs to fetch/pin all IPFS hashes that are registered onchain (=> json files).
parse all json metadata files and fetch/pin all IPFS hashes mentioned within (up to a configurable max size and max number of files ...mitigate attack vector)
optional: expose API for app to publish content to IPFS (attack vector!)

temporarily cache such content for a few minutes. only pin permanently if registered onchain within a specified delay.

optional: garbage collection: unpin content that is removed from chain or has outlived its time-to-live.

Looks good. I like it

We could actually use offchain workers to pin content:
https://rs-ipfs.github.io/offchain-ipfs-manual/introduction.html


Print span info

add a recorder as an example of logging span into application log.

Hey @etsangsplk ! Thanks for submitting this PR. Wanted to let you know we've assigned this to the relevant folks at LightStep to review, and we will get back with a proper review as soon as possible. In the interim, feel free to reach out on Slack or by email at<EMAIL_ADDRESS>


Crash saving typed predictors with the '... is not JSON serializable' message

This is related to issue #677.  Below is the typed signature input class that causes the crash
class Input(BaseModel):
    """Input for the QueryClassifier model."""
    toolinfo: dict[str, str] = Field(description="A dictionary of tools and their descriptions")
    query: str = Field(description="The query to be answered")
    conversation_history: str = Field(description="The query context")

def input_format_handler(question: Input) -> str:
    """Format handler for the Input class"""
    return json.dumps({
        "toolinfo": question.toolinfo,
        "query": question.query,
        "conversation_history": question.conversation_history
    })

class QueryClassifierSignature(dspy.Signature):
    """Our goal is to select the right tool for processing the query using only the provided tool information"""

    question: Input = dspy.InputField(format=input_format_handler)
    tool: str= dspy.OutputField()

Crashes in module.py save() at: f.write(ujson.dumps(self.dump_state(), indent=2)). demo attribute contains a list of example objects and each example is of type Input. This is what it chokes on
I have specified a format handler (see the signature input field) but its clearly not getting called

@thomasahle - any hints on how to fix? I'd be happy to do it if you point me in the right direction

@Neoxelox - Is this fixed in dspy-ai = "2.4.0"? Otherwise, any hints on how to fix? I'd be happy to do it if you point me in the right direction

It's fixed in the GitHub repo. The version in pypi is very outdated. I don't know when they will release all of these changes, but you can pin this GitHub repo as a dependency in your requirements.txt or pyproject.toml

I still have this issue when saving list of typed_predictors - even with the current version?


WINDOWS: search for config on same drive as executable location

Description
This change causes the platform_specific_path function to root its's path in the drive __FILE__ is found in. This is arguably more accurate than $env:SystemDrive since in some security contexts a chef-client installation on a drive other than the OS is preferred.
Issues Resolved
fixes #5477
Check List

[x] New functionality includes tests
[x] All tests pass
[x] RELEASE_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

cc @chef/client-windows

I suppose another way of doing this would be to set and accept a CHEF_HOME environment variable but I'm not sure if the cost of adding that dependency is more or less evil than inspecting the executable location.

Thanks for your contribution, @jkerry !


Added SSL certificate option

My syntax may not be most elegant since I am new to nodejs, but I did test against ws and wss + SSL cert supplied, both worked as expected.
new command would be:
thor --amount 1 --SSLcertificate server.crt  wss://localhost:443

Any update on this? It would definitely be interesting to have


⚠ Bofrost.be has degraded performance

In bd15ced, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1685 ms

Resolved: Bofrost.be performance has improved in 3a60157 after 13 minutes.


Build failed

hi,
I was curios to try it out, but was not able to build it. Would be nice if you can point me out what I miss here.
Thanks
`± |master ✓| → go build
github.com/paas-prometheus-exporter
./main.go:91:29: cannot use config (type *"github.com/paas-prometheus-exporter/vendor/github.com/cloudfoundry-community/go-cfclient".Config) as type *"github.com/alphagov/paas-prometheus-exporter/vendor/github.com/cloudfoundry-community/go-cfclient".Config in argument to cf.NewClient
./main.go:98:34: cannot use "github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".DefaultRegisterer (type "github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer) as type "github.com/alphagov/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer in argument to app.NewDiscovery:
"github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer does not implement "github.com/alphagov/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer (wrong type for MustRegister method)
have MustRegister(..."github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Collector)
want MustRegister(..."github.com/alphagov/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Collector)
./main.go:106:42: cannot use "github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".DefaultRegisterer (type "github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer) as type "github.com/alphagov/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer in argument to service.NewDiscovery:
"github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer does not implement "github.com/alphagov/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Registerer (wrong type for MustRegister method)
have MustRegister(..."github.com/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Collector)
want MustRegister(..."github.com/alphagov/paas-prometheus-exporter/vendor/github.com/prometheus/client_golang/prometheus".Collector)
`

typo issue.


RedProtect Conversion

Throws a NPE when converting, most likely the data change between RP being updated and the last time GP was updated in that area. Would like to move over to GP from RP but waiting on the conversion update.

Seeing if this was updated yet. Understand you are busy, just don't want to make the jump until I can convert everyone's claims.


pin datasets in examples requirements

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


WebLink: Deserializer: Release inbound object if not yet released

If we set a download timeout less than actual required time, then download operation will be stopped and will destruct all the classes involved with that. In that case, observed a memory corruption from operator_delete for the Web::Response from ~DeserializerImpl().  It seems that it is trying to do operator_delete on the already destructed Web::Response class due to wrong reference count. So adjusting the reference count using Release() to ensure both ref count updated and memory get released

https://jenkins.code.rdkcentral.com/job/github-triggered/1983/ started

Thats interesting, since what you are doing now in the destructor is part of the _current destructor, so it could not resolve the issue youare describing, a leak.
See: https://github.com/rdkcentral/Thunder/blob/master/Source/core/Proxy.h#L319-L321 the destruction of any ProxyType object should trigger those lines and clear (Release) the object. However it is a fraction later (if the destructor ~DeserializerImpl has run all the members (and thus also _current) will be destructed.
So would be interested in what you actually fix with this.

Sure @pwielders, will reach you on Monday :)

Closing this PR, since this part is handled with the PR: https://github.com/rdkcentral/Thunder/pull/152


Improve performance by not copying when creating numpy array

Overview: What does this pull request change?

Prevent numpy.array() from copying the data when creating array.

Motivation and Explanation: Why and how do your changes improve the library?

numpy.array() is taking a lot of time when rendering. It is not necessary to copy the array data when converting to a numpy array, so it can be optimized by adding the copy=False argument.
I used a test scene heptadecagon.py (This file is not very small so I did not paste it directly here) and with that two lines of modification, I get a improvement of 12s on my machine.
Here is the performance data of ~:0(<built-in method numpy.array>).

ncalls
tottime
percall
cumtime
percall

before
62636
12.38
0.0001977
12.38
0.0001977

after
62636
0.2249
3.59e-06
0.2249
3.59e-06

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Thank you for your efforts! Although the numbers look good, running the scene normally yields jarring results.

This is possibly due to the pixel array being overwritten rather than replaced.

Thank you for your efforts! Although the numbers look good, running the scene normally yields jarring results.  This is possibly due to the pixel array being overwritten rather than replaced.

Thank you for reminding me of that. 😊 I have just tested on many other situations and it seems that it is much more complicated than I have thought. I will dig into that and open another pr (if I can figure it out).


Clarified IcoMoon icon updating steps

I added more details to this part of the docs based on where I got confused. I also made some pictures, but I'm not sure where they should go or if they are necessary with more explicit instructions.

One option might be to use the image URLs from the PR description above.

That makes me nervous. Seems unexpected that if for some reason the PR description is edited the contributing guide would break! I'd create a docs folder to put the contribution guide in and put images there (https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-readmes#relative-links-and-image-paths-in-readme-files).

A docs/ directory (and maybe a docs/img/ subdirectory?) sounds good to me. :+1: I think I'd lean toward keeping CONTRIBUTING.md where it is, in part because we link to it from the central repository. (The Briefcase repository similarly also has a root CONTRIBUTING.md along with a separate docs/ directory.) But also happy to move it if that's your preference!

Ah sorry, closed this accidentally, I think things should be OK now! 😅

No pref on my end for moving the markdown docs. The only thing I really care about is explicitly putting the image artifacts in the repo.


Crash in copyToRealm.

How frequently does the bug occur?
Sometimes
Description
I've got a weird crash when copyToRealm.
open class PendingPhone : RealmObject {

      @PrimaryKey
      var pendingId: String = ""
      var client: Client? = null
      var dealtId: Long = 0
      var clientId: Long = 0
      var phoneType: PhoneType? = null
      var phoneColorType: PhoneColorType? = null
      var phoneOwnerType: PhoneOwnerType? = null
      var phoneNumber: String = ""
      var description: String? = null
      var creatingDate: Long = 0
      var syncDate: Long? = null
}

I am trying to save the given object in Realm:
  val creatingDate = Instant.now().toEpochMilli()
  val newPhone = PendingPhone().apply {
     this.pendingId = pendingId
     this.debtor = debtor
     this.debtId = debtId
     this.debtorId = debtor.debtorId
     this.phoneType = phoneType
     this.phoneColorType = null
     this.phoneOwnerType = phoneOwnerType
     this.phoneNumber = phoneNumber
     this.description = description
     this.creatingDate = creatingDate
     this.syncDate = null
  }

  realmTemplate.executeInRealm { realm ->
     realm.copyToRealm(newPhone)
  }

 suspend fun <T> executeInRealm(code: (MutableRealm) -> T): = realm.writeBlocking {
    code.invoke(this)
}

In this case, if you call findLatest before saving, as the error says, then after the error it will say that the object has not yet been created, use copyToRealm
What am I doing wrong??
Stacktrace & log output
Stacktrace below :

java.lang.IllegalArgumentException: Cannot import an outdated object. Use findLatest(object) to find an up-to-date version of the object in the given context before importing it.

Can you reproduce the bug?
-- select --
Reproduction Steps
No response
Version
1.8.0
What Atlas App Services are you using?
Local Database only
Are you using encryption?
Yes
Platform OS and version(s)
Android, v. 10
Build environment
Android Studio version: ...
Android Build Tools version: ...
Gradle version: ...

Hi @darkan23
This happens when you try to copyToRealm an already managed Realm Object that is outdated. Most likely, you are doing something like this:
// Create unmanaged person outside the write transaction
val person = Person("Jane Doe") // Create unmanaged person
person.child = realm.query<Child>("name == 'Tim'").first().find()!! // Reference a managed object

realm.write {
  // Copying the person here might throw the error you are seeing if the Realm progressed from the time you did the query.
  copyToRealm(person)
}

Is it something like this you are doing?

Yes, that pattern is a problem. The reason it is a problem is that Realm Objects are versioned and thus might change once you enter a write transaction.
I.e. in your logic, you might read Client at version 1 and store it in your object, then, just before doing the write, another thread deletes that Client object.
Then when you enter the write, it is unclear what the correct behavior would be.
In cases like this, you basically have two options:

You can use copyFromRealm() on the Client object when you assign it to PendingPhone. That would work, but you might accidentally end up overwriting data you didn't want to.

Move all the logic inside the write transactions. You can only ever have active write transaction, so that will ensure we can guarantee data integrity. So something like this:

override fun createPendingPhone(
    dealId: Long,
    pendingId: String,
    phoneType: PhoneType?,
    phoneOwnerType: PhoneOwnerType?,
    phoneNumber: String,
    description: String?,
) {
    appScope.launch {
        // Always start transaction
        realmTemplate.executeInRealm { realm ->
            val client = realm.query<Client>("deals.dealId = $dealId")
            if (client == null || !client.isValid()) {
                log.warn("No client for deal with id $dealId! Can't save pending phone.")
                realm.cancelTransaction()
            } else {
                val creatingDate = Instant.now().toEpochMilli()
                val newPhone = PendingPhone().apply {
                    this.pendingId = pendingId
                    this.client = client
                    this.dealId = dealId
                    this.clientId = client.clientId
                    this.phoneType = phoneType
                    this.phoneColorType = null
                    this.phoneOwnerType = phoneOwnerType
                    this.phoneNumber = phoneNumber
                    this.description = description
                    this.creatingDate = creatingDate
                    this.syncDate = null
                }
                realm.copyToRealm(newPhone)
            }
        }
}

I would strongly recommend option 2.

@cmelchior
Thanks for the help!

Hi!
@cmelchior  thank you for the explanation. it solved my problem.
I wanted to ask another question here. i think it's the right topic.
Is this a good example of using:

            //Sample with find latest
            realmTemplate.write { realm ->
                val latestPerson = realm.findLatest(person)

                //do something with person, like add phone or anything

                realm.copyToRealm(latestPerson)
            }

Thank you!

@Igro182
You don't need the last copyToRealm. Once you used findLatest you have access to the mutable Realm data and can just modify that object directly, so:
            //Sample with find latest
            realmTemplate.write { realm ->
                realm.findLatest(person)?.let {
                   name = "Jane Doe"
                }
            } ?: TODO("Handle the user not existing")

@cmelchior Thank you! does it actually mean, this is another option to resolve the issue described by @darkan23 ? any of these options is preferable from performance or any other point of view?

Using findLatest is much better for performance, since you are only modifying the fields that changed.

Using findLatest is much better for performance, since you are only modifying the fields that changed.

Thank you @cmelchior !


Allow to add a global ignore for code diagonistics messages

Currently there is no way (or at least I could not find any) to add some diagnostic messages to a global ignore setting.
One such example:

This message pops up everywhere in our big solution at work and I would love to disable it globally on my local machine. I realize that there are ruleset files that can ignore this message, however, this would be an incredible time-consuming task to write ruleset files for all the projects in this solution.

You could create a ruleset and add it to the Directory.Build.props at the root of your solution:
<Project>
  <PropertyGroup>
    <CodeAnalysisRuleset>$(MSBuildThisFileDirectory)MyRules.ruleset</CodeAnalysisRuleset>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="my.analyzers" Version="0.0.1" />
  </ItemGroup>
</Project>

Then it applies to all csproj files starting from the root.

@filipw thanks, although that way of "solving" it was already known to me.
The issue with that way is, that I have to edit our top most .props file and will always have it listed as a change in the git repository. Since we are a lot of people (~160) working on the same code base this is forbidden and the only way, in this case, to solve the issue in vscode "reliably" is by having a global ignore, or a file that I can add to .gitignore and is not in the git repository already (like omsnisharp.json for example).

You will be able to control it with .editorconfig (see #1526)

Aweomse, thanks!

editorconfig support for analyzer severities has been implemented


Handle display of errors attempting to set "api key"

The "Api key" is really a formatted connection string. Need a way to validate they have the correct format (use regex) and present an error of some sort on the authentication page that comes up first when you add the applet. Also add link to end user readme that will explain the format of the string

There isn't support atm for my to be able to validate the key before they leave that api screen. I'd imagine too that my usage of the apiKey is out of scope for what they were intending.

Going to re-open this! I noted when i accidentally had a malformed key, I could not get past the API window. The issue is if i have a properly formatted key I can get past, but the options will not display any pipelines because i was unable to get to the Jenkins server. Need a way to inform user of an issue hee.


To run sailor

Hi,
I'm trying to run sailor on our HPC as a user. I first installed singularity via conda by "conda install -c conda-forge singularity".
And I can see "singularity version 3.6.4" by run "singularity --version" to make sure singularity is installed.
Then I download the executable sailor "https://s3-us-west-1.amazonaws.com/sailor-1.0.4/sailor-1.0.4" to an empty folder and ran "chmod +x sailor-1.0.4" as described in the tutorial.
However, when I run ./sailor-1.0.4, a weird error massage shows up:
FATAL:   while extracting ./sailor-1.0.4: not a squashfs root filesystem
Do you have any suggestion about this problem?
Thanks for advance!

Hi, it seems like an issue with trying to run singularity unprivilaged: https://github.com/hpcng/singularity/issues/3940
Is it possible to ask your HPC admins to install singularity and see if that helps you run the image?


Short solution needed: "Add new value to time series" (redis-timeseries)

Please help us write most modern and shortest code solution for this issue:
Add new value to time series (technology: redis-timeseries)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Add new value to time series


Improved timeline style for mobile screen size.

Fixes #132
Description
Made the "How it works for customers and tailors " timeline vertical for mobile view.
Changed timeline color to match the webpage color theme.
Type of change
Style change
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshots
Before

After

Hello @harshit-002!
Thank you for submitting this pull request Your pull request will be reviewed by maintainers shortly. Meanwhile make sure you have referenced the respected issue in this pr Your pr will not be merged if it does not refer respected pr and please read our Contributing Guidelines https://github.com/UBA-GCOEN/StichHub/blob/main/CONTRIBUTING.md And Code of Conduct https://github.com/UBA-GCOEN/StichHub/blob/main/CODE_OF_CONDUCT.md

Hey @harshit-002
Your code is not responsive, and also vertical timeline is not looking good in mobile view.
So do you have any good idea to showcase how it works in vertical?

tailwind css doesn't have any class for extra small screen size, I can't make it responsive for less than w:640px just by changing the classes. I shall close the issue.

tailwind css doesn't have any class for extra small screen size, I can't make it responsive for less than w:640px just by changing the classes. I shall close the issue.

@harshit-002 Actually tailwindcss is mobile-first, its all classes are by default for the mobile screen


Graphics settings break VS Code

Issue Type: Performance Issue
On my workstation I have Nvidia graphics card. In the NVIDIA control panel, if I change the Image settings with preview value from "Performance" or "Balanced" to Quality the VS Code interface breaks. There are green lines everywhere, text is blurry and have a green shadow. Changing back to "Performance" or "Balanced" fixes the issue, but I would like to run the best setting for graphics quality.
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz (8 x 2794)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.88GB (19.44GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    79	 20732	code main
    0	   211	   948	   window (loadDocumentsSaga.js - Frontend - Visual Studio Code)
    0	    14	  3200	     watcherService
    0	    11	 21212	       console-window-host (Windows internal process)
    0	     7	 12392	     winpty-process
    0	    70	 19944	       C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe
    0	    12	 20964	       console-window-host (Windows internal process)
    0	    13	 18300	     electron-crash-reporter
    0	    75	 21376	     extensionHost
    0	   118	 19804	       electron_node eslintServer.js
   18	   183	 21476	       electron_node tsserver.js
    0	    68	 20928	         electron_node typingsInstaller.js typesMap.js
    0	    75	 10776	   shared-process
    0	   119	 20452	   gpu-process
    0	    66	 20568	   window (Issue Reporter)

Workspace Info
|  Window (loadDocumentsSaga.js - Frontend - Visual Studio Code)
|    Folder (Frontend): 334 files
|      File types: js(271) map(12) scss(11) json(9) xml(7) png(6) html(3)
|                  dll(2) xlsx(1) babelrc(1)
|      Conf files: package.json(1) webpack.config.js(1) settings.json(1);

Extensions (2)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.8.2

powershell
ms-
1.12.1

We are building exploration builds that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download

Downloaded the Windows version, and that seem to be working excellent. Also now that I'm connected to external monitor, noticed that this issue is only present on the built in laptop screen, not on external monitors. Attached a screenshot comparing VS Code and the VS Code- Eploration

We will ship with Electron 4 with our upcoming release 1.36 this week. As such I am closing this issue. To benefit from the update already today, consider to use our insiders version: https://code.visualstudio.com/insiders/


Vite 4 support

SvelteKit is finally 1.0.0. Alas, adding the PWA functionality fails again. :'(
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vite
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/vite-plugin-pwa
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@vite-pwa/sveltekit
npm ERR!     dev<EMAIL_ADDRESS>from the root project

Is Vite 4 support in the pipelines?
Thanks, guys!

@alensiljak yes, we're working on it, we need to apply a few changes.

released 0.1.0 version

Thank you for the present! Looking forward to using it this weekend.


VariantFragment and ProductFragment removal

Description
Part of #778
This one focuses on VariantFragment and ProductFragment, which are the last two! 🎉
With this PR merged, the Fragments have been removed from the demo store, and it's now using the raw query strings. The next step would be to optimize those query strings where they're being used - this is a task that could be parallelized since each page will have its own data needs.
Also I'm purposely avoiding the graphql-constants.ts file, since that will just be full-on deleted when we're done. Once this PR is merged and consensus obtained on completely removing fragments, I'll just delete that.

I'm going to say that the tests pass for this; it seems we have flaky tests right now.

I'm going to say that the tests pass for this; it seems we have flaky tests right now.

I'm going to say that the tests pass for this; it seems we have flaky tests right now.


Relax assumption that validation is "on PR"

ballet version: 0.10.0

Description
If creating a feature on a feature development branch locally, validation cannot be run even though it makes sense. This is because validation is skipped unless it is run from "on a PR" which means the ref is named like pull/1. Relax the assumption to just check when on the master branch vs when not on the master branch. This allows easier validation from local repos.
Solution

rename on_master to on_default_branch
deprecate on_pr and use not project.on_default_branch

Implemented in b86faab

three existing differs used
detect differ uses different functions to see if each differ can be used
"pull request" differs (soon to be renamed) do not rely on existence of pull requests git structure


Add rotation support

Would nice to see support for rotated objects (using SAT, swept OOB...) for collision tests, and the colliding angle in collision response.

I agree!
I'm not able to add these right now because of time constraints, but if anyone out there reading this is able to help, we would greatly welcome it :)

@yckart Actually, I have the same problem, do you have find a solution ?


Formatter for javascript not found

This is most likely a duplicate of https://github.com/akalongman/sublimetext-codeformatter/issues/173

Have this issue too. Linux x64, Sublime 3083

{
	"codeformatter_js_options": {
		"syntaxes": "javascript,json,JavaScript",
		"format_on_save": true
	}
}

i think you should have
"syntaxes": "JavaScript"

it works for me.

:+1:
Can confirm that "syntaxes": "JavaScript" fixes the issue.
Same thing with html formatter.

this is issue with old settings file that does not have syntaxes specified


from ssd import build_ssd  ImportError: cannot import name 'build_ssd'

Can you please explain when did you get this error?

https://github.com/amdegroot/ssd.pytorch/blob/master/ssd.py


@sveltejs/kit and vite@3 crash Chrome

Describe the bug
We've noticed that a certain page causes Chrome to hang or crash. I was able to create a sample project for this issue. I think it's likely something to do with Vite in dev mode. If I build the project and preview it, everything is working fine.
We've currently switched to Firefox as a workaround.

Reproduction
Please clone https://github.com/sserdyuk/vitebug-08-08-2022
Please run npm run dev and navigate to http://localhost:4100/mock3/explore. The page usually renders once but crashes Chrome on a refresh. I am also noticing it takes quite a bit of time to load that page in the first place.
Logs
No response
System Info
System:
    OS: Linux 5.4 Ubuntu 18.04.6 LTS (Bionic Beaver)
    CPU: (16) x64 AMD Ryzen 7 5700G with Radeon Graphics
    Memory: 21.54 GB / 30.74 GB
    Container: Yes
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 16.14.0 - ~/.bin/node/bin/node
    npm: 8.3.1 - ~/.bin/node/bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Firefox: 103.0
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.64
    @sveltejs/adapter-node: ^1.0.0-next.71 => 1.0.0-next.86
    @sveltejs/kit: next => 1.0.0-next.405
    @sveltejs/vite-plugin-svelte: ^1.0.0-next.36 => 1.0.1
    svelte: ^3.44.0 => 3.49.0
    vite: ^3.0.0 => 3.0.4

Severity
serious, but I can work around it
Additional Information
No response

to work around this problem, prefer deep imports of .svelte files, see also https://github.com/rgossiaux/svelte-headlessui/issues/107
I wonder if the addition of tailwind in the reproduction plays a part here too.

Another report on discord showed that @svelteuidev/core has a similar issue, where we did prebundle the svelte library, but Vite doesn't resolve to the prebundled file.

I found the issue with @rgossiaux/svelte-headlessui. The bug was in the reproduction. It had type="ts", which as far as I know is not valid. If you change it to lang="ts" then it works:
https://github.com/sserdyuk/vitebug-08-08-2022/blob/d6a649d6bc535734347c30a6ac3b6c6d7c9ff1cf/src/routes/mock3/_shared/Explore.svelte#L1

I think we can close this issue now. I've filed a new one to track the @svelteuidev/core issue: https://github.com/sveltejs/vite-plugin-svelte/issues/421

closing per @benmccann's comment.
The crash in the original report likely happened due to the large number of requests.


ReferenceError: HTMLElement is not defined

I tried with headless mode...
But my test are failing that HTMLElement is not defined. But same worked in head mode.
Can you please assist ?

Found the issue.. hance closing the bug.


Rotating SuperEllipse Contribution

Demo: https://editor.p5js.org/jkenzer/full/nPbnDYnsI

Community Contribution
Link to live project, video, or image:

Sharing

[x] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

Thank you for this awesome contribution ❤

Thank you for this awesome contribution ❤


Database configuration

Improve documentation
Link : https://github.com/supabase/gotrue#database
Describe the problem
As far as I know, the Supabase fork of GoTrue might support to Postgres database, while the original repo is only supporting MySQL/MariaDB. But the docs of this repo also stated, that only supported MySQL.
Describe the improvement
Is this fork of GoTrue does supported Postgress? If yes, could u please share the relevant DB_DRIVER for config? As well as it would be awesome if you guys can share, what things you guys made to make GoTrue compatible with PostgreSQL. Thanks in advance!

Hi @Yasirunet, maybe this file will help you to set up your Postgres database https://github.com/supabase/gotrue/blob/master/hack/postgresd.sh . And yes it should definitely be documented if it is a supported driver.

Hey @Yasirunet, sorry for the lapse in documentation! We were really pushing for some features to go out for the launch week in August such as the ability for gotrue to automatically run its database migrations on start. This wasn't a concern in the past because we didn't make any changes to the underlying schema but with the phone authentication feature, we had to add some extra columns to the users table.

Is this fork of GoTrue does supported Postgress?
That is correct. The DB_DRIVER should be postgres. Since the upstream of gotrue by netlify is using mysql as the DB_DRIVER, we had to make changes to the initial schema to make it compatible with postgres. In addition, some of the code in gotrue relied on specific mysql dialect which doesn't work for postgres. We had to make those changes too. Hope this helps!

Thanks for the reply @kangmingtay. I'll close this issue for now. If I found any problem while I configure gotrue with Postgres I'll raise it separately. It's better if u can update the docs once u get free time. Keep up the great work! ✌

Hi everyone 👋  I saw the README still says the only suported driver is mysql here.

DB_DRIVER - string required
Chooses what dialect of database you want. Must be mysql.

Should this be changed to postgresql?
Thanks for all you do! ❤


Locally hosted loading gif

Probably a dumb question but how do I use a loading gif hosted locally in my project? I'm using Ruby on Rails, with the javascript for infinite scrolling below
$container.infinitescroll({
      navSelector: 'nav.pagination', // selector for the paged navigation
      nextSelector: 'nav.pagination a[rel=next]', // selector for the NEXT link (to page 2)
      itemSelector: '#discover_content div.discover-article', // selector for all items you'll retrieve
      bufferPx: Math.round($(window).height() * 1.5),
      pixelsFromNavToBottom: Math.round($(window).height() * 1.5),
      loading: {
        finishedMsg: 'No more products to load.',
        msgText: "",
        img: "/app/assets/images/myblend-loading.gif"
      }
    }

I'm pretty sure the path is right but whenever I hit the infinite scrolling code I get an error in my console like "GET http://localhost:3000/app/assets/images/myblend-loading.gif 404 (Not Found)" and the image doesn't display. How can I use the gif I downloaded as the loading gif?

Looking at your options code, your image's complete URL would looks like:
http://example.com/app/assets/images/myblend-loading.gif

Double check that this URL works.


fix railing vaulting

About the PR
This fixes  railing vaulting
in the flaps pr, vaulting was changed from using the smallImpassable collision layer to using VaultImpassable

in the flaps pr, vaulting was changed from using the smallImpassable collision layer to using VaultImpassable

Won't this break a lot of things? Apparently cloners are colliding with players again. SmallImpassable is what it should be doing or maybe Impassable.

As far as breaking anything, vault impassable is basically always used in tandem with smallimpassable and impassable so nobody should be getting anywhere they shouldn't as far as i've tested.
I'm still going through and trying to test out if there's a better solution that will fix these, If you do have a good example for what vaultimpassable is supposed to represent it's been hard to find.

On this, I've gone through and tried a lot of different ways but I can't find a good way of separating out larger sized items such as closets from mobs unless there is another collision layer at work.
I'm still pretty confident in that vault impassable is always treated as a step down from impassable and in all the uses i've seen it generally uses both.
I figure that the options are:

I can revert all the collision changes from previous pr, use smallimpassable for vaulting and flaps can use mobImpassable
Make changes to the cloner and railing to put them in line with the other changes.

That's all I can come up with, I'm not trying to rock the boat or anything, I'm fine with whatever's best.

That's all I can come up with, I'm not trying to rock the boat or anything, I'm fine with whatever's best.

More and more everyday I get motivated to just refactor things to have just the 1 layer. Some stuff is still a mess so it's probably fine for now.


Welcome email subject in Russian was sent to English speaking user

The subject line for use  1906824's welcome email was in Russian:

So the commit above might fix this. It's hard to test b/c I think the bug had to do with a delayed job process getting stuck with a locale set to Russian based on some previous job it ran, and since I don't know what job that was, I can't really replicate it.


[BUG] Buggy reply in chatbot

Describe the bug
I use ./scripts/run_chatbot.sh OptimalScale/gpt-neo2.7B-inst-tuning, but the output looks weird.
User >>> Who are you?
Bot:
 Output: I am a student from the United States.
User >>> What is your name?
Bot:
User >>> What is your name?
Bot:
User >>> Who are you?
Bot:
What is your name?
What is your name? What is your name?
What is your name?
What is your name?
What is your name? What is your name?
What is your name?
What is your name?
What is your name? What is your name?
What is your name?
What is your name?
What is your name? What is your name?
What is your name?
What is your name?
What is your name? What is your name?
What is your name?
What is your name?
What is your name? What is your name?
What is your name?
What is your name?
What is your name? What is your name?
What is your name?
What is
User >>>

To Reproduce
Steps to reproduce the behavior:

Run ./scripts/run_chatbot.sh OptimalScale/gpt-neo2.7B-inst-tuning
Ask What is your name?

Expected behavior
Should not reply so many What is your name?

I think it is because the checkpoint is not good.
You may try different models listed here: https://github.com/OptimalScale/LMFlow#model-zoo
For example, Robin-7B ⭐ and Parakeets-2.7B ⭐

Noted, many thanks!

@shizhediao I change to Robin-7B and the reply still looks buggy.
#############################################################################
##   A pinkmanlove/llama-7b-hf + output_models/Robin-7b/robin-7b chatbot is now chatting with you!
#############################################################################

User >>> What's your name
Bot: ?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions
User >>> Write a story about bird.
Bot: ###Assistant:Once upon a time, there was a little bird named Flutter. Flutter lived in a beautiful forest with her family. She loved to sing and fly, and she was always curious about the world around her.
User >>> What is your name?
Bot: ###Human:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have. ###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Human:What
User >>> Q:What's your name
Bot: ?
AI:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.
Please write in English language.###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have. ###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.###Human:What's your name?###Assistant:My name is AI Alpha, and I am a language model based on the GPT-3 architecture. I am here to assist you with any questions or tasks you may have.
User >>>

Thanks for your interest in LMFlow! You may use --prompt_structure "###Human: {input_text}###Assistant:" in ./scripts/run_chatbot.sh and check the performance. Since Robin-7B is trained on this type of prompts, it can help improve the performance. Thanks 😄

Hi, can you show your shell code?

Thanks, let me try it. @research4pan


Mealie - High Ram Usage

Works great, but a new install with nothing in it is chewing 600m of my rpi4 2gb ram. This seems unreasonably high, is there anything that can be done?

Hi, sorry this is likely due to upstream image. Plus, please use templates for issues. Thanks.
A quick search on the upstream repo shows this was already encountered : https://github.com/hay-kot/mealie/issues/654
I've set those values in the newly pushed version. If this doesn't help, I don't see what I can do from the addon side

Hey thanks just wanted to make sure something easy wasn't getting overlooked. Sorry about the template, the flow dialogue didn't come up for some reason from where I hit new issue. Thanks!

No problem, it showed me that I had a bug in the config.yaml to disable blank issues so actually it helped :)
Regarding size or ram optimization alas I can't do much as often it is linked in the upstream container image. In this case I've reduced the number of threads in a new version so it should limit ram usage, however be aware that lots of graphic addons have relatively high ram usage

just for reference, whatever you changed helped a little, went fom 600m to 480m. still using 100m more than HA itself lol

Thanks. I'll close it as I don't see what can be changed more but if you see any other way to decrease ram usage please post here or make a PR. Thanks!


Update the dvcs/gitignore submodule

Hello
Recent changes have been submitted to the dvcs/gitignore repository to add support for Drupal 7 and Drupal 8 templates, among others.
May you update the git submodule?
Thanks

It was updated 6 days ago.
https://github.com/joeblau/gitignore.io/commit/54308538aff8d7dd4ff1fc8a1a6c42305033ebea


⚠ Bofrost.at has degraded performance

In ec39770, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2362 ms

Resolved: Bofrost.at performance has improved in bb042ef after 6 minutes.


golangci-lint: 1.25.0 -> 1.25.1

Motivation for this change
Update golangci-lint to its latest release.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 86337 1

2 packages built:
- golangci-lint
- vimPlugins.vim-go


Added edit/delete buttons on search results (task #5716)

Codecov Report

Merging #529 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #529   +/-   ##
=========================================
  Coverage     28.18%   28.18%
  Complexity      952      952
=========================================
  Files            85       85
  Lines          3246     3246
=========================================
  Hits            915      915
  Misses         2331     2331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d2258...60e50be. Read the comment docs.


feat: gate provider implementation

Description

Adds gate.io as a provider to support umee/usdt
todo still : unit tests + cleanup
closes: #604

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #611 (bbf5b39) into main (6b2a099) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   48.45%   48.08%   -0.37%
==========================================
  Files          63       64       +1
  Lines        7940     8801     +861
==========================================
+ Hits         3847     4232     +385
- Misses       3835     4311     +476
  Partials      258      258

Impacted Files
Coverage Δ

x/leverage/keeper/exchange_rate.go
61.81% <0.00%> (-17.26%)
:arrow_down:

x/leverage/keeper/grpc_query.go
7.33% <0.00%> (-3.38%)
:arrow_down:

x/leverage/client/cli/query.go
0.00% <0.00%> (ø)

x/leverage/types/query.pb.gw.go
0.00% <0.00%> (ø)

x/leverage/client/tests/suite.go
100.00% <0.00%> (ø)

x/leverage/keeper/loaned.go
0.00% <0.00%> (ø)

LGTM. Let's get that config change in.

Done at ed837f455611348519a22acb5e9335ca861b3d0e
@RafilxTenfen do you want to check this out before it gets merged in?


Update 1 book URL in free-programming-books-id.md

Update URL for Pemrograman Kompetitif Dasar
What does this PR do?
Update resource
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


kubernetes upstream: add rook operator

Create a new operator under community-operators for Rook the Storage
Orchestrator for Kubernetes. This is the upstream version.
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

Current Total Score: 32%...

The logs are full of errors, yet the CI is green https://travis-ci.com/operator-framework/community-operators/builds/111611074 🤔

@leseb The scorecard passes since your operator is running. Our CI also prints out the operator logs as well, which is where you are seeing the errors like this: https://travis-ci.com/operator-framework/community-operators/builds/111611074#L419

@SamiSousa how can we diagnose what's happening?

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

@SamiSousa looks like the issues are solved, I don't understand "CVP/pr-sanity-check"'s error here, am I missing something obvious? Thanks!

Looks good. Can you elaborate in the description a little more what the Operator does? E.g. that it stands up a Ceph cluster with StatefulSets and whether or not it supports upgrades of Ceph as well as advanced lifecycle features as claimed in the capability level ("Full Lifecycle").
Also, any requirements on the Kubernetes node (devices, network) would be good to know.

Note: I successfully deployed a cluster using the same Travis job (injected a minimal CR).

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

PR includes changes to only the [upstream-community-operators] directory. No pipeline will be launched.

/lgtm


The size of train.features.hkl is too big???

When I run the prepro.py,I spend too much time getting train.features.hkl,it almost 80GB+ now and still increase...I want to ask is that normal???

In my case, I got 31G for training data.


⚠ Bofrost.de has degraded performance

In eb51f0e, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1397 ms

Resolved: Bofrost.de performance has improved in e03e860.


embed Instagram post

Not sure is this possible or not, just feel Instagram has more limit than TikTok.

I've added it, but let me make some other improvements to the plugin first. I should be able to make a new release by the end of today!
Note that I don't use Instagram so I have no idea how well it'll work. Tried it with some links so it should work with most of them for now. If something doesn't work, just comment in this issue or create a new issue. Thanks!

Really thanks for your quick reply, if having anything, I will post here. You are amazing!


Fix for SET TRANSACTION_ISOLATION_LEVEL issue

The issue is than when you set the :set_transaction_isolation_level in your connection options, when connecting the following error is raised:
** (Tds.Error) Line 1 (Error 195): 'TRANSACTION_ISOLATION_LEVEL' is not a recognized SET option.

The proper SET option for this is TRANSACTION ISOLATION LEVEL (without the underscores). This PR fixes this issue :)
Additionally, I have fixed a few minor typos in the errors when setting connection options with wrong arguments.

Thank you!

Wow... that was super fast :)

Well, it was my bad when I exposed those connection options recently, it quickly triggered me when I saw your comment. I'm pushing new release in hex in few minutes.
Thank you again!!!


Update Microsoft public document

The below subtopic needs to updated:
Topic : Switch managed disks from one disk type to another
Point no 6 needs to be updated as below
Current statement : Select Configuration from the menu.
Required statement: Select Size + Performance from the menu.
Note: Configuration field has been changed to Size + Performance in the Azure portal.

@SivaVilla : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@SivaVilla Thanks for helping us improve our docs, we appreciate it!
This change looks good, so:
#sign-off


Delete achievements of game that are no longer in the library

Hi!
Just wanna know if it's possible to delete achievements of game I don't own anymore.
It will be really important. The achievements of this game are listed yet, but SAM doesn't seems to be able to find them.
Thank you!

This is not possible with SAM/the Steamworks API.


“An external application wants to open [file] in Code” dialog does not remember “Allow opening local paths without asking” decision

Type: Bug
Every time I try and open a file from say, a command line program, I get a prompt in Code saying:

An external application wants to open [file] in Code. Do you want to open this file or folder?

Each time, I check the "Allow opening local paths without asking" and then click the "Yes" button, but I still get this prompt multiple times a day.
Is it possible to get this dialog to actually remember my decision to open local files without asking? Instead of constantly asking.
VS Code version: Code 1.84.2 (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:52:33.687Z)
OS version: Darwin x64 22.6.0
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz (4 x 2300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 3, 4

Memory (System)
16.00GB (0.01GB free)

Process Argv
. --crash-reporter-id d0190847-56db-4203-8f95-8148c095a0ae

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

vscode-intelephense-client
bme
1.10.1

vscode-eslint
dba
2.4.2

EditorConfig
Edi
0.16.4

prettier-vscode
esb
10.1.0

copilot
Git
1.137.0

copilot-chat
Git
0.10.1

vscode-github-actions
git
0.26.2

todo-tree
Gru
0.0.226

php-namespace-resolver
Meh
1.1.9

dotenv
mik
1.0.1

php-docblocker
nei
2.7.0

volar
Vue
1.8.23

vscode-typescript-vue-plugin
Vue
1.8.22

vscode-import-cost
wix
3.3.0

php-debug
xde
1.34.0

Screenshot of dialog:

If you open the settings editor, change the security.promptForLocalFileProtocolHandling setting accordingly.

It’s un-checked, which given the description sounds like the dialog shouldn’t be appearing at all?

Yeah strange, whats the full protocol link?

Hi @bpasero, same problem here when opening files from WSL:

URL:
vscode://vscode-remote/wsl+Ubuntu-22.04/home/myuser/myproject/myfile.php:305

security.promptForLocalFileProtocolHandling is also unchecked.

@sebj54 Try: security.promptForRemoteFileProtocolHandling

It is also unchecked.
I also tried the following:

set security.promptForRemoteFileProtocolHandling to true
tick the checkbox on the popup
security.promptForRemoteFileProtocolHandling is now unchecked

So it seems that these settings are not taken in account and the warning is shown everytime

@sebj54 the setting is inverse, it needs to be false for the checkbox to be checked. Please read the settings description carefully.

Yes I know that. I checked it only to see if the checkbox on the confirm prompt is working. The only thing that's working here is this checkbox on the confirm prompt.
The setting itself (security.promptForRemoteFileProtocolHandling) is not taken in account. The confirm prompt is shown whether it is true or false.

Is this a normal install with local settings or anything special about it? Workspace settings?

Yes it's a normal install. The setting only exists in remote (no user nor workspace setting)

It needs to be configured locally, not remote.

Then the confirm prompt does not set the correct setting I guess. Ticking the box updates the setting in remote and this setting does not appear anywhere than in remote. See screenshots below:

When I manually set it to false in my JSON user settings, it works as expected (the prompt is disabled), but the line I added is greyed out:

Ah nice catch!

It was hard to find out! Thanks for your help on this :)

is there an easy way to trigger this prompt?

@sebj54 @martinbean @bpasero bumping to see if the issue is fixed!

@justschen @bpasero Sorry for the delay. I've tried to check if the issue is fixed with insiders version but could not figure out how to make it work from WSL (the URL scheme keeps launching stable version)

This fix has meanwhile landed in stable!

Still having the same issue, Warp editor + VsCode
Version: 1.87.0 (Universal)
Commit: 019f4d1419fbc8219a181fab7892ebccf7ee29a2
Date: 2024-02-27T23:42:56.944Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 21.5.0

I am also having the same issue and it is also with the warp application. Fur sure a correlation with warp. Causation is not confirmed.

Having this issue too and I'm using WezTerm. I'm opening files using vscode://...

Still having this issue on macOS, just using Arc browser with Locator.js and VSCode stable, opening files using links like vscode://file/Users/dgattey/checkouts/ghg/workspaces/app-dashboard/components/measure/footprint/CalculationMethodTiles.tsx:35:9, where ghg is repo folder name. When I open it in VSCode I see this popup, which makes me think maybe the file is being treated as not remote OR local? Is there something about the resolution to ~ for the home folder that's messing with this setting still?

I have this in my user settings and no overrides in my workspace settings:
  "security.promptForRemoteFileProtocolHandling": false,
  "security.promptForLocalFileProtocolHandling": false,


Where is urlUtils imported from?

import urlUtils from '@arcgis/core/core/urlUtils';
This doesn't work.

There's no default export on that module. Try something like import { urlToObject} from '@arcgis/core/core/urlUtils';

I do import { urlToObject} from '@arcgis/core/core/urlUtils'
But there is no addProxyRule with urlToObject:
urlToObject.addProxyRule({
urlPrefix: "https://www.mycompany.com/server",
proxyUrl: "https://www.mycompany.com/Proxy/proxy.ashx"
});

Oh! Do something like this:
import * as urlUtils from '@arcgis/core/core/urlUtils';

urlUtils.addProxyRule( . . . );

Thanks.

Awesome, I'll go ahead and close this issue.


feat!: errorCode as enum, reason as string

changes errorCode in resolution/evaluation structures to enum
changes reason in resolution/evaluation structures to string

Closes: https://github.com/open-feature/java-sdk/issues/78
:warning: the flagd integration tests WILL fail with this change :warning: - that's because the flagd provider needs these changes (a bit of a chicken/egg situation). I have a provider update ready locally to push as soon as this is published, which will then get the integration tests working again. This PR temporarily deactivates them.

Codecov Report

Merging #80 (a495396) into main (e108666) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #80      +/-   ##
============================================
+ Coverage     91.24%   91.84%   +0.59%
- Complexity      173      175       +2
============================================
  Files            19       19
  Lines           377      380       +3
  Branches         22       23       +1
============================================
+ Hits            344      349       +5
+ Misses           22       20       -2
  Partials         11       11

Flag
Coverage Δ

unittests
91.84% <100.00%> (+0.59%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...dev/openfeature/javasdk/FlagEvaluationDetails.java
100.00% <ø> (ø)

...c/main/java/dev/openfeature/javasdk/ErrorCode.java
100.00% <100.00%> (+100.00%)
:arrow_up:

...ain/java/dev/openfeature/javasdk/NoOpProvider.java
96.55% <100.00%> (ø)

...ava/dev/openfeature/javasdk/OpenFeatureClient.java
97.61% <100.00%> (+0.08%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

FYI @thomaspoignant  I have updates to the contribs pending locally, including the flagd and the go-feature-flag provider for this.

Similar PR in c# for any interested: https://github.com/open-feature/dotnet-sdk/pull/72


feature Support xor Predicate

Proposed changes
mysql [test]>select true xor false,true xor true;
+------------------+-----------------+
| (TRUE XOR FALSE) | (TRUE XOR TRUE) |
+------------------+-----------------+
|                1 |               0 |
+------------------+-----------------+

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[Native] - problem in casting varchar type column into  varchar(3) against c++ worker

Bug description
There is a problem in casting between varchar type columns (with different lengths) in Prestissimo.
In the following SQL the input is a varchar[8] type column cast into  varchar(3) and C++ worker returns incorrect results. This works correctly in Presto.
presto:tpch> select cast(varchar_value as varchar(3)) from (values ('9898.122')) t(varchar_value);
_col0
9898.122
Note:-> This is incorrect output. The correct result should be 989
System information
Velox System Info v0.0.2
Commit: fb5afdc532f3248b49302a4bdf0dbe406903882b
CMake Version: 3.26.4
System: Darwin-22.4.0
Arch: x86_64
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: <IP_ADDRESS>30022
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: <IP_ADDRESS>30022
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX13.1.sdk/usr;/usr/local;/usr;/;/usr/local/Cellar/cmake/3.26.4;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local
Relevant logs
No response

HI @mknegi, I see you are filing lots of issues. Curious where are you from and what are trying to do. Velox is all C++, unlike Presto which is a mix of Java and C++. Hence, it is redundant to include [native] prefix to Velox issues. I wonder if you meant to submit these issues to Presto instead. Looking forward to hearing from you.

HI @mknegi, I see you are filing lots of issues. Curious where are you from and what are trying to do. Velox is all C++, unlike Presto which is a mix of Java and C++. Hence, it is redundant to include [native] prefix to Velox issues. I wonder if you meant to submit these issues to Presto instead. Looking forward to hearing from you.

@mbasmanova : Manoj is from IBM. We are getting these issues from running tests in presto-product-tests Presto module against Prestissimo. We want to establish that as a baseline for Presto/Prestissimo product tests in the build.

@aditi-pandit Got it. Thank you for the context. Would it make sense to file these issues in the GitHub repo? Ideally, issues in Velox repo would be described in Velox terms and include a repro that can run with Velox alone.

@mbasmanova : Yes, the way the issue is described is more appropriate for Prestissimo than Velox.
We has debugged this a bit and felt the issue is in Velox CastExpr, so filed it here.
But you are right that without a Velox repro there isn't context. Will ask Manoj to file the issues in Presto github instead.

@aditi-pandit Thanks.

Tracking this issue in Presto project https://github.com/prestodb/presto/issues/20847


SonarCloud code review

Hi Mr Skoruba.  This is not a dig or in any way trying to be detrimental to the project.
I love the work that's been done here. I have a SonarCloud review of my code base which also includes this project.
This morning I've reviewed the what's showing up and I was wondering how I could make this information useful to you and your team. Is this something of interest to you?

Most of the Vulnerabilities arise from the view Pager.cshtml

Which contains this explanation

Hi @carlblanchard - thank you for you feedback, I appritiate any improvements - I will check it. :-)
Honestly I do not know this tool and it looks very interesting. I will scan this solution as well and go through the warrnings.

The service I use is SonarCloud.io as this project is a public project you'd be able to get it for free.   https://sonarcloud.io/pricing

Thanks for your tip, I will check it.

@skoruba fyi  https://github.blog/2020-09-30-code-scanning-is-now-available/


When is full stack supported?

Problem

Steps To Reproduce
Steps to reproduce the behavior:

Expected behavior

Screenshots

Environment:

Dioxus version:
Rust version:
OS info:
App platform:

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

it is already: I use it every day. Maybe you meant something else than this?

How to use dioxus+axum+sqlx+mysql to build an information management system, is there a tutorial?


Add PHPStan

Codecov Report

Merging #22 (354d8a2) into master (216b022) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
- Coverage     31.12%   30.89%   -0.23%
+ Complexity       96       94       -2
============================================
  Files            14       14
  Lines           302      301       -1
============================================
- Hits             94       93       -1
  Misses          208      208

Impacted Files
Coverage Δ
Complexity Δ

src/Twig/Node/ToggleNode.php
96.29% <0.00%> (-0.14%)
8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216b022...4f18e11. Read the comment docs.


pytest import triggered from main code

https://github.com/sktime/skbase/blob/9a5c70c358ef89b06993148407d93c524141e07a/skbase/base/_base.py#L96
This piece in the main code imports from the testing module. This import then triggers the following line of code:
https://github.com/sktime/skbase/blob/9a5c70c358ef89b06993148407d93c524141e07a/skbase/testing/__init__.py#L5
Which then imports pytest:
https://github.com/sktime/skbase/blob/9a5c70c358ef89b06993148407d93c524141e07a/skbase/testing/test_all_objects.py#L14
pytest is only part of the optional requirements and probably should not be imported in the main code unless it becomes part of the standard requirements.
I ran into this issue in an environment that did not have pytest installed and I was calling .clone() on an estimator that inherited from BaseObject.

yes, this is a duplicate of this one here, right?
https://github.com/sktime/skbase/issues/177

Duplicate of #177

sorry for this @LarsLZondag - __init__ logic is tricky...


Disable skipCI for all-contribs

Description
Makes all-contributors PRs run CI. This will allow us to have required checks and we can start to explicitly require tests to pass.
Fixes #4671
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python -m pytest (or $ nox -s tests)
[x] The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

@all-contributors please add @AndEsterson for infra


Large raw data files problematic for validation

Dicoms or any other large raw image data file can be problematic for validation. Perhaps there can be a way for the validation to detect those type of raw image data files are present and stop the validation with an error?

DICOMs should be ignored if stored in sourcedata/. Large niftis should not pose a problem (only the header is being read). Could you describe the environment and dataset a bit more?

This was helping a user validate their dataset. The validation was being done on a windows 10 OS using Chrome. The issue ended up being that raw image data files and nifti images (with accompanying sidecar jsons) were all together. This was likely creating a memory error and crashing chrome. Once the raw image data files were moved, the validator worked very well and created the report.


⚠ Bofrost.lu has degraded performance

In 0d48335, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1727 ms

Resolved: Bofrost.lu performance has improved in 495053d after 13 minutes.


Support input std::wstring

Some character using 2 byte such as Japanese, Chinese cannot keep in json file.
Could you support input std::wstring.

JSON required UTF-8 at RFC8259

Thank you information.


Distribute HTTP/2 client request load properly among I/O threads

$subject

https://github.com/ballerina-platform/ballerina-lang/issues/13877

https://github.com/wso2/transport-http/pull/308

Fixed with https://github.com/wso2/transport-http/pull/308


networkmanager: 1.16.0 -> 1.18.0

Motivation for this change

build w/iwd support since it's free (no dep required!)
move to iputils for minor utilities, instead of inetutils
libnm-glib has been deprecated for 5 years, don't build support for it

This is the last release offering this as an option

parallel building :)

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/raw/1.18.0/NEWS
Things done
(following is marked based on my testing with a similar branch,
but not exactly current 'staging'.  FWIW.)

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

FWIW been using this on my system since packaging it yesterday morning.

@dtzWill This will conflict with https://github.com/NixOS/nixpkgs/pull/59916

Also we need to keep libnm-glib. See https://github.com/NixOS/nixpkgs/pull/59916#discussion_r277252728

Technically conflicts, but I think it'll be more or less the same before or after.  But might be best to be sure to handle the conflict in the same branch and not burden someone merging staging to master or something :).

Unless there's a strong reason to go the other way 'round (LMK!), I'm happy with (and suggest) we tackle the meson conversion first.  One thing at a time! :)

(or include this in the conversion? Whatever y'all feel is best ^_^)

Enjoyed reading your comments as they came in because we were thinking all the same things :rofl:
Not sure how to go about things, probably path of least resistance :+1:

From the changelog Add support for policy routing rules. yeah sounds cool !

Rebased onto staging, which now has the meson conversion.
Still working on rebuild-all-the-things to test,
but it was straightforward so hopefully works well too :).

On Mon, 22 Apr 2019 20:56:51 -0700, Wael Nasreddine<EMAIL_ADDRESS>wrote:

kalbasit commented on this pull request.

@@ -63,4 +65,3 @@
g_ptr_array_add (argv, "--use-blacklist");
g_ptr_array_add (argv, (char *) arg1);

va_start (ap, arg1);

is this an accidental removal?

Yes and no :).
I did not set out to remove this, and I'm not sure I'm aware it was
removed.
Even so, it wasn't quite "accidental" in that AFAICT it was simply
determined not useful when I generated the patch :).
Perhaps different settings were used previously, but it applies
so I'm inclined to think it's alright.
The next line is still the same, however, so I think if you'd prefer
we can touchup the patch to keep it.

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/60060#pullrequestreview-229339300Non-text part: text/html

Yes and no :). I did not set out to remove this, and I'm not sure I'm aware it was removed. Even so, it wasn't quite "accidental" in that AFAICT it was simply determined not useful when I generated the patch :). Perhaps different settings were used previously, but it applies so I'm inclined to think it's alright. The next line is still the same, however, so I think if you'd prefer we can touchup the patch to keep it.

@cstrahan pointed out that it was actually removed from the patch file itself as opposed to what gets patched by it. My bad not noticing that it can stay like this no problem.

Thanks, all! \o/


Match cpuExecuteLoadStore and cpuExecuteLoadStoreF

These recompile load/store instructions into PowerPC machine code. I've given up on annotating the PPC instructions for now, ideally we'd make macros or inline functions for them but it's not fully clear what those look like yet (e.g. when to use | vs + for immediates)

Yeah, they have jump tables (I added the comment)


Add support for Go

Is your feature request related to a problem? Please describe.
 Coming soon

Hello @dcu!
As @hermescanutodesouza told we are working to support GoLang. Would be great see your PR's helping us here to support GoLang 😃.


feat(typing): type response

follow up of #2299

@vytas7 updated

@vytas7 regarding the failure to install rapidjson in pypy, did you already had a fix in a PR?

@vytas7 regarding the failure to install rapidjson in pypy, did you already had a fix in a PR?

Yes, but that PR still needs work, it is in Draft: https://github.com/falconry/falcon/pull/2324/files#diff-493968368d3cc25459cbc290f4f38ee1444eb298e0c5f840672c3dfce9b9f291R26.

will cherry pick b4a6a4d6e339e243e7802c6153f8c9aa35a9edde

seems to be working. pipeline should now be green


[Core] Migrate managementPolicy to use trait sets

Closes #280.
Sorry if I've missed anything, too many meetings these days!

@feltech I realised this hadn't updated the pure-python tests too. Fixed here.


Implement remaining client search endpoints

Implemented client search endpoints for:

references
readGroupSets
callSets
reads

Did a bunch of refactoring as well.
Does not close #76

This is fantastic @dcolligan, we're really opening up the client side of things here! I've a few comments here and there where things can be improved a little, but I really like this PR in general. I'm slightly uneasy about the google_compliance.py script. This isn't really a compliance tester, more of a way of automating running a bunch of example queries and making sure they output something. I think it's definitely good to have it, as it gets really tedious typing in all these command lines, but compliance should be treated separately in its own first-class CLI program. Perhaps we could rename this to google_examples.py?

I can rename the script to google_examples.py.  It really is necessary at this point since ensuring the correctness of the API without this is quite an effort.  The only way it can really be done is with a live end-to-end test.

Pushed a new commit that addresses @jeromekelleher 's concerns and brings the semantics of variants-search into line with the rest of the search commands.

Looks great, thanks.
+1.

running the example in readme
client_dev variants-search http://localhost:8000 -v 1000g_2013 -r 1 -e 60000 -n rs75454623  | less -S
will give this result:
1000g_2013.10046
can you look into it? maybe it's the print method in the AbstractSearchRunner?

Yeah, that's right.  I didn't really see any point in continuing to use the old print methods.
Until we have some kind of idea of what we want the command line client to print out for reads/variants/etc., it shouldn't really matter how we format the data, as long as it works.  And if someone does have an opinion on this, please file an issue.  Right now I just tend to print out ids of returned objects.

Ah, didn't spot this - thanks for pointing it out @MollyZhang. I'd rather not lose this functionality for variants-search. Perhaps we should have two output modes, detailed by default or just IDs. Each class should provide a printDetail() method which can be called on the type of object they are expecting.
We can do this in a follow up PR if you prefer to merge this in now though.

Yes, I'd like to get this in, and as far as I know no one is depending on the client output.
Please create an issue for client output formatting.

OK, sounds good to me.  Anyone else wants to chime in here? I'll merge in a few hours if there are no further comments.

+1. I've got reservations about the google api bit, but it is obvious that is temporary.

@jeromekelleher I'd held off commenting because it's a huge and complicated change

It's a big change, but it's nearly all client-side stuff which shouldn't impact anyone. Merging; thanks @dcolligan!


Fix RNTester on Windows

Motivation
Currrent, RNTester can not work on windows.

Fixes https://github.com/facebook/react-native/issues/19654.

Test Plan:
pass all current ci.
Release Notes:
[GENERAL] [INTERNAL] [RNTester] - fix RNTester on windows.

I can split the pr, they are in same pr because I want to fix build problem on windows, which still exists (see https://github.com/facebook/react-native/issues/19654).
As for packager.sh, it has to be removed if you want to make it on windows. As for max-workers, I think it can add back.

@pvdz The metro issue has been around for a month. Can you help on this issue ?

@hramos This can be merged.

@gengjiawen I'll defer to @pvdz for approval + merging.

@pvdz Can you merge this pr ?

@gengjiawen Can you confirm this is still an issue on Metro 42.2 (depending on a new version of Babel) and RN 0.57 (which should resolve most pending Windows issues)? The error reported in #19654 was almost certainly caused by the Babel regression that has been fixed by now.
As for this PR, it still drops typing that we want to keep and it still drops a shell script we want to keep so those points have not been addressed.
Please confirm this issue is still blocking you with the latest metro/rn or close this ticket if that's now resolved. Thank you!

The type thing is fixed by metro, I have confirmed here @kelset. As I stated in clarification, My main fix is refactor current unix-like bash to nodejs script so we can test RNTester on windows.

@dulmandakh @janicduplessis Can you guys review my pr ? Thanks.

@rafeca I have updated the code.

This looks good to me, I'm going to import this to Phabricator.
@hramos : any thoughts?


Fix locale file syntax, broken by ai-shifu#924

Something broken in the json files :sweat_smile:

I don't know why this takes so long.


Update sample data fixture file

Re-ordering? What's the PR about?

Re-ordering? What's the PR about?

The sample data file would not get loaded with the way it was ordered before. The tags were being referenced before definition. This resolves that issue so that the file is actually worth something again.

The sample data file would not get loaded with the way it was ordered before. The tags were being referenced before definition. This resolves that issue so that the file is actually worth something again.

should we add a quick unit test that uses this fixture just to make it loads well?

should we add a quick unit test that uses this fixture just to make it loads well?

nice, now I will know if I break it again :-)

nice, now I will know if I break it again :-)

I think you can just do 'fixture = blabla.json' and django will load it for you. But explicit load also works

I think you can just do 'fixture = blabla.json' and django will load it for you. But explicit load also works


Updated gitlab integration to include port

Updated integration module to allow for the use of a custom port, which
is often the case in self hosted gitlab instances.
Removed host.includes(':') check in config.ts to allow for users to
include the port in the host
Changed url.hostname to url.host in core.ts to include the port in the
api call (otherwise it'll result in an error when trying to import a new
component)
With this fix, if you're using a self-hosted gitlab instance with a custom port, you can now add the port in the host in the config as such:

With this fix, we can now import new components stored in our own gitlab instance.
Fixes  #9581
Signed-off-by: Edgar Silva<EMAIL_ADDRESS>

Thanks for this! Think we're just missing some spelling in the changeset, try GitLab and Self Hosted instead, notice the casing is important for the spelling of GitLab.