Add model and agent selectors to frontend

What problem or use case are you trying to solve?
Let the user choose which model and agent they want to use
Describe the UX of the solution you'd like
I'm imagining a toolbar across the top of the chat section, where you can pick a model and an agent
Do you have thoughts on the technical implementation?

Agent can be hard-coded to LangchainsAgent and CodeactAgent for now (bonus points for an API that exposes them)
Model should be taken from https://docs.litellm.ai/docs/providers (is there a way to expose the list via an API in python?)

maybe hard-code a list of popular models if this is hard

prompt for an API key when model changes
Save settings in localstorage

one API key per model

When either option changes, we should send an initialize action on the websocket to re-initialize the agent.

Also nice to have: ability to configure the docker image for the sandbox. The API will need a small adjustment to support this.
We might have a list of suggestions, e.g. for python, node, rust, go, etc


Fix setting confirm flag

It was impossible to set confirm flag due to incorrect comparison.
In this point of time state->image_ok is already decoded and contains
one of following values:
If BOOT_FLAG_UNSET then we are ok to set a confirm flag.

Looks correct to me, also the copy_done above has the same "bug". I'll just check first if it's straight-forward to add testing of this change to the sim.

Commit message looks like it missing a list of values. we don't use this in zephyr - that why I didn't encounter this bug.


(prerelease) directrix deception

slate paths behind a directrix count towards circle ambit even if they are dead ends

This is intended behavior, kind of, because the circle can't know "ahead of time" if it's a closed loop.


Gracefully parse 'super' with type arguments

From test superWithTypeArgument3:

We can just parse and throw away the results. If we're certain that this could be a call, we should just parse  as a super() invocation to avoid downstream errors.

Just curious, why that would be needed? super for the derived class is a concrete type, so what would that type arguments in super mean?

+1 to @Igorbek 's comment, what's the intent here?

Sorry to be obtuse as well, but since the generics aren't required on the constructor, why would they be required on the super?  The  It would be like having to write this, which isn't logical:
class D extends C  {
    constructor<T>() {
        super<T>();
    }
}

The intent is that instead of letting new users grapple with parse errors, we should give the most helpful experience we can. The fact that we understand why this doesn't work isn't indicative that newer users will immediately pick up on it.

Just to clarify, sometimes we change the parser to accept things we know aren't legal so that the errors are easier to understand. For example, this is never legal:
public class Foo {

}

A naive parser would just say "Unexpected token 'class'" but instead we parse it anyway and then later issue a more helpful "Can't use that modifier here" error

Thanks for articulating. I could've probably been a little clearer on that. 😄


Simple payload - Validated

23 byte payload as per documented design

Signed-off-by: c19x<EMAIL_ADDRESS>

Simple payload cross-platform validation - COMPLETE

Validated with Android implementation of SimplePayload to confirm they are entirely compatible
Validation covered all public data types (unit8, unit16, float16, matchingKey, contactKey, contactIdentifier)
Validation covered key derivation procedure (secretKey -> matchingKeySeed -> matchingKey -> contactKeySeed -> contactKey -> contactIdentifier) across both days and periods.

Tested and confirmed valid as per design.


implementations: "this function is not a method" error could just simply be "no results"

If you find implementations on a function rather than a method, you get an error:

Error getting implementations: This function is not a method

e.g. https://sourcegraph.com/github.com/sourcegraph/go-langserver/-/blob/langserver/implementation.go#L65:6&tab=impl
Of course, finding implementations on a function doesn't make sense. It only works on interface types and methods (finding the interfaces that implement that method).
We could make this error less confusing by e.g. just returning no error and simply returning no results.
The error originates from here: https://sourcegraph.com/github.com/sourcegraph/go-langserver@bf90fac03a4d1a07f50701547d56fabfdb0c32ec/-/blob/langserver/implementation.go#L76:30

IMHO, present error is better as it is a no-go for a function or method to be implemented. I also wonder how it would work on methods. Sounds illogical to me.

The language server client (e.g. editors) shouldn't need to know a priori if a given location in a file is a valid location to call "find implementations". No results instead of an error makes sense to me.

I'm not sure that that's right FWIW, or it might be masking an error.
Calling "find implementations" on MustParse in github.com/kevinburke/aws-vault/vendor/github.com/alecthomas/kingpin.v2 should return at least one implementation, in github.com/kevinburke/aws-vault/main.go, but it doesn't find it.
local URL is http://localhost:7080/github.com/kevinburke/aws-vault/-/blob/vendor/gopkg.in/alecthomas/kingpin.v2/global.go#L84:6&tab=impl

@kevinburke Find implementations finds methods which implement an interface methods. What you are referring to is find references. In this case it works https://sourcegraph.com/github.com/kevinburke/aws-vault/-/blob/vendor/gopkg.in/alecthomas/kingpin.v2/global.go#L84:6=&tab=references

I suppose but I guess even if I'm calling it incorrectly, it would be nice if the error message was clearer, for example, it could say "this function is not an interface definition" instead of "this function is not a method", the latter of which doesn't make much sense.


TILA-2003 | Reservation adjust time mutation

Change log

Add new mutation reservationAdjustTime

Enables reservation time change for reservee or staff user.

Other notes
Done a bit of a refactor within the changes so commit kinda yuge 🙈

I wonder if it would make sense to extract those mixing classes into a separate file just to cut down the number of lines in one file. Might be good, might be bad. Don't know, really 🤔

Yes that would be nice and then I would actually refactor every serializer in its own file under resrevation_serializers/ But chose not to do that within this. But something to perhaps do in the near future 👍


Numba 0.52.0RC1 / llvmlite 0.35.0RC1 checklist

llvmlite

[x] Merge to master (when approved):

[x] https://github.com/numba/llvmlite/pull/626
[x] https://github.com/numba/llvmlite/pull/627

[x] merge change log changes (https://github.com/numba/llvmlite/pull/643)
[x] Create 0.35 release branch
[x] Annotated tag 0.35.0rc1 on branch
[x] build on buildfarm (remember to check the "upload" box)
[ ] build wheels (3.6, 3.7, 3.8)
[ ] upload wheels and sdist to PyPI
[x] verify conda packages uploaded to Anaconda Cloud and in main channel

Post RC:

[ ] Tag 0.36.0dev0 on master to start new cycle

numba 0.52.0

[x] Merge to master:

[x] - https://github.com/numba/numba/milestone/40

[x] merge change log changes

[x] - https://github.com/numba/numba/pull/6365

[x] Create 0.52 release branch
[x] annotated tag 0.52.0rc1 on release branch
[x] build conda packages on buildfarm
[ ] build wheels (3.6, 3.7, 3.8)
[ ] upload wheels and sdist to PyPI
[ ] Verify packages uploaded to Anaconda Cloud
[ ] Send RC announcement email / post announcement to discourse group
[ ] Post link to twitter

Post RC:

[ ] Tag 0.53.0dev0 to start new cycle

Release announcement: https://numba.discourse.group/t/numba-0-52-0-and-llvmlite-0-35-0-release-candidates/284
0.52.0RC2 outstanding tickets are here: https://github.com/numba/numba/milestone/48


Develop

I've added some comments!
Good work mate! 💪

Niceee, goood catches with the variable namings! Solved it with this one https://github.com/smartive-education/app-musketeers/pull/57
Thanks!


feat: ipc-multiple-player

Owner

[x] Nickname(Tuya): 伽拉
[x] Intra-group review（组内审阅人员）：萧瑟

Description
ipc-multiple-player component.
Package
Please select the relevant package.

[ ] tuya-panel-animation-sdk
[ ] tuya-panel-api
[ ] tuya-panel-electrician-sdk
[x] tuya-panel-ipc-sdk
[ ] tuya-panel-lamp-sdk
[ ] tuya-panel-lock-sdk
[ ] tuya-panel-robot-sdk
[ ] tuya-panel-outdoor-sdk

Type of change
Please select the relevant option.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Self CheckList
Please check all options.

[x] Intra-group review
[x] ESLint lint
[x] Example Run
[x] Jest Run
[x] No Grammer Error
[x] No Spell Error
[x] No Merge Conflict

LGTM

Codecov Report

Merging #179 (c3bec10) into main (1e9c794) will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   61.57%   62.00%   +0.42%
==========================================
  Files         320      342      +22
  Lines       12100    12829     +729
  Branches     2818     2900      +82
==========================================
+ Hits         7451     7955     +504
- Misses       4617     4854     +237
+ Partials       32       20      -12

Impacted Files
Coverage Δ

packages/tuya-panel-lock-sdk/src/utils/index.tsx
73.07% <0.00%> (-26.93%)
:arrow_down:

...-panel-ipc-sdk/src/ty-ipc-native/nativeManager.tsx
9.20% <0.00%> (-0.74%)
:arrow_down:

...-ipc-sdk/src/ty-ipc-native/player-manager-func.tsx
16.05% <0.00%> (-0.36%)
:arrow_down:

packages/tuya-panel-api/src/lamp/general.ts
13.61% <0.00%> (ø)

packages/tuya-panel-api/src/robot/gyroDataApi.ts
9.72% <0.00%> (ø)

packages/tuya-panel-api/src/robot/laserDataApi.ts
8.88% <0.00%> (ø)

...l-gateway-sdk/src/components/setPassword/index.tsx
48.27% <0.00%> (ø)

...l-lamp-sdk/src/components/rhythms-circle/index.tsx
40.52% <0.00%> (ø)

...-gateway-sdk/src/components/addDeviceTip/index.tsx
40.74% <0.00%> (ø)

...rician-sdk/src/components/curtain/curtain-base.tsx
1.03% <0.00%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e9c794...c3bec10. Read the comment docs.


API to check operation conditions

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b9164e9f-178d-835e-0305-e95c449e04dd
Version Independent ID: 8c2f234f-027d-e066-d3ce-460f2378c567
Content: Product configuration overview - Supply Chain Management | Dynamics 365
Content Source: articles/supply-chain/pim/build-product-configuration-model.md
Service: dynamics-365-supply-chain
GitHub Login: @t-benebo
Microsoft Alias: benebotg

Bug 834389 has been logged to address this issue.

Thanks for your feedback. We are closing this issue because we are either unable to find relevant information or reproduce this. If you're still experiencing the issue described here, please reopen or create a new issue.


USB communication related issue on C5-BTLE

To create this issue DEFAULT_EMULATED_DATA_STATUS was enabled. Thereafter when USB port was connected to PC it was found that BLE transfer speeds visibly slowed down.
Removing the USB port caused the BLE transfer to reach its initial transfer speed.
It was also found that issuing an openxc-dump command caused communication to work unaffected simultaneously when BLE and USB were connected.

There's a bit more background on this issue here: https://github.com/openxc/vi-firmware/blob/next/src/platform/pic32/usb.cpp#L114-L118
The short summary is that the USB API for the PIC32 (or at least the way I found to use the API) requires spinning waiting for a handle to be not busy, so if USB is connected but not trying to read data, it will slow down the main loop. There may be a way to use interrupts instead.


Add optional required parameter to Joystick constructor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 4 (25.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.273%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

observation/sources/Joystick.cpp
1
4
25.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
1332

Relevant Lines:
1619

💛  - Coveralls


Replace Tanstack From Integration with Formik in Input Components (In Upcoming Release)

Instead of Tanstack form which is in v0. It would be better to add integration with Formik. which is widely used and has rich and mature features

I'm not entirely sure if that's the right move. I'd recommend reading through this discussion on the current state of Formik: https://github.com/jaredpalmer/formik/discussions/3526.
Given the information in the discussion, I have reservations about whether ShadCN should choose to use Formik.

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Expose desired_maximum_frame_latency through window creation

Objective

Closes #12930.

Solution

Add a corresponding optional field on Window and ExtractedWindow

Changelog
Added

wgpu's desired_maximum_frame_latency is exposed through window creation. This can be used to override the default maximum number of queued frames on the GPU (currently 2).

Migration Guide

The desired_maximum_frame_latency field must be added to instances of Window and ExtractedWindow where all fields are explicitly specified.

Sorry for getting back late, did some quick testing with pipelined rendering disabled to see if switching to one frame for that case might make sense, running on this scene I got way worse frame times (80 against 50 fps), and worse latency (40 against 50ms) using Presentmon.


CodePush React: Adds a flag to  specify a custom React Native project name

Discussion
When creating a React Native project, one can specify a name which becomes the iOS project name. By default this name is saved into package.json, and this CLI tool will attempt to read from there to derive the name.
However, it is not uncommon for the package.json name to change (e.g. to fit into yarn workspaces).
Therefore, it seems appropriate that a developer would want to change this name and override the automatically discovered name when necessary.
Solution
Add a flag to the CLI which lets a developer specify the name used when creating a React Native project.
Example Usage
> appcenter codepush release-react -a foo/bar --deployment-name Staging -m --description "Foo Bar" --project-name app

Expected Result:
If the React Native name was app when the project was created, the XCode Project will be named app.xcodeproj. Thus specifying --project-name app will point the CLI to ios/app.xcodeproj when building to auto-detect the version.

/azp run

+1

Hi guys. This was fixed here: https://github.com/microsoft/appcenter-cli/pull/1497.
I'm closing this PR.


More Gambit-y errors from the macro expander

Right now, macro expansion errors are reported with the error procedure. For instance, (cond-expand a) generates the error *** ERROR IN ##main -- Invalid cond-expand form:  (cond-expand a), but this is not optimal, since it doesn't give information about the source location. In Gambit there is a procedure called c#compiler-user-error which is used internally to generate Gambit's error messages. It might be better to use that instead of just error.
I'm not entirely sure that this is a desirable thing, but I think so. Fixing this would mean to implement a small utility function that calls c#compiler-user-error and put it in util.scm, and then searching through the calls to error in hygiene.scm, replacing the calls where appropriate.

Vote for this features :)


Super scaffolding breaks roles.yml with improper indentation

I did this:
./bin/super-scaffold crud Billing::SubscriptionExtension Team extension_team_id:super_select{class_name=Team} --trace

And got this output:
Writing './app/controllers/account/billing/subscription_extensions_controller.rb'.
Fixing Standard Ruby on './app/controllers/account/billing/subscription_extensions_controller.rb'.
Writing './app/views/account/billing/subscription_extensions/index.html.erb'.
Writing './app/views/account/billing/subscription_extensions/_menu_item.html.erb'.
Writing './app/views/account/billing/subscription_extensions/_index.html.erb'.
Writing './app/views/account/billing/subscription_extensions/_subscription_extension.html.erb'.
Writing './app/views/account/billing/subscription_extensions/edit.html.erb'.
Writing './app/views/account/billing/subscription_extensions/show.html.erb'.
Writing './app/views/account/billing/subscription_extensions/_form.html.erb'.
Writing './app/views/account/billing/subscription_extensions/new.html.erb'.
Writing './app/views/account/billing/subscription_extensions/_breadcrumbs.html.erb'.
Proceeding to generate './app/views/api/v1/billing/subscription_extensions'.
Writing './app/views/api/v1/billing/subscription_extensions/_subscription_extension.json.jbuilder'.
Writing './app/views/api/v1/billing/subscription_extensions/index.json.jbuilder'.
Writing './app/views/api/v1/billing/subscription_extensions/show.json.jbuilder'.
Writing './config/locales/en/billing/subscription_extensions.en.yml'.
Writing './app/controllers/api/v1/billing/subscription_extensions_controller.rb'.
Fixing Standard Ruby on './app/controllers/api/v1/billing/subscription_extensions_controller.rb'.
Writing './test/controllers/api/v1/billing/subscription_extensions_controller_test.rb'.
Fixing Standard Ruby on './test/controllers/api/v1/billing/subscription_extensions_controller_test.rb'.
Updating './test/factories/billing/subscription_extensions.rb'.
Updating './app/models/team.rb'.
rake aborted!
Psych::SyntaxError: (<unknown>): mapping values are not allowed in this context at line 4 column 9
<internal:/Users/jgreen/.asdf/installs/ruby/3.2.1/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
<internal:/Users/jgreen/.asdf/installs/ruby/3.2.1/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
Tasks: TOP => bullet_train:super_scaffolding
(See full trace by running task with --trace)

Adding --trace didn't get me any additional info.
I finally traced the issue down to the fact that the first few lines of roles.yml had been updated to this:
default: # AKA : listener
  models:
  Billing::SubscriptionExtension: read

Instead of this:
default: # AKA : listener
  models:
    Billing::SubscriptionExtension: read

I corrected the indentation and then re-ran the scaffolding command and then the rest of the scaffolding process seemed to work.

Strange, the indentation is working for me 🤔 Can I ask what you wrote for rails g model?

I think it was something like rails g model Billing::SubscriptionExtension team:references extension_team:references.

Looked over this one again today, can't seem to reproduce... I don't want to close it though if it really is a problem, so I think I'll leave this one be until we can pin down what the actual issue is.
If anything, the only thing that comes to mind is the BlockManipulator and how we've changed the indentation logic in the past. Will consider looking into that if we make any progress.

I just tested this again and it has something to do with the comment on the first line. With no trailing comment everything works as expected, but a trailing comment on either of the first to lines causes different problems.
With this I get the error and broken indentation described in the original issue.
default: # test
  models:
    Team: read

With this there's no error thrown, but the new model ends up being added in the wrong spot.
default:
  models: # test
    Team: read

Instead of the new model being added under default.models it's added under editor.models.
default:
  models: # test
    Team: read
    Membership:
      - read
      - search
    Platform::Application: read
    Webhooks::Outgoing::Endpoint: manage
    Webhooks::Outgoing::Event: read
    Webhooks::Outgoing::Delivery: read
    Webhooks::Outgoing::DeliveryAttempt: read
    Invitation:
      - read
      - create
      - destroy

editor:
  models:
    Billing::SubscriptionExtension: read
    Scaffolding::CompletelyConcrete::TangibleThing: manage
    Scaffolding::AbsolutelyAbstract::CreativeConcept:
      - read
      - update

admin:
  includes:
    - editor
  manageable_roles:
    - admin
    - editor
  models:
    Billing::SubscriptionExtension: manage
    Team: manage
    Membership: manage
    Scaffolding::AbsolutelyAbstract::CreativeConcept: manage
    Platform::Application: manage

I suspect the problem is here:
https://github.com/bullet-train-co/bullet_train-core/blob/779fdd93b6414953e3cdfab8c4e4d9e219af47a6/bullet_train-super_scaffolding/lib/scaffolding/file_manipulator.rb#L53
We're expecting the line to exactly match instead of checking that it starts with the right thing. Or maybe we should strip comments and then check for an exact match?


Migrated code to null-safety

Please note: currently, there are immense issues with the map view provided by flutter_map. These issues are fixed in https://github.com/fleaflet/flutter_map/pull/923. You should not merge this PR until flutter_map published 0.13.1.

Dear @TheOneWithTheBraid the dev branch already contains null safety. Can you please rebase your PR against that branch and see if something is missing?
I'll merge that branch soon into the master if flutter_map has published that version.

@Xennis If dev already contains null safety, I don't think it's necessary to merge this branch. I would rather propose to close this PR in favor of merging dev into master and afterwards publishing master to pub.dev.

If you don't mind, I will open a clean PR fixing the dependecy issues.

Great :+1:
Now null safety is merged into the master #63 A release will follow soon.


Final copy changes for /info & pre-audit

Once this passes, I'm just going to merge this, as it is 100% copy.


Fix index out of bounds crash in HttpHeaderHelper.findCharset

Sending an HTTP request with the header "Content-Type: foo/bar; charset="
would previously make this method throw a StringIndexOutOfBoundsException
that would go uncaught and cause a 500 response:
java.lang.StringIndexOutOfBoundsException: String index out of range: 0
        at java.lang.String.charAt(String.java:658)
        at org.apache.cxf.helpers.HttpHeaderHelper.findCharset(HttpHeaderHelper.java:90)

FYI, http://git-wip-us.apache.org/repos/asf/cxf/commit/59b87cad, I did not apply the patch directly, as I renamed the tests. Please close this request yourself. Thanks

Cool, thanks! I don't quite understand why you didn't just make your changes as follow-up commits, which would have better preserved my authorship, but alright.

Sure, I'll explain. I did not like the actual test name and I thought it was not a very useful test as it was only 'asserting' that the given line runs - hence I added two tests explicitly checking two error situations.
The commit message refers to your alias.
Cheers

(Sorry for taking so long to respond)
Sure, I have no problem at all with the changes you made. It's just that I would in the same situation instead have made those changes in additional commits instead of starting a completely new, unrelated (as far as Git is concerned) branch.

isn't this patch encouraging the invalid charset parameter usage?
SIOOBE was bad but shouldn't we be throwing some invalidity exception or at least write a WARN log to signal potentially the content may not be correctly decoded?

My thinking when writing the patch was that charset= should probably be handled in the same way as if the charset parameter wasn't present at all. Now that you point it out, this decision is indeed questionable. The presence of the parameter, but with an invalid value, is indeed different from

Oops, accidentally hit the reopen button while writing.

Hi emlun - sure I'll bear that in mind when merging your next patch, hi Aki - I think there was a code there already defaulting to UTF-8, but if you think something may need to be fixed we can definitely do it :-)

@sberyozkin somewhere I remember reading the missing charset is supposed to be interpreted as charset utf-8 in http. But the current mime RFC [1] as well as w3c's internationalization document both mention the missing charset means iso-8859-1. So, I don't remember where I read the defautl utf-8 convention.
But here I was talking about not the default but the invalid charset syntax. Something went wrong or programmed wrong and a client is sending a content-type header with
Content-Type: text/xml; charset=
The above specs say the charset value must be a valid IANA charset value.  In this case, we don't know why the client generated this invalid charset entry. Was it trying to set the system default charset and didn't realize the value was null? Or something else went wrong? Hence, simply ignoring this invalid charset parameter and defaulting to utf-8 will hide this problem from our eyes and potentially lead to the incorrect decoding.
[1] https://tools.ietf.org/html/rfc7230
[2] http://www.w3.org/International/O-HTTP-charset#charset

Sorry, I meant ISO-8859-1, my fault. As far as the actual defaulting is concerned, I've no strong opinion here, the older code was interpreting the absence of the charset by defaulting to ISO-8859-1. I'm not sure if having 'charset=' is equivalent to omitting a charset or to a bad client request situation...

emlun, how did you have a 'charset=' created, do you use some existing REST client that does it ?

I think I had charset= as an explicit test input (though perhaps
inadvertently) in an integration test at some point, while testing that a
web application should refuse non-JSON input. It's not in my test suite
anymore, however.
On Tue, 27 Oct 2015 12:08 sberyozkin<EMAIL_ADDRESS>wrote:

emlun, how did you have a 'charset=' created, do you use some existing
REST client that does it ?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/cxf/pull/89#issuecomment-151457709.


Command failed : sass

I installed the plugin, and turned it on by going to Packages > Atom SASS > compile file and it says it's watching for SASS.
THen when I save my style.scss file I get this error:
Command failed: sass "/home/jameswelbes/jwdigital/assets/scss/style.scss" "/home/jameswelbes/jwdigital/assets/scss/style.css"
/bin/sh: 1: sass: not found
Is this some kind of permissions issue?

Hey! Well, that's not my package you are talking about ;) My package does not add "Atom SASS" entry in main menu. Perhaps you are using this package?

whoops! haha sorry =]


add headers to postfix summary mail

this PR adds the To, Content-Transfer-Encoding and Content-Type headers to the postfix summary mails

not sure why the travis tests fail, they work locally
but the one test affected by this change also works on travis (ok 160 checking pflogsum delivery)


CXF-9055 Follow OpenTelemetry semconv for trace span and its attributes

Add missing span attributes to comply with OpenTelemetry semantic conventions
Test the span attribute names and values
Couldn't add the attributes "network.protocol.version" for the client http span, because we didn't find a way to find its value.

BREAKING CHANGE: Client span name was renamed to the URL path instead of the full URL
Link to the Jira ticket: CXF-9055 Follow OpenTelemetry semantic conventions for trace span and its attributes

Thanks for the pull request, @csemaan1A ! I would suggest to preserve the span name (as you highlighted, it is breaking) to have consistent behavior across CXF tracing integrations, thank you.

Thanks for the pull request, @csemaan1A ! I would suggest to preserve the span name (as you highlighted, it is breaking) to have consistent behavior across CXF tracing integrations, thank you.

I renamed it to have only the path to be aligned with the semantic convention of OpenTelemetry.
Keep in mind, that the server span name is set to path, not the full URL.
So what do you think?

I renamed it to have only the path to be aligned with the semantic convention of OpenTelemetry.

Thanks, I read the recommendations and I don't see much of controversy here. Yes, the it has more than path (too specific) but what is more important - we are not adding blanket implementation. I would prefer to not break things.

Thanks a lot @csemaan1A !


Unable to install gem chef-provisoning-google

Hello team,
I am trying to install chef-provisioning-google gem and getting an error specifying that there is no gem. I tried to install it from the git source directly but it is getting failed. Can anyone help me on this.

We don't currently have a gem pushed to Rubygems. Now that the refactoring PRs have been merged I'm planning to push the 0.1 version to Rubygems.

Thanks for the response. I was now able to work with chef-provisioning-google by creating a gem of my own and installed it.

I pushed the gem today so you can use the official 0.1 release. Thanks for bringing it up. We would have missed it without the nudge.


sass color variables preview

Ionic version:  (check one with "x")
[x ] 2.x
I'm submitting a ...  (check one with "x")
[ x ] feature request
Current behavior:
In src/theme/variables.scss, the$colors variable defines the default color palette.

Expected behavior:
In Visual Studio Code, we don't get color preview for the $colors variable unless we trick the editor into thinking the colors are css color properties.

As far as I am aware, no one has made a VS Code plugin to preview SASS color variables. To be able to preview the colors would be great; otherwise, you always need to refer to an outside guide and tools to verify the colors you are working with.
How does the Ionic team recommend dealing with this issue?

Hello! Thanks for opening an issue with us! So unfortunately there is not much we can do about missing functionality in an IDE. I would recommend checking out some of the sass plugins for vscode or posting an issue on the vscode repo to get this feature built in to vscode itself. Thanks!


Improves documentation to recommend ManifestFilesMixin

Adds ManifestFilesMixin as alternative to CachedFilesMixin and links
to Django documentation.

Thanks a lot, merged in 60ca93092db3389cd2694deeaa298732b363fbd9.


goal: dartanalyzer --use-cfe switched to the default

The CFE integration work is suspended, so this will not be addressed.


feat(kernels): implement pre-processing components of grisubal

Summary of the changes if needed.
Scope

[x] Code

Type of change

[x] New feature(s)

Codecov Report
Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 82.41%. Comparing base (70ecf3e) to head (7d075b9).
Report is 1 commits behind head on master.

Files
Patch %
Lines

honeycomb-kernels/src/grisubal/inp.rs
0.00%
18 Missing :warning:

honeycomb-kernels/src/grisubal/grid.rs
0.00%
17 Missing :warning:

honeycomb-kernels/src/grisubal/mod.rs
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   83.31%   82.41%   -0.90%
==========================================
  Files          31       31
  Lines        3134     3168      +34
==========================================
  Hits         2611     2611
- Misses        523      557      +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Default load (no strategies) should not include effects of HHPs

Right now you cannot see what would happen to the load IF strategy "switch to gas if congested" would be absent:

If "switch to gas" is not chosen, what is the preferred behaviour?

Use the electricity component, but still do not exceed network capacity, and disable the gas part.
Use the electricity component, exceeding network capacity if necessary, and disable the gas part.
Turn off both components and use other technologies to fulfil demand.

If "switch to gas" is not chosen, what is the preferred behaviour?

None of the above :laughing:

Use the electricity component as much a possible even if it exceeds the network capacity. Now for the exceptions. Do not use the electricity if:

Capacity of the buffer is insufficient to fulfil demand
The energy stored in the buffer (kWh) plus what the electrcity-part can do is insufficient to fulfil demand
The 'binary' profile dictates that the electricity part should be shut off

Do not use the electricity if:

Capacity of the buffer is insufficient to fulfil demand
The energy stored in the buffer (kWh) plus what the electrcity-part can do is insufficient to fulfil demand
The 'binary' profile dictates that the electricity part should be shut off

(2) and (3) turn out to be very simple, but I don't think I'll be able to satisfy (1). The capacity of a buffer dictates the amount of energy which can be taken from the storage (tank?) to satisfy demand. For example:

We have a full buffer with a capacity of 10kW,
An attached technology whose capacity is 15kW
And demand of 20kW

... the buffer "produces" 10kW from storage, and the technology runs at 10kW, satisfying demand.

We have an empty buffer with a capacity of 10kW
An attached technology whose capacity is 15kW
And demand of 20kW

The technology will run at 15kW in order to satisfy as much demand as possible. As I understand it, you propose to disable the tech completely because buffer capacity (10kW) is less than demand (20kW)?

Do not use the electricity if:

Capacity of the buffer is insufficient to fulfil demand
The energy stored in the buffer (kWh) plus what the electrcity-part can do is insufficient to fulfil demand
The 'binary' profile dictates that the electricity part should be shut off

f24a2d9 disables the HHP congestion strategy by default, with (2) and (3) done. I'll see what I can do about (1) tomorrow morning.
Moses Beta LES-436

f24a2d9 disables the HHP congestion strategy by default, with (2) and (3) done. I'll see what I can do about (1) tomorrow morning.

:+1:


[SPARK-25237][SQL]remove updateBytesReadWithFileSize because we use Hadoop FileSystem s…

…tatistics to update the inputMetrics
What changes were proposed in this pull request?
In FileScanRdd, we will update inputMetrics's bytesRead using updateBytesRead  every 1000 rows or when close the iterator.
but when close the iterator,  we will invoke updateBytesReadWithFileSize to increase the inputMetrics's bytesRead with file's length.
this will result in the inputMetrics's bytesRead is wrong when run the query with limit such as select * from table limit 1.
because we do not support for Hadoop 2.5 and earlier now, we always get the bytesRead from  Hadoop FileSystem statistics other than files's length.
How was this patch tested?
manual test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@wzhfy

Can one of the admins verify this patch?

ok to test

this seems to be caused by removing support for Hadoop 2.5 and earlier? cc original authors @cloud-fan @srowen to make sure

test this please

Is it difficult to add tests for checking the metric in the case select * from t limit 1?

btw, can you clean up the title and the description..?

I'm not sure we can test the case though, for example, how about the sequence below?

import org.apache.spark.TaskContext
spark.range(10).selectExpr("id AS c0", "rand() AS c1").write.parquet("/tmp/t1")
val df = spark.read.parquet("/tmp/t1")

val fileScanRdd = df.repartition(1).queryExecution.executedPlan.children(0).children(0).execute()

fileScanRdd.mapPartitions { part =>
  println(s"Initial bytesRead=${TaskContext.get.taskMetrics().inputMetrics.bytesRead}")

  TaskContext.get.addTaskCompletionListener[Unit] { taskCtx =>
    // Check if the metric is correct?
    println(s"Total bytesRead=${TaskContext.get.taskMetrics().inputMetrics.bytesRead}")
  }
  part
}.collect

It's OK to assume Hadoop 2.6+ only. In fact 2.6 is quite old anyway.

@maropu I have added a ut to check the inputMetrics

ok to test

Test build #95508 has started for PR 22232 at commit 1c32646.

Test build #95508 has finished for PR 22232 at commit 1c32646.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95508/
Test PASSed.

@dujunling I personally think this can be merged, but only if the test is tightened up

I think that's fine @maropu ; we can always apportion credit appropriately later.


[Feature Request] Prevent Military and helicopter spawns

It would be amazing to have an option to prevent military and helicopter spawns built in.

this is very non essential (doubt itl get high priority unless its very simple to do) but would be awesome for rp , could also add it to the clubs that dont have default music and someone could rp as the DJ.

yea this is needed i know i saw on another server that they just have a block on them to get in but they still spawn

I've looked into that solution myself and all it does is check if you're in it and delete if used.

no ive seen a server that if you try to get in a text pops up on the screen that you cant do that and thats it. they are there always but never enterable.

Not planned, vRP doesn't aim to implement everything (it's not a collection of script), but only what is required for the RP. I don't think flying things are too much invasive.


Produce separate reference package for runtime store generation

There is a lot of code duplication here. For example BuildAllMetapackage and BuildRSReferencePackage targets uses mostly the same logic and can be cleaned up. Same with the Add*References.cs build tasks. This change will also allow us to avoid building then unpacking and repacking the .All metapackage. These changes will follow in a cleanup PR later (I'll file an issue) but I want to do the minimal amount of required work for now to get the builds running.

I'd rather implement it "right" the first time. It's actually more work to refactor this later, and these kinds of cleanup often get dropped. But I understand the time crunch. Can I help on this one?

Talked in person. :shipit:  for now. We'll cleanup next week.

Followup filed in https://github.com/aspnet/Universe/issues/600.


Major and minor updates

This PR allows editors to specify major/minor updates do documents and to add a change note to the change history if the change is major. The workflow UI is slightly different to what exists in Specialist Publisher at the moment but it is more similar to the UI within Whitehall.  Ticket.
Screenshot:

One comment, otherwise :+1:

@h-lame I agree with your comment, but we have payload mutating happening in other Apps. If it's a blocker I'll change it to what you've suggested, but the logic is pretty opaque either way and IMO my code comments explain what's going on. No bother if you think otherwise and have a better way to do the same thing without becoming more confusing.

@tommyp If there's precedent that probably takes priority - and your comments are clear.  Leave it as-is.


Add DynamicObjects::try_parse for typed object conversion

Signed-off-by: Jessie Chatham Spencer<EMAIL_ADDRESS>
Motivation
Issue #1029 requests a method to convert a DynamicObject into a Resource. Such a method would avoid having to repeatedly implement this logic.

Solution
This PR implements the DynamicObject::try_parse method to facilitate easy conversion from a DynamicObject to a Resource. The method uses serde_json to first serialize the DynamicObject and then deserialize the JSON to the Resource.
A small error type ParseDynamicObjectError has been implemented as well to represent a parsing failure. It wraps the original serde_json::Error so the original error information is preserved.

Codecov Report

Merging #1061 (2780f2e) into main (da6b5e7) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
+ Coverage   72.34%   72.35%   +0.01%
==========================================
  Files          65       65
  Lines        4704     4713       +9
==========================================
+ Hits         3403     3410       +7
- Misses       1301     1303       +2

Impacted Files
Coverage Δ

kube-core/src/dynamic.rs
70.58% <88.88%> (+3.92%)
:arrow_up:

kube-runtime/src/wait.rs
69.81% <0.00%> (-1.89%)
:arrow_down:


since 2 days access tokens give an error

Hi,
Since 1-2 day my spotify service broke down (basyl.stream). I didn't touch anything, so I'm figuring out what could be the cause of this.
The reason that I post this issue, is to figure out if other people had a same issue suddenly (maybe something changed on the Spotify side).
The strange thing is that a service I run with the same Spotify account and credentials still keeps working. For that service I don't use the "new" refresh implementation, but a try-catch function (as once suggested, before this was implemented in the web-api): https://github.com/jwilsson/spotify-web-api-php/issues/237#issuecomment-964478065
Below the error details (I don't know if there exist already a better way to print it, since some details seem to be cut a way).
Fatal error:  Uncaught SpotifyWebAPI\SpotifyWebAPIException: Invalid access token in /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php:47
Stack trace:
#0 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php(244): SpotifyWebAPI\Request->handleResponseError('{\n  "error": {\n...', 401)
#1 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php(132): SpotifyWebAPI\Request->send('GET', 'https://api.spo...', 'fields=name%2Ce...', 'HTTP/2 401 \r\nww...')
#2 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/SpotifyWebAPI.php(124): SpotifyWebAPI\Request->api('GET', '/v1/playlists/6...', Array, Array)
#3 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/SpotifyWebAPI.php(1275): SpotifyWebAPI\SpotifyWebAPI->sendRequest('GET', '/v1/playlists/6...', Array)
#4 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php on line 47

I did some tests.
The client_id/secret/refreshtoken seem to work fine. I'm able to obtain a new accessToken. However, when I use it print_r($api->me());, it directly says its invalid.

I made a minimal example. Like mentioned with an old version of your API (I'm not sure which version, I think 3 or 4) I can get access correctly.
I have this example and the print_r output of the $api. I'm curious if you see something wrong.
$session = new SpotifyWebAPI\Session(CLIENT_ID,CLIENT_SECRET);

$session->setAccessToken($spotifyAuth['sp_access_token']);
$session->setRefreshToken($spotifyAuth['sp_refresh_token']);

$options = [
    "return_assoc" => true,
    "auto_refresh" => true,
    "auto_retry" => true
];

$api = new SpotifyWebAPI\SpotifyWebAPI($options,$session);
print_r($api);

$options = ['fields' => 'name, collaborative, followers, public, snapshot_id, tracks.total'];
$sp_playlist_details = $api->getPlaylist($destinationList, $options);

print_r($sp_playlist_details);

This gives the following output:
SpotifyWebAPI\SpotifyWebAPI Object
(
    [accessToken:protected] =>
    [lastResponse:protected] => Array
        (
        )

    [options:protected] => Array
        (
            [auto_refresh] => 1
            [auto_retry] => 1
            [return_assoc] => 1
        )

    [request:protected] => SpotifyWebAPI\Request Object
        (
            [lastResponse:protected] => Array
                (
                )

            [options:protected] => Array
                (
                    [curl_options] => Array
                        (
                        )

                    [return_assoc] =>
                )

        )

    [session:protected] => SpotifyWebAPI\Session Object
        (
            [accessToken:protected] => <redacted>
            [clientId:protected] => <redacted>
            [clientSecret:protected] => <redacted>
            [expirationTime:protected] => 0
            [redirectUri:protected] =>
            [refreshToken:protected] => <redacted>
            [scope:protected] =>
            [request:protected] => SpotifyWebAPI\Request Object
                (
                    [lastResponse:protected] => Array
                        (
                        )

                    [options:protected] => Array
                        (
                            [curl_options] => Array
                                (
                                )

                            [return_assoc] =>
                        )

                )

        )

)

Fatal error:  Uncaught SpotifyWebAPI\SpotifyWebAPIException: Invalid access token in /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php:47
Stack trace:
#0 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php(244): SpotifyWebAPI\Request->handleResponseError('{\n  "error": {\n...', 401)
#1 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php(132): SpotifyWebAPI\Request->send('GET', 'https://api.spo...', 'fields=name%2C+...', 'HTTP/2 401 \r\nww...')
#2 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/SpotifyWebAPI.php(124): SpotifyWebAPI\Request->api('GET', '/v1/playlists/5...', Array, Array)
#3 /<redacted>/vendor/jwilsson/spotify-web-api-php/src/SpotifyWebAPI.php(1275): SpotifyWebAPI\SpotifyWebAPI->sendReque in /<redacted>/vendor/jwilsson/spotify-web-api-php/src/Request.php on line 47

I figured out the error, it seems that accessTokens have a higher character count since a few days (I count 287). My database field to store the token was set to a maximum of 255 characters.
My old implementation would request a new one and continue. Your implementation probably handles this in a different way (although I would expect also that it would continue with the call when the new access token is received).


#164 Use correct "Generated"-annotation based on JDK version.

Fixes usage of auto-value-gson with JDK 9 and newer.
This bumps the dependency of auto-common to 0.9, because this version includes the necessary utility method.

Hi,
Any idea when it gets released?
Thanks
Jacek

When it's ready

I second that request. The fix is urgent for anyone using Java 9 and above. Never has there been such a long gap between releases.

Urgent needs can always build from source if they need to. Let’s avoid the dramatics in the issue tracker

Likewise, simple answer hinting when it can be expected or what is blocking it would do but you decided differently so you got dramatics :)

I'm going to lock conversation on this merged pull request since none of this is helpful.
I understand the frustration in having to wait for changes to be released, however there is someone waiting for every change and we decide when to cut releases based on work planned.
We have some more bugs and issues to fix up before this is released, as we'd like to do a single release that includes fixes for many of the issues that have grown here, but we won't provide a timeline because this is something we're doing in free time and, especially this time of year, we literally don't know how long things are going to take as we also have families and other obligations to attend.
As @hzsweers mentioned, you're welcome to build from source if your needs are urgent, otherwise we're going to finish up the issues we can and then will cut a release.


100 years twitter — review and manage command

This is still a WIP but I finally came up with an approach for finding the events and displaying them on the review page that I'm happy with, and a solution that I think will work for scheduling and tweeting. I haven't written any unit tests and still have a few more refinements to do, but thought maybe you could review at your convenience to see if you have any concerns so I can make myself a checklist and merge when I finish adding tests etc.

Codecov Report

Merging #672 into develop will decrease coverage by 0.95%.
The diff coverage is 32.31%.

@@             Coverage Diff             @@
##           develop     #672      +/-   ##
===========================================
- Coverage    98.05%   97.09%   -0.96%
===========================================
  Files          218      221       +3
  Lines        11650    12112     +462
  Branches        66       66
===========================================
+ Hits         11423    11760     +337
- Misses         227      352     +125

Cleaned up the todos and fixmes, added unit tests for everything and corrected or refined a few more things along the way.


How-to: Test your authorization server

Ref: https://github.com/spring-projects/spring-authorization-server/issues/499

Hi @colin-riddell, thanks for the suggestion! Just for clarity for others, could you update the issue and say just a bit more about your suggestion? For example, you may be suggesting a guide for:

Integration testing the authorization server locally using e.g. JUnit
Building a test suite for end-to-end OAuth flows using an automated testing tool e.g. Selenium/SoapUI/Postman/etc.
Other?

Related gh-258

@colin-riddell

Integration testing the authorization server locally using e.g. JUnit. It is possible to write a test with mockMvc calls

Please see the JUnit integration tests that make use of MockMvc.
We're also considering adding integration test support via gh-258.
I'm going to close this as a duplicate of gh-258.


"Install the DS4 Driver" Error

DS4Windows ->Settings -> Controller/Driver Setup -> Install the DS4 Driver
"Unhandled exception has occurred in your application. If I click Continue, the application will ignore this error and attempt to continue. If you click Quit, the application will close immediately
Could not find file "C:....\ScpDriver.log"
I clicked Continue and it just showed me the same thing again.
Details :

See` the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
************** Exception Text **************
System.IO.FileNotFoundException: Could not find file 'C:\Users\Isay Bart\Documents\ScpDriver.log'.
File name: 'C:\Users\Isay Bart\Documents\ScpDriver.log'
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.StreamReader..ctor(String path, Encoding encoding, Boolean detectEncodingFromByteOrderMarks, Int32 bufferSize, Boolean checkHost)
at System.IO.File.InternalReadAllText(String path, Encoding encoding, Boolean checkHost)
at DS4Windows.WelcomeDialog.timer_Tick(Object sender, EventArgs e)
at System.Windows.Forms.Timer.OnTick(EventArgs e)
at System.Windows.Forms.Timer.TimerNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************
mscorlib
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.7.2110.0 built by: NET47REL1LAST
CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
DS4Windows
Assembly Version: <IP_ADDRESS>
Win32 Version: 1.4.222
CodeBase: file:///C:/Users/Isay%20Bart/Documents/DS4Windows.exe
System
Assembly Version: <IP_ADDRESS>
Win32 Version: 4.7.2110.0 built by: NET47REL1LAST
CodeBase: file:///C:/windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.dll
System.Windows.Forms
Assembly Version: <IP_ADDRESS>

Any fix for this?
I already have my DS4 connected via USB and the light on the controller is off.
Thanks in advance!

I believe that since the website isn’t working, the download from within the Ds4 won’t work. I say just check now and then if the website is up.

got the same problem and I donut now what to do


Reuse agreements on consume flow

Detect if agreement already exists and reuse it.
If agreement exists only one Metamask signature is required.
Requires: https://github.com/oceanprotocol/squid-js/pull/243

https://github.com/oceanprotocol/commons/issues/141


[Roadmap] support for tortoise-tts

Why
As tortoise-tts can run locally offline, its better to support for privacy reasons.
Description
TTS should work using API of https://github.com/neonbjb/tortoise-tts

We don't support TTS python libraries, all of the Big-AGI modules are Services (e.g. need an HTTP address/port).
Can re-open when this becomes a service.


Route handled with get* instead of post*

My route
Route::controller('my/route/{args?}', 'My\Controller');

My controller
class Controller extends Controller {
    function getIndex($args = null) {
      return "get";
    }

    function postIndex($args = null) {
      return "post";
    }
}

GET "my/route" returns "get"
GET "my/route/1" returns "get"
POST "my/route/1" returns "post"
POST "my/route" returns "get"
As you see there's a weird behaviour when there are no arguments to the post route. Is this by design?

Looks like a bug to me.

Why do you have that optional args their? The controller method takes care of the optional parameter binding.
Just use this:
Route::controller('my/route', 'My\Controller');

I think that the Controller should handle these arguments without messing with them, and route any request to its proper http verb. The optional argument declaration in the route is expected to be there by design from my understanding.
Furthermore, when trying your suggestion
Route::controller('my/route', 'My\Controller');

i get the Controller method not found exception on route GET my/route/1, because it's trying to access the get1 method.

class Controller extends Controller
did you purposely use this controller name for the issue?

did you purposely use this controller name for the issue?

That looks like an oversight in the simplified example, that's all.

I've ran some blackbox test, here's the result.
Each test contains the route declaration, the Controller methods and 4 results.
// No args
Route::controller('test', 'My\Controller');
function getIndex() { return "index"; }
function getLocation() { return "location"; }
Results:
get 'test'			ok
get 'test/1'		ok (not found)
get 'test/location'		ok
get 'test/location/1'	ok
----------------------

// Mandatory arg
Route::controller('test/{args}', 'My\Controller');
function getIndex($arg) { return "index"; }
function getLocation($arg) { return "location"; }
Results:
get 'test'				ok (not found)
get 'test/1'			ok
get 'test/location'		ok (not found)
get 'test/location/1'	ERR (NotFoundHttpException)
----------------------

// Mandatory arg - no args on controller methods
Route::controller('test/{args}', 'My\Controller');
function getIndex() { return "index"; }
function getLocation() { return "location"; }
Results:
get 'test'				ok  (not found)
get 'test/1'			?   (returns "index" even though $arg is not declared)
get 'test/location'		ERR (returns "index")
get 'test/location/1'	ERR (NotFoundHttpException)
----------------------

// Optional args
Route::controller('test/{args?}', 'My\Controller');
function getIndex($arg = null) { return "index"; }
function getLocation($arg = null) { return "location"; }
Results:
get 'test'				ok
get 'test/1'			ok
get 'test/location'		ERR (returns "index")
get 'test/location/1'	ERR (NotFoundHttpException)
----------------------

// Optional args - no args on controller methods
Route::controller('test/{args?}', 'My\Controller');
function getIndex() { return "index"; }
function getLocation() { return "location"; }
Results:
get 'test'				ok
get 'test/1'			ok
get 'test/location'		ERR (returns "index")
get 'test/location/1'	ERR (NotFoundHttpException)

I can see that mostly the 'location' errors are triggered because 'location' is interpreted as an argument. However, i'm pretty sure that this behaviour was different in 4.x branch.

Look at this trivial example:
Route::get('a/{args}', function($args){return "get";});
Route::post('a', function(){return "post";});

GET a/1 returns "get"
POST a returns "post"
GET a returns MethodNotAllowedHttpException

The latter suggest that the resolver didn't found a matching route for GET a, so it fell back to the only matching pattern - that is configured to only allow the POST method.
I fear i'm losing something important, because this seems to be way too much of a routing issue.

There is no bug in your last code snippet.
The route /a is only responding to POST requests, hence the MethodNotAllowed.
If you set the parameter to optional for the GET route, you won't have any error.

You are right, but i didn't say that's a bug.
My point is that for some reason, while in a GET request context, the resolver parsed a POST route. It's just an heads up since the original issue i submitted was exactly related to this behaviour, but may turn out that is not related.

Closing due to human timeout (2 weeks or more with no response).


Gfclient metin2 account creator

can you help me for gameforge account creator(metin2)

Discord; cips0x666

Hi, i don't know how the login works for metin2 but i guess that the blackbox creation is the same for all gameforge games so you can look at the source to generate it. Other than that I don't know how the login works for that game sorry.


Minor spelling correction in README.md

Corrected a small spelling mistake in README.

Hey,
I noticed a small spelling mistake in the README.md file when looking at into your project. I took the liberty of correcting it in a fork and have created a pull request if you're interested in keeping the change.
I thought that might be easier than commenting on the file itself.

Nice catches, thanks!


Make an '.add' command dynamically to a defined mapTo from a service or controller

I need to make something like that:

Define an event map;
$commangularProvider.mapTo('Event').asSequencial()

Add commands dynamically from an another service or controller;
$commangular.map('Event').add('Command')

Can i do something like that with commangular framework, or just work if i define commands in config step?

Commangular build the command execution tree on a angular run block, so at the moment you can't add new commands after the angular configuration stage.
You can do dinamic angular module loading and load new commands in another config block, but never outside.


Keeps releases lean

Keep unnecessary files out of releases/dists.

Cool! Thanks for adding! Learned something new again 😄


Get coordinates of person from feed

Using cv2 image detection, get the coordinates of the detected person to use in the controller.

Added code to LiveFeed_opencv.py to print position of person


Add support for running HMAC operations

This PR adds the HMAC driver and a HMAC example.

The build is red due to unformatted code. Please format your code.

Pushed an update that addresses the comments and fixes the format failures.

Ping

bors d+

bors r+


fix installation links in table of contents

i suggest removing the table of contents entirely, since it's so easy to accidentally break and github now has them built in anyway:

Thanks, but we are migrating to .rst for the readme so this PR is kinda redundant...


DynamicClassCreator: Use self.res

DynamicClassCreator: use self.res to match https://github.com/RedHatQE/openshift-python-wrapper/pull/945

Depends on https://github.com/RedHatQE/openshift-python-wrapper/pull/945

!verified

!cherry-pick v4.12

!cherry-pick v4.12

!cherry-pick v4.12

!cherry-pick v4.12


Added kubeburner adapted files

Included kubeburner files to facilitate perf/scale testing on kubemarks workload cluster.

Sure!
https://kube-burner.readthedocs.io/


tn.connect should check if tensor-legs are compatible for symmetric backend

For block-sparse tensors, an identical dense shape of two legs is not sufficient for their contraction. Flows and charges have to match as well. tn.connect is currently not checking this. An error is eventually raised upon contraction, but we could detect it earlier already when connecting two legs

Yeah, we could add a is_connectable method to the backends. So BaseBackend would always return True/check the dimensions, and then your could do specific checks for the symmetric backend.


rest-auth/login returns {"detail":"CSRF Failed: CSRF cookie not set."}

Hi,
I have been trying to integrate React.js application to a Django server that has django-rest-auth installed.  The details of my question are here: https://stackoverflow.com/questions/59095076/dango-react-axios-and-csrf-failed-csrf-token-missing-or-incorrect
Thank you

oops it was something I was doing wrong

Can you mention what you were doing wrong? I am currently facing the same issue.

@redcricket I would also know, what are you doing wrong.

@redcricket @AnupamBrt @mitorski ever figured it out?


Renaming files not working on some files

Issue Type: Bug
Tagging @IsidorN as requested.
I'm trying to rename some Markdown files that I have in a folder and about 1/3 of  the files can be renamed, while for the rest, when I try to rename them, nothing happens. It works fine in the stable version, but not on the insiders version. Here is a link to the repository where my blog is hosted: https://github.com/ertay/ertay.github.io
Steps to Reproduce:

Download the repository linked above.
Open the folder in VS Code
Expand the _posts folder in the Files Explorer.
Try to rename the files in the bottom (so the latest files).

Does this issue occur when all extensions are disabled?: Yes
VS Code version: Code - Insiders 1.45.0-insider (a3083e58e2a9e77f60e531acaa32e18527ae8439, 2020-04-17T08:09:47.238Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz (4 x 3504)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.90GB (9.35GB free)

Process Argv

Screen Reader
yes

VM
0%

Extensions: none

@ertay thanks for precise steps however this works for me.
I followed your exact steps and I could rename from the explorer both by using the keyboard and the context menu.
Here's a gif showing what I am doing. If you are doing something different to what I described or what I have shown in the gif let me know.
Also if you F1 > developer tools > do you see some errors in the console
Can you rename those files using the native file explorer

@Isidorn I'm sorry I'm not able to see the GIF as I am blind. For me both the F2 shortcut, and the Rename function from the context menu don't work. If I start from the top of the file list in the _posts folder, it works until I reach the file named "2019-4-4-episode-9-sighted-assistance-for-blind-board-gamers-with-dale-and-laura-rowe". After that file, I cannot rename any of the files inside that folder, others work fine.
Also, I toggled the Developer Tools, which seemed to open a DOM browser, going through that with my screen reader I didn't see any errors.
Renaming the files outside of VS Code-Insiders works fine, even with VS Code Insiders open, iif I use Windows Explorer to rename an opened file, it updates in VS Code just fine. It is very weird because I don't have this problem in the stable build of VS Code, all files can be renamed there.  Sorry about that.

Do you use some screen reader when attached to VS Code?
When you press F2 do you not get the inputbox, or you get it but typing anyhting has no effect
You see the same behavior even if you reload vscode?
Does deleting those files for example work? Only rename is the problem?

I just tried reproducing also on my Windows machine and I could not reproduce. And due to I have to ask you all these questions..

Let's close as duplicate of https://github.com/microsoft/vscode/issues/95315
Since that is the oldest issue. It seems like I broke something in vscode insiders.


Fix KeyError for rule_hit_details

I noticed one thing after merging these changes.
Here you handled keyError inside /systems but no conditional handling in /system/<host_id> API.
In case of systems without rule hits, while calculating values for columns - state & recommendation count, API request results into exception.


annotate MonarchAPI endpoints for "diseases/phenotypes associated with orthologs of a gene"

We previously explored in https://github.com/biothings/BioThings_Explorer_TRAPI/issues/237 the possibility of incorporating model organism data into TRAPI queries by adding one explicit edge from a human gene to an ortholog, and another explicit edge from that ortholog to other entities (like related diseases and/or phenotypes). That route proved cumbersome, because people generally did not know that they could/should explicitly add those edges to their query.
We could revisit that strategy by adding new templates to our creative mode implementation.  Alternatively, we could utilize the Monarch API endpoint that goes directly from a gene to the diseases and phenotypes related to orthologs of that gene.
https://api.monarchinitiative.org/api/bioentity/gene/NCBIGene%3A695/ortholog/phenotypes?rows=100&facet=false&unselect_evidence=false&exclude_automatic_assertions=false&fetch_objects=false&use_compact_associations=false&direct=false&direct_taxon=false
https://api.monarchinitiative.org/api/bioentity/gene/NCBIGene%3A695/ortholog/diseases?rows=100&facet=false&unselect_evidence=false&exclude_automatic_assertions=false&fetch_objects=false&use_compact_associations=false&direct=false&direct_taxon=false
NOTE: the "diseases" endpoint appears to not be returning results for any gene at the moment.
Annotating these Monarch API endpoints would give BTE direct edges between human genes and phenotypes/diseases which will simplify the incorporation of model organism data into BTE.  (Care must be taken in the modeling of the predicate and evidence.)

Note that Kevin Schaper added some additional info in this thread https://ncatstranslator.slack.com/archives/C014B3JAX36/p1678312101989449?thread_ts=1678308576.260219&cid=C014B3JAX36.  Based on that, I don't think we can easily incorporate the reverse direction in the near term.  So unless this issue is being held open for a different reason, I think we should close it as "complete enough for now".


Run by line does not scroll the notebook

Have a cell with enough code to have it go past the end of the window
Run by line through it.
It should be scrolling to the appropriate line.

This works in the current run by line


added missing side when drawing shapes

The missing point necessary for completing the shapes was added

Kindly if there is no issue can you merge it so I can update the package? I have a lot pending on this package to work perfectly.

thanks for pointing it out, sry for late response got affected by semeru eruption


Which attributes to use for the model

Hello Jeevesh,
I would like to ask which attributes from the NSRDB are best suited to be used as inputs for the models.
Thank you so much for your attention, my best regards.

You can use as many features as you want, Camilo. I would say the more the better. Since I am no meteorologist, I would defer from telling you which feature is important and which is not. And will only tell you statistical methods to find it out for yourself.
If you want to reduce training time or model size, you can plot the correlation heat map by first loading the data into a dataframe and then running :
import seaborn as sns
corr = df.corr()
sns.heatmap(corr,
            xticklabels=corr.columns,
            yticklabels=corr.columns)

[For more on plotting heatmaps : https://stackoverflow.com/questions/39409866/correlation-heatmap ]
Then eliminate features having very low correlation with the feature(GHI) being predicted. But this is only a heuristic way. And we need to be careful as features having zero correlation doesn't necessarily mean that there is no dependence. So do this, only if you want to reduce size desperately.
Another way could be to first train the model on all features , then replace(in the test set) any feature you wish to remove with its mean value(calculated over train set) and check how much accuracy drops compared to the accuracy on the original dataset. If it doesn't drop by much, you can eliminate that feature, and trian on the reduced feature set.
Also, you can check gradients, if the gradient to a feature is near to zero,almost always, then surely that feature is not influencing the loss much, so you can drop it.
I am glad that you found the repository useful. And wish you all the best for your future endeavours !
Yours sincerely


CommonMark 0.29 support

Just opening a tracking issue for latest CommonMark 0.29 released recently.
https://spec.commonmark.org/changelog.txt
Contains several breaking changes from the looks of it (mainly around whitespaces).

Thanks! Will update next week.


Try to move SimResult object into the base api.

This avoids example-specific imports such as:
from deepdrivewe.examples.amber_ntl9.simulate import SimResult

#15 Handled in.


[Microsoft.App] optimize java agent related properties

change leveltype from string to enum
rename logLevelSettings to loggerSettings

For 2:
Below is a configuration file for logback logging framework:
<?xml version="1.0" encoding="UTF-8"?>

<configuration>

  <jmxConfigurator />

  <appender name="consoleAppender"
            class="ch.qos.logback.core.ConsoleAppender">
    <encoder>
      <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36}:%L- !!! %msg%n</pattern>
      <charset class="java.nio.charset.Charset">UTF-8</charset>
    </encoder>
  </appender>

  <logger name="chapters.configuration" level="DEBUG" additivity="false">
    <appender-ref ref="STDOUT" />
  </logger>

  <root level="info">
    <appender-ref ref="consoleAppender" />
  </root>

</configuration>

To describe the configurations, the payload could looks like:
{
    "enabled": true,
    "loggerSettings": [
        {
           "logger": "chapters.configuration",
           "level": "debug",
           "additivity":  false,
        }
    ],
    "appenderSettings": [
         // appender list
     ],
     "globalSettings": {
         // jmx
     }
}

Currently, we only support level settings for loggers.

Detected Breaking change(9) already reviewed in previous PR https://github.com/Azure/azure-rest-api-specs/pull/28405

/azp run

/azp run

/azp run

@ms-zhenhua would you take another look? This PR contains some updates based on https://github.com/Azure/azure-rest-api-specs/pull/28192. BTW, although some breaking change detected, this 2024-02-02-preview API version for Microsoft.App hasn't been released yet.


Missing file isn't handled

If I supply a file that doesn't exist, bam just sits. Console logs show the file doesn't exist, but the user has no idea.

See #91


Internal error: Undefined class constant

The error message is like this: Uncaught Error: Undefined class constant 'MYSQL_ATTR_INIT_COMMAND' in /[...]/Db.php:23. The code that causes this, is just an array defining driver options for Doctrine.
$opts = [
    "driverOptions" => [PDO::MYSQL_ATTR_INIT_COMMAND => ...]
];

Try disabling the opcache in your php.ini.
If it doesn't help, please create a small reproducing repository that shows the problem, thanks.

One more idea I have - try enabling the pdo_mysql extension in your php.ini.

Well, pdo_mysql wasn't event installed (the app itself runs inside docker, but I have phpstan and some other util on local machine). Thanks for the help!

Soon-to-be-released PHPStan 1.3.0 addresses this, you can now use OPCache again with it! Feel free to test phpstan/phpstan dev-master to verify :)


Shutdown after installing a page of images

Idk how to close this but I figured out my issue, sorry for wasting your time seeing this.

No worries, I guess you had "after the download: shutdown" option selected 😅


fix golang version

ref:
https://github.com/kubernetes/kubernetes/blob/07240b7166d83bed49d783e0ecdfa7ee7e62cfca/hack/lib/golang.sh#L329

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

/cc @cblecker

thanks @cblecker  - that was perfect for an lgtm!
/approve
/lgtm

/approve


Change path for images

Built here: https://ivadomed.org/en/af-transfer_doc_images/

Pull Request Test Coverage Report for Build 358043131

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.969%

Totals

Change from base Build 356966781:
0.0%

Covered Lines:
5782

Relevant Lines:
6356

💛  - Coveralls

@jcohenadad  I removed most of the images. We still have 2 csv files under /images: detailed_results.csv and df_compare.csv.
Should I move them to https://github.com/ivadomed/doc-figures ?

@jcohenadad I removed most of the images. We still have 2 csv files under /images: detailed_results.csv and df_compare.csv.
Should I move them to https://github.com/ivadomed/doc-figures ?

no-- these are small and non-binary (ie ASCII)

@lrouhier Could you please review the PR in case I missed any sections?

I tried to change the path in the conf.py for the new repo, but it didn't render correctly (https://github.com/ivadomed/ivadomed/pull/521/commits/335dc46ebbe87ec9ab764d8708e564b93e52fd45)

paper.md still compiles well, thanks @alexfoias !!


[enhancement]: ControlNet processors w/ Resolution settings should set to model optimized resolution

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
When users select a processor that has a input/output resolution, the resolution's should auto update to that of the model architecture. Else, you get SDXL processed images that look wonk
Alternatives
Warn users to manually update these
Additional Content
No response

Detect resolution, image resolution or both?


If stoped - wait all events to be handled

I made a webcrawler experiment here: https://github.com/Konard/LinksPlatform/tree/webcrawlerserver
And found a problem, if we ask to stop an abot (PoliteWebCrawler) it just stops all its threads, or waits for its threads, but it does not wait for events to be finished (for example crawler_ProcessPageCrawlCompleted).
Because of this it is required to keep a track of each thread that is involved in events handling like this:
        private void crawler_ProcessPageCrawlCompleted(object sender, PageCrawlCompletedArgs e)
        {
            if (!Program.Threads.Contains(Thread.CurrentThread))
                Program.Threads.Add(Thread.CurrentThread);
...

And after this wait them all (Join), to correctly release resources, close connection to database, close the application itself & etc.
Is there is a better way to this? Or is it possible to integrate that feature into abot?

Can you give a more complete example of how/when you are trying to stop the crawl?

https://github.com/Konard/LinksPlatform/blob/c7b3c9ac12a2c2416ab8db100e670af8e1749b3c/Platform/Platform.Data.CrawlerServer/Crawler.cs

Does it work if you change...
crawler.PageCrawlCompletedAsync += crawler_ProcessPageCrawlCompleted;
to...
crawler.PageCrawlCompleted += crawler_ProcessPageCrawlCompleted;

WOW, I didnt notice this. Ill check it.

Did that help you?

Looks like a better solution (if I decide not to use async events). Sync events are working ok (no need to track threads anymore). But if async events are required (for example to maximize CPU utilization) this issue still not solved.

I agree that it is an issue that needs to be fixed. Just wanted to be sure
it is what it appears to be.
Thanks
On Tue, Jan 5, 2016 at 12:14 AM, Konstantin Dyachenko <
<EMAIL_ADDRESS>wrote:

Looks like a better solution (if I decide not to use async events). Sync
events are working ok (no need to track threads anymore). But if async
events are required (for example to maximize CPU utilization) this issue
still not solved.
—
Reply to this email directly or view it on GitHub
https://github.com/sjdirect/abot/issues/109#issuecomment-168921200.

Async events have been removed with the release of abot 2.0.


kubectl wait with jsonpath fails when field is not found

What happened?
Waiting for a field to be set on a resource using  --for=jsonpath= fails when the field is not found.
kubectl wait brokers -n knative-eventing  --timeout 300s --for=jsonpath='{.status.state}'=https://example.com
error: state is not found

What did you expect to happen?
The jsonpath syntax behaves differently when compared to --for=condition= since this:
kubectl wait deployment <deployment_name> --timeout 300s --for=condition=Nope=True

waits even when there is no condition called Nope.
In addition, waiting on status fields that are set asynchronously is really useful, so the usual flow of creating and waiting for a resource to have a specific field isn't reliably solvable with this error thrown.
How can we reproduce it (as minimally and precisely as possible)?
Run:
$ kubectl create deployment nginx --image=nginx; kubectl wait --for=jsonpath='{.status.readyReplicas}'=1 deploy/nginx
deployment.apps/nginx created
error: readyReplicas is not found

Anything else we need to know?
I see a test with this behavior [1], however, I think it's not consistent with the existing wait behavior.
[1] https://github.com/kubernetes/kubernetes/blob/10dcc6c5f44a0607881cd2f3bd5c4d80f61ad120/staging/src/k8s.io/kubectl/pkg/cmd/wait/wait_test.go#L1167-L1176
Kubernetes version

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.5", GitCommit:"c285e781331a3785a7f436042c65c5641ce8a9e9", GitTreeState:"clean", BuildDate:"2022-03-16T15:58:47Z", GoVersion:"go1.17.8", Compiler:"gc", Platform:"linux/amd64"}

Server Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-26T08:02:07Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}

Cloud provider

N/A

OS version

NAME="Fedora Linux"
VERSION="35 (Workstation Edition)"
ID=fedora
VERSION_ID=35
VERSION_CODENAME=""
PLATFORM_ID="platform:f35"
PRETTY_NAME="Fedora Linux 35 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:35"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f35/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=35
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=35
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Install tools

N/A

Container runtime (CRI) and version (if applicable)

N/A

Related plugins (CNI, CSI, ...) and versions (if applicable)

N/A

/triage accepted

This might be a duplicate of #1204