[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get

What changes were proposed in this pull request?
Introduced a new parameter emptyCollection for CreateMap and CreateArray functiion to remove dependency on SQLConf.get.

Why are the changes needed?
This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.

Does this PR introduce any user-facing change?
No

How was this patch tested?
Existing UTs.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @MaxGekk

ok to test

Test build #118755 has started for PR 27657 at commit 37b26ac.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23506/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23512/
Test PASSed.

Test build #118761 has started for PR 27657 at commit 7bbf40e.

Test build #118761 has finished for PR 27657 at commit 7bbf40e.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CreateArray(children: Seq[Expression], useStringTypeWhenEmpty: Boolean)
case class CreateMap(children: Seq[Expression], useStringTypeWhenEmpty: Boolean)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118761/
Test FAILed.

Test build #118755 has finished for PR 27657 at commit 37b26ac.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CreateArray(children: Seq[Expression], emptyCollection: Boolean) extends Expression
case class CreateMap(children: Seq[Expression], emptyCollection: Boolean) extends Expression

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118755/
Test FAILed.

Test build #118770 has started for PR 27657 at commit 689722a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23522/
Test PASSed.

Can you add some end-to-end tests to check that no change happens in output data types even when the conf updated?

Test build #118770 has finished for PR 27657 at commit 689722a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118770/
Test FAILed.

retest this please

Test build #118807 has started for PR 27657 at commit 689722a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23557/
Test PASSed.

Test build #118807 has finished for PR 27657 at commit 689722a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118807/
Test FAILed.

retest this please

Test build #118857 has started for PR 27657 at commit 689722a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23606/
Test PASSed.

Test build #118857 has finished for PR 27657 at commit 689722a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118857/
Test FAILed.

Test build #118899 has started for PR 27657 at commit e255906.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23648/
Test PASSed.

Test build #118899 has finished for PR 27657 at commit e255906.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118899/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23661/
Test PASSed.

Test build #118912 has started for PR 27657 at commit e255906.

Test build #118912 has finished for PR 27657 at commit e255906.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118912/
Test FAILed.

retest this please

Test build #118921 has started for PR 27657 at commit e255906.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23669/
Test PASSed.

retest this please

ok to test

Test build #119221 has started for PR 27657 at commit e255906.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23960/
Test PASSed.

Test build #119221 has finished for PR 27657 at commit e255906.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119221/
Test FAILed.

retest this please

Test build #119437 has started for PR 27657 at commit e255906.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24174/
Test PASSed.

Test build #119437 has finished for PR 27657 at commit e255906.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119437/
Test PASSed.

thanks, merging to master/3.0!

Thanks everyone for reviews.


example with XML and JSON

Do you have an example of Produce with XML and JSON?
Say you have a struct like this
type Data struct {
 Version string `xml:"version,attr" json:"version"`
}

d:=Data{Version:"v1"}

//Would like to render d so it will output JSON or XML dependending on the request header.

https://github.com/swaggo/swag/tree/master/example/celler


only translate what is on-screen

https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver


[REQ] Allow to supress comments where there's nothing to report

Is your request related to a workflow problem?
Could you provide a configuration option to have the action not comment if it has no fixes or new issues to report?
Propose a solution
The action shouldn't comment if there's no value in the comment.
Additional comments
N/A

Seems your issues workflow is broken:
https://github.com/Checkmarx/ast-github-action/actions/runs/12318196781

Jira integration failure.


The quick start not friendly enough

Which is server ? Which is client?The quick start do not tell us!

your quick start is a disaster, especially those who are not familiar with java.


MUIC-573: [Android] - User unable to send message after answer Response Card

Moved to onMessageSent

jira link missing?


Multiple network types in Flow.json

Overview
In FCL applications, developers can choose their desired transport to use when communicating with an Access API. The available transports in FCL are GRPC via HTTP, and REST via HTTP.
In order for FCL applications to configure themselves resiliently using the network configuration information made available in Flow.JSON, it would need to read the specific network information for both the network it is configured with (eg: "testnet", "mainnet" etc) and also the transport that it is configured to use (eg: "grpc", "http").
Suggestion
If we allow for multiple Access Node API URLs to be specified in Flow.json, nested by both the network and transport they represent, FCL could use this information to resiliently configure itself.
Example Format
...
"networks": {
  "emulator": {
    "grpc": "<IP_ADDRESS>:3569", // <-- Used by FLOW CLI
    "grpc-http": "<IP_ADDRESS>:8080", // <-- Used by FCL (grpc transport)
    "rest-http": "<IP_ADDRESS>:8888", // <-- Used by FCL (http/rest transport)
  },
  "mainnet": {
    "grpc": "access.mainnet.nodes.onflow.org:9000",
    "grpc-http": "access-mainnet.onflow.org",
    "rest-http": "rest-mainnet.onflow.org",
  },
  "testnet": {
    "grpc": "access.mainnet.nodes.onflow.org:9000",
    "grpc-http": "access-testnet.onflow.org",
    "rest-http": "rest-testnet.onflow.org",
  }
}
...

doesn't this conflict with https://github.com/onflow/fcl-js/issues/1479 ?

@bluesign It should work alongside the deprecation of GRPC supported outlined in https://github.com/onflow/fcl-js/issues/1479 ! - Flow.json still may want to outline grpc network addresses to be used in other tools, while FCL will still want to consume the rest/http network address

Not sure this is a big enough unlock now that REST and gRPC-Web are available using the short network domain. Going to close.


Study page is not loading

When click on the study tab there is an error that occrs

improper link was provided on the main page. proper destination assigm=ned


Cannot move arbitrary objects

We need a simple move() function to move our objects around in 3D space, such as lines, arcs, entire sketches and finally 3D objects.

This dovetails nicely into the discussion about assemblies, because this and #2673 are pre-requisites to an assembly system and I think it would be prudent to keep assemblies in mind when designing this feature.

Is there an existing engine command that does this?

I think we discussed that patternTransform is the one command that can but otherwise no.

As of July 29 (Slack thread), there has been some work in the engine on this, but it wasn't finished yet.

https://github.com/KittyCAD/modeling-api/pull/441

@jtran does that complete this issue so it can be closed? Or is there outstanding work?

This is my next job once offsets are in. The linked API work was a sketch of how it would work and was left up for review. I will revisit this.
Also https://github.com/KittyCAD/modeling-app/issues/4373


feat: add credential retry logic to sql lambda

Description of changes

Add credential refresh and retry logic to SQL lambda.
This is merging into a feature branch.
CDK / CloudFormation Parameters Changed

N/A
Issue #, if available

N/A
Description of how you validated changes
Manual testing. E2E tests will come in subsequent PR.
Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The handler has the engine stored as an environment variable. So we could add that to the expression.


Add breadcrumbs to travel advice details

https://trello.com/c/tomHUlp7/475-define-data-format-for-breadcrumbs
Proposed schema change to allow hardwired breadcrumbs through the publishing pipeline for travel advice. The structure resembles the section tag 'parent' hierarchy currently used on GOV.UK.
For now I've added the breadcrumbs structure to the travel advice details hash as it's not common across other formats and is a temporary measure until we have an idea of how dependency resolution informs breadcrumbs and related links.

:+1:

Closing for now as this requires further changes.


Fix Firebase set up - use native SDK

Actually turns out native SDK is bugged for auth and we can't use it LOL


removing ntdll requirement from function features exported by both ntdll and ntoskrnl

removing the ntdll requirement from function features that are exported by both ntdll and ntoskrnl will improve hits for kernel drivers e.g. #240.

Great! I think documenting this would be a very good idea. Either at https://github.com/fireeye/capa-rules/blob/master/doc/format.md#api or even better as a linter suggestion?

Great! I think documenting this would be a very good idea. Either at https://github.com/fireeye/capa-rules/blob/master/doc/format.md#api or even better as a linter suggestion?

From my analysis of ntdll.dll and ntoskrnl.exe found on Windows 7 there is overlap of ~625 exported symbols. I think it would be really neat to include this as a linter suggestion; less the user needs to worry about when building out their rules.
I'll merge this PR and create a new issue to discuss further how to best handle export overlap in ntdll.dll and ntoskrnl.exe.


Full screen mode in browser (Youtube) shows focused border colours

Hi
Whenever I full screen my youtube video, there is a blue border around it. Is there an option to remove it on full screen or is this a bug?
Image here: https://i.imgur.com/9pkXaHB.jpg
Do you need any other information?
Mac OS High Sierra 10.13.1
On a single screen on my laptop.
Any help would be appreciated. Thanks.

I was able to fullscreen a youtube video and not see the default border. I did this by changing a playing video to fullscreen, clicking pause, and clicking play, keeping my mouse away from the sides.
New to chunkwm, but I thought this had to do with focus of the window.

Hmm interesting, but I won't be able to test it out since I only have one screen.

I believe full-screen YouTube acts as a "floating" window. I had the same issue until I added the following to my .chunkwmrc:
chunkc set focused_border_skip_floating  1

After that, the border no longer appeared on full screen YouTube.

Hi mmanguno, that solved my problem. Thank you very much man.

That fix didn't work for me, for YouTube or any other embedded video that I put in fullscreen. OS X Mojave and Firefox Developer Edition.
Here's my full .chunkwmrc:
#!/bin/bash

#
# NOTE: specify the absolutepath of the file to use for logging.
#       'stdout' and 'stderr' are valid values.
#

chunkc core::log_file ~/.chunkwm_log

#
# NOTE: specify the desired level of logging.
#
#       - none, debug, warn, error
#

chunkc core::log_level error

#
# NOTE: specify the absolutepath to the directory to use when
#       loading a plugin. '~' expansion is supported.
#

chunkc core::plugin_dir /usr/local/opt/chunkwm/share/chunkwm/plugins

#
# NOTE: if enabled, chunkwm will monitor the specified plugin_dir
#       and automatically reload any '.so' file that is changed.
#

chunkc core::hotload 0

#
# NOTE: the following are config variables for the chunkwm-tiling plugin.
#

chunkc set global_desktop_mode           bsp
# chunkc set 2_desktop_mode                monocle
chunkc set 3_desktop_mode                float

chunkc set global_desktop_offset_top     20
chunkc set global_desktop_offset_bottom  20
chunkc set global_desktop_offset_left    20
chunkc set global_desktop_offset_right   20
chunkc set global_desktop_offset_gap     15

# chunkc set 3_desktop_offset_top          190
# chunkc set 3_desktop_offset_bottom       190
# chunkc set 3_desktop_offset_left         190
# chunkc set 3_desktop_offset_right        190

chunkc set desktop_padding_step_size     10.0
chunkc set desktop_gap_step_size         5.0

chunkc set bsp_spawn_left                1
chunkc set bsp_optimal_ratio             1.618
chunkc set bsp_split_mode                optimal
chunkc set bsp_split_ratio               0.5

chunkc set monitor_focus_cycle           1
chunkc set window_focus_cycle            monitor

chunkc set mouse_follows_focus           intrinsic
chunkc set window_float_next             0
chunkc set window_region_locked          0

#
# NOTE: shell commands require escaped quotes
#       to pass value containing a whitespace.
#
chunkc set ffm_bypass_modifier           \"cmd shift\"

chunkc set preselect_border_color        0xffd75f5f
chunkc set preselect_border_width        5
chunkc set preselect_border_radius       0

#
# NOTE: these settings require chwm-sa.
#       (https://github.com/koekeishiya/chwm-sa)
#

chunkc set window_float_topmost          0
chunkc set window_fade_inactive          0
chunkc set window_fade_alpha             0.85
chunkc set window_fade_duration          0.25
chunkc set window_use_cgs_move           0

#
# NOTE: the following are config variables for the chunkwm-border plugin.
#

chunkc set focused_border_color          0xff0f6288
chunkc set focused_border_width          5
chunkc set focused_border_radius         0
chunkc set focused_border_skip_floating  1

#
# NOTE: specify plugins to load when chunkwm starts.
#       if chunkc plugin_dir is not set, the absolutepath is necessary.
#

chunkc core::load border.so
chunkc core::load tiling.so
chunkc core::load ffm.so

#
# NOTE: shell commands require escaped quotes
#       to pass value containing a whitespace.
#

chunkc tiling::rule --owner Finder --name Copy --state float
chunkc tiling::rule --owner \"App Store\" --state float
chunkc tiling::rule --owner "Emacs.*" --state tile
chunkc tiling::rule --owner \"Microsoft Outlook\" --name ".*Reminder.*" --state float

Same as @neverfox  here


Why "setEnergyOfReference 159 keV" ?

Hello,
In "GATE_MACROS_Jaszczak"-> "Brightview_Main_LEHR_Oz_Jas.mac", I have a question about “/gate/digitizer/Singles/blurring/linear/setEnergyOfReference 159.0 keV” in Digiter in the tutorial.
Why is it set to 159 keV, instead of 140.5 keV (Tc-99m Mono-Energy)？
Thank you for your help,
Best regards
Connor

Hi Connor,
It is the energy of reference for the energy resolution. You can also set it for Tc (9-10% typically at 140 keV). Gate calculates the energy resolution for the different energy considered in the simulation (eg scatter) in any case.
Ben
Get Outlook for iOShttps://aka.ms/o0ukef

From: Connor_He @.>
Sent: Sunday, April 7, 2024 5:01:04 AM
To: BenAuer2021/Simulation-Of-Nuclear-Medicine-Imaging-Systems-Scintigraphy-SPECT @.>
Cc: Subscribed @.***>
Subject: [BenAuer2021/Simulation-Of-Nuclear-Medicine-Imaging-Systems-Scintigraphy-SPECT] Why "setEnergyOfReference 159 keV" ? (Issue #1)
Hello,
In "GATE_MACROS_Jaszczak"-> "Brightview_Main_LEHR_Oz_Jas.mac", I have a question about “/gate/digitizer/Singles/blurring/linear/setEnergyOfReference 159.0 keV” in Digiter in the tutorial.
Why is it set to 159 keV, instead of 140.5 keV (Tc-99m Mono-Energy)？
Thank you for your help,
Best regards
Connor
—
Reply to this email directly, view it on GitHubhttps://github.com/BenAuer2021/Simulation-Of-Nuclear-Medicine-Imaging-Systems-Scintigraphy-SPECT/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUHBMALNTTAHK5YDROCQYWTY4EDNBAVCNFSM6AAAAABF3E2RQCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDSNRUGIYDKOI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Some questions on Video ReID

First of all, thank you for this amazing work! Well-formed and super easy to use!

what inputs you will provide, if any:
A video ReID dataset, several sequences of video clips. All the identities are annotated with a unique id.

what outputs you are expecting:
Given one person's image that appears in a video, find this person only in this video.

With this kind of video ReID task, I have several problems:

I plan to directly build backbones like resnet and load the weight directly from .pth file. The reason is, this sample code demo/predictor.py contains a lot of dependencies, which makes it harder for me to integrate. In this way, I have to make the image preprocessing identical to training. In preprocessing, fastreid accepts BGR images, and subtract pixel_mean and divide pixel_std.

# Values to be used for image normalization
_C.MODEL.PIXEL_MEAN = [0.485*255, 0.456*255, 0.406*255]
# Values to be used for image normalization
_C.MODEL.PIXEL_STD = [0.229*255, 0.224*255, 0.225*255]

Seems like this pixel_mean and pixel_std is in RGB order?
And in my understanding, the preprocessing only contains subtract pixel_mean and divide pixel_std. Is this correct?

Another question is about the common practice to sample a video ReID dataset. Right now I have a 30 FPS video dataset, do I need to use every person in every sequence to generate the dataset? Or sparse sampling is better? I am afraid this might bring too many easy instances, since person in consecutive frames tends to be very similar.
Will fastreid support Video ReID in the future? The Deep person reid has this feature, but still based on image ReID.

The last question is about PK sampling. My video looks very different to each other and the identities from different sequences might be overlapped. So, I am considering sample negatives identities only from the same video clip rather than sampling from the whole dataset. Do yo have any thoughts on this? Could you give me a pointer to the code I need to change?

Any answer will be appreciated. Thank you!

The best practice for building a model is to export to ONNX or TensorRT, then you can remove all the dependencies. The only thing you need to do is writing the preprocessing.
The preprocessing is just resize, because subtract mean and divide std have been moved into the network as follow

https://github.com/JDAI-CV/fast-reid/blob/9c667d1a0fbd8a6b5a82ad4d04d51b47d6b2957a/fastreid/modeling/meta_arch/baseline.py#L74
You can check the preprocess here
https://github.com/JDAI-CV/fast-reid/blob/9c667d1a0fbd8a6b5a82ad4d04d51b47d6b2957a/demo/predictor.py#L51
BTW, the image is RGB order.

You can just pick 2 or 3 images from each video clip because they are very similar. We won't consider Video ReID in the future because you can process the video clip offline and then use fastreid for training.

The better way is to do the data clean, for example, merge the same ids in the overlapped video clips.


implement live traces

Implement live traces view

Implements LiveTracesView, which is the first useful example that is designed to be run locally in an electron window. I can't include an example figURL because it's meant to be run locally.
The interesting thing about it is that it uses an in-memory object to retrieve the data chunks for the traces. This allows viewing of SI recording objects without serializing them to disk.


Unsupported uint8_type error with int8 models

The error: miopen make_tensor: MAKE_TENSOR: unsupported type uint8_type
Issue comes from int8 models
Affected ONNX Zoo models are listed here: https://github.com/gyulaz-htec/models/blob/migraphx_testing/MIGRAPHX_fp32-int8.md
Repro step with migraphx:
/code/AMDMIGraphX/build/bin/migraphx-driver run vision/classification/resnet/model/resnet50-v1-12-int8.onnx

The error: miopen make_tensor: MAKE_TENSOR: unsupported type uint8_type in resnet50-v1-12-int8.onnx occurs in miopen_pooling::compute function in src/targets/gpu/pooling.cpp where make_tensor is called, which does not support shape::uint8_type and throws an error (rc/targets/gpu/include/migraphx/gpu/miopen.hpp).

Maybe we could make int8 from uint8 by shifting it? Casting it would truncate half the data.
Ted already did something similar (probably?) with zero points for int8 support in parsing.

The error is resolved when pooling is added to the list of operations that do not support unit8 type.
When verify is attempted error is reported, which can be analyzed in a separate issue.

@nives-vukovic  you'll need to add in a shift similar to what I did for changes to MatMulInteger #2903


About DDP

I have trained my model using DDP, but I am unable to achieve the mentioned mIoU 76.1 on the NuScenes dataset. I am wondering if using DDP has negatively affected the model's performance.
envs:
spconv 2.3.5
torch  1.10.1+cu113

ori0004.log
here is the log file.


Improve S and Shift+S shortcut keys

To simplify keyboard navigation, we want to make the following changes to the S and Shift+S shortcut keys. See this CZO thread for extensive discussion.
Functionality

[ ] Drop the Shift+S shortcut.
[ ] Change the S shortcut to do double-duty:

As a first priority, if the user is not in a conversation view, S should narrow to the conversation view (topic or PM thread) for the selected message. Note that they may end up higher or lower in the thread than the selected message, as they are navigating to (a) the oldest unread message if there are any, or (b) the end of the conversation. This should work from anywhere, including All messages, a stream view, or a near view.
If the user is in a topic view, narrow to stream (i.e., the current functionality). (Nothing should happen if the user is in a PM conversation view.)

Documentation
In the in-app Keyboard shortcuts menu and the help center, we should replace the documentation for Shift+S and S with:

Narrow to topic or PM conversation | S
Narrow to stream from topic view | S

As we would like to get this done quickly, please do not pick up this issue if you are a new contributor.
@N-Shar-ma Would you be up for taking this on?

claim

// Define the new keyboard shortcuts
const SHORTCUT_S = 's'; // Narrow to conversation or stream
const SHORTCUT_SHIFT_S = 'Shift+s'; // Removed
// Add an event listener for key presses
document.addEventListener('keydown', (event) => {
const key = event.key;
if (key === SHORTCUT_S) {
if (notInConversationView()) {
narrowToConversationView();
} else if (inTopicView()) {
narrowToStream();
}
}
});
// Define the functions for narrowing to conversation view and stream
function notInConversationView() {
// Code to check if user is not in a conversation view
}
function narrowToConversationView() {
// Code to narrow to the conversation view for the selected message
}
function inTopicView() {
// Code to check if user is in a topic view
}
function narrowToStream() {
// Code to narrow to the stream
}
so this is the pesudo code for this issue

Awaiting review!


[layer] LSTM weight array size fix

this patch adds LSTM weight array size fix.
Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1846. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.


Mocking uuid

Hi there,
I am trying to mock this import: import { v4 as uuidv4 } from 'uuid'; (package.json dep: "uuid": "9.0.0"), but I am not able to.
I created a uuid.ts files with the following content: export const v4 = () => 'some-uuuid';.
I am using storybook 7.
Thanks!

Hey 👋
This package only allow you to mock local packages(where used relative import ./)
So if you want to mock uuid package, you can create your file uuid.ts, which will include uuidv4 method:
import { v4 } from 'uuid';

export const uuidv4 = v4;

and then you can mock your uuid.ts file by creating __mocks__/uuid.ts:
export const uuidv4 = () => 'some-uuuid';

so your folder structure will be like this:
.
├── index.ts
├── uuid.ts
├── __mocks__
│   ├── uuid.ts

index.ts content is simple export of uuid.ts:
export * from './uuid';

After this, you can just import uuid from your component like this:
import { uuidv4 } from '../path/to/uuid';

Thank you!
Can I override for a single story and/or component?

Unfortunately now, but I have it in plans to add this feature later

+1 for that feature :)


feat: Update to prometheus 2.45.5 in self-monitor

Description
Changes proposed in this pull request (what was done and why):

Updated prometheus to latest patch version. Patch does not contain relevant fixes, however uses a newer golang version

Changes refer to particular issues, PRs or documents:

https://github.com/kyma-project/third-party-images/pull/431

Traceability

[ ] The PR is linked to a GitHub issue.
[ ] New features have a milestone set.
[ ] New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
[ ] The corresponding GitHub issue has a respective area and kind label.
[ ] The follow-up issues (if any) are linked in the Related Issues section.
[ ] Adjusted the documentation if the change is user-facing.
[ ] The feature is unit-tested
[ ] The feature is e2e-tested

/retest


"These countries/regions and clouds aren't supported"

Under the section ”Regional availability" you are stating that "These countries/regions and clouds aren't supported" ==> What do you mean by "aren’t supported"? Are you saying that one will not be able to set up and hold a live event if one’s tenant is located in one of the unsupported countries/regions? Some clarification would have been nice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b679199-caa5-4cc5-27e5-60a2cf999f69
Version Independent ID: 6878c954-e248-94c2-7602-47437ec7a2dd
Content: Plan for live events in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-live-events/plan-for-teams-live-events.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@MacKender  Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@MacKender thank you for reaching out and helping improve MS Docs. As far as I know, yes, that is what is meant by the statement in the article. Let me know if you have any suggestions to add a note for clarification for other users.

@MacKender Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Upgrading to pfsense 2.5 -- controller won't start, missing mongodb

Hi, I just upgraded my pfsense to 2.5, but the controller would not fully startup.  I determined that mongo was not starting and running 'mongo' on the command line was giving some kind of SSL error.
I checked pkg to re-install mongo fresh but it wasn't there.  It looks like pfsense 2.5 decided to disable the FreeBSD pkg repos.  I had to modify the files in /usr/local/etc/pkg/repos to re-enable the FreeBSD repo, then I was able to re-install mongo.  After that, the controller started up fine.
I'm unsure if I should leave the FreeBSD repos enabled or not, or if that will cause any conflicts with the PFsense repos (they probably disabled FreeBSD for a reason).
Anyway -- I figured I'd document my findings here for the next guy.  I'm not sure what the right patch would be to the script to address this, but it's probably non-trivial.

For the record:
I removed the 'FreeBSD' section of: /usr/local/etc/pkg/repos/pfSense.conf, it was something like:

FreeBSD: { enabled: no }

I also copied over  /usr/local/etc/pkg/repos/FreeBSD.conf from /etc/pkg/FreeBSD.conf
Perhaps not the most elegant changes, but it got the job done.
Then:

pkg update
pkg install mongodb36

I hit the same issue after updating to 2.5.1 from 2.4.5. The version of mongodb I had previously installed (3.6.21) was linked against an older version of OpenSSL that was removed in the new pfSense release.
The only fix I found was to upgrade to the latest mongodb, which meant re-enabling the main repos.

no more updates, closing


#17 host aliasing

This turned out to be a problem with Golang's way domain names are resolved. If you are using K8S' Host aliases you will also need a nsswitch file based on info from here: Golang source.


Download all the images of contacts

Closes: #81
Proposed changes
Now the user will be able to download the images of all WhatsApp contacts and save it to a media_images folder
Types of changes
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Screenshots

USE : python3 -m wplay -wmedia

The used then has to input total whatsapp contacts

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- wplay/get_media.py  7
- wplay/__main__.py  1

See the complete overview on Codacy

Please review @rpotter12 @xandao6 @priyansh19

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 3

Complexity increasing per file
==============================
- wplay/get_media.py  7
- wplay/__main__.py  1

See the complete overview on Codacy

Made the changes @rpotter12. There were no additional packages installed. So no changes in requirements.txt and setup.py file


SpeechKITT.displayRecognizedSentence  (true) not working, Any alternative?

@TalAter Sir I really big fan of you because of your all open-source cool projects......
I am Using your Annyang js on my project which working very well but I don't know why
SpeechKITT.displayRecognizedSentence  (true) not working, But I badly need to show what the user speaks on the mic, is there any fix for this, if not then is there any alternative way that I can perform to do this?
here is the code
`if (annyang) {
// Add our commands to annyang
annyang.addCommands({
'hello': function() { alert('Hello world!'); }
});
// Tell KITT to use annyang
SpeechKITT.annyang();

// Define a stylesheet for KITT to use
SpeechKITT.setStylesheet('//cdnjs.cloudflare.com/ajax/libs/SpeechKITT/0.3.0/themes/flat.css');

// Render KITT's interface
SpeechKITT.vroom();
SpeechKITT.displayRecognizedSentence(true);

}`

Hi @alexia-rose
Thanks for bringing this to my attention. I just tested this and I can see the issue you are describing.
It looks like KITT is correctly adding the recognized sentence text and appending it to the DOM...
https://user-images.githubusercontent.com/926653/140663541-ebfc6e54-5bd1-4c52-b9d7-4abfd61d7cb2.mp4
... unfortunately it looks like the element containing that text has display: none; set on it.
I will try to find some time to fix this, but it won't likely be in the next few months.
If you would like to tackle this and send a PR with a fix, that would be awesome. Alternatively, you might be able to get around this bug for now with a custom stylesheet that replaces themes/flat.css. Specifically the section shown here https://github.com/TalAter/SpeechKITT/commit/b2306c4445b17cea2038412e9b181c571b2496e9

@TalAter thank you so much for your response and time sir,
I am pretty new to web development so having problems understanding how I can fix it by myself :(
I will wait for you to fix this 😢 until i will use without this feature


Alt-F12 "Peek Definition" does not work

Pressing Alt-F12 doesn't seem to do anything, but pressing F12 opens mixin definitions correctly but also peeks at the same time.
(see #36)
Right-click context menu opens the 'peek defintion' view to the line you right clicked, not the file where the mixin is defined.

Should be fixed in 0.6.2 version.


command line too long

This issue was originally created at: 2005-05-06 02:12:37.
This issue was reported by: chaarmeijer.
chaarmeijer said at 2005-05-06 02:12:37

When generating our SDK on Windows using the latest
Scons, python 2.4.1 and MSVC 6, the command line
got too long and the compile terminates. This could be
prevented via the use of response files with MSVC.

issues@scons said at 2005-05-06 02:12:37

Converted from SourceForge tracker item 1196445

stevenknight said at 2006-11-08 15:28:56

A fix has been integrated for next release that executes command lines on
Windows directly when possible, and only uses cmd (the source of the line length
limitation) when a command line contains a pipe or file redirection or other
character that requires interpretation.

Hello
I am using the latest scons . but still I am getting this error.
Varsion details below
script: v<IP_ADDRESS>b2c53bc42290e911b334a6b44f187da698a668, 2017/11/14 13:16:53, by bdbaddog on hpmicrodog
engine: v2.5.0.rel_2.5.0:3642:1201f1727768, 2016/06/29 17:42:26, by dholth on cardamom
engine path: ['C:\Python27\lib\site-packages\SCons']

@adul2020  - Please bring your issue to the users mailing list. Likely there's other issues at play. Also looks like your scons install is broken.. script 3.0.1... and engine 2.5.0...


Refactor ExpressiveValidator

remove lock
use ConcurrentDictionary for caching

Your solution is nice and should work at first sight. Nevertheless I'll hold on with the merge at the moment, because maybe simplification related to complete removal of threading related logic from this particular class is the way to go (or at least understanding why it is needed if it is).

OK, let me know what you decide. Getting rid of threading entirely would be nice, but at least ConcurrentDictionary abstracts out all that crap.
We're running this fork on production right now, so far seems to be smooth.

Modification merged. @pawelpabich: if you'll face your old problem after release, please let us know (I believe it'll be working correctly).


Logger crash when the value contains '%'

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

Coverage remained the same at 89.244% when pulling 19203077ea2d22af881953feeba2a5702621b976 on muniraju:master into b9799ee715fc3ff7f78d764c844ca740975f706a on snowplow:master.

I have signed cla!

Confirmed! @muniraju has signed the Individual Contributor License Agreement. Thanks so much


fix: add more APIs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: aeneasr:x: upptime-botYou have signed the CLA already but the status is still pending? Let us recheck it.


NVIDIA HDMI Audio Output never works on startup.

OS:
Windows 10 LTSB 2016 (14393.2273)
GPMDP Version:
4.5.0
Issue Descriptions:
Released NVIDIA audio device never initializes and requires re-selection.
Steps to Reproduce:

Start GPMDP
Play audio
Notice that there's no output...
Go into Desktop Settings -> Playback -> Re-Select the already selected P24h-10 (NVIDIA High Definition Audio).
Have audio work again.

100% Reproducible, either a regression from GPMDP or Nvidia driver changes.

Still broken in 4.6.1?

Still broken in 4.6.1?
Unfortunately; yeah.


Rule for validating class layout

A rule to validate the class layout is nice to have.
https://kotlinlang.org/docs/coding-conventions.html#class-layout

Dupe of #309


Vending machines have way too much stuff in them

They're being used for cosmetic purposes but you have shit like this:

A hot drinks machine doesn't need 20, it should have like 5 due to the volume of them we have.
Note that you should change this after botany and chef are looked at.

is it time for the great emogarbage vending machine 1984 to return?

Okay new idea from discord:
Split vendors more. In the above case it should be separate coffee and tea vendors, then we just let the randomised spawners handle it.

If this is implemented, the person responsible will have to re-balance the prices of existing vending machine restock boxes and add new ones corresponding to the new split machines, for #11506.


fix: Change instance_metadata_tags to default to null/disabled due to tag key pattern conflict

Description

change instance_metadata_tags to default to null/disabled due to tag key pattern conflict

Motivation and Context

Closes #1785

The default is disabled when a value is not provided. In hindsight, we should have matched the default behavior of the API and let users opt in. I don't know why there is a different tag restriction pattern for metadata tags but its currently causing issues for users so better to opt out and let them opt in as they see fit

Breaking Changes

Controversial, but I will say no

How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects

This PR is included in version 18.2.1 :tada:


Create updated WinGet package for March 2024 GDK

Create updated WinGet package for March 2024 GDK

@microsoft/xbox-developer-experience-toolbox for review

@microsoft/xbox-developer-experience-toolbox for review


invalidHost() test does not work with dyn dns configured

Fixed broken ServerConfigTest.invalidHost() test. 19<IP_ADDRESS> is not a valid IP adress and is resolved as a host which does not fail when dyn dns is used. Made it an invalid ip6 adress instead.

Thanks, I missed that point.


Rework SFC examples

Signed-off-by: Rastislav Szabo<EMAIL_ADDRESS>

Coverage increased (+0.02%) to 69.01% when pulling 52fd0a7f44324cb44277e71b20d472dc16c4106c on rastislavszabo:sfc into 9ddb3e7f80f76666b834fcebd40f7802cd992040 on contiv:dev.


Migrate ebrainsFeature to EbrainsDatasetVersionV3

EbrainsFeature queries have been using KG v1 connection. This PR makes general adjustments to ebrains data features around EbrainsDatasetVersionV3 queries.

TODO: Some datasets have no fullname field in their detail. This causes some features to return a None type name.
import siibra
fts = siibra.features.get(siibra.get_region('wax v3', 'neocortex hippocampus'), siibra.features.other.EbrainsDataFeature)

@xgui3783, any ideas how to remedy this without making changes in the query?

Potentially, one can add the following to provide access to the data:
def get_connector(self) -> RepositoryConnector:
    return EbrainsPublicDatasetConnector(self._dataset.id)


store transaction information in the cloud

The idea is to keep childchain PG data lean and upload json blocks with transactions to a CDN. The childchain then redirects the block.get requests to the CDN.
Context:
After a block is formed and submitted to the contracts, all watchers in the network request for block data, via block.get where the argument to the request is the block hash.
The childchain responds with all transactions included in the block, so that watchers are able to apply these transactions on their own ledgers, and spend inputs and produce outputs.
If we don't offload this transaction information, we need to keep them on the childchain side (permanently) and stress the application. The http responses are very suboptimal (large jsons).

As there were no further feedbacks I will take this as an accepted proposal and outline an approach in a separate issue. Thanks!


gabbyusubs ~ only korean tv shows

Source name
gabbyusubs
Source URL
https://www.gabbyusubs.com
Package type
bangumi
Source language
en
Other details
Here is also their sister site:
Forum by Gabbyusubs: https://forum.gabbyusubs.com/ (this sister site uses the same servers, only difference in the website layout and design)
I suggesting this extension because I've experienced that the shows were uploaded within an hour after the original broadcast and way sooner like 5-8 hrs before the dramacool or other sites.
@appdevelpo @OshekharO PLEASE HAVE A LOOK AND I'M REALLY HOPING TO USE THIS AN EXTENSION.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Forum by Gabbyusubs

uses POST method for search

mostly uses https://shorturl.at/ in the iframe for redirecting to video server link

Gabbyusubs

uses GET method for search

uses https://shorturl.at/ but also others at random.


Demo Admin Account

Can you share account for admin page on demo site?

its : Email<EMAIL_ADDRESS>PW: admin123
But i have not updated demo website to latest version yet.

@indpurvesh Yep :) Thanks

@indpurvesh Does demo site account changed?

@darron1217 Try now.

@indpurvesh It works now :)
Thanks


 As long as the codebase is structured in a recursive way, this will be an problem.
This input also causes a crash with type inference.
a {{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{{

Restructuring everything to be iterative might make the entire codebase much cleaner too, but it would also require a huge rewrite of everything. So the fix to this one might not be as fast as the other ones.

I just pushed a large change to hir_ty which removed much of the recursion but the input still crashes for some reason. I must have missed something or misdone something.
I'll look into it soon.


feat(deployment) add template rendering to initContainers

What this PR does / why we need it:
Allow users to pass helm templates (e.g. for the image name) when definining additional initContainers
Which issue this PR fixes

fixes #825

Special notes for your reviewer:
None
Checklist

[x] PR is based off the current tip of the main branch.
[x] Changes are documented under the "Unreleased" header in CHANGELOG.md
[x] New or modified sections of values.yaml are documented in the README.md
[x] Commits follow the Kong commit message guidelines

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jeroen Vankelecom seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[v0.16] Fix NLL compatibility

Uncovered by a crater run in https://github.com/rust-lang/rust/pull/63565, the most recent v0.16.x version breaks when NLL is fully enabled. This PR is targeted to be based atop tag v0.16.13 (it's probably easiest to merge it manually, unless you want to create a branch for this PR to target).

See also #561 , #562 and #616 . Interesting that 0.16.x is still used so much in the wild.

@Mark-Simulacrum Thank you for this PR! I've create a v0.16 branch which is the new target of this PR. Why is the #![allow(deprecated)] necessary!

Ah, I think I forgot to drop that, it's not strictly necessary, I can drop it if you'd like.

I can drop it if you'd like.

That would be great!

Okay, I've dropped the deprecation commit, so this should be good to go. (Closed and reopened because CI failed due to seemingly unrelated -- perhaps network -- reasons).

Thanks! Don't mind the CI. It will fail because of a changes on travis ubuntu version. We fixed our .travis.yml after the 16.x releases.


Is supporting rust 1.0 still needed?

It makes sense to not be dependent on the absulote latest rust version, but 1.0 seems a bit of a stretch as it e.g doesn't support ? which would make it hard to follow the library guidelines.

As long it is not a big pain I do not see any benefit of dropping 1.0 support. So far I see no features which would justify dropping 1.0 support. Using ? Instead of try! would mean dropping support for everything below 1.13 not just 1.0.
Besides, the guidelines are just guidelines. If you can't follow them no harm is done.

I sent a pr about using ? and bumping min stable version to 1.13 in #54
I hope this is not still controversial :-)

Closing issue as resolved with #54


Vite config cleanup after Remix stabilized

Just some quick cleanup I encountered using the starter just now.

Removed unstable_ prefixes
Removed now unused LiveReload component

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much!


Centered image alignment crashes on save

In a HTMLEditorField, selecting Centered, on its own. for an image's alignment causes the following fatal PHP error on save:
PHP Fatal error:  Call to a member function appendChild() on null in /Volumes/Users/foo/Sites/bar/framework/View/Parsers/ShortcodeParser.php on line 187

All other alignments seem to save ok.
Observed in the latest dev-master.

I can confirm this

A lot of painful research reveals the problem to be https://github.com/silverstripe/silverstripe-framework/pull/1190
The feature this change attempted to address no longer seems to be necessary; Tinymce shortcode handling has advanced quite considerably since 3.x.
I'm tempted to choose between a huge revert, or just dropping our core shortcode handler and dropping in something like https://github.com/thunderer/Shortcode

It's hard to come up with a quick fix which isn't simply disable all dom element re-organisation.

Summarising a discussion offline with @tractorcow:
The DOM reorganisation code was designed for when shortcodes were inserted at illegal places in the DOM, eg:

hello there

[this_shortcode_generates_a_div]

goodbye there

Allegedly, more recent implementations of shortcodes in TinyMCE actually handle this by placing a
 in the WYSIWYG editor and replacing it with the shortcode on save.
If this is the case (and needs some testing) then we could get away with a simple replacement-based shortcode handler, and we could move to the thunderer library.
/cc @Firesphere @hafriedlander

Another option would maybe be to rewrite the current shortcode parser?
The downside would be, that we would need to maintain it ourselves. The upside would be it's probably easier to update and implement, than a third party module.
Digging deep into my memory, Thunderer wasn't really that easy to setup with SilverStripe. I may have some basic implementation lingering around in some unpushed branch, but it's not the holy grail I think.

Hi everyone, I'm the author of mentioned Shortcode library. I'd like to address some of the concerns raised here and in #5535. I'll link the comments and answer them here:

https://github.com/silverstripe/silverstripe-framework/issues/5535#issuecomment-219629328 I was also surprised that there are literally no generic shortcode parsers out there, they either copy WordPress regex or implement only a non-extensible set of BBCodes. That was the main reason to provide the proper solution using an actual parser, and that's Shortcode was born,

https://github.com/silverstripe/silverstripe-framework/issues/5535#issuecomment-219629544 yes, I'm the only maintainer, but I'm committed to supporting it. This library is quite popular, nears 30k downloads in total and over 100 daily. It is also well-designed, very extensible, and I'm open to any suggestions on how to make it better, on the basis that those improvements serve the shortcode processing problem for which it was created. Also, I guess that that key feature is HTML awareness? I'll be happy to discuss what you need here, maybe there is something I can do?

https://github.com/silverstripe/silverstripe-framework/issues/5535#issuecomment-220478558 I agree that this would be a substantial change, but it's definitely possible to use one of my parsers to extract the shortcodes and then just write ProcessorInterface compliant processor, that's exactly the reason I made the library so extensible,

https://github.com/silverstripe/silverstripe-framework/issues/5535#issuecomment-220571935 I consider the current state of Shortcode to be stable, even though there is no 1.0.0 release. As for the
 tag issue, please see my recent answer https://github.com/thunderer/Shortcode/issues/40#issuecomment-257632082 ,

https://github.com/silverstripe/silverstripe-framework/issues/5987#issuecomment-256250145 simple replacement is definitely something my library can do, as for the preceding / following text removal, please see my recent comment on the issue: https://github.com/thunderer/Shortcode/issues/40#issuecomment-257632082 ,

https://github.com/silverstripe/silverstripe-framework/issues/5987#issuecomment-256258404 my recommended way of setting up Shortcode in your project is to wrap the whole logic into the service and treat it as such by exposing only what's necessary - you pass the input, you get the replaced output. I'd be happy to help make it easier, so please let me know what problems did you encounter. I'd be very grateful for your feedback.

I'd throw my weight behind @thunderer's package.  If that happens we're just in the same place we are now, maintaining a shortcode parser.
Maybe if @thunderer was happy to recruit some more contributors it could alleviate our worries?

@dhensby Thanks for your support. I understand your worries, but let me restate that Shortcode is well designed, feature complete, extensible, and maintained. It exists for more than one and half year and was battle-tested in several projects. I'll be more than happy to hear about new feature ideas or any difficulties you encountered. Also please note that it's already used (among others) by Corcel, Grav CMS, pingpong/shortcode, coduo/php-humanizer, and will be used in next major release of golonka/bbcodeparser.
When you talk about more contributors, do you mean more people contributing to code or just more repository owners? I think that there were so little contributions so far only because when I design a feature, I think about the whole abstraction so that you can extend what you need in your project and do not need to change the upstream. Open/Closed principle, if you wish. :) This comes directly from the "functional approach" idea I came across years ago. I even managed to talk about it on several conferences.

Hi @thunderer I firstly want to say thank you greatly for the amount of interest and thought you'd put into empathising with our issues. As an open source project we really benefit from having a positive relationship with other library developers, so it's great that we can collaborate in this way. :)
Given your feedback and suggested fixes, I see that any of the possible road-blocks we have to implementation have been addressed. (see https://github.com/thunderer/Shortcode/issues/40#issuecomment-257632082)
I would like to put my weight behind the conversion of this fix into a new proof of concept silverstripe shortcode replacement. @sminnee given your insight into the original work done on shortcode handling, do you feel likewise?
@thunderer if this became the case, perhaps I will myself be able to contribute back to your project, as is normally the case when we take on third party dependencies. :) We rarely find ourselves not contributing back, as we have to jquery-validate, composer, monolog, etc.... perhaps that was what @dhensby was hinting at.

ping @sminnee

It's now popping up in CMS behat tests in insert media. Priority is now increased.

I've attempted to disable this feature at https://github.com/silverstripe/silverstripe-framework/pull/6349, although this simply disables the feature rather than fixes it.

Any word on this issue and when it may be fixed, As it is still happening.

@adrian-stein which version of framework are you experiencing this on?

3.5.0

That's a shame; It's going to be troublesome to disable this feature in 3.5 without semver repurcussions, and the actual issue itself is very difficult to fix properly.
@dhensby can you think of a semver-way to address this issue? The only fix I can suggest is #6349 which violates semver in 3.x.

Are you sure you're on 3.5.0 and not 3.5.x-dev?
It seems that https://github.com/silverstripe/silverstripe-framework/commit/a4760b8ee409c2c96a0e77445debf931259cb9aa causes this bug to appear in 3.x, but this isn't apparent until 3.5.1, as 3.5.0 doesn't have this patch yet.
@dhensby IMO this blocks 3.5.1 release.

Ok, so that patch only raises the issue in Left, on its own which is the default. Centered on its own has always been broken and remains so.

Yup on .0
 "silverstripe/cms": "3.5.0",   "silverstripe/framework": "3.5.0",
I am needing "Centered on its own", "Left, on its own" doesnt produce the error.

Yeah, that makes sense. :) The issue always existed and now it's about to get worse unless it's patched before 3.5.1.

@sminnee could you please help us make the call, can we disable this feature on 3.5 given that it crashes?

By the way @adrian-stein thanks a lot for the prompt reply.  :)

No problem, happy to help. Me being quick helps you, and you fixing it, hopefully quick helps me :)

Also you talk about disabling it. Does that mean we wont be able to centre media? As it is a fairly useful and important feature for me.

Oh, you'll be able to center of course. What will happen is that it will no longer attempt to wrap the shortcode in a container element, nor break it in the middle of parent elements.

I recommend that we remove the use of ShortcodeParser::SPLIT and revert to the 3.4 use of ShortcodeParser::INLINE for both center and leftAlone images.

Thanks @sminnee , +1 for this, as it appears to be the least intrusive. Not urgent, but let's get this in before 3.5.1

If 3.5.1 is already in RC then it's urgent. Can either @dhensby or @tractorcow pick it up? :-)

I'll tag it tomorrow.

Thanks for the quick response guys. Il look forward to 3.5.1. Any ideas when it will be released?

Tomorrow! Just gonna make the call. :)

Minimal 3.5.1 fix at https://github.com/silverstripe/silverstripe-framework/pull/6436; Will use INLINE in place of SPLIT for now.

Merged


Don't emit the filename in diff mode

So that the output can be piped straight into something expecting a diff. Also so that no output => no changes.

hi @nrc - thinking about taking on this issue but have some questions.
how will users tell which diffs belong to which file with multi file changes?
how about git diff style output instead (maybe add as a config value)?
number of context lines in diff mode is hardcoded as 3 - seems like something fit for a config value?
any way to unit test output to std::out in rust?

hi @nrc - thinking about taking on this issue but have some questions.

awesome!

how will users tell which diffs belong to which file with multi file changes?
how about git diff style output instead (maybe add as a config value)?

I would expect the diff to include the file changed, I thought that was part of the metadata emitted with the diff. (Just to be clear, the filename this issue is concerned with is the one Rustfmt emits when reading a file).

number of context lines in diff mode is hardcoded as 3 - seems like something fit for a config value?

Seems like a good idea, but should be a separate PR please.

any way to unit test output to std::out in rust?

I believe you can capture std::out when running a process, I'm not sure of the details though, sorry. Maybe ask on #rust.

This is partially addressed by #1123, so we can check for an empty diff for the case that Rustfmt makes no changes. There is still some work to do so that our output can be used by tools expecting a diff (e.g., patch).


NIFI-10588 Add a new goal that checks dependency duplications in nars

Summary
NIFI-10588
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
locally tested with mvn verify
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@MikeThomsen and @SaumyaGurtu I'm not sure this PR accomplishes the goal described in NIFI-10457. Although the plugin configuration checks for duplicate dependencies, it does not highlight when certain dependencies should be marked as provided. Therefore, I'm not sure this should be merged.

@MikeThomsen The proposed solution has passed the checks and highlights the duplicate dependencies in the project if any as asked in the ticket. This will increase the discipline in the repository.
Please let me know if you have any change in plans.

@SaumyaGurtu Although this pull request looks like a useful improvement, it does not accomplish the goals described in the associated Jira issue. The goal described in the Jira issue is specifically related to NAR bundles. Although a NAR bundle may not contain direct duplication of dependencies, the hierarchical nature of NAR dependencies means that a child NAR could have the same library as a parent NAR, making the extra dependency unnecessary in the child NAR. This kind of relationship is not necessarily detected through the maven-enforcer-plugin because NAR bundles are specific to Apache NiFi. For this reason, an alternative approach will be necessary to accomplish the goal described in the Jira issue.

@SaumyaGurtu, although this PR does not align with the goals of NIFI-10467, it is still a useful improvement and it does appear to implement the features described in NIFI-10588. I updated the title and link to relate to that Jira issue.
With that change, this can be reviewed with the purpose of banning duplicate dependencies. This needs to be verified in a local build to ensure that it works as designed.

@exceptionfactory I think you probably meant NIFI-10457 not NIFI-10467

@exceptionfactory I think you probably meant NIFI-10457 not NIFI-10467

Thanks for the correction @dan-s1!

@exceptionfactory I am not sure how this differs from what I tried for NIFI-10565 but could not get working with the Maven Enforcer plugin.

@dan-s1 Yes, it sounds similar. This may only check for duplicates declared in the pom.xml itself, without reference to dependencies inherited from parent definitions. With your previous testing, that would be a key point to evaluate, and I plan to take a closer look soon. This warrants some reading of the Maven Enforcer Plugin documentation.

@SaumyaGurtu, are you able to make the adjustments suggested to move the banDuplicatePomDependencyVersions under the current Maven Enforcer configuration?

@SaumyaGurtu Based on the work you already did, I updated the branch to move the ban rule under the current set of enforcer rules. I also rebased the PR so that we can get a current status of the build with this rule enabled.


Why mapMultiRowFields returns empty objects?

https://jsfiddle.net/roman1101/te4ordgh

Thank you. I had warn Cannot read property 'name' of undefined when i define data like that:
var all = []
all[1] = {id:1, name:'name1'}
all[2] = {id:3, name:'name1'}
...
state:{all},
...
But this is Vue feature

@RVeligotskiy can you please show the data definition that did work? So that we can see the difference.

@maoberlehner If you create a separate independent computed value that points to chacteristic then that reference to the store will not render empty.
See here for example of this based on above example: https://jsfiddle.net/noeldacosta/o1ae65nd/7/
This suggests that this is a reactivity issue. This is highlighted by the buttons I've added. If you view the inspector you will see that the aliased computed property is an observer whereas the other is not.

Is there any further updates on this? This is still an issue in June 2021.
A workaround for now is to use the store directly, but it doesn't feel like the correct solution.
this.$store.state.characteristics


ecc compiles SEC("lsm/path_chown") error

#include "vmlinux.h"
#include <bpf/bpf_core_read.h>
#include <bpf/bpf_helpers.h>
#include <bpf/bpf_tracing.h>

lsm-path_chown.bpf.c as follows:
/*LSM_HOOK(int, 0, path_chown, const struct path *path, kuid_t uid, kgid_t gid)*/
SEC("lsm/path_chown")
int BPF_PROG(forbid_chown,const struct path *path,kuid_t uid, kgid_t gid)
{
	   	return 0;
}

char _license[] SEC("license") = "GPL";

The compilation process is as follows:
[root@cloud test]# ecc lsm-path_chown.bpf.c
INFO [ecc_rs::bpf_compiler] Compiling bpf object...
INFO [ecc_rs::bpf_compiler] $ "clang" CommandArgs { inner: ["-g", "-O2", "-target", "bpf", "-Wno-unknown-attributes", "-D__TARGET_ARCH_x86", "-idirafter", "/usr/local/include", "-idirafter", "/usr/lib64/clang/12.0.1/include", "-idirafter", "/usr/include", "-I/tmp/.tmp5LhqOe/include", "-I/tmp/.tmp5LhqOe/include/vmlinux/x86", "-I/home/hf/highrisk/test", "-c", "lsm-path_chown.bpf.c", "-o", "lsm-path_chown.bpf.o"] }
INFO [ecc_rs::bpf_compiler]
ERROR [ecc_rs::bpf_compiler] lsm-path_chown.bpf.c:12:5: error: passing 'void *' to parameter of incompatible type 'kuid_t'
int BPF_PROG(forbid_chown,const struct path *path,kuid_t uid, kgid_t gid)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/.tmp5LhqOe/include/bpf/bpf_tracing.h:435:20: note: expanded from macro 'BPF_PROG'
        return ____##name(___bpf_ctx_cast(args));                           \
                          ^~~~~~~~~~~~~~~~~~~~~
/tmp/.tmp5LhqOe/include/bpf/bpf_tracing.h:410:39: note: expanded from macro '___bpf_ctx_cast'
#define ___bpf_ctx_cast(args...)      ___bpf_apply(___bpf_ctx_cast, ___bpf_narg(args))(args)
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/.tmp5LhqOe/include/bpf/bpf_helpers.h:184:29: note: expanded from macro '___bpf_apply'
#define ___bpf_apply(fn, n) ___bpf_concat(fn, n)
                            ^
note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
<scratch space>:14:1: note: expanded from here
___bpf_ctx_cast3
^
/tmp/.tmp5LhqOe/include/bpf/bpf_tracing.h:400:39: note: expanded from macro '___bpf_ctx_cast3'
#define ___bpf_ctx_cast3(x, args...)  ___bpf_ctx_cast2(args), (void *)ctx[2]
                                      ^~~~~~~~~~~~~~~~~~~~~~
/tmp/.tmp5LhqOe/include/bpf/bpf_tracing.h:399:63: note: expanded from macro '___bpf_ctx_cast2'
#define ___bpf_ctx_cast2(x, args...)  ___bpf_ctx_cast1(args), (void *)ctx[1]
                                                              ^~~~~~~~~~~~~~
lsm-path_chown.bpf.c:12:58: note: passing argument to parameter 'uid' here
int BPF_PROG(forbid_chown,const struct path *path,kuid_t uid, kgid_t gid)
                                                         ^
1 error generated.

Error: Failed to compile

Caused by:
    Failed to run clang(exit code = Some(1))

Seems it was not related to ecc. I can't compile this program with libbpf-bootstrap

kuid_t is a struct, which is not able to be casted from void*

Is this problem definitely a problem with the operating system itself? Will it be eliminated if I upgrade to the latest kernel version? My current kernel is 5.10. What version do I need to upgrade to?

Is this problem definitely a problem with the operating system itself? Will it be eliminated if I upgrade to the latest kernel version? My current kernel is 5.10. What version do I need to upgrade to?

It might be an issue about your code. You may use unsigned 64bit integer for the argument uid

If I change to 64-bit integer and compile with ecc, there is indeed no problem, but when loading with ecli, an error will be reported and the type does not match.

ecli error info : invalid param:failed to deserialize package to object, invalid type:null


dwc + extensions text edits and additions

Edited parts of text for clarity
Expanded explanations for Occurrence, Event core, extensions, identifiers
Elaborated figure captions
Added connection between Occurrence core/extension and eMoF

Instructions
Thanks for contributing! :heart:
If this contribution is for instructor training, please email the link to this contribution to
<EMAIL_ADDRESS>so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!
Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at<EMAIL_ADDRESS>You may delete these instructions from your comment.
- The Carpentries

Looks good to me!


[5.2] Use Instance query instead of cloned parent query

This fixes https://github.com/laravel/framework/issues/13762

This breaks our tests?

Yes wasn't aware of that. Haven't tested it locally sorry for that.
But the test actually don't test if the morphed model don't use the SoftDeletes trait.
This problem still exists #13762 it will fail if you don't use the SoftDeletes trait on a morphed Model.
I have a closer look. But some help would be nice.

@tiran133 Can you just PR a test case that currently doesn't work?
ping @phroggyy

@GrahamCampbell Replaced by https://github.com/laravel/framework/pull/13806


Add ability to sort widgets

Hello,
This PR adds the ability to sort widgets, similar how you can sort the right menu options.
It's backwards compatible, so it won't break or change ordering of existing widgets if no order is set.

Hey, please move the sorting logic to FilamentManager so that plugin-registered widgets are also sorted.
Also, add the $sort attribute to the base Widget class, not the stub.

Hello,
I've just taken a look into this, and I'm not sure which way is preferable, on FilamentManager, having in mind that

$widgets is a public property, so it should be ordered by default in case someone is using it directly
Being $widgets a public property, it can be modified by the developer, so the order would be lost

So the two options are:

Order $widgets when calling registerWidget(). This would be less performant, and would ignore those two points before
Order the widgets when calling getWidgets(). This is only called one time, so it should be more perfomant. The widgets would be ordered also in case the developer tinkers with $widgets property, but not if he uses that property directly.

I think the second one is better, what do you think?

Hi,
Yeah, exactly. I was hinting at using getWidgets() to process sorting.

Done.
I'm using a intermediate collection because it will allow for cleaner code when adding #746 to the same method.

Thanks!


chore: bump zellij version to 0.41.1

With zellij 0.41.1 there were some changes on how keys are handled, I adapted the code to those changes so that it now supports the latest version, I tested locally and it seems to work as intended, but feel free to give it a try since I wasn't using this plugin before and I'm not sure if I missed something.
This plugin and sessionizer are going to improve my workflow a bunch, thanks for publishing these!
Resolves #1

works great, thank you


Add function to properly import gpg keys

This is a rebase of https://github.com/voxpupuli/puppet-yum/pull/118
Fixes #116

Hi @linuxdan. I fixed the spec issues. The function was in the wrong directory. Can you add an acceptance test for this?

@bastelfreak
Sure, but I do not know how.
Might you have a link or three describing how to write one ?

@dhoppe I could never get past Travis.
If you can get my function into the master branch, I would be eternally grateful.

TravisCI fails for two reasons. First the variable $path contains a / and the Rspec tests have to be adjusted.

https://github.com/voxpupuli/puppet-yum/blob/master/spec/defines/gpgkey_spec.rb#L24
https://github.com/voxpupuli/puppet-yum/blob/master/spec/defines/gpgkey_spec.rb#L39-L40

  1) yum::gpgkey with content provided with ensure = present should contain Exec[rpm-import-/test-key] with path => "/bin:/usr/bin:/sbin/:/usr/sbin", command => "rpm --import /test-key", unless => "rpm -q gpg-pubkey-$(gpg --with-colons /test-key | head -n 1 | cut -d: -f5 | cut -c9-16 | tr '[A-Z]' '[a-z]')" and require => "File[/test-key]"
     Failure/Error:
       is_expected.to contain_exec("rpm-import-#{title}").with(
         'path'    => '/bin:/usr/bin:/sbin/:/usr/sbin',
         'command' => "rpm --import #{title}",
         'unless'  => "rpm -q gpg-pubkey-$(gpg --with-colons #{title} | head -n 1 | cut -d: -f5 | cut -c9-16 | tr '[A-Z]' '[a-z]')",
         'require' => "File[#{title}]"
       )

       expected that the catalogue would contain Exec[rpm-import-/test-key]
     # ./spec/defines/gpgkey_spec.rb:21:in `block (4 levels) in <top (required)>'

  2) yum::gpgkey with content provided with ensure = absent should contain Exec[rpm-delete-/test-key] with path => "/bin:/usr/bin:/sbin/:/usr/sbin", command => "rpm -e gpg-pubkey-$(gpg --with-colons /test-key | head -n 1 | cut -d: -f5 | cut -c9-16 | tr '[A-Z]' '[a-z]')", onlyif => ["test -f /test-key", "rpm -q gpg-pubkey-$(gpg --with-colons /test-key | head -n 1 | cut -d: -f5 | cut -c9-16 | tr '[A-Z]' '[a-z]')"] and before => "File[/test-key]"
     Failure/Error:
       is_expected.to contain_exec("rpm-delete-#{title}").with(
         'path'    => '/bin:/usr/bin:/sbin/:/usr/sbin',
         'command' => "rpm -e gpg-pubkey-$(gpg --with-colons #{title} | head -n 1 | cut -d: -f5 | cut -c9-16 | tr '[A-Z]' '[a-z]')",
         'onlyif'  => ["test -f #{title}", "rpm -q gpg-pubkey-$(gpg --with-colons #{title} | head -n 1 | cut -d: -f5 | cut -c9-16 | tr '[A-Z]' '[a-z]')"],
         'before' => "File[#{title}]"
       )

       expected that the catalogue would contain Exec[rpm-delete-/test-key]
     # ./spec/defines/gpgkey_spec.rb:37:in `block (4 levels) in <top (required)>'
puppetlabs_spec_helper: defaults `mock_with` to `:mocha`. See https://github.com/puppetlabs/puppetlabs_spec_helper#mock_with to choose a sensible value for you


Configuration of description font size

For TV usage, the font size of the descriptions are too small and different from all the other font sizes:

A configurable font size would be awesome.

Font size is now linked for Font Size Small in v1.2.3, no ETA on release.


Modularization Base Structure

This commit creates following modules

fluentui_core
fluentui_listitem
fluentui_drawer
fluentui_tablayout
fluentui_others
FluentUI

In addition, contains a build pipeline to create universal package
of the Fluent UI library
Platforms Impacted

[*] Android

Description of changes
This commit creates a base structure for the modularization and adds following modules

fluentui_core
fluentui_listitem
fluentui_drawer
fluentui_tablayout

In addition to these, following modules are created

fluentui_others - Containing rest of the controls apart from the ones covered above
FluentUI - This will act as a container module which has a dependency on all the four modules listed above and fluentui_others

For general users the dependency specification of Fluent UI in gradle will remain the same, though, now, it will fetch five other modules as the dependency
Verification
Change was tested by verifying all elements in demo app work
Pull request checklist
This PR has considered:

[* ] Light and Dark appearances
[* ] VoiceOver and Keyboard Accessibility
[*] Internationalization and Right to Left layouts
[*] Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

Merging to develop branch


Add capabiliy to map jobs to users

We should add some capability to map jobs to users. It should match up with the existing security layer of the web server.

We should talk to a websecurity expert, for instance @maartenplieger

OWASP provides general knowledge and best practices on web security, may be useful here: https://www.owasp.org/index.php/Main_Page


feat: user defined input run_id via config

I would like to be able to define run_ids before I start individual row validations, so that I can better keep track of individual runs.
Before this change = The run_id is generated as part of RunMetadata object using str(uuid.uuid4())
After this change = The run_id can be input via config, in which case it is assigned as part of data_validation.py, otherwise if the input config value is None then data_validation.py will continue to use str(uuid.uuid4())
To reviewers...
Please note that the majority of my changes are to test_data_validation.py where Ive added extra assertions and cleaned up things up by using references to consts values rather than strings.

/gcbrun

/gcbrun

/gcbrun

/gcbrun

@nj1973 - Would you mind explaining your 2 commits for my understanding please?

55f5e64
6857a27

Hi @nick-redfearn, happy to. In the BigQuery integration tests there are some tests which store validations in a YAML config file. They include an assertion that the number of lines in the YAML file match a constant. With the addition of the new run_id attribute the constants needed increasing by 1.
I'm not convinced that checking the number of lines in the config file is the best way for these tests to identify success but I don't want to dig into that right now.
You are unlikely to be able to run integration tests due to needing many different database types therefore you won't see knock on effects like this. I figured the simplest thing to do was to adjust the constants and update you once the tests were passing.
I'll review the PR properly later today.

@nj1973 Thanks very much 🙇

@nj1973 Im considering adding this to cli_tools.py, under _add_common_arguments

Yep, I think that's a good idea.

Yep, I think that's a good idea.

@nj1973 Added in this commit

@nj1973 Ive added these commits...

Cleanup in cli_tools.py to use consts values -> https://github.com/GoogleCloudPlatform/professional-services-data-validator/pull/1310/commits/6908c7ee70d16eba956126a45611dc1772a5b694
Adding to get_pre_build_configs -> https://github.com/GoogleCloudPlatform/professional-services-data-validator/pull/1310/commits/6908c7ee70d16eba956126a45611dc1772a5b694
Adding to test_config_manager.py, similar to test_get_threshold_property + formatting in get_pre_build_configs -> https://github.com/GoogleCloudPlatform/professional-services-data-validator/pull/1310/commits/b6b08d4f940d809bd8963b8cd4d4dc32021f7050

/gcbrun

Thanks @nick-redfearn for your continued contributions, it's very much appreciated.

@nj1973 Thanks a lot for your help, much appreciated 🙇


Remove Consumable Items on Use

This PR will introduce the logic for removing consumable items when used (specifically, for items of ItemType FOOD, FERTILISER, SEED, and PLACEABLE).
Note that there is still a bug with InventoryComponent causing display issues (and there is a bug in which removing an item with a count of 1 still allows player interaction until the player updates the inventory by switching to another hotbar slot), but this is going to be dealt with by team 8 when they update the inventory component.

There are better ways to do this, might clean in s4


Add example of feature set aware xvalidation rule

When adding new fields that are blocked behind a featureset, we sometimes need to have validations on their parent struct, but, these must only be present on the featureset version specific to the feature being added.
To achieve this, this PR includes an updated version of our controller-tools fork that allows a new validation based on featuresets for CEL validation rules. (https://github.com/openshift/kubernetes-sigs-controller-tools/pull/16)
Need to reset the go.mod before we merge

/lgtm


Disk check module is should be called whenever there is a change in disk space. However, the system is not working in this way

Diskcheck module should keep polling for the changes in the disk sizes being monitored. However, the disk size doesn't keep polling and hence manual refresh checks the changes in size of the disks if any.
Can we have a fix to it ?

Events from OS or diffing server-side are not supported.
It can either be manual or polling ATM


Allow to control port-forward via extension api

What would you like to be added:
An extension api that allows to configure port-forwards (per cluster).
Why is this needed:
Extension might provide services that need to be exposed to localhost via port-forward.

The https://github.com/Mirantis/lens-extension-cc extension has a specific use case for this: When an MCC cluster has StackLight enabled, we list the StackLight URLs (e.g. Prometheus, Kibana, Grafana, etc.). Our users would like the extension to provide a button to click to open a socket to these services in order to avoid having to manually create the tunnel.


Fixed incorrect link creation

So, several links weren't working because GitHub Markdown, for some reason, treated square brackets + space + parentheses like a title + link (although normal Markdown didn't). So I've added a bunch of escaping backslashes so as to distinguish the link and the notes about the programs' commerciality.
Another issue was with the link to the mutopia project. When it's without the preceding www, it isn't a working link...
And just so you know, the two websites — imslp.org and tunefl.com — are currently (?) unavailable. Nevertheless, I haven't excluded them from the list.

Thanks for your help! Interesting bug indeed.
http://imslp.org seems to be up again.
For tunefl I will link to the GitHub repo https://github.com/tiredpixel/tunefl

@adius But still tiredpixel/tunefl is a discontinued repo... Maybe you exclude this?

I think just because the maintainer doesn't work actively on it anymore doesn't mean
that it's not still a useful project.
If it has been laying around for years and isn't deployable anymore is when I would remove it…


Update hmr-react.md

small commit :) one extra line)

Can you sign the CLA? Good to go after that.

@bebraw , ah, sorry, i'm new here... I hope now I did it right.

It's cool. Thanks. 👍


Can't find MACRO_CALL in AstIdMap

Running ra_cli analysis-stats currently often produces the above error. I can reproduce this with Chalk, Cranelift and rustc. I guess it's looking in the wrong map when nested expansions are involved? I don't know the macro machinery well enough to investigate this though.
Full error and relevant part of the stacktrace:
thread 'main' panicked at 'Can't find MACRO_CALL@[11; 187) in AstIdMap:
[SyntaxNodePtr { range: [0; 391), kind: MACRO_CALL }]', crates/ra_hir/src/source_id.rs:108:21
stack backtrace:
(...)
   7: ra_hir::source_id::AstIdMap::ast_id
             at /home/florian/Projekte/opensource/rust-analyzer/<::std::macros::panic macros>:8
   8: <ra_hir::expr::ExprCollector<&'a DB>>::collect_expr
             at /home/florian/Projekte/opensource/rust-analyzer/crates/ra_hir/src/expr.rs:825

I can try to isolate a smaller reproduction, but I don't know if it's necessary ;)

It maybe related to #1243, which is the only macro expanding errors when i run ra-cli analysis-stats on rustc code.

And that issues maybe fixed by swapping the orders of locals and globals:
https://github.com/rust-analyzer/rust-analyzer/blob/940c538ecf42a53e5a0e0e9ebad7267c1fe843ca/crates/ra_hir/src/nameres.rs#L275
But i am not near computer till Monday. I would investigate more about it later.

But even if we can't resolve the macro / resolve it wrongly, we shouldn't crash, right?

I guess, we need to be just more principled with macro resolution....
Specifically:

instead of just "public macros" in DefMap, we should introduce proper macro scopes
inside Bodies, properly add stuff from macro-generated files to source map (I wonder if we can avoid storing an HitFileId for each expr)
take a calling context into account when expanding macro to item/expr/pattern etc

I've sort of punted on that for the time being in the hope that "name resolution librarification" effort deals with all these in a principled way, but the effort is stalled :(

Heh, I actually was trying to fix this bug in https://github.com/rust-analyzer/rust-analyzer/commit/594aac059e1f8c15a7c856e2778b0c4ff2a240aa#diff-874c3972fedd96a674824aaf3f448d98, and the fix was incomplete

But even if we can't resolve the macro / resolve it wrongly, we shouldn't crash, right?

Yes you are right, I just checked #1243  is not the reason of the assert. :(

Now analysis doesn't crash for chalk.
For rustc, it hangs inside chalk


feat: implement change path dialog (Issue #330)

Issue: https://github.com/epam/ai-dial-chat/issues/330

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review


Unresolved reference

Hi,
Firstly, thanks a lot for your awesome work!
There seems to be some errors in run_rvlcdip.py file. In the line "from datasets import ClassLabel, load_dataset, load_metric" it shows "Unresolved reference 'datasets'". And I can't find a module named datasets in the project folder.
Best regards,

It looks like there's a missed library in the requirements
Just run "pip install datasets", it's a very popular library from huggingface 👍🏻

Oh, I see. Thanks!


Discrepancy in results between screen output and report out

Hi,
Trying to figure out the onscreen results when fastp finishes running and the results summary in the generated report file.
The numbers don't addup....
Thanks for the help.
================
Example when fastp finishes and the output on screen gives:
Read1 before filtering:
total reads: 4000000
total bases: 400000000
Q20 bases: 392516035(98.129%)
Q30 bases: 376358571(94.0896%)
Read1 after filtering:
total reads: 3102308
total bases: 309754624
Q20 bases: 306341522(98.8981%)
Q30 bases: 294745910(95.1546%)
Read2 before filtering:
total reads: 4000000
total bases: 400000000
Q20 bases: 387859490(96.9649%)
Q30 bases: 373512577(93.3781%)
Read2 aftering filtering:
total reads: 3102308
total bases: 309754624
Q20 bases: 305723840(98.6987%)
Q30 bases: 295222362(95.3085%)
Filtering result:
reads passed filter: 6204616
reads failed due to low quality: 235470
reads failed due to too many N: 1559914
reads failed due to too short: 0
reads with adapter trimmed: 1355796
bases trimmed due to adapters: 17275112
=================================
These are the results in the report:
fastp report
Summary
General
fastp version:	0.7.0
sequencing:	paired end (100 cycles + 100 cycles)
Before filtering
total reads:	7.629395 M
total bases:	762.939453 M
Q20 bases:	744.224095 M (97.546941%)
Q30 bases:	715.132854 M (93.733893%)
After filtering
total reads:	5.917183 M
total bases:	590.810059 M
Q20 bases:	583.711016 M (98.798422%)
Q30 bases:	562.637589 M (95.231552%)
Filtering result
reads passed filters:	5.917183 M (77.557700%)
reads with low quality:	229.951172 K (2.943375%)
reads with too many N:	1.487650 M (19.498925%)
reads too short:	0 (0.000000%)

Good catch!
On-screen display should be 4000000 pairs = 8000000 Reads.
8000000 Reads = 7.629395 M
8000000 / 1024 / 1024 = 7.629395
I will change on-screen display to be as same as the report.
Thanks


api management gateway how to offline restart with backup snapshot ?

i'm not very sure it this description means the gateway can be able to start without internet ? if they have been run with the backup ?
_When configuration backup is turned on and connectivity to Azure is interrupted:
Running self-hosted gateways will continue to function using an in-memory copy of the configuration
Stopped self-hosted gateways will be able to start using a backup copy of the configuration_
i have try it in my local docker container, the snapshot it's already created in the path "/apim/config",
after offline and restart container ,  it throw error :

[Error]2021-07-8T01:46:52.274 [Error], exception: System.Net.Http.HttpRequestException: Name does not resolve

---> System.Net.Sockets.SocketException (0xFFFDFFFF): Name does not resolve

at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)

--- End of inner exception stack trace ---

at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)

at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)

at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)

at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)

at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)

at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)

at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)

at Gateway.Host.AspNetCore.ExternalConfiguration.ServiceConfigurationSource.<>c__DisplayClass17_0.<<UpdateConfiguration>b__1>d.MoveNext() in C:\azp\agent\_work\1\s\Proxy\Gateway.Host.AspNetCore\ExternalConfiguration\ServiceConfigurationSource.cs:line 166

--- End of stack trace from previous location where exception was thrown ---

at Polly.Retry.AsyncRetryEngine.ImplementationAsync[TResult](Func`3 action, Context context, CancellationToken cancellationToken, ExceptionPredicates shouldRetryExceptionPredicates, ResultPredicates`1 shouldRetryResultPredicates, Func`5 onRetryAsync, Int32 permittedRetryCount, IEnumerable`1 sleepDurationsEnumerable, Func`4 sleepDurationProvider, Boolean continueOnCapturedContext), source: ServiceConfigurationSource

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20dccd8b-f67a-8728-3bb3-f46a0ffdfd40
Version Independent ID: 3e79e57d-a348-b0d3-cd89-86c76ca70104
Content: Self-hosted gateway overview
Content Source: articles/api-management/self-hosted-gateway-overview.md
Service: api-management
GitHub Login: @vlvinogr
Microsoft Alias: apimpm

Hello @Restry,
Thank you for your feedback! We will review and update as appropriate.

Hello @Restry, apologies for the delayed response here. The scenarios mentioned in the documentation describe about connectivity disruption to Azure and I think you will still require a working internet connection for the self hosted gateway to work.  After a quick glance at the issue faced looks like the container was unable to resolve the custom domain name. To resolve the issue we might need to have a closer look at the configuration set-up it will be helpful if you could create a support request for the issue faced or you can also post a question on our QnA forum with  detailed reproducing steps.
As we primarily monitor this channel for any documentation bugs and updates. We will now proceed to close this issue out. Please tag me in your response if there are any additional concerns. Thank you!

ok thanks


specify bazel version in .bazeliskrc since .bazelversion not working …

…in bzlmod

This basically forced everyone to use bazelisk.
Is this caused by a bug in Bazel?

This basically forced everyone to use bazelisk.
Is this caused by a bug in Bazel?

Bazel don't respect .bazelversion in bzlmod anymore, it only works in workspace mode.
People can use USE_BAZEL_VERSION=7.4.1 bazel build ... to specify bazel version if not using bazelisk.

interesting ...

This basically forced everyone to use bazelisk.
Is this caused by a bug in Bazel?

Bazel don't respect .bazelversion in bzlmod anymore, it only works in workspace mode. bazelbuild/bazelisk#52
People can use USE_BAZEL_VERSION=7.4.1 bazel build ... to specify bazel version if not using bazelisk.

Maybe we should document this explicitly here as there is no .bazelversion file anymore and bazel users do not know the version required.

well done to bazelisk :D

@tongke6 Is it possible to just upgrade to bazel 8?

@tongke6 Is it possible to just upgrade to bazel 8?

I will give it a try when all secretflow repos have moved to bzlmod.

@tpppppub add instruction in this PR: https://github.com/secretflow/yacl/pull/444


Home Assistant 2024.6.3  issued started : Failed updating jwt token

Version of the custom_component
Latest versions
Describe the bug
Suddently stopped working, tried logging in again, credentials are accepted but getting
Failed updating jwt token
Debug log
Nothing in the debug log

Add your logs here.

+1

@dcsim0n do you have a chance to take a look at this?

It may be a couple days. I’ll add a reminder to take a look ASAP
Dana Simmons
https://linkedin.com/in/dcsimon
KN4BEV
On Mon, Jun 24, 2024 at 9:56 AM Luke Lashley @.***>
wrote:

@dcsim0n https://github.com/dcsim0n do you have a chance to take a look
at this?
—
Reply to this email directly, view it on GitHub
https://github.com/Southern-Company-HA/southern-company-hacs/issues/80#issuecomment-2186644025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKHAURGBD3DYBMR3VCAVYTZJAQPDAVCNFSM6AAAAABJVVJIQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWGY2DIMBSGU
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

Having the same problem here.  "Failed updating jwt token"

Any updates on this yet?

I looked at it briefly in my dev environment. When sending the auth request
the jwt token isn’t found in the response. It seems likely that the
southern company website changed  and HA needs to change to. I’ll spend
some more time looking at it later this week.
Dana Simmons
https://linkedin.com/in/dcsimon
KN4BEV
On Sat, Jul 6, 2024 at 3:19 PM Chance Callahan @.***>
wrote:

Any updates on this yet?
—
Reply to this email directly, view it on GitHub
https://github.com/Southern-Company-HA/southern-company-hacs/issues/80#issuecomment-2211890888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKHAUVONQVK7THAK35R5TTZLA7KZAVCNFSM6AAAAABJVVJIQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHA4TAOBYHA
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

@Lash-L Has the HA integration been updated with this fix? There looks to be a failing build on the API repo, not sure if it went out or not.

A new version should have been pushed now.

I am getting this error running 1.0.0


Add Meadowridge School (BC, Canada)

@JoelC11 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Thank you!


remove UseWebRoot in [Working With Static Files]

Please remove note or add clarification about UseWebRoot in Working with Static Files because there is no mentions of UseWebRoot in Introduction to ASP.NET Core
Does UseWebRoot work ? There is an open ticket for it #1367

Yeah, we should remove the pointer to the Intro to ASP.NET Core doc from that note.
Yes, UseWebRoot() does work, although I don't think VS will be able to reflect this correctly in the solution explorer. I believe VS just always assumes that wwwroot is your web root, but everything should still work correctly at runtime. The icon will just be wrong.

fixed in #2375


Breakpoint margin shouldn't be available if debugger experiment is off.

Current bits allow breakpoints to be set even if the debugging experiment is disabled. Doesn't really make sense to do this.

On the vscode side where the breakpoint margin is shown, we don't know whether there is a debug adapter available for a notebook. Breakpoints can be added if there is a debug adapter available for the language. This isn't really the right condition. They are actually getting enabled by the Python extension. Have been meaning to investigate a new package.json contribution for a notebook DA. I just wrote an issue for that:https://github.com/microsoft/vscode/issues/132014

Although my proposal still doesn't really help, because the contribution can't be conditionally enabled by a setting. But, that is a temporary situation and not a typical thing to do.


Add Gradle Enterprise API example

Fixes #893
New module samples/gradle-export-api added with Gradle Enterprise example inside.
Test Plan

How do we know the code works?

Proceed with the steps described in the README file.
Checklist

[x] Documented
[x] release_notes.md updated

Thanks! Let's also submit this example to the upstream repo https://github.com/gradle/gradle-enterprise-export-api-samples

Thanks! Let's also submit this example to the upstream repo https://github.com/gradle/gradle-enterprise-export-api-samples

https://github.com/gradle/gradle-enterprise-export-api-samples/pull/10
I've also done some polishing (change Gradle version, @file:JvmName annotation)