Bug: FastjsDom.set writable error

Describe the bug
FastjsDom.set writable error
Expected behavior
Any key are not writable, but they should be writable
Screenshots

Additional context
Add any other context about the problem here.
Version
On version 1.1.1

This bug has been fixed in dev 4b447106c98a8bdce321d1ac5002adde18f7491f , and it will be fixed at release v1.2.0

This problem is still alive.

This problem is alive at v1.2.1


⚠ Bofrost.at has degraded performance

In 16880f9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1065 ms

Resolved: Bofrost.at performance has improved in 9595c61 after 9 minutes.


Failing test: publish__idempotent_publishing__should_publish_a_message_with_implicit_Id_only_once

When run locally with make test_macOS and make test_iOS:
✗ publish__idempotent_publishing__should_publish_a_message_with_implicit_Id_only_once, expected to equal <1>, got <0>
✗ publish__idempotent_publishing__should_publish_a_message_with_implicit_Id_only_once, expected to equal <123>, got <nil> (use beNil() to match nils)

[19:10:57]: ▸   publish__idempotent_publishing__should_publish_a_message_with_implicit_Id_only_once, expected to equal <1>, got <0>
[19:10:57]: ▸   /Users/quintin/code/ably-cocoa/Spec/RestClientChannel.swift:692
[19:10:57]: ▸   ```
[19:10:57]: ▸                             }
[19:10:57]: ▸                             expect(result.items.count) == 1
[19:10:57]: ▸                             expect(result.items.first?.id).to(equal("123"))
[19:10:57]: ▸   ```
[19:10:57]: ▸   publish__idempotent_publishing__should_publish_a_message_with_implicit_Id_only_once, expected to equal <123>, got <nil> (use beNil() to match nils)
[19:10:57]: ▸   /Users/quintin/code/ably-cocoa/Spec/RestClientChannel.swift:693
[19:10:57]: ▸   ```
[19:10:57]: ▸                             expect(result.items.count) == 1
[19:10:57]: ▸                             expect(result.items.first?.id).to(equal("123"))
[19:10:57]: ▸                             done()
[19:10:57]: ▸   ```

┆Issue is synchronized with this Jira Bug by Unito

Closing outdated issue. The codebase changed drastically since then and all skipped tests were unskipped, see PRs for https://github.com/ably/ably-cocoa/issues/1406 and https://github.com/ably/ably-cocoa/issues/1848
If you encounter frequently failing test again, please create a new issue with a best guess why it might be happening.


Follow JWT spec Claim names on jwt.verify options

jwt.verify expects as options:
{ audience: 'urn:foo', issuer: 'urn:issuer', jwtid: 'jwtid', subject: 'subject' }

Which is good for the clarity of the code, but i think that it should also accept the original claim names defined on JWT spec, as:
{ aud: 'urn:foo', iss: 'urn:issuer', jti: 'jwtid', sub: 'subject' }

Suggestion, at index.js:
From:
if (options.audience) {
    var audiences = Array.isArray(options.audience)? options.audience : [options.audience];

    // current code
}

To:
if (options.audience || options.aud) {
    var audience = options.audience || options.aud; // I would also suggest the use of 'let' instead of 'var' inside these blocks
    var audiences = Array.isArray(audience)? audience : [audience];

    // current code
}

Are you open do Pull requests?

They are not the same though. expiresIn accepts a string like 1 day that gets converted to a timestamp, but I would always expect exp to be the raw exp value.

Good @felixfbecker. So the claims passed on using the same key as the spec (e.g. exp) would be treated as is, raw. Leaving the others that can act with some sort of helper with their "associative" names, like expiresIn.

Imo this is would make the API very confusing

@felixfbecker But do you agree that the original spec keys should be accepted?

no, I think it's fine as-is

Closing as stale.


Sync pull_exn hangs indefinitely instead of failing with error if can't auth to github

I have some code like:
module Store = Irmin_unix.Git.FS.KV (Subject.Metadata)
module Sync = Irmin.Sync (Store)

let push_obj (repo: Store.repo) (remote: Irmin.remote) (subject: string) (body: string) =
  (* pull from remote *)
  Store.master repo >>= fun db ->
  print_endline "pull from remote...";
  Sync.pull_exn db remote `Set >>= fun _ ->
  (* init a new feature branch to push to *)
  print_endline "init feature branch...";
  ...

let demo_push remote_uri subject body =
  let* repo = Store.Repo.v get_config in
  let remote = Store.remote remote_uri in
  push_obj repo remote subject body

if I try to pull from a private repo in GitHub using https:// url without username:password@ in it then what I see is:
pull from remote...

...and then it hangs indefinitely.
Obviously, this can't work. But shouldn't pull_exn raise an exception in this case?
(if I put the user/pass in the url then my code runs to completion)

Yes, the bug is well know and the HTTP stack does not handle correctly errors. I will try to fix your bug after vacation (in few weeks).

Thank you for looking, enjoy your vacation! 😄


Remove variants of ModelicaServices and only ship the default version

Reported by dietmarw on 4 Dec 2012 16:45 UTC
We currently have three different variants of ModelicaServices. The problem is that we can never be sure that the tool vendors are actually caring to update also the MA hosted version in trunk.

Migrated-From: https://trac.modelica.org/Modelica/ticket/920

Comment by dietmarw on 4 Dec 2012 16:58 UTC
At the Modelica Design Meeting 77 in Waterloo it was decided to move the default to the "top-level" and remove the other variants.
DONE in 267b9d37f861e97e93da2b219e604cc129f5db06


[FEATURE]: choose file input in tailwind

Description
Need to create code for choose file input as per below image.

The final code should be placed under path tailwind_components/forms with file name as choose_file_input.jsx
The file as to be imported to tailwind_components/forms/collection.js file as per example and added to the formCollections list
Oncling input box, should open the folder to select any file
Post these process, go to components tab (components/forms) in website and check whether the codepen is updated

For PR reference - https://github.com/jsvigneshkanna/tailwind_ui_components/pull/76/files
For any issue while creating / importing the component code file, check below sample files
https://github.com/jsvigneshkanna/tailwind_ui_components/tree/master/tailwind_components/buttons
For icons please refer - https://heroicons.com/
Screenshot of the tailwind component

Are you taking this fetaure implementaion
no

I want to work on this, please assign ! @jsvigneshkanna

Sure @streetcodec
Also check other forms components to be built in issue tab and comment which you are comfortable on

Hi @streetcodec ,
let me know if any help needed on this issue!

Thanks @jsvigneshkanna I have made a PR, please review it!


Please update documentation for support.

Hello!  Could you update whichever is incorrect below, please?
I see on the Troubleshooting page, https://docs.microsoft.com/en-us/azure/azure-functions/start-stop-vms/troubleshoot, under Next Steps:
If you run into problems during deployment, you encounter an issue when using Start/Stop VMs v2 (preview), or if you have a related question, you can submit an issue on GitHub. Filing an Azure support incident from the Azure support site is not available for this preview version.
On the github page, https://github.com/microsoft/startstopv2-deployments#customer-support-contact, you say to open a Support case.
Thank You!

Public doc updated, hence closing this issue.


Copy-DbaDatabase fails - Get-DbaBackupHistory finds Differential backup despite -CopyOnly

Before submitting a bug report:

[x] Ensure you are able to reproduce it on the latest released version (we release often)
[x] Verified this bug is not already reported in an issue
[x] Verified errors are not related to permissions
[x] Can reproduce in a clean PowerShell session (clean = powershell -NoProfile)

Steps to Reproduce
/*
    Any T-SQL commands involved or used to produce test objects/data.
*/

<#
Copy-DbaDatabase -Source mySourceServer -Destination myDestServer -BackupRestore -NetworkShare \\myDestServer\backup -AllDatabases -ExcludeDatabase master,msdb,model,tempdb -ReuseSourceFolderStructure -verbose -force
#>

Copy-DbaDatabase -Source mySourceServer -Destination myDestServer -BackupRestore -NetworkShare \myDestServer\backup -AllDatabases -ExcludeDatabase master,msdb,model,tempdb -ReuseSourceFolderStructure -verbose -force
Expected Behavior
Type     Name                 Status     Notes

Database WTMaps               Successful
Database WTMapsDEV            Successful
Database WTMapsProductionCopy Successful
PLEASE NOTE:
In the Verbose Output below, at 16:25:42, on the failed (first) database, there is this line:
VERBOSE: [16:25:42][Get-DbaBackupHistory] Valid Differential backup
At 16:25:46, on the second successful database, there is this line (and similar for the third successful database):
VERBOSE: [16:25:46][Get-DbaBackupHistory] No Diff found
In actual fact all three of the databases have DIFF backups, but of course this should not matter nor should it be considered since Copy-DbaDatabase is making CopyOnly backups.
This same error happens on Start-DbaMigration, and whether -ReuseSourceFileStructure is used or not (though without that parm the Notes column says ("Failed to restore database").
The databases all share the same simple structure - D:\Data for data files, F::Logs for log files, and that is the default database file locations on the target server.
Actual Behavior
PS C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\dbatools> Copy-DbaDatabase -Source ussql007 -Destination ussqllab120 -BackupRestore -NetworkShare \ussqllab120\backup -AllDatabases -ExcludeDatabase master,msdb,model,tempdb -ReuseSourceFolderStructure -verbose -forc
e
VERBOSE: [16:25:38][Copy-DbaDatabase] Connecting to ussql007
VERBOSE: [16:25:38][Copy-DbaDatabase] Ensuring user databases exist (counting databases).
VERBOSE: [16:25:38][Copy-DbaDatabase] Connecting to ussqllab120
VERBOSE: [16:25:38][Test-DbaSqlPath] Connecting to USSQL007.
VERBOSE: [16:25:38][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:38][Copy-DbaDatabase] Performing SMO version check.
VERBOSE: [16:25:38][Copy-DbaDatabase] Checking to ensure the source isn't the same as the destination.
VERBOSE: [16:25:38][Copy-DbaDatabase] Checking to ensure network path is valid.
VERBOSE: [16:25:38][Copy-DbaDatabase] \ussqllab120\backup share can be accessed.
VERBOSE: [16:25:38][Copy-DbaDatabase] Checking to ensure server is not SQL Server 7 or below.
VERBOSE: [16:25:38][Copy-DbaDatabase] Checking to ensure detach/attach is not attempted on SQL Server 2000.
VERBOSE: [16:25:38][Copy-DbaDatabase] Checking to ensure SQL Server 2000 migration isn't directly attempted to SQL Server 2012.
VERBOSE: [16:25:38][Copy-DbaDatabase] Warning if migration from 2005 to 2012 and above and attach/detach is used.
VERBOSE: [16:25:38][Copy-DbaDatabase] Warning on different collation.
VERBOSE: [16:25:38][Copy-DbaDatabase] Collation on ussql007, SQL_Latin1_General_CP1_CI_AI differs from the ussqllab120, Latin1_General_CI_AI.
VERBOSE: [16:25:38][Copy-DbaDatabase] Ensuring destination server version is equal to or greater than source.
VERBOSE: [16:25:38][Copy-DbaDatabase] Writing warning about filestream being enabled.
VERBOSE: [16:25:38][Copy-DbaDatabase] FILESTREAM enabled on ussql007 but not ussqllab120. Databases that use FILESTREAM will be skipped.
VERBOSE: [16:25:38][Copy-DbaDatabase] Building database list.
VERBOSE: [16:25:38][Copy-DbaDatabase] Performing count.
VERBOSE: [16:25:38][Copy-DbaDatabase] Building file structure inventory for 3 databases.
VERBOSE: [16:25:39][Get-SqlFileStructure] WTMaps
VERBOSE: [16:25:39][Get-SqlFileStructure] WTMapsDEV
VERBOSE: [16:25:39][Get-SqlFileStructure] WTMapsProductionCopy
VERBOSE: [16:25:39][Copy-DbaDatabase]
######### Database: WTMaps #########
VERBOSE: [16:25:39][Copy-DbaDatabase] Checking for accessibility.
VERBOSE: [16:25:39][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:39][Copy-DbaDatabase] Checking Availability Group status.
VERBOSE: [16:25:39][Copy-DbaDatabase] Started: 11/14/2018 16:25:39.
VERBOSE: Performing the operation "Backup WTMaps from ussql007 and restoring" on target "ussqllab120".
VERBOSE: [16:25:39][Backup-DbaDatabase] Connecting to USSQL007
VERBOSE: [16:25:39][Backup-DbaDatabase] 1 database to backup
VERBOSE: [16:25:39][Backup-DbaDatabase] Backup database [WTMaps]
VERBOSE: [16:25:39][Backup-DbaDatabase] Creating full backup
VERBOSE: [16:25:39][Backup-DbaDatabase] Building file name
VERBOSE: [16:25:39][Backup-DbaDatabase] Setting filename
VERBOSE: [16:25:39][Backup-DbaDatabase] Building backup path
VERBOSE: [16:25:39][Test-DbaSqlPath] Connecting to USSQL007.
VERBOSE: [16:25:39][Backup-DbaDatabase] Devices added
VERBOSE: [16:25:42][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Processing WTMaps
VERBOSE: [16:25:42][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:42][Get-DbaBackupHistory] 2 result-groups found.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Processing WTMaps
VERBOSE: [16:25:42][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:42][Get-DbaBackupHistory] 2 result-groups found.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Valid Differential backup
VERBOSE: [16:25:42][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:42][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:42][Get-DbaBackupHistory] 3 result-groups found.
VERBOSE: [16:25:42][Copy-DbaDatabase] Reuse = True.
VERBOSE: [16:25:42][Restore-DbaDatabase] Changing statement timeout to infinity
VERBOSE: [16:25:42][Restore-DbaDatabase] ParameterSet  = Restore
VERBOSE: [16:25:42][Restore-DbaDatabase] Trust Database Backup History Set
VERBOSE: [16:25:42][Restore-DbaDatabase] Processing DatabaseName - WTMaps
VERBOSE: [16:25:42][Select-DbaBackupInformation] Processing Db WTMaps
WARNING: [16:25:42][Copy-DbaDatabase] Failure attempting to restore WTMaps to ussqllab120
VERBOSE: [16:25:42][Copy-DbaDatabase] Failed to restore WTMaps to ussqllab120. You specified -ReuseSourceFolderStructure. Does the exact same destination directory structure exist?
VERBOSE: [16:25:42][Copy-DbaDatabase] Aborting routine for this database.
VERBOSE: [16:25:42][Copy-DbaDatabase]
######### Database: WTMapsDEV #########
VERBOSE: [16:25:42][Copy-DbaDatabase] Checking for accessibility.
VERBOSE: [16:25:42][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:42][Copy-DbaDatabase] Checking Availability Group status.
VERBOSE: Performing the operation "DROP DATABASE WTMapsDEV" on target "ussqllab120".
VERBOSE: [16:25:42][Copy-DbaDatabase] WTMapsDEV already exists. -Force was specified. Dropping WTMapsDEV on ussqllab120.
VERBOSE: [16:25:42][Remove-DbaDatabase] Connecting to USSQLLAB120
VERBOSE: [16:25:43][Copy-DbaDatabase] Started: 11/14/2018 16:25:42.
VERBOSE: Performing the operation "Backup WTMapsDEV from ussql007 and restoring" on target "ussqllab120".
VERBOSE: [16:25:43][Backup-DbaDatabase] Connecting to USSQL007
VERBOSE: [16:25:43][Backup-DbaDatabase] 1 database to backup
VERBOSE: [16:25:43][Backup-DbaDatabase] Backup database [WTMapsDEV]
VERBOSE: [16:25:43][Backup-DbaDatabase] Creating full backup
VERBOSE: [16:25:43][Backup-DbaDatabase] Building file name
VERBOSE: [16:25:43][Backup-DbaDatabase] Setting filename
VERBOSE: [16:25:43][Backup-DbaDatabase] Building backup path
VERBOSE: [16:25:43][Test-DbaSqlPath] Connecting to USSQL007.
VERBOSE: [16:25:43][Backup-DbaDatabase] Devices added
VERBOSE: [16:25:46][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Processing WTMapsDEV
VERBOSE: [16:25:46][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:46][Get-DbaBackupHistory] 3 result-groups found.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Processing WTMapsDEV
VERBOSE: [16:25:46][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:46][Get-DbaBackupHistory] 2 result-groups found.
VERBOSE: [16:25:46][Get-DbaBackupHistory] No Diff found
VERBOSE: [16:25:46][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:46][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:46][Get-DbaBackupHistory] 3 result-groups found.
VERBOSE: [16:25:46][Copy-DbaDatabase] Reuse = True.
VERBOSE: [16:25:46][Restore-DbaDatabase] Changing statement timeout to infinity
VERBOSE: [16:25:46][Restore-DbaDatabase] ParameterSet  = Restore
VERBOSE: [16:25:46][Restore-DbaDatabase] Trust Database Backup History Set
VERBOSE: [16:25:46][Restore-DbaDatabase] Processing DatabaseName - WTMapsDEV
VERBOSE: [16:25:46][Select-DbaBackupInformation] Processing Db WTMapsDEV
VERBOSE: [16:25:46][Select-DbaBackupInformation] Setting LogBaseLSN
VERBOSE: [16:25:46][Format-DbaBackupInformation] Starting
VERBOSE: [16:25:46][Format-DbaBackupInformation] String passed in for DB rename
VERBOSE: [16:25:46][Format-DbaBackupInformation] New DbName (String) = WTMapsDEV
VERBOSE: [16:25:46][Format-DbaBackupInformation]  1 PhysicalName = D:\Data\WTMapsDEV_Data.MDF
VERBOSE: [16:25:46][Format-DbaBackupInformation] PhysicalName = D:\Data\WTMapsDEV_Data.MDF
VERBOSE: [16:25:46][Format-DbaBackupInformation]  1 PhysicalName = F:\Logs\WTMapsDEV_Log.LDF
VERBOSE: [16:25:46][Format-DbaBackupInformation] PhysicalName = F:\Logs\WTMapsDEV_Log.LDF
VERBOSE: [16:25:46][Restore-DbaDatabase] VerifyOnly = False
VERBOSE: [16:25:46][Get-DbaDbPhysicalFile] Connecting to USSQLLAB120
VERBOSE: [16:25:46][Test-DbaBackupInformation] Testing restore for WTMapsDEV
VERBOSE: [16:25:46][Get-DbaDatabase] Connecting to USSQLLAB120.
VERBOSE: [16:25:46][Test-DbaBackupInformation] VerifyOnly = False
VERBOSE: [16:25:46][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:46][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:46][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:46][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:46][Test-DbaLsnChain] Testing LSN Chain
VERBOSE: [16:25:46][Test-DbaLsnChain] Testing LSN Chain - Type Type
VERBOSE: [16:25:46][Test-DbaLsnChain] Passed LSN Chain checks
VERBOSE: [16:25:46][Test-DbaBackupInformation] Marking WTMapsDEV as verified
VERBOSE: [16:25:46][Restore-DbaDatabase] WTMapsDEV passed testing
VERBOSE: [16:25:46][Restore-DbaDatabase] Passing in to restore
VERBOSE: [16:25:46][Invoke-DbaAdvancedRestore] Performing restore action
VERBOSE: [16:25:56][Invoke-DbaAdvancedRestore] Succeeded, Closing Server connection
VERBOSE: [16:25:56][Copy-DbaDatabase] Successfully restored WTMapsDEV to ussqllab120.
VERBOSE: [16:25:56][Copy-DbaDatabase] Deleting \ussqllab120\backup\WTMapsDEV_201811141625-1-of-3.bak.
VERBOSE: [16:25:56][Copy-DbaDatabase] Deleting \ussqllab120\backup\WTMapsDEV_201811141625-2-of-3.bak.
VERBOSE: [16:25:56][Copy-DbaDatabase] Deleting \ussqllab120\backup\WTMapsDEV_201811141625-3-of-3.bak.
VERBOSE: [16:25:56][Copy-DbaDatabase] Updating database owner to sa.
VERBOSE: [16:25:56][Set-DbaDatabaseOwner] Connecting to USSQLLAB120.
VERBOSE: [16:25:56][Set-DbaDatabaseOwner] Updating 1 database(s).
VERBOSE: [16:25:56][Set-DbaDatabaseOwner] Setting database owner for WTMapsDEV to sa on USSQLLAB120.
VERBOSE: Performing the operation "Updating Trustworthy on WTMapsDEV" on target "ussqllab120".
VERBOSE: [16:25:56][Copy-DbaDatabase] Successfully updated Trustworthy to True for WTMapsDEV on ussqllab120
VERBOSE: [16:25:56][Copy-DbaDatabase] Finished: 11/14/2018 16:25:56.
VERBOSE: [16:25:56][Copy-DbaDatabase] Elapsed time: 00:00:13.
VERBOSE: [16:25:56][Copy-DbaDatabase]
######### Database: WTMapsProductionCopy #########
VERBOSE: [16:25:56][Copy-DbaDatabase] Checking for accessibility.
VERBOSE: [16:25:56][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:25:56][Copy-DbaDatabase] Checking Availability Group status.
VERBOSE: Performing the operation "DROP DATABASE WTMapsProductionCopy" on target "ussqllab120".
VERBOSE: [16:25:56][Copy-DbaDatabase] WTMapsProductionCopy already exists. -Force was specified. Dropping WTMapsProductionCopy on ussqllab120.
VERBOSE: [16:25:56][Remove-DbaDatabase] Connecting to USSQLLAB120
VERBOSE: [16:25:56][Copy-DbaDatabase] Started: 11/14/2018 16:25:56.
VERBOSE: Performing the operation "Backup WTMapsProductionCopy from ussql007 and restoring" on target "ussqllab120".
VERBOSE: [16:25:56][Backup-DbaDatabase] Connecting to USSQL007
VERBOSE: [16:25:56][Backup-DbaDatabase] 1 database to backup
VERBOSE: [16:25:56][Backup-DbaDatabase] Backup database [WTMapsProductionCopy]
VERBOSE: [16:25:56][Backup-DbaDatabase] Creating full backup
VERBOSE: [16:25:56][Backup-DbaDatabase] Building file name
VERBOSE: [16:25:56][Backup-DbaDatabase] Setting filename
VERBOSE: [16:25:56][Backup-DbaDatabase] Building backup path
VERBOSE: [16:25:56][Test-DbaSqlPath] Connecting to USSQL007.
VERBOSE: [16:25:56][Backup-DbaDatabase] Devices added
VERBOSE: [16:25:59][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Processing WTMapsProductionCopy
VERBOSE: [16:25:59][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:59][Get-DbaBackupHistory] 3 result-groups found.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Processing WTMapsProductionCopy
VERBOSE: [16:25:59][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:25:59][Get-DbaBackupHistory] 2 result-groups found.
VERBOSE: [16:25:59][Get-DbaBackupHistory] No Diff found
VERBOSE: [16:25:59][Get-DbaBackupHistory] Connecting to USSQL007.
VERBOSE: [16:25:59][Get-DbaBackupHistory] Executing sql query.
VERBOSE: [16:26:00][Get-DbaBackupHistory] Processing as grouped output.
VERBOSE: [16:26:00][Get-DbaBackupHistory] 808 result-groups found.
VERBOSE: [16:26:02][Copy-DbaDatabase] Reuse = True.
VERBOSE: [16:26:02][Restore-DbaDatabase] Changing statement timeout to infinity
VERBOSE: [16:26:02][Restore-DbaDatabase] ParameterSet  = Restore
VERBOSE: [16:26:02][Restore-DbaDatabase] Trust Database Backup History Set
VERBOSE: [16:26:02][Restore-DbaDatabase] Processing DatabaseName - WTMapsProductionCopy
VERBOSE: [16:26:02][Select-DbaBackupInformation] Processing Db WTMapsProductionCopy
VERBOSE: [16:26:02][Select-DbaBackupInformation] Setting LogBaseLSN
VERBOSE: [16:26:02][Format-DbaBackupInformation] Starting
VERBOSE: [16:26:02][Format-DbaBackupInformation] String passed in for DB rename
VERBOSE: [16:26:02][Format-DbaBackupInformation] New DbName (String) = WTMapsProductionCopy
VERBOSE: [16:26:02][Format-DbaBackupInformation]  1 PhysicalName = D:\Data\WTMapsProductionCopy_Data.MDF
VERBOSE: [16:26:02][Format-DbaBackupInformation] PhysicalName = D:\Data\WTMapsProductionCopy_Data.MDF
VERBOSE: [16:26:02][Format-DbaBackupInformation]  1 PhysicalName = F:\Logs\WTMapsProductionCopy_Log.LDF
VERBOSE: [16:26:02][Format-DbaBackupInformation] PhysicalName = F:\Logs\WTMapsProductionCopy_Log.LDF
VERBOSE: [16:26:02][Restore-DbaDatabase] VerifyOnly = False
VERBOSE: [16:26:02][Get-DbaDbPhysicalFile] Connecting to USSQLLAB120
VERBOSE: [16:26:02][Test-DbaBackupInformation] Testing restore for WTMapsProductionCopy
VERBOSE: [16:26:02][Get-DbaDatabase] Connecting to USSQLLAB120.
VERBOSE: [16:26:02][Test-DbaBackupInformation] VerifyOnly = False
VERBOSE: [16:26:02][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:26:02][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:26:02][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:26:02][Test-DbaSqlPath] Connecting to USSQLLAB120.
VERBOSE: [16:26:02][Test-DbaLsnChain] Testing LSN Chain
VERBOSE: [16:26:02][Test-DbaLsnChain] Testing LSN Chain - Type Type
VERBOSE: [16:26:02][Test-DbaLsnChain] Passed LSN Chain checks
VERBOSE: [16:26:02][Test-DbaBackupInformation] Marking WTMapsProductionCopy as verified
VERBOSE: [16:26:02][Restore-DbaDatabase] WTMapsProductionCopy passed testing
VERBOSE: [16:26:02][Restore-DbaDatabase] Passing in to restore
VERBOSE: [16:26:02][Invoke-DbaAdvancedRestore] Performing restore action
VERBOSE: [16:26:14][Invoke-DbaAdvancedRestore] Succeeded, Closing Server connection
VERBOSE: [16:26:14][Copy-DbaDatabase] Successfully restored WTMapsProductionCopy to ussqllab120.
VERBOSE: [16:26:14][Copy-DbaDatabase] Deleting \ussqllab120\backup\WTMapsProductionCopy_201811141625-1-of-3.bak.
VERBOSE: [16:26:14][Copy-DbaDatabase] Deleting \ussqllab120\backup\WTMapsProductionCopy_201811141625-2-of-3.bak.
VERBOSE: [16:26:14][Copy-DbaDatabase] Deleting \ussqllab120\backup\WTMapsProductionCopy_201811141625-3-of-3.bak.
VERBOSE: [16:26:14][Copy-DbaDatabase] Updating database owner to sa.
VERBOSE: [16:26:14][Set-DbaDatabaseOwner] Connecting to USSQLLAB120.
VERBOSE: [16:26:14][Set-DbaDatabaseOwner] Updating 1 database(s).
VERBOSE: [16:26:14][Set-DbaDatabaseOwner] Setting database owner for WTMapsProductionCopy to sa on USSQLLAB120.
VERBOSE: Performing the operation "Updating Trustworthy on WTMapsProductionCopy" on target "ussqllab120".
VERBOSE: [16:26:14][Copy-DbaDatabase] Successfully updated Trustworthy to True for WTMapsProductionCopy on ussqllab120
VERBOSE: [16:26:14][Copy-DbaDatabase] Finished: 11/14/2018 16:26:14.
VERBOSE: [16:26:14][Copy-DbaDatabase] Elapsed time: 00:00:17.
Type     Name                 Status     Notes

Database WTMaps               Failed     Failed to restore. ReuseSourceFolderStructure was specified, verify same directory structure exist on destination.
Database WTMapsDEV            Successful
Database WTMapsProductionCopy Successful
PS C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\dbatools>
Environmental data

PowerShell:
PS C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\dbatools> $Psversiontable

Name                           Value

PSVersion                      5.1.14393.2248
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.2248
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
PS C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\dbatools>

SQL Server:
SourceServer:
Microsoft SQL Server 2014 (SP2-CU3) (KB3204388) - 12.0.5538.0 (X64)
Dec 15 2016 17:52:48
Copyright (c) Microsoft Corporation
Standard Edition (64-bit) on Windows NT 6.3  (Build 9600: ) (Hypervisor)

TargetServer:
Microsoft SQL Server 2017 (RTM) - 14.0.1000.169 (X64)
Aug 22 2017 17:04:49
Copyright (C) 2017 Microsoft Corporation
Developer Edition (64-bit) on Windows Server 2016 Standard 10.0  (Build 14393: ) (Hypervisor)

Thank you for the report. @Stuart-Moore - I could set it to ignore diffs in the wrapper commands but want to make sure there's not an underlying issue.

$CopyOnly wasn't being passed through in the internal call in Get-DbaBackupHistory. It is now.
Fixed in PR #4675

:bananadance: thank you 💯 !

Thanks for updating this.  Has this been released to development zip file or master zip?  I've downloaded both and still have the problem...

Version 0.9.533

Chrissy and Stuart,
I don't think this got fixed.  It should be relatively easy to test.
Create a database, do a full backup then a diff backup on it, then run
Copy-DbaDatabase from that server and using that database to a different
server.  See if it tries to get the diff backup or if it correctly uses the
CopyOnly backup.
Vince
On Thu, Nov 15, 2018 at 5:02 PM Chrissy LeMaire<EMAIL_ADDRESS>wrote:

Thank you for the report. @Stuart-Moore https://github.com/Stuart-Moore

I could set it to ignore diffs in the wrapper commands but want to make
sure there's not an underlying issue.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sqlcollaborative/dbatools/issues/4526#issuecomment-439206345,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ7Ww7TFndMlXTFoKwcODFqHhWQbELoXks5uveRugaJpZM4YerXI
.

OK more detail on this problem, and sorry it is coming in drips and drabs.
Please reopen this bug.
Our database that is failing when using Copy-DbaDatabase has several
recovery chains being pointed out by Get-DbaBackupHistory,  The fork that
it chooses to report upon has IsCopyOnly = False, as it chooses the last
Full backup that was not a CopyOnly (and has a Diff backup after it in the
chain) despite the -IncludeCopyOnly parm.  But, that was not the most
recent full backup according to time, since the -CopyOnly backup that
happened just before (from the Copy-DbaDatabase command) should be the one
being reported on as the -LastFull backup.
What possible solutions exist for this issue?

Change the -LastFull (and -Last etc) logic to use the last by time not
lsn.  However, there is this comment in the code:
# recap for future editors (as this has been discussed over
and over):
#   - original editors (from hereon referred as "we") rank
over backupset.last_lsn desc, backupset.backup_finish_date desc for a good
reason: DST
#     all times are recorded with the timezone of the server
#   - we thought about ranking over backupset.backup_set_id
desc, backupset.last_lsn desc, backupset.backup_finish_date desc
#     but there is no explicit documentation about "when" a
row gets inserted into backupset. Theoretically it could
#     happen that backup_set_id for the same database has not
the same order of last_lsn.
#   - given ultimately to restore something lsn IS the source
of truth, we decided to trust that and only that
#   - we know that sometimes it happens to drop a database
without deleting the history. Assuming then to create a database with the
same name,
#     and given the lsn are composed in the first part by the
VLF SeqID, it happens seldomly that for the same database_name backupset
holds
#     last_lsn out of order. To avoid this behaviour, we
filter by database_guid choosing the guid that has MAX(backup_finish_date),
as we know
#     last_lsn cannot be out-of-order for the same database,
and the same database cannot have different database_guid
So if I understand that correctly, lsn keeps the proper order within a
recovery fork, but the forks themselves are not ordered according to time,
thus the issue.  If there is a way to correctly order the recovery forks by
time, this might be solved.
Have a parm that is distinct from -IncludeCopyOnly, such as
-JustCopyOnly  (-OnlyCopyOnly? :-) ).   I feel the results given with
-IncludeCopyOnly make sense if you want to know about all backups ever, but
not if are focusing exclusively on the CopyOnly backup as Copy-DbaDatabase
wants to do.

Here, notice that the returned results are not from the most recent
backups
PS C:\Windows\system32> Get-DbaBackupHistory -SqlInstance . -Database
WTMaps -IncludeCopyOnly -lastfull | select -first
2 | fl
WARNING: [16:04:42][Get-DbaBackupHistory] Found backups from multiple
recovery forks for WTMaps on NP:., this may
affect your results
WARNING: [16:04:42][Get-DbaBackupHistory] Between 06/18/2017
01:00:03/267000000042700037 and 11/27/2017
16:10:00/299000000367000037  was on Recovery Fork GUID
d88e05ab-7d37-4504-a89c-28629280a50f (69 backups)
WARNING: [16:04:42][Get-DbaBackupHistory] Between 11/27/2017
17:31:39/299000000367000037 and 11/28/2018
11:33:42/494000000088100037  was on Recovery Fork GUID
27c93885-d897-41cc-ad1a-655d0caa588c (467 backups)
WARNING: [16:04:42][Get-DbaBackupHistory] Between 11/08/2015
10:00:29/1897000000619600057 and 11/11/2015
00:05:14/1901000000464300057  was on Recovery Fork GUID
9c8283a8-5fd2-4c49-bbaa-9145e235105f (2 backups)
WARNING: [16:04:42][Get-DbaBackupHistory] Between 10/21/2017
00:05:10/510000002469900037 and 11/27/2017
00:05:20/584000004942600037  was on Recovery Fork GUID
69fa9415-386b-482e-9c8a-a8f53e479c04 (44 backups)
WARNING: [16:04:42][Get-DbaBackupHistory] Between 11/11/2015 13:25:53/0 and
10/20/2017 11:35:58/150000000635000037  was
on Recovery Fork GUID d2f4fa54-63b9-4ac1-9300-d451181da07c (34611 backups)
ComputerName         : (removed)
InstanceName         : MSSQLSERVER
SqlInstance          : (removed)
Database             : WTMaps
UserName             : (removed)
Start                : 11/26/2017 1:00:14 AM
End                  : 11/26/2017 1:00:40 AM
Duration             : 00:00:26
Path                 :
{\USBACK013\SQLFULL3$\USSQL007\WTMaps\FULL\USSQL007_WTMaps_FULL_20171126_010014_1.bak,
\USBACK013\SQLFULL3$\USSQL007\WTMaps\FULL\USSQL007_WTMaps_FULL_20171126_010014_2.bak}
TotalSize            : 678.13 MB
CompressedBackupSize : 451.81 MB
CompressionRatio     : 1.5
Type                 : Full
BackupSetId          : 79093
DeviceType           : Disk
Software             : Microsoft SQL Server
FullName             :
{\USBACK013\SQLFULL3$\USSQL007\WTMaps\FULL\USSQL007_WTMaps_FULL_20171126_010014_1.bak,
\USBACK013\SQLFULL3$\USSQL007\WTMaps\FULL\USSQL007_WTMaps_FULL_20171126_010014_2.bak}
FileList             : {@{FileType=D; LogicalName=WTMaps;
PhysicalName=D:\Data\WTMaps_Data.MDF}, @{FileType=L;
LogicalName=WTMaps_log;
PhysicalName=F:\Logs\WTMaps_Log.LDF}}
Position             : 1
FirstLsn             :<PHONE_NUMBER>42600037
DatabaseBackupLsn    :<PHONE_NUMBER>52000037
CheckpointLsn        :<PHONE_NUMBER>42600037
LastLsn              :<PHONE_NUMBER>44500001
SoftwareVersionMajor : 12
IsCopyOnly           : False
LastRecoveryForkGUID : 69fa9415-386b-482e-9c8a-a8f53e479c04
RecoveryModel        : SIMPLE
On this command, notice that if I limit the results to the last week or
so with -Since, I now find the CopyOnly backup I wanted to see:
PS C:\Windows\system32> Get-DbaBackupHistory -SqlInstance . -Database
WTMaps -IncludeCopyOnly -Since 11/20/2018 -LastFull | select -first 2 | fl
ComputerName         : (removed)
InstanceName         : MSSQLSERVER
SqlInstance          : (removed)
Database             : WTMaps
UserName             : (removed)
Start                : 11/28/2018 11:33:37 AM
End                  : 11/28/2018 11:33:42 AM
Duration             : 00:00:05
Path                 :
{\USSQLLAB120\backup\WTMaps_FULL_COPY_ONLY20181128.bak}
TotalSize            : 348.11 MB
CompressedBackupSize : 228.51 MB
CompressionRatio     : 1.52
Type                 : Full
BackupSetId          : 99313
DeviceType           : Disk
Software             : Microsoft SQL Server
FullName             :
{\USSQLLAB120\backup\WTMaps_FULL_COPY_ONLY20181128.bak}
FileList             : {@{FileType=D; LogicalName=WTMaps;
PhysicalName=D:\Data\WTMaps_Data.MDF}, @{FileType=L;
LogicalName=WTMaps_log;
PhysicalName=F:\Logs\WTMaps_Log.LDF}}
Position             : 1
FirstLsn             :<PHONE_NUMBER>94900001
DatabaseBackupLsn    :<PHONE_NUMBER>88100037
CheckpointLsn        :<PHONE_NUMBER>94900001
LastLsn              :<PHONE_NUMBER>95200001
SoftwareVersionMajor : 12
IsCopyOnly           : True
LastRecoveryForkGUID : 27c93885-d897-41cc-ad1a-655d0caa588c
RecoveryModel        : SIMPLE
On Wed, Nov 28, 2018 at 11:19 AM Vince Iacoboni<EMAIL_ADDRESS>wrote:

Chrissy and Stuart,
I don't think this got fixed.  It should be relatively easy to test.
Create a database, do a full backup then a diff backup on it, then run
Copy-DbaDatabase from that server and using that database to a different
server.  See if it tries to get the diff backup or if it correctly uses the
CopyOnly backup.
Vince
On Thu, Nov 15, 2018 at 5:02 PM Chrissy LeMaire<EMAIL_ADDRESS>wrote:

Thank you for the report. @Stuart-Moore https://github.com/Stuart-Moore

I could set it to ignore diffs in the wrapper commands but want to make
sure there's not an underlying issue.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sqlcollaborative/dbatools/issues/4526#issuecomment-439206345,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ7Ww7TFndMlXTFoKwcODFqHhWQbELoXks5uveRugaJpZM4YerXI
.

Or we could make sure that the current recoveryforkGUID is being passed back into the history function.
PR imminent

Yes even if you record the timestamp before the copy only backup in
Copy-DbaDatabase, then pass that timestamp as the -Since parameter to
Get-DbaDatabase it would ensure you get the most recent.
On Thu, Nov 29, 2018, 9:51 AM Stuart Moore<EMAIL_ADDRESS>wrote:

Or we could make sure that the current recoveryforkGUID is being passed
back into the history function.
PR imminent
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sqlcollaborative/dbatools/issues/4526#issuecomment-442861097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ7Wwx2fW3HR0UCfjQByuFbNuTDz2Wg0ks5uz_R6gaJpZM4YerXI
.

Nope, we've already got the recoveryForkguid so we'll just pass that back in.
If you're doing a restore at the same time as the copy then you'll break it, but you'll it a lot more than just that ;)

Hi Stuart,
Don't mean to rush you, but we are looking at a deploy of hundreds of
servers through Octopus where we would like to use Copy-DbaDatabase.  We
are preparing the install this week.  Any chance you could provide an ETA
on the RecoveryForkGuid fix for Get-DbaBackupHistory?  Thanks and again
don't mean to rush, you guys do this for the good of the community and you
have your own lives and work.  What you do is much appreciated!
Vince
On Thu, Nov 29, 2018 at 10:15 AM Stuart Moore<EMAIL_ADDRESS>wrote:

Nope, we've already got the recoveryForkguid so we'll just pass that back
in.
If you're doing a restore at the same time as the copy then you'll break
it, but you'll it a lot more than just that ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sqlcollaborative/dbatools/issues/4526#issuecomment-442870025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ7Ww131usaUEYjMr4sQupZXi-5GhcFSks5uz_oRgaJpZM4YerXI
.

Sorry, it actually got pushed in a while ago. Can you try with a recent copy of master (or dev branch) please

will close unless it's not fixed, please let us know @sqlslinger and thank you for fixing, @Stuart-Moore !

New year same functions. Just I'll have a look
--
Stuart Moore
On 31 December 2018 at 18:43:31, Chrissy LeMaire (notifications@github.com(mailto:notifications@github.com)) wrote:

will close unless it's not fixed, please let us know @sqlslinger(https://github.com/sqlslinger) and thank you for fixing, @Stuart-Moore(https://github.com/Stuart-Moore) !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(https://github.com/sqlcollaborative/dbatools/issues/4526#issuecomment-450679140), or mute the thread(https://github.com/notifications/unsubscribe-auth/AFWoZoN8YKe62tRWS19yX11elN8LxB4wks5u-lrTgaJpZM4YerXI).


examples/link throws error when logging state

ReferenceError: Can't find variable: convertToRaw is thrown when clicking "Log State" in the link example.

Merged #11 to repair this.


illlegal file names in DBS ?

Hi @yuyiguo
I have found an odd thing chasing some CRAB Publisher issue.
There are jobs which processed this dataset
/EmbeddingRun2017E/ElMuFinalState-inputDoubleMu_94X_miniAOD-v2/USER from phys03
When inserting the outputs in DBS, I get an exception from DBS when looking up the jobs parent file names because those LFN ends with the underscore character _, i.e. calls to DBS API return error with that:
 globalApi.listBlocks(logical_file_name='/store/user/belfo/a/b/c/d.root_')
*** HTTPError: HTTP Error 400: Invalid Input Data /store/use...: Not Match Required Format

while this works (of course this file is not present, so it returns an empty llist)
globalApi.listBlocks(logical_file_name='/store/user/belfo/a/b/c/d.root')
[]

So.. if the underscore at the end is illegal, how coudl those file names enter in DBS to begin with ?
see:
https://cmsweb.cern.ch/das/request?instance=prod/phys03&input=file+dataset%3D%2FEmbeddingRun2017E%2FElMuFinalState-inputDoubleMu_94X_miniAOD-v2%2FUSER
Is this a shortcmoning in WMCore's Lexicon, or some stricter checking in DBS list API ?
In CRAB we always validate user LFN's with Lexicon before attempting to insert in DBS but I can not find clear confirmation that this dataset has been put in phys03 by CRAB, e.g. there is a single block with 15K files and CRAB always has a limit at 100 files per block.

I tried to check if Lexicon would have spotted this, and much to my surprise it accepts the file name with _ at the end. I tried to dig and found this which I can't make sense of, the string candidate ends with underscore but when checked against regexp4 which ends with .root returns True. I am quite puzzled as would have expected this to fail,  but I surely do not know regexps...
>>> from WMCore.Lexicon import check
>>> check(regexp4, candidate)
True
>>> regexp4
'/store/(temp/)*(user|group)/(([a-zA-Z0-9\\.]+)|([a-zA-Z0-9\\-_]+))/([a-zA-Z][a-zA-Z0-9\\-_]*)/(([a-zA-Z0-9\\-_]+)/)+([a-zA-Z0-9\\-_]+).root'
>>> candidate
'/store/user/belfo/a/b/c/d.root_'
>>> check(regexp4, candidate)
True
>>>

In any case, it seems not good that DBS does not allow to lookup information using as search string a file name stored in it.

Probably should be
^/store/(temp/)*(user|group)/(([a-zA-Z0-9\\.]+)|([a-zA-Z0-9\\-_]+))/([a-zA-Z][a-zA-Z0-9\\-_]*)/(([a-zA-Z0-9\\-_]+)/)+([a-zA-Z0-9\\-_]+).root$

i.e. anchor the beginning and end of the string with ^ and $.

sounds right @dan131riley. I doubt the lack of anchors was intentional. What do you think @amaltaro , any  danger in making Lexicon really do what it meant to do ?
@yuyiguo it may not be  optimal that DBS has a LFN format validation independent of Lexicon, and that the check on LFN's used to read is different from the check on LFN's written to the DN. But I do not thing this should be changed right now, OTOH  given that cat is out of the box, can you consider relaxing checks in the server to accept the LFNs which are already in the system ?
Anyhow I am working around this for the time being by skipping insertion of parent LFN when the DBS lookup for them throws an exception.

I totally agree that we should add $ to the end of that regular expression. @belforte please let me know if you want me to take care of it tomorrow or if you will.
Regarding read operations, I did not know that regex checks were enforced there as well. Perhaps it's required to accept some "wildcards" in the user read calls? Otherwise, maybe this is something that we could discuss for the future generation and see whether it can be relaxed indeed.

I was quite busy today and got a lot of unread emails. I don't remember on top of my head that DBS reader and writer use different checks. The only one we use is the Lexicon shared by DMWM. I will check the code.

I checked DBS code, the reader has much relaxed check than the writer because that we introduced the common Lexicon much later than the time CMS data recorded.  DBS reader has to be able to read the old data. Here is what we have in the reader lfn check:
https://github.com/dmwm/DBS/blob/14df8bbe8ee8f874fe423399b18afef911fe78c7/Server/Python/src/dbs/utils/DBSInputValidation.py#L26
The CMS lfn should have the format as define here : https://github.com/dmwm/WMCore/blob/bb573b442a53717057c169b05ae4fae98f31063b/src/python/WMCore/Lexicon.py#L347
However, the Lexicon has a bug that prevents it to enforce the format as it defined.  Dan already pointed out it should anchor the beginning and end of the string with ^ and $.
So it is not a problem with DBS as @belforte thought.  I think that we should fix the Lexicon. I will check the DB to see how many file with the root_.  I am not sure what you want to with these files.

thanks @yuyiguo . I remember that rules for reading had to be more relaxed, that's why I was suprised that some LFNs could be present in DBS yet not usable for reading.
Origin of the problem is understood, but it will be a while until Lexicon is changed and new version of DBS Server deployed with it.
An issue should be open in WMCore for fixing the LExicon, but I suspect it will only happen as part of the larger Lexicon reformatting that @vkuznet is doing. @amaltaro can you follow with @vkuznet on this ?
I suspect there is no solution for the files with bad names. I suggest to leave them as they are. I have now changed CRAB Publisher code so that it skips parent files which can't be found in DBS. And if a user complains that parents have not been recorded, we'll know what to say.

Ok, @belforte .


update warning message for upgrading istio version

To fix https://github.com/istio/istio/issues/28208
Before:
$ istioctl install --set hub=gcr.io/istio-testing -d manifests/
! Istio control planes installed: 1.7.3.
! Use --revision or --force to install Istio.
This will install the Istio 1.8.0 profile into the cluster. Proceed? (y/N)

After:
$ istioctl install --set hub=gcr.io/istio-testing -d manifests/
! Istio control planes installed: 1.7.3.
! An older installed version of Istio has been detected. Running this command will overwrite it.
This will install the Istio 1.9.0 profile into the cluster. Proceed? (y/N)

$ istioctl install --revision=1-9-0 --set hub=gcr.io/istio-testing -d manifests/
! Istio is being upgraded from 1.7.3 -> 1.9.0.
! Before upgrading, you may wish to use 'istioctl analyze' to check for IST0002 deprecation warnings.
This will install the Istio 1.9.0 profile into the cluster. Proceed? (y/N)

$ kubectl get pods -n istio-system
NAME                                    READY   STATUS    RESTARTS   AGE
istio-ingressgateway-5bdb464488-gtp6h   1/1     Running   0          35s
istiod-1-7-3-b5c499b7b-nvfcp            1/1     Running   0          6m54s
istiod-1-9-0-fd59b7bf8-bdq9n            1/1     Running   0          59s

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
5abff47df9baf77695d87cf6bb460b095c79a3d8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Update OWNERS files

What type of PR is this:
/kind tests

What does this PR do / why we need it:
This PR updates the OWNERS list, updating it with the current team members.
Which issue(s) this PR fixes:

Fixes #
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/approve

/lgtm


Improving dbt plugin experience

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3156
Originally created by @pnadolny13 on 2022-01-13 15:41:31

We've talked recently about ways to improve the Meltano dbt plugin experience to make it more appealing vs running a standalone dbt project. Here are some thoughts (not all mine, just summarizing ideas I've heard):

staging job code generation - we know quite a bit about the data being loaded if it was managed by Singer. We could have utilities to generate staging tables as accelerators or templates (meaning user intervention is needed).
source.yml generation - auto configure source yamls
create a higher level dag so we can run a command similar to the + syntax in dbt (dbt run --models +model_name) where all dependencies are also rebuilt but extending into the Singer EL layer.
switching environments - Similar to how in the squared repo we use the environments feature to make it easy to switch between dbt environments. This might already be supported but just needs documentation on how best to use it. Or theres a way to make it even smoother.
Others?

Let me know if this was already summarised somewhere else but I couldnt find an issue.
cc @tayloramurphy @vischous

View 4 previous comments from the original issue on GitLab


Clean up the data portal repo (git history + main branch)

Our data portal git repo is much bigger than it needs to be, to the point where cloning it takes several minutes. This is a problem for GHA and for developers' productivity. To solve this issue, we should:

Make sure that no data is checked in in the repo. This is a bad practice and needs to be discontinued. A good place for storing them is a private S3 bucket. If GHA needs access to this bucket, add it to single-cell-infra/terraform/modules/hosted-cellxgene/iam.tf
Once those huge files have been removed from the main branch, all the other existing branches need to be deleted, since they will have a lot of files.

Note that as a mitigation strategy, it is possible to specify --single-branch when cloning the data portal, but this should only be used as an emergency.

@ebezzi / @atolopko-czi : Close this as a duplicate of #5682 ?


add showResults config key and check it in proposal-options, closes #926

ref: #926

Thanks @fonorobert ! I just changed the configuration key from showResults to alwaysShowTopicResults, to make it more verbose. Also, you where missing the definition of locals: ["config"] on /lib/proposal-options/component.json.

right, thanks @mjlescano


Book 6 Chapter 12 and 13 duplicate instructions

The Practice portion of Chapter 12 is the same as all of Chapter 13

Fixed in commit f4ba282faa8aafa5b7ae71da6b6c37975c8e01e1. Will be merged at end of cohort.


Add before_script, after_script to model for write hooks around the model performing.

Resolve #222, #213

good job thks


array_map a sanitize function fails input sanitization validation

Hello,
I have what I thought must be something you've encountered in the past but after a good day of trying and searching I must admit I don't see any related issues.  Thus if I am mistaken, or better yet, incorrect in my assumptions or usage, please correct me!
We have the following snippet of code which fails with the message 'Detected usage of a non-sanitized input variable $_POST (WordPress.VIP.ValidatedSanitizedInput.InputNotSanitized)'  The line it is flagging is where we do the array_map to apply the sanitize_text_field function to each element of the $_POST['topic_order'] array.
The code itself looks like the following:
/**
 * Update each topic with a proper 'order'
 * @return [type] [description]
 */
public function sort_topics_callback() {
	if ( isset( $_POST['topic_order'] ) ) {
		$topic_order = array_map( 'sanitize_text_field', $_POST['topic_order'] ); // input var ok
		for ( $i = 0; $i < count( $topic_order ); $i++ ) {
			$id_parts = split( '-', $topic_order[ $i ] );
			$id = intval( $id_parts[1] );
			$new_term_group = $i + 1;

			wp_update_term( $id, 'smrt-topic', array( 'term_group' => $new_term_group ) );
		}
	}

	die();
}

Hi @mehtryx,
This actually has been mentioned before: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/294#issuecomment-68529542. That PR provides for whitelisting (and actually needs to be rewritten after #334), but it doesn't actually address array_map().

Thanks, sorry for the duplicate then. Close this at your discretion and I'll keep eyes out for those others.

Thanks, sorry for the duplicate then. Close this at your discretion and I'll keep eyes out for those others.

Let's leave this open until support for array_map() is implemented, since it didn't have its own ticket yet.


Partitioned DML over 30s always fails by context deadline exceeded

Partitioned DML over 30s always fails by context deadline exceeded.
$ time ./spanner-cli -p ${CLOUDSDK_CORE_PROJECT} -i ${CLOUDSDK_SPANNER_INSTANCE} -d ${DATABASE_ID} --execute='PARTITIONED UPDATE Songs SET Duration = Duration + 1 WHERE TRUE'
ERROR: rpc error: code = DeadlineExceeded desc = context deadline exceeded
./spanner-cli -p ${CLOUDSDK_CORE_PROJECT} -i ${CLOUDSDK_SPANNER_INSTANCE} -d   0.35s user 0.47s system 2% cpu 34.068 total

gcloud databases execute-sql succeeds.
$ time gcloud spanner databases execute-sql --instance=merpay-sponsored-instance ${DATABASE_ID} --sql='UPDATE Songs SET Duration = Duration + 1 WHERE TRUE' --enable-partitioned-dml
Statement modified a lower bound of 1024000 rows
gcloud spanner databases execute-sql --instance=merpay-sponsored-instance     0.55s user 0.22s system 1% cpu 1:10.73 total

Thanks for filing an issue. Let me check if this happens on my side as well.

Thanks for filing an issue. Let me check if this happens on my side as well.

I found the reason why this happens.

spanner-cli calls google-cloud-go/spanner's PartitionedUpdate function: statement.go
PartitionUpdate function internally calls spanner.Client.ExecuteSql function: pdml.go
spanner.Client.ExecuteSql set timeout with 30 seconds if the context doesn't have any timeout: spanner_client.go

So basically we have to set longer timeout explicitly to run PDML for over 30 secs. I will create a PR to fix that.

I found the reason why this happens.

spanner-cli calls google-cloud-go/spanner's PartitionedUpdate function: statement.go
PartitionUpdate function internally calls spanner.Client.ExecuteSql function: pdml.go
spanner.Client.ExecuteSql set timeout with 30 seconds if the context doesn't have any timeout: spanner_client.go

So basically we have to set longer timeout explicitly to run PDML for over 30 secs. I will create a PR to fix that.


Lbryum difficulty retarget algorithm seems to be wrong

Lbryum difficulty retarget algorithm is wrong and should be fixed: https://github.com/lbryio/lbryum/blob/master/lbryum/blockchain.py#L22

@kaykurokawa  please confirm if this is still valid or close

Fix looks good in torba, closing


Remove pyfits depency

Installing on a new machine illustrates how very abandoned this package is. It should be trivial to replace with astropy (yes that's me volunteering)

Great! It is not such a totally trivial change though. astropy.fits and pyfits have some subtle differences (assuming you're considering one of the latest astropy versions, which you should). Fortunately, those differences mostly matter when creating new FITS files, which STUI does not do.


How to optimize to another color?

I dont understand logic of your color check function. I wanna optimize this for rgb(210,67,34). Can you explain me?please:)

I can give you an example like this
enemy_red: int = 210
enemy_green: int = 67
enemy_blue: int = 34
tolerance: int = 15

def color_check(red: int, green: int, blue: int) -> bool:
    return (enemy_red - tolerance < red < enemy_red + tolerance) and (enemy_green - tolerance < green < enemy_green + tolerance) and (enemy_blue - tolerance < blue < enemy_blue + tolerance)

Ok, it work and now i understand this logic.
But second question is: Is this code work only with window-mode?
First versions is working with full-window mode.

You must use the full screen windowed mode to capture images from the game, but if it works,
use full screen.

I'm a complete noob I have an arduino Leonardo and have no clue what I am doing. Can you break it down more for me please. Thank you!


chore: Release 0.1.2

Waiting on https://github.com/firebase/firebase-functions-python/pull/152. We should have a new release this week.


ENSWEB-6845 Use contigviewbottom configs to save regulation configs

Description
https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-6845

Remove track image component from regulation views
When saving configs in regulation view, update location view config so that the tracks can be seen in location view.
Remove Feature context and Details by cell types pages

Views affected
Regulation

@jyothishnt Can you add the sandbox link here to test this?


Add Typhoon to Kubernetes AWS installation docs

Description
Add Typhoon to Kubernetes AWS installation docs. Typhoon provides minimal and free Kubernetes clusters via Terraform module. It supports AWS (new), bare-metal, GCE, and Digital Ocean with flannel or Calico. Calico is the default on AWS, bare-metal, and GCE.
Rough performance stats for the curious.
cc @emanic
related: #1089

LGTM, thanks @dghubble


random logouts & TokenMismatch using memcached cluster on AWS

Production site is kicking users back to login seemingly randomly - almost always correlating to a TokenMismatch.
I have added logging to track the URI being requested and the user requesting. Interestingly I can see that for some unknown reason the user transitions to "Guest" ie !Auth::user() just prior to hitting a protected route.
Does NOT occur using the file driver. But this is no use to me with two active front end servers.
Laravel 5.1 - two EC2 instances in parallel
memcached (AWS cluster)
php 5.5.25
centos/whm
I have config:cache's and session domain set.
Typical flow is page GET, with an AJAX call to check for new messages on a getstream.io queue, with EACH page refresh. Each page refresh also subscribes to push notifications from getstream.io
At this stage we have to shut down our second front end EC2 instance and run in production on only one server using the file driver.
What am I doing wrong?

Which driver are you using?

This issue has come up many times before.
A good work around in my experience is to use the redis driver for sessions, and actually save the session data before sending the response rather than after sending the response like Laravel does out of the box.

You'll need to extend laravel's start session middleware to do that.

ok, will look to it

thanks

I'm ok with switching to Redis from memcached- in your experience is it ok to use Redis for both sessions and cache or do I need to split these?

It's fine. You can actually have multiple redis databases on one redis instance. Just add another redis connection in your database config and get the sessions to use database 1 instead of database 0.

Then make sure you set the database key in the session config to use the name you gave this new connection in your database config,

Thanks again graham :)

@GrahamCampbell
A good work around in my experience is to use the redis driver for sessions, and actually save the session data before sending the response rather than after sending the response like Laravel does out of the box.
So can we make this the default behaviour in Laravel then? We know there are many many other people with this issue?
Or at least put this on the Docs as an alternative way - so it is documented for all to see?

I'm having similar issues after I started using the redis session driver. I don't get any TokenMismatch but a random logout.
Not 100% reproducible but most of the time: login in two browsers/computers with the same user, make an ajax POST request, refresh both and one of them gets logged out

Hi there, we have same issue on AWS EC2 PHP 5.5.9-1ubuntu4.16 and AWS elastic cache cluster with sessions expiring in randomly very very often (1-2 of 5 requests).
Does it means that laravel does not support AWS elastic-cache memcache cluster?
Is there another approach than moving from memcache to redis?
Thanks


♻ Move generic hashing and storage utilities from lamindb into lamindb-setup

https://github.com/laminlabs/lamindb/pull/1476
https://www.notion.so/laminlabs/Monitor-hosted-storage-usage-enable-safe-deletes-4afbd336989c4f578fc8fab2194328eb

Could you cross-link this with the work package?

Could you cross-link this with the work package?

Done!


[E2E] [Picture] Update the picture

As the original images were in Chinese, now the English version has been added.

It is ready to go now? @QuakeWang


[SPARK-43539][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_0003

What changes were proposed in this pull request?
The pr aims to assign a name to the error class _LEGACY_ERROR_TEMP_0003.
Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.

@panbingkun Could you wrap op by toSQLStmt() at:
https://github.com/apache/spark/blob/abc140263303c409f8d4b9632645c5c6cbc11d20/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala#L46

This is done.

+1, LGTM. Merging to master.
Thank you, @panbingkun.


No way to catch error/exception

Using the same example in #92 - but using a Ubuntu-14 template (as opposed to Ubuntu-20) getting an error that I can't trap
However the VMs are created - but there's no way to capture the error/exception and handle the IP address lookup myself.
Do you want to perform this update? yes
Updating (testing):
     Type                             Name              Status                  Info
     pulumi:pulumi:Stack              XXXX-testing  **failed**              1 error
 ~   ├─ vsphere:index:VirtualMachine  rmo-su-1          **updating failed**     [diff: ~vapp];
 ~   ├─ vsphere:index:VirtualMachine  rmo-cc-1          **updating failed**     [diff: ~vapp];

Diagnostics:
  pulumi:pulumi:Stack (labminds-testing):
    error: update failed

  vsphere:index:VirtualMachine (rmo-su-1):
    error: 1 error occurred:
    	* updating urn:pulumi:testing::XXXX::vsphere:index/virtualMachine:VirtualMachine::rmo-su-1: timeout waiting for an available IP address

If this is due to a get then I think this is the same as https://github.com/pulumi/pulumi/issues/3364

Unfortunately, it looks like this issue hasn't seen any updates in a while. If you're still encountering this problem, could you leave a quick comment to let us know so we can prioritize it? (Commenting will bump it back into our triage queue.)


Added my name(Ijeoma Onwuka) to CONTRIBUTORS.md

This is my first pull request. I hope to create more in the future.

Thanks for the contribution @Belindamag! Claim your rewards now!


Add NavCash to navcoin.org wallets

Description
Adds NavCash to the list of wallets in navcoin.org
Issues Resolved
Preview Links
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/en/wallets
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/es/wallets
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/it/wallets
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/jp/wallets
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/kr/wallets
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/ru/wallets
https://5eefcf272dfdf500072ca88d--navcoin.netlify.app/zh/wallets
Checklist

[ ] Have you assigned/claimed the issues you've resolved in this pull request?
[ ] Have the issues been moved to the QA column of the NavCoin Websites project?
[ ] Have you checked there are no merge conflicts?
[ ] Have you tested the changes work across both mobile and desktop?

@aguycalled seems that .es.md is using wrong logo.
Also, should the core wallet logo be updated on these pages?


Fixed subquery reponse for staking dashboard

#8693rgnfq

Task linked: CU-8693rgnfq Android. Not loading staking dashboard for not staking proxied


Schedule Name Default to newest viewable schedule quarter

The Default name for the schedule should be a current or upcoming quarter

For example:

When May 6, the default schedule name should be 23' Fall
Nov 4 --> 24' Winter
Feb 10 --> 24' Spring


Wrong file names in chamberconnectlibrary-2.0.2.tar.gz on https://pypi.python.org

In chamberconnectlibrary-2.0.2.tar.gz from https://pypi.python.org files are named in CamelCase style: WatlowF4T.py, P300.py, EspecInteract.py
Because of that, there are some import errors, for example in espec.py:
from chamberconnectlibrary.p300 import P300
...
from chamberconnectlibrary.especinteract import EspecError

In repo on github these files have correct names.
Please repack tar.gz and upload it on https://pypi.python.org

It should be fixed with version 2.1.4

@MylesMetzler , thanks for answer. When are you going to release the next version?

I released it just prior to closing this issue: https://pypi.python.org/pypi/chamberconnectlibrary
When I was checking it I did have to clear pip's cache to get it to install the new version.


Thread Safety

Hi,
Just wondering if FullSerializer is thread safe?
Im trying to do serialization/deserialization on threads on a project on Android and iOS but its not working for me on Android, whereas when i disable threading, it works perfectly.
There seems to be a few static dictionarys in places which means, even if i create 2 instances of the parser, it would not be thread safe, i guess?
Thanks.

Thanks, I've added some locking.
FS should be fully thread safe on a per-serializer level. So each thread needs to have it's own fsSerializer instance.


MathJax doesn't render higher order roots

I'm not sure if I this is specific to IJulia or more generally Jupyter or MathJax but when the HTML-CSS renderer tries to display a cube root, for example, the output is simply: \root{3}{x} with no pretty printing.

I don't think this is IJulia specific.   See e.g. ipython/ipython#1359 ... but it looks like \sqrt[3]{x} (which is the standard LaTeX syntax for this) works


provide option to format bibsonomy refs with citation style

currently, the bibsonomy endpoints return json, which is fine. it would be cool to have the option to retrieve the references as preformatted html, following one of supported citation styles

Would be cool. https://de.wikipedia.org/wiki/Citation_Style_Language would be a natural candidate for formats that are available and implemented for other sources. Zotero, which I presume is also supported by APIS, plays nicely w/ CSL.

yes, we already decided to implement CSL and allow to set the style used somewhere in the settings.
Just to remember: https://github.com/brechtm/citeproc-py


Inconsistent behavior in updating bitmap sprite

Hello, I am using generated bitmap data as sprite in my plugin. I am modifying the data and want to update sprite. In Chromium/ubuntu14.04, Firefox/win7 and IE/win7 sprite is updated automatically. Only in chrome(v42)/win7 I have to workaround it by destroying sprite and creating new one instead. I was trying bitmapdata.update() method, but it didnt help. Chrome does not throw any error.
Live DEMO of the problem is on plugin page here.
Second island with debug = true should react on user clicks and draw additional info. Try it in chrome/win and other browser.
I am using this method to add aditional info into map:
Phaser.Plugin.Island.prototype.renderSite = function(index) {
    var cell = this.diagram.cells[index],
        he = cell.halfedges,
        ctx = this.debugLayer.ctx, // debugLayer is Phaser.BitmapData object
        point;

      ctx.font="8px";
      ctx.fillStyle = '#ff0';

      ctx.beginPath();
      ctx.arc(cell.site.x,cell.site.y,2,0,2*Math.PI);
      ctx.fill();

      for (var i = 0; i < he.length; i++) {
        ctx.fillStyle = '#ff0';
        point = he[i].edge.lSite;
        ctx.fillText('L'+i,point.x-8,point.y-8);
        point = he[i].edge.rSite;
        if(point){
            ctx.fillText('R'+i,point.x+8,point.y+8);
        }

        ctx.fillStyle = '#0f0';
        point = he[i].getEndpoint();
        ctx.beginPath();
        ctx.arc(point.x,point.y,1,0,2*Math.PI);
        ctx.fill();
        ctx.fillText('E'+i,point.x-8,point.y-8);
        point = he[i].getStartpoint();
        ctx.beginPath();
        ctx.arc(point.x,point.y,1,0,2*Math.PI);
        ctx.fill();
        ctx.fillText('S'+i,point.x+8,point.y+8);
      }
};

It is probably bug in chrome, but how should I describe it to google?
Thanks for any hints

Does this still happen in modern versions of Chrome? If yes, then I'd wager it's a bug in the code. If not, I can close this.

Yes it is still the issue, I have also updated Phaser to 2.4.4 and it didn't help. Test on Firefox = OK. Test on Chrome = NOT-OK.

I need a test case really, I can't debug the whole thing. Surely it must boil down to something quite specific?

Ok.. I will try to extract it tomorrow
On Feb 4, 2016 10:58 PM, "Richard Davey"<EMAIL_ADDRESS>wrote:

I need a test case really, I can't debug the whole thing. Surely it must
boil down to something quite specific?
—
Reply to this email directly or view it on GitHub
https://github.com/photonstorm/phaser/issues/1883#issuecomment-180069510
.

Here is the problem: Sprite is not redrawn on bitmapdata update, so I have to destroy sprite and recreate it with updated bitmadata, but just in Chrome. In Firefox it works correctly. Check this fiddle.
I have also find out that Sprite.events seems not to be working if sprite is created from bitmap data, look at this fiddle.

Your first fiddle doesn't work because you're never telling the BitmapData to update its WebGL texture. You can't just modify the underlying context directly and expect that to be reflected in WebGl, it needs to know to create a new texture from it and re-apply it to the Sprite. Do that by setting the 'dirty' flag and then calling render:
        bmd.dirty = true;
        bmd.render();

And in the 2nd fiddle your sprite events don't work because you've not enabled the sprite for input. Add this: sprite.inputEnabled = true; and it works just fine.
Going to close this off as neither are actual issues with Phaser.


error when parsing empty files

BUG-issue
Description
Parsing empty files results in a segmentation-fault and has to be handled before parsing.

Description
add error for the case of an empty file while parsing
How it was tested?

manually test with SakuraTree


The Cutter argument overlap causes an error for any value other than  the default of none.

Setting an overlap value for Ginsu.split_doc() threw the error AttributeError: 'Ginsu' object has no attribute 'split_overlap' on line 46 of cutter.__init__.py
Setting an overlap value for Machete.split() threw the error UnboundLocalError: local variable 'segments' referenced before assignment on line 514 of cutter.__init__.py
I have not attempted to set an overlap value on any other cutter functions.

Cutter has now been refactored, which should have fixed the remaining bugs. Any further problems should be dealt with in another issue.


🐞 Bug:  No gap between the navbar and the title text Terms of Service.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
There is no gap between the navbar and the title text Terms of Service. In Term of Service page.
Steps To Reproduce

Go to the 'About page'.
Click on 'Term of Service'.

Expected Behavior
There should be a gap between the navbar and the title text Terms of Service. In Term of Service page.
Screenshots

Device Information [optional]
No response
Additional context
No response
Are you working on this issue?
No

@subhamkumarr, @tanmoysrt Can I work on this issue?

@Pradipram Yes, you can take it.

Hi, @subhamkumarr , @Pradipram  this issue raised previously #4550
Also while making PR follow the contribution guidelines without maintainers approval if your raise the PR your work will be vain attemt.
cc: @tanmoysrt

@Malavi1 Are you not facing that issue even though this PR https://github.com/CircuitVerse/CircuitVerse/issues/4550 got merged?

@Malavi1 #4550 is closed, but the issue still exists. And since the issue is closed, that way, @subhamkumarr cannot find that this issue already exists.

@Malavi1 #4550 is closed, but the issue still exists. And since the issue is closed, that way, @subhamkumarr cannot find that this issue already exists.

You should check locally. The production website is not always up-to-date.

@tanmoysrt, I can see the same issue locally also.

I will check, If issue persists, I will re-open

@tanmoysrt, I can see the same issue locally also.

I will check, If issue persists, I will re-open

Sorry, I have checked locally the issue was already resolved.


@azure/core-http is deprecated, and not reflected in this doc

Type of issue
Outdated article
Description
I was looking for http guidelines for javascript and found this article https://learn.microsoft.com/en-us/javascript/api/overview/azure/core-http-readme?view=azure-node-latest
however per npmjs, https://www.npmjs.com/package/@azure/core-http the mentioned package is deprecated, I was expecting the official ref-docs to reflect on deprecated libraries.
Page URL
https://learn.microsoft.com/en-us/javascript/api/overview/azure/core-http-readme?view=azure-node-latest
Content source URL
https://github.com/MicrosoftDocs/azure-docs-sdk-node/blob/main/docs-ref-services/latest/core-http-readme.md
Document Version Independent Id
f1aad07d-e09e-0e94-3507-d814dee558ba
Article author
@azure-sdk
Metadata

ID: b4cc2fcb-6e32-9089-ba65-0c242ca38a96
Service: core

This has been addressed.


Performance optimizations (14% for hello world L5 app)

Optimizations for improve performance for 14.3%
Detailed description https://github.com/neomerx/rhw-l5#researching-laravel-5-framework

This looks really nice. Thank you!

Really impressive, @neomerx :beer:

+1

Thank you very much for taking the time to look into this. Will look it over in more detail tonight.

:+1:

:100:

Wow, very nice. If those numbers are consistent then that is very impressive!

really nice

:+1: Always a fan of optimization.

+1 Appreciate that you took time out to do this.

I'm a definitely +1 to all performance optimizations but find the title really misleading. It gives the impression your Laravel application will be +14% faster which is not the case in real world. We're talking about a total of 5ms difference between all the commits, something probably completely inconceivable in real world usage.

Yeah, Gary is right, it's not even fresh L5 install.
I bet that Eloquent is the slowest part of the framework in an average app.
Still impressive

@garygreen Take a look at https://github.com/kenjis/php-framework-benchmark#hello-world-benchmark
What you call 'inconceivable' milliseconds is actually difference between 'good' and 'terribly slow' for php public opinion

@neomerx So how many requests per second does Laravel go up by in that chart, with these commits?

Just to clarify, I have zero issue with this PR at all, welcome any performance improvements. The only thing is the commit names/title of this PR being misleading to others, looking through the commit history in Laravel. "Improve performance of default Laravel application for 4.3%" Those are pretty sweeping statements that are very misleading out of context when you look at the numbers.

@garygreen feel free to make your pull request for contributors' naming guidelines which not invulnerable for critics by itself

This reintroduces the buggy #8135, see also #8210.

@JoostK I've downloaded fresh L5 app, applied the patch and before and after I got this
neomerx@L5:~/bug-fix/laravel$ php artisan event:generate
Events and handlers generated successfully!

Where is the bug?

@JoostK my patch and  #8135 have different implementations. Please either support your statement that    #8239 is buggy or remove it.

So how many requests per second does Laravel go up by in that chart, with these commits?

That list is totally wrong anyway. Laravel does like 500 if you turn on route caching and config caching, and you strip out the middelwares.

@GrahamCampbell Moreover I have a feeling that due to their kernel settings you will have different result if just change test order in https://github.com/kenjis/php-framework-benchmark/blob/master/benchmarks/hello_world.sh

+1

@neomerx please see the test added in #8210, which will show why abcf531890a31be32edc81a4ba2e45fcf2d46897 won't work.  I also fell into the same trap.

@GrahamCampbell out of interest how do you get 500 requests per second with Laravel? I can't get close to that amount, even with base L5 install and route, config, compiled optimisations?  I'm getting 40 rqs p/s.

@garygreen Disable all the middlewares, use apply all the optimisations, and change opcache to cache large files too. That should make a difference because the compiled.php file won't get cached by default because it's too large.

Ohh thanks! That's interesting to know about opcode cache. When you say disable all middlewares, isn't that a critical part / flow in your app or am I misunderstanding what you mean by that?

When you say disable all middlewares, isn't that a critical part / flow in your app or am I misunderstanding what you mean by that?

Well, it makes a more fair comparison between the other frameworks.

Interesting, opcache by default caches all files regardless of size opcache.max_file_size. Still even with middleswares disabled and opcache I can't get anywhere close to 500 rq/s. You must have some magical setup or something ;D

Also, why should we disable all middlewares?

@toddbc Thanks for good point that I missed support for searching by interface supported by provider.
It looks it is not used by the framework itself and I didn't have any issues neither with tests nor with event:generate. However for backward compatibility I've added such support and it doesn't effect performance.
I've also added slightly modified version of your test to a separate commit and leave it up to @taylorotwell which test version to commit. Anyway copyright is yours )

@GrahamCampbell @garygreen From my experience the environment has a huge impact on performance behavior

on real hardware I had better performance improvement (in %) than on virtualized. Possibly virtual network, memory and etc has its own limitations
kernel settings have big impact on performance
php settings has also significant effect on performance

From default LAMP L5 Hello World 75 RPS to 500 RPS on the same hardware? Ez. Drop unnecessary middleware, apply all L5 buit-in optimization, NGINX, HHVM, kernel setup. What if PHP but not HHVM? Well, that wouldn't easy but looks achievable on non-virtual infrastructure and careful PHP settings.

Maybe Graham was talking about HHVM. I'm testing on standard PHP. What PHP settings do you recommend to tweak specifically?

@garygreen I've did such testing some time ago and changed settings in /etc/php5/fpm/pool.d/www.conf.  Sadly I've lost that settings but as I remember it's only a few parameters that start with 'pm.'

It's going to be dependent on your machine. I get 400-500 with everything
optimized and sessions disabled.
On Saturday, April 4, 2015, Gary Green<EMAIL_ADDRESS>wrote:

@GrahamCampbell https://github.com/GrahamCampbell out of interest how
do you get 500 requests per second with Laravel? I can't get close to that
amount, even with base L5 install and route, config, compiled
optimisations? I'm getting 40 rqs p/s.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/8239#issuecomment-89585555.

@neomerx, I took a look at 29d5f863a19add2160a0365b3da8363d82ab11fc.  I'll just note that the common case for getProvider is looking up a provider that doesn't exist yet (on initial registration.)  It's barely called otherwise iirc.  This means it will always hit the foreach, since it will ultimately return null.
So, with n providers, it would end up doing (n * (n - 1)) / 2 instanceof comparisons.  There's probably some breaking point where using class_parents($class) + class_implements($class) only n times will be faster, though would have to benchmark to see it.  Did a quick comparison since I was interested, suggests the breakoff might be around ~9 providers.  But I didn't test carefully, just saw that $x = $y instanceof z takes about 23% as long as $x = class_parents('y') + class_implements('y') + array('y').
Strange that you didn't have problems with event:generate, though.  You're sure you're testing with a clean setup?
This line creates the provider:
https://github.com/laravel/framework/blob/614d08023f6e87cd535f38f875ba06c24e9c842f/src/Illuminate/Foundation/Console/EventGenerateCommand.php#L28
But normally this is an app-specific subclass:
https://github.com/laravel/laravel/blob/6449472ef7c7899785fb05bbed8eb7f5c3a08395/config/app.php#L145
I'm sure you might've nixed that unnecessary subclass for performance if you're not using events in that way, but in a default setup you would experience the problem.

@toddbc Yep, it's always returns null. For default application it's invoked 21 times and I think for typical application it would be somewhere in between 20-25 providers. It shouldn't work like this IMHO. Thus I tend to think it's better to refactor it and ask architect @taylorotwell for it/advise.
So it looks we don't have any open questions with this PR anymore and it could be merged, right?
Here is the list of all invoked providers

getProvider Illuminate\Events\EventServiceProvider hit null
getProvider Illuminate\Routing\RoutingServiceProvider hit null
getProvider Illuminate\Auth\AuthServiceProvider hit null
getProvider Illuminate\Routing\ControllerServiceProvider hit null
getProvider Illuminate\Cookie\CookieServiceProvider hit null
getProvider Illuminate\Database\DatabaseServiceProvider hit null
getProvider Illuminate\Encryption\EncryptionServiceProvider hit null
getProvider Illuminate\Filesystem\FilesystemServiceProvider hit null
getProvider Illuminate\Foundation\Providers\FoundationServiceProvider hit null
getProvider Illuminate\Foundation\Providers\FormRequestServiceProvider hit null
getProvider Illuminate\Pagination\PaginationServiceProvider hit null
getProvider Illuminate\Session\SessionServiceProvider hit null
getProvider Illuminate\Validation\ValidationServiceProvider hit null
getProvider Illuminate\View\ViewServiceProvider hit null
getProvider App\Providers\AppServiceProvider hit null
getProvider App\Providers\BusServiceProvider hit null
getProvider App\Providers\ConfigServiceProvider hit null
getProvider App\Providers\EventServiceProvider hit null
getProvider App\Providers\RouteServiceProvider hit null
getProvider Illuminate\Bus\BusServiceProvider hit null
getProvider Illuminate\Hashing\HashServiceProvider hit null

:+1: Sweet.

This needs rebasing and squashing to one commit please.

I just tried this out and I don't see a 14% change. Using the config/route caching I see a change of only 3.7%.

@GrahamCampbell The methodology, used performance tools and the performance test results in the description. If you have found any errors there please be specific.

@GrahamCampbell as I've been mentioning... the title is misleading. If you look at the figures, it's not 14% at all. On average it's 4% and with that 4% is just a few milliseconds difference ;-)

I think it's a shame to close this.  Whether the optimizations amount to 4% of 14%, that's still an improvement.  So long as it doesn't reduce code quality free speed is always nice.
I'll say again that tests can benefit from a lot of these optimizations most, and I hate wasting time on tests.  Not only can tests not benefit from cached routes and etc. (well, I made route/config cache filenames include the environment name to improve this in my own build), but often they are testing small things, so the overall setup is accentuated.
More requests per second is nice, but even if that's small, I'll take a 4% reduction in test time any day.  I'm more than impatient enough to be happy to see my code works properly 2 seconds earlier.
Just IMHO.

I agree with @toddbc

Why is this closed?

It was a certainly worth investigating. We're very grateful for the time you spent on this.

Are you planning to resubmit? I was just a little confused by the performance claims.

I agree with everyone who says it needs further investigation and shouldn't be closed. The sheer attempt by the author to do such research shows how valuable the overall work and time put into it, are. I would love to see any percentage of performance: 1% translating to meer milliseconds in small setup can mean the same 1% in dozens, if not hundreds of those milliseconds. We should start somewhere, today with this 4% boost, tomorrow another 4% and at the end of the day we will have much better performing framework.

+1 open

@shehi Agreed. The author closed it though. Hopefully @neomerx is resubmitting because it needed some rebasing and stuff like that.

I really like the work @neomerx has done here. Hope this gets resubmitted.


Support for 3.5 SRD system

If you are already supporting pf1, then supporting the 3.5 SRD system might be low-hanging-fruit as it started off as a fork of pf1.

73a7c214bf0ac448973417bf44c7c91b9a20125e

Added in v1.1.0


Repo migration to ExpediaGroup

Description
As per the migration from the HotelDotCom repository to the ExpediaGroup one, all the references have been updated

@worldtiki the Travis integration is not working, could you please enable it?  You can do it from here: https://travis-ci.com/account/repositories


Update hydra-core

@CharlesAuthier I understand now why you opened 2 PRs, one for develop and one for the 222 branch. In the future, if changes can be integrated in develop directly (it's the case for this PR), then I'll take care of merging the updated develop into 222. No need to double the efforts.


Optional starting line number

Would it be possible to have an optional starting line number? You mentioned adding a ln:false/ln:true option. I would propose extending this syntax to also allow ln:x where x is a number which is the starting line number. Ideally this would be restricted to positive integers.
Note highlights should refer to the line number as rendered, not the true line number. I.e. a codeblock with ln:901 highlighting the fifth line should have hl:905, not hl:5.

ln is either true or false. It would make no sense to be able to set a number for this parameter. I can create a parameter offset where you could set the offset. Why would this have to be restricted to positive numbers? Why should highlights refer to the rendered numbered? It would not make much sense for me. If you have set offset to 140 and you have 200 lines of code, then you'd have to count which line is it you want highlight. It would be easier to just look at the line number and set that one, or not?

In absence of my original ln suggestion, an offset parameter would be brilliant.
With all due respect I disagree about the ln parameter. It would be trivial to parse such a parameter with either integer or boolean input. Furthermore, it would decrease the number of options specified in the codeblock opening line (which can already get long). This would mean instead of having two different parameters to set, you could capture all of the corresponding behaviour with just one. I understand if you don't wish to implement this in such fashion though.
I feel a bit more strongly about the highlighting issue. On the contrary, if you set the offset to 140 and have 200 lines of code. Say you want to highlight the 100th line, your suggestion would be to add hl:100 and mine would be to add hl:240. If you know what lines you are highlighting by numbers, your method makes more sense, but more often when highlighting, you identify which lines to highlight whilst reading the code (or directly from your IDE) and in both of these scenarios, the code number you would read off would be 240 and not 100. You would never actually know that a line you want to highlight in a segment of code is line 100 unless you read it without the offset added which is unnecessary.

Ok, that makes sense, I agree with highlighting. So hl:905 instead of hl:5.
The ln parameter does work the following way. Say, you enabled line numbers globally. In this case if you specify ln:false line numbers would not be shown to that specific code block. On the other way around if you disabled line numbers globally ln:true would enable line numbers for that specific code block.
You are right about the parameters, that they are getting too long. Would ln:true,900 be ok? That way it could be enabled/disabled, and after the "," you could define the offset.

I think that would be ok, but would it not be also possible to just have
false -> no line numbering
true -> line numbering starting at 1
{number} -> line numbering starting at number
The added benefit of this is it is once again the actual line number as seen in the IDE/reading mode not an offset. (i.e. to offset a code by 100 lines, it actually starts at line 101 now. Ideally you would put ln:101 rather than ln:true,100) if that makes sense.
I guess my point is that you would never have ln:false,{number} so why let it be an option? Are you considering the case someone temporarily wants to disable the line numbers and then return to the same offset? I understand this use case but syntactically having the line number stored and not used makes no sense. If you wanted to cater to that use case, the way I would personally do it is have ln as I described above and add a second flag disableln to disable line number irrespective of the previous ln flag. I guess in your way, you could reverse your parameters so have:
ln:false -> no line numbers
ln:true -> line numbers starting at 1 (an alias for ln:1)
ln:{number} -> line number starting at {number}
ln:{number},false -> line number starting at {number} but temporarily disabled

I agree with this method totally:
"I think that would be ok, but would it not be also possible to just have
false -> no line numbering
true -> line numbering starting at 1
{number} -> line numbering starting at number"
There is no need for an option where line numbers offset is set, but the linenumbers are disabled.

This one will also be included in Release 1.1.10


Embedding custom HTML inside table cells

Is there a way to render custom html inside table cells?
I am trying to use active-table to render a list page. The first column is supposed to have links that open another page.
Currently, the examples on the activetable.io website are all about rendering a table with data. I am not finding any example of a table with html inside the cells.
<ActiveTable
                data={activeTableData}
                tableStyle={{
                    width: '100%',
                }}

                displayAddNewColumn={false}
                frameComponentsStyles={{
                    styles: {
                        default: {
                            // backgroundColor: 'pink'
                        }
                    }
                }}
                headerStyles={{
                    default: {
                        backgroundColor: 'pink'
                    }
                }}
                rowHoverStyles={{
                    style: {
                        backgroundColor: '#d6d6d630',
                        "transitionDuration": "0.1s"
                    }
                }}
                // stripedRows={{
                //     odd: {
                //         backgroundColor: ''
                //     },
                //     even: {
                //         backgroundColor: '#ebebeb7a'
                //     }
                // }}
                rowDropdown={{
                    displaySettings: {
                        isAvailable: false
                    },
                    canEditHeaderRow: false
                }}
                columnDropdown={{
                    displaySettings: {

                        // isAvailable: false

                    },
                    isInsertLeftAvailable: false,
                    isInsertRightAvailable: false,
                    // is
                }}
                filter={true}
                isCellTextEditable={false}
                allowDuplicateHeaders={false}
                contentEditable={false}
                displayAddNewRow={false}
            />

Hi @rsgilbert. Currently the table does not support rendering custom html elements. We may consider this in the future.

Hello,
I second that. It would maybe be useful for columns to have a custom render function called for each cell, with row & cell as parameters. I can think of several scenarios where this makes sense:

Links in a table are quite common, as mentioned by @rsgilbert
In a generic key->value service, for example, you could have data like:

"timeout.minutes" -> number with incremenent/decrement.
"app.icon" -> base64 image to be previewed on cell hover
"support.email" -> mailto:...

Excel-style "Insert Up"/"Insert Down"/"Move Up"/"Move Down" are very specific operations that might not be needed if you want to use the table for add/edit/delete/sort/filter.
Setting isInsertDownAvailable, isInsertUpAvailable, isMoveAvailable to false would leave "Delete" as the only row-based operation. That is better represented by a custom action column with a delete icon button.

another use case : got /2024/02/01/jklkjsdf.jpg and i want to format the cell so i can display a picture. Custom render is needed, like in webix


Feat/bot1

add new feature - chatbot, include basic functions and html files

add features of bots:

general questions
add cart
query item detail