Gs5 fixes for Pit + flash

There are problems on the GS5 when sending empty bulk transfers during Pit file packet requests.This put the entire session into a wonky state. Request none be sent for these packets.

I tried the patch and it worked with download-pit and print-pit, BUT i have to disconnect the USB-cable afterwards and reconnect.
Device:
Note 10.1 LTE, SM-P605, P605XXUCNJ1
lsusb:
Samsung Electronics Co., Ltd GT-I9100 Phone [Galaxy S II] (Download mode)
On:
x86_64 GNU/Linux

@locomanolo disconnect and reconnect at which point in the process?

@sshimko Every time i did a download-pit or print-pit. But now i guess, it's because i didn't set the --resume flag. So i tested with --resume flag and replugging didn't help. Just look at the log for more details.
And again, just to clarify. My guessing about the --resume flag was wrong, but lead me to another error. I can download-pit or print-pit with the command 'sudo heimdall download-pit --output pit --no-reboot --verbose', if i disconnect and then connect the USB-cable after each command. But replugging the cable doesn't work with the command ''sudo heimdall download-pit --output pit --no-reboot --verbose --resume'. Therefore, i think it has to do with the initialisation of the USB-connection.
Log:

heimdall detect
Device detected

sudo heimdall download-pit --output p605.pit --no-reboot
[sudo] password for xxx:
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...
Initialising protocol...
Protocol initialisation successful.
Beginning session...
Some devices may take up to 2 minutes to respond.
Please be patient!
Session begun.
Downloading device's PIT file...
PIT file download successful.
Ending session...
Releasing device interface...
Re-attaching kernel driver...

sudo heimdall print-pit --no-reboot --verbose
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Manufacturer: "Sasmsung"
Product: "MSM8960"
        length: 18
  device class: 2
           S/N: 0
       VID:PID: 04E8:685D
     bcdDevice: 0100

iMan:iProd:iSer: 1:2:0
nb confs: 1
interface[0].altsetting[0]: num endpoints = 1
Class.SubClass.Protocol: 02.02.01
endpoint[0].address: 82
max packet size: 0010
polling interval: 09
interface[1].altsetting[0]: num endpoints = 2
Class.SubClass.Protocol: 0A.00.00
endpoint[0].address: 81
max packet size: 0200
polling interval: 00
endpoint[1].address: 01
max packet size: 0200
polling interval: 00
Claiming interface...
Setting up interface...
Initialising protocol...
ERROR: Failed to receive handshake response. Result: -7
ERROR: Protocol initialisation failed!
Releasing device interface...
########################
NOW REPLUGGING OF USB
########################

sudo heimdall print-pit --no-reboot --verbose
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Manufacturer: "Sasmsung"
Product: "MSM8960"
        length: 18
  device class: 2
           S/N: 0
       VID:PID: 04E8:685D
     bcdDevice: 0100

iMan:iProd:iSer: 1:2:0
nb confs: 1
interface[0].altsetting[0]: num endpoints = 1
Class.SubClass.Protocol: 02.02.01
endpoint[0].address: 82
max packet size: 0010
polling interval: 09
interface[1].altsetting[0]: num endpoints = 2
Class.SubClass.Protocol: 0A.00.00
endpoint[0].address: 81
max packet size: 0200
polling interval: 00
endpoint[1].address: 01
max packet size: 0200
polling interval: 00
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...
Initialising protocol...
Protocol initialisation successful.
Beginning session...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
Some devices may take up to 2 minutes to respond.
Please be patient!
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
Session begun.
Downloading device's PIT file...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
PIT file download successful.
Entry Count: 30
Unknown 1:<PHONE_NUMBER>
Unknown 2: 844251476
Unknown 3: 21325
Unknown 4: 14413
Unknown 5: 14137
Unknown 6: 52
Unknown 7: 0
Unknown 8: 0
--- Entry #0 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 1
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 8192
Partition Block Count: 30720
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: APNHLOS
Flash Filename: NON-HLOS.bin
FOTA Filename:
--- Entry #1 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 2
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 38912
Partition Block Count: 117632
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: MODEM
Flash Filename: modem.bin
FOTA Filename:
--- Entry #2 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 3
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 156544
Partition Block Count: 1024
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: SBL1
Flash Filename: sbl1.mbn
FOTA Filename:
--- Entry #3 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 4
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 157568
Partition Block Count: 64
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: DBI
Flash Filename: sdi.mbn
FOTA Filename:
--- Entry #4 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 5
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 157632
Partition Block Count: 64
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: DDR
Flash Filename:
FOTA Filename:
--- Entry #5 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 6
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 157696
Partition Block Count: 4096
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: ABOOT
Flash Filename: aboot.mbn
FOTA Filename:
--- Entry #6 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 7
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 161792
Partition Block Count: 1024
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: RPM
Flash Filename: rpm.mbn
FOTA Filename:
--- Entry #7 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 8
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 162816
Partition Block Count: 1024
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: TZ
Flash Filename: tz.mbn
FOTA Filename:
--- Entry #8 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 9
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 163840
Partition Block Count: 20480
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: PAD
Flash Filename:
FOTA Filename:
--- Entry #9 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 10
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 184320
Partition Block Count: 20480
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: PARAM
Flash Filename: param.bin
FOTA Filename:
--- Entry #10 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 11
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 204800
Partition Block Count: 28672
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: EFS
Flash Filename: efs.img.ext4
FOTA Filename:
--- Entry #11 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 12
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 233472
Partition Block Count: 6144
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: MODEMST1
Flash Filename: nvrebuild1.bin
FOTA Filename:
--- Entry #12 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 13
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 239616
Partition Block Count: 6144
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: MODEMST2
Flash Filename: nvrebuild2.bin
FOTA Filename:
--- Entry #13 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 14
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 245760
Partition Block Count: 22528
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: BOOT
Flash Filename: boot.img
FOTA Filename:
--- Entry #14 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 15
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 268288
Partition Block Count: 26624
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: RECOVERY
Flash Filename: recovery.img
FOTA Filename:
--- Entry #15 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 16
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 294912
Partition Block Count: 26624
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: FOTA
Flash Filename:
FOTA Filename:
--- Entry #16 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 17
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 321536
Partition Block Count: 14318
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: BACKUP
Flash Filename:
FOTA Filename:
--- Entry #17 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 18
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 335854
Partition Block Count: 6144
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: FSG
Flash Filename:
FOTA Filename:
--- Entry #18 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 19
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 341998
Partition Block Count: 2
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: FSC
Flash Filename:
FOTA Filename:
--- Entry #19 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 20
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 342000
Partition Block Count: 16
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: SSD
Flash Filename:
FOTA Filename:
--- Entry #20 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 21
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 342016
Partition Block Count: 16384
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: PERSIST
Flash Filename: persist.img.ext4
FOTA Filename:
--- Entry #21 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 22
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 358400
Partition Block Count: 18432
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: PERSDATA
Flash Filename: persdata.img.ext4
FOTA Filename:
--- Entry #22 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 23
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 376832
Partition Block Count: 4894720
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: SYSTEM
Flash Filename: system.img.ext4
FOTA Filename:
--- Entry #23 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 24
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 5271552
Partition Block Count: 409600
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: CACHE
Flash Filename: cache.img.ext4
FOTA Filename:
--- Entry #24 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 25
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 5681152
Partition Block Count: 40960
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: HIDDEN
Flash Filename: hidden.img.ext4
FOTA Filename:
--- Entry #25 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 26
Attributes: 5 (Read/Write)
Update Attributes: 5 (FOTA)
Partition Block Size/Offset: 5722112
Partition Block Count: 0
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: USERDATA
Flash Filename: userdata.img.ext4
FOTA Filename: remained
--- Entry #26 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 70
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 0
Partition Block Count: 34
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: PGPT
Flash Filename: pgpt.img
FOTA Filename:
--- Entry #27 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 71
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 34
Partition Block Count: 16
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: PIT
Flash Filename: MSM8974.pit
FOTA Filename:
--- Entry #28 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 72
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 50
Partition Block Count: 32
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: MD5
Flash Filename: md5.img
FOTA Filename:
--- Entry #29 ---
Binary Type: 0 (AP)
Device Type: 2 (MMC)
Identifier: 73
Attributes: 5 (Read/Write)
Update Attributes: 1 (FOTA)
Partition Block Size/Offset: 30777311
Partition Block Count: 33
File Offset (Obsolete): 0
File Size (Obsolete): 0
Partition Name: SGPT
Flash Filename: sgpt.img
FOTA Filename:
Ending session...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
Releasing device interface...
Re-attaching kernel driver...
############
REPLUGGING
############

sudo heimdall print-pit --no-reboot --verbose --resume
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Manufacturer: "Sasmsung"
Product: "MSM8960"
        length: 18
  device class: 2
           S/N: 0
       VID:PID: 04E8:685D
     bcdDevice: 0100

iMan:iProd:iSer: 1:2:0
nb confs: 1
interface[0].altsetting[0]: num endpoints = 1
Class.SubClass.Protocol: 02.02.01
endpoint[0].address: 82
max packet size: 0010
polling interval: 09
interface[1].altsetting[0]: num endpoints = 2
Class.SubClass.Protocol: 0A.00.00
endpoint[0].address: 81
max packet size: 0200
polling interval: 00
endpoint[1].address: 01
max packet size: 0200
polling interval: 00
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...
Beginning session...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer.
Releasing device interface...
Re-attaching kernel driver...
############
REPLUGGING
############

sudo heimdall download-pit --output p605-2 --no-reboot --verbose --resume
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Manufacturer: "Sasmsung"
Product: "MSM8960"
        length: 18
  device class: 2
           S/N: 0
       VID:PID: 04E8:685D
     bcdDevice: 0100

iMan:iProd:iSer: 1:2:0
nb confs: 1
interface[0].altsetting[0]: num endpoints = 1
Class.SubClass.Protocol: 02.02.01
endpoint[0].address: 82
max packet size: 0010
polling interval: 09
interface[1].altsetting[0]: num endpoints = 2
Class.SubClass.Protocol: 0A.00.00
endpoint[0].address: 81
max packet size: 0200
polling interval: 00
endpoint[1].address: 01
max packet size: 0200
polling interval: 00
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...
Beginning session...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer.
Releasing device interface...
Re-attaching kernel driver...
############
USB left inside
############

sudo heimdall download-pit --output p605-2 --no-reboot --verbose
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Manufacturer: "Sasmsung"
Product: "MSM8960"
        length: 18
  device class: 2
           S/N: 0
       VID:PID: 04E8:685D
     bcdDevice: 0100

iMan:iProd:iSer: 1:2:0
nb confs: 1
interface[0].altsetting[0]: num endpoints = 1
Class.SubClass.Protocol: 02.02.01
endpoint[0].address: 82
max packet size: 0010
polling interval: 09
interface[1].altsetting[0]: num endpoints = 2
Class.SubClass.Protocol: 0A.00.00
endpoint[0].address: 81
max packet size: 0200
polling interval: 00
endpoint[1].address: 01
max packet size: 0200
polling interval: 00
Claiming interface...
Setting up interface...
Initialising protocol...
ERROR: Failed to receive handshake response. Result: -7
ERROR: Protocol initialisation failed!
Releasing device interface...
############
REPLUGGING
############

sudo heimdall download-pit --output p605-2 --no-reboot --verbose
Heimdall v1.4.1

Copyright (c) 2010-2014 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/
This software is provided free of charge. Copying and redistribution is
encouraged.
If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/
Initialising connection...
Detecting device...
Manufacturer: "Sasmsung"
Product: "MSM8960"
        length: 18
  device class: 2
           S/N: 0
       VID:PID: 04E8:685D
     bcdDevice: 0100

iMan:iProd:iSer: 1:2:0
nb confs: 1
interface[0].altsetting[0]: num endpoints = 1
Class.SubClass.Protocol: 02.02.01
endpoint[0].address: 82
max packet size: 0010
polling interval: 09
interface[1].altsetting[0]: num endpoints = 2
Class.SubClass.Protocol: 0A.00.00
endpoint[0].address: 81
max packet size: 0200
polling interval: 00
endpoint[1].address: 01
max packet size: 0200
polling interval: 00
Claiming interface...
Attempt failed. Detaching driver...
Claiming interface again...
Setting up interface...
Initialising protocol...
Protocol initialisation successful.
Beginning session...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
Some devices may take up to 2 minutes to respond.
Please be patient!
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
Session begun.
Downloading device's PIT file...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
PIT file download successful.
Ending session...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...
Releasing device interface...
Re-attaching kernel driver...

I was also having the "Empty bulk transfer" problems with the SM-G900F using the 1.4.1.  I built the master branch (at d0526a3b74a003dfc6f805682693be9173ffcd88) and was able to flash on the recovery without issues.  (Running on Fedora 21)

Is there a EASY answer to how you fix this:
Downloading device's PIT file...
ERROR: Failed to send request to end PIT file transfer!
ERROR: Failed to download PIT file!
Ending session...
ERROR: Failed to send end session packet!
Releasing device interface...

Is the fix integreated in the version 1.4.0 ?
This version end with the same error (SM-G900F, Vodafone-branding):
"...
Some devices may take up to 2 minutes to respond.
Please be patient!
Session begun.
Downloading device's PIT file...
ERROR: Failed to receive PIT file part #0!
ERROR: Failed to download PIT file!
Ending session...
ERROR: Failed to receive session end confirmation!
..."
Or the software must be manually edited with the fix? But how?
Please help me get out of the data-clutches of Google.

I'll just add that with a Galaxy S5 Canadian version (SM-G900W8), sshimko's patches fixed this issue for me.

Is this ever getting pulled?

@Qwertie- As is, no. Because I've confirmed this change breaks support for other devices - further investigation is needed. So that other people can benefit, I leave pull requests open however until I can come up with a better solution - right now I don't have a better solution.

@Benjamin-Dobell I built the latest version and it works on my SGS 5 but the binary on the website does not with the error
Downloading device's PIT file...
ERROR: Failed to send request to end PIT file transfer!
ERROR: Failed to download PIT file!
Ending session...
ERROR: Failed to send end session packet!
Releasing device interface...
Re-attaching kernel driver...

@jaymzh @benwaffle Your ERROR: Protocol initialisation failed! might be the same issue as #228. Try my fix with the udev rule.

@sshimko @Benjamin-Dobell S5 users on OSX are hosed without getting something into the latest version of heimdall from this fix fork. libusbx which is required to build the fork that contains the fix, is no longer available on homebrew, and the fork and master have diverged significantly in how they're built (as far as I can tell, I'm no pro with this stuff. a lowly S5 owner desperately trying to update his modem firmware)

@shellscape Unfortunately I can't merge this (as is) due to it breaking support for SM-N900, and possibly other devices I don't own. However, you have two options:

libusbx actually was merged back into (or rather became) the official libusb-1.0. So you can just grab that from Homebrew and should still be able to build the fork.

Just checkout the latest Heimdall source and apply a single line code change:

At line 929 of BridgeManager.cpp (https://github.com/Benjamin-Dobell/Heimdall/blob/master/heimdall/source/BridgeManager.cpp#L929):
-		success = SendPacket(requestPacket);
+		success = SendPacket(requestPacket, kDefaultTimeoutSend, kEmptyTransferNone);

Ideally we could detect SGS5 and just toggle between these two behaviour at run-time. However, some SGS5 definitely do work - as I have a GM-G900I that works flawlessly. I suspect this behaviour changes between secondary bootloader versions - so know the device model isn't enough to differentiate.

@Benjamin-Dobell awesome info, thanks much for taking the time to post that. I'll give that a shot in the next day or so. I'm running a very old KitKat bootloader, and I've suspected that my problems getting it updated are related to it's age.

Doesn't look like that worked, unfortunately. I made the suggested change and built the source, and using that binary I attempted to flash - which appeared to work successfully. However, I checked after boot and despite there being no error messages, no changes were made. I attempted to download the pit file from my SM-G900T and this is what I got:
→ sudo heimdall download-pit --output I9505.pit --verbose --no-reboot
Heimdall v1.4.0

Copyright (c) 2010-2013, Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
      Manufacturer: "Sasmsung"
           Product: "MSM8960"

            length: 18
      device class: 2
               S/N: 0
           VID:PID: 04E8:685D
         bcdDevice: 0100
   iMan:iProd:iSer: 1:2:0
          nb confs: 1

interface[0].altsetting[0]: num endpoints = 1
   Class.SubClass.Protocol: 02.02.01
       endpoint[0].address: 82
           max packet size: 0010
          polling interval: 09

interface[1].altsetting[0]: num endpoints = 2
   Class.SubClass.Protocol: 0A.00.00
       endpoint[0].address: 81
           max packet size: 0200
          polling interval: 00
       endpoint[1].address: 01
           max packet size: 0200
          polling interval: 00
Claiming interface...
Setting up interface...

Initialising protocol...
WARNING: Control transfer #1 failed. Result: -9
WARNING: Control transfer #2 failed. Result: -9
WARNING: Control transfer #3 failed. Result: -9
WARNING: Control transfer #4 failed. Result: -9
WARNING: Control transfer #5 failed. Result: -9
WARNING: Control transfer #6 failed. Result: -9
Protocol initialisation successful.

Beginning session...

Some devices may take up to 2 minutes to respond.
Please be patient!

Session begun.

Downloading device's PIT file...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet.
ERROR: Failed to send request to end PIT file transfer!
ERROR: Failed to download PIT file!
Ending session...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet. Retrying...
ERROR: libusb error -7 whilst sending packet.
ERROR: Failed to send end session packet!
Releasing device interface...

Heimdall v1.4.0

It looks like you're still running the old binary. If you're running the latest code from this repo it will say v1.4.1.

You're too fast :) I copied an older log I had generated. I updated the output from using the built binary

Hmm, it's failing very early on - this patch modifies functionality during PIT dumping, but you're not even able to connect. I suggest opening or commenting on another issue. However, in my experience if it fails that early on it usually means you've failed to communicate with the device once (say using the old binary), and then haven't rebooted the device (back into download mode) before trying again. Please ensure you've freshly rebooted into download mode before running Heimdall.
The same error can also occur due to a slightly dodgy USB port or cable (in download mode the devices seem to particularly fragile and fail with ports and cables that work fine with other devices) - so it's worth trying another port as well.

You were indeed correct on the reboot suggestion. I hadn't realized, noob mistake there, so apologies are due. I attempted a PIT download and this is the output:
→ ./heimdall download-pit --output G900T.pit --verbose
Heimdall v1.4.1

<snip>

Initialising connection...
Detecting device...
      Manufacturer: "Sasmsung"
           Product: "MSM8960"

            length: 18
      device class: 2
               S/N: 0
           VID:PID: 04E8:685D
         bcdDevice: 0100
   iMan:iProd:iSer: 1:2:0
          nb confs: 1

interface[0].altsetting[0]: num endpoints = 1
   Class.SubClass.Protocol: 02.02.01
       endpoint[0].address: 82
           max packet size: 0010
          polling interval: 09

interface[1].altsetting[0]: num endpoints = 2
   Class.SubClass.Protocol: 0A.00.00
       endpoint[0].address: 81
           max packet size: 0200
          polling interval: 00
       endpoint[1].address: 01
           max packet size: 0200
          polling interval: 00
Claiming interface...
Setting up interface...

Initialising protocol...
Protocol initialisation successful.

Beginning session...
WARNING: Empty bulk transfer after sending packet failed. Continuing anyway...

Some devices may take up to 2 minutes to respond.
Please be patient!

ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer. Retrying...
ERROR: libusb error -7 whilst receiving bulk transfer.
Releasing device interface...

The resulting G900T.pit file is 0 bytes.

Unfortunately, I'm not sure; without the device on hand it's really difficult for me to resolve these types of issues. I only have access to a G900I, and it actually works without this patch applied. If you haven't already done so, then I would suggest undoing the change you made to BridgeManager.cpp and recompiling.

@Benjamin-Dobell thanks for the help none the less. I recloned the repo and rebuilt, but I'm still getting the the ERROR: libusb error -7 whilst receiving bulk transfer. Retrying... errors. The good news is that with the binary built from the source, I no longer get the initialization error. It looks like the download for OSX on http://glassechidna.com.au/heimdall/ is still pointing at 1.4.0, which probably why I ran into that problem to begin with. thanks again.

@sshimko thank you, it's work for me, not galaxy s5 but sc-02f which use android 5.0 bootloader

Current git on 2016-08-12 built on Debian jessie worked for me on a Samsung S5 SM-G900T to RECOVER twrp-3.0.2.

Just another report that this patch, applied on top of the v1.4.1 tag, plus the fix from https://github.com/Benjamin-Dobell/Heimdall/issues/172#issuecomment-54003538, was enough for me to flash TWRP on my T-Mobile Galaxy S5 using Ubuntu 12.04.

I merged this with master, resolved the conflict and can confirm it fixes the issue for Note 2014 LTE. I created #373 to merge into  master.

I'm getting "SECURE CHECK FAIL" on flashing, probably because my image is bad... and I tried adding the two other arguments to the ReceivePitFile SendPacket and I think it may have messed things up for my Galaxy J727U

I just tried this fix on the GS5  G900T and was able to finally get a copy of the PIT.


S3- Title and Associated Partner Error (we need to test if this error still exists)

User reports that changes made to project titles and associated community partners do not reflect properly after editing existing projects. For example, the above project should be titled “Evidence-Based Nebraska – Treatment”, however, the “- Treatment” portion is not displaying (is in unclear at what point this part of the title falls out). Additionally, an organization that was accidently added (“Spielbound”) is hanging on after the user attempted to remove it.


The RPC call or parameters have been disabled

I'm trying to retrieve the metadata from this 9vwYtcJsH1MskNaixcjgNBnvBDkTBhyg25umod1rgMQL
Despite the critical bug I've seen in the readme of this repo and you suggesting not to use it, this tool was working for me till a few weeks ago (before solana went offline).
This is the command I run:
yarn retrieve 9vwYtcJsH1MskNaixcjgNBnvBDkTBhyg25umod1rgMQL

This is the response:
yarn run v1.17.3
$ ts-node src/index.ts 9vwYtcJsH1MskNaixcjgNBnvBDkTBhyg25umod1rgMQL
/solana/sol-mint-list/node_modules/@solana/web3.js/src/connection.ts:815
        callback(new Error(`${res.status} ${res.statusText}: ${text}`));
                 ^
Error: 410 Gone:  {"jsonrpc":"2.0","error":{"code": 410, "message":"The RPC call or parameters have been disabled."}, "id": "12c964c7-4ac7-4db3-8c2a-fe74692edbe1" }

    at ClientBrowser.callServer (/solana/sol-mint-list/node_modules/@solana/web3.js/src/connection.ts:815:18)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

The error seems clear enough, RPC calls disabled... maybe you can have a look and see if they really are disabled and why? Will they be enaled again or that's it? THX for a feedback & cheers

@cryptotester // are you still facing this issue?

yes im facing the same issue


docs: meaning of argument "format"?

Hi,
taking a look at help(OmnivoreQL.get_article) I see the argument "format: str = None" but can't find anywhere what the expected values are and what the effects are.
Thank you for clarifying this to me.

It is not clear based on their documentation what format exactly means. But bydefault html is returned and you can also change it to markdown. I have update the code and pydoc to include this information. https://github.com/yazdipour/OmnivoreQL/pull/19/commits/f88564a3bc6aca7bb0698c7bc698ea25590bdab2


Increment version for template releases

Increment package version after release of azure-template

@chidozieononiwu another instance of a version increment I would expected to have been closed automatically.


Fix including excluded repositories due to broken status

There's a short period of time after a package is uploaded that OBS might report it as broken, with the details set to empty. This means that, when the build metadata is gathered, excluded architectures end up being included, because the status is broken instead of excluded.
In order to work around this, wait for a short period of time if the package's status is broken and details are empty, that way we can actually check if the architecture is excluded.
Signed-off-by: Ryan Gonzalez<EMAIL_ADDRESS>
In draft status because it depends on https://github.com/collabora/open-build-service-rs/pull/10.

your dependency has been merged now :)


Feature request: implement a smart os.path.getsize

It would be pretty cool to have a smart "getsize" that works locally, with s3, etc.

This is out of scope, and work-arounds already exist (see #504).


Init containers now retrieved

Summary
Init containers were ignored. Now they are retrieved by InterLink and passed in the same identical way to the sidecar, but before "normal" containers
I had to use my previous PR as codebase, since it integrated a slight API rework which is not merged int he actual InterLink master

Related issue :
#220

@Surax98 this change is not against the main branch, therefore I cannot merge it unless I add the previous major changes.
Instead, I think this is a small enaough set of change that should be merged ahead of the 0.3.0, for which I think we need a bit of more time to push.

@Surax98 this change is not against the main branch, therefore I cannot merge it unless I add the previous major changes.
Instead, I think this is a small enaough set of change that should be merged ahead of the 0.3.0, for which I think we need a bit of more time to push.

@dciangot ok, I thought it would be worth merge everything together, but I will just re-apply this minor change based on the main branch. I cannot quickly test it (I have already upgraded my slurm sidecar's API), but it should be really minimal and shouldn't be any problem at all

@Surax98 this change is not against the main branch, therefore I cannot merge it unless I add the previous major changes.
Instead, I think this is a small enaough set of change that should be merged ahead of the 0.3.0, for which I think we need a bit of more time to push.

@dciangot ok, I thought it would be worth merge everything together, but I will just re-apply this minor change based on the main branch. I cannot quickly test it (I have already upgraded my slurm sidecar's API), but it should be really minimal and shouldn't be any problem at all


[TGER-71] Add Waivers

Add LocationWaiver model.
Add LocationWaiver factory.
Add LocationWaiver migration.
Add LocationWaiver test.
Add Signature test.
Fix permission seeded test.
Require locations package as a required dependency.
Require media package as a required dependency.

https://github.com/tipoff/locations/issues/31

@drewroberts I am going to push the nova resource and policy for now. I still have a question on the relationship of Signature - Location - Waiver so didn't make any changes to them.


HAWQ-414. Share memory become inconsistent if the number of segment f…

…iles created more than max_appendonly_segfiles

+1

merged


BUG | 2.0.2 | 'EqualHeightElement' cannot be used as a JSX component. Its return type 'ReactNode' is not a valid JSX element.

Hi, I just upgraded to version 2.0.2 from 1.0.3 and everything else being equal, I get the following error:
'EqualHeightElement' cannot be used as a JSX component.
  Its return type 'ReactNode' is not a valid JSX element.
    Type 'string' is not assignable to type 'ReactElement<any, any>'

I have followed the upgrade steps and made the relevant updates:

The tag prop has been replaced by as in EqualHeightElement
The updateOnChange prop now only accepts an array based on DependencyList
The class name equal-height-JlocK has been updated to equal-height-wrapper

What TS version you are using? I didn't add intentionally explicity return of type for components based on article: https://www.totaltypescript.com/jsx-element-vs-react-reactnode.

You should almost never use JSX.Element or React.ReactElement in your code. They're types used internally by TypeScript to represent the return type of JSX expressions.
Instead, use React.ReactNode to type the children of your components. I'd also suggest not annotating the return types of your components to avoid confusion - but if you're using TypeScript 5.1, go ahead.

I am wondering where the error lies. Is it on my side and I should explicitly add the type ‘ReactNode’ for all components, or is the problem somewhere else like a big incompatibility of TS versions, or the type of parent components or something else?!

@loba-b I've had another read of that link you sent and indeed I think it's a TypeScript version issue.
In TypeScript versions before 5.1, you can't use React.ReactNode in one specific case - typing the return type of a component.
For compatibility between TypeScript versions, may I suggest changing the return types from React.ReactNode to React.ReactElement?

Hi @tandrasi thank you for your support. I'll check it out, but I'm also thinking of removing the types for the returned component in fixedForwardRef. In the other component I didn't add such types because of the article, but for fixedForwardRef I found the solution online and didn't notice that there is type.

I think I have fixed issue. I removed the fixedForwardRef  and passing the ref in props in standard way. I'll do more testing today and if everything will be fine, I'll implement the new version.

I have just released a new version @2.0.3. Please test it when you can and please let me know if it is ok.


How to handle Stripe errors?

Is there a way to get notified when the transaction fails so that we can react to stripe error codes?
I only see errors in the developer console but I was not able to detect them in any callback provided by VueStripeCheckout.
Thank you in advance!

Will look into it thanks.

Error events are now available in V3 beta. See this and this.


Write out results schema to filesystem in summarize functions

Summary of Changes
This has two purposes:

Make sure the results are written safely somewhere while the file database problem is not sorted

For calculators where nothing is written to the disk (MACE, EMT, ...) this results file gives sense to the currently empty directories

What do you think?
EDIT: Probably not going to be as easy as I was expecting
Checklist

[ ] I have read the "Guidelines" section of the contributing guide. Don't lie! 😉
[ ] My PR is on a custom branch and is not named main.
[ ] I have used black, isort, and ruff as described in the style guide.
[ ] I have added relevant, comprehensive unit tests.

Notes

Your PR will likely not be merged without proper and thorough tests.
If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.
When your code is ready for review, ping one of the active maintainers.

Can one of the admins verify this patch?

I'll take a look later to figure out what's going on here.

@Andrew-S-Rosen Thanks, I thought the same. It seems that a string is finding its way in the Monty code while it should be a dict.

I am sorting this out. Seems to be related to https://github.com/materialsproject/emmet/issues/914.

I just fixed what I believe is the upstream issue. Just waiting on a new release of emmet-core.

Note to self for later:
We can circumvent these issues by jsanitize-ing the data beforehand.

Alright, this is close... but not all the way there. This is definitely 100% do-able, but there are a few spots where directory is not defined appropriately (hence the errors) plus one serialization issue in the defect tests that is easily solvable.

The light at the end of the tunnel: the checks have emerged!! Now we just need some tests 😄

@Andrew-S-Rosen
Thanks for taking care of that, I think that was a little bit beyond my python abilities, tests will come this weeks probably

EDIT: it seems that one particular line takes a lot of time (flat 30 seconds each time I run a calculation) I will turn off get_metadata for now

Is this a result of the change in the present PR, or are you just commenting more generally?

EDIT: it seems that one particular line takes a lot of time (flat 30 seconds each time I run a calculation) I will turn off get_metadata for now

Is this a result of the change in the present PR, or are you just commenting more generally? Could you also provide some insight about the Atoms object? I am curious if there is a lot of data in .info. If this is a new thing, perhaps it is related to #1829. I doubt it is related to present PR specifically.

Ah yes! There is something inside the atoms.info, although it's not a lot just a simple short string. I assume this was related to this commit but it might not be you are right

Here are the tests! Did not create new ones but made sure to test all summarise functions

@tomdemeyere: Fantastic, thank you very much! I will proceed with the merge.
Later on, if you find needing JSON is critical, let me know because I can likely make it work if needed.

Just thought about it:
Would you mind adding a reserved key name in "additional_fields" which value would be used as a name for the pickle file?
{"pickle_label": "water_dimer_5.5"}
This is a nice niche feature that helps visual inspection?

Personally, I'm a bit hesitant to add in "hidden" features where we overload a given method with multiple purposes (as you likely have observed from my comments about disliking the .pop business on user-supplied dictionaries).


Add Move duplicate feature

Hi @ManthanRami,
Thanks a lot for opening the pull request and for your help in making difPy a better package!
Unfortunately, the feature to move files directly within difPy will not be implemented, as this doesn't fall within its scope. Instead, users can run difPy and can make use of the search.lower_quality output to move the files wherever they desire. The output of difPy is designed to be adaptable to many use cases, so that users can decide for themselves what to do with it.
Nevertheless, I would like to thank you again very much for your input and for taking the time to open the pull request!
All the best,
Elise

Hi @ManthanRami!
After reevaluating your idea, I concluded that it indeed would be a valuable feature to add to difPy. The feature has been added to v.3.0.6.
Thanks a lot for your contribution!
All the best,
Elise


Enabling compiled regex for "pattern" on String type

Hi, the documentation says you can use compiled regex for "pattern" parameter on String type:

pattern - A string or compiled regex that the data must match.

But when I try to use a compiled regex I get this error message:
  File "/home/kurt/Projects/myproject/myproject/types.py", line 17, in Product
    name = validators.String(pattern=re.compile(r"^[a-zA-Z_][a-zA-Z0-9_-]{0,63}$"))
  File "/home/kurt/Projects/myproject/venv/lib/python3.6/site-packages/apistar/validators.py", line 109, in __init__
    assert pattern is None or isinstance(pattern, str)
AssertionError

Thank you.

Closing in favour of #433


add legendary battle love and thunder in the menu please

add please

0.19.0 just published which supports Thor L&T


Feat.typhoon dynamic layers

@SwatiTh can you maybe google to find out why that ibf-dashboard test keeps failing? Maybe it's a known issue somewhere or something?


Grammar fix

Just a small grammar fix here.

Lol whut? Why did this trigger all those failures? 😅

@driesvints see the message from failing test.
Did you really expected that such REAMDE is to be updated manually? That it is manually updated with all the new fixers and new options?

@kubawerlos there's a 108 failing tests in the CircleCI test alone and yes I did expect I could simple edit a README of a repo without breaking the entire test suite 😅

Nvm, I just saw the contributing guide. Sorry for not reading that earlier!

@driesvints 108? Take a second look:

FAILURES!
Tests: 19682, Assertions: 452708, Failures: 1, Skipped: 108, Incomplete: 41.

You broke exactly one test, which in its message explains what went wrong:

PhpCsFixer\Tests\Console\Command\ReadmeCommandTest::testIfReadmeFileIsCorrect
README.rst file is not up to date! Do not modify it manually! Regenerate readme with command: php php-cs-fixer readme > README.rst.

See #4944.


Feat/demoeng 1319 automatic serverless deploys

Summary
view services/README.md
successful job summary example with test services:

Checklist

[ ] Tested changes end to end
[ ] Updated documentation
[ ] Requested one or more reviewers

Closing due to the merge of #387.


Rename Skin abstractions to Theme

This is a potential update to https://github.com/dnnsoftware/Dnn.Platform/pull/5838 to adjust the names of the abstractions to use Theme instead of Skin.

@valadas @mitchelsellers @donker @david-poindexter

I'm really torn on this, as even if we make the change here is is only a partial change as the actual Themes are still stored in the /Skins folder within the portal Or root.

I don't have a strong opinion on this but leaning towards leaving it at Skins just for consistency at least for developers. To keep it consistent then everything with the words Skin would have to become Theme, so ThemeObjects, folder names, manifests, etc. and the would be massive breaking change. Sooo, I am leaning towards leaving Skin terminology in the backend myself.

Well, we are already "straddling the fence" on these two terms, so I would be a fan of just making things consistent one way or the other.  Skin is what it has always technically been.  Theme is better for outsiders coming in, but Corp didn't go "all in" when they started using Theme.  Documentation is currently Theme but the code unfortunately doesn't match.  So...is there a chance we could go "all in" one way or the other?  For what it is worth, I like Theme but this would of course mean having to change folder names, etc.
Furthermore, I honestly think the Skin(s) approach was flawed semantically from the beginning.  We had no clear distinction between a skin "package" and skin "layout".  So I think theme and layout clear this up semantically.  Container is fine regardless.


fix(docs): fix stopper.stop wrong variable name. closes #2244

Was:
var stopper = require('karma').stopper
runner.stop({port: 9876}, function(exitCode) {

Changed to :
var stopper = require('karma').stopper
stopper.stop({port: 9876}, function(exitCode) {

Thanks :octocat:


Global and center settings

we need a way to define settings globally and for a set of centers. e.g.

A center has it's own list of emails it wants included when the reports go out
A region needs to define by when thing are due
Globally, we may want to define some default that could change.

We could do this with a settings table that maps a setting key/value pair to center. Maybe the magic center 0 could be global/default.

Pull Request: https://github.com/pdarg/tmlpstats/pull/68


Node Representation Learning

Add notes of Node Representation Learning in Machine Learning with Networks part.

Please publish your fork with Jeykll so we can preview your changes at https://tianyuanhuang.github.io/cs224w-notes/

got it! It should work now.

Thanks for the contribution! Looks good overall. I think there's a minor grammar error in bullet 2 of "Embedding Nodes", but they're solid notes.

Thanks Ben!


codestitch?

Just discovered https://codestitch.app/app from reddit, i think it could be to add to html/css template

Great, Feel free to add a PR;


fix: changing node reachability status

Checklist

[ ] I have read the coding guide
[ ] My change requires a documentation update and I have done it
[ ] I have added tests to cover my changes.

Description

Motivation and context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):
Closes #2693

This change is

Codecov Report

Merging #2728 (e722ab4) into master (377b43b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   63.76%   63.70%   -0.06%
==========================================
  Files         237      237
  Lines       26772    26774       +2
==========================================
- Hits        17070    17056      -14
- Misses       8174     8189      +15
- Partials     1528     1529       +1

Impacted Files
Coverage Δ

pkg/topology/kademlia/kademlia.go
75.37% <0.00%> (-0.31%)
:arrow_down:

pkg/p2p/libp2p/stream.go
70.58% <0.00%> (-11.77%)
:arrow_down:

pkg/localstore/subscription_pull.go
84.24% <0.00%> (-2.74%)
:arrow_down:

pkg/localstore/subscription_push.go
77.19% <0.00%> (-1.76%)
:arrow_down:

pkg/p2p/libp2p/internal/reacher/reacher.go
90.90% <0.00%> (-1.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377b43b...e722ab4. Read the comment docs.

pkg/topology/kademlia/kademlia.go, line 1322 at r1 (raw file):
Previously, mrekucci wrote…
But then you'll have inconsistencies between what is set in metrics and what will be reported in the topology endpoint.

So I need to understand why we need the sync.Once here first.

pkg/topology/kademlia/kademlia.go, line 1322 at r1 (raw file):
Previously, mrekucci wrote…
So I need to understand why we need the sync.Once here first.

It's basically because of this issue (in libp2p): #2693

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aloknerurkar and @istae)

pkg/topology/kademlia/kademlia.go, line 1322 at r1 (raw file):
Previously, aloknerurkar wrote…
@aloknerurkar if the reachability is constantly changing, how do you know which value to pick?

So the reachability update is being provided by the libp2p event bus. If it changes, shouldnt we report the updated value?
For eg. due to some network issue, if the reachability becomes private from public, the topology endpoint should show the updated value right?


Changing the day order breaks it

hi @bunkat
firstly, thanks for a great package! absolutely love it!!
onto the bug..
if the schedule is specified as "at 8:00 pm on sun, mon, tue, wed, sat" it works.
if the schedule is specified as "at 8:00 pm on mon, tue, wed, sat, sun" it breaks!! by which i mean it skips the first few occurrences completely.
Cheers
rajpa

Yeah, in general Later assumes that all of the constraints are pre-sorted.  If you do a console.log on the schedule that is created you will see it is just a buch of key value pairs where the values are arrays.  Make sure each of the arrays are sorted before you calculate occurrences and you should be all set.

thanks @bunkat. the problem arises if I do schedule.next(100, start, end) in which case, the "sun" occurences just vanish completely, having come last... hope that clarifies..
cheers/rajpa

Sun needs to come first since it's the lowest day value in Later.  If you sort the constraints after creating the schedule it will work as expected.


Rotation of Tile with Navigation mesh using editor causing imperfect baking of the mesh

Tested versions
Reproducable in 4.2.2 stable
System information
Godot v4.2.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 31.0.24002.92) - AMD Ryzen 5 2600X Six-Core Processor (12 Threads)
Issue description
when rotating a Tile with at least one point deviating too much from a simple enough shape (unsure) causes the Engine to bake the navigation mesh of the Tile incorrectly.

In This picture, at the top there are the preconfigured navigation meshes of the tiles, in the lower ones the formers are rotated using the inbuilt tool.
Steps to reproduce
-Make a Tilemap
-Set the Navigation mesh of a Tile, while deviating from a simple shape, preferably sharp/a lot of corners
-Place the tile, rotated
Minimal reproduction project (MRP)
Test-project.zip

New addition of an Error:

I can confirm that this is in fact a bug. See the linked PR for details.


Add decimal point limitation

Give the user the ability to add a limitation of the figures after the decimal point, when we return the result.
This is due to float being currently limited to 2 decimal points, but none of the other types are.
I need to have the decimal points amount consistent for all types.

The 2 decimal point limitation is only on a few float conversions.
The choices are:

Remove the limitation.
Add a parameter that sets the limitation.

The simplest thing to do is remove the limitation.  I think the better thing to do is add a parameter that sets the limitation with a default of "0" for no limitation.
This extra feature will need to be changed in the float, double and string converters.

I've just noticed that Math.Round() has some limits it sets when rounding values.
You can only have a maximum of 15 fractional values.
You can only round values that are less than 1e16d (uses the Abs() method to handle negative values).
As the Math class does this work, I don't have to, but the unit tests will need to state that.

Using the benchies to identify if this parameter affects the performance.

It's nice to have a conversation with myself! :)

I have a branch with the fix for float types.
I'm working on making the same feature for the other types as well to keep them in sync.

Next step is to update the readme and wiki to reflect the new parameter added to the extensions.


Configurable behavior of page-up (cursorPageUp) and page-down (cursorPageDown)

I haven't found a way how to change the behavior of page-up and page-down to the following:

when I hit page-up / page-down, the cursor won't visually move the line, but the content scrolls up or down.
this basically means, that hitting page-up and then page-down brings me to the same "view" as it was before (unless I hit start / end of document)

Currently when I press page-up / page-down the page doesn't scroll, but the cursor moves up or down first (then after hitting page-up / page-down again it scrolls finally). I'm not used to this behavior and would like to change that.
Not sure I expressed this correctly, I just would like to have the option to control this.

There are two commands that do what you wish, but they need to be bound to a key combination:
In your keybindings.json
{ "key": "ctrl+pagedown",          "command": "scrollPageDown",
                                     "when": "editorTextFocus" },
{ "key": "ctrl+pageup",            "command": "scrollPageUp",
                                     "when": "editorTextFocus" }

It's not the same, what you suggest is to just scroll without moving the cursor, I wanted the behavior that is in Visual Studio and all other IDEs, when I press PageUp/Down it scrolls and moves the cursor as well.


✨ migrate Identity store to pinia

This one need to be tested (doesn't work yet)
edit: Tested new minting on /snek/gallery/3124270296-1
TODO

[x] onChange account fetchBalance is triggered but new value not diplayed
[x] onLoad app doesn't show WalletName
[x]  [Vue warn]: Write operation failed: computed value is readonly
[x] issue with subapi (connect to bsx on rmrk chain???)
[ ] > After connect, if realod, it doesn't stay connected (the wallet) Balance is not loaded properly of compare with beta

PR Type

[x] Refactoring

Context

[x] related link #4755

Screenshot 📸
updated:

Copilot philosophy

🤖 Generated by Copilot at 23b3c6a
Summary
Walkthrough

wassup

wassup

wassup

Clicked this magic button

Btw @subsquid has identity squid which should be released very soon 🥺
so I am maybe thinking to rewrite once we will have API for that. WDYT?

Btw @subsquid has identity squid which should be released very soon 🥺 so I am maybe thinking to rewrite once we will have API for that. WDYT?

YES! please, set me free from this hell!
Is it going to be with ArrowSquid? can't we beta test it?
in any case I'll still have to rewrite some of the code because we need to fetch balance.
I need to think of a way to persist balance with account (for now fetchBalance on ConnectWalletModal openning)

copilot:poem

copilot:poem

It works only in description

YES! please, set me free from this hell!
Is it going to be with ArrowSquid? can't we beta test it?

cc @RaekwonIII

YES! please, set me free from this hell!
Is it going to be with ArrowSquid? can't we beta test it?

cc @RaekwonIII

AFAIK the identity squid is unrelated to Arrow Squid. It's sort of like an "addendum" of Giant Squid. Michael is working on it, but he's been sidetracked by a few things in the last couple of weeks.
As for Arrow Squid, you guys will probably even have Alpha access, if you want to! 😂

As for Arrow Squid, you guys will probably even have Alpha access, if you want to!

OFC 🦑

@roiLeo can we finish this appart from having Identity Squid in some minimal way?

@roiLeo can we finish this appart from having Identity Squid in some minimal way?

Hi! It's not that I don't want to finish it, but I'm facing some problems on fetching user balance when you switch network.
Same stuff with Identity GivenName. For now this PR could break some important stuff.
A little help would be very appreciated 😃

on fetching user balance when you switch network.

maybe it's some issue related to sub-api package?

A little help would be very appreciated

if you can be more descriptive, so other can have look so you are not blocked on this one?

on fetching user balance when you switch network.

maybe it's some issue related to sub-api package?

Nope I deleted some part of code that was subscribing to prefix change maybe it's comming from that part?

if you can be more descriptive, so other can have look so you are not blocked on this one?

onChange account fetchBalance is triggered but new value not diplayed
onLoad app doesn't show WalletName

Balance is not persisted
But when I test it sometimes it work and sometimes it doesn't
(just tested preview I can fetch balance when network change but GivenName isn't displayed)

Hello @kodadot/code-review-guild I need some reviews/tests since this PR affects a sensitive part of the code.
I would like to know if there is a strange behavior when you connect or change account in walletModal (check givenName & balance). If so please let me know the steps to reproduce the bug.
Thanks! 👯♀

@kodadot/qa-guild pls
Need to test if we have correct token amounts on chain and correct identities

cc @helloitsdamsky

identity should work, right?
bc I don't see it working
also balance bug found prob not related to this pr
https://user-images.githubusercontent.com/5887929/236919962-07c6ae4d-b95d-47d8-affd-40b552d23663.mov

on Mar 28
I would merge bc it's open quite long

I would merge bc it's open quite long here

Feel free but I'll let you know this could break some part of app.
IDK why but on RMRK2 sometimes it's fetching balance from BSX rpc endpoint.

I would merge bc it's open quite long here

Feel free but I'll let you know this could break some part of app.
IDK why but on RMRK2 sometimes it's fetching balance from BSX rpc endpoint.
edit: now doesn't work on rmrk2... face_exhaling

seems related with

#5838

seems related with
* [Balance bug on rmrk2 #5838](https://github.com/kodadot/nft-gallery/issues/5838)

Maybe something wrong with sub-api package as I don't have the good apiInstance when ksm prefix

hmm, did not help apparently

https://github.com/kodadot/nft-gallery/pull/5914

testing on this one

https://deploy-preview-5400--koda-canary.netlify.app/ksm/collection/22708b368d163c8007-CITY/activity

testing on this one
* https://deploy-preview-5400--koda-canary.netlify.app/ksm/collection/22708b368d163c8007-CITY/activity

Loading times are longer than beta.kodadot.xyz

if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

Balances from Kusama won't load, only if change to another network and try again, or refresh the page, also, taking lots of times to fetch balances:

if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

this was might fixed in

https://github.com/kodadot/nft-gallery/pull/5927
I can try update this PR and let's see

May be related too PR above

if i select the BSX network, check my balances and then change to RMRK without closing the modal it still shows my BSX balances:

I would propose to close sidebar on network change till now

Balances from Kusama won't load, only if change to another network and try again, or refresh the page, also, taking lots of times to fetch balances:

worked for me

prepare for bugs


image-rs: add feature gate to verify

it's pulled in unconditionally and expects host headers to be installed. Can it be behind a feature gate?

/cc @ChengyuZhu6

Sure.

it's pulled in unconditionally and expects host headers to be installed. Can it be behind a feature gate?

Absolutely, I agree with your suggestion.  I'll work on implementing this change. Thanks for pointing it out!


[Apple Notes] ... Search Notes Function - Database Error

Extension
https://www.raycast.com/tumtum/apple-notes
Description
I cannot use the "search notes" feature. I get the following error message and no results ever get shown.

"Database disk image is malformed"
Steps To Reproduce
I'm on a Mac Sonoma 14.2.1 running Raycast Version 1.68.1
I go to the raycast search window and click on "search notes" and I get the error message attached above
Current Behaviour
See Above
Expected Behaviour
I expect it to show me results from my notes in accordance with my search terms.

Got the same issue with a Mac Studio M2 Max, macOS Ventura 13.6.3, Raycast 1.68.1.

Got same issue.

Thanks for bringing this up. It appears that this is a duplicate of issue https://github.com/raycast/extensions/issues/6916, so I'll mark it as such.


Use voluptuous for netio

Description:
Migration of the configuration check to voluptuous.
Related issue (if applicable): fixes 127528299
Example entry for configuration.yaml (if applicable):
switch:
  - platform: netio
    host: <IP_ADDRESS>
    port: 1234
    username: user
    password: pwd
    outlets:
      1: Free
      2: TV
      4: Lamp

@eagleamon, would be nice if you could take a look at the changes and run a quick test. Thanks.

🐬


ROCm Kernel 4k resolution problem

Hey everybody,
I installed new Ubuntu 16.04 on my PC. Then i followed the installation instruction as documented here: ROCm.

After pc restart, I cannot select high resolution. (3840x2160)

OS:   Ubuntu 16.04
GPU: WX 7100
Any idea?

This is a mesa/amdgpu problem

@gstoner I have no amdgpu-pro driver installed.

@reger-men The amdgpu and amdgpu-pro drivers are different. I use the amdgpu drivers from this repository to get everything working for me, but I'm on Vega FE.

ROCm Userland compute components sit on amdgpu Linux driver.    The amdgpu Linux driver supports all of the X11/OpenGL, display logic. you can look at here   https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/tree/master/drivers/gpu/drm/amd
If the issue is in the MesaGL and X11 userland components are part of your distribution, we do not distribute these.      ROCm really is only about GPU Computing solution.   We notify the Linux driver team your having an issue

Here is good article on what going on in AMDGPU from Display perspective  https://www.phoronix.com/scan.php?page=news_item&px=AMD-Open-FreeSync-Planning
https://www.phoronix.com/scan.php?page=news_item&px=AMDGPU-DC-Cleaning-Pre-4.15

I installed ampgpu-pro 17.30, the 4k resolution is supported on kernel 4.10 but not on ROCm kernel 4.11. That mean the ROCm drivers doesn't support 4k, is that right?