Feature request: sidebar without buttons at the bottom of the page

Description
Hi, is there a way to have a sidebar without having the "PREVIOUS" and "NEXT" buttons at the bottom of the page? Thanks a lot for your help, well done for the theme!

You can just remove or comment those lines. It is present in _includes/article-section-navigator.html with the class name article__section-navigator

Thanks!


2FA Detected!

It Says Please try again after switching off 2FA..why turn off 2FA.....can u not just add a 2FA option after login so we can paste the code to verify ??

Hey @ShadmanArafin PRs are welcome, go through the code in getHeader.py and test the riot API and how they take in code to verify.


tests: add various eve payload representation tests

Overlaps and gaps.
https://redmine.openinfosecfoundation.org/issues/6553

replaced by #1493


Add default value for INSTALL_PATH

what

Add default value for INSTALL_PATH

why

On wsl INSTALL_PATH is empty

@dependabot use these reviewers


Monitor flashes black screen

Hi again
I'm back with another problem :/
Like the title suggests I've been having one or both monitors flashing black and then functioning normally. There seems to be no pattern or way to replicate it.
Sometimes there's times where it will flash both monitors multiple times in a minute, other times it will only flash one monitor once without another issue for a while.
I tried recording it but only managed to catch an example of it flashing my built in monitor once. I tried to catch it flashing both but it didn't act up for multiple minutes and I didn't want to waste my phone storage continuously waiting for it to happen again.
https://github.com/MolotovCherry/virtual-display-rs/assets/132479519/7d4d6df4-56ae-432b-a678-b1d9b8daaa40
Edit: new vid
https://github.com/MolotovCherry/virtual-display-rs/assets/132479519/414a737f-173b-4fc6-ac56-ebe1dbffdf7c

It happens randomly. I cannot seem to replicate it. I don't mess with enabling or disabling the display. I turn it on, leave it on, and then it will randomly throw a fit which you can see in the videos I attached earlier.

And it doesn't happen at all when the monitors are disabled?

Nope, only when it is enabled.

Does it happen when running a particular application or type of application (e.g. games), or is that completely unrelated?

Seems unrelated, all I use this laptop for is school and runescape lol

Does it only happen after a long time? Or does that not matter?

It doesn't seem to matter, sometimes I can go hours without anything happening, sometimes it will be really disruptive and flash multiple times a minute

Did the driver log anything of note to the event log? If it's crashing, it'll send a report to the event log

Not a thing :/

Is this a recent development, or did it used to do the same?

It has happened since I first started using this however long ago, I've only thought to write about it after seeing how responsive you are

What monitor settings do you have for the virtual monitors? And what are the settings for them in windows (extended, duplicated, etc)?

1920x1080 60hz Extend

This doesn't happen on my computer (at least, I've never seen it happen before), though I'll leave it enabled and see if it happens to me eventually.
Can you test this on another computer too?

Yeah, I can try my other computer.
If I had to guess, it could be that this laptop has no dedicated gpu? My other computer does, and from what I remember yours does too.
But that's just speculation from someone that has no idea about the development of something like this.

So far its been ~40 mins on my other computer doing the same thing I would be doing. No problems on this computer everything runs just fine. Usually there would've been a hiccup by now. I'm not sure what this means for solving the problem :/

I'm working on seeing what it could be / improving things

@lolKaizen Can you test out this debug driver please? (As usual, uninstall the old one first. Don't uninstall the whole program, just the driver itself)

Yeah I'll try it out, I'll make another comment in ~an hour just so I know for sure what the results sre

Just had the same thing happen again, it seems it didn't fix the issue.

Just had the same thing happen again, it seems it didn't fix the issue.

Hmm, I haven't the slightest clue then. I definitely just fixed what should likely be the last big bug

Are you sure all other drivers are gone? (E.g. using pnputil /enum-devices you can see a list of all of them)

Yeah, I made sure to check before I installed the driver.

I'm using integrated graphics right now just in case, but I don't think that will allow me to reproduce it still. If the issue is one I can reproduce (like the win10 one was), I can debug it to figure it out, (and the one I just fixed), but if I can't reproduce it, it could also be something hardware/software specific to a computer/model which I can't account for

Idk how debugging works, is there any way you can look at my computer to check out what's going on? Might be a silly question, just trying to be of more help.

Is that machine running win10? Even if so though, it should run the same now as far as I know.

is there any way you can look at my computer to check out what's going on?

Not really unfortunately. Debugging is generally a troubleshooting process where one takes educated guesses about what it could be and hopes one of those guesses hits the mark (and maybe with some help from tools). If it's a familiar problem, educated guesses could be more precise. If it's one that's very specific to one machine in a particular configuration (which often ordinarily may not even be a bug in the program, but something that a workaround has to be written for once found). Being able to reproduce it also means I have access to the physical machine and can keep making guesses to see when it stops happening. It's like finding a needle in a haystack with a metal detector, but without the metal detector it's even harder

Is that machine running win10?

Yes, but I've since upgraded to 11
I totally get it, about the debugging. Don't stress yourself out too much with this, I'll try to think of anything else that could be causing this

So would I be correct in assuming it's happening on win11 as well, and it persisted across upgrades?

Yes, it has persisted

I'm going to post an update soon since a big bug got fixed. I have added a portable zip to the release build containing only the files (no installer). Instructions for how to install using that one are on the main page.
When that version comes out, might I ask you to uninstall the program, then install it manually using those instructions?

The portable ?

There will be two zips. One of them looks like this

The portable ?

The file assets will be posted once the build is finished (~10 minutes)
https://github.com/MolotovCherry/virtual-display-rs/releases/tag/v0.2.6

I think I just saw a flash actually 🤔 That's good news at least

Just downloaded the new thing, should I uninstall or just keep it?

I think I just saw a flash

So maybe I was on to something?

Just downloaded the new thing, should I uninstall or just keep it?

I think I just saw a flash

So maybe I was on to something?

Uninstall the current program. The debug drivers have a version based on the build time, so the version always increases every time, so it's best to just get rid of them first when going for release versions

Are you using a built-in intel integrated graphics card?
Yeah, Intel iris xe

@lolKaizen It turns out I made a mistake when I asked you to try the other debug driver. Please try this one. I am pretty sure it fixes the problem

Hey dude, I meant to respond earlier but I got carried away with my studies. That does mean that I have thoroughly tested the driver though, and it seems to work perfectly now. I'll let you know if it ever happens again but if something was wrong, I think I would know by now.

Fixed in 3393d6f4da014010e225cb2f297f156c0d04fd42

Question, do I have to keep this driver installed or will the latest release work?

Question, do I have to keep this driver installed or will the latest release work?

The latest release is still plagued by the bug, but the one you tried isn't. The one you tried is debug however. It'll probably work fine regardless though. But if you make more than 1 monitor, it'll become very laggy. So it is only functional for 1 monitor.

Oh okay, cool. I'm glad I could contribute a little lol

Oh okay, cool. I'm glad I could contribute a little lol

P.P.S. If you want the latest debug release

Hey, I didn't want to make another issue but lmk if I should. My uni gives us access to udemy and I noticed that the DRM makes video playback a black screen when it's shown on the virtual monitor. When I turn off hardware acceleration on my browser it shows fine though.
I'm assuming you can't fix this without knowing how udemy DRM works but I thought I'd ask.

Hey, I didn't want to make another issue but lmk if I should. My uni gives us access to udemy and I noticed that the DRM makes video playback a black screen when it's shown on the virtual monitor. When I turn off hardware acceleration on my browser it shows fine though.
I'm assuming you can't fix this without knowing how udemy DRM works but I thought I'd ask.

That's correct. This is not an easily fixable thing

My most pressing concern right now is simply to have it working properly
Totally understand lol, no worries


Adding orijtech/structslop: Recommends struct field rearrangements to provide for maximum space/allocation efficiency

See https://github.com/orijtech/structslop

That's crazy. Thanks for adding that. 🏍


Update usage of uri() function in WLS on VM offers

Change
Fix the wrong usage of uri() to address #189
Test

Pipelines: Admin, Configured Cluster, Dynamic Cluster
Template: Tested all combinations of DNS(no DNS vs. use existing DNS), SSL(no SSL vs. SSL) and VNET(new VNET vs. use existing VNET)

Signed-off-by: Zheng Chang<EMAIL_ADDRESS>

@rjeberhard I have done the rebase actions on PR#190. It is ready to merge.


Support AsyncIterable?

const results = await.all an_object_that_have_atat_symbol_async_iterator_method

same as
const results = await Promise.all([...await an_object_that_have_atat_symbol_async_iterator_method])

See https://github.com/tc39/ecma262/issues/1909

I think this proposal must be tightly restricted to the exact semantics of the existing combinators.

That makes sense


Error in config_spacy.json file

while training a model there is an issue with config_spacy.json file
error
ValueError: unknown training file format : unk for file config_spacy.json
inside the json file
{
"pipeline":"spacy_sklearn",
"path":".models/nlu",
"data":".data/data.json"
}
please help

Thanks for the question, our Github issue board is for bugs and feature requests only, though 😕
Please ask this question in the forum✨
If you were describing a bug, please create a report and fill out the template


Stop printing rake abort messages on compilation/linking failure

When compilation/and or linking fails, you always end up with a huge rake stack trace that takes way more space than the compiler/linker error message itself.
In my opinion, there is no benefit in having this stack trace for an average user.
I would opt for this stack trace not being there in the default verbosity option.

Hi, @matrdr. Very sorry for this. Are you using version 0.31? The next major version nearing completion is a nearly complete rewrite of logging and exception handling. It's all quite tidy and configurable now.

Yes, I am using 0.31.1.
That would be great if the next release fixes that.
If that is the case, feel free to close the issue again.
Keep up the great work! I am looking forward for the new release!


Rift guardian variant incorrectly identified

I've got a Rift guardian pet that's the blood variant, yet it's identified as the wrath variant (I have 92rc and have never crafted wrath runes). I assume it's just an ID mix-up, but I figured I'd call it out as an issue.
Edit: I think my rift guardian was the wrath variant despite me never crafting wrath runes and having it locked since I got it at the blood altar? Not an issue with this plugin, so I can close the issue, but I'm just confused... menagerie bug?

Weird, but thank you for trying to bring it to my attention, even if it was all sorted in the end!


Circulation solving method in OLAF

Dear all
@ebranlard  @jjonkman
I want to conduct secondary development for OLAF module, especially for the calculation of blade bound circulation. Could you please tell me the specific code location? The large amount of code is a little difficult for me.
In particular, I would like to take van A.Grrel's approach and I would like to know where his approach is applied in OLAF (Aero module).

All I need is the part that iterates to update the bound circulation based on the lift coefficient. (Obtain blade information, give the initial bound circulation, look up the table, calculate the bound circulation, iterate, output the blade bound circulation).
Thank you so much!

Hi @robytian
The iterative for the circulation solving, using the method of van Garrel is found here:
https://github.com/OpenFAST/openfast/blob/dev/modules/aerodyn/src/FVW_Wings.f90#L312
I hope that helps.

Hi @ebranlard
I'd like to ask you a few more questions, which I hope you can answer.
1.Did the code location you gave me last time include this theoretical part? https://openfast.readthedocs.io/en/main/source/user/aerodyn-olaf/OLAFTheory.html#cl-based-iterative-method  Is there any other.f90 needed?
2.Can two tests, "EllipticalWing_OLAF" and "HelicalWake_OLAF", output blade circulation and wake velocity field separately? Or do I need to implement the output by modifying WakeMod[3] in AeroDyn15 with OLAF integration?
3.I don't care about the structure, servo control and other modules given in openfast, I just want to achieve blade circulation calculation and helix wake output, is it possible to select "HelicalWake_OLAF" as a test?
4.If I want to model NREL5MW or IEA15MW, do I have to re-model it in "HelicalWake_OLAF"? Or do you need to model in OPENFAST 5MW_Baseline?
Thank you very much!
Best wishes

Hi,
Here are some answers to your questions:

Yes, the code implements exactly this theory, and the link I provided, form the line I pointed to to the bottom, is the code that implement the iteration algorithm. The most important piece of code that is not in this function is the computation of the Cl as function of angle of attack, AFI_ComputeAirfoilCoefs, which is part of the file AirfoilInfo.f90.
I'm not sure I fully understand your question. AeroDyn can output the circulation along the blade using Blade nodal outputs and the variable Gam. OLAF can output velocity fields using the grid outputs. OLAF is selected using WakeMod=3
Yes, HelicalWake OLAF is a good test case for that. The best, when you only care about aerodynamics is to use the aerodyn driver. You'll find the HelicalWake test case for the aerodyn driver here.
If you want to model a realistic turbine, you'll have to go through the process highlighted in the guidelines. We do not provide OLAF input files for the NREL-5MW or IEA15MW (we might provide those in the future). All the input files you see on the r-test are only example files for testing purposes and are not intended to be used directly.
I hope that helps!

Hi @ebranlard
After several days of simulation and modeling, in addition to the above questions, I also want to consult some other questions, please forgive me.
I modeled 5MW wind turbine according to "ad_HelicalWakeInf_OLAF".The following problems were found:
1.The WakeRegParam shown here in the manual does not exist in the OLAF test. Instead of WakeRegFactor and WingRegFactor, I would like to know what these two parameters should be set to for NREL 5MW wind turbine？
2.Based on the above problems, I want to know how the initial vortex core radius rc0 is calculated?
3.The Regularization parameters here state:
(1)Does WakeRegFactor=0.6 correspond to the formula given here, I wonder which value is multiplied by 0.6? How to understand Deltar is the length of the spanwise station?
(2)Here(Regularization parameters) the manual recommends CoreSpreadEddyVisc=1000 and and here The default value is 100.
4.The calculation of deltat, Ttarget, ntarget,distance
(1)The deltat calculation formula is given here. If I use NREL5MW fan, can it be understood as deltat=1/12.1, and the 5MW turbine default speed is 12.1rpm.
(2)It is pointed out here (Wake length and number of panels) that there is no turbulence simulation ka=1.5, and there is turbulence simulation ka=1. I would like to know how the current test reflects whether my simulation is turbulence simulation or not.
(3)Based on (2), I want to simulate the wake region of 10 times the rotor diameter, then the calculation formula is as follows:
(10×126)/(11.4×(1-ka×a)),right?
(4)ntarget,distance equals Ttarget in (3) divided by deltat in (1) , right?
According to the above calculation,the deltat is 0.083 the total simulation time is about 221s, and ntarget,distance is 2674. However, the calculation will stop at 186s, and the calculation does not reach 10 times the length of impeller. I wonder why?
5.Figure 1 and Figure 2 are completely different results from my two simulations, and Figure 3 is what I want to achieve.I want to know which parameters to adjust in the example to get the perfect helix and velocity field cloud picture.

figure1

figure2

figure3

Hi @robytian
I don't have the time to go into all of your questions in details, but it seems like you are making progress.
1-3  We indeed switched from "RegParam" to "RegFactor" and some places of the documentation needs updating, but they are the same thing, so you can replace "Param" by "Factor" in the definitions of rc here:
https://openfast.readthedocs.io/en/dev/source/user/aerodyn-olaf/InputFiles.html#wake-regularization-and-diffusion-options
Delta r is the distance between two aerodyn nodes.

If your simulation stops at 186s is likely because the .fst file stops at 186s, no? or does the simulation crash?
The python script in the guidelines will help you set the parameters according to the equations of the guidelines.

If you want pure helices, then you can turn off the wake roll up by setting FreeWakeStart  to a very large value. Note that the wake won't be physical, but you'll get the perfect helix if that's what you are after.

I can see that you have nNWPanelsFree to default. You can try to set it according to the guidelines, it will make the end of the wake less "messy".
In Paraview, make sure to "rescale" the range of your colorscale for the velocity and the circulation (Paraview by default will set the range at t=0).
To speed up the computation, you don't need to output the VTK and velocity fields at each time step.
I hope that helps,
Emmanuel

Hi @ebranlard
Recently, I made a comparison on the software using the free vortex wake method. The wind turbine model is NREL-5MW, the wind speed is 10m/s, the rotor speed is 10RPM, the DT is set to 0.1, the total simulation time is 300s, and the panels of nNWPanels are set to 3000, while the rest are not set. It always stops at 113s (Instead of stopping the calculation, the calculation is done), I don't know why.
In addition, this is the velocity field distribution calculated and simulated by me. You can see that the wind speed distribution simulated by OLAF is completely opposite to that of Qblade. In my cognition, Qblade may be more consistent with the velocity distribution. What's the reason, I wonder?
I opened the visualization in paraview and selected the y distribution at x=100m and z=90m.

Here are the parameters I set in OLAF:

Something might be wrong in the postprocessing, because the VTK figure of the wake you showed earlier has a wake deficit in the near wake that makes sense (double hump shape). In Figure 8 of this paper, the wake deficit from OLAF, obtained from the Grid output, are consistent with what you would indeed expect.
The issue is diverging from the original question, so I'll close this issue, but feel free to post a dedicated issue if the problem persists.


[BUG] Create a nightly CI test pipeline for force.caller.classloader=false

Describe the bug
At a handful occasions we needed to resort to setting spark.rapids.force.caller.classloader to the non-default value false as a workaround for bugs. However, we only have a smoke test enabled for this configuration. Without a full test pipeline run against this config we ended up incurring a few regressions over time.
Steps/Code to reproduce bug
Manually run pytest-xdist with pseudo-distributed standalone local-cluster via:
TEST_PARALLEL=2 \
  PYSP_TEST_spark_rapids_force_caller_classloader=false \
  NUM_LOCAL_EXECS=2 \
  ./integration_tests/run_pyspark_from_build.sh -k test_explain_set_config

and observe failures like:
py4j.protocol.Py4JJavaError: An error occurred while calling z:com.nvidia.spark.rapids.ExplainPlan.explainPotentialGpuPlan.
  : java.lang.NoClassDefFoundError: com/nvidia/spark/rapids/GpuOverrides$

full stacktrace

E                       at com.nvidia.spark.rapids.ExplainPlanImpl.explainPotentialGpuPlan(GpuOverrides.scala:4196)
E                       at com.nvidia.spark.rapids.ExplainPlan$.explainPotentialGpuPlan(ExplainPlan.scala:65)
E                       at com.nvidia.spark.rapids.ExplainPlan.explainPotentialGpuPlan(ExplainPlan.scala)
E                       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
E                       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
E                       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
E                       at java.lang.reflect.Method.invoke(Method.java:498)
E                       at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
E                       at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
E                       at py4j.Gateway.invoke(Gateway.java:282)
E                       at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
E                       at py4j.commands.CallCommand.execute(CallCommand.java:79)
E                       at py4j.ClientServerConnection.waitForCommands(ClientServerConnection.java:182)
E                       at py4j.ClientServerConnection.run(ClientServerConnection.java:106)
E                       at java.lang.Thread.run(Thread.java:748)
E                   Caused by: java.lang.ClassNotFoundException: com.nvidia.spark.rapids.GpuOverrides$
E                       at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
E                       at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
E                       at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
E                       at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
E                       ... 15 more

Expected behavior
We should not have exceptions with supported options. Unfortunately, this is one of the options that can't be solved via test parametrization because this needs to be applied before pytest Spark app is launched. More generally it may be an epic to identify more pre-pytest-launch settings like this.
Environment details (please complete the following information)
local-cluster, Standalone cluster anywhere
Additional context
#5646

@gerashegalov Does this issue request to run all the integration test cases with the config PYSP_TEST_spark_rapids_force_caller_classloader=false?

Sorry, I am confused. Is this a bug report or a feature request?
If the latter one, can you elaborate more about the ENVs? like pytest-xdist + local cluster or standalone cluster, can you share the expected commands to test in different scenarios? and do we need to run all IT cases, or just some specific cases for multiple spark shims?
Also we need some detailed ENV combinations to do the resource planning, thanks

@gerashegalov Does this issue request to run all the integration test cases with the config PYSP_TEST_spark_rapids_force_caller_classloader=false?

it should be parametrize at Jenkinks level because we cannot do at the pytest level

Sorry, I am confused. Is this a bug report or a feature request?
bug in a sense that we left this feature without continuous testing and it was broken by later PRs.

If the latter one, can you elaborate more about the ENVs? like pytest-xdist + local cluster or vanilla IT against standalone cluster, can you share the expected commands to test in different scenarios? and do we need to run all IT cases, or just some specific cases for multiple spark shims?
Also we need some detailed ENV combinations to do the resource planning, thanks

Ideally I would like another instance of all tests we have with the ENV PYSP_TEST_spark_rapids_force_caller_classloader=false injected at whatever cadence the capacity allows but not less than weekly frequency.


Please tell me what is the reason for this？

Error occurred when executing ApplyInstantIDAdvanced:
ModelPatcher, object has no attribute 'get model_object
File "F:\ComfyUI-aki-v1.3\ComfyUI-aki-vl.3\execution. pyline 152, in recursive executeoutput data, output ui= get output data(obj, input data allFile "F:\ComfyUI-aki-v1.3\ComfyUI-aki-v1.3\execution. py".line 82, in get output datareturn values = map node over list(obj, input data all, obj.FUNCTION, allow interrupt=TrueFile "F: ComfyUI-aki-vl.3\ComfyUI-aki-vl,3\execution,py", line 75, in map node over listresults.append(getattr(obj, func)(**slice dict(input data al1, i)))File "F:\ComfyUI-aki-v1.3\ComfyUI-aki-vl. 3\custom nodes ComfyUl InstantID\InstantID.py", line 332, in apply_instantidsigma start = model.get model object("model sampling").percent to sigma(start at)
Please tell me what is the reason for this？

I think you need to update comfyui

Thanks，I succeeded


Change "Add multiple to commiittee" to "...users"

Changes the "Add/Remove multiple users to committee" bulk logic in committee list to
"Add/Remove multiple to meeting".

successfully tested


travis.yml: Add git diff check

This check makes sure repo is in a clean state after tests are run,
especially after dep ensure.
git diff --exit-code produces a 0 when there are not git differences.
See #492

LGTM. Can you rebase to the updated master to fix the tests?

Tests were failing due to recent changes, so I added the changed Gopkg.lock file as well. @AlexNPavel PTALA thanks!

lgtm


Render github package docs somewhere

split out from #167
The docs are already present in the readme.md

[ ] detect that docs are requested for a github package, request the markdown content from github and render it

Unfortunately, the packages do not benefit from our snippet rendering, also it is not possible to document individual blocks.
Sent from Outlook Mobilehttps://aka.ms/djubve

From: Michał Moskal<EMAIL_ADDRESS>Sent: Monday, August 15, 2016 8:45:03 AM
To: Microsoft/pxt
Cc: Peli de Halleux; Assign
Subject: [Microsoft/pxt] rander github package docs somewhere (#230)
split out from #167https://github.com/Microsoft/pxt/issues/167
The docs are already present in the readme.md

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/pxt/issues/230, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD-4KWijdU1Zc6vpoq2ReftCafEZf3GZks5qgIl_gaJpZM4Jkfwq.

One solution is to rely on GitHub pages. We could have a PXT command that generates a static web site with pre-rendered markdown files.
Sent from Outlook Mobilehttps://aka.ms/djubve

From: Peli de Halleux
Sent: Monday, August 15, 2016 10:40:01 AM
To: Microsoft/pxt; Microsoft/pxt
Cc: Assign
Subject: Re: [Microsoft/pxt] rander github package docs somewhere (#230)
Unfortunately, the packages do not benefit from our snippet rendering, also it is not possible to document individual blocks.
Sent from Outlook Mobilehttps://aka.ms/djubve

From: Michał Moskal<EMAIL_ADDRESS>Sent: Monday, August 15, 2016 8:45:03 AM
To: Microsoft/pxt
Cc: Peli de Halleux; Assign
Subject: [Microsoft/pxt] rander github package docs somewhere (#230)
split out from #167https://github.com/Microsoft/pxt/issues/167
The docs are already present in the readme.md

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/pxt/issues/230, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD-4KWijdU1Zc6vpoq2ReftCafEZf3GZks5qgIl_gaJpZM4Jkfwq.

@peli - does the recent doc change handle this now?

Not yet for 3rd party packages.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Tom Ball<EMAIL_ADDRESS>Sent: Saturday, April 1, 2017 12:18:13 PM
To: Microsoft/pxt
Cc: Peli de Halleux; Assign
Subject: Re: [Microsoft/pxt] Render github package docs somewhere (#230)
@pelihttps://github.com/peli - does the recent doc change handle this now?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/pxt/issues/230#issuecomment-290941188, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD-4KfQkwtJRJ2_OzaENedGH1w4Y7nqWks5rrqL1gaJpZM4Jkfwq.


ZERO npm dependencies discovered if any npm dependency has an array as a license

Please provide a set of steps on how to reproduce the issue

Create a package.json with the following a package that has a deprecated license:

pause stream for example has 3 million weekly downloads, and a depreacted license it seems.

{
  "name": "tmp",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "pause-stream": "0.0.11"
  }
}

generate the package-lock.json via npm install --package-lock-only

You will see something like the following in the package-lock.json (note the deprecated license evaluated):
requires": true,
  "packages": {
    "": {
      "name": "tmp",
      "version": "1.0.0",
      "license": "ISC",
      "dependencies": {
        "pause-stream": "0.0.11"
      }
    },
    "node_modules/pause-stream": {
      "version": "0.0.11",
      ....
      "license": [
        "MIT",
        "Apache2"
      ],
      "dependencies": {
        "through": "~2.3"
      }
    },
    ....

run syft . in the same directory.

What happened:
✔ Indexed .
 ✔ Cataloged packages      [0 packages]
No packages discovered

This happens even when there are numerous packages in the dependencies. i.e ZERO packages are discovered. Not pause-stream, nor its dependencies, or any other packages specified in package.json/package-lock.json prior to running syft.
What you expected to happen:
I would expect syft to find all the packages regardless of whether the licencse section is deprecated or not (possibly even if it is invalid?)
https://docs.npmjs.com/cli/v9/configuring-npm/package-json#license
Anything else we need to know?:
This is particualrly high importance as this would mean syft misses all of the npm dependencies if only one is "misformatted". No error is raised, only a warning when running in verbose mode.
WARN cataloger failed cataloger=javascript-lock-cataloger error=failed to parse package-lock.json file: json: cannot unmarshal array into Go struct field lockPackage.Packages.license of type string location=/home/[...redacted...]/package-lock.json

Happended for lockfileVersion: 2 however believe it occurs for version 1 and perhaps 3. Additioanlly there are likely many similar ways to cause 0 packages to be discovered. (make the unmarhalling step fail).
Environment:

Output of syft version: 0.62.1 (same with latest)
OS (e.g: cat /etc/os-release or similar):

Updated the title to reflect that its not just "deprecated" syntax but modern sytax can also be effected.
syft expects the license to always be a string but it could (valid) be evaulated as an array.


Update documentdb-sdk-python.md

Add summary about this new 1.6.1 release and updating necessary fields.

Hi @rnagpal, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (rnagpal). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@mimig1 - reviewing

#sign-off

@cjgronlund


Swipe-to-go-back with pointer event changes

@manu can you take a look at your recent changes to pointer events? Noticing swipe-to-go-back in a nav inside of a tab isn't working.

Is this related to #7934 ?

@apparition47 nop! #7934 is a different one


Indention bug in else statement of torch connector.

Information

Qiskit Machine Learning version:
Python version:
Operating system:

What is the current behavior?
There is an indentation error on line 166 of the torch connector.
Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

@nonhermitian What is wrong with indentation in this code? Looks good to me.

The issue originates from someone other than myself so I cannot say. However it seems that one of the statements is not nested at the correct level and causes issues when actually using the module.

Well, it is supposed to be an if - elif - else statement. So, it is unclear where indentation is wrong. Do you have any other details of the issue or know who originally raised this issue?

Sorry they reported it a bit further down.

I see, the selected part looks good to me either. So, are there any actual problems with the torch connector e.g. wrong results?

Please just close this issue. I will ask the original authors to post a new issue themselves.

OK, thanks.


Styling issue on embedded Ember lists

See image below - the colouring of the header on an embedded Ember list page is not quite right - the last column has a white space next to it, not grey - in the example, to the right of the created column.

Closing - fixed - QA have tickets which cover the same issues identified here


CI Testing - Simulide

Description of changes
This PR is only for testing

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg  eval

@ofborg eval

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide

@ofborg build simulide


Update opentelemetry demo

I don't think we need this one right? Closing. Feel free to re-open if necessary.


[ux] slight's version command is either long or LARGE V

Describe the solution you'd like
OMG is this the only command on the planet with a -V for version as opposed to -v, which saves the pinky from having to hit an extra key?
Additional context
Options:
-c, --config
-h, --help             Print help

We use clap for command argument parser for Slight CLI and it defaults to -V for version. It looks like their decision to use -V instead of -v is because many programs use lower case -v for verbose and capital -V for version.
If you prefer -v for version, I can certainly change that!


Add a tool to change a volume's ttl setting.

I need a tool to change a volume's ttl setting. Could you please help me, thank you very much

coming soon

Hello! Have you added opportunity to change TTL?


Plot undirected graph route correctly

Plotting the route in an undirected graph fails because the geometry of the edge is always in a certain direction.
For example:
import numpy as np
import osmnx as ox
from matplotlib import pyplot as plt

place = "Piedmont, California, USA"
G = ox.graph_from_place(place, network_type="drive")
G_undirected = ox.get_undirected(G)

# print route
orig = list(G_undirected)[0]
dest = list(G_undirected[120]
route = ox.shortest_path(G_undirected, orig, dest, weight="length")
fig, ax = ox.plot_graph_route(G_undirected, route, route_color="y", route_linewidth=6, node_size=0)

This results in the following image:

However, with the proposed changes the route is plotted like this:

I was thinking of creating a different for loop for nx.MultiGraph objects but the proposed if statement (here) seems a bit cleaner to me. It would only check the second condition if the the graph is an nx.MultiGraph.
if not G.is_directed() and G.nodes[u]["x"] != data["geometry"].coords[0][0]:

Let me know if you think this would be useful or if you have any suggestions.
-Andres

I made a new branch with just one commit that includes all the tests as that seems a bit cleaner.  I can close this request and make a new one with that branch if you prefer.

Yes, would you close this one and open a PR with that new branch? I'll take a look at what you did there. Thanks.


[Part2] Added ImagePullSecrets to SidecarInjectionSpec

This PR updated the test cases related to SidecarInjectionSpec.
Fixed https://github.com/istio/istio/issues/4870
/cc @ayj @yusuoh @linsun

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
Assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyliu513: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
696a983b2d2ee7127c0f8158163f1a2b48a11af9
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
696a983b2d2ee7127c0f8158163f1a2b48a11af9
link
/test istio-unit-tests

prow/istio-presubmit.sh
696a983b2d2ee7127c0f8158163f1a2b48a11af9
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
696a983b2d2ee7127c0f8158163f1a2b48a11af9
link
/test istio-presubmit

prow/istio-unit-tests.sh
58a1190986db11c1fb3755081ae005b9a0d7a53a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
58a1190986db11c1fb3755081ae005b9a0d7a53a
link
/test istio-unit-tests

prow/istio-presubmit.sh
58a1190986db11c1fb3755081ae005b9a0d7a53a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
58a1190986db11c1fb3755081ae005b9a0d7a53a
link
/test istio-presubmit

prow/istio-unit-tests.sh
b142e585ab6a187cf077025f2d5ec268646d4c06
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b142e585ab6a187cf077025f2d5ec268646d4c06
link
/test istio-unit-tests

prow/istio-presubmit.sh
b142e585ab6a187cf077025f2d5ec268646d4c06
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b142e585ab6a187cf077025f2d5ec268646d4c06
link
/test istio-presubmit

prow/istio-unit-tests.sh
23234e4138023389da28eb406b8087d76bd1eee4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
23234e4138023389da28eb406b8087d76bd1eee4
link
/test istio-unit-tests

prow/istio-presubmit.sh
23234e4138023389da28eb406b8087d76bd1eee4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
23234e4138023389da28eb406b8087d76bd1eee4
link
/test istio-unit-tests

prow/istio-presubmit.sh
fbb00cd89f8d11c4e1341e1b96e061741c42f3a5
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
fbb00cd89f8d11c4e1341e1b96e061741c42f3a5
link
/test istio-presubmit

prow/istio-unit-tests.sh
fbb00cd89f8d11c4e1341e1b96e061741c42f3a5
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
fbb00cd89f8d11c4e1341e1b96e061741c42f3a5
link
/test istio-presubmit

prow/istio-unit-tests.sh
43716f9d1ca4aededb2157d30320fb834ce1b2a0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gyliu513: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
43716f9d1ca4aededb2157d30320fb834ce1b2a0
link
/test istio-unit-tests

prow/istio-presubmit.sh
43716f9d1ca4aededb2157d30320fb834ce1b2a0
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
Assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj seems ci/circleci: e2e-pilot-noauth-v1alpha3-v2 failed, can you help re-run the test?

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, yusuoh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ayj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Issue when clicking search button on keyboard

Search is working but when we press search button from keyboard it shows null issue. Screenshots are attached

maybe it will help https://github.com/yshean/google_places_flutter/issues/2


Find correct visual_delivery_shift_correction for dataset 3

@neukym doing as part of #291

Completed as part of #290, tested and confirmed to mimic previous results.


Tree Indent Guides are misaligned with its parent drop down arrow

Issue Type: Bug
When the tree indent guides are enabled ("workbench.tree.renderIndentGuides": "always"), they look misaligned with the parent drop-down arrow on top.

As a user I would expect the indent guide line to be aligned to the center of the parent drop-down arrow.
VS Code version: Code 1.58.0 (2d23c42a936db1c7b3b06f918cde29561cc47cd6, 2021-07-08T06:53:55.113Z)
OS version: Linux x64 5.12.14-arch1-1
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4000)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
31.31GB (28.55GB free)

Process Argv
--no-sandbox --unity-launch --crash-reporter-id d82b6845-3d72-4a6f-981c-3dbee67a3d78

Screen Reader
no

VM
0%

DESKTOP_SESSION
undefined

XDG_CURRENT_DESKTOP
undefined

XDG_SESSION_DESKTOP
undefined

XDG_SESSION_TYPE
tty

Extensions: none

If this is by design then by all means close this issue, it looks weird to me.

Yeah, looks weird for me too. It feels, wrong.

Unfortunately this is by design: moving the guide only a pixel to the right will make it overlap with some icons. The rule is: the twistie and the indent guides aren't meant to be aligned. It is not meant to be this:


Issue#210

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[✔ ] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
[✔ ] Make sure you are making a pull request against the dev branch. Also you should start your branch off dev branch.
[ ] Check you have added tests that prove your fix is effective or that your feature works.
[✔ ] Check your code additions will fail neither code linting checks nor unit test.
[ ] Check you added any notable changes to the CHANGELOG.md file.

Description
added delete comment action and check again comment policy

@imknight also add tests for backend code, check tests for delete task here, it'll be similar

noted, will follow up with test tomorrow.

Codecov Report

Merging #264 into dev will decrease coverage by 0.35%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##                dev     #264      +/-   ##
============================================
- Coverage     79.06%   78.71%   -0.36%
- Complexity      223      232       +9
============================================
  Files            81       82       +1
  Lines           731      747      +16
============================================
+ Hits            578      588      +10
- Misses          153      159       +6

Impacted Files
Coverage Δ
Complexity Δ

app/Providers/AuthServiceProvider.php
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

app/Http/Controllers/CommentController.php
100% <100%> (ø)
5 <1> (+1)
:arrow_up:

app/Policies/CommentPolicy.php
33.33% <33.33%> (ø)
7 <7> (?)

app/Models/Comment.php
100% <0%> (ø)
3% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d3e15...b45b0cd. Read the comment docs.


Do not send replication message if there is no changes or events

Since the sending system is now visible to events, I had to change the visibility of some structures to crate.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9b96589) 88.77% compared to head (99d9212) 87.37%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   88.77%   87.37%   -1.41%
==========================================
  Files          14       14
  Lines         855      871      +16
==========================================
+ Hits          759      761       +2
- Misses         96      110      +14

Files
Coverage Δ

src/network_event/server_event.rs
92.85% <100.00%> (-2.08%)
:arrow_down:

src/server.rs
97.37% <100.00%> (+0.09%)
:arrow_up:

src/server/despawn_tracker.rs
64.70% <ø> (-35.30%)
:arrow_down:

src/server/removal_tracker.rs
80.00% <ø> (-20.00%)
:arrow_down:

src/server/replication_buffer.rs
99.13% <100.00%> (+0.02%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Filter scanlators by priority

Describe your suggested feature
TLDR: User can set up which scanlators he prefers over others. If first priority is not available, it would fallback to the second. If not, than third. And so on.
For example there is a manga with following chapters:

ch. 1, group A
ch. 2, group A
ch. 2, group B
ch. 2, group C
ch. 3, group B

Current implementation (#8803) allows to filter out only whole groups from manga, so user would end up without chapter 1 or without chapter 3.
With priorities the user can select that he prefers groups in specific order, for example A > B > C. Then the filter would show each chapter only once like this:

ch. 1, group A
ch. 2, group A
ch. 3, group B

Other details
This is basically copy-pasted issue from here https://git.mihon.tech/tachiyomi/tachiyomi/issues/8804
Related:
https://git.mihon.tech/tachiyomi/tachiyomi/pulls/8803
https://git.mihon.tech/tachiyomi/tachiyomi/issues/969
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

#777 is right there? Closing as duplicate.


Hardiness zones

Pull Request Checklist:

[x] This PR addresses an already opened issue (for bug fixes / features)

This PR addresses part of #1290

[x] Tests for the changes have been added (for bug fixes / features)

[x] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] CHANGES.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Adds the Hardiness Zones index with options for both Australian and USDA classifications
Adds separate indicators for each classification scheme.

Does this PR introduce a breaking change?
No.
Other information:

Currently,  70degF for USDA et  20 degC for anbg are not included in last zone, because bins are closed on left and open on right. Should I hack things so that the very last bin is also closed on the right or leave things are they are?

Also, angb zones were noted with half-integers in the previous code, but looking at https://www.cpbr.gov.au/gardens/research/hort.research/zones.html, I see 7 zones of 5 degC, noted 1,2,...,7. Not sure if I missed something?

Currently, 70degF for USDA et 20 degC for anbg are not included in last zone, because bins are closed on left and open on right. Should I hack things so that the very last bin is also closed on the right or leave things are they are?

If we want to follow the definition closely, it would be good to close them.

Also, "angb" zones were noted with half-integers in the previous code, but looking at https://www.cpbr.gov.au/gardens/research/hort.research/zones.html, I see 7 zones of 5 degC, noted 1,2,...,7. Not sure if I missed something?

No, there were just a lot of problems in my code. Sorry!

In get_zones,   zone_min, zone_max and step_size could have conflicting values if (zone_max - zone_min)/step_size is not a integer. Should I raise an error, or give a warning and extend zone_max?


Events added for foundrySwap functionality

@salmanferrum please review

@SibghatUllah1997 please resolve the conflicts. Then @salmanferrum please review and approve


DRF 3 changes HttpRequest to Request

When I do registration, one exception raise as follow:
add_message() argument must be an HttpRequest object, not 'Request'.

The upper level code related to django-rest-auth is at /rest_auth/registration/views.py#L27
def form_valid(self, form):
    self.user = form.save(self.request)
    return complete_signup(self.request, self.user,
                           app_settings.EMAIL_VERIFICATION,
                           self.get_success_url())

And add_message in django will check request object:
if not isinstance(request, HttpRequest):
    raise TypeError("add_message() argument must be an HttpRequest object, "
                    "not '%s'." % request.__class__.__name__)

but docs from drf says:
Note that due to implementation reasons the Request class does not inherit from HttpRequest class, but instead extends the class using composition.

Related stackoverflow thread:
http://stackoverflow.com/questions/27456273/using-django-message-framework-with-rest-framework
I will make a pull request if you guys are going to support drf 3.0.

@mateusz-sikora when will this issue be fixed? I would like this to be fixed ASAP, since I do have an urgent client requirement. Moreover, if its not getting fixed soon, what are the possible work around?

@jayakrishnandingit you can fork this project to your account, make fix there and use your version.
after that you can create a pull request to this project.

@schemacs @jayakrishnandingit fix for this issue is in place


gulp --tasks-simple command never finishes

Before you open this issue, please complete the following tasks:

[x] use the search bar at the top of the page to search this repository for similar issues or discussions that have already been opened.
[x] if you are looking for help from the gulp team or community, open a discussion.
[x] if you think there is a problem with the plugin you're using, open a discussion.
[x] if you think there is a bug in our code, open this issue.

What were you expecting to happen?
.\node_modules\.bin\gulp.cmd --tasks-simple should finish.
What actually happened?
The command never finishes
Please give us a sample of your gulpfile
// gulpfile.js
var gulp = require("gulp");
var htmlGlob = ["src/index.html", "./favicon.ico"];
gulp.watch(htmlGlob, () => {}) // <-- This line makes "Fetching build tasks" never complete

Terminal output / screenshots
PS C:\Users\birger.pedersen\test\ts> .\node_modules\.bin\gulp.cmd --tasks-simple

Please provide the following information:

OS & version [e.g. MacOS Catalina 10.15.4]: Windows 10
node version (run node -v): v14.0.0
npm version (run npm -v): 6.14.4
gulp version (run gulp -v):  CLI version: 2.3.0, Local version: 4.0.2

Additional information
How to reproduce:

Open powershell or cmd
cd to some folder
Run npm i gulp
Create this file

// gulpfile.js
var gulp = require("gulp");
var htmlGlob = ["src/index.html", "./favicon.ico"];
gulp.watch(htmlGlob, () => {}) // <-- This line makes "Fetching build tasks" never complete

Run .\node_modules\.bin\gulp.cmd --tasks-simple

Because of this bug, VSCode never completes fetching build tasks in my project.

Of course it doesn't complete, you have a watcher running and holding the process open. That's why watchers need to either be in conditionals or inside a task.

Thanks for your help


Fix [Docs] Sistent Page Bugs - Text and Link errors #11553

Notes for Reviewers
This PR fixes #11553
Signed commits

[x] Yes, I signed my commits.

Have made the necessary updates to the import code, Button variant and "How to use Sistent tokens/theme" link.

🚀 Preview for commit f6009292a3af375f8bff79fd9479b5a1a61258d5 at: https://66d07906ceea5c179c83ab8a--meshery-docs-preview.netlify.app

🚀 Preview for commit 1bd8b7338a9abcfacf726d7029844c5d21b4a477 at: https://66d07b92ceea5c1a6583a843--meshery-docs-preview.netlify.app

good work @kaushiktak19 🚀

Thanks @sudhanshutech


grafana: 6.6.2 -> 6.7.0

Motivation for this change
https://github.com/grafana/grafana/releases/tag/v6.7.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This change is

@GrahamcOfBorg test grafana


ENH: check consistency of rc status on sequences when making new containers

Summary by Sourcery
Check and enforce consistency of sequence strand orientation when creating new sequence containers. If sequences have mixed reverse complement status, drop annotations and issue a warning. Add a test to ensure annotations are dropped in such cases.
Enhancements:

Ensure consistency of sequence strand orientation when creating new sequence containers by checking if all sequences are reversed or not.

Tests:

Add a test to verify that annotations are dropped when input sequences have mixed reverse complement status.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

11 of 15 (73.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.008%) to 92.13%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/cogent3/core/new_alignment.py
11
15
73.33%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.008%

Covered Lines:
33748

Relevant Lines:
36631

💛  - Coveralls


Update App Toolkit 0.2.0 Documentation to be more consistent

What this PR does / why we need it
Updates the docs for App Toolkit to follow TAP convention

Good catches, thanks @seemiller !


Use fromJSON instead of JSON literal in contains

Fixing https://github.com/Expensify/Expensify/issues/157916
Follow-up testing https://github.com/Expensify/Expensify.cash/pull/2329
Failed workflow run: https://github.com/Expensify/Expensify.cash/actions/runs/840029501
Why do I think this will work? Random comment from this thread

🚀 Deployed to staging in version: 1.0.43-9🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.44-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Shared Computer Activation and License Token Roaming Issue

License token roaming doesn't appear to be working as it is outlined above.  I have an office configured with 5 systems in Shared Computer Activation Mode along with License Token Roaming.  Per the article, I configured the following 3 Registry keys on each system: Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Office\ClickToRun\Configuration
SCLCacheOverride = 1, SharedComputerLicensing =1, and SCLCacheOverrideDirectory = \XYZServer\OfficeLTR%Username%
I log into PC #1, open Word and activate Office 365 as I have not activated these on any of the systems pointing to the override directory, I even see the creation of the text files {randomCharacters}.authstring and {randomCharacters}.signingCert once activated on system 1.
I then log into PC #2, open word, I get prompted to Activate!  This is not a VDI scenario but we don't want the extra prompts to activate on the other system.  When I check the network location, where the files should be getting created, the previous .authstring and .signingCert files have been renamed to .authstring.txt.previous and .signingCert.txt.previous and I get prompted to activate Office which defeats the purpose of this configuration.  This is not a VDI scenario, but is similar in that we can't have the shared computers keep prompting the users to activate just because they logged into a different system.  They should be able to log into 1 of the 5 systems, activate office 365 and it not prompt to activate on the other 4.  I understand, if it expired, but this is not working in a test where I am literally logging into one, signing out and then logging into the other.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ab31873-7ad3-afde-3c72-8a7fb4f2e551
Version Independent ID: 19f7f483-9f53-f577-1cd4-d360c0b234fc
Content: Overview of shared computer activation for Office 365 ProPlus
Content Source: DeployOffice/overview-of-shared-computer-activation-for-office-365-proplus.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

I have the same problem. RDS solution, 6 RDS servers and around 80 users. However my shared folder only contains 4 files...
Some users are unable to activate office.

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Office\ClickToRun\ is for App-V by the look of it. Have you set it in Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Office\16.0\ ?

We gave up on the License Token Roaming and just went with a full install\offline version of office for those systems.  Mainly due to the way the environment was setup and configured.


Traceback

Exception in thread Thread-1:
Traceback (most recent call last):
  File "threading.pyc", line 810, in __bootstrap_inner
  File "threading.pyc", line 763, in run
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/ui/windows/notification.py", line 20, in __init__
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/ui/windows/notification.py", line 74, in get_updates
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/update.py", line 25, in all
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/update.py", line 39, in _fetch_updates
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/extension.py", line 66, in should_update
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/extension.py", line 58, in is_current_version
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/lazy_property.py", line 15, in __get__
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/github/repository.py", line 35, in version
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/lazy_property.py", line 15, in __get__
  File "/Users/jeremiehornus/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/github/repository.py", line 46, in extension_path
AttributeError: 'NoneType' object has no attribute 'get'

Can you try installing Mechanic again directly from the Install tab, and confirm that the traceback doesn't occur (after restarting RF)? If you get a warning instead, can you also please share the output?

Just did that. It works fine now. Thanks very much :)

Did you get a warning instead of the traceback? I'm trying to pinpoint if there are any extensions that might be configured incorrectly, which would cause an error at this point in the program.

Yes I did get some warnings about some extensions (word-o-mat, curve equalizer, etc.) but did not copy them in time.
Now I cannot reproduce them.

OK, that means it's OK. :)
I'm going to close this issue, but reopen if you see any additional problematic output.

2015-02-17 19:20:42,479 - Mechanic - WARNING - Couldn't get information about Arrange Windows.roboFontExt from typemytype/RoboFontExtensions
2015-02-17 19:21:08,481 - Mechanic - WARNING - Couldn't get information about AdjustMetrics.roboFontExt from FontBureau/fbOpenTools
2015-02-17 19:21:12,473 - Mechanic - WARNING - Couldn't get information about AddOverlap.roboFontExt from asaumierdemers/AddOverlap
2015-02-17 19:21:13,985 - Mechanic - WARNING - Couldn't get information about word-o-mat.roboFontExt from ninastoessinger/word-o-mat
2015-02-17 19:21:16,809 - Mechanic - WARNING - (Probably) Couldn't fetch the GitHub file tree for gferreira/hTools2
2015-02-17 19:21:19,147 - Mechanic - WARNING - (Probably) Couldn't fetch the GitHub file tree for gferreira/hTools2
2015-02-17 19:21:36,241 - Mechanic - WARNING - (Probably) Couldn't fetch the GitHub file tree for gferreira/hTools2


Add ts declaration file

There are a lot of ways to go about this, but the easiest to to just write the file since this project is so small!

Should close https://github.com/ashvardanian/SimSIMD/issues/47

Do you by any chance know, why NPM publish action fails in CI, @sroussey? The CI fails, but the error isn't informative, and it doesn't happen when I push from my machine.

Did I change that? I have separate branch for those changes, but it's not ready yet. Thought I can cherry pick them.

No, @sroussey it started happening long before you joined the project, but I haven't resolved it yet.

I’ll have a look

:tada: This PR is included in version 3.6.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Prevent ducalis from adding duplicate comments in PR reviews

Subj.

@alex-kovshovik can't reproduce. I added test coverage forDucalis::Commentators::Github class in #113 to prove that it works as featured. Feel free to reopen this issue and provide more details in case if it still happens for you

Ok, important part that it's necessary to have more than 30 comments per PR to reproduce it.

#118

Ah, perfect - thanks for fixing!


Confirm nullable fields with defaults are OK or not

They are OK as long as the app-side is consistent with the db-side. Need to implement "DEFAULT" DDL logic.


Allow --ip and --mac to be set when joining a CNI net

These only conflict when joining more than one network. We can still set a single CNI network and set a static IP and/or static MAC.
Fixes #4500

I'll add a test after lunch

LGTM
remote prune test died, I expect unrelated to this change.  I restarted.

LGTM

@mheon Reminder on Tests.
Looks like the CI system is hung.

Added a test

Some test failures are (wierd) flakes, but it seems like --ip with --net $CNINETWORK is not working. I'm passing the right things into OCICNI, so the problem has to be there.

This does not work,
network.RuntimeConfig = map[string]ocicni.RuntimeConfig{
defaultNetwork: rt,
}
is always set to the "podman" netconf, so the static allocations do not get applied.
The problem is that defaultNetwork = r.netPlugin.GetDefaultNetworkName() returns "podman" instead of the user provided value.
Ugly hack I'm using to set defaultNetwork:
if len(networks) == 0 {
defaultNetwork = r.netPlugin.GetDefaultNetworkName()
} else {
defaultNetwork = networks[0]
}

Good catch - pushed an updated version that should set that properly

It's green.
@vrothberg @baude @TomSweeneyRedHat @rhatdan PTAL

LGTM

/lgtm


Expose iOS gesture recognizers publicly to allow for modification

Currently the gesture recognizer chain is internal and no reference to them is maintained, which makes it difficult to either disable or override certain behaviors. Implementing developers may for example want to disable simultaneous gesture recognition or setup dependency chains so if a pinch gesture is recognizing we shouldn't go into a shove or a pan. We should maintain publicly accessible references to the gesture recognizers to allow for this.
https://github.com/tangrams/tangram-es/blob/master/platforms/ios/src/TangramMap/TGMapViewController.mm#L531
There are probably some sensible defaults to setup for this as well. Open to thoughts on that.

Resolved via #1550.


V1.0.4

Coverage increased (+0.4%) to 91.473% when pulling 7c82844cba3b989ce4792d1f100db3ac3d4b269e on v1.0.4 into ffc922af15fa81b7b0f53d7024745a894d63bdc1 on master.


Design: How are we going to build etcd Operator for multi-cluster

I was thinking about this recently but how will we run an etcd Operator across multiple Kuberenetes clusters? A few ideas:

Teach the Operator to be aware of multiple clusters. The etcd.cluster object would essentially have a list of clusters and service accounts

Work with upstream to add a way for the Federation API to give services service account to clusters

Try and use the Federation API to send replica sets to the individual clusters that manage a replicaset of 1 and sort out storage, etc.

The potential users of this multi-cluster etcd would be the Kubernetes federation API and potentially Dex.

This may help: https://github.com/admiraltyio/multicluster-controller
Please let me know if you have any questions.


Add ServiceCollection extension overload accepting options

@Eilon

:-1: This doesn't make sense to do for directory browser when none of the other middleware in this repo can be configured this way.

@Tratcher The idea of this change was to provide an overload to configure options if there is an extension on IServiceCollection. That said this was the only middleware having an extension...so should this be deleted entirely?

This is the only middleware that requires services. Don't remove it.

Hmm I talked to @Tratcher and this might indeed be a case where it doesn't make as much sense to have this overload. I don't think it's super wrong, but perhaps not too useful, and might even reduce the usability of the API. In the case of directory browser it turns out you should call https://github.com/aspnet/StaticFiles/blob/dev/src/Microsoft.AspNetCore.StaticFiles/DirectoryBrowserExtensions.cs#L56 to set the options.

:up: :date:

:shipit:

f202f5b7b3a4763f212722c79aaf4945f2a3c676


New/pending review/reviewed flag?

Here's another one that I may be overthinking: But what about a workflow for studies that shows them as newly brought in from ClinicalTrials.gov and pending review, or the opposite, a flag where I could manually mark studies as reviewed/OK?
I'm trying to figure out how to best manage new stuff coming in, and while we're asking departments to keep us apprised as they can, that helps more with making sure things ARE listed that should be, but not so much with making sure things AREN'T listed that shouldn't be, you know?

I think this is a good idea.  Right now, in the admin area you can search for a study but there is no way to sort by "last updated".  As stated above, it would be a lot easier to manage as new studies are created/updated.  There are "created_at" and "updated_at" fields in the database so I don't think this would be difficult to implement.

Cool! I know I'd find it helpful.


IGNITE-5966 IgniteCache#get() fails with "Requesting mapping from grid failed" when deserialising binary object loaded from CacheJdbcPojoStoreFactory

The ticket is resolved, closing PR. Feel free to reopen if it is needed.


Sharp sometimes create pixilated zoom images after resizing

Before:

After:

Why is the after image so pixilated and zoom? It seems to happen randomly when Sharp application is under the load.

@hybmg57 can you elaborate what was the issue and fix ? I have a similar problem :(
thanks in advance

@sylvainlegault my issue was that I was loading too many images at once causing instance resources to max out.

@hybmg57 thanks a lot, I will look if this is the cause here too.


Support 2018-style macro imports

This example from the crate-level docs, in 2018:
[dependencies]
slog = "2.3"
slog-async = "2.3"
slog-term = "2.4"

use slog::{o, Drain};

fn main() {
    let decorator = slog_term::TermDecorator::new().build();
    let drain = slog_term::FullFormat::new(decorator).build().fuse();
    let drain = slog_async::Async::new(drain).build().fuse();

    let _log = slog::Logger::root(drain, o!());
}

As of rustc 1.30.0-nightly (33b923fd4 2018-08-18) I receive the following error:
error: cannot find macro `kv!` in this scope
 --> src/main.rs:8:42
  |
8 |     let _log = slog::Logger::root(drain, o!());
  |                                          ^^^^
  |
  = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

I naively thought that: https://github.com/slog-rs/slog/commit/9a14db2d7bbcb7c28c37614d793427951a398dbd would do the job, but there were problem https://github.com/slog-rs/slog/issues/176 and I did not have time to deal with it, so I reverted.
If someone is willing to pick it up and carry the torch, I'm all for it.


Make install-npm non-root compatible

And deprecate install-tool + npm, pnpm, yarn, lerna?

install-npm is now non-root compatible, i won't deprecate the tools, the install-npm now uses the specific tool installer for know tools:

npm
pnpm
yarn
lerna


Unable to compile glsl into version 330 - Unknown identifier 'binding' in layout

Since the last krafix update, it's no longer possible to target glsl #version 330.
#version 330
#ifdef GL_ARB_shading_language_420pack
#extension GL_ARB_shading_language_420pack : require
#endif

layout(binding = 0) uniform sampler2D gbuffer0; // <- ERROR: 0:7: Unknown identifier 'binding' in layout
layout(binding = 1) uniform sampler2D tex;

Before the update (9b3cf9d868c8d4c8cf46a62bc12c75f2fe0385a1):
#version 330
#ifdef GL_ARB_shading_language_420pack
#extension GL_ARB_shading_language_420pack : require
#endif

uniform sampler2D gbuffer0;
uniform sampler2D tex;

Yay!


microlens 0.4

microlens-<IP_ADDRESS> depended on by:

morte-1.4.1 (>=<IP_ADDRESS> && < 0.4). Gabriel Gonzalez<EMAIL_ADDRESS>@Gabriel439
patches-vector-<IP_ADDRESS> (>=0.2 && < 0.4). Liam O'Connor<EMAIL_ADDRESS>@liamoc

Fixed in patches-vector-<IP_ADDRESS>

@DanBurton: Both affected packages have had their constraints bumped, so 54f6852 can be reverted now.

:+1: sweet! It's @snoyberg's week so I'll let him handle that.


[bug]: Canvas pencil shortcuts

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
8
What version did you experience this issue on?
3.2.0RC3
What happened?
Hello!
for me the shortcuts for resizing the brush tool stop working in WebUI --> Unified Canvas when I switch from base to mask and vice versa.
This is just a little issue but would speed up the process if it would work.
Feel free to contact me!
Screenshots
No response
Additional context
No response
Contact Details
No response

Hmm, I am unable to replicate this issue. Would it be possible to share a video?

Hi @StefanTobler,
when you open the canvas and choose base or mask and use the shortcuts (ü/* on german keyboard) for changing the size of the tool you have to klick once till you can change the size with the shortcut keys.

choose mask
use the shortcut to resize the tool
change to base
use the shortcut to resize the tool (shortcuts dont work)
click once with the mouse
shortcut will work

Normally it should work without click.
https://github.com/invoke-ai/InvokeAI/assets/82087345/d57683cd-5810-47ff-a1a6-0d0134594fbc

What I've seen happen with this using the keyboard shortcuts at any rate is that it acts like you're typing [ and ] in the Layer name field.  That field seems to have the focus, which is why the shortcuts aren't making it to the canvas tool.

This is expected, you cannot use keyboard shortcuts in a field that allows character inputs of the same type.


[Accessibility]A11y_VSCode_ViewSearch_Keyboard: Tooltip is not visible to keyboard only users but only visible on mouse-hover.

Environment Details:
VSCode Version : 1.23.1
OS Version : Win10
Additional Details:
MAS Violated : MAS 2.1.1 , MAS 1.1.1
Repro Steps:

Launch VS Code.
Navigate to Activity Bar and select "Search"(Cntrl+Shift+F) button.
Navigate to "Match Case" , "Match Whole Word" , "Use RegEx","Use Exclude settings and Ignore Files" , "Replace All" comboboxes and "Refresh","Collapse All" and "Clear" buttons using "Tab".
Also, mouse hover on all above mentioned comboboxes.

Actual:
Tooltip information is not available for keyboard only users for "Match Case" , "Match Whole Word" , "Use RegEx","Use Exclude settings and Ignore Files","Replace All" comboboxes and "Refresh","Collapse All" and "Clear" buttons which is available on mouse hover.
Expected:
Tooltip information should be made available for keyboard only users which is available using mouse.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
The keyboard only users will not be able to gain information regarding few controls present on screen which is only avaiable using mouse hover.
MAS Reference:
MAS 2.1.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
MAS 1.1.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={d2d2051f-bdc8-4af7-8e18-38aae867e216}
Attachment For Reference:
A11y_VSCode_ViewSearch_Keyboard_Tooltip.pptx
Does this issue occur when all extensions are disabled?: Yes

Dup of https://github.com/Microsoft/vscode/issues/52016


Add negotiator argument & reason to close

This PR adds the possibility to hook into the Websocket Handshake by providing a negotiator themself through the constructor, it also adds the reason to the close event and removes the close exception (close codes >= 2000 are by definition NOT errors).

@mbonneau ping

@CharlotteDunois I agree with the close code update, but what is the reason that the Negotiator needs to be injected?

@mbonneau I need to be able to read the HTTP headers and don't initiate a websocket upgrade at all when the HTTP request is no good.

@CharlotteDunois Because this is middleware, would it be more appropriate to take care of authentication before the WebSocketMiddleware is even invoked?

@mbonneau That might work for my use case, but there are other uses where being able to inject a negotiator would improve the usability of this middleware. Others might have a very optimized handshake process for their application and being able to inject a custom negotiator will allow them to use this middleware as base for a websocket server, instead of having to re-implement the same thing over again.
In the end I don't see much damage being done in being able to inject a negotiator, even though it might be unused for most use cases.


Increase max-width for image

Mobile screens such as. moto g4, pixel 2 etc. didn't show the image properly

Before (moto g4):

After:

No problem!


fix Use robust logic to check there is no multipart upload for Azure

Proposed changes

Azure has no logic for multi part load's upload id. We should use one robust way to check it.

run buildall

run buildall


Error: The requested resource /Services/undefined was not found

When trying to save the configuration from https://xxx.ngrok.io/setup/ or http://localhost:5000/setup, I'm getting this error:
{"stack": "Error: The requested resource /Services/undefined was not found
 at success (/Users/.../src/twilio-contact-center/node_modules/twilio/lib/base/Version.js:88:15)
 at Promise_then_fulfilled (/Users/.../twilio-contact-center/node_modules/q/q.js:766:44)
 at Promise_done_fulfilled (/Users/.../twilio-contact-center/node_modules/q/q.js:835:31)
 at Fulfilled_dispatch [as dispatch] (/Users/.../twilio-contact-center/node_modules/q/q.js:1229:9)
 at Pending_become_eachMessage_task (/Users/.../twilio-contact-center/node_modules/q/q.js:1369:30)
 at RawTask.call (/Users/.../twilio-contact-center/node_modules/asap/asap.js:40:19)
 at flush (/Users/.../twilio-contact-center/node_modules/asap/raw.js:50:29)
 at processTicksAndRejections (internal/process/task_queues.js:79:11)", "message": "The requested resource /Services/undefined was not found", "status": 404, "code": 20404, "moreInfo": "https://www.twilio.com/docs/errors/20404" }

(Note, my absolute file path has been masked)

Can you please check if process.env.TWILIO_CHAT_SERVICE_SID was set on your installation?


test: fix route_server_malformed_test.py to work

route_server_malformed_test.py hasn't been excuted on travis.
somehow unittest.TestCase and yield() dosn't work
Signed-off-by: FUJITA Tomonori<EMAIL_ADDRESS>

Codecov Report

Merging #113 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   37.66%   37.65%   -0.01%
==========================================
  Files          60       60
  Lines       30336    30336
==========================================
- Hits        11425    11424       -1
- Misses      17791    17793       +2
+ Partials     1120     1119       -1

Impacted Files
Coverage Δ

pkg/server/server.go
39.16% <0%> (-0.08%)
:arrow_down:

pkg/server/fsm.go
52.77% <0%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec61c4...1d771f8. Read the comment docs.


How to calculate  mAP at different tIoU thresholds and the average mAP

Hello, thanks for the great work. I want to reproduce the detection results. Could you provide the code for calculate mAP at different tIoU thresholds and the average mAP on Anet dataset, please?

Hi, Thanks for your interests, but i am busy rresently. I will update the code of the fully pipeline of temporal action localization (include training the feature extractor, how to extrate the feature and classification, maybe also include our new work).
You can "watch" the repository for reminding you upon my updating.


Add new concept: Range

The information provided here will be used to create a glossary entry in the IEA Wind Task 32 Glossary of Terms. Please fill in all of the text marked "...".
Before you start

[ ] There is no similar existing entry in the Task 32 lidar glossary.

Proposed new entry
An entry is a combination of a label and a description. Source information can also be included.
Preferred label (required)
The usual label used for the entry, e.g., "probe length"

...

Alternative label (optional)
Another word or phrase that could be used for this entry, e.g., "pulse length".

...

Definition (required)
Free text that will be used as the definition for this energy, e.g. "the length over which the line-of-sight wind speed is determined". A source DOI can also be provided as part of the text.

...

Broader Concept (optional)
A parent entry. e.g., "measurement principles". This helps establish semantic meaning in the glossary.

...

What happens next?
Approved entries will be entered into https://github.com/IEA-Wind-Task-32/wind-lidar-glossary and then copied to http://data.windenergy.dtu.dk/ontologies/view/IEATask32Glossary/en/.
For interal use only
Please do not change any of the following text. This will be used to help process this issue.

[ ] All required data are present.
[ ] This is a new glossary entry. If not, an existing entry might be changed instead.
[ ] The text has been editted for style.
[ ] The text has been added to definitions.csv.

Testing framework


Visual Studio Code doen't load zsh when debuging which was configed

My setting is as following:
    "terminal.integrated.shell.osx": "/bin/zsh",
    "terminal.integrated.shellArgs.osx": [],

But the shell is using sh when debuging, I find by the following code:
#include <stdlib.h>
#include <stdio.h>

int main(int argc, char **argv) {
    system("tom");
    return EXIT_SUCCESS;
}

The output of Debug Console is:
@"sh: tom: command not found\r\n"

But in the embeded terminal, when I run tom, the output is from zsh:
$ tom
zsh: command not found: tom

I think I have found the reason, the CMake uses /bin/sh as its Shell, following is from my Makefile:
# The shell in which to execute make rules.
SHELL = /bin/sh

I tried to change it to /bin/zsh, but it didn't make sense.
Any suggestion would be appreciated!

This issue was moved to Microsoft/vscode-cpptools#1631


InputNumber doesn't work with javascript interop (focus, select, etc.)

I have a EditForm and i'm trying to set focus on some InputNumber field, unfortunately, it doesn't work, no error is showed neither focus occur...
If I change the code bellow to a simple <input @ref="myInput" /> it works.
<EditForm>
        <InputNumber @ref="myInput" />
</EditForm>

@code
{
        protected InputNumber<int> myInput;

        [Inject]
        protected MyBrowserInteropInjection MyBrowserInteropInjection{ get; set; }

        protected async override Task OnInitAsync()
        {
              MyBrowserInteropInjection.Focus(myInput);
        }
}

Thanks for contacting us, @alexandrereyes.
JS Interop should happen OnAfterRender phase.

Since I disabled server side rendering, OnInit with JsInterop works very good!
But.....even on OnAfterRender event, the above code doesn't work.

Thank you for filing this issue. In order for us to investigate this issue, please provide a minimalistic repro project that illustrates the problem.


form/converter: make Python-like formatting code optional.

The user is warned of the consequences on both affected nodes. We could
accept printf-like only formatting strings on the form too, but not
now (maybe later).
Signed-off-by: Gustavo Lima Chaves<EMAIL_ADDRESS>

-0
I don't like this approach that much, why do we need this configuration? Wouldn't it be better to separate this in different nodes? Then if the node is not used, their functions should go away.

@barbieri: note that one the nodes in question is still usable with the new config. I can separate the form one in another node (I'd have to do that with the pcre one as well). Everyone OK with that approach?

On Tue, 05 Apr 2016 11:03:31 -0700, Gustavo Lima Chaves wrote:

@barbieri: note that one the nodes in question is still usable with the new config. I can separate the form one in another node (I'd have to do that with the pcre one as well). Everyone OK with that approach?

They are usable, but the result is not the same, so anyone using these
nodes needs to keep in mind that the result might change under different
configurations.

@glima couldn't you explain in the commit msg what exactly is going on? Looks like these functions are only used by the node type "form/string-formatted", that I suppose you're not using in your demo for small os.
Unused nodes aren't removed from the binary?

On Tue, 05 Apr 2016 11:07:27 -0700, Bruno Dilly wrote:

@glima couldn't you explain in the commit msg what exactly is going on? Looks like these functions are only used by the node type "form/string-formatted", that I suppose you're not using in your demo for small os.
Unused nodes aren't removed from the binary?

If nothing references them, yes. But if the functions they use to do
their work end up under some path referencing other functions, they will
all be brought in.
Same reason why anything using the console module will drag every packet
type we have, even if all you do is print an empty from a timer to check
that the program is alive.

@bdilly: two converter nodes also refer to those functions. @ibriano's point is valid, but I try to state the consequences on the Kconfig help text (not in the original node's documentation, though). I can tweak the commit message, sure.

I'll wait for the work on alias to proceed here. Maybe we can have a python .so with the nodes in question and alias them back the original names.

On Tue, 19 Apr 2016 13:03:09 -0700, Gustavo Lima Chaves wrote:

I'll wait for the work on alias to proceed here. Maybe we can have a python .so with the nodes in question and alias them back the original names.

Will they provide the exact same behavior?

Yes, and PR made.


Multiple inheritance with DecoderBase

An initialization issue will occur when we construct a class using multiple inheritances with DecoderBase. For example, we here have class XLNetDecoder(XLNetEncoder, DecoderBase). When we call super().__init__(...) in XLNetDecoder, the initialization of DecoderBase can not be executed properly because of the parameter input_size in DecoderBase.__init__(). hparams is actually assigned to input_size, and hparams is set to be None in ModuleBase.
init order: XLNetDecoder -> XLNetEncoder -> XLNetBase -> DecoderBase -> ModuleBase.

Can we call the Parent class constructors explicitly? Like
  __init__(..)
    XLNetEncoder.__int__(..)
    DecoderBase.__init__(..)

In XLNetDeocder, we do not have the parameter input_size, while it is required in DecoderBase.

I don't think this will work. nn.Module.__init__() will be called twice, and we will lose some parameters in the model. We probably can just delete the parameters intput_size or make it Optional since it is not used in DecoderBase.


CIFAR training not working in FeAI

CIFAR training not working in FeAI - Found by @laurislopata

issue was that roundDuration = 0 in tasks.json for CIFAR, which was cousing startRound == False in the client. Will further investigate with @s314cy to see if this is desired behavior, put roundDuration's to 5 for all tasks to avoid this behavior for now.

After a discussion we will enforce roundDuration > 0 in the task creation


complete the EOF functions using SVD solver

Reported by Ansley B Manke on 9 Jul 2004 18:27 UTC
This code does not allow for gappy data but runs
faster for complete data fields.  See
~ansley/FERRET/external_functions/eof/eofsvd_space.F
need _tfunc and _stat functions, and tests.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/928

Comment by<EMAIL_ADDRESS>on 5 Nov 2004 19:30 UTC
Changing these bugs in Ferret Tasks to the External Functions component

Comment by ansley.b.manke on 25 Sep 2013 23:09 UTC
This was completed in Ferret v6.8


answerCallbackQuery not working

PHP 7.4 (Shared hosting beget.com)
Other commands are working successfully.
answerCallbackQuery not working. Everything is done correctly, returns a successful result. But there is no window in the chat (alert)
My code:
			Request::answerCallbackQuery([ 				'callback_query_id' => $callback_query_id, 				'text' => 'OK', 				'show_alert' => true, 			]);
Please, help me :)

@temirovgroup Have you tried on different devices and Telegram apps?
Various Telegram apps display the alerts differently.
Also, be sure to return the answer using return Request::answerCallbackQuery...!

I tried it on different devices. Returns this:
{     "ok": true,     "result": true,     "raw_data": {         "ok": true,         "result": true     },     "bot_username": "@chickenstore_bot" }
P.S. return Request::answerCallbackQuery...! - It's done. Not working

Please try this instead, inside your CallbackqueryCommand::execute command, and let me know if that works.
Maybe the callback query ID you're passing is invalid?
public function execute(): ServerResponse
{
    $callback_query = $this->getCallbackQuery();

    // your code...

    return $callback_query->answer([
        'text'       => 'OK',
        'show_alert' => true,
    ]);
}

Excuse please. The problem was this:
$telegram = new Telegram(Yii::$app->params['telegram']['api_key'], Yii::$app->params['telegram']['bot_username']); $telegram->handle();
($telegram->handle();)
I don't know why I called him at all.. :))

Thank you for your answers. And a special thank you for your work!

Excuse please. The problem was this: $telegram = new Telegram(Yii::$app->params['telegram']['api_key'], Yii::$app->params['telegram']['bot_username']); $telegram->handle(); ($telegram->handle();)
I don't know why I called him at all.. :))

This problem has plagued me 10H.. Thank you Soooooomuch

I encountered the same issue where I'd send an answerCallbackQuery and Telegram responded with 200 OK, but no notification appeared for the user.
I found this answer on StackOverflow mentioning:

The problem was with the library I was using and how I used it. Using the https://github.com/php-telegram-bot/core and the handleGetUpdates() method, the library automatically sends an empty response to answerCallbackQuery. I attempted to answer the CallbackQuery again after the library already did. Even though Telegram says OK, it only handles the first call.

So, I solved it by not using $telegram->handleGetUpdates().
Instead, I'm now using the \Longman\TelegramBot\Request::getUpdates($data) method.
To use it directly, you still need to set up and create a Telegram instance and then pass it to Request::initialize().
Like this:
use \Longman\TelegramBot\Request;
use \Longman\TelegramBot\Telegram;

$apiKey = "place_your_api_key_here";
$botUsername = "place_your_bot_username_here";

$telegram = new Telegram($apiKey, $botUsername);

Request::initialize($telegram);

$updates = Request::getUpdates([
    // here is a place for your long polling request params
]);

I hope this helps!

@underwear How curious, I don't understand why it's not working for you, as the $telegram->handleGetUpdates() "should" be doing the same thing.
Clearly the few extras it does, seem to be breaking something, but I've not encountered that yet.
FYI, no need to do Request::initialize as the Telegram constructor does that already for you.
What version of PHP are you on, and which version of the bot are you using?