Django support.

Hello,
I have been asked to evaluate Turbodbc. We have django project and we use the postgres database backend available out of the box for the same. Since Turbodbc claims to be fast, would like to use it in our project.
I would appreciate if someone can help me to know how to integrate it with django as database backend if that's possible at all.

Can you specify what you actually need from turbodbc? Couldn't you specify it instead of pyodbc in the connection string?


Additional parameter requires for toleration in DaemonSet

Describe the bug
The DaemonSet manifest generates the following:
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/master

The default operator is "Equals" and without a value, this never matches. The Pods are never deployed. The corrected toleration is:
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/master
        operator: Exists

kube-vip 0.3.2 on K3s 1.20.2+k3s1

Fixed in 0.3.3 (in development)


Enable map access for function, add ClickHouse dialect

#380

@monadbobo  it seems like the tests no longer pass on this PR

@monadbobo it seems like the tests no longer pass on this PR

Yes, my problem, I fixed the compilation error after merging the main branch code.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

36 of 39 (92.31%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 90.188%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
6
9
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
6636

Relevant Lines:
7358

💛  - Coveralls

Thanks again @monadbobo

Perhaps a corresponding dialect should also be added in "examples/cli.rs".


Update c3p0 to version <IP_ADDRESS>

I believe this falls under "contributions which do no require a full Contributor's License Agreement", as described here: http://www.quartz-scheduler.org/community/contribute.html#contributions-which-do-not-require-full-contributors-license-agreement-cla
@J3173 If you could confirm that you agree with a simple yes below that would be great!

@chrisdennis if @J3173 does not respond I can also submit this PR and then respond with an approval if it helps?    Also if this project is looking for committers I am an active GitHub committer and have Maven Central permissions.   Just throwing that out there...

I believe this falls under "contributions which do no require a full Contributor's License Agreement", as described here: http://www.quartz-scheduler.org/community/contribute.html#contributions-which-do-not-require-full-contributors-license-agreement-cla
@J3173 If you could confirm that you agree with a simple yes below that would be great!

Yes, I agree.

Also if this project is looking for committers I am an active GitHub committer and have Maven Central permissions. Just throwing that out there...

@melloware Right now @jhouserizer and I are just trying to get back on top of the open issues/PRs with a focus on getting bugs fixed and merged. There is discussion going on internally regarding the future, but it's all just discussion for now. When that discussion approaches some kind of conclusion we can/should talk.

No problem.  thanks for your response!


Update compositor data for Mir 2.12

It now implements primary-selection-unstable-v1: https://github.com/MirServer/mir/releases/tag/v2.12.0

Looks good, thanks!


Sync Release 0.11 into master branch

Description

As in title
Type of change
What type of changes does your code introduce to tobs? Put an x in the box that apply.

[ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
[ ] FEATURE (non-breaking change which adds functionality)
[ ] BUGFIX (non-breaking change which fixes an issue)
[ ] ENHANCEMENT (non-breaking change which improves existing functionality)
[ ] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Dashboard sync CI check is failing as we didn't port https://github.com/timescale/tobs/pull/439 into release branch. This should be safe to ignore.


Normalize and document handling of config options setting through env vars

What does this PR do?
Enable all configuration options to be set with env vars.
Motivation
The goal is to make the configuration more consistent: All main options can be set either by the datadog.yml file or env vars. Env binding is done with default setting to avoid duplication.
Additional Notes

https://github.com/DataDog/documentation/pull/2865 was merged


Star count and fix order

Added star count for Excubo.Blazor.Diagrams and fixed the order of entries in that section.

Thanks!


WIP: Add poststorage child workflows

Refs #886.

Yes, if a child workflow only works with AM and Enduro is configured to run with a3m, I'd prefer that child workflow to fail to know I misconfigured the system.
As I said, we may want to improve that at some point to be able to report the child workflows in the API/UI. For now they are just like webhooks to be able to trigger custom workflows after storage, and we only make sure those workflows are started by Temporal. Those workflows can be monitored elsewhere for now, until we decide if we want to add information about them in the API/UI.
I'll add some tests and ping you for a final review.


[CMSIS-NN] Support for passing cpu flags to Arm(R) Corstone(TM)-300 s…

This commit contains:
-Infrastructure for passing CPU flags to Arm(R) Corstone(TM)-300 software.
-CMSIS-NN tests for Arm(R) Cortex(R)-M7 and Arm(R) Cortex(R)-M55 with -nomve flag.
-Removes an INFO message from AOT codegen.
cc @Mousius @areusch @grant-arm @manupa-arm

cc @mkatanbaf as fyi
thanks @ashutosh-arm for cleaning up the log line!


acomsis cookie logic for cn homepage

Resolves: MWPW-151792
Test URLs:

Before: https://stage--cc--adobecom.hlx.live/cn/creativecloud/roc/home?martech=off
After: https://acomsis-cookie--cc--adobecom.hlx.live/cn/creativecloud/roc/home?martech=off

@seanchoi-dev We are checking for the signed in user at the start of the script and during this time the whole page rendering is blocked till ims returns the result which is going to have a performance impact on the CC pages.
Can we do it as a delayed processing?
@amitbikram @salonijain3 Could you share your inputs on the same?

@seanchoi-dev We are checking for the signed in user at the start of the script and during this time the whole page rendering is blocked till ims returns the result which is going to have a performance impact on the CC pages. Can we do it as a delayed processing? @amitbikram @salonijain3 Could you share your inputs on the same?

There is no other option than checking IMS before rendering anything.
And that's the way how homepage works now.
imslib.min.js is about 17kb and as long as we don't exceed 100kb total byes before loading LCP, we will get proper LH score for LCP.
I limited this logic only for the homepage path so it doesn't affect existing CC pages.
Let me know if you have question why we need this.

@seanchoi-dev script.js is the bootstrap file which loads for all the pages, we should keep it lightweight and should avoid(if possible) adding any additional logic that is required for one/few pages. We should think of an alternative aproaches to handle this. Below few options I can think of right now:

Can we go with Akamai approach to serve /cn/creativecloud/roc/home from homepage
A redirect Milo block with current cookie and redirection logic which can be used in the page where we need it.
cc: @salonijain3 @aishwaryamathuria

@seanchoi-dev script.js is the bootstrap file which loads for all the pages, we should keep it lightweight and should avoid(if possible) adding any additional logic that is required for one/few pages. We should think of an alternative aproaches to handle this. Below few options I can think of right now:

Can we go with Akamai approach to serve /cn/creativecloud/roc/home from homepage
A redirect Milo block with current cookie and redirection logic which can be used in the page where we need it.
cc: @salonijain3 @aishwaryamathuria

I understand that script.js is getting loaded all pages and we want to keep it lightweight as much as possible.
I moved the function at utils.js though, utils.js is also getting loaded everywhere as well, I hope this makes us feel better.
Things about this implementation,

This logic is to add / remove acomsis cookie according to the user login status.
User can login / logout outside of a.com, loading IMS is required to check the status.
The logic has been reviewed and finalized with many engineers and other stakeholders both from Milo and Dexter.
This logic has to hit before loading blocks, so users can't see the flicker. (Cannot be running as a block)
Akamai will redirect according to the acomsis cookie.
-- If the cookie exists, all users visiting logged-out homepage should get redirected to signed-in homepage.
-- If the cookie doesn't exists, all users visiting logged-in homepage should get redirected to signed-out homepage.
All other locales except cn's logged out homepage is under milo homepage repo and logged-in homepage is currently under Dexter and they both have this logic. (and a bit more stuff in it)
-- https://github.com/adobecom/homepage/blob/stage/homepage/scripts/scripts.js#L239
New Chinese signed-in homepage is under CC repo and missing this logic therefore it causes a major bug that CN users can visit logged in homepage without logged in and once they logged in they can't revisit logged out page even after logged out.
Akamai side for this logic is ready on stage for testing
-- WPS-25719
We will need a decent QA on stage and we can't do it because this PR isn't merged into stage, yet. There are also pressures from above.
-- This doesn't mean we need to approve and merge blindly but we want to review this quickly.

Let me know if you have any questions about this PR.

@seanchoi-dev We wont get much benefit moving it to utils as the approach remains same. Since this is for one specific page lets with with the current approach to keep it simple. We may need to revisit if this applies to more pages or see any side effect at later stage. Approving it for now. Thanks!
cc: @salonijain3 @aishwaryamathuria


Refresh elements size on containers size change

If the containers size changed, the elements size aren't recalculated so the the tab control will not be rendered correctly.
A window size change or the change of the tab collection is required to render the control correctly.
Here a plunker to reproduce the issue:
http://plnkr.co/edit/xN40AmjVc9npecQdF89E?p=preview
thank you

Right, I had the same issue with the jQuery plugin version of this. Since there's not really a good way to detect a change in the container size, I created a refresh method that could be called by the user code any time they changed the container size.
I'm thinking I'll need to add something similar to this. So in your example plunk, you'd need to call that refresh (or whatever it's going to be) when the Full/Half button is clicked.

Thanks for your reply!
A refresh method would be great!

For v0.1.0, I added a refresh-on option, so you can point that attribute to a flag that it will watch, and when that flag is true the tabs container will refresh its sizes.
Here's a fork of your plunk showing it working:
http://plnkr.co/edit/bdqMZPyQbt0TmKZAYybK

Thank you!


[BUG] : Link not working

ER diagram link provided is not working and directs to 404 error.
screenshot:

Please assign this issue under gssoc 23 @shreya024

It's ok,we are going to modify the ER Diagram anyway and update it soon


chore: add api-iot as owners for samples

the right owners should be @gcseh @googleapis/api-iot

the right owners should be @gcseh @googleapis/api-iot

@gcseh Thank you! I always forget that teams don't exist outside of an org. 🤦♀

@gcseh Thank you! I always forget that teams don't exist outside of an org. 🤦♀

already done in an other PR.


Tracking issue for getting this crate back up and running!

Hi,
I have been working on a fork to get it working in the latest stable rust, I think I'm about 50% of the way there, I got the callbacks fixed up (still want to optimise them a little bit though, it uses a Box::leak and a dyn which I don't think I need) and now I just get a segfault when it closes the device. Any help/advice is appreciated.
https://github.com/emm312/hackrf-rs

Looks like if I just remove it it doesn't segfault, not an ideal solution but it worked I guess, will need to look into it more


[Bug]: Table widget fails to pickup/handle utf8 column names from Google sheets

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
The table widget fails to pickup/handle utf8 column names from Google sheets
Steps To Reproduce

Create a sheet with utf8 column names
Use the Google sheet integration to display the data on a table widget

Environment
Release
Version
Cloud

I believe there is already a ticket on this here:
https://github.com/appsmithorg/appsmith/issues/5445

You're right. Closing this


Fix versions

to guarantee reproducible builds

The phonopy example takes too long, so the tests fail - for now we exclude it.


server locked when refreshing the config in nacos

spring cloud hoxton
spring boot 2.2.6
nacos 1.3.1
when we refresh the config in nacos,   the server locked , follow-up requests are all have no response.  we must restart the server
we found in log , the log in the figure below is not printed

up to now， we have encountered this problem twice
by the way , we found the related function marked as "for testing", even in the later version of spring cloud. why?

the final log of the thread that refreshing config:
2022-01-03 11:57:40,619 CST [d.internal_8848] DEBUG org.springframework.core.env.PropertySourcesPropertyResolver 115 logKeyFound - Found key 'propertyName' in PropertySource 'bootstrapProperties-config.yaml,DEFAULT_GROUP' with value of type Boolean

Please try spring cloud 2021.0.6 or 2022.0.1

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


[QA] User is able to see people on Genesis Plaza while doing the on boarding

Explorer Alpha build versions:
0.36.0
Issue Description:
When a user is on the onboarding world and they look up , they are able to see people floating in the sky (avatars from genesis plaza)
STR:

Open 0.36.0 with a new account
Validate that you will appear on the on boarding
Look up during the on boarding
Validate that you are able to see people on the Genesis plaza

Expected behavior:
When doing the on boarding , people over the genesis plaza should not be visible
Current behavior:
When a user is on the onboarding world and they look up , they are able to see people floating in the sky (avatars from genesis plaza)
Evidence:
https://github.com/user-attachments/assets/b3118f35-d9b9-4c90-b8e2-41e306450d67
Additional Notes:
This issue happens on Windows and Macos

No users can be seen during the on boarding!
Attaching video as evidence :
https://github.com/user-attachments/assets/138bb1b2-52d7-4233-a4d5-99c60decd7cd

During the testing of a PR for the latest release we were able to reproduce the people floating during the on boarding
https://github.com/user-attachments/assets/53fe66c3-d433-475a-b253-66cea145bcd8

As far as I could test, this only happens for new users. Im looking at ways to fixing this!


second regex capture to grab hmr rendered marko files

##Description
vite HMR builds add a t=____ string to the end of marko files that was failing to match the original regex. so, I added a second one.
Motivation and Context
HMR refreshes in vite would kill the page until the server was restarted
Checklist:

[n/a] I have updated/added documentation affected by my changes.
[ ] I have added tests to cover my changes.

Hey @jwise7 thanks for the PR!
Could you run npm run format to fix the listing issues in the CI?


pythonPackages.pytest-cram: 0.2.0 -> 0.2.2

Motivation for this change
Fix build https://hydra.nixos.org/build/127627259
ZHF: #97479
@NixOS/nixos-release-managers
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 100529 1

3 packages built:

python27Packages.pytest-cram
python37Packages.pytest-cram
python38Packages.pytest-cram

Result of nixpkgs-review pr 100529 1

3 packages built:
- python27Packages.pytest-cram
- python37Packages.pytest-cram
- python38Packages.pytest-cram


Add Combine environment

This PR:

Adds a CombineEnvironment which combines the features of multiple environments into a single one.
Add a method to OfflineEnvironment to directly combine it with another.

Open Points:

The naming is not consitent yet. The method is called extend the environment Combine. I'm open to name suggestions here
The same functionality could be useful for IncrementalEnvironments. Should we extend this implementation to cover them as well or do we define a seperate environment for that task?

What do you think of something like horizontal stack or join

horizontal stack is technically correct, but doesn't sound "sexy". join is fine, but can easily be confused with stack

How do we resolve this discussion? :smile:

Hold a vote? @newLabAspect and @mknitt what do you think? Which name is a good fit?

I prefer being technically sound over being sexy. Thus, I would rather vote for horizontal stack. Nevertheless, in that case we should probably re-name stack to vertical stack. To have it shorter, another option would be vstack and hstack?


CLI help fails due to missing dependency on twilio package

Hi there!
I was just trying this out.  I ran this:
$ pip install elasticsearch<3.0.0 elastalert==0.1.6
$ elastalert-create-index ...
$ elastalert --help
Traceback (most recent call last):
  ...
  File ".../site-packages/elastalert/elastalert.py"
    from alerts import DebugAlerter
  File ".../site-packages/elastalert/alerts.py"
    from twilio import TwilioRestException
ImportError: cannot import name TwilioRestException

Seems like twilio is already in my environment:
$ pip freeze | grep -i twil
twilio==6.3.0

Maybe the published a new package with an API break?

FYI, I worked around this by running pip install "twilio<6".

0.1.6 is old(ish) and didn't have twilio pinned.


[skip ci] cephadm-adopt: use --realm and --zone for RGW

Historically, ceph orch apply rgw was using:

1st arg as service id
2nd arg as realm value
3rd arg as zone value

There's now dedicated parameters for that (even if the current implementation
is still working) but we have now the same parameters used for both multisite
and non multisite setup.
Signed-off-by: Dimitri Savineau<EMAIL_ADDRESS>

closing in flavor of #6776


[GHSA-32hw-3pvh-vcvc] XSS vulnerability on password reset page

Updates

References

Comments
Adding the patch link for v3.3.4: https://github.com/mautic/mautic/commit/942cb6992df619fdf1c181bfad9e25d5d4178b6f
The GHSA-ID in the commit patch message: "Merge pull request from GHSA-32hw-3pvh-vcvc

Fixing xss on common controller for Mautic 3.x branch.

Add test cases to validate xss filteration."

Hi there @RCheesley! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


[web] progressIndicator not working

Since the whole library is not using web worker when starting to crop using controller.crop() the cropping blocks the main thread resulting in a frozen page. A side effect of this is that the progressIndicator did also not work on web.
maybe sth. like https://pub.dev/packages/squadron could help solving the multithreading problems for web

@c-seeger Thank you for the suggestion. As I'm not very familiar with web, let me take some time to challenge solving this. If you are in a hurry, consider overriding cropping logic with imageCropper parameter.
Crop(
  image: _imageData,
  controller: _controller,
  imageCropper: YourCustomImageCropper(),
),

class YourCustomImageCropper<Image> extends ImageCropper {
  @override
  FutureOr<Uint8List> call({
    required Image original,
    required Offset topLeft,
    required Offset bottomRight,
    ImageFormat outputFormat = ImageFormat.jpeg,
    ImageShape shape = ImageShape.rectangle,
  }) {
    // call `defaultImageCropper.call()` using some trick not to block during operation.
    // return the result of the step above.
  }
}

Just wanna +1 this, with larger files the UI just seems to freeze completely when cropping. Otherwise, great work with this package!

@c-seegerObrigado pela sugestão. Como não estou muito familiarizado com a web, deixe-me dedicar algum tempo para desafiar a solução disso. Se você estiver com pressa, considere substituir a lógica de corte pelo imageCropperparâmetro.
Crop(
  image: _imageData,
  controller: _controller,
  imageCropper: YourCustomImageCropper(),
),

class YourCustomImageCropper<Image> extends ImageCropper {
  @override
  FutureOr<Uint8List> call({
    required Image original,
    required Offset topLeft,
    required Offset bottomRight,
    ImageFormat outputFormat = ImageFormat.jpeg,
    ImageShape shape = ImageShape.rectangle,
  }) {
    // call `defaultImageCropper.call()` using some trick not to block during operation.
    // return the result of the step above.
  }
}

Undefined class 'ImageShape'. ????


Not redirecting to application after login on iOS 9.0.2

Hi,
When calling the FBLoginManager.loginWithPermissions() method I got the Safari screen that pops up but after the user log in and accept the permission the Safaris screen stays empty and the user is not redirected to my application.
I added the LSApplicationQueriesSchemes entries to my plist file

Is there any extra data to set in order to get the redirection working the iOS 9.x ?
Thx

@GuillaumeNachury I'm having the same problem. did you manage to resolve it?

ok, i solved it. I had forgotten to connect the app delegate: https://github.com/magus/react-native-facebook-login#appdelegatem-modifications


Interactive creation of account fails

When trying to create an account on testnet using an interactive mode it fails to create it:
flow accounts create
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
                           ⚠ Upgrade to Cadence 1.0
     The Crescendo network upgrade, including Cadence 1.0, is coming soon.
     You may need to update your existing contracts to support this change.
                     Please visit our migration guide here:
             https://cadence-lang.org/docs/cadence_migration_guide
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Enter an account name: test
✔ Testnet

❌ Command Error: account creation error

had the same issue, thanks for the report


more grammar corrections, optimisations

grammar corrections

for terminal-strings and special-sequences, only the content is stored, i.e. for terminal-strings, the surrounding quotes are not stored, and for special-sequences the surrounding question marks are not stored. (8d9e490)
the first-quote-symbol has been changed from U+2019 Right Single Quotation Mark to U+0027 Apostrophe. § 7.3 Table 1 calls for "apostrophe", also the new symbol is more frequently available on keyboards. (c54e837)
the SyntacticException struct is replaced with SyntacticFactor and syntactic-exceptions are stored correctly (before they were stored as the original EBNF text, effectively forgetting all parsing done to them). (717947a)

optimisations

implement 3 cargo clippy recommendations: removed unnecessary closures (a6f7284)
the MetaIdentifier struct is replaced with just String, simplifying the types (a7c37cd)
added a few comments, removed unnecessary raw string literals and semicolons (d5a5ee9)
simplified the checks if the correct rules were matched and found a bug (f576a4d)

I simplified the problem you stated by removing the tests as far as possible as stated in #3.

it seems you already merged this with #6

@Johann150 thanks for the contribution. I appreciate it a lot ^^ I tried to keep your contributions in the history but it seems Git overriden it.
Thanks again!


Do you have a musl library that supports UEFI？

I want to write an  application under uefi,use msvc as compiler,and I aso porting freetype  ,I found it depend C runtime library.
I did not use edk-libc,because it is so large,my framework is gnuefi.

I don't have a musl libc library that adapts the UEFI enviroment.
Maybe I can port libc which used by NuttX to this project because I have created this project for discovering stage of porting NuttX to UEFI.


do not create istio CA if we PILOT_CERT_PROVIDER is kubernetes and signer has been configured

pilot:
  k8s:
    env:
    - name: EXTERNAL_CA
      value: ISTIOD_RA_KUBERNETES_API
    - name: K8S_SIGNER
      value: kubernetes.io/legacy-unknown
    - name: PILOT_CERT_PROVIDER
      value: kubernetes

Take above config as an example, we do not need to enable ca function in istiod at all since we will delegate all certs generation(including istiod certs) to the external ca and istiod is just working as an RA.
Currently we will still createIstioCA and generate unneeded certs.  See https://github.com/istio/istio/blob/master/pilot/pkg/bootstrap/server.go#L1050 for details.
With this change, we can get below benefits:

save effort for creating an needless CA server and certs --those codes are dead under this case.
Support using external signer to sign istiod certs as well : Curretly we do not support specify signer for istiod certs even if PILOT_CERT_PROVIDER is kubernetes as we will use the defaut one kubernetes.io/legacy-unknown.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test release-notes_istio

unit-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test release-notes_istio

unit-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test release-notes_istio

unit-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-multicluster-tests_istio

release-notes_istio
34fdf9d3a6845130ba0e1cf11664087313fa5659
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-multicluster-tests_istio

release-notes_istio
34fdf9d3a6845130ba0e1cf11664087313fa5659
link
/test release-notes_istio

unit-tests_istio
34fdf9d3a6845130ba0e1cf11664087313fa5659
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-k8s-tests_istio

unit-tests_istio
34fdf9d3a6845130ba0e1cf11664087313fa5659
link
/test unit-tests_istio

release-notes_istio
bbd03cd864c908395e881d95a4b9fd7f5615f64f
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
0f9f6d04df48a3bf41bb0fe93326d7b86aafdb86
link
/test integ-security-k8s-tests_istio

release-notes_istio
44a7f165d547940a1f721df862f6b92f9ded60bd
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
44a7f165d547940a1f721df862f6b92f9ded60bd
link
/test release-notes_istio

integ-security-multicluster-tests_istio
44a7f165d547940a1f721df862f6b92f9ded60bd
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
44a7f165d547940a1f721df862f6b92f9ded60bd
link
/test integ-security-multicluster-tests_istio

release-notes_istio
97c796fd8b3f7f88bdb488e2eef9582465e0d39c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

What benefits do we get?
On Tue, Jun 22, 2021 at 8:12 AM Iris @.***> wrote:

@.**** commented on this pull request.
In pilot/pkg/bootstrap/certcontroller.go
https://github.com/istio/istio/pull/33542#discussion_r656320216:

@@ -129,10 +130,22 @@ func (s *Server) initDNSCerts(hostname, customHost, namespace string) error {

var certChain, keyPEM, caBundle []byte
var err error

if features.PilotCertProvider == constants.CertProviderKubernetes {

if features.PilotCertProvider == constants.CertProviderKubernetes && signerName != "" && s.RA != nil {
pilot:
k8s:
env:
- name: EXTERNAL_CA
value: ISTIOD_RA_KUBERNETES_API
- name: K8S_SIGNER
value: kubernetes.io/legacy-unknown
- name: PILOT_CERT_PROVIDER
value: kubernetes

Take above config as an example, we do not need to enable ca function in
istiod at all since we will delegate all certs generation to the external
ca and istiod is just working as an RA.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/33542#discussion_r656320216, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXKOE7EYSWSBJOX56RTTUCR57ANCNFSM47BGWMNA
.

we can skip creating a no useful CA and initializing all the no-needed certs. This also opens a door to let user define different signer to for istiod certs.

@howardjohn Please see the updated description for this PR. Thanks!

@shankgan A ping on this, Thanks!

/test release-notes_istio

@irisdingbj - I think this is already being done, but to double confirm - From the perspective of config grouping, can we keep these two separate - EXTERNAL_CA (env variable indicating that the RA code path is triggered for data-plane mTLS workload certificates), and PILOT_CERT_PROVIDER (which indicates who is signing the control-plane certificates). These two code paths can then share the K8S_SIGNER config to figure out how to route the CSR requests.

@irisdingbj - I think this is already being done, but to double confirm - From the perspective of config grouping, can we keep these two separate - EXTERNAL_CA (env variable indicating that the RA code path is triggered for data-plane mTLS workload certificates), and PILOT_CERT_PROVIDER (which indicates who is signing the control-plane certificates). These two code paths can then share the K8S_SIGNER config to figure out how to route the CSR requests.

@irisdingbj - I think this is already being done, but to double confirm - From the perspective of config grouping, can we keep these two separate - EXTERNAL_CA (env variable indicating that the RA code path is triggered for data-plane mTLS workload certificates), and PILOT_CERT_PROVIDER (which indicates who is signing the control-plane certificates). These two code paths can then share the K8S_SIGNER config to figure out how to route the CSR requests.

Yep, this makes  the code logic more clear. I have also removed the integration test.

@howardjohn @shankgan @hzxuzhonghu PTAL, Thanks!

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-security-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-multicluster-k8s-tests_istio

integ-distroless-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-operator-controller-tests_istio

integ-cni-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-cni-k8s-tests_istio

integ-helm-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-security-multicluster-tests_istio

integ-telemetry-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
b7b2b2473ec5ea38bd1f6b4466b785b396c396da
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shankgan PTAL, Thanks!

/retest


Fix: swift lint

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[x] Refactoring

:scroll: Description

split a long swift method and disable the cyclomatic_complexity lint ( should have complexity 10 : currently 11 )
:bulb: Motivation and Context

:green_heart: How did you test it?
:pencil: Checklist

[x] I reviewed submitted code
[ ] I added tests to verify changes
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #213 (4936b4f) into main (9169e69) will increase coverage by 8.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   79.15%   88.00%   +8.84%
==========================================
  Files          49        4      -45
  Lines        1497      100    -1397
==========================================
- Hits         1185       88    -1097
+ Misses        312       12     -300

Impacted Files
Coverage Δ

dart/lib/src/sentry_options.dart

dart/lib/src/protocol/breadcrumb.dart

dart/lib/src/utils.dart

dart/lib/src/hub_adapter.dart

dart/lib/src/protocol/request.dart

dart/lib/src/sentry.dart

dart/lib/src/protocol/sentry_runtime.dart

dart/lib/src/hub.dart

dart/lib/src/protocol/browser.dart

dart/lib/src/version.dart

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9169e69...4936b4f. Read the comment docs.


AlertDialog can not be closed after reconnecting to the app.

AlertDialog can not be closed after reconnecting to the app.

Open a AlertDialog.
Reconnect to the app. (e.g. Refresh the website page.)
The AlertDialog can not be closed now.

Code example to reproduce the issue:

Describe the results you received:
https://user-images.githubusercontent.com/121756620/236811031-dd80d28e-b28b-4b8a-959a-4ffb3b6bf988.mp4
Flet version (pip show flet):
Name: flet

Version: 0.7.0.dev1372
Summary: Flet for Python - easily build interactive multi-platform apps in Python
Home-page:
Author: Appveyor Systems Inc.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: C:\Program Files\Python312\Lib\site-packages
Requires: flet-core, httpx, oauthlib, packaging, watchdog, websocket-client, websockets
Required-by:

Operating system: Windows 11.

Can you please provide some sample code for testing.
I am just from trying with the example in the docs and it works as expected.

There is a lot of missing files in that example, like fonts and other assets.
Can you do the repro in a separate GitHub repository, or Gist (which can be cloned as a repo too)?


Bratseth/quoted tensor labels

@lesters please review
This allows any string as a (mapped) tensor label, where non-identifier strings must be quoted by single or double quotes.
Strings containing double quotes will be output with single quotes and vice versa, so the backend must also parse both kinds. Let me know if this isn't ok @havardpe .

why can't we use the same format as the quoted string we already support?


Cargo.toml files using absolute paths are not correctly parsed

On Fuchsia; we use a gen-cargo script to generate Cargo.toml files from our custom build system that are compatible with RLS. These files use absolute paths to their dependencies, and this seems to break rust-analyzer, but functions just fine with RLS.
Steps to repro:

Download Fuchsia (see here): https://fuchsia.dev/fuchsia-src/development/source_code
fx set core.x64 --release
fx build (this may take several hours, and requires a pretty powerful machine)
fx gen-cargo //src/connectivity/bluetooth/profiles/bt-a2dp-sink:bin
Open fuchsia/src/connectivity/bluetooth/profiles/bt-a2dp-sink in an editor that supports rust-analyzer (such as VSCode)
Observe  errors such as this "Unable to open 'channel.rs': Unable to read file (Error: File not found (/mntpnt/fuchsia/src/connectivity/bluetooth/profiles/bt-a2dp-sink/mntpnt/fuchsia/garnet/public/rust/fuchsia-zircon/src/channel.rs))."
when trying to navigate between files with rust-analyzer.

I did try to replicate your case with a full path deps and it works :
# /sandbox/temp/foo/crates/foo.toml

[package]
name = "foo"
version = "0.1.0"
authors = ["Edwin Cheng<EMAIL_ADDRESS>edition = "2018"

[dependencies]
baz = {path="/sandbox/temp/foo/crates/baz"}

Would you mind to just share the post-generated Cargo.toml ?

Haven't looked into this yet, but an interesting thing for Fuchsia use-case is that we don't require a Cargo.toml. Instead a rust-project.json file can be used, which just specifies the crates directly (ie, it's a lower-level in comparison to .toml). We don't really have any good docs for this functionality (mainly because there are no users I know of), but this tests shows an example:
https://github.com/rust-analyzer/rust-analyzer/blob/8b278b1ab660df0728508e45e88ac769a2e03a58/crates/ra_lsp_server/tests/heavy_tests/main.rs#L281-L354
In theory, producing something like project-json from a custom build system should be easier than faking whole Cargo.tomls

# Copyright 2019 The Fuchsia Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

[package]
name = "bt_a2dp_sink"
version = "0.1.0"
edition = "2018"
license-file = "LICENSE"
authors =<EMAIL_ADDRESS>description = "Rust crate for Fuchsia OS"
repository = "https://fuchsia.googlesource.com"

[[bin]]

name = "bt_a2dp_sink"
path = "/mntpnt/fuchsia/src/connectivity/bluetooth/profiles/bt-a2dp-sink/src/main.rs"

[features]
default = []

[dev-dependencies]

[dependencies]
serde_json = "1"
slab = "0.4"
parking_lot = "0.9"
lazy_static = "1"
serde_derive = "1.0.99"
matches = "0.1.8"
failure = "0.1.1"
bitfield = "0.13"

[dependencies.bt_a2dp]
path = "/mntpnt/fuchsia/out/default/gen/src/connectivity/bluetooth/lib/bt-a2dp/bt-a2dp"
version = "0.1.0"

[dependencies.bt_avdtp]
path = "/mntpnt/fuchsia/out/default/gen/src/connectivity/bluetooth/lib/bt-avdtp/bt-avdtp"
version = "0.1.0"

[dependencies.fuchsia_async]
path = "/mntpnt/fuchsia/out/default/gen/garnet/public/rust/fuchsia-async/fuchsia-async"
version = "0.1.0"

[dependencies.fidl_fuchsia_media_playback]
path = "/mntpnt/fuchsia/out/default/gen/sdk/fidl/fuchsia.media.playback/fuchsia.media.playback-rustc"
version = "0.1.0"

[dependencies.fidl_fuchsia_cobalt]
path = "/mntpnt/fuchsia/out/default/gen/zircon/system/fidl/fuchsia-cobalt/fuchsia-cobalt-rustc"
version = "0.1.0"

[dependencies.fuchsia_bluetooth]
path = "/mntpnt/fuchsia/out/default/gen/src/connectivity/bluetooth/lib/fuchsia-bluetooth/fuchsia-bluetooth"
version = "0.1.0"

[dependencies.fuchsia-zircon]
path = "/mntpnt/fuchsia/out/default/gen/garnet/public/rust/fuchsia-zircon/fuchsia-zircon"
version = "0.3.3"

[dependencies.log]
version = "0.4.4"
features = ["std"]

[dependencies.fuchsia-inspect]
path = "/mntpnt/fuchsia/out/default/gen/src/lib/inspect/rust/fuchsia-inspect/fuchsia-inspect"
version = "0.1.0"

[dependencies.fidl]
path = "/mntpnt/fuchsia/out/default/gen/garnet/public/lib/fidl/rust/fidl/fidl"
version = "0.1.0"

[dependencies.fuchsia_cobalt]
path = "/mntpnt/fuchsia/out/default/gen/src/lib/cobalt/rust/fuchsia-cobalt"
version = "0.1.0"

[dependencies.fidl_fuchsia_media]
path = "/mntpnt/fuchsia/out/default/gen/sdk/fidl/fuchsia.media/fuchsia.media-rustc"
version = "0.1.0"

[dependencies.fuchsia_syslog]
path = "/mntpnt/fuchsia/out/default/gen/garnet/public/rust/fuchsia-syslog/fuchsia-syslog"
version = "0.1.0"

[dependencies.fuchsia_inspect_contrib]
path = "/mntpnt/fuchsia/out/default/gen/src/lib/inspect/rust/fuchsia-inspect-contrib/fuchsia-inspect-contrib"
version = "0.1.0"

[dependencies.fidl_fuchsia_bluetooth_bredr]
path = "/mntpnt/fuchsia/out/default/gen/sdk/fidl/fuchsia.bluetooth.bredr/fuchsia.bluetooth.bredr-rustc"
version = "0.1.0"

[dependencies.fidl_fuchsia_bluetooth]
path = "/mntpnt/fuchsia/out/default/gen/sdk/fidl/fuchsia.bluetooth/fuchsia.bluetooth-rustc"
version = "0.1.0"

[dependencies.fdio]
path = "/mntpnt/fuchsia/out/default/gen/garnet/public/rust/fdio/fdio"
version = "0.2.0"

[dependencies.futures]
version = "0.3.1"
features = ["io-compat"]

[dependencies.fidl_fuchsia_mem]
path = "/mntpnt/fuchsia/out/default/gen/zircon/system/fidl/fuchsia-mem/fuchsia-mem-rustc"
version = "0.1.0"

[dependencies.fuchsia-component]
path = "/mntpnt/fuchsia/out/default/gen/garnet/public/rust/fuchsia-component/fuchsia-component"
version = "0.1.0"

[dependencies.bt_a2dp_sink_metrics]
path = "/mntpnt/fuchsia/out/default/gen/src/connectivity/bluetooth/profiles/bt-a2dp-sink/bt_a2dp_sink_metrics_rustlib"
version = "1.0.0"

[dependencies.fidl_fuchsia_bluetooth_avdtp]
path = "/mntpnt/fuchsia/out/default/gen/sdk/fidl/fuchsia.bluetooth.avdtp/fuchsia.bluetooth.avdtp-rustc"
version = "0.1.0"

[patch]

[patch.crates-io]

[patch.crates-io.fuchsia-cprng]
path = "/mntpnt/fuchsia/third_party/rust_crates/../../garnet/public/rust/fuchsia-cprng"

[patch.crates-io.cmake]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/cmake"

[patch.crates-io.rust-crypto]
path = "/mntpnt/fuchsia/third_party/rust_crates/../rust-mirrors/rust-crypto"

[patch.crates-io.servo-freetype-sys]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/servo-freetype-sys"

[patch.crates-io.xi-rope]
path = "/mntpnt/fuchsia/third_party/rust_crates/../rust-mirrors/xi-editor/rust/rope"

[patch.crates-io.xi-core-lib]
path = "/mntpnt/fuchsia/third_party/rust_crates/../rust-mirrors/xi-editor/rust/core-lib"

[patch.crates-io.xi-rpc]
path = "/mntpnt/fuchsia/third_party/rust_crates/../rust-mirrors/xi-editor/rust/rpc"

[patch.crates-io.backtrace-sys]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/backtrace-sys"

[patch.crates-io.xi-trace]
path = "/mntpnt/fuchsia/third_party/rust_crates/..//rust-mirrors/xi-editor/rust/trace"

[patch.crates-io.xi-trace-dump]
path = "/mntpnt/fuchsia/third_party/rust_crates/../rust-mirrors/xi-editor/rust/trace-dump"

[patch.crates-io.winapi-util]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/winapi-util"

[patch.crates-io.web-sys]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/web-sys"

[patch.crates-io.winapi]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/winapi"

[patch.crates-io.xi-unicode]
path = "/mntpnt/fuchsia/third_party/rust_crates/../rust-mirrors/xi-editor/rust/unicode"

[patch.crates-io.pkg-config]
path = "/mntpnt/fuchsia/third_party/rust_crates/tiny_mirrors/pkg-config"

[profile]

[profile.release]
lto = "thin"
panic = "abort"
opt-level = "z"

@gbbosak The following are just my guesses:
Did any Cargo.toml generated in /mntpnt/fuchsia/src ? If I understand correctly, RA use cargo-metadata and It will search through ancestor directory to get relevant workspace information.
Maybe that Cargo.toml in mntpnt/fuhsia/src confuses the actual path data ?

We're looking into whether or not emitting a rust-project.json file would be feasible. I'll update this when I find out the results of that.

We've switched to rust-project.json and it works now. Closing this bug.


希望由Motrix下载的文件完成后能够在软件内可见，即希望添加“下载完成”

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/agalwood/Motrix/issues/71


chore add required check performance

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Ensure AsyncWorker.before_worker_boot can only be called one

Summary:
This PR ensures that AsyncMiddleware.before_worker_boot can only be called once. This is needed because it creates an AsyncWorker that sets the creates and sets the Asyncio event loop. Thus, if called more than once, the function will create a new event loop which will cause Future <Future pending cb=[Protocol._on_waiter_completed()]> attached to a different loop exception to be thrown when in-flight futures get completed
Future work
A better design would be to make AsyncMiddleware.before_worker_boot a true singleton rather than using a global variable and lock....but that's for another day.

Codecov Report
Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@b9512a1). Click here to learn what that means.

Files
Patch %
Lines

src/async_dramatiq/middleware/async_base.py
92.30%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   95.16%
=======================================
  Files           ?       11
  Lines           ?      186
  Branches        ?        0
=======================================
  Hits            ?      177
  Misses          ?        9
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Join dask.DataFrame with dask.Series

Hi,
Could someone please let me know how to join a dask dataframe with a dask series object. I tried converting the dask series into a dask dataframe but it did not work. #1677 does not give a clear answer for it. In pandas, a pandas series could be converted into a pandas dataframe by using pandas.dataframe(series) it gives me an error when doing the same for dask dataframe.
code:
card_id_pur_freq = dd.DataFrame(card_id_pur_freq)

output:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-38-c5d7a167a963> in <module>
----> 1 card_id_pur_freq = dd.DataFrame(dsk = card_id_pur_freq)

TypeError: __init__() missing 3 required positional arguments: 'name', 'meta', and 'divisions'

I only know what give the divisions parameter
could someone please help me with the code.
Thanks
Michael

ok thanks for the help


Enable logging to disk

Enable sending logs to disk:

[ ] Command line option to send all output to one file
[ ] JSON checklist option for where to log that checklist
[ ] JSON check option for where to log the output of that check

It must be

[ ] Logstash compatible
[ ] Permissions concious

This is already available in shipped-common/logging.  Method Logfile() provides the name of the file for collecting logging.  Collected logging includes TRACE logs even if they're suppressed from the console.  See shipped-bootstrap for an example of usage.

I can't find those repos. Could you link me to them? Additionally, we're trying to be framework-independent here in order to encourage wide usage, regardless of particulars. From the README.md: "Distributive attempts to be as framework-agnostic as possible."


Restrict registrations to a specifc domain

or set of domains. This was requested by Peter Neish from Melbourne. Will need to be checked in terms of collaborations before we implement it.

was the request to do this at the application level as a whole or to allow an Org basis?
Also, was it just registration specifically or login as well?
If its at the app level then this might be a viable approach (although this quite old so devise may have something better by now):
http://stackoverflow.com/questions/6448969/how-can-i-restrict-access-to-all-devise-controllers-by-ip-address

Right now I've implemented this (uncommitted kludge) on DMPmelbourne site
as a check for org type = 4 in the registration org select box
On 14 Feb 2017 7:11 p.m., "Brian Riley"<EMAIL_ADDRESS>wrote:

was the request to do this at the application level as a whole or to allow
an Org basis?
Also, was it just registration specifically or login as well?
If its at the app level then this might be a viable approach (although
this quite old so devise may have something better by now):
http://stackoverflow.com/questions/6448969/how-can-i-
restrict-access-to-all-devise-controllers-by-ip-address
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DMPRoadmap/roadmap/issues/93#issuecomment-279804567,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AR1z75wORcscP9GiLv5U091OFgizWujEks5rcfxYgaJpZM4L3-6F
.


Seeing the issue reported on swagger-ui in api documentation generated using swaggo

https://github.com/swagger-api/swagger-ui/issues/5452

Please use the issue template and fully describe the issue so we can understand and give you back proper support if it's the case.


[Service Bus] Docs review leading up to 7.0.0 release

Now that we are getting closer to the 7.0.0 release for azure-messaging-servicebus, this issue is to track the work to review all the docs around the package and make any fixes or improvements

readme
[x] migration guide (#17656)
[x] java docs
[x] Adding in sample for how to write a long-running processor (#17633) (approved, and in auto-merge)

@ramya-rao-a   @conniey finished all the java docs before release, so closing this issue.
@richardpark-msft did samples for us . Thank You.


feat(lsp): add lspRestart keymap

Add <leader>cL keymap to restart lsp server (LspRestart)

Open to other keymap suggestions!

Just use :LspRestart. I'd advise against restarting, so doesn't make sense to make this a keymap


Add six dependency explicitly

Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

Coverage remained the same at 98.441% when pulling ac98c6ac7973f233e87bc99278845028b51dd764 on add-six-dep into d4b32d4d4711ef72f206016170cb070afe0f3783 on master.


.NET 7: Update Route Group code

Per this comment

@sammychinedu2ky you might want to update your todo-group sample since it's not working. Some of the APIs has changed e.g. AddRouteHandlerFilter has been renamed to AddEndpointFilter

once you update the sample, that could be used for showcasing the Route Group feature in the doc.

cc @sammychinedu2ky

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b09824ab-b051-75a1-13b7-b0e281cc46e0
Version Independent ID: b09824ab-b051-75a1-13b7-b0e281cc46e0
Content: Minimal APIs overview
Content Source: aspnetcore/fundamentals/minimal-apis.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Rick-Anderson I've already made the changes


Optimal request interval calculation and assign to register in config space

OPtimal request time calculate :
CLK_PERIOD/BW_RATE
in hw we cannot realize division.
For simple, we calculate this as constant for highest bandwidth rate :
OPT_REQ_INTERVAL = CLK_PERIOD/3200
and next time we do shift left arith OPT_REQ_INTERVAL, because BW_RATE values differs over previous as division of 2:
3200
1600
800
400
200
etc


Jetson Orin AGX

What kind of new feature are you looking for?
(Keep the one that applies, please describe)

Hardware: Jetson Orin AGX

Do you plan to:

Contribute an initial driver: No
Write unit tests: No
Update https://github.com/periph/cmd to use the new functionality: No

The Jetson Orin AGX has the RPi GPIO layout.  Does this mean it will just work?
_, err := host.Init()
if err != nil {
    panic(err)
}

outputPin := rpi.P1_13
outputPin.Out(gpio.High)

doesn't work while the equivalent on https://github.com/NVIDIA/jetson-gpio does:
import RPi.GPIO as GPIO
import time

# Pin Definitons:
led_pin = 13  # BOARD pin 13

def main():
    # Pin Setup:
    GPIO.setmode(GPIO.BOARD)  # BOARD pin-numbering scheme
    GPIO.setup(led_pin, GPIO.OUT)  # LED pin set as output

    GPIO.output(led_pin, GPIO.HIGH)

if __name__ == '__main__':
    main()

I get when logging the outputPin.Out error:
panic: bcm283x-gpio (GPIO27): subsystem gpiomem not initialized and sysfs not accessible

What is needed is a detection system, see https://github.com/periph/host/blob/main/rpi/rpi.go#L28 or https://github.com/periph/host/blob/main/beagle/black/black.go#L31 or https://github.com/periph/host/blob/main/orangepi/orangepi.go#L27 for example.

Ok just to confirm it won't work and I'll have to figure out another way to run?

package main

import (
	"os"

	"github.com/rs/zerolog"
	"periph.io/x/conn/v3/driver/driverreg"
	"periph.io/x/conn/v3/gpio/gpioreg"
)

func main() {
	logger := zerolog.New(os.Stdout)
	if _, err := driverreg.Init(); err != nil {
		logger.Fatal().Err(err).Msg("failed to initialize periph.io")
	}
	for _, pin := range gpioreg.All() {
		logger.Info().Interface("pin", pin).Msg("found pin")
	}
        if gpioreg.ByName("16") == nil {
            logger.Fatal().Msg("Failed to find GPI16")
        }
}

Doesn't find anything.
{"level":"fatal","message":"Failed to find GPI16"}


Can we do titles and authors (including uppercasing, page headers, pdf metadata) more intelligently?

Would also like to be able to copy the all-caps header in PDF mode but actually grab the title in mixed case. Likewise for authors, etc.

Fixed the \title macro so that it can accept a macro and still capitalize it.

It may be that the accsupp package is the answer, but I haven't tried it yet.

Fixed.


Feature: Option to set match order to LexicalTypeaheadMenuPlugin and LexicalMenu

Currently, TypeaheadMenu defaults to preselecting index 0 as the default option to place matches (and consequently pre-select and highlight). In our use case, we would like the last element of the list to display the match and be selected/highlighted by default

This problem could be solved with an attribute such as 'matchOrder' with options like: 'fromBottom', 'fromTop' which would set the defaultSelectedIndex in Menu that is currently hardcoded to 0. - solving with just css or reordering of options would result in reverse tabIndexing.
If supported, I'm happy to submit a PR with proposed changes.
Changes would look like
before ->
  useEffect(() => {
    setHighlightedIndex(0);
  }, [matchingString]);

after ->
  useEffect(() => {
    setHighlightedIndex(matchOrder === 'fromBottom' ? options.length - 1 : 0)
  }, [matchOrder, matchingString, options])

Reordering the list so index 0 is at the bottom can be achieved with css:
display: flex;
flex-direction: column-reverse;

but I'm not sure what affect that might have on tab index. However, with this approach the arrow key behaviour is reversed vs expected. It might be desirable to add the option to swap up/down arrow behaviour.

I remapped the arrow commands, but it's certainly an inelegant work-around:
useEffect(() => {
return mergeRegister(
	editor.registerCommand<KeyboardEvent>(
		KEY_ARROW_UP_COMMAND,
		(payload) => {
			console.log("up to down")
			const event = payload
			if (event["handledByRemap"]) return
			event.preventDefault()
			event.stopImmediatePropagation()
			event['handledByRemap'] = true
			return editor.dispatchCommand(KEY_ARROW_DOWN_COMMAND, event)
		},
		COMMAND_PRIORITY_CRITICAL
	),
	editor.registerCommand<KeyboardEvent>(
		KEY_ARROW_DOWN_COMMAND,
		(payload) => {
			const event = payload
			if (event["handledByRemap"]) return
			event.preventDefault()
			event.stopImmediatePropagation()
			event['handledByRemap'] = true
			return editor.dispatchCommand(KEY_ARROW_UP_COMMAND, event)
		},
		COMMAND_PRIORITY_CRITICAL
	)
)
}, [editor])


snowflake_grant_privileges_to_role listed example doesn't seem to work

Provider Version
0.69.0
Terraform Version
1.3.5
Describe the bug
The below example is listed on the documentation (https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/grant_privileges_to_role)
# all in database
resource "snowflake_grant_privileges_to_role" "g11" {
  privileges = ["SELECT", "INSERT"]
  role_name  = snowflake_role.r.name
  on_schema_object {
    all {
      in_database = snowflake_database.d.name
    }
  }
}

From everything I have tried, this doesn't seem to work. If this isn't how the resource works now, could we get the documentation updated?
Expected behavior
For the code to run without errors
Code samples and commands
Additional context

@florencewambui, it doesn't seem to change anything. I tried it with and without the provider attribute and got the same results. I am guessing that it worked in 0.68 and the functionality was changed or removed in 0.69+ versions. I can't even do a "terraform validate" without getting syntax errors.
PS C:\terraform\> terraform validate
╷
│ Error: Missing required argument
│
│   on main.tf line 367, in resource "snowflake_grant_privileges_to_role" "g11":
│  367:     all {
│
│ The argument "object_type_plural" is required, but no definition was found.

Also then granting ownership privilege there no option to provide COPY/REVOKE CURRENT GRANTS

@systematics78 I agree. I haven't seen the implementation of the COPY/REVOKE CURRENT GRANTS in any resource that deals with the OWNERSHIP privilege. This is basically mandatory in order to change ownership on existing objects.

I get the same error. It seems the "all in database" functionality is what doesn't work. The documentation is wrong, or the code needs to support what the documentation says.
│ Error: Missing required argument
│
│   on redacted.tf line 326, in resource "snowflake_grant_privileges_to_role" "redacted":
│  326:     all {
│
│ The argument "object_type_plural" is required, but no definition was found.

I was able to get mine working by limiting the scope of the grants to one object type, in my case tables. Another resource block would be needed for another type like views.
...
  on_schema_object {
    all {
      object_type_plural = "TABLES"
      in_database = "..."
    }
  }
...

Can someone please provide example to replace snowflake_table_grant to  snowflake_grant_privileges_to_role  to grant table privileges SELECT to share
   7: resource "snowflake_table_grant" "grant" {
│
│ This resource is deprecated and will be removed in a future major version release. Please use snowflake_grant_privileges_to_role instead.
│

Hey, soon we should have a migration guide in our MIGRATION.md document on how to migrate old grant resources to new ones.

Hey @Bryan-Meier, could you confirm the doc fix was provided and close the issue?

The doc update looks good. Thank you for this!


Add a callback to handle allocation requests

First take at #324.
The idea is to make it possible to customize the behavior of the TURN server in order to admit/deny allocation requests (e.g., to implement user quotas) or redirect clients to an alternate server.
type AllocationHandler func(clientAddr net.Addr) (alternateServer net.Addr, errorCode stun.ErrorCode)

Currently the allocation handler is per-listener (i.e., per PacketConnConfig and per ListenerConfig) and it is called just before the server would create a new allocation.
The PR contains a minimalistic implementation plus a test to get a feeling of the new API.
Some observations:

client API: we will need to find a way to return the alternate server IP from client.Allocate(), should the server respond with a "Try Alternate" error (maybe the returned error could have a StatusCode and a Parameter of type any to return meaningful errors?) -- an alternative would be to automatically follow redirects in the client until we get to a usable server, but I guess this behavior should be made configurable,
handle the ALTERNATE-DOMAIN attribute: the current API allows to return an alternate server address, but no alternate domain (see here).
user quotas: the current API is not enough to implement user quotas, in that we can already prevent over the quota allocations from being made but, given that we are only called on allocation creation but not at deletion, we cannot know when an allocation goes away, effectively resulting in blocking all access for the user indefinitely.

My takeaway is that most probably we'll need two distinct APIs to handle user quotas and redirects:

the allocation handler will be fine for redirects (but maybe we can change the name to RedirectHandler, plus we may also need to handle the alternate domain case)
user quotas need to track the lifecycle of allocations and  that will require a new callback, say, QuotaHandler:type QuotaHandler func(clientAddr net.Addr, username string, new bool) (bool, error)

setting new=true would mean it's a new allocation (otherwise we're deleting one), and returning (false, nil) would mean to deny access for the new allocation.

Sure, it's perfectly doable. Any thoughts on the client side API? How should we return the alt-server and alt-domain from client.Allocate? Or should we just merge this in ASAP and find out client-side API later?
I'll update the redirect handler to return the alt-domain too ASAP.

Hi @rg0now,

Any thoughts on the client side API? Or should we just merge this in ASAP and find out client-side API later?

I think, I would merge the server side handlers first and care about the client side changes via another PR.

How should we return the alt-server and alt-domain from client.Allocate?

I think this would break the API which I would like to avoid.
I think we could easily handle this by returning a custom error type:
type TryAlternateError struct {
    AlternateServer net.Addr
    AlternateDomain string
}

func main() {
   ...

   conn, err := c.Allocate()
   if err != nil {
       var altErr *turn.TryAlternateError
       if errors.As(err, &altErr) {
           connectAlternate(altErr.AlternateServer, altErr.AlternateDomain)
       }
   }
}

On a second thought:
I think we should probably also simplify the signature of the allocation handler to:
type AllocationHandler func(clientAddr net.Addr) error

Then we can use the same TryAlternateError from my previous comment.

I would also prefer to keep handlers closely related to the associated TURN methods.
E.g. I think a AllocateHandler can cover more possible use cases than a RedirectHandler or QuotaHandler.
However, you have a valid point regarding the release of allocated resources..
Following my line, we might also need to add an AllocationExpiredHandler which the user would need to hook for releasing resources.

In my projects, I usually try to use interfaces for the implementation of handlers:
But this is a larger, API-breaking change, which I am not sure we really need to do now:
type AllocationHandler interface {
    Allocate(clientAddr net.Addr, username string) error
}

type AllocationExpiredHandler interface {
    AllocationExpired(clientAddr net.Addr, username string) error
}

type PermissionHandler interface {
    CreatePermission(clientAddr net.Addr, peerIP net.IP) error
    ExpirePermission(clientAddr net.Addr, peerIP net.IP) error
}

type AuthenticationHandler interface {
    Authenticate(username, realm string, srcAddr net.Addr) (key []byte, err error)
}

type ServerConfig struct {
    Handler any // this handler can implement any of the previous interfaces
}

The advantage of tying the handlers to a struct would be, that the user can easily associate state to the handlers (like a quota database).  Or implement handlers which implement subset of the aforementioned interfaces.

This makes a lot of sense. In Kubernetes we use API versions to handle breaking API changes: we release a new version (say, v1alpha2 on top of v1alpha1), an automatic converter that upgrades an API call from the old version, and then we deprecate the old API and stop supporting it after 2-3 release. I really miss API versioning from Go (or any other programming language for that matter): it would make such API upgrades much simpler.
Anyway, here's the current plan, let me know if you're fine with it:

add a new handler to PacketConnConfig and ListenerConfig types with the signature:type AllocationHandler func(clientAddr net.Addr) error

insert a call to the allocation handler into internal/server/turn.go:handleAllocateRequest
add an example that demonstrates a TURN server that returns a redirect error for allocation requests
worry about the client-side interface later.

As per the last point, I'm happy to implement the TryAlternateError API too, let me know if I should do it now or put it into another PR.

Hi @rg0now,
I am missing just one thing: the AllocateHandlers signature is not very feature proof. We cant handle additional attributes if we want to use the handler for other purposes (e.g. quota handling).
I am thinking about attributes like:

USERNAME
REQUESTED-TRANSPORT (for #311, #315)
REQUESTED-ADDRESS-FAMILY
ADDITIONAL-ADDRESS-FAMILY
...

What do you think about simply passing the stun.Message as a second parameter?

What if we create a struct with all the data the caller would ever need to make a decision (like the username, transport, etc.) and pass that to the callback?

I had the same idea. I think this would work as well as we can extend the structure in the future 👍

The problem I see here is that we do not know the five-tuple at the time when CreateAllocation handler is called. Hence, the quota handler can not correlate the quota allocation (CreateAllocation) to the release (AllocationDeleted).

Hmm, I really want to get this right so let's see what is that I don't understand.
Let's pass a struct like this to the CreateAllocation handler:
type AllocationDescriptor struct {
	Username                   stun.Username
	FiveTuple                  allocation.FiveTuple
	RequestedTransportProtocol allocation.Protocol
	RequestedAddressFamily     proto.RequestedAddressFamily
	AdditionalAddressFamily    proto.RequestedAddressFamily
}

The allocation handler interface would look like this:
type AllocationHandler interface {
	// CreateAllocation is called before the server making a new allocation. Return an error to prevent the allocation from being made.
	CreateAllocation(desc AllocationDescriptor) error
	// AllocationDeleted is called by the server after deleting an allocation. This is useful to track the lifetime of allocations.
	AllocationDeleted(fiveTuple *allocation.FiveTuple)
}

We would call the CreateAllocation handler in internal/server/turn.go:handleAllocateRequest. The structure of this longish function would look like this:
func handleAllocateRequest(r Request, m *stun.Message) error {
	// integrity check

	// create client-side 5-tuple
	fiveTuple := &allocation.FiveTuple{
		SrcAddr:  r.SrcAddr,
		DstAddr:  r.Conn.LocalAddr(),
		Protocol: allocation.UDP,
	}

	// check if allocation already exists
	if alloc := r.AllocationManager.GetAllocation(fiveTuple); alloc != nil { ... }

	// handle RequestedTrasnport, AttrDontFragment, ReservationToken and EvenPort

	// call the allocation handler's CreateAllocation callback
	desc := alloc.NewAllocationDescriptor()
	err := r.AllocationManager.allocationHandler.CreateAllocation(desc)
	if err != nil {
		// return err to client
	}

	// create the allocation...
}

Another option here would be to call the CreateAllocation handler from internal/allocation/allocation_manager.go:CreateAllocation, this seems more "self-contained" but at this point we lost our stun.Message so we have to pass the necessary AllocationDescriptor fields (username, etc.) as arguments.
Finally, internal/allocation/allocation_manager.go:DeleteAllocation would look like the below
func (m *Manager) DeleteAllocation(fiveTuple *FiveTuple) {
	m.allocationHandler.AllocationDeleted(fiveTuple)

	// delete and close allocation
}

Wdyt?

Hey @rg0now,
thanks for the detailed description :-) I think I got this wrong. I was under the impression that the five-tuple contains:

Client IP+Port
Relayed IP+Port
Protocol

However, you seem to be correctly using the clients connection local address (from server perspective) instead of the relayed address.
I still need to understand why this works. This way, it seems like the client can not create multiple allocations using the same connection to the server as these would all use the same five-tuple?

I still need to understand why this works. This way, it seems like the client can not create multiple allocations using the same connection to the server as these would all use the same five-tuple?

Yes, this strikes me as odd too, but it seems that each turn.Client can support only a single allocation (the client actually caches the relayedConn). This seems like an assumption we don't quite document. If you want more allocations, create more Clients, each with a separate net.PacketConn and, hence, with a separate FiveTuple.
The useful consequence of this assumption is that we can use the FiveTuple to identify allocations, like in internal/allocation/allocation_manager.go:GetAllocation:
func (m *Manager) GetAllocation(fiveTuple *FiveTuple) *Allocation {
	m.lock.RLock()
	defer m.lock.RUnlock()
	return m.allocations[fiveTuple.Fingerprint()]
}

Maybe the reason of why you're finding this confusing now is that you're deep into the implementation of RFC6062 TCP allocations and the client model is so much different for TCP.

Okay, I've read the TURN RFC (again) 😁
It clearly says that the five-tuple is identifying the client-server connection and that a client may only have a single or dual allocation active (dual as in dual-stack when requesting an allocation with relayed addresses for multiple address familiies e.g. IPv4 + IPv6).
See: https://datatracker.ietf.org/doc/html/rfc8656#name-allocations-2
This now also resolves some of my confusion in regard to the TCP allocation PRs which we are currently working on 😃
So now, I can fully support your proposed implementation 👍
Just with one remark:
I would try to keep the handlers out of the AllocationManager and just to Server since I think it would be cleaner if the  AllocationManager does not need to care about the handlers. I would try to keep them just to the Server types.
I still try to understand why somebody thought it was a good idea to have both a public Server and internal Server type -.- I believe, this makes a lot of stuff more difficult to understand. But thats a different topic :D


Improve ballerina streams performance

Purpose
Purpose of this PR is to $title.
Fixes #20004
Remarks
https://github.com/ballerina-platform/ballerina-lang/pull/20013

Codecov Report

Merging #20005 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #20005   +/-   ##
================================================
  Coverage            20.51%   20.51%
================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
================================================
  Hits                   286      286
  Misses                1095     1095
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb52e38...8f8bc8e. Read the comment docs.


TODO in this fork

[ ] TODO: Using Danbooru API to find out tag's category
[ ] TODO: Add Option for Users to choose renaming with character or non-character tags

for the first TODO: I'm going to check if pybooru fits my needs


chore: fix for console not respecting admin url

Fix for console not respecting admin url
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
After the webpack upgrade we stopped respecting env variables. This was due to a change in when we were reading them and passing them to the front-end. Env variables are now filled in at runtime vs. build time.
Tracking Issue
https://github.com/flyteorg/flyteconsole/issues/463

Looks good


V3.0.0 - Big Refactor, updated libraries, project converted to typescript, Popup refactored

Changes:

Project converted to Typescript
Updated tests to work correctly with typescript
Updated jest and lint configuration
Refactored the popup component separating responsibilities
Updated example project for working correctly with the last version of react-native-map-link
From the main function of index, I extracted logic to create new functions, allowing them to be tested in the future if necessary and removing direct responsibility from the parent function.

Break Changes:

Removed use of react-native-modal to use modal directly provided by react

This is really awesome @Fabianurrutia! Thanks for doing all this work, so cool!
Give me a few more days to look into this and give it a test, and then we can get it merged next week.

This looks great - I have one question, that I couldn't really find the answer to online: don't we need to compile the Typescript before publishing to NPM to make it work in older RN projects?
It looks like the current version of metro might support Typescript bundling of node modules out of the box, but most RN packages I could find on Github include a compilation step before publishing to NPM, I think we might need to add that as well?

Yes, you're correct. It's generally a good practice to compile TypeScript code before publishing to npm, especially if you want to ensure compatibility with older React Native projects or environments that might not support TypeScript natively.
I missed testing with previous versions, give me a couple of days and I'll do the update so it compiles correctly.

Made one small change to the push workflow - going to merge this now, thanks for your amazing work on this!

Also, I am wondering what the reason is for removing react-native-modal because the built-in one in RN is very barebones.

Agree with that. After upgrading to v3, the popup style was broken in our project. We need to build a new popup in our side.

Yeah, that's a fair point. We can do more to fix the default styling here.
I'm happy with the move away from the separate react-native-modal dependency though, because only a small subset of the users of this library use the popup, so I want to keep the lib as lightweight as possible.
Happy to accept styling/UX improvement PRs for the popup though!

I'm happy with the move away from the separate react-native-modal dependency though, because only a small subset of the users of this library use the popup, so I want to keep the lib as lightweight as possible.

Fwiw react-native-modal could be added as an optional peer dependency, so that users can choose whether to install it or not.
I'm not sure whether only a subset of users use the popup, though; the popup has been the main use of this library for us in several projects. As of now, we need to stick to v2.
PS: The change could've been better documented as well. We only caught this after upgrading, and we had to revert.

Yep. A detailed migration guide is necessary for a major version bump with such lots of breaking changes


Part function broken

Another annoying failure
13:31:57 < deer-spangle> Hallo part
13:31:57 < Hallo> Function failed with error message: list index out of range

I believe this is fixed with 569a768eec4ac5aa266b4d775e54d69eee544451 Although I would like to write some tests for LeaveChannel before merging to master

https://github.com/joshcoales/Hallo/pull/155


Add some testing of the backup functionality.

This adds some testing of the backup functionality.
It tests using a single Step(-1) call, as well as multiple Step() calls.
It also does some testing of the PageCount() and Remaining() methods.

Coverage increased (+3.4%) to 69.817% when pulling 3a5d0a7e5b045a61f995822398788cda0d4435fb on a-p-:backup-tests into c3e9588849195eefa783417c3a53d092f6e93526 on mattn:master.

Coverage increased (+3.4%) to 69.817% when pulling 3a5d0a7e5b045a61f995822398788cda0d4435fb on a-p-:backup-tests into c3e9588849195eefa783417c3a53d092f6e93526 on mattn:master.

Cool.


Update Sign-ins log retention period

As announced in blog below, AAD Free users can see sign-ins log for 7 days.
https://techcommunity.microsoft.com/t5/azure-active-directory-identity/new-tools-to-block-legacy-authentication-in-your-organization/ba-p/1225302

@juntakata : Thanks for your contribution! The author(s) have been notified to review your proposed change.

This has already been fixed.
#please-close


Unneeded variables

clang prints these warnings:
warning: variable 'pubkey_example' is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const char pubkey_example[]   = "PT0gZWQyNTUxOXYxLXB1YmxpYzogdHlwZTAgPT0AAAC973vWScqJr/GokqY4CXskGdqTbPIpH1bMJ9nX+VdFYw==";
                  ^
yaml.c:42:19: warning: variable 'seckey_example' is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const char seckey_example[]   = "PT0gZWQyNTUxOXYxLXNlY3JldDogdHlwZTAgPT0AAACwCPMr6rvBRtkW7ZzZ8P7Ne4acRZrhPrN/EF6AETRraFGvdrkW5es4WXB2UxrbuUf8zPoIKkXK5cpdakYdUeM3";
                  ^
yaml.c:43:19: warning: variable 'time_example' is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const char time_example[]     = "2018-07-04 21:31:20 Z";
                  ^

Thanks for pointing these out.
https://github.com/cathugger/mkp224o/commit/390e8ea9deb520478d06b2065bbfc8d95fb26246
Should be okay now.

Thanks!


Fix webmodeler static image visibility

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   96.94%   96.94%
=======================================
  Files           4        4
  Lines         131      131
  Branches       28       28
=======================================
  Hits          127      127
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40af80d...87950a3. Read the comment docs.