[4.1][Feature] Change Route Key to something besides ID #2212

Change crud to use:
getKey() -> getRouteKey()
getKeyName()->getRouteKeyName()
and update searches to use $this->model->where($this->model->getRouteKey(),$id))

I missed edit. I will do more testing and resubmit

Wow - this is great work @MasterBratac . Thank you for taking the time to submit this!

@tabacitu Thank you. I was having problems with update and have not had the time to fix that yet.

The update function needs to stay as
$item = $this->model->findOrFail($id);//This will always use primary key. But since it is POST ok.
this is what is passed by the request.

I have a pull request into Laravel for the following which could also be easily implemented in the base crud class to change the route key by
protected $routeKeyName = 'uuid';

in the crud model. simply by changing the getRouteKeyName() function
public function getRouteKeyName()
    {
        return (isset($this->routeKeyName) ? $this->routeKeyName : $this->getKeyName());
    }

Let's see if they merge that or not. If not I may open a pull request for that later.
if @tabacitu might be interested in that.

@MasterBratac that sounds very interesting indeed - can you please link to the Laravel PR? Did it get merged? If so, I believe the changes needed in Backpack will be much smaller, which would be great 😄

Looking forward to this Backpack feature. I'm implementing UUID for some models but all relations are based on ID, so I will need to continue to use both.

Oooh... 🤯 now I understand!
Thanks for pitching in @martijnb92 ... I never prioritised this because I didn't see the particular use case where this is crucial. I think I understand now, please correct me if I'm wrong:

your models have UUIDs, so you want to show those in the route, not IDs;
your models also have IDs, set as primary keys, because your relationships are based on them;

The only way to solve this right now, would be to

make sure you define all parameters of your relationships - including the keys
set the UUIDs as the primary keys
Then the relationships won't be affected, they'll use the provided IDs. Right?

But what really needs to happen is that we should fix this, and use getRouteKey() and getRouteKeyName() - I agree. Thanks!

That's exactly the case. It does work if edit all the relations with the parameters, but I prefer to use 'getRouteKeyName()'  instead. Looks much cleaner.

We do have a similar usecase where all relationships are based on 'id' however want to expose UUID based routes.
This is an interesting feature and we are looking forward to get this implemented in backpack.

The progress on this looks great. I apologize I lack the skills to complete this myself.

Is this still planned for 4.2?
This might be helpful too
https://laravel.com/docs/8.x/routing#customizing-the-default-key-name

Is this still planned for 4.2?
This might be helpful too
https://laravel.com/docs/8.x/routing#customizing-the-default-key-name

@tabacitu There is now a much more simple implementation for this on the current branch and the ability to override
getRouteKeyName() in laravel. 3 small changes to Backpack, override the getKey() function from the model, and add 2 a trait. Would you like it as a new pull request?

@tabacitu There is now a much more simple implementation for this on the current branch and the ability to override
getRouteKeyName() in laravel. 3 small changes to Backpack, override the getKey() function from the model, and add 2 a trait. Would you like it as a new pull request?

@tabacitu
I submitted a different pull request for this.
#3490

@tabacitu
I submitted a different pull request for this.
#3490

@tabacitu
What about this one?
I see that it hasn't been touched since 2021.

Thanks for re-surfacing this @EmanueleCoppola . I see @MasterBratac has submitted https://github.com/Laravel-Backpack/CRUD/pull/3490 that is a newer PR than this. I'll close this PR and take a look at that one right now. Let's move the conversation there.


Change deliver_now to deliver_later

Use ActiveJob, in particular deliver_later, to deliver many emails. Rake tasks disappear fast, so we may not want to do that everywhere. Switching this should make this system a little more responsive in some cases.

http://edgeguides.rubyonrails.org/active_job_basics.html
There are a lot of back ends available. I am currently leaning towards delayed job, because then we don't need to install any other software, and it is highly reliable because it uses our already existing database system and ActiveRecord.

Notr this warning: "Using the asynchronous queue from a Rake task (for example, to send an email using .deliver_later) will generally not work because Rake will likely end, causing the in-process thread pool to be deleted, before any/all of the .deliver_later emails are processed. To avoid this problem, use .deliver_now or run a persistent queue in development."


[Tennistv] Rewrite

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Rewrite cause site got updated and no longer uses the older API endpoints.

Old code returns city, season and round.

https://github.com/yt-dlp/yt-dlp/blob/e7870111e83033e0ac728d5a2d565d1eb146c335/yt_dlp/extractor/tennistv.py#L110-L112
You can still collect that info, in attribute values of the same div that you are collecting description now.

It will be good to return same data.

and merge with master


Fix NetworkFirst waitUntil

NetworkFirst uses two promises (one for the network request, and one for the timeout). If the network request succeeds, then the timeout promise's timer is canceled. However, it attempted to wait until both promises resolved before the handler resolved as done; this meant that, if the network request succeeded, then it never resolved its handlerDone / awaitComplete promise.
Note: There are two potential issues with this PR:

I wasn't sure what to do about the "If Promise.race() resolved with null" case, when the NetworkFirst strategy falls back to waiting on the network request. Should the code ensure that handler.waitUntil(networkRequest) is called in the case of a network timeout + cache miss?
I updated a test to try and cover this case, but I couldn't figure out how to run the test suite to confirm my changes. (I found the test_server gulp task and navigated to http://localhost:3004/test/workbox-strategies/sw, but I get console errors, so I must be doing something wrong.)

R: @jeffposnick @philipwalton
Fixes #2721

Thanks a ton for investigating this and proposing a fix, @joshkel!
I'll take a look, but @philipwalton touched this code more recently, so it would be great if he could give a review as well.
(Regarding manual test running, instead of using http://localhost:3004/test/workbox-strategies/sw, it should be http://localhost:3004/test/workbox-strategies/sw/, with a trailing /, or else the service worker won't register properly. This always annoys me too, and we should fix the server to automatically redirect.)

Thanks, @jeffposnick. I don't think that adding
handler.waitUntil(networkPromise);

is the best solution, because that partially undoes the timeout - if the network is slow, the initial response can still come through when the timeout expires, but the handler's waitUntil / doneWaiting won't resolve until the network request resolves.
I pushed an alternate approach; please let me know what you think. Thanks.

Thanks again for your continued work on getting this straight! This latest update is 👍 from me, but I would appreciate a final look from @philipwalton before we merge.

Done. Thanks for the reviews, @jeffposnick and @philipwalton.


TangoController just saves problems from the JSON given in the feedback

TangoController doesn't check the actual assignment and map problems to scores received from the feedback

This has been resolved and merged.


Animation Player Tracks

Was able to find the delay effect tap time using the following script:

extends Node
var delaytap1 = AudioServer.get_bus_effect(1,0).tap1_delay_ms
func _process(delta):
print(delaytap1)

However I can't figure out how to not make this an animation track

Fixed with a export keyword. Added set/get functions to make it work as expected.


create DB from command line

Is there a way from the command line to create a new database? I.e. not using aardvark or arangosh. If not, please consider this a feature request :)

If you were thinking about bash, then the following command should do it:
curl -X POST http://<IP_ADDRESS>:8529/_db/_system/_api/database --data '{"name":"myDatabase"}'
If you can can use arangosh but don't want to use it interactively, you could use
echo 'db._createDatabase("myDatabase");' | arangosh
I am not sure if that helps.

Thanks @jsteemann - that help. I still think a dedicated cmd-line tool like foxx-manager would be nice, but I'm going to close this for now.

+1


Add a hidden concurrency option

Inspired by the long dormant https://github.com/buildkite/agent/tree/lol-workers and the need for high-concurrency agents for testing lockfiles, I added a hidden --concurrency flag.
Have been giving it a workout with -race on and have sorted out the various leaks.

That branch name 😂

I figure I'll land this in 3.1 unless anyone objects. We can perhaps consider proper public support in 4.0?

I don't have much else to add to this! But I'm keen to hear from @keithpitt and @sj26 for how it works conceptually w/ Buildkite

I believe they will use there own http connections, we could definitely look to consolidate them, I wonder if that would have conurrency issues between the go routines.

I was aiming for "no worse than running the same concurrency of top-level processes"

@lox yep, I reckon don't worry about it for now.
The signals and figuring out stopping are the only blockers on my mind. Tweaking the log verbosity is a nice-to-have.

@lox the other "nice to have" with this change is if we could send some sort of identifier to the registration API that this agent was spun up along side others.. maybe it'd be called SpawnUUID or something? We'd only send it if the agent was run with spawn > 1.
Then in the BK backend (when stopping an agent) we'd be able to also stop the other agents it was registered along side.

I'm happy with this direction, ask for review again when we're ready to let it loose?

Just gonna remove myself from the review requests until we do another around of looking at this :)

I investigated adding a prefix to the logger, it's super hard as the logger gear uses globals and package-level methods. I will add another PR with a refactor of the logging gear after this lands.

I know it's probably too late for naming, but what about --count?
buildkite-agent start --token abc123 --count 5


vim indent plugins

Since our team moved to Standard, I'm having difficulty finding a vim indentation plugin for JS that dos the correct thing, some examples of code structures that break most/all vim indenters I've tried:
single line if statements:
if(foo) return foo
  return bar

ending brackets or braces after last item:
let foo = [something, somethingElse, somethingExtra, batarang, purpleBallons,
  cats, dogs, lions, tigers, bears]
  // bad indent!

I'm jut wondering if any Standard/Vim users have found a better indent, or have workarounds for these issues.

https://github.com/pangloss/vim-javascript has some recent updates. Seems to do just fine in most cases.

@pomke Have you given @mcchrish's suggestion a try?
I'm going to close this issue now, as it's been open for a month and I want to keep the issue tracker tidy 👍 Feel free to continue discussion.


Postmill rate limit.

We're hitting a rate limit when testing the Postmill/reddit questions. Is there a way to disable this?

@robert1003 can you explain how to reset the rate limit for trust users?
cc. @frankxu2004

As for resetting the rate limit, I think the simplest way is to reset the whole docker container with the provided image, and apply the above fix.

Actually to kill the rate limit completely, there's a hack. We left the website mostly as-is for it to mimic real websites as much as possible (e.g. real websites usually have anti-spam or anti-bot mechanism).
Nonetheless, if you think this is too much of a hassle, then:

Fantastic. Thanks!


What is the mathematical logic of running UMAP multiple times?

Hi! I love UMAP and use it extensively for my analysis.
I'm developing new single-cell visualization methods and came up with a particularly interesting Riemannian-manifold learning solution. I'm then using UMAP on this data, rather than using traditional PCA metrics.
While running UMAP in these settings, it happened to me that data intrinsic dimensionality was too high for a more intuitive interpretation of the data even with 3D UMAP plots. I then tried running UMAP with 100 components and then gave these as an input to a new UMAP embedding.

#In Seurat v3:

neu <- RunUMAP(neu, reduction = 'Beltrami', dims = 1:100, min.dist = 0.5, reduction.key = 'dbMAP_', n.components = 100)
dual <- neu<EMAIL_ADDRESS>neu<EMAIL_ADDRESS><- dual

neu <- RunUMAP(neu, reduction = 'dual', dims = 1:100, min.dist = 0.5, reduction.key = 'dbMAP_', n.components = 3)
triple <- neu<EMAIL_ADDRESS>neu@reductions$triple <- neu@reductions$dual
rownames(triple) <- colnames(neu)
neu<EMAIL_ADDRESS><- triple

neu <- RunUMAP(neu, reduction = 'triple', dims = 1:100, min.dist = 0.5, reduction.key = 'dbMAP_', n.components = 3)

I've uploaded the resulting plots here.  Surprisingly, initial clusters were more aligned after this. Although the results are reasonably similar, they do differ in the resulting branching resolution. This is interesting.
However, as I don't understand the internal mechanics of UMAP, I'm unsure if visualizing data through these 'multi-embedded-embeddings' is reliable at all. What is the mathematical logic of running UMAP multiple times? Is there any logic at all in it?
Any clues from the developers or the UMAP community?

Maybe that section helps you: https://umap-learn.readthedocs.io/en/latest/faq.html#can-i-cluster-the-results-of-umap
Especially this part:
... with its uniform density assumption, does not preserve density well. What UMAP will do, however, is contract connected components of the manifold together.

So you are basically doing that twice. UMAP also uses gradient descent so doing your same experiment multiple times may lead to different results.
In general readthedocs is very well written and clarifies a lot.

@davisidarta Did that clarify things?

@davisidarta Did that clarify things?

Hi @sleighsoft ! Thank you for your kind answer. I read umap's readthedocs throughoutly and it clarify things a bit.
However, it also made me question myself: if  one sets min.dist = 1, UMAP runs its constraints while preserving the original distances? If so, can one run UMAP multiple times in their data in order to constrain noisy/higher-dimensional data while keeping this parameter? Is there any particular case where this might hold true, such as with Riemmanian manifolds? What would be the UMAP's coordinates meaning in this scenario?
I'm questioning this due to the fact that it did work with a lot of cases. As the community of machine-learning grows, also does data dimensionality, and the ability to run UMAP multiple times could provide people with deeper insights on data.

UMAP doesn't preserve all distances -- that is, for example, something that MDS tries to do, with the caveat that managing to achieve that usually results in sub-optimal embeddings for many datasets. In particular this is because there are many more large distances between datapoints (in an all-pairs distance sense) and thus much more emphasis is ultimately placed on this and thus the optimization doesn't do entirely what one might want (unless, of course, preservation of all distacnes as much as possible is exactly what you want).
UMAP tries to preserve local distances as much as possible, while trying to retain some of the global structure if it can. Even with that said the uniform distribution assumption, along with the local connectivity assumption create significant distortions to the ambient distance structure, so what UMAP is preserving is not high dimensional distances, but rather something else again -- an approximation of manifold distances under certain assumptions.
On top of all of that UMAP pursues an stochastic optimization approach on a non-convex optimization problem and certainly does not achieve the optimum. So the output does not even preserve the local distorted distances described above. What UMAP is preserving is topological structure, up to a point. And ultimately it will tend to accentuate the structure it does find. That means that running UMAP multiple times will essentially be enhancing that accentuation of topological structures found. From a practical point of view that means that running UMAP on the output of UMAP will tend to increase the definition of connected component structure (i.e. increase the clustering), and collapse noisy structures down to simpler structures, hence the accentuation of linear strand like structures and loops that you see in your example.

Hi @lmcinnes ,
Thank you for the clarifying response! That's very interesting.  I'm going to investigate this further.
Best!


initial league app

Description
create a simple league of legends app to show champion and their subtitles
Copilot

🤖 Generated by Copilot at 89bfd8b
Summary
🎮🏆🧙

This pull request adds a new applet called League Champs, which shows league of legends champions and their subtitles on the tidbyt device. The applet code is in league_champs.star and uses various modules to fetch and display the data. The applet manifest is in manifest.yaml and defines the applet metadata.

League Champs applet
Shows champions and subtitles
On tidbyt device

Walkthrough

Create a new applet called League Champs that displays league of legends champions and their subtitles on the tidbyt device (link, link)
Load, cache, parse, and render the data from a CSV endpoint using various modules in league_champs.star (link)
Define a schema for the applet configuration in league_champs.star, which allows the user to choose the image position and the champions to display (link)
Filter the data based on the user's preferences using a filter_data function in league_champs.star (link)
Define the applet metadata in manifest.yaml, such as the id, name, summary, description, author, file name, and package name (link)

I have read the CLA Document and I hereby sign the CLA

recheck

all changes addressed


oci-adb-client-runsql-python - Issue

Get the following issue when trying to deploy  oci-adb-client-runsql-python sample:
Complete output from command python setup.py egg_info:
        =============================DEBUG ASSISTANCE==========================
        If you are seeing an error here please try the following to
        successfully install cryptography:

        Upgrade to the latest pip and try again. This will fix errors for most
        users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
        =============================DEBUG ASSISTANCE==========================

Hi @tanker110, is this the error you are seeing "ModuleNotFoundError: No module named 'setuptools_rust'" in the last line of the output when you run "fn -v build" or while run the deploy command?
If yes, then can you set the version of the "oci" python sdk to 2.40.0 in function's the "requirements.txt" ... We have updated the function sample with this change.
oci==2.40.0
Looks like there is a new dependency introduced in oci python sdk library from version 2.40.1. The cryptography<=3.4.7,>=3.2.1 results in an error "ModuleNotFoundError: No module named 'setuptools_rust'"
Please reopen the ticket is you run into issues with the suggested change.

Hi @tanker110, we have updated the Dockerfile and func.yaml for this sample to use the latest OCI Python SDK (versions 2.40.1+). We had to update pip in the Dockerfile. The OCI Python SDK (version 2.40.1) updated the Cryptography versions. The new Cryptography uses a newer version of setuptools which is not available in Pip. Updating Pip gives you access to download that.

Hi Sachin,
Thank you so much. Before I heard from you I was able to add pip upreade and install rust to the docker file. Thanks so much for your response.
We are doing a proof of concept of moving our infrastructure to the cloud and was testing some of the function ability. I too the python using client and changed it a bit
To use an event that would get trigerred when users drop files into object storage bucket. It would read the file name from the JSON event and pass it to oracle to run a procedure.
I’ve never done anything in python so it was unique experience. I did have a question about the DB ENCRYPT password. Is that added in plain text in the configuration parameters on the OCI interfave and then is encrypted once the call to the function is made? I wasn’t sure how that worked. I also added a try catch when I call the procedure so I could catch Object not found. For example
If a user dropped a file in the bucket then immediately removed it. I wanted to be able to log a clean Object not found in bucket. So far it seems to work.
Thanks,
Tommy
From: Sachin Pikle @.>
Sent: Tuesday, August 31, 2021 5:34 AM
To: oracle/oracle-functions-samples @.>
Cc: Thomas Blue @.>; Mention @.>
Subject: Re: [oracle/oracle-functions-samples] oci-adb-client-runsql-python - Issue (#37)
EXTERNAL EMAIL: Please do not click on links or attachments unless you know the content is safe.
Hi @tanker110https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tanker110&d=DwMCaQ&c=xlPCXuHzMdaH2Flc1sgyicYpGQbQbU9KDEmgNF3_wI0&r=wny_FOQ7R36pj2oKlbR7VXardoJHNNGJsfPP198p040&m=y6OQ8WzXmvco2cmJMo1xtvdYWRzUQwcyCrJ_YSkbyYY&s=mPGj1dl1Y72DD5bYVlMMQHCmqYCL0NiyFFQmR4iNcKU&e=, we have updated the Dockerfile and func.yaml for this sample to use the latest OCI Python SDK (versions 2.40.1+). We had to update pip in the Dockerfile. The OCI Python SDK (version 2.40.1) updated the Cryptography versions. The new Cryptography uses a newer version of setuptools which is not available in Pip. Updating Pip gives you access to download that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_oracle_oracle-2Dfunctions-2Dsamples_issues_37-23issuecomment-2D909111806&d=DwMCaQ&c=xlPCXuHzMdaH2Flc1sgyicYpGQbQbU9KDEmgNF3_wI0&r=wny_FOQ7R36pj2oKlbR7VXardoJHNNGJsfPP198p040&m=y6OQ8WzXmvco2cmJMo1xtvdYWRzUQwcyCrJ_YSkbyYY&s=ar43ednijfHiEmUQrCxbKftmiceWrDfWsOTzTiPkizM&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVDIJY6NS7BZA3NDYFKGRCTT7SVYBANCNFSM5BULJGBA&d=DwMCaQ&c=xlPCXuHzMdaH2Flc1sgyicYpGQbQbU9KDEmgNF3_wI0&r=wny_FOQ7R36pj2oKlbR7VXardoJHNNGJsfPP198p040&m=y6OQ8WzXmvco2cmJMo1xtvdYWRzUQwcyCrJ_YSkbyYY&s=u3zxOpw9f3Sc6uLfBkRklR1UEmPkAB0XriBORud-tK4&e=.
Triage notifications on the go with GitHub Mobile for iOShttps://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=xlPCXuHzMdaH2Flc1sgyicYpGQbQbU9KDEmgNF3_wI0&r=wny_FOQ7R36pj2oKlbR7VXardoJHNNGJsfPP198p040&m=y6OQ8WzXmvco2cmJMo1xtvdYWRzUQwcyCrJ_YSkbyYY&s=VlFO8mC3OaiZKzhxHebsNOEuxzDVuyNOFb39Nkfh1Ms&e= or Androidhttps://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=xlPCXuHzMdaH2Flc1sgyicYpGQbQbU9KDEmgNF3_wI0&r=wny_FOQ7R36pj2oKlbR7VXardoJHNNGJsfPP198p040&m=y6OQ8WzXmvco2cmJMo1xtvdYWRzUQwcyCrJ_YSkbyYY&s=3ysrRqfgr6jSgWPYdYu641bG3jeWYI0fGvV4yLQLwFw&e=.


Counter Example

Just like Redux Counter Example
Part of #4

https://bl.ocks.org/curran/acde35df0c7939ff97740b4f9800258e


Moved config values to separate JSON file

Description
Closes #8.
Moved config values to separate JSON file
Author's Checklist

[x] These changes don't break existing dependants. If they do, and you suggest to proceed,
please explain why.

Reviewer's Checklist

[ ] All classes have documentation comments. - NA
[ ] All methods have documentation comments. - NA
[ ] No parameters are hardcoded. Should be loaded as properties instead. If there needs to be hardcoded properties, explain why.
[ ] All information to be logged/displayed to the user are internationalized. If not, explain why.  - NA
[ ] README.md has been updated if needed. - NA
[ ] pom.xml version is set to the latest date If not, explain why. - NA

Assignee's Checklist

[ ] All GitHub action checks have passed.
[ ] All reviewers have approved.
[ ] Relevant documentation has been updated if needed.
[ ] pom.xml version is set to the latest date If not, explain why.

Commit and branch is referring to the wrong github issue (should be #8)

Fixed it.


Meetup.com REST to GraphQL API Migration / Conversion - Requires Pro Subscription

UPDATE (April 15, 2024) : As noted below, RefactorGVL now has a Pro account and we would need to stay within their Terms of Service, including having a privacy policy defined before applying for an Oauth token through RefactorGVL's admin account.
The throttling of requests is on a points system.
Also, see https://github.com/hackgvl/hackgreenville-com/issues/172 for examples of using the GraphQL Playground and a couple other points.
----------------------(Notes from Aug 2022)----------------------------------------------------
@ramonaspence
It's unclear if/when Meetup will force everyone to migrate from REST to GraphQL and their API docs are now GraphQL specific.  I figure they'd list a date if they were planning to kill off the REST API, but you never know.  Plus, this would be an opportunity for both of use to use OAuth 2 and GraphQL on a real project. Both seem to be the latest tech for such things.
We'd probably use JWT Flow to authenticate over OAuth 2. I think each developer could create their own "OAuth client" with a unique AUTHORIZED_MEMBER_ID and CLIENT_ID which we'd likely store in the local .env / environment / config.ini file.  Of course, the production OAuth client would eventually be created, but I don't think we need to create an official Code For Greenville Events API client until we're closer to deploying changes to the live server.
I'm not entirely sure how expiration values and refreshing tokens works from a server to server flow, but I imagine it's not difficult.
Once the auth token stufff is taken care of, we likely need to do a query to groupByUrlname which returns a Group object, which has a upcomingEvents response as an UpcomingEventsConnection object, which then has pagination and edge details to help iterate through the list of UpcomingEventsEdge objects, which contains nodes as an Event object.

Not sure if this will be needed, but I did see that the Wayback Machine has copies of the old v2 REST API docs, which were removed and redirected to the GraphQL docs awhile back.
v2 REST API - GET /events
v2 REST API - GET /groups
And, yes, I have donated to Wayback Machine recently, because it does things like this for you.

RefactorGVL now has a Meetup Pro account.
This means the Meetup GraphQL API migration mentioned in the first post on this issue is likely possible.
We'd have to satisfy their Terms of Service and API License, but hopefully that's not a blocker since we're not "commercial".  It does expect that we'd have a privacy policy defined that

If making an application available, provide and comply with a user agreement and a privacy policy that describes how you collect, share, use, and retain user information. Your privacy policy must be at least as protective of the personal information of Meetup’s members as is Meetup’s Privacy Policy;

A privacy policy is on the meta list.
This may be an older doc, but it has some FAQs on the GraphQL version of their API.

@irby thanks for jumping on this one.
The notes above should be a good start.  @raiderrobert controls the Meetup Pro account, which it seems is necessary to create an eventual OAuth needed to hit the Meetup GraphQL API.

@raiderrobert @irby even with Meetup pricing increases mentioned in the community-organizers channel, it doesn't seem we're going to replace Meetup soon enough to continue hoping the REST API works.
The Refactor Pro account will likely be needed if we're going to try to authenticate to Meetup's GraphQL API.
We're not trying to create a client, since we're going server to server.  So, I think the JWT Flow in the docs is the way we'd have to authenticate.
Robert, it looks like either of the following links may have an interface to CRUD clients and gather more context for considering this issue
https://www.meetup.com/api/oauth/list/
https://www.meetup.com/api/oauth/create/

@allella I spoke with @raiderrobert yesterday. Yes, a Pro account is required in order to create an OAuth client, and we will need a client in order to generate the JWT necessary for JWT flow.
Robert submitted an application to create an OAuth client yesterday. It took a couple days for my application to be reviewed (and rejected because I wasn't Pro), so I expect it won't be for another couple days that we'll get a client together.
I have already made great strides on developing the code with what I've been able to get from the GraphQL playground. @bogdankharchenko was a tremendous help in getting me started.

Closing via #345


Looking forward to get involved and contribute to the community 🎉

First Name
Chanchal
Last Name
Bansal
Discord Username (if applicable)
Chanchal#3379
Let us understand your motive.
Hey there,
I am Chanchal and I am Open Source contributor. And I think this community will help me to make more amazing contributions. So, I would love to be a part of this community.

Hey @Chanchal1603 👋🏻
Thanks for requesting an invite! Welcome to SidHacks Community 🎉
Before going ahead, I would want you to complete the below To-Do list.
Your To-Do List ✔

Accept the invitation sent to you via mail.
Change the appearance of this organization to "Public" from the people list here.
Join our Discord Server here.

Accept the Rules from #📓〡rules channel.
Introduce yourself to our community in 👋〡introduction channel.

Feel free to share your excitement on socials with #SidHacksCommunity. You can also tag me @siddharth_hacks.

Close this issue once you complete all the above points.

Looking forward to interacting with you in our community! Welcome once again! 🤓

Yayyy, Done!
Thanks, Siddharth for such a warm welcome:D


Configure an application rule steps not clear using portal

If you follow the link https://docs.microsoft.com/en-us/azure/firewall/tutorial-firewall-deploy-portal at step #7 it doesn't specifically state which rule you should be applying the data to for Rules as there are "FQDN tags" and "Target FQDNs". It's confusing to know if it applies to the FQDN tags rule since that is the first field of options available. Then you get to step #10 that mentions "Target FQDNs". If step #7 is for the "FQDN tags" rule, then step #9 makes no sense since their is not the options for Protocol:port. You only have Protocol:port option under "Target FQDNs and that step starts at #10. Needs to be clear on which type of rule data is being applied to.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac13cbf3-f230-7e85-d57d-cba3196a166c
Version Independent ID: f4f0c94a-5a43-94e2-d8e5-19cf167c188a
Content: Tutorial: Deploy and configure Azure Firewall using the Azure portal
Content Source: articles/firewall/tutorial-firewall-deploy-portal.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@phillipgibson Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@phillipgibson
Yep, the UI changed after the article was written.
Update is in.

#please-close

@phillipgibson We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Checking $VIMRUNTIME read permissions will always fail on wsl

          `Cannot read $VIMRUNTIME directory "/opt/nvim-linux64/share/nvim/runtime". Ensure that VSCode has access to that directory. Also try :checkhealth.`

I'm getting that error but I do not fully understand what am I suppose to do, running on WSL, nvim installed from pre-built release
Originally posted by @Yusuf007R in https://github.com/vscode-neovim/vscode-neovim/issues/1816#issuecomment-1992304302

I have the same problem using flatpak neovim

Confirming I am running into the same issue.

That means that fs.readdirSync() failed on that directory. What is vscode-neovim or Nvim supposed to do if it can't read that directory? What are the permissions on the directory?

First time building the plugin from source and installing, so I may have done something wrong... I had to add wsl.localhost to my "Allowed UNCHosts" settings in VSCode to get past a new error, but after that I'm still seeing the Cannot read $VIMRUNTIME directory error logged in the terminal.


Corrected assertion

toEqual doesn't exist in Chai. to.equal does though. Perhaps this assumed a different assertion library?
Regardless, must use deep.equal in Chai to compare objects - otherwise Chai will do a reference type comparison, so the existing example would fail.

It's not using Chai, it's using https://www.npmjs.com/package/expect, which has toEqual. You'll see this a bit above your fix:
import expect from 'expect'

How'd I miss that?! Sigh. Thanks for the quick reply.


Create Mongodb indexes for targets

We're currently storing target documents with the target id and experiment id unindexed.
Indexing on exp_uid and target_id could significantly increase performance.

Never mind, indexes are ensured on targets.{exp_uid, target_id}: https://github.com/nextml/NEXT/blob/2dc302f17f772d5c03096f66b2db136c9e9c077d/next/apps/App.py#L268-L269


Tour throbber positioning off in editor fullscreen

Closing as duplicate of https://github.com/TryGhost/Ghost/issues/8559


Sky130 PDK data export script

(diffbase should be origin/meeting_08142023)

Looks great.
One thing I'll roll in after the fact - I would like this script and the parse_digital_cells one to both move into pdks/Sky130/scripts.
I'll do that after merging, along with some of the other file-name changes we discussed.


chore(main): release 1.0.0

:robot: I have created a release beep boop
1.0.0 (2024-11-03)
Features

init (e8be0d4)
initial release (5c140f6)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.0
:sunflower:


Adjust content overlay color

Currently there is a white opacity set on the overlay area (clickable region) behind the challenge view, see screen shot. We want to either change that to being fully transparent or black set to a 10 - 15% opacity.

The issue of the inconsistency relies in api.js adding an full screen overlay with background #FFF and opacity 0.05.
Solution: overwrite the style of the 2nd inner div by setting opacity to 0.
See PR: https://github.com/hCaptcha/hcaptcha-android-sdk/pull/2

The issue of the inconsistency relies in api.js adding an full screen overlay with background #FFF and opacity 0.05.
Solution: overwrite the style of the 2nd inner div by setting opacity to 0.
See PR: https://github.com/hCaptcha/hcaptcha-android-sdk/pull/2


Task/swagger marketplace api

In this pr:

Add swagger documentation for marketplace API.

This change is

Codecov Report

Merging #136 into swagger will decrease coverage by 0.02%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             swagger     #136      +/-   ##
=============================================
- Coverage      86.76%   86.74%   -0.03%
  Complexity      1276     1276
=============================================
  Files            113      114       +1
  Lines           3536     3537       +1
  Branches         152      152
=============================================
  Hits            3068     3068
- Misses           368      369       +1
  Partials         100      100

Impacted Files
Coverage Δ
Complexity Δ

.../java/org/oscm/rest/marketplace/EntryResource.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...org/oscm/rest/marketplace/MarketplaceResource.java
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

.../src/main/java/constants/MarketplaceConstants.java
0% <0%> (ø)
0 <0> (?)

Codecov Report

Merging #136 into swagger will decrease coverage by 0.02%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             swagger     #136      +/-   ##
=============================================
- Coverage      86.76%   86.74%   -0.03%
  Complexity      1276     1276
=============================================
  Files            113      114       +1
  Lines           3536     3537       +1
  Branches         152      152
=============================================
  Hits            3068     3068
- Misses           368      369       +1
  Partials         100      100

Impacted Files
Coverage Δ
Complexity Δ

.../java/org/oscm/rest/marketplace/EntryResource.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...org/oscm/rest/marketplace/MarketplaceResource.java
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

.../src/main/java/constants/MarketplaceConstants.java
0% <0%> (ø)
0 <0> (?)


Update readme to inform how to save settings

Quick readme update as it's easy to believe the repo is messed up. According to current owner of branch, it's no longer maintained.

This is a flow problem, not a plugin problem so I don't think this is the reight place for it.
Also, you should not have to restart flow. Just close the setting windows before typing any more command should be enough.

I have added a comment to a related FlowLauncher bug: https://github.com/Flow-Launcher/Flow.Launcher/issues/1877#issuecomment-1868269602
Meanwhile, I would strongly recommended to merge this PR and add info about saving into the Readme.


🐛 BUG: Legacy Env name computed on publish

What version of Wrangler are you using?
0.0.22
What operating system are you using?
Mac
Describe the Bug
Legacy environment mode should not compute name fields in environments.
result: name = my-worker-staging => publishes as my-worker-staging-staging

Not sure I understand exactly. Could you show what wrangler.toml looks like, and what command you run?

Ah ok I see. Yeah, if an environment has an explicit name, then we shouldn't add an environment identifier to it.

Capturing from offline discussion:
There is a weird case if the user provides the --name command line argument along with --env when dealing with legacy environments.
It is not 100% clear what should be the correct behaviour. Note that Wrangler 1 does not support the --name option.
We have decided, initially, to disallow this combination - --name + --env + legacy_env - for publishing. Providing a suitable error message that describes how to set the name in the environment section of the wrangler.toml if they wish to specify a name for a particular environment.

We have decided, initially, to disallow this combination - --name + --env + legacy_env - for publishing.

+1. I assume this would be an extremely rare combo anyway.


MERL-BRDF dataset

Hi, thanks for your impressing work.
I am trying to re-implement your code, however I didn't find the data-download link for your processed MERL-BRDF dataset. It seems the public-available source databse is different from that one used in your codes.
I also noticed the code under nerfactor/brdf, but the readme file said we needn't run it directly. However it truly leads to errors when directly run the shell command.
Can you please share the download link of your processed MERL-BRDF dataset, or your processing code

Sorry, I found the scripts under nerfactor/data_gen now. Please delete this issue.


add(mempool): Verify orphaned mempool transactions

Motivation
We want to verify transactions in the mempool that spend the transparent outputs of other transactions in the mempool.
Closes #8777.
Solution

Adds a handle to the mempool service in the transaction verifier
Adds AwaitOutput request in the mempool service
Updates the spent_utxos() method in the transaction verifier to try querying the mempool for spent outpoints before returning a TransparentInputNotFound error.
Polls the mempool service from the transaction verifier after verifying a mempool transaction that creates new UTXOs (in case they're spent by other mempool transactions that are still being verified)
Updates getblocktemplate method and ZIP-317 transaction selection to include transactions that spent the outputs of other transactions in the mempool when all of their dependencies have been selected

Tests
Added tests to check that:

Inserting a transaction also updates the transaction dependencies tracked in the verified set
The Storage.remove() method works as expected (the rest of evict_one() should be covered already)
The mempool responds to AwaitOutput requests when the output for the queried outpoint is:

Added to the mempool
Already available in the mempool

The transaction verifier:

Calls the mempool with AwaitOutput requests as expected and processes UnspentOutput responses correctly
Polls the mempool after verifying a mempool transaction that creates new transparent outputs
Includes all of the expected spent_mempool_outpoints in its response

Long poll ids remaining consistent as long the mempool contents are unchanged (and everything else is unchanged)
ZIP-317 mempool transaction selection excludes transactions that have dependencies unless their dependencies have already been selected

If needed, this PR could also add tests for:

ZIP-317 mempool transaction selection always returns the right order of transactions (this could be unnecessary since they’re sorted afterwards anyway but it could be a good sanity check)
The getblocktemplate method returns transactions with dependencies in the right order when the transaction hashes would have them sorted in the wrong order
Ideally at least a basic acceptance test that checks that it all works via RPCs

Follow Up Work
The mempool's Downloads sends a result to the response channel too early, it should wait until the transaction is being inserted into the mempool's verified set.
PR Author's Checklist

[x] The PR name will make sense to users.
[ ] The PR provides a CHANGELOG summary.
[x] The solution is tested.
[x] The documentation is up to date.
[x] The PR has a priority label.

PR Reviewer's Checklist

[ ] The PR Author's checklist is complete.
[ ] The PR resolves the issue.

@upbqdn can you please review this one?

This is a complex PR (not your fault, it's a complex issue). I've been reviewing it for a while but it feels I could spend ages reviewing this to be 100% sure. I'm OK with approving it but do you think we should ask for someone else to take a look?

In hindsight, it probably should've been split into multiple PRs. A second review would be ideal since it involves concurrency and consensus changes, though it has also gone through a few rounds of self-review.

Also, did you manage to test it for the use case we wish to address (i.e. sending to tex addresses?)

I haven't, and there's no acceptance test that tries to submit an orphaned transaction (I didn't know how to make one), I'll try doing that now.

I'm also still reviewing.

What do you mean by "orphaned" transactions in the title?

Transactions that spend outputs that are missing in the chain state, though I'm not sure if "orphan transactions" is the right term if those outputs can still be found in the mempool.

What do you mean by "orphaned" transactions in the title?

Transactions that spend outputs that are missing in the chain state, though I'm not sure if "orphan transactions" is the right term if those outputs can still be found in the mempool.

This RFC, https://github.com/zcashfoundation/zebra/blob/257567b559dba0359519d61684e80daac52cc434/book/src/dev/rfcs/0005-state-updates.md#L62, defines orphaned blocks as those that are no longer included in the best chain, which implies they were mined at some point. I'd assume orphaned txs are those in such blocks, but this PR doesn't apply to them. Maybe something like "Verify mempool UTXOs"?

I'm trying to figure out what happens if someone submits txs containing a circular dependency. We should make sure we can handle such cases well.

The transaction verifier would return an TransparentInputNotFound error for both because (unlike pending_utxos in the state service) the mempool only responds to AwaitOutput requests once the transaction creating that output has been added to the mempool's verified set.

@mergify refresh

@mergify requeue

@mergify queue


LG Ultrafine Brightness multi-monitor

I've tried your GUI tool and it works perfectly 🙂 ! Only problem is I have two Ultrafines 4k connected to my Windows PC and the tool will only control one of the two. Do you know if it would be possible to update it to target all connected monitors?
(I haven't looked at the code yet, but might take a look this weekend to see if I can find a way to do this).

oh! really nice to hear that!
Yes sure it should be possible, as I only deal with the first found monitor with the device id. I'll report in when I touch the code.

...and it would be great if you edit & compile the code yourself, as I'll probably lose my office with LG5K soon, so no more real device validation...not sure when I can buy one myself 😢
the code is a bit not well organized, as I was trying to develop a conf file feature, but haven't done due to recent activities...

@yo1995 Sounds good. Sorry to hear about the LG5K. It's a great monitor!
I've been playing around with it yesterday and replicated the code in C# without the need for a 3rd party library. I'm going to see how difficult it would be to ship that on the Windows Store for people to use more easily.

@yo1995 I've gotten carried away and ended up building a full GUI tool to control the brightness. Let me know if you'd like access to the beta 🙂
https://www.reddit.com/r/bootcamp/comments/f67u1e/lg_ultrafine_brightness_control/

@quentez Super nice and looks slick! Once you have the release version, please let me know so I can put a redirection to your version in the readme. 😃

@yo1995 The app is now live here: https://www.microsoft.com/en-us/p/lg-ultrafine-brightness/9n5mj2fq4gww
Let me know what you think 🙂 !

Thank you so much for this @quentez! Just installed it from the MS Store and it allows my HP Elitebook to control the Ultrafine 5K’s brightness perfectly and conveniently. Left you a good review. Thanks again!

@duc1701 Glad I could help 🙂 !
I'm happy to hear it's working with the 5k version. I wasn't able to get my hands on one.

@quentez Thanks for your help, and I've added a pointer to your MS Store version in the README!
As I've lost my access to the 5K, I hope your software can help even more users who find this repo! 😺


Pause/Resume with Views

Hi,
Does the pause/resume feature work with views?
I used the examples/view.py code and added pause/resume. Unfortunately after resume was called then I started to receive all updates and not just my filtered view.
Thanks,
Peer

I think it’s a bug. When resuming, it doesn’t pass the set views to the server. I will fix this in the next release. ETA is about 15 days.

Awesome, thanks for the prompt reply and future fix.
Thanks,
Peer
On Tue, Sep 5, 2017 at 16:27 Wiwat Tharateeraparb<EMAIL_ADDRESS>wrote:

I think it’s a bug. When resuming, it doesn’t pass the set views to the
server. I will fix this in the next release. ETA is about 15 days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/devcartel/pyrfa/issues/32#issuecomment-327094142, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADBeQwwmvSccU7n1pWdT_ype-Z-yd62Eks5sfPfFgaJpZM4PMSd0
.

Seems that pauseAll() and resumeAll() work with views but not marketPriceResume(ric)

Confirmed that views combined with 'pauseAll/resumeAll' behaves as
expected. Thanks.
On Tue, Sep 5, 2017 at 19:06 Wiwat Tharateeraparb<EMAIL_ADDRESS>wrote:

Seems that pauseAll() and resumeAll() work with views but not
marketPriceResume(ric)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/devcartel/pyrfa/issues/32#issuecomment-327131578, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADBeQ0o3eu39LfxmE6ofGaPuBc0eRDzDks5sfR0LgaJpZM4PMSd0
.

Please try PyRFA 8.2.1 released today for which addresses this issue.

Great, thanks for the quick fix. I`ll try it out this friday. Thanks.

Hi, I tried PyRFA 8.2.1 using marketPricePause(ric) and marketPriceResume(ric)  but it still loses the view settings after the resume. Other than checking the init.py version number how can I programmatically check the pyrfa.pyd version? I want to ensure I am running the correct version.
Also, I am using Python 3.6 win64. Thanks.

You can run below to check the version:
>>> import pyrfa
>>> pyrfa.__version__

I will double check it

I have checked again with PyRFA 8.2.1 Win64 and can confirm that view works with marketPricePause and marketPriceResume. Maybe you can try to update PyRFA with:
Python3.6.exe -m pip install -U pyrfa

Fixed in 8.2.1


[Accessibility]: Multiple elements with "navigation" role do not have unique labels

[Accessibility]: Multiple elements with "navigation" role do not have unique labels
Detailed description

Describe in detail the issue you're having.

When there are multiple elements with role "nav" on a page, they must have unique labels that clearly describe their purpose. This helps people who use assistive technologies to quickly understand and navigate to each navigation region.

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

<nav role="navigation">

What did you expect to happen? What happened instead? What would you like to see changed?

For each element with a "nav" role, either set the value of the aria-labelledby attribute to the id value of any visible text that appropriately and uniquely describes that navigation region; Or, use the aria-label attribute to add an invisible, unique, non-empty label to an element with the "nav" role.

What browser are you working in?

Firefox 101.0(64-bit)

What version of the Carbon Design System are you using?

<EMAIL_ADDRESS><EMAIL_ADDRESS>
What WCAG 2.1 checkpoint does the issue violate?

IBM 2.4.1 Bypass Blocks WCAG technique ARIA6 WCAG technique ARIA13

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Additional information

Screenshots or code

Hi @yashgarg1719, the user is responsible for setting aria-label (ariaLabel) or aria-labelledby (ariaLabelledby) in Tabs.
<ibm-tabs> (Tabs) accepts both values as input properties. You can observe this in the documentations.
For <ibm-breadcrumb> (Breadcrumbs), an ariaLabel property is available as can be observed in the documentation under Inputs.
Closing issue as issue can be resolved via input property. Feel free to reopen the issue or comment with more details to reopen.


Should Register-SecretVault lock in the ModulePath where the ModuleName resides?

While doing development on a SecretManagement extension, a different instance of my module kept getting imported into my session and executed, rather than the one I placed earlier in the $PSModulePath. I finally figured out that the ModulePath property was saved with my registered secret vault, and that instance had priority running.
I did an Unregister-SecretVault & Register-SecretVault, which reset the ModulePath based on $PSModulePath and solved the strange import behavior.
My mindset was that the Register-SecretVault was semi-permanent and would not have to be reissued periodically.
Of course, having discovered this behavior, hopefully I'll recognize the symptoms if it crops up again.

Yes, currently Register-SecretVault saves the full path of the ModuleName you provide.  It uses PowerShell module loading, so if you provide just a module name it will search for it using $env:PSModulePath, or if you provide a full path/name it will just use that.  But when it finds the module it saves the full path in the vault registry.  If you change the location of the extension vault module, you have to re-register it.


Is it possible to expose various parts of the webpack config?

Problem
Currently the build system is opinionated (which isn't a bad thing). But it would be nice to be able to add our own loaders / plugins / potentially use a PostCSS style system instead of SASS if the user desires;
More Information
Any additional information which might be helpful.
I know Blendid is run on Gulp where as i believe Slate is now all on webpack they achieve it with a API / config like: https://github.com/vigetlabs/blendid/wiki/Configuration#alternatetask which is quite elegant.
I don't know too much about Shopify but i'd happily start looking in to this if this was something you guys are open to 👍

IMHO, I like the way Rails Webpacker does this. It allows us to extend the configs and a append a plugin to an environment object. Exposing an object for OOP and allowing the user to make choices based on some initial guides could allow for a more advanced setup, while allowing a soft landing for those who opt not to use it. With webpacker, one of my goals was to be able to use sourcemaps for styles while keeping HMR in tact.  We worked at adding https://github.com/sheerun/extracted-loader - which exposed the ability, and simply adding our new loader, and appending it to the environment object worked nicely.
Might allow for some inspiration here https://github.com/rails/webpacker/blob/master/docs/webpack.md#loaders
Is there no way to add a loader currently in 1.x ?  I do see how the team is adding userWebpackConfig,  in https://github.com/Shopify/slate/blob/1.x/packages/slate-tools/tools/webpack/config/dev.js#L80 but I'm not sure its doing what I think it does.
The current logic to me seems to say that I can add properties like module plugins to dev in extends on slate.config.js -  and it would all just be merged. Maybe adding some clarification on how you expect this to work would expose more ideas / contributions.
Last but not least, I would expect slate.config to error out at some point. Requiring non existent libraries to the config here doesn't break the  compiling task like it would when working with webpack.  Was that the intended behavior?

Is there no way to add a loader currently in 1.x ? I do see how the team is adding userWebpackConfig, in https://github.com/Shopify/slate/blob/1.x/packages/slate-tools/tools/webpack/config/dev.js#L80 but I'm not sure its doing what I think it does.

@el-rotny so I was keeping this low-key but it looks like you stumbled upon an existing solution that I wasn't 100% sure on so I didn't include it in the docs yet.
It is currently possible to extend the Webpack configs through two parameters in slate.config.js:
'slate-tools': {
  extends: {
    dev: { ... **insert config object here** ... },
    prod: { ... **insert config object here** ... },
  },
}

We're using Webpack Merge to make this possible. I haven't had the chance to really get to know the package, so I'm not 100% confident in it yet.


"Optional" label in StepLabel should be localizable

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
"Optional" label in StepLabel should be localizable.
Current Behavior
It's hardcoded with text constant "Optional" and cannot be replaced.

Tech
Version

Material-UI
1.0.0-beta.22

React
16.1.1

browser
any

Oops, I have miss that during the review! I agree. Something like this should do it:
        {optional && (
          <Typography type="caption" className={classes.optional}>
-            Optional
+            {optional}
          </Typography>
        )}


Setup a PR review bot

Created a PR review bot. It does the following:

Marks new PRs with the bot-review label and sets it to draft status.
Checks to see if the PR contains the elements of a PR Template (from .github/pull_request_template.md).
If PR matches a template, it removes the bot-review label and removes the PR from draft status.

The bot determines if a template has been used by looking at the **bolded headings**.  It checks each known template against the body of the pull request.
Editing the pull request body causes the PR review bot to run again.
Issue: https://github.com/commaai/openpilot/issues/30715

do you have some examples of it working on your fork?

Here are some examples.
No template found, PR failed
https://github.com/commaai/openpilot/assets/147658676/9b2c7979-c5bd-4618-8495-218166bf978a
Template found, PR passed
https://github.com/commaai/openpilot/assets/147658676/74b85266-62b3-4bff-adbd-4af028c6a882
PR is edited, status is updated
https://github.com/commaai/openpilot/assets/147658676/51a42c3b-dd79-49d2-a6cf-30bd1f7216be

does pygithub have an api for doing stuff like converting to draft, getting pull request id, etc?

As far as I could discover, draft status cannot be be modified by the REST endpoint that PyGithub uses internally.
Only the GraphQL endpoint can convert a PR to and from a draft. The required pull request id can only be obtained through the GraphQL endpoint.

Thanks for the PR!
This is bigger and more custom than I was expecting? This is pretty generic stuff, and it's important that it has basically no maintenance cost (i.e. in the next year, we don't have to touch it to get it working again). Are there existing Actions we can use instead? The ideal thing is a single action, but perhaps there's a few different ones we can chain together. There's also github-script which I imagine would simplify this a bit.


Add carray() and farray()

Based on PR #1855.

[Current coverage][cc-pull] is 87.44%

Merging [#1871][cc-pull] into [master][cc-base-branch] will decrease coverage by -<.01%

2 files (not in diff) in numba were modified. more

Misses -9
Partials +1
Hits +8

@@             master      #1871   diff @@
==========================================
  Files           288        292     +4
  Lines         51589      52126   +537
  Methods           0          0
  Messages          0          0
  Branches       5340       5396    +56
==========================================
+ Hits          45144      45578   +434
- Misses         5535       5621    +86
- Partials        910        927    +17

Powered by Codecov. Last updated by [965a794...2a8d4a9][cc-compare]
[cc-base-branch]: https://codecov.io/gh/numba/numba/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/numba/numba/compare/965a794ae33919fd2a79e6d2d090cc72a99552e9...2a8d4a97d27854e5988c40fbafe24e7ef5a06243
[cc-pull]: https://codecov.io/gh/numba/numba/pull/1871?src=pr

@sklam: Can you do the review of this?

I've addressed the review comments now.

Woo!  Super excited to see this feature arrive.


Port V6 Macros to either V5 or V7 macro system

Two macros ported over from V6 to V5:

peepeepoopoo
jesus
Invocation works.


specs-go/v1: unify the descriptor type

Unifying the descriptor type makes it much easier to handler descriptors
in generic manner. This change ensures that a single deserialization can
be done a descriptor that may be processed in separate contexts.
It is unclear whether or not the specification should be pedantic about
this, as well. As it is written, these fields are only valid when being
referred through a manifest, but this distinction is only required
during validation. It may be possible to lift the platform definition to
the descriptor type, but this isn't strictly necessary.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>Addresses #588.

Would it make sense to make this a well-known annotation instead? Seems like a good use for the field. Would require moving the annotations type to map[string]interface{} of course though, which might have consequences I haven't foreseen.

Reposted from an emailed comment, which GitHub seems to have eaten:
On Mon, Mar 20, 2017 at 07:01:12PM -0700, Erik Hollensbe wrote:

Would it make sense to make this a well-known annotation instead?

+1 to this.  With platform-ness being just one way to select a given child, and the existing annotation org.opencontainers.image.ref.name being another parallel/complimentary way, I think moving the platform information into annotations makes sense.
@stevvooe, you'd seemed to be on board with platform annotations earlier.  Has something changed?  We can always continue to inject the old platform properties if we want backwards compatibility with existing Docker manifest-list engines, although we may not be able to only use annotations if we require forward compatibility for existing Docker manifest-list blobs.

Seems like a good use for the field. Would require moving the annotations type to map[string]interface{} of course though, which might have consequences I haven't foreseen.

There's some background on string vs. interface{} values in #44 if that helps orient you.

Reposted from an emailed comment, which GitHub seems to have eaten

@wking GitHub probably ate this because you are supposed to be blocked. Please do not comment on my pull requests. I have asked you, kindly, more than once.

With platform-ness being just one way to select a given child, and the existing annotation org.opencontainers.image.ref.name being another parallel/complimentary way, I think moving the platform information into annotations makes sense.

Ref name isn't really binding in the way that platform is. Platform is just pulled up from the underlying config and can be validated. Ref name is a hint that shouldn't be trusted and can be ignored. This PR brings them to the same level so they can be used in filtration logic, but that doesn't point to their equivalence.

Would it make sense to make this a well-known annotation instead? Seems like a good use for the field. Would require moving the annotations type to map[string]interface{} of course though, which might have consequences I haven't foreseen.

I don't see any reason to break from the structured approach. Having such a large change before 1.0 would be detrimental to the release and not provide value. Furthermore, annotations are not a dumping ground for stuff; they are meant for non-binding metadata. If we can provide structure for something, we absolutely should.
Note that this PR doesn't change the context under which the platform field can be used. It only unifies the Go type. From the perspective of the specification, the Platform field can only be used with indexes. Moving platform to annotations or allowing platform descriptions outside of this context are outside the scope of this PR. This PR is only present to make the descriptor type easier to work with.

Fair enough.
I hope my query wasn't a bother! I just thought it was a reasonable
question.
-Erik
On Tue, Mar 21, 2017 at 12:32 PM Stephen Day<EMAIL_ADDRESS>wrote:

Reposted from an emailed comment, which GitHub seems to have eaten
@wking https://github.com/wking GitHub probably ate this because you
are supposed to be blocked. Please do not comment on my pull requests. I
have asked you, kindly, more than once.
With platform-ness being just one way to select a given child, and the
existing annotation org.opencontainers.image.ref.name being another
parallel/complimentary way, I think moving the platform information into
annotations makes sense.
Ref name isn't really binding in the way that platform is. Platform is
just pulled up from the underlying config and can be validated. Ref name is
a hint that shouldn't be trusted and can be ignored. This PR brings them to
the same level so they can be used in filtration logic, but that doesn't
point to their equivalence.
Would it make sense to make this a well-known annotation instead? Seems
like a good use for the field. Would require moving the annotations type to
map[string]interface{} of course though, which might have consequences I
haven't foreseen.
I don't see any reason to break from the structured approach. Having such
a large change before 1.0 would be detrimental to the release and not
provide value. Furthermore, annotations are not a dumping ground for stuff;
they are meant for non-binding metadata. If we can provide structure for
something, we absolutely should.
Note that this PR doesn't change the context under which the platform
field can be used. It only unifies the Go type. From the perspective of the
specification, the Platform field can only be used with indexes. Moving
platform to annotations or allowing platform descriptions outside of this
context are outside the scope of this PR. This PR is only present to make
the descriptor type easier to work with.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/image-spec/pull/620#issuecomment-288192882,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABJ6-k6uodJdG6lJ89qq7e8dr2g49XLks5roCW-gaJpZM4MjIiz
.

I hope my query wasn't a bother! I just thought it was a reasonable
question.

No, it is a completely reasonable question. I hope the clarification was helpful.

I guess we need another PR to update specification accordingly to make it consistent with the changes in this PR.

LGTM

If such changes, calls to descriptor will be no errors in the manifest?

@opencontainers/image-spec-maintainers Rebased after the pointer change in to Platform. PTAL

LGTM

lgtm


change: directory structure to polyrepo.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 19 (89.47%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 64.066%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/base-error.ts
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1117

Relevant Lines:
1643

💛  - Coveralls


Add support for magento 2.3.x CMS REST endpoints

as of Magneto 2.3.x it is possible to search the cmspage and cmsblocks by using the REST endpoints.
I think this should be the default one supported, and snowdog extension offered as a fallback if the Magento version is 2.2 or earlier as a useLegacyCMS config or something like this.

@janmyszkier I requested something similar here - https://github.com/DivanteLtd/mage2vuestorefront/issues/65. However I was informed the reason is because the core Magento API doesn't parse everything. In my experience if you have a widget in the CMS Page/Block then it shows the widget JSON in the midst of the parsed HTML.
In my opinion Magento should have an API to return all json data of a CMS page/block. When working in the PWA you don't generally want parsed HTML returned. But this is understandably difficult in a WYSIWYG. But having the JSON data of the widget is nice, but in its current state I don't think it's very usable.

If you do not really use widgets and similar stuff. You can easily fetch pages and blocks to your ElasticSearch with this tutorial. However, as said above, if you use widgets it will display non-HTML fragments.


Lazy look_ahead

I've noticed that when using the look-ahead feature, this always involves a full traverse/transform of the input document under that node. This can be a problem when the input documents are large and complex.
This is an attempt to rewrite the look_ahead API so that its invocation becomes basically free. Instead of doing a forced deep transformation up front, the required work has been moved into the methods explicitly called by the API user.
A single level of LookAheadChildren gets computed when the user calls LookAheadSelection::children().
The arguments/values to a field are also lazily computed, and variable substitution is now done purely on demand.
The PR is in a draft state and the old look_ahead API is still intact for the time being, I'm interested in general feedback first before finishing it off.
Summary of API breakages:

trait LookAheadMethods removed. In my opinion there's no need for this and it always requires an explicit extra import.
struct ConcreteLookAheadSelection removed
struct LookAheadSelection now has some inherent methods at least partially compatible with LookAheadMethods:

field_name, has_arguments: Compatible signature
arguments now returns impl Iterator<Item = LookAheadArgument> instead of &[LookAheadArgument].
argument now returns Option<LookAheadArgument> instead of Option<&LookAheadArgument>.
children now returns LookAheadChildren instead of Vec<&Self>. LookAheadChildren implements IntoIterator.
field_original_name / field_alias: New in 0.16

Some methods moved into new struct LookAheadChildren:

LookAheadMethods::child_names
LookAheadMethods::has_children moved to LookAheadChildren::is_empty
LookAheadMethods::select_child moved to LookAheadChildren::select

LookAheadSelection::for_explicit_type moved to LookAheadSelection::children_for_explicit_type, which returns LookAheadChildren.
LookAheadValue::List(_) contains a new struct LookAheadList with IntoIterator + iter method.
LookAheadValue::Object(_) contains a new struct LookAheadObject with IntoIterator + iter method.

I know the change looks large, I made it so because I essentially see it as a rewrite. I would like to get some indication on whether you would accept a change along these lines. If you are positive, I'll finish up the PR, overwrite the existing implementation and update the integration tests. I've finished this locally.

@tyranron Thanks! If you instead prefer a PR closer to the finished product, I can fix that before that time.

@audunhalland once you finish adjustments, please, re-request my review via this GitHub button. Thanks!

Ok, rebased on master, overwrote look_ahead and updated the tests I found to be relevant (based on grepping for look_ahead).


[rtextures] Created ImageFromChannel()

Adds the possibility to extract a specific channel from an image

@brccabral Thanks for the implementation, added some points to review. The function should return the selected channel, not channel + alpha, and threshold could be skipped (it could be managed at user side or with a separate function if required).

@brccabral Thanks for the implementation, added some points to review. The function should return the selected channel, not channel + alpha, and threshold could be skipped (it could be managed at user side or with a separate function if required).

changes applied

@brccabral Great addition! Thank you very much! :D


CMP several SAN extensions in certificate request message

Using openssl cmp for performing IR request, I faced a strange behavior.
The authentication between the sender and the RA relies on a certificate trusted by the RA (cmp_identity_authentication.pem). I'm requesting a certificate matching the CSR in parameter. The CSR has two entries in the SAN: one dNSName and one URI.
$ openssl cmp -cmd ir -server mycmpserver -path cmp_profile -srvcert cmp_server_cert.pem -cert cmp_identity_authentication.pem -key cmp_identity_authentication.key -certout my_new_certificate.pem -newkey my_new_certificate.key -csr my_new_certificate.csr

cmp_main:apps/cmp.c:3077:CMP info: using section(s) 'cmp' of OpenSSL configuration file '/tmp/openssl-3.2.1/openssl.cnf'
cmp_main:apps/cmp.c:3085:CMP info: no [cmp] section found in config file '/tmp/openssl-3.2.1/openssl.cnf'; will thus use just [default] and unnamed section if present
setup_client_ctx:apps/cmp.c:2088:CMP info: will contact http://mycmpserver:80/cmp_profile
CMP info: sending IR
CMP error: received error:code=500
CMP error: error receiving:server=http://mycmpserver:80
CMP error: transfer error:request sent: IR, expected response: IP

From the traces and from the RA logs, two SANs are present in the certificate request.
On RA logs: « repeated extension found: <IP_ADDRESS> »
From traces

The extension id-ce-subjectAltName (<IP_ADDRESS>) appears twice. The first extension contains the value of the authentication certificate SAN (a single dNSName in my case). The second extension has the correct values from the CSR. Every other values from the IR request seem ok (public key, other extensions, etc.). Would it be possible to remove the SAN added by the authentication certificate from the demand?
I've faced this issue on OpenSSL 3.0.2 15 Mar 2022 (Library: OpenSSL 3.0.2 15 Mar 2022) and on OpenSSL 3.2.1 30 Jan 2024 (Library: OpenSSL 3.2.1 30 Jan 2024)

Could observe the same behavior which was resolved by passing_-san_nodefault_ in the IR command.
Quoting from the CMP doc:
-san_nodefault
When Subject Alternative Names are not given via -sans nor defined via -reqexts, they are copied by default from the reference certificate (see -oldcert). This can be disabled by giving the -san_nodefault option.

Looks like this has to be explicitly disabled.


Crash on hover

Problem Description
Factorio crashes when I hover over the icons in the righthand column (ingredients list?) in the compact view.  It doesn't crash when I hover over the same column in regular view.

This is the error message:
The mod Factory Planner (1.1.73) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event factoryplanner::on_gui_hover (ID 178)
factoryplanner/ui/base/compact_dialog.lua:418: attempt to index field '?' (a nil value)
stack traceback:
factoryplanner/ui/base/compact_dialog.lua:418: in function 'handle_hover_change'
factoryplanner/ui/base/compact_dialog.lua:496: in function 'handler'
factoryplanner/ui/event_handler.lua:157: in function <factoryplanner/ui/event_handler.lua:114>
Reproduction
No response

Hello, thanks for the report! This issue has been fixed with the most recent release (1.1.74), so please update and give that a go. If you still run into the issue, please let me know.

Thank you so much!  Fantastic mod, by the way.  Probably the greatest improvement to my gameplay in at least a year.

Ha well happy to hear that :)


Erroneously removed styles w/ :not() selectors

We have a style that looks similar to this:
.body-copy ol:not(.vjs-menu-content)>li, .body-copy ul:not(.vjs-menu-content)>li, .body-copy>.p402_premium ol:not(.vjs-menu-content)>li, .body-copy>.p402_premium ul:not(.vjs-menu-content)>li {
    padding-left: 30px;
    margin-bottom: 5px;
    line-height: 28px;
    position: relative;

The whole block style disappears.  However if I remove the :not(...) then it properly finds it.

I was able to temporarily get around it by using this config:
        const purifiedCss = purify(html, stylesheets, {
            minify: true,
            whitelist: [ '*:not*' ]
        });

Same for me. For a real-world example with Bulma see https://github.com/webpack-contrib/purifycss-webpack/issues/113.

I encountered the same issue.
I submitted a pull request about this.
https://github.com/purifycss/purifycss/pull/202


Complete the javadoc of NoteApi and LabelApi

And fixed some bugs XD

@Stel000
Thanks for adding the Javadocs.


Not clustering if markers are on same location

I am using your sdk for clustering markers on maps.
However it is not clustering maps if markers are on same location when multiple markers are on same latitude longitude.

same issue? have any solution

Hi guys. I don't see any solution other than preventing markers to have the exact same coordinates. In one project we did it client-side just by collecting all items with the same coordinates and then slightly modifying them.


Performance profiling

Are you able to create a stress scene so I can run a profile?

Yes, certainly!  To start with I'm thinking we should have a scene with one high-poly object and a scene with many lower-poly objects.  In addition to getting a baseline profile, those are the two most obvious areas that we could consider running the calculations in parallel and we'd be able to use these scenes to evaluate any improvement from doing so.
The other potential bottleneck to test would be the wave height gdscript callback function, so we'll also want a scene with an object under no wave function, a constant wave function, and a complex one.

@fire Let me know if you think I'm going down the right path with this:
StressTest.zip

I have scenes with 1 object and 10 objects, in both cases the total number of faces is about the same so we can compare the results with each other.
I have scenes with a built-in wave height, and two with simple and complex callbacks to gdscript for the wave height.
I took a quick look with the built-in profiler and these all take about 125% of a physics timeslot each cycle on my Ryzen 3600.  I can bump it up easily if needed.

So far, all the scenes test with an object totally underwater, this isolates and makes consistent the code to calculate the forces.  We'll want one with objects on the surface too, in order to hit the mesh clipping function too.
Once we have a nice suite, these might be able to double as both performance and regression tests.  If these are in line with what you're looking for, I think they'll warrant inclusion in the repo so that anyone could perform the same tests.

@fire I decided to convert this into a script that allows different numbers of objects and faces to be specified.  When the objects sink to a specified depth, the script will print some stats and exit.  This should allow for more versatility in running this from various profilers, automated test suites, etc.  I've added a small section to the wiki on how to use it.
Let me know if https://github.com/godot-extended-libraries/hydro/commit/d9f4aa19a28dbd91d195b2f36a49a8499d053f76 is sufficient for your profiling work, I used it with perf on Linux and have already found some interesting results.

Will contact you directly, but the summary was things happened and I rethinking my projects.

I've found this stress test to be more than adequate for profiling myself, if we decide to increase its scope for use in other areas we can detail such use cases in a separate issue.


alart update

/alert can be selected to go to the person added in the ticket or to the person who owns the ticket

e.g= /alart (user)

Hello, this feature has been added in the latest commit now. You might need to use /reload after updating your files for the /alert command to show the new optional user option.
By default if you don't use the new option, it will alert the ticket creator. It will also check to see if the user you select is added to the ticket, otherwise a reply error will be sent about that.
Thanks for the suggestion.


 Please wait...
    ________________________________________________________________

0/9 [>---------------------------]   0% Migrating: 2016_02_09_194940_create_o
hid_post_table
Illuminate\Database\QueryException  : SQLSTATE[42000]: Syntax error or acce
violation: 1071 Specified key was too long; max key length is 1000 bytes (SQL
alter table posts add index posts_status_type_index(status, type))
at C:\newea\vendor\laravel\framework\src\Illuminate\Database\Connection.php:
4
660|         // If an exception occurs when attempting to run a query, we'
format the error
661|         // message to include the bindings with SQL, which will make
is exception a
662|         // lot more helpful to the developer instead of just the data
se's errors.
663|         catch (Exception $e) {

664|             throw new QueryException(
665|                 $query, $this->prepareBindings($bindings), $e
666|             );
667|         }
668|

Exception trace:
1   PDOException::("SQLSTATE[42000]: Syntax error or access violation: 1071
ecified key was too long; max key length is 1000 bytes")
C:\newea\vendor\laravel\framework\src\Illuminate\Database\Connection.php
58
2   PDOStatement::execute()
C:\newea\vendor\laravel\framework\src\Illuminate\Database\Connection.php
58
Please use the argument -v to see more details.

How to specify the length in 2016_02_09_194940_create_orchid_post_table.php
I tried the following in AppServiceProvider.php
use Illuminate\Support\Facades\Schema;
public function boot()
{
Schema::defaultStringLength(191);
}
But not working... Help needed.

I have same issue, mariadb-10.2.19

mariadb support is only scheduled in laravel 5.8. At the moment, the current 5.7, you can temporarily fix it with the help of third-party packages providing work with json
https://github.com/ybr-nx/laravel-mariadb


Runtime error

Arch Linux
$ pacman -Q python
python 3.4.2-2
$ pacman -Q python-pip
python-pip 6.0.8-1
$ type joe
joe is /home/dontdieych/.local/bin/joe
$ which joe
/home/dontdieych/.local/bin/joe
$ joe
Traceback (most recent call last):
  File "/home/dontdieych/.local/bin/joe", line 9, in <module>
    load_entry_point('joe==0.0.5', 'console_scripts', 'joe')()
  File "/usr/lib/python3.4/site-packages/pkg_resources/__init__.py", line 519, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2630, in load_entry_point
    return ep.load()
  File "/usr/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2310, in load
    return self.resolve()
  File "/usr/lib/python3.4/site-packages/pkg_resources/__init__.py", line 2316, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/home/dontdieych/.local/lib/python3.4/site-packages/joe/joe.py", line 59
    print ', '.join(GITIGNORE)
             ^
SyntaxError: invalid syntax
$

How did you install it?
Py3 compatibility was recently merged in master, and hasn't been put up on pypi yet. Try installing from source and it should work.

Thanks. It's working.
PR: should change git@github.com:karan/joe.git -> https://github.com/karan/joe on README. It's private only address.


spi-hdlc-adapter: Reliability and Performance Improvements

This change includes many improvements which reduce latency, increase throughput, and improve reliability.
The most significant change from this commit is addressing a frame corruption bug which would occasionally corrupt frames received from the slave during periods of congestion. This was occurring because push_pull_spi() was allowed to be called when sSpiTxIsReady was set, even if sSpiRxPayloadSize was not equal to zero. Under such circumstances the previously received frame would be corrupted. This change makes sure that push_pull_spi() does not get called until sSpiRxPayloadSize is zero.
push_pull_spi() now only performs a single SPI transaction (instead of two), which eliminates a significant amount of duplicated code. The call to usleep() has been removed entirely, along with the associated static sSpiTransactionDelay.
Statistics are now gathered and reported at exit. You can also induce spi-hdlc-adapter to dump its statistics while it is running by sending it a SIGUSR1 signal.
This change also includes miscellaneous smaller changes.

Codecov Report

Merging #1441 into master will decrease coverage by -2.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1441      +/-   ##
=========================================
- Coverage   72.54%   70.5%   -2.05%
=========================================
  Files         142     142
  Lines       18210   19455    +1245
  Branches     2236    2387     +151
=========================================
+ Hits        13210   13716     +506
- Misses       4155    4841     +686
- Partials      845     898      +53

Impacted Files
Coverage Δ

src/core/mac/mac_whitelist.cpp
75% <0%> (-15.39%)
:x:

src/ncp/ncp_base.cpp
38.92% <0%> (-1.75%)
:x:

src/core/thread/network_data_leader_ftd.cpp
67.99% <0%> (-0.24%)
:x:

src/core/mac/mac.cpp
79.69% <0%> (-0.16%)
:x:

src/core/thread/mle.cpp
80.65% <0%> (+0.35%)
:white_check_mark:

src/core/thread/mle_router.cpp
79.96% <0%> (+0.48%)
:white_check_mark:

src/core/net/udp6.cpp
83% <0%> (+1%)
:white_check_mark:

src/core/thread/lowpan.cpp
93.72% <0%> (+1.43%)
:white_check_mark:

src/core/api/thread_api.cpp
46.32% <0%> (+1.73%)
:white_check_mark:

src/core/thread/mle_tlvs.hpp
100% <0%> (+1.97%)
:white_check_mark:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0976e57...fcc72ff. Read the comment docs.

Will remove work-in-progress tag once these changes are verified.

This is no longer a work in progress, but I can't remove the work-in-progress tag at the moment.

We are seeing much better test results with this version of spi-hdlc-adapter in our recent testing. Let's go ahead and get this merged soon.

Great to hear, @darconeous !


Kitchen converge failing in  chef 15.0.293

-----> Starting Kitchen (v1.16.0)
[03:43:17][Step 1/1] -----> Creating ...
[03:43:18][Step 1/1]        Detected platform: windows version 2012rtm on x86_64. Instance Type: m4.large. Default username: administrator (default).
[03:43:18][Step 1/1]        If you are not using an account that qualifies under the AWS
[03:43:18][Step 1/1] free-tier, you may be charged to run these suites. The charge
[03:43:18][Step 1/1] should be minimal, but neither Test Kitchen nor its maintainers
[03:43:18][Step 1/1] are responsible for your incurred costs.
[03:43:18][Step 1/1]
[03:43:19][Step 1/1]        Instance  requested.
[03:43:19][Step 1/1]        Polling AWS for existence, attempt 0...
[03:43:19][Step 1/1]        Attempting to tag the instance, 0 retries
[03:43:19][Step 1/1]        EC2 instance  created.
[03:43:19][Step 1/1]        Waited 0/1600s for instance  volumes to be ready.
[03:43:21][Step 1/1]        Waited 0/1600s for instance  to become ready.
[03:43:26][Step 1/1]        Waited 5/1600s for instance  to become ready.
[03:43:32][Step 1/1]        Waited 10/1600s for instance  to become ready.
[03:43:38][Step 1/1]        Waited 15/1600s for instance  to become ready.
[03:43:44][Step 1/1]        Waited 20/1600s for instance  to become ready.
[03:43:50][Step 1/1]        Waited 25/1600s for instance  to become ready.
[03:43:56][Step 1/1]        Waited 30/1600s for instance  to become ready.
[03:44:02][Step 1/1]        Waited 35/1600s for instance  to become ready.
[03:44:09][Step 1/1]        Waited 40/1600s for instance  to become ready.
[03:44:15][Step 1/1]        Waited 45/1600s for instance  to become ready.
[03:44:21][Step 1/1]        Waited 50/1600s for instance  to become ready.
[03:44:27][Step 1/1]        Waited 55/1600s for instance  to become ready.
[03:44:33][Step 1/1]        Waited 60/1600s for instance  to become ready.
[03:44:39][Step 1/1]        Waited 65/1600s for instance  to become ready.
[03:44:46][Step 1/1]        Waited 70/1600s for instance  to become ready.
[03:44:52][Step 1/1]        Waited 75/1600s for instance  to become ready.
[03:44:58][Step 1/1]        Waited 80/1600s for instance  to become ready.
[03:45:04][Step 1/1]        Waited 85/1600s for instance  to become ready.
[03:45:10][Step 1/1]        Waited 90/1600s for instance  to become ready.
[03:45:16][Step 1/1]        Waited 95/1600s for instance  to become ready.
[03:45:23][Step 1/1]        Waited 100/1600s for instance  to become ready.
[03:45:29][Step 1/1]        Waited 105/1600s for instance  to become ready.
[03:45:35][Step 1/1]        Waited 110/1600s for instance  to become ready.
[03:45:41][Step 1/1]        Waited 115/1600s for instance  to become ready.
[03:45:47][Step 1/1]        Waited 120/1600s for instance  to become ready.
[03:45:53][Step 1/1]        Waited 125/1600s for instance  to become ready.
[03:45:59][Step 1/1]        Waited 130/1600s for instance  to become ready.
[03:46:06][Step 1/1]        Waited 135/1600s for instance  to become ready.
[03:46:12][Step 1/1]        Waited 140/1600s for instance  to become ready.
[03:46:18][Step 1/1]        Waited 145/1600s for instance  to become ready.
[03:46:24][Step 1/1]        Waited 150/1600s for instance  to become ready.
[03:46:31][Step 1/1]        Waited 155/1600s for instance  to become ready.
[03:46:37][Step 1/1]        Waited 160/1600s for instance  to become ready.
[03:46:38][Step 1/1]        Waited 0/1600s for instance  to fetch windows admin password.
[03:46:38][Step 1/1]        Retrieved Windows password for instance .
[03:46:38][Step 1/1]        EC2 instance  ready.
[03:47:35][Step 1/1]        [WinRM] Established
[03:47:35][Step 1/1]
[03:47:39][Step 1/1]
[03:47:39][Step 1/1]
[03:47:39][Step 1/1]            Directory: C:\chef\ohai\hints
[03:47:39][Step 1/1]
[03:47:39][Step 1/1]
[03:47:39][Step 1/1]        Mode                LastWriteTime         Length Name
[03:47:39][Step 1/1]        ----                -------------         ------ ----
[03:47:39][Step 1/1]        -a----        5/15/2019   1:47 AM              0 ec2.json
[03:47:39][Step 1/1]
[03:47:39][Step 1/1]
[03:47:39][Step 1/1]        Finished creating  (4m22.25s).
[03:47:39][Step 1/1] -----> Converging ...
[03:47:39][Step 1/1]        Preparing files for transfer
[03:47:39][Step 1/1]        Preparing dna.json
[03:47:39][Step 1/1]        Resolving cookbook dependencies with Berkshelf 6.2.0...
[03:47:45][Step 1/1]        Removing non-cookbook files before transfer
[03:47:45][Step 1/1]        Preparing validation.pem
[03:47:45][Step 1/1]        Preparing client.rb
[03:47:49][Step 1/1] -----> Installing Chef Omnibus (install only if missing)
[03:47:51][Step 1/1]        Downloading package from https://packages.chef.io/files/stable/chef/15.0.293/windows/2016/chef-client-15.0.293-1-x64.msi
[03:47:57][Step 1/1]        Download complete.
[03:48:03][Step 1/1]        Successfully verified C:\Users\ADMINI~1\AppData\Local\Temp\chef-client-15.0.293-1-x64.msi
[03:48:03][Step 1/1]        Installing Chef Omnibus package C:\Users\ADMINI~1\AppData\Local\Temp\chef-client-15.0.293-1-x64.msi
[03:50:58][Step 1/1]        Installation complete
[03:51:05][Step 1/1]        Transferring files to
[03:54:29][Step 1/1] $$$$$$ C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/config.rb:24:in join': no implicit conversion of nil into String (TypeError) [03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/config.rb:24:in default_license_locations'
[03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/config.rb:10:in initialize' [03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/acceptor.rb:25:in new'
[03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/acceptor.rb:25:in initialize' [03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/acceptor.rb:95:in new'
[03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/license-acceptance-1.0.5/lib/license_acceptance/acceptor.rb:95:in check_and_persist!' [03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.0.293-universal-mingw32/lib/chef/application.rb:254:in check_license_acceptance'
[03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.0.293-universal-mingw32/lib/chef/application.rb:68:in run' [03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-bin-15.0.293/bin/chef-client:25:in <top (required)>'
[03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/bin/chef-client:167:in load' [03:54:29][Step 1/1] $$$$$$ 	from C:/opscode/chef/bin/chef-client:167:in '
[03:54:29][Step 1/1] >>>>>> ------Exception-------
[03:54:29][Step 1/1] >>>>>> Class: Kitchen::ActionFailed
[03:54:29][Step 1/1] >>>>>> Message: 1 actions failed.
[03:54:29][Step 1/1] >>>>>>     Converge failed on instance .  Please see .kitchen/logs/default-windows-2012r2.log for more details
[03:54:29][Step 1/1] >>>>>> ----------------------
[03:54:29][Step 1/1] >>>>>> Please see .kitchen/logs/kitchen.log for more details
[03:54:29][Step 1/1] >>>>>> Also try running kitchen diagnose --all for configuration

This is a test-kitchen and/or license-acceptance bug and may have been fixed by now since that was all in flux.  You will definitely need to be on latest test-kitchen to use chef 15, and that version will only be in the chef-dk 4 version which dropped literally earlier today, and the backport to chef-dk 3 has not happened yet.  But this is not a bug in this repository, and not the appropriate place to track those issues.


Suggestion

Config.yml
PersonaToSkin: false #Toggle

also please enchant form like you can change in config without changing at clothesForm.php
i think this is a big help for everyone also its big help to split it into 2 config ::
config.yml
attire.yml
**Form Title
**ResetSkinButton/Back Button Picture
**Clothes/Cosplay Category Button Picture
**Per Clothes/Cosplay Button Picture
Have a great day !! 😊

you mean a config for changing form texture like the title, button name, button picture? and also why you closed the issue so soon

yes that what i mean sorry about closed issue

okay i may make a config for that in a further day


NoSuchBucket and possible depreciation

http://emulator101.com

"404 Not Found
Code: NoSuchBucket
Message: The specified bucket does not exist
BucketName: emulator101.com
RequestId: FAA826CB4D6B4726
HostId: uY4w8ZWaEr+Osd/rnFRhqAQQ24CZV1CrxPYl0VvDSZ3GeHx/du1Eu4ta4vHxWKLq+mgAAoUoCWg="

Other than that great work, it's been pretty good to use.

Thanks for the reports. I understand these 2 things are unrelated, could you please use a separate issues to report them? Makes it easier to keep track.
Thanks 👍


Move to YAML recipe format

Still needs testing, and documentation written.
Fixes #107
Fixes #115
Fixes #112

Also fixes #112

@JorgeBornemann I'd appreciate if you could look over the code changes.
@Sylviabohnenstengel I'd appriciate it if you could look over the documentation changes. There is a rendered version of the documentation here: https://tmpweb.net/H2iSr5c5Bbb5/


Create a link for the website

In order for the people to reach the content worldwide, I need to create a link by signing in to the streamlit website and defining the parameters I'll have for my application.

Link created and added to readme.


Set validation_horizon to avoid errors when generating cutoffs for cross-validation

When the user-provided horizon is too long, prophet and arima models will use a shorter validation_horizon to generate cutoffs. This means that they will no longer fail due to errors in the generate_cutoffs function, which occur when the horizon is too long relative to the dataset.

Addressed comments. Latest codecov shows improvement in test coverage: https://app.codecov.io/gh/databricks/automl/compare/54/overview


[Bug] missing piexe with 4 players

Majd said it's backend side error, icon is corrupted

This was a frontend problem


Remove replaces from bundle manifest when PREV_BUNDLE_INDEX_IMG is empty or not set

When we push to main/stable, we want to strip out the replaces line that is hardcoded in the bundle manifest. We can use the PREV_BUNDLE_INDEX_IMG we're already leveraging for setting the --from-index to know if replaces should be there or not.
stolostron/backlog#17826
stolostron/backlog#18208
Signed-off-by: Robin Y Bobbitt<EMAIL_ADDRESS>

/lgtm

/retest-required


docs(README): update README

Add new static badges on the README to communicate the status and quality of the project, remove broken badges and other minor improvements.
Also, revamp the README header section to center the header content.

:tada: This PR is included in version 1.0.1-dev.2 :tada:
The release is available on:

v1.0.1-dev.2
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

v1.0.1
GitHub release

Your semantic-release bot :package::rocket:


Documentation of deploying dynomite cluster on AWS

We are trying to use Netflix conductor in our project but did n't find any documentation on  deploying  dynomite cluster on aws with production HA settings. Can you please provide steps to deploy?

Here it is: https://github.com/Netflix/dynomite-manager/wiki/Step-by-step-installation

I hope this is answered. Please reopen the issue if you have further follow up questions