Running on Matterport3D

Hi,
Thanks for your amazing works. I am trying to get it run on Matterport3D, but an info file (train_info.pbz2) is required. Would you be able to provide the codes for generating that file?
Thanks!

I am looking for the info file for MP3D, too.
Thanks!

I tried to generate the 'sem_map' using the object aabb, but it didn't perfectly match the map in the provided info file.

In my understanding that file has information useful to estimate the object-nav metrics. If you can use directly the simulator instead, then you can ignore the train_info.pbz2

Yes, I directly used the simulator. But the problem here is how to determine the floor height, as one floor can span various heights in the MP3D dataset, and the floor height given by the level AABB annotation is unreliable.
I am also facing the same problem now. Is there an effective solution? Can we generate this info by ourselves?

In my understanding that file has information useful to estimate the object-nav metrics. If you can use directly the simulator instead, then you can ignore the train_info.pbz2

Yes, I directly used the simulator. But the problem here is how to determine the floor height, as one floor can span various heights in the MP3D dataset, and the floor height given by the level AABB annotation is unreliable.

I am also facing the same problem now. Is there an effective solution? Can we generate this info by ourselves

I don't think you need to generate this info if you are running experiments on MP3D. In get_metrics() at envs/habitat/objectgoal_env.py you can use directly the simulator to get the agent's position and distance from the goal positions. The goal positions can be found from the v1 dataset provided in the habitat-lab repository.
You can verify this by tracing where the train_info.pbz2 info are being used in objectgoal_env.py. You can remove any use of that in the code. Also you don't need to pre-determine the floor-heights. If your input episodes contain start_position, start_rotation, object_category, and starting_distance (geodesic) then you should be fine.

I don't think you need to generate this info if you are running experiments on MP3D. In get_metrics() at envs/habitat/objectgoal_env.py you can use directly the simulator to get the agent's position and distance from the goal positions. The goal positions can be found from the v1 dataset provided in the habitat-lab repository.
You can verify this by tracing where the train_info.pbz2 info are being used in objectgoal_env.py. You can remove any use of that in the code. Also you don't need to pre-determine the floor-heights. If your input episodes contain start_position, start_rotation, object_category, and starting_distance (geodesic) then you should be fine.

I see. I can use the v1 dataset directly. And this is a convenient way.  Thank you!

I don't think you need to generate this info if you are running experiments on MP3D. In get_metrics() at envs/habitat/objectgoal_env.py you can use directly the simulator to get the agent's position and distance from the goal positions. The goal positions can be found from the v1 dataset provided in the habitat-lab repository.
You can verify this by tracing where the train_info.pbz2 info are being used in objectgoal_env.py. You can remove any use of that in the code. Also you don't need to pre-determine the floor-heights. If your input episodes contain start_position, start_rotation, object_category, and starting_distance (geodesic) then you should be fine.

Thanks, pal, but  I am still confused about how to get the goal position from the MP3Dv1 dataset provided in the habitat lab.

Hi. I am also facing the similar problem. I wonder how to reset the episode without train_info.pbz2 when using mp3d dataset? For gibson, we use ground truth sem_map from train_info.pbz2 to pick the new object in the new episode (function generate_new_episode), but how could this be done in mp3d?
Any suggestion would help! Thank you :)

train_info

Hi Min Zhao, would you mind giving more details about your solution?  How did you make it work on Mp3D? Thanks so much!

I don't think you need to generate this info if you are running experiments on MP3D. In get_metrics() at envs/habitat/objectgoal_env.py you can use directly the simulator to get the agent's position and distance from the goal positions. The goal positions can be found from the v1 dataset provided in the habitat-lab repository.
You can verify this by tracing where the train_info.pbz2 info are being used in objectgoal_env.py. You can remove any use of that in the code. Also you don't need to pre-determine the floor-heights. If your input episodes contain start_position, start_rotation, object_category, and starting_distance (geodesic) then you should be fine.

@ggeorgak11    Your advice is mostly correct and one can train the model with matterport. But there may have some mistakes. The metric, like distance_to_goal, is not correct. Specifically, it seems to point to one target goal. You may have to build the dataset with the object_nav_dataset dataset. I'm still investigating this modification, and glad to hear more about your advice.

Could you give more details about your solution? How did you make it work on Mp3D? It would be very helpful to me. Thanks so much!


add Multipart support (FromRequest)

Akin to the Form support it can be nice to develop and implement Multipart.
It would be used to:
Be able to decode form data from the request (found in the payload == body), but often it is associated with file upload instead.
As such the API also different then the Form we already support.
You can to start with copy over https://github.com/tokio-rs/axum/blob/main/axum/src/extract/multipart.rs,
and adapt it from there.
This one is only used for Extract purposes, no IntoResponse support desired here.
Deliverables:

support the Extractor
make sure it is tested (porting over axum's version will help a lot with this and the previous deliverable)
add a file upload example where one uploads an image and the server displays it in html

That's it.

@GlenDC I could probably take this on too since it should be very similar to the Form implementation :)

And thank you very much for picking this one up :)

@GlenDC I won't be able to finish a PR for this for the next week or so, I have a lot going on at work right now 😓 if there is someone else who would like to pick this up feel free to reassign 👍

@devanbenz all good. If someone else wants to pick it up they can, otherwise it's here for you once you feel like it again.
This is not an urgent ticket and I'm not really promoting rama yet to the outside world beyond the occasional mention. So chances are big that it will still be here if you feel like picking it up later.
Take care and enjoy :) And even if you never get to this or anything rama-related again, all good. You did already a lot for the project and I thank you for that.

Going to drop this. It requires the use of a pretty heave dep (multer) for little to no use case for now.
We can revive it if there's ever a strong request for it.


Support response.blob()

node-fetch v2 supports blob() for isomorphic JS.
So that client code can be unit tested via mocks on the server, can this package be updated to use node-fetch v2?

Nice! Not sure when I'll get to this, so PRs implementing it most welcome

Just noting this here as it might be useful in further removing differences between server and client side implementations https://github.com/PaulKinlan/streaming-server-sw-demo/blob/005c6045cd7091ccc8265ea7ad67cb5e4cc381ba/public/scripts/platform/node.js#L65

waiting on node-fetch@2 getting out of alpha/beta

Given that Blob support has been merged to node-fetch (https://github.com/bitinn/node-fetch/pull/200), where is the priority on this now? ;-)

Thanks for the heads up.
The priority is as high as users of fetch-mock make it - PRs very welcome :-). If no PRs are forthcoming I'll get round to implementing eventually... but kinda busy with other stuff right now

node-fetch 2 is still in alpha. Blocked until it's released properly

I know this is an old issue, and this appears to work for some, but I get the following error:
TypeError: response.blob is not a function
when I have my mock set as:
 const myBlob = new Blob();   beforeEach(() => {     fetchMock.mock("*", { body: myBlob, sendAsJson: false });   });

I fixed the above issue by adding node-fetch as a dev dependency:
npm i -D node-fetch
My application doesn't need node-fetch, but fetch-mock has a dependency on node-fetch v2. Hope this helps anyone else who faces this issue


Binaries: Access denied

electron-webpack couldn't download binaries  on yarn run dist:
Error output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>node-pre-gyp info using<EMAIL_ADDRESS>| darwin | x64
node-pre-gyp http GET https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.0.0/electron-v1.8-darwin-x64.tar.gz
node-pre-gyp http 403 https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.0.0/electron-v1.8-darwin-x64.tar.gz
node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.0.0/electron-v1.8-darwin-x64.tar.gz

Having the same issue on yarn and npm. I've tried reinstalling entirely, installing earlier versions, --unsafe-perm, pretty much everything from #612
My only dependency on sqlite3 is regular sqlite, which doesn't make sense to me. Is there a workaround?

I have the same issue.
Would be nice to not have to compile the package.
Some of the systems do not have compile tools installed.

@Claytone Finally I get sqlite with electron-webpack working, but never use yarn – even to add something.
rm -rf node_modules
npm install
npm run dist

Works for me with node v8.11.1 and v9.11.1 (over nvm) and "sqlite3": "^4.0.0",

I see it with yarn 1.7.0, but not with npm 6.0.1.
http 403 https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v3.1.9/node-v59-linux-x64.tar.gz

Anyone still having problems please try to v4.0.1 release: https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#401 and see the docs for electron at #1006

electron-webpack couldn't download binaries on yarn run dist:
Error output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>node-pre-gyp info using<EMAIL_ADDRESS>| darwin | x64
node-pre-gyp http GET https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.0.0/electron-v1.8-darwin-x64.tar.gz
node-pre-gyp http 403 https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.0.0/electron-v1.8-darwin-x64.tar.gz
node-pre-gyp ERR! Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.0.0/electron-v1.8-darwin-x64.tar.gz

fix it ？


[Question] Install somewhere other than home dir

What would I need to change in the installation script to install it with its own user "minecraft" in /var/lib/minecraft like other applications do it?

Hey Minecraftschurli,
All you would need to do is open up SetupMinecraft.sh and if you do a Ctrl+F (or a Ctrl+W for searching with nano) and search for the "~" symbol.  That represents the home directory.  There is a DirName=$(readlinke -e ~) that is particularly important.  If you change those it should take care of it for you!


Assignment of incompatible function types allowed

TypeScript Version:  3.3.0-dev.20181221

Search Terms:
Assignment of functions with incompatible prototypes
incompatible parameters
Code
interface Parent { shared: string }
interface Child extends Parent { child_only: string }

interface UnrelatedWide { shared: string }
interface UnrelatedNarrow { shared: string, child_only: string }

// Expected: Parent is not assignable to Child
var inval1: (a: Parent) => string = (a: Child) => a.child_only;

// Expected: string is not assignable to "???"
var inval2: (a: string) => string = (a: "???") => "";

// Expected: UnrelatedWide is not assignable to UnrelatedNarrow
var inval3: (a: UnrelatedWide) => string = (a: UnrelatedNarrow) => a.child_only;

Expected behavior:
For inval1 I expected to receive a Compiler Error due to incompatible assignment from Parent to Child, because Child expects to have the child_only property which Parent does not provide.
For inval2 I expected to receive a Compiler Error due to incompatible assignment from string to the narrower type "???".
For inval3 the expected behaviour is the same as inval1.
Actual behavior:
Passes type check with no errors.
Playground Link
Related Issues:
type Callable = (a: any, ...args: any[]) => any;
type ReplaceFirstArg<U extends Callable, V> = U extends (a: infer P, ...args: infer Q) => infer R ? (a: P extends V ? P : V, ...args: Q) => R : never;
declare function test<U extends Callable, V>(fn: ReplaceFirstArg<U, V>, a: V): void;

// Expected: {} is not assignable to "foo"
test(function (a: "foo") { return "" }, {});

Might be related? I was trying to figure out why incompatible assignment is permitted through test when I discovered the above issue.

Do you have --strictFunctionTypes on?

That's the issue: My project has --strictFunctionTypes enabled, but the playground–where I was debugging the related issue–does not enable that flag by default.


Error when connecting to external kernels

Problem Description
What steps will reproduce the problem?

I was trying to connect to a remote ipython2 kernel (consoles > connect to an existing kernel), selected the .json file, ticked "this is a remote kernel", added my host name. This procedure used to work in previous versions, but for now it doesn't (qt console version is currently on 4.3.1). Thanks for any help
Traceback
  File "/usr/local/lib/python2.7/dist-packages/spyder/plugins/ipythonconsole.py", line 1060, in create_client_for_kernel
    password)
  File "/usr/local/lib/python2.7/dist-packages/spyder/plugins/ipythonconsole.py", line 1782, in _create_client_for_kernel
    client.shellwidget.kernel_client = kernel_client
  File "/usr/local/lib/python2.7/dist-packages/qtconsole/base_frontend_mixin.py", line 57, in kernel_client
    kernel_client.iopub_channel.message_received.connect(self._dispatch)
AttributeError: 'QtKernelClient' object has no attribute 'iopub_channel'

Package Versions

Spyder version: 3.2.8
Python version: 2.7.12
Qt version: 4.8.7
PyQt4 (API v2) version: 4.11.4
Operating system: Linux 4.13.0-38-generic

Dependencies
pyflakes >=0.5.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pygments >=2.0    :  2.2.0 (OK)
pandas >=0.13.1   :  0.22.0 (OK)
numpy >=1.7       :  1.14.2 (OK)
sphinx >=0.6.6    :  1.7.4 (OK)
rope >=0.9.4      :  0.10.7 (OK)
jedi >=0.9.0      :  0.12.0 (OK)
psutil >=0.3      :  5.4.5 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
cython >=0.21     :  None (NOK)
qtconsole >=4.2.0 :  4.3.1 (OK)
IPython >=4.0;<6.0:  5.6.0 (OK)
pylint >=0.25     :  1.8.4 (OK)

Thanks for reporting. We'll let the Jupyter guys know about this error so they can fix it.


Create ensah

@hafsabhjr I am sorry. I have to close the request without merging. Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


append koa-typescript-guide

Thanks for the PR!

thanks your reply, request updated, want merge.
@ellerbrock


belindas-closet-nextjs_5_368_admin-page-and-contact-page-unittest

Resolve: #299

@kaimanasse15 You should create a new branch from main, copy over your tests and make a new PR.

@kaimanasse15 Can I close this PR? I think it's too conflicted to merge.


Section 6 image needs replaced

It says not at all likely on both ends of the scale.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f943a733-9295-0882-d3e1-21aaea5491e6
Version Independent ID: c165bada-eea6-dd3d-dfb4-daffd9c47af8
Content: Create a new survey - Microsoft Forms Pro
Content Source: fp-docs/create-new-survey.md
Service: forms-pro
GitHub Login: @sbmjais
Microsoft Alias: shjais

Thanks for the feedback. We have corrected the image here.
Closing this issue.


Add example to demonstrate channel operator

Add code example let say channel_op.go which demonstrates use of channels in Go
Refer Hello World for reference
https://tour.golang.org/concurrency/2

Hello, is it still a valid issue?

Hello, @monkrus yes this issue is valid.  All the issues with the label v2.0.0 are valid.


README: Mac/linux HelloWorld instruction improvements

It seems that we can have Mac users run HelloWorld too, they just need to brew install devil
I've also made the build.sh file executable, so you can run it on mac/linux.
fixes aardvark-platform/aardvark.rendering#59

thx.
PS.: we should get rid of this soon

Thanks @haraldsteinlechner.
BTW which part are you getting rid of?

devil dependeny will be optional making it easier
Marcin Jekot<EMAIL_ADDRESS>schrieb am Mo., 28. Sep. 2020,
17:24:

Thanks @haraldsteinlechner https://github.com/haraldsteinlechner.
BTW which part are you getting rid of?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aardvark-platform/aardvark.docs/pull/31#issuecomment-700077994,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5KAL5C7O5XLRSB47WG33SICTDLANCNFSM4R3RZKIA
.


label:"p: shared_preferences"  Shared Preferences getBool throws exception

Hi
I have written a package to handle user host settings in my application. The settings is handled by a class that looks like this:
class HostSetting {
  final String _staticIpAddressKey = 'staticIpAddressKey';
  final String _useStaticIpKey = 'useStaticIpKey';

  bool get useStaticIp => _useStaticIp;
  set useStaticIp(value) => _useStaticIp = value;

  String get staticIpAddress => _staticIpAddress;
  set staticIpAddress(value) => _staticIpAddress = value;

  HostSetting() {
    _useStaticIp = (_preferences.getBool(_staticIpAddressKey) ?? false);
    _staticIpAddress = (_preferences.getString(_useStaticIpKey) ?? '');
  }

  Future<void> save() async {
    await _preferences.setString(_staticIpAddressKey, _staticIpAddress);
    await _preferences.setBool(_useStaticIpKey, _useStaticIp);
  }

  String _staticIpAddress = '';
  bool _useStaticIp = false;

  final SharedPreferences _preferences = GetIt.instance.get<SharedPreferences>();
}

As you can see I am using GetIt to create a Singleton instance of the HostSetting class.
  SharedPreferences prefs = await SharedPreferences.getInstance();
  GetIt.instance.registerSingleton<SharedPreferences>(prefs);

To test this class I have created unit tests.
  test('Verify default values', () async {
    var setting = GetIt.instance.get<HostSetting>();
    expect(setting.staticIpAddress, '');
    expect(setting.useStaticIp, false);
  });

Running this test I gets this exception:

So, whats the problem here?  I am probably blind for my own mistakes but I need help to see them.
I am running on windows and vsCode.
This is output from flutter doctor.
[√] Flutter (Channel stable, 2.10.4, on Microsoft Windows [Version 10.0.22000.556], locale sv-SE)
    • Flutter version 2.10.4 at C:\ProgramData\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (2 weeks ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
    • Android SDK at C:\Users\lglin\AppData\Local\Android\sdk
    • Platform android-31, build-tools 32.0.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.10.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.10.31410.357
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.66.1)
    • VS Code at C:\Users\lglin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.38.1

[√] VS Code (version 1.65.0-insider)
    • VS Code at C:\Users\lglin\AppData\Local\Programs\Microsoft VS Code Insiders
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (3 available)
    • BTV DL09 (mobile) • K6T6R16C01000368 • android-arm64  • Android 7.0 (API 24)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.22000.556]
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 100.0.1185.29

[√] HTTP Host Availability

    • All required HTTP hosts are available
``
`

Hi @lgLindstrom, Thanks for filing the issue. Can you please share a minimal and complete sample code along with the tests? We won't be able to tell from the code snippet. Additionally please try running without get it and see if it makes any difference.

Makes no difference using GetIt or not,
Attached my code
/mvh
/lg

Lars-Göran Lindström
Consius AB
+46 70 190 23 30
@.***
Den fre 8 apr. 2022 kl 11:17 skrev Mahesh Jamdade @.***

:

Hi @lgLindstrom https://github.com/lgLindstrom, Thanks for filing the
issue. Can you please share a minimal and complete sample code along with
the tests? We won't be able to tell from the code snippet. Additionally
please try running without get it and see if it makes any difference.
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/101568#issuecomment-1092638688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABE33XCBZVCNMKCZMNFQLGTVD72TRANCNFSM5S33723Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

@lgLindstrom Did you attach the code with the email? Probably attachments do not show up here, Please post it in the comments.

My code.
host_connect.zip

_useStaticIp = (_preferences.getBool(_staticIpAddressKey) ?? false);
_staticIpAddress = (_preferences.getString(_useStaticIpKey) ?? '');

Your keys are backwards here, so the exception is correct. Closing as this is not a bug in the plugin, but in the client code.

Your keys are backwards here, so the exception is correct.

Can someone please explain what exactly that means?

:)
I've switched the keys for string and bool values.


fix #218 by displaying sound durations in HH:MM:SS format

This pull request fixes #218. Sounds in the Pack and Similar <SoundList /> components had hitherto displayed durations in a SS:XX format. This pull request should make it so that those durations now display in MM:SS format for sounds less than an hour long, and HH:MM:SS format for sounds over an hour in duration.
I made two other minor changes.
Firstly, sounds over an hour in length needed more room to display their duration, so I changed the percentage width of sound durations from ~33% to 50%.
Secondly, I noticed an inconsistency between the stated length of sounds on our application and sounds downloaded to a device.
For instance, downloading one track that our application listed as 8 seconds long actually appeared as 9 seconds long in Finder after downloading it.
So, I changed our approach from flooring the incoming sound duration to rounding it:this seems to create a consistent sound duration across our application and the stated duration of downloaded files.

To get an idea of the kind of changes this pull request makes, we can look at a sound with a really long length, e.g., https://freesound-player.vercel.app/sound/376019, and compare that to https://freesound-player-git-fix-sound-length-formatting.amilajack.vercel.app/sound/376019.
Current appearance of our application at the time of this writing

Appearance with the changes in this pull request

By the way, certain really short sounds display a duration of 00:00. While I initially thought this looked odd, it actually matches the duration that appears when downloading a sound with that duration and viewing its metadata or playing it in a media player, at least when I tried previewing it in Finder and playing it in QuickTime Player on macOS Big Sur, so I decided to leave that as is.
Another thing that this commit does is display all sounds in the HH:MM:SS format, instead of just those sounds over an hour in length. I initially thought this looked odd, too, since a ton of sounds less than a minute in length had a lot of zeros, but, on the other hand, it creates a consistent format, HH:MM:SS, across all sound pages, so I figured I would let that be, as well. Do you think these two changes are fine?
Current appearance of this application without the changes from this pull request on a sound page with a really long length:

Appearance of this application with the changes from this pull request on a sound page with a really long length:

Current appearance of this application's homepage without the changes from this pull request:

Appearance of this application's homepage with the changes from this pull request:

By the way, certain really short sounds display a duration of 00:00:00. While I initially thought this looked odd, it actually matches the duration that appears when downloading a sound with that duration and viewing its metadata or playing it in a media player, at least when I tried previewing it in Finder and playing it in QuickTime Player on macOS Big Sur, so I decided to leave that as is.
Another thing that this commit does is display all sounds in the HH:MM:SS format, instead of just those sounds over an hour in length. I initially thought this looked odd, too, since a ton of sounds less than a minute in length had a lot of zeros, but, on the other hand, it creates a consistent format, HH:MM:SS, across all sound pages, so I figured I would let that be, as well. Do you think these two changes are fine?
Current appearance of this application without the changes from this pull request on a sound page with a really long length:

Appearance of this application with the changes from this pull request on a sound page with a really long length:

Current appearance of this application's homepage without the changes from this pull request:

Appearance of this application's homepage with the changes from this pull request:

Thank you for the help!


chore: show date fields on report auto-generator component

ZH Card

Will add e2e test once #1140 is merged.

Looking good! Just one note--this isn't explicit in the AC so I'm not sure if it should be addressed, but the "Generate Reports" heading shows up on the page:  Should that be removed too since the button is gone and you can't generate anymore?

Thanks for bringing this up @BCerki! I'm not sure either.
@nanyangpro would you please take a look at this?!

Good call, @BCerki - Yes, once the reports are generated, the title and the button should all be hidden to avoid confusions. We just want to always show the dates to users.


Files with the same name but different relative paths are being skipped.

This library is skipping files with the same name, but different relative paths.
If I upload this folder structure:
-test/
    -flare.csv
    -test2/
        -flare.csv
        -test3/
            -flare.csv
            etc...

Only the first flare.csv is added, while the rest of the files are passed as the filesSkipped parameter in the filesAdded event. This is happening when I drop a directory onto a dropzone in Chrome. The webkitRelativePath property of the dropped files is blank.
I believe this issue can be fixed by changing this line of code, which resides in the function generateUniqueIdentifier(): https://github.com/23/resumable.js/blob/d19bf23195c9121698357477523d9ca55da3b0c0/resumable.js#L165
to:
var relativePath = file.webkitRelativePath||file.relativePath||file.fileName||file.name; // Some confusion in different versions of Firefox
In fact, this library is checking for the relativePath property at this line:
https://github.com/23/resumable.js/blob/d19bf23195c9121698357477523d9ca55da3b0c0/resumable.js#L456
So in order to maintain consistency, anytime this library checks for a relative path, it should always check for the relativePath property.
I fixed a related bug in my code by manually setting the relativeProperty on dropped directory files. However since you're not checking for the relativePath property when generating a unique identifer, these flare.csv files are getting skipped.
Again, this is only for dropping directories in a dropzone in Chrome.
For context, I'm not using this librarys assignBrowse or assignDrop functions, I am handling the browse and drop events myself, and passing the files to Resumable with r.addFiles
EDIT: I just tried using assignDrop and the behavior is the same.
**EDIT 2 **: I just realized there's an option to provide a custom function for generateUniqueIdentifier . That should solve my problem for now.

Looks like this is fixed by 02e87a75dfebb036d522f029a3701ef0aa7497f9, so this could be closed.


[Autodiff] Fixes memory leaks in autodiff linear map context allocation builtins

When the differentiating a function containing loops, we allocate a linear map context object on the heap. This context object may store non-trivial objects, such as closures,that need to be freed explicitly, at program exit. This PR fixes the autodiff linear map context allocation builtins to destroy and deallocate any such objects.
Fixes #67323

@asl @BradLarson Could I get a review on this?

@swift-ci Please test.

@asl as per offline discussion w/ @BradLarson, since we're already aware of the memory scaling issues with allocating loop context objects directly on the heap I have created a new revision to reintegrate BumpPtrAllocator in AutodiffLinearMapContext while still preventing memory leaks.

since we're already aware of the https://github.com/apple/swift/pull/34886 with allocating loop context objects directly on the heap
@jkshtj Well, this was quite different case, as the chain of boxes were explicitly created ;) Anyway, as we already discussed, as soon as you had the initial implementation on top of the boxes, it was possible to change the underlying implementation to something more lightweight, as we certainly did not want to reference count the pullback tuples.

@swift-ci please test

@swift-ci Please test

@swift-ci please test windows

@swift-ci Please test


Label for "kid" in encryption examples is wrong

In the following example, the unprotected map has two items, the "alg" and "kid":
https://github.com/cose-wg/Examples/blob/892673f8faba75eb4ff8ca7b9507c1455ecb7425/encrypted-tests/enc-pass-01.json#L17-L20
But in the encoded data, we find label 5:
https://github.com/cose-wg/Examples/blob/892673f8faba75eb4ff8ca7b9507c1455ecb7425/encrypted-tests/enc-pass-01.json#L40
According to https://www.iana.org/assignments/cose/cose.xhtml#header-parameters, "kid" is 4 and "IV" is 5.

Never mind, looks like sending IV here was intentional. I just don't know where the KID went.

The unprotected is being pulled from line 6 not from line 17.  I should remove the lines 17-20.


Unable to use in latest React Native version (in version 2.1.0)

When running an application using the latest version of this dependency with the latest version of React Native, the following error appears:
error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':react-native-system-navigation-bar:compileDebugAidl'.
> Could not resolve all task dependencies for configuration ':react-native-system-navigation-bar:debugCompileClasspath'.
   > Could not find com.facebook.react:react-native:0.68.2.
     Required by:
         project :react-native-system-navigation-bar

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s

info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Seems to be releated to the following commit https://github.com/kadiraydinli/react-native-system-navigation-bar/commit/97653186f28c0276106eca6e0716a45c416b3340 Is there a reason to hardcode the react native version to 0.68.2 in this dependency? Trying to understand this change, as I'm using react native version 0.70.6 and it does not seem to work, but it is working in the previous version of this library. For now I'll just pin it to 2.0.1

Same here, please revert that commit

The problem has been fixed. You can use it in the latest version.


Record June 13 meeting notes

@frankhinek what are your thoughts on just merging these? i don't see the need for any of us to approve them (coz most of us were there 😂 )


Selective download of unexplored tiles

As far as I can see, the download links below the map of unexplored tiles supply files that do contain 'all' unexplored tiles. This file can get very large, making it hard to process with other apps. For my squadratinhos it is currently 31MB which cannot be processed by Locus Maps on my mobile device.
It would be a nice feature to be able to download only a selection. This could be the currently visible rectangle in the map or any other method to only select the tiles in the area where I plan my next hike or ride :-)

That totally makes sense! I faced a similar problem with OsmAnd.
JavaScript isn't my strong suit, but I managed to hack this together. And now you the download will only export what you have in the viewport.


min validation rule fails when ConvertEmptyStringsToNull middleware is enabled

Laravel Version: 5.4.11
PHP Version: 7.1.1
Database Driver & Version: n/a

Description:
When \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class is in use, https://laravel.com/docs/5.4/validation#rule-min doesn't see the initial field as empty.  So for instance, password needs to be at least 6 characters after the middleware has converted it to null.
Steps To Reproduce:

Get a fresh Laravel project with a password (or really any other) field with a minimum value
Add the rule 'password'      => 'confirmed|min:6|max:60',
Submit the form
You'll see "The password field must be at least 6 characters".

You need to add the nullable rule to allow nullable fields or a minimum length.  Refs: http://themsaid.com/laravel-convert-empty-strings-to-null-20170130/


Update enable-your-device-for-development.md

-   **Allow all trusted apps to install**
- OR

and below. what meant "-OR-"?

@bergano65 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Enabling sideloading and enabling developer mode are different things, the Or is appropriate. Might need a touch of formatting cleanup, but I'll handle that.


Explore and Customize Your SAP Web IDE Full-Stack

Tutorial URL: https://developers.sap.com/tutorials/webide-customize.html
Please specify the step you are referring to: Step 4: Learn about SAP Web IDE
Correction:
There is no 4th tab (hat icon) to the Learning Center in the side panel. It is only available in Home page. Screenshot below

Thanks,
Mary

Hi,
You are right, we have removed the Learning Center. You can still access the videos that were there previously in our YouTube page.
https://www.youtube.com/channel/UCgScBj_AEGo_mI5accM4XhA
Thank you for pointing this out to us. We will make sure to update the tutorial.

Tutorial has been updated.


Aikido ROS control

@Shushman @mkoval can you compare this with https://github.com/personalrobotics/aikido/pull/103 and see which needs to be worked on? I branched from the mkoval branch and made the fix to use the component refactor.

This change is

I would like to split this into several pull requests:

[ ] convertJointTrajectory
[ ] RosJointStateClient
[ ] RosTrajectoryExecutor
[ ] ExecutorMultiplexer and ExecutorThread
[ ] printCollisionObject and printCollisionResult #106

This branch is based off of, and supersedes, #103. I am closing that pull request.

This is an ASAP task for me now.

 Ok, I will actually work on verifying and merging this branch now. Especially since personalrobotics/rewd_controllers only works on this branch of aikido.

Closing in favor of various other PRs.


Article to link

https://towardsdatascience.com/learn-transformer-fine-tuning-and-segment-anything-481c6c4ac802

Interesting proof of concept. How well does this approach work for larger areas?
The paper that describes the work we did to create the dataset, 4-class models, and catchment-wide map time-series is here https://eartharxiv.org/repository/view/7527/
The segfomer models are published here https://zenodo.org/records/8172858

A full 12+ year, full catchment set of labeled data will be available soon. This consists of a trillions of labeled pixels and would serve as an amazing model training dataset


Fixing parallism icon not showing up in execution plans

Issue #19083
After Fix:

Before:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.002%) to 42.259%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/common/processService.ts
2
81.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
27677

Relevant Lines:
61225

💛  - Coveralls


0.2.2 via online upgrade - crontab not present.

Did an online update from 0.2.1 to 0.2.2 - crontab not present.
I check in /home/yi-hack/sbin/ <--- crontab not present.

Check in /home/yi-hack/usr/bin

good, I see it there. Command is not found though - is there a special requirement to activate it, install it, etc..?

nevermind ./busybox crontab works

./busybox crontab enables crontab


Allow custom display name format for spans (#45)

This allows users to, when creating the exporter, use a custom DisplayNameFormatter function to specify how to create the display name from span data. Default format remains the same. Addressing issue #45

@stevencl1013 Can you run make precommit? It's failing as the following:
=== RUN   TestExporter_Timeout
    TestExporter_Timeout: cloudtrace_test.go:157: err.Error() = "rpc error: code = Unknown desc = context deadline exceeded"; want "rpc error: code = DeadlineExceeded desc = context deadline exceeded"
--- FAIL: TestExporter_Timeout (0.00s)
FAIL
FAIL	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace	0.029s
FAIL
make: *** [Makefile:85: test-386] Error 1

@ymotongpoo When I ran make precommit on my machine, all the tests passed. I think there might be an issue with the timeout test, because it did get a context deadline exceeded error, but failed because it got rpc error: code = Unknown instead of rpc error: code = DeadlineExceeded. I've experienced this issue occasionally on my machine as well in the past.


[Question] Adding CSS classes to widgets

I am looking for an opportunity to add custom css classes to a form widget and extend its 'form-control' class by using the template tag. Unfortunately the parameter 'field_class' modifies a higher-level DIV.

If there is no interest in discussing this any further, I think we should close this issue.

Just stumbleded around this issue trying to find an "easy" way to add custom css (and data-attributes) to a widget (in order to use bootstrap-select).
Kinda surprised that this is not supported.

However you can use django-widget-tweaks in order to customize the input widget before it is handled by django-bootsrap4. This might be a nice solution:
{% bootstrap_field form.field|add_class:"what_ever_class_you_like"|attr:"data-foo:bar" %}


how to use with angular

just i am wondering how to use this lib with angular 18?

Hi @AhmedHossamFCI
You can use it just like you would with any other type of library, framework of vanilla javascript. I've actually tried it on some simple testing Angular app and it works as expected.

Add the package to the dependencies section on the package.json file:

"accessibility": "*"

and run npm install.
2. Import the Accessibility class to the component that you want to display the tool (for example app.component.ts) like so:
import { Accessibility } from 'accessibility';

Create a new instance of the class like this:

ngAfterViewInit() {
  setTimeout(async () => {
    new Accessibility();
  });
}

Please let me know if there are any issues with the tool in Angular.


[$500]  Compose Box - Focus not lost from composer on LHN popup open

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.11-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open the app
Open any report and send any message
Focus on composer
Click on plus besides the composer to open Actions popup
Right on any chat in LHN to open popup on LHN
Observe that even though popup is open in LHN, app still focuses on composer

Expected Result:
App should not focus back on composer whenever any popup is open
Actual Result:
App focuses back on composer when we open actions popup and open any right click popup in LHN
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/74137c5f-18a4-4e16-8ee5-d8ccfda09552
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0123ed583fdc5774f0
Upwork Job ID:<PHONE_NUMBER>117650432
Last Price Increase: 2023-12-13
Automatic offers:

bernhardoj | Contributor | 28067465

I liked @bernhardoj's proposal to fix this with ComposerWithSuggestions's popover context visible state.
🎀 👀 🎀 C+ reviewed

@jasperhuangg when you have a min can you review @bernhardoj 's proposal above?
https://github.com/Expensify/App/issues/32970#issuecomment-1854133465

Sorry for the delay, NewDot deployer chore has taken a lot of time this week. Looks good to me, assigned!

@mananjadhav hi, we have a regression here. The issue is that the isPopoverOpen state is late to update, so the focus always fails. More info is explained on the proposal there.
After looking at the linked proposal, I remember we have a PR that will do a big refactor to the composer focus logic and when I look around the PR, I found that they will handle this issue too.
I don't think there is an easy way to handle this globally, so, sadly I think we should revert our PR and wait for the above PR. (except we want to handle this issue for LHN (report context menu) only, which means my main solution)
Let me know what you think!

@mananjadhav can you review @bernhardoj 's comment above and propose the next best steps? Should I put this on hold pending https://github.com/Expensify/App/pull/29199 ?

I can see the PR is already reverted. Yes we should put this on Hold pending #29199

Put on hold pending https://github.com/Expensify/App/pull/29199
Removed 'hold for payment' too

Held, nothing to do here!

https://github.com/Expensify/App/pull/29199 is still being worked on and this issue is on hold.

Still held, started a convo in C+ channel here
Also adding a BZ backup for my OOO

Still on HOLD for https://github.com/Expensify/App/pull/29199

Same ^

Same ^^

^^^ Same

Still on hold

Commented on the PR this is held on

https://github.com/Expensify/App/pull/29199#issuecomment-2026256884

Also.. are we sure that the behavior isn't intended?  Whenever I click on a chat in LHN, my assumption is that the chat opens and the cursor is in the compose box.  I understand that there was a pop up open previously but we w
ouldn't expect that pop up to stay open if we navigated to another chat then immediately back again, right?
Maybe there are other examples I'm unaware of where we keep the pop up while taking other actions?

Putting on #vip-vsb for now, since this doesn't have to do with money

The issue we have here is that the composer is focused when we open a second popover.

Click on plus besides the composer to open Actions popup
Right (click) on any chat in LHN to open popup on LHN
Observe that even though popup is open in LHN, app still focuses on composer

Thanks @bernhardoj , I def missed that part :ohnothing:
I was able to reproduce

I feel like it's a pretty rare edge case and it doesn't affect functionality.  BUT... having that second popup from the LHN hang around isn't idea.  Let's wait for this to come off hole then I'll retest then decide what to do with it.

Still on HOLD

Still held

@ntdiary will resume working on https://github.com/Expensify/App/pull/29199
This issue is still blocked on https://github.com/Expensify/App/pull/29199

Still blocked on https://github.com/Expensify/App/pull/29199

https://github.com/Expensify/App/pull/29199
Held on above and it looks like it's still a draft

@ntdiary Awesome! Sounds like a good idea to split up the PR. Thanks for the update.

https://github.com/Expensify/App/pull/42423
Above merged so we're getting close

The PR we were holding on closed without being fixed. I threw a retest-weekly on here to see if the bug exists six months later.

Try to refactor the logic regarding refocusing when the modal is closed

@mallenexpensify Should we keep this as a weekly or demote to monthly if we're gonna wait so far out?

@mallenexpensify @lanitochka17 Are we still retesting this on weekly cadence?

@jasperhuangg retests take a weekish.  @ntdiary and I are both able to reproduce so the bug still exists. I think we need to decide between

Close it cuz it's a minor bug that doesn't affect functionality (I might actually prefer to be able to type and have the text fill the compose box vs nothing happening if I type)
Review existing proposals to see if we want to accept any
Add Help Wanted to get more proposals
Something.

I don't think we need/want to increase the price though

Thanks @ntdiary , I'm going to close, comment/reopen if you disagree.


MountVolume.SetUp failed for volume “mongo-two”: lstat /mongo/data: no such file or directory

Is this a request for help?: yes

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes: helm v2.10.0-rancher5, kubernetes v1.11.5
Which chart: mongo-replicaset 3.8.0
What happened:
Deploying never end, kubelet logs infinitely:
MountVolume.SetUp failed for volume “mongo-two”: lstat /mongo/data: no such file or directory
But /mongo/data folder exists on all nodes hosts.
What you expected to happen:
Local Persistent Volumes for mongo data should be mounted correctly.
How to reproduce it (as minimally and precisely as possible):
Get a cluster with three nodes, named one, two and three.
Create storage class:
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: local-storage
provisioner: kubernetes.io/no-provisioner
volumeBindingMode: WaitForFirstConsumer
reclaimPolicy: Retain

Create 3 PVs:
apiVersion: v1
kind: PersistentVolume
metadata:
  name: mongo-[one/two/three]
spec:
  capacity:
    storage: 40Gi
  accessModes:
  - ReadWriteOnce
  storageClassName: local-storage
  local:
    path: /mongo/data
  nodeAffinity:
    required:
      nodeSelectorTerms:
      - matchExpressions:
        - key: kubernetes.io/hostname
          operator: In
          values:
          - [one/two/three]

Deploy mongo-replicaset helm chart 3.8.0:
yaml config:
replicas: 3
replicaSetName: rs0
port: 27017
auth:
  enabled: true
  adminUser: admin
  adminPassword: password
  key: fsz1468fez468
image:
  repository: mongo
  tag: xenial
  pullPolicy: IfNotPresent
persistentVolume:
  enabled: true
  storageClass: local-storage
  accessModes:
  - ReadWriteOnce
  size: 40Gi

Resulting stateful-set yaml extract:
...
  volumeMounts:
    - mountPath: /data/db
      name: datadir
...
  volumeClaimTemplates:
  - metadata:
      creationTimestamp: null
      name: datadir
    spec:
      accessModes:
      - ReadWriteOnce
      storageClassName: local-storage
      resources:
        requests:
          storage: 40Gi
...

Anything else we need to know:
-While deploying, PV status is "Bound" with correct claim name, but fail to be mounted.
-When I deploy chart with persistentVolume.enabled: false, deployment succeeds
-My nodes hosts are ubuntu 16.04
-Sometimes the first pod deployment finish, but the second fails.
-On hosts, running "lstat /mongo/data" gives no command found
-On hosts, running "stat /mongo/data" succeeds
Thanks you

Ok the difference was I use a contenairized kubelet.
I add my volume bound into kubelet container and it's OK.


Chinese localization is not completed.(v1.3.0)

VSCode Version: Code 1.3.0 (e724f269ded347b49fcf1657fc576399354e6703, 2016-07-07T16:56:12.476Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:
1.Click the Extensions View icon.
2.Click on the ... More button, "show popular extensions" is still English.

Our translation process takes around a week to finish. This is why milestones builds will always have a minor amount of strings in English (especially around new features).


H

Please describe the bug
Please give a clear and concise description of what went wrong.
Explain the steps needed to reproduce the bug

Navigate to to '…'
Click on '…'
See an error…

What was the expected behaviour?
Screenshots
If applicable, please add screenshots to help explain your problem.
What web browser were you using? (if relevant)
If you're reporting a bug with the front end, please include your browser information below:

Platform: Desktop/Tablet/Smartphone
Browser [e.g. Chrome, Safari]
Version [e.g. Version 15.1]

Additional context
Is there anything else we might find useful?

I have a feeling this may have been a mis-click! Please feel free to open the issue again with the problem description, but I'll close this one for now.


Title:  Making clock to World Clock

Is your feature request related to a problem? Please describe.
If we have a clock then why we just see time of our country and not other.
Describe the solution you'd like.
i want to transform existing clock to world clock so we can see time of any country by just selecting that country. Just select any country and you will be able to see the time, i will also add digital clock
Describe alternatives you've considered.
There might not have any other feature than this.
Add any other context or screenshots about the feature request here.

Assign this issue to me to improve existing clock.

Assign this issue to me to improve existing clock.

@VaibhavDhanani Create a seperate project for this. All the best 👍🏻

ok, i have added as 112 - world clock


Java: add Sonar configuration

I propose following approach:-

Add plugin configuration in pom.xml
Add sonar.properties
Add sonar.yml in src/main/docker for sonarqube community server.

@pascalgrimaud would you suggest anything more to be done?

Yes it's the good approach I think
Anyway:

I don't know if we have all method to add the configuration in pom.xml. We need to check this part first and do a 1st PR separately if needs
then, I wonder where to put this. Maybe in server/java/sonar. Not sure it's specific to java, as it could be similar if it was kotlin. Maybe simply server/sonar ?

I don't know if we have all method to add the configuration in pom.xml. We need to check this part first and do a 1st PR separately if needs

Yes, would enhance the BuildToolDomainService with required configurations in plugins

then, I wonder where to put this. Maybe in server/java/sonar. Not sure it's specific to java, as it could be similar if it was kotlin. Maybe simply server/sonar ?

I agree, its not just java, as per current structure it should be server/sonar.
Then I think its not limited to only server-side applications, then even server/javatool should not be in server. Isn't it?

oh by server, it means backend, so I think javatool is in the right place. Anyway, it would be easy to move if needed.
About sonar, we could have another / similar configuration for "client", like Angular, React or Vue later.
So I'm suggesting this:

put it into server/sonar for now, and then later we could move it if it's necessary

What do you think?

Yes, let's start with server/sonar and move it later if needed :)
You may assign this ticket to me.

Not sure if it can help: https://github.com/pascalgrimaud/jhipster-lite/commit/cfd245cfbf042c016f6fec46995ae508be98582b
I did this for JHLite, and to reduce the code smells, before working on pushing an analysis to Sonarcloud


Proposal: Omit specified custom headers from being added to the TOC

All headers of the specified range (for example H2:H6) are added to the TOC. I have also H2 "Table Of Contents", which should be omitted from being included into the TOC. Also, it would be nice to omit some custom short subsections  (not all), which also belong to the specified range.
A special attribute in the comment can be used as a command to omit the required header from being added to the TOC like specified here.
## Table of Contents   <!-- TOC omit:true -->

By the way, the comments are not recognized in the current version (v.1.3.0), which yields the following TOC for this example:
- [Contents  <!-- TOC omit:true -->](#contents----toc-omit-true)

Makes sense. I will look into it during the weekend.
I prefer a short comment like <!-- omit -->.

By the way, the comments are not recognized in the current version

Thanks for catching that

This would be great, otherwise we have docs looking like this:

I would expect document headers (H1 equivalent) to be omitted from the TOC and the TOC's tree to start at H2.

@luispabon In this case, you can set tocLevels to 2..6 in the workspace setting then the H1 will be ignored.

@neilsustc apologies, I didn't realise I could do this. It's exactly what I needed, thank you :+1:

I prefer a short comment like <!-- omit -->

It is convenient but you might would like to consider several aspects:

How would the user know that this comment relates to header omission from the TOC?
Such comment might be occasionally removed by the user later, so it would be nice to include TOC as the first term to identify the relation, i.e. <!-- TOC omit -->
In case you would like to add any additional commands later, like explicit specification of the rendering headers via the comment or anything else (<!-- TOC depthFrom:2 orderedList:true -->) then it would require to desing a uniform format attribute[:value]. The format of the commands can unified from the start taking into account these possibilities and providing backward/forward compatibility.

Personally I don't like to introduce too many distracting things to Markdown writing (as said in the README).

So for point 2, I might be never willing to add this kind of features because they mess the document (unless there are many requests for them).
For point 1, I just don't like capitalized TOC characters. But I think I can make it in-casesensitive so I can choose to use toc.
What do you think about <!-- omit in toc --> or <!-- toc omit -->?
(And feel free to use TOC if you prefer)

<!-- omit in toc --> is semantically perceivable.
Non-capitalized <!-- toc omit --> is not relly clear until some hints are made that this is a command or that we omit from the TOC but not the TOC: <!-- toc: omit --> (the colon sign makes it clear).

Thanks for the feedback. Will implement it later.

Please try v1.3.0-fix177

Thanks,
 <!-- omit in toc --> works fine!


adding windows functionality for 'last updated'

including windows functionality for "last updated" in notebooks.
import os
last_modified = None
if os.name == "posix":
    last_modified = !stat -f\
                    "# This notebook was last updated: %Sm"\
                     Snapping_Demonstration.ipynb
elif os.name == "nt":
    last_modified = !for %a in (Snapping_Demonstration.ipynb)\
                    do echo # This notebook was last updated: %~ta

if last_modified:
    get_ipython().set_next_input(last_modified[-1])

Pull Request Test Coverage Report for Build 611

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 85.912%

Files with Coverage Reduction
New Missed Lines
%

spaghetti/network.py
2
89.43%

Totals

Change from base Build 610:
0.0%

Covered Lines:
994

Relevant Lines:
1157

💛  - Coveralls


{WIP} fixing unit tests

I'm not quite sure you commit message and the commit match 😛

I know there are errors, waiting for the mime-types-data error to be fixed by @DavidS :) (ducks)


Add Push or PR test build workflow file

The workflow focus on test changes in openjdk-tests, which means changes
with jenkins won't be covered by this workflow.
Signed-off-by: Sophia Guo<EMAIL_ADDRESS>

Depends on https://github.com/AdoptOpenJDK/run-aqa/pull/28. When https://github.com/AdoptOpenJDK/run-aqa/pull/28 is done the yaml file need to update to use run-aqa v1.

Failures are jdk_util 8 failures. Not related with the yml file.

This workflow works for three scenarios:

User push the branch, the action will be triggered in user's personal repo ( enable action)
User create the PR in openjdk-tests repo, the action will be triggered in openjdk-tests
PR is merged to openjdk-tests

Open to discuss, the main purpose is to ensure PR's functionality. Pick a specific test should be enough for now? That is saying we don't need to run the whole sets. Question: minimum tests set we should select? ( jdk_version, os, build_list, target)
Going forward we can get PRs labels to decide the test targets. So next step we can add the action to auto label PRs.

@sophia-guo I agree that we should just take a sampling of tests as a starting point (a small target from each directory/group), then become smarter about it, by seeing which directories changed and selecting for that.

Updated with
Openjdk test against hotspot with running with os: [ubuntu-16.04,
macos-10.15, windows-2016],  version: [8, 15]
System test against openj9 with running with os: [ubuntu-16.04,
macos-10.15, windows-2016],  version: [8, 15]
https://github.com/sophia-guo/openjdk-tests/actions/runs/331641472

Investigating failures on Windows.

Windows issue fixed. Update pull request repo name as github.event.pull_request.head.repo.full_name and push repo as github.repository.
action takes  1h 25 mins with each job only takes a few minutes. The longest one takes 9 mins. That is even though jobs are parallel some will still be in queue due to the runners availability.

Thanks for confirming the execution times!


not working on Firefox mobile/fennec

Recently it started working on edge. However with fennec + this extension it still doesn't work
 fennec with this extension
 edge

Hi, first, can you confirm your device, OS version, and FF app version for reference?
As a side note, the screenshot shows you can access the bing chat menu. When you do not have access, it will display like this. Maybe it could be a temporary error from Bing's side, as I also experienced that error message but it went away couple hours later.

Xiaomi Mi 10, Fennec 110.0.1 (fdroid's fork of Firefox, I use it so I can have custom extensions without using betas), android 12
Still seems to happen

🤔 I'll try to install an emulator to look into the issue, but please understand that I cannot make any concrete promises, as multiple factors could be counting into this.
Meanwhile, can you check if the regular Android Firefox can run Bing Chat, as others reported? This is to track if this is a Fennec-specific error or something else.

Any help from other experts in Android & Fennec would be highly appreciated!

Nvm, fixed by just logging out and then logging in again.
Sorry for wasting your time

All good! Thank you for your time for reporting and investigating the issue with me. I'm happy that the extension now works for you. Enjoy bing-ing!


[CI] Function run_codecov bool judgement fix

/test-conformance

/test-e2e

/test-e2e

Codecov Report

Merging #2113 (4e22393) into main (c67106c) will decrease coverage by 19.69%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2113       +/-   ##
===========================================
- Coverage   61.23%   41.54%   -19.70%
===========================================
  Files         270      131      -139
  Lines       20376    16449     -3927
===========================================
- Hits        12478     6834     -5644
- Misses       6609     9031     +2422
+ Partials     1289      584      -705

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
41.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 After that only commit message was updated.
/skip-all

Skipped "Go / Verify docs and spelling" temporarily as www.strongswan.org is not available.


Latitude/longitude plot of redshift.

Solves #156.

Coverage remained the same at 26.741% when pulling 0386a6c1de9eabad174f737a87a28244e868e793 on jakubnabaglo:master into 79346b2074d34d73ad9bcc6ef0f9e8e6892881ee on chengsoonong:master.


removeTag & removeUnusedTag

implemented Model API for removeTag(Tag tag) as Model component enhancement.
added private AddressBook#removeUnusedTag() method to update tag list when contacts get edited or deleted.

Pull Request Test Coverage Report for Build 5

28 of 30 (93.33%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 91.902%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/model/ModelManager.java
0
2
0.0%

Totals

Change from base Build 4:
0.08%

Covered Lines:
1498

Relevant Lines:
1630

💛  - Coveralls


How many server did you scanned or fixed?
Did you completed your mission? How long does it take?
Have you tried other tools? What was the difference?
Do you have any useful tips?

We are still investigating. In the first try we scanned our DMZ systems now we are going to scan the rest. At the end its around 2900 Servers (Win/Unix).
We searched with own powershell scripts etc. what our automation team is missing the most are error codes for the scanner but we are happy to have this tool :)

Would you introduce yourself?  Sr Linux Sysadmin at Pavlov Media.  Formally a Java developer.
How many server did you scanned or fixed? scanned several hundred, fixed about 20.
Did you completed your mission? How long does it take? Not completed.  The darn issue keeps expanding with more CVEs.
Have you tried other tools? What was the difference? Looked at other tools, the best one requires python to be installed on hosts to run it; total non starter for Windows, our Senior Windows admin rejected that idea outright.  He's willing to use the pre-compiled binary for windows, though.  (I'm old school and don't download linux binaries from github, I build from source.)
Do you have any useful tips?  Beware  the spaces in filenames issues.  Running the jar on Linux doesn't like being told to use a ./ prefix on a path.  windows doesn't like putting quotes around parameters, and powershell can mangle your dashes and quotes.  I'm used to bash so I escape such things without thinking much about it.

Would you introduce yourself?

I'm a software developer and automation engineer working for the endpoint management product HCL BigFix. I am trying to contribute back to this project as I can as we work on content to automate it.

How many server did you scanned or fixed?

Helping our customers scan thousands of systems at once by running this utility through BigFix.

Did you completed your mission? How long does it take?

Have things working on well on Windows and Linux. Trying to figure out the best way to run on other platforms seamlessly even if there isn't already a JRE installed. We have a massive discussion happening here: https://forum.bigfix.com/t/log4j-cve-2021-44228-detection-and-mitigation/40141/324

Have you tried other tools? What was the difference?

We tried approaches that scanned looking for JAR files that contain log4j2-core-* but the Logpresso scan utility found tons more results within renamed JAR files, WER files, EAR files, and JAR files that contain many things bundled together.

Do you have any useful tips?

Test test test. Do gradual rollouts across many devices to not overwhelm storage of VM hosts.

Would you introduce yourself?
I lead a security software company that helps organizations operating Critical Infrastructure to detect and mitigate threats
How many server did you scanned or fixed?
10,000+ Servers
Did you complete your mission? How long does it take?
We are using Logpresso with our other tools as an "enhanced" detection mechanism and are having great luck so far!
Have you tried other tools? What was the difference?
The developer of Logpresso is way more responsive :)
Do you have any useful tips?
Test!

Would you introduce yourself?
I'm a IT Engineer from Germany.
How many server did you scanned or fixed?
MANY. Number increasing.
Accidentally fixed a system automatically with the parameter force-fix :-D
Did you completed your mission? How long does it take?
I'm pretty sure this issue will be with us for a long time, like the coronavirus.
Everyone should scan their hosts on a regular basis. Use a monitoring tool. We build a check plugin for checkmk. Open-Source and free version available.
Blog arcticle
Latest version of the check plugin
Discussion to for the plugin developement - JOIN US!
With checkmk we were able to push the check on all monitored linux/windows hosts at once. The check will be executed every 4 hours.
For questions about checkmk ask Martin Hirschvogel<EMAIL_ADDRESS>(@martinhv)
Have you tried other tools? What was the difference?
Not yet. But I will do this for cross-checking.
Do you have any useful tips?

As @jlellis mentioned no one should use binaries downloaded from unknown sources.
Provide checksums for the files to help finding possible code injections.
Provide howtos to build the binaries from source (@jlellis Can you assist here?)
Keep the scan binaries as small as possible so that the deployment doesn't use as much bandwidth.
I still have a stomachache when rolling out the scan tool to many systems. I don't want to kill many systems at once through my own fault. Find a solution to reduce CPU usage.

@xeraph AWSOME work! Keep going! Tell us if you need help. Contact the checkmk guys and bundle your competences.

Great scanner, thank you. Very easy to use and very effective too.
Used on Windows with the following in a batch file
start "ServerName" /D .\Log4jScan /I log4j2-scan.exe --scan-log4j1 --scan-logback --scan-zip --report-path .\logs\ServerName.csv --report-csv \\ServerName\C$
We are able to scan our 89 servers from a single location this way.


Build Manage Networks for Hosts!

python3 manage.py host exec list_networks host_id=1
python3 manage.py host exec get_network host_id=1 network_id=08e5caac9$$$$
python3 manage.py host exec prune_networks host_id=1
python3 manage.py host exec remove_network host_id=1 network_id=08e5caac9$$$$


Provide a simpler convenience API for writing rules

Slack conversation
When writing rules, I expect to have to do custom traversal of the AST in some cases. However, the majority of the time it seems like there's a lot of non trivial repetition across rules (e.g. traversing the AST to find a when vs having a visitWhen function).
Detekt has some nice abstractions around working with PSI and KtFile. Looks like most of that is supplied through the Kotlin compiler's KtVisitorVoid and then some wiring through detekt's BaseRule.
Having the convenience functions from KtVisitorVoid are very helpful and make development simpler.

Very interesting idea for 1.0

I have investigated it. Sofar, I cannot find a way to implement KtVisitorVoid without loosing ktlint functionality.
When using the KtVisitorVoid, the traversal of the nodes in the AST is delegated to the KtVisitorVoid instead of using ktlint's AST traversal mechanism. This results in loosing the ability to suppress certain rules on specific code constructs.
Without implementing KtVisitorVoid, this can be demonstrated in ktlint internally. The KtVisitorVoid functions have a single parameter:
public void visitPrimaryConstructor(@NotNull KtPrimaryConstructor constructor) {

while Ktlint calls function below for each ASTNode:
public open fun beforeVisitChildNodes(
    node: ASTNode,
    autoCorrect: Boolean,
    emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit,
)

I have refactored the method as follows by extract the parameters autoCorrect and emit to class properties:
class Rule { // Simplified
    protected val autoCorrect: Boolean
        get() = ...

    protected val emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
        get() = ...

    public open fun beforeVisitChildNodes(node: ASTNode)
}

I have refactored both RuleExecutionContext to initialize the autoCorrect and emit before starting traversal of the rule. Also, I have refactored a single rule to use the new signatures. All worked well, until I ran the entire suite of unit tests. Out of 2000+ unit tests, 33 of them were failing. All failing tests had a code sample containing an Suppress annotation to suppress a ktlint rule. For example:
val fooWithIndentationFixing1: String =
    "foo" +
        "bar"
@Suppress("ktlint:standard:indent")
val fooWithIndentationFixingSuppressed: String =
    "foo" +
    "bar"
val fooWithIndentationFixing2: String =
    "foo" +
        "bar"

The code above produced a lint violation on block:
@Suppress("ktlint:standard:indent")
val fooWithIndentationFixingSuppressed: String =
    "foo" +
    "bar"

while no violation was expected as it is suppressed with an annotation.
This problem is caused by moving the autoCorrect parameter to a property of the Rule class and by that make it a constant for all nodes in the class instead of determining per node whether the rule needs to be suppressed for the rule. To solve this, the suppression handling would need to be moved to the Rule class which I am not willing to do as it would make the functionality public. Also, this change will be a breaking and needs changes in all rules.
KtVisitorVoid can not be implemented until above can be solved in acceptable way.

@paul-dingemans would it be possible to create a base class for Rule and move suppression handling there in a way that isn't visible from subclasses?

You made me thinking about this issue again.
I found a way to work around the problem without moving the suppression handling to a different module. But is really means that a lot of boilerplate code has to be provided in ktlint. I have to find a way to generate this code to keep things maintainable. The idea is as follows:
Next to the standard beforeVisitChildNodes function
    public open fun beforeVisitChildNodes(
        node: ASTNode,
        autoCorrect: Boolean,
        emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit,
    ) {}

the rule class (or its base class) had to provide an additional function for each Kt-construct. Examples:
    /**
     * This method is called on a node of element type 'IF' in the AST before visiting the child nodes.
     *
     * @param ktIfExpression the [KtIfExpression] of a node with element type 'WHEN'
     * @param autoCorrect indicates whether rule should attempt autocorrection
     * @param emit a way for rule to notify about a violation (lint error)
     */
    @Suppress("unused")
    public open fun beforeIfExpression(
        ktIfExpression: KtIfExpression,
        autoCorrect: Boolean,
        emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit,
    ): Unit =
        beforeVisitChildNodes(ktIfExpression.node, autoCorrect, emit)

    /**
     * This method is called on a node of element type 'WHEN' in the AST before visiting the child nodes.
     *
     * @param ktWhenExpression the [KtWhenExpression] of a node with element type 'WHEN'
     * @param autoCorrect indicates whether rule should attempt autocorrection
     * @param emit a way for rule to notify about a violation (lint error)
     */
    @Suppress("unused")
    public open fun beforeWhen(
        ktWhenExpression: KtWhenExpression,
        autoCorrect: Boolean,
        emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit,
    ): Unit =
        beforeVisitChildNodes(ktWhenExpression.node, autoCorrect, emit)

The KtlintRuleEngine will call the new dispatcher function beforeNode instead of beforeVisitChildNodes:
    public fun beforeNode(
        node: ASTNode,
        autoCorrect: Boolean,
        emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit,
    ) {
        when(node.elementType) {
            IF ->
                node.psi.safeAs<KtIfExpression>()?.let { return beforeIfExpression(it, autoCorrect, emit) }
            WHEN ->
                node.psi.safeAs<KtWhenExpression>()?.let { return beforeWhen(it, autoCorrect, emit) }
        }
        // In case no mapping exists for the element type, or if the PSI of the node could not safely be cast to the Kt-type, then fall back
        // on the generic handler.
        beforeVisitChildNodes(node, autoCorrect, emit)
    }

And the same has to be done for the afterVisitChildNodes. Based on some configurartion it should be doable to a generate a class that contains those functions.

@eygraber See explanation in #2158 why I this will not be implemented in ktlint with the solution provided in the PR. The performance downgrade is not acceptable for the small benefit of rule developers.


Update port_platform.h

fix WIN32_WINNT  not defined

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @IronsDu isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

I'm not very knowledgeable about this, delegating to @nicolasnoble  who wrote most of the windows code.

@IronsDu   can you elaborate on what the problem is?  Just saying "fix WIN32_WINNT not defined" is not sufficient, our testing platform is running plenty of windows builds and tests and we're not seeing problems.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


RCIAM 852 and RCIAM 851

This PR fulfills the objectives of
https://jira.argo.grnet.gr/browse/RCIAM-852
and
https://jira.argo.grnet.gr/browse/RCIAM-851

@nliam This needs to be reviewed again


Resolve esbuild warnings

Brief bug description
What went wrong?
After upgrading angular to v18 and using the new build system, which is esbuild instead of webpack, I see the following error.
▲ [WARNING] Calling "urlParse" will crash at run-time because it's an import namespace object, not a function [call-import-namespace]

    node_modules/@kontent-ai/delivery-sdk/dist/es6/utilities/delivery-url.helper.js:8:22:
      8 │     const parsedUrl = urlParse(url);
        ╵                       ~~~~~~~~

  Consider changing "urlParse" to a default import instead:

    node_modules/@kontent-ai/delivery-sdk/dist/es6/utilities/delivery-url.helper.js:1:7:
      1 │ import * as urlParse from 'url-parse';
        │        ~~~~~~~~~~~~~
        ╵        urlParse

Repro steps
Build an angular project which uses the delivery SDK and is using the newer esbuild.
Expected behavior
No warnings about urlParse.
Test environment

Platform/OS: node v22, angular v18

Additional context
Happens with both delivery-sdk v14 and v15.

https://github.com/angular/angular-cli/issues/28929


It seems a CORESVG issue - Here after installation

Hi,
he situation on Mac (Big Sur OS)
There is no actionable buttons, nothings works

Thank you

No, that's exactly what it's meant to do. As stated on the readme, it's just a mockup, there's no logic.


Permission denied error for creating renate-sample directory

I am trying to run RENAT following the guide using a container. I am running into the below error in step 4 where I get permission denied errors. I do not know the sudo password for this container so I obviously cannot use that.
bash-4.2$ whoami    robot   bash-4.2$ pwd   /home/robot/work/renat   bash-4.2$ $RENAT_PATH/tools/project.sh renate-sample mkdir: cannot create directory ‘renate-sample’: Permission denied cp: target ‘renate-sample’ is not a directory find: ‘renate-sample’: No such file or directory created test project:  renate-sample use item.sh to create test case
Is there a workaround for this issue?

Seems the robot user on the image does not have permissions to the configured default folder.
Switching to the robot users home dir seems to fix the issue.


missing feature : default terrain ?

right now, if someone give -1 as terrain id it does act like a basic terrain you can overwrite, I dont think there's a need to do anything more about that

I agree. We only need for it to default to -1. How user handles with that is up to them.


Fix: try unicode replacemenets for wacky renderings of some currencies [untested]

refer to: https://discord.com/channels/1001847734766145607/1166105955516305508/1168465753872273438

PSS pr limbo


Please document REST api tags for users

Instead of just saying: "We recommend using the JavaScript SDK", please describe the information that should be added when contacting the Application Insights REST api. The tags 'ai.user.id', 'ai.user.accountId' and 'ai.session.id' documented in the official GitHub repository have no effect on the Azure Portal Users and Session pages, they always display "1 User", "1 Session", even though inside the event details user ids are displayed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 306c312c-8c07-9cdf-a0e0-239dc823bbde
Version Independent ID: 572696a5-450f-5b84-65d9-b7d522dcaba8
Content: User, session, and event analysis in Azure Application Insights
Content Source: articles/application-insights/app-insights-usage-segmentation.md
Service: application-insights
Product: unspecified
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin; daviste

@RobertoPrevato Thank you for the feedback!  Is this the REST API documentation you are looking for?  I didn't see any mention of the JavaScript SDK on the document that was included.
https://dev.applicationinsights.io/reference

Hi @RobertoPrevato,
Here's the details on the REST API properties: https://github.com/Microsoft/ApplicationInsights-Home/blob/master/EndpointSpecs/Schemas/Docs/ContextTagKeys.md
Can you provide more details about exactly what you're sending and not seeing in the Users/Sessions tools? Go to the Users tool when it shows "1 user" erroneously, click the little blue square Analytics button above the chart, and copy the query that results here. Probably the fastest way for us to debug.

(I wouldn't call the data collection apis "the REST API", as there's really only a REST API for reading data, that's whats documented at dev.applicationinsights.io)
The things documented on the GitHub link David posted are the same that our SDK's use.  if you go up a couple directories to the "Bond" folder (https://github.com/Microsoft/ApplicationInsights-Home/tree/master/EndpointSpecs/Schemas/Bond) those files are used to generate the much of the code the that the official SDKs use.
if you're sending data directly to dc, where things go depends on how/where/version you're using.  so a specific example of an event you're sending would be helpful.
if you're using the javascript sdk, then the names of things in the documented schema aren't something you would use, you'd use the methods on the sdk directly to set things like user and session information.

yes, for "usage" purposes, many people only consider pageviews and custom events to be "usage".  so the users tool defaults to only showing events + pageviews if there are any.  (I think the text in that view is being clarified to "custom events and page views").  If there are no events or pageviews, then the users tool falls back to showing requests.


improved the dev docs

Purpose of PR?:
This PR aims to improve documentation for new contributors as the old docs was deprecated
Fixes #
Does this PR introduce a breaking change? No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

@DelusionalOptimist @daemon1024 Please review this as the documentation is lagging behind!

Can we fix the commit history, the PR looks mostly ready to merge. Thanks for taking your time to contribute :D

I am trying to fix this but the older commits are appearing  on squashing the commits which were committed after this PR. Can you please tell me how to fix this?

@daemon1024

Probably best to reset the branch to main and manually creating a new commit with all the required changes.

Probably best to reset the branch to main and manually creating a new commit with all the required changes.

That means a new PR?

Probably best to reset the branch to main and manually creating a new commit with all the required changes.

That means a new PR?

@daemon1024

All the previous comments are unresolved again ^^ Please redo them.

@daemon1024 Please review it, as I think our documentation is lagging, it will be very overwhelming for the new contributors to test their changes for operator or controller. Would be happy for new suggestions as I am working on it after a long time!


fix(textwidget): Fix the TextWidget

Part of the API of the widgets has changed in vtk.js making the widget crash.

Fixes #456

LGTM

LGTM!


Redis client [issue #143]

Draft of a redis client. I have been running it locally using docker.
/assign @xuanyang-cn

Hi @s-gruneberg Thanks for contribution!! BTW, can I ask is this for Redis Cloud or Redis opensource?

/assign

@liliu-z this is for redis open source, it is similar to the pgVector implementation where it takes a connection string. To my knowledge it should work with redis cloud if the connection to the cloud database is set up. It might take some slight tweaking.

I realized that my filter search is not working properly, closing this PR until I fix it.

@s-gruneberg any update on this?

Yes, all unit tests are passing and filter search is working. As far as I can tell it's good to go.
Let me know if you have any questions or need me to modify anything / fix errors!

Sure, let test this a little bit and get back to you! Plz know that this may take some time due to the lack of human power.

It would be better if you could squish all of these changes together into one single commit. This will make it easier to track changes and maintain a more organized version history

LGTM
@s-gruneberg Seems this PR has some conflicts with the chroma client one, could you resolve the conflicts?

@s-gruneberg Please squish the two commits together into one single commit. It cannot be auto rebased so unable to merge.

@XuanYang-cn
I'm having some trouble squashing it:
Github is flagging my squashed commit as having a merge conflict when as far as I can tell there is no conflict. Resolving conflict (on github) gives me an additional commit titled "Merge branch main..." with no differences from previous commit.
I'm not sure how to fix this on my end because i'm going in circles. If I "resolve" merges on github it makes two commits. If I squash those commits to one (current state) github says there are merge conflicts.
Is it possible to squash on PR merge? If so I can 'resolve' the conflicts and end up with two commits again.

@XuanYang-cn
Figured it out! Thanks for your patience!


[WIP] add test coverage for integration test

Ⅰ. Describe what this PR did
Add integration test coverage according to this article : https://www.cyphar.com/blog/post/20170412-golang-integration-coverage
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

It could not be better to add integration test coverage!

FAIL: /go/src/github.com/alibaba/pouch/test/api_system_test.go:32: APISystemSuite.TestInfo
/go/src/github.com/alibaba/pouch/test/api_system_test.go:56:
    // Check the volume drivers
    c.Assert(len(got.VolumeDrivers), check.Equals, 3)
... obtained int = 4
... expected int = 3

LGTM
I think that next step we can refactor the hack/build shell script 😄
Thank you @Letty5411


Enable TLS authentication for connections

Configuration of TLS is now (optionally) supported using new parameters which define the path to find certificate files required.
TLS_VERIFY_PEER is true for default security, however, like SSL_VERIFY this is configurable.
I have tested manually, and began writing a test suite for the plugin, but hit enough walls to leave that for now.
Known issues

If the TLS configuration is defined, but the backend refuses connection the plugin still starts and only reports an error on shutdown - don't know why - any suggestions?
I don't check if the file defined for the keys exists, but Bunny will throw errors anyway

Test Examples
No TLS enabled
starts without issue
TLS enabled - but missing required parameters
<source>
  type amqp
  host rmq.example.com
  port 5671

  vhost /
  queue test
  user guest
  pass guest

  format json

  tls true
</source>

...

2016-04-01 13:51:20 +0000 [error]: fluent/supervisor.rb:309:rescue in main_process: config error file="10-amqp-source.conf" error="'tls_key' and 'tls_cert' must be all specified if tls is enabled."

TLS Configured and operational

Starts without issue*

TLS Configured but file missing
2016-04-01 13:58:57 +0000 [error]: fluent/supervisor.rb:318:rescue in main_process: unexpected error error="Neither PUB key nor PRIV key: not enough data"

TLS Configured but not authenticated
Hangs and does nothing, but on shutdown reports;
2016-04-01 13:57:22 +0000 [warn]: fluent/root_agent.rb:123:rescue in block (2 levels) in shutdown: unexpected error while shutting down input plugin plugin=Fluent::AMQPInput plugin_id="object:a0bd4c" error_class=OpenSSL::SSL::SSLError error=#<OpenSSL::SSL::SSLError: SSL_write: certificate verify failed>

I've reviewed and write some comment, check please.
And, we have to add config_param about tls to lib/fluent/plugin/out_amqp.rb too?

I've been implementing formal tests for this code. I'll add them to this branch for review.
I noticed that the 'host and exchange must be defined' error will only fail if host isn't set, as the exchange gets a default value of empty string. I've updated that check accordingly.

Please review my changes, and observe that the travis CI tests are passing using new tests I've implemented to check the configuration, but have also mocked out the Bunny connection to enable more advanced testing.
Currently I only use the mock to ensure the queue and exchanges are created (no checking of vhost, durability, etc)
10 tests, 23 assertions, 0 failures, 0 errors, 1 pendings, 0 omissions, 0 notifications

Added some code coverage reporting;
Coverage report generated for Unit Tests to ~/workspace/fluent-plugin-amqp/coverage. 159 / 201 LOC (79.1%) covered.

Great work!  looks good to me.
Once, I'll merge into master.


Test docker container

Description
Creates a dockerized hardhat blockchain node using DockerFile and docker-compose. This is for setting up a test environment in which these test will read and write to a local blockchain node.
Notes

Issue (if applicable)
n/a
Testing

Screenshots (if applicable)

What about this?
// package.json
"scripts": {
  "docker:launch": "docker compose --env-file ./env.local"
}

//.docker-compose.yml
environment:
  - REACT_APP_ALCHEMY_API_KEY

This is technically already a variable used by the react app

🚀


Cannot quit / exit without killing the process

Hi, so I am running cargo watch -x test to run unit tests for exercises I downloaded on exercism.io. It works fine, but I can't quit using Ctrl-C. The only way I can stop it is killing the process eg. pkill cargo-watch.
Is this by design, or is this a bug?
› cargo-watch --version
cargo-watch 7.8.0

› cargo --version
cargo 1.52.0 (69767412a 2021-04-21)

› uname -a
Linux manjaro 5.10.34-1-MANJARO #1 SMP Sun May 2 11:29:56 UTC 2021 x86_64 GNU/Linux

That's a bug.
Can you try sending SIGINT with pkill?
Also can you show how you're running cargo watch, and a debug log

Hi @passcod,
Thanks for the reply, I appreciate it.
So I tested › pkill --signal SIGINT cargo-watch and it did work, so that lead me into thinking that the problem doesn't lie in cargo-watch. Then I closed and reopened Konsole. That solved the problem; Ctrl-C works again as expected. So it was a borked terminal.
I'm planning to use cargo-watch in the upcoming weeks, I'll keep an eye if the problem comes up again. And if it does, I'll do a further investigation to reproduce it.
For now, I'm closing this ticket. Will reopen if I have more actionable information.


Update version of setup-node in GitHub actions

As part of upgrading the repo node version, we should update and unify our GitHub action setups.
https://github.com/marketplace/actions/setup-node-js-environment

Fixed in #8360.


Rewrite of 29 Craps in C#

A C# version of Craps. Man, that was a lot of spaghetti to untangle.

Oops, not  everything was committed.


Add support for videos

Hard limit on video size (<=5MB?)
Not sure if it would need an intermediary transformation before it can be converted to webp but definitely worth looking up

Knock on wood this doesn't have too many issues. Fixed by commit


ssl.SSLError flooding logs

I just added SSL/TLS support to my websocket implementation, and upon testing it I get ssl.SSLError's such as the following:
ssl.SSLError: [SSL: WRONG_VERSION_NUMBER]
ssl.SSLError: [SSL: UNKNOWN_PROTOCOL]
ssl.SSLError: [SSL: NO_SHARED_CIPHER]
Trying to add an 'except ssl.SSLError' does not seem to work. Is there a way to turn the errors off?
I understand this is with the underlying SSL library, however I have a strict configuration for SSL/TLS and I don't want to see these messages for clients of which I don't support of which I am testing with testssl.sh.
EDIT: Probably should post an example traceback :D
SSL error in data received
protocol: <asyncio.sslproto.SSLProtocol object at 0x61dae08788d0>
transport: <_SelectorSocketTransport closing fd=10 read=idle write=<idle, bufsize=0>>
Traceback (most recent call last):
  File "/usr/lib/python3.7/asyncio/sslproto.py", line 526, in data_received
    ssldata, appdata = self._sslpipe.feed_ssldata(data)
  File "/usr/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
    self._sslobj.do_handshake()
  File "/usr/lib/python3.7/ssl.py", line 763, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLError: [SSL: UNSUPPORTED_PROTOCOL] unsupported protocol (_ssl.c:1056)

This StackOverflow question (in the context of aiohttp, not websockets, but it's the same issue) has a pretty good answer:
https://stackoverflow.com/questions/52012488/ssl-asyncio-traceback-even-when-error-is-handled
Unfortunately, the ticket in the Python bug tracker hasn't gotten much attention:
https://bugs.python.org/issue34506

One thing I'm not sure about is whether the logging is triggered from websockets or from asyncio. Would you be able to configure logging in your application to display the name of the logger?
If it's a websockets.<something> logger, then I can do something about it.

The error is raised via the asyncio logging channel.
@Verequies depending on what kind of logging module you use, you can filter the log message. This is what we have done to work around #606 (happens a lot in production but never locally).

Closing in favor of https://bugs.python.org/issue34506.

Hi Guys,
I got around this by creating a custom exception_handler.  Just posting in case others can use this.
def exception_handler(loop, context):
exception = context['exception']
if isinstance(exception, SSLError):
    pass
else:
    raise exception

loop.set_exception_handler(exception_handler)


modified some strings in test.js

I believe I have learned a few things about PR and I think this one might just work.

LGTM! (looks good to me)


Create ShellSortExample.swift

Checklist

[x] I've looked at the contribution guidelines.
[x] This pull request is complete and ready for review.

Description

This is a fairly self explanatory and tiny change.
Inner while loop within this shell sort example was slightly incorrect - for example try array [64, 20, 50, 33, 72, 10, 23, -1, 4,-2,-3] with previous version.
Fixed by changing while loop conditions.

Cheers!


User Group live areas too large

I run a site with multiple nested user groups and have to select certain groups for users to be in that exist within a nested group.
When I go to click on the little + button next to a group to expand it, I find myself often accidentally misclicking just outside of the box (but not on the group itself), and even though the area looks like it shouldn't be live (the text of the group does not highlight or do anything to indicate this area will select anything), it will select an incorrect group, thus automatically joining that user to that group (and thereby kicking me out of the group selection dialogue box and I have to start all over again).
I feel the expected behaviour should be to not select anything, thereby avoiding the misclick and the frustration of starting all over again.
To replicate:

Make a group.
Make a second group with the first group as the parent.
Make a third group with the second group as the parent.
Create a new user.
Try to add the user to a group
Open the first + of the first group.
Click just slightly off of the second + for the second group
The user will be added to either the first group or the second group despite no text being highlighted to signify the area is live.

Another thought for a potential solution would be a "Confirm" button before the group is confirmed to be entered. I think this may be an easier solution.

This experience is different and therefore should be resolved in version 9.


Web API Support

Hi.
I know this is not a bug, but here it goes:
Can this be used with a simple web API? I don't see it in the documentation.
As far as i can tell, it only works with Messenger, Skype, Telegram and Slack. Is there  way that can be used with a web API?
Also how could i use it with Serverless instead of Claudia? The main problem is that i can't do any real testing without lambda servers.
Thanks.

please use the gitter channel (https://gitter.im/claudiajs/claudia) for general questions. we use github issues only for bug reports


Cluster support for AQL queries

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[X] 3.1
[ ] self-compiled devel branch

Hi,
I just checkout ArangoDb and did some tests with basic scenarios. After some reading the docs I found this:

In a cluster, AQL data-modification queries are currently not executed transactionally. Additionally, update, replace, upsert and remove AQL queries currently require the _key attribute to be specified for all documents that should be modified or removed, even if a shared key attribute other than _key was chosen for the collection. This restriction may be overcome in a future release of ArangoDB.
Reference

This means as soon as I want to switch to clustering I can't expect transactional execution of my AQL queries? AQL is described as the "One SQL-like Query Language for all Data Models" this restriction prevent me to see Arangodb as the right tool when scalability counts. When are you planning to cover his feature? Thank you!

Sorry, but I don't get your point. What is the connection between SQL and full ACID transactions in a clustered environment?

Perhaps I understand your statement wrong about the restriction. Can you explain what's the impact of this limitation as an arangodb user when I use clustering?

ArangoDB supports full ACID multi collections transaction for a single instance and full ACID single documents transactions for a cluster for the moment. But it would be helpful if you could explain the connection you made between SQL, cluster and transactions.

Please imagine following situation:
I have a big dataset which is sharded over 3 arangodb instances worldwide.
(1) DE, (2) USA, (3) TR
Every country has two collections:

users
partners

Query:
FOR u IN users
    FILTER u.name== "peter"
    UPDATE u WITH { sponsor: "klaus" } IN partners
    LET result= MYFUNCTION()
RETURN NEW

Process
DE -(update 'partner' document)-> USA
                                   ^--(read 'partner' document)- TR

According to the documentation there is no ACID support for AQL data-modification queries across multiple instances right?
//The update operation will fail because MYFUNCTION

DE -(update 'partner' document)-> USA
                                   ^--(read 'partner' document)- TR

Is it correct that no rollback happens and TR see wrong data?

Related https://github.com/arangodb/arangodb/issues/2019

I see that's already in the roadmap, cool!

Distributed Transaction
Transactions in a distributed environment with a transaction manager.

Yes, that's why I wrote at the moment.
Sorry, but I don't get your connection between SQL cluster, and transactions. I would appreciate if you could explain it a little bit more in detail.

There is no connection my title is wrong. This answered my questions. Thanks! https://docs.arangodb.com/3.0/Manual/Transactions/Limitations.html

You are welcome!