Repo report order stability

What: Fixes #850 .

Why: Order of listing directory files is not guaranteed; in fact differences have been observed, causing test failures.

How: Enforce order stability (ascending as it is intuitive)

Checklist:

[ ] Documentation added to the README.md OR link to PR on https://github.com/specmatic/specmatic-documentation
[ X ] Tests
[ ] Sonar Quality Gate

Issue ID:
Closes: #850

Thanks @westse, we too just encountered this issue, and do appreciate the PR!

Thanks @westse


Changes in swagger description leads to failing az apim api import command

Describe the bug
I'm trying to import an API Definition into API Management using the following command:
az apim api import --resource-group $(ApimResourceGroup) --service-name $(ApimName) --specification-format OpenApiJson --api-revision $(Revision) --api-version v1 --api-id $(ApimApiId) --api-version-set-id $(ApimApiId) --specification-url $(ApiSpecificationUrl) --service-url $(ApiUrl) --path $(ApimPath) --subscription-required false --description '$(ApiDisplayName)'
This works great the first time, but on subsequent attempts we get the error:
Can't change property Description for non-current revision
The reason for this error seems to be that this commands uses the Swagger description field.
Which in our case changes for every release, and using this command does not let us do that.
It is also not possible to override the Description field using the --description parameter.
Expected behavior
You should be able to override Description when given as an argument in order not to generate this error.
Imho. you should also be able to change description between imports without generating an error.
As it stands we are unable to deploy new versions of the API when we have changed description of the API in swagger.
Environment summary
The script is run as part of an Azure CLI task in Azure DevOps release pipeline, using Azure CLI version 2.27.1.

route to service team

Same issue. Is there a workapround (except deleting / recreating)

@abragsta @owingruters Apologies for the late reply. We are looking into this issue. We will provide an update once we have more details on this.
@adrianhall Could you please look into this ask once you get a chance ? Awaiting your reply.

This is "by design".  There are several fields in the OpenAPI specification that cannot be updated unless you are changing the current API revision.  For details, please see https://docs.microsoft.com/en-us/azure/api-management/edit-api#update-the-swagger
#please-close


Implement iOS keyboard track pad selection for TextField widget

Use case
On iOS system fields and in natively developed iOS applications, one can press and hold the space bar to go into trackpad mode, then put another finger on the trackpad to be able to select specific texts (this is the replacement of 3D touch selection)
With Flutter, the keyboard only transforms in the trackpad to move the cursor, but it is not possible to also select text.
Proposal
Flutter should be able to select text in a textfield in trackpad mode, as demonstrated in the sample video below:
https://user-images.githubusercontent.com/8842565/179538899-b6af75dd-fe72-4fed-ae26-b938ea8ae222.MP4
Additional information
More detailed descriptions on the usage in iOS can be found online, for example here.

Probably related to: https://github.com/flutter/flutter/issues/89228

Probably related to: #89228

Seems similar, but the linked issue is about moving the cursor in a scrolling field and this issue is specifically about selecting using the iOS keyboard in trackpad mode.


Make the Audio inheritable from the discord.player.AudioSource

Implement the AudioSource functionality instead of the wrapper class

Instead of AudioSource, I used PCMVolumeTransformer. Inherited from PCMVolumeTransformer and made its own implementation


Receive and Send screen: currency selection

Please work only on points mentioned in this task. Design for Send and receive screens will be changed later in another task.
1)Dropdown coin's list on receive screen. https://zpl.io/bleZxPP

Arrow position when list is closed

2.1) Arrow position when list is open

Same flow for Send screen https://zpl.io/a7p5M3W

If we click arrow near "BEAM" then instead of a drop-down coin's list opened new window with available coins

Checked


Flow dashboard logs through the app host's logger

Subscribe to logs from the dashboard resources and print them to the console.

Fixes https://github.com/dotnet/aspire/issues/2911
This pull request primarily focuses on enhancing the DashboardLifecycleHook class in the src/Aspire.Hosting/Dashboard/DashboardLifecycleHook.cs file. The changes include the addition of new dependencies, the implementation of the IAsyncDisposable interface, and the introduction of a method to watch and handle dashboard logs. Additionally, there are modifications to the DistributedApplicationBuilder class and updates to the unit tests to accommodate these changes.
Key changes include:
Addition of new dependencies:

src/Aspire.Hosting/Dashboard/DashboardLifecycleHook.cs: New dependencies were added to the DashboardLifecycleHook class, including ResourceNotificationService, ResourceLoggerService, and ILoggerFactory. This change allows the class to handle resource notifications and logs, and to create loggers.

Implementation of the IAsyncDisposable interface:

src/Aspire.Hosting/Dashboard/DashboardLifecycleHook.cs: The DashboardLifecycleHook class now implements the IAsyncDisposable interface, which provides a mechanism for releasing unmanaged resources asynchronously. A new DisposeAsync method was added to handle the disposal of resources.

Introduction of a method to watch and handle dashboard logs:

src/Aspire.Hosting/Dashboard/DashboardLifecycleHook.cs: A new method, WatchDashboardLogsAsync, was introduced to watch and handle dashboard logs. This method includes logic to parse and log JSON formatted log lines.

Updates to the DistributedApplicationBuilder class:

src/Aspire.Hosting/DistributedApplicationBuilder.cs: An additional filter was added to the DistributedApplicationBuilder class to handle logging for the Aspire.Hosting.Dashboard.

Updates to unit tests:

tests/Aspire.Hosting.Tests/Dashboard/DashboardResourceTests.cs: Unit tests were updated to accommodate the changes in the DashboardLifecycleHook class and the DistributedApplicationBuilder class. This includes the addition of a new test, DashboardLifecycleHookWatchesWarningLogs, to verify the new log watching functionality. [1] [2] [3]

Microsoft Reviewers: Open in CodeFlow

Don't forgot to add tests.

This needs to show no logs by default. I'll make that change so that it's config enabled.


Use graphql-playground

Description
This PR adds the graphql-playground UI to the rendered HTML GraphiQL response from /graphql. It also adds a handy link from the DevTools component.
https://user-images.githubusercontent.com/462077/174936767-0828fd86-3634-4a82-9750-cc5741f6e781.mov
Additional context
This component is fairly customisable and styleable. The types in this file provide the best documentation I could find for what is possible.
Before submitting the PR, please make sure you do the following:

[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[x] Update docs in this repository according to your change
[x] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

We should redirect the routes to just graphql instead of maintaining them.
I'm happy and excited to move forward with this now that the future of it isn't up in the air anymore. It's a much better UX than GraphiQL.


Double wide nerd font glyphs are redenred properly with latest preview version

Windows Terminal version
1.21.1272.0
Windows build number
10.0.22631
Other Software
No response
Steps to reproduce
Use UbuntuMono Nerd Font and configure some double wide character in status bar or print them in terminal
Issue seen with Latest Windows Terminal Preview version:  1.21.1272.0
Expected Behavior
Double wide fonts should be rendered properly like below
In Windows Terminal version: 1.19.11213.0  (Atlas Engine is enabled)

Actual Behavior
In Windows Terminal Preview version: 1.21.1272.0
With Graphics API: Direct3D 11 (Same result wtih Graphics API: Automatic) - some fonts are good but some are not

With Graphics API: Direct2D. The result is better but not same as 1.19.11213.0

In full screen mode, it get a bit worse

Huh, weird. I thought those triangle glyphs were narrow (1 cell wide)? I just installed the latest version of Ubuntu Mono NF (version 0.80) and U+E0B8, U+E0BA, U+E0BC, and U+E0BE are all narrow for me.
Can you figure out what codepoints your status line uses, or otherwise give me a printf command (or similar) that allows me to reproduce the issue locally?

I'm using an earlier verion of Ubuntu Mono NF which i downloaded from https://github.com/ryanoasis/nerd-fonts/blob/master/patched-fonts/UbuntuMono/Regular/UbuntuMonoNerdFont-Regular.ttf
This version has those characters(U+E0B8, U+E0BA, U+E0BC, and U+E0BE) to be double wide.
Sometime down the line (around year back i believe), they (ryanoasis/nerd-fonts) updated those characters to be narrow. So the latest version still have them as narrow.
I kept the older version of font file. Here it is. If you want to try this, you may want to remove the already installed one.
UbuntuMono Nerd Font.zip

There's a couple ways I could see us taking this:

This is by-design, the PL glyphs are supposed to be single-wide now, and the terminal is correctly rendering them as such. Users can always opt-out of the Terminal doing this with "font.builtinGlyphs": false...
... though, with "font.builtinGlyphs": false, we still should probably render these a little better
alternatively, I'm not sure if we can check the font ahead of time, and manually scale our PL drawing to the same width the font expects them to be

Users can always opt-out of the Terminal doing this with "font.builtinGlyphs": false...

FYI you can also find the setting here:

I think we should consider closing this as "by design" for the following reasons:

Newer version of NF have these glyphs as narrow.
Adjusting the width of builtin glyphs to match the font would break their biggest strength of being fully "gap-less".
Adjusting the size of font glyphs in the past has repeatedly proven itself to be very error prone. Adjusting the vertical/horizontal alignment is less bad, but still somewhat error prone. It should be reserved to situations where there aren't any alternatives.

@SivanagBalla Is there a reason why you don't want to use a newer Ubuntu Mono NF version?

I liked the older double wide verison of these characters and so i kept it.
Anyway, turning off Builtin Glyphs worked. This is good enough for me.  But does this option have any other side effects?

No, it simply disables these builtin glyphs:

The benefit of them being builtin is that they're "pixel perfect", unlike the corresponding glyphs in a font.

Yea I second closing by design. If disabling the builtin glyphs works for you, that's probably the best we'll be able to do in the general case.
Thanks for following up! TIL that there was a version of NF where those glyphs were double-wide


Build updates and try to get older IE back

tears of joy, rage, and sadness
I made the mistake of trying something using edge out on IE8. After a good bit of cursing, wailing, gnashing of teeth, and desk-to-face interaction, I've arrived at a build file that, while terribly slow, will get to the point that tests run and even mostly pass in IE8 (~500 failures, but hey, something runs). I've not yet had the strength to look at other versions.
I hope to address most of the open IE issues in this PR - and get the build back down well below 45 seconds, but for now I have to go take a shower and not look at Windows again for a day or three.

holy shit nice work. the babel/rollup update is good for something too. :+1:

Well, by rolling all of the various test files into one during the build, the build time drops back down to around 30 seconds, which is still a bit excessive. The test page does load a bit faster though.
Once again, Travis has decided to take his ball and go home, but I promise that an npm run build completes successfully :smile:

I never did come up with a way to get build times back down from orbit. The Babel 6 docs are a bit sparse (or I'm just not good at finding them), but I think if there was a way to run it without adding all of the helpers to every file then it could be run in a cache-friendly way to at least cut the rebuild time down to something more reasonable. I tried a handful of things, but they either didn't produce viable builds or took just as much time to complete :cry:.

I wanted to merge this to prevent more merge conflicts, but I'm definitely going to take a look if we can't make it faster.


Implement wasm-rdbms interface for standardized database access

WASM RDBMS
WASM components do not have access to databases natively. Rather, they must obtain all functionality from their host, through the component model types.
Although there exists a wasi-sql project, which intends to provide a WASI standard for database access, it is still in its infancy and shows no signs of active development.
Rather than await the completion of wasi-sql, WASM startup Fermyon introduced a series of WIT interfaces postgres, sqlite, and mysql in their WASM-native framework Spin, which use a related series of database types. These interfaces are supported by the Spin host environment.
It is not clear if Fermyon’s interfaces will become standard or not, or if work will be resumed on the earlier (but far less complete) wasi-sql. Rather than wait for the lengthy process of standardization to produce something useful, Golem needs to support some level of database access now, so that developers using databases have options.
This specification calls for the development of a new wasm-rdbms interface, which is designed to support features common to mainstream databases, as well as a corresponding set of implementations in Golem, powered by a low-level Rust library.

💡
Currently, this design only facilitates connection with existing databases, rather than supporting the newer paradigm of provisioning databases based on their demonstrated usage inside the code. However, as connecting to existing databases is something that needs to be supported regardless, it makes sense to first start with this feature.

Overview
The basic approach of this language-agnostic interface to databases is to have a generalized core upon which all specific database interfaces can depend.
This allows new databases to be introduced cheaply, while still respecting the fact that developers must necessarily program against specific databases, due to differences in column types, SQL syntax, and other features.
Common Elements
Common elements belong to the same generic package and have generic interface names.
They include the following, as well as related supporting types:

Column Types. The types possible for a column. This is a superset of the possible types for any given database.
Columns. The combination of a column type, with a name, and column-specific flags, such as whether or not the column is nullable, unique, auto-generated, etc.
Value. A value is a value of some column type.
Row. A row is a collection of values.
Statement. A statement has SQL (text) as well as variables and values for those variables (prepared statement).
Result Set. A result set is the result of executing a query. It may be iterated over.

Unique Elements
Unique elements belong to database-specific packages, with database-specific interface names. They represent aspects of a database interface that benefit from tying to one specific database.

Connection. A connection may be opened, with a database-specific connection information; connections allow both query (which return result set) and execution (which returns integer).

WIT Sketch
Common Elements
Something like the following should work for most databases (other than SQLite):
type node-index = u32;
type table-name = string;

/// Node in the db-data-type structure
variant db-column-type-primitive{
    integer(option<u8>),
    decimal(u8, u8),
    float,
    boolean,
    datetime,
    interval,
    string(option<u32>),
    text,
    binary(option<u32>),
    blob,
    enum(list<string>),
    json,
    xml,
    uuid,
    spatial,
}

variant db-column-type {
    primitive(db-column-type-primitive),
    array(list<option<u32>>, db-column-type),
}

flags db-column-type-flags {
    // Key constraints
    primary-key,     // Single or part of composite primary key
    foreign-key,     // References another table's key
    unique,          // Unique constraint

    // Core properties
    nullable,        // If not present, column is NOT NULL
    generated,       // Value is computed rather than stored directly
    auto-increment,  // MySQL AUTO_INCREMENT/PostgreSQL SERIAL/SQL Server IDENTITY

    // Common behaviors
    default-value,   // Has a default value defined
    indexed,         // Participates in an index
}

/// Data types for database columns
record db-column-type-meta {
    db-type:     db-column-type,
    name:        string,
    flags:       db-column-type-flags,
    foreign-key: option<table-name>,
}

/// Value descriptor for a single database value
variant db-value-primitive {
    integer(s64),
    decimal(string),
    float(float64),
    boolean(bool),
    datetime(u64),
    interval(u64),
    string(string),
    text(string),
    binary(list<u8>),
    blob(list<u8>),
    enum(u32),
    json(string),
    xml(string),
    uuid(u128),
    spatial(list<float64>),
    other(string, list<u8>),
    db-null,
}

variant db-value {
    primitive(db-value-primitive),
    array(list<db-value-primitive>), // Flatteneed
}

/// A single row of values
record db-row {
    values: list<db-value>,
}

/// A potentially very large and lazy stream of rows:
resource db-result-set {
    get-column-metadata: func() -> list<db-column-type-meta>;
    get-next: func() -> option<list<db-row>>;
}

Unique Elements
Something like the following should work for databases that are not SQLite:
interface postgres {
  resource db-connection {
    open: static func(address: string) -> result<db-connection, error>;

    query: func(statement: string, params: list<db-value>) -> result<db-result-set, error>;

    execute: func(statement: string, params: list<db-value>) -> result<u64, error>;
  }
}

interface mysql {
  resource db-connection {
    open: static func(address: string) -> result<db-connection, error>;

    query: func(statement: string, params: list<db-value>) -> result<db-result-set, error>;

    execute: func(statement: string, params: list<db-value>) -> result<u64, error>;
  }
}

SQLite will require its own interface, perhaps inspired by the one in Spin.
Host Implementation
The host implementation will live in the worker-executor service and will use best-in-class async Rust libraries to provide implementations of the specified interfaces.
One slight complication is that a connection in the guest must not map to a connection in the host. The reason for this is that on a single worker-executor node, there may exist thousands of workers, and these workers should not maintain their own independent connections to the database.
Therefore, in order to improve performance, it is necessary to perform connection pooling in the host, so that if only 20 concurrent connections are needed across all workers, then only 20 concurrent connections are created and maintained.
Note that if the wasm-rdbms interface improves in power to allow interleaving database updates with side-effects as part of a single database transaction, then pooling becomes much more difficult. However, with the current interface, the only two things a worker can do with a connection are query and execute, which atomically return results; and if those results are small enough to fit in memory, then there is no need to keep an underlying connection dedicated to the worker (instead, it can be reused for another worker).

/bounty $5000

/attempt #1016

The host implementation will live in the worker-executor service

I am assuming you mean golem-worker-executor-base directory because golem-worker-executor simply starts up the server with all the services defined in the former directory
and will the .wit files reside in this repo  https://github.com/golemcloud/golem-wit/blob/main/wit  ?

@palash25 Please don't work on this one, it's already taken. I will have new bounties up soon.

hey @justcoon are you working on it ?

hi @debaa98 , yes I am working on it

@palash25 Please don't work on this one, it's already taken. I will have new bounties up soon.

only one person can attempt it at the same time?

@volfcan Yes, please! But be on the look out for many more bounties in the next 2 months.

hey @justcoon it seems quite inactive so will i take the issue ?

hey @justcoon it seems quite inactive so will i take the issue ?

I believe @justcoon is still working on this, and will open PRs once he is done.

Hi, @debaa98 , I am actively working on that issue


Bug fix/database initial syncer needs patience at times

Scope & Purpose
Initial database sync has more robust estimate of timeout for leader keys:

Leader API has new quick option to return #docs if > 1 mio docs
Follower side does a first quick call. If keys received => proceed as before, if count recalculate longer timeout repeat call without quick option

[X] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[X] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Backports:

[ ] No backports required
[x] Backports required for: 3.7 : https://github.com/arangodb/arangodb/pull/13359

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket number:
[ ] Design document:

Testing & Verification
(Please pick either of the following options)

[ ] This change is a trivial rework / code cleanup without any test coverage.
[X] The behavior in this PR was manually tested
[X] This change is already covered by existing tests, such as (please describe tests).
[ ] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[ ] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

Link to Jenkins PR run:
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/13626/
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/13631/
Documentation

All new features should be accompanied by corresponding documentation.
Bugs and features should furthermore be documented in the CHANGELOG so that
support, end users, and other developers have a concise overview.

[ ] Added entry to Release Notes
[ ] Added a new section in the Manual
[ ] Added a new section in the HTTP API
[ ] Added Swagger examples for the HTTP API
[ ] Updated license information in LICENSES-OTHER-COMPONENTS.md for 3rd party libraries

External contributors / CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/14035/


Feature: Dokku integration

For those not familiar with Dokku according to their website Dokku is

The smallest PaaS implementation you've ever seen

and from their Github description

A docker-powered PaaS that helps you build and manage the lifecycle of
applications http://dokku.viewdocs.io/dokku/

I use it because it provides a simple deployment option for web applications.
Shortly summarized you deal with Git and Docker no extra things unless you want.
I am using Dokku on 2nft.alemayhu.com and would like to use Cilium there. I also
have some other web apps where I would like to use Dokku + Cilium but
official support would be nice vs random hacks to get it to play nice together.
After thinking about it a good integration could look something like

User installs plugin dokku plugin:install https://github.com/cilium/dokku-cilium.git cilium
User creates a Cilium directory in their project with the policies to be
loaded.
User pushes to Dokku where if the Cilium directory is detected the plugin runs.
The plugin checks if user has the Cilium agent running on the machine.  If
the agent is missing it gets installed and / or started.
The plugin asks Cilium agent to perform validation and then loads the policy if
all is okay.

I don't know if the above suggestion will work with the Dokku plugins system,
but from eye balling the documentation below I don't see why it shouldn't be
feasible.

Plugins
Plugin Creation

Sounds great! Would love to see this.

Maybe this can somehow be tied into the Policy Repository, the git tree part seems relevant

Use of a git tree to maintain the policy in combination with a post-merge hook which automatically imports the policy. (TODO: Write & link to guide)


Bugfix start button missing underline on hover

Description

Bugfix Start button missing underline on hover behavior on forestry form
Add missing data-test attributes to start button
Enable forestrysectoropscreening card on form list

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-136


feat: Add RMC to slots feed.

Description of change
Closes #1064
Type of change

Enhancement (a non-breaking change which adds functionality)

How the change has been tested
Change checklist
Add an x to the boxes that are relevant to your changes, and delete any items that are not.

[] My code follows the contribution guidelines for this project
[] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes

Superseeded by https://github.com/iotaledger/explorer/pull/1182


.NET Core project files

Does the information in Additions to the csproj format for .NET Core applies to vbproj and fsproj as well?
If yes, then the article needs to be updated and mention that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb4428fc-215c-78e1-5ff0-fe73f7a08260
Version Independent ID: 6741b1de-38a4-fbb1-d79d-acc47d549a2d
Content: Additions to the csproj format for .NET Core - .NET Core CLI
Content Source: docs/core/tools/csproj.md
Product: dotnet-core
Technology: dotnet-cli
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

cc @gewarren, you're going to be replacing this article, right?

Yes, see #18198.


⚠ Bofrost.at has degraded performance

In 9cfe88d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2272 ms

Resolved: Bofrost.at performance has improved in 2fdd7fb.


BUG: Fix type conversion in for AttrVar Union types

@epatters I updated one of the tests to test this. I also verified that with the test updates the tests fail on the current master branch


<EMAIL_ADDRESS>Help wanted!!!

We did upgrade the webpack version to 2.2.1 due to some vulnerability checks and facing issues.

@ramyavakity Please provide more details about the issue you're facing.

Hey Kishore,
I did upgrade webpack version and see some random errors in the terminal.
Please help me figure out this.


add lesson 1

creat lesson 1

Ok, I will accept it, You will have your folder.
Just add your files at any time.


[feature] Accumulator response builder

The current response builders don't offer a way to accumulate new responses from each chunk of text. Refine, for example, is meant for iterating over chunks and modifying the answer with each iteration until you end up with 1 answer. Being able to accumulate responses allows people (like me) to use a prompt like "Summarize this text" and generate multiple summaries, 1 for each chunk.
Example:
query_engine = RetrieverQueryEngine.from_args(
    retriever=retriever,
    service_context=service_context,
    node_postprocessors=[
        SimilarityPostprocessor(similarity_cutoff=0.7)
    ],
    text_qa_template=QA_PROMPT,
    response_mode='accumulate'
)

NOTE: This response builder does not work for streaming (and will fail with an error saying so if you try). In order to get streaming working, I think we'd have to make it possible for get_response to return an array of generators which would probably break other consumers? Happy to discuss solutions though.

Thanks for the review! I decided to make it easier to parse out each response by making the separator string an optional param. Take a look at the update and let me know what you think!

Alright I've made another fairly large refactor of this PR because of @Disiok 's request to allow async. I'm not totally sure if this is exactly what you had in mind, but this made the most sense to me as it allows users to use the use_async flag which already exists on the response_builder. Let me know what ya'll think!
cc: @logan-markewich

Looks great! Should work now. Going to merge this now!


[Task]  manager/controller/AppControllerTest.java

Description
Help us impl Unit Test For manager/src/test/java/com/usthe/manager/controller/AppControllerTest.java

You can learn and refer to the previous test cases impl.

controller example unit case:  https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/controller/AccountControllerTest.java
service example unit case:  https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/service/TagServiceTest.java
jpa sql dao example unit case: https://github.com/dromara/hertzbeat/blob/master/manager/src/test/java/com/usthe/manager/dao/MonitorDaoTest.java

Task List

[ ] Impl Unit Test For manager/src/test/java/com/usthe/manager/controller/AppControllerTest.java

尝试认领一下这个任务嘿嘿

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Try claiming this quest hehe


Add not null check to the return value of toX509Certificates in OpenSslX509KeyManagerFactory

Motivation:
The return value of io.netty.handler.ssl.SslContext.toX509Certificates() may be null, so the non-null check is required for the return value
Modification:
Should do the non-null check on the return value of io.netty.handler.ssl.SslContext.toX509Certificates() in SslContext and OpenSslX509KeyManagerFactory, thanks
Result:
Added a non-null check for the return value of io.netty.handler.ssl.SslContext.toX509Certificates()

@hyperxpro actually I think this is fine as otherwise it would also throw either NPE or something else once trying to use it.

@chrisvest WDYT ?

The OpenSslX509KeyManagerFactory changes look fine.


Wordpress - can't checkout

Please ask for the credential in the private chat.🙏

Nabeel have fixed an OTP but now have an issue with register form.
'Please enter a valid Email!', please investigate why users got this warning.
please use not >40min. if you use more than 40min please contact us.


feat: Mental shift from gen art tag to normal png tag

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Feature

Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10449

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Fixed, thanks

it is showing the symbol while is loading, and then it disappears:

base genart being labeled as non-genart:

https://deploy-preview-10455--koda-canary.netlify.app/base/collection/0x2cc76e51c4ae3ed7b0dcada34c1ea4fe059d5881

it is showing the symbol while is loading, and then it disappears:  could be because of loading slowness on my end

✅ Updated. I found a hack to fix it.

base genart being labeled as non-genart:
 https://deploy-preview-10455--koda-canary.netlify.app/base/collection/0x2cc76e51c4ae3ed7b0dcada34c1ea4fe059d5881

Even though on the canary env, the nfts are not identified as special tag. On Base network, they are all static images, not animations
https://canary.kodadot.xyz/base/collection/0x2cc76e51c4ae3ed7b0dcada34c1ea4fe059d5881

found some that are not showing the icon, can you check if the same happens for you?
https://deploy-preview-10455--koda-canary.netlify.app/ahp/collection/80
https://deploy-preview-10455--koda-canary.netlify.app/ahp/collection/129
in this one some load the icon and some not:
https://deploy-preview-10455--koda-canary.netlify.app/ahp/collection/78

found some that are not showing the icon, can you check if the same happens for you?
https://deploy-preview-10455--koda-canary.netlify.app/ahp/collection/80 https://deploy-preview-10455--koda-canary.netlify.app/ahp/collection/129
in this one some load the icon and some not: https://deploy-preview-10455--koda-canary.netlify.app/ahp/collection/78
i believe kodachain collections were showing the icon before and are not showing anymore

✅ Updated. They should be fixed.

@exezbcz should we show the jpeg icon on audio and video as well?

@exezbcz should we show the jpeg icon on audio and video as well?
deploy-preview-10455--koda-canary.netlify.app/ahp/collection/1

edge case, could be

@exezbcz should we show the jpeg icon on audio and video as well?
deploy-preview-10455--koda-canary.netlify.app/ahp/collection/1

edge case, could be

@Jarsen136

@exezbcz should we show the jpeg icon on audio and video as well?
deploy-preview-10455--koda-canary.netlify.app/ahp/collection/1

edge case, could be

@Jarsen136

It does show the icon after a while.

cc @hassnian


Monitor multiple wallets in different networks

Description
Currently, this service connects just to one RPC node (devnet, testnet or mainnet-beta endpoint) and it's able to track multiple solana wallets (addresses) balances.
It will be nice that this service is able to track multiple wallets in different networks (devnet, testnet and mainnet-beta).
Meanwhile, I will deploy two services, one per network (mainnet and testnet) and if I have time and it is really required I can make the code change to add support to configure a custom RPC node per wallet.

Hello! Unfortunately, we currently only monitor services on mainnet-beta and that is why support for multiple networks is missing. If you have time to make PR that adds support for that it would be welcome!


Core: settings icon is not shown in panel widgets

In property panel widgets there is no settings icon which makes it impossible to hide that specific widget.

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-14763

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-16023

Now you can hide each panel


Robustness test updates

Modifies the Kopia robustness tests to use the new persister implementation. Also contains minor updates to the test definitions.
Part 3 of 5:

#201 Implement Kopia API client
#202 Implement new persister
#203 Robustness test updates
#204 Add context to store interface
#205 Push robustness metadata without writing to fs

Codecov Report

Merging #203 (ebdc190) into robustness-persister (3d43c64) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           robustness-persister     #203      +/-   ##
========================================================
- Coverage                 62.79%   62.64%   -0.15%
========================================================
  Files                       348      334      -14
  Lines                     17377    16539     -838
========================================================
- Hits                      10912    10361     -551
+ Misses                     4982     4789     -193
+ Partials                   1483     1389      -94

Impacted Files
Coverage Δ

repo/content/content_manager.go
85.52% <0.00%> (ø)

internal/blobtesting/concurrent.go

internal/repotesting/repotesting.go

internal/mockfs/mockfs.go

internal/blobtesting/asserts.go

internal/blobtesting/verify.go

internal/blobtesting/map.go

internal/blobtesting/faulty.go

internal/testutil/testutil.go

internal/testutil/retriable_t.go

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d43c64...ebdc190. Read the comment docs.


[hw/csrng] Integrity protection for KV in CSRNG

This issue is to investigate integrity protection requirements for the DRBG internal state.

i think given that all the entropy blocks have passed D2S, this is probably relegated to future release.
Let me know if anyone objects.

I'm closing out some emails that have been languishing in my inbox...
I think this is fine to move to future release.  My only caveat would be if we plan to have any pre-tapeout FIPS review of the CSRNG, that feedback could force this forward.
@moidx do you remember what specifically triggered you to file this issue?  (Or just a general concern?)

@moidx / @cdgori / @tjaychen - slightly older issue here, but just checking if this should be in M2?
I'm tagging as M3 but if this was something that needed to go in please change it back.

Moving to backlog as this was set as future release.

Triaged for csrng, keeping https://github.com/lowRISC/opentitan/labels/Type%3AFutureRelease.

To be assessed for pentesting testplan.

TODO:

Check D2S review notes
Discuss with @johannheyszl

I've studied the D2S review notes. The option of adding integrity protection for key and v inside was raised in the D2S meeting and we wanted to check with labs if this is advisable. It was mentioned in the discussion that loosing a couple of bits in the input (i.e. before AES) can be argued to be not that bad. It was also mentioned that adding integrity protection could be exploited itself, e.g., via SCA.
@johannheyszl and I talked about this and we believe that if integrity protection was added key and v inside CSRNG, it should also be added to the ENTROPY_SRC output and especially the EDNs. This is assuming it wouldn't introduce any other vulnerabilities. The later down the pipeline the entropy is manipulated, the worse the problem becomes.
Adding comprehensive integrity protection to the entropy complex is a huge task. We believe this should only be done if we have clear evidence that it's actually required and it doesn't introduce other vulnerabilities. I am thus labeling this as FutureRelease and removing PROD labels.

Thanks @vogelpi, this sounds reasonable.

For completeness, the pentesting plan contains a test geared towards this issue.


Proposal: GraphQL Voyager plugin

I'm interested in creating GraphQL Voyager plug-in for GraphiQL.

@acao @IvanGoncharov @RomanHotsiy cc.

this is something @IvanGoncharov himself (one of the original voyager authors) proposed and is looking forward to! I'll let you know when the plugin proposal template is ready, busy with the plugin API proposal itself right now!

@acao Not sure that foundation should host plugins that wrap 3rd-party libraries/tools.
I think it should be hosted by projects themselves or by the community on external repos.

makes a lot of sense! i think we can host these discussions here for third party modules as a way to capture interest, since this is frequently requested, but most of the actual plugin proposals people are about to be making will be built/maintained elsewhere. does that make sense? even for third party plugins, best to keep all the proposals under one roof for now.

@acao Totally fine with proposals 👍  and thinking it's an excellent repo to collect them and think about them as use cases to design plugin API.

Here's the current GraphiQL structure:

So the plug-ins can only use the left side of GraphiQL?
Here's the GraphQL Voyager UI:

Is it possible to create plug-ins that (also) use the right side of GraphiQL?

As an idea, the GraphQL Voyager plug-in for GraphiQL could use the left side for docs (e.g. built-in GraphiQL Docs) and the right side for graph visualization.
If the user clicks on a type/field on the left side, the visualization focuses on that type/field, and vice versa.

Is it possible to create plug-ins that (also) use the right side of GraphiQL?

With the current plugin API this is not possible. However, you can render anything you want in the plugin component, for example you could add a "full-screen dialog" which would give you the most amount of screen possible which might make sense for this kind of plugin.

Also note that the plugin pane can be resized to take up the full width of the page:


bug: iOS: ion-slide elements will not render until a touch event happens

Bug Report
Ionic version:
[x] 4.9.0
Current behavior:
When using <ion-slides> within an Angular project, sometimes slide contents will not be rendered. Especially when they are composed out of more complex components and changing changing based on bound variables.
The component will not render itself until a touch event happens. Changes go undetected by Angular and there are also no events (mutation observer) fired by the Swiper API (if observers and observers for children are enabled).
Once I manually trigger a touch event, the components within <ion-slide> elements will properly render.
Expected behavior:
Slides, sub components and their children should always render.
Steps to reproduce:

Download the latest conference app as a base
Integrate Cordova and the ionic wkwebview plugin >= 4.0.1
Do an optimized prod (--prod) build
Integrate slides as below and wait for the render problems to happen (you may need to try a few times - thus I integrated everything into the schedule modal)

Related code:
  <ion-slides zoom="true">
    <ion-slide>

    </ion-slide>
    <ion-slide>

    </ion-slide>
    <ion-slide>

    </ion-slide>
  </ion-slides>

Other information:
This may be related to #19311
This does not happen with text only components, but with any images and SVGs.
This behaviour weirdly also extends to other components than  elements. We have a custom countdown timer which exposes the same behaviour (which may or may not be related to this - but if - it's likely some weird Angular problem?!)
Ionic info:
Ionic:

   Ionic CLI                     : 5.4.1 (/Users/Wilk/.nvm/versions/node/v10.16.3/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.9.1
   @angular-devkit/build-angular : 0.803.5
   @angular-devkit/schematics    : 8.3.5
   @angular/cli                  : 8.3.5
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 8.1.2<EMAIL_ADDRESS>   Cordova Platforms : ios 5.0.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.0.1, (and 5 other plugins)

Utility:

   cordova-res : 0.6.0
   native-run  : 0.2.8

System:

   Android SDK Tools : 25.2.2 (/Users/Wilk/Library/Android/sdk)
   ios-deploy        : 1.9.4
   ios-sim           : 8.0.2
   NodeJS            : v10.16.3 (/Users/Wilk/.nvm/versions/node/v10.16.3/bin/node)
   npm               : 6.9.0
   OS                : macOS Mojave
   Xcode             : Xcode 10.3 Build version 10G8

Same Problem

I have a similar problem. The element is in the correct position, but does not display properly

Also cannot reproduce in Ionic 5.x
@gitliyu and @omardoma, can you confirm?

Closing this issue, since it is resolved for me and there is no feedback from the mentioned users.


OS-level thread names confuse some tools

<nhardt> i noticed that for top and production of a core file, the logcabin process is coming out as evloop
<nhardt> i think it has to do with that call to set the thread name in main()
<diego> yeah, i think that's right
<diego> i wonder if an extra clone() in Server/Main.cc would fix that
<diego> i do like the thread names being known to the OS sometimes

cc @nhardt

I think spawning a new thread in main() fixes that, but reopen if it's still coming up somewhere.

Seems like this is still an issue in some places. here's a few instances:
[root@scale-192-168-4-26 ~ ]# service logcabin start
Starting logcabin:                                         [  OK  ]
[root@scale-192-168-4-26 ~ ]# ps aux | grep logcabin | grep -v grep
root     14295  1.7  0.0 495320  2332 ?        Ssl  18:58   0:00 /usr/bin/logcabind --daemon --config /etc/logcabin.conf --log /var/log/logcabin.log --pidfile /var/run/logcabin.pid
[root@scale-192-168-4-26 ~ ]# top -b -n 1 | grep logcabin
[root@scale-192-168-4-26 ~ ]# top -b -n 1 | grep evloop
14295 root      20   0  483m 2336 1520 S  0.0  0.0   0:00.16 evloop
[root@scale-192-168-4-26 ~ ]# killall logcabind
logcabind: no process killed
[root@scale-192-168-4-26 ~ ]# pidof logcabind
14295
[root@scale-192-168-4-26 ~ ]# pidof evloop
[root@scale-192-168-4-26 ~ ]# killall evloop
[root@scale-192-168-4-26 ~ ]# killall evloop
evloop: no process killed
[root@scale-192-168-4-26 ~ ]# ps aux | grep logcabin | grep -v grep
[root@scale-192-168-4-26 ~ ]# top -b -n 1 | grep evloop
so, seems the method top and killall use to get the process name are confused by the thread rename.
tried pstree as well, this one gets evloop.
[root@scale-192-168-4-26 ~ ]# pstree
init─┬─acpid
....
├─evloop───6*[{evloop}]

Oh, should have mentioned I'm on fdcd8de08bb8fd79e8784ed56f365817a2d34b94. (I have d4172886fb9c2b84d70c099e4dc9a280d1c289d2 "Close #103: OS-level thread names confuse some tools")

ok, I'll just remove it then


Python Voice Assistant

Jarvis python voice assistant

A simple python code voice assistant (Jarvis)
user friendly
easy to access code

Go for it 👍
Assigning you this work 🚀

Hey Mrinank please add the Hacktoberfest22 label otherwise it will be accepted in hacktober fest

Merged
Happy Hacktoberfest 👍

Thanks for the merged...🤗


Synchronization/cross thread visibility of variables

Some variables within CommandHandler and RedisChannelHandler are accessed multi-threaded:

RedisChannelHandler.active
RedisChannelHandler.closed
CommandHandler.closed
CommandHandler.connected
CommandHandler.channel

In certain constellations, updates are not visible to other threads and this leads to broken states (connection.close() but active=true or closed=false).
Goal: Prevent races/visibility issues

Needs merge to 4.0 branch


make all method implementations in geterrain.h inline

Currently geterrain.h defines methods that are not inline.   This header doesn't have a corresponding implementation file which is fine but then it should inline its methods (or add them to an anonymous namespace) otherwise if the header is included within more than one source of a binary linker errors will result.

Code review completed and PR merged.  Closing.


fix #276

Do not draw border on focused window on float mode desktop while focused_border_skip_floating is on

Hmm I wonder if there is a better way to achieve this effect, as the state of a floating space only needs to be checked after a space_change event, and not every time a change in window focus occur.

Yeah as I have not dived into the whole code base and figured out how everything works, this is my quick and dirty hacks to fit my urgent need. Feel free to reject if it's not what you expect. 😀

This has now been implemented on the master branch.


audit: Port line_problems to rubocop and add tests part 3

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

#569 and continuation of #2995
Suggestions for any edge test cases are needed as I may not be aware of all of them.

Thanks again @GauthamGoli!

Thanks, and good work this summer!


Add SSR/Critical CSS for inline mode

This isn't done yet, I just copied glamor's implementation. The tests are really simple and I haven't tested it outside of jest yet but it's a start and it should theoretically does work.
This will only work with inline mode since there will be imports to css files and node won't know what to do with that.
This also fixes the fontFace test.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@578f017). Click here to learn what that means.
The diff coverage is 22.22%.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   80.39%
=========================================
  Files             ?       13
  Lines             ?      459
  Branches          ?       83
=========================================
  Hits              ?      369
  Misses            ?       73
  Partials          ?       17

Impacted Files
Coverage Δ

src/index.js
90.24% <100%> (ø)

src/server.js
19.23% <19.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578f017...36047ec. Read the comment docs.

closes https://github.com/tkh44/emotion/issues/32

Can you add server.js to the main dir so that we can have a shortcut like babel.js and styled.js?

UPDATE:
I tested it with next and it works 🎉  https://emotion-next.now.sh (once this PR is merged I'll submit a PR to next.js and add it as an example)
Everything has tests.
I added a server.js file to the root so people can just import emotion/server


[Question] UI to view validation results?

I'm testing out the validator for @Trillium-Solutions, and am wondering if there is a tool or UI for consuming and displaying the results.json.
I see a few tags for a "local web UI" here in the Issues - does that tool already exist and just lack documentation, or is that something different altogether?

Hi, thks for your question and welcome around!
Quick answer: there is no tool or UI for consuming the validation report.
Longer answer: The local web UI is a web application packaging the validator functionality in a Spring based server and a React based client. It has just been merged, packaged and published as a Docker image for the first time today.
docker pull ghcr.io/mobilitydata/gtfs-validator:master
It's a first version that opens a local text editor to consume and display the validation report but could be a good candidate for more advanced visually displaying the results.
You can see more details in #421
Hope that answer your question,

@NomeQ -  perhaps open a feature request issue so that it is tracked?

FYI @NomeQ , we figured the validation report display is broken when the web app is run inside Docker. We should have a fix shortly to display it right into the UI. See #451

It has now been merged to master and is available in the Docker image

Hope that helps,


upgrade vmware-go-kcl to v1.5.0

Signed-off-by: Tao Jiang<EMAIL_ADDRESS>Description
Please explain the changes you've made
Upgrade vmware-go-kcl dependency to the latest v1.5.0.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[1231]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

The build failed on ci-lint:
  Running [/home/runner/golangci-lint-1.31.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: SA1019: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (staticcheck)
  Error: SA1019: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (staticcheck)
  Error: SA1019: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (staticcheck)
  Error: SA1019: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (staticcheck)
  Error: SA1019: package github.com/golang/protobuf/ptypes is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (staticcheck)

  Error: issues found
  Ran golangci-lint in 233888ms

All of them come from:
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&resp)
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&e)
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&e)
./state/cloudstate/cloudstate_crdt.go:					err := ptypes.UnmarshalAny(vAny, &saveState)

The build failed on ci-lint:
run golangci-lint
  Running [/home/runner/golangci-lint-1.31.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: SA1019: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (staticcheck)
  Error: SA1019: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (staticcheck)
  Error: SA1019: ptypes.MarshalAny is deprecated: Call the anypb.New function instead.  (staticcheck)
  Error: SA1019: ptypes.UnmarshalAny is deprecated: Call the any.UnmarshalTo method instead.  (staticcheck)
  Error: SA1019: package github.com/golang/protobuf/ptypes is deprecated: Well-known types have specialized functionality directly injected into the generated packages for each message type. See the deprecation notice for each function for the suggested alternative.  (staticcheck)

  Error: issues found
  Ran golangci-lint in 233888ms

It is caused by calling deprecated function in:
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&resp)
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&e)
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&e)
./state/cloudstate/cloudstate_crdt.go:					err := ptypes.UnmarshalAny(vAny, &saveState)

@daixiang0

@taojwmware would you mind to sync from the latest master branch and resolve the conflict? I have time to review your change in this week.


Why it doesn't load images in PDF?

In the rendered PDF images are not loaded.
here is main.py
import pydf

html_str = """
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width,initial-scale=1" />
    <title>بن اعتباری</title>
  </head>
  <body>
      <img src="./pizza.jpg" />
  </body>
</html>
"""

pdf = pydf.generate_pdf(html_str)
with open("test_doc.pdf", "wb") as f:
    f.write(pdf)

and image exists in that directory and everything is fine in html file

@MojixCoder I think this will probably answer your question! https://github.com/wkhtmltopdf/wkhtmltopdf/issues/4723


Replaced panic on cluster close to error issues

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #172 (8711b8d) into master (6cf527c) will decrease coverage by 34.52%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           master     #172       +/-   ##
===========================================
- Coverage   53.86%   19.33%   -34.53%
===========================================
  Files         142      131       -11
  Lines       16133    15050     -1083
===========================================
- Hits         8690     2910     -5780
- Misses       6959    11900     +4941
+ Partials      484      240      -244

Flag
Coverage Δ

1.14.x
?

1.15.x
?

1.16.x
?

1.17.x
19.33% <20.00%> (-34.46%)
:arrow_down:

connection
?

discovery
?

e2e
19.33% <20.00%> (-27.90%)
:arrow_down:

integration
19.33% <20.00%> (-27.90%)
:arrow_down:

macOS-latest
?

ratelimiter
15.65% <20.00%> (-0.01%)
:arrow_down:

scripting
16.08% <20.00%> (-0.01%)
:arrow_down:

table
?

ubuntu-latest
19.33% <20.00%> (-34.63%)
:arrow_down:

unit
?

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf527c...8711b8d. Read the comment docs.


Indicate mod's origin provider

Add an icon next to each mod showing it's origin (mod.io, HTTP URL, local file)

I have a PR for this, blocked on #9 for some prior changes.


fix: add our volume selector zone requirement to all terms

Fixes #2971
Description
Node selector terms are OR'd together, so our relaxation removes them one at a time when we are unable to schedule.  This change ensures we add the volume topology zone requirement to all terms instead of just  the first one so the relaxation process won't remove it causing us to think a pod will schedule, when it won't.
How was this change tested?
Unit testing & deployed to EKS.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 74.754%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
5164

Relevant Lines:
6908

💛  - Coveralls


[IE] if interactionDOMElement.getBoundingClientRect doesn't exist use empty rect

Founded and resolved by @POlITIC

cheers for this!


Add value to ctx in EnumMemberError.

Change Summary
Add value to ctx in EnumMemberError.
Feature requested in #1938 and #784.
@tek08 already has a patch on the way that contains this change
but its scope is broader and more complex. This PR is intended as a quick win.
Checklist

[x] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review

Thanks but if you look at the linked issue you can see that it has been rejected as is for v1.
With v2, context (including set value) will always be added but it needs some extra work around it.
See https://github.com/samuelcolvin/pydantic/pull/2425#discussion_r628860363


Using our own veins fork

This seems like it might be necessary to allow us to add some of the functionality in TraCI that we need in veins. Just wanted to open up a discussion about it. We could either include the few modified files that we make into this repo, or we can maintain the temporary fork I made here. We can try to do a pull request, but I'm not sure when or how frequently we should do that if we're going to be actively developing this. Also their repo isn't very actively developed so I'm not sure how easy PRs would be. We also might be able to do some networking magic that allows us to do python TraCI commands and pass them by proxy through our Omnet++ simulation. Any thoughts?

I haven't seen evidence that says that network magic would be easy. I like the idea of using a custom veins maintained on your fork.

Note: We'll need to update our installation guides to use our custom veins. I also just realized that our installation guides don't mention cloning this repo.

I just finished my install guide, with both of these in mind, let me know if I missed something. Otherwise up to you.

Oh I might need to add this to my install guide now...


nvm ls-remote does not list v20.8.1 as Latest LTS: Iron

Operating system and version:
macOS Monterey
Version: 12.3.1 (21E258)
nvm debug output:

nvm --version: v0.39.5
$TERM_PROGRAM: iTerm.app
$SHELL: /bin/zsh
$SHLVL: 1
${HOME}: <snipped>
${NVM_DIR}: '${HOME}/.nvm'
${PATH}: ${NVM_DIR}/versions/node/v18.18.2/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
$PREFIX: ''
${NPM_CONFIG_PREFIX}: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'zsh 5.8 (x86_64-apple-darwin21.0)'
uname -a: 'Darwin 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64 x86_64'
checksum binary: 'sha256sum'
OS version: macOS 12.3.1 21E258
awk: /usr/bin/awk, awk version 20200816
curl: /usr/bin/curl, curl 7.79.1 (x86_64-apple-darwin21.0) libcurl/7.79.1 (SecureTransport) LibreSSL/3.3.5 zlib/1.2.11 nghttp2/1.45.1
wget: /usr/local/bin/wget, GNU Wget 1.21.4 built on darwin21.6.0.
sed: /usr/bin/sed
cut: /usr/bin/cut
basename: /usr/bin/basename
rm: /bin/rm
mkdir: /bin/mkdir
xargs: /usr/bin/xargs
git: /usr/local/bin/git, git version 2.42.0
ls: grep:: No such file or directory
grep: grep: aliased to grep --color=auto --exclude-dir={.bzr,CVS,.git,.hg,.svn,.idea,.tox} (grep --color=auto --exclude-dir={.bzr,CVS,.git,.hg,.svn,.idea,.tox}), grep (BSD grep, GNU compatible) 2.6.0-FreeBSD
nvm current: v18.18.2
which node: ${NVM_DIR}/versions/node/v18.18.2/bin/node
which iojs: iojs not found
which npm: ${NVM_DIR}/versions/node/v18.18.2/bin/npm
npm config get prefix: ${NVM_DIR}/versions/node/v18.18.2
npm root -g: ${NVM_DIR}/versions/node/v18.18.2/lib/node_modules

nvm ls output:

       v16.20.2
->     v18.18.2
         system
default -> lts/hydrogen (-> v18.18.2)
iojs -> N/A (default)
unstable -> N/A (default)
node -> stable (-> v18.18.2) (default)
stable -> 18.18 (-> v18.18.2) (default)
lts/* -> lts/hydrogen (-> v18.18.2)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.24.1 (-> N/A)
lts/erbium -> v12.22.12 (-> N/A)
lts/fermium -> v14.21.3 (-> N/A)
lts/gallium -> v16.20.2
lts/hydrogen -> v18.18.2

How did you install nvm?

Install script in readme using curl.
What steps did you perform?
nvm ls-remote --lts=iron
            N/A

What happened?
Output N/A.
What did you expect to happen?
The Node.js website https://nodejs.org/en now shows versions 20.8.1 LTS and 21.0.0 Current.
Expected to get:
       v20.8.1   (Latest LTS: Iron)

Is there anything in any of your profile files that modifies the PATH?

Yes. I am using Oh My Zsh.

For me it now works with the release of Node 20.9.0.

During the actual LTS promotion, which was this morning, the website might report results inconsistently.
@tfentonz can you check again?

@ljharb now working for me. Promotion unlocked.
nvm ls-remote --lts=iron
        v20.9.0   (Latest LTS: Iron)

Closing issue.


i2c peripheral is not using a repeated start condition for write_read()

A logic analyser shows that a stop condition followed by start condition is currently being issued instead of the repeated start.
Both embedded-hal and embedded-hal-async specify that write_read() uses a repeated start condition.
Some devices like the veml7700 require a repeated start. See Fig. 4 - I2C Bus Timing for Receive Word Command Format on page 4.

Probably the best thing to do would be to support  https://docs.rs/embedded-hal/latest/embedded_hal/i2c/trait.I2c.html#tymethod.transaction - for the embedded-hal trait the provided methods will use it and things should be fine


Showing Wrong Bank Name

Link: https://ifsc.razorpay.com/PUNB0392700
Output: {"BRANCH":"DAULATPUR","CENTRE":"DAULATPUR","DISTRICT":"UNA","STATE":"HIMACHAL PRADESH","ADDRESS":"DAULATPUR, UNA  HP 176038","CONTACT":"01976265167","UPI":true,"RTGS":true,"CITY":"DAULATPUR","MICR":"110024187","NEFT":true,"IMPS":true,"SWIFT":"","BANK":"Punjab National Bank","BANKCODE":"PUNB","IFSC":"PUNB0392700"}
Original Bank: PNB, Dilshad Garden

This is correctly reported now.


Support encrypting key-value entries

When setting a key, it should be able to be encrypted. Updating the value should maintain its encryption.
Permissions to the keys should be checked.
Split from #64.

This is being implemented/rendered invalid by #75.


Add JSON FeatureFlag

The LDFeatureFlag impl uses the guice registered Moshi instance to
deserialize the JSON into a POJO.
Most likely app developers will screw up the JSON values in LD,
resulting in Moshi deserialization Exceptions in their app.
However, it should be a rather quick change to update the value in LD.
I believe the usefulness of JSON flags for DynamicConfigs outweighs this chance
of human error.
I want to use this to dynamically configure jobqueue and event
consumers. Something like a JobqueueConsumerConfig:
{
"enabled": Boolean
"batch_size": Int
"schedule": TaskSchedule
}
TaskSchedule:
{
"more_work_ms": Int
"no_more_work_backoff: Backoff
"error_backoff": Backoff
}
This would be extremely difficult to manage with individual flattened
flags like "jobqueue_consumer_schedule_more_work_ms".

Nice!

Serialization exceptions are a good example of why in-code default values could be useful.
How controversial would it be to expand the Feature API to also include a safe get-or-default accessor that would bark loudly (e.g., with log.warn) and use the specified default. Maybe making it something you have to explicitly use would make it less controversial than making default value fallbacks a standard for all feature flag usage?
E.g.,
const val SOME_SAFE_DEFAULT = makeValidGsonThatWontExplode()
...
fun Feature.getOrDefault(..., defaultVal) {
  try {
    this.get(...)
  } catch (e: Exception) {
    log.warn("Flag not registered or value was invalid", e)
    SOME_SAFE_DEFAULT
  }
}
...
...
val definitelyValidParams = zachsJsonFeature.getOrDefault(flagInput, SOME_SAFE_DEFAULT)
doStuff(definitelyValidParams)

@zcross I still feel like that default value is a little bomb in the codebase. Lots of feature flags are created with a initial value, and then get turned on in production to a target value. But the default in the code will always be the initial value.

@zcross I still feel like that default value is a little bomb in the codebase. Lots of feature flags are created with a initial value, and then get turned on in production to a target value. But the default in the code will always be the initial value.

@zcross @swankjesse there is never going to be a golden answer to this problem, it is very use case specific. sometimes a default is totally sane, sometimes it could cause catastrophic consequences. additionally, failing a request that could use a sane default could also lead to catastrophic consequences.
The question is should we provide overloaded methods that accept an optional default. I think the concern there is it makes providing a default too easy, without forcing a developer to think through what happens if my code unexpectedly falls back to the default in the future. Is it really safe?
After initially being an advocate for defaults, and implementing my own default fallback logic in a library, I'm starting to realize defaults are hard to reason about. Ultimately it's much easier to think about the failure scenario of "failing to talk to LD and failing the request" vs "failing to talk to LD and running an old code path".
I think for now we force developers to implement their own try-catch-return default logic and reconsider adding it later.

Yeah, I think you got it exactly right. Running old code is a dangerous failure mode, whereas 503ing is a well-known failure mode.


Nonce Handling

First commit is not complete, but implements the nonce storage, when finished this PR should have the nonce storage as a module (similar to polkadex_balance_storage) and should allow for the nonce operations, finishing closes issue #61

The code should also be error handled and cleaned prior to finishing.

@haerdib Besides these conflicts, i think it is actually working, I must have mistaken something because i rerun the tests and it is actually working as expected.

@haerdib So if i understand it correctly now, i leave the nonce_handler code and places where its being used intact and separate the nonce_storage as it's own thing?

Yes, for now that would be the best solution. A clean up of the nonce handler is necessary, but that should be an independent task.

Added tests to nonce_storage as requested.

I think there has been a misunderstanding somewhere. You're somewhat coupling the nonce_handler of the enclave with the nonce storage for the accounts. But these two should be strictly separate.
Like I've written in Teams:

Nonce_handler handles the nonce of the enclave extrsinics sent to the substrate chain. While your nonce storage handles the nonces of users talking directly to the worker / enclave.
Both are nonces, but are handling two completely separate usecases

If you want to somewhat couple them due to them being both nonce storages, you can do that by using the same trait between them, but I don't think even that makes sense due to the following reasons:

The enclave nonce handler needs to lock the storage over a period of time such that another thread can not read the nonce and get an outdated nonce, resulting in a failed extrinsic - in this case the enclave is the "sender"
In the nonce storage however the enclave is the "receiver", meaning it validates the nonce.
Additionally, unlike in 1., we have a nonce for each account. As each account interacting with the enclave needs to be registered anyway (that's what the authorize function tests), I think it would make sense to couple the initialisation of the nonce of each account (to 0 ) when the account itself is registered. Or even combine the account regisry and the nonce storage, as I've written in implement a valid nonce in the client calls #61:

Because we are already storing the registered accounts, it would probably make sense to store the assosciated nonce there as well. I'm not sure if this should be implemented within the balance storage because there the tokenid is used for key generation.
Take a look at the account registry, which is implemented here: https://github.com/Polkadex-Substrate/polkadexTEE-worker/blob/develop/enclave/src/polkadex.rs

It is quite a complex task.. please do ask me or @Gauthamastro in case of confusion. I'm sorry if I've been somewhat unclear and caused misunderstanding.

This a really good explanation @haerdib, Great work!

Since the nonce stroage and account storage in polkadex.rs are somewhat bundled together, the nonce storage could be implemented within the account storage, like substrate has done in the BasiPool struct. This struct contains the Pool struct, which is a separate struct itself, but it is clear that BasicPool is bonded with the Pool.
Additionally, it might be worth to take a look at the trait implementation of the Chain Api. This allows to unit test the Pool Struct separatedly from the ChainApi by creating a Mock ChainApi for testing purpose. Maybe we should do the same for the Nonce Storage struct?

Since the nonce stroage and account storage in polkadex.rs are somewhat bundled together, the nonce storage could be implemented within the account storage, like substrate has done in the BasiPool struct. This struct contains the Pool struct, which is a separate struct itself, but it is clear that BasicPool is bonded with the Pool.
Additionally, it might be worth to take a look at the trait implementation of the Chain Api. This allows to unit test the Pool Struct separatedly from the ChainApi by creating a Mock ChainApi for testing purpose. Maybe we should do the same for the Nonce Storage struct?

Yes, this would be great.
CC: @arrudagates

Can't this be solved in a simpler way if we create a parent struct which contains both PolkadexAccountStorage and PolkadexNonceStorage:
pub struct Storage {
    accounts: PolkadexAccountsStorage
    nonce: PolkadexNonceStorage
}

and implements methods that will use both, like for example initialize_main_account(acc) would call self.accounts.add_main_account(acc) and then call self.nonce.initialize_nonce(acc):
pub fn initialize_main_account(acc: AccountId) {
    self.accounts.add_main_account(acc);
    self.nonce.initialize_nonce(acc);
}

This way there would be nothing preventing unit tests to happen independently on each struct, as the interaction between both happens in its own separate parent struct.

Sure, I think that is a possibility as well. But then you'd need to implement an "Add Account and nonce" function there as well, which then calls a) the account storage to register a new account and b) create a new nonce entry. Same goes for remove. But I think that's a good solution, keeping the two storage structs completely separate.
But what I'm not yet sure about is wether it's simpler. Because if we want to test thouroughly we also need to test the Storage struct you proposed (i.e. we need to make sure that it really calls both storage initialisation, adds a nonce and an acoount and does not omitt a call anywhere). Which then would need Mock implemenations for both structs.

Sounds great! If you're restructuring, also consider the naming of file (polkadex.rs is not really a good name for a storage struct file) and the Storage struct name.
For mocking traits you could consider https://docs.rs/mockall/0.9.1/mockall/attr.automock.html for easy mocking

I think trying to register/remove an account/proxy should return an error, so I'm implementing errors on those situations and I'll refactor the tests dependent on that (test_polkadex_gateway), it looks like this:
pub fn add_main_account(&mut self, acc: AccountId) -> Result<(), AccountsStorageError> {
        if self.accounts.contains_key(&acc.encode()) {
            warn!("Given account is registered");
            return Err(AccountsStorageError::AccountAlreadyRegistered);
        };
        let vec: Vec<AccountId> = Vec::new();
        self.accounts.insert(acc.encode(), vec);
        Ok(())
    }

Can i continue with this approach or should i revert back?

There are some things yet to do with the code in the last commit, like some missing tests and renaming the polkadex.rs module

I'll get on these changes right now

@haerdib Maybe it would make sense to have the structure like:
enclave/src/
    accounts_nonce_storage/
        lib.rs
        accounts_storage.rs
        nonce_storage.rs

Maybe it would make sense to create a folder for the newly created files, as they somewhat belong together?
Also @Gauthamastro  we need to think about the permanent nonce storage on disc / ipfs ( I think this is neccesary... though I'm not 100% sure right now) Should this be discussed in a separate issue?

I would like to study IPFS, so maybe I could take on that task too.

Maybe it would make sense to create a folder for the newly created files, as they somewhat belong together?
Also @Gauthamastro we need to think about the permanent nonce storage on disc / ipfs ( I think this is neccesary... though I'm not 100% sure right now) Should this be discussed in a separate issue?

I believe, we can store this on permanent storage and it can be part of the IPFS snapshots

Maybe it would make sense to create a folder for the newly created files, as they somewhat belong together?
Also @Gauthamastro we need to think about the permanent nonce storage on disc / ipfs ( I think this is neccesary... though I'm not 100% sure right now) Should this be discussed in a separate issue?

I believe, we can store this on permanent storage and it can be part of the IPFS snapshots and, also included in recovery process along with balances of an account

I believe it would make sense to put this in a separate issue,  so this PR doen't get too big. What do you think about this @Gauthamastro  and @arrudagates ?

I believe it would make sense to put this in a separate issue, so this PR doen't get too big. What do you think about this @Gauthamastro and @arrudagates ?

Yes, I agree.

IPFS should be a separate issue. This is only for nonce handling


Incompatable with Spleeter?

I was able to get it working but only by installing BeatNet after calling Spleeter, which makes it a little weird to work with. I have an open StackOverflow question on this, but I was wondering if you could resolve it with dependency management of some kind.
https://stackoverflow.com/questions/75838650/spleeter-and-beatnet-incompatible-numpy-numba-libraries-any-solutions

Alternatively use demucs -- much more reliable stemming https://github.com/facebookresearch/demucs -- though I've not tried it with beatnet yet.

Actually, I was able to fix BeatNet - I basically removed the packaging, and manually installed the packages it needed. I don't know why the packaging doesn't work (I think its a bunch of outdated version information)

This works for me in vanilla colab
!pip install -q cython
!pip install -q numba
!pip install -q librosa
!pip install -q mido
!pip install -q pytest
!pip install -q scipy
!pip install -q numpy
!pip install -q torch
!apt-get install portaudio19-dev
!pip install -q pyaudio
!pip install -q pydub
!pip install --upgrade --no-deps --force-reinstall --quiet 'git+https://github.com/CPJKU/madmom.git'
!pip install --upgrade --no-deps --force-reinstall --quiet 'git+https://github.com/davies-w/BeatNet.git'

In addition to the suggested solutions, in the case of Spleeter dependencies incompatibility, alternatives such as Demucs source separator engines can be utilized whose reported performance is higher than Spleeter.


Two ways to use this proxy in Python

After got the secret sauce:
basic_auth, proxy, port = get_proxy()

I find that one low-level way to use it is:
req = 'GET {url} HTTP/1.0\nProxy-Authorization: BASIC {basic_auth}\n\n'.format(
    url='http://httpbin.org/ip', basic_auth=basic_auth)
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
sock = ssl.wrap_socket(sock)
sock.connect((proxy, port))
sock.send(req.encode('ascii'))
print(sock.recv(1024))
sock.close()

Another method needs an ugly monkey patch of HTTPSConnection to avoid SNI error:
class PatchedContext:

    def __init__(self, conn):
        conn._check_hostname = False
        conn._context.check_hostname = False
        self.ctx = conn._context

    def __getattr__(self, attr):
        if attr == 'wrap_socket':
            return lambda sock, server_hostname: self.ctx.wrap_socket(sock)
        return getattr(self.ctx, attr)

conn = http.client.HTTPSConnection(proxy, port)
conn._context = PatchedContext(conn)
conn.request("GET", "http://httpbin.org/ip",
             headers={"Proxy-Authorization": "BASIC "+basic_auth})
print(conn.getresponse().read())

@scturtle, were you able to use it with https sites? https://httpbin.org/ip and others result in 500 Internal Server Error.

@dessant I can use it as plain HTTP/HTTPS proxy now:) See my gist.

@scturtle oh lovely, thanks for sharing. :trophy:

@scturtle Thanks for sharing! Any idea how can I package it with my script together? Or do an update to docs or something?

@spaze Not really. Just share here in case someone needs. Pls feel free to take any part of the code or close this issue.

Thanks for sharing! If possible, can you do another example but using python requests?

I tried the above code changes and still seem to be getting a b'malformed HTTP response ""\n'.  Is there something that I'm missing?
I used the proxy.py script in the gist you made and it seems to work when I do that. So not sure why there would be something specific to doing the monkey patch (I've tested to make sure that the proxy credentials are valid)

With http resources everything is fine, but with https - malformed HTTP response "<html>"
Any ideas how to handle that?


⚠ Bofrost.de has degraded performance

In 8d31d06, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 990 ms

Resolved: Bofrost.de performance has improved in ca01d8b after 13 minutes.


Make jmeter service configurable

Currently the jmeter-service does require a certain naming convention for the jmeter test files as well as the port 80 to be exported by the services under test.
desired output:

have the name of the jmeter file as a parameter
have the port of the service to be tested as a parameter

Additionally to making the jmeter-service configurable, it should also provide logs. Currently, the jmeter-service only has logs in the pods which are overwritten by each run.

Additionally to making the jmeter-service configurable, it should also provide logs. Currently, the jmeter-service only has logs in the pods which are overwritten by each run.

Just for clarification. Overwritten by each run includes running through different stages. It would be okay - not the best - if there are log files for each stage which will be overwritten by sending a new-artifact.
I would suggest something like a results folder, which saves the log files for at least the last 10 runs (including alle stages) and it would be nice, if you could add the name of the stage to the log files.


fix crashing with :badarg on a discovereable relative protocol url

HTTPoison crashes with :badarg if provided url has double slash relative protocol ("//example.com")
So if some service provides discoverable oembed link with relative protocol, :get_oembed request will crash
Example:
<link rel="alternate" type="application/json+oembed" href="//www.playbuzz.com/api/oembed/?url=https://www.playbuzz.com/qzeyrr10/plan-a-vacation-and-well-tell-you-what-job-you-should-have&format=json">

This fixes it by replacing // with http://. As random website may not use https, i figure replacing with http is more robust

Thanks, well spotted!

@slavone On second thought, I've found the better way to handle this.
Using URI.merge - https://hexdocs.pm/elixir/URI.html#merge/2
  defp discover(url) do
    with {:ok, %HTTPoison.Response{body: html}} <- HTTPoison.get(url, [], [follow_redirect: true, ssl: [{:versions, [:'tlsv1.2']}]]),
         [_ | _] = tags <- Floki.find(html, "head link[type='application/json+oembed']"),
         {"link", attributes, _} <- List.first(tags),
         %{"href" => href} <- Enum.into(attributes, %{}),
         oembed_url = %URI{} <- URI.merge(url, href)
    do
      {:ok, URI.to_string(oembed_url)}
    else
      _ -> {:error, "oEmbed url not found"}
    end
  end

When we're requesting the page, and API url is relative, basically it's relative to the current url.
So all we need is to merge requested url with API url.
i.e. URI.merge("http://somepage.com/url", "//somepage.com/api")
URI.merge will take the parts missing in the second url from the first one.
I've updated the master branch.

Yeah, i like this, solves the problem of potential 301 requests to the /api with http. Good discovery!


detailed-logging-is-on to be added to CC

Decision on the Application Implementation call on 13th or May:
The detailed-logging-is-on attribute shall be added to the response body of the /core-model-1-4:control-construct path in the OAS.
It shall be added to the properties section, but not the required section.

No individual /core-model-1-4:control-construct path in the TAR


add support for tables located in S3 in Iceberg REST catalog

PR Checklist

[ ] A description of the changes is added to the description of this PR.
[x] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes

Related Issues
This PR covers the basic and initial S3 support addressing issue https://github.com/unitycatalog/unitycatalog/issues/105

Thank you @alexreid-db for this! How can we test this? Could you take a look at the current unit tests and see if these code paths have enough coverage to be confident that we are not breaking local path support? If not, could you add better unit tests to ensure local path is not broken?
For S3, have you tested manually?

Yeah, sorry, meant to create this as Draft until I added the tests and description.
This is a pre-requisite for any credential vending, etc.
Yes, I've tested this locally with OSS Spark. Caveats until credential vending support is that both the client and server need credentials in the default credentials provider chain that has access to the table location(s).

@haogang @tdas this PR is ready for review


Explorer

Issue Type: Bug
Explorer is impossible to use with extensions.  You can't resize the sections and the Source Control section is impossible to navigate for large amounts of files.
  As you can see there is a ton of Git Lens
crap that I can't get rid of and I can't resize the windows, making the
explorer a total pain to use, because you can only see 10 lines at a time.
On Wed, Feb 24, 2021 at 10:47 PM David Campbell<EMAIL_ADDRESS>wrote:

On Wed, Feb 24, 2021 at 8:04 PM VS Code Issue Triage Bot <
<EMAIL_ADDRESS>wrote:

Thanks for reporting this issue! Unfortunately, it's hard for us to
understand what issue you're seeing. Please help us out by providing a
screen recording showing exactly what isn't working as expected. While we
can work with most standard formats, .gif files are preferred as they
are displayed inline on GitHub. You may find https://gifcap.dev helpful
as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling
screencast mode for the recording (Developer: Toggle Screencast Mode in
the command palette).
Happy coding!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/117630#issuecomment-785520895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATMEXKGR7EK3J7YWIKAWY3TAWVZTANCNFSM4YFNC3GA
.

Unfortunately when images are sent to GitHub by replying to a notification email they get lost. Instead please visit the issue on the GH website and copy+paste or drag+drop your gif file into the comment field. You can then use the Preview tab to verify it before posting.

This is caused by GitLens extension. Either uninstall it, or right click hide the views


New copy action menu

New copy action menu
Pull flex style to globals
Use …s

Closes #960

📝Changed routes:

/snippets

(view full size)

Commit 4412fae9cd7578cfab6e4c1f6332eecf700a598c (https://carbon-git-copy-menu.carbon-app.now.sh).


Unable to run Python script

I successfully installed atom and script. But I can't run python script at all(all python scripts has same error.)
I'm using Window 7 and python3.4. Plz help me.

Based on the double output, you need to fully restart and upgrade Atom if you can.

Closing due to age, no response, and lack of information


Prevent panic when response is nil

The response from go's http client can be nil when
an error occurs. In order to prevent panicking the
error needs to be checked before attempting to access
the response.

Thank @piersy for the contribution. That nil check definitely needed to be higher :+1: :goat:

np :)


Notifications without auto-closing

Requesting for the ability to remove the auto close timer to allow persistent toasts that explicitly have to be dismissed.

Hey @muhammadsqln
If you want a Toast without auto close behavior, just don't pass any value to the autoCloseDuration parameter.
Example:
toastification.show(
	  context: context,
	  type: ToastificationType.success,
	  style: ToastificationStyle.flat,
	  title: 'Component updates available.',
	  description: 'Component updates available.',
	  alignment: Alignment.topLeft,
	);


Adding the support for key for trigger & output binding

Adding the support for key for trigger & output binding as per customer demand :-

https://github.com/Azure/azure-functions-kafka-extension/issues/326
https://github.com/Azure/azure-functions-dotnet-worker/issues/848

Kafka supported any library provide customer the support of reading key & value(message), so this is a required support for the customer

Unit testing -- done
E2E testing -- the language worker is still in-progress, will add the test case when that will be done

Should we set the Key as well in the constructor at line 110 in KafkaEventData.cs?

Yes, even if the key is null it will write the key as null and it's customer choice in his code if it wants to read that or not.


[draft]: fixing ci issues

god bless revert
closing this one as it helped with debugging CI abnormal reaction with the if statement in store_heightsub.go


Add the support to install the binaries from the new repo

This PR adds the functionalities to either install openwhisk
binaries from the releases page of openwhisk cli or copy the
binaries locally.
The key installation_mode of openwhisk_cli dict can be set to
remote or local. The default one is local.
Closes-Bug: #2101

PG4 456 🔵


casks/p4merge.rb

sha256 doesn't match
openssl md5 -sha256 Downloads/P4V.dmg
SHA256(Downloads/P4V.dmg)= 766b6f6b8669f889f1186dd96408b5b8af6b9dc6c602784d6d6ea25130007709

Thanks for the report. The checksum was fixed in 4b4a943a7f.

Thank you @ndr-qef!


Dak

Is "dak" an actual word, or is it just a mistyping of "diak?"  I came across this sentence:  "Klteketel a taem el dak el kie e ngika el rubak a mlo metik er a klemeriar reng er a Ezekiel el kirel a chelitakl " and I wonder if it should be "diak el kie?"  What is a good translation for that first part of the line:  klteketel a taem el dak el kie?  Searching for the phrase "dak" turns up a lot of examples on tekinged, but they look like mistypes.

It comes from "dmak" as in together. But in many sentences like this one,
it's shortened to "dak."
Kelteketel a taem el dak el kiei...
In this context, I would translate the sentence to: As they lived together
for some time, the old man discovered  Ezekiel's interest in songs."
If you change the sentence to " Ng kelteketel a taem el dak el kiei e ngika
el rubak a KOL MLO METIK... Then it would be "After all this time or they
lived together for a long time when finally the old man discovered...
Slight changes... But that's a whole different issue.. Lol. DAK remains the
same in both sentences.
Other example sentences with the word in different forms:
Jim, me de DAK el mora ospitar. Jim, let's go to the hospital together.
Ngak ma Jim a DILAK el mo er a ospitar. Jim and I went to the hospital
together.
A lekok DMAK ngak ma Jim el mo er a ospitar e ng di ng mla merael. I was
going to go to the hospital with Jim but he left already.
Jim, MDAK kau ma Lukes el mo er a ospitar. Jim, go with Lukes to the
hospital.
Hope this helps.
J
On Thu, Mar 2, 2023, 5:27 PM JimGeselbracht @.***>
wrote:

Is "dak" an actual word, or is it just a mistyping of "diak?" I came
across this sentence: "Klteketel a taem el dak el kie e ngika el rubak a
mlo metik er a klemeriar reng er a Ezekiel el kirel a chelitakl " and I
wonder if it should be "diak el kie?" What is a good translation for that
first part of the line: klteketel a taem el dak el kie? Searching for the
phrase "dak" turns up a lot of examples on tekinged, but they look like
mistypes.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/405, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXYSPXQCUCDP3QDEMHLVIXDW2E3HFANCNFSM6AAAAAAVOAHXCE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Awesome.   Thanks
Jim Geselbracht

From: Lukes-Imeyuns @.>
Sent: Thursday, March 2, 2023 6:39:36 PM
To: tekinged/missing @.>
Cc: JimGeselbracht @.>; Author @.>
Subject: Re: [tekinged/missing] Dak (Issue #405)
It comes from "dmak" as in together. But in many sentences like this one,
it's shortened to "dak."
Kelteketel a taem el dak el kiei...
In this context, I would translate the sentence to: As they lived together
for some time, the old man discovered Ezekiel's interest in songs."
If you change the sentence to " Ng kelteketel a taem el dak el kiei e ngika
el rubak a KOL MLO METIK... Then it would be "After all this time or they
lived together for a long time when finally the old man discovered...
Slight changes... But that's a whole different issue.. Lol. DAK remains the
same in both sentences.
Other example sentences with the word in different forms:
Jim, me de DAK el mora ospitar. Jim, let's go to the hospital together.
Ngak ma Jim a DILAK el mo er a ospitar. Jim and I went to the hospital
together.
A lekok DMAK ngak ma Jim el mo er a ospitar e ng di ng mla merael. I was
going to go to the hospital with Jim but he left already.
Jim, MDAK kau ma Lukes el mo er a ospitar. Jim, go with Lukes to the
hospital.
Hope this helps.
J
On Thu, Mar 2, 2023, 5:27 PM JimGeselbracht @.***>
wrote:

Is "dak" an actual word, or is it just a mistyping of "diak?" I came
across this sentence: "Klteketel a taem el dak el kie e ngika el rubak a
mlo metik er a klemeriar reng er a Ezekiel el kirel a chelitakl " and I
wonder if it should be "diak el kie?" What is a good translation for that
first part of the line: klteketel a taem el dak el kie? Searching for the
phrase "dak" turns up a lot of examples on tekinged, but they look like
mistypes.
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/405, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXYSPXQCUCDP3QDEMHLVIXDW2E3HFANCNFSM6AAAAAAVOAHXCE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHubhttps://github.com/tekinged/missing/issues/405#issuecomment-1452872033, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AX6MKZP327ENFE4TVYAS5W3W2FKWRANCNFSM6AAAAAAVOAHXCE.
You are receiving this because you authored the thread.Message ID: @.***>

Hey Jim,
I think this is a pattern in more words than just DMAK. If you look at the grammar book in Section 6.4.2, you'll see that 'M' is a verb marker infix found in the base version of many verbs:

And, I don't know where it is explained in the grammer book (Aleks probably does!), but the 'M' infix is dropped in many non-base versions like hypotheticals and past tense versions.
So DMAK becomes DAK in a hypothetical like 'SEL DE DAK' for 'when we are together' and in the past past tense like 'AKI DILAK' for 'we were together.
I tried to do a SQL search to find all the documented verbs that follow this pattern:
mysql> select stem,pal,pos from all_words3 where (pos like 'v.i.' or pos like 'v.s.' or pos rlike 'past') and stem in (select id from all_words3 where substr(pal,2,1) = 'm' and (pos like 'v.i.' or pos like 'v.s.') and id=stem and substr(pal,1,1) != 'o') order by stem;
+-------+--------------+----------+
| stem  | pal          | pos      |
+-------+--------------+----------+
|    37 | dilak        | v.past   |
|    37 | dmak         | v.i.     |
|    63 | lmangel      | v.i.     |
|    63 | bekelilangel | v.s.     |
|    63 | lilangel     | v.i.past |
|    67 | lmuk         | v.i.     |
|    67 | liluk        | v.i.past |
|    68 | lmuut        | v.i.     |
|    68 | liluut       | v.i.past |
|  1263 | kmeed        | v.s.     |
|  1263 | kileed       | v.s.past |
|  2093 | tmuu         | v.i.     |
|  2093 | tiluu        | v.i.past |
| 12325 | tilaut       | v.past   |
| 12325 | tmaut        | v.i.     |
+-------+--------------+----------+
38 rows in set (0.13 sec)

@Lukes-Imeyuns , thanks for an awesome explanation and example sentences.

OK, we should create an auto parse for this. Add it to DMAK as a v.s.hypo. and add the example sentences from Lukes as well:
Jim, me de DAK el mora ospitar. Jim, let's go to the hospital together.
Ngak ma Jim a DILAK el mo er a ospitar. Jim and I went to the hospital
together.
A lekok DMAK ngak ma Jim el mo er a ospitar e ng di ng mla merael. I was
going to go to the hospital with Jim but he left already.
Jim, MDAK kau ma Lukes el mo er a ospitar. Jim, go with Lukes to the
hospital.


Finish chapter 2 example

Choose another example from htmx site.
Implement it.

Done basic example, i have not done input validation.


Keras OCR TFLite Models

Adding Keras OCR TFLite Models.

@maringeo  Did you have a chance to look at this PR?

@maringeo Publisher name is missing in the TFHub pages of both Keras OCR and CRAFT Text Detector. Please look into it.


Create a Bucket sort in c++

create a bucket sort in easyest method please approve it..

Great work please give this repo a star and follow me for follow back 😊

thank You and done... :)

it shows me this why..

Is it get merged?

yes ThankYou

Please give this repo a star ✨
Thank you ☺

i have one question, my only two repo is count some are excluded and some are not-Accepted. Can i do other question on your repo should it countable on hacktoberfest ...???