Decide on extension trait convention

Tide uses many "extension traits" (which extend an existing type with new methods, and have no other impls). We should standardize on a naming convention.

One possibility would be FooExt where Foo is the name of the type being extended -- including the type in the name helps the reader quickly see what is being extended.
A downside is that we want to provide many extensions to Context. We'd end up with cookies::ContextExt and forms::ContextExt etc. But given that you only use these trait names on import, where they will be qualified by module, perhaps this is fine? The paths do contain the full set of relevant info: what is the extension, and what is being extended?

I think using ContextExt would be a good idea. This would be the common type name across the entire ecosystem which would signal that this type extends something on tide's Context. I think the recognizability this achieves will be really useful to convey the idea of how it's supposed to be used. Overall it provides a consistent name for the core extension trait in a given crate across all such crates.
@aturon  I agree with you, given that the type itself will only be present at the top of the file for the most part and the type will not be used anywhere else, the import path will give enough context as to where this is coming from.

If I apply this specification to #175, I feel like we have several options:

QueryStringExt
UrlQueryExt
QueryExt

I'm not entirely sure which is appropriate, but the method it defines is url_query. So UrlQueryExt is probably the most intuitive.

I'm in support of using the *Ext naming scheme -- it's what I see a lot in the ecosystem already and feels the most familiar.
As for the comment above https://github.com/rustasync/tide/issues/187#issuecomment-486456855, yeah I'd also go with UrlQueryExt. I think QueryExt is a bit too unclear, and QueryStringExt doesn't quite feel right (as while it is a string deserialization it doesn't quite describe the entire nature of the extension trait).

@fairingrey Ignore my comment above. I completely misunderstood the convention. A more appropriate naming scheme for the querystring module is tide::querystring::ContextExt.

Oh, sorry! Yeah, that makes sense.

A downside of the chosen convention I recently ran into is not being able to actually bring multiple ContextExt into scope. A workaround is to use the relatively recent use foo::Foo as _; feature to import the traits methods into scope without having the trait nameable:
use tide::{cookies::ContextExt as _, forms::ContextExt as _};

This can also be mitigated in Tide for prelude users, if Tide has
pub mod prelude {
    use crate::{cookies::ContextExt as _, forms::ContextExt as _};
}

then a user adding use tide::prelude::*; will still get the effect of importing the methods without the traits.

Having a prelude is certainly useful, and I think we eventually should have one for the most common extension traits, but not all of them would be a part of the prelude right.
So we might have to rethink the naming scheme itself.

Personally I don't mind the as _, and am anti-preludes, so I'm happy to keep using that. (Although I've also had to use it in other places to force importing crates when I don't use any of their items before, so I may be pre-biased).

But don't you think as the ecosystem grows, the number of such imports would be an annoyance to type always.
Though to be fair, most would only be typed once and then forgotten.

A few data points:

RFC-0445 defines the general schema of how to name Ext traits.
https://github.com/rustasync/futures-timer/pull/18 recently went through a similar question, and we settled on FooExt where FooExt as _ can be used to prevent conflicts
In Runtime's time PR we are defining trait impls that may conflict with futures::prelude, but using as _ in the prelude these problems can be evaded.

Given the prior discussion on this thread also, I feel we should go with the schema laid out in RFC-0445, and keep the as _ use in mind if we ever decide to define a prelude.

One thing to keep in mind is that examples should use as _ as well if that's how users are expected to use them (relevant to https://github.com/rustasync/futures-timer/pull/18 as that is currently shadowing futures::prelude::TryFutureExt in the example, which could really confuse users as to why their method calls suddenly stop working when introducing futures-timer).

The discussion here has more or less quieted down. The futures crate is now also shadowing extension traits. It feels like we've reached consensus, and it's okay to close this now (:


Support cbor-raw encoding for messages

Currently roslibrust assumes and only supports default json-encoding.
It looks in the two affected places are Client::handle_publish where messages are decoded (and there's an unwrap assuming the encoding is json) and Writer::publish which assumes the msg is a RosMessageType. It probably makes sense to construct the publisher with an encoding mechanism defined in order to prevent changing the publish/subscribe APIs.
The format of these messages is not extremely well documented in rosbridge_suite's protocol document, nor is it even implemented in roslibpy, but from what I can tell it should produce messages like:
"msg": {
    "bytes": <bytearray>
}

We can make use of serde_rosmsg which implements the correct encoding mechanism, as despite the name it has no relation with cbor other than that their both in binary...

@Carter12s would like to get your take on this since you've written the trait for RosBridgeComm. Currently the API doesn't give a means of expressing the desired encoding:
async fn publish<T: RosMessageType>(&mut self, topic: &str, msg: T) -> RosLibRustResult<()>;

The RosBridgeComm trait is intended as a generic interface to a ROS bridge server, not a generic ROS IPC layer (ROS bridge, TCPROS for ROS1, whatever IPC for ROS2). I think it makes sense to expand the APIs to be encoding aware with an enum of supported transport methods. I think this crate should also define a different trait which is intended to be middleware agnostic (though that's of course completely tangential to this issue).

Ah I see that I misunderstood. cbor-raw is only allowed for subscribers, not for publishers. Publishers seem to be required to use JSON encoding, as there is no compression field for advertise, only for subscribe.

Yeah I think this should be as easy as subscribe() taking an argument about compression and then swapping in a different decode closure into the internal callback queue.
There is a bigger conversation around how to more broadly restructure the crate to support completely different comm backends if/when we want to do something like support ROS1 or ROS2 native protocols, but I don't want to think about that yet. I reality I think we should punt on cbor-raw support for now, and focus more on documentation and tests.


Add MFA login

I modified the login method to support Multi-factor authentication.

I'll update this for the new release

Working on conflicts.


Uses codecov to generate coverage report

Well as the title said, I added codecov support to pdt. Currently we don't have a good percentage of coverage, but this could help us to improve.
Many scripts are learned and copied from https://github.com/falconry/falcon. Thanks!
Coverage report of this pull request branch:

Current coverage is 69.16%

Branch #134 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

oh wow - I have been thinking about doing that refactoring for so long...
HUG
+1 to this


Can't color circles by genes in visium dataset

Hello! I was trying the ROI notebook. I can load the shapes, but when I open the "view" plugin from the plugin menu, I can't color the points.

To reproduce

launch the interactive viewer as specified in ROI notebook
open the "downscaled_lowres" coordinate system by clicking it in the "Coordinate System" list
load the shapes elements by double clicking them
Open the "View" plugin from the plugin menu
Click or double click any of the obs or genes. The circles do not change color. I also tried changing the slider for the colors and I didn't see any change

Do you see the same thing, @giovp and @rahulbshrestha ? Or am I just doing something wrong?

Closed by https://github.com/scverse/napari-spatialdata/pull/73.


Extend IPlacedComponent with world position/orientation getters.

Provide getters on scripting side since RE of property with https://github.com/WopsS/RED4ext.SDK/pull/138.
I tested the code in my own RED4ext plugin up until now, which is working fine. But I haven't tried with Codeware (workspace not configured to build plugin/scripts and test it yet).

Done :)
Is README of RedLib obsolete regarding extension of class properties? Or I'm missing something in this case?

It doesn't have an example for properties.

My bad, should be good now.

Properties cannot be added to existing classes.

I was talking about this note. Which I guess is an old statement?

You can't add properties to a C++ class, but you can register more properties in RTTI.

Alright, well the later was my expectation when using RTTI_PROPERTY, but the note was not explicit to me, I thought it wasn't possible to declare more RTTI properties when extending. I'll write a PR about this.


[BUG] Step 2 of Extended Introduction Failing

Hi Semagrams team,
Thanks for creating the extended introduction! I am running into another error as described below:
I ran into the following error on Step 2 of the extended introduction after I skipped Step 1 per the suggestion of using Semagrams.Examples. With the following example from the introduction:
using Catlab
using Semagrams
using Semagrams.Examples

my_awesome_petri_net = Semagram{ReactionNet{Float64}}(ReactionNetSema)

I get the following traceback:
ERROR:   error: all type parameters to the acset type must be fully instantiated.

  Right: Semagram{WeightedGraph{Int}}(WeightedGraphSema)
  Wrong: Semagram{WeightedGraph}(WeightedGraphSema)

Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:33
 [2] Semagram{Catlab.CSetDataStructures.AttributedCSet{Catlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, Catlab.Theories.AttrDesc{C
atlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, (:N, :L), (:rate, :concentration, :species_label, :transitions_label), (1, 2, 2, 1
), (1, 1, 2, 2)}, Tuple{Float64, L}, (), (), Tables, Indices} where {L, Tables<:NamedTuple, Indices<:NamedTuple}}(ls::LocatedSemagramData)
   @ Semagrams.UI ~/FOSS/Semagrams.jl/src/UI.jl:41
 [3] Semagram{Catlab.CSetDataStructures.AttributedCSet{Catlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, Catlab.Theories.AttrDesc{C
atlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, (:N, :L), (:rate, :concentration, :species_label, :transitions_label), (1, 2, 2, 1
), (1, 1, 2, 2)}, Tuple{Float64, L}, (), (), Tables, Indices} where {L, Tables<:NamedTuple, Indices<:NamedTuple}}(s::SemagramSchema)
   @ Semagrams.UI ~/FOSS/Semagrams.jl/src/UI.jl:77
 [4] top-level scope
   @ REPL[5]:1

caused by: UndefVarError: Ts not defined
Stacktrace:
 [1] (Catlab.CSetDataStructures.AttributedCSet{Catlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, Catlab.Theories.AttrDesc{Catlab.Th
eories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, (:N, :L), (:rate, :concentration, :species_label, :transitions_label), (1, 2, 2, 1), (1, 1
, 2, 2)}, Tuple{Float64, L}, (), (), Tables, Indices} where {L, Tables<:NamedTuple, Indices<:NamedTuple})(; table_type::Type)
   @ Catlab.CSetDataStructures ~/.julia/packages/Catlab/5eZgn/src/categorical_algebra/CSetDataStructures.jl:68
 [2] (Catlab.CSetDataStructures.AttributedCSet{Catlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, Catlab.Theories.AttrDesc{Catlab.Th
eories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, (:N, :L), (:rate, :concentration, :species_label, :transitions_label), (1, 2, 2, 1), (1, 1
, 2, 2)}, Tuple{Float64, L}, (), (), Tables, Indices} where {L, Tables<:NamedTuple, Indices<:NamedTuple})()
   @ Catlab.CSetDataStructures ~/.julia/packages/Catlab/5eZgn/src/categorical_algebra/CSetDataStructures.jl:68
 [3] Semagram{Catlab.CSetDataStructures.AttributedCSet{Catlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, Catlab.Theories.AttrDesc{C
atlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, (:N, :L), (:rate, :concentration, :species_label, :transitions_label), (1, 2, 2, 1
), (1, 1, 2, 2)}, Tuple{Float64, L}, (), (), Tables, Indices} where {L, Tables<:NamedTuple, Indices<:NamedTuple}}(ls::LocatedSemagramData)
   @ Semagrams.UI ~/FOSS/Semagrams.jl/src/UI.jl:39
 [4] Semagram{Catlab.CSetDataStructures.AttributedCSet{Catlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, Catlab.Theories.AttrDesc{C
atlab.Theories.CatDesc{(:T, :S, :I, :O), (:it, :is, :ot, :os), (3, 3, 4, 4), (1, 2, 1, 2)}, (:N, :L), (:rate, :concentration, :species_label, :transitions_label), (1, 2, 2, 1
), (1, 1, 2, 2)}, Tuple{Float64, L}, (), (), Tables, Indices} where {L, Tables<:NamedTuple, Indices<:NamedTuple}}(s::SemagramSchema)
   @ Semagrams.UI ~/FOSS/Semagrams.jl/src/UI.jl:77
 [5] top-level scope
   @ REPL[5]:1

I tried the following suggestion as I thought that "Right" indicated the correct procedure but that failed as well:
julia> my_awesome_petri_net = Semagram{WeightedGraph{Int}}(WeightedGraphSema)
ERROR: UndefVarError: WeightedGraph not defined
Stacktrace:
 [1] top-level scope
   @ REPL[6]:1

I really like the idea of providing the user feedback or correction in the stacktrace! That is super helpful, but maybe I am just misinterpreting what I should do.
Thanks for the help!
~ tcp

Hi @TheCedarPrince,
In the first piece of code, the ReactionNet datatype takes two type arguments: N=Number and L=Label. The following should work (but I might have switched the numbers and strings!):
my_awesome_petri_net = Semagram{ReactionNet{Float64,String}}(ReactionNetSema)

For the second piece of code, you would need to import WeightedGraph:
using Catlab.Graphs

I fixed the ReactionNet type arguments in the docs.

That worked - thanks @sjbreiner.
However, based on what you are saying, it seems like the error traceback could be better improved by changing it from what was said here:
ERROR:   error: all type parameters to the acset type must be fully instantiated.

  Right: Semagram{WeightedGraph{Int}}(WeightedGraphSema)
  Wrong: Semagram{WeightedGraph}(WeightedGraphSema)

To something like this:
ERROR:   error: all type parameters to the acset type must be fully instantiated.

Ensure that you are `using Catlab.Graphs`.

As in the traceback, this gets around the specifics of the graph type and makes it much more broader. In theory, I could imagine it linking back to documentation in some way.
I'll close this issue for now and open a new one - thanks for the speedy help @sjbreiner !


Error fetching Savings Plan Data: QueryAthenaPaginated: athena configuration incomplete

I have installed opencost and then try to integrate AWS cloud cost on it , I have followed all the steps from below doc to setup different things:

Setup CUR
https://docs.kubecost.com/install-and-configure/install/cloud-integration/aws-cloud-integrations#cost-and-usage-report-integration
Setup Athena
https://docs.kubecost.com/install-and-configure/install/cloud-integration/aws-cloud-integrations#step-2-setting-up-athena
Setup IAM Permissions by following file:

module "iam_eks_role" {
  source    = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  role_name = "opencost"
  version   = "5.33.0"

  role_policy_arns = {
    policy = module.iam_policy.arn
  }

  oidc_providers = {
    one = {
      provider_arn               = local.kube_info["oidc_provider_arn"]
      namespace_service_accounts = ["opencost:development-opencost"]
    }

  }
}

module "iam_policy" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-policy"
  version = "5.33.0"

  name        = "opencost_policy"
  path        = "/"
  description = "used for opencost tools"

  policy = jsonencode({

    "Version" : "2012-10-17",
    "Statement" : [
      {
        "Sid" : "AthenaAccess",
        "Effect" : "Allow",
        "Action" : [
          "athena:*"
        ],
        "Resource" : [
          "*"
        ]
      },
      {
        "Sid" : "ReadAccessToAthenaCurDataViaGlue",
        "Effect" : "Allow",
        "Action" : [
          "glue:GetDatabase*",
          "glue:GetTable*",
          "glue:GetPartition*",
          "glue:GetUserDefinedFunction",
          "glue:BatchGetPartition"
        ],
        "Resource" : [
          "arn:aws:glue:*:*:catalog",
          "arn:aws:glue:*:*:database/athenacurcfn*",
          "arn:aws:glue:*:*:table/athenacurcfn*/*"
        ]
      },
      {
        "Sid" : "AthenaQueryResultsOutput",
        "Effect" : "Allow",
        "Action" : [
          "s3:GetBucketLocation",
          "s3:GetObject",
          "s3:ListBucket",
          "s3:ListBucketMultipartUploads",
          "s3:ListMultipartUploadParts",
          "s3:AbortMultipartUpload",
          "s3:CreateBucket",
          "s3:PutObject"
        ],
        "Resource" : [
          "arn:aws:s3:::aws-athena-query-results-*"
        ]
      },

      {
        "Sid" : "S3ReadAccessToAwsBillingData",
        "Effect" : "Allow",
        "Action" : [
          "s3:Get*",
          "s3:List*"
        ],
        "Resource" : [
          "arn:aws:s3:::opencostrty"
        ]
      },

      {
        "Action" : [
          "organizations:ListAccounts",
          "organizations:ListTagsForResource"
        ],
        "Resource" : [
          "*"
        ],
        "Effect" : "Allow",
        "Sid" : "ReadAccessToAccountTags"
      },
    ]

  })

}

--- helm chart values:
---
opencost:
  serviceAccount:
    annotations:
      eks.amazonaws.com/role-arn: "arn:aws:iam::28535656734:role/opencost"
  opencost:
   cloudCost:
    enabled: false
   customPricing:
    enabled: true
    provider: aws
    costModel:
     athenaBucketName: "s3://aws-athena-query-results-test-cost"
     athenaRegion: "eu-central-1"
     athenaDatabase: "athenacurcfn_opencost_cur"
     athenaTable: "opencost_cur"
     projectID: "394279423"
   ui:
    enabled: true
    image:
     registry: gcr.io
     repository: kubecost1/opencost-ui
     tag: "cloudcost"
   prometheus:
    internal:
     enabled: true
     serviceName: prometheus-kube-prometheus-prometheus
     namespaceName: monitor
     port: 9090
   metrics:
    serviceMonitor:
    enabled: true
    namespace: monitor
   exporter:
    defaultClusterId: "default-test-cluster"
    image:
      registry: gcr.io
      repository: kubecost1/opencost
      tag: "cloudcost"
    extraEnv:
      EMIT_KSM_V1_METRICS: "false"
      EMIT_KSM_V1_METRICS_ONLY: "true"
      LOG_LEVEL: error #error
      AWS_PRICING_URL: "https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/eu-central-1/index.json"

opencost container logs:
2024-01-05T08:58:39.23149803Z ERR Failed to lookup reserved instance data: no reservation data available in Athena2024-01-05T08:58:39.231539251Z
ERR Failed to lookup savings plan data: Error fetching Savings Plan Data: QueryAthenaPaginated: athena configuration incomplete

It looks like you've added some new opencost.opencost.costModel.* values that aren't supported in the OpenCost Helm chart. I assume these were lifted from the Kubecost docs you referred to. Take a look at https://www.opencost.io/docs/configuration/#cloud-costs and https://github.com/opencost/opencost-website/blob/main/static/cloudCost-example-output.json for configuring Cloud Costs with OpenCost

thanks for reply @mattray , looks like I have found this values from opencost doc iteslf or I am missing something , please let me know
https://www.opencost.io/docs/installation/helm#example-configuration


Add feasibility to comment the environment configs in .env.config file

The current implement doesn't allow to add comments to the .env.config file as follows,
{
  "HOST": "https://abc.com",
  // "SERVER_URL": "{{BASE_URL}}/api/v1",
}

Related error :
[Configured Env]  {
  error: SyntaxError: Unexpected token / in JSON at position 4
      at JSON.parse (<anonymous>)
      at Object.module.exports.config (/home/APISquare/envone/example/node_modules/envone/src/config.js:136:38)
      at Object.<anonymous> (/home/APISquare/envone/example/index.js:12:41)
      at Module._compile (internal/modules/cjs/loader.js:1075:30)
      at Object.Module._extensions..js (internal/modules/cjs/loader.js:1096:10)
      at Module.load (internal/modules/cjs/loader.js:940:32)
      at Function.Module._load (internal/modules/cjs/loader.js:781:14)
      at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
      at internal/main/run_main_module.js:17:47
}

@suthagar23 since JSON does not support comments are you looking to switch to using something other than JSON or make use of a workaround in JSON to allow comments? I could look into a yml alternative instead or you could go with a format like this:
{
  "HOST": "https://abc.com",
  "__SERVER_URL__": "{{BASE_URL}}/api/v1",
}

It's not the clearest or cleanest but if well documented you can make it clear to use that format for comments. Happy to work on this if you have an opinion on either way.

Hi @mjnagel, First thanks for your interest in this.
Yes, I also would like to have a YML alternative for this (So users can use .env.config or .env.yml). If you want, I can able to create an issue as a new feature and add that. But it might be a huge wight task and needs to be unit tested as well :-)

Next for the above issue,
The problem occurs when we parse the .env.config content in this following way,
const parsedData = parseEnv(JSON.parse(fs.readFileSync(configPath, { encoding: "utf8" })));

So if we are able to add a wrapper to read and remove the commented line(s) from the read file before parsing it, that would be the solution for this.
function parseReadFile(content) {
  // remove commented line or lines
}

const parsedData = parseEnv(JSON.parse(parseReadFile(fs.readFileSync(configPath, { encoding: "utf8" }))));

Okay, I see now! Yes I'd be happy to make a parser to remove the comments if you'd like to assign it to me. I'll have to spend a little time just making sure I follow your code's current formatting and structure but I'd be happy to tackle this.
Totally agree a YML alternative would be a big leap!

I have assigned this task to you. Hope to see your plan soon :-)

@suthagar23 what's the easiest way to test / test if my changes have the desired effect? Working through a func that I think should work...

@suthagar23 I did some initial testing and this PR should add support for single comments like the example you provided in the issue. Not sure if you're looking for something more in depth to support more types of comments? Happy to expand the solution as needed.

Yes, as the first step we can add single line comments and can extend up to multi-line comments later.


Node Eviction failed

before  Node Eviction
kubectl get pod -o wide
NAME                                      READY   STATUS    RESTARTS   AGE    IP             NODE        NOMINATED NODE   READINESS GATES
nginx-local-storage-lvm-77c4b4749-t5hr7   1/1     Running   0          4m3s   <IP_ADDRESS>   k8s-node1   <none>           <none>

Eviction
kubectl drain k8s-node1 --ignore-daemonsets=true --delete-emptydir-data

after Node Eviction
kubectl describe pod nginx-local-storage-lvm-77c4b4749-rjqvn
Name:           nginx-local-storage-lvm-77c4b4749-rjqvn
Namespace:      default
Priority:       0
Node:           <none>
Labels:         app=nginx-local-storage-lvm
                pod-template-hash=77c4b4749
Annotations:    <none>
Status:         Pending
IP:
IPs:            <none>
Controlled By:  ReplicaSet/nginx-local-storage-lvm-77c4b4749
Containers:
  nginx:
    Image:      nginx:latest
    Port:       80/TCP
    Host Port:  0/TCP
    Command:
      sh
      -xc
      VOL="$( df | grep /usr/share/nginx/html | awk '{print $1,$NF}' )"
      echo "
Demo volume: ${VOL}
" > /usr/share/nginx/html/index.html
      nginx -g "daemon off;"

    Limits:
      cpu:     100m
      memory:  100Mi
    Requests:
      cpu:        100m
      memory:     100Mi
    Environment:  <none>
    Mounts:
      /usr/share/nginx/html from html-root (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-2mfsr (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  html-root:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  local-storage-pvc-lvm
    ReadOnly:   false
  kube-api-access-2mfsr:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Guaranteed
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason            Age                From                  Message
  ----     ------            ----               ----                  -------
  Warning  FailedScheduling  82s                hwameistor-scheduler  0/3 nodes are available: 1 node(s) had taint {node-role.kubernetes.io/master: }, that the pod didn't tolerate, 1 node(s) were unschedulable, 1 not right node.
  Warning  FailedScheduling  11s (x1 over 82s)  hwameistor-scheduler  0/3 nodes are available: 1 node(s) had taint {node-role.kubernetes.io/master: }, that the pod didn't tolerate, 1 node(s) were unschedulable, 1 not right node.

[root@k8s-master ~]# kubectl get ldc
NAME     NODEMATCH   PHASE
node-1   k8s-node1   Bound
node-2   k8s-node2   Bound
[root@k8s-master ~]# kubectl get pvc
NAME                    STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS            AGE
local-storage-pvc-lvm   Bound    pvc-e6c343fa-d285-44e5-b74b-5c802d14d5cb   1Gi        RWO            local-storage-hdd-lvm   8m15s
[root@k8s-master ~]# kubectl get node
NAME         STATUS                     ROLES                  AGE   VERSION
k8s-master   Ready                      control-plane,master   76d   v1.23.3
k8s-node1    Ready,SchedulingDisabled   <none>                 76d   v1.23.3
k8s-node2    Ready                      <none>                 76d   v1.23.3
[root@k8s-master ~]# kubectl get lvr
NAME                                              CAPACITY     NODE        STATE   SYNCED   DEVICE                                                                  AGE
pvc-e6c343fa-d285-44e5-b74b-5c802d14d5cb-vmldjt<PHONE_NUMBER>   k8s-node1   Ready   true     /dev/LocalStorage_PoolHDD-HA/pvc-e6c343fa-d285-44e5-b74b-5c802d14d5cb   9m53s

The version is wrong, evictor related components are missing


WIP: Fix multiple active actor reminders

Signed-off-by: Joni Collinge<EMAIL_ADDRESS>Description

Issue reference

Please reference the issue this PR will close: #4419
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

I've been running test cycles for about 2 hours and I haven't seen the issue repro since.

Might update the log so it includes the other host address


chore: add api_shortname and library_type to repo metadata

Update .repo-metadata.json as required by go/library-data-integrity

@losalex the logic for warning on README updates is giving a false positive in this case, the README is generated automatically from .repo-metadata.json, so this is not a manual change.

@losalex the logic for warning on README updates is giving a false positive in this case, the README is generated automatically from .repo-metadata.json, so this is not a manual change.

Sure, thanks @bcoe for clarification!


Rename flatten array to flatten

@treyhunner wrote

Opened from a discussion in exercism/xpython#374.
I think this exercise should be renamed to use more generic terminology.  flatten is sufficiently generic.  Arrays in Python are different than lists and are not frequently used.

There is further discussion about what is required in this closed pull request: https://github.com/exercism/x-common/pull/412
If you wish to work on this, I suggest reading that issue and posting a plan of action to this issue for review before proceeding with the pull request(s) required to implement the changes.

For those considering performing this rename, there could be some useful information in https://github.com/exercism/discussions/issues/12


Accept WINDOW clause after QUALIFY when parsing

This PR is based on https://github.com/sqlparser-rs/sqlparser-rs/pull/1218 from @iffyio which needed to have conflicts resolved.
I merged up to main, and fixed conflicts, but I don't have permissions push directly to the upstream branch https://github.com/validio-io/sqlparser-rs/tree/window-qualify-ordering so I made a new one
Closes https://github.com/sqlparser-rs/sqlparser-rs/pull/1218
Description from that PR:

The positioning of QUALIFY and WINDOW clauses differ between dialects.
BigQuery requires that WINDOW clauses come after QUALIFY which fails on the parser as a result.
This updates the parser to accept the clauses in either order.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

28 of 28 (100.0%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 89.212%

Files with Coverage Reduction
New Missed Lines
%

src/lib.rs
2
11.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
24280

Relevant Lines:
27216

💛  - Coveralls


Declare global variables

This caused warnings with setopt warn_create_global

Ross Penman wrote on Wed, Aug 31, 2016 at 07:56:33 -0700:

This caused warnings with setopt warn_create_global

Thanks, pushed with a log message tweak.


sep31: /info endpoint

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Implement the Sep31 /info endpoint.
Why
Known limitations

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr154.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr154.previews.kube001.services.stellar-ops.com/


When i run watch the error are showing in the windowns notification not in the console, how i can change that ?

Laravel Mix Version: #.#.# (npm list --depth=0)
Node Version (node -v):
NPM Version (npm -v):
OS:

Description:
Steps To Reproduce:

This fixed it for me https://github.com/JeffreyWay/laravel-mix/issues/2680

Ha this was incredibly frustrating, thanks @jonXmack for the workaround


How to detect user which plan has ?

Hi is there any way to detect the user which plan has ( SIMPLE START, ESSENTIALS, PLUS or SELF-EMPLOYED) with api?

Try $dataService->Query("select * from CompanyInfo");


Upload file to a specific folder

Hi, I've been looking at the examples and I can't find anything about this.
Thx

Do I have to first send the file and then move it?

I just fixed it.
For those newbies like me, you have to copy the folder ID and use it as argument on files.Parent (similar to the example of file.create with appDataFolder)

Did you have any issue with files being created at the root of your Gdrive even when the folder ID is provided in the file.Parent when on device? Works fine for me in Editor but on IOS the files upload to the root of my google drive instead of the folder specified as parent

Did you have any issue with files being created at the root of your Gdrive even when the folder ID is provided in the file.Parent when on device? Works fine for me in Editor but on IOS the files upload to the root of my google drive instead of the folder specified as parent

Hi,
At the end I used the Google API instead. Is not difficult to use


Make this doc more like Magnet Segmentation Toolkit doc

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e9c1423) 85.46% compared to head (3701fd5) 85.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   85.46%   85.46%
=======================================
  Files          12       12
  Lines        3137     3137
=======================================
  Hits         2681     2681
  Misses        456      456

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@Samuelopez-ansys There is no docstring (description) for the autoattribute Antenna_type. I know the meaning is obvious, but the summary table looks odd as it's the only property without a description. I just thought I'd point this out. I'm OK with you merging this PR as is--but I thought you'd appreciate the suggestions noting things that could perhaps be improved (now or later). Please merge this PR when you are satisfied with it. It's way better than it was and will continue to evolve!


updated user-routes.js to use expiredIn

updated expiresInMinutes which is deprecated to expiresIn.

Thanks for this :) just merged an older PR that addressed the issue.


fix autocomplete url params

Replaced ?&input with ?input in autocomplete request url, this should fix filtering by type #686.
P.S. This is my first contribution to open source, please let me know if I did something wrong.

Good catch, and thank you for the PR!
My testing shows that this does not resolve #686, but it might still be worth merging this PR.
I always thought that adding an & before the first query param made a difference.
I would like to get some more clarity on the issue that you are having, which is different than the issue #686 was created for.

Hello, sorry for late response, had a busy week.
I haven't tested the issue @tgreco has in #686, however this should fix many potential filtering errors as it seems that Google has problems parsing ?& in params.
Although I described the issue in #686, I will describe my steps to give more clarity:

I added types param to query (along with other params as key, ...)

query={{
        types: "address",
      }}

Filtering by type didn't work - results included cities, countries, businesses, etc.
I analysed the source code and found ?& in request query
Removing the & solved my issue and search results were properly filtered (included only type "address")

According to Wikipedia, query params should look like that: https://example.com/path/to/page?name=ferret&color=purple (note ? before first param, & before other params)

multiple query parameters are separated by the ampersand, "&"

Source

Sorry for the delay in getting this out.
Released as v2.3.0


Cannot load to menu

Describe the bug
This is my first time playing the modpack. I've downloaded it off of curse. The current version is 0.14.1.
Upon pressing play, the pack seems to load through the initial forge loading phase, but then crashes in the middle of it, preventing gameplay completely. I've tried running with the minimum and recommended ram usage and around 10GB. I've had the same issue with or without optifine and even after reinstalling the whole pack.
To Reproduce
Steps to reproduce the behavior:

Start the pack new,
Try to play the pack.

Expected behavior
I expect the pack to not crash on startup and allow me to play the game as expected.
Reports (please complete the following information using a website like pastebin):
latest.log - https://pastebin.com/7CHGKM3H

@Spyrox17 Try disabling FoamFix in the modlist before starting the pack up again.

Yep that fixed it.


Change out Node-Sass for Dart-Sass

Is your feature request related to a problem? Please describe.
Currently in the project you are using node-sass for sass compiling. Since libsass is deprecated basically so is node-sass and it would be nice to use a sass that was up to date with releases.
Describe the solution you'd like
Changing the compiling sass to Dart-Sass would allow users to use and be up to date with sass features and get away from a lot of errors and headaches that revolve around the use of node-sass
Describe alternatives you've considered
Any alternatives are staying with node-sass. Which, even though it works, may not be ideal in the long run.

Thanks, @Hadr619. I've got a pull request ready for this one—it'll ship in the next release.


add multilingual support

Adds support for multilingual sites.
No changes to config.toml are necessary for single language sites; there are defaults for everything.
Most code has been copied over (and adapted) from Abridge: https://github.com/Jieiku/abridge/issues/105.
Switching language sends the user to the same page in the selected language (/archive, a particular post…). If this translation does not exist, the 404 is shown, which now includes this error in each language set in the config:

The page you requested doesn't seem to exist or has not been translated to your language yet. Check the URL for errors, or return to the homepage.

The "return to the homepage" part is a link to that language's homepage.
The intended use for this is keeping the same content in each language. It could be easily adapted so that the switching of languages takes you to the new language homepage, instead of looking for the article's translation.

Hey, I seen the link from abridge and took a look, this reminded me that I never finished the 404 page. I adapted some of your 404 page into mine just now.


ImportError: No module named _caffe

Hello,
I am trying to run the eval_net.py example in the README description, but I get
"ImportError: No module named _caffe".  I am running in an Anaconda environment.  Everything seemed to install OK with no errors.
I run the command
python tools/eval_net.py ucf101 1 rgb UCF-101_frames/ models/ucf101/tsn_bn_inception_rgb_deploy.prototxt models/ucf101_split_1_tsn_rgb_reference_bn_inception.caffemodel --num_worker 4 --save_scores scoresOutput.txt
I get:
Traceback (most recent call last):
File "tools/eval_net.py", line 38, in
from pyActionRecog.action_caffe import CaffeNet
File "/data/torres/temporal-segment-networks/pyActionRecog/action_caffe.py", line 4, in
import caffe
File "./lib/caffe-action/python/caffe/init.py", line 1, in
from .pycaffe import Net, SGDSolver
File "./lib/caffe-action/python/caffe/pycaffe.py", line 13, in
from ._caffe import Net, SGDSolver
ImportError: No module named _caffe
I have tried to read through google posts for this error, but they all refer to the standard Caffe installation, including the "make pycaffe" part of it.  Your installation is customized and therefore different :)
Do you have any suggestions for me?
Thank you,
Frank Torres
Palo Alto Research Center

This indicates you didn't build the Python bindings of Caffe. The make pycaffe command is also for this.
We use CMake, it will automatically build the Python bindings once all dependencies are met. Please check whether you followed the steps in build_all.sh.

Thank you.  It took some time, but I figured out my problem.  I had corrupted boost files deep in installs and updates.  I needed to completely clean boos off my compute server and then reinstall fresh.  now it works.
Best,Frank
  From: yjxiong<EMAIL_ADDRESS>
To: yjxiong/temporal-segment-networks<EMAIL_ADDRESS>Cc: Frank Torres<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Sunday, January 29, 2017 7:27 PM
Subject: Re: [yjxiong/temporal-segment-networks] ImportError: No module named _caffe (#49)
This indicates you didn't build the Python bindings of Caffe. The make pycaffe command is also for this.We use CMake, it will automatically build the Python bindings once all dependencies are met. Please check whether you followed the steps in build_all.sh.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for sharing your solutions!
Closing this issue as it is resolved.


Update supported LCD Controllers for RGB example.

Update supported LCD Controllers for RGB example.

Merged into PR #78.


combobox keyboard navigation bug in filtering example

Description
the issue is reproducible on park-ui website, but I get it too using ark-ui 3.5.0
currently on my website the old version is working properly https://arek-ui.arexoft.com/?q=Combobox
when I enter the example https://park-ui.com/react/docs/components/combobox,
click on combobox in demo,
using keyboard select "React",
then using keyboard delete the value to be empty, and using down arrow select "Vue" from the list
after clicking "Enter", "React" value reappears even tough I have just selected "Vue"
Link to Reproduction (or Detailed Explanation)
https://park-ui.com/react/docs/components/combobox
Steps to Reproduce

go to https://park-ui.com/react/docs/components/combobox

click on combobox in demo

using keyboard select "React",

then using keyboard delete the value to be empty, and using down arrow select "Vue" from the list

after clicking "Enter", "React" value reappears even tough  "Vue" was just selected

Ark UI Version
3.5.0
Framework

[X] React
[ ] Solid
[ ] Vue

Browser
Google Chrome
Additional Information
I have the same problem with my components after trying to upgrade to ark-ui 3.5.0

I can't reproduce this in Zag.js or Ark UI docs. So it's probably related to how this is set up in Park UI.
Perhaps it's already fixed but not released cc @cschroeter

Here's a repro sandbox, after some clicking around on different options, the inputValue and value get out of sync (look at the console).

I have no idea why the ark-ui docs work and this repro, park demo and my own components don't
they seem to be almost exactly the same

After some digging, I found that this was a regression in Zag.js and was fixed in the last two releases.
We need a new release @cschroeter to resolve this issue.

New version has been released.
If the issue persists after the release, I'll re-open it.


usrsctp: fix build with clang 15+

Description of changes

Add missing function prototypes; and
Remove set but unused variables.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I don't think it's a good idea to update this library to some random commit. Maybe there's a way to fix this clang16 issue while still using a tagged release.
Also this change should go to the staging

I updated the PR with a patch to remove the unused variables and add the missing prototypes. I initially tried applying the commits from upstream FreeBSD that did this, but they didn’t apply cleanly. I also retargeted to staging.


refactor: export localnet and tasks in separate packages

You can now do:
npx hardhat localnet --anvil "--block-time 1" --port 2000

Added ability to init localnet without starting anvil (in case a user wants to start anvil on their own).


Why isn't this populated in the KiCad PCM?

Thanks for your work. I like the plugin and I think some time ago this was listed in the PCM. Things changed? Or is there another plugin to achieve the same and there is a reason to tidy up the official PCM repo?

@g200kg Any comments if this is planned?
see https://gitlab.com/kicad/addons/metadata

@g200kg Alive? 😉


Easy reference of JS files

Move JS files to output directory on build and reference them without knowing the directory structure.

Let's implement this with cpplocate


integrations: Prevent duplicate PR review messages

Add condition in view to check if the edited pull
request review has any changes, so it does not send a message when it does not.
Add test that verify that the condition works.
Fixes #26145

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Hi nice work here, code LGTM!
One thing that I'd like to point out is the format of the commit message. I'm sure you're already aware of the commit discipline. I highly recommend the zulip git repo tool, it checks your commit style every time you commit. For example, here's the lint output for your commit message:

Other than that, @sbansal1999 do you think this issue needs another reproducer to confirm the root cause of the bug we're trying to fix in this PR? From your discussion with Greg, here it looks like you and Greg were still doing some investigation. CMIIW

@lumpleme Do you plan to continue working on this PR?

@lumpleme @alya I'll pick up this one

Closing as this issue was solved in #30848. Thanks for the work here, @lumpleme !


Suggested changes for https://github.com/gradle/gradle/pull/18865

See https://github.com/gradle/gradle/pull/18865
No breaking public API change required. The binary compatibility check still fails validation because of the added kotlin extensions that must either be @Incubating or accepted as stable.

@bot-gradle

Sorry I don't understand what you said.
Currently, the following commands are supported:
@bot-gradle test <BuildStage>

triggers the specified build for this PR. This command takes a single argument, i.e. @bot-gradle test QF.  Common stages are:

SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease
Shortcuts: SC/CA/QFL/QF/RFM/RFN/RFR
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACC: AllConfigCacheTestsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle test and merge

queues this PR for testing and merges if all tests pass by:

Creating a merge commit from your PR branch HEAD and the target branch
Running a ReadyForNightly build against the merge commit
When it passes, fast-forward the target branch to this merge commit (i.e. merge the PR)

The merge commit is called a pre-tested commit, which means that it fully tests the integration
of your branch HEAD and latest master, instead of only testing your branch HEAD.
@bot-gradle cancel

cancel a running pre-tested commit build or remove it from queue

@bot-gradle clean

clear the conversation history

@bot-gradle help

display this message

To run a command, simply submit a comment.  For detailed instructions see here.

@bot-gradle test SC

OK, I've already triggered SanityCheck build for you.


Libscap symbols

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver
/area libscap-engine-noop
/area libscap-engine-source-plugin
/area libscap-engine-udig
/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
This ensures that we export various symbols required to build on macOS (and likely Windows).
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: geraldcombs
To complete the pull request process, please assign molter73 after the PR has been reviewed.
You can assign the PR to them by writing /assign @molter73 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Note that this leaves the Linux-only libraries (scap_event_schema, scap_engine_bpf, scap_engine_kmod, and scap_engine_modern_bpf) separate. I can look at consolidating those as well if needed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: geraldcombs
Once this PR has been reviewed and has the lgtm label, please ask for approval from fededp by writing /assign @fededp in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @geraldcombs ! I propose a fix in https://github.com/falcosecurity/libs/pull/502; can you take a look?
Note that i also enabled sinsp-example build for windows and macos, to be able to test linking phase :)

Closing in favor of #502.


Make Rosetta DB acquisition more granular

This makes the pool acquisition more granular, only acquiring a resource
from the DB pool for foo/bar when foo/bar actually uses the DB resource
rather than any time foo uses it for any foo/baz.
Concretely, this means we now only acquire a DB resource for:

network/status
account/balance
block and block/

Previously we acquired it for all subroutes except construction/*.
(Though we actually could've already removed it trivially for mempool/*
without this refactor.)
To test I tried hitting network/list with archive-uri set and unset and saw it works both times. I also confirmed that before this change if archive-uri wasn't set it returned a SQL error. I also ran the Rosetta test suite and rosetta-cli tests.
Checklist:

[x] Document code purpose, how to use it
[x] Tests were added for the new behavior
[ ] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? List them:

Closes #7690
Closes #8001

!approved-for-mainnet

!ci-build-me


fix generating valid OPDS feeds

Thanks for merging :-)
I realize this project is still very much a work in progress, but I was actually thinking of using it to generate optional OPDS 2.0 feeds with COPS for those who're interested.
Of course, right now php-opds only generates OPDS 1.2 (which is more than well covered by COPS itself), but I wanted to give the integration a first try - and it seems to go OK for the most part. So next I'll try OPDS 2.0 once your 0.4.0 release is out ;-)
One thing I did find lacking in php-opds so far was the possibility to add other navigation links in book entries, e.g. to series, authors, tags, ... Something to think about...

Thanks to you for your improvements!
Yes, this package is not really ready for production, I have to add a warning about this. I will works on 2.0 when I will have some time, in next weeks. Do you know some reader with 2.0 parser? Because it's just a draft for now https://specs.opds.io/
I will think about this option for navigation, thanks for suggestion!

According to https://github.com/opds-community/awesome-opds at least Aldiko, Thorium Reader and any apps based on Readium toolkits should support OPDS 2.0 feeds - including all those listed at https://github.com/readium/awesome-readium
I don't know whether any specific hardware e-book readers support it, but internet standards tend to take a long time as draft before they become an actual spec. And this one has been around for 5 years, and it's a subset of the larger Readium Architecture, so I'm sure there are enough practical use cases to try it out :-)


Panic when calling UploadStreamToBlockBlob with invalid credentials

Which version of the SDK was used?
0.13.0
Which platform are you using? (ex: Windows, Linux, Debian)
Mac
What problem was encountered?
Calling UploadStreamToBlockBlob  with wrong credentials throws panic
The reason for that is that is that copyFromReader returns without waiting for goroutines to end ( In case of error)
How can we reproduce the problem in the simplest way?
I ran into this bug when I  Called UploadStreamToBlockBlob with a ~11MB size file with invalid credentials.
However a simple way would be to run this test
func Test_CopyWithErr(t *testing.T) {
	ctx := context.Background()
	p, err := createSrcFile(_1MiB * 12)
	if err != nil {
		panic(err)
	}
	defer os.Remove(p)

	from, err := os.Open(p)
	if err != nil {
		panic(err)
	}

	br := newFakeBlockWriter()
	defer br.cleanup()

	br.errOnBlock = 1
	transferManager, err := NewStaticBuffer(_1MiB, 1)
	if err != nil {
		t.Fatal(err)
	}
	defer transferManager.Close()
	_, err = copyFromReader(ctx, from, br, UploadStreamToBlockBlobOptions{TransferManager: transferManager})

}

Have you found a mitigation/solution?
yes, calling wait() before returning the error

@guy-har Hi! This issue should be resolved with the new version!


Additional undocumented filter comparisons

By playing with the API, I find that comparisons other than = are supported in filters.  For example, date>=2020-07-01 and date<2020-07-15 .  To obtain results for e.g. all nations you can specify areaType=nation and areaCode!=Q (Q here is arbitrary; I find that omitting any filter for areaName or areaCode results in an error).
Assuming these comparisons are intended to be supported (perhaps they are experimental?), it would be good if they were documented.

Hi @infinnovation-dev
Well, they have been implemented intentionally, so they are indeed intended. But also yes, they are still experimental, which is why they haven't been formally released. They are really intended to be used against the date filter only. Well, they're not really useful when it comes to other filter metrics... In fact, they were initially implemented to facilitate data extraction between 2 specific dates.
One reason they have not be announced - for instance - is we have found that the use of conjunctive and disjunctive filters with the date metric tends to result in unexpected responses.
My main objective and priority right now is to enable the means to include multiple areaName / areaCode metrics. That seems to be a functionality that users really want. I received a suggestion from one of the users today - and it might just work.
Rest assured that we will document every single functionality / metric as soon as they pass QA.

Thanks for your quick response @xenatisch , I understand your situation.  I'll note in passing that e.g. using areaCode>=W00000000 and areaCode<=W99999999 seems successfully to pick all Welsh areas.


Add Services section in HomePage

Description
For understanding of UI/UX check here
Make sure the page is responsive in MOBILE , TAB . DESKTOP , LAPTOP
Add screenshots for the same.
Screenshots

Additional information
Guidelines ⚠
I will follow the Setup Guidelines
I will follow the Contributing Guidelines
I will follow the Code of Conduct

Notice ⛔
You will make PRs only to itsroy69-doctalk branch.
Commit message / PR title--> fix: bla bla bla
Please make sure in the .css files you are making/using , the styles should be applied to Unique Class names

Completed / Doubts ? 🚀
Once you are done with the code , please tag me in #milan with the Screenshot of whatever you made so that we can review that there together.
If you have any doubts, queries please tag me in #doctalk so that we can discuss the issue there together.
Cheers 🥂

Can I work on this issue?

assigned


Feature test macros needed

Time.c needs _xopen_source and parse.y needs something related to isascii gcc automagically defines the kitchen sink with _gnu_source I'll work on this later if no one else picks it up

@matz I think this can be closed as "time" is since a long time a gem. also a missing gmtime_r seems to be handled graceful via NO_GMTIME_R

thanks.


chore: release v0.2.1

🤖 New release

daktilo: 0.2.0 -> 0.2.1

Changelog

[0.2.1] - 2023-10-05
🐛 Bug Fixes

(cd) Use a custom token for triggering release workflow - (0f8dcdc)

📚 Documentation

(readme) Give more details about cargo (#30) - (91c8e94)
(release) Update release instructions - (59101b5)

This PR was generated with release-plz.

Codecov Report
All modified lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:loudspeaker: Thoughts on this report? Let us know!.


PowerShell Extension doesn't appear in Extension Search

Azure Data Studio Version:
Version: 1.5.1 (system setup)
Commit: 6a500715a7f2a9c5466d66b3cc312308bf59846d
Date: 2019-03-16T01:14:53.392Z
VS Code 1.30.1
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134
Steps to Reproduce:

Search for any of the following in the extensions:
PowerShell
Power Shell
Power
Shell

None of these show the PowerShell extension. Searching through the popular extensions allows you to be able to Install however.

@brettmillerb Thanks for reporting the issue, we have fixed it.


Add MarkupEditor

Adds a module to select markup fiducials using a markup
curve node and sets their selection state
when you are done placing the curve points.
If we like the way this works it could be the basis
for other edit operations like splitting lists, cut/copy/paste
between lists, etc.

Requires this change to slicer core https://github.com/Slicer/Slicer/pull/5041 which was just merged so this can be tested against tomorrow's nightly build.


Bugfix/Disabling of chatbotBotConfig.fullFileUpload when share chatbot updated.

Close #3707

thanks @richersoon , just merged in another PR https://github.com/FlowiseAI/Flowise/pull/3713 that also fix the issue. closing for now


Sync failed. Please check your network condition. 04

The more we know about your system and use case, the more easily and likely we can help.
Environment info

OS: Windows
App Version (Command/Ctrl + ,): 1.9.1 (Info from log file. (Shortcut does not work since failure denies that)

Description of the problem / feature request / question:
Want to auth through GitHub. It says that the Sync failed, condition 00 or 04.
Obviously my connection is running since i can send this issue :D
similar issue as #454

Sorry, manually updated to 1.9.2. Problem was fixed! Thanks for this tool!


[documentation] #2544: Tutorial doctests

Signed-off-by: 6r1d<EMAIL_ADDRESS>

Description of the Change
Adds example that mirrors tutorial examples, so that changes in the API can be propagated by directly taking them from GitHub.
Issue
Addresses #2544

Benefits
Direct connection to tutorial
Possible Drawbacks
More code to test
Usage Examples or Tests [optional]
cargo run --example tutorial

Alternate Designs [optional]
As test

TO-DOs:

[ ] Add a deprecation warning (#[deprecated]) into http.rs's new, since it is being superseded by try_new.
[ ] #[must_use] is redundant for try_new.
[ ] There's some code that should be added to the examples

Documentation check currently stops, because it sees the ^ character, caused by the example warning:
if cargo doc -q 2>&1 | grep '^'; then exit 1; fi

My first attempt at fixing the code failed, but I'll try more.

I have to extend expect with actual error messages.


people

faculty and staff page as on origal site
Data from JSON
No hardcoding

Created PR!

What about the footer? It doesn't stick to the bottom of the page. An easy workaround could be to add a custom css rule to all the pages where the content is less than the screen size as bottom: 0. But if there is a better way, that you know of we can do that.


Draft: Particle fuel modeling

Provides a yaml-interface for

modeling particle fuel with arbitrary layers
multiple particle fuel types in the reactor
assigning particle fuel as children to some parent component

We have been decently successful with these changes internally in that
downstream plugins can see Component.particleFuel and perform actions
based on their content. What follows is an overview of the interface,
implementation, and a discussion of where to go next.
Related to https://github.com/terrapower/armi/issues/228 and
would support modeling the MHTGR-350 benchmark
https://github.com/terrapower/armi/issues/224
This patch is submitted to kick-start a discussion on better ways to add
this feature into ARMI, leveraging the domain knowledge of the ARMI
developers and the "particle fuel aware" plugins internally developed at
USNC Tech.
Input interface
particle fuel:
    demo:
        kernel:
            material: UO2
            id: 0
            od: 0.6
            Tinput: 900
            Thot: 900
            flags: DEPLETABLE
        buffer:
            material: SiC
            id: 0.6
            od: 0.61
            Tinput: 900
            Thot: 900

matrix:
    shape: Circle
    material: Graphite
    Tinput: 1200
    Thot: 1200
    id: 0.0
    od: 2.2
    latticeIDs: [F]
    flags: DEPLETABLE
    particleFuelSpec: demo
    particleFuelPackingFraction: 0.4

With this interface it's possible to define several specifications
in the model and assign them to different cylindrical components.
Implementation
The particle fuel is stored as a child of the parent component, such
that <Circle: Matrix>.children is used to dynamically find the particle
fuel spec. We can't store the specification as an attribute because we
have to support potentially dynamic addition and removal of children to this
component. Something like self.particleFuel = spec that makes spec a
child would also have to understand what happens if we remove the spec
from the parent, e.g., self.remove(self.particleFuel). What is then the
outcome of self.particleFuel unless we always check the children of the
matrix?
By making the particle fuel spec a Composite and placing it in the
.children of the parent, the spec is able to be written to and read
from the database.
Adds Component.setParticleMultiplicity. The method is called during
block construction when the block's height is available to the matrix
component (particle's parent). The multiplicity is determined from the
matrix volume and target packing fraction.
Note: the particle mult is, by design, for a single component.
Unresolved issues

Volume of the parent matrix is not reduced by the volume occupied
by the particles.
No support for homogenizing regions that contain particle fuel
Various homogenization properties don't account for particle fuel
(e.g., Core.getHM*)
Particle fuel is not included in some text-reporting, leading to
statements like

[info] Nuclide categorization for cross section temperature assignments:
       ------------------  ------------------------------------------------------
       Nuclide Category    Nuclides
       ------------------  ------------------------------------------------------
       Fuel

and
[warn] The system has no heavy metal and therefore is not a nuclear reactor. Please make sure that this is intended and not a input error.

No provided routines for packing the particles into their parent. This
could be facilitated with a dedicated packing plugin and an unstructured
3-D SpatialGrid class. It's burdensome to expect the user to define
the exact location of every particle every time. But, if some Plugin
performs the packing and creates this spatial grid, the multiplicity is
tackled, and you potentially avoid adding or removing particles as their
parent expands or contracts.
Unsure if material modifications make their way down to the materials
in the particle fuel spec. The implementation suggests it as the matMods
argument is passed into the particle fuel YAML object constructor. But
we have yet to stress test that

Next steps
This patch is submitted because we continue to find places where this
approach does not play well with the rest of the ARMI stack. While Blocks
that contain particle fuel are correctly able to compute their heavy
metal mass by iterating over their children, which in turn finds the
particle fuel. However, higher-level actions like Core.getHM* do not
go down to the sub-block level, instead asking to homogenize Blocks.
The homogenization methods are not yet aware of the particle fuel because
they rely on Component.getNuclides which reports the nuclides for it's
Material, and does not include the children.
This approach is sensible because if I'm writing a neutronic input file
and I can exactly model the matrix and it's particle fuel, I would expect
matrix.getNuclides to return the nuclides for just the matrix. Then,
being informed of the particle fuel, I can write those materials and geometry
uniquely. However, codes that cannot handle particle fuel and/or work
with homogenized regions (e.g., nodal diffusion) would need this
homogenized data. Allowing Component.getNuclides to return the nuclides
on the child particle fuel would support this case, but not the previous case.
My speculation is that the optimal strategy lies somewhere in making the
matrix object not a Component but a Block and having the ARMI Composite
tree accept blocks that potentially contain blocks. I think this is valid
using the API but the user interface would need some work. Having the matrix
be a block would provide a better interface for homogenization and exact
representation of the particle fuel. I think...
Other related changes
Added Sphere.getBoundingCircleOuterDiameter so that the particle fuel
composites can be properly added to the database. They need to be
"sortable" other wise Database3._createLayout breaks trying to sort
components. This enables the particle fuel spec to be added to and read
from the HDF data file
The material constructor is a more public function as it is needed both
in creating Components but also in creating the particle fuel spec.
Added MATRIX flag
Signed-off-by: Andrew Johnson<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@drewj-usnctech  Thanks so much!
Sorry, we had some staff turn-over recently, so between that and Thanksgiving I haven't been at my usual response rate.  This is really interesting though.
Thanks for all the work you put into this. Nick and I were looking at it over lunch.  Hopefully we'll be able to think about this "next steps" and "unresolved issues" a bit more.

Thank you for the fantastic comments. I'm going to direct most of the higher level comments to https://github.com/terrapower/armi/discussions/503 and maybe sometime next week we could arrange a longer conversation

(comments originally for the discussion got too focused on this implementation so moving them here)
I think the larger goal of this #503  (blocks containing composites not just components) would help greatly here. You could then model the particle fuel compact as a Block containing

matrix cylinder to give fixed spatial boundaries (id > 0)
matrix derived shape to fill in the space inside the bounding cylinder
individual components making up the spherical layers

Then the parent block(for something like MHTGR-350 // #224) could have children like

bounding hexagonal duct
derived shape for the graphite block
circles for the coolant holes
sub-block representing the compact

The YAML builders could be updated to expect either a shape argument to build a component or another key (sub-block?) to refer to another block that is already defined in the blueprint, e.g., compact.
And then, because the packing fraction is so specific to this application, it might need it's own section just to say "that block that uses this specific sub-block, use this packing / volume fraction." Other plugin changes would likely be needed in order to convert the packing fraction to spatial locations. But if there's some 3-D grid structure that acts like armi.reactor.grids.Grid, then you could get multiplicity and packed locations inside the compact from that.

@ntouran - want to make sure that this is still in progress as it's been open for some time now. I see that you have a separate PR open, but are there any other changes here that are needed once that PR lands?

Closing in favor of #702


Fixing the errors in the Code

The bugs are fixed #651

@Raj-Banerjee start contributing here https://github.com/Ishaan28malik/Get-Dev-Resources


humble macos

From @srmainwaring , which gets this working on macos.

Testing results: rviz crashing:
$ source install/setup.bash
not found: "/home/rfriedman/Dev/geo_ws/install/grid_map_demos/share/grid_map_demos/local_setup.bash"
rfriedman@dev-rfriedman01:~/Dev/geo_ws$ ros2 launch grid_map_geo load_tif_launch.xml
[INFO] [launch]: All log files can be found below /home/rfriedman/.ros/log/2023-10-28-19-14-42-651535-dev-rfriedman01-27705
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [static_transform_publisher-1]: process started with pid [27711]
[INFO] [test_tif_loader-2]: process started with pid [27713]
[INFO] [rviz2-3]: process started with pid [27715]
[static_transform_publisher-1] [INFO] [1698542083.082540979] [world_map]: Spinning until stopped - publishing transform
[static_transform_publisher-1] translation: ('0.000000', '0.000000', '0.000000')
[static_transform_publisher-1] rotation: ('0.000000', '0.000000', '0.000000', '1.000000')
[static_transform_publisher-1] from 'world' to 'map'
[rviz2-3] /opt/ros/humble/lib/rviz2/rviz2: symbol lookup error: /snap/core20/current/lib/x86_64-linux-gnu/libpthread.so.0: undefined symbol: __libc_pthread_init, version GLIBC_PRIVATE
[ERROR] [rviz2-3]: process has died [pid 27715, exit code 127, cmd '/opt/ros/humble/lib/rviz2/rviz2 -d /home/rfriedman/Dev/geo_ws/install/grid_map_geo/share/grid_map_geo/launch/config.rviz --ros-args -r __node:=rviz2'].


Add runner user to sudoers and bump Docker version

Hi, a small PR as discussed in #22. Thanks

@vitobotta Thanks! I'll review this asap.
@summerwind Should we add a field to the Runner spec to make this configurable? WDYT?

Ehm... I tested this image locally and I got the user in the sudoers group etc. But how can I use my image for the runner now, while this gets merged? I need to be root to investigate some issues, especially networking related. There seems to be a networking issue with Docker in Docker, and often my build fails in the runner because it cannot connect to some hosts to download packages etc. Any idea?

I have found some references lke https://discuss.istio.io/t/connection-issues-with-docker-build-inside-a-kubernetes-pod/5761 where they say that using the host network would solve these networking issues. Is this possible?

I solved the networking issue.... but I still don't know how to use my image for the runner :(

Please specify the image field in your runner to the name of the image you've docker-pushed https://github.com/summerwind/actions-runner-controller/blob/master/api/v1alpha1/runner_types.go#L40

@mumoshu   It worked, thannks!

Thanks for the PR!
In the GitHub's runner environment allows us to use sudo with no password. So, this change looks good to me 👍
See also: https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners#administrative-privileges-of-github-hosted-runners
In the future, it seems better to make the file system of the Runner container image the same as GitHub's runner environment.


[wip] tf*idf support

Any reason why tf-idf was closed?

I rebuilt this extension using ActiveRecord

I am sorry. I do not understand what that means. :sweat_smile:
I am new to ruby.


Shell Script Invocation Error

After I added the library, I got the three errors in my projects.

It seems that because I use the script bellow. After executing the script, there will be these errors.
TAGS="TODO:|FIXME:"
echo "searching ${SRCROOT} for ${TAGS}"
find "${SRCROOT}" ( -name ".swift" ) -print0 | xargs -0 egrep --with-filename --line-number --only-matching "($TAGS).$" | perl -p -e "s/($TAGS)/ warning: $1/"


update README

included instructions for installing vector plugin, which includes code lines to insert into config files
moved installing DSX local plugins to troubleshooting section
fixed HDP plugin table to include tmdbsimple
added note about significance of cells with %%spark

LGTM


gdax false minimum trade amount

Note: for support questions, please join our Discord server

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
Launch a tradebot on btc/eur/gdax

Expected result (what you hoped would happen)
Buy and sell BTCs according to my strategy

Actual result (unexpected outcome)
"2018-02-28 02:06:37 (INFO):	Trader Received advice to go long. Buying  BTC
2018-02-28 02:06:37 (ERROR):	Wanted to buy BTC but the amount is too small (0.003015963807) at GDAX"
It considers 0.003 too small wheras gdax has a 0.001 BTC minimum trade rule.
cf. https://support.gdax.com/customer/en/portal/articles/2426595-gdax-limits-for-deposits-withdrawals-trades-and-balances

In order to test the 0.001BTC rule, I tried to place on gdax website an order to buy 0.003BTC an it accepted the order (I did not wait for the site to fill the order)

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

Thank you in advance !:-)
Xavier

Thanks for the report, I've fixed this now :)
You need to download the latest development build in order to have access to the fix until I do a new release.

@H256 ah yes, Gekko recently started supporting the lot calculations required to figure out whether this is the case.
Mind opening a new issue so that we can track it? Thanks!


shutdown is not recognized as a external or internal command

whenever I try to do --
pywhatkit.shutdown(time=10)#any time
I get the error -- shutdown is not recognized as a external or internal command
Anyone with the same error?
Can anyone help me with this how to fix it, is the problem with the module or my computer?
I am using windows 7 32 bit, python I am using - 3.8.6

Can you please mention the OS you are working on.

Can you please mention the OS you are working on.

Can you try to run the shutdown -s command in your command prompt and tell if it worked

Can you try to run the shutdown -s command in your command prompt and tell if it worked

Can you please mention the OS you are working on.

windows 7, 32 bit

Can you please mention the OS you are working on.

windows 7, 32 bit

Can you try to run the shutdown -s command in your command prompt and tell if it worked

nope. didn't worked!

Can you try to run the shutdown -s command in your command prompt and tell if it worked

nope. didn't worked!

Then it is a problem with your system. Shutdown is an external command i.e., it has its own executable in C:\Windows\System32 and if the path variables are not correctly configured or the executable is missing it may result in this error. See this for help. If it does not resolve the issue try contacting Microsoft Support.

Then it is a problem with your system. Shutdown is an external command i.e., it has its own executable in C:\Windows\System32 and if the path variables are not correctly configured or the executable is missing it may result in this error. See this for help. If it does not resolve the issue try contacting Microsoft Support.

@aaryanrr is right, I think shutdown.exe is not in your path.

@aaryanrr is right, I think shutdown.exe is not in your path.


Add check on Timer::start method to prevent reset if it's already started

The current start method doesn't do any checking whether the Timer is already started or not, it just sets the time as it is.
This PR will add check so it match the functionality as described on the docs.
Fix #95480

After deeper look, this might not be the best idea. What if the timer is already started, but just merely paused? Would start() simply resuming from the pause or re-starting the timer?
I'd go with adjusting the documentation to match the current behavior.


docs: fix spelling & grammar in docs

Awesome project! I found a few typos in the docs as I was getting ready to test out kprofefe - here's a quick PR for the fixes.

Thanks a lot!


Repository image details page needs to be redone

The image tag details page needs to be redone. double back navigation in existing implementation is confusing.
Existing implementation:

Design:

In particular

only 1 back navigation should be visible
we don't need the tabs
detail labels should be left aligned
bread crumb could include "<Projects <RepoName <ImageName" when on the image scan details page

looks much better. one detail, the label "LABELS" should not be all upper case.


Make explicit that Google Ads extractor does not pull in data on Smart Campaigns

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1918
Originally created by @DouweM on 2020-03-26 22:56:28

View 6 previous comments from the original issue on GitLab


wake_on_lan widget: find macs case-insensitive

Find mac addresses case-insensitive. When mac addresses are added, they are saved like the users enters them. If the user used upper-case letters, this results in showing the host offline in the dashboard, although it´s online. Other fix would be to make all mac inputs lowercase while saving.

Nice catch, thanks! :)


keras v 2.2.4-tf save model ValueError: Could not pack sequence.

I am using tensorflow.keras on colab.research.google.com. It runs good till today.
I notice the tf version upgraded from 1.13 to 1.14.0-rc1, and tf.keras.version is 2.2.4-tf.
I have trained the same model and saved well before. But now, when I call model.save( ... ), an error occurs like:

 in ChkEvaluate()
18         MinEvaLoss = EvLoss
19         if EvLoss < 0.47:
---> 20             mo.save( DIR + 'model3_Rd' )
21             Saved += 1
22             print( '--------- model saved. ---------' )
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/network.py in save(self, filepath, overwrite, include_optimizer, save_format)
1209     ```
1210     """
-> 1211     saving.save_model(self, filepath, overwrite, include_optimizer, save_format)
1212
1213   def save_weights(self, filepath, overwrite=True, save_format=None):
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/saving/save.py in save_model(model, filepath, overwrite, include_optimizer, save_format)
111           'or using save_weights.')
112     hdf5_format.save_model_to_hdf5(
--> 113         model, filepath, overwrite, include_optimizer)
114     return
115
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/saving/hdf5_format.py in save_model_to_hdf5(model, filepath, overwrite, include_optimizer)
97         {
98             'class_name': model.class.name,
---> 99             'config': model.get_config()
100         },
101         default=serialization.get_json_type).encode('utf8')
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/network.py in get_config(self)
991       model_inputs.append(
992           tf_utils.ListWrapper([layer.name, new_node_index, tensor_index]))
--> 993     model_inputs = nest.pack_sequence_as(self._nested_inputs, model_inputs)
994     # Preserve external Keras compat for Models with single input.
995     if not nest.is_sequence(model_inputs):
/usr/local/lib/python3.6/dist-packages/tensorflow/python/util/nest.py in pack_sequence_as(structure, flat_sequence, expand_composites)
447           "Could not pack sequence. Structure had %d elements, but "
448           "flat_sequence had %d elements.  Structure: %s, flat_sequence: %s." %
--> 449           (len(flat_structure), len(flat_sequence), structure, flat_sequence))
450   return _sequence_like(structure, packed)
451
ValueError: Could not pack sequence. Structure had 21 elements, but flat_sequence had 1 elements.  Structure: [<tf.Tensor 'tshare_1:0' shape=(?, 240, 1) dtype=float32>, <tf.Tensor 'm_5_1:0' shape=(?, 3, 20, 1) dtype=float32>, <tf.Tensor 'm_15_1:0' shape=(?, 3, 20, 1) dtype=float32>, <tf.Tensor 'm_60_1:0' shape=(?, 3, 20, 1) dtype=float32>, <tf.Tensor 'm_240_1:0' shape=(?, 3, 20, 1) dtype=float32>, <tf.Tensor 'm1680_1:0' shape=(?, 3, 20, 1) dtype=float32>, <tf.Tensor 'm4800_1:0' shape=(?, 3, 20, 1) dtype=float32>, <tf.Tensor 'r15_1:0' shape=(?, 3, 15, 1) dtype=float32>, <tf.Tensor 'r60_1:0' shape=(?, 3, 15, 1) dtype=float32>, <tf.Tensor 'r240_1:0' shape=(?, 3, 15, 1) dtype=float32>, <tf.Tensor 'r1680_1:0' shape=(?, 3, 15, 1) dtype=float32>, <tf.Tensor 'r4800_1:0' shape=(?, 3, 15, 1) dtype=float32>, <tf.Tensor 'indik15_1:0' shape=(?, 3, 13, 1) dtype=float32>, <tf.Tensor 'indik60_1:0' shape=(?, 3, 13, 1) dtype=float32>, <tf.Tensor 'indik240_1:0' shape=(?, 3, 13, 1) dtype=float32>, <tf.Tensor 'indik1680_1:0' shape=(?, 3, 13, 1) dtype=float32>, <tf.Tensor 'indik4800_1:0' shape=(?, 3, 13, 1) dtype=float32>, <tf.Tensor 'ks_1:0' shape=(?, 60) dtype=float32>, <tf.Tensor 'dayinfo_1:0' shape=(?, 4) dtype=float32>, <tf.Tensor 'maday_1:0' shape=(?, 5, 10, 1) dtype=float32>, <tf.Tensor 'polyline_1:0' shape=(?, 20, 4, 1) dtype=float32>], flat_sequence: [<tensorflow.python.keras.utils.tf_utils.ListWrapper object at 0x7f44949ea2b0>].

There is somthing different in model.summary(). The current summary is:
RDayDense0 (Dense)              (None, 96)           119904      flatten_32[0][0]

dropout_107 (Dropout)           (None, 96)           0           RDayDense0[0][0]

RDayDense1 (Dense)              (None, 64)           6208        dropout_107[0][0]

dropout_108 (Dropout)           (None, 64)           0           RDayDense1[0][0]

RDayDense2 (Dense)              (None, 8)            520         dropout_108[0][0]

dropout_109 (Dropout)           (None, 8)            0           RDayDense2[0][0]

tshare (InputLayer)             [(None, 240, 1)]     0

m_5 (InputLayer)                [(None, 3, 20, 1)]   0

m_15 (InputLayer)               [(None, 3, 20, 1)]   0

m_60 (InputLayer)               [(None, 3, 20, 1)]   0

m_240 (InputLayer)              [(None, 3, 20, 1)]   0

m1680 (InputLayer)              [(None, 3, 20, 1)]   0

m4800 (InputLayer)              [(None, 3, 20, 1)]   0

r15 (InputLayer)                [(None, 3, 15, 1)]   0

r60 (InputLayer)                [(None, 3, 15, 1)]   0

r1680 (InputLayer)              [(None, 3, 15, 1)]   0

r4800 (InputLayer)              [(None, 3, 15, 1)]   0

indik15 (InputLayer)            [(None, 3, 13, 1)]   0

indik60 (InputLayer)            [(None, 3, 13, 1)]   0

indik240 (InputLayer)           [(None, 3, 13, 1)]   0

indik1680 (InputLayer)          [(None, 3, 13, 1)]   0

indik4800 (InputLayer)          [(None, 3, 13, 1)]   0

ks (InputLayer)                 [(None, 60)]         0

dayinfo (InputLayer)            [(None, 4)]          0

maday (InputLayer)              [(None, 5, 10, 1)]   0

polyline (InputLayer)           [(None, 20, 4, 1)]   0

OutputDense (Dense)             (None, 1)            9           dropout_109[0][0]
Total params: 136,913
Trainable params: 136,913
Non-trainable params: 0

There are about 20 noused InputLayers listed, which weren't listed in model.summary() in the past versions. If delete these InputLayers, the model could be saved.
This is a big model. I would train different input data in different steps. To update the code may got trouble. How can I save the model without deleting the more InputLayers?

@saintthor Can you share the colab gist. Thanks!

@saintthor Can you share the colab gist. Thanks!

sorry. I have alterd the model and deleted the no-used input layers.

Automatically closing this out since I understand it to be resolved, but please let me know if I'm mistaken.Thanks!


Patch to support longer assembly names in the mapping session table.

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
Review the contributing guidelines for this repository; remember in particular:

do not modify code without testing for regression
provide simple unit tests to test the changes
if you change the schema you must patch the test databases as well, see Updating the schema
the PR must not fail unit testing

Description
Using one or more sentences, describe in detail the proposed changes.
Increased length of old_assembly and new_assembly columns in the mapping_session table in the core databases.
Use case
Describe the problem. Please provide an example representing the motivation behind the need for having these changes in place.
Xenopus tropicalis assembly name would appear truncated as "Xenopus_tropicalis_v" in the current database schema for e100.
Benefits
If applicable, describe the advantages the changes will have.
Longer assembly names would be supported.
Possible Drawbacks
If applicable, describe any possible undesirable consequence of the changes.
More space would be required.
Testing
Have you added/modified unit tests to test the changes?
No. I think the existing unit tests should work.
If so, do the tests pass/fail?
N/A.
Have you run the entire test suite and no regression was detected?
No.

I'll update the table.sql file and run the patch test databases script.

It should be ready now.

The problem with table.sql notwithstanding, looks good.

Sorry I missed that, added now.

Turns out ALTER TABLE mapping_session MODIFY COLUMN old_assembly VARCHAR(80);
removes the extra bit of NOT NULL DEFAULT ''.
Thus the schema is broken...
The sql statements we want is this patch are:
ALTER TABLE mapping_session MODIFY COLUMN old_assembly VARCHAR(80) NOT NULL DEFAULT '';
ALTER TABLE mapping_session MODIFY COLUMN new_assembly VARCHAR(80) NOT NULL DEFAULT '';

Reverting.


[FLINK-31936] Support setting scale up max factor

What is the purpose of the change
Support setting scale up max factor for autoscaler.
Brief change log

Add new option kubernetes.operator.job.autoscaler.scale-up.max-factor for setting scale up max factor.
Cap scale factor in JobVertexScaler#computeScaleTargetParallelism by max scale-up factor.
Record capped target processing rate instead as the expected processing rate in JobVertexScaler#computeScaleTargetParallelism.
Adapt UTs accordingly.

Verifying this change

Extended existing unit test

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? auto-generated doc

@mxm do you have any more concerns/comments? Or can we merge this?

No more comments. Thanks @X-czh! 😃


[bug]: Minting a normal asset with --decimal_display does not yield expected results

Background
I minted a new asset with the flag: --decimal-display 3 but the created asset shows "decimal_display":  0
Your environment
litd integrated mode
branch: 0-19-staging
commit: fa32097a4d0deee7e84872690194d18f108cf5a5
Steps to reproduce
Command used:
tapcli --tlscertpath ~/.lit/tls.cert --rpcserver=localhost:8443 --network=testnet assets mint --type normal --name beefbux --supply 1000000 --decimal_display 3 --new_grouped_asset --meta_type json
tapcli assets mint finalize
Expected behavior
When running tapcli assets list, I expect to see the asset with its defined decimal display.
Actual behavior
The minted asset appears to have its decimal display set to 0:
        {
            "version":  "ASSET_VERSION_V0",
            "asset_genesis":  {
                "genesis_point":  "1fd2b57bbbaaae90d9015f7ea4b75413629aeb591fc789ad42c900d5a999f56a:1",
                "name":  "beefbux",
                "meta_hash":  "0000000000000000000000000000000000000000000000000000000000000000",
                "asset_id":  "9052f8837a836ee5d48b8609f78cb475aec480d2e58fe798b0d5b8354245e121",
                "asset_type":  "NORMAL",
                "output_index":  0
            },
            "amount":  "1000000",
            "lock_time":  0,
            "relative_lock_time":  0,
            "script_version":  0,
            "script_key":  "02c71287f4763bc86e7144933d586e534ea799b6530dd49909d78e7eb1c00baaa7",
            "script_key_is_local":  true,
            "asset_group":  {
                "raw_group_key":  "029b811d7ef954704bf07c949f0464b680224a808468fd13d391c9141d9046459c",
                "tweaked_group_key":  "02e446b1ee2e362a75fa94f2ed02a2653df979225d8d68c79ae0643e7fcb317f64",
                "asset_witness":  "0140fd75b9eb5b1840b426eb1b3248f0038e8d38665c12bab4e7817322d517eef6ab86675433edf171e7e9bfb52315d20265b40e4ab28638cd2388212e68bc656032",
                "tapscript_root":  ""
            },
            "chain_anchor":  {
                "anchor_tx":  "020000000001016af599a9d500c942ad89c71f59eb9a621354b7a47e5f01d990aeaabb7bb5d21f01000000000000000002e80300000000000022512082bcb8523d1c7ecf7a156c452df083144ffd7d0691f0c5314f5c1586476343a4704b0a02000000002251209423066211c876f9ba1709678567091e9c750747747625b2c4725a68944a4d5301408391f5c0f3d4873c48d83d20bb9749b2f709f0dff5e6b37df995f81372e73d926d3d80c73bb25dd66d35c36922a5c180bc824730224ff369869f397c3110d98900000000",
                "anchor_block_hash":  "0000000000000000000000000000000000000000000000000000000000000000",
                "anchor_outpoint":  "f939a83cf71a7d8d743a989e81ad9c292f4e6c4f7c3bc5639313cd1739a15363:0",
                "internal_key":  "03b7484d5f0c6102cb58c016186fe28f8e7bc007c6d859eaa3b206534098e3c14d",
                "merkle_root":  "a376b5e1cd538fd5c4c1426bda4621d02c5c0924c5ff689dcc59712efc291255",
                "tapscript_sibling":  "",
                "block_height":  0
            },
            "prev_witnesses":  [],
            "is_spent":  false,
            "lease_owner":  "",
            "lease_expiry":  "0",
            "is_burn":  false,
            "script_key_declared_known":  false,
            "script_key_has_script_path":  false,
            "decimal_display":  {
                "decimal_display":  0
            }
        }

Maybe unrelated, but I also don't understand why the block height appears to be zero (and the block hash is empty). The minting transaction had over 2000 confirmations at the time when I pulled the above data: f939a83cf71a7d8d743a989e81ad9c292f4e6c4f7c3bc5639313cd1739a15363

The bit with block height displayed as 0 has come up in the Slack as a surprise + issue that requires user workarounds.

Looks like this is from not having any metadata set for this mint call; I assumed that a caller setting a decimal display would also include some other metadata. If no metadata exsists we end up skipping the logic to add the decimal display.
IMO the correct behavior here is to have the decimal_display as the sole JSON object. Implemented in #979 .

Classic user error!
I first tried adding metadata with the --meta_bytes flag but that wasn't allowed, so I removed that flag and set --meta_type json
Could you help me craft a sample json file for my guides?

Hmm, adding metadata should have been allowed? If it was JSON, then decimal display should get added to that.

This is the error I run into for the command:
tapcli assets mint --type normal --name beefbux --supply 1000000 --decimal_display 3 --meta_bytes 66616e746173746963206d6f6e6579 --new_grouped_asset
[tapcli] unable to mint asset: rpc error: code = Unknown desc = cannot set decimal display if meta type is not JSON

@jharveyb so we should be assuming that if decimal display is set, then we use the json meta type.

@Liongrass do things work if you add  --meta_type json back to the set of flags?

I wasn't able to set --meta_bytes 66616e746173746963206d6f6e6579 and --meta_type json at the same time, and when I only set --meta_type json the decimal_display ended up set to zero

Quick tools to encode & decode JSON to hex.
Encode:
echo -n '{"hello":"world"}' | hexdump -v -e '/1 "%02X"'
7B2268656C6C6F223A22776F726C64227D
Decode:
echo 7B2268656C6C6F223A22776F726C64227D | xxd -r -p
{"hello":"world"}

Hm I was using a tool similar to this, but my main question is whether I have to pass the hex encoded string to tapd or the raw string. I tried with the hex encoded string first and got an error, but roasbeef instructed me to use the raw string

Ah true, I forgot that tapd will encode it to bytes internally. I guess with this you could decode JSON for an already minted asset.


Add reference to skpm in readme

Add reference to skpm in readme
https://github.com/mathieudutour/sketch-module-web-view/issues/4

Cool thanks!

(also I just moved the repo to the skpm org)


Adding Form.io tutorial to the integration docs.

This adds a tutorial on how to build "Serverless apps with Form.io + Sendgrid". Comments welcome.

@travist I will let you know as soon as I have these live on sendgrid.com/docs. I apologize for the delay in merging these in.
Thanks!

Thank you!  Excited to see it!


RT-1125:(charts-on-fhir) Node.js 16 actions are deprecated

Overview
Updated  actions/checkout@v3, actions/setup-node@v3. to actions/checkout@v4, actions/setup-node@v4
actions/checkout@v4, actions/setup-node@v4 use a node 20,
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
How it was tested
Created a PR and tested for Pull request action, I have also updated a release action
Checklist

[X ] The title contains a short meaningful summary
[X ] I have added a link to this PR in the Jira issue
[X ] I have described how this was tested
[ ] I have included screen shots for changes that affect the user interface
[ ] I have updated unit tests
[ ] I have run unit tests locally
[ ] I have updated documentation (including README)

Ticket: https://meliorix.atlassian.net/jira/software/projects/RT/boards/51?assignee=617710fef485cd00689d10a1&selectedIssue=RT-1125