LnbitsWallet Unable to Create Invoice

I'm trying to stand up a quick lnbits server to do some programming against. In development, I wish to stand up a server that is backed by the LnbitWallet class. I used the following .env
# .env
LNBITS_BACKEND_WALLET_CLASS=LNbitsWallet
LNBITS_ENDPOINT=https://legend.lnbits.com
LNBITS_KEY=walleettttkkeyyyy

There's a bunch more in the .env but I doubt it's relevant (it's full of the defaults).
All works well in standing up an instance. However, when creating an invoice, I get the following error message:

coupled with the following error logs:
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/anyio/_core/_sockets.py", line 186, in connect_tcp
    addr_obj = ip_address(remote_host)
  File "/usr/local/lib/python3.9/ipaddress.py", line 53, in ip_address
    raise ValueError(f'{address!r} does not appear to be an IPv4 or IPv6 address')
ValueError: 'legend.lnbits.com' does not appear to be an IPv4 or IPv6 address

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/httpcore/backends/asyncio.py", line 109, in connect_tcp
    stream: anyio.abc.ByteStream = await anyio.connect_tcp(
  File "/usr/local/lib/python3.9/site-packages/anyio/_core/_sockets.py", line 189, in connect_tcp
    gai_res = await getaddrinfo(
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/httpcore/_exceptions.py", line 8, in map_exceptions
    yield
  File "/usr/local/lib/python3.9/site-packages/httpcore/backends/asyncio.py", line 109, in connect_tcp
    stream: anyio.abc.ByteStream = await anyio.connect_tcp(
  File "/usr/local/lib/python3.9/site-packages/anyio/_core/_tasks.py", line 118, in __exit__
    raise TimeoutError
TimeoutError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 60, in map_httpcore_exceptions
    yield
  File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 353, in handle_async_request
    resp = await self._pool.handle_async_request(req)
  File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection_pool.py", line 253, in handle_async_request
    raise exc
  File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection_pool.py", line 237, in handle_async_request
    response = await connection.handle_async_request(request)
  File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection.py", line 86, in handle_async_request
    raise exc
  File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection.py", line 63, in handle_async_request
    stream = await self._connect(request)
  File "/usr/local/lib/python3.9/site-packages/httpcore/_async/connection.py", line 111, in _connect
    stream = await self._network_backend.connect_tcp(**kwargs)
  File "/usr/local/lib/python3.9/site-packages/httpcore/backends/auto.py", line 29, in connect_tcp
    return await self._backend.connect_tcp(
  File "/usr/local/lib/python3.9/site-packages/httpcore/backends/asyncio.py", line 109, in connect_tcp
    stream: anyio.abc.ByteStream = await anyio.connect_tcp(
  File "/usr/local/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/usr/local/lib/python3.9/site-packages/httpcore/_exceptions.py", line 12, in map_exceptions
    raise to_exc(exc)
httpcore.ConnectTimeout

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/gzip.py", line 24, in __call__
    await responder(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/gzip.py", line 43, in __call__
    await self.app(scope, receive, self.send_with_gzip)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/cors.py", line 92, in __call__
    await self.simple_response(scope, receive, send, request_headers=headers)
  File "/usr/local/lib/python3.9/site-packages/starlette/middleware/cors.py", line 147, in simple_response
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/exceptions.py", line 93, in __call__
    raise exc
  File "/usr/local/lib/python3.9/site-packages/starlette/exceptions.py", line 82, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 670, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 266, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 65, in app
    response = await func(request)
  File "/usr/local/lib/python3.9/site-packages/fastapi/routing.py", line 227, in app
    raw_response = await run_endpoint_function(
  File "/usr/local/lib/python3.9/site-packages/fastapi/routing.py", line 160, in run_endpoint_function
    return await dependant.call(**values)
  File "/app/lnbits/core/views/api.py", line 284, in api_payments_create
    return await api_payments_create_invoice(invoiceData, wallet.wallet)
  File "/app/lnbits/core/views/api.py", line 203, in api_payments_create_invoice
    raise exc
  File "/app/lnbits/core/views/api.py", line 189, in api_payments_create_invoice
    payment_hash, payment_request = await create_invoice(
  File "/app/lnbits/core/services.py", line 70, in create_invoice
    ok, checking_id, payment_request, error_message = await wallet.create_invoice(
  File "/app/lnbits/wallets/lnbits.py", line 71, in create_invoice
    r = await client.post(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1842, in post
    return await self.request(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1527, in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1614, in send
    response = await self._send_handling_auth(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1642, in _send_handling_auth
    response = await self._send_handling_redirects(
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1679, in _send_handling_redirects
    response = await self._send_single_request(request)
  File "/usr/local/lib/python3.9/site-packages/httpx/_client.py", line 1716, in _send_single_request
    response = await transport.handle_async_request(request)
  File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 353, in handle_async_request
    resp = await self._pool.handle_async_request(req)
  File "/usr/local/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/usr/local/lib/python3.9/site-packages/httpx/_transports/default.py", line 77, in map_httpcore_exceptions
    raise mapped_exc(message) from exc
httpx.ConnectTimeout
2022-09-28 23:31:33.22 | ERROR | Exception in ASGI application

Basically, https://legend.lnbits.com is not an IP address. I guess the code is expecting an IP address? Does this mean I can't use https://legend.lnbits.com as my dev backing? If so, is there something that should be done to the guide / .env comments? https://legend.lnbits.com was the example given.
Potentially related to https://github.com/lnbits/lnbits/issues/991

Sorry for asking but, did you use the wallet id, or the wallet key, if key, which one?

Is this issue still happening? Can it be closed?

You can close it. I unfortunately. don't have time to recreate atm. Thanks for your help!


Fix wai request conversion

Two showstopper bugs here, hiding each other from the tests.

The function to recursively read the wai request body did not actually recurse, and only returned the first chunk (fortunately, enough for most HTTP requests).
The wai version of a hadron request had a requestBody which unconditionally yielded its one chunk, meaning that functions expecting a different chunk each time terminated by the empty ByteString recurse forever and try to allocate infinite memory.

I should definitely add some conversion tests with multi-chunk request bodies; I'll do that tomorrow, just want to get this fix in for now.
! @thumphries @erikd-ambiata

/jury set-priority high

Makes sense to me, but I'm trusting your description. Could you include tests with this PR?

Seems legit. :+1:

Makes sense to me, but I'm trusting your description. Could you include tests with this PR?

Done, how's it look now?

@thumphries pushing this through, let me know if you see any issues with the test.


Support complex objects in database backend by using JSON objects

Pipestat should support complex objects (see example below) and store them in as JSON objects in the database. Currently, with the transition to sqlmodel, this functionality is not implemented.
pipeline_id: test_pipe
samples:
  collection_of_images:
    description: "This store collection of values"
    type: array
    items:
      type: file
  output_file_in_object:
    type: object
    properties:
      prop1:
        description: "This is an example file"
        type: file
      prop2:
        description: "This is an example image"
        type: image
    description: "Object output"
  output_file:
    type: file
    description: "This a path to the output file"
  output_image:
    type: image
    description: "This a path to the output image"

Added recursively replacing custom types for more complex schemas.
Next Steps:
-Reset database tables between pytests (clear all) such that it does not cause other tests to fail. This will help address. https://github.com/pepkit/pipestat/issues/38
-currently, complex objects are not inserted in DB, instead return error:
Could not insert the result into the database. Exception: (psycopg2.ProgrammingError) can't adapt type 'dict'
-- This appears to occur at _execute_context in base.py where the parameters exist as a dictionary containing a dictionary. In the original SQLAlchemy build (on dev branch), the parameters exist as a dictionary containing strings.

Can now store dicts as JSONB Column and filter on contents within the JSONB column using psm.select.
Next steps:
-fix collection of images using arrays of JSONB

To do:
Test more elaborate array example to ensure functionality is as desired.

Backwards compatibility with Python 3.8 was added via 22e418d


TabBar throws Unexpected Null-Value when width is too small

When using the TabBar Widget from fluent-ui I currently encounter an error: Unexpected Null-Value under the following circumstances:

Reducing the Width of the Parent-View containing the TabBar to a size, where not all Tabs can be rendered completely.

For Reproduction:

All Tabs contain Text and Icons.

The TabView then only renders grey (or red in debug-mode) and is not usable anymore.

This is the complete Error:
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following TypeErrorImpl was thrown building LayoutBuilder:
Unexpected null value.
The relevant error-causing widget was:
TabView
TabView:file:///(Removed)/incident_list_tab_view.dart:50:12
incident_list_tab_view.dart:50
When the exception was thrown, this was the stack:
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 266:49 throw
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 561:63 nullCheck
packages/flutter/src/widgets/scroll_position.dart 145:49 get maxScrollExtent
packages/scroll_pos/src/scroll_pos.dart 35:53 get max
packages/scroll_pos/src/scroll_pos.dart 51:59 get canForward
packages/fluent_ui/src/controls/navigation/tab_view.dart 530:41 forwardButton
packages/fluent_ui/src/controls/navigation/tab_view.dart 555:27
packages/fluent_ui/src/controls/navigation/tab_view.dart 567:38
packages/flutter/src/widgets/layout_builder.dart 119:70 layoutCallback
packages/flutter/src/widgets/framework.dart 2682:19 buildScope
packages/flutter/src/widgets/layout_builder.dart 153:5 [_layout]
packages/flutter/src/rendering/object.dart 2300:59
packages/flutter/src/rendering/object.dart 1056:15 [_enableMutationsToDirtySubtrees]
packages/flutter/src/rendering/object.dart 2300:7 invokeLayoutCallback
packages/flutter/src/widgets/layout_builder.dart 228:7 rebuildIfNecessary
packages/flutter/src/widgets/layout_builder.dart 313:5 performLayout
packages/flutter/src/rendering/object.dart 2189:7 layout
packages/flutter/src/rendering/box.dart 2430:11 layout
packages/flutter/src/rendering/layout_helper.dart 56:10 layoutChild
packages/flutter/src/rendering/flex.dart 903:45 [_computeSizes]
packages/flutter/src/rendering/flex.dart 938:32 performLayout
packages/flutter/src/rendering/object.dart 2027:7 [_layoutWithoutResize]
packages/flutter/src/rendering/object.dart 1020:17 flushLayout
packages/flutter/src/rendering/binding.dart 516:19 drawFrame
packages/flutter/src/widgets/binding.dart 865:13 drawFrame
packages/flutter/src/rendering/binding.dart 381:5 [_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1289:15 [_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1218:9 handleDrawFrame
packages/flutter/src/scheduler/binding.dart 1076:5 [_handleDrawFrame]
C:/b/s/w/ir/cache/builder/src/out/host_debug/lib/_engine/engine/platform_dispatcher.dart 1168:13 invoke
C:/b/s/w/ir/cache/builder/src/out/host_debug/lib/_engine/engine/platform_dispatcher.dart 218:5 invokeOnDrawFrame
C:/b/s/w/ir/cache/builder/src/out/host_debug/lib/_engine/engine/initialization.dart 190:45
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 367:37 _checkAndCall
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 372:39 dcall

@WinXaito looks like an issue with scroll_pos

Indeed, it looks like a problem with scroll_pos
I will check that

I checked on scroll_pos, but I didn't find anything wrong, because de error comes from flutter scroll_controller.
I thing the controller is not correctly attached to the tabview.
@brianmayclone  Can you provide a minimal reproductible example please ?

@WinXaito Sorry I wanted to provide a sample to you within the next days.
@WinXaito @bdlukaa Tried the current master in our project and it works like a charm!
BIG THANX !


Update deployment.yaml

Wrap entire deployment with 'efsFileSystemId' conditional to prevent node selector etc from not being found in chart

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/retest
On Wed, Oct 2, 2019 at 1:11 PM Kubernetes Prow Robot <
<EMAIL_ADDRESS>wrote:

@isaac-chan https://github.com/isaac-chan: The following test failed,
say /retest to rerun them all:
Test name Commit Details Rerun command
pull-charts-e2e 0a6098a
https://github.com/helm/charts/commit/0a6098afe5593bcccac6cc491b8d2fe9571d1e4a
link
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/helm_charts/17594/pull-charts-e2e/1179488600442540032/ /test
pull-charts-e2e
Full PR test history
https://prow.k8s.io/pr-history?org=helm&repo=charts&pr=17594. Your PR
dashboard https://gubernator.k8s.io/pr/isaac-chan. Please help us cut
down on flakes by linking to
https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests
an open issue https://github.com/helm/charts/issues?q=is:issue+is:open
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/helm/charts/pull/17594?email_source=notifications&email_token=ADIOA5R2QHYKOYMEJLNRG7DQMT6APA5CNFSM4I4NVJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAGATKQ#issuecomment-537659818,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADIOA5UCCTUCVPJ4OHOS6WLQMT6APANCNFSM4I4NVJEQ
.

--
Isaac Chan

/lgtm

/retest

@isaac-chan
Would you sign DCO and bump the chart to the latest version please? Thank you.


InvalidLocationConstraint when creating bucket

We are using s3proxy to connect to azure storage. When we are creating a bucket using nodejs sdk I am getting InvalidLocationConstraint error. Here is the stack trace
{ InvalidLocationConstraint: The specified location constraint is not valid. For more information about Regions, see How to Select a Region for Your Buckets.
    at Request.extractError (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/services/s3.js:538:35)
    at Request.callListeners (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/request.js:668:14)
    at Request.transition (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/request.js:670:12)
    at Request.callListeners (/Users/battula/eloise/foundational-services/node-s3proxy/node_modules/aws-sdk/lib/sequential_executor.js:115:18)
  message: 'The specified location constraint is not valid. For more information about Regions, see How to Select a Region for Your Buckets.',
  code: 'InvalidLocationConstraint',
  region: null,
  time: 2017-03-14T09:40:15.509Z,
  requestId: null,
  extendedRequestId: undefined,
  cfId: undefined,
  statusCode: 400,
  retryable: false,
  retryDelay: 75.30141439047937 }

If I use java sdk it works fine. After a little debugging I found that if I pass region as azureblob while creating the bucket then it is working fine.

Enable S3Proxy trace logging and see what nodejs is providing, probably us-east-1.  I investigated a similar issue earlier in aws/aws-sdk-js#919 but dropped it due to lack of understanding how to debug nodejs code.  Perhaps S3Proxy should default to allowing us-east-1 as a constraint?

@andrewgaul After debugging I found that nodejs is sending us-east-1 as the default region. This is causing the issue.
I have found from the #127  issue you asked to use jclouds.region=us-east-1 while using nodejs sdk. I have added this to my properties file and it worked. Is this the solution you are mentioning?

@kishore25kumar I am glad that you found a workaround but I think S3Proxy should work out of box for nodejs users.  Perhaps we should add a default jclouds.region value to S3Proxy?

Fixed by #277.


Runs in dev, but fails to build

So I just installed this to an existing project which builds without issue, until I install the spinner:
[!] (plugin terser) Error: Unexpected token: operator (?)
SyntaxError: Unexpected token: operator (?)
at Z.get (...\node_modules\terser\dist\bundle.min.js:1:463)
at reportError (...\node_modules\jest-worker\build\workers\processChild.js:107:11)
at reportClientError (...\node_modules\jest-worker\build\workers\processChild.js:87:10)
at execFunction (...\node_modules\jest-worker\build\workers\processChild.js:157:5)
at execHelper (...\node_modules\jest-worker\build\workers\processChild.js:139:5)
at execMethod (...\node_modules\jest-worker\build\workers\processChild.js:143:5)
at process. (...\node_modules\jest-worker\build\workers\processChild.js:64:7)
at process.emit (events.js:315:20)
at emit (internal/child_process.js:876:12)
at processTicksAndRejections (internal/process/task_queues.js:85:21)
I've uninstalled and rebuilt and the app builds fine again, then after installing the spinner it again fails to build.
Love the component, any idea why it's failing to build?

Hi @jamersoniiv,
I've no idea right now, why this happens. I will try to reproduce this error, but it could help if you manage to strip down your app to a minimum of code where this error still happens.

I could not reproduce the problem. Seems it has something to do with the svelte version or one of the dependencies in the package. It looks like it might be the version of rollup-plugin-terser. In my test I used the latest template from svelte with these dependencies:
  "devDependencies": {
    "@rollup/plugin-commonjs": "^17.0.0",
    "@rollup/plugin-node-resolve": "^11.0.0",
    "rollup": "^2.3.4",
    "rollup-plugin-css-only": "^3.1.0",
    "rollup-plugin-livereload": "^2.0.0",
    "rollup-plugin-svelte": "^7.0.0",
    "rollup-plugin-terser": "^7.0.0",
    "svelte": "^3.0.0"
  },
  "dependencies": {
    "sirv-cli": "^1.0.0",
    "svelte-number-spinner": "^0.5.1"
  }

James: sounds like your build environment doesn't understand the nullish coalescing operator. Is that possible? Do you use ?? anywhere else in the code?

Problem seems to be solved, I guess.


[DCOS-17650] release dcos-enterprise-cli 1.3.0

As this also uses a new Jenkins pipeline for ZIP artifacts, I'd like to make a few manual checks before labeling this as ready.

I've been able to test this on linux after following instructions from here : https://github.com/mesosphere/universe#repository-consumption-1
➜  cli git:(master) dcos package install dcos-enterprise-cli
By Deploying, you agree to the Terms and Conditions https://mesosphere.com/catalog-terms-conditions/#certified-services
Continue installing? [yes/no] yes
Installing CLI subcommand for package [dcos-enterprise-cli] version [1.3.0]
New commands available: dcos backup, dcos security
➜  cli git:(master) dcos security --version
1.2.0
➜  cli git:(master) dcos backup --version
dcos backup version 0.1.0

For other platforms I've downloaded the ZIPs and compared the structure with the current release, and they were similar.

@jose @larioj @takirala Can we get this merged please? We need it to conicide with the GA release of DC/OS.

@jsancio is on vacation


Feature Request: Collapsible Initiator Groups

It would be great if the UI supported expanding/collapsing requests per initiator group like so:
All initiator groups expanded

test_product_connection collapsed

Alternatively, a filter for initiator groups could be added to achieve similar ends.

Hello,
This is a great idea, and I have implemented it.
It is now available in  httpdbg v0.22.0.

Thank you for the suggestion.
Have a nice day,

0.22.0 looks good, closing.
Thanks!


Add initial support for traits.

Add initial support for traits, limited for now to methods with a self argument.
Default/blanket method implementations are not supported yet.
For now, trait constraints on type parameters are only supported on non-method functions.
The implementation follows the discussion at https://github.com/secure-foundations/verus/discussions/73 .  See test/traits.rs for details about what's supported and what's not yet supported.  See example/traits.rs for a simple executable example.

This pull request preserves the previous behavior of trait implementations for traits declared outside the crate being verified (such as Clone and Index).  The new behavior applies only to traits declared inside the crate being verified.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

I will try and get this done soon....


Set genealogy parent correctly to avoid multiple parents for graph refresh

Set genealogy parent correctly to avoid multiple parents for graph refresh
Only by doing child.parent = parent, we enforce that there can be on 1 parent at the time.
The hook variant is a low n+1 fro actual refresh, but it's used in some complex specs for graph refresh resolving cycles. The other is a custom saving code that does genealogy_parent assignment effectively and is currently used in AWS graph refresh.

@miq-bot assign @Fryguy

For backport purposes, #14060 is needed to be backported first (already backported to euwe, but not yet to darga)

@Fryguy should be only in Fine


Energy conservation

Hello,
What level of energy conservation can I expect from Athena's simulation? Are there conservation tests available to show Athena's consistency in this matter?
I am working on a simulation with a gravitational source term added to the problem generator. Should I expect a change to the accuracy of the conservation? If so, at what levels? Are there any ways to improve it?
Regards, Yotam.

To make gravity source terms conservative, one needs special care (e.g., http://adsabs.harvard.edu/abs/2013NewA...19...48J). This is not implemented in the current Athena.
Any source terms that are added as an operator-split fashion will hurt energy conservation. I believe @pdmullen had an experience of testing gravity source terms.

Hey @Yotag,
Thanks for the question! My experience with gravity in Athena++ is with the included FFT self-gravity solver.  As @changgoo mentioned, updates to energy from self-gravity are handled through source terms, not by constructing fluxes, and therefore total energy is not expected to be conserved to machine precision.
If you are not using the FFT self-gravity solver, but are rather implementing your own source terms, I would recommend looking at self_gravity.cpp for reference.
I have done some test problems for the FFT self-gravity solver.  One such test problem involves advecting a 1-D self-gravitating sheet once across a periodic domain.
compare.pdf
This problem involves adiabatic hydro with self-gravity and thus employs the self-gravity energy source terms.  The L_1 error for this problem converges at second order for both the vl2 and rk2 integrators.
conv.pdf
If interested, below is the time evolution of the total energy in these 1-D self-gravitating disk simulations at different resolutions.  Recall that for self-gravitating systems the total energy (without B-fields) is given as

etot.pdf
Best,
Patrick


OS detection via JavaScript

May be outside issue...
Is it possible to change the "identifier" in source code for OS detecting (http://browserspy.dk/os.php), but not affecting JS functionality and building?
The meaning of the not to be the white crow and easy prey for tracking, if I use a rare OS/distro.

Huh, I didn't realize there were other ways to detect the platform. But do we need to do this in the Chromium source code? If it can be done via an extension, it would benefit more than those who use ungoogled-chromium.

WebKit Trac has a good list about Fingerprinting.
Also see: https://github.com/Eloston/ungoogled-chromium/issues/13 https://github.com/Eloston/ungoogled-chromium/issues/55

From what I understand, ScriptSafe can deal with this. I don't see any need for ungoogled-chromium to do anything here.

I had to write this already for another repo but PLEASE DO NOT SPOOF YOUR OS, the only thing it does is make you so easily identifable it is astonishing. It is more than foolish to assume Github, Google etc. are not abusing this since at least a decade.
TCP/IP fingerprinting works without Javascript/HTML/CSS; just by pinging a server that server can tell your OS and even rough version like WinNT X, Linux Kernel xx etc. That's the reason mozilla decided to keep the original OS even if privacy.resistFingerprinting is enabled.
The only way to be "safe" (without external providers) is to setup a Windows VPN and pipe everything through it. Which (in my opinion) would defeat the purpose of "security" since your traffic passes through a propiertary code that, worse, isn't even remotely UNIX.
Best bet is to use a VPN service with many users that is hosted in a trustworthy EU country (as in DACH or BENELUX). Everything else should be considered unsafe, while anything from the Five Eyes countries should be considered malicious. If you care any percent about privacy and then still pipe your traffic through any of UK/US/CA/AU/NZ you should really just stop using the internet and open your private home to the general public, including that Nigerian prince.


Comparing kickers

lines 69, 70 - think should be ordered descending

This is definitely a bug. Thanks! Will be fixed.


Feature request: ability to scan specific policy

Description:
It would be very cool if the user could specify a singular policy to scan.
e.g: netfetch scan --target grafana-egress-network-policy
This would then list the pods that this policy targets. It could also list some more information about what the policy actually does and how it applies to the pod.

Are you planning on working on this? or I'll take it.

@roopeshsn I have been doing some work on this and I am planning to resume working on it. Stuck with some other assignments right now which has halted the progress here.

@roopeshsn I have been doing some work on this and I am planning to resume working on it. Stuck with some other assignments right now which has halted the progress here.

Cool

Initial logic for this implemented in #138.


Append headers in the interceptor

First of all, good work so far!
Second, is there a way (or are you considering a way) to append headers to the request inside the interceptor. That is the main thing I would need an http-interceptor for and yours is the best one i have found so far. So you know, it would be nice =)
Thanks.

Thanks for your interest.
This lib was designed to have full control of requests/responses so yep you can add headers to requests.
The way to do it is straightforward, suppose you have next interceptor:
httpInterceptor.request().addInterceptor((data: any[], method: string) => {
  // data - Here is an array of arguments which where passed when made http request
  // so for http.get('/my-url') it will be simply ['/my-url']
  // You can modify it the way you want but keep in mind that this array will then be
  // a set of arguments provided to make an http request
  // And since you can add headers to every request in Angular2 Http service
  // you can do same here - just update `data` array like so:
  data[1] = new RequestOptions({headers: new Headers({'X-My-Header': 'value'})});
  // Index 1 here is because RequestOptions is the second argument for Http.get() method
  // and data[0] - is the request url which you also can verify/change
  return data;
});

This is "dirty" way to do it because you probably want to check if RequestOptions already passed to the request and then you will need to add only headers you want, but it gives you an idea how to do this in basic.
Also please note that for some requests like post index of RequestOptions is shifted right because it has body argument before.
Hope all that I wrote is easy to understand =)
And since this feature already supported I will close issue but feel free to continue discussion if you have more questions or whatever.

Thank you! I actually tried to append "new Headers()" to the data Array but with no luck. Didnt think of RequestOptions. Awesome, thanks!


QMAPS-2428 - Tripadvisor / Pagesjaunes in history

Description
Add TripAdvisor and PagesJaunes POI to the history.
Add POI category to the history too.

To be discussed with Charlotte.
During my tests on this branch, I remarked that the following elements were added in the history:

intention (ex: parc / parc nice / hotel / hotel nice / restaurant / restaurant nice)
TripAd POI (ex: one hotel from a poi list)
PJ POI (ex: a restaurant from a poi list)
OSM PoI (ex: type"tour eiffel" or "societe generale nice musiciens" or "hotel negresco nice" in the search field)

And these elements were not:

LatLon POI (gps coordinates if clicking anywhere on the map)
OSM poi (if it is clicked on the map)

Other point to discuss wwith Charlotte:
Should we show intentions from the history in the suggest? I think we should not. See example below:

i think the "nearby" should not appear in the suggest under a category name


[terra-clinical-item-display] Update truncated text examples

Summary

What was changed:

Update doc site examples to use different preview text instead of full text in the clinical item display

Why it was changed:

Truncated text can change the user experience and it was suggested it is best to provide as much of an equitable experience to all users as possible

Testing

This change was tested using:

[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[x] No tests are needed

Updates made to the clinical item display truncated examples:

Reviews
In addition to engineering reviews, this PR needs:

[x] UX review
[x] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9340

Thank you for contributing to Terra.
@cerner/terra

Fails
🚫	Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG entry is missing for:

terra-clinical-item-display

Generated by 🚫 dangerJS against 3d1963e

I think these changes do not require updates to the changelog as it is just really minor updates to 2 examples

Discussed offline with @adoroshk about updating the Show Hide example to meet accessibility and Alla helped with those updates. Thank you!

@trandrew1023 - as we discussed, let's meet with Eric and see if we can create a more realistic truncation example. Show/Hide and Slide Panel are not the best options or patterns that we want to encourage consumers to use. Thanks!

@mjpalazzo @eawww  The examples have been updated to be a single example of truncated item displays inside a Terra List. By default, the full text is currently being used in the truncated item display with different methods of disclosing for keyboard users:

Terra Popup

The popup component is not scrollable via keyboard

Modal/dialog

This method seems stable

Toggling truncated prop

This example was just added for testing toggling the prop and will likely be removed

Terra Toggle Button

@trandrew1023 - Thanks for improving these examples. They are working better. Here are some observations and changes needed before I can approve: I would like you to remove the Toggle Truncation Example. It appears to use Terra Show Hide which is not a pattern we want discourage consumers from using. Also the button state is not being announced when it is expanded and collapsed. The Toggle Button example shows the pattern we would like consumers to use. It is more accessible than Show Hide. The button state is announced when expanded or collapsed. The problem with this example is I could not get JAWS to announce the content after I pressed Enter to expand. Down Arrow should take me to the disclosed text but it does not.

Thank you for the feedback @mjpalazzo, the Toggle Truncation Example and suggestion to use "Show/Hide" has been removed from the accessibility guide. The Toggle Button example has also been updated so that down arrow will read select the Item Display content. Thanks!


fix: fix permalink redirecting (close #1516)

What is the purpose of this pull request?

[x] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 3 (33.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 41.733%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/client/src/router/resolveRoutePath.ts
0
1
0.0%

packages/core/src/app/prepare/prepareRoutes.ts
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.05%

Covered Lines:
685

Relevant Lines:
1683

💛  - Coveralls


Remove widget generation wizard

Description:
Let's remove widget generation wizard from the analytics pack as widgets generated from the wizard cannot be used directly in dashboards for real usecases.

@RAVEENSR : Please check whether referenced issues also fixed when removing the wizard.


Installation issue

Hi,
I am trying to install deepsphere tf2. Although, it shows that the installation is completed, however, when trying to import dependencies from deepsphere, the following error occurs:
cannot import name 'SphereHealpix' from 'pygsp.graphs'
How should I solve this?
Many Thanks

Hi
Thanks for your prompt reply. I have installed the given PyGSP version from the link, but the issue seems to remain the same. I am using python 3.10.5.
Many Thanks

I cannot reproduce this issue. I just created a new 3.10 environment and get the correct dependencies with the requirements install.
Could you send me the output of pip freeze?
Can you try to create a fresh venv / conda env?
Otherwise, because the PyGSP version is quite low, you might need to force a reinstall:
pip install --force-reinstall git+https://github.com/jafluri/pygsp.git@sphere-graphs

Hi
Thanks for the advice. I shall try this with fresh conda env.
pip freeze produced a huge list with versions of installed packages etc. Not sure if you wanted to see that.
PyGSP, which I found there, is 0.5.1. probably this version is causing my issue.
Many Thanks

Hi,
Thanks for your help. I have been able to insall deepsphere in a fresh conda env. There is still, however, a conflict sustained with the tensorflow and numpy version.
An error prompted from healpy_networks.py  script, at the line 70.
The Error reads: module 'numpy' has no attribute 'int'.
np.int was a deprecated alias for the builtin int. To avoid this error in existing code, use int by itself. Doing this will not modify any behavior and is safe. When replacing np.int, you may wish to use e.g. np.int64 or np.int32 to specify the precision. If you wish to review your current use, check the release note link for additional information.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
Many Thanks

You are right, the newest version of numpy removes np.int, so I replaced it with python standard ints. If you have not already changed it yourself, pull the repo should fix it.

Hi,
Yes, I have replaced it. Another conflict I encountered is that the specified Scipy version is not compatible with the current python version. New version of scipy promts the following error:
File _ckdtree.pyx:783, in scipy.spatial._ckdtree.cKDTree.query()
File _ckdtree.pyx:387, in scipy.spatial._ckdtree.get_num_workers()
TypeError: Unexpected keyword argument {'n_jobs': -1}
This is because the 'n_jobs' argument has been renamed in the new version of scipy. I am not entirely sure how to work around that. Thanks a lot for your continuous support.
Many Thanks
Wasim

Yes, makes sence, the PyGSP is on the same decrepated version of numpy and scipy as deepsphere was. I just updated the repo, please reinstall PyGSP via:
pip install --force-reinstall git+https://github.com/jafluri/pygsp.git@sphere-graphs
and try again.

Hi,
Thanks for the update. It works now. I cannot thank you enough for this great package that you ( and your team) have developed. You have done service to humanity.
Easter Greetings to you. Have a wonderful time.
Many Thanks
Wasim

Thanks, glad that it works!
Happy Easter.


Error: NotFoundError - Resource not found while implementing llama index with Azure OpenAI for fine-tuning

Description:
During the implementation of the llama index with Azure OpenAI for fine-tuning, the following error occurred:
Retrying llama_index.llms.openai.base.OpenAI._chat in 0.6394267984578837 seconds as it raised NotFoundError: Error code: 404 - {'error': {'code': '404', 'message': 'Resource not found'}}.

Code snippet:
# Perform query to retrieve the contexts and answers for the generated questions

self.llm = OpenAI(
    api_base=self.azure_openai_endpoint,
    api_key=self.azure_openai_api_key,
    api_version=self.azure_openai_api_version,
    model=self.model,
    temperature=self.temperature
)

query_engine = index.as_query_engine(similarity_top_k=2, llm=self.llm)

Additional Information:
The error seems to be related to a NotFound error with code 404 indicating that the requested resource was not found.
Problem Statement:
The issue occurs while trying to execute the query using Azure OpenAI. The error message suggests that the resource being requested is not found.
Solution Required:
Please provide guidance on how to resolve this issue as I am unsure how to proceed.

Is the name of the deployment the same as the model? Azure OpenAI has an ability to change the name of the deployment compared to the model. Please see the llama index sample for more information
https://github.com/Azure/azure-search-vector-samples/blob/main/demo-python/code/community-integration/llamaindex/azure-search-vector-python-llamaindex-sample.ipynb


Plugin somehow using old marker data

It seems that the plugin has started using marker data from before the 2.0.0 migration. I can tell because markers I add a few days ago have disappeared, and markers I deleted a few months ago have reappeared.
Even after renaming the marker folder in the plugins/BlueMap-Marker directory and restarting the server, the old markers still appear.
Using BMM 2.1.5 on Paper 1.21.1.

Since 2.0 all markers in paper are stored in the folder plugins/BMMarker/.... If you migrated your old markers, you can delete the old folder to avoid unwanted migrations.
Editing files while the server is running also result in weird duplications of files. If you already renamed all folders, search for one that looks inside like the following and rename it back to BMMarker while the server is offline (the backup folder may not exist for you).

All fixed! I had to rename the BlueMap-Marker folder to BMMarker. There was already a BMMarker folder in the plugins directory but I renamed it to something else just in case. No idea how that happened...


ACP-118: Specify SignatureRequest handler ID

Updates the ACP-118 specification to include the canonical handler ID that should be used by all VMs to register SignatureRequest handler implementations.
Specifies the canonical handler ID as 1, incrementing from the only other handler ID registration, which uses a handler ID of 0.

Want to link the AvalancheGo PR with the reference implementation and mark this ACP as "implementable"?

My slight preference would be to link to the merged source code, rather than a pull request. If this gets merged before the AvalancheGo PR, then we can follow up with another PR to mark the ACP as implementable.


unable to render scrolling position

Same question in bubkoo/html-to-image#81
And, I noticed there's a PR#209  attempting to solve this problem, I implemented it on my fork.
The effect is as follows:

Can I make a PR? I may need help adding test cases as I am unable to run the test
Steps To Reproduce

Playground for https://codesandbox.io
Your Environment

modern-screenshot: 4.4.33
Browser: Chrome/<IP_ADDRESS>

Good, welcome to submit PR, but I prefer to move the option to features

#52 #78


Add download stats to download detail pages

Need to get the addon download stats from the mirrors server.  Example URL:
http://mirrors.kodi.tv/addons/matrix/script.module.trakt/script.module.trakt-3.1.0+matrix.2.zip?stats

I have code done for this, but so far it fails for an unknown reason when it has to update more than a few addons. More investigation will be needed.

Now that the process for parsing the addons.xml file is separate from Gatsby, I think it will now be possible to add download counts. But they would be download counts for the current version, not all time download counts. Part of that is technical (there isn't a great way to store the historical count and then make sure you aren't double counting stuff), but I would also argue that downloads of the current version are a better reflection on popularity.  If I download and keep using an addon, every time an update comes out, it will update. So the current download count is a reflection of active users.  Using a historic count, every time an add-on updates, it's historic download count will sky rocket. So an add-on that was popular once might always end up at the top of list because of three or four versions of big download numbers. New entries will never make the popular list if they have to overcome 10 years of history of downloads.

but I would also argue that downloads of the current version are a better reflection on popularity

Yes I agree. What was popular or working 5 years ago, may not be the case today.

done with a0e21f47a2df7774b3689d367b5d46ef09bc0972 and fc515a6c3284d70792e2612b3430a58737d37bca. I'm going to leave this open for a couple days to see if there's any feedback.

So you are asking mirrorbits for downloadstats of every single addon?

Yes. That seems to be the only way of which I'm aware to do it. It's only happening once a day via the script in the GitHub action. It doesn't feel ideal, and if there's another way to get the stats, I'm open to changing this. Or even reducing the frequency to every couple of days or even once a week if needed. BTW, it takes about 5 minutes to get all the stats for one repo branch (so about 10 minutes to get both Leia and Matrix).

that sounds like a DOS attack on mirrors :( When did this last run?
Too bad we don't have decent monitoring there atm, would be interesting to see the load this causes.
Generally, I don't like this and we should look for a better solution, e.g. doing a redis export, which at least wouldn't impact mirrorbits that much.

I ran the script once on my laptop maybe 12 hours ago. The run from the GitHub action went around 2:36AM UTC (or it finished around there after 10 minutes, not sure which).  I completely understand your concerns.  I'm unfamiliar with mirrorbits or what doing a redis export entails.  Can that be done on a schedule and put somewhere that a Github action can get to it? If so, and if I can get a sample export for Matrix (and Leia if possible), then I can figure out how to parse and use that instead.  If not that, I can look at introducing a pause between requests to make the load less spiky.  Honestly, whether the job takes 10 minutes or 4 hours doesn't matter all that much.  I do see that Github limits a job run to 6 hours before killing it, so if we have to go that route we just have to keep that in mind.

The current website already does this every 24h afaik

how about http://mirrors.kodi.tv/.stats/redis_file_stats_20210308.json
We can quite easily export this every day

@wsnipex That's a good start, and I could definitely use that instead.  The URL I'm using right now:
http://mirrors.kodi.tv/addons/matrix/script.module.trakt/script.module.trakt-3.1.0+matrix.2.zip?stats
gives daily, monthly, and total downloads for the given file. Since we're planning on have the download stats be "of the current version" and not cumulative, the total one is of most interest.  I think the JSON you linked to has the daily downloads.  Could I get one that has totals instead and have the file named the same thing every time?

There is no "all downloads since the dawn of time" key in the DB, but we have "downloads since start of year".
http://mirrors.kodi.tv/.stats/redis_file_stats.json
Currently there is only 2021, since we started fresh, so you have to be prepared to accumulate years yourself when 2022 comes.

I can work with that.  Thanks.

@wsnipex I have updated the script with PR 89db9ac2054742145cedf308a8f3d04df287cea1 to grab the summary file from the URL you provided.  At your convenience could you set that file to be updated daily and let me know when it's scheduled? Then I can update the run time on the parsing script if needed so that we get pretty fresh data.
Thanks both for pointing out the issue and helping with the solution.  I appreciate it.  And the script only takes like 45 seconds to run now instead of 5 minutes.


[github-actions] meshcop check fails frequently

Console/log output
logs_6102.zip

The log shows that running command ot-ctl thread start gives InvalidArgs error:
2021-03-21T18:10:47.3402847Z + sudo /home/runner/work/ot-br-posix/ot-br-posix/build/otbr/third_party/openthread/repo/src/posix/ot-ctl thread start
2021-03-21T18:10:47.3404026Z otbr-agent[15292]: [WARN]-PLAT----: processTransmit: Drop
2021-03-21T18:10:47.3405350Z otbr-agent[15292]: [NOTE]-PLAT----: Will not subscribe duplicate multicast address ff03::fc
2021-03-21T18:10:47.3406765Z otbr-agent[15292]: [NOTE]-PLAT----: Will not subscribe duplicate multicast address ff03::1
2021-03-21T18:10:47.3408440Z otbr-agent[15292]: [NOTE]-PLAT----: Will not subscribe duplicate multicast address ff02::16
2021-03-21T18:10:47.3409881Z otbr-agent[15292]: [WARN]-PLAT----: Failed to subscribe multicast address ff02::2: InvalidArgs
2021-03-21T18:10:47.3410897Z otbr-agent[15292]: [INFO]-PLAT----: Session socket is ready
2021-03-21T18:10:47.3411485Z Error 7: InvalidArgs

We have seen such issues in external commissioner tests in openthread/openthread github actions. I suspect that OT CLI doesn't receive the whole command thread start.

trying reproduce this issue in https://github.com/openthread/ot-br-posix/pull/753

Resolved by https://github.com/openthread/openthread/pull/6333


[STORM-1964] Unexpected behavior when using count window together with timestamp extraction

Do not use timestamp to determine the event count in WatermarkCountEvictionPolicy
when count based trigger is used.

+1


Do not add "undefined" to the beginning of the result of .fixMarkup()

Fixes #1452

Added default return value (empty string) to the ".replace()" call.

I tried to keep to the existing code style, and I added a test for the fix.

Oops... That's the thing with german keyboards. Typing " is almost easier than typing '. I always get it confused.
I've changed that and made a force-push to my branch to no pollute history...

Thanks, merged! (Don't really care about history "pollution" myself :-) )


Account pages

Your PR Server URL is https://near-wallet-pr-109.onrender.com.
Follow its progress at https://dashboard.render.com/web/srv-bkp2cu0rvnpqtm6f53r0.
Cheers,
The Render Team


[BUG] Link broken to prompt template documentation when running LLM node with incorrect prompt template

Describe the bug

A prompt flow with LLM nodes is defined.
The prompt flow is then run in test mode within VSCode locally.
The prompt definition itself does not use the expected prompt template format, i.e. 'system:\n','user:\n','assistant:\n','function:\n'
The error message states "The Chat API requires a specific format for prompt definition, and the prompt should include separate lines as role delimiters: 'system:\n','user:\n','assistant:\n','function:\n'......." and includes a link to the prompt template documentation.
The link is broken.

How To Reproduce the bug
Steps to reproduce the behavior, how frequent can you experience the bug:

Run a flow with an LLM node in chat mode with an incorrect prompt template format.

Thank you for the feed back. We will update the https://aka.ms/pfdoc/chat-prompt .

hi @corticalstack this link has been fixed, please have a try. Thanks for reporting this.


Comma-separated const declarations not accepted (Redux)

Affected page
https://www.freecodecamp.org/learn/front-end-libraries/redux/use-const-for-action-types
Expected behavior
The following two code snippets are both correct and semantically equivalent js, but one passes all tests and the other does not. Either both should pass or both should fail.
Passes:
const LOGIN = `LOGIN`;
const LOGOUT = `LOGOUT`;

Fails:
const LOGIN = `LOGIN`
    , LOGOUT = `LOGOUT`;

Declaring multiple comma separated const's fails this test:
LOGIN and LOGOUT should be declared as const values and should be assigned strings of LOGIN and LOGOUT.
Your code
Copy and paste the code from the editor that you used in between the back-ticks below:
const LOGIN = 'LOGIN'
    , LOGOUT = 'LOGOUT';

const defaultState = {
  authenticated: false
};

const authReducer = (state = defaultState, action) => {

  switch (action.type) {
    case LOGIN:
      return {
        authenticated: true
      }
    case LOGOUT:
      return {
        authenticated: false
      }

    default:
      return state;

  }

};

const store = Redux.createStore(authReducer);

const loginUser = () => {
  return {
    type: LOGIN
  }
};

const logoutUser = () => {
  return {
    type: LOGOUT
  }
};

System (please complete the following information):

Browser: Firefox 90.0b6

The test currently checks for two separate const declarations. You can view it here - Use const for action types
I think the regex can be updated to fix this.

I can grab this, if no one else is working on it.

Hi @patlehmann1, any issue with the help wanted or first timers only label is open for contribution. So yeah you can start working on it.


How would I install this in Linux?

How would I install this in Linux?
I clone the repository and issued a "make" command but the terminal does not pick up the program.

You can run any executable by typing its path, e.g. type ./walk after running make. If you want to just type the name, e.g. walk, you need to install the executable by copying it to a directory in your $PATH.

Many thanks. It works.

I think this should be closed.

I think this should be closed.

I don't think it should be closed and I'm preparing an example that can be added to the main README.md.

Hello again,
I tested these steps on Ubuntu 20.04 with bash for shell.
There's only one distinction in the installation steps, whether the user prefers a local (user-only) installation, or system-wide (requires root/sudo access).
Step 1: build from source
git clone https://github.com/google/walk.git
cd walk
make

Step 2A: Installation for non-root user
mkdir -p ~/local/{bin,share/man/man1}
cp -av -t ~/local/bin sor walk
cp -av -t ~/local/share/man/man1 sor.1 walk.1

cat << EOF > ~/.walkrc
export PATH="\${PATH}:\${HOME}/local/bin"
export MANPATH="\${MANPATH}:\${HOME}/local/share/man/man1"
EOF

cat << EOF >> .bashrc
if [[ -f ~/.walkrc ]]; then
    . ~/.walkrc
fi
EOF

Step 2B: Installation as root (system-wide)
sudo mkdir -p /usr/local/{bin,share/man/man1}
sudo cp -av -t /usr/local/bin sor walk
sudo cp -av -t /usr/local/share/man/man1 sor.1 walk.1
sudo chown root.0 /usr/local/bin/{sor,walk}
sudo chmod 755 /usr/local/bin/{sor,walk}
sudo chown root.0 /usr/local/share/man/man1/{sor.1,walk.1}
sudo chmod a+r /usr/local/share/man/man1/{sor.1,walk.1}

IMHO, this actually belongs in the makefile, but it's literally better to have some shell commands documented than nothing.
Unfortunatelly, I don't know how to write good Makefiles.
Anyhow please someone test this and confirm the steps also work for you.

There's only one distinction in the installation steps, whether the user prefers a local (user-only) installation, or system-wide (requires root/sudo access).

[…]

IMHO, this actually belongs in the makefile, but it's literally better to have some shell commands documented than nothing. Unfortunatelly, I don't know how to write good Makefiles.

Seems overkill to me, just drop an install: target with PREFIX into Makefile, with four cp commands.
IMO no shell runcontrol editing should be performed in the setup, either the file goes into a standard directory in PATH or the user has to know what they are doing.
Rather than this I'd focus on the fact that I have not been able to get a reply from either @bbarenblat or @cryslith since 2021-01-29, where I asked for an official release tag or Void wouldn't package it.
I don't know what other systems packaging policies are but I guess it wouldn't hurt having a proper release.
If anything ask your distro managers to package this, having this available in "mainstream" distributions (Debian, Ubuntu, Centos, WhateverOS) is likely to have a bigger impact on end-user adoption.
I like the utility very much and have switched my memory muscle to use it in place of find since I stumbled onto it, it bugs me not having the package on my everyday system official repo (I carry the package I built around).

@anddam How is that possibly my problem?  It's not my software.

My bad, I just went over the "Contributors" side panel on the repo.
I'll reply in #3 .

Hello! Original author here. I’m not sure how I missed this. I’m not opposed at all to adding a make install target; I’ll add one right now.
The primary development repository for this project has moved to https://git.benjamin.barenblat.name/walk (mirrored at https://github.com/bbarenblat/walk), so watch that space.


Chemical compatibility test: Formlab resins vs. KOHaq

Sample
Resin
Solution
Temperature (°C)
$m_{t_0}$ (g)
$m_{t=23h}$ (g)
$\Delta_{m, t=23h}$ / %
m_51h

1
clear v4
KOH 29.9 w%
~20
1.206
1.2043
-0.141
1.2045

2
clear v4
KOH 29.9 w%
~45
1.2112
1.2085
-0.223
1.2090

Lets to the 10k rigid cubes with the same dimension, as these fit perfectly into the round neck flasks -> 1cm^3
Numbering is perfect
Please print directly on the platform -> results in more homogeneous shape
Sorry, I don´t get the question
Yes, exactly

sorry, were samples 1 and 2 printed directly on the platform, or were they ones with a base?

Ah, I think they were both not printed on the base, if I remember correctly

All good - probably shouldn't matter, just wanted to double check.

Chemical compatibility after 51 hours still seems to be reasonable good. No clear degradation could be observed. However, I think it will be a lot more interesting, investigating at 70 or 80°C. Haven't done that so far, because the hotplate did not get the water bath warm enough. Will do that next week for a couple of hours with a flask directly placed on the hotplate.

Sounds good! If it stabilizes, that would be ideal.

Definitely.
I just figured out that the safety temperature of these hotplates controlles the temperature of the hotplate itself, not the one measured by the thermocouple (it works that way with the ones I use back home). This is why I did not get to the desired 70°C in the water bath. Will repeat the high temperature experiments next week with both, v4 and rigid 10k resin.

I added a last value of the compatibility test at room temperature. As you can see, over time the mass is slightly increasing, which might either be due to not perfectly washed cubes with remaining KOH on the surface or to some kind of swelling mechanism. Either way, the mass remains more or less constant over time at room temperature. The more interesting tests will start when I do electrochemical tests at elevated temperatures. For now, I think we are good to proceed this way


Add button type property in mwc-button

Issue: Button type submit #205

Related to #289

Related to #289

@dfreedm I know that is related to the form submit ticket, but why should that block adding this feature?

What does adding this feature without custom element form submission accomplish?
An <mwc-button type="submit"> inside a <form> element will not submit it. I'd be cautious about adding type="submit" which could imply to users that form submission works when it doesn't.

Makes sense @asyncLiz, thanks. We'll need to wait on the result of #289

Closing as obsolete

The type attribute wasn't added to button? Is it resolved in some other way?

Sorry about that! Was going through and cleaning up a lot of old issues :)

would it make sense to rebase this PR and try to get it ready to merge?

would it make sense to rebase this PR and try to get it ready to merge?

If you can rebase it for MWC (skip M3), I'll review it :)

Obsolete with M3. See https://github.com/material-components/material-web/issues/3941 for upcoming support


You can share this repository

https://prod.liveshare.vsengsaas.visualstudio.com/join?C6D99FE8B825D1E228C15DC5995B2377FD3E

Link was validated. Close Issue


Use-case: Code Server in Docker/Singularity

Hi @anibalsolon, great plugin. I've used it and it works seamlessly in VSCode. I have a separate use-case to propose and see if it's in the scope of your work.
Our group uses code-server on an HPC cluster which runs a VSCode backend in a singularity image, and forwards the port to a local machine. You can see how that's done here in docker and here in singularity. Our use case is here.
Our current only limitation is that we cannot open images that are on the cluster with NeuroViewer. When we select an image, it hangs on the Loading screen.
Let me know if this is something you'd consider adding as a feature, or if there is anywhere you can point me to start digging around as to how you load images -- maybe I can PR.
Thanks!

hey @TinasheMTapera thank you for the feedback- Let me ask you, is code-server the same as what Github uses in github.dev? If so, the last version of the extension is working there, maybe you can try to update the extension?
https://github.dev/Washington-University/HCPpipelines/blob/master/global/templates/MNI152_T1_2mm.nii.gz
After installing the extension, it looks like this:

If not, I'll def look into it. This extension was mainly build to open images where it is harder to open e.g. clusters.

It looks to be the same architecture, yes! Unfortunately I'm having trouble installing the latest version. Within code-server, the latest available version is 0.0.9 as current. I'm not sure if perhaps there's some marketplace configuration I need to fix there?
Alternatively, I tried to install from VSIX file, and instead got the error that 0.0.13 is unavailable for my version of code-server:
Singularity> code-server --version
4.2.0 693b1fac04524bb0e0cfbb93afc85702263329bb with Code 1.64.2

Note that this code-server instance was only installed and began running a couple of days ago, so it's pretty up-to-date.
Thoughts?

Not sure! So from a brief research, I found out that it does not use the official marketplace, but the Open VSX one. The extension is in its last version there: https://open-vsx.org/extension/anibalsolon/neuro-viewer
It is weird that is saying it is unavailable, have you tried to directly install the .vsix file?
I've spun up a Docker code-server here, and it shows me the last extension version (0.0.13). Is is possible that it has some sort of cache on apps versions?
Nevertheless, I was able to reproduce your error (even with the last version). It happens because of the way it tries to download the interface files (javascript), a security feature is currently blocking it. I will try to figure this out and let you know!

Thanks! Yes I have tried to directly install from vsix, and instead got the error that 0.0.13 is unavailable for my version of code-server.
Unable to install extension 'anibalsolon.neuro-viewer' as it is not compatible with VS Code '1.64.2'.

Additionally (I guess somewhat important) is that I downloaded a bunch of different versions of VSIX files and was successfully able to install 0.0.10, that's the highest version I got installed successfully but it still hangs at loading screen.

@TinasheMTapera I've found out the issue, and that's mainly related on how the data was being loaded (using websockets). For now, I have turned to a less-optimal way, but one that is able to work in code-server without extra configuration.
Would you like to give it a try?
https://github.com/anibalsolon/vscode-neuro-viewer/releases/download/v0.0.14-4/neuro-viewer-0.0.14-4.vsix

@TinasheMTapera if you still have issues, let me know!

@TinasheMTapera thanks for the follow up- would you know if it is permission that the extension requires to work? Maybe the extension can be changed in such a way that it does not require this permission. I'd be happy to help dig the issue, it is a good use case with code-server.

It's a pretty narrow corner case, I believe https://pennlinc.github.io/docs/cubic#file-permissions-on-cubic
I wouldn't worry too much about it since our cluster is just a very odd case, but if you would like for me to get more detailed diagnostics let me know!


Changing language mode keeps previous linter and shows non-errors

VSCode Version: 1.0.0-alpha
OS Version: Windows 10

Steps to Reproduce:

Open an HTML file
Change language mode to Javascript
Change back to HTML

Actual:
Showing many errors as it still thinks it is in Javascript language mode.

Duplicate of #5193


Fix textarea

Resolve the bug that users cannot submit reasons found in release test.

Pull Request Test Coverage Report for Build 987062434

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.107%

Totals

Change from base Build 986226157:
0.0%

Covered Lines:
950

Relevant Lines:
1076

💛  - Coveralls


API break: rewrite PaymentProtocol classes

These classes haven't been touched up since they were first written. The PR simplifies the interactions with protobuf classes, and includes a bunch of tests.

HttpFoundation requires PHP5.5+. Seems as good a time as ever to deprecate 5.4


Not visible after copying on the SD Card

When I copy a picture into a folder on my SD Card it shows that it is successfully copied, but I can't see it in the new folder. The Copy action was successful I can see the picture in a different gallery app just fine but in Camera Roll itself it doesn't even show after reloading the pictures.
This only happens if I copy the pictures to the sd card, on the internal storage everything is fine.
This is on Android 7.1.2.
I was thinking maybe your copying the image correctly, but then there is an issue with adding the picture to the Media Scanner of Android.

Thats weird.
After any file operation MediaScannerConnection.scanFile() is called with all the affected files.
I will look into this issue.

Are you adding the file via the absolute path like /storage/...? I remember the media scanner using different file paths for external storage so they can control who has access but I don't know if that's also the case for adding files

Strange I just tried copying files again and it showed them directly...

So its working?

Just tried with a new folder and it seems to be working fine now
I think you can close this


Frontmatter of a created event

Happy to delete or move if this is not appropriate for here...

Would putting additional key: values in the frontmatter of an event note, cause any problems down the line in FC? Would it confuse FC or make it the event non-functional?

The plugin will ignore any extra frontmatter entries, and will not overwrite them. I don't think the parser is smart enough to deal with key/value pairs that take up multiple lines. So instead of
arraykey:
  - value
  - value
  - value

You should write
arraykey: [value, value, value]

I should add a note that we might add new frontmatter fields to enable two-way sync and other features down the line. And issue #70 is something I plan to work on, although any migration process would need to have a way to fail gracefully.

I'm labeling this as a question and marking it answered by closing it, but please free to follow up if you have another question :)


python,misc: Add reorder-python-imports hook to pre-commit

This:

Adds reorder-python-imports to pre-commit.
Applies this to all files in the repo.
Adds (2.) to ".git-blame-ignore-revs".

I'd suggest that we use isort instead which seems more popular on GitHub and it is known to work well with black. I usually use that for my own projects. I personally like this isort configuration:
[tool.isort]
profile = "black"
multi_line_output = 3
force_grid_wrap = 2

This ensures that multiple imports from the same module end up in a list instead of as separate import statements. I generally find that more readable. For example, we currently get this:
from foo import bar
from foo import baz

With the isort configuration above, you get this instead:
from foo import (
    bar,
    baz,
)

I have had a quick look at the way this changes Python files. There is some weirdness that we need to resolve if we decide to use this tool (I would prefer isort):

Some comment blocks seem to be modified for no good reason.
Local includes and m5 includes are mixed. That seems a bit weird.

We probably don't need to remove this from the blame history. It's a pretty localised change, so I it would cause a lot of issues if it appears in blame. In fact, that might be desirable since changes to the import order could potentially come with unforeseen side-effects.

+1 for isort and that local includes and m5 should be separate.
Thanks for pointing these things out, Andreas!

Good points. Seems like isort is the way to go. I'm closing this PR in favor of #431


session-manager-plugin support

Expected Behavior
Be useful for AWS packer builds
Current Behavior
Not useful - forked
Dockerfile that works in my case:
FROM ubuntu:latest

RUN set -e;  \
    apt-get update && apt-get install -y curl apt-transport-https ca-certificates gnupg; \
    echo "deb [arch=amd64] https://apt.releases.hashicorp.com $(. /etc/lsb-release; echo "$DISTRIB_CODENAME") main" > /etc/apt/sources.list.d/hashicorp.list; \
    curl -fsSL https://apt.releases.hashicorp.com/gpg | apt-key add -; \
    apt-get update -o Dir::Etc::sourcelist=sources.list.d/hashicorp.list -o Dir::Etc::sourceparts=- -o APT::Get::List-Cleanup=0; \
    apt-get install -y packer; \
    curl "https://s3.amazonaws.com/session-manager-downloads/plugin/latest/ubuntu_64bit/session-manager-plugin.deb" -o /tmp/session-manager-plugin.deb; \
    dpkg -i /tmp/session-manager-plugin.deb; \
    apt-get autoremove -y curl apt-transport-https ca-certificates gnupg; \
    apt-get clean

COPY "entrypoint.sh" "/entrypoint.sh"

ENTRYPOINT ["/entrypoint.sh"]

Maybe it can be useful to allow to specify dockerfile content and override default one?
Steps to Reproduce
Try to build AMI in AWS with SSM session
Environment
AWS account with SSM session for connections

I also have a feeling the session manager plugin isn't working properly using this action.
Getting the following error when packer trying to connect to an EC2 instance via SSM:
"session-manager-plugin": executable file not found in $PATH

I think the only option may be to add it to the docker file like this https://github.com/aws/session-manager-plugin/issues/12#issuecomment-972880203 - trying to evaluate it, or switch from packer:light to other docker, like ubuntu based but it seems this is not desired based on https://github.com/hashicorp/docker-hub-images/issues/100
If the trick with docker RUN on alpine will work I will try to add a PR that will allow such steps, if not - only fork locally and adjust for your needs, also one more customisation I can think of it packer init support but as I understand this is only possible with new version https://github.com/hashicorp/packer-github-actions/pull/47

This worked for my case - but only in fork of this repo, as I'm changing the base Docker image
https://github.com/skeggse/docker-packer-ssm/blob/main/Dockerfile

Thank you for reporting this @123BLiN.
In the legacy version of this Action, this wasn't supported. You should be able to use SSM (and similar tooling) with the latest version of this Action.
See #63

Got the same error Getting the following error when packer trying to connect to an EC2 instance via SSM:
"session-manager-plugin": executable file not found in $PATH , while trying to use github actions. Previously had a stage defined for installing session mananger . At the end I added
RUN wget https://s3.amazonaws.com/session-manager-downloads/plugin/latest/ubuntu_64bit/session-manager-plugin.deb && dpkg -i session-manager-plugin.deb && rm session-manager-plugin.deb in my docker file and it worked.


asm.js

asm.js http://asmjs.org/

This issue was imported from Google Moderator
Moderator votes: +4
Issue added by Marv on 2014-08-22
To vote this issue up or down, simply include +1 or -1 in your comment.

+1

+1

+1

+1

+1 especially since it is now enabled by default in MS Edge: https://dev.modern.ie/platform/changelog/10532-pc/

Now available at http://caniuse.com/#feat=asmjs


Off-by-one in the shader?

 If I select the first palette I add, the default palette is rendered with the shader, selecting the second palette renders the first, etc.
If I add 0.5 to the sampling column it seems to solve the problem.
vec4 outputSample = texture2D(u_sPalette, u_vTexel*vec2(u_fColumn + 0.5, moduloValue + 0.5));

This is a cool technique though I do not yet grasp how the modulo indexing works.

Oops that was in there originally GML-side but I forgot to migrate that across at some point. Shall fix.

https://github.com/JujuAdams/ColorMod/commit/775ea2521309986608f03106b77d6aaacc6c05eb


Introduce the controller module of the daemon.

Getting rid of the -pedantic flag to suppress multiple redefinition compilation warnings.
Compiling and linking against the libsoup library which in turn depends of GLib and GIO libs.
Creating and starting up the Soup web server with built-in defaults.

She looks consistent and straightforward ! :+1: — Approved. :blue_heart:


Add sloped sprites to wallcf8, wallcf16, and wallcf32

The next of my sloped wall PRs. As before, these sprites were made by ripping existing sprites and hand-editing in Paint.NET. Pinging @ZeeMaji for review.

One interesting thing about this wall is that (I think) it is meant to match the shiny castle walls, which have sloped sprites but those sprites do not line up with the ground—they are shifted up by a pixel, so they hover off the ground. In this screenshot, on the left are two 16-high walls, and on the right is a 16-high wall with a castle wall atop it. You can see the seam. This seems like an issue with the castle wall itself and I don't think that wallcf should replicate this behavior.

How do they look when they're combined with the gray sandstone edge?

Looks good to me.


Possible bug in TinyLlama's dataloading

Hi,
Can I check why did you shuffle the filenames here? https://github.com/jzhang38/TinyLlama/blob/main/pretrain/tinyllama.py#L308).

To my understanding, shuffling results in different nodes taking partitions of the different list of filenames. Hence, a filename might be processed twice by different nodes (i.e. *0.bin in diagram), which implies another filename is left out.

To my understanding, what we want is for different nodes to take partitions of the same list of filenames, so that every filename is included.

I’ve verified the above by checking if the filename (i.e. train_slimpajama_214_0000000275.bin for me) exist in the list of filenames. In my run, this filename which is read by different nodes.

After my fix (see below), this file name is only read by one node.
filenames = sorted(glob.glob(str(data_dir / f"{prefix}*")))
# random.seed(seed)
# random.shuffle(filenames)

Is my understanding correct? Many thanks!

Hi Larry,
Yes, you are right.
We add a shuffle operation there because starcoderdata is not shuffled. If we do not shuffle the filenames, data of one coding language may appear together during training. We thought the seeds for different workers were the same when we added that shuffle function, but as pointed out by you, they are not.
This bug results in around 35% of data not being loaded into the dataloader and some data may be seen multiple times in a single epoch. I have updated the code to fix this bug. Unfortunately, we cannot afford to have a completely fresh run from scratch. What we opt to remedy this is to manually kill the process, fix the code, and resume the training at around 1.5T-token checkpoints.
We will discuss this issue in detail in our upcoming technical report. Thanks a million for pointing that out!

Hi @jzhang38 , thanks for confirming! GIven that TinyLlama-1b is performing quite well, I'm hopeful that the results will improve more after this fix :)

We add a shuffle operation there because starcoderdata is not shuffled. If we do not shuffle the filenames, data of one coding language may appear together during training.

Hmm, but the line below ensures that the filenames are shuffled right?
https://github.com/jzhang38/TinyLlama/blob/5120753ef69dfb9a76aefe43e475732ce0c6a27d/pretrain/tinyllama.py#L353
Separately, there's one other issue with the lit_gpt code which I surfaced here. Any ideas if I'm correct?

Hmm, but the line below ensures that the filenames are shuffled right?

https://github.com/jzhang38/TinyLlama/blob/5120753ef69dfb9a76aefe43e475732ce0c6a27d/lit_gpt/packed_dataset.py#L188
The shuffle toggle there only shuffles seqs within a single chunk.

Thanks for your replies!

The order returned by glob.glob uses the order in which entries appear in the filesystem. I think the order is arbitrary but fixed.

At least for my case, the order was the same for machines on the same node, but different across nodes. It may be that I'm running from a docker container.

At least for my case, the order was the same for machines on the same node

I see. Maybe I should sort it to play safe.

This bug results in around 35% of data not being loaded into the dataloader and some data may be seen multiple times in a single epoch.

Sorry @jzhang38 , can you walk me through how you calculated 35%? I calculated 62% for 16 processes. Intention is not to nitpick (i'm grateful for the codebase!) but to understand the implications.
Here's my calculations:
Assume we have 16 processes (2 * 8 cards)
Let X be the event where the particular data file is only seen by one process.
Let Y be the event where the particular data file is not seen by another process
Let Z be the event where the particular data is seen by more than one process (i.e. duplicated)
P(X) = P(Y) ** 15 = (15/16) ** 15 = 0.38 (15/16 since each process will look at 1/16 partition of a random list, which has 15/16 prob of not containing that particular data file)
P(Z) = 1 - P(X) = 0.62

good catch @larrylawl -- thanks for surfacing this!
@jzhang38 would you be open to releasing the upcoming 1.5T checkpoint even in spite of this bug (perhaps with a different name to indicate the duplicate/unused partitions), before restarting training from the 1T checkpoint (which it seems like you've decided on as your course of action according to the notion update)
It would be very interesting to be able to compare the two versions of the same model, trained to the same point, with and without this difference in data used to observe how the performance differs
(also, in spite of this bug, I'm imagining the with-bug 1.5T checkpoint will still improve perf over the previous 1T point, useful for those of us experimenting with the model today)

good catch @larrylawl -- thanks for surfacing this!
@jzhang38 would you be open to releasing the upcoming 1.5T checkpoint even in spite of this bug (perhaps with a different name to indicate the duplicate/unused partitions), before restarting training from the 1T checkpoint (which it seems like you've decided on as your course of action according to the notion update)
It would be very interesting to be able to compare the two versions of the same model, trained to the same point, with and without this difference in data used to observe how the performance differs
(also, in spite of this bug, I'm imagining the with-bug 1.5T checkpoint will still improve perf over the previous 1T point, useful for those of us experimenting with the model today)

Actually, the "wrong" 1.5T checkpoint is here...
https://huggingface.co/TinyLlama/tinyLlama-intermediate-checkpoints/tree/step-720k-token-1510B
Be sure to pass the correct revision parameter to your class-method from_pretrained.
I actually done tiny evaluation of myself on HellaSwag, and there is about 1% improvement
1T vs 1.5T ckpt:
  TinyLLAMA 1.1B - 1T- HellaSwag - Eval metrics/hellaswag/10-shot/InContextLearningMultipleChoiceAccuracy: 0.5245
  TinyLLAMA 1.1B - steps-1510B (1.5T)- HellaSwag - Eval metrics/hellaswag/10-shot/InContextLearningMultipleChoiceAccuracy: 0.5357

thanks for the info @MFajcik !


Instructions for installing ASM and ACM

installation instructions
configuration files
content for the root and namespace repos

@googlebot I consent.


Add URL getURL() method on clients

If we plan to introduce, e.g. BlobClientBuilder.blobUrl(..) API, we should consider two things:

Making the BlobClient.getUrl method have the same name, e.g. getBlobUrl()
The lack of symmetry between BlobClientBuilder.blobUrl(String) and URL getBlobUrl()


Use only pragma once and no more include guards

There were 30 files with pragma once and 42 with include guards

Retest this please Jenkins

I can merge after the other one

@alkino : can you check the slack discussion and we can finalise this PR?

Codecov Report

Merging #712 (a4aacd6) into master (318e25a) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head a4aacd6 differs from pull request most recent head b97e67e. Consider uploading reports for the commit b97e67e to get more accurate results

@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   55.99%   55.99%
=======================================
  Files         108      108
  Lines        8996     8996
=======================================
  Hits         5037     5037
  Misses       3959     3959

Impacted Files
Coverage Δ

coreneuron/apps/corenrn_parameters.hpp
100.00% <ø> (ø)

coreneuron/apps/main1.cpp
47.30% <ø> (ø)

coreneuron/io/nrn_checkpoint.hpp
80.00% <ø> (ø)

coreneuron/io/nrn_filehandler.hpp
38.18% <ø> (ø)

coreneuron/io/nrn_setup.hpp
88.00% <ø> (ø)

coreneuron/io/nrnsection_mapping.hpp
0.00% <ø> (ø)

coreneuron/io/reports/nrnreport.hpp
0.00% <ø> (ø)

coreneuron/network/netcon.hpp
58.06% <ø> (ø)

coreneuron/network/tqueue.hpp
100.00% <ø> (ø)

coreneuron/permute/cellorder.hpp
100.00% <ø> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318e25a...b97e67e. Read the comment docs.

Retest this please


mod:replace mongo driver to address CVE-2021-20329

The mongo driver has CVE https://github.com/advisories/GHSA-f6mq-5m25-4r72
The mongo driver is an indirect reference and cannot be directly upgraded.
More information on the issue https://deps.dev/advisory/OSV/GO-2021-0112?from=%2Fgo%2Fgithub.com%252Flightningnetwork%252Flnd
The fix will replace the reference of the library with the fixed version.

FWIW, we don't actually directly use this module:
⛰   go mod why -m go.mongodb.org/mongo-driver
# go.mongodb.org/mongo-driver
github.com/lightningnetwork/lnd/cmd/lncli
github.com/jedib0t/go-pretty/text
github.com/go-openapi/strfmt
go.mongodb.org/mongo-driver/bson

lncli uses it, but just to print out some text in a nice table format (lncli payinvoice/sendpayment).

FWIW, we don't actually directly use this module:
⛰   go mod why -m go.mongodb.org/mongo-driver
# go.mongodb.org/mongo-driver
github.com/lightningnetwork/lnd/cmd/lncli
github.com/jedib0t/go-pretty/text
github.com/go-openapi/strfmt
go.mongodb.org/mongo-driver/bson

lncli uses it, but just to print out some text in a nice table format (lncli payinvoice/sendpayment).

Agreed. But it comes with a known CVE. It makes people paranoid.

https://github.com/advisories/GHSA-f6mq-5m25-4r72

Just needs a rebase then this can be merged at will

Just needs a rebase then this can be merged at will

It has been rebased. Thanks

After merging your other PR this needs another rebase, sorry.

After merging your other PR this needs another rebase, sorry.

It should be good now. Thanks!


Too many Host headers caused via lua headers():add(":a","value")

Description:
The lua filters makes it possible to add headers which are available
only for access logs by adding ':' character to them. However if this
kind of "hidden" header starts with ":a" it is used as ":authority"
and this causes multiple "host" headers to appear with HTTP/1.X
requests. This in turns causes error with at least golang based http server:
"HTTP/1.1 400 Bad Request: too many Host headers".
With the envoy virtual hosts routes config it is not possible to
modify the ":" prefixed headers but it's nicely possible via lua api.
The use of ":" started headers via lua api may be an unplanned feature
but it makes it possible to have these hidden/log-only headers like
the Nginx supports via variables. These variables/hidden headers are
very convenient especially when using external authorizers or other
external subrequests where one needs to log the subrequest result
headers as part of access logs but not pass all of them to the
upstream.
Proposed fix:
Envoy should copy only the ":authority" header as HTTP/1.X "host" header and not all of the ":a*" headers.
Proposed new feature:
Add documented support for using hidden/access-log only headers.
Repro steps:

Use the configuration below
Have upstream server ready (written in go), or some other server but verify headers with tcpdump.
make a request to the envoy
notice that the server returns 400 error (you can verify the issue by using tcpdump to capture the traffic).

Config:
static_resources:
  listeners:
  - address:
      socket_address:
        address: <IP_ADDRESS>
        port_value: 8081
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          codec_type: auto
          stat_prefix: proxy_http
          http_protocol_options:
            accept_http_10: true
          #Disabled delayed close for the http/1.0 (and all other...)
          delayed_close_timeout: 0.0s
          access_log:
          - name: envoy.file_access_log
            typed_config:
              "@type": type.googleapis.com/envoy.config.accesslog.v2.FileAccessLog
              path: /var/log/envoy/envoy-access.log
              format: "[%START_TIME%] \
                       host=\"%REQ(:AUTHORITY)%\" \
                       m=\"%REQ(:METHOD)%\" \
                       st=\"%RESPONSE_CODE%\" \
                       ahidden=\"%REQ(:AHIDDEN)%\" \
                       bhidden=\"%REQ(:BHIDDEN)%\" \
                       \"\n"
          route_config:
            name: local_route
            virtual_hosts:
            - name: backend
              domains:
              - "*"
              routes:
              - match:
                  path: /envoy-status
                direct_response:
                  status: 200
                  body:
                    inline_string: OK
              - match:
                  prefix: /
                route:
                  cluster: upstream
          http_filters:
          - name: envoy.lua
            typed_config:
              "@type": type.googleapis.com/envoy.config.filter.http.lua.v2.Lua
              #################################################################
              inline_code: |
                function envoy_on_request(handle)
                     -- testing request header modifications,
                     -- adding a "hidden" log only header starting with ":a" will be used
                     -- as ":authority" causing "HTTP/1.1 400 Bad Request: too many Host headers" error
                     -- Example headers caused by this example:
                     --     host: localhost:8081
                     --     host: a-value
                     handle:headers():replace(":ahidden", "a-value")
                     handle:headers():replace(":bhidden", "b-value")
                end
              ##########################################################
          - name: envoy.router
            typed_config: {}
  clusters:
  - name: upstream
    connect_timeout: 0.25s
    type: strict_dns
    lb_policy: round_robin
    load_assignment:
      cluster_name: upstream
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: upstream
                port_value: 9090
### LISTENER FOR ADMIN API
admin:
  access_log_path: "/var/log/envoy/envoy-admin.log"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 8001

You are relying on undocumented behavior which I don't think we are going to change. Can you use dynamic metadata for this? IIRC it can also be logged. cc @dio

Yes, the dynamic metadata works perfectly for this case. Thanks for the the tip.


Delete story

Description
Currently, anyone can delete story of other users.
Steps to reproduce
Visit any user's profile, see their story, Delete icon is visible and on clicking it, story gets deleted
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Hey @anamika7153 I have already opened a issue for it.


feat(select): add optional css class prop to md-list

Adjust width of list inside select to fit container; add optional listClass prop.
Old:

Fix:

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:
Before (If applicable):

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Issue #272 fix


feat: Add tests for submissions by token and fix namespaces

Add tests for submissions by token and fix namespaces
Description
Tests for #240 and fix old wrong namespaces

Approving. Just to remind you of this discussion. If you are to add the change, this PR is good place- #246 (comment). Cheers

Yes, I haven't forgotten and I considered making changes. Checking what exactly to change, I decided to not continue and explained the reasons in a reply of your comment.


Fixes #2304 Java wrapper for indy_list_pools Indy SDK function

A wrapper function for the indy_list_pools Indy SDK function was missing in the Java SDK.

Hi @darkchylde ,
we had to re-write master history to fix DCO there. So now this PR should be updated as well.
Can I force-push to your branch or would you like to do it by yourself or to create a new one?

Hi @darkchylde ,
we had to re-write master history to fix DCO there. So now this PR should be updated as well.
Can I force-push to your branch or would you like to do it by yourself or to create a new one?

Rebased and synced.

Should https://github.com/hyperledger/indy-sdk/pull/2306/commits/d4d7b5335c193808ba8fca1514d1f1a546dd1d9a commit be dropped as well?

Should d4d7b53 commit be dropped as well?

Dropped.


Open curriculum entry for RDF

This looks great so far! Let's discuss it in the Bookclub meeting and the Education call coming up!


View helpers using content_tag render duplicated content

I believe this issue is related to #240
Steps to reproduce
I think I bumped into #240  by using my own helpers that used content_tag internally. For example:
# app/helpers/bootstrap_helper.rb
module BootstrapHelper
  def panel(&block)
    content_tag(:div, class: 'panel panel-default', &block)
  end
end

<%= helpers.panel do %>
  The client list goes here
<% end %>

# app/components/client_list_component.rb
class ClientListComponent < ApplicationComponent
end

<%= render ClientListComponent.new %>

Expected behavior

The client list goes here

Actual behavior
Output would have duplicated-ish content.
The client list goes here

The client list goes here

System configuration
Rails version: 6.1.3
Ruby version: 2.6.5
Gem version:  2.30
Workaround

Full disclosure

I was able to work around it by changing the binding on the helper method to use the Component's view context with this piece of code:
# app/components/application_component.rb
class ApplicationComponent < ViewComponent::Base
  def render_helper(name, &block)
    helpers.method(name).owner.instance_method(name).bind(helpers).call do
      with_output_buffer(nil, &block)
    end
  end
end

<%= render_helper(:panel) do %>
  <%= render_helper(:panel_body) do %>
    Somehow it also works with nested helpers 🤷
  <% end %>
<% end %>

Output

      Somehow it also works with nested helpers 🤷

Though I am sure I am missing on a ton of edge cases and potential issues, I thought I'd share my hack @BlakeWilliams

@guzart Thank you for the report!
It's unfortunate that helpers are impacted by this issue too, but it does make sense. One alternative work around could be to include the helper module which should define the method on the component itself. I think that would cause it to be evaluated in the context of the correct @output_buffer.

Oh, totally! Including the helper in the base ViewComponent is a much... MUCH simpler solution. Thanks!


Could we make the dateline and byline slightly closer together on smaller widths

I was thinking something a bit more like this, leaving a bit more space before the post content starts as well:

Think it looks a bit weird, but OK


Extensionless imports in master-branch no longer supported by node-resolve

Hi Team!
I've tried to get working the latest master version of the material-web, and got a lot of errors like:
Missing "./decorators" export in "lit" package

    material-web/textfield/outlined-text-field.ts:10:28:
      10 │ import {customElement} from 'lit/decorators';

It seems node-resole no longer allows to import without file extension, and all imprts should be changed to import {customElement} from 'lit/decorators.js'
https://github.com/rollup/plugins/issues/684#issuecomment-770517359

It seems the same  problem as
https://github.com/material-components/material-web/issues/3395
It was fixed at https://github.com/material-components/material-web/commit/d99e3055e75d01f59c96098977e3450d0d3e7e5e
But appears again in the master branch with Material 3 refactor
cc @asyncLiz

Thanks for the issue! This is a dupe of #2632 but will be fixed shortly with https://github.com/material-components/material-web/pull/3623 :)


https://github.com/lekhmanrus/vulgar.git

Note: for support questions, please use one of these channels: Chat: VulgarDisplayOf2^2.slack or Twitter: @datatype_void

**I'm submitting a ... **
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?

What is the current behavior?

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via

https://plnkr.co, https://codepen.io, or similar.

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular version: 2.0.0-beta.X

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Please fill out the appropriate information when submitting an issue.


Add the ability to specify a namespace seperator

When using the version of Angular locker designed for Angular 1 the values are saved using a single period . when using a namespace, however with the Angular 2 version the separator has changed thus breaking backwards compatibility which is important for hybrid apps.

Thanks!


[firebase_performance] Deprecate incrementCounter in favor of incrementMetric

Description
Add incrementMetric and mark incrementCounter as deprecated.
incrementCounter is deprecated in the Java SDK and it's been replaced with incrementMetric. Let's make firebase_performance match that.
See: https://firebase.google.com/docs/reference/android/com/google/firebase/perf/metrics/Trace.html#incrementCounter(java.lang.String, long)
Related Issues
Fixes flutter/flutter#29775
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

LGTM!