Uncovered list

How can i get the list of "uncovered" items?
'''debug:unassigned''' debug displays 8 items and analysis displays uncovered 1000+ items

@stolentine could you please provide your config file?

Ooohh...
We are in the process of changing the architecture, so the settings are strange in places
paths:
  - ../../app
  - ../../vendor
exclude_files:
  - '#.*test.*#'
  - '#.*Test.*#'
  - '#.*_laravel_idea.*#'
  - '#.*example.*#'
  - '#.*Example.*#'
layers:
  - name: App
    collectors:
      - type: bool
        must:
          - { type: directory, regex: '%currentWorkingDirectory%/app/' }
        must_not:
          - { type: directory, regex: '%currentWorkingDirectory%/app/Legacy' }
          - { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain' }

  - name: Legacy
    collectors:
      - type: bool
        must:
          - { type: directory, regex: '%currentWorkingDirectory%/app/Legacy/.*' }
        must_not:
          - { type: directory, regex: '%currentWorkingDirectory%/app/Legacy/.*/ModuleInterface/.*' }

  - { name: Legacy_ModuleInterface,   collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Legacy/.*/ModuleInterface/.*' } ] }
  - { name: Shared,                   collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/Shared/.*' } ] }

  - { name: Psr,      collectors: [ { type: directory, regex: '%currentWorkingDirectory%/vendor/psr' } ] }
  - name: Vendor
    collectors:
      - type: bool
        must:
          - type: directory
            regex: '%currentWorkingDirectory%/vendor/'
        must_not:
          - type: directory
            regex: '%currentWorkingDirectory%/vendor/psr/'

  #Module
  - { name: Anticorruption,     collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/((?!Shared).)*/Anticorruption/.*' } ] }
  - { name: Application,        collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/((?!Shared).)*/Application/.*' } ] }
  - { name: ModuleInterface,    collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/((?!Shared).)*/ModuleInterface/.*' } ] }
  - { name: Domain,             collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/((?!Shared).)*/Domain/.*' } ] }
  - { name: Infrastructure,     collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/((?!Shared).)*/Infrastructure/.*' } ] }
  - { name: Presentation,       collectors: [ { type: directory, regex: '%currentWorkingDirectory%/app/Subdomain/((?!Shared).)*/Presentation/.*' } ] }

ruleset:
  ModuleInterface:
    - Shared
  Domain:
    - +ModuleInterface
  Application:
    - +Domain
  Anticorruption:
    - ModuleInterface
    - +Application
    - Legacy_ModuleInterface
  Presentation:
    - ModuleInterface
    - Common
    - Vendor #todo
  Infrastructure:
    - +Application
    - Anticorruption
    - Presentation
    - Vendor
    - App

  Shared:
    - Psr
    - Vendor #todo

  #todo
  Legacy:
    - Legacy_ModuleInterface
    - +Vendor
    - Shared
    - +Infrastructure

  #todo
  App:
    - +Vendor
    - Legacy
    - Shared

#########
  Psr:
    - Vendor
  Vendor:
    - Psr

vendor/bin/deptrac debug:unassigned  ./tools/deptrac/depfile_layers.yaml --cache-file=./tools/deptrac/.deptrac.cache

/app/Subdomain/ApiGateway/todo.php
/app/Subdomain/Core/todo.php
/app/Subdomain/Generic/todo.php
/app/Subdomain/Supporting/todo.php
App\Subdomain\ApiGateway\todo
App\Subdomain\Core\todo
App\Subdomain\Generic\todo
App\Subdomain\Supporting\todo

$ vendor/bin/deptrac analyse ./tools/deptrac/depfile_layers.yaml --cache-file=./tools/deptrac/.deptrac.cache

 9439/9439 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 -------------------- ------
  Report
 -------------------- ------
  Violations           0
  Skipped violations   0
  Uncovered            1185
  Allowed              7898
  Warnings             0
  Errors               0
 -------------------- ------

I guess it is possible that you have 1185 uncovered dependencies on those 4 files and 4 classes in them. That would make sense but it is a lot of dependencies in my mind for just 4 classes. Is this at all plausible? I do not know how big/used the classes are.

You could try to create a dummy layer with just those 4 classes and see if those uncovered dependencies turn into vialiations. If they do, it would be this case. If you have some uncovered dependencies left when debug:unassigned is empty, that would be a concern and quite likely a bug in deptrac.

Sorry, I probably should have removed this, so as not to mislead you. "todo.php" are temporary dummy classes. I removed them and the problem remained only now debug does not display anything

In that case, the last idea I have is that you are referencing uncovered dependencies to files not in paths. Do you have some examples of the uncovered dependencies?

namespace Illuminate\Foundation\Console;

use App\Http\Middleware\PreventRequestsDuringMaintenance;
use Exception;
use Illuminate\Console\Command;
use Illuminate\Foundation\Exceptions\RegisterErrorViewPaths;
use Throwable;

class DownCommand extends Command
{

DownCommand from the vendor for some reason use class "App\Http\Middleware\PreventRequestsDuringMaintenance" which does not exist.
debug:token with an argument of this class has empty output

Hey. I'm experiencing a similar thing:
 -------------------- -----
  Report
 -------------------- -----
  Violations           0
  Skipped violations   0
  Uncovered            305
  Allowed              178
  Warnings             0
  Errors               0
 -------------------- -----

when having empty list with vendor/bin/deptrac debug:unassigned.
What does the "Uncovered" means? Is it related to "unassigned"?

@ktrzos, you can use
$ deptrac --report-uncovered

to see the uncovered dependencies.

Since there was no update in a while, I assume the existing debug commands and options are enough. I will close this for now.


Fix /[chainSlug] UI issue on safari mobile

Issue:

📝 Changed routes:

/chain/[chainSlug]

(view full size)

Commit c8ad57899b5165d5b01b889757c17b0f60fc9523 (https://thirdweb-gxvzi9t8x.thirdweb-preview.com).


VSCode tour

@abe33 can we reuse the tour from atom?

Yes of course, the only thing is that we should use screenshots from VSCode and not from Atom, @abmirayo can you help us on that?


the reward function - _reward()

Hello,
I am wondering about the _reward function.
In the function the reward is calculated as following:
reward =
+ self.config["collision_reward"] * self.vehicle.crashed
+ self.config["right_lane_reward"] * lane / max(len(neighbours) - 1, 1)
+ self.config["high_speed_reward"] * np.clip(scaled_speed, 0, 1)
reward = utils.lmap(reward,
[self.config["collision_reward"],
self.config["high_speed_reward"] + self.config["right_lane_reward"]],
[0, 1])
reward = 0 if not self.vehicle.on_road else reward
return reward
If I set in my configuration file that right_lane_reward and high_speed_reward are set to zero and collision_reward as a negative number shouldn't this function always return 0?
I get different values that are bigger the zero and I don't understand why
Thanks in advance,
Yael

Hi @yael-ai
This is probably due to the reward normalization in the [0, 1] range.
Indeed, if you set high_speed_reward = right_lane_reward = 0, and e.g. collision reward = -5, then the reward is linearly mapped from the [-5, 0] range to [0, 1].
So a collision-free state should always give a reward r=1 (after the mapping, instead of r=0).
Is that what you observe?

Hi,
Thank you so much for the response!
Yes it makes sense now


TEST: Mongodb fork test

DO NOT MERGE
Description
This PR is only to test kokoro changes in #1045 against the MongoDB fork in GoogleCloudPlatform/opentelemetry-operations-collector#147

Closing PR as test passed.


#pragma once for health_check_event_sink.h

Commit Message: #pragma once for health_check_event_sink.h
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

cc @botengyao @yanavlasov


Fix a typo in discussion of terminal titles

"E.g." seems to be the intended meaning: There are Linux distributions that are not Ubuntu, but Ubuntu is an example of a Linux distribution for which the behavior is the given.

Docs Build status updates of commit f08217f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/tutorials/tab-title.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Agree! :) Thanks @fuglede

Agree! :) Thanks @fuglede


remove aux info and replace with creator info, and beef up list channels CLI CORE-5894

Patch does the following:
1.) Removes ConversationAuxiliaryInfo and replaces with ConversationCreatorInfo and ConversationCreatorInfoLocal.
2.) Lookup username of creator during localization process.
3.) Add Headline and creator info to InboxUIItem for frontend to render.
4.) Change return type of GetTLFConversations to be InboxUIItems for easier processing.
5.) Change keybase chat list-channels to output headline and created by info.


Network architecture diagram does not match the implementation code

Hi chrischoy, @chrischoy
Nice work and thank you for sharing the code.
I have a question about the implementation of ResUNet2. In my opinion, the forward() function of ResUNet2 should look like:
def forward(self, x):
   out_s1 = self.conv1(x)
   out_s1 = self.norm1(out_s1)
   out_s1 = MEF.relu(out_s1)
   out= self.block1(out_s1)
   ...

As shown in the ResUNet architecture in the paper:

However, your implement of ResUNet2 feed output of residual block to 3D ConvTr, and activate feature map twice using ReLU(one in self.block, one in MEF.relu). Is there a problem here, or am I missing something？
https://github.com/chrischoy/FCGF/blob/458549e076d9941dce550c3de334be5a7bf9cde9/model/resunet.py#L142-L147

Yes, your first model was the one that I tried first and experimentally, I found that the current model works better.
The diagram might not match the implementation as we tried various models in the camera ready and used the one variation that worked best. Sorry for the confusion.


fix(__decorate): Stop using non‑standard Reflect.decorate

TypeScript PR: https://github.com/microsoft/TypeScript/pull/36408

Reflect.decorate is not on a standards track and has no active proposal being championed in TC39.
We have no idea if Reflect.decorate will get added to the language, even if it does, we have no guarantee it will be the implementation we are assuming it to be.
By having this condition in the code, we are likely preventing Reflect.decorate from ever existing in the language, just like Array.prototype.flatten had to get a different name because MooTools would attempt to use it if it existed and it was not the implementation MooTools assumed it would be.
Here is a W3C TAG finding which recommends against usage of speculative features -- https://www.w3.org/2001/tag/doc/polyfills/#don-t-use-speculative-polyfills-that-defer-to-native-implementations

Nice work @ExE-Boss ☺


Attestation Service support alternative sender names

Currently the attestation service sends a generic message to the user "Your Celo verification code is...". Wallets would like to have the ability to customize the sender (ex. "Your Valora verification code is..."). To achieve this, it requires Celo validators to create a support ticket and respond to the following questions:

In order to evaluate if we can activate the custom friendly name feature on your account, could you please confirm what's your use case for custom friendly name? Also, please confirm that you have controls and validation in place on the text field used for the service name. This is necessary to ensure that the feature is used appropriately.

My response:

We participate in a decentralized phone number verification service. The service is generic and not tied to any particular application which is why we need the ability for the caller to specify their own app name. These applications are mostly blockchain wallets which run on the Celo network.

It also requires a new feature be added to the Attestation service and API to expose the ability to pass in a custom sender name.

@codyborn is this something we can still decide not to do? I agree with you on "Celo" being more generic + wonder if it's potentially an attack vector to fully support custom names (i.e. custom name set to some sketchy link that the user then clicks when they receive the SMS)

Closing this in favor of ASv2


change job execution state

We have a case want to stop scheduled jobs temporarily.
It's ok to kepp state on memory.
We setup schedule with execution state, and change enable/disable on statusPage.

How about this enhancement?
I would like to try PR if it is attractive.

@tetsuyanh I'll review the pull request.
Pause function for 1 or group of jobs mid-cycle may cause some unforeseen problems with the entire lib. I don't want to break backward compatibility.


Make getRandomPrompt random after first prompt

# # #4
I work at Google. I don't know what the process will be for contributing here.

I signed it!

Thanks for the Pull Request! I addressed how it should be fixed now on your issue #4
Again, feel free to open another issue or Pull Request if it is still not resolved.


Ore processing plant Purified dust

Galena
Magnetitie
Iron
Sphalerite
Stibnite
Copper
Tin

bruh

DW ill go look for more issues <3


Low quality on selecting a picture

On Android Device,
Image selected from Gallery/File Source is of very low quality.
Same image when opened via any File manager has very good quality. I suppose plugin is doing some compression on the image.

Hi, which platform you are using, PhoneGap, Ionic... ?

Following are the platform details:
ionic info

cli packages: (C:\Users\sd\AppData\Roaming\npm\node_modules)

    @ionic/cli-utils  : 1.19.2
    ionic (Ionic CLI) : 3.20.0

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 3.1.9
    Cordova Platforms  : none
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    Node              : v8.9.0
    npm               : 5.2.0
    OS                : Windows 10

@uzumakinaruto123 Fixed! Try now. Although low end devices will have some memory trouble now. Tested in mine and it is working. Gallery shows high quality images. Closing this issue for now. Let me know if this helped. :)
Cheers,
Chris
Neutrinos

@ChrisTomAlx By re-request do you mean removing and reinstalling plugin? Actually I am confused as I don't see any commits in the repo?

@uzumakinaruto123 the commits are in the scanlibrary used for the plugin. Removing and re-adding will most likely do it. But I would suggest starting from a blank project if you just want to test this plugin.


Support character alternates

Some fonts have alternate glyphs for some characters. These include standard kinds like small caps and superscripts/subscripts, and also include stylistic alternates for different uses (e.g. different ® for headline and body text). BonMot should have a way to query which of these is are available in a font, and to enable easy use of them if they are available. The querying part can be done using the C functions in Core Text.

Dup #173


Panic when inserting array literal with NULL element into a table where the matching column has a non-nullable element

Describe the bug
I have a custom data sink whose schema contains an array whose element type is non-nullable.  If I attempt to insert an array literal with a null element into this data sink via SQL, the process exits with a panic.  This behavior can be reproduced using MemTable.
To Reproduce
The following example code can be added to datafusion-examples/src and run via cargo run --example array-non-nullable-element:
use std::sync::Arc;

use arrow::datatypes::{DataType, Field, Schema};
use arrow::record_batch::RecordBatch;
use datafusion::common::Result;
use datafusion::prelude::*;

#[tokio::main]
async fn main() -> Result<()> {
    let schema = Arc::new(Schema::new(vec![

    Ok(())
}

Running with RUST_BACKTRACE=1 indicates that there is an unwrap() occurring in ListArray::new.
   3: core::result::Result<T,E>::unwrap
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/result.rs:1102:23
   4: arrow_array::array::list_array::GenericListArray<OffsetSize>::new
             at $HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-array-53.0.0/src/array/list_array.rs:228:9
   5: arrow_cast::cast::list::cast_list_values
             at $HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-cast-53.0.0/src/cast/list.rs:144:17
   6: arrow_cast::cast::cast_with_options
             at $HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow-cast-53.0.0/src/cast/mod.rs:750:32
   7: datafusion_expr_common::columnar_value::ColumnarValue::cast_to
             at $DATAFUSION/datafusion/expr-common/src/columnar_value.rs:195:17

Expected behavior
I would expect this query to bubble a DataFusionError up to the call site instead of panicking the process.
Additional context
No response

It looks like an arrow-rs problem, GenericListArray::try_new should be used instead of GenericListArray::new🤔

Is the right approach to close this issue after opening a new one against arrow-rs?

Is the right approach to close this issue after opening a new one against arrow-rs?

I think we can keep it open and wait for an upstream fix.


Grantr App

grantr.app
Excellent resource listing most known grants in the web3 space.

FInd grants that would be appropriate to add to the scoring system research.


Display only first ~100 characters of email body in template list view

In the email template list view, display only  ~100 characters of the email body so that we can see more rows per page screen.

This has been fixed.


is it hard to support BLOOM?

I imagine that it would not be too difficult to add it, but given its big size and now that there are many smaller models outperforming it, I don't think adding BLOOM will be on our priority list soon.


What are the differences and major improvements?

Hi, Samuel!
Thank you for the interesting project!
My colleagues work with ODrive and I found that API is pretty beautiful.
Even more - I think about the implementation library for golang.
But I have some questions.
It will be great if you have time to chat in telegram ( @l1va4ka ) or you can send other contacts by email<EMAIL_ADDRESS>to not post it here.
Firstly i would like to ask about the whole idea. I read everything that i found (sources in different branches), but i think i can't clearly answer the question why not to use uavcan, profinet, nats, mqtt or something else as a transport layer? Might be because i am not so strong on hardware side and not so strong in c programming it is not obvious for me. Or do you see any other more closer competitor? Ros is decided to use dds for example. Is it "too large"?
Thank you for your time.
Best regards, Mike.

Hey Mike!
Thanks for your interest in the project!
There are several aspects to a communication framework which I find rather important and most of which are found in some existing communication frameworks but I don't know any framework yet which combines all those aspects (including Fibre, but we're moving there). Here's an incomplete list:

Automatic discovery of objects that match a certain interface
High level API (remote procedure calls rather than sending raw bytes)
Now sometimes passing raw bytes may actually be exactly what you want and there are other paradigms (publish-subscribe, message passing) which have their place too. But often you'd like to use several of these paradigms side-by-side in the same application. For example for a motor controller's position command and feedback a publish-subscribe scheme makes sense, but for a command like "save configuration to NVM" a function call is more appropriate. It turns out that a variation of function calls (remote procedure call with infinite-length input and output streams instead of finite argument list) makes it easy to have subscriptions and traditional function calls side-by-side.
The high level API should optionally be announcable by the server itself so that the client doesn't need to be recompiled with every new server feature.
Not bound to a particular underlying layer (not bound to USB-only or CAN-only)
Automatic discovery of communication paths (including multi-hop) and automatic switch-over or link-bundling in the face of dynamic network topologies
Suitable to run on any platform (bare-metal embedded, desktop, mobile, web, ...)
Suitable to use from multiple programming languages

(again note that Fibre, too, doesn't cover all of this yet but design decisions are made with those things in mind)
For ODrive in particular some of these features may seem unnecessary initially but as ODrive evolves so do its communication requirements and things which seemed far-off (like multi-hop capability) suddenly become very relevant (e.g. controlling an ODrive testrig from the developer PC via a Raspberry Pi).
If you're interested in implementing golang bindings that would be cool! Since recently there's a C library which you can just bind to rather than implementing the whole protocol. In fact the protocol itself will soon require changes to scale towards the aforementioned goals but implementations that bind to the C/C++ libfibre will be largely (albeit not completely) shielded from those changes.
If you have any questions regarding the libfibre API or otherwise let me know! You can find me on the ODrive Discord as "Samuel#7161".

Thank you for the answer!


deadlock fix

This PR solves deadlock issue among BroadcastTxHandler, BlkHandler and API threads. The race condition issue between API and pending state still exists.


Update AccountSettingsView.coffee

This commit is wrong, look here:
Https://github.com/codecombat/codecombat/commit/e2640362bd1eca07070dde33d5572960dc00cec0
It will prompt id error, so restore it!

Coverage remained the same at 55.826% when pulling 9cd6c2a35b9b9c7d414632211f6097ba1a68d324 on icodegame:patch-6 into 3665a8a1011828d1af7ac9d1a40cd0bf23e093a8 on codecombat:master.

Hi @icodegame! I tested and on both reset and delete functionality worked without an 'id' error. Can you go into more detail what this is fixing? It should be roughly equivalent since @user is a clone of me.


[FEATURE]: Timescale extension support

Describe what you want
Add support for Timescale: https://docs.timescale.com/api/latest/
We could start with basic features like create_hypertable and some other functions, and broader support with time.

This would be amazing and would be the first typescript ORM to provide support for timescale functionality!


[stable/k8s-spot-rescheduler] Add pod disruption budget

Is this a request for help?:
No
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature Request

Which chart:
stable/k8s-spot-rescheduler
What happened:
If I deploy one or more than one replica for k8s-spot-rescheduler the cluster-autoscaler is not able to evict it without pdb.
What you expected to happen:
Having the option to define a pdb with max unavailability set to 1 the cluster-autoscaler and any other parts of the system which need to evict pods/taint nodes is able to gracefully do this on the k8s-spot-rescheduler pods.
How to reproduce it (as minimally and precisely as possible):

Have a autoscaling cluster (w/ stable/cluster-autoscaler) with e.g. two nodes
Deploy stable/k8s-spot-rescheduler with replicas set to 2
The cluster autoscaler is not able to evict one of the pods because of it's own restrictions when a pdb is missing

Anything else we need to know:
Normally you would run the k8s-spot-rescheduler on master nodes, which is not possible on AWS EKS. Thus the need to have a pdb.

@komljen What do you think about it?
I first thought about defining the pdb by default with maxUnavailability: 1. But when this chart runs usually on master nodes, IMHO it should be not be created by default.


Hard to know which file it's referring to

I got this error in my Action:

The problem is that I don't know where these bad links are.

I skimmed the source code and found this:
https://github.com/reiddraper/freshlinks/blob/596f7f5bc8a562b1b98cde1448fa8bca3cd0539b/freshlinks-action/src/main.ts#L51-L69
Perhaps something like this:
function reportFile(
  link: freshlinks.MarkdownLink,
  suggestions: boolean,
  possibleLinkDestinations: string[],
  annotationTemplate: string
): void {
  const sourceFile = link.sourceFile.replace(
    '/home/runner/work/freshlinks/freshlinks/',
    ''
  )

  const suggestion = calculateSuggestion()

  type SuggestionTemplate = {suggested_link: string}
  type TemplateArgs = {link: string; suggestion?: SuggestionTemplate}
- const templateArgs: TemplateArgs = {link: link.link, suggestion: undefined}
+ const templateArgs: TemplateArgs = {link: link.link, suggestion: undefined, sourceFile: link.sourceFile}
  if (suggestion) {
    templateArgs.suggestion = {suggested_link: suggestion}
  }


[E2E]Push test fixes and update projects to restore nuget packages

Fix push tests flakiness
-Updated csproj files to restore nuget packages on build

Fix for #21

:+1:


The download scripts cannot be found on Github.

The download scripts for Insights were not available at https://github.com/CognizantOneDevOps/Insights/blob/master/Deployment/RHEL7/
The URL was returning a 404 ERROR. Could you please look into it? Thanks in advance! :+1:

@vishwajitmankar The link was taken from https://onedevops.atlassian.net/wiki/spaces/OI/pages/450592772/Linux+Installation

@vishwajitmankar Could you please point out the use of the refreshTime tag in the server-config.json file?

You can ignore that parameter. We are not using it anymore as product is open source.


chore(package): update github-repository-provider to version 2.1.8

Coverage remained the same at 77.405% when pulling 67eaea8f6add40f53bef098895be129661be0664 on greenkeeper/github-repository-provider-2.1.8 into 1e91ca21de431e6351dcb783c8401b9f3a50b1bc on master.

:tada: This PR is included in version 7.4.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Calling getBalance on contract results in 3 * sent amount

I send x wei to a contract address with
web3.eth.sendTransaction({from: accounts[0], to: contract.address, value: x})
then I check the balance
web3.eth.getBalance(contract.address)
It returns 3 * x...
This is consistent if I change x. It also deducts accounts[0] balance by 3 * x. Regardless of what my contract does, this should not be happening. Oddly enough, the token distribution amounts are changed by the correct amounts, without the 3x factor.
Truffle v3.4.4
OSX 10.12.4
TestRPC v4.0.1

More data:
      // this results in multiplication of msg.value by 2 unless I comment out the rest of the function...
      uint256 createdTokens = tokensPerEther * msg.value;
      // this actually multiplies msg.value by 3 even tho tokensPerEther != 3
      // using SafeMathLib for uint here
      uint256 createdTokens = tokensPerEther.times(msg.value);

Also, confirmed this doesn't happen on mainnet...

Thank for reporting this, @illuzen! We're going to go ahead and close this issue as we've been unable to reproduce the issue using the latest version of ganache-cli. If you are still experiencing this issue please open a new issue with steps on how to reproduce and we'll look into it again.


Add gang count and position to ra3/hwqsx control stations

Adding 2 fields into the devices dict for RA3/HWQSX keypads/picos:
gang_position (which position the keypad resides in a multi-gang station)
gang_count (how many ganged devices are in the control station)
These fields will allow for better device/entity naming.
Currently each keypad has "Position 1" in it's name, even if it's the only keypad in that location. Even a single pico on a pedestal gets the "Position 1" added to it's name.
With these fields, we can detect if it's in a single gang, and ignore the position name.
ie "Rec Room Coffee Table Position 1 Pico" becomes "Rec Room Coffee Table Pico"
The gang_position field will allow us to convert the position to an ordinal (1st, 2nd etc) without having to parse the number out of the device_name field.

@danaues I would love to see this PR get merged. Dealing with a setup where many multi-gangs
:)


XIONE-1354: revert format C++ names

Reason for change: commit 9eb937e changed the format of C++ names in JsonData_*.h header files. This is breaking existing code that uses these files.
Risks: Medium
Test Procedure: DRMActivationService plugin will build again.
Signed-off-by: Justin Ware<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Justin Ware seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Would also point out that while this is not a bundled service within RDK, the DTV service also suffers from this problem.

Hi @sebaszm , are you saying that this change will "... break[ing] JSON-RPC glue generation from C++ headers." ? Was the change in the format of the C++ class names in the "JsonData_*.h" intentional and the new format will be the correct one going forwards? For example used to be "GetDrmIdentificationResultData" but is now "GetdrmidentificationResultData" for one of our JSON-RPC interfaces.

Hi Justin, no, that was not intentional, but the change has impact on other code.

Please change self.name to self.true_name. That should make both worlds work correctly.
Will do.

Hi @sebaszm , updated as you've suggested and can confirm this resolves our broken builds. I don't understand the wideer implications of this change though.

Hi @sebaszm , thanks for the approval. I'm not authorized to do the merge will someone else be doing this?

On advice of Vjiay Selvaraj (ComCast) and Thunder component owner this pull request has been cancelled. The new behaviour of all lowercase generated C++ type names is now to be used.

I'm arguing this back, as we've currently got a mixed case here.


Document on ScrollPhysics the requirement to override applyTo

I missed this when first experimenting with a custom ScrollPhysics subclass a few weeks ago, which led me into about a half-hour of very confused debugging into the framework as I tried to figure out why my code wasn't running.
This requirement is already stated on applyTo itself, but one won't necessarily see that unless there's already a reason to pay attention to applyTo.  So it seems best to mention it on the documentation of the class itself.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks!

This feels like a foot gun though.
I wonder if we could instead make this more like ScrollBehavior, which has a unique copyWith that creates a _WrappedScrollBehavior to preserve custom subclasses.

Agreed. I haven't thought about what that could look like (or how to avoid or mitigate breakage from an API change), but something like that would be welcome.


GORA-477 Add support for Solr 5.x

This issue provides a patch for https://issues.apache.org/jira/browse/GORA-477
This patch was contributed by Aaron Cosand

If some folks from dev@ can review then we can commit to master


Fix issue with SSID containing space

When an SSID was containing a space, the script was using only the first
word.
The modified code is from the rofi-wifi-menu repository.
Fixes #5

hi @sheoak
Sorry for the delay. I'll review your PR soon as possible. Thank you so much to fix this issue!

Hey! It doesn't work for me anymore, not sure if I have an issue with my network or not, I will try to have a look at it today!

See my last commit, I think this solves some other cases. I'm not sure I understand why it doesn't always work but it seem to solve the issue… I'm experiencing a little bit with the script so might want to check it works for you in all cases!
https://github.com/sheoak/nmcli-rofi/commit/7dac5846b3fad190d91f49edad54fc912ffdb3dd


custom charset support!

public static class Response extends Base<Connection.Response> implements Connection.Response {
...
private static void writePost(Collection<Connection.KeyVal> data, OutputStream outputStream) throws IOException {
writePost(data, outputStream, null);
}
    private static void writePost(Collection<Connection.KeyVal> data, OutputStream outputStream, String contentType) throws IOException {
        String charset = DataUtil.getCharsetFromContentType(contentType);
        if(charset == null){
            charset = DataUtil.defaultCharset;
        }

...

If I understand the request, this was implemented recently with ability to set a post charste.


undefined reference to Boost at linking

I'm following the instructions on BUILDING.md on how to build the tests but at the step cmake --build . --config Release I'm getting the following error:
[ 53%] Linking CXX executable ../bin/test_toolkit
/usr/bin/ld: CMakeFiles/test_toolkit.dir/test_project.cpp.o: in function `boost::filesystem::exists(boost::filesystem::path const&)':
/usr/include/boost/filesystem/operations.hpp:463: undefined reference to `boost::filesystem::detail::status(boost::filesystem::path const&, boost::system::error_code*)'
collect2: error: ld returned 1 exit status
make[2]: *** [tests/CMakeFiles/test_toolkit.dir/build.make:339: bin/test_toolkit] Error 1
make[1]: *** [CMakeFiles/Makefile2:284: tests/CMakeFiles/test_toolkit.dir/all] Error 2
make: *** [Makefile:101: all] Error 2
(base)

I'm read on stackoverflow that adding -lboost_system and -lboost_filesystem in the gcc call may fix the problem, but I can't figure out where in the cmake files to add that. What should I do?

Somehow this stopped happening, I don't know why.


[1.20.x] KOGITO-6936 - Drop Xstream

could we have it backport this droppign also to 1.13.x branch?


IMPORTANT: Cookie Monster not loading

Because of a change of repository ownership the link to load CookieMonster has been changed.
The new location of the file is
https://cookiemonsterteam.github.io/CookieMonster/dist/CookieMonster.js
This link should work for all methods of loading the mod.
An update to the Readme, wiki entry and a new version of the mod itself will be pushed out tomorrow. In the meantime this should resolve most issues!

Can I suggest making a new repo in the original location (under @Aktanusa's account) where CookieMonster.js and CookieMonsterBeta.js both just contain:
Game.LoadMod('https://cookiemonsterteam.github.io/CookieMonster/dist/CookieMonster.js');

@Aktanusa could do this, but this might create the problem of people opening issues in their repository. They are quite busy so they might not always have the time to direct them here.
I'm hoping that after this weekend every user will find the new repo! Perhaps @Aktanusa can clone the repo and add a line to the Readme directing to this new location?


Fix for File.lastModified on IE10 and IE11

IE11 does not have lastModified so we fall back on lastModifiedDate.
Note that lastModifiedDate returns a date-object and not an integer, but the time library
handles this correctly. Alternatively one could do file.lastModifiedDate.getTime() to extract
time as in integer.

Initial review suggests that the following code would work in a broader range of scenarios:
function _File_lastModified(file)
{
	// Check the deprecated lastModifiedDate field for IE10 and IE11.
	//
	// If that fails too, give the current time. This is the fallback behavior
	// for lastModified in the specification: https://www.w3.org/TR/FileAPI/
	//
	return __Time_millisToPosix(
		'lastModified' in file
			? file.lastModified
			: 'lastModifiedDate' in file
				? file.lastModifiedDate.getTime()
				: (file.lastModified = Date.now())
	);
}

This way (1) it is not left up to trust that the date is converted to a POSIX time and (2) you cannot get a crash if lastModifiedDate does not exist.
We need to do more testing before proceeding with this here, particularly around the behavior of Blob files on different OSes and browsers from your other issue.

Any updates on this?
It would be good to have this merged at least as an incremental improvement by making it work in IE11.
I can change the PR to your initial suggestion.
Been running this code and my other PR in prod since October without any reported issues :)


Improve HMR Support for Svelte/Vue CSS Styles

Resolves #458

Added HMR support for the virtual CSS that comes from Svelte & Vue single-file components
Fix a sloppy bug introduced in 97f6c1f540cd2f09a5ed2d08c1cc225b0d9afa5c that broke HMR on master (@FredKSchott no more committing directly to master! :)
We now update all response imports to accept HMR updates, not just at the "hot cache" stage.

@drwpow For some reason this is an exceptionally unnecessarily messy diff. It's a much smaller change than it looks, happy to walk through in person.


@tamagui/build doesn't install devDependencies

Current Behavior
@tamagui/build doesn't install devDependencies.
I found out when I using monorepo and pnpm, and tried to reproduce with new empty project.

Expected Behavior
It should be install other stuff I supposed?
Tamagui Version
1.9.22

Reproduction
Run `watch` in CodeSandbox project provided by this template.

LINK
System Info
No response

Is this a codesandbox thing? It works for me locally with yarn.

Weird, in npm docs:
https://docs.npmjs.com/cli/v8/commands/npm-install

Only thing I can think of is you have NODE_ENV set in your shell and somehow codesanbox does too but that can't be true...

I think technically "devDependencies" are dependencies which are not needed by the library when it is in operation. And technically- these modules which @tamagui/build uses are actually regular "dependencies" since they are needed in its operation. Yarn may be excluding them in the installation because it seems them as internal to the module's build process and not useful in our project.

Put it back into dependencies in 1.11.1 I think this makes sense because so long as you put @tamagui/build into devDependencies it wont install it on your production build, but dev deps dont install transitively so its confusing otherwise.

It's truly a bit weird that npm and other acting weird... 😯
Anyway, thanks for solving the issue!


[WIP][QUARKS-139] Init gradle branch

merging @lfeagan and @ddebrunner 's work and init branch

Build error seems affected by build.xml file changed. I will proceed with ignore once


okular-nightly: Fix URL so that download errors won't happen later.

Relates to https://github.com/ScoopInstaller/Versions/issues/787
Relates to https://github.com/ScoopInstaller/Versions/issues/705

[x] I have read the Contributing Guide.

/verify

/verify


Change order of subscribes to do the most derived object classes first

Currently the EncodingRulesTester subscribes to the attributes per object classes in SOM file order. This means that an object is often discovered at a knownObjectClass which is not the same as the published object class. To solve this problem the level in the SOM hierarchy has to be determined and the subscribes performed from the deepest levels to the most shallow level.
The number of "." in the object class name determines how deep the class is. Thus, find the deepest level, perform all subscribes at this level, then the same for each one less deep level until all subscribes are done. This will make the test case more stable and allow the test federate to be running before the test case is started.

Have implemented the subscribes by depth (deepest nesting first). Made the summary report in the test case log easier to read by using only a single log call.


Add support for lab color

This is a major update of the library, it adds support for CIE L*a*b color conversion. With this change the properties of the color objects have been changed to capital letters because of the next reasons:

For consistency. For example, if the property to get the red channel is R and the property to get the rgb representation of the color is RGB it didn‘t make sense to work with objects with lowercase properties. It is more consistent if these properties are in capital letters too. E.g. { R: 255, G: 255, B: 0, A: 0.5 }
To make it possible to have CIE L*a*b colors with alpha. E.g. {L: 100, a: 50, b: 10, A: 0.5}

Closes: #140

Looks good to me!


dns: overflow unpacking uint32

I found a reproducible case of this using only this package, so it's not a SkyDNS bug. Here's how:
Using this server:
package main

import (
    "log"

    "github.com/miekg/dns"
)

func main() {
    handler := dns.HandlerFunc(handleRequest)
    log.Printf("Listening on UDP :53")
    err := dns.ListenAndServe(":53", "udp", handler)
    if err != nil {
        log.Fatal(err)
    }
}

func mustRR(s string) dns.RR {
    r, err := dns.NewRR(s)
    if err != nil {
        log.Fatal(err)
    }
    return r
}

func handleRequest(w dns.ResponseWriter, m *dns.Msg) {

    proxiedM := &dns.Msg{
        Answer: []dns.RR{
            mustRR("news.ycombinator.com.                    300 IN CNAME   news.ycombinator.com.cdn.cloudflare.net."),
            mustRR("news.ycombinator.com.cdn.cloudflare.net. 300 IN A       <IP_ADDRESS>"),
            mustRR("news.ycombinator.com.cdn.cloudflare.net. 300 IN A       <IP_ADDRESS>"),
        },
        Ns: []dns.RR{
            mustRR("cloudflare.net.         14881   IN      NS      ns3.cloudflare.net."),
            mustRR("cloudflare.net.         14881   IN      NS      ns2.cloudflare.net."),
            mustRR("cloudflare.net.         14881   IN      NS      ns1.cloudflare.net."),
            mustRR("cloudflare.net.         14881   IN      NS      ns5.cloudflare.net."),
            mustRR("cloudflare.net.         14881   IN      NS      ns4.cloudflare.net."),
        },
        Extra: []dns.RR{
            mustRR("ns1.cloudflare.net.     14881   IN      A       <IP_ADDRESS>"),
            mustRR("ns1.cloudflare.net.     14881   IN      AAAA    2400:cb00:2049:1::adf5:3b1f"),
            mustRR("ns2.cloudflare.net.     14881   IN      A       <IP_ADDRESS>"),
            mustRR("ns2.cloudflare.net.     14881   IN      AAAA    2400:cb00:2049:1::c629:de83"),
            mustRR("ns3.cloudflare.net.     14881   IN      A       <IP_ADDRESS>"),
            mustRR("ns3.cloudflare.net.     14881   IN      AAAA    2400:cb00:2049:1::c629:de1f"),
            mustRR("ns4.cloudflare.net.     14881   IN      A       <IP_ADDRESS>"),
            mustRR("ns4.cloudflare.net.     14881   IN      AAAA    2400:cb00:2049:1::c629:df83"),
            mustRR("ns5.cloudflare.net.     14881   IN      A       <IP_ADDRESS>"),
            mustRR("ns5.cloudflare.net.     14881   IN      AAAA    2400:cb00:2049:1::c629:df1f"),
        },
    }

    proxiedM.SetReply(m)
    if err := w.WriteMsg(proxiedM); err != nil {
        log.Print(err)
    }
}

If I run that and then run this client:
package main

import (
    "fmt"

    "github.com/miekg/dns"
)

func main() {
    m := new(dns.Msg)
    m.SetQuestion(dns.Fqdn("news.ycombinator.com"), dns.TypeA)
    aM, err := dns.Exchange(m, "<IP_ADDRESS>:53")
    fmt.Printf("%v %v", aM, err)
}

I get the error dns: overflow unpacking uint32 on the client's side. Additionally, if I remove any of the ns or additional records from the response then I get the error dns: buffer size too small.
Hopefully you are able to reproduce this as well, and we're able to get to the bottom of this :)

Ah, thanks for this! Without checking anything, this just looks like the buffer used (in skydns) is too small.
(But I should really check :) )

Yep, giving the client a larger buffer allows it to accept the message. The server shouldn't be sending a payload that large without EDNS or TCP involved.

@andrewtj being a forwarding is proxy is tricky at times :)

@miekg wouldn't be DNS if the whole weren't trickier than the parts :) By the by, compression makes that payload manageable.

There is a bug in Exchange() I think, when sending the message we don't check the EDNS0 size and thus default to 512 when receiving it.
This should mean that glibc sends messages with a bufsize != 512 and a EDNS0 record, haven't check that though.

Well, no there is no bug in client.Exchange() which is used by skydns, there is a bug in Exchange() which indeed does not check edns0 buffer sizes.


dependabot supports github actions

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
might be worth mentioning in the readme?

Yes you are correct. We should add this on the documentation as an alternative.


Shortcut when interpolation for t=0 or 1

Given that everything above the the check can't change the value of t, there's no point in doing all that processing and then ignoring it.

Nice catch 🚀


Slim down the brew taps by removing .git folder

Provide a detailed description of the proposed feature
At the moment the taps (/usr/local/Homebrew/Library/Taps/homebrew) at my machine are over 1Gb.
In each of the taps the most of space is taken by .git folders
homebrew-cask: 340 Mb of 360 Mb
homebrew-cask-versions: 76Mb of 77 Mb
homebrew-core: 590Mb of 620 Mb
While I understand that git is in the core functionality of the homebrew, removing of .git and keeping only the latest commit would save a lot of space.
What is the motivation for the feature?
Reducing the space for taps by 95%.
How will the feature be relevant to at least 90% of Homebrew users?
Reducing the space for taps by 95%.
What alternatives to the feature have been considered?
Please let me know if there's an alternative or a workaround.

The HOMEBREW_INSTALL_FROM_API environment variable was introduced in v3.3.0 about two months ago.

The HOMEBREW_INSTALL_FROM_API environment variable was introduced in v3.3.0 about two months ago.

Yup, this is the feature that will address this. I recommend testing it out.

Thank you @MikeMcQuaid @gromgit
After setting HOMEBREW_INSTALL_FROM_API=1 could I simply erase /usr/local/Homebrew/Library/Taps/ or will it have some unintended consequences?

You should instead run brew untap homebrew/core and brew untap homebrew/cask. Those are currently the only two taps that are supported by HOMEBREW_INSTALL_FROM_API so you'd lose the ability to use any other taps by removing that directory. However, the good news is that those two are by far the biggest taps so it should still make a difference.

Great, thanks a lot for the prompt response @Rylan12 !


Web UI replaces 0 in Parameter JSON view with "" which might lead to an invalid query

My Environment

ArangoDB Version: 3.9.10
Deployment Mode: Single Server
Deployment Strategy: Manual Start
Infrastructure: own
Operating System: Debian
Total RAM in your machine: 64Gb
Disks in use: HDD
Used Package: Debian .deb

Component, Query & Data
Affected feature: AQL query using web interface
AQL query (if applicable):
FOR doc in samples LIMIT @offset, 10 RETURN doc

with a parameter JSON of
{"offset": 0}

Steps to reproduce

Switch to the "Editor" tab under the "Queries" main entry
Switch the parameter view on the right to JSON
Past the AQL query and parameter from above into the corresponding fields
modify something in the query view

Problem: Modifying something in the query view will change the 0 in the parameter json into an empty string. If you now hit the "Execute" button you will be told that you didn't specify a number for the LIMIT offset.
Expected result: Modifying the query content should not change the parameter JSON in a way that makes the resulting query invalid.

Hey @larsborn, thanks for the detailed report!
This issue was fixed in #18985 and was backported to 3.9 (#18988). It's available in v3.9.11.


[Test-Framework] Don't start Test proxy if all tests are ignored in test class

The Test Proxy is started up as part of a OneTimeSetup for the RecordedTestBase. If all tests are going to be ignored based on attributes (e.g. based on service version), we can skip this setup.

This is now obsolete since we now only start a single instance of the test proxy per process.


Add Coming Soon sign to Catalog

Desired State of the Meshery.io site
Bad font - don't use - SVG - coming-soon-patterns
PNG - coming-soon-patterns

Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

The best that I could slap together in 6 minutes.

That's really really red 😅


Unable to access API for streams mode

Hi,
I have used the helm-chart to deploy Redpanda Connect in our Kubernetes env. I followed following commands
helm repo add benthos https://benthosdev.github.io/charts/
helm repo update
helm install benthos/benthos

I see a Deployment,Service,ConfigMap after installing.
I added values.yaml configmap to have the streams mode on
# values.yaml
streams:
  enabled: true
  streamsConfigMap: "benthos-streams"

I restarted the deployment. I wanted to access the API of Redpanda connect to run pipelines in streams mode
like in here - https://docs.redpanda.com/redpanda-connect/guides/streams_mode/streams_api/
I am not sure how to access this API with the given helm chat installation. Am I missing some pieces here? Can you please help
Thanks

So we are able to get it up and running
We tried to access the api

GET /streams
POST /streams

When we tried to do POST /streams with connect pipeline and  we have issues connecting to input kinesis due to some FW issues. It is taking the whole API down.
Accessing -GET /streams - gives us 503,404 no healthy upstream responses.
Is there an issue here?


b80fabd5-69d6-48fb-9f8e-de7f2c6921e5

this is for automated testing

dcb0caa9-d868-4390-bec5-0ab652312424


Why are the documents in the wiki not available, all connections are https://github.com/alibaba/fescar/wiki/Home_Chinese?

为什么wiki中的文档都没有了，全部连接都是  @https://github.com/alibaba/fescar/wiki/Home_Chinese ？

It is ok now, I will close the issue, if you have other questions, please reopen it or create a new one


Migrate SHA and factors examples

Add the sha and factors examples from https://github.com/risc0/risc0-rust-examples to this repository, as a proof of concept for merging all our examples into the main repository.
As currently drafted, this PR uses a single workspace for both examples. This will help avoid a profusion of workspaces. However, it leads to an awkward name collision with the methods crate -- this PR uses factors-methods and sha-methods. Probably this is acceptable but I wanted to flag it as a potential point of confusion for people looking at our examples. See the 8d6ba26 commit for details on this merge.

Now that I've drafted up #374, I think this approach is better. Although disambiguating methods as factors-methods and sha-methods isn't ideal, I think splitting out the guest methods from the individual examples and putting them in a shared methods directory is more confusing. This PR's version also makes the examples further from the starter template code, creating more changes we need to explain in every example tutorial.

If we had a tool for generating a starter project instead of a template repository, would your thinking on this change?

If we had a tool for generating a starter project instead of a template repository, would your thinking on this change?

I don't think so. I think these are orthogonal concerns, in that whatever code was generated by our tool would still be structured differently from the examples as written in #374. The key difference is that right now and in #373, if someone writes code starting from the starter template and following our tutorial in https://www.risczero.com/docs/examples/hello_multiply, they can compare to the contents of https://github.com/risc0/risc0-rust-examples/tree/main/factors to see if they did thing right and how they differ from the intended approach. In #374, there is no folder to point them at for this without also saying "and ignore these other examples files and these members/methods entries in some Cargo.toml files. Whether they start coding from a starter template or from tool-generated starter code, their end result still won't look like our published examples if we go with #374.
My other concern is the one I mentioned in #374 -- that people going to the examples directory will be confused about which folders are examples. Someone coming to look at examples will see e.g.
chess
factors
methods
sha
voting-machine

and one of those things isn't an example, but that's not obvious. We can alleviate this some with a README, but of course GitHub puts the directory contents above the README, so this is imperfect.

Would it make sense to adjust the tutorial and/or the starter so that it matches this?

Would it make sense to adjust the tutorial and/or the starter so that it matches this?

I don't know how we could make the tutorial "match this" because I'm worried about the final state of the tutorial code, not its initial state. Fundamentally, unless the tutorial literally involves creating multiple examples, someone following the tutorial will not be able to compare what they create to our examples without understanding our code well enough to know what to ignore, which probably involves telling them "when you go to compare to the example, here is what is the example, and here is what to ignore".
(I did previously have concerns about initial state mismatch too, but thanks to your feedback those concerns are now addressed.)
As for my concern about people going to the example directory not knowing which things are examples: This doesn't involve tutorial/starter code, so how well they do/don't match has no effect on it.

Using the approach in #374 instead.


Formatting only: apply Save Actions on some files

Pull Request Test Coverage Report for Build 5369

3 of 11 (27.27%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 40.79%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-web-server/src/main/java/azkaban/webapp/servlet/ExecutorServlet.java
0
3
0.0%

azkaban-common/src/main/java/azkaban/server/HttpRequestUtils.java
3
8
37.5%

Totals

Change from base Build 5367:
0.02%

Covered Lines:
13213

Relevant Lines:
32393

💛  - Coveralls

@djaiswal83 @ypadron-in how about merging this? To have a cleaner diff in https://github.com/azkaban/azkaban/pull/2523.

@ypadron-in, thanks for approving. Anything to prevent merging this? I don’t have the permission.


Build to phone?

I have downloaded this example, and it builds fine but does not run on the phone, doesn't appear to copy to the phone at all, am I missing something?

Currently it's available for iOS 10, be sure your phone has the same version, and check also the devices list on Xcode


Yew app renders fine locally but not on GH Pages.

Problem
My Yew app here works fine when I run it locally with trunk --config trunk.toml serve. Deployed on GH Pages, however, all I see is a black screen. When I open the app on localhost:8080 locally, I see all elements and everything works as it should.
Steps To Reproduce
Steps to reproduce the behavior:

Go to the app's repository.
Click on the link in the description.
See the issue description above.

Expected behavior
The app should have been rendered properly.
Environment:

Yew version: 0.20 from crates.io
Rust version: rustc 1.66.0 (69f9c33d7 2022-12-12)
Target, if relevant: wasm32-unknown-unknown
Build tool, if relevant:  trunk
OS, if relevant:  Ubuntu - latest
Browser and version, if relevant: 108.0.5359.124 (Official Build) (x86_64)

This is not a bug. Your paths are not setup correctly. The web page is trying to load https://angeldollface.art/ceramic.rsceramic-rs-86a52a549ebd0d45.js and the corresponding wasm blob which don't exist at those paths.
You'll need to use trunk --public-url.

Hi @simbleau! :heart: Sorry, for posting it here. I wasn't sure where to post this. I find Yew so cool, btw. ❤🔥 Anyway: I added the trailing slash, weirdly, it still isn't rendering. Thoughts?

There must be a reason I'm missing why trunk doesn't generate the glue code to call your main function. If you paste the following into the console, the app renders fine:
(await (await import('/ceramic.rs/ceramic-rs-86a52a549ebd0d45.js')).default('/ceramic.rs/ceramic-rs-86a52a549ebd0d45_bg.wasm')).main()

Honestly this is not reproducible for me either. When I run it locally, it works fine.
But you're right - for some reason it's not calling init.
finalizeInit should look like this:

But it looks like this:

Where is the wasm.__wbindgen_start();?
Are you post-processing this somewhere?

Negative, I'm not. Perhaps the GitHub Action is doing something? Actually let me test whether the local build peoduces the same behavior.🤔🤔

@simbleau I fixed it. This issue mentions somebody having release flags set in their project's Cargo.toml to optimize their executable. I removed these flags in the latest commit of my project here. Here's the link to the commit. Maybe this is a bug?

@simbleau Also, thank you so much for trying to debug this for me. :heart_on_fire:

Underlying issue
tl;dr don't use strip = "symbols" or strip = true for now.

Underlying issue
tl;dr don't use strip = "symbols" or strip = true for now.

Alright. 👍

Underlying issue
tl;dr don't use strip = "symbols" or strip = true for now.

Shouldn't we add this to the docs, though? Could be confusing for people who know Rust but not Yew.

Underlying issue
tl;dr don't use strip = "symbols" or strip = true for now.

Shouldn't we add this to the docs, though? Could be confusing for people who know Rust but not Yew.

It's not really yew specific though, since it affects any wasm it seems. And I wouldn't want to add docs that will get eventually outdated. If you have any idea to make this more discoverable in this issue tracker, I think that's sufficient. Might revisit this if it pops up again for somebody else.

Underlying issue
tl;dr don't use strip = "symbols" or strip = true for now.

Shouldn't we add this to the docs, though? Could be confusing for people who know Rust but not Yew.

It's not really yew specific though, since it affects any wasm it seems. And I wouldn't want to add docs that will get eventually outdated. If you have any idea to make this more discoverable in this issue tracker, I think that's sufficient. Might revisit this if it pops up again for somebody else.

Fair enough. Hmm, I think maybe adding a custom label? Something like "Yew + GH Pages not rendering"? Something that'll show up on Google, basically. ❣

Good issue save my live!


Feature: Individual Lap Timer

There should be a timer for the individual lap, not just the total elapsed time. This new lap timer will take the front-and-center view in Stopwatch, and the total elapsed time will be in a smaller font to the upper right of the lap time.

アカウントを乗っ取られました。


Crash when generating world with YUNG's better caves (1.12)

crash report: https://pastebin.com/bRkKCPQC
Nether EX version: I tried differend ones, the newest (2.1.5), and some previous ones

I did not encounter a crash when using the latest versions of LibraryEx, NetherEx, and YUNG's Better Caves. If you do encounter a crash when using the latest versions of the mods, send me that crash report.

I Had a crash while generating a world, then I deleted NetherEX, and after some time I added the same Version, and it works idk why

I think I forgot to include LibaryEX in my modpack then, now I added it too, so this is why


[Docs]: Table in email verification link guide has wrong primary key (?)

Description
In https://lucia-auth.com/guidebook/email-verification-links/, should it be

name
type
primary
references
description

id
string
✓

Token to send inside the verification link

expires
bigint (unsigned 8 bytes)

Expiration (in milliseconds)

user_id
string

user(id)

instead of

name
type
primary
references
description

id
string

Token to send inside the verification link

expires
bigint (unsigned 8 bytes)
✓

Expiration (in milliseconds)

user_id
string

user(id)

?

Sorry, fixed with #1277


Migrate to WHATWG MIMEType

Nevermind, I just saw this is a duplicate of #2079, sorry for the noise.


HMR always reloading script in SFC when just style is changed if using another vite plugin that transforms the script

Related plugins

[X] plugin-vue

[ ] plugin-vue-jsx

Describe the bug
When using another vite plugin like @vue-macros/reactivity-transform that transforms the source code, HMR will always update the script part of an SFC even if it's not changed, for example when editing just css. This leads to the whole script being executed again and state being lost.
When changing css I expect this in the console:
[vite] hmr update /src/App.vue?vue&type=style&index=0&scoped=7a7a37b1&lang.css

but with another plugin present I get:
[vite] hmr update /src/App.vue, /src/App.vue?vue&type=style&index=0&scoped=7a7a37b1&lang.css

This most likely happens because handleHotUpdate reads the raw file, parses it, and compares it with the previous version from the cache populated by transformMain, which gets the already transformed code directly from vite. Since the untransformed and transformed source is always different, even if no edits happen, vite-plugin-vue assumes an edit happened and adds the script to the list of affected modules.
I looked a bit into a solution, but neither always caching with the raw source nor always transforming seems straight forward.
Applying the same plugins to the source in the handleHotUpdate hook so it's based on the same code that the transform hook gets is probably preferable, but I couldn't find anything to do that in the vite API.
Reproduction
https://stackblitz.com/edit/vitejs-vite-tzll9a?file=src%2FApp.vue&terminal=dev
Steps to reproduce

Change something in the styles of App.vue
Save file

System Info
System:
    OS: Linux 6.4 Arch Linux
    CPU: (16) x64 AMD Ryzen 7 PRO 6850H with Radeon Graphics
    Memory: 19.42 GB / 30.62 GB
    Container: Yes
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.4.0 - /usr/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 9.8.1 - /usr/bin/npm
    pnpm: 8.6.9 - /usr/bin/pnpm
  Browsers:
    Chromium: 115.0.5790.102

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I found a solution and will submit a PR soon.

I sketched out two different solutions:
[A] Transform original source with preceding plugins
Code
Since handleHotUpdate reads the original source from the filesystem, we can call the transform hook of all plugins preceding plugin-vue to get the source to a state that matches what our own transform would get and would write into the cache, at which point the two script versions would match.
[B] Save original source on our tranform hook
Code
Alternatively, we can save the descriptor of the original source alongside the partially transformed source that we get in our transform hook and compare against that in handleHotUpdate. This solution could also be implemented with a separate "original source" cache.

Which is the better approach? Both have pros and cons.
A populates the cache in a way that's more what is expected by other pieces of code. It's just coincidence that no other code is looking at the cached content while it wrongly contains the original source. But A does not quite call transform hooks of preceding plugins the right way. It's currently missing the plugin context, which I'm not sure how to properly reconstruct. It should do something similar to what vite itself does but I don't want to copy-paste all that code. vue-macros doesn't use the context, so for my specific bug, this detail does not matter.
B does not change current cache behaviour at all, but adds more complexity by additionally caching the original source.
I think A tries to follow the spirit of the cache more.
Other plugins (like svelte) theoretically have the same problem, but using code-transforming macros is pretty niche right now.
The issue that handleHotUpdate does not have access to the same source that transform does might even be tackled in vite itself?

Fixed by https://github.com/vitejs/vite-plugin-vue/pull/227


make :id and :*_id path parameters of type "integer"

Follow up for https://github.com/octokit/rest.js/issues/1001
This will require to maintain a list of exceptions

:client_id is a string (https://developer.github.com/v3/oauth_authorizations/)

The only other exception that I have identified is :gist_id which should probably not be called _id

https://developer.github.com/v3/gists/,
https://developer.github.com/v3/gists/comments/

:gist_id which should probably not be called _id

I’ll raise it with the docs team! What would you call it instead? Maybe :gist_sha?


Add optional showDismissButton prop for showing dismiss button in bottom drawer

Changes:

Add optional showDismissButton prop for showing dismiss button in BottomDrawer

@Sreejit7 Fictoan generally uses the isDismissable convention to show/hide the button, as is the case in the NotificationItem component.
Which one do you think makes more sense?

@sujan-s I think it makes sense to stick to the convention we already have. Updated the name :)


Change Loader method at runtime

Hi everyone!
I have a little problem with my project and angular translate. My app is composed of two parts, one that can be accessed by anybody, and the second that needs login in.
I need to retrieve translation data from a distant server but this data can only be accessed once logged in. So I was wondering if it was possible to first create a custom loader that would contain the necessary data for my access-free pages, and once I'm logged in, I switch to the distant data.
I've tried to use the partial Loader but the problem is that the URL is use doesn't end in .json, so I don't see how I could switch between local files and the distant data.
I'm aware that it may not be the best way, but I haven't found the correct solution in the documentation.
Any help would greatly be appreciated!
Sami

Closing due inactivity. Additionally, we recommend using a custom loader. You can even re-use the existing ones.


No module named 'cvtk'

I am running the code in Azure Notebooks.  I got this error: "ImportError: No module named 'cvtk'.
Can advise how to solve it?

@justshot same issue i'm facing any resolution you got ?

I remember one staff from Microsoft suggested me to use Tensorflow library
directly.
I didn't try.
On Wed, 15 May 2019 at 19:26, Ashish Kumar<EMAIL_ADDRESS>wrote:

@justshot https://github.com/justshot same issue i'm facing any
resolution you got ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CatalystCode/Handwriting/issues/3?email_source=notifications&email_token=AA72A7IZK5JEZPWBYVGKJDTPVPXNTA5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOLN3Y#issuecomment-492615407,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA72A7LDK63AZWZHSEMUCV3PVPXNTANCNFSM4GSS3QXQ
.

I remember one staff from Microsoft suggested me to use Tensorflow library directly. I didn't try.
…
On Wed, 15 May 2019 at 19:26, Ashish Kumar @.***> wrote: @justshot https://github.com/justshot same issue i'm facing any resolution you got ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=AA72A7IZK5JEZPWBYVGKJDTPVPXNTA5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOLN3Y#issuecomment-492615407>, or mute the thread https://github.com/notifications/unsubscribe-auth/AA72A7LDK63AZWZHSEMUCV3PVPXNTANCNFSM4GSS3QXQ .

@justshot Were you able to solve this issue?

MS suggest me to use Tensorflow.
On Mon, 19 Aug 2019 at 16:27, niloofers<EMAIL_ADDRESS>wrote:

I remember one staff from Microsoft suggested me to use Tensorflow library
directly. I didn't try.
… <#m_-5983270632730649054_>
On Wed, 15 May 2019 at 19:26, Ashish Kumar @.***> wrote: @justshot
https://github.com/justshot https://github.com/justshot same issue i'm
facing any resolution you got ? — You are receiving this because you were
mentioned. Reply to this email directly, view it on GitHub <#3
https://github.com/CatalystCode/Handwriting/issues/3?email_source=notifications&email_token=AA72A7IZK5JEZPWBYVGKJDTPVPXNTA5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOLN3Y#issuecomment-492615407>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA72A7LDK63AZWZHSEMUCV3PVPXNTANCNFSM4GSS3QXQ
.
@justshot https://github.com/justshot Were you able to solve this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CatalystCode/Handwriting/issues/3?email_source=notifications&email_token=AA72A7JOS6OE6HJMAQ42K7DQFJKP3A5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4SDP3A#issuecomment-522467308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA72A7NBMG7J5EDPAR5WAW3QFJKP3ANCNFSM4GSS3QXQ
.

MS suggest me to use Tensorflow.
…
On Mon, 19 Aug 2019 at 16:27, niloofers @.> wrote: I remember one staff from Microsoft suggested me to use Tensorflow library directly. I didn't try. … <#m_-5983270632730649054_> On Wed, 15 May 2019 at 19:26, Ashish Kumar @.> wrote: @justshot https://github.com/justshot https://github.com/justshot same issue i'm facing any resolution you got ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 <#3>?email_source=notifications&email_token=AA72A7IZK5JEZPWBYVGKJDTPVPXNTA5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOLN3Y#issuecomment-492615407>, or mute the thread https://github.com/notifications/unsubscribe-auth/AA72A7LDK63AZWZHSEMUCV3PVPXNTANCNFSM4GSS3QXQ . @justshot https://github.com/justshot Were you able to solve this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3?email_source=notifications&email_token=AA72A7JOS6OE6HJMAQ42K7DQFJKP3A5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4SDP3A#issuecomment-522467308>, or mute the thread https://github.com/notifications/unsubscribe-auth/AA72A7NBMG7J5EDPAR5WAW3QFJKP3ANCNFSM4GSS3QXQ .

Were you able to solve this issue using Tensorflow?

I didn't follow up.
On Thu, 5 Sep 2019 at 20:18, niloofers<EMAIL_ADDRESS>wrote:

MS suggest me to use Tensorflow.
… <#m_4553726517189491182_>
On Mon, 19 Aug 2019 at 16:27, niloofers @.> wrote: I remember one
staff from Microsoft suggested me to use Tensorflow library directly. I
didn't try. … <#m_-5983270632730649054_> On Wed, 15 May 2019 at 19:26,
Ashish Kumar @.> wrote: @justshot https://github.com/justshot
https://github.com/justshot https://github.com/justshot same issue i'm
facing any resolution you got ? — You are receiving this because you were
mentioned. Reply to this email directly, view it on GitHub <#3
https://github.com/CatalystCode/Handwriting/issues/3 <#3
https://github.com/CatalystCode/Handwriting/issues/3>?email_source=notifications&email_token=AA72A7IZK5JEZPWBYVGKJDTPVPXNTA5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVOLN3Y#issuecomment-492615407>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA72A7LDK63AZWZHSEMUCV3PVPXNTANCNFSM4GSS3QXQ
. @justshot https://github.com/justshot https://github.com/justshot
Were you able to solve this issue? — You are receiving this because you
were mentioned. Reply to this email directly, view it on GitHub <#3
https://github.com/CatalystCode/Handwriting/issues/3?email_source=notifications&email_token=AA72A7JOS6OE6HJMAQ42K7DQFJKP3A5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4SDP3A#issuecomment-522467308>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA72A7NBMG7J5EDPAR5WAW3QFJKP3ANCNFSM4GSS3QXQ
.
Were you able to solve this issue using Tensorflow?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CatalystCode/Handwriting/issues/3?email_source=notifications&email_token=AA72A7MR4BG2KDQTAWX7OMTQID2JBA5CNFSM4GSS3QX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD564NHA#issuecomment-528336540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA72A7IALYSLVMF3ELFG6ALQID2JBANCNFSM4GSS3QXQ
.


Question: How to highlight diagnostic virtual text?

A lot of colorschemes provide a way to configure the highlighting of diagnostic virtual text. I saw that Kanagawa provides the overrides option, which I believe could be used to implement this, but I'm not sure how to do it in a way that wouldn't require me to hard-code color values for each style.

The above two screenshots show what I'm referring to. The first screenshot is Tokyonight which highlights the virtual text for the error diagnostic with a faint red background, while the second screenshot is Kanagawa which has no background highlight.
I identified the highlight groups that are responsible for this component, but I couldn't figure out how to customize them appropriately. For example, I tried to set the foreground color as the background and apply a high blend value to make it more faint, but I must've been doing something wrong because the blend had no effect.
overrides = function(colors)
  local theme = colors.theme
  local make_highlight = function(fg)
    return { fg = fg, bg = fg, blend = 80 }
  end
  return {
    DiagnosticVirtualTextHint = make_highlight(theme.diag.hint),
    DiagnosticVirtualTextInfo = make_highlight(theme.diag.info),
    DiagnosticVirtualTextWarn = make_highlight(theme.diag.warn),
    DiagnosticVirtualTextError = make_highlight(theme.diag.error),
  }
end,

UPDATE:
After looking through Tokyonight's source code, I figured out how to do it and it looks pretty good in my opinion.

Here's the necessary code (copy-pasted from Tokyonight) to make it happen. From my understanding of the code, it seems that you need to manually blend the background and foreground colors.
overrides = function(colors)
  local theme = colors.theme

  local hexToRgb = function(c)
    c = string.lower(c)
    return { tonumber(c:sub(2, 3), 16), tonumber(c:sub(4, 5), 16), tonumber(c:sub(6, 7), 16) }
  end

  local blend = function(foreground, background, alpha)
    alpha = type(alpha) == "string" and (tonumber(alpha, 16) / 0xff) or alpha
    local bg = hexToRgb(background)
    local fg = hexToRgb(foreground)

    local blendChannel = function(i)
      local ret = (alpha * fg[i] + ((1 - alpha) * bg[i]))
      return math.floor(math.min(math.max(0, ret), 255) + 0.5)
    end

    return string.format("#%02x%02x%02x", blendChannel(1), blendChannel(2), blendChannel(3))
  end

  local darken = function(hex, amount)
    return blend(hex, theme.ui.bg, amount)
  end

  local make_highlight = function(color)
    return { bg = darken(color, 0.1), fg = color }
  end

  return {
    DiagnosticVirtualTextHint = make_highlight(theme.diag.hint),
    DiagnosticVirtualTextInfo = make_highlight(theme.diag.info),
    DiagnosticVirtualTextWarn = make_highlight(theme.diag.warning),
    DiagnosticVirtualTextError = make_highlight(theme.diag.error),
  }
end,

I don't know if this is something you would like to integrate into Kanagawa. I personally believe it would be a nice option to have.
Also, I'm not familiar with open source licenses and IP issues, but the only thing that I can potentially see as an obstacle to using the above code in Kanagawa would be that Tokyonight is using the Apache 2.0 license, whereas Kanagawa uses the MIT license. Although, I'm sure that it would be possible to refactor the above code enough to be able to get around the issue (if there even is one in the first place).

That's awesome! Thanks for the simpler solution and for considering my feature request. :)

Inspired by the suggestion in this issue, I've created a small PR to add this method to the README: https://github.com/rebelot/kanagawa.nvim/pull/228 🙇♂


orderBy not working

The documentation says:
Result<Person> query = data
    .select(Person.class)
    .where(Person.NAME.lower().like("b%")).and(Person.AGE.gt(20))
    .orderBy(Person.AGE.desc())
    .limit(5)
    .get();

However, nothing after the orderBy line works.
It says "cannot resolve method limit(int)"

There are numerous test cases and examples using orderBy and limit, added another one. Are you sure your'e not missing something?

Thank you for your reply.  I checked your tests and you are correct.
My getData method was returning EntityDataStore instead of EntityDataStore<Persistable>, which caused the error.

Sure, glad you found the cause


Add metadata fields to statistics finder.

Add metadata fields to statistics finder.
Adds Document Type and Publishing orgs as metadata.
Adds Updated date and collection to 'published' statistics.
Adds Release date and cancelled/confirmed state to 'upcoming' stats
The search api only indexes 'updated date' and 'collection' metadata
on 'published' stats and 'release date' and 'state' on 'upcoming'
stats so no extra logic is needed.
See Trello: https://trello.com/c/XLdskaKe/382-make-stats-results-metadata-match-existing-metadata

As a general question, do we want to make this more or less exactly like the Whitehall finder in not showing the labels for the metadata, except for the collection.
Example
Whitehall

This PR

The metadata in Whitehall is a bit different, but the existing code in Finder-frontend styles metadata like this. Maybe we need some design input?

If this is a question of style, go with the finder-frontend look. If this is a question of content, I'm not sure.


Shift operations among encrypted values

Hello!
I just wanted to ask whether the shift operator was going to be implemented maybe in the future, since I saw in the old documentation the shift function reported in the class Pyfhel: "shift -> SHIFT each cyphertext inside PyCtxt ctxt for each ID in it."
Thank you!
By the way, amazing work with this library. I'm doing some research in this field and I found using Pyfhel really straightforward.

Thanks for the pointers! I just pushed v2.2.2 showcasing the already existing shift/rotation functionality for BATCH encoding. Have a look at the Demo_SIMD.py.

Thanks for the pointers! I just pushed v2.2.2 showcasing the already existing shift/rotation functionality for BATCH encoding. Have a look at it on line 81 of Demo_SIMD.py.

Thank you!

Hello @ibarrond , I'm sorry to bother you again. I was continuing my work using your library and I think there might be something wrong in the last Pyfhel version.
When I initially opened this issue there was an older version of Pyfhel which allowed me to perform shift operation using as the amount of bits to shift an encrypted or encoded value.
While now, in the 2.3.1 version, if I try to run the same exact code I will get an error saying:
---> ctxt1_rot = ctxt1 << intctxt2

Pyfhel/PyCtxt.pyx in Pyfhel.PyCtxt.PyCtxt.__lshift__()

Pyfhel/Pyfhel.pyx in Pyfhel.Pyfhel.Pyfhel.rotate()

TypeError: an integer is required

And I think it's strange, given that in a previous Pyfhel version it worked very well.
If you want to take a better look at what I'm talking about I uploaded here on Colab the same notebook while using first Pyfhel 2.2.4 and then 2.3.1, showing that differently from the last version in a previous one it worked very well.
The rotation operator usage is in the last cell of both notebooks.
2.2.4 version: https://colab.research.google.com/drive/1_mVbTtCGLzi7k0EcpqnSJ5Y_pEpk6Ui5?usp=sharing
2.3.1 version: https://colab.research.google.com/drive/1Ec93uw1XXRKNmzDbHBLzbgIXxlXJ4VKN?usp=sharing

Closing as the issue was answered


Fix manual install

Fixes an issue where when manuallybuilding after a failed download, "undefined" would sneak in to the arguments for node-gyp. Also updates missing changelog entries (not including 0.5.x) and bumps to 0.6.3

This passed on appveyor the previous commit, and i only changed the travisyml, and travis has passed so I'm merging this. @johnhaley81 reviewed this just to be safe.

@maxkorp you missed v0.5.0 in the CHANGELOG.md fyi

@johnhaley81 you missed my note about that


[mrp] Inline ReliableMessageContext getters and setters

Problem
I noticed that inlining ReliableMessgeContext getters & setters reduces the code size a bit.
Change overview
Move ReliableMessgeContext getters & setters to the header.
Testing
CI only.

fast track: simple refactor with bots reporting size benefits.


crash on map load

base is crashing when loading into a map
its crashing here:
void CS_FASTCALL H::FrameStageNotify(void* rcx, int nFrameStage)
{
const auto oFrameStageNotify = hkFrameStageNotify.GetOriginal();
F::OnFrameStageNotify(nFrameStage);
return oFrameStageNotify(rcx, nFrameStage);

}

fixed it :
namespace CLIENT
{
enum
{
CREATEMOVE = 5U,
MOUSEINPUTENABLED = 12U,
FRAMESTAGENOTIFY = 33, // Change from 32U to 33
};
}
}
but somehow the chams are only working for visible and non visible isnt working

the invis chams only work on debug atm, thanks for telling me that framestagenotify index is updated


gitea dump does not include lfs folder if LFS_CONTENT_PATH is set to a custom folder

Gitea version (or commit ref):
Git version:
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
Running gitea on Windows Server 2019 with LFS enabled. The command:
gitea dump ...
does not include the lfs folder if the folder is not in the default folder (e.g. c:\Program Files\Gitea\data\lfs).
I have my lfs folder in a RAID 1 volume (just like the repos and everything I need to backup) at D:/Gitea/data/lfs and I did set:
LFS_CONTENT_PATH = D:/Gitea/data/lfs
Im not a go expert but by reading the dump.go code looks like it simply includes the folders under c:\Program Files\Gitea\data without checking if the lfs folder is somewhere else. Of course adding a link does not work.
...
Screenshots

Looks like lfs are not dumped on official 1.11 release either. Is there maybe a setting that I am missing? I am zipping them separately myself, but it would be a lot easier if Gitea was taking care of dumping them along with the other files...

I am experiencing a similar issue (no LFS in backup with custom LFS_CONTENT_PATH=/home/git/gitea-lfs) on version 1.10.1.

@philipphomann would you like to offer your fix as a PR to Gitea?

@zeripath It is included in #10376 which still waits on second approval (:


Integrate volunteers data to modal

Integrate volunteers data to modal
Clean up row selection code for table of volunteers data

Added the workaround and tested!


Add article about codespaces

contributing/codespaces.md
Why:
Closes [issue link]

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

This seems to have been opened accidentally, I am going to close it now :yellow_heart:
Take a look at the contributing.md to learn how to contribute in this repo. You can open a discussion if you have any questions or check out issues with the help wanted label. :sparkles:


BackstopJS tests not loading object data from mock requests

Describe the bug
BacktopJS tests that include mock requests to Request Broker are not functioning correctly - object data is not displayed.
To reproduce
Steps to reproduce the behavior:

Run DIMES locally
In another terminal, run the backstopJS tests usuing yarn backstop-test
See the resulting tests on the My List page and in the request modals that show collection info, but not the associated archival objects.

Expected behavior
The test snapshots should match the DIMES UI and include the archival object data that has been added to the users list. That data is in the mock requests located in the backstop_data/request_reference directory.
Error message or screenshots
Screenshot of My List test:

Impact on your work
Impacts our ability to the UI for unintended changes.

OK I totally rubber ducked myself into figuring this out!
What's happening is that a request is being made behind the scenes to the browser's localStorage, and then that data is used to filter out any items that might have been removed from the list: https://github.com/RockefellerArchiveCenter/dimes/blob/base/src/components/PageMyList/index.js#L264-L266
Because the "browser" storage in this case is empty, the fetchMyList function returns an empty list, which then filters out all of the items.
Solution-wise, I think we need to either find a way to mock that fetchMyList function or the browser localStorage state.


Explain when you need to update a PWA in the store

I've read through https://learn.microsoft.com/en-us/microsoft-edge/progressive-web-apps-chromium/how-to/microsoft-store and understand how to generate an app from a PWA and publish it to the store.
What I don't understand is when I would need to regenerate the PWA to update it. Looking at the generated app packages, it seems like it is mostly images. I couldn't find much from the actual manifest except from the start-url.
I think it could be good to add a section explaining when you need to update your app. My guess would be that you need to do this:

When you want to update assets in the store, or your app icon
When you want to update your start-url

Is this correct? Are there more reasons to update a PWA app in the store?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d7f49d04-dd9e-9d95-6bc3-f158e4eacada
Version Independent ID: 5e3a5695-0978-7051-45d1-623dbb757f22
Content: Publish a Progressive Web App to the Microsoft Store - Microsoft Edge Development
Content Source: microsoft-edge/progressive-web-apps-chromium/how-to/microsoft-store.md
Product: microsoft-edge
Technology: pwa
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

This is a very good point @danielcompton. Let me make sure this issue is tracked on our backlog so we can prioritize it and update the docs.
I think your assumption about when you'd need to update the package in the store is correct, but we'll need to double-check internally with the right team before updating the docs.


Remove partition affinity from Event Hub Producer Client

Summary
In its current form, an instance of the EventHubProducerClient must be bound to a specific Event Hub partition in order to publish events explicitly to that partition.  The client should be able to work dynamically across all partitions, allowing a partition to be specified when publishing an event batch, similar to how a partition key is accepted.  One client instance should be able to communicate with any partition of the associated Event Hub on demand or publish to the gateway for automatic routing or partition key hashing.
Scope of Work

The EventProducerClient does not accept an option specific to a partition when it is constructed.

The notion of instance-level state for partition association has been removed.

The SendOptions allows for a PartitionId to be specified, allowing null but not empty strings.

When an event batch is sent, validation should be performed to ensure that the send options contain either a partition identifier or a partition key, but not both.   Having neither is also acceptable.

Tests have been added or adjusted to cover the updated API and ensure its functionality.

Out of Scope

Updates or changes to samples beyond ensuring that the project can be compiled; these will be covered under a separate work item.

Updates or changes to documentation; these will be covered under a separate work item.

Background cleanup of internal transport clients for partitions addressed by the client instance; this will be an enhancement covered under a separate work item.

Success Criteria

The refactoring and enhancements  detailed by the scope have been completed.

The tests necessary for its validation have been created or adjusted and pass reliably.

The existing test suite continues to produce deterministic results and pass reliably.

References

Event Hubs Client Library Strawman
Event Hubs Client Library Skeleton

The SendOptions allows for a PartitionId to be specified, allowing null but not empty strings.

Did we consider having an overload that takes the partitionId instead of having it in the SendOptions?

The SendOptions allows for a PartitionId to be specified, allowing null but not empty strings.

Did we consider having an overload that takes the partitionId instead of having it in the SendOptions?

It was considered, but remains an obscure corner case expected to be used less frequently than the partition key, which is in the options.


Develop

Coverage decreased (-0.7%) to 85.734% when pulling 49d902dfed0fa9e6d7f582f48a7fc9b0c40bc479 on develop into fc8121c3eaa6e48a24d104fa3bc0e06186321a0f on qa.


expire property necessary?

Since we have kept reference of timeout handle, is it necessary to add expire  as a property and check it every time we call get method? Is not obvious that it exists means it is not expired? Any other uses ?

I would like to have the option to set TTL without adding a timeout function. So the cache invalidation is handled on the next get request. For that kind of purpose the expiration field would be very useful, but for now I also don't see the purpose for that, except for debugging.


Handle error in pa_context_get_server_info.

This addresses Gecko Bug 1438414, where debug_assert_ne!(i, ptr::null_mut()) fires in callback for Context::get_server_info.
From reading the PulseAudio source code, this happens in a few error cases, such as command timeout.

It does seem odd. The report starts early/mid February 2018.  I've opened a PR against cubeb to add matching check.


Unable to install Docker on CentOS7.1

Giving Docker a first try, for managing glibc incompatibilities in a build.
Additional environment details (AWS, VirtualBox, physical, etc.):
Physical machine, running CentOS 7.1.1503
Steps to reproduce the issue:
$ sudo yum update
$ curl -fsSL https://get.docker.com | sh

Describe the results you received:
[admin@centos71bld ~]$ curl -fsSL https://get.docker.com | sh
+ sudo -E sh -c 'sleep 3; yum -y -q install docker-engine'
Error: Package: docker-engine-1.11.1-1.el7.centos.x86_64 (docker-main-repo)
           Requires: libdevmapper.so.1.02(DM_1_02_97)(64bit)
Error: Package: docker-engine-1.11.1-1.el7.centos.x86_64 (docker-main-repo)
           Requires: libsystemd.so.0()(64bit)
Error: Package: docker-engine-1.11.1-1.el7.centos.x86_64 (docker-main-repo)
           Requires: libsystemd.so.0(LIBSYSTEMD_209)(64bit)
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest
[admin@centos71bld ~]$

[admin@centos71bld ~]$ lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID: CentOS
Description:    CentOS Linux release 7.1.1503 (Core)
Release:        7.1.1503
Codename:       Core
[admin@centos71bld ~]$

Describe the results you expected:
Expected successful install.

This looks similar to https://github.com/docker/docker/issues/20484, can you check that discussion for possible clues? But I wonder why yum update didn't upgrade you to the current (7.2) version of CentOS

Thanks for getting back to me.  Yeah, I had checked that thread, but nothing I could use.  Here is the output of 'yum update':
[admin@centos71bld ~]$ lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
[admin@centos71bld ~]$ sudo yum update
Loaded plugins: fastestmirror, langpacks
cent-7u1_64                                          | 3.4 kB  00:00:00
centos-7u1                                           | 3.6 kB  00:00:00
docker-main-repo                                     | 2.9 kB  00:00:00
dsu_repository_dependent                             | 2.3 kB  00:00:00
dsu_repository_independent                           | 2.3 kB  00:00:00
Loading mirror speeds from cached hostfile
No packages marked for update
[admin@centos71bld ~]$

(I'm glad it didn't upgrade the OS; that would have been an undesirable outcome!).
The compatibility matrix lists Docker 11.1 as compatible with CentOS7.1, if I'm reading it right; so based on that matrix, I would have expected it to work.
No need to spend time on it if it's not an issue for others; for my purposes, I'll just back off the CentOS to 6.5 (which was my original purpose for looking at Docker anyway).
Cheers,
-chris

Hm, the compatibility matrix is for the CS version of Docker Engine (commercially supported), although it should be using roughly the same code base. We actually had some discussion about mentioning 7.1 / 7.2 separately, because (as we've been informed) for CentOS and RHEL, basically 7.2 does not exist; it's simply CentOS/RHEL 7, and an "up to date system" is (at this moment), 7.2.
However, I'm surprised why it works for some but not for others; it would be great if we could resolve this, or at least know what's causing it, because this is not the best user experience :blush:

@walquis Did you resolve the prolem you reported?

Sorry @JevonQ, no I haven't touched it since last June.


added Forcefield.apply assert_bonds

Thanks for the contribution!
My understand was that it's supposed to get caught earlier (see here) but I know you're dealing with topologically different systems than we were using back then. I'm a little fuzzy on this so I will let @summeraz comment.

It looks like that comment says it gets picked up in the MD engine later on.  Arguably this is a thing for foyer to spot.
Looks like this change breaks an existing test, I think you all can push to this branch to fix

Why did this PR not go through CI?

Oops, that was sloppy. We thought it was one of the tests that can fail for silly reasons, but on further inspection it's actually something we need to change. Thanks for catching this

No worries! I was just surprised that while I was working on another PR, that test started to fail. It looks like this PR was really needed, since one of the tests didn't have all the bonds defined.

Yeah, of all the things that can happen with failing units tests, finding and fixing an unrelated issue is among the better outcomes


add necessary files for publishing with github page

This PR is to add necessary files and folders for publishing the docs website with github page.

docsrc is a copy of doc with the update of Makefile (provided by Serge in pysal/pysal)
docs contains the .nojekyll file and will include locally built Html files

addressing https://github.com/pysal/submodule_template/issues/19

My pleasure. I am merging this so that I can reference the file from pysal.org


How to use editNotification()

Hi guys,
I'm sorry to post this here but I've searched everywhere and I can't find a solution.
Here's my situation. I need to pass a countdown to a notification and I don't really know how to do it. My countdown works fine in my component, however, when I send it to the notification, it only sends the value of the countdown at the moment of creating the notification.
I've checked the documentation and there's a method editNotification() that takes a UID and an updated object.
I'm using react-notification-system with react-notification-system-redux and when I want to create a notification I simply dispatch error(object) and my notification is created. However, I've checked react-notification-system-redux docs but I don't see any editNotification action.
I'd like to know how I could create an action to dispatch editNotification. I've checked the examples but I'm not sure I fully understand. I see a method _editNotification but I don't see any example calling it.
Any help would be appreciated.

I was facing almost same issue. I wanted to update notification when back-end process was done.
edit functionality is not working as expected.
I successfully updated the notification but its autoDismiss time was not getting refreshed (I mean message changed and then disappeared)
So I finally wrote the extension of react-notification-system
It probably serve your purpose. check this link
https://github.com/SheikhG1900/react-notifier-system

I created at PR to describe at least the editNotificatioǹ arguments correctly. See: https://github.com/igorprado/react-notification-system/pull/152

@alveshelio @SheikhG1900 @jpsikorra Merged #152. Sorry for the wait.


Add DenyAll and AllowAll access checkers

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
https://github.com/yiisoft/rbac/issues/85

Maybe add .styleci.yml and .phpunit-watcher.yml files?

Done