slickFilter with 2 rows isnt working.

I am trying to create a slider using slick with 2 rows but it seems like making it 2 rows and filtering it via onclick event isnt working and making the items disappear. any fixes for this bug?
Here is the jfiddle.
http://jsfiddle.net/xv1ogzkt/

Just had a quick look
(ps: in future plz dont put minified source in Fiddles :wink: hehe)
It's a pretty large oversight, the filterSlides method completely overlooks the fact there might be rows... the filterSlides method would never work with rows option in it's current implementation.
It's a bit of work, @ronieldom so if it's essential for your project, you should attempt a different solution, or a different framework for now :disappointed: - You could always have 2 carousels, and bind your own custom left/right arrows which progress both carousels simultaneously.

I have the same issue. Thanks, @simeydotme for the clear response. For now, I'll look at a different imlpementation.

@escaped : There's a problem with your patch. The filter works great but the events are unbinds.
See http://jsfiddle.net/166caxpj/ for an example with your master branch source.

Duplicate as #1924

+1

Same problem here.
After trigger filter in two rows carousel, all items disappear

I'm in that boat too, @skrzepij . But weirdly enough the example which uses ":even" as a filter does work, which makes me wonder if I'm filtering incorrectly. (I'm looking for a data attribute, so I've been trying
$("#grid-wall").slick('slickFilter', "[data-tag='blog']")

@skrzepij @egermani same boat, if you find a solution let me know. I can filter with :even but not with a selector.

Hi @kenwheeler ! Thank you for this amazing carousel !
Do you know any good workaround for using slickFilter with 2 rows?

+1

Hi @danielgarnier. Here is my workaround for this case:
`
var slider = $('.slider');
var allSlides = $('.slick-slide > div > *').clone();
var trigger = $('button');
trigger.on('click', function() {
var filterSlides = allSlides.filter('.filter-example');
slider.slick('unslick').empty().append(filterSlides).slick();
});
`

Trying to do 4 rows - it's a small gallery.
I was thinking, as a workaround for multiple filters and multiple rows, could I just say:
var filtered = false;

$('.filter-agr').click(function(e) {

  $('.gallery-page')[0].slick.refresh();

   if ($("img").not("[alt='agricultural']")){
       $("img").not("[alt='agricultural']").parent().css({'display' :'none','width':'0px'}).parent().css('float', 'left');
     $("img[alt='agricultural']").parent().css('width' , '370px').parent().parent().css('float' , 'left');

       filtered = true;
}else{
       $("img").not("[alt='agricultural']").parent().css({'display' :'block','width':'100%'}).parent().css('float', 'none');
     $("img[alt='agricultural']").parent().removeAttr('style');
       filtered = false;
}
});

codepen link: https://codepen.io/schnoodly/pen/dRzzBm
But it's an incredibly roundabout and clunky way of doing things (along with the fact I only have a few months' experience under my belt), and the largest clientside downfall is that the images stay in their separate pages.
If anyone has anymore pointers, I would love to hear them. Hopefully this helps someone.

I've recently run into this problem, and can't find any other thread except this one and https://github.com/kenwheeler/slick/issues/1924.
I seem to be having success with @escaped's patch, although I haven't thoroughly tested many case scenarios.
@apsylone, can you elaborate on what is wrong with this patch?
Any word on official support for this having filters work in grid mode?

still an issue

我今天遇到了這個問題，並創建了一個jQuery插件來處理這種情況。
也許可以幫助某人，直到過濾器支持網格模式：
https://gist.github.com/mariovalney/b6e56f061698031f1684edee43a2dc1e

Help me a lot, Thank you :DD


Fix null pointer related to server create command

Issue #514
Signed-off-by: Leif Sandstrom<EMAIL_ADDRESS>

Integrated in master (commit 6025c9bcc38b5)

Integrated in master (commit 6025c9bcc38b5)


OpenX: Adding OpenX to list of hosted Prebid Server providers

Hi, is this just a docs update?

Yep.  We're hosting our own Prebid Server and would like to be included on the list of Prebid Server hosting providers.


Add v14.0 for Autoruns on main page

Docs Build status updates of commit fb97d93:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d207903:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a90ff1b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


TS2741: Property 'manager' is missing in type '{ children: Element; }' but required in type 'ProviderProps'.

I started to follow the installation guide: https://github.com/coinbase/rest-hooks/blob/master/docs/getting-started/installation.md
At step 1, we need to add a RestProvider without props. Typescript asks to add a prop manager:

Also, when I run typescript check, I have these errors:

This is a new create-react-app project with typescript.
package.json:
{
  "dependencies": {
    "rest-hooks": "^0.7.3",
  },
  "devDependencies": {
    "typescript": "^3.3.3333"
  }
}

tsconfig.json:
{
  "extends": "./tsconfig.paths",
  "compilerOptions": {
    "target": "es5",
    "lib": [
      "dom",
      "dom.iterable",
      "esnext"
    ],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "preserve"
  },
  "include": [
    "src"
  ]
}

Thanks for the report. Will get on this! :)

Should be fixed in #b335faddc9f7c4e9fc0e7191dcba1934ebb0bd34

Fix released in https://github.com/coinbase/rest-hooks/releases/tag/0.8.0

Thank you :)


Add a DirectFormClient

The need arises to secure the /accessToken endpoint for the OAuth server support of the CAS server.

+1

PR for 1.8.x: https://github.com/pac4j/pac4j/pull/469

The PR for 1.8 must be validated in the new OAuth server support for CAS. Then, I'll issue the same for the master branch.

PR for master: https://github.com/pac4j/pac4j/pull/478


Lecture03

Implement CustomList and fixed all tests

Coverage decreased (-24.2%) to 35.922% when pulling c8692d3f8d1e2609ff709d534235e84aaeb9058e on vladfedorenko:lecture03 into 354e59d14c8207f1a4977555c3526c00fb22514d on rybalkinsd:lecture03.

Coverage increased (+2.9%) to 63.107% when pulling 35ccc1237dce964048de7919c48c835c54f26a5c on vladfedorenko:lecture03 into 354e59d14c8207f1a4977555c3526c00fb22514d on rybalkinsd:lecture03.

Coverage increased (+2.2%) to 62.381% when pulling f24c485e9aa1e3a1269cf97b11be096e39c1d2c5 on vladfedorenko:lecture03 into 354e59d14c8207f1a4977555c3526c00fb22514d on rybalkinsd:lecture03.

Принято!


Error upon importing barcode-detector/pure

Not really a big blocker but just want to let you know that when I was gonna write a custom polyfilling logic with the pure import but I got this error on build with Vite:
│ $ tsc && vite build
│ vite v5.2.11 building for production...
│ ✓ 12213 modules transformed.
│ x Build failed in 10.57s
│ error during build:
│ Error: [commonjs--resolver] Missing "./dist/es" specifier in "barcode-detector" package
│     at e (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:47597:25)
│     at n (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:47597:627)
│     at o (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:47597:1297)
│     at resolveExportsOrImports (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:48287:20)
│     at resolveDeepImport (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:48306:31)
│     at tryNodeResolve (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:48031:20)
│     at Object.resolveId (file:///Users/<redacted>/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:47781:28)
│     at file:///Users/<redacted>/node_modules/rollup/dist/es/shared/node-entry.js:19778:40
│     at async PluginDriver.hookFirstAndGetPlugin (file:///Users/<redacted>/node_modules/rollup/dist/es/shared/node-entry.js:19678:28)
│     at async resolveId (file:///Users/<redacted>/node_modules/rollup/dist/es/shared/node-entry.js:18359:26)

I am able to import barcode-detector just fine.
I have this vite.json:
{
  "$schema": "https://json.schemastore.org/tsconfig",
  "extends": "./react-library.json",
  "Display": "Vite",
  "moduleResolution": "node",
  "compilerOptions": {
    "target": "ESNext",
    "lib": ["DOM", "DOM.Iterable", "ES2020"],
    "types": ["vite/client"],
    "allowJs": false,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "module": "ESNext",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "strict": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "forceConsistentCasingInFileNames": true
  }
}

The commonjs resolver shouldn't be looking for "./dist/es". If you can provide a minimal repo to reproduce this error it would be of much help.

I'll try later today, but a quick info is that my code is a private fork of this repo: https://github.com/bigcommerce/b2b-buyer-portal

I think subpath exports are not supported by "moduleResolution": "node": https://stackoverflow.com/a/74538429 or it's very difficult to get it right. And the tsconfig documents says You probably won’t need to use node10 in modern code.. Try changing it to bundler.

Thanks, appreciate the help. I noticed that the moduleResolution is actually not even under the compilerOptions. Other import issues crop up though even if moduleResolution fixes thebarcode-detector/pure import , probably due to how it is set up, so I don't think I'll change it. In my case, the barcode-detector import already fine so I'll just use that.


Order content by date last modified?

I've searched the docs but can't find how to order content by modified date.

Ask questions at http://discuss.gohugo.io/


Deprecation of "Sponsor" object

Prerequisites

[ ] I searched to see if the issue already exists.

Description
The GitHub API is deprecating the "Sponsor" object in October. So kind of them :)
I came here as I haven't been able to work out how to use the new API and am finding it really confusing - the old approach you're using here is much easier to grok.

I thought you should know, and wondered if you'd started work on moving to the new API format?
Steps to Reproduce
This will stop working.

ah nice haha, nah I haven't looked into it yet

I've figured it out finally. They are using some kind of union which means you need a type assertion to access the data now. ... on User


Questions About Large Kuhn Poker and BUG Report

Thanks for the open-source project.  I found a bug when using the game large_kuhn_poker.py, and created a pull request in https://github.com/xiaohangt/RMDO/pull/1#issue-2279886173.
I have some questions about the details of the large Kuhn experiment in the paper. I'm trying to use your game for my work, and it would be a great help if you could answer these questions.

What are the specific rules of large kuhn poker? Two players are allowed to use more pots, but it seems that only three bets are still allowed (L139~142)
Since it cannot run, may I ask if other versions of the code were used in the paper's experiments (for example, the C++ version of kuhn poker in OpenSpiel was modified).

@TimerChen Thanks for the question.
I've read your pull request. Thanks for that. While I basically mimic the same implementation here: https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/python/games/kuhn_poker.py. Therefore:

The current_player function should be fine.
You are right about the pieces.append.

Regarding the questions:

Yes, only three bets are still allowed.
I didn't use C++ version of Kuhn Poker.


The mod causes infinite loading on the title screen.

I am sure that my client version is 3.9.0 and mod version is 1.0.0_3.9.0.
Here is the ERROR
[Error  :DrakiaXYZ-BigBrain] BigBrainPlugin: System.TypeLoadException: Could not resolve type with token 01000056 (from typeref, class/assembly AICoreStrategyAbstractClass, Assembly-CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null)
at SPT.Reflection.Patching.ModulePatch.Enable () [0x00000] in :0
at DrakiaXYZ.BigBrain.BigBrainPlugin.Awake () [0x00058] in :0
TypeLoadException: Could not resolve type with token 01000056 (from typeref, class/assembly AICoreStrategyAbstractClass, Assembly-CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null)
at SPT.Reflection.Patching.ModulePatch.Enable () [0x00000] in :0
at DrakiaXYZ.BigBrain.BigBrainPlugin.Awake () [0x00095] in :0

This can only be caused by running the wrong version of BigBrain for your version of SPT. This isn't a bug


Fix: Use same amount of left pad as .cm-line

Why
The indent markers are drawn using backgrounds on a ::before element that is placed on CodeMirror lines (.cm-line). The left offsets of the indent markers should match the left pad of the .cm-line, however there is an error in the calculation.
The left offset of the indent marker is made up of:

0.5ch that is added to the left offset of the background in createGradient
plus 2px that is set as the left value of the ::before element.

The 2px was added in #26 by @bradymadden97 to try fix the alignment but if you look closely at theme.tx#L85 the .cm-line left pad is 6px instead of 2px.
The offset of 0.5ch plus 2px is coming close, but see for example how the line under the 6 is shifting as I zoom the font size:

(Maybe zoom the first image yourself to see how far left it should be.)
This is because the size of 0.5ch depends on the font size, whereas the CodeMirror .cm-line offset is always fixed at 6 pixels.

What changed
Remove the extra 0.5ch offset from the background and change the ::before left from 2px to 6px.

Test plan
I tested using an app that uses CodeMirror. I enabled the indentation markers and then gradually increased the font size to confirm the drift.
After the PR the line stays in place when I increase the font size:

Note that the same happens in the Replit UI. It's easiest to see when choosing a Font Size of Huge in User Settings:

The red box is the cursor. It's an outline because the view does not have the focus. The grey line should align with the left of the cursor.
Maybe clearer when I modify --indent-marker-bg-color in devtools:

Compare with a Font Size of Small:


fix separator not visible issue

This PR fixes #15885
in this commit: https://github.com/microsoft/vscode/commit/7c3f60f86e6776c4a339c23f85fd9a11c3424bbb#diff-addd7132dee13457b17c0ce8af86416722108e69b8a60d63a865f524a8323f5fR19
the align-items property of the toolbar container is changed to 'center' from default value 'stretch', this caused the height of our task separator to become 0 (not visible).
fix: set it to stretch specifically for the separator to fit the container.

Pull Request Test Coverage Report for Build 965761667

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.976%

Totals

Change from base Build 963349969:
0.0%

Covered Lines:
26333

Relevant Lines:
55640

💛  - Coveralls


Finish k-sigs/promo-tools documentation

This issue tracks the completion of the release documentation. Mainly it monitors the sections in RELEASE.md:

[ ] Validation/Canaries
[ ] Drafting release notes
[ ] Drafting a GitHub release
[x] https://github.com/kubernetes-sigs/promo-tools/pull/592
[ ] Publishing
[ ] Rollout
[ ] Announce

/kind documentation
/area release-engineering
/sig release
/cc @kubernetes-sigs/release-engineering

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/lifecycle frozen


Same validation metric values across collaborators in Jupyter notebooks

Describe the bug
When launching the federated training in Jupyter notebooks of openfl-tutorials folder, I noticed that different collaborators achieve the same validation metric values. That could be possible if collaborators had the same data, but the data is randomly split. Looks like there is an issue of defining the Data Loader for each collaborator.
To Reproduce
Steps to reproduce the behavior:

Open openfl-tutorials/Federated_PyTorch_UNET_Tutorial.ipynb in Jupyter.
Execute all cells.

Expected behavior
Collaborators have different metrics due to random data split.
Screenshot

Parallel collaborator execution implies an absence of protobuf classes instances in parallelized code because fork processes cannot pickle such objects. Output:
_pickle.PicklingError: Can't pickle <class 'federation_pb2.ModelProto'>: import of module 'federation_pb2' failed

@aleksandr-mokrov suggested that we will operate with pure Python entities (dictionaries) instead of protobuf-created ones. I am reworking client-server interaction to use google.protobuf.json_format.MessageToDict protobuf entities conversion.


governance: fixes and test for cancelation

We need to answer on question: how to change checking?
I see at least 3 variants:

nobody has voted for the proposal
voting hasn't been started yet
the proposal hasn't been queued yet


Main Person - > Bakkal/ Grocer

Main Person / Owner-Tenant>
We may use “Bakkal/ Grocer” rather than Main Person

It should be displayed on the website in the following manner:
Bakkal/ Grocer
Name:
Religion:
Status:
Type of ownership:


DateTimeField does not work as a componentClass (react-bootstrap 0.29.0)

With the latest version of react-bootstrap, components are now initialised as a componentClass of the new FormControl component (see https://react-bootstrap.github.io/components.html#forms).  For example this datepicker would be:
<FormGroup controlId="formDate" validationState={myDate.error}>
    <ControlLabel>Date</ControlLabel>
    <FormControl componentClass={DateTimeField} mode={'date'} format={'DD/MM/YYYY'} inputFormat={'DD/MM/YYYY'} placeholder="Please select a date" {...myDate} />
    <FormControl.Feedback />
    <HelpBlock>This would be a date picker</HelpBlock>
  </FormGroup>

Currently it does not work.

react-bootstrap is not a dependency of this project, while they can work together, they are not interdependent.
What you can do is make you own wrapper around react-bootstrap-datetimepicker that would use the react-bootstrap API and render a DateTimePicker, I don't see anywhere that componentClass can take a ReactComponent though, it seems to be only string

@chollier If you look at https://github.com/react-bootstrap/react-bootstrap/blob/ae48d58afc2bcfcc36cabec136bba33929387513/src/FormControl.js for example acts like a higher order component where componentClass takes any react component, or a valid element string (since React will just render them, it's just JSX)
However I get your point they aren't interdependent so I'll try see if I can figure it out why it's just not returning the DateTimeField inside the wrapper (which provides validation state, etc)


Feature Request: Add singularity images to .gitignore

Hello,
Can you add this to the .gitignore that is automatically generated by wfpm:
# Singularity images
**/*.img
**/*.sif

Cheers,
Andrej

addressed by #53


Missing Information

This article is missing a lot of steps of how to set up the linker configuration file.
Specifically it's missing:

Any required naming of the file
Required/default location of the file (or how to set a custom location)
Valid values to use within the file
Links to any existing documentation that may explain these missing pieces

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f76b85eb-e640-6751-7eb2-fc58676d6018
Version Independent ID: 422c639a-104a-4e31-cc78-03c023dd05ab
Content: Custom Linker Configuration - Xamarin
Content Source: docs/cross-platform/deploy-test/linker.md
Product: xamarin
Technology: xamarin-crossplatform
GitHub Login: @asb3993
Microsoft Alias: amburns

I share the frustration, there's missing info on linking and also this specific section for the Custom Linker Configuration. Linking is a complex thing and there should be a tutorial for the basic scenarios - take a third party SDK, put it in your Xamarin app - how to link it properly? For instance, a native XXX.framework for iOS

Thanks for filing an issue on this!
Much of this documentation comes directly from the Mono IL Linker where you can also read up on here:
https://github.com/mono/linker/blob/master/src/linker/README.md
and additionally the Linker Analyzer tool:
https://github.com/mono/linker/blob/master/src/analyzer/README.md
There are additional examples and explanations here:
https://github.com/mono/linker#link-xml-file-examples
Regarding these questions:
Any required naming of the file
Unless stated, there should not be any required naming. The Build Action set is the indicator that this file should be used within the linker at MSBuild time.
Required/default location of the file (or how to set a custom location)
We recommend the default location within the head project (iOS/Android) root as per the docs.
Valid values to use within the file
We can probably add the XML file example above into this doc if it's more helpful!
Links to any existing documentation that may explain these missing pieces
We can also add links to these mono repository readmes and CLI reference (i.e. https://linux.die.net/man/1/monolinker)
Finally, Blazor also uses the same linker and links to similar documentation. Is there anything else on this page we can help make our custom linking page more clear with?
https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/blazor/configure-linker?view=aspnetcore-3.1#control-linking-with-a-configuration-file
Custom linking is quite an advanced scenario & I'd love to better understand how we can improve this documentation!

also another alternative solution for those who want linking and have issues with the default linking configurations is this: https://docs.microsoft.com/en-us/xamarin/android/deploy-test/linker#falseflag


[Event Request] Codeunit 5912 - ServLedgEntries-Post - Call to OnCreateCreditEntryOnBeforeServLedgEntryInsert also before first Insert

Dear ALAppExtensions team,
Through this issue we would like to request event publisher OnCreateCreditEntryOnBeforeServLedgEntryInsert also to be called for the first insert in CreateCreditEntry:
            case ServDocType of
                DATABASE::"Service Shipment Header", DATABASE::"Service Header":
                    begin
                        case ServLine.Type of
                            ServLine.Type::Item:
                                Type := Type::Item;
                            ServLine.Type::Resource:
                                Type := Type::Resource;
                            ServLine.Type::Cost:
                                Type := Type::"Service Cost";
                            ServLine.Type::"G/L Account":
                                Type := Type::"G/L Account";
                        end;
                        "No." := ServLine."No.";
                        "Entry Type" := "Entry Type"::Sale;
                        "Document Line No." := ServLine."Line No.";
                        "Amount (LCY)" := -ServLine.Amount;
                        Quantity := -ServLine.Quantity;
                        "Charged Qty." := -ServLine."Qty. to Invoice";
                        "Discount Amount" := -ServLine."Line Discount Amount";
                        "Unit Cost" := -GetRefinedUnitCost(ServLine);
                        "Cost Amount" := -Round("Unit Cost" * ServLine.Quantity);
                        "Discount %" := -ServLine."Line Discount %";
                        "Unit Price" :=
                          Round(
                            -("Amount (LCY)" + "Discount Amount") / Quantity, Currency."Unit-Amount Rounding Precision");
                        "Gen. Bus. Posting Group" := ServLine."Gen. Bus. Posting Group";
                        "Gen. Prod. Posting Group" := ServLine."Gen. Prod. Posting Group";
                        Open := false;
                        Description := ServLine.Description;
                        OnCreateCreditEntryOnBeforeServLedgEntryInsert(ServLedgEntry, ServHeader, ServLine); // << EVENT CALL HERE AS WELL
                        Insert;

                        NextServLedgerEntryNo += 1;
                        "Entry No." := NextServLedgerEntryNo;
                        "Document Type" := "Document Type"::"Credit Memo";
                        "Entry Type" := "Entry Type"::Sale;
                        "Document Line No." := ServLine."Line No.";
                        "Amount (LCY)" := ServLine.Amount;
                        if ServHeader."Currency Code" <> '' then
                            Amount := AmountToFCY(ServHeader, "Amount (LCY)")
                        else
                            Amount := "Amount (LCY)";
                        Quantity := ServLine.Quantity;
                        "Charged Qty." := ServLine."Qty. to Invoice";
                        "Discount Amount" := ServLine."Line Discount Amount";
                        "Unit Cost" := GetRefinedUnitCost(ServLine);
                        "Cost Amount" := Round("Unit Cost" * ServLine.Quantity);
                        "Discount %" := ServLine."Line Discount %";
                        "Unit Price" :=
                          Round(
                            ("Amount (LCY)" + "Discount Amount") / Quantity, Currency."Unit-Amount Rounding Precision");
                        Description := ServLine.Description;
                        OnCreateCreditEntryOnBeforeServLedgEntryInsertFromServiceHeader(ServLedgEntry, ServHeader, ServLine);
                        Insert;

                        NextServLedgerEntryNo += 1;
                    end;

(A different event call would also work)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


support for vacuum cleaner would be nice

I realy like your work. and i use it for every device.
but i hava also a smart vacuum cleaner and the support for it would be realy nice

Vacuum devices are tricky because they really need to support a bunch of traits that means the user must provide a lot of state
e.g.

docked
location
different profiles/programs

https://developers.home.google.com/cloud-to-cloud/guides/vacuum
But I'll try and have another look


Handle cases when it get's invalid

At present the retrieval script marks handles invalid but they don't delete the submissions from the submission table for the previously valid handle.

Hi @raj454raj , can you explain the problem little more? (my understanding is - if a user first gives a valid handle, all his submissions get recorded under table submission. Afterward, he changes it to some other handle then the previous submissions under that handle name needs to be deleted from 'submission' table).

So for example: https://www.stopstalk.com/user/profile/tanujkhattar
The current codeforces handle of the user is tanujkhattar.
Now this handle is invalid because the user has changed it to Baba and hence we made an entry in invalid_handle table for tanujkhattar. At this point in submission retrieval, we also need to delete the codeforces submissions with previously valid handle.


Add new test machines to infrastructure

I have created two new linux x64 machines for use by the general testing jobs.
They are hosted at Softlayer with hoistname, IP address, and logins as follows:
  test-softlayer-ubuntu1604-x64-1
  <IP_ADDRESS>
  root/********

and
   test-softlayer-rhel7-x64-1
   <IP_ADDRESS>
   root/********

These machines need configuring with Ansible, adding to Nagios and Jenkins etc to be made available for test.
Heads-up to @smlambert when they are done.

Created pull request #248 to add these systems to the Ansible inventory

To do List:

[ ] Add systems to Keybox
[ ] Update keybox's profile 'root_test_machines' to include these systems
[ ] Create pull request to add these systems to the Ansible inventory file
[ ] Create new entries in secrets gpg
[ ] Refresh Ansible dynamic inventory
[ ] Execute Playbook on these systems

Running playbook now - AWX job number 20839

playbook failed... need to investigate

test-softlayer-ubuntu1604-x64-1 looks good
 test-softlayer-rhel7-x64-1 Failure in playbook due to vendor being offline
The sourceforge.net website is temporarily in static offline mode. Only a very limited set of project pages are available until the main website returns to service.

We are still working around the clock to restore full capacity to SourceForge. We do not have an ETA yet but we will update here when we do. We appreciate your patience. Thank you.

Manually installed/configured ant-contrib, re running play 20940

@bblondin we can always store files in https://ci.adoptopenjdk.net/userContent/


bind: fix build on machines where glibc does not provide L1 cache size

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 163854 run on x86_64-linux 1

2 packages blacklisted:

tests.nixos-functions.nixos-test
tests.nixos-functions.nixosTest-test

31 packages failed to build:

acme-sh
autofs5
bashSnippets
bind
blueberry
check-wmiplus
cinnamon.cinnamon-common
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cinnamon-session
cinnamon.cjs
cinnamon.nemo
cinnamon.pix
cinnamon.warpinator
cinnamon.xapps
cinnamon.xreader
cinnamon.xviewer
dig (dnsutils)
dwm-status
host
inxi
monitoring-plugins
nmapsi4
python310Packages.xapp
python39Packages.xapp
sssd
tests.trivial-builders.references
testssl
twa
xed-editor
xplayer

Result of nixpkgs-review pr 163854 run on aarch64-linux 1

26 packages failed to build:

acme-sh
autofs5
bashSnippets
bind
blueberry
cinnamon.cinnamon-common
cinnamon.cinnamon-screensaver
cinnamon.cinnamon-session
cinnamon.cjs
cinnamon.nemo
cinnamon.pix
cinnamon.warpinator
cinnamon.xapps
cinnamon.xreader
cinnamon.xviewer
dig (dnsutils)
dwm-status
host
inxi
monitoring-plugins
python310Packages.xapp
python39Packages.xapp
sssd
twa
xed-editor
xplayer

Result of nixpkgs-review pr 163854 run on aarch64-linux 1
26 packages failed to build:

Are you building via qemu-user or real harware?

this was built using qemu

Closing as not longer needed due to https://github.com/NixOS/nixpkgs/pull/164586


PDF Viewer: Single page UX

Item Display Problems
Single page view in the PDF viewer on Item pages is currently not great. There are a few things happening:
1: Single page items show the item small and floating with lots of space below it

2: Multipage items cut off weirdly only showing part of the item or shows partial pages.
Example A:

Example B:

Double Scrollbar
These displays are causing a double scroll bar experience on the right side of the item page. It's not as cool as a double rainbow. It's whatever the opposite of that experience is.

Desired solution
Height-wise, I'd like the item to display in the same way as the two page view does -- the whole item contained in the available space, using the buttons to page through it instead of scrolling. I'm less concerned about full screen view, where we expect people to zoom and scroll, but the item page is the showcase of the item -- it needs to look good and feel good to use.

This is looking so much better but I am still seeing some critical issues. If possible, I would like to see these items fixed:
Issue 1: Page display changes are carrying over between items
Right now if I change from single to two page spread page view on an item and then move to a different item, it looks like the new item retains the settings I changed on the previous item. This is not desirable. Setting changes on an item should not affect anything other than the item you are on currently.
Video example:
https://github.com/ucd-library/dams/assets/17831969/ef32549e-651f-4720-83b1-594e837c190c
Issue 2: Previous item is displaying when opening new item page
When moving between items, the previous item shows before the new one loads. This is potentially confusing for a user, who may click out before the load finishes if they see the wrong item. It is better to have it be blank or to have a loading spinner than to show incorrect data on load. You can see this happen in the video I posted above.
Issue 3: Bottom of item pages are cropped/missing on mobile
On mobile, we're consistently losing the bottom portion of the pages (on my iphone at least, haven't checked android), so there may need to be a bit of tweaking there still on sizing. Here are some examples:

Example 1
Example 2


Modify the model with new materials and textures

Could it be done done in Godot or we need to do it in Blender where the original model was created?
A texture is an image or pattern only, whereas a material is a collection of information that defines an object’s color, shininess, transparency, and bumpiness. (https://all3dp.com/2/blender-how-to-add-a-texture/)

We have the 3D models from Blender in:
12:39 $ du -sh 3d_models/*
864K	3d_models/mob.blend
932K	3d_models/player.blend

and they have been exported to GLB format from Blender also:
12:39 $ du -sh dodge_the_creeps_3d/art/player.glb*
52K	dodge_the_creeps_3d/art/player.glb
32K	dodge_the_creeps_3d/art/player.glb.import

It is the models in glTF format:
«
glTF (derivative short form of Graphics Language Transmission Format or GL Transmission Format)

is a standard file format for three-dimensional scenes and models
A glTF file uses one of two possible file extensions: .gltf (JSON/ASCII) or .glb (binary).
Both .gltf and .glb files may reference external binary and texture resources. Alternatively, both formats may be self-contained by directly
An open standard developed and maintained by the [Khronos Group] (https://en.wikipedia.org/wiki/Khronos_Group),
»

So it is a transmission format, so maybe, the models could be modified later.

In order to play with materials in Godot there is a cool demo that can be loaded in Godot to play with: https://godotengine.org/asset-library/asset/123

So as a conclusion, we can modify the material and textures in Godot, which is great because probably, we can change them during the game.
But I am pretty sure that in Blender we should do the initial creation of materials with their textures.
And it is time to explore one of the projects that I want to look at in the past months: https://www.materialmaker.org/
«
Material Maker is a procedural PBR (Physically Based Rendering) materials authoring tool, based on the Godot Engine.
Materials are defined as graphs where nodes create or transform textures, and can be exported for the Godot, Unity and Unreal game engines.
There are more than 200 available nodes, and new nodes can be created either by connecting and grouping existing nodes, or by describing them in GLSL.
»
Materials are defined as graphs where nodes create or transform textures
So you have textures to work with and inside material maker you can transform them. And the nodes are implemented using GLSL (OpenGL Shading Language) the principal shading language for OpenGL, which I have used already in the past in MagicaVoxrels. So, really col!

I should read more about PBX but I am not sure it is the alternative to follow to work with textures. To generate textures, it seems to be the reference. But, do we need to generate textures? Or just reuse already created ones?

Blender has a great collection of textures: https://cloud.blender.org/p/textures/

Ok, done a quick test with Godot:

Our new ship has a military green color with a texture that is a kind of camouflage. Good enough for this try.

I will stop investing time in this issue now, but for sure I will continue researching in materials and textures, now with a more solid knowledge base.

Interesting PBR intro: https://cgcookie.com/lessons/pbr-introduction
«Physically based is the new standard for creating materials. Instead of relying on diffuse and specular components separately, PBR shaders work with roughness and real reflections. To create most any opaque material, you'll just need to adjust four settings:
Roughness
Fresnel
Metalness
Displacement

»


Doesn t work  - error log.

Traceback (most recent call last):
  File "Moriarty.py", line 175, in <module>
    MP.run()
  File "Moriarty.py", line 145, in run
    self.spamcalls_()
  File "Moriarty.py", line 122, in spamcalls_
    spamcalls().spamcallsStart(self.phoneNumber)
  File "/home/andrejki/Moriarty-Project/DeepInfo/risks.py", line 8, in __init__
    display=Display(visible=0,size=(1024, 768))
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/display.py", line 54, in __init__
    self._obj = cls(
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/xvfb.py", line 44, in __init__
    AbstractDisplay.__init__(
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/abstractdisplay.py", line 85, in __init__
    helptext = get_helptext(program)
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/util.py", line 13, in get_helptext
    p = subprocess.Popen(
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'

Hi, this is the error. Thank you kindly for this, but it just doesn t work?
Best regards

Traceback (most recent call last):
  File "Moriarty.py", line 175, in <module>
    MP.run()
  File "Moriarty.py", line 145, in run
    self.spamcalls_()
  File "Moriarty.py", line 122, in spamcalls_
    spamcalls().spamcallsStart(self.phoneNumber)
  File "/home/andrejki/Moriarty-Project/DeepInfo/risks.py", line 8, in __init__
    display=Display(visible=0,size=(1024, 768))
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/display.py", line 54, in __init__
    self._obj = cls(
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/xvfb.py", line 44, in __init__
    AbstractDisplay.__init__(
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/abstractdisplay.py", line 85, in __init__
    helptext = get_helptext(program)
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/util.py", line 13, in get_helptext
    p = subprocess.Popen(
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'

Hi, this is the error. Thank you kindly for this, but it just doesn t work? Best regards

I faced the same. Just install the pip: sudo apt-get install xvfb

Not working.
Traceback (most recent call last):
File "/opt/osint-numbersearch/./Moriarty.py", line 175, in
MP.run()
File "/opt/osint-numbersearch/./Moriarty.py", line 145, in run
self.spamcalls_()
File "/opt/osint-numbersearch/./Moriarty.py", line 122, in spamcalls_
spamcalls().spamcallsStart(self.phoneNumber)
File "/opt/osint-numbersearch/DeepInfo/risks.py", line 10, in init
self.driver=uc.Chrome(options=options,version_main=f.read())
File "/usr/local/lib/python3.10/dist-packages/undetected_chromedriver/init.py", line 401, in init
super(Chrome, self).init(
File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/chrome/webdriver.py", line 69, in init
super().init(DesiredCapabilities.CHROME['browserName'], "goog",
File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/chromium/webdriver.py", line 92, in init
super().init(
File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/remote/webdriver.py", line 277, in init
self.start_session(capabilities, browser_profile)
File "/usr/local/lib/python3.10/dist-packages/undetected_chromedriver/init.py", line 589, in start_session
super(selenium.webdriver.chrome.webdriver.WebDriver, self).start_session(
File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/remote/webdriver.py", line 370, in start_session
response = self.execute(Command.NEW_SESSION, parameters)
File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/remote/webdriver.py", line 435, in execute
self.error_handler.check_response(response)
File "/usr/local/lib/python3.10/dist-packages/selenium/webdriver/remote/errorhandler.py", line 247, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: unknown error: cannot connect to chrome at <IP_ADDRESS>:48727
from chrome not reachable

Traceback (most recent call last):
  File "Moriarty.py", line 175, in <module>
    MP.run()
  File "Moriarty.py", line 145, in run
    self.spamcalls_()
  File "Moriarty.py", line 122, in spamcalls_
    spamcalls().spamcallsStart(self.phoneNumber)
  File "/home/andrejki/Moriarty-Project/DeepInfo/risks.py", line 8, in __init__
    display=Display(visible=0,size=(1024, 768))
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/display.py", line 54, in __init__
    self._obj = cls(
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/xvfb.py", line 44, in __init__
    AbstractDisplay.__init__(
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/abstractdisplay.py", line 85, in __init__
    helptext = get_helptext(program)
  File "/home/andrejki/.local/lib/python3.8/site-packages/pyvirtualdisplay/util.py", line 13, in get_helptext
    p = subprocess.Popen(
  File "/usr/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'Xvfb'

Hi, this is the error. Thank you kindly for this, but it just doesn t work? Best regards

I faced the same. Just install the package: sudo apt-get install xvfb

Thanks, but not helpful, did that, nothing.
The hotmail account is valid and the password.
I guess it just doesn t want to work.
Traceback (most recent call last):

 File "Moriarty.py", line 175, in <module>
   MP.run()
 File "Moriarty.py", line 145, in run
   self.spamcalls_()
 File "Moriarty.py", line 122, in spamcalls_
   spamcalls().spamcallsStart(self.phoneNumber)
 File "/home/andrejki/Moriarty-Project/DeepInfo/risks.py", line 10, in __init__
   self.driver=uc.Chrome(options=options,version_main=f.read())
 File "/home/andrejki/.local/lib/python3.8/site-packages/undetected_chromedriver/__init__.py", line 233, in __init__
   patcher.auto()
 File "/home/andrejki/.local/lib/python3.8/site-packages/undetected_chromedriver/patcher.py", line 127, in auto
   release = self.fetch_release_number()
 File "/home/andrejki/.local/lib/python3.8/site-packages/undetected_chromedriver/patcher.py", line 148, in fetch_release_number
   return LooseVersion(urlopen(self.url_repo + path).read().decode())
 File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
   return opener.open(url, data, timeout)
 File "/usr/lib/python3.8/urllib/request.py", line 531, in open
   response = meth(req, response)
 File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
   response = self.parent.error(
 File "/usr/lib/python3.8/urllib/request.py", line 569, in error
   return self._call_chain(*args)
 File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
   result = func(*args)
 File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
   raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

Experiencing the same issue in Kali 2020.1. I have Chromium v103.0.5060.134 installed.

after adding the additional --no-sandbox arguments I was able to fix the chrome unreachable error.
Fix unreachable chrome issue
	def startChrome(self):
		try:
			f=open("Moriarty/c_Version.moriarty","r")
			options = uc.ChromeOptions()
			options.add_argument("--no-sandbox")
			options.add_argument(version_main=f.read())
			self.driver=uc.Chrome(options=options, delay=30)
		except FileNotFoundError:
			os.system("cd Moriarty && bash c_V.sh && cd ..")
			f=open("Moriarty/c_Version.moriarty","r")
			self.driver=uc.Chrome(options=options, delay=30)

But now getting the following error below.
 And I'll remove cli usage. Everything will be on web.
Note :  This project doesn't work currently

@AzizKpln spent the last 2 hours trying to figure out what I was doing wrong. I guess we just have to wait now.

Hi, the project is updated. You can use it without receiving errors now.
Tested OS: Parrot Linux, Kali Linux


./mvnw clean install gets stuck

Hello! Congrats on the book. Looking forward to diving into it.
Running ./mvnw clean install  the code gets stuck on test Running com.packtpub.beam.chapter4.SportTrackerMotivationUsingOwnJoinTest. I have run the test directly and it works. Any idea how I can solve this? Thanks.

By the way, I needed to change the version of Lombok to 1.18.20 regarding this issue: https://github.com/projectlombok/lombok/issues/2790

Hello! Congrats on the book. Looking forward to diving into it.
Running ./mvnw clean install  the code gets stuck on test Running com.packtpub.beam.chapter4.SportTrackerMotivationUsingOwnJoinTest. I have run the test directly and it works. Any idea how I can solve this? Thanks.

By the way, I needed to change the version of Lombok to 1.18.20 regarding this issue: projectlombok/lombok#2790

Hi, I think that is low memory or low cpu , I had the same problem but in my case I was using minikube, I had forgotten to set the arguments --memory and --cpu on 'minikube start'

Thank you for the solution @vitorfranklin. Closing the issue for now.


x11-docker to use latest desktops like gnome3 or others

Hi
I've just tested x11docker with lxde, with
./x11docker --desktop --size 1920x1080 --xorg --gpu --vt 4 x11docker/lxde --home
unfortunately, in this image, I found no way of sudoing and install packages.
A really cool application would be to switch between several desktop distros and test the latest ones with all gpu acceleration, and home dir shared. This is like  https://github.com/ustuehler/lxc-desktop (which unfortunately doesn't work for me in xenial)
I wouldn't really care about security. This seems like a very cool application.

Hi,

I found no way of sudoing and install packages.

You can use option --sudouser (needs sudo in image, but that misses in x11docker/lxde) or --user=root to get root privileges in container.
As all installed packages get lost this way, I prefer to customize the dockerfile. For example, you can create a dockerfile with some desired extra packages:
FROM x11docker/lxde
RUN apt-get update
RUN apt-get install -y firefox-esr synaptic sudo

Build with docker build -t mylxde - < mydockerfile and run x11docker --desktop mylxde.

use latest desktops like gnome3 or others

Currently I am trying out several desktop environments for x11docker. New images already on docker hub are x11docker/mate and x11docker/lxqt.
Just now I am working on x11docker/trinity and will publish it this evening.
Unfortunately, Gnome 3 and related desktops like Cinnamon, Budgie and Pantheon still refuse to work in docker images. I am not sure about the core reasons, maybe some systemd/logind dependencies that won't work in a container. I will give it some more tries, it would be cool to have Gnome 3 and Cinnamon in a container.
As a quite new desktop in development, you may like Liri: https://hub.docker.com/r/lirios/unstable/
It does not work with x11docker yet, but I will figure that out. The description on docker hub shows how to run it on host display.

and home dir shared.

You mean your "real" home dir? You can set --homedir=$HOME to share it.

x11docker has new options --systemd and --runit to run init systems in container.
This makes it possible to run desktop environments that need some daemon services in background.
Examples:
For systemd:  Cinnamon on fedora 27: x11docker/cinnamon
x11docker --systemd --desktop --gpu x11docker/cinnamon

For runit: latest Enlightenment 0.22 on Void Linux: x11docker/enlightenment
x11docker --runit --desktop --gpu x11docker/enlightenment

x11docker supports two new desktop environments.
One is deepin from dde, the leading desktop environment in china:
x11docker --desktop --systemd --sys-admin --pulseaudio --gpu x11docker/deepin

The other one is liri-shell from LiriOS:
x11docker --desktop --gpu lirios/unstable

Meanwhile I've created several images containing a desktop environment: https://hub.docker.com/u/x11docker/
Gnome 3 and its forks Budgie and Pantheon are still missing. There seems to be serious bugs in gnome-shell and libmutter causing segfaults regardless what I try to adjust.
I will give it another try with the next major Gnome 3 update.

@mviereck Did you try to run GNOME3 with working dbus/systemd as used here for snapd?

Did you try to run GNOME3 with working dbus/systemd as used here for snapd?

Yes, I did. x11docker provides a similar setup with --init=systemd. I also tried with quite reduced container isolation. e.g. --cap-add=ALL --ipc=host --net=host. Maybe I've missed --security-opt seccomp:unconfined.

I found a GNOME docker repository and updated it: Dockerfile-Ubuntu-Gnome. It runs GNOME in a VNC server (which is probably harder than using a X server directly).
Starting some components in xstartup works:
gnome-panel &
gnome-settings-daemon &
metacity &
nautilus &
gnome-terminal &

Unfortunately, the full gnome-session or gnome-shell does not work out of the box.

I found a GNOME docker repository and updated it: Dockerfile-Ubuntu-Gnome.

The commands in xstartup just sets up parts of a Gnome 2 environment. I'd say that mate desktop is a better choice for this attempt.

Unfortunately, the full gnome-session or gnome-shell does not work out of the box.

Yes, I failed to run them, too. Sometimes I find a segfault of libmutter in dmesg.
I even get segfaults if I try to run gnome-shell from host in custom X server setups.
Try e.g. x11docker --desktop --exe gnome-shell and have a look at dmesg afterwards.
My last attempts to get gnome-shell running have been in April '19. Maybe I'll try next year again. Same issues occur with pantheon and budgie, forks of Gnome 3. Only Cinnamon, an early fork, works well. Compare #147
I'd like to get Gnome 3 running in a container, but I am skeptic. It seems to be too buggy.

Did you see this tutorial?
They use a VNC server (but without docker) on Ubuntu 18.04.

Did you try the setup? I don't see any Gnome 3 specific configuration and doubt that it will work. I see the screenshots, but it might be just some luck that it did not crash.

I tested it on my laptop (without docker) and it worked as described in the tutorial. There were some conflicts with daemons/indicators (like Seafile, Nextcloud) started multiple times though...

Thank you for insisting and investigating!
I seems that some serious bugs in libmutter are fixed. In some tests I was able to run gnome-shell from host in e.g. Xephyr similar to the tigervnc setup. This failed about a year ago.
I found one X configuration in x11docker that still caused Gnome 3 segfaults. Gnome 3 crashes if X extension X-Resource is not enabled.
I've enabled X-Resource in the latest commit and now gnome-shell runs in container!
Example:
FROM debian:buster
RUN apt-get update
RUN apt-get install -y --no-install-recommends gnome-shell
CMD gnome-shell --sm-disable

x11docker --desktop --gpu --init=systemd -- gnomeimage

PS: I filed an upstream bug.

It seems there is no general issue that prevents gnome-shell in container.
But the segfault if running X with disabled extension X-Resource is worth a bug report.

I get segfaults e.g. running gnome-control-center. Seriously? Segfaults in a config dialog?
The keyboard layout does not match my host system. Gnome overwrites the settings done by x11docker. But I cannot change it because gnome-control-centersegfaults. Sigh.
gnome-usage segfaults, too, if looking at RAM usage.

Thank you so much for your investigation! Your example is working out of the box for me!

It seems there is no general issue that prevents gnome-shell in container.
But the segfault if running X with disabled extension X-Resource is worth a bug report.

Maybe you can submit it upstream since you discovered it? This should be the corresponding project location.

I get segfaults e.g. running gnome-control-center. Seriously? Segfaults in a config dialog?
The keyboard layout does not match my host system. Gnome overwrites the settings done by x11docker. But I cannot change it because gnome-control-center segfaults. Sigh.
gnome-usage segfaults, too, if looking at RAM usage.

I did some further tests (see below) and also noticed that control center does not work. I think we should create bugs upstream here as well.

I got Ubuntu with GNOME 3 in VNC within Docker running as well finally!!! I experienced similar problems too.
I use ubuntu-desktop instead of gnome-shell but some parts are not working like the sidebar or gdm3 (see Known issues section in my README.md).

 (The fork seems to have less issues than the original ...). Budgie also needs --init=systemd.

Thanks for your work! It would be nice if you add builds on hub.docker.com as well :innocent:

Thanks for your work! It would be nice if you add builds on hub.docker.com as well.

I'll do that at least for budgie.
I am hesitating with Gnome 3 because of the remaining issues. I don't want to provide an image with segfaulting applications. Before that it would need bugreports to Gnome developers and fixes to at least for gnome-control-center.
I'll give pantheon some trials, too.

However, this will take a bit of time, I have some other projects in RL yet.
I'll close here for now. If you make some progress on the Gnome issues or open further Gnome bug tickets, please let me know.

If you make some progress on the Gnome issues or open further Gnome bug tickets, please let me know.

List of upstream bug reports

gnome-shell
mutter
gnome-control-center

If you make some progress on the Gnome issues or open further Gnome bug tickets, please let me know.

I created the following upstream bugs:

gnome-shell
mutter
gnome-control-center

The solution for the GNOME apps (gnome-control-center and gnome-usage) is to install and use gnome-session instead of gnome-shell.

The solution for the GNOME apps (gnome-control-center and gnome-usage) is to install and use gnome-session instead of gnome-shell.

gnome-session fails to run in container. The messages do not really help. Running gnome-session --debug shows:
 Unable to init server: Could not connect: Connection refused

** (gnome-session-failed:818): WARNING **: 18:20:57.916: Cannot open display:

But why?  gnome-shell does not have issues to access the display. Running X without access restrictions (x11docker option --no-auth) does not help either.

Could you please add your segfault to gnome-control-center bug? I could only reproduce the assertion failure

I cannot reproduce the segfault, sorry. Probably I confused it with the segfault of gnome-usage.

I've fixed a possible issue: x11docker now runs systemctl --user start dbus. Otherwise systemctl --user status dbus shows an inactive state. But this did not help.

In my VNC version, I start the session via dbus-launch --exit-with-session gnome-session.

Some more information about my VNC setup: I start the docker container with /sbin/init, have a systemd service which starts TigerVNC, which has a xstartup file which launches dbus-launch --exit-with-session gnome-session.
While testing a bit with x11docker, I got some errors because of invalid container names (when passing a command containing a slash like /sbin/init as command). You should replace all invalid characters by a valid character like _.

I am currently trying your VNC setup. A build with gnome-shell gnome-terminal only gave me a black screen, but at least gnome-session did not terminate itself. Currently rebuilding with the full Ubuntu desktop without changing anything.
I'll compare your VNC setup with my x11docker setup to find the key difference.

While testing a bit with x11docker, I got some errors because of invalid container names (when passing a command containing a slash like /sbin/init as command). You should replace all invalid characters by a valid character like _.

Thanks! Is fixed now.

A build with gnome-shell gnome-terminal only gave me a black screen, but at least gnome-session did not terminate itself.
I forgot to change the comment. It's updated now in the repo: gnome-session instead of gnome-shell and remove the gdm3 modification.

I'll compare your VNC setup with my x11docker setup to find the key difference.

I don't know what your --init=sytemd does, but my container starts up it's own dbus/systemd system. I guess your setup reuses the host one.

I forgot to change the comment. It's updated now in the repo: gnome-session instead of gnome-shell and remove the gdm3 config modification.

Now it sort of works. I have published an experimental Gnome 3 Dockerfile and a Gnome 3 image on Docker hub.
Some issues remain. Most annoying:

gnome-session terminates after a few minutes and leaves gnome-shell alone. A script in the image supervises this to avoid a sudden termination of x11docker.
logout and shutdown do not work. The image provides a script and a launcher to trigger a shutdown by x11docker.

I don't know what your --init=sytemd does, but my container starts up it's own dbus/systemd system. I guess your setup reuses the host one.

x11docker does a similar setup with --init=systemd  as your VNC setup running systemd in container.

Now it sort of works. I have published an experimental Gnome 3 Dockerfile and a Gnome 3 image on Docker hub.

Thanks for your work :+1:

gnome-session terminates after a few minutes and leaves gnome-shell alone. A script in the image supervises this to avoid a sudden termination of x11docker.

My Ubuntu desktop works in VNC for several days now.

logout and shutdown do not work. The image provides a script and a launcher to trigger a shutdown by x11docker.

I have the same problem in my VNC setup.

My Ubuntu desktop works in VNC for several days now.

You could check pstree  or ps aux | grep gnome.  I give a bet that you don't have gnome-session anymore but gnome-shell only.

You should update your README on Docker hub since gnome-usage works (if you would include it in your Dockerfile)

You could check pstree or ps aux | grep gnome. I give a bet that you don't have gnome-session anymore but gnome-shell only.

Wrong. Starting with CMD [ "dbus-launch", "--exit-with-session", "gnome-session" ] works for me. Even logout terminates the container!
This is my working Dockerfile:
FROM ubuntu:19.10

ENV container docker
ENV DEBIAN_FRONTEND noninteractive

# Install locale
ENV LANG C.UTF-8
ENV LC_ALL C.UTF-8
RUN apt-get update && apt-get install -y --no-install-recommends \
    locales && \
    echo "$LANG UTF-8" >> /etc/locale.gen && \
    locale-gen && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/*

# Install systemd
RUN apt-get update && apt-get install -y \
    dbus dbus-x11 systemd && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/*

# Install GNOME 3
RUN apt-get update \
  && apt-get install -y --no-install-recommends gnome-session gnome-control-center gnome-terminal gnome-usage \
  && apt-get clean \
  && rm -rf /var/lib/apt/lists/*

CMD [ "dbus-launch", "--exit-with-session", "gnome-session" ]

Running with
x11docker --desktop --gpu --init=systemd -- gnome

You should update your README on Docker hub since gnome-usage works (if you would include it in your Dockerfile)

gnome-usage crashes if you click the "Storage" tab. That happens with the ubuntu image as well.

Wrong. Starting with CMD [ "dbus-launch", "--exit-with-session", "gnome-session" ] works for me.

Indeed. gnome-session seems to be stable in the ubuntu image, but not in the debian image. I wonder why.

Even logout terminates the container!

Indeed, great! I don't see know why there is a difference between ubuntu and debian. I should change my image to ubuntu base.
If you still have the logout issue in your VNC setup, you could check your dbus user service with systemctl --user status  dbus. Previously it showed inactive in x11docker, Now x11docker executes systemctl --user start  dbus before running the final command. Maybe that makes a difference.
BTW: With x11docker --init=systemd  you don't need dbus-launch. x11docker runs the image command with dbus-run-session if started with --init=systemd. That does basically the same.

If you still have the logout issue in your VNC setup, you could check your dbus user service with systemctl --user status dbus. Previously it showed inactive in x11docker, Now x11docker executes systemctl --user start dbus before running the final command. Maybe that makes a difference.

It is running in my setup. I guess I should take some time and make a concept which behavior I want. Should logout really close the session and stop the VNC server? Maybe it would be better to somehow forward this request to close the VNC session but keep the server running.

In gnome-control-center I have issues with three tabs: "Sharing", "Power" and "Details". It takes some time until something is shown. Until then the dialog does not response to anything, frozen until some timeout. Maybe some issue with the hostnamed systemd service. Do you have the same issue in your VNC setup?

Indeed I have the same problem in my VNC setup. Your idea about hostnamed seems plausible since at least Sharing and Details/About want to display the hostname.
BTW:
You should also add your Budgie Dockerfile to hub.docker.com :wink:

Your repository https://github.com/darkdragon-001/Dockerfile-Ubuntu-Gnome does not have a possibility to open issue tickets. Is that intended?

Since it started as a fork, it used the settings from upstream. I updated the settings to support issues now.

 --cap-add SYS_ADMIN: You should not add this capability, it is much too powerful. It was needed for early systemd setups in container, but not anymore with recent versions of systemd.
--cap-add SYS_BOOT: I suggest this to allow logout / shutdown of systemd.
--security-opt apparmor:unconfined: Should not be needed.
-it -d: -i, --interactive and -d, --detached are an either-or decision. Use only one of them.

Thanks for your information! I updated my README.


Long Producer Reconnect Time on Local Kafka

Description
When a producer is disconnected from a broker, reconnect takes several seconds leading to a high latency for the first message sent to a disconnected broker.
How to reproduce
/// Setup:
/// - Windows 10 Pro, 12 cores.
/// - kafka_2.12-2.3.0.
/// - Set connections.max.idle.ms=60000 in kafka server.properties.
/// - Start both zookeeper and kafka on the local machine.
/// - Create a 32 partition topic: .\kafka-topics.bat --create --topic 32-part-topic-test --partitions 32 --bootstrap-server localhost:9092 --replication-factor 1
/// - Run the program and observe that the DeliveryHandler isn't called for several seconds.
///   (See final log message. Ex: [Information] [2020-09-08 08:09:41.925] Success. ElapsedMs: 5405)
kafka_reconnect_log.txt
ConsoleApp1.zip
Checklist
Please provide the following information:

[x] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[x] Confluent.Kafka nuget version.
v1.4.3
[x] Apache Kafka version.
kafka_2.12-2.3.0
[x] Client configuration.
[x] Operating system.
[x] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

are you running kafka in docker?
does setting your bootstrap servers to <IP_ADDRESS>:9092 resolve this?
for some reason there's a transport failure on localhost:9092.
looking quickly, i'm not sure what's up but seems network related.
note: you should not run kafka itself directly on windows - it's not tested and there's definitely a bug when it tries to roll segment files that will cause it to crash.

@mhowlett I can no longer reproduce - I think something was up with the machine I was running on. For first time connect to a broker it is taking ~300 ms pretty reliably (mentioned here as well https://github.com/confluentinc/confluent-kafka-dotnet/issues/1305#issuecomment-640860377) . Is this normal?


namespace collision

OpenAI also uses the command openai in their implementation:
https://github.com/openai/openai-python
So one cannot use your script and OpenAI's implementation, but must choose one or the other.

Thank you for this information. I'll take care of that 👍


Use type inference during type definition, customizable validation messages

I added the following features in this PR:

use type inference during type definition

roughly implemented only for classes (fields, super-class) and functions (parameters)
this shows the importance of supporting delayed type definitions, since some parts of LOX would need a topological sorting regarding the customization order

enable Typir users to customize details of validation messages (e.g. see the LOX example for the operator ==)
adapted the conversion API to a proposal of Markus
refactorings

Thanks @insafuhrmann for your review!


⚠ ClamAV has degraded performance

In b452729, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 651 ms

Resolved: ClamAV performance has improved in 57d5abe.


Mailgun doesn't send emails but no errors too

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Similar Mailgun issue to https://github.com/fastlane/fastlane/issues/8568
In mac terminal running following command sends an email.
curl -s --user 'api:key-xxxx' https://api.mailgun.net/v3/sandboxxxxx.mailgun.org/messages -F from='Mailgun Sandbox<EMAIL_ADDRESS>-F to='Umut<EMAIL_ADDRESS>-F subject='Hello Umut' -F text='Congratulations Umut, you just sent an email with Mailgun!  You are truly awesome!'

In fast file running following does nothing, to  email address is verified in Mailgun

      mailgun(postmaster: "https://api.mailgun.net/v3/sandboxxxxxxx.mailgun.org/messages",
        apikey: "key-1283d1761422369594e5c5db309b90d7",
        to: "Umut<EMAIL_ADDRESS>        from: "Mailgun Sandbox<EMAIL_ADDRESS>        app_link: "https://www.google.com",
        subject: "Hey",
        message: "Successfully deployed new App Update.",
        success: true
        )

[INSERT OUTPUT HERE]
+------+---------------------------------------------------------------+-------------+
|                                  fastlane summary                                  |
+------+---------------------------------------------------------------+-------------+
| Step | Action                                                        | Time (in s) |
+------+---------------------------------------------------------------+-------------+
| 1    | Verifying required fastlane version                           | 0           |
| 2    | default_platform                                              | 0           |
| 3    | /usr/libexec/plistbuddy -c 'Set CFBundleVersion -1' '../Hugin | 0           |
| 4    | /usr/libexec/plistbuddy -c 'Set CFBundleShortVersionString 0. | 0           |
| 5    | mailgun                                                       | 1           |
+------+---------------------------------------------------------------+-------------+

[13:47:55]: fastlane.tools finished successfully 🎉

So I assume this would work, debugging mailgun.rb in fastlane adding puts I see
  def self.mailgunit(options)
        sandbox_domain = options[:postmaster].split("@").last
        puts sandbox_domain
        params = {
          from: "#{options[:from]}<#{options[:postmaster]}>",
          to: (options[:to]).to_s,
          subject: options[:subject],
          html: mail_template(options)
        }
        puts params

output:
{:from=>"Mailgun Sandbox <postmaster@sandboxxxx.mailgun.org><https://api.mailgun.net/v3/sandboxxxx.mailgun.org/messages>", :to=>

So it seems wrong however changing it to from: "<#{options[:postmaster]}>" didnt help either.
Also this line too in mailgun.rb throws me off
 RestClient.post<EMAIL_ADDRESS>params
Isnt this supposed to be ?
https://api.mailgun.net/v3/#{sandbox_domain}/messages
So I tried RestClient.post " https://api.mailgun.net/v3/sandboxxxxx.mailgun.org/messages" ,params and I got a 401 error.
What to do here? Why my emails are not making it to Mailgun Server?
I don't see any requests in Mailgun dashboard logs, besides the one that I made thru terminal
@thiagofelix

After I had to use deprecated methods to be able to send an email thru Mailgun. I suck at ruby but I will make a pull request.
for now this works
    ENV['MAILGUN_SANDBOX_POSTMASTER'] =<EMAIL_ADDRESS>    ENV['MAILGUN_APIKEY'] = 'key-1xxxxxxxxxxx7'
    ENV['MAILGUN_APP_LINK'] = 'https://www.google.com'

    mailgun(to<EMAIL_ADDRESS>        from: "Ugenlik",
        subject: "Fastlane Beta",
        message: "App is successfully deployed to Hockey App.",
        success: true
     )

smae problem for me. i can send through Curl, but not in fastlane


Change img Drag

Hi, is possible to change the drag img?
Code:
img id="test" data-drag="true" jqyoui-draggable="{animate:false, placeholder: 'keep', onStart:'dragCallback(item.order, $index)'}" ng-model="list1" data-jqyoui-options="{revert: 'invalid', helper: 'clone'}" src="img/surgeonGame/icon_forbici.png"
when i start to drag the img, i need to chage this img with another img...
thanks.

@izzusan83: You can use helper option and pass a function to mutate the cloned draggable. More info:
http://api.jqueryui.com/draggable/#option-helper

hum, is possible to have a example?
because there is just this:
-helper: "clone"
I need to change clone image with a big image.

It also takes a function wherein you could modify the dragged image. I do
not have an example with me but you will get plenty on google.
On May 4, 2015 12:45 PM, "izzusan83"<EMAIL_ADDRESS>wrote:

hum, is possible to have a example?
because there is just this:
-helper: "clone"
I need to change clone image with a big image.
--
Reply to this email directly or view it on GitHub
https://github.com/codef0rmer/angular-dragdrop/issues/180#issuecomment-98605384
.

sorry I misspelled :)
I need to change the clone image...

I solved,
you need use onStart.

@izzusan83: Glad you found a solution..!


feat: Using lucia instead of next auth

Describe the feature you'd like to request
Lucia has recently published several guides on implementing authentication beyond web, including one for Expo.  Since Lucia also supports Electron, I think using Lucia instead of Next Auth aligns well with the project goals, which aim to demonstrate the use of the T3 stack in a monorepo with multiple apps.
Describe the solution you'd like to see
Here is a link to the guides
https://preview.lucia-auth.com/guidebook/github-oauth-native/expo/
https://preview.lucia-auth.com/guidebook/github-oauth-native/electron/
Additional information
I would love to help with implementation if you decide to give it a shot :)

+1
Lucia is less opinionated than Next Auth, true it has more setup but with that comes so much more flexibility. Even as a set-up option for those who want that while still retaining Next Auth for people who prefer that as an option I don't see impossible to do.

I wasn't too keen on Lucia when I tried it but if there is a clean implementation maybe? They are using namespaces for module augmentation though which isn't too monorepo friendly - I opened an issue and they might change it to ES module syntax in the next major.
I had an implementation for NextAuth on Expo a while back but paused and waited for v5 and integration in authjs core - but the development over there has been slow so it's taking longer than anticipated...

Out of curiosity, @juliusmarminge  was there something in particular (other than the namespaces issue) that made you 'not too keen'?

Back then i thought the abstractions were a bit weird and didnt see any added value over using NextAuth, but I've been using it in a project now and it's growing on me.
I think we might have to raise the issue in create-t3-app first though so we dont drift out of "the t3 stack" too much in this repo

I think next-auth is still the better option for ct3 app. The lucia use case is much more relevant on this repo. But, it has been a while since I last used ct3 app, so if the cli now allows you to choose between providers, then it would make sense to consider it there first.

Got a pretty clean next-auth solution going in #720

Looked at the PR, looks amazing ! Thank you so so much ! Will this be authjs retrocompatible?

Looked at the PR, looks amazing ! Thank you so so much ! Will this be authjs retrocompatible?

This repo is already using authjs :)

Is there a better step by step next auth implementation for react native and tauri Js

but I feel the main problem is with implementing Apple auth with custom flow


Add TagNoteMap implementation

Description
Implementing the Association Class between Note and Tag objects. This should allow us to create Tags and Notes that are mapped to one another but aren't tightly coupled. For now, there's a 1 way association as Notes need to contain a list of tags. This is used to initialise the TagNoteMap.
Fixes #
Testing
None yet, currently empty methods auto-generated by intellij exist
Remarks
Here's my understanding of what to implement:

we want to keep track of the associations b/w notes and tags. TagNoteMap this should be done, left with the initialisations for the diff lists and the map.

Done: Implement Maps, Setters and Getters
Done:  fix initialisation methods

Notes shall contain a set of Tags objects. Therefore, initialising the TagNoteMap object should be done by enumerating through all notes.

Done: Add Set of Tags to Note object. current implementation makes tags optional and we can add in tag by tag only.
Done: Initialise the TagNoteMap.

ClientNotes: get all Clients from  AddressBook#setClients(), enumerate through their ClientNotes to add to TagNoteMap
Pending: CountryNotes: get all Countries from _____(how?), enumerate through their CountryNotes and add to TagNoteMap

Need to update the Parser, specifically the ClientNoteAddCommandParser such that it can have access to TagNoteMap when the parser gets initialised.

For this I have to add a getter for TagNoteMap higher up the hierarchy at LogicManager
I get my map from the model, so model & modelManager is updated with a getter for TagNoteMap as well

Questions/Issues being looked into now

working on the Notes containing and the initialisation of TagNoteMap now (point 2)

Add any additional remarks for others to take note of.

build is failing because country notes getters were removed by recent pull request. have communicated w rayson and willl be adding getter from CountryManager accordingly

Codecov Report

Merging #150 into master will decrease coverage by 1.94%.
The diff coverage is 12.28%.

@@             Coverage Diff              @@
##             master     #150      +/-   ##
============================================
- Coverage     70.99%   69.04%   -1.95%
- Complexity      519      521       +2
============================================
  Files            90       91       +1
  Lines          1665     1722      +57
  Branches        171      177       +6
============================================
+ Hits           1182     1189       +7
- Misses          421      471      +50
  Partials         62       62

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/model/AddressBook.java
94.87% <ø> (ø)
15.00 <0.00> (ø)

...va/seedu/address/model/country/CountryManager.java
71.42% <0.00%> (-7.52%)
9.00 <0.00> (ø)

...main/java/seedu/address/model/note/TagNoteMap.java
10.86% <10.86%> (ø)
2.00 <2.00> (?)

src/main/java/seedu/address/model/note/Note.java
52.94% <20.00%> (-13.73%)
4.00 <1.00> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
93.93% <25.00%> (-4.45%)
28.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f134aa5...fc58d7e. Read the comment docs.

Quite a few TODOs and stray comments. I think a follow-up issue can be created to cleanup the todos and stray comments.
Just wondering, what is the main purpose of having TagNoteMap class? Is it so that it would be easier to query for notes based on a given set of Tags? Because it seems like additional work to "sync" tags with notes and it might be quite error-prone if the syncing is not done right. Any thoughts @qwoprocks ?

for the comments & TODOs: I'll add an issue for this and resolve it as I'm doing the delete, update and storage aspects
for the purpose behind this class:

I'll let @qwoprocks reply to that (this will help verify if the original motivation behind it is being met by this PR also). Regardless, I've written the purpose in the attached issue and this PR's description.

Quite a few TODOs and stray comments. I think a follow-up issue can be created to cleanup the todos and stray comments.
Just wondering, what is the main purpose of having TagNoteMap class? Is it so that it would be easier to query for notes based on a given set of Tags? Because it seems like additional work to "sync" tags with notes and it might be quite error-prone if the syncing is not done right. Any thoughts @qwoprocks ?

@raysonkoh actually the implementation @rtshkmr did was a bit off from what I had in mind, the tagnotemap is actually supposed to be the one being passed down from logic manager to the parser to create the tags, so there would no need to do the syncing stuff. @rtshkmr isit alright if i just push to this PR and implement that?


updating create app links

Description

Updating create app links to use templates

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.34.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature Improvements] Gitignore file update

We should have a gitignore file to protect from unwanted file push on GitHub.

added gitignore file

Completed


translate-cloak not cloaking

I am seeing a flash of the translation key before it is asynchronously replaced.  I have tried translate-cloak but it doesn't seem to be working.  Any thought?
Thanks and this module is very much appreciated!

+1 - same issue here.

Could you please elaborate this a bit more?
What did you have tried? What is your configuration? Can you show a working example of non-working?

Just as a side note to extend the question: Where is translate-cloak set / attached? On a div element or on the body element?

Ok, fixed it... sort of. Let me clarify:
I've added it to the body-tag and added the translate-cloak class (opacity: 0). That works fine... The initlal page loads without flickering! But when I use ngRoute to display another part of the page (SinglePageApplication), then the new part (new controller) will NOT show the translated elements as the translatFinishedEvent (or whatever that event is called) is not being triggered (I guess).
I've changed the translate-cloak CSS class to use "background-color: red", and now I can see that when the whole page loads... everythings is cool and cloaking works (no red parts on the page). As soon as I click on my link (that loads "/#/" (so actually the same page(!), but with ngRoute => SinglePageApplication)) the translate cloak class does not get removed (so every translated text stays red in this case!)! So I guess I have to pass the translateprovider to each controller so that SPA works, am I right?
In short: translate-cloak works, but as soon as I use ngRoute to replace a section of the page (with a new controller), the controller view's translate-cloak classes do not get removed.
Regards,
Sascha

+1 to @mastix , couldn't have said it better myself.  Although.. it is in the initial page load load and not an ngRoute redirect.
The problem I am seeing is that ngCloak isn't working at all.  I see the translation key flicker, then it loads the strings properly.  ngCloak has no effect.
Isn't the body not to be shown until the strings are loaded?  I know this will create an initial delay for the user but we can cache later.

Are you using the partial loader?

is it ngCloak we are now talking about or just and only translate-cloak? :-)

You are right @tspaeth, I meant translate-cloak.
I am not using a partial loader for the initial page being loaded (login) and that is where the issue is more apparent.

So does one of you @mastix or @itonics-tbeauvais have a plunker or similar as a full test case?

Running at the end of the Sprint, I will have to add one in a day or two.

Hi, I also see this issue. And I see the exact same as @mastix: On initial load everything is fine, but when loaded with ngRoute (/#/), the translation keys are visible. Are there any good workarounds in the maintime?

translate-cloak doesn't work for me, since, in a way, it is implemented incorrectly, I'm wondering why it's not implemented by analogy with a native ng-cloak directive. The problem with the current implementation is that if some text needs to be translated and it resides e.g. in index.html, then in this case translation keys will not be hidden until angular is initialized and translate-cloak can come into play. In fact this directive should have been implemented as a native one, so that you can add the translate-cloak to target elements as a class rather than as an attribute. In this case it would have worked properly. At the moment, in order to make it work I need to add both the translate-cloak class and the translate-cloak attribute. The simplest solution to that issue would be just allow to declare the translate-cloak directive as a class.

Here here!  Any update?

At the moment, in order to make it work I need to add both the translate-cloak class and the translate-cloak attribute. The simplest solution to that issue would be just allow to declare the translate-cloak directive as a class.

I don't understand the issue. But yes, the attribute way should work too. Perhaps we had missed the default (because there is actually NO restriction, although it is documented).
As you can see here: http://plnkr.co/edit/PTVj8vBMFRl4UmHp8uTM?p=preview

Single attribute works
Explicit key in attribute works
however: class does not work

Speaking of making the thing easier, it would be a good improvement allowing class directives.
But that (class attribute) is actually not the topic of this issue.
The problem with this issue is: nobody has made a working example (proof of concept). I'm running a larger SPA with ui-route without these problems and we could not understand the problem. After a while we close stale issues.
So, well. However, it is correct that the directive on instantiation is not looking for the state of translations. And yes, it is correct that a $translate.refresh() will invoke implicitly an event which will solve this problem". At least as a workaround, this is fine. This issue is a bug and will be addressed..

fyi: #1175 in canary resolved.


fix: raw key Typescript return type

Fixes the raw return on Typescript types
Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included (not sure if the index.ts is considered a benchmark)
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Related issue: https://github.com/fastify/fluent-json-schema/issues/129

@aboutlo I added a new schema on the type's index.ts, but not sure if it's needed and if I used it correctly, what I tried to do was basically add a new "test" to show that the required key is valid independent of it's position

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.559%

Totals

Change from base Build 994617246:
0%

Covered Lines:
410

Relevant Lines:
410

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on required-json-schema at 99.559%

Totals

Change from base Build 994617246:
99.6%

Covered Lines:
410

Relevant Lines:
410

💛  - Coveralls


No late initialize for container NodePool's node_count and initial_node_count

Description of your changes
In the gcp terraform provider there are two ways to configure the size of NodePools:

initial_node_count specifies the initial size of the node pool, allowing the pool size to be controlled by the cluster autoscaler (or other tooling);
node_count explicitly configures the size of the node pool, allowing TF to manage the size of the pool.

You cannot specify both when creating a node pool, but this is not (currently) validated by the TF provider when updating an existing node pool.
At present provider-gcp late initializes both properties, resulting in a spec with both values set. Not only would this not be valid for creating a new node pool, but in the case where the user explicitly set only the initial size the late initialization causes the provider to attempt to manage the ongoing size of the node pool as if the user had set node_count too, resulting in fights with the GKE cluster autoscaler, etc.
While this can be worked around by disabling LateInitialize in the managementPolicy, the current behaviour is undesirable and surprising to users as it effectively removes the distinction between the two ways to specify pool size.
The TF docs also warn that the initial_node_count reported can change if node pools are resized, and suggests using a lifecycle block to ignore changes.
This PR removes both node_count and intial_node_count from late initialization, and ignores changes to the initial_node_count field.
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Note: The TF provider calculates current node_count as int(instances / AZs), so when testing it's necessary to resize the node pool by at least the number of AZs or the provider will not detect the change!

Create new node pool with initial_node_count, resize via the console, provider does nothing.
Create new node pool with node_count, resize via the console, provider resets to specified size.

/test-examples="examples/container/v1beta2/nodepool.yaml'

test-examples="examples/container/v1beta2/nodepool.yaml"

/test-examples="examples/container/v1beta2/nodepool.yaml"

We can ignore the failed Uptest- job on this PR. It was due to a typo in the comment I made (now deleted).


[rviz_rendering] Unnecessary information in ogre log messages

Ogre logs are redirected using rviz_rendering::ogre_rendering.cpp.
Currently, every log output generated by this class also includes the path to the ogre_rendering.cpp class.
Example:
[rviz_common:info] Creating resource group General, at /home/greimela/projects/ros2/rviz2_ws/src/aos-rviz2-public/rviz_rendering/src/rviz_rendering/ogre_logging.cpp:80
[rviz_common:info] Creating resource group OgreInternal, at /home/greimela/projects/ros2/rviz2_ws/src/aos-rviz2-public/rviz_rendering/src/rviz_rendering/ogre_logging.cpp:80
[rviz_common:info] Creating resource group OgreAutodetect, at /home/greimela/projects/ros2/rviz2_ws/src/aos-rviz2-public/rviz_rendering/src/rviz_rendering/ogre_logging.cpp:80
...

As far as I can tell Ogre does not provide information such as file name or line number in the Ogre::LogListener.
So we should just remove the path from the log message in this case.

Yeah, unfortunately the logging API I setup doesn't allow you to not specify the file and line number. I don't think we want to just exclude it because other instances of the log messages have meaningful files and line numbers in them, it's only the Ogre ones that don't and the ogre log messages which are being piped through this API don't provide the original file and line number.


Suggestions to improve step 7 of the getting started doc section

After successfully completing the "getting started" section described in the doc, I'd like to share some feedback with you guys on step 7, as I had to struggle a bit. Some simple changes might help future folks quite a bit.

There is no such thing as "my.registry.com". Now I know it's just a placeholder, but it wasn't apparent. This is especially important because the acorn login command does not report login failure, as I don't think it actually logs you in, making it impossible to know a good registry/credential combo from bad.
It would have been great to spell out the commonly used registry URLs (ghcr.io is mentioned in acorn login --help but not in the docs, docker.io is not mentioned, I had to guess after failing with hub.docker.com)
Different repo has different rules on tagging (I think). For example the docker.io repo would need the user name as part of the tag, so acorn/getting-started wouldn't work.

In any case, hope the above is helpful to you guys. And since I had it, let me also share with you an error message I had to ponder with. To you guys the cause of the problem might look obvious, but for someone not intimately familiar with the Kubernetes/docker world (which I think would be your target users), this might not be as easy to troubleshoot, especially when they have followed the docs to the letter.
$ acorn push my.registry.com/acorn/getting-started:v0.0.1
Error: Post "https://kubernetes.docker.internal:6443/apis/api.acorn.io/v1/namespaces/acorn/images/my.registry.com+acorn+getting-started:v0.0.1/push": stream error: stream ID 71; INTERNAL_ERROR; received from peer

Thanks @stevel032. This is good feedback. I particularly agree with not using "my.registry.com". We'll get that updated.
@iwilltry42 can you update this doc to use a real registry? We are using ghcr.io in a lot of places, so might as well use that.

While we are on this subject, does it seem odd to you guys that the acorn login will actually not do the logging in operation, and thus never report any failure?

Yes; https://github.com/acorn-io/acorn/issues/324

docs updated


[API] spelling: encrypt

Split from #3459 as @kroeckx identified that it's complicated
This will require some work/discussion

This bug is due to an error in the RFC: https://tools.ietf.org/html/rfc2633 and thus fixing it would involve talking to IETF. For now, this clearly won't be going anywhere here. I'll see about poking IETF...

Abandoning this as any progress will first require IETF to do something.


Align closer to gruvbox base16 highlighting

First off, I would like to say thanks for working on this project!  I have really enjoyed the theme!
I have been a longtime user of the following colorscheme:
https://github.com/chriskempson/base16-vim/blob/master/colors/base16-gruvbox-dark-soft.vim
After switching to your theme, I noticed some differences with the treesitter syntax highlighting.  The base16 highlighting seemed to have a bit more variety in highlighting some of the elements with different colors, specifically the this keyword within TypeScript.
I have attached a handful of images below to demonstrate the differences.
base16 gruvbox dark soft

gruvbox-flat as-is

gruvbox-flat to-be

One thing to note about my color selections within the PR is that I pulled them from https://github.com/morhetz/gruvbox for orange2 and aqua.  I think they fit alright with your theme, but if you're using a flat calculation to find a new representation, then I can adjust them as you see fit.
Thanks again and interested to hear your thoughts!

This now looks like a mergeable PR. 🙏🏾


istio: Update to 1.5.4

Update to Istio release 1.5.4 fixes:

CVE-2020-10739: By sending a specially crafted packet, an attacker could trigger a Null Pointer Exception resulting in a Denial of Service. This could be sent to the ingress gateway or a sidecar. This is conditional on Istio being configured with Istio telemetry V2 enabled.

Istio integration has been updated to Istio release 1.5.4

test-me-please

Coverage decreased (-0.03%) to 37.093% when pulling 2038a7040bf9823af89f462beffb020ff55969fb on pr/jrajahalme/istio-1.5.4 into 454eae136e7f5e4ba25b0901646bb87c70aa6ca0 on master.

test-me-please

Hit by #11512

retest-4.9

retest-runtime

test-me-please

Hit by #11560

Hit by #10763

test-me-please

Known flake on running the privileged unit tests in the 4.9 CI.


Refactor SingleSubst format determination

I had to look up what a for...else... loop meant. It's really not obvious. This is hopefully a bit easier to follow.

I had to look up what a for...else... loop meant

I had to look up what a for...else... loop meant

I just read the else as if it's written ifnobreak

The rationale of "let's refactor because it's using a Python feature I haven't seen before" is rather dubious.
It's an arbitrary change that perhaps makes it better for you, perhaps not for others. It's completely siubjective, and therefore better left alone.

perhaps makes it better for you, perhaps not for others

fair point. I actually had to read this several times to convince myself it was doing the same thing as before the patch.