cnvkit.py target antitarget do not run in parallel

Hi I just realized that the Sample-target.bed and Sample-antitarget.bed in cnvkit do not run in parallel, but one sample at once in a ipython run.
Am I doing something wrong? or this is the standard behavior?
Thanks a lot!
[2018-02-20T18:26Z] ls11: export TMPDIR=./work/bcbiotx/tmpoMpC3w && /bcbio/anaconda/bin/cnvkit.py target ./work/bedprep/cleaned-MMRF_1223_4_BM_CD138pos_T1_KHS5U_L11073-variant_regions.quantized-vrsubset-callableblocks.bed --split -o ./work/bcbiotx/tmpoMpC3w/MMRF_1223_2_PB_Whole_C3_KBS5U_L05821-target.bed --avg-size 250
[2018-02-20T18:27Z] ls11: export TMPDIR=./work/bcbiotx/tmpwcysJW && /bcbio/anaconda/bin/cnvkit.py antitarget -g ./work/regions/MMRF_1223_1-analysis_blocks.bed ./work/bedprep/cleaned-MMRF_1223_4_BM_CD138pos_T1_KHS5U_L11073-variant_regions.quantized-vrsubset-callableblocks.bed -o ./work/bcbiotx/tmpwcysJW/MMRF_1223_2_PB_Whole_C3_KBS5U_L05821-antitarget.bed --avg-size 1000000
[2018-02-20T18:27Z] ls11: export TMPDIR=./work/bcbiotx/tmp5oHetH && /bcbio/anaconda/bin/cnvkit.py target ./work/bedprep/cleaned-MMRF_1817_1_PB_Whole_C3_KBS5U_L05568-variant_regions.quantized-vrsubset-callableblocks.bed --split -o ./work/bcbiotx/tmp5oHetH/MMRF_1817_1_PB_Whole_C3_KBS5U_L05568-target.bed --avg-size 250
[2018-02-20T18:28Z] ls11: export TMPDIR=./work/bcbiotx/tmpwv5mlh && /bcbio/anaconda/bin/cnvkit.py antitarget -g ./work/regions/MMRF_1817-analysis_blocks.bed ./work/bedprep/cleaned-MMRF_1817_1_PB_Whole_C3_KBS5U_L05568-variant_regions.quantized-vrsubset-callableblocks.bed -o ./work/bcbiotx/tmpwv5mlh/MMRF_1817_1_PB_Whole_C3_KBS5U_L05568-antitarget.bed --avg-size 1000000
[2018-02-20T18:29Z] ls11: export TMPDIR=./work/bcbiotx/tmpvWAEVw && /bcbio/anaconda/bin/cnvkit.py target ./work/bedprep/cleaned-MMRF_1817_1_PB_Whole_C3_KBS5U_L05568-variant_regions.quantized-vrsubset-callableblocks.bed --split -o ./work/bcbiotx/tmpvWAEVw/MMRF_1817_1_BM_CD138pos_T1_KBS5U_L05541-target.bed --avg-size 250
[2018-02-20T18:30Z] ls11: export TMPDIR=./work/bcbiotx/tmpYFXGtp && /bcbio/anaconda/bin/cnvkit.py antitarget -g ./work/regions/MMRF_1817-analysis_blocks.bed ./work/bedprep/cleaned-MMRF_1817_1_PB_Whole_C3_KBS5U_L05568-variant_regions.quantized-vrsubset-callableblocks.bed -o ./work/bcbiotx/tmpYFXGtp/MMRF_1817_1_BM_CD138pos_T1_KBS5U_L05541-antitarget.bed --avg-size 1000000

Thanks for the question. These steps are not parallelized across multiple machines so that the binning process uses consistent sizes across batched samples. The steps are pretty quick; it looks like in your case they take a minute or less each. As a result we haven't though to complicate things by having separate size estimation and parallelization but leave it all happening in one process. Please let us know if you're running into any bottlenecks and happy to reevaluate.

Thanks for your reply. I have a quite large batch (2000 sample). My first ideas was to split Tumor normal pair in set of 100 pairs.  Since cnvkit now use a background generated from all samples I decided to start a run with all samples together.... so the 1 minute is summing up ;) (and I did not see that coming).
May I ask your opinion on this?
Thanks!
Sent from my iPhone

On Feb 20, 2018, at 2:58 PM, Brad Chapman<EMAIL_ADDRESS>wrote:
Thanks for the question. These steps are not parallelized across multiple machines so that the binning process uses consistent sizes across batched samples. The steps are pretty quick; it looks like in your case they take a minute or less each. As a result we haven't though to complicate things by having separate size estimation and parallelization but leave it all happening in one process. Please let us know if you're running into any bottlenecks and happy to reevaluate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for following up with more details about your setup. Practically, I'd suggest using the smaller batches rather than trying to put these all together. A hundred sample pairs together would give you a reasonable background for the samples. We haven't done a ton of testing with larger batch sizes like that and I think you'll run into additional bottlenecks both with ipython scaling and CNVkit steps. We're working on enabling these larger runs with the move to CWL and hopefully will have more and better scaling in the future.

Thanks a lot! I have change the setup as you suggested.
Sent from my iPhone

On Feb 21, 2018, at 10:59 AM, Brad Chapman<EMAIL_ADDRESS>wrote:
Thanks for following up with more details about your setup. Practically, I'd suggest using the smaller batches rather than trying to put these all together. A hundred sample pairs together would give you a reasonable background for the samples. We haven't done a ton of testing with larger batch sizes like that and I think you'll run into additional bottlenecks both with ipython scaling and CNVkit steps. We're working on enabling these larger runs with the move to CWL and hopefully will have more and better scaling in the future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Brad, I do not understand exactly how the ipython cluster is configured, but I am just wondering if would not be possible to downsize the number of engine node during the cnvkit input preparation. I just see all these Idle CPUs...
I definitely understand that this is not a priority and the CWL workflow will sort these things out.
Thanks a lot!
with profile.report("callable regions", dirs):
samples = run_parallel("prep_samples", [samples])
samples = run_parallel("postprocess_alignment", samples)
samples = run_parallel("combine_sample_regions", [samples])
samples = run_parallel("calculate_sv_bins", [samples])
samples = run_parallel("calculate_sv_coverage", samples)
samples = run_parallel("normalize_sv_coverage", [samples])
samples = region.clean_sample_data(samples)
Sent from my iPhone

On Feb 21, 2018, at 11:30 AM, Alessandro Pastore<EMAIL_ADDRESS>wrote:
Thanks a lot! I have change the setup as you suggested.
Sent from my iPhone

On Feb 21, 2018, at 10:59 AM, Brad Chapman<EMAIL_ADDRESS>wrote:
Thanks for following up with more details about your setup. Practically, I'd suggest using the smaller batches rather than trying to put these all together. A hundred sample pairs together would give you a reasonable background for the samples. We haven't done a ton of testing with larger batch sizes like that and I think you'll run into additional bottlenecks both with ipython scaling and CNVkit steps. We're working on enabling these larger runs with the move to CWL and hopefully will have more and better scaling in the future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the suggestion, this is something we tackle better in CWL since each step is it's own submission to the cluster and will use exactly the resources it needs. In the current implementation we don't have the ability to resize the cluster on demand for different steps that require everything bundled together since we use a static IPython setup for the full process. This has pluses and minuses: the advantage is that you can keep the allocated cores you have on a busy cluster for the remaining steps, the downside is that they're idle during steps that do not distribute out over the samples. Sorry this is not optimal for your needs now but hope this explains the design reasoning and future improvements.

Sure thanks!
Sent from my iPhone

On Feb 22, 2018, at 6:42 AM, Brad Chapman<EMAIL_ADDRESS>wrote:
Thanks for the suggestion, this is something we tackle better in CWL since each step is it's own submission to the cluster and will use exactly the resources it needs. In the current implementation we don't have the ability to resize the cluster on demand for different steps that require everything bundled together since we use a static IPython setup for the full process. This has pluses and minuses: the advantage is that you can keep the allocated cores you have on a busy cluster for the remaining steps, the downside is that they're idle during steps that do not distribute out over the samples. Sorry this is not optimal for your needs now but hope this explains the design reasoning and future improvements.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks, Brad's answer still holds, so closing.


transparent background in pictures for collages

Is your feature request related to a problem? Please describe.
Images that are loaded into the collage have a black background. This is annoying if the images in the collage overlap.
Describe the solution you'd like
I would like these to be transparent.
Describe alternatives you've considered
possible solution:

in file -> photobooth-app/photobooth/services/mediaprocessing/collage_pipelinestages.py
find line 31
change -> canvas.paste(_image, (_definition.pos_x - offset_x, _definition.pos_y - offset_y))
to -> canvas.paste(_image, (_definition.pos_x - offset_x, _definition.pos_y - offset_y),_image)

Additional context
Add any other context or screenshots about the feature request here.

I'm not 100% sure what is happening to the image.
Is it possible to post a screenshot here showing the problem?

Version 1.2.1 is released including a fix. Thx for reporting!


[Feature Request] Executre Obsidian commands

There's a core plujgin-slash command-when we press slash (/) can invokes a Obsidian command to execute.
But in Chinese/Japanese/Korean environment, these commands replaced by language strings, and there are hard to input. For example, "/pin" changed to "/釘選" in Traditional Chinese environment.
Could it be possible that you provide a trigger command, such as dot command? Triggered by pressing a dot (.) in the begining of line, and execute the corresping Obsidian commands?
For example:
.pin => Execurte Pin command
.pdf => Execute export PDF command?
etc.
I think it will be very useful to let us expand the commands and very convinent to execute commands.
Thanks.

Hi, @emisjerry :)
Thank you for your FR, but I'll not implement that feature because this plugin is for auto-complete, not for executing a command.
Kind regards.

What a pity...

i found a solution: using command alias to add alias to commands. Then i can use slash command to invoke it.


replace github.com/docker/docker with github.com/docker/engine v18…

….06.1-ce
because github.com/docker/engine is the newer versioned client SDK for docker
2. replace github.com/docker/distribution => github.com/docker/distribution master
since we need a newer version of github.com/docker/distribution for docker client
Thank you for contributing to meli.
Every contribution to meli is important to us.
Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to meli, and meli agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that meli shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.
Now,
What(What have you changed/added/removed?)
Why(Why did you change/add/remove it?)
fixes; https://github.com/komuw/meli/issues/108

Theres some work to be done;
for example volume.VolumesCreateBody;
https://github.com/komuw/meli/blob/3e22c43eff33e6bd2cc18041e4d1343d5426925b/volume.go#L16
seems to have been renamed to volume. VolumeCreateBody;
https://github.com/moby/moby/blob/b384467326e5b22c486e312f8232f3384dfdabb8/api/types/volume/volume_create.go#L12
and
https://github.com/docker/engine/blob/b384467326e5b22c486e312f8232f3384dfdabb8/api/types/volume/volume_create.go#L12
among other changes

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   49.18%   49.18%
=======================================
  Files           8        8
  Lines         555      555
=======================================
  Hits          273      273
  Misses        238      238
  Partials       44       44

Impacted Files
Coverage Δ

types.go
100% <100%> (ø)
:arrow_up:

volume.go
80% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e22c43...0aa476d. Read the comment docs.


Memoization group

@codecov How do I tell you when a code branch is to be ignored?

@heubeck here's a proposed uni.memoize() group with:

uni.memoize().forever()
uni.memoize().until(condition)
uni.memoize().during(duration)

What do you think?

/cc @cescoffier

@heubeck here's a proposed uni.memoize() group with:

uni.memoize().forever()

The different naming from other parts of the API is intended? (cf. await().indefinitely())

uni.memoize().until(condition)
uni.memoize().during(duration)

@cescoffier suggested in my PR to use 'atMost' with the duration, since it's invalidated not before end of the duration, atLeast may fit better, but I'm also fully fine with during.
Just a thought: as every event after expiration of the memoize duration is memoized, always(duration) could make things clear? Or it just confuses, don't know.

What do you think?

The offered functionality is fine, looking forward to use it :innocent:

The different naming from other parts of the API is intended? (cf. await().indefinitely())

You are right, I should rename to indefinitely here.

@cescoffier suggested in my PR to use 'atMost' with the duration, since it's invalidated not before end of the duration, atLeast may fit better, but I'm also fully fine with during.

atLeast is interesting, there is no hard invalidation when the duration has expired. It's rather the next subscription that can trigger invalidation.

Done

Ready for review.
I think we need to keep it experimental and see adoption.

@jponge, do you want me to adapt the documentation about "caching" and add it to this PR when you are finished with the implementation?

No that's fine I'll do it

@cescoffier @heubeck I just pushed a bunch of changes

I just spotted that the race condition tests inherited from UniCacheTest rely on a single threaded executor, which clearly  does not allow 2 runnables to compete for subscription and cancellation.
I'm replacing with Executors.newFixedThreadPool(2) and these tests fail now, I will look into fixing the race conditions.

Moved back to draft as a consequence of finding these blockers.

Pushed changes with fixes and @Ladicek feedback

I don't really feel like reviewing the PR, but the change to System.nanoTime LGTM.


Add DeltaCAT Development Getting-Started Doc

Issue for unaddressed TODO on https://github.com/ray-project/deltacat/pull/34:

I saw you have added dev-requirements.txt. Do you want to add the README.md about installing dev dependencies and setup of pre-commit?

Subtask: https://github.com/ray-project/deltacat/issues/60


Failed publishing "Item is protected" using New MultiModule Project wizard

I tried using the new project wizard and created the aem-project-archetype-10 project and deploy to a quickstart, and saw the following error message during publish.
Failed publishing path=/, result=JcrResult[ success:false, exception: org.apache.sling.ide.transport.RepositoryException - javax.jcr.nodetype.ConstraintViolationException: Item is protected]

What version of the IDE tooling are you using? Did you make any changes to the generated project?

Hi @rombert , I'm using Eclipse Mars.1 Release (4.5.1) with AEM developer tools (1.0.6), Sling IDE Tools (1.0.10). Maven (3.2.5). Java (1.8.0_73).
Thanks!
Jason

I can't reproduce this at my end and I am not sure why the Eclipse plugin would try to update the root node. Can you attach/paste your filter.xml files and also the settings that you used when creating the project?

Closed, as request for more informations was not answered.


Support allowlist option for MD040

While MD040 requires us to specify a language, it doesn't specify which languages we can use, which means we can use whatever we want as long as it's not an empty one.
But in the cases of syntax highlighting, tools like refractor will throw an error when we feed it an unknown language. It would be great if we can configure MD040 with an allowlist.
E.g.,
"MD040": { "allowlist": ["js", "css", "html"] },

Duplicate of https://github.com/DavidAnson/markdownlint/issues/608


I have simple question

Is this not supported?
I need 'else' on widget tree

Hi @xpwmaosldk
This comes to how you position the if else statement
Try this code sample below

minimal code sample
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({Key? key, this.dark = true}) : super(key: key);

  final bool dark;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      theme: dark ? ThemeData.dark() : ThemeData.light(),
      home: const Home(),
    );
  }
}

class Home extends StatefulWidget {
  const Home({Key? key}) : super(key: key);

  @override
  State<Home> createState() => _HomeState();
}

class _HomeState extends State<Home> {
  bool showFlutterlogo = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Material App Bar'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            if (showFlutterlogo)
              const FlutterLogo(
                size: 100,
              )
            else
              const Text('No Flutter Logo'),
            // showFlutterlogo
            //     ? const FlutterLogo(
            //         size: 100,
            //       )
            //     : const Text('No Flutter Logo'),
            ElevatedButton(
              child: Text(
                  showFlutterlogo ? 'Show Flutter Logo' : 'Hide Flutter Logo'),
              onPressed: () =>
                  setState((() => showFlutterlogo = !showFlutterlogo)),
            )
          ],
        ),
      ),
    );
  }
}

Oh my...
It didn't work before. right..?
thank you TahaTesser!


remove extra config.toml

- Summary
the site uses site/config.toml instead
- Test plan
rebuild site and it's the same
- Description for the changelog
remove extra config.toml

@tanyabouman what do you think about renaming the remaining config to hugo.toml as this is the new convention?

what do you think about renaming the remaining config to hugo.toml as this is the new convention?

Good idea.  Done.


Register GHG concentrations

@durack1 I wasn't sure exactly what to fill in where here. Let's discuss, fix, then I can write docs and include in here to help people.

@znichollscr might be best to move this chatter into an issue, as we have much information to coalesce across data products into a general purpose template - just FYI/and for my recollection a first pass attempt a synthesizing this across PCMDI-AMIP-1-1-9 (first CMIP6Plus dataset), CR-CMIP-0-1-0 (new) and CEDS-2017-05-18-CO2-em (CMIP6 dataset) is here. The information in the current input4MIPs_source_id.json, was just a subset pulled from the ESGF index, as below:
https://github.com/PCMDI/input4MIPs_CVs/blob/903ec2bd1c5e925a3fa5e610a4414f131a95e2bc/input4MIPs_source_id.json#L2131-L2149
In a near-final version, I would prefer augmented info, similar to what I have for the latest PCMDI-AMIP-1-1-9 dataset, which was generated from:
        "PCMDI-AMIP-1-1-9":{
            "calendar":"gregorian",
            "comment":"Based on Hurrell SST/sea ice consistency criteria applied to merged HadISST (1870-01 to 1981-10) & NCEP-0I2 (1981-11 to 2022-12)",
            "contact":"PCMDI (pcmdi-cmip@llnl.gov)",
            "dataset_category":"SSTsAndSeaIce",
            "further_info_url":"https://pcmdi.llnl.gov/mips/amip",
            "grid":"1x1 degree longitude x latitude",
            "grid_label":"gn",
            "institution":"Program for Climate Model Diagnosis and Intercomparison, Lawrence Livermore National Laboratory, Livermore, CA 94550, USA",
            "institution_id":"PCMDI",
            "license":"AMIP boundary condition data produced by PCMDI is licensed under a Creative Commons Attribution 4.0 International License (CC BY 4.0; https://creativecommons.org/licenses/by/4.0). Consult https://pcmdi.llnl.gov/CMIP6/TermsOfUse for terms of use governing input4MIPs output, including citation requirements and proper acknowledgment. Further information about this data, including some limitations, can be found via the further_info_url (recorded as a global attribute in this file). The data producers and data providers make no warranty, either express or implied, including, but not limited to, warranties of merchantability and fitness for a particular purpose. All liabilities arising from the supply of the information (including any liability arising in negligence) are excluded to the fullest extent permitted by law",
            "mip_era":"CMIP6Plus",
            "nominal_resolution":"1x1 degree",
            "product":"observations",
            "references":"Taylor, K.E., D. Williamson and F. Zwiers, 2000: The sea surface temperature and sea ice concentration boundary conditions for AMIP II simulations. PCMDI Report 60, Program for Climate Model Diagnosis and Intercomparison, Lawrence Livermore National Laboratory, 25 pp. Available online: https://pcmdi.llnl.gov/report/pdf/60.pdf",
            "region":[
                "global_ocean"
            ],
            "release_year":"2023",
            "source":"PCMDI-AMIP 1.1.9: Merged SST based on UK MetOffice HadISST and NCEP OI2",
            "source_description":"Sea surface temperature and sea-ice datasets produced by PCMDI (LLNL) for the AMIP (DECK) experiment of CMIP6Plus",
            "source_id":"PCMDI-AMIP-1-1-9",
            "source_type":"satellite_blended",
            "source_variables":[
                "areacello",
                "sftof",
                "siconc",
                "siconcbcs",
                "tos",
                "tosbcs"
            ],
            "source_version":"1.1.9",
            "target_mip":"CMIP",
            "title":"PCMDI-AMIP 1.1.9 dataset prepared for input4MIPs"
        },

Which was recorded in the previous iteration repo PCMDI/input4MIPs-cmor-tables/input4MIPs_source_id.json
The above (PCMDI-AMIP-1-1-9 example from the input4MIPs-cmor-tables repo) may also need an entry that details changes between the previous 1.1.8 and the current 1.1.9 data, along with the fact that this is the "endorsed" AMIP SST and sea ice dataset (rather than some secondary prototype/testing dataset that can be optionally used), along with any other information/identifiers that data providers want to include about their data. In the case that certain fields aren't used by some data providers, these can remain blank.

In a near-final version, I would prefer augmented info, similar to what I have for the latest PCMDI-AMIP-1-1-9 dataset, which was generated from

Ok I think that makes more sense. To check I understand, this source ID file would define not only high-level info about a dataset, but also details e.g. the grid and calendar?
Assuming I've understood correctly, we would then need a different source ID for each product that is on a different grid/calendar. For example, we provide data as a global-mean (no grid basically) and on a 15x360 degree grid (i.e. 15 degree latitudinal bands). With the proposal above, we would need to register two source IDs to differentiate between those two. Is that on purpose or is it better to drop some keys (that are data file, rather than data set, specific) out?

Made #13 to continue the discussion

Closing in favour of disussions in #13


Improve Lucide Icons

Hello, I’m working to improve lucide icons package, the goals of this PR are:

[x] Update icon set with the latest release of Lucide Icons
[x] Solve an inheritance problem in SVGs, currently I can't set a stroke width because the children overwrite the parent's width

I did some tests and everything seems okay to me

Thank you! Was just having the same problem with not being able to apply strokeWidth to the icons

Thank you! Was just having the same problem with not being able to apply strokeWidth to the icons. I was about to submit a PR for this, but your solution is much better! It might be nice to add strokeWidth as a prop though where you can pass a size token. It's a very simple change in IconProps.ts and themed.tsx

Looks great and Gabrola seems like he has good points.

Yes, it's a good idea, I'll add it, thanks for your feedback


Add tests CoordinateUtilities - row and column index

@manstis please have a look on these tests.

Thanks @jomarko


Error occur when checking format supported for HEIC/HEIF

Trying to install sharp on Docker Lambda for HEIC/HEIF support
installed libde265-1.0.5
installed libheif-1.6.2
installed vips-8.9.1
npm install sharp
><EMAIL_ADDRESS>install /home/aws-lambda/s3-resize-upload/node_modules/sharp
> (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)

info sharp Detected globally-installed libvips v8.9.1
info sharp Building from source via node-gyp
make: Entering directory `/home/aws-lambda/s3-resize-upload/node_modules/sharp/build'
  TOUCH Release/obj.target/libvips-cpp.stamp
  CXX(target) Release/obj.target/sharp/src/common.o
  CXX(target) Release/obj.target/sharp/src/metadata.o
  CXX(target) Release/obj.target/sharp/src/stats.o
  CXX(target) Release/obj.target/sharp/src/operations.o
  CXX(target) Release/obj.target/sharp/src/pipeline.o
  CXX(target) Release/obj.target/sharp/src/sharp.o
  CXX(target) Release/obj.target/sharp/src/utilities.o
  SOLINK_MODULE(target) Release/obj.target/sharp.node
  COPY Release/sharp.node
make: Leaving directory `/home/aws-lambda/s3-resize-upload/node_modules/sharp/build'
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

+<EMAIL_ADDRESS>added 84 packages from 168 contributors and audited 178 packages in 18.196s

2 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

But when checking for format supported, got
Something went wrong installing the "sharp" module

libvips-cpp.so.42: cannot open shared object file: No such file or directory

- Remove the "node_modules/sharp" directory, run "npm install" and look for errors
- Consult the installation documentation at https://sharp.pixelplumbing.com/en/stable/install/
- Search for this error at https://github.com/lovell/sharp/issues

Did you see #2000?

Sorry don't quite understand from it.
From this comment you mean I need to to have to have the installed libraries (libde265-1.0.5, libheif-1.6.2, vips-8.9.1) same directory with the build/Release/sharp.node?
Sorry and  thank you for your explaination

https://github.com/lovell/sharp/blob/master/binding.gyp#L160 ensures the compiled build/Release/sharp.node file always contains the vendor/lib location in its rpath so it might "just work" if you put other shared libraries in the same directory.
Another option might be setting LD_LIBRARY_PATH - good luck!

If you're providing a globally-installed libvips etc at install time then you'll need to ensure these are also made available at runtime. Did you see the https://github.com/smcguinness/SharpLayer repo linked to in #2000?

If I got it correctly, that means sharp couldn't detect the installed libraries when the function is called?
If I could put it together into Sharp folder, I could just deploy to AWS Lambda all together?
Sorry if I got it wrongly again.

Followed the steps from #2000, got result as below
libvips-cpp.so.42 => /usr/local/lib/libvips-cpp.so.42 (0x00007f3a16d45000)
libvips.so.42 => /usr/local/lib/libvips.so.42 (0x00007f3a166aa000)

How can I have it to point to /vendor/lib so I can package it and deploy to AWS Lambda?

Resort to another library to convert HEIC to JPG heic-convert
Closing this.


Document @title on @class=example

From @azaroth42 on November 3, 2014 15:5
Not sure if this belongs here, but it would be great if the use of a title attribute on a section with class="example" to generate a title could be documented.
For example here: http://www.w3.org/respec/guide.html#examples-syntax-highlighting
Copied from original issue: w3c/respec#356

The syntax highlighting example anchor referenced in this issue is no longer in the user guide, and there's still not a ton of info on the docs page for the example CSS class.  I also had to read the code :-)
I did a very quick update to the wiki page to capture the info I think is missing, and expected to make a PR but it looks like I have permissions to just directly edit :-O.  @marcoscaceres you may want to check it!
https://github.com/w3c/respec/wiki/example

https://github.com/w3c/respec/wiki/example/_compare/54ec91bf4b8b73fb46f19f661fa9b232399d0e58...6e3df96e7ee19de60f6314a9c99a03bf44dd0c88 is the diff for my wiki edit.

@triblondon, thanks! looks good. Tested example locally too.


[Bug]: QSProcessMonitor crashes Quicksilver

Before submitting your bug report, please confirm you have completed the following steps

[X] Searched the issue is not already listed in the Issue List (I've searched it)
[X] Searched in the Quicksilver Users' Group for questions relating to tech support.
[X] Downloaded the latest version of Quicksilver for your system and confirmed the issue still persists.

Bug description
As per the title -- we have a number of crashes in QSProcessMonitor. This will be a meta-issue with links to a few relevant issues.
For example, I get a EXC_BAD_ACCESS at https://github.com/quicksilver/Quicksilver/blob/f4f679f3a9a0dc377214e150761ff633a9807a13/Quicksilver/Code-QuickStepCore/QSObject.m#L412
My
Steps to reproduce

Start QS
Enable Running Applications & Processes in Settings -> Catalog -> Applications
Wait a few minutes to hours

Expected behavior
No crash
MacOS Version
Other
Quicksilver Version
2.4.2
Relevant Plugins
No response
Crash Logs or Spindump
The callstack during a crash:
#1	0x0000000184f77d90 in -[__NSDictionaryM objectForKey:] ()
#2	0x0000000105efa56c in -[QSObject _safeObjectForType:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject.m:416
#3	0x0000000105efa610 in -[QSObject objectForType:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject.m:429
#4	0x0000000105f2a6a0 in __54-[QSProcessMonitor processObjectWithPSN:fromSnapshot:]_block_invoke at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:207
#5	0x0000000184f98904 in __NSDICTIONARY_IS_CALLING_OUT_TO_A_BLOCK__ ()
#6	0x0000000184fbe2f0 in __NSDictionaryEnumerate ()
#7	0x0000000105f2a538 in -[QSProcessMonitor processObjectWithPSN:fromSnapshot:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:206
#8	0x0000000105f2a33c in -[QSProcessMonitor processObjectWithPSN:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:195
#9	0x0000000105f2b240 in -[QSProcessMonitor appTerminated:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:313
#10	0x0000000105f29be4 in __appTerminated_block_invoke at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:103

Screenshots
No response
Additional info
No response

Related issues:

https://github.com/quicksilver/Quicksilver/issues/2968
https://github.com/quicksilver/Quicksilver/issues/2990

Seem to have just had a crash at https://github.com/quicksilver/Quicksilver/blob/f4f679f3a9a0dc377214e150761ff633a9807a13/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m#L170, but XCode said it was "paused" -- unclear if I fat fingered something while it was running in the background.

For users thinking that this might be the cause of their crashes, consider disabling QSProcessMonitor in your settings by going to: Preferences -> Catalog -> Applications and unchecking Running Applications & Processes

Hi all,
I made a few related changes in the process-monitor-crashes branch, and it seems to be running much more stably for me.
If anyone would be willing to try out a debug version with these changes, I'd appreciate the feedback, I'll probably merge and cut a new release in a week or so if things seem improved:

Looks like the same crash is occurring: https://github.com/quicksilver/Quicksilver/issues/2990#issuecomment-2153738223

I'm still occasionally getting some of these EXC_BAD_ACCESS crashes coming through QSProcessMonitor, in spite of converting things to use the threadsafedictionary. Would appreciate any input from @pjrobertson @skurfer or anyone more familiar with ObjC.
Just now, crash is at https://github.com/quicksilver/Quicksilver/blob/af772d58691fc54d9f41bdc1a7690c78dd0a6e3b/Quicksilver/Code-QuickStepCore/QSObject.m#L461
#0	0x000000019cee9c08 in objc_msgSend ()
#1	0x00000001032f7fb4 in -[QSThreadSafeMutableDictionary objectForKey:] ()
#2	0x00000001033c2d9c in -[QSObject objectForCache:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject.m:461
#3	0x00000001033cdac8 in -[QSObject(FileHandling) fileExtension] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m:831
#4	0x00000001033cd73c in -[QSObject(FileHandling) isClipping] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m:810
#5	0x00000001033cbf8c in +[QSObject(FileHandling) fileObjectWithPath:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m:631
#6	0x00000001033f243c in -[QSProcessMonitor imbuedFileProcessForDict:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:179
#7	0x00000001033f3f20 in -[QSProcessMonitor reloadProcesses] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:391
#8	0x00000001033f326c in -[QSProcessMonitor appLaunched:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:298
#9	0x00000001033f1d44 in __appLaunched_block_invoke at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:82
#10	0x0000000102cdcf2c in _dispatch_call_block_and_release ()
#11	0x0000000102cdeba4 in _dispatch_client_callout ()
#12	0x0000000102ce7d88 in _dispatch_lane_serial_drain ()
#13	0x0000000102ce8e7c in _dispatch_lane_invoke ()
#14	0x0000000102cf8958 in _dispatch_root_queue_drain_deferred_wlh ()
#15	0x0000000102cf7c30 in _dispatch_workloop_worker_thread ()
#16	0x000000010359bd40 in _pthread_wqthread ()

AFAICT cache should be thread safe.

Well, I probably should have discovered Xcode's Address Sanitizer and Thread Sanitizer sooner. I still need to figure out how to use them and my superficial familiarity with ObjC is not helping, but it seems like it's a step in the right direction.
Thread Sanitizer identifies data races right where I've been getting crashes in QSThreadSafeMutableDictionary:
/Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepFoundation/QSThreadSafeMutableDictionary.m:107 Data race in -[QSThreadSafeMutableDictionary objectForKey:] at 0x10a08c920

Location is a 16-byte heap object at 0x10a08c920
Read of size 8 by thread 17
#0	0x0000000106c9be10 in -[QSThreadSafeMutableDictionary objectForKey:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepFoundation/QSThreadSafeMutableDictionary.m:107
#1	0x0000000106f56b70 in -[QSObject objectForCache:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject.m:461
#2	0x0000000106f6990c in -[QSObject(FileHandling) fileExtension] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m:831
#3	0x0000000106f69390 in -[QSObject(FileHandling) isClipping] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m:810
#4	0x0000000106f66b20 in +[QSObject(FileHandling) fileObjectWithPath:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m:631
#5	0x0000000106fa46bc in -[QSProcessMonitor imbuedFileProcessForDict:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:179
#6	0x0000000106fa753c in -[QSProcessMonitor reloadProcesses] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:391
#7	0x0000000106fa5f00 in -[QSProcessMonitor appLaunched:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:298
#8	0x0000000106fa3ac4 in __appLaunched_block_invoke at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSProcessMonitor.m:82
#9	0x00000001051a82e8 in __tsan::invoke_and_release_block(void*) ()
#10	0x00000001070aaba4 in _dispatch_client_callout ()
Write of size 8 by thread 21
#0	0x0000000106c9b260 in -[QSThreadSafeMutableDictionary initWithCapacity:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepFoundation/QSThreadSafeMutableDictionary.m:58
#1	0x000000018ba6cbd0 in -[NSMutableDictionary initWithObjects:forKeys:count:] ()
#2	0x0000000106f546c0 in -[QSObject copyWithZone:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject.m:293
#3	0x0000000106f47c54 in -[QSLibrarian typeArraysFromArray:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:527
#4	0x0000000106f46c88 in -[QSLibrarian recalculateTypeArraysForItem:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:463
#5	0x0000000106f45014 in -[QSLibrarian reloadSets:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:337
#6	0x000000018b98b144 in __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ ()
#7	0x0000000106f28a10 in -[QSCatalogEntry scanForced:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSCatalogEntry.m:719
#8	0x0000000106f43d9c in __28-[QSLibrarian reloadSource:]_block_invoke at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:273
#9	0x00000001051a82e8 in __tsan::invoke_and_release_block(void*) ()
#10	0x00000001070aaba4 in _dispatch_client_callout ()
Heap block allocated by thread 21
#0	0x000000010517e2d0 in wrap_calloc ()
#1	0x000000018b4e5d84 in _objc_rootAllocWithZone ()
#2	0x0000000106f546c0 in -[QSObject copyWithZone:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSObject.m:293
#3	0x0000000106f47c54 in -[QSLibrarian typeArraysFromArray:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:527
#4	0x0000000106f46c88 in -[QSLibrarian recalculateTypeArraysForItem:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:463
#5	0x0000000106f45014 in -[QSLibrarian reloadSets:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:337
#6	0x000000018b98b144 in __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ ()
#7	0x0000000106f28a10 in -[QSCatalogEntry scanForced:] at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSCatalogEntry.m:719
#8	0x0000000106f43d9c in __28-[QSLibrarian reloadSource:]_block_invoke at /Users/n8henrie/git/qs/quicksilver/Quicksilver/Code-QuickStepCore/QSLibrarian.m:273
#9	0x00000001051a82e8 in __tsan::invoke_and_release_block(void*) ()
#10	0x00000001070aaba4 in _dispatch_client_callout ()

Adding my thread 2990 (before this one) here
https://github.com/quicksilver/Quicksilver/issues/2990
Still crashing after debug images and updates.
I have disabled the Running Process catalog. Will revert back if/when the next crash occurs

v2.4.3 has been released and contains some relevant fixes. Can subscribers to this thread please update and report back?

I've upgraded.  Thanks so much for your work, @n8henrie !

Random background crashes still persist.
For me started 2 days ago, for no clear reason, on a previous version. Updated to v2.4.3 still crashing, 15 times in 2 days. Meanwhile I installed v2.4.3:Debug (4042)
I'm running MacOS Monterey 12.7.1 on Macbook Air M1
Other things I observed while analyzing crash reports in Console.app

5 out of 15 crash reports: "Time Since Wake:       1 seconds"
All crash reports fired round number of seconds from boot: "Time Awake Since Boot: 84000 seconds" - always at least two zeroes (***00)
Application Specific Information: abort() called

Attaching last crash report
Untitled.txt
Anything other info I should deliver?


[WIP] sr-iov integration documentation

Add a document explaining steps to use sr-iov with CNI-Genie.

@FozAhm thanks for your feedback!


Allow hubot to be cooked from a different repo than the one.

I also merged a PR by candianveggie.

Why removing revision attr ?

Please check #22

Merged in with #22


Readme Collaboration Test

Added my name to the readme under franklin's message. For testing/setup purposes

LGTM!


fix: Add startingRect scroll position to cloned node.

This fixes an issue where elements that have been scrolled are losing their scroll position during resize. It takes the scrollTop and scrollLeft values of the original element and applies it to the ghost element.
I was going to write a test for it but I couldn't get Karma to run the already existing tests without detaching from Chrome, running out of memory, etc.  Perhaps someone could help me out with that task. :)

Codecov Report

Merging #66 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   95.43%   95.47%   +0.03%
==========================================
  Files           4        4
  Lines         285      287       +2
  Branches       42       42
==========================================
+ Hits          272      274       +2
  Misses          8        8
  Partials        5        5

Impacted Files
Coverage Δ

src/resizable.directive.ts
96% <100%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ab1c7...c2e6ba3. Read the comment docs.

LGTM, thanks! re the tests, are you on the latest chrome / running npm run test:watch ?

@mattlewis92 I am on the latest Chrome, but I was just using npm test.

Hey @mattlewis92 , any idea if this will be merged or not?

Oops sorry, I am away travelling atm and forgot about this. Will cut a release now 😄

Released as 1.2.3 😄


Fix serialization bug

The casing on a field name is incorrect, preventing serialization.

API change check
API changes are not detected in this pull request.


Add apiBase and apiHeaders options.

This PR allows for changing the apiBase url, which implicitly adds support for various OpenAI proxies, the Azure OpenAI Service, and more. Likewise with adding apiHeaders, users may specify an organization per OpenAI's spec, and any necessary third party headers for non-OpenAI use.
We are maintaining a fork with these changes for use in our own tooling at Trelent, but figured we may as well just contribute it here if there's an appetite for it!
I noticed there were some formatting changes - what formatter do you use? Happy to rerun a specific format over this branch to match what you had before.

Mind all the version change commits - I didn't end up changing any with the last commit. We were just using that for our own fork.

Great work, that's live at openai-streams and on canary. Our default branch is now canary for openai-streams@canary testing first, but it works perfectly and is shipped.


Multi-layer support for macropads without a dedicated layer-switching button?

This tool is awesome and has helped me get my 3x2 +1 macro-pad working, however it seems to be defaulting to the third layer and since my macro-pad doesn't have a layer switching button, I can't seem to figure out how to utilize that feature. Is it possible to map it to one of the keys? Like setting a macro-pad specific modifier key?
Amazon link to my model

Official program doesn't have such capability. So I don't know whether this is possible. If you can find any program able to do this, we can sniff traffic and implement it.


Bring ingress documentation inline

@NimRegev As requested here is the documentation provided inline. I imagine each section being expandable. I think it's important that we keep all provider-specific instructions together. Especially for Google which is more complex than the other providers.
I do worry people will think a specific solution is tested so I added some language there aswell.
Signed-off-by: Dan Garfield<EMAIL_ADDRESS>

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/ingproviders/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/ingproviders/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/ingproviders/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/ingproviders/docs/


E8-23178

The changes for 479 are not needed and should be removed from this

Updated to include only changes for 555


Arweave Integration Milestone 1: Publish using transaction ID

Towards https://github.com/oceanprotocol/pm/issues/151.
Changes proposed in this PR:

Add ArweaveFile interface

superseded by https://github.com/oceanprotocol/ocean.js/pull/1612


Re-enable Sentry on Android (without crashes)

In order to resolve the crash bug #5757, we've disabled Sentry error reporting for our Android releases. See details at https://github.com/zulip/zulip-mobile/issues/5757#issuecomment-1728692990 , and the (long) chat thread around https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.20crashes/near/1643296 .
We should re-enable Sentry so that we have error reporting again, but without the crashes.
Possible ways to do that include:

Wait for Sentry upstream to find and release a fix. Their issue thread is https://github.com/getsentry/sentry-java/issues/2955 .

Re-enable Sentry reporting of events that arise in our JS and Kotlin code (both those we explicitly report, and uncaught exceptions), but without enabling Sentry's native code.
It's not clear whether this is possible; see chat discussion at https://chat.zulip.org/#narrow/stream/48-mobile/topic/Sentry.20crash.20bug/near/1644261 .
If the price of this were that we didn't get reporting of errors that happen within native code, that would be fine.

Some other workaround.

(#5768 is what does the disabling in main; we already did it for a release, v27.213, in a release branch based on v27.211.)

Quickly tagging #5741 here as possibly relevant as this release is the first time my Android 14 Pixel 5 has stopped crashing every 30 seconds. It has been non-stop crashes for a few months. I'm running zulip mobile android v27.213 which is finally happy / not crashing.

@darren1713 Very interesting! Thanks for that update. Glad the app is running crash-free for you again.
Just to repeat for this thread some of the context in that one: you first reported the crashes 2023-06-06, and they'd started when you upgraded to Android 14.
At that time I suppose you can't have been on the Google Play system update dated August 2023. That's interesting because it otherwise appears that this Sentry-related bug is only triggered (or only triggered frequently, at least) with that update; so perhaps that only applies to Android 13 and Android 12, and Android 14 is enough to trigger it on its own.

Android 14 is enough to trigger it on its own

I think we're getting events with #5741's error output much more frequently on Android versions other than 14, than on Android 14. And in both cases, the frequency graph doesn't have the ominous-uptick shape that was characteristic of the crashes that became the focus of #5757.

Android 14
Not Android 14

(These observations came up in an internal conversation but looks like I never updated #5741 with that information, oops.)

Ah thanks. I replied over on #5741, at https://github.com/zulip/zulip-mobile/issues/5741#issuecomment-1747636217 ; that's probably the thread for further discussion in that direction.

The PR #5765 which fixed this was effectively reverted in commit 033a9d63d6fec7b19bed411dea122fa704f211c8. I've filed a fresh issue for trying again:

#5782


Wrong API on migrations

Hi, I'm just starting with Sequelize, and looks like a great library!.
Using the sample project, just found out that the migrations API used is not correct, I guess is something still not migrated since the project start using umzug (I suppose)
file:<PHONE_NUMBER>0222-create-user.js
Current (wrong) API:
up: function(migration, DataTypes, done) {
    migration
      .createTable('Users', {
        username: DataTypes.STRING
      })
      .complete(done)
  },

Expected (correct) API:
up: function(queryInterface, Sequelize) {
    queryInterface
      .createTable('Users', {
        username: Sequelize.STRING
      });
  },

If needed, I can create the pull request with the changes.
Again, great work guys, kudos!!

Fixed in #29


sort: Slice fails to sort subslices (sometimes)

What version of Go are you using (go version)?

$ go version
go version go1.15.3 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/xxx/.cache/go-build"
GOENV="/home/xxx/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/xxx/gocode/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/xxx/gocode"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/home/xxx/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/home/xxx/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build010487569=/tmp/go-build -gno-record-gcc-switches"
r

What did you do?
https://play.golang.org/p/soXZlKQ2pRF
What did you expect to see?
I expected the subslice to be sorted and the output to be after: [1 2].
What did you see instead?
The subslice wasn't sorted. The output is after: [2 1].
sort.SliceStable doesn't work in this case, too.

Sorry, it was my mistake.


AbstractMedia::images() does not return gifs

AbstractMedia has several methods to select a subset of available media. One would expect AbstractMedia::images() to return gifs but it doesn't. Only AbstractMedia::all() does include gifs.
Impact:
The themes I have seen, frequently use constructs like the following to set a hero image: (Quark)
{% set blog_image = page.media.images[page.header.hero_image] ?: page.media.images|first %}

A gif will never be found although people would expect it to be found.
One could copy /system/config/media.yaml to user/config and tweak the 'type' for gifs, but I'm not sure if that should be the way to go.
Is there a rationale for omitting gifs?
NB. AbstractMedia seems to lacks methods for types 'animated' and 'vector'

Gifs are actually available in ::files() and not ::images(), this is because they are generally animated, and don't support the image manipulations without losing all their animation frames.

I'm thinking about which strategy seems more logic to me...
Block all kids below 18 at the door of the bar, or allow them entrance and serve them alcohol free beer as documented?
I think I would go for the second option:

since the several image manipulating functions I have tested on animated gifs, appear to make no difference except for resize(). No harm done.
not all gifs are animated and not all gifs are manipulated by functions...


We can no longer start files with BytePos(0)

After https://github.com/swc-project/swc/pull/4616 we can no longer start files at BytePos(0) and therefore now have to offset all our node byte positions. This is a very unfortunate change because byte positions of nodes no longer align with byte positions in the text.
I think we should deprecate using swc's BytePos and instead start using an opaque type that you can perform operations on, but need to provide a parsed source to get the index in the file.

swc won't be using u32::MAX https://github.com/swc-project/swc/pull/4650
For this change, we're going to have to ban the use of the following swc structs and methods:

BytePos
Span
span() - use ctxt() only
lo()
hi()

https://stackoverflow.com/a/69484643/188246
I'm thinking we can add a new methods to Spanned like start(), end() and range() that return a new SourceIndex type that wraps BytePos and offsets the position be a certain value.
pub struct SourceIndex(BytePos);

impl SourceIndex {
  pub fn new(val: usize) {
    SourceIndex(BytePos(val as u32 + 1000))
  }

  pub fn as_usize(&self) -> usize {
    (self.0.0 - 1000) as usize
  }
}

This is super unfortunate we have to do this though.


AssertionError: [ Checksum for cc.en.300.zip...

while running this line sh script/redial/eval/redial_rec_eval.sh in C2-CRS, I meet this error
AssertionError: [ Checksum for cc.en.300.zip from  https://pkueducn-my.sharepoint.com/:u:/g/personal/franciszhou_pku_edu_cn/Ee3JyLp8wblAoQfFY7balSYB8g2wRebRek8QLOmYs8jcKw?download=1 does not match the expected checksum. Please try again. ]
How can I fix it? Anyone can help?


[FLINK-12056][coordinator] Remove legacy methods in LeaderRetrievalUtils

What is the purpose of the change
Also some refactor.
I insist

[FLINK-12056][coordination] Remove legacy methods in LeaderRetrievalUtils
[FLINK-12056] Inline simple function LeaderRetrievalUtils#getRecoveryMode

and feel free to

[FLINK-12056] Loose implementation of utils
[FLINK-12056] Inline LeaderConnectionInfoListener

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector:(no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @zentol @dawidwys

@zentol well, will update commit and description to retain only the first commit.
For the last 3 commits, it is valid to be a hotfix pr(s)?


:sparkles: Feat: Add more json-rpc methods

Description
Add more json-rpc methods for low hanging fruit methods that can reuse existing methods.
For now they are just hardcoded in the rpc handler rather than being in the procedures package.
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

#973  👈
main

This stack of pull requests is managed by Graphite.


Actually print the error for "Connection failed to the datacenter"

The code that handles connection errors doesn't actually print the error.
It would help if it printed something.

Also printing the host and port of the server it's trying to connect to would be helpful.

@nhooey Starting from 0.14.1, these information are now sent to the logs, e.g.: https://github.com/sensu/uchiwa/blob/ad9d5fabf909a905dc0e6ece03f5164df69d39ad/uchiwa/sensu/loadbalancing.go#L55

Great! Thanks @palourde!


Particle Storm needs an update to work with phaser-CE

Particle Storm doesn't work with phaser-ce 2.7.2

A bug in the API (phaser-ce 2.7.2)

I'm unlikely to update Particle Storm to support CE, so I'd recommend adding in a method reference into CE. I.e. map PIXI.canUseNewCanvasBlendModes to the Phaser.Device equivalent.

 to the Phaser.Device equivalent.
which is what?

#2863


Not working in jenkins

New Issue Checklist

[yes ] Updated fastlane to the latest version
[yes ] I have read the Contribution Guidelines

Issue Description
Snapshot is working fine locally but not working in Jenkins.
Through Jenkins noticed three issues below:

Build fails after signing identity
App crashes when it tries to launch
Login page never loads and times out

But didn't notice any of this issue locally. I happens only in Jenkins.
Environment
fastlane version (run fastlane -v): 16.1
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? No
Do you use a Ruby environment manager ? No
What Xcode version do you use (8.0)

@jinsumv Can you provide your Fastfile and the full output of running fastlane, the crash and build failure that you mention?


Portal and quill

Hello! How to make toolbar of quill in Portal?

+1
Im trying to use quill inside Portal, but im getting addRange(): The given range isn't in document. when typing in the editor, thus the input is loosing focus. I tried the solution here, which works great when using quill outside Portal, but its not working when using it inside Portal


Project crashes when trying to view a dictionary with freed nodes as its keys in the remote tab.

Godot version:
3.2.2
Issue description:
When trying to view a node that has an attached script that contains a dictionary with previously freed nodes as its keys in the remote tab, the project will crash. This does not occur in 3.2.1 nor 3.2.2 beta 1 (I have not tested all of the 3.2.2 beta builds but I can confirm that the crash also occurs in 3.2.2 RC1).
Steps to reproduce:
Simply add the following code to a nodes script while the node is a parent of other nodes, then try to view that node in the remote tab while the project is running.
var test_dictionary = {}
func _ready():
	for a in get_children():
		test_dictionary[a] = "useless_value"
		a.queue_free()

Minimal reproduction project:
DictionaryBug.zip

Tested with 3.2.2 stable on Windows 10. I don't get a crash but the remote debugger gets disconnected and the log shows these errors:
ERROR: encode_variant: Condition "!v" is true. Returned: ERR_BUG
   At: core/io/marshalls.cpp:1179
ERROR: encode_variant: Condition "!v" is true. Returned: ERR_BUG
   At: core/io/marshalls.cpp:1179
ERROR: encode_variant: Condition "!v" is true. Returned: ERR_BUG
   At: core/io/marshalls.cpp:1179
ERROR: decode_variant: Condition "len < 4" is true. Returned: ERR_INVALID_DATA
   At: core/io/marshalls.cpp:108
ERROR: Error when trying to decode Variant.
   At: core/io/marshalls.cpp:490
ERROR: Error when trying to decode Variant.
   At: core/io/marshalls.cpp:525
ERROR: Error when trying to decode Variant.
   At: core/io/marshalls.cpp:525
ERROR: _notification: Condition "ret != OK" is true.
   At: editor/script_editor_debugger.cpp:1478

Can't reproduce on master b92477d77e9a6f46e4276a20a451dfac9d485f47

Sorry, I should have clarified my issue a bit better. The editor itself doesn't crash, just the active project running in the debug window, causing the debug process to abruptly stop.

@CritCorsac No worries! In my repro, the game itself actually doesn't crash. Only the remote debugging session stops and the game window stays open. Since it's different for you, could you share your minimal project in a zip? I wonder if the difference could be due to how we've set things up in the project somehow.

@pouleyKetchoupp On further testing I am getting an identical error to you. I originally thought the game window itself had froze as I was using a simple print command to check if it was still responsive, but seeing as this bug disconnects the debugger I wouldn't have been getting an output anyway, making that a silly oversight by myself.
Sorry if I've been using any incorrect terminology. I'm still kind of new to all this.
I have added a minimal reproduction project to my original comment.

@RandomShaper This looks like a regression on 3.2 from the dangling variants fix.
ScriptDebuggerRemote::_send_object_id fails on these lines when encoding the dictionary property:
https://github.com/godotengine/godot/blob/3e3972db7a0a7c04df8e852dc3e0d45061999575/core/io/marshalls.cpp#L1178-L1179
Because it fails to access the value from the key, which is a deleted object.
And that happens because Variant::hash() used in maps gets a null object in this case:
https://github.com/godotengine/godot/blob/3e3972db7a0a7c04df8e852dc3e0d45061999575/core/variant.cpp#L2859-L2862
On master, it works because Variant::hash() still gets an object pointer without checking instead:
https://github.com/godotengine/godot/blob/db168abe7d75d501a4a322dd8617f00ff8e2c4d5/core/variant.cpp#L2961-L2963
Would it make sense to change the hash method back to using the object address without nullifying it when it's been deleted? It's just a hash calculation, but I don't know if that could have dangerous side effects.

Fixed by #39906.


Add page for table of gmdmar modified items

Create a new page that lists, by date modified, all gmdmar modified items.
A boostrap table may be simpler than a datatable.
Construct the table using Liquid.

Unexpected issue: newer queries to loc.gov don't seem to have included number_source_modified in the search:results. The number_source_modified field should be in each result's item field.

Target fields to include:

id
title
date
bibliographic record modified
call number
thumbnail

plus hdl if possible

hdl not included


ecospold v1 model: Ecospold.dataset should return a list of Dataset instances

There can be more than one Dataset per ecospold file. Need to change name to datasets and helper method to get_element_list.

Resolved by 9507dcc.


Headings sizes in edit and preview modes

Hi @colineckert !
Very nice theme! Congratulations.
Size of headings in edit mode are quite different from their size in preview mode.
How can I make the edit mode size match the preview mode size?
Edit mode

Preview mode

@gdigesu thanks for raising the issue! This is something I noticed as well - it seems to be mobile-only - and I'm currently working on a fix. I should have a patch update ready later today.

@gdigesu ok this bug should be fixed - sizing is consistent on mobile between edit and preview modes. I just published a new release, so update your theme and let me know if this issue persists. Thanks again!

Collin, thank you.


Clicking on product variant crashes Dashboard 2.0

What I'm trying to achieve
Edit a product variant
Steps to reproduce the problem

Click on a product variant listed under a product

What I expected to happen
To be shown the variant editing page. Instead, I get the react error white screen. The browser console gives the following error TypeError: a.attributes.filter(...)[0] is undefined. An array index out of bounds error.
System information
Operating system: Windows 10 x64
Browser: Firefox 67

Why did you close it?

It no longer crashes. I thought it had been fixed.

Oh alright. It works as well for me now.


Specific Python Version for CARLA-0.9.10

Hi! I was wondering if there needs to be a specific python version for CARLA, specifically version 0.9.10.
I know that for python 3.9, the PythonAPI codes work well but when I try using 3.8 it introduces a "ModuleNotFound" error. Note the image below.
This is using python version 3.8

I would like to know if I can use python 3.8 with this version of CARLA and how I can go about it doing so.
Thanks!

Hello.
Did you build egg file for python 3.8?

Hello.
Did you build egg file for python 3.8?

Hi, I tried doing so by using 'make PythonAPI' command in the windows build instructions, being sure to be in the x86 Native Tool Command Prompt for VS and also tried using the 'python setup.py install' command in the normal command prompt.
In both cases, I made sure to be using python 3.8. the egg file still showcases for 3.9, even when I uninstall 3.9 from my system.
Maybe I am doing something wrong?

Hi, I tried doing so by using 'make PythonAPI' command in the windows build instructions, being sure to be in the x86 Native Tool Command Prompt for VS and also tried using the 'python setup.py install' command in the normal command prompt.
In both cases, I made sure to be using python 3.8. the egg file still showcases for 3.9, even when I uninstall 3.9 from my system.
Maybe I am doing something wrong?

Hi , I tried doing so by using 'make PythonAPI' command in the windows build instructions, being sure to be in the x86 Native Tool Command Prompt for VS

Hmm, i think now we should be using x64 command prompt. At least, lastest doc say so.
When I want to specify python version I use --python-version argument. In your case: make PythonAPI ARGS="--python-version=3.8". I work with python on Ubuntu, but I guess this command works for Windows too.

In both cases, I made sure to be using python 3.8. the egg file still showcases for 3.9, even when I uninstall 3.9 from my system.

Well, it's strange if you already uninstalled 3.9 version. As far as I know, make PythonAPI  uses default python version.
You can check in terminal which python version sets by default. Also, maybe environment variable for python didn't change after you deleted 3.9?

I tried these builds again, also trying to do another method of building, 'pip install carla/' in the PythonAPI folder and I see in all cases there are errors that occur. The following is the latest message:

Unfortunately, I don't know what it means =(

Hi , I tried doing so by using 'make PythonAPI' command in the windows build instructions, being sure to be in the x86 Native Tool Command Prompt for VS

Hmm, i think now we should be using x64 command prompt. At least, lastest doc say so.
When I want to specify python version I use --python-version argument. In your case: make PythonAPI ARGS="--python-version=3.8". I work with python on Ubuntu, but I guess this command works for Windows too.

In both cases, I made sure to be using python 3.8. the egg file still showcases for 3.9, even when I uninstall 3.9 from my system.

Well, it's strange if you already uninstalled 3.9 version. As far as I know, make PythonAPI  uses default python version.
You can check in terminal which python version sets by default. Also, maybe environment variable for python didn't change after you deleted 3.9?

I tried these builds again, also trying to do another method of building, 'pip install carla/' in the PythonAPI folder and I see in all cases there are errors that occur. The following is the latest message:

Unfortunately, I don't know what it means =(

Thank you for the feedback!
I tried rebuilding again, this time deleting the 'carla/Build/boost-install' directories, and then make PythonAPI ARGS="--python-version=3.8".
This allowed me to finally be able to successfully obtain the egg file for python 3.8 with no errors with regard to building. And import carla works just fine.
However, I end up getting the following error:

Is there a way to work around this error?

Thank you for the feedback!
I tried rebuilding again, this time deleting the 'carla/Build/boost-install' directories, and then make PythonAPI ARGS="--python-version=3.8".
This allowed me to finally be able to successfully obtain the egg file for python 3.8 with no errors with regard to building. And import carla works just fine.
However, I end up getting the following error:

Is there a way to work around this error?

Look at the 3083 issue, maybe their solution helps you too.

Look at the 3083 issue, maybe their solution helps you too.

@MisterioRemo Thank you for your help! I'll see if I can get around the error and post the solution if I can. Thank you for the resource as well!

@MisterioRemo Thank you for your help! I'll see if I can get around the error and post the solution if I can. Thank you for the resource as well!

It has been a while but I got it working!
There were a few things I tried to make this work so forgive me if this is a jumble of methods, but who knows, this might help someone hopefully.
A few things to note. For my project,  I use the "WindowsNoEditor" version of Carla, the Quick Installation. But I used the "Windows Build" version of Carla to build the specific *.egg file I needed for a python version, in my case Python 3.8.
Method 1:
I made sure to install a specific version of a library solver, using Axel1092's message in issue #3083
pip install -Iv setuptools==47.3.1
I then rebuilt the PythonAPI for carla in the "Windows Build" version using this

I tried rebuilding again, this time deleting the 'carla/Build/boost-install' directories, and then make PythonAPI ARGS="--python-version=3.8".

I then took the *.egg file that should be in the /PythonAPI/carla/dist directory in the "Windows Build" version and placed in the /PythonAPI/carla/dist directory in the "WindowsNoEditor" version. Carla python scripts work perfectly for me.
Method 2: (This one might be a coincidence)
Still in the "Windows Build" version, there were times before this when the make PythonAPI command would result in errors and would not create the *.egg file. In windows, a message would pop up at the end saying the the build was successful, but most times this is not true. If you do not see a *.egg file in the /PythonAPI/carla/dist directory, the build was not successful.
I ended up trying to follow this YouTube tutorial. I followed it after they installed "Windows Build" version of carla at around the time 5:20. They use mingw and uses the command mingw32-make rebuild before building python. After following the tutorial, I found that the make PythonAPI command works successfully and being sure to do the first method I mentioned, Carla python scripts should work just fine.
Hope this helps someone! I'll keep this issue open for a few more days, if someone else has any problems or questions.
Thanks!

Hey @iiJoeyii
This thread has been closed for a while, so you might not notice my comment. But if you do, I request some help from you.
I have tried to build the .egg file for python 3.8, but while running make PythonAPI ARGS="--python-version=3.8" I keep getting lots of boost errors and can't successfully build the file. It looks like it will take a lot of my time to fix all the errors, so I thought if you can share your .egg file, I can move onto the next part of my project sooner as my deadlines keeps getting closer.
It would be a great help if you can share the egg file.
Thanks!

Hi @Mohammed012345, I can try help!
Before you try my egg file try removing all the boost files from the carla/Build directory and rerun make PythonAPI ARGS="--python-version=3.8" and see if that works for you.
In any case, I uploaded my egg file to a miscellaneous repository I have.
I hope this helps!

Hi @iiJoeyii ,
First of all, thanks for the quick response and the egg file :)
I will try removing the boost files and execute the command if I need to in the future. One final question I had was if this egg file would also work with CARLA 0.9.10 version or if not then how to build for a specific version. As far as I've seen, the build always generates egg for the latest version.
Thanks again!

Hi @Mohammed012345,
No worries!
You can try to see if it would work with 0.9.10. I should have mentioned that this egg file is for the 0.9.11 version, that's my mistake. Building the egg file should be dependent on what version you have installed. So, if you have 0.9.10, the egg file will build for 0.9.10.

Hi @Mohammed012345, I can try help!
Before you try my egg file try removing all the boost files from the carla/Build directory and rerun make PythonAPI ARGS="--python-version=3.8" and see if that works for you.
In any case, I uploaded my egg file to a miscellaneous repository I have.
I hope this helps!

Could you tell me how to make your egg? Because when I run the command "make PythonAPI" on  Native tool Command, it often has an error. Or could you show me the video on youtube show the process. Thanks

It has been a while but I got it working!
There were a few things I tried to make this work so forgive me if this is a jumble of methods, but who knows, this might help someone hopefully.
A few things to note. For my project, I use the "WindowsNoEditor" version of Carla, the Quick Installation. But I used the "Windows Build" version of Carla to build the specific *.egg file I needed for a python version, in my case Python 3.8.
Method 1:
I made sure to install a specific version of a library solver, using Axel1092's message in issue #3083
pip install -Iv setuptools==47.3.1
I then rebuilt the PythonAPI for carla in the "Windows Build" version using this

I tried rebuilding again, this time deleting the 'carla/Build/boost-install' directories, and then make PythonAPI ARGS="--python-version=3.8".

I then took the *.egg file that should be in the /PythonAPI/carla/dist directory in the "Windows Build" version and placed in the /PythonAPI/carla/dist directory in the "WindowsNoEditor" version. Carla python scripts work perfectly for me.
Method 2: (This one might be a coincidence)
Still in the "Windows Build" version, there were times before this when the make PythonAPI command would result in errors and would not create the *.egg file. In windows, a message would pop up at the end saying the the build was successful, but most times this is not true. If you do not see a *.egg file in the /PythonAPI/carla/dist directory, the build was not successful.
I ended up trying to follow this YouTube tutorial. I followed it after they installed "Windows Build" version of carla at around the time 5:20. They use mingw and use the command mingw32-make rebuild before building python. After following the tutorial, I found that the make PythonAPI command works successfully and being sure to do the first method I mentioned, Carla python scripts should work just fine.
Hope this helps someone! I'll keep this issue open for a few more days, if someone else has any problems or questions.
Thanks!

Hi @TrinhTuanHung2021, try this for the version of Carla you have and see if that will work.


TimesUp not needed for PF1

Hi, I just wanted to drop a quick note to say that TimesUp is not needed for the PF1 system. The module works without it due to a recent update in PF1 which enabled durations.
Thanks for a great mod

Okay, thanks!


Allow user to bind admin port on different host

like localhost to protect the endpoint if they so wish.
Default to <IP_ADDRESS>.

Current coverage is 47.04%

Merging #842 into master will increase coverage by +0.09% as of 358f6d9

@@            master    #842   diff @@
======================================
  Files          263     263
  Stmts        12456   12460     +4
  Branches      1585    1585
  Methods          0       0
======================================
+ Hit           5849    5862    +13
+ Partial        446     443     -3
+ Missed        6161    6155     -6

Review entire Coverage Diff as of 358f6d9

Powered by Codecov. Updated on successful CI builds.

@mattnworb @negz @gimaker

lgtm


Adding Bigtable system tests to list of default system tests.

Coverage remained the same at 100.0% when pulling 176e0e8308a6d94b4e8378613828bb6bd91b9a91 on dhermes:turn-on-bigtable-sys-tests into 49f18eda3f8e2acd9733bc51d44ae8e7f76ce1e8 on GoogleCloudPlatform:master.

@tseaver I'm AFK right now but this is going to be more painful than I thought.

It's failing on the merge commit because it needs grpcio in the tox environment.
It needs to be disabled in Python 3

OK, I've reverted it.

Cool. I think the fix will be a two-liner change to tox.ini since system-tests and system-tests3 are separate it won't be that hard to just run another script in the first env.

Does the travis utility script have an option to emulate running tests locally?

No idea. What's the concern?

So that we could exercise all the Travis-dependent bits of our scaffolding.  It doesn't look like it.

The failure of this PR was not Travis based. I never ran it locally (I was in too big a hurry). tox will "save us".
I'd also say that tox -e system-tests is no longer worth running locally. Instead
python system_tests/run_system_test.py --package=FOO

will be better during local dev (since much faster).


Issue #49  - Compile Time DI Testing (components)

Addresses issue: https://github.com/playframework/scalatestplus-play/issues/49
This is a first pass for review, still lots TODO (see below).
Feedback and comments appreciated before I move onto adding more tests and docs. I only changed the solution slightly from what was described in the issue, so Guice is still the default choice for most tests - which makes sense given it's the default choice for Play Applications.
Feedback on the package names is appreciated, I went with components but open to suggestions.

[x] Add *WithComponent traits to allow testing applications with manual DI
[ ] Add tests for OneAppPerSuiteWithComponents
[ ] Add tests for OneAppPerTestWithComponents
[ ] Add tests for OneServerPerSuiteWithComponents
[ ] Add tests for OneServerPerTestWithComponents
[ ] Add examples and docs for OneAppPerSuiteWithComponents
[ ] Add examples and docs for OneAppPerTestWithComponents
[ ] Add examples and docs for OneServerPerSuiteWithComponents
[ ] Add examples and docs for OneServerPerTestWithComponents

Locally I'm struggling to get the whole project to build with the browser tests passing (I'm running OSX). Do you have any setup advice?

 This will format the code according to Scalariform configuration. The code style is checked by our build in Travis and if it does not conform, the build fails.

ahh, thanks @marcospereira - will do!

Ok that's all pushed now ready for initial comments. If you guys are happy with the solution I'll move forward adding more tests, docs etc.

@marcospereira - are you guys happy for me to move forward with this? I'll rebase & get back on it over the next week if so.
TBH I forgot to prod you to move things forward, sorry!

Hey @markglh,
First of all, sorry for the long time to review this.
I think the main point I would change here is how the trait WithApplicationComponents is defined. It could be rewritten to:
trait WithApplicationComponents {

  /**
   * @return The current components
   */
  def components: BuiltInComponents

  /**
   * @return new application instance and set the components. This must be called for components to be properly set up.
   */
  lazy val newApplication: Application = components.application

  /**
   * @return a context to use to create the application.
   */
  lazy val context: ApplicationLoader.Context = {
    val classLoader = ApplicationLoader.getClass.getClassLoader
    val env = new Environment(new java.io.File("."), classLoader, Mode.Test)
    ApplicationLoader.createContext(env)
  }
}

And then, given a BuiltInComponents implementation, like:
class SomeComponents(context: ApplicationLoader.Context)
  extends BuiltInComponentsFromContext(context)
    with NoHttpFiltersComponents {

  override def router: Router = Router.empty

}

We can have specs like:
class SomeSpec extends PlaySpec with OneAppPerSuiteWithComponents {
  override def components: SomeComponents = new SomeComponents(context)
}

Which is almost the same for users writing specs, but we remove the need for immutability. And since the user spec is overriding the return type for components, we can have access to any component specific to SomeComponents.
WDYT?

Also take a look at the 2.5.x tests https://github.com/playframework/play-scala-compile-di-example/blob/2.5.x/test/ApplicationSpec.scala

Great, thanks guys - I'll dig into this over the weekend and move things forward!

@marcospereira Making this immutable makes sense, I can't think of any normal usages where this is gonna cause issues, so I've pushed up those changes.
I've looked over the Play 2.5 tests that @wsargent pointed out, I think this saves enough boilerplate to make it worthwhile having in the library though.
I need to add more tests and examples for the various traits, and I plan to document this in the play docs. Is there a recommended procedure for updating the documentation? I can figure it out by looking at what's there but not everything (css tags, etc) is totally obvious.

Hey @markglh, the doc are here:
https://github.com/playframework/scalatestplus-play/tree/master/docs/manual/working/scalaGuide/main/tests
They are just regular markdown files with a custom syntax to include code samples. You don't need to touch any CSS or JS files.

Thanks for the feedback @marcospereira. I'll address these and add the docs. Am I right in thinking I raise a pr here to get the page linked into the main docs?
Also, apologies for the ridiculous delay finishing this PR, life's been a bit crazy recently.

I think this is good to go now! Pending a final review @marcospereira

Thanks, no problem at all @marcospereira  - the review process was really helpful, no complaints at all my end!! Thanks for your patience in getting this through :D
Should I raise a Pr in the main play repo to link to the new docs? here maybe?

Should I raise a Pr in the main play repo to link to the new docs? here maybe?

Yes, please. :-)
Just waiting for Travis build and then we can merge this. After that, we can also make a new release (probably today or tomorrow).
Again, thank you @markglh.

Thanks! Sounds like a plan 👍

Pr raised: https://github.com/markglh/playframework/pull/1/files 😸

PR Raised here: https://github.com/playframework/playframework/pull/7578 😸

I'll open/close it at that point.

Merged already. I think our task to validate docs is missing the index.toc files. Anyway, you don't need to close/open the project to trigger a new build. Project members can do that in Travis. ;-)

Awesome everything's merged now, thanks @marcospereira !

@markglh just to let you know there is now a 3.1.0 release. Also, see 3.1.x branch. :-)

That was quick! Thanks 😄


Handle our workspace:* deps properly in static analysis code

Testing static analysis with goose-quotes in the example folder got tricky. We were trying to follow the defintion of measure back to the workspace dist (compiled js for the hono client lib), and that overloaded the language server.
This PR makes sure we ignore fpx workspace deps when doing static analysis

Bonus: Do not follow the arguments identifier at all, as this can cause serious issues

LGTM, but i was thinking: wouldn't it be good idea to create issues for workspace package support (as well as support for parsing argument)?

good point, i created an issue for handling workspace packages. however, for arguments i'm comfortable just ignoring that identifier for now — the only place this would break is if someone defined a variable called arguments in a higher level scope, and knowledge of that identifier's value would improve the request generation


Formatting and light editing.

I have formatted the documents to conform to common Markdown conventions, such as limiting line lengths to 80 characters (so they fit in vi with default settings), and placing spaces between hashes and header texts (as @leebrian did with README.md in #4a43e32b0db0b053db37d394d6ef2c1aa078a5c6).

Thanks Tony. No content or wording changes, but now the code is a little easier to read and work with...


cppcheck: out of bound access to string

While checking with cppcheck I found an out of bound access to a string in the catch header: catch.hpp:4151
It should be
for( std::size_t i = 0; i < arg.size(); ++i )

instead of
for( std::size_t i = 0; i <= arg.size(); ++i )

, shouldn't it?

Yes, there's also a pending PR #660 fixing it.


[Impeller] Use API validation for tests.

In https://github.com/flutter/flutter/issues/121015 I found a crash related to "API validation" checks.  We should make sure that we are running our impeller integration tests with API Validation turned on.
Here are the environment for shader validation.  We do have these turned on in run_tests.py, but I'm not sure what the one is for API validation.

We were using the guidance in this doc for API validation but that was based on reverse engineering what Xcode does. After updating to Ventura, the steps stopped working.

Executing the following program with metal validation on shows us the correct environment variables:
code:
#include <stdio.h>
#include <stdlib.h>

int main(int argc, char *argv[], char * envp[])
{
    int i;
    for (i = 0; envp[i] != NULL; i++)
        printf("\n%s", envp[i]);
    getchar();
    return 0;
}

environment variables:
METAL_DEVICE_WRAPPER_TYPE=1
METAL_DEBUG_ERROR_MODE=0


Keyboard navigation doesn't work

[ ] navigate using arrows
[ ] navigate using tab
[ ] navigate using enter
[ ] escape should not quit the app
[x] Text fields work with keyboard (this currently works)

Closing as dup of https://github.com/flutter/flutter/issues/13264


Update CONTRIBUTING.md

While the wiki has well-maintained info about many ways to contribute, this top-level file lacked the same level of polish. This is an attempt to summarize the contribution avenues, and increase the readability of the issue-reporting flow.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: brookr sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!


Helm - Spread instances across zones in Kubernetes cluster for high availability

In what area(s)?

/area runtime
/area operator
/area placement

/area docs
/area test-and-release

Describe the feature
Spread instances across zones in the Kubernetes cluster to not all be scheduled on the same failure zone.
This can be done by using pod anti-affinity or pod topology spread constraints (Kubernetes 1.19+).
This could potentially only be enabled when running in HA is enabled.
Release Note

RELEASE NOTE: ADD: Spread Dapr instances across zones in Kubernetes cluster for high-availability

@yaron2 ok if I send a PR as well?
Only thing I'm not sure about is what approach to use. I'd go for topology spread but that is 19+ but can add both with a config flag.


feature: non root user

Description

Creating a non-privileged user to run Dist::Zilla by using local::lib to install dependencies
New labels were added as well to provided better metadata about the image

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[X] My code follows the style guidelines of this project, please see the contribution guidelines.
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas

Thanks for the contribution @glasswalk3r


circleci not using master & devs not pulling before submitting pr == failures because of old master

https://circleci.com/gh/istio/istio/31744
+ gometalinter.v2 --config=./lintconfig_base.json ./...
pilot/pkg/kube/inject/webhook_test.go:344:65:error: unused variable or constant too many arguments (varcheck)
pilot/pkg/kube/inject/webhook_test.go:344:56:error: unused variable or constant too many arguments (varcheck)
pilot/pkg/kube/inject/webhook_test.go:344:46:error: unused variable or constant too many arguments (varcheck)
pilot/pkg/kube/inject/webhook_test.go:344:36:error: unused variable or constant too many arguments (varcheck)
pilot/pkg/kube/inject/webhook_test.go:344:24:error: unused variable or constant cannot use configFile (variable of type string) as WebhookParameters value in argument to NewWebhook (varcheck)

This happens not only when devs don't rebase their PR prior to submission, but when reviews take awhile or base their PR on top of a broken circleci commit.

another example is https://circleci.com/gh/istio/istio/33844
we have master broken with linters because the pr that has linter issues and the pr that changed linters happened near without a rebase

Added "pull master" to depupdate, which calls "git merge master" before each CI run.


Communicating between your Django APIs using RAbbitMQ

Article checklist
ATTENTION: In your PR - add the ISSUE (topic form) # that this PR corresponds to. You can do this by also adding a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.
This fixes #3011.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
If you have not already please go over our Resources Page for more tips and tricks on how to improve our overall technical writing.
Preliminary Checks - Formatting and Structure

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.
[x] Does your article follow any of the suggested structure formats? - see example formats
[x] Is your article properly formatted in Markdown? - see Github Markdown guide
[x] Have you used the correct folder and file structure? - see Contribution Guidelines
[x] Is your article over 750 words? - Tool: Wordcounter.net
[x] Have you used our preferred heading structure? - H3 (###) and up
[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.
[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.
[x] Have you included a hero image that is 600x400 pixels and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images
[x] In your PR - add a comment that states "This fixes #(enter your Idea Content Form #)" to link and close your Idea Content (issue) when the PR is merged.

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid -  Grammarly
[x] Please place your article through a 3rd party plagiarism checker? We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide

Contribution guidelines
For first-time contributors and for more details, see Contributing Guidelines

This fixes #3011

Hello @JohnKiguru. I shall be reviewing your pr
cc: @hectorkambow

@Qodestackr Kindly, have you contributed any articles to section. I was searching your username and couldn't find any associated PRs. Thanks

Hello @WanjaMIKE, @Qodestackr has already published 5 articles.🤗

plagiarism check done

Thanks for the changes, I'm ready to start a tech review
cc: @ahmadmardeni1

Great article @JohnKiguru. The flow of the article is smooth.
This article will be ready for final review once you add the GitHub link which will be helpful.

Done

Great. Pinging content moderators for a final review
cc: @ahmadmardeni1 @hectorkambow

@JohnKiguru
Overall nice work - please do go over my final edits to improve future articles and reviews .
cc @Qodestackr


Powershell Terminal - navigation enhancements with ctrl-arrow keys

In Windows Powershell console outside of VScode, it is possible to quickly navigate through commands on the current line with ctrl-arrow keys to skip words blocks Currently in the VScode Powershell terminal, there is no way to quickly navigate the cursor through the text, the arrow key only affords one character at a time.

looks like there's already been work done here on this
https://github.com/PowerShell/vscode-powershell/issues/818


How to save my character's every frame pose?

Dear author, I have download the newest version of Maple Necrocer. I want to save my character's every frame pose, and there was a function named "Save" next to "Spawn" before, but I can't find it now.
But now it can only be stored in Stand mode? Thanks for your reply.
作者您好~ 先前紙娃娃能夠依每個影格姿勢&調整範圍並儲存，現在那個功能似乎不見了?
請問是改到別的地方了還是以後只能儲存stand姿勢呢? 謝謝回覆

這功能已經加入了


[FEATURE REQUEST] Single, unified best twitter client

This is what it always come to my mind everytime I open either squawker or Quacker, that why not both apps can be unified and be a single best alternative as open source end for x. Both apps have some unique advantages and some drawbacks(bugs). Instead of putting all your efforts individually, why not it can be made as single app with all the features of both apps combined, as it was like fritter earlier.  You might have various valid reasons for being unique and separate. Im respecting it but this is jist my suggestion. Thanks.

I'm thinking about doing this already, as the stress of maintaining Quacker is daunting on me

I do want to hear from other people before I start merging my changes into Squawker


No support of drag on touch devices

To implement in priority

Hey, have you done the touch implementation?

Nope, and this repo is quite dead. Maybe I'll find some time for this, but I can't promise anything really.


Backup/Restore with stdin/stdout

Like most of backup command line, it could be a great thing to be able to dump to stdout and restore from stdin.
In the better world this feature allows developer to not configure a storage.

We can specify a filename so that should be enough.


add visa as brand name

Just saw that Visa was missing as a brand name and added it.

Coverage decreased (-0.005%) to 99.677% when pulling bda8d95ccfd4bc77611a93603a9f58057fbac4ad on hendricius:add-visa-brandname into c3c29572b822e8bfefd123a2da790d92015d1fc3 on Fivell:master.

Coverage decreased (-0.005%) to 99.677% when pulling bda8d95ccfd4bc77611a93603a9f58057fbac4ad on hendricius:add-visa-brandname into c3c29572b822e8bfefd123a2da790d92015d1fc3 on Fivell:master.

Coverage decreased (-0.005%) to 99.677% when pulling bda8d95ccfd4bc77611a93603a9f58057fbac4ad on hendricius:add-visa-brandname into c3c29572b822e8bfefd123a2da790d92015d1fc3 on Fivell:master.

Coverage decreased (-0.005%) to 99.677% when pulling bda8d95ccfd4bc77611a93603a9f58057fbac4ad on hendricius:add-visa-brandname into c3c29572b822e8bfefd123a2da790d92015d1fc3 on Fivell:master.

Coverage decreased (-0.005%) to 99.677% when pulling bda8d95ccfd4bc77611a93603a9f58057fbac4ad on hendricius:add-visa-brandname into c3c29572b822e8bfefd123a2da790d92015d1fc3 on Fivell:master.


Fix bug we initiate a backup when the volume has started detaching

When the volume.Spec.NodeID is different than the node ID of the backup VA ticket, we should not initiate a backup as the volume is going to detach soon
longhorn/longhorn#7937
This PR is going to replace the approach at the PR https://github.com/longhorn/longhorn-manager/pull/2627. After discussed with @ejweber and @james-munson , we think that this approach is better because:

The other approach only touches the logic for the VA ticket of RWO non-migratible volume. It still leaves the logic for the RWX and mitigrable volume the same as we cannot compare the volume.Spec.NodeID with the node ID of these VA tickets. They are most likely to be different
It is fundamentally still correct that when the volume start detaching (but not finish detaching yet) the VA ticket can set to satisfied because at this exact moment the volume is still attached. VA controller can set reset the VA ticket to satisfied:false when the volume finish detaching. It is the responsibility of the client (backup controller in this case) to check and make sure that the volume.Spec.NodeID is still the desired one

Test run:

Master: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6379/
v1.5.x: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6385/

Still need to follow up with the test results later, even though the PR has been merged.

@mergify backport v1.6.x v1.5.x

The fix is general, so it should be expected to happen in 1.6 and 1.5 after VA was introduced. Do you know why this issue can reproduce after 1.5.4-RC2? @PhanLe1010 @c3y1huang

Hi @innobead my currenty theory is that we change the code flow somehow and make it longer between volume.Spec.NodeID being cleanup and the time that volume start detaching by setting the engine.spec.desirestate to stop. But that is just an idea and I couldn't find proof in from the git diff of recent commit. I belive @c3y1huang and @mantissahz already search the commit history too. We couldn't pin down the exact commit that make the race become more visible

That's reasonable and should be fine, as we already clarified the fix here.


YQL code generation failing with unexpected errors

The request
use ytdemo;
pragma yt.DefaultCluster ='ytdemo';

$multiply_member = ($st, $m, $x) -> {
    return $st.$m*$x
};

$struct_multiply = ($struct, $x) -> {
    $members = ["a", "b"];
    $multiplier = EvaluateCode(LambdaCode(($st) -> {
        return FuncCode(
            "AsStruct",
            ListMap(
                $members,
                ($m) -> (
                    ListCode(
                        AtomCode($m),
                        FuncCode(
                            "Apply",
                            QuoteCode($multiply_member),
                            $st,
                            ReprCode($m),
                            ReprCode($x)
                        )
                    )
                )
            )
        )
    }));
    return $multiplier($struct);
};

insert into `//home/ibushmarinov/testmult`
with truncate
select * from (
    select
    -- /RenameMembers(
        $struct_multiply(
            TableRow() , 2)
    --     ,
    --      ($x) -> ($x || "_2")),
    -- RenameMembers($struct_multiply(TableRow(), 3), ($x) -> ($x || "_3"))
    from (Select 1 as a, 2 as b)
) Flatten columns;
commit;
select * from `//home/ibushmarinov/testmult`;

fails with the following cryptic error:
YQL embedded call failed[1]
yt/yql/plugin/plugin.cpp:171: Failed to run: -memory-:<main>: Fatal: Expression evaluation

    -memory-:<main>:11:19: Fatal: At function: EvaluateCode
    	    $multiplier = EvaluateCode(LambdaCode(($st) -> {
	                  ^
        -memory-:<main>: Fatal: yql/providers/yt/lib/config_clusters/config_clusters.cpp:96: TYtGatewayConfig: No default cluster

[1]

This seems to be a bug on the server side and not in the code itself. What does "default cluster" even mean in this context?

Hello!
It was fixed in 19c0638759853903d07f928247367f98960f12a8. Please wait for the next yql-package update.
This example will start working after the update.

Fixed as of today.