[nrfconnect] Remove temporary timeval problem fix after merging solution from Zephyr.

Problem
Temporary solution was introduced in order to fix timeval type size problem resulting in improper operation of the select method. It's an internal Zephyr implementation problem and it will be fixed there.
Proposed Solution
Remove changes introduced in https://github.com/project-chip/connectedhomeip/pull/3800 after merging fix from Zephyr project.

@kkasperczyk-no has this been done yet? any ETA?

@woody-apple It can't be removed yet. Fix was merged to Zephyr master quite long ago, but in CHIP we got Zephyr revision associated with the nRF Connect SDK version and currently recommended 1.4.0 version does not have it. New version 1.5 of nRF Connect SDK should be released in next few weeks and after that we will update it in CHIP. I remember about that issue, but thank you for reminding and tracking issues status!


Remove vscode settings from repo

Coverage remained the same at 100.0% when pulling 166ce365d80695bdf27f9d779107e83e328423b5 on feature-remove-vscode-settings into 0f731a8680b4c6a458f22f9b4907ae938a124098 on main.


Support for nRF52810?

Hello!
If I started work on an nrf52810-hal is it the sort of thing you would like to see merged, or developed as a separate project? I can't see any references to it in this repository so I was just wondering what the plans were.
Thanks :)

Hi!
Sure, if you did an implementation and the code is okay, we'll happily merge that!
It seems that just nobody did have the need of an implementation yet. I also didn't hear much of the nRF52810 yet, so not sure how widespread it is.
You are welcome to contribute anytime!

What @Yatekii said.

I was just wondering what the plans were.

This is a pretty loosely organized group, so there aren't really any plans beyond what the individual contributors want. If you want to support 53810 in this crate, go ahead and make it happen :-)
One caveat: I'm not sure how many of the current maintainer have nRF52810 hardware and experience (I know I have neither). I'm guessing this would require some ongoing maintenance on your part, after the initial contribution.

As far as hardware goes, nRF52810 can be "emulated" on nRF52832 dev. board, since former is just a stripped version of the latter. For that reason there is no nRF52-DK in existence which is specifically for the nRF52810 chip. That being said, the only support that this chip is requiring is a correct linker script which takes into account smaller amount of memories available and, perhaps, to implement feature-gating of peripherals that aren't present on the chip.

@eupn Good to know, thank you! :)

I'm not sure which is better of the following two options:
#[cfg(feature = "52810")]
use crate::target::{spim0, SPIM0};

#[cfg(any(feature = "52832", feature = "52840"))]
use crate::target::{spim0, SPIM0, SPIM1, SPIM2};

or
use crate::target::{spim0, SPIM0};

#[cfg(any(feature = "52832", feature = "52840"))]
use crate::target::{SPIM1, SPIM2};

Any thoughts?

I think both are valid and okay, but I personally would go for the second.
The first one tells you on first sight what each chip can do. The second one tells you the differences.
From a style perspective I would go for the second one. But I think the first one is better when it comes to understanding code.

I've gone with the second option and opened a PR here (#57).

Closed by #57


Upgrade Sphinx theme to 1.11

Summary
See https://github.com/Qiskit/qiskit_sphinx_theme/releases/tag/1.11.0 for the detailed changelog.
Some highlights:

Fixed IBM fonts not loading
Left sidebar can have expandable sections
Left sidebar shows the previous versions as an expandable section now, unexpanded by default
Page table of contents on the right stays fixed when scrolling

If I remember correctly, the decision from the dev meeting was to merge this after 0.24.0rc1 is tagged hopefully on Thursday, so any possible flakiness/issues can be handled without the pre-release CI pressure.

the decision from the dev meeting was to merge this after 0.24.0rc1 is tagged hopefully on Thursday, so any possible flakiness/issues can be handled without the pre-release CI pressure.

I interpreted that as being CI flakiness? That we didn't want a theme release to accidentally break CI because, at the time, Terra was using an unpinned version of the theme.
There's no risk of CI flakiness here since the upgrade is controlled, thanks to the new version pin.
cc @mtreinish to clarify

Do we want to enable a dropdown for the contributing section? If we do decide to go for the expandable dropdown are there any other things we would like to add to the sidebar tree? For example we could turn the tutorials button into an expandable dropdown with all the tutorials listed?


Download every firmware on the server once

User story

As a developer
I want to dowload every firmware from all the vendor once
So that we have a pool of firmwares available and stored

Acceptance criteria

All vendor firmwares are succesfully downloaded
Error or error messages for the ones that couldnt be downloaded

Definition of done (DoD)

All the acceptance criteria have been met
The code has been merged with the main one
The documentation and Bill of Materials have been updated
The code is complete and uploaded in GitHub
Functionality has been reviewed

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

some vendors have issues downloading


Doesn't work with python3.12

Hello, on python3.12 doesn't work.
Problems accure at installation, github . I running on window10 with python3.12
I installed python 3.9, works with no issue
Regards

Python 3.10 on Linux works. (But a fork of TensorFlowTTS must be installed)


Validate input style based on source format

Currently there is only a minimal validation of the input style unrelated to the source format. This can lead to issues when having on matching parameter sourceFormat and content. For example when sending a JSON object and defining sourceFormat=SLD.
A more sophisticated validation based on sourceFormat  and its content should be implemented.

The described situation leads to a 400 return because the parsing of the input fails.
The only problematic situation is when the content is in a XML format and the sourceFormat is in another XML format.
For instance the input is a SLD file and the sourceFormat is set to QML. In this case the output will be an almost empty style but without any error raised (when targetFormat is different from sourceFormat). This is a really minor issues.


[Neo4j Connection] Cannot connect to a Neo4j cluster

Hi !
There is a possible improvment, when you create a configuration, you use :
"bolt://$host:$port" .
That avoid us to connect through the bolt+routing protocol (neo4j cluster).
=> I think we should let the user write the protocol in the "Host" text field and so be able to connect to a Neo4j cluster.
Example : Host  bolt+routing://host

I created a pull request : #168

Thanks for your pull request
Changes were accepted


Installation process

Hello!
Thanks for creating this project; it's rare to find a password filter with a focus on security. I have a couple of questions about the installation process:

Which registry keys should be configured? Could you give me an example of a Key and its corresponding Value?
Are there any additional steps I need to follow?
How to build the lib.rs?

I have gone through the source code and found the registry keys, but I am not sure about the values. I was able to download the database, but it seems to always tell password was compromised, without any error.
Thanks in advance.

Hi!
Thanks for your interest! It's great to see someone checking this out. Admittedly, I've gotten this to a "working" state and haven't found the help to follow through with the most difficult portions now. I still need to learn Wix to create a proper installer, and the code certainly could be cleaned up.
As for this working, there are a few things I was in the middle of recently that would most likely make it break. Optionally normalizing strings is one of those things.
Expected registry keys for this to operate:

Path (REG_SZ): A string that points to the local folder or network share path where the sled database resides to save download state.
DownloadPath (REG_SZ): A string that points to the local folder or network share path where the hashes from haveibeenpwned are downloaded to and where your custom compromised passwords are stored.
FilterPath (REG_SZ): A string that points to the local folder or network share path where the data structure files themselves are stored. This should be separate from your download path and is intended to be the DFS-replicated folder. These files would only be modified when a new download is done and hashes are updated, and even then only a few files and a few blocks within those files should realistically update, heavily reducing the bandwidth necessary to replicate.
NormalizeFlag (REG_DWORD): A 0 or 1 indicating whether to normalize a string (1) or leave it alone (0).

To build the library would just require installing Rust (available here) and performing a cargo build --release. It should produce a sediment.dll. If it doesn't I likely haven't configured the build to do so yet as I hadn't gotten there.

Thank you. Was the library working when you compiled it? It seems the exported function names are wrong and not being accepted by Windows.


Hetamap visualization

Added code to create heatmaps visualizations.
The idea is that, starting from a dictionary that maps region names -> scalar values brainrender adds all the regions to a Scene, colors them according to the scalar value and a colormap and then visualizes things. This way the regions colors are a heatmap.
For the visualization, the Scene is 'sliced' with two Plane objects to create an almost 2D visual feel (though of course the whole thing is rendered in 3D with vedo). The use can select different orientations ('frontal', 'top', 'sagittal') which specifies the orientation of the planes slicing the scene and of the camera, and specify the position of the 'slice' (along an axis that depends on the orientation) and the thickness of the slice (distance between planes).

@vigji let me know if you have time to give this a quick look!

Hey, thanks for having a look.

It is not entirely clear to me here why is there a requirement for two planes, the use cases that I can mostly think of would require an actual 2D slice no?

You need two planes to cut through to get a 2D slice.  Similarly, a single plane here cut's the brain in half so you're left with still a lot of 3D geometry. You need a second cut to get rid of it. (They way it works in vedo, when you cut with a plane all the geometry on one side of the plane is destroyed but the other side remains intact).
You could cut twice with the same plane, the first time removing what's on one side of the plane and the second time what's on the other side of the plane, but then instead of being left with a 2D slice you're left with nothing. That's why I offset the second plane slightly (like in histology, you can't do a 0um thick slice). Then you're left with something that is close to a 2D image but still has some thickness.
I know this looks different from e.g. what you'd do in matplotlib, but I kind of like the way it looks when you still have a bit of depth to it.
You can always make the spacing between the planes very small.
For the second point, I can for sure pass the coordinates of the plane, but I'm not sure what you mean exactly? The (x,y) coordinates of the regions' meshes' contours in the slicing plane? How would you use these to fill them up, and why would that be preferable?

You need two planes to cut through to get a 2D slice. [...] You can always make the spacing between the planes very small.

Now I see the point! I thought that you were somehow projecting the intersection on the slice, not cutting 3D volumes in 3D space. Maybe it would be good to have as the default the minimum value possible, and increase the thickness if you want the "slicing" feeling? I think this would be more intuitive to me!

For the second point, I can for sure pass the coordinates of the plane, but I'm not sure what you mean exactly? The (x,y) coordinates of the regions' meshes' contours in the slicing plane? How would you use these to fill them up, and why would that be preferable?

I can imagine having the coordinates in the 2D reference frame of the slice, and then use them in a separate plot. The reasons for me to want that could be:

finer control over shape appearance (I know there's a lot of customisability also in vedo, but I feel that the matplitlib fill is, if less nice maybe, entirely deterministic - see eg the thickness of the contour lines in the images of your examples), or, if not finer, just with an API I'm more familiar with parameter-wise
integration with other plots, to show the section in an insert or a subplot in a bigger panel with no illustrator work
importantly, saving it as vector format (pdf or svg), if I remember correctly this is not an option vedo offers ATM

I see, good point.
I need to think about how to do it. Vedo has some code to get the intersection of two meshes, so that might work.
Well, that gives you the 3D coordinates of where the intersection is in atlas space, then I guess we need a bit of linear algebra to project them onto the plane. I'll give it a shot I thin it would be cool to have!

Ok, I was thinking that maybe would come out of the box from vedo's functions!
If there's lot of algebra involved, maybe it's wiser to put that effort in a different PR :D
Also, if the intercept calculation can be done using a different mesh slicer (I don't know what mesh libraries might offer that), if you have to invest in the linear algebra for the projection it could even be a separate repo without the requirement of the vedo backend!

if it helps you can cut triangular meshes easily in vedo eg.
from vedo import *
s=Sphere().wireframe()
p=Grid().scale(3).triangulate()
sp=s.intersectWith(p)
print(sp.points().shape)
show(s,p, sp, axes=1)

also projecting anything on any plane is also out of the box - check out:
examples/basic/silhouette1.py
examples/basic/silhouette2.py

Awesome, vedo always has a solution! Seems like it should be relatively easy to do @vigji !

PS: reading better maybe projecting is not what you're after...

if you want to rotate the plane to make it conicide with the xy plane the follow discussion https://github.com/marcomusy/vedo/issues/561#issuecomment-996908553
to fill a closed contour in the xy plane you can use triangulate().

I think what we need is: given a plane with any orientation and an additional mesh -> get the coordinates of the intersection between the two and project them onto the plane such that in the end you're left with a set of 2D coordinates which represent the location of intersections between the mesh and plane in the plane's own coordinates system.
So I think cutting + projection or intersection + projection should do it.

a set of 2D coordinates which represent the location of intersections between the mesh and plane in the plane's own coordinates system.

cutting a sphere with a plane always gives a circle, but projecting a circle on a plane (almost) always gives an ellipse.... but you want the circle not the ellipse :)
from vedo import *
s=Sphere().wireframe()
p=Grid().scale(3).triangulate().rotateX(20).rotateY(20).z(.1)
sp=s.intersectWith(p).lw(8)
plane = Plane(pos=(2,0,2), normal=(1,0,1), sx=5).alpha(0.1)
so = sp.clone().projectOnPlane(plane).c('k').alpha(1)
show(s,p,sp,so,plane, axes=1)

So do not use projectOnPlane.
As you can see from the link above the linear algebra involved is trivial, simply use applyTransform(T) where matrix T=np.array([v0,v1,v2]), v2=np.cross(v0,v1) .

Oh it seems like I was mistaken about plane.points(), it does give the vertices of the plane which I can use to get the vectors I need. This works:
    pts = plane.points() - plane.points()[0]
    v = pts[1] / np.linalg.norm(pts[1])
    w = pts[2] / np.linalg.norm(pts[2])

    M = np.vstack([v, w]).T  # 3 x 2

    projected = {}
    for n, actor in enumerate(regions_actors):
        # get region/plane intersection points
        intersection = plane.intersectWith(actor._mesh).points() # points: (N x 3)
        projected[actor.name] = intersection @ M

    return projected

but I can't control the orientation of the vectors. E.g. this image is upside down compared to how it should look like:

Btw, @marcomusy  what's the easiest way to get a camera that faces an arbitrary plane (i.e. it's orthogonal to it)?
@vigji  is the output above what you had in mind? Can you share code on how to use it to make nice plots in matplotlib?

i guess it depends on how you send [u,w] to [(0,1),(1,0)], flipping them should flip the image.

Btw, @marcomusy what's the easiest way to get a camera that faces an arbitrary plane (i.e. it's orthogonal to it)?

you need to prescribe camera=dict(pos=(....), focalPoint=(....))

@vigji is the output above what you had in mind? Can you share code on how to use it to make nice plots in matplotlib?

I don't have anything particularly fancy, I just use plt.fill(contour_x, contour_y) to outline the brains in my plot, or with a facecolor color-coding for different regions!

Mmm, I'm not sure that this will work:

It seems that it expects the points to be in order, and I guess separate sets of points for the left/right halves of each region...
I'm happy to have it export the coordinates, but I'm not sure of how much use it would be unless we come up with a way to sort the points?

:D I love this abstract art!
Absolutely, that is essential, never consider it as I was getting the points in order with the slicing function I was using...maybe there's a quick way of sorting the points by euclidean distance to each other?

Lol.
I think sorting could work, an alternative is fitting a piecewise linear curve to the points (or a spline). I actually have some Julia code for this so it would be easy enough to implement. The only difficulty is in dealing with meshes that are separate (e.g., the two halves between L/R hemispheres).
I'm starting to think that this might become something a bit too involved to be contained within brainrender. It might be best to have it as a small separate package? I see it as:

use brainrender/vedo to slice atlas/regions with a plane at arbitrary orientation
get the coordinates of each meshes' slice for post hoc analysis
either use brainrender to create a visualization or a matplotlib one, with nicely defined presets etc.

This way also brainrender wouldn't have matplotlib as a dependency and it wouldn't have to include the code for sorting/cleaning these points stuff.

Yes, I agree!

Okay, moved development to: https://github.com/brainglobe/bg-heatmaps

Probably adding .join(reset-True) to line helps in ordering the points.

At the cost of sounding repetitive:

Awesome, vedo always has a solution!

The trick was to split the plane/mesh intersection by connectivity and then do the join operation.
@marcomusy  vedo is truly an amazing library, it's really incredible the ammount of work you've put into it.
I really hope you'll get all the credit you deserve for it!
    for n, actor in enumerate(regions_actors):
        # get region/plane intersection
        intersection = plane.intersectWith(
            actor._mesh.triangulate()
        )  # points: (N x 3)

        if not intersection.points().shape[0]:
            continue  # no intersection

        pieces = intersection.splitByConnectivity()
        for piece_n, piece in enumerate(pieces):

            # sort coordinates
            points = piece.join(reset=True).points()

            projected[actor.name + f'_segment_{piece_n}'] = points @ M

@vigji  we're almost there! I just need to clean up the code a bit so that the users can customize the renders/plots appearance. With the plot being upside down I'm not sure what we can do since what is 'up' will depend on the atlas orientation, how the cutting planes were defined etc... I guess maybe we can provide pre-defined transformations e.g. to rotate all coordinates by an angle, or mirror across one axis etc...

With the plot being upside down I'm not sure what we can do

What if you change to:
w = -pts[2] / np.linalg.norm(pts[2])

This is amazing! Great job with the library @marcomusy :)
What I was thinking about though is just a function for the user to get the coordinates though! You can have a tutorial on how to use it, but I don't think that the matplotlib plotting part should be handled by you, there you enter the domain of something most users will be very familiar with and will want to customise by themselves in any way.

@vigji we're almost there! I just need to clean up the code a bit so that the users can customize the renders/plots appearance. With the plot being upside down I'm not sure what we can do since what is 'up' will depend on the atlas orientation, how the cutting planes were defined etc... I guess maybe we can provide pre-defined transformations e.g. to rotate all coordinates by an angle, or mirror across one axis etc...

I think we just need to ensure a consistent behavior for the 3 standard views, and a reasonable interface for the user to specify a custom new slicing.
Maybe passing min n=3 3D coordinates that get interpolated to define the edges of the slicing plane? Then the user can reorient it in full and fix the potential upside-down projection themselves just by inverting the order of the points.
I'm thinking about the coordinates as to me they are a good way for a user to represent of the plane cutting the volume. Specifying manually angles and offsets I think would produce endless tinkering and adjustment for the slicing plane to cut through the regions you are interested. With coordinated you get very fine control over where the plane is cutting

@marcomusy  that works, brilliant!
Btw, are you on twitter? I'd like to give you a shoutout for all the help when this is released

I do not have twitter... maybe I should :)

You should! I'll still thank you and vedo for being awesome ;)


Looks like v3.51 broke LinuxVirtualMachine

The upgrade to v2.51.0 of the AzureRM Terraform Provider (#854) added a new property PlatformFaultDomain:
https://github.com/pulumi/pulumi-azure/blob/b2481d61664a2227e512e8bb6d2d8a5a0e1bfa4f/sdk/dotnet/Compute/LinuxVirtualMachine.cs#L545-L549
This update seems to have borked Pulumi.Azure with the following error:

error: azure:compute/linuxVirtualMachine:LinuxVirtualMachine resource 'srm-dev-docker-vm' has a problem: "platform_fault_domain": all of platform_fault_domain,virtual_machine_scale_set_id must be specified

Both of those properties should be optional for LinuxVirtualMachine. We've tried setting PlatformFaultDomain to its default value (-1), but it still fails. We don't want to have to add a scale set just to please Pulumi 😝
I noticed in the azurerm PR that the platform_fault_domain is RequiredWith: []string{"virtual_machine_scale_set_id"}, but we haven't specified any of them in the stack.
// @stack72

Hey @khellang actually the default value of -1 in the terraform provider is a workaround because in the API the default value of this property platformFaultDomain is null which means that Azure will assign a platformFaultDomain automatically for you. But terraform schema does not support null and 0 is a legal input for this property, we have to use -1 as its default value to emphasize this.

@ArcturusZhang Right, that's fine, but for some reason, the introduction of this property (at either terraform or Pulumi level) fails validation of linuxVirtualMachine when none of the (optional) properties have been set, or when only platformFaultDomain has been set to -1.
Judging by the error message, it seems this validation fails at the terraform level, which leads me to believe that the Pulumi terraform bridge passes some invalid data down 🤷🏻♂

Getting the same thing on Azure.Compute.WindowsVirtualMachine
using Pulumi.Azure 3.53.0
I see giving a
PlatformFaultDomain = 1
still gives the same problem
error: azure:compute/windowsVirtualMachine:WindowsVirtualMachine resource 'jumpVM-zga' has a problem: "platform_fault_domain": all of platform_fault_domain,virtual_machine_scale_set_id must be specified

Yeah, anyone using WindowsVirtualMachine or LinuxVirtualMachine with Pulumi.Azure v3.51.0 and above is broken by this. The only solution (that we've found) is to downgrade to v3.50.0 😞

thanks for the quick answer at least I can get back to work... might want to drop the stable version in the nuget repo, that problem will probably scare a lot of newbies
dotnet add package Pulumi.Azure -v 3.50.0

Chiming in on this. We are encountering this problem as well.
    "dependencies": {
        "@pulumi/azure": "3.50.0", // <-- sadness
        "@pulumi/pulumi": "^2.17.0"
    }

.. is unfortunately our fix.

I have just tried with:

pulumi: 3.0.0
pulumi_azure: 4.0.0
still:

 error: azure:compute/linuxVirtualMachine:LinuxVirtualMachine resource 'jumpVM' has a problem: "platform_fault_domain": all of `platform_fault_domain,virtual_machine_scale_set_id` must be specified

It's kinda worrying that nothing's done about this. Seems like a blocker that no one are able to use virtual machines on Azure above v3.50.
Is this considered legacy? Are everyone focused on the new native Azure provider? I wish I could send a PR to fix this, but honestly I don't even know where to start 😅

@khellang et al - I am super sorry I've not been able to get to this - I promise I will start looking tomorrow (now that the major work I was finishing is taken care of!)
This is definitely NOT a legacy provider

Sorry for bring this up again, but this bug is an hard blocker for using pulumi 3 and any other latest pulumi provider.

Hi folks
I just brought this issue to "in progress" state! I am looking through to try and get a fix in place
P.

Ok folks, I just opened a pull request that fixes this bug - as soon as it's green, I will get a patch of the provider cut!


Enhance guidance regarding the form component re placeholder text and helper text

What the current guidance states:
For reference, here is the current Carbon form guidance has to say about helper text and placeholder text:

From the "Formatting" section (link):

Helper text: Provides assistance on how to fill out a field. Helper text is optional.
Placeholder text: Hints at what goes into a field. Placeholder text is optional.

From the "Content" section (link):

Helper text
Helper text is pertinent information that assists the user in completing a field. Helper text is always available when the input is focused and appears underneath the label. Use sentence-style capitalization, and in most cases, write the text as full sentences with punctuation.

Placeholder text
Placeholder text provides hints or examples of what to enter. Placeholder text disappears after the user begins entering data into the Input and should not contain crucial information. Use sentence-style capitalization, and in most cases, write the text as a direct statement without punctuation.

Summary
What this issue relates to:

The Carbon form component — and specifically the guidance re helper text and placeholder text.

Who is providing this feedback:

Tom Waterton, on behalf of the Cloud & Cognitive org Design System Adoption Guild (DSAG).

Why we're raising this issue:

We are seeing a lot of inconsistency across products in terms of how form field helper text and placeholder text is being used.
We think that if the form component contained a bit more guidance, this will help teams produce more consistent forms.

Relevant information
Our understanding of your guidance as it stands today:
With regard to helper text and placeholder text, it seems that the current guidance allows teams to build form fields where:

the form field has both helper text and placeholder text
the form field has helper text but not placeholder text
the form field has placeholder text but not helper text
the form field has neither helper text nor placeholder text

This seems reasonable, as it accounts for different scenarios and needs.
However, we are seeing instances that don't strictly comply with any of the above 4 approaches, so we thought we would bring these to your attention to see if some further guidance can be provided.
Issue 1: People using placeholder text when they should be using helper text.
Reading your guidelines, it seems that helper text is intended for additional information to help the user know how to fill in the field (and this is always available), whereas the placeholder text is more intended for an example (and this disappears when the user starts entering data into the input field).
What we understand to be a correct example:

Phone number — field label
[ e.g. 44 7777 1234567 ] — form input field, with placeholder text providing an example (disappears when the user starts entering data in the input field)
Prefix your phone number with the relevant country calling code. — helper text (always present)

But we fairly often see form fields where people have chosen not to use helper text at all, and have instead used the placeholder text to provide additional information about how to complete the field.
Example 1a:

Phone number — field label
[ Prefix your phone number with the relevant country calling code. ] — instructional help entered (incorrectly according to your current guidance) as placeholder text

Example 1b:

It is likely that some teams do this because the placeholder text option (which sits within the field) requires no additional space in the form, whereas the helper text site below the inout field and therefore takes up additional space in the form.
If you think this is acceptable, then it would be good to update the current guidance to reflect this.
If, on the other hand, you don't want people to use placeholder text in this way, then it would be good to explicitly state this.
Issue 2: People adding helper text that is not needed / adds no value
Another issue we see regularly is where teams add placeholder text that merely repeats the field label and therefore adds no value.
Example 2a:

Email address — field label
[ Add your email address ] — placeholder text has been added but adds no value

Example 2b:

Therefore, it would be good if your guidance explicitly said not to do this (i.e. if the field label alone is sufficient, you don't need to add placeholder text or helper text — even if other fields within the same form do require helper text or placeholder text).
Issue 3: People using tooltips to contain help information
Sometimes, when teams do need to provide the user with additional help text, they are choosing to add an information (i) hover-help icon next to the field label or making the field label itself a definition tooltip.
Example 3a:

Phone number (i)  — field label with an info tooltip icon
[                                          ] — empty input field

Example 3b:

Phone number   — field label that has been made into a definition tooltip
[                                          ] — empty input field

We assume that this is not what you intend teams to do and that in such cases, teams should be using helper text to show the additional information below the form input field? If so, it would be helpful if you covered this explicitly in the guidance.

+1 to this issue - actively hitting this discussion every release of our products. Please can we get clearer guidance.

Agreed—our product consistently encounters issues and inconsistencies with placeholder/helper text in form design.
There could also be some additional clarification on how "info icon" tooltips intersects with helper text. Our product often leans on these "info icon" tooltips to convey information that I expect would be better handled as helper text...so it would be great to get clearer guidance on the do's and don'ts of placeholder text, helper text, and info tooltips.

Update were made to improve this guidance on the form page. I added updates into an existing PR open concerning the form component page but it is currently in a staging branch and should be public soon.


fixed AvoidingInjection.md

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

please reopen with a proper target branch


OCPBUGS-37543: pkg/storage/azure: do not retry remove storage operation

Previous to commit 472515d, RemoveStorage never triggered a retry. After removing storage account key usage for workload identity enabled clusters (OCPBUGS-37543), a failed container deletion (caused by a 404) would trigger a retry (which is not a full reconcile in this case, since the operator CR does not get updated), and would cause a permanent AccountNotFound error.
/assign @rajdeepc2792
Holding until QE has verified this fix works.
/hold

Closing this - we'll revert the original change instead and get a fix in a follow-up PR.

/close


[SPEC ONLY]: Binary options (nebula stretch)

Superseded by https://github.com/vegaprotocol/specs/issues/2230


linux: add aarch64_ilp32 support.

This patch adds aarch64 (arm64) ILP32 support by using
the proper syscalls for sys_fcntl(), sys_fstat(), sys_lseek()
and sys_mmap().
Signed-off-by: Christoph Müllner<EMAIL_ADDRESS>

I think this patch needs some further information:
aarch64 (arm64) uses a LP64 ABI by default, but also offers a ILP32 ABI (similar to x86_64 and x32).
One of the benefits of aarch64_ilp32 is the potential performance benefit (e.g. pointer chasing workloads).
Using ILP32's performance benefits in combination with gperftools to further improve execution times
was the main motivation for this patch.
Details for ILP32 can be found here:
https://wiki.linaro.org/Platform/arm64-ilp32
https://wiki.debian.org/Arm64ilp32Port
https://wiki.leapproject.ca/index.php?title=Main_Page

Applied. Thanks.


Add creation date to project files/folders

We were not able to completely implement every Projects feature we wanted before getting it merged to dev yesterday.
This issue tracks adding the creation date to files and folders within a project so you can see and sort them in the project items table.

File creation date added in 3.6.4804-dev

Unsure if we want folder creation date, since that's not even tracked on the server right now


Showing provenance of conflicting constraints in pip-compile

Thanks for the great tool. I use pip-compile to manage a large production Python environment, and one of the main pain-points I've found is that when an upstream change leads to a conflict, it can often be quite difficult to ascertain the cause of the failure.
For example, consider the following requirements.in file, which in my case can have several dozen listed dependencies:
# requirements.in
# ... several dozen packages
google-cloud-bigquery~=1.14.0
# ... several dozen more packages
tensorflow-data-validation~=0.13.1
# ... several dozen more packages

If you run this through pip compile, it finds a conflict:
$ python -m piptools compile requirements.in
Could not find a version that matches google-cloud-bigquery<1.7.0,>=1.6.0,~=1.14.0
Tried: 0.20.0, 0.20.0, 0.21.0, 0.21.0, 0.22.0, 0.22.0, 0.22.1, 0.22.1, 0.23.0, 0.23.0, 0.24.0, 0.24.0, 0.25.0, 0.25.0, 0.26.0, 0.26.0, 0.27.0, 0.27.0, 0.28.0, 0.28.0, 0.29.0, 0.29.0, 0.30.0, 0.30.0, 0.31.0, 0.31.0, 0.32.0, 0.32.0, 1.0.0, 1.0.0, 1.1.0, 1.1.0, 1.2.0, 1.2.0, 1.3.0, 1.3.0, 1.4.0, 1.4.0, 1.5.0, 1.5.0, 1.5.1, 1.5.1, 1.6.0, 1.6.0, 1.6.1, 1.6.1, 1.7.0, 1.7.0, 1.8.0, 1.8.0, 1.8.1, 1.8.1, 1.9.0, 1.9.0, 1.10.0, 1.10.0, 1.11.1, 1.11.1, 1.11.2, 1.11.2, 1.11.3, 1.11.3, 1.12.0, 1.12.0, 1.12.1, 1.12.1, 1.13.0, 1.13.0, 1.14.0, 1.14.0, 1.15.0, 1.15.0
There are incompatible versions in the resolved dependencies.

but this error contains no information about the provenance of the conflicting constraints, and so it is not much help in ascertaining the cause of the conflict.
I have a partial solution to this in https://github.com/jakevdp/pip-tools/commit/c33cafc69552dfaef1b730e864897b26ea74068a; it works by propagating combined comes_from metadata as a string in the combined constraints. The result for the above requirements looks like this:
$ python -m piptools compile requirements.in
Could not find a version that matches google-cloud-bigquery<1.7.0,>=1.6.0,~=1.14.0 (from apache-beam[gcp]==2.13.0->tensorflow-data-validation==0.13.1->-r requirements.in (line 5), -r requirements.in (line 3))
Tried: 0.20.0, 0.20.0, 0.21.0, 0.21.0, 0.22.0, 0.22.0, 0.22.1, 0.22.1, 0.23.0, 0.23.0, 0.24.0, 0.24.0, 0.25.0, 0.25.0, 0.26.0, 0.26.0, 0.27.0, 0.27.0, 0.28.0, 0.28.0, 0.29.0, 0.29.0, 0.30.0, 0.30.0, 0.31.0, 0.31.0, 0.32.0, 0.32.0, 1.0.0, 1.0.0, 1.1.0, 1.1.0, 1.2.0, 1.2.0, 1.3.0, 1.3.0, 1.4.0, 1.4.0, 1.5.0, 1.5.0, 1.5.1, 1.5.1, 1.6.0, 1.6.0, 1.6.1, 1.6.1, 1.7.0, 1.7.0, 1.8.0, 1.8.0, 1.8.1, 1.8.1, 1.9.0, 1.9.0, 1.10.0, 1.10.0, 1.11.1, 1.11.1, 1.11.2, 1.11.2, 1.11.3, 1.11.3, 1.12.0, 1.12.0, 1.12.1, 1.12.1, 1.13.0, 1.13.0, 1.14.0, 1.14.0, 1.15.0, 1.15.0
There are incompatible versions in the resolved dependencies.

It's not perfect or pretty, but it makes debugging these kinds of dependency conflicts much easier.
My solution is admittedly a bit of a hack (which is why this is an issue rather than a pull request) but I was wondering if there are better solutions I am overlooking, or if you'd be open to a contribution along these lines if I put in some effort to clean up my approach.
Thanks!

Hello @jakevdp,
Thanks for raising this issue! I would love to see this feature in pip-tools. Anyways, don't hesitate to shoot a "WIP" PR. I hope we can implement it cooperatively.

Put together a prototype in #837, with some improvements over my initial approach.


Only import BindingType on cfg debug assertions

Objective
Fix this warning
warning: unused import: `BindingType`
  --> ...bevy/crates/bevy_pbr/src/render/mesh_view_bindings.rs:23:88
   |
23 |         BindGroup, BindGroupLayout, BindGroupLayoutEntry, BindGroupLayoutEntryBuilder, BindingType,
   |                                                                                ^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Solution

It's only referenced when cfg debug assertions, so only import it under the same cfg

Instead of this PR, can you please replace the import with:
render_resource::{binding_types::*, *}

Instead of this PR, can you please replace the import with: render_resource::{binding_types::*, *}

Clever, replaced PR with your suggestion.


I got empty result while using 7b-it model

I use WSL2 on Windows 11 to run gemma_pytorch. The device is i9-13900 + RTX A6000 and I use the 7b-it model. But When I try to run the Gemma interface, I always get an empty result. What might be the reason and how can I solve it?
/opt/conda/lib/python3.10/site-packages/torch/_utils.py:831: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
  return self.fget.__get__(instance, owner)()
Model loading done
======================================
PROMPT: The meaning of life is
RESULT:
======================================

@egbertwong could you please provide the command you used to reproduce this?

@egbertwong could you please provide the command you used to reproduce this?

Hi, thanks for your reply! I just follow the steps in the README file. And I also write my commands down here:
VARIANT=7b
CKPT_PATH=/mnt/d/Code/gemma/gemma-7b-pytorch/gemma-7b-it-quant.ckpt

sudo usermod -aG docker $USER
newgrp docker

DOCKER_URI=gemma:${USER}

docker build -f docker/Dockerfile ./ -t ${DOCKER_URI}

PROMPT="The meaning of life is"

docker run -t --rm \
    --gpus all \
    -v ${CKPT_PATH}:/tmp/ckpt \
    ${DOCKER_URI} \
    python scripts/run.py \
    --device=cuda \
    --ckpt=/tmp/ckpt \
    --variant="${VARIANT}" \
    --prompt="${PROMPT}"

It seems you are using quantized checkpoint, please make sure that you also add --quant  in the command. I think it should work.


Special characters in database user password

During the initial installation, when I specified "4,BaR~!<q^m9" as the password, I was unable to connect to the database. I got an "Access denied to dbuser@localhost - DB not connected" error. On changing to a password with only alphanumeric characters, the installation proceeded normally.
Is this behavior normal and to be expected?
I am running mariadb 10.1.17 and php 7.0.10

The angle char was escaped as an XSS defense; though it is probably not needed on the setup screen. Should be fixed in current dev.

I have finished my installation using an alphanumeric password. I haven't verified whether this bug has been fixed in the dev branch. But, if you are reasonably confident, do feel free to close this issue. Thanks.

I'm very confident. Still I'll leave this open for say a month so that we know it hasn't actually been tested and we really should do this.

Glad I checked - there was still an issue. Now tested and confirmed working.


SyntaxError on basic model – syntax parsing seems to be broken for 'model'

With the latest release v0.2.23, getting a syntax error on the first line with model – this seems to be broken. This was working in the v0.2.22 release.

Thanks for the heads up @rakeshrm - we're releasing v0.2.24 shortly with a fix

Apologies for the issue here @rakeshrm, v0.2.24 has just been published and VS Code should auto-update soon.

Thanks for a lighting fast response and fix @ewanharris @rhamzeh


Adds CloudinaryImage(s) fixes, video support (beta), select (beta), opinionated enhancements. #832, #3504, #2699

Description of changes
CloudinaryImage(s) fixes, video support (beta), select (beta), opinionated enhancements.
Fixes folder support for CloudinaryImages. Previously only worked with single image.
*This PR has outgrown its original purpose... they grow up so fast 😉 *

[x] Adds autoCleanup support to CloudinaryImage(s)
[x] Adds public_id format and resource_type to CloudinaryImages lightbox
[x] Adds the etag property, which is the MD5 generated by Cloudinary on upload. Useful for local file comparisons.
[x] Adds select functionality, allowing for choosing remote Cloudinary Images

[x] Update select's UI with preview images
[ ] Support CloudinaryImages (plural)
[x] Currently shows "sibling" uploaded media with prefix format:
[cloudinary prefix]/[list path]/[field path]/

[x] Adds video upload/preview support (beta) to CloudinaryImage

[x] Allow and support video uploads
[x] Generate video thumbnails in admin
[x] Adds video icon to thumbnails in admin
[ ] Support videos in CloudinaryImages (plural) as well
[ ] Allow video playback in admin
[ ] Handle video use cases for templates (I only needed uploads for time being)

Questions
Am I wasting my time? 🌳🔨
Should we refactor CloudinaryImage(s) to work as one field type instead of two?
Rename field to something like CloudinaryUpload || CloudinaryMedia || Cloudinary?
Screenshots
Supports a mixing of images and video:

Supports upload or selecting from Cloudinary:

Adds image previews, file-types, and paths to dropdown:

Supports metadata in lightbox caption:

Adds "open original" button to lightbox:

Related issues (if any)
#832
#3504
#2699
Testing

[x] Please confirm npm run test-all ran successfully.

I don't think I'm missing anything here but I haven't looked at the 4.x codebase for a bit so while it should be a simple fix, maybe just look it over.

I just realized that Cloudinary might be getting replaced by the Storage API... is that correct? Are 4.x changes needed to Cloudinary types?

Just added support (without trying to change too much) for autoCleanup removal of single and multiple images.

On another note, I would like to integrate video upload support to this as well, as Cloudinary now supports it.

@JedWatson I've started to add video upload support as well. There aren't THAT many changes to make this work but it does complicate this pull-request a tad. Let me know if you'd like me to handle this a different way. My internal thought was to add video support (behind the scenes) and then maybe later we could do a refactor of CloudinaryImages to something like CloudinaryUpload and try to get it to handle "all the things". I've got a project I'm trying to use this with ASAP hence me throwing these things together, but I'd be down to refactor later. It'd be nice to remove the need for 2 field types.

Is this already merged? I just stumbled over this Issue since the autoCleanup of the CloudinaryImage is currently not working in the latest version. I'm quite new to Keystone but after looking at the code and testing I found that the value is never 'remove' in CloudinaryImageType.js.

Hey @JedWatson, just checking in to see that these changes are still on track. I'm hoping to have select up and running today. Tired of having so many duplicates in Cloudinary ;)

@JedWatson Added select functionality to CloudinaryImage and UI updates, take a look!

Is this still in review?

Going to add this to our new PR statuses project, and assign it to someone to look through.

@Noviny Awesome Ben! I am using this/my branch in a few production (low traffic) projects so after making the changes I needed this PR got a little out of hand and some it might be too "opinionated" about how it handles things. I think ultimately it would be best to refactor the entire CloudinaryImage(s) type into a single type like "Cloudinary" or "CloudinaryMedia" since I've been using it to handle documents/images/videos. I would be happy to work on that once I know you guys are on board with that direction or if another implementation would be better. Let me know. Thanks!

@danielmahon its inspiring that you're still improving this pr. I'm sure it'll be merged soon!

@danielmahon Thanks, save my day!


tlcgroup.com contact form agreement text hyper link

Hi Team,

Please make the bold term and Privacy Policy.
Contact form submission fail error in the first attempt.  Accepts in the second submission.

Contact form leads details automatic drop on Email Id,
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Contact form validation missing checkbox.

@2016DigiTech Please use separate issues for different matters.

is a simple CSS change. you can make this in form.css
Duplicate of #95
Duplicate of #97
What do you mean by that? If you mean the recaptcha, this is the new v3 which does automatic human verification. It only asks for user interaction in rare cases.


sphinx documentation on Collection object

Here is the requested sphinx docs on the proposed collection (see issue #138).  Please DO NOT merge this, at this stage it is simply a proposal for what could be done.

I guess we can close this. Since it was a proposal for discussion and it was anterior to new apibreak branch of Andrew.


Hashicorp Vault Operator

Explore / POC how vault will provide securing of secrets within kubernetes for other pods to consume.

New ticket #1889 raised for next steps.


Failed ES UpdateAdvancedVisibility

When I've tried to run temporal, I've got this erorr
Can't do Elasticsearch schema upgrade for no-following version numbers. (eg. from v1 to v2, but not from v1 to v3)
Base on temporal.io index_template_v7.json, service got v4
But, as I understand, the service doesn't have config for v4
https://github.com/alexandrevilain/temporal-operator/blob/dfeaac2787208f72aae5ca39002ff248417741a4/internal/resource/persistence/template.go#L83

Hi @DodgeCamaro !
Thanks for reporting this issue, you're right v4 is not supported.
PR #360 fixes it!
I'll try to release 1.13.0 this week-end or next week. It will ship with this fix and huge reconciliation improvements. I'll ping you on this issue once done.

Hi @DodgeCamaro !
0.13.0 is now released with ES schema fix :)


[gardening] pkg/dds/test/devtools_server/instance_reuse_test flaky

The tests
pkg/dds/test/devtools_server/instance_reuse_test Timeout (expected Pass)

are failing on configurations
unittest-asserts-debug-linux

The test history is showing it toggling between passing/flaky/timout.
Filing issue to point to.

another failure https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-linux-release/29813/overview


hash in ssh_config value cause truncate

the ssh config  as follow:
Host wap1 # there is a proxy available for this one...
    UserKnownHostsFile /dev/null
    StrictHostKeyChecking no
    Port 22
    User user_name
    IdentityFile path_to_private_key
    ProxyCommand ncat --proxy-type socks5 --proxy-auth 'user_name:pwd@#123_^&*' --proxy proxy_ip:proxy_port %h %p

value after '#' in line of ProxyCommand will be truncate. more detail can refer following links:
https://github.com/trzsz/ssh_config/pull/2

@lonnywong plz help

@warjiang Does openssh work properly?

@warjiang Does openssh work properly?

Yeah, it works

openssh supports # without ' and ":
Host test
    LocalCommand echo Hello# World
    PermitLocalCommand yes

Need to study how openssh does it. But I've been busy recently.

@lonnywong
First i should admit that i have little knowledge of openssh, even bunch of knowledge came from daily usage 🤣 .
May be it's not right time to talk further, you can recheck this when you are free. Feel free to review it 😄 .
What i want to express is that, the ssh_config pkg cannot parse # char in side string literal.
The test code as follow:
func main() {
	configData := `Host test
    LocalCommand echo Hello'#' World
    PermitLocalCommand yes`
	cfg, err := ssh_config.Decode(strings.NewReader(configData))
	if err != nil {
		panic(err)
	}
	v, err := cfg.Get("test", "LocalCommand")
	if err != nil {
		panic(err)
	}
	debug("value is %s", v)
}

before fixed:

after fixed:

Apart from that, i've tested in openssh client, i mock a ssh config file like following:
Host wap1
    LocalCommand echo Hello# World 'test' "test"
    PermitLocalCommand yes

it's equla to command echo Hello'#' World no echo Hello'

@warjiang How about we make some changes like this:
Host comment
    Key1 = Value1 # This is part of the value, not a comment
    Key2   Value2 # This is a comment, not part of the value

The value of Key1 is Value1 # This is part of the value, not a comment. And the value of Key2 is Value2.

@warjiang How about we make some changes like this:
Host comment
    Key1 = Value1 # This is part of the value, not a comment
    Key2   Value2 # This is a comment, not part of the value

The value of Key1 is Value1 # This is part of the value, not a comment. And the value of Key2 is Value2.

we should distinguish scene of #

# in side single quote or doule quote
in this case, # should be treated as a common literal
# not   in side single quote or doule quote
in this case, # should be treated as grammar of comment

so @lonnywong  should change code as following, if you want # as part of value
Host comment
    Key1 = 'Value1 # This is part of the value, not a comment'
    Key2   Value2 # This is a comment, not part of the value

It's not clear whether the value 'Value1 # This is part of the value, not a comment' contains single quotes or not.
I think = means there is no comment at the end, which is simple and easy to distinguish. It's not exactly the same as openssh, but it's worth it.

i've made serval test-case it in my local enviroment
Host wap
    LocalCommand = echo Value1 # This is part of the value, not a comment
    PermitLocalCommand yes

Host wap
    LocalCommand echo Value1 # This is part of the value, not a comment
    PermitLocalCommand yes

Conculsion: whether use equal sign, it turns out the same effect.

if wrap # with single quote as follow:
Host wap
    LocalCommand echo 'Value1 # This is part of the value, not a comment'
    PermitLocalCommand yes

I mean we change the code to do that.

It's not clear whether the value 'Value1 # This is part of the value, not a comment' contains single quotes or not.
I think = means there is no comment at the end, which is simple and easy to distinguish. It's not exactly the same as openssh, but it's worth it.

maybe you are right, but it will casued some extra knowledge of another version of ssh config (like config of tssh) 😆 .

I mean we change the code to do that.

i can try it, but maybe we can use option to let user to choose whehter enable this feature.

how about another im tools like wechat or tg? may be we can talk it for further.  the work under trzsz is very useful for me,  maybe i can take part in these project in deep. 🤔

i can try it, but maybe we can use option to let user to choose whehter enable this feature.

I think most people will not use = in ssh config, even fewer use = and add comments at the end of the line.
We just need to document the new features of = in the new version.

how about another im tools like wechat or tg? may be we can talk it for further. the work under trzsz is very useful for me, maybe i can take part in these project in deep. 🤔

There's a QQ group at the bottom of README.

I think most people will not use = in ssh config, even fewer use = and add comments at the end of the line.
We just need to document the new features of = in the new version.

that's true~ i'll try it later 🔧

I've implemented this feature by add lexRReservedvalue state. After detect equal, it will go to state of checking lexRReservedvalue.

I've implemented this feature by add lexRReservedvalue state. After detect equal, it will go to state of checking lexRReservedvalue.

for the ssh config as following:
Host comment
    Key1 = Value1 # This is part of the value, not a comment
    Key2   Value2 # This is a comment, not part of the value

the test case like following:

I will write the documentation and update it this weekend.

done https://github.com/trzsz/trzsz-ssh/commit/a6c64a61aefa33c74d5ec7bdd6b211ec2713ce81


Possibility to avoid properties processor execution was provided

@brutskov I'll merge this one but please create a ticket under carina-api to find better solution which will not need you to ignore some properties processors in similar cases.


Implement the use of exclamation points to describe breaking changes

According to https://www.conventionalcommits.org/en/v1.0.0/ , a breaking change can be described by using an exclamation point. Here are three cases that will generate the same major version bump and the same breaking change message.
Case 1 :
feat!: completely change this behavior

Case 2 :
feat(versioning)!: completely change this behavior

Case 3 :
feat!: update the parser for commits

BREAKING CHANGE: completely change this behavior

The exclamation point is optional, and if used, is just before the colon.
If there is an exclamation point, the BREAKING CHANGE section is optional, and the commit message will be used as breaking change description.

Additionaly, since this would change the regex, I'm wondering if the first ?: at the beginning of the "scope" line is necessary, since the colon is always supposed to be after the scope.

This would be nice 👍
The ?: at the beginning of the scope line is to make sure it is not selected as a group with the parenthesis.

I'm not 100% sure about this, but testing a bit on regex 101, it looks like the colon is selected differently, but since we have clear named groups and we don't use anything but those named groups, it looks OK.
I've just tested quickly, it looks like no tests break. Do you have awareness of a case in which it would break ? I've only tested basic commit messages with the folloxing regexes :
(?P<type>fix|feat|chore)(?:\((?P<scope>[^\n]+)\))?: (?P<subject>[^\n]+)(:?\n\n(?P<text>.+))?
(?P<type>fix|feat|chore)(\((?P<scope>[^\n]+)\))?: (?P<subject>[^\n]+)(:?\n\n(?P<text>.+))?

With
chore(potato): doing some stuff
chore: doing some potato stuff

I think that should be fine

NVM, I just didn't understand "non capturing groups" well. It can be removed, but keeping it in is maybe clearer since we have capturing and non-capturing.

Yes, I don't think it matter much if they are there or not since we use named groups.


perf: TestChannel nonce is incrementing, not random

A recent change #3152 caused the tests on master to fail with jest timeouts. My hypothesis is that the change introduced some inefficient code, namely generation of random integers, which made the difference for the timeouts.
This PR swaps out a random nonce for an incrementing nonce approach, which should be faster.

Why do you hypothesize that generating a random nonce is inefficient?

Why do you hypothesize that generating a random nonce is inefficient?

Why do you hypothesize that generating a random nonce is inefficient?

Mainly i) the observed failures on master with the random nonce change included and lack thereof on this branch and ii) a little bit of googling about javascript being pretty slow at generating random integers.
On the other side, we aren't generating many random integers, so even if JS is "slow" I would not have expected it to have much of an effect. And I will admit we don't really have compelling evidence that the hypothesis is true :-P
However, the incrementing nonce seems like a better approach anyway . And on the small amount of evidence we have, it seems empirically better, too (whether that has anything to do with the hypothesis, IDK).

Why do you hypothesize that generating a random nonce is inefficient?

Mainly i) the observed failures on master with the random nonce change included and lack thereof on this branch and ii) a little bit of googling about javascript being pretty slow at generating random integers.
On the other side, we aren't generating many random integers, so even if JS is "slow" I would not have expected it to have much of an effect. And I will admit we don't really have compelling evidence that the hypothesis is true :-P
However, the incrementing nonce seems like a better approach anyway . And on the small amount of evidence we have, it seems empirically better, too (whether that has anything to do with the hypothesis, IDK).

❯ node __tests__/foo.js
randomly generate 1000000 numbers: 132.029ms

I agree that incrementing the nonce is better anyway. I would refrain from assuming that generating random nonces would cause timeouts by hogging CPU.

❯ node __tests__/foo.js
randomly generate 1000000 numbers: 132.029ms

I agree that incrementing the nonce is better anyway. I would refrain from assuming that generating random nonces would cause timeouts by hogging CPU.


Typo in Documentation

in the curl instruction - there is an extra ' in:

curl --request GET https://[your-customer-id].queue-it.net/status/integrationconfig/secure/[your-customer-id]' --header 'api-key: [Customer API-Key]' --header 'Host: queue-it.net'

This was already reported on the LUA repo here, so it might be worth reviewing all the KU repositories as it seems like a copy&paste error.

Thanks, we will go through all the repos documentation


Invalid documentation for NewHashPartitioner

Sarama Version: v1.10
https://godoc.org/gopkg.in/Shopify/sarama.v1#NewHashPartitioner says:

If the message's key is nil, or fails to encode, then a random partition is chosen.

But code actually returns -1 in case of encoding error, which results in ErrInvalidPartition.

It actually returns -1 and the encoding error, so the producer should just pass along the encoding error rather than trying to treat the -1 as a partition (https://github.com/Shopify/sarama/blob/9bb4a68d57ff6f623363aa172f0a8297aa289ba7/async_producer.go#L346-L349). The behaviour makes sense as-is, I will fix the documentation.
Thanks for the report!


add the RegexPriority field to the routes list

Is it possible to add the RegexPriority field to the routes list? this will be fine for multiple rules.

已fork


Question: static header with shy one

Can I implement shy table view with two headers, first shy (able to hide on scroll) and second static (on top of screen, and visible all the time)?
Almost suitable solution I got with group header view, but there was gap between group header and navigation bar on scroll bounces.

Facing issue on header movement when scroll tableView.
class name is TLYTableViewController
i used the code of UIScrollView delegate to move header with cell when scroll.
#pragma mark - UIScrollViewDelegate

(void)scrollViewDidScroll:(UIScrollView *)scrollView {
scrollView.contentInset = UIEdgeInsetsMake(-200, 0, 0, 0);
}

when i use this code table fluctuate or jerk the screen.
Is that any solution, when scroll table and section header also move at top of screen?

@Mazyod please, check https://github.com/telly/TLYShyNavBar/pull/163 to solve this issue.


Add IP address logical type

IP addresses can be much more optimally represented as a 64 bit integer, meaning that it's much more efficient for storage and allowing consumers to do equality or subnet (range) comparisons using long-integer arithmetic.
Reporter: Tristan Stevens
Note: This issue was originally created as PARQUET-1363. Please see the migration documentation for further details.

Uwe Korn / @xhochy:
[~tmgstev] You would probably need two types: IPv4 and IPv6

Tristan Stevens:
I guess you've got two options - you could have two types, or you could use the ipv6 representation of ipv4 addresses (i.e. zero padded). My first thought was for one type, but the same argument goes for having both 32 bit integers and 64 bit integers and arguing that the first 2^32 can be represented by zero padding the leading 32 bits!


config parsing code throws bug when 'train_data_dict' not set even when running 'prep'

as discovered by @yardencsGitHub

Fixed by #39

and add test for this in e301cff574a18f29a503fe6cc5f04c4e694d38e3


Set python version to python-ldappool package

Thank you for your contribution!
This GitHub repository is just a mirror of https://opendev.org/openstack/puppet-keystone, where development really happens. Pull requests proposed on GitHub are automatically closed.
If you are interested in pushing this code upstream, please note that OpenStack development uses Gerrit for change proposal and code review.
If you have never contributed to OpenStack before, please see:
https://docs.opendev.org/opendev/infra-manual/latest/gettingstarted.html
Feel free to reach out on the #openstack-upstream-institute channel on Freenode IRC in case you need help. You can access it through:
https://webchat.freenode.net/#openstack-upstream-institute


Broken except clause in paginate() causes 500s on invalid pages when used with a generic view

The except clause wrapping all of paginate() says "except KeyError, AttributeError:". This is broken (needs parens), so AttributeErrors are not actually caught. The symptom of this is that if you use pagination in a template rendered by generic view, and request an invalid page, you get a 500 from an AttributeError in the line "page_range = paginator.page_range".
This only shows up if you use a generic view because a generic view will set the context var "paginator" to None. Without the generic view you get a KeyError two lines earlier, which is caught by the except clause.
Fix for this is in my fork: http://github.com/carljm/django-pagination/commit/2a44e0ac284e3f1ad0c8a7281344674e34a42718

I had the same error in the Listview. I had this one resolved just by adding 'paginate_by = 20' to the arguments in urls.py for a ListView


Backport of 13814 - org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testRequest…

Description
org.opensearch.repositories.s3.S3BlobStoreRepositoryTests.testRequestStats fails with NullPointerException
It's a NullPointerException from S3BlobStore.extendedStats() method, where 'genericStatsMetricPublisher' is null. This parameter sets through S3Repository constructor from test and in this test it sets as null. This is the root cause of the issue. If we set valid a GenericStatsMetricPublisher, test works fine without any issue. This was a consistent failure, not a random failure.
Related Issues
Resolves #10735
Signed-off-by: Abdul Muneer Kolarkunnu<EMAIL_ADDRESS>

Analyzing the failures

Is it possible rerun(re-trigger) the failed test suits?


FR: Allow list items to use other list delimiters *, +

Currently a Hierarchy Note must be a pure list with the list identifier being -. I hope it can parse other Markdown list identifiers (+, *) as well.
Also I hope it can allow other content like yaml, comment, headings in the Hierarchy Note.

Should be fixed in 0.10.44
@zcysxy will you give it a try and let me know :)

@SkepticMystic Yeah it works now 🎉


move cross-env to prod list

cross-env is used when starting production too, without that I will get error that cross-env is unknown command

Cheers!


Add a Gitter chat badge to README.md

Fortran-FOSS-Programmers/FOODiE now has a Chat Room on Gitter
@zbeekman has just created a chat room. You can visit it here: https://gitter.im/Fortran-FOSS-Programmers/FOODiE.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Already present.


Autocomplete issue on shouldComponentUpdate

I am trying to use Autocomplete but for some reason on shouldComponentUpdate not working well. The component is about two levels from root component. But if I set the direction different than 'auto'... it works as should be.
On this line https://github.com/react-toolbox/react-toolbox/blob/dev/components/autocomplete/Autocomplete.js#L70 I added a log:
console.log(this.state.focus, nextState.focus, this.props.direction, POSITION.AUTO)

logs
false true "auto" "auto"

and this line https://github.com/react-toolbox/react-toolbox/blob/dev/components/autocomplete/Autocomplete.js#L74 looks like doesn't fire the lifecycle sometimes, I did a quick test with this code and works (I don't feel is the best approach):
 shouldComponentUpdate (nextProps, nextState) {
   if (!this.state.focus && nextState.focus && this.props.direction === POSITION.AUTO) {
    const direction = this.calculateDirection();
     if (this.state.direction !== direction) {
       // not calling setState
       this.state.direction = direction;
     }
   }
   return true;
 }

Reading https://facebook.github.io/react/docs/component-specs.html
docs from shouldComponentUpdate doesn't have a suggest if we can use setState or not...

https://github.com/react-toolbox/react-toolbox/pull/646

Fixed


lib/cli/errors: browserSessionId → sessionId

/cc @sipayRT

Coverage remained the same at 80.145% when pulling 40abd553127ae797976a899eac466d5c7993de45 on fix/browserSessionId into 3b876bc76e8b1f1ee9a612cf70a9f822b70a7bc3 on master.

Coverage remained the same at 80.127% when pulling d96807a01eda3b299b557e46fb96340d772bf33a on fix/browserSessionId into be509c47e90b43945165e25e803b3cb7eada2dfe on master.


”Chețani”, ”Coasta Grindului”, ”Cordoș” are listed in the drop-down menu

Description:
When user writes ”Chețani”, ”Coasta Grindului”, ”Cordoș” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Coasta Grindului"

Expected results
The location appears in the drop-down menu as "Sat Coasta Grindului, MUREȘ (Chețani)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Cordoș"

Expected results
The location appears in the drop-down menu as "Sat Cordoș, MUREȘ (Chețani)".


[4522] Fix items order in inventory adjustment dropdown.

Resolves #4522
Description
The items in the inventory adjustment dropdown were appearing in an unexpected order when adding a new storage location. This PR fixes the issue by ensuring that the items are sorted alphabetically in the controller before being passed to the view.
Solution:
Added .alphabetized scope to the inventory_items in the StorageLocationsController to ensure items are sorted alphabetically before being displayed.
Code Change:
# app/controllers/storage_locations_controller.rb
class StorageLocationsController < ApplicationController
  ...
  def inventory
    ...
    @inventory_items = StorageLocation.includes(inventory_items: :item)
                                      .find(params[:id])
                                      .inventory_items
                                      .alphabetized
                                      .active
    ...
  end
  ...
end

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
I have tested this change locally by:

Creating a new storage location.
Creating a new item to be added to the inventory.
Adding a new inventory adjustment for that location.
Verifying that the items in the dropdown are sorted alphabetically.

@cielf Apologies for the delay in progress. I need to update the logic and write test cases, so I am working on both.

All good on my end too!


ci!: Remove 3.8 and add 3.11

Signed-off-by: Kevin Stillhammer<EMAIL_ADDRESS>

Depends on https://github.com/home-assistant/core/pull/78860


Updated Single connection DataSource to HikariCP.

This prevents database warnings 'No transaction in progress'.
Code is already tested.

SonarQube analysis reported 2 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 PersistenceConfig.java#L45: Remove this hard-coded password.
 PersistenceConfig.java: Replace all tab characters in this file by sequences of white-spaces.

All is well.


Removing constraint from templates to avoid SDK multithreading issue

Works around https://github.com/dotnet/aspire/issues/4145.
@dsplaisted has done a full diagnosis of the issue here, but the TL;DR is that there seems to be a multi-threading issue inside the SDK, particularly in their logic that tries to check for installed workloads. Aspire templates today have a constraint to show these templates only when the aspire workload is installed, which is technically unrequired as the templates get installed via the workload anyway. By adding this constraint, we are forcing the piece of code in the SDK with the race condition, which will make it so that around 50% of the time, aspire template creation will fail. The SDK team will fix this bug in servicing, but in the meantime we are working around the bug by removing the unnecessary constraint from our templates.
We expect a lot of people will hit this issue (essentially anyone creating aspire projects from the command line), so we'll want to service this to 8.0.1 release. (FYI: @danmoseley )
cc: @DamianEdwards @phenning
Microsoft Reviewers: Open in CodeFlow

/backport to release/8.0


cannot decode json: no json object could be decoded

Hi,
the newest pytube version seems to fail with some videos (just experienced one or two until now), for example this one:
https://www.youtube.com/watch?v=YrgRloe0OKc
Error message is the above one. Any ideas?
Thanks.

@Timtam can you confirm this wasn't an issue with the previous version?

nope, it was, I tested with 0.2.0 right now. I just wanted to say that I tested it with the newest available version, so it isn't solved yet.

@Timtam this is tricky, it's because it's age restricted. I'm looking now to see if there's a workaround.

Can't fix, but now raises exception.


corerad, gopls: set buildGo118Module in top-level

Signed-off-by: Matt Layher<EMAIL_ADDRESS>Description of changes
Address review feedback from @SuperSandro2000, and apply the same to gopls.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test gopls

@GrahamcOfBorg test corerad


Remove dependencies between store and core that have crept in

We removed all dependencies between store -> core.
A couple crept in.
For now, I've cheated by adding methods to allow metrics entity data to be modified - ideally the registration would move to core, but that's a bigger change.

Codecov Report

Merging #4517 into master will increase coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4517      +/-   ##
==========================================
+ Coverage   58.85%   58.94%   +0.08%
==========================================
  Files         897      884      -13
  Lines       29248    29031     -217
  Branches     4220     4192      -28
==========================================
- Hits        17214    17112     -102
+ Misses      12034    11919     -115


Startup scripts silently fail if DB password include a '$'

If you include a password containing a '$' under databases.roles, the postgres job will report as running but the DB won't have a password set. In /var/vcap/sys/log/postgres/postgres_ctl.err.log I see:
[2017-08-18 20:46:02+0000] + echo 'Setting password for role cloud_controller...'
[2017-08-18 20:46:02+0000] /var/vcap/jobs/postgres/bin/postgres_start.sh: line 81: $6: unbound variable

My cloud_controller DB password does have a '...$6...' in the middle. Looks like this line is not doing any escaping so special characters get expanded. On CAPI we usually use Ruby's Shellwords.shellescape in our ERB templates around passwords.
Also a big +1 on this comment around failing the job if setting the roles fails: https://github.com/cloudfoundry/postgres-release/blob/865224b83361d58e8a5bbef77ccee48429feae45/jobs/postgres/templates/postgres_ctl.erb#L31-L37. Would have been much easier to debug if the postgres job failing immediately rather than silently erroring.

@ljfranklin
Thanks for reporting this issue. We have opened a separate story to have the postgres job to fail when a query fails.
For the empty password issue, we have fixed it as suggested and you will find the fix in the next release.

The empty password issue has been fixed in v21.


Unofficial Extras exports

Unofficial Extras exports a get_key as well as a get_key_bind function. These still have to be exposed to the user of the bindings.

Raw (unsafe) versions have been added in https://github.com/Zerthox/arcdps-bindings/commit/ab8ac5b842dbd5c8ba019ee3e4b45533a45b24bd.


Use true landscape mode instead of constraint re-routing

Because of constraint rerouting, the app goes into landscape even when the user has locked the rotation and wants their app to stay on portrait. I should define a dedicated XML for landscape to let Android deal with this, instead of doing constraint re-routing like I do currently.

just needed to change manifest value to "fullUser"


Add live_component handler to the LiveView integration

This pull request is a copy of @aj-foster’s work in #47, with a fix to make the tests pass an a patch to remove the separate clause for the live_component type. The latter requires us to depend on :appsignal 2.2.16 or above, as that version includes https://github.com/appsignal/appsignal-elixir/pull/788.

Thanks for taking the time to clean up my work and push it forward!

I’ve released this patch in :appsignal_phoenix 2.1.2 today. Thanks once again, @aj-foster, for your work on this!

Thank you so much for your work man this is tremendous!


(Flutter Desktop FFI) Accessing a native method from Flutter Desktop for macOS crashes the app.

Steps to Reproduce
While trying to access the native methods inside a dylib file from a Flutter macOS app, it crashes the app.
Note: this is not a release build, I am trying to setup the FFI setup in the debug mode.

I compiled the C code from https://github.com/dart-lang/samples/tree/master/ffi/hello_world
I added the resulting dylib file into the Xcode from "Frameworks, Libraries and Embedded content"
Embed option was set Embed & Sign
Target Membership was set Optional
flutter run --verbose
The app starts just fine, when I invoke the FFI code to access the native method the app crashes without any error.

Crash log:
[ +220 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +2 ms] DevFS: Deleting filesystem on the device (file:///var/folders/gd/tfxtn2j90055v3tzk05185680000gn/T/io.org.myapp/myappViRgeR/myapp/)
[ +257 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +2 ms] "flutter run" took 23,272ms.
[ +228 ms] ensureAnalyticsSent: 224ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hook priority 4
[   +3 ms] Shutdown hooks complete
[        ] exiting with code 0

Code:
import 'dart:ffi' as ffi;

typedef hello_world_func = ffi.Void Function();

typedef HelloWorld = void Function();

void test_ffi() {
  final dylib = ffi.DynamicLibrary.open('heyhello.dylib');

  final hello = dylib
      .lookup<ffi.NativeFunction<hello_world_func>>('hello_world')
      .asFunction();

  hello();
}

Expected results: The app prints: "Hello world"
Actual results: The app crashes
flutter analyze
No issues found! (ran in 16.0s)

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-2.0.pre.83, on Mac OS X 10.15.6 19G73, locale en-IN)
    • Flutter version 1.21.0-2.0.pre.83 at /Users/username/Library/Application Support/fvm/versions/master
    • Framework revision 9e658bc3d5 (2 days ago), 2020-07-21 03:56:07 +0200
    • Engine revision dcc9a4048d
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 9dca49e71e)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/username/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.2

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (1 available)
    • macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.6 19G73

• No issues found!

Please provide a backtrace for the crash from running under a debugger.

@stuartmorgan
Somehow this issue got fixed after upgrading to the latest master version which arrived this morning. But there is another issue with the FFI, for which I have raised a ticket here: https://github.com/flutter/flutter/issues/62185
Flutter 1.21.0-6.0.pre.17 • channel master • https://github.com/flutter/flutter.git
Framework • revision e64fe11542 (4 hours ago) • 2020-07-23 18:11:17 -0700
Engine • revision 626244a72c
Tools • Dart 2.9.0 (build 2.9.0-21.0.dev a3815b6590)


Feature issue 938 search input fields

One issue found:

Open search page
Enter some search terms and get the results
Click on a service to open the service detail
Click the back button
Expected: The search terms are still there
Observed: The search screen input fields have been reset to empty


needed to delete this pull request

It was still linked to David's branch

@terrifricker  yeah probably best to just create a new branch then and push that


Fixing issue where a cancelled job would not notify pipe is was finished

preview about to drop.  If this is important for hosted, let's get it in

looks good

CJ - I'm merging to get maximum coverage as devs run in last few days before release.


Re-home SDK implementations

I would like to make it clearer which code represents the integration with the Playwright Server, vs. which is the "API", for use by the consumer. As such, the former will be re-homed into Playwright.SDK.

This work has been merged via non-PR workflow.


Avoid applying java-base when applying jvm-test-suite

This removes the dependency between these two plugins

@bot-gradle test this

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build


Added Rabbit Network

I have read the CLA Document and I hereby sign the CLA

Please let us know when your network shows in https://chainlist.org/

yes network showing in  https://chainlist.org/  in testnet .

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
14 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.2%) to 83.786%

Files with Coverage Reduction
New Missed Lines
%

gnosis/eth/typing.py
2
83.33%

gnosis/protocol/gnosis_protocol_api.py
2
88.66%

gnosis/safe/api/relay_service_api.py
2
52.27%

gnosis/safe/proxy_factory.py
3
95.24%

gnosis/util/util.py
5
61.54%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
3271

Relevant Lines:
3904

💛  - Coveralls


add "wicg" to w3c megaGroups entry

For https://github.com/WICG/entries-api I'm getting ye olde:
FATAL ERROR: Unknown Status 'ED' used.


update: change default pb version to 0.22.20

Proposed changes:

Change default pocketbase version to latest release, moving from 0.22.4 to 0.22.20. Latest release info: https://github.com/pocketbase/pocketbase/releases
Fix for warning when deploying: remote:  1 warning found (use --debug to expand): remote:  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 7)

Love the project, running it out now for some small projects. Thanks for publishing the project!
Realized there have been a few releases on pocketbase and updated my default pocketbase version to the latest release locally.

In fact I just upgraded to the latest version apart from updating a few things, so I'm closing the PR, but thanks for your input anyway.


installing p4fpga

Hi,
I have some issues while installing p4fpga.
I can see two projects are required: p4c and p4fpga. Do they need to be in separate directories? or p4c is a sub-directory in p4fpga?
To create the soft-link to p4fpga source code in p4c, there is no sub-directory named  "compiler " in p4fpga directory!  There is no sub-directory named "extensions" in p4c either. do we need to create the sub-directories manually?

Hi @ali64Mon, I have updated the top-level readme.md to reflect the current process to build p4fpga.

Thanks for your reply. Could you please provide me with an example showing how to work with P4FPGA?


Add --subdomain flag to transfer-pvc subcommand to allow users specifying custom subdomains to ingress and route endpoint types

Born out of reviews from #56

Covered here: https://issues.redhat.com/browse/MTRHO-25
Closing in favor of the existing Jira.


Bump mongoid version to 6

@mauriciozaffari Looks like bundler 1.13.1 has an issue to find out .gemspec file. Build is running with bundler 1.11 on my local system. Could you please help?

This branch works on my rails 5 install, with the latest stable mongoid gem. Thank you for your good work ! However I am getting this issue https://github.com/mongoid/mongoid_search/issues/107 .. The relevancy value is always 1.0 .. If you have any idea what could be causing this, I would really appreciate. Thanks

Can someone finish this PR with a passing build, please? I'm happy to check it out, merge, etc.

Is this project dead? If you click the details on the build TravisCI cannot find the repo...?

I wouldn't rely on it.. I've personally moved over to searchkick

Or https://github.com/mongoid/mongoid_fulltext

@sivagollapalli could you rebase your PR to current master with working CI for Mongoid 3-5 and check tests passing for Mongoid 6? If all of them are passed, we could say there is support for Mongoid 6 and close #115

@rtrv Sure I will rebase and update PR.

Replaced with https://github.com/mongoid/mongoid_search/pull/124.


Remove old Contour package versions

What this PR does / why we need it
Removes old Contour package versions so we have N-2 available for users
Which issue(s) this PR fixes
N/A
Describe testing done for PR
N/A
Special notes for your reviewer
N/A

Waiting on https://github.com/vmware-tanzu/community-edition/pull/4618


Allow change of matrix aggregation function

In aggregated matrix (vector) it would be nice to have possibility to change the aggregation function without having to de-aggregate the matrix first (keep the aggregation combo box in the toolbar)


Psycopg2 keeps failing to build

opencdms version: 0.10
Python version: 3.8
Operating System: Kali Linux( Version 2021)

Description
I was trying to install pyscopg2 which is a database driver for posgresql.
I did notice the package is available, as from the stack trace pip was able to download the package,
but it does fails whenever it tries to build the package as it has some missing dependencies like: libpq-fe.h.
Running the following command:
pip install psycopg2
fails with the following  error stack trace:
Defaulting to user installation because normal site-packages is not writeable
Collecting psycopg2
  Using cached psycopg2-2.9.3.tar.gz (380 kB)
Building wheels for collected packages: psycopg2
  Building wheel for psycopg2 (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /usr/local/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/setup.py'"'"'; __file__='"'"'/tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-679zt9_t
       cwd: /tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/
  Complete output (38 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.linux-x86_64-3.8
  creating build/lib.linux-x86_64-3.8/psycopg2
  copying lib/errors.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/pool.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/__init__.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/sql.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/_json.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/tz.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/extras.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/_ipaddress.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/_range.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/extensions.py -> build/lib.linux-x86_64-3.8/psycopg2
  copying lib/errorcodes.py -> build/lib.linux-x86_64-3.8/psycopg2
  running build_ext
  building 'psycopg2._psycopg' extension
  creating build/temp.linux-x86_64-3.8
  creating build/temp.linux-x86_64-3.8/psycopg
  gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DPSYCOPG_VERSION=2.9.3 (dt dec pq3 ext lo64) -DPSYCOPG_DEBUG=1 -DPG_VERSION_NUM=140000 -DHAVE_LO64=1 -DPSYCOPG_DEBUG=1 -I/usr/local/include/python3.8 -I. -I/usr/include/postgresql -I/usr/include/postgresql/14/server -I/usr/include/libxml2 -c psycopg/psycopgmodule.c -o build/temp.linux-x86_64-3.8/psycopg/psycopgmodule.o -Wdeclaration-after-statement
  In file included from psycopg/psycopgmodule.c:28:
  ./psycopg/psycopg.h:36:10: fatal error: libpq-fe.h: No such file or directory
     36 | #include <libpq-fe.h>
        |          ^~~~~~~~~~~~
  compilation terminated.

  It appears you are missing some prerequisite to build the package from source.

  You may install a binary package by installing 'psycopg2-binary' from PyPI.
  If you want to install psycopg2 from source, please install the packages
  required for the build and try again.

  For further information please check the 'doc/src/install.rst' file (also at
  <https://www.psycopg.org/docs/install.html>).

  error: command 'gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for psycopg2
  Running setup.py clean for psycopg2
Failed to build psycopg2
Installing collected packages: psycopg2
    Running setup.py install for psycopg2 ... error
    ERROR: Command errored out with exit status 1:
     command: /usr/local/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/setup.py'"'"'; __file__='"'"'/tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-4iq8smwq/install-record.txt --single-version-externally-managed --user --prefix= --compile --install-headers /home/benji/.local/include/python3.8/psycopg2
         cwd: /tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/
    Complete output (38 lines):
    running install
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-3.8
    creating build/lib.linux-x86_64-3.8/psycopg2
    copying lib/errors.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/pool.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/__init__.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/sql.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/_json.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/tz.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/extras.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/_ipaddress.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/_range.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/extensions.py -> build/lib.linux-x86_64-3.8/psycopg2
    copying lib/errorcodes.py -> build/lib.linux-x86_64-3.8/psycopg2
    running build_ext
    building 'psycopg2._psycopg' extension
    creating build/temp.linux-x86_64-3.8
    creating build/temp.linux-x86_64-3.8/psycopg
    gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DPSYCOPG_VERSION=2.9.3 (dt dec pq3 ext lo64) -DPSYCOPG_DEBUG=1 -DPG_VERSION_NUM=140000 -DHAVE_LO64=1 -DPSYCOPG_DEBUG=1 -I/usr/local/include/python3.8 -I. -I/usr/include/postgresql -I/usr/include/postgresql/14/server -I/usr/include/libxml2 -c psycopg/psycopgmodule.c -o build/temp.linux-x86_64-3.8/psycopg/psycopgmodule.o -Wdeclaration-after-statement
    In file included from psycopg/psycopgmodule.c:28:
    ./psycopg/psycopg.h:36:10: fatal error: libpq-fe.h: No such file or directory
       36 | #include <libpq-fe.h>
          |          ^~~~~~~~~~~~
    compilation terminated.

    It appears you are missing some prerequisite to build the package from source.

    You may install a binary package by installing 'psycopg2-binary' from PyPI.
    If you want to install psycopg2 from source, please install the packages
    required for the build and try again.

    For further information please check the 'doc/src/install.rst' file (also at
    <https://www.psycopg.org/docs/install.html>).

    error: command 'gcc' failed with exit status 1
    ----------------------------------------
ERROR: Command errored out with exit status 1: /usr/local/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/setup.py'"'"'; __file__='"'"'/tmp/pip-install-r88tgur4/psycopg2_14d63bb466404a78826008b2da45b021/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-4iq8smwq/install-record.txt --single-version-externally-managed --user --prefix= --compile --install-headers /home/benji/.local/include/python3.8/psycopg2 Check the logs for full command output.```

They provide a very useful error message:
    It appears you are missing some prerequisite to build the package from source.

    You may install a binary package by installing 'psycopg2-binary' from PyPI.
    If you want to install psycopg2 from source, please install the packages
    required for the build and try again.

    For further information please check the 'doc/src/install.rst' file (also at
    <https://www.psycopg.org/docs/install.html>).

We know:

The prerequisite were not present to build the package from source
A binary package is available
To install from source we need to fulfil the build dependencies

Looking first at the link they provide (https://www.psycopg.org/docs/install.html), and specifically at the psycopg-vs-psycopg-binary section, they state:

"The psycopg2-binary package is meant for beginners to start playing with Python and PostgreSQL"
"For production use you are advised to use the source distribution"

(they give further information on the reasons why - these make sense since they have built the binary version using a stack that is particular to their build environment which may have subtle differences to other environments that the binary package may be used in)
The psycopg2-binary docs give a similar warning: The binary package is a practical choice for development and testing but in production it is advised to use the package built from sources.
I'm a bit reluctant to even use psycopg2-binary in development due to the tenth principle of 12 factor app development (Dev/prod parity) which states: "Keep development, staging, and production as similar as possible".
I think we may want to suggest psycopg2-binary to some of our users who are experimenting and not developing production systems, but in general we need to make sure that psycopg2 can be built in each environment that we're supporting.
See the prerequisites in the psycopg2 docs for a broad overview and also Option 2 in this StackOverflow discussion for some guidance.


feat: prune layouts based on stats

Still not using GetField, but I think this is correct and works.

I think we need to do more here

Prune splits based on stats results. There's no point building all the masks for reading if we know they're going to be thrown away.
We need to handle A op B, i.e. A || B this will not get pushed down right now and we will never prune on it

switching to https://github.com/spiraldb/vortex/pull/1379


Improve APM for 5xx responses

What does this PR do?
Improve reporting of 5xx errors.
Additional Notes

Review checklist
Please check relevant items below:

[ ] This PR includes all newly recorded cassettes for any modified tests.

[ ] This PR does not rely on API client schema changes.

[ ] The CI should be fully passing.

[ ] Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.

Note: CI shouldn't be run on this Draft PR, as its expected to fail without the corresponding schema changes.

/azp run


Be ready for Promises

http://www.w3.org/TR/2015/WD-webrtc-20150210/#interface-definition
Buff... No idea how to make both worlds to live together.

How to detect callbacks/promises based browser:
If navigator.mediaDevices.getUserMedia exists then this is a new browser and does supports promises for the whole WebRTC API.


Remove _type which is no longer returned on bulk response items

As per title

Backported to 8.0: https://github.com/elastic/elasticsearch-specification/pull/1128


Add document parser with simple HTML parser (fixed)

Abstract base class so that people can write their own

@ajratner are we making any memory usage assumptions for ddlite? If we think people might still be working with large data sets, I should switch the doc parser to a generator

Hey @henryre,
This all looks great!  And I even learned about a new type of soup.  I guess only two minor comments:

I agree with your point above, we should switch to generators.  I don't think we should over-optimize for industrial-scale use-cases or anything, as we may never want / need to get there... but this is an easy fix, in keeping with our python code elsewhere too.  (I do however think that between (i) keeping everything as a generator, (ii) supporting sparse matrices, and (iii) potentially having a db connection of some sort, we should be able to handle decent-enough sized sets... let's see!)

Minor: should we maybe call NullParser TextParser to be clearer?