Windows Auth Issue on Server 2016

[ x] I read and understood how to enable logging

Issue / Steps to reproduce the problem
I'm running into THIS issue when using windows authentication along with the latest IDSVR4.  Is there anything you guys can do to prevent us from having to disable HTTP2 on a windows 2016 server or am I at the mercy of M$?

I too had seen this issue in older versions of Chrome, but in more recent versions it went away.

All of our users even remote, including machines we don't manage have this issue using Chrome.  I even downloaded the latest Canary build of Chrome, Version 64.0.3256.0 (Official Build) canary (64-bit) and it still shows this error.   It is because we are running IIS on Server 2016.

I tried disabling http/2.0 requests within the site using:
<rewrite>     <rules>         <rule name="RequestBlockingRule1" patternSyntax="Wildcard" stopProcessing="true">             <match url="*" />             <conditions>                 <add input="{SERVER_PROTOCOL}" pattern="HTTP/2.0" />             </conditions>             <action type="AbortRequest" />         </rule>     </rules> </rewrite>
But this did nothing.

If you look at THIS CHROME BUG it appears to be fixed, but it can take some time for a fix to make it's way to release.  On stack overflow someone told me this fix may show up in early December.

Thanks for the follow up, and glad to hear it's on their end (not ours) :)


TextInput from React Native does not show entered text

Environment
  React Native Environment Info:
    System:
      OS: macOS 10.14.1
      CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
      Memory: 751.85 MB / 16.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 9.4.0 - /usr/local/bin/node
      npm: 6.4.0 - /usr/local/bin/npm
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.1 => 16.6.1
      react-native: 0.57.7 => 0.57.7
    npmGlobalPackages:
      create-react-native-app: 1.0.0
      react-native-cli: 2.0.1
      react-native-config: 0.11.5
      react-native-git-upgrade: 0.2.7

Description
The TextInput component does not show text just typed if it already has some long text and the cursor is in the leftmost position.
Steps to reproduce:

Open the Reproducible Demo application (see below).
Put the cursor to the beginning of the text in the TextInput.
Try typing something (say, "abc").

Expected:

Actual:

I.e., "abc" is entered, however, the cursor stays in the initial position and the entered text is not visible. I have to move the cursor to the left myself to see the text. That is not expected behavior: I, as a user, feel that the input is broken and my text just is not entered at all.
Reproducible Demo
The project to reproduce the issue is available here. Just run it in Xcode on an iOS simulator.
Related Stack Overflow Question
https://stackoverflow.com/questions/53732372/textinput-from-react-native-does-not-show-entered-text

Confirmed this is still happening with the latest release.

joins the question
check this [https://snack.expo.io/@roach_iam/textinput-bug](snack expo)

Still happening on 61

Can someone reopen this? Do not let it become a "Feature" or "Easter Egg" for react native apps.


build: regex-to-strings -> randExp.js, bundle 938 KiB -> 798 KiB

No behavior change. Resolves #179

Awesome, thank you!


Update SCBs to adjudicate SCB updates found throughout the CB approval process

💡 Summary
As the Kraken SCBs undergo the CB approval process this issue and branch will be updated to reflect all of the consolidated SCB updates.
Motivation and context
This work is required to process and publish the Kraken release for the SCBs.
Implementation notes
Related to issue #1449
Acceptance criteria
How do we know when this work is done?
The SCBs are updated to reflect any changes/updates noted by the following teams:

[x] tech editor / comms team
[ ] JCDC
[ ] OCC

marking as blocked for now since we are awaiting JCDC & OCC feedback


Enable Browserify my merging tags and mixins into a single bundle with event-stream

Hello,
I removed the need for two script tags by using event-stream to merge the two source streams (from gulp-riot and gulp-babel) into one concatenated output file, and updated the "main" node in package.json so that this will work well as a Browserify module.  I updated the README to reflect the need for only one script tag.
Please accept this PR if you think it adds value. I'd love to get your future changes, and to keep contributing as I build my app, so I'd like to avoid diverging into my own fork.
Thanks!
Tim

@mividtim Hi! I've accepted your PR. I think it can be useful. I didn't get for what purposes we need vanilla-masker module... Therefore i've removed it from dependencies. Riot-mui npm package was updated as well.


standalone tests failing locally due to 32bit libs being present on a 64 bit machine

Tests failing locally due to 32bit libs being present on a 64 bit machine.
Run '/usr/bin/python3 ./tests/standalone/run_all.py search' in '/home/jayvdb/python/Nuitka'.
Using concrete python 3.10.9 on x86_64
Consider output of standalone mode compiled program: BrotliUsing.py
Comparing output of 'BrotliUsing.py' using '/usr/bin/python3' with flags silent, expect_success, --standalone, remove_output, cpython_cache, timing, --nowarn-mnemonic=debian-dist-packages ...
--- /usr/bin/python3 (stderr)
+++ nuitka (stderr)

@@ -0,0 +1,2 @@

+/usr/lib64/gcc/x86_64-suse-linux/12/../../../../x86_64-suse-linux/bin/ld: skipping incompatible /usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1
+/usr/lib64/gcc/x86_64-suse-linux/12/../../../../x86_64-suse-linux/bin/ld: skipping incompatible /usr/lib/libgcc_s.so.1 when searching for libgcc_s.so.1

I have a patch coming for this.

This should be done in output comparison I think, matching a regexp of this kind of line.

I think that is what I did in the PR ?

I will make this part of 1.4.1 when it comes

This was released, please use 1.4.3 though, there was an important incorrect code execution bug fixed in there.


chore: import repository https://github.com/mytesting-org/test-node.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Cstubs.Types.TYPE doc source code formatting

The code blocks were misformatted. I haven't tested the doc generation with these edits.

Thanks.


Hugo/playground: add report an issue link to playground

Passing issueUrl to playground
Add issueUrl to playground menu
name change editorEnv to playgroundEnv
add option to add target to menu link

Testing:

go to playground
open menu (3 dots)
click on "report an issue"
Github should open in a new tab with prefilled text, including the page url and commit version.

For https://linear.app/usmedia/issue/CUE-303

Imported as https://review.gerrithub.io/c/cue-lang/cuelang.org/+/1172234

Closed via 3da5049efaa904c72a7027db69e7e75e6a325bfd


Don't report atomic race in bazel tsan build

Fix https://github.com/grpc/grpc/issues/17175

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,244      Total (=)      2,019,244

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,179,124      Total (>)     11,179,115

 No significant differences in binary sizes

Isn't this overkill, though? Some atomic races are legitimate

I thought it's ok to disable because this is also disabled by default in google3/testing/ with the reason being "There are too many of them...".
But I'm not sure whether this is an overkill in our own repo though.

@AspirinSJL  feel free to also consider https://github.com/grpc/grpc/pull/17216

Personally, having atomic races enabled has helped me a lot, including freelist examples like this one. We manage a lot of our own freelists, non-blocking queues, etc., and those are hard to get right without something like this. I know that we don't do it internally since everything inside uses absl:: and its predecessor, but we haven't previously seen an issue with false positives on this. Only with the indirect introduction of absl through OpenCensus.

I see. Closing this.


Allow deeplinking to specific transactions

https://opencollective.com/civicinnovationnetwork/transactions
In sharing how the platform works, I was aspiring to link to a specific funding transaction on the above page. This would have made it a little simpler to share details about the collective. It would be amazing if we could deeplink to items, even those past the first page of results

thanks @patcon! I'll label this enhancement and close it for the moment, since we have a long list of priorities to go through first.


Update documentation home.md

Same as https://github.com/angular/angular-cli/pull/18237#pullrequestreview-447087415

Closing as documentation for CLI version 1 is deprecated and will be deleted soon.


Added ability to look past incremental deploys (#6344)

Pull request opened by the merge tool on behalf of #6344

Merged into branches iso6 in 5848d3ec7bf00799183a590c439e5c5d5493323d


Reduce image size

Hi,
I would like to use the oneapi-hpckit container for my gitlab-ci pipeline but your image is too large (~23Go) for my registry.
Would it be possible to have a minimalist container with only the compiler (and the necessary libs) and not all the tools ?
Thanks

@pums974 This is something we have on track, you can expect this on a future release. On the meantime, as a workaround, you can use the Dockerfile as an example for building your own container.

Amazing, I had the same question.
It would be very helpful to me to know which packages are required for the compiler alone and for the python distribution. I  only want the compiler and the python distribution (with its optimized math packages) to be fair. Right now I just copied the Dockerfile but it is way too big. Could you tell me which packages I need for this smaller build?
UN true
&& dnf install -y \
intel-basekit-getting-started \
intel-oneapi-advisor \
    intel-oneapi-ccl-devel \
    intel-oneapi-common-licensing \
    intel-oneapi-common-vars \
    intel-oneapi-compiler-dpcpp-cpp \

intel-oneapi-dal-devel \
intel-oneapi-dev-utilities \
    intel-oneapi-dnnl-devel \
    intel-oneapi-ipp-devel \
    intel-oneapi-ippcp-devel \
    intel-oneapi-libdpstd-devel \
    intel-oneapi-mkl-devel \
    intel-oneapi-onevpl-devel \
    intel-oneapi-python \
    intel-oneapi-tbb-devel \
    intel-oneapi-vtune \

Thanks in advance!

its not only too large for the gitLab registry, it is also too large for the gitlab runners:

write /opt/intel/oneapi/intelpython/python3.9/envs/2022.2.1/lib/libippiy8.so.10.5: no space left on device (manager.go:237:373s)

With the release of 2025.0 oneAPI toolkits, we have introduced smaller toolkits/bundles.
For instance a C++ Essentials is a smaller version of the base toolkit that might be suitable.
docker pull intel/cpp-essentials:latest
Details can be seen on https://www.intel.com/content/www/us/en/developer/tools/oneapi/base-toolkit.html
Closing due to product change and age. If you have feedback or requests for other bundle, please let us know.

This issue was specific to the oneapi-hpckit container, and their I don’ see any reduced/essentials images. Please reopen the issue. Thanks.


Fix docs link

Changes

Fix docs link

Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

Codecov Report

Merging #301 (a51a3bd) into main (239273c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   56.72%   56.72%
=======================================
  Files          23       23
  Lines         781      781
  Branches      158      158
=======================================
  Hits          443      443
  Misses        337      337
  Partials        1        1


Allow code execution without docker library installed

Why are these changes needed?

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2750391) 39.33% compared to head (f7b0b2c) 26.97%.

Files
Patch %
Lines

autogen/code_utils.py
40.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1740       +/-   ##
===========================================
- Coverage   39.33%   26.97%   -12.37%
===========================================
  Files          57       57
  Lines        6096     6099        +3
  Branches     1365     1484      +119
===========================================
- Hits         2398     1645      -753
- Misses       3502     4245      +743
- Partials      196      209       +13

Flag
Coverage Δ

unittests
26.95% <40.00%> (-12.39%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@PyroGenesis before proceeding, I want to understand the reason you don't want the docker Python library to be installed. Currently, the docker Python library is installed as a required dependency of pyautogen.

I see. I didn't realize docker was a required dependency because something went wrong with my dependency manager:
(project-py3.10) > poetry show pyautogen
 version      : 0.2.14
 description  : Enabling Next-Gen LLM Applications via Multi-Agent Conversation Framework

dependencies
 - chromadb *
 - diskcache *
 - flaml *
 - ipython *
 - openai >=1.3
 - pydantic >=1.10,<3
 - pypdf *
 - python-dotenv *
 - sentence_transformers *
 - termcolor *
 - tiktoken *

Anyway, creating a new project did resolve the docker dependency correctly, so this is not an issue anymore.


different laradock container using another's SSH keys

I have a few different laradock environments depending on the project(s) needs.
I first created one environment with an SSH key, which works fine. I've been replacing the insecure_id_rsa and insecure_id_rsa.pub with my own and in the workspace Dockerfile, it gets copied into the container:
ARG INSTALL_WORKSPACE_SSH=false

COPY insecure_id_rsa /tmp/id_rsa
COPY insecure_id_rsa.pub /tmp/id_rsa.pub

RUN if [ ${INSTALL_WORKSPACE_SSH} = true ]; then \
    rm -f /etc/service/sshd/down && \
    cat /tmp/id_rsa.pub >> /root/.ssh/authorized_keys \
        && cat /tmp/id_rsa.pub >> /root/.ssh/id_rsa.pub \
        && cat /tmp/id_rsa >> /root/.ssh/id_rsa \
        && rm -f /tmp/id_rsa* \
        && chmod 644 /root/.ssh/authorized_keys /root/.ssh/id_rsa.pub \
    && chmod 400 /root/.ssh/id_rsa \
    && cp -rf /root/.ssh /home/laradock \
    && chown -R laradock:laradock /home/laradock/.ssh \
;fi

On a different environment with a different DATA_PATH_HOST and COMPOSE_PROJECT_NAME, I added different ssh keys, but for some reason, the container is still using the keys from the other environment.
i.e, the cat id_rsa.pub in this container has the other keys loaded in ~/.ssh dir.
I tried renaming the file that gets copied in and running docker-compose build --no-cache workspace and it still loads in the other key.
How can I get different keys to load in for different containers?

Apparently I had to rebuild other items. not just workspace? don't get it. but i rebuild everything no cache and now the key has changed


Python Getting Started: trim down installation section

Installation section is necessary evil, let's keep it short
so that reader gets faster to interesting bits of the guide.
More installation details (install dev version, install from source,
trouble shooting, ...) can be delegated to offical docs.

I moved the troubleshooting to official docs in https://github.com/Open-EO/openeo-python-client/commit/51995fb01778d57d15e8f26041402f7920df57fa


fix(app): Fix for error while presenting in IOS in wallet initiate flow

Codecov Report
Patch and project coverage have no change.

Comparison is base (d451e57) 90.07% compared to head (b5d839f) 90.07%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   90.07%   90.07%
=======================================
  Files          98       98
  Lines        3797     3797
=======================================
  Hits         3420     3420
  Misses        250      250
  Partials      127      127

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update to 1.19.2

Please update mod to MC 1.19.2. I want to use this mod on my build server for record progress of all players, but mod is only for 1.19.

Or you planning update mod to the MC 1.20 after released??

I'll update this when I have time, hopefully sooner than later.

I'll update this when I have time, hopefully sooner than later.

Awesome dude this mod is great thanks for making it


update ASHRAE city look up

@rathod-b I had to revert merging this change into develop because the city look ups are failing. See the Actions tests: many cities are not found and it is reverting to the geometrically nearest city. Can you please investigate this issue? We can merge this change once the same cities are found as the previous method.

It seems the ArchGDAL module is having trouble returning the city value when a match is made. I can print the corresponding city value but when I try to return the value it doesnt seem to return anything. I will find an alternative.


build: upgrade to Python 3.9

Resolves #590

Still draft because I need to setup Python 3.9 on Sapir to make this work!

Still draft because I need to setup Python 3.9 on Sapir to make this work!


Implement reorderButtons

Implement reorderButtons
(A) what you did
-  Implement reorderButtons
(B) what you expected to happen
- Buttons will be reordered when user calling the method
For instance:
$this->crud->reorderButtons('line', ['update', 'delete', 'show', 'open_google']);
(C) what happened
- Buttons are reordered

A new inspection was created.

A new inspection was created.

The inspection completed: 5 new issues, 1 updated code elements

A new inspection was created.

A new inspection was created.

The inspection completed: 4 new issues, 1 updated code elements

The inspection completed: 1 new issues, 1 updated code elements

Looks excellent! Thank you @luqmanrom !
@pxpm could you please take a look?

@luqmanrom I've created a separate PR starting from this, so we can add the unit test.
@pxpm please check out https://github.com/Laravel-Backpack/CRUD/pull/2457

PS. Thank again @luqmanrom ! 😄


not working google login

python2 pokecli.py -a google -u user -p pass always gives Login Error, server busy. I've checked on phone and i'm able to login without any problems

if you have a two factor auth then try to create a new password for device

Confirmed it works with app password for me (I use two factor)

did not work a single time for me

i dont have 2factor auth enabled but will try

Looks like it doesn't work if -du option enabled

@vanrzuf I hope your issue is resolved.
Please feel free the open a new issue when necessary!


Save block + exit to terminal feature

Hi @genieCS ,
I was wondering if you could add a save block feature, and enable users to exit back to their terminal instead of opening a new window. I would also be open to work on it.

it would be cool! go for it🚀


okd 4.11 install on azure fails with os image override (fcos)

Describe the bug
Installation fails on Azure with OS image override setting.
Installer attempts to create terraform azurerm_image resource but fails because source blob azurerm_storage_blob.rhcos_image is Block type.
Version
OKD: 4.11.0-0.okd-2022-11-19-050030
Azure Public Cloud (Germany West Central)
FCOS fedora-coreos-36.20221030.3.0-azure.x86_64
IPI
How reproducible
100%
Log bundle
n/a - bootstrap node does not get created
Installer logs
$ ./openshift-install version
./openshift-install 4.11.0-0.okd-2022-11-19-050030
built from commit 0c4e73175c1aaa2140fb360ce8ff44a4b9dd669f
release image quay.io/openshift/okd@sha256:b2e925d0178130baa99ebdcdf9bfe124a1fa496cae955af5543652c2166def63
release architecture amd64

$ export OPENSHIFT_INSTALL_OS_IMAGE_OVERRIDE="https://builds.coreos.fedoraproject.org/prod/streams/stable/builds/36.20221030.3.0/x86_64/fedora-coreos-36.20221030.3.0-azure.x86_64.vhd.xz?sha256=ad735bdd450827c539b3339ab4ed37c697935d9ece44071cb918e1832ab56dbe"

$ ./openshift-install create cluster --dir cluster --log-level=debug
...
DEBUG azurerm_storage_blob.rhcos_image: Creating...

DEBUG azurerm_image.clustergen2: Creating...
ERROR
ERROR Error: compute.ImagesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="The source blob https://clusterl9ky0.blob.core.windows.net/vhd/rhcosl9ky0.vhd is not a page blob." Target="disks"
ERROR
ERROR   with azurerm_image.cluster,
ERROR   on main.tf line 94, in resource "azurerm_image" "cluster":
ERROR   94: resource "azurerm_image" "cluster" {
ERROR
ERROR
ERROR Error: compute.ImagesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="The source blob https://clusterl9ky0.blob.core.windows.net/vhd/rhcosl9ky0.vhd is not a page blob." Target="disks"
ERROR
ERROR   with azurerm_image.clustergen2,
ERROR   on main.tf line 106, in resource "azurerm_image" "clustergen2":
ERROR  106: resource "azurerm_image" "clustergen2" {
ERROR
ERROR failed to fetch Cluster: failed to generate asset "Cluster": failure applying terraform for "vnet" stage: failed to create cluster: failed to apply Terraform: exit status 1

Somehow this is being omitted:
https://github.com/openshift/installer/blob/0c4e73175c1aaa2140fb360ce8ff44a4b9dd669f/data/data/azure/vnet/main.tf#L89
resource "azurerm_storage_blob" "rhcos_image" {
  name                   = "rhcos${random_string.storage_suffix.result}.vhd"
  storage_account_name   = azurerm_storage_account.cluster.name
  storage_container_name = azurerm_storage_container.vhd.name
  type                   = "Page"
  source_uri             = var.azure_image_url
  metadata               = map("source_uri", var.azure_image_url)
}

Dupe of #531


Finalizers get removed before the instance is really gone

When deleting a machine, the finalizer which is responsible to delete the cloud provider instance (machine-delete-finalizer), gets removed before we know that the instance is gone.
As cloud providers usually do the deletion async, the machine controller should only remove the finalizer when the instance is gone.

Consumers of the cluster api (machines) might start cleanup procedures after machines have been deleted - which will fail if the instances are not gone yet (AWS & Openstack -> SecurityGroups)


Abstract DOM from patch functions

Is there any interest in abstracting the render/patch functions in /vdom modules that actually touch the DOM, in order to allow (additional) custom implementations of these functions for non-DOM (i.e., native app) environments?

Noticed today that this was added with #213, but just hasn't been released yet.  Exactly what I was looking for!


Add extensionpoints to SwaggerGenerator

Enables extending SwaggerGenerator through inheritance and overriding of virtual methods.
We have an api where we want to customize our Swagger documentation to make it as accurate as possible. Opening up SwaggerGenerator allows us to inherit and simply override the methods we need to customize.
I'd be happy to give this another go if the solution is not to your satisfaction.

this is highly needed and a tiny fix, please merge!

We'd love to have this too.
Seem this PR has been ignored for some months already. I'd recommend squashing all commits into one, as it's just 1 file change, but otherwise the changes look ok.
Any idea whether there is an active maintainer who can review and accept this?

Apologies for the delay. I'm currently working working my way through the list of issues and prioritizing.
This particular fix is not top of the list.
Swashbuckle has a lot of extensibility built in with the range of configure options, operation, schema and document filters.
Philosophically, I don't believe that making all private methods virtual protected is a good approach for extensability - especially in a library. It breaks encapsulation - now I can't change the internals of the generator because consumers of the library could be coupled. I prefer to follow the GoF advice and "favor composition over inheritance".
Perhaps you could elaborate on the specific feature you're trying to achieve and we can collaborate on a different design?

@domaindrivendev , thanks for responding. These are all valid points about encapsulation, and there are quite a few extensibility points, which should cover most of the cases. In light of this, the PR should be closed.

@domaindrivendev , there's one missing extensibility point raised here: #651

Just circling back on this - thanks for the update.


Adding full screen mode

Adding full screen mode with F11 shortcut. It's useful in non tiling windows manager.

thanks ;)


Error handling when register_listener fails

If register_listener fails there is only a log message
https://github.com/eclipse-uprotocol/up-streamer-rust/blob/d4ab17fbc745705290e29e5251fa8e9fcbffe943/up-streamer/src/ustreamer.rs#L153C1-L173
but the constructed tuple is added to forwarding_listeners and set to active. This basically leaves a "dead" listener in the HashMap.

Thanks for pointing this out! You're completely right :)

@PLeVasseur  Please assign this to me

@pranavishere2 -- you mentioned yesterday some refactoring done in this area fixed this issue.
Could you update here with info on how it was solved?
Perhaps you could also write a test to prove this out.

Prior to the update in the main branch, the following code was leading to a dead listener object even when registerListener failed:
if let Err(err) = reg_res {
warn!("{FORWARDING_LISTENERS_TAG}:{FORWARDING_LISTENERS_FN_INSERT_TAG} unable to register listener, error: {err}");
} else {
debug!("{FORWARDING_LISTENERS_TAG}:{FORWARDING_LISTENERS_FN_INSERT_TAG} able to register listener");
}
(
0,
forwarding_listener,
)
Following the refactoring in the main branch, this issue has been resolved by introducing an exception when the registerListener call fails. The updated implementation ensures that if the listener cannot be registered, an error is thrown to prevent the dead listener object. Below is the code snippet:
uuris_to_backpedal.insert((any_uuri(), Some(uauthority_to_uuri(out_authority))));
if let Err(err) = in_transport
.register_listener(
&any_uuri(),
Some(&uauthority_to_uuri(out_authority)),
forwarding_listener.clone(),
)
.await
{
warn!(
"{}:{} unable to register request listener, error: {}",
FORWARDING_LISTENERS_TAG, FORWARDING_LISTENERS_FN_INSERT_TAG, err
);
for uuri_pair in &uuris_to_backpedal {
if let Err(err) = in_transport
.unregister_listener(
&uuri_pair.0,
uuri_pair.1.as_ref(),
forwarding_listener.clone(),
)
.await
{
warn!(
"{}:{} unable to unregister listener, error: {}",
FORWARDING_LISTENERS_TAG, FORWARDING_LISTENERS_FN_INSERT_TAG, err
);
}
}
return Err(ForwardingListenerError::FailToRegisterNotificationRequestResponseListener);
}
Also the listener is added in the map at the end of the function only when all preconditions are satisfied:
forwarding_listeners.insert(
(in_comparable_transport, out_authority.to_string()),
(1, forwarding_listener.clone()),
);
Ok(Some(forwarding_listener))
This makes sure there will not be any dead listner when registerListener API fails.

@pranavishere2 -- please use code tags to put the code in and give references to the main branch which files / lines, i.e. use links.

@pranavishere2 -- please use code tags to put the code in and give references to the main branch which files / lines, i.e. use links.

Done

Thanks @pranavishere2 -- closing as completed by #20


opkg-keyrings: Document upgrading opkg-keyrings

This PR adds documentation about opkg-keyrings and how to upgrade them on a target.
The document has been temporarily hosted here, and can be reviewed.
AB#2351694
Testing
Build nilrt-docs.

This is more of a draft as I haven't written the last section about SystemLink yet.


Ensure all component stylesheets are properly linted

Update glob pattern in stylesheet lint scripts to ensure all stylesheets are linted.
Fix #513

After fixing the lint script. Even after running the lint-styles-fix script there are a lot of issues that will need to be manually fixed:
The list of issues is pretty long...

All stylesheets are now passing the lint tests. I have disabled 2 lint rules in the process.

no-descending-specificity - this rule creates a lot of errors which would require fairly substantial reworking of some of our stylesheets in order to resolve. This would create a large and hard to review PR. This rule also reports some false positives and trying to follow this rule can result in much less DRY code. From what I can see of reading around the web a little, a lot of people are disabling this rule for similar reasons. There are open bug reports about the issues against the stylelint project.
no-empty-source - the current config of our build process expects there to be an scss file to go with each component. If we remove the empty files (there are only 2 of them) then the build process breaks.

utACK f3bf899


Formalize policy on pip compatibility

We should define a formal policy on the pip functionality and workflows we want and don't want to support. This helps us triaging issues and users to understand the scope of uv pip.

We now have a document that summarizes our compatibility policy, and highlights many of the areas of incompatibility: https://github.com/astral-sh/uv/blob/main/PIP_COMPATIBILITY.md


Conversion to mobi is not creating landscape pages

Conversion (cbr > mobi) looks great but there are some pages that are supposed to be displayed together but aren't.
When converting from cbr to pdf using calibri this feature works fine
Cant find anything about it in wiki

Show a screenshot of your kcc settings. @Luttudo
Do you have landscape split unchecked?
Are the images already split in the original CBR?

It worked. Thanks!!


Bag with data tuples

There is a bug when data corrupted in a weird way after the filters are applied and if row count is more than one. Presumably the data tuples is parse like one string and then placed in table
https://analytics.community.intersystems.com/dsw/index.html#/ALLCOMMUNITY/AIAnalytics.dashboard?FILTERS=TARGET:*;FILTER:[CountryCode].[H1].[CountryCode].{%26[Argentina],%26[Armenia]}&widget=OverallAIInfo
The first column of the second row placed in the last column of the first row and so one

ZEN displayed the data in a correct way

Done in back-end


Add documentation to Developer's Guide for GTEST DISABLE_ Macros

Follow up from https://gitlab.com/autowarefoundation/autoware.auto/AutowareAuto/-/issues/573
Description
Disabling tests should be done via DISABLE_ prefixes on tests so that they aren't forgotten.
Expected behavior
The Developer's Guide should contain this information.
Definition of Done

[ ] Add information about using the DISABLE_ prefixes to the Developer's Guide

Please assign to me.

Please assign to me.

@JWhitleyWork Thanks, I will do it once we have a place to put this, currently we are preparing the bare-bones of the documentation.


Update README.md

Restructure, correct typo and format

Thanks for your contribution.
@vlinkz Are we merging this? It looks good to me ;()


Add any files in /generic to the firefox core build

Fixes #1067
Tested by running uProxy in Firefox and running grunt test

:+1:


commented out psycopg2 to see if we even need it...

IBM Cloud toolchain: Delivery Pipeline deployed orders to dev, including commit 182d925868b8b3246e93febf5d6b590dc62ddc80


[chip-test] alert_handler_reverse_ping_in_deep_sleep

Check that escalation receivers located inside always-on blocks do not
auto-escalate due to the reverse ping feature while the system is in deep
sleep.
Signed-off-by: Miguel Osorio<EMAIL_ADDRESS>

Hi @cindychip, I updated the test to enable and check all local alerts. I also added a flag to the ISR to fail the test if there are any alert interrupts detected. PTAL. Thanks!

@moidx here is the run result in dv:
Maybe we can set the run_timeout_min to 4 hours?
### Test Results
|  Stage  |                       Name                       | Tests                                            |  Max Job Runtime  |  Simulated Time  |  Passi
ng  |  Total  |  Pass Rate  |
|:-------:|:------------------------------------------------:|:-------------------------------------------------|:-----------------:|:----------------:|:------
---:|:-------:|:-----------:|
|   V2    | chip_sw_alert_handler_reverse_ping_in_deep_sleep | chip_sw_alert_handler_reverse_ping_in_deep_sleep |      3.443h       |    255.146ms     |     1
    |    1    |  100.00 %   |
|   V2    |                                                  | **TOTAL**                                        |                   |                  |     1
    |    1    |  100.00 %   |
|         |                                                  | **TOTAL**                                        |                   |                  |     1
    |    1    |  100.00 %   |

hey all,
i've been staring at this test a bit, and now i'm not sure how we really should be testing this. Because it's IMO a combination of hardware / software / system behavior.
From what I can see, the most likely way a failure will trigger is a combination of two things:

we screw up the clock / reset controls somehow such that pwrmgr escalation receiver gets out of sync from the alert_handler.
after a low power event, the software for whatever reason takes an enormous amount of time before it enables pings again.

The first event will cause the pwrmgr escalation receiver to think that it should keep counting even though the alert handler has gone offline.
While the latter (if the limit is 175ms..it's not inconceivable software might run into this, since as far as I can tell rom doesn't enable the ping) would mean the alert handler doesn't ping the escalation for some time, causing it to auto-escalate.
The test case we have here I feel like is not very likely to ever flag an error (though it is still good to have) because most of the "time" in the test I think is used in pre-sleep, and it's not very likely things will go out of sync there.
The only way I can think of to test this is to hit the alert handler / pwrmgr combintation repeatedly with different kinds of sleep over and over with real software / or introduce artificial delays on the software, but all of this is going to take way too long in simulation.  We could run it in FPGA, but this would be something that should be run for hours.
I think at a minimum I should probably add some assertions to ensure the escalation receiver and alert_handler cannot get out of sync, but beyond that I don't really know how to make this better.... any thoughts?

i think what i'm trying to say is that the purpose of these tests is probably to look for places where alert handler and pwrmgr get out of sync. But in this test, there's really only one moment where that could happen.  And even if things DID get out of sync, it would require software to behave in an expected way to actually manifest an error.  So I wonder if it makes more sense to codify what we think are the properties into cross module assertions, and then just try to stimulate it as much as possible.

Hi @tjaychen, for the long running test you are describing, we could simulate different pwrmgr transitions in a similar way to pwrmgr_deep_sleep_all_reset_reqs_test.c with additional random delays in software while enabling/checking alerts on each power cycle. I can probably write that as a separate test if it makes sense. wdyt?

Thanks Tim and Miguel for the suggestions.
I think Tim's concern is totally valid, because prim_esc_receiver does not have any status register to tell which state is it at, if reset happened or not, or if this counter is reset to 0.
1).  To address pwrmgr and prim_esc_receiver not in sync: I can only think of probing some internal signals, or write assertions, as Tim suggested.
To unblock this PR from reviewing/merging, I will create a separate issue for that.
2). To address pwrmgr and alert_handler not in sync:
@moidx's suggestion would work!

@tjaychen just to clarify, the out of sync scenario you mention should not be possible if everything is implemented correctly, right? i.e., the vectors you describe would only help to bias the test so that the involved mechanisms are used in a way that a bug (if there was one) would manifest more readily?

@tjaychen just to clarify, the out of sync scenario you mention should not be possible if everything is implemented correctly, right? i.e., the vectors you describe would only help to bias the test so that the involved mechanisms are used in a way that a bug (if there was one) would manifest more readily?

yeah. But I worry I'm being too specific on just clk/rst, so if you can think of any other areas we should target..we should probably think about that too.


Nginx w/ModSecurity 3.0 doesn't shut down workerprocesses

@petermollerud commented on Thu Nov 09 2017
After running Nginx 1.12.1 with ModSecurity 3 for a while, we have noticed that when we issue "service nginx stop" on Redhat EL6 - Nginx is unable to shut down all of its worker processes. They must be killed off separately using "kill". This is kind of annoying and isn't how it should be.

Hi @petermollerud,
Can you check the exactly point ModSecurity is stuck? You can use gdb for that. That will help a lot.

Hi @zimmerle ,
Yes I can try to do that. The problem is that this isn't occuring all the time, so I cannot reproduce the error in a controlled fashion. However, I'll look into GDB (never used it before) and see what I can do.

we encount this problem too, when run /usr/local/nginx/sbin/nginx -s reload,8 nginx workers process,sometimes has one worker process not quit,not happen every time.
CentOS 7.2
nginx 1.12.2
ModSecurity 3.0 rc1

I have not been able to reproduce the problem for the last week on our installation, so haven't gotten anywhere with GDB either...

I observed a similar problem.
Linux ip-172-18-147-255 4.4.0-1039-aws #48-Ubuntu SMP Wed Oct 11 15:15:01 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Our ModSecurity and ModSecurity-ngix are old.

ModSecurity: e14dc602e52a9fc231352729aaea16df3b239e14
ModSecurity-nginx: abbf2c47f6f3205484a1a9db618e067dce213b89

I'm using /dev/null as SecAuditLog.
gdb bt.
#0  __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1  0x00007efe231e5dbd in __GI___pthread_mutex_lock (mutex=mutex@entry=0x7efe2381f008) at ../nptl/pthread_mutex_lock.c:80
#2  0x00007efe22d12d0c in modsecurity::utils::SharedFiles::write (this=<optimized out>, fileName="/dev/null",
    msg="XXXX"..., error=error@entry=0x7ffc8128a850)
    at utils/shared_files.cc:230
#3  0x00007efe22cac18b in modsecurity::audit_log::writer::Parallel::write (this=0x28775b0, transaction=0x2f1fc20, parts=<optimized out>,
    error=0x7ffc8128a850) at audit_log/writer/parallel.cc:166
#4  0x00007efe22ca9f75 in modsecurity::audit_log::AuditLog::saveIfRelevant (this=<optimized out>, transaction=transaction@entry=0x2f1fc20,
    parts=parts@entry=6006) at audit_log/audit_log.cc:296
#5  0x00007efe22c98558 in modsecurity::Transaction::processLogging (this=0x2f1fc20) at transaction.cc:1274
#6  0x00007efe22c98735 in modsecurity::msc_process_logging (transaction=<optimized out>) at transaction.cc:2102
#7  0x000000000048f269 in ngx_http_modsecurity_log_handler (r=<optimized out>)
    at /var/chef/cache/ModSecurityNginxConnector-abbf2c47f6f3205484a1a9db618e067dce213b89/src/ngx_http_modsecurity_log.c:72
#8  0x0000000000449625 in ngx_http_log_request (r=r@entry=0x1528c80) at src/http/ngx_http_request.c:3530
#9  0x000000000044ad5a in ngx_http_free_request (r=r@entry=0x1528c80, rc=rc@entry=0) at src/http/ngx_http_request.c:3477
#10 0x000000000044b54f in ngx_http_set_keepalive (r=0x1528c80) at src/http/ngx_http_request.c:2910
#11 ngx_http_finalize_connection (r=r@entry=0x1528c80) at src/http/ngx_http_request.c:2561
#12 0x000000000044be9f in ngx_http_finalize_request (r=r@entry=0x1528c80, rc=<optimized out>, rc@entry=0)
    at src/http/ngx_http_request.c:2457
#13 0x000000000045a429 in ngx_http_upstream_finalize_request (r=r@entry=0x1528c80, u=u@entry=0x1de26f0, rc=rc@entry=0)
    at src/http/ngx_http_upstream.c:4382
#14 0x000000000045b171 in ngx_http_upstream_process_request (r=r@entry=0x1528c80, u=u@entry=0x1de26f0) at src/http/ngx_http_upstream.c:3963
#15 0x000000000045b386 in ngx_http_upstream_process_upstream (r=0x1528c80, u=0x1de26f0) at src/http/ngx_http_upstream.c:3875
#16 0x000000000045a4a5 in ngx_http_upstream_handler (ev=<optimized out>) at src/http/ngx_http_upstream.c:1245
#17 0x0000000000437efb in ngx_epoll_process_events (cycle=<optimized out>, timer=<optimized out>, flags=<optimized out>)
    at src/event/modules/ngx_epoll_module.c:902
#18 0x000000000042f732 in ngx_process_events_and_timers (cycle=cycle@entry=0x141b650) at src/event/ngx_event.c:242
#19 0x0000000000435e63 in ngx_worker_process_cycle (cycle=cycle@entry=0x141b650, data=data@entry=0x3)
    at src/os/unix/ngx_process_cycle.c:749
#20 0x0000000000434900 in ngx_spawn_process (cycle=cycle@entry=0x141b650, proc=proc@entry=0x435df2 <ngx_worker_process_cycle>,
    data=data@entry=0x3, name=name@entry=0x493cb7 "worker process", respawn=respawn@entry=-4) at src/os/unix/ngx_process.c:198
#21 0x0000000000435fd3 in ngx_start_worker_processes (cycle=cycle@entry=0x141b650, n=4, type=type@entry=-4)
    at src/os/unix/ngx_process_cycle.c:358
#22 0x0000000000436eba in ngx_master_process_cycle (cycle=0x141b650, cycle@entry=0x13f81a0) at src/os/unix/ngx_process_cycle.c:243
#23 0x0000000000411f83 in main (argc=<optimized out>, argv=<optimized out>) at src/core/nginx.c:375

I'm going to update modules to the latest but it would take time to capture the symptom again. Meanwhile, let me know anything you want to investigate more.

I believe this problem could be related with the one reported on issue #1927. PR #1949 addresses that and was merged at 3d2030.
Please let us know if the issue still persists with the latest code and we can investigate further. Thanks!


The "Availability set" option is not available in current Azure portal. Please kindly update the document below to avoid any confusion.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f9b2908-f032-3f26-76de-6e6edf356f40
Version Independent ID: bfe6017f-306b-f502-e984-5558ce7de732
Content: Tutorial: Create an internal load balancer - Azure portal - Azure Load Balancer
Content Source: articles/load-balancer/tutorial-load-balancer-basic-internal-portal.md
Service: load-balancer
GitHub Login: @asudbring
Microsoft Alias: allensu

@Juh-net Hope you have self resolved and hence closed the issue. Thanks for the update.


Fixes #374

merged preact-cli created config into firebase hosting key
to preserve other config options

It looks like this should still work with simplehttp2server.


run-checker-daily.yml: If the openssl app is not built do not run it

This fixes the current runchecker daily failures.

This pull request is ready to merge

Pushed. Thanks.


The nav bar and the tab bar block my scene

Version
Tell us which versions you are using:

react-native-router-flux v3.30.0
react-native v0.25.1

Expected behaviour
My scene shouldn't be blocked by the navbar and the tabbar when no sceneStyle is specified.
Actual behaviour
My scene is blocked so I have to specify the sceneStyle.
Steps to reproduce

Just use the example and change the style a little

A cheap hack I use is to pad the view by Navigator.NavigationBar.Styles.General.TotalNavHeight.

There is a small snippet in the example app that handles this.

if (computedProps.isActive) {
    style.marginTop = computedProps.hideNavBar ? 0 : 64;
    style.marginBottom = computedProps.hideTabBar ? 0 : 50;
  }

Hi @mickeyinfoshan please be more specific. Ideally share a screenshot. Overall please explain what do you mean by block?

I confirm this issue, I just ran on it.
I'll give more details soon.

I don't know if it what's @mickeyinfoshan means.
If you remove hideNavBar from the Example (here), you won't be able to swipe back with Android because the scene will be blocked in transition.
Any ideas?
cc @aksonov @rturk @sarovin

@charpeni I ran into the problem @mickeyinfoshan is having, and it's different from what you're describing here:

If you remove hideNavBar from the Example (here), you won't be able to swipe back with Android because the scene will be blocked in transition.

The problem I run into is that the navbar seems to be overlaid on the scene so if I display something at the top of the view it will potentially be covered by the navbar.


Does the licence apply to the svg icons?

I'm working on a VS Code extension for Racket (Magic Racket) and I'd like to use your icons for "Run file in terminal" and "Run file in REPL" — not only because I want to spare myself the work of drawing a triangle, but also because I'd the users to have a consistent experience across languages and environments (and the users are already used to your icons and their meanings). I'm just checking if you are okay with that :-)
Btw, great extension, thank you for the great work!

Thanks for filing this issue, I'll wait for someone with a little bit more knowledge on license to get back to you. In the mean time, please have a look at https://github.com/vscode-icons/vscode-icons (these are Icons used by VS Code).

Hi @Eugleo 👋
Yes, the icons are under MIT.


[fix-4291][UI] user management authorization operation exceptions do not prompt exception information

What is the purpose of the pull request
#4291
fix user management authorization operation exceptions do not prompt exception information
Brief change log
add  .catch(e => {
this.$message.error(e.msg || '')
})
Verify this pull request
This change added tests and can be verified as follows:

Manually verified the change by testing locally.

Codecov Report

Merging #4292 (659cfb0) into dev (de1b87f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #4292      +/-   ##
============================================
- Coverage     43.18%   43.17%   -0.02%
- Complexity     3160     3169       +9
============================================
  Files           466      467       +1
  Lines         21619    21668      +49
  Branches       2614     2621       +7
============================================
+ Hits           9337     9355      +18
- Misses        11383    11414      +31
  Partials        899      899

Impacted Files
Coverage Δ
Complexity Δ

...inscheduler/service/zk/CuratorZookeeperClient.java
60.97% <0.00%> (-4.88%)
7.00% <0.00%> (-1.00%)

...dolphinscheduler/remote/command/CommandHeader.java
100.00% <0.00%> (ø)
11.00% <0.00%> (+4.00%)

...scheduler/service/queue/TaskPriorityQueueImpl.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...r/server/master/runner/MasterSchedulerService.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...server/master/runner/MasterBaseTaskExecThread.java
35.41% <0.00%> (ø)
10.00% <0.00%> (ø%)

...ver/master/consumer/TaskPriorityQueueConsumer.java
54.83% <0.00%> (ø)
21.00% <0.00%> (ø%)

...e/dolphinscheduler/server/entity/TaskPriority.java

...e/dolphinscheduler/service/queue/TaskPriority.java
0.00% <0.00%> (ø)
0.00% <0.00%> (?%)

...olphinscheduler/remote/command/CommandContext.java
70.00% <0.00%> (ø)
5.00% <0.00%> (?%)

...he/dolphinscheduler/remote/codec/NettyDecoder.java
84.61% <0.00%> (+0.83%)
7.00% <0.00%> (+1.00%)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1b87f...659cfb0. Read the comment docs.


Catch docstring yields

Catch yields section in docstrings

Thanks a lot for the suggestions! I've applied those suggestions; so please feel free to re-review them 😊


config: removing deprecated sds_config

Also cleans up the release notes from #5288
Living dangerously: sending this out at EoD though my local build has only verified 1/3 of the tests pass after merge with #5288 but I'd like @htuch 's take on if we can kill this field off now or if I should wait for the week or two until we cut 1.9.  If tests fail everyone else can ignore this until Monday :-P
Risk Level: Medium (unclear who is still using deprecated config)
Testing: existing tests pass
Docs Changes: n/a
Release Notes: inline

Will reopen once we cut 1.9.  Figured it was close enough it was worth making the PR either way :-P


Major refactoring

Changes:

Added clap for options management
Added --indicator with templates instead of --main-indicator. Example in README.md
Bumped dependencies' versions
Added --imperial option instead of --fahrenheit. It now makes wind speed to be displayed in MPH. --fahrenheit is a hidden synonym for now.
Now wttrbar spawns on waybar start/reload and stays running. Json output is generated periodically - 30 minutes as default, with option --interval to control it (in minutes, minimum is 30). Added corresponding changes into README.md.
Note: if you have wttrbar module on more then one output, it will spawn same number of processes and they will fetch data from wttr.in independently. Prior version. that used interval setting of waybar module suffers from this too, but wttrbar process is not running constantly, so it is not noticeable.
Changed Information about waybar module settings in README.md - no need for "interval" field now.

This PR includes changes from #22, so it may be merged after or instead of it.

hey @nut-3  - many great fixes here, thank you. I also wrote on another PR - what's the benefit of having the process always running vs spawning it every 30 minutes? I feel like if it's always running there will always be the risk of introducing some memory leak

hey @nut-3 - many great fixes here, thank you. I also wrote on another PR - what's the benefit of having the process always running vs spawning it every 30 minutes? I feel like if it's always running there will always be the risk of introducing some memory leak

Hi, @bjesus . As for daemon vs spawning. Most important draw is the ability to limit wttr.in requests frequency. With spawning you can only rely on users' decency to not send requests too often.
Another one is that it will be easier to sync daemon instances' data in multi-monitor setup. As you may know, waybar spawns one custom module process for each monitor on which this custom module is configured. I've thought that in the future it might be interesting to implement feature that lets several wttrbar processes to use common response data from wttr.in.
Well, If you don;t like such drastic architectural changes, feel free to just copy parts you want. Or I can make another pr with parts you want in you project.

Hey, thanks for clarifying. I wouldn't want to hurt the wttr.in service but I also see limiting the requests frequency as a out of the scope here - I'll happily add a notice to the readme though. I'm more concerned about breaking the current behavior of wttrbar for existing users who will just update and expect things to work as usual.
all the rest of the PR seems great and I'd love to merge it. If you can make a PR without the constant running process I would to merge it, otherwise I'll try looking into it myself sometime next week 🙏

I think we need to use nut-3 method as wttr.in been having stuggles being online this week as the server been over max amount of request...
If you still want to have the old method can we have a flag for those that want to use the old method of getting requests and have the new method be the default so save the wttr.in servers

(1) I saw no indication that wttr.in was down because of load, and I would be very flattered to think that if it was, wttrbar has anything to do with it. (2) afaict, the wttr.in repo itself includes examples (e.g. tmux) that are querying every minute. (3) changing the way wttrbar works, from what I understand, can actually cause more traffic to wttr.in, because most users will not update their waybar config, meaning that new processes will be spawned and each process will keep sending a request every given interval.
I released 0.7.1 now which includes a simple 10 minutes caching. It simply saves the response to a temporary JSON file, and if the file is fresh (i.e. newer than 10 minutes ago) it just reads from it instead of making a request. This should work seamlessly to all existing users, and would make sure we never have to worry about memory leaks as the process still dies after execution.

Nice I like the fact it's caching the response now instead of sending a request to get info every second. I would be Oki merging nut-3 and my fork with that change

closing this PR as it has conflicts and doesn't seem to be updated. please open a new merge-able if you want


Void and open-close node configuration

I was just working on hast-include (similar to posthtml-include), to show the difference between PostHTML and hast, and ran into the problem of configuring void nodes (used to control whether or not an ending tag is expected) and open-close nodes (used to determine which opening tags implicitly imply the closing of other elements).
Now, plug-ins might want to configure these mappings, e.g., the include plug-in defines a custom include element which is a void element. It should be parsed and compiled (and maybe treated by other plug-ins?) as void.
To ensure this, I propose exposing the void and open-close dictionaries on either file or processor.
E.g., file.namespace('hast').void or processor.void.
The disadvantage of this is that, when patching file, users have to keep track of that (e.g., when running parse, run, and compile with different parsers). The disadvantage of patching processor is that currently, Parser and Compiler have no access to it (but that’s fixable of course)!

@eush77 thoughts? (sorry for bugging you haha :wink:)

I would say that file is an obscure place for this, and parser/stringifier configuration should got to Parser or Stringifier (or processor)?
I doubt that having multiple sources of such configuration is a good idea (what happens if they conflict? what should plugins do — add configuration to both or pick one? which one?). file.namespace('hast').void would probably represent “file-wise” configuration and take precedence over processor.void, but I think file has nothing to do with parsing or stringifying at all, unless I'm missing something.

processor it is; I think I’ll add support for a data dictionary on it, similar to VFile’s and Unist nodes!


PKCE for msal-node auth code flow with confidential client best practise?

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
1.2.0
Wrapper Library
Not Applicable
Wrapper Library Version
None
Description
I am assuming playing with the below samples that the implementation should be largely the same for a confidential client?
[1] https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/samples/msal-node-samples/auth-code
[2] https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/samples/msal-node-samples/auth-code-pkce
The samples both appear to still work if I switch in ConfidentialClient per the docs for the auth-code demo
Playing with [3] https://github.com/microsoftgraph/msgraph-training-nodeexpressapp and having read https://oauth.net/2/grant-types/authorization-code/ I gather it is sensible to use PKCE for auth-code even in the case of a confidential client? Can I check my understanding of that is correct?
I've added the PKCE code from [2] to [3] and all seems to work fine testing locally with only a single user. But I can spot a possible problem with doing this, but before I move on to ask about that can I check if my understanding up to this point is correct? Many thanks in advance!
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@DevRCRun PKCE can be used by all clients (Confidential & Public). We did not specify samples for confidentialClient since we do not have too many clients using PKCE on ConfidentialClientApplication.
We can add the support, however.
Can you please elaborate the possible problem you envision here?

@sameerag thanks for your reply, it would be a helpful clarification in the samples for me, given that the Oauth site and various MS pages recommend PKCE for both client types (unless I'm reading them wrong?)
The query I have may be a flaw in my understanding of the flow in the auth code PKCE example.
First the PKCE code object is initialised:
 // Set up PKCE Code object in app's local memory so it's shared between routes
 app.locals.pkceCodes = {
 challengeMethod: 'S256', // Use SHA256 Algorithm
 verifier: '', // Generate a code verifier for the Auth Code Request first
 challenge: '' // Generate a code challenge from the previously generated code verifier
}

Then in the route that kicks off the first leg the verifier and challenge are generated for the request and the PKCE code object updated
// Initialize CryptoProvider instance
const cryptoProvider = new msal.CryptoProvider()

// Generate PKCE Codes before starting the authorization flow
const { verifier, challenge } = await cryptoProvider.generatePkceCodes()

// Set generated PKCE Codes as app variables
app.locals.pkceCodes.verifier = verifier
app.locals.pkceCodes.challenge = challenge

In the redirect route the previously generated codeVerifier from the PKCE code object is again supplied for the second leg
// Add PKCE code verifier to token request object
const tokenRequest = {
    code: req.query.code,
    scopes: ["user.read"],
    redirectUri: "http://localhost:3000/redirect",
    codeVerifier: app.locals.pkceCodes.verifier, // PKCE Code Verifier
    clientInfo: req.query.client_info
};

My understanding is that the codeVerifier needs to match otherwise Azure will reject the transaction? (if I take codeVerifier out of tokenRequest this indeed seems to be what happens).
What I'm confused about, is on a busy enough app I feel it might be possible for another request to hit the first route before the users browser hits the redirect route. Because the verifier and challenger appear to be overwritten in app.locals by the first route, the verifier taken from app.locals and used in the redirect route would then be different from that generated for the corresponding initial request.
Otherwise I think I must be misunderstanding how things work behind the scenes?
Thanks for your time

@DevRCRun you're basically right. The sample is using app.locals since it's primarily meant for testing and not for actual usage (and also to avoid having an extra dependency), but in reality you should consider using a session solution that would allow you to store these variables on a user/request basis. We'll consider revising the samples to make this point clear.

Thanks for the clarification, a note in the sample would be helpful.

@DevRCRun Thank you for the feedback.
@derisen Let's note this in the sample work we are planning. Closing this.


Filtering lookup editor

First of all, I'm sorry for this stupid question, and my poor English ):
I have a lookup editor which is based on a database tabe, I want load some of the records in the table based on the value of a column 'type' ( an int16 type column).
How and where can I apply this (where type=1)?
Can I do this by using ordanary lookup script on the table row class, or I have to write a custom lookup class?
Any example will be helpful.
Thanks in advance.

See https://github.com/volkanceylan/Serenity/issues/184

Thanks for you reply.
But, for the server side implementation,  instead of constant value
query.Where(XYZRow.Fields.XyzID != 0);`
I want to pass the value dynamically at run time, some thing like
query.Where(XYZRow.Fields.XyzID != parameter);
How can I achieve that?

You can't. See filtered lookup in dialog sample.

Thanks Volkan,
I achieved by using filterField and filterValue.


New kernelmodule build container

What is different now?

Deliver linux-image debug symbols via gardenlinux apt repo
Pins linux-* packages to gardenlinux apt repo, but keeps debian repo as package repo for typical build dependencies
arm64 and amd64 build container
Version of kernelmodule build container matches the target Garden Linux Version

e.g. a  gardenlinux/build-kernelmodule-amd64:1079  container has the header and debug symbols installed for garden linux 1079

TODO: integrate in release pipeline and publish images to a registry


.aspx.designer.cs are not updated on .aspx save

Hi, let me first tell you this project is awesome. I'm testing it on our rather complex solution and it seems to work as smooth as Visual Studio should just do. This is great!
I am however experiencing an issue with aspx pages (no MVC here, plain old Web Forms). To reproduce it, create a new project using the Empty C# template (sdk 4.0.47), then add a web form called Default.aspx , complete with its codebehind Default.aspx.cs and its designer file Default.aspx.designer.cs.
Add a new <asp:Label runat="server" id="myLabel"></asp:Label> control and save the .aspx file. The control member variable should be available in the .designer.cs now, but it's not. It seems like the file is never regenerated.
Do you have any idea why?

I am looking to try and capture information from the issues into documentation. It looks like this is a limitation that does not have a solution for us just now (barring some help from the VS team on the designer side). This would obviously go into a 'known limitations' area of the documentation.
Documentation?

@CZEMacLeod Not sure if this is something you could/would integrate, but there is an open source .designer.cs generator tool:
https://github.com/seanofw/Redesigner

Seems like an interesting project.  I myself thought it would be nice if it were possible to use a source generator to generate the designer files.  Maybe even it might be possible to reimplement the Redesigner project as a source generator.  Not sure if it would actually be possible, given that, as far as I know, source generators execute in a .NET 5 runtime, and I'm not sure what dependencies on .NET Framework are required.

@AvremelM @TheJayMann I would have thought it could maybe run as an MSBuild task a bit like RazorGenerator's RazorGenerator.MSBuild package. The designer files would be generated on demand as part of the build process. Unfortunately, I'm not sure that is entirely possible for these specific files; especially as that project requires that the assembly can build first to regenerate the files.
It seems likely that it would be possible to make this project into a visual studio extension though, which could be invoked manually as and when required.

It seems likely that there's a way this could be done programmatically via System.Web.Compilation,
I just can't figure out if the functionality for generating the designer source is built-in, or if it just builds the type and then VS generates the source from that.

For all the ReSharper users: We had exactly the same issue and solved it by adding an explicit Update ASP.NET Designer File command to the ReSharper Roflcoper extension (requires the current R# 2021.2, can be installed in the ReSharper extension manageer).
See: https://github.com/ulrichb/Roflcopter/blob/master/README.md#update-aspnet-designer-file-r-only

RE: @CZEMacLeod @AvremelM
The .designer.cs files can be generated by the old System.Web compiler used in (deprecated) Web Site projects (which is also why they don't have/need these files).
To test this I have used an old Web Site project that does not have .designer.cs files.
This is the example code that generates the designer file:
var cbm = new System.Web.Compilation.ClientBuildManager("~", @"<project dir>");
var code = cbm.GenerateCode("~/Menu.aspx", File.ReadAllText(@"<project dir>\Menu.aspx"), out var tbl);

The variable code now contains the code for Menu.aspx.designer.cs.
Unfortunately, this example is not suitable for source generators or most design-time tooling because it will compile the application partially and will read many other files in the background. In fact, it might be identical to the Build Page action in VS (for Web Site projects).
The source code of this compiler is available here as part of .NET Framework. In particular, PageCodeDomTreeGenerator is the class that generates designer code for aspx files. Even so, for use as a source generator this might need to be completely rewritten, including the aspx parser (System.Web.UI.PageParser).

Update: I was wrong about System.Web.Compilation, which turned out to be a good thing.
The .designer.cs files generates in VS contain only field definitions, while the files generated by the System.Web compiler contains all of the required code at runtime (such as event handler wiring and control initialization).
Even when published, the main DLL is compiled against these incomplete designer files while the "real" code is generated at
runtime. Only precompiling the app can skip this runtime step (and fortunately precompiling still works via MSBuild publish so I don't need to reimplement it).
This means that the task of generating .designer.cs files is relatively easy.
I am now using AspxParser (with a minor modification) to parse the pages and some logic lifted from the reference source to determine the types of fields to generate.
Here are the basics:

The target project must contain the following in the csproj:
<ItemGroup>
	<AdditionalFiles Include="**\*.aspx" Exclude="$(DefaultWebFormsItemExcludes)" />
	<AdditionalFiles Include="**\*.ascx" Exclude="$(DefaultWebFormsItemExcludes)" />
	<AdditionalFiles Include="**\*.master" Exclude="$(DefaultWebFormsItemExcludes)" />
</ItemGroup>
<ItemGroup>
	<Reference Include="System.Web.Extensions" />
</ItemGroup>

Parse web.config section /configuration/system.web/pages/controls/add
Add the entries after the following list of defaults (mostly taken from here)
<add tagPrefix="asp" namespace="System.Web.UI.WebControls" assembly="System.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
<add tagPrefix="mobile" namespace="System.Web.UI.MobileControls" assembly="System.Web.Mobile, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
<add tagPrefix="asp" namespace="System.Web.UI" assembly="System.Web.Extensions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35" />

The above list is global, but each page also has its own Register directives which must be considered first.
These directives can be used to look up control types via the module symbols made available to source generators. No assembly loading or reflection needed!

DFS traversal of the ASPX syntax nodes is required with the following logic to detect and skip multiple instance templates

If an HTML control node with an ID and runat="server" is encountered:

Use HtmlTagNameToTypeMapper to determine the field type
Generate a field
Continue iterating over children

If an ASPX server control node is encountered:

Use the registrations and symbols to find the type by metadata name
If it has an ID and runat="server", generate a field
Iterate over children, except those where the control type has a property with the same name of type ITemplate and does not have [TemplateInstance(TemplateInstance.Single)]
Exception: If the control type has any property like above but with [PersistenceMode(PersistenceMode.InnerDefaultProperty)], skip all children entirely

For any other node type, continue iterating over children

What works:

IntelliSense
Publishing via MSBuild
Precompiled publish

What does not work:

WCF service references or App_WebReferences. Tooling in VS uses dotnet-svcutil which works but requires major code changes.
Add new item does not contain any Web Forms item templates

Many things weren't tested yet because my source generator is very incomplete and not optimized.

@OronDF343 This looks like interesting stuff. Should we perhaps move this over to a new issue or a discussion; specifically something like "Add a source generator to enable .designer.cs updates"?
Are you thinking of making your code public? And would you like to add it to this repository or maintain it yourself?
As this would not be relevant for all users of this SDK, I would suggest that we move it to its own package - perhaps MSBuild.SDK.SystemWeb.WebForms' or similar. Then either add it as a package reference, or we could make it a standalone top level SDK (probably relying on MSBuild.SDK.SystemWeb` underneath it).
I'm not quite sure if VS can handle injecting new 'add item' types from an SDK or other nuget package; I know that project types can be done via the templates package: MSBuild.SDK.SystemWeb.Templates.
It might be that to enable that would require building a VSExtension which would need to be installed. (Not my favourite solution as then you need to ensure that the extension is installed on any machine you are using to work on the project).

@CZEMacLeod Sure, I'll open a discussion once I have more to share. It might take a while for me to have an update on this, and the decision to make the code public partly depends on my employer as this all started as an internal tool to improve maintainability of older applications. In testing my proof of concept against a very large Web Forms project, I have found many more smaller issues that need to be addressed before it is usable for real-world projects.

Should this be closed?  This is still unresolved / a known issue

@jeffjmc Unfortunately, this is a known limitation, and is not something that can be addressed within the SDK. It would require input from the Visual Studio team to wire up the designer system to work with CPS and this SDK type, which is unlikely to happen for a deprecated technology.
This SDK makes it easy to continue to maintain existing projects, and potentially to work on migrating to ASPNet Core, perhaps using something like the https://github.com/dotnet/systemweb-adapters project. It is not intended for use in 'green field' development as Net 4.x is not the place for that.
If you need to work on webforms code, and require designer support, then I would suggest keeping a branch of your project in the legacy format where you can do such work.

Technically Web Forms isn't officially deprecated (though obviously, it de-facto is), so maybe a feature request to just expose the existing functionality for generating designer files wouldn't be completely crazy?
And also, they still haven't closed https://github.com/dotnet/project-system/issues/2670 yet, so theoretically... 😅
(Or maybe JetBrains would open source their implementation, which they developed just a couple years ago for Rider, but that seems less likely somehow.)


Gallery goes upside down when going back

First of all, such an amazing work! I've started using it in one of my projects.
I've noticed a bug as I was walking around the gallery (attaching a screenshot):

This happens when I go towards the end and try to come back where I started or even sometimes in the middle when looking up. I'm also attaching a short video of this here:
https://user-images.githubusercontent.com/33711869/160363966-7e9e25d7-97e8-40f6-b904-4fdb20c670e6.mp4
This is in Chrome. I've not checked it in other browsers.

It seems to happen whenever you walk right up to a wall, then turn around.

@bootkernel did you get a solution for this issue ? @ClementCariou are you working on this ? and thanks for this amazing work !

@bootkernel did you get a solution for this issue ?

No I wasn't able to find a solution for this.

The problem is fixed.


Bug in 4d-plugin-curl-v3 4.1.0 with HTTPHEADER

I upgraded the curl plugin to 4.1.0, and now i can’t set custom http headers anymore. Following request
$options:=New object
$options.URL:="https://api-zoug.moments.dad-group.com/api/v5/area"
$options.HTTPHEADER:=New collection("accept: application/json";"pageLimit: 10";"pageCurrent: 1";"Authorization: Basic YXBpLmRvc2dyb3VwQGRvcy1nc206UGhhbGNvbjE1")

C_BLOB($request;$reponse)
$status:=cURL ($options;$request;$reponse)

sends this headers:
GET /api/v5/area HTTP/2
Host: api-zoug.moments.dad-group.com
accept: */*

Tested in v18R5 and v19.0 on MacOS 10.14.6 and in v18R5 on Windows 10 Pro.
Thanks for looking after
Ingo Wolf

could you please try 4.1.1.

Hello,
setting custom headers works in 4.1.1.
Thanks
Ingo Wolf


Custom message

As readme file, I don't see anything to talk about Custom error message. Do we support it?

Take a loop at #121

Yes, now we have support for custom error messages.


Vite + Vue 3 HMR runtime error

Vue version
3.2.41
Link to minimal reproduction
https://stackblitz.com/edit/vitejs-vite-rm74vp?file=src/App.vue
Steps to reproduce
Just try to edit non tag-wrapped text inside template
What is expected?
HMR will work well, edited text will stay actual
What is actually happening?
Runtime error
TypeError: Cannot set properties of null (setting 'nodeValue')
    at setText (vue.js?v=b62a0db1:7310:20)
    at processText (vue.js?v=b62a0db1:5245:9)
    at patch (vue.js?v=b62a0db1:5207:9)
    at patchKeyedChildren (vue.js?v=b62a0db1:5795:9)
    at patchChildren (vue.js?v=b62a0db1:5755:11)
    at processFragment (vue.js?v=b62a0db1:5498:9)
    at patch (vue.js?v=b62a0db1:5220:9)
    at ReactiveEffect.componentUpdateFn [as fn] (vue.js?v=b62a0db1:5675:9)
    at ReactiveEffect.run (vue.js?v=b62a0db1:388:19)
    at instance.update (vue.js?v=b62a0db1:5710:52)

System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vue: ^3.2.41 => 3.2.41

Any additional comments?
The bug is clearly related to the fact that the template uses variables obtained asynchronously. In my case - joke

Seems to be a duplicate of #6852. Note the current direct use of Text as a child of Fragment is problematic.
@posva @edison1105 The problem has been feedback from many people, hope to increase the priority.

@zhangzhonghe thanks.
close as duplicated.


errors for cursormove and cursorhold with ensime and neovim.

Steps to reproduce

Install ensime plugin using plug in neovim () on ubuntu 14.04
run ensimeConfig in sbt project
Open a scala file in above project

Expected behaviour
Not get errors, ensime comands work
Actual behaviour
I get the following error on almost every key press and it every couple of seconds even if I don't do anything:
Error detected while processing CursorHold Auto commands for "*.scala":
error caught in request handler '/home/thayne/.config/nvim/plugged/ensime-vim/rplugin/python/ensime.py:autocmd:CursorHold:*.scala ('chart-web/app/com/lucidchart/Utils.scala',)':
Traceback (most recent call last):
  File "/home/thayne/.config/nvim/plugged/ensime-vim/rplugin/python/ensime.py", line 177, in au_cursor_hold
    super(NeovimEnsime, self).au_cursor_hold(*args, **kwargs)

If I press enter I see this:
Error detected while processing CursorHold Auto commands for "*.scala":
TypeError: super(type, obj): obj must be an instance or subtype of type

This makes the editor completely unusable with the plugin installed.

It is probably related to this: https://thingspython.wordpress.com/2010/09/27/another-super-wrinkle-raising-typeerror/
I am on python 2.7.6

Hi @tmccombs,
Could you start vim with debugging enabled (vim -V9vim.log) and check in the file vim.log if you see any other clue what the problem can be?
Cheers.

It appears the problem was that I had copied the rplugin code into a different place in my runtime path.
Deleting that fixed it. Although it is incredibly slow, and sometimes commands don't seem to do anything.


implement builtin_string/instr_binary

Signed-off-by: TigerInYourDreams<EMAIL_ADDRESS>What have you changed? (mandatory)
Implement the function instr_binary which I found in #3275
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Add instr_binary function.
What are the type of the changes? (mandatory)
Add function。
The currently defined types are listed below, please pick one of the types for this PR by removing the others:

New feature (change which adds functionality)

How has this PR been tested? (mandatory)
Unit Test。
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No

/test

@TigerInYourDream Would you like to fix the bug?

@TigerInYourDream Would you like to fix the bug?

@AndreMouche My bad.I'll create new pr to fix it. Thanks for your help.


Named slots error introduced in 0.7.2

Using named slots defined with <template v-slot:slotName></template> are throwing the error below
[vite] Internal server error: Codegen node is missing for element/if/for node. Apply appropriate transforms first.   Plugin: unplugin-vue2-script-setup
The shorthand does not throw the error <template #slotName></template>
unplugin-vue2-script-setup 0.7.2 and up are throwing the error
vue 2.6.11
vue/composition-api 1.4.1
vite 2.6.14

@martinglover fixed in https://github.com/antfu/unplugin-vue2-script-setup/pull/82


fix #1411 load extrascripts in Classic Test Runner

This PR adds the possibility to load in the Classic Test Runner
the extrascripts exposed in attester's config, when CTR is run
in isolated mode.
Previously, the extrascripts were injected by attester only to CTR's
index page, but CTR had no possibility to propagate those scripts
into the iframe when tests were run with #runIsolated=true in the URL.
This commit needs https://github.com/attester/attester/pull/121
integrated in attester in order for it to properly expose before
and after extrascripts.

The other 2 commits are just minor visual improvements

@divdavem I added a new commit removing force and just not storing scripts in array if they don't come from the main document. What do you think about it now?
It's a bit artificial to do it IMO but at least it doesn't break compat.

@divdavem
I fixed the querySelectorAll issue & rebased (I also reorder the commits)
Build failure is due to MapManagerTest random failure

@jakub-g Thank you.
:ok: 5a5a780f442634463a4435e5b1ac6122a8390e8a (and its 4 parent commits) is fine for me.

@divdavem thank you for the review!


[1.12.2] Crash when generating world with OTG v9.3 and BBOP v1.0

OTG Plugin or Mod
[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

[x] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[ ] 1.12.2_v8_r1
[ ] 1.12.2_v7_DEV_r26
[ ] 1.12.2-v6
[ ] 1.12.2-v5
[ ] 1.11.2-v8
[ ] 1.11.2-v9
[ ] 1.10.2-v21
[x] Other - specify here 1.12.2 v9.3

Forge or Spigot Versions
<IP_ADDRESS>54  mc 1.12.2
Server/Client Log
https://drive.google.com/file/d/1EFBf6sPTc8jFGH7dQvW6vV1TZg7o4T3e/view?usp=sharing
What other plugins are you running?
https://imgur.com/a/JoZARbh
Description
Hello! When I generate a new world with OTG and BBOP it crashes, ive tried to delete otgcore and the otg folder in the mods directory. (crash report: https://drive.google.com/file/d/1MduM6I3aHOqQl-OcLhEFZR7BytkgCilO/view?usp=sharing)
[What did you expect to happen? - Explain what you expected to happen after performing the previously described steps]
That the world is generated and opened correctly.
[Can you provide a Minimal, Reproducible Example? See here for details: https://stackoverflow.com/help/minimal-reproducible-example] Download this (https://drive.google.com/file/d/17Q7Apcv8BCjvyopKYdqHpi802N8-_AXl/view?usp=sharing) smaller modpack (about 15 mods) run it (for example with curse launcher and custom profile) and generate a world with OTG and BBOP, I dont know why it stopped crashing on the small test modpack then I deleted BBOP ingame, and restarted the game, but if I do that with my big modpack it doesnt fix anything, but the crashreport stacktrace seems the same or very similar.

For better communication im on the OTG discord server or zou can add me: MrProton#3228

The issue was caused by JustEnoughIds, after removing it and replacing with NotEnoughIds whitch doesnt change how biomeIds work, everything works fine, thx anyone on discord.


Cannot run kraken issuses

I tried to run kraken according to the following link:  https://github.com/cloud-bulldozer/kraken/blob/master/docs/installation.md, But the following error message appeared:
Git
root@node5:~/kraken# python3 run_kraken.py -c config/config.yaml
2021-10-31 18:15:33,077 [INFO] Starting kraken
2021-10-31 18:15:33,111 [INFO] Initializing client to talk to the Kubernetes cluster
2021-10-31 18:15:33,744 [INFO] Publishing kraken status at http://<IP_ADDRESS>:8081
2021-10-31 18:15:33,746 [INFO] Starting http server at http://<IP_ADDRESS>:8081
2021-10-31 18:15:33,751 [INFO] Fetching cluster info
error: the server doesn't have a resource type "clusterversion"
2021-10-31 18:15:35,183 [ERROR] Failed to run kubectl get clusterversion, error: Command 'kubectl get clusterversion' returned non-zero exit status 1.
root@node5:~/kraken#
Run containerized version
root@node5:~/kraken/containers# docker run --name=kraken --net=host -v /root/.kube/config:/root/.kube/config:Z -v /root/kraken/config/config.yaml:/root/kraken/config/config.yaml:Z -v /root/kraken/scenarios:/root/kraken/scenarios:Z -d quay.io/openshift-scale/kraken:latest
5495c5c3fb22f17d3a8259115d776bb2045f45bc3f9c8105d6ec1940b9567b7b
root@node5:~/kraken/containers#
root@node5:~/kraken/containers#
root@node5:~/kraken/containers# docker logs -f kraken
2021-11-01 07:51:16,194 [INFO] Starting kraken
2021-11-01 07:51:16,233 [INFO] Initializing client to talk to the Kubernetes cluster
2021-11-01 07:51:39,675 [INFO] Publishing kraken status at http://<IP_ADDRESS>:8440
2021-11-01 07:51:39,679 [INFO] Starting http server at http://<IP_ADDRESS>:8440
2021-11-01 07:51:39,680 [INFO] Fetching cluster info
error: the server doesn't have a resource type "clusterversion"
2021-11-01 07:51:44,257 [ERROR] Failed to run kubectl get clusterversion, error: Command 'kubectl get clusterversion' returned non-zero exit status 1.
kubernetes info:
root@node5:~/kraken/containers# kubectl get node
NAME        STATUS   ROLES                  AGE    VERSION
k8smaster   Ready    control-plane,master   199d   v1.20.5
k8snode1    Ready                     199d   v1.20.5
node3       Ready    control-plane,master   199d   v1.20.5
node4       Ready                     196d   v1.20.5
node5       Ready    control-plane,master   176d   v1.20.5
I don’t know the reason for the failure,Can someone explain it
If you need more information,please let me know.
Thx

I checked the source code. Many of them use OpenShift commands. Is it suitable for k8s clusters?

Hi @Fredericwu, thanks for reporting the issue. You are right, there are a couple of references to oc cli which we are planning to replace with kubectl. We have been testing/running Kraken on OpenShift at the moment but the plan is to definitely improve the coverage to make sure the scenarios work on Kubernetes environments as well. We are tracking it in the following issues: https://github.com/cloud-bulldozer/kraken/issues/185, https://github.com/cloud-bulldozer/kraken/issues/186. We will keep you posted. Thanks.

@chaitanyaenr is this still an issue?

@sandrobonazzola the failure reported in the issue is fixed by https://github.com/redhat-chaos/krkn/pull/256 but there are still a few references of oc calls that would need to replaced which are tracked in other issues, so closing this issue. @Fredericwu please feel free to reopen in case of any issues. Thanks.


chore: update cli docs

@dammy001 These files were generated when I ran test:ui

Seems generated by Cypress. We might want to find a way to disable it, or at least exclude them from git

@antfu done and added to gitignore

Can you resolve the conficts? Thanks

@antfu


Inconsistent use of playCount vs playcount

In some objects like SBKTrack, playcount attribute is used, in others, like SBKArtistInfoGetData,  playCount.
Is this on purpose?

Hi @ridmaur, thanks for pointing this inconsistency. I'll make sure to update SBKArtistInfoGetData to follow the playcount naming like the rest of the project

I've just released a new version that fixes the naming issue discussed here. Thanks for opening this issue!


Should benchmarks be run on "random" values instead of the same value each time?

Currently the benchmarks in this library use hardcoded values to compare the performance of different functions in different libraries. This obviously produces pretty consistent benchmarks.
However, this is a bit problematic, as many algorithms actually spend a different amount of time depending on the value – for example, leap years are more expensive to calculate, month lengths affect calculations, leap days are very rare etc. Some values are fast to convert while others are slower. In addition to that, there's the problem of branch prediction – if the code in question uses branches, and it is evaluated always on the same value, the branch prediction will hit 100% correct. This means that the benchmarks are not really indicative of real world performance, nor are they good for comparing different implementations because one value might be fast in one implementation and slow in another.
The way to avoid this is to use a lot of different values to calculate the benchmarks and average them for the result. The easiest way to do this is by generating random values for the benchmarks. I personally use iter_custom with Criterion with the following implementation:
pub fn bencher<I: Copy, O>(s: impl Fn() -> I, f: impl Fn(I) -> O) -> impl Fn(u64) -> Duration {
    const ARR_SIZE: usize = 4096;
    move |n| {
        fastrand::seed(7);
        let is: [I; ARR_SIZE] = std::array::from_fn(|_| s());
        let now = Instant::now();
        for i in 0..n {
            let _ = black_box(f(is[i as usize & (ARR_SIZE - 1)]));
        }
        now.elapsed()
    }
}

This prepopulates a 4096 element array with random values always generated from the same seed, and then runs the function to be tested in a round robin fashion on the array. 4096 is big enough so there will be a couple leap days in there as well, but usually not so big that memory performance becomes an issue.
What do you think, would this be worthwhile for this library as well? Would you want a pull request converting the benchmarks to use random values instead with the method shown above?

I think it's probably fine to add this style of benchmark (as long as the seed is fixed) as additional benchmarks, but the existing benchmarks on fixed inputs should 100% stay. I am open to changing the values of the fixed inputs, but I would generally prefer for them to be representative. I'm not sure if they're perfect on that dimension today though.
More generally though, I'm not totally convinced by your suggested solution. I think a better answer is probably to have a better benchmark harness that uses random interleaving. The problem with your suggested approach, IMO, is that it's much harder to reason about the path through the code because its taking an aggregate result. The aggregate result will likely yield more realistic wall clock timings, but I think they are less useful from the perspective of profiling hot spots, looking at generated code and trying to do targeted optimizations. So that in turn leads me to a place where we probably want both, and not just one.
I will say though that my bandwidth is limited and this sort of tuning in the benchmarks isn't really my priority right now. I'm open to a PR, but depending on its size/complexity, it could be a while before I can review it.

I'm going to close this for now since I don't have any specific plans to pursue this at present. I'd be open to accepting a PR with this style of benchmark added to the existing benchmarks though. (But not replacing them.)