Errors during Import points cloud from CSV file into sketch

Hi Artem! I found some errors when trying to apply this macro: https://www.codestack.net/solidworks-api/document/sketch/csv-import-points/
When I try to use your CSV-file, downloaded from codestack.net, I get this error:"Run-time error 9. Subscript out of range" If debug button click then get this string of code: "For i = 0 To UBound(points)"
If I try use my own CSV-file, I get anothe error: "Run-time error 13. Type mismatch" If debug button click then get this string of code: "dCells(i) = CDbl(vCells(i))" In this case it seems VBA can't convert string to double - but why?
Can you help to understand this situations? Thank you in advance.

Close this issue. I finded the reasone of this errors. 1st erros becouse CSV-file have Unix(LF) - format, transform it to Windows(CR LF) by Notepad++ and its became Ok. Second error becouse vCells(i) must have comma insteed point in its value. Maybe this will be helpfull for others.


[DOC][configuring-the-service-manager.md] Fix variable name

$dataTime  > $dateTime

@gianarb

👍 it's good but I can not do nothing :D


Doesn't work with FormData using a Buffer

I can't tell exactly where the error stems from, but here is what I'm doing...
file // this was extracted from multer and is using MemoryStorage

const form = new FormData()
form.append('file', file.buffer)
fetch(<url>, {
  method: 'POST',
  body: formData
})

at the endpoint that fetch is making the request to, i am using multer to parse the multipart form.
What im noticing is that at my latter endpoint, multer isnt able to recognize any files being uploaded. However, if in my code above, instead of using the file.buffer from multer, I change multer to use LocalStorage and use createReadStream and pass that in instead, then it works.

We detect FormData body in very specific way, so it could be this is a new feature we haven’t support or somehow FormData isn’t taking that buffer.
You can take a look at our tests it should contain some FormData usage example.
(From my phone)

On Apr 25, 2018, at 8:18, stringbeans<EMAIL_ADDRESS>wrote:
I can't tell exactly where the error stems from, but here is what I'm doing...
file // this was extracted from multer and is using MemoryStorage
const form = new FormData()
form.append('file', file.buffer)
fetch(, {
method: 'POST',
body: formData
})
at the endpoint that fetch is making the request to, i am using multer to parse the multipart form.
What im noticing is that at my latter endpoint, multer isnt able to recognize any files being uploaded. However, if in my code above, instead of using the file.buffer from multer, I change multer to use LocalStorage and use createReadStream and pass that in instead, then it works.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I didn't see any reason this wouldn't work, so out of curiosity I wrote a test case:

	it.only('should allow POST request with form-data using buffers as body', function() {
		return Promise.resolve().then(() => {
			// readFileAsync is just promisified fs.readFile
			return readFileAsync(path.join(__dirname, 'dummy.txt'));
		}).then((dummyFile) => {
			const form = new FormData();
			form.append('my_field', dummyFile); // this is a buffer

			url = `${base}multipart`;
			opts = {
				method: 'POST'
				, body: form
			};

			return fetch(url, opts).then(res => {
				return res.json();
			}).then(res => {
				console.log(res.body);
				expect(res.method).to.equal('POST');
				expect(res.headers['content-type']).to.startWith('multipart/form-data;boundary=');
				expect(res.body).to.contain('my_field=i am a dummy');
			});
		});
	});

and the result
    √ should allow POST request with form-data using buffers as body (41ms)

  1 passing (146ms)

so you might want to look to another source of the issue... you are saying that LocalStorage (or is it DiskStorage?) works with multer but not MemoryStorage and a Buffer? Have you tried logging the file.buffer to make sure there's data?

What package did you use for the FormData class? And what version?

@TimothyGu https://www.npmjs.com/package/form-data

@isnifer, what was your solution?  it looks like the FormData construct is not part of the node-fetch TS types.  i may need to just expand the interface if this lib does indeed support binary streams


iNaturalist setup on Ubuntu - syntax errors in elastic_model.rb during database setup

I am trying to set up iNaturalist on a Ubuntu 15.04 server, following the development setup guide
The command:
rake db:setup
is failing with a message:
Couldn't create database for {"host"=>"localhost", "encoding"=>"utf8", "adapter"=>"postgis", "username"=>"geoff", "template"=>"template_postgis", "database"=>"inaturalist_test"} rake aborted! SyntaxError: inaturalist/lib/elastic_model/elastic_model.rb:159: syntax error, unexpected ':', expecting =>           { term: { "user.id": opts[:user].id } },                               ^ inaturalist/lib/elastic_model/elastic_model.rb:159: syntax error, unexpected '}', expecting keyword_end           { term: { "user.id": opts[:user].id } },                                                ^ inaturalist/lib/elastic_model/elastic_model.rb:160: syntax error, unexpected ':', expecting => ...envelope: { "private_#{field}": coords } }) ]} ...                               ^ inaturalist/lib/elastic_model/elastic_model.rb:279: syntax error, unexpected end-of-input, expecting keyword_end
I then set up elasticsearch before retrying the database setup but that did not resolve the issue.

This looks like you might be using an older version of Ruby that doesn't recognize the newer hash syntax. What version of Ruby are you using?

It looks like Ruby 2.1.2 was installed as a dependency by the apt-get install rails command.

FWIW I'm using Ruby 2.2.1p85 locally, so anything at that version and above should be fine. I highly recommend using RVM. The dev setup guide is basically always out of date, so look upon it with a jaundiced eye. There's also https://github.com/pleary/inaturalist-vagrant, which might still work, though I kind of doubt it.

Thanks.  I will sort out the Ruby upgrade through RVM and see how I get on.

That inaturalist-vagrant repo is out of date and should probably be removed. The newer way is to use vagrant through test-kitchen in https://github.com/inaturalist/inaturalist-cookbook . But none of that is documented, and there are probably some things out of date in there that need updating. At one point I had visions of creating development machine images that you could download and run in VirtualBox or something, but we just never had any potential users so it never came to be.
I'd be interested to hear how you make out, and if you have any recommendations for us to help people like you get starting working on the Rails codebase.

Thanks for the guidance on the inaturalist-vagrant repo.  I will avoid it.  As I go through the setup process I am putting together one or more shell scripts that do the basic web server installation and configuration. They can be added to the relevant Wiki page when I have it working.

I now have the iNat homepage running on a test machine now. The process was pretty smooth given I have no background with Ruby/Rails etc.
I did run into a few errors while doing the rake db:setup step:
#Couldn't create database for {"host"=>"localhost", "encoding"=>"utf8", "adapter"=>"postgis", "username"=>"postgres", "template"=>"template_postgis", "database"=>"inaturalist_test"}
#inaturalist/db/structure.sql:14: ERROR:  unrecognized configuration parameter "row_security"
#inaturalist/db/structure.sql:34: ERROR:  PostGIS is already installed in schema 'public', uninstall it first
#inaturalist/db/structure.sql:41: ERROR:  extension "postgis" does not exist
#inaturalist/db/structure.sql:262: ERROR:  function "st_aslatlontext" already exists with same argument types
#inaturalist/db/structure.sql:14: ERROR:  unrecognized configuration parameter "row_security"
#inaturalist/db/structure.sql:34: ERROR:  PostGIS is already installed in schema 'public', uninstall it first
#inaturalist/db/structure.sql:41: ERROR:  extension "postgis" does not exist
#inaturalist/db/structure.sql:262: ERROR:  function "st_aslatlontext" already exists with same argument types
But at end I had both inaturalist_test and inaturalist_development databases installed (Checked in pgadmin) as did the seed data.
For posterity, the steps on Ubuntu are set out in the attached text file.

K, I assume this is no longer a problem then, so I'm closing. I also should have mentioned earlier on that https://github.com/inaturalist/inaturalist/blob/master/.travis.yml is probably a good guide for Ubuntu users as well, since those are instructions we send to travis when it sets up machines for continuous integration.


Windows binaries download expired

It's impossible to complete the 5th step of the installation for Windows, because we can no longer download the binaries as you can see from the screenshot.

Fixed


Backend: More options for the shortener api

For eg bit.ly and cutt.ly currently it only has the option for tinyurl

Hey, I can Work on this. Could you please assign it to me?

Done @Abhyuday03


Formatter got confused with a comment

Hey - I love the project, thank you for sharing it.
We found a little bug when formatting this:
sql: ${recurring_referral_value}/IFNULL(${exchange_rates_first_month.rate},1) ;; #  + ${overage_value}/IFNULL(${exchange_rates_first_month.rate},1) ;;

It became:
sql: #  + ${overage_value}/IFNULL(${exchange_rates_first_month.rate},1) ;;
      ${recurring_referral_value}
      / ifnull(${exchange_rates_first_month.rate}, 1)
    ;;

Which strangely, Looker was happy with.
I'm not sure what it should be instead - perhaps removing the comment is the most correct thing here?
We changed it manually and removed the comment and it reformatted to :
    sql:
      ${recurring_referral_value}
      / ifnull(${exchange_rates_first_month.rate}, 1)
    ;;

fixed in version 0.0.10

Excellent - thank you so much for the rapid fix!


[nrf noup] cmake: move patch from extensions.cmake to nrf repo

This is done to reduce the diff from upstream, and to
facilitate downstream patches.
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

Missing tag on the deps commit

Missing tag on the deps commit

that was not supposed to be here, my bad.

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

Simply to pass CI I'm afraid. The sanitycheck seems to be running without the modules installed, so the ${ZEPHYR_NRF_MODULE_DIR} is not defined when the tests are running.
I have done the same fix before, and seem to remember it was concluded that this was the best way of fixing the issue. I will check if this is still the case.

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

Simply to pass CI I'm afraid. The sanitycheck seems to be running without the modules installed, so the ${ZEPHYR_NRF_MODULE_DIR} is not defined when the tests are running.
I have done the same fix before, and seem to remember it was concluded that this was the best way of fixing the issue. I will check if this is still the case.

Thanks for the explanation.
I think it's fine to test for ZEPHYR_NRF_MODULE_DIR in this case.
https://github.com/NordicPlayground/fw-nrfconnect-zephyr/pull/279#discussion_r384711094

@mbolivar : Hi, about your feedback

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

Please see
https://github.com/NordicPlayground/fw-nrfconnect-zephyr/pull/279#issuecomment-591828282
and re-asses the review

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

Simply to pass CI I'm afraid. The sanitycheck seems to be running without the modules installed, so the ${ZEPHYR_NRF_MODULE_DIR} is not defined when the tests are running.

How can that be? That would mean sanitycheck isn't using our HAL, which I don't understand. @thst-nordic ?

@mbolivar : Hi, about your feedback

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

Please see
#279 (comment)
and re-asses the review

I'm not blocking this PR, but that seems kind of fishy to me and sounds like it should be addressed in CI.

It looks like the latest version added checks for whether ZEPHYR_NRF_MODULE_DIR is defined. Why is that necessary? It doesn't seem like it should be.

Simply to pass CI I'm afraid. The sanitycheck seems to be running without the modules installed, so the ${ZEPHYR_NRF_MODULE_DIR} is not defined when the tests are running.

How can that be? That would mean sanitycheck isn't using our HAL, which I don't understand. @thst-nordic ?

I'm no expert on this, but could it be that CI is actually using the manifest file from Zephyr and not the nrf manifest, when running on this repo ?
That could explain why the nRF repo would be available.
@thst-nordic Could you provide more info on this ?
and also why this happens: https://github.com/NordicPlayground/fw-nrfconnect-zephyr/pull/279#issuecomment-591828282

DNM until Upmerge #296 will be merged

No longer needed


doesnt work as expected

hi,
i used:
barrelbot watch src/components
it produced : index.ts (not tsx!)
`
// THIS FILE IS AUTOGENERATED AND MANAGED BY BARRELBOT. DO NOT EDIT
// for more info: https://github.com/sw-yx/barrelbot
export * from './SmallButton.module.css'
export * from './SmallButton.module.css.d'
export * from './SmallButton.test.tsx'
export * from './SmallButton.tsx'
`
and it gives me an error , should be :
export * from './SmallButton' and so on. also I would like to have a way to ignore css , tests ...

good to know! PR welcome, otherwise i'll get to this when i have time

Same. i tried barrelbot watch src/components --extension js but it still generates .ts file

i'll be honest, i dont use this much right now. @sgrimard would you like to be a maintainer? i can give you publish rights


Refactor of clear controller & bug fixes

Refactoring of the controllers below

Clear controller

Bug fixes

Fixes filtering by date bug

Coverage increased (+0.1%) to 50.881% when pulling 604d492b38b17694a131c306f1cca00f06def497 on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.

Coverage increased (+0.2%) to 50.902% when pulling 51e78b03b683202b41f32b13f9e9001fe0c1964a on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.

Coverage decreased (-0.1%) to 50.609% when pulling eeb1fec24c52e3f2cb218df95bf5a3f2ed110732 on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.

Coverage increased (+4.7%) to 55.398% when pulling 2efba5c4b9b49a5657ac9f24167ea242f7944485 on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.

Coverage increased (+4.6%) to 55.317% when pulling a06a2d3c3583f80d74e465101c05d3474bcb5824 on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.

Coverage increased (+4.6%) to 55.317% when pulling a5a9dd67c4e62e09c431cd5b9e4ee24b6a218dda on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.

Coverage increased (+4.6%) to 55.371% when pulling 752a5907d7c844a566c7c7a298d363faa00cabd3 on Refactor into 258f87063044d7bfd4859d9d0e26b9a9573ec224 on master.


Feature request: JSON-feeds

There's a new kids in town: JSON-feeds. Some say that they will replace the 'old' RSS-feeds. You can read more over here:
http://www.i-programmer.info/news/87-web-development/10804-json-feed-the-new-rss.html
Is there any chance that Miniflux will support this?

more like a picofeed question, but valid +1

Ah, it is already requested in #fguillot/picoFeed#333. Let's continue the conversation over there. :)


Long term: Switch to a native library for driver implementations

This would have a number of benefits:

Some unfixable race conditions relating to signals (e.g. SIGCONT) will be resolved.
No more duplicated code between Linux and macOS.
Significantly reduced metadata size from removing P/Invoke declarations.
Faster managed builds and editing as CsWin32 will no longer be needed.
Easier porting to new platforms.

The native library would probably be written in Zig or C. For this to be as painless as possible, we would need alexrp/zig-msbuild-sdk#8 (and by extension dotnet/sdk#19929) to be implemented first.

Experience from Ruptura shows that this should be fairly straightforward to do even in the short term.
The main annoyance will be working around dotnet/sdk#19929. We would need to package the compiled native libraries in runtimes/<rid> folders in the Vezel.Cathode package; we do something similar for analyzers already, so this isn't too hard. We would also need some hacks to include the native libraries when building the sample projects.

(The native library will be written in C initially and ported to Zig once Zig reaches 1.0.)

This will run into the same problem as vezel-dev/celerity#101.

Turns out I was wrong about SIGCONT: That race condition just cannot be fixed.
https://stackoverflow.com/a/75084598

I'm specifically avoiding moving basic I/O to the native drivers since I'm hoping #76 will move forward eventually. So it's mostly just stuff related to terminal configuration and signals for now.


how to slove this  -----   no model named '_mask'

If your dataset is VOC, you just delete the code of COCO.

_mask is from the cpp binary file in pycoco lib code. But if you install the library shown in dev branch, this problem should not be existed.
since the problem should be fixed in the newer version of code, will close this issue for now.


Add task for generation of a sap-ui-cachebuster-info.json file

Unlike the grunt-sapui5-bestpractice-build plugin, the ui5-builder does not generate a sap-ui-cachebuster-info.json file in order to enable cache busting for application resources on supported backend systems.
Expected Behavior
Generate a sap-ui-cachebuster-info.json file containing the last modified timestamps of all files that are included in the build.
Current Behavior
Not supported as of now
Affected components

[x] ui5-builder
[ ] ui5-server
[ ] ui5-cli
[ ] ui5-fs
[ ] ui5-project
[ ] ui5-logger

Ahh, missed to include that issue into the PR to mark it as fixed:
https://github.com/SAP/ui5-builder/pull/237
The app cachebuster index file can be created with the generateCachebusterInfo task.


Minor UI fixes

Notion card
NA
Summary

Fixed toast message on new invoice page for not adding client and proceeding
Address field of add new client
Timesheet entry scroll issue

Preview

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

[ ] I have manually tested all workflows
[ ] I have performed a self-review of my own code

Raised  a different PR for this because unable to revert gemfile.lock changes


BatchNormalization: validation loss >> train loss, same data

I implemented this paper's neural net, with some differences (img below), for EEG classification; train_on_batch performance is excellent, with very low loss - but test_on_batch performance, though on same data, is poor: the net seems to always predict '1', most of the time:
       TRAIN (loss,acc)   VAL (loss,acc)
'0' -- (0.06269842,1)     (3.7652588,0)
'1' -- (0.04473557,1)     (0.3251827,1)

Data is fed as 30-sec segments (12000 timesteps) (10 mins per dataset) from 32 (= batch_size) datasets at once (img below)
Any remedy?

Troubleshooting attempted:

Disabling dropout
Disabling all regularizers (except batch-norm)
Randomly, val_acc('0','1') = (~.90, ~.12) - then back to (0,1)

Additional details:

Keras 2.2.4 (TensorFlow backend), Python 3.6, Spyder 3.3.4 via Anaconda
CuDNN LSTM stateful
CNNs pretrained, LSTMs added on afterwards (and both trained)
BatchNormalization after every CNN & LSTM layer
reset_states() applied between different datasets
squeeze_excite_block inserted after every but last CNN block

UPDATE:
Progress was made; `batch_normalization` and `dropout` are the major culprits. Major changes:

Removed LSTMs, GaussianNoise, SqueezeExcite blocks (img below)
Implemented batch_norm patch
Added sample_weights to reflect class imbalance - varied between 0.75 and 2.
Trained with various warmup schemes for both MaxPool and Input dropouts

Considerable improvements were observed - but not nearly total. Train vs. validation loss behavior is truly bizarre - flipping class predictions, and bombing the exact same datasets it had just trained on:

Also, BatchNormalization outputs during train vs. test time differ considerably (img below)

UPDATE 2: All other suspicions were ruled out: BatchNormalization is the culprit. Using Self-Normalizing Networks (SNNs) with SELU & AlphaDropout in place of BatchNormalization yields stable and consistent results.

BatchNormalization outputs with a more dramatic val vs. train difference:

Probably resolved: I've inadvertently left in one non-standardized sample (in a batch of 32), with sigma=52 - which severely disrupted the BN layers; post-standardizing, I no longer observe a strong discrepancy between train & inference modes - if anything, any differences are difficult to spot.


Add scripts to build a registry

I was expecting this to be scripts for using with torc, but this doesn't seem to be that? What am I missing?

I decided against it, for now:

Torc is in a private repository. This is public.
Torc is beta and subject to change.
Torc is complex to setup and understand; no one besides me understands it yet.
Using Torc was great when I was debugging. Now that it works, most people will prefer this.

We will always need both formats. We can add torc instructions somewhere when there are more use cases and it is more stable.


extras/dialer: allow to seed random

Helpful if you want to get the same random numbers in subsequent runs
(e.g. to compare results between branches).

cc @alepuccetti


fix(debug): always use dlv debug, better docs

What this PR does / why we need it
This PR moves us from dlv exec for in container debugger runs to dlv debug. The main goal of this change is to prevent needing to compile binaries with GC flags that only dlv knows of.
I also focused on adding some docs for this script and some more touch points for being able to debug different packages, since it's useful for developers to be able to set these.

Jira ID
DT-3662

Notes for your reviewers

FYI @clevelittlefield-outreach

Yay!


Added PT bye message

Hello, just a small contribution to ArangoDB, I've added bye message for portuguese language.

 You should sign our Contributor License Agreement in order to get your pull request merged.

CLAassistance is not working. I could't sign the CLA. Can't see any message inside Textbox and after clicking submit button, receive this error: 404 Not Found: Requested route ('cla-assistant.io') does not exist.

@arangodb, the gist link you have used in CLA assistant seems to be broken. If you (re-)link this repository with an existing gist file (delete the current link and create a new one at https://cla-assistant.io) it should work fine.

manually added CLA


[fast-interp] fix frame_offset pop order

This PR fixes https://github.com/bytecodealliance/wasm-micro-runtime/issues/3062


The command should say docker load not docker image load

File: engine/reference/commandline/image_load.md, CC @mstanleyjones
the command should say docker load and not docker image load

Sorry, this doc is correct as-is.


Add GLU support

This change adds GLU blocks to megablocks (replacing vanilla MLPs), and does some refactoring around the mlp types, including an MLP_TYPE_REGISTRY.
Note, this is unoptimized at the moment:

no support for the memory optimized mlp version yet
w1 & v1 are not fused into one op that is split

I've updated the PR based on @tgale96 's feedback, mainly:

adding registry
isolated test file

I've left a few of the issues unresolved as I work through them, namelystk support for a cleaner implementation (as well as some code quality changes)

LGTM! Ready to merge?

@tgale96 great, yes!

Thanks for the contribution Sasha! This is awesome.


More Comprehensive Test Suites

This is a draft doc to maintain the design of deeper tests for ExplainaBoard so that potential hidden bugs could be captured when we make major refactoring.
Generally, from the task perspective, the following tests would be added gradually for each task:

test if training set features could be automatically disabled when there is no training set

test if training set dependent features could be added automatically and if the bucketing value is correct

test if the bucket number is correct given a bucket feature

test if cli of each task is correct

test if user_defined_feature could work

test if user_defined_metadata could work

test if the specified metric could work

test if evaluation speed is normal (this is useful when we make significant architectural modifications)

test supported metrics

test error cases

for example, sometimes we don't need to print all cases, e.g., sequence labeling, otherwise, the analysis report would be too large.

Named Entity Recognition

[x] others
[ ] test if user_defined_feature could work
[ ] test if user_defined_metadata could work (it seems current dataload didn't support this?)

Bugs (issues) Identification
For example

the training set dependent features of NER task cannon work
the number of buckets is misused (the number of predicted entities are printed)
samples are stored in an inappropriate way (store all samples, which makes the report file too large)
there is a typo in unittest file (line 17)?
the user_defined_metadata features can not work

I think this is great! If we have all these tests, we can be more confident when we merge PRs. You might have already thought of this but just one general comment is that I think it may take quite some time to cover all of these (e.g. all the metrics for all the tasks) so maybe we can write more unit tests for the sub-modules of the system? For example, we can test bucketing by itself without actually going through the loading -> processing process. But I think end-to-end tests can still be very useful to ensure the more important test cases work.

I think this is great! If we have all these tests, we can be more confident when we merge PRs. You might have already thought of this but just one general comment is that I think it may take quite some time to cover all of these (e.g. all the metrics for all the tasks) so maybe we can write more unit tests for the sub-modules of the system? For example, we can test bucketing by itself without actually going through the loading -> processing process. But I think end-to-end tests can still be very useful to ensure the more important test cases work.

Aha thanks and this (For example, we can test bucketing by itself without actually going through the loading -> processing process) makes sense!  I think I will do both and I find task-by-task testing is pretty rewardable, also, pushing me examining deeply just like a user.


Update getYears.js

As it should be possible to use the Date field as "Birthday" -50 is a bit low

Hi @misterboe  I'm closing this PR since there is no update. Feel free to open a new one when you are available.


july-meetup-recap

Posting tomorrow in AM. Will be featured in our Newsletter.

👏 👍

ty @luqmaan


Bot file needs to be unencrypted

I had issues where my bot would fail to load, and state I needed to set my BotFileSecret. It turns out the .bot file is encrypted, and I had to run a command to unencrypt it to make these changes per the comment here: https://github.com/Microsoft/BotBuilder-Samples/issues/932#issuecomment-440039929
Please add better instructions to explain decrypting the bot file.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 466e4935-993f-ed61-0446-c6eff7310572
Version Independent ID: 50fe83f8-c261-0bbe-5b8e-910ee27f17dc
Content: Azure Bot Service tutorial to have a bot answer questions - Bot Service
Content Source: articles/v4sdk/bot-builder-tutorial-add-qna.md
Service: bot-service
GitHub Login: @JonathanFingold
Microsoft Alias: v-jofing

If you're using a .bot file, and it was created in Azure portal, it will be encrypted - so either decrypting it or using the botFileSecret is required.
Part of the listed Prerequisites in that article are the previous tutorial, which includes decrypting your .bot file as one of the steps. Assuming you had followed that, your bot file here would already be decrypted.
Will add mention to this article to decrypt it, if necessary, when adding the qna values.


sidebar/navbar in CMSWrapper

Goals

Users can set sidebarConfig to true to let CMSWrapper render sidebar with schema
Users can set sidebarConfig to a array to let CMSWrapper render sidebar with this configuration
Users can create Submenu with sidebarConfig
Users can change the logo on navbar
Users can decide the menu on navbar

Proposed Solution
sidebarConfig
[{
  title: 'Posts',
  pathname: '/posts',
  params: {
    op: 'create'
  }
  items: Array<Object>
}]

current implement in CMS
navbarConfig
{
  logo: ``,
  renderMenu: React.Node,
}

@abz53378 Can we have a clearer interface of sidebarConfig?
For example, what properties will be included in params?
Furthermore, what does renderMenu  in navbarConfig do ? Does it render like antd menu?

Agreed, I think the clearer details can help everyone to understand and give feedbacks before implementation. Also, this helps everyone on the same page.

@wwwy3y3, @chilijung, @chihsuan. Updated!


Not adapted on small screen device, please see the screenshot.

I am finding it hard to get this project up and running, I keep on getting errors when running the project.
Launching lib\main.dart on SM G950F in debug mode...
Initializing gradle...
Resolving dependencies...

Error running Gradle:
ProcessException: Process "C:\flutter\movie-details-ui-master\android\gradlew.bat" exited abnormally:
Starting a Gradle Daemon (subsequent builds will be faster)

BUILD FAILED
Total time: 59.344 secs
FAILURE: Build failed with an exception.

Where:
Build file 'C:\flutter\movie-details-ui-master\android\build.gradle' line: 4

What went wrong:
A problem occurred evaluating root project 'android'.

Could not find method google() for arguments [] on repository container.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
Command: C:\flutter\movie-details-ui-master\android\gradlew.bat app:properties

Finished with error: Please review your Gradle project setup in the android/ folder.


Remove spammy logs in unit tests

This causes a bunch of logs like klog  timed out waiting for caches to sync in all of our tests,
which gets highlighted by Prow and obscures real errors. I don't think
we really need this log, it only happens when the stop channel is closed
so Istio is shutting down; no other controllers do it.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
e8b8d95b3902fb1ba31b6602190774afae458797
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
On Thu, Dec 31, 2020, 2:47 AM Istio Automation<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn: The following test failed,
say /retest to rerun all failed tests:
Test name Commit Details Rerun command
integ-helm-tests_istio e8b8d95
https://github.com/istio/istio/commit/e8b8d95b3902fb1ba31b6602190774afae458797
link
https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/29825/integ-helm-tests_istio/1344595186914693120 /test
integ-helm-tests_istio
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/29825#issuecomment-752922239, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXIL27WWSXSWITBJWLDSXRJETANCNFSM4VOU4FUA
.


feat(app): app.runWithContext()

Allows accessing globals provided at the app level with app.provide() via a regular inject() call as long as you have access to the application. Useful for Pinia, vue-router, Nuxt, Quasar, and other advanced use cases.

https://github.com/vuejs/pinia/issues/1784
Allowing using stores (or anything global to an app really) within router navigation guardsrouter.beforeEach(() => {
  const userStore = useUserStore() // pinia store
})

I named the function runWithContext() to look like effect.run() but maybe it should be named something different like runWithProvides() since it only ensures inject() behavior but I think keeping a more generic names allows to add other things if the future like onServerPrefetch() and so.

I also think it's worth giving functions like the callback passed to router.beforeEach() and the setup function in pinia a name that can be found in docs. Something like inject-aware function/context. That way, we could have a page in documentation explaining the concept and library authors could mention this as inject-aware (or whatever other name that makes sense) to indicate that inject() and provide() can safely be used in a context and add an external link to that page. It could maybe create more awareness of the need to call composables within an inject-aware functions like setup().


chore: replace Ring with RustCrypto in pki.rs

Signed-off-by: Richard Zak<EMAIL_ADDRESS>

The only failure is Cargo/deny being upset about the RustCrypto project using a crate called subtle which is BSD-licensed, and that's approved?

The only failure is Cargo/deny being upset about the RustCrypto project using a crate called subtle which is BSD-licensed, and that's approved?

Yes. Add it to deny.toml. In the future, do that presumptively and point out the additional license in the PR text so that reviewers can assess whether that change is acceptable or not.


Error handling in Spec

Error messages should contain more context. For example, if None is passed where a list is expected, the message will simply say that it can't iterate over a None type, without specifying which value is the culprit. We may be better off providing the stacktrace as well.

(copied from slack for reference)
here’s some stuff going on…needs documention
e.g. If the data needs to be evaluated on init:

add the property to additional_required_props

https://github.com/opendp/dpcreator/blob/develop/server/opendp_apps/analysis/tools/stat_spec.py#L106

make sure the property has the correct validator here:

https://github.com/opendp/dpcreator/blob/develop/server/opendp_apps/analysis/tools/stat_spec.py#L40

Alternately, put checks in:

pre:  happen before the “canned” validation above https://github.com/opendp/dpcreator/blob/develop/server/opendp_apps/analysis/tools/stat_spec.py#L115
post: happen right after the “canned” validation: https://github.com/opendp/dpcreator/blob/develop/server/opendp_apps/analysis/tools/stat_spec.py#L133


[WIP] Introduce depth limit in env and apply to recursive functions

What
This is a WIP implementation to resolve https://github.com/stellar/rs-soroban-env/issues/861
Based on a minimal prototype of rs-stellar-xdr that introduces a new trait DepthLimiter (https://github.com/jayz22/mini-rs-xdr/tree/guard).
The trait is added a constrain for EnvBase, to avoid unnecessary cluttering (avoid E: Env -> E: Env + DepthLimiter everywhere).
We check all the recursive paths in the env code base : Val convertion to/from ScVal, comparison, clone. (ser/deser will be covered by rs-stellar-xdr's ReadXdr, WriteXdr which is constrained by DepthLimiter as well).
Also added some tests to demonstrate it working.
The interface looks more-or-less ready with some minor cleanups, so I would welcome feedback.
Update: the xdrgen side changes are in this PR https://github.com/stellar/xdrgen/pull/158
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]

Generally speaking this looks great, I'm glad the rough idea looks like it holds together!
A couple suggestions:

Maybe try calling the associated error-type definition in the trait something else -- say type DepthError; -- so that it doesn't collide with the Error  type defined in implementations of EnvBase and so forth. Might cut down on the amount of noise arising from ambiguity on the name Self::Error.
I talked to @tomerweller and he seems to think we're going to have an opportunity to do one more cycle of XDR additions (so long as they don't actually affect anyone downstream) before we call it finished, so ... maybe try to define this as a config setting, just in case we ever wanted to make it deeper than 100? (There's a corresponding limit in stellar-core which is not a config setting, which is hard-wired to 1000, but that also covers outer structures such as overlay messages containing transactions and so forth). I guess this isn't critical since 100 is very deep and we could always add it as a new config setting in a future protocol, but it might not hurt to include up front. @MonsieurNicolas do you have a strong feeling?

re: make this a config setting. Right now we have a few of these limits hard coded in the XDR (like number of signers), and it's probably fine for now as it allows clients everywhere to also implement it without connecting to the network and it's just less work.


delete extra file

there is an extra blank file(maybe for future uses) named common.css remove this one
https://github.com/prakhartiwari0/my-web-shortcuts/blob/0d87d350cc0fddf7ff70b80825db1583e2882f5e/src/common.css

Oh you are right, I created that CSS file thinking that this would be some common styles (variables, fonts, etc.) for every UI this extension has, which are mainly the Popup, Options page, and the elements it created on the webpages for Element Selection & Keyboard shortcut selector.
But I faced a problem. The styles of the Popup and Options for declared in the context of the whole document, but when this file was imported to setter.js which is used to do stuff inside another website, many issues started to happen.
So I separated the CSS that is required for the Extension element on another website, and the CSS that is required for the Extension pages like Options, Popup, etc.

I searched for confirmation and yes, there is no mention of common.css in any file.

If you want to make this change, please tell me. Or if anybody else wants to do it please ask to be assigned here.

If you want to make this change, please tell me. Or if anybody else wants to do it please ask to be assigned here.

you can assign to someone

Hi, can you assign this fix to me, thanks!


Update Responsiveness foundation

Closing this PR as spacing foundation needs to be completed first (and spacing-related changes to responsiveness will be done as part of that)


chore: update google.golang.org/protobuf to v1.33.0

This is to move away from CVE-20204-24786: infinite loop vulnerability.

/lgtm


Add prost, and update third party crates.

Description
As discussed in the mailing list, we need prost to improve RPC mechanism. With the help of prost, we do not need handcrafted .rs file for each proto. Instead, we can simply maintain the .proto file and use prost to generate the corresponding Rust source codes.
Accompanied with update on regular third party crates.
CI succeed. proof.
Type of change (select applied and DELETE the others)

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] API change with a documentation update
[ ] Additional test coverage
[x] Code cleanup or just sync with upstream third-party crates

How Has This Been Tested?
Checklist (check ALL before submitting PR, even not applicable)

[x] Fork the repo and create your branch from master.
[x] If you've added code that should be tested, add tests.
[x] If you've changed APIs, update the documentation.
[x] Ensure the tests pass (see CI results).
[x] Make sure your code lints/format.

Added prost-types
CI status at http://ci.mesalock-linux.org/dingelish/incubator-mesatee/3

CI passed


default password broken in docklet_rstudio

Running the default example from the repository's README.md
docklet_create() %>%
  docklet_rstudio()

did not work out of the box. The browser opened but no connection was made. Apparently the containerized RStudio server rejects any passwords that are set to rstudio.
I found this out by loging into the droplet manually and starting the docker container, which gave
   ERROR: You must set a unique PASSWORD (not 'rstudio') first! e.g. run with:
docker run -e PASSWORD=<YOUR_PASS> -p 8787:8787 rocker/rstudio

Indeed, with a different password
docklet_create() %>%
  docklet_rstudio(password = "really_nice_r_package!")

it all works. I suggest modifying the default password here.

thanks @nielsaka for raising this issue. having a look at the PR


Support for linking with LLVM linker

This currently does not work due to a bug in SKSE, which does not properly find exports by name. This bug has been reported and is being looked at. In the mean time this issue should be explored to see if there is a particular configuration for lld-link.exe that can exactly mimic the MSVC linker behavior, to avoid needing an SKSE update.

The bug in SKSE with getting the exports by name has been reported to Ian and acknowledged. This may require an update on the SKSE side. Ideally there would be some option that can be passed to the linker to start exports at ordinal 0, which would make it a drop in replacement for MSVC's linker, but so far there is no luck finding such an option or a workaround.

I've confirmed that the null first export is hard coded to be a null address and so there is no workaround on this side. SKSE will require a fix to its export lookup for this to work. Issue will remain open until a fixed SKSE64 and SKSEVR is released.


Enhancement: Print scanning results in auto-encode mode

If auto-encode could print the VMAF results per CRF, as does crf-search, that would be useful IMO to track the progress and identify outliers.

Yes I think it would make sense to be able to opt into the crf-search output when running auto-encode.

Logging (e.g. RUST_LOG=ab_av1=info) was added in https://github.com/alexheretic/ab-av1/blob/main/CHANGELOG.md#v0715
It is currently mostly meant for non-terminal use cases or debugging. But it also serves as a verbose output.

Wonderful, thanks!


molecule status raises IndexError when container is stopped

molecule status raises an uncaught IndexError when container is stopped.
Fix entails adding all=True to the self._docker.containers(filters={'name': name})... call in molecule/drivers/dockerdriver.py:176.
I'm working on the PR to fix, but I could some advice on how best to test. Here is what I have so far:
def test_status_when_stopped(docker_instance):
    ''' Test docker_instance.status when test subject -- container -- is stopped or exited '''
    docker_instance.up()
    docker_instance._docker.stop(container='test1')

    assert 'Exited' in docker_instance.status()[0].state

To reproduce:
> docker stop test-01 && molecule -v && molecule status
1.11.0
Traceback (most recent call last):
  File "/usr/local/bin/molecule", line 11, in <module>
    sys.exit(main())
  File "/Library/Python/2.7/site-packages/molecule/cli.py", line 68, in main
    CLI().main()
  File "/Library/Python/2.7/site-packages/molecule/cli.py", line 64, in main
    util.sysexit(c.execute()[0])
  File "/Library/Python/2.7/site-packages/molecule/command/status.py", line 57, in execute
    status = self.molecule.driver.status()
  File "/Library/Python/2.7/site-packages/molecule/driver/dockerdriver.py", line 176, in status
    cd = self._docker.containers(filters={'name': name})[0]
IndexError: list index out of range

Fix entails adding all=True to the self._docker.containers(filters={'name': name})... call in molecule/drivers/dockerdriver.py:176.

Yeah, the problem with that, is the way in which docker reports status.  If you add that, then molecule status when the container is offline, will not show the custom offline message, but instead show the number of minutes since the container was stopped.

The use case is displaying the default docker status while machine is up, and not_created when down.  Looks like I introduced that bug when implementing this logic.

@retr0h Is molecule's preference to display a more user friendly message? Also, I don't quite understand what you were getting at when you say, "when the container is offline, will not show the custom offline message, but instead show the number of minutes since the container was stopped.". Could you clarify?
With the proposed change, the status describes how much time has elapsed since the container 'Exited'. If the container does not exist, the not_created state, the status reports 'Not Created'.

With the proposed change, the status describes how much time has elapsed since the container 'Exited'. If the container does not exist, the not_created state, the status reports 'Not Created'.

That should be fine.

Released molecule 1.11.3 to pypi.


Add ability to pre-provision in Vagrant

I had a need to add some network configuration changes to my nodes
while spinning up VMs with Vagrant. This commit adds the ability to
add custom changes to your node block configuration by creating a vagrant/
directory and adding a Vagrantfile.<node_name> file to that directory.
You can then add your own custom configuration options which will run
before the main Ansible provisioner. The use case I'm solving for is when
I want to add a bridged (public) interface to a Vagrant node and then
configure a tagged VLAN interface before doing the main provisioning
with Ansible.

I have some other fixes, but I'm going to provide those in another PR since they are basically unrelated to this change. Thanks!


adding likewise earlystopping best mae/rmse scores performance value

When you run the tests I saw that you use the last epoch result for Example in Freesolv DMPNN. I wonder if you can provide a way to show and save also the best score epoch value which is a natural way to do so with EarlyStopping without  defining a true ES callback by the fact that you have generally set lr_cycle processes.
What do you think ? I would not remove the 300 last results but add a new column called "best results". Specially cause the FreeSolv split performance is so affected by the seed.

I added a max min section to the score output. But since we have a cross-validation there is already some average of the final error. However, it is not really fair to report the best validation error in cross-validation since you should not know it as it is actually the test data, which should be all blind. We could split off a little separate validation data in each set for early stopping, but it is not guaranteed that it will be also good in test set.
For now I only see a major decrease of test error in PROTEINSDataset which starts at 0.8 accuracy and falls down to like 0.7 during fitting...

Indeed, generally I merge the 5CV individual validation outputs into the full dataset and compute the rmse only once (there is no more std in this case). In general (most of the case) the 5CV mean rsme value is very close to this combine RMSE value. Except for Freesolv where the split has a dramatic influence in the performances. But if you consider the earlystopping as a good technic which I do, you don't want to overfit too much on the training dataset meaning that you start to memorise and you also start to be less "generalisable" so long trainings are not "efficient" for me. It's why the best performance on a validation set should be use to store the best-model and apply to an extra test set.

Okay, sure. I just roughly set the hyperparameter so that it does never really overfits too much. Yes, the splits matter. We always use random splits, I think there is one split for e.g. ESOL that gets like 25% better performance. I would have to run multiple random 5-fold CV and then average all. But this is a little more time consuming.
I will add a Best RMSE column for the small datasets, which are split dependent.

Okay, I added the column with some description as you proposed. I will also from now on fix the random state for the K-fold split, meaning they ideally should all train on the same random split, which should increase reproducibility and comparability

It makes lot of sense now, I will close this issue

Done

Okay, I will do add them for all stats, to show them you simply have to copy results folder and run python3 summary.py --min_max True


For-in

Why don't you use Object.keys + for instead of for-in? It works much faster, cleaner and no need to call hasOwnProperty all the time.

I could do, but it means dropping IE8 and below. Something which would probably make a lot of people fairly unhappy. I suppose I could sniff for typeof Object.keys === 'function' and use alternate methods, but it could easily make the code a bit messier.

Polyfill] of Object.keys could be used when there is no such function. So in modern browsers code would work much faster and old browsers would not be dropped out.

Good point, that'd be the best approach. Then the only concern is extra
file size for those that just wanted a small-ish event class. Shouldn't be
too bad though, I may drop it in soon.
On 9 February 2015 at 15:20, coderaiser<EMAIL_ADDRESS>wrote:

Polyfill] of Object.keys
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys
could be used when there is no such function. So in modern browsers code
would work much faster and old browsers would not be dropped out.
—
Reply to this email directly or view it on GitHub
https://github.com/Wolfy87/EventEmitter/issues/89#issuecomment-73525898.

Not a bad idea, but this is an unnecessary micro-optimization IMO. Adding 40 line polyfill to improve 2 lines isn't worth it.

I say leave it as it is. It's not like this is too slow.
Sent from my iPhone

On 9 Feb 2015, at 16:02, David DeSandro<EMAIL_ADDRESS>wrote:
Not a bad idea, but this is an unnecessary micro-optimization IMO. Adding 40 line polyfill to improve 2 lines isn't worth it.
—
Reply to this email directly or view it on GitHub.

Thanks for the input you two. I think I'd rather keep it simple and not introduce whatever monster this is trying to prevent.
hasDontEnumBug = !({ toString: null }).propertyIsEnumerable('toString'),

(from the polyfill)


LLVM 15.0.0.rc2

Most relevant is that the versioned libclang is gone again.

Most relevant is that the versioned libclang is gone again.

That's a shame. This means we'll have to go for rebuilding qt against each major version of libclang instead of only once.

Most relevant is that the versioned libclang is gone again.

That's a shame. This means we'll have to go for rebuilding qt against each major version of libclang instead of only once.

You can comment in the PR that changed it or on discourse. I guess there's still a small window where this might be reconsidered, but once LLVM 15 is out, the appetite to change back to versioned again  (after going forth and back in LLVM 14 & 15) will probably be out of the question for a while.

You can comment in the PR that changed it or on discourse.

I saw you commented on the PR, but realistically there's only a handful of people there, and Tom Stellard is currently away (at least he passed on his RM duties). You'll probably have more chances of success (or at least a wider audience) on discourse (which fully replaced their mailing lists).

Do you have some time to do that? I don't know if I'll be able to find the time.

Do you have some time to do that? I don't know if I'll be able to find the time.

Don't know if I'll be a good spokesperson for your concerns, but I can past your question.

Do you have some time to do that? I don't know if I'll be able to find the time.

Don't know if I'll be a good spokesperson for your concerns, but I can paste your question.

Done

Do you have some time to do that? I don't know if I'll be able to find the time.

I had posted to the LLVM discourse, and after some discussion, we now arrived at a PR (based on changes I proposed), but it's receiving pretty strong pushback both on phabricator and now also on discourse, and the time for 15.0.0-rc3 is running low (though the interim release manager has extended the release partially for this).
In any case, I don't think more answers from my side will shift the balance, so I've taken this as far as I could. If you'd like to have this feature back, I think the best way is to get involved in the conversation.


Jamie/4439 - This one goes to 11

:nut_and_bolt: Description: What code changed, and why?
This PR bumps our Angular framework from v10 to v11, which is the most current production ready version of Angular.
Migrate Angular
This did two things:

Update the various @angular packages in package.json.
Automatically apply migration patches to our code base.

Commands:
ng update @angular/core @angular/cli
ng update @angular/material
Reference: https://update.angular.io/?l=3&v=10.2-11.0
Update all other npm packages to wanted (or constrained) version.
Patch code incompatibilities due to all of the above
The few necessary patches, included in various commits herein, have achieved these milestones:

[x] build (ng build)
[ ] unit tests (via wallaby in VSCode)
[ ] unit tests (make unit via command-line)
[ ] e2e tests (protractor via make e2e)
[ ] lint (make lint)
[x] launch application (make serve)
[x] application runs with no errors in browser
[x] application runs with no warnings in browser

:chains: Related Resources
Last Angular Update (v9 -> v10): https://github.com/chef/automate/pull/4468
:+1: Definition of Done
With Angular 11 / TypeScript 4 ecosystem, Automate-UI and all of its unit and integration tests still function properly.
:athletic_shoe: How to Build and Test the Change
Do your usual hab studio setup notably including building automate-ui-devproxy.
Then (line numbers shown for reference):
[1] cd components/automate-ui
[2] mv node_modules /location/to/save/your/old/node_modules
[3] npm install
[4] make serve

Notes:
Line [2] is only needed if you want to be able to easily resume what you were doing before you tried out this PR! Once you are done evaluating, move or delete your new node_modules and restore your copy made in line [2].
Line [3] generates the new node_modules directory for this PR.
Line [4] starts automate-ui.
:white_check_mark: Checklist

[x] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[x] All commits have been signed-off for the Developer Certification of Origin.

Note: ngrx 10.1.1 throws a missing peer dependency of angular 10, I believe this can be safely disregarded until ngrx 11 is released.  Reference: https://github.com/ngrx/platform/issues/2830#issuecomment-748628514

Note: Formbuilder#group deprecations: https://angular.io/api/forms/FormBuilder#group

The link above for  https://github.com/ngrx/platform/issues/2830#issuecomment-748628514 is broken.

Welcome, @SEAjamieD.
Many commits to this PR -- that cleanly and clearly documents your steps. ✅
You have completed level N. Time to advance to level N+1.

Observe the ellipses on many of the commit messages (image below). That is a polite (yet subtle 😉 )way for the system to tell you your message headers (as distinct from message bodies) are too long. Have a look at How to Write a Git Commit Message for ways to refine the quality of your commit messages.


Fix spelling, change indentation for 'if...then' and 'for...loop'.

Change indention rule for 'if' statements and loops to format them like this:
IF some condition
THEN
    -- Do some cool statements
    INSERT blah blah blah;
END IF;

Codecov Report

Merging #5578 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5578      +/-   ##
==========================================
- Coverage   83.03%   82.99%   -0.04%
==========================================
  Files         137      137
  Lines      151957   152379     +422
==========================================
+ Hits       126174   126472     +298
- Misses      25783    25907     +124

Impacted Files
Coverage Δ

src/gui_gtk_x11.c
58.06% <0%> (-0.1%)
:arrow_down:

src/gui.c
63.63% <0%> (-0.67%)
:arrow_down:

src/ui.c
72.32% <0%> (ø)
:arrow_up:

src/gui_gtk.c
31.45% <0%> (ø)
:arrow_up:

src/os_unix.c
63.63% <0%> (ø)
:arrow_up:

src/if_xcmdsrv.c
85.99% <0%> (-0.36%)
:arrow_down:

src/buffer.c
85.76% <0%> (ø)
:arrow_up:

src/highlight.c
82.58% <0%> (ø)
:arrow_up:

src/misc2.c
87.73% <0%> (ø)
:arrow_up:

src/testing.c
90.69% <0%> (ø)
:arrow_up:

... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e117e...ef31f98. Read the comment docs.

have you contacted the files maintainer (mentioned at the top of the file)?

I will do so.

Hi response yet from the author.

Let me include this now.  Would be nice if you could write a few test cases.


Search Movies by name

This task is to enable users to search movies by their names. Given a word, the search should list all the movies that have the word in their names (case insensitive). For example, given "Ame", the search should return: "The American President, How To Make An American Quilt, Lamerica, Fair Game, Screamers".
Please create an issue that should include: the PBI (user story), description, task list, acceptance criteria, and acceptance tests. And follow the GitHub flow to finish this issue.
(You will need to add an option in the menu for this search. When the user chooses this option, the program lets the user enter a word to perform this search.)

Added support for searching movies by names


⚠ Bofrost.nl has degraded performance

In 40a6c27, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1488 ms

Resolved: Bofrost.nl performance has improved in c99cc19.


Update TypeScript, refactor

Updates dependencies to the most recent version of TypeScript.
Tweak/refactor a bunch of things in snabbdom.ts. Most of the changes are related to using new features in JavaScript/TypeScript.
I won't go through each change but please comment if there is anything that does not look like an improvement :smile:

Thanks for the comments @mightyiam. Btw, feel free to merge my PRs. It's safe to assume I'm okay with that :wink:
There are many places in Snabbdom where we access nested properties that may be undefined along the way. Now that those have been replaced by optional chaining (?.) we could consider removing the isUndef function altogether? Its benefits are less clear now.


V2.0.0-beta-59 Can't resolve '@material-ui/icons/FileDownload'

I've the impression to run on this to time to time very strange.
I've just upgraded from 2.0.0-beta-54 to 2.0.0-beta-59.
Can you check ?
Thanks,

trying the #515

This issue seems to come from that the versioning scheme has silently changed since beta 55 - latest version is 2.0.0-beta.59 as opposed to 2.0.0-beta-59 (previous scheme). Referencing ^2.0.0-beta-59 had me end up on 2.0.0-beta-9.
https://www.npmjs.com/package/mui-datatables?activeTab=versions

That's weird to change convention naming during the project...
Because when you are changing from this to that :

That's is my case, you cannot gest that you have to put a . instead of - like this ... Especially using some automatic dependency finder like npm-upgrade ..

Yes, this is something I had screwed up initially by not using dots. That's why I made the change.


RFC: build the profiler with both release and debug tracers by default

Here is an analysis of the needs and issues people face:
Main Needs:

Enable the debugging for the tracer at any time by the parameter to obtain more meaningful information without needing to recompile it.
When the debugging is not needed, disable it by remove the parameter to run the profiler with optimal performance.
If possible, integrate the BPF program of the profiler into third-party applications with the debug tracer to be enabled, and get valuable information in some way.

Main Issue:
When binary files are committed to the git repository, the storage space quickly increases with each commit.
My Solution:

Build both the release and debug tracer by default, and enable or disable tracer debugging as needed.
Publish a profiler with the debug tracer on a branch synchronized with the mainline, and tagged with a special label like v1.0.1-debug to make integration easy.

Implementation Steps:

Modify the Makefile in the root directory, select different GO_TAGS and BPF program compilation commands based on the branch .

-GO_TAGS := osusergo,netgo
-EBPF_FLAGS :=
+ifneq (,$(findstring debug,$(BRANCH)))
+    GO_TAGS := osusergo,netgo
+    EBPF_FLAGS := fake-release
+else
+    GO_TAGS := osusergo,netgo,debugtracer
+    EBPF_FLAGS :=
+endif

-debug: GO_TAGS := $(GO_TAGS),debugtracer
-debug: EBPF_FLAGS += debug
-debug: all

Modify the Makefile in the support/ebpf directory, and compile two versions of the tracer by default. If the debug tracer need to be released, compile only the debug version tracer and rename it as the release version tracer. By this way, third-party applications can use v1.0.1-debug to reference the debug version tracer.

-TRACER_NAME ?= tracer.ebpf.$(BUILD_TYPE).$(TARGET_ARCH)
+TRACER ?= tracer.ebpf.release.$(TARGET_ARCH)
+DEBUG_TRACER ?= tracer.ebpf.debug.$(TARGET_ARCH)
+
+TARGET ?= $(TRACER) $(DEBUG_TRACER)

-ifeq ($(BUILD_TYPE),debug)
-       TARGET_FLAGS+=$(DEBUG_FLAGS)
-endif

 SRCS := $(wildcard *.ebpf.c)
-OBJS := $(SRCS:.c=.$(BUILD_TYPE).$(TARGET_ARCH).o)
+OBJS := $(SRCS:.c=.release.$(TARGET_ARCH).o)
+DEBUG_OBJS := $(SRCS:.c=.debug.$(TARGET_ARCH).o)

-all: $(TRACER_NAME)
+all: $(TARGET)

-debug:
-       $(MAKE) BUILD_TYPE=debug
+fake-release:
+       $(MAKE) TARGET=$(DEBUG_TRACER)
+       mv $(DEBUG_TRACER) $(TRACER)

A friendly ping to people to join this discussion. @florianl @rockdaboot @umanwizard @Gandem @athre0z @dmathieu @christos68k


ConfigUtils initialization issue

Description: Crashes when starting the server. Guessing it's failing to read the config maybe
Crash report: https://gist.github.com/profjb58/7e0a99fdb059e8e51c8b1e856dbc7792

was more of a bug/discrepency with latest FabricWarps & FabricHomes, fixed in their respective v0.2.1 and v0.1.3


fix(select-button): add support for mobile devices

:rocket: Welcome to Baloise ChatOps based GitOps Bot :tada:
- If you want to enable preview environments for this PullRequest, comment with `/preview`.
- If you want to disable the preview environment for this PR, comment with `/undeploy`.
- If you need help or want to see the docs, comment with `/help`.

Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:


Add remote image support to OpenShift Template

[x] Add remote image support to OpenShift Template
[x] Test that remote images work
[x] Add docs to README.md for remote image support

/lgtm


Fix endless loop when awaiting Lnurl

In resource LnurlAwait the check for an existing LNURL in the database causes the subsequent loop to run for ever since the invoice variable is never filled. It seems that the call LnurlModel.find_by_uuid(uuid) does not actually query the database anymore after the first call on line 36. So an updated value will not be detected. However, when closing the db session explicitly the subsequent calls get 'fresh' data.
I propose the following test script which simulates a LNURL capable wallet submitting an invoice after a delay of 5 seconds.
import requests, time, json, qrcode, time, threading, logging

def findnth(haystack, needle, n):
    parts= haystack.split(needle, n+1)
    if len(parts)<=n+1:
        return -1
    return len(haystack)-len(parts[-1])-len(needle)

def wallet_action(uuid):
    sleep = 5
    logger.info(f'Starts in {sleep} seconds')
    time.sleep(sleep)

    request_lnurl = "http://lnurl.test:5000/v1/lnurl/" + uuid
    response_lnurl = requests.get(request_lnurl)
    lnurl_json = response_lnurl.json()

    request_withdraw =  lnurl_json['callback']
    k1 = lnurl_json['k1']
    pr = 'lnbc5u1p0fa0g0pp5z0xnnq63p7fx7vs3t4sx9sapk3lvpeppffy0pursn6fz5m99xr0qdqqcqzpgxqyz5vqsp59kyl2900ggel0e8gr2s3uv4ze5d96aqdm0q597npqn4mlkm0fwes9qy9qsq8s2d96sljuhnu9za7edskaxlmur2rxuzhg4ckyctq970nsplxev8ccdfs9jmw75t79vvxhqpsz3r83xf7qzc9fcss8jxwmkdgxt7kusp0j3dl5'
    data = {'k1': k1, 'pr': pr}
    logger.info(f'Submits k1: {k1}, pr: {pr}')
    response_withdraw = requests.get(request_withdraw, params=data)
    response_withdraw.json()

logging.basicConfig(level="INFO", format='%(threadName)-6s | %(message)s')
logger = logging.getLogger(__name__)

threading.current_thread().name = "main"
request_url = "http://lnurl.test:5000/v1/lnurl"
data = {"amount": 500}
response = requests.post(request_url, json=data)

logger.info("Received LNURL:" + response.json()["lnurl"])
callback = response.json()["callback"]
logger.info
logger.info("Received 'await-invoice' URL:" + callback)

uuid = callback[findnth(callback, '/', 4)+1 : findnth(callback, '/', 5)]
wallet_thread = threading.Thread(target=wallet_action, args=[uuid], name="wallet")
wallet_thread.start()

logger.info(f'Starts longpolling at {callback} \n')
response = requests.get(callback)
logger.info('Here is the invoice your wallet just submitted over "LNURLProxyAPI:"')
logger.info(response.json()['invoice'])

This in indeed a lovely change and fixes this problem :fire: Very nice! Also the test is perfect for this!! :+1:
I've got an idea for the test:
Instead of searching "for the needle in the haystack" we could give the wallet a proper tool to decode the received LNURL like so:
import lnurl  # At the top

decoded_lnurl = lnurl.decode(response.json()["lnurl"])
request_lnurl = decoded_lnurl.base

findnth() could be removed
wallet_action() wouldn't receive a parameter
wallet_thread would not need to be given arguments
request_lnurl does not need to be concatenated

There is actually even a LnurlWithdrawResponse object in that library that we could use:
https://github.com/python-ln/lnurl#building-your-own-lnurl-responses
What do you thing?

What do you think?

Yes for sure, we should use the functionality from the library whenever possible.
import requests, time, json, time, threading, logging
from lnurl import Lnurl, LnurlResponse, handle

def wallet_action():
   sleep = 5
   logger.info(f'Starts in {sleep} seconds')
   time.sleep(sleep)

   res = handle(lnurl_string) # LnurlWithdrawResponse

   k1 = res.k1
   pr = 'lnbc5u1p0fa0g0pp5z0xnnq63p7fx7vs3t4sx9sapk3lvpeppffy0pursn6fz5m99xr0qdqqcqzpgxqyz5vqsp59kyl2900ggel0e8gr2s3uv4ze5d96aqdm0q597npqn4mlkm0fwes9qy9qsq8s2d96sljuhnu9za7edskaxlmur2rxuzhg4ckyctq970nsplxev8ccdfs9jmw75t79vvxhqpsz3r83xf7qzc9fcss8jxwmkdgxt7kusp0j3dl5'
   data = {'k1': k1, 'pr': pr}
   logger.info(f'Submits k1: {k1}, pr: {pr}')

   response_withdraw = requests.get(res.callback, params=data)
   response_withdraw.json()

logging.basicConfig(level="INFO", format='%(threadName)-6s | %(message)s')
logger = logging.getLogger(__name__)

threading.current_thread().name = "main"
request_url = "http://lnurl.test:5000/v1/lnurl"
data = {"amount": 500}
response = requests.post(request_url, json=data)

lnurl_string = response.json()["lnurl"]
logger.info("Received LNURL:" + lnurl_string)
callback = response.json()["callback"]
logger.info
logger.info("Received 'await-invoice' URL:" + callback)

wallet_thread = threading.Thread(target=wallet_action,  name="wallet")
wallet_thread.start()

logger.info(f'Starts longpolling at {callback} \n')
response = requests.get(callback)
logger.info('Here is the invoice your wallet just submitted over "LNURLProxyAPI:"')
logger.info(response.json()['invoice'])

I will submit this test in a separate folder with accompanying requirements.txt.

Hint:
When testing on localhost with http instead of https it is necessary to set the following environment variable for the lnurl library to allow the connection: LNURL_FORCE_SSL=0


react-native link react-native-oauth doesnt work on Windows powershell

rnpm-install ERR! Something went wrong while linking. Error: spawn UNKNOWN
Please file an issue here: https://github.com/facebook/react-native/issues

spawn UNKNOWN

I get the following error when attempting to link the library. Solution was to remove the pre and post link shell scripts that were erroring out.
  "rnpm": {
    "commands": {
      "prelink": "node_modules/react-native-oauth/bin/prepare.sh",
      "postlink": "node_modules/react-native-oauth/bin/cocoapods.sh"
    },
...

It appears the shell script expected to be running bash but in this case I am running in powershell. Can there be a better linking workflow to account for this?

I have a problem like you can fix it?

@talk2MeGooseman same

@auser  any advice ?


Taking more than one gradient fails with default RecursiveCheckpointAdjoint

I am a total beginner with Jax and diffrax, not sure if this is a bug or expected, but if i try to find the second or higher derivative of  a solution from diffeqsolve() I get an error. Changing the adjoint to DirectAdjoint() seems to fix the problem.
Minimal working example (using the default ODE example from the diffrax introduction):
import jax.numpy as jnp
import numpy as np
import jax
from diffrax import diffeqsolve, ODETerm, Dopri5,  DirectAdjoint

z = 2.3
t = 1.

def rhot(z):
    def f(t, y, args):
        return -z*y

    term = ODETerm(f)
    solver = Dopri5()
    y0 = jnp.array([2., 3.])
    solution = diffeqsolve(term, solver, t0=0, t1=t, dt0=0.1, y0=y0)
    #solution = diffeqsolve(term, solver, t0=0, t1=t, dt0=0.1, y0=y0, adjoint = DirectAdjoint()) #changing the adjoint fixes it
    return solution.ys[0][0]

drhozdz = jax.grad(rhot,argnums = 0)
d2rhozdz = jax.grad(drhozdz,argnums = 0)

print("expected state ", np.exp(-z*t)*2.)
print("found state ", rhot(z))

print("expected ", -2.*t*np.exp(-z*t))
print("found 1st deriative ", drhozdz(z))

print("expected 2nd ", 2.*t**2*np.exp(-z*t))
print("found 2nd derivative ", d2rhozdz(z))  #fails with default adjoint

The error returned is:
"print("found 2nd deriative ", d2rhozdz(z))  #fails with default adjoint
^^^^^^^^^^^
ValueError: Reverse-mode differentiation does not work for lax.while_loop or lax.fori_loop with dynamic start/stop values. Try using lax.scan, or using fori_loop with static start/stop."

Yup, I'm afraid this is expected. RecusiveCheckpointAdjoint does some smart things under-the-hood to be very efficient when computing specifically first-order gradients, but unfortunately this also makes it incompatible with certain kinds of higher-order autodiff.
First of all, when looking to compute the Hessian, it is usually more efficient to use forward-over-reverse rather than reverse-over-reverse (and indeed this is what jax.hessian does). RecursiveCheckpointAdjoint should actually be compatible with that in most cases.
But nonetheless, in the general case, using DirectAdjoint is indeed the appropriate fix. (And handling edge cases like this is the reason it exists,)
You might also like the example on second-order sensitivies from the documentation.

I'm going to tag this under "refactor" as this could probably do with a more informative error message.

Thanks for the quick reply, I missed that documentation, it was very helpful.
Playing around a bit with a more complex example I am struggling with, I see what you mean...  doing forward-over-reverse with RecusiveCheckpointAdjoint() works and seems both faster and more memory efficient than using DirectAdjoint(), so that was extremely useful!  thanks!


Command "typecheck:watch" not found

command yarn dev
error:
➜  empty-webapp git:(master) ✗ yarn dev
yarn run v1.22.19
$ concurrently "yarn typecheck:watch" "webpack serve --config webpack.config.js"
error Command "typecheck:watch" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[0] yarn typecheck:watch exited with code 1
[1] <w> [webpack-dev-server] "hot: true" automatically applies HMR plugin, you don't have to add it manually to your webpack configuration.

command yarn dev error:
➜  empty-webapp git:(master) ✗ yarn dev
yarn run v1.22.19
$ concurrently "yarn typecheck:watch" "webpack serve --config webpack.config.js"
error Command "typecheck:watch" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[0] yarn typecheck:watch exited with code 1
[1] <w> [webpack-dev-server] "hot: true" automatically applies HMR plugin, you don't have to add it manually to your webpack configuration.

I tried to run yarn add -D buffer, but it didn't work


add controlflow handling to stochastic swap pass

Summary
Adds controlflow handling to StochasticSwap routing pass.
Depends on #8793
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

98 of 101 (97.03%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.02%) to 84.013%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/transpiler/passes/routing/stochastic_swap.py
95
98
96.94%

Files with Coverage Reduction
New Missed Lines
%

qiskit/extensions/quantum_initializer/squ.py
2
80.9%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
55989

Relevant Lines:
66643

💛  - Coveralls

A couple of issues I noticed while allowing control flow instructions to be less than full width:

the usage of for node in dag.two_qubit_gates may return CF instructions since these should get through the unrolling which could cause exceptions
sometimes it seemed possible for a CF instruction's num_clbits to get out of sync with the DAGOpNode.cargs using public methods. I can't remember how it occurred but if I do I'll create an issue.

For 1: when this method has been used in other transpiler passes, I've put in an explicit if isinstance(node.op, ControlFlowOp): continue at the start of the loop to avoid issues.
For 2: that seems a bit worrying.  At a guess, perhaps it's if a clbit that's in the condition of the argument is also in the body of the blocks becomes idle in the blocks?  For IfElseOp, the two blocks also need to have the wires be idle in both blocks to be removed again, which seems like a vector for issues.

For 1: when this method has been used in other transpiler passes, I've put in an explicit if isinstance(node.op, ControlFlowOp): continue at the start of the loop to avoid issues.
We could also set a flag on the DAGCircuit method which by default doesn't include two qubit CF instructions.

For 2: that seems a bit worrying. At a guess, perhaps it's if a clbit that's in the condition of the argument is also in the body of the blocks becomes idle in the blocks? For IfElseOp, the two blocks also need to have the wires be idle in both blocks to be removed again, which seems like a vector for issues.

That's a possibility. I usually didn't intend to remove idle classical bits but it's possible they slipped through somehere.
The pass only considers wires as idle as the intersection of idle wires of each block.

(Also, it perhaps wouldn't be a bad idea to rebase this PR to get rid of the accidentally re-applied commits from main - it's not really the end of the world, but if we merge as-is, about 11 people will falsely get claimed as co-authors.)


update to trystan-inheritences

My vscode at home is set up for a different account, so I created a branch to push and pull to, and this is a pull request with some of the changes I made.

Merged pull request


WIP on docs rework

Moved files and made it much easier to navigate within the docs

I need to make this build, check if any links are broken in the main repo too


Vertical labels : is it possible?

I'm trying to get vertical labels to resolve this problem :

Some labels disappears.
How can I do?
Thanks

Duplicate of #1234


Uninstall does not work

Clicked Uninstall several times, does not work.
Atom 1.0 on Mac OSX 10.10.3

Also Atom 1.0 on Mac 10.10.3- uninstall works for me. Try looking into developers console for some errors?
I also noticed that when i click, osx keychain ask me for a permission to authorize, maybe this is permission issue with your keychain?
I have a Polish version of OSX but this may help you - This is screenshoot of keychain permission dialog that have appeared to me when I was uninstalling plugin.

@michaelaye I would be happy to hear any feedback.

I never required a password to install Atom packages and I shouldn't, as everything should go to ~/Library and not /Library. However, it might have been a temporary hickup with the Atom API, because after restarting Atom your package was indeed uninstalled. Thanks!

:+1:


What is the difference between last_updated and created?

Why do we need both of these variables if they are set to the same value. Should last_updated be when the dataset was last updated and created be when a particular record was created?  Maybe this issue is more appropriate for OpenClimate-schema

created is written once, last_updated is updated each time we, uh, update


[Bug]: Game crashes when encountering Iceologer

Mod Loader (Required)
Fabric
Minecraft Version (Required)
1.20.1
Mod Version (Required)
0.14.22
Notes (Required)
I run a server and multiple players have been completely locked out of their game when facing pillagers. It usually happens when they get attacked by the iceologers ice attack that forms above their head but sometimes the same thing happens just by being close to the pillagers.

Attached is the error message. The only way to fix this is to delete their player data from the server. This allows them to get back online, minus all of their inventory etc but if they return to the chunk the crash happens again because the mob has corrupted the chunk. At this point I have to completely roll back the server.
This has been present for a couple of months now and has happened multiple times to the point where I've just removed the mod. That's a shame as I absolutely love this mod. Hopefully you're able to fix this.
latest.log (Optional)
No response

There is no Iceologer mob in Illager Invasion unfortunately.

I don't know for sure that it was the iceologer, reports from players are obviously a bit obsured seeing as one second they're just playing normally and then the next second their game comes up with that error message. When I ask them what they were doing right before they died all of them say they were dealing with pillagers.
A couple of them mentioned the ice thing so I was just guessing that maybe that had something to do with it. Does that error stand out to you at all? This didn't happen until I installed your mod. Obviously it's very situational as the world will run fine until players encounter a raid but once they do this is what happens.
I've removed the mod now so if you don't want to look into it I guess there's not much more to say but it would be great if you could possibly investigate this as I love your mod and would really like to keep using it.

Again, it more than likely has nothing to do with an iceologer.

Again, it more than likely has nothing to do with an iceologer.

Friends and Foes Iceologer?


fix: adjusting sidenav list for better viewing

Adjusting the sidenav list appearance per request:

Hi @NickSaglioni,
General look good. Olga had a brief look during scrum and mentioned this behaviour is a bit strange. Would you be able to adjust it? Thank you.
Please use your judgement if this behaviour should be on common repo or not.

reference from Carbon: https://carbondesignsystem.com/components/UI-shell-left-panel/usage/

Hi @NickSaglioni,
Generally look good. Olga had a brief look during scrum and mentioned this behaviour is a bit strange. Would you be able to adjust it? Thank you. Please use your judgement if this behaviour should be on common repo or not.  reference from Carbon: https://carbondesignsystem.com/components/UI-shell-left-panel/usage/

Hi @ianliuwk1019. Thanks for pointing it out. I have adjusted as requested. Please let me know if it looks ok. Thank you.

Hi @NickSaglioni,
Generally look good. Olga had a brief look during scrum and mentioned this behaviour is a bit strange. Would you be able to adjust it? Thank you. Please use your judgement if this behaviour should be on common repo or not.  reference from Carbon: https://carbondesignsystem.com/components/UI-shell-left-panel/usage/

Hi @ianliuwk1019. Thanks for pointing it out. I have adjusted as requested. Please let me know if it looks ok. Thank you.

Hi @NickSaglioni , thanks for adjusting.
The hover on the none-selected item seem to also "bold" the text. The Carbon style sample does not do that. Could you adjust it? If common repo does not have specific one for side navigation hover styling, maybe just change it as sideNave.vue. Thanks.

looks good, thanks Nick! My only concern is that, when there is only the "add user permission" option, the rest <li> elements are hidden, however they still exist, not sure from the accessibility perspective for screen reader, should we still render them? will that confuse the user? or it's okay to just hide them like this

looks good, thanks Nick! My only concern is that, when there is only the "add user permission" option, the rest <li> elements are hidden, however they still exist, not sure from the accessibility perspective for screen reader, should we still render them? will that confuse the user? or it's okay to just hide them like this

That's a good observation from @MCatherine1994! It is preferable conditional rendering the elements and not just hide the element. Not sure if the reader agent actually take into account if the element is "display: none", probably not.

Will merge this pr, and @NickSaglioni please create a follow up ticket to make adjustment of hidden side navigation options, thanks!!


Can't format inside tokio select macro.

I try to add some instructions, but I found it easy to understand.
https://docs.rs/tokio/0.3.5/tokio/macro.select.html

Does cargo fmt work for that code?

Rustfmt doesn't format code inside macros as it only sees opaque token trees. It doesn't know if those token trees should be interpreted as item, statement, expression or anything else.

Not our bug, then


adding gradient in button and animation so that website look good

@avinash201199  I can add gradient in buttons and animation, the website will definitely look spectacular ,please assign this issue to me...😀😀😀

don't forget to add screen shot  on pr :)
and add issue number to pr


Added session manager

I have added a utility tool for developers which help them manage their productivity better. This is my first time creating a pull request please guide me incase of any error or anything

Added readme.md file. Please check now.

Please check now

Thank you for your patience. I have done the necessary changes. Please check now @FerdausPolok

I will just update this pr and submit it after updating if it's fine

I will just update this pr and submit it after updating if it's fine

Okay then feel free to start further working by creating an issue first. Thanks.


index=1 is hardcoded in lib/saml2/Metadata.php on AssertionConsumerService element

I am using the php-saml library and implemented the service provider part.
I generate metadata using the library.
In Metadata.php inside builder function index attribute is set to 1 for AssertionConsumerService and AttributeConsumingService XML elements.
I have below questions

why it is directly set to 1.
Is it ok if I changed the value to 0. What will be the impact? Are we using this index="1" value anywhere in code.

When I try to configure generate metadata in IDP it gives me below error.
SEVERE - /EntitiesDescriptor/EntityDescriptor/SPSSODescriptor/AssertionConsumerService/@index           AssertionConsumerService index should be 0
Please suggest what is the impact if I changed the value from 1 to 0.

I believe I used as template the one defined here which contains index=1 for AssertionConsumerService and AttributeConsumingService:
http://www.datypic.com/sc/saml2/e-md_SPSSODescriptor.html
If you check the wikipedia, the SP metadata also contains a AssertionConsumerService with index=1
https://en.wikipedia.org/wiki/SAML_2.0#Service_provider_metadata
Not sure of the impact of modifying it to be 0 instead of 1.
What IdP are you using that validates that the index may be 0?


Fix typo in some format scripts

Incorrect ending of POSIX format string breaking some code
Would be good to rebase PRs after this is merged as this might fix some cases that have been missed previously as the matches weren't correct
Discovered in:

https://github.com/godotengine/godot/pull/87352

That's weird, it used to work fine when I wrote it. I wonder what changed.

Unsure what causes it bit solves the issue here https://github.com/godotengine/godot/actions/runs/7748557498/job/21131383267?pr=87352#step:16:13

@Alex2782 in the rasterizer_canvas_gles3.cpp file, I think you forget to free the utilities variable.

Seems to be some bug with running my local CI for format so will just verify it works here with a quick push, it doesn't catch format errors on this or the unchanged so just gonna verify it works here as CI for clang-format on my local branch has been off at times

Realized that I do still need to verify it works with that PR, will do

Seems this did not fix the specific issue, will have to dig deeper

For context, this is the PR which added these codes, which worked at the time: https://github.com/godotengine/godot/pull/75700
And you can see there how the output is supposed to look like with trailing spaces and tabs.

Believe I've found the complete solution, sorry for using the CI here so much the diff generation seems to fail on my local branch so it won't show up
Keeping the \e\[0m part for now but changed to echo to prevent it printing invalid format sequences

Removing the 0 change, verified locally

There, should be fixed completely now, sorry for the back and forth, adding this printout from the example fail case and restoring:
*** The following changes must be made to comply with the formatting rules:
diff --git a/core/core_bind.cpp b/core/core_bind.cpp
index 3a116a0..e5363f9 [10](https://github.com/godotengine/godot/pull/87864/checks#step:16:11)0644
--- a/core/core_bind.cpp
+++ b/core/core_bind.cpp
@@ -49,[11](https://github.com/godotengine/godot/pull/87864/checks#step:16:12) +49,11 @@ namespace core_bind {
 ResourceLoader *ResourceLoader::singleton = nullptr;

 Error ResourceLoader::load_threaded_request(const String &p_path, const String &p_type_hint, bool p_use_sub_threads, CacheMode p_cache_mode) {
-	return ::ResourceLoader::load_threaded_request(p_path, p_type_hint, p_use_sub_threads, ResourceFormatLoader::CacheMode(p_cache_mode));··
+	return ::ResourceLoader::load_threaded_request(p_path, p_type_hint, p_use_sub_threads, ResourceFormatLoader::CacheMode(p_cache_mode));
 }

 ResourceLoader::ThreadLoadStatus ResourceLoader::load_threaded_get_status(const String &p_path, Array r_progress) {
-	float progress = 0;<TAB>
+	float progress = 0;
 	::ResourceLoader::ThreadLoadStatus tls = ::ResourceLoader::load_threaded_get_status(p_path, &progress);
 	r_progress.resize(1);
 	r_progress[0] = progress;

Thanks!

Thank you!

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.


OC should only parse dependencies specified in package.json

Currently oc parses all node_modeules files which is sometimes causing problems (nock) - it should only parse dependencies specified in package.json

uhm. Have you tried with 0.15.0?

The problem i encountered was in oc dev 0.14.6, i'll try 0.15

in 0.15.0 i get Missing dependencies from package.json => ["request"] error (after npm install)

Yes. With 0.15 you need now to include the node.js dependencies (as request) in the package.json under the dependencies. Standard node.js. Can you try adding this?
...
{
  "dependecies" {
     "request": ""
  }
}
...

that's what i actually have:
"dependencies": {
    "request": "^2.55.0"
  },


Make 'id's unique in PaginationComponent

Description
When displaying a Community with both child Collections and sub-Communities, the pagination controls for the two lists will have duplicate id attributes.  SiteImprove considers this an accessibility issue.  This patch generates a UUID member in PaginationComponent and uses it in the template to make the ids unique.
Instructions for Reviewers
To test, you will need a Community with child Collections and sub-Communities, so that both lists appear.
List of changes in this PR:

The component's class exposes a public elementId field, which is initialized to a UUID in the constructor.
The template appends this to id attributes as appropriate.
The .spec is updated to provide UUIDService for injection.

NOTE:  the .spec is broken:  "NullInjectorError: No provider for UUIDService!"
NOTE:  after the above is fixed, the .spec will probably fail because it is looking for fixed attribute values.  I will work on that after the suite is repaired enough to run at all.
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[ ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

"Help wanted" because I need some advice on how to make the specs work.


allow for bytes or buffer as input

allows for clients to pass in the file as bytes or a buffer of bytes. Added tests to cover both bytes and buffer input cases.

Please generate a new release so we can use this feature. Installing current version 0.4.4 doesn't include these changes.


Address TODOs with package releases

Description

@cpanato, now that it's transferred, we should be good to address TODOs

will do

@cpanato I'm happy to help set up anything around package releases. Let me know

@malancas if you have time feel free to work on that :) that will be awesome

@cpanato, what work was remaining? I see some TODOs in goreleaser, anything else?

@haydentherapper do we want to publish the images in the gcr as well? or only in ghcr.io?
ok, give me 5 min then I will take a look at what is missing and fix that right away, sorry being extremely busy in the past weeks :(

I think to just ghcr is totally reasonable, let's make it easy. I like the idea of making everything run by GHAs.
No worries!

ok sounds good, in case we want in gcr later we can copy manually the old tags :)
I'm doing a rehearsal now and should be ready soon

SG, happy to approve any PRs to update TODOs


Handle when user closes the app while unzipping

Hi there,
Just a quick question:
Is there any way to handle when the user closes the app while unzipping a file?
Because I've tried to close the app while unzipping a file, and the unzipped folder is created, but it is not completely processed (corrupted), so I would want to know if there is a way to handle this, like deleting the file that it's unzipping when the user closes the app, or some workaround.
Thanks.

You could call the Progress API which exposes a cancel() method in your app delegate's applicationWillTerminate implementation. After cancelation you will have to clean up - e.g. by removing any incomplete destination folders. You can learn more about progress tracking/cancelation here:

Thanks @weichsel !
I'll take a look!


[CIT-648] Use time instead of chrono

Proposed changes
Due to RUSTSEC and chrono marked as unmaintained we swap all use of chrono in favour of time crate.
Outstanding is crate rcgen.
Types of changes
What types of changes does your code introduce to thin-edge.io?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Closing in favour of #850 and following.


UMD not setup correctly in gulpfile.js (Browserify Require + 2.0.0-Beta2)

Requiring chart.js in a browserify setup is failing:
chart.js:7209     Uncaught ReferenceError: Chart is not defined

Related PRs:
#1269

Was using tag https://github.com/nnnick/Chart.js/tree/2.0.0-beta2

root can be either window or globals (given configuration) but without this, JS will not lookup in globals object (only in window)

Merged #1850


Remove step size jittering functionality

Summary:
Remove step size jittering functionality from samplers.
Description:
The HMC sampler allow for the nominal step size to be randomly jittered, in line with advice given in Neal's HMC review.  Random jittering, however, is not effective at getting the sampler through regions of high-curvature where we should be using more advanced samplers or modifying the target model.
Removing this functionality will clean up the code and avoid users attempting to use it in difficult problems.
May have to wait for the refactor as jitter is exposed as an argument in CmdStan.
Current Version:
v2.13.1

Duplicate of #1816?


Adds backoff to wing client set

What this PR does / why we need it:
Use a backoff when connection to wing.
fixes #261
Release note:

NONE

/lgtm
/approve


Make curbsides also useable for the foot encoder

Currently the FootFlagEncoder is ignoring the |turn_costs=true flag. However, since for curbsides we need edge-based graph traversal this way we cannot use curbsides. While it might be rare that we need to use turn costs for foot profiles, curbsides could certainly be useful.

We can either try to allow 'edge-based without turn-costs' (#1702), or we allow foot flag encoder with |turn_costs=true (I think I prefer the second option)