chat: fix AttributeError crash on -qq with short context

Closes #948
Always pass logger to start_prompt.

@tiran please explain why this is better. I may miss something.

FYI checked with @tiran and his comment is a suggestion but not a blocker for the existing PR. I personally don't find required keyword arguments better than positional in this case, so leaving as-is.

@mergifyio rebase

@russellb any idea what's up with the error above?

Please make sure nathan-weinberg has logged in Mergify dashboard

If you expand the "Details" it says:

Please make sure nathan-weinberg has logged in Mergify dashboard

https://dashboard.mergify.com/

@Mergifyio rebase

$ tox -r -e unit --notest
$ source .tox/unit/bin/activate
$ ilab serve --max-ctx-size 50
INFO 2024-05-02 13:54:09,758 lab.py:313 Using model 'models/merlinite-7b-lab-Q4_K_M.gguf' with -1 gpu-layers and 50 max context size.
INFO 2024-05-02 13:54:10,186 server.py:196 Starting server process, press CTRL+C to shutdown server...
INFO 2024-05-02 13:54:10,186 server.py:197 After application startup complete see http://<IP_ADDRESS>:8000/docs for API.
Exception: Requested tokens (52) exceed context window of 50
Traceback (most recent call last):
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib64/python3.9/site-packages/llama_cpp/server/errors.py", line 171, in custom_route_handler
    response = await original_route_handler(request)
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib/python3.9/site-packages/fastapi/routing.py", line 278, in app
    raw_response = await run_endpoint_function(
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib/python3.9/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
    return await dependant.call(**values)
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib64/python3.9/site-packages/llama_cpp/server/app.py", line 371, in create_chat_completion
    first_response = await run_in_threadpool(next, iterator_or_completion)
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib/python3.9/site-packages/starlette/concurrency.py", line 42, in run_in_threadpool
    return await anyio.to_thread.run_sync(func, *args)
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib/python3.9/site-packages/anyio/to_thread.py", line 56, in run_sync
    return await get_async_backend().run_sync_in_worker_thread(
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 2144, in run_sync_in_worker_thread
    return await future
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib/python3.9/site-packages/anyio/_backends/_asyncio.py", line 851, in run
    result = context.run(func, *args)
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib64/python3.9/site-packages/llama_cpp/llama_chat_format.py", line 236, in _convert_text_completion_chunks_to_chat
    for i, chunk in enumerate(chunks):
  File "/home/ihrachys/instruct-lab-gitlab/cli/.tox/unit/lib64/python3.9/site-packages/llama_cpp/llama.py", line 953, in _create_completion
    raise ValueError(
ValueError: Requested tokens (52) exceed context window of 50

$ source .tox/unit/bin/activate
$ ilab chat -qq "what is hurling"
Hurling is an ancient Gaelic sport, which originated in Ireland. It is the fastest field game
on earth with the ball reaching speeds of over 145km/h.

Have you re-installed the client package with the PR included?

And
ilab chat -qq "what is hurlingsdfd sdfdaf sdf dsaf dsaf dsaf dsaf dsaf dsaf dsaf dsf adsf dsaf dsfs dafgfdfd dfgf dg fdg fdg fdg fdg dgz fgagsfg dfsg fdsg fdg fgdsg dsf "
Message too large for context size.

@hickeyma I will put https://github.com/instructlab/instructlab/pull/950 here on top to prove it fixes the issue with -qq. (note that it's failing there without this PR; it should pass here now). You can then revert this fix locally and just try to run functional tests without it to see the failure.
FYI I also rebased to latest and it works as expected. I think you have an issue with your environment. Please show how you update your environment with the content of this PR, to confirm you have it included.

@Mergifyio rebase

rebased to include macos functional CI fix

@booxter if you go to https://dashboard.mergify.com/ you'll be able to login and use the rebase command :smile:

@hickeyma you can see that functional tests are now passing (while using -qq to talk to a context constrained server).
I suspect we may deal with different failure scenarios even though they look the same. This may be because the client doesn't provide enough details to see traceback for the AttributeError exception. Could you please reproduce the failure with https://github.com/instructlab/instructlab/pull/1090 (you will need to enable DEBUG in config.yaml for this to log a traceback) and post the traceback here? I'd like to get to the bottom of your failure. Thanks!

@mergifyio refresh

@mergifyio rebase

Note the approval from Nathan came before I included https://github.com/instructlab/instructlab/pull/949/commits/c33f4bd1b1980018f04184199a268e137ce7444f here. I am not sure he would necessarily agree with it without reviewing again.
It would be nice to clarify if anything blocks this PR. @hickeyma said before that he couldn't make this PR improve things for him, but 1) I can't reproduce his failure and 2) I suspect it may be a different one, where details are hidden because of deficient error logging (there's a patch to improve it.)

@hickeyma whenever you get a chance, can you take another look to see if you still hit problems with this?

@mergifyio rebase


Add dimcli library

Hi @gknowles, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Solid work, thanks!


reviewed trisomy 18 terms

Fixes #3127
@nicolevasilevsky : if you think it is necessary. we could create a term that would encompass the extra copy of the full or partial chromosome 18 (some term that would be similar to Down syndrome, but for chromosome 18). Let me know if you think this is necessary

@sabrinatoro I tried to fix the conflict on this branch and I think I messed it up - sorry!
Now I am getting the inference that 'complete trisomy 21' is equivalent to 'trisomy 21' on this branch, which is obviously wrong and it wasn't there before

ok- I think I fixed it but will you double check (can you open this in Protege and make sure all the logical axioms on 'trisomy 18',  'trisomy 21' and 'trisomy 22' (and children) are correct?
If it looks okay, feel free to merge.
Sorry about that!


Add stderrLevels option to Console Transport and update docs.

This PR lets users choose which levels to log to stderr instead of stdout. It's non-breaking and fully backwards compatible with previous options and behavior. I hope you like it :+1:
The new Console Transport option is stderrLevels, which accepts an Array of strings containing the levels to log to stderr instead of stdout.
The code is thoroughly unit tested, contains input validation, and converts the Array provided to options.stderrLevels to an Object for faster key-lookup times. The README.md and docs/transports.md files have also been updated to better reflect the current state of the Console Transport.
Example usage:
Create a Console that logs 'error' and 'warn' levels to stderr, and other levels to stdout:
var console = new (winston.transports.Console)({ stderrLevels: ['error', 'warn'] });
Create a Console that logs nothing to stderr and everything to stdout:
var console = new (winston.transports.Console)({ stderrLevels: [] });
Create a Console that logs certain custom levels to stderr:
var console = new (winston.transports.Console)({
  levels: myCustomLevels,
  stderrLevels: ['delta', 'epsilon']
});

Backwards Compatibility
The current state of the Console has it logging these levels to stderr:

error and debug (if options.debugStdout is false)
error (if options.debugStdout is true)

This behavior is kept as the default for stderrLevels in order to ensure this change is non-breaking: stderrLevels defaults to the equivalent of (options.debugStdout ? ['error'] : ['error', 'debug']). This means that everyone not using the new stderrLevels option will see no change in the Console Transport's behavior.
Note: Another PR from July 2013 exists for the same feature (https://github.com/winstonjs/winston/pull/286), but caused breaking changes and was never merged. Hopefully since this new PR is non-breaking and takes the debugStdout option into consideration, uses an Object for fast key-lookup times, includes unit tests, input validation and updated documentation, the feature we both want to see can finally get in in 2015 :)

Nice improvement!  I also have been wanting to control level-to-output stream mapping for a while.

Let's use that improvement the world needs it

This seems to be a valuable improvement.

I am +1 on this if we can cleanup the obtuse syntax a bit. There has to be a simpler way to setup the initial state.

@indexzero Thanks for the code review, I made some changes following your advice. How does this look? Should I move the setStderrLevels function out of the Console constructor (right now it's there so as to follow the helper-function pattern seen with throwIf in the other transports, e.g. in daily-rotate-file.js line 31)?

This is good. Especially the deprecation notice. This will land in 1.1 and we will fully remove debugStdout in 2.0.0

This was cherry-picked.


Apache SkyWalking 6 with Sofa mosn telemetry data

Hi
I am happy to reach you, talk about how does mosn plan to send telemetry? As the mesh solution inside China, I want to SkyWalking and mosn integration happens. SkyWalking 6 alpha is ready to go soon, release in next two weeks.
For now

SkyWalking supported Istio telemetry format, https://github.com/apache/incubator-skywalking/blob/master/oap-server/server-receiver-plugin/skywalking-istio-telemetry-receiver-plugin/src/main/proto/istio-metric.proto
SkyWalking supported SkyWalking own format, https://github.com/apache/incubator-skywalking-data-collect-protocol/blob/e7fc69462955c86d70f3f7f33712dfe33ecefbc6/service-mesh-probe/service-mesh.proto

I want to get some feedback from you, thanks.

@wu-sheng Tracing support in SOFAMosn is coming in the next release planed in the next month. I'll try to integrate SkyWalking if everything goes well.

Related issue #246

SkyWalking now could supports telemetry without any tracer or agent. That is why I am interested in mesh solution.

This topology based on Istio mixer, no agent or tracer required. How cool is that.


Use getter/setter for attributes if available.

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Use getter/setter for reading and writing attributes if they are available. Use case: when you pre-processing/formatting beforehand.
Also replaced get_class($this) with static::class as it is faster with less op calls: https://belineperspectives.com/2017/03/13/get_classthis-vs-staticclass/
P.S. Will add/fix tests after initial review.

The first iteration was using getPropertyName and setPropertyName directly, now it uses getPropertyNameAttribute and setPropertyNameAttribute alternative getter and setter to allow to have normal getter and setter in the model that is not participating in reading/writing properties from FormModel::load and Html form field which uses getAttributeValue context.
There is also discussion and possibility to extend this to allow even getter and setter without actual property, some sort of virtual attributes for that context.
But I am not sure whether this functionality is needed in model at all. Something similar was present in Yii2, but it was usable there as ActiveRecord model was often used as an actual model for forms and loading from request. Here FormModel and actually DTO and it's not correct to do formatting/pre-processing in DTO. It is better done on the stage of mapping entity to dto and vice-versa.
Leaving my thoughts and PR here for further discussion.
P.S. In case if PR closed at the end without merging, I will push the change of get_class to static::class with another PR.

In any case we can document the possibility of doing something similar with just overriding setAttribute (currently there is only setAttributes, but I will make it private and add public setAttribute instead)  and getAttributeValue in extending class.

@armpogart would you please resolve conflicts? Is there anything to add/fix in this pull request?

See issue for reason.


Building on macOS is currently broken because of this change

Planet is a macOS native app created with SwiftUI. We use WalletConnect for various Ethereum and ENS features. The following change broke building on macOS.
https://github.com/WalletConnect/WalletConnectSwiftV2/commit/ffe2ea43becb7476789803454a964095d0820c56#r128975315

@alexander-lsvk Thank you so much for the quick fix! 1.8.6 works great here.


Use the latest stable version of Ceph

Moving away from Firefly and use Giant instead.
Fixes: #31
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

@Ulexus Not sure how we can properly create a tag for firefly...

We now have Docker tags for firefly and giant (as per #31 ), and the modifications to ceph/base seem to work as expected for the giant release.
My only question is with respect to the upgrade.  Is it safe for people using the latest tag to simply pull fresh containers and run them, or does there need to be additional checking or instructions involved for the upgrade.
Since I'm one of the users of the latest tag, I'd really hate to destroy my ceph cluster by merging this PR. ;)

We should probably add a warning, just to remember users to always use tags (and ceph version) while pulling an image form the hub.
For the upgrade you might to follow a sequence.

Is there any way to query the versions of the other daemons in the Ceph cluster before running the component?  That is, can we have an OSD container check that the MONs are upgraded before running itself?  Is that even a good or necessary action?
The order appears to be fairly simple for the actual upgrade, though:

Upgrade each monitor
Upgrade each OSD
Upgrade each other daemon (MDS, RADOSGW)
Upgrade the utilities (rbd,rados,etc.)

The warning is good.  The only problem is that we didn't have tagging before yesterday, so everyone was necessarily using :latest.
The plus side there is that according to Docker Hub, there have only been a couple hundred downloads of ceph/osd, and fewer still ceph/mon.  For all I know, that could just be me (though that is probably not the case).  In any case, there should not be very many clusters affected, if out-of-order upgrading causes issues.  Of course, to those few...  It would be nice if we had a way to issue email notices to container users, but that's not going to happen, I'm afraid.

To check the mon version you can:
ceph daemon mon.$(hostname) version
However this needs to be run inside the container since this talks to the socket.
For OSDs you can:
ceph osd metadata $osd_id

Agree on the few users that might be affected, I don't see any good way to email current users.
I believe we will have to merge that like this :(

In that case, I guess we merge away
On Wed, Mar 4, 2015, 07:57 Leseb<EMAIL_ADDRESS>wrote:

Agree on the few users that might be affected, I don't see any good way to
email current users.
I believe we will have to merge that like this :(
—
Reply to this email directly or view it on GitHub
https://github.com/ceph/ceph-docker/pull/32#issuecomment-77152876.


invalid URL prefix in "undefined" when send non-POST request to location

Hello and thank you for the script!
I have found that when non-POST request comes to a location which is configured to scan POST-Body data, I got following error:
curl --location --request GET 'http://test2.lan/your-location/'

/var/log/nginx/error.log:
2021/12/18 08:06:08 [error] 18966#18966: *52 invalid URL prefix in "undefined", client: <IP_ADDRESS>, server: ipa2.lan, request: "GET /your-location/ HTTP/1.1", host: "ipa2.lan"

The location configuration is:
location /your-location/ {
   set $upstream "http://<IP_ADDRESS>:8099";
   mirror /_scannBodyJNDI;
   proxy_pass $bodyScanned;
}

I suppose this can be fixed by adding conditional to postBodyInspect function in cvs.js:
else if (r.method === 'GET') {return r.variables.upstream};

or
else {return r.variables.upstream};

Or it must be fixed on virtual host configuration level?
What do you think?

Hi - thanks for finding this little bug. It is fixed now.


Transforming due-date

Fixes
#6 - Handling reminders with passed due-dates and notify-offset
#7 - Transform due-date input

Not sure why merging this PR didn't close the linked issues #6 and #7


MAPEXPORT

https://forum.dynamobim.com/t/exporting-object-data-to-sdf-shp/44134

Not going to have time for this.


refactor: replace minimist with commander

synp has commander as its own dep
CLI hints

:tada: This issue has been resolved in version 4.0.0 :tada:
The release is available on:

v4.0.0
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New modules;)

I've created few modules such as NumberConverter, DuplicatesEliminator and Inverter

This branch has no conflicts with the base branch
Merging can be performed automatically.


[Performance] Tracking script API responses slow in newer releases

I just updated to the latest release (hash: 241156d9eee9f029e4940ed0e6892e538afe6f62) and noticed that my web app where I've added the Umami tracking script has considerably slowed down. A quick look at the Networking tab in Chrome reveals that the requests made by the tracking script to https://mywebsite.com/api/collect now takes around 4-5 seconds to receive a response instead of milliseconds it used to take before.
To test this, I rolled back to a previous commit (hash: 418a24deb762b95ace7d6f963a811d925ea9aee3) without touching any other server or database settings. The requests immediately sped up and response times changed to less than 100ms.
Sharing some screenshots below of the requests made from the same page on my web app before and after switching to the older release.
New release:

Old release:

I need more details. What database are you using, where are you hosting, etc.

Sorry for the missing details!
Database
1 GB RAM, 1 vCPU, 40 GB SSD
PostgreSQL database (12.3)
Amazon Lightsail
Node.js server
2 GB RAM, 1 vCPU, 60 GB SSD
Ubuntu
Amazon Lightsail

Only major thing that changed was the upgrade to prisma. You can try this, add LOG_QUERY=1 to you .env file and run in dev mode. It should print out the queries and how long they are taking.

Closing this one. Track in #263


Missing YouTube from inputs

Just installed this and noticed that all the apps and inputs from my TV show up in the “Rolodex” view on the home app except for YouTube. I’ve been unable to find a way to manually add it to the list.

I would guess that you reached the  limit and no more inputs cannot be added, you can check that out in the homebridge debug log to confirm it. You would need to remove an app from your tv so that YouTube will fit.

I would guess that you reached the  limit and no more inputs cannot be added, you can check that out in the homebridge debug log to confirm it. You would need to remove an app from your tv so that YouTube will fit.

Thanks.


Long-press on e-mail address -> menu (copy address / new e-mail)

When you want to work on with an e-mail address (sender, CC, BCC), it is quite difficult to extract the address first. For example you want to forward somebody the sender's e-mail address ("Can you send me the address of ...?") or create a new (clean) mail to the guy with the CC address.
It would be great, to be able to open a small menu after a long-press on an e-mail address. The menu should contain the items: 1. "Add to contacts" (or "Open contact" when already added to contacts), 2. "Copy to clipobard", 3. "Start new e-mail" (to this address). This behaviour is known for example from the AOSP contact app. A long-press on an address asks you to copy to clipboard, too.
There is workaround I use, but it is rather complicated: options menu of an e-mail, "Show headers" and then you can copy parts of the mail header like normal text.
Sincerely
Spectas
PS: I played a bit with Gimp to show a bit, how this could look like:

There's been lots of suggestions in this area. It all boils down to the same thing - what we have is not intuitive / consistent / feature complete.
See #1120 #1070
I think we want to design it properly. I'm going to leave this open, but we should consider it as part of a design overhaul rather than making changes when tapping on a specific bit.

Closing this in favor of #6181.


Need complex imagegeometry/acquisition geometry

The complex geometries are related to Fourier Transform

what do you mean with complex geometries?

when doing z = FourierTransform.direct(x) then x belongs to a real ImageGeometry but  z belongs to a complex acquisition geometry, e.g., z = a + ib

Then what's relevant is to be able to specify the type of the array we are allocating.
Currently

DataContainer do not allocate the data array by themselves but expect to be passed an array. The array type is irrelevant.
AcquisitionData and ImageData allocate only numpy.float32

I suggest we add a field in the geometries to specify the data type and allow the ImageData and AcquisitionData to use the keyword argument dtype.

We would need to make sure that DataContainers with complex numbers behave correctly. For example norms and inner products must be defined for complex vectors, see e.g.,
https://mathcs.clarku.edu/~ma130/inner2.pdf
There could be different ways of doing this. If there's a field in the datacontainer to specify the datatype, then the norm method and functionals such as squared two-norm needs to check the data type and if complex use the complex norm computation. Altenatively always use the complex norm computation (which in case of reals simplifies to the real norm), but this does unnecessary complex conjugation of a real number.  Another option could be to have a ComplexImageData say, for which norms etc would be defined to be complex, so could skip checking whether real or complex. But this may lead to other complications.

Just checked that numpy doesn't do anything on conjugate if data is not complex:
import numpy as np

b = np.zeros((10,) , dtype=np.float32)
>>> c = b.conjugate()
>>> id(c)
139843906666048
>>> id (b)
139843906666048

For this reason I'd always use the complex norm computation.

OK that sounds good. There still might be a small overhead to check the
data type in calling conjugate but it is probably not much.
On Sat, 28 Mar 2020 at 23:21, Edoardo Pasca<EMAIL_ADDRESS>wrote:

Just checked that numpy doesn't do anything on conjugate if data is not
complex:
import numpy as np
b = np.zeros((10,) , dtype=np.float32)>>> c = b.conjugate()>>> id(c)139843906666048>>> id (b)139843906666048
For this reason I'd always use the complex norm computation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vais-ral/CCPi-Framework/issues/522#issuecomment-605527272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMDSCAL3KE5G2LOLH6EQM3RJZZ6VANCNFSM4LU7OUAA
.

Apparently norm, squared_norm are already  taking care of complex data.
However, dot isn't doing it by itself. I think it'd be better if dot takes care of the complex data rather than norm.

Agreed, having dot apply the conjugate instead of norm and squared_norm is
better.  So when doing x.dot(y) I would expect the conjugate to be applied
to y, not x, as the conjugate goes on the second argument according to the
document I posted in a previous comment (as well as e.g. wikipedia's
article on dot product for complex)
On Mon, 30 Mar 2020 at 13:19, Edoardo Pasca<EMAIL_ADDRESS>wrote:

Apparently norm, squared_norm are already
https://github.com/vais-ral/CCPi-Framework/blob/e2043267253091df3f05dc5814c464d1a2c179ce/Wrappers/Python/ccpi/framework/framework.py#L972
taking care of complex data.
However, dot
https://github.com/vais-ral/CCPi-Framework/blob/e2043267253091df3f05dc5814c464d1a2c179ce/Wrappers/Python/ccpi/framework/framework.py#L989
isn't doing it by itself. I think it'd be better if dot takes care of the
complex data rather than norm.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/vais-ral/CCPi-Framework/issues/522#issuecomment-605940463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMDSCCILC32NW5NQNCDAATRKB54JANCNFSM4LU7OUAA
.


Don't explode if user doesn't include "enabled" attribute when creating a rule

I personally couldn't reproduce it since we set a default value in the RuleAPI jsonschema, so the default value (True) should be used.
In any case I pushed a change so we now follow the same pattern as we do for actions.

default to false is safer?

It depends on what behavior we want.
We default to True for other resources (e.g. action) and we already default to True in jsonschema so if nothing else it's consistent.

I feel it is safer to have rules disabled by default unless explicitly specified since rules lead to executions. Given the "active" nature of rule I am comfortable if we keep this behavior inconsistent with rest of the content.

+1

I'm fine with that, but I will just note it as a minor backward incompatible changes in the changelog.

Changed the default "enabled" behavior and added a test case for it.

I am late to the party but I am -2 on "disable" by default.
This is confusing: user creates a rule (min typing, get example from somewhere), st2 rule create myrule.yaml, obviously doesn't read through the returned data, and than wonders why the rule doesn't work. Especially if actions, etc, still work.
We already have safe-guards of not loading the rules. it may be enough.
If we want it safe, fine, let's give up "default" and make it required parameter. And just be sure that it's 400.

Yeah, I should have waited a bit longer for more feedback.
I personally agree with @dzimine (other safeguards like not registering rules by default should be enough).
I'm also fine with making the attribute required without a default value, but then we should be consistent and do it for all the pack resources, imo.


Builder Column Listing not returning correct columns for Postgres

Laravel Version: 5.4.27

PHP Version: 7.1.3

Database Driver & Version: Postgres

Description:
When you call getColumnListing against a postgres environment that has multiple schemas and the table you are looking for exists in multiple schemas, the return value will be columns from that table in all schemas. When trying to get the list of columns, the more appropriate response would be for the current schema that we are connected to.
Steps To Reproduce:
Create a new postgres database
create two schemas and set them up in you config/database.php file. For this I am calling them schema1 and schema2.
in the first schema, use the following
CREATE TABLE schema1.test_table(
  first_column INTEGER
)

and in the second schema use the following
CREATE TABLE schema2.test_table(
  second_column INTEGER
)

Now call (in tinker)
Schema::connection('schema1')->getColumnListing('test_table')

and you will get back ['first_column', 'second_column'] as the return value which is incorrect.
Proposed Solution:
I am not sure if this introduces any other bugs, so I am not ready to put it in a pull request yet, but the solution that works for this particular bug is this.
In Builder.php, the method getColumnListing should be modified to the following:
    /**
     * Get the column listing for a given table.
     *
     * @param  string  $table
     * @return array
     */
    public function getColumnListing($table)
    {
        $table = $this->connection->getTablePrefix().$table;

        $search_path = $this->connection->getDoctrineSchemaManager()->getSchemaSearchPaths()[0];

        $results = $this->connection->select($this->grammar->compileColumnListing($table, $search_path));

        return $this->connection->getPostProcessor()->processColumnListing($results);
    }

In this modification, we add the search path to the compileColumnListing method. In php7, this won't have any effect on a method that only has 1 argument.
Next, in PostgresGrammar class, we modify the method compileColumnListing
    /**
     * Compile the query to determine the list of columns.
     *
     * @param  string  $table
     * @param  string  $schema
     * @return string
     */
    public function compileColumnListing($table, $schema = null)
    {
        return "select column_name from information_schema.columns where table_name = '$table' and table_schema='$schema'";
    }

Here we simply add the new $schema param and modify the query to also filter results with the table_schema column.
I haven't tested this fix on php5 so I dont know if overloading like this will break that, but in php7 at the very least, mysql and sqlite both still work with the modified Builder class.
I also suspect that MSSql has the same bug, but I haven't tested that yet either.

Its better that you do a PR.

@srmklive done. again though I am not sure if this introduces any other bugs. I ran phpunit before and after the changes. on php7 it works just fine so hopefully thats a good indication, but hopefully the pr gets a little more discussion on it.


Python API doesn't support TOML

Describe the bug
C/C++ supports parsing TOML files as a HELICS function, Python (and perhaps other bindings)
What is the expected behavior?
All supported language bindings support parsing both JSON and TOML.

The function helicsCreateXXXXFromJSON will actual read TOML files just fine.  This has been fixed in 2.0 but hasn't been renamed in 1.X.X to maintain compatibility.
The 1.3.2 adds a helicsFederateRegisterInterface(fed, file)  this will read json or toml.

Ah, so not a problem after all (other than the naming).


⚠ Bofrost.de has degraded performance

In 21fac89, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 882 ms

Resolved: Bofrost.de performance has improved in f5202c0 after 2 hours, 13 minutes.


Cluster won't create using "Rancher created VPC and Subnet" option for EKS

Rancher versions: 2.0 master 8/2
Steps to Reproduce:

Create a EKS cluster with  Rancher created VPC and Subnet selected for VPC & Subnet option
Create cluster

Results:  The VPC & Security Group are not posted by UI or returned in API.  The Cluster won't create saying "Error parsing state: virtual network, subnet, and security group must all be set together"

Version - 2.2 master 4/15
Verified this is working.


nice work man! what does this line mean XD

:beer:
    public var animations = [Animatable]()

Thanks! That's just creating an array that can hold anything that conforms to the Animatable protocol. That means it's something we can call animate(time) on. Basically, it's an array that can hold any type of animation that will be animated together.

thx!  so this part [Animatable]  means somthing conforms to protocol!
and () create the array?


Show stats of IP in cli and get a free ip to reserve

Description
Is there any script or tool in cli to see the stats of an IP or get a free IP from networks to reserve?
Use case
It could help admins to see the stat of IP faster. For example if i want to see the stats of an IP

If it is used in VM directly and which host
If it is reserved on which mac address
If it is not reserved and it is not on VM directly but it is on a device
If it is free and i can reserve it
etc

Interface Changes
I write an simple bash script for this purpose

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

This was finally contributed to https://github.com/tinova/one-tools. Thanks!


ETCD cleanup & storing results on custom storage

the following should be done :

[ ] clean results from etcd
[ ] add new methods for get/set results to storage adapter
[ ] add new key with the name "result" to the storage adapter new methods


[bug]: a height hint greater than 0 must be provided

Background
lnd refuses to start, complainding about hint must be greater than 0
Your environment

version of lnd
lnd version 0.17.3-beta commit=v0.17.3-beta

which operating system (uname -a on *Nix)

Linux lndmain 4.4.0-206-generic #238-Ubuntu SMP Tue Mar 16 07:52:37 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

version of btcd, bitcoind, or other backend

Bitcoin Core version v25.0.0

any other relevant environment details

Steps to reproduce
start lnd.
having the same issue on two lnd nodes (with different transactions)
also tried
lnd  --height-hint-cache-query-disable
2024-01-13 09:54:44.129 [ERR] BTCN: Broadcast attempt failed: tx already confirmed: -27: Transaction already in block chain
2024-01-13 09:54:44.130 [INF] LNWL: Inserting unconfirmed transaction 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00
2024-01-13 09:54:44.291 [INF] LNWL: 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00: tx already confirmed
2024-01-13 09:54:44.450 [ERR] UTXN: Failed to sweep first-stage HTLC (CLTV-delayed) output 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00:0
2024-01-13 09:54:44.451 [ERR] UTXN: Failed to sweep outputs at height=0: a height hint greater than 0 must be provided
2024-01-13 09:54:44.451 [INF] SWPR: Sweeper shutting down
2024-01-13 09:54:44.451 [INF] NTFN: Cancelling epoch notification, epoch_id=2
2024-01-13 09:54:44.451 [INF] NTFN: New confirmation subscription: conf_id=1, txid=62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00, num_confs=6 height_hint=825608
2024-01-13 09:54:44.451 [INF] HSWC: HtlcNotifier shutting down
2024-01-13 09:54:44.451 [INF] PRNF: PeerNotifier shutting down
2024-01-13 09:54:44.451 [INF] CHNF: ChannelNotifier shutting down
2024-01-13 09:54:44.451 [INF] NTFN: bitcoind notifier shutting down
2024-01-13 09:54:45.441 [INF] NTFN: Dispatching 6 confirmation notification for txid=62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00
2024-01-13 09:54:45.442 [INF] NTFN: Stopping mempool notifier
2024-01-13 09:54:45.442 [INF] HLCK: Health monitor shutting down
2024-01-13 09:54:45.442 [ERR] LTND: Shutting down because error in main method: unable to start server: a height hint greater than 0 must be provided

Expected behaviour
lnd should start
Actual behaviour
does not start

So removing the height hint cache as is, means we won't have a height hint to pass, but other sub-systems want to verify that it's present (as they need to know the last point of something being unspent/unconfirmed).
Are you able to start if you unset the arg? Or did you run into this issue then try to set the arg? Had you set the arg before?
Might the node have had other patches applied? It's odd that the nursery is trying to sweep something at height zero. Is the chain backend syncing from scratch in the background? More UTXN logs a the debug log level can help here as well.

So removing the height hint cache as is, means we won't have a height hint to pass, but other sub-systems want to verify that it's present (as they need to know the last point of something being unspent/unconfirmed).
Are you able to start if you unset the arg? Or did you run into this issue then try to set the arg? Had you set the arg before?

i got the problems on the nodes first, then got a tip to set the flag. never used nor seen that flag before.

Might the node have had other patches applied?

one of the nodes have had several patches before, but not for years. the other node i think never had any patches.

It's odd that the nursery is trying to sweep something at height zero.

especially when they are already swept and confirmed

Is the chain backend syncing from scratch in the background? More UTXN logs a the debug log level can help here as well.

don't think it syncs from scratch, i think i would have noticed.

added
debuglevel=UTXN=trace

but don't see much UTXN stuff yet.
2024-02-01 18:36:52.399 [INF] LTND: Waiting for chain backend to finish sync, start_height=828418

seems it does not start at 0 though

2024-02-01 18:33:31.899 [INF] LTND: Version: 0.17.3-beta commit=v0.17.3-beta, build=production, logging=default, debuglevel=UTXN=trace
2024-02-01 20:04:17.393 [INF] UTXN: UTXO nursery starting
2024-02-01 20:04:19.475 [INF] UTXN: (Re)-sweeping 1 heights below height=828430
2024-02-01 20:04:19.475 [DBG] UTXN: Attempting to sweep outputs at height=0
2024-02-01 20:04:19.476 [INF] UTXN: Attempting to graduate height=0: num_kids=0, num_babies=23
2024-02-01 20:04:19.476 [INF] UTXN: Publishing CLTV-delayed HTLC output using timeout tx (txid=62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00): (*wire.MsgTx)(0xc001469180)({
2024-02-01 20:04:19.952 [ERR] UTXN: Failed to sweep first-stage HTLC (CLTV-delayed) output 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00:0
2024-02-01 20:04:19.952 [ERR] UTXN: Failed to sweep outputs at height=0: a height hint greater than 0 must be provided

there is all UTXN from one session with debuglevel=UTXN=trace , hope it helps. any more settings i can try?

tried with 0.17.4, basically no change
after two hours it tried again to reinsert an already confirmed transaction and stopped the startup process complaining about height hint not greater than 0
would be happy if i could either submit that hint manually, or if the code could decide it is better to continue than stop
still same issue with two nodes with 0.17.4
2024-02-28 18:03:07.221 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>08007936 occurred
2024-02-28 18:03:07.221 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>08007936 occurred
2024-02-28 18:03:07.221 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>08007936 occurred
2024-02-28 18:03:07.221 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>08007936 occurred
2024-02-28 18:03:07.221 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>08007936 occurred
2024-02-28 18:03:07.315 [INF] LTND: Channel backup proxy channel notifier starting
2024-02-28 18:03:07.316 [INF] ATPL: Instantiating autopilot with active=false, max_channels=5, allocation=0.600000, min_chan_size=20000, max_chan_size=16777215, private=false, min_confs=1, conf_target=3
2024-02-28 18:03:07.316 [INF] LTND: We're not running within systemd or the service type is not 'notify'
2024-02-28 18:03:08.131 [INF] LTND: Waiting for chain backend to finish sync, start_height=832432
2024-02-28 18:35:57.773 [INF] LNWL: Catching up block hashes to height 830000, this might take a while
2024-02-28 18:35:57.774 [INF] LNWL: Done catching up block hashes
2024-02-28 18:35:57.774 [INF] LNWL: Rescanned through block<PHONE_NUMBER>00000000011d55599ed27d7efca05f5849b755319c89eb2cffbc1f (height 830000)
2024-02-28 19:29:31.767 [INF] LNWL: Catching up block hashes to height 832438, this might take a while
2024-02-28 19:29:31.768 [INF] LNWL: Done catching up block hashes
2024-02-28 19:29:31.768 [INF] LNWL: Finished rescan for 113822 addresses (synced to block<PHONE_NUMBER>000000000321834d8bb9f62e1b74c971ad3621223799459330098d, height 832438)
2024-02-28 19:29:33.807 [INF] LTND: Chain backend is fully synced (end_height=832438)!
2024-02-28 19:29:33.808 [WRN] HLCK: check: disk space configured with 0 attempts, skipping it
2024-02-28 19:29:33.809 [WRN] HLCK: check: tls configured with 0 attempts, skipping it
2024-02-28 19:29:33.809 [INF] LNWL: SigPool starting
2024-02-28 19:29:34.304 [INF] LNWL: 6e12001da5af8dae817eee0928c8c9d1be2a67a6a6be02769af9676c32c5b188: tx already confirmed
2024-02-28 19:29:35.711 [INF] CHNF: ChannelNotifier starting
2024-02-28 19:29:35.711 [INF] PRNF: PeerNotifier starting
2024-02-28 19:29:35.711 [INF] NTFN: New block epoch subscription
2024-02-28 19:29:35.711 [INF] BTCN: Broadcaster now active
2024-02-28 19:29:35.711 [INF] HSWC: HtlcNotifier starting
2024-02-28 19:29:35.711 [INF] SWPR: Sweeper starting
2024-02-28 19:29:35.861 [INF] UTXN: UTXO nursery starting
2024-02-28 19:29:35.861 [INF] NTFN: New block epoch subscription
2024-02-28 19:29:37.623 [INF] UTXN: (Re)-sweeping 1 heights below height=832438
2024-02-28 19:29:37.623 [DBG] UTXN: Attempting to sweep outputs at height=0
2024-02-28 19:29:37.623 [INF] UTXN: Attempting to graduate height=0: num_kids=0, num_babies=23
2024-02-28 19:29:37.623 [INF] UTXN: Publishing CLTV-delayed HTLC output using timeout tx (txid=62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00): (*wire.MsgTx)(0xc008e8fec0)({
 Version: (int32) 2,
 TxIn: ([]*wire.TxIn) (len=1 cap=1) {
  (*wire.TxIn)(0xc000a98cc0)({
   PreviousOutPoint: (wire.OutPoint) 81e84010f3eb56e10eb808b00711c46cf1a96368015f83a21223c979c7b846f9:1,
   SignatureScript: ([]uint8) {
   },
   Witness: (wire.TxWitness) (len=5 cap=5) {
    ([]uint8) {
    },
    ([]uint8) (len=72 cap=72) {
     00000000  30 45 02 21 00 87 d8 f4  39 83 5a 5d 71 46 17 fb  |0E.!....9.Z]qF..|
     00000010  b4 c1 5b aa fd 91 89 9d  5c 30 82 fe 58 61 94 6c  |..[.....\0..Xa.l|
     00000020  dd 58 af b3 38 02 20 19  33 74 07 a1 b8 c8 6d 43  |.X..8. .3t....mC|
     00000030  a1 49 24 e9 a0 08 8e 4e  d7 e0 94 de d3 99 e6 40  |.I$....N.......@|
     00000040  67 98 f4 92 43 27 92 01                           |g...C'..|
    },
    ([]uint8) (len=71 cap=71) {
     00000000  30 44 02 20 0d b3 01 32  c5 c3 b9 97 a2 bd 66 a1  |0D. ...2......f.|
     00000010  aa c5 2a 55 6a 42 1f 2d  30 4d 6f 51 0a 66 b6 d7  |..*UjB.-0MoQ.f..|
     00000020  0d ae 4d 57 02 20 44 d0  f9 62 38 81 f2 8d be f4  |..MW. D..b8.....|
     00000030  57 48 7e 0a 36 dd 7f 0c  30 fb c9 1c a4 9e ba 25  |WH~.6...0......%|
     00000040  64 25 04 7b 4d 39 01                              |d%.{M9.|
    },
    ([]uint8) {
    },
    ([]uint8) (len=133 cap=133) {
     00000000  76 a9 14 69 d9 29 69 40  47 52 24 bd 20 64 c3 52  |v..i.)i@GR$. d.R|
     00000010  10 f7 44 08 b5 18 72 87  63 ac 67 21 03 41 0a f5  |..D...r.c.g!.A..|
     00000020  bb e6 aa b1 37 6b 79 26  df 99 3d 7f 8d a7 6f 39  |....7ky&..=...o9|
     00000030  90 4c 1c 21 02 59 fe 61  72 72 6c 66 4c 7c 82 01  |.L.!.Y.arrlfL|..|
     00000040  20 87 64 75 52 7c 21 02  9c 84 44 ae a5 0f 39 df  | .duR|!...D...9.|
     00000050  08 19 f6 99 d9 72 36 ee  b5 53 ab c6 e8 8d a6 32  |.....r6..S.....2|
     00000060  5f 0e 2d 14 4a 1a 0f 3b  52 ae 67 a9 14 b9 33 f0  |_.-.J..;R.g...3.|
     00000070  45 99 7c 8c 49 52 af 17  92 c8 a4 bd 01 5a 29 be  |E.|.IR.......Z).|
     00000080  c4 88 ac 68 68                                    |...hh|
    }
   },
   Sequence: (uint32) 0
  })
 },
 TxOut: ([]*wire.TxOut) (len=1 cap=1) {
  (*wire.TxOut)(0xc008e4b640)({
   Value: (int64) 15072,
   PkScript: ([]uint8) (len=34 cap=34) {
    00000000  00 20 e2 f3 5d 12 f8 c8  d0 14 cd bb ab 65 65 c8  |. ..]........ee.|
    00000010  12 05 67 e2 aa bd eb 89  ef 05 bb c7 9e 89 e9 d5  |..g.............|
    00000020  1e 9d                                             |..|
   }
  })
 },
 LockTime: (uint32) 0
})

2024-02-28 19:29:37.775 [ERR] BTCN: Broadcast attempt failed: tx already confirmed: -27: Transaction already in block chain
2024-02-28 19:29:37.775 [INF] LNWL: Inserting unconfirmed transaction 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00
2024-02-28 19:29:37.930 [INF] LNWL: 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00: tx already confirmed
2024-02-28 19:29:38.080 [ERR] UTXN: Failed to sweep first-stage HTLC (CLTV-delayed) output 62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00:0
2024-02-28 19:29:38.080 [ERR] UTXN: Failed to sweep outputs at height=0: a height hint greater than 0 must be provided
2024-02-28 19:29:38.080 [INF] SWPR: Sweeper shutting down
2024-02-28 19:29:38.081 [INF] NTFN: Cancelling epoch notification, epoch_id=2
2024-02-28 19:29:38.081 [INF] NTFN: New confirmation subscription: conf_id=1, txid=62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00, num_confs=6 height_hint=832438
2024-02-28 19:29:38.081 [INF] HSWC: HtlcNotifier shutting down
2024-02-28 19:29:38.081 [INF] PRNF: PeerNotifier shutting down
2024-02-28 19:29:38.081 [INF] CHNF: ChannelNotifier shutting down
2024-02-28 19:29:38.081 [INF] NTFN: bitcoind notifier shutting down
2024-02-28 19:29:39.096 [INF] NTFN: Dispatching 6 confirmation notification for txid=62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00
2024-02-28 19:29:39.096 [INF] NTFN: Stopping mempool notifier
2024-02-28 19:29:39.096 [INF] HLCK: Health monitor shutting down
2024-02-28 19:29:39.096 [ERR] LTND: Shutting down because error in main method: unable to start server: a height hint greater than 0 must be provided
2024-02-28 19:29:39.096 [INF] RPCS: Stopping RPC Server
2024-02-28 19:29:39.096 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2024-02-28 19:29:39.096 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2024-02-28 19:29:39.096 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2024-02-28 19:29:39.112 [INF] LTND: Shutdown complete

unable to start server: a height hint greater than 0 must be provided

Very strange behavior, was the channel a LND <=> LND channel ?

Can you run the patch: https://github.com/lightningnetwork/lnd/pull/8524
This PR just prints out the HTLC information of all the pending HTLCs which need to be spent by the UTXO_Nursery. Analysing the transaction which causes the height hint to be 0 brought my attention to the fact that all the locktimes of the Second-Level Timeout transactions are 0, although they should only be 0 for the Success-Transaction:
https://mempool.space/tx/62ff2f1f063082090be8aecd42bba5ae29b4b1b1a00e1f13806b9d99f8087e00
This is a timeout transaction which has the expiry of 0, which normally should not happen. By running the patch we can get more information of the htlc which is written to your db.

Very strange behavior, was the channel a LND <=> LND channel ?

the channels on both nodes seems to be to LND.

@ziggie1984 i tried your patch and guess you want this part:
2024-03-10 15:34:20.111 [INF] UTXN: UTXO nursery starting
2024-03-10 15:34:20.111 [INF] NTFN: New block epoch subscription
2024-03-10 15:34:20.442 [INF] UTXN: (Re)-sweeping 1 heights below height=834066
2024-03-10 15:34:20.442 [DBG] UTXN: Attempting to sweep outputs at height=0
2024-03-10 15:34:20.442 [INF] UTXN: Attempting to graduate height=0: num_kids=0, num_babies=4
2024-03-10 15:34:20.442 [DBG] UTXN: Crib output: babyOutput: expiry=0, timeoutTx=020000000001019c3d3bb647290174b822ff5a92ab60624a0945d96f61a0ab8fd56dfcdffd8e7502000000000000000001351701000000000022002094fd5b3395c57a37104d49af026868c950bb9052211d803fa560d1af9c154eb10500473044022009a134c2d405b66761a2446b53b0c0757fd3266432795c04f41e2c731b2f587202201e8a1fa63ff1372ef62effd47617143a52d854f6fa576169e0cc3e9e7300f4ff0147304402201324ccc13fec7ab900dcc4855825ac38b51f0609d880355ad42b4f44fa4d34fd0220271666dcf8c1ca70e9e82a2de583d7ad6342fd26dd9367267c303ee0bd46044101008576a914151f84cfe9ae31e279b2e35de4d77fdf1aeda77a8763ac672102b950360c6260bde44391a4e01178d0060b6def2ed2c02e956d9d70ef133124d57c820120876475527c2102cc01696b3eb22d453a0aa0788b2cff738996ea5c554287136cfc321290c1fac152ae67a9149934b68fc95bea23d23fe0305b522810e568e63d88ac686800000000, kidOutput=kidOutput: blocksToMaturity=144, absoluteMaturity=0, breachedOutput=breachedOutput: witnessType=HtlcOfferedTimeoutSecondLevel, amt=71477, outpoint=da2bffef57fd0ea5520d6cc2b53905cdf56735d702b65dd462f025c58f92490f:0, confHeight=0
2024-03-10 15:34:20.442 [DBG] UTXN: Crib output: babyOutput: expiry=0, timeoutTx=020000000001019c3d3bb647290174b822ff5a92ab60624a0945d96f61a0ab8fd56dfcdffd8e7501000000000000000001eeb200000000000022002094fd5b3395c57a37104d49af026868c950bb9052211d803fa560d1af9c154eb105004830450221008acfebdafe1d64a7eb4789750e6306839a79f2f889517e1beead4d81337371620220758af7d20b9a2094a96a500d36b71b8a4c0dbeb9acf3815c7a947084611096760147304402203fac722814e9558329da224a5c6b10b8ec44ab9a427b540e96e31c11aa2831020220739d8dd1a0add2be831e38f750b15773ff23b887dba7c2a3b22b5058b309175601008576a914151f84cfe9ae31e279b2e35de4d77fdf1aeda77a8763ac672102b950360c6260bde44391a4e01178d0060b6def2ed2c02e956d9d70ef133124d57c820120876475527c2102cc01696b3eb22d453a0aa0788b2cff738996ea5c554287136cfc321290c1fac152ae67a914cb40a044188223e80851165ba62800e341d9cd2588ac686800000000, kidOutput=kidOutput: blocksToMaturity=144, absoluteMaturity=0, breachedOutput=breachedOutput: witnessType=HtlcOfferedTimeoutSecondLevel, amt=45806, outpoint=92087dff6457c5349cd77c39a1f5be4fcd32f8c1b514f3411920ab5339430e29:0, confHeight=0
2024-03-10 15:34:20.443 [DBG] UTXN: Crib output: babyOutput: expiry=0, timeoutTx=020000000001019c3d3bb647290174b822ff5a92ab60624a0945d96f61a0ab8fd56dfcdffd8e7500000000000000000001cb7f00000000000022002094fd5b3395c57a37104d49af026868c950bb9052211d803fa560d1af9c154eb1050047304402203f64dd6000402eaba18ddf2472aa781cd5ce73ea30162417272ba1f9ee3e361b022053b624d75e48c3cc20232a74401b8728ea036f226e0526ed4a0147ecfaaf710601483045022100ff25b4622dd52d1e06c4f3849db1ee57be491456a4d682dede78671562b70d2d022050b6aabd78fa941568214f68ca9266e10f55c8382099a74212d97debc978db5001008576a914151f84cfe9ae31e279b2e35de4d77fdf1aeda77a8763ac672102b950360c6260bde44391a4e01178d0060b6def2ed2c02e956d9d70ef133124d57c820120876475527c2102cc01696b3eb22d453a0aa0788b2cff738996ea5c554287136cfc321290c1fac152ae67a91432d82dbe64484894960f83a16c149c239f26a01588ac686800000000, kidOutput=kidOutput: blocksToMaturity=144, absoluteMaturity=0, breachedOutput=breachedOutput: witnessType=HtlcOfferedTimeoutSecondLevel, amt=32715, outpoint=7970f5660fa5af13d1678976f66efb5958194102978842206d6b4dbd2ac2b7bd:0, confHeight=0
2024-03-10 15:34:20.443 [DBG] UTXN: Crib output: babyOutput: expiry=0, timeoutTx=020000000001019c3d3bb647290174b822ff5a92ab60624a0945d96f61a0ab8fd56dfcdffd8e7503000000000000000001361701000000000022002094fd5b3395c57a37104d49af026868c950bb9052211d803fa560d1af9c154eb105004830450221008b96bb27827efec62dd3496f51fa60fa6242bc68ab1a944f189b28cae9cf9a6d02206e25e3026e31cb0f1fef75572a3bd186128c1390786725b2c7a4bc6f6d3b840b0148304502210090247d7e91179f487c74176cf33c9f42efd38c0f68689e5ca5685e78b9eae78602207a3ae49d160fe3d08dbf8bb9658c12e568ceda20583f93ef69c6a9cfe9ea0e1a01008576a914151f84cfe9ae31e279b2e35de4d77fdf1aeda77a8763ac672102b950360c6260bde44391a4e01178d0060b6def2ed2c02e956d9d70ef133124d57c820120876475527c2102cc01696b3eb22d453a0aa0788b2cff738996ea5c554287136cfc321290c1fac152ae67a9143b788e941926604a7221e437124a584280be12a188ac686800000000, kidOutput=kidOutput: blocksToMaturity=144, absoluteMaturity=0, breachedOutput=breachedOutput: witnessType=HtlcOfferedTimeoutSecondLevel, amt=71478, outpoint=1e2c311bee786a57fde8594ffe151e4134c2dd2a6175954105f522d96032b8f7:0, confHeight=0
2024-03-10 15:34:20.443 [INF] UTXN: Publishing CLTV-delayed HTLC output using timeout tx (txid=da2bffef57fd0ea5520d6cc2b53905cdf56735d702b65dd462f025c58f92490f): (*wire.MsgTx)(0xc001f1fd40)({
 Version: (int32) 2,
 TxIn: ([]*wire.TxIn) (len=1 cap=1) {
  (*wire.TxIn)(0xc000cc87e0)({
   PreviousOutPoint: (wire.OutPoint) 758efddffc6dd58faba0616fd945094a6260ab925aff22b874012947b63b3d9c:2,
   SignatureScript: ([]uint8) {
   },
   Witness: (wire.TxWitness) (len=5 cap=5) {
    ([]uint8) {
    },
    ([]uint8) (len=71 cap=71) {
     00000000  30 44 02 20 09 a1 34 c2  d4 05 b6 67 61 a2 44 6b  |0D. ..4....ga.Dk|
     00000010  53 b0 c0 75 7f d3 26 64  32 79 5c 04 f4 1e 2c 73  |S..u..&d2y\...,s|
     00000020  1b 2f 58 72 02 20 1e 8a  1f a6 3f f1 37 2e f6 2e  |./Xr. ....?.7...|
     00000030  ff d4 76 17 14 3a 52 d8  54 f6 fa 57 61 69 e0 cc  |..v..:R.T..Wai..|
     00000040  3e 9e 73 00 f4 ff 01                              |>.s....|
    },
    ([]uint8) (len=71 cap=71) {
     00000000  30 44 02 20 13 24 cc c1  3f ec 7a b9 00 dc c4 85  |0D. .$..?.z.....|
     00000010  58 25 ac 38 b5 1f 06 09  d8 80 35 5a d4 2b 4f 44  |X%.8......5Z.+OD|
     00000020  fa 4d 34 fd 02 20 27 16  66 dc f8 c1 ca 70 e9 e8  |.M4.. '.f....p..|
     00000030  2a 2d e5 83 d7 ad 63 42  fd 26 dd 93 67 26 7c 30  |*-....cB.&..g&|0|
     00000040  3e e0 bd 46 04 41 01                              |>..F.A.|
    },
    ([]uint8) {
    },
    ([]uint8) (len=133 cap=133) {
     00000000  76 a9 14 15 1f 84 cf e9  ae 31 e2 79 b2 e3 5d e4  |v........1.y..].|
     00000010  d7 7f df 1a ed a7 7a 87  63 ac 67 21 02 b9 50 36  |......z.c.g!..P6|
     00000020  0c 62 60 bd e4 43 91 a4  e0 11 78 d0 06 0b 6d ef  |.b`..C....x...m.|
     00000030  2e d2 c0 2e 95 6d 9d 70  ef 13 31 24 d5 7c 82 01  |.....m.p..1$.|..|
     00000040  20 87 64 75 52 7c 21 02  cc 01 69 6b 3e b2 2d 45  | .duR|!...ik>.-E|
     00000050  3a 0a a0 78 8b 2c ff 73  89 96 ea 5c 55 42 87 13  |:..x.,.s...\UB..|
     00000060  6c fc 32 12 90 c1 fa c1  52 ae 67 a9 14 99 34 b6  |l.2.....R.g...4.|
     00000070  8f c9 5b ea 23 d2 3f e0  30 5b 52 28 10 e5 68 e6  |..[.#.?.0[R(..h.|
     00000080  3d 88 ac 68 68                                    |=..hh|
    }
   },
   Sequence: (uint32) 0

So the problem in your case is, that HTLCs where created with a LockTime (expiry) of 0. How that happened I cannot explain so far normally it is guarded by this function:
https://github.com/lightningnetwork/lnd/blob/5cb4811e86ed1607c1c9671756d7276256e2ec44/htlcswitch/link.go#L2816-L2818
Specifically: https://github.com/lightningnetwork/lnd/blob/5cb4811e86ed1607c1c9671756d7276256e2ec44/htlcswitch/link.go#L2910-L2919
where we make sure the htlc timeout is greater than the current height + a delta. So prob. the LND you run when this happened was somewhere in the v0.6-beta to v0.5-beta range. I wonder whether this node ever run successfully after 2019 where the FCs happened?
To sum it up, your case should never happen with LND. I think the best solution for you is to run a patched version to recover your funds and then close the node down. I let you know which patch to run to recover your funds.

So I added a code part into #8524 which now tries to fill in the missing information when the height_hint is zero by querying the bitcoind backend. This will only work with a full node (not pruned bitcoind node). With this change your lnd node should start up fine. make sure that all the relevant channels are fully resolved before switching versions again.
I am not sure about adding this kind of exception into the main code, because from my understanding a height_hint of 0 cannot happen currently because we guard against it as shown above.
Feel free to reach out if you have any questions @robtex

So I think you run lnd-0.5-beta when this problem occured, because there a Outgoing HTLC of 0, would have been allowed:
https://github.com/lightningnetwork/lnd/blob/3b2c807288b1b7f40d609533c1e96a510ac5fa6d/htlcswitch/link.go#L1953-L1965
So maybe a bad implementation of pathfinding caused this, but in the newest versions of LND starting from lnd-0.5.1-beta this should not be a problem anymore.


WARNING: Do not update until this issue is closed.

currently, memory-card has a bug that caused all the data cannot be saved.
See: https://github.com/zixia/memory-card/issues/3

Resolved by https://github.com/zixia/memory-card/issues/3


Import readline

Hello @graniet,
By adding the readline library, it's more pleasant to work with the terminal, example:
Before:

After:

Thanks for your project!

Hello,
thanks @qqwaszx for this pull !


Use with 3rd party images

We'd like this tooling to work well with the .NET images that are shipped an supported by Red Hat.
I just tried setting:
<ContainerBaseImage>registry.access.redhat.com/ubi8/dotnet-70:7.0</ContainerBaseImage>

And I could build an run the resulting image:
$ podman run -ti web:1.0.0
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://[::]:8080
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
      Content root path: /app
^Cinfo: Microsoft.Hosting.Lifetime[0]
      Application is shutting down...
...

Can we capture the expected requirements for a base image in a document?
cc @baronfel @richlander @omajid @aslicerh

Overall I'd love it if RedHat wanted to ship an 'extension' package or something for this tech that modified the base image inference/entrypoint/etc in ways that make sense for your images!

Yes, the goal is to have our images work with this tooling, and make it easy for the user to opt-in to using them.

right now the requirements are as follows:

This is already a good overview to start from.
Can we capture these in a document, and try improve them as we enable the tooling to work with the Red Hat images?

This sounds like an awesome direction. Having this system work well for RH-produced images is a great idea.
Perhaps this is something that Canonical folks would be interested in as well.

The 8.0 tooling works wel with Red Hat images.
The changes we made weren't Red Hat specific, and will improve the SDK for working with other base images too.


Feat/cli with overridable streams

In order to provide a WebCLI, I needed to be able to pass in InputStream and OutputStreams to the CLI, so I could redirect input and output to a WebSocket.
I updated the CLI so when using the "main" it simply initializes the CliContext with System.stdin and System.stdout, but also allows calling a static runCli method where I can pass in a manually constructed CliContext.

Thanks for spotting this ... issue now seems to be solved.

There is one for just the static stuff ... Just for my current work, I need both changes, so I based this PR off the other one.
https://github.com/apache/iotdb/pull/11870

However I think there might be one singleton that I learned too late that it is needed ...

hi @chrisdutz
This change will cause the CLI to not work properly.
For example:
The input statement will be repeatedly output
Unable to auto-complete keywords
Unable to select SQL statement by up and down keys

This is really odd ... as it shouldn't change anything, just instead of using "System.in" and "System.out" you use variables that are initialized with them.
But I'll have a look, if I can spot what's causing this.

But I can confirm, that the code seems to be behaving differently, even if it shouldn't be. I just switched to master, rebuilt and ran the CLI and can see what you were referring to. I'll try to figure out what's causing the difference.

Ok ... was a bit tricky, but in the end I pushed a change that should fix it. There were actually two issues:

I was running the CLI in IntelliJ (not from the console) ... here both version behaved identically (Even when running the CLI from master in IntelliJ directly, it will echo the commands and not have auto-complete).
I was expecting to setting "in" and "out" to System.in and System.out woudln't be any change, but it turns out in this case the internal variables "in" and "out" are not null and the code will take a wrong turn.

I updated the code to simply not set the "streams" if "in == System.in && out == System.out" ... that seemed to have worked.

Hi,
yeah ... it surely doesn't address all singletons, just the ones I needed for my work. Of course adjusting all singletons is the more complete work, but I wanted to change as little as possible.
In general do I think we should completely get rid of any form of static variables for anything but constant definitions.
Currently I would be in strong favor of changing things to compose things using constructors, similar to Spring Constructor Injection, but to manually weave the components together, so we can generally use IoTDB in any form of application, no matter the component framework being used.
However do I know this is a big change and possibly one that could break compatibility with extensions built for older versions, so I think we should do the "resettable statics" first and focus on a more general refactoring later on.


Fix logger

Right now multiple packages configure the logger, they should get the default logger if already initialized and configured instead

This can be closed.


Cannot set properties of undefined (setting 'inTable')

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
remark-gfm 4.0.0
Link to runnable example
No response
Steps to reproduce
With react-markdown
Doing:
<Markdown
  children={`| Type | Count |\n| :- | -: |\n`
      + rows.map(item => `| ${item.join(" | ")} |`).join("\n")}
  />

causes the exception below.
Downgrading to 3.0.1 solves the problem.
Expected behavior
Render the table.
Actual behavior
Uncaught TypeError: Cannot set properties of undefined (setting 'inTable')
    at Object.enterTable (index.js:76:1)
    at compile (index.js:351:1)
    at fromMarkdown (index.js:192:1)
    at parser (index.js:18:1)
    at Function.parse (index.js:262:1)
    at ReactMarkdown (react-markdown.js:104:1)
    at renderWithHooks (react-dom.development.js:14141:1)
    at mountIndeterminateComponent (react-dom.development.js:17432:1)
    at beginWork (react-dom.development.js:18728:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3733:1)

Runtime
Node v17
Package manager
npm 8
OS
macOS
Build and bundle tools
Webpack, Create React App

Duplicate of https://github.com/remarkjs/remark-gfm/issues/57

Please look at the pinned issue before opening a new one.
To reiterate from the existing issue:
A major version release is rolling out across all: mdx, unified, remark, rehype, and micromark packages.
This includes both type changes (static analysis error) and changes to the parser (potential runtime error) if the major versions are mismatched.
Hold on version 3 of remark-gfm, until the next major of react markdown is released


export and import

Description of problem
Most dokku plugins offer a :export and :import feature that can be used to backup and restore to a new server if required.
This plugin does not offer any similar options, it would be a really nice improvement
It seems we have access to data-dir, but it's probably unsafe to rsync it's data while other processes are writing to it.

Does clickhouse have a way to do import/export? Thats what is blocking me from implementing this.

It's a good question, I read https://clickhouse.tech/docs/en/operations/backup/
The best, officially supported option seems to be https://clickhouse.tech/docs/en/operations/utilities/clickhouse-copier/
It's not perfect (not atomic) but should be a good start :)

We don't customize the image. Is that process available in the official clickhouse image?

The 2021 roadmap for ClickHouse contains a "backup" feature. The issue which tracks this feature is https://github.com/ClickHouse/ClickHouse/issues/13953
Once that story is done there will be official backup and restore commands which could be used for "export" and "import".

Okay seems like the backup was implemented. Does anyone have good ideas as to how this might be done on our end? Seems like it has to backup to a directory, but we don't currently mount any backup directories afaik...

My assumption is the same. A folder have to be mounted to expose backups. I will run some tests tomorrow.

We could backup to a file and then maybe cat the contents out?

The type of a disk under storage_configuration can be s3. I have to do some testing to see if backup and restore works with that type.

That might make our existing backup/restore code more difficult to integrate with. I'd rather not deviate from that if possible, as it makes it easier to copy/paste code across plugins.

I had a closer look on https://github.com/AlexAkulov/clickhouse-backup. The functionality which uses BACKUP and RESTORE is referenced as "EmbeddedBackup" in the code. During embedded backup, they build a BACKUP query with all tables. Executing that query will result in a single file. Which can be copied, or as you said outputted with cat.

Backups were implemented in the official image, so does that mean we could implement that here?

Backing up
For anyone who might want to back up the clickhouse to S3, here is how I do it.
COMMANDS=$(cat <<'EOF'
    echo -e '✅ Setting environment variables'
    export CLICKHOUSE_USERNAME=<replace-clikhouse-username>
    export CLICKHOUSE_PASSWORD=<replace-clikhouse-password>
    export REMOTE_STORAGE=s3
    export S3_ACCESS_KEY=<replace-access-key>
    export S3_SECRET_KEY=<repalce-secret-key>
    export S3_BUCKET=<repalce-bucket-name>
    export S3_REGION=us-east-1

    echo "✅ Download clickhouse-backup binaries"
    wget https://github.com/Altinity/clickhouse-backup/releases/download/v2.6.1/clickhouse-backup-linux-amd64.tar.gz
    tar -zxvf clickhouse-backup-linux-amd64.tar.gz
    install -o root -g root -m 0755 build/linux/amd64/clickhouse-backup /usr/local/bin

    echo "✅ Creating and uploading backup"
    BACKUP_NAME=clickhouse-backup-$(date -u +%Y-%m-%dT%H-%M-%S)
    clickhouse-backup create $BACKUP_NAME --rbac --configs
    clickhouse-backup upload $BACKUP_NAME

    echo "✅ Exit shell. Goodbye!"
    exit
EOF
)

dokku clickhouse:enter <clickhouse-instance-name> bash -c "$COMMANDS"

[!NOTE]
clickhouse-backup must be run inside the container.

Restoring
To restore, simply repeat the process but run the following toward the end.
clickhouse-backup restore_remote <replace-with-remote-backup_name>

You can set up cronjob to run once per day. Learn more about Altinity Backup for ClickHouse.


Call to undefined method sweelix\yii2\image\Image::getPath()

On PreviewFile.php you're calling Image::getPath() but that function is not implemented in the Image.php file.
I think, it can be solved by replacing getPath() for getUrl(true).
This is the line
$imageData = file_get_contents($image->getPath()); (+220)

+1


lua53: fix "default-names" option for luarocks

Previously luarocks was installed as luarocks-5.3 and luarocks-admin-5.3
even if the user passed the --with-default-names switch.

Thanks again @telemachus!


please add menu mode to FilterChip

Use case
please add menu mode to FilterChip
Proposal
https://github.com/flutter/flutter/assets/64336442/20c979b1-b90c-40c6-acc1-fe5b65962d8a

Closing as duplicate of https://github.com/flutter/flutter/issues/108683


Performance Testing with KWOK (Technical Outcome)

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR describes the technical outcome of using KWOK for performance tests. It also contains some scenarios describing these concepts in action:

Optimizing etcd Performance
Control Plane Performance Evaluation

Which issue(s) this PR fixes:

#1063

/release-note-none

Hi @wzshiming, let me know what you think.

/ok-to-test

/test pull-kwok-verify-main

/approve
/lgtm


Add Various Template and Reference-Parameter Functions

Adds:

readJedecID(JedecID & id) - Same as readJedecID(JedecID * id), but uses a reference instead and is thus never nullptr`.
seekArrayElement<Type>(uint24_t address, uint8_t index) - Seeks an array element.

Performs a static_assert to ensure that sizeof(Type) > 0, though by the laws of C++ that expression should always be true.
Implemented manually rather than deferring to seekDataArray because seekDataArray manually handles the case of size being 0 at runtime and this version instead ensures that size is never 0 at compile time, thus this should be capable of producing smaller code.

seekArrayElementMember<Type>(uint24_t address, uint8_t index, size_t offset) - Seeks a member of an array element.

I'm presuming this is the sort of thing seekDataArray's offset parameter is indended to do. I made this a separate function from seekArrayElement because seeking a specific member of an object in an array seems like a very niche thing to do, and is liable to confuse people who are only looking to read a single element from an array. The majority of users are going to want the seekArrayElement version.

readObject<Type>(Type & object) - A thin, type-safe wrapper around readBytes.

Absolves the user of having to deal with casting, & or sizeof, and thus prevents errors that would arise from manually dealing with boilerplate.

readDataObject<Type>(uint24_t address, Type & object) - A thin, type-safe wrapper around readDataBytes.

The documenation is probably off because I basically had to guess at what readDataBytes does.

readSaveObject<Type>(uint24_t address, Type & object) - A thin, type-safe wrapper around readSaveBytes.

Again, the documenation is probably off because I basically had to guess at what readSaveBytes does.

loadObject<Type>(Type & object) - A thin, type-safe wrapper around loadGameState

I opted for Object rather than GameState because it can be used for more than just games and because the words 'game state' get used (and 'overloaded') quite a lot in game development so giving them yet another meaning is likely to cause more confusion for beginners.
Again, absolves the user of having to deal with casting, & or sizeof, and thus prevents errors that would arise from manually dealing with boilerplate.

saveObject<Type>(const Type & object) - A thin, type-safe wrapper around saveGameState

I was going to make a wrapper for readDataArray, but I was really confused about what it was supposed to be doing.
I also wondered if writeSavePage might benefit from being templated, but I don't know enough about what it's actually supposed to be doing to be able to properly document a wrapper for it.

I'd rather not use loadObject and saveObject for the loadGameState and saveGameState overload wrapers and want to keep their orininal names. Reason for this is that the functions only allows a single gameState object to be loaded and saved for the purpose of loading and saving a gamestate / savegame.
The function names you propose are good ones but are better suited for future functions that allow to load and save multiple objects from and to different locations in the save data.

I'd rather not use loadObject and saveObject for the loadGameState and saveGameState overload wrapers and want to keep their orininal names.

The function names you propose are good ones but are better suited for future functions that allow to load and save multiple objects from and to different locations in the save data.

Fair enough. I've just updated them.

Any thoughts about whether a readObjectEnd would be useful?
template<typename Type>
static void readObjectEnd(Type & object)
{
  readBytesEnd(reinterpret_cast<uint8_t *>(&object), sizeof(object));
}

@tiberiusbrown's explanation yesterday has made a few things clearer (and will be useful for adding documentation later), and I'm now under the impression that readObjectEnd would be useful for doing e.g.
Fx::seedData(object1Address);
FX::readObjectEnd(object1);

Fx::seedData(object2Address);
FX::readObjectEnd(object2);

Since readfBytesEnd is there having a readObjectEnd makes sense.
However for smaller code size. closing (terminating) the different seek functions using readEnd is prefered.
Talking about readEnd. readEnd is practically the same as readPendingLastUInt8 (readPendingLastUInt8  function calls readEnd) what's is there a method to change readPendingLastUInt8 as an  alias for readEnd?

Since readfBytesEnd is there having a readObjectEnd makes sense.

If you hadn't merged I would have added that now, but since you've already merged I'm not sure whether to add that next or to focus on the documentation next.
(I don't want to do more than one thing at a time if I can help it because the commit history gets a bit hard to read when commits start getting interlaced. Though perhaps that's just me being overly perfectionist again.)

readEnd is practically the same as readPendingLastUInt8

Good to know. That definitely belongs in the documentation.

what's is there a method to change readPendingLastUInt8 as an alias for readEnd?

In C++ you'd just make one call the other. It seems to me that readEnd is the more fundamental of the two, so the one with the long name should probably call readEnd.
You can force it to be inline if you want to be extra sure, but I'd be surprised if the compiler didn't always inline a function that consists of nothing more than a call.
(In the worst case scenario where it didn't inline I'd expect no more than a jump to the body of the other function. I don't think a compiler would generate a second call unless all optimisation was off.)
(If I were creating my own language I'd make it possible to do functionA = functionB;. Languages like Haskell allow that sort of thing.)


bump librarian-puppet version in dependencies

required librarian-puppet version fails to install any module with Puppetfile generated by 1.3.2 version, because of new puppet forge url:

forge "https://forgeapi.puppetlabs.com"

so, maybe it's a good idea to bump librarian-puppet version in requirements =)

going to bump to 1.4.1 since 2.x requires ruby 1.9


Uint instead of uInt?

Why not to use Uint or uint?
Currently:
json["id"].uInt
json["id"].uInt8
json["id"].uInt16
...

Better
json["id"].uint
json["id"].uint8
json["id"].uint16

There hasn't been much activity on this issue for a while so I'm gonna go ahead and consider it fixed. Please let us know it you'd like to reopen it.


BF: Fixes for using custom config

We need to read the bids_root from the custom configuration early (and not at the very end of config.py, as is currently the case in master).

It's becoming more and more clear to me that config.py's complexity is slowly getting out of hand and, like @jasmainak said, it's drifting away from what an ordinary user should have to deal with. I would suggest to start treating it more like an ordinary Python module than just a collection of configuration settings (because in fact we're already past this point anyway), and move the bits that we want to be "user-facing" to an example of a custom configuration file. This PR and #84 make it easy to use different custom configurations; and I'm considering adding a small script run_pipeline.py to replace the Makefile and allow the user to specify which configuration to use without having to set an MNE_BIDS_CONFIG_PATH einvironment variable.
WDYT?

@hoechenberger we need to talk :)

@hoechenberger we need to talk :)

Yeeesss... so... how about the three of us -- you, @jasmainak and I -- schedule a call?

I'm happy to chat, for example tomorrow morning. But I don't want to stand in the way of progress in the mne-study-template. If you think it's more efficient to just talk with @agramfort please go ahead!

… ugh … enough for today, will fix the tests tomorrow.
@jasmainak I had a quick call with @agramfort this afternoon and we discussed how to proceed with this PR and some small other steps. I think we are good for now in terms of deciding where to go, at least for the next couple days! :)

Should pass tests now… These are quite a number of changes, will explain tomorrow.

Ok so this PR now adds a few convenience functions to retrieve certain configuration values:

get_subjects
get_subjects_dir
get_sessions
get_task
get_runs
get_kind

This allows for easier handling of those settings in a central place; for example, a user can now specify sessions = 'all' to process all sessions, which is probably more intuitive than sessions = None. It also allowed us to move reading of the custom configuration file to the bottom of config.file again.
@agramfort I think this is good to merge.

thansk a lot @hoechenberger  !


Tests with Grizzly now map exceptions properly

When using Grizzly with ResourceTestRule, it didn't know how to map exceptions (it would just return the generic Grizzly error page, which is not useful for testing). This pull request fixes this by turning on RESPONSE_SET_STATUS_OVER_SEND_ERROR
Closes #1057 (though it only mentioned protected routes)

Thanks for your work on this.

Nice. It's all about finding the hidden features!


[WIP] Add independent database model as ramp-database

@aboucaud I would check the diff in https://github.com/paris-saclay-cds/ramp-board/pull/55/files#diff-a04566a61786f36dc7805a893b5a088e to make sure to apply all changes made there to model.py again here in this PR.

@kegl it's a bit difficult to further work on other things while this is not yet merged. So I am going to merge it, but I made a copy of the current master branch (available as master_copy), so you can easily check that out to still check the previous version.


GEODE-599: Remove Flaky annotation from previously failing tests

this looks good; I will pull it in


JavaScript heap out of memory after v0.5.22 upgrade

Hi, we're using your library in build step on GitHub Actions and yesterday it suddenly stopped working and we get an error like this. When I force the version to 0.5.21 it works again. We use the plugin like this:
libAssetsPlugin({
    include: /\/fonts\//
})

I would be grateful if you can fix this. This plugin is great, thank you for creating it.

@piotrpalarz Thank you for your feedback and sorry for broken your project, I'll fix this soon.

@piotrpalarz I've just reproduced the issue you encountered, and I'll try to fix it.

@piotrpalarz This issue was caused by the changes made in issue 79. I will roll back these changes in the next version to fix the more severe crash problem mentioned here.


Question: Specify Api Routes

Hey yonaskolb!
First off, really great project. I love SwagGen and the fact that I can now use a native app generating my models and requests plus using Stencil which I really love.
A quick question: Is it possible to specify only the routes or models which should be generated?
Similar to Swagger Codegens -Dmodels {opts}, -Dapis {opts} flags?
That would be great!
Keep up the good work.
Kind regards
PS: Stencil has been updated and now allow % elif %. Would be great if you could update the dependencies. Perhaps even not constraining them to an exact version but e.g. specifying the major version ;-)

Thanks for the kind words @prefect42!
At the moment, no there isn't a way to only generate a subset of the spec.
In terms of Stencil, I actually use my own fork that adds something I was looking for, and the pull request I made hasn't been approved yet https://github.com/kylef/Stencil/pull/85
I can look at rebasing my fork though to upgrade

No worries. I script myself a filter.
One more thing: Currently a file is created for every method of an API Controller. Is that really necessary. Would be great if the Extensions to the controller could be generated all in the same file. If this is not to your liking this could be made a parameter.
Your project is really young, but I am very glad I found it.

Yes, in the default template all the operations are generated as seperate files, but you can easily generate them in one file if you change the request.swift destination in the template.yml file from:
"Requests{% if tag %}/{{ tag|upperCamelCase }}{% endif %}/{{ operationId|upperCamelCase }}.swift"

to
Requests.swift

And then in the request.swift file wrap the relevant code in a
{% for operation in operations %}
...
{% endfor %}

And then reference all the operation properties with operation.
That's the advantage of having a flexible template configuration, instead of the hardcoded files in Swagger Codegen

Awesome 🎉
I am glad I asked ;-)

Just a note, you would also have to remove context: operations from the request file in template.yml to get them generating in 1 file

@prefect42, the Stencil dependancy has been updated so feel free to use the new {% elif %} tag


Merge captures for the same webpage ?

Hello,
I'm wondering it there would be any way of adding an option to merge captures made for the same website within the same entry.
Knowing the capture template, it could be possible to find if the exact same header is already present in the capture file and then the content could be appended to the already existing entry.
The kind of use-case I'm thinking about with this feature request, is when you are on a page and you want to capture multiple selections, that would then be merged inside a single org header.
Let me know what you think about this !
Thanks in advance for your answer !

Hey, sorry for a late reply!
It would be useful and possible in theory by modifying the 'server' python script.. but makes it quite a bit more complicated as well (i.e. requires parsing the file in addition to generating org-mode). I usually just do it manually when I process my highlights later


the doc "Integration With Spring Framework" configuration

But Sql2o has no defautle constructor, should be that:

@ccor There is no need for a default constructor because you can use Spring to pass in a datasource in your configuration. See the below Spring 4.1 XML example as to how to initialize a sql2o object properly in Spring.
    <bean id="sql2o" class="org.sql2o.Sql2o">
	<constructor-arg type='javax.sql.DataSource' ref='datasource'/>
</bean>

Thanks for clearing this out. I will close this issue. There is still a need to add better documentation for how to use a connection pool without using spring, but that is covered in #143


Add ICONOMI/ICN asset

ICONOMI was one of the biggest ICOs in this year, and is one of the more succesfull Ethereum assets. Why not add it?

It will be released next week, so it would be great if you added support for ICN tokens to your wallet.

ICONOMI is so great like Augur REP's.

Ugh. I don't know how many times I have to say this.
WE CANNOT ADD ANY TOKEN WITHOUT THE ADDRESS AND DECIMALS.
If you provide us with those two pieces of information we can add it.

@tayvano here people are just making sure to notice ICONOMI (but yeah, I know how annoying that can be to hear repeatedly same requests).
We'll provide address and decimals (18 decimals there will be) within few days (once contract is deployed and values assigned to designated addresses).

I understand that but I'm getting 20+ emails / tweets / reddit message a day right now asking the same question about ICO. We typically receive around 30-40 messages a day with legit support requests.
Raving about how great a token is in my support inbox is not going to prompt us to add the token any faster. We do not add tokens based on emails or our personal feelings on a token. We add them when someone requests them to be added and includes the address and decimals needed so we can easily add them.
I see some of my replies are making in the bitcointalk.org thread. Hopefully this one can too so we can focus on helping people who are having issues with the site and writing code.


Adds Publishing Py Packages

Latest pipeline run.
Example of the .whl files published.

Please review.

I believe I addressed all the feedback (planned for this PR). Please review again.


Client Allocation Request for: Dong Fong Technologies Vietnam Company Limited

Client Allocation Questions
Core Information

Name: Dong Fong Technologies Vietnam Company Limited
Website / Social Media: http://vn.dongfong.com.tw/about.html
Region: Asia excl. Greater China
DataCap Requested: 2TiB
Addresses to be Notarized: f17chz2xuedput42kfhfs722f7q6lk7ue4ioi2zyi
Notary Requested: ericfish

Hi @uglyboy123
I am a colleague of @ericfish (here).
Sorry for the delay in processing your application because our Datacap is still in progress.
What's your company's business? and could you show me your company's business license?

Hi, @uglyboy123. Can we go on this verifying?

Sorry, please let us continue with the verifying

I am Mia Nguyen,  in charge of Dongfong Technology Vietnam.

Dongfong Technology is a famous transnational IDC technical service provider in Taiwan and Southeast Asia. Since its establishment, Dongfong Technology has been committed to providing customers with one-stop IDC room and network services.

Here is our business license

Thanks for your introduction.
What kind of data do your company want to store and have you ever use any cloud to store these data? What's your usage volume and frequency?
And do you plan on allocating a substantial portion of your DataCap to a single miner, or will you spread it across many miners? What method will you use to insperct miners?

Hi,rayshitou
1.We want to  store some live video as a backup in the Filecoin network,About 5TiB.
2.We plan t0 divide it up among several miners,distance is our primary consideration.

OK.
Will you record your allocation decision in public? Which platform will you use?
And, i want to know that have you been approved for a DataCap previously? If so, can you share the details of the last allocation decision?

Yes.

Sorry, maybe my question is not clear enough, can you answer it separately.

Will you record your allocation decision in public? Which platform will you use?
Have you been approved for a DataCap previously? If so, can you share the details of the last allocation decision?

Hi,rayshitou
1.We will post the result of the application on Github.
2.None.

Thanks for your quick response.  Finally, Can you guarantee that all these data you mentioned above abides by local regulations and in compliance with the recipient miner's terms of service?

Yes, we promise to abide by local regulations and comply with the terms of service of the receiver miner.

@uglyboy123 ，I have noticed that you have applied for 5T DataCap, but we only have 2T left. I have modified the DataCap, please be aware.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacedl57bljad5zhkkiqhaykvz6cgyyx3bmnsizesxjpu7qizf5a2y3s

Address

f17chz2xuedput42kfhfs722f7q6lk7ue4ioi2zyi

Datacap Allocated

2TiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacedl57bljad5zhkkiqhaykvz6cgyyx3bmnsizesxjpu7qizf5a2y3s


Scaling the mesh does not scale the bounding box.

Scaling the mesh does not scale the bounding box and leads to mousepicking being unreliable in the editor.
How to reproduce:
Scale mesh by 5 (for example).
Try to select mesh.

Could bullet be used to get accurate picking by using ray vs box/mesh? If bullet is used, scale problem will also be fixed.


Spark

Added Spark standalone, streaming examples, and integration with Cloud Pubsub

@lesv have you found any problems with my code? Thank you!

@maxluebbe PTAL
@hegemonic PTAL

The JAR shouldn't be submitted here.

Let me know when all of these are done.

@lesv bdutil uses ALPN 7.0.0: https://github.com/GoogleCloudPlatform/bdutil/blob/f1b5b36bae4bd8b5abb09d94d3575980b307755d/extensions/bigtable/bigtable_env.sh#L40
Should we use 7.1.3 instead even though it won't be in the VMs?

@lesv I've addressed your comments. The indentation looks messed up in the diff but looks fine here: https://github.com/taragu/cloud-bigtable-examples/blob/spark/scala/spark-streaming-wordcount/src/main/scala/StreamingExample.scala
https://github.com/taragu/cloud-bigtable-examples/blob/spark/scala/spark-standalone-wordcount/src/main/scala/WordCount.scala
Also, you mentioned I should include more in the word count example README (https://github.com/taragu/cloud-bigtable-examples/blob/spark/scala/spark-standalone-wordcount/README.md) besides the link to the official doc. What else should I include?

I find that indentation issues happen when there are tabs in the document.

Tara -- Look at Solomon's advice and remove any tabs or hidden characters.  Consider using 4 space indents for carry on lines.
I need to check w/ @hegemonic as we may just do a simple doc for this and have the bulk of the text in the various readme's.

@lesv I've removed the tabs. As we discussed earlier, I didn't use 4 spaces because the style guide used 2 spaces: https://sites.google.com/a/google.com/scala/coding/scala-style-for-new-developers?pli=1. Is there anything else?

Did you just strike the alpn-boot?  If so, does it work?

Yes---I deleted alpn in the build files because it was only used in runtime. We don't need it to compile the code.

LGTM -- please make sure to add it to the README about running, but lets start a new PR for that.


Add gemini@5 support. Fixes #14.

Replace deprecated 'endTest' event with 'endState'.

Hello here! Is there any chance to get it published in near feature, or should we look for another solution? Currently we cannot properly abort build in case of broken gemini tests, and this affects our continious integration a lot

v2.1.4 is published. tnx for the contributing!


New versions of create_root, new_child, etc with attributes and inner text

This is a feature request to add methods for creating new nodes with an attribute dictionary, like this:
function create_root( xdoc::XMLDocument
                    , name::AbstractString
                    , attrs::Dict{ASCIIString,ASCIIString} )
    xroot = create_root(xdoc, name)
    set_attributes(xroot, attrs)
    xroot
end
function new_child( parent::XMLElement
                  , name::AbstractString
                  , attrs::Dict{ASCIIString,ASCIIString} )
    child = new_child(parent, name)
    set_attributes(child, attrs)
    child
end
function new_child( parent::XMLElement
                  , name::AbstractString
                  , attrs::Dict{ASCIIString,ASCIIString}
                  , text::ASCIIString )
    child = new_child2(parent, name, attrs)
    add_text(child, text)
    child
end

This would remove the need for additional calls to set_attributes or add_text and make the creation of new elements much more streamlined, for example:
xgeom = new_child(xgrid, "Geometry", Dict("Type"=>"VXVYVZ"))
xxdat = new_child(xgeom, "DataItem", Dict("Dimensions"=>"4 2", "Format"=>"HDF", "Precision"=>"8"), xspacedata)

Could be additional methods using keyword arguments, I suppose. I'd look over a pull request.

Would there be an issue with having them defined as methods with positional arguments, rather than keyword arguments, and letting dispatch choose the appropriate one?
I will try and submit a pull request if I can figure out how AbstractString and friends are actually supposed to work, and if I can get it working for both 0.3 and 0.4.

The issue with positional arguments is whether the particular order is a clear API. Sometimes it's clearer to have named inputs. For example with attributes and text, what if you want to add text but not have any attributes? I also lean towards separating functionality out into smaller, more composable pieces, so I'm not sure what trying to put everything into the same list of arguments for a single function call accomplishes.

Wouldn't it make sense to pass all attributes as keyword arguments, like this?
function create_root(xdoc::XMLDocument,
                     name::AbstractString; # Notice the semicolon
                     attrs...)

@315234 See Compat.jl to get things working on both 0.3 and 0.4.

That would only work for assigning to attributes whose names are valid Julia identifiers (so no keywords, no punctuation), but otherwise would be consistent with one of the signatures of set_attributes

Right. There could be an alternative method taking a Dict{AbstractString, AbstractString} for corner cases. (At least it could be added later if somebody requests it.)

Actually, doing f(symbol("/")=>1) works.


SQL as of 2017-10-17 + Autorest for Python 2.0.17

Added feature:

Added support for state and migration flag properties for SQL Vnet rules

Codecov Report

Merging #1545 into master will increase coverage by <.01%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
+ Coverage   54.24%   54.24%   +<.01%
==========================================
  Files        3585     3585
  Lines       88224    88230       +6
==========================================
+ Hits        47854    47859       +5
- Misses      40370    40371       +1

Impacted Files
Coverage Δ

...re/mgmt/sql/operations/server_usages_operations.py
93.75% <ø> (ø)
:arrow_up:

...operations/recommended_elastic_pools_operations.py
19.71% <ø> (ø)
:arrow_up:

...mt/sql/models/failover_group_read_only_endpoint.py
80% <ø> (ø)
:arrow_up:

...re/mgmt/sql/models/service_objective_capability.py
41.66% <ø> (ø)
:arrow_up:

...mt/sql/operations/service_objectives_operations.py
26% <ø> (ø)
:arrow_up:

...-sql/azure/mgmt/sql/models/service_tier_advisor.py
20% <ø> (ø)
:arrow_up:

...ure-mgmt-sql/azure/mgmt/sql/models/partner_info.py
62.5% <ø> (ø)
:arrow_up:

...zure/mgmt/sql/operations/server_keys_operations.py
16% <ø> (ø)
:arrow_up:

...e-mgmt-sql/azure/mgmt/sql/sql_management_client.py
100% <ø> (+0.99%)
:arrow_up:

...e-mgmt-sql/azure/mgmt/sql/models/failover_group.py
35.71% <ø> (ø)
:arrow_up:

... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8918213...90bdfde. Read the comment docs.


Why not add a event when scrolling stops?

I want to get the events when scrolling stops. Fortunately， i find a solution in this issue
But i have a question, why not add a event in api such as ps-scroll-x-stop?

I'm glad you found the solution. The reason why it's not included as a feature is, as I mentioned in the previous issue, performance. There is no native way to capture scrolling stops, and we need a timer to keep updated in every scroll event. I thought it's better for users to decide whether they use the event or not. It's just a few lines of code, so users may have no difficulty without any API, I think.
Anyway, I really appreciate your interest 😄


Update Get-WindowsReservedStorageState.md

Fixing example, it fails with -Online.
PR Summary
Removed the -Online parameter from the example as it causes error. It doesnt apply per discussion with engineering owner.
PR Checklist

[x] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[x] Summary: This PR's summary describes the scope and intent of the change.
[x] Contributor's Guide: I have read the contributors guide.
[x] Style: This PR adheres to the style guide.

Thanks for submitting your pull request. To improve the quality of your content and make sure all errors are resolved, we recommend that you use the PubOps publishing process.

Add the Sign off label when you think your PR is ready to merge. A PR reviewer either merges it, or adds the Back to Submitter label with a comment about what needs to be fixed and sends it back to you.

If you need to update your content per the PR reviewer feedback, add the Sign off label again.

Your content is published live during one of the next publishing cycles, which are weekdays at 10:30 AM Pacific Time and 3:30 PM Pacific Time.

If you have a question, post it on the Ask an Admin support channel.

@mestew not sure if you are able to review and merge this small change. Not urgent.

@SteveDiAcetis  Does this bit below need to be pulled out of the cmdlet despcription as well?

Gets the current state of reserved storage. This command is supported with the online Windows image.

Thanks for checking out the details on this with engineering. Let me know about the desription and I can get this merged for ya

The description is correct. I will add 'only' to it. Because only online, the parameter for online (versus offline image) isn't needed.

@SteveDiAcetis saw the new change come through. Thanks so much. I'll handle getting this merged in.


[REQ] Support for clicking on photo or name to access steam profile

I believe it is simple and useless at the moment, but the option of clicking on the player's photo or nickname to access their Steam profile would be interesting.

will add it on the new release.


Redis Telemetry not appearing on Application Insights

List of NuGet packages and version that you are using:
Application Insights Kubernetes Version: 7.0.0
Application Insights SDK Version: 2.22.0

Runtime version (e.g. net461, net48, netcoreapp2.1, netcoreapp3.1, etc. You can find this information from the *.csproj file):
net8

Hosting environment (e.g. Azure Web App, App Service on Linux, Windows, Ubuntu, etc.):
AKS

Describe the bug
When reviewing the application map for a dotnet application hosted on AKS we noticed no telemetry to redis endpoints/dependency. Case #2407250010001728 was raised with Microsoft and MS engineer advised to raise a case directly with engineering as they don't support this package.
To Reproduce
Steps to reproduce the behavior:
Go to Application Insights for the specific AKS cluster.
Click on Application Map.
Redis Dependency does not appear on the map although the highest amount of traffic is sent/received from that endpoint.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
AKS support group have asked to raise an issue with App Insights directly, refer https://github.com/microsoft/ApplicationInsights-Kubernetes/issues/368
Microsoft support email pasted below,
Hi Adeel,
Thanks for your time, I really appreciate your cooperation.
We have discussed the symptom on the meeting and provided a suggestion, please kindly refer to following meeting minutes for your reference:
Symptom
Application Map not showing all endpoints such as lwccachesydney.redis.cache.windows.net
Analysis
Application Map will visualize two telemetry type requests and dependency.
We have queried Redis log over the past 7 days, there is no record being captured which is why the Redis didn’t appear in the Application Map.
By checking the telemetry further, we found that SDK version is ai-K8S<IP_ADDRESS> and all those telemetries were captured by ai-k8s:x.x.x.x
As per your developer team’s confirmation, they added package in the source code.
I have double checked this version with our K8S team and engineering team, Unfortunately, I was told that this specific SDK is beyond CSS knowledge and scope, it is supported by our engineering team directly.
Suggestion
To address this issue further, please kindly ask your developer team to raise this question on GitHub.
GitHub - microsoft/ApplicationInsights-Kubernetes: Enrich the telemetry data for .NET applications running inside containers that are managed by Kubernetes.
Hope this makes sense for you and kindly let me know if you have further questions.
Regards,
Jason

@OsvaldoRosado Can you take a look at this? Do I understand correct that the problem is that there's no baked in telemetry module for Redis?

You are right. There is no automatic collection of Redis calls, so it must be manually collected. https://learn.microsoft.com/en-us/azure/azure-monitor/app/asp-net-dependencies#automatically-tracked-dependencies
No plan to add the new feature in this repo as well, given this is already supported in OpenTelemetry by using https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Instrumentation.StackExchangeRedis along with OTel based AzureMonitor distro : https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-enable?tabs=aspnetcore
Hope the new OTel based approach is good enough to meet the needs.