Galaxy S7 Edge US edition performance issues - Submission

Hi, I've quite large question. Since feature development of my product is on hold until first release on Oculus store will be achieved, so i'll get back to old questions/issues after submission will be complete. But i'm struggling with it since september last year (feedback from oculus team is poor, so it is long process). They are failing my submission because on Galaxy S7 Edge (snapdragon version) there is lots of frame drops, judder etc. I've S7 Edge with Exynos processor, and it is working like a charm. Do you encountered that issue? Buying another phone from US series would be troublesome. I've saw, that Unity/Unreal devs had similar problems. I'm on 3.2 version of GearVRf (since further releases had many breaking changes and buisness wanted to release on this version and then upgrade to new one). All my textures are ASTC's for better performance (on our test phones, result is phenomenal!). But still, S7Edge snapdragon is failing to work as expected.

Ok, thanks for the invite.  I've been able to download and play with it on a Snapdragon S7 Edge running Android 7 (Nougat).
First, good job :).  The stereo images look very nice and the user interface looks and works very well.  Good work :)
You mentioned that Oculus was complaining about "Galaxy S7 Edge 6.0 us version".  Does that mean Android 6.0?  as in Marshmallow?  I'm assuming so.  We grabbed an S7 Edge and flashed it with 6.0, but I am unable to see/install your app.  It does not show up in the 'My Preview Apps' section like it does with the S7 phones running Nougat (Android 7).  If I take the apk and try to install it manually with adb, I get:  Failure [INSTALL_FAILED_OLDER_SDK]
What's your minSdkVersion set to?  Maybe Oculus is faling it because it won't install on Marshmallow?

Hi @felislynx-silae I notice one thing, you are using lot of custom shader(CS). If I enter a room CS is added, move to another room CS is added. Again moving to the previous room CS is added. If you have few CS, you can just create them once and reuse them.

@thomasflynn funny thing about 6.0.  And after that, submission status was still failed because of SGS7E, i've started digging around and voila US/EU version difference. I'll give you all feedback that i've got:
VRC.Mobile.Input.3 ->
Notes from Reviewer

Short press back button works fine until the Main Menu where it should bring up the "Exit to Oculus Home screen?" where the user can have the option to cancel or Go to Oculus Home.
Steps to Reproduce

1. Launch the title
2. If applicable, select a menu item to begin the experience
3. Press the back button
4. Observe the display
5. Press the back button again
Expected Results

If the app has a pre-launch menu, pressing the back button once should take you back to it.  Pressing the back button multiple times should eventually show the "Return to Oculus Home" menu.

VRC.Mobile.Performance.1 ->
Notes from Reviewer

Still jitter and judder issues on the S7 Edge. Occurs on all our S7 devices.
Steps to Reproduce

1. Use the app for the length of the content or 45 minutes, whichever is shorter
2. Launch the OVR Metrics tool and select the log file for your app
3. Observe the FPS graph
Expected Results

Application should not experience extended periods of framerate below 60 FPS. Exceptions include when there's a black screen or during loading scenes.

VRC.Mobile.SDK.1 ->
Notes from Reviewer

Still jitter and judder issues on the S7 Edge. Occurs on all our S7 devices.

After that submission test result i just had to ask here if anyone had issues with SGS7Edge before since i saw lots of topics about poor performance of US version.
@apjagdale For every widget responsible for transition into another scene, we add shader which is responsible for animation around icon. We are changing values inside this shader to animate widget. I could try to have one instance but i would have to test, how it would behave if we would have ie. 10 transition widgets on scene :)

@felislynx-silae Two things:

You could try lowering the eye buffer's resolution to the default 1024 (in gvr.xml)

            resolutionWidth="1024"
            resolutionHeight="1024"

You could enable multiview for your app; you will have to adjust your shaders, which we can help with. In gvr.xml:

<lens name="N4" >
...
    <vr-app-settings
        ...
        useMultiview="true"

@apjagdale Could you please try to run the app for extended period of time? I guess up to 45 minutes is to be expected. Please also figure out the cpu usage pattern.

@liaxim about eye buffer resolution, we increased it just because users were telling us, that for 1024x1024 value quality was worse than webview+cardboard :)
We are still trying to get hold on us version of this phone.
But i'll prepare version with reuse of shaders and useMultiview to check out performance gain

@felislynx-silae Regarding reusing Custom Shaders, we cache it in framework. I am unaware as why your app is creating Custom Shaders all the time. We cache CS by its class name. You can check our gvr-eyepicking demo which uses CS.

@apjagdale could it be connected to use of ASTC textures for photospheres?

New version is uploaded into Beta channel.

shaders for transition objects are now reused instead create over and over and over again
i've added .nomedia to root folder of app to prevent media scan for new thumbnails and assets
i've raised cpu level to 2

@felislynx-silae I was seeing some network activities while at the start menu interface doing nothing. There seems to be consistent network activities and sometimes relatively high.
Do you know what's going on there?

That sounds like something to look into.  That aside however, there has been a lot of improvement.  We can verify that shaders are no longer being recompiled.  And framerate is a lot more steady.  Performance on Snapdragon and Exynos looks pretty similar (with Snapdragon looking slightly better).

We have submitted new version to review. Fingers crossed :) The network activity is actually download jobs that are working while app is idle (ones that didn't have a chance to be finished while watching presentation). It is a requested feature.

So, again they said that 1. S7 edge has judder and 2. Short back navigation is wrong. And honestly i dont see what is wrong with back navigation now. And why there is still some kind of judder on their s7 edge. They didnt provide any additional information...

can they share the log of the run with you?

I've made ticket with request for logs. I'll send them as soon as ill get them

@felislynx-silae Do you mean you are downloading bits and pieces of the 360 degree photographs while idle?

@bohuang3d more or less. Some parts that will speed up future run. It make sense for our target user. Maybe not for typical user that will download this app once, run for 30 minutes and then unistall :)

@felislynx-silae Can't you download all that stuff prior to the first launch? Like show loading asset notice and launch only after done. All that activity could be contributing to the jitter the tester is seeing. Do you throttle all those downloads or do they happen as fast as the network and the device allow? How big of a download are we talking about? How big are the files, how many? What happens if the phone is not connected to a network? Do you do something with those files immediately after downloading?

Those are 4k spheres and we dont download them in pre launch since some presentations weight a lot and it is better to fast launch it with 1k sphere and then download on demand 4k per visited scene (typical sphere 4k is ~4mb). Throttle is set to 5 files at once. Quantity depend how many scenes you visited and exited before 4k loads. They are saved just like any other asset. If phone is disconnected from the network work is disposed and if user will go for this asset again, download will resume. If we are in main menu, after file is downloaded, nothing happens. It is just ready for another run of this presentation :). I can disable this feature and check on ovr metrics tool for performance changes tommorow morning :)

@felislynx-silae
You say that others have reported problems with the Snapdragon S7 as well. Due to chip architecture differences, it’s a possibility that the Qualcomm chipset may not handle some operations as well as the Euro ARM chipset, thus exposing the vulnerable parts of your app using those operations. (On the other hand the Snapdragon chipset may excel in other areas compared to ARM)
That speculation aside, the S7 is a sailed ship and your app has to adapt to its quirks. I would want you to log some performance metrics and do some sanity checks. For example, is it reasonable for the app to download 3kb to 18kb of data each frame? How long does it take to parse the data? The length of time to transform the data into other images/data structures? Any bottleneck during this chain of processes could be the cause of the occasional frame rate drops.

So after next submission, they didn't failed it because of SGS7Edge so it means that background network shouldn't be done while idle :). Also shader was an issue. Although they still fail us because of back navigation. I believe that this is because when you go back from presentation into main menu, first back event is doing nothing. Which is quite strange
override fun dispatchKeyEvent(event: KeyEvent): Boolean {
        return if (applicationMain.onBackPressed(event)) { // If this is not MenuScene, event will be consumed and returns true, MenuScene returns false and event is not consumed
            true
        } else {
            super.dispatchKeyEvent(event)
        }
    }

I'm looking why first  super.dispatchKeyEvent(event) gives no effect and second one is invoiking "Exit to oculus screen". Is there a way to invoke this menu by code in framework?

Great to hear. The rest of your issues should hopefully be easier comparatively.
For the back navigation, I can't tell the logic flow of this 'return if' block. I'm guessing this function returns true if applicationMain knows if back key pressed. Otherwise return whatever super.dispatchKeyEvent(event) returns.
Can you debug and examine the 'event' object. What action(s) correspond to the first super.dispatchKeyEvent(event) you mention?
What is the shader issue

I've send another set of invitations (we had to change package name & keystore to sign app so new entry in store was created).
Today news: only thing they say that is wrong:
Notes from Reviewer

The back button short-press still is not functioning as intended.
Your navigation currently is:
Main Menu -> Presentation ->(back press) Main Menu ->(back press) Nothing happens, you remain on the Main Menu. This is when the "Exit to Oculus Home Screen" should appear but currently it doesn't.
Steps to Reproduce

1. Launch the title
2. If applicable, select a menu item to begin the experience
3. Press the back button
4. Observe the display
5. Press the back button again
Expected Results

If the app has a pre-launch menu, pressing the back button once should take you back to it.  Pressing the back button multiple times should eventually show the "Return to Oculus Home" menu.

Although, on S6, S7 and S7Edge (white and black gogles) we couldn't reproduce this behaviour which is quite strange and thats why i've asked that question. applicationMain knows if scene consumed event (so we shouldn't dispatch it to framework). On Main menu dispatchKeyEvent is dispatching back button keycode with DOWN and UP action correctly, but first one is not doing anything, second one is entering universal menu. I've made some workaround within version 4 but aparently its still wrong

We have GVRMain.onBackPress to deal with the back key navigation. Currently only gvr-immersivepedia uses it as far as I can recall. If your app decides it wants to handle the back key (to move to a different scene for example) then you must return true from onBackPress. Otherwise the framework handles it. For Oculus we bring up the exit-to-Oculus-home activity. There is no public API to force the Oculus prompt.
Not sure whether you are relying on onBackPress alone. Do you have a custom dispatchKeyEvent?

@felislynx-silae I cannot reproduce on S7edge the way I understand it. At main menu where the scenes are displayed, pressing back I do see the 'return to Oculus Home' screen. Pressing back again brings me back to your main menu window.
You say you can't reproduce either. Which device did the reviewer flag the problem?

@bohuang3d
They are right: Black googles + s6 -> back button is not working o_O
action:0/1 keycode:4
On white googles same action and keycode but back works

@felislynx-silae How does gvr-immersivepedia work for you? Is it too not bringing up the prompt?

@liaxim Yup it works, but i have version of immersivepedia with 4.0 framework. My app is on 3.2 and update to newer framework before release is impossible

Ok. Does the 3.2 version work for you?

On my app, apparently not :).
Funny thing is, everything works superb on white goggles or in dev mode.
I've checked that on app with removed all "sniffers" to back press or keyevents to make sure, that i'm not messing with events in some way.
Changes done in releases >=3.3 are to damaging to existing code base to do it as "fast change".
Migration to 4.0 was put on hold, on november 2017 to finish 1.0 release (it took me almost a month to regain basic functionality on 4.0). Thats why migration to never version is very not welcomed right now.
I'll finish changes to immersivepedia to migrate it to 3.2 framework and i'll tell you tomorrow morning.

@liaxim https://github.com/felislynx-silae/GearBugSample/tree/develop i've used this project to test this bug. Apparently on 3.2 black goggles are not working correctly. If you change to 3.3.0 they are working. So is there any chance to fix this without updating to 3.3 or we have to do it?

@liaxim Ok, i've made some changes to run app on 3.3.0 (back is working on this version)
While my testers are checking debug build to see if nothing has been broken, on release build PlatformEntitlementCheck is failing always:
PlatformEntitlementCheck.start(
                    gvrContext,
                    baseActivity.resources.getString(R.string.APP_ID),
                    entitlementCheckListener)

throws: class java.lang.IllegalStateException Could not initialize the platform sdk; error code: -1
Without Entitlement check Oculus wont publish app :/

Ok, updated 3.2 at https://github.com/liaxim/GearVRf/tree/32update
6d5c2fecac3a0959ece0020a6a1594e7d9e026c4 is the commit you really need.
9e8995051b28af5efb7e79f5236838d504409ec5 you may need to build with newer ndks.
4e5d24cd5d6f461c7bcf47adfea0478f46813ea1 is a nice to have since it makes sure threads get correct priorities.

@felislynx-silae
Before you do another submission,
-Make sure the language is English legible. Oculus may fail you for difficult navigation with Polish texts
-If possible show with more content. Five environments could be relatively sparse in Oculus' considerations.
If you send me an updated build, my side can give you a look-over to hopefully prevent additional roadblocks from Oculus submission

@bohuang3d i'll send as soon as i'll build a new version of 3.2 from liaxim. Yeah i know it is crashing, i've changed package name of rest objects and i forgot to update proguard :D in this build.
All in app texts are in both languages. Presentations have hardcoded texts and it language depends on creator :) we have multilingual presentations on roadmap :)

@felislynx-silae , just checking in...how is it going?

@thomasflynn we are waiting 4 days for review from oculus, so fingers crossed

@thomasflynn @liaxim We finally passed technical review. Now only store assets review :)
Thank you all for all your help! I'll post link to app as soon as it will be available on store :)

@felislynx-silae Awesome. Can we close now?


fix Issue 7583 - [CTFE] ICE with tuple and alias this

http://d.puremagic.com/issues/show_bug.cgi?id=7583

Thanks!
Note to Walter: This is an awful heisenbug, that could generate all kinds of wrong-code and ICE bugs, apart from this one. It deserves a high priority.


Fix supplementary view + contained first responder reuse issue

The below works around a (seeming?) bug or odd behavior in UICollectionView, where it tries to be smart about recycling supplementary views that contain a first responder such as a text field. Specifically, it holds onto a supplementary view that contains a first responder, not immediately recycling it when it is scrolled out of view. That ensures that the keyboard isn't immediately dismissed, which would be jarring.
...Unfortunately, this doesn't seem to actually work in practice very well. When the supplementary view  is scrolled back into view, and we're asked to dequeue a view, the collection view hands us back a different view, leading to double views that get stacked on top of each other in the layout, leading to a bunch of weirdness.
So, to work around this, we do a few things:

We begin tracking which supplementary views currently contain a first responder. For practicality of implementation, we only track text fields right now. This could change, but is harder, given there's no generic "first responder changed" notification. This code lives in ListView.

We update ListLayoutContent.content(in: ...) to always return supplementary info when a supplementary view contains a first responder, even when out of frame. This ensures the supplementary view instance is kept alive by the collection view. You can see that happening here:

Within collectionView(_:viewForSupplementaryElementOfKind:at:), we check to see if there's a live, existing visibleContainer (aka the supplementary view) view, and if there is, we return that, instead of just dequeuing a new, wrong view.

After all that, the correct thing happens.
Checklist
Please do the following before merging:

[x] Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

Do you happen to have a vanilla UICollectionView repro of this problem? I can file a feedback with Apple if you haven't already.

I haven't, I couldn't repro in Flow layout which makes me think its either doing something similarly special, or I didn't quite poke things right.


Interactive tests

For #871

@ebolyen can you please review this?

Coverage increased (+0.0%) to 98.96% when pulling 3a82b7376787c0d64e08ebae662c4b5074ca93b4 on anderspitman:interactive_tests into a39451be38e436b125e52b38772c43d5f7dc9f01 on biocore:master.

@jairideout yup!

Coverage increased (+0.0%) to 98.96% when pulling 3a82b7376787c0d64e08ebae662c4b5074ca93b4 on anderspitman:interactive_tests into a39451be38e436b125e52b38772c43d5f7dc9f01 on biocore:master.

Coverage increased (+0.0%) to 98.96% when pulling 3a82b7376787c0d64e08ebae662c4b5074ca93b4 on anderspitman:interactive_tests into a39451be38e436b125e52b38772c43d5f7dc9f01 on biocore:master.

@anderspitman Tested this locally and it is working great! Way easier to type too! Only one comment which is pretty discretionary, so let me know if you are ready for merge.


issues with replaced docker tags

while migrating from one host to another i found that postgres stopped working. while starting up the same "version" i got the following error:
The database cluster was initialized with CATALOG_VERSION_NO 202005171, but the server was compiled with CATALOG_VERSION_NO 202007201.

it appears that the image: postgres:13 and postgres:13.0 is misleading and gets updated frequently and each update will break existing databases and will need to somehow get the last version of the database software running to do a pg_dump on but i'm not sure as i thought i was running 13.0.
i can see that latest may change frequently but tags with versions on them are expected to run a known version. i think it matters more when the software can't automatically migrate between minor version updates.

There are more specific tags that you can use to get an exact version
https://hub.docker.com/_/postgres/?tab=tags&page=1&name=13
postgres:13-rc1 matches your catalog version, and was updated to 13.0-1.pgdg100+1 a little over a month ago https://github.com/docker-library/postgres/commit/8d281112a872380578e37a92a698ce59d66473d7
$ docker run -d --rm --name postgres -e POSTGRES_PASSWORD=pass postgres:13-rc1
812900e87aed559520a9f76fc9b30c3914a3f565de225ff1ff110ed6d1ee57f0

$ docker exec postgres cat /usr/share/postgresql/13/catalog_version
202007201

See also https://www.postgresql.org/developer/beta/ for information from the PostgreSQL community regarding the use of beta/pre-release versions, especially:

PostgreSQL beta and release candidate release are not meant for use in production systems.
...
Features are subject to changes that are backwards incompatible at any time during the development of the betas, and could possibly be removed altogether.

So this is unfortunately "by design" in the PostgreSQL world.

Also, same as #662 which was about pre-release 12 (and 13: https://github.com/docker-library/postgres/issues/662#issuecomment-723881751)

I hit the same problem today.
How can i roll back to 13.0 to restore my DBs?
Looking at the images here : https://hub.docker.com/_/postgres/?tab=tags&page=1&name=13
It appears that the image for 13.0 and 13.1 are identical
for linux/amd64
postgres:13
DIGEST:sha256:b6a3459825427f08ab886545c64d4e5754aa425c5eea678d5359f06a9bf7faab
postgres:13.1
DIGEST:sha256:b6a3459825427f08ab886545c64d4e5754aa425c5eea678d5359f06a9bf7faab
Or am I confused?
Should I use this image:
https://hub.docker.com/layers/postgres/library/postgres/13.0/images/sha256-832e01fa055c55a9c9195db231cf3935a81b7b60c8cccd64e7b5395d1ee1948b
Actually the one i needed is
docker pull postgres:13-beta1

$ docker run -d --rm --name postgres -e POSTGRES_PASSWORD=pass postgres:13-beta1
946c9f2b29612801e1c14d68ecddd70bd48372436d967aaaaad008ee5252ebd0

$ docker exec postgres cat /usr/share/postgresql/13/catalog_version
202005171```

@0xfff in my case, i ended up finding the sha of the version i had used before and updated my docker-compose file to use it, for example:
  postgres13:
    image: postgres@sha256:b71084d6fef0876d7e63e652b0227d965bf8515bb3dec7478af4b67bf3aa722b
    ports:
      - "5432:5432"
   ...

I've filed https://github.com/docker-library/postgres/pull/797 to help alleviate this in the future.


Consider renaming APIConfig

Due to it having Config in the name PR #313 has to name a config APIConfigConfig.
Consider renaming this to perhaps APIAccess or Authorization. Getting Config out of the name could help.

My vote would be for AuthorizedApp


Feature/Ability UI parser to store format the parsed hero data into a usable format for display

Created AbilityUiParser to create a more usable format for the wiki ability cards
Moved all localization-related logic from AbilitiesParser to AbilityUiParser
Moved most json write calls to the main parser

Is there a particular reason we need english localized output to the ability-ui.json? I would think that just the key to localization is sufficient.
For example, instead of
"Key": "ability_incendiary_projectile",
"Name": "Catalyst",
"Description": "Spew napalm that slows enemy movement and amplifies the damage Infernus does to them.",
I would recommend
"Key": "ability_incendiary_projectile", (up to you if this is still needed)
"Name": "ability_incendiary_projectile",
"Description": "ability_incendiary_projectile_desc"
This would have it follow the same format as hero-data.json's hero_key's WeaponName, WeaponDescription, Lore, Role, Playstyle, keys in WeaponTypes, etc.
Alternatively we can alter this slightly so it follows hero-data's pattern of allowing searching for an ability-ui object using a function similar to Module:HeroData's get_json_item, i.e., retrieve ability ui card with name "Catalyst" instead of "Infernus", "1".
For this we would want:
"NameKey": "ability_incendiary_projectile", (key for localizing name)
"Name": "Catalyst", (searchable by get_json_item)
"DescriptionKey": "ability_incendiary_projectile_desc", (key for localizing description)
To expand on this idea; you would use "XKey" for all localizable content other than the Ability's actual name, as thats realistically the only object we might want to be able to use get_json_item on.
Before simply appending _desc to the NameKey to get DescriptionKey, you may want to ensure its fully correct similar to attributes.py's _map_to_unlocalized which locates a key in any of the ways they exist. This part may not be needed if the key is 100% consistently just appending _desc.

Added loop to run ui parser for every language, writing any localization updates to their relevant file. This means any complex string regex replacements are run once on the backend


fix: update favicon

Summary

Related to https://discord.com/channels/955773041898573854/1030773050217615440/1282255908466069545
Update favicon to use the zap logo
How to test

Go to http://localhost:8080/
It should show the zap logo as favicon on all pages (excluding spaces page)

Check new favicon in sx-ui channel

Check new favicon in sx-ui channel

updated


docs: add a tip on using appear attribute and v-on:appear hook

Based on issue #9320 in the issue list of vue, I added a tip to clarify the usage of appear attribute and v-on:appear hook.

Looks good now, thanks!


Add Docker Compose deployment

Hello, we have added a Docker Compose configuration file for easy deployment of Attack Flow, along with a corresponding deployment test in a GitHub action.
We updated the README with instructions, not sure that is the proper place for that.

Hi @banzo thank you for the contribution. We typically don't release a docker compose file for projects with a single container. Can you elaborate on your motivation for creating a docker compose file so that I can better understand the need? Thanks--

Hi @banzo thank you for the contribution. We typically don't release a docker compose file for projects with a single container. Can you elaborate on your motivation for creating a docker compose file so that I can better understand the need? Thanks--

The docker-compose file can be used for a Docker Swarm deployment.
I find it also quite convenient compared to the Docker command line that becomes rapidly cumbersome (when mounting volumes for example).
We actually started building a Helm chart and an OpenShift Operator that would maybe be more useful, but in the end we had to go back to this simple docker-compose that currently fits our needs.

Ok, thanks for the explanation! I haven't used Swarm but it sounds like hosting a docker compose in this repo would be useful. In general I view the compose file as a suggestion and expect a lot of users will end up customizing their own version of it, so the feedback I left on the PR is aligned with that generalized usage. Once that's addressed I will merge it in.


Watcher exponential backoff + jitter

The watcher functions in internal/statestorage/redis/redispb/matchobject.go and internal/statestorage/redis/redispb/player.go are both currently 'query every 2 seconds' and are going to generate a lot of the overall redis load on OM.  It would be better to have them set up with (configurable) exponential backoff & jitter.  There are a few implementations of exp bo + jitter as golang modules, we need someone to evaluate them and then test the one we pick.

This will be included in 0.4.0 scheduled for late Feb 2019.


Poping empty stash should not be possible

If the git' stash is empty, the button to pop should be empty to avoid confusion.
Also, the error message contains 2 times the "No stash found" line.
Error: Command failed: git stash pop
No stash found.
No stash found.

Disabling versionning panel #205 .
Since atom is doing a git integration in 1.18, we  don't need it anymore.


chore: upadted and fixed plan.md

close our eyes?
will it almost feel like nothing changed at all

yeah because this is still named upadted

https://canary.discord.com/channels/980412957060137001/1011621831335235625/1015686262226694215

upadted

upadted

LGTM

D4M

So they say
Dance for me, dance for me, dance for me, oh, oh, oh
I've never seen anybody do the things you do before
They say move for me, move for me, move for me, ay, ay, ay
And when you're done I'll make you do it all again

I wanna just dance, but he took me home instead
Uh-oh, there was a monster in my bed


dataTable的on-load能不能不要冒泡

Clear and concise description of the problem
on-load事件冒泡，导致触发了我自定义的行点击事件
Suggested solution
建议默认不要冒泡
Alternative
No response
Additional context
No response
Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

You should make some judgments in your custom click event


Suggest: console progress bar

We have a progress bar for the UI.
A simple console based progress bar could be implemented as well
See java example:
http://nakkaya.com/2009/11/08/command-line-progress-bar/

Closing this for now.   The primary use of the CLI seems to be as a point of integration with IDEs.  This is would muddy that unnecessarily.


Add HTTP caching.

Should solve #170

[x] Deploy new cache changes (remove Expires, add ETag revalidation) on the API side for the projects list
[ ] Support ETag-based HTTP caching on the API side for environments
[ ] Write upgrade hook for moved session info

Questions:

where do we best store session data and the cache? I chose ~/.platformsh/session.yml and ~/.platformsh/cache, both removed on logout

Closing as cache options are built into the client library which will be used in v2 (#241)


Publication of Railflow for TestRail plugin

Repository URL
https://github.com/railflow/railflow_jenkins_plugin
New Repository Name
railflow-testrail-plugin
Description
Railflow provides a set of command line tools for integrating testing tools and resulting reports with TestRail.
This plugin allows you to easily integrate Jenkins testing jobs with TestRail and automatically export all testing reports to TestRail using the Railflow CLI tools. Aggregating result from all your Jenkins jobs into TestRail allows teams to look at test trends, auto-assign failures via Railflow automation, create link between Jenkins and TestRail, and much more.
GitHub users to have commit permission
railflow
sergey-oplavin
tharindud
Jenkins project users to have release permission
railflow
Issue tracker
Jira

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.
Commands
The bot will parse all comments, and it will check if any line start with a command.
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.29.6)

:x: Jenkins Security Scan failed.
The Security team was notified about this.

/hosting re-check

The requested change to replace prototype syntax with fetch API has been done. Changes have been pushed to master branch.

@mawinter69 Please note. The requested changes have been done.

Create a .mvn folder within the repository root containing the following files: https://github.com/jenkinsci/archetypes/tree/master/common-files/.mvn
Create a .github folder within the repository root with the following files and subdirectories: https://github.com/jenkinsci/archetypes/tree/master/common-files/.github
Replace ${artifactId} where needed
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L12 this should either be 1.0 or 0.1
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L16-L19 should be inlined into index.jelly
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L48 Instead of shading commons-lang3 yourself, add the Jenkins bom: https://github.com/jenkinsci/bom#usage and depend on the commons-lang3 Jenkins plugin: https://plugins.jenkins.io/commons-lang3-api/dependencies/
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L57-L61 same like above: https://plugins.jenkins.io/gson-api/dependencies/
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L92-L132 is obsolete and already specified in the parent pom
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L135-L137 should reflect the final destionation, like jenkinsci/<yourChosenRepoName>
https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L138 should be <tag>${scmTag}</tag>
Add a Jenkinsfile with the following content: https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile
https://github.com/railflow/railflow_jenkins_plugin/tree/master/src/main/java/io/railflow Move classes and files to io.jenkins.plugins:railflow-testrail matching your chosen destination in the pom
Your plugin doesn't compile via mvn clean verify package, which is needed in order to build it on our infra

isn't guava provided by core? https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L63-L67
same for commons-codec: https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L52-L56
Afaik there are no library plugins for them (yet)
replace usages of javax.validation.constraints.NotNull with edu.umd.cs.findbugs.annotations.NonNull  and remove the dependency to javax.validation at https://github.com/railflow/railflow_jenkins_plugin/blob/ac837c2c45fe1f730e398507cdb6fbff22f2f188/pom.xml#L72-L76

@NotMyFault @mawinter69 All requested changes have been made and pushed to master branch.

@NotMyFault @mawinter69 All requested changes are done and pushed to master. Please check.

https://github.com/railflow/railflow_jenkins_plugin/blob/3c7ffea0b3cda56e0713432e6c0c6107ec3842fb/src/main/resources/io/jenkins/plugins/railflow/jenkins/admin/GlobalConfig/config.jelly#L14 and L30 make use of onclick . This is inline javascript and not CSP compliant. See https://www.jenkins.io/doc/developer/security/csp/ how to avoid inline javascript

https://github.com/railflow/railflow_jenkins_plugin/blob/3c7ffea0b3cda56e0713432e6c0c6107ec3842fb/src/main/resources/io/jenkins/plugins/railflow/jenkins/admin/GlobalConfig/config.jelly#L13 replace with
<button type="button" class="jenkins-button validate-button" name="activateLicense">${%activateLicenseButton}</button>
Same for line 28
Some nitpicking
replace https://github.com/railflow/railflow_jenkins_plugin/blob/3c7ffea0b3cda56e0713432e6c0c6107ec3842fb/src/main/resources/io/jenkins/plugins/railflow/jenkins/admin/GlobalConfig/config.jelly#L17 with <l:spinner/>, same for line 33 (See https://weekly.ci.jenkins.io/design-library/Progress/)

/hosting re-check

Is https://github.com/railflow/railflow_jenkins_plugin/blob/3c7ffea0b3cda56e0713432e6c0c6107ec3842fb/pom.xml#L80-L83 used for anything, and if so, what?

https://github.com/railflow/railflow_jenkins_plugin/blob/3c7ffea0b3cda56e0713432e6c0c6107ec3842fb/pom.xml#L80-L83 is unused. Will remove it.

/hosting re-check

@mawinter69 @daniel-beck All requested changes have been pushed to master.

/hosting re-check

Any update on this guys?

Can you guys take a look at the changes and get this published please? Let me know if there any more changes required. Thanks.

/hosting re-check

The URL should point to your GitHub repository: https://github.com/railflow/railflow_jenkins_plugin/blob/master/pom.xml#L16C10-L16C48 - https://github.com/jenkinsci/railflow-testrail-plugin

/request-security-scan

The Jenkins Security Scan discovered 28 finding(s) :mag:.
For every identified issue, please do one of the following:

Implement the recommended fix to address the issue.
If you think it's a false positive, suppress the warning directly within the code.
Alternative, you write an explanation here about why you think it's irrelevant. That will require a manual review, leading to a slower process.

After addressing the findings through one of the above methods:

If all modifications have been made to the code, please initiate a new security scan by triggering the /request-security-scan command.
If there are any unresolved findings (those not corrected or suppressed), request a review from the Jenkins security team by using the /audit-review command.

Remoting: Unsafe Callable
You can find detailed information about this finding here.
RailflowCallable.java#70
Potentially unsafe Callable implementation RailflowCallable#checkRoles

Stapler: Missing POST/RequirePOST annotation
You can find detailed information about this finding here.
TestRailServerConfig.java#94
Potential CSRF vulnerability: If DescriptorImpl#doCheckTestRailPassword connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

TestRailServerConfig.java#90
Potential CSRF vulnerability: If DescriptorImpl#doCheckTestRailUserName connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

TestRailServerConfig.java#77
Potential CSRF vulnerability: If DescriptorImpl#doCheckTestRailUrl connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

TestRailServerConfig.java#73
Potential CSRF vulnerability: If DescriptorImpl#doCheckName connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#439
Potential CSRF vulnerability: If DescriptorImpl#doCheckRunId connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#428
Potential CSRF vulnerability: If DescriptorImpl#doCheckJiraProjectKey connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#417
Potential CSRF vulnerability: If DescriptorImpl#doCheckMilestonePath connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#406
Potential CSRF vulnerability: If DescriptorImpl#doCheckResultFilePattern connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#395
Potential CSRF vulnerability: If DescriptorImpl#doCheckSearchMode connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#372
Potential CSRF vulnerability: If DescriptorImpl#doCheckTestCasePath connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

RailflowPublisher.java#359
Potential CSRF vulnerability: If DescriptorImpl#doCheckTestRailProjectName connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check
You can find detailed information about this finding here.
TestRailServerConfig.java#94
Potential missing permission check in DescriptorImpl#doCheckTestRailPassword

TestRailServerConfig.java#90
Potential missing permission check in DescriptorImpl#doCheckTestRailUserName

TestRailServerConfig.java#77
Potential missing permission check in DescriptorImpl#doCheckTestRailUrl

TestRailServerConfig.java#73
Potential missing permission check in DescriptorImpl#doCheckName

RailflowPublisher.java#439
Potential missing permission check in DescriptorImpl#doCheckRunId

RailflowPublisher.java#428
Potential missing permission check in DescriptorImpl#doCheckJiraProjectKey

RailflowPublisher.java#417
Potential missing permission check in DescriptorImpl#doCheckMilestonePath

RailflowPublisher.java#406
Potential missing permission check in DescriptorImpl#doCheckResultFilePattern

RailflowPublisher.java#395
Potential missing permission check in DescriptorImpl#doCheckSearchMode

RailflowPublisher.java#372
Potential missing permission check in DescriptorImpl#doCheckTestCasePath

RailflowPublisher.java#359
Potential missing permission check in DescriptorImpl#doCheckTestRailProjectName

Jenkins: Plaintext password storage
You can find detailed information about this finding here.
JiraParametersImpl.java#16
Field should be reviewed whether it stores a password and is serialized to disk: projectKey

JiraParametersImpl.java#15
Field should be reviewed whether it stores a password and is serialized to disk: token

TestRailParametersImpl.java#17
Field should be reviewed whether it stores a password and is serialized to disk: password

ProxySettingsImpl.java#15
Field should be reviewed whether it stores a password and is serialized to disk: password

RailflowCallable.java#27
Field should be reviewed whether it stores a password and is serialized to disk: licenseKeyOrContent

The URL should point to your GitHub repository: https://github.com/railflow/railflow_jenkins_plugin/blob/master/pom.xml#L16C10-L16C48 - https://github.com/jenkinsci/railflow-testrail-plugin

Fixed

/request-security-scan

Fixed

/request-security-scan

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

Can we resume the review and publish this please?

/hosting re-check


[feature] Conditionally compile instructions via feature flags

Need to test some instructions on my program in devnet. Want to hide these instructions from rust SDK unless program's crate is compiled with feature devnet.
Right now, if I try doing this I get all sorts of issues.
For example, if I want to feature gate an instruction on the account compression program like
#[cfg(feature="devnet")]
pub fn init_prepared_tree_with_root(...) -> Result<()> {}

I get the following issues
 Compiling spl-account-compression v0.4.0 (/Users/home/Documents/solana-program-library/account-compression/programs/account-compression)
error[E0425]: cannot find function `init_prepared_tree_with_root` in module `spl_account_compression`
   --> programs/account-compression/src/lib.rs:290:12
    |
290 |     pub fn init_prepared_tree_with_root(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `spl_account_compression`
    |
note: found an item that was configured out
   --> programs/account-compression/src/lib.rs:290:12
    |
290 |     pub fn init_prepared_tree_with_root(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: the item is gated behind the `devnet` feature
    = help: consider importing this function:
            crate::__private::__global::init_prepared_tree_with_root
            ```

This issue already exists (https://github.com/coral-xyz/anchor/issues/2257) and the fix also exists in https://github.com/coral-xyz/anchor/pull/2339. I commented there to see if the author can fix the conflicts, so let's follow it there.


New Dataset: Kaggle-1 Glomerulus Segmentation

Request
Add dataset nodes for a new derived/processed data type corresponding to "Kaggle-1 Glomerulus Segmentation".

The pipeline name is pas_ftu_segmentation.

Results of datasets endpoint in local environment

In Globus


bump the LLVM used by mlir-air

This focuses on the LLVM bump. Mostly related to the SCF ReduceOp changes in https://github.com/llvm/llvm-project/pull/75314
As a follow-up we can bump the mlir-aie used. I just first want to see if this PR actually works (I haven't built and tested succesfully locally).

In utils/clone-llvm.sh the branch used is the 'air' branch. Why is this? When I bump, can I use main?

I suggest bumping mlir-aie at the same time and using the LLVM hash here: https://github.com/Xilinx/mlir-aie/blob/main/utils/clone-llvm.sh#L16.  The llvm version for mlir-aie and mlir-air should match.

In utils/clone-llvm.sh the branch used is the 'air' branch. Why is this? When I bump, can I use main?

It's naming the local branch air so the name is not too important here.


Enhance the user interface of the login page by adjusting the layout of the social media login buttons

Issue no :- #547
This pull request focuses on enhancing the user interface of the login page by adjusting the layout of the social media login buttons. The goal is to create a more user-friendly and visually appealing experience for users attempting to log in via social media accounts.
Key Changes:
Button Alignment:
Adjusted the alignment of the social media buttons to be centrally aligned, providing a more balanced look.
Added consistent spacing between buttons to prevent a cluttered appearance.
Button Styling:
Updated the button styles to match the overall theme of the login page, ensuring that they are visually cohesive with other UI elements.
Implemented hover effects for buttons to enhance interactivity and provide feedback to users.
Responsive Design:
Ensured that the layout is responsive, making it accessible on various devices, including mobile and tablet screens.
Utilized media queries to adjust button sizes and spacing on smaller screens for optimal usability.
Screen shot :-

please merge this pull request

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Remove version: Sogou.SogouInput version <IP_ADDRESS>46

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://ime.sogoucdn.com/sogou_pinyin_<IP_ADDRESS>46.exe
Response Error: The remote server returned an error: (403) Forbidden.
(Automated message - build 910)


[SIL.rst] Add textual examples for some of the pack instructions.

Just writing some tests for the pack instructions and I would have found having a textual SIL example in SIL.rst of how to write them to be useful. Just paying it forward.

@swift-ci smoke test


Spurious error when calling mraa_add_subplatform()?

When attempting to call mraa_add_subplatform(MRAA_GENERIC_FIRMATA, "/dev/ttyACM0") I am getting back a result code 4 however the call appears to actually succeed, and subsequent MRAA calls work as expected.
I am calling from a NUC (platform 3) to an attached Arduino 101.

If you get MRAA_ERROR_INVALID_PARAMETER you need to check syslog, in any case it pretty much guarrantees that the call failed, likely imraa already added the platform so the mraa_add_subplatform call was superfluous?

I will check syslog.
Is there a way I can check to see if imraa has already added the subplatform? I tried calling mraa_get_platform_type() but that returns the NUC that MRAA is running on.
Perhaps mraa_add_subplatform() could return a specific result in the case that imraa has already added the subplatform?

Uhm there is mraa_get_platform_combined_type which if you give the offset should return the firmata firmware version. We had a combined name thing but it turned out to be a bad idea since it's impossible to parse. There is mraa_get_platform_combined_type but it's not exposed via C++ because it's a bit confusing.
We had something like you describe where mraa_init would return MRAA_ERROR_PLATFORM_ALREADY_INITIALISED instead of MRAA_SUCCESS when already initialised but turned out that was really hard to parse/understand and very error prone. But probably mraa_add_subplatform should return MRAA_SUCCESS if a platform is already there and used just like mraa_init silently succeeds. Does that make sense?

"But probably mraa_add_subplatform should return MRAA_SUCCESS if a platform is already there and used just like mraa_init silently succeeds."
Yes, please. That is the behavior I expected, and the MRAA_ERROR_INVALID_PARAMETER confused me into thinking that my param was bad somehow, and not realizing for a while that the subplatform was already available.

Done with 980dfce80ed5ee5f2244aaf434d0ef29a5e6babc - if there is a GENERIC_FIRMATA subplatform already present it will return MRAA_SUCCESS, if another subplatform is present you will get MRAA_ERROR_FEATURE_NOT_SUPPORTED and in all other cases MRAA_ERROR_INVALID_PARAMETER


added --no-bump option for deploy

To support external version management, bumping of version can be disabled using flag --no-bump.

@MartinWeindel looks like the check for CLA is passed, but the block is due to missing reviewer. Let's see if we can push this through today.


Fix a bug where two CreateJob for the same job can race

Fix a bug where two CreateJob for the same job can race such that a job thinks it has twice the chunks it actually has, therefore it can never be completed.
This is not the most elegant fix, but it's the most low-friction fix.  Ideally we'd fix this by fixing #1192.

I'm not sure when two CreateJobs would be called for the same job. Can you give an example of a scenario where this might happen?
I want to understand the race, but to do that, I think I need to have that context.
Based on the code you updated, I'm guessing that the race is in the jobManager wait loop ... and if its called twice for the same job, one manager could see two creation changes and think it needs two chunks. Instead you determine the # of chunks not from the change feed, making it not racy.
Still, I want to understand the situation where the job is created twice.

@sjezewski yeah basically it happens when two nodes both think they are responsible for a pipeline, i.e. that they both run the runPipeline goro for the same job.  Then when a new commit triggers the pipeline, they both call CreateJob, thus the race.

Cool. LGTM


Searchable fixture tree

Closes #39

@skidding this PR is not ready for CR since I didn't wrote the tests (TDD for the win) 🍧 But you can comment out on the styles, maybe we can change something.

If you haven't already, try to see how it looks to have the input take up the entire space .filter-input-container is taking now (in other words no margin around input). Might give it a more minimal look, but might also be less intuitive. Looking great either way! 👯

@skidding please review
normal state:

focus state:

if the release is not working please do the following
git push origin v0.4.1; git push origin --tags

Looks good and works like a charm.
Did you consider searching through the component names as well? It might be weird, but I think it might be more common to search for a component than for a specific fixture name. Wdyt?

@skidding please review. I've added fuzzysearch, I hope you like it and find it useful. Thanks

Beautiful! 🌹


Correct the name from openvpn to dockvpn

Just a quick fix to the docs.

By the way, thanks your work on this. Hands down the easiest OpenVPN docker image to quickly get up and running.

Oh, good catch! Thank you. And thanks for your kind words and feedback!


README.md change to add all new contributors

Describe the content

Add new contributors to the repository's README.md

If possible I would like this activity to be assigned to me

Can I work on this? Can you assign it to me?

Should i make a workflow to update readme regularly on a specific interval?

but What is the issue? in which file? I am totally new to this so can you help me little

Everything is ok. Just contributors' profiles are updated in the README.md file with a delay of 1 or 2 days delay.
We think to make it faster like real-time updates when new contributors add to this project, it should also display in the README.md file consecutively.

@crescentpartha, I was studying ways to make these changes automatically and I found the github api, but I still can't use it and I'm not sure if it's due to something that has to be configured in the repository. Could you take a look?
https://docs.github.com/pt/rest/collaborators/collaborators#list-repository-collaborators


Add docker suitable for projects created from archetype

Dockerfile was created for archetype: so it's automatically created for all projects from archetype


getting VideoIter:: ERROR!!

Getting below error when running feature_extractor notebook.Same Getting same error when executing feature_extractor.py in windows environment
2020-12-24 06:41:50,683 VideoIter:: ERROR!! (Force using another index:
154)
torch.Size([0, 1, 1, 3]) x 162020-12-24 06:41:50,683 VideoIter:: ERROR!! (Force using another index:
154)
torch.Size([0, 1, 1, 3]) x 16
2020-12-24 06:41:50,688 VideoIter:: ERROR!! (Force using another index:
154)
torch.Size([0, 1, 1, 3]) x 162020-12-24 06:41:50,697 VideoIter:: ERROR!! (Force using another index:
154)
torch.Size([0, 1, 1, 3]) x 162020-12-24 06:41:50,700 VideoIter:: ERROR!! (Force using another index:
154)
torch.Size([0, 1, 1, 3]) x 16

@RachanaAgarwal
Can you provide more information, like what is the command you run?

Exact error with feature_extractor.py(on windows env) given below(above error is with feature_extractor notebook when running on collab)
command :python feature_extractor.py --dataset_path dataset --pretrained_3d exps/models/c3d.pickle --model_type c3d
--dataset_path dataset is => path to test video( just have single video Robbery_test_056_x264.mp4 ) for feature extraction
--num_workers ==> 4 as I was getting a paging error
python feature_extractor.py --dataset_path dataset --pretrained_3d exps/models/c3d.pickle --model_type c3d
2020-12-24 15:10:35,522 Loading feature extractor from exps/models/c3d.pickle
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
WARNING:root:VideoIter:: ERROR!! (Force using another index:
69)
not enough values to unpack (expected 2, got 1)
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
WARNING:root:VideoIter:: ERROR!! (Force using another index:
4)
not enough values to unpack (expected 2, got 1)
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
WARNING:root:VideoIter:: ERROR!! (Force using another index:
167)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
132)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
9)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
26)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
136)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
29)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
114)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
36)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
147)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
164)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
29)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
76)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
42)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
94)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
37)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
18)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
86)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
101)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
86)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
132)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
171)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
14)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
136)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
101)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
54)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
139)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
166)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
154)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
126)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
158)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
20)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
66)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
28)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
34)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
170)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
2)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
137)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
153)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
46)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
82)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
65)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
115)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
53)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
131)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
164)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
143)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
29)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
132)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
5)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
3)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
131)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
101)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
142)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
142)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
155)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
168)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
151)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
92)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
22)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
112)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
5)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
132)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
52)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
62)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
126)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
94)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
72)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
140)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
137)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
95)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
40)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
77)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
63)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
80)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
130)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
120)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
22)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
138)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
132)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
94)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
111)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
29)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
58)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
2)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
135)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
69)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
104)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
43)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
156)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
155)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
95)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
23)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
44)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
163)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
9)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:

The script expects the data to be the same as the dataset, i.e. a directory containing some hierarchy. Please try passing a path to a directory for --dataset_path

yes, it's the path to the directory. Please let me know what exactly need to be done
Directory of  \AnomalyDetectionCVPR2018-Pytorch-master\dataset
which has this file
26-03-2020  08:23        18,125,482 Robbery_test_056_x264.mp4.mp4

@RachanaAgarwal
I created a new branch called debug_video_loader. This adds the line number of the exception in the warning message. Can you checkout this branch, run the code, and tell me the warning then?

@ekosman  Please find new logs
python feature_extractor.py --dataset_path dataset --pretrained_3d exps/models/c3d.pickle --model_type c3d
2020-12-25 10:36:52,041 Loading feature extractor from exps/models/c3d.pickle
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
WARNING:root:VideoIter:: ERROR!! (Force using another index:
36)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
36)
not enough values to unpack (expected 2, got 1)
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
WARNING:root:VideoIter:: ERROR!! (Force using another index:
21)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
21)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
128)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
128)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
149)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
149)
not enough values to unpack (expected 2, got 1)
C:\Users\racha.conda\envs\adCVPR18\lib\site-packages\torchvision\io\video.py:116: UserWarning: The pts_unit 'pts' gives wrong results and will be removed in a follow-up version. Please use pts_unit 'sec'.
"The pts_unit 'pts' gives wrong results and will be removed in a "
WARNING:root:VideoIter:: ERROR!! (Force using another index:
91)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
91)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
61)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
61)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
100)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
100)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
25)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
25)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
84)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
84)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
17)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
17)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
2)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
2)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
40)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
40)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
40)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
40)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
129)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
129)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
118)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
118)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
157)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
157)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
10)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
10)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
121)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
121)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
11)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
11)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
164)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
164)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
143)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
143)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
53)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
53)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
51)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
51)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
74)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
74)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
159)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
159)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
11)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
11)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
80)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
80)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
63)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
63)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
138)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
138)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
165)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
165)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
64)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
64)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
85)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
85)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
149)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
149)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
135)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
135)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
120)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
120)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
110)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
110)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
56)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
56)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
54)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
54)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
33)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
33)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
153)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
153)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
20)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
20)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR!! (Force using another index:
89)
not enough values to unpack (expected 2, got 1)
WARNING:root:VideoIter:: ERROR (line number 71 !! (Force using another index:
89)
.
.
.
.
.

@RachanaAgarwal
I'm unable to recreate this bug.
I created a new directory containing one file:
F:\anomaly_data\videos\test\Arrest006_x264.mp4.mp4
I run this command without any error:
python feature_extractor.py --dataset_path "F:\anomaly_data\videos\test" --pretrained_3d C:\Users\eitan\PycharmProjects\AnomalyDetectionCVPR2018-Pytorch\pretrained\c3d.pickle --model_type c3d

@ekosman
The feature extractor is now working with the latest code changes in the master. Thanks for the update and support

@RachanaAgarwal
Great. May I close this?

@ekosman When I gave a list of videos(7-8 ranging from 2 to 15 mins ) for feature extraction in between I get below logs
followed by normal dumping features logs
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
2200)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
2104)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
4424)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
495)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
4205)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
770)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
2460)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
4829)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
208)
torch.Size([0, 1, 1, 3]) x 16
2020-12-26 00:37:17,037 Video 35 / 9 : Writing clip 1130 of video break_4
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
4236)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
1568)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
3493)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
3744)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
697)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
3906)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
112)
torch.Size([0, 1, 1, 3]) x 16
WARNING:root:VideoIter:: ERROR (line number 75) !! (Force using another index:
20)
torch.Size([0, 1, 1, 3]) x 16

@RachanaAgarwal
Are all the video files valid?

Yes all the videos files are valid

@RachanaAgarwal
Can you share the files? I want to see if I can reproduce this.

Sorry, can't share the video files. Please try with any long videos

@ekosman
Getting below error when running TrainingAnomalyDetector_public.py.
File "TrainingAnomalyDetector_public.py", line 96, in
save_every=20000)
File "C:\old_laptop\paralaxiom\AnomalyDetectionCVPR2018-Pytorch-master\network\TorchUtils.py", line 118, in fit
epoch=epoch)
File "C:\old_laptop\paralaxiom\AnomalyDetectionCVPR2018-Pytorch-master\network\TorchUtils.py", line 177, in do_epoch
batch = self.data_to_device(batch, self.device)
File "C:\old_laptop\paralaxiom\AnomalyDetectionCVPR2018-Pytorch-master\network\TorchUtils.py", line 219, in data_to_device
data = data.to(device)
AttributeError: 'str' object has no attribute 'to'
command
python TrainingAnomalyDetector_public.py --features_path anomaly_features --annotation_path Train_Annotation.txt
anomaly_features=> Directory having pre-computed features downloaded from https://drive.google.com/drive/folders/1rhOuAdUqyJU4hXIhToUnh5XVvYjQiN50?usp=sharing

@ekosman Any help to resolve the above issue is much appreciated

@RachanaAgarwal I have some important deadlines soon so I won't be able to take care of it in the coming weeks. I'll keep this as a reminder anyway.

@ekosman
Getting below error when running TrainingAnomalyDetector_public.py.
File "TrainingAnomalyDetector_public.py", line 96, in
save_every=20000)
File "C:\AnomalyDetectionCVPR2018-Pytorch-master\network\TorchUtils.py", line 118, in fit
epoch=epoch)
File "C:\AnomalyDetectionCVPR2018-Pytorch-master\network\TorchUtils.py", line 177, in do_epoch
batch = self.data_to_device(batch, self.device)
File "C:\AnomalyDetectionCVPR2018-Pytorch-master\network\TorchUtils.py", line 219, in data_to_device
data = data.to(device)
AttributeError: 'str' object has no attribute 'to'
command
python TrainingAnomalyDetector_public.py --features_path anomaly_features --annotation_path Train_Annotation.txt
anomaly_features=> Directory having pre-computed features downloaded from https://drive.google.com/drive/folders/1rhOuAdUqyJU4hXIhToUnh5XVvYjQiN50?usp=sharing

help me


Added Äru Svensk easter egg.

OMG yes! Could you resolve this so i can merge it now?!

I think I dit it right. Newbie here 😃

Looks right to me 😉


SARAALERT-NONE: Bundle Audit Fixes

Description
Bundle audit fixes and rubocop
Checklists
Submitter:

[x] This PR describes why these changes were made.
[x] This PR is into the correct branch.
[ ] This PR includes the correct JIRA ticket reference.
[ ] Comment added to the relevant JIRA ticket(s) with a link to this PR
[x] Code diff has been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[ ] If UI changes have been made, Chrome Dev Tools Lighthouse accessibility test has been executed to ensure no 508 issues were introduced.
[ ] Tests are included and test edge cases
[x] Tests have been run locally and pass (remember to update Gemfile when applicable)
[ ] Test fixtures updated and documented as necessary

@tstrass :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions
[ ] Tested all recommendations listed in the "Testing Recommendations" section. The application behaves as expected with this PR.

@timwongj :

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code
[ ] If applicable, you have tested changes against a large database, and considered possible performance regressions
[ ] Tested all recommendations listed in the "Testing Recommendations" section. The application behaves as expected with this PR.

This does a lot of updates that aren't necessary for audit. Did you do a bundle update? Let's keep it simple/safe and just bundle update rails instead.

good call: https://github.com/SaraAlert/SaraAlert/pull/1237/commits/561121d890614fb46745285894b54dfc9576b9fe


getting 2ch stereo output m4a instead of multichannel for 360RA

am I doing something wrong? How do I get the 8 or 12 channels?

this is from MediaInfo:
General
CompleteName : C:\Users*****\Music\Justin Timberlake\Everything I Thought It Was [350639046] [2024]\14 - What Lovers Do [360].m4a
Format/String : iso8
CodecID/String : iso8 (mp41/dash/cmfc)
FileSize/String : 2.78 MiB
Duration/String : 3 min 42 s
OverallBitRate_Mode/String : Constant
OverallBitRate/String : 105 kb/s
Cover : Yes
Audio
ID/String : 1
Format/String : AAC LC SBR
Format/Info : Advanced Audio Codec Low Complexity with Spectral Band Replication
Format_Commercial_IfAny : HE-AAC
Format_Settings : NBC
CodecID : enca-40 / mp4a-5
Duration/String : 3 min 42 s
BitRate_Mode/String : Constant
BitRate/String : 96.0 kb/s
Channel(s)/String : 2 channels
ChannelLayout : L R
SamplingRate/String : 44.1 kHz
FrameRate/String : 21.533 FPS (2048 SPF)
Compression_Mode/String : Lossy
StreamSize/String : 2.55 MiB (92%)
Encryption : Encrypted
ConformanceErrors : 1
Crosscheck : Yes
CMAF : Yes
channelConfiguration : CMAF does not permit USAC UsacConfig channelConfigurationIndex 0, permitted values are 1 and 2

@tcafranz thank you for having raised an issue! You're the first person to have raised an issue to do with the Sony 360 RA format, so I haven't looked at it in a while. What should happen is that the track(s) is/are downloaded as a .mka file...
From the mediainfo output, that track is a regular old AAC stereo audio, not Sony 360 RA. What was the command that you used for this track? If you want to try again, it should be
$ tidal-wave https://listen.tidal.com/album/350639046 --audio-format 360 --loglevel debug

If you execute that, could you get the logs and add it as a file to your response here on GitHub?

PowerShell 7 (x86)_tidal-wave 360RA debug.txt
yea I don't even know where to start with all this but here you go. Appreciate the help. I've managed to get Dolby Atmos 6 channels just fine but never had any success with 360RA until yesterday when I actually got it to download SOMETHING.

😭 I only have apple or windows to get access token from.... ughhhh... yes I have ffmpeg I don't know why it's saying I don't. I wouldn't suppose you'd be kind enough to grab that album for me (well for my wife).  🫤

@tcafranz if you have no Android devices, it's possible to use something like BlueStacks to get an Android virtual machine on your Windows host, but I haven't done that...

@ebb-earl-co thanks ill check it out.


Add buy me a coffee hover button

hover button on the bottom right corner that stays till while scrolling.

Hi, @Sayak-Bhunia , I will work on this if you want .
I am a Fullstack developer with strong proficiency in NextJs as well as Javascript .
You can visit my portfolio website which is created in NextJs. https://kapilbadokar.vercel.app/
Please Assign this issue  to me.
Best Regards.
Kapil

the issue is assigned to you.
do star the repo.
and send a design before implementing.

any updates ?

any updates ?

Hi @Sayak-Bhunia ,
Will begin the working shortly.
The task will be completed by midnight.
Thanks for understanding.
Best Regards.
Kapil

Do you want it like this

It is fixed on the bottom of screen, and is completely visible while scrolling
Also responsive on the mobile.
When the user clicks , hes redirected to the buymeacoffee profile page of yours, which you will add.

https://www.buymeacoffee.com/sbhunia2909 this is my buymeacoffe account add this link to the button and can you make the button round like only the coffee icon will be visible.

I have completed it .

Updated it with your profile url.
Made the icon circle.
Added hover and on-Click effects

Hi @Sayak-Bhunia,
Also mark this issue as completed.
It was great collaborating to your projects.
If there are any more similar issues.
Do assign it to me.
Thanks.
Best Regards
Kapil


forward imports to non-coordinator shards

Overview
This PR forwards translated import requests to the correct shard based on columnID provided or translated columnKey (see bug description in #1715).
Fixes #1715
Pull request checklist

[x] I have read the contributing guide.
[x] I have agreed to the Contributor License Agreement.
[x] I have updated the documentation.
[x] I have resolved any merge conflicts.
[x] I have included tests that cover my changes.
[x] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

@jaffee I updated this based on your comments and rebased with master.


Song does not play when disabling autoplay

Chromium x64 version 62.0.3202.89 on Arch Linux 4.13.11
Chromium has a great hidden feature in chrome://flags that allows to disable autoplay, when setting the Autoplay policy flag to Document user activation is required and restarting. But the music on this app does not start playing, and the following warning is shown in the developer tools :
An AudioContext in a cross origin iframe must be created or resumed from a user gesture to enable audio output. (Song @ bundle.js:14055)
If possible, there should be a way to start it manually, or at least to detect that autoplay is disabled and ask the user to enable it.

I am sure it's possible. But using the Chrome flags, which are experimental features, is an extreme edge case. Not sure if devs on this project have time for those kind of edge cases. If you want you could submit a pull request with the fix!

Doesn't mobile Chrome do this by default?


GUI: Multiple instances when selecting settings

Right click on try icon
Chose settings
Repeat 1&2

actual:
If you open settings several times, you get several identical settings instances, but only the most recent setting instance is interactable until closed.

expected:
There is always just one instance of settings and previous instance gets focused as active window when user choses 'settings' at the tray icon.
Version SyncTrayzor: 1.1.24
Version Syncthing: v1.3.2
Version OS: Windows 8.1 Pro N

Thanks!


Add Sally to sigstore-oncall

Summary
Add Sally to sigstore-oncall as discussed on Slack. IIUC, this PR is the appropriate way to add her to the repos where she can being to read about how to start the onboarding process.
Release Note
n/a
Documentation
n/a

@sallyom

cc @bobcallaway @priyawadhwa @trevrosen

I would be honored to serve as SRE for the public instance of Sigstore and I'm fully prepared to commit and dedicate the time required! Thanks for considering me.


Tables not working

Describe the bug
My markdown containing table does not convert to table in docx.
To Reproduce
import { unified } from "unified";
import markdown from "remark-parse";
import docx from "remark-docx";
import { saveAs } from "file-saver";

const processor = unified().use(markdown).use(docx, { output: "blob" });

export const saveMessage = async () => {

  const html = `
| Column 1 |Column 2| Column 3 |
| -------- |--------| -------- |
| Row 1    | Data     | Data   |
| Row 2    | Data     | Data   |
| Row 3    | Data     | Data   |
`
  const doc = await processor.process(html);
  const blob = await doc.result as Blob;
  saveAs(blob, "example.docx");
}

saveMessage()

The example.docx file

Same string in the playground

Expected behavior
To be a table in the docx.
Additional context
"remark-docx": "^0.1.6"
"file-saver": "^2.0.5"

Table is not included in CommonMark spec so you can't parse table with remark-parse.
You have to setup remark-gfm like:
import { unified } from "unified";
import markdown from "remark-parse";
import gfm from "remark-gfm";
import docx from "remark-docx";

const processor = unified().use(markdown).use(gfm).use(docx, { output: "blob" });


Invert the colors for the chapter title

The chapter title should be gray text on a white background. This is more standard for a book. At the very least, this should be the behavior if the publication-type attribute is set to book (which is the default). If we want to keep the inverted colors for other publication types, then we'll need to add the publication-type to the body as a CSS class.

Use the following colors:

background: don't set
main title (when there's a subtitle): 666665
subtitle (or main title when there's no subtitle): 333332
bottom border: 666665

We might need to provide a different default avatar as well.


Java seems to have no optional version.

Thanks for your feedback. You can use vfox update java to update to latest version that fix this issue.