[full-ci] bump reva

ocis CI test run for https://github.com/cs3org/reva/pull/4741
Fixes https://github.com/owncloud/ocis/issues/9498
Fixes https://github.com/owncloud/ocis/issues/9399

@butonic I'll take this over. I need a reva bump too

Still failing tests.
E2E test fails because the default for an archive is now "zip"
1) Scenario: download space (attempt 1, retried) # tests/e2e/cucumber/features/spaces/downloadSpace.feature:6
   ✔ Before # tests/e2e/cucumber/environment/index.ts:44
   ✔ Given "Admin" creates following users using API # tests/e2e/cucumber/steps/api.ts:7
       | id    |
       | Alice |
       | Brian |
   ✔ And "Admin" assigns following roles to the users using API # tests/e2e/cucumber/steps/api.ts:19
       | id    | role        |
       | Alice | Space Admin |
   ✔ And "Alice" logs in # tests/e2e/cucumber/steps/ui/session.ts:45
   ✔ And "Alice" creates the following project spaces using API # tests/e2e/cucumber/steps/api.ts:167
       | name | id     |
       | team | team.1 |
   ✔ And "Alice" creates the following folder in space "team" using API # tests/e2e/cucumber/steps/api.ts:221
       | name        |
       | spaceFolder |
   ✔ And "Alice" creates the following file in space "team" using API # tests/e2e/cucumber/steps/api.ts:181
       | name                  | content    |
       | spaceFolder/lorem.txt | space team |
   ✔ And "Alice" navigates to the project space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:37
   ✖ When "Alice" downloads the space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:209
       Error: expect(received).toContain(expected) // indexOf

       Expected substring: "download.tar"
       Received string:    "download.zip"
           at Proxy.<anonymous> (/drone/src/webTestRunner/node_modules/.pnpm/playwright@1.44.1/node_modules/playwright/lib/matchers/expect.js:177:37)
           at World.<anonymous> (/drone/src/webTestRunner/tests/e2e/cucumber/steps/ui/spaces.ts:215:32)
   - And "Alice" adds following users to the project space # tests/e2e/cucumber/steps/ui/spaces.ts:85
       | user  | role     | kind |
       | Brian | Can edit | user |
   - And "Alice" logs out # tests/e2e/cucumber/steps/ui/session.ts:58
   - And "Brian" logs in # tests/e2e/cucumber/steps/ui/session.ts:45
   - And "Brian" navigates to the project space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:37
   - When "Brian" downloads the space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:209
   - And "Brian" logs out # tests/e2e/cucumber/steps/ui/session.ts:58
   ✔ After # tests/e2e/cucumber/environment/index.ts:112

API test fails with other issue.
  @issue-1755
  Scenario: sharer uploads a file with checksum and as a sharee overwrites the shared file with new data and invalid checksum                                                                                # /drone/src/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature:364
    Given user "Alice" has created a new TUS resource for the space "Personal" with content "" using the WebDAV API with these headers:                                                                                # SpacesTUSContext::userHasCreatedANewTusResourceForTheSpaceUsingTheWebdavApiWithTheseHeaders()
      | Upload-Length   | 16                        |
      | Upload-Metadata | filename dGV4dEZpbGUudHh0 |
      | Tus-Resumable   | 1.0.0                     |
    And user "Alice" has uploaded file with checksum "SHA1 c1dab0c0864b6ac9bdd3743a1408d679f1acd823" to the last created TUS Location with offset "0" and content "original content" via TUS inside of the space "Personal" using the WebDAV API # SpacesTUSContext::userHasUploadedFileWithChecksumToTheLastCreatedTusLocationWithOffsetAndContentViaTusInsideOfTheSpaceUsingTheWebdavApi()
    And user "Alice" has sent the following resource share invitation:                                                                                # SharingNgContext::userHasSentTheFollowingResourceShareInvitation()
      | resource        | textFile.txt |
      | space           | Personal     |
      | sharee          | Brian        |
      | shareType       | user         |
      | permissionsRole | File Editor  |
    When user "Brian" overwrites recently shared file with offset "0" and data "overwritten content" with checksum "SHA1 fe990d2686a0fc86004efc31f5bf2475a45d4906" via TUS inside of the space "Shares" using the WebDAV API with these headers: # SpacesTUSContext::userOverwritesRecentlySharedFileWithOffsetAndDataWithChecksumViaTusInsideOfTheSpaceUsingTheWebdavApiWithTheseHeaders()
      | Upload-Length   | 19                        |
      | Upload-Metadata | filename dGV4dEZpbGUudHh0 |
      | Tus-Resumable   | 1.0.0                     |
    Then the HTTP status code should be "460"                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
      HTTP status code 204 is not the expected value 460
      Failed asserting that 204 matches expected '460'.
    And for user "Alice" the content of the file "/textFile.txt" of the space "Personal" should be "original content"                                                                                # SpacesContext::checkFileContent()


cassandra: add a way to disable compression

We write mostly individual datapoints so we really don't need compression.

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Arithmetic

Currently, qdbp uses 63 bit integer arithmetic, much like ocaml. Should we keep it? If so, should there be runtime safety checks(overflow checking, etc)? If not, should we switch to bignums? And what should we do about floats

63 bit integers are by far the most performant option, especially because they can fit in a pointer so don't need to be reference counted. But they can lead to subtle bugs that would be unacceptable. So the two options are switch to GMP based bignums or have checked 63 bit arithmetic

Switched to checked 63 bit signed arithmetic


Re-evaluate OpenFeature file naming

While working on #72, I encountered a rule violation around spec naming. I believe this was because the files were named openfeature while the constant we're defining is OpenFeature. In addition to violating the rule, this naming convention is surprising, and I'd expect the files to be named open_feature. This would also be an issue if we switched to the Zeitwerk autoloader.
I'm curious about the naming choice and if we'd be open to renaming, especially while we do not have a major version.

Our naming conventions say both open feature and openfeature are acceptable (one vs two words). The casing should really match whatever the language/packaging idioms recommend.
As we aren't yet at a 1.0, this is a good time to make breaking changes (if needed). I won't weigh in on what specifically is more "rubyesque".

Created #90 to address the file change!
One last thing would be renaming the entire package. Currently, it's openfeature-sdk, which isn't too wild. The only thing we might consider is renaming to open_feature-sdk and pointing those older packages to the new one.


autoscaling.keda.sh/paused-replicas Automatic scaling was not restored after test deletion in 1.8.2

Report
autoscaling.keda.sh/paused-replicas Automatic scaling was not restored after test deletion in 1.8.2
Expected Behavior
autoscaling.keda.sh/paused-replicas Automatic scaling was restored after test deletion in 1.8.2
Actual Behavior
autoscaling.keda.sh/paused-replicas Automatic scaling was not restored after test deletion in 1.8.2
Steps to Reproduce the Problem
1.kubectl apply --server-side -f https://github.com/kedacore/keda/releases/download/v2.8.2/keda-2.8.2.yaml
2.add  annotations autoscaling.keda.sh/paused-replicas: '11'
3.delete annotations autoscaling.keda.sh/paused-replicas: '11'
4.hpa maxReplicaCount and minReplicaCount not change
Logs from KEDA operator
example

KEDA Version
< 2.11.0
Kubernetes Version
Other
Platform
None
Scaler Details
cron
Anything else?
$ kubectl version
Client Version: v1.29.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.21.1
WARNING: version difference between client (1.29) and server (1.21) exceeds the supported minor version skew of +/-1

kubectl apply --server-side -f https://github.com/kedacore/keda/releases/download/v2.8.2/keda-2.8.2.yaml

KEDA v2.8 is no longer supported; can you please try with KEDA 2.15?

KEDA v2.8 is no longer supported; can you please try with KEDA 2.15?

Unfortunately, our internal cluster version is v1.21.1. According to the official recommendation of keda https://keda.sh/docs/2.15/operate/cluster/#kubernetes-compatibility, we use keda’s v2.8.2. I also tested it. After version 2.15 of keda, the program will panic because there is no v2 version of hpa, which can be understood as being incompatible with 1.21.1

@tomkerkhove https://keda.sh/docs/2.8/concepts/scaling-deployments/#pause-autoscaling，Didn’t the official support paused-replicas in v2.8.2? So is this a bug?

KEDA 2.8.2 is from Jan 2023; I doubt that we will issue a patch for it: https://github.com/kedacore/keda/releases/tag/v2.8.2

@tomkerkhove So in the 2.8.2 version I am currently testing, adding paused-replicas is in line with expectations, but deleting paused-replicas is not in line with expectations. Is it really a bug?

@tomkerkhove So in the 2.8.2 version I am currently testing, adding paused-replicas is in line with expectations, but deleting paused-replicas is not in line with expectations. Is it really a bug?

@tomkerkhove The purpose of trying to determine whether this problem is a bug is to clarify whether it is caused by my non-compliant operation or whether it is a defect of 2.8.2, because I see that the official clearly shows this function to users.

I remember some issues related with the pause feature in the beginning due to errors on (internal) selectors. To test if this is your case, restart the KEDA operator pod, if it fixes the HPA, you are affected by these problems

I remember some issues related with the pause feature in the beginning due to errors on (internal) selectors. To test if this is your case, restart the KEDA operator pod, if it fixes the HPA, you are affected by these problems

@JorTurFer Restart keda-metrics-apiserver or keda-operator pod?

keda-operator pod

keda-operator pod

After deleting autoscaling.keda.sh/paused-replicas, delete the pod of keda-operator and restart it, hpa resumes Automatic scaling.But this shouldn't be a routine process, is there any other solution? I also saw the design of autoscaling.keda.sh/paused, can it solve my problem?

But this shouldn't be a routine process, is there any other solution?

This bug is already solved in latest versions. I fully understand that you are attached to v2.8 as you're using k8s 1.21, but we won't cut any extra release for v2.8 as this version has 1,5 years and k8s 1.21 is out of support too. The only solution to the bug of this feature is using an updated version of KEDA.

I also saw the design of autoscaling.keda.sh/paused, can it solve my problem?

Do you mean to modify the current instances of a pod manually? yeah, probably it can. I use the pause feature when I want to disable or modify the amount of pods of a workload during manual operations

@tomkerkhove
Haha, but I tested autoscaling.keda.sh/paused: 'true' on 2.8.2 and found that manually adjusting replicas has no effect. Is there a design document that I can refer to? I really started to suspect that it was my operation problem. The official documentation does not seem to open paused to users.


fix quickstart

Related issue
n/a
Proposed Changes
Fix permissions for generate policy in the quickstart
Checklist

[x] I have read the contributing guidelines.
[x] I have inspected the website preview for accuracy.
[x] I have signed off my issue.

/cherry-pick release-1-13-0


Conflicting model scale definitions

The most obvious way to retrieve model scale (atomic/coarse-grained/multiscale (a mix of atomic and coarse-grained)) is from the _ihm_model_representation_details table. However, the scale is also explicitly defined in _ihm_modeling_protocol_details.multi_scale_flag .
It causes a conflict for PDBDEV_00000093:
According to the representation table, the model is purely atomic:
loop_
_ihm_model_representation_details.id
_ihm_model_representation_details.representation_id
_ihm_model_representation_details.entity_id
_ihm_model_representation_details.entity_description
_ihm_model_representation_details.entity_asym_id
_ihm_model_representation_details.entity_poly_segment_id
_ihm_model_representation_details.model_object_primitive
_ihm_model_representation_details.starting_model_id
_ihm_model_representation_details.model_mode
_ihm_model_representation_details.model_granularity
_ihm_model_representation_details.model_object_count
_ihm_model_representation_details.description
1 1 1 'N4BP1 CUE domain' A 1 atomistic 1 rigid by-atom . .
2 1 2 'Ubiquitin' B 2 atomistic 2 rigid by-atom . .
3 1 1 'N4BP1 CUE domain' A 3 atomistic 1 flexible by-atom . .
4 1 1 'N4BP1 CUE domain' A 4 atomistic 1 flexible by-atom . .
5 1 1 'N4BP1 CUE domain' A 5 atomistic 1 flexible by-atom . .
6 1 2 'Ubiquitin' B 6 atomistic 2 flexible by-atom . .
7 1 2 'Ubiquitin' B 7 atomistic 2 flexible by-atom . .
8 1 2 'Ubiquitin' B 8 atomistic 2 flexible by-atom . .
9 1 2 'Ubiquitin' B 9 atomistic 2 flexible by-atom . .
10 1 2 'Ubiquitin' B 10 atomistic 2 flexible by-atom . .
11 1 2 'Ubiquitin' B 11 atomistic 2 flexible by-atom . .

at the same time _ihm_modeling_protocol_details.multi_scale_flag  is set to YES.
Thus, on the website it's rendered as 'multiscale' :

)
I think structural model scale should be inferred using only _ihm_model_representation_details. @brindakv @jaredsagendorf  what do you think?

This table is populated during deposition, correct? Seems like the deposition system just needs a consistency check. Or maybe just make this field not editable and automatically populate it for the user?


Use istanbul-lib-hook to wrap require and support vm hooks

Use istanbul-lib-hook to wrap require and hook vm.runInThisContext and vm.createScript
Add options --hook-run-in-context and --hook-create-script (other names welcome)
Add a test that will succeed only if runInThisContext is successfully hooked.
The createScript hook is much harder to test. Given that istanbul-lib-instrument does not support the embedSource option any more, it is probably impossible to use this option meaningfully in nyc. Still looking into this.
Unrelated change: removed istanbul dev dependency in favor of APIs that are already being used, so that we don't accidentally use code from the old module any more. (I think the text reporter was being pulled in from the old lib)
Added --temp-directory option to report command so as to be able to use nyc itself to produce its coverage reports from the ./.self-coverage directory

Some questions:

I added requirejs as a dev dependency although it is actually a dependency of the test project. Is this correct or should we be doing an npm install from the test project directory before running its test?
there is no equivalent test for these hooks apart from the CLI test. Is this needed?

Link main issue for cross-ref: https://github.com/istanbuljs/nyc/issues/292

Changes Unknown when pulling 155de13b2075e41c4d17dba25b257e42a63dc43e on gotwarlost:libhook into ** on istanbuljs:master**.

Changes Unknown when pulling 297314bee2bb5771d31f68ea99b4a7298723cd51 on gotwarlost:libhook into ** on istanbuljs:master**.

Changes Unknown when pulling d28153c1413efd4346436a6b9b4810d05db21544 on gotwarlost:libhook into ** on istanbuljs:master**.

No idea why the appveyor build is failing. Need help.

@gotwarlost AppVeyor just fails a good chunk of the time, nothing to do with this pull as long as I can tell. re-kicked it off.

This is looking great 🎉 to land this I think all we'd need to to do would be:

add a test for vm.createScript, I don't think I saw one?
address the couple small issues:

I think that enabling the new instrumentation settings by default would be smart (@jamestalmage what are your thoughts?).
I'd be tempted to use 'enable' rather than 'true' when passing configuration around in the env.

finally, I'd also like to spin up my Windows VM and run this against a few projects once we're happy.

Thanks for the detailed feedback.

I think I'm going to remove the vm.createScript hook. The problem is that there is no place to stash the original code that was used for createScript. This is because, the instrumenter no longer supports the notion of embedding the source as part of the file coverage object. So if we ended up hooking vm.createScript the HTML report won't be able to find the original source. If someone really, really needs this we can add back the notion of embedding the source into the instrumenter and then implementing this. Even in istanbul this is a fairly exotic case and I don't believe it works correctly even today.
I will change the setting to enable|disable instead of true|false and enable it by default

@gotwarlost awesome, are you feeling like we're getting close to being able to point existing Istanbul users towards the Istanbul 1.0 APIs, and nyc? I've been having great luck as I test the new libraries against everything I throw at them, awesome work :) I wish we'd kicked this in motion s

Changes Unknown when pulling 03866c9ed24c481beba6f7b4f483aef0baa69329 on gotwarlost:libhook into ** on istanbuljs:master**.

@bcoe I think we are getting real close, it's probably already much better than istanbul. One problem is that it is not backwards compatible and we need to go through a documentation exercise and more importantly, provide a conversion program that will take a istanbul.yaml and turn it into a nyc config file, showing warnings with unsupported features etc.
I think a big gap from istanbul.yaml is the inability to configure reporting details in nyc (e.g. set the text reporter to write to a file, for example), but those are minority use-cases.

OK, the latest commit has all the PR comments included in it. Please take a look. I can squash commits after things look ok. Specifically, please check bundle dependency changes in package.json - I'm not quite sure abut what I did there.

Also, I'm not sure if coveralls not being able to tell how coverage changed is a regression in the way lcov info is being fed to it (lcov now generated using nyc instead of istanbul)

@gotwarlost this is feeling like a coveralls.io issue, I find there's a lot of weirdness with various services when I transfer repo ownership.


Recursive functions will not serialize/pickle

Reporting a bug

[x] I am using the latest released version of Numba (most recent is visible in
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

From this question: https://stackoverflow.com/questions/52569621/numba-functions-and-pickle
This:
from numba import njit
import pickle

@njit
def df(n):
    if n <= 0:
        return 1
    else:
        return n * df(n - 2)

pickle.dumps(df)

fails with
RecursionError: maximum recursion depth exceeded while calling a Python object

from the serialization call and it clearly ought not to.

hi @stuartarchibald , thanks for picking it up. I wrote that stackoverflow question and was coming here to report it when I saw that you already did. Happy to provide more details if necessary. I am using numba 0.39, as I could not find 0.40 in conda to retest on latest version.

@luk-f-a no problem. We keep an eye on stackoverflow for issues users may be having! Thanks for coming here to report the issue, it's much appreciated. Numba 0.40.0 will still have the bug, but if you want to try it anyway because it has loads of new features then it is available from the Numba channel:
$ conda install -c numba numba=0.40.0

and will be available from the main channels soon.

I'm actually still running into this problem -- is there any guidance on a workaround for this?

+1 same issue here

This does not reproduce on mainline for the upcoming 0.55 release. Closing.


feat: upgrade vue language tools

/cc @zhiyuanzmj

Oh, actually it breaks the tests, but the CI didn't run on this PR for some reason. I have reverted it, feel free to resend another PR.


Add multiple types for ocamllsp

Hi, I'm working on splitting the ocaml filetype into several ones.
Historically several file formats have been detected as just "ocaml" filetype. The filetype needs splitting because they need to uses specialized tree-sitter parsers. The plan is to adapt plugins like this one to support the filetypes before the breaking change of splitting the filetype is introduced into (neo)vim: https://github.com/ocaml/vim-ocaml/pull/61
This PR adds support for these filetypes while maintaining current behaviour when all file formats are detected as the ocaml filetype. To further complicate matters the new filetypes and the language_id expected by the server are different, so a map is added and get_language_id is defined.
I'm new to lua, feel free to point out errors in style, I'll gladly fix them.

Thanks for preparing us for this change!


Add 5.1 configuration settings to the reference

Closes #51
I did not document the new master_update_shard_statistics UDF, since it is mainly for internal use and can cause problems if used incorrectly.

:shipit:


Kill from UI doesn't call stopCmd for manual workers in exclusive mode

If workers runner setup as "manual"
mist.workers.runner = "manual"
I start new job, and kill it from UI
After this do not Is called script from
mist.workers.cmdStop = ...
I use exclusive mode
mist.context-defaults.worker-mode = "exclusive"
cmdStop is called in the case if job just finisht(success or fault)

fixed by #426


Implementing ToSql for [u8;N]

Hi thanks for developing and supporting diesel.
This PR would allow to bind slices of arbitrary size to queries (my specific usecase is raw queries). It's mostly for convenience to prevent having to reshape types prior to sending them to diesel.
An alternative would be to implement it for all the T: AsRef<[u8]>.

Thanks for opening this PR. Could you add at least some minor text for the motivation of that PR.

Thank you! Waiting for the tests though

Waiting for the tests though

It's configured in such a way that it only merges the PR if the test passes. I just allows me to not coming back for merging in a day or two if everything is fine.

I'll come back to it this afternoon (failed test)

I'm not sure all of this is actually needed. I can also squash the commits into a single one to reduce noise.


CommonMark?

Do you have any thoughts about CommonMark? It seems like on such a big version change with breaking comparability etc. it might be worth considering.
I don't know a ton about it, but I do like the sound of it's goals.

This was already discussed in waylan/Python-Markdown#338.

aha, thanks!


Configure default plugins

There are some plugins in php-http/plugins that got dependencies. We should allow the user to configure those plugins.
httplug:
  plugins:
    cache:
      service: 'acme.cache'
      config:
        respect_headers: true
    logger:
      formatter: 'acme.formatter'

Reference: https://github.com/php-http/HttplugBundle/pull/16#discussion_r48946387

agree. we can use the ->canBeEnabled() construct in configuration to know for each plugin whether it should be loaded. as soon as any other option is configured, enabled becomes true automatically. the DI extension would pass parameters (retry limit, redirect limit, cache service and so on) and remove plugins that are disabled from the container.


111 different errors while attempting to build app in Xcode

Lots of errors about commands that have been renamed, along with errors from the different libraries used. I can't seem to build it at all.

Guess it's time for an update then.

@Casuallynoted are you using an Xcode beta?

@swiftcodex I've opened it in both Xcode 7.3 and the Xcode 8 Beta, but it doesn't seem to change anything

@Casuallynoted on a clean clone, I'm not getting any errors in Xcode 7.3.1. 🤔
@Jxrgxn are you getting any errors in the stable version of Xcode?

Whoops! Looks like the version I first opened with Xcode 8 is what's giving me errors in Xcode 7.3, a clean clone works great! Sorry about that!

@Casuallynoted awesome! Yeah, I need to get on an Xcode 8 branch sooner than later...

It's all good, thank you so much for being willing to look into it, the app looks awesome! :)


fix(jump.js): add default options to jump and extends from util option

In order to add options to jump.js util, add DEFAULTS const with base jumpjs config and extend to a custom config.

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #233   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          21     21
  Lines         408    409    +1
=====================================
+ Hits          408    409    +1

Impacted Files
Coverage Δ

src/js/utils/scroll.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb581d0...056c415. Read the comment docs.


Deny h2c upgrade traffic around the code base

In the Go upstream http2 library, a DOS vector was introduced. The fix for the DOS introduces a request smuggling vulnerability. See https://github.com/golang/go/issues/56352.
All of these are related to h2c upgrades; we don't actually care about this - we only want HTTP/2 prior knowledge and HTTP/1.1.
This PR introduces a wrapper around the h2c library denying h2c upgrades. It also enforces via linting that this is used.
Please provide a description of this PR:

ill move the linter change to common-files btw, once it merges.

need backport to v1.16?

/cherrypick release-1.16

@howardjohn: new pull request created: #41885

In response to this:

/cherrypick release-1.16

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cherrypick release-1.15

@kfaseela: #41872 failed to apply on top of branch "release-1.15":
Applying: Deny h2c upgrade traffic around the code base
Using index info to reconstruct a base tree...
M	common/config/.golangci.yml
M	pilot/pkg/bootstrap/server.go
M	pkg/istio-agent/xds_proxy.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/istio-agent/xds_proxy.go
Auto-merging pilot/pkg/bootstrap/server.go
Auto-merging common/config/.golangci.yml
CONFLICT (content): Merge conflict in common/config/.golangci.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deny h2c upgrade traffic around the code base
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kfaseela: new issue created for failed cherrypick: #42966

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Move resolving workspace env to provision step

What does this PR do?
Resolve workspaceEnv (from attributes) when we're creating the workspace deployment rather than during flattening to ensure all containers get workspaceEnv applied.
What issues does this PR fix or reference?
workspaceEnv attribute does not apply to project-clone container.
Is it tested? How?
Can be tested with
cat << EOF | kubectl apply -f -
kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: theia-next
spec:
  started: true
  template:
    projects:
      - name: web-nodejs-sample
        git:
          remotes:
            origin: "https://github.com/che-samples/web-nodejs-sample.git"
    components:
      - name: theia
        attributes:
          workspaceEnv:
            - name: TEST_ENV
              value: TEST_VALUE
        plugin:
          uri: https://che-plugin-registry-main.surge.sh/v3/plugins/eclipse/che-theia/next/devfile.yaml
          components:
            - name: theia-ide
              container:
                env:
                  - name: THEIA_HOST
                    value: <IP_ADDRESS>
EOF

Ensure env var TEST_ENV is applied to project-clone.
PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

/test v8-devworkspace-operator-e2e

Given some other issues that have cropped up (https://github.com/devfile/devworkspace-operator/issues/707, https://github.com/devfile/devworkspace-operator/issues/709) I'm no longer convinced this is the way to go. I'm putting this PR on hold for now.

Merging as a component in https://github.com/devfile/devworkspace-operator/issues/707; it's useful to group commonEnv as in this PR.


program: respond to jon code review

address points raised in initial code review:

convert InstructionError to ProgramError without a trait
use VoteState::deserialize_into_uninit()
drop one lamport borrow before taking another
rewrite how signers are handled to be clearer and also preserve unfortunate native stake program permissiveness
add comments for skipped owner checks

also some of the block comments changed but thats because there was a rustfmt rule that messed with comments, which i didnt notice garbled them in a push to master commit lol
after this pr, the most important thing for me to do with the stake program is get solfuzz-agave up and running. currently this repo has better (exhaustive tests for all stake account state combinations for complex operations like split and merge, exhaustive tests for missing signers) but also worse (many of the ad hoc tests for edge cases have not been ported, and lockup coverage is very lacking) test coverage than the monorepo stake program. i believe tho that firedancer ported all the tests in stake_instruction.rs to test fixtures. so if we pass those, i will be very confident my implementation is correct
also i think i will implement the sysvar skipping logic, theres no downside to it and after we launch we can remove all those accounts from the instruction builders. but i want to do this after solfuzz-agave because it might cause false negatives if there are tests that expect omitting a sysvar to cause a failed transaction

ok! after going through every instruction one by one, i believe signers handling now matches the native program exactly (aside from fixing authorize with seed)


Widgets visualization appears to be cut/adjusted to the node's length

As per screenshot

Duplicate of https://github.com/enso-org/enso/issues/9379


🚀 Please try it out - try.esdoc.org

I released Try ESDoc. This is a trying ESDoc site (aka REPL).

Thanks.

Clicking the "try it out" button causes this to happen for me. Latest firefox (108.0.2) on windows 11.
Before:

After:

XHR error 502 in console:
XHR POST https://try.esdoc.org/api/create
[HTTP/2 502 Bad Gateway 190ms]
POST
	https://try.esdoc.org/api/create
Status
502
Bad Gateway
VersionHTTP/2
Transferred6.84 kB (6.40 kB size)
Referrer Policystrict-origin-when-cross-origin
Request PriorityHighest


WIP R3 driver

This is still WIP but it already allows the user to e.g. use service calls to upload a MELFA BASIC program to the robot, execute the program, read the robot state, toggle the robot servo / control state etc.
For real applications this will be quite useful I think, as one can control the robot remotely + without the teaching control, and without having to run a copy of RT Toolbox 3 which doesn't work under linux.
Let me know what you think! I am also happy to adjust the coding style to your preferences.
Wolf

@wolfv Do you have particular reason to close this PR? If not, could you please remain open this for the future development? I personally don't have MELFA robot and time to check it for a while but someone may be interested in using this feature.


Mismatched input '1' expecting CoreDecimalIntLiteral

I have a small program which uses the Antlr g4 to build a WHLSL parser (I am unable to use the JS version as it does not run with Node). When parsing https://github.com/KhronosGroup/SPIRV-Cross/blob/master/reference/opt/shaders-hlsl/comp/image.comp I receive:
line 59:12 mismatched input '1' expecting CoreDecimalIntLiteral

Thank you for these reports. This one is a clear bug in the grammar, I've fixed it.


com.kmpalette.palette.graphics.Palette -> androidx.palette.graphics.Palette

Describe the Bug:
Can we use the official Android X version of Palette?
Expected Behavior:
It looks like the normal Android X version should handle the current use cases.

Hey @jaredsburrows, since Landscapist is developed with KMP support by default, I'm eagerly anticipating the official AndroidX Palette's KMP support. I will re-open this issue and let you know once the official AndroidX Palette supports KMP.


Build system refactor

Right now, the build and publication system is kinda a mess.

Travis CI is responsible for handling the building and releasing of resources.
When a new version is released, I need to await CI completion to build and publish the docker images
Once CI is complete, I use buildx to create multi-arch images and push them to docker

It's a rather toilsome process and there have been some significant shifts recently that I think can help clean up this workflow.

Most of what I'm doing in Travis CI can be done easily in GitHub Actions without requiring the provisioning of an API key.
GitHub Actions also support buildx now making it easy to build and publish multi-arch images

During the process, we should preserve all existing artifacts.

In this process, we should look into having NodeJS produce targz's containing compiled javascript and node_modules for proper architectures. Right now, a lot of this is done in buildx and I've had some issues with NodeJS publications from time to time.

First end-to-end run:
https://travis-ci.com/github/deps-cloud/indexer/builds/168421899
https://github.com/deps-cloud/indexer/actions/runs/116991656
$ docker pull depscloud/indexer:0.2.8
0.2.8: Pulling from depscloud/indexer
c9b1b535fdd9: Already exists
0fd982b6e8ab: Pull complete
21f0d5836d00: Pull complete
f67951e661e6: Pull complete
Digest: sha256:413a6496cd102afabf01e1c82a591d4fe2c0a4f7307143a98bed14a9b2d6da43
Status: Downloaded newer image for depscloud/indexer:0.2.8
docker.io/depscloud/indexer:0.2.8

$ docker run --rm -it depscloud/indexer:0.2.8 --help
dependency indexing service

Usage:
  indexer [flags]

Flags:
      --config string              (optional) path to the config file
      --extractor-address string   (optional) address to the extractor service (default "extractor:8090")
      --extractor-ca string        (optional) ca used to enable TLS for the extractor
      --extractor-cert string      (optional) certificate used to enable TLS for the extractor
      --extractor-key string       (optional) key used to enable TLS for the extractor
      --extractor-lb string        (optional) the load balancer policy to use for the extractor (default "round_robin")
  -h, --help                       help for indexer
      --rds-config string          (deprecated) path to the rds config file
      --ssh-keypath string         (optional) the path to the ssh key file
      --ssh-user string            (optional) the ssh user, typically git (default "git")
      --tracker-address string     (optional) address to the tracker service (default "tracker:8090")
      --tracker-ca string          (optional) ca used to enable TLS for the tracker
      --tracker-cert string        (optional) certificate used to enable TLS for the tracker
      --tracker-key string         (optional) key used to enable TLS for the tracker
      --tracker-lb string          (optional) the load balancer policy to use for the tracker (default "round_robin")
      --workers int                (optional) number of workers to process repositories (default 5)

Tracker end-to-end run:
https://travis-ci.com/github/deps-cloud/tracker/builds/168424743
https://github.com/deps-cloud/tracker/actions/runs/117003373
$ docker pull depscloud/tracker:0.2.7
0.2.7: Pulling from depscloud/tracker
c9b1b535fdd9: Already exists
0fd982b6e8ab: Already exists
21f0d5836d00: Already exists
558cf20de2fa: Pull complete
f59374a4ee0c: Pull complete
Digest: sha256:51e3cc2cc1efb5845263661e7bce443d905f8fd49b5905e54917d8eab69adde8
Status: Downloaded newer image for depscloud/tracker:0.2.7
docker.io/depscloud/tracker:0.2.7

$ docker run --rm -it depscloud/tracker:0.2.7 --help
tracker runs the dependency tracking service.

Usage:
  tracker [flags]

Flags:
  -h, --help                              help for tracker
      --port int                          (optional) the port to run on (default 8090)
      --storage-address string            (optional) the address of the storage tier (default "file::memory:?cache=shared")
      --storage-driver string             (optional) the driver used to configure the storage tier (default "sqlite3")
      --storage-readonly-address string   (optional) the readonly address of the storage tier
      --storage-statements-file string    (optional) path to a yaml file containing the definition of each SQL statement
      --tls-ca string                     (optional) path to the file containing the TLS certificate authority
      --tls-cert string                   (optional) path to the file containing the TLS certificate
      --tls-key string                    (optional) path to the file containing the TLS private key

Gateway end-to-end run:
https://travis-ci.com/github/deps-cloud/gateway/builds/168426256
https://github.com/deps-cloud/gateway/actions/runs/117009325
$ docker pull depscloud/gateway:0.2.8
0.2.8: Pulling from depscloud/gateway
c9b1b535fdd9: Already exists
0fd982b6e8ab: Already exists
21f0d5836d00: Already exists
a83d482cd567: Pull complete
Digest: sha256:dd1c15b8c069de525ae209eb8b1f0803e0a3439404c3971afd95a43a601be0b3
Status: Downloaded newer image for depscloud/gateway:0.2.8
docker.io/depscloud/gateway:0.2.8

$ docker run --rm -it depscloud/gateway:0.2.8 --help
Start up an HTTP proxy for the gRPC services

Usage:
  gateway [flags]

Flags:
      --extractor-address string   (optional) address to the extractor service (default "extractor:8090")
      --extractor-ca string        (optional) ca used to enable TLS for the extractor
      --extractor-cert string      (optional) certificate used to enable TLS for the extractor
      --extractor-key string       (optional) key used to enable TLS for the extractor
      --extractor-lb string        (optional) the load balancer policy to use for the extractor (default "round_robin")
  -h, --help                       help for gateway
      --port int                   (optional) the port to run on (default 8080)
      --tls-ca string              (optional) path to the file containing the TLS certificate authority
      --tls-cert string            (optional) path to the file containing the TLS certificate
      --tls-key string             (optional) path to the file containing the TLS private key
      --tracker-address string     (optional) address to the tracker service (default "tracker:8090")
      --tracker-ca string          (optional) ca used to enable TLS for the tracker
      --tracker-cert string        (optional) certificate used to enable TLS for the tracker
      --tracker-key string         (optional) key used to enable TLS for the tracker
      --tracker-lb string          (optional) the load balancer policy to use for the tracker (default "round_robin")

Extractor end-to-end run:
https://travis-ci.com/github/deps-cloud/extractor/builds/168426724
https://github.com/deps-cloud/extractor/actions/runs/117009531
$ docker pull depscloud/extractor:0.2.10
0.2.10: Pulling from depscloud/extractor
1c6172af85ee: Pull complete
b194b0e3c928: Pull complete
1f5ec00f35d5: Pull complete
93b1353672b6: Pull complete
3d7f38db3cca: Pull complete
21e102f9fe89: Pull complete
1f9c0020f4f4: Pull complete
5ab83c758454: Pull complete
654868f0dc71: Pull complete
0f8613f2ca58: Pull complete
9f7fe9d6a9d5: Pull complete
1c739eca900a: Pull complete
1a159414bab2: Pull complete
6dc1ea9563c0: Pull complete
Digest: sha256:ced08357b7946838a715fef353267b1ef7f1ea840a198c270c3daf320ff1c662
Status: Downloaded newer image for depscloud/extractor:0.2.10
docker.io/depscloud/extractor:0.2.10

$ docker run --rm -it depscloud/extractor:0.2.10 --help

><EMAIL_ADDRESS>start /app
> node lib/main.js "--help"

   extractor undefined

   USAGE

     main.js

   OPTIONS

     --bind-address <bindAddress>        The ip address to bind to.                              optional
     --port <port>                       The port to bind to.                                    optional
     --tls-key <key>                     The path to the private key used for TLS                optional
     --tls-cert <cert>                   The path to the certificate used for TLS                optional
     --tls-ca <ca>                       The path to the certificate authority used for TLS      optional
     --disable-manifests <manifest>      The manifests to disable support for                    optional

   GLOBAL OPTIONS

     -h, --help         Display help
     -V, --version      Display version
     --no-color         Disable colors
     --quiet            Quiet mode - only displays warn and error messages
     -v, --verbose      Verbose mode - will also output debug messages

Alright, most core systems have been updated to leverage the new GitHub actions workflow.

Alright. Every system has officially been migrated off of travis-ci and onto GitHub Actions. Now when a project is released, we simply push a tag and the workflows take care of doing the rest.


Test: Improved testcase coverage for StrBuilder

added some missing flows to testcases plus some nice formatting for easy understanding.

Thanks!
Please separate the formatting fixes and the test additions into different commits.
Please stick to the existing code style for the new tests (no new line at the beginning and at the end of a test method; single new line between test methods).

Agreed with Pascal here, just for semantics on commit history.

Fixed all the code as suggested, Thanks.

Changes Unknown when pulling 31a5cd173d118148b2a2d2dfac8c99f2d90a8a06 on ameyjadiye:test-StrBuilder into ** on apache:master**.

Thanks for splitting the changes. :+1:
But please also address the second part:

Please stick to the existing code style for the new tests (no new line at the beginning and at the end of a test method; single new line between test methods).

Furthermore it would be very nice if you would clean up the history of the pull request by using git rebase once it is ready to merge.
After you commit the style fixes for the new tests you should be able to clean-up the history like this:
Use git rebase -i head~5. Choose to drop the first two commits (06e8b3dd06ee2f86490b2e94359d29d2fe04786c and 27e110b37f8f1e1cceee18ab614424f8a807a747). Squash d23bd1db8c0f21f62006b8cf0f41eb0588997a1e and the last commit. Afterwards use push -f to update the pull request.
After this there will be only two commits (one with the style changes and one with the new tests) and the commit history of commons-text will be pristine. :smile:

Changes Unknown when pulling 242ad5e6cda2cc62be4e1b8fccedd7922ecdc44e on ameyjadiye:test-StrBuilder into ** on apache:master**.

@PascalSchumacher This seems nice trick , but somehow didn't worked for me and ended up just pushing latest commit, can you try this once ? I have given you write access for exact this repository.

Coverage increased (+0.4%) to 97.317% when pulling eb25d61ca6bd845815bb30feb2ba0cf9f6e106ff on ameyjadiye:test-StrBuilder into 9f6e5e45e925511d0fdbf59bb264aafa6b91f997 on apache:master.

Thanks. I was not as easy as I expected (I had to merge).
I followed these steps:
git rebase -i head~5
Edit the rebase-todo-to to contain:
drop 06e8b3d test: Improved testcase coverage for StrBuilder
drop  27e110b revert to master
pick d23bd1d Test: Improved testcase coverage for StrBuilder
squash 242ad5e Style fixes for StrBuilderTest
pick 31a5cd1 Fixed formatting for StrBuilder

Edit merge conflict.
git rebase --continue
Editmerge conflicts (nothing to do, just confirm merge was good).
git rebase --continue
push -f
Please remove my access to the repository. Thanks!

Cool, seems clean now :+1: thanks Pascal. Trick will be certainly beneficial in future to me 😉

Looking good! :+1:

Thanks Amey.


Simpler settings management

The previous settings structure was causing the loading of all django
settings, including those that are deprecated. This was causing
deprecation warnings for most users. These warnings could be disabled at
the cost of hiding all django deprecation warnings, which was too bad.
We took the opportunity to get rid of a now useless test utility:
"override_custom_settings".
Close #589.

Could we please merge this?

I feel like this change should be relatively uncontroversial. Could someone please take another look and merge this?

Thanks @claudep!


Removing gitlab authentication from SDLC apis

Hi Legend Team,
I want to use the Legend sdlc apis in our javascript application, but we are unable to authenticate apis and get response through code.
So other way was to remove gitlab authentication from sdlc apis. So is ther any way by which I  can access these sdlc apis without authenticating by gitlab or what are the code changes required to remove gitlab authentication from sdlc.
Thanks

Hi,
Maybe you can replicate what we do in https://github.com/finos/legend-studio/blob/master/packages/legend-application-studio/src/stores/LegendStudioBaseStore.ts#L189
We call the /auth/authorize endpoint to reroute user to authenticate and authorize using OAuth
The other route that you can take is to use Private Access Token, for this you have to do 2 things:

Setup SDLC config to use: https://github.com/finos/legend/blob/master/installers/omnibus/sdlc/config/config.yml#L36
Include the token in your network request header, for example, with Studio, we do this in our config: https://github.com/finos/legend/blob/master/installers/omnibus/studio/config/config.json#L7

Hi @akphi , Thanks for your reply. I was following second approach. So I configured SDLC something like this.

I created "shomil-token" as a personal access token in gitlab.

But while runing SDLC locally, I am getting 401 unauthorized error.

I think you misused the headerTokenName, it's the name of the request header tag that you use to send the private access token from studio, if you look at https://github.com/finos/legend/blob/master/installers/omnibus/sdlc/config/config.yml#L36 you can see we set the headerTokenName as legend-omnibus-pat - search for that in the file, you see we need to add it to the CORS header whitelist as well
Now, in the studio config, you set header accordingly
https://github.com/finos/legend/blob/master/installers/omnibus/studio/config/config.json#L7
So for you example, I suppose it can be something like
{
  ... // if you set `headerTokenName: shomil-token`
  "sdlc": {
    "url": "http://localhost:${LEGEND_OMNIBUS_NGINX_PORT}/sdlc/api",
    "baseHeaders": {
      "shomil-token": "<your private access token, e.g. glpat-...>"
    }
  },
  ...

I think you misused the headerTokenName, it's the name of the request header tag that you use to send the private access token from studio, if you look at https://github.com/finos/legend/blob/master/installers/omnibus/sdlc/config/config.yml#L36 you can see we set the headerTokenName as legend-omnibus-pat - search for that in the file, you see we need to add it to the CORS header whitelist as well
Now, in the studio config, you set header accordingly https://github.com/finos/legend/blob/master/installers/omnibus/studio/config/config.json#L7 So for you example, I suppose it can be something like
{
  ... // if you set `headerTokenName: shomil-token`
  "sdlc": {
    "url": "http://localhost:${LEGEND_OMNIBUS_NGINX_PORT}/sdlc/api",
    "baseHeaders": {
      "shomil-token": "<your private access token, e.g. glpat-...>"
    }
  },
  ...

Thanks @akphi again, but I am using another application which will fetch data from sdlc apis, not studio. How that can be achieved. Thanks

Thanks @akphi again, but I am using another application which will fetch data from sdlc apis, not studio. How that can be achieved. Thanks

I almost forgot, but what I said applies still, when you make network call to SDLC server, send along the header, e.g.
curl --header "shomil-token": "<your private access token, e.g. glpat-...>" --write-out %{http_code} --silent --output /dev/null http://localhost:6100/api/currentUser

Thanks @akphi again, but I am using another application which will fetch data from sdlc apis, not studio. How that can be achieved. Thanks

I almost forgot, but what I said applies still, when you make network call to SDLC server, send along the header, e.g.
curl --header "shomil-token": "<your private access token, e.g. glpat-...>" --write-out %{http_code} --silent --output /dev/null http://localhost:6100/api/currentUser

Hi @akphi , currently after curl, I am getting this nullPointerException

What's your SDLC config like right now?

What's your SDLC config like right now?

@akphi , It's same as previous

Any change required here ?
Thanks !!

Can you post the full config?

Can you post the full config?

Yes sure,
Copyright 2020 Goldman Sachs

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
applicationName: Legend SDLC
sessionCookie: LEGEND_SDLC_JSESSIONID
server:
applicationConnectors:
- type: http
port: 7070
maxRequestHeaderSize: 128KiB
adminConnectors:
- type: http
port: 7076
gzip:
includedMethods:
- GET
- POST
requestLog:
type: classic
appenders:
- type: file
currentLogFilename: ./logs/access.log
threshold: ALL
archive: true
archivedLogFilenamePattern: ./logs/access-%d.log
archivedFileCount: 5
timeZone: UTC
rootPath: /api
#features:
canCreateProject: true
canCreateVersion: true
filterPriorities:
GitLab: 1
org.pac4j.j2e.filter.CallbackFilter: 2
org.pac4j.j2e.filter.SecurityFilter: 3
CORS: 4
pac4j:
callbackPrefix: /api/pac4j/login
clients:
- org.finos.legend.server.pac4j.gitlab.GitlabPersonalAccessTokenClient:
headerTokenName: shomil-token
scheme: https
host: fraboxpd0782.de.db.com
apiVersion: v4
bypassPaths:
- /api/info
gitLab:
newProjectVisibility: public
projectIdPrefix: SAMPLE
projectTag: legend
server:
scheme: https
host: fraboxpd0782.de.db.com
app:
id:
secret:
redirectURI: http://localhost:7070/api/auth/callback
projectStructure:
extensionProvider:
org.finos.legend.sdlc.server.gitlab.finos.FinosGitlabProjectStructureExtensionProvider: {}
platforms:
legend-engine:
groupId: org.finos.legend.engine
platformVersion:
#version: 3.3.1
fromPackage: legend-engine-protocol-pure
legend-sdlc:
groupId: org.finos.legend.sdlc
platformVersion:
#version: 0.77.1
fromPackage: legend-sdlc-server
logging:
Change this to affect library class logging
level: INFO
loggers:
# Change this to affect application class logging
org.finos.legend.sdlc: INFO
appenders:
- type: file
logFormat: "%d{yyyy-MM-dd HH:mm:ss.SSS} %-5p [%thread] %c - %m%n"
currentLogFilename: ./logs/service.log
threshold: ALL
archive: true
archivedLogFilenamePattern: ./logs/service-%d.log
archivedFileCount: 5
timeZone: UTC
- type: console
logFormat: "%d{yyyy-MM-dd HH:mm:ss.SSS} %-5p [%thread] %c - %m%n"
swagger:
resourcePackage: org.finos.legend.sdlc.server.resources
title: Legend SDLC
schemes: []

@shomil-maurya-db please upload a file next time, also I think you missed one my instruction earlier, you should add this in your config
cors:
  allowedHeaders:
    - X-Requested-With
    - Content-Type
    - Accept
    - Origin
    - Access-Control-Allow-Credentials
    - x-b3-parentspanid
    - x-b3-sampled
    - x-b3-spanid
    - x-b3-traceid
    - shomil-token

Thanks @akphi again, but I am using another application which will fetch data from sdlc apis, not studio. How that can be achieved. Thanks

I almost forgot, but what I said applies still, when you make network call to SDLC server, send along the header, e.g.
curl --header "shomil-token": "<your private access token, e.g. glpat-...>" --write-out %{http_code} --silent --output /dev/null http://localhost:6100/api/currentUser

Hi @akphi , currently after curl, I am getting this nullPointerException

Well, I really don't have a clear idea at this point, maybe you can try to debug the NullPointer issue? You can also post the stacktrace here, maybe I can help

Thanks @akphi again, but I am using another application which will fetch data from sdlc apis, not studio. How that can be achieved. Thanks

I almost forgot, but what I said applies still, when you make network call to SDLC server, send along the header, e.g.
curl --header "shomil-token": "<your private access token, e.g. glpat-...>" --write-out %{http_code} --silent --output /dev/null http://localhost:6100/api/currentUser

Hi @akphi , currently after curl, I am getting this nullPointerException

Well, I really don't have a clear idea at this point, maybe you can try to debug the NullPointer issue? You can also post the stacktrace here, maybe I can help

Hi @akphi , these logs are present when I hit curl command
2023-06-26 13:04:48.425 INFO  [main] org.eclipse.jetty.server.AbstractConnector - Started<EMAIL_ADDRESS>(http/1.1)}{<IP_ADDRESS>:7070}
2023-06-26 13:04:48.436 INFO  [main] org.eclipse.jetty.server.AbstractConnector - Started<EMAIL_ADDRESS>(http/1.1)}{<IP_ADDRESS>:7076}
2023-06-26 13:04:48.436 INFO  [main] org.eclipse.jetty.server.Server - Started @35484ms
2023-06-26 13:22:14.644 INFO  [dw-23] org.finos.legend.server.shared.bundles.ChainFixingFilterHandler - Reordered filters as CORS -> org.pac4j.j2e.filte
r.SecurityFilter -> org.pac4j.j2e.filter.CallbackFilter -> GitLab -> Guice Filter -> org.pac4j.j2e.filter.LogoutFilter -> Username -> io.dropwizard.jers
ey.filter.AllowedMethodsFilter-1e64062 -> io.dropwizard.servlets.ThreadNameFilter-410a5cdb
2023-06-26 13:22:14.671 WARN  [dw-23] org.eclipse.jetty.server.HttpChannel - /api/currentUser
java.lang.NullPointerException: null
at java.base/sun.net.util.IPAddressUtil.checkHost(IPAddressUtil.java:425)
at java.base/sun.net.util.IPAddressUtil.checkAuthority(IPAddressUtil.java:470)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.checkURL(HttpsURLConnectionImpl.java:91)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.(HttpsURLConnectionImpl.java:100)
at java.base/sun.net.www.protocol.https.Handler.openConnection(Handler.java:62)
at java.base/sun.net.www.protocol.https.Handler.openConnection(Handler.java:57)
at java.base/java.net.URL.openConnection(URL.java:1099)
at org.finos.legend.server.pac4j.gitlab.GitlabPersonalAccessTokenAuthenticator.getUserInformation(GitlabPersonalAccessTokenAuthenticator.java:58
)
at org.finos.legend.server.pac4j.gitlab.GitlabPersonalAccessTokenAuthenticator.validate(GitlabPersonalAccessTokenAuthenticator.java:47)
at org.finos.legend.server.pac4j.gitlab.GitlabPersonalAccessTokenAuthenticator.validate(GitlabPersonalAccessTokenAuthenticator.java:29)
at org.pac4j.core.client.BaseClient.retrieveCredentials(BaseClient.java:71)
at org.pac4j.core.client.DirectClient.getCredentials(DirectClient.java:42)
at org.pac4j.core.engine.DefaultSecurityLogic.perform(DefaultSecurityLogic.java:113)
at org.pac4j.j2e.filter.SecurityFilter.internalFilter(SecurityFilter.java:93)
at org.pac4j.j2e.filter.AbstractConfigFilter.doFilter(AbstractConfigFilter.java:81)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:319)
at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:273)
at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:548)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1434)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1349)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at com.codahale.metrics.jetty9.InstrumentedHandler.handle(InstrumentedHandler.java:313)
at io.dropwizard.jetty.RoutingHandler.handle(RoutingHandler.java:52)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:763)
at io.dropwizard.jetty.BiDiGzipHandler.handle(BiDiGzipHandler.java:67)
at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:54)
at org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:179)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
at org.eclipse.jetty.server.Server.handle(Server.java:516)
at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:400)
at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:645)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:392)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
at java.base/java.lang.Thread.run(Thread.java:829)
<IP_ADDRESS> - - [26/Jun/2023:07:52:14 +0000] "GET /api/currentUser HTTP/1.1" 500 508 "-" "curl/8.0.1" 64

Hi @akphi , just one doubt, are private access token and personal access token (in gitlab) are same right, or there is any difference ?

yes, they are the same
that's really odd; from the stack trace, we got an error indicating that some URL's host was missing. One possible case is that in your config, the field host is missing, which is weird since in the latest reply, you set it as fraboxpd0782.de.db.com, so I'm not sure

Hi @akphi , I also tried first approach as you discussed but I am getting response in new tab and the cookie of LEGEND_SDLC is not getting transferred to my application.

This issue is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This issue was closed because it has been inactive for 35 days. Please re-open if this issue is still relevant.


add homebrew test

Codecov Report

Merging #1429 into master will decrease coverage by 5.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage   51.12%   45.55%   -5.57%
==========================================
  Files         136      136
  Lines       13612    13612
==========================================
- Hits         6959     6201     -758
- Misses       5800     6613     +813
+ Partials      853      798      -55

Impacted Files
Coverage Δ

internal/backend/b2/b2.go
0% <0%> (-79.41%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-75.35%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-73.9%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-68.96%)
:arrow_down:

internal/backend/swift/config.go
34.37% <0%> (-56.25%)
:arrow_down:

cmd/restic/lock.go
52.5% <0%> (-5%)
:arrow_down:

internal/backend/test/tests.go
58.81% <0%> (-0.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06bd606...b648572. Read the comment docs.

I'm not sure this is a good idea. It would test not restic itself, but the installation via homebrew. That'd add many different external dependencies, at a minimum the homebrew servers etc.


Add source for install-package to install netDumbster

PR Summary
There is a break in daily builds are installing netDumbster fails and hence Send-MailMessage tests fail.
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] to your commit messages if the change is significant or affects feature tests

/cc @ThreeFive-O

Merging this without waiting for 24 hours, since this is failing daily builds.


не  могу скачать какое либо расширение

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

Появляется  #ошибка  "the editor could not be opened due to an unexpected error xhr failed. Try Again"

@webdevmaxim please share steps to reproduce this behavior, e.g. are you using a local or remote window, what kind of editor you're opening (text file, Jupyter notebook, custom editor), and the specific workspace this repros in if any

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add 8.1 support

@Gargron

Since Travis is not supported anymore, could you please rewrite this to GitHub Actions?
For example:
# .github/workflows/main.yml
name: "CI"

on: ['push', 'pull_request']

jobs:
  lint:
    name: "Lint"
    runs-on: "ubuntu-latest"
    strategy:
      fail-fast: false
      matrix:
        php-version:
          - "7.2"
          - "7.3"
          - "7.4"
          - "8.0"
          - "8.1"
    steps:
      - uses: "actions/checkout@v2"
      - uses: "shivammathur/setup-php@v2"
        with:
          php-version: "${{ matrix.php-version }}"
          ini-values: error_reporting=-1, display_errors=On
          coverage: "none"
      - uses: "ramsey/composer-install@v2"
      - name: "Run the linter"
        run: "composer lint -- --colors"

  unit-tests:
    name: "Unit Tests"
    runs-on: "ubuntu-latest"
    strategy:
      fail-fast: false
      matrix:
        php-version:
          - "7.2"
          - "7.3"
          - "7.4"
          - "8.0"
          - "8.1"
    steps:
      - uses: "actions/checkout@v2"
      - uses: "shivammathur/setup-php@v2"
        with:
          php-version: "${{ matrix.php-version }}"
          coverage: "none"
      - uses: "ramsey/composer-install@v2"
        with:
          composer-options: "${{ matrix.composer-options }}"
      - name: "Run unit tests"
        run: "./vendor/bin/phpunit --verbose --colors=always"


DWORD_PTR

What managed type should we use for DWORD_PTR?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 678eaef3-eec4-dc52-1234-37e220f84682
Version Independent ID: 38b09163-65d8-4d6c-1394-401e080ed6f0
Content: Marshaling Data with Platform Invoke
Content Source: docs/framework/interop/marshaling-data-with-platform-invoke.md
Product: dotnet-framework
GitHub Login: @gewarren
Microsoft Alias: dotnetcontent

Since it is an unsigned long type, use System.UInt32 (uint in C#).


Format selection with black does not work on indented code

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
The "Format file or selection with Black" option does not work when selecting code that is indented.
What steps reproduce the problem?

Indent a line of code that can be formatted with black
Select the line and click "Format file or selection with Black"
The code is not formatted

What is the expected output? What do you see instead?
With
True
test=True

selecting the second line and clicking "Format file or selection with Black" works and shows:
True
test = True

With
if True:
    test=True

selecting the second line and clicking "Format file or selection with Black" does not works and shows:
if True:
    test=True

Paste Traceback/Error Below (if applicable)

None.
 I was able to reproduce this, although I'm not sure if this is an issue with Spyder or a black limitation. Checking around I found this issue: https://github.com/psf/black/issues/1352 and using autopep8 as formatter provider seems like enables formating an indented code selection properly:

Maybe we should update the action text to Format file or selection with Autopep8 when using autopep8 but leave it just as Format file with Black when using black and make it work with or without selection in the case black is selected 🤔 What do you think @ccordoba12 ?

although I'm not sure if this is an issue with Spyder or a black limitation

It's a black issue. Their maintainers decided to not offer a way to not format portions of code. However, there's a way to support this through the Python language server, but I haven't found the time to do it, sorry.

What do you think @ccordoba12 ?

I think we should try to support range formatting with Black because it's really useful. I'll try to make that happen before the end of the year.

Looks like the black issue linked above would unblock this. Thanks for looking into it!

Looks like the black issue linked above would unblock this. Thanks for looking into it!

That issue was fixed in black 23.11.0: https://github.com/psf/black/releases/tag/23.11.0
The way it works is by passing a list of line ranges to https://black.readthedocs.io/en/stable/contributing/reference/reference_functions.html#black.format_file_contents that parses the entire file and only format the selected lines. It does return the entire file as well so the fix is not trivial.

Looks like the black issue linked above would unblock this. Thanks for looking into it!

That issue was fixed in black 23.11.0: https://github.com/psf/black/releases/tag/23.11.0
The way it works is by passing a list of line ranges to https://black.readthedocs.io/en/stable/contributing/reference/reference_functions.html#black.format_file_contents that parses the entire file and only format the selected lines. It does return the entire file as well so the fix is not trivial.

I open a pull request that may fix this at https://github.com/python-lsp/python-lsp-black/pull/52.
I have not been able to test it in Spyder yet (if anyone knows how to install a forked dependency of a submodule with conda...).

I open a pull request that may fix this at https://github.com/python-lsp/python-lsp-black/pull/52.

Thanks a lot @remisalmon!

I have not been able to test it in Spyder yet (if anyone knows how to install a forked dependency of a submodule with conda...).

You need to run the command:
pip install --no-deps -e .

Did not know I could pip with conda, the fix does work in Spyder!
> conda list | grep black
black                     23.11.0          py39hf3d152e_0    conda-forge
python-lsp-black          1.4.0.dev0               pypi_0    pypi

Spyder.webm

Did not know I could use pip with conda, the fix does work in Spyder!

Yep, you can if you use --no-deps to not bring any other pip dependency.
And things is pretty cool! Thanks again for your work on this.


Build job with file parameters

PR for issue #73

@binoyudayan thanks for creating PR.  it would be better to add integration test as well ?


Update Marketplace, Forward to Official Vendors' Shops

In brief
As a suggestion by Robert on the ThreeFold forum, the marketplace could be updated with links redirecting to the different 3Node vendors. Also, old products are still displayed.
Original Issue
"
Another issue that has been addressed to the Belgium team several times; our (old) products are still on the Belgium marketplace. For vendors this marketplace has never been very effective. First of all it cost commission, secondly, the fact it was a Belgium company, providing foreign nodes (Netherlands, USA) with a bank account in Dubai has put of may buyer thinking it was scam.
The current nodes/products in that webshop are not maintained. However, the marketplace is still promoted and has SEO value. So, to stimulate sales and decentralisation, our products should somehow forward (with a clear message) to the vendors webshop.
"
Potential Solution
Instead of having the products themselves on the marketplace, we could only have links to the official vendors. The vendors will be able to update their products as needed.

This way we would lose out on commission tho. Will discuss in stakeholder call.


can't execute click action in wechat corp under windows

I used flutter web to develop a h5 web page, running in enterprise Wechat windows pc version, and found that all click events were invalid; In fact, it's normally under mac version. This confused me, I don't know where to find the reason.
The mainly difference is, under windows pc version, it threw this js exception:

The browser kernel in enterprice wechat is:
The Mac version of the WeChat browser kernel is the system's safari.
PC cef core browser version is Chromium framework 53

The problem should be that the browser kernel of the corporate WeChat PC version is too old， version is Chromium 53. My question is, Can flutter handle this kind of downward compatibility problem because the kernel version is too old?

Hi @stoneLee81
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Add three-week cycle comment to README

This adds a comment about our three-week cycle to the README.md.

:+1: Thank you for adding it. I wanted to add it there, and completely forgot about it :-(


Themes vs Styles

I think themes should belog to themes.xml file, see:
http://android-developers.blogspot.sk/2014/10/appcompat-v21-material-design-for-pre.html
or see here a clarification of topic "Theme vs Style" - what belongs where (if done properly, as per guidelines):
https://chris.banes.me/2014/11/12/theme-vs-style/
http://developer.android.com/guide/topics/ui/themes.html

mmm yes, I have renamed my styles.xml files to themes.xml files

hmm, does everything you style belong to themes.xml? but... probably yes ;)
I'll close it as soon as available in the next release. thx


Add specs for Integer.sqrt [Feature #13219]

(new in Ruby 2.5)

The test failure should be unrelated to the commit.


add function CopyLocalFileToRemotePath & CopyRemoteFileToLocalPath

Doesn't this conflict a bit with current naming?

@zhangfuwen thanks for your contribution, can you address my earlier comment there?


TwitterAdsPromotedTweetApi.getAllPromotedTweets() takes deprecated parameter lineItemId

Hi there,
We noticed the method TwitterAdsPromotedTweetApi.getAllPromotedTweets() only takes the deprecated parameter lineItemId and doesn't offer the ability to pass a list of line item ids as the endpoint https://dev.twitter.com/ads/reference/get/accounts/%3Aaccount_id/promoted_tweets
Many thanks in advance,
Luis

Thanks for the heads up about this...This was fixed in the last commit! More changes will come in the next couple days.


Function to disable a device

Write a function that uses the NM DBus API to disable a device.

https://github.com/resin-io/hq/pull/453

Implemented in a8201966c3d1cd4fdc21c3e832345f4b718f5ec3


Getting MissingPluginException

I am getting this exception,
MissingPluginException (MissingPluginException(No implementation found for method getAllUpiApps on channel com.az.upi_india))
Logs here
E/flutter (32146): [ERROR:flutter/lib/ui/ui_dart_state.cc(157)] Unhandled Exception: MissingPluginException(No implementation found for method getAllUpiApps on channel com.az.upi_india)
E/flutter (32146): #0      MethodChannel._invokeMethod
package:flutter/…/services/platform_channel.dart:154
E/flutter (32146): <asynchronous suspension>
E/flutter (32146): #1      MethodChannel.invokeMethod
package:flutter/…/services/platform_channel.dart:329
E/flutter (32146): #2      MethodChannel.invokeListMethod
package:flutter/…/services/platform_channel.dart:342
E/flutter (32146): #3      UpiIndia.getAllUpiApps
package:upi_india/upi_india.dart:23
E/flutter (32146): #4      _CheckoutSheetState.initState
package:dais/…/widgets/checkout_sheet.dart:26
E/flutter (32146): #5      StatefulElement._firstBuild
package:flutter/…/widgets/framework.dart:4640
E/flutter (32146): #6      ComponentElement.mount
package:flutter/…/widgets/framework.dart:4476
E/flutter (32146): #7      Element.inflateWidget
package:flutter/…/widgets/framework.dart:3446
E/flutter (32146): #8      Element.updateChild
package:flutter/…/widgets/framework.dart:3214
E/flutter (32146): #9      ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:4527
E/flutter (32146): #10     Element.rebuild
package:flutter/…/widgets/framework.dart:4218
E/flutter (32146): #11     ComponentElement._firstBuild
package:flutter/…/widgets/framework.dart:4481
E/flutter (32146): #12     ComponentElement.mount
package:flutter/…/widgets/framework.dart:4476
E/flutter (32146): #13     Element.inflateWidget
package:flutter/…/widgets/framework.dart:3446
E/flutter (32146): #14     Element.updateChild
package:flutter/…/widgets/framework.dart:3214
E/flutter (32146): #15     ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:4527
E/flutter (32146): #16     Element.rebuild
package:flutter/…/widgets/framework.dart:4218
E/flutter (32146): #17     ComponentElement._firstBuild
package:flutter/…/widgets/framework.dart:4481
E/flutter (32146): #18     ComponentElement.mount
package:flutter/…/widgets/framework.dart:4476
E/flutter (32146): #19     Element.inflateWidget
package:flutter/…/widgets/framework.dart:3446
E/flutter (32146): #20     Element.updateChild
package:flutter/…/widgets/framework.dart:3214
E/flutter (32146): #21     ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:4527
E/flutter (32146): #22     StatefulElement.performRebuild
package:flutter/…/widgets/framework.dart:4675
E/flutter (32146): #23     Element.rebuild
package:flutter/…/widgets/framework.dart:4218
E/flutter (32146): #24     ComponentElement._firstBuild
package:flutter/…/widgets/framework.dart:4481
E/flutter (32146): #25     StatefulElement._firstBuild
package:flutter/…/widgets/framework.dart:4666
E/flutter (32146): #26     ComponentElement.mount
package:flutter/…/widgets/framework.dart:4476
E/flutter (32146): #27     Element.inflateWidget
package:flutter/…/widgets/framework.dart:3446
E/flutter (32146): #28     Element.updateChild
package:flutter/…/widgets/framework.dart:3214
E/flutter (32146): #29     SingleChildRenderObjectElement.mount
package:flutter/…/widgets/framework.dart:5830
E/flutter (32146): #30     Element.inflateWidget
package:flutter/…/widgets/framework.dart:3446
E/flutter (32146): #31     Element.updateChild
package:flutter/…/widgets/framework.dart:3214
E/flutter (32146): #32     ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:4527
E/flutter (32146): #33     Element.rebuild
package:flutter/…/widgets/framework.dart:4218
E/flutter (32146): #34     ComponentElement._firstBuild
package:flutter/…/widgets/framework.dart:4481
E/flutter (32146): #35     ComponentElement.mount
package:flutter/…/widgets/framework.dart:4476
E/flutter (32146): #36     Element.inflateWidget
package:flutter/…/widgets/framework.dart:3446
E/flutter (32146): #37     Element.updateChild
package:flutter/…/widgets/framework.dart:3214

Android or iOS?
Which version of plugin are you using?

It is working now. Thanks @mdazharuddin1011999


New Clinical Significance terms from EVA

As reported on Aug 24 from EVA, the ClinVar evidence now contains a broader set of clinical significance terms. The new terms:

low penetrance
uncertain risk allele
established risk allele

TODOs

[ ] Adding these values to the JSON schema
[ ] Release JSON schema for the September OpenTargets Platform release that contains this modification.
[ ] Update ETL configuration to handle and assign score to evidence with these clinical significance values.

PR on JSON schema merged. PR#160
JSON schema release is out: v2.2.8

How the scoring is sorted out for these new categories:
'low penetrance': 0.3,
'uncertain risk allele', 0.3,
'established risk allele', 0.5,

Update staged: PR#259

Gitbook updated and merged.


receiving error if _this.$props is not defined

Hello
the current Beta-9 results in following error of _loop function:
TypeError: Cannot read property 'hasOwnProperty' of undefined     at _loop
Responsible for this error is that _this.$props is undefined.
https://github.com/Akryum/vue-apollo/blob/master/src/index.js#L43

Downgrading to 3.0.0-beta.5 is fixing the issue for me at the moment. @Akryum not sure why $props|$data is undefined in my code but it happens on route transition. Is it possible to change the lines to not rely that props or data is present?

Running into same issue. Was able to get around it by adding props: []

@loitran where did you place the props:[]? I use vue-apollo combined with Nuxt and the current beta.9 is not working for me currently

@dohomi place it in your vue component.
export default {   name: 'organizations',   props: [],   apollo: {} }
I'm running 3.0.0-beta.9

@loitran that is more-less not really an option for me. I use apollo quite extensively on https://github.com/lumen-cms/lumen-cms and for example in the usage with NuxtJs pages will never use props by nature

@dohomi @Akryum submitted a pull request with a fix.
https://github.com/Akryum/vue-apollo/pull/279


Keep text selection ranges within the length of the text

Fixes https://github.com/flutter/flutter/issues/11041

@Hixie

Thanks for spotting! This may fix an issue where I was seeing strange incoming selection indices on the iOS side when I was last working on text editing.


Qt-Wallet Can't run cold wallet when not connected to network.

When starting up the cold wallet without a network connection, after a few minutes you will get a dialog pop-up saying:
Embedded MWC-Node Error
mwc-node process exited due some unexpected error. The exit code: 127
...
Since this is a dialog, all use of the wallet is blocked even if you move the dialog out of the way and try to continue to use the wallet. Once you click on either option in the dialog (e.g. keep embedded, switch to cloud), the wallet shuts down.

Verified with the latest QT wallet build without a network connection and not hitting "get a dialog pop-up saying:
Embedded MWC-Node Error...". Hence closing this ticket.


Rearrange auth related modules with ballerina/auth.* pattern

Description:
Need to rearrange all the auth related modules in the way of import should have ballerina/auth.* pattern as follows:

Module Name
Current Import
New Import

Auth module
ballerina/auth
ballerina/auth

JWT Auth module
ballerina/jwt
ballerina/auth.jwt

LDAP Auth module
ballerina/ldap
ballerina/auth.ldap

OAuth2 module
ballerina/oauth2
ballerina/auth.oauth2

Closing this issue since it is no longer valid because some APIs are not just use for authentication purposes.


failures during epub view

I need my epub data to always be fetched from storage.
Because The epub view does not display when my internet is connected,
but it works well when i disconnect my internet .
How do i set the epub to always fetch from storage by default and not use the internet.

How do i always fetch epub from storage. i am having issues when it fetches from the internet

@mahavir155 How do i always fetch epub from storage. i am having issues when it fetches from the internet?

@hrishikesh-kadam The app works great without internet, but when phone is connected to internet, it shows empty white screen after loading


v-show on custom-control does not work

I was trying to show/hide a custom control like this:
<custom-control v-show="canShow">
</custom-control>

This does not work. It works only if v-show is applied to a child node of custom-control. Is it intended?

You'd have to use v-if instead

Your v-show is conflicting with a v-show we already have on the root div of the component.
v-if gets around that because it triggers our logic to create/remove the custom control from the map when the component is created/destroyed.
I'll push a fix for this but in general most of our components will require v-if because vue isn't really rendering anything, just instantiating and removing map objects (the only exception being custom controls, custom markers and info windows). v-show works by setting display: none via inline styles on DOM elements which vue controls.


Fix bug test on value if it is json object

There's is a bug in match json objects

Hello @TahiriAbdou . Thanks for contributing. Can you show me an example that can replicate the bug?

Basically, The bug show when you try to store a value starts with {.
for my case example i had this value : {title} online, free {title} download  . i always get a null value because this value is behaved like a json object.
I guess same issue with [ .


Adding is.webapp()

Detects if website is running inside an iOS Web App. Supports 'not' interface.

Thanks!
We'll keep an eye on the popularity of the request.


add bdd folder

Codecov Report

Merging #45 (f6ce859) into master (d0d4d63) will increase coverage by 13.71%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #45       +/-   ##
===========================================
+ Coverage   76.56%   90.28%   +13.71%
===========================================
  Files           5        5
  Lines         384      463       +79
===========================================
+ Hits          294      418      +124
+ Misses         90       45       -45

Impacted Files
Coverage Δ

service/model.py
90.90% <0.00%> (+16.07%)
:arrow_up:

service/route.py
89.44% <0.00%> (+21.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d4d63...f6ce859. Read the comment docs.


Improve Utility Tools - Zip File Upload

Add a utility for uploading Zipfiles (containing various .txt files) and then run selected model over each files with verbose analytics.
Emails to senders.

Making this feature on streamlit that will take zip files extract csv from it and then display the results with a feature to download it from that place.


Setup two independent scrollareas

Current Behavior
So I'm currently using smooth-scrollbar just like described in the documentation. I have an element I apply Scrollbar.init() to. It works fine - but as soon as I define another scrollarea (on different element) - again using Scrollbar.init() - solely the scrollbar which was defined at first works.
Desired Behavior
I want both scrollareas to work independently from each other. In other words, when I'm inside of the first component the first scrollarea is supposed to scroll, and when I'm in the second component, the second scrollarea is supposed to scroll.
Is there an already implmented way to handle this behavior? If not, deactivating the first scrollarea and acivating the second, when navigating to the second component (and vice versa) would be fine as well.

Can you show me a demo of this issue? There should be no limit to the amount of scrollbars.

Here's a quick demo in form of a codepen: https://codepen.io/magiix/pen/eYpBXbd
The element scroll-content is being created for both scrollbars, but solely the first is working.
Is my approach wrong in general?

The problem is caused by the delegateTo and continuousScrolling options here:
  const home = Scrollbar.init(homeRef, {
    delegateTo: document,
    damping: 0.15,
    continuousScrolling: false,
  });
  const about = Scrollbar.init(aboutRef, {
    delegateTo: document,
    damping: 0.15,
    continuousScrolling: false,
  });

When events from both scrollbars are delegated to a same element, i.e. document, and continuousScrolling are both set to false, only the first one scrollbar in your code will scroll when wheel event fires.
You can remove the delegateTo options or set them to different values to fix this issue.

Thanks! That did the trick.
One more thing though, how come the overscroll bounce effect isn't working for this codepen? I took a look at common mistakes but I couldn't figure a way to enable it.

The overscroll plugin need to be enabled using
Scrollbar.use(OverscrollPlugin)

See: overscroll plugin.


Add org Groote Schuur Hospital, 1st site using zulu

https://jira.movember.com/browse/IRONN-141

@ivan-c  another org change for this week... first site to use Zulu


Include dotnet target in NuGet

As discussed in #270 we should support CoreCLR via NuGet.
This means duplicating the PCL target within a new folder called \lib\dotnet.

See #283 for a much-welcomed PR to this issue.


How to implement session management with CRA? (discussion)

Dear everybody,
I was building a React app based on CRA which includes:

CRA at front end.
API at Backend (with Node and Express).

I've made proxy and called API from CRA app successfully. However, I couldn't find out how to use session at CRA? (although I could use express-session & passport with another Node apps)
My current scenario:

Write a authenticate API at backend for Login feature.
Call API at CRA app and login success.
(Still finding how to store user session...)

I thought about localStorage but I'm not sure about it. I also find guide from official Create-React-App project but ...opss....
Let me know if you've already implement this feature. Thanks a lot!

This is a fine question but seems a little out of scope of CRA. CRA is just a tool to create and run projects. How you implement authorisation depends on your project and as far as I know unrelated both to React and CRA. You may want to search for something like "authorisation in single page apps" on the Internet.

I'll close for this reason, as this issue doesn't seem actionable for us. If you find a satisfactory answer please feel free to share it in this thread.

Dan, could you clarify:
are you saying that to add an authentication flow, it is necessary to eject from CRA?

No, why? CRA provides you the build setup. It has no opinion about how you structure your app and implement features (such as authentication) in it. Anything you can do in JavaScript, you can do within an app created with CRA.

Suppose the requirement is that I do not want to serve any routes that would use the historyApiFallback (i.e., serve index.html + bundle.js) unless the user is authenticated. How do I express this without ejecting from the framework?
Or is the assumption that the React index.html and the bundle.js, thus all React code, will be served to anyone and all authentication would take place via an API to which CRA forwards requests it cannot handle?
What I really like to do is to do is to ensure authentication on certain history fallback routes (say /secretprofile) but not on others.  Given that CRA's webpack server serves the history fallback routes, how is it that CRA does not have an opinion on how I need to do this?

Suppose the requirement is that I do not want to serve any routes that would use the historyApiFallback (i.e., serve index.html + bundle.js) unless the user is authenticated.

History “fallback” on development server is not meant to be a sophisticated routing solution. It exists only to let your client-side app handle routing, and how it does it is outside of development server’s concerns.
Is not serving bundle.js to unauthenticated users a hard requirement?
You can still “protect” routes on the client without actually hiding that code. This would be much simpler to implement with a client-side router, and is totally possible within CRA. (To learn how to do it, consult your client side router documentation and examples.)
If your intention is to not serve the code for unauthorized routes, it gets trickier. For example, you could potentially use code splitting to separate bundles (we support Webpack’s require.ensure extension for code splitting) but the name of the bundle would still be hardcoded in the initial bundle code. So it’s not as much “protection” as it is “cutting unused code”. In general my opinion is that trying to “secure” JS code from being viewed is not a worth endeavor, and if you want to do it, you need something more sophisticated than a single-page app.

Alright, thanks. I think I understand the approach and should be able to implement it.
I suppose the underlying issue is the lack of familiarity. In fact, I couldn't even define the word "build setup" you bolded.  Because of that, one is left to wonder if a given feature is supported by CRA and one must look for the right way of doing it, or the right hook, or whether one should directly implement it outside CRA (but without ejecting), and whether that's even possible.

Yea, I definitely see how this could be challenging at first. I promise you’ll get better at it, but I’m not sure how I can help.

I couldn't even define the word "build setup" you bolded

What I mean is that there are two steps:

First, your project is compiled on your machine. A static build folder is produced with the HTML file and all JS assets.

Then, you can put it on your server and serve to the users. At this point you can’t change how the code was bundled (e.g. how it is split into files), and you can’t serve different HTML files because there is just one. However your JavaScript code can dynamically decide how to handle routes and implement the logic for authorization.

If you removed CRA from the equation, you could do something more sophisticated, like a “mixed” single-page app that also has some logic on the server. We think it’s more complex for beginners, and we also don’t want to dictate usage of any specific web server, so CRA only supports building single-page apps without server-side logic.
I hope this helps!


Subclasses of vehicle

Description of the issue
From issue #1267:
So far, we have subclasses of vehicle only by type of propulsion. We might add subclasses of vehicle by type of
Ideas of solution
Just a first structure with some ideas for definitions:

land vehicle: A land vehicle is a vehicle that are moved by applying forces against the ground.

road vehicle: A road vehicle is a vehicle that uses roads.

motorised road vehicle: A motorised road vehicle is a road vehicle that has a traction motor.

car: A car is a motorised road vehicle that is used for passenger transport and has a maximum of eight seats.
bus: A bus is a motorised road vehicle that is used for passenger transport and has more than eight seats.
truck: A truck is a motorised road vehicle that is used for freight transport.

bicycle: A bicycle is a road vehicle that has two wheels and is propelled by a person.

rail vehicle: A rail vehicle is a vehicle that uses railway tracks.

locomotive: A locomotive is a rail vehicle that has a traction motor and provides propulsion for a train.
railroad car: A railroad car is rail vehicle that ...

aircraft: An aircraft is a vehicle that is flying in the air.

airplane: An airplane is an aircraft that has fixed wings.
helicopter: A helicopter is an aircraft that has rotating wings.

We further might add an equivalent class 'motorised vehicle' EquivalentTo: vehicle and 'has part' some 'traction motor'): A motorised vehicle is a vehicle that has a traction motor.
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

That is a good starting point. Here is bit of a different thought to the categorisation of vehicles:
Last week I had a discussion about "combined" subclasses that respect both the working environment of the vehicle and the type of propulsion. The result for BEV as an example would be subclasses BE land vehicle, BE watercraft, and BE aircraft. And maybe even BE road vehicle and BE rail vehicle as subclasses of BE land vehicle.
I mention this, because having terms that combine the probably two most important categorisations of a vehicle could be advantageous. However, doing this even more fine grained (e.g. BE car, BE bus, BE truck ...) would be very tedious, so I would limit it to a coarse level. Also, doing this solely would exclude the possibility to denote for example land vehicles regardless of the propulsion type. So, this would be an addition to your suggestions and not a substitute.
If that feels too much like redundant work or not worth the little extra comfort for modelling, I don't mind dropping this idea.

Using equivalent classes, we can create a multi-hierarchical structure.

So do we agree on implementing the classes above? To not blow up this issue to much, I suggest that we add more fine grained subclasses like battery-electric truck in a second step.

I just saw, that my list above needs a proper definition of railroad car. So here is a proposal:  A locomotive is a rail vehicle that has no traction motor.

We might also add a train: A train is an object aggregate that consists of rail vehicles.

Motorcycles and e-bikes: My definition proposal of bicycle has an is propelled by a person. That excludes motorcycle as subclass, but allows e-bikes as subclass. An definition of an e-bike could be: An e-bike is a bicycle that is propelled by a person and an electric traction motor.
Regarding your arguments on rail vehicles that have a transport capability and provide their own propulsion I have not yet an clear opinion.
Making train equivalent to object and (uses some railway) would not solve the problem for train, as a single railroad car is (at least in my understanding not a train) as it can not move itself.
But a completely different idea: We have to keep in mind that we are not building a transport ontology but an energy modelling ontology. Maybe we don't need to include locomotives and railroad cars at all. Maybe it is for our domain enough to include:

A train is a vehicle that uses railway tracks.

A freight train is a train that is used for freight transport.
A passenger train is a train that is used for passenger transport.

Are there any transport models in the energy modelling domain, that explicitly model railway transport with single vehicles like locomotives and railroad cars?
I agree to your proposals of water vehicles.

I like your solution for motorcycles/e-bikes.
The distinction between locomotive, railroad car and mixed forms could be interesting for economic models that try to reduce the number of empty drives. But that is not the focus here, so I agree with your new definitions.

Okay, so I think we have an agreement and implement what we have discussed above.

I think the following alternative labels are useful:

bike to bicycle
motorbike to motorcycle
automobile to car
autobus to bus
lorry to truck

To make it possible that internal combustion vehicle and its subclasses can be inferred as subclasses of motorised vehicle, the axiom 'internal combustion vehicle' 'has part' some 'internal combustion engine' has to be extended to 'has part' some ('internal combustion engine' and 'participates in' some propulsion). But I think, that even better reflects its definition: An internal combustion vehicle is a vehicle powered by an internal combustion engine.


Build Docker images with pre-installed PISCES

[ ] Add a Dockerfile to define build process and entry point
[ ] Set up gh-actions to build docker images and publish to Docker hub

@guma44 I'll update this issue with progress and issues building a docker image. We should discuss how to integrate the container in Cromwell. I find this in the Cromwell docs - is it a relevant starting point? baseCommand can be the pisces command, but I'm not sure about specifying inputs/outputs.