adds handling of multiple face responses in single image; closes #77

Closes #77. When initializing a GoogleVisionAPIFaceExtractor, the handle_annotations argument now takes a value of either first (returns only the first detected face) or prefix (the default), which prefixes each column name with face%d_.

Coverage decreased (-0.3%) to 77.476% when pulling 8afef61bd925c414fbb4908ccbad38fce202437d on fix-face-extractor into b8528ef85a240c4e752ef62000fcf5a201aa59bb on master.


@types/bingmaps

Can you work with the typescript team to get this released on @types.
It's much easier to manage using npm that way without having to pull the definitions into a local project.
See
https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/

I'll look into it, but it doesn't look like those are managed by the TypeScript team at Microsoft. We have very specific rules we have to follow to make things open source, so not sure if this is an option or not. This is why we didn't make these appart of DefinatelyTyped.

Yeah, I've worked at Big Corporations before and know how much of a hassle it can be.
Of course, the best answer would be to release the Bing Maps javascript api on NPM and include the typescript definitions along with the library, but oh how I dream.
Another option would be to add a typings.json to this repository then we can download with the typings tool using the "github:Microsoft/Bing-Maps-V8-TypeScript-Definitions" format.

Ok, I'll put aside some time next week to try and get this setup on npm. I'll also reach out to the owners of @types project to see how best to link this there without moving this project.

I would really like to see this! I've just switched to the new version of the Angular CLI (webpack) and it's no longer using typings.json, only "@types".

I've had a talk with the author of that blog post. Going through this project he ended up recommending using DefinatelyTyped instead of @types for this project.

These definitions are not available through npm. Simply type:
npm install -g bingmaps

@rbrundritt I guess you mean now instead of not? :) Good stuff.
https://www.npmjs.com/package/bingmaps

Correct. I meant "now" not "not". It was a long day yesterday :)


[SUPPORT] Disaster Recovery (DR) Setup? Questions.

Are there any tips or support on setting up a Disaster Recovery (DR) environment with Apache Hudi?
We are creating our Datalake, stored on AWS S3, by running a Spark structured streaming application on AWS EMR. The Spark application is processing incoming data from a AWS Kinesis stream and saving them into Hudi tables on S3 and syncing with the AWS Glue catalog. All of this happens in a single AWS region (us-east-1).
In the event where we need to failover to a different region or our main region (us-east-1) goes down, what is the suggested approach to get start up again in another AWS region with our existing Datalake data? We can set up S3 replication to replicate the parquet files (and .hoodie files) to another S3 bucket residing in a different AWS region, but S3 replication happens asynchronously which means files may get replicated out of order and cause issues when querying (due to possible missing files). We will need to look at how to replicate Glue databases/tables from 1 AWS region into another, so that other AWS services and/or query engines can query.
Would love to hear some ideas/thoughts :)
Trying to workaround an issue like this: https://www.datacenterdynamics.com/en/news/aws-us-east-1-outage-brings-down-services-around-the-world/
Environment Description

Hudi version : 0.7.0-amzn-1

Spark version : 2.4.7

Hive version : 2.3.7

Hadoop version : 2.10.1

Storage (HDFS/S3/GCS..) : S3

Running on Docker? (yes/no) : no

I ran a test where I deleted some .parquet files from a Hudi table (stored on S3) to simulate S3 replication lagging behind in the copy process and therefore causing the target S3 bucket to have missing data files. Then used AWS Athena to query the Hudi table with missing data files.
Result:

Query ran successfully with missing data files (.parquet) - AWS Athena did not error out.
The returned results were incorrect (count and data returned did not match with original Datalake). This makes sense because .parquet data files are missing.

Next, I wonder what happens if S3 replication is slow and it's not able to replicate the files in .hoodie folder fast enough - what happens when I run SQL queries on a Hudi table with missing .hoodie files?

There is a preview available for AWS Backup for S3, this might be interesting to use in future. AWS claims that you can do point in time recovery with it: Continuous backups create point-in-time backups, and allow you to restore S3 resources to any point-in-time within the last 35 days.

Thanks @kazdy for your input. I read the documentation for AWS Backup and S3 support.
Based on the documentation, I am assuming we can do the following (using the us-east-1 issue that occurred on 2021-DEC-7):
FAILURE SCENARIO:

Create a backup of Hudi Datalake S3 bucket on us-east-1 using AWS Backup and create a copy of that in region X.
When us-east-1 failure/issue occurs, then restore Hudi Datalake S3 bucket backup (created from us-east-1) into a different S3 bucket in region X.

FALLBACK SCENARIO (when us-east-1 is stable again):

Create a backup of Hudi Datalake S3 bucket on region X using AWS Backup and create a copy of that in us-east-1.
When ready to fallback to us-east-1, then restore Hudi Datalake S3 bucket backup (created from region X) into a S3 bucket in us-east-1.

Sounds like above scenario should work - won't be able to test this until AWS Backup for S3 is generally available.

@WTa-hash have you tried using savepoint feature? Maybe it'll allow you to deal with these issues when using s3 replication and missing .hoodie files? There will be some missing data, but maybe tables will not be corrupted?

@xushiyan @bhasudha @bvaradar @yanghua : Do you folks have any pointes on this regard.

@WTa-hash have you tried using savepoint feature? Maybe it'll allow you to deal with these issues when using s3 replication and missing .hoodie files? There will be some missing data, but maybe tables will not be corrupted?

No, I haven't. Can you link me to documentation about the savepoint feature.

We don't have any documentation as such. You need to directly use writeClient or go via hudi-cli.
But here is how you can do savepoint and restore using hudi-cli
connect --path /tmp/hudi_trips_cow
commits show
set --conf SPARK_HOME=[SPARK_HOME_DIR]
savepoint create --commit<PHONE_NUMBER>2853592 --sparkMaster local[2]

// restore

refresh
savepoint rollback --savepoint<PHONE_NUMBER>5108487 --sparkMaster local[2]

btw, savepoint and restore for MOR is added just few weeks back and so is available only from 0.11. But should work for COW for older releases too.

I will try to add more documentation around savepoint/restore to our website.

recently we also updated instructions on how to use hudi-cli for S3 dataset.
https://hudi.apache.org/docs/next/cli/
just incase you you interested.

Closing this as hudi has savepoint and restore for both table types. Feel free to reopen or create new github issue if you need further assistance. thanks!

For anyone looking at this question now, I see there's documentation available for "current" version (0.11):
https://hudi.apache.org/docs/next/disaster_recovery


Align the argo policy

This should align the argocd rbac policy for namespaced instances to the
same as the main argo instance.
This was initially pushed via 3ee9bb64127081520050e502e497e55056bfa41a
in multicluster-devsecops. Since it is for common/ let's place it in the
proper repo.

Set to draft until we test it thoroughly

lgtm


Unable to Change Staff Member's Costume

Bug Description
When attempting to change a staff member's costume, an error message reading "Unknown Unknown" appears, and the costume does not change. Entertainers can change to the default guest costume and other entertainer costumes, but no others.
Steps To Reproduce

Install the current release of PeepEditor into the latest dev build of OpenRCT2.
Create or Load a save.
Use Peep Editor to select any staff member.
Attempt to change their costume. Any will do.
View error message and observe lack of changed costume.

Expected Behavior
The staff member should change their appearance to match the selected costume, and no error message should appear.
Screenshots

First of all, apologies for the late response.
I am working on a new version that is compatible with the latest develop, I shared it on several Discords when there were breaking changes. But recently I released a beta version here, so there is a compatible version. Keep in mind, not all functionality is there. You can find it here:
https://github.com/Manticore-007/OpenRCT2-PeepEditor/releases/tag/v24.7.7-beta


[Bug] [seatunnel-core-spark] spark on yarn cluster mode  can not get --config/-c  file

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
when  use spark-submit   yarn  cluster  deploy-mode ，spark can not  get  config  file on yarn
SeaTunnel Version
2.1.1-prepare
SeaTunnel Config
env {
        spark.master = yarn
        spark.app.name = "20220315"
        spark.executor.instances = 1
        spark.executor.cores = 1
        spark.executor.memory = "4g"
        spark.driver.memory = "4g"
        spark.yarn.keytab = "xxxx.keytab"
        spark.yarn.principal = "xxxxxx"
        spark.yarn.queue = "xxxxxx"
}
source{
 jdbc {
        driver = "com.mysql.jdbc.Driver"
        url = "xxxxxxxxxx"
        table = "xxxxxxxxxxx"
        result_table_name = "xxxxxxxxxxx"
        user = "root"
        password = "xxxxxxxxxxx"
}

}

transform{
 sql {
        sql = "select   * from xxxxxx"
        result_table_name = "xxxxx"
}
}
sink{
jdbc {
        driver = "com.mysql.jdbc.Driver"
        source_table_name = "xxxxx"
        saveMode = "append"
        url = "xxxxx"
        user = "root"
        password = "xxxxx"
        dbTable = "xxxxx"
        }
}

Running Command
bin/start-seatunnel-spark.sh --master yarn --deploy-mode cluster -c config/application.conf

Error Exception
22/04/24 14:27:19 WARN conf.HiveConf: HiveConf of name hive.strict.checks.cartesian.product does not exist
22/04/24 14:27:20 INFO security.AMCredentialRenewer: Scheduling login from keytab in 18.0 h.
22/04/24 14:27:20 INFO yarn.ApplicationMaster: Preparing Local resources
22/04/24 14:27:20 INFO yarn.ApplicationMaster: ApplicationAttemptId: appattempt_1647333129725_263600_000001
22/04/24 14:27:20 INFO yarn.ApplicationMaster: Starting the user application in a separate Thread
22/04/24 14:27:20 INFO yarn.ApplicationMaster: Waiting for spark context initialization...
22/04/24 14:27:20 INFO config.ConfigBuilder: Loading config file: ./config/application.conf
22/04/24 14:27:21 INFO config.ConfigBuilder: parsed config file: {}

22/04/24 14:27:21 ERROR seatunnel.Seatunnel:

===============================================================================

22/04/24 14:27:21 ERROR seatunnel.Seatunnel: Fatal Error,

22/04/24 14:27:21 ERROR seatunnel.Seatunnel: Please submit bug report in https://github.com/apache/incubator-seatunnel/issues

22/04/24 14:27:21 ERROR seatunnel.Seatunnel: Reason:No configuration setting found for key 'env'

22/04/24 14:27:21 ERROR seatunnel.Seatunnel: Exception StackTrace:org.apache.seatunnel.shade.com.typesafe.config.ConfigException$Missing: No configuration setting found for key 'env'
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.findKeyOrNull(SimpleConfig.java:156)
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:174)
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:188)
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:193)
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.getObject(SimpleConfig.java:268)
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.getConfig(SimpleConfig.java:274)
	at org.apache.seatunnel.shade.com.typesafe.config.impl.SimpleConfig.getConfig(SimpleConfig.java:41)
	at org.apache.seatunnel.config.EnvironmentFactory.getEnvironment(EnvironmentFactory.java:47)
	at org.apache.seatunnel.config.ExecutionContext.<init>(ExecutionContext.java:49)
	at org.apache.seatunnel.command.spark.SparkTaskExecuteCommand.execute(SparkTaskExecuteCommand.java:44)
	at org.apache.seatunnel.command.spark.SparkTaskExecuteCommand.execute(SparkTaskExecuteCommand.java:36)
	at org.apache.seatunnel.Seatunnel.run(Seatunnel.java:48)
	at org.apache.seatunnel.SeatunnelSpark.main(SeatunnelSpark.java:27)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.spark.deploy.yarn.ApplicationMaster$$anon$2.run(ApplicationMaster.scala:685)

Flink or Spark Version
No response
Java or Scala Version
No response
Screenshots

it can not get file so ERROR seatunnel.Seatunnel: Reason:No configuration setting found for key 'env'
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

can you rerun command with bash -x ./bin/start-seatunnel-spark.sh... and paste log here?

CMD='${SPARK_HOME}/bin/spark-submit --class "org.apache.seatunnel.SeatunnelSpark" --name "xxxxx" --master "yarn" --deploy-mode "cluster" --files "plugins.tar.gz,config/xxxxxx" --conf "spark.executor.memory=4g" --conf "spark.driver.memory=4g" --conf "spark.master=yarn" --conf "spark.yarn.keytab=xxxxx" --conf "spark.app.name=20220315" --conf "spark.executor.cores=1" --conf "spark.executor.instances=1" --conf "spark.yarn.principal=xxxxx" --conf "spark.yarn.queue=xxxxx" lib/seatunnel-core-spark.jar --master yarn --deploy-mode cluster -c config/xxxxxx'
this is the submit command，when run on yarn ,-c config/xxxxxx file Will not be found

Just add check to the command to solve the problem
@whb-bigdata
Running Command
bin/start-seatunnel-spark.sh --master yarn --deploy-mode cluster --check -c config/application.conf
Here are the details of my test
[xxxxxx@bigdata-app03 apache-seatunnel-incubating-2.1.1-SNAPSHOT]# ./bin/start-seatunnel-spark.sh --master yarn --deploy-mode cluster --check --config /mnt/services/seatunnel/spark_batch.conf 22/04/27 09:49:00 WARN NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable 22/04/27 09:49:01 WARN DomainSocketFactory: The short-circuit local reads feature cannot be used because libhadoop cannot be loaded. 22/04/27 09:49:01 INFO EsServiceCredentialProvider: Loaded EsServiceCredentialProvider 22/04/27 09:49:01 INFO Client: Requesting a new application from cluster with 5 NodeManagers 22/04/27 09:49:01 INFO Configuration: found resource resource-types.xml at file:/etc/hadoop/<IP_ADDRESS>-315/0/resource-types.xml 22/04/27 09:49:01 INFO Client: Verifying our application has not requested more than the maximum memory capability of the cluster (6144 MB per container) 22/04/27 09:49:01 INFO Client: Will allocate AM container, with 1408 MB memory including 384 MB overhead 22/04/27 09:49:01 INFO Client: Setting up container launch context for our AM 22/04/27 09:49:01 INFO Client: Setting up the launch environment for our AM container 22/04/27 09:49:01 INFO Client: Preparing resources for our AM container 22/04/27 09:49:02 INFO EsServiceCredentialProvider: Hadoop Security Enabled = [false] 22/04/27 09:49:02 INFO EsServiceCredentialProvider: ES Auth Method = [SIMPLE] 22/04/27 09:49:02 INFO EsServiceCredentialProvider: Are creds required = [false] 22/04/27 09:49:02 INFO Client: Source and destination file systems are the same. Not copying hdfs:/hdp/apps/<IP_ADDRESS>-315/spark2/spark2-hdp-yarn-archive.tar.gz 22/04/27 09:49:02 INFO Client: Uploading resource file:/mnt/services/seatunnel/apache-seatunnel-incubating-2.1.1-SNAPSHOT/lib/seatunnel-core-spark.jar -> hdfs://nameservice1/user/xxx_user/.sparkStaging/application_1643094720025_42346/seatunnel-core-spark.jar 22/04/27 09:49:03 INFO Client: Uploading resource file:/mnt/services/seatunnel/apache-seatunnel-incubating-2.1.1-SNAPSHOT/plugins.tar.gz -> hdfs://nameservice1/user/xxx_user/.sparkStaging/application_1643094720025_42346/plugins.tar.gz 22/04/27 09:49:03 INFO Client: Uploading resource file:/mnt/services/seatunnel/spark_batch.conf -> hdfs://nameservice1/user/xxx_user/.sparkStaging/application_1643094720025_42346/spark_batch.conf 22/04/27 09:49:03 INFO Client: Uploading resource file:/tmp/spark-9bbe4cf2-c001-4c0c-a918-7a552a6e5b5b/__spark_conf__1828107881235032523.zip -> hdfs://nameservice1/user/xxx_user/.sparkStaging/application_1643094720025_42346/__spark_conf__.zip 22/04/27 09:49:03 INFO SecurityManager: Changing view acls to: xxxxxx,xxx_user 22/04/27 09:49:03 INFO SecurityManager: Changing modify acls to: xxxxxx,xxx_user 22/04/27 09:49:03 INFO SecurityManager: Changing view acls groups to:  22/04/27 09:49:03 INFO SecurityManager: Changing modify acls groups to:  22/04/27 09:49:03 INFO SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users  with view permissions: Set(xxxxxx, xxx_user); groups with view permissions: Set(); users  with modify permissions: Set(xxxxxx, xxx_user); groups with modify permissions: Set() 22/04/27 09:49:03 INFO Client: Submitting application application_1643094720025_42346 to ResourceManager 22/04/27 09:49:03 INFO YarnClientImpl: Submitted application application_1643094720025_42346 22/04/27 09:49:04 INFO Client: Application report for application_1643094720025_42346 (state: ACCEPTED) 22/04/27 09:49:04 INFO Client:  	 client token: N/A 	 diagnostics: AM container is launched, waiting for AM container to Register with RM 	 ApplicationMaster host: N/A 	 ApplicationMaster RPC port: -1 	 queue: default 	 start time:<PHONE_NUMBER>796 	 final status: UNDEFINED 	 tracking URL: http://bigdata-master01:8088/proxy/application_1643094720025_42346/ 	 user: xxx_user 22/04/27 09:49:05 INFO Client: Application report for application_1643094720025_42346 (state: ACCEPTED) 22/04/27 09:49:06 INFO Client: Application report for application_1643094720025_42346 (state: ACCEPTED) 22/04/27 09:49:07 INFO Client: Application report for application_1643094720025_42346 (state: RUNNING) 22/04/27 09:49:07 INFO Client:  	 client token: N/A 	 diagnostics: N/A 	 ApplicationMaster host: <IP_ADDRESS> 	 ApplicationMaster RPC port: 0 	 queue: default 	 start time:<PHONE_NUMBER>796 	 final status: UNDEFINED 	 tracking URL: http://bigdata-master01:8088/proxy/application_1643094720025_42346/ 	 user: xxx_user 22/04/27 09:49:08 INFO Client: Application report for application_1643094720025_42346 (state: RUNNING) 22/04/27 09:49:09 INFO Client: Application report for application_1643094720025_42346 (state: RUNNING) 22/04/27 09:49:10 INFO Client: Application report for application_1643094720025_42346 (state: RUNNING) 22/04/27 09:49:11 INFO Client: Application report for application_1643094720025_42346 (state: FINISHED) 22/04/27 09:49:11 INFO Client:  	 client token: N/A 	 diagnostics: N/A 	 ApplicationMaster host: <IP_ADDRESS> 	 ApplicationMaster RPC port: 0 	 queue: default 	 start time:<PHONE_NUMBER>796 	 final status: SUCCEEDED 	 tracking URL: http://bigdata-master01:8088/proxy/application_1643094720025_42346/ 	 user: xxx_user 22/04/27 09:49:11 INFO ShutdownHookManager: Shutdown hook called 22/04/27 09:49:11 INFO ShutdownHookManager: Deleting directory /tmp/spark-11894826-40fd-484e-aac6-ec360c1f02c2 22/04/27 09:49:11 INFO ShutdownHookManager: Deleting directory /tmp/spark-9bbe4cf2-c001-4c0c-a918-7a552a6e5b5b
Code bug fixes
org.apache.seatunnel.command.spark.SparkTaskExecuteCommand
add Code
        if (DeployMode.CLUSTER.equals(sparkCommandArgs.getDeployMode())) {             confFile = Paths.get(sparkCommandArgs.getConfigFile()).getFileName().toString();         }

@quanzhian Thank you for your reply. If adding -- check is only to check the creation environment, not to execute the positive circulation, so it can succeed


Speaker unlink functionality doesn't appear to work (for admins)

Whether or not we should have this for speakers themselves, the action is visible on web2 for admins. We need to figure out why it's aparently a no-op, and decide what to do from there.

This link is also visible for speakers who claimed a talk. It shows a confirmation dialog and when I press ok, it just reloads the page with no changes.


Activity Page - Storage of Open Pit Coal Mining

Description:
Wireframe:
Following #253 we have a full stack example of how to generate an activity emissions form using the API form builder service.The implementation here should be very similar to the GSC activitiy page.
Documentation on the full stack steps necessary to create an activity page are in our docs
Use the excel file (BCIERS Reporting Fields V2 in the SME channel files  - Reporting App directory) provided by IRC to determine what the necessary activity, source type, gas type, methodology, reporting fields & related configurations that need to be added are.
Acceptance Criteria:
Given I am on the storage of open pit coal mining activity form page
When I first land on the page
Then the activity schema is fetched & displayed
Given the schema has rendered correctly
When I make selections that have dependencies (gas type, methodology)
Then the correct options and fields as defined from the configuration are shown
Development Checklist:

[x] Any activities, source types, gas types, methodologies or reporting fields needed for the configuration that are not already in the database are added
[x] The configuration relationships have correctly been added to the database
[x] The many to many reporting field data (if needed) has correctly been added to the database
[x] The base schema for the activity & source types have been added to the database
[x] A routing directory/page has been added to both the industry_user & industry_user_admin flows for the activity
[x] A parent component (named for the activity) has been added to the components in the activity directory
[x] The page fetches the correct initial activity schema from the API service on initial load
[x] A uiSchema exists in the components/activities/uiSchema directory for the activity & source types (will move to the database eventually, but can live here for now)
[x] Conditional fields render dynamically as data is entered
[x] On selecting a source type (or if there is only one, on loading the page) The first set of data fields is displayed (defaultEmptySourceTypeState)
[ ] Matches the wireframe

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

To test:-

Navigate to the reporting page.
Select Operation 3 from the list, then click Save and Continue.
Proceed to the Review Facilities page.
On the Review Facilities page, select Open Pit Coal Mining from the list of activities, and click Save and Continue. This action will take you to a new page with a URL similar to:
https://cas-bciers-frontend-dev.apps.silver.devops.gov.bc.ca/reporting/reports/1/facilities/f486f2fb-62ed-438d-bb3e-0819b51e3aff/activities?reports_title=Operation+3&facilities_title=Facility
In the task list, click Open Pit Coal Mining to open the activity form


Sorry, this is not an issue, just a request

You have coding skills in darts, if you don't mind porting your library to darts please?

You have coding skills in darts, if you don't mind porting your library to darts please?

Just call the Java library using the Dart channels if you are developing an app using flutter. Otherwise no, it would be impossible to migrate everything to dart


CMYK

It would be cool to be able to convert to an from CMYK :)

I have been holding off on device specific color spaces because of the hairy business around different devices. The values of CMYK depends on printers and the colors of their ink, which makes it particularly tricky, but I think I saw some "standard" formula somewhere that may be "good enough". Same for CMY. It's definitely worth investigating, since they are both very common.

Looks like there's no way to implement accurate CMYK without a color profile, since it depends on paper color, ink, etc. The only possibility without implementing color profile support is the naive implementation, where
black = 1 - max(red, green, blue)
cyan = (1 - red - black) / (1 - black), or 0 if black is 1
magenta = (1 - green - black) / (1 - black), or 0 if black is 1
yellow = (1 - blue - black) / (1 - black), or 0 if black is 1

red = 1 - min(1, cyan * (1 - black) + black)
green = 1 - min(1, magenta * (1 - black) + black)
blue = 1 - min(1, yellow * (1 - black) + black)

Some people may prefer to define their colors this way, so it may still be useful as an input interface, but the colors won't be accurate.

hm... I think something like black = 1 - max(red, green, blue) is not the solution we want.
But having a stuct that can hold CMYK values is useful. More general, a generic type that can hold n different channels could allow to define custom spaces. Let's say you want to print something special, then you'd define the colors c, m, y, k but also e.g. two spot colors custom0 and custom1.
And transforming from color space A to color space B should only be implemented if it is definite. In all other cases I'd offer a convert function where you can pass in your custom function.
That would look like this (pseudocode):
let my_rgb = Rgb::new(0.5, 0.3, 0.7);
let my_foo: FooColor = my_rgb.convert::<FooColor>(|channels|{
  let a = some_calc(channels[0], channels[2]);
  let b = some_cals(channels[1], channels[2]);
  FooColor::new(a,b)
});

Then you can also offer official standard profiles and just do s.th. like
let my_cmyk = my_rgb.convert::<Cmyk>(Cmyk::Profiles::ISOUncoded_v2);

What do you think?

Yea, something like that is probably the way to go. The main problem with implementing the naive variant is that it can be mistaken for the accurate variant, so I feel like it should be avoided. I'll postpone this for the time being, until a concrete solution comes up, but it looks like some form of color profile support is desirable. A more generic conversion interface can still be independently added. I'll open a couple of issues...

I think this should be straight forward enough with ICC profiles off the table. Palette's support should mainly be for the naive version (e.g. Cmyk<Srgb> and similar) or as a semantic value container (could be Cmyk<Any> or a different marker type). The documentation just need to be clear enough on regarding how the naive variant is not suitable for printing.

Oh wow, eight years have already passed... I (almost) can't remember which project I needed CMYK support for back then :rofl:
But it's still good to know that there are now new perspectives :wink:
Thank you! :+1:

Ah, yes, I have a better idea of what I'm building now. But other things have also been calling for more attention along the way, so this one had to be patient. 😅


Pinned postgres to 10.4 and pvl8 2.1.2

Pinned postgres to 10.4 and pvl8 2.1.2  to match current amazon rds versions.

Failing because docker cli requires a login.


[Ready to merge] replaced print with return in python templates

Signed-off-by: Vivek Singh<EMAIL_ADDRESS>fixes https://github.com/openfaas/templates/issues/13

Description

Motivation and Context

[ ] I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #13
How Has This Been Tested?

Tested on Docker for Mac
python-armhf is tested on scaleway server with armv7
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

No.. We don't. Should we add that?

I think so. It should even be the same base image

I will add that, Should I update this PR or raise a different pull request from that?

Let's update this one please

@alexellis I have updated this PR with new template python3 template for armhf.

LGTM. I'll merge.


ScrollControls from react-three/drei not working with Canvas

Hello! I have been using this starter to create a web app that needs to use orbit controls for some pages but toggles to use scroll controls on other pages. I have noted how orbit controls are implemented with the <LControl/>  component in canvas.jsx and pointer events are connected to the dom stored in global state.
However, trying to use react-three/drei's helper , <ScrollControls> (link to ScrollControl docs) within a page file has been unsuccessful. Pointer and scroll events seem to be dropped entirely and I have been left with an unresponsive screen after disabling the default orbit controls. As of now, I have tried connecting the dom in the global state to the <ScrollControls> helper and implemented a controls object similar to <LControl/> - that returns a <ScrollControls> object instead of Orbit -  but still all of my pointer events are not registering. Is there any way to reconfigure the canvas so that this scroll navigation helper can be used? Again, I hope to toggle between, scroll and orbit controls based on the page the client is on and anticipate using global state to do so. I appreciate any assistance with this as I've been stuck for almost 2 weeks now unfortunately :(

I'm having the same issue. My last resort is to create an entirely separate R3F Canvas in the page's JSX instead of adding canvas elements to the Page.canvas property.

Perfect thank you for the help @GabeDahl ! It looks like my created app is a couple commits behind the addition of the templates folder, so I will be migrating all my changes to the new react-three-next starter. I was able to find a hacky workaround with global state, and dreis ScrollControls helper but this approach is much cleaner in my opinion and hopefully would cause less reloads than my scroll controls toggle.
Along those lines , just a quick follow up. Would I be able to enable and disable scroll controls for specific pages with the Scroll.tsx component? I need orbit controls for my index.tsx page , but would require a scrollable canvas and dom for other pages. Im wondering how I would do this , and if a global state would be ideal in toggling the use of this utility?

Would I be able to enable and disable scroll controls for specific pages with the Scroll.tsx component?
Yeah, I made a little context above the scroll wrapper & canvas that has a simple pages value.

import { Dispatch, ReactNode, SetStateAction, createContext, useState } from 'react'

interface ScrollContextState {
  pages: number
  setPages: Dispatch<SetStateAction<number>>
}

export const ScrollContext = createContext<ScrollContextState>(null)

export const ScrollContextProvider = ({ children }: { children: ReactNode }) => {
  const [pages, setPages] = useState(1)
  return <ScrollContext.Provider value={{ pages, setPages }}>{children}</ScrollContext.Provider>
}

Then I set the pages in each route/page component
  useEffect(() => {
    setPages(3)
  }, [])

or
  useEffect(() => {
    setPages(1)
  }, [])

I'm currently working on a way to RELIABLY reset the camera position & scroll position/state upon route change, but it's too wonky error-prone right now

@gene-ius @GabeDahl Thank you for your input!
I'm facing the same issue while I was trying to use independent ScrollControls for individual pages. And somehow ScrollControls only works on top level (in _app.jsx), whereas not working in child component. Still figuring out why.
And based on discussion above,
does it mean I'll have to use Scroll template along with @studio-freight/lenis, instead of dreis ScrollControls helper?
Still really confused. If anyone can point out the right direction I'll be really appreciate it!

Native scroll should be supported OOTB, will investigate for a better implementation with lenis in the near future.


Mathematics highlighting overrides parenthesis coloring

Component:

[X] VSCode Extension
[ ] VSCodium Extension
[ ] LSP (used with other editor)

Extension version: v0.4.1
LSP version:
OS version and name: macOS 13.2

[X] I am on the latest stable version of the extension/LSP.
[X] I have searched the issues of this repo and believe that this is not a duplicate.

Issue

Currently the math coloring (which seems to be monochrome) overrides the default parenthesis pair coloring, presumably because they are all counted as String. I'm fine with limited highlighting functionalities, but it is very difficult to work with if even the built-in highlighting is turned off.

Is the issue here that "standard token type" for math seems to be "String"?
Outside of math it's "Other", and parentheses seem to work fine

As a workaround I replaced the existing part(s) of typst.tmLanguage.json with
{
    "name": "other.math.typst",
    "begin": "\\$",
    "end": "\\$",
    "captures": {
        "0": {
            "name": "punctuation.definition.other.math.typst"
        }
    }
},

which while not perfect at least enables colored parentheses.


Helm chart doesn't allow setting allowedTopologies for storage class.

Feature Request
Description
Storage class here: https://github.com/sergelogvinov/proxmox-csi-plugin/blob/main/charts/proxmox-csi-plugin/templates/storageclass.yaml doesn't allow defining/redefining allowedTopologies.
It would be great to have this possibility to manage hybrid clusters

Hi, it in my wish list...
Thanks.

@sergelogvinov I added a PR to add topologies to helm chart


A Scan has a failure.. Please approve to proceed

Approval required for following Workflow to proceed.

WorkflowName
Workflow#
BranchName
TriggerEvent
LastCommitUser

build-test
83
refs/heads/main
push
Yog4Prog

Issue Details
Found an Issue while performing SCA Scan
:point_right: You are required to Approve (or) Reject the issue
Approve or Reject by commenting in the below section with any of the following keywords
:green_book:  Approved Keys: approved approve lgtm goahead proceed yes
:closed_book: Reject Keys: denied deny reject rejected no abort cancel exit
:point_right: Note: If left uncommented the issue will be closed after the timeout period and the workflow will be marked unsuccessful.

Approval waiting period elapsed. Approval request is automatically closed and workflow status is marked to Failed.


Dashboard not found when deployed through Kubeflow

I'm deploying some RAPIDS containers through Kubeflow and the nvdashboard does not work properly.
When I attempt to view the dashboard I see Sorry, /nvdashboard/GPU-Memory is not a valid page. If I manually hit http:///notebook/kubeflow/dask/nvdashboard/GPU-Memory I see the dashboard.
I'm guessing somewhere we are using an absolute path to the nvdashboard and kubeflow and other similar deployment platforms require us to use relative paths.

Thanks for raising this! I've thrown in #23 as a first attempt to fix it. It's interesting that it seems to be able to get the list of dashboards (a json file) but not the dashboards themselves. Hopefully this will make things consistent.
@supertetelman do you have any interest in testing this PR out for me before I merge it?

That seems to be working.
I'm occasionally seeing what looks to be a different issue now on the NVLink tabs. The dashboard occassionally shows a 500 error and the logs are showing this:
ERROR:tornado.application:Uncaught exception GET /NVLink-Throughput (<IP_ADDRESS>)
HTTPServerRequest(protocol='http', host='sae-npn-01:32720', method='GET', uri='/NVLink-Throughput', version='HTTP/1.1', remote_ip='<IP_ADDRESS>')
Traceback (most recent call last):
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/tornado/web.py", line 1699, in _execute
    result = await result
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/tornado/gen.py", line 742, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/bokeh/server/views/doc_handler.py", line 55, in get
    session = yield self.get_session()
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/tornado/gen.py", line 735, in run
    value = future.result()
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/tornado/gen.py", line 742, in run
    yielded = self.gen.throw(*exc_info)  # type: ignore
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/bokeh/server/views/session_handler.py", line 77, in get_session
    session = yield self.application_context.create_session_if_needed(session_id, self.request)
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/tornado/gen.py", line 735, in run
    value = future.result()
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/tornado/gen.py", line 748, in run
    yielded = self.gen.send(value)
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/bokeh/server/contexts.py", line 215, in create_session_if_needed
    self._application.initialize_document(doc)
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/bokeh/application/application.py", line 178, in initialize_document
    h.modify_document(doc)
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/bokeh/application/handlers/function.py", line 133, in modify_document
    self._func(doc)
  File "/root/jupyterlab-nvdashboard/jupyterlab_nvdashboard/apps/gpu.py", line 233, in nvlink
    for i in range(ngpus)
  File "/root/jupyterlab-nvdashboard/jupyterlab_nvdashboard/apps/gpu.py", line 233, in <listcomp>
    for i in range(ngpus)
  File "/root/jupyterlab-nvdashboard/jupyterlab_nvdashboard/apps/gpu.py", line 230, in <listcomp>
    for j in range(nlinks)
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/pynvml/nvml.py", line 1999, in nvmlDeviceGetNvLinkUtilizationCounter
    check_return(ret)
  File "/opt/conda/envs/rapids/lib/python3.6/site-packages/pynvml/nvml.py", line 366, in check_return
    raise NVMLError(ret)
pynvml.nvml.NVMLError_NotSupported: Not Supported
ERROR:tornado.access:500 GET /NVLink-Throughput (<IP_ADDRESS>) 206.01ms

Great! This fix will be released in 0.1.10 shortly!
If you continue to have the other problem you mentioned feel free to raise another issue.


Install application vi 'git pull'

Is there a way to deploy an application with dokku from running a script on the deployment server using a 'git pull' command rather than pushing to the remote?

I use a chef recipe that pulls from github to a 'staging' directory and then git push into the local dokku instance. Nothing that will git pull directly into dokku

Feel free to re-open if you have any further comments on this.


Message deletion

Hey, awesome tool here,
at http://bullg.it, we're using it, but there is a strange behaviour, we're discussiing, and when we send a message, it gots directly deleted..

Hmm, I'm not sure about this. First of all, the screenshot doesn't look like gitter-cli, it does look like the gitter app, so you might want to reach them :smiley:

Well, not sure if it's a serious answer, but I'll re-explain.
Gitter is nice, it works, and we use it with my folks at bullgit, since the first beta release, and we love it.
Some of us started to use your cli client, to keep chatting at work, which is a good solution.
But most of the time, when you want to send a message with "ctrl + s" via gitter-cli, the message just don't show up in the console, so, in order to verify, I went on the gitter web version, and I was surprised to see that many messages sent with gitter-cli are deleted.
This ONLY HAPPEN with gitter-cli, so it is a gitter-cli issue.

Right, I get it now. I was confused for the screenshot.
I'll take a look at that. Thanks for reporting!

Thank you man, feel free to shoot me an email if you want me to give you my config / or anything else.

Just a heads up, I gave this a try for the first time and encountered the same issue. Running Ubuntu 16.04 if it matters.


NvTrueHDR - RTX HDR in games (testers needed!)

Noticed that nvapi64 exposed some TrueHDR profile settings a couple drivers ago but they never seemed to have any effect, when 551.23 released I did see the driver DLLs were trying to read from them now though, but settings still didn't seem to do much...
Digging around in the driver it turned out there were some other undocumented settings it needed enabled too, with those set it seems to activate fine 😺
Posted a tool that can set up the settings for you here: https://www.nexusmods.com/site/mods/781
Sadly haven't found a good way to take screenshots of the RTX HDR yet, but to me it seems to give slightly darker results than Windows AutoHDR, maybe preferable to some.
Only really tested this on my own system so far, would be interested in hearing any feedback from anyone who tries it!

Can't seem to get this working at all. I tried with Fortnite DX12, Dolphin Emulator DX12, and Yuzu VK with the DXGI Swapchain setting enabled. What does the HUD element look like? Also does NVCP show it as active because that is a good way to check if it's working for videos it changes live.

After a DDU it works finally. I have no clue what caused it to break since I had default NVCP settings

On my PC it doesn't find the profiles, even after adding them manually to the NVCP.
I also tried to run NvTrueHDR.exe as admin but it returns the same error.

On my system it doesn't find the profiles, even if I run it as administrator:

Hm, maybe try using the full path for the EXE, might be needed for profiles added in NVCP.
If it still doesn't work try using NV inspector with the XML on nexusmods.
@CeIIHunter I had same issue when trying to work out how to enable it, almost thought it was just broken & gave up on it till I did a clean install lol, glad you could get it working. Not sure which NVCP settings might be interfering with it, think I did have DXGI swapchain setting changed too, so maybe that's the cause?

Adding the entire path worked, I did a quick test and it looked great.
It's worth considering that it has a performance cost, with my 3080 Ti standing in the exact same spot and pointing at the same door on a building, I measured 54 fps with TrueHDR enabled vs 58 with it it disabled (6,89% performance loss).

@Artins90 I imagine this game is using RT and or DLSS? I believe Nvidia's HDR uses tensor cores so if a game doesn't make use of those cores there shouldn't be performance loss? Also yeah it looks great when compared to AutoHDR, a little dimmer than I'd like, but it seems like it uses a wider color gamut more appropriately.

Also @emoose I don't know if the DXGI swapchain causes it. I reenabled it after getting it working and it seems to function still. I'll update if it breaks after a reboot or something.

@Artins90 I imagine this game is using RT and or DLSS? I believe Nvidia's HDR uses tensor cores so if a game doesn't make use of those cores there shouldn't be performance loss?

It's Granblue Fantasy: Relink, it doesn't support DLSS nor raytracing.
Power usage definitely goes up considerably even when watching videos with RTX HDR, but I have no idea whether RTX HDR uses tensor cores or not.

just can't get it to work on any game i try. win10, latest driver fresh after ddu, aw3423dw. tried disabling all overlays(steam, nv, rtss) but nothing

doom 2016 with vk is the only one that sorta worked so far, but performance is horrific at around 2100ms per frame, starting it with opengl just doesn't do anything like with other games

Not really sure if it works on win10 unfortunately, seen a couple win10 users mention it not working at least... are there any Win10 users here that have it working?
I posted a quick TrueHDRTweaks tool at https://www.nexusmods.com/site/mods/781?tab=files to let you tweak some of the hardcoded values, haven't been able to figure out what they all are yet though, if anyone feels brave feel free to give it a try.

I have tested all values exposed by your ASI loader and written down what they do. Paper white multiplier is Value5 and it defaults to ~203 nits, which is a more appropriate than what AutoHDR default to at its minimum brightness (~300 nits or so, too bright for a dark room).
These are my suggested defaults, and they don't shift colors!
[Values]
# Value0 = Gamma? Seems like it's not a raw gamma formula but more of an indicator than pure gamma as it doesn't shift colors much, just their luminance. There's no way to set it to sRGB. 2.2 is the way to go for nearly all games
Value0 = 2.2
# Value1 = It doesn't seem to have no effect right now. It's not paper white or mid gray scaling nits.
Value1 = 150
# Value2 = Contrast: higher is more contrast, leave at 1 for original/neutral contrast)
Value2 = 1
# Value3 = The strength of the HDR highlights curve? Though it also seems to affect the average brightness and possibly shifts colors a bit (at least on negative values). Leave at 1 or more.
Value3 = 1.3
# Value4 = Saturation: higher is more saturation, leave at 1 for original/neutral saturation. This is no "smart" gamut expansion, it seems to shifts all colors equally
Value4 = 1
# Value5 = Paper white multiplier, expressed in an unknown format (it can go beyond 100, maybe 50 is neutral and 100 is 2x, 150 is 3x...). Supposedly it uses mid gray as scaling pivot. At 50 it's roughly 200 nits (or 203!), matching a Windows SDR->HDR brightness slider value of ~30. At 0 it's pitch black. Suggested value is 50, but it's based on preference
Value5 = 50
# Value6 = Peak Brightness in nits: suggested range is 750 to 1000 (or the peak brightness of your display anyway). Don't set this lower than ~400
Value6 = 1000
# Value7 = Doesn't seem to affect the image, it could be some internal parameter, like how many zones it divides the image in for analysys, or the LUT resolution
Value7 = 64.0
# Value8 = Doesn't seem to affect the image, it could be the quality of the HDR effect?
Value8 = 5

Is it possible to expose the tweaks of TrueHDRTweaks tool for videos as well -normal RTX HDR Video? Would be great to control how youtube and other streaming videos in browser will look!

So I can't figure out why but with Vulkan FPS either dies or it works it seems inconsistent for me for some reason. Have not gotten it working in OGL at all yet.

Is it possible to expose the tweaks of TrueHDRTweaks tool for videos as well -normal RTX HDR Video? Would be great to control how youtube and other streaming videos in browser will look! Oh, and this works beautifully in games particularly after the tweaks, many, many thanks!

v0.5 of the tweaks seems to apply to MPC-HC fine with the RTX video renderer, haven't tried it in browsers at all though, would guess the ASI loader might be able to load it into them but wouldn't be surprised if something might break it, if anyone tries it let us know how it went.
0.5 also added a bunch of extra unknown settings, one of them seems to have a pretty big effect on FPS, feel free to give them a try.

@CeIIHunter Have you gotten NvTrueHDR to work with Yuzu?
Switching to the DXGI swapchain is fine but as soon as I enable any profile for Yuzu, performance tanks to 0-1FPS (Mario Kart 8).
Auto HDR works with the renaming to cemu hack, but I really don't like how it looks.

@CeIIHunter Have you gotten NvTrueHDR to work with Yuzu? Switching to the DXGI swapchain is fine but as soon as I enable any profile for Yuzu, performance tanks to 0-1FPS (Mario Kart 8). Auto HDR works with the renaming to cemu hack, but I really don't like how it looks.

Nope never got it working. But we got the new driver update and nvidia app that lets you enable it. That'll probably work but currently it only supports one monitor. The NVTrueRTX still works with dual monitors so I'm still forcing it that way lmao. Thanks nvidia


Dep issues

#34 reminded me that we should write down the deps that need fixing. This applies to all repos, but a central list had to go someplace.
zeroconf is missing from some repos.
jarbas_utils is still present, and in some cases is causing both jarbas_utils and ovos_utils to come in. That's off the top of my head. I think I recall some unmigrated code in the voice sat.

I had mentioned in the chat that there was a DEP that I had to manually install on my Manjaro machine.
Going through my notes and logs, I believe it was pyasn1

Trying a new install on a Picroft device.  Half way through, I had to manually install libxml2-dev and libxslt1-dev


How to update the conda base environment?

Hi,
I am struggling a bit, trying to get a new environment deployed. For some reasons, it works on my local machine. Mamba can solve the environment and install it.
I was gonna try to update the conda base environment but I am not sure how to do that without breaking things.
@dsroberts can you help?
R

Also, what about using micromamba instead of miniconda?

There is no automated procedure for updating the base environment. Its outside of the containerisation anyway, so updating it would just follow the standard procedure for updating a conda env. Micromamba looks interesting, I had no idea it existed. I'd gladly replace a base conda environment with micromamba, but I'd a) alias the 'conda' command to it and b) make sure that it does everything users need the 'conda' command to do. That way, users can follow external conda docs and everything should work as expected.

I am really struggling with the deployment of a conda environment that includes esmvaltool, ilamb etc...
I am reconsidering things a bit and was thinking that having a separate environment for ESMValtool (which has a lot of dependencies) would be a better approach going forward.
I tried to deploy a new environment with a  different name, separate versioning, admin folder etc. but with the same base conda environment but I get an error with the build script. It can't find the base.sif file. It does not build the container as it considers that the container.def as not change.
It would be good to have your input. Are you planning to come to the NRI in the next few days?

Hmmm... The idea behind this setup was that the base conda installation would happen once per system, and any environments would be built on top of that. I can see the issue around versioning though, I guess it doesn't cope when you change it to build an 'ilamb-0.1' or 'esmvaltool-0.1' environment. I think that'd be a good feature to implement, maybe separating out different environment classes under the 'scripts' directory and separating out install_config.sh into site_config.sh and env_config.sh files would be the way to do that. Then the github action can detect which environment has changed, tell the scripts to source the appropriate env_config.sh and go from there.
I probably won't be in this week, but I'm happy to tee up something for next week. I'll ping you on slack and we can discuss further.

Hi @rbeucher. Reviving this issue as I took advantage of the January quiet time to revisit ways to handle creation and maintenance of different environments. This is the result of that. environment.yml files are now split into subdirectories of environments, and there are various hooks available for different behaviour required by different environments. My test repo has an example of an esmvaltool env and a simple xarray environment that can all be maintained and updated separately (or all at once if necessary). Github actions automatically detects which environment(s) have changed and runs the appropriate build/test/deploy steps.
I've also switched it to micromamba, which worked great apart from compatibility with nb_conda_kernels. It wasn't strictly necessary, but I've made some small modifications to micromamba around symlink handling and mamba info output just so that all of the available ipython kernels show up neatly when creating a new notebook in jupyterlab.
I'm planning to do the switchover on launch of the analysis-24.01 environment, which will be towards the end of next week. With any luck, users won't notice the change and I can quietly delete the entire conda base environment after a little while. Thanks for the discussion, and for raising this issue in the first place!

Hi @dsroberts,
Thanks! That looks great. I am going to have a look and will let you know how it goes. Thanks for sharing!

Completed in #64


Remove basic auth assumptions from the engine

Currently, the FHIR providers assume that the authentication for a terminology server will be based on basic auth.
Rather than do this I propose we make the providers accept a client, which may be authenticated by the implementing system by whatever means is necessary.

Resolved by #286


Empty repository.

The code doesn't work due to the fact that there is no code.

Bug fixed, there is now code in the repository.


[BUG]

Environment
Please provide as many details as you can:

Hosting type

[x] Form.io
[ ] Local deployment

Version:

Formio.js version: 3.27.3
Frontend framework: Angular 8.1.2 / angula-formio 3.26.1
Browser: IE
Browser version: Edge & 11

Steps to Reproduce

Add yes-no select or date-picker in form.io form.
Render form in the browser.

Expected behavior
Render normally
Observed behavior
Select and date-picker rendered is unusable
Example

"dependencies": {
"@angular/animations": "8.1.2",
"@angular/common": "8.1.2",
"@angular/compiler": "8.1.2",
"@angular/core": "8.1.2",
"@angular/forms": "8.1.2",
"@angular/platform-browser": "8.1.2",
"@angular/platform-browser-dynamic": "8.1.2",
"@angular/platform-server": "8.1.2",
"@angular/router": "8.1.2",
"@angular/cdk": "8.1.2",
"angular-oauth2-oidc": "8.0.1",
"angular-formio": "3.26.1",
"formiojs": "3.27.3",
"classlist.js": "1.1.20150312",
"core-js": "2.5.7",
"font-awesome": "4.7.0",
"ng-animate": "0.3.4",
"moment": "2.24.0",
"rxjs": "6.5.2",
"file-saver": "2.0.2",
"primeng": "8.0.2",
"primeicons": "2.0.0",
"chart.js": "2.8.0",
"quill": "1.3.6",
"bootstrap": "4.3.1",
"jquery": "3.4.1",
"popper.js": "1.15.0",
"sweetalert2": "8.5.0",
"web-animations-js": "2.3.2",
"zone.js": "0.9.1"
},
scss file
@import "variables";
@import "spinner/spinner";
@import "mixins/background";
@import "mixins/toggle";
@import "fab";
@import "layout";
@import "side-nav";
@import "global-nav";
@import "bs-overrides";
@import "multi-select";
@import "lpl-card";
@import "form-wizard";
@import '~bootstrap/dist/css/bootstrap.css';
Component
<formio class="form-io-wizard" [form]="form" [submission]="submission" (ready)="formReady($event)"
(change)="handleFormChanged($event)" (nextPage)="onNextPage($event)" (prevPage)="onPrevPage($event)"
(submit)="onSubmit($event)" (submissionLoad)="submissionLoaded($event)">

This means that the Form.io CSS is not getting included in the renderer.  This may happen if you are using ViewEncapsulation in your application that is keeping the Form.io styles from getting loaded. You can force them to get loaded by adding the following to your scss file.
@import "~formiojs/dist/formio.form.min.css";

Ultimately what I would rather, though, is to figure out why the FormioComponent inline styles are not getting applied.

Thanks for replying I will try that. Curious though why this would only be an issue in IE 11 and 10. Chrome, Firefox, and Safari look okay.

That seems to have worked. Thanks again for the quick response.


fix: JWT::loggedIn() does not remove Bearer prefix

Description
Supersedes #1039 , Close #1039
Fixes #1038
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Great! done

@MrFrost-Nv27 thank you!


Change viewport styling to more closely match v4

Issue: #5965
What I did
Styling for addon-viewport iframe was a 10px black border which was a
little intrusive when working on stories. This commit changes the iframe
style to a more familiar style that mimics v4 with horizontal centering
and a subtle box-shadow.
How to test
The changes are reflected in the Viewport stories being tested in Chromatic.

Looks great!!!


Allow one encryption counter reset per 100 messages to allow changing…

… batteries and brownouts in devices
Attempt to fix #116. Thanks ChatGPT for help. Did not try running this, please review if this makes sense.

There are some linting issues (see the first CI / lint test). I think we also need some tests to see if this works as expected.

I managed to run this on my instance and it does not yet fix the issue. Will continue torturing this.

I believe version in #119 came out a lot nicer than this approach.


include

@pravinparker  Thank you for this PR. But, please be advised that we are not actively supporting this SDK. You should use https://github.com/pubnub/c-core


Incompatible with ECB

I got error message below when trying to switch perspective with ECB enabled.
ecb-error: ECB 2.40 - Error: switch-to-buffer: Can only switch to visible special ecb-buffers!

This is 5 years old with no other comments... is this still relevant? OP? Can you close if not?


rename lib directory to src

This change is in preparation for the separation of the framework and the userspace

There is a branch with the beginnings of this


update deps

Coverage remained the same at 90.501% when pulling b6a37aae6f18b14ac2c4d653aab7da0a3c072e8d on update-deps into aa8d4b4fe9fb6e0cf294d149305478d270e1fe16 on main.


Chore forbiden create mv with some constant expr and curdate()

Proposed changes
forbiden create mv with some constant expr and curdate()
create materialized view const_1 as select k1,curdate() from d_table;
create materialized view const_2 as select k1,curdate()+k1 from d_table;
create materialized view const_3 as select k1,abs(1+1) from d_table;

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.59 seconds
stream load tsv:          439 seconds loaded<PHONE_NUMBER>9 Bytes, about 162 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          72 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230327111153_clickbench_pr_121300.html

run buildall

run buildall

run p0


Package helm charts and deploy it

Package helm chart and deploy it somewhere. I am thinking to have it in a branch on this repository.

fixed by 994dd33519eb8f374b20baf183c4f38da282178c


Some problems in go engine

You have really nice implementation of go rules, however while doing MCTS it provides nodes with illegal moves. I have tracked down several bugs, and mitigated the problem which still persists. Do you know what may be the cause ?
To replicate the issue you can try to check illegal move
moves = ["some game, unfortunately I haven't recorded any"]

game = go.GameState(9)
illegal_move = ["illegal move in given state after moves"]

for move in moves:
   game.do_move(move)
   game = game.copy()
game.is_legal(illegal_move) # This will be True now, which is wrong

Now I have tracked several problems which mitigated the problem, but not fixed it completely:
function _update_neighbors does not update liberty_sets for opponents groups:
if self.board[nx][ny] == -self.current_player:
   new_liberty_count = len(self.liberty_sets[nx][ny])
      for (gx, gy) in self.group_sets[nx][ny]:
         self.liberty_sets[gx][gy] -= set([position]) # MISSING
         self.liberty_counts[gx][gy] = new_liberty_count

copy operation has some problems, following copy operation had some fault I couldn't track.
        for x in range(self.size):
            for y in range(self.size):
                other.group_sets[x][y] = set(self.group_sets[x][y])
                other.liberty_sets[x][y] = set(self.liberty_sets[x][y])

I have changed it to:
other.group_sets = deepcopy(self.group_sets)
other.liberty_sets = deepcopy(self.liberty_sets)

It all helped the issue, but it still happens every let's say 10000 mcts rollouts, do you by any chance have any clues what may cause it ?

I just notices these problems were addressed in this fork https://github.com/vftens/RocAlphaGo

Can you try using the `cython-optimization' branch and see if the bug persists? The latest development in this repository has been there.

Hey thanks for response, sure I'll try it

Hey, the problem still persists. It happens once every ~600 generated 9x9 games. I have alpha go zero inspired solution on repo (https://github.com/CezCz/CezGo). It still has a lot of polishing left to be done, but simply run main.py and it will start training pipeline.
P.S I have added caching as network was a huge bottleneck for me, will try without it but it's going to take a while.

Can you share the exact code that is causing the issue? Unless I can reproduce the error I'm not sure where to look.
If you're using our MCTS code, I have fewer guarantees – we never got MCTS fully working and tested.
By the way, you're free to use any of our code as part of your project, but you need to keep a copy of our license with it.

Glad to hear it. Before the cython changes, I had my own feature caching branch, since computing the features can be more of a bottleneck than running the network. You might try that – code is here


Discord Bot Feature: Command to Add Social Links

Set Social Links
/social github = "https://github.com/yalematta"
/social twitter = "https://twitter.com/yalematta"

I think the /bio command is meant for that purpose
ref: #29

This can be added in the bio command in this way-
person> /bio add github https://github.com/yalematta
bot> added bio

As mentioned by @Vyvy-vi, this is part of the /bio command.

Thank you for creating the issue and triaging 👍 great team work 💪

Would separate commands make it easier or harder?
/bio set description <string>
/bio set github  <string>
...

or
/bio description  <optional-string>
/github <optional-string>
...

What do you think?


Settings in RegisteredClient are not json serializable with Jackson

ClientSettings and TokenSettings are not serializable with the BeanSerializer because they do not have getter methods prefixed with "get". This prevents me from serializing a RegisteredClient to json in a custom RestController.

I can submit a PR for a jackson module that can serialize all the Settings classes if you want me to.

@bschoenmaeckers I just merged gh-331 which includes a start for the Jackson module. I think you could go ahead and get a head start on ClientSettings and TokenSettings, as well as RegisteredClient, and add them to that module. However, I don't think we will be able to include this in the next release. We can potentially look at including it in 0.2.0.

Just another note on this: while I think you could get started creating the mixin (since you need it for yourself), it may not be needed in the framework right now. We may need to wait and see if it shows up as a need before we would want to look at it.

@bschoenmaeckers, while this suggestion would be nice to have, this is not an immediate need in the framework itself (that I'm aware of). I'm going to close this for now. I will keep an eye on whether this pops up as a need, and reopen if that is the case.


Demo not working

In trying to run
root@a2cdbc97c488:/exercise-pose-analyzer# python exercise_analyzer.py -f 'shoulder_press_1.mp4' -e 'sp'
the following errors are thrown:
root@a2cdbc97c488:/exercise-pose-analyzer# python exercise_analyzer.py -f 'shoulder_press_1.mp4' -e 'sp'

WARNING:tensorflow:From /exercise-pose-analyzer/nnet/pose_net.py:54: calling resnet_arg_scope (from tensorflow.contrib.slim.python.slim.nets.resnet_utils) with is_training is deprecated and will be removed after 2017-08-01.
Instructions for updating:
Pass is_training directly to the network instead of the arg_scope.
WARNING:tensorflow:From /exercise-pose-analyzer/nnet/pose_net.py:54: calling resnet_arg_scope (from tensorflow.contrib.slim.python.slim.nets.resnet_utils) with is_training is deprecated and will be removed after 2017-08-01.
Instructions for updating:
Pass is_training directly to the network instead of the arg_scope.
2019-02-14 14:40:29.512724: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2019-02-14 14:40:29.512774: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2019-02-14 14:40:29.512810: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2019-02-14 14:40:29.512823: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/ffmpeg_reader.py", line 283, in ffmpeg_parse_infos
    line = [l for l in lines if keyword in l][0]
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "exercise_analyzer.py", line 72, in <module>
    video = VideoFileClip(video_name_input)
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/VideoFileClip.py", line 81, in __init__
    fps_source=fps_source)
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/ffmpeg_reader.py", line 32, in __init__
    fps_source)
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/ffmpeg_reader.py", line 289, in ffmpeg_parse_infos
    filename, infos))
OSError: MoviePy error: failed to read the duration of file testset/shoulder_press_1.mp4.
Here are the file infos returned by ffmpeg:

ffmpeg version 2.4.2-   http://johnvansickle.com/ffmpeg/    Copyright (c) 2000-2014 the FFmpeg developers
  built on Oct  9 2014 07:24:56 with gcc 4.8 (Debian 4.8.3-11)
  configuration: --enable-gpl --enable-version3 --disable-shared --disable-debug --enable-runtime-cpudetect --enable-libmp3lame --enable-libx264 --enable-libx265 --enable-libwebp --enable-libspeex --enable-libvorbis --enable-libvpx --enable-libfreetype --enable-fontconfig --enable-libxvid --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwbenc --enable-gray --enable-libopenjpeg --enable-libopus --disable-ffserver --enable-libass --enable-gnutls --cc=gcc-4.8
  libavutil      54.  7.100 / 54.  7.100
  libavcodec     56.  1.100 / 56.  1.100
  libavformat    56.  4.101 / 56.  4.101
  libavdevice    56.  0.100 / 56.  0.100
  libavfilter     5.  1.100 /  5.  1.100
  libswscale      3.  0.100 /  3.  0.100
  libswresample   1.  1.100 /  1.  1.100
  libpostproc    53.  0.100 / 53.  0.100
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x3885700] Format mov,mp4,m4a,3gp,3g2,mj2 detected only with low score of 1, misdetection possible!
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x3885700] moov atom not found
testset/shoulder_press_1.mp4: Invalid data found when processing input

root@a2cdbc97c488:/exercise-pose-analyzer#
root@a2cdbc97c488:/exercise-pose-analyzer#
root@a2cdbc97c488:/exercise-pose-analyzer#
root@a2cdbc97c488:/exercise-pose-analyzer#
root@a2cdbc97c488:/exercise-pose-analyzer#
root@a2cdbc97c488:/exercise-pose-analyzer#
root@a2cdbc97c488:/exercise-pose-analyzer# ls testset/
download_testset_wget.sh  shoulder_press_1.mp4	shoulder_press_2.mp4  shoulder_press_3.mp4
root@a2cdbc97c488:/exercise-pose-analyzer# mkv
bash: mkv: command not found
root@a2cdbc97c488:/exercise-pose-analyzer# ffmpeg
bash: ffmpeg: command not found
root@a2cdbc97c488:/exercise-pose-analyzer# python exercise_analyzer.py -f 'shoulder_press_2.mp4' -e 'sp'
WARNING:tensorflow:From /exercise-pose-analyzer/nnet/pose_net.py:54: calling resnet_arg_scope (from tensorflow.contrib.slim.python.slim.nets.resnet_utils) with is_training is deprecated and will be removed after 2017-08-01.
Instructions for updating:
Pass is_training directly to the network instead of the arg_scope.
WARNING:tensorflow:From /exercise-pose-analyzer/nnet/pose_net.py:54: calling resnet_arg_scope (from tensorflow.contrib.slim.python.slim.nets.resnet_utils) with is_training is deprecated and will be removed after 2017-08-01.
Instructions for updating:
Pass is_training directly to the network instead of the arg_scope.
2019-02-14 14:46:46.780805: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2019-02-14 14:46:46.780853: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2019-02-14 14:46:46.780904: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2019-02-14 14:46:46.780930: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/ffmpeg_reader.py", line 283, in ffmpeg_parse_infos
    line = [l for l in lines if keyword in l][0]
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "exercise_analyzer.py", line 72, in <module>
    video = VideoFileClip(video_name_input)
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/VideoFileClip.py", line 81, in __init__
    fps_source=fps_source)
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/ffmpeg_reader.py", line 32, in __init__
    fps_source)
  File "/usr/local/lib/python3.6/site-packages/moviepy/video/io/ffmpeg_reader.py", line 289, in ffmpeg_parse_infos
    filename, infos))
OSError: MoviePy error: failed to read the duration of file testset/shoulder_press_2.mp4.
Here are the file infos returned by ffmpeg:

ffmpeg version 2.4.2-   http://johnvansickle.com/ffmpeg/    Copyright (c) 2000-2014 the FFmpeg developers
  built on Oct  9 2014 07:24:56 with gcc 4.8 (Debian 4.8.3-11)
  configuration: --enable-gpl --enable-version3 --disable-shared --disable-debug --enable-runtime-cpudetect --enable-libmp3lame --enable-libx264 --enable-libx265 --enable-libwebp --enable-libspeex --enable-libvorbis --enable-libvpx --enable-libfreetype --enable-fontconfig --enable-libxvid --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwbenc --enable-gray --enable-libopenjpeg --enable-libopus --disable-ffserver --enable-libass --enable-gnutls --cc=gcc-4.8
  libavutil      54.  7.100 / 54.  7.100
  libavcodec     56.  1.100 / 56.  1.100
  libavformat    56.  4.101 / 56.  4.101
  libavdevice    56.  0.100 / 56.  0.100
  libavfilter     5.  1.100 /  5.  1.100
  libswscale      3.  0.100 /  3.  0.100
  libswresample   1.  1.100 /  1.  1.100
  libpostproc    53.  0.100 / 53.  0.100
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x3f39700] Format mov,mp4,m4a,3gp,3g2,mj2 detected only with low score of 1, misdetection possible!
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x3f39700] moov atom not found
testset/shoulder_press_2.mp4: Invalid data found when processing input

Is this an error with the .mp4 or the installation?

use the docker setup, its easier, I had many problems to install each dependencie.

@nathangeorge1 I'm facing the same issue, were you able to progress?
@leo2105 I'm getting nathan's mentioned issue while running the video_pose.py inside the docker. This is not an error during installing dependencies.

@siddharthgee I remember playing with dependencies such as moov and possibly adjusting the code, but my team deciding to not go with this; I wouldn't recommend it either, unless they can fix this issues

If anyone's wondering, the issue is with the video files. As the hosted video files have being removed from the location. So running the testset/download_testset_wget.sh script simply downloads 3 empty files with .mp4 extension. That's why you get the following error,
OSError: MoviePy error: failed to read the duration of file ...
Try using your own *.mp4 file, and it'll start processing :)


fix: Remove uses of deprecated types

Hi,
I noticed that #82 missed a couple uses of deprecated types which were causing issues if you're using the NetInfoData interface.

Thanks for this 👍 Merging and releasing now.


POL-497 Override the Maven version used by Quarkus

@aloubyansky Could you please confirm this is correct?

Quarkus was bumped to 1.13.6.Final which includes a Maven upgrade (see 1.13.5.Final blog post) so we don't need to override the Maven version anymore.


Error! The dev script in package.json must not contain now dev

The changes in #2507 seem to break common conventions for JS development

Why can users not specify whatever they want in their projects package,json
what is the expected alternative approach?
given the size of your user-base, would it not be beneficial to document changes like this, when they're made, explaining the motivation, and what one should do instead?

Having this as a simple policy for  the acceptance of Pull requests would certainly reduce the pain of changes like this.

Thank you for reporting this. This error is not intentional for your use case!
  Looking forward to the fix. Cheers.

@Pushplaybang This should be solved. Can you confirm?

Has been fixed in https://github.com/zeit/now-cli/pull/2559

Still getting the same error in v17.1.1

@AndyBitz
Same problem !🤷♂
Version v17.1.1

@Huskyhunter
...
"scripts": {
   "dev": "./dev.sh"
},
...

chmod +x ./dev.sh

npm run dev

I've found a temporary solution.


fix typo

Codecov Report

Merging #1520 (ae2d7db) into master (a9bf783) will decrease coverage by 0.13%.
The diff coverage is n/a.

:exclamation: Current head ae2d7db differs from pull request most recent head 75e9da5. Consider uploading reports for the commit 75e9da5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   39.27%   39.13%   -0.14%
==========================================
  Files         604      597       -7
  Lines       35510    35434      -76
==========================================
- Hits        13946    13868      -78
+ Misses      20026    20025       -1
- Partials     1538     1541       +3

Impacted Files
Coverage Δ

common/log/log.go
88.23% <ø> (ø)

common/net/port.go
100.00% <ø> (ø)

common/platform/others.go
72.72% <ø> (ø)

common/protocol/http/headers.go
83.78% <ø> (ø)

common/protocol/id.go
97.29% <ø> (ø)

app/proxyman/outbound/errors.generated.go
0.00% <0.00%> (-100.00%)
:arrow_down:

common/task/task.go
88.88% <0.00%> (-7.41%)
:arrow_down:

testing/servers/tcp/tcp.go
81.81% <0.00%> (-5.46%)
:arrow_down:

testing/scenarios/common.go
73.07% <0.00%> (-4.62%)
:arrow_down:

app/proxyman/outbound/handler.go
36.61% <0.00%> (-4.23%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bf783...75e9da5. Read the comment docs.

Why did you close #1516? Also I don't see the point of sending these patches to fix typos. Feels like a waste of maintainer's time.

Why did you close #1516? Also I don't see the point of sending these patches to fix typos. Feels like a waste of maintainer's time.

I closed that in the reason that i thought that you would not let that branch to be merged

I closed that in the reason that i thought that you would not let that branch to be merged

That's simply not how GitHub works.

I closed that in the reason that i thought that you would not let that branch to be merged

That's simply not how GitHub works.

Thank you for your answering.This PR just contains some chore fixed.

move to https://github.com/v2fly/v2ray-core/pull/1535


[match] Correct how match handles enterprise adhoc

Fixes #11139
Fixes #12133
Da motivation
I have experience this issue while (as well as others) where match doesn't treat adhoc profiles for enterprise accounts the way it is expected.
❌ Before

match would place certificates for enterprise adhoc accounts under distribution

This meant that match wouldn't reuse the same cert used for inhouse which was placed under enterprise

sigh would also look for enterprise adhoc files in Spaceship.certificate.production.all when actually in Spaceship.certificate.in_house.all

✅ After

match looks for both enterprise adhoc and inhouse certs under the enterprise directory

Which now means the one certificate can be shared for all enterprise distribution builds

sigh now properly returns certificates for enterprise adhoc profiles

⚠ Warning

This may introduce some backwards compatibility issues 🤔

match will now look for the adhoc cert in the enterprise directory instead of distribution
This shouldn't "break" anything but will make the other certificate just useless

After i update fastlane to version 2.92.0, when i use match sync the adhoc certificates got the error as follow:
undefined method `in_house?' for nil:NilClass.
As you said match will now look for the adhoc cert in the enterprise directory instead of distribution.
but in my git project there is no enterprise directory, how can match create enterprise in git project?

As a temp solution, I downgraded back down to 2.91.0
Gemfile
gem "fastlane", '2.91.0'

Reverted this PR and making new version for 2.92.1


Unify Prose and Textbox with an underlying TextRegion

Remaining steps

[x] Update Textbox to use this
[x] Add internal padding

Follow-up work:

[ ] Restore IME support
[ ] Upstream new result of PlainEditor (once other steps are complete)

When you renamed TextRegion to TextArea, a lot of things are still referring to the region terminology which makes it confusing.
Also, TextArea is kind of confusing since it makes think of the HTML tag <textarea> ... but don't have any real thoughts about if that's an issue or not.

When you renamed TextRegion to TextArea, a lot of things are still referring to the region terminology which makes it confusing.

As mentioned on the Zulip, I'm still doing a pass over docs.

Also, TextArea is kind of confusing since it makes think of the HTML tag <textarea> ... but don't have any real thoughts about if that's an issue or not.

I don't have a strong feeling about any particular name; this needing a name is largely an accident. Maybe we should prefer "TextCore" or something?

When you renamed TextRegion to TextArea, a lot of things are still referring to the region terminology which makes it confusing.

As mentioned on the Zulip, I'm still doing a pass over docs.

I meant in identifiers, not in docs:
                let mut text_region = Textbox::text_mut(&mut textbox);
                TextArea::reset_text(&mut text_region, "");

Yeah, I believe that is https://github.com/linebender/parley/issues/165. I've added a workaround into Prose directly. Note that this issue is still visible in http_cats; I've added a workaround into http_cats itself for that one.


Custom endpoints for Azure-AD oauth2 authentication

Fix #26494

Hi, @saragluna , @yiliuTo , please help to review this PR when you have time.

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here


Question: How to keep YAML stuff  separate from docstring in django project because it makes file bulky??

Currently, there is no way to do this, but this does need to change for a variety of reasons.

This would definitely be a nice feature to have.

YAML is out in v2, schema generation is done by DRF.  Will be looking into allowing overrides to the swagger spec in the future, but will aim to make these separate templates, outside of the code and docstring.


Not sure if binning should be considered in IPM, or be converted to image coordinates prior

Currently, binning is considered within IPM such that the input point can be a "binned" pixel coordinate (I'm not sure what the correct terminology here is).
I'm wondering if it is necessary to consider the binning inside IPM, or outside IPM by ensuring pixels are converted to those that match the original width x height of the image.

We are using this feature at Bit-Bots. The official image proc software binning node does it like that, and there is also support for that in the camera_info message. It only changes the binning params in the camera_info keeping it otherwise the same. I think the idea is that roi, binning, etc don't change the original camera calibration matrix and instead provide an additional transformation that needs to be applied. This makes it a bit harder for us, as we need to consider this, but it also makes the camera_info cleaner, as the same camera always has the same camera matrix. I think we should use the default way of handling this instead of e.g. creating an additional node that creates "unbinned" camera_infos.
Or did you mean "outside" of the projection, but still inside the ipm libary? Because I think we need to handle the binning param in the camera_info ether way. You could also scale the pixels instead of the camera_matrix, but this is the exact same thing only the other way around, and I see no benefits in changing the implementation. The binning param is available ether way at this stage due to the CameraInfo message being passed to the projection function. The presence of the complete CameraInfo msg type will also be helpful in the future if we consider the distortion matrix in the projection.

I see, thinking twice I think we should handle binning_x and binning_y inside IPM, and project_point() should be called with "binned" pixels like you currently are doing.
For consistency, would it make sense to handle ROIs from CameraInfo aswell?

It makes sense to handle ROIs but their implementation is currently not my to priory. We should open an issue for this.


Layout enhancements in section II, 5.3.1 and so on

It would be better to use systematically another font for XML elements and folder names.
Section: II, 5,3,1
Text: the METS root element mets MUST define

Check fonts for consistency across use of:

folder names;
XML elements;
MOSCOW terms;


Issues logging into Pixiv

Cannot log into Pixiv through the program.
The program is refusing to let me log into Pixiv, When going to connect, it says failure.
Steps to reproduce

Go to 'Pixiv site options'
Click on 'Login'
Enter login details
See error

Expected behavior
To let me log into Pixiv.
Copy from the log when attempting to log in
[02:35:04.212][Warning] [www.pixiv.net] No OAuth2 token type received: {"has_error":true,"errors":{"system":{"message":"103:pixiv ID\u3001\u307e\u305f\u306f\u30e1\u30fc\u30eb\u30a2\u30c9\u30ec\u30b9\u3001\u30d1\u30b9\u30ef\u30fc\u30c9\u304c\u6b63\u3057\u3044\u304b\u30c1\u30a7\u30c3\u30af\u3057\u3066\u304f\u3060\u3055\u3044\u3002","code":1508}}}
[02:35:04.212][Info] [www.pixiv.net] Login finished: failure.

I also have this problem. Copied from my log:
[13:41:18.184][Info] [www.pixiv.net] Logging in...
[13:41:19.663][Warning] [www.pixiv.net] No OAuth2 token type received: {"has_error":true,"errors":{"system":{"message":"access_denied","code":1508}}}
[13:41:19.663][Info] [www.pixiv.net] Login finished: failure.

[02:35:04.212][Warning] [www.pixiv.net] No OAuth2 token type received: {"has_error":true,"errors":{"system":{"message":"103:pixiv ID\u3001\u307e\u305f\u306f\u30e1\u30fc\u30eb\u30a2\u30c9\u30ec\u30b9\u3001\u30d1\u30b9\u30ef\u30fc\u30c9\u304c\u6b63\u3057\u3044\u304b\u30c1\u30a7\u30c3\u30af\u3057\u3066\u304f\u3060\u3055\u3044\u3002","code":1508}}}

The error reads as:
103:pixiv ID、またはメールアドレス、パスワードが正しいかチェックしてください。

In English:
103: Check if the pixiv ID, e-mail address and password are correct.

Are you sure you provided the correct credentials? i.e. email instead of username.
Did it work before?

[13:41:19.663][Warning] [www.pixiv.net] No OAuth2 token type received: {"has_error":true,"errors":{"system":{"message":"access_denied","code":1508}}}

Never saw this error. 🤔
Same question, did it work before, or is it the first time you try to login on Pixiv with Grabber?

I havent tried it before. It was the first time i had attempted to. And it works fine logging in onto the site itself through a web browser, so i cant see it being details.
Ill get back to you later after reading tbrough that thread, currently busy rn, will read through it in a few hours hope thats ok

[13:41:19.663][Warning] [www.pixiv.net] No OAuth2 token type received: {"has_error":true,"errors":{"system":{"message":"access_denied","code":1508}}}

Never saw this error. thinking
Same question, did it work before, or is it the first time you try to login on Pixiv with Grabber?
Could it be related to upbit/pixivpy#83?
It used to work, but that was a while ago on an earlier version. I made sure to use email rather than username, and that my details were correct.

Just to make sure, consumer key should be MOBrBDS8blbauoSck0ZfDbtuzpyT and consumer secret should be lsACyCD94FhDUtGTXi3QzcFE2uU1hqtDaKeqrdwj, correct?

Indeed.
I could reproduce just now, so I'll start seeing how to fix that 👌

I feel I should mention that I only got pixiv to work once I added the phpsession cookie. Unfortunately, it looks like it expires every month. Is this the wrong approach? I have also checked that the consumer key/secret is correct in my settings.

I want to mention that I only got pixiv to work once I added the phpsession cookie, which expires monthly. Is this the wrong approach? I have also checked that the consumer key/secret is correct in my settings.

Just for the record, login is failing on my end as well.


How to passing parameters to command alert ?

I want  to use command alert , but how can I passing parameters to command alert ?
I try to set arg1 , arg2, @timestamp when alert will pass these arguments to action.sh as below,
alert:
  - command
command:
  - "/opt/elastalert/action.sh arg1 arg2 @timestamp"

But it’s got error ,
If i'm wrong is it possible to explain how i can do this ?
Thanks by advance,

http://elastalert.readthedocs.io/en/latest/ruletypes.html#command

hi Qmando,
I try to using command alert as below,
alert:
-command
command: ["/opt/alert/action.sh", "%(timestamp)s","%(user)s","%(ip)s","%(id)s","%(count)s"]

but got the error,
ERROR:root:Error while running alert command: Error while running command /opt/alert/action.sh 2016-09-07 11:14:16.819 guest <IP_ADDRESS> 1/0/3 5: [Errno 13] Permission denied
If i'm wrong is it possible to explain how i can do this ?
Thanks by advance,


Fix needed: icons have disappeared  on iD 2.19.5

images below

and lots of other features have the same issues

@lukethemapper I can't reproduce this issue. Are you working on osm.org? Do they appear if you reload the page?

They didn't (also i work on osm.org)

@lukethemapper What browser are you using? Do you see any console errors?


iOS app getting crashed on specific Flavor

I am facing a strange issue of app crashes on iOS for staging and preprod. Only prod is getting run for simulators and devices. the error received is
Terminating app due to uncaught exception 'com.firebase.core', reason: 'App name can only contain alphanumeric, hyphen (-), and underscore (_) characters'

The firebase files are updated with the names.  but somehow its getting crashed stating the same error.
The flavor code
flavorizr:
  app:
    android:
      flavorDimensions: "app_flavor"

  flavors:
    staging:
      app:
        name: " Staging"
      android:
        applicationId: "com.app.staging"
        firebase:
          config: "android/app/src/staging/google-services.json"
      ios:
        bundleId: "com.app.staging"
        firebase:
          config: "ios/config/staging/GoogleService-Info.plist"

    preprod:
      app:
        name: "PreProd"
      android:
        applicationId: "com.app.preprod"
        firebase:
          config: "android/app/src/preprod/google-services.json"
      ios:
        bundleId: "com.app.preprod"
        firebase:
          config: "ios/config/preprod/GoogleService-Info.plist"

    prod:
      app:
        name: "Prod"
      android:
        applicationId: "com.app.live"
        firebase:
          config: "android/app/src/prod/google-services.json"
      ios:
        bundleId: "com.app.live"
        firebase:
          config: "ios/config/prod/GoogleService-Info.plist"

@AngeloAvv can you please help?

I have same issue , did you got any hint


Add Atlassian Confluence

What this PR does / why we need it:
This PR adds a new chart for Atlassian Confluence.
Atlassian Confluence is an enterprise wiki collaboration platform.
Special notes for your reviewer:
This chart uses the official image atlassian/confluence-server.
I am running a Confluence server with this chart in my environment. See also https://github.com/int128/devops-kompose.

Thank you for the review!

Support application upgrades
Just bump a chart and Confluence automatically upgrades database on boot up.
I added description to README.md.

Allow customization of the application configuration
Confluence does not provide config files or env-vars.
We need to configure database and etc on the setup wizard on a web browser.

Provide a secure default configuration
Currently this chart does not use any credentials such as database password.
Is more configuration needed?

Any update on this? Please let me know any suggestions.

I am looking forward to merging this!

@int128 how about reopen this ?
I think you can manage charts for confluence and jira in this official helm repo not your personal repo.
And It would be help for other users.


Validator slashing not updating delegations

Bug description
Currently when a validator is slashed due to jail or other things, the associated delegations are not updated. We should make so  that they are, and also provide a command to fix all the currently wrong delegations too.
Steps to reproduce

Create a validator
Delegate some tokens to that validator
Make the validator slash due to downtime
Observe the delegations

Expected behavior

The delegations should update correctly
Possible solution
Each block, observe to know which validators are now jailed/tombstoned. Then, update their delegations.
Maybe there is even a way to read begin block events and know who has been slashed.

A solution is to wait until RiccardoM/juno#27 is implemented and then iterate though the BeginBlockEvents to get all the slashing events that were emitted during that block, updating the delegations at that height for each slashed validator.


Refactor noTx loop breaking logic for embedded databases

Hi All,
This PR contains a couple of commit that refactor the logic of loop braking for the case of embedded, this new implementation will get all the record from the dirty manager, create a tx out of them and commit the tx, in this way we can use the tx way for generate rids and completely remove the need of creation of an empty record for breaking loops.
This implementation is an hard requirement for future evolutions in the distributed layer that require just one way to handle the data (the transaction).
Same logic could be implemented also for remote noTx, but currently is not done, will be done in future, with as well a major clean up of dirty management logic.

Already merged


Overlapping objects in split screen

If we use split screen (feature available in Microsoft edge browser) the object gets duplicated onto the screen (check first screenshot) and when we exit the mode, it becomes one, but strangely (as in second screenshot), and this window gets isolated from other windows and other windows can no longer participate with this window (third screenshot).

ps: I'm a beginner here and also trying to understand what and why's that happening,

I think it must be the incognito mode

Try using another browser (it worked in firefox for me)
AND disable any adblocker or anti tracking plugin, they will often block this

Try using another browser (it worked in firefox for me) AND disable any adblocker or anti tracking plugin, they will often block this

it works in other browser without this feature(split screen), I'm targeting this feature only

I think it must be the incognito mode

no, it was just for reference, issue persists in any mode

If we use split screen (feature available in Microsoft edge browser) the object gets duplicated onto the screen (check first screenshot) and when we exit the mode, it becomes one, but strangely (as in second screenshot), and this window gets isolated from other windows and other windows can no longer participate with this window (third screenshot).

If we use split screen (feature available in Microsoft edge browser) the object gets duplicated onto the screen (check first screenshot) and when we exit the mode, it becomes one, but strangely (as in second screenshot), and this window gets isolated from other windows and other windows can no longer participate with this window (third screenshot).

I agree with this, can't we try to fix that?, or we've to create new instance of window each time for this to work?
Ps, currently only two windows can interact at a time, so if we add a third one, it won't interact with the first two, adding fourth one can work with third, and this pair goes on....