Set transform ignored after rotation_degrees has been set

Godot version:
3.2.3-stable
OS/device including version:
Windows 10
Issue description:
I found a case where you can set the transform on a Spatial node to a given Transform() object, then when you print its value it is not what you set it to.
This problem appeared as a heisenbug because when I printed the transform just before it was set the problem went away.
Please see the code for the minimal reproduction.  It seems that if you set rotation_degrees it doesn't actually change the transform until the next read operation, and thus over-writes any direct setting transform.
Steps to reproduce:
See below
Minimal reproduction project:
tool
extends EditorScript

# *******
# Control-Shift X to run this code in the editor
# *******

func _run():
	var t = str2var("Transform( 0.944959, -0.327188, 0, 0, 0, 0, -0.327188, -0.944959, 0, -21.0524, -0.666294, -24.4351 )")

	var a = Spatial.new()

	# Step 1: Uncomment this line and the the transforms don't match
	#a.rotation_degrees = Vector3(-90, 0, 0)

	# Step 2: Then uncomment this line and the the transforms will match again
	#print(a.transform)

	print("Transforms below should match!")
	print("Transform to apply: ", t)
	a.transform = t
	print("Transform of node:  ", a.transform)

Confirmed that it's still reproducible in latest 3.x (3.6-beta).
The fix proposed in #44803 might still be suitable for 3.x.
The bug seems fixed in master, at least following the steps in the script gives matching transforms in all steps:
Transforms below should match!
Transform to apply: [X: (0.944959, 0, -0.327188), Y: (-0.327188, 0, -0.944959), Z: (0, 0, 0), O: (-21.0524, -0.666294, -24.4351)]
Transform of node:  [X: (0.944959, 0, -0.327188), Y: (-0.327188, 0, -0.944959), Z: (0, 0, 0), O: (-21.0524, -0.666294, -24.4351)]
Transforms below should match!
Transform to apply: [X: (0.944959, 0, -0.327188), Y: (-0.327188, 0, -0.944959), Z: (0, 0, 0), O: (-21.0524, -0.666294, -24.4351)]
Transform of node:  [X: (0.944959, 0, -0.327188), Y: (-0.327188, 0, -0.944959), Z: (0, 0, 0), O: (-21.0524, -0.666294, -24.4351)]
[X: (1, 0, 0), Y: (0, -0, -1), Z: (0, 1, -0), O: (0, 0, 0)]
Transforms below should match!
Transform to apply: [X: (0.944959, 0, -0.327188), Y: (-0.327188, 0, -0.944959), Z: (0, 0, 0), O: (-21.0524, -0.666294, -24.4351)]
Transform of node:  [X: (0.944959, 0, -0.327188), Y: (-0.327188, 0, -0.944959), Z: (0, 0, 0), O: (-21.0524, -0.666294, -24.4351)]

Fixed by #78439.


Implement Origin UI in Traffic Portal

Provide the ability to list, create, edit, and delete Origins using Traffic Portal.

This depends on #2314 because that PR changes the isPrimary field to read-only, and this PR does not send isPrimary in requests. Currently that field is required and updatable, but it shouldn't be. Hence the dependency on that PR.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1796/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1813/
Test PASSed.


Closes #1555: [Feature] - fix StackTraceSampler / AutoTracing

Closes #1555

This change is

inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/opentelemetry/trace/samplers/HybridParentTraceIdRatioBasedSampler.java line 52 at r1 (raw file):
Previously, heiko-holz (Heiko Holz) wrote…
Technically we could. However, I have followed OpenCensus' implementation of https://github.com/census-instrumentation/opencensus-java/blob/master/api/src/main/java/io/opencensus/trace/samplers/ProbabilitySampler.java.
But we can change it to this if you think this is more readable:
 // If the parent or any parent link has been sampled keep, the sampling decision.
        if ((parentSpanContext.isValid() && parentSpanContext.isSampled()) || isAnyParentLinkSampled(parentLinks)) {
            return SamplingResult.recordAndSample();
        }

We have agreed to change it to the shorter version


Hope the project support arm  CPU

Hope the project support arm  CPU，example  raspberry-pi et。
In  arm64，  I can Build Casdoor Go backend code，but I can not build Casdoor frontend code 。

@WarlockFish

but I can not build Casdoor frontend code

What's the error?

My M1 MAC is arm64 core. And I can build Casdoor frontend code successfully on this MAC. So I think that's not the arm64 caused you build failed. @WarlockFish

I know why I can't compile it, I use node==18.7 。 when use node==16 , Casdoor frontend code can build successfully。

Closed as resolved


Replace argparse with Click as the cli interface

Right now, argparse is used as the cli interface but Click have many advantages:

Ability to use nested commands which would allow the script to get closer to the official .js implementation. For exemple ./resume-cli.py export instead of ./resume-cli.py --export or ./resume-cli.py serve instead of ./resume-cli.py --serve
Introduce unit tests, which is a welcome code quality improvement.
Support choices parameters, prompts or callbacks. Callbacks could be very useful to run pre-check on, for exemple, the theme directory and help to easily solve issues such as the None problem.
Ability to have global parameters and command specific parameters. Essentially ./resume-cli.py [global-options] command [command-options]

The first three items are the most significant, but Click offer other advantages that I'm not thinking of now.

I'm not sure what I think about this, it's extra dependency that is not really important for the app on the one hand, on the other hand it does have some minor advantages.
I'm not sure the nested commands are that important, at least for now.
Tests are important, but I think tests can be done without click almost as easily, but will need to verify this :)
Prompts might be useful for when the user didn't enter any option (such as init or export), but that depends on how we want to handle what happens when no option was given (We might have a default usage, help message or something else).
Callbacks are possible with argparse too, just by using the action parameter you can add a default behavior that argparse implemented or create a function by yourself.
The global and command specific arguments are nice, but it also complicates the API, so again, I'm not sure if it's better for this app.
I don't say click is not good or not useful, I'm just not sure it's better for this use case, and I will change it to click (or any other similar tool if better suited) if I see it as a better alternative for argparse for the use case

I'm not sure the nested commands are that important, at least for now.

Check this quick exemple.
@click.group()
def cli():
    pass

@click.command()
def export():
    # export logic

@click.command()
def serve():
    # serve logic

cli.add_command(export)
cli.add_command(serve)

Then we'd only have to call cli() as the entrypoint.
I'm not going to argue all your points, however I do think it's the most important of the issue I've created.

It seems you know click better then me, so do you know if click supports getting the arguments of another package if needed?
I mean, let's assume for the moment resume-json-python is a huge success and someone want to add it as a sub command on their app, will it be able for them to add and pass arguments to our app easily (basically nesting groups)?
If yes, that would be a good thing to do your suggestion, otherwise I still need to think about it

Well I don't really know about reusing directly the cli with another package but there is this section about invoking other commands so maybe ? But if anyone was to reuse it in another program, I think they would want to use the classes and methods not the cli, like in template_generator.py with Jinja2 imports.

I thought about it and click would give us a bit more options when in need to check things so it will be done, both because of what you said and the fact that the added requirement is not that bad when we have other bigger requirements

OK, great.

I still need to make sure that the design will be good if using click, right now it seems like we will need to bundle all the sub commands on the same file to start from, which I don't like, but still need to see how bad it is

Well, it is much like currently, but instead of the ifs for args.init, args.validate and such, you have a method per action. The cli.add_command() I referenced earlier is not even required. How bad can that be ?

I will update the pip version after doing all the work with the other issues since most of the work here is behind the scenes


eq-635 timeout

What is the context of this PR?
Trello card

Added Dialog component (using a11ydialog under the hood)
Added Fetch component (for AJAX requests)
Created Timeout component that displays a dialog once the threshold of the session timeout has been reached (default 120 seconds) allowing user to continue with survey or sign out.

How to review

set env var EQ_SESSION_TIMEOUT_SECONDS to 160
start app
begin a survey
wait 10 seconds for dialog
test 'continue survey' button resets timeout

start again
confirm 'save and sign out' button works

start again
confirm session times out

@hamishtaplin its also missing on introduction page

Observations:

Getting a timeout pop up on a session time out screen.
Hitting [esc] have the same effect as [Continue Survey] not sure if we want to fix it or leave it as a feature.
Pop up always displays ‘UK Innovation survey’ irrespective of the survey that we are currently filling.

Rest looks good. The button colour on the pop differs between census and other survey which is really good.

@hamishtaplin should i put the same fix to the session timeout screen as i have to the thank you page?

We use "Save and sign out" on the time out screen but  "Save and complete later" on the survey screen, they are doing the same thing, should it not be consistent?

@LJBabbage We're changing the label of the 'save and complete later' button anyway so probably doesn't matter.

Retested on branch and works as expected (issues now resolved)

@LJBabbage All on you :)


Reference Template Paths documentation missing information about absolute paths

The information about Reference template paths states:

Template paths should be relative to the file that does the including.

However, absolute paths are valid.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6724abea-bbdc-bf66-ed5e-3214fa6c3e66
Version Independent ID: 4f8dab21-3f0e-da32-cc0e-1d85c13c0065
Content: Templates - Azure Pipelines
Content Source: docs/pipelines/process/templates.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

We've merged the related PR. Closing this issue.


Provide AsciiDoc Renderer

Which scope/s are relevant/related to the feature request?
content
Information
It would be nice to support also AsciiDoc (*.adoc) as Markdown alternative.
similar to withMarkdownRenderer() it could be named withAsciiDocRenderer().
Describe any alternatives/workarounds you're currently using
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[ ] No

Haven't seen this one as much. Does this need to be built-in?

Probably you are right and it could also be an extension living somewhere else.


Feature request: force deploy of newly minted smart wallet code to blockchain

I am looking to integrate the soinbase smart wallet into my app. We primarily use the USDC token and one feature used is the permit() function with an offchain gassless signature that authorizes an allowance of usdc for another address; the smart wallet owner van sign the permit message and authorize another address to spend their usdc.
However, it seems the USDC code only accepts the signature from smart wallets that have deployed their code to the blockchain, not newly minted predeployed wallets. I have raised the issue here: https://github.com/circlefin/stablecoin-evm/issues/470
So in order for a smart wallet to sign a permit signature for usdc they must initiate a transaction that will trigger the deployment of the wallet code to the blockchain.
Perhaps there already exists a way to force a smart wallet to deploy to its code, but if not I think this would be a helpful feature for edge cases like this one.
I can elaborate further if needed.

Hey @Ncastro878, this makes sense. Are you using the Coinbase Wallet SDK?

@wilsoncusack I am not. I am using web3modal to sign users in, and that allows users to pick between coinbase mobile app or coinbase smart wallet for connecting.


Additional Selection Sort is Random

When adding additional selected rows and calling selection sort on a table results in a randomized selection of rows.

#2 solves


[RFC] Introduce .fit(ckpt_path="last")

🚀 Feature
Add support for passing just "last" to trainer.{fit,validate,test,predict}(ckpt_path=...)
This would pick the latest model checkpoint saved from the set of:

"top-k" checkpoints
"last" checkpoints
"fault-tolerant" checkpoints.

The tracking logic would most likely be inside the checkpoint connector.
Also, just for trainer.fit, ckpt_path should default to "last" when fault-tolerance is enabled.
Motivation
Until now, we've recommended passing trainer.model_checkpoint.last_model_path, but with fault-tolerance enabled, the last model path might be one generated by fault-tolerance.
Fault-tolerance logic is meant to be hidden from the users so we don't want them to track this.
Alternatives
The best alternative (after #11862) would be:
ft_checkpoints = [cb for cb in self.callbacks if isinstance(cb, _FaultToleranceCheckpoint)]
if ft_checkpoints:
    last_ckpt_path = ft_checkpoints[0].ckpt_path
else:
    last_ckpt_path = trainer.model_checkpoint.last_model_path
trainer.fit(model, ckpt_path=last_ckpt_path)

but it does not consider that the model_checkpoint.last_model_path could have been saved after.
We should track this for the user.
Additional context
Proposed by @tchaton

If you enjoy Lightning, check out our other projects! ⚡

Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @borda @tchaton @justusschock @awaelchli @ananthsub @ninginthecloud @rohitgr7 @carmocca

Some n00b questions:

Should Lightning use "last.ckpt" as the default path for both the model checkpoint and the fault tolerant checkpoint path? This way we don't have to even distinguish these.
Why is "last.ckpt" customizable by the end user? Doesn't that that make distinguishing the most recently saved checkpoint harder for the framework?
Does save_last still make sense on the ModelCheckpoint callback if the fault tolerant feature is enabled & rolled out? Is there redundancy if both are enabled?
What happens if multiple model checkpoint callbacks are configured with save_last ? From which callback do we pick last_model_path from ?

Hey @ananthsub .

Should Lightning use "last.ckpt" as the default path for both the model checkpoint and the fault tolerant checkpoint path? This way we don't have to even distinguish these.

Yes, this was my first idea. However, fault tolerant can be harder to get right when an epoch end checkpoint is quite stable. It is why we originally decided to keep them apart.

Why is "last.ckpt" customizable by the end user? Doesn't that that make distinguishing the most recently saved checkpoint harder for the framework?

Not 100 % sure to understand your question. However, the last checkpoint ideally should be the one with the most recent timestamp.

Does save_last still make sense on the ModelCheckpoint callback if the fault tolerant feature is enabled & rolled out? Is there redundancy if both are enabled?

Yes, it still makes sense. The concept of last doesn't change. When fault tolerant is triggered, its checkpoint is actually latest in date to be created. But when restarting, as soon the new ModelCheckpoint creates a new checkpoint, latest become this one.

What happens if multiple model checkpoint callbacks are configured with save_last ? From which callback do we pick last_model_path from ?

I think checkpoint should be timestamped and the latest should be used.

I'll answer too, adding to Thomas' comments:

Should Lightning use "last.ckpt" as the default path

No because the fault-tolerance checkpoint is saved on exception so we cannot really guarantee that it will be usable on reload, on the other hand, "last" checkpoints are saved normally.

Why is "last.ckpt" customizable by the end user? Doesn't that that make distinguishing the most recently saved checkpoint harder for the framework?

Because it's quite common to want to append the epoch number in case you start multiple runs using the same directory.
It would be harder if we go off the checkpoint name, but we should either use their timestamps or "listen" on the save_checkpoint procedure

Does save_last still make sense on the ModelCheckpoint callback if the fault tolerant feature is enabled & rolled out? Is there redundancy if both are enabled?

I don't think it's redundant for the reasons above.

What happens if multiple model checkpoint callbacks are configured with save_last ? From which callback do we pick last_model_path from ?

Currently they get overwritten, there's a proposal to avoid this in #5030


chore: migrate to dotenv; delivery token -> accessToken

This PR does a few things, primarily because we (Gatsby!) have seen some issues with users and using environment variables. Specifically that the .contentful.json file is slightly different than what we recommend, and using a .env file may be a little more aligned with standards and best practices.
I realize this PR is somewhat opinionated, so would love to chat further if anything needs further explanation! Specifically what I've done:

Renamed delivery token -> access token

This seems to be a little more consistent (it is an access token) and then the environment variable CONTENTFUL_ACCESS_TOKEN can be used for both the delivery API and the preview API

Deleted .contentful.json and migrated to dotenv, .env files
Added some additional scripts (e.g. develop is a standard shortcut, as is start, e.g. npm start)

Thanks!

@axe312ger & @Khaledgarbaya, thoughts?

README needs to be updated.


Android build warning

Based on the warning message I got while building for Android, this package uses deprecated API.
Note: /Users/behnam/.pub-cache/hosted/pub.dev/external_app_launcher-3.1.0/android/src/main/java/com/example/launchexternalapp/LaunchexternalappPlugin.java uses or overrides a deprecated API.

+1

+1

@behnamsattar @papalardo
Thank you for reporting this issue. We will fix this in near future.


bundle exec rake on jruby 1.7.19 running in --1.8 mode

It appears that Bundler 1.12.4 cannot exec rake 10.5.0 on jruby 1.7.19 running in --1.8 mode. This happens to be the configuration used in Travis CI for jruby-18mode.
To reproduce locally:
rvm get stable
rvm install jruby-1.7.19
rvm use jruby-1.7.19@new-gemset-name --create
gem install rake -v 10.5.0
bundle exec rake

The result:
- What did you do?

  I ran the command `/Users/msiegel/.rvm/gems/jruby-1.7.19@docile/bin/bundle exec rake`

- What did you expect to happen?

  I expected Bundler to...

- What happened instead?

  Instead, what actually happened was...

Error details

    TypeError: can't convert Array into String
      org/jruby/RubyKernel.java:1766:in `exec'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/cli/exec.rb:44:in `kernel_exec'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/cli/exec.rb:26:in `run'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/cli.rb:304:in `exec'
      org/jruby/RubyKernel.java:2222:in `send'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/cli.rb:11:in `start'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/exe/bundle:27:in `(root)'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/lib/bundler/friendly_errors.rb:98:in `with_friendly_errors'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/gems/bundler-1.12.4/exe/bundle:19:in `(root)'
      org/jruby/RubyKernel.java:1082:in `load'
      /Users/msiegel/.rvm/gems/jruby-1.7.19@docile/bin/bundle:23:in `(root)'

Environment

  Bundler   1.12.4
  Rubygems  2.4.5
  Ruby      1.8.7 (2015-01-29 patchlevel 376) [java]
  GEM_HOME  /Users/msiegel/.rvm/gems/jruby-1.7.19@docile
  GEM_PATH  /Users/msiegel/.rvm/gems/jruby-1.7.19@docile:/Users/msiegel/.rvm/gems/jruby-1.7.19@global
  RVM       1.27.0 (latest)
  Git       2.8.2
  rubygems-bundler (1.4.4)

      Bundler settings

  orig_path
    Set via BUNDLE_ORIG_PATH: "/Users/msiegel/.rvm/gems/jruby-1.7.19@docile/bin:/Users/msiegel/.rvm/gems/jruby-1.7.19@global/bin:/Users/msiegel/.rvm/rubies/jruby-1.7.19/bin:/Users/msiegel/.rvm/bin:/opt/homebrew-cask/Caskroom/google-cloud-sdk/latest/google-cloud-sdk/bin:/usr/local/sbin:/usr/local/bin:~/bin:/Users/msiegel/.jenv/shims:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
  orig_gem_path
    Set via BUNDLE_ORIG_GEM_PATH: "/Users/msiegel/.rvm/gems/jruby-1.7.19@docile:/Users/msiegel/.rvm/gems/jruby-1.7.19@global"
  bin_path
    Set via BUNDLE_BIN_PATH<EMAIL_ADDRESS>  gemfile
    Set via BUNDLE_GEMFILE: "/Users/msiegel/Documents/opensource/docile/Gemfile"

Please note that I checked, and this doesn't appear to be related to #1844, even though they have similar text.

To anyone who encounters this bug by trying to support Ruby 1.8 versions: use rake version ~> 10.4.2 instead, which seems to work.

Update: it appears that the problem actually has nothing to do with rake version, so the above comment about 10.4.2 is wrong. As far as I can tell, bundler 1.12.4 is broken in bundle exec on jruby-18mode, period.
Does anyone know any more?

bundle exec rake works just fine for me under jruby

Hi @segiddins I apologize for not clarifying, this is jruby, in 1.8 mode. That's equivalent to the travis ci config jruby-18mode, and you should add this environment variable locally to produce the behavior:
export JRUBY_OPTS="--1.8"

If you still can't reproduce, please see my failing builds from the Docile gem, for example: https://travis-ci.org/ms-ati/docile/jobs/131159524

warning: --1.8 ignored

@segiddins: what version of jruby are you using? Is it not 1.7.19?

ah missed that, it's whatever the latest version is

Can you reproduce the issue in jruby 1.7.19 in 1.8 mode? Do you know on what exact jruby version it was working for you in 1.8 mode?
If so, that would make me think I should report to travis project to upgrade the jruby in jruby-18mode?

I don't know what jruby 1.8 mode even is 😁

Looks like JRuby in 1.8 mode has buggy Kernel.exec, i. e. it does not support 'If command is a two-element array, the first element is the command to be executed, and the second argument is used as the argv[0] value, which may show up in process listings. ' part (fails with TypeError: can't convert Array into String).
Filled https://github.com/bundler/bundler/pull/4790 to fix it.


It should be possible to obtain the path of a sub-client.

Getting the path from a sub-client should be possible so that it could even become possible to store/transmit paths and payloads completely independently.
For instance:
let my_client = Client::new("https://<IP_ADDRESS>:8006", "user", "password");

let ct = NodesClient::new(&my_client).nodes().node("proxmox").lxc().vmid(VmId::new(100).unwrap());
let ct_path = ct.path();
assert_eq!(ct_path.as_ref(),  "/nodes/proxmox/lxc/100");

implement a trait called get_path, and generate it with generator


Would be awesome to be able to push a set of helpers to the @preload

It would be great to be able to pass additional args (or an helpers objects) to the preload.
Just like https://github.com/makeomatic/redux-connect

I don't get what you mean

Redux connect is just like your preload annotation, it allows to prefetch data before entering a route.
By default, the preload callback has this signature:
@preload(function(dispatch, getState, location, params) { return Promise })

I suggest to add a configurable helpers argument. The signature would be:
@preload(function(dispatch, getState, location, params, helpers) { return Promise })

And in the configuration we could add an option like that to configure the helpers:
preload: {
    helpers: {
            logger: (msg) => console.log("I prefetched :"+msg)
    }
}

So in my preload method, i could do something like:
@preload((dispatch, helpers) => {
    dispatch(...some_action...);
    helpers.logger("A little log");
})

Ok, and what is params in redux-connect?

It is the route params.
If my route is defined with something like that
<Route path="/page/:slug">

I would get the slug in params

Implemented in 5.0.0.
{
  preload:
  {
    helpers:
    {
      logger: ...
    }
  }
}


⚠ Fortnite has degraded performance

In 9470d3b, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1619 ms

Resolved: Fortnite performance has improved in f13ef03.


Russian translation fix

Translated non-translated words.
Deleted schemes in links: all these sites now have TLS, so http: is redundant.

Thanks for your contribution!


Bot Framework V4 human handoff sample NodeJS

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
Need a sample to demonstrate how to proper use of the human hand-off in bot V4 @ nodeJS.
Current example in github by other seem to be outdated.
Node - https://github.com/GeekTrainer/botframework-v4-handoff
Describe the solution you'd like
A clear sample with updated code to show how we can use the human handoff interaction.
Describe alternatives you've considered
NA.
Additional context
NA.
[enhancement]

dup of #1133

This is not an official sample, but I made a Human Handoff Bot using the most recent NodeJs SDK that you can take a look at. https://github.com/tdurnford/botframework-human-handoff
Hope this helps.

Thanks alot @tdurnford


why don't found example's components PhotoGrid?

Hey!
Why don't found components PhotoGrid?I see the HomePage example have the component

I should probably add it, but in the meantime: https://gist.github.com/dabbott/b62e9b7cd25d41dd59ec1a10b158481f


Fix typos.

r? @jamesmunns
(rust_highfive has picked a reviewer for you, use r? to override)

bors: r+


Camera no longer moves when clicking minimap

Describe the bug
The camera moves with arrow keys, but does not move when clicking minimap. Other mouse actions such as unit selection still work with the mouse and the selection is still reflected in the main window.
To Reproduce
Steps to reproduce the behavior, for example:

Start any game from the debugger and set a breakpoint in the OnGameStart() function
Try moving the camera by clicking on the minimap

Desktop (please complete the following information):

OS / Distro: [Windows 10]
cpp-sc2 Version: SHA 3bd046938ac3e510655fb26ca8816e6872f36d85,
StarCraft II version [Base81009]

Additional context
The cpp-sc2 versions is older, and I don't think the problem stems from there. Can you let me know if you can reproduce? Otherwise, it could be OpenCv, that added relatively recently, or a Blizzard update, or ...

Does your problem only happen if you have a breakpoint in OnGameStart()? If put your breakpoint later when the game is started, does the minimap work? I haven't put a breakpoint in OnGameStart() for a long time but I know that it works when I use breakpoints later on, though I haven't tried in sc2 version 5.

Unfortunately, the problem still occurs after OnGameStart() as well. If anyone has tried this without a problem, on the same version of sc2 please let me know, and I'll conclude it is something weird in my setup.

On the sc2ai discord, people have confirmed the problem. Some people think it is not a bug but rather intented by Blizzard to counter cheaters. I'm not sure about that since the ladder games are realtime and the problem doesn't seem to occur in realtime.

Thanks


Model registration decorators

The current syntax is pretty much the poster child for decorators:
class MyModel(models.Model):
    pass
auditlog.register(MyModel, exclude_fields=["example"])

I propose the following:
@auditlog.register(exclude_fields=["example"])
class MyModel(models.Model):
    pass

Would you be interested in a PR?

Seems useful. I am actually very interested in a PR, looking forward to your solution.


Invalid usage of the option FIRST in the FETCH statement.

All of a sudden I recently started having this error occur on any django ORM operation that I use:
[42000] [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Invalid usage of the option FIRST in the FETCH statement. (153) (SQLExecDirectW); [42000] [Microsoft][ODBC Driver 13 for SQL Server][SQL Server]Statement(s) could not be prepared. (8180)
This is what the query looks like in the django traceback:
QUERY = 'SELECT [Entity].[Audit], [Entity].[Class], [Entity].[FromArrow], [Entity].[FromAssc], [Entity].[ID], [Entity].[Name], [Entity].[SeqNum], [Entity].[Properties], [Entity].[ToArrow], [Entity].[ToAssc], [Entity].[Type], [Entity].[UpdateDate], [Entity].[SAGuid], [Entity].[PropType], [Entity].[ShortProps], [Entity].[Activity], [Entity].[CRID], [Entity].[CRURL], [Entity].[CRROOTURL], [Entity].[Version] FROM [Entity] WHERE [Entity].[ID] = %s FETCH FIRST 21 ROWS ONLY' - PARAMS = (1,)
This is the line of code that is being executed where the error occurs:
Entity.objects.using(encyclopedia).get(pk=pk)
Here is my database connection from settings.py (we are on an internal network, so it authenticates using my built in windows credentials):
{
    'ENGINE': 'sql_server.pyodbc',
    'NAME': 'database',
    'HOST': 'server',
    'OPTIONS': {
        'driver': 'ODBC Driver 13 for SQL Server',
    }
}

Here are the details of my application installation and versions:
django-mssql-backend==2.8.1
Django==3.0.7
MS SQL Server Version==14.0.3238.1

I've been using this package on these same databases in the past, and I have not seen this issue occur before. This makes me think that its something I must have done, but I can't think of what would be causing it. Any help would be greatly appreciated! Thanks!

On microsoft odbc driver page,they say that driver odbc 13 only supports SQL server up to 2016 (preview) and it looks like you are using SQL server 14 = 2017. I would try to upgrade the driver and try again.


Show Playlist Duration

Can you add the duration for albums and the queue?

I don't know where to display the duration on the screen,especially, the queue duration

The duration for albums could be displayed in the description of albums under the name and artist. I'm not sure of a good place for the queue duration to be displayed.

I'm closing this issue in favor of #80 since there doesn't seem to be a good place to show duration in the queue.


How's the cer/p12 identifier generated?

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
How's the cer/p12 identifier generated?
Question Description
How's the cer/p12 identifier generated?
.cer and .p12 stored in the repo.
The identifier seems to be different from the identifier that I see in the Keychain Access. How can I verify if it's the same certificate between the keychain and the stored repo when the identifiers are different/renamed?
Thanks

How's the cer/p12 identifier generated?

Where? There are multiple places that generate certificates in fastlane.

@cuongta @janpio  do you know how the password is generated? i want the password of certificate generated by cert action. is there any way?

@bhavincb The password is supplied by the user at the time of creation. It is not stored anywhere, besides possibly Keychain Access, at the user's discretion.

@snatchev , there is no parameter for supplying password to the cert action.  how to supply password to the cert action?

@bhavincb looks like you are correct, there is no password in the cert action. The password is only applied when the certificate is turned into a p12 file.
@cuongta could you try using openssl pkcs12 -info -in my.p12 to get more info about the certificates so you can cross-reference them to the ones in the repo?
As far as I know, fastlane does not change any identifiers for existing certificates. It may be the case that Keychain Access applies some identifiers for the UI, but I do not understand how that works.

@snatchev  cert action also generates p12 certificate. so which password it uses when generating this file?

it is a blank password
https://docs.fastlane.tools/actions/pem/#note-about-empty-p12-passwords-and-keychain-accessapp
On Tue, May 14, 2019 at 10:54 AM Bhavin Jalodara<EMAIL_ADDRESS>wrote:

@snatchev https://github.com/snatchev cert action also generates p12
certificate. so which password it uses when generating this file?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/14745?email_source=notifications&email_token=AAAAZ4FD6M4EZX3W3UFMPLDPVLHCFA5CNFSM4HMGMCQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLXX5A#issuecomment-492272628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAAZ4G4KX6MQTEHXVWA2YDPVLHCFANCNFSM4HMGMCQQ
.


Error

Hello,
Please read documentation to understand how to get your account and use that on your code:
https://github.com/Kucoin/kucoin-python-sdk

Hello, is it not possible to earn this, there are examples?

Hello there,
No!
Actually, Because there is not enough speed to order execution and catch opportunities :)


Complete login logic for map side panel

fixes #498
When logged in, this will be displayed, instead:

On qa, it will be https://qa.vectorbase.org/vectorbase/app/user/profile

@bobular I added a commit that makes clicking on the analysis name switch to edit mode

@bobular I added a commit that makes clicking on the analysis name switch to edit mode

I noticed!  Thanks :-)


How is it possible to obtain retweets? From the account (Not from the tweet)

I want to take the old retweets of the accounts, How I can do this?
Thanks for everything !

Sadly I don't know. I have look in Twitter but I only get a few retweets, not all :/

Hi, look what I have found @wurik. It seems that Twitter API only returns the most 100 recent retweets :/
https://dev.twitter.com/rest/reference/get/statuses/retweets/%3Aid


No consumer contract parser found for hash

Issue when verifying my pact
sample code
const pact = require('@pact-foundation/pact-node')

const opts = {
	providerBaseUrl: 'http://my.api', // where your service will be running during the test, either staging or localhost on CI
	// providerStatesSetupUrl: 'http://localhost:3001/test/setup', // the url to call to set up states
	// pactUrls: ['http://localhost/'], // the pacts to test against
	// pactBrokerUsername: 'shanelee007',
	// pactBrokerPassword: 'xxx',
	publishVerificationResult: true,
	providerVersion: '2.0.0'
	provider: 'Talent%20API'
}

pact.verifyPacts(opts)
	.then(() => {
		console.log('success')
		process.exit(0)
	})
	.catch(error => {
		console.log('failed', error)
		process.exit(1)
	})

When i run this i was expecting to pull down all pacts for my provider. I am running the latest pact broker docker image
But i get the error above
Deps are:
    "@pact-foundation/pact": "5.9.1",
        "@pact-foundation/pact-node": "^6.19.4",

it only works when i hardcode the absolute url for the pact broker
pactUrls: [
		'http://localhost/pacts/provider/Talent%20API/consumer/experienceAPI/latest'
	 ], // the pacts to test against

Thanks @shavo007.
Could you please post the debug logs for this. You'll need to set the following in your test code:
var pact = require('@pact-foundation/pact-node');
pact.logLevel('debug');

As a start, you need to URL encode your provider name. i.e.
provider: 'Talent%20API'

can simply be:
provider: 'Talent API'

not a problem @mefellows
config again:
const pact = require('@pact-foundation/pact-node')

pact.logLevel('debug')

const opts = {
    providerBaseUrl: 'http://talent.xxx', // where your service will be running during the test, either staging or localhost on CI
    // providerStatesSetupUrl: 'http://localhost:3001/test/setup', // the url to call to set up states
    pactUrls: ['http://localhost'], // the pacts to test against
    pactBrokerUsername: 'shanelee007',
    pactBrokerPassword: 'xxx',
    publishVerificationResult: true,
    providerVersion: '2.0.0',
    provider: 'Talent API'
}```

here is the error trace

```failed Error:node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-support-1.6.2/lib/pact/consumer_contract/consumer_contract.rb:44:in `from_hash': No consumer contract parser found for hash: {"_links"=>{"self"=>{"href"=>"http://localhost", "title"=>"Index", "templated"=>false}, "pb:publish-pact"=>{"href"=>"http://localhost/pacts/provider/{provider}/consumer/{consumer}/version/{consumerApplicationVersion}", "title"=>"Publish a pact", "templated"=>true}, "pb:latest-pact-versions"=>{"href"=>"http://localhost/pacts/latest", "title"=>"Latest pact versions", "templated"=>false}, "pb:pacticipants"=>{"href"=>"http://localhost/pacticipants", "title"=>"Pacticipants", "templated"=>false}, "pb:latest-provider-pacts"=>{"href"=>"http://localhost/pacts/provider/{provider}/latest", "title"=>"Latest pacts by provider", "templated"=>true}, "pb:latest-provider-pacts-with-tag"=>{"href"=>"http://localhost/pacts/provider/{provider}/latest/{tag}", "title"=>"Latest pacts for provider with the specified tag", "templated"=>true}, "pb:provider-pacts-with-tag"=>{"href"=>"http://localhost/pacts/provider/{provider}/tag/{tag}", "title"=>"All pact versions for the provider with the specified consumer version tag", "templated"=>true}, "pb:provider-pacts"=>{"href"=>"http://localhost/pacts/provider/{provider}", "title"=>"All pact versions for the specified provider", "templated"=>true}, "pb:latest-version"=>{"href"=>"http://localhost/pacticipants/{pacticipant}/latest-version", "title"=>"Latest pacticipant version", "templated"=>true}, "pb:latest-tagged-version"=>{"href"=>"http://localhost/pacticipants/{pacticipant}/latest-version/{tag}", "title"=>"Latest pacticipant version with the specified tag", "templated"=>true}, "pb:webhooks"=>{"href"=>"http://localhost/webhooks", "title"=>"Webhooks", "templated"=>false}, "curies"=>[{"name"=>"pb", "href"=>"http://localhost/doc/{rel}?context=index", "templated"=>true}]}} (Pact::Error)
	from node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-support-1.6.2/lib/pact/consumer_contract/consumer_contract.rb:49:in `from_json'
	from node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-1.28.0/lib/pact/provider/rspec.rb:26:in `honour_pactfile'
	from node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-1.28.0/lib/pact/provider/pact_spec_runner.rb:123:in `block in initialize_specs'
	from node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-1.28.0/lib/pact/provider/pact_spec_runner.rb:119:in `each'
	from node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-1.28.0/lib/pact/provider/pact_spec_runner.rb:119:in `initialize_specs'
	from node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-1.28.0/lib/pact/provider/pact_spec_runner.rb:34:in `run'

Thanks @shavo007, can you please paste the output of stdout during the run. You should see something like:
[2018-07-13T00:05:28.594Z] DEBUG<EMAIL_ADDRESS>on Matts-iMac.local: Finding consumers
[2018-07-13T00:05:28.594Z] DEBUG<EMAIL_ADDRESS>on Matts-iMac.local: finding pacts for Provider: Animal Profile Service Tag: undefined
[2018-07-13T00:05:32.916Z] DEBUG<EMAIL_ADDRESS>on Matts-iMac.local: Starting pact binary with '/bin/sh,[object Object],{"cwd":"/Users/mfellows/development/public/pact-js/node_modules/@pact-foundation/pact-node","detached":true,"env":{"npm_config_save_dev":"","npm_config_legacy_bundling":"","npm_config_dry_run":"","CLOUDFLARE_API_KEY":"6a23f6371f12d818cb3368c996f5e84562eff",
...

This will help us see what pact-node is trying to do.

BTW, i am using node 10.5.0
there is alot of output here but it starts with
[2018-07-13T01:11:20.700Z]  INFO<EMAIL_ADDRESS>on L3010: Verifying Pacts.
[2018-07-13T01:11:20.704Z]  INFO<EMAIL_ADDRESS>on L3010: Verifying Pact Files
[2018-07-13T01:11:20.707Z] DEBUG<EMAIL_ADDRESS>on L3010: Starting pact binary with '/bin/sh,[object Object],{"cwd":"node_modules/@pact-foundation/pact-node","detached":true,"env":{"npm_package_devDependencies_lint_staged":"7.2.0","npm_package_nyc_lines":"78","npm_package_devDependencies_prettier":"1.13.7","npm_package_nyc_functions":"80","npm_package_nyc_instrument":"false","npm_package_nyc_exclude_4":"src/**/apiConstants.js","TERM_PROGRAM":"iTerm.app","npm_package_nyc_exclude_3":"src/config","npm_package_devDependencies__pact_foundation_pact":"5.9.1","LESS_TERMCAP_md":"\u001b[38;5;136m","NODE":"/Users/slee/.nvm/versions/node/v10.5.0/bin/node",

[2018-07-13T01:11:20.712Z]  INFO<EMAIL_ADDRESS>on L3010: Created './standalone/darwin-1.47.2/bin/pact-provider-verifier 'http://localhost' --provider-base-url 'http://api.blah' --broker-username 'shanelee007' --broker-password 'xxx' --publish-verification-results 'true' --provider-app-version '2.0.0'' process with PID: 364
[2018-07-13T01:11:21.669Z] DEBUG<EMAIL_ADDRESS>on L3010:
   node_modules/@pact-foundation/pact-node/standalone/darwin-1.47.2/lib/vendor/ruby/2.2.0/gems/pact-support-1.6.2/lib/pact/consumer_contract/consumer_contract.rb:44:in `from_hash': No consumer contract parser found for hash: {"_links"=>{"self"=>{"href"=>"http://localhost", "title"=>"Index", "templated"=>false}, "pb:publish-pact"=>{"href"=>"http://localhost/pacts/provider/{provider}/consumer/{consumer}/version/{consumerApplicationVersion}", "title"=>"Publish a pact", "templated"=>true}, "pb:latest-pact-versions"=>{"href"=>"http://localhost/pacts/latest", "title"=>"Latest pact versions", "templated"=>false}, "pb:pacticipants"=>{"href"=>"http://localhost/pacticipants", "title"=>"Pacticipants", "templated"=>false}, "pb:latest-provider-pacts"=>{"href"=>"http://localhost/pacts/provider/{provider}/latest", "title"=>"Latest pacts by provider", "templated"=>true}, "pb:latest-provider-pacts-with-tag"=>{"href"=>"http://localhost/pacts/provider/{provider}/latest/{tag}", "title"=>"Latest pacts for provider with the specified tag", "templated"=>true}, "pb:provider-pacts-with-tag"=>{"href"=>"http://localhost/pacts/provider/{provider}/tag/{tag}", "title"=>"All pact versions for the provider with the specified consumer version tag", "templated"=>true}, "pb:provider-pacts"=>{"href"=>"http://localhost/pacts/provider/{provider}", "title"=>"All pact versions for the specified provider", "templated"=>true}, "pb:latest-version"=>{"href"=>"http://localhost/pacticipants/{pacticipant}/latest-version", "title"=>"Latest pacticipant version", "templated"=>true}, "pb:latest-tagged-version"=>{"href"=>"http://localhost/pacticipants/{pacticipant}/latest-version/{tag}", "title"=>"Latest pacticipant version with the specified tag", "templated"=>true}, "pb:webhooks"=>{"href"=>"http://localhost/webhooks", "title"=>"Webhooks", "templated"=>false}, "curies"=>[{"name"=>"pb", "href"=>"http://localhost/doc/{rel}?context=index", "templated"=>true}]}} (Pact::Error)

AH, I see it.
pactUrls: ['http://localhost'], // the pacts to test against

This is a list of known pact URLs. If you want to fetch from the broker, you need to specify the pact broker URL, e.g.
pactBrokerUrl: 'http://localhost',

This is why we're not seeing "Finding consumers ..." at the start.

voila, that worked @mefellows!!!
pactBrokerUrl: 'http://localhost', // the pacts to test against

i think the docs are a bit confusing.
why have two fields for pact broker url?
https://github.com/pact-foundation/pact-node#provider-verification

pactBrokerUrl which is a string and pactUrls which is an array

also providerVersion  is a boolean, i believe it should be a string?

Yep, I can see how it's a bit confusing, I'll update the docs shortly.
We don't actually have two fields for a pact broker url - pactUrl just takes an arbitrary number of URIs where pacts reside - whether local files or on remote HTTP systems (it just so happens that you can point broker URLs in their to the specific pact files).
pactBrokerUrl tells the verifier to use the broker discovery system to find all relevant pacts.
Does that make sense?

yes and no @mefellows !
i was under the assumption pacts are verified by a broker?
but i guess you could host them on a http server if you wanted.
i guess its an easy mistake but the error i got would not help me decipher what was wrong!
thanks for your help anyway

It didn't help me either - so I agree with you there.
I'll raise an issue over in the verifier repo to see what we can do.

👍

i was under the assumption pacts are verified by a broker?

Pact generation and verification happens on your machine. The pact broker stores the pacts and verification results.


Add device related icons to the Sketch Page

Sample Icons

Requirements:

Do not mess up any other part of the web app
Add an icon on the horizontal menu, on clicking which a drop down/another bar appears below showing options for icons representing laptops, pc, phones, etc which can be imported as a shape like the other ones
Add up to 10 different icons
Please test this thoroughly before giving a PR
Make use of any open source icons (or make custom icons) for this. You are required to give references in the PR description.

General PR Guidelines:

Each pull request should have an appropriate and short title like "Fixed Bug in Upload Page"

Describe your intended changes in the description section of the pull request (Use bullet points and phrases)

Refrain from using phrases like "Hi, I am ..", "Please merge me this OPR", "Thank You..", etc. We are only interested in technical parts

Attach a screenshot/clip of the change(s)

Make sure to refer to the respective issue in the respective PR using phrases like Resolves #issue_number or Closes #issue_number.

Please be patient enough. The project maintainers/mentors would review it as per their schedule. Please do not start putting comments like "Please check this" etc.

Although we support feedback from everyone in all phases of development, it is highly advised not to put any negative comments in other participant's pull requests.

Always keep a note of the deadline.

i want to work on this

i want to work on this

Assigned for 3 days


Changing the order of a Control node during TreeExiting results in errors and strange behaviour

Godot version
4.0.dev 9142904c2
System information
Win 11, RTX 3060
Issue description
If a script changes the order of a control node within it's siblings during the TreeExiting event, many errors are thrown continuously whenever the mouse cursor hovers over the deleted control.
This also results in strange behaviour - for example, nodes above the deleted one no longer receive input.
The actual errors:
E 0:00:02:0210   Node::can_process: Condition "!is_inside_tree()" is true. Returning: false   <C++ Source>   scene\main\node.cpp:686 @ Node::can_process()
E 0:00:02:0228   CanvasItem::get_global_transform: Condition "!is_inside_tree()" is true. Returning: get_transform()   <C++ Source>   scene\main\canvas_item.cpp:172 @ CanvasItem::get_global_transform()
Please note that I've only tested this in C#, but it's most likely not C# specific.
Steps to reproduce

Subscribe to the TreeExiting event/signal in a way that adds or deletes a node ahead of the current one in the scene hierarchy (so that the index of the current node changes).
Delete the node that you subscribed to.

Minimal reproduction project
DeleteTest.zip
Click on the button, then hover over the label. Errors show up.

Happens in 3.5.stable as well.


Disable autocorrect

Is there a way to disable autocorrect on the text input? I tried setting autoCorrect={false} on the  tag, but it doesn't seem to get passed through.

Oops, found the answer here: https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/83


[FSDE-16525] Migrate carousel to new vue documentation

You can check this PRs instance in https://c667b890b40d47ff2f9f137d3496f7971276aa9b-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-346-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-346/3/. :white_check_mark:

You can check this PRs instance in https://fb4bd89853c7311eb48fb2a231177782da3538da-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-346-ux-chi.kubeodc-test.corp.intranet/ (internal)


Generate portable documentation from the wiki

This PR uses pandoc and make to generate portable .docx documents using the project wiki as the source material.
closes #380

Maybe this new doc should be run by us and published on the daffodil site as part of each release? Then people could just download it.

Maybe this new doc should be run by us and published on the daffodil site as part of each release? Then people could just download it.

It wouldn't be too hard to add the git checkout + pandoc commands to the release candidate container script and add the result to the site repo. Similar to what we already do for Daffodil lib java/scala docs. This way we never even need to manually run it and it's just part of the automated process.

@stevedlawrence and @mbeckerle, I really like the idea of publishing the documentation via a release script and allowing users to just download the built artifacts.  This also solves the problem where the documents move along with the releases.  We'll want to publish the documentation as points in time.  For instance documentation for v1.2.0 will be different than v1.3.0, etc.  Since the wiki itself is a git repo, we can tag it, but if we have the documents generated at the time of a release, it solves the problem that way.

Maybe this new doc should be run by us and published on the daffodil site as part of each release? Then people could just download it.

@mbeckerle +1 👍, I think the daffodil-site repo would be a better location for this to live.

@mbeckerle +1 👍, I think the daffodil-site repo would be a better location for this to live.

@Shanedell, will take point on making that happen?

@mbeckerle +1 👍, I think the daffodil-site repo would be a better location for this to live.

@Shanedell, will take point on making that happen?

Yeah I should be able to get this going tomorrow

@stevedlawrence @mbeckerle I think I miss understood. So what should be done is I add pandoc to the release-canidate container, then update the process to create the Makefile, clone the repo and make the docs? After making the docs how would I upload them to the daffodil-site or would I upload somewhere similar to where the bin and source are stored?

So what should be done is I add pandoc to the release-canidate container, then update the process to create the Makefile, clone the repo and make the docs?

Yep. You might not even need the Makefile? Just need to update the release-candidate script to run the couple of commands that are needed. It's just a git clone and pandoc, right?

After making the docs how would I upload them to the daffodil-site or would I upload somewhere similar to where the bin and source are stored?

The release candidate script already clones and updates the site repo with java/scala docs, so it should be similar. For example, it currenly does this:
    echo "Installing Site Docs..."
    rm -rf $DAFFODIL_DOCS_DIR
    mkdir -p $DAFFODIL_DOCS_DIR/{javadoc,scaladoc}/
    cp -R target/javaunidoc/* $DAFFODIL_DOCS_DIR/javadoc/
    cp -R target/scala-2.12/unidoc/* $DAFFODIL_DOCS_DIR/scaladoc/

Note ha DAFFODIL_DOCS_DIR is just subdirecory in DAFFODIL_SITE_DIR specific to java/scaladocs.
So in the "daffodil-vscode" section of the container scrip, you can clone the vscode wiki, run pandoc, and copy the resulting file somewhere to $DAFFODIL_SITE_DIR.
Whatever changes you make to the site repo are automatically committed and pushed when "complete-release" is run, so it's just a matter of building and installing the resulting pdf's to the right directory in the site repo and everything else should just work.

@stevedlawrence That makes sense thank you. Should I make a directory site/docs/vscode/{release_version} to hold the docs? Currently it seems the base directories are mapped to daffodil release so figured we want a separate folder for the vscode releases correct?

Yep, seems reasonable to me

I am going to be closing this PR as these PR's replace it:

https://github.com/apache/daffodil-site/pull/103
https://github.com/apache/daffodil/pull/897


Virtual devices with fibaro commands through ha-bridge

I am interested to know if anyone has had any luck with controlling LUA virtual devices through their echo/google home via Fibaro HC2 yet? I have a few LUA virtual devices and i cant seem to find an ID for the http command to type into the HA...

Could you post this on the Fibaro Support request that is already open. Then close this issue. Thanks


test: Image processing with variants

The aim is to make sure enhance.go is as reusable as possible.
We need to debug how the paths are being resolved and get consistent behaviour between the test function and production function.
The trailing slash seems like the bane of pre-processing in any language, on any platform! It won't be possible to satisfy all environments but pick the direction that makes the most sense for now.

This is up and running.
The main issue was the test function wasn't monitoring the correct processed files folder for the final outcome. Now that's fixed, we're seeing well-defined behaviour under bulk testing of 512 test inputs.
Variant statistics:
  Expected total variants: 1510-1822
  Actual total variants: 1512


[Feature] Always use same scope when update model in ES

Is your feature request related to a problem? Please describe.
With scout:import the model scopes can be set with ImportSourceFactory, so you know all related models are correctly indexed as well in your Elasticsearch (ES) as they can be eager loaded.
But when you do a $model->save() somewhere in your code (e.g controller action), you must be sure to ALSO eager load the correct relations you need te be indexed in ES.
This means you have to take care of these scopes in multiple places.
Now you could say, just set the with attribute in your model, but then you have no control anymore of when you want tot eager load and when not. The ImportSourceFactory would also not be needed anymore! But this IS a nice feature to have more control of it all!
Describe the solution you'd like
When the model is indexed into ES, it can be configured (somehow) to always have the same relations eager loaded (amongst other things you'd like), to always have the same data indexed in ES.
Describe alternatives you've considered
In the Searchable trait there is a function perhaps helpful:
    /**
     * Get the indexable data array for the model.
     *
     * @return array
     */
    public function toSearchableArray()
    {
        return $this->toArray();
    }

This could be overridden in your model. But I am not sure it is the best place to manage eager loading... And also, what would be the purpose of ImportSourceFactory anyways?
Additional context
Perhaps this is more a question than a feature request. Anyhow, suggestions are welcome!

The idea of 'ImportSourceFactory' to remove 'eloquent' dependency. Not implemented yet

You can extend https://github.com/laravel/scout/blob/1c4b66c36c2d6fdf94a8b79e2fbb9f4b378a6e26/src/Searchable.php#L25 and add your global scope.

'

The idea of 'ImportSourceFactory' to remove 'eloquent' dependency. Not implemented yet

Did not know that, thank you for the clarification!

You can extend https://github.com/laravel/scout/blob/1c4b66c36c2d6fdf94a8b79e2fbb9f4b378a6e26/src/Searchable.php#L25 and add your global scope.

(or override the trait in the model itself)
But this is not about Global Scopes, as in must be always applied. I need to be flexible to eager load relations in one place, and not eager load in another place.
But when it comes to send a model to ES, then I always want to eager load (and send along with the model data) the same relations. Because always the same data needs be indexed for the searches.

All I needed was already there, but I had no overview. Me writing down the questions I had gave me the overview.
This could be the simple answer:
class Vacancy extends Model
{
    use Searchable,
        SoftDeletes;

// ...

    /**
     * Get the indexable data array for the model.
     *
     * @return array
     */
    public function toSearchableArray()
    {
        $with = [
            'branches',
            'client',
            'company',
            'education',
            'licenses',
            'recruiterProfile',
        ];
        $this->loadMissing($with);

        return $this->toArray();
    }

Great solution) Thanks! I'll add it to README

The last question how to combine logic from toSearchableArray  and ImportSourceFactory which  relations to load in one place


fix: proc append warnings for file attributes

:tada: This PR is included in version 3.9.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


how to hide columns, but still have their data available when selected

How do I properly hide a column so that it is still available when I call grid.getRowSelection()?
I'm using the library (nice job) to view the contents of a database table. After filtering and sorting the table, I need to obtain my data.ID field.
I don't want to display the ID column, but when a user selects a row, I want to use the ID of the selected data to do an action. I am using grid.selectRowsFromCells(); to select the row when the fin-selection-changed event is distributed.

Hello John... Thanks for giving Hypergrid a try...
One thing you can do is temporarily add your 'ID' column, call grid.getRowSelection(), then remove it. For example:
const IdColumnIndex = 0; // let's assume you know it's index
const columnIndexes = [1,2,3]; // we'll also assume you have your column indexes array
grid.behavior._setColumnOrder([IdColumnIndex]); // resets the internal list without updating the grid
var rows = grid.getRowSelectionMatrix(); // The "Matrix" version returns each column in an array
grid.behavior._setColumnOrder(columnIndexes); // restore
var IDs = rows[0]; // just the first (and only) column

If you want all the currently visible fields as well:
grid.behavior._setColumnOrder(columnIndexes.concat(IdColumnIndex));
var rowsIncludingIDs = grid.getRowSelection();
grid.behavior._setColumnOrder(columnIndexes); // restore

Jonathan

@joneit thank you for the response!
I found I could pass a bool to grid.getRowSelection(true) to make it include "hidden" data fields. Now I'm trying to find a way to do similar with grid.getRowSelectionMatrix() which does not take a bool. I will test your technique and let you know if I am successful.

Ha! you're right of course, I totally missed that. That's what I get for
answering mail at end of long day... I will add that parameter to the
Matrix version on the next release. But in the meantime you can do what I
suggested as a work-around. Jonathan
On Fri, Nov 18, 2016 at 12:29 PM, John Grant<EMAIL_ADDRESS>wrote:

@joneit https://github.com/joneit thank you for the response!
I found I could pass a bool to grid.getRowSelection(true) to make it
include "hidden" data fields. Now I'm trying to find a way to do similar
with grid.getRowSelectionMatrix() which does not take a bool. I will test
your technique and let you know if I am successful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openfin/fin-hypergrid/issues/399#issuecomment-261590895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFt_EB6Tpj2fcOzzP38msSxDvfrd3yigks5q_eCPgaJpZM4K1-2v
.

--
Jonathan Eiten
Senior Developer | OpenFin
201-674-1457
<EMAIL_ADDRESS>Build Once. Deploy Instantly. Run Natively.
www.openfin.co | @openfintech
Skype: jonaverse
Twitter: @JonathanEiten
LinkedIn: http://www.linkedin.com/in/jonathaneiten
http://www.linkedin.com/in/jonathaneiten

Actually, I could use a tip about how to obtain all column indexes (if you know off the top of your head) and how to obtain a specific column index. I'm still looking for these methods.

John,
There is a set of "all" indexes and a subset of "active" indexes. Both are ordered sets (arrays). Those missing from the latter set are "hidden" columns.
Generally you control these sets by providing them to Hypergrid, which is the best practice. If you do not, Hypergrid infers the set of "all" indexes from the data. Hypergrid assumes all columns are active (i.e., the set of active indexes is the same as the set of all indexes).
Note, however, this not the recommended practice: The order of the inferred set is not defined. While the columns may appear in the order you expect, this is just luck because the order is undefined; you cannot depend on the order you see remaining the case in the future, or in different execution environments, etc.
You specify the order by doing (at least) one of the following:

Pass the schema option to the Hypergrid constructor.
Call myGrid.behavior.dataModel.setSchema method after instantiation.

The objects in schema contain information about each column, including the column name. For example:
var schema = [
    { name: 'ID' },
    { name: 'zip_code' },
    ...
];

var grid = new Hypergrid({ schema: schema });

You can dig the schema out of Hypergrid (or get the schema you let Hypergrid infer from the data if you didn't supply a schema):
var schema = myGrid.behavior.dataModel.schema;

From the schema you can get the number of data fields:
var columnCount = schema.length;

The column index is the position of the column in the array. Therefore, if you want the column index when you know the column name:
var columnIndex = getColumnIndexFromName('zip_code');

function getColumnIndexFromName(columnName) {
    return schema.findIndex(function(s) { return s.name === columnName; });
}

You can also access the column objects created by Hypergrid from the schema. These objects are the run-time objects representing columns.
function getColumnIndexFromName(columnName) {
    var length = schema.length;
    for (var i = 0, i <length; i++) {
        if (grid.behavior.getColumn(i).name = columnName) {
            return i;
        }
    }
}

Finally, you can do something similar with the set of active columns:
function getColumnIndexFromName(columnName) {
    length = grid.behavior.getActiveColumnCount();
    for (var i = 0, i <length; i++) {
        if (grid.behavior.getActiveColumn(i).name = columnName) {
            return i;
        }
    }
}

Jonathan

HI Jonathan,
I had some trouble with your instructions. I believe some of the methods you mentioned did not exist, at least in the version I am using. Regardless, I made some progress, but I have one new problem.
To find the indices of the active columns and the "complete" list of columns, I did the following:
function getColumnIndexFromName(columnName) {
    var schema = grid.behavior.schema;
    return schema.findIndex(function(s) { return s.name === columnName; });
}
var allColumns = grid.behavior.schema.map(function(spec) {
    return getColumnIndexFromName(spec.name);
});
var activeColumns = grid.behavior.columns.map(function(c) {
    return c.index;
});

Then I could apply the temporary "column ordering", as such.
grid.behavior._setColumnOrder(allColumns);
var multiselectResults = grid.getRowSelectionMatrix();
grid.behavior._setColumnOrder(activeColumns);

To have a more useful result, I implemented this transformation:
function transformSelectionMatrix(multiselect, selectedRowCount, schema) {
    var iRow,
        rows = [],
        row;
    for(iRow=0; iRow<selectedRowCount; iRow++) {
        row = {};
        schema.forEach(function(schemaElement, schemaIndex) {
            row[schemaElement.name] = multiselect[schemaIndex][iRow];
        });
        rows.push(row);
    }
    return rows;
}

Which I invoked like this:
var selectedRowCount = (multiselectResults.length > 0) ? multiselectResults[0].length : 0;
return transformSelectionMatrix(multiselectResults, selectedRowCount, grid.behavior.schema);

New Problem
The new problem seems to be that multiple rows are not selected. I can visually see multiple vertical cells selected, but only the initially selected cell properly "selects" (or checks) the row. Additionally, the array depth of all elements in the selection "matrix" are as if I only selected cells from one row.
Again, I am using grid.selectRowsFromCells(); to select the row when the fin-selection-changed event is distributed. I hoped this event handling would select multiple rows, but perhaps it is causing a problem. Can you advise?

@cyrfer @joneit We will get back to you this week

@cyrfer Sorry for the delay. We are making a push to release this week. We will have time to look at your issue next week

@cyrfer This pr should address your concern with checkbox for multi-row selection

Regarding access to the full list of columns, as stated in the updated responses above, as of version 1.3, we now support grid.getColumns().
Regarding the "new problem," you need to also set grid.properties.singleRowSelectionMode to false (as stated in the updated responses above).
Jonathan

@cyrfer Thank you for your patience, and especially for your input. Your comments focused our attention of these issues and we have mades things easier in the next version. Please read carefully my updated comments on the issues page. Note that some of the comments refer to new functionality in version 1.3, to be released at the end of next week (1/20/2017). Jonathan

@Dwaynekj I suggest we leave this issue open until at least the release date. J.


Not reporting multiple ci-status'

 ⚓  ~/s/a/  khj/make-mechanic-deletion-on-cancel  git ci-status
success

Thanks for reporting! This is a duplicate of #943.


'Cannot read property 'toLowerCase' of undefined' during slot deployment

I am trying to deploy to a slot using the action. I am not using a publishing profile to deploy, but instead a service principal. Looking through the 'ParameterValidator.validateScmCredentialsSlotName' it looks like to do a slotted deployment you are requiring a profile? I am passing in a valid slot name that exists, so I am not sure why I would get this error. Help is appreciated.

Deploying to slot using service principal is not supported currently
Check this issue https://github.com/Azure/functions-action/issues/65

Could you please reconsider this? Not beeing able to do slot deployments using a service principal is a very frustrating.
In issue #65 you mentioned that

publish profile is more secure (limited priviledge)

but we can use granular RBAC assignments to control the permissions of the deployment service principal.
Also when deploying multiple apps (e.g. one webapp and one function app) we would need to track multiple publish profiles?
Using azure/webapps-deploy@v2 works perfectly fine when deploying to a deployment slot, so this seems like an arbitrary limitation.

Agree that would be nice to implement, missing that feature so much

Yes, would like to see this feature also.
An error message stating the above would have saved me time debugging too.

Yes, would like to see this feature also.
An error message stating the above would have saved me time debugging too.

Right... the error does not actually tell you the problem. Outside of being some arbitrary limitation.

It's disappointing, that this scenario is not supported and the error messages are currently very misleading (you basically have to check the code to understand what's going on) but there is a workaround:
You can use the<EMAIL_ADDRESS>action to deploy a webapp (including function apps) to a slot while using a service principal.
Here is an example:
      - name: Azure Login
        uses: Azure/login@v1
        with:
          creds: ${{ secrets.AZURE_CREDENTIALS }}

      - name: Deploy Functions
        uses<EMAIL_ADDRESS>        with:
          inlineScript: |
            az webapp deployment source config-zip --resource-group ${{ env.AZURE_RESOURCE_GROUP }} --name ${{ env.AZURE_FUNCTIONS_APPSERVICE }} --slot staging --src functions.zip

      - name: Swap Slots
        uses<EMAIL_ADDRESS>        with:
          inlineScript: |
            az webapp deployment slot swap --resource-group ${{ env.AZURE_RESOURCE_GROUP }} --name ${{ env.AZURE_FUNCTIONS_APPSERVICE }} --slot staging --target-slot production


Refactor readme docs and provide tutorial for public instance.

based on feedback from @rminnich , we will have a faster tutorial style introduction for osfci.tech

there is a work in progress page available into #Features accessible from the front page. It is not finished and clean , but that could be a good initial start to look at. Other option would be to put in place a walk through when the session open. That is doable with bootstrap and using popups.

@vejmarie good point -- I will refactor top title bar to change
" Features " to " Help "
" How to help " to " Contribute "
This will make it more clearer for more folks while we work on refactoring / refining the tutorial

based on discussion with @vejmarie and @susmithp , we have decided to:

provide dynamic tool-tip help that will be offered to user in real-time
help can be toggled via checkbox

This was deployed a while back !


/mobile-toolkit/aloremipsum: line 12: adb_paste: command not found

I believe I have platform-tools and mobile-toolkit in PATH. I've tried other commands such as apaste and abounds and they work

Oh yea thats my bad, gonna fix it right away

Okay, navigate to the cloned folder and use git pull then it should work, thanks for your cooperation :)

Thanks working well


TabIndex and Spreading Props

Expected result
I have a navigation bar with multiple links. Each link consists of text and an animated icon. When a user tabs inside the navigation, the only item that has to get focused is the link itself.
Actual result
The whole links gets focused on the first tab. The animated icon inside gets focused on second tab.
Ways to fix it:

Spread the incoming props to the component down to the inner div
Remove the tabIndex or make it a prop

I will be more than happy to submit a pull request, if you give me green light!
Thank you for the excellent work!

Anyone looking for a solved version of this problem or a typescript version of react-lottie here is a version:
https://gist.github.com/chrispcode/2c12af4e6a8c2cca242c64559cd3fb90


Add unit tests for RCGetInteriorVehicleDataConsent

#This PR is ready for review.
Risk
This PR makes no API changes.
Summary
This PR provides unit test coverage for RCGetInteriorVehicleDataConsent
CLA

[x] I have signed the CLA

@ValeriiMalkov Wrong base branch

@ValeriiMalkov Original branch was already merged into feature baseline.


[Bug]: Grpc.Core.RpcException: Status(StatusCode="PermissionDenied", Detail="Bad gRPC response. HTTP status code: 403")

Preflight Checklist

[x] I could not find a solution in the documentation, the existing issues or discussions
[x] I have joined the ZITADEL chat

Environment
Self-hosted
Version
v2.64.1
Database
PostgreSQL
Database Version
17
Describe the problem caused by this bug
Hi, I'm using Zitadel dotnet SDK to get a user, I used the PersonalAccessToken method as shown in the example, I gave the service user IAM Owner permission in the instance as well as Organization Owner in ZITADEL org and generated a new PAT, however, I always get this error when calling the Method: GetUserByIDAsync in UserService Grpc.Core.RpcException: Status(StatusCode="PermissionDenied", Detail="Bad gRPC response. HTTP status code: 403")
I injected the clients this way:
services.AddScoped(sp =>
{
    return Clients.AuthService(new(auhthorityUrl, ITokenProvider.Static(personalAccessToken)));
});

The issue also happens with JWT key
I'm on version v2.64.1
To reproduce
I created a service user and gave it role Org Owner in ZITADEL and also IAM Owner, I generated the PAT and tried using the Dotnet SDK methods, If I use the PAT in postman directly it works, when I use it with this Grpc client it doesn't.
Screenshots
No response
Expected behavior
No response
Operating System
No response
Relevant Configuration
No response
Additional Context
No response

For more context, I'm using Zitadel vie Nginx reverse proxy with external tls, here is my conf file:
server {
    listen 80;
    listen [::]:80;
    server_name domain.com;

    location / {
        grpc_pass grpc://<IP_ADDRESS>:6545;
        grpc_set_header Host $host;
    }

    listen 443 ssl; # managed by Certbot
    ssl_certificate /etc/letsencrypt/live/domain.com/fullchain.pem; # managed by Certbot
    ssl_certificate_key /etc/letsencrypt/live/domain.com/privkey.pem; # managed by Certbot
    include /etc/letsencrypt/options-ssl-nginx.conf; # managed by Certbot
    ssl_dhparam /etc/letsencrypt/ssl-dhparams.pem; # managed by Certbot

}
server {
    if ($host = domain.com) {
        return 301 https://$host$request_uri;
    } # managed by Certbot

    listen 80;

    server_name domain.com;

I found the solution, It was cloudflare that was blocking the grpc connection, I had to enable it in Network > enable Grpc, in cloudflare dashboard


[ENH] isolate soft dependencies

This PR isolates soft dependencies at runtime and test time as follows:

moving imports into functions and classes
tests requiring soft dependences are only run when required soft dependencies are installed
in some tests, classes that require soft dependencies are replaced by equivalents (for test purpose) without soft dependencies

This is a continuation of PR https://github.com/alan-turing-institute/sktime/pull/2985 for custom/manual tests, with the aim to isolate all instances of soft dependency imports in the above way.

Ready for review now - all soft dependencies are isolated, as #2986 shows.


Appstudio update hacbs-test-project-pplh

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-pplh-on-pull-request-
creating pipelinerun hacbs-test-project-pplh-on-pull-request- in namespace rhtap-demo-evaw-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-pplh-on-pull-request-
creating pipelinerun hacbs-test-project-pplh-on-pull-request- in namespace rhtap-demo-yqzg-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


[RenderPixi] Can't pass options for PIXI.WebGLRenderer

In case of working with high density displays like retina, we have to pass the "resolution" (and optionally "autoResize") option to PIXI.WebGLRenderer. But it seems we don't have ways to pass it, or any other option values described in PIXI's document.
https://github.com/liabru/matter-js/blob/master/src/render/RenderPixi.js#L53-L58
I think there should be all option parameters filled with default values and we should be able to overwrite them by passing a "options" argument for RenderPixi.create().
Thanks!

You can now pass pixiOptions in your RenderPixi.create options (you could also pass a PIXI.WebGLRenderer instance as the option as renderer instead).

@liabru Cool!! Thanks for the fix!


[Endpoints] Update Endpoints + Guice sample

Review of sample provided by @tangiel.

Moved all but Guice filters to configureServlets() from web.xml.
Added additional commentary on why /_ah/api/* is used instead of /*.

Thank you!


Reindexing an exhibit temporarily drops the item count

For example, I just started a reindex of SAE on staging. before starting it had 1194 items. Shortly after reindexing it had dropped down to 290 and then a bit later to 25.

The indexing routine does purposefully remove some records from solr but only under certain conditions (e.g. the resource shouldn't be visible any longer). It should not be clearing out the whole collection.

The persisted member has the token on it and the manifest member does not. so they're all getting removed.
irb(main):009:0> members.first
=> "https://figgy.princeton.edu/concern/scanned_resources/eefe4a6e-729e-4fc1-ada1-41fe0a6fd34b/manifest"
irb(main):010:0> persisted_members.first.url
=> "https://figgy.princeton.edu/concern/scanned_resources/fbc2d7b3-164b-4458-b2c3-9007c2ed08a5/manifest?auth_token=36af893b93fdea9cd3a3a441afa38ac8"

https://github.com/pulibrary/dpul/blob/c594a896e043e7e2ad77ddd336176149ef65baac/app/models/exhibit_proxy.rb#L41-L44


[Snyk] Security upgrade mocha from 10.0.0 to 10.1.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

589/1000  Why? Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-MOCHA-2863123
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: mocha
    The new version differs by 8 commits.

5f96d51 build(v10.1.0): release
ed74f16 build(v10.1.0): update CHANGELOG
51d4746 chore(devDeps): update 'ESLint' to v8 (#4926)
4e06a6f fix(browser): increase contrast for replay buttons (#4912)
41567df Support prefers-color-scheme: dark (#4896)
61b4b92 fix the regular expression for function `clean` in `utils.js` (#4770)
77c18d2 chore: use standard 'Promise.allSettled' instead of polyfill (#4905)
84b2f84 chore(ci): upgrade GH actions to latest versions (#4899)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

Coverage remained the same at 90.909% when pulling 301dff607d2c7932d952e999f10fd8721ae0186e on snyk-fix-cda747f15df555e208fcc8417f5b71a6 into 97055fec0782091235da5ce942adc73feb23ef43 on main.


feat: implement ErrorHandler & LoopWrapper & RowButtons, improve KeyboardSetYAML, fix: ServerConnectionError, docs: Option monad

closes #40

Is it finished now?

Is it finished now?

yeah. you can do a merge

Thanks for PR! I added some minor comments, as we resolve them I'll be able to merge up these thingies

Thanks for PR! I added some minor comments, as we resolve them I'll be able to merge up these thingies

It was nothing ^_^
I've resolved the problems you mentioned in the comments!


Node_exporter is not running with fresh install on Debian 9

I used this role to install and run node_exporter on a fresh new VM, everything is installed but the service does not run by default.
Setup
ansible 2.7.7
cloudalchemy.node-exporter 0.12.0
Operating System Debian 9
What it does
It install the node-exporter, the service and all of what is needed for it to run BUT does not start the service.
What it should do
Install everything and start the service.
Step to reproduce
Build a fresh instance of Debian 9 and run the playbook with default values on it.

I assume this issue can be closed since #72 was merged.


Update deploy-wdac-policies-with-script.md

Removed a stipulation which implies that signed WDAC policies have to be placed within System32 and EFI locations.  In some cases they should ONLY be placed in the EFI partition. (NOT the System32 location.) This updated wording matches the real behavior of the CiTool (when using CiTool --update-policies to deploy a new signed policy).
Additionally, for devices without the CiTool, (e.g. running Windows 10), you can put signed policies in the EFI partition and not the System32 folder with 0 consequence (correct me if I'm wrong on this.)
Additionally, I haven't put this in the pull request, but the wording of the article should be updated in the section "Deploying policies for Windows 11 22H2 and above" to state that a signed WDAC policy should not be placed in both locations (as this will cause a blue-screen! We've verified this on at least 4 different models of Dell running Windows 11.)
The reason this should be put in is there is an implied wording of the article that one can use either the CiTool on 22H2 devices and above (i.e., "You can use the inbox CiTool to apply policies on Windows 11 22H2") or copy it to both locations -- which is not true, so the wording will have to be updated either way.
Description
Removed the "in addition to [previous] locations..." so that it wouldn't imply that you always have to place a signed policy in the System32 location.
Why
The proposed changes bring this article in-line with the behavior of Microsoft's CiTool.
Changes
Clarifies wording of where signed WDAC policies should be placed (when copying signed policies.)

@jgeurten is there any further edit needed on this contribution or good to accept? See Jeffrey's review comments.

I've implemented the changes and resolved the merge conflict in a PR in the private repo. The changes will be live later today. Closing this PR.


Add usage-based threshold pull functionality

Replace untranslated string formatting with usage-based formatting.

I guess this didn't get merged, and is not needed anymore


Known issues link gets 404 Error

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
Go to https://github.com/SharePoint/sp-dev-docs/wiki/Why-SPFx, click on the right menu on "Known issues". This should show a list of "Known issues"
Observed Behavior
I got an 404 page at https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/basics/known-issues
Steps to Reproduce
See above

Wiki also updated to point to pages in https://docs.microsoft.com/en-us/sharepoint/dev. Thx for the issue reporting.


Problem when creating sveltekit project

Describe the bug
Whenever i try to create a sveltekit project with pnpm create vite and use pnpm install and then start the dev server with pnpm run dev it gives me these errors: SvelteKitError: Not found: /workbox-c676b6d3.js,  SvelteKitError: Not found: /dev-sw.js and SvelteKitError: Not found: /@vite-plugin-pwa/pwa-entry-point-loaded
Reproduction
use pnpm create vite and install the packages with pnpm install. Then run the project by using pnpm run dev. it gives me the errors
Logs
"Handling window message"
"Bad source or badly formatted message, skipping."

System Info
System:
    OS: Windows 11 10.0.22621
    CPU: (16) x64 AMD Ryzen 7 7730U with Radeon Graphics
    Memory: 3.39 GB / 15.36 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    pnpm: 8.14.3 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Edge: Spartan (44.22621.1702.0)

Severity
blocking all usage of SvelteKit
Additional Information
No response

Why are you using pnpm create vite? That's not a package that's under our control, and there's nothing we can do about how that behaves.

Using pnpm create vite and selecting the svelte then SvelteKit option, I believe it ends up using create-svelte. However, I wasn't able to reproduce the issue. Please specify the exact CLI options you have selected.

have you try this command:
npm create svelte@latest my-app
cd my-app
npm install
npm run dev -- --open

I haven't had a chance to try out if it's a me problem or a problem with sveltekit dropping support for pnpm, but in the past pnpm worked with sveltekit and I loved it. Not only bc it makes it a lot faster to install but also cuz it saves disk space. I feel like many devs would agree with me that not being able to use pnpm is a big deal breaker

Oops accidentally closed it

I haven't had a chance to try out if it's a me problem or a problem with sveltekit dropping support for pnpm, but in the past pnpm worked with sveltekit and I loved it. Not only bc it makes it a lot faster to install but also cuz it saves disk space. I feel like many devs would agree with me that not being able to use pn

Using pnpm create vite and selecting the svelte then SvelteKit option, I believe it ends up using create-svelte. However, I wasn't able to reproduce the issue. Please specify the exact CLI options you have selected.

I used the vite cli with pnpm then I selected svelte and sveltekit with the demo starter app template with typescript, eslint and prettier. The issue persistedin different directories and when not using eslintand prettier. My pnpm version is 8.14 and I'm using the newest version of create-vite

Using pnpm create vite and selecting the svelte then SvelteKit option, I believe it ends up using create-svelte. However, I wasn't able to reproduce the issue. Please specify the exact CLI options you have selected.

If you haven't been able to replicate the issue with pnpm than it might be some problem on my device but idk


[Snyk] Security upgrade @mapbox/rehype-prism from 0.8.0 to 0.9.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-ANSIREGEX-1583908
No
Proof of Concept

484/1000  Why? Has a fix available, CVSS 5.4
Open Redirect SNYK-JS-GOT-2932019
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: @mapbox/rehype-prism
    The new version differs by 5 commits.

6c19410 0.9.0
f2a335f prepare v0.9.0
4806b23 update dependencies
a0a7d5d Merge pull request #36 from mapbox/dependabot/npm_and_yarn/minimist-1.2.6
f197083 Bump minimist from 1.2.5 to 1.2.6

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Open Redirect

👷 Deploy Preview for remarkable-meerkat-3bf7d4 processing.

Name
Link

🔨 Latest commit
26ce43fb98e06d412a9df5d007cf7fef17d1ecda

🔍 Latest deploy log
https://app.netlify.com/sites/remarkable-meerkat-3bf7d4/deploys/65620e0019bcd90008c5a393


adding POPBLOG to blog.

What type of PR is this?
Blog -  this is to highlight pops new role
/hold

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Signed-off-by:  danpopsd<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign lucperkins after the PR has been reviewed.
You can assign the PR to them by writing /assign @lucperkins in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

fad4fa4 Create pop-joins-falco .md
c8e22fd Update pop-joins-falco .md
3ada26f Update pop-joins-falco .md
31f0aee Update pop-joins-falco .md
43e1fc8 Update pop-joins-falco .md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

broken images in the commit and DCO issues.


Add tests to check rate limiter hit for TOTP

Adding tests to heck that the rate limiter hit() is called for invalid TOTP scenarios.
Closes #6069

Thanks! And +1 for the Mountain Goats reference 😉

Sweet! Thanks!


operationOptions - DisableAsyncPattern

Hi!
According to the documentation, if you set the option "operationOptions": "DisableAsyncPattern" in an action, you get synchronous call. But when I'm using it in a action calling another logic apps, it seems that the request will reply immedidate with HTTP 202 Accepted without waiting on response from the called logic apps at all. DisableAsyncPattern seems to only mean that "we do not wait at all". Look like this is also stated on this page:
https://social.msdn.microsoft.com/Forums/en-US/ad931904-cf4b-4017-a3dd-b806e288c11a/to-trigger-a-logic-app-from-a-logic-app-is-there-a-no-wait-http-call?forum=azurelogicapps
Removing this flag is the only option to get any answer/response back from called logic app with response action.
Regards
Olve Slind
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a0dd3aa-82c2-4510-1413-a109eddf6303
Version Independent ID: 21f0f699-9267-821f-07aa-998f7dfc32f2
Content: Schema reference for trigger and action types - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-workflow-actions-triggers.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@olveslind , thank you for your feedback. We'll review this and get back to you shortly!

@olveslind Could you check if you have one of the following configurations in the logic app that is being called?

Asynchronous Response

Split On (When you have an array in your payload and is defined in the schema for POST/PUT triggers)

If you have either of the above, you would get a 202 immediately.

Hi!
Thank you for your reply!
I have tried different configurations, but "Asynchronous Response" is set
to "Off" like here since I do not want asynchronous behaviour, but
synchronous call/response.
But a response of 202 immediately is not what I expected from synchronous
behaviour that the documentation explains.
It is more like "fire and forget" . The Asynch "On" behaviour here seems to
be more like "wait" on async operations in c#.
(If Async setting is turned off in client: property operationOptions":
"DisableAsyncPattern")
My problem is that I do not understand this behavior based on the
documentation and the name of the properties.
What is default behaviour also seems to have changed during the lifespan of
Logic Apps according to blogs: previously synchronous was default, now it
is asynch.
Regards,
Olve Slind
ons. 30. jun. 2021 kl. 15:45 skrev Pramod Valavala @.***

:

@olveslind https://github.com/olveslind Could you check if you have one
of the following configurations in the logic app that is being called?

Asynchronous Response
[image: image]
https://user-images.githubusercontent.com/43602528/123970352-ad615d00-d9d6-11eb-9d34-18c225657de7.png
2.
Split On (When you have an array in your payload and is defined in
the schema for POST/PUT triggers)
[image: image]
https://user-images.githubusercontent.com/43602528/123971188-72135e00-d9d7-11eb-9ce0-6b8f562d4656.png
If you have either of the above, you would get a 202 immediately.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/77586#issuecomment-871418159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXVVLSEWSXPIW3UBDU755DTVMNX7ANCNFSM47PPRFEQ
.

@olveslind The DisableAsyncPattern has different implications when used on either end I suppose.
On the response action, if its ON, it would immediately send a 202.
On the request action (logic app action), if its ON, it would skip waiting on the 202 (which is the default).
So, for a synchronous-like behavior, it would be best to always have it enabled on the calling action. This way, even if the child logic app responds with a 202 (either because of async response is ON or if splitOn is used as mentioned in my previous comment), the parent logic app would wait (similar to how async works in C#).
The default is asynchronous because it helps to ensure actions succeed even if the child logic app takes longer than the timeout of the underlying connection. Note that if the child logic app is fast, the underlying logic apps runtime will respond immediately too. Only in the case when it takes too long will the child logic app send a 202 for the caller to poll. (Unless if Async Response is enabled, which makes it return 202 immediately).
Hope that helps 😄

Hi!
Thank you very much for a good explanation and answer! This helps a lot for
me to understand the logic:-)
Regards,
Olve Slind
tir. 6. jul. 2021 kl. 07:27 skrev Pramod Valavala @.***

:

@olveslind https://github.com/olveslind The DisableAsyncPattern has
different implications when used on either end I suppose.
On the response action, if its ON, it would immediately send a 202.
On the request action (logic app action), if its ON, it would skip waiting
on the 202 (which is the default).
So, for a synchronous-like behavior, it would be best to always have it
enabled on the calling action. This way, even if the child logic app
responds with a 202 (either because of async response is ON or if splitOn
is used as mentioned in my previous comment), the parent logic app would
wait (similar to how async works in C#).
The default is asynchronous because it helps to ensure actions succeed
even if the child logic app takes longer than the timeout of the underlying
connection. Note that if the child logic app is fast, the underlying logic
apps runtime will respond immediately too. Only in the case when it takes
too long will the child logic app send a 202 for the caller to poll.
(Unless if Async Response is enabled, which makes it return 202
immediately).
Hope that helps 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/77586#issuecomment-874470931,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXVVLXZAJRWIPJWUOU3QZ3TWKH43ANCNFSM47PPRFEQ
.

@olveslind Glad we could help!
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Added ability to check for focus gain.

Functionality analogous to already implemented blur.

In my opinion this PR is unsplittable. Order change is necessary for focus to work. I tried to describe it in commit message. In case we leave it without change, focus event will not be fired because selection is changed before we started to listen.


[ambient] Fix some unit test flakes for ambient informer

Please provide a description of this PR:
After a recent PR flakes like https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/1866952380273135616 showed up, which are reproducible (eventually) with stress.
This is because some of these tests aren't waiting for the correct number of events before proceeding.
This PR

tightens up the event counting the unit tests use to keep things deterministic (actual cause of the flakes)
puts explicit invocation counts on all mocks (these are good, the only reason the flake manifested in the first place in the one test they're used)

A 20 min stress run of the affected tests here seemed good enough to validate, given how it wasn't hard to repro.

@bleggett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a14b90aee2fdad6145f8201a7570cfa2c075b71e
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.