Test 123

Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ping

ping

ping

ping

ping

ping

dummy comment

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

/run-e2e help

Valid command format for /run-e2e is
: /run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2e help

Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/hello

/hello

/hello

Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/hello

Valid Commands supported by this repo:
Valid Commands supported by this repo:

/hello

Valid Commands supported by this repo:

/hello

Valid Commands supported by this repo:

/hello

Valid Commands supported by this repo:

/hello

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17
Command: /run-e2e-dummy
Valid command format for /run-e2e-dummy is:
/run-e2e-dummy K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/wrong

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17
Command: /run-e2e-dummy
Valid command format for /run-e2e-dummy is:
/run-e2e-dummy K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2e help

Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2e help

Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2e help

Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2e

@bo

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

/run-e2e

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e 1.22.6 kvm rockylinux-8

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//help

//help

//help

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e K8S_VERSION HYPERVISOR OS ACS_VERSION
Following are supported values for each parameters:
K8S_VERSION: 1.22.6,1.23.3
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.14,4.16,4.17

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e [K8S_VERSION] [HYPERVISOR] [OS] [ACS_VERSION]

Following are supported values for each parameters:
K8S_VERSION: 1.23.3,1.22.6
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.16,4.14,4.17

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e [K8S_VERSION] [HYPERVISOR] [OS] [ACS_VERSION]

Following are supported values for each parameters:
K8S_VERSION: 1.23.3,1.22.6
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.16,4.14,4.17

//help

//help

Valid Commands supported by this repo:
Command: //run-e2e
Valid command format for //run-e2e is:
//run-e2e [K8S_VERSION] [HYPERVISOR] [OS] [ACS_VERSION]

Following are supported values for each parameters:
K8S_VERSION: 1.23.3,1.22.6
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.16,4.14,4.17

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-59.zip.zip
Test Result: [1m[32mRan 2 of 2 Specs in 1412.905 seconds[0m
[1m[32mSUCCESS![0m -- [32m[1m2 Passed[0m | [91m[1m0 Failed[0m | [33m[1m0 Pending[0m | [36m[1m0 Skipped[0m
PASS

//run-e2e

Jenkins job created for running //run-e2e, will keep you posted when the result is ready

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

//run-e2e

Jenkins job created for running //run-e2e, will keep you posted when the result is ready

Failed to successfully run e2e test on PR 2

//run-e2e

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-73.zip.zip
Test Result: Ran 2 of 2 Specs in 1094.235 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

//run-e2e

Jenkins job created for running //run-e2e, will keep you posted when the result is ready

//run-e2e

//run-e2e

//run-e2e

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-74.zip.zip
Test Result: Ran 2 of 2 Specs in 1070.964 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

//run-e2e

//run-e2e

Jenkins job created for running //run-e2e, will keep you posted when the result is ready

//run-e2e

Jenkins job created for running //run-e2e, will keep you posted when the result is ready

//run-e2e

//run-e2e

//run-e2e

Failed to successfully run e2e test on PR 2

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-76.zip.zip
Test Result: Ran 2 of 2 Specs in 1090.800 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

//run-e2e

//run-e2e

//run-e2e

/assign

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/lgtm

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e [K8S_VERSION] [HYPERVISOR] [OS] [ACS_VERSION]

Following are supported values for each parameters:
K8S_VERSION: 1.23.3,1.22.6
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.16,4.14,4.17

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to successfully run e2e test on PR 2

Failed to successfully run e2e test on PR 2

/run-e2e

Failed to start Jenkins job for /run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Valid Commands supported by this repo:
Command: /run-e2e
Valid command format for /run-e2e is:
/run-e2e [K8S_VERSION] [HYPERVISOR] [OS] [ACS_VERSION]

Following are supported values for each parameters:
K8S_VERSION: 1.23.3,1.22.6
HYPERVISOR: kvm,xen,vmware
OS: ubuntu-2004,rockylinux-8
ACS_VERSION: 4.16,4.14,4.17

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to create job to execute: /run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to create job to execute: /run-e2e

/run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to create job to execute: /run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to create job to execute: /run-e2e

/run-e2e

Failed to create job to execute: /run-e2e

Failed to start Jenkins job for /run-e2e

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

Failed to successfully run e2e test on PR 2

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

Failed to successfully run e2e test on PR 2

/run-e2e

Failed to successfully run e2e test on PR 2

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-84.zip.zip
Test Result: github.com/onsi/ginkgo.runSpecsWithCustomReporters({0x26df8a0, 0xc0002436c0}, {0x23fb629, 0x8}, {0xc000160540, 0x2, 0x241a63d})
/root/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:245 +0x185
github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters({0x26df8a0, 0xc0002436c0}, {0x23fb629, 0x8}, {0xc00008bf50, 0x1, 0x1})
/root/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:228 +0x1be
sigs.k8s.io/cluster-api-provider-cloudstack-staging/test/e2e.TestE2E(0x0)
/jenkins/workspace/capc-builder@2/test/e2e/e2e_suite_test.go:97 +0x10a
testing.tRunner(0xc0002436c0, 0x24ed508)
/usr/local/go/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1306 +0x35a
STEP: Dumping logs from the bootstrap cluster
STEP: Tearing down the management cluster
JUnit report was created<EMAIL_ADDRESS>Ran 2 of 0 Specs in 607.376 seconds
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (607.38s)
FAIL

/run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to create job to execute: /run-e2e

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-85.zip.zip
Test Result: Ran 2 of 2 Specs in 1106.724 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

/run-e2e

/run-e2e

Failed to start Jenkins job for /run-e2e

Failed to create job to execute: /run-e2e

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-86.zip.zip
Test Result: Ran 2 of 2 Specs in 1055.589 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

/run-e2e

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-87.zip.zip
Test Result: github.com/onsi/ginkgo.runSpecsWithCustomReporters({0x26df8a0, 0xc0000ce000}, {0x23fb629, 0x8}, {0xc0005221e0, 0x2, 0x241a63d})
/root/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:245 +0x185
github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters({0x26df8a0, 0xc0000ce000}, {0x23fb629, 0x8}, {0xc00008bf50, 0x1, 0x1})
/root/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:228 +0x1be
sigs.k8s.io/cluster-api-provider-cloudstack-staging/test/e2e.TestE2E(0x0)
/jenkins/workspace/capc-builder/test/e2e/e2e_suite_test.go:97 +0x10a
testing.tRunner(0xc0000ce000, 0x24ed508)
/usr/local/go/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1306 +0x35a
STEP: Dumping logs from the bootstrap cluster
STEP: Tearing down the management cluster
JUnit report was created: /jenkins/workspace/capc-builder/_artifacts/junit.e2e_suite.1.xml
Ran 2 of 0 Specs in 608.201 seconds
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (608.20s)
FAIL

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-89.zip.zip
Test Result: github.com/onsi/ginkgo.runSpecsWithCustomReporters({0x26df8a0, 0xc000504d00}, {0x23fb629, 0x8}, {0xc0003a21e0, 0x2, 0x241a63d})
/root/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:245 +0x185
github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters({0x26df8a0, 0xc000504d00}, {0x23fb629, 0x8}, {0xc00008bf50, 0x1, 0x1})
/root/go/pkg/mod/github.com/onsi/ginkgo@v1.16.5/ginkgo_dsl.go:228 +0x1be
sigs.k8s.io/cluster-api-provider-cloudstack-staging/test/e2e.TestE2E(0x0)
/jenkins/workspace/capc-builder@2/test/e2e/e2e_suite_test.go:97 +0x10a
testing.tRunner(0xc000504d00, 0x24ed508)
/usr/local/go/src/testing/testing.go:1259 +0x102
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1306 +0x35a
STEP: Dumping logs from the bootstrap cluster
STEP: Tearing down the management cluster
JUnit report was created<EMAIL_ADDRESS>Ran 2 of 0 Specs in 608.905 seconds
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (608.91s)
FAIL

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-88.zip.zip
Test Result: Ran 2 of 2 Specs in 1041.456 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e 1.22.6 kvm rockylinux-8 4.16

/run-e2e 1.22.6 kvm rockylinux-8 4.16

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e 1.22.6 kvm rockylinux-8 4.16

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e 1.22.6 kvm rockylinux-8 4.16

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e 1.22.6 kvm rockylinux-8 4.16

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

/run-e2e

Jenkins job created for running /run-e2e, will keep you posted when the result is ready

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-98.zip.zip
Test Result: Ran 2 of 0 Specs in 609.732 seconds
FAIL! -- 0 Passed | 2 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (609.73s)
FAIL

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-99.zip.zip
Test Result: Ran 2 of 2 Specs in 1131.597 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-100.zip.zip
Test Result: Ran 2 of 2 Specs in 1127.349 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-102.zip
Test Result: Summarizing 3 Failures:
[Fail] When testing subdomain [It] Should create a cluster in a subdomain
/root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.1.0/framework/cluster_helpers.go:134
[Fail] When the specified resource does not exist [It] Should fail due to the compute resources are not sufficient for the specified offering [TC8]
/jenkins/workspace/capc-builder/test/e2e/invalid_resource.go:154
[Fail] When testing machine remediation [It] Should replace a machine when it is destroyed
/root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.1.0/framework/controlplane_helpers.go:110
Ran 22 of 23 Specs in 10927.753 seconds
FAIL! -- 19 Passed | 3 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (10927.76s)
FAIL

Failed to successfully run e2e test on PR 2: Job was aborted. Please rekick the test

Failed to successfully run e2e test on PR 2: Job was aborted. Please rekick the test


Create Creating Hex Codes.js

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix

Why was this change needed? (You can also link to an open issue here)  Hex codes generated

Other information:

i closed this


🐛 Auth - Unable to log into app after it closes / Unable to register

To: @jakebaylissssw
cc: @adamcogan , @matt-goldman ,@AndreasLengkeek, @ozdemir-mehmet, @wicksipedia, @nvhoanganh, @brydeno
Expected Behavior

I should be able to log into the app multiple times.
Current Behavior

I can only log into the app once. After that, once it has closed, I just see the red spinner on the login screen. I need to delete the app then re-install it, in order to log in again.
Possible Solution

This could be related to MSAL configuration (see https://github.com/SSWConsulting/SSW.Rewards/pull/125) but could also be to do with KeyChain configuration if the app bundle was modified.
Steps to Reproduce

Install the app on iOS.
Log in.
Close the app (NOTE: swiping up doesn't always reproduce the issue, but restarting the device does).
Attempt to log in again.

AB#57970

The issue seems to have affected the signup process and new users are unable to create accounts

@AndreasLengkeek As a new user, I have managed to register for an account in one go.
Also, I am not able to reproduce the current behaviour of the red spinner on the login screen. Instead, I have the app crashed in splash screen.
Steps to Reproduce:

Install the app on iOS.
Log in.
Close the app by restarting the physical device.
Attempt to open the app.
App crashed in splash screen (able to open the app and logs in after 5~6 continuous tries or 10 seconds)

*Note the tests were all done on iPhone 6s Plus.

Hi @jianganna7,
I checked with @jernejk, who tested logging in on his Android.
He is still having the auth infinite loading issue.

If it helps, I also tried Windows Subsystem for Android (Windows 11) and it worked.

In case you don't have an Android but have Windows 11, this might help you debug things.
https://jkdev.me/use-windows-subsystem-for-android-in-windows-11/

If it helps, I also tried Windows Subsystem for Android (Windows 11) and it worked.

Cool - that's good to know and thanks for helping out!

I checked with @jernejk, who tested logging in on his Android. He is still having the auth infinite loading issue.

Thanks for checking @JackDevAU 🥇 Ah yep I think that's because PR #176 still hasn't been merged yet.
BTW Did @jernejk reinstall the app for the last test, and was the internet stable when the error occurred?
If needs to, we might ask @jernejk to test from fix/infinite-loading on his Android to see if it fixes the infinite loading issue from his end?

Ah yep I think that's because PR https://github.com/SSWConsulting/SSW.Rewards/pull/176 still hasn't been merged yet.

Yep, once this is merged it should hopefully fix the issue.

BTW Did @jernejk reinstall the app for the last test, and was the internet stable when the error occurred?

No, he already had the app installed.
Yea, once we merge the fix. Let's get JK to test it again 🙂

As per our conversation, we are also moving away from b2c to Identity.
Until this is fully implemented, we have provided a temporary fix, https://github.com/SSWConsulting/SSW.Rewards/pull/216

As per our conversation, we are also moving away from b2c to Identity. Until this is fully implemented, we have provided a temporary fix, #216
Please see the Identity issue here: #204

**Figure: test pass from the product owner **


dialog.about.errorWhileLookingForUpdates error when checking for updates

My Setup

Operating System: Windows 10 version 1909 10.0.18363.657
App Version: 2.17.7
Installation type: .exe

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
Go to help menu => about rocket.chat => press blue button 'check for updates'
Current Behavior
Update check fails with message dialog.about.errorWhileLookingForUpdates

Expected Behavior
Update check should begin download and installation of newer version if available, or report that application is already the latest version.

Just noticed this is a duplicate of https://github.com/RocketChat/Rocket.Chat.Electron/issues/1500, sorry!


Add plotly

I got a ModuleNotFoundError: No module named 'plotly' error when first running pip install, this fixes it.

Ah, sorry! That was caused by an unneeded import in experiments.py, I've deleted that line in my latest push to main. Do you still get this issue? Closing this pull request for now - I don't currently think the library should rely on Plotly (but I may add this in future)

I don't get the issue anymore, thanks


gem install error: Undefined symbols for architecture arm64

What version of gRPC and what language are you using?
grpc: 1.56.0
language: ruby 3.2.2
What operating system (Linux, Windows,...) and version?
macOS 13.4
Apple M1 chip
What runtime / compiler are you using (e.g. python version or version of gcc)
Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)
What did you do?
gem install grpc -v 1.56.0
What did you expect to see?
Gem successfully installed.
What did you see instead?
`
40 warnings generated.
compiling rb_enable_cpp.cc
linking shared-object grpc/grpc_c.bundle
Undefined symbols for architecture arm64:
"_CFRelease", referenced from:
absl::lts_20230125::time_internal::cctz::local_time_zone() in libgrpc.a(time_zone_lookup.o)
"_CFStringGetCString", referenced from:
absl::lts_20230125::time_internal::cctz::local_time_zone() in libgrpc.a(time_zone_lookup.o)
"_CFStringGetLength", referenced from:
absl::lts_20230125::time_internal::cctz::local_time_zone() in libgrpc.a(time_zone_lookup.o)
"_CFStringGetMaximumSizeForEncoding", referenced from:
absl::lts_20230125::time_internal::cctz::local_time_zone() in libgrpc.a(time_zone_lookup.o)
"_CFTimeZoneCopyDefault", referenced from:
absl::lts_20230125::time_internal::cctz::local_time_zone() in libgrpc.a(time_zone_lookup.o)
"_CFTimeZoneGetName", referenced from:
absl::lts_20230125::time_internal::cctz::local_time_zone() in libgrpc.a(time_zone_lookup.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [grpc_c.bundle] Error 1
make failed, exit code 2
`

I am encountering this issue as well. The error seems like the CoreFoundation framework is not being linked in somehow?

I was able to work around the issue with bundle config build.grpc --with-ldflags="-Wl,-undefined,dynamic_lookup".

See this issue as well; moved past it with similar steps to @tdyas. Running with:
grpc: 1.56.0
ruby 3.2.2
macOs 12.6.6 (21G646)
Apple M1 Pro

I was able to work around the issue with bundle config build.grpc --with-ldflags="-Wl,-undefined,dynamic_lookup".

Solved my issue as well, thank you very much @tdyas

This problem may not be limited to arm64-darwin. I had another person on my team run into this on x86-darwin, though using the precompiled gem is a workaround for now.


moving broker and examples directories

under the new contrib directory
Fixes https://github.com/kubernetes-incubator/service-catalog/issues/51

I suspect that this change won't build successfully as-is. The top-level Makefile will need to be updated (https://github.com/kubernetes-incubator/service-catalog/blob/master/Makefile#L20) and the makefiles which were moved will need update of the relative paths in the include clauses (https://github.com/kubernetes-incubator/service-catalog/blob/master/broker/k8s/Makefile#L19)

@martinmaly

I suspect that this change won't build successfully as-is. The top-level Makefile will need to be updated (https://github.com/kubernetes-incubator/service-catalog/blob/master/Makefile#L20) and the makefiles which were moved will need update of the relative paths in the include clauses (https://github.com/kubernetes-incubator/service-catalog/blob/master/broker/k8s/Makefile#L19)

We should keep the build working, but the current arrangement with the build is not optimal.  We should not need a Makefile in each package.  I will open another issue for that.

+1 on a single makefile. thoughts on merging this and then cleaning up the build and makefile situation immediately thereafter?
cc/ @martinmaly @pmorie

LGTM

I don't have issue with temporarily breaking build to separate pure move from edits and shortening the window where racing commits cause painful rebases. I'd support merging this right away and recovering right thereafter.
you'll need the CLA though regardless.

+1 on a single makefile. thoughts on merging this and then cleaning up the build and makefile situation immediately thereafter?

SGTM.  I would like to track closely against what Kubernetes does in this area, but a single Makefile that 'just works' is good for now.  Some work needs to be done to consume the upstream build infrastructure.

LGTM

LGTM

Note that I have signed the CLA, but the bot doesn't recognize that fact at the moment. https://github.com/kubernetes/test-infra/issues/1130 is tracking the fix(es) to this issue.


can't navigate back after calling login

could there be an option to change this to href = instead of replace ?
I am using autoLogin: false in my config, and navigating to the login on a button click. I'd like to be able to navigate back using browser back button after opening login page.
https://github.com/soofstad/react-oauth2-pkce/blob/8acce0fd8eca03d95aeba5f6dc5b9b4e28c813f1/src/authentication.ts#LL40C24-L40C24

I don't see any security-reason why this wouldn't be alright, and after testing quickly, it feels better to be able to hit the back-button on my mouse to go back to before the login. I'll make a PR.

The preferred behaviour is not obvious here. What should happen if the auth server has cookies stored, and the login happens instantly? Would seem weird for the user to navigate back to a login page then.


Add License dropdown

This is the license field task - create a dropdown with the licenses from this list.
I added a license dropdown in both workflow and collection.
This is what it looks like after adding a dropdown.

Added some comments in this issue - https://github.com/NASA-IMPACT/stac-admin/issues/5


Delay with sending messages to our users

We sent a message to 45,000 users and it took 40 minutes to send. Is this normal or is there a way to reduce the time spent sending the message?

Good morning,
Is there any update on this?

@Scheiderichv094 The time taken is as expected according to the current design. We are actively working on improving efficiency. It's worth noting that once you send the messages, they will be sent in the background, allowing you to navigate to other pages within Teams.

Is there an estimated time frame for when it will be improved and what the time duration would be once a message is sent?

Is there an update to my recent message?

@Scheiderichv094 ,
We will check internally and will get back to you with proper response.

Thanks for the patience. It is taken into consideration already and is planned to release in the future releases of CC.

Do you have a timeline and details for the next release?

Please let us know if you have any queries otherwise we can make it to closure.


[HUDI-5928] Fixing graceful shut down of deltastreamer with post write termination strategy

Change Logs
Looks like table services are not propoerly shut down when post write termination kicks in. This patch fixes the flow, where in regular ingestion and any table services are shutdown properly when post write termination is enabled and condition is met.
Impact
Improves the usability of post write termination strategy for deltastreamer in continuous mode.
Test:
Also tested w/ a manual deltastremaer execution. w/o the fix, spark job just hangs, and w/ the fix, it shutsdown gracefully.
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Hi @nsivabalan I'm using this patch for single table DeltaStreamer and still not getting my spark job to shut down. It seems to work if the entire job doesn't have any data to pick up, such as running a test where there is NoNewData from the beginning. But if the job has processed any messages and then reaches NoNewData, it still hangs after it's finished. Logs at the end (Spark job still hanging after this prints):
23/03/14 16:57:52 INFO org.apache.hudi.utilities.sources.debezium.DebeziumSource: About to read 0 from Kafka for topic :identity.public.user_email_communications
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.DeltaSync: No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=(Option{val=identity.public.user_email_communications,0:389782}). New Checkpoint=(identity.public.user_email_communications,0:389782)
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.NoNewDataTerminationStrategy: Shutting down on continuous mode as there is no new data for 5
23/03/14 16:57:52 WARN org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer: Closing and shutting down ingestion service
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer: Ingestion completed. Has error: false
23/03/14 16:57:52 INFO org.apache.hudi.client.transaction.lock.InProcessLockProvider: Base Path s3a://<redacted>/public_user_email_communications/, Lock Instance java.util.concurrent.locks.ReentrantReadWriteLock@2dfe2370[Write locks = 0, Read locks = 0], Thread pool-31-thread-1, In-process lock state ALREADY_RELEASED
23/03/14 16:57:52 INFO org.apache.hudi.client.transaction.lock.LockManager: Released connection created for acquiring lock
23/03/14 16:57:52 INFO org.apache.hudi.client.transaction.TransactionManager: Transaction manager closed
23/03/14 16:57:52 INFO org.apache.hudi.client.BaseHoodieClient: Stopping Timeline service !!
23/03/14 16:57:52 INFO org.apache.hudi.client.embedded.EmbeddedTimelineService: Closing Timeline server
23/03/14 16:57:52 INFO org.apache.hudi.timeline.service.TimelineService: Closing Timeline Service
23/03/14 16:57:52 INFO io.javalin.Javalin: Stopping Javalin ...
23/03/14 16:57:52 INFO io.javalin.Javalin: Javalin has stopped
23/03/14 16:57:52 INFO org.apache.hudi.timeline.service.TimelineService: Closed Timeline Service
23/03/14 16:57:52 INFO org.apache.hudi.client.embedded.EmbeddedTimelineService: Closed Timeline server
23/03/14 16:57:52 INFO org.apache.hudi.client.transaction.TransactionManager: Transaction manager closed
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.DeltaSync: Shutting down embedded timeline server
23/03/14 16:57:52 INFO org.apache.hudi.client.embedded.EmbeddedTimelineService: Closing Timeline server
23/03/14 16:57:52 INFO org.apache.hudi.timeline.service.TimelineService: Closing Timeline Service
23/03/14 16:57:52 INFO io.javalin.Javalin: Stopping Javalin ...
23/03/14 16:57:52 INFO io.javalin.Javalin: Javalin has stopped
23/03/14 16:57:52 INFO org.apache.hudi.timeline.service.TimelineService: Closed Timeline Service
23/03/14 16:57:52 INFO org.apache.hudi.client.embedded.EmbeddedTimelineService: Closed Timeline server
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer: Delta Sync shutdown. Error ?true
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer: Ingestion completed. Has error: false
23/03/14 16:57:52 INFO org.apache.hudi.utilities.deltastreamer.DeltaSync: Shutting down embedded timeline server
23/03/14 16:57:52 INFO org.apache.hudi.utilities.ingestion.HoodieIngestionService: Ingestion service (continuous mode) has been shut down.
23/03/14 16:57:52 INFO org.sparkproject.jetty.server.AbstractConnector: Stopped<EMAIL_ADDRESS>(http/1.1)}{<IP_ADDRESS>:8090}
23/03/14 16:57:52 WARN org.apache.spark.scheduler.cluster.k8s.ExecutorPodsWatchSnapshotSource: Kubernetes client has been closed (this is expected if the application is shutting down.)

@nsivabalan Can you take a look at the above when you get a chance? Thanks!

@sydneyhoran : sure. I will check it out. thanks!

I could not reproduce. From my testing, my spark job exits.
Here are the contents of properties
cat /tmp/parquet-dfs-compact.props

hoodie.datasource.write.recordkey.field=VendorID
hoodie.datasource.write.partitionpath.field=date_col
hoodie.datasource.write.precombine.field=date_col
hoodie.metadata.enable=true
hoodie.upsert.shuffle.parallelism=8
hoodie.insert.shuffle.parallelism=8
hoodie.delete.shuffle.parallelism=8
hoodie.bulkinsert.shuffle.parallelism=8

hoodie.deltastreamer.source.dfs.root=/tmp/parquet_dataset/
hoodie.deltastreamer.schemaprovider.target.schema.file=file:/tmp/ny.avsc
hoodie.deltastreamer.schemaprovider.source.schema.file=file:/tmp/ny.avsc

my spark submit job
./bin/spark-submit --driver-memory 8g --executor-memory 8g  --class org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer /tmp/hudi-utilities-bundle_2.11-0.14.0-SNAPSHOT.jar --props /tmp/parquet-dfs-compact.props --schemaprovider-class org.apache.hudi.utilities.schema.FilebasedSchemaProvider --source-class org.apache.hudi.utilities.sources.ParquetDFSSource   --source-ordering-field date_col   --table-type MERGE_ON_READ --target-base-path file:\/\/\/tmp/hudi-deltastreamer-ny/   --target-table ny_hudi_tbl  --op UPSERT  --continuous --source-limit 30000000 --min-sync-interval-seconds 10 --post-write-termination-strategy-class org.apache.hudi.utilities.deltastreamer.NoNewDataTerminationStrategy

last few lines from my shell
23/03/20 14:43:21 INFO HoodieTableMetaClient: Finished Loading Table of type MERGE_ON_READ(version=1, baseFileFormat=PARQUET) from file:///tmp/hudi-deltastreamer-ny/
23/03/20 14:43:21 INFO HoodieActiveTimeline: Loaded instants upto : Option{val=[20230320144238433__deltacommit__COMPLETED]}
23/03/20 14:43:21 INFO DeltaSync: Checkpoint to resume from : Option{val=1679348290000}
23/03/20 14:43:21 INFO DFSPathSelector: Root path => /tmp/parquet_dataset/ source limit => 30000000
23/03/20 14:43:21 INFO DeltaSync: No new data, source checkpoint has not changed. Nothing to commit. Old checkpoint=(Option{val=1679348290000}). New Checkpoint=(1679348290000)
23/03/20 14:43:21 INFO NoNewDataTerminationStrategy: Shutting down on continuous mode as there is no new data for 3
23/03/20 14:43:21 WARN HoodieDeltaStreamer: Closing and shutting down ingestion service
23/03/20 14:43:21 INFO HoodieDeltaStreamer: Ingestion completed. Has error: false
23/03/20 14:43:21 INFO TransactionManager: Transaction manager closed
23/03/20 14:43:21 INFO BaseHoodieClient: Stopping Timeline service !!
23/03/20 14:43:21 INFO EmbeddedTimelineService: Closing Timeline server
23/03/20 14:43:21 INFO TimelineService: Closing Timeline Service
23/03/20 14:43:21 INFO Javalin: Stopping Javalin ...
23/03/20 14:43:21 INFO Javalin: Javalin has stopped
23/03/20 14:43:21 INFO TimelineService: Closed Timeline Service
23/03/20 14:43:21 INFO EmbeddedTimelineService: Closed Timeline server
23/03/20 14:43:21 INFO TransactionManager: Transaction manager closed
23/03/20 14:43:21 INFO DeltaSync: Shutting down embedded timeline server
23/03/20 14:43:21 INFO EmbeddedTimelineService: Closing Timeline server
23/03/20 14:43:21 INFO TimelineService: Closing Timeline Service
23/03/20 14:43:21 INFO Javalin: Stopping Javalin ...
23/03/20 14:43:21 INFO Javalin: Javalin has stopped
23/03/20 14:43:21 INFO TimelineService: Closed Timeline Service
23/03/20 14:43:21 INFO EmbeddedTimelineService: Closed Timeline server
23/03/20 14:43:21 INFO HoodieDeltaStreamer: Delta Sync shutdown. Error ?true
23/03/20 14:43:21 WARN HoodieDeltaStreamer: Gracefully shutting down compactor
23/03/20 14:43:21 ERROR HoodieAsyncService: Interrupted while waiting for shutdown
java.lang.InterruptedException
	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2067)
	at java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1475)
	at org.apache.hudi.async.HoodieAsyncService.shutdown(HoodieAsyncService.java:127)
	at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer$DeltaSyncService.shutdownAsyncServices(HoodieDeltaStreamer.java:773)
	at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer$DeltaSyncService.lambda$startService$1(HoodieDeltaStreamer.java:744)
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
23/03/20 14:43:21 INFO HoodieIngestionService: Ingestion service (continuous mode) has been shut down.
23/03/20 14:43:21 INFO HoodieDeltaStreamer: Ingestion completed. Has error: false
23/03/20 14:43:21 INFO DeltaSync: Shutting down embedded timeline server
23/03/20 14:43:21 INFO SparkUI: Stopped Spark web UI at http://<IP_ADDRESS>:8091
23/03/20 14:43:21 INFO MapOutputTrackerMasterEndpoint: MapOutputTrackerMasterEndpoint stopped!
23/03/20 14:43:21 INFO MemoryStore: MemoryStore cleared
23/03/20 14:43:21 INFO BlockManager: BlockManager stopped
23/03/20 14:43:21 INFO BlockManagerMaster: BlockManagerMaster stopped
23/03/20 14:43:21 INFO OutputCommitCoordinator$OutputCommitCoordinatorEndpoint: OutputCommitCoordinator stopped!
23/03/20 14:43:21 INFO SparkContext: Successfully stopped SparkContext
23/03/20 14:43:30 INFO AsyncCompactService: Compactor shutting down properly!!
23/03/20 14:43:30 INFO ShutdownHookManager: Shutdown hook called
23/03/20 14:43:30 INFO ShutdownHookManager: Deleting directory /private/var/folders/ym/8yjkm3n90kq8tk4gfmvk7y140000gn/T/spark-b0421ab6-9ec0-4671-b5a6-3e6a1433859b
23/03/20 14:43:30 INFO ShutdownHookManager: Deleting directory /private/var/folders/ym/8yjkm3n90kq8tk4gfmvk7y140000gn/T/spark-ed48e856-e856-423f-a766-1363056d0ef1
nsb$


Authentication buttons should be disabled if input fields are not filled

Is your feature request related to a problem? Please describe.
A user can currently submit button on sign up page and login page even if no field value is provided.
Describe the solution you'd like
Those buttons should be disabled if all fields are not filled.
Describe alternatives you've considered
Additional context
I would like to work on this.

Ahhh... Ok ahead @Olaleye-Blessing


Logging Interceptor - Use charset specified by the request body content type

It's read but never assigned.

Yikes. We should write a test for this to ensure the declared charset is used. Add one of you're feeling icerly generous, otherwise I'll whip one up later or tomorrow.


fix: uint8_t not in std

add header for std int
fix for fedora install

gcc version 13.1.1
Fedora 38

That sounds good to me

Ok I did some modification on your code but I include it inside the official repo https://github.com/ZmnSCPxj/clboss/pull/169
Thanks!

Closing this for now


yii\test\ActiveFixture::resetTable() should use yii\db\QueryBuilder::truncateTable() instead of manual delete/reset

Because yii\db\QueryBuilder::resetSequence() is not implemented for all drivers, using yii\db\QueryBuilder::truncateTable() will yield better results over all drivers. For example, it enables the use of ActiveFixture for MSSQL, where it couldn't be used before.

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#13577

Closing this as discussed in #13577


agent: call remove after operation is finished

To avoid calling Controller methods concurrently, Controller.Remove
is now called only after the last operation has proceeded. We do this
by checking to see if the cancellation is available to detect an
outstanding operation needs to be completed. Once the operation returns,
we proceed with the shutdown procedure.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>cc @jinuxstyle

@jinuxstyle Please give this patch a try with your test script.

OK, I will.

[Current coverage][cc-pull] is 55.23%

Merging [#1192][cc-pull] into [master][cc-base-branch] will increase coverage by 0.33%

@@             master      #1192   diff @@
==========================================
  Files            77         77
  Lines         12193      12131    -62
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6694       6700     +6
+ Misses         4579       4521    -58
+ Partials        920        910    -10

[][cc-pull]

Powered by Codecov. Last updated by [eacedad...559595b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/eacedad16fd578d452c2ba722058a5f2f1cc36d3...559595ba1f3f0d5b87f691940c165b2a7618abb6?src=pr
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1192?src=pr

LGTM

LGTM


/W4: Conv from 'int' to 'float', poss loss of data

Conversions of the int liteerals to float triggers a warning using MSVC on warning level 4. Changing the literal to float (to which it is converted anyway) solves the issue.

LGTM, thanks!


support concurrent.futures

asyncio and the await syntax in general deals with asyncio futures.  This library so far deals with those, with async functions, and with normal functions.  Integrate concurrent.futures as a handled object type.

also resolved by v0.2.0


two bugs with rays [BUG]

Expected Behavior
Hello. The rays do not update position and if (toolbox=True) the entire graph is drawn incorrectly.

example data -->
ohlc.csv
Current Behaviour
This bug do not produces no errors in Python.

Reproducible Example
import pandas as pd
from lightweight_charts import Chart

if __name__ == '__main__':
    chart = Chart(toolbox=True)
    chart.legend(True)

    df = pd.read_csv('ohlc.csv')
    chart.set(df)

    rayLine = chart.ray_line(df['date'].iloc[-30], df['close'].iloc[-30])

    new_position = pd.Series({'time': df['date'].iloc[-50], 'value': 162})
    rayLine.update(new_position)    # <---- NO UPDATE RAY-LINE

    chart.show(block=True)

Environment
- OS: Windows 10 22H2
- Library: <IP_ADDRESS>

Hey @NikolayNelubov,
Do you get the same issue if you use the ohlcv.csv data provided in the examples?
Louis

With ohlcv.csv the rayline is displayed correctly. But still does not  rayLine.update(new_position) his position.

Hey @NikolayNelubov,
As raylines are essentially a subclass of the Line object, there is no way to update them using the update method. At present, you will have to delete the previous ray line and create a new one.

I see, thank you. I hope in a future version there will be a method for updating the position for rays. Good luck to you in all your endeavors!


redpanda: configmap refactors

These two commits encapsulate some of the more difficult checks of Enabled fields and migrates most config generation onto the listener structs. This is in preparation for allowing customization of the truststore_file.

I incorporated all improvements from this PR into https://github.com/redpanda-data/helm-charts/pull/1268


Stored functions

Looks like SQLParser-rs doesn't currently support CREATE PROCEDURE or alike so for now perhaps:
EXEC CREATE FUNCTION IIF(X, Y, RIGHT(Z, 3))


The AWS SQS Queue scaler's documentation should be more specific about which SQS actions are required

Proposal
The AWS SQS Queue scaler's documentation states: "The user will need access to read properties from the specified AWS SQS queue."
It would be nice to have the exact list of required SQS actions needed in the AWS policy.
For example:
"The user will need access to read properties from the specified AWS SQS queue. The AWS policy must allow action sqs:GetQueueAttributes against the queue subject to the scaler's monitoring."
Use-Case
Users have to configure the AWS policy, and they need to know the exact list of required SQS actions by the scaler.
Anything else?
This suggestion applies to the documentation for other scalers that monitor different types of AWS resources.

Hi @AndreyMatveyev
Sorry for the slow response. :(
Are you willing to contribute with that change? We are not experts on AWS, so if you feel that the documentation is poor and you have an idea about how to solve it, we will be happy if you contribute with it.
The change in this case should be done in the docs repo.


setToken redirect the browser even if redirect param is set to false

The method setToken is redirecting even if the redirect param is set to false as below:
            $auth.setToken(data.token, false);

Have you blanked out $authProvider.loginRedirect in the config phase of your app?
The default value for this config variable is '/', which will trigger this redirect check regardless of a false redirect in setToken:
if (config.loginRedirect && !redirect) {
    $location.path(config.loginRedirect);
...

Check the example app's for an example config block, where you would simply add the following:
$authProvider.loginRedirect = '';

Ok. If I set it to blank it works.
But, what is the point to have this redirect param?
For example, in my app, when I update the user profile information I receive a new token with the updated user information and store it using setToken. In this case I do not need the redirection because the user is already logged in.
If this code fragment is modified in this way:
if (config.loginRedirect && redirect) {
    $location.path(config.loginRedirect);
...

I think it will obey this redirec param.
What do you think?

Follow this link to see the full conditional is as follows:
if (config.loginRedirect && !redirect) {
    $location.path(config.loginRedirect);
}  else if (redirect && angular.isString(redirect)) {
    $location.path(encodeURI(redirect));
}

This structure prioritizes redirect when it's supplied, but when it isn't, it will fall back on config.loginRedirect for default. The change you're suggesting would only apply the default redirect if an explicit redirect is also supplied, breaking this example:
// refresh token and redirect home (default)
auth.setToken(token);

If I'm understanding your goal, you want to rely on config.loginRedirect normally, but want to be able to explicitly suppress redirection in only certain scenarios like yours, when you want a new token with no redirect. Is that right?

I see.
Yes, that was my goal.
I've misunderstood the current meaning of this redirect param. Sorry for that.
Another try:
if (config.loginRedirect && !redirect && (redirect !== false)) {
    $location.path(config.loginRedirect);
}  else if (redirect && angular.isString(redirect)) {
    $location.path(encodeURI(redirect));
}

That solution makes sense and I think the problem is valid enough to submit a PR. It's not an ideal situation, though. This is a workaround, and the behavior would have to be specially documented.
I think this is showcasing the complexity of having satellizer involved in routing. Perhaps I should mention this in a separate Issue/PR, but I had a problem with redirects using $location instead of $state, since I'm using ui-router, and I had to share router config with satellizer's config to satisfy it. When routing gets baked-in like this, satellizer becomes opinionated on behavior outside of authentication, when redirects could easily be put into a promise resolution.
I think your suggested PR is valid for this issue, but it's my opinion that redirection should be removed entirely from satellizer. That's what promises are for.

I agree. Routing operations should be handled by the application as there are a number of router modules and this number is increasing.
With the promise returned by the $http module it is very trivial to do the app specific routing.
Thank you.

Relevant issue, especially considering the docs:
$auth.setToken(token, [redirect])
Saves a JWT or an access token to Local Storage. It uses shared.setToken internally.
token - An object that takes a JWT (response.data[config.tokenName]) or an access token (response.access_token).
redirect - An optional boolean value that controls whether or not to redirect to loginRedirect route after saving a token. Defaults to false.
IMO the docs make more sense then current behaviour. Which redirect should be used is maybe more something to decided in the actual login flow?

Yeah, I agree with this. If you're looking for a temp workaround, set redirect to true. This way its not a string and it exists; skipping both redirect conditions.
Also, maybe make authenticate and login be the same. login takes a redirect param while authenticate does not and sends in false


fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22

This change: (check at least one)

[ ] Adds a new feature
[X] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[X] No

Is the: (complete all)

[X] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[X] Test suite(s) passing?
[X] Code coverage maximal?
[X] Changeset added?
[X] Component status page up to date?

What does this change address?
#826
How does this change work?
Remove overflow property for an element that will never overflow
Additional context

I see the size report action is failing, wondering if that is because of the node 22 update?

@brentswisher I also noticed the size job failing and it does relate to node 22 but I don't know how to fix it. It might be a task that relies the latest build.
My interpretation of the error is that the job runs a build against both the current branch and develop with node22, and its failing to run against develop because it has the unsupported node 20 syntax. So it should get corrected once we merge and develop gets these updates to evaluate in the next PR


So badly outdated as to be useless

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae2e3360-2086-b37d-0048-1ff04a4736bb
Version Independent ID: d8976bd3-d1d9-3852-5113-5d0403b02dc1
Content: Tutorial: Build a multi-tenant daemon that accesses Microsoft Graph business data - Microsoft Entra
Content Source: articles/active-directory/develop/tutorial-v2-aspnet-daemon-web-app.md
Service: active-directory
Sub-service: develop
GitHub Login: @jmprieur
Microsoft Alias: jmprieur

@lsmith-apriva
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Will be addressed with Microsoft.Identity.Web v2.0
See https://github.com/AzureAD/microsoft-identity-web/wiki/v2.0

Thank You, Jean Marc!
@.***
Lawrence Smith
Sr Software Architect
480.421.1276
@.***
apriva.comhttp://www.apriva.com/
From: Jean-Marc Prieur @.>
Sent: Monday, November 28, 2022 9:07 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Larry Smith @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] So badly outdated as to be useless (Issue #98598)
CAUTION: This email originated from outside the Apriva network. Do not click on links or open attachments unless you recognize the sender and know the content is safe.
Will be addressed with Microsoft.Identity.Web v2.0
See https://github.com/AzureAD/microsoft-identity-web/wiki/v2.0https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzureAD%2Fmicrosoft-identity-web%2Fwiki%2Fv2.0&data=05|01||60deb144dc434da3af6e08dad1bf1d74|91019608a27c43debc269209aad30ef1|0|0|638052916072505312|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=TQ1LOoXUEDIF3eVuhhZ6dGiYBrRU62i514d6XBb1reY%3D&reserved=0

Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F98598%23issuecomment-1330046370&data=05|01||60deb144dc434da3af6e08dad1bf1d74|91019608a27c43debc269209aad30ef1|0|0|638052916072505312|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=CxJpuEvST%2B9tqiexKwWsXb4FW1We48u5pZI1AJKjNCc%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2IZ77MRC3YZ2NUSCXO7VLTWKV6M5ANCNFSM6AAAAAAQOW4ZGQ&data=05|01||60deb144dc434da3af6e08dad1bf1d74|91019608a27c43debc269209aad30ef1|0|0|638052916072505312|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=nKhhk2krAQHJTabAArqVzzMukSYXKtZ5JyM4ywOflg4%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

#please-close


Use 'D' symbol in format to specify minimal length of fractional part

This request address issues #45 and #63 (as far as I understand this issues duplicate each other). Now it's possible to specify minimal length of fractional part using 'D' symbol. At the same time 'd' symbol used to specify maximal length as it works in current version.
Here some examples how format works. Assume that value is 1.23:

( ddd).d became 1.2
( ddd).D became 1.2
( ddd).ddd became 1.23
( ddd).DDD became 1.230
( ddd).Ddd became 1.23
( ddd).DDd became 1.23
( ddd).dD will raise exception

Look for live sample in trailing-zero.html file in test folder

Thank you very much for solution !!
It looks great !!
But do you have a solution to put "€" just after the number ?
Thank you again.
Best Regards.

I use :before and :after css selector to out currency's symbol. I.e.

.eur:before {content: "\20AC\00A0";}

And then set value to span via textContent

Thanks again !
But where do I have to call on this script ?
�

Finally, the class is now loaded but the price is placed under the Euro sign. I don't understand cos there is no breakline...
The result is like that :
€
180,250

I've add follow lines to the bottom of my odometer's theme file:
.odometer-inside {
  display: inherit;
}

I'm not sure about correctness of this solution and you cat try replay display: block in odometer's theme

Ok. Thank you !
Perfect ;-)


MRG BUG/API: Fix bugs with KIT/Ricoh reader

@apesquita can you try this branch with your data? In particular, as @agramfort said, some simple dataset would be great. Ideally something like a high-SNR auditory evoked dataset with MRI-based N100 source localization and plot_alignment calls should tell us if we're doing things correctly.
Introduces a standardize_names=None that defaults to True in 0.21 but changes to False in 0.22. False means "use names if present in the file". We don't have any files like this, but it seems to work in local testing. It would be good to get some tiny test file to really test this, but in the meantime I've modified a test to modify an existing test file to mock it.
Todo:

[x] Check that localization and plot_alignment are correct
[x] Fix EEG scaling
[x] Choose/check naming for systems

Actually it looks like @Kyung-minAn sent @agramfort some data for testing. So we don't need any data from you @apesquita , but it would be good to get feedback on how it's working for you!

Super! I am on leave for a few days. But I'll give this a go next week.
Many thanks. Ana
On Wed, Aug 5, 2020 at 9:09 PM<EMAIL_ADDRESS>wrote:

Actually it looks like @Kyung-minAn https://github.com/Kyung-minAn sent
@agramfort https://github.com/agramfort some data for testing. So we
don't need any data from you @apesquita https://github.com/apesquita ,
but it would be good to get feedback on how it's working for you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/8100#issuecomment-669475241,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXJVWYKNJZN36IVNU5767DR7G36JANCNFSM4PV3EAFQ
.

Good!!
@larsoner and @agramfort, Thank you for developing and testing it.
If you need more dataset for testing, please tell me~
@apesquita, Thanks~ Ana!

Okay @Kyung-minAn with your auditory data I can obtain these plots:

Was the head tilted that far forward?
It's entirely possible my rough coreg is the cause of the activation being localized on the wrong side of the Sylvian fissure. I think this is probably okay. What do you think?
@Kyung-minAn would it be possible for you to record the tiniest file possible (e.g., 1 sec data) that includes coregistration? I already have a dataset that is 20 sec long. If this is as short as possible, then we can use that for testing already. But it would be better to have a smaller one if possible.

@Kyung-minAn actually never mind about the testing data -- looks like we already have some nice small files!

@larsoner
I upload a tiny data I cut 1 s long.
020321_PureTone_MEG160-export_1s.zip
If small files you have is not suitable for testing, I would be glad that you use this one.

@larsoner , Thank you for the test results.
The plots you uploaded look so nice~!!
Although the sources are localized outside of the Sylvian fissure, I think that your test is successful.
This is a plot when I performed coregistration for the same data.

I think the localization error results from the noisy MRI data.
I'm so excited for your progress!!
Thanks a lot!!!
Min

Pushed a commit to fix EEG gains, now we verify that the values we get from the MEG/EEG/misc channels match what's in the PDF. Thanks for the excellent test data!

Ready for review/merge from my end @agramfort

@larsoner Hi, just ran a quick comparo of this branch on our KIT MEG160 and KIT MEG125
Certainly aligns the helmet and sensors, but the face area is filled in on the MEG160 (bottom lefthand image)?
master

ricoh

@Kyung-minAn have you tried this?
Best, P

@paulsowman can you mne.io.write_info(raw.info) and upload it somewhere for me to try? That way I can debug the helmet-over-face issue

@paulsowman actually don't bother, I can replicate with our own test KIT data if I make it generate a helmet on the fly. I'll try to fix it

Okay @paulsowman feel free to try again. On master this is what the following code does with testing data -- it looks nice and smooth, but there is already some misalignment because our built-in helmet is not a good match for the sensor locations:
python -c "import mne; raw = mne.io.read_raw_kit('test_as-raw.con'); mne.viz.plot_alignment(raw.info, show_axes=True, eeg=False, surfaces=[])"

If I force it to generate a helmet (like it does in your case), it gets ugly:

This PR fixes helmet generation, and actually just always does it for KIT now -- it's not as pretty as our smoothed surface, but it should more accurately represent the geometry:

Can you see if it fixes your "filled in face" problem?

hey, I just tried this out some of the KIT data and nothing is broken, channel naming is the same regardless of the standardize_name value (guessing no names are stored for ours), helmet is fine, everything seems to be OK

Thanks everyone !

KIT UMD also seems to be working as expected (thanks @jpkulasingham for testing!)

no need of MRI but 10s of data for each system would be useful.

I would say 1 sec is even better than 10 sec (less space for testing files)

@agramfort @larsoner
Ricoh company sent me three con files from adult MEG system (1s long).
PQA160C/1001/Kanazawa (until 2017)
RICOH160-1/10020/Kanazawa (since 2018)
RICOH160-1/10021/Kanazawa (since August 2020)
The last file is the recent version of the adult MEG system.
They changed sensor layouts during their upgrade.
Yokogawa_Ricoh_sample_data_1s.zip
Thank you for your help.

see https://github.com/mne-tools/mne-python/pull/8187/files
On Tue, Sep 1, 2020 at 11:49 AM Kyung-minAn<EMAIL_ADDRESS>wrote:

@agramfort https://github.com/agramfort @larsoner
https://github.com/larsoner
Ricoh company sent me three con files from adult MEG system (1s long).
PQA160C/1001/Kanazawa (until 2017)
RICOH160-1/10020/Kanazawa (since 2018)
RICOH160-1/10021/Kanazawa (since August 2020)
The last file is the recent version of the adult MEG system.
They changed sensor layouts during their upgrade.
Yokogawa_Ricoh_sample_data_1s.zip
https://github.com/mne-tools/mne-python/files/5155385/Yokogawa_Ricoh_sample_data_1s.zip
Thank you for your help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/8100#issuecomment-684685156,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABHKHGBZ7IQQAZS3S25USDSDS7RVANCNFSM4PV3EAFQ
.

@agramfort
Thank you for your effort. I checked it.
For a child-customized Yokogawa MEG system (the data I sent initially, PQ1151R/903/Kanazawa), would it be better to be added in the Ricoh data reader as well?

can you share again the file PQ1151R/903/Kanazawa ? is it tiny?

@agramfort @Kyung-minAn
Hello,
I am trying to catch-up. A lot has happened! Thanks so much!

I have this small file from the child-size system that @Kyung-minAn had shared before. Does this one work for your purposes?

motor_task_tiny.zip

Which layout from the following should I choose for a child-size data? I am not sure if this is yet available or not.
['CTF-275.lout', 'CTF151.lay', 'CTF275.lay', 'EEG1005.lay', 'EGI256.lout', 'KIT-125.lout', 'KIT-157.lout', 'KIT-160.lay', 'KIT-AD.lout', 'KIT-AS-2008.lout', 'KIT-UMD-3.lout', 'Neuromag_122.lout', 'Vectorview-all.lout', 'Vectorview-grad.lout', 'Vectorview-grad_norm.lout', 'Vectorview-mag.lout', 'biosemi.lay', 'magnesWH3600.lout']

Thanks for helping me catch up!
Ana P

@apesquita, Thank you for sharing sample data.
The data was recorded from child-customized MEG system (PQ1151R/903/Kanazawa).
@agramfort, Thank you for checking the data. If you need more tiny data, please tell me. I will cut it for 1 s long.
Many thanks,

doing
import mne
raw = mne.io.read_raw_kit('010409_Motor_task_coregist-export_tiny.con')
raw.info['bads'] = ['MEG 099']
raw.plot_sensors()
raw.plot_psd(sphere='auto')

gives

you see that there is hope that layout is already found out properly.
Just a shift problem with plot_psd. Any idea @larsoner ?

Just a shift problem with plot_psd. Any idea @larsoner ?

If the head was toward the right side of the sensors during recording, this is a feature, not a bug. The topomap plots (and sensor plots) now try to account for info['dev_head_t'] and also the head size when deciding where and how large to draw the head circle relative to the sensors

but why is it different when you do plot_sensors?

Ahh I didn't see the difference. Yeah it seems like those two plots should have the same head-sensor relationship, and they don't. So I agree it's a bug


tidy clippy linting

add clippy config file aligned with MSRV set in CI
move deny warnings from the CI script to a compiler flag to ensure consistent behaviour during development and CI
address a few pedantic lints

We want the clippy to be run on stable, not msrv.

that's not what the clippy config does. setting the MSRV prevents clippy from suggesting changes that use syntax or features which are not compatible with the MSRV.

Thanks! ❤


Feature trex

This feature introduces the following changes:

Added a dynamic type Var.
Async functions now accept callback of any type not only void(*)(JSONObject).
Message queuing when the device is not connected with Grandeur is improved.

Created a release.

Created a release.


Add support for authenticated media

Setup instructions:

Set up a reverse proxy to pass /_heisenbridge/media/* to heisenbridge
Configure heisenbridge -> media_url in the registration file with the public URL that the reverse proxy handles

Optionally, you can run another heisenbridge instance with the --media-proxy flag to have it in a separate process

@hifi pls? :P

Oh yeah, I guess authenticated media has been out for long enough by now


“switch” points nowhere, make it point to given/when

What document are you referring to where 'switch' is?

https://docs.perl6.org/language/control#given

fixed with https://github.com/perl6/doc/commit/51d7a8d7e5


Tests broken on german machine because warning is given in german

Our tests are not independent of the language settings of the developer machine.

Repro steps
Use german machine and run build.cmd all
Actual behaviour
Build is broken with the following changes:

is there a way to flag them and set the thread culture arbitrarily?

@smoothdeveloper  yes with an internal use fsc argument LCID (used by ide), but that add a warning, so change a bit the diff of output.
i added #858 to add an additional  --preferreduilang like roslyn to pass en-US, so test can pass the language for case sensitive tests (i get same problem with italian)
i think i need to rebase and ask for review

Maybe we can disable the 4 tests for non-us systems?  Or we remove the part that tests the culture specific message.

the whole test is case sensitive (diff the output of compiler), but we can disable these ( nunit ignore ) on non en-US cultures. I'll send a pr, good idea @forki

❤  thanks for making this work.


Import boost 1.70 bugfix for clang version check - 1.8

Change Description
Fixes #8915
This commit applies a patch to boost version 1.70, which incorrectly used lexicographical comparison of compiler versions, so version 11 was considered less than 4. As a result, BJam passed the -fcoalesce-templates option (which was not supported since GCC 4.0) to compiler versions 10+, which in turn broke eos build.
See https://github.com/boostorg/build/issues/440 for details.
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

This does not fix the issue on the mac side.

This fix will only work for a fresh build of eos. Because the patch is applied to boost version 1.70 that's downloaded and installed into the target directory, the target directory must be wiped out or changed to a new directory (using ./scripts/eosio_build.sh -i /path/to/new/install/dir). Removing the build directory is not enough.


ion-select z-index conflicts with custom UI element

Bug Report
Ionic version:

[x] 4.1.1
Current behavior:

I have an element with ion-select on the page. Also, there is a custom drawer element with a drawer button sitting over the ion-select when the drawer is open. Because the is a z-index: 2 on the ion-select it takes precedence (in terms of visibility and event handling) over the button of my drawer, despite the button being higher in the DOM hierarchy. I see no reason why z-index: 2 would be needed on that element.

Hi there,
Thanks for opening an issue with us! Would you be able to provide a repository with the code required to reproduce this issue?
Thanks!


Add Time base and speeding/slowing

[x] Add fields for controlling speed of time and verify with existing scenarios
[x] Hook up speed up/slow down buttons. They should effect both running and stepping.

Also needed to change the way periodic drawing of trails is triggered so that the spacing remains the same at any speed of simulation.

When slowing way down I also experienced the same symptoms as issue #10. At very slow speeds there may be too many calculations with very small deltas, compromising precision.


Adding New Type Skills Fails if Translation Not Provided for Key

submitted by Discord User Rob Sol, window to add new skill won't pop up, error seems to be this line:

workaround is to set language back to English (or presumably any language with a translation file that has the keys shown below)

Think I have a fix for this where it will more gracefully fail


Talos uses phenopackets

Counterpart to https://github.com/populationgenomics/talos/pull/446
Some arguments changed. some stages dropped, one new one added. It's a brave new world, get on board

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.65%. Comparing base (f49675e) to head (aa0223a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   78.65%   78.65%
=======================================
  Files          10       10
  Lines        1785     1785
=======================================
  Hits         1404     1404
  Misses        381      381

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Handle GPO Comment gracefully when Central Store is on D:\SYSVOL

Update README
Update defaults/main.yml to have a new variable opt_laps_gpo_comment_path
Update tasks/gpo.yml to utilize variable for GPO Comment destination

Can't think of a way offhand to deal with relocating AdmPwd.admx to a Central Store on D:\SYSVOL

I'm curious is there a way to programatically get the SYSVOL location. Being able to get that value dynamically instead of having a user manually specify that is a lot more ideal. Potentially we can just change the path to be \\localhost\SYSVOL\domain\Policies\{{ '{' }}{{ pri_laps_gpo.id }}{{ '}' }}\Machine\comment.cmtx. Otherwise I think we can call (Get-SmbShare -Name SYSVOL).Path to get the local path based on the share path.

I would agree that looks cleaner.  I was in a bit of a rush with this and your method is much better.
I actually can't test as my lab environment is unavailable.

No worries, the only other thing is around the ARM architecture https://github.com/jborean93/ansible-role-win_laps/pull/5/files#diff-6d62b73b3f46cfa11f6466d08cf45303R9. I don't have an ARM host to test so I have no idea what the value of $env:PROCESSOR_ARCHITECTURE is on that host and if it matches that key.

ARM64 is the documented value:
https://docs.microsoft.com/en-us/windows/win32/winprog64/wow64-implementation-details

Awesome thanks for confirming that.


Added Delivery Timer and Daily Quests HUD

ignore rest commits idk what happend, just take the 2 i said

JTGHQ timers added
daily quests seems too brittle to add atm


Cannot for the life of me, get nginx-proxy-manager to work with Discourse in a reverse-proxy-configuration.

I tried deploying (locally) a VM running Ubuntu Server 18.04 to run a piece of forum software called "Discourse"
The issue is when I attempt to forward traffic going to domain.xyz to address x.x.x.x and using certs installed / created locally on nginx-proxy-manager.
The installer (For discourse) refuses to acknowledge port 443 is open, and when checking the authenticity of the domain it fails every time stating that 443 is unreachable, and that 80 IS reachable.
As for testing it myself, I get error 502's via Chrome, indicating the webserver is DOWN. Which is odd. It must be hunting for a file or something when it runs that test. ¯_(ツ)_/¯

I've read their documentation in regards to running it behind an NGINX server, but I don't understand how to apply it to nginx-proxy-manager itself. 🤔
(https://meta.discourse.org/t/running-other-websites-on-the-same-machine-as-discourse/17247)
If anyone here has experience in deploying a Discourse in a situation like this, I'd love some input. But as for now, I'm stuck here and cannot proceed any further.

I should probably also include the config as displayed in Nginx-Proxy-Manager itself...

After further review, the above configuration was correct.
The issue I was facing was on Discourse's end, and it's configuration documentation in regards to using reverse proxies.
In their documentation they state to use / add the following argument into the app.yml file before compiling / building with Docker:
- "templates/web.socketed.template.yml"  # <-- Added
and to comment out:
- "80:80" # http
- "443:443" # https

After doing a complete wipe, redownload of Discourse's AiO installer and clean install IGNORING all of the aforementioned "requested steps" Discourse worked right out of the box if you just run ./discourse-installer, ignore the error and just slap your domain details into app.yml as well as SMTP mail server details into the file and compile / build with ./launcher rebuild app
I'm marking this as closed, and for anyone else who happens upon this issue, this is how you fix it.
You can further contact me via my email listed on my Github Profile. 👍


Cfd plot fix

The plot function in ConditionalFreqDist was throwing an ImportError
because it was trying to import 'plt' from matplotlib which does not
exist. Additionally the methods called were still the methods of
they pylab submodule and I updated those calls to those of the pyplot
submodule. Additionally the if v in self key check would not pass
with valid input so I removed it and the function now plots correctly.

Thanks @jbbe.
Resolved in #2319


Warning message for Quick-TRANSfer

I'm running into a Quick-TRANSfer warning when running scPredict. It seems to be related to this Harmony issue.
This is an example of what I'm running:
process_seurats <- function(seuratraw){
  seuratraw <- seuratraw %>%
    NormalizeData() %>%
    FindVariableFeatures() %>%
    ScaleData() %>%
    RunPCA() %>%
    RunUMAP(dims = 1:30) %>%
    JackStraw(num.replicate = 100) %>%
    ScoreJackStraw(dims = 1:20) %>%
    FindNeighbors(dims = 1:20) %>%
    FindClusters(resolution = 1:10/10)
  return(seuratraw)
}

set.seed(2248)
query <- process_seurats(query)

# predict using model
query <- scPredict(query, reference, max.iter.harmony = 50)

And the warning message that occurs:
Harmony converged after 2 iterations
Warning message:
Quick-TRANSfer stage steps exceeded maximum (= 4439650)

Can this warning be safely ignored? Or is this an issue with Harmony?
Thanks!

I had a similar issue when mda model was used during training process. Can this warning be ignored?


Switch out plus icon to the new one

💬 Description
As it says on the tin
✅ Checklist

[ ] Tests written
[ ] Browser tested
[ ] Added to documentation
[ ] Added to storybook

 Mobbing

 Mobbing


[UIK-2687][docs] Updated Volume filter example and docs

Motivation and Context
A11y
Still present, need to find a solution:

problem navigating from bottom part to listbox UIK-2763
both input and list item are focused, and pressing Enter is unpredictable

Fixed:

problem with input roles - #1821
dialog and trigger must be labelled "Volume"
listbox must be labelled "Presets"
from/to inputs should have unique labels
from/to inputs must be in a group named "Custom range"

UX
All fixed:

custom range must be cleared when a list option is applied
no options must be selected in list when custom range is applied
max value must be unlimited
if "to" is empty, it must stay empty, and trigger must show "{from}" (e.g. "55")

How has this been tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[x] Nice improve.

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly or it's not required.
[ ] Unit tests are not broken.
[ ] I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
[ ] I have added new unit tests on added of fixed functionality.

@ilyabrower what do you think we should do to solve these 2 issues?
you're also welcome to review the code written so far

@ilyabrower what do you think we should do to solve these 2 issues?

Fixed


environment variables

They should preferably be autocompleted too, if that's possible.

Hmm. I'll look into it.


Quaterly Press Release

Acceptance Criteria:
Quaterly Press Release

Should create a process for this that involves tracking in issue.


Ask mp only when needed

Hello,
I'd like to use the cli in a script to retrieve team informations using the team memberlist option.
It currently asks for the mp (while it's not required to use only the api), it'd be nice to ask for it only when required.
thanks!

Hello,
Currently, the device secret key that is required to call the endpoint you're talking of is encrypted using the local key that is stored in the keychain, or encrypted using the master password in the local storage. That is why your master password is asked.
From your message, I guess you do not want to store your master password, even encrypted. The only solution I can think of would be to add the possibility to disable the save of the encrypted master password in the local storage, but still save the local key in the keychain. Thus, you could recover the device secret key.
This would add some granularity in the secrecy options.

Cyril message is a bit simplified, his initial use case is to use the CLI on a CI (and calling methods that don't require decrypting any content).
Another solution could be to use the MP as env variable so the MP is in the CI secrets manager.
Another one could be to be able to export the device secrets so they can be stored in the CI secrets manager.


Current solution to build for macos ARM64

Hello,
I wonder what are the actual solutions to build macos/ARM64 packages with public CI services available like GH Actions.
It seems that GH Actions hasn't released the support for M1 yet: https://github.com/github/roadmap/issues/528
The only other solution I could think of, would be cross compilation but I don't think that's possible yet with meson-python?
Did I miss something?

GitHub Actions is going to take a while longer I suspect. I did just learn of Cirrus CI, which seems to be the first to offer M1 support free for open source projects: https://cirrus-ci.org/guide/macOS/#macos-virtual-machines. I haven't tried it myself yet, but it looks promising.
Qemu probably doesn't work on macOS arm64 yet? Can't find any info so quickly.

The only other solution I could think of, would be cross compilation but I don't think that's possible yet with meson-python?

I'm working on that for SciPy; part 1 is making cross-compilation work when using meson directly (basically there with one hacky bit), part 2 is to supply a cross file to pip or build and have that picked up correctly.

I didn't know either cirrus! Awesome, it seems indeed to provide ARM64 machines:

I'll try to use that to publish on PyPi.

Great, would love to hear how it works out for you!

Well so far, I was able to build a wheel (still using my wrapper script to get the right name) \o/:
Found one wheel to rename dist/pycdfpp-0.4.0-cp310-cp310-any.whl
New wheel name: dist/pycdfpp-0.4.0-cp310-cp310-macosx_12_0_arm64.whl

It's pretty fast and the UI is quite nice:

My current .currus.yml file is:
macos_instance:
  image: ghcr.io/cirruslabs/macos-monterey-base:latest

task:
  script: |
    brew install gcc@11 pyenv
    pyenv install 3.10.4
    export PATH="~/.pyenv/shims:${PATH}"
    pyenv local 3.10.4
    pip3 install meson build wheel twine
    CC=gcc-11 CXX=g++-11 python3 scripts/build_wheel.py

Next steps are:

find how to filter github releases
do it for all python versions if possible with build matrix if it exists
register secrets to push on PyPi

And that should be enough.

Finally I was able to build and push on test.pypi with the following script:
https://github.com/SciQLop/CDFpp/blob/2b7d9d43712e58aa6b7fb429e50802038e837cac/.cirrus.yml
Note that the yml can be quite tricky to write and also you have some strong concurrency limitations for free projects, only one task at the time plus some delay between tasks. But it works pretty well! Thank you for the pointer :).

Thanks for sharing @jeandet, very useful!

Cool stuff, it seems to work quite well in my tests on the two cross-linked medium size Python projects as well.


Call Log Partial Views

Mashed that button.

Thanks a ton for your work on this, @drownedout !
I had a few comments and suggested changes -- please tweak if you've got the availability this week, otherwise I'll pull this down and edit on Friday or Saturday.

Oh shoot. I just saw this.


focusing issue in nih-plug / Windows 10

In Windows 10, nih-plug standalone version egui does not get keyboard input, because the parented windows is never focused.
always calling .focus() on the window fixes this but its not a nice solution.

this was briefly talked about in the rust audio discord, basically keyboard focus with baseview is kind of a mess on windows, and ableton is partially to blame. i've tried fixing this but haven't had much luck

@murl-digital your idea in past discord conversation + a post from an @Beepster fixed this for me. I have just maintained a fork of egui_baseview to keep this working in my plugins, but here is all I changed in egui_baseview to "make this work" although it doesn't feel like the right way :)
in src/window.rs at bottom of fn on_frame()
        if !full_output.platform_output.events.is_empty() ||
            full_output.platform_output.ime.is_some() {
            #[cfg(target_os = "windows")]
            window.focus();
        }

That is kind of hacky, but if you think this is a good temporary fix I could merge it upstream.

i recall someone somewhere saying there were problems or it didn't work exactly how it was expected to, but i reckon it's good enough
i think it may be smart to put it behind a feature gate in case it has unintended consequences


Move the query request and response details to modules

Closes: #56

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@07a58a0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #57   +/-   ##
=======================================
  Coverage          ?   7.7%
=======================================
  Files             ?     44
  Lines             ?   1322
  Branches          ?    180
=======================================
  Hits              ?    103
  Misses            ?   1186
  Partials          ?     33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a58a0...e15f714. Read the comment docs.


Video volume set before play is not applied on the video

Depending the core provider, setting a video volume before play() doesn't work:

video_ffmpeg: volume is not saved internally, and volume is applied only if the internal player is created. It fail silently if the internal player is not yet created (only after play()).
video_ffpyplayer: volume is saved internally, and applied to the internal player if created. The volume is not applied when the internal player is created.
video_gi: volume is set internally and on the internal player. The internal player is created when the instance is created, so there is no issue.
video_gstplayer: volume is set internally and on the internal player if created. The volume is also set when play(). There is no issue.
video_pyglet: volume is set if the internal player is created. The internal player is created on load(), so no issue.

In conclusion: only video_ffmpeg and video_ffpyplayer are impacted.

Well, ffpyplayer doesn't do live volume changes :/


Added a new fields to Work and File

This change adds a new "checksum generation date" field to File.  This is the date that the checksum was generated by either Banjo or an external application. The E-Deposit application will include this data when it submits files to Banjo
A new "vendor id" field has been added to Work. Vendor id is generated by the E-Deposit application and needs to be included in the data sent to Voyager.
@scoen

looks fine to me


fix uservars in minizinc

All solvervars were being used as uservars in minizinc, from a time before we needed decompositions for minizinc.

Not sure if we need to uncomment the get_variables in objective() (line 401)
If there can be vars in the objective that are not in the constraints we need to?

keep it? it's not there at the moment i think

Seems like putting variable in the objective that is not in the constraints doesn't work anyway
m = Model(x1 == 6)
m.minimize(x2)
m.solve('minizinc')

x2 will be None after solve even if we add it to the uservars.
Merging this


Invalid call on checkpoint initiator phase _WaitingCheckpointInitiatorPhase

Is this a bug, feature request, or feedback?
Bug
What is the current behavior?
Crash when adding 2nd worker to a 1 worker cluster.
What is the expected behavior?
Wallaroo doesn't crash.
What OS and version of Wallaroo are you using?
Ubuntu Xenial/18.04 LTS VM with 2 vCPUs & 4GB RAM + aloc-tee-source branch @ commit 667910400ef
Steps to reproduce?
See steps for #3003.  This crash happens much less frequently than #3003's crash reason, perhaps 1 failure in 10 or 20 attempts.
Full logs and input file are at http://wallaroolabs-dev.s3.amazonaws.com/logs/logs.20190909b.tar.gz.  The last few lines of the initializer's log are:
1568070130.953989,Checkpoint_Initiator: Checkpoint Barrier CheckpointBarrierToken(2) Complete
1568070130.954088,EventLog: Writing CheckpointId for CheckpointId 2
1568070130.954831,Received msg on Control Channel
1568070130.954861,INFO,2PC,2PC: Checkpoint complete 2 _twopc.txn_id is Passthrough-w-initializer-id-124429631552992038742267394152216317954:c_id=2
1568070130.955126,Sent control message to worker2
1568070130.955316,Checkpoint_Initiator: Event Log CheckpointId 2 complete for worker worker2
1568070130.955327,Invalid call on checkpoint initiator phase _WaitingCheckpointInitiatorPhase
This should never happen: failure in /home/vagrant/wallaroo/lib/wallaroo/core/checkpoint/checkpoint_initiator_phase.pony at line 53

Pilot error: I was using start-worker.sh when I should have been using join-worker.sh.  Closing.


HLS #EXT-X-MEDIA Tags not parsed properly, Missing Attributes

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v4.3.8 (uncompiled)
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Demo
If custom app, can you reproduce the issue using our demo app?
NA
What browser and OS are you using?
Windows 11, Chrome v115
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
NA
What are the manifest and license server URIs?

Sent over mail
What configuration are you using?  What is the output of player.getConfiguration()?

Default Configuration
What did you do?

Loaded the Manifest
What did you expect to happen?
HLS Manifest has the #EXT-X-MEDIA tag however it isn't parsed properly attributes like Name, Deault, Language ... Tag:
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio-aacl-98",LANGUAGE="hi",NAME="Hindi",DEFAULT=YES,AUTOSELECT=YES,CHANNELS="2"

What actually happened?

I see language as und and rest values as null

Tried debugging the issue found that HLS Parser filters outs the HLS Tags where uri is missing, In the case above instead of URI it's assigned via GROUP-ID this function below skips the respective #EXT-X-MEDIA tag
https://github.com/shaka-project/shaka-player/blob/ed93a0cb12173de65f76109136d179bb0f34c014/lib/hls/hls_parser.js#L1306-L1318
As per RFC8216 the URI attribute is optional which we are forcing here https://github.com/shaka-project/shaka-player/blob/main/lib/hls/hls_parser.js#L1795-L1796 Not sure but that's all what I could find.
  The URI attribute of the EXT-X-MEDIA tag is REQUIRED if the media
   type is SUBTITLES, but OPTIONAL if the media type is VIDEO or AUDIO.
   If the media type is VIDEO or AUDIO, a missing URI attribute
   indicates that the media data for this Rendition is included in the
   Media Playlist of any EXT-X-STREAM-INF tag referencing this
   EXT-X-MEDIA tag.  If the media TYPE is AUDIO and the URI attribute is
   missing, clients MUST assume that the audio data for this Rendition
   is present in every video Rendition specified by the EXT-X-STREAM-INF
   tag.

@theodab can you review it?

@WINOFFRG can you provide a public url? Thanks!

Hi! Sorry I don't have any public sample at the moment. However I can share it with you over Slack if that's okay with you. However, it's Geo Restricted for India.

Public sample stream: https://s3.amazonaws.com/qa.jwplayer.com/~alex/121628/new_master.m3u8

Yes this is similar, The issue is same here tags aren't parsed.

Hi! Any updates on this issue?