[Bug]: RuntimeError: Loading lora model failed

Your current environment
$ python collect_env.py
Collecting environment information...
PyTorch version: 2.2.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Debian GNU/Linux 11 (bullseye) (x86_64)
GCC version: (Debian 10.2.1-6) 10.2.1 20210110
Clang version: Could not collect
CMake version: version 3.18.4
Libc version: glibc-2.31

Python version: 3.10.13 | packaged by conda-forge | (main, Dec 23 2023, 15:36:39) [GCC 12.3.0] (64-bit runtime)
Python platform: Linux-5.10.0-28-cloud-amd64-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 12.1.105
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA L4
Nvidia driver version: 535.86.10
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Byte Order:                         Little Endian
Address sizes:                      46 bits physical, 48 bits virtual
CPU(s):                             12
On-line CPU(s) list:                0-11
Thread(s) per core:                 2
Core(s) per socket:                 6
Socket(s):                          1
NUMA node(s):                       1
Vendor ID:                          GenuineIntel
CPU family:                         6
Model:                              85
Model name:                         Intel(R) Xeon(R) CPU @ 2.20GHz
Stepping:                           7
CPU MHz:                            2200.204
BogoMIPS:                           4400.40
Hypervisor vendor:                  KVM
Virtualization type:                full
L1d cache:                          192 KiB
L1i cache:                          192 KiB
L2 cache:                           6 MiB
L3 cache:                           38.5 MiB
NUMA node0 CPU(s):                  0-11
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:             Mitigation; Enhanced IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt clwb avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves arat avx512_vnni md_clear arch_capabilities

Versions of relevant libraries:
[pip3] numpy==1.24.4
[pip3] torch==2.2.0
[pip3] torchvision==0.17.0
[pip3] triton==2.2.0
[conda] numpy                     1.24.4                   pypi_0    pypi
[conda] torch                     2.2.0                    pypi_0    pypi
[conda] torchvision               0.17.0                   pypi_0    pypi
[conda] triton                    2.2.0                    pypi_0    pypiROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: N/A
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      0-11            N/A             N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

🐛 Describe the bug
I am trying to load LoRA model and getting error.
Docker Cmd:
docker run --runtime nvidia --gpus all -p 8000:8000 --env "HUGGING_FACE_HUB_TOKEN=<SNIP>" vllm/vllm-openai --model="mistralai/Mistral-7B-v0.1" --dtype auto --tensor-parallel-size 1  --gpu-memory-utilization 0.9 --max-model-len 4096 --enable-lora --lora-modules ai-lora="ai-maker-space/mistral7b_instruct_generation"

Docker logs
$ docker run --runtime nvidia --gpus all -p 8000:8000 --env "HUGGING_FACE_HUB_TOKEN=SNIP" vllm/vllm-openai --model="mistralai/Mistral-7B-v0.1" --dtype auto --tensor-parallel-size 1  --gpu-memory-utilization 0.9 --max-model-len 4096 --enable-lora --lora-modules ai-lora="ai-maker-space/mistral7b_instruct_generation"
INFO 04-03 03:46:22 api_server.py:228] args: Namespace(host=None, port=8000, allow_credentials=False, allowed_origins=['*'], allowed_methods=['*'], allowed_headers=['*'], api_key=None, served_model_name=None, lora_modules=[LoRA(name='ai-lora', local_path='ai-maker-space/mistral7b_instruct_generation')], chat_template=None, response_role='assistant', ssl_keyfile=None, ssl_certfile=None, root_path=None, middleware=[], model='mistralai/Mistral-7B-v0.1', tokenizer=None, revision=None, code_revision=None, tokenizer_revision=None, tokenizer_mode='auto', trust_remote_code=False, download_dir=None, load_format='auto', dtype='auto', kv_cache_dtype='auto', max_model_len=4096, worker_use_ray=False, pipeline_parallel_size=1, tensor_parallel_size=1, max_parallel_loading_workers=None, block_size=16, seed=0, swap_space=4, gpu_memory_utilization=0.9, max_num_batched_tokens=None, max_num_seqs=256, max_paddings=256, disable_log_stats=False, quantization=None, enforce_eager=False, max_context_len_to_capture=8192, disable_custom_all_reduce=False, enable_lora=True, max_loras=1, max_lora_rank=16, lora_extra_vocab_size=256, lora_dtype='auto', max_cpu_loras=None, device='auto', engine_use_ray=False, disable_log_requests=False, max_log_len=None)
INFO 04-03 03:46:23 llm_engine.py:87] Initializing an LLM engine with config: model='mistralai/Mistral-7B-v0.1', tokenizer='mistralai/Mistral-7B-v0.1', tokenizer_mode=auto, revision=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.bfloat16, max_seq_len=4096, download_dir=None, load_format=auto, tensor_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=False, kv_cache_dtype=auto, device_config=cuda, seed=0)
INFO 04-03 03:46:27 weight_utils.py:163] Using model weights format ['*.safetensors']
INFO 04-03 03:47:14 llm_engine.py:357] # GPU blocks: 2796, # CPU blocks: 2048
INFO 04-03 03:47:16 model_runner.py:684] Capturing the model for CUDA graphs. This may lead to unexpected consequences if the model is not static. To run the model in eager mode, set 'enforce_eager=True' or use '--enforce-eager' in the CLI.
INFO 04-03 03:47:16 model_runner.py:688] CUDA graphs can take additional 1~3 GiB memory per GPU. If you are running out of memory, consider decreasing `gpu_memory_utilization` or enforcing eager mode. You can also reduce the `max_num_seqs` as needed to decrease memory usage.
INFO 04-03 03:47:23 model_runner.py:756] Graph capturing finished in 7 secs.
WARNING 04-03 03:47:23 serving_chat.py:306] No chat template provided. Chat API will not work.
INFO:     Started server process [1]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)

No chat template is defined for this tokenizer - using the default template for the LlamaTokenizerFast class. If the default is not appropriate for your model, please set `tokenizer.chat_template` to an appropriate template. See https://huggingface.co/docs/transformers/main/chat_templating for more information.

INFO:     <IP_ADDRESS>:53067 - "POST /v1/chat/completions HTTP/1.1" 200 OK
INFO 04-03 03:47:27 async_llm_engine.py:436] Received request cmpl-dff142a30da3480595415f23d9eba52b: prompt: '<s>[INST] What does following alerts says and how do you resolve this alert? <IP_ADDRESS> interface xe-0/0/0 is transitioning carrier states [/INST]', prefix_pos: None,sampling_params: SamplingParams(n=1, best_of=1, presence_penalty=0.0, frequency_penalty=0.0, repetition_penalty=1.0, temperature=0.7, top_p=1.0, top_k=-1, min_p=0.0, seed=None, use_beam_search=False, length_penalty=1.0, early_stopping=False, stop=[], stop_token_ids=[], include_stop_str_in_output=False, ignore_eos=False, max_tokens=4048, logprobs=None, prompt_logprobs=None, skip_special_tokens=True, spaces_between_special_tokens=True), prompt_token_ids: [1, 1, 733, 16289, 28793, 1824, 1235, 2296, 389, 9916, 2627, 304, 910, 511, 368, 11024, 456, 10977, 28804, 28705, 28740, 28734, 28723, 28770, 28781, 28723, 28781, 28723, 28783, 28783, 4971, 1318, 28706, 28733, 28734, 28748, 28734, 28748, 28734, 349, 8265, 288, 20320, 4605, 733, 28748, 16289, 28793], lora_request: LoRARequest(lora_name='ai-lora', lora_int_id=1, lora_local_path='ai-maker-space/mistral7b_instruct_generation').
INFO 04-03 03:47:27 async_llm_engine.py:133] Aborted request cmpl-dff142a30da3480595415f23d9eba52b.
Exception in callback functools.partial(<function _raise_exception_on_finish at 0x7f7a41870160>, request_tracker=<vllm.engine.async_llm_engine.RequestTracker object at 0x7f7a3775ad10>)
handle: <Handle functools.partial(<function _raise_exception_on_finish at 0x7f7a41870160>, request_tracker=<vllm.engine.async_llm_engine.RequestTracker object at 0x7f7a3775ad10>)>
Traceback (most recent call last):
  File "/workspace/vllm/lora/worker_manager.py", line 139, in _load_lora
    lora = self._lora_model_cls.from_local_checkpoint(
  File "/workspace/vllm/lora/models.py", line 214, in from_local_checkpoint
    raise ValueError(f"{lora_dir} doesn't contain tensors")
ValueError: ai-maker-space/mistral7b_instruct_generation doesn't contain tensors

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/workspace/vllm/engine/async_llm_engine.py", line 29, in _raise_exception_on_finish
    task.result()
  File "/workspace/vllm/engine/async_llm_engine.py", line 414, in run_engine_loop
    has_requests_in_progress = await self.engine_step()
  File "/workspace/vllm/engine/async_llm_engine.py", line 393, in engine_step
    request_outputs = await self.engine.step_async()
  File "/workspace/vllm/engine/async_llm_engine.py", line 189, in step_async
    all_outputs = await self._run_workers_async(
  File "/workspace/vllm/engine/async_llm_engine.py", line 276, in _run_workers_async
    all_outputs = await asyncio.gather(*coros)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/workspace/vllm/worker/worker.py", line 223, in execute_model
    output = self.model_runner.execute_model(seq_group_metadata_list,
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/workspace/vllm/worker/model_runner.py", line 574, in execute_model
    self.set_active_loras(lora_requests, lora_mapping)
  File "/workspace/vllm/worker/model_runner.py", line 660, in set_active_loras
    self.lora_manager.set_active_loras(lora_requests, lora_mapping)
  File "/workspace/vllm/lora/worker_manager.py", line 112, in set_active_loras
    self._apply_loras(lora_requests)
  File "/workspace/vllm/lora/worker_manager.py", line 224, in _apply_loras
    self.add_lora(lora)
  File "/workspace/vllm/lora/worker_manager.py", line 231, in add_lora
    lora = self._load_lora(lora_request)
  File "/workspace/vllm/lora/worker_manager.py", line 150, in _load_lora
    raise RuntimeError(
RuntimeError: Loading lora ai-maker-space/mistral7b_instruct_generation failed

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "uvloop/cbhandles.pyx", line 63, in uvloop.loop.Handle._run
  File "/workspace/vllm/engine/async_llm_engine.py", line 38, in _raise_exception_on_finish
    raise exc
  File "/workspace/vllm/engine/async_llm_engine.py", line 33, in _raise_exception_on_finish
    raise AsyncEngineDeadError(
vllm.engine.async_llm_engine.AsyncEngineDeadError: Task finished unexpectedly. This should never happen! Please open an issue on Github. See stack trace above for the actual cause.
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 264, in __call__
    await wrap(partial(self.listen_for_disconnect, receive))
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 260, in wrap
    await func()
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 237, in listen_for_disconnect
    message = await receive()
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/protocols/http/httptools_impl.py", line 580, in receive
    await self.message_event.wait()
  File "/usr/lib/python3.10/asyncio/locks.py", line 214, in wait
    await fut
asyncio.exceptions.CancelledError: Cancelled by cancel scope 7f7a0af8e8c0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/protocols/http/httptools_impl.py", line 419, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
    return await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/fastapi/applications.py", line 1054, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/applications.py", line 123, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/errors.py", line 186, in __call__
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/errors.py", line 164, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/cors.py", line 83, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/exceptions.py", line 62, in __call__
    await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 758, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 778, in app
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 299, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 79, in app
    await wrap_app_handling_exceptions(app, request)(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/_exception_handler.py", line 64, in wrapped_app
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/_exception_handler.py", line 53, in wrapped_app
    await app(scope, receive, sender)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 77, in app
    await response(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/responses.py", line 257, in __call__
    async with anyio.create_task_group() as task_group:
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 678, in __aexit__
    raise BaseExceptionGroup(
exceptiongroup.ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
INFO 04-03 03:47:33 metrics.py:213] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 0.0 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 0.1%, CPU KV cache usage: 0.0%
^CINFO:     Shutting down
INFO:     Waiting for application shutdown.
INFO:     Application shutdown complete.
INFO:     Finished server process [1]

Application Code:
from openai import OpenAI

openai_api_key = "EMPTY"
openai_api_base = "http://[domain]:8000/v1"

client = OpenAI(
  api_key=openai_api_key,
  base_url=openai_api_base,
)

chat_completion = client.chat.completions.create(
messages=[{
  "role": "assistant",
  "content": "You are a networking expert.",
  "role": "user",
  "content": "What does following alerts says and how do you resolve this alert? <IP_ADDRESS> interface xe-0/0/0 is transitioning carrier states"
}],
model="ai-lora",
stream=True
)

for chunk in chat_completion:
  print(chunk.choices[0].delta.content, end="")

App logs:
 python3 chat.py                                                                                 29s  08:47:13 PM
NoneTraceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_exceptions.py", line 10, in map_exceptions
    yield
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 209, in _receive_event
    event = self._h11_state.next_event()
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/h11/_connection.py", line 469, in next_event
    event = self._extract_next_receive_event()
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/h11/_connection.py", line 419, in _extract_next_receive_event
    event = self._reader.read_eof()  # type: ignore[attr-defined]
            ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/h11/_readers.py", line 204, in read_eof
    raise RemoteProtocolError(
h11._util.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_transports/default.py", line 66, in map_httpcore_exceptions
    yield
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_transports/default.py", line 110, in __iter__
    for part in self._httpcore_stream:
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_sync/connection_pool.py", line 347, in __iter__
    for part in self._stream:
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 337, in __iter__
    raise exc
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 329, in __iter__
    for chunk in self._connection._receive_response_body(**kwargs):
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 198, in _receive_response_body
    event = self._receive_event(timeout=timeout)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_sync/http11.py", line 208, in _receive_event
    with map_exceptions({h11.RemoteProtocolError: RemoteProtocolError}):
  File<EMAIL_ADDRESS>line 158, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/opt/homebrew/lib/python3.11/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
    raise to_exc(exc) from exc
httpcore.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/aniket/Desktop/DemoS2LLM/chat.py", line 23, in <module>
    for chunk in chat_completion:
  File "/opt/homebrew/lib/python3.11/site-packages/openai/_streaming.py", line 44, in __iter__
    for item in self._iterator:
  File "/opt/homebrew/lib/python3.11/site-packages/openai/_streaming.py", line 56, in __stream__
    for sse in iterator:
  File "/opt/homebrew/lib/python3.11/site-packages/openai/_streaming.py", line 48, in _iter_events
    yield from self._decoder.iter(self.response.iter_lines())
  File "/opt/homebrew/lib/python3.11/site-packages/openai/_streaming.py", line 224, in iter
    for line in iterator:
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_models.py", line 857, in iter_lines
    for text in self.iter_text():
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_models.py", line 844, in iter_text
    for byte_content in self.iter_bytes():
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_models.py", line 823, in iter_bytes
    for raw_bytes in self.iter_raw():
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_models.py", line 881, in iter_raw
    for raw_stream_bytes in self.stream:
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_client.py", line 123, in __iter__
    for chunk in self._stream:
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_transports/default.py", line 109, in __iter__
    with map_httpcore_exceptions():
  File<EMAIL_ADDRESS>line 158, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/opt/homebrew/lib/python3.11/site-packages/httpx/_transports/default.py", line 83, in map_httpcore_exceptions
    raise mapped_exc(message) from exc
httpx.RemoteProtocolError: peer closed connection without sending complete message body (incomplete chunked read)

Do I need to convert the Lora output to a particular format?
I see following error
ValueError: ai-maker-space/mistral7b_instruct_generation doesn't contain tensors

Me too, I finetuned gemma-2b-it on ['q_proj', 'o_proj', 'k_proj', 'v_proj', 'gate_proj', 'up_proj', 'down_proj', 'lm_head'], then when I use vllm to infer, vllm raise RuntimeError: Loading lora ./xxx/checkpoint-16250 failed.


Attempts to fix ACME plugin

The acme plugin in master does not work. This PR attempts
to fix it. After several hours I have not succeeded in getting
a succesful letsencrypt cert but I got to the point where I
had no more exceptions and just got
[2016-09-02 07:34:25 +0000] [19] [CRITICAL] WORKER TIMEOUT (pid:30)
Because I spent so long on it (partially for want of any other recent
python experience) I wanted to get my changes out there
I am curious if @kevgliss has a branch with some of these fixes that
just hasn't made its way into master yet
This PR is a superset of #419 because that change (or a simpler one
to compensate for lack of explicit account_number decleration) is
needed to get even this close to working

It also pulls in the github sourced acme-0.9.0dev0 because the last release on pypi doesn't have code for the DNS01 challenge.

The error WORKER TIMEOUT would imply that Letsencrypt is simply taking too long to verify our domain and the worker thread is timing out. We could experiment with increasing the timeout of the thread.
Unfortunately Lemur was originally designed to work with synchronous certificate APIs (organizational validation). This means for async APIs (like letsencrypt) that take upwards of minutes or more to validate we run in to timeouts.
Thinking about it more, if we wanted to support the async use-case correctly we would most likely define a new plugin type issuer-async that would then have some pickup logic. This isn't on our near term roadmap as all of our issuers are synchronous in nature.


401 unauthorized - custom callback

Hi, plugin works well, thanks for your strategy!
If there is any possibility to callback some action on token revoke? I want to compare it against refresh token and allow to recreate access token instead of throwing 401.
If not, could you let me know where should i start looking for modifying your strategy to fit my needs?
Thanks.

I think you're looking for the Custom Callback functionality of the Passport module.
The strategy only validates the JWT, passport provides that ability to take custom actions based on the results of the strategies validation.
Hopefully this helps.

Closing for now, if I'm missing something and you think the module doesn't give enough information about the reason for the failure for you to take the necessary steps in a custom callback let me know and we can revisit this.


changed the Float buffer to read from right instead of left

Don't forget to update the readme in the holodeck repo :)

https://github.com/BYU-PCCL/holodeck/issues/431


DO NOT MERGE Validate uncommitted test

Tests that #17 does not break Travis. This should fail in (make validate).

Failed as expected:
docker run --rm -i  -t "skopeo-dev:HEAD" hack/make.sh validate-git-marks validate-gofmt validate-lint validate-vet
---> Making bundle: validate-git-marks
There is trace of conflict(s) in the following files :
 - cmd/skopeo/main.go


Merge develop into master

Pull Request Test Coverage Report for Build 56

0 of 27 (0.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-20.0%) to 13.333%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/me/tobiadeyinka/beam/Beam.java
0
1
0.0%

src/main/java/me/tobiadeyinka/beam/database/DatabaseManager.java
0
1
0.0%

src/main/java/me/tobiadeyinka/beam/entities/Podcast.java
0
25
0.0%

Totals

Change from base Build 46:
-20.0%

Covered Lines:
6

Relevant Lines:
45

💛  - Coveralls


Add basic tests.

Pull Request Test Coverage Report for Build 703103772

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.7%) to 32.275%

Totals

Change from base Build 703080387:
7.7%

Covered Lines:
90

Relevant Lines:
267

💛  - Coveralls


Programming exercises: Display error message for title and shortname conflicts on localVCS

Checklist
General

[x] This is a small issue that I tested ~on a test server~ locally.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I strictly followed the server coding and design guidelines.
[x] I documented the Java code using JavaDoc style.

Client

[x] I strictly followed the client coding and design guidelines.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context
In a previous Artemis version (7.0.3 right now), it was possible that when an error occurred during creating/importing/deleting a programming exercise the respective folders for that programming exercise were not cleaned up.
This means that the short names that are related to the folder names stay blocked, however, there was no error message shown in this case, for the blocked short names.
Description

This PR adds adjusts the error message thrown from the server, so that the client displays an alert.
adds translations for error message on validation of programming exercise title and short title
adds a scroll to top when saving course details

Steps for Testing Locally
Prerequisites:

1 Instructor

Create a programming exercise with title and short name "blockedShortName"
See that in local-vcs-repos and repos a folder coursePrefix + BLOCKEDSHORTNAME will be created
Duplicate the folder from step 2 in local-vcs-repos and rename it to coursePrefix + BLOCKEDSHORTNAME1
Try to import a programming exercise with the shortname coursePrefix + BLOCKEDSHORTNAME1 and see that an error message is displayed that explains that the shortname is already taken

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress
Code Review

[x] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Screenshots
Now using actual translations instead of hardcoded english messages

The failing server LocalVCIntegrationTest testUserTriesToDeleteBranch() test is flaky

code lgtm!


Could Carla export simulation data like *.mp4 or some sensor data?

I found that Carla could retrieve data to *.log, and then we could read the *.log using Carla API.
But, I am trying to export video (for example *.mp4) and sensor (radar) data from Carla simulation environment. And then these data could be fed into our own algorithms.
Does Carla support this?
Thank you.

Hi
CARLA exports images in formats such as PNG, not to video formats, but it's simple to convert an image sequence to a video using a number of open source or free tools. Refer to the example scripts supplied with CARLA (such as tutorial.py) to see how the sensors output data. The sensors have a "listen" function which takes a callback to save the data on each simulation step. The image sequence is then saved to a folder on your hard drive. You can then convert this image sequence to video using another tool such as QuickTime.
Thanks for your question


Setup for tensor class... prepare for the operations incoming!!!

Setup for tensor

checked with jon on discord


No right window insets on landscape mode

About this issue
If the edgeToEdgeMode and the landscape mode are enabled, it looks like this:

I don't think, this should be this way. The right side gets cropped off.
Details

[X] Used library version: 8.1.3
[X] Device: Google Pixel 3a
[X] Gradle plugin version: 4.0.0
[X] AS version 4.0

Checklist

[X] Searched for similar issues
[X] Checked out the sample application
[X] Read the README
[X] Checked out the CHANGELOG
[X] Read the MIGRATION GUIDE

Thanks for fixing!

uploading v8.1.6 right now.
Thanks for reporting.


An error shown if to clear conversation messages while response is generating

EPAM AI DIAL chat version
0.6.19
What happened?
Steps:
1 Start chat with any model
2 Send several messages
3 Send a request that suppose a long response
4 Press 'Clear conversation messages' button in the chat header while response is generating
5 Refresh page
Actual result: last request is preserved, error is shown
Expected result: all messages are removed, conversation settings popup is shown

Confidential information

[X] I confirm that do not share any confidential information

For DIal RAG:
Steps:

create a request to model
while model responding , click "clear conversation messages" icon on the top
confirm deletion

Actual result

Request and response were removed,
main form for selecting model is displayed
user can not select any other conversation on side panel

https://github.com/epam/ai-dial-chat/assets/77381071/6c01568f-bb86-492e-a51c-81b2e3333f84
NOTE: for Palm model side panel is not blocked
Expected result
"clear conversation messages" should bit be available during model response generation

verified on staging successfully


Preserve state of settings accordion panels upon form submit/refresh

From tech call 31 December:
"In Settings, on save, may want to continue to show the section(s) that was last open. i.e., if you’ve just added category weighting, you might want to see that right after you saved it."

Confirmed.


CALENDAR: start view month is not working

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
StackBlitz link:  https://stackblitz.com/edit/gmbffs-5g3jqc?file=src%2Fexample%2Fdate-range-picker-forms-example.html
Steps to reproduce:

I have configured start view as month, but it is not showing month view

Reproduction
StackBlitz link:  https://stackblitz.com/edit/gmbffs-5g3jqc?file=src%2Fexample%2Fdate-range-picker-forms-example.html
Steps to reproduce:

I have configured start view as month, but it is not showing month view

Expected Behavior
the month view should be displayed
Actual Behavior
the default view is only displayed for other views it is working, month has this problem.
Environment

Angular: ^19.0.0
CDK/Material:^19.0.0
Browser(s): Version 131.0.6778.86 (Official Build) (64-bit)
Operating System (e.g. Windows, macOS, Ubuntu): Windows

What you're seeing is the month view. If you wanted to see the view with the individual months, you should use the startView="year".


[shape_poly] Update arange and image_resize to support shape polymorphism

Bug: #8367
Small refactoring to jax.image.resize to make it compatible with
shape polymorphismin jax2tf. In the process added also support for
jnp.arange([dim_poly]). Note that the underlying lax.iota already
supported shape polymorphism.

I agree the numerical change is a problem, will look into it.

Drop in favor of #8569

The change looks fine, but the test failure looks concerning. Why did we get a numerical difference?

The change was correct but triggered an XLA compilation error (bad result). I filed XLA bug b/206898375. Previously this was not an issue because we were doing the computations in question using numpy, now we do them with jax.numpy. I added a workaround here.


[Epic]: Improve Chart Experience

Objective
Improve customer experience while using Chart Widget.
Relevant PRD and discussions are here.

https://www.notion.so/appsmith/Chart-widget-replace-fusion-charts-d04099471dda4f7286ae2f2fa980a7b7?pvs=4

Below details will be filled gradually.
Success Metrics

Metric

Customer satisfaction score increases

Decrease churn rate down to 30%

Prioritised User Stories

User Story

e.g. as a user, I want to be able to access the platform via mobile phone

e.g as a user, I want to be able to communicate with the other members on the canvas

Developer Handoff Document in Figma
No response
Test Plan
No response
RACI matrix

Role
People

Responsible

Accountable

Consulted
@Nikhil-Nandagopal, @mohanarpit, @areyabhishek

Informed

Migration of fusion charts to ECharts is complete now. Marking this epic as complete now.


How to install Datuture Hub

After running requirements.txt:
ERROR: Could not find a version that satisfies the requirement datature-hub==0.2.0 (from versions: none) ERROR: No matching distribution found for datature-hub==0.2.0
When I tried installing datature-hub via pip install datature-hub https://pypi.org/project/datature-hub/ error =
ERROR: Could not find a version that satisfies the requirement datature-hub (from versions: none)
ERROR: No matching distribution found for datature-hub

Hey @getcontrol, may I know the current version of Python that you are using to install datature-hub? Thanks!

Apologies I missed this! Python v. 3.9


Center Pivot button, UI improvements

Added a "center pivot" button that sets the pivot point to the centroid of the shape (only works on closed shapes)
Replaced all instances of get_editor_interface() with the EditorInterface singleton
Changed button theme_type_variation to match similar button groups in the editor.
Changed one-off action buttons to not toggle
Replaced references to StaticBody2D with PhysicsBody2D to allow users to change the parent body node type

I'm fairly new to open source contributions, so if you have any feedback please let me know. Thanks for the plugin!

This PR initially aimed to improve the "set pivot" action. The idea was that if an SS2D_Shape is attached to a parent PhysicsBody2D, the tool would adjust the position of the PhysicsBody2D and set the SS2D_Shape's position to (0, 0). This adjustment is useful for users who often need to change the pivot point of the parent body managed by an SS2D_Shape for things like moving platforms.
While users can manually adjust the pivot and set the shape's position to (0, 0) in these situations, I think it's important to streamline these operations because the plugin is ultimately a level design tool. Any bit of friction in the user experience is worth minimizing where possible.
I think this change is outside the scope of this PR, but it's something worth considering in the future!


Library versioning

The cmake install script should install the shared library to libmimalloc.so.<ABI version> and point a symlink to libmimalloc.so, instead it just installs to the latter. It should also add execution bit to it (chmod 755 instead of 644).

Packaged it for Arch Linux: https://aur.archlinux.org/packages/mimalloc-git/

That is great -- thanks for packaging it! I'll look into how to create symlinks and set execution bits using cmake...

We need add SONAME to shared library for guarantee the compatibility of the abi


Update Visual Studio Code to support workspace files.

Reasons for making this change:
Visual Studio Code has a few files that can be placed into the workspace in order to share settings across users.  Settings.json is for project specific overrides.  Tasks.json is for executable tasks (build, gulp, etc.)  While launch.json is for debugging specific tasks.
Links to documentation supporting these rule changes:
Visual Studio Code home page:  https://code.visualstudio.com/
For settings.json:  https://code.visualstudio.com/docs/customization/userandworkspace
For tasks.json:  https://code.visualstudio.com/docs/editor/tasks
For launch.json:  https://code.visualstudio.com/docs/editor/debugging

@brennanfee thanks!


[BUG]: VolumeHealthMetricSuite test failure

Bug Description
VolumeHealthMetricSuite always fail . Following doc,  I have enabled controller and node  “healthMonitor”  parameter.
[root@registry ~]# cat csi-powerstore/cert/wr-certify-config.yaml
storageClasses:
- name: powerstore-ext4
minSize: 2Gi
rawBlock: false
RWX: false
VolumeHealth: true
RWOP: false
VGS: false
[root@registry ~]# cat csi-powerstore/cert/wr-certify-config.yaml
storageClasses:

name: powerstore-ext4
minSize: 2Gi
rawBlock: false
expansion: true
clone: true
snapshot: true
RWX: false
VolumeHealth: true
RWOP: false
VGS: false

[root@registry ~]# ./cert-csi certify --cert-config csi-powerstore/cert/wr-certify-config.yaml  --vsc powerstore-snapshot --vgs-volume-label wrvgslabel --driver-name csi-powerstore --vgs-name wrvgs --path csi-powerstore/cert/ --sequential -l 5
[2023-07-29 01:56:07]  INFO Starting cert-csi; ver. 0.8.1
[2023-07-29 01:56:07]  INFO Suites to run with powerstore-ext4 storage class:
[2023-07-29 01:56:07]  INFO 1. ScalingSuite {replicas: 2, volumes: 5, volumeSize: 2Gi}
[2023-07-29 01:56:07]  INFO 2. VolumeHealthMetricSuite {pods: 1, volumes: 1, size: 2Gi}
Does it look OK? (Y)es/(n)Y
… …
[2023-07-29 01:56:56]  INFO Starting VolumeHealthMetricSuite with powerstore-ext4 storage class
[2023-07-29 01:56:56]  INFO Successfully created namespace volume-health-metrics-74bd6cd2
[2023-07-29 01:56:56]  INFO Waiting for all pods in volume-health-metrics-74bd6cd2 to be READY
[2023-07-29 01:57:04]  INFO All pods are ready in 8.012472857s
[2023-07-29 01:57:06]  INFO Deleting all resources in namespace volume-health-metrics-74bd6cd2
[2023-07-29 01:57:20]  INFO Namespace volume-health-metrics-74bd6cd2 was deleted in 14.07634887s
[2023-07-29 01:57:21] ERROR suite VolumeHealthMetricSuite failed; error=exit status 1
[2023-07-29 01:57:21]  INFO FAILURE: VolumeHealthMetricSuite in 25.0916706s
Logs
Error.log
{"level":"error","msg":"suite VolumeHealthMetricSuite failed; error=exit status 1","time":"2023-07-28 12:51:28"}
{"level":"error","msg":"suite VolumeHealthMetricSuite failed; error=exit status 1","time":"2023-07-28 12:52:38"}
{"level":"error","msg":"no ResourceUsageMetrics provided","time":"2023-07-28 12:52:44"}
{"level":"error","msg":"suite VolumeHealthMetricSuite failed; error=exit status 1","time":"2023-07-29 01:57:21"}
Screenshots
No response
Additional Environment Information
[root@registry ~]# kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.3", GitCommit:"9e644106593f3f4aa98f8a84b23db5fa378900bd", GitTreeState:"clean", BuildDate:"2023-03-15T13:40:17Z", GoVersion:"go1.19.7", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.4", GitCommit:"95ee5ab382d64cfe6c28967f36b53970b8374491", GitTreeState:"clean", BuildDate:"2022-08-17T18:47:37Z", GoVersion:"go1.18.5", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.26) and server (1.24) exceeds the supported minor version skew of +/-1
Steps to Reproduce

install csi-powerstore and enable node health check
execute
”/cert-csi certify --cert-config csi-powerstore/cert/wr-certify-config.yaml  --vsc powerstore-snapshot --vgs-volume-label wrvgslabel --driver-name csi-powerstore --vgs-name wrvgs --path csi-powerstore/cert/ --sequential -l 5”

Expected Behavior
the test pass
CSM Driver(s)
CSI powerstore 2.1
Installation Type
No response
Container Storage Modules Enabled
No response
Container Orchestrator
K8s 1.24.4
Operating System
debian 11

In order to run VolumeHealthMetricSuite; driver namespace must be passed in command line arguments. Correct syntax is
cert-csi functional-test volumehealthmetrics --sc <storage-class> --driver-ns <driver-namespace> --podNum <number-of-pods> --volNum <number-of-volumes>
Updated the same in CSM docs.


[Docenhancement][Frameratebots][3836]

Changed 30 FPS to variable frame rate.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/bots/calls-and-meetings/real-time-media-concepts.md
96
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 6b1994c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/bots/calls-and-meetings/real-time-media-concepts.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Script Name Variable Won't Apply

I am running this on Heroku, I added TRACKER_SCRIPT_NAME to my config vars, with the value viewcount and restarted all dyno's. Even after the restart the script doesn't work at the viewcount location.

In the current version you need to rebuild the app for it to apply, sorry. In the next release it should work at runtime as intended.

Fixed in v1.27.0


Bug 184: Pre-deployment script shows WARNING related to upcoming breaking change

Bug 184: Pre-deployment script shows WARNING related to upcoming breaking change
Based on the version 5.0.0, the password is changed to SecureString instead of string.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: haritsaxena sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Harun, there are some merge conflicts, Ignore my changes for this file configuringBackupADVM.json.


UI-8671 - Integrate SCB tree table column migration into the core

Summary
This PR cherry-picks the changes done for the SCB migration that allows them to adjust the size of the column on tree tables
Original PR

The cherry-pick looks good, however I am curious whether this solution was discussed directly with the client ? It seems odd to me to specify the same base width for all tables. And independently from that, on how many dashboards to they have the problem ? Is it just a few or hundreds ?

@antoinetissier I believe @Nouzbe discussed this more directly with the client, but because of the complexities of correctly calculating the width properly for all tree tables, we went with a more heuristic fix of allowing them to use the --tree-column-width argument to pass in whatever base width is necessary. You can see my comment on the ticket about it here.


Delegate clearFolder to library user

Just an idea, I think https://github.com/askiada/external-sort/blob/8a71574cb0791a63b202f639cf78e754bd4aa106/file/file.go#L42 is potentially dangerous.
What if the responsibility was completely offloaded to the user of the library?

Good point! The processing is creating chunk files. And we don't want to keep these when we are done. Also we don't want to process a potential chunk file from a previous run. I don't know what would be a better approach. Maybe to only remove files with chunk_*.csv pattern. So at least you don't remove other user files

I think that is a good alternative!
This could even be driven by a parameter or something, but prob a pattern is good enough with no extra development needed!


zabbix_sender is missing

Target machine is running Ubuntu 16.04.3 LTS
Package installed is ii  zabbix-agent                       1:3.0.11-1+xenial                          amd64
zabbix_sender isn't installed.  Do I need to set something to make that happen or is that a packaging problem?  Note: when I attempt to execute it I get:
The program 'zabbix_sender' is currently not installed. You can install it by typing:
apt install zabbix-agent
Which "is already the newest version" when I attempt to do so. :/

Hi, the package is zabbix-sender (and zabbix-get). But I'll add them in the list to be installed. Will create a PR.

Merged the PR, is available on github and somewhere in the coming days on the Galaxy.

zabbix_sender is still missing from packahe zabbix-agent (on Ubuntu 16.04)

Hi @mbalmer
As far as I see, the zabbix-sender is installed on the host when running the role. Is this not the case for you? If so, what version of the role are you using?

Am 25.03.2018 um 11:14 schrieb Werner Dijkerman<EMAIL_ADDRESS>Hi @mbalmer https://github.com/mbalmer
As far as I see, the zabbix-sender is installed on the host when running the role. Is this not the case for you? If so, what version of the role are you using?

I think this was a false alarm.  I got zabbix_sender up and running.  Please close the issue and sorry for the noise...

No worries mate!


Make Popover render only when needed

What this PR does / why we need it:
I set the KeepMounted option to false.
This will mount the DOM only when the menu is opened.
https://material-ui.com/api/modal/#props
Before

After

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice catch ⚾
/approve


Add LICENSE?

Do we want to add some license?
I'd suggest MIT license, which is quite standard from my experience. It ensures that we are not liable for any malfunction/damage done by using our package and we do not provide any warranty. The users are usually requested to cite the authors of this repository and the copyright notice.
More about licenses at choosealicense.com (by GitHub), or here.
Other examples:

Magpylib uses a BSD 2-Clause "Simplified" License (their license)
TetraX uses a GNU license (their license)

I agree. There is no problem from my side. Maybe @michalu1 @michalurb  can comment on this (as he is the most experience with this)?

I don't have much experience with this. But I like MIT license as it is short and understandable :-).

Ok, I have added a MIT license to the SWT_reformatted branch. I plan to do a pull request this evening (if everything goes well with other stuff).


Change/add icons

There are a few ui changes regarding icons in the new design.

Change icons in onboarding
Add icon to navbar in onboarding

https://projects.invisionapp.com/d/main?origin=v7#/console/22098616/468807390/preview

Done changing icons
Mostly done with button adjustments as well
https://github.com/pace/connectedfueling-app-android/tree/Change-add-icons

Done


dev server can't run with url endsWith file extensions

Describe the bug
Runs ok with normal url

Runs ok with filename url

and broken, when click  refresh button.

Reproduction
Every thing is ok in production .
Hard to Reproduction in online.

export default defineConfig(({command}) => {
    return {
    resolve: {
        alias: {
            '@ezone': path.resolve(__dirname, 'node_modules/@ezone'),
            '@': path.resolve(__dirname, 'src'),
            '～@': path.resolve(__dirname, 'src'),
            ...(command === 'serve' ? npmLinkPaths : {}),
        },
    },
    envPrefix: 'REACT_APP',
    esBuild: {
        exclude: ['node_modules'],
        jsxInject: 'import React from \'react\'',
    },
    build: {
        outDir: 'build',
        assetsDir: 'static',
        sourcemap: false,
        rollupOptions: {
            output: {
                manualChunks(id) {
                    if (id.includes('monaco')) {
                        return 'editor';
                    }
                    if (id.includes('prose') || id.includes('markdown')) {
                        return 'markdownEditor';
                    }
                    if (id.includes('aliIcon')) {
                        return 'aliIcon';
                    }
                },
            },
        },
    },
    css: {
        preprocessorOptions: {
            less: {
                modifyVars,
                javascriptEnabled: true,
            },
        },
    },
    optimizeDeps: {
        include: ['lodash'],
    },
    plugins: allPlugins,
    server: {
        https: process.env.REACT_APP_HTTPS,
        watch: {
            followSymlinks: true,
        },
        proxy: {
            '/v1': {
                target: apiProxy,
                logLevel: 'debug',
                changeOrigin: true,
            },
            '/socket.io': {target: wsProxy, ws: true, changeOrigin: true},
        },
    },
};
});

System Info
System:
    OS: macOS 10.15.7
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 640.63 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.17.6 - /usr/local/bin/node
    Yarn: 1.17.0 - /usr/local/bin/yarn
    npm: 6.14.15 - /usr/local/bin/npm
  Browsers:
    Chrome: 94.0.4606.71
    Firefox: 92.0
    Safari: 14.0.3
  npmPackages:
    @vitejs/plugin-react-refresh: ^1.3.6 => 1.3.6
    vite: ^2.5.6 => 2.5.10

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

In addition:

localhost:8080/some.route.dots browser returns 404.
localhost:8080/some.route.dots/settings works.

duplicate of #2415


PCE buttons 4 and 6 not working

I received Humble's updated BT adapter and tested again with my Retro-Bit Genesis 6 button controller. Dpad now works correctly as do all buttons except buttons 4 and 6 (Genesis X and Z). They don't work at all. Tested in game and in two different PCE controller test utilities.

I was able to fix this by setting source as Switch MD/Genesis and dest as PCE 6 button controller then manually re-mapping Select. Closing issue.


Inconsistency in username properties across resources

There is an inconsistency in the username properties for the resources. For the zookeeper and zookeeper_service resources the property is username, while for the zookeeper_config resources it is user.

Good point.
I’ve been thinking of collapsing these into a single resource; any thoughts on that?

Regardless of whether they are collapsed together, or not, this will be a breaking change. I’m working on dropping Chef 14 support anyway in #225, so I’ll handle this then, too.


💭 Failed to initialize VisionCamera: VisionCamera currently does not work on web.

Question

when open on the web. There is a error! The Error: Failed to initialize VisionCamera: VisionCamera currently does not work on web.
It appears to initialize VisionCamera in the web environment as well.
How to resolve, or How to do without initializing VisionCamera in a web environment?
What I tried

I try to use Platform API to resolve it, but it don't work
VisionCamera Version
^3.9.2
Additional information

[X] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

I'm also facing this issue, and currently the only workaround I can think of is using JS dynamic imports to try catch loading the module.
If the package could at least provide a No-op VisionCamera implementation for web that returns null devices or fails on call rather than on import, that could be a potential temporary solution.

As the error message states, VisionCamera does not work on Web.
I am not using Web myself, so I've never seen that error before.
For Web, you should use web camera APIs instead.

We also encountered the same issue, and we resolved it by applying patches to react-native-vision-camera and react-native-worklets-core as follows. Please refer to the following for your reference.
react-native-vision-camera+4.3.2.patch
diff --git a/node_modules/react-native-vision-camera/lib/commonjs/index.web.js b/node_modules/react-native-vision-camera/lib/commonjs/index.web.js

new file mode 100644

index 0000000..b92811b

--- /dev/null

+++ b/node_modules/react-native-vision-camera/lib/commonjs/index.web.js

@@ -0,0 +1,5 @@

+'use strict';

+

+Object.defineProperty(exports, '__esModule', {

+ value: true,

+});

diff --git a/node_modules/react-native-vision-camera/lib/module/index.web.js b/node_modules/react-native-vision-camera/lib/module/index.web.js

new file mode 100644

index 0000000..e69de29

react-native-worklets-core+1.3.3.patch
diff --git a/node_modules/react-native-worklets-core/lib/commonjs/index.web.js b/node_modules/react-native-worklets-core/lib/commonjs/index.web.js

new file mode 100644

index 0000000..db7129b

--- /dev/null

+++ b/node_modules/react-native-worklets-core/lib/commonjs/index.web.js

@@ -0,0 +1,5 @@

+"use strict";

+

+Object.defineProperty(exports, "__esModule", {

+ value: true,

+});

diff --git a/node_modules/react-native-worklets-core/lib/module/index.web.js b/node_modules/react-native-worklets-core/lib/module/index.web.js

new file mode 100644

index 0000000..e69de29


While importing load_dataset from datasets

Describe the bug
cannot import name 'DEFAULT_CIPHERS' from 'urllib3.util.ssl_' this is the error i received
Steps to reproduce the bug
from datasets import load_dataset
Expected behavior
No errors
Environment info
python 3.11.5

Hi! Can you please share the error's stack trace so we can see where it comes from?

We cannot reproduce the issue and we do not have enough information: environment info (need to run datasets-cli env), stack trace,...
I am closing the issue. Feel free to reopen it (with additional information) if the problem persists.

Yeah 👍
On Tue, 6 Feb 2024 at 2:56 PM, Albert Villanova del Moral <
@.***> wrote:

We cannot reproduce the issue and we do not have enough information:
environment info (need to run datasets-cli env), stack trace,...
I am closing the issue. Feel free to reopen it (with additional
information) if the problem persists.
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/datasets/issues/6618#issuecomment-1929102334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASS4PJ3XOIIWISPY3VX3QRTYSHZK5AVCNFSM6AAAAABCL3BT4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGEYDEMZTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Please downgrade the version of urllib3 if you have the same issue:
!pip install urllib3==1.25.11

Please downgrade the version of urllib3 if you have the same issue:
!pip install urllib3==1.25.11

This worked for me. Thanks.
I use python 3.11 and datasets==2.20.0. Downgrading urllib3 to 1.25.11 worked in my case.


importerror: cannot import name pod

Your panda3d needs the old POD module.
https://github.com/panda3d/panda3d/commit/88dbb31daa02779405ef5326677eefb5cf93f3c8
You can re-add it and add the name to the python util.

Find your PythonUtil.py file, mine was in C:/Python27/Lib/site-packages/direct/showbase. Im using the panda3d pip installation on the newest(old) 2.7 Python.
In the end i had to add 4 different names to the top of the file 'POD', 'ParamObj', 'clampScalar', 'pivotScalar',
They need their respective defs which can be found in the old PythonUtil.py, link provided by C0MPU73R in the previous comment. Find in page each of the four names and copy their respective defs to your PythonUtil.py. It was able to import POD and the others for me after that.

i was able to get all that working and quite a few more modules but came to crossroad with urllib3

Find your PythonUtil.py file, mine was in C:/Python27/Lib/site-packages/direct/showbase. Im using the panda3d pip installation on the newest(old) 2.7 Python. In the end i had to add 4 different names to the top of the file 'POD', 'ParamObj', 'clampScalar', 'pivotScalar', They need their respective defs which can be found in the old PythonUtil.py, link provided by C0MPU73R in the previous comment. Find in page each of the four names and copy their respective defs to your PythonUtil.py. It was able to import POD and the others for me after that.

i was able to get all that working and quite a few more modules but came to crossroad with urllib3
i also tried many different versions of it. idk how to ask but would you or someone
provide me a working python or panda3d for potco. also sorry for late reply


chore: bump dependencies

Summary of changes

Changes introduced in this pull request:

bumped the dependencies which resolves some automated security vulnerabilities - long term, cargo audit should be in place as outlined in https://github.com/ChainSafe/forest-explorer/issues/73

Reference issue to close (if applicable)

Closes
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),

Oof, some of our version bounds gotta be off.

Oops!


Minor Change (Spelling): Correct spelling of parameter

@gordicaleksa I would really appreciate it if you could review this PR


Toggling shape keys?

Hi! Thanks for putting this project for others to use!
I have a VRM model based on Victoria which supports Shape Keys.
Here you can see the lid - which can be toggled - closed:

And opend:

When I load this model using this demo project, the lid is starts open, it then closes, and opens just to stay always open. I have a working VRM file exported from blender, which loads fine (lid closed) using the dnd demo of three-vrm .
So I am guessing that ,  when you load the model the shape key is somehow toggled. Can you maybe give me a hint?

this demo appends entire scene definition from a VRM file (vrm.scene), not just vrm model itself (vrm.humanoid)
(and if some other demo app doesn't append entire scene, but only model itself then animations don't get loaded)
vrm = await loadVRM(model); // load vrm model
scene.add(vrm.scene); // add model to scene
if (!vrm.humanoid) return;

so its most likely that VRM model you're using has some animations pre-set along VRM model itself
you can either
a) remove them in blender and save vrm model without them or
b) delete them after vrm file is loaded and before its appended to scene or
c) disable them in scene itself once they are loaded

closing as its not a product issue, but feel free to post further on this thread with any additional questions.


Fresh Vue + Webpack app not generating image file on Windows 7

Steps (on Windows 7):

vue cli webpack myApp
npm install
npm run build

As for me, I get this output:
User@User-PC MINGW64 /E/alex/buildTest
$ npm run build

> buildTest@ build E:\alex\buildTest
> rimraf dist && mkdirp dist && ncp static dist/static && cross-env NODE_ENV=production webpack --progress --hide-modules --config build/webpack.prod.conf.js
                         Hash: b70123bf6740c50d4bde
Version: webpack 1.12.14
Time: 5205ms
                                       Asset       Size  Chunks             Chunk Names
                 app.f274887a001873610c97.js    84.8 kB       0  [emitted]  app
    app.4b7e81fcd187c952b6e89f542e1494da.css  482 bytes       0  [emitted]  app
             app.f274887a001873610c97.js.map     666 kB       0  [emitted]  app
app.4b7e81fcd187c952b6e89f542e1494da.css.map  966 bytes       0  [emitted]  app
                               ../index.html  241 bytes          [emitted]
Child html-webpack-plugin for "..\index.html":

Child extract-text-webpack-plugin:

As you can see, the default assets/logo.png file isn't generated. Is this a default or a bug? If the latter, how to fix it?

The default webpack config inlines images < 10kb as base64 strings to save HTTP requests. Load the built page and you will see the image is there.

@yyx990803 Oh, didn't know that. Thanks for the info.


CI failing for mamba setup

CI is failing because provision-with-micromamba has been migrated to setup-micromamba so the test are not running

Fixed in #98


"Schedule a publish" doesn't seem to work as intended.

It looks like values entered into the "Schedule a publish" popup are not saved to Firebase. The "Save" button itself does not update these values, and they do not appear to update on any input or blur events.
The only way to set either of these fields seems to be the "Publish" and "Unpublish" buttons. Publish will set the "Publish at" to the current time, and "Unpublish" will do the same for the "Until" field, which nulls out the "Publish at" information (including in the Firebase DB). This means you can actually get yourself into a broken state where the "Publish" button will not work because it reads the "Until" timestamp as being in the future, and thus it is an invalid date range.
Expected behavior:

Hitting "Save" will persist the "Publish"/"Unpublish" timestamps to the DB.
and/or:
Persist the new "Publish"/"Unpublish" timestamps to the DB on field blur. (Using reasonable defaults for time of day, such as 12:01 for Publish and 23:59 for unpublish.)

Note: I'm going to start working on fixing this, but I don't seem to have sufficient permissions to assign myself the issue.

The expected behavior should be that changes require hitting the "Save" button. So any manual changes to the fields should require whacking "Save", and then the Publish/Unpublish buttons can just be a convenient shorthand method of modifying those fields.
Seem reasonable?

Sure thing.
One point on the pub/unpub buttons: I feel like, for historical reasons, we don't want to null out the "Publish" date when we hit "Unpublish." I can easily see a scenario where someone would want to go, "What was the exact date range when we ran that poll?" And nulling the Publish date just seems unnecessary as long as we correctly use the unpublish field on the front end. Not sure if this was intended behavior in the beginning or not.

Expected behavior:

Publish button sets published_at to "Right now, minus a few seconds" and clears unpublished_at if it's in the past.
Unpublish button sets unpublished_at to "Right now, minus a few seconds" and doesn't touch published_at.

:+1:


cypress: 12.16.0 -> 12.17.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cypress is: Fast, easy and reliable testing for anything that runs in a browser
meta.homepage for cypress is: https://www.cypress.io
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 12.17.1 with grep in /nix/store/j30wfn9rj55fmnah5zmahim0vvq3gajm-cypress-12.17.1
found 12.17.1 in filename of file in /nix/store/j30wfn9rj55fmnah5zmahim0vvq3gajm-cypress-12.17.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
cypress
polaris
polaris-web

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j30wfn9rj55fmnah5zmahim0vvq3gajm-cypress-12.17.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cypress https://github.com/r-ryantm/nixpkgs/archive/87508551d9d9b927ef3eee6745c1ef0b7d5011dc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j30wfn9rj55fmnah5zmahim0vvq3gajm-cypress-12.17.1
ls -la /nix/store/j30wfn9rj55fmnah5zmahim0vvq3gajm-cypress-12.17.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

cypress
polaris
polaris-web

Maintainer pings
cc @thorstenweber83 @mmahut @Craftzman7 for testing.

@ofborg build cypress cypress.passthru.tests


Able to create roles with the same name.

Affected module
UI
Describe the bug
Able to create roles with the same name.
To Reproduce

Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
NA

@parthp2107, are we getting any errors from the backend?

@Sachin-chaurasiya, the backend is not throwing any error.

@parthp2107, on UI we show displayName and we can create roles with the same display name but not with the same name.
This is already handled so closing this issue.


Rasa train issue

Getting an issue onrasa train
Traceback (most recent call last):
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\Scripts\rasa.exe\__main__.py", line 7, in <module>
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\__main__.py", line 117, in main
    cmdline_arguments.func(cmdline_arguments)
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\cli\train.py", line 59, in <lambda>
    train_parser.set_defaults(func=lambda args: run_training(args, can_exit=True))
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\cli\train.py", line 91, in run_training
    training_result = train_all(
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\api.py", line 106, in train
    from rasa.model_training import train_async
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\model_training.py", line 39, in <module>
    from rasa.core.agent import Agent
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\core\agent.py", line 16, in <module>
    from rasa.core.channels.channel import OutputChannel, UserMessage
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\core\channels\__init__.py", line 23, in <module>
    from rasa.core.channels.twilio import TwilioInput  # noqa: F401
  File "C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\rasa\core\channels\twilio.py", line 5, in <module>
    from twilio.base.exceptions import TwilioRestException
ModuleNotFoundError: No module named 'twilio.base'

What is the output of rasa --version?

@hsm207 Here are the rasa --version and Twilio
Rasa Version
Rasa Version      :         2.8.2
Minimum Compatible Version: 2.8.0
Rasa SDK Version  :         2.8.1
Rasa X Version    :         0.42.0
Python Version    :         3.8.11
Operating System  :         Windows-10-10.0.19042-SP0

Twilio
Name: twilio
Version: 6.50.1
Summary: Twilio API client and TwiML generator
Home-page: https://github.com/twilio/twilio-python/
Author: Twilio
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Requires: six, pytz, requests, PyJWT
Required-by: rasa

What is the output of rasa --version and pip show twilio?

What is the Location where the twilio package is installed?
e.g.
Name: twilio
Version: 6.50.1
Summary: Twilio API client and TwiML generator
Home-page: https://github.com/twilio/twilio-python/
Author: Twilio
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: /opt/venv/lib/python3.8/site-packages
Requires: PyJWT, pytz, six, requests
Required-by: rasa

Location: c:\users\A v1\anaconda3\envs\rasa\lib\site-packages

Do you get the same error when you train the bot using rasa init?

Do you get the same error when you train the bot using rasa init?

I didn't check with rasa init.
Let me try and know you.

Do you get the same error when you train the bot using rasa init?

Yes @hsm207  getting the same Twilio issue

@Manoj1229 what is the output of:
python -c "from twilio.base import *; import sys; print(sys.path)"

python -c "from twilio.base import *; import sys; print(sys.path)"

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'twilio.base'

What if you run:
python -c "import sys; print(sys.path)"

python -c "import sys; print(sys.path)"

['', 'C:\\Users\\AppsTek V1\\anaconda3\\envs\\rasa\\python38.zip', 'C:\\Users\\AppsTek V1\\anaconda3\\envs\\rasa\\DLLs', 'C:\\Users\\AppsTek V1\\anaconda3\\envs\\rasa\\lib', 'C:\\Users\\AppsTek V1\\anaconda3\\envs\\rasa', 'C:\\Users\\AppsTek V1\\AppData\\Roaming\\Python\\Python38\\site-packages', 'C:\\Users\\AppsTek V1\\anaconda3\\envs\\rasa\\lib\\site-packages']

I see you have installed twilio at c:\users\A v1\anaconda3\envs\rasa\lib\site-packages but that path is not in your sys.path.

I see you have installed twilio at c:\users\A v1\anaconda3\envs\rasa\lib\site-packages but that path is not in your sys.path.

Both are same, It my mistake typo here c:\users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages

I see you have installed twilio at c:\users\A v1\anaconda3\envs\rasa\lib\site-packages but that path is not in your sys.path.

Both are same, It my mistake typo here c:\users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages

Here the overview pip show Twilio:
Name: twilio
Version: 6.50.1
Summary: Twilio API client and TwiML generator
Home-page: https://github.com/twilio/twilio-python/
Author: Twilio
Author-email<EMAIL_ADDRESS>License: UNKNOWN
Location: c:\users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages
Requires: PyJWT, requests, pytz, six
Required-by: rasa

Can you try running this command:
python -c "import twilio; print(twilio.__file__)"

python -c "import twilio; print(twilio.file)"

C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\twilio\__init__.py

python -c "import twilio; print(twilio.file)"

This is not the command I asked you to run. Was there a typo?
Anyway, what is the content of this folder?
C:\Users\AppsTek V1\anaconda3\envs\rasa\lib\site-packages\twilio

@hsm207 The Issue is solved! downgrade the Twilio version  to 6.26


Added sitemap file

Added sitemap file for rescuekerala.in

we dont need a site map generated by an app that shows all the sub data and request info links

Why should it matter? anyway, there are many tools using which anybody can do deep crawling of the whole website including endpoints!

If we are not adding a sitemap, this PR can be closed.
@syam3526 @vigneshhari @biswaz @vrthra @bobinson

Too much metadata with priority like 0.64, do we need this?


Fix links replacement script to handle /tree/ links

Currently the script handles only links of the form https://github.com/microsoft/qsharp-language/blob/main/Specifications/Language/, but the documentation also contains links with /tree/ instead of /blob/ which are left unchanged.
This means that on the docs website part of the links point to other pages on the same website and part of the links point to this GitHub repo (for example, the link "example program" on this page or type links here).
It makes sense to unify the behavior for links that are included in the uid mapping.

@bettinaheim Do you know who's a good person to review this? Would be nice to fix the way the links are converted before the next release.

@bettinaheim Do you know who's a good person to review this? Would be nice to fix the way the links are converted before the next release.

It's always better to do a one-line technical solution than to require different people working on the docs to follow the requirement :-)

It's always better to do a one-line technical solution than to require different people working on the docs to follow the requirement :-)

This wasn't enough to fix it since the tree links weren't in the uid map. I opened a PR to add them: https://github.com/MicrosoftDocs/quantum-docs-pr/pull/1158
Hopefully that would work.

This wasn't enough to fix it since the tree links weren't in the uid map. I opened a PR to add them: https://github.com/MicrosoftDocs/quantum-docs-pr/pull/1158
Hopefully that would work.


[BugFix] fix mv on union bug

Fixes #24460
the bugs' reason are:

the mv's column type and nullable are invalid
the refresh process does not fail when there are filtered rows.

Fix it by deriving the correct nullable property and column type for mv and enable insert strict mode for mv refresh.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
5
5
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
5
5
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
5
5
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 11 / 11 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/analyzer/QueryAnalyzer.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java
5
5
100.00%
[]

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


[BUG] 'deposit' method in Pot endpoint checks for funds in wrong source

Describe the bug
I'm using the Pot endpoint to move funds from my main account to one of my pots and the error about insufficient funds is always raised. I am trying to deposit money from my main account which has sufficient funds, into a pot, so it should not be checking the pot balance at the beginning of the deposit method. This checking seems to only be needed for withdrawing from pots.
Expected behavior
For money to be deposited into a pot from the account id (main account)
Environment (please complete the following information):

0.2.0
3.8.10

Thanks @eliasbenaddou will take a look, likely be over the weekend to be honest atm.

No problem! Amazing package btw, I’ve been using it for quite a while and wanted to reach out for sometime. I may submit a PR if that helps?

Thankyou, glad you like the package,
Regarding a PR by all means always welcome a PR if you can,

Thanks again @eliasbenaddou thats it merged in, will release momentarily


require Stripe through  provider

constants provided to a module can't be mocked, providing Stripe through the $window provider makes mocking the Stripe library easier.
I didn't build or test this since no task manager is provided.

Sorry for letting this sit idle for so long. Pretty embarrassed :fearful:
Not sure how/when I managed to delete the npm scripts. Got that fixed.
If you still think changes are needed here, happy to review another PR. You'll notice that the test suite fails right out of the gate because you can't inject $window (service) into stripeProvider (provider).
If you can give me a more complete story on how/why you intend to mock the service I can probably offer an alternative way to unit test w/ mocks.


[FLINK-7577][build][WIP] POM Cleanup flink-core

What is the purpose of the change
This PR changes the flink-core pom to

not contain unused dependencies
contain all used dependencies

Brief change log
Verifying this change
mvn dependency:analyze
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-core ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING]    org.powermock:powermock-core:jar:1.6.5:test
[WARNING]    org.powermock:powermock-reflect:jar:1.6.5:test
[WARNING]    org.objenesis:objenesis:jar:2.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]    org.xerial.snappy:snappy-java:jar:<IP_ADDRESS>:compile
[WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
[WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
[WARNING]    log4j:log4j:jar:1.2.17:test
[WARNING]    org.joda:joda-convert:jar:1.7:test
[WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test

After the change:
[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-core ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING]    org.powermock:powermock-core:jar:1.6.5:test
[WARNING]    org.powermock:powermock-reflect:jar:1.6.5:test
[WARNING]    org.objenesis:objenesis:jar:2.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]    org.xerial.snappy:snappy-java:jar:<IP_ADDRESS>:compile
[WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
[WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
[WARNING]    log4j:log4j:jar:1.2.17:test
[WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)

Documentation
none

We will have to redo this from scratch since too much time has passed.


Footer

The footer is the old team dashboard
just upload it :)

@unjown did you make content for /aboutus or is this link in the footer just a placeholder?


Don't make this a framework

A library is not the same as a framework, but napc_app_setup and napc_app_loop are framework-like.
Replace napc_app_setup (and napc_app_loop) with.. libnapc_init(); instead?

Linux:
int main(void) {
    libnapc_init();
    // do stuff
}

Arduino:
void setup(void) {
    libnapc_init();
    // do stuff
}

void loop(void) {
    // do stuff
}

Periodic updates could be achieved by periodically calling libnapc_tick(); or something (to collect random bytes, or check network sockets etc.)

This is being done right now. The project will be split into libnapc and napc. napc will contain the very hardware dependent functionalities like ethernet, file system etc.


[Help] I need help setting up Codecov

I can't figure out how to setup codecov properly

Hi @GuillouTran, is this for GuillouTran/guilloutran.com? If so, I think what I'm doing will work for you. I'm trying to remember how I have this setup. 🤔

I'm using Jest – jest --coverage in package.json – to run tests and generate the code coverage report, which gets uploaded to Codecov.
I tried to use the Codecov GitHub app, but remember struggling to get it working.
In the end, I used the bash upload script and created a Codecov task to upload the coverage report, which you can see here (https://github.com/chrisvogt/gatsby-theme-private-sphere/blob/master/.circleci/config.yml#L37). In the environmental variable for that CircleCI project, I have a CODECOV_TOKEN set.

To do the same for your repo:

Verify that your coverage report is being generated and saved (look for a /coverage directory with lcov files in it).
Update your CircleCI config and copy in my Codecov task.
You may (?) need to set a CODECOV_TOKEN environmental variable in CircleCI, but I can't remember if that was truly necessary.

One more thing: the tests I have for this repository are not good and I want to update and rewrite them. I don't recommend following what I'm doing inside my *.spec.js files. They were an experiment with Jest snapshot tests, and are making my code coverage report look inflated. I don't feel the tests currently in this project are useful, and I plan to erase and replace them with good tests – probably integration tests, but still written in Jest.

Closing this for now. Let me know if you have any questions!


Add NoChatReports

Add small mod that strips cryptographic signatures that since 1.19 are attached to every message sent in the chat.
Link: https://modrinth.com/mod/no-chat-reports

No Chat Reports has been considered in the past, however chat reporting is a topic with very mixed opinions. The mod itself is pretty bloated too. There is a config file in Additive that makes the mod less obtrusive, but the mod is not included by default. You may add it manually if you wish, and it will be pre-configured for you.

No Chat Reports has been considered in the past, however chat reporting is a topic with very mixed opinions. The mod itself is pretty bloated too. There is a config file in Additive that makes the mod less obtrusive, but the mod is not included by default. You may add it manually if you wish, and it will be pre-configured for you.

Mixed is very off.

Chat reporting is a very abusive mechanic designed against server owners and people like me who dont want to get banned from others abusing it. There is tons of proof of this being abused and do not trust anything mojang says on the matter as its all lies

Again, just install it yourself.
I use NCR too, but I don't ask a modpack creator to add it after they already say no

Either way, it will not be added. I'm against chat reporting in quite a few ways, but NCR is not in the scope of Additive. Additive is an OptiFine alternative, it is not meant to change what Mojang obviously wants to keep.


Stub Mixlib::ShellOut

Been trying to wrap my head around stubbing mixlib::shellout in a cookbook. Any thoughts on where/how I would add this to chefspec? I'd work up a PR then.

For reference: Here is an example of this in motion:
https://github.com/juliandunn/library-demo-cookbook/blob/master/spec/unit/helper_spec.rb
Though it looks like it needs some updating for rspec 3
https://github.com/juliandunn/library-demo-cookbook/issues/2


List of 2D Tests to Refactor

WIP
@adimako @tridelat @Giovanni-Cozzuto-1989 @cekees
In order to make sure we cover all the tests, here is a list of all 2D air-water-vv tests I am paying attention to.  I will try to refactor everything listed here to the new best practices we have, but I might be slower or less effective, especially with tests that you are particularly familiar with.  I will try to make sure to post responses to this issue in particular to update you on which tests I'm working on (as well as updating the sub-issues).
Please contribute - in particular, add tests that aren't in this list with links (I'll explain the structure of these issues below), and update my references if you've adjusted or updated tests in other branches.  It can be hard to tell which branches are "ahead" or "behind" in their implementation of a particular test, but it's always nice to be working off of more modernized work.
The format I'm currently using to lists tests is as follows:

Category
The broad category of the issue, with a brief description of what classifies a problem as being in that category.
Test
A series of problems that follows one physical problem and has one set of code to support it.  Ideally, each can be covered by one set of modules with only context option changes to differentiate sub-tests.  Each should have some form of readme or explanation which describes the problem at this level, gives insight to call the functions, and maybe talks about the different sub-tests if they are important.  Each should link to the readme to help explain what the test's physical needs are.

[x] Geometry: what shape(s) from SpatialTools are needed to support this test, including any variations or special adjustments needed for the problem and sub-tests.  If this shape is already well supported, this box is checked.
[x] Main Code: checked if there is updated clean code that can run at least one sub-problem and has context options (there might need to be refactoring to match all the other sub-tests, of course)

Variant Options

[x] Variant ([last version]).  A sub-test.  The [last version] link should go to the most updated and clean implementation of this particular sub-test that we have, to easily check how it set up parameters and what made it different.  These will generally be taken care of by having a separate context file which can be used to set all the context options to its default values - once this is made and tested, the box can be checked.

Comments

Additional comments on the Test can go here, prefaced by names to help keep track of them.

So in general it goes
parun ./air-water-vv/2d/Category/Test_so.py -C "Variant_Options_File" -o "other changes"
(not that you'd run parun that way usually, but that illustrates the file structure).
I've subdivided this issue based on the directory structure in the refactoring branch.  You can also comment here on new folders you think should be split off, or any movement of tests from one category to another.

Benchmarks:
constantSlopeBeach:
floatingStructures:
hydraulicStructures:
numericalTanks
other (as these categories hold only a couple tests each)

@nerisaurus:

flat_linear_waves: To be removed and stay as an archived branch, as now replaced by numericalTanls/linearWaves
-nonlinear flat waves: Same here, to be replaced by nonlinear flat waves
-reflecting flat waves: to be replaced by standingWaves
-Xie and Chen @cekees I think this is goes under the constant slope tests unless it is a submerged bar

Now that I'm back where I can check my previous simulations of the two I think Chen has a submerged bar, but Xie does not, so I'll move them accordingly unless there's other input.
For the others, are the linear wave and nonlinear wave readme's still good to use as references for the new problems?

I've pushed a branch in Proteus that contains the code I'm using to support the air-water-vv changes I make (mostly changes to SpatialTools which allow calls from the tests to resolve properly) here.  It's a bit messy, and I'll split pieces off of it and clean them up when I actually push for the functionality to be merged into Proteus.  For now I just have it up so I'm not making mysterious unsupported calls in my code.  Feel free to merge in new support there, or to mention new functionality that I'll want to merge in to make sure my proteus work stays compatible.
Meanwhile, I will be focusing on starting to port over changes in the hydraulicStructures category in a branch [branch pending - come back later for a link].

I've actually diverted from my main focus to try to update the Numerical Tank problems to the latest cython boundary condition updates, so that I have code that runs to test things out with (as I can't find a local commit where they will run).
@tridelat , I followed your advice here on updating numericalTanks/nonlinearWaves to the new standard, but I keep running into this problem:
  File "/home/chluser/proteus/linux2/bin/parun", line 10, in <module>
    execfile(__file__)
  File "/home/chluser/proteus/scripts/parun", line 478, in <module>
    runName + '_init_prof')
  File "/home/chluser/proteus/proteus/Profiling.py", line 190, in __call__
    return func(*func_args, **func_kwargs)
  File "/home/chluser/proteus/proteus/NumericalSolution.py", line 468, in __init__
    model = Transport.MultilevelTransport(p,n,mlMesh,OneLevelTransportType=p.LevelModelType)
  File "/home/chluser/proteus/proteus/Transport.py", line 6003, in __init__
    PhiSpaceTypeDict=phiSpaces)
  File "/home/chluser/proteus/proteus/Transport.py", line 6229, in initialize
    movingDomain=movingDomain)
  File "/home/chluser/proteus/proteus/mprans/RANS2P.py", line 1171, in __init__
    diffusiveFluxBoundaryConditionsSetterDictDict)
  File "/home/chluser/proteus/proteus/mprans/RANS2P.py", line 75, in __init__
    getDiffusiveFluxBoundaryConditions,getPeriodicBoundaryConditions)
  File "/home/chluser/proteus/proteus/NumericalFlux.py", line 1997, in __init__
    getDiffusiveFluxBoundaryConditions,getPeriodicBoundaryConditions)
  File "/home/chluser/proteus/proteus/NumericalFlux.py", line 1788, in __init__
    parallelPeriodic=True)
  File "/home/chluser/proteus/proteus/NumericalFlux.py", line 168, in __init__
    g = gReturn[0]
AttributeError: BoundaryCondition instance has no attribute '__getitem__'

Any insight on this?  The code at the point I get this error is up here if anyone wants to try it out.

It looks like the boundary conditions are not initialised and that a BoundaryCondition class instance is passed instead of the actual function(x,t), you have to add init_cython() (e.g. domain.bc[flag].p_dirichlet.init_cython()) in all your *_p.py files?

I had indeed missed some of those (I think I had put them in on an earlier more ambitious refactoring [trying to deal with import statements too, which brought up too many bug], and forgot to redo them when I retreated to this refactor).  That seems to get past that bug (and into another, of course, but one that I recognize already).

After some bug fixing which @tridelat helped with a lot, I have made a crude compatibility update for the numerical tank tests (branch here).  I've only tested it on nonlinear waves so far, so I'm not eager to merge it in yet - and the fixes are not particularly clean at all points (although I did try to also clean up a few imports and error messages along the way) - but it's a start. Once I've done a few more tests, I'll move back to the hydraulicStructures.

Current work is on benchmarks (some hydraulicStructures code is bringing up obscure errors, and the dambreak problems in particular provide a series of stepping stones to test solutions as each new complicating element gets added to the problem - while at the same time getting more tests refactored), with my current rough work here.

Pull request #119 is a nearly complete update for the four benchmark problems (with dambreak considered a derivative of dambreak_Ubbink).


getIsPortTaken does not work and break the usedPortAction option

This following method getIsPortTaken might falsely return false, even though a server might be running on the configured protocol, host and port.
https://github.com/playwright-community/jest-process-manager/blob/ff7018a6c747aa370b1e62df1aa16b4a316f4aa6/src/index.ts#L121-L134
This renders usedPortAction useless, and for example would lead to a server being started while ignore should have prevented that.
From what I understood this is because of SO_REUSEADDR and SO_REUSEPORT:
Package such as node-portscanner would use net.Socket() to prevent that: https://github.com/baalexander/node-portscanner/blob/4fc93fe2a5cc9db983caab57bfe27cbee4de9cc5/lib/portscanner.js#L100-L135

@nrako thanks for report! I'll try to investigate this soon


[faad2] update to 2.10.1

Library name: faad2
New version number: 2.10.1
It seems the patches of the current port were already merged as pull requests, making the port simpler.

Thanks for the update!


Issue with Files Application - startup quickly

Description
Every time I press Ctrl + N to open a new window and subsequently close all windows, the Files application terminates its background process. As a result, the next startup displays a waiting launch screen.
Steps To Reproduce

Open the Files application.
Use the shortcut Ctrl + N to open a new window.
Close all windows.
Re-open the Files application.

Requirements

e.g. Fix crash that occurs when...
When I use the Files application, if I open a new window using Ctrl + N and then close all windows as needed, I want the Files application to continue running in the background. Even if there are no windows open, the next time I open the Files application, it should launch quickly and resume its previous state, instead of showing a startup interface.

Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.3672
Log File
2024-07-13 12:34:38.3729|Information|SIDELOAD: Checking for updates...
2024-07-13 12:34:39.5204|Information|SIDELOAD: Current Package Name: Files
2024-07-13 12:34:39.5211|Information|SIDELOAD: Remote Package Name: Files
2024-07-13 12:34:39.5214|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-07-13 12:34:39.5218|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-07-13 12:34:39.5242|Warning|SIDELOAD: Update not found.
2024-07-13 12:34:41.7576|Information|App launched. Launch args type: LaunchActivatedEventArgs
2024-07-13 12:34:42.5472|Information|Adding cloud provider "OneDrive" mapped to C:\Users\hoan2\OneDrive
2024-07-13 12:34:43.0039|Information|Drive added: C:, Fixed
2024-07-13 12:34:43.2494|Information|Drive added: D:, Fixed
2024-07-13 12:34:43.3058|Information|Drive added: E:, Fixed
2024-07-13 12:34:43.3370|Information|Drive added: F:, Fixed
2024-07-13 12:34:43.4085|Information|Drive added: G:, Fixed
2024-07-13 12:34:43.4462|Information|Drive added: J:, Fixed
2024-07-13 12:34:43.4808|Information|Drive added: L:, Removable
2024-07-13 12:34:43.5834|Information|Drive added: J:
2024-07-13 12:34:43.5984|Information|Drive added: L:
2024-07-13 12:34:45.2743|Information|SIDELOAD: Checking for updates...
2024-07-13 12:34:46.4090|Information|SIDELOAD: Current Package Name: Files
2024-07-13 12:34:46.4097|Information|SIDELOAD: Remote Package Name: Files
2024-07-13 12:34:46.4102|Information|SIDELOAD: Current Version: <IP_ADDRESS>
2024-07-13 12:34:46.4107|Information|SIDELOAD: Remote Version: <IP_ADDRESS>
2024-07-13 12:34:46.4132|Warning|SIDELOAD: Update not found.
2024-07-13 12:34:49.3463|Information|The app is being activated. Activation type: ProtocolActivatedEventArgs
2024-07-13 12:34:49.7877|Information|Running on ARM: False

Thanks for the report, We're tracking this in #12689. You can check there or click subscribe in the right sidebar for updates.
This is expected as Files can only cache one instance/window right now. Also in future please upload the log file and don't copy and paste the contents


Delete soft-deleted entities

Avoids potential bugs in which soft-deleted entities are returned from database
queries (soft-deletion is now deprecated), but some records may still exist.
Fixes #1956

I'm looking at the schema and see that queries.author_id is set to null on deletion. Scheduled queries cascade deletion with associated query and associated pack. Can you think of other entities that should have cascading deletion?