URLs in document should open in a new window unless local references

So...
I added the link to Satyrn's repo and then clicked on it.
And we opened in the markdown window, which I think we don't want (We aren't trying to replace their browser for browsing).
I'm not 100% sure the best way to deal with it.  Perhaps.

for local references we do nothing (they should act like they do now)
for references without a target attribute should get target="_blank" when rendered.
for references with a target attribute are unchanged
to allow authors to explicitly load a new URL into the same Saturn context, we should open/name the current target context as "satyrn" so that it isn't hard for markdown editors to say "load it this url in Saturn". By which I mean, target="satyrn" opens in our app explicitly.

Btw, that last bit also makes it an interesting possible integration with web browsers to pass a URL reference from the web to our app. That's not a feature we want to worry about now, but whatever our solution, I'd like it to be the simplest & least breaking when using markdown from "the wild".

i think that's reasonable all around - i only wonder about allowing any external document to open internally - as that adds a can of worms.... e.g. if there are changes in the document, do we also prompt for saving, etc.   so +1 for 1-3, but let's be certain about 4.
thoughts?

So I tried target="_blank", That opens a new electron window, is that what we are expecting? Don't we want to open the link in their browser.

Hmph.
Yes. But now I'm not sure how to do that now. Maybe we need to intercept the open URL and launch a process with whatever the default browser is?

https://stackoverflow.com/questions/32402327/how-can-i-force-external-links-from-browser-window-to-open-in-a-default-browser

I think so - like this, yes?
1 - in-doc links stay w/in window
2 - in-app links behave like target=_blank
3 - exsternal links are replaced with JS that runs a new browser

the new-window trick in the stack-overflow seems to be the right approach for 3.
AND we have to add the target="_blank" to all URLs without a target in the showdown extension.

https://stackoverflow.com/questions/32402327/how-can-i-force-external-links-from-browser-window-to-open-in-a-default-browser

I quickly tried this and it does open in browser but also in electron app. preventDefault() isn't doing what I would expect

cool - tapping that event is nice - great find!  assuming we can figure out the preventDefault problem.
can you clarify the point about adding target=_blank.... not sure I follow

oh...
I mispoke.
We'll need to process the markdown on load to change all URLs, not just the custom extension.

although I'm curious how we name the current context as "satyrn" so that target="satyrn" replaces the current content.

Ah....
Is it possible to open a new satryn window?

currently, target="_blank" opens a new Satyrn window. But maybe we should offer that in a menu.

I got the basics of the opening in new window working on _blank targets.  I have not done the regex to replace all the missing external URLs to _blank.

Nice. So what we really want is to part the markdown for
Rebooting the Web of Trust
Then convert into an anchor tag with _blank target correct?
Or are we wanting to scan for anchor tags in the markdown and add a _blank?
Or is it both?

Good catch. I was thinking we do the scan in the html, which might simplify things.
I added a bunch of links to the top of the default.md for testing, including a simple .md link and fragment links in both .md and html.
Looking at the options, I think if we apply the following after converting to HTML:

if the link URL starts with "#", do nothing in the rendering
if the link URL has a target, do nothing in the rendering
if the link URL has no target (and is not "#"), set the target to "_blank"

Then, either on-click or on the open (where we currently intercept)

if the link URL has a saturn target, load it in the current document
if the link URL has a _saturn target, load it in a new Satyrn window
if the link URL is "about:blank" open in new Saturn window (without menu bar)
if the link URL is a fragment, just let chrome handle it (by scrolling)

My only doubt at this point is whether or not we have access to the target value in the window opener event handler or if in the pre-processing we want to hack the URL, prepending "satyrn:" or something.
This also raises the question of non-local URLs loaded by Saturn.  Other than the node_modules thing, I think it should "just work".
Let me add a URL that points to a thing on github.

So... that adds one more thing, we should probably only ever try to open .md URLs in Satyrn

Okay, I have added an extension which parses and adds the target="_blank" stuff when needed so the first part of this is done.

I am not sure I understand how this works
  mainWindow.webContents.on('new-window', function(e, url) {
    // about:blank is opened when creating stand-alone helper windows
    // such as for the About page and the Guide
    if(url && url !== 'about:blank') {
      e.preventDefault();
      console.log('EXTERNAL')
       shell.openExternal(url);
       return false;
      }
  });

But I think I am right in thinking that is the place we want to do the second part

Yes. That's probably where the second part happens--especially if we can get the target value in this code to put "satyrn" and "_satyrn" in the right place.  The test with the about:blank was because without it the about/guide pop-ups were being shunted to the shell, which didn't know which app to open.
However, we may need to intercept in an on-click handler on the link elements, especially if we can't get the target value in this function. I'd prefer to do it all here.

btw, that function is called whenever an explicit target is used.
Also, we need to add the check to see if the window exists already. When using a target that already exists, you get back the same window. So... when I fixed the guide code to use "guide" as the target, it re-used the same window, added the guide content again (a bug), and failed to bring the window to the foreground.

I have fixed a number of these.
The styling is a bit of a fudge I have copied main.css into the app folder because I can't figure out how this css is brought in from webpack or how we can access it.
I have changed the target back to guide and fixed the re-adding content bug. You can get the target using the disposition variable in the new-window listener.
Still need to:

Make windows focus on open
Make target satyrn open in same window - currently still opens in browser

Now it should be just the focus on open issue.

Actually to clarify: The problem is focusing on the help page for example, when the help page is already open in another window. Currently it is not getting brought to the foreground.

Ok. I fixed the focus by closing the old pop-up window if it exists. I needed a timeout so we didn't close it before the IPC call gets made (closing it without the timeout throw an error). We could potentially use a nextTick or whatever, but the old trusty timeout worked great.
However, opening the .md directly, e.g.,

satyrn target (open in current Satyrn) https://github.com/WebOfTrustInfo/satyrn/raw/master/README.md
And in a new window
_satyrn target (open in new Satyrn window) https://github.com/WebOfTrustInfo/satyrn/raw/master/README.md

Both fail to render the .md. I think this is the last bit for this issue.

Confused, this works for me I am pretty sure

Last problem I can see is when target = _satyrn but the window is already open it doesn't focus on the correct window. So I assume similar fix to above @jandrieu, although this happens in background.js rather than app so it is a little different.

Hmmmm... we probably shouldn't close it, since it may have state. Also, if we are want it to be like "_blank", I think we should open it in a new window always. This might mean simply changing the target to a target
As for the latest... yeah. I did a pull and clicking on the "satyrn" link, it just shows the markdown. AND we lose the ability to open new files. Opening new files simply stops doing anything.
If I use "_satyrn", that opens a new window, but it is also both unrendered markdown. The menu functions relate to the parent window and not the new one. For example, changing the edit mode for the new window changes the edit state of the initiating document. Loading a new file loads it into the initiating window.

Ah, my bad sorry :)

Are you able to reproduce?

Okay, I have solved part of this although it has thrown up a number of questions and issues.
Markdown can now be rendered as markdown using the converter both in a new window and the same window as appropriate. This is done using a XmlHttpRequest to fetch the content.
Issues:

Request assumes files are Markdown. Currently this breaks if they aren't, I have added a test url but have not dealt with this.
For same page, the kernel.kill() function in resetKernel does not exist. I have commented this out for now but assume we need to do something here. The whole state seems to be out of sync. You can switch to edit mode, add a javascript tag and write in the editor. Running the code gives no output. But you are able to reset the editor. Needs looking into.
For new window, the issue is that switching to edit mode changes the original window rather than the current one. This has been mentioned before.
I have also added some todos around what file names and targets we should be giving this windows. Particularly for targets when opening a new window. These probably need to be different for each window otherwise all links will just open in the same window, but not sure how we would generate or track these. Easiest way would be to make each link click create a window with a different target so if the same link is clicked twice then two windows would open.

This is quite a lot of so may be best to open new issues individually? Let me know and I can do that.

I think we might be able to fix this if we figure out how to open a file with the app.
Then to open a _saturn window, we use the shell to open the file? We'll need to make sure we can open with the arg as a URL, but that should be straightforward.

Okay, after chatting with @ewelton and @gannan08 today, I have had another attempt at this which I think is more along the lines of what you were thinking Joe.
I have refactored the create window code that was in app.on("ready ... into is own function. This function is now called for every _satyrn target which then adds the appropriate listeners for that window.
I have removed all references to mainWindow. We don't currently need to refer to the windows and can just use the event listeners on each window (I think).
File menus now work as expected
I have introduced a bug, reload no longer works - possibly track separately? I moved the call to load the markdown file from the app.js into background which I think is correct. However we need to make sure we are reloading the correct file on a reload event. I couldn't find this exact event handler on the window, but there must be something. Figured I would just commit and hopefully it is an easy fix I just missed. (Sorry if its not, I tried to create a new branch locally and push but not sure I have permissions).
Finally I still use a http Request to load the url file contents before passing to converter. Not sure there is a better way than this, although it does mean the issue with a non markdown url still exists.
Open to suggestions, but to me this feels like its on the right track now.

Fixed the reload. I am hesitantly saying this is now done although there is still the external url with satyrn target that isn't a markdown file minor issue.

@jandrieu Can you test this again, I think we can close now.

LGTM


Generated images missing parameter info using WebUI backend

Describe the bug
After generating the images using WebUI backend from #25 and show the generation history, click the image and some parameter information is missing.

Desktop (please complete the following information):
MacBook Pro with Chrome

@harrywang can you help to make a bit of tests? Just open your webui with no api mode, switch to PNG info tab, upload one image in txt2img or img2img folder to see how it works here? If it could not read information as well that would be the issue on webui side

@harrywang can you help to make a bit of tests? Just open your webui with no api mode, switch to PNG info tab, upload one image in txt2img or img2img folder to see how it works here? If it could not read information as well that would be the issue on webui side

@jtydhr88

Yes. No metadata saved in the PNG.
It would be nice if we can have the metadata saved in PNG while using StableStuio via your WebUI plugin.

I just tried another one, which has the metadata saved - all generated using using StableStuio via WebUI backend plugin. - not sure why some worked and some did not work.

just generated another one to confirm: the metadata is saved in PNG:

but metadata is not properly shown in StableStudio:

I guess I get the cause which is line break.
can you go to your local file https://github.com/Stability-AI/StableStudio/blob/552ddb4a3dbe4f23b69ad0169948899331eb0f2c/packages/stablestudio-plugin-webui/src/Utilities.ts#L57
and change \n to \r, to see it can fix the issue?

I guess I get the cause which is line break. can you go to your local file
https://github.com/Stability-AI/StableStudio/blob/552ddb4a3dbe4f23b69ad0169948899331eb0f2c/packages/stablestudio-plugin-webui/src/Utilities.ts#L57
and change \n to \r, to see it can fix the issue?

No, the history images won't show after changing to \r with console error:

Is this likely an issue with themes? Can you verify that the text isn't white as well?

Is this likely an issue with themes?


Skip empty lines in fscomp.conf

Looks good, could you please add an entry to CHANGELOG.md?

Thanks for the contribution


When open telegam app , it takes too long time wait for connecting to the proxy

My problem is that when open the APP, it takes a lots of  time to wait for connecting the proxy. I found that #169 seems to solve this problem without affecting the speed. So I'm wondering if anyone has the same problem as me? Or it has a better solution, thank you!

Also please retry with the latest version because the delays may be fixed by https://github.com/alexbers/mtprotoproxy/commit/88c8c57a44bfa0815c48bf759d8016380380279a

Also please retry with the latest version because the delays may be fixed by 88c8c57

The same situation, even in the latest build.


3MF Editor Validation not catching namespace prefix error on path

The path attribute for booleanshape and boolean should not have a namespace prefix. Schema validation doesn't catch this as we have an "Any" attribute. So, a structure validation needs to be added to the 3MF editor.

validation check added to editor

closed

validation check added to editor


Update aether-deploy to 0.25.0

Updates no.arktekk.sbt:aether-deploy from 0.24.1 to 0.25.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "no.arktekk.sbt", artifactId = "aether-deploy" } ]

labels: sbt-plugin-update, semver-minor

Done in #587


After login, a thread starts periodically sending noops to the server…

… to prevent timeout

See comment on issue87

Ah, would be nice if we could stick to a naming scheme for PR and branches.
Naming for Branches: [issueTyp]/[xx][optional description]
PR: branchName + optional text :)
i will edit this one to fit


Add domain_history() to Fix#10

Description
Add new method in class Browser to sort the histories according to their domain-name
Add DocStrings for modules generic & utils
Fixes #10
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[x] I have commented my code, particularly in hard-to-understand areas (if applicable)
[x] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[x] Any dependent and pending changes have been merged and published

Looks good. One suggestion though, the code for getting domain name seems a bit hacky. I would suggest using https://docs.python.org/3/library/urllib.parse.html to get the domain name instead.

Also, when linking issues in comments, use #10 directly (with nothing around it) instead of Issue#10. This way, GitHub will automatically convert it into a link to the issue.


If WebSocket connection gets interrupted, it stays interrupted

There doesn't seem to be a strategy for error detection/recovery/re-connection here. A simple observation can be made by following these steps:

Start websocket server
Start Elm app containing a Signal with WebSocket.connect underneath
Shut down the websocket server
Keep observing the Elm app

which simply results in no more signals being emitted.
Error recovery is important, especially for server-driven real-time apps. Perhaps we can add a reconnect flag, or better yet, a ReconnectStrategy type with finer grained options for re-establishing communication?

WebSockets has been moved outside of the core modules, so we resolved this problem by deleting all the code. The new approach uses Tasks so should not have the same fundamental API constraints.
Thanks for the report and sorry for the crazily long delay!

You can try elm-socketio which will reconnect and has some configurable error handling.


testClosingResourcesMultipleTimes_noErrors() failed

Environment:

Jib version:
Build tool:
OS:

Description of the issue:
testClosingResourcesMultipleTimes_noErrors() failed
Expected behavior:
to pass
Steps to reproduce:

jib-maven-plugin Configuration:
PASTE YOUR pom.xml CONFIGURATION HERE

jib-gradle-plugin Configuration:
PASTE YOUR build.gradle CONFIGURATION HERE

Log output:
Additional Information:

We've never seen this test failed. Do you see any stack trace?

Closing due to inactivity, feel free to re-open if the problem persists and you have additional information.


*: Fix misuse of pkg/errors.Errorf and error directive

%w directive is only valid for recently introduces go native error wrapping. pkg/errors uses %v.
This PR fixes discovered issues in the code base.
Signed-off-by: Kemal Akkoyun<EMAIL_ADDRESS>
[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Verification

make test-local
make test-e2e

@GiedriusS I've fixed misuse of errors.Errorf for the existing changes. Also traversed the code base and fixed other misuses that caught by my eyes.
I'd be glad if you could take another look at it.


feat: add typescript type definitions

Hello, I am using this library to build an interceptor for nestjs, but the type definition is missing for this library, so I add the corresponding type declaration.
As typescript becomes more and more popular, adding type definitions to the library will make the library easier to use.
Closes #170

This looks like it’ll make it a lot more ergonomic to use; thank you for the contribution!
Do you know if there’s anything we can do to test these, to make sure if the interface is changed we don’t forget to update the type definitions? (Not asking to implement yet, just asking)

@nemtsov As far as I know, if the type declarations is not generated by typescript compiler tsc, it seems that the external type declaration cannot be verified automatically.

@hungtcs what are your thoughts on https://github.com/microsoft/DefinitelyTyped-tools/tree/master/packages/dtslint tests or https://github.com/SamVerschueren/tsd ?

Hi @nemtsov , I took a brief look for tsd and dtslint, These two tools seem to be used to verify the correctness of the declaration file, but can not verify API consistency. so at present, I don't see some improvement through this tool

FYI I've raised a pull request on the DefinitelyTyped project to create types for json-mask: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/66328


Ability to specify Redis Prefix

I would like to use multiple application with only one redis server and cannot find the way to specify prefix like in this example :
$redis->setOption(Redis::OPT_PREFIX, 'myAppName:');

Could you point me to a direction ?
FYI, i'm using Stash with StashBundle inside a EZ5 project

+1

+1

Wouldn't namespacing suffice for your needs? (http://www.stashphp.com/Grouping.html#namespaces)

I can see a need for this, so I'll toss it on the list. Someone is working on a predis driver option, so I'm going to let them finish that up and then add the new option in.

+1 cause redis is shared

FWIW there is also an issue calling clear on the existing redis driver with no key name, which will blow away the entire redis database because it calls FLUSHDB

Hey,
Anything happen with this?  I've skimmed through the 3 Predis PRs and they all seem to have halted.  If there's any interest I can potentially pick up from one.

This would also be useful for managing lots of keys on large shared Redis databases.

👍

Just waiting on a PR :-)


[OAuth] Support ALTER and DROP

Theoretically after we've setup the OAuth ownership roles + access token role inheritance, etc. We shouldn't need to do anything for ALTER and DROP OAuth created tables to work.
Check it and at least write some tests to prove it:

master api key can drop/alter tables created from an oauth api key
ownership role can drop all tables created by an oauth api key
a new or refreshed access token can drop/alter tables created previously by other access token
same for views and other entities.

Tests were created as part of the create dataset PR


Module for managing Ktor modules

A very common pattern when writing Shedinja + Ktor applications is to have controllers declared as
class MyController(scope: InjectionScope) {
    fun installOnto(application: Application) = with(application) {
        // ...
    }
}

// And in the class that manages the backend server

val myController: MyController by scope()
// ...
myController.install(this)

This can get very repetitive and it's easy to forget to install some controllers or components. A possible solution would be to create a Ktor module that "automatically" installs controllers and other modules if the implement some interface. This would be fairly easy to do on the Shedinja side (somewhat similar to services).

Here's an example of what this could look like
class ControllerA : KtorModule {
    fun Application.install() {
        routing {
            get("a") {
                 call.respond("Hello from a")
            }
        }
    }
}

class ControllerB : KtorModule {
    fun Application.install() {
        routing {
            get("b") {
                call.respond("Hello from b")
            }
        }
    }
}

class CoreModule : KtorModule {
    fun Application.install() {
        install(ContentNegotiation) {
            jackson { /* ... */ }
        }
    }
}

class KtorApp(scope: InjectionScope) : ShedinjaService {
    private val ktorModules: KtorModules by scope.meta()

    lateinit var server: ApplicationEngine

    fun start() {
        server = embeddedServer(port = 12345) {
            ktorModules.installAllOnto(this)
        }
    }
}


Dependency update tools can't detect new versions of KustomExport

Tools such as Renovate and the gradle-versions-plugin are unable to find version information for KustomExport.
$ ./gradlew dependencyUpdates --info

...

The exception that is the cause of unresolved state: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find any matches for deezer.kustomexport:compiler:+ as no versions of deezer.kustomexport:compiler are available.
Searched in the following locations:
  - https://dl.google.com/dl/android/maven2/deezer/kustomexport/compiler/maven-metadata.xml
  - https://repo.maven.apache.org/maven2/deezer/kustomexport/compiler/maven-metadata.xml
  - https://raw.githubusercontent.com/Deezer/KustomExport/mvn-repo/deezer/kustomexport/compiler/maven-metadata.xml
Required by:
    project :lib

The exception that is the cause of unresolved state: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find any matches for deezer.kustomexport:lib:+ as no versions of deezer.kustomexport:lib are available.
Required by:
    project :lib

Normally these tools don't have a problem finding dependencies in custom Maven repos. Is there something missing or unusual about the way KustomExport builds are published?

I never used such a tool before, I've adjusted the publication and copied the produced maven-metadata-local.xml to the expected directory. The url you have is now pointing to an xml file: https://raw.githubusercontent.com/Deezer/KustomExport/mvn-repo/deezer/kustomexport/compiler/maven-metadata.xml
Can you try again with your tool and tell me if it works for you?

@glureau Yes, that works nicely now, thanks. 👍
 ./gradlew dependencyUpdates

...

------------------------------------------------------------
: Project Dependency Updates (report to plain text file)
------------------------------------------------------------

The following dependencies are using the latest milestone version:
...
 - deezer.kustomexport:compiler:0.8.1
 - deezer.kustomexport:lib:0.8.1
 - deezer.kustomexport:lib-coroutines:0.8.1
...


PUBLIC meaning?

Each release's name is structured as ghidra_*_PUBLIC_*.zip.  Out of curiosity, what does PUBLIC refer to?  Is it because there are some in development features that aren't public, or because there are confidential parts of the program?

Each release's name is structured as ghidra_*_PUBLIC_*.zip. Out of curiosity, what does PUBLIC refer to? Is it because there are some in development features that aren't public, or because there are confidential parts of the program?

When you build Ghidra from source you'll get something like ghidra_11.2_DEV.
As far as I can tell it's just a PUBLIC release build vs DEV build.

PUBLIC refers the the final release distributions placed on GitHub.  Development builds use DEV as you mentioned.  The application.config file gets modified during our build process which produces the final distributions.

The version number does not mean much with DEV since 1000 different builds may have been produced with the same version number with different code modifications.  DEV implies an unknown state within a development cycle.


Benchmark tweaks

This PR adds all the tweak done while working on the benchmark. A lot of happened, and despite my best effort is hard do split it up in several chunks

Alright, a lot happened but now:

[x] I removed buggy/flaky tests (like on density compensation)
[x] The CI is faster (and will be even more when we cache the installation of cufinufft)
[x] Examples scripts serve also as tests for the trajectories
[x] All tests are passing :tada: , we get 68% of branch coverage

Moving forward

[ ] We still need to publish the coverage etc

Regarding the renaming of data_consistency method to get_grad: This was done to stick closer to the Modopt API. May be data_grad is a good compromise (that should be used in Modopt as well)


3DS - How to get mangopay password on PRO?

I have question about 3DS process:
On the Sanbox we can get password at

(it is always "MANGOPAY123")
but on PROD how to user can find it ?

Hello @duykhanh1411
The MANGOPAY123 is just for your tests on sandbox environment
When in PROD, the issuing bank will send you the proper password depending on the card used by your users.

Hello @duykhanh1411
The MANGOPAY123 is just for your tests on sandbox environment
When in PROD, the issuing bank will send you the proper password depending on the card used by your users.

thanks @dduwoyemgp


Error message tooltip flickers on hover (DisplayServer regression)

Godot version
4.0.alpha_2
System information
Windows 10, AMD Ryzen 2700x, Nvidia 1070ti
Issue description
Visual glitch where the tooltip that shows information of a given error flickers instead of lighting up fully, on exit it is hidden correctly
Steps to reproduce

Open Editor
Open new GDScript
Make code that generates runtime error
Tab out of game to editor
Look at tab "Errors([some number])" in bottom of editor
Observe flicker

Minimal reproduction project
N/A

@albinaask Can you record a video of this happening?

https://user-images.githubusercontent.com/11806563/153949092-371872b5-ca20-4eee-a263-5de073693a17.mp4

Noticed this too. Was in the middle of another ticket so I forgot to open an issue on this.
Windows 10.

As a workaround, you can likely enable Single Window Mode in the Editor Settings and restart the editor.


Transaction commits in tests

Why do you commit the transaction in the dao tests?

The testDBCall will roll back the transaction: https://github.com/qiangxue/golang-restful-starter-kit/blob/master/daos/daos_test.go#L13

But if the transaction is committed, it can't be rolled back, no?

ah, I see what you meant. Yes, you are right. It's more reasonable (and faster) not to commit the transaction in the test.


Migrate to angular-cli

We can migrate our custom webpack solution to angular-cli.
Angular-cli now uses webpack. I think it will be more standard way to build angular applications

I'll wait for 1.0-final release (probably August 27)

Still waiting for stable release with angular rc.6 working

Migration is done on dev branch


Validation fixes

Category

[ x] Content fix

Docs Build status updates of commit 288e6f8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/schema/lobsysteminstance-element-in-lobsysteminstances-bdcmetadata-schema.md
:warning:Warning
View
Details

docs/schema/lobsysteminstance-element-in-lobsysteminstances-bdcmetadata-schema.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@VesaJuvonen
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!


Erwin docs

Codecov Report

Merging #565 (ca7827d) into master (ed6fd93) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #565   +/-   ##
=========================================
  Coverage     60.93%   60.93%
  Complexity      622      622
=========================================
  Files           104      104
  Lines          2245     2245
  Branches        259      259
=========================================
  Hits           1368     1368
  Misses          760      760
  Partials        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6fd93...ca7827d. Read the comment docs.


forwardAuth: add service name to headers in auth service

Hi,
Im using traefik behind a internet router with port forwarding (80/443). All my endpoints are only publicly accessible, so request from the internal network are also via external. I'm using docker-compose, so no k8s. I've implemented forwardAuth. It's "all" working honky-dory...... except:
I'm trying to implement conditional access based on router/service. So user A has access, but only to service "B". Hence the auth container need to know to which router/service the request is for.
All request (inside auth container) have the following header:
'x-forwarded-for': 'a.b.c.d'
Which (obviously) is my public IP address in case request are coming from the internal network as all my services are exposed publicly, eg. blog.spilleman.nl
The only way I can make it work is to create a custom header in my docker compose labels (for each application), explicitly setting it so I can access it in my auth container (the one called by the forwardAuth logic). I now do it via a custom header, per service like 'x-application-url': 'https://blog.spilleman.nl'
So by default, the request contains NO information that the user actually requested "blog.spilleman.nl"
How can I change this so the auth container DOES indeed know which service the user is trying to access (without custom headers)..... or am I doning something wrong?
Solution I can think of is that traefik (always) sets the service name in a header so I don't have to do it manually. What are your ideas?
Thanks!
Sander Spilleman

duplicate of #3919
Note: please follow the issue template.


diminished Returns stays on play session

With the Networking problem crushed comes a new problem.
When you play and start diminishing moons and switch save files, the diminished returns are kept across them.
But when you restart the game all saves have them set to zero again.
So it is saved on the players session and not the save states.

When loading old DiminishingReturns data from the save file I forgot to clear the old data before loading in the new data. It will now do that in the next update.
I discovered an additional bug that results in the most recently diminished moon to not be saved onto the file. Two birds with one Github issue. Thank you again @VanilaBOI.


CI docker daemon not running

[2020-11-30T22:11:34.910Z] 2020-11-30 22:11:32,782 - root - INFO - Running command: 'DOCKER_CACHE_REGISTRY=mxnetci docker-compose -f docker/docker-compose.yml pull ubuntu_cpu'

[2020-11-30T22:11:35.472Z] Couldn't connect to Docker daemon at http+docker://localhost - is it running?

Affects https://github.com/apache/incubator-mxnet/pull/19604 https://github.com/apache/incubator-mxnet/pull/19588
cc @rondogency

I created updated AMIs which should solve this for the short-term, but looking into longer term solutions.


Control flow not formed when using consts

TypeScript Version:  2.0.3
Code

interface Releasable {
    release(): void;
}

const typeOfNumber: string = 'number';

function release(releasable: number | Releasable): void {
    if(typeof releasable === typeOfNumber) {
         allocated.splice(allocated.indexOf(releasable), 1);
    } else {
         releasable.release();
    }
}

Expected behavior:

interface Releasable {
    release(): void;
}

const typeOfNumber: string = 'number';

function release(releasable: number | Releasable): void {
    if(typeof releasable === typeOfNumber) {
         allocated.splice(allocated.indexOf(releasable), 1); // Ok, typeof releasable is number here
    } else {
         releasable.release(); // Ok, typeof releasable implements Releasable here
    }
}

Actual behavior:

interface Releasable {
    release(): void;
}

const typeOfNumber: string = 'number';

function release(releasable: number | Releasable): void {
    if(typeof releasable === typeOfNumber) {
         allocated.splice(allocated.indexOf(releasable), 1); // [ts] Argument of type 'number | Releasable' is not assignable to parameter of type 'number'. Type 'Releasable' is not assignable to type 'number'.
     } else {
         releasable.release(); // [ts] Property 'release' does not exist on type 'number | Releasable'.
     }
}

Currently type guards are only limited to literals. Type guards are consumed at compile time and from this taken in mind variables defined with let or var seems natural to not result in proper control flow but type guards using constants defined with const should result in a proper type guard. Since the compiler already knows that consts will not change their value ans so their value should be checked dose it evaluate to known typeof return value to form a proper control flow else to result in a  [ts] error ...

Why are you using a const rather than the literal "number" here?
We could think about this as a suggestion but you'd definitely need to not have the : string annotation of typeOfNumber since that explicitly discards our knowledge of its initializer

I'm using const as a refactor of typeof type guards and as well for little memory optimization. And I'm using string as type for the consts since typeof returns string: The typeof operator returns a string indicating the type of the unevaluated operand.

After reading the TypeScript Language Specification; 4.18.6 The typeof operator I've changed the type of typeOfNumber from string to primitive string literal 'number' but this dose not change the behavior (the same [ts] errors are emitted).

Approved change for next release


Update Readme Installation Guide

In _config.yml, the 'gems' configuration option has been renamed to 'plugins'.

@DirtyF I've updated the PR. Please check again. Thank you.

Thanks @ldt116 😄
@jekylbot: merge +docs


chore(gha): update github actions versions

🧰 Changes

update github actions versions. The v3 of a bunch of these actions is deprecated.

I noticed these deprecated actions when working with Jenn yesterday. Nothing urgent at all, just bumping them for safety.

This PR was released!
🚀 Changes included in v6.75.0-beta.67


Detect Java toolchain usage using Provider with side effect

Fixes https://github.com/gradle/gradle/issues/21314
Also fixes https://github.com/gradle/gradle/issues/21368

@bot-gradle test qfl

OK, I've already triggered the following builds for you:

QuickFeedbackLinux build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Qt: Could not initialize OLE (error 80010106)

I'm working on a ASP.NET Core MVC app and I wanted to use DinkToPdf library to convert Html to PDF.
I get this error in the console, when I first access a page that uses the IConverter from the services:
Qt: Could not initialize OLE (error 80010106)

I still get the PDF with no issues.
I think the issue is somewhere around calling: new SynchronizedConverter(new PdfTools())
As I have it in the services as a singleton and only called the first time it's accessed:
services.AddSingleton(typeof(IConverter), new SynchronizedConverter(new PdfTools()));

Have the same problem. It genereates the PDF, yet, the error is throw on the first call

The same error is reported by the BasicConverter under the same conditions.

Also getting this issue with OPs setting, I get this error with Haukcode.Wkhtmltopdf.netcore also... I think this is an issue with wkhtmltopdf.... but not sure. Can we get a point in the right direction?

I've abandoned wkhtmltopdf in favour of Chrome based solutions. Similar concept but using the debugging protocol to control headless Chrome. The wrappers aren't as mature but the handling of CSS and things like SVG are so much better it's not funny.

That's awesome for you, but not sure how that helps when trying to generate thousands of pdfs as a background task in an azure function.

I've not written an Azure function but if you're using wkhtmltopdf that implies you can at least load a DLL.
An exe might not work directly in an Azure function but what stops you from using more appropriate hosting to implement HTML to PDF as a web service and using it that way? Generation time is a few hundred ms for single page documents.
If that's not good enough, Chromium is open source. Contribute a direct API and make yourself very popular.

I've just hit this problem too, in an Azure Isolated Functions host project.
I'm pretty sure this issue is due to the worker thread in SynchronizedConverter not being STA mode. So I copied the SynchronizedConverter and made an STA version.
public class STASynchronizedConverter : BasicConverter
{
    Thread conversionThread;

    BlockingCollection<Task> conversions = new BlockingCollection<Task>();

    bool kill = false;

    private readonly object startLock = new object();

    public STASynchronizedConverter(ITools tools) : base(tools)
    {
    }

    public override byte[] Convert(IDocument document)
    {
        return Invoke(() => base.Convert(document));
    }

    public TResult Invoke<TResult>(Func<TResult> @delegate)
    {
        StartThread();

        Task<TResult> task = new Task<TResult>(@delegate);

        lock (task)
        {
            //add task to blocking collection
            conversions.Add(task);

            //wait for task to be processed by conversion thread
            Monitor.Wait(task);
        }

        //throw exception that happened during conversion
        if (task.Exception != null)
        {
            throw task.Exception;
        }

        return task.Result;
    }

    private void StartThread()
    {
        lock (startLock)
        {
            if (conversionThread == null)
            {
                conversionThread = new Thread(Run)
                {
                    IsBackground = true,
                    Name = "wkhtmltopdf worker thread"
                };

                // This is to fix issue https://github.com/rdvojmoc/DinkToPdf/issues/119
                conversionThread.SetApartmentState(ApartmentState.STA);

                kill = false;

                conversionThread.Start();
            }
        }
    }

    private void StopThread()
    {
        lock (startLock)
        {
            if (conversionThread != null)
            {
                kill = true;

                while (conversionThread.ThreadState == ThreadState.Stopped)
                { }

                conversionThread = null;
            }
        }
    }

    private void Run()
    {
        while (!kill)
        {
            //get next conversion taks from blocking collection
            Task task = conversions.Take();

            lock (task)
            {
                //run taks on thread that called RunSynchronously method
                task.RunSynchronously();

                //notify caller thread that task is completed
                Monitor.Pulse(task);
            }
        }
    }
}

I also see this error. I can run this in an Azure function app once - it generates the PDF fine and throws this error, however subsequent calls to the function app fail (502 / 503 or just timeout / hang until I cancel the request)

I resolved the issue of failing to produce the second call to the Azure function by creating a startup class to handle the singleton
using Microsoft.Azure.Functions.Extensions.DependencyInjection;
using Microsoft.Extensions.DependencyInjection;
using DinkToPdf;
using DinkToPdf.Contracts;

[assembly: FunctionsStartup(typeof(Html2Pdf.Startup))]

namespace Html2Pdf
{
    public class Startup : FunctionsStartup
    {
        public override void Configure(IFunctionsHostBuilder builder)
        {
            builder.Services.AddSingleton(typeof(IConverter), new SynchronizedConverter(new PdfTools()));
        }
    }
}

See here for more
https://docs.microsoft.com/en-us/azure/azure-functions/functions-dotnet-dependency-injection

Hey,
I am using the library with .Net 5. I am facing the same error
Qt: Could not initialize OLE (error 80010106)
Any resolution so far?

@distantcam  provided the solution. It works fine @Workaholic01. Those who may be checking this page in search of a solution, implement the solution by @distantcam.  works for dotnet 6 .. @distantcam Thanks for the solution

@distantcam solution works fine on Windows, but the function SetApartmentState is not available on Linux. Is there something that works on both platforms?

@distantcam  works like a charm

how come for all these years the fix given by @distantcam still does not apply to the SynchronizedConverter class? is this library not being maintained anymore?

HI @dqmarkmagaoay , this library is no longer maintained, from my stressed test output, it can serve around 1.5K request/per hour. If it won't fit your need, you need to use PDFSharp, or headless pdf, or a paid library.

HI @dqmarkmagaoay , this library is no longer maintained, from my stressed test output, it can serve around 1.5K request/per hour. If it won't fit your need, you need to use PDFSharp, or headless pdf, or a paid library.

Thanks for the info and reply @swotiendang , i was just curious as to why fixes are not being applied. This still fits my needs and may continue to use it at the moment.

thanks much @distantcam

thanks much @distantcam running it in Azure function smoothly now

@balajiv27 i just wanna ask, have you tried it as an Azure App?


Is it possible to get relations between NER?

Is it possible to get relations (REL) between NER entities using this library?
For e.g. If I were to pass in the following sentence "Moscow is the capital of Russia", I can extract Moscow and Russia as the NER. How can I extract 'is capital of" as the relation between the two NER entities?

Hello!
We have no Information Extraction in the library at the moment.  However, a good starting point for such task can be OpenIE.


Update auto-assign-label-pr.yml

The issue with auto-assign-label-pr.yml has been fixed that is the labels conflict is now set free

@SumithThota thankyou for fixing it

Could you please check it


findEntitiesByClassification -> unexpected exception if type null

The following code fragment
       try {
              entities = metadataCollection.findEntitiesByClassification(userId, typeGuid,
                      classification,
                      null, null, 0,
                      null,
                      null, null, null, 0);//TODO Handle exceptions from findEntitiesByClassification
          }

was used with
userId = "me"
typeGuid = null
classification = "DataValue"

other parms 0/null

The exception returned was:
org.odpi.openmetadata.repositoryservices.ffdc.exception.RepositoryErrorException: OMRS-REPOSITORY-400-055 An unexpected exception was received from a repository connector during the findEntitiesByClassification operation which had message: null
The exception seems to be caught in EnterpriseOMRSMetadataCollection where
                  List<EntityDetail> results = metadataCollection.findEntitiesByClassification(userId,
                                                                                entityTypeGUID,
                                                                                classificationName,
                                                                                matchClassificationProperties,
                                                                                matchCriteria,
                                                                                fromEntityElement,
                                                                                limitResultsByStatus,
                                                                                asOfTime,
                                                                                sequencingProperty,
                                                                                sequencingOrder,
                                                                                pageSize);

gets a null pointer exception
The method comments suggest a null type should be ok
The cause of this is in OMRSRepositoryContentValidator verifyEntityIsClassified where we iterate through the entity's classifications
    public boolean verifyEntityIsClassified(List<String>   requiredClassifications,
                                            EntitySummary  entity)
    {
        if (requiredClassifications != null)
        {
            List<Classification> entityClassifications = entity.getClassifications();

            for (String requiredClassification : requiredClassifications)
            {
                if (requiredClassification != null)
                {
                    for (Classification entityClassification : entityClassifications)
                    {
                        if (entityClassification != null)

At this point the method has been called with a sensible requireClassifications
requiredClassifications = {ArrayList@7628}  size = 1
 0 = "AbstractConcept"

and the entity looks ok:
entity = {EntityDetail@7465} "EntityDetail{entityProperties=null, classifications=null, type=InstanceType{typeDefCategory=TypeDefCategory{typeCode=6, typeName='EntityDef', typeDescription='An object or concept of interest.'}, typeDefGUID='578a3510-9ad3-45fe-8ada-e4e9572c37c8', typeDefName='GovernanceOfficer', typeDefVersion=1, typeDefDescription='Person responsible for a governance domain.', typeDefDescriptionGUID='null', typeDefSuperTypes=[TypeDefSummary{, guid='a32316b8-dc8c-48c5-b12b-71c1b2a080bf', name='Referenceable'}], validStatusList=null, validInstanceProperties=[qualifiedName, additionalProperties, title, scope, domain]}, instanceProvenanceType=InstanceProvenanceType{ordinal=1, name='Local Cohort', description='The instance is managed by one of the members of a cohort that the local server belongs to'}, metadataCollectionId='2b341b63-f82c-4aa5-86fc-326e63734bb4', instanceURL='http://localhost:8080/instances/entity/c5f748a6-0e46-4a3a-937c-c0450d8d7dc6', GUID='c5f748a6-0e46-4a3a-937c-c0450d8d7dc6', status=In"
 entityProperties = null
 classifications = null
 instanceProvenanceType = {InstanceProvenanceType@7574} "InstanceProvenanceType{ordinal=1, name='Local Cohort', description='The instance is managed by one of the members of a cohort that the local server belongs to'}"
 metadataCollectionId = "2b341b63-f82c-4aa5-86fc-326e63734bb4"
 guid = "c5f748a6-0e46-4a3a-937c-c0450d8d7dc6"
 instanceURL = "http://localhost:8080/instances/entity/c5f748a6-0e46-4a3a-937c-c0450d8d7dc6"
 type = {InstanceType@7577} "InstanceType{typeDefCategory=TypeDefCategory{typeCode=6, typeName='EntityDef', typeDescription='An object or concept of interest.'}, typeDefGUID='578a3510-9ad3-45fe-8ada-e4e9572c37c8', typeDefName='GovernanceOfficer', typeDefVersion=1, typeDefDescription='Person responsible for a governance domain.', typeDefDescriptionGUID='null', typeDefSuperTypes=[TypeDefSummary{, guid='a32316b8-dc8c-48c5-b12b-71c1b2a080bf', name='Referenceable'}], validStatusList=null, validInstanceProperties=[qualifiedName, additionalProperties, title, scope, domain]}"
 createdBy = "me"
 updatedBy = null
 createTime = {Date@7579} "Fri Sep 21 15:47:55 BST 2018"
 updateTime = null
 version = 1
 currentStatus = {InstanceStatus@7580} "InstanceStatus{ordinal=15, name='Active', description='The instance is approved and in use.'}"
 statusOnDelete = null

but there are no classifications on this entity - hence NPE

Adding a simple check for null seems to address, but will continue working through to check behaviour is correct in caller & callee. I can submit a PR next week.


not linting it shows its all ok

Have you installed the providers yet? http://atomlinter.github.io/

yep it's installed and always showing No Issues

Can you please provide us a repro case? Also can try installing linter-jshint file and then open a javascript file?
Please note that linters are grammar specific

After installing linter-jshint it works!! Thank you so much!


Combining explicit arguments with slice expansion doesn't work

Probably it is already discussed. But I didn't see description in Language Specification.
What version of Go are you using (go version)?
go version go1.8 linux/amd64
play.golang.org
Does this issue reproduce with the latest release?
I think, yes.
What did you do?
https://play.golang.org/p/2Qm34TE-gn
func main() {
	a := []interface{}{ 1, 2, 3 }
	fmt.Println(1, 2, 3)
	fmt.Println(a...)
	fmt.Println(-1, 0, a...)
}

What did you expect to see?
1 2 3
1 2 3
-1 0 1 2 3

What did you see instead?
tmp/sandbox223672132/main.go:11:13: too many arguments in call to fmt.Println
	have (number, number, []interface {}...)
	want (...interface {})

This is working as defined in the spec. The arguments to match a variadic argument may be a list of singletons or a slice followed by ..., not a combination. The main reason is to avoid ambiguity that can lead to errors.
Working as intended.

The previous Go2 proposals are https://github.com/golang/go/issues/18605 and https://github.com/golang/go/issues/19218.
@robpike you might want to raise your point in the proposals, or when the time comes for Go2.


Version bump WG to 0.0.20190601

Bump Wireguard to latest release at the time of this pull request.

Since I waited too long with merging this I'll close it. I've pushed an update that sets the version to 0.0.20190702.


🐛 [BUG] - Loading Pages Between Menu Switching Zero States  Appear

Description
When I switching between Menu like "Test Suite", "Test Run", "Mock Services" their zero states appear
Reproduction URL
https://app.sprint.rest/app/e4vdz7gbcn/pane001/suites/folder/di85027
Reproduction steps
1. Go to 'Sprint Cloud'
2. Click on 'Test Run'
3. Click on 'Test Suites'
4. See Zero State of 'Test Suites'

Expected not to see Zero States of every menu items

Screenshots
![DESCRIPTION](LINK.png)

Logs
No response
Browsers
Chrome
OS
Mac

screen-capture (1).webm
Still same

Checked, still same


9.1 increase in 400 status code

While testing a build from the 9.1.x branch in production, I noticed that the number of 400 status codes from the origin was increasing compared it its 9.0.1 based peer.  At least 3 times as many.

Nevermind.  Digging in some more.  It appears that the rate of 400's varies and what I saw was within the normal variance.


Consuming an output which is a map

Hello,
I'd like to retrieve the domain_name and the zone_id from a hosted zone created with the controller.
However I'm struggling getting the proper format. Actually when I use that
  writeOutputsToSecret:
    name: route53-cloud-hostedzone
    outputs:
      - route53_zone_name:domain_name
      - route53_zone_zone_id:zone_id

I don't get the expected string format
apiVersion: v1
data:
  domain_name: ewogICAgICAiY2xvdWQub2dlbmtpLmlvIjogImNsb3VkLm9nZW5raS5pbyIKICAgIH0=
...
kind: Secret
metadata:
  name: route53-cloud-hostedzone
  namespace: flux-system

{
      "my.domain.tld": "my.domain.tld"
    }

From my understanding I should parse the output within the resource that consumes the secret but I don't know how to proceed.
the module expects the string domain_name and zone_id
kind: Terraform
metadata:
  name: acm-cloud
spec:
  approvePlan: auto
  destroyResourcesOnDeletion: false
  interval: 8m
  path: ./
  sourceRef:
    kind: GitRepository
    name: terraform-aws-acm
    namespace: flux-system
  vars:
    - name: subject_alternative_names
      value:
        - "*.my.domain.tld"
    - name: wait_for_validation
      value: true
    - name: tags
      value:
        Name: "my.domain.tld"
  varsFrom:
    - kind: Secret
      name: route53-cloud-hostedzone

I ended up building my own module in order to properly format the outputs.
But still, if we want to use community modules that would be cool to be able to do that and somewhat related to this issue I guess?


fix(split): no fold find if foldexpr setup

WHAT
foldlevel computing can manually trigger with zx, so we just need recompute foldlevel after setup filetype to json | html | text
related #162

WHY
HOW
Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Linter
[ ] Tests
[ ] Review comments
[ ] Security

Summary by CodeRabbit

Bug Fixes

Improved handling of fold levels after setting the filetype to ensure proper folding behavior.

Hi @wenjinnn I can't reproduce the issue. Could you record a video for before/after the PR? Thanks 🙏

Sure! the basic setting is:
vim.opt.foldmethod = "expr"
vim.opt.foldexpr = 'v:lua.vim.treesitter.foldexpr()'

before this PR:
https://github.com/jellydn/hurl.nvim/assets/30885216/80b15da5-7ec5-4c2c-979a-5eb44e4aa40e
after:
https://github.com/jellydn/hurl.nvim/assets/30885216/f0506829-2eda-4c7e-9e7d-ae840380e810


fix: upgrade to version 3.1.219

from: https://github.com/jenkins-x/jx-cli

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign garethjevans
You can assign the PR to them by writing /assign @garethjevans in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
aeda0faa80ec5a5b26a31521fe9670850c23dcad
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


[Feature request] Expose the "method" parameter to onSuggestionHighlighted

Hi
How about add a  "method" property to parameter of onSuggestionHighlighted callback, which indicate the "source" event type that triggered the change of highlighted suggestion?
Possible values of the "method" property could be:

"mouse": the change of highlighted suggestion was triggered by MouseEnter / MouseLeave
"key": change was triggered by KeyDown / KeyUp

Use case: change the input value when user select the suggestion item by KeyDown / KeyUp, but not when mouse hover it. Like what Google Search's suggestions function works.

Isn't this use case implemented by default already?

This is the case in onSuggestionSelected but not in onSuggestionHighlighted. When you enter a search query and hover an item and then click enter it selects the hovered item. If there is a method prop you could also support the more conventional approach, that the user searches for the query entered in the input field.


how to use concat with merge

I was trying to upgrade my past codes after some months, I can see that many things have changed.
How can I use merge in concat mode as shown below with the new keras version. Thanks
merged = merge([x1, x2], mode='concat')

from keras.layers import concatenate
 concatenate([x1, x2], axis=-1)

Thanks Daniel.
However, it does not seem to work. see here the error:
from keras.layers import concatenate
merged = concatenate([x1,x2], axis=-1)
Traceback (most recent call last):
File "", line 1, in
merged = concatenate([x1,x2], axis=-1)
File "/home/ade/.local/lib/python2.7/site-packages/keras/layers/merge.py", line 508, in concatenate
return Concatenate(axis=axis, **kwargs)(inputs)
File "/home/ade/.local/lib/python2.7/site-packages/keras/engine/topology.py", line 596, in call
output = self.call(inputs, **kwargs)
File "/home/ade/.local/lib/python2.7/site-packages/keras/layers/merge.py", line 283, in call
return K.concatenate(inputs, axis=self.axis)
File "/home/ade/.local/lib/python2.7/site-packages/keras/backend/tensorflow_backend.py", line 1723, in concatenate
return tf.concat([to_dense(x) for x in tensors], axis)
File "/home/ade/anaconda2/lib/python2.7/site-packages/tensorflow/python/ops/array_ops.py", line 1075, in concat
dtype=dtypes.int32).get_shape(
File "/home/ade/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 669, in convert_to_tensor
ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
File "/home/ade/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/constant_op.py", line 176, in _constant_tensor_conversion_function
return constant(v, dtype=dtype, name=name)
File "/home/ade/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/constant_op.py", line 165, in constant
tensor_util.make_tensor_proto(value, dtype=dtype, shape=shape, verify_shape=verify_shape))
File "/home/ade/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/tensor_util.py", line 367, in make_tensor_proto
_AssertCompatible(values, dtype)
File "/home/ade/anaconda2/lib/python2.7/site-packages/tensorflow/python/framework/tensor_util.py", line 302, in _AssertCompatible
(dtype.name, repr(mismatch), type(mismatch).name))
TypeError: Expected int32, got list containing Tensors of type '_Message' instead.

Can anybody please help with this? How do I replicate the old merge layer with concat in the new keras!!
import keras
from keras.layers import concatenate
input1 = keras.layers.Input(shape=(16,))
x1 = keras.layers.Dense(8, activation='relu')(input1)
input2 = keras.layers.Input(shape=(32,))
x2 = keras.layers.Dense(8, activation='relu')(input2)
merge = concatenate([x1, x2], axis=-1)
Error: TypeError: Expected int32, got list containing Tensors of type '_Message' instead.

The code you posted works fine here.
It seems that you are using Keras 2.0.4, so you can try to upgrade to 2.0.6

Thanks @Danielhiversen . I have verified that I have keras 2.0.6 and I still get errors compiling the code. please see the attached snapshot of my console. I would appreciate any help, thanks.

With tensorflow 1.2.1 and keras 2.0.6, the code works on my mac. What's the backend and its version?

Hi @keunwoochoi and thanks for the response.
I am using keras 2.0.6, you can see the screenshot up there confirming that. The backend is tensorflow.
I am using tensorflow version = 0.12.1
Thanks. I will appreciate your help.

@Danielhiversen @keunwoochoi   Thanks. found out it's my obsolete tensorflow version that's causing it. Now closing this.

This is basically a compatibility issue among Keras & Tensorflow.
The following steps would resolve the issue.
Uninstall keras & tensorflow

sudo pip uninstall keras
sudo pip uninstall tensorflow
Then, reinstall both of them with the specified version
sudo pip install keras==2.0.6
sudo pip install tensorflow==1.2.1


plaay list imorter mass start stream

when i upload list on playlist importer  and i  mass start anything ,,,,,,thestreaeam star all.but no output format video an audio,,,and the user cant see streams,,
when i uplod singlee stream  on sstream page hee wwork he streem ,,utput  video nd audio ok.

after uploaad playlist withaut check proxy and tracode null and bistream filter nulled,,,,,,,,,
when i staart 100 stream the panel blocked wont to open the page,,,,and fos strem not respond,need rebot to work

now gon on error nginxn page after reboot
mmmmm,,,not good

ow ok it open,,but so slow

i think there is a bug in mass import, we will take a look soon.

in old fos its not problem 4000 stream  i start
and mas start i start 2000 streams in on time in old fos panel

fuck, when import with proxy selexted not work nathing when start streams

we took out the proxy, you want it back?

nooo
whe import plylist and chek boxproxy
after when you trat mas strem,ll stream start but not work nothing

the new volume1 not work its impposible to have a stable proces
its imposibel to sta 100 streams,the panell not work,,,,,,,blank page,need reboot and after reboot not work the stream,,,,,v1  sooryyy is not stale version in importstreammmmm,,,,,the old panel is a perfect panel,,,,

the problem wen ju mas start streams  the admin  panel not responde,,,,go in crash
i havent installl phpmyadmin,,,and when the panel go in crash phpmyadmin respone
#2002 Cannot log in to the MySQL server
[ Log in ]

sorry now what can we do its imposible to mass start streams 100 more,,,,,in old fos pannel that work erfectly,,,,i mass start in old pannel 2000 stream in on clic,,,and in v1 cant start 100

old fos streamiga start 1500/////2000 stream in v1 when start100 stream the panel not wor

the old pael its so fast ,,,,but not work more 5 conction user simultaied ,,,,
k


Template

Did you use any template to make this website? Thinking of making my own, where do I start?

It's a modified version of AdminLTE (quite a lot of modifications) but there are also many other ones. You can search for admin dashboard templates online.


Pre-trained data set test & misc. questions

Hi,
I followed the installation instructions and wanted to test the pre-trained data set you provided. However, when I run the python code, I get the following error:
(cv) amyrzat@ainos03:~/face-py-faster-rcnn-master/tools$  python run_face_detection_on_fddb.py --gpu=0
Traceback (most recent call last):
  File "run_face_detection_on_fddb.py", line 4, in <module>
    from fast_rcnn.test import im_detect
  File "/home/amyrzat/face-py-faster-rcnn-master/tools/../lib/fast_rcnn/test.py", line 17, in <module>
    from fast_rcnn.nms_wrapper import nms
  File "/home/amyrzat/face-py-faster-rcnn-master/tools/../lib/fast_rcnn/nms_wrapper.py", line 9, in <module>
    from nms.gpu_nms import gpu_nms
ImportError: No module named gpu_nms

Also, on Friday I deleted the repository and tried to re download it again with the command you provided, but I got the following error:
git clone --recursive git@github.com:playerkk/face-py-faster-rcnn.git
Cloning into 'face-py-faster-rcnn'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

When I downloaded your repository couple weeks ago, the command worked, but now it doesn't.
Also, I realized that in the file run_face_detection_on_fddb.py you are using FDDB to test the data, but your Readme file doesn't instruct to download it.
I am new to this, so if there is anything I am missing, please let me know.
Thank you in advance.

you have to cd to $FRCN/lib and then run "make" in the terminal. (step 3 of the installation section)
If you can't download the repository, I think it might be due to the setting of your git (eg, ssh key).
You can find more information of FDDB here http://vis-www.cs.umass.edu/fddb/

Thank you! I was able to fix and successfully install everything.
Now, however, whenever I run python code, I get the following error.
(cv) amyrzat@ainos03:~/rcnn/face-py-faster-rcnn-master/tools$ python run_face_detection_on_fddb.py --gpu=0
Traceback (most recent call last):
  File "run_face_detection_on_fddb.py", line 104, in <module>
    net = caffe.Net(prototxt, caffemodel, caffe.TEST)
RuntimeError: Could not open file models/face/VGG16/faster_rcnn_end2end/test.prototxt

You need to run the code in the root directory of the repository, like
python ./tools/run_face_detection_on_fddb.py --gpu=0

Thank you very much!
So, when I run command, this is what I get: python ./tools/run_face_detection_on_fddb.py --gpu=0
Loaded network /home/amyrzat/output/vgg16_faster_rcnn_iter_80000.caffemodel
F0228 15:46:41.819329  5875 syncedmem.cpp:56] Check failed: error == cudaSuccess (2 vs. 0)  out of memory
*** Check failure stack trace: ***
Aborted (core dumped)

But if I do the following command, the program runs.
python ./tools/run_face_detection_on_fddb.py --gpu=1
However, I also get the following result. I looked online, and I found that I might be naming my files wrong and the program can't find it. I double checked run_face_detection_on_fddb.py to see if it access right directories, but I couldn't fix it.
File "./tools/run_face_detection_on_fddb.py", line 146, in <module>
  scores, boxes = im_detect(net, im)
File "/home/amyrzat/rcnn/face-py-faster-rcnn-master/tools/../lib/fast_rcnn/test.py", line 121, in im_detect
  blobs, im_scales = _get_blobs(im, boxes)
File "/home/amyrzat/rcnn/face-py-faster-rcnn-master/tools/../lib/fast_rcnn/test.py", line 103, in _get_blobs
  blobs['data'], im_scale_factors = _get_image_blob(im)
File "/home/amyrzat/rcnn/face-py-faster-rcnn-master/tools/../lib/fast_rcnn/test.py", line 33, in _get_image_blob
  im_orig = im.astype(np.float32, copy=True)
AttributeError: 'NoneType' object has no attribute 'astype'

Thank you once again.

I deleted and re-downloaded FDDB. It worked. Thank you for all of your help!


Rule: prefer if over ternary operation evaluating to None if cond doesn't hold

Proposal
Disallow ternary operations that:

if condition holds, call a method
otherwise, do nothing (the whole expression evaluates toNone)

e.g. method(...) if condition else None
Why is it bad?
Can be autofixed, simplified, and be clearer for future maintainers.
Examples & autofix
- print("🐍") if condition else None
+ if condition:
+     print("🐍")

- dictionary.update({"foo":"bar"}) if condition else None
+ if condition:
+     dictionary.update({"foo":"bar"})

(the second example can be simplified to dictionary["foo"]="bar", but the example is what inspired this proposal, and the simplification doesn't serve as good example)

Would a better rule just be one that just triggered if the result of a ternary is unused (i.e. on a line by itself)? I think that would still catch both of your cases, but would avoid potential false positives e.g.
maybe_int = int(s) if s.isdecimal() else None

And would also catch extra cases like:
print("hello") if cond else print("goodbye")

I can have a go at implementing this, I assume it would be a RUF rule since I can't see an implementation elsewhere?

We could include it as a RUF rule. I'd like to see if it flags anything on the ecosystem CI checks before committing to merging it. Are you open to implementing, then evaluating whether there are valid patterns that we might be overlooking based on what gets flagged?
(I think your suggestion of checking if the result is unused makes sense -- so checking for StmtExpr where the Expr is a ternary.)

Yeah that sounds good, it doesn't look too difficult to implement so there'd be little loss if we decide not to continue after opening a PR 👍

I think there's merit in also completely not allowing ternary expressions as they cannot be accurately measured by coverage.py. There's flake8-if-expr which does this.
Would it be possible to support this as part of this feature please?
Thanks heaps
Fotis


Add  to all relative path elements in System.Private.CoreLib.csproj

#804

@weshaggard please have a look

This problem exists in several other .csproj files. It would be nice to fix it everywhere.

@jkotas I will take care with the other projects in another PR. I just wanted to clean up S.P.CoreLib first to unblock people seeing the reported warnings

LGTM


🌩 Elevate the Server to Cloud Readiness: Dockerization, Kubernetes, and Monitoring 🚀

Problem
Our current HTTP server, while functional and robust for on-premise and local deployments, lacks the critical infrastructure needed to be cloud-ready. In today’s cloud-driven world, we need to prepare the server for seamless deployment, scaling, and monitoring in cloud environments to ensure it can handle high traffic and maintain performance.
Why This Matters
To ensure the server is lightweight, scalable, and capable of handling real-world workloads in cloud environments, we must make it adaptable to cloud-native principles. This means the server should be easy to deploy using containers, support auto-scaling via orchestration tools like Kubernetes, and offer monitoring and observability to track performance metrics. This issue will focus on introducing essential features like Dockerization, Kubernetes orchestration, and performance monitoring.
Goals
We need contributors to implement cloud-readiness for the server. Here are the key tasks involved:

Dockerization:

Package the HTTP server into a Docker container.
Ensure it is easy to deploy in any cloud environment by providing a Dockerfile with clear instructions on how to build and run the server.
Make sure that the server runs smoothly inside the container.
The final Docker image should be lightweight, highly portable, and well-documented.

Kubernetes Support:

Create Kubernetes YAML files and Helm charts to manage the server deployment in a Kubernetes cluster.
Ensure support for auto-scaling based on incoming traffic load.
Ensure the solution is flexible enough for use with different cloud providers (AWS, GCP, Azure).

Metrics and Monitoring:

Integrate Prometheus for metrics collection, and provide basic metrics like request count, response time, error rates, resource usage and many more.
Set up Grafana dashboards for visualizing these metrics.
Expose metrics in a format that Prometheus can scrape (e.g., HTTP endpoints).

Optional:

Add CI/CD pipeline integrations to automatically build and deploy Docker images and Kubernetes configurations.

What You Need to Do
If you’re interested in tackling this issue, here’s how to get started:

Proposal:

Before diving into the code, please provide a detailed implementation plan in the comments section of this issue. Outline how you plan to implement Dockerization, Kubernetes support, and monitoring.
Be sure to include:

How you’ll structure the Dockerfile.
Any specific Kubernetes configurations or Helm charts you'll use.
How you’ll integrate Prometheus and Grafana, and what specific metrics will be exposed.

Read Project Files:

Read the README.md file carefully. This will give you a better understanding of the project’s goals and the overall architecture.
Review the CONTRIBUTING.md file. It contains important guidelines, particularly for newcomers. Following this will ensure that your contribution process is smoother and aligns with the project’s standards.

Additional Considerations
Here are some additional factors to keep in mind:

Cloud-agnostic: Ensure that your Docker and Kubernetes setup is cloud-agnostic, meaning it should work on platforms like AWS, GCP, Azure, etc.
Scalability: Design the solution to handle high traffic, with Kubernetes autoscaling based on CPU/memory usage or request load.

Next Steps
Once your implementation plan is approved, you can begin working on the feature. Make sure to:

Regularly update the issue with your progress.
If you hit any blockers, ask questions or request feedback from the community.

Let's make this server cloud-native and ready for the real world! 🌐

I can work on this issue.
kindly assign it to me.

I can work on this issue. kindly assign it to me.

Hi @payallenka,
Thanks for showing interest in tackling this issue! I'd be happy to assign it to you, but before I do, could you walk through the issue thoroughly? You will then understand how to contribute to it.
If you have any questions or need help along the way, don’t hesitate to reach out!

Sure, I am writing the implementation steps along with some code snippets for reference
Implementation Plan for HTTP Server

Dockerization

Dockerfile Structure:

Base Image:Use an official Java runtime (e.g., openjdk:11-jre-slim) as the base image.
Copy Project Files:Copy the necessary files, including the compiled JAR file and any configuration files.
Expose Ports: Expose the server's listening port (default 8080).
Command to Run the Server:Use CMD to start the Java application.

Example Dockerfile:
# Use an official OpenJDK runtime as a parent image
FROM openjdk:11-jre-slim

# Set the working directory
WORKDIR /app

# Copy the compiled JAR file
COPY target/http-server.jar ./http-server.jar

# Expose the server port
EXPOSE 8080

# Run the Java application
CMD ["java", "-jar", "http-server.jar"]

Kubernetes Configuration

Kubernetes Resources:
-Deployment:Define a Deployment resource to manage the application replicas.
-Service: Create a Service to expose the HTTP server externally.
Helm Charts:

Structure the Helm chart with templates for Deployment and Service to enable easy installation and management.

Example Deployment Manifest:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: http-server
spec:
  replicas: 3
  selector:
    matchLabels:
      app: http-server
  template:
    metadata:
      labels:
        app: http-server
    spec:
      containers:
      - name: http-server
        image: yourusername/http-server:latest
        ports:
        - containerPort: 8080
        env:
        - name: SERVER_PORT
          value: "8080"  # You can customize this if needed

Example Service Manifest:
apiVersion: v1
kind: Service
metadata:
  name: http-server
spec:
  type: LoadBalancer
  ports:
  - port: 80
    targetPort: 8080
  selector:
    app: http-server

Monitoring with Prometheus and Grafana

Integration Steps:

Prometheus Setup:

Deploy Prometheus using a Helm chart.
Configure Prometheus to scrape metrics from the HTTP server. This requires exposing a /metrics endpoint.

Grafana Setup:

Deploy Grafana using Helm and connect it to Prometheus as the data source.
Create dashboards to visualize key performance metrics.

Exposed Metrics:

Use a Java metrics library, such as Micrometer or Prometheus Java Client, to expose metrics like:

Request count
Response times
Error rates
Thread usage
Memory usage

Example Prometheus Configuration (scrape config):
scrape_configs:
  - job_name: 'http-server'
    metrics_path: '/metrics'
    static_configs:
      - targets: ['http-server:8080']

Summary

Dockerize the HTTP server with a clear and efficient Dockerfile.
Deploy the application on Kubernetes using a Helm chart with necessary configurations.
Integrate monitoring with Prometheus and Grafana, exposing important metrics from the application.

This plan would work as per me. If you have any further add-ons or reductions please do let me know!

Sure, I am writing the implementation steps along with some code snippets for reference
Implementation Plan for HTTP Server

Dockerization

Dockerfile Structure:

Base Image:Use an official Java runtime (e.g., openjdk:11-jre-slim) as the base image.
Copy Project Files:Copy the necessary files, including the compiled JAR file and any configuration files.
Expose Ports: Expose the server's listening port (default 8080).
Command to Run the Server:Use CMD to start the Java application.

Example Dockerfile:
# Use an official OpenJDK runtime as a parent image
FROM openjdk:11-jre-slim

# Set the working directory
WORKDIR /app

# Copy the compiled JAR file
COPY target/http-server.jar ./http-server.jar

# Expose the server port
EXPOSE 8080

# Run the Java application
CMD ["java", "-jar", "http-server.jar"]

Kubernetes Configuration

Kubernetes Resources: -Deployment:Define a Deployment resource to manage the application replicas. -Service: Create a Service to expose the HTTP server externally.
Helm Charts:

Structure the Helm chart with templates for Deployment and Service to enable easy installation and management.

Example Deployment Manifest:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: http-server
spec:
  replicas: 3
  selector:
    matchLabels:
      app: http-server
  template:
    metadata:
      labels:
        app: http-server
    spec:
      containers:
      - name: http-server
        image: yourusername/http-server:latest
        ports:
        - containerPort: 8080
        env:
        - name: SERVER_PORT
          value: "8080"  # You can customize this if needed

Example Service Manifest:
apiVersion: v1
kind: Service
metadata:
  name: http-server
spec:
  type: LoadBalancer
  ports:
  - port: 80
    targetPort: 8080
  selector:
    app: http-server

Monitoring with Prometheus and Grafana

Integration Steps:

Prometheus Setup:

Deploy Prometheus using a Helm chart.
Configure Prometheus to scrape metrics from the HTTP server. This requires exposing a /metrics endpoint.

Grafana Setup:

Deploy Grafana using Helm and connect it to Prometheus as the data source.
Create dashboards to visualize key performance metrics.

Exposed Metrics:

Use a Java metrics library, such as Micrometer or Prometheus Java Client, to expose metrics like:

Request count
Response times
Error rates
Thread usage
Memory usage

Example Prometheus Configuration (scrape config):
scrape_configs:
  - job_name: 'http-server'
    metrics_path: '/metrics'
    static_configs:
      - targets: ['http-server:8080']

Summary

Dockerize the HTTP server with a clear and efficient Dockerfile.
Deploy the application on Kubernetes using a Helm chart with necessary configurations.
Integrate monitoring with Prometheus and Grafana, exposing important metrics from the application.

This plan would work as per me. If you have any further add-ons or reductions please do let me know!

Hi @payallenka,
Thank you for expressing your interest in working on this issue. I am impressed with your plan and I'm delighted to inform you that I have assigned this issue to you. Your willingness to contribute to our project is much appreciated.
Before making any contributions, please read the Readme.md file carefully to better understand the project's goals and purpose. This will give you clarity on our mission. Also, make sure to review the Contributing.md file, which contains important guidelines to make the contribution process smoother, especially for newcomers.
Feel free to start working, and if you have any questions or need assistance during the process, please don't hesitate to reach out.

Hi @payallenka,
I hope you're doing well! I wanted to check in and see how things are progressing on the cloud-readiness issue. Have you made any updates or progress on the Dockerization, Kubernetes support, or performance monitoring tasks? If you’ve encountered any challenges or need assistance, feel free to reach out.
Looking forward to your update!

Yup Ajay was caught up in some work (exams actually), I have done most of it you'll have it ready by end of today!

Hi,
Unfortunately there is a slight issue as I won't be able to complete this
task due to some academic work from the college and personal reasons.
Please close the issue to re-assign to someone deserving .
I deeply apologise for the inconvenience caused.
Regards
Payal Lenka
On Sat, Oct 12, 2024 at 1:28 PM Ajay Negi @.***> wrote:

Hi @payallenka https://github.com/payallenka,
I hope you're doing well! I wanted to check in and see how things are
progressing on the cloud-readiness issue. Have you made any updates or
progress on the Dockerization, Kubernetes support, or performance
monitoring tasks? If you’ve encountered any challenges or need assistance,
feel free to reach out.
Looking forward to your update!
—
Reply to this email directly, view it on GitHub
https://github.com/ajaynegi45/Http-Server/issues/10#issuecomment-2408447521,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AT6EWI52PYFEAUXTSCASZITZ3DJBNAVCNFSM6AAAAABPMLFWDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGQ2DONJSGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add files via upload

Name files appropriately for better understanding.

Have Renamed the files, please do check
regards
Maanav T
On Tue, Oct 11, 2022 at 9:09 PM Aby Stalin @.***> wrote:

Name files appropriately for better understanding.
—
Reply to this email directly, view it on GitHub
https://github.com/ACM-Amrita-Amritapuri/thats-what-C-said-about-my-PyPy/pull/21#issuecomment-1274900976,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWD3VLL2C7TX5HQKXYIURGTWCWC4JANCNFSM6AAAAAARCNGE7Q
.
You are receiving this because you authored the thread.Message ID:
<ACM-Amrita-Amritapuri/thats-what-C-said-about-my-PyPy/pull/21/c1274900976
@github.com>

Follow C file naming conventions like :
File names are made up of a base name, and an optional period and suffix. The first character of the name should be a letter and all characters (except the period) should be lower-case letters and numbers. The base name should be eight or fewer characters .

Have renamed it , hope it is correct. please do check
Thank you
regards
Maanav T
On Wed, Oct 12, 2022 at 9:39 AM Akshit @.***> wrote:

Follow C file naming conventions like :
File names are made up of a base name, and an optional period and suffix.
The first character of the name should be a letter and all characters
(except the period) should be lower-case letters and numbers. The base name
should be eight or fewer characters .
—
Reply to this email directly, view it on GitHub
https://github.com/ACM-Amrita-Amritapuri/thats-what-C-said-about-my-PyPy/pull/21#issuecomment-1275559406,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWD3VLMUPSREBXW52IECAMDWCY2YHANCNFSM6AAAAAARCNGE7Q
.
You are receiving this because you authored the thread.Message ID:
<ACM-Amrita-Amritapuri/thats-what-C-said-about-my-PyPy/pull/21/c1275559406
@github.com>

good job 👍


discussion of differences between SCBI & HF/ 1999 drought

@camerondow35 ,
I'm cutting all of the new added text below from the discussion. My reasons are that (1) this is a lot of text, and we need to stay concise and economical with words, (2) we want to keep that first paragraph of the discussion really tight and focused on summarizing how the main results fill our previous gap in understanding, (3) a lot of this content is really results, and is already covered there, and (4) this discussion feels like it's getting too much "into the weeds" (too much detail) for a Nature paper.

We find statistically, but not biologically, significant relationships between total growth and spring temperature at both sites in our dendrometer band analysis (schematic_summary).
However, the slope of the relationships are in opposite directions, with warming causing decreasing stem growth at Harvard Forest but increasing stem growth at SCBI (EDT_phenology_parameters).
We believe this difference is due to severe drought conditions in 1999 which obviously caused abnormal growth patterns in that year (r EDF_pheno_Tmax_climwin).
Therefore, we suggest that our two sites represent two scenarios: 1. A forest which had no significant summer drought, but was only influenced by warming temperatures (SCBI). 2. A forest which experienced spring warming along with severe summer drought (Harvard Forest).
At SCBI, we see a very small increase in total stem growth (on average +0.05mm/$^\circ$C), suggesting that even in the absence of drought or inclement climate conditions during the growing season, spring warming does not enhance stem growth in a meaningful way.
At Harvard Forest, we see a decrease in total growth with warmer temperatures in the CTW (-0.15mm/$^\circ$C on average). We speculate that this result is likely a product of reductions in total stem growth related to drought effects in 1999.
Due to the method of selection for CTW, years with significant departures from the norm can influence the analysis to a greater extent.
Stem growth in 1999 was clearly impacted by climate conditions (r EDF_pheno_Tmax_climwin), and so the CTW selected by climwin maximizes the effect of these impacts (most likely the effects of drought) on stem growth.
To examine this further, we reran our dendrometer band analysis using the month of May as the CTW.
When we change the CTW to the month of May, we see results much closer to those found at SCBI, with a similar advancement in growth timing but a much less pronounced effect of $T_{max}$ on total growth (-0.015mm/$^\circ$C on average, a tenfold decrease compared to the CTW optimized around the drought year;EDF_pheno_Tmax_AprilMay).
Once again see that there was no meaningful influence of spring temperature on total growth.
In fact, the magnitude of the effect of the summer drought compared to the effects of spring $T_{max}$ illustrates the point that conditions during the peak growing season are much more influential to stem growth than conditions during the Spring.

We will want to make sure we capture anything that's unique and important elsewhere, which is why I'm opening this issue.

On a related note, we say "However, we did not find evidence that higher spring temperatures were correlated with summer drought stress in our dendrometer band analysis, implying that the effects of warm spring temperatures on stem growth elucidated here (Fig. r schematic_summary) were not attributable to summer drought." This is detailed in the methods. But this seems to contradict the removed text above. @camerondow35 , did you redo that analysis? Or is this text old?

I suppose it's worded weird and I definitely should've updated it, sorry.

"However, we did not find evidence that higher spring temperatures were correlated with summer drought stress in our dendrometer band analysis, implying that the effects of warm spring temperatures on stem growth elucidated here (Fig. r schematic_summary) were not attributable to summer drought."

This statement refers to the average effect of spring temps on summer SPEI. We found no significant effect, and so we say that on average, the spring temps weren't causing more drought. If you look at our SPEI plots we see that 1999 there was a potential relationship, but every other year reduces the impact of 1999 on the overall analysis:

How about: "We did not find evidence that higher spring temperatures were correlated with summer drought stress in our dendrometer band analysis, implying that warmer spring temperatures were acting independent of summer drought in most years of our analysis. However, we see a clear effect of summer drought at Harvard Forest in 1999 which reduced growth in that year."

As for removing all of that text, we need to include some discussion explaining the differences somewhere. Maybe Including it around the discussion of SPEI? I think including it in the statement I suggested above might work. I think it deserves a good amount of attention in the discussion, but if you think it's less important that's fine.

I still question whether it deserves so much attention. It's one anomalous year at one site, and while it does affect the slopes of relationships, it doesn't fundamentally change the story. In a paper this concise, there's really not much space to get into side-stories.
Also, I'm wondering how anomalous 1999 really was. Do you have additional sources documenting this as a year of significant drought besides SPEI? A SPEI of ~ -1 is drier than average, but based on my understanding of the metric and the SPEI website, it doesn't seem to qualify as a very rare or extreme drought. Looking at your full plots (below), there was a year at SCBI that was almost as dry.

Neil talks about how HF hasn't had any really meaningful drought in decades...

I guess I took Loic's word for it:
"On-site weather records indicate that the study period included the driest summer (1999) over a 26-year period (1991–2017), with monthly precipitations of 52 mm relative to a monthly average of 111 mm from June to August. The last two decades, however, represent a regional wet period with increased frequency of rainfall events during the summer ([Bishop and Pederson 2015]."

Knowing that ^ and seeing how 1999 was a very anomalous year, I just put 2 and 2 together.

Anomalous in terms of growth patterns*. If you look at the pheno_tsensetivity figure it stands out alot, and needs to be explained.

I definitely wouldn't deny that it's the driest, but that doesn't necessarily make it a strong drought, especially given the trend toward increasing rainfall at the site. Defining and quantifying drought is always tricky-- there are many different definitions and time scales, and then the question of if/how it's biologically relevant. (And we do see that year as anomalous, so worth mentioning, but not sure it justifies being highlighted/ discussed.)

Anomalous in terms of growth patterns*. If you look at the pheno_tsensetivity figure it stands out alot, and needs to be explained.

1999 is the year on the far right of these plots, correct?

1999 is the year on the far right of these plots, correct?

Yep!

(And we do see that year as anomalous, so worth mentioning, but not sure it justifies being highlighted/ discussed.)

I think it also highlights a weakness of our analysis, which is worth discussing too. It's a good launching point into the monthly tmax ctw's instead of the climwin derived ctw's

I think it's good to mention this (at least in theory). We obviously wouldn't want to hide it, but I also don't think it clears the (high) bar for discussion of more than 1-2 sentences in the main manuscript (if that). It's one anomalous year, but I don't think it would qualify as enough of a drought that one would want to claim it as a good example for understanding drought responses. The fact that we have such a limited sample size (1 drier year, 4 "normal") makes me uncomfortable in using this to try to draw broad conclusions.

I believe you meant April, not May, in this statement: "To examine this further, we reran our dendrometer band analysis using the month of May as the CTW." Correct? (You're talking about the analysis in Extended Data Fig. 5, which is all April, right?)

(And we do see that year as anomalous, so worth mentioning, but not sure it justifies being highlighted/ discussed.)

I think it also highlights a weakness of our analysis, which is worth discussing too. It's a good launching point into the monthly tmax ctw's instead of the climwin derived ctw's

Agree, BUT... The discussion of a Nature (or short format) paper needs to be really concise and stick to the most essential points. While the results are somewhat influenced by this anomalous year, it does not affect our conclusions. Similarly, we have somewhat different results but the same conclusions regardless of how we select the CTW.

(You're talking about the analysis in Extended Data Fig. 5, which is all April, right?)

It was always May for HF from what I remember, but we get similar results for April tmax. EDF5 is all May now, because SCBI DOY25 was weird for April tmax.
I was planning on creating an official version of that "comparison table" for the SI. In it i'd like to have bayesian results for climwin, april, and may CTW's. Would you be fine with that?

While the results are somewhat influenced by this anomalous year, it does not affect our conclusions.

Ok, I think adding 1-2 sentences and the suggested SI comparison table could be enough.

(You're talking about the analysis in Extended Data Fig. 5, which is all April, right?)

It was always May for HF from what I remember, but we get similar results for April tmax. EDF5 is all May now, because SCBI DOY25 was weird for April tmax.
I was planning on creating an official version of that "comparison table" for the SI. In it i'd like to have bayesian results for climwin, april, and may CTW's. Would you be fine with that?

I don't think we have space-- we'd have to sacrifice some other display item, as we're at the 10 max.

We do need to acknowledge that for whatever reason, 1999 had the lowest total growth. While it might not have been a major drought, it seemed to have some effect.
Year  Total Growth
1999 0.1897616
2000 0.2013485
2001 0.2173154
2002 0.2168089
2003 0.2024734

It was always May for HF from what I remember, but we get similar results for April tmax. EDF5 is all May now, because SCBI DOY25 was weird for April tmax.

We had all April in the submitted version: https://github.com/EcoClimLab/growth_phenology/issues/82.

Are you able to shift this conversation to Teams? The back-and-forth on GitHub issues is tough.

We do need to acknowledge that for whatever reason, 1999 had the lowest total growth. While it might not have been a major drought, it seemed to have some effect.
Year Total Growth 1999 0.1897616 2000 0.2013485 2001 0.2173154 2002 0.2168089 2003 0.2024734

So 1999 growth is 87% that of highest year (2001) and 94% that of 2nd-lowest year (2000). While lower and something we can mention if space permits, I still wouldn't make a big deal of it.

Since we're already over length, we don't have space to discuss this. (I wouldn't prioritize it over current content.) So closing.


To reduce dependency footprint, logic which uses ESnext decorators should be separated into another package

The only code I have which makes use of ESnext decorators (proposal) is the ViewModel-creation code.
This should be separated into a different npm package so that the core does not depend upon that technology.


BLD: Need correct param for setup to specify extra reqs

Otherwise, $ pip install -e .[bayesian] warns me:
"pyfolio 0.5.1+37.gb684c3a does not provide the extra 'bayesian'"
Also, Theano will get installed by pymc3 extra dependency

@richafrank looks like we fixed "pyfolio 0.5.1+37.gb684c3a does not provide the extra 'bayesian'" at the same time
https://github.com/quantopian/pyfolio/pull/332

Oh nice!  Should we close or merge this?

This pr also removes theano (mine doesn't) we can merge this and I'll update my branch.


update PPP

Codecov Report

Merging #245 (246c37a) into master (5f61565) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage     48.60%   48.60%
  Complexity      643      643
=========================================
  Files           137      137
  Lines          2874     2874
  Branches        370      370
=========================================
  Hits           1397     1397
  Misses         1374     1374
  Partials        103      103

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Fix] Navbar UI for mobile displays

Updated navbar UI behaviour to collapse on navigation link clicks on small viewports.

Preview on https://aniverma17.github.io/Pyladies-delhi-website

LGTM.


add tosdr?

Hey there @tastapod @Voker57 @kant @StevenBlack
ToS;DR do distribute a hosts file blocking any website with an E grade. It can be found at https://api.tosdr.org/pihole/

Thank you for this Lucas @lucasnuic.
We definitely will not be doing this.
We try not to block the root domains of businesses.  Like their home pages, for example.  Because we don't employ enough lawyers to deal with that.
We try to block the actual domains used to convey ads, tracking, or worse. This is rarely the root domain, and certainly never the root domains of large companies.
Closing!


[bug] add namespace selector into PodMonitor

What this PR does / why we need it:
w/o enable namespace selector, PodMonitor could not locate which namespace Pods need to be monitored
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Since we don't have any extensive integration tests yet for this integration, just make sure this gets tested manually locally and then LGTM 👍

This will be covered in performance test tool command.