Installation on OS 10.10 with Python 3.3 failed

I want to install the chrome language detection (cld) https://github.com/mzsanford/cld for Python.
I am working on OS X 10.10 with Python 3.3, installed through a download of the .dmg from the Pythonwebsite.
What did I do so far?

Downloaded and updated xCode to the most recent version
Command Line Tools for xCode installed with that line $ xcode-select –install
Downloaded the GNU, C and C++ Compilerhere http://hpc.sourceforge.net and installed via $ sudo tar xvf gcc-4.9-bin.tar -C /
Install the libcld C++ library following the instructions on https://github.com/mzsanford/cld (I installed it from source, not with homebrew)!
Installed the pkg-config package $ git clone git://anongit.freedesktop.org/pkg-config

Then I followed the steps described to install the Pythonbindings:
$ git clone http://github.com/mzsanford/cld.git

$ cd cld/ports/python

$ make install # This will prompt for your password

Which gave me this error message:
python -u setup.py build
Traceback (most recent call last):
File "setup.py", line 17, in <module>
**pkgconfig('cld'))
TypeError: __init__() keywords must be strings
make: *** [build] Error 1`

I also downloaded the source and tried to install it with python3.3 setup.py which gives me this
 pkg-config has not been found but this setup script relies on it.

Well, I installed id, but it seems that it does not find it.
Might that be a problem that it installed it to the Python the system is using (which would 2.7) while I use Python3.3? Or other suggestions?

I had not worked on Python 3 support. I just added a version of it to the py3 branch. Please try it out and see if it works for you.


Add Repository Iterator/Crawler to client

Adds a repository iterator/crawler to the Java client.  Uses the streaming NTriples format from Fedora to stream very large result sets, so it is reasonable to iterate the entire contents of a large repository.
Crawling/iterating the repository.
Simple walking of PASS entities is achieved by providing a Consumer<URI>, which is invoked for each matching PASS entity.  The API provides a mechanism for crawling all PassEntities (under an implicit base URI, FedoraConfig.getBaseUrl()):
PassClient client = PassClientFactory.getPassClient();

// Process all PASS entities
client.client.processAllEntities(myConsumer);

// Process only submissions
client.client.processAllEntities(myConsumer, Submission.class);

For finer-grained control, ise org.dataconservancy.pass.client.fedora.RepositoryCrawler. Resources can be ignored (not sent to the consumer, but their children still recursed), or skipped entirely (thus preventing recursion to their children).  RepositoryCrawler.Ignore and RepositoryCrawler.Skip classes have useful predicates for skipping or ignoring resources.
For example, to iterate ONLY submission resources (and not binary files that might be children of them), use recursion depth of 1, and ignore the parent submissions/ container, as it is not a Submission:
import static org.dataconservancy.pass.client.fedora.RepositoryCrawler.Ignore.IGNORE_ROOT;
import static org.dataconservancy.pass.client.fedora.RepositoryCrawler.Skip.depth;
...

RepositoryCrawler crawler = new RepositoryCrawler();
int numVisited = crawler.visit("http://localhost:8080/fcrepo/rest/submissions/", myConsumer, IGNORE_ROOT, depth(1));

As another example, to iterate ALL pass entities, ignoring ACLs,  ignoring parent containers, and ignoring children of PASS entities (like binary files POSTed to submissions), start with the repository root, to a depth of 2, and ignore containers:
import static org.dataconservancy.pass.client.fedora.RepositoryCrawler.Ignore.IGNORE_CONTAINERS;
import static org.dataconservancy.pass.client.fedora.RepositoryCrawler.Skip.SKIP_ACLS;
...

RepositoryCrawler crawler = new RepositoryCrawler();
int numVisited = crawler.visit(URI.create(FedoraConfig.getBaseUrl()), myConsumer, IGNORE_CONTAINERS,
            depth(2).or(SKIP_ACLS));

Resolves #51

I like the idea of adding those simple API methods, which will handle many use cases.  I'll add a commit that adds those methods, using the RepositoryCrawler as the implementation, and leaving it public so that clients can use RepositoryCrawler directly for use cases that extend beyond iterating PASS entities (such as iterating ACLs, or binary files, etc).

Looks great! I think this is a really good addition to the client. :)


Add NPM publisher for jinja package

New repo created at http://github.com/alphagov/govuk_template_jinja and initially updated by running this code locally.
Follows the same pattern as other NPM published versions, like mustache and ejs. There's quite a bit of duplication in the publisher code, but this doesn't feel like the time to refactor it, partly as we're looking at what might replace govuk_template as part of the Patters and Tools team discovery.

This looks to be the same as the other publisher files, for example, the publisher for the mustache version of the template.

Update, npm packages aren't being updated when we release a new version, due to some incorrect config in our CI server (which does the pushing).
The npm credentials were rotated recently, and although they were updated in CI deployment config, this hasn't fully deployed to the CI, so the publish tasks are still using the old auth and failing.
GOVUK Infrastructure are looking into this at the moment, but once it's fixed we may need to do some cleanup to ensure any missed releases are published.


Fix font to be the same as design

@smn I wasn't sure about them I saw them in the design, can you explain what those are for? should I remove them or change the NDOH to TUNEME/or something else?

@stevebarnett could you explain to @saeedmb8 (or point him in the right direction?) what the meta tags with name & property attributes are for?

Thanks @smn

@saeedmb8 Here's a quick rundown:
<meta name="description" content="" /> is what appears in search engines results, like this. It's often filled from a "site descripton" or "page description" field in a CMS.
<meta name="keywords" content="NDOH" /> was historically used by search engines, but these days the content of a page has more "weight." It's still useful to have these here. [The Foundation site](http://praekeltfoundation.org/, for example, has things like consulting, mobile, web.
<meta name="viewport" content="width=device-width, initial-scale=1" /> is a nudge for mobile browsers to display the content properly for devices that have a hi-res screen (like many Androids these days, and most iPhones). It says something like "show the content at the width of the device." Here's more on MDN.
 <meta http-equiv="content-type" content="text/html;charset=utf-8" /> sets the content encoding. A shorter, nicer, version is <meta charset=utf-8>.
<meta property="og:title" content="NDOH" /> and <meta property="og:description" content="NDOH"> are Open Graph things, basically both for "Facebook SEO". These can be the same as the regular meta title and description.

There's more of these kind of things in the excellent documentation for h5bp.

How's that, @smn? :)

Thanks @SteveBarnett for your wonderful explanation :) now they make sense to me :))

@saeedmb8 Welcome! \o/

@smn I've removed the NDOH and left it empty until I get the contents for them.

@smn @bruskiza @miltontony ready for review

:+1: even though they empty


[Tiered storage] Replace usage of shaded Guava Supplier with java.util.function.Supplier

Motivation

it is a bad practice to reference shaded classes in other modules.
Guava's Supplier class is a legacy class in Guava:

"Legacy version of java.util.function.Supplier."

Modifications

Replace the usage of the shaded Guava Supplier with java.util.function.Supplier.

This is also instructed in the javadoc of Guava's Supplier:

"As this interface extends java.util.function.Supplier, an instance of this type can be used as a java.util.function.Supplier directly. To use a java.util.function.Supplier in a context where a com.google.common.base.Supplier is needed, use supplier::get."


GH-35515: [C++][Python] Add non decomposable aggregation UDF

Rationale for this change
Non decomposable aggregation is aggregation that cannot be split into consume/merge/finalize. This is often when the logic rewritten with external python libraries (numpy, pandas, statmodels, etc) and those either cannot be decomposed or not worthy the effect (these are often one-off function instead of reusable one). This PR implements the support for non decomposable aggregation UDFs.
The major issue with non decomposable UDF is that the UDF needs to see all data at once, unlike scalar UDF where UDF only needs to see a batch at a time. This makes non decomposable not so useful as it is same as collect all the data to a pd.DataFrame and apply the UDF on it. However, one very application of non decomposable UDF is with segmented aggregation. To refresh, segmented aggregation works on ordered data and passed one logic chunk at a time (e.g., all data with the same date). With segmented aggregation and non decomposable aggregation UDF, the user can apply any custom aggregation logic over large stream of ordered data, with the memory overhead of a single segment.

What changes are included in this PR?
This PR is currently WIP and not ready for review.
So far I have implemented the minimal amount of code to make a basic test working but needs clean up, error handling etc.

[x] First round of self review
[x] Second round of self review
[x] Implement and test unary
[x] Implement and test varargs
[x] Implement and test Acero support with segmented aggregation

Are these changes tested?
Added new test calling with compute and acero.
The compute tests calls the aggregation on the full array. The acero test callings the aggregation with segmented aggregation.

Are there any user-facing changes?

Closes: #35515

@westonpace I think the PR is in a good shape for review. I will be out until 5/28 so please take your time to review this and I will address them when I get back. If there are other people that you think should be on the reviewer list I can ping them as well.

@westonpace any chance you can take a look at this? Or maybe some else can help review?

@westonpace any chance you can take a look at this? Or maybe some else can help review?

I'll commit to looking at this tonight.

Also, it may be interesting to @felipecrv who has played around with the kernels some.

@felipecrv @westonpace I think all the comments are addressed except for this one: https://github.com/apache/arrow/pull/35514#discussion_r1205081272 (which needs a bit more discussion since I am not sure the best way to handle python ref counting here.
Please take another look thanks!

@westonpace I believe this PR is good to go. The failed CI seems unrelated. I have checked the Py refcount and it seems OK (I will add details in the comment thread above)

@icexelloss I'll take another look through today.

@icexelloss I'll take another look through today.

Thank you!

I checked failed CI jobs and those seem unrelated.


Added cli to run reader from command line

Will these changes still allow the codes that import functions from nitrates_reader to work properly?

checks failed E
File "/opt/hostedtoolcache/Python/3.8.17/x64/lib/python3.8/site-packages/nitrates-1.0.2-py3.8.egg/nitrates/post_process/nitrates_reader.py", line 844
E       if args.work_dir not None:
E                            ^
E   SyntaxError: invalid syntax

This is not an executable, and is being imported by other parts of nitrates. please add if name==main or whatever to embed the cli calls

Ok, now it seems the checks have passed. Do I open another PR on Alfred to add:
python -m nitrates.post_process.nitrates_reader --work_dir ${workdir}
?

Have you actually tested it?

I get this when I test it:
read_results_dirs('%s' %args.work_dir)
TypeError: read_results_dirs() missing 1 required positional argument: 'api_token'

and what I tested is
python -m nitrates.post_process.nitrates_reader --work_dir /gpfs/group/jak51/default/nitrates_all_results/2023/tar/712491393_c0

ok, with the inclusion of API token it works

ok, in the future please try to test before opening a PR


Verify samples during CIs

Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.

We'll need to add this to languages' ci.yml files as needed. I considered adding it to other shared steps but they are all fairly specific. I made this file to at least be more general to samples, with this one specific step to check sample metadata (frontmatter). I tweaked my original script to make it easy to add other validations if/when we so choose.
/cc @weshaggard @benbp

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

Also, the script is written according to PowerShell recommendations. It takes pipeline input so you can easily, robustly get a list of files by any other means and pipe it to this script, much like other cmdlets e.g. Test-Path. This means, for example, someone could run it manually as I have been doing over repos:
$files = dir sdk -filter *.md -recurse | Test-SampleMetadata.ps1 -AllowParentProducts -PassThru
vim $files # opens all of them to fix

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

In fact, @weshaggard do we want to take this opportunity to combine some validation into a single set of steps all pipelines can run - making it easier to plug in common validations across repos? For example, the link checker is likely consistent (or should be) across language repos.
If necessary, we could add task- (or task group-) specific conditions if we want to turn specific validations off for some reason. I'd be happy to start that in this PR since I'll have to make changes to at least some of the language repos (was planning on the tier 1 languages).


Refer to internal representations instead of Edwards points

The README currently contains language like:

The ristretto technique gives a way to map ristretto255 group elements to Edwards points (fromBytes()) and to convert a certain subset of Edwards points back to ristretto255 group elements (toBytes()).

This suggests to users that it is potentially valid to convert between ristretto255 group elements and Edwards points, and use the latter in other contexts. This is not the case, as the ristretto255 RFC draft strongly states in section 4 (and elsewhere in the spec):

ristretto255 is an abstraction which exposes a prime-order group, and
ristretto255 elements are represented by curve points, but they are
not curve points.  The API needs to reflect that: the type
representing an element of the group SHOULD be opaque and MUST NOT
expose the underlying curve point.
It SHOULD be possible for a ristretto255 implementation to change its
underlying curve without causing any breaking change.  A ristretto255
implementation MUST be interoperable with any other implementation,
even if that implementation uses a different curve internally.  Any
operation on ristretto255 elements that only works correctly or leads
to different results based on the underlying curve is explicitly
disallowed.
In particular, implementations MUST NOT define the ristretto255
functions as operating on arbitrary curve points, and they MUST NOT
construct group elements except via "DECODE" and
"FROM_UNIFORM_BYTES".
However, it is RECOMMENDED that implementations don't perform a
"DECODE" and "ENCODE" operation for each operation in Section 3.3, as
it is inefficient and unnecessary.  Implementation SHOULD instead
provide an opaque type to hold the internal representation in between
operations.

I presume that limitations of JavaScript prevent you from providing an opaque type that contains the internal representation as an Edwards point (thus making the safe APIs perform a DECODE and ENCODE operation for each API operation). An opaque type is strongly preferred, but if it is not possible, then the language in the README should be altered to ensure that users understand they MUST NOT operate directly on the internal representations (beyond the specific unsafe APIs provided) under any circumstances.

Thanks for pointing this out -- README updated.


Is it possible to exclude specific cluster like we have exclude-region?

Description:
We wanted to exclude certain clusters while running cloud nuke. We see how to exclude regions and resource type. Is there any way to exclude cluster id's as well?

Hey @sreenusuuda, which cluster are you referring to? Can you elaborate on what you are trying to achieve with cloud-nuke? (e.g., your setup, resources you are trying to nuke)

Actually we are creating lot of Kubernetes clusters on our day to day activities. We are running cloud-nuke on regular basis to avoid cloud costs. We are currently nuking entire region which deletes all the available kubernetes clusters. Do we have any option to delete all the resources in the region excluding some clusters and its attached resouces?
eg: cloud-nuke aws --exclude-region --exclude-eks XYZ

Hey @sreenusuuda, have you tried using the config to exclude certain resources when nuking?
Here is an example and you can find more in the README file:
s3:
  exclude:
    names_regex:
      - ^alb-.*-access-logs$
      - .*-prod-alb-.*


Remove fee_paid from transaction response

The fee_paid field in the Horizon transaction response will be removed when Horizon 0.25 is released.  The fee_paid field has been replaced by max_fee, which defines the maximum fee the source account is willing to pay, and fee_charged, which defines the fee that was actually paid for a transaction. See CAP-0005 for more information.

This involves simply updating the VCR files cached from prior testing calls. No change in functionality.

isn't there anything in the SDK that stores and renders this response and would therefore need to change?

Nope, no mentions of fee_paid anywhere in the repo


Android Support: Exporting to Android Archive (AAR)

This pr add functionality to support android archives in vcpkg through exporting libs and includes to aar archives. This works similar to ndkports currently in the works by @DanAlbert . Once the archive is created then it can imported in the android as a native dependent.
Checkout the article "Native Dependencies in Android Studio 4.0" about prefab and native dependencies on https://android-developers.googleblog.com/2020/02/native-dependencies-in-android-studio-40.html
Checkout the prefab  project on https://github.com/google/prefab
See NDK ports for more https://android.googlesource.com/platform/tools/ndkports
Todos

[x] ability to auto build all android ports to support the 4 android Abis for i.e arm64-v8a, armeabi-v7a, x86_64, x86
[x] prevent requiring port triple
[x] Failing if port is not android specific
[x] Testing on other platforms (tested on OS X)

Example exporting [jsoncpp]
Requires

maven
ndk
7zip or zip

The following packages are already built and will be exported:
    jsoncpp:x86-android
Exporting package jsoncpp...
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------< org.apache.maven:standalone-pom >-------------------
[INFO] Building Maven Stub Project (No POM) 1
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-install-plugin:2.4:install-file (default-cli) @ standalone-pom ---
[INFO] Installing<root>/prefab/jsoncpp/jsoncpp-1.9.2.aar to /.m2/repository/com/vcpkg/ndk/support/jsoncpp/1.9.2/jsoncpp-1.9.2.aar
[INFO] Installing <vcpkg_root>/prefab/jsoncpp/pom.xml to /.m2/repository/com/vcpkg/ndk/support/jsoncpp/1.9.2/jsoncpp-1.9.2.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.301 s
[INFO] Finished at: 2020-03-01T10:18:15Z
[INFO] ------------------------------------------------------------------------
Successfuly installed jsoncpp. Checkout <vcpkg_root>/prefab/jsoncpp/aar

Export
prefab
└── jsoncpp
    ├── aar
    │   ├── AndroidManifest.xml
    │   ├── META-INF
    │   │   └── LICENCE
    │   └── prefab
    │       ├── modules
    │       │   └── jsoncpp
    │       │       ├── include
    │       │       │   └── json
    │       │       │       ├── allocator.h
    │       │       │       ├── assertions.h
    │       │       │       ├── autolink.h
    │       │       │       ├── config.h
    │       │       │       ├── forwards.h
    │       │       │       ├── json.h
    │       │       │       ├── json_features.h
    │       │       │       ├── reader.h
    │       │       │       ├── value.h
    │       │       │       ├── version.h
    │       │       │       └── writer.h
    │       │       ├── libs
    │       │       │   ├── android.arm64-v8a
    │       │       │   │   ├── abi.json
    │       │       │   │   └── libjsoncpp.so
    │       │       │   ├── android.armeabi-v7a
    │       │       │   │   ├── abi.json
    │       │       │   │   └── libjsoncpp.so
    │       │       │   ├── android.x86
    │       │       │   │   ├── abi.json
    │       │       │   │   └── libjsoncpp.so
    │       │       │   └── android.x86_64
    │       │       │       ├── abi.json
    │       │       │       └── libjsoncpp.so
    │       │       └── module.json
    │       └── prefab.json
    ├── jsoncpp-1.9.2.aar
    └── pom.xml

13 directories, 25 files

Requires JAVA and Gradle ?

Requires JAVA and Gradle ?

Gradle is required on the consumption end of this, but not on the production end.
The Java requirement comes from maven, which could be avoided if needed (it could also potentially be made an optional requirement).

@DanAlbert
and if you look at the future\in advance, and not just in these edits

@atkawa7 @DanAlbert https://github.com/android/ndk/issues/916#issuecomment-568042185
Can this be made to be used to build the prefabs you'll deliver?
Or maybe also integrated into AS UI (SDK Manager) to search, get/build and include packages manually/automatically with as little dependencies as possible and use what's available in the AS installation.

Requires JAVA and Gradle ?

Gradle is required on the consumption end of this, but not on the production end.
The Java requirement comes from maven, which could be avoided if needed (it could also potentially be made an optional requirement).

@atkawa7 If at some point prefabs support: https://github.com/google/prefab/issues/65#issue-566719573 Can this feature be extended to produce debuggable prefabs?

@Zingam that is doable. VCPKG supports debug libs  but I didn't include them since prefabs doesn't support them yet. Once i google/prefab#65 is supported I am sure we can add the debugs.

Thanx! I just wonder how all this stuff would fit into my current build system as I have custom Find*.cmake modules to build and configure the libraries I need. I use vcpkg for my Windows and Linux builds.

@atkawa7 @DanAlbert android/ndk#916 (comment)
Can this be made to be used to build the prefabs you'll deliver?

Not sure what the benefit would be. Getting this merged here makes it available to users. Us using it wouldn't make a difference.

Or maybe also integrated into AS UI (SDK Manager) to search, get/build and include packages manually/automatically with as little dependencies as possible and use what's available in the AS installation.

I don't think that's the right approach. Users should be fetching prebuilts, not building the libraries themselves. This patch makes it easy for someone to build the vcpkg corpus for Android and push them to maven as AARs. The better solution would be for someone to do that instead.

/azp run

It looks like we cannot use these changes to build vcpkg in Windows anymore.

@DanAlbert Thank you for your good reviews. @JackBoosY @ras0219-msft See the news changes. Now its buildable on Visual Studio

This is seriously amazingly cool, and also I am not at all a person who is ready to review this. We'll discuss this at our weekly PR meeting, and I'll make sure that this gets the review it needs 😄. Thanks so much @atkawa7 and everyone else!

Or maybe also integrated into AS UI (SDK Manager) to search, get/build and include packages manually/automatically with as little dependencies as possible and use what's available in the AS installation.

I don't think that's the right approach. Users should be fetching prebuilts, not building the libraries themselves. This patch makes it easy for someone to build the vcpkg corpus for Android and push them to maven as AARs. The better solution would be for someone to do that instead.

I think there is a strong case for building from sources but time will tell, including the case when custom versions of libraries might be needed. I am not familiar with the process of publishing android libraries and all I could find are a few blog posts, so I may be missing information.
vcpkg has a good corpus of libraries already and even has everything I need for now and is well maintained.

@JackBoosY @strega-nil @ras0219-msft  Checkout the new changes

CI test success.
@dan-shaw

Passing CI now, and it looks like all review comments are fixed. Thanks @atkawa7 and everyone for the PR and reviews!

Should add the new files export.prefab.cpp, export.prefab.h to vcpkglib.vcxproj.filters

I hope the vcpkg doc will be updated soon in order to reflect this, since for the moment this feature is mostly hidden for users (the official doc about triplets only mentions info about outdated android standalone toolchains.

@pthom This isn't really a feature the vcpkg team knows much about; if you'd like to write up the docs, we'd absolutely appreciate it :) (or if @atkawa7 would like to come back and write docs!)

@pthom @strega-nil  there is currently documentation on how to integrate android archives
See this  document https://github.com/microsoft/vcpkg/blob/master/docs/specifications/prefab.md
See #11052 for configuration issues that might pop up.
You need to create the four android triplets yourself. Initially I had added triplets but then removed them since android users need custom triplets.

@pthom This isn't really a feature the vcpkg team knows much about; if you'd like to write up the docs, we'd absolutely appreciate it :) (or if @atkawa7 would like to come back and write docs!)

My proposition, where I made some changes in the doc that would have helped me a lot:
https://github.com/microsoft/vcpkg/pull/11264

I am not a native English speaker but I think that there are some grammatical errors in the document. Also prefab.md isn't very descriptive unless you already know what you look for? Perhaps Android-prefab.md or something like that would be better?

@Zingam I think just android is even better


Integration with djanog-allauth

Is there integration with this ADFS provider and django-allauth?  If so is there any documentation or code samples?
Currently running allauth but love the features available with django-allauth-adfs for groups and claim mappings etc.  Any help would be appreciated.

What troubles are you encountering?

I have not tried it yet. I am building a new site and loved what allauth brings with user management but found your package. New to a lot of this Django stuff so learning as I go and docs/examples really help.
Can I just install the package - add the config to settings.py and then auth from my AD tenant?
Thanks in advance
-Brant
Sent from my iPhone

On Oct 2, 2022, at 12:07 PM, thenewguy @.***> wrote:

What troubles are you encountering?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Yes. You configure it like an allauth provider. I am happy to help if you have any issues getting it to work. Perhaps you could document what is unclear and add it to the readme

Thank you. I am having a site design/planning session tomorrow to chart our
project development.
So far we have mocked up a bunch of ideas and the board of my organization
approved my ideas…. Now I need to produce!! So I am starting fresh with a
Django 4+ project with django-invitations, django-allauth and now that I
found your package, I will work on integration.
Thank you for the help.
-Brant
On Sun, Oct 2, 2022 at 12:44 PM thenewguy @.***> wrote:

Yes. You configure it like an allauth provider. I am happy to help if you
have any issues getting it to work. Perhaps you could document what is
unclear and add it to the readme
—
Reply to this email directly, view it on GitHub
https://github.com/thenewguy/django-allauth-adfs/issues/6#issuecomment-1264708014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABK4KR7TSZFCR3CLAW7B7ALWBHJZFANCNFSM6AAAAAAQ27MXVU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sounds good. Going to close this issue. If you hit any trouble open a new specific issue and we'll get you sorted. If you can improve the documentation, a PR would be appreciated


[5.9] Complete regex literal lexing

5.9 cherry-pick of https://github.com/apple/swift-syntax/pull/1463
Medium risk, but fixes a whole bunch of regex literal parsing issues.

The previous regex literal lexing logic didn't implement all the heuristics needed to parse all the regex literals that the old C++ parser handles. Update it with the heuristics it needs, and better handle diagnostics for invalid cases.
This unfortunately requires a bit of lexical hackery, including a heuristic to classify previous token kinds to determine if we're in regex literal position, but it's needed to handle pathological cases such as x /^ y/ where there's an ambiguity with a binary operator.
Resolves #1059
rdar://102213809

https://github.com/apple/sourcekit-lsp/pull/725
@swift-ci please test

https://github.com/apple/sourcekit-lsp/pull/725
@swift-ci please test Windows

https://github.com/apple/sourcekit-lsp/pull/725
@swift-ci please test Windows

https://github.com/apple/sourcekit-lsp/pull/725
@swift-ci please test Windows


⚠ ClamAV has degraded performance

In 1051957, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in fad78b1 after 5 minutes.


Expand implicit tuple patterns in the AST

This patch expands what were previously hidden tuple patterns inside enum element patterns that match a case with associated values.  For example:
enum X {
  case y(bool)
}

switch X.y(true) {
  case .y: ()
}

case .y used to be typechecked as an enum element pattern with no sub-pattern.  Now, it will be typechecked as case .y(_).
This allows the elimination of corner cases in the Space Engine and fixes the size heuristic in the case of large sub-patterns that were being omitted by the user in a pattern match.

@swift-ci please smoke test

Looks good. The SILGen test change is probably benign, but worth verifying.

@swift-ci please smoke test

@swift-ci please smoke test

In light of the unintended SILGen change:
@swift-ci please test

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 576b8e34a366e6ca649b6f1e9f4a566b143ee53e
Test requested by - @CodaFi

Cool.  Will nominate for 4.0 shortly.

@CodaFi Another fun one:
enum E {
  case c
  case d
}

func f(e: E) {
  guard case let .c(value) = e else { // crash
    return
  }
}

Doesn't seem to crash with a switch though (the payload is bound to ()).

Was that introduced by this one?

No, this is an old bug that's been there for ages. I think it's related though.

Hm.. Well I can't seem to get it to crash on master right now.

Nevermind, this crashes in Lowering.

Just FYI: https://bugs.swift.org/browse/SR-3466


Add demo of Report.add_html() for adding custom HTML or simple text to the report

cc @SophieHerbst

I recently added something like that: https://mne.tools/dev/auto_tutorials/intro/70_report.html?highlight=report#adding-custom-html-e-g-a-description-text
#10603

Oooooh so this is where we saw it before, @SophieHerbst!!
@sappelhoff We were both like, "hum, I thought this was demo'd somewhere!" but couldn't find it anymore. Turns out we should've looked in the dev docs instead of browsing only the stable ones… 🤦


Fix 146987， duplicate completion item when search extension by category

This PR fixes #146987

https://github.com/microsoft/vscode/blob/d2663decf774f5ca5472c25d55e9e47e0c3b9ad3/src/vs/editor/contrib/suggest/browser/suggestModel.ts#L656-L664
inactiveProvider contains those providers have not contributed to this completion model, but if there is only one CompletionProvider for this model, inactiveProvider will be an empty Set
https://github.com/microsoft/vscode/blob/d2663decf774f5ca5472c25d55e9e47e0c3b9ad3/src/vs/editor/contrib/suggest/browser/suggest.ts#L276-L278
when inactiveProvider is empty , The above case will fail, result in the only one completion provider be called again.  so we should remove the options.providerFilter.size > 0 condition.

I am not sure if this is the right location for the fix. Settings Editor also use same widget and this issue is not seen there. Can you please check the difference between Extension Input usage and Settings Search usage?

Settings Editor also use same widget and this issue is not seen there.

This is because completion items for Setting Editor doesn't contains character ",
https://github.com/microsoft/vscode/blob/d3af2375bcabd03b2fe8756483ba967bd5fe6a40/src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts#L104-L111
while the extension query completion item does contains:
https://github.com/microsoft/vscode/blob/d3af2375bcabd03b2fe8756483ba967bd5fe6a40/src/vs/workbench/contrib/extensions/common/extensionQuery.ts#L19
character " will start a new leadingWord which is in class LineContext, and fulfil this condition:
https://github.com/microsoft/vscode/blob/d3af2375bcabd03b2fe8756483ba967bd5fe6a40/src/vs/editor/contrib/suggest/browser/suggestModel.ts#L653-L665
And if I insert " into the setting Editor's completion item, like this:
	private static SUGGESTIONS: string[] = [
		`@${MODIFIED_SETTING_TAG}`,
		'@tag:"notebookLayout"',
		`@tag:${REQUIRE_TRUSTED_WORKSPACE_SETTING_TAG}`,
		`@tag:${WORKSPACE_TRUST_SETTING_TAG}`,
		'@tag:"sync"',
		'@tag:"usesOnlineServices"',
		'@tag:"telemetry"',
		`@${ID_SETTING_TAG}`,

it will show duplicate suggestion. The duplicate item disappeared with this patch applied.

@sandy081

Assigning to @jrieken - assuming that the file is being owned by him.

@jrieken , the problem it caused is https://github.com/microsoft/vscode/issues/146987

The reason is explained above in this thread. If you still think it's not a good fix. Maybe I have misunderstood something. I can close this PR.

This PR caused the tests fail. Close it


refactor: remove circular dependencies through net_processing (2/N)

Issue being fixed or feature implemented
The architecture of bitcoin assumes that there's no any external class that processes network messages and knows anything about PeerManager from net_processing; no any external call for PeerManager::Misbehaving in bitcoin. All logic related to processing messages are located in net_processing.
Dash has many many extra types of network messages and many of them processed by external components such as llmq/signing or coinjoin/client. Current architecture creates multiple circular dependency.
What was done?
That's part II of refactorings.
This PR removes PeerManager from several constructor and let LLMQContext to forget about PeerManager.
Prior work in this PR: https://github.com/dashpay/dash/pull/5782
What else to do?
Some network messages are processed asynchronously in external components such as llmq/signing, llmq/instantsend, llmq/dkgsessionhandler. It doesn't let to refactor them easily, because they can't just simple return status of processing; status of processing would be available sometime later and there's need callback or other way to pass result code without spreading PeerManager over codebase.
How Has This Been Tested?

Run unit/functional tests
run a linter test/lint/lint-circular-dependencies.sh

Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

Thoughts @UdjinM6 ?


vue-tsc --noEmit type erros, when running type checking before vite build

Describe the bug
When having the new Version 0.9.0 installed and implemented as described in the changelog, there will be typescript errors when running vue-tsc --noEmit before running vite build. They are all related to typings in @histoire/app/src.
Reproduction
I created a stackblitz, where a build is running and failing because of this problems (https://stackblitz.com/edit/histoire-vue3-types-xi9pkt).
System Info
This is from the stackblitz console, but we had the same issue when running on node 14.18.0

  System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.10 - /bin/yarn
    npm: 7.17.0 - /bin/npm
  npmPackages:
    @histoire/plugin-vue: ^0.9.0 => 0.9.0
    @vitejs/plugin-vue: ^3.0.1 => 3.0.1
    histoire:  ^0.9.0 => 0.9.0
    vite: ^3.0.4 => 3.0.4

### Used Package Manager

npm

### Validations

- [X] Follow our [Code of Conduct](https://github.com/histoire-dev/histoire/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/histoire-dev/histoire/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://histoire.dev/guide/).
- [X] Check that there isn't [already an issue](https://github.com/histoire-dev/histoire/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/histoire-dev/histoire/discussions).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.

The issue seems to be that types property in @histoire/app/package.json is pointing to a .ts file instead of .d.ts file.


Update api-server-authorized-ip-ranges.md

I ran into an issue where I only got an error message with timeout during aks create (both az cli and tf) which was caused by leaving the NVA ip out from the list of authorized IPs therefore adding this to the documentations regarding limitations.

@attilabakos : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

I believe we already cover this generally in the article and this specific callout isn't necessary. Due to the prolonged orphaned state of this PR, I'm going to proceed with closing it. #please-close


Facing issue with cdpjconv

When I try to run the demo, there is a compile error: user-defined type not defined.
Then highlighted private function Jason_parseobject (json_string as string, byref json_index as long) as scripting.dictionary
May I know how to solve it. Thanks alot

Hi, simply enable Microsoft Scripting Runtime in the VBA References.

Thanks !!!


How to archive tray selection information?

This is a follow up to #4964
Cups support tray selection. Nice.
But how to archive tray selection data with printed data?
Our customer wants to archive the printed documents and the tray selection.

The job ticket information is part of the job history but is not embedded (by CUPS at least) in the spooled documents. If you want a permanent archival of whole print jobs you are probably better off using a third party solution with CUPS so that you don't have performance issues down the road.

Do you know which third party solutions provide an archive which stores the tray selection information?

Most of them are infinitely configurable/scriptable for this; I think Pykota will do it, but best to search for a solution with your favorite search engine...


Use native golang dcos-backup CLI extension

This changeset moves away from the python dcos-backup CLI to a golang-based dcos-backup CLI.
Relevant PR: https://github.com/mesosphere/dcos-enterprise-cli/pull/6
The resource.json file was written using the S3 artifacts found in the build log in jenkins

@collinvandyck : I've opened https://github.com/mesosphere/dcos-enterprise-cli/pull/10
Do you want to have this change backported to DC/OS 1.10 specifically? Otherwise we can wait before releasing a universe package and set minDcosReleaseVersion to 1.11, there is also the licensing subcommand in the pipeline for 1.11.


Manage Release name / selector labels / add label part-of / component

Hi,
I used the stakater application charts for some deployement.
I had see a limitation in some case. When I wanted to deploy the same application multiple time in the name namespace, because the charts didn't use the Helm Release.Name.
So I updated the _helper.tpl to generate an application fullname which use the Helm Release.Name and the applicationName.
So the name of the deployed objects are {{ Release.Name }}-{{ applicationName }}
It's now possible to deploy multiple instance of the same value file in the same namespace.
To to that
I refactor labels and selectorLabels with

app.kubernetes.io/instance:
app.kubernetes.io/component:
app.kubernetes.io/part-of:

Updated templates and value.yaml remove all trailing spaces.

I haven't had the time to look over all the changes yet, but I'll leave a few thoughts here:

Please avoid committing whitespace changes alongside meaningful ones. It messes with blame information and makes it more difficult to pinpoint what the origin of each line is, later down the line. I suggest removing the trailing whitespace changes from your PR, or moving them to a separate commit.
Since these changes will result in resources with different names, as well as references to Secret's with different names, we might need to do a major release bump if we accept it, as current users might find a new release of the chart to cause some downtime.
Some of these changes are unnecessary and only produce noise (e.g. the main container's name in the Deployment template). Please review whether using the fully qualified name is necessary to make the distinction between two releases in the same namespace so that the minimum amount of changes is made.


Display Dataset Size for Improved Usability

This PR enhances the usability of the dataset feature by introducing size information across the dashboard and dataset explorer.
Main Changes:

Dashboard Update:

The dashboard entry now displays the size of the latest version of each dataset.

Dataset Explorer Enhancements:

Each dataset version is now visible within the explorer.
When a file is selected from the tree, its size will be displayed on the right-hand side.

API Fix for Dataset Size Calculation:

The previous logic included hidden directories (e.g., .git) and system-generated files (e.g., .DS_Store on macOS) in the size calculation.
This PR refines the size calculation to only sum the sizes of version-controlled files, ensuring accurate and relevant measurements.

I have addressed the comments. Please take a look!


Microsoft.Bot.Schema.BotTimeoutException

Bot Info
Active Channels: Direct Line
Deployment Environment: Azure Bot Service
Issue Description
Event time | 	10/15/2019, 2:24:34 PM (Local time)	 |
-- | -- | --
Message | POST to XXXXXX-XXX-XXX-XXX-V4 timed out after 15s	 |
Exception type | Microsoft.Bot.Schema.BotTimeoutException |
Failed method | Microsoft.Bot.ChannelConnector.BotAPI+d__31.MoveNext |
Problem Id | Microsoft.Bot.Schema.BotTimeoutException at Microsoft.Bot.ChannelConnector.BotAPI+d__31.MoveNext |
Assembly | Microsoft.Bot.Base.ChannelConnector, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null_ |
Telemetry type | exception |
Operation Id | 5167a7f93232764fb3af71690c833570 |
Parent Id | |5167a7f93232764fb3af71690c833570.96621b92_ |
Application version | Tue 10/08/2019 0:54:54.64 UTC (fv-az458) [Build 82024] [Repo Intercom] [Branch prod] [Commit e8d652926cfe0bdc1b5f0916284470ab95e34b4a] [IntercomWebUIVersion 1.6.19] [IntercomBotAppTemplatesVersi…[show more] |
Device type | PC |
City | Pune |
State or province | Maharashtra |
Country or region | India |
Cloud role name | bc-directline-pn |
Cloud role instance | RD0003FFBD5B8C |
SDK version	dotnet | 2.9.1-26108 |
Sample rate | 1 |
Call Stack
Microsoft.Bot.Schema.BotTimeoutException:    at Microsoft.Bot.ChannelConnector.BotAPI+<PostActivityToBotAsync>d__31.MoveNext (Microsoft.Bot.Base.ChannelConnector, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null)
We are getting this exception after 2 weeks from deployment

And I found this Exception Details in a Log that we maintain in DB
Exception Details: StackTrace
Message: Reading the request body timed out due to data arriving too slowly. See MinRequestBodyDataRate.
MethodName: BotController
Stack Trace:
at   Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException.Throw(RequestRejectionReason   reason)     at   Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1MessageBody.PumpAsync()     at   System.IO.Pipelines.PipeCompletion.ThrowLatchedException()     at   System.IO.Pipelines.Pipe.GetReadResult(ReadResult& result)     at   System.IO.Pipelines.Pipe.GetReadAsyncResult()     at   System.IO.Pipelines.Pipe.DefaultPipeReader.GetResult(Int16 token)     at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.MessageBody.ReadAsync(Memory1   buffer, CancellationToken cancellationToken)     at   Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.ReadAsyncInternal(Memory1   buffer, CancellationToken cancellationToken)     at   Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpRequestStream.Read(Byte[]   buffer, Int32 offset, Int32 count)       at System.IO.StreamReader.ReadBuffer(Span1 userBuffer, Boolean&   readToUserBuffer)     at   System.IO.StreamReader.ReadSpan(Span1 buffer)     at System.IO.StreamReader.Read(Char[]   buffer, Int32 index, Int32 count)       at Newtonsoft.Json.JsonTextReader.ReadData(Boolean append, Int32   charsRequired)     at Newtonsoft.Json.JsonTextReader.ParseValue()     at   Newtonsoft.Json.JsonTextReader.Read()       at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract,   Boolean hasConverter)     at   Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader   reader, Type objectType, Boolean checkAdditionalContent)     at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader   reader, Type objectType)     at   Newtonsoft.Json.JsonSerializer.Deserialize[T](JsonReader reader)     at Microsoft.Bot.Builder.Integration.AspNet.Core.HttpHelper.ReadRequest(HttpRequest   request)     at   Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter.ProcessAsync(HttpRequest   httpRequest, HttpResponse httpResponse, IBot bot, CancellationToken   cancellationToken)     at   BotProject.Controllers.BotController.PostAsync() in   C:\BotFrameworkV4\BotProject\BotProject\Controllers\BotController.cs:line 36
Does it have to do anything with the service plan that we are running?
Currently, it's in Basic Plan as we are still testing.
Custom Data
Conversation ID | 	L0K8uhPjGRZG6wwd0CLNUM-c	 |
-- | -- | --
Correlation ID | |5167a7f93232764fb3af71690c833570.96621b92_		 |
Activity type | message	 |
Recipient ID | XXXXXX-XXX-XXX-XXX-V4@OYkNvbTPG-E |
Bot endpoint | https://XXXXXX-XXX-XXX-XX-V4.azurewebsites.net/api/messages	 |
Activity ID | L0K8uhPjGRZG6wwd0CLNUM-c|0000020 |
Status code | GatewayTimeout |
EventName | Exception |
Channel ID | directline |
From ID |<EMAIL_ADDRESS>|
Bot ID | XXXXXX-XXX-XXX-XXX-V4	 |

This should not be related to the service plan you are using. I am looking into it.

I didn't find anything additional in the service logs. It appears that it is entirely timing out on the bot side (your code)/.NetCore/kestrel. I'm still not sure about MinRequestBodyDataRate, but still investigating.
Just a few things that may not be related, but that I want to check:

Do you have any areas of the code that could be taking a long time (make calls to external services, etc)?
Is the issue still happening, or did it happen outside of the window shown in that image?
Is the App Service set to be always on? I don't think you would see that many exceptions for that period of time, if it was that, but again, I just wanted to check.
Are you using any middleware or LUIS/QnA?

Can you check to see how many requests you have taking over 14 seconds in the last 7 days? You can run the following query in the application insights Logs (analytics)
let start_time = ago(7d);
let end_time = now();
requests
| where duration > 14000
| where timestamp > start_time and timestamp < end_time
| limit 100

I'd also be curious to know how many are taking over 10 seconds (| where duration > 10000)

Got it Resolved, the issue was due to log running code, and greedy Regex implementation.
Thank you for your support.


Add support for eth_getTransactionCount to prover

Motivation
Add support for web3 method eth_getTransactionCount
Description
Add support for web3 method eth_getTransactionCount
Partially: #4706
Steps to test or reproduce
Run all tests.

:tada: This PR is included in v1.8.0 :tada:


[BUG] Not Showing Properly on buttons

Description
When we hover over the buttons on the entire page it changes the color to gray which is not visible clearly. So i want to edit this.
@mdazfar2 Pls assign me under label gssoc-ext, hacktoberfest-accepted
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@rupeshv2121 assigned
Hope you star our Repo.
Join our Discord Server to collaborate and discuss further

pls add level @Kavita1928

Hey @rupeshv2121
except your issue changes you made other changes in different pages FIX IT by today or I have to close this PR
make sure you star our Repo.

i uploaded a demo video for this pls check


I add tiny mode and backgroudimage for the JSBadgeView

thanks your project!,we use it in our project,we add tiny mode and backgroudimage for the JSBadgeView, also make some propriety can modify by user. Could you consider add it to your master branch?

how to use the 'tinymode', could U give some illustration or example?

how to use the 'tinymode', could U give some illustration or example?

Hi! Thanks for the PR.
There are some unrelated changes in this PR. Would you mind submitting a different one for each of the features that you'd like to add / change?
Also, please take a look at the current code style to keep your code consistent with it.
And to better understand the changes, could you attach screenshots of the before and after? Thank you!

Hi! Thanks for the PR.
There are some unrelated changes in this PR. Would you mind submitting a different one for each of the features that you'd like to add / change?
Also, please take a look at the current code style to keep your code consistent with it.
And to better understand the changes, could you attach screenshots of the before and after? Thank you!


use the declared normalModuleFactory variable

If I am wrong, please let me know.
What kind of change does this PR introduce?
slightly adjust how to resolve normalModuleFactory variable.
Did you add tests for your changes?
Sorry, no
If relevant, link to documentation update:
No
Summary
reduce the code size 😉
Does this PR introduce a breaking change?
No
Thanks

Thanks

Appreciate to be merged 😀


Feature Request - IOU - Holding down the delete button should continually delete the amount - Reported by: @kakajann

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to a conversation
Start the Request money flow
Type some amount with several digits
Press and hold the delete button

Expected Result:
Holding down the delete button should continually delete the amount
Actual Result:
Holding down the delete button doesn't continually delete the digits. User has to press each time to delete a single number.
Workaround:
None needed, button is deleting the amount.
Platform:

Where is this issue occurring?

iOS
Android
Mobile Web

Version Number: 1.1.17-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/44479856/144119249-780122ea-4089-45ff-955e-629b5a32b858.mp4
Expensify/Expensify Issue URL:
Issue reported by: @kakajann
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638274892063400
View all open jobs on GitHub

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

If you decide to make this one external I would like submit a proposal:
To implement the expected behaviour described in the first post on this issue, we can utilize the props onLongPress and onPressOut of the react native Pressable component.
onLongPress we would start the interval timer that would delete symbols one by one and onPressOut we would call clearInterval on it.
Here is a sample code:

First we'll need to pass the props for new event handlers from IOUAmountPage through BigNumberPad to Button component.

diff --git a/src/components/BigNumberPad.js b/src/components/BigNumberPad.js
index 26299c661..272155c28 100644
--- a/src/components/BigNumberPad.js
+++ b/src/components/BigNumberPad.js
@@ -8,6 +8,17 @@ import Button from './Button';
 const propTypes = {
     /** Callback to inform parent modal with key pressed */
     numberPressed: PropTypes.func.isRequired,
+
+    /** TODO */
+    numberLongPressed: PropTypes.func,
+
+    /** TODO */
+    numberPressOut: PropTypes.func,
+};
+
+const defaultProps = {
+    numberLongPressed: () => {},
+    numberPressOut: () => {},
 };

 const padNumbers = [
@@ -30,7 +41,9 @@ const BigNumberPad = props => (
                             key={column}
                             style={[styles.flex1, marginLeft]}
                             text={column}
+                            onLongPress={() => props.numberLongPressed(column)}
                             onPress={() => props.numberPressed(column)}
+                            onPressOut={props.numberPressOut}
                         />
                     );
                 })}
@@ -41,5 +54,6 @@ const BigNumberPad = props => (

 BigNumberPad.propTypes = propTypes;
 BigNumberPad.displayName = 'BigNumberPad';
+BigNumberPad.defaultProps = defaultProps;

 export default BigNumberPad;
 diff --git a/src/components/Button.js b/src/components/Button.js
index 8e346c963..da0b8cca3 100644
--- a/src/components/Button.js
+++ b/src/components/Button.js
@@ -32,6 +32,12 @@ const propTypes = {
     /** A function that is called when the button is clicked on */
     onPress: PropTypes.func,

+    /** TODO */
+    onLongPress: PropTypes.func,
+
+    /** TODO */
+    onPressOut: PropTypes.func,
+
     /** Call the onPress function when Enter key is pressed */
     pressOnEnter: PropTypes.bool,

@@ -68,6 +74,8 @@ const defaultProps = {
     small: false,
     large: false,
     onPress: () => {},
+    onLongPress: () => {},
+    onPressOut: () => {},
     pressOnEnter: false,
     style: [],
     textStyles: [],
@@ -158,6 +166,8 @@ class Button extends Component {
         return (
             <Pressable
                 onPress={this.props.onPress}
+                onLongPress={this.props.onLongPress}
+                onPressOut={this.props.onPressOut}
                 disabled={this.props.isLoading || this.props.isDisabled}
                 style={[
                     this.props.isDisabled ? styles.cursorDisabled : {},
diff --git a/src/pages/iou/steps/IOUAmountPage.js b/src/pages/iou/steps/IOUAmountPage.js
index 5f5c2a0ff..4e4b8678e 100755
--- a/src/pages/iou/steps/IOUAmountPage.js
+++ b/src/pages/iou/steps/IOUAmountPage.js
@@ -74,6 +74,8 @@ class IOUAmountPage extends React.Component {
         super(props);

         this.updateAmountNumberPad = this.updateAmountNumberPad.bind(this);
+        this.handleLongPressNumberPad = this.handleLongPressNumberPad.bind(this);
+        this.clearDeletionTimer = this.clearDeletionTimer.bind(this);
         this.updateAmount = this.updateAmount.bind(this);
         this.stripCommaFromAmount = this.stripCommaFromAmount.bind(this);
         this.focusTextInput = this.focusTextInput.bind(this);
@@ -211,6 +213,8 @@ class IOUAmountPage extends React.Component {
                         ? (
                             <BigNumberPad
                                 numberPressed={this.updateAmountNumberPad}
+                                numberLongPressed={this.handleLongPressNumberPad}
+                                numberPressOut={this.clearDeletionTimer}
                             />
                         ) : <View />}

Then an actual implementation for the feature would look like this:

    /**
     * TODO
     *
     * @param {String} key
     */
    handleLongPressNumberPad(key) {
        // Backspace button is pressed
        if (key !== '<') {
            return;
        }

        const timer = setInterval(() => {
            this.setState(prevState => ({
                amount: prevState.amount.slice(0, -1),
            }));
        }, 100);

        this.setState({timer});
    }

    /**
     * TODO
     */
    clearDeletionTimer() {
        clearInterval(this.state.timer);
    }

Note that I am only checking for the < key and ignoring the actual keyboard Backspace since on the desktop the default sticky keys behaviour is already doing what we are looking for.
Here is a sample video:
https://user-images.githubusercontent.com/64093836/144203786-ac671eee-96ef-4562-b060-4c56abd88fae.mp4

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

posted in our internal slack about how we'd prefer to do this: only allow holding backspace/delete or allow all buttons to repeat if you hold them down.
I'm thinking only delete probably makes most sense but wanted to get a gut check there first.

my thread didn't gain much traction but at least @marcochavezf chimed in and agreed only the backspace/delete button should be able to repeat via holding it down.
I think this is fine for a contributor to work on, I'm not super familiar with this code base but I would guess we already have some key event listeners which are blocking the repeat event, unless it's a react native thing (?), because at least on web the default behavior is that keydown events repeat.
said differently: I'm not privy enough with this code base to know if @dklymenk suggestion is the right way or not so another engineer who's more familiar should review instead of  me.

Upwork posting

Triggered auto assignment to @parasharrajat (Exported)

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

To me it sounds like @dklymenk's proposal would just do the trick. Actually, I didn't find any native way when keypress is fired continuously. Not sure if this is something possible natively.
And there is only one proposal which is promising.
Now I leave the decision up to @iwiznia .

Not sure I get the proposal. So the onLogPress will be mapped to handleLongPressNumberPad? If so, how/when will we detect the long press is over? That's when we need to call clearDeletionTimer, right?

@iwiznia

So the onLogPress will be mapped to handleLongPressNumberPad?

Yes

If so, how/when will we detect the long press is over? That's when we need to call clearDeletionTimer, right?

We pass the clearDeletionTimer to onPressOut. As far as I am aware that is the only way to detect when the long press is ended in react native.
Sorry if the prop names I used are confusing. I tried to keep the names in line with other props in their components. If you find some of them confusing or wrong we can rename them no problem.

Oh ok, that sounds good. @bfitzexpensify can you hire @dklymenk?
One clarification, are the onLogPress and onPressOut fired in web?

📣 @dklymenk You have been assigned to this job by @iwiznia!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

One clarification, are the onLogPress and onPressOut fired in web?

According to react native web documentation, yes. I also did a quick check in mWeb on my laptop via dev tools responsive mode, so I would expect it to work on real devices too.

According to react native web documentation, yes.

Should then we not set the timeout in web, given default behavior already works?

Should then we not set the timeout in web, given default behavior already works?

We are already doing that by only listening to the < press and ignoring the Backspace in the handleLongPressNumberPad function.

Note that I am only checking for the < key and ignoring the actual keyboard Backspace since on the desktop the default sticky keys behaviour is already doing what we are looking for.

Here is a quote from the original proposal

Yeah, saw that, but we would still set the timeout... I guess web is the platform we less care about those as I think those have a higher performance impact in mobile, but I think it would be possible to only target native platforms, right? Or is there a case for keeping it to support computers with touchscreens?

Yeah, saw that, but we would still set the timeout... I guess web is the platform we less care about those as I think those have a higher performance impact in mobile, but I think it would be possible to only target native platforms, right? Or is there a case for keeping it to support computers with touchscreens?

Sorry, I don't see how that would set the timeout. By listening only for < key we will only trigger the timeout if the button is long pressed on the rendered number pad. If you long press a physical backspace key on your keyboard, the timer will not start.
I don't think the changes I described above impact the computers with touch screens. We don't render the numpad on desktop, so they cannot press the <  on it to trigger the event.

Oh sorry, you are right.

This is moving along, right @dklymenk?

No, I haven't gotten hired on upwork.

@bfitzexpensify you must've missed my ping, can you hire @dklymenk please?

Sorry for the delay @dklymenk, hired you now.

Thank you. I got the offer. I will submit a PR shortly.

@iwiznia While reviewing the footage for mWeb (https://github.com/Expensify/App/pull/6626) I noticed that when doing a long press on the delete key a completely random UI element gets selected for no reason and an annoying context menu appears. This would definitely qualify as a bug if it were to be merged.
I will look into ways of resolving it tomorrow.
Thanks.

In order to fix the selection issue I reused the code you're already using on report screen for a similar problem. https://github.com/Expensify/App/pull/6626/commits/4489d4e77867651704ef11a83468af3e24dd1541
It seemed like a pretty safe bet to me that when tapping or clicking the button, the selection should be disabled.
The PR #6626 is ready for review.

Glad to hear that logic is helping out with these problems. I didn't consider that to be reusable while writing it. I will review the PR shortly.

In review

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.21-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/6626

If no regressions arise, payment will be issued on 2021-12-27. :confetti_ball:

7 days since deployment. @dklymenk, paid you and ended the contract — thank you!
@kakajann, can you respond to the offer here? Once you do, I'll accept and pay out the reporting bonus.

By looking at the thread above, i'm guessing this job https://www.upwork.com/jobs/Reporting-IOU-Holding-down-the-delete-button-should-continually-delete-the-amount-6547_~011d115cee449bdc46/ is temporary 🤔

@bfitzexpensify Thanks, accepted


test(a11y): introduce karma-accessibility-checker

Related Ticket(s)
Refs #2387.
Description
This change introduces automated a11y test (karma-accessibility-checker) integrated to our CI, starting with one for <CTA>.
Changelog
New

a11y compliance tests based on karma-accessibility-checker.

Finally ready for review - "Stories walk through" feature is implemented. Given the number of reports, the CI won't fail even with error reports for now.

Hey @asudoh , would you be able to fix merge conflicts?
I'm also wondering since this affects the way knobs are created, we would need to integrate this first before we begin to fix the other storybook stories in the epic https://github.com/carbon-design-system/ibm-dotcom-library/issues/2955.

Thanks @kennylam and @jeffchew for reviewing! Solved the merge conflict.


Update to Node 22 (active LTS) & NPM security/minor patches updates

See https://nodejs.org/en/blog/release/v22.11.0
Fixes #12531
Update minor patches & security fixes for NPM dependencies

punycode warning

This will introduce a warning about punycode being removed in the future, it's better we are on the Active LTS so that things like this are alerted to us.
These will be resolved by other updates to packages:

eslint (may take a bit until we get our repo updated) - https://github.com/wagtail/eslint-config-wagtail/issues/22
jest-environment-jsdom - https://github.com/jestjs/jest/issues/15367
storybook (we will need to do a bit to get this updated). I can dig into what it would take to update Storybook once this is merged, raising an issue on our repo.

Thank you Matt


Show QC traces and use global TIC/BPC chromatograms

Change TIC and BPC extractors to use global chromatograms from the source file (e.g. <chromatogram id="TIC">) instead of building TIC scan-by-scan
Add option to view QC traces in Transition menu
Add ShowQcTraceName setting which controls which trace is shown

Known issues:

qcMenuItem is not showing its DropDownItems submenu but qcContextMenuItem is. What's up with that?
ChromCacheMinimizerTest is failing but I don't understand why. Is the new way of getting TIC chromatograms somehow being filtered out by the minimizer? I couldn't tell the differences between the original and minimized versions when looking in the debugger.
I left this code intact in SpectrumFilter.cs:

if (EnabledMs)
{
    _isHighAccMsFilter = !Equals(_fullScan.PrecursorMassAnalyzer,
        FullScanMassAnalyzerType.qit);

    if (!firstPass && !_isFAIMS)
    {
        var key = new PrecursorTextId(SignedMz.ZERO, null, null, ChromExtractor.summed);  // TIC
        dictPrecursorMzToFilter.Add(key, new SpectrumFilterPair(key, PeptideDocNode.UNKNOWN_COLOR, dictPrecursorMzToFilter.Count,
            _instrument.MinTime, _instrument.MaxTime, _isHighAccMsFilter, _isHighAccProductFilter));
        key = new PrecursorTextId(SignedMz.ZERO, null, null, ChromExtractor.base_peak);   // BPC
        dictPrecursorMzToFilter.Add(key, new SpectrumFilterPair(key, PeptideDocNode.UNKNOWN_COLOR, dictPrecursorMzToFilter.Count,
            _instrument.MinTime, _instrument.MaxTime, _isHighAccMsFilter, _isHighAccProductFilter));
    }
}

Because when I comment it out, tests start failing. But as far as I can tell, the global chromatograms ARE getting used.

Leaving that code in kills any performance gains, so we'll need to sort
this out. What kind of failures are you seeing?
I'm not surprised if it's just that the TIC and BPC have changed somewhat -
my intuition was that this wouldn't agree with our own values. I notice,
for example, that the Bruker DIA PASEF files claim TIC 10 for scans with no
mz-intensity pairs, so we'd disagree on that for sure.
On Thu, May 23, 2019 at 12:47 PM Matt Chambers<EMAIL_ADDRESS>wrote:

Change TIC and BPC extractors to use global chromatograms from the
source file (e.g. ) instead of building TIC
scan-by-scan
Add option to view QC traces in Transition menu
Add ShowQcTraceName setting which controls which trace is shown

Known issues:

qcMenuItem is not showing its DropDownItems submenu but
qcContextMenuItem is. What's up with that?
ChromCacheMinimizerTest is failing but I don't understand why. Is
the new way of getting TIC chromatograms somehow being filtered out by the
minimizer? I couldn't tell the differences between the original and
minimized versions when looking in the debugger.
I left this code intact in SpectrumFilter.cs:

if (EnabledMs)
{
_isHighAccMsFilter = !Equals(_fullScan.PrecursorMassAnalyzer,
FullScanMassAnalyzerType.qit);
if (!firstPass && !_isFAIMS)
{
    var key = new PrecursorTextId(SignedMz.ZERO, null, null, ChromExtractor.summed);  // TIC
    dictPrecursorMzToFilter.Add(key, new SpectrumFilterPair(key, PeptideDocNode.UNKNOWN_COLOR, dictPrecursorMzToFilter.Count,
        _instrument.MinTime, _instrument.MaxTime, _isHighAccMsFilter, _isHighAccProductFilter));
    key = new PrecursorTextId(SignedMz.ZERO, null, null, ChromExtractor.base_peak);   // BPC
    dictPrecursorMzToFilter.Add(key, new SpectrumFilterPair(key, PeptideDocNode.UNKNOWN_COLOR, dictPrecursorMzToFilter.Count,
        _instrument.MinTime, _instrument.MaxTime, _isHighAccMsFilter, _isHighAccProductFilter));
}

}
Because when I comment it out, tests start failing. But as far as I can
tell, the global chromatograms ARE getting used.
You can view, comment on, or merge this pull request online at:
https://github.com/ProteoWizard/pwiz/pull/553
Commit Summary

Skyline: Expose TextId through ChromatogramGroupInfo

updated CVs: PSI-MS to 4.1.26, Unimod to 2018:10:25

Simplify enumeration of global chromatogram indexes

File Changes

M pwiz_tools/Shared/ProteowizardWrapper/MsDataFileImpl.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-0 (6)
M pwiz_tools/Skyline/Controls/Graphs/ChromGraphItem.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-1 (8)
M pwiz_tools/Skyline/Controls/Graphs/GraphChromatogram.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-2 (33)
M pwiz_tools/Skyline/Controls/Graphs/GraphSpectrum.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-3 (1)
M pwiz_tools/Skyline/Model/ExportChromatograms.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-4 (4)
M pwiz_tools/Skyline/Model/Results/ChromCacheBuilder.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-5 (2)
M pwiz_tools/Skyline/Model/Results/ChromDataProvider.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-6 (93)
M pwiz_tools/Skyline/Model/Results/ChromHeaderInfo.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-7 (48)
M pwiz_tools/Skyline/Model/Results/ChromatogramCache.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-8 (1)
M pwiz_tools/Skyline/Model/Results/MeasuredResults.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-9 (13)
M pwiz_tools/Skyline/Model/Results/SpectraChromDataProvider.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-10 (39)
M pwiz_tools/Skyline/Model/Results/SpectrumFilter.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-11 (19)
M pwiz_tools/Skyline/Properties/Resources.Designer.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-12 (143)
M pwiz_tools/Skyline/Properties/Resources.resx
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-13 (3)
M pwiz_tools/Skyline/Properties/Settings.Designer.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-14 (14)
M pwiz_tools/Skyline/Properties/Settings.settings
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-15 (3)
M pwiz_tools/Skyline/Skyline.Designer.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-16 (16)
M pwiz_tools/Skyline/Skyline.resx
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-17 (26)
M pwiz_tools/Skyline/SkylineGraphs.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-18 (40)
M pwiz_tools/Skyline/TestData/PwizFileInfoTest.cs
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-19 (40)
M pwiz_tools/Skyline/app.config
https://github.com/ProteoWizard/pwiz/pull/553/files#diff-20 (3)

Patch Links:

https://github.com/ProteoWizard/pwiz/pull/553.patch
https://github.com/ProteoWizard/pwiz/pull/553.diff

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/553?email_source=notifications&email_token=AAJFE6MIQLWYEWQCE6G7W5TPW3YGPA5CNFSM4HPJXOJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVRREBA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJFE6PYLKWYGGAJSZB745DPW3YGPANCNFSM4HPJXOJQ
.

Leaving that code in kills any performance gains, so we'll need to sort this out. What kind of failures are you seeing? I'm not surprised if it's just that the TIC and BPC have changed somewhat - my intuition was that this wouldn't agree with our own values. I notice, for example, that the Bruker DIA PASEF files claim TIC 10 for scans with no mz-intensity pairs, so we'd disagree on that for sure.

In AgilentMseChromatogramTestAsNegativeSmallMolecules:
'pwiz.Skyline.Model.Results.NoFullScanDataException' in Skyline-daily.exe
Additional information: No scans in AgilentMse\BSA-AI-0-10-25-41_first_100_scans.mzML match the current filter settings.
It seems something I did fixed a lot of the other failures I saw earlier when commenting out that code. Now it's just this AgilentMse failure, the ChromCacheMinimizer failure, and a failure in TestRetentionTimeFilter because none of the old mzML/mz5 files and not all the vendor readers have base peak chromatograms in them. I think Brendan said he wants to allow the user to opt-in to the scan-by-scan BPC building to use when it's not available direct from the file. We would need that capability to make this test work without updating the mzML/mz5 files in RetentionTimeTest.zip (actually I need to add BPC support for Thermo too but that's quite simple).

Could we not selectively disable that based on whether the BPC is
available? Then we don't have to bug the user at all.
On Thu, May 23, 2019 at 2:22 PM Matt Chambers<EMAIL_ADDRESS>wrote:

Leaving that code in kills any performance gains, so we'll need to sort
this out. What kind of failures are you seeing? I'm not surprised if it's
just that the TIC and BPC have changed somewhat - my intuition was that
this wouldn't agree with our own values. I notice, for example, that the
Bruker DIA PASEF files claim TIC 10 for scans with no mz-intensity pairs,
so we'd disagree on that for sure.
In AgilentMseChromatogramTestAsNegativeSmallMolecules:
'pwiz.Skyline.Model.Results.NoFullScanDataException' in Skyline-daily.exe
Additional information: No scans in
AgilentMse\BSA-AI-0-10-25-41_first_100_scans.mzML match the current filter
settings.
It seems something I did fixed a lot of the other failures I saw earlier
when commenting out that code. Now it's just this AgilentMse failure, the
ChromCacheMinimizer failure, and a failure in TestRetentionTimeFilter
because none of the old mzML/mz5 files and not all the vendor readers have
base peak chromatograms in them. I think Brendan said he wants to allow the
user to opt-in to the scan-by-scan BPC building to use when it's not
available direct from the file. We would need that capability to make this
test work without updating the mzML/mz5 files in RetentionTimeTest.zip
(actually I need to add BPC support for Thermo too but that's quite simple).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/553?email_source=notifications&email_token=AAJFE6NIIFYGPIWF3BSULQ3PW4DKFA5CNFSM4HPJXOJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDQ3AI#issuecomment-495390081,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJFE6OQNQSU2TJERGJ2GRLPW4DKFANCNFSM4HPJXOJQ
.

My intent was to disable this completely and just have the UI show that BPC is unavailable when we cannot get it directly from the MSDataFile API and then wait to see if anyone complains, and if so, who and why, and only if we get important complaints consider adding a way to get back to the old way of doing things, but for now just go with the more limited, but higher performance method, rather than kill ourselves maintaining parity with the original implementation when we don't really know who cares, other than it was once requested by Michael Bereman when he was working on SProCoP as a post-doc in the MacCoss lab.

OK, I fixed RetentionTimeTest by switching from BPC to TIC. Any tips about the ChromCacheMinimizer failure? What is that class doing with all ions chromatograms?

ChromCacheMinimizer has an option to discard unused chromatograms. It may be testing that this does not discard TIC or BPC, since those are special cases, which your QC chromatograms now join, but if for some reason the test no longer includes, say, BPC, then it would fail testing that the minimizer did not discard BPC. Just a guess. One of us will have to have a closer look. Since you should think about modifiying this test to ensure QC chromatograms are not discarded by the minimizer, I vote for you to be the one to look more closely.

When I add code to keep chromatograms if PrecursorMz==0, the first MinimizedRatio ChromCacheMinimizer test passes, but the next one fails:
Assert.AreEqual(1.0, statsMissingFirstProtein.MinimizedRatio + statsWithOnlyFirstProtein.MinimizedRatio,                                 .00001);
The logic here is to include or exclude the first protein and expect the minimized files to add up to the original file size. That only makes sense if the global chromatograms are not counted in either file total (i.e. they're excluded both from the original size and the minimized size). But in that case I don't see why the first MinimizedRatio failed (before I forced the minimizer to keep the global chromatograms). @nickshulman what am I missing?

If we find that folks do care about clickable TIC in Skyline it should be
generally possible and inexpensive to pull each scan's TIC and BPC from
relatively inexpensive header metadata.
On Thu, May 23, 2019 at 4:29 PM Brendan MacLean<EMAIL_ADDRESS>wrote:

My intent was to disable this completely and just have the UI show that
BPC is unavailable when we cannot get it directly from the MSDataFile API
and then wait to see if anyone complains, and if so, who and why, and only
if we get important complaints consider adding a way to get back to the old
way of doing things, but for now just go with the more limited, but higher
performance method, rather than kill ourselves maintaining parity with the
original implementation when we don't really know who cares, other than it
was once requested by Michael Bereman when he was working on SProCoP as a
post-doc in the MacCoss lab.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/553?email_source=notifications&email_token=AAJFE6OTSWWONVVT5VWXLMLPW4SHDA5CNFSM4HPJXOJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDYHBI#issuecomment-495420293,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJFE6I4LMZAJ65XF5RDQBLPW4SHDANCNFSM4HPJXOJQ
.

... which I thought I'd commented on here, but that seems to have not stuck. I'll just fix them myself (mostly about one-liners, we generally put the if and the clause on seperate lines for ease of breakpoint setting).


Create documentation on working around prefix issues

Our dev process is based on the premise that the project's code will work the same in developer orgs and in the packaging org. We should document the places where the namespace is and isn't automatically resolved, and describe the workarounds for the latter.

Cleaning up old issues...
Closing as this is outside the scope of CumulusCI


App cannot be build on last api level for Stax

@NicolasFlamel1 could you please to help to solve tests issues for this PR
I have to fix the app because it doesn't build anymore on last api level.
ty for your help

Hey @tdejoigny-ledger. This PR fixes the functional tests hanging on the Stax.

ty @NicolasFlamel1


improved inference api

Reference Issues/PRs

Fixes #354
Fixes #356
Also see #361
Transfers the parameter "embedding" from the base class of inference
Removes .bootstrap() as the abstract method from the base class, since latent distribution test does not implement it, after the hyppo backend introduction.
upd: latent position test now uses exact MC p-values

What does this implement/fix? Explain your changes.

The attribute representing p-value is now always called .p_value_.
.fit() now returns self. added fit_predict() method that fits the model and returns p-value (what .fit() used to be doing previously). Modified the tests and tutorial where necessary accordingly.
removed .bootstrap() as an abstract method from the base class, since the nonparametric test does not use it.
transferred the embedding parameter from the base class to the latent position test, since it makes very little sense to choose between ase and omni for the nonparametric test.
(happy to revert the latter two changes if anyone vetos them)
upd: latent position test now de facto includes the original sample itself when computing the p-value. this leads to a valid test does not have issues with 0 p-values, nor with p-values > 1. continuity correction removed.

Any other comments?
note that this does not address #222 , nor makes any amends to tutorials other than the ones necessary for them to work with fit no longer returning p-value.

I also initially wanted to modify this
https://github.com/neurodata/graspy/blob/2e0c8325aaff24a7bb3a1d22f26a46cca1038a70/graspy/inference/latent_position_test.py#L211-L219
in order to always use
(len(null_distribution_1[null_distribution_1 >= sample_T_statistic]) + 1) / (self.n_bootstraps + 1)

rather than using
(len(null_distribution_1[null_distribution_1 >= sample_T_statistic]) + 0.5) / (self.n_bootstraps )

if there are permutation with more extreme statistic and
(len(null_distribution_1[null_distribution_1 >= sample_T_statistic]) + 1) / (self.n_bootstraps )

when there are no such permutations. basically, make it in accordance with recommendations of, say https://pubmed.ncbi.nlm.nih.gov/21044043/ (and, maybe more notably, cep). but i do not exactly understand the "continuity correction" thing.

I also initially wanted to modify this
https://github.com/neurodata/graspy/blob/2e0c8325aaff24a7bb3a1d22f26a46cca1038a70/graspy/inference/latent_position_test.py#L211-L222
in order to always use
(len(null_distribution_1[null_distribution_1 >= sample_T_statistic]) + 1) / (self.n_bootstraps + 1)

rather than (implicitly) using
(len(null_distribution_1[null_distribution_1 >= sample_T_statistic]) + 0.5) / (self.n_bootstraps )

if there are permutation with more extreme statistic and
(len(null_distribution_1[null_distribution_1 >= sample_T_statistic]) + 1) / (self.n_bootstraps )

when there are no such permutations. basically, make it in accordance with recommendations of, say https://pubmed.ncbi.nlm.nih.gov/21044043/ (and, maybe more notably, cep). but i do not exactly understand the "continuity correction" thing.

I am fine with using the CEP version you suggest, makes sense to me.

i think i am failing codecov because i have decreased the overall number of lines covered when changing the p-value thing? not sure.
in any case, i am done. you can merge if you are happy with it.

@bdpedigo , @j1c any updates?


XPipe does not parse extra SSH config options like RemoteCommand

I am trying to have XPipe execute a command after it establishes connection or have it forward the agent, but it seems like the options from the SSH config just get ignored.
SSH config
Host test
  HostName <IP_ADDRESS>
  User root
  Port 22
  RemoteCommand tmux a || tmux
  ForwardAgent yes
  ForwardX11 yes
  RequestTTY yes
  TCPKeepAlive yes

Expected Behavior
Executing the ssh command manually executes the command and launches a tmux session in the remote host if one does not exist already.

Actual Behavior
XPipe ignores the extra options and no command is executed. The issues occurs on both the latest release and public test builds.

Command that XPipe will execute from Insights:
ssh "Invalid" -oStrictHostKeyChecking=accept-new -oRemoteCommand=none -oNoHostAuthenticationForLocalhost=yes -t -F "<temp config>"

That is actually intentional. The RemoteCommand attribute is incompatible with any other commands passed inline, e.g. ssh user@host bash will not work when RemoteCommand is specified. That is why it executes -oRemoteCommand=none.
If you want to run a certain init command, you can use shell environments and/or scripts.

Ah interesting, I did not know that. Is it the same for the other options like ForwardAgent?

It should not touch any other options besides RemoteCommand

Perfect, thank you! :)

So I guess if everything else except the remote command works as expected, this can be closed.


improve test assertions

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

#29


Adding pets doesn't work in WSL remote vscode

Describe the bug
When I click on the plus to add pets or go to the command palette to add pets, the pet list briefly pops up for a fraction of a second before disappearing. Happens 100% of the time.
Additional context
I'm currently working in WSL - Ubuntu 22.04
The extension works fine in my regular vscode but when I launch remote into WSL, the add pets stops working.

I have same issue, but not with WSL. Just regular SSH into a remote host (Amazon Linux 2)
Downgrading to 1.22 seems to fix this issue.
You can downgrade to 1.22 with this:

It works, thanks!

Please go to View -> Output and switch to "Extension Host".
Try it again and see if there is some error being reported. If so, paste it in here

No errors
only info in output is 2023-08-09 23:22:19.320 [info] ExtensionService#_doActivateExtension tonybaloney.vscode-pets, startup: false, activationEvent: 'onStartupFinished'

Yeah, I'm having the same issue D;

I have same issue, but not with WSL. Just regular SSH into a remote host (Amazon Linux 2)
Downgrading to 1.22 seems to fix this issue. You can downgrade to 1.22 with this:

This fixed it for me as well :)

I have same issue, but not with WSL. Just regular SSH into a remote host (Amazon Linux 2)
Downgrading to 1.22 seems to fix this issue. You can downgrade to 1.22 with this:

This fixed it for me :)
I wonder what causes this

I would love to know what causes this! I've tried running the extension in debug mode under WSL2 and then the bug doesn't occur 🤔 there aren't any errors or logs to help me

Ya same is happening to me too. On v1.25.0. Tried uninstalling and re-installing (didn't work). The menu flashing you described only happens for me on WSL as well.

I compared the code of the two versions 1.22 and 1.25, as far as I could tell the only changes regarding spawning a pet was  localization support. This might be the culprit, I didn't have time to investigate further, I will update when I do.

Please update the extension to the latest version (1.25.1) shortly when it is available in the marketplace


Go CLI detector should take into account replace go.mod overrides

When running go list -m, the Go CLI detector does not currently take into account any replace values specified within the corresponding go.mod file.
Example:
go.mod
replace (
    github.com/miekg/dns => github.com/miekg/dns v1.1.42
)

If a version <1.1.42 is requested as a dependency in go.sum, the override is not taken into consideration and the version returned by Component Detection will be whatever is requested from go.sum

Resolved with #1052 and #1045.


Loader: avoid wasteful strpbrk, array_key_exists

array_key_exists() could return true when the value is set to null, the same result is considered to be a failure in the default: case. This may prevent a value in $_SERVER from being used.
strpbrk() is a rarely used function that behaves like strstr() and returns a substring on success. Given that we are only checking a single character for specific values, isset() (a language construct that does not incur standard function overhead) is more suitable for performance and legibility.

Please send just the beginsWithAQuote change.

Closing this issue. @GrahamCampbell has confirmed that null values within $_ENV and $_SERVER are valid return values from getEnvironmentVariable()


curation image update

@freiburgermsu please delete the biomodels_qc.egg-info directory from the repo and add it to .gitignore.


Fix dataTables.bootstrap4.js comments to reference Bootstrap 4 (currently 3)

/*! DataTables Bootstrap 3 integration
 * ©2011-2015 SpryMedia Ltd - datatables.net/license
 */

/**
 * DataTables integration for Bootstrap 3. This requires Bootstrap 3 and
 * DataTables 1.10 or newer.
 *
 * This file sets the defaults and adds options to DataTables to style its
 * controls using Bootstrap. See http://datatables.net/manual/styling/bootstrap
 * for further information.
 */

Thanks for noting this. See #1015 which discusses this.


Fixed typos in loadpair instructions

@Cooper-Qu Hi, can you take a look and merge this?

LGTM. Thanks.


Theme no longer light right on startup?

When running out of sources I no longer see the light theme applied right on startup, only coming in later. No matter what I do it looks like this:

I can however not reproduce when running out of sources with a different user data dir.
@aeschli can you give me an idea if something changed and where I should look at for debugging?

This is weird:

This is on me.


Can EzXHelper or Xposed be used to call the superclass version of a hooked method?

I have a scenario in which I want to hook a method in a class that is extended from another class. Under certain conditions, I want to override the hooked method in the extended class and have it instead execute the original method. Basically I want to do the Xposed/EzXHelper equivalent of calling super.myHookedMethod(). Is there a way to do this?
I tried using XposedHelpers.callMethod(XposedHelpers.getSurroundingThis(param.thisObject), "myHookedMethod") and XposedHelpers.callMethod(param.thisObject, "super.myHookedMethod") but neither has worked. Is there any way to achieve this?

XposedBridge#invokeOriginalMethod (Member method, Object thisObject, Object[] args)

Doesn't this just call the method of the existing class?
https://api.xposed.info/reference/de/robv/android/xposed/XposedBridge.html#invokeOriginalMethod(java.lang.reflect.Member, java.lang.Object, java.lang.Object[])

Are you looking for java.lang.invoke.MethodHandle? it can call obj.super.method()

For invoking a super method (aka. invoke-super), you can use JNIEnv::CallNonvirtual<Type>Method.

@teble I'm honestly not sure if java.lang.invoke.MethodHandle is what I'm looking for, but it kind of sounds like it might be based on what I'm reading. Can I use callMethod() with obj.super then?

@cinit I'm not sure I understand this.


Dem volume insertion initial velocities

Description of the problem

This is a follow up from Victor's comment from PR [#1074

The initial velocity and initial angular velocity are now define with one parameter each.
Really quick PR.
No example or application test (except for  one) was using those parameters.

Ohh shoot, did not see the comments before the merge. You can fix them in a secondary quick PR @OGaboriault


Add support for bottom menu

Problem description
You already have something similar in TabFolder. Sometimes you want to use this menu with other widgets, but this is not possible. Alas, while Row does not yet exist, there are problems with the automatic horizontal organization of content. It is not convenient to make an adaptive menu without using TabFolder. We have to calculate all the positions of the icons. Please give developers direct access to BottomNavigationView and UITabBar

Thanks for your feedback. While you are correct that we use the BottomNavigationView in the TabFolder you can in fact use it "standalone" with some manual work. If you don't specify a height of the tabfolder you it will be as high as the bar. you can than react on the select events to show arbitrary content above it.
Add the native view as a standalone widget is something that could be useful as well though.


[FEAT] Add find functionality for string

Resolves #1925
Returns the first occurrence of the substr provided, -1, in case of fails to find.

Great work! 🚀


Suggestion to break up these tables

Long tables like these are very difficult to read and track.
By the time I've scrolled down to view info for my product, I've lost track of the headings and what each column indicates.
I suggest either breaking it up alphabetically with links a-z. Or perhaps we should add some sort of a scrolling heading to our template ;)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e27d0b1-56f9-2eb7-8fee-0c47cfbafeac
Version Independent ID: 12556227-6adc-52c1-ac60-f341ae247e51
Content: Azure Services in FedRAMP and DoD SRG Audit Scope - Azure Government
Content Source: articles/azure-government/compliance/azure-services-in-fedramp-auditscope.md
Service: azure-government
GitHub Login: @Jain-Garima
Microsoft Alias: gjain

@batamig we'll review your feedback and get back to you shortly. Thanks.

@batamig we'll review your feedback and get back to you shortly. Thanks.

closing as page doesn't exist anymore

This list is too short. Add all the services add default the search to only show at least audit for fedramp high. Get rid of repeated "service" row.  Try to freeze the service row at the top while I'm in the table, that might help some people.