add query_name as tag from Spark Structured Streaming metrics

What does this PR do?
Adds a query_name tag for Spark Structured Streaming metrics.
Part of the implementation for Structured Streams added in #8078 included a regex pattern to capture and validate the metric_names related to structured streaming, but didn't capture the stream's query_name, which is also a provided component within the metric key.
Motivation
This is a necessary tag to have if a cluster is running more than 1 stream! Without the query_name tag there is no way to disambiguate which stream is producing the structured_streaming metrics for that cluster.
Additional Notes
A query name is optionally set on the Structured Stream when writing to a sink.  If the queryName param is not supplied, you will see a UUID in it's place, as evidenced by the diff in spark/tests/fixtures/metrics_json.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@otosky Thanks! Can we put this behind a flag in case of default high cardinality due to UUIDs?

@ofek Definitely - is it preferred to have this default False and then have the client op-in in their config?

Yes please!

Hi @otosky, when adding the config option, can you also include a warning in the description that the option should not be enabled unless the queryName param is supplied?

@ofek & @sarah-witt
added an enable_query_name_tag flag and I think I added documentation in the right places.  Let me know if I'm missing anything or if anything needs renaming.

Awesome!  Is there anything I have to do to get that last "PR Labels" check green?

No, we can ignore that though!


Gogs avatars without domain

per issue #1260
the gogs implementation currently assumes a gravatar url with a format of //1.gravatar.com/gravatar/<hash>. If someone is not using gravatar, and has uploaded a custom avatar, the url format with be /avatars/<id>.
we need to account for the latter by prepending the //<hostname>

cc @Svenskunganka
just merged the following pull request:
https://github.com/drone/drone/pull/1265/files
this attempts to expand relative avatar urls to the full url. It is passing tests, but I haven't tested with a non-gravatar gogs configuration, so I'm looking forward to your feedback

Alright, the repo images works well, however the profile image up top is still trying to access the avatar the old way:

Good catch. Pushed a fix for the User avatar that should be available in ~5 min once the build completes. This will require you to login / logout so that it can persist the absolute URL.

Yep, everything's good now after logout/login! Awesome work, Brad!

Found a last issue with the Avatars now that I'm starting with the actual builds that I did not have access to before:

can you get me a copy of the hook payload (from gogs repo settings, hook)? It would be helpful to see what the avatar looks like that comes in the message

Sure, this is the interesting part of the payload:
{
  ...
  "sender": {
    "login": "Svenskunganka",
    "id": 1,
    "avatar_url": "https://git.domain.tld//avatars/1"
  }
}

does the image tag in the drone UI have https://git.domain.tld//avatars/1?
we actually have a similar issue with gravatar, where I had to create a helper function to parse out ///:
func fixMalformedAvatar(url string) string {
	index := strings.Index(url, "///")
	if index != -1 {
		return url[index+1:]
	}
	return url
}

Yeah it has, and directly accessing that link gives a 404 from Gogs, so I think it's a problem on their end.

ok, cool, I'm updating the fixMalformedAvatar function now

ok, just pushed https://github.com/drone/drone/commit/e1daf0fd749c3d05b200547e24ab4a353e7a138d


Rufus not triggering when running Puma as a daemon (Rufus 3.7, Puma 5.2.1)

I seem to be encountering the same symptoms as https://github.com/puma/puma/issues/607, which was apparently solved several years ago but maybe resurfaced in a newer update?
Rails 4.2.11
Ruby 2.5.2
Rufus Scheduler 3.7
Puma 5.2.1
Here is my scheduler: config/initializers/rufus-scheduler.rb
require 'rufus-scheduler'

s = Rufus::Scheduler.singleton

s.every '6s' do
  puts "Test output without calling a rake task"
  File.open(Rails.root.join('tmp', 'rufus-log.txt'), 'w') { |f|
    f.write("Running task, writing output #{Time.current}") }
end

s.cron '* * * * *' do |job|
  Rails.logger.info '=' * 80
  Rails.logger.info Time.now
  Rails.logger.info '-' * 80
  Rails.logger.info [ :env_tz, ENV['TZ'] ].inspect
  Rails.logger.info [ :uname, (`uname -a` rescue nil) ].inspect
  Rails.logger.info [ :rv, RUBY_VERSION, :rp, RUBY_PLATFORM ].inspect
  Rails.logger.info [ :ra, (Rails::VERSION.to_s rescue :nora) ].inspect
  Rails.logger.info EtOrbi.render_nozone_time(Time.now.to_f)
  Rails.logger.info EtOrbi.platform_info
  Rails.logger.info [ :fu, Fugit::VERSION, :rs, Rufus::Scheduler::VERSION ].inspect
  Rails.logger.info '-' * 80
  Rails.logger.info Fugit.parse('*/1 5-15 * * 0-5').inspect
  Rails.logger.info [ :nt, Fugit.parse('*/1 5-15 * * 0-5').next_time.to_s ].inspect
  Rails.logger.info '-' * 80
end

puts "Done scheduling Rufus"

Rails server as a terminal process (not a daemon)
Output (running as a server in console, RAILS_ENV=development)
stock_trend_finder (development_updates)$ rails s -p 4000
=> Booting Puma
=> Rails 4.2.11 application starting in development on http://localhost:4000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Done scheduling Rufus
Puma starting in single mode...
* Puma version: 5.2.1 (ruby 2.5.2-p104) ("Fettisdagsbulle")
*  Min threads: 0
*  Max threads: 5
*  Environment: development
*          PID: 1879
* Listening on http://<IP_ADDRESS>:4000
* Listening on http://[::1]:4000
Use Ctrl-C to stop
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
================================================================================
2021-02-19 12:06:00 -0500
--------------------------------------------------------------------------------
[:env_tz, nil]
[:uname, "Linux DESKTOP-PTRKO96 4.19.104-microsoft-standard #1 SMP Wed Feb 19 06:37:35 UTC 2020 x86_64 GNU/Linux\n"]
[:rv, "2.5.2", :rp, "x86_64-linux"]
[:ra, "Rails::VERSION"]
(secs:1613754360.0179772,utc~:"2021-02-19 17:06:00.017977237701416016",ltz~:"EST")
(etz:nil,tnz:"EST",tziv:"1.2.9",tzidv:nil,rv:"2.5.2",rp:"x86_64-linux",win:false,rorv:"4.2.11",astz:[ActiveSupport::TimeZone, "America/New_York"],eov:"1.2.4",eotnz:#<TZInfo::TimezoneProxy: America/New_York>,eotnfz:"-0500",eotlzn:"America/New_York",eotnfZ:"EST",debian:"America/New_York",centos:nil,osx:"America/New_York")
[:fu, "1.4.2", :rs, "3.7.0"]
--------------------------------------------------------------------------------
#<Fugit::Cron:0x00007f8b1404e920 @original="*/1 5-15 * * 0-5", @cron_s=nil, @seconds=[0], @minutes=nil, @hours=[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15], @monthdays=nil, @months=nil, @weekdays=[[0], [1], [2], [3], [4], [5]], @zone=nil, @timezone=nil>
[:nt, "2021-02-19 12:07:00 -0500"]
--------------------------------------------------------------------------------
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
================================================================================
2021-02-19 12:07:00 -0500
--------------------------------------------------------------------------------
[:env_tz, nil]
[:uname, "Linux DESKTOP-PTRKO96 4.19.104-microsoft-standard #1 SMP Wed Feb 19 06:37:35 UTC 2020 x86_64 GNU/Linux\n"]
[:rv, "2.5.2", :rp, "x86_64-linux"]
[:ra, "Rails::VERSION"]
(secs:1613754420.056664,utc~:"2021-02-19 17:07:00.05666399002075195",ltz~:"EST")
(etz:nil,tnz:"EST",tziv:"1.2.9",tzidv:nil,rv:"2.5.2",rp:"x86_64-linux",win:false,rorv:"4.2.11",astz:[ActiveSupport::TimeZone, "America/New_York"],eov:"1.2.4",eotnz:#<TZInfo::TimezoneProxy: America/New_York>,eotnfz:"-0500",eotlzn:"America/New_York",eotnfZ:"EST",debian:"America/New_York",centos:nil,osx:"America/New_York")
[:fu, "1.4.2", :rs, "3.7.0"]
--------------------------------------------------------------------------------
#<Fugit::Cron:0x000055dd9d483110 @original="*/1 5-15 * * 0-5", @cron_s=nil, @seconds=[0], @minutes=nil, @hours=[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15], @monthdays=nil, @months=nil, @weekdays=[[0], [1], [2], [3], [4], [5]], @zone=nil, @timezone=nil>
[:nt, "2021-02-19 12:08:00 -0500"]
--------------------------------------------------------------------------------
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task
Test output without calling a rake task

<...continues on...>

I can confirm that it was writing to the file in tmp/rufus-log.txt as expected too.
Rails server as a terminal process (as a daemon)
RAILS_ENV=development
stock_trend_finder (development_updates)$ rails s -d -p 4000
=> Booting Puma
=> Rails 4.2.11 application starting in development on http://localhost:4000
=> Run `rails server -h` for more startup options
Done scheduling Rufus

If I tail the Rails log I see nothing, except a lone DB query that it runs for another initializer at startup.

Hello,
so in Rails daemon mode, Puma only advertises "Booting Puma" and nothing more. It may be going in clustered mode.
if you put this in a config/puma.rb:
on_worker_boot do |worker_number|
  puts ". worker ##{worker_number} starting ..."
end

Does it behave differently in daemon versus non-daemon?
If yes, you could start the scheduling from there. Maybe:
on_worker_boot do |worker_number|
  puts ". worker ##{worker_number} starting ..."
  if worker_number == 0
    Rufus::Scheduler.singleton.every '5s' do
      puts ".. Hello, it's #{Time.now}"
    end
  end
end

https://puma.io/puma/#configuration
https://gist.github.com/rpocklin/308ba709a9647f7d1b92

I need to look up more about this clustering mode you mention, but for now here's the result of running the code you suggested:
stock_trend_finder (development_updates)$ rails s -p 4000
=> Booting Puma
=> Rails 4.2.11 application starting in development on http://localhost:4000
=> Run `rails server -h` for more startup options
=> Ctrl-C to shutdown server
Done scheduling Rufus
Puma starting in single mode...
* Puma version: 5.2.1 (ruby 2.5.2-p104) ("Fettisdagsbulle")
*  Min threads: 0
*  Max threads: 5
*  Environment: development
*          PID: 25980
* Listening on http://<IP_ADDRESS>:4000
* Listening on http://[::1]:4000
Use Ctrl-C to stop
Test output without calling a rake task
Test output without calling a rake task
================================================================================
2021-02-19 18:01:00 -0500
--------------------------------------------------------------------------------
[:env_tz, nil]
[:uname, "Linux DESKTOP-PTRKO96 4.19.104-microsoft-standard #1 SMP Wed Feb 19 06:37:35 UTC 2020 x86_64 GNU/Linux\n"]
[:rv, "2.5.2", :rp, "x86_64-linux"]
[:ra, "Rails::VERSION"]
(secs:1613775660.1281312,utc~:"2021-02-19 23:01:00.12813115119934082",ltz~:"EST")
(etz:nil,tnz:"EST",tziv:"1.2.9",tzidv:nil,rv:"2.5.2",rp:"x86_64-linux",win:false,rorv:"4.2.11",astz:[ActiveSupport::TimeZone, "America/New_York"],eov:"1.2.4",eotnz:#<TZInfo::TimezoneProxy: America/New_York>,eotnfz:"-0500",eotlzn:"America/New_York",eotnfZ:"EST",debian:"America/New_York",centos:nil,osx:"America/New_York")
[:fu, "1.4.2", :rs, "3.7.0"]
--------------------------------------------------------------------------------
#<Fugit::Cron:0x00007fb56c0263a8 @original="*/1 5-15 * * 0-5", @cron_s=nil, @seconds=[0], @minutes=nil, @hours=[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15], @monthdays=nil, @months=nil, @weekdays=[[0], [1], [2], [3], [4], [5]], @zone=nil, @timezone=nil>
[:nt, "2021-02-21 05:00:00 -0500"]
--------------------------------------------------------------------------------
^C- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2021-02-19 18:01:02 -0500 ===
- Goodbye!
Exiting
stock_trend_finder (development_updates)$ rails s -d -p 4000
=> Booting Puma
=> Rails 4.2.11 application starting in development on http://localhost:4000
=> Run `rails server -h` for more startup options
Done scheduling Rufus

It seems rails -d for Rails 4.2 doesn't read config/puma.rb https://github.com/puma/puma/issues/1253

OK, it seems you would need to use a newer version of Rails or to call bundle exec puma (as seen in the puma issue 1253 above).
I've tested with a setup similar to yours and, like you, starting with rails s -d ends up with the threads killed by the daemonization forking. The rufus-scheduler thread is killed at that point.
If you use bundle exec puma Puma will let you use config/puma.rb and tune your application.

Thank you for the help John. It seems that in the latest version of Puma they removed daemon support (https://github.com/puma/puma/pull/2170) . I've decided that the easiest way of working around this is to run my app in a Docker container, and could spin up a separate container for the scheduled jobs, after putting them in a rake task.


initial release errors

I have a new project where I'm trying to do an initial release. release-it fails on
    "changelogCommand": "git log --pretty=format:'* %s (%h)' [REV_RANGE]",

which resolves to
git log --pretty=format:'* %s (%h)' 0.0.0...HEAD

As far as I can tell, the range it's building is "package.version to HEAD", but in this case, what I have in package.version doesn't represent a valid tag.
To get this out, I had to add a custom "changelogCommand" for my initial release.
    "changelogCommand": "git log --pretty=format:'* %s (%h)'",

For subsequent releases I will be able to reuse the default "changelogCommand".
I don't mind submitting a PR to fix, but my solution wasn't elegant. IE: how would the script know that a tag cannot be found because it's the initial release? Looking for your thoughts @webpro. If nothing else, the documentation can be updated with this gotcha.

One option would be to inspect whether the result of git tag --list is empty. If so, no value for REV_RANGE.

Hi @jfairley, thanks for the report. I think I've implemented a solution for the initial release in 2.4.0. Could you please test if this works for you?

@webpro Sorry it took me a month to test. I just created a little demo project, and it worked great. Thanks!
https://github.com/jfairley/release-it-test/releases


⚠ AGEG website (prod) has degraded performance

In 0472454, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 2056 ms

Resolved: AGEG website (prod) performance has improved in 7e6e41b.


npm @microsoft/applicationinsights-web: license information missing in package.json

Just a minor issue leading to a warning in our context, but nagging for us. It would be great if you took a look at it!
We are using license-webpack-plugin to aggregate and check licenses of the npm packages.
Because of missing license information (thus also unspecified on the npm web site https://www.npmjs.com/package/@microsoft/applicationinsights-web, reading "None") we receive a build warning:
license-webpack-plugin: could not find any license type for @microsoft/applicationinsights-web in its package.json
We know that there are some (non-working) workarounds for this in license-webpack-plugin, but it would be wise to specify the license correctly in the right place (presumably).
Thanks!

Fixed deployed as NPM and next CDN channels

Closing as this was an NPM issue only


Can't tab out of field when calendar is open and breaks accessibility

Describe the bug
2.9.6 was not crashing using Select Year/Month dropdown
2.15.0 fixed it but it is not possible to tab out of the field and get the value selected when moving to the next field 2.9.6 does work.
To Reproduce
Steps to reproduce the behavior:

Focus on the field
use keyboards arrows to move to a date without selecting it
hit tab or shift+tab to move to another field
it does not move to the other field, it focus inside the calendar and it also breaks the accessibilty hotkeys

Firefox
Chrome

Looks related to https://github.com/Hacker0x01/react-datepicker/issues/2140. Even a user that has a mouse can't access the other date field without double-clicking. This is a breaking change and we are locking down the version of this package in our repos until it is fixed.

Any workarounds for this ?

This can solve half of the issue to set the value on tab. Otherwise just use the older version.
onKeyDown = (e: any) => {         if (e.key == 'Tab') {             setTimeout(() =>                 this.ref!.setOpen(false), 100             )         }     }
Only work around for moving to the next field i've found so far is to specify where you want to focus next, but quite tedious to have to specify this everywhere.

Hi, I'm still experiencing this issue when a timepicker is present with version 3.4.1
Unable to tab out and breaking accessbility.

I have the same issue, any updates on this?

Still got this issue   - Win7 + IE 11

Will this issue be fixed?

I'm experiencing this issue as well. Any update?

This is an issue for me as well

This can solve half of the issue to set the value on tab. Otherwise just use the older version.
onKeyDown = (e: any) => { if (e.key == 'Tab') { setTimeout(() => this.ref!.setOpen(false), 100 ) } }
Only work around for moving to the next field i've found so far is to specify where you want to focus next, but quite tedious to have to specify this everywhere.
I ended up going with version 2.9.0. This solves any tabbing issues in my case and requires no workaround code - keeping things simple.

2.10.1 worked for me, and it is definitely broken by 2.16.0. I'm not going to go version by version to try to figure out which one broke it. Still broken in latest (4.1.1 as I write this).
Also if you tab into the field, type in a date manually, then tab out, the tab gets stuck looping through prev month, next month, and date. It won't tab to the next field ever.

Hello! I need to know if this issue still present on the current version?

@tammypmc

Hello! I need to know if this issue still present on the current version?

I'm no longer working on any react project. But I can reproduce on the demo page: https://reactdatepicker.com/

Click near the input field on the first example (not the one at the top, it does other weird stuff. The first one under "Examples".)
Tab => Focus goes into the input field
Start hitting tab again => It loops between input field, prev month, next month, selected date, and back to input field.

I'm on Chrome on Windows. I've attached a video - all I'm doing in the video is hitting tab over and over
https://user-images.githubusercontent.com/2453426/135771190-288484e2-ed02-4396-8072-8567545da3d0.mp4

Steps to produce: Click tab until you are stuck in a loop
Requirements for it to happen: There needs to be the arrows for changing months visible
So if you use includeDates option to limit the dates to only one month, there won't be any arrows visible, and the user can properly tab out of the datepicker (although it's left open).

My solution is to disable the calendar opening on focus which will allow tabbing past this input. And then allowing the user to hit Enter key to open the calendar when on the input. From there, the user can select a date via Enter key or close the calendar via Esc key to the tab on.
  const handleOnKeyDownDatePicker = event => {
    if (datePickerRef?.current && !datePickerRef.current.state.open) {
      if (event?.keyCode === 13 || event?.which === 13) {
        event.preventDefault();
        datePickerRef.current?.setOpen(true);
      }
    }
  };

  <ReactDatePicker
    ...
    preventOpenOnFocus={true}
    ref={datePickerRef}
    onKeyDown={handleOnKeyDownDatePicker}
  />

Anymore information on this one? It would be great to have at least an option to cycle to the next input after the calendar closes. Seeing the issue when a user tabs in, focuses, selects a date. Hitting tab again just selects the same input over and over again.

This is not an issue, Check out the modal pattern as explained in this WAI-ARIA article:
https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal/
If focus is on the last tabbable element inside the dialog, moves focus to the first tabbable element inside the dialog.
Since the tooltip is interactive, having a focus-trap is a good thing, its not breaking accesibility.

This is not an issue, Check out the modal pattern as explained in this WAI-ARIA article:

Have you tried it though? The user is literally incapable of going anywhere else on the page without using the mouse. Hitting enter or space bar doesn't dismiss the dialog, neither does escape key.

@ch1qui this issue happens after you have closed the calendar and selected a date. So the flow goes:

tab into a field
Calendar pops
Choose date
Calendar closes
Tab into next field

where I think it’s broken is the fact that it pops the SAME calendar on the SAME field previously selected. Therefore a keyboard user can never tab to the next field. Hope this makes more sense!

When I try to skip over the calendar entirely with tab there is no way to do so, when I tab into the input button and then press tab again would expect to focus on the next input but instead the calendar dropdown opens automatically (I would have expected it to open like a dropdown via the space bar or literally anything other than tab). Then when I am in the component, I tab through it all and it loops, as expected. But when I press escape my focus is brought back to the input field for the date picker, which as I explained I cannot skip.
How is a keyboard user expected to access content past your component?

Yes, I agree @reinrl. We shouldn't treat this as a modal but more as a native part of the page you're on. Users should be able to tab out of it like other fields. However, looking at the examples here: https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/datepicker-dialog/ it seems the recommended path is to treat a datepicker as a modal. I'm not 100% sure what's best since I'm not an accessibility expert.

@martijnrusschen Thanks for the quick reply - I stand corrected (sorry @ch1qui - that guidance from the WAI really surprises me, based on what I thought that I knew about other various input elements!). I don't profess to be an A11Y expert either (only having benefited from working with a few different vendors at various jobs), so our next steps are going to be to go back to our current compliance vendor with that link in hand, and see what they have to say about that information versus their own guidance that the calendar view should not trap the user's focus. We usually hear back pretty quickly, so I will circle back here once I hear more.

Sounds good!

@martijnrusschen Thanks for the quick reply - I stand corrected (sorry @ch1qui - that guidance from the WAI really surprises me, based on what I thought that I knew about other various input elements!). I don't profess to be an A11Y expert either (only having benefited from working with a few different vendors at various jobs), so our next steps are going to be to go back to our current compliance vendor with that link in hand, and see what they have to say about that information versus their own guidance that the calendar view should not trap the user's focus. We usually hear back pretty quickly, so I will circle back here once I hear more.

My apologies, as it would appear that I never did circle back on this in a timely fashion. After some further conversation with our A11Y vendor, we settled on a bit of a hybrid approach:

when open, the date picker does act like a modal (trapping focus within the various actions presented)
we no longer open the date picker "modal" when the field is focused (instead adding a calendar icon button to trigger the opening), so you can continue to tab right through the fields in the form without getting trapped on a date field


Change example links to a hash

This avoids broken links.
Fixes #956

@edwardhorsford @roshaanbajwa sorry, re-review please – the link-styled-as-button example unexpectedly broke the tests when changing it to # so I’ve switched that one to link to / for now.


Minor cleanups for string table rewrite

Minor changes:

[ ] Reorganize clen/arridx/isascii flag check order

With lazy charlen no longer relevant, closing as unmerged.


Incorrect variable in Makefile for Linux shared

Use the shared library version on Linux
Running on Ubuntu 19.10
cd src
cp Makefiles/Makefile_linux_shared Makefile
make
Side note: I needed to have boost installed to make this compile:
sudo apt-get install --no-install-recommends libboost-all-dev
make install
The make install fails because it is using the STATIC variable and not the SHARED
The fix is below:
change ./src/Makefiles/Makefile_linux_shared at lines 122 and 123 and replace STATIC_LIB with SHARED_LIN
diff Makefile Makefiles/Makefile_linux_shared
122,123c122,123
< 	cp $(SHARED_LIB) ../test
< 	cp $(SHARED_LIB) ../examples

cp $(STATIC_LIB) ../test
cp $(STATIC_LIB) ../examples

Thanks. Fixed in next release.


Small overlay in OBS

Hello, first of all, thank you very much for the information ... I want to tell you the following, I have mac and rekorbox, I did the whole procedure for Kuvo and when I go to add the URL of unbox in OBS the overlay appears so small that you see a very thin line, it is as if it were on a very small scale, I did tests with other urls and the result is normal ... I wanted to check the url of unbox, for example http: // localhost: 8080 / asot.html opening it in chrome and it looks good, and it is updated as the songs are played ... I don't know the problem, thanks for attending, greetings

What resolution did you set in browser source in OBS?

Hmmm yeah usually this is caused by not setting the resolution in OBS to the average browser size: 1366 x 784
Can you try that resolution and let us know what it looks like?

Hello, first of all, thank you very much for the information ... I want to tell you the following, I have mac and rekorbox, I did the whole procedure for Kuvo and when I go to add the URL of unbox in OBS the overlay appears so small that you see a very thin line, it is as if it were on a very small scale, I did tests with other urls and the result is normal ... I wanted to check the url of unbox, for example http: // localhost: 8080 / asot.html opening it in chrome and it looks good, and it is updated as the songs are played ... I don't know the problem, thanks for attending, greetings

Hey out of interest, is kuvo working for you on a whole set (on Mac)? I'm on 6.5.1 and it really isn't working at all or does for a couple of tracks and stops. Kuvo's problem, not this app, as the site doesn't update from Rekordbox itself. Yours is working?

What resolution did you set in browser source in OBS?

1280X720 and so it looks:

Hmmm yeah usually this is caused by not setting the resolution in OBS to the average browser size: 1366 x 784
Can you try that resolution and let us know what it looks like?

I tried it and it appears the same

Hey out of interest, is kuvo working for you on a whole set (on Mac)? I'm on 6.5.1 and it really isn't working at all or does for a couple of tracks and stops. Kuvo's problem, not this app, as the site doesn't update from Rekordbox itself. Yours is working?

I have an old OBS because I have the El Capitan operating system on my mac and I use rekorbox 5. The problem I have is the size of the overlay, but the information of the track that is updating with kuvo works for me, because I tried the other file that of rekorbox_stream. txt.

It already works for me but in the following way. I left the rekorbox on my mac and on another mac I left it to transmit, I updated to BIG SUR, and installed the latest version of OBS, and so if it worked for me.


[BUG] Repo does not include the Gemfile.lock file

Version, Branch, or Commit:
Main branch
Expected behavior:
The Gemfile.lock shouldn't be ignored from git, it should be added to make sure everybody uses the same versions of gems.
Actual behavior:
Gemfile.lock is missing, so running bundle install is not predictable and different developers can have different versions of dependencies.
I will abide by the code of conduct

@arielj I'm pretty sure that's on purpose and not a bug. I believe @bronzdoc and I have discussed this in the past.

@arielj these two blogposts should clarify why we don't include the Gemfile.lock in gems
https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
https://bundler.io/guides/faq.html#why-cant-i-just-specify-only-dependencies

@bronzdoc those two articles say opposite things about committing Gemfile.lock:
From the first one:

Do not check your Gemfile.lock into version control, since it enforces precision that does not exist in the gem command, which is used to install gems in practice. Even if the precision could be enforced, you wouldn't want it, since it would prevent people from using your library with versions of its dependencies that are different from the ones you used to develop the gem.

From the second:

Q: What happens if I put a Gemfile in my gem?
A: When someone installs your gem, the Gemfile and Gemfile.lock files are completely ignored, even if you include them inside the .gem file you upload to rubygems.org. The Gemfile inside your gem is only to make it easy for developers (like you) to install the dependencies needed to do development work on your gem. The Gemfile also provides an easy way to track and install development-only or test-only gems. Read about Gemfiles in gems from the Bundler in gems page and the How to create a gem with Bundler guide.

A: Yes, you should commit it. The presence of a Gemfile.lock in a gem's repository ensures that a fresh checkout of the repository uses the exact same set of dependencies every time. We believe this makes repositories more friendly towards new and existing contributors. Ideally, anyone should be able to clone the repo, run bundle install, and have passing tests. If you don't check in your Gemfile.lock, new contributors can get different versions of your dependencies, and run into failing tests that they don't know how to fix.

Considering the Gemfile.lock includes a section about the "RUBY VERSION" and this is a library that has a testing matrix (ie. https://github.com/fastruby/dotenv_validator/blob/main/.github/workflows/main.yml#L29) I don't think it would be a good idea to include a Gemfile.lock in the repository. I think the cons outweigh the pros for this project.


mp4 not created

Hello, my conversions in radarr will not finish. Right when it finishes it throws an error and does not create the mp4. I cant see any real useful information in the log file even with debug on. I know this is a ffmpeg error but hoping you might have some insight. I even tried using the same ini from sonarr which works fine. They both use the same directories and are both updated and both use the same docker config.
LOG: https://pastebin.com/raw/vPaf1JW0
CONFIG: https://pastebin.com/raw/hRr5e32Y

I would take the generated FFMpeg command and run it manually and see if that gives you any more info cause the logs aren't super helpful here


Release dates for browsers can be taken from BCD

see : https://github.com/mdn/browser-compat-data/tree/main/browsers

Indeed, and that's where I'm getting that data already!
I assume you're filing this issue due to this remark from the README:

(Strangely, release dates are visible on caniuse.com, but not available in data.json. I've filed this as https://github.com/Fyrd/caniuse/issues/6726.)

By that, I only meant that it's annoying that I have to depend on both caniuse and BCD, when I really ought to be able to just depend on caniuse. But, whatever, BCD is right there, and it's fine.

Ah, I missed that you were already using BCD.
Yeah it doesn't make much sense to me to track the release data in two projects.
We always combine the two data sets when needed :)

It turns out that caniuse does provide release dates, in an undocumented 2.0 version of the JSON. https://github.com/Fyrd/caniuse/blob/main/fulldata-json/data-2.0.json I've filed https://github.com/Fyrd/caniuse/pull/6728 to link to it.

Nice!


Parallelize IngestionPipeline.run

Description

Adds parallel processing for ingestion pipeline run
Uses multiprocessing Pool.starmap

NOTE: I didn't encounter the cannot pickle CoreBPE error. It seems that moving parallelization up to the run method has resulted in not needing to pickle lower-level imports. If we had defined tokenizer here directly like we have in SentenceSplitter, then that's when we'd see the error and need the fix. The same goes for the partial fix for lambda funcs not being pickle-able — that fix is no longer necessary here.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[x] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

LGTM!


Question: Delta Indices and Testing

In our application, I had rspec set up almost exactly the way you describe in the documentation and it was working well -- without delta indexing. But I turned on deltas for one index and now the specs for that index hang -- I've done some investigation and it's because the index_finished? method never seems to return true. Checking why, it's because this file, db/sphinx/test/ts-event_instance_delta.tmp never goes away. I'm not sure why -- delta indices are working fine in practice, it just seems to be hanging in the test environment.
Is there any extra configuration needed to make it work with deltas in the test environment?

Which version of TS are you using? Also: try deleting that file, then running the tests, and see if they keep hanging...

Doh! Deleting the file solved it. Thanks!

Sometimes those files get stuck, and so further updates fail. I'm pretty sure the TS code has improved in recent releases to avoid such situations (it'll try to delete the file even when an exception's raised), so best to use the latest if possible :)

Sounds good, thanks!

Thanks all for writing this, I was running into the same issue. It might be helpful to mention in the README that you should check that you have no leftover tmp files in your DIR that will cause your sphinx specs to hang indefinitely.

Appreciate the comment @corinnekunze - and for everyone who's been hit by this issue, I've made the following changes lately:

Added details of the guard files to the documentation - both in the rake tasks section and the common issues section.
Made sure guard files are removed as part of a rebuild (9c91644d2c309a16017882820576fb94107dcf71).
Add a warning about any present guard files when running a full index (5784551c3b619b5930a928924706457394f6c7c6).


[Enhancement] Routing for 'Intro to pandas'

Selecting 'Intro to pandas' shows no routes available. I can take a look at this, please assign me.

Yes You can work on it @fjuren

Resolved routing issue "intro to pandas"

@fjuren yeah, its done.


Create uttehuacan.txt

@lacorp2513 First stage of verification passed, official domain is uttehuacan.edu.mx as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@lacorp2513 Pull request merged. Thank you.


Add verbose flag to copod model

Hi,
I think you should send PR to the development branch at first.
https://github.com/yzhao062/pyod#how-to-contribute
Best regards,
Akira


fabric-sdk: Chaincode Enhancements

This Issue calls for the following improvements to platform/fabric/core/generic/chaincode:

[ ] (Invoke) Add a timeout when requesting endorsements
[ ] (Invoke) Retry if the endorsement cannot be achieved
[ ] (Discover) Filter by Ledger Height

partially addressed, the rest will be done when needed


Feature/initial setup

Sets up the project directory structure and provides an example on entry into Angular application from Django template.

I'm no python expert, but that side looks good from what I know 👍

Cool, I have another commit to add for migrations and touch up the readme before I merge it.


OIIO dependency fixes

Fancy new FindOpenImageIO.cmake, and related cleanup
Bump OIIO minimum to 1.7
Remove old #if's related to older OIIO versions

This is master only, it will not be backported to OSL 1.8.

LGTM!


Bug: wc2, DEEPLINK_CHOICE breaks usage when no app can be opened

Current Behavior (Desktop!)
https://github.com/WalletConnect/walletconnect-monorepo/issues/2303#issuecomment-1539185204
There is a localstorage item set: WALLETCONNECT_DEEPLINK_CHOICE
this gets set whenever you select a wallet on the wc2 modal (using deeplinking)
When the link set in this storage item does not have a corresponding app to open (like a desktop app / mobile app) it redirects on the dapp to the last used deep link. This redirect happens on every transaction attempt, even if the connected wallet is not the one set on storage
the actual tx request does pop up in a connected wallet, but the entire session on the dapp side is lost
Expected Behavior
based on this demo: https://react-app.walletconnect.com/
the item gets removed whenever navigating back in the wc-modal, and gets cleared upon opening the modal
this prevents accidental setting of item, and seems more likely that the connected wallet <> deeplink set are intended to be there
(added vid for clarification)
Steps To Reproduce

use onboard connect modal (latest)
click on wallet-connect (v2)
click on one of the shown deeplink-wallets
DONT CONNECT
click back, and use QR scanning or copy URI to connect an alternative wallet
once connected, attempt to do a transaction
redirect happens on dapp
*. can verify here that the page that opens is the link set in storage on walletconnect_deeplink_choice

What package is effected by this issue?
@web3-onboard/walletconnect
Is this a build or a runtime issue?
Runtime
Package Version
2.3.9
Node Version
16.17.1
What browsers are you seeing the problem on?
Chrome
Relevant log output
None

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Expected behavior based on the wc2 demo. (I think this will mostly solve the issue, just clear the storage item when no connection is established or another wallet ends up being used)
Screencast from 16-06-23 15:33:38.webm
More rigorous would be something to check if it is a proper deeplink, but idk

Is this supposed to happen purely on mobile? If so how could someone use the QR code 🤔

@glitch-txs no this is a desktop issue
when selecting a wallet from the list on wc-modal on desktop.
the expected behavior is that this opens a corresponding desktop-app wallet (not browser extension)
but the choice which is selected gets cached. so that when you click but don't decide to connect this choice stays and interferes with any usage after when you connect an alternative wallet by copying/scanning QR

This has been resolved on the WC side - PR to resolve within W3O: https://github.com/blocknative/web3-onboard/pull/1851

@L03TJ3 those updates are available with the latest version of @web3-onboard/walletconnect at version 2.4.4-alpha.1 and was merged with this PR for any more details : https://github.com/blocknative/web3-onboard/pull/1851/files


500 error when trying to delete a namespace

Created the following namespace:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/kubernetes-namespaces/v1beta3/namespace-prod.json
While there were no entities associated with it,
tried to delete it by accessing:
http://KubeMasterIP:8080/api/v1beta3/namespaces/production
with DELETE
Got the following 500 err:
{
"kind": "Status",
"apiVersion": "v1beta3",
"metadata": {},
"status": "Failure",
"message": "converting  to : type names don't match (Namespace, DeleteOptions), and no conversion 'func (v1beta3.Namespace, api.DeleteOptions) error' registered.",
"code": 500
}
cc @derekwaynecarr

that's a new one to me... are you seeing this failure currently on HEAD?

@derekwaynecarr
I have the code up to date correct to 3 days ago.
(set on  b9babb56b0962a22a93bcbaa02729f2da67dbf11)

I just tried to reproduce this on master with following steps:
$ cluster/kubectl.sh create -f examples/kubernetes-namespaces/namespace-dev.json
$ curl -i -X DELETE -k -u vagrant:vagrant https://<IP_ADDRESS>/api/v1beta3/namespaces/development
HTTP/1.1 200 OK
Server: nginx/1.4.7
Date: Wed, 08 Apr 2015 21:15:49 GMT
Content-Type: application/json
Content-Length: 494
Connection: keep-alive

{
  "kind": "Namespace",
  "apiVersion": "v1beta3",
  "metadata": {
    "name": "development",
    "selfLink": "/api/v1beta3/namespaces/development",
    "uid": "3201a85f-de34-11e4-8201-0800279696e1",
    "resourceVersion": "27586",
    "creationTimestamp": "2015-04-08T21:14:08Z",
    "deletionTimestamp": "2015-04-08T21:15:49Z",
    "labels": {
      "name": "development"
    }
  },
  "spec": {
    "finalizers": [
      "kubernetes"
    ]
  },
  "status": {
    "phase": "Terminating"
  }
}
$ cluster/kubectl.sh get namespaces
NAME      LABELS    STATUS
default   <none>    Active
development   name=development   Terminating

After waiting for namespace to terminate, it is then removed.
Closing this as I cannot reproduce.


?module causing error in KaTeX

Most KaTeX files work with the ?module parameter, but this one doesn't: https://unpkg.com/katex@0.9.0-alpha1/src/MacroExpander.js?module

Oh weird, the server thinks you're requesting an index page. I'll have a look.

Ah, that error message was misleading. I've fixed it.
The real problem is that the babel parser is choking on the type keyword. I could just add the flow preset to babel, but that begs the question about what to do when people are using typescript.
Ideally, we'd be able to infer a project's babel settings from the existing babel setup that a package uses, but the katex package just uses flow-bin and doesn't have any .babelrc files anywhere, so that'd be tricky. The .babelrc files were built specifically to address this issue, but when people don't use them it makes this kind of thing difficult.
I'm definitely open to suggestions on how to handle this. Not sure the best way forward.
/cc @hzoo

I see. I think this is an issue with KaTeX, and I don't think you should do anything but show the syntax error with an error response code. I'll file an issue with KaTeX.
I actually don't think you should pick up Babel configs at all, but only translate the module specifiers. Modules should be published to npm as consumable by browsers, and not publish source using upcoming features, TypeScript, Flow, etc.

We had the same issue with really to support both flow/ts in the react preset but in the end we decided for it to make more sense to remove "flow" from the react preset (not sure why it was there before other than fb + react + flow. Now that we have preset-typescript it didn't make sense.
At first we were just checking the //@flow beforehand so not sure if you want to have to parse that https://github.com/babel/babel/pull/5468 before enabling a plugin on the fly somehow
They don't publish the babelrc file (that has it's own problems too), can read from package json I suppose but that's only if they don't use their own preset.
Yeah, shouldn't have to read the file

I actually don't think you should pick up Babel configs at all, but only translate the module specifiers.

I think you're right, @justinfagnani. Going down that road leads to including all sorts of transforms and presets just to make sure that we're covering everyone.
I wonder if there's a way to avoid parsing the entire file, and just focus on transforming any import/export statements. I remember @Rich-Harris telling me a while back about https://github.com/Rich-Harris/magic-string, which avoids parsing the full AST and just focuses on string manipulation. That could be a possible solution.

Can be relatively simple to do as long as import/exports are always still top level (they are currently), std/esm might be doing that

I don't see what using a lax parser would bring to the table. While unpkg might be able to deal with the file, other tools and runtime wouldn't be able to. The files would error out on node, browsers and in bundlers that might pull from unpkg. I think it's just better to stick to parsing the latest ES revision + maybe stage 3/4 syntax.
I filed a bug on KaTeX though: https://github.com/Khan/KaTeX/issues/954 so we can close this now. Thanks for figuring it out!

Ya, good point. I guess that approach would just pass the problem to the next one in line.
Just FYI, I added better debugging info when using ?module so now the page looks like this:

Hopefully that will help to debug issues like this more easily :)


Rename repo and project

For our email to SOI, we decided to change the name to Synthetic Household File (SHF?) to better communicate that this project extends beyond the PUF (incorporating nonfilers, imputing other features, potentially different record count, etc.). This may also preemptively avoid a naming conflict with the TPC project, which seems like it might be called "synthetic PUF."
Should we adopt this name generally?
Also should we consider a term other than "household" since we're looking at tax units? For example, "Synthetic Microdata File?" Other ideas welcome.

I prefer to keep it general - Synthetic Household File or Synthetic Household Policy-Analysis File. I am not sure they will always be tax units; they certainly won't always be (and aren't always now) tax-filing units. If we do state-level analysis we may be very concerned about sales taxes or benefit issues, which won't always be driving by income tax filing status.
That said, it is just a preference. I don't feel strongly.

I agree on generality, which led me to the term "microdata," but I also don't feel strongly.
#11 got me thinking more generally about this though: SHF is really an umbrella project that would include synthesizing the PUF as well as other enhancement logic which currently lives in the taxdata and C-TAM repos. If we're just working on the PUF synthesis, maybe synpuf is actually an appropriate name, even if it's unpublicized and just lives as a piece of the SHF brand.
This raises questions around how these other enhancements play with the synthetic PUF (ideally as well as the real one, if Approach A in #11 is adopted), and what the real-PUF version of SHF would be called.
One potential end state would be to create two libraries:

synpuf, which has one key function, synthesize(), taking the raw PUF file and producing the synthetic one.
taxdata, which has one key function: enhance(), taking either the raw or synthetic PUF and producing the file used for Tax-Calculator. The synthetic file could be called SHF, real-PUF one name TBD.

All is to say, not sure we should rush to change this right now.
@MattHJensen @andersonfrailey

The two-function approach @MaxGhenis describes seems very clean to me. Even if, in practice, there is human intervention each time we run either of the steps (examining results, etc.), it is a nice separation that keeps the projects distinct and working well with each other. Curious for others' thoughts on this and on issue #11.


Ruff stops enforcing rules in src/ based layout

This is a slightly odd one to track down, but ruff has stopped enforcing any rules in my src/ folder!
I've got a private repo (which makes it hard to share, at least publicly).
The ruff rules have been constant for the life of the repo (it's about 6 weeks old), so I tried using git bisect
I've managed to track down the commit that breaks things, using this git bisect run script:
bash -c '(cat src/myproject/app.py; echo -e "\n\nf\"a\"" ) | ruff check --no-fix --stdin-filename src/myproject/app.py  - --diff 2>&1 | grep --fixed "+\"a\""'

And looking at the changed files in the breaking commit, it doesn't "add up":
 src/myproject/__main__.py                                                  | 18 +++++++++++++++---
 src/myproject/api/routers/health.py                                        | 11 -----------
 src/myproject/apiserver/router.py                                          |  8 ++++++++
 src/myproject/app.py                                                       | 46 +++++++++++++++-------------------------------
 src/myproject/{metascheduler => common}/versions/alembic.py                |  0
 src/myproject/{metascheduler => common}/versions/v2_2_4.py                 |  0
 src/myproject/{metascheduler => common}/versions/v2_5.py                   |  0
 src/myproject/common/models/dsn.py                                         | 23 +++++++++++++++++++++++
 src/myproject/dependencies.py                                              |  7 -------
 src/myproject/hypervisor/__init__.py                                       |  0
 src/myproject/hypervisor/dependencies.py                                   |  7 +++++++
 src/myproject/hypervisor/router.py                                         | 26 ++++++++++++++++++++++++++
 src/myproject/hypervisor/routers/health.py                                 | 11 +++++++++++
 src/myproject/logging.py                                                   |  5 +++--
 src/myproject/component/__init__.py                                        |  1 -
 src/myproject/settings.py                                                  | 14 ++++++++++++++

I'd be happy to share access to the repo for the commits in question if it helps debug.
Through-out this time errors are still flaged up in tests/

Ruff config in pyproject.toml
```
[tool.ruff]
line-length = 110
extend-select = [
    "W",    # pycodestyle warnings
    "I",    # isort
    "C90",  # Complexity
    "C",    # flake8-comprehensions
    "ISC",  # flake8-implicit-str-concat
    "T10",  # flake8-debugger
    "A",    # flake8-builtins
    "UP",   # pyupgrade
    "RUF",  # un-needed noqa stanzas
]
extend-ignore = ["A002"]
extend-exclude = [
    "__pycache__",
]
target-version = "py311"
fix = true
[tool.ruff.isort]
combine-as-imports = true
known-first-party = ["myproject", "tests"]
[tool.ruff.mccabe]
max-complexity = 6
</details>

(For future me, the breaking commit is b06f117fc and b06f117fc^ is good)

I'm not immediately sure what's going on. The first thing I'd wonder is if some of the files are being unintentionally excluded by the default exclusions list:
pub static EXCLUDE: Lazy<Vec<FilePattern>> = Lazy::new(|| {
    vec![
        FilePattern::Builtin(".bzr"),
        FilePattern::Builtin(".direnv"),
        FilePattern::Builtin(".eggs"),
        FilePattern::Builtin(".git"),
        FilePattern::Builtin(".hg"),
        FilePattern::Builtin(".mypy_cache"),
        FilePattern::Builtin(".nox"),
        FilePattern::Builtin(".pants.d"),
        FilePattern::Builtin(".pytype"),
        FilePattern::Builtin(".ruff_cache"),
        FilePattern::Builtin(".svn"),
        FilePattern::Builtin(".tox"),
        FilePattern::Builtin(".venv"),
        FilePattern::Builtin("__pypackages__"),
        FilePattern::Builtin("_build"),
        FilePattern::Builtin("buck-out"),
        FilePattern::Builtin("build"),
        FilePattern::Builtin("dist"),
        FilePattern::Builtin("node_modules"),
        FilePattern::Builtin("venv"),
    ]
});

E.g., that might happen if you moved files into a build subdirectory. But based on the layout above, I'm not seeing anything that would trigger that behavior.
The other possibility is that the automatic gitignore behavior somehow thinks those files should be ignored.
Are you able to share the output of running with --verbose?

❯ ruff --version
ruff 0.0.249

❯ ruff check --no-fix src/laminar/app.py --verbose
[2023-02-21][18:26:29][ruff::commands::run][DEBUG] Identified files to lint in: 1.6477ms
[2023-02-21][18:26:29][ruff::diagnostics][DEBUG] Cache hit for: /home/ash/code/astro/laminar/src/laminar/app.py
[2023-02-21][18:26:29][ruff::commands::run][DEBUG] Checked 1 files in: 10.105801ms

❯ rm -r .ruff_cache

❯ ruff check --no-fix src/laminar/app.py --verbose
[2023-02-21][18:26:41][ruff::commands::run][DEBUG] Identified files to lint in: 1.64271ms
[2023-02-21][18:26:41][ruff::commands::run][DEBUG] Checked 1 files in: 9.527063ms

And to force an error (isort and f-string without replacements):
diff --git a/src/laminar/app.py b/src/laminar/app.py
index 8370d1b..400aa8b 100644
--- a/src/laminar/app.py
+++ b/src/laminar/app.py
@@ -1,5 +1,5 @@
-import structlog
 from fastapi import APIRouter, FastAPI
+import structlog

 app = FastAPI()

@@ -22,3 +22,5 @@ def build_app() -> FastAPI:
     log.info("Starting", app=module.__name__)
     app.include_router(module.router)
     return app
+
+f"a"

(Happy to work out a way to get you a copy of the working and broken commits privately if it helps)

It would help a lot, if you're open to it. Do you want to send a zip by email (charlie.r.marsh@gmail.com)? What works best?

You've got mail!

I forgot that I shipped a feature in latest Ruff that silently turns it off for all of your projects specifically.

😿

Is the issue not that app.py now contains a match statement? Which is suppressed with # noqa: E999. (But the presence of the match means we can't check the AST.)
If you remove the noqa, you get a warning, like: error: Failed to parse src/laminar/app.py: invalid syntax. Got unexpected token 'settings' at line 16 column 11.
If you add an error that's not based on the AST (like a long line), you get: src/laminar/app.py:26:89: E501 Line too long (91 > 88 characters).
If so, this should all be moot anyway since match support just merged. But maybe I'm misdiagnosing here.

Ooooh shiny. Testing out a main build now.
I guess it makes sense that with the syntax errors it can't parse the AST to enforce more of the rules.

Yup, confirmed. Main fixes it.


Gatt code documentation

-Documenting the gatt library used for working with GATT and connecting to the Wahoo devices.
-Covers commonly used methods, properties, and classes contained in the drivers.

Please discard any changes to the BLEConnectivityFix.md file


Generic Stack Component

fixes #44

[ ] Update readme file

I know it's a bit late in the sprint, but it would be super nice that the image we use in the readme could actually be pretty.

I can update it to look better tomorrow for the readme :) for this one I just took a screenshot of how it currently looks like in the styleguide slim file.


Update Japanese message catalogue for function node

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

This PR updates Japanese message catalogue of function node according to the latest fix on dev launch.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.02%) to 77.314% when pulling ca213589ac93e0f05c7760a8811fd9c5ab55a1ef on node-red-hitachi:update-function-message-jp into 82b3a97d9994f87bdf4e398ea8338c4c0c054a51 on node-red:dev.


Attribution for the R-Tree code

Hi @tidwall,
I've noticed that most of the R-tree code in this project is ported from https://github.com/mourner/rbush — would you be so kind as to include some kind of attribution for it?
Thank you!

Absolutely, and I just want to say that you do excellent work. Your RBush logic helped boost Tile38's overall performance by about 20%. Thanks a ton!
I added a note to the README and made sure the ported files match with your original notices. If this does not suffice, please let me know.

Fantastic, thank you! This is more than enough — a simple link in the source code would suffice. :) You can remove the cited licenses if you want.


fix: fix database connection in kubernetes cluster

:tada: This PR is included in version 3.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[WIP] Add support for contact tracking to MocoTrack

This is a first pass at adding contact tracking to MocoTrack, but I haven't gotten a problem to solve well yet.

This change is

This is ready for review once #594 is merged.

I just realized I did not finish updating the documentation in MocoTrack.h.


Document error @return of passedPrerequisitesForCourse(student, course)

* @return true if the student has any course score record that is passed (>=60 or PASS), which means he has passed the course.

The method should return true if the @param student pass all the courses in the prerequisite of @param course, rather than to check whether he has passed the course.

This has been fixed a long time ago, please pull the latest commit.

Fixed.


Support for Rider & Serilog JSON

Sadly, this doesn't appear to work out-of-the-box in Rider apps that use Serilog to output JSON logs,

@Twinki14 Thank you for reporting the issue!
There could be two cases why the plugin does not work:

Rider's console does not support the plugin.
The plugin does not work with Serilog's output for some reason.

To determine the cause, could you please check the debug log of the plugin by the steps in README?
It would be helpful if you could share the log that contains #io.github.orangain.prettyjsonlog.console here.

Sure, idea.log
Note, in Rider enabling the debug level was slightly different,
Help -> Diagnostic Tools -> Choose Trace Scenarios -> Advanced log settings

@Twinki14  Thank you for sharing the log. Unfortunately, it seems that Rider does not support the plugin. According to the log, the plugin works at build time, but not at run time.
While investigating the issue, I found a report of the Grep Console plugin not working with Rider ^1. That plugin uses the same extension points as the Pretty JSON Log plugin.
Currently, there does not seem to be no way to get the plugin to work with Rider until JetBrains provides extension points for Rider's console ^2.
Sorry for the inconvenience. Once again, thank you for trying the plugin and reporting the issue.

Happy to report that in the latest Rider version, 2024.2.3, it appears this plugin now formats the console correctly. however the console output looks like
[null] null: null
{
  "@i": "e8bfc543",
  "@m": "Using AWS credentials specified with the AWSOptions.Credentials property",
  "@t": "2024-09-04T17:11:26.7805905Z",
  "SourceContext": "AWSSDK"
}

Seems maybe an issue with supporting Serilog?

@Twinki14 That's a good news! I would add support for Serilog this weekend.
However, I could not reproduce the plugin working in my environment (Rider 2024.2.3, macOS 14.6.1, Trial License). Maybe some setting or condition changes the behavior.

@Twinki14 That's a good news! I would add support for Serilog this weekend.
However, I could not reproduce the plugin working in my environment (Rider 2024.2.3, macOS 14.6.1, Trial License). Maybe some setting or condition changes the behavior.

After digging deeper it looks like when debugging a project the debugger console is completely seperate than when running a project on it's own. The debugger console looks to be totally compatible with this plugin.
So, to recreate it, use a blank console project and debug it. It's also worth noting Serilog output is done in several different popular configurations.
https://github.com/serilog/serilog-formatting-compact is the most popular and has several different ways it outputs JSON logs

@Twinki14

After digging deeper it looks like when debugging a project the debugger console is completely seperate than when running a project on it's own. The debugger console looks to be totally compatible with this plugin.
So, to recreate it, use a blank console project and debug it.

Thank you for the clarification, but I couldn't make the plugin work even when debugging a project.
I’m not sure if this is what you meant, but it seems that when I started debugging the project, the Rider shows two different but similar tabs “Console” and “Debug Output”. The former tab does not support the plugin while the latter tab supports the plugin. However I don't know how to output logs into the “Debug Output” tab.

Even such a situation, I think I could add a support for the Serilog.

It's also worth noting Serilog output is done in several different popular configurations.
https://github.com/serilog/serilog-formatting-compact is the most popular and has several different ways it outputs JSON logs

Thank you for the information. According to the documentation, it seems that there are four patterns of JSON formats as follows:

JsonFormatter
CompactJsonFormatter
JsonFormatter(renderMessage: true)
RenderedCompactJsonFormatter

The message template is an interesting idea, but it needs some effort to support it. This is because it is not a simple substitutions but requires some calculations. Therefore, I would support the rendered version of the formatters, i.e. 3 and 4 for now, and I will leave 1 and 2 as future work.

@Twinki14 Now, new version 0.4.0 of the plugin that includes Serilog support has been released on the marketplace. Could you please try it? Thanks for the feedback!


Copy-paste error in readme

Hey, I just flew over your readme and it seems like there happened some sort of formatting or copy-past error in your readme. In the section about "Command line functions", it seems the text that follows is also somehow formatted as a headline and appears twice.

Hey, I just flew over your readme and it seems like there happened some sort of formatting or copy-past error in your readme. In the section about "Command line functions", it seems the text that follows is also somehow formatted as a headline and appears twice.

Thank you for your reminder! I have deleted the duplicate part.


supersid tk viewer spectrograph should use decimals instead of exponentials

Just another observation - using the tk viewer, the numbers in the lower right, showing the location of the cursor on the spectrograph are being shown in exponential notation.  In the previous version, Eric's, they were shown with six digits including decimals.

See the status bar bottom right. Is this what you intend to see?

(supersid) E:\work\Python-Samples\fenrog\supersid\supersid>git diff tksidviewer.py
diff --git a/supersid/tksidviewer.py b/supersid/tksidviewer.py
index 29332ae..53409d9 100644
--- a/supersid/tksidviewer.py
+++ b/supersid/tksidviewer.py
@@ -17,6 +17,14 @@ import tkinter.messagebox as MessageBox
 import tkinter.filedialog as FileDialog

+class Formatter(object):
+    def __init__(self):
+        pass
+    def __call__(self, x, y):
+        strength = pow(10, (y/10.0))
+        return "frequency=%.0f  " % x + " power=%.3f  " % y + " strength=%.0f" % strength
+
+
 class tkSidViewer():
     """Create the Tkinter GUI."""

@@ -75,7 +83,7 @@ class tkSidViewer():
         self.canvas._tkcanvas.pack(side=tk.TOP, fill=tk.BOTH, expand=1)

         self.axes = self.psd_figure.add_subplot(111)
-        # self.axes.hold(False)
+        self.axes.format_coord = Formatter()

         # StatusBar
         self.statusbar_txt = tk.StringVar()

What's the "strength" value about?  Was that there before?

Don't ask me about the physical meaning of strength. It was there on the wx viewer from where I copied both: formula and formatting.

Strength seems useless. It is just converting the logarithm decibels to a linear value (maybe voltage?). I think we should get rid of it. Will open a new issue for that.


Create a hyperlink to the Dart SDK issue tracker

Will land via https://dart-review.googlesource.com/c/sdk/+/218882


Search (Ctrl+Shif+F) does not support lookaheads

Issue Type: Bug
description:
VSCode does not support lookaheads when searching through the workspace files (Ctrl+Shift+F). Normal search (Ctrl+F) does support lookaheads.
Steps to reproduce:

Press Ctrl+Shift+F
Enter foo(?=bar) (for a positive lookahead) or foo(?!bar) (for a negative lookahead)
Notice the error Error parsing regex near foo(?=bar)` at character offset 5: Unrecognized flag: '='. (Allowed flags: i, m, s, U, u, x.)

Installation summary:
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T00:24:49.616Z)
OS version: Linux x64 4.13.0-38-generic

System Info

Item
Value

CPUs
Intel(R) Celeron(R) CPU G550 @ 2.60GHz (2 x 1829)

Load (avg)
1, 1, 1

Memory (System)
7.77GB (0.31GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

EditorConfig
Edi
0.12.1

vscode-docker
Pet
0.0.26

vscode-eslint
dba
1.4.8

dotenv
mik
1.0.1

vscode-yaml
red
0.0.11

(1 theme extensions excluded)

This isn't supported right now because the search tool we use, ripgrep, doesn't support these regex features.

@roblourens Would you reopen this issue as a feature request?


Docker compose config updates

This

doesn't restart the services while developing
disabled the basic auth check while developing
adds a .env.example file

If you create a .env file with a COMPOSE_FILE value you can just type docker-compose some-command without having to list the compose files each time.

Can we merge this? Any blockers?


seaweedfs container crashing

Describe the bug
Seaweedsfs K8s POD logs show the below error and repeatedly crashing. The POD was up and working fine and recently was in a terminated state, while K8s was unable to bring up a new POD as it was repeatedly crashing.
I0316 13:11:46.487625 master.go:268 current: <IP_ADDRESS>:9333 peers:
I0316 13:11:46.555070 file_util.go:23 Folder /data/store1 Permission: -rwxr-xr-x
I0316 13:11:46.555263 master.go:268 current: <IP_ADDRESS>:9333 peers:<IP_ADDRESS>:9333
I0316 13:11:46.555264 file_util.go:23 Folder /data/store1 Permission: -rwxr-xr-x
I0316 13:11:46.555429 master_server.go:127 Volume Size Limit is 30000 MB
I0316 13:11:46.555808 master.go:149 Start Seaweed Master 30GB 3.43 673214574 at <IP_ADDRESS>:9333
I0316 13:11:46.558281 raft_server.go:119 Starting RaftServer with <IP_ADDRESS>:9333
I0316 13:11:46.558790 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:46.687449 raft_server.go:168 current cluster leader:
I0316 13:11:48.350425 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:48.556484 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:49.557531 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:50.141583 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:50.558666 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:51.560387 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:51.933040 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:52.561638 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:53.562483 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:53.723858 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:54.563136 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:55.515519 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:55.563945 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:56.565410 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:57.306594 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:57.566608 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:58.568196 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:11:59.097521 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:11:59.569348 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:00.570857 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:00.888891 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:12:01.572144 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:02.573810 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:02.679850 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:12:03.574399 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:04.471459 volume_grpc_client_to_master.go:43 checkWithMaster <IP_ADDRESS>:9333: get master <IP_ADDRESS>:9333 configuration: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:19333: connect: connection refused"
I0316 13:12:04.576196 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:04.689286 master_server.go:215 [<IP_ADDRESS>:9333]  - is the leader.
W0316 13:12:04.689713 tls.go:39 pemfile.NewProvider({   5h0m0s}) grpc.master failed: pemfile: at least one credential file needs to be specified
I0316 13:12:04.815564 master.go:200 Start Seaweed Master 30GB 3.43 673214574 grpc server at <IP_ADDRESS>:19333
I0316 13:12:05.577973 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:06.315984 masterclient.go:155 No existing leader found!
I0316 13:12:06.316035 raft_server.go:190 Initializing new cluster
I0316 13:12:06.316104 master_server.go:174 leader change event:  => <IP_ADDRESS>:9333
I0316 13:12:06.316118 master_server.go:177 [<IP_ADDRESS>:9333] <IP_ADDRESS>:9333 becomes leader.
I0316 13:12:06.579545 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
I0316 13:12:07.581096 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
W0316 13:12:08.563280 filer_server.go:142 skipping default store dir in /data/store1/filerldb2
I0316 13:12:08.563666 leveldb2_store.go:42 filer store leveldb2 dir: /data/filerldb2
I0316 13:12:08.563684 file_util.go:23 Folder /data/filerldb2 Permission: -rwxr-xr-x
I0316 13:12:08.564056 master_grpc_server.go:349 + client .filer@<IP_ADDRESS>:8888
E0316 13:12:08.576145 leveldb2_store.go:62 filer store open dir /data/filerldb2/00: resource temporarily unavailable
I0316 13:12:08.582343 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
F0316 13:12:08.662698 configuration.go:25 failed to initialize store for leveldb2: resource temporarily unavailable
goroutine 135 [running]:
github.com/seaweedfs/seaweedfs/weed/glog.stacks(0x0)
/go/src/github.com/seaweedfs/seaweedfs/weed/glog/glog.go:768 +0x89
github.com/seaweedfs/seaweedfs/weed/glog.(*loggingT).output(0x3bde300, 0x3, 0xc0002300e0, {0x2f3f5f8?, 0xc0004fb9b8?}, 0x2?, 0x0)
/go/src/github.com/seaweedfs/seaweedfs/weed/glog/glog.go:719 +0x3aa
github.com/seaweedfs/seaweedfs/weed/glog.(*loggingT).printf(0x23c3bb1?, 0x8?, {0x24192bd, 0x26}, {0xc0004fb9b8, 0x2, 0x2})
/go/src/github.com/seaweedfs/seaweedfs/weed/glog/glog.go:657 +0x10f
github.com/seaweedfs/seaweedfs/weed/glog.Fatalf(...)
/go/src/github.com/seaweedfs/seaweedfs/weed/glog/glog.go:1154
github.com/seaweedfs/seaweedfs/weed/filer.(*Filer).LoadConfiguration(0xc00047a500, 0x3bd87d0)
/go/src/github.com/seaweedfs/seaweedfs/weed/filer/configuration.go:25 +0x2fb
github.com/seaweedfs/seaweedfs/weed/server.NewFilerServer(0xc0001be140, 0xc0001be140, 0xc0001b29c0)
/go/src/github.com/seaweedfs/seaweedfs/weed/server/filer_server.go:152 +0x97f
github.com/seaweedfs/seaweedfs/weed/command.(*FilerOptions).startFiler(0x3bde7e0)
/go/src/github.com/seaweedfs/seaweedfs/weed/command/filer.go:228 +0x351
github.com/seaweedfs/seaweedfs/weed/command.runServer.func1()
/go/src/github.com/seaweedfs/seaweedfs/weed/command/server.go:258 +0x2a
created by github.com/seaweedfs/seaweedfs/weed/command.runServer
/go/src/github.com/seaweedfs/seaweedfs/weed/command/server.go:256 +0xd94
System Setup

Seaweedfs POD is running in AIO
Command : ["-logdir", "/data/logs", "server", "-dir", "/data/store1", "-volume.max=200", "-s3", "-s3.config", "/data/config/config.json"]

Can you provide a few more details like verion of k8s, version of seaweedfs, how it was deployed?
What pod are you launching, master, volume, filer, s3?
Might help to share your deployment yaml or helm config.
This is the only interesting thing I see:
E0316 13:12:08.576145 leveldb2_store.go:62 filer store open dir /data/filerldb2/00: resource temporarily unavailable
I0316 13:12:08.582343 s3.go:177 wait to connect to filer <IP_ADDRESS>:8888 grpc address <IP_ADDRESS>:18888
F0316 13:12:08.662698 configuration.go:25 failed to initialize store for leveldb2: resource temporarily unavailable
goroutine 135 [running]:

Could be an issue with whatever you are using to host the /data/ files.


Global planner node-9 process died

When I use the global planner, I often meet a problem as following:

[global_planner_node-9] process has died [pid 5793, exit code -11, cmd /home/nb/avoidance_ws/devel/lib/global_planner/global_planner_node __name:=global_planner_node __log:=/home/nb/.ros/log/42cfa022-9983-11e9-ac6e-0242b966eb14/global_planner_node-9.log].
log file: /home/nb/.ros/log/42cfa022-9983-11e9-ac6e-0242b966eb14/global_planner_node-9*.log

The launch file is default, and the environment is Gazebo simulation.
Some parameters we set as "robot radius = 0.5", "resolution = 1.0", "cell scale = 1.0".
And another question is how should I set above parameters, and could tell me the meaning of "cell scale"?
Waiting for response, thanks.

@Jaeyoung-Lim it's a know issue. We are trying to figure it out. If you have any insights, they're the most welcomed.

@Jaeyoung-Lim it's a know issue. We are trying to figure it out. If you have any insights, they're the most welcomed.

Until now, we have tried to adjust these three parameters, we found that the frequency of "process died" is different(when we set "robot radius = 0.5", "resolution = 1.0 or 0.5", "cell scale = 1.0", the number of died is smaller than other condition), and this "died" frequency may also related positively to distance between current position("s" in code) and goal("t" in code).
We think that the problem may happen in data format because this global planner algorithm uses octomap and cell to represent discrete space and the drone.
Another is that during the path planning process, there are a mount of octomap grid information has been recorded, will it cause a problem such as memory crash?
Thanks so much for your response!

FYI @Jaeyoung-Lim

@JoeyLeeNPU Have you been able to catch the segfault in a debugger so we can get a line number? Maybe using GDB or Valgrind? I tried to catch the segfault but it wouldn't happen when I ran in the debugger.

I meet this problem when I run the global planner and this problem shows in the terminal. I copy the whole error message in my first description. And I don’t use other debugger. So how should I do next?
| |
李卓一 NPU
|
|
<EMAIL_ADDRESS>npulzy
|
签名由 网易邮箱大师 定制
On 07/01/2019 23:11, Julian Kent wrote:
@JoeyLeeNPU Have you been able to catch the segfault in a debugger so we can get a line number? Maybe using GDB or Valgrind? I tried to catch the segfault but it wouldn't happen when I ran in the debugger.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

If you install valgrind and add launch-prefix="valgrind" to the global planner node then it should run in valgrind.
It is better explained here:
http://wiki.ros.org/roslaunch/Tutorials/Roslaunch Nodes in Valgrind or GDB
Then if it crashes it will show the exact line number where the crash happened. Note that the execution is much slower though.

I will try it now. And I want to konw if you met this error in gazebo when run global planner?
| |
李卓一 NPU
|
|
<EMAIL_ADDRESS>npulzy
|
签名由 网易邮箱大师 定制
On 07/01/2019 23:21, Julian Kent wrote:
If you install valgrind and add launch-prefix="valgrind" to the global planner node then it should run in valgrind.
It is better explained here:
http://wiki.ros.org/roslaunch/Tutorials/Roslaunch Nodes in Valgrind or GDB
Then if it crashes it will show the exact line number where the crash happened. Note that the execution is much slower though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Yes, I saw it when using Global Planner with RViz for vizualization and Gazebo headless. However when I tried to use valgrind I couldn't get the problem to reproduce.

I see... and when I test this pkg on my drone, it also crashes same as gazebo, the flight will be influenced. Do u have some suggestions? Thanks very very much.
| |
李卓一 NPU
|
|
<EMAIL_ADDRESS>npulzy
|
签名由 网易邮箱大师 定制
On 07/01/2019 23:30, Julian Kent wrote:
Yes, I saw it when using Global Planner with RViz for vizualization and Gazebo headless. However when I tried to use valgrind I couldn't get the problem to reproduce.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Another option would be to enable Thread Sanitizer and Address Sanitizer in the compiler. Then when the crash happens hopefully we get a stack trace.

Okay, I will try as you said. If I have some thoughts I will reply you quickly. And if you fix this bug, I will update my package in time.
Thanks again.
| |
李卓一 NPU
|
|
<EMAIL_ADDRESS>npulzy
|
签名由 网易邮箱大师 定制
On 07/01/2019 23:37, Julian Kent wrote:
Another option would be to enable Thread Sanitizer and Address Sanitizer in the compiler. Then when the crash happens hopefully we get a stack trace.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

In these days, I have a try on debug this problem both in gazebo and on my real drone, but sorry to say that I have not solve it.
I guess that the problem comes from the memory management module when the "global_planner_node" is running because the error number is "-11".
If any "while" function or any "callback" function may have a memory problem, such as too many data has pushed into stack waiting to process?
I think use two threads to process data like "local_plnanner" would be better.
I added the yaw control based on your way-point position control law because there are too many constrains in slam-based flight.

This is fixed in #441

Very very thanks to you all! I will update my package and try it on my drone.
And I see there is a "to do" in yaw control, we have written a yaw control law in order to steer slam-based drone.
The strategy is that if the angle between the reference and the current is too large, I will order the drone turn first until the desired position appears in FOV, then drone flies to the target position with adjusting heading to the reference yaw.
Thanks to U all again ! hah~


installation pb

I am very interested in your project but I have problems with the installation.
The jlpm command give me:
node_modules/@jupyter-widgets/base/lib/widget.d.ts:55:5 - error TS2416: Property 'initialize' in type 'WidgetModel' is not assignable to the same property in base type 'Model<any, ModelSetOptions, {}>'.
  Type '(attributes: any, options: { model_id: string; comm?: any; widget_manager: any; }) => void' is not assignable to type '(attributes?: any, options?: ModelConstructorOptions<this>) => void'.
    Types of parameters 'options' and 'options' are incompatible.
      Type 'ModelConstructorOptions<this>' is missing the following properties from type '{ model_id: string; comm?: any; widget_manager: any; }': model_id, widget_manager

55     initialize(attributes: any, options: {
       ~~~~~~~~~~

node_modules/@jupyter-widgets/base/lib/widget.d.ts:199:52 - error TS2344: Type 'WidgetModel' does not satisfy the constraint 'Model<any, ModelSetOptions, {}>'.
  Types of property 'initialize' are incompatible.
    Type '(attributes: any, options: { model_id: string; comm?: any; widget_manager: any; }) => void' is not assignable to type '(attributes?: any, options?: ModelConstructorOptions<Model<any, ModelSetOptions, {}>>) => void'.
      Types of parameters 'options' and 'options' are incompatible.
        Type 'ModelConstructorOptions<Model<any, ModelSetOptions, {}>>' is missing the following properties from type '{ model_id: string; comm?: any; widget_manager: any; }': model_id, widget_manager

199 export declare class WidgetView extends NativeView<WidgetModel> {
                                                       ~~~~~~~~~~~

node_modules/@jupyter-widgets/base/lib/widget.d.ts:203:48 - error TS2344: Type 'WidgetModel' does not satisfy the constraint 'Model<any, ModelSetOptions, {}>'.

203     constructor(options?: Backbone.ViewOptions<WidgetModel> & {
                                                   ~~~~~~~~~~~

node_modules/@jupyter-widgets/base/lib/widget.d.ts:243:102 - error TS2344: Type 'T' does not satisfy the constraint 'Model<any, ModelSetOptions, {}>'.
  Type 'WidgetModel' is not assignable to type 'Model<any, ModelSetOptions, {}>'.
    Types of property 'initialize' are incompatible.
      Type '(attributes: any, options: { model_id: string; comm?: any; widget_manager: any; }) => void' is not assignable to type '(attributes?: any, options?: ModelConstructorOptions<Model<any, ModelSetOptions, {}>>) => void'.
        Types of parameters 'options' and 'options' are incompatible.
          Type 'ModelConstructorOptions<Model<any, ModelSetOptions, {}>>' is not assignable to type '{ model_id: string; comm?: any; widget_manager: any; }'.

243     interface InitializeParameters<T extends WidgetModel = WidgetModel> extends Backbone.ViewOptions<T> {
                                                                                ~

Found 4 errors.

I am on jupyterlab 2.2.6
Regards

Thanks for your response.
<EMAIL_ADDRESS>For jupyterlab/jupyter I don't understand.
npm list |grep "jupyterlab/jup" doesnt show anything.

Did you ever figure out what caused this?
On Fri, Sep 4, 2020 at 3:23 AM Djangoliv<EMAIL_ADDRESS>wrote:

Thanks for your response.
<EMAIL_ADDRESS>For jupyterlab/jupyter I don't understand.
npm list |grep "jupyterlab/jup" doesnt show anything.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/data-exp-lab/jupyterlab_twitch/issues/12#issuecomment-687003852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVXOZ6TJU6II4PGUD3HJDSECPYZANCNFSM4QU3ULIA
.

No,
I tried again with an installation from scratch and in the console I have this:
Plugin '@data-exp-lab/jupyterlab-twitch:plugin' failed to activate.
TypeError: n.registerWidget is not a function
activate player.js:21
promise index.es6.js:157

OK, thanks.  I'll dig into this ASAP.
On Tue, Sep 15, 2020 at 2:41 AM Djangoliv<EMAIL_ADDRESS>wrote:

No,
I tried again with an installation from scratch and in the console I have
this:
Plugin '@data-exp-lab/jupyterlab-twitch:plugin' failed to activate.
TypeError: n.registerWidget is not a function
activate player.js:21
promise index.es6.js:157
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/data-exp-lab/jupyterlab_twitch/issues/12#issuecomment-692530266,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVXO2ULSFJOJPMAG2IQ4DSF4LEDANCNFSM4QU3ULIA
.

This is so strange to me!  I am going to try to build from scratch here.

I installed the extension successfully! Thank you for your work.
You can close this issue.

Awesome!  I am sorry I didn't get back to you with more ideas, but happy it
works!
On Fri, Dec 4, 2020 at 9:42 AM Djangoliv<EMAIL_ADDRESS>wrote:

I installed the extension successfully! Thank you for your work.
You can close this issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/data-exp-lab/jupyterlab_twitch/issues/12#issuecomment-738854429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVXOYQDZMFSTRPXKQ7BI3STD7PTANCNFSM4QU3ULIA
.


Fixed issue where data elements could not be saved in ID sync container ID field

Description

Where the extension.json previously only allowed number in the ID sync container ID field, with this change, it allows either a number or a string that matches the regex ^([^%\n]*%[^%\n]+%)+[^%\n]*$ for data elements.
Related Issue

PLATIR-30215
Motivation and Context

Our automated tests do not test the extension.json, so it slipped through the cracks.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[x] I have made any necessary test changes and all tests pass.
[x] I have run the Sandbox successfully.
[x] I've updated the schema in extension.json or no changes are necessary.
[ ] My change requires a change to the documentation.

I've created PDCL-10847 to run the validation from extension.json in our functional tests, which would have caught this issue.

You could just set it to a string. I don't know what value this regex adds.

That's fair. Excess validation has burned me a lot recently, specifically with this field.

Do we need to do a parseInt call in the runtime so that it is passed as an integer into experience edge?

We do that before saving the settings into Tags.

@jonsnyder said

If the customer wants to use a data element for the containerId, it will be saved as a string in the settings. When the tags library is run, Tags will resolve the data element and the containerId will be a string containing an integer.

I just pushed a fix that looks if the ID sync container ID is a string at runtime and runs parseInt() on it, if it is.

why we return undefined at line 35?
// there are no settings for this current env, but there are settings for others
    if (
      edgeConfigOverrides.development ||
      edgeConfigOverrides.staging ||
      edgeConfigOverrides.production
    ) {
      return undefined;
    }

We are returning undefined because there are no overrides for the current environment. It is return undefined instead of return because there is an eslint rule where functions that return values should always return a value.


Update 'aes-gcm', 'hmac', 'hkdf', 'sha2'

This release uses the new aead v0.3 crate which makes the following changes to the API:

NewAead now borrows the key, preventing needless copies
Aead and AeadInPlace traits have been split. It appears you're using both, so this pulls them both in.

Note that these crates now depend on generic-array v0.14 which has an MSRV of 1.41+.

Note: we're planning a similar update to the digest crate soon (i.e. later this week) as well as the sha2 crate which will also bump generic-array up to v0.14 there. Just a heads up that if you merge this without that change, you'll be depending on two different versions of generic-array.

This is awesome, @tarcieri! Thank you! I'm hoping https://github.com/fizyk20/generic-array/pull/102 is merged before moving ahead.

Ooh, neat PR to generic-array. Good to know!

Looks like generic-array v0.14.2 is out with your PR included?

Awesome. Merged in f7f6e741521c866bf9b6c290b4389425b5c952e7! Thank you!


Update URLs in Contributing section of README

This fixes links in the README.

Dangit. I can't merge!
I'm not really planning on contributing to this repo that much so you can go ahead and merge it if you'd like @fugufish. That way I won't have to be added to the list of authorized users to merge protected branches.


Bezier-rs: Add bounding box, extrema and inflection functions for subpath

Added bounding_box, local_extrema and inflections functions for the subpath class in bezier-rs.
Note, the current functions do not consider the points in between two bezier curves. We may want to consider these points for local extrema and inflection.

Besides my comments, this also needs to have its conflicts resolved. Thanks.

After this is rebased, I can review it one last time and probably merge this time around.


onMatch throws errors when null

If onMatch is null, it's attempted to be called anyway.

Will work it out in the next version, Thank you! :smile:

Will work it out in the next version, Thank you! :smile:

Already worked it out in the new version, Thanks!

Already worked it out in the new version, Thanks!


209 - Adds 401 status for un authorized

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Hi @joshfischer1108 ,
Created this PR for issue 209.
Let me know If any changes needed.

Header -  Accept = json

Header -  Accept = other than json

Thank you for this @sivasuriyankumarasamy!   I will have some time to look at this tomorrow.

Hi @sivasuriyankumarasamy . I think it would be better to put a custom filter to be first in the filter chain.  Something like this.
public class ExceptionHandlerFilter extends OncePerRequestFilter {

    @Override
    public void doFilterInternal(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws ServletException, IOException {
        try {
            filterChain.doFilter(request, response);
        } catch (RuntimeException e) {

            // custom error response class used across my project
            ErrorResponse errorResponse = new ErrorResponse(e);

            response.setStatus(HttpStatus.INTERNAL_SERVER_ERROR.value());
            response.getWriter().write(convertObjectToJson(errorResponse));
    }
}

    public String convertObjectToJson(Object object) throws JsonProcessingException {
        if (object == null) {
            return null;
        }
        ObjectMapper mapper = new ObjectMapper();
        return mapper.writeValueAsString(object);
    }
}

What do you think?
Also, the build is broken.

Hi @joshfischer1108,
Made the changes.
Please let me know If anything.

Thanks for this @sivasuriyankumarasamy !  I'll have some time to test this out tomorrow.

Hi @joshfischer1108 ,
Test case added for exception filter.

Well done, @sivasuriyankumarasamy .  Thank you.


peakshape function is missing

while trying to reproduce the published work with the example data in PAVE2.0, the pave_de_lowC gave the error (unrecognized function or variable peakshape). Is something missing from the github version? Thanks a lot and Best, Alaa

Thanks for pointing this out. I've uploaded the missing function 'peakshape.m' . Please let me know if there's other issues.


Is there any plan of security guarantee, such as https support,  sensitive data encryption, params check and so on.

Is there any plan of security guarantee, such as https support,  sensitive data encryption, params checking and so on.

@prolen Thanks for your great question. Currently we do have supported https scheme and params check in api-server. For the rest part you mentioned, it would be all included in our future plan. If you are interested, any contribution is welcomed.

Already resolved by #592  #598 #611


Add spec tests

Add tests to check we are matching the w3c.

Closing this long running branch for now. Additional work can be done in smaller PR's.


Spacing Not Working for Ordered List

I'm trying the spacing utility for this ordered list. I will use all -n3 for this test case. It works for every other resolution except for the ml-sm-n3 class. It only works for sm resolution if I use ml-n3 instead of ml-sm-n3 class.
Here's the code;

<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />

Spacing utility

   ↓

Item

Item 2

Preview;

I'm using;
Bootstrap: Version 4.4.1
Operating system: Microsoft Windows 10 Version 2004 (OS Build 19041.508) (64-bit)
Browser: Microsoft Edge Version 85.0.564.51 (64-bit)
What am I doing wrong here?

That appears to be an iPhone SE (1st generation) or iPhone 4 style device (power button on top), which has a horizontal width of 320px (640px with a 2× device pixel ratio).
The sm breakpoint is at 576px: https://getbootstrap.com/docs/4.5/layout/grid/#grid-options

That appears to be an iPhone SE (1st generation) or iPhone 4 style device (power button on top), which has a horizontal width of 320px (640px with a 2× device pixel ratio).
The sm breakpoint is at 576px: https://getbootstrap.com/docs/4.5/layout/grid/#grid-options
Thank you. Anyway, in Web Browser > Inspect, there are devices from Moto G4 to iPhone X. Which Bootstrap resolution class can I use to cover those type of devices?

.ml-n3 would work.
There's no need for all of the other breakpoints since each class applies to all breakpoints above:

Is the same as:

It only works for sm resolution if I use ml-n3 instead of ml-sm-n3 class.

That's by design. See the above comments for more information on this as well. Beyond that, you're using negative margin to override the default padding-left on
s when you could change the padding instead.

.ml-n3 would work.
There's no need for all of the other breakpoints since each class applies to all breakpoints above:

That's by design. See the above comments for more information on this as well. Beyond that, you're using negative margin to override the default padding-left on
s when you could change the padding instead.

Thank you very much for these clarifications.


feat(cli): Add tutorial on how to run agent

copilot:all

Current dependencies on/for this PR:

main

PR #3732   👈

This comment was auto-generated by Graphite.


[electron] Adds v31 (Check on June 12)

Timelines as per https://www.electronjs.org/docs/latest/tutorial/electron-timelines
Since upstream declares EOL for current releases, we can drop the approximate note.
The "4 releases temporarily supported" policy
is no longer applicable, so we can drop that as well.
Marking as draft, can check back around June.

@captn3m0 get ready :) beta5 is released 5 hours ago

@captn3m0 we need to add node and chromium version info