Update README.md

maybe use https://www.grammarly.com/browser/chrome to check typos?
I've addressed the image ratio too.

@raymondlo84 thank you for a PR! I see nothing critical here and for typos we have a spell_check job and browser extensions are quite heavy. Glad that you had time to check this.
Thank you for your contribution!


Added in Azure Files as supported

To Data Box Disks, as it is supported but not all of the features of Azure Files are supported.
Thought the docs were a little misleading for those who just need to copy files with no LFS or without fill file metadata
see the table at the bottom of here - https://learn.microsoft.com/en-us/azure/storage/files/storage-files-migration-overview#file-copy-tools

@microsoft-github-policy-service agree

@stevenmatthew
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Investigate Kotzebue Sound HUC

HUC 19050500 seems to be entirely/mostly over water but is getting a valid data return -- can this be checked out at a lower level in the data to ensure that it's really providing valid results?

@charparr can you take a look at this one?  It seems like there are some valid data here, even though it's weird that it's almost entirely over water.  If there's real data, then this should stay in place.

This is a real HUC...but I think I'm learning why "hydrologic unit" and "watershed" are not synonymous. This is a sound that has land on three sides and really not a watershed. The polygon is real and "official" but useless from a "help me summarize the data with a cookie cutter" perspective. I'm going to ticket the geo repo for dropping this polygon.

Kotzebue Sound HUC is no longer available via the list of places in the API.


Mistaking string for hex.

A module in restringer attempts to convert/map "-example" from an example array of ['foo', '-example'] into a hex, resulting in NaN.

Great catch! I'm on it :D


added  sql schema file with the name sqlschema.sql

@akhil111  good job, but there are two things to be remembered

We shouldn't store the confirmed password in the database since it is not a necessity, so you can remove the confirm password.
Add one more field to this called active so it must look like

ALTER TABLE `formt` ADD active VARCHAR(255) NOT NULL AFTER `passwd`


feat: configure tempo

:tada: This PR is included in version 0.2.0-alpha.12 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Restoring debug view on startup is not smooth

I started VSCode out of sources via command line. Check out how many transitions the debug view goes through until ready:

I see:

"Run" without twistie
"Run" with twistie
Title without "Run"
"Run" moves to Title
Other views appear

@isidorn I see you have set when context for all debug views CONTEXT_DEBUG_UX. Because of this debug views are getting enabled at different timings. From the infrastructure side, we are trying to cache previous views count and trying to to merge/not merge the title on reload. But once extensions are loaded we revalidate and update view to merge/not merge.
I think the root cause here is that Run (welcome) view is appearing for a short moment. So, I would recommend to cache the CONTEXT_DEBUG_UX state (at workspace scope) and set it before registering the views and revalidate the state later when you know the truth.

@sandy081 @isidorn seeing something similar also in the explorer, check how the twistie only appears later:
https://user-images.githubusercontent.com/900690/106712642-88201c80-65f9-11eb-879c-49cec53961e6.mov
I am feel this was not the case before.

@bpasero twisties is a different issue - I suspect this is because of codicons taking time to load. If I remember I noticed similar behaviour on activity bar too, if you have codicons and svgs - codicons are loaded later than svgs. I would recommend to file a separate issue for this.

@sandy081 your suggestion makes sense and I have implemented it. With it I see reduced flashing. I still see the twisties appearing late, but there is a different issue for that
@bpasero let me know if this is now also better for you - it should be.

Yeah looks better, I also only see the twisties.

Adding VERIFIED label based on happy users comment :D


Suggestions are not shown in VSCode

I executed the command. sfcc-dts-setup from the root directory from my sfcc project and the tsconfig.json file has been generated with all the compilerOptions but I still do not see any suggestion when for example I try to get the suggestions from require('dw/system/Site').  I also enabled  the "TypeScript: Select TypeScript version but without success.

This is a really old issue, but for anyone still having trouble with it. I was able to solve it by transforming the generated tsconfig file into a jsconfig file.


fix: head is not set correctly when using keepalive in router-view

head is not set correctly when using keepalive in router-view.
I initially tried to solve this problem in PR #92, unfortunately, I found out the problem was not fixed when I actually used it in the project after the new version was released. This PR is trying to solve this bug that was not successfully fixed last time.
I rethink on why it didn't work as expected:

The unit test I wrote before was too concise to accurately simulate the actual situation of this bug, so this time I rewrote the unit test closer to the actual situation.
I didn't try to test whether my modified version worked properly in the minimum reproduction. This time I created a minimum reproduction to test my modified version.

Minimum reproduction setup based on the Vitesse template

This error is reproduced by trying to switch routes after starting the project and observing the change in the site title.

debug-vueuse-head-keepalive.zip

Thanks for the update and continued effort @LittleSound!
lgtm


[web]: Fidelity with animated transform

See https://timsneath.github.io/flutter_flip_view/#/
Gradient doesn't rotate cleanly with transform.
Source at https://github.com/timsneath/flutter_flip_view/tree/master/example

Fixed via https://github.com/flutter/flutter_web/commit/50f7fcfce93ecf557f86b3a345c9c460299ef5e5


Implement elastic combined range operators

While not part of the original Apache Lucene spec, elastic allows for some clever greater than and less than operations. Examples are:
age:>10
age:>=10
age:<10
age:<=10

These are now implemented thanks to @bigpigeon but elastic also allows you to specify range operators using a similar syntax like so:
age:(>=10 AND <20)
age:(+>=10 +<20)

This library should support this other syntax as well.

I'll be late


Initial BoxedJob implementation

WIP implementation of a BoxedJob CRD and controller

Left some comments.

Left some comments.

Great! I added some clarifications.


openapi_3 to 2: Convert deprecated to x-deprecated

Although both OpenAPI 3 and 2 support the deprecated property on Operation objects, only OpenAPI 3 supports deprecated on Schema objects. Convert to x-deprecated for OpenAPI 2, which is supported by Autorest (and possibly others).  Don't overwrite any existing x-deprecated property, which may contain additional deprecation information.
Thanks for considering,
Kevin

Thanks for the contribution!

Thank you for reviewing and merging it!


TVOC and NOx not showing up

Describe The Bug:

The TVOC(Ind40) and NOx values are not available in Controller or Eve apps. Temperature, humidity, CO2 and the different PMs are showing just fine.
To Reproduce:
Just install the plugin and make it available in HomeKit

Expected behavior:

I am not expecting these values to be part of HomeKit air quality, nor I am expecting to see them in the Apple Home app. However, I would like to see them in Controller or Eve apps and be able to create automations with them.
Logs:
2024-08-25 09:18:54Airgradient BridgeLoaded plugin 'homebridge-airgradient'
2024-08-25 09:18:54Airgradient BridgeLoading 2 platforms...
2024-08-25 09:18:54Airgradient BridgeAirGradientPlatformDid finish launching
2024-08-25 09:18:55Airgradient BridgeBridge is running on port 51836.
Plugin Config:
{
"platform": "ExampleHomebridgePlugin",
"name": "Airgradient"
}
Screenshots:

Environment:

Plugin Version:1.0.4
Homebridge Version: 4.3.1
Node.js Version: 16.20.2
NPM Version:
Operating System:  Hoobs box

Can you add a screenshot from the Eve app? I am able to see both TVOC and NOx values.

Not sure what is going on. I checked my Airgradient devices in HomeKit and they were gone. In the Eve app, when I look at the Airgradient bridge, there is no device for that bridge. I have tried removing the bridge in both HomeKit and Hoobs then reinstall everything, still no device in HomeKit. It might be a server problem, I had issues this week. I had a plug-in that was spamming the log and fill up the storage faster than the system was purging it, so everything became sluggish. I manage to stop it and remove it. The system eventually partly recover and went from sluggish to slow. I am waiting on my Hoobs pro to rebuild the server. Until then, I am sorry but I won't be able to help.
You can close the bug report, I will retest it in a few months once I received the Hoobs pro.
Le 3 sept. 2024 à 10:08, Will Smith @.***> a écrit :

Can you add a screenshot from the Eve app? I am able to see both TVOC and NOx values.
3C39D48A-01B1-490B-8F57-60FB517A2A54.png (view on web)https://github.com/user-attachments/assets/175ea4c2-1509-49e5-84bc-d043e41541d2
—
Reply to this email directly, view it on GitHubhttps://github.com/Smith8154/homebridge-airgradient/issues/3#issuecomment-2326624747, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAUAH5TVPCFYS74BK5PKMULZUW7GZAVCNFSM6AAAAABNCS55TSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRWGYZDINZUG4.
You are receiving this because you authored the thread.Message ID: @.***>

Closing per request.


Updating workflows to support new Dependabot permissions

Description
Updated the testing and auto-approval workflows to be able to pass for Dependabot and fork pull requests.

Motivation and Context

Dependabot PRs are now treated as coming from a fork (see this blog post). This was causing an issue in the testing and auto-approval workflows since they assumed they were getting a read-write GITHUB_TOKEN.
How Has This Been Tested?

Will be tested by seeing if checks on the current set of Dependabot PRs are passing
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] ~My change requires a change to the documentation.~
[ ] ~I have updated the documentation accordingly.~
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

I misunderstood what changed. I need to read more fully through this post to work out the correct thing to do now


Try to remove any dependency on std library from sputnik

If possible, remove any use of std inside sputnik.
Alternatives: NEAR's own libraries or implementing a different logic in all the places that use std.

Do you plan to replace HashMap with LookupMap/UnorderedMap? If so, do you have any recommendations on how? Same question about std::cmp::min

Yes, this is the plan, depending on the situations. If you we are very intensive with the reads and no need to iterate through the HashMap, then we definitely go with LookupMap. If you need any kind of iterations/getting all the elements -> UnorderedMap.
std::cmp::min not sure about this one, but near must have something similar. If not, we can implement our own method, sounds pretty trivial.

So that means we will have to implement custom Serialization in order to replace all the HashMaps,

I hear you. I assume you're talking about serde serialization, since borsh is already supported.
I would avoid to implement our own serialization since that's pretty overkill and it's something that should be available by default in the near sdk.
I would be curious to hear from near why they don't support serde on UnorderedMap. On LookupMap it's pretty obvious since there is not way for getting all the key/value pairs, but on UnorderedMap should be supported.
A simple
#[derive(Serialize, Deserialize)] on their UnorderedMap definition should solve this and then we can replace HashMap with UnorderedMap

Hi @ctindogaru,
Sometimes you may see compile-time errors that tell you:

the trait `serde::ser::Serialize` is not implemented for `...`
even though the struct or enum clearly has #[derive(Serialize)] on it.

This almost always means that you are using libraries that depend on incompatible versions of Serde. You may be depending on serde 1.0 in your Cargo.toml but using some other library that depends on serde 0.9. So the Serialize trait from serde 1.0 may be implemented, but the library expects an implementation of the Serialize trait from serde 0.9. From the Rust compiler's perspective these are totally different traits.

The fix is to upgrade or downgrade libraries as appropriate until the Serde versions match. The cargo tree -d command is helpful for finding all the places that duplicate dependencies are being pulled in.

We get the serde version indirectly from the near-sdk, so we shouldn't run into the issue where the versions don't match.

Can we raplace std::cmp::min with and algoritam.:
// C++ program of above implementation
#include<iostream>
using namespace std;

// Pair struct is used to return
// two values from getMinMax()
struct Pair
{
	int min;
	int max;
};

Pair getMinMax(int arr[], int n)
{
	struct Pair minmax;
	int i;

	// If there is only one element
	// then return it as min and max both
	if (n == 1)
	{
		minmax.max = arr[0];
		minmax.min = arr[0];
		return minmax;
	}

	// If there are more than one elements,
	// then initialize min and max
	if (arr[0] > arr[1])
	{
		minmax.max = arr[0];
		minmax.min = arr[1];
	}
	else
	{
		minmax.max = arr[1];
		minmax.min = arr[0];
	}

	for(i = 2; i < n; i++)
	{
		if (arr[i] > minmax.max)
			minmax.max = arr[i];

		else if (arr[i] < minmax.min)
			minmax.min = arr[i];
	}
	return minmax;
}

This is in C++ but we can reproduce it.


<EMAIL_ADDRESS>PR for evalutaion article of Kumar Chandrakant.

Closing this PR as suggested in the communication.

Closing this PR as suggested in the communication.


Refactor DNS resolver

It is not that important but anyway it's better.
I wanted to utilize gomainr but I think I'll just use dnsr instead so I am just proposing for merge so it won't go to waste although it's not much work :)
Thanks
btw. Config is not used at all?

I already implemented a cache that works across all sources and saves results for 24hrs. I believe this is a better solution.
https://github.com/crackcomm/gomainr/blob/a059cd43cb8d7edde1e1be8fb1661b7fbff29121/search/search.go#L27

I think it's better not to construct resolver on every call so maybe just set the cache capacity to 0 in dnsr.New(0)?

K. makes sense. Can you update the PR with the change, then I can merge it.

It's done, in case you missed it :+1:

Merged, thanks!


Minutes

We need to discuss file naming

Does the date-stamp in the file names cause them to back-date?

Should do, yes.

Yes, but date:  can be used too I think

:shipit:


Missing Documentation on multitenant xms fields in jwt access token

We have a multi tenant application.
When generating id token we use the sub to identify the user for further processing.
When generating a access token through the auth code flow, the sub for the same application and user differs.
We found that in the access token there are fields without documentation, one of them contains the sub we would expect for identifying the user.
"xms_st": {
"sub": "**********"
},
"xms_tcdt": ********
Please add documentation on these fields and are they safe for use/do they always contain the sub we need ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39e50f53-203a-35d3-794f-73b27be0fde0
Version Independent ID: f2af0873-d2ef-6df2-d3c2-8c953d392097
Content: Microsoft identity platform ID tokens - Microsoft identity platform
Content Source: articles/active-directory/develop/id-tokens.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

@btHolert Thank you for your feedback . We will investigate and update the thread.

Is this access token for an audience you own? If not, you should ignore all claims in that token. Never use data from access tokens, when you're the client, and never accept access tokens if they don't match your audience.

This access token is for our application to act on microsoft graph resources on behalf of users using our application.
We have multiple services getting tokens, sometimes through easy auth in azure and sometimes by requesting them from microsoft through refresh tokens we obtained through the standard user flow.

Thanks! Graph is not your resource, so you should not be looking inside of that token.

Yes i should @hpsin , Microsoft even describes in great detail every field in these tokens issued with the graph audience what each field means and what content i can expect.
Especially since the docs on said tokens explicitly mention that I should use the sub found in the tokens as unique identifiers for 3rd party applications (which btw is not available through any other source).
So either fully remove the documentation on these tokens and explicitly state that Microsoft views these tokens as a blackboxes not meant to be looked into by 3rd parties or kindly enhance the documentation as requested.

The access token documentation is for access tokens that your registered API receives.  Graph is a resource that we registered, and you could register your own as well.  Client always look in the ID token for claims - nothing else.
You can use response_type=id_token and the corresponding scopes and nonce to get an ID token that your client app can use.  See here for details on how to expose an API and get your own access tokens: https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-configure-app-expose-web-apis

Yes i know all that as i wrote above.
Still it is currently impossible to know if an access token i receive belongs to a user that is already registered with my application because the sub in there differs from the one received in earlier id tokens (which by your argumentation i can look into). So i cannot build any context and the access token is thus useless.

So on registration of a user with our service the initial point of contact is a function app with easy auth where we receive an id token for our registered application. We use the sub from that id token as the user identifier throughout our application.
Later on the users calendar data must be processed by a worker service without direct user interaction, so the user receives an email with the request to authenticate with microsoft and grant our previously mentioned application the rights on graph to process their calendars. We cannot do that through easy auth or smth different because there is no direct user interaction with the worker. So we receive a refresh token and access token through the redirect url at the end of the grant flow. We want to make sure that the user did indeed authenticate with the correct upn and not some other upn as it is possible to misclick easily when you are logged in with multiple users. Also as the end result of that step the user is registered in the workers tables with its sub as primary identifier.
However at that step we can only use the sub we receive in the access token (as we have no id token at this point) which is different from the sub we received in the id token on a users initial registration (we use the same application registration throughout).
But there is the xms_st.sub field in that access token which contains the correct sub we received on initial registration.
Please let me know if i need to be clearer at any point.

Hm, you have some options here -

You can use the Graph token to call the /userinfo endpoint to fetch the user's details, including subject.
You can use the refresh token to get an ID token.
You can investigate why you're not receiving an ID token here.

The last point may be easiest and most performant - there's no auth flow that gives you a refresh token and an access token via redirect, so the middleware involved is either omitting the ID token or simply not getting one. There's nothign stopping it from giving you one on a technical level.

@btHolert We will be closing this thread now, feel free to come back if you need any help.


README Updates

Hey team 👋
I've updated some formatting in the README file. Including removing some newlines, English structure, and badges to the top of both English and 中文 files.
Please let me know if these changes are okay.
Cheers!

Thanks, @maxxfrazer! LGTM.


How to import saved settings?

Extension Version
1.8.15
Description
I can see button to export setting, but I can't seem to find the import button 🤷🏻 Please advise.

Browsers
Firefox, Chrome
OS
Linux

@yermulnik Hah - I should probably add a button to upload a file :).
For now, go to JSON and copy/paste your config.

@yermulnik Hah - I should probably add a button to upload a file :).

That would be great as restoring config puzzled me and eventually I had to configure it on another browser manually.

For now, go to JSON and copy/paste your config - set the JSON editor to "text" mode.

I tried that editor, though it's a way far from obvious that I can paste over the top of the existing data (I didn't try though. Is it just paste? 🤔).

@yermulnik it's definitely not obvious :).
Set the editor to "text" mode and you can select/copy/paste.

Thanks for the hints 👍🏻
Closing as resolved, whilst would definitely look forward for you to be adding "Upload file" butting 😺


Value exceeds max length

Hello,
I was hoping to ask for some help on how to debug this problem as tracing the cause of an error with ohif is proving difficult for me. The error is:
/Viewers-master/OHIFViewer/.meteor/local/build/programs/server/packages/dimseservice.js:4321 throw 'Value exceeds max length'; ^ Value exceeds max length Exited with code: 1 Your application is crashing. Waiting for the file change
I'm running OHIF on centos 7 as a systemctl service. Whenever this error appears, it is resolved by simply stopping and starting the service again. But since this is a recurring issue, this is very inconvenient. And so I'm opting to ask for help on how to solve this problem.
Thank you

We're getting ready to formally announce version 2 of the OHIF Viewer. After the announcement, version 1 issues will receive lower priority support. As this issue is a bit stale, I'm going to close it for now.
I hope you were eventually able to resolve your issue. I know things like this can be particularly frustrating.


improve test coverage

See what's not being covered in red: https://coveralls.io/builds/7128688/source?filename=msgboard%2Fmsg.py

#28


Add "Quit" menu item on the system tray for Linux and Windows users

To allow Linux and Windows users to quickly close the app, we should have an "Quit" menu item.

done :)


Write data to archive body

Instead of only modifying the asar header, we should look into writing data to the body as well. This should be an optional feature though, as it will increase the resulting asar file size.
Related to #43.

No longer relevant as writing to the body won't solve anything. Encryption is the only way forward. See: https://github.com/sleeyax/asarmor/releases/tag/v3.0.0


Debugger StepOver doesn't pause after stepping over a tail call

In duktape version 2.2.0, the duktape debugger doesn't pause after stepping over a call to a function that does a tail call.
See the comment in the code below:
var Test = (function () {
    function Test() {
        return this;
    }
    Test.prototype.Foo = function Foo() {
        return 1;
    };
    Test.prototype.TailCall = function ReturnInline() {
        return this.Foo();
    };
    Test.prototype.OnUpdate = function OnUpdate() {
        this.TailCall();    // line A: debugger doesn't pause after stepping over this.
        var extraCode = 1;  // line B:
        ++extraCode;
    };
    return Test;
}());

Stepping into the call on line A works fine.  Setting a breakpoint on line B also causes the debugger to pause after stepping over line A.  But if no breakpoint is set on line B, the debugger does not pause on line B when stepping over line A.
Perhaps this issue is related to the following release note:

Fix incorrect pausing by debugger StepOut, StepOver, and StepInto commands when stepping out/over/into a tail call (https://github.com/svaarala/duktape/issues/1684, https://github.com/svaarala/duktape/issues/1685, https://github.com/svaarala/duktape/issues/1726, https://github.com/svaarala/duktape/issues/1734)

Thanks, I'll see if I can reproduce and ensure it's a tailcall related issue. That's quite likely because tailcalls and pause behavior is surprisingly complicated (not conceptually but in the details it involves).

I have a hunch that the culprit is this:
        thr->heap->dbg_pause_flags &= ~DUK_PAUSE_FLAG_LINE_CHANGE;

This is done when the tailcall is executed; line-based pausing is no longer relevant in the current function if a tailcall is executed in the function one is currently running. However, when the tailcall is embedded in a stepped over call, the flag can still be cleared, but should be restored upon return.

Also if pause flag restoring is added into call handling generally, the line change pause trigger can just be cleared for every call (not just tailcalls) instead of relying on the activation pointers being different for nested calls (as is currently done; and this should be valid because the original activation still exists for non-tailcalls).

Hmm. Thinking more about this it might be a bit difficult to just restore flags for the activations: if the pause condition is met (e.g. StepInto) and we resume again with potentially new flags, existing activations will have pause flag snapshots (now out of date) that one would then try to restore and would thus need to edit.
The root cause of the awkwardness is that the "pause if line changed" and some other pause flags are relatively to the activation where resume happens. This is tracked by storing a borrowed reference to the activation in the heap state and then comparing against it. This then becomes a problem for tailcalls where the activation is reused and its pointer remains the same, and the "pause if line changed" clearing is done to avoid this issue.
But maybe it'd be just cleaner to keep a borrowed reference to the activation and flag the activation itself explicitly as being the resume starting point. For tailcalls, that flag on the activation would be cleared (and the pause flags don't need to be edited, stored, or restored).
This doesn't work fully as such because we still need to detect when we step out of the starting point function; for tailcalls this means we pause when we exit the tailcall target but don't want to pause on line changes any more. So probably two flags are needed on the activation: one flag to indicate it is treated as a starting point for "step out" and another to indicate it is active for "line changed" tracking. On tailcalls the latter is cleared, but the former is not.
I don't have time right to work on this more but I'll try to fix this in the next few days. Thanks for the bug report and the repro!


I want to add my PR. May you confirm it please?

fixes #4

We want to merge it

We want to merge it

Than please rebase it. It has conflicts.
BTW, PR title should indicate the code contribution content. Not the action that should be done.

We want to merge it

Than please rebase it. It has conflicts.
BTW, PR title should indicate the code contribution content. Not the action that should be done.

Who should do it?
Who sent the request? Or everyone?


Failing E2E: address-book mobile

viewport is not changing to mobile for the second describe on
address-book e2e

PR: GH-6957


Any plans to add postgresql support?

I have no experience with postgresql, but from what I understand, it shouldn't be different to using MySQL when using SQLAlchemy, since it would just be changing the config files.
You could just change this line in each init file:
https://github.com/casperbh96/Flask-Stripe-MySQL-Bootstrapped/blob/master/app/StripeMicroservice/setup_app/__init__.py#L13

Yeah realised that later and now I have it running with postgresql.
It's great template I was searching something similar for long time.


Replace once_cell::sync::Lazy with std::cell::LazyCell once it's stable

We depend on once_cell for initialization of static items in the sov_schema_db crate, but we may be able to remove that dependency as std has std::cell::LazyCell, which is functionally equivalent (still unstable, though). While we could opt-in into the feature with #![feature(lazy_cell)], I don't really see a point –we wouldn't even remove once_cell from our dependency tree, just as a direct dependency– but let's make a note of switching away from once_cell when std has everything we need stabilized.

That would be good idea, but we need to wait for stabilization:
https://github.com/Sovereign-Labs/sovereign-sdk/issues/29
Do you have link to RFC about it, so we can easily track when it lands on stable?

https://github.com/rust-lang/rust/issues/109736

lazy_cell stabilized in 1.80


Mccalluc/0.0.16 rc2

I've pushed the new version: This just points to the update.

This looks good to me. I have tested that the links work.


Fixed typos in "Install package in Yarn from a Git repository"

@DreierF are you in the Discord? If so what's your username, so I can add the contributor role?

Yes, thanks 🙂
FlorianDreier#9515


Add a marker in built-in terminal middleware to distinguish between "soft" and "hard" 404

From @khellang on Friday, September 29, 2017 3:33:40 PM
I've come across a scenario where I'd like to determine if a 404 response coming up the pipeline was the result of hitting the built-in terminal middleware ("hard" 404) or if someone actually handled the request, but returned 404 anyway ("soft" 404). This can be solved easily by adding a marker in HttpContext.Items for middleware to check. Would you accept a PR for something like that?
Copied from original issue: aspnet/HttpAbstractions#945

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Feature: support for downloading analytics data from ITC

Issue Description
I started reviving fastlane/spaceship#190
The original PR allowed to fetch time_series, and I noticed that ITC analytics contain lots of data (Overview, Metrics, Sources, Retention). The first thing I will do is to check what people want !
So far this is what I found so far. Here are the URLs that are hit to fetch data, depending on the main views:
Overview

"data/app/detail/all-time"
"data/app/detail/measures"

Metrics

"data/app/detail/dimensions"
"data/app/detail/retention"
"data/app/detail/measures"
"userpreferences/METRICSVIEW"
"data/events"
"data/dimension-values"
"data/time-series"

Sources

"data/sources/campaign-list"
"data/sources/domainreferrer-list"

Retention

"data/retention"

CC @pieisgood

Essentially, I'm only after time series data. But having access to the rest of the data isn't a bad thing.

@pieisgood are you interested in trying out the current API ?
Maybe give some feedback. I have still not decided the exact API style
See https://github.com/lacostej/fastlane/commit/analytics

Hello !It's actually related to ITC only ? Do you think it can also be done for the play store ?

Spaceship is related to iTunes Connect only, that's correct. I'm not sure how the expansion of fastlane into Android is planned out, but I thought there were already APIs for google play store analytics data?

I can't find that kind of API on Google Play store... There are some mention of Google Cloud CSV data that can be retrieved but nothing really solid... I'm gonna continue searching about, thanks for your answer (and your awesome work on that issue :+1:).

Good luck! If you find anything post it here since I'll be in the same boat soon enough.

I'm looking for a way to get daily download numbers. Can I help with anything?

At this point, you can either build on top of what I built and make another pull request or do the same thing for what lacostej built. My code still works and I use it daily, so you can just sorta ham fist it into the spaceship section of your fastlane ruby gem on your disk... if you don't want to make a pull request.

Hey @pieisgood , I was trying to use iTunes api from your fork, https://github.com/pieisgood/spaceship but getting an error while running it from command line.
[5] pry(main)> app.analytics.app_views()
=> {"itcBaseUrl"=>"https://itunesconnect.apple.com",
 "message"=>"Make sure the URL is correct and try again.",
 "l10n"=>{"Crossfire-response-badrequest-title"=>"The URL is invalid.", "Crossfire-response-badrequest-message"=>"Make sure the URL is correct and try again."},
 "errors"=>[{"message"=>"Invalid adam id: null", "messageTemplate"=>"Invalid adam id: null", "invalidValue"=>"[null]"}]}

Appreciate any help.

Did you initialize the app? the adam id is null... so no app was chosen to
get analytics for it seems
On Thu, Jul 7, 2016 at 1:11 AM, Sushant Choudhary<EMAIL_ADDRESS>wrote:

Hey @pieisgood https://github.com/pieisgood , I was trying to use
iTunes api from your fork, https://github.com/pieisgood/spaceship but
getting an error while running it from command line.
[5] pry(main)> app.analytics.app_views()
=> {"itcBaseUrl"=>"https://itunesconnect.apple.com",
"message"=>"Make sure the URL is correct and try again.",
"l10n"=>{"Crossfire-response-badrequest-title"=>"The URL is invalid.", "Crossfire-response-badrequest-message"=>"Make sure the URL is correct and try again."},
"errors"=>[{"message"=>"Invalid adam id: null", "messageTemplate"=>"Invalid adam id: null", "invalidValue"=>"[null]"}]}
Appreciate any help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/3682#issuecomment-231011749,
or mute the thread
https://github.com/notifications/unsubscribe/AEFfUMsapzviELyXqPVcaqkrnPEkh2_rks5qTLSzgaJpZM4HuHAx
.


Resource references in relationship matchers should support more puppet features

It seems that that_requires,  that_comes_before and such get confused when the name of the resource is surrounded by quotes (or double-quotes).
Example:
shoud contain_package('foo').that_comes_before('Package["bar"]')   # does not work
shoud contain_package('foo').that_comes_before('Package[bar]')   # works !

This is surprising (and misleading) because, both notations are the same in the Puppet language.

The resource references on the ruby side of things always are unquoted, since they are not "really" puppet code. I'd hesitate to change this behaviour for a single consumer of puppet's ruby API. Do you think a note in the README would have helped you avoid this pitfall?

I understand there is a limitation as to how the resource are represented inside Ruby but, as a Puppet developer I have no such knowledge.
A note in the README would be a must (I just wasted about an hour on this problem).
The main problem I see here is that the content inside the quotes feels like Puppet code but it seems like it isn't. This is really confusing...

I am having a problem checking a require on a package with a hyphen in the name that I think is related.
should contain_file('/etc/ssh/sshd_config').that_requires('Package[openssh-server]')

Failure/Error: should contain_file('sshd_config').that_requires("Package[openssh-server]")
NoMethodError:
  undefined method `[]' for nil:NilClass

In testing I noticed if I try to escape the hyphen or add an extra hyphen I get a different error
should contain_file('/etc/ssh/sshd_config').that_requires('Package[openssh--server]')

Failure/Error: should contain_file('sshd_config').that_requires('Package[openssh--server]')
  expected that the catalogue would contain File[sshd_config] with that requires Package[openssh--server]

What do you think about the note added here: https://github.com/DavidS/rspec-puppet/blob/42c83bff6175327e0f69236300b3860c530f8476/README.md#relationship-matchers
(https://github.com/DavidS/rspec-puppet/commit/42c83bff6175327e0f69236300b3860c530f8476#diff-04c6e90faac2675aa89e2176d2eec7d8R243)

I think that's good, thanks!
Please use a more "eye-catchy" style, because this is really a caveat and people have a tendency to "run through the doc". I would suggest writing unquoted title using bold font for example.
Also, IIRC, Class[foo] works whereas Class[::foo] doesn't. This should be mentioned as well.

Good point. This is now #326

Thanks, with #326, explanation is pretty clear and examples help avoid the pitfalls.

Thank you for validation!


gen.php not working

Hello Developer,
gen.php is not working for every drive id it is giving same encrypted code i.e. ?id=cm5LTUxBUUlYM0FDNlJlMllmNm1Ldz09

can you attach error_logs


feat: Fixes Chatbot on homepage

Pull Request
This PR added the Chatbot on homepage of your website.
Description
Please include a summary of the changes and the related issue.
Closes # 616
Type of change

[x] Adding a new Resource
[x] Adding a new Category
[x] Documentation enhancement or fixes
[x] Website enhancement or fixes

Checklist:

[x] I read carefully CONTRIBUTING.md
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Screenshots (if appropriate):
Please add screenshots to help explain your changes.

Additional

@jfmartinz, how can I solve the Vercel check?

@jfmartinz, how can I solve the Vercel check?

Don't worry about that.

Btw We're currently redesigning the website so you can raise issue about the website after the website is done, ill close it for now. YOui can add this later


OneHotEncoder can accidentally create columns with same name

Describe the bug
The OneHotEncoder uses the schema <old_column_name>_<value> to name the created columns. This can lead to conflicts, however.
To Reproduce
Run this program:
from safeds.data.tabular.containers import Table
from safeds.data.tabular.transformation import OneHotEncoder

if __name__ == '__main__':
    table = Table.from_dict({"a_b": ["c"], "a": ["b_c"]})
    transformed_table = OneHotEncoder().fit_and_transform(table)

    print(transformed_table)

It raises an exception:
ValueError: Length mismatch: Expected axis has 2 elements, new values have 1 elements

The issue is that two columns with the same name (a_b_c) get created.
Expected behavior
No exception. The names of all created columns should be unique. They should also not conflict with existing columns in the Table. This can be done by detecting conflicts between two created columns or between a created column and an existing, unchanged column and appending a suffix _<counter> to the names of the created columns (e.g. a_b_c_1 vs. a_b_c_2).
Screenshots (optional)
No response
Additional Context (optional)
No response

Also useful: https://docs.python.org/3/library/collections.html#collections.Counter

We decided that we will implement the OneHotEncoder ourselfves, instead of using the one from scikit-learn.
We should also add performance tests to verify that our implementation is as effecient the one in scikit-learn. The tests should be performant on several large datasets.


Invoices should only be created once and stored in the backend

The current system recreates the invoices on demand, which can have strange effects, e.g. causing invoices for other conference years use different issuers. This is not correct accounting and needs to be fixed going forward.
The system should create invoices only once and then store them in the database as JSON or text field.
The next time a user requests the invoice, the stored invoice should be returned.

Created a WIP PR for this at #596

PR mentioned above was merged so I guess this one is more or less solved.


Display traits for NFTs (ERC721 and ERC1155) retrieved from OpenSea

We used to display them for CryptoKitties before we aligned the UI for ERC721 with 1155's.
Let's show them again.
Buzz @colourfreak if we need design help.
This screen, for individual token IDs:

Sample, in the OpenSea API output:
"traits" : [
   {
      "display_type" : null,
      "max_value" : null,
      "order" : null,
      "trait_count" : 34,
      "trait_type" : "Affinity",
      "value" : "Earth II, Fire I"
   },
   {
      "display_type" : null,
      "max_value" : null,
      "order" : null,
      "trait_count" : 18,
      "trait_type" : "Slabs",
      "value" : "â¢ â¢ â¢ â¢"
   },
   //…
]

[ ] Buzz Android too, in case it's missing?

@hboon @colourfreak do we have design for displaying such kind of data?


[CP] [Stable] Cherry pick request for 0a20707e3f1084b85bcdcfb4035bdd150b90756f

Commit(s) to merge
0a20707e3f1084b85bcdcfb4035bdd150b90756f
Target
stable
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/336603
Issue Description
Fix JSON array parsing bug that causes seg fault when --coverage is used.
What is the fix
The fix changes the definition of end to point 1 past the end of the element, rather than the end of the element, which avoids the need for buggy look-ahead style lookups
Why cherry-pick
Flutter customers have hit this issue when using test coverage, the sympton of this bug is a hang in flutter test making it hard for the developers to figure out what went wrong.
Risk
low
Issue link(s)
https://github.com/flutter/flutter/issues/124145 https://github.com/dart-lang/sdk/issues/53990
Extra Info
No response

//cc @liamappelbe @dnfield

Closing issue, created multiple issues for the same cherry pick request by mistake.


Think about supporting reflinking

This would allow efficient 'copy on write' usage.
In particular this would efficiently support the following use cases:
a) A 'filter' step that is just copying files that match the data you want to process in the next step
b) Debugging some data ... by copying some (subset) from an existing repo to another repo to debug

Let's close this in favor of #573. Reflinking, move and rename will all be fairly similar under the hood I think. At least enough so that the same person implementing them all together makes sense. I updated that issue to reflect that reflink support should be added as part of it.


Ignore error in single test file loading when loading all tests and report it to user

Now if you have some invalid test files like in this repo https://github.com/zzzorgo/vscode-jest-test-adapter-issue, test loading fails and you unable to run even valid ones using UI. One test disallows to run all tests. I think it would be better to ignore errors while loading this tests and show in the UI that this files are invalid.
Motivation: When I've just started using plugin I had two invalid files but had no idea about it. Only couple of hours with modified plugin code and extensive logging helped me find issues.

The PR I've raised covers a lot of what you want, but details of what the issues are with any given test are not ideal - you'll have to go check the logs to find out.  I've raise an issue with the host adapter to address this (hbenl/vscode-test-explorer#130).

I've merged the PR.  Please let me know if it solves your issue.  Unfortunately it won't make your tests work.  I'll address them in the other issues that you've raised.

Thank you! My problem was solved by editing tests themselves (only two) so the purpose of this issues is two make a better experience for other not so committed users :)

Cool, I'll close this now.  If in error, please reopen.


Add hand-pose-estimation model

The request content includes hand-pose-estimation model, c++ demo, and some modifications for this model to calculate its accuracy check.

@yssemaev @vladimir-dudnik please pay attention on model license.
Could you think, we can accept it to OMZ if it licensed for ACADEMIC OR NON-PROFIT ORGANIZATION NONCOMMERCIAL RESEARCH USE ONLY?

@playboy007gy according to CONTRIBUTING.md we accept models under permissive licenses, such as MIT, Apache 2.0, and BSD-3-Clause.


Add workers for kind clusters

Currently, only control-plan node is installed
Add 3 workers nodes for clusters deployed by kind

Increasing the number of nodes requires the addition of CPU and/or memory  in the default options in Vagrant

This now has conflicts, and as I understand it, we are going to try without any worker nodes. So, closing this PR.


WebApp Configuration could use Github Environment Variables

It is possible to run Github actions in a specific environment and set variables that can be used in configuration.
The config would be

Fork the Sample Web App Repository
Create the Static Web App
Update the newly created  workflow file in the SWA repository to add env from the github vars
Update environment variables from the github API

Could not be used with artifact upload.


Closes #17 - Replace deprecated include module

See

#17

They are not responding, maybe we should create a fork


SWDEV-415692 - Disable test Unit_Grid_Group_Sync_Positive_Basic

Test Unit_Grid_Group_Sync_Positive_Basic hangs in MI200
Temporarily disable it until hang issue is fixed

Change-Id: I5e261f42db0f363e7b302296a8f424a0d30f5672

This change is already part of https://github.com/ROCm-Developer-Tools/hip-tests/pull/413.


Package install support

Hi. CentOS provides a pre-packaged etcd, and i'm quite sure that the packages are also available for Red Hat and Fedora. Using those packages can be one of the install options.
In these packages they provide the config file, which is basically a template for env variables. Template for the config file is included together with the systemd unit file template that utilizes this file.
Also, there were two options missing, log_package_levels and strict_reconfig_check.

@upcFrost I appreciate the effort you put into this change, but I'm going to close this PR out. We'd like to keep the cookbook code path as simple as possible while still supporting every possible distro. Adding a unique code path for package installs on RHEL introduces a level of complexity, especially as the version of etcd in the package becomes old and doesn't support configuration that will be available in the latest release tarballs.  We've gone down this road before in other cookbooks and once we introduce package installs for several different distros we end up adding complex logic to handle configuration differences between different older package release. It becomes hard to maintain and makes the cookbook fragile.


Add system.stdout.isTTY property

In some use cases, this is useful to detect whether PhantomJS is run inside a TTY context. This is similar to Node.js process.stdout.isTTY.

I'll take a look into this, @Vitallium any extra details or you can provide would be great!

In progress https://github.com/ariya/phantomjs/pull/14578


 Ignore.
extensions::uncaught_exception_handler:8 Error in event handler for sockets.tcp.onReceive: RangeError: Offset is outside the bounds of the DataView
at Types.getFixed4BytesValue (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:6583:27)
at readString (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:9382:36)
at DceRpcNetShareEnumAllResponse.load (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:9356:41)
at Protocol.parseDceRpcNetShareEnumAllResponsePacket (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:11080:39)
at null. (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:12559:44)
at null. (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:11482:21)
at ChromeSocket2.fetch (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:11710:26)
at ChromeSocket2.fetch (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:11712:26)
at _appendReceivedData (chrome-extension://mfhnnfciefdpolbelmfkpmhhmlkehbdf/background.js:11595:14)handler @ extensions::uncaught_exception_handler:8

@simmondp Finally, I could reproduce this issue on my environment. I will be able to fix this issue.

@simmondp This issue is duplicate of #16. I close this issue. Please refer the status of #16. Thank you for this reporting.

Tried the updated version - fixed successfully.
Keep up the good work!
Many thanks
On 25 June 2015 at 23:11, Yoichiro Tanaka<EMAIL_ADDRESS>wrote:

@simmondp https://github.com/simmondp This issue is duplicate of #16
https://github.com/yoichiro/chromeos-filesystem-cifs/issues/16. I close
this issue. Please refer the status of #16
https://github.com/yoichiro/chromeos-filesystem-cifs/issues/16. Thank
you for this reporting.
—
Reply to this email directly or view it on GitHub
https://github.com/yoichiro/chromeos-filesystem-cifs/issues/66#issuecomment-115416195
.


Added SBT Cross Build support and support for SBT 1.0.0

Added SBT Cross Build support to travis.yml
Updated library and plugin dependencies.
Made some minor refactors of the code for clarity and correct pattern matching.
Created version.sbt file with current plugin version.
Implements fix for issue #11

There appears to be an issue with java7 build for the 0.13.16, I'll keep looking into it.

Build issue has been corrected.  Please review it and let me know if there's anything you need/want me to change!

Thanks so much @zarthross LGTM. I'll bring it in and give it a whirl. If all goes well, I'll publish!


Fix: New room - Room names in LHN do not match the name when created

Details

Fix: New room - Room names in LHN do not match the name when created
Fixed Issues

$ https://github.com/Expensify/App/issues/20510
PROPOSAL: https://github.com/Expensify/App/issues/20510#issuecomment-1584813869
Tests

Log in with a High traffic account that owns a existing Workspace
Click on the green + button
Click on the "New Room" option
Set the name of the #Room to anything you'd like (following the correct format)
Go to LHN, verify that Room name in LHN matched the name when created

[x] Verify that no errors appear in the JS console

Offline tests
Same as Tests
QA Steps

Log in with a High traffic account that owns a existing Workspace
Click on the green + button
Click on the "New Room" option
Set the name of the #Room to anything you'd like (following the correct format)
Go to LHN, verify that Room name in LHN matched the name when created

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots

Web

https://github.com/Expensify/App/assets/16502320/12189843-89c4-4cdc-a746-811f61e419c9
Mobile Web - Chrome

https://github.com/Expensify/App/assets/16502320/dde213fc-f691-4989-af76-1b90b2a5d3c2
Mobile Web - Safari

https://github.com/Expensify/App/assets/16502320/7df48256-6531-453f-a66f-5a880324baf0
Desktop

https://github.com/Expensify/App/assets/16502320/f06b81a7-d34c-4087-b31b-02e7ad1f7907
iOS

https://github.com/Expensify/App/assets/16502320/6ec9cd04-7410-452a-b099-5198c2663888
Android

https://github.com/Expensify/App/assets/16502320/4c96fa53-528d-4c84-91cb-a6795f047577

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop & Android & Mobile Web - Chrome
https://github.com/Expensify/App/assets/85645967/8b58b342-d7d2-4b9f-9d1c-f50fbdd4b263

Mobile Web - Safari & iOS
https://github.com/Expensify/App/assets/85645967/0963e5d4-d6f6-491c-8c71-5ebe5336c04b

All yours @Beamanator

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.28-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
failure ❌

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Release-1.26] - Error log when trying to find the interface comes without the interface

Backport fix for Error log when trying to find the interface comes without the interface

#8345

Validated on Version:
-$  k3s version v1.26.9+k3s-f8f888f4 (f8f888f4)

Environment Details
Infrastructure
Cloud EC2 instance
Node(s) CPU architecture, OS, and Version:
Ubuntu 22.04
Windows 2019
Cluster Configuration:
1 node servers
Steps to validate the fix

Install k3s passing the flag for flannel interface with a mock one and another with a non-existing one
Check logs of failure
Need to find the interface name in the logs

Issue reprodution:

There is no interface named test on the node.

-$ curl https://get.k3s.io | INSTALL_K3S_COMMIT=xxxxxxx  sh -s - server --cluster-init --flannel-iface=test

Sep 27 15:37:58 ip-172-31-26-165 sh[17555]: Failed to get unit file state for nm-cloud-setup.service: No such file or directory
Sep 27 15:37:58 ip-172-31-26-165 k3s[17558]: time="2023-09-27T15:37:58Z" level=warning msg="unable to get global unicast ip from interface name: route ip+net: no such network interface"
Sep 27 15:37:58 ip-172-31-26-165 k3s[17558]: time="2023-09-27T15:37:58Z" level=fatal msg="invalid node-ip: invalid ip format ''"

Validation Results:

There is no interface named test on the node.

-$ curl https://get.k3s.io | INSTALL_K3S_COMMIT=xxxxxxxx  sh -s - server --cluster-init --flannel-iface=test

Sep 27 k3s[19315]: time="2023-09-27T15:42:39Z" level=fatal msg="interface test does not have a correct global unicast ip: route ip+net: no such network interface"

-$ create test interface mock
sudo ip link add name dummy0 type dummy
sudo ip link set dev dummy0 up

-$ curl https://get.k3s.io | INSTALL_K3S_COMMIT=xxxxxxxxxx  sh -s - server --cluster-init --flannel-iface=dummy0

Sep 27 k3s[10569]: time="2023-09-27T15:21:07Z" level=fatal msg="interface dummy0 does not have a correct global unicast ip: can't find ip for interface dummy0"


winget upgrade lists an available update for WinSCP, but winget upgrade WinSCP.WinSCP says there's none

Brief description of your issue
When enumerating available updates, winget upgrade says WinSCP 5.21.6 can be updated to 5.21.7.
But  winget upgrade WinSCP.WinSCP says there's no applicable update.

Steps to reproduce
Run  winget upgrade WinSCP.WinSCP on a machine where WinSCP 5.21.6 is installed.
Expected behavior
winget should upgrade WinSCP to 5.21.7
Actual behavior
 winget upgrade WinSCP.WinSCP reports there's no applicable update.
Environment
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2604
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

User Settings: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

WinGet attempts to verify by looking to see if the registry keys are under HKCU or HKLM if I'm not mistaken

Indeed, and that's what's expected (looking under HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall and HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall, I mean).
My WinSCP install shows up at HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\winscp3_is1.
And --force doesn't help:
PS>  winget upgrade WinSCP.WinSCP --scope user --force
No applicable upgrade found.

As I don't have a specific need for that upgrade at this point, I'll leave the system as is should you want me to perform further tests.

Seems to work, thanks for the fix!


Feature [RPA-685] Set proper status and error message for terminated and interrupted process instances.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Breaking Bad

I agree to the terms of the RunBotics Contributor License Agreement.


misspelled

Line 81 'statistics' and line 109 'resilience'
Signed-off-by: Pranjal<EMAIL_ADDRESS>

Please merge it

please merge my pr, if changes made are correct


Does validation is already in framework?

Validation is not reflecting in the UI.

Create a <input type="number" @bind('some property')/>

try to write some text
Expected:- it should some validation error.

It isn't implemented yet, you can track the issue here #17.

Thanks for answering, @RyoukoKonpaku!

Great


BCE years trigger ISO8601Error

I work with historical data and also BCE dates, however these currently result in an error, e.g.:
 Unrecognised ISO 8601 date format: '-0663-01-01'
Yet according to ISO 8601 BCE years should be denoted with a preceding - sign, e.g. -0002-04-12 is even listed as an example.

I'm also affected but note this is known behaviour: https://github.com/gweis/isodate/blob/8856fdf0e46c7bca00229faa1aae6b7e8ad6e76c/src/isodate/isodates.py#L6
Probably the fix is to replace the built-in Python library with another implementation, e.g., NumPy, but that is also probably a breaking change.

@dymil hit the nail on the head with the response. I wrote this so I would understand the problem a little better.  Python's datetime.datetime doesn't support negative years.
>>> from datetime import datetime

>>> datetime(63,1,1)
datetime.datetime(63, 1, 1, 0, 0)

>>> datetime(-63,1,1)
ValueError: year -63 is out of range

Python date libraries like Pendulum (pendulum.datetime) and Arrow (arrow.Arrow) have the same problem because these libraries use datetime.datetime for their internal representation.
The expanded parameter of parse_date's documentation suggests that negative years are supported source code.  The regular expressions support negative years, if only a datetime.datetime function (or one that took similar parameters) would support negative years.
I agree with @dymil NumPy is a great alternative that does the ISO parsing itself and supports negative years.
If there were another library that took a datetime.datetime-like parameters and supported negative years, then I think it would be a good move to add a datetime_func= parameter to the parse_date() function.  This approach would add no new imports for isodate.  Is there a Python date library that supports negative/BCE dates?

Thanks for your clarifications! I have worked with flexidate before, maybe it is worth a try.
In any case, I think the current error message when parsing BCE years is misleading, perhaps it could be updated in the meantime?

In any case, I think the current error message when parsing BCE years is misleading, perhaps it could be updated in the meantime?

expanded= parameter
@jonasengelmann  If you want to parse negative years per the current documentation, it should be called like this.
>>> isodate.parse_date('-0663-01-01', expanded=True)
ValueError: year -663 is out of range

I think a ValueError is a descriptive error message.
If you want, I can put a PR together to allow a FlexiDate object to be able to passed instead of the Python date function.  Only if you want me to.
Here's what I'd propose:
>>> import flexidate
>>> isodate.parse_date('-0663-01-01', expanded=True, date_obj=flexidate.Flexidate)
<class 'flexidate.FlexiDate'> -0663-01-01

This has the benefit of adding  no more dependencies to the isodate library, but still allowing it to be useful for this edge case.


PreferenceCategory bottom margin too big

First of all, great library! I don't think this is a bug directly for your library, but maybe can add it as a fix? See the comparison below using the regular PreferenceFragment, PreferenceFragmentCompat (using v14 theme), and your PreferenceFragmentCompat respectively.

I've tried setting my own android:listSeparatorTextViewStyle and Preference_TextAppearanceMaterialBody2 with 0 bottom margin/padding and it doesn't seem to fix it.
Any idea what's causing this issue? Thanks for all the work you put in.

The latest version (v24.0.0) of the official library seems to be messing with the paddings / margins (that's why I didn't release the v24 fix yet), maybe they realized the same things you did and tried to fix it, with no success. I'll look into it anyways.

Oops forgot to mention this was on v23.4.0.

Don't worry, I got it. I'm just saying that the support lib dev team is definitely doing something with the paddings / margins, so your problem maybe won't exist in the future versions. Or they just really messed up the layout this time.

It's now available in <IP_ADDRESS>. You can set the bottom margin to 0dp (or whatever you want) by setting preferenceCategory_marginBottom in your theme, for example:
<item name="preferenceCategory_marginBottom">0dp</item>

Tested and working. Nicely done! Thank you for the fix.

Is this still working? I am not sure if I did something wrong or it is no longer supported...

@giccisw It should. What's wrong?


Provide named exports

RxJS version:
6.2.0
Code to reproduce:
import { range } from 'rxjs';
import { map, filter } from 'rxjs/operators';

range(1, 10).pipe(
    filter(n => n % 2 !== 0),
    map(n => n * n),
).subscribe(v => console.log(v));

Expected behavior:
No error
Actual behavior:
SyntaxError: The requested module 'rxjs' does not provide an export named 'range'
at ModuleJob._instantiate (internal/modules/esm/module_job.js:89:21)
Additional information:
Running on NodeJS 10.2.1 with the flag --experimental-modules the following code works as expected:
import range from 'rxjs';
import map from 'rxjs/operators';
import filter from 'rxjs/operators';

range.range(1, 10).pipe(
    filter.filter(n => n % 2 !== 0),
    map.map(n => n * n),
).subscribe(v => console.log(v));

Hey @thiagogcm I'm having trouble reproducing the error you're seeing. The reproduction code seems to work for me in Node, and I have a stackblitz reproduction which also seems to be working as expected. Do you have any more information about your environment? Are you running this in Node or in the browser?

Hi @natmegs Thanks for looking into it.
Im running pure javascript code on NodeJS (linux) 10.2.1 and one detail I forgot to mention: The second snippet only works when I change the file type to mjs
node --experimental-modules index.mjs

@thiagogcm how did you run first example then? node 10's esm would only work with mjs in experimental, as you already indicated second example ran by manually renaming it.

I am unable to run the first example regardless the file extension.

I guess issue in here is trying to use js module with experimental which supposed to break for some cases. I.e https://github.com/nodejs/node/issues/16474 shows similar cases you described, and as we officially don't offer esm modules yet there isn't any actual way to run rx via native esm.
I'm closing this issue as expected to not work at the moment, we will definitely support native module one time with our packages and please check with those stable node features.

Fair enough. As the second code snippet works fine I opened this issue to make sure I was not missing anything. Thanks


Add switch of undo data validation.

Ⅰ. Describe what this PR did

Add switch of undo data validation.

Ⅱ. Does this pull request fix one issue?
Last PR of #1049
Fix #1049

Codecov Report

Merging #1083 into develop will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##             develop    #1083      +/-   ##
=============================================
+ Coverage      39.94%   39.96%   +0.01%
  Complexity      1153     1153
=============================================
  Files            222      222
  Lines           8929     8931       +2
  Branches        1158     1158
=============================================
+ Hits            3567     3569       +2
  Misses          4914     4914
  Partials         448      448

Impacted Files
Coverage Δ
Complexity Δ

...ava/io/seata/core/constants/ConfigurationKeys.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...seata/rm/datasource/undo/AbstractUndoExecutor.java
83.15% <66.66%> (+0.36%)
20 <4> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ee500...9c47c59. Read the comment docs.

@slievrly OK,  I already added.


Clarify documentation of optionals

Pre-Review Checklist for the PR Author

[ ] Code follows the coding style of CONTRIBUTING.md
[ ] Tests follow the best practice for testing
[ ] Changelog updated in the unreleased section including API breaking changes
[ ] Branch follows the naming format (iox-#123-this-is-a-branch)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit messages are signed (git commit -s)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[ ] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed (except task-list-completed)
[ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior

[ ] Each unit test case has a unique UUID

[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes TBD

@mossmaurice It seems like the PR checklist assumes that a contributor can open a branch in the iceoryx repository, has signed the legal agreements, and opens an issue in before-hand.
This seems like a lot of overhead for these minor documentation improvements. Maybe it's easier if you just re-commit the commits under your name.

@tobiasblass

It seems like the PR checklist assumes that a contributor can open a branch in the iceoryx repository,

This is not the case, why do you have this impression? At the moment the workflow is just to create a branch on the https://github.com/apexai/iceoryx fork (for Apex.AI employees) otherwise on your private fork.

has signed the legal agreements,

This is something you only have to do once. See: https://www.eclipse.org/legal/ECA.php Just create an account with the same E-Mail you use in your commits and sign the ECA.

and opens an issue in before-hand.

This is required since we have to ensure traceability. Therefore the workflow is like this:

Create issue (For small things like this PR the issue can consists of one or two sentences)
Create a branch with the prefix iox-#??? where ??? is the issue number
Use in every commit the prefiox iox-#???
The PR name also requires the iox-#??? prefix and is then linked with the issue.

This seems like a lot of overhead for these minor documentation improvements.

The overhead is actually quite minimal. Signing the ECA once costs you 5 minutes and the rest goes with the flow. So could you please sign the ECA, create the issue, rename your branch and perform a rebase to adjust your commit messages, like:
git rebase -i HEAD~2
# change pick to edit for both commits
git commit --amend
# add the iox-#??? and continue to the next commit with git rebase --continue
git push -f # force push since you changed the history

Starting in a new open source project comes always with a little bit of overhead but the next issue will cost you only one additional minute since now you know the process :D ...

Maybe it's easier if you just re-commit the commits under your name.

No I would not do this. You made a contribution and we are all thankful for that and therefore your name should be mentioned, even when it is just a minor change. Also we want to be clear and transparent for everyone and those hacks may provide the wrong impression.
@tobiasblass From your point of view, do you have any suggestions for us how to make it easier for future developers to get started in our project? Any hints would be welcome.

@elfenpiff  Thanks for the clarifications, I'll fix up the PR then.

It seems like the PR checklist assumes that a contributor can open a branch in the iceoryx repository,

This is not the case, why do you have this impression? At the moment the workflow is just to create a branch on the https://github.com/apexai/iceoryx fork (for Apex.AI employees) otherwise on your private fork.

Good question. I think the fact that there's a branch naming scheme suggested that to me (because why would you need a branch naming scheme on private forks?). Maybe it would be good to clarify this in the PR checklist.

@tobiasblass From your point of view, do you have any suggestions for us how to make it easier for future developers to get started in our project? Any hints would be welcome.

I fully understand the need for traceability  (and thank you for the step-by-step instructions!). However, when the change is about minor fixes in the documentation, traceability is not as much of a concern (or at least it seems like this to me, I'm not an expert).
At the same time, the effort to learn about the commit workflow can be higher than the actual work. Sure, that is not a big deal if you plan to commit regularly, but it discourages this kind of minor one-off fixes.
You could consider having a streamlined process for "minor documentation fixes". It is probably a good idea to still insist on the ECA there, but it might be possible to skip the issue-creation/branch-linking step.

@tobiasblass

Thanks for the clarifications, I'll fix up the PR then

I would like to merge your pull request in the next days, do you have time to fix up the PR?

Closing in favor of #1363


Add support for sourcemaps

Hey @szarouski, this is great! But can you fix the build ? Right now, it's not working. See https://travis-ci.org/t32k/grunt-csso/jobs/176102824. You can run it locally before pushing, npm run test. Thanks!

Fixed. Don't know how I missed travis 😛

@nitriques does it look good now?

Yes! Sorry @szarouski I was a lot busy in the past weeks. I've made another quick review: could you check it/argue with me/fix it ? Thanks!

@nitriques Thanks for review! 🍺 Updated.

@szarouski Thanks! Check out the attached commits I've just pushed ;) And please test on Windows !

@nitriques, checked out latest version from dev tests are failing on windows for sourcemap:
Running "nodeunit:tests" (nodeunit) task
Testing csso-test.js.FF......
>> csso - sourcemap
>> Message: should create sourcemap
>> Error: '.a{-webkit-fi1ter:blur(5px);filter:blur(5px)}.b{-webkit-padding-before:10px;pad
ding-block-start:10px}\r\n/*# sourceMappingURL=sourcemap.css.map */' == '.a{-webkit-fi1ter
:blur(5px);filter:blur(5px)}.b{-webkit-padding-before:10px;padding-block-start:10px}\n/*#
sourceMappingURL=sourcemap.css.map */'
>>   at Object.sourcemap (test\csso-test.js:20:10)
>>   at runCallback (timers.js:574:20)
>>   at tryOnImmediate (timers.js:554:5)
>>   at processImmediate [as _immediateCallback] (timers.js:533:5)

>> csso - sourcemap
>> Message: should create sourcemap
>> Error: '{"version":3,"sources":["<unknown>"],"names":[],"mappings":"AAAA,E,CACC,wB,CACA
,gB,CAED,E,CACC,2B,CACA,wB","file":"<unknown>","sourcesContent":[".a {\\n\\t-webkit-fi1ter
: blur(5px);\\n\\tfilter: blur(5px);\\n}\\n.b {\\n\\t-webkit-padding-before: 10px;\\n\\tpa
dding-block-start: 10px;\\n}\\n\\n/*# sourceMappingURL=data:application/json;base64,eyJ2ZX
JzaW9uIjozLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUE7SUFDSSww
QkFBa0I7WUFBbEIsa0JBQWtCO0NBQ3JCO0FBQ0Q7SUFDSSw2QkFBMEI7WUFBMUIsMEJBQTBCO0NBQzdCIiwiZmlsZS
I6InNvdXJjZS5jc3MiLCJzb3VyY2VzQ29udGVudCI6WyIuYSB7XG4gICAgZmlsdGVyOiBibHVyKDVweCk7XG59XG4u
YiB7XG4gICAgcGFkZGluZy1ibG9jay1zdGFydDogMTBweDtcbn1cbiJdfQ== */"]}' == '{"version":3,"sour
ces":["<unknown>"],"names":[],"mappings":"AAAA,E,CACC,wB,CACA,gB,CAED,E,CACC,2B,CACA,wB","
file":"<unknown>","sourcesContent":[".a {\\r\\n\\t-webkit-fi1ter: blur(5px);\\r\\n\\tfilte
r: blur(5px);\\r\\n}\\r\\n.b {\\r\\n\\t-webkit-padding-before: 10px;\\r\\n\\tpadding-block
-start: 10px;\\r\\n}\\r\\n\\r\\n/*# sourceMappingURL=data:application/json;base64,eyJ2ZXJz
aW9uIjozLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUE7SUFDSSwwQk
FBa0I7WUFBbEIsa0JBQWtCO0NBQ3JCO0FBQ0Q7SUFDSSw2QkFBMEI7WUFBMUIsMEJBQTBCO0NBQzdCIiwiZmlsZSI6
InNvdXJjZS5jc3MiLCJzb3VyY2VzQ29udGVudCI6WyIuYSB7XG4gICAgZmlsdGVyOiBibHVyKDVweCk7XG59XG4uYi
B7XG4gICAgcGFkZGluZy1ibG9jay1zdGFydDogMTBweDtcbn1cbiJdfQ== */"]}'
>>   at Object.sourcemap (test\csso-test.js:24:10)
>>   at runCallback (timers.js:574:20)
>>   at tryOnImmediate (timers.js:554:5)
>>   at processImmediate [as _immediateCallback] (timers.js:533:5)

>> csso - comments
>> Message: should minify and remove all but the first exclamation comment
>> Error: '.a{-webkit-fi1ter:blur(5px);filter:blur(5px)}.b{-webkit-padding-before:10px;pad
ding-block-start:10px}\r\n/*# sourceMappingURL=sourcemap.css.map */' == '.a{-webkit-fi1ter
:blur(5px);filter:blur(5px)}.b{-webkit-padding-before:10px;padding-block-start:10px}\n/*#
sourceMappingURL=sourcemap.css.map */'
>>   at Object.comments (test\csso-test.js:34:10)
>>   at runCallback (timers.js:574:20)
>>   at tryOnImmediate (timers.js:554:5)
>>   at processImmediate [as _immediateCallback] (timers.js:533:5)

Warning: 3/12 assertions failed (15ms) Use --force to continue.

Ok thanks. At home, I do not have a Windows machine (I've tested in on Ubuntu) but I do at work. Will test ASAP.

I have no problems running the test on my Windows machine.
I think it depends on your git config: if git converts LF to CRLF, then the test might not pass.
I've juste pushed a .gitattributes file to make sure your git config does not make the test fails.

I had an issue even after I pulled, so I decided to delete everything except for .git and try again. After reset everything works fine. Good job 👍


[PostgreSQL] Adding a new privatepreview version for fast-provisioning feature

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Adding getCachedServerName API
Adding additional properties for LocationCapabilities API. There's no change for LocationCapabilities API itself and only introducing a couple of new properties. If this can be an issue for this PR, can be removed

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run

Hi @honghr now passing the CI except SDK breaking change. Let me work with SDK folks to handle this

Hi @BigCat20196, I'm only planning to release Python SDK for this new privatepreview version. Do you think this error message is something could be potentially dangerous? I would appreciate your inputs!
❌azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 10.1.0
Diff with approved:

Model Server no longer has parameter tags_properties_tags
Diff with base:
Model Server no longer has parameter tags_properties_tags

Hi @honghr now passing the CI except SDK breaking change. Let me work with SDK folks to handle this

@honghr Any feedback on this PR please?

Hi @BigCat20196, I'm only planning to release Python SDK for this new privatepreview version. Do you think this error message is something could be potentially dangerous? I would appreciate your inputs! ❌azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 10.1.0 Diff with approved:

Model Server no longer has parameter tags_properties_tags
Diff with base:
Model Server no longer has parameter tags_properties_tags

@BigCat20196 Any input would be appreciated for this SDK breaking change message!


fix: node 20 support

I've upgraded node-fetch and modified utils/wait.ts to be sure it uses the node-fetch version of fetch.
shim/crypto.ts is also modified. I'm not sure the fix is correct, but the bee node looks working. I bought a batch, uploaded data, and got it successfully, so the base functionality is working.

nice, thanks @TheBojda! please update package-lock.json too and LGTM

I think, I added it.
(I'm not a git ninja. :))

Unfortunately test are failing: https://github.com/fairDataSociety/fdp-play/actions/runs/9503353206/job/26193586676
reverted in #142 until this issue is solved