data validation drop-down list use sqref cell  issue #268

PR Details
data validation drop-down list use sqref cell
Description
I think SetDropList only uses the current situation. SetSqrefDropList is used to indicate that the cell in the current sheet or other sheet is referenced.
Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #270 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   98.57%   98.55%   -0.03%
==========================================
  Files          18       18
  Lines        3790     3796       +6
==========================================
+ Hits         3736     3741       +5
- Misses         35       36       +1
  Partials       19       19

Impacted Files
Coverage Δ

datavalidation.go
84% <83.33%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da107d...93cbafb. Read the comment docs.


Use local time zone automatically

Details
Use local time zone automatically
Testing
printed out the time zone which is expected

Thanks a lot for sending in your code! I really appreciate it.


I have found bugs using your processor.

I have a floating point library which uses PicoBlaze. Replacing it with your PauloBlaze produces wrong results 1% of times.  Therefore your design has bugs, probably in ALU part.

Thanks for reporting this. Do you get the wrong results during simulation or runtime? Are you able to find a case were it goes wrong? Otherwise it would be hard to find and fix this bug.

It is on run-time. I feed two 64-bit numbers into the Scratch Pad Memory and processor calculates Floating-point arithmetic on them and write the result back into SPM. It is a real complex algorithm and I see that your core generates wrong result. The only change I made is to set then SPM size from 64 to 256 (maybe that is the cause? ). The problem could be anywhere. it is a 2000 up lines of code machine program.

This does not sound like it can be debugged easily. I canot promise to look into it, but I am still curious what the bug might be. Maybe at some point in the future

The work is part of my PhD. I have uploaded the Vivado 2018.3 project and the PicoBlaze program (which your core fails executing) into my repository, I don't have enough time to pin point the bug but if you are curious you can look into my Vivado design and then replace the PicoBlaze with PauloBlaze and see where it exactly fails. You can also run both cores together and log the discrepancies.

If the data was coming through the input ports, then it's likely that data was being offset, so when reading to one port you were getting data from the previous port request, because of issue #5. Thus, the bug may not have been in the ALU but in the port input logic.


修改错别字

Signed-off-by: blkart<EMAIL_ADDRESS>

Nice catch @blkart and it's the great fix :+1:


wpcom/v2 endpoints do not autocomplete

To reproduce:

Open the dev console.
Change the endpoint path to wpcom/v2 (see screenshot below).
Type /sites into the path field.

What I expected: to see a list of /sites endpoints.
What I saw instead: nothing happens, but there's an error in the dev console.

I believe the line in question is this un-guarded regexp reference: https://github.com/Automattic/rest-api-console2/blob/0313c8e157c9d88aa7e46bff2a80f71b293b6474/lib/api/core.js#L43

Should this be moved to the new console repository https://github.com/Automattic/wp-api-console? This repo is for the previous one?

@youknowriad hm... I was thinking that, but the regexp that produces the error (in the wpcom dev console) seems to not be in the new repository. Because of that I assumed that the dev console must be running this version. Am I mistaken?

Oh! Maybe I'm wrong. This line might have the same issue. I'll move the bug report over there.


use swiftui rating package to create gui rating

https://github.com/magickworx/StarRatingViewSwiftUI
https://github.com/ForceGT/RatingViewSwiftUI
something like:

both good options
could go next to edit button or maybe below description

merged in #78


Develop

I have made some bug fixes to AffoFly_Transmitter.
Please have a look and let me know.

Renamed varialbe rxConfig in local functions to rxConfigLocal as there is a global variable called rxConfig already.
Changed structure assignment to use memcpy for it to work in getRxConfigs() and getRxConfig() functions.
Renamed variable finalText to finalTextInner in a for loop because we have a variable called finalText declared earlier in the same function.
Moved char array declaration in a Do loop to outside the loop because the strings are static.

The motors use pins 9, 10, 6 and 5 saving the pin 3 so that Timer2 can be used for Servos


Parsing in Data Import dialog don't work correctly for Japanese

Hi I found CSV importer won't work correctly.
It can handle Japanese text (input file view) but when parsing it by delimiter to data frame (data frame view) it fails.
input file view in DataImport dialog : correctly works for SJIS,EUC,UTF-8

data frame view in DataImport dialog : doesn't work (second & third column are combined)

This leads loading error like "number of columns are bigger than column names".

What happens if you import manually with read.csv?

All the dialog does is calling read.csv, nothing is parsed manually.

Closing since we don't actually parse or convert the data. Please reopen if plan read.csv behaves differently.


Problems with creating a mesh

Hello,
I'm trying to create a simple mesh for an IPE for a 2D analysis, but the mesh is not regular and Safir doesn't run. In the videos on youtube, there isn't shown how to create it, it is only shown how to do the geometry. When I click on "Mesh 2D", Safir does a mesh like this:

I tried also to transfinite the curves, but it didn't work. Can you help me?

the error looks like this:

Could you please upload your .geo and .g4s files? But before uploading, please add a suffix ".txt" to these filenames. Only this .txt format is suported by GIThub

Test.g4s.txt
Test.geo.txt

Dear Nelly-22,
it would be nice if you could identify yourself. The SAFIR and GmSAFIR communities are not based on anonymous messages.
The messages with the Determinant < 0 are probably due to the fact that the first line that you used to described the surface was not in the appropriate direction. Invert the 2 points which make this first line in the script and this should solve the problem (or choose another line as the first one line describing the surface).
The mesh can be refined by giving a smaller value of the fourth coordinate of the points in your script. This 4th coordinate is driving the size of the mesh around the point.
Hope this helps.
Jean-Marc

Yes, thank you.
What do you mean by "identify yourself"? Do I have to show my licence somewhere?


Provide a simple clear button for Run output

Otherwise a full page reload is required if you like to clean the result output. The clear button will only be shown when some result is available.

Sorry, i broke everything :disappointed:  could you please rebase or recreate this branch on develop?
Thanks for the PR!


More Unit Tests

This bumps our coverage of our utilities to about 67%.
Additions

Adding type-checkers-spec.js
Adding date-range-formatter-spec.js
Creating util unit test folder to match structure of JS

Testing

Run the unit tests!

Preview

Notes

The Chai assertion .to.be.true kept returning eslint errors, so I've turned off the dot-notation rule for the unit testing folder

Nicely done! :+1:

Looks really sexy to me. I want to merge it. Can I?

I want to wait until I get one more :+1: so non-west coast folks can see it before it goes in.

Paging @contolini who is technically  a non-west-coaster now/

I am an all-coaster.

:+1:

:+1:


Switch to latest RHEL versions for testing

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

@ondrejbudai I've updated Schutzfile to use https://github.com/osbuild/osbuild/commit/d602b5ff7f40dd3abb956d29aa0c7573e6e0ed29 which as a bonus fixes an issue we found last week on RHEL-9.1


Fix text selection in composer disappears after dragging it over the FAB

Details

Dragging a text selection in the composer over the FAB in sidebar will make the selection disappear just like we drag it below the input.
Fixed Issues

$ https://github.com/Expensify/App/issues/31573
PROPOSAL: https://github.com/Expensify/App/issues/31573#issuecomment-1847409814
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Web/Desktop

Open any chat
Type anything in the composer
Drag a text selection from the composer to the FAB in the sidebar/LHN
Verify the text selection persist

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/df053bd4-3239-4003-bbbf-3fae80da9a0f

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/e28de905-fbad-4536-8271-2aae8415ea1a

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.12-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Remove wait_for_event and simplify event access in subscribe_events

Removes the obsolete wait_for_event functions. I don't see the use case of these functions any more.
In addition, the event subscription has been updated:

Renames subscribe_frame_events to subscribe_events and moved to more fitting event.rs instead of the frame_system file.
Instead of returning the StorageChangeSet, which required quite some type insight to retrieve the events from it, a struct EventSubscription is returned. Upon next_event it directly tries to retrieve the events.

closes #413

One thing that is not quite clear to me is how the EventDetails and EventRecord relate as they seem quite similar. Is it a possibility to get rid of EventDetails?

True enough. That might be something one could look into. EventDetails has been copy pasted from subxt. It's basically a helper / wrapper struct. EventRecord is the Substrate type. But that should be investigated in a different issue.
EventDetails does contain quite some convenience features. But maybe it's an overkill. Will create an issue for that.


Is possible to have the needed jar file to work with ti.googlesignin

I see that you have a common jar file for ti.map and others, is possible to have one that works with https://github.com/AppWerft/Ti.GoogleSignIn
Thanks for this great module

You can close this ticket I have done this build for that purpose
google-play-services.jar.zip
Thanks Again


Remove usage of deprecated auth0 rules

Action Required: Rules will Reach End of Life on November 18, 2024

We've received a notification that auth0 rules will be retired. They are currently being used based on a community forum recommendation to have the user's email and name included in the auth0 JWT.
We need to either:

Replace it with an Auth0 action (or whatever the recommended replacement is)
Have the api call auth0 with the token to get the user's details (email and name)

It might make sense to do this after #62 so it can be done in the open.


can't fetch all mtail dependencies

vgo2nix-unstable-2019-02-06
git clone https://github.com/google/mtail.git
cd mtail
vgo2nix

[...]

I tracked this down to this problem:
package main

import (
	"fmt"
	"golang.org/x/tools/go/vcs"
)

func main() {
	repoRootDynamic, err := vcs.RepoRootForImportDynamic(
		"dmitri.shuralyov.com/gpu/mtl",
		true)
	if err != nil {
		fmt.Println(fmt.Sprintf("RepoRootForImportDynamic Error %s", err))
	} else {
		fmt.Println(fmt.Sprintf("RepoRootForImportDynamic Success %s", repoRootDynamic))
	}
}

Running this gives
RepoRootForImportDynamic Error
  parse https://dmitri.shuralyov.com/gpu/mtl?go-get=1:
  multiple meta tags match import path "dmitri.shuralyov.com/gpu/mtl"

The contents of that URL are
<meta name="go-import" content="dmitri.shuralyov.com/gpu/mtl git https://dmitri.shuralyov.com/gpu/mtl">
<meta name="go-import" content="dmitri.shuralyov.com/gpu/mtl mod https://dmitri.shuralyov.com/api/module">
<meta name="go-source" content="dmitri.shuralyov.com/gpu/mtl https://dmitri.shuralyov.com/gpu/mtl https://gotools.org/dmitri.shuralyov.com/gpu/mtl https://gotools.org/dmitri.shuralyov.com/gpu/mtl#{file}-L{line}">

@dmitshur Do you have any idea about why this is happening?

@Infinisil Yes. I think you must've tested with a very old version of the golang.org/x/tools/go/vcs package. This was issue golang/go#31845, and it was fixed on May 6, 2019.
I see that the golang.org/x/tools module was updated from a 2-year-old version to a newer one in PR #37 11 days ago, so I suspect this problem is resolved now.

@bbigras Let me know if this is still an issue.


Download at url with progress

Downloading large files can be problematic because the SMBClient.download(path: String) stores the whole file in memory, returning it as a Data object.
This PR adds a new SMBClient.download(path: String, localPath: URL, overwrite: Bool, progressHandler: (Double) -> Void) to allow downloading files while writing the chunks of data to disk progressively, resulting in lower memory consumption.

localPath accepts a file URL, following the existing API in SMBClient.upload(localPath: URL, remotePath path: String)
overwrite flag enables overwriting the file if it already exists. If the file does exist and the flag is set to false, the download method throws a CocoaError.fileWriteFileExists (this is the best error I could find. let me know if there's a better one)
progressHandler allows for download progress updates. It follows the existing progressHandler API in the upload function.

I've also added a test for the new method.

Merged by https://github.com/kishikawakatsumi/SMBClient/pull/156


Change text magnification to general magnification

The magnification option should not only increase/decrease the size of text but the UI in general. In addition to this, we need to investigate if the UI should scale down when on mobile (for smaller screens).

General magnification should be handed by the browser. Therefore, text-only magnification is correct.


Use common translation package

Resolves #2273.

Review for Laravel is more/less done. Still fixing bugs in React.

Ooookay @tristan-orourke @yonikid15 I think this is now good, although I'm not 100% sure how the JPB functioned prior to this regarding locale entries for various things.
I'd also like folks to test out applications, profiles, and the admin portal to see if we have any issues around translated models. Highest risk is probably Skills at this point.

Ooookay @tristan-orourke @yonikid15 I think this is now good, although I'm not 100% sure how the JPB functioned prior to this regarding locale entries for various things.
I'd also like folks to test out applications, profiles, and the admin portal to see if we have any issues around translated models. Highest risk is probably Skills at this point.

Just saw this. Will take a look now 👍


[FEATURE] Use EC2 ImageBuilder to create AMIs

Is your feature request related to a problem? Please describe.
Currently AMIs are built using EC2 instances in the VPC.
This is working fine, but it might be simpler to use the EC2 Image Builder service to create the AMIs using pipelines.

Deprecating the legacy scheduler in favor of ParallelCluster.


CONSOLE_READCONSOLE_CONTROL::dwCtrlWakeupMask is a bit mask, not a character

dwCtrlWakeupMask is documented to be a control character but it instead seems to be a bit mask in which each bit corresponds to one of the 32 control characters 0x00 to 0x1F.

  ULONG dwCtrlWakeupMask;

dwCtrlWakeupMask
A user-defined control character used to signal that the read is complete.

https://github.com/microsoft/terminal/blob/6c869ebb269155194e668b768d3424eb2a22a125/src/host/readDataCooked.cpp#L495

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33ea95a4-7dad-cc82-7f3d-3bbc9a75fb33
Version Independent ID: 4e8ad957-9707-9f59-1a42-e926dcd699b0
Content: CONSOLE_READCONSOLE_CONTROL structure - Windows Console
Content Source: docs/console-readconsole-control.md
Product: console
GitHub Login: @miniksa
Microsoft Alias: miniksa

Well how about that. You're absolutely right. Fixing.


AS0034 Breaking Change

Please include the following with each issue:
1. Describe the bug
Table ObseleteState=Pending; V1

V2 Set the Table to Access Internal:

error AS0034: The property 'Access' for Table 'xxxx' has changed from value 'Public' to value 'Internal'. This is not allowed because it will break upgrade of existing installations and dependent extensions.

AL Language: 7.4.496506
Visual Studio Code: 1.58.2
Business Central: 18.3

This issue is fixed for version of the AL extension for Visual Studio code higher than 7.4.500202.


Listed URL is 404

The repository's linked webpage (https://rudof-project.github.io/shapes-rs/) is 404.

Ops, you were right, I have just changed it to the new one: https://rudof-project.github.io/rudof/
Thanks a lot for pointing this out and I hope you have fun if you try rudof.


Error when importing database dump: Cannot add foreign key constraint

When exporting a MySql dump with the ProcessDatabaseBackups module and importing it again, I'm getting the error:
Error in query (1215): Cannot add foreign key constraint

Apparently the line:
CONSTRAINT `appapi_apikeys_ibfk_1` FOREIGN KEY (`application_id`) REFERENCES `appapi_applications` (`id`) ON DELETE CASCADE

is the problem here since the table appapi_applications does not exist yet.
I was able to fix this issue by moving the blocks DROP TABLE IF EXISTS 'appapi_applications'; and CREATE TABLE 'appapi_applications' … and INSERT INTO 'appapi_applications' … to the top of the file.

Yeah, I have already encountered these problems, too. The only problem is that the appapi_applications table must be created before appapi_apikeys. The foreign-keys are useful, because when an application is deleted, the apikeys will automatically deleted as well. But maybe it is better to implement this as php logic, since I cannot influence in which order the tables will be created from ProcessDatabaseBackups.

My last commit should fix this issue. On new installations the created database-scheme will no longer contain foreign-key constraints.
I tried to remove them on update automatically, but I think that could be complicated because we need to know the names of the constraints to delete them. My foreign-key constraint for the table appapi_apikeys was called appapi_apikeys_ibfk_1, but I think that could differ depending on the database-system used.
So, my plan is to add a message to the update-description, that the constraints can be deleted manually like this: ALTER TABLE appapi_apikeys DROP FOREIGN KEY appapi_apikeys_ibfk_1;


1.8.1 and 1.8.2 versions gives generated file conflict build warning

After upgrading to 1.8.1 and 1.8.2 version I've encounter following build warning (as error due to treat warnings as error setting):
1>(CliServiceCollectionExtensions).g.cs(51,40): Error CS0436 : The type 'CliServiceProviderExtensions' in 'DotMake.CommandLine.SourceGeneration\DotMake.CommandLine.SourceGeneration.CliCommandGenerator\(CliServiceProviderExtensions).g.cs' conflicts with the imported type 'CliServiceProviderExtensions' in 'BugReport, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'DotMake.CommandLine.SourceGeneration\DotMake.CommandLine.SourceGeneration.CliCommandGenerator\(CliServiceProviderExtensions).g.cs'.

Here's a repo:
BugReport.zip

Thanks for the bug report. This is now fixed with v1.8.3:

Fixed "CS0436 : The type 'CliServiceProviderExtensions' in ..." compiler error when project is referenced by another project.
Generated Builder classes will be put in GeneratedCode sub-namespace of the definition class's namespace to prevent namespace pollution.
Global GeneratedCode namespace was already being used by delegate-model, now class-based model will use GeneratedCode sub-namespace.

Thanks, but adding InternalsVisibleTo (as we usually do with tests sattelite projects) still gets the same error.
Here's updated repo with DI extension usage (as in real project):
BugReport.zip

Ok v1.8.4 should now fix it completely:

Updated to latest daily build 2.0.0-beta4.24126.1 of System.CommandLine.

Fixed compiler error related to CliServiceProviderExtensions and CliServiceCollectionExtensions when project is referenced
by another project. Class conflict errors occur due to same namespace in different assemblies.
This can't be fixed via PrivateAssets in PackageReference because although default value is "contentfiles;analyzers;build",
source generator still flows to the parent project via ProjectReference and PrivateAssets="all" prevents flow of
source generator but it also prevents flow of "compile" so it becomes useless.
First attempt to fix (in v1.8.3), was making CliServiceProviderExtensions and CliServiceCollectionExtensions
classes internal but the problem resurfaces if user adds InternalsVisibleTo attribute in child project.
So we finally solve this problem, by detecting if current compilation is a parent project in the solution,
if so we do not inject feature extensions as they already come transitively from the child project.
This way we can also keep CliServiceProviderExtensions and CliServiceCollectionExtensions classes public.

Yes, now everything works fine. Thanks.
And thank you for such neatly done project - a pleasure to use.


Drivers module documentation

System information

**OS Platform and Distribution Linux Ubuntu 16.04
**Apollo installed from source
**Apollo version 5.0

I would like to know if there is any documentation for the 'drivers' module in the repo that I can refer to. I see there is fair documentation for other modules, but I do not see anything for drivers module. Please let me know

Drivers components most are adapted for the specifc sensor,get sensor data and tranfer to apollo data struct.You can get sensor product specification and open source driver to learn it.


Please improve streaming add support user-agent for streaming radio and get information audio tag song,author etc

Big thank's for streaming radio support
Please add support user-agent for streaming radio some station don't work without user-agent
and get information audio tag song,author etc
Thank's advance

For version 4.12, added support for stream titles (specifically the SHOUTcast style 'StreamTitle' tag), which will be displayed in the application title bar and systray tooltip when available. Also set the user agent string.


incus 6.4.0 can't find skopeo

Describe the bug
With incus 6.4.0 from nixpkgs-unstable:
The incus deamon is missing a path to a skopeo (and bossibly umoci) binary.
[user@system:~]$ incus launch docker:hello --ephemeral
Launching the instance
Error: Failed instance creation: Failed getting remote image info: OCI container handling requires "skopeo" be present on the system

Steps To Reproduce
Steps to reproduce the behavior:

Install incus and skopeo
add an oci remote: e.g. incus remote add docker https://docker.io protocol=oci
launch an oci container from the added remote: e.g. incus launch docker:hello -e

Expected behavior
incus finds the skopeo binary, converts the docker image and launches the container.
Notify maintainers

@adamcstephens
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.5, NixOS, 24.05 (Uakari), 24.05.20240821.224042e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/rc7vhx0w0hxz170r88i0s04n5b9rwqa9-source`

Add a :+1: reaction to issues you find important.

6.4 isn't available on stable release, and thus 24.05 has not received the necessary module updates. Stable users are highly encouraged to stay on the default LTS. For now if you want the latest releases you'll want to use unstable.
https://github.com/NixOS/nixpkgs/blob/28922c4421b4a8d8f583913607da4f6db59e65a2/nixos/modules/virtualisation/incus.nix#L59


[WIP] Devguide A1->A2 upgrade chapter (candidate)

@wardbell @naomiblack This PR contains the PhoneCat upgrade tutorial, which is the part that's furthest along. It also has the outline and some preliminary content for the wider Upgrade section. My question is do you want me to yank out everything except the tutorial from this PR?

I haven't looked yet. I want to. Hope Naomi beats me to it

hosted for review at https://ngdocsdev.firebaseapp.com/docs/ts/latest/guide/upgrade.html
still troubleshooting some issues with doc shredder but text is ready to review...

I think you missed a couple of the examples when you pulled phonecat out? I get errors from L164 of upgrade.jade and don't have the source under examples for
+makeJson('upgrade/ts/typescript-conversion/tsconfig.json', null, 'tsconfig.json')

or on L174 for
+makeJson('upgrade/ts/typescript-conversion/package.json', {paths: 'scripts'}, 'package.json', {otl: /(\"tsc.*)/})

Thank you @naomiblack and @bradlygreen! Just pushed an update addressing your comments.

This is live on the site and now in master. Thank you!


Change import EventEmitter.

Correct bug with Typescript 3.5.3:
Type 'typeof internal' is not a constructor function type.
No need to update the typescript of the lib.

Looks great, thanks!
@Romakita What do you think? Can we merge it and publish a new patch version of the package?

yes we can ;)


Cannot pip install from source on pypi

pip install --no-binary fails. It looks like this is because requirements.txt is missing from the source distribution tar archive at https://pypi.org/project/faster-whisper/#files.
Looking at setup.py, I think requirements.conversion.txt also needs to be included. It's not in the tarfile either.
Could you update pypi to include these files?
$ pip install --no-binary faster-whisper faster-whisper
Collecting faster-whisper
  Downloading faster-whisper-0.5.1.tar.gz (1.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.5/1.5 MB 18.1 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      Traceback (most recent call last):
        File "/home/t/temp/faster-whisper-source/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/t/temp/faster-whisper-source/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/t/temp/faster-whisper-source/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-5xq9gyu6/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 341, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-5xq9gyu6/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 323, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-5xq9gyu6/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 487, in run_setup
          super(_BuildMetaLegacyBackend,
        File "/tmp/pip-build-env-5xq9gyu6/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 338, in run_setup
          exec(code, locals())
        File "<string>", line 19, in <module>
        File "<string>", line 15, in get_requirements
      FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-install-ugd4hpy_/faster-whisper_5f58a8920ea34e67a52797c9fdd6fb59/requirements.txt'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
$

Thanks for reporting the issue.
However, even after fixing this specific error, source installation is currently not possible because some dependencies do not provide a source distribution:

ctranslate2: https://pypi.org/project/ctranslate2/#files
onnxruntime: https://pypi.org/project/onnxruntime/#files


Update Wooting SDK, adding support for Wooting Two HE & Wooting Two Lekker Edition

List any issues that this PR fixes: fixes # , etc...

Fixes #2338 & #2317
This pull request proposes the following changes:

Deletes old Wooting SDK
Adds new Wooting SDK, which adds support for Wooting Two HE & Wooting Two Lekker Edition

I've updated the dll again to a slightly newer version, hope you don't mind. Thanks for contributing!


Confirmation of dependencies.

I tried setting up this library in my project as shown in the README but I got the following error:

Uncaught TypeError: Cannot read property 'createClass' of undefined
at:
var Cropzone = _fabric2.default.util.createClass(_fabric2.default.Rect, /** @lends Cropzone.prototype */{

I have not added any dependencies shown in the "dependency" section of README.
I could not tell whether "dependency" meant the libraries were included or needed to be included.
Please can you clarify this, and if not too much trouble update the README to make this clear.
An example would also be much appreciated, and any additional info on things such as if require/import can be used or setting to window is necessary would also.
Regards.

@goldingdamien
Okay, I'll clarify dependency meaning and add some tutorial/examples for users.


Add page finding to embedded browser.

Adding page find to embedded browser, useful for things like wiki pages.

Closes #108

Yes, indeed a good feature.


Export dist for 1.3.0.

Export dist for 1.3.0. I ran npm run dist on top of the v1.3.0 tag to do this.

Coverage remained the same at 97.47% when pulling dd7ae7b6c1fe12a50b06343093db92d1bc1a39cd on CRogers:feature/dist-1.3.0 into 172e72d1b8e4cf1c78209b57e8fca3a71b0179c8 on Matt-Esch:master.

lgtm.


Add ability to change css output slug

Issue description:
I like the new css output, however I would like to change the slug from "kirki-styles" to something else.  Is it possible for you to add a filter so this is possible?
Version used:
(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
dev
Using theme_mods or options?
n/a
Code to reproduce the issue (config + field(s))
n/a

Done, you an now use the kirki_styles_action_handle filter. :+1:


Raise NamedSecurityInfo related exception using HR result.

Done.
Cherry-picked required commits from the PR. I have added RSpecs for the functionality implemented in the PR.

Can anyone take a look at Travis to identify the failure ?. The failures are not related to the changes made in this PR.

Yeah they all look network latency related. Might try rerunning travis later.

Thank you @Aliasgar16 for rspec test :)

I restarted the travis failure last night and now there are more timeouts, so I'm going to write travis off as unrelated on this PR.
@mwrock review?

@Aliasgar16 I'm curious, did you try running the unit tests without :windows_only ?

travis failures look temporal. Restarting them now.


Redirects in ITI-105

Section Number Identify the most specific section number the issue occurs (e.g. 4.1.2)
2:<IP_ADDRESS>.3
Issue Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.
The following text requires clients to follow redirects:
If the Document Recipient returns an HTTP redirect response (HTTP status codes 301, 302, 303, or 307), the Document Source shall follow the redirect, but may stop processing if it detects a loop. See RFC7231 Section 6.4 Redirection 3xx.
Redirecting on a POST transaction might not be safe. The linked RFC states:
"Automatic redirection needs to done with
care for methods not known to be safe, as defined in Section 4.2.1,
since the user might not wish to redirect an unsafe request."
Where Section 4.2.1 of the RFC defines a safe request as one that is read-only.
Proposed Change Propose a resolution to your issue (e.g., suggested new wording or description of a way to address the issue). The committee might simply accept your suggested text. Even if they don't, it gives a good sense of what you are looking for. Leaving this blank means you can't imagine how to resolve the issue, which makes it easier for the committee to admit they can't imagine how to resolve it either and leave it unresolved.
Allow clients to treat 3xx codes as an error.
Priority:

Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

good discussion point. This is not really associated with the Improvements project.

Ah, I see this has been in ITI-65 as well.


Specifying Alignment in Supervision

Hi,
I noticed that Lhotse allows specifying token alignment as part of the supervision , and that it is also handled in the speech_recognition.py of Lhotse.
However, I cannot find how or where this labelled alignment is utilised in K2 before/after passed to the Conformer model. Can you point me towards the correct direction?
Furthermore, if you have any literature on the topic to share, I will be grateful.
Thanks.

We are not using alignment information in training at present. The default alignment type in lhotse is word alignment; you may need framewise alignment information at the token level if you use BPE as modeling unit.

I see. Thank you for the clarification.
If I manage to get framewise alignment information at the token level, (for example Aishell's Mandarin lang_char), can you point me in the correct direction towards where and how the alignment information can be utilised?
My idea is to intercept the output of the Conformer and force the token at that labelled frame to be 1 and all other tokens to be 0, before passing to the intersection with the CTC graph. But, I am not sure about the pros and cons.
I can't find any literature (scholarly or not) about this idea, but I am probably missing the technical term here.

can you point me in the correct direction towards where and how the alignment information can be utilised?

One possible way is to use framewise alignment information for cross-entropy training. Note that you have to disable time warping in SpecAugment.

Thanks for sharing your advice.
Anyway, I will close this ticket now.


Encrypt: set default RSA key size to 1024 everywhere, using the RSA_KEY_SIZE macro

This pull request also fixes the problem described in #31, which was caused by the test key generated in RsaCheck() being too small for newer OpenSSL versions.

SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
I choose option 1.

Maybe define two macros?

RSA_KEY_SIZE was unused.


Update implementation status to reduce confusion

Closes #134. Closes #137. Closes #138. Closes #150.

I got sick of all the dupe pull requests so I figured it was time to make things clearer.

I can attest to having learned about tc39/proposal-dynamic-import, forgotten about it, having come to this repository, and felt seriously saddened thinking module-loading has had no progress since June. Merging this PR would significantly reduce bad-feels surrounding module loading, by providing some useful linkage to pertinent follow-up resources. Good PR, thanks domenic.


Updates to thread affinity to allow it for ProxyMutex

Using this change to track down #5943.
I would like for Continuations with thread affinity to have mutexes that also have thread affinity, but that blew up in the AIO code.

To make Continuation thread affinity, just use EThread::mutex as its mutex.

It is better to rewrite UnixNetVConnection::reenable(VIO *vio) within this PR, because it will also obtain the nh->mutex across EThread.
https://github.com/apache/trafficserver/blob/04982180df1de9996e9df207bae37ba200882096/iocore/net/UnixNetVConnection.cc#L778-L834

[approve ci]

[approve ci]

[approve ci]

[approve ci]

[approve ci]


As a user, I would like see the TOC on the right hand side of the documentation site always present when I scroll so that I can navigate the content easily.

Currently the TOC doesn't not move when the user scroll. For a long page, such as https://qiskit.org/documentation/apidoc/circuit_library.html, it is hard to navigate to different sections.

This will be fixed by either switching to a new Sphinx theme, such as Furo: https://github.com/Qiskit/qiskit_sphinx_theme/issues/232. "Won't fix" for Pytorch


Migrate Spark recipes from blaze

Blaze still holds our recipes for PySpark and SparkSQL in the old "just into" style.  These should be brought over to into and translated into append/convert style.

closed by #78


docs: update README.md

Which problem is this PR solving?

formatting

Short description of the changes

Fixed README.md formatting

Checklist

[x] Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@blumamir, updated 👌


[BUG] Can't build catalog from the ACCESS-MED containerised environment

Describe the Bug
The ACCESS-MED containerised environment is currently read-only, which causes the catalog-build command to fail when attempting to write or update the catalog.yml file located at access-nri-intake/data/catalog.
Steps to Reproduce

Use the access-med conda environment.
Run any catalog-build command.

Result: The command fails due to the inability to write to the read-only environment.
Additional Context
A potential solution is to introduce an argument that allows users to specify an alternative location for the catalog.yml file, which should be outside the squashfs container. Additionally, a symlink could be created at access-nri-intake/data/catalog, pointing to the desired writable location of the catalog.yml file.

@marc-white FYI

Fixed


Make hyperlinks in (and between) APIs more usable

As discussed in our meeting today, we want to make links in APIs more easily usable by client developers.
We discussed two approaches:

The runtime approach proposed by @andreasowczarek includes putting HTTP method, resource type, title, etc. in a hyperlink control object (beside the href property we already have).
The design time approach proposed by me includes pointing in the schema definition which includes the hyperlink description to the resource (type) definition (= path item, in OpenAPI), so client developers always know what they can do with the link.

Maybe there could be some way of combining both without too much overhead.

A while ago (during the development of OpenAPI 3.0) I made the proposal https://github.com/OAI/OpenAPI-Specification/issues/577, which basically allowed to add to an "interface" (which has mostly the same format as a path item, but without parameters) to a property with type: string and format: uri.
That proposal was not adopted in OpenAPI 3.0, but OpenAPI 3.0 now has a different way of specifying links (a links property in a response). We should verify whether using this fulfills our needs (which might be a reason to drive the adoption of 3.0 forward), or whether this needs extensions to be useful.

As discussed in our meeting today,

Others reading the guidelines won't necessarily know who "we" is.

we want to make links in APIs more easily usable by client developers.

There are two approaches I know of - html <a> and atom <link>.  My guess is @andreasowczarek's idea is akin to this with an additional "options" property to indicate the method.

OpenAPI 3.0 now has a different way of specifying links... We should verify whether using this fulfills our needs

A pre-requisite is having a clear stance on v3 in the guidelines and what it means to work with two major versions of this spec, which will be the reality for end users for some time.
The link object enables a very RPC style (operationRef). The last time I looked it's effectively the default design position (calling it link is somewhat confusing) and that will definitely (imo) impact tooling. I think Open API link's utility depends on what the guidelines are trying to make easy for developers. If it's to enable a style of approach like gRPC or Google Cloud's guidelines then it's pretty suitable for that. If it's a hypertext control, I suspect there's a bit of work to do, and may require the guidelines to recommend a profile of OAS link to veer away from implicit RPC.

Others reading the guidelines won't necessarily know who "we" is.

You are right. I'm wondering of how we (Zalando's API Guild aka the maintainers of this repository) can make it more visible to outside observers/contributors that we have bi-weekly Zalando-internal meetings where these issues are discussed (beside other topics).
I would say we should try to lay down the important arguments here in comments to issues, though sometimes we also have internal reasons which can't be shown in public.

There are two approaches I know of - html <a> and atom <link>.  My guess is @andreasowczarek's idea is akin to this with an additional property to indicate the method (akin to the "options" header).

You (as an employee of Zalando and member of the API guild) can look at our Rolling Agenda document, @andreasowczarek' presentation is linked from there.
We already have the href property for links in Rule #164, @andreasowczarek's proposal is to add some more (optional) attributes to allow clients at runtime to know what to do with a link. (method, type, accept, auth, title).

I'm wondering of how we... can make it more visible
You (as an employee of Zalando and member of the API guild) can look at our Rolling Agenda document, @andreasowczarek' presentation is linked from there.

One suggestion would be to make significant design improvements and proposals like this public.

From the meeting
We are closing this for now, as we don't see an urgent need right now. Can be reopened when the need arises.


samples: Fixes #1051

Passed updated view definition to bigquery.update() method.
Fixes #1051  ☕

@stephaniewang526 I checked the documentation at https://cloud.google.com/bigquery/docs/updating-views#update-sql and it shows code snippet prior to this commit. Do I need to update documentation separately?

@stephaniewang526 I checked the documentation at https://cloud.google.com/bigquery/docs/updating-views#update-sql and it shows code snippet prior to this commit. Do I need to update documentation separately?


use table alias as column alias for aliased table function

Summary of the changes / Why this improves CrateDB
handles part of #10387

If the table function is aliased the alias should be used.

Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Its been decided to defer this issue to 5.0, I am wrapping this up for now.
There is one testcase failure: TableFunctionITest.test_unnest_on_top_of_regexp_matches. Based on the chat with Jordi, the testcase should be good, but it exposes a small implementation bug in Crate which VALUES is an instance of TableFunctionRelation. With the change, this TC fails because the column name is aliased.

NOTE: VALUES() is not a table function
> They are used like a table, view, or subquery in the FROM clause of a query.

cr> select * from values(1);
UnsupportedFeatureException[Unknown function: values(1)]
cr> select * from (values(1)) as foo;
+------+
| col1 |
+------+
|    1 |
+------+
SELECT 1 row in set (0.040 sec)

Since VALUES() cannot be used in from clause without an alias, it can be deduced that it is not a table function.


api: Added Proposal for Discovery Endpoint idea (InfoAPI)

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
Add the proposal for unified endpoint discovery as per discussion in https://github.com/thanos-io/thanos/issues/2600.
I highlighted two options, but again up to the maintainers which one you choose, happy to work on any of the ones that we agree! 🎉
I was not sure what to put under work plan and there was no fixed format for proposals that I could find, might have missed it? I copied from some existing ones if there is anything missing let me know! 🙂

cc @bwplotka @brancz

cc @bwplotka @brancz

Are we ready for another review round? 🤗

Are we ready for another review round? 🤗

No sorry, I was extremely busy with other company internal things and did not have a chance to address any of the comments yet. But will do it today! If this is super urgent to be implemented (e.g. this week) and someone has more time they can take over as well, let me know and I will close this out! Thanks for patience 😅

No sorry, I was extremely busy with other company internal things and did not have a chance to address any of the comments yet. But will do it today! If this is super urgent to be implemented (e.g. this week) and someone has more time they can take over as well, let me know and I will close this out! Thanks for patience 😅

Thanks @brancz, I had to force push as docs was complaining, but nothing changed apart from formating.
@bwplotka and others please have a look as well, thank you! 🙇♀

Thanks @brancz, I had to force push as docs was complaining, but nothing changed apart from formating.
@bwplotka and others please have a look as well, thank you! 🙇♀


Fixed model dumping in train_sequence

Fixed model dump

Modulus Pull Request
Description

Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


Unable to update

Looks like a rewrite was done on the master branch
$ brew update --verbose
[...]
==> git rev-parse -q --verify HEAD
4480fe4f12eeacf55d6f628898f3abcb9099e32a
git config core.autocrlf false
git pull --ff --no-rebase origin refs/heads/master:refs/remotes/origin/master
From https://github.com/caskroom/homebrew-versions
 ! [rejected]        master     -> origin/master  (non-fast-forward)
Error: Failed to update tap: caskroom/versions
[...]

Yep,
$ pwd
/usr/local/Library/Taps/caskroom/homebrew-versions
$ git fetch
From https://github.com/caskroom/homebrew-versions
 + 4480fe4...47159ca master     -> origin/master  (forced update)

Your branch and 'origin/master' have diverged,
and have 2737 and 2738 different commits each, respectively.

Thank you for the notice. Easiest solution is to brew untap caskroom/versions && brew tap caskroom/versions, and no harm done.
However, this shouldn’t be happening. Judging from the affected cask and the recent history, @fanquake have you done the rewrite?

However, this shouldn’t be happening. Judging from the affected cask and the recent history, @fanquake have you done the rewrite?

Yeah, and the extremity of the diverge is pretty worrisome.
I simply did a $ git fetch && git reset --hard @{u}, I suppose that's safe as well?

I simply did a $ git fetch && git reset --hard @{u}, I suppose that's safe as well?

Whatever works. Since the tap only holds casks, there shouldn’t be any repercussions regarding usage, so whichever solution you pick is fine, as long as it fixes it.

@vitorgalvao No, the commit modifying the emacs cask was done through the GitHub UI. So a rewrite shouldn't have happened.

Thank you. If any of @caskroom/maintainers did it, please do tell so we can confirm it came from user error and not github (wouldn’t be the first time we see github acting weirdly with commits), in which case we should report it. Something similar seems to have happened in the taps fonts.
No need to keep the issue open, though.

This worked for me brew untap caskroom/versions && brew update && brew cleanup --force -s && sudo rm -rf "$(brew --cache)" && brew tap caskroom/versions

On my end I'm seeing the divergence at https://github.com/caskroom/homebrew-versions/commit/d7f9062917ed5ff7bb7bfee8b3bdfd9ceb482711
master used to have https://github.com/caskroom/homebrew-versions/commit/28a022ba6e9cc0ff22e82000d1828715cdb11e31 follow it, but now I see https://github.com/caskroom/homebrew-versions/commit/8c415de2f34c684e058f5d03b7597f1b186d3df7 instead.
The change to the formula is the same, but the commit message was rewritten from:
Add TrueCrypt 7.1a

To:
 iQEcBAABAgAGBQJTi6fyAAoJEMUNS2x+QKQJYPoH/RngGb1BSrcB6VrT8JGKv2kS
 urv3zL9GnYvGKv4R78kU0bLLq8Iknh5okxp4EOAQqMsHAUSLWKSCDv+84PE981rs
 ivhez2zHC0IIRzCBS3heXRPFtTpfIJWcDIhau4w5iAaLo/EIXd7SWBUBKvkGwbZ6
 a11tK8uJXTqXjDWDitWZYO01SxmCkCwA/6xp04ZS0ThSWc2iURvwVbrUS1rL7iMQ
 Jwe/WCY5emmX6EkcONa0kIUuK4Jeu3J7WMxliAS5fLZGEYkQHLjmFhzJShjIC/YB
 1wwaatrvHb1wVNtSsX07xLw11Jdi9Re50tzP2CtJ3j/SbcoFI67sPRiu48j0tag=
 =L/fU
 -----END PGP SIGNATURE-----

Add TrueCrypt 7.1a

I think that it's me you have to blame, because I recently have overwritten the email address in some of my commits and have pushed by mistake to upstream/master instead of the origin/master. I apologize for all the inconvenience and troubles caused by this action. However, I'm sure that only my commits were affected.
There is no way to express how sorry I'm if that was me who caused so many troubles, but I've noticed that only recently. :bow:

brew untap caskroom/versions && brew tap caskroom/versions fixed it for me, so no worries. thx for the good work.

Confirming that brew untap caskroom/versions && brew tap caskroom/versions fixes the issue.

@vitorgalvao Thank you!

brew untap caskroom/versions && brew tap caskroom/versions fixed it for me too.

I fixed the same problem by just using brew update


Unknown variable "binlog-space-limit" error when using mysql:5.7 image.

Installed the cluster following this docs. I am using the mysql:5.7 image instead of the default percona MySQL image. I've also set volumeClaim in volumeSpec the cluster yaml, following this. But using this combination of image & own volumeClaim results in the following error:
2020-08-24 21:15:24+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 5.7.31-1debian10 started.
2020-08-24 21:15:24+00:00 [ERROR] [Entrypoint]: mysqld failed while attempting to check config
	command was: mysqld --verbose --help
	2020-08-24T21:15:24.711860Z 0 [ERROR] unknown variable 'binlog-space-limit=341M'
2020-08-24T21:15:24.717024Z 0 [ERROR] Aborting

I tracked the issue to the code here https://github.com/presslabs/mysql-operator/blob/288131ec062a1165c51562073b28443dbf59f26f/pkg/internal/mysqlcluster/defaults.go#L99
The variable "binlog-space-limit" does not exist for MySQL 5.7 config. Can this check on volumeClaim to set the variable "binlog-space-limit" be restricted to percona images only?
Operator version: 0.4.0

Hi @couch-potato08, thanks for reporting this. I will add an extra check to don't set that config based on the image.


Add vidyard support

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.12.01. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.12.01

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):
Vidyard homepage: https://www.vidyard.com/

Single video: ~~http://play.vidyard.com/MYsNEfzgpaB4w8xGWL2g7A~~
Same video embedded on another site: ~~https://www.purestorage.com/otb/ep1.html~~
Downloadable link to the same video: ~~http://cdn.vidyard.com/videos/Tty5gmS1jK8gPPatNZSCRg/full_hd.mp4?5R1bEOiBmTPTd29ZHp6WJbAB2_2Ffz6As5zIVJlFfEBx5r0B6ZGGus0ZpcRiljHOZi7zRLk4BSgvU5-1SIv7pJHEfwz6XHojWyhk0kwVpPMqF94~~
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Edit: These all 404 now, see link in the comment below.

Another video: https://play.vidyard.com/wVn1pCABE7RbkAHm6vNuFu.html

Here is an example of an embedded vidyard video:
https://tidelift.com/subscription/webinar/watch/idc/thank-you
Attempted download with version 2020.09.06:
[generic] thank-you: Requesting header
WARNING: Falling back on generic information extractor.
[generic] thank-you: Downloading webpage
[generic] thank-you: Extracting information
ERROR: Unsupported URL: https://tidelift.com/subscription/webinar/watch/idc/thank-you

Another example, don't know how long it will be up:
https://em.barracuda.com/dc/kQ4nJk0QPyKZ4SUJ7_SxXt5LxMtfeeBvSLuLU1XILns8CEPhzxEdmypT2QgdyO0BZ01AtlyQVDnRh-S_bbbY8AW97JajKGaDYYVqx7MGKk7ZIIuNa_8vwImzCaexv8AP/U1mC0bC02K0BmI01sV000Oj
youtube-dl 'https://em.barracuda.com/dc/kQ4nJk0QPyKZ4SUJ7_SxXt5LxMtfeeBvSLuLU1XILns8CEPhzxEdmypT2QgdyO0BZ01AtlyQVDnRh-S_bbbY8AW97JajKGaDYYVqx7MGKk7ZIIuNa_8vwImzCaexv8AP/U1mC0bC02K0BmI01sV000Oj'
[generic] U1mC0bC02K0BmI01sV000Oj: Requesting header
WARNING: Falling back on generic information extractor.
[generic] U1mC0bC02K0BmI01sV000Oj: Downloading webpage
[generic] U1mC0bC02K0BmI01sV000Oj: Extracting information
ERROR: Unsupported URL: https://em.barracuda.com/dc/kQ4nJk0QPyKZ4SUJ7_SxXt5LxMtfeeBvSLuLU1XILns8CEPhzxEdmypT2QgdyO0BZ01AtlyQVDnRh-S_bbbY8AW97JajKGaDYYVqx7MGKk7ZIIuNa_8vwImzCaexv8AP/U1mC0bC02K0BmI01sV000Oj

Another example, don't know how long it will be up:
https://em.barracuda.com/dc/kQ4nJk0QPyKZ4SUJ7_SxXt5LxMtfeeBvSLuLU1XILns8CEPhzxEdmypT2QgdyO0BZ01AtlyQVDnRh-S_bbbY8AW97JajKGaDYYVqx7MGKk7ZIIuNa_8vwImzCaexv8AP/U1mC0bC02K0BmI01sV000Oj
youtube-dl 'https://em.barracuda.com/dc/kQ4nJk0QPyKZ4SUJ7_SxXt5LxMtfeeBvSLuLU1XILns8CEPhzxEdmypT2QgdyO0BZ01AtlyQVDnRh-S_bbbY8AW97JajKGaDYYVqx7MGKk7ZIIuNa_8vwImzCaexv8AP/U1mC0bC02K0BmI01sV000Oj'
[generic] U1mC0bC02K0BmI01sV000Oj: Requesting header
WARNING: Falling back on generic information extractor.
[generic] U1mC0bC02K0BmI01sV000Oj: Downloading webpage
[generic] U1mC0bC02K0BmI01sV000Oj: Extracting information
ERROR: Unsupported URL: https://em.barracuda.com/dc/kQ4nJk0QPyKZ4SUJ7_SxXt5LxMtfeeBvSLuLU1XILns8CEPhzxEdmypT2QgdyO0BZ01AtlyQVDnRh-S_bbbY8AW97JajKGaDYYVqx7MGKk7ZIIuNa_8vwImzCaexv8AP/U1mC0bC02K0BmI01sV000Oj

Since 2016, this issue is still opened? did anyone get a fix? I want to download this vid -https://play.vidyard.com/ZKXHwfjf1MtezrxwjKGs5h

I can download from vidyard, but I believe there is an access control mechanism that checks the Referer HTTP header.
For instance:
 youtube-dl "https://cdn.vidyard.com/hls-videos/wYIcVOmXXMuf1hAslXUlOw/stream_master_6u7VYEhHHbx5aZtD4wGGrQ.m3u8" --add-header "Referer: https://play.vidyard.com/"

youtube-dl https://play.vidyard.com/ZKXHwfjf1MtezrxwjKGs5h --add-header "Referer: https://play.vidyard.com/"
@matiya this is not working for me

For that video, the following should work:
youtube-dl "https://cdn.vidyard.com/hls-videos/ArwxsclFb9I2YAILazF3LA/sd_segmented/sd_segmented_zXn2vRofmYWaDPMN46AfNA.m3u8" --add-header "Referer: https://play.vidyard.com"
I'm not an expert, but I think the .m3u8 is a playlist and in order to get it, you can open the network connections in the developer tools of the browser.
I believe youtube-dl could automate this.

Yep; all youtube-dl needs to do is find the stream_master URL  (i.e. https://cdn.vidyard.com/hls-videos/fWSBwUuZPHpnh3HhjgXzFg/stream_master_5ZbxuIQGkGsDiBvSQ11C-Q.m3u8?BMvc0VjC4BMUKTj2kp0sz-7Tva-ygg0y7o0M1bNkWHCAlnjxRXi-uIaLfF7OCXSB0viEpLnWYajbdHVIvHLsdGJMldvdLGjH10hURA20YLMFbpWpjOvHL_MUl5-e8KDeq6RxHBt56ZJiDwED78K6wja50vizr5wBPV6c6sB58lFlvCODqmimPaFC6QgAQSHX9AWC) then add the referrer (--add-header "Referer: https://play.vidyard.com") and it should always work. Just confirmed with several URLs:

.

Here's another url: https://play.vidyard.com/urAKCbwcLunhRfGdnQt2rT.html
The command-line that worked for me:
youtube-dl 'https://cdn.vidyard.com/media/hls/mHt17oCX28b7JMxgtAtYBA/,full_hd,hd,480p,sd,.mp4.urlset/index-f2-v1-a1.m3u8' --add-header "Referer: https://play.vidyard.com/urAKCbwcLunhRfGdnQt2rT.html"

Ditto. The way to do it seems to be to access the video playback from DevTools (Chrome) and see what URL the network is sending requests for segment-{NUMBER}. Then you replace it in the download section as @jnahmias showed - the unique ID that's in the network goes to the first url, and the original .html ID goes as the referrer

Searching for master.m3u8 in devtools worked fine.  You can observe the headers needed there. Just the referer was sufficient for me.

actually, it's much easier to get the URL from the vidyard JSON. For example, using curl and jq:
$ curl --silent --show-error --fail https://play.vidyard.com/player/urAKCbwcLunhRfGdnQt2rT.json | jq -r '.payload.chapters[0].sources.mp4[] | select(.profile == "1080p") | .url'
https://cdn.vidyard.com/videos/mHt17oCX28b7JMxgtAtYBA/full_hd.mp4?WacwzqupUNYvK0u-RpqrcdDCnv6gMO-LW8uWAI3bHLpHfksSB_jpJakZfu7R2FZxRU_C6xnSAuMhoMvO_NoE4g4280IX28KUjifG9xn6oBrTdX-n1fTyhFV69hywKbQsxZJ8uF_1QgjNkLhKtqEz4Nw

Then you just download that URL with an appropriate referrer:
$ curl --head --referer https://play.vidyard.com/ https://cdn.vidyard.com/videos/mHt17oCX28b7JMxgtAtYBA/full_hd.mp4?WacwzqupUNYvK0u-RpqrcdDCnv6gMO-LW8uWAI3bHLpHfksSB_jpJakZfu7R2FZxRU_C6xnSAuMhoMvO_NoE4g4280IX28KUjifG9xn6oBrTdX-n1fTyhFV69hywKbQsxZJ8uF_1QgjNkLhKtqEz4Nw
HTTP/2 200
content-type: video/mp4
content-length:<PHONE_NUMBER>
x-amz-id-2: iz0w+n6ZLpMjJIKoKldpyPq7HBDeYSa1WyQj/EUyq7HCvZNTxTsP16Uq0AbpEb2ZAaw26ChwNU4=
x-amz-request-id: 6EBDV6Y54JR5C90R
date: Tue, 04 Jul 2023 21:14:18 GMT
last-modified: Fri, 23 Jul 2021 20:31:32 GMT
etag: "e995e2345abc4224649e7f830768fa98-298"
x-amz-storage-class: GLACIER_IR
x-amz-server-side-encryption: AES256
content-disposition: attachment
x-amz-version-id: WFrigakfilZPROrqupngELRYA8H9.Iau
accept-ranges: bytes
server: AmazonS3
x-cache: Miss from cloudfront
via: 1.1 957a0e737a088bdc07cb5cc9dcc9e826.cloudfront.net (CloudFront)
x-amz-cf-pop: EWR53-P1
x-amz-cf-id: D25vNCPQsiXUWCI2NXgXteK2wEpGch_FybYxKLRsJE2uZo0cVqVLsg==
x-cdn: cloudfront
vary: Origin

Note: remove the --head to actually download the file.


Deploy assumes there is an SSH endpoint to connect to

When running python acs.py deploy -c myconfig.ini for the first time the operation fails on

Traceback (most recent call last):
File "acs.py", line 66, in
main()
File "acs.py", line 27, in main
acs = ACSUtils(options.config_file)
File "/Users/tero/repositories/timesiege/deployment/cloud/acs-scripts/acs/acs_utils.py", line 31, in init
self.ssh.connect(self.getManagementEndpoint(), username = self.config.get('ACS', "username"), port=2200)
File "/Library/Python/2.7/site-packages/paramiko/client.py", line 283, in connect
to_try = list(self._families_and_addresses(hostname, port))
File "/Library/Python/2.7/site-packages/paramiko/client.py", line 187, in _families_and_addresses
addrinfos = socket.getaddrinfo(hostname, port, socket.AF_UNSPEC, socket.SOCK_STREAM)
socket.gaierror: [Errno 8] nodename nor servname provided, or not known

This is most probably due to the fact that acs_utils.py has init that tries to open an SSH tunnel to an endpoint that does not (yet) exist:
self.ssh = SSHClient()
self.ssh.load_system_host_keys()
self.ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy())
self.ssh.connect(self.getManagementEndpoint(), username = self.config.get('ACS', "username"), port=2200)
self._configureSSH()

Reading the deployment commands, it clearly is intended to create everything from scratch including the resource group and all management endpoints. Therefore I think this is a bug in the script.

Thanks for the patch :-)


How to re-request review

I would like to know how can I re-request reviews. it seems there is no way to do this with the current version.

@phbissiwu It depends on when you'd like to trigger the GitHub action. If you watch the following events,
on:
  pull_request:
    types: [opened, ready_for_review, reopened]

when you get a PR back to draft, then make it ready for review again, the action will be triggered, so it'll re-request reviews. If you don't like such a workflow and embed a command in a commit, there's no way at this moment.

@phbissiwu It sounds like you could use Labels to trigger the action to re-assign reviewers:
on:
  pull_request:
    types: [labeled]
jobs:
  build:
    if: ${{ github.event.label.name == 'ReviewRequest' }}
    runs-on: ubuntu-latest

Mostly copied from: https://github.com/necojackarc/auto-request-review/issues/57#issuecomment-1046108267
Thanks to @gdegirmenci

I think we can use GitHub Actions' default ways to trigger or retrigger any actions, and those should be sufficient, so I'm closing this issue. Let me know here if you think we should add some features to the action itself.


nls web story

The idea here is that we use the unpkg service to unpack and provide the AMD modules that Core can require.
Pairs with: https://github.com/microsoft/vscode-unpkg/pull/40

@TylerLeonhardt Seems like the tests trip:

I'm leaving this in draft until the unpkg PR goes in.. but @joaomoreno @alexdima you're welcome to review.


This is not an issue but a compliment

Hey guys!,
I wanted to let you know, pro game developer here! I want to let you know i make html5 games for a living. I know my canvas but i'm step by step recreating the PIXI engine just to train my self in private to get more effective. This should be a compliment to the devs here .. My engine half in size is here https://github.com/prophecyjs/Engine ..
Thanks guys  !!
PS: I already deprecated Graphics.lineAlpha because i have a dedicated color class based on rgba  .. See https://github.com/prophecyjs/Engine/blob/master/src/core/color/Color.js

Good luck @johnnymast! And if you find anything while going through the PixiJS source to share, please consider making contributions back as we prepare for v5 (next branch)!

well considering i'm recreating the engine to advance my knollage i see a load of redundant calculations and calls. I will report on this soon .. its like what i said before i made my color class hold the alpha RGBA (right) so its not needed for the graphics class to hold its own alpha i'm aiming to use this color class on more places as well to save kb's in the compiled result. An other redundant calculation could the Container rect bounds .. In the most usecases is almost never used .. so i didn't implement it (YET)  Okey i don't implement WebGL yet but i guess thats not much of a change.

Color class?


FW landing project virtual waypoint to handle landing overshoot

No obvious regressions in a simple landing test. https://github.com/PX4/Firmware/pull/8985
Ideally we need a way to force an overshoot.

Here's one where I set the landing angle unrealistically high.

@dagar Will review this tomorrow morning!

@dagar Have you ever thought of splitting this up into several files?

Not really, but that might help. I feel like a lot of it could probably be condensed a lot better. For example when handling the manual position mode we could be first generating the setpoint, then going through the exact same control_position code as regular navigation. Likewise for takeoff after altitude/airspeed is achieved and several other cases.


Higher precision for unix_lat

I always get 1us latency for small packets.
I've made a local hack to cast delta as double, and actual value is 1.6us on my machine.
Perhaps it's something to consider?

I updated the measurement resolution to nanoseconds.


Alfred ignores field overrides when called from repeater matrix template

Hi Bernhard,

I have an image field named image_content_half. Let's say I have filled its note field with value "Foo".
I have a Repeater Matrix type text_image which is using this image field. From the fields list for text_image I have overriden the notes of the image_content_half field to "Bar".
I am rendering my matrix field as suggested: {$rockfrontend->render($page->matrix)}
Inside the template for my Repeater Matrix type (/site/templates/fields/matrix/text_image.latte) I am calling Alfred for the particular field:

...
<div class="bla" {alfred($page, ['fields'=> 'image_content_half'])|noescape}>
  <img ...>
</div>
...

I would expect the field notes of image_content_half to show the override value "Bar" but instead it shows the original value "Foo"
(this is not only the case with notes, but basically with any override including e.g. required property)
(when editing via ProcessWire admin the field overrides work correctly)

RockFrontend 2.9.1, RepeaterMatrix 0.0.8, ProcessWire 3.0.200
Am I missing something or is this a bug?
Thank you in advance.

Hey @stizzlestizzle I'm not sure if that is related to RockFrontend. RockFrontend/Alfred is only showing the page editor in a modal window. You can also click on the edit icon and open that page in a new tab. You can then also remove the ?modal=1 (or similar) to get the regular page editor with header + footer of the PW backend.
I think the most likely issue is that maybe it's a bug with RepeaterMatrix that when it is opened via custom url (?field=my_repeatermatrix_field) it does not apply field overrides?
Is that what describes your issue?

Thanks for getting back so quickly.
You are correct: Opening directly https://.../processwire/page/edit/?id=1304&fields=image_content_half does indeed also ignore the field overrides.
Closing this issue.


Unpredictable Trezor communication hangups

Unfortunateley, I have to create this issue.
To besure, the reason is not a bad USB cable, I just today bought a new one at the computer store. But the instability is the same. I am wondering, if other users are facing the same issue. It's a long standing issue for me also with mytrezor.com which I nearly cannot use, because the sending of transactions only works in 1 of 5 tries or so, and if it works or not, seems to be random. In most of the tries, is does not. I cannot reproduce the missbehaviour, neither I can reproduce the succes case.
I have a big deversity of hangup situations.
The most stable way to unlock the Trezor with MBHD is to boot the PC with Trezor disconnected, then start MBHD, select language, wait for the welcome screen topics, and the connect the Trezor. I had have now great 7 times or so in a row that was successful, I was already thinking that would stable work. But just now, I had again a case, where it hangsup on the screen "Requesting Trezor unlock". See screenshot.

What almost never works, was the case, when after successfull unlock as described above, to exit MBHD, wait 10 s and then start MBHD again. Then the unlock never worked, until... just before some minutes. Surprisingly I did not have to enter the PIN again, only confirm the unlock request by MBHD. But I am sure that is a feature.
But afterwards, I exited MBHD and started it again with still connected Trezor, and now, it is not detected anymore, instead the welcome screen appears after language selection, with the suggestion "Connect Your device...". So I disconnect the Trezor, wait 10 s, connect it again, MBHD say it detectet the Trezor, then comes "Requesting Trezor unlock", but this time there is absolutely no action on the Trezor display. In other cases, at least there is the "Waking up" progress bar with turning gears, until 100% is reached and the the communication freezes, the gears standing still.
So, in short, there are many combinations of misbehaviour, which I am unable to reproduce, they seem to happon randomly and unpredictable. I am just happy, if at one time, it works. But I cannot reproduce the success cases.
I really would like to help to solve this issue, since after I had this issues also at mytrezor.com my hope was that MBHD would not have this problems. Maybe my Trezor is broken? I tried now with three USB cables- one I had on my own, the very short one delivered with the Trezor, and now the one I bought today. So the cable should not be responsible.
The Ubuntu udev rules it seems I do not require, the permission slook good:
crw-rw---- 1 root plugdev 180, 0 Mai 15 14:30 /dev/usb/hiddev0
Maybe it is a OS issue with udev / hotplug whatever.
My OS is Debian 8 "Jessie" amd64.
But I faced the same issue with Debian 7 "Wheezy" x86 before, so it seems not be an OS issue.
So please tell me how I could help You debugging this.
I also created a support cas at Satoshi Labs some months ago, but the support was very very poor, the best conclusion I remember was "we had other users reporting this issue, also".
Trezor firmware is 1.3.3. I had the same issue with firmware version before that version.
On mytrezor.com, I think the unlocking nearly always works, only sending coins in most cases does not work, when it hangs on "Signing transaction"
Maybe I should buy a new Trezor to check if my current is just broken somehow?

You're correct that the short USB cables that come with the device have intermittent data problems, but using any standard mobile micro-USB cable usually sorts that out which implies that you're seeing something weird.
Fortunately, we have the error reporting system availalble now.
Can you unlock any wallet (Trezor or not), go to the Help screen and click the Report Error button. Reference this issue in the user notes (e.g. See #565 for details). Click upload. This will allow us to see your logs securely which will give us a lot of under the covers details about your issue.
You can then click Cancel and carry on as normal (no restart required).

Thank You very much. So here what I've done:
Start MultiBit HD without Trezor connected. Tried to get to the help screen. Did not manage that. Shutdown MultiBit HD. Startedt it again. I had now suddenly to accept the license, which I hade not to do since weeks. Accepted it. Welcome topics appeared. Connected Trezor. Trezor detected. Entered PIN. Trezor hangup, screenshot the same as originally posted. Exit. Disconnect Trezor. Wait 10 s. Start MultiBit HD again. Select language.  Connect Trezor. "Trezor detected" message.  Click Next. Hangup. Shutdown MBHD, disconnect Trezor while MBHD is in shutdown state. Wait 10 s. start MBHD with disconnected Trezor. Select language. Connect Trezor. "Trezor detected". Click Next. Enter PIN. Trezor unlocked. Now in the MBHD dashboard. Disconnect Trezor. Got Help. Click "Report error". Upload success. Click "Cancel". Exit MBHD. Thanks again!

Thanks for persevering! Sounds like your Trezor is giving you some trouble. I'll take a look at the error reports over the weekend (assuming I get some free time) and see what's causing this.

I've had a chance to look at the uploaded logs and there is no communications error showing up - packets are definitely written successfully to the USB buffer. The logs indicate correct detach of device and match the sequence described above.
The normal request/response sequence to unlock is:

CREDENTIALS_REQUEST_MASTER_PUBLIC_KEY (to form deterministic hierarchy)
CREDENTIALS_ENTER_PIN_FROM_MASTER_PUBLIC_KEY (Optional)
CREDENTIALS_REQUEST_CIPHER_KEY (to form password)
CREDENTIALS_ENTER_PIN_FROM_CIPHER_KEY (Optional)
CREDENTIALS_PRESS_CONFIRM_FOR_UNLOCK (to confirm unlock)

There seems to be a hang occurring inconsistently after 1 or 3 above. One commonality is the expectation that the device will respond with a PIN matrix request. A quick test involving removing the PIN from one of our test devices and restarting yielded a smooth Unlock experience (as expected).
We regularly test this code with a range of devices and have seen consistent smooth behaviour on OS X. However, it may be that your system has an unusual set up that could lead to this behaviour. If possible it would be worth testing the same device on a different operating system.

I'm going to mark this as closed for now since there's not anything I can do to fix it. However, I'm OK with re-opening it should there be more supporting evidence for the behaviour.


MaterialEditTextPreference issue

Hi,
Im trying to use MaterialEditTextPreference in one of my projects and when I try to open the fragment which the Preferences is inserted, it crashes with a class not found error. Im compiling version 8.5.4

Unable to reproduce.
You're using an old version of the library, too.

What version should I use? Im following the tutorial on github
On Feb 26, 2016 7:21 PM, "Aidan Follestad"<EMAIL_ADDRESS>wrote:

Unable to reproduce.
You're using an old version of the library, too.
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/975#issuecomment-189506665
.

The latest version is always shown at the top of the README documentation, and on JitPack

Tested this issue agaim, follow below the output:
compile('com.github.afollestad.material-dialogs:core:<IP_ADDRESS>@aar') {
transitive = true
}
08:04:10.449 8096-8096/AndroidRuntime: FATAL EXCEPTION: main
    Process:  PID: 8096

    android.view.InflateException: Binary XML file line #5: Error

inflating class
com.afollestad.materialdialogs.prefs.MaterialEditTextPreference
Caused by: java.lang.ClassNotFoundException: Didn't find class
"com.afollestad.materialdialogs.prefs.MaterialEditTextPreference"
On Fri, Feb 26, 2016 at 8:21 PM, Aidan Follestad<EMAIL_ADDRESS>wrote:

The latest version is always shown at the top of the README documentation,
and on JitPack
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/975#issuecomment-189523189
.

--

Cássio Nicolai Bruzasco

The preference classes are in Commons. See the documentation.

Thanks for your instruction. I was used to only use material dialogs that I
didnt even realised that Preferences was in another component.
Thanks very much and take care :)
On Mon, Feb 29, 2016 at 12:49 PM, Aidan Follestad<EMAIL_ADDRESS>wrote:

The preference classes are in Commons. See the documentation.
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/975#issuecomment-190264364
.

--

Cássio Nicolai Bruzasco


feat: check out latest tag

Instead of getting main, check out the latest tag when running install.sh
List the full command when explaining how to use NONINTERACTIVE

look nice

finsih !! bravo nexus!


[ML][Pipelines] feat: keep original empty display name for component

Description
Previously we use node name as default display name for anonymous component to avoid displaying them as "azureml_anonymous". Given we may keep original component name now, we remove this logic to avoid blocking component reuse.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

last three


Rare Drop Notifications at New Bosses

The rare drop notifications have not been screenshotting and sending to the webhook for all 4 new bosses.

Beyond updating monster_drops.json, to support Whisperer loot, LootReceived event must be used (rather than NpcLootReceived), as we discovered in https://github.com/pajlads/DinkPlugin/pull/286

Having same issues with whisperer, not picking up loot into discord.


[Discussion] Frontend progressive migration to Typescript

I would like to propose to start migrating the frontend codebase from Javascript to Typescript. Typescript is a superset of javascript that provides optional static typing, classes, and interfaces. Thus, any Javascript code can be run as Typescript code.
Advantages
Some advantages of using Typescript over Javascript are:

Its considered a way of testing: although it is not a replacement for testing, it can help finding bugs thanks to type checking. e.g. if a Component expects a number as a prop and receives a string or null it fails at compile time, while Javascript would not only not fail but also introduce unpredictable behavior. Generally, it allows finding errors earlier.
Intelligent code completion: both for writing general code and also for writing React component in tsx files, as component properties are defined statically.
Code is easier to understand: specially in an open source environment, where we want developers to easily understand what the code does to start contributing. There would be a contract between each part of the application regarding how they communicate with each other, going from what the frontend expects to receive from an API call to the props that a functional component should receive.
As Typescript is widely used nowadays, major libraries like the ones that we currently use in the frontend has support for Typescript (i.e. types are published) like React itself, Redux, MUI, React Testing Library, etc.
Migrating to Typescript could be also an opportunity to developers that want to contribute to an open source project (lots of good first issues). Other open source projects have done this receiving feedback from the community, specially for deciding whether to actually migrate to Typescript or not: see this PR from the Jest repo and this page for a long list of examples.
Refactoring is way easier as it can be done with confidence of not breaking other parts of the code.

Migration
Migration can be done gradually. There are official migration guides and several open source projects that successfully did such a migration.  A step to step of the migration could be as follow:

Start by adding the typescript compiler: as ts is a superset of js, the compiler can compile the current source code and already give some advantages like being sure that the number of parameters passed to a function are equal to the number of parameters that the function expects.
Start migrating the code base. I would suggest to start by the Redux state as it is where the majority of types have to be defined. Migrating react components should be straightforward.
Select a convention for new code: new code should be written in typescript, if the new feature has to make changes in pre-existing source files, migrate them as well.

The first step of the migration has been completed as #318 was merged with the main branch. The next step is to finish migrating the frontend source code. Quite a lot of files have yet to be migrated, thus I'll create several issues to ask help for finishing this task. From now on, new code should be written in typescript. Here is a list of the files that have yet to be migrated:

js files:

./src/features/PrivateRoute.js
./src/utils/notification.js
./src/utils/test-utils.js
./src/config.js
./src/components/dropdown/Dropdown.js
./src/components/combobox/ControlledSelect.js
./src/api/client.js
./src/modules/Workspace-config/__tests__/test_worspaceConfig.js
./src/modules/Workplace/sidebar/components/commonComponents.js
./src/modules/Workplace/PanelManager.js
./src/modules/Workplace/__tests__/test_upperbar.js
./src/modules/Workplace/__tests__/test_workspaceInfo.js
./src/modules/index.js
./src/setupTests.js
./src/error/useErrorHandler.js
./src/error/errorMiddleware.js
./src/error/errorHandler.js

jsx files:

./src/components/pagination/CustomPagination.jsx
./src/components/pagination/ArrowsOnlyPagination.jsx
./src/components/buttons/ButtonLight.jsx
./src/components/buttons/ButtonLogout.jsx
./src/components/buttons/LoadingButtonIBM.jsx
./src/components/combobox/Combobox.jsx
./src/components/combobox/ComboBoxWithInputText.jsx
./src/components/SupportIconsBar.jsx
./src/components/dialog/index.jsx
./src/components/bars/upperBar/ButtonAppBar.jsx
./src/components/Keyboard.jsx
./src/theme.jsx
./src/modules/Workspace-config/WorspaceForm.jsx
./src/modules/Workspace-config/ExistingWorkspaceForm.jsx
./src/modules/Workspace-config/LoadDocumentForm.jsx
./src/modules/Workspace-config/index.jsx
./src/modules/Workspace-config/NewWorkspaceForm.jsx
./src/modules/Workspace-config/DeleteWorkspaceModal.jsx
./src/modules/Workplace/sidebar/SuspiciousLabelsPanel.jsx
./src/modules/Workplace/sidebar/ContradictingLabelsPanel.jsx
./src/modules/Workplace/sidebar/LabelNextPanel.jsx
./src/modules/Workplace/sidebar/SearchPanel.jsx
./src/modules/Workplace/sidebar/AllPositiveLabelsPanel.jsx
./src/modules/Workplace/sidebar/Element.jsx
./src/modules/Workplace/sidebar/PosPredictionsPanel.jsx
./src/modules/Workplace/sidebar/EvaluationPanel.jsx
./src/modules/Workplace/tutorial/index.jsx
./src/modules/Workplace/tutorial/TutorialDialog.jsx
./src/modules/Workplace/tutorial/Arrow.jsx
./src/modules/Workplace/information/StatsContainer.jsx
./src/modules/Workplace/information/ModelErrorAlert.jsx
./src/modules/Workplace/information/DrawerHeader.jsx
./src/modules/Workplace/information/TabPanel.jsx
./src/modules/Workplace/information/ProgressBar/index.jsx
./src/modules/Workplace/information/Divider.jsx
./src/modules/Workplace/information/FileTransferLabels/TransferLabelsDialog.jsx
./src/modules/Workplace/information/ModelProgressBar/index.jsx
./src/modules/Workplace/main/MainPanel.jsx
./src/modules/Workplace/main/Element.jsx
./src/modules/Workplace/main/ShortcutsModal.jsx
./src/modules/Workplace/upperbar/UpperBar.jsx
./src/modules/Workplace/upperbar/CategoryCard.jsx
./src/modules/Workplace/upperbar/Modal/CreateCategoryModal.jsx
./src/modules/Workplace/upperbar/Modal/EditCategoryModal.jsx
./src/modules/Workplace/upperbar/Modal/DeleteCategoryModal.jsx

I've created issues that call for help on finishing the typescript migration. The followings are the issues.

[ ] #359
[ ] #360
[ ] #361
[ ] #362
[ ] #363
[ ] #364
[ ] #365

The typescript migration in now complete. Thanks to all of the contributors. No more javascript!


feat: Add esbuild to allowedPackageJsonDependencies.txt

There are existing esbuild-plugin in the DT repo currently, including one of my ongoing PR #70733. To facilitate adding or modifying these types in DT side, I would like to ask DT-tools maintainer to kindly accept and merge this PR.

This would be a pretty unfortunate dep to add in the repo thanks to just how many platform-specific deps this will pull in; is there no way to declare things such that this dependency is not needed?


Required prop types warnings

When I zoom with gestures on the touchscreen, I get errors in the console (I use chrome devtools with my phone as remote device):
Warning: Failed prop type: The prop `startX` is marked as required in `be`, but its value is `null`.
Warning: Failed prop type: The prop `startY` is marked as required in `be`, but its value is `null`.
Warning: Failed prop type: The prop `endX` is marked as required in `be`, but its value is `null`.
Warning: Failed prop type: The prop `endY` is marked as required in `be`, but its value is `null`.

This problem is repeated in the example:
https://jsfiddle.net/chrvadala/f67qyfsd/

Fixed with v3.1


Change Snippet from using &'static str

Speaking to people on #rust on IRC about compile-time generating &'static str values, where the values depend on a const parameter, we came to the conclusion, that the outputs and inputs function in NewSnippet should probably return Vec<String> or Cow<'static, str> instead of Vec<&'static str>. As it looks right now, we can implement outputs for Get<const N: usize> as vec!["element"; N], but if we want to show where each element is located on the stack, like vec!["element_3", "element_2", "element_1", "element_0"], we might need to change the interface of the inputs and outputs functions.

Closed by 632413d264dad314429c207fc5193615a7b8f2b0


Fix Kafka polling method

On previous polling implementation, when an exception happened during a poll, all of the messages consumed before the exception was thrown were discarded. The last offset/message pushed into the stream can be different, depending on how fast the broker and client exchanges messages and when the polling timer ran.

Wow, looks like a big change! I know we had discussed this but had no idea you were getting to work on it right away. Good stuff!

I'm wondering if thrown exceptions should be emitted on the next polling cycle instead of right away, to let the stream catch up with the messages, if it were to fail instead of resume/restart.

@Aaronontheweb Yeah, this is required to fix one of the racy specs, if not both.

Plus I need to update some of the specs since we changed the default stream behavior, rechecked that they should be doing what they were supposed to be doing

All of the partitioned source specs are failing @Arkatufus


set up BFO import job

extensions/go_bridge.owl contains BFO classes. We need a standard BFO import file pulling relevant classes and axioms (APs, disjointness) using these classes a seed.

Now we have Arachne running in Noctua, this is causing distracting high level inferences to show up in Noctua as well as in inferences.  Would be good to get this fixed before Corvallis meeting.


AF_PACKET: need to expose network interface from which packet was captured

Context: Host with several docker containers
Capture mode: AF_PACKET, all interfaces [i.e., bound to pseudo interface, capturing packets from all interfaces]
When running gopacket based app on a machine with multiple docker containers, its often essential to identify the interface from which the packet was captured, so that it can be tied back to the target container. Looking at the metadata information (or even the ethernet layer code), the network interface information is not exposed.
In the absence of this information, it is necessary to run the packet capture process on each virtual interface, which is highly inefficient. (https://groups.google.com/forum/m/#!topic/linux.kernel/3T8aWc_gLCc)
With AF_PACKET, its possible to monitor packets arriving on all interfaces using ifindex 0, and after the packet arrives at the userpspace, its possible to identify the specific interface using the sockaddr_ll.
Exposing this information in either the metadata or as part of some layer would be very helpful.

I think this is possible by looking at the sockaddr_ll section of the tpacket frame.
In https://www.kernel.org/doc/Documentation/networking/packet_mmap.txt it says:
   Frame structure:
   - Start. Frame must be aligned to TPACKET_ALIGNMENT=16
   - struct tpacket_hdr
   - pad to TPACKET_ALIGNMENT=16
   - struct sockaddr_ll
   - Gap, chosen so that packet data (Start+tp_net) aligns to TPACKET_ALIGNMENT=16
   - Start+tp_mac: [ Optional MAC header ]
   - Start+tp_net: Packet data, aligned to TPACKET_ALIGNMENT=16.
   - Pad to align to TPACKET_ALIGNMENT=16

The sockaddr.ll section could perhaps be extracted by performing:
// For V3 headers
var ll *C.struct_sockaddr_ll
//     Start at w.packet                           +  aligned size of w.packet
d := uintptr(unsafe.Pointer(w.packet)) + uintptr(tpacketAlign(int(unsafe.Sizeof(w.packet))))
ll = (*C.struct_sockaddr_ll)(unsafe.Pointer(&d))

sockaddr_ll.sll_ifindex will give the index of the interface, which can be mapped to a string at init-time by using ioctl with SIOCGIFNAME.

I believe this is now done.


Calculated column numeric sort issue

Bug Report
Steps to Reproduce:

Open table with numbers
Created a calculated column
Sort on calculated column

e.g. SIMUL Orders table, create percentage filled

Expected Result:
Sort on numeric values
Actual Result:
Sort as if its by alpha-numeric
99
100
0
0

Additional Context:
potentially server side sort for calculated column is treating it as a string?

Looks like that's related to the integer division:

in the percent filled we're dividing integer columns so the result is an integer -> but we specify the data type to be double. So in sort it tries value.asInstanceOf[Double], which fails and therefore sort doesn't get applied.
if we do something like filledQuantity * 1.0 / quantity, it works fine.

How do you guys think we should handle this?

One solution could be for the expression parser to take into account the column data type. Or easier solution is if we don't have any use-case for integer division we can treat all divisions as floating point divisions
Second, we could use a proper numeric conversion to double when applying sorts, but this might make it hard to investigate issues i.e. why for instance 5/2 and 4/2 are treated the same by the sort. We can add error logs when applying such conversions as a work around but still.

So I think resolving the casts would be good (oops my fault!). There is a whole set of literature on when we should widen data types in programming languages, as you rightly point out, these two:
=4/2
=5/2

would necessitate different data types to hold the result even with both having integer inputs. We could probably get away for the sort with some sensible heuristics (for example any operation involving a double numeric value or involving a division operator always results in a double result.)
Would be interested in your thoughts as well as @rumakt and @naleeha.
Chris

I think defaulting all division result to floating point on the server side make sense. Seem to be what Excel does as well.
If we were to cast the result back to int using value.asInstanceOf[Int], it truncates the decimal part which may not be what the user want depending on the scenario.
There is a secondary question of, once you have the calculated value, what do we want to display.
We could make this ui concern with the double decimal format setting

Excel seems to round up, e.g. 1.6 becomes 2 with 0 dp
Not sure what we do with our UI atm
I am a bit confused where the integer columns are in this case. Both Filled Qty and Quantity seem to be defiled as double in SIMUL Order table.

Yes, agreed. I think the display is catered for by Steve's UI widget as it forces them to consider the datatype (and therefore the accuracy.)


nginx-fancyindex: v0.4.4 -> v0.5.2

Add myself (aneeshusa) as a maintainer.

Motivation for this change
IIRC, I wanted access to fancyindex_show_dotfiles first available in v0.5.0.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[N/A] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[N/A] (Package updates) Added a release notes entry if the change is major or breaking
[N/A] (Module updates) Added a release notes entry if the change is significant
[N/A] (Module addition) Added a release notes entry if adding a new NixOS module
[N/A] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

cc folks who touched this in the past: @ajs124, @lzorkin