Cut v1.14.3-up.1

This issue can be closed when we have completed the following steps (in order).
Please ensure all artifacts (PRs, workflow runs, Tweets, etc) are linked from
this issue for posterity. Assuming vX.Y.Z-up.K is being cut, after upstream
crossplane/crossplane vX.Y.Z has been released
according to the declared schedule, you should have:

[x] Synced the release-X.Y release branch in upbound/crossplane, with upstream crossplane/crossplane release branch, up to the vX.Y.Z tag, adding any required change specific to the fork, see here for more details.
[x] Tagged upbound/crossplane vX.Y.Z-up.K from the release-X.Y branch by:

[x] Running the Tag workflow on the release-X.Y branch with the proper release version, vX.Y.Z-up.K. Use Release vX.Y.Z-up.K as message (FYI: the format suggested is only for consistency, there is no actual dependency on it).
[x] Running the CI workflow on the release-X.Y branch to build and publish the latest tagged artifacts.
[x] Confirm the image has been successfully published using: docker buildx imagetools inspect docker.io/upbound/crossplane:vX.Y.Z-up.K

[x] Created and merged a PR for upbound/universal-crossplane to either the main branch, if cutting a patch for the latest supported release, taking care to label it backport release-X.Y, or directly to the release-X.Y branch, if cutting a patch for an older supported release. With the following changes:

[x] Update any reference to the old latest release to vX.Y.Z-up.K, such as CROSSPLANE_TAG and CROSSPLANE_COMMIT in the Makefile.
[x] Run make generate to import any changes in the upstream Helm chart.

[ ] Cut UXP vX.Y.Z-up.K release from the release-X.Y branch by:

[x] Running the Tag workflow on the release-X.Y branch with the proper release version, vX.Y.Z-up.K. Use Release vX.Y.Z-up.K as message (FYI: the format suggested is only for consistency, there is no actual dependency on it).
[x] Running the CI workflow on the release-X.Y branch to build and publish the latest tagged artifacts.
[x] Verify that the tagged build version exists on the releases.upbound.io build channel, e.g. build/release-X.Y/vX.Y.Z-up.K/...

[x] Verify the produced helm chart available in the build channnel at build/release-X.Y/vX.Y.Z-up.K/charts by doing some sanity checks:

[x] Installs on a cluster properly with helm -n upbound-system upgrade --install universal-crossplane <path-to-chart.tgz> --create-namespace.
[x] Uses the correct image versions of upbound/crossplane, e.g. kubectl -n upbound-system get pods  -o yaml | grep image:
[x] Verify at least one of the above reference platforms works end to end by configuring and creating a claim, e.g. using https://github.com/upbound/platform-ref-gcp/blob/main/examples/cluster-claim.yaml:

[x] https://marketplace.upbound.io/configurations/upbound/platform-ref-aws
[ ] https://marketplace.upbound.io/configurations/upbound/platform-ref-azure
[ ] https://marketplace.upbound.io/configurations/upbound/platform-ref-gcp

[x] Upgrading from the latest supported version works, for example run:

create a kind cluster: kind create cluster
install the current stable version: up uxp install
install one of the above reference platforms
upgrade to this new version as above: helm -n upbound-system upgrade --install universal-crossplane <path-to-chart.tgz> --create-namespace

[x] Run the Promote workflow from the release-X.Y branch, to promote vX.Y.Z-up.K to stable, here you should find universal-crossplane-X.Y.Z-up.K.tgz. Verify everything is correctly working by running up uxp install against an empty Kubernetes cluster, e.g. kind create cluster, which should result in an healthy UXP installation with expected image versions.
[x] Drafted, validated with the rest of the team and then published well authored release notes for UXP vX.Y.Z-up.K. See the previous release for an example, these should at least:

[x] enumerate relevant updates that were merged in u/xp and u/uxp.
[x] mention the xp/xp version it refers to.
[x] list new contributors to u/uxp.
[x] have the links to the full changelog of u/xp and u/uxp.

[x] Ensured that users have been notified of the release on all communitcation channels:

[x] Slack: crossposting on Crossplane's Slack workspace channels #announcements, #upbound and #squad-crossplane on Upbound's Slack.
[x] Twitter: ask #marketing on Upbound's Slack to do so.

Released https://github.com/upbound/universal-crossplane/releases/tag/v1.14.3-up.1 !


Import fps controller

Import and configurate fps Controller
Change input settings for azerty keyboard

Bug fixing TODO

Player can see through wall when he is close to them
We need to precise collision checking when the player jump, sometimes he is on the void but he don't fall

TODO :

Avoir une chute moins violente
Eliminer les bugs de visions quand on est trop proche d'un mur.


Remap shortcut

Microsoft PowerToys version
0.69.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
Keyboard Manager
Steps to reproduce
Disclaimer : I'm not a programmer nor a coder and only understood a bare minimum of what it is.
That being said, I'm currently having some sort of factory-made error that makes shortcut [ shift + 2 = " ] and [ shift + ' = @ ] by default, instead of expected shortcut [ shift + 2 = @ ] and [ shift + _' = " ] as printed on my laptop's keycaps. I decide to do my own research to fix this by myself and that lead me to download PowerToys (version 0.68.0) in the github website, which helped me to rebind the keys to be as expected through out the months.
But after the update today, the remapped shortcuts doesn't work anymore, at first I thought it's caused by a third-party but doesn't seemed to be the case. I have deleted the old bindings to rebind them again, I have tried to remap other shortcuts into different shortcuts, and I have the remapping's set to all apps, but it doesn't work.
I'm very much confused as to how to show physical proof of this issue, consider that it's needed of a video recording for the example instead of a screenshot yet I'm uncomfortable in doing so due to personal reasons. I hope to be able fix this shortcut issue as soon as possible with guidance and suggestions, thank you very much for your time.
✔ Expected Behavior
faulty default shortcut [ shift + 2 = " ] and [ shift + ' = @ ] remapped into  [ shift + 2 = @ ] and [ shift + _' = " ] along with other mapped build shortcuts.
❌ Actual Behavior
It does not remapped shortcuts as intended.
Other Software
No response

I'm having the same issue - remapping win-shift-s (to win-shift-home, which is my ShareX shortcut) worked on 0.68.1, but after updating to 0.69.0 it wasn't working at all. Uninstalled and downgraded to 0.68.1 and it works properly again, so something broke in the update.

I'm having the same issue - remapping win-shift-s (to win-shift-home, which is my ShareX shortcut) worked on 0.68.1, but after updating to 0.69.0 it wasn't working at all. Uninstalled and downgraded to 0.68.1 and it works properly again, so something broke in the update.

It finally worked! Thank you very much with the suggestion!


Add a install extension button in Extension

[READ] Step 1: Are you in the right place?
Issues filed here should be about a feature request for a specific extension in this repository. To file a feature request that affects multiple extensions or the Firebase Extensions platform, please reach out to
Firebase support directly.
[REQUIRED] Step 2: Extension name
This feature request is for extension: Translate Text, but applicable to all other extensions
What feature would you like to see?
This is more UX, it's more intuitive and convenient to add some kind of addButton in the Extension page in order to add an extension. Everytime I want to add an extension, I have to go this page:
https://firebase.google.com/products/extensions?authuser=0
It's like entering the back of the car to get to driver seat.
How would you use it?
Well, at the moment, I'm trying to add several extensions. and I have to go thru the back of the car multiple times.

Hi @nonoumasy thanks for the feedback. Can you file a support ticket for this?

Support link: https://firebase.google.com/support/troubleshooter/report/features
Since this repo is just focused on the code for extensions themselves, filing a feature request with support will make sure that this platform-level feedback will find its way to the right spot.


[BUG] MySQL Connection doesn't work

Description
Unable to connect my MySQL database on a shared hosting server. Enabled remote access to the IP as specified in the data source page.
Steps to reproduce the behavior:

Click on + to add a data source
Select "MySQL"
Enter the host address, database name, authentication information (username and password)
Click test and the error throws up

PluginExecution failed with error Error connecting to MySQL: The server time zone value 'PDT' is unrecognized or represents more than one time zone. You must configure either the server or JDBC driver (via the 'serverTimezone' configuration property) to use a more specifc time zone value if you want to utilize time zone support.
Important Details

Version: Cloud
OS: Windows
Browser Google Chrome (v. 85.0.4183.102)

Server Information

Apache Version | 2.4.46
PHP Version | 7.2.33
MySQL Version | 10.2.33-MariaDB
Architecture | x86_64
Operating System | linux
Perl Version | 5.16.3
Kernel Version | 3.10.0-962.3.2.lve<IP_ADDRESS>.el7.x86_64

Hello @harishkotra, a way to address to problem has been released into Appsmith cloud and should be available to self-hosted instances as a release is created soon.
The problem is that the timezone set on the MySQL server is something that the JVM (Appsmith server) doesn't recognize unambiguously. So, the solution is the override the server timezone. We've added a new field in the MySQL datasource configuration UI at the bottom, in a section called "MySQL Specific Parameters" where you can set this override.
In your particular case, PDT is an ambiguous timezone and if the override field I mentioned above is set to something like PST or UTC, the connection should go through.
Let us know if you face further problems on this.


BE: Add Search and Filter APIs for Incident

Need add Search and Filter APIs for Incident. The API should be able to filter Incidents with District and Thana and search based on address property with full text search. The API should also be able to search Incidents with a given lat/lon pair.

Is this need to create api views for filtering and searching incidents? i want to work on it.


Description: Added Missing Descriptions and Preserve Views

Updated missing metadata descriptions and missing link preserve views.

Docs Build status updates of commit b36baa7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/contactgroupservices.md
:white_check_mark:Succeeded

Skype/UCMA/contacts-and-groups-management.md
:white_check_mark:Succeeded

Skype/UCMA/contacts-and-groups.md
:white_check_mark:Succeeded

Skype/UCMA/contextual-communication.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-context-channel.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-state-transitions-inbound.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-state-transitions-outbound.md
:white_check_mark:Succeeded

Skype/UCMA/conversationcontextchannel-quickstart.md
:white_check_mark:Succeeded

Skype/UCMA/conversations.md
:white_check_mark:Succeeded

Skype/UCMA/creating-a-generic-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-a-skype-for-business-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-an-excel-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-an-outgoing-two-party-conversation.md
:white_check_mark:Succeeded

Skype/UCMA/deploying-ucma-4-0-and-ucma-5-0-applications-in-a-skype-for-business-server-2015-environment.md
:white_check_mark:Succeeded

Skype/UCMA/diagnostics-and-error-reporting.md
:white_check_mark:Succeeded

Skype/UCMA/diagram-of-a-voicexml-call.md
:white_check_mark:Succeeded

Skype/UCMA/dialogs-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/dns-load-balancing.md
:white_check_mark:Succeeded

Skype/UCMA/endpoint-draining.md
:white_check_mark:Succeeded

Skype/UCMA/error-handling-and-diagnostics.md
:white_check_mark:Succeeded

Skype/UCMA/error-handling.md
:white_check_mark:Succeeded

Skype/UCMA/escalating-a-two-party-conversation-to-a-conference.md
:white_check_mark:Succeeded

Skype/UCMA/escalation-to-conferencing.md
:white_check_mark:Succeeded

Skype/UCMA/establishing-an-outgoing-call.md
:white_check_mark:Succeeded

Skype/UCMA/extending-the-callfactory-and-mediaproviderfactory-classes.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f53d9ff:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/contactgroupservices.md
:white_check_mark:Succeeded

Skype/UCMA/contacts-and-groups-management.md
:white_check_mark:Succeeded

Skype/UCMA/contacts-and-groups.md
:white_check_mark:Succeeded

Skype/UCMA/contextual-communication.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-context-channel.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-state-transitions-inbound.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-state-transitions-outbound.md
:white_check_mark:Succeeded

Skype/UCMA/conversationcontextchannel-quickstart.md
:white_check_mark:Succeeded

Skype/UCMA/conversations.md
:white_check_mark:Succeeded

Skype/UCMA/creating-a-generic-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-a-skype-for-business-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-an-excel-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-an-outgoing-two-party-conversation.md
:white_check_mark:Succeeded

Skype/UCMA/deploying-ucma-4-0-and-ucma-5-0-applications-in-a-skype-for-business-server-2015-environment.md
:white_check_mark:Succeeded

Skype/UCMA/diagnostics-and-error-reporting.md
:white_check_mark:Succeeded

Skype/UCMA/diagram-of-a-voicexml-call.md
:white_check_mark:Succeeded

Skype/UCMA/dialogs-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/dns-load-balancing.md
:white_check_mark:Succeeded

Skype/UCMA/endpoint-draining.md
:white_check_mark:Succeeded

Skype/UCMA/error-handling-and-diagnostics.md
:white_check_mark:Succeeded

Skype/UCMA/error-handling.md
:white_check_mark:Succeeded

Skype/UCMA/escalating-a-two-party-conversation-to-a-conference.md
:white_check_mark:Succeeded

Skype/UCMA/escalation-to-conferencing.md
:white_check_mark:Succeeded

Skype/UCMA/establishing-an-outgoing-call.md
:white_check_mark:Succeeded

Skype/UCMA/extending-the-callfactory-and-mediaproviderfactory-classes.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 18d35eb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/UCMA/contactgroupservices.md
:white_check_mark:Succeeded

Skype/UCMA/contacts-and-groups-management.md
:white_check_mark:Succeeded

Skype/UCMA/contacts-and-groups.md
:white_check_mark:Succeeded

Skype/UCMA/contextual-communication.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-context-channel.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-state-transitions-inbound.md
:white_check_mark:Succeeded

Skype/UCMA/conversation-state-transitions-outbound.md
:white_check_mark:Succeeded

Skype/UCMA/conversationcontextchannel-quickstart.md
:white_check_mark:Succeeded

Skype/UCMA/conversations.md
:white_check_mark:Succeeded

Skype/UCMA/creating-a-generic-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-a-skype-for-business-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-an-excel-bot.md
:white_check_mark:Succeeded

Skype/UCMA/creating-an-outgoing-two-party-conversation.md
:white_check_mark:Succeeded

Skype/UCMA/deploying-ucma-4-0-and-ucma-5-0-applications-in-a-skype-for-business-server-2015-environment.md
:white_check_mark:Succeeded

Skype/UCMA/diagnostics-and-error-reporting.md
:white_check_mark:Succeeded

Skype/UCMA/diagram-of-a-voicexml-call.md
:white_check_mark:Succeeded

Skype/UCMA/dialogs-performance-counters.md
:white_check_mark:Succeeded

Skype/UCMA/dns-load-balancing.md
:white_check_mark:Succeeded

Skype/UCMA/endpoint-draining.md
:white_check_mark:Succeeded

Skype/UCMA/error-handling-and-diagnostics.md
:white_check_mark:Succeeded

Skype/UCMA/error-handling.md
:white_check_mark:Succeeded

Skype/UCMA/escalating-a-two-party-conversation-to-a-conference.md
:white_check_mark:Succeeded

Skype/UCMA/escalation-to-conferencing.md
:white_check_mark:Succeeded

Skype/UCMA/establishing-an-outgoing-call.md
:white_check_mark:Succeeded

Skype/UCMA/extending-the-callfactory-and-mediaproviderfactory-classes.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Website has 404's for PlatformMessage api doc links

Probably known, but for tracking: the website's travis is failing because we have some 404s:
- _site/platform-services/index.html
  *  External link https://docs.flutter.io/flutter/services/PlatformMessages/sendJSON.html failed: 404 No error
  *  External link https://docs.flutter.io/flutter/services/PlatformMessages/setJSONMessageHandler.html failed: 404 No error
  *  External link https://docs.flutter.io/flutter/services/PlatformMessages/setStringMessageHandler.html failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Headers/FlutterAsyncMessageListener.h failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Headers/FlutterMessageListener.h failed: 404 No error
  *  External link https://github.com/flutter/flutter/blob/master/examples/hello_services/ios/Runner/LocationProvider.m failed: 404 No error
htmlproofer 3.4.0 | Error:  HTML-Proofer found 6 failures!

cc @jakobr-google @mit-mit

Yes, this will be resolved by https://github.com/flutter/website/pull/447.

Cool, thanks for the link.

Temp fixed by https://github.com/flutter/website/pull/458


Submitting from a WorkflowTemplate shows incorrect serviceAccount and securityContext nag

Summary
Starting a Workflow from a WorkflowTemplate brings up the security nag "This workflow does not have security context set. ..." - even if the WorkflowTemplate defines a securityContext.  I've also (just) noticed that the serviceAccount is also shown as "default" even though I'm running with one (currently having to as using PNS).
What version of Argo Workflows are you running?
Running with v3.2.7 client & v3.2.6 server
Diagnostics
Example WorkflowTemplate
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: my-workflow-template
  namespace: my-namespace
spec:
  entrypoint: main
  securityContext:
    runAsNonRoot: false
  serviceAccountName: my-service-account
  templates:
    - name: main
      metadata:
      container:
        command:
          - bash
          - -c
          - echo 'Hello from WT'; env; sleep 15
        image: ubuntu
        name: main

Example command & output:
$ argo submit --from workflowtemplate/my-workflow-template
Name:                my-workflow-template-76qt4
Namespace:           my-namespace
ServiceAccount:      default
Status:              Pending
Created:             Tue Feb 01 21:38:02 +0000 (now)
Progress:

This workflow does not have security context set. You can run your workflow pods more securely by setting it.
Learn more at https://argoproj.github.io/argo-workflows/workflow-pod-security-context/

What Kubernetes provider are you using? EKS
What executor are you running? PNS

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

I can only assume the test at https://github.com/argoproj/argo-workflows/blob/81afc8a7b482aa9b95e010e02f9ef48dea7d7161/util/printer/workflow-printer.go#L117 and access at https://github.com/argoproj/argo-workflows/blob/1159afc3c082c62f6142fad35ba461250717a8bb/cmd/argo/commands/get.go#L121 are operating on the "raw" spec.  I was expecting some accessor function which merged the WorkflowTemplate into the Workflow before letting code query object attributes...

@tyrken this is a CLI problem?
@sarabala1979 can I check my logic here? If you have wf.Status.StoreWorkflowSpec, you should use that, otherwise use wf.Spec? I wonder if we should add a wf.GetExecSpec()?

@tyrken I think you've found the bug, do you want to fix it? I think we'd benefit from a func named:
func (w *Workflow) GetExecSpec() *WorkflowSpec

That would return w.Status.StoredWorkflowSpec or w.Spec and then you could just call that.

yes cli should use wf.GetExecSpec()

Dillen is going submit the PR for this

I think it is a CLI only issue, and thanks-in-advance to Dillen!

Yes it is a CLI issue. Dillen will fix it
Sent from my iPhone

On Feb 5, 2022, at 7:24 AM, Tristan Keen @.***> wrote:

I think it is a CLI only issue, and thanks-in-advance to Dillen!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.


Move GTest to submodule

Instead of make it a deps
This pined googletest to 1.10. Ideally we want to update to 1.11 as well , since 1.10 may build fail on later version of Clang (https://github.com/google/googletest/commit/f7902802f1a61140e188223fb6d1c95925cbec4a was included in GTest 1.11)
But some tests failed to link with GTest 1.11.  So will not upgrade GTest version in this commit.

This pined googletest to 1.10. Ideally we want to update to 1.11 as well , since 1.10 may build fail on later version of Clang (https://github.com/google/googletest/commit/f7902802f1a61140e188223fb6d1c95925cbec4a was included in GTest 1.11)
But when build on my mac book (with GTest 1.10 installed), build failed due to it first try to find the header file in /usr/local/include... so will not upgrade GTest version in this PR.

@wenleix Wenlei,

This pined googletest to 1.10.

I can't find where this version is specified. Could you point me to that place?

@mbasmanova :

And this commit is essentially 1.10 release:

@wenleix There is this commit specified? I looked in .gitmodules, but didn't see it there.
 % cat .gitmodules
[submodule "third_party/googletest"]
	path = third_party/googletest
	url = https://github.com/google/googletest.git

@mbasmanova : Submodule's commit SHA is stored in Git's object database directly: https://stackoverflow.com/q/5033441

@wenleix Got it. Thank you, Wenlei, for explaining.

Should we have a CMake flag around add_subdirectory(third_party)? As reported in the description here, this change is breaking newer Clang versions. Also, older Clang versions seem to fail too. See https://github.com/facebookincubator/velox/issues/1339

Also, what is the motivation to make this part of the source?


Video compress does not reduce video size more than 50% from orignal size

Current behavior
While compressing video after recording a video from a camera it compresses the video size to 140MB while the original size of the video is 373MB
So to further reduce the size and check the video quality I tried to change the bitrate value but after changing few bitrate value its doesn't reduce the app size to a smaller size.
I tried the bitrate value as below with compress file size

bitrate 100000 - file size 140mb
bitrate 1000000 - file size 136mb
bitrate  2000000 - file size 136 mb
bitrate  4000000 - file size 140 MB

Expected behavior
What we want is to compress the video with different bitrates and check the video quality after compression as we want to reduce the video by at least 70% from its original size
Platform

[X] Android
Android version 13
[X] iOS

React Native Version
react-native version 0.66.4
React Native Compressor Version
react-native-compressor 1.6.1
await Video.compress(
        _path,
        {
       compressionMethod: Platform.OS == 'android' ? 'manual' : 'manual',
          minimumFileSizeForCompress:2,
          bitrate:Platform.OS == 'android'? '100000' : '700000'
        },
        (progress) => {
        setProgressStatusValue(progress*100)
        }
      );

Same problem for me. I have a 124mb video and it is scaled down to 107mb. I can't reduce it any more.
Did you find a solution?

🙏 sorry for a long ago I was not maintaining due to the huge office workload, hopefully, I am going to start fixing bugs on a weekend basis,
I will fix at least 2 issues on the weekend, for priority bugs you can join the discord channel https://discord.gg/dtYzk8sp where we can discuss which bug is most important

@Prathamesh-2332 is it taking more time to compress on android or ios?

@Prathamesh-2332 @LemoineThomas @neeravshahpocketapp  can you check the latest version and verify if this issue happens again?

@neeravshahpocketapp bitrate does not work if you are using auto video compression, if you wanna reduce more then you should go with manual compression where bitrate works


[Android][0.20.0] 组件与组件间出现空隙，导致出现类似分割线效果，颜色为父容器背景颜色

视图效果如下

测试代码如下

<template>

                <text class="text">测试{{index}}</text>

</template>

引入的weex版本

implementation 'com.taobao.android:weex_sdk:<IP_ADDRESS>'

It seems like a 1px bug, I will look into it.

It seems like a1pxbug, I will look into it.

 My be related to version.


Restores corrupted files on Windows

I tried this on Windows and creating a backup of a folder seemed to work flawlessly. When I tried restoring it gave me a lot of these errors:
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: The process cannot access the file because it is being used by another process. (os error 32)', C:\Users\XBagon\.cargo\registry\src\github.com-1ecc6299db9ec823\rustic-rs-0.5.3\src\commands\restore.rs:382:68

After the restore finished, I diffed the original folder and the restored one and it reported some differences on some video files, which were visibly corrupted.

Rust by default sets dwShareMode correctly so it shouldn't matter if rustic accesses the same file in parallel. I've come across two things that often cause this issue on Windows (locking a file momentarily right after it's been created/modified):

Windows Defender (will do it for most files most of the time)
Windows Explorer if it's open to the destination (thumbnail generation)

I'm aware of a few solutions:

Keep the file open (possibly with a lock) instead of reopening it every time in write_at()
Just retry .open() after a short delay (which seems like a good idea anyway?)
Add Windows Defender exclusions for the destination and/or rustic.exe (which would also speed up all operations)

@ducalex Thanks for your reply and suggestions! I wasn't aware of the Rust internals but good to know that in principal it should work.
Actually I think we should do all:

I'm aware of a few solutions:
* Keep one handle to the file around until the end (possibly with a process lock), then write_at() is free to do whatever

This is actually what I kind of plan in the long term, see also https://github.com/rustic-rs/rustic/discussions/629#discussioncomment-5796845. Keeping files open and holding file handles could also possibly increase performance and reduce/remove file fragmentation.

* Just retry .open() after a short delay (which seems like a good idea anyway?)

Good idea, I think this should be implemented independently and pretty fast.

* Add Windows Defender exclusions for the destination and/or rustic.exe (which would also speed up all operations)

Is this something rustic could do? Or can you give an short How-To (which we can add to the docu once it is ready, see #302 )? Sorry, I can't judge if this is trival - I didn't use Windows for a long time...

* Add Windows Defender exclusions for the destination and/or rustic.exe (which would also speed up all operations)

Is this something rustic could do? Or can you give an short How-To (which we can add to the docu once it is ready, see #302 )? Sorry, I can't judge if this is trival - I didn't use Windows for a long time...

Exceptions can be added via powershell or by writing to the registry, both can be done by rustic I imagine though you'd need to run it as administrator. Perhaps it's best to just document how to do it manually:
Open an elevated powershell and run Add-MpPreference -ExclusionProcess "rustic.exe".
There's a mention in the restic FAQ but I don't think the exclusion is documented anywhere (perhaps in the forum?).

If this is because a parallel running job (e.g. Windows Defender) accessing the file, note that the rustic restore is "resumable" in the sense that it detects already restored contents and only needs to restore the missing contents if you re-run rustic restore.

So I tried a few things. I created a new backup, restored it again and had the same problem again with some video files.

Open an elevated powershell and run Add-MpPreference -ExclusionProcess "rustic.exe"

I followed this though before doing all that and ensured I didn't have the files open myself anywhere, and I'm pretty sure I don't, as it affected multiple different video files, I wasn't watching any video and didn't have the folder open in explorer or elsewhere, but I guess that's always hard to completly prove.
So then I tried restoring again it did repair the files to my surprise? Also it only restored around 30MB to repair multiple files a lot larger than that, so seems to work pretty efficiently :). Cool program you have there 🥳.
I guess now the question for me is if I find this system reliable enough to actually use it for backups :P I'm looking for a nifty backup solution on Windows for so long, I might try it 😅. It seems to mostly affect large files, I guess I could try to work around those for the moment.


Cookie parsing discards valid cookies

When parsing a raw header with multiple cookies, a a failure is returned if any cookie can not be parse.
So
Headers(Header.Raw(ci"Cookie", """key1=value1; key2={"aField":{}}"""))).cookies
will return a parse failure - because the second cookie is invalid, containing non-escaped " character - rather than a list of one Cookie (the second).
Perhaps, it should try and salvage valid cookies, by first splitting up the raw header by semi-colons
Gitter discussion:
https://gitter.im/http4s/http4s?at=61e16a3e526fb77b317c2735

I agree. Note: the gitter channel is moribund, most dicussion is on Typelevel discord (https://discord.gg/ZWmFFV73X8)

This is an interesting idea.  We already have Headers#getWithWarnings that returns an Ior.  This works great when there are multiple headers of the same name, and we can only parse some of them.
This is the same problem, but the header uses the ;-delimiter.  (Which is actually quite complicated!  See org.http4s.internal.parsing.Rfc7230.headerRep1.)  To make this work generally, what we'd want for recurring headers is to split the semi-colons, and then construct an Ior from parsing the components.  Then getWithWarnings could work like it does for multiple fields.  This would be slower, because the parsers aren't geared to return an Ior, so I think we'd need to feed it multiple inputs. 🤔

Chrome is sending cookies from the domain + subdomain in web requests (e.g. example.com + my.example.com). We happen to be the subdomain and there is an invalid cookie from example.com that we have no control over.


rtsp address issue

i am a beginning learner,
now i have a issue as below:
rtspCamera1.startStream("rtsp://yourEndPoint");
where is rtsp address from ? just ip+port+url ? or from rtsp server ?
if anyone could help me ?
thanks inadvance.
BR.

Like this:
rtsp://<IP_ADDRESS>:554/live/app
Where:
<IP_ADDRESS> -> rtsp server ip
554 -> rtsp port of server configured for stream
live -> application name used in your server (normally named live by default)
app -> Any ramdom string

thank you very much :)


Issue 340 permission fix

Avg response time
coverage on master

This pull request (PR) is a:

[x] Bug fix
[ ] Feature addition
[ ] Other, Please describe:

I certify that:

[x] I have reviewed the contributing guidelines
[x] If this PR is a work in progress I have added WIP: to the
beginning of the PR title
[x] If this PR is problematic for any reason, I have added
DO NOT MERGE: to the beginning of the title
[x] The branch name and title of this PR contains the text
issue-<#> where <#> is replaced by the issue that this PR
is addressing
[x] I have deleted trailing white space on any lines that this PR
touches
[x] I have used spaces for indentation on any lines that this PR
touches
[x] I have included some comments to explain non-obvious code
changes
[x] I have run the tests localy (ctest) and all tests pass
[x] Each commit is a logically atomic, self-consistent, cohesive
set of changes
[x] The commit message should follow these guidelines:

[x] First line is directive phrase, starting with a capitalized
imperative verb, and is no longer than 50 characters
summarizing your commit
[x] Next line, if necessary is blank
[x] Following lines are all wrapped at 72 characters and can
include additional paragraphs, bulleted lists, etc.
[x] Use Github keywords where appropriate, to indicate the
commit resolves an open issue.

[x] I have signed  Contributor License Agreement (CLA) by
clicking the "details" link to the right of the licence/cla
check and following the directions on the CLA assistant webpage
[x] I have ensured that the test coverage hasn't gone down and added new unit tests to cover an new code added to the library

Summary of changes
Made installed scripts 555 permissions
Rationale for changes
Installed software should not be group or world writeable, since this is a huge security vulnerability, obviously.
For contributors and SI team members with code review priviledges

[X] I certify that I will wait 24 hours before self-approving via
pullapprove comment or Github code review so that someone
else has the chance to review my proposed changes

Let's move Summary of Changes and Rationale for Changes to the top of this file and the template(s).

@rouson if you have a chance to look at this and give it a "LGTM" or provide comment that would be great. Feel free to merge too, I'm done. If this happens in the next 5 min I'll try to upload release assets before going to the gym. Otherwise I'll do it when I return.

LGTM

@zbeekman, I'll let you merge in case you want to wait for the tests to complete.

They were about to finish but then I realized the release signing and
deploy script would error on the tag build. My changes shouldn't impact
non-tag builds and I probably should have added [ci-skip]. Feel free to
merge if the second to last commit has a green check. This will help clear
any ci backlog whil I'm at the gym.
On Tue, Apr 18, 2017 at 6:26 PM Damian Rouson<EMAIL_ADDRESS>wrote:

@zbeekman https://github.com/zbeekman, I'll let you merge in case you
want to wait for the tests to complete.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sourceryinstitute/OpenCoarrays/pull/345#issuecomment-295002082,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAREPFVoTGAr_p2SLuHXxCwFspNTff0Pks5rxTidgaJpZM4MkFUf
.

LGTM


Game init

Capstone Review PR
Important information regarding project review

This project was expected to be delivered by July 14th ~ 15th as it was requested on July 7th, I notified Student Success about not being able to fulfill the expected delivery date due to health-related problems.

Project Objectives:

Create effective JavaScript code, that solves the problem
Use Webpack
Use ES6+
Encapsulate JS code in modules
Deal with async code
Use DOM (read/write data) listen to events
Test JS code
Send and receive data from a back-end endpoint
Use JSON format
Ability to communicate information effectively to non-technical people
Shows a desire to take personal responsibility to complete tasks and solve problems
Sets high standards of performance for oneself
Ability to translate business requirements into software solutions
Ability to multitask and effectively manage time and prioritization
Strong English written communication
Deploy apps (Heroku, Netlify)
Use linters (code standards)
Maintain professional Github repos

PR Approved by TSE's


Add explicit version to all messages

I've verified that the rust dsdl parser and compiler have basic support for version numbers. I've not tested with multiple versions of same filename but think this will fail.
We should at least hold on merging this PR until the python parser have the same basic support for version numbers.

[x] Verify that the rust dsdl parser is able to parse dsdl when there only exists a single version of a message.
[x] Verify that the rust dsdl compiler is able to compile dsdl when there only exists a single version of a message.
[ ] Implement parsing of version number in python parser. Uavcan/pyuavcan#39
[ ] Ensure that dsdl compilation is done correctly for pyuavcan when there only exists a single version of a message.
[ ] Ensure that dsdl compilation is done correctly for libuavcan when there only exists a single version of a message.

Possibly:

[ ] Figure out how compilation should be done when there exists several versions of same message.
[ ] Ensure that dsdl compilation is done correctly for pyuavcan when there exists a several versions of the same message.
[ ] Ensure that dsdl compilation is done correctly for libuavcan when there exists a several versions of the same message.
[ ] Ensure that dsdl compilation is done correctly for uavcan.rs when there exists a several versions of the same message.

My first thought on how to compile multiple version for the Rust compiler is:

Append Ver<major version> to the typename for every major version.
Append Ver0<minor version> to the typename for every minor version that has 0 as its major version.
Add a type alias from the type name to the most recent version.

I do not know the details of how libuavcan compile dsdl but I guess this is possible here as well? Do you have any better ideas  @pavel-kirienko ?

Perhaps we instead should make NodeStatus version 1.0? Since this message is required to support the Uavcan protocol it would perhaps be valuable that only one version exists? This would of course mean that we're commited to not change this message, which i assume is not a problem?

I don't think we can arrive at any sensible conclusion here until we decided on how to detect data structure version at the time of decoding; and, optionally, whether to attempt automatic promotion of received data structures to the latest supported version in libuavcan, uavcan.rs, and pyuavcan. Let's finalize https://github.com/UAVCAN/dsdl/issues/35 first.

Ok, I'm on board with that. I've been actually doing some work on this front today. And i wrote a half baked solution there just now. I will refine it a bit more a write a throrough proposal very soon.

@kjetilkjeka I started working on a new set of DSDL definitions for UAVCAN v1.0. I suggest closing this in favor of my new proposition which will incorporate this change as well.


Reader:  Error reading certain fonts

If we use EXCEL_READER_2007 to read a template with a font without scheme "minor" like WingDings or Arial Monospaced, we won't get the desired output but the font is being reset to Excel default font ( Calibri in my case )
Cause:  Error in Method ZCL_EXCEL_READER_2007->LOAD_STYLE_FONTS because it the "create object lo_font " doesn't return an empty font but a font with some default settings.  Here the scheme-attribute "minor" causes the problem.
Solution:  Correction to ZCL_EXCEL_READER_2007.

Fixed with revision 435


keep a reference to callback userdata

If we don't keep a reference on the Julia side, then the object could be freed by the GC at any time and cause nasty segfaults when we try to access it from inside the callback.

Is this valid?
CSIP allows multiple callbacks and I know that JuMP is doing some multiplexing on top of MathProgBase, but what if a user adds multiple lazy constraints individually through the MPB interface? I guess that this data would then be overwritten.
But I just saw that the methods in MPB are actually called set*callback, so this behaviour is to be expected, I guess.

Anyway, the current implementation of, e.g., setlazycallback! in SCIP.jl will just add the new callback in addition to the old one :mag:

Yes, the MPB API expects that at most one callback can be added. Given that this PR fixes the most common use case and doesn't break anything new, I think it's safe to merge.

That's true.


Fix broken link to example _config.yml file

Configuration docs were pointing to example _config.yml on a gh-pages branch which showed Not Found when clicked.

Good catch. Thanks.


Updates to fix the bugs that were associated with the blacklist

blacklisted addresses now saved to local storage
-fixed the bug that allowed addresses from the blacklist to be re-added
-removed adding user to the top of the room for host room, since it introduced too many bugs

This will need to pull in the latest changes from develop

okay, did it


Add doc about Milestones

Issue Type
[ ] Question
[ ] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[x] Documentation
Description
I gather this is powerful but I am struggling to figure out how those classes compose.
Environment
If it's a bug, version(s) of android this affects:
All
Version of osmdroid the issue relates to:
6.0.2

I'm struggling too, though I designed them!
You're right, I should write a doc about them.

the demos are pretty awesome. animation is quite cool! so, there's that.

The marathon one? Yes it is quite impressive but complicated.   I was looking for some simple stuff, place text (based on x) in the middle of line; every x miles; change line color every x km...

I've just added a page in the wiki: Milestones feature
Tell me what you think.


Emit "terminated" on renegotiation error (+ test fix)

Previously SIP.js would send a BYE but the client code would never be notified of that, so the UI would basically not be able to recover.
While I was at it I also fixed the WebRTC.Simple test on non-Safari browsers, to avoid keeping a false positive.

Hi @nud,
Thank you for the PR! This looks good to me, I'll give it a few more days for comments (at minimum, so @egreenmachine can see it) before merging.
Thanks again,
James


Terminology needs work.

Based on the call today, I think it would be wise to create a terminology section, and note when we are using normative definitions from other specs, and when we are making up our own definitions... and not make up our own definitions that conflict....
I heard the word "Envelope" being used today... and I want to clarify the following.
An "Envelope" is some JSON you get.
The Envelope can be a VC Data Model VP (in LD or JWT form)
The Envelope can also be some JOSE based thing, like a DIDComm JWM, or an OIDC id_token.
We should be crystal clear that OIDC id_token's and DIDComm JWMs... ARE NOT W3C Verifiable Presentations...
its super confusing when we don't make this distinction, and we loose the ability to proxy requests over authenticated channels....
for example: Wallet -> VP -> CHAPI  (ENVELOPE)-> DIDComm  (ENVELOPE)-> OIDC (ENVELOPE)....

How I see these terms is:
Embed Targets: the OIDC, DIDComm, CHAPI, etc. outer transport wrapper
Inputs: each atomic object/item you submit specific to an Input Descriptor, meaning: a JWT, a VC object, a VP object, a JWT of the VC/VP flavor, etc.

Are embed targets always optional? Or do some inputs require (for best practices) an embed target?
I'm thinking that I could just sent a VP, JWT, VC over HTTP without using an embed target.

id_tokens would seem to require OIDC, but in reality, anyone can generate them, and its up to the verifier to decide if they will be accepted.
Similarly you can send a JWT / LDP ZKP over HTTP Signatures....
obviously if the verifier is running windows xp servers and only supports OIDC, you can't use DIDComm with them.

I think that was one of the sources of confusion on yesterday's call. The language should be clear about how they can be optionally used together.

For example of terms used in respec: https://identity.foundation/.well-known/resources/did-configuration/#terminology

Are embed targets always optional? Or do some inputs require (for best practices) an embed target?
I'm thinking that I could just sent a VP, JWT, VC over HTTP without using an embed target.

Technically anything is an embed target, the simplest example being a plain JSON request body with a presentation_submission prop/object and a credentials prop/array with credentials inside. Random embed target? Presentation Exchange Badger don't care!

From the meeting 9/3/2020, we feel a terminology section is low effort and high value enough that it should be part of v0.1.0

@wyc will create a PR that introduces a terminology section with some initial values.

@glcohen and I agree that spending time on this issue during our call on 9/24/2020 would be valuable.

We did a terminology review here: https://hackmd.io/rTeaRlYLQlu753nuqAOQgw?both
The next steps are to organize this into logical groups and eliminate superfluous terminology across the spec.

@wyc  any chance we could get an update on the status of this? This is the last major area of textual updates we wanted to get in for v1.0.

@csuwildcat I will spend time this weekend on it, including addressing concerns in #199. My apologies for all the delays.

I cleaned some of the terminology-related stuff in PR #192. We could probably close this when that merges.

#192 has been merged, closing


The 'cursor' option is required, except for aggregate with the explain argument.

throw MongoDB.Driver.MongoCommandException   HResult=0x80131500   Message=Command aggregate failed: The 'cursor' option is required, except for aggregate with the explain argument.   StackTrace:    at MongoDB.Driver.Core.WireProtocol.CommandWireProtocol1.ProcessReply(ConnectionId connectionId, ReplyMessage1 reply)    at MongoDB.Driver.Core.WireProtocol.CommandWireProtocol1.Execute(IConnection connection, CancellationToken cancellationToken)
at MongoDB.Driver.Core.Servers.Server.ServerChannel.ExecuteProtocol[TResult](IWireProtocol1 protocol, CancellationToken cancellationToken)    at MongoDB.Driver.Core.Servers.Server.ServerChannel.Command[TResult](DatabaseNamespace databaseNamespace, BsonDocument command, IElementNameValidator commandValidator, Func1 responseHandling, Boolean slaveOk, IBsonSerializer1 resultSerializer, MessageEncoderSettings messageEncoderSettings, CancellationToken cancellationToken)    at MongoDB.Driver.Core.Operations.CommandOperationBase1.ExecuteProtocol(IChannelHandle channel, ServerDescription serverDescription, ReadPreference readPreference, CancellationToken cancellationToken)
at MongoDB.Driver.Core.Operations.CommandOperationBase1.ExecuteProtocol(IChannelSource channelSource, ReadPreference readPreference, CancellationToken cancellationToken)    at MongoDB.Driver.Core.Operations.ReadCommandOperation1.Execute(IReadBinding binding, CancellationToken cancellationToken)
at MongoDB.Driver.OperationExecutor.ExecuteReadOperation[TResult](IReadBinding binding, IReadOperation1 operation, CancellationToken cancellationToken)    at MongoDB.Driver.MongoDatabaseImpl.ExecuteReadOperation[T](IReadOperation1 operation, ReadPreference readPreference, CancellationToken cancellationToken)
at MongoDB.Driver.MongoDatabaseImpl.RunCommand[TResult](Command1 command, ReadPreference readPreference, CancellationToken cancellationToken)    at Hangfire.Mongo.Migration.Strategies.MongoMigrationStrategyMigrate.BackupCollection(HangfireDbContext database, String collectionName, MongoSchema currentSchema) in D:\work\MongoDBTest\src\Hangfire.Mongo\src\Hangfire.Mongo\Migration\Strategies\MongoMigrationStrategyMigrate.cs:line 97    at Hangfire.Mongo.Migration.Strategies.MongoMigrationStrategyMigrate.Migrate(MongoSchema fromSchema, MongoSchema toSchema) in D:\work\MongoDBTest\src\Hangfire.Mongo\src\Hangfire.Mongo\Migration\Strategies\MongoMigrationStrategyMigrate.cs:line 38    at Hangfire.Mongo.Migration.MongoMigrationManager.Migrate(HangfireDbContext dbContext) in D:\work\MongoDBTest\src\Hangfire.Mongo\src\Hangfire.Mongo\Migration\MongoMigrationManager.cs:line 72    at Hangfire.Mongo.MongoStorage..ctor(String connectionString, String databaseName, MongoStorageOptions storageOptions) in D:\work\MongoDBTest\src\Hangfire.Mongo\src\Hangfire.Mongo\MongoStorage.cs:line 68    at Hangfire.Mongo.MongoBootstrapperConfigurationExtensions.UseMongoStorage(IGlobalConfiguration configuration, String connectionString, String databaseName, MongoStorageOptions storageOptions) in D:\work\MongoDBTest\src\Hangfire.Mongo\src\Hangfire.Mongo\MongoBootstrapperConfigurationExtensions.cs:line 115    at MAS.MASWebCoreModule.<>c__DisplayClass3_0.<PreInitialize>b__0(IAbpHangfireConfiguration configuration) in D:\work\MongoDBTest\src\MAS.Web.Core\MASWebCoreModule.cs:line 64    at MAS.MASWebCoreModule.PreInitialize() in D:\work\MongoDBTest\src\MAS.Web.Core\MASWebCoreModule.cs:line 62    at System.Collections.Generic.List1.ForEach(Action1 action)    at Abp.Modules.AbpModuleManager.StartModules()    at Abp.AbpBootstrapper.Initialize()
I'm trying to solve this exception.
I google search other MongoDB components found that have similar problems.
Download your code, breakpoint debugging.
In the BackupCollection method of the MongoMigrationStrategyMigrate class, the last line of code throws an exception.

Add a few lines of code here :
{ "cursor", new Dictionary<string, object>     {         { "batchSize", 0 }     } }

I've successfully eliminated this exception.
I think this cursor is a required option and should be passed in by the developer from the front.
Can you merge the problem in the next version?
Be deeply grateful.

@VAllens, thank you for your detailed report and preliminary research. I'll take a look at this, and eventually bring it into the next release.
The next release is 0.6.0 and it is coming soon :)

Oh, thanks.
Maybe when, can you tell me?

@VAllens , We are aiming for end of this week :)

@VAllens, I just tried with batchSize=0 as you suggested. That has some weird side effects on my machine. It is not really working.
I tried changing it to 1 - and everything works again. Could you try that to see if that fixes you problem or just exposes it again?

@VAllens, seems batchSize=0 has a special meaning:
https://docs.mongodb.com/manual/reference/method/db.collection.aggregate/#example-aggregate-method-initial-batch-size

A batchSize of 0 means an empty first batch and is useful for quickly returning a cursor or failure message without doing significant server-side work. Specify subsequent batch sizes to OP_GET_MORE operations as with other MongoDB cursors.

You can use it as a parameter with a default value, let the caller decide whether to change its default value.
In fact, I do not understand the meaning of this parameter, because I do not use this parameter.
Thanks you.

I passed in batchsize = 0 parameter, just to eliminate the exception.
But I don't know how set the batchsize parameter value, just by the default value of the MongoDB official document.

@VAllens, just change the 0 (zero) in the code you inserted to 1:
{                     "cursor", new Dictionary<string, object>                     {                         { "batchSize", 1 }                     }                 }
Please see if that solves your issue.

I've tested both 0 and 1, and I don't see any problems on the surface

After reading the documentation carefully, I found that "cursor" is no longer optional as of MongoDB 3.4
MongoDB 3.4 Aggregate
MongoDB 3.2 Aggregate
The documentation states that an empty "cursor" element is accepted.
@VAllens, could you please try this out and report back if that solves your issue?
{ "cursor", new BsonDocument() }

There is a PR #103 that should solve this problem. Please try it out.

Thank you. I saw these two link documents yesterday.
For this PR #103, I'm test haven't detected any problems. :)

The fix has been included in the 0.5.3 release.
It should be available on nuget.org shortly.


Update help-and-support.md

Codecov Report

Merging #702 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   32.09%   32.09%
=======================================
  Files          52       52
  Lines        5272     5272
=======================================
  Hits         1692     1692
  Misses       3386     3386
  Partials      194      194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a479f...a63e1a7. Read the comment docs.


Proper Acceleration Calculation

Fix this:
if (i > 0) {
  // Ensure the initial velocity for the next instruction is always <= than the target velocity
  // because an instruction cannot decelerate to target velocity, only accelerate.
  if (calcRes.instructionResults.last.finalOuterVelocity > nextInstruction.targetVelocity) {
    instruction.acceleration = 1; // TODO: Calculate the value
  }
}

The acceleration should be the largest possible for the Robi.


template week-day.html

template week-day.html shows the meetings one below the other in different columns, can it be made to show one next to the other in their respective columns?

十分感谢，邮件已经收到！

Yeah it can you just need to rewrite the whole page, as this is not supported currently but its worth a rewrite.

Thanks for your answer, I thought that rewriting the cal-cell and cal-offset classes could solve it.


paramed helmet resprite

About the PR
it has new sprites
it also has a light now
Why / Balance
i didnt like the old one
Technical details
puts it all in a new .rsi cause i was too lazy and some dumbass might wanna use the old ones for some reason
Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog
:cl:

tweak: new paramed voidsuit helmet sprite and it has light now

add a little more blue please

read coderabbit's review


PIP button

[x] change svg for PIP button

@BrooklynKing @maxvektor let's squash commits like this in the future. And use conventional commits.


validator highlighting cell in wrong column if type 'control' field is used on the left

I opted for using two fields of type "control", one at the left hand side of the grid and the other at the opposite end but, as mentioned in the title, when validation fires the wrong cell receives the css changes.
see picture please:

please note that issue happens even if using only one control on the left hand side
tx

I think I've pinned the reason for this behaviour and it is the fact that I have a hidden field.
Once I remove it, the css highlighting works on the correct cell/column again.
Is there a way to overcome it or am I doing it wrong?
tx

Yes, thank you for the report.
This issue is fixed already https://github.com/tabalinas/jsgrid/issues/226
But pending to be released (it's gonna be very soon).


Check for EWOULDBLOCK on timeout

Description
Secure sockets is inconsistent and returns either 0 or EWOULDBLOCK on timeout, depending on the port.  Change the network layer to check for both values.
Checklist:

[ ] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

Hi, as you probably know, the return values from recvfrom() and recv() in FreeRTOS+TCP are not entirely following the BSD rules.
In case there is no data, recvfrom() will always return -EWOULDBLOCK, whereas recv() returns zero.
I think that now it is too late to change this behaviour: users would complain. But yes, it is good to always check for both zero and -EWOULDBLOCK, and treat them the same.
All negative return codes except -EWOULDBLOCK and -EINTR are fatal.
To summarise:
FreeRTOS_recvfrom() may return:
    <positive number>          // Data was received
    -pdFREERTOS_ERRNO_EINTR    // Operation was interrupted
    -pdFREERTOS_ERRNO_EWOULDBLOCK // No data awas vailable
FreeRTOS_recv() may return:
    <positive number>          // Data was received
    -pdFREERTOS_ERRNO_EINVAL   // This is not a valid TCP socket, or socket not bound
    -pdFREERTOS_ERRNO_ENOMEM   // RX-stream buffer could not be allocated
    -pdFREERTOS_ERRNO_ENOTCONN // socket is not yet connected
    -pdFREERTOS_ERRNO_EINTR    // Operation was interrupted
    0                          // No data was available


directline errors

I keep getting directline errors once a while multiple times during the day....
e.g.
getaddrinfo ENOTFOUND directline.botframework.com directline.botframework.com:443
and
some errors like below
https://directline.botframework.com/v3/conversations/I02GjBASIPz4DOmNQeTxKL/activities/I02GjBASIPz4DOmNQeTxKL|0000000' failed: [503] Service Unavailable
https://directline.botframework.com/v3/conversations/6lg94qXdQbv6WOaUTf42YO/activities/6lg94qXdQbv6WOaUTf42YO|0000000' failed: [500] Internal Server Error
https://directline.botframework.com/v3/conversations/HBVeZlhbpVx1B1cjKD5QXS/activities/HBVeZlhbpVx1B1cjKD5QXS|0000000' failed: [502] Bad Gateway
Any reason why ? it stops our webchat conversation flow....
Appid: 3b2bea4a-c6ac-4e54-a926-cbee6a1c1d2a
One common thing for all errors is that activitiy id is always ending with |0000000

Hi @ubreddy
I spoke with one of the Direct Line Service engineers about the issues you've been having.  They provided this response:

There are a couple different problems:

Errors from internal dependencies
a.	We are in the process of moving our internal databases to CosmosDB which will give better performance and resiliency. That should be done in the next couple weeks.
Errors from the platform
a.	We've battling a networking problem and have engaged other Azure teams to root cause this. This is our highest priority issue.
Errors from deployment
a.	We are deploying some fixes that will make deployments less impactful. This should also be in place in the next couple weeks

The good news is that we're aware of each of these and making progress on their fixes. The bad news is that it's taking far too long and for that I apologize. These issues are frustrating for us, too.

Hi Eric Dahlvang,
in case our issue we have already using TLS1.2 and other recommended setting. BUt still we are getting the error. so please let me what should be the changes we need to do....
Below line is raising the issue:
<<<<<using (var response = await client.PostAsync(url, strContent).ConfigureAwait(false))>>>>>.
Thanks,
Raj

Hi @Rashree138
This issue is not related to TLS 1.2, but rather the service as explained here: https://github.com/Microsoft/BotFramework-Services/issues/39#issuecomment-463321808

Any update on this? Today, I'm getting 502's at one point and then the API starts working.

@thedrew12 The fix for the issue is still in progress.

Closing this issue.  The fixes for this have been completed.


Add Netlify-specific context to Remix server actions

Motivation
At Netlify, we're gearing up to launch the Netlify Graph, which allows easy access to third-party APIs via the Onegraph acquisition.
What does this PR do?
This PR adds a custom getLoadContext function to the Netlify server template which gets at most 2 pieces of information from the function invocation:

netlifyGraphToken, which is passed to handlers that fetch remote third-party data (check our docs here).
clientNetlifyGraphAccessToken, which is extracted from the Authorization request header, if present. This might be in JWT form, containing signed information about the client. This short video goes into great detail about the workflows this can allow.

@anmonteiro thanks so much for the PRs :)
We've anticipated each host will have unique features like this and we'll never be able to keep track of them all ourselves. Do ya'll want to own the netlify adapter? We'll keep the CLI option but we'll use the netlify adapter from your published package.

@anmonteiro can you rebase this on dev instead of main and we'll get it merged? Thanks!

@ryanflorence thx for the review. I just rebased this on dev.
I think we'd be happy to move this to the Netlify org. Tagging @sgrove and @localden here for visibility.


is there any plan to support influxdb?

is there any plan to support influxdb?

Even I need to integrate influxdb reporter, any plans?

There isn't support for configuring an influxdb reporter with xml yet, but it's still possible to configure it using Spring Java config.


Code has been modularized a bit and now uses numpy for calculations

Some improvements to the code.

Thanks for your effort, I think it's a good idea to use the numpy library in this project.
One question: have you considered the possibility for nan values in the dataset? One could perhaps want to use the numpy.nanmean instead.

Thanks for your effort, I think it's a good idea to use the numpy library in this project.
One question: have you considered the possibility for nan values in the dataset? One could perhaps want to use the numpy.nanmean instead.

Good point @asmundb. I'll change this.

Good point @asmundb. I'll change this.


Set explicit dependency versions

This change is to ensure that packages are not moving
the ground underneath the project and introducing
breaking changes.
As the project progresses, these packages will be updated
accordingly and to the latest version if there are improvements
in the dependency.
Peer dependencies will be updated on a very regular basis.
create-react-class was updated to 15.5.3 due to a known
issue with browserify

@oshalygin be sure to follow commit message formats for the future PRs (for auto-generated CHANGELOG.md)

@tomchentw will do!

Released v7.3.0

@oshalygin I think it should be fine leaving devDependencies open, as our dependencies are locked by yarn.lock. I'm OK with exact dependencies & peerDependencies, although personally I don't use this pattern in other projects.

Good call thanks @tomchentw !


dd: unexpectedly consumes all bytes from stdin

Executive summary:
Setup:
cargo build -p uu_dd
echo 'abcd' > infile

GNU dd:
$ (dd bs=1 skip=1 count=0 status=none && cat -) < infile
bcd

uutils dd:
$ (./target/debug/dd bs=1 skip=1 count=0 status=none && cat -) < infile

(it produces no output).

I'm going to be very explicit about this because it helped me understand the problem here. The way I'm reading the command line is:

dd means copy bytes from stdin to stdout,
bs=1 means blocks of 1 byte from the input and write blocks of 1 byte to the output,
skip=1 means skip 1 block of the input,
count=0 means write 0 blocks to the output,
&& means do the second command only if the first command terminates with exit status 0,
cat - means copy bytes from stdin to stdout,
< infile means redirect the bytes of infile into stdin,

Altogether this could be described in English as "send bytes of infile into stdin, have dd skip the first byte and stop, then have cat copy the remaining bytes to stdout".
So the problem seems to be that by the time cat attempts to read from stdin, there are no bytes available to read, but there should be. I took a look in the code for dd and it doesn't seem to be reading more bytes than it should: https://github.com/uutils/coreutils/blob/1194a8ce534e88cf213ddc3b66bb8d357455cf56/src/uu/dd/src/dd.rs#L182 Perhaps this has something to do with how Rust provides a handle to stdin?
(I discovered this issue when looking into test failures in the GNU test tests/misc/head-c.sh.)

The corresponding GNU test for dd is in tests/dd/not-rewound.sh.

There's a similar issue with od; a corresponding test is in tests/misc/od-N.sh.

I think it would be a welcome addition.

Alright, I'll clean that up and make a PR.


commit the lib files so we can use as import

This PR is just to make sure i'm doing this right.  For subsequent modifications I'm planning to just run npm run dist and push the new stuff to 1.4.2

Not sure what this is for ??


AbortionError(code=StatusCode.UNAUTHENTICATED, details="Request had invalid authentication credentials.")

Very seldom, like 9 out of 450k publish requests, we get the following error:
AbortionError(code=StatusCode.UNAUTHENTICATED, details="Request had invalid authentication credentials.")

Retrying 2 times doesn't help, and we loose the message.
What's the recommended way of dealing with this problem? Retry until it works? Should application code have to deal with it, or is it something that should be handled automatically by SDK?
Versions, traceback etc is the same as in #2683.

@forsberg AbortionError indicates you are using an old version of this library. That was a beta feature of grpc and we have been using the stable version for some time.
Can you explain how you are installing?

@forsberg FWIW we've seen something similar in #1917. The issue is essentially one of timing: your token may not be expired when we check the expiry before making a request, but by the time it reaches the server, it is expired. Do you know what kind of credentials you are using? (e.g. service account or a user credentials)

We have a very simple retry logic here - it will simply try 3 times in a row. For the problem in #2683, this seems to have done the trick. For this, it doesn't. I guess it's matter of timing.
I'll make sure we do a fresh install from master without old crap lying around on Monday to see if problem still appears.
Agree that having built-in retry functionality would be very convenient. Or at least have documented what kind of exceptions are worth retrying.

And to answer your question: It's a service account.

After fixing our borked install to use a relatively fresh master e1fbb6bc, we have not observed this particular error anymore, but we have not had it running for a very long time. I'll report back again when we've had it running for a week or so without problems.

@forsberg Thanks for the update. This error is in some sense unavoidable because we check "is the token valid" (and here) before sending, but by the time it's sent it may have become invalid. (However, I'm fairly certain the server gives 5 minutes of wiggle room, which isn't part of the expiry so it seems "impossible".)

Hello! :-)
First, a mea culpa; I have not done as good of a job at keeping up with issues as I should have. If you are getting this (I admit it) cut and paste, it is likely because your issue sat for too long.
In this case, I have been in the process of making a radical update to the PubSub library (#3637) to add significant performance improvements and a new surface, which we hope to launch soon. As such, I am clearing out issues on the old library. It is my sincere goal to do a better job of being on top of issues in the future.
As the preceding paragraph implies, I am closing this issue. If the revamped library does not solve your issue, however, please feel free to reopen.
Thanks!


First character is not recognized when typing after keyboard navigation to a cell

Describe the bug
The character which is entered first after keyboard navigation to a cell is not entered into the cell. For example, typing This only yields his. See demo:

Steps to reproduce

Keyboard navigate to a cell so that it is highlighted
Type something
Observe that the first character is missing

Expected behavior
Entering information into a cell is supposed to start immediately upon typing after keyboard navigation to a cell.
Are you using the mobile app?
No
Obsidian debug info
SYSTEM INFO:
Obsidian version: v1.4.3
Installer version: v1.3.5
Operating system: Windows 10 Home 10.0.19045
Login status: logged in
Catalyst license: insider
Insider build toggle: on
Live preview: on
Legacy editor: off
Base theme: light
Community theme: Polka v1.3.9
Snippets enabled: 14
Restricted mode: off
Plugins installed: 118
Plugins enabled: 98
1: Divide & Conquer v1.0.0
2: Advanced new file v1.5.1
3: Advanced Tables v0.19.1
4: Advanced URI v1.37.0
5: Auto Link Title v1.4.1
6: Better Word Count v0.10.0
7: Buttons v0.4.19
8: Calendar v1.5.10
9: Commander v0.5.0
10: Custom Frames v2.4.6
11: D2 v1.1.3
12: Dataview v0.5.56
13: Dictionary v2.22.0
14: Emoji Shortcodes v2.2.0
15: Emoji Toolbar v0.4.1
16: File Diff v1.0.13
17: Focus Mode v1.11.4
18: Force note view mode v1.2.0
19: Gallery v0.5.8
20: Hide Sidebars on Window Resize v1.1.0
21: Home tab v1.1.2
22: Hotkeys++ v0.2.7
23: Hotkey Helper v0.3.18
24: Inbox v1.1.0
25: Kanban v1.5.3
26: Linter v1.19.1
27: Natural Language Dates v0.6.1
28: MetaEdit v1.8.2
29: Obsidian42 - BRAT v0.7.0
30: Obsidian42 - Strange New Worlds (SNW) v1.2.2
31: Obsidian42 - Text Transporter v1.0.3
32: Open vault in VSCode v1.2.1
33: Pandoc Plugin v0.4.1
34: Paste URL into selection v1.7.0
35: Periodic Notes v0.0.17
36: Plugin Update Tracker v1.5.2
37: Projects v1.16.3
38: Prompt v1.1.0
39: Review v1.6.4
40: Table Enhancer v0.5.10
41: Typewriter Scroll v0.2.2
42: URI Commands v1.0.0
43: QuickShare v1.3.1
44: QuickAdd v1.2.1
45: Quick Explorer v0.2.8
46: Workbench v1.6.1
47: Word Sprint v0.2.5
48: Templater v1.16.0
49: Tag Wrangler v0.5.11
50: Style Settings v1.0.6
51: Spaced Repetition v1.10.1
52: Sortable v0.3.1
53: Smarter Markdown Hotkeys v1.16.4
54: Settings Search v1.3.8
55: Lapel v0.1.1
56: Note Refactor v1.7.1
57: Numerals v1.2.1
58: Obsidian Git v2.20.7
59: qmd as md v0.0.2
60: Quiet Outline v0.3.15
61: Raindrop Highlights v0.0.18
62: Reading Time v1.1.1
63: Readwise Official v2.0.1
64: Recent Files v1.3.7
65: Rollover Daily Todos v1.1.6
66: Tasks v4.6.0
67: Plugin Groups v2.1.0
68: Update time on edit v2.2.0
69: Colorful Note Borders v0.2.4
70: File Explorer Note Count v1.2.1
71: Hover Editor v0.11.13
72: Daily Note Outline v1.2.2
73: Callout Manager v1.0.1
74: Dynamic Highlights v0.3.1
75: Creases v0.7.0
76: Hider v1.3.1
77: List Callouts v1.1.4
78: ProZen v0.3
79: Rapid Notes v1.2.5
80: Sentence Navigator v1.3.0
81: Shell commands v0.20.0
82: MySnippets v1.2.3
83: Auto Note Mover v1.2.0
84: Folder Note v0.7.3
85: Editor Syntax Highlight v0.1.3
86: Supercharged Links v0.10.0
87: Pandoc Reference List v2.0.19
88: Zotero Integration v3.0.7
89: Outliner v4.8.0
90: LanguageTool Integration v0.3.4
91: Text Format v2.2.7
92: Time Block Planner v0.6.0
93: Create Note in Folder v1.1.2
94: Homepage v3.5.1
95: DataLoom v8.2.1
96: Obsidian Enhancing Export v1.8.7
97: Excalidraw v1.9.17
98: Various Complements v8.4.1
Relevant log output
No response

Thanks for this. This is will fixed in the next day.

Fixed in 8.2.2


ConfigAttributeError: Key 'legacy_reward' is not in struct

https://github.com/thuml/iVideoGPT/blob/130bbec1d266f96da7a7195ef688f6c1990b5cc5/mbrl/train_metaworld_mbpo.py#L70-L73
This code will result in an error. Is this key still needed?
omegaconf.errors.ConfigAttributeError: Key 'legacy_reward' is not in struct
    full_key: legacy_reward
    object_type=dict

This key no longer exists in our cleaned code for release. I have removed them from the latest commit. Thank you for pointing out this!

In fact, I still get an error after removing it. /(ㄒoㄒ)/~~

I have tested the current code and not encountered the same issue. Did you install our specified version for metaworld?
pip install git+https://github.com/Farama-Foundation/Metaworld.git@83ac03ca3207c0060112bfc101393ca794ebf1bd

I reinstalled the environment, but it still didn't work. And there was no error when I installed metaworld.
The metaworld version is as follows：
metaworld                    2.0.0
What happens if the webpage displays "Not Found"?

You should either use this url for pip install, which will automatically git clone codes and setup, or visit https://github.com/Farama-Foundation/Metaworld/tree/83ac03ca3207c0060112bfc101393ca794ebf1bd to manually download the code.

Commenting out rgbd_tuple in the following code solves the problem. But I don't know why. Is it because the version of mujoco I installed is wrong?
/mnt/data/xxxx/Anaconda/envs/ivid/lib/python3.9/site-packages/gymnasium/envs/mujoco/mujoco_env.py
        assert self.metadata["render_modes"] == [
            "human",
            "rgb_array",
            "depth_array",
            # "rgbd_tuple",
        ], self.metadata["render_modes"]


Remote notifications event not triggered in Android

RN: 0.48.4
react-native-fcm: 9.6.2
Android 6.0.1
Devices: Samsung J5, One Plus 2
@evollu in Android I can receive local and remote notifications both in foreground/background/killed. My problem is that while the app is in background/killed, I don't get any event for remote notifications (the notification is shown correctly). The event is not triggered even when clicking on the notification.
I'm sending the remote notifications with Firebase Console.
Things I tried:
-use FCM.getInitialNotification() as suggested in #558.
-Use AppState to detect when the app comes from background to getInitialNotifiaction
-FCM.on(FCMEvent.Notification...) is placed outside of the component code
-Adding in MainActivity.java (as suggested in #341):
@Override
public void onNewIntent(Intent intent) {
    super.onNewIntent(intent);
    this.setIntent(intent);
}

I also found this thread in Stack Overflow: https://stackoverflow.com/a/37845174, that says it's not possible to send Data Messages from Firebase Console. Is that the case? I'm pretty sure with older versions of react-native-fcm (6.2.3) I was receiving the event correctly (app in background and remote notification).

it needs to be data only notification to trigger the callback I think.

Look at #588

Also had this problem and was trying around forever with the firebase console ... as it turns out, notifications that have a notification body and would display a notification text and so on, are indeed not handled in the background. Notifications/Messages that only have a data part will be handled in the background and when the app is closed as soon as the app starts again. But they will then not show up in the android notification center...
Works in Background:
curl -X POST -H "Content-Type: application/json" -H "Authorization: key=theKey" -d '{ "data": { "someData": "test123" }, "to": "deviceID" }' https://fcm.googleapis.com/fcm/send

Does not work in Background:
curl -X POST -H "Content-Type: application/json" -H "Authorization: key=theKey" -d '{ "data": { "navPath": "test123" }, "to": "clientID", "notification": {  "body": "hey"  }}' https://fcm.googleapis.com/fcm/send

This is confusing me, why can we not have both like on iOS? I want to receive a notification with a text and when the user presses it, navigate to the according screen in my app. How would I manage to do that?

my problem is getInitialNotification alway return null (not undefined) when i press notification on tray.

FCM ignores data if it is send together with notification. can't do anything about it

@evollu so how can I send a notification and when the user taps on it open a specific page inside my app? Is this not possible with fcm notifications?

it is. you have to use "custom_notification" to ensure delivery

@evollu thank you so much, that works 👍  Totally overlooked that in the Readme


Enable associated domains capability for share.soundscape.services

This, in conjunction with the apple-app-site-association file to be hosted on share.soundscape.services, fixes the marker sharing bug.

I have attached the file, which should be hosted at https://share.soundscape.services/.well-known/apple-app-site-association
It has to be served with a content-type of application/json, and no file extension. (Thanks apple for that ludicrous requirement)
apple-app-site-association.txt


[ST] Execution Reverted

Describe the bug
A user is trying to bridge oLIT from Arbitrum to Ethereum but gets an "execution reverted" error. As far as I'm aware there aren't any liquidity constraints for this token like there are on Alchemix assets. The user tried deleting the decimals and also inputting just 1 oLIT but still got the error.
Link to ticket in discord
https://discord.com/channels/454734546869551114/1200875338897563808/1200875541239189544

A different user is trying to bridge NEXT from Gnosis Chain to Arbitrum but also got execution reverted. Then they tried to bridge to Polygon and got this error:

https://discord.com/channels/454734546869551114/1200879162634813491/1200880415980929165

These were caused by the bridge being paused


Cards with different sizes

I think the problem CSS of mustard-ui file

It's alright. The problem was in style.css
.card {
  border: 1px solid #dedede;
  margin: auto;
  /* max-width: 100%;
  max-height: 90%; */
  height: 500px;
}

We need to comment max-width and max-height and make height is 500px


Description of close-out procedure

here a GH issue to describe the close-out procedure, most of which is legacy and already known to everyone.
Code is https://github.com/CMSCompOps/WmAgentScripts/blob/master/Unified/checkor.py
Here below the items in order of reading the code, picking up on all the things in "completed" reqmgr-status (with some option flags selecting some part of it)

checking the list of things that need force-completing or by-passing, from afs files and mcm api
getting the list of files which were invalidated by dynamo (for further information)

per workflow, the following things are don

force completing if requested
build requirement for custodial tape subscription based on campaign and tier rule
force completing if over thresholds from campaign's rule
collect information about ongoing ACDC
collect information about required completion level by output dataset
collect information about possibility of truncating the output dataset
reduce the requirement of completion based on time in the system
collect dataset parentage information, and apply cumulative threshold if configured as such
check if all output are completed [A]
verify whether the output can be set valid (but not closed-out)
force complete if it can be tuncated
verify that no lumisection is too big (according to campaign settings)
collect information about tape custodial location and subscription
collect information about number of files in phedex & dbs
analyze the file count, compare with dynamo, invalidate in dbs some file if already not in phedex anymore and were globally deleted
collect information about duplicated lumisections
invalidate files that contain duplicates
decide on a custodial tape destination based on parent, and campaign setting, and output size
check for large fraction of invalidated file for tagging the wf
fill summary information to the closedout-db in mongodb (towards making https://cms-unified.web.cern.ch/cms-unified//assistance.html)
setting close-out if relevant making error reports otherwise and if relevant
send notification to mcm based on the type of error

Thanks for providing these details, Jean-Roch.
I think any mention of force-completing does not belong to this ticket and I'd like to decouple them.
In this issue, we should start with work that is already in completed status, and then proceed with all those checks that you described above.
Do we provide the workflow summary / error report for every single workflow? Or only in cases the workflow didn't reach the target level of completion (let's say 90 or 95% for MC, etc).?
From your list, I'd say what we'd have to have in the close-out procedure is:

build requirement for custodial tape subscription based on campaign and tier rule

similar to "collect information about tape custodial location and subscription". Or is there any difference?
similar to "decide on a custodial tape destination based on parent, and campaign setting, and output size". Can we join all these bullets into one clear description of how output subscriptions are handled?

collect information about ongoing ACDC

(if there is any ACDC in acquired/running, then do nothing and try these checks in the next cycle(?)

collect information about required completion level by output dataset

required completion by dataset? Where is it defined? or is it campaign-wise?

collect dataset parentage information, and apply cumulative threshold if configured as such

what is the "cumulative threshold" you're talking here? please elaborate

check if all output are completed [A]

do you mean are registered in both DBS and PhEDEx?

verify whether the output can be set valid (but not closed-out)

don't we set output datasets to VALID when workflows get announced (or maybe when workflow moves to closed-out status)? If you're talking about setting output datasets to VALID while there is still some work/recovery on going, I'd handle that as an exception. Unless you have an algorithm that we could put in the system...

verify that no lumisection is too big (according to campaign settings)

I don't get this point. This should be a check during assignment. If you're worried about Ops mistake, then I think we need to work on avoiding those mistakes and forget this check.

collect information about number of files in phedex & dbs

what to do if they don't match?

analyze the file count, compare with dynamo, invalidate in dbs some file if already not in phedex anymore and were globally deleted

why compare it with dynamo? which information is held by dynamo that we cannot have in PhEDEx and DBS?

collect information about duplicated lumisections

invalidate files that contain duplicates. Then what do you do with those other healthy lumi sections that got invalidated in the same file? How you decide which file to invalidate? How do you decide whether recovery is needed after this invalidation?

check for large fraction of invalidated file for tagging the wf

how this information is used? what do you mean by "tagging the wf"? Does it affect the final decision whether the workflow can be closed-out or not?

fill summary information to the closedout-db in mongodb (towards making https://cms-unified.web.cern.ch/cms-unified//assistance.html)

this would add another dependency to the WMCore services. So we better handle it in a different way, either providing this summary via ReqMgr2/WMStats or in a different way.

setting close-out if relevant making error reports otherwise and if relevant
send notification to mcm based on the type of error

what is this notification? is it using a REST API and filling a McM request with some information?

I'm going to create another placeholder for auto force-completion with some of your bullets.

Thank you very much Jean-Roch, Alan for creating this. I think it is good idea to keep separate tickets for (auto) force-complete and close out ticket. I will create one issue for moving from closed-out to announced as well. I know Jean-Roch is busy to write all the logic. It would be helpful brief explanation about conditions which make the each state transition and point the code as this ticket has. Alan and I can ask questions if something is not clear, hope we won't bother Jean-Roch too much with this. (But that is the penalty for being a only expert. 😄
FYI. Issue for announced transition #8921

@amaltaro regarding force-complete : everything here is related to something in "completed". The force-completion would happen to on-going acdc, should the requirement be met. It is part of the current completed->close-out transition for the original workflow. Fine with me if you want to put it elsewhere though.

many of the details above will have to come through reading the code to get the exact way. any description with words will likely fall short.

you might find reading https://cms-unified.web.cern.ch/cms-unified/logs/checkor/last.log useful


Edited WriteHost rule strings.

This should REPLACE the previous pull request. I think it has all of the required files.

Hi @juneb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

This attempt has both changed files, but it's still failing. Please let me know how to fix it.

Hi June. Can you please Sign the CLA? I will accept the PR and fix the failing test
https://github.com/PowerShell/PSScriptAnalyzer/blob/development/Tests/Rules/AvoidUsingWriteHost.tests.ps1

@juneb, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Hi June. Thank you for the message updates. Looking forward for more great content from you.


Update configure-connector.md

Step 12 was missing in the steps

Added the last item to the list of steps

Fixed internally by removing the inline TOC as the TOC is autogenerated at the top of the page and not need to have it duplicated.


Remove hardcoded 'stink' username and '1' user_id from source code

I think 'stink'  appears once at the top of the website/active router. And I believe the 1 user_id appears 3 or 4 times in the API router. These hardcoded values currently server as the default whitelist (it is assumed that is_eyes is true for this account). We may need to put these defaults in the config, or maybe we use the lowest user_id that has is_eyes equal to true.

I believe I did this within the last 2 releases. There are config values for this username and user_id.


Python: Function body type hint without assignment is ignored

Issue Type: Bug
The following code should produce intellisense recommendations for list attributes/methods. However, it is still treated as a generic variable.
def test_method(a):
  a: list
  a.<ctrl+space>

Compare this to:
def test_method(a):
  a: list = a
  a.<ctrl+space>

Which produces the expected result.
Extension version: 2021.7.1060902895
VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:30:16.440Z)
OS version: Linux x64 5.8.0-50-generic snap
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz (8 x 3399)

GPU Status
2d_canvas: unavailable_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: disabled_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
1, 0, 1

Memory (System)
15.43GB (5.10GB free)

Process Argv
--no-sandbox --force-user-env --unity-launch --crash-reporter-id decd6d22-e356-4931-9723-127dca212b72

Screen Reader
no

VM
0%

DESKTOP_SESSION
zorin

XDG_CURRENT_DESKTOP
zorin:GNOME

XDG_SESSION_DESKTOP
zorin

XDG_SESSION_TYPE
x11

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwt:30329788
pythonvssor306:30341831
bridge0708:30335490

I'm not sure that this is valid code; that a: list is not an introduction of a variable.
Why are you putting the type annotation in the body of the function as a statement rather than applying it to the parameter itself?

It is certainly valid code (type it in your interactive terminal, it will work without a problem).
As for why anyone would do this: consider the following scenario
no_return_info = lambda: [], 'hi'
a, b = no_return_info()
# How do I know what 'a' is? Type hints
a: list
a.append(5)
# ...

In that case, it is a syntax error to provide type hints on initialization. Hopefully that answers your question.

In your original example, the type annotation should be specified on the input parameter.
def test_method(a: list):
    a.<ctrl+space>

The code you posted in your first sample will run in the Python interpreter without generating a runtime exception, but it is not properly using type annotations, so pyright (the type checker that underlies pylance) will see it as an error. So does mypy.
Your second example above involves a local variable rather than an input parameter, so it works as you expect within pylance. Completion suggestions are provided without a problem in this case. However, I'll point out that this is still considered an illegal use of a type annotation by some type checkers. Mypy will not allow this because it requires type annotations to be specified on the first use of a variable. If you move the a: list before the assignment to a, it will work in mypy as well. Pyright is a bit more flexible in allowing you to annotate a local variable or an instance variable anywhere rather than prior to its first appearance within a file.

I would think you'd type the above as:
no_return_info: Callable[[], Tuple[List[Any], str]] = lambda: ([], 'hi')

But in this case, I would think that type inference gets this correct.

@jakebailey Right, I was quickly typing an example but in reality I don't have control over no_return_info (i.e. it comes from an external definition). Sometimes, those functions can be defined in C or dynamically returning things in which case the default intellisense wouldn't work that way.
@erictraut thank you for your detailed explanation, I wasn't aware of those rules (and have never used mypy before). I encountered the same pylance problem with local variables and my MWE used a function argument since I didn't realize they were treated differently.
Pardon the contrived example, but what about something like this?
import random

class first:
    def whoami(self):
        print('first')
        return 'first'

    def afirstmethod(self):
        print('first method')

class second:
    def whoami(self):
        print('second')
        return 'second'

    def asecondmethod(self):
        print('second method')

def random_class():
    """
    Either returns `first` or `second` 50% of the time.
    """
    if random.random() < 0.5:
        return first()
    return second()

def main():
    x = random_class()
    if x.whoami() == 'first':
        x: first
        # Do things with a `first` object
        x.afirstmethod()
    else:
        x: second
        # Do things with a `second` object
        x.asecondmethod()

if __name__ == '__main__':
    main()

mypy didn't complain about any issues for me, but pylance still provides no type suggestions. Is this considered supported?

I don't think mypy checks functions that don't have type annotations themselves, so you may not be seeing errors due to that.

You are correct, changing it to main() -> None raised mypy errors. Is there any valid way of typing in this kind of scenario?

Yes, Jake is correct. By default, mypy completely ignores the body of a function if its type signature is not annotated, and it always assumes such functions return an Any type. Pyright always analyzes code, and it uses type inference for return types wherever possible.
The standard way to distinguish between objects of different types in Python is to use the isinstance call. If you do this, pyright will use "type narrowing" to distinguish between the different types. Note that the type of x in this case is inferred to be first | second (i.e. it's a union type) until it is narrowed to either first or second based on the test. For more details about type narrowing, refer to this documentation.
def main():
    x = random_class()
    if isinstance(x, first):
        x.afirstmethod()
    else:
        x.asecondmethod()

Pyright supports another type narrowing pattern that may be of interest here if you don't want to use isinstance. You can discriminate types based on a field that is explicitly annotated as a literal type.
from typing import Literal

class first:
    id: Literal["first"] = "first"
    ...

class second:
    id: Literal["second"] = "second"
    ...

...

def main():
    x = random_class()

    if x.id == "first":
        x.afirstmethod()
    else:
        x.asecondmethod()

@erictraut In my code base, first and second are protocol-like, so it's difficult to test for x's type with isinstance. However, I do see your point.
The main reason I submitted a bug report instead of accepting the behavior is due to PyCharm providing intellisense inside the branches, but now I realize that is probably custom logic on their side, not something generically supported by Python's typing standards. I'm OK closing this as a result.


Define a new ItemReference interface to use with DelegatedPermission.

PTAL @patrick-codaio @sam-codaio @drew-codaio @coda/packs
CC @ekoleda-codaio
Eric we had a little meeting to discuss how to shape this, and how this overlaps with the concept of Identities, which I tried to capture in the comments.

Eric we had a little meeting to discuss how to shape this, and how this overlaps with the concept of Identities, which I tried to capture in the comments.

Ya, that surface makes sense given where we are.


Target Scala release 2.13

Currently the code is being cross-built and published for 2.13.0-M3, but 2.13.0 has been released. Could that be updated?
Thanks in advance! :-)

@JamesGallicchio, Yes eventually 2.13 will be cross-built. It depends on whether all the libraries used to build/test/release are available for 2.13.
Thanks for raising issue though.

Compilation seems to be working already. The only problem is with gradle scaladoc plugin that break with scaladoc 2.13 as indicated https://github.com/gradle/gradle/issues/9855

Without being able to generate the scaladoc, it won't be able to be released to the public.

starting point:  Scala 2.13.1
https://github.com/reactor/reactor-scala-extensions/pull/39

This is now done as part of #44. Thank you @giabao


[ISSUE #4673] DLedger quick start document optimize

Make sure set the target branch to develop
What is the purpose of the change
Fix #4673
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4675 (93e136e) into develop (a3aef17) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4675      +/-   ##
=============================================
- Coverage      44.69%   44.60%   -0.09%
+ Complexity      7516     7487      -29
=============================================
  Files            975      975
  Lines          67378    67378
  Branches        8892     8892
=============================================
- Hits           30112    30054      -58
- Misses         33550    33597      +47
- Partials        3716     3727      +11

Impacted Files
Coverage Δ

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (-9.38%)
:arrow_down:

...q/namesrv/routeinfo/BrokerHousekeepingService.java
72.72% <0.00%> (-9.10%)
:arrow_down:

...a/org/apache/rocketmq/logging/inner/SysLogger.java
28.57% <0.00%> (-5.72%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-4.35%)
:arrow_down:

...java/org/apache/rocketmq/logging/inner/Logger.java
51.67% <0.00%> (-4.31%)
:arrow_down:

...apache/rocketmq/remoting/netty/ResponseFuture.java
77.55% <0.00%> (-4.09%)
:arrow_down:

...rocketmq/remoting/netty/NettyRemotingAbstract.java
49.82% <0.00%> (-3.95%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
31.64% <0.00%> (-3.77%)
:arrow_down:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
81.42% <0.00%> (-1.43%)
:arrow_down:

...rg/apache/rocketmq/remoting/netty/NettyLogger.java
14.96% <0.00%> (-1.37%)
:arrow_down:

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Coverage decreased (-0.07%) to 48.85% when pulling 93e136edc29e90369cbca2d60c1bdea9bd3e0a8b on mxsm:rocketmq-4673 into a3aef179f7d07ef0425debff40041f81f1bf94dd on apache:develop.


Code review

Link of the project: https://github.com/ahmedadel56/Recipe-Application/projects/1
Number of people: 2 nice men 😊

**STATUS: APPROVED  🟢 **

Hi Team,
Your project is complete!
Enjoy building the project 2 nice men ✌🏻

Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.

As described in the Code reviews limits policy you have  limited number of  reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.


CDK-674. DatasetDescriptor.checkPartitionStrategy should throw Validatio...

...nException.
I changed methods in DatasetDescriptor, PartitionStrategy, and Compatibility to throw ValidationException rather than IllegalArgumentException or IllegalStateException when an invalid value is specified.

One minor comment, otherwise +1.
I also restarted the tests that had errors, but please check that they pass.