Provide Python-specific README to pypi

Problem description
The main project README is being used to publish to https://pypi.org/project/pulumi/ which is showing JavaScript examples.
Suggestions for a fix
Publish a Python-specific README for the pypi package.

Some considerations on this topic:
The source for content that is shown on Pulumi's PyPi page comes from this line of setup.py where it reads the GitHub repo's README.md
That could read from another file, by adjusting the relative path, e.g. to point to the README.md in the root of the Python SDK folder. Unfortunately, that file is not up to date and needs review.
In theory, someone could replace it, or create a new file like README.pypi.md which is just a copy of the GitHub repo's normal README.md, but with the TypeScript code samples converted to Python. The issue with this approach is that it requires someone remember to update both README files every time. They will gradually drift apart and the PyPi-specific file will become out of date.
Another possibility would be to include a Python code listing as well as a TypeScript code listing in the default README. Another idea would be to add instructions on how to use pulumi convert to convert the example to Python as a way of showing off Pulumi's multi-language code generation capabilities.
That said, I think it's safe to say that since it's been 5 years since this issue was filed, and the way forward isn't really very clear (and time won't change that lack of clarity much) that this is something of a non-issue and we can safely close this ticket as wont-fix. Feel free to reopen if something comes up that changes any of this.


Final keosd unix socket changes

This PR consists of the 3 final keosd unix socket changes.

keosd no longer listens on <IP_ADDRESS>:8900 by default
cleos' default wallet_url is the keosd socket created at ~/eosio-wallet/keosd.sock
cleos' keosd auto launch has been modified to strictly use the new unix socket at the above path. Additionally, keosd will be launched such that its http and https server are disabled.

FWIW, I did verify that the "docker quick start instructions" still work. Those instructions launch keosd with --http-server-address so not really affected by change at all.


Update In-Memory Cache options to match Apollo 3 types

Description
This PR aims to update the in-memory cache configuration type to match the options provided by the Apollo 3 client.
Example:
// This should be possible and currently isn't
export const createGraphQL = createGraphQLFactory({
  cacheOptions: {
    possibleTypes: {
      PricingValue: ['MoneyV2', 'PricingPercentageValue'],
    },
  },
});

For context: the InMemoryCacheConfig interface extends from the current ApolloReducerConfig but since the IntrospectionFragmentMatcher has been removed, we have to rely on the cacheOptions::possibleTypes property to configure supertype-subtype relationships.
Type of change

[x] graphql-testing Minor: New feature (non-breaking change which adds functionality)

Checklist

[ ] I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@jarredszabadi yep. This will allow better configuring the cache when using Apollo 3 on tests.


Decoder.append(stringbuilder) to shift limit by the size of variable data

Decoder that has repeating groups with variable data does not shift the limit by the length of the data when appending to string builder.
This causes the next row to start at the "length" field.

The append method only prints the length of the variable data but does not shift the limit as it is done in getXxxxx() method.
Xxxxx is a name of the variable data field.

Can you  provide an example and can you confirm the language used?

Hi Martin,
The language is java.
The test is  here
My fix is here
Thanks,
Anton

Thanks. I was just pushing a fix as this arrived ;-)


Update python to 3.13 and use it as the default for automated workflows

As requested by pyansys core team:
https://github.com/ansys/pydynamicreporting/issues/194

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.86%. Comparing base (d415360) to head (f903288).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

src/ansys/dynamicreporting/core/serverless/item.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   62.45%   61.86%   -0.59%
==========================================
  Files          22       22
  Lines        6416     6475      +59
  Branches     1213     1231      +18
==========================================
- Hits         4007     4006       -1
- Misses       2035     2095      +60
  Partials      374      374

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[libigl] allow arm and uwp

Fixes https://github.com/microsoft/vcpkg/issues/27084.
Counter PR against #30333 but without a support expression at all. I have tested arm64-osx, arm-windows, arm64-windows, x64-uwp, arm-uwp and arm64-uwp

Please fix conflicts

Conflicts solved :)


Support multiple stable release branches / consider all branches when looking for previous release shas

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[X] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #2202 🦕
We are currently using this fork for our release process and it appears to be working as expected, but I'm sure there are edge cases that aren't being addressed yet.
This PR add a flag --consider-all-branches that, when specified, will use GitHub's compare commits API to compare the commits between head of the branch being released, and the found sha of the previous release, allowing the previous release's sha to be on a different branch. This allows, for example, to have a branch like release-1.7.x, with the latest release being, say, 1.7.4, and then release a new minor version (1.8.0) from a branch like release-1.8.x, and have it correctly show the changelog of commits since 1.7.4, even though that tag is on a different branch.
This PR isn't complete yet, and there's a lot of test coverage missing, but I wanted to get consensus on the approach before investing more time. Thanks!

We ended up forking to get this behavior. If there is interest in it please let me know and I can re-open.


python312Packages.aiomealie: init at 0.4.0

Description of changes
Module to interact with Mealie
https://github.com/joostlek/python-mealie

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321758 run on x86_64-linux 1

4 packages built:

python311Packages.aiomealie
python311Packages.aiomealie.dist
python312Packages.aiomealie
python312Packages.aiomealie.dist


Reduce memory footprint by reducing size of data types

This PR attempts to reduce the memory footprint of using this crate.

String types are changed to Box<str> to save 8 bytes each.
The thin-vec crate is used to replace Vec's, saving 16 bytes each.
Many large Option's are Boxed
Many large types in HashMaps are Boxed

I try to avoid making code-breaking changes, but some return types are changed, such as &Vec<T> to &[T]... in most cases that shouldn't matter.  The entire test suite compiles are run without change.
The current API design prevents more involved optimizations without breaking code.  For example, returning &bool, &u32 etc. prevents those fields from being replaced by smaller, packed data types like bitflags. A future major version should really change those to return non-references instead.
I have given up on optimizing chart data types because they are simply too tedious, and there shouldn't really be more than a few charts in a typical spreadsheet.

@schungx
Thank you for the tremendous corrections.
We have no problem with the revisions and will approve them.

Beware some function signatures have minor subtle differences which may require code changes. Be prepared for some incoming issues on this.

When I have time I'll put in #[inline] on all the trivial APIs.

Noted.
We will include that in the release notes.


Mention different DEFAULT ports for different servers

Note that all ports mentioned below are just default ports and developers can change them:
Ports for admins

8510 is used by turms for admin + metrics APIs
9510 is used by turms-gateway for metrics APIs

Ports for users or LB servers

10510 is used by turms-gateway to provide WebSocket service
11510 is used by turms-gateway to provide TCP service
12510 is used by turms-gateway to provide UDP service

Ports for RPC

18510


document process to manually validate JWT access token signature

Hello Active Directory,
About the underlying process to validate the signature, I would like to get the exact process?
https://docs.microsoft.com/en-us/azure/active-directory/develop/access-tokens#validating-tokens
I'm using implicit flow grant to get identity token (response_type=id_token) and access tokens (response_type=token).
In python I was able to build a script

Loading the jwks uri from https://login.microsoftonline.com/TENANT_ID/v2.0/.well-known/openid-configuration?appid=CLIENT_ID
loading the jwks from the url received in 1. (looks like https://login.microsoftonline.com/TENANT_ID/discovery/v2.0/keys?appid=CLIENT_ID
build the public key based on the kid present in both (identity and access tokens) JWT

BUT
the signature validation is working for the identity token. NOT for the access token !
Since I was able to make it work for identity token, I guess that I'm correctly validating the signature. Can you tell in the documentation what are the exact steps to follow to validate the signature of an Access token JWT, from the raw JWT splitting to the true/false boolean, including cryptographic steps?
Here is my working process for identity token, in python
token = token.encode("utf-8")
signing_input, crypto_segment = token.rsplit(b".", 1)
header_segment, payload_segment = signing_input.split(b".", 1)
header = json.loads(base64url_decode(header_segment))
kid = header.get('kid')
resp = requests.get(f"https://login.microsoftonline.com/{params['tenant_id']}/v2.0/.well-known/openid-configuration?appid={params['client_id']}").json()
jwk_uri = resp['jwks_uri']
resp = requests.get(jwk_uri).json()
jwks = {}
for _ in resp.get('keys', []):
    jwks[_['kid']] = _

jwk = jwks.get(kid)
numbers = RSAPublicNumbers(e=decode_value(jwk['e']), n=decode_value(jwk['n']))

public_key = numbers.public_key(backend=default_backend())
public_key_pem = public_key.public_bytes(
    encoding=serialization.Encoding.PEM,
    format=serialization.PublicFormat.SubjectPublicKeyInfo
)

signature = base64url_decode(crypto_segment)

try:
    public_key.verify(signature, signing_input, padding.PKCS1v15(), hashes.SHA256())
    print("... success")
except:
    print("... failed")

and some utils
def base64url_decode(input):
    if isinstance(input, str):
        input = input.encode("ascii")

    rem = len(input) % 4

    if rem > 0:
        input += b"=" * (4 - rem)

    return base64.urlsafe_b64decode(input)

def ensure_bytes(key):
    if isinstance(key, str):
        key = key.encode('utf-8')
    return key

def decode_value(val):
    decoded = base64.urlsafe_b64decode(ensure_bytes(val) + b'==')
    return int.from_bytes(decoded, 'big')

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2471c08b-befe-8e1a-df08-f13e116c231e
Version Independent ID: 0d827d33-2906-6352-9398-13863def9354
Content: Microsoft identity platform access tokens - Microsoft identity platform
Content Source: articles/active-directory/develop/access-tokens.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

Hi there @raphaeljoie - make sure that you're only validating tokens that have your app's aud claim.  Tokens for Microsoft APIs don't always validate since they use a custom format that they understand how to validate, or they can be encrypted. In general, as a client application you don't need to validate access tokens - there's no benefit to it, and the API will do that validation.

To avoid confusion, maybe AAD shouldn't include the public key in my client's well-known JWK list? Since I was able to get the public key matching the "kid", I expected also to be able to use that key!

This is a good suggestion, and I'll bring it up internally.  Given the mechanisms of how existing apps look up keys and validate tokens, this likely won't be possible (without breaking many Microsoft apps), but for the future it's great to keep in mind.  We're also starting to encrypt access tokens in the future, so that only apps with permission to look inside the token can decrypt them, which will help solve this issue.  I also expect that if we hid the key the next issue would just be "why isn't the key published, I can't verify the token" :)
I've made some updates to the access token page that hopefully help differentiate when and how to handle tokens.

Side question: Is it possible to get an access_token that is targeting my client_id as aud? (= does it make sense to mention signature validation on that page?)

Yes, it is possible, but it isn't necessarily recommended.  In that scenario, an ID token is perfectly sufficient, and likely gives you everything you're looking for today, including validation.

To avoid confusion, maybe AAD shouldn't include the public key in my client's well-known JWK list? Since I was able to get the public key matching the "kid", I expected also to be able to use that key!

This is a good suggestion, and I'll bring it up internally.  Given the mechanisms of how existing apps look up keys and validate tokens, this likely won't be possible (without breaking many Microsoft apps), but for the future it's great to keep in mind.  We're also starting to encrypt access tokens in the future, so that only apps with permission to look inside the token can decrypt them, which will help solve this issue.  I also expect that if we hid the key the next issue would just be "why isn't the key published, I can't verify the token" :)
I've made some updates to the access token page that hopefully help differentiate when and how to handle tokens.

Side question: Is it possible to get an access_token that is targeting my client_id as aud? (= does it make sense to mention signature validation on that page?)

Yes, it is possible, but it isn't necessarily recommended.  In that scenario, an ID token is perfectly sufficient, and likely gives you everything you're looking for today, including validation.

#please-close - docs were updated to clarify that public clients (and client apps in general) must not validate access tokens.  there's both no reason to do so and no expectation they can.


Type of error to allow for custom error messages

Added 'type' to make it easier to detect what the error is and display custom error message.
An example:
{
"status": "error",
"message": "JSON does not validate",
"errors": [
{
"property": "firstName",
"message": "must be at least 1 characters long",
"type": "minLength" // this is what I've added
}
]
}
To do that I had to add an optional argument $type to addError() method.

@onlinesid merge conflicts now as of version 1.4.0
I am in agreement with @keradus on ignoring those files globally on your workstation, and would recommend installing composer globally as well so you don't have to ignore the phar at all.

Thanks for the feedbacks, I have done those things now.

@keradus thanks for the updates.
Your example output:
{
  "status": "error",
  "message": "JSON does not validate",
  "errors": [
    {
      "property": "firstName",
      "message": "must be at least 1 characters long",
      "type": "minLength" // this is what I've added
    }
  ]
}

I don't find the current failure/error messages inadequate or confusing. I am unsure what the goal is. Better i18n?

Hi @bighappyface
No issue/confusion with the current error messages, it's mainly about having a way to detect an error type without having to parse the error message.
It's also about making it easier to customize the error messages. For example "does not have a value in the enumeration" isn't really something that any web/app end user should see :)
I'm using json-schema to validate form on client side and reusing it for server side.

For the client-side validation, are you making a call back to the server to use this validator, or are you using a client-side validator?

No call back to the server. A javascript json schema validator on the client/browser side, and this library for validation using PHP on the server side. So the same json definition is used by client side and server side.

Being you are using a client-side validator, why is the messaging format of the server-side validator a concern for the end user as you described? Doesn't the client-side validator facilitate validation messaging for the end user?

Hi @bighappyface
First of all, server side validation must always exist, any input from the client side must still be validated regardless if validation occurs on the client side or not. So in reality validation happens twice, on the client side and on the server side.
Traditionally, with framework like Symfony for example, on the server side, we would use a form builder. The form builder can add html5 limited validation on the form (like input is required for example).
However I'm trying to move away from that. I think a better way to build a web app is to develop RESTful API for the server side and use angular (or other js framework like it) on the client side. This is a much cleaner model ... more decoupling (or even better if it's 100%) between client and server side. But to achieve that I still need to do validation on the client as well as server side ... this is why I'm using json schema so that the validation for the client side can be replicated in the server side with very little effort and no duplication

@onlinesid,
There is another PR very similar this this, #122. Have you seen it?
I think there is value in what both this and the other PR are trying to achieve; however, considering that #122 was submitted first, and addresses the concerns for more expressive data about the failure than just the constraint name, I think it is fair to determine some kind of reconciliation between them.
Here are a couple of other validators that use the same test suite:
https://github.com/ruby-json-schema/json-schema
https://github.com/geraintluff/tv4
https://github.com/geraintluff/jsv4-php
I believe we should adopt something along the lines of what @geraintluff has done in the error message format. Below is a possible addition to the work you have already done:
JsonSchema\Constraints\StringConstraint
public function check($element, $schema = null, $path = null, $i = null)
{
	// Verify maxLength
	if (isset($schema->maxLength) && $this->strlen($element) > $schema->maxLength) {
		$this->addError($path, "must be at most " . $schema->maxLength . " characters long", 'maxLength', $schema);
	}

	//verify minLength
	if (isset($schema->minLength) && $this->strlen($element) < $schema->minLength) {
		$this->addError($path, "must be at least " . $schema->minLength . " characters long", 'minLength', $schema);
	}

	// Verify a regex pattern
	if (isset($schema->pattern) && !preg_match('#' . str_replace('#', '\\#', $schema->pattern) . '#', $element)) {
		$this->addError($path, "does not match the regex pattern " . $schema->pattern, 'pattern', $schema);
	}

	$this->checkFormat($element, $schema, $path, $i);
}

JsonSchema\Constraints\Constraint
public function addError($path, $message, $constraint = '', $schema = array())
{
	$schema = array_intersect_key((array) $schema, array_flip(array($constraint)));
	$this->errors[] = array(
		'property' => $path,
		'message' => $message,
		'constraint' => $constraint,
	) + $schema;
}

Sample Output
array (
  'property' => 'example',
  'message' => 'must be at least 5 characters long',
  'constraint' => 'minLength',
  'minLength' => 5,
),
array (
  'property' => 'example',
  'message' => 'does not match the regex pattern ^[\\d]',
  'constraint' => 'pattern',
  'pattern' => '^[\\d]',
)

By leveraging the name of the constraint, we can filter the schema to provide the data used in the constraint. Without this information, the constraint name alone is helpful but very limited, and I see something like this eventually happening when you consider both this PR and #122.
Thoughts?

Instead of the suggested:
addError($path, $message, $constraint = '', $schema = array())

I just added optional $error_info:
addError($path, $message, $constraint='', $error_info=null)

For several reasons:

$constraint doesn't necessarily mean there's $schema->$constraint. We should not be making that assumption
Longer term I think addError should take an object instead of more and more arguments. When we keep needing to add argument to a method, it's often means we need to turn the arguments into an object instead.

I'm thinking ConstraintErrorInterface and ConstraintError, but I don't have the time to do that at the moment as I have to work on other part of the project, but I will be coming back to this at some stage.

Also, I'm not sure what the rebase flag is for, there's 0 commit for me to rebase?

I squashed my commits but I made it worse here, it now says 14 commits!
Do I need to 'Close and comment' this pull request then create another one?

After squashing or rebasing you need to push using the --force argument. Instead of that you pull the origin and merge it again.
Do what you need with the branch and push with force, no need for recreating pr

Thanks for that, it works!
I can't squash it to 1 though ... I think it's because I merged / rebase after that first one push

Oh... your changes are on master... please, avoid that in future. What is more you work on master branch, that could be the reason of your problems here.
You should not modify original branches on forked repos.
It may help:
git checkout upstream/master
git branch -D master
git checkout -b master
git cherry-pick --no-commit de769e21ecd10919e059ccfdfd619bff8a954ce4
git cherry-pick --no-commit 4cd973e6cbd90876f08c02d968c3867175bf568f
git commit -m "Added optional arguments \$constraint and \$error_info in addError()"
git push -f

I've moved my commits to another branch, not on master now, please review them on #141 instead.


Uploading small images

Hello! Great plugin!
However, I noticed that it doesn't upload images smaller than 100 KB (this is seen on the live demo as well).
Is there a way around this?

Cropit does reject small images by default, you can change this behavior by using the smallImage-Option (see: http://scottcheng.github.io/cropit/#docs-options-smallImage)
Example:
$('#image-cropper').cropit({
  smallImage: 'allow'
});

Thanks @BugHunter2k. I've added a small image error message on the demo so it doesn't fail silently when image is too small.

Hi @BugHunter2k . Thank for the info, but now, I cannot zoom it in. Why is that?


Bower Integration

Any plans on integrating this project with the Bower dependency management framework (i.e. deploy to bower.io) so we can reference via bower.json?

http://knsv.github.io/mermaid/usage.html

:) Hope it works for you.


Fix on error when parsing CSV and Python 3 support fixing

Thanks for these fixes, the reports/feeds API stuff definitely needs more checking out on my part to make sure it is working for Python 2+3


feat: get governance rewards

Closing as it is a duplicate of https://github.com/interlay/interbtc-api/pull/363


doc: percentiles and hdr merge

@busbey you asked for it (https://github.com/brianfrankcooper/YCSB/pull/1507#pullrequestreview-591345620), you get it ;)
This PR updates a README.md file with the information about how to work with latency percentiles and that a user shall not look up for averages.

@busbey ping

@allanbank ping


FOAMByExample for human consumption

FOAMByExample is modeled and runnable, but we don't have a made-for-human-consumption view of it.

Covered in #153


FIX: var naming convention?

Since there's going to be a bckward incompatibility with the attributes, you may also want to change some of the param names: i.e. underscore to separate words (e.g. applyfilters =>apply_filter), explicit naming (e.g. n => n_sample), no uppercase (e.g. Nx) etc.
WDYT?

you are right.
I will take time to do a code review this week-end, and hunt down this kind of thing.

Decision to replace n_trials by n_matrices here: https://github.com/pyRiemann/pyRiemann/pull/140#discussion_r714660528

Closed with #173, #174 and #175.


DetectFaces throws error

Hi,
Thanks for the plugin. However, it throws an error when I try to use it.
Could you please take a look?
Error occurred when executing DetectFaces:

[ONNXRuntimeError] : 3 : NO_SUCHFILE : Load model from /home/user/ComfyUI/models/landmarks/fan2_68_landmark.onnx failed:Load model /home/user/ComfyUI/models/landmarks/fan2_68_landmark.onnx failed. File doesn't exist

check the readme

Download bluefoxcreation/FaceAlignment model into ComfyUI/models/landmarks


Option to add sidecars

Instead of overwriting the entire container definition, it would be nice to be able to append sidecars. For instance, I'd like to use the ddagent sidecar for datadog metrics and fluentbit sidecar to push logs to datadog.

@antonbabenko this can be closed now, thank you again!

Great @marcoceppi !
@nitrocode Please use v2.26.0 for this feature.

Raising a question here since this is the most relevant issue I can find...  Does anyone (@antonbabenko?) have thoughts on somehow exposing the volume block for the Atlantis ecs_task_definition as a top-level variable for this module so users can optionally specify a Docker or EFS volume? I've personally been bumping up against the limits of the 20GB of storage provided by default for Fargate tasks. The ability to specify a Docker or EFS volume for the Atlantis task's container(s) would be nice. However, this might already be possible and I'm missing something, so I thought I'd sanity check here before creating an issue. Thanks!


Flipping orientation on Android crashes app

Expected Behaviour
Flipping the orientation of the device rotates the scan preview window
Actual Behaviour
Flipping the orientation crashes the app
Steps to Reproduce
Invoke scan window and rotate the device
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 4.4.4
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Motorola XT1039
Cordova CLI version and cordova platform version
cordova 6.4.0
cordova-android 6.1.0
Plugin version
phonegap-plugin-barcodescanner 6.0.4
Logs taken while reproducing problem
W/dalvikvm( 4242): threadid=39: thread exiting with uncaught exception (group=0x4167bd40)
E/AndroidRuntime( 4242): FATAL EXCEPTION: Thread-5660
E/AndroidRuntime( 4242): Process: app.id, PID: 4242
E/AndroidRuntime( 4242): java.lang.IllegalArgumentException: Crop rectangle does not fit within image data.
E/AndroidRuntime( 4242): 	at com.google.zxing.PlanarYUVLuminanceSource.<init>(PlanarYUVLuminanceSource.java:50)
E/AndroidRuntime( 4242): 	at com.google.zxing.client.android.camera.CameraManager.buildLuminanceSource(CameraManager.java:372)
E/AndroidRuntime( 4242): 	at com.google.zxing.client.android.DecodeHandler.decode(DecodeHandler.java:92)
E/AndroidRuntime( 4242): 	at com.google.zxing.client.android.DecodeHandler.handleMessage(DecodeHandler.java:60)
E/AndroidRuntime( 4242): 	at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime( 4242): 	at android.os.Looper.loop(Looper.java:136)
E/AndroidRuntime( 4242): 	at com.google.zxing.client.android.DecodeThread.run(DecodeThread.java:110)
W/ActivityManager( 1020):   Force finishing activity app.id/com.google.zxing.client.android.CaptureActivity

I have the same problem. Running on Samsung S5 (Android 5.0), cordova-android 5.1.1, cordova-cli 6.1.1. Plugin version: phonegap-plugin-barcodescanner 6.0.4 "BarcodeScanner".
Here is my log:
E/AndroidRuntime: FATAL EXCEPTION: Thread-192023                                                                       Process: cz.csdevelopment.nDemo, PID: 6322                                                                       java.lang.IllegalArgumentException: Crop rectangle does not fit within image data.                                                                           at com.google.zxing.PlanarYUVLuminanceSource.<init>(PlanarYUVLuminanceSource.java:50)                                                                           at com.google.zxing.client.android.camera.CameraManager.buildLuminanceSource(CameraManager.java:372)                                                                           at com.google.zxing.client.android.DecodeHandler.decode(DecodeHandler.java:92)                                                                           at com.google.zxing.client.android.DecodeHandler.handleMessage(DecodeHandler.java:60)                                                                           at android.os.Handler.dispatchMessage(Handler.java:102)                                                                           at android.os.Looper.loop(Looper.java:145)                                                                           at com.google.zxing.client.android.DecodeThread.run(DecodeThread.java:110)

Could you please update the plugin from github (which gives you 6.0.5-dev currently) and see if the crash still occurs?

got the same on samsung Crop rectangle does not fit within image data. at com.google.zxing.PlanarYUVLuminanceSource.(PlanarYUVLuminanceSource.java:50) at

    {
      "showFlipCameraButton" : true, // iOS and Android
      "showTorchButton" : true,
     "orientation" : "portrait",
    "prompt" : "FOCUS CAMERA ON PRODUCT BARCODE"
    }

pass this to scan until a fix is available & also to customize the scanner screen a bit with options

@clearride please see my previous comment - on which version did you see this?

@EddyVerbruggen I am not able to get 6..0.5-dev  , my current plugin ver is 6.0.4, but I'm not held up here as my need is for a portrait view mode only.

@clearride I get that this isn't your problem, but it would help everybody if anyone could test the changes made for this issue in 6.0.5-dev. It's just a matter of specifying https://github.com/phonegap/phonegap-plugin-barcodescanner as the plugin source instead of the npm package name.

@EddyVerbruggen got it, looks like it works on my setup & test with samsung galary(android 4.1.1) & Xiomi (android 6)

@clearride That's great, thanks for the test! That reassures me we can push this to npm soon 👍

6.0.5 is on npm.


Update kubelet command line reference

Ran into a 401 unauthorized issue after migrating from command-line flag to kubelet configuration file.
So I added a hint to warn inconsistent default values for "authorization-mode"

/assign @zacharysarah @sftim

Seems related to https://github.com/kubernetes/kubernetes/issues/68939
@kbhawkey @tengqm I looked that the history of kubelet.md and it appears some manual edits have made it in as well as some automatic generated PRs too. Feel free to approve if correct approach.
/lgtm

Yeah, I explored the source code and found the difference is made by intention.
Also there is a statement on kubelet-config-file page saying that:

Note that some default values differ between command-line flags and the Kubelet config file. If --config is provided and the values are not specified via the command line, the defaults for the KubeletConfiguration version apply.

It could be better if we point out what exactly the differences are.
This PR is a little one step forward.

Hi @povsister .
Thanks for opening this pull request.
The kubelet reference page is not generated (I do not know the history
of why the kubelet flags are managed the same as other components).
To keep things in sync, the flag text that is documented in this page should match the output
of the flag value when you run the kubelet. Right now, manual fixes are okay as long as
the text matches.
I have not confirmed, but hope the text for this flag is fixed in kubernetes/kubernetes.

@povsister , Are you able to squash your commits? Thanks!

Are you able to squash your commits? Thanks!

Do you mean sync change of this message to kubernets/kubernets repo?
I just checked the code, found that both (default "AlwaysAllow") and (DEPRECATED: This is a cadvisor flag that was mistakenly registered with the Kubelet. Due to legacy concerns, it will follow the standard CLI deprecation timeline before being removed.) statements are auto-generated at runtime.
It's not possible to sync the text inside kubelet elegantly.
I will dig deeper later.
Temporarily hold this PR.
/hold

Hi @povsister .
It is okay to go ahead with this change.
It would be wonderful if you could log an issue with the kubelet source code (to update the flag if possible).
Are you able to squash your commits?

@kbhawkey Not yet. I am using GitHub web to create this PR.
Need to clone the whole repo if you want a beautiful git commit log.
I'll do that later causing I am on vacation today.

@kbhawkey Commits squashed.
Next I'll try to fix the kubelet help message in the code instead of simply log an issue.
Feel free to remove the hold label  if you want to merge this commit.

/sig node

Next I'll try to fix the kubelet help message in the code instead of simply log an issue.

That sounds like a good approach. Feel free to label the kubelet code change with /sig docs.

/hold cancel

Page preview:
https://deploy-preview-20855--kubernetes-io-master-staging.netlify.app/docs/reference/command-line-tools-reference/kubelet/
/lgtm

/approve


State Collection Not Filtering

Provide a general summary of the issue here
I have created a multi-select dropdown using react-aria hooks and the issue I am having is this:

When the user types in their search term, the dropdown list filters down correctly.
Then when the user presses the down key, the dropdown list filter is removed but the search term is still selected.

My code for the keydown is:
onArrowDown: () => {
    state.selectionManager.focusedKey
      ? state.selectionManager.setFocusedKey(state.collection.getKeyAfter(state.selectionManager.focusedKey))
      : state.selectionManager.setFocusedKey(state.collection.getFirstKey(), 'first');
    state.selectionManager.setFocused(true);
  },

I am using useListState like this:
  const filter = useCallback(
    (nodes: Iterable<Node<ListBoxItemType>>) =>
      search?.length
        ? Array.from(nodes).filter((item) => item.textValue.toLowerCase().includes(search.toLowerCase()))
        : Array.from(nodes),
    [contains, search],
  );

  const state = useListState<ListBoxItemType>({
    items,
    children: getItemChildren() as CollectionChildren<ListBoxItemType>,
    selectionBehavior: 'toggle',
    selectionMode: 'multiple',
    selectedKeys: selectedItems.map((item: ListBoxItemType) => item.id),
    filter,
    onSelectionChange: (keys: Selection) => {
      const selectedKeys =
        keys === 'all'
          ? selectedItems.map((selectedItem) => selectedItem.id as string)
          : Array.from(keys.values() as unknown as string[]);
      onSelectionChange(selectedKeys);
      clearSearch();
    },
  });

🤔 Expected Behavior?
I expect the list to remain filtered when I use the arrow keys to navigate to the select the item.
😯 Current Behavior
All of the items show up in the unfiltered list when I press down key.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
See above.
Version
3.29.1 of react-aria
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge, Other
If other, please specify.
No response
What operating system are you using?
Mac OS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Could you provide a minimal reproduction for us? At a glance I don't see anything that could be causing this behavior from your shared code but I'm unsure what hooks you are using or if you have your own custom hooks powering the keyboard interaction behavior

Closing as stale


Update Pillow Examples to include 1.47 and 1.9 inch displays

I was giving this a quick look and it lGTM, but I was surprised the 1.47 was wider than the 1.9. Is that correct?

Not physically, but pixel-wise it is.


Ability to hide line numbers

Sometimes we don't want to display line numbers.
Describe the solution you'd like
It seems that we should add another optional argument to highlightElement. It should be an object with parameters (more settings can be tweaked here in the future).
Describe alternatives you've considered
We don't have some solution with this package.
Additional context
I can create a PR with this feature. I only want to hear your approval.

this is great idea,
you can create a PR with this feature but try to keep the size as small as possible,
thanks,
Mathias


using composer for download and update of shopware

What about using a composer based install?
I am thinking of

cloning shopware/composer-project
adapt content of .env and composer.json (for different shopware versions)
run composer install/update

By using composer we could handle dependencies effectively.
What is your take on this?
cheers tom

So far i have this and it seems to work:
/**
 * composer based install
 */
task(
    'shopware:install',
    function () {
        run('mkdir {{shopware_temp_dir}}');
        run('cd {{shopware_temp_dir}} && git clone https://github.com/shopware/composer-project.git');
        run('rsync --recursive --ignore-existing {{shopware_temp_dir}}/composer-project/ {{shopware_public_path}}/');
        run('rm -rf {{shopware_temp_dir}}');
        run('cd {{shopware_public_path}} && composer install');
    }
)->desc('checkout shopware composer project');

This assumes there is a composer.json in repositories web folder.
(taken from shopware/composer-project)
The shopware version can be set in the require setting.
As well as adding requirements
"k10r/staging": "1.0.3",
"k10r/deployment": "1.2.0"
in that composer.json.
I could do a PR if that helps.
Cheers tom

Hi Tom!
We're currently not using this setup for composer-based Shopware environments. If this works for you, feel free to create a PR with a separate deploy-shopware-composer.php augmenting the base configuration with your composer-specific tasks :-)
It may however be more suited for a fork, as we'll probably not be able to maintain that configuration.
Best regards
Uwe


Add custom button/link on JupyterHub launch screen

Context
@iameskild has done a bit of research on this and it looks like Jupyter_app_launcher will give us the functionality we need. We just need add an additional button on the existing Jupyterlab launch screen.

Value and/or benefit
For our usecase, this will be an nbgitpuller link which will clone a repo into nebari, though there are a wide variety of usecases for this functionality.
Anything else?
The outcome here should be a pattern to follow, successfully launching this on a nebari instance, and a tutorial explaining to others how to do it on their own.
Ultimately, we may want to use this functionality to ship easy-access examples to users when the examples folder is deprecated.

@kcpevey It seems that we can easily add a button, and we can create a link with nbgitpuller, but it doesn't seem possible to combine this ability right now.  Or at least, I could not get it to work locally.
@iameskild and I met today to discuss this.  He had not been able to get these 2 to work together either.  We tried the following:

Adding a button, and trying to open the link produced by nbgitpuller.  It will not open either in the nebari hub, or from the local jupyter instance.  Changing the address a bit did not help this. We could get it to open up another jupyter lab session in a jupyter lab window, but not grab the git repo.
There is an example on jupyter app launcher that will run a streamlit app. It has some args that you can specify a command to run.  We tried to open the webpage from there.  It will attempt to open a new window from a new port, but still no github repo.
The same command line approach as #2, but instead I tried to see if it would clone the repo.  It does not and it freezes.
We also tried to see if there was a way to open a jupyter notebook from the terminal, thus giving us a command we could potentially use in a shell script, but it is not possible at the moment.  https://github.com/jupyterlab/jupyterlab/issues/5056

We could open a notebook from a button, which if the user runs through it, they can have an intro to nebari that can clone or update repos and open them up?    Any other thoughts on a direction to take?
@iameskild did I miss anything?

@iameskild @aktech  Do you know if the work in https://github.com/nebari-dev/jhub-apps will supersede this issue?

Yes, I will close this since the App Launcher will provide equivalent functionality.


Use dates

Hello,
Thank you for this great plugin.
I would like to use it to define a date based on another one (also a custrom field) but I don't know how to manipulate the datetime format (I tried this =>  http://apidock.com/ruby/v1_9_3_392/Time/%2B but it didn't work :/ ). For exemple : date_B = date_A + 3 days.
Thank you very much for your help. :)

Hi. Check this issue #20

Great thank you 👍


[AIRFLOW-XXX] Fix typo

Make sure you have checked all steps below.
JIRA
[AIRFLOW-XXX] as typo fixes

Description
typo fixes

Tests
n/a

Commits
n/a

Documentation
n/a

Code Quality
n/a

thanks!


Error executing process > 'POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE

Description of the bug
I have test the functionality with the command provided in the README:
nextflow run scalepopgen/
-profile test,docker
-qs 10
but I keep having an issue with admixture.
I executed the same command but changing the -qs:
nextflow run scalepopgen/
-profile test,docker
-qs 2
but I had the same issue.
I have run the command several times, and the only change I have seen is K number used in the admixture command.
Also, I have deleted the work, test, and scalepopgen directories and tried all from cero, but the problem still the same
I have no clue about what the problem is. Any help would be great.
Cheers
Command used and terminal output
$ nextflow run scalepopgen/ -profile test,docker -qs 2

[-        ] process > POPGEN48_SCALEPOPGEN:SCALEPOPGEN:MULTIQC_GENETIC_STRUCTURE                                                         -
[b4/b87a63] NOTE: Process `POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)` terminated with an error exit status (139) -- Execution is retried (1)
[f2/4cdfd7] NOTE: Process `POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)` terminated with an error exit status (139) -- Execution is retried (1)
[28/ae9d00] NOTE: Process `POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)` terminated with an error exit status (139) -- Execution is retried (1)
[57/310939] NOTE: Process `POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)` terminated with an error exit status (139) -- Execution is retried (1)
[52/56f0f7] NOTE: Process `POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)` terminated with an error exit status (139) -- Execution is retried (1)
ERROR ~ Error executing process > 'POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)'

Caused by:
  Process `POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE (scalepopgen_ld_filtered_update_chrom_id)` terminated with an error exit status (139)

Command executed:

  admixture \
      scalepopgen_ld_filtered_update_chrom_id.bed \
      3 \
      -j2 \
      --cv=5 >& 3.log

  cat <<-END_VERSIONS > versions.yml
  "POPGEN48_SCALEPOPGEN:SCALEPOPGEN:RUN_ADMIXTURE:ADMIXTURE":
      admixture: $(echo $(admixture 2>&1) | head -n 1 | grep -o "ADMIXTURE Version [0-9.]*" | sed 's/ADMIXTURE Version //' )
  END_VERSIONS

Command exit status:
  139

Command output:
  (empty)

Command error:
  .command.sh: line 6:    38 Segmentation fault      admixture scalepopgen_ld_filtered_update_chrom_id.bed 3 -j2 --cv=5 &>3.log

Work dir:
  /work/dir/work/8b/75d8eade6408937d0d1f397045f298

Tip: view the complete command output by changing to the process work dir and entering the command `cat .command.out`

 -- Check '.nextflow.log' file for details

Relevant files
17042024.nextflow.log.txt
scalepopgen.zip
System information
N E X T F L O W  ~  version 23.10.1
Desktop Workstation
Docker
Ubuntu 22.04.4

Hello!
As far as I can see from your log file, 32 CPUs and 23.3 GB (13.8 GB) memory is available to you. The Admixture module is running with »process_high« resources, meaning with max 12 CPUs and 72 GB of memory per job, which is probably causing the problems in you case. You can check different process-specific resource requirements here: scalepopgen/conf/base.config and adjust them according to your local computing system. I would suggest to run the script with »process_low« and with 1 CPU. In the file scalepopgen/modules/nf-core/admixture/main.nf change the label »process_high« to »process_low« or dont change anything and just reduce the number of parallel jobs from 2 to 1, i.e. "-qs 1".
Please let us know if this solved the issue.

Hello, yeah I agree with @NPogo. From your log file, it appears that all the processes are completed (except Admixture) and this process requires large number of CPUs. Run with "-qs 1" as suggested by @NPogo, and let us know whether it worked.
Just for your info, I ran the following command on my local desktop after git cloning the repo and using docker
nextflow run scalepopgen/ -profile test,docker -resume -qs 1

and it successfully completed within ~30-45 minutes (see the log file attached).
In your run, the exit code is 139 and it could mean that the program was terminated because of some memory violation issues.
Please let us know if you still have the same issue.
test_docker_run.log

Hello!
Thanks for the quick response.
I did three different tests based on your suggestions:

Just changing to -qs 1
Changing to -qs 1 and the scalepopgen/conf/base.conf file (attached)
Changing to -qs 1, the scalepopgen/conf/base.conf file and the scalepopgen/modules/nf-core/admixture/main.nf file (attached)

For each case, the problem persisted. I also removed the folders and tried from a new cloned directory with the changes mentioned.
Im working in a Windows 10 workstation with WSL2 activated and Ubuntu 22.04.4.
I have docker installed in Windows and linked to the WSL2 and working on Ubuntu.
Cheers
modifyied_files.zip

I have tried the pipeline in a server, and I had an issue with Admixture:
Command error:
  Unable to find image 'quay.io/biocontainers/admixture:1.3.0--0' locally
  1.3.0--0: Pulling from biocontainers/admixture
  docker: [DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of quay.io/biocontainers/admixture:1.3.0--0 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2.

This is because docker schema 1 is not supported by default in docker engine version 26, and this support will be removed completely in future versions.
After fixing this, I could make it work on the server and the test profile ran successfully on the server.
So, I do not know what the problem might be in the local computer. Could be about the RAM, but I have set the parameters the way you suggested and the problem still happening.
Any further suggestions to fix the problem in the local computer?

So based on this blog on Nextflow website (https://www.nextflow.io/blog/2021/setup-nextflow-on-windows.html), I hypothesize that it could be an issue with docker image of ADMIXTURE tool. It could be that docker of ADMIXTURE tool is not compatible with the windows subsystem Linux (WSL). Try the solutions mentioned in the section "Step 3" of the above-mentioned blog; basically, follow these steps  ( I am quoting exactly from the above-mentioned link):
1). Edit the .wslconfig file in your Windows home directory. You can do this using PowerShell as shown:
PS C:\Users\<username> notepad .wslconfig

2). Add these two lines to the .wslconfig file and save it:

[wsl2]
kernelCommandLine = vsyscall=emulate

3). Restart your machine.
Let me know if it works.
Unfortunately, I don't have access to WSL for now so I really cannot test it. One thing that I could do is containerized the ADMIXTURE tool on the new base image and replace it with the biocontainer image in the workflow. This could take sometime but meanwhile, I am glad that you managed to run test example on your server.

I checked the blog and I followed your suggestion. And it worked! Even with the parameter -qs 10
Thanks a lot!

I checked the blog and I followed your suggestion. And it worked! Even with the parameter -qs 10
Thanks a lot!
I'm closing the issue since that change solved it.
Cheers


Static assets in node_modules error on import

Describe the bug
Importing svgs and pngs works in the package that Vite is being run in but fails in packages in node_modules.
Example:
import buildingv2 from './buildingV2.svg'
export const BuildingV2 = ({
  alt = 'Building',
  size = 60,
  ...props
}) => {
  return (
    <img
      alt={alt}
      height={size}
      loading="lazy"
      src={buildingv2}
      width={size}
      {...props}
    />
  )
}

If this code snippet is in the same package as Vite it will work with no issues but if the same code snippet is in node_modules  this error will occur
|- /Users/xxx/src/xxx/node_modules/xxx/icons/lib/img/buildingV2.svg:1
<svg width="61" height="60" viewBox="0 0 61 60" fill="none" xmlns="http://www.w3.org/2000/svg">
^

SyntaxError: Unexpected token '<'

My initial thoughts were that Vite just needed to include these packages on build but nothing I try seems to parse files in node_modules correctly. I'm hoping this is just a bad config on my end which can be answered easily, the packages in question are private so the reproduction URL is invalid for now.
Vite config:
import { defineConfig } from 'vite'
import tsconfigPaths from 'vite-tsconfig-paths'
import react from '@vitejs/plugin-react'
import { viteCommonjs } from '@originjs/vite-plugin-commonjs'
import { isomorphicImport } from 'vite-plugin-isomorphic-import';
import EnvironmentPlugin from 'vite-plugin-environment'

export default defineConfig({
  esbuild: {
    loader: "tsx",
    include: [/.*\.[tj]sx?$/],
    exclude: [],
  },

  ssr:{
    noExternal: [
      '@xxx/attribution', // pngs
      '@xxx/sharing-popover',// pngs
      'framer-motion', // export error
      'style-value-types',// export error
      'popmotion',// export error
      'framesync',// export error
    ]
  },
  build: {
    target: 'esnext',
  },
  plugins: [
    EnvironmentPlugin('all'),
    react({
      jsxImportSource: "@emotion/react",
      babel: {
        plugins: ["@emotion/babel-plugin"],
      },
    }),
    tsconfigPaths(),
    isomorphicImport({
      client: [],
      server: ['perf_hooks'],
    }),
    viteCommonjs(),
  ],
})

Reproduction
https://codesandbox.io/
Steps to reproduce
No response
System Info
System:
    OS: macOS 11.3.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 32.40 MB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.volta/tools/image/node/18.16.0/bin/node
    Yarn: 3.2.1 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 9.6.7 - ~/.volta/tools/image/npm/9.6.7/bin/npm
  Browsers:
    Chrome: 117.0.5938.62
    Firefox: 101.0
    Firefox Developer Edition: 118.0
    Safari: 14.1

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Can this be re-opened? I'm having the same issue when using a dependency in node_modules that requires a static .png from within the package's own /assets directory.
In dev I can fix this with vite-plugin-babel + https://www.npmjs.com/package/babel-plugin-transform-assets, however, after then deploying a prod build and invoking an SSR page, the app crashes/fails to load. Error logs show the invalid token/syntax (basically, the prod build has reverted back to the "no Node loader exists to handle this file during SSR" issue, indicating that the Babel "fix" isn't being applied to the prod build).
Initially I thought rollup was causing this, but testing with other rollup plugins they seem to work fine during build. And now I'm seeing that ESBuild is in fact used for part of the build process (I thought it was only applied in dev mode)??
In the end I basically tried brute-forcing every possible config option i could think of but nothing works. I understand that these issues are systemic within the JavaScript ecosystem and Vite's team is doing its best to standardise modern conventions, however, there is a mind-boggling explosion of complexity with SSR, ESBuild, CJS/ESM interoperability, rollup, and then sometimes even necessary requirements of 3rd-party libs not controlled by the developer, e.g. transpilation tools like Babel. Also note that these crazy pipelines are not voluntarily introduced by developers, but are in reality a necessary inclusion to get many popular 3rd-party deps working with Vite.
This complexity is compounded by an apparent lack of transparency/observability into the entire dev+ build pipelines. Such opacity may be intentional from Vite to shield users from the "config burden" of predecessors like Webpack, but in many cases IMO it's making everything needlessly complex.
Apologies for the rant. I do have huge respect for Evan and the team. Just wanted to get these honest frustrations off my chest. I also don't know what the solution is, but maybe we could start by offering developers much clearer and stronger guidelines for how things are done in Vite-land, how to debug common issues, and improving visibility into the whole process from an SSR dev -> prod build.


Fix #264 and #132

@xukai92 There is a small issue for supporting explicit return statements. I have documented the issue in #323. It should be OK to merge this PR now as we can probably fix #323 later.

Do you think it might be better to just store them in spl.info?

Do you think it might be better to just store them in spl.info?

We want to be able to run the program without any samplers, so it's better to keep model function independent of sampler specific data structures. But as an alternative, we could modify the compiler so that model functions return (v::VarInfo, s::Union{Void, Sample} instead of v::VarInfo if needed.

I would prefer to return the tuple instead of putting things into VarInfo. What I am concerned is that the putting return samples will be carried with VarInfo, which may slow unnecessarily down the whole sampling?
Maybe we can also do things differently depending on if sampler is nothing - do nothing for return statement if sampler is missing and update them in sampler if it exists. In this way we always return vi still.

I would prefer to return the tuple instead of putting things into VarInfo. What I am concerned is that the putting return samples will be carried with VarInfo, which may slow unnecessarily down the whole sampling?

Let's go for a tuple for #323

I haven't make it to update the value yet

I haven't make it to update the value yet

That's OK. I will merge this PR when you are done.

I realise that my implementation actually has a bug where it doesn't handle coroutines correctly.

Regarding the corountine issue, I ended up adding a new filed to VarInfo, for the following reason:

We need store "predictions" in corountine level. There are many ways to do, e.g. what we did before is using task.storage. We can also add fields to particles but I choose to bind that to VarInfo for consistence.
Adding a new filed to VarInfo makes it easy to drop the predictions after each vi -> sample conversion, so that we don't waste time to copy them in the future.

This currently gives me error and need to be fixed. I disable the empty now.

Adding a new filed to VarInfo makes it easy to drop the predictions after each vi -> sample conversion, so that we don't waste time to copy them in the future.

Adding a pred field to VarInfo sounds good!

The update of pred into sample is on L67 in helper.jl. I was trying to reset pred after each conversion, but it gives me error when wrapping samples into Chain (seems for PG only). I put comments from L73 to L79. Can you have a look at it?

Another bug of explicit return:
When HMC dealing with numerical overflow, it only recovers the theta but not the vi.pred used by last numerical OK run of model.

Note: I merged the part fixing #264 of this PR into the master branch.

@xukai92 Yes, let's do that and merge this PR.

@yebai I've disabled the explicit return. Can you review this PR and accept it if everything is fine?


Autoscrolling doesn't behave correctly when switching tabs

Describe the bug
When you have a tab scrolling in the background and switch to other tabs, the scrolling function doesn't respond correctly when coming back to that tab.
To Reproduce

Start Autoscrolling in any tab.
Keep switching between tabs, at least 3 times.
Go back to your scrolling tab from Step 1.
You can no longer stop scrolling that tab. When you activate the extension again, instead of stopping the scroll, it will instead scroll twice as fast.

Expected behavior
When coming back to the scrolling tab from the background, activating the extension again in that tab should correctly stop the scrolling.
Desktop:

OS: Ubuntu 18.04
Browser Firefox
Version  61.0.1

I think this might be fixed or work better after the setTimeout is changed to setInterval, as proposed in https://github.com/pinkienort/AutoScrolling/pull/16/files#diff-421fcea811dc9e4c3d2d0486f63e42eaR13. It won't scroll twice as fast or bug out because we keep that reference to the ongoing interval instead of creating new callbacks.


Fix crash on inifinty cols + support select those tables for delete

Cant be sure it actually solve it (we don't have a way to reproduce) but I think it might.
I think 100 is ok, this is not stop users from creating larger tables it's just stop "fixing" larger tables


(Maybe a bug?) Trading/Villager Gui lets you place stuff where you probably shouldn't

im not sure if this is intentional because it lets you trade if you put the required items in either slot

though, if this is a bug, this could possibly be used as an easy way to edit villager trades.
Like instead of using a command generator you could just place and remove items from the villager ui.

also another small bug i saw was that short grass appears to be missing from the creative gui, likely due to the rename of the item id to be called minecraft:short_grass instead of minecraft:grass

 im not sure if this is intentional because it lets you trade if you put the required items in either slot
though, if this is a bug, this could possibly be used as an easy way to edit villager trades. Like instead of using a command generator you could just place and remove items from the villager ui.

Yeah, this is intentional, as a way of manual trading and compatibility with servers without this mod, you can see that the "fake slots" dissapear when you put any item in any slot.
I'm more intrigued by the aliasing issues in the interface, are you using a version older than 1.2, or does the problem persist on some screen resolutions?

also another small bug i saw was that short grass appears to be missing from the creative gui, likely due to the rename of the item id to be called minecraft:short_grass instead of minecraft:grass in 1.20.4

Thanks for reporting this, I had forgotten about this change, it'll be fixed in the next version.

@Wilyicaro No mean any pressure but I'm just curious what have u been working on for the next update for this mod? Sorry for asking.

the screen issues may have something to do with the mods im using, as I have encountered some issue that bumps the gui scale up by 1 when i enter the pause screen, so i am always playing on a gui scale one less than usually
so maybe that might have something to do with the ui being messed up?

it is essential that causes the gui scale increase issue
https://modrinth.com/mod/essential
i guess whatever modifications they make to the pause screen just mess it up

Sorry, but I can't do much, as Essential is apparently closed source, so only its developers can fix it

yeah thats fine it's really only noticeable in the villager gui
it only causes small like lines in the crosshair and health and hunger bars to appear


Prometheus shared instance is not thread-safe

Hey, consider me an early adaptor as I am running a fork of VaporMonitoring 1.0 currently in production to monitor a microservice. One change I had to do in my fork was to isolate the shared state of collected metrics behind a lock (serial queue). Otherwise you might run into subtle undefined behavior. Xcode will warn you about this, if you enable the thread sanitizer runtime diagnostic.
In this project the same problem exists. The shared prometheus instance will be accessed from different EventLoops (threads) at the same time reading and mutating the metrics storage. This needs to be synchronized by some form of locking.
You can see this by running your example and:
wrk -t 1 -c 100 -d 5m "http://localhost:8080/hello"
and then accessing the prometheus endpoint. Xcode (with thread sanitizer enabled) will show you a race-condition warning.

Hi,
First off, thanks for reaching out and adopting 😄, greatly appreciated! I see what you're saying and will try to get this fixed! To be honest though, I have no idea how all these thread things work, and how/where to fix this issue 😅. I'll do some research, but if you have any pointers for me, that'd be greatly appreciated!

Hey, no worries. This stuff can be quite an art of its own. I’m happy to help you. Let me come back to you with a concrete example how to solve the threading issue.

Thread safety should have been achieved with the 0.2.0 release and the Vapor Monitoring 2.1.1 release


As a CMS editor, I can add, edit and remove an individual user

All existing features remain.

In v3.0 and beyond it would be great to see information links next to each user group that provides a summary of the user group for the CMS editor to quickly understand user permissions assigned.

@ChrisMarsh82 this is done and you can close this.


Improve UI video teachers dashboard

Purpose
Feedbacks from the learning analytics workshop concerned the user experience that needs to be improved in the teachers dashboard
Proposal

[x] Fix following variable values: Statements interval = 1d / View count threshold = 30s / Event group interval = 1
[x] Add the title, the number of students and the start and end dates of the course in the course overview

@jmaupetit @SergioSim Maybe the three constants variables can be just regraded as project constants and not variables anymore? WDYT?

Hello @quitterie-lcs ) If we limit the user choice to a single value, I think it would be better to have them as constants)

I've added a commit with minor fix and improvements to the fixtures script. Feel free to do whatever you want with it!


Scroll inside fixed element?

Hi,
When I init a Scrollbar I am unable to scroll on the div on the left unless my Scrollbar reaches the top or bottom?
How do we handle scrolling inside a fixed div?
I was looking for answers but couldnt find anything that fit my pb.
Thank you for the help and great library !

You can use the delegateTo option to delegate wheel/touch events to another element. For your case, you can set delegateTo: document so that all the wheel/touch events will be handled at document level.
See: https://github.com/idiotWu/smooth-scrollbar/blob/develop/docs/README.md#available-options-for-scrollbar

You can use the delegateTo option to delegate wheel/touch events to another element. For your case, you can set delegateTo: document so that all the wheel/touch events will be handled at document level.
See: https://github.com/idiotWu/smooth-scrollbar/blob/develop/docs/README.md#available-options-for-scrollbar

Grea! Thank you

Grea! Thank you


Add official support of Python 3.12

Python 3.12 was released on Monday Oct 2. Bandit should be built and tested on this version going forward.

Block by https://github.com/mtreinish/stestr/pull/353

Maybe we should just switch to pytest?

Maybe we should just switch to pytest?

Probably at some point. But for now it's fixed.


acr configuration needs to be easily copy/paste-able

Should look more like this with semi-colon at the end so it's copy-pasteable.

# set these values to yours
ACR_SERVER=<fill_acr_server>;
ACR_USER=<fill_acr_user>;
ACR_PWD=<fill_acr_pwd>;

docker login --username $ACR_USER --password $ACR_PWD $ACR_SERVER

Agreed, feel free to adjust and create a PR.


Fix clippy lints in v0.23.x

Just some minor lints picked up by Rust 1.61 in the tools directory.

Codecov Report

Merging #1150 (b5c3dff) into v0.23.x (3b1798a) will increase coverage by 0.0%.
The diff coverage is n/a.

:exclamation: Current head b5c3dff differs from pull request most recent head 1c72222. Consider uploading reports for the commit 1c72222 to get more accurate results

@@           Coverage Diff           @@
##           v0.23.x   #1150   +/-   ##
=======================================
  Coverage     67.4%   67.4%
=======================================
  Files          212     212
  Lines        20280   20280
=======================================
+ Hits         13676   13679    +3
+ Misses        6604    6601    -3

Impacted Files
Coverage Δ

abci/src/server.rs
9.2% <0.0%> (-0.2%)
:arrow_down:

tendermint/src/node.rs
63.7% <0.0%> (+0.1%)
:arrow_up:

light-client-verifier/src/types.rs
38.2% <0.0%> (+0.2%)
:arrow_up:

testgen/src/header.rs
85.0% <0.0%> (+0.5%)
:arrow_up:

testgen/src/vote.rs
84.8% <0.0%> (+0.8%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1798a...1c72222. Read the comment docs.


Issue running server

I just stumbled upon this today, when I run the server I get the following:
route-config.js:51
throw 'Unable to load ' + routeItem.controller + ": " + e;
^
Unable to load ../controllers/v1/rooms/rooms-controller: Error: Cannot find module '../controllers/v1/rooms/rooms-controller'

Hi, thanks so much for giving this a try!
The problem is, that npm start doesn't automatically compile coffeescript files. I'm looking into this. In the meanwhile, you can install coffeescript compiler (coffee) and then use it to compile the app/ folder. Just run coffee --compile app from the repo root. After that, I was able to start the server without problem.

I added npm run-script build to compile CoffeeScript files. It is described in README.

Thanks so much! Giving it a shot now!

Thanks so much. The server loads now. I ran into another small issue, when I load up a YouTube video I get this:
server/app/domain/youtube/youtube.js:31
item = data['items'][0];
^
TypeError: Cannot read property 'items' of undefined
server/app/domain/youtube/youtube.js:31:24
Seems like data is undefined

I see, there seems to be a problem with the youtube library that we're using. I'll look into it later.


qBittorrent "unauthorized"

Environment
Docker
Version
v0.7.2
Describe the problem
I have added qbittorrent tile using my server local IP (as http, not https), username and password. When I click it a new blank tab opens with just a tiny "unauthorized" word in top left corner. If I click the same exact link from Portainer, qbittorrent opens normally asking for user/pass. Same exact IP:port. Homarr = unauthorized / Portainer (or manual IP entry) = no problem.
When I click from Homarr, no new info appears in Portainer logs.
Additional info
I have not set any PUID/PGID for Homarr, is it possible that it has anything to do with that? All other tiles I've added with both local and external link work fine, Only qbittorrent has this problem

.
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

This is a known issue and related to qbit specifically. You can look for it on the web for a common solution.
I don't really know how to fix it code-wise so is it's really bothering you apply the fixes found online

Ah, thanks, found and solved!
"You can change the setting in the WebUI under Options -> Enable Cross-Site Request Forgery (CSRF) protection. Uncheck it."

Ah, thanks, found and solved!
"You can change the setting in the WebUI under Options -> Enable Cross-Site Request Forgery (CSRF) protection. Uncheck it."

thanks, it works for me.

@ajnart, Thanks!

@ajnart, Thanks!
It would be nice to add some note in the interface when setting up the qBitTorrent widget

If you want to contribute to homarr you could add this to the docs at ajnart/homarr-docs 😉

@ajnart, Yes, that's a good idea, I'll try to do that when I have time, thanks!


Add URL to readthedocs.io

https://py-tutorial-de.readthedocs.io/de/python-3.3/index.html

absolutely correct, readthedocs.io point to Bitbucket.


added Groups in Permission struct

Hello,
I just started to use casdoor, it is a great work, thank you ! I was testing the different possibilities when I figured out that the "Groups" were missing from the Permission struct.
I just tested to add it, it works on my system, I added it to test, test is passing, I think it is ok.
Tell me whether if this PR is ok for you :)
Thank you !

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[fix]Make sure only call once set_dict_encoding_type for each ColumnReader

Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (Yes/No/I Don't know)
Has unit tests been added: (Yes/No/No Need)
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

std::once_flag is used to process multiple threads, does we should use it on there?

std::once_flag is used to process multiple threads, does we should use it on there?
ColumnReader maybe be used by multiple queries.


No main_frame for some pages

For example:
https://victorzhou.com/blog/replacing-disqus/#:~:text=Commento is orders of magnitude lighter than Disqus.&text=It's open source and can,collect as little as possible.&text=It has an Import from,old Disqus comments to Commento.

It seems to be working with the current version. Closing.


Update MD file on new branch 2017-12-07_19-54-31

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Failed Setup, will retry: none

-New HA green hardware, plus a Z-wave stick
-core: 2024.7.4, OS 12.4
-uhoo from HACS, version is stated as 0.0.4 from @andrewleech  in the HACS page, 0.0.5 in the Integration page
Uhoo is installed and then configured, accepts user and password. Then says: Failed Setup, will retry:none
I have these in the log:
Error: an exception occurred while attempting to get latest data: Error requesting data from https://api.uhooinc.com/v1/getalllatestdata: 400, message='Bad Request', url=URL('https://api.uhooinc.com/v1/getalllatestdata')
also have this:
This error originated from a custom integration.
Logger: custom_components.uhoo
Source: helpers/update_coordinator.py:344
integration: uHoo (documentation, issues)
First occurred: 03:25:18 (12 occurrences)
Last logged: 03:32:55
Error fetching uhoo data:
just for fun I tried the webpage linked and it indeed says invalid.

Hmm, my install seems to be working. The version numbers reported are confusing, which made me realise I never tagged my "current" version as a release.
I've just done so, as v0.0.5
Maybe check if hacs offers this as an update now?

Hi
I am fairly new to HACS, so I am not sure where, but I do not see such an option.
If I go to HACS - integration - uhoo I get this, still saying 0.0.4 ( I hope pics go thru from email)
￼
in fact, if I click on 'release 0.0.4'  it it opens the github page and thats still 0.0.4 too.
UPDATE: it opens the @csacca github. Is that okay? this came from your page..
the integration still looks like this:
￼

On 5 Aug 2024, at 11:49, Andrew Leech @.***> wrote:
Hmm, my install seems to be working. The version numbers reported are confusing, which made me realise I never tagged my "current" version as a release.
I've just done so, as v0.0.5
Maybe check if hacs offers this as an update now?
—
Reply to this email directly, view it on GitHub https://github.com/andrewleech/uhoo-homeassistant/issues/4#issuecomment-2268655876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL4Z37RTALXY3KCKAQIU5SDZP5DCBAVCNFSM6AAAAABL7K5EZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYGY2TKOBXGY.
You are receiving this because you authored the thread.

I'm not getting the pictures sorry, but yeah 0.0.4 is a release from the original csacca repo, not mine, so it looks like maybe that's what's installed instead?

Oh...
I originally made my changes here as a pull request into csacca repo, not expecting people to ever need to install directly from here.
However csacca repo hasn't been updated since / my changes never got merged.
I never updated the instructions in the readme on this fork to show how to install directly from this repo, so the instructions still give the url for the original csacca one.

Ok, I've just updated the readme to hopefully make this easier!
You're probably best to remove your current copy from hacs and try again from the updated instructions on the front page of this repo.

I just deleted the current uhoo setup
I added a custom repo of: https://github.com/andrewleech/uhoo-homeassistant/archive/refs/tags/v0.0.5.tar.gz and installed it.
the top of the hacs page says 0.0.5, @andrewleech, @csacca.  at Release, it says 0.0.4.
clicking on it, the github page still says 0.0.4 and I have the same error.

On 5 Aug 2024, at 12:26, Andrew Leech @.***> wrote:
I'm not getting the pictures sorry, but yeah 0.0.4 is a release from the original csacca repo, not mine, so it looks like maybe that's what's installed instead?
—
Reply to this email directly, view it on GitHub https://github.com/andrewleech/uhoo-homeassistant/issues/4#issuecomment-2268733581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL4Z37TPHVCLCTW3NBXSRVDZP5HO5AVCNFSM6AAAAABL7K5EZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG4ZTGNJYGE.
You are receiving this because you authored the thread.

here you can see me using your new readme, selecting 0.0.5. On the top left, you can still see the tag 0.0.4

Did you restart home assistant in between? It does look like it's still using the old one.

yes I did a full restart. I tried it before and after I logged in with the uhoo creditentials.

On 5 Aug 2024, at 12:50, Andrew Leech @.***> wrote:
Did you restart home assistant in between? It does look like it's still using the old one.
—
Reply to this email directly, view it on GitHub https://github.com/andrewleech/uhoo-homeassistant/issues/4#issuecomment-2268778155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL4Z37WXMOQNPRU6VDJCPODZP5KJHAVCNFSM6AAAAABL7K5EZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYG43TQMJVGU.
You are receiving this because you authored the thread.

On the hacs page, bring up custom repositories again and just double check the url for the repo, eg.

and then back on the hacs main page see if it's listed as "pending update" like mine, if so hit the update button.

yes, it looks like this:

and if I open it from the list, and click on the repository under the 3 dots here, it takes me to you github.

after I download it, I get a Pending Restart:

I've made another new release tag v0.0.6 just to include the readme changes.
If you update to that then the rest of the display for uhoo integration should show the correct version too.
Hopefully after that and the home assistant restart it works for you.
I haven't tested logging in from scratch with a new install for a while so there's still a chance something has gone wrong there, but hopefully not!

I deleted all traces (hopefully), even the custom repo from the HACS window. I have rebooted (not just restarted after delete.
I have then installed the new repo, using the link from the new readme. It does show 0.0.6, along with 0.0.5. However, in the corner, it still says 0.0.04, and that tag links to the old github page.

After I downloaded this, I got a prompt to restart. I rebooted again, and installed the integration.
Unfortunately, it is still the same result. I dont get it..
PS: I am not sure it matters, but the Configure window looks like this:

Sorry I still cannot get this working.
-do I need an uHoo premium subscription?
-what is the correct URL? I assume https://api.uhooinc.com/v1/getalllatestdata is not it.

I haven't paid for premium, I don't think it's that.
Oh, I see now in your previous pictures about the versions, I think mine does show all the same as you now. That 0.0.4 is the GitHub badge picture, that link in the readme must still be wrong sorry.
Perhaps yours is correctly installed now, which doesn't explain why the setup fails.
There's a chance the setup process in the integration is actually broken, maybe it's been broken by a recent home assistant update or something. My copy has been installed and untouched for a long time now.
I'll have to try resetting my installation and go through the setup process myself to see what's going on, which will have to wait until I'll have a little bit of time free to fix anything needed when I do so to keep my uhoo working.

Is there any news on this repo? I have the same issue as  rbhun. Are we one of the few experiencing this issue? Curious if @andrewleech did have the time to look into the issue?

No I haven't had time to look closer, though considering there's a few reports now it certainly sounds like there's a common issue with initial log in.
My existing installation is still working correctly so most of the server configuration is presumably still correct and valid, just something has changed with the login.
Between having a very young family and busy work I don't have much time for personal projects like this lately, but this issue is on my list to look at eventually - just really can't give much indication when that might be sorry.

I can fully understand that this is not your first priority in your situation. Of course I hope you will find some time for this issue. Thank you and cheers!

same problem here, please let me know if I can help (e.g. testing)

hi folks
TL;DR

open you uHoo mobile app
tap hamburgher menu
Appearance
Temperature
Change it to whatever else you currently have and save
Change it back to you previous setting

Issue is in the pyuhoo library trying to access the temperature unit selection from somewhere that is not anymore guaranteed to be present, reselecting the unit makes the API return again said field, without which the unhandled exeption occurs
I forked the library repo and prepared a fix to infer the unit from somewhere else
https://github.com/andrewleech/pyuhoo/pull/1
am preparing also the bump in the homeassistant component itself:
https://github.com/andrewleech/uhoo-homeassistant/pull/6

WowIt works Thank you! Sent from my iPhoneOn 23 Sep 2024, at 01:07, Simone Rescio @.***> wrote:
hi folks
TL;DR
open you uHoo mobile app
tap hamburgher menu
Appearance
Temperature
Change it to whatever else you currently have and save
Change it back to you previous setting
Issue is in the pyuhoo library trying to access the temperature unit selection from somewhere that is not anymore guaranteed to be present, reselecting the unit makes the API return again said field, without which the unhandled exeption occurs
I forked the library repo and prepared a fix to infer the unit from somewhere else
andrewleech/pyuhoo#1
am preparing also the bump in the homeassistant component itself:
#6
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Fyi the issue i addressed is related specifically to the error reported in https://github.com/andrewleech/uhoo-homeassistant/issues/5
I got confused and referenced this issue instead and later corrected the link
Altough you may try the temp unit reselection regardless to try if it fixes the other problem as well

Well it seems to have immediately fix this issue too, so the answer is still valid. I guess the same issue breaks the first run and reports an error


Set default Docker command to start.

Set default Docker command to start.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

[Current coverage][cc-pull] is 100%

Merging [#48][cc-pull] into [master][cc-base-branch] will not change coverage

@@            master       #48   diff @@
========================================
  Files            7         7
  Lines          263       263
  Methods          0         0
  Messages         0         0
  Branches        23        23
========================================
  Hits           263       263
  Misses           0         0
  Partials         0         0

Powered by Codecov. Last updated by [6adf745...1217952][cc-compare]
[cc-base-branch]: https://codecov.io/gh/fusionapp/fusion-index/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/fusionapp/fusion-index/compare/6adf74558654c1901902d72ed30daddcf1a59947...121795222d0df0b1d8c2dc7316c2617f92357b5f
[cc-pull]: https://codecov.io/gh/fusionapp/fusion-index/pull/48?src=pr


VarifocalNet

Hi, this is the implementation of our detector,  VarifocalNet (VFNet), a dense object detector built on the FCOS.  Please review the code. Thank you.

ping @yhcao6

Hi, @yhcao6, I have finished the pruning and debugging of the code and got it tested. Thank you very much for your example code, which helps me a lot.   Look forward to a further review. Many thanks.

Hi, @hyz-xmaster, This PR is almost done, but still missing the unit tests. Since it adds a new head (VFNetHead) and a new loss (VariFL), it is necessary to add unit tests in test_heads.py and test_losses.py.

Hi, @yhcao6, the VFNetHead requires the DeformConv2d function which seems no CPU version. In this case, does the unitest work with the GPU version of DeformConv2d?

Hi, @hyz-xmaster, in such case you can skip when cuda is not available like here.

Hi, @hyz-xmaster, in such case you can skip when cuda is not available like here.

Hi, @yhcao6, thank you. I have noticed that. But when I run this test, it still fails due to the focal  loss issue.

Hi, @hyz-xmaster, in such case you can skip when cuda is not available like here.

Hi, @yhcao6, thank you. I have noticed that. But when I run this test, it still fails due to the focal loss issue.

This should be a bug of test_fsaf_head_loss when cuda is available. CI can only cover cpu cases so it doesn't report an error.

Hi, @hyz-xmaster, This PR is almost done, but still missing the unit tests. Since it adds a new head (VFNetHead) and a new loss (VariFL), it is necessary to add unit tests in test_heads.py and test_losses.py.

The unit tests for VFNetHead and VarifocalLoss are added.

Thank you very much for your help with this PR, @yhcao6, @RyanXLi and @hellock !

@hyz-xmaster Cheers!

Hi!
@hyz-xmaster
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤


Recycler view Endless Scroll for pagination, How should I do?

Help me..
Made from (Asymmetric in Grid form).
however,
It is difficult to add an RecyclerView Endless Scroll Paging function.
I long for help. please.

in AsymmetricRecyclerview the layout manager is linearLayoutManager and you must solve pagination problem like this:
if (isLastItem()) {
// your call api and page handling must be here.
}
private fun isLastItem(): Boolean {
val layoutManager = yourRecyclerview.layoutManager as LinearLayoutManager
val pos = layoutManager.findLastCompletelyVisibleItemPosition()
val itemsCount: Int = layoutManager.findLastVisibleItemPosition()
return pos >= itemsCount
}

in AsymmetricRecyclerview the layout manager is linearLayoutManager and you must solve pagination problem like this:
if (isLastItem()) {
// your call api and page handling must be here.
}
private fun isLastItem(): Boolean {
val layoutManager = yourRecyclerview.layoutManager as LinearLayoutManager
val pos = layoutManager.findLastCompletelyVisibleItemPosition()
val itemsCount: Int = layoutManager.findLastVisibleItemPosition()
return pos >= itemsCount
}


Cannot run run_randon_agent.py

I use the following command to run the code:
python run_random_agent.py --avd_name "AndroidWorldAvd" --android_avd_home "C:\Users\Dell.android\avd" --android_sdk_root "C:\Users\Dell\AppData\Local\Android\Sdk" --emulator_path "C:\Users\Dell\AppData\Local\Android\Sdk\emulator\emulator" --adb_path "C:\Users\Dell\AppData\Local\Android\Sdk\platform-tools\adb" --num_steps 1000 --task_path "D:\code\androidWorld\android_env\tasks\Vokram\mdp_0000.textproto”
It will work at the beginning, but once the emulator started,emulator would quit right away.Then the process try to start the emulator again and same thing happens.After this the process ended, and I got this error:
E1112 10:50:50.045867 13404 base_simulator.py:81] DEBUG   | Concatenated backend parameters:  C:\Users\Dell\AppData\Local\Android\Sdk\emulator\qemu\windows-x86_64\qemu-system-x86_64.exe -adb-path C:\Users\Dell\AppData\Local\Android\Sdk\platform-tools\adb -gpu swangle_indirect -no-audio -show-kernel -verbose -avd AndroidWorldAvd -grpc 8554 -ports 53854,5555 -no-snapshot
Traceback (most recent call last):
File "C:\Users\Dell.conda\envs\android_world\Lib\shutil.py", line 632, in _rmtree_unsafe
os.unlink(fullname)
PermissionError: [WinError 32] Another program is using this file, and the process cannot access it : '/tmp/android_env/simulator/simulator_instance_ar5jromf\emulator_output'
I closed the android studio when running the code. I tried to open the emulator manualy in android studio and it work well. How can I solve this problem? Thank you!

Hi, we don't officially support Windows. Also, is this AndroidWorld? If yes, please open a bug there instead of AndroidEnv. Thanks!
@crawles FYI

Hi, we don't officially support Windows. Also, is this AndroidWorld? If yes, please open a bug there instead of AndroidEnv. Thanks! @crawles FYI

Sorry to disturb you！I didnt notice that. I will try it on Linux instead

No problem! Feel free to post your findings in the AndroidWorld repo page.