[BUG] issue with SMB fileserver macOS

This might be a very specific issue with the local (fileserver) setting. However, if other users run into a similar issue, it might make sense to collect here.
setup

macOS Ventura 13.2
arc version 0.4.0
git version 2.39.0
fileserver (NetApp grid) mounted via smb

steps (removed file server address)
arcdir="/Volumes/<---fileserver--->/demoarc"
mkdir -p $arcdir; cd $arcdir
arc init

error
Start processing command with the arguments:
        Branch:Field ""
        EditorPath:Field ""
        GitLFSByteThreshold:Field ""
        Owner:Field ""
        RepositoryAddress:Field ""

Start Arc Init
Done processing command.
ERROR: System.IO.IOException: Input/output error : '/Volumes/<---fileserver--->/demoarc/.arc/.gitkeep'
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Init(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)
   at ArcCommander.APIs.ArcAPI.init(ArcConfiguration arcConfiguration, FSharpMap`2 arcArgs)
   at ArcCommander.Program.handleCommand@215.Invoke(ArcConfiguration arcConfiguration, FSharpMap`2 arcArgs)
   at ArcCommander.Program.processCommand[a,T](ArcConfiguration arcConfiguration, FSharpFunc`2 commandF, ParseResults`1 r)
   at ArcCommander.Program.handleCommand(ArcConfiguration arcConfiguration, ArcCommand command)
   at ArcCommander.Program.main(String[] argv) Input/output error : '/Volumes/<---fileserver--->/demoarc/.arc/.gitkeep'

Basically same steps via Linux, same file server, works:
Linux Setup

Ubuntu 20.04.6 LTS
arc v0.4.0
git version 2.40.0
Fileserver eingebunden per `sudo mount -t cifs -o ...

arcdir="/<---fileserver--->/demoarc/"
mkdir -p $arcdir; cd $arcdir
arc init
arc i create -i test
arc sync -f -r https://git.nfdi4plants.org/brilator/linuxtest/

Is <---fileserver---> a valid name? Because this looks suspicious to me. In Windows, you wouldn't be allowed to choose such a name.

Is <---fileserver---> a valid name? Because this looks suspicious to me. In Windows, you wouldn't be allowed to choose such a name.

:D No, it's not. That's what I meant by "(removed file server address)"

2023-04-06 10:08:58.6559 ArcCommanderMainLog TRACE: Start ArcCommander
2023-04-06 10:08:58.7467 ProcessCommandLog INFO: Start processing command with the arguments:
	Branch:Field ""
	EditorPath:Field ""
	GitLFSByteThreshold:Field ""
	Owner:Field ""
	RepositoryAddress:Field ""

2023-04-06 10:08:58.7668 ProcessCommandLog TRACE: and the config:
	general.authclientid:80f4fbff13c3a27713860b6e71755fb3cba7adf644cf71a7cfcc9c1f67ac3680
	general.authredirecturi:http://localhost:7890
	general.authscope:openid email profile read_repository write_repository
	general.editor:nano
	general.forceeditor:false
	general.gitlfsbytethreshold:150000000
	general.gitlfsrules:**/dataset/**
	general.rootfolder:.arc
	general.verbosity:1
	general.workdir:/Volumes/............/demoarc
	assay.files:README.md
	assay.folders:dataset;protocols
	assay.rootfolder:assays
	study.files:README.md
	study.folders:protocols;resources
	study.rootfolder:studies
	isamodel.assay:folder.assay.rootfolder
	isamodel.assayfilename:isa.assay.xlsx
	isamodel.investigationfilename:isa.investigation.xlsx
	isamodel.studiesfilename:isa.studies.xlsx
	isamodel.studyfilename:isa.study.xlsx
	run.rootfolder:runs
	workflow.dockerfile:Dockerfile
	workflow.rootfolder:workflows

2023-04-06 10:08:58.7717 ArcInitLog INFO: Start Arc Init
2023-04-06 10:08:58.7723 ArcInitLog TRACE: Create Directory
2023-04-06 10:08:58.7723 ArcInitLog TRACE: Initiate folder structure
2023-04-06 10:08:58.7885 ProcessCommandLog INFO: Done processing command.

Is <---fileserver---> a valid name? Because this looks suspicious to me. In Windows, you wouldn't be allowed to choose such a name.

:D No, it's not. That's what I meant by "(removed file server address)"

Ha! Missed that one! 😅

Okay, according to the error message along with the log, the ArcCommander is not able to create a file in the directory.
We will have to investigate this further.
Does this error only occur on your server but not when working on a local folder? If so, it might be a problem with permissions.

only on that server and only when trying with mac not linux

Could you check if you have fewer permissions with your Mac account or when using the terminal from your Mac account?

same university user login

macOS Ventura 13.2
on the mac it is connected via the finder option

This might actually be a server issue as I also keep running into issues with pure git

fatal: .git/index: index file smaller than expected

Yes, turned out to be an issue with the file server supporting only macOS ≤ 11.01..


Question: How to get the installation location of a C++ Win32 WinUI 3.0 app as a string

In the UWP app that I'm attempting to port over to WinUI I need to load files that are part of the UWP app package as an array/vector of individual bytes. The UWP C++ code that I'm using to do so looks as follows:
std::vector<char> MyApp::ReadFileFromStorageFolder(const std::wstring& relativePath)
{
  path filePath = path{ winrt::Windows::ApplicationModel::Package::Current().InstalledLocation().Path().data() } / path{ relativePath };

  std::ifstream inputFileStream(filePath, std::ios::binary | std::ios::ate);
  std::ifstream::pos_type pos = inputFileStream.tellg();

  std::vector<char> result(pos);
  inputFileStream.seekg(0, std::ios::beg);
  inputFileStream.read(&result[0], pos);

  return result;
}

I'm not sure what to do with the InstalledLocation property because calling that property simply never returns when running the WinUI app with that code. It just blocks the UI thread forever.
Is that an API that is actually intended to work within WinUI? If not, is there a corresponding new API that I could use?
The end goal is simply to read binary files bundled together with the app as soon as the app starts. It is perfectly sufficient to do this synchronously because the file sizes are measured in single digit kilobytes.

If you are running as a unpackaged app Pachage.Current seems to be unsupported, according to the release notes
From the release notes:

Known issues for WinUI applications without MSIX-packaging (unpackaged apps):
Some APIs require package identity and are not supported in unpackaged apps, such as:
[...]
Package.Current

You can use QueryFullProcessImageName to get the location of the .exe file, then just throw that into std::filesystem::path and call .parent_path() to get the folder path

@MikeHillberg thoughts?


Fixes incompatibility with php 5.3

by removing shorthand array notation

+1 Yes please to this! I think this might even fix some of the issues I've seen on my Windows VM (which is using an earlier PHP version)


Persist ProposerData (prepared\registered proposerd) on BN to survive upon restart

There is a well known condition in which our BN will use default fee recipient. Since we do not persist prepared\registered proposer anywhere, when BN restarts it loses the information and will get it back on next VC poll, which suppose to happen on each epoch (for teku VC is at beginning of third slot). During this time window, if a validator have a block proposal duty, BN will use default fee recipient and will also give less time to EL to produce a payload (we will send FcU with attributes and getPayload in sequence)
An improvement would be to persist prepared\registered proposerd (the data managed by ProposerDataManager) on disk and reload it upon restart.
Another option is to make VC resend info if loses connection with BN (on event stream reconnection?) but this will improve our VC and not make BN by itself more resilient to restarts and so less dependant by VC behaviour.

I'd probably go with the VC change as we can't assume the beacon node will persist the data to disk either (the api doesn't require it and I think even mentions it may be forgotten when the beacon node restarts).

Going to close this one. We seem to be handling this fine in the real world and other BN implementations don't persist the data either so we can't depend on that anyway.


[LOG4J2-1923] Allow having the stacktrace as a string in JSONLayout, XMLLayout and YAMLLayout

Can you file an JIRA issue about this here: https://issues.apache.org/jira/browse/LOG4J2/
and mention the JIRA issue here?
It would be good with some motivation why this would be a good idea, such as example use case.

@mikaelstaldal I've opened the JIRA: LOG4J2-1923

It would be nice to have the same functionality in XmlLayout and YamlLayout. It should be easy to add that since they use the same Jackson based framework.

Sure. I will check if I can extend it to xml and yaml.

Documentation in layouts.xml.vm should be updated.

@mikaelstaldal Hi :) I've extended this to YAML and XML + updated layouts.xml.vm

To avoid breaking binary compatibility, we should not modify public/protected constructors/methods of JsonLayout, XmlLayout, YamlLayout. Add the new flag to the Builder only.

It would be nice to unit test this new feature for XmlLayout and YamlLayout also.


Support new type of WSL installation

From Windows 10 Fall Creators Update (1709), instead of the lagecy way of installing WSL by lxrun.exe, it is recommended to install WSL from Microsoft Store. Currently, wsl-terminal does not run with the new type of WSL installation.
Here's some links that might be useful:
https://docs.microsoft.com/en-us/windows/wsl/wsl-config
https://github.com/hashicorp/vagrant/issues/9298

@mxalbert1996 wsl-terminal has supported new type of WSL installation.
You can run tools/write-distro-guids-to-config-file.js to generate the distro_guid config, then open etc/wsl-terminal.conf and uncomment the dirstro_guid line which you preferred to use.

Thanks.


SSCS-10056 hearing post endpoint mapping wrapper

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/SSCS-10056
Change description
Hearing post endpoint mapping wrapper
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X ] No

Another branch created for  post end point and these changes merged in master by PR [SSCS-10088 Creating post endpoint mapping (] https://github.com/hmcts/sscs-hearings-api/commit/6677314c386cee5b3a4efca81373b3c8ca4ae5c7


submit - add custom error message for expired apple certs problem

Checklist

[x] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
Companion to https://github.com/expo/turtle-v2/pull/922/files
Some of Apple's certificates have expired. This results in app rejections.
How
Handle the new error code.
Test Plan
None


Quarkus extension seems to be broken in VS Code

I don't think the Quarkus extension doesn't work in the latest VS Code. For example, when I'm typing certain keys (e.g. quarkus.kubernetes.), it should show all relevant values automatically. But after I updated the latest VS Code, it doesn't anymore.
Here are my VS Code and Quarkus extension versions:

See https://github.com/redhat-developer/vscode-quarkus/issues/526 . Marking this as a duplicate. We just need to release 1.11.0. Downgrading to vscode-java 1.8.0 should also fix this.

@rgrunber when will 1.11.0 be released? How to downgrade vscode-java 1.8.0?

nvm. I just found that you mentioned the release date (July 25th) on slack channel.

Yeah, ASAP is ideal for this. Another possibility is to just use the development versions of vscode-quarkus + vscode-microprofile :
https://download.jboss.org/jbosstools/vscode/snapshots/vscode-microprofile/vscode-microprofile-0.5.0-238.vsix https://download.jboss.org/jbosstools/vscode/snapshots/vscode-quarkus/vscode-quarkus-1.11.0-544.vsix

Awesome. thx @rgrunber

I downgraded 1.8.0 and installed the above 2 extensions manually but the issue is still the same

The above 2 (snapshot) versions, vscode-microprofile-0.5.0* & vscode-quarkus-1.11.0* would need vscode-java 1.9.0
The previous 2 versions, vscode-microprofile-0.4.0 & vscode-quarkus-1.10.0 would need vscode-java 1.8.0

Normally the quarkus vscode extensions isn't so tightly dependent on a particular version of vscode-java, but there was a change we reacted to in vscode-java 1.8.0 -> 1.9.0 (coming from m2e)  that made the old versions unable to run in the runtime of the newer vscode-java, and the newer ones unable to run in the runtime of the older vscode-java.

OK. Let me try to downgrade 2 versions too.

Still doesn't work. Maybe I need to upgrade all extensions back to the latest and wait for `1.11.0` :(

Can you also confirm vscode-microprofile (which should be installed as a dependency of vscode-quarkus) was at version 0.4.0 when you tried the downgrade approach ?

Yeah I did

You're absolutely right. It's still broken, just in a different way.
In https://github.com/redhat-developer/vscode-quarkus/issues/526, the issue was the quick-pick for adding new extensions wasn't coming up. That breakage was from m2e removal of org.eclipse.m2e.lifecycle.defaults bundle, so downgrading to 1.8.0 fixed that.
However there is still another breakage on 1.8.0. m2e bumped some of the artifact API that also is incompatible. Apparently this doesn't break the quick-pick menu but it is seen when one attempts to trigger completion in an application properties file.
!ENTRY org.eclipse.core.jobs 4 2 2022-07-25 10:24:01.118
!MESSAGE An internal error occurred during: "MicroProfile properties collector".
!STACK 0
java.lang.NoSuchMethodError: 'java.lang.String org.eclipse.m2e.core.embedder.ArtifactKey.getGroupId()'
	at org.eclipse.lsp4mp.jdt.internal.core.utils.DependencyUtil.getLocalArtifactFile(DependencyUtil.java:91)
	at org.eclipse.lsp4mp.jdt.internal.core.utils.DependencyUtil.getArtifact(DependencyUtil.java:63)
	at org.eclipse.lsp4mp.jdt.internal.core.MavenArtifactResolver.getArtifact(MavenArtifactResolver.java:44)
	at com.redhat.microprofile.jdt.internal.quarkus.core.properties.QuarkusConfigRootProvider.addArtifactInClasspath(QuarkusConfigRootProvider.java:178)
	at com.redhat.microprofile.jdt.internal.quarkus.core.properties.QuarkusConfigRootProvider.contributeToClasspath(QuarkusConfigRootProvider.java:160)
	at com.redhat.microprofile.jdt.internal.quarkus.core.properties.QuarkusConfigRootProvider.contributeToClasspath(QuarkusConfigRootProvider.java:102)
	at org.eclipse.lsp4mp.jdt.core.PropertiesManager.contributeToClasspath(PropertiesManager.java:346)
	at org.eclipse.lsp4mp.jdt.core.PropertiesManager.getJavaProject(PropertiesManager.java:324)
	at org.eclipse.lsp4mp.jdt.core.PropertiesManager.configureSearchClasspath(PropertiesManager.java:179)
	at org.eclipse.lsp4mp.jdt.core.PropertiesManager.getMicroProfileProjectInfo(PropertiesManager.java:135)
	at org.eclipse.lsp4mp.jdt.core.PropertiesManager.getMicroProfileProjectInfo(PropertiesManager.java:110)
	at org.eclipse.lsp4mp.jdt.core.PropertiesManager.getMicroProfileProjectInfo(PropertiesManager.java:101)
	at org.eclipse.lsp4mp.jdt.internal.core.ls.MicroProfileDelegateCommandHandler.lambda$0(MicroProfileDelegateCommandHandler.java:105)
	at org.eclipse.core.runtime.jobs.Job$2.run(Job.java:187)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

What about trying to downgrade to 1.7.0 of vscode-java ?

how about the other dependencies? Shouldn't 1.11.0 be released today?

Ok. 1.7.0 works for me

Yes, I'm in the process of releasing 1.11.0.

vscode-microprofile 0.5.0 & vscode-quarkus 1.11.0 have just been published on the marketplaces. I was able to confirm with some others that it'll fix the issues we've been having.

Ok. Let me try it now.

Yay! It works for me too. Thx:)

@rgrunber I just have the same issue when I created a new Quarkus 2.11.1 project. Is this related to a new Quarkus version? I don't think so but this issue happens agagin.


Create a Bengali (Bangla) translation of the navigate terminal guide

Based on the English version of the guide (https://github.com/devadvance/terminalcheatsheet/blob/staging/guides/navigate-terminal.md), create a Bengali (Bangla) translation in https://github.com/devadvance/terminalcheatsheet/blob/staging/i18n/bn/guides/navigate-terminal.md.
You can copy this template to use a starting point: https://github.com/devadvance/terminalcheatsheet/blob/staging/i18n/new_language_templates/guides/navigate-terminal.md
It is OK to use the English images/GIFs. Look for TODO in the file for suggested places for translations.
Please comment on this issue before starting work so people are informed that you are working on it.

I am Interested in solving this Issue


Can no longer add multiple env variables at once

Existing documentation URL(s)
https://developers.cloudflare.com/workers/configuration/environment-variables/
this states
8. (Optional) To add multiple environment variables, select Add variable.
What changes are you suggesting?
There is now a sidebar that shows up to add one variable at a time and no options to add multiple
I would suggest allowing adding multiple
Additional information
No response

@sabercoy we just released the new multi-variable component 🎉


when destination.call() fails, funds get destroyed

Hi, in claim(..., address destination) the line destination.call.value(value).gas(msg.gas)() can fail in case destination is a smart contract that requires more than msg.gas to execute its fallback function or simply reverts because of other reasons. If it fails, call() returns false which will make the transaction succeed. However, the Fund is destroyed by delete funds[id]; and not successfully transferred to destination.
destination.transfer(value) is safer to use as it reverts on failure and costs max. 2300 gas.
Correct me if I'm wrong.

It is correct but there is another thing to mention.  As you said, I agree with the smart contract execution which can change the execution flow.

Not sure how the extra gas you're mentioning adds to OP. Deleting is fine when you use destination.transfer() which will revert on failure. When it doesn't revert, delete frees some gas, yup.
But I'm curious, maybe I didn't understand your comment?

I'll talk about 3 different cases:

Send value to EOA - Probably this is the desired case for burner wallets. If a transaction gets to the delete instruction, it will get gas to run the call and send the value. It will be extremely hard (not impossible) to fail on sending the value with this extra boost.
Send value/tx to a contract (Honest smart contract that reverts) - In this case all the transaction states will be reverted, including the delete. However if it gets out of gas on the external contract, the fund will be deleted without revert.
Send value/tx to a contract (Bad smart contract actor) - Calling an external contract can change the execution flow by trying reentrancy attacks or calling functions in the original contract that can alter the storage state.

As you said, destination.transfer() will revert in case of failure. Depending on the design, it could be or not the desired effect. destination.send() has the same gas limitation as transfer but it doesn't reverts. It only returns a boolean status.

Thanks for explaining!

Do you have some numbers? How much gas is freed vs gas cost of simply sending ETH (2300gas?)
According to (this answer)[https://ethereum.stackexchange.com/questions/19341/address-send-vs-address-transfer-best-practice-usage], you are not correct here. If an honest smart contract reverts, the tx will succeed.
Agreed

From Ethereum Yellow Paper p.25,7,8
15000 Refund given (added into refund counter) when the storage value is set to zero from
non-zero.
24000 Refund given (added into refund counter) for self-destructing an account.
Even with this numbers it is difficult to estimate. I added some measurements in the audit tests but they are not very consistent in every run.
If you find a better way to measure it, please let me know.

You are right. External calls return a status value. It becomes an independent call which can fail without affecting the original call.
To revert the original transaction, some more checks should have been needed:
require(destination.call.value(value).gas(gasleft())())


FYI - Ransomware in Transmission app!

Ransomware developers target Apple users. Transmission download ~this week-end contains KeRanger ransomware, 400USD. http://www.csoonline.com/article/3041080/security/ransomware-developers-target-apple-customers.html
http://researchcenter.paloaltonetworks.com/2016/03/new-os-x-ransomware-keranger-infected-transmission-bittorrent-client-installer/

Fixed in https://github.com/drduh/OS-X-Security-and-Privacy-Guide/commit/495e27c52dd17610430dba7407fbb54cebd4505f


Hey the Ubuntu WSL link in the scripts is outdated.

Link is for 16.04 but not for 18.04 which from what I can tell is only available through third party links or the Windows Store.
I haven't tried this yet but I believe this powershell script should work.
Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Windows-Subsystem-Linux
Get-AppxPackage -name "*Ubuntu*18*" | Add-AppxPackage

not all the store distros work from command line install.  Makes sense to enable ubuntu 18 if it isn't already enabled.  @tara-raj

It's enabled but I was not able to find a way to install from CLI, had to do it manually in the store which was no big deal.

Excellent thanks. I'll close.


Problems with Public role after updating

Hello! I've been running an older version of Superset without a problem, where I embed some dashboards on my website and through the Public user role permissions it is possible to see and use the dashboards.
However, after updating to version 0.36 (using docker) I've been having problems providing public access to my dashboards. Without changing any user role settings, I get Access Denied messages when before I was able to access the dashboard.
The only way I found around this is to set PUBLIC_ROLE_LIKE_GAMMA = True in the superset_config.py and then add the necessary permissions. However, every time I restart the server, it overwrites whatever permissions I've added and I have to add them again. If I put this setting back to False again, when I restart, the previous behavior comes up, where the public can't access the dashboard.
It seems that for some reason Superset doesn't recognize the public user role unless if it is innitiated through the PUBLIC_ROLE_LIKE_GAMMA setting.
Any ideas of what could be done to fix this? Thanks!

Just reproduced this, it appears running superset init resets Public to be exactly like Alpha (removes what was added manually)

As a workaround, you may be able to set PUBLIC_ROLE_LIKE_GAMMA = True, run superset init, set PUBLIC_ROLE_LIKE_GAMMA = False and then alter Public role.

I still get the same behavior of not being able to view the public dashboards doing that. Just to be clear, regardless of the user permissions, I still get Access Denied when trying to view a public dashboard. So, even though doing what you said did not overwrite the permissions, I still couldn't access the public dashboards (it seems it stops recognizing the public role).
However, I solved my problem by removing the superset_init container from docker-compose (after the first startup). I'm not sure if this is the intended behavior though...

Having the same problem
@mistercrunch @bkyryliuk
Shouldn't this line be
if conf.get("PUBLIC_ROLE_LIKE_GAMMA", False):

or even
if conf.get("PUBLIC_ROLE_LIKE_GAMMA", False):
    return (
        self.get_session.query(self.role_model)
        .filter_by(name="Gamma")
        .one_or_none()
    )

?

Hey,
#10674 fixes this issue, a rerun of superset init will keep all data access permissions on the public role. Also introduces a new way of configuring a pre defined public role.


[Bug] when modifying the fusion image of CT and PT,  Unable to change windowLevel of PT

Describe the Bug
When I was modifying the fusion image of CT and PT, I wanted to change the windowLevel of PT separately. When addingTool, I added volumeId to the configuration configuration. I found that when I get the targetId in the code, I always get the default actor UID, but I can't get it. To the volumeId of PT, the windowLevel of CT is always modified.
Steps to Reproduce

The current behavior
What I hope to change is the windowLevel of PT, The windowLevel of CT is indeed changed
The expected behavior
What I hope to change is the windowLevel of PT
OS
Windows 11
Node version
18.17.1
Browser
chrome 121.0.6167.85

getTargetId() This method will always get the uid of the first actor, using the volumeId of CT

you can add the volumeId of the pet when configuring the window level tool, check out the ptCT example https://github.com/cornerstonejs/cornerstone3D/blob/main/packages/tools/examples/petCt/index.ts#L378

I added the first picture above of this configuration. I debugged the internals of the library and found that after adding volumeId, this volumeId always obtains the ID of the first volume. Because of the logic in getTaegetId, my screenshot above can be See

这个地方我已经添加了 volumeId 的配置


.nav-inline .nav-item has extra space when there are spaces in the HTML source

Just came across this general issue when working with dispay: inline-block; and nav elements
http://stackoverflow.com/questions/9664321/strange-margin-on-displayinline-block-elements
so i'd suggest to add something like this to _nav.scss
    .nav-inline {
        font-size: 0;
    }

We've generally opted not to try to "fix" this aspect of inline-block in other places.

Yup, not changing anything here for basic inline nav.


Support for eth_getEncryptionPublicKey and eth_decrypt (EIP-1024)

These methods, as implemented by Metamask respectively allow a Dapp to obtain a public key appropriate for encryption, and decrypt an encrypted payload using a private key derived from an Ethereum account's private key.
At least one Dapp already makes use of these methods; Tornado.cash, which uses these to encrypt a backup copy (which is stored on-chain) of private notes required to redeem deposits.
It would be great if we could use these methods with our Ledger-backed keys :)
References:
https://github.com/ethereum/EIPs/pull/1098
https://docs.metamask.io/guide/rpc-api.html#other-rpc-methods

Any thoughts from Ledger on this? It would be great if this was implemented

Hello, thank you for this idea, it is currently not in our roadmap but we could take a look at it, probably beginning of next year.
While we are discussing Tornado.cash, feel free to have a look at https://torn.community/t/tornado-cash-in-ledger-live/1735 this would definitely help pushing these topics.
Thank you,
Adrien

Skiff requires this, so +1

I'll plus one this issue too unfortunately: 401884

bumping this; would be great to see this feature. any updates by any chance?

Resolves #240

@firnprotocol I'm not in a dev team, however I upgraded my Ledger's firmware today and can confirm Skiff works. It probably means the issue is resolved.

@pepawel excellent, thanks for the heads-up—though it looks like now MetaMask needs to update itself to not throw an error in this case?  (see lined issue above)

@pepawel saw your edits.
right, the problem is that when you call eth_getEncryptionPublicKey with a Ledger logged in, MetaMask throws:
{
    code: -32603
    message: "Ledger does not support eth_getEncryptionPublicKey."
    ...
}

this is because of this pull request, which essentially defined this error behavior—under the assumption that Ledger doesn't support it.
Now that Ledger does support this (see above), I think MetaMask needs to re-visit this error behavior and disable it. that's my read. i haven't gotten a response from them yet though.

@firnprotocol thank you for explaining the issue, it definitely makes sense!

Hi, can anyone confirm whether Ledger supports eth_getEncryptionPublicKey please?


JVM: Revamp JVM specific properties retrieval for prompt generation

There are some properties in the benchmarks that only exist for JVM projects. In the current logic, these properties are being added to the benchmark class and only JVM projects will use them. This PR reduces the size of benchmarks by removing these properties from the benchmarks. Instead, these properties are lively queries from the introspector new API without the need to store them in the benchmark objects.
In addition to the two properties (exceptions and is_jvm_static) for JVM projects, a third property is also added to indicate if the target method is a resource-type object (implements AutoClosable) that needs to be closed after use. This helps to reduce possible OOM in generated fuzzing harnesses because of memory leaks from unclosed resource objects. This is the replacement of the work originally shown in #528.

/gcbrun exp -f -n ascc-jvm-pr-531-2 -m vertex_ai_gemini-1-5 -b comparison

/gcbrun exp -n ascc-jvm-pr-531-5 -m vertex_ai_gemini-1-5 -i -b jvm-medium


Fix broken AttentionMechanism docstrings

Currently, for all AttentionMechanisms, the memory_sequence_length arg does not get formatted correctly in the docs, making it easy to miss.
I believe this is because the (optional) modifier is not preceded by a colon, as in the other (working) args.

Can one of the admins verify this patch?

Jenkins, test this please.

Jenkins, test this please.

Can one of the admins verify this patch?

@jagthebeetle Can you rebase to the latest master and apply your commit on top of that? Github is showing thousands of commits right now. I think it is better to create a new PR for this rather than reusing this.


Solving issue 756 - able to use string as table args.

Also correcting the reality that current Transaction is given as argument to the scope function.

Linking to #756


Precommit CI appears to be entirely broken

I'm seeing all reviews since this morning (at least) failing the same way: https://reviews.llvm.org/harbormaster/build/283932/
It's especially interesting to see the HTTP 28 failure code!

Thank you for the report @AaronBallman , much appreciated! I will be able to look at it tomorrow only

Alright, it seems that that issue is caused by completely disabled plain HTTP.
To mitigate that we would need to move to HTTPs and (likely) register a domain.

I have temporary disabled https://reviews.llvm.org/harbormaster/plan/5/ while we are looking on that

Thanks, I can confirm that the precommit CI seems to be working better after the temporary disable.


dependabot: Fix config syntax

Attempt 3 :)
Checklist

[ ] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[ ] Update the changelog (if necessary)

😄


Unknown Jailbrake Aborting

What version of Electra are you using?

look at issue #18

@rustymagnet3000  it doesn't work for me with the new tar file
`Trungs-iPad:/var/mobile/bfinject root# bash bfinject -P Facebook.app -l dylibs>
[!] "Facebook.app" was not uniquely found, please check your criteria.
< bfinject -P Facebook.app -l dylibs/bfdecrypt.dylib
[+] Electra detected.
[+] Injecting into '/var/containers/Bundle/Application/BA8BC26C-867F-46E0-B07B-6                                                                                F68692FE059/Facebook.app/Facebook'
[+] Getting Team ID from target application...
[+] WARNING: No Team ID found. Continuing regardless, but expect weird stuff to                                                                                happen.
[+] Thinning dylib into non-fat arm64 image
[+] Signing injectable .dylib with Team ID  and platform entitlements...
[bfinject4realz] Calling task_for_pid() for PID 490.
[bfinject4realz] Calling thread_create() on PID 490
[bfinject4realz] Looking for ROP gadget... found at 0x18421b4e0
[bfinject4realz] Fake stack frame at 0x133000000
[bfinject4realz] Calling _pthread_set_self() at 0x18445b804...
[bfinject4realz] Returned from '_pthread_set_self'
[bfinject4realz] Calling dlopen() at 0x18421b460...
[bfinject4realz] Returned from 'dlopen'
[bfinject4realz] ERROR: dlopen() failed to load the dylib.returned 0x0 (FAILURE)
[bfinject4realz] Calling dlerror() at 0x18421b2b0...
[bfinject4realz] Returned from 'dlerror'
1b158ee66b2fd9e45de454843034d7ef  -(545,0x1b504eb80) malloc: *** mach_vm_map(siz                                                                                e=6157549568) failed (error code=3)
*** error: can't allocate region
*** set a breakpoint in malloc_error_break to debug
[bfinject4realz] dlerror() returned: (null)
[*] Signing the executable with ldid
cp: missing destination file operand after '/var/mobile/Documents/Cracked/'
Try 'cp --help' for more information.
rm: missing operand
Try 'rm --help' for more information.
Attempting to unzip .ipa
unzip:  cannot find or open decrypted-app.ipa, decrypted-app.ipa.zip or decrypte                                                                                d-app.ipa.ZIP.
bfinject: line 127: cd: Payload: No such file or directory
Finna sign
./minimal/mapping.h(54): _assert(false); errno=2
zip warning: name not matched: Payload
zip error: Nothing to do! (try: zip -r .ipa . -i Payload)
rm: cannot remove 'Payload': No such file or directory
[]Generated signed .ipa in /var/mobile/.ipa
rm: cannot remove 'decrypted-app.ipa': No such file or directory
[] Signing completed successfully
[+] So long and thanks for all the fish.
`

@LaxusiC Are you using this fork?: https://github.com/klmitchell2/bfinject
What iOS version are you using? What jailbreak are you using?

@klmitchell2 nvm i got it working now, thank you. Is there a way to crack an app without reboot and turn off Tweaks?


Update project to framework latest

Bumps the lockfile to all latest versions
Incorporates framework changes into project root

I'm not sure what to do about tests. We have testBaseUrlHasBeenSet to ensure developers playing with this project remember to set a URL, but we explicitly don't want to set one for the repo or everyone would inherit it. I'm okay with disabling Actions on this repo since the unit tests are for our actual content but for play-testing.
Thoughts @lonnieezell? And this is ready.

I'm good turning actions off on this repo.

I think I found a fix for tests (136d77800f16d386676a0e0242c1c89ed28b3acc) that will let us keep them running here. I also updated the docs to remove the ProjectTests references.
Can we get @michalsn added as a contributor to this repo as well?


How to retain Session data in FastAPI the way we retain in Streamlit framework

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
#below is the Streamlit app code

def app():

    st.title("HOME")
    st.markdown("## Data Upload")

    # Upload the dataset and save as csv
    st.markdown("### Upload a csv file.")

    # Code to read a single file
    uploaded_file = st.file_uploader("Choose a file", type = ['csv'])
    if uploaded_file.name.endswith(".csv"):
        data = pd.read_csv(uploaded_file)

    st.session_state.data = data
  """#  Here we are retaining data with session_state for next operation, how can we perform same operation FastAPI..?    """

Description
In the above Streamlit app code  we are retaining data with session_state  for next operation, How can we perform same operation in FastAPI..?
Operating System
Windows
Operating System Details
10
FastAPI Version
0.75.2
Python Version
Python 3.9.12
Additional Context
No response

Global: just save it as a global object or in your app instance.
Local: use contextvar, or save it in request


Qiskit 0.45.3 FakeBackendV2 reports 2 qubits for a 133Q device

Environment

Qiskit version: 0.45.3
Python version: 3.12
Operating system: any

What is happening?
Because there is currently no Fake Torino system we have made our own for offline benchmarking:
import os
try:
    from qiskit_ibm_runtime.fake_provider.fake_backend import FakeBackendV2
except ImportError:
    from qiskit.providers.fake_provider import FakeBackendV2

class FakeTorino(FakeBackendV2):
    """A fake 133 qubit backend."""

    dirname = os.path.dirname(__file__)  # type: ignore
    conf_filename = "conf_torino.json"  # type: ignore
    props_filename = "props_torino.json"  # type: ignore
    backend_name = "fake_torino"  # type: ignore

When using FakeBackendV2 from the Runtime everything works.  However, using the same class from the old fake provider results in a target consisting of only 2 qubits.
The loaded files are in the Benchpress repo.
How can we reproduce the issue?
Run the above.
What should happen?
I should be able to load a FakeBakendV2 from older versions of Qiskit for benchmarking purposes.
Any suggestions?
No response

Haha, yep that fixes it.  Thanks!


how to use with proguard

when I want to make a release with proguard it give me an error
how to exclude it from proguard

Hello @Jahury.
Remember that, the library import in gradle this libraries:

compile 'com.android.support:appcompat-v7:24.0.0-alpha1'
compile 'com.google.android.gms:play-services-location:10.2.0'
compile 'com.google.android.gms:play-services-vision:10.2.0'

For use the exif inteface, for obtain the information of the picture.
Then, in my opinion you need to implement the last libraries and magical camera, maybe like this:
-keep class magicalcamera.** { *; }
or like
-keep class com.frosquivel.magicalcamera.** { *; }
Why?
because magical camera is a free and open source library, you dont need to worry of realize a proguard in this, in my opinion only need to exclude the library.
I am not a master of proguard, you can need to search in stack overflow maybe like this:
http://stackoverflow.com/questions/7721397/how-to-make-proguard-ignore-external-libraries
PD: This is not a issue of magical camera, you need to implement any method for exclude the library in proguard.


⚠ TiendaEnLinea has degraded performance

In 5e39642, TiendaEnLinea (https://www.fahorro.com/) experienced degraded performance:

HTTP code: 200
Response time: 6544 ms

Resolved: TiendaEnLinea performance has improved in 43f9e7f.


Login with Google, Github etc

Decide on what strategies we want to offer for sign-in
[ ] Google
[ ] Github
[ ]  Gitlab
[ ] twitter?
[ ] OpenID?

implement these

Google and Facebook logins have been added using Azure AD B2C auth


Solve second problem of homework 7

Closed by https://github.com/FavioVazquez/Electrodinamica-Clasica-PCF/commit/aefdc0e5799e8d706cfd904cf328cff26336b861


building example with mingw fails

Hi,
While tying to build example with mingw-64 I am getting this error and similar:
[  6%] Building CXX object CMakeFiles/qjSet.dir/src/glApp.cpp.obj
In file included from C:/LuaGL/gitsources/imGuIZMO.quat/example/src/tools/vGizmo.h:16,
                from C:\LuaGL\gitsources\imGuIZMO.quat\example\src\glWindow.h:16,
                from C:\LuaGL\gitsources\imGuIZMO.quat\example\src\glApp.cpp:26:
C:/LuaGL/gitsources/imGuIZMO.quat/example/src/tools/vgMath.h:259:25: error: member 'vgm::Vec3 vgm::Mat3::<unnamed union>
::<unnamed struct>::v0' with constructor not allowed in anonymous aggregate
        struct { VEC3_T v0 , v1 , v2 ; };
                        ^~

Could find this: https://stackoverflow.com/questions/41031424/constructor-not-allowed-in-anonymous-aggregate-string-in-struct
Thanks

Thanks for reporting.
I never built imGuIZMO.quat with mingw, I just now tried to compile it, and get that error.
About StackOverflow link: is just curious because I compile regularly with gcc (with v.5.2 for compatibility, and just now tested in 9.2.1) and it doesn't even give me a warning.
(and, of course, not even with CLang for macOS and MSVC for Windows)
Anyway I'll fix it soon... today or tomorrow.
Thanks again.

Thanks for taking a look!!

I just found out that it happens only with "standard" data type, and not with "templates": indeed using -DVGM_USES_TEMPLATE the compiler build it correctly
And is affect also GCC compiler (as it was rightly supposed to be), but not MSVC and CLang.
(Now the StackOverflow page have more sense for me)
Now I work to fix it

The issue should be solved
Try it and let me know

I could build now but had to change CMakeLists.txt : uncomment https://github.com/BrutPitt/imGuIZMO.quat/blob/master/example/CMakeLists.txt#L151 and also dont link against dl in https://github.com/BrutPitt/imGuIZMO.quat/blob/master/example/CMakeLists.txt#L161
There are some opengl initialization issues:
C:\LuaGL\gitsources\BUILDS\imguizmoquat>qjSet
Shaders/qjVert.glsl...
Shaders/qjVert.glslNOT OPEN...
Shaders/qjFragES2.glsl...
Shaders/qjFragES2.glslNOT OPEN...
Vertex shader(s) failed to link, fragment shader(s) failed to link.
ERROR: error(#280) Not all shaders have valid object code
ERROR: error(#280) Not all shaders have valid object code

Uniform variable "resolution" not found
Uniform variable "quatPt" not found
Uniform variable "diffuseColor" not found
Uniform variable "phongMethod" not found
Uniform variable "specularExponent" not found
Uniform variable "specularComponent" not found
Uniform variable "normalComponent" not found
Uniform variable "isFullRender" not found
Uniform variable "useShadow" not found
Uniform variable "useAO" not found
Uniform variable "matOrientation" not found
Uniform variable "Light" not found
Uniform variable "epsilon" not found
GL Error #1282(1282)  in File C:\LuaGL\gitsources\imGuIZMO.quat\example\src\qJulia.h at line: 68
Vertex shader was successfully compiled to run on hardware.

Fragment shader was successfully compiled to run on hardware.

Vertex shader(s) linked, fragment shader(s) linked.

GL Error #1280(1280)  in File C:\LuaGL\gitsources\imGuIZMO.quat\example\src\qJulia.h at line: 68
GL Error #1280(1280)  in File C:\LuaGL\gitsources\imGuIZMO.quat\example\src\qJulia.h at line: 68
GL Error #1280(1280)  in File C:\LuaGL\gitsources\imGuIZMO.quat\example\src\qJulia.h at line: 68
GL Error #1280(1280)  in File C:\LuaGL\gitsources\imGuIZMO.quat\example\src\qJulia.h at line: 68

It cannot find the GLSL shaders files or the Shaders folder: Shaders/qjFragES2.glslNOT OPEN... used in example.
Have you this folder in same directory of qjset?

It cannot find the GLSL shaders files or the Shaders folder used in example.
Have you this folder in same directory of qjset?

Yes, that was the problem.( Wonderful images!!!)
With Shift, Ctrl and Alt movements are restricted to X, Y, Z axes (absolute axes)
Is there a mode to restrict movements to the axes represented by the imGuizmo (red, gren and blue arrows)

I guess you mean like [0-45] degree on X axis, for example?
(If I have not misunderstood the question)
This is not possible, but should be ease test the return rotation and to limit it.

No, I dont mean restrict the amount of degrees. I mean the same that happens witn Shift, Ctrl and Alt (which restrict movement to an specific axis)
But as there are 6 axis (3 absolute axis X,Y,Z and 3 guizmo axis red, green, blue) I would like to restrict movement to the guizmo axis instead of absolute. For example to do a rotation around blue axis.

This is interesting, but unfortunately not currently... but it could be useful, it could be a future improvement.

This could is done in https://github.com/CedricGuillemet/ImGuizmo#imguizmo for moving objects
I have just wrapped ImGuIZMO.quat in C functions (as in cimgui) and works fantastic.
I am planning to add it to https://github.com/sonoro1234/LuaJIT-ImGui
I only fail to understand the vec3 requeriments: what are valid inputs? why vec3(1,0,0) is not valid but vec3(1,0,5) is valid? (not unit length vector)

I have just wrapped ImGuIZMO.quat in C functions (as in cimgui) and works fantastic.
I am planning to add it to https://github.com/sonoro1234/LuaJIT-ImGui

Thanks to have take in consideration ImGuIZMO.quat

I only fail to understand the vec3 requeriments: what are valid inputs? why vec3(1,0,0) is not valid (arrow disappears and trying to move gives nans) but vec3(1,0,5) is valid? (not unit length vector)
Maybe a bug due to the latest changes?

Let me to test/debug

Also: GLAPP_USE_VIRTUALGIZMO is defined but I cant find how to use it in the example, (Where to click)

Should works using mouse on background viewport (not in ImGui windows)... if really built with it
(you can see how I use it in glWindow.cpp)

Thanks for all. I tested after new commit and everything works!!

Thanks to you to have tested it and to have reported the issues


can i make cortile to ignore certain workspace?

i want cortile work on all workspace, but there is workspace i don't cortle work on it by default

You could use wmctrl in combination with cortile socket communications to archive what you want.
Either start cortile with the config.toml value tiling_enabled = true and then disable tiling on a specific workspace or vice versa. e.g. This command disables tiling on a given workspace defined by wmctrl -s <WORKSPACE INDEX>:
wmctrl -s 0 && sleep 1 && ./send.sh -s /tmp/cortile.sock -m '{"Action":"disable"}'

Let me know if this works for you.

wmctrl -s 0 && sleep 1 && ./send.sh -s /tmp/cortile.sock -m '{"Action":"disable"}'
bash: ./send.sh: No such file or directory

sorry what is ./send.sh? do u mean i create file with that name? if that what I script in it

The script can be found in the assets folder: https://github.com/leukipp/cortile/blob/main/assets/scripts/send.sh
You can also try it without the script via...
echo '{"Action":"enable"}' | nc -U /tmp/cortile.sock.in

...and you may have to install nc (Netcat) on your distro if it's not already installed.
Details are explained in the socket section of the README file.

i found the script and it worked very good


About adding curl commands retries in bootstrap.sh

What would you like to be added:
I would like to request retry function of curl commands for instance metadata on bootstrap.sh.
Why is this needed:
On bootstrap.sh, curl commands for instance metadata are executed.
But requesting to instance metadata is not always successful.It may result in an error.
Therefore, I believe that retry processing is necessary for the case of failure.
amazon-eks-ami/bootstrap.sh at master · awslabs/amazon-eks-ami
TOKEN=$(curl -X PUT -H "X-aws-ec2-metadata-token-ttl-seconds: 600" "http://<IP_ADDRESS>/latest/api/token")

Sounds reasonable.

The following pull request fix this issue.
https://github.com/awslabs/amazon-eks-ami/pull/596a

The following pull request fix this issue.
https://github.com/awslabs/amazon-eks-ami/pull/596a

https://github.com/awslabs/amazon-eks-ami/pull/596 has been merged. Closing issue.


How to fine tune use pretrained model?

Hello. I want to restore pretrained model param to original layers, and only train new added layers. So, how can i fix pretrained layers? Thanks.

http://tensorpack.readthedocs.io/en/latest/tutorial/save-load.html

Thanks. it is a great work.


subsys/shell: Use use_colors flag for shell instance

The z_flag_use_colors_set function in instance_init seems to be missing the use_colors flag. This PR fixes that.

This pr removes lots of color codes from the logs, but I'm still getting something like these:
[JJ--- 6 messages dropped ---
[JJ[00:00:48.453,000] <inf> modem_gsm: RSSI: -67
[JJ[JJ[01:01:49.694,000] <inf> modem_gsm: RSSI: -69

Anyone knows where these [JJs come from?

Yes, these are escape codes responsible for colors.
May you please check if the same problem exists on qemu_x86_64? If so I could support you with the fix.

May you please check if the same problem exists on qemu_x86_64? If so I could support you with the fix.

I don't have experience with qemu_x86_64, but I suppose it should exist across different arch?

This pr removes lots of color codes from the logs, but I'm still getting something like these:
[JJ--- 6 messages dropped ---
[JJ[00:00:48.453,000] <inf> modem_gsm: RSSI: -67
[JJ[JJ[01:01:49.694,000] <inf> modem_gsm: RSSI: -69

Anyone knows where these [JJs come from?

@ycsin Do you use CDC ACM UART? https://github.com/zephyrproject-rtos/zephyr/issues/36948

@ycsin Do you use CDC ACM UART? #36948

No, current USB related configs in my project:
# USB
CONFIG_USB=y
CONFIG_USB_DEVICE_STACK=y

log message coloring comes from this flag: https://github.com/zephyrproject-rtos/zephyr/blob/626b1b79df62bcdc4142cb671693ea9f31f10909/subsys/shell/shell_log_backend.c#L159


[MM-21910] Modal Handling for new Sidebar

Summary
Handling of the New Channel, Join Public Channel and Create Direct Message modals.
Temporary buttons included.
Ticket Link
https://mattermost.atlassian.net/browse/MM-21910

Currently awaiting these PRs before it can be merged:
https://github.com/mattermost/mattermost-webapp/pull/4799
https://github.com/mattermost/mattermost-webapp/pull/4821
https://github.com/mattermost/mattermost-webapp/pull/4846


Support for uglify-es

Now that Ember 2.13 has babel browser targeting, the build can contain ES6 code which uglify-js doesn't support. I've been using babili but it takes twice as long and produces larger files than uglify-es.
Someone has already made a branch for this but an official ember-cli packages would be great.
https://github.com/fusion2004/broccoli-uglify-es-sourcemap
https://github.com/fusion2004/ember-cli-uglify-es

Yep, I asked @fusion2004 to submit patches here.  Would love to update the main project.

I will hopefully be getting to that very soon! Sorry I haven't gotten to it sooner.

Sweet!

Resolved by https://github.com/ember-cli/broccoli-uglify-sourcemap/pull/47


Bulk export

Adding feature for user to export data as json

@Ali-Razmjoo @dhirensr Please review

@spiderxm : I checked it now on latest version of this branch,
2 problems I'm facing

files are not getting saved as ".csv" and instead "Honeypot-data-csv-1624359617127csv"
so the csv and excel for example shows all the data now, but the json still looks smaller with less data.

can you also test that?

@dhirensr Will fix that.

@spiderxm : when I'm filtering data, i get less results in json, whereas csv and excel have consistent results. is it also for you?

@spiderxm : when I'm filtering data, i get less results in json, whereas csv and excel have consistent results. is it also for you?

I didn't face issue like that. Data is consistent.

With ElasticSearch we can only request 10,000 records at max.
So if count is greater than that. We would get only 10,000 records

It is a great feature, but it exports the data with false positives from the table. Can you export data from API calls directly instead of from the table?
Thanks.

great job, thanks.

I've changed the PR to elasticsearch branch...  some tests needed new codes that exist theere.


Fix for wiredep

Hello,
a quick fix for wiredep builds: without toaster.scss, the dependency will not be automatically picked up by wiredep

Thanks for the PR!


Display transactions for contracts

We'll tackle related work as part of this milestone: https://github.com/blockstack/explorer/milestone/29

I'll close this issue since a contract page has a list of transactions


Hot logo

Can we get a super sweet logo for collins? This will improve the user experience for me significantly since i sometimes find it hard to find collins when i have 20 tabs open and it has no favicon.
 😢
This is kinda random but I have this logo I had made for another project that I never launched. It's a sweet chihuahua that in no way relates to the name of this project except that I think we can all imagine it's name might be collins.

cc @byxorna @defect @roymarantz

I like it, 👍

@roymarantz @defect @komapa @ssalevan @maddalab what do you think? I like it as well...
How will it look at 16x16 though?

so 16x16 not great i think at the 32x32 level it starts to look like something though.

I like it! I'm going to try spinning a collins container up with that as a favicon later to see what it looks like in the toolbar, but i'm sure it'll be a lot better than the default chrome or play one :)
We'll also need to check with legal on our side if there are any extra steps for contributions that aren't strictly code. I'll shoot them an email and let you guys know.

Looks OK at 16x16 to me in the Chrome tabs bar. Not great, but mostly due to me being lazy and not making the white background transparent :)
Do we need 16x16 though? Shouldn't most semi-recent versions of the most common browsers support at least 64x64?

Tbh all favicons look a bit bootleg, so if it doesn't look stellar I'm not too worried. Transparency would be nice though. Should this change include a bit of branding on the navbar and documentation as well?
Also, can you include screenshots of the tab with common browsers?

This looks great. @defect It looks like you used a favicon and didn't also implement the higher resolution options available these days -- it might make the icon look much better: https://davidwalsh.name/retina-favicons

@grahamc Hehe yeah. I went early 2000s style for a worst-case :) Still looked pretty decent i thought! Especially if we can get some transparency in there.
Once we get legal sign-off I'll ask the frontend folks for advice, unless people here all ready know best practices for favicons.

Good news! We got the sign-off from legal. Sorry for the super long delay. Unless someone gets to it before me, I'll work on getting a PR out later this week. It's been a while since I did any frontend work though :)

Merged in #563. Thanks @michaeljs1990!


ThorVG: Update from v0.11.6 to v0.12.0

https://github.com/thorvg/thorvg/releases/tag/v0.12.0
Godot-related SVG bug fixes:

[SwEngine]  thorvg/thorvg#1834
[SwEngine]  thorvg/thorvg#1848

Fixes #86128 Gradient issue.

The copyright year update should also be done in this file:
diff --git a/COPYRIGHT.txt b/COPYRIGHT.txt
index 4b8a246df0..c549761beb 100644
--- a/COPYRIGHT.txt
+++ b/COPYRIGHT.txt
@@ -483,7 +483,7 @@ License: Expat

 Files: ./thirdparty/thorvg/
 Comment: ThorVG
-Copyright: 2020-2023, The ThorVG Project
+Copyright: 2020-2024, The ThorVG Project
 License: Expat

 Files: ./thirdparty/tinyexr/

Thanks!

Can this be pushed to 4.2 branch also.

Cherry-picked for 4.2.2.


fix typo in model image names on push

images are being built with the correct name, but pushed as quay.io/ai-lab/quay.io/ai-lab/image-name - this fixes it

merging, last fix to model-image builds 🤞


add thumbnail upload feature

attempt : rought attempt, implementing direct firebase api on adding article
update : create article now uses first party firebase client instead of route api
update : functional article creation with thumbnail
fix : thumbnail now applies when created, before was only uploaded but not applied
add : helper to avoid firebase updateDoc type error when using custom type/interface
update : improved the effiiency of updating article document. Now it's modular.

Also changed some code Quality on firestoreApi

I closed this as done, but we'll be having a big refactoring soon

Cleaning up some messy function/method names, and stuff.
Maybe cleaning console too.
More technical documentation


Server crashes when command block is used to set permission

Description
We have multiple command blocks at spawn to set prefixes, suffixes, keep inventory true or false, and natural health regen true or false.
Each command block gives a player the permission by targeting them with the @p selector
lp user @p permission set noregen.on true server=neatobuilds
/lp user @p permission set essentials.keepinv false server=neatobuilds
lp user @p meta setsuffix &4
lp user @p meta setprefix &4
Reproduction steps

Start server
click on the button that triggers the command block
the button triggers the first command block /lp user @p permission set essentials.keepinv true server=neatobuilds
then it triggers the second command block say @p turned on Keep Inventory
command goes through but when it sends to luckperms the server goes down

Here is the start and crash log
start and crash log
Here is the luckperms config for the server
config.yml
Expected behavior
Before all the command blocks worked fine until I recently upgraded the server to 1.16.4 and updated luckperms.
We used to use the 'commandhook' plugin but it failed as well then we learned we had the option for LuckPerms to resolve Vanilla command target selectors
Environment details
The server runs in a bungeecord network and serves as the main survival world where players first join and can choose a name and chat color and whether to enable keep-inv or not

`>.... [18:54:09 INFO]: Previous version: git-Paper-259 (MC: 1.16.4)

.... [18:54:09 INFO]: You are running the latest version`

LuckPerms version: LuckPerms-Bukkit-5.2.23.jar

Can you try to reproduce on a clean server (i.e. nothing other than LP installed). The errors are the server not responding, which I'm doubtful is LP's fault since just about everything we can do off the main thread, we use a different thread(s).

ok I copied over the command blocks to another server and removed all the plugins except Luckperms but still got a crash
start and crash log
let me try switching to a local database now

here is the crash again on a H2 database after I imported the data from the mysql database
start and crash
we can do the command no problem by typing it in but when a command block does the command it crashes

Try set register-command-data-list up to false in luckperms config.yml

@benwoo1110 it already is

I have the same issue with the new update (5.2.26) after restoring the previous version (5.1.107) it stopped happening.

Thanks - silly mistake from me.
Should be all fixed in the latest version.


fix: queries related to badges

Description
This PR is the continuation of the #102 where I address all the queries related to Badges

Considerate using the last version of the UI lib (1.6.1) and use BadgePreview instead of BadgePreviewV2


Generating a consistent story to BotServices between LUIS and QnAMaker samples and docs

LUIS uses BotServices with:

A constructor that takes BotConfiguration and initializes a Dictionary

QnAMaker uses BotServices:

With a static method that initializes the QnAMaker instances on a Dictionary
Then the result is being passed to BotServices just as a container

It's a little confusing if you are working on a project with both LUIS and QnAMaker to reconcile both approaches on the same base code. Additionally, the BotServices abstraction seems like a recommended approach, which I don't know if it's the case.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2963321c-6720-be8f-aba6-225960eba1b3
Version Independent ID: bff968a7-33a8-bc53-b08b-6c17d672c3cd
Content: Use QnA Maker to answer questions - Bot Service
Content Source: articles/v4sdk/bot-builder-howto-qna.md
Service: bot-service
Product: bot-framework
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

We are working on streamlining samples and the code to address the issue you and others have raised. Thanks


Amend circleci workflows

What
Add separate workflows for master branch and non-master branch

master branch flow: test, build and enable seprate deploys to any
environment independant of one another for the master branch only.

test branch flow: test the branch but do not, unnecessarily, build
the docker image.

build and deploy branch: requires approval to build then enables
deploy to any environment other than master.

Why
To provide a flexible approach to deploying any branch to any environment.
This includes master because you may NOT want to deploy over someone elses
work being tested on a non-production environment
Also:

non-master branches will always run tests but require manual approval for build and deploy
non-master branches cannot be deployed to production
master branch auto-deploys to dev (may want to remove this)

Checklist
Before you ask people to review this PR:

[x] Tests and linters should be passing
[x] Github should not be reporting conflicts; you should have recently run git rebase master.
[x] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

Morning @msahilan07 @arthurashman, @chris-groves,
I understand from @chris-groves that you guys want to stick with the current pipeline setup. I can see this being problematic for VCD (the only consumer of this API) when it comes to testing as there is currently no means to deploy a branch to an environment via the pipeline unless it is in master and, as i think we agreed, if it is in master it should be pushed out to production asap.
How are you guys manually testing branches at the moment?

Morning @msahilan07 @arthurashman, @chris-groves,
I understand from @chris-groves that you guys want to stick with the current pipeline setup. I can see this being problematic for VCD (the only consumer of this API) when it comes to testing as there is currently no means to deploy a branch to an environment via the pipeline unless it is in master and, as i think we agreed, if it is in master it should be pushed out to production asap.
How are you guys manually testing branches at the moment?

Hi @msahilan07 further to our discussion I have amended this PR to keep the master branch flow the same but add the ability to build and deploy non-master branches.
Can you take a look and approve if happy. thanks

Hi @msahilan07 further to our discussion I have amended this PR to keep the master branch flow the same but add the ability to build and deploy non-master branches.
Can you take a look and approve if happy. thanks


[update] hdf5 i/o

Add fortran API to save and load state file.

LGTM. Might be a candidate for future refactoring, e.g. for example to pass the filename from the fortran api, such that it can be used together with vc-relax (not sure this is needed tough).

good point! I will add it to this PR


Added TIPC_NLA_NODE_KEY and TIPC_NLA_NODE_ID

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

#533 @morehouse @ebiggers

Can you rebase onto the master branch rather than merging it?  Pull requests shouldn't include a merge commit.

I've added CODEOWNERS file recently and now trying to understand the implications :)
The log above says:

JiahengHu requested a review from dvyukov as a code owner 1 hour ago
So you did not add me specifically? Either way, I trust @ebiggers on this. If you will be ready to merge this while I am sleeping, merge this.

I've added CODEOWNERS file recently and now trying to understand the implications :)
The log above says:

JiahengHu requested a review from dvyukov as a code owner 1 hour ago

So you did not add me specifically? Either way, I trust @ebiggers on this. If you will be ready to merge this while I am sleeping, merge this.

I think the system just automatically assign you to be the reviewer. Not sure why.

The code changes look fine now, though I'm not an expert in this API.
The commit message could use a better title.  It mentions TIPC_NLA_NODE_KEY and TIPC_NLA_NODE_ID, but actually the patch also adds TIPC_NL_KEY_SET and TIPC_NL_KEY_FLUSH.  A better title would be "sys/linux: add descriptions for new tipc crypto APIs".
Including links to the kernel commits which introduced these APIs (https://git.kernel.org/linus/134bdac39766 and https://git.kernel.org/linus/e1f32190cf7d) would also be helpful.
And there's no other new tipc crypto stuff that should be described too, right?  Just these?

The code changes look fine now, though I'm not an expert in this API.
The commit message could use a better title. It mentions TIPC_NLA_NODE_KEY and TIPC_NLA_NODE_ID, but actually the patch also adds TIPC_NL_KEY_SET and TIPC_NL_KEY_FLUSH. A better title would be "sys/linux: add descriptions for new tipc crypto APIs".
Including links to the kernel commits which introduced these APIs (https://git.kernel.org/linus/134bdac39766 and https://git.kernel.org/linus/e1f32190cf7d) would also be helpful.
And there's no other new tipc crypto stuff that should be described too, right? Just these?

Thx! I just modified the commits correspondingly


fix(www): themes toggle

Theme changes were only being applied when made from the system; however, when attempting to change it from the application header, the changes were not reflecting within the app.
Before:
https://github.com/guilhermerodz/input-otp/assets/103655828/c11738d0-5365-4659-9b63-17d5d19d34df
After
https://github.com/guilhermerodz/input-otp/assets/103655828/5e0db7df-8b8e-47ba-bfe1-66d2b0729756

hi @emiliosheinz now the system's prefers-color-scheme stopped working
https://github.com/guilhermerodz/input-otp/assets/10366880/9cdecd28-c511-4da0-85f6-b9dfdfe7a6b1

@guilhermerodz thank you for noticing. Weir that in my second video, when I change my system theme, it successfully changes the website theme. Any thoughts?

@guilhermerodz, I have tested it locally, and based on my understanding, it is working as expected. The implementation I have employed ensures that the selection made on the website will always take precedence. In essence:

If users select Light or Dark on the website's header it will take precedence over what is selected on the System (aka prefers-colors-scheme or OS theme).
If users select System on the website's header but have no preferred color scheme it will fallback to what is set on the OS.
If users select system on the website's header and have a preferred color scheme, the preferred color scheme will be applied, no matter what's the theme applied to the OS.

IMO having the preferred color scheme taking precedence over what is selected on the website will make the feature confusing for users since they might have a prefer color scheme set and when they try to change the theme on the header nothing will happen.
Video showcasing what I explained above:
https://github.com/guilhermerodz/input-otp/assets/103655828/80913ead-c0e2-44d4-a281-a7c5ed796317
Please, let me know your thoughts or concerns about this approach.

The theme isn't updating when there's no prefers-color-scheme, or if there's prefers-color-scheme:dark
https://github.com/guilhermerodz/input-otp/assets/10366880/e978194c-4fc7-4ec4-828e-23d20ba0485f
I still haven't debugged deeply to understand what's happening

That is definitely not what's happening on my side. Weird.

@guilhermerodz Sorry for asking but are you sure you are testing the right branch? 😅
I'm asking because the behavior you described in your previous message and video is exactly what I'm fixing with this PR. When testing the theme toggle on https://input-otp.rodz.dev/ the behavior is exactly as in your video, but when trying the same thing on the branch with the fixes I applied it works as expected. Could you please double check and let me know the results?
Sorry if I'm missing something really obvious here. Thanks!
See the proof below:
https://github.com/guilhermerodz/input-otp/assets/103655828/5755439d-63f0-4377-ae5b-9fa50dec5eae

@guilhermerodz Did you have the chance of circling back to this? I would love to hear your thoughts.


Fixed issues with public IPs when creating repair VMs in no-tty mode

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair create
General Guidelines

[ Yes ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ Yes ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ Yes ] My extension version conforms to the Extension version schema

For new extensions:

[ n/a ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
PR Notes
Fixed 2 issues with the extension vm-repair.

When creating a repair VM with a public IP, the Ip would be named after a boolean and not the proper naming scheme for the resource repair-<VMName>-<Resource>
Added an option to NOT create a public IP in notty mode. --no was added to avoid the prompt for the Pip. Prior to this, there were 2 switches to create a public IP in notty mode. --yes and --associate-public-ip both create a Pip in notty. No switch existed to do the same without a Pip.

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan @zhoxing-ms @alloy
Is there anyway my PR can bypass the failed check for azdev style? all the errors generated are for code that I did not touch or create. Looks like this extension was never tested or styled prior to being pushed to main. I fixed all the issues Flake8 provided hoping it would pass, but Pylint errors are not stopping it. I would like to not fix all of this as it would require some refactoring to pass the existing tests. Thanks!
Output of azdev style vm-repair
************* Module azext_vm_repair.custom
src/vm-repair/azext_vm_repair/custom.py:335:44: E0606: Possibly using variable 'repair_resource_group' before assignment (possibly-used-before-assignment)
src/vm-repair/azext_vm_repair/custom.py:335:74: E0606: Possibly using variable 'repair_vm_name' before assignment (possibly-used-before-assignment)
src/vm-repair/azext_vm_repair/custom.py:445:16: W0719: Raising too general exception: Exception (broad-exception-raised)

************* Module azext_vm_repair._validators
src/vm-repair/azext_vm_repair/_validators.py:180:7: W0212: Access to a protected member _subscription of a client class (protected-access)
src/vm-repair/azext_vm_repair/_validators.py:183:79: W0212: Access to a protected member _subscription of a client class (protected-access)

************* Module azext_vm_repair.repair_utils
src/vm-repair/azext_vm_repair/repair_utils.py:211:8: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/repair_utils.py:438:12: E0602: Undefined variable 'install_ade_extension_command' (undefined-variable)
src/vm-repair/azext_vm_repair/repair_utils.py:583:8: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/repair_utils.py:587:4: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/repair_utils.py:707:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:708:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:709:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:710:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:711:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:19:0: W0611: Unused SuseNotAvailableError imported from exceptions (unused-import)

-------------------------------------------------------------------
Your code has been rated at 9.80/10 (previous run: 10.00/10, -0.20)

@jimurrito as long as no new error is introduced should not be blokcer

No new errors then what was already on main for vm-repair. If you clone this repo from main and run azdev style vm-repair I get the same errors as well.
These are what you see from azdev style vm-repair when pulled from main:
azdev style vm-repair

===============
| Style Check |
===============

Extensions: vm-repair

Running pylint on extensions...
Pylint: PASSED
************* Module azext_vm_repair.custom
src/vm-repair/azext_vm_repair/custom.py:623:0: C0303: Trailing whitespace (trailing-whitespace)
src/vm-repair/azext_vm_repair/custom.py:626:0: C0303: Trailing whitespace (trailing-whitespace)
src/vm-repair/azext_vm_repair/custom.py:649:0: C0303: Trailing whitespace (trailing-whitespace)
src/vm-repair/azext_vm_repair/custom.py:655:0: C0303: Trailing whitespace (trailing-whitespace)
src/vm-repair/azext_vm_repair/custom.py:50:0: W0404: Reimport 'AzCommandError' (imported line 17) (reimported)
src/vm-repair/azext_vm_repair/custom.py:50:0: W0404: Reimport 'RunScriptNotFoundForIdError' (imported line 17) (reimported)
src/vm-repair/azext_vm_repair/custom.py:50:0: W0404: Reimport 'SupportingResourceNotFoundError' (imported line 17) (reimported)
src/vm-repair/azext_vm_repair/custom.py:50:0: W0404: Reimport 'CommandCanceledByUserError' (imported line 17) (reimported)
src/vm-repair/azext_vm_repair/custom.py:331:44: E0606: Possibly using variable 'repair_resource_group' before assignment (possibly-used-before-assignment)
src/vm-repair/azext_vm_repair/custom.py:331:74: E0606: Possibly using variable 'repair_vm_name' before assignment (possibly-used-before-assignment)
src/vm-repair/azext_vm_repair/custom.py:441:16: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/custom.py:20:0: W0611: Unused _unlock_singlepass_encrypted_disk imported from repair_utils (unused-import)
************* Module azext_vm_repair._validators
src/vm-repair/azext_vm_repair/_validators.py:432:0: C0304: Final newline missing (missing-final-newline)
src/vm-repair/azext_vm_repair/_validators.py:180:7: W0212: Access to a protected member _subscription of a client class (protected-access)
src/vm-repair/azext_vm_repair/_validators.py:183:79: W0212: Access to a protected member _subscription of a client class (protected-access)
************* Module azext_vm_repair.repair_utils
src/vm-repair/azext_vm_repair/repair_utils.py:211:8: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/repair_utils.py:438:12: E0602: Undefined variable 'install_ade_extension_command' (undefined-variable)
src/vm-repair/azext_vm_repair/repair_utils.py:583:8: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/repair_utils.py:587:4: W0719: Raising too general exception: Exception (broad-exception-raised)
src/vm-repair/azext_vm_repair/repair_utils.py:707:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:708:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:709:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:710:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:711:16: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
src/vm-repair/azext_vm_repair/repair_utils.py:19:0: W0611: Unused SuseNotAvailableError imported from exceptions (unused-import)

------------------------------------------------------------------
Your code has been rated at 9.73/10 (previous run: 9.80/10, -0.07)

Pylint: FAILED

Running flake8 on extensions...
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/_validators.py:432:39: W292 no newline at end of file
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:615:26: E225 missing whitespace around operator
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:616:34: E225 missing whitespace around operator
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:622:38: E225 missing whitespace around operator
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:622:65: E225 missing whitespace around operator
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:623:1: W293 blank line contains whitespace
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:626:1: W293 blank line contains whitespace
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:627:9: E303 too many blank lines (2)
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:643:126: E231 missing whitespace after ','
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:649:1: W293 blank line contains whitespace
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:650:10: E114 indentation is not a multiple of 4 (comment)
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:650:10: E116 unexpected indentation (comment)
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:652:33: E127 continuation line over-indented for visual indent
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:655:1: W293 blank line contains whitespace
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:656:9: E303 too many blank lines (2)
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:664:133: E231 missing whitespace after ','
/home/james/code/azure-cli-extensions/src/vm-repair/azext_vm_repair/custom.py:672:130: E231 missing whitespace after ','
1 	E114 indentation is not a multiple of 4 (comment)
1 	E116 unexpected indentation (comment)
1 	E127 continuation line over-indented for visual indent
4 	E225 missing whitespace around operator
3 	E231 missing whitespace after ','
2 	E303 too many blank lines (2)
1 	W292 no newline at end of file
4 	W293 blank line contains whitespace

Flake8: FAILED

I have a local version of the branch where I fixed all the Flake8 errors, but I did not want to refactor to fix the errors in Pylint.
I am FTE if you wanna reach out on Teams. alias: jamesimmer

Fixed all the errors when running azdev style vm-repair. See commit changes to see refactors. All are minor, and mostly on unused code. Any used code was tested via azdev and practical use via the CLI.

Please add some test cases for this PR change

@jimurrito Please resolve these conflicts


Keep the puma pidfile and the state path as defaults if environment is production

While using the development environment we want to write the pidfile and
the state path where it will be lost after restarting the services, so
we avoid writing this information to a folder mounted from the host.
In production we want to avoid using /tmp for writing these files.

Also, I don't think these files are relevant when running inside of a container, no?

...and this makes me wonder if we need a pidfile at all for the devenv. we might just drop pidfile and state_path altogether.

The idea was to avoid it creating it on the mounted project hierarchy (making new runs fail because the pidfile is there yet if you did an unclean exist -- frequently on development).
However, you are right, I cannot see the pidfile any longer, so I'm updating the PR to directly remove those directives.

Requesting for reviews again.

Approved by @MaximilianMeister previously, minor change, tests passing, and security related. Merging.


editing a note changes the note name and destroys all text formatting

I've just tried using the edit subcommand with gnote and was surprised by the result:

the note was renamed to "note name  (system:notebook:thenameofthenotebook"
all text formatting disappeared

Both of those details are linked to what the following returns:
old_content = self.interface.get_note_content(notes[0])

In the Scout.get_note_content method, the two things are visible:
https://github.com/lelutin/scout/blob/master/src/scout/core.py#L153
the comment on that line mentions that bullet points disappear when splitting lines.
there's probably more to it though since there can be bold text, striked out text and other forms of formatting which will probably be completely invisible to the terminal.
The only way this could be fixed is if the dbus API provided some way to get the note contents with all markup for the formatting. Then we could use the version with markup for the edit action.

interesting, I can see here:
http://git.gnome.org/browse/gnote/tree/src/dbus/remotecontrol.hpp
that one of GetNoteCompleteXml() or GetNoteContentsXml() could be what we want to use.

this is linked to #26 : that other ticket mentions the idea of implementing xml in/out for more commands


GridView and DetailView empty cells

After upgrade to 4b511fb GridView and DetailView stop working.
Every cell of both GridView and DetailView is shown as empty (no value in red).

Could you try to checkout to https://github.com/yiisoft/yii2/commit/25138d337c3dee2979dccbf3576451626ae46b54 ?

And if it works - try https://github.com/yiisoft/yii2/commit/eda1e7b0277098ebca01997d2e72c8f502acb982

Confirmed, reverted https://github.com/yiisoft/yii2/commit/f72e9d5bcf4642a0fe54ccbc3bd58d7e05e3ff7b
Thank you

I am totally confused on why this would be desired behavior inside the ArrayHelper::getValue() function...

The goal of the function is to extract something from that is a collection of key value pairs (array or object).
This function now behaves differently for arrays than it does for objects (bad practice, then there should be 2 separate functions instead).

This basically makes the function useless for objects, consider the scenarios:

I know I have an object, use: $object->$attribute
I don't know if have an object or an array, can't use ArrayHelper::getValue() with a default since that will get unpredictable. Calling it without a default will give me a silent null when there is a missing key in the array, but if it happens to be an object then it will instead throw an exception.

$values = ['a' => 1, 'b' => 2];
ArrayHelper::getValue($values, 'a') === ArrayHelper::getValue((object) $values, 'a')
ArrayHelper::getValue($values, 'c') !== ArrayHelper::getValue((object) $values, 'c')

It is unclear for me in which scenario this behavior makes more sense than the previous.


docs: update the guide

Signed-off-by: Ali Sajid Imami 395482+AliSajid@users.noreply.github.com<!--
SPDX-FileCopyrightText: 2023 - 2024 Ali Sajid Imami
SPDX-License-Identifier: Apache-2.0
SPDX-License-Identifier: MIT
-->
Description
Please include a summary of the change and which issue You fixed. Please also include relevant motivation and context. List any dependencies required for this change.
Fixes # (issue)
Change Type
Please delete options that are not relevant.

[ ] Style (Non-breaking change which fixes an issue)
[ ] Refactor (change which changes the codebase without affecting its external behavior)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a capability)
[ ] Breaking change (fix or feature that would cause existing features to not work as expected)
[ ] This change requires a documentation update

How Was This Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Toolchain Version:
Toolchain Channel (i.e, stable, beta, nightly):
Operating System:
Operating System Version:
Any other relevant details:

Checklist:

[ ] Code follows the project's style guidelines
[ ] Code has undergone self-review
[ ] Comments added to complex code sections for clarity
[ ] Documentation updated to reflect changes
[ ] Changes do not generate new warnings
[ ] Tests added to verify the fix or feature
[ ] All unit tests pass locally with these changes
[ ] All dependent changes merged and published in downstream modules
Signed-off-by: Ali Sajid Imami<EMAIL_ADDRESS>

:tada: This PR is included in version 2.0.1-next.1 :tada:
The release is available on:

GitHub release
v2.0.1-next.1

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

GitHub release
v2.1.0

Your semantic-release bot :package::rocket:


Kotlin problem

I'm a junior mobile app dev working on Vs code, i upgraded to version 3.0.2. Ever since then, i've been on the below error
Launching lib\main.dart on TECNO CD6 in debug mode...
lib\main.dart:1
[Fatal Error] kotlin-script-runtime-1.6.10.pom:2:1: Content is not allowed in prolog.
[Fatal Error] kotlin-reflect-1.6.10.pom:2:1: Content is not allowed in prolog.
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:compileDebugKotlin'.

Could not resolve all files for configuration ':app:kotlinCompilerClasspath'.
Could not resolve org.jetbrains.kotlin:kotlin-script-runtime:1.6.10.
Required by:
project :app > org.jetbrains.kotlin:kotlin-compiler-embeddable:1.6.10
Could not resolve org.jetbrains.kotlin:kotlin-script-runtime:1.6.10.
Could not parse POM https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-script-runtime/1.6.10/kotlin-script-runtime-1.6.10.pom
Content is not allowed in prolog.
Could not resolve org.jetbrains.kotlin:kotlin-reflect:1.6.10.
Required by:
project :app > org.jetbrains.kotlin:kotlin-compiler-embeddable:1.6.10
Could not resolve org.jetbrains.kotlin:kotlin-reflect:1.6.10.
Could not parse POM https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-reflect/1.6.10/kotlin-reflect-1.6.10.pom
Content is not allowed in prolog.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

I dont even know where to start looking for the problem. if can take time to help me out, i will be grateful

@Herlarney
This is likely an issue with that particular version of Gradle. Upgrading/downgrading like in https://github.com/flutter/flutter/issues/51690#issuecomment-603988891 is likely the only solution.
Also, this isn't a Flutter issue, so you need to ask this in support channels like StackOverflow.
Closing from here.


Undefined is not an object (evaluating 'CameraManager.Aspect') during running app

# App.js
import React from 'react';
import {Text, View} from 'react-native';
import Registration  from './src/pages/Registration.js';
// sample styles
export default class App extends React.Component {
render() {
return (

);

}
}
Registration.js
import React, { Component } from 'react';
import {  Text, TextInput, View, Button, Form, NativeAppEventEmitter } from 'react-native';
import Camera from './react-native-camera/index.js';
export default class Registration extends Component {
constructor(props) {
super(props);
this.state = {text: ''};
}
render() {
return (
<View style={{padding: 30}}>
<TextInput
style={{height: 40}}
autoFocus={true}
autoCapitalize="none"
autoCorrect={false}
placeholder="First Name"
onChangeText={(firstName) => this.setState({firstName})}
/>
      <TextInput
       style={{height: 40}}
        autoFocus={false}
        autoCapitalize="none"
        autoCorrect={false}
        placeholder="Last Name"
        onChangeText={(lastName) => this.setState({lastName})}
      />
      <TextInput
       style={{height: 40}}
       autoFocus={false}
       autoCapitalize="none"
       autoCorrect={false}
       placeholder="Email"
       onChangeText={(email) => this.setState({email})}
     />

      <TextInput
      style={{height: 40}}
      placeholder="Username!"
      onChangeText={(text) => this.setState({text})}
    />

       <TextInput
      style={{height: 40}}
      placeholder="password!"
      onChangeText={(text) => this.setState({text})}
    />

      <TextInput
       style={{height: 40}}
        secureTextEntry={true}
        autoCapitalize="none"
        autoCorrect={false}
        placeholder="Password Confirmation"
        onChangeText={(passwordConfirmation) => this.setState({passwordConfirmation})}
      />
      <Camera
       ref={(cam) => {
         this.camera = cam;
       }}
       style={styles.preview}
       aspect={Camera.constants.Aspect.fill}>
       <Text style={styles.capture} onPress={this.takePicture.bind(this)}>[CAPTURE]</Text>
   </Camera>
    <Button
	 onPress={this.camera.capture().then((data) => console.log(data)).catch(err => console.error(err))}
	  title="Press Me"
/>
  </View>

    );
}

}

Add the following permissions in the AndroidManifest.xml file:
<uses-permission android:name="android.permission.RECORD_AUDIO"/>
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

Already added

Please Add this into your gradle file
android {
...
defaultConfig {
...
multiDexEnabled true
}
}
AND also add the below dependency in your gradle
dependencies {
compile 'com.android.support:multidex:1.0.1'
}
This will definitely solve your issue.

In reactnative project folder where is it

in Android/App/build.gradle

in reactnative project there is 2 folders that given below in which folder Android/App/build.gradle
react-native-packager-cache-38539b997296799ed5a5b31713a7ada56b73934e
node_modules

Solution that works for me (on ios) : run the app via Xcode directly instead of react-native run-ios

I have the same problem. I have already setup my project with the manual install process, rnpm link and @ashishrokr solution, but nothing works. Someone have another solution ?
Test with a Galaxy S7Edge on Android 7.0
react-native-cli: 2.0.1
react-native: 0.47.2
expo: 44.0.0

Same problem here, anyone solved this for npm run ios?

@haikezegwaard - Are you running in the simulator? I get this error when I use the  in the iOS simulator but it works on my device. The iOS simulator doesn't support the camera, so my guess is that the library isn't failing very gracefully.

I don't know if you still have this issue but I've been dealing with it the whole morning and I guess I fixed It. As the docs says:

On Android, you require buildToolsVersion of 25.0.2+. This should easily and automatically be downloaded by Android Studio's SDK Manager.

So go to your android/app/build.gradle and make sure that buildToolsVersion is at least 25.0.2. Mine was on 23.0.1 so after changing this and updating all the tools I had on Android Studio the problem was fixed.

how can I acess camera in react native webview?

I am seeing this on iOS. Any solution?

in IOS you have given Camera permission in info.plist ?

Same problem the pod install has a dependency to react that makes this.
Any solution ?

@bkvirendra  could help on pod installs

Still stuck with this. Anything to resolve this ?

@ishigamii This was resolved in https://github.com/react-native-community/react-native-camera/commit/8989aa235475e3157ca3b172632fdbd26515f52a
Can you point your npm installation to use the latest master instead as this was merged recently but isn't yet included in a release? Like
"react-native-camera": "https://github.com/react-native-community/react-native-camera/tarball/master"

@bkvirendra actually just did what you told me and doing so I got a clean install but got back to the "CameraManager.aspect" Error. So I linked the project react-native link react-native-camera and pod install and the pod install installed React again and back to beginning of the problem :(

@ishigamii Are you using cocoapods for all the RN libraries & could you also share the environment details of your project?
The react-native-camera does work with the simulator as well, as long the library is linked properly.

@bkvirendra I don't use pods for all of them, but only the one requiring it.
Here is the details :
Pods :
pod 'Firebase/Core'
pod 'Firebase/Auth'
pod 'Firebase/Database'
pod 'Google/SignIn'
pod 'react-native-camera', :path => '../node_modules/react-native-camera'
Package.json :
"dependencies": {
"debounce": "^1.1.0",
"moment": "^2.20.1",
"moment-timezone": "^0.5.14",
"react": "16.2.0",
"react-moment": "^0.7.0",
"react-native": "0.53.0",
"react-native-elements": "^0.19.0",
"react-native-firebase": "^3.2.4",
"react-native-google-signin": "^0.12.0",
"react-native-i18n": "^2.0.6",
"react-native-vector-icons": "^4.5.0",
"react-navigation": "^1.0.0-beta.27",
"react-native-camera": "https://github.com/react-native-community/react-native-camera/tarball/master"
},
React :
react-native-cli: 2.0.1
react-native: 0.53.0
Right now, if I remove the pod from react-native-camera It works (after some cache cleaning), if I add the pod it install React (like described here: https://github.com/react-native-community/react-native-camera/issues/1237). If I don't pod install I get the aspect problem.
Thanks a lot for you help :)

Still blocked in ios by this :s Do you need more information ?

do a manual link:

npm install react-native-camera --save
In XCode, in the project navigator, right click Libraries ➜ Add Files to [your project's name]
Go to node_modules ➜ react-native-camera and add RNCamera.xcodeproj
In XCode, in the project navigator, select your project. Add libRNCamera.a to your project's Build Phases ➜ Link Binary With Libraries
Click RNCamera.xcodeproj in the project navigator and go the Build Settings tab. Make sure 'All' is toggled on (instead of 'Basic'). In the Search Paths section, look for Header Search Paths and make sure it contains both $(SRCROOT)/../../react-native/React and $(SRCROOT)/../../../React - mark both as recursive.

Try doing this


Ecosystem defolkloring: add support channel information

Ecosystem defolkloring effort
This automatic draft pull request appends a header with a placeholder for "support channel" information to the repository README.md
Please take over the PR & replace the placeholder with relevant information.
Addresses #132

Yeah, we desperately need to figure out how to create a support channel for Agora. I wonder if we could somehow borrow the Plutonomicon discord and create an agora channel there.

@peter-mlabs do you know if it is possible?

What about just having a Liqwid Labs discord? We'll have the same issues with the extras libraries.

Solved by #140.


Add postgresql.replication_delay_bytes metric for version 10

What does this PR do?
For postgresql version 10, the postgresql.replication_delay_bytes metric was missing. This PR adds the query and metric to the check.
Motivation
What inspired you to submit this pull request?
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2363 into master will decrease coverage by 0.62%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
- Coverage   79.54%   78.91%   -0.63%
==========================================
  Files         204        5     -199
  Lines       13775      498   -13277
  Branches     1460       88    -1372
==========================================
- Hits        10957      393   -10564
+ Misses       2428       73    -2355
+ Partials      390       32     -358


[BUG] Firefox & Safari

In Firerox I am not shown the editing options, and in Safari I get an error.
Safari
Firefox

Re safari: I have no idea, maybe you have an old version
Re firefox: Try CMD+. - it should toggle sidebar - it's should be visible by default


Update Rust Benchmark

This PR updates rust regex create and improve the regex performance.

There is a better PR( #21) for this change, therefore I close this one.