Mod breaks mirror functionality

The mirror functionality is broken when using this mod.  Holding the hotkey (default A) does nothing, and pressing the mirror button in the select tool causes the y scale to be set to 0.1.
My assumption is the sliders are enforcing a minimum positive value and the mirror tool is attempting to set one of the scales to a negative value.

Are you using version 1.2.1? It should be fixed since that update.

Ahh ok, yeah I was on 1.1.0 apparently.  Shame there's no easy way of indicating updates are available.  Thank you!


Document package architecture

to make it easyer for devs to find the right place for code
close #655

that's just stupid - we need to escape - but escape char will get rendered :/

I'll just write down the current state (and what it should be) with TODOs in source ... we can refactor this later

Codecov Report

Merging #972 (7860fff) into master (bdcee93) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   51.32%   51.39%   +0.06%
==========================================
  Files          81       81
  Lines        6143     6143
==========================================
+ Hits         3153     3157       +4
+ Misses       2807     2803       -4
  Partials      183      183

Impacted Files
Coverage Δ

server/model/build.go
0.00% <ø> (ø)

server/model/proc.go
43.63% <ø> (ø)

server/shared/configFetcher.go
94.94% <ø> (ø)

server/shared/procBuilder.go
86.09% <ø> (ø)

server/shared/userSyncer.go
0.00% <ø> (ø)

server/shared/buildStatus.go
100.00% <100.00%> (ø)

server/shared/procStatus.go
100.00% <100.00%> (ø)

server/logging/log.go
54.65% <0.00%> (+4.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdcee93...7860fff. Read the comment docs.


Allow <head> and footer scripts to be changed via config

Common feature request is an easy way to add scripts to <head> or in the footer without modifying any of the theme files.
Currently this can be done by adding custom script elements to _includes/head/custom.html or _includes/footer/custom.html This pull request allows the user to add additional scripts to either <head> or before the closing </body> elements via their _config.yml file.
Simply add the full relative (or absolute) path(s) to relevant array and they will be added to the page.
Examples:
head_scripts:
  - https://code.jquery.com/jquery-3.2.1.min.js
  - /assets/js/your-custom-head-script.js
footer_scripts:
  - /assets/js/your-custom-footer-script.js

In the case of footer_scripts, if used, the default /assets/js/main.min.js file won't be loaded and jQuery and other scripts used by the theme will need to be added to the array or replacements found. Unless you want the collapsible navigation, image lightboxes, smooth scrolling, and other niceties to stay broken ;-)
Note: depending on the size of your site there may be a slight performance hit to build times as each of these config variables introduce for loops.
Ref: #1238

Good stuff! So a custom footer_scripts with functionality  equivalent to the out-of-the-box one would look like this (going by the uglify script)?
footer_scripts:
  - /assets/js/vendor/jquery/jquery-1.12.4.min.js
  - /assets/js/plugins/jquery.fitvids.js
  - /assets/js/plugins/jquery.greedy-navigation.js
  - /assets/js/plugins/jquery.magnific-popup.js
  - /assets/js/plugins/jquery.smooth-scroll.min.js
  - /assets/js/_main.js

Looks about right. That should be everything.

Great, so now anyone could do this to get a CDN-equivalent:
footer_scripts:
  - https://cdnjs.cloudflare.com/ajax/libs/jquery/1.12.4/jquery.min.js
  - https://cdnjs.cloudflare.com/ajax/libs/fitvids/1.2.0/jquery.fitvids.min.js
  - /assets/js/plugins/jquery.greedy-navigation.js (didn't see a CDN for this)
  - https://cdnjs.cloudflare.com/ajax/libs/magnific-popup.js/0.9.9/jquery.magnific-popup.min.js
  - https://cdnjs.cloudflare.com/ajax/libs/jquery-smooth-scroll/1.7.2/jquery.smooth-scroll.min.js
  - /assets/js/_main.js

BTW, regarding the versions:

jQuery - I guess you're using 1.x for IE6-8 support?
jquery.fitvids.js - latest is 1.2.0 (MM is using 1.1)
jquery.greedy-navigation.js - looks like a couple of small updates have been made (I diffed the MM version with the one currently on master)
magnific-popup - latest is 1.1.0 (MM is using 0.9.9)
jquery-smooth-scroll - latest is 2.2.0 (MM is using 1.7.2)

Some of those scripts are breaking changes if updated. Out of scope for this PR.

Sure, was just wondering.
Should I open an issue for package update?
If so, one issue or issue per package?

Don't worry about it. I have it covered. Some of these I may drop or replace with lighter alternatives. Now that scripts can be added easily I don't need to bundle everything and can leave it up to the user to augment if they want.

Cool! Could you throw me a hint on which of these I should be OK with upgrading in my override?

Not sure. You'll have to test.
If memory serves Magnific Popup had some CSS changes that I didn't want to mess with so I didn't bother updating.
Greedy nav had something I needed to override to fix a styling inconsistency.
The others I haven't looked at in a while.

Understood. Thanks again for this. I guess I'll just follow the versions in the theme for now (simple enough to diff and update when a new release is out).

Just a thought, maybe you could include something like _main-only.min.js (a minified version of _main.jsonly) which could be used in the custom footer scripts approach rather than the "development-flavor"_main.js `?


Handle an empty query parameters with @Default

Say we have an annotated service that uses @Default annotation to optionally bind query parameters.
class MyService {
    @Get("/list")
    public String list(@Default @Param Integer page) {
        ...
    }
}

As per the Javadoc of @Default, when a value is not specified for @Default, a non-existent parameter is converted into null. page is null if /list is the request path.
https://github.com/line/armeria/blob/ccb29fee0fea5a8657fe3ad2de1fe0a19062818c/core/src/main/java/com/linecorp/armeria/server/annotation/Default.java#L35-L36
However, it does not work well if there is a parameter but no value. A NumberFormatException is raised when /list?page= is sent as the request path.
java.lang.NumberFormatException: For input string: ""
	at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:67)
	at java.base/java.lang.Integer.parseInt(Integer.java:671)
	at java.base/java.lang.Integer.valueOf(Integer.java:988)
	at com.linecorp.armeria.internal.server.annotation.AnnotatedServiceTypeUtil.stringToType(AnnotatedServiceTypeUtil.java:177)
	at com.linecorp.armeria.internal.server.annotation.AnnotatedValueResolver.convert(AnnotatedValueResolver.java:1021)

It would be better to solve this problem as follows the value of the parameter is empty.

Inject an empty string ("") if the type of page is String.
Inject a null value if the type of page is not String such as Integer, Boolean and so on.

In addition to the bugfix, we also need to improve the error message when an incorrect request is made so that users can easily identify the problem.

@ikhoon
Hello. Can I pick up this issue?

Yes, please. 😀

@ikhoon
What if the type of parameter is primitive such as int, long?
class MyService {
    @Get("/list")
    public String list(@Default @Param int page) {
        ...
    }
}

In this case, which response do you prefer?

@ikhoon
Plus, in terms of handling empty query parameters, I am considering couple of cases like below:
Case 1
Say service is like:
class MyService {
    @Get("/list")
    public String list(@Default("1") @Param List<Integer> params) {
        ...
    }
}

But the request is sent like /list?params=.
Then which action would be processed?

Inject null to params
Inject [1] to params
Throw an exception

Case 2
If service is like
class MyService {
    @Get("/list")
    public String list(@Default @Param List<Integer> params) {
        ...
    }
}

and the request is sent like /list?params=.
Then which action would be processed?

Inject null to params
Inject [null] to params
Throw an exception

Case 3
If service is like
class MyService {
    @Get("/list")
    public String list(@Default @Param List<String> params) {
        ...
    }
}

and the request is sent like /list?params=.
Then which action would be processed?

Inject null to params
Inject [""] to params
Inject [null] to params
Throw an exception

Please give me your opinion for enhancement. Thank you.


[CI] Slack process is not work well

Description

Is there anyone can help to confirm the CI pipeline of Slack can work well?
https://github.com/service-mesh-performance/service-mesh-performance/actions/runs/988410331
Expected Behavior

Screenshots

Environment:

OS: [e.g. Ubuntu]
Browser: [e.g. Chrome, Safari]
Version: [e.g. 22]
Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

We can setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true first.


parse_property autocomplete raise bad signature error

Godot version
4.1.dev (4640b553a21) but present since 4.0
System information
MacOS 13.1 M1 Pro
Issue description
when autocompleting the _parse_property function with types it will raise bad signature error.

This is because instead of completing with enum types it completes with int types. I don't know if this is a bug only in this function or in all function containing variable typed with enums as I don't know of any other virtuam function typed with enums
Steps to reproduce

activate add type hint
create a script inheriting EditorInspectorPlugin
start typing func _parse_property
autocomplete the rest

Minimal reproduction project
N/A

Thanks for your report, this is a duplicate of https://github.com/godotengine/godot/issues/75311.


bpf: node_config - reduce default amount of vtep endpoints to 2

Specifying more than 2 endpoints currently causes LLVM to emit non-global
static data reads from an .rodata.cst32 section, which is not supported by
our version of libbpf, nor by cilium/ebpf.
<EMAIL_ADDRESS>This commit fixes verifier-test.sh as it uses the default node config.
Issue introduced in https://github.com/cilium/cilium/pull/17370.
Related: https://github.com/cilium/cilium/issues/18730.
Provide only 2 VTEP endpoints in default node_config.h

cc @vincentmli @pchaigno @joestringer

This change is not covered by end-to-end tests and compile tests are passing. Marking ready to merge.


Add missing ProjectAsync aggregate overload for immutable aggregates

Whoops, thought I already did somehow, has been added.

Thanks, @Hawxy!


dart: 2.7.1 -> 2.7.2 (stable) + 2.8.0-dev.10.0 -> 2.9.0-4.0.dev (dev)

Motivation for this change
Bum dart stable and dev channels to the latest.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

c/c @GRBurst

Result of nixpkgs-review pr 86205 1

2 packages built:
- dart (dart_stable)
- dart_dev


Dynamic Toolbar Preferred Default Height

@jessesquires
I'm trying to implement a feature where the height of the toolbar is determined by some state the JSQMessagesViewController-subclass has.
I find that there is no good opportunity to pass that state to the JSQMessagesInputToolbar subclass before the toolbarHeightConstraint is set in jsq_configureMessagesViewController.
- (void)jsq_configureMessagesViewController
{
    self.view.backgroundColor = [UIColor whiteColor];
    self.jsq_isObserving = NO;
//Right here...
    self.toolbarHeightConstraint.constant = self.inputToolbar.preferredDefaultHeight;

I can work around this in one of three ways:

making toolbarHeightConstraint public,
or by making @selector(jsq_configureMessagesViewController) public,
or by creating a new entry point that we call from inside jsq_configureMessagesViewController just before setting the toolbarHeightConstraintConstant.

1 & 2 are not ideal solutions.
Perhaps we can break out the lines of code which configure the toolbar into something that subclasses can override, to allow subclasses to do some sort of pre-processing.
Would you be interested in seeing a PR for something like this?
The risk would be low & the net effect to existing clients would be nil.

Hey @walsh2000 - I'm open to it!

PR #877 is one way to achieve the desired effect. Low risk. Zero impact to existing consumers.

Been thinking about how to solve this too - as well as how to add additional buttons, views, etc. into the toolbar based on a JSQMessagesVC state. Gonna pull #877 and try it out. Have you discovered anything else since you pushed that @walsh2000?

@walsh2000 thanks for PR #877 it was very useful

@gcarlo89 :smiley:

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Move technical exception to dedicated package

As in https://github.com/jhipster/jhipster-lite/pull/3682 move this package in generated applications (in ZalandoProblemsModuleFactory)

@DamnClin : I wonder if we could add a new optional property like 'packageDestination', so the user can choose where to generate these classes.
By default, it could be:

error.infrastructure.primary

Then, the user could choose the old one for exemple:

technical.infrastructure.primary.exception

It means, the template should look like:
package {{packageName}}.{{packageDestination}};

I think it could be nice because:

some user don't like infrastructure
some other could replace primary by something else
etc

What do you think?

This mean adding, at least, 3 properties, could be done but not sure the UX will be that good

Let's wait few days and think about my suggestion, as maybe there can be some impact

@DamnClin : ZalandoProblemsModuleFactory doesn't exist anymore. Is this issue still relevant since migration to Spring Boot 3?

let's close this as it's probably not relevant anymore


Bump minor version number to 1.1 due to API change

(This is a meta bug to refer issues where we added new APIs since 1.0)

Closing as resolved now that 1.1 has been released.

To finish the list: only #5525 has been added since.


<IP_ADDRESS> build error (in stackage nightly)

Configuring btrfs-<IP_ADDRESS>...
> /tmp/stackage-build12/btrfs-<IP_ADDRESS>$ runghc -clear-package-db -global-package-db -package-db=/var/stackage/work/builds/nightly/pkgdb Setup build
Building btrfs-<IP_ADDRESS>...
Preprocessing library btrfs-<IP_ADDRESS>...
Capabilities.hsc:9:28: fatal error: sys/capability.h: No such file or directory
compilation terminated.
compiling dist/build/System/Linux/Capabilities_hsc_make.c failed (exit code 1)
command was: /usr/bin/gcc -c dist/build/System/Linux/Capabilities_hsc_make.c -o dist/build/System/Linux/Capabilities_hsc_make.o -fno-stack-protector -fno-stack-protector -D__GLASGOW_HASKELL__=800 -Dlinux_BUILD_OS=1 -Dx86_64_BUILD_ARCH=1 -Dlinux_HOST_OS=1 -Dx86_64_HOST_ARCH=1 -Iinclude -Idist/build/autogen -include dist/build/autogen/cabal_macros.h -I/opt/ghc/8.0.1/lib/ghc-8.0.1/unix-<IP_ADDRESS>/include -I/opt/ghc/8.0.1/lib/ghc-8.0.1/time-<IP_ADDRESS>/include -I/opt/ghc/8.0.1/lib/ghc-8.0.1/bytestring-<IP_ADDRESS>/include -I/opt/ghc/8.0.1/lib/ghc-8.0.1/base-<IP_ADDRESS>/include -I/opt/ghc/8.0.1/lib/ghc-8.0.1/integer-gmp-<IP_ADDRESS>/include -I/opt/ghc/8.0.1/lib/ghc-8.0.1/include -I/opt/ghc/8.0.1/lib/ghc-8.0.1/include/

Hi, thanks for the report. I just published a new version (<IP_ADDRESS>) on hackage that should fix this issue.


Objective-C Version?

This is not an issue but a request - for an objective-c version! This looks awesome. I'd love to be able to use it but I don't know Swift.

Sure. I'll post back when it's done.

Incredible - thank you so much!

Let me know if this works for you. I haven't had a chance to do much testing, but it's functionally equivalent to the Swift version.
https://github.com/dbettermann/AlertController

Dylan,Thank you so much! I added it to my project and made the appropriate changes. It seems to be working so far (for AlertView, not ActionSheet since that has to be presented from a view). I will shoot you an email if I encounter any issues, but if you don't hear from me, assume all is well. Thank you again so much!Jennifer
 On Tuesday, June 23, 2015 11:10 PM, Dylan Bettermann<EMAIL_ADDRESS>wrote:

Let me know if this works for you. I haven't had a chance to do much testing, but it's functionally equivalent to the Swift version.https://github.com/dbettermann/AlertController—
Reply to this email directly or view it on GitHub.


How to generate content instead of a file?

Is it possible to generate a string with content instead of a file? I want to create a virtual module in vite and I need to get the content string after generation. Is there such a possibility?

I see that docs mention that if you don't define output property it will actually not write to disk, so maybe that just returns content as string that you can use?


chore: Merge provernet to master

This PR brings the provernet changes back to master

Benchmark results
Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,360 (+81%)
avm_simulation_time_ms (FeeJuice:set_portal): 10.1 (-32%)
avm_simulation_time_ms (Token:mint_public): 50.2 (-89%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 685 (+142%)
avm_simulation_time_ms (Token:transfer_public): 21.4 (+48%)
l2_block_processing_time_in_ms (8): 752 (+53%)
node_history_sync_time_in_ms (3): 4,391 (+37%)
node_history_sync_time_in_ms (5): 6,654 (+56%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,790
1,573 (+1%)
726 (+1%)
778 (+2%)
781 (+1%)

proof_construction_time_sha256_30_ms
11,624
3,091 (-1%)
1,383 (-1%)
1,409 (-2%)
1,457 (-1%)

proof_construction_time_sha256_100_ms
44,063 (-1%)
11,825 (-1%)
5,813 (+3%)
5,539 (-11%)
5,387 (-1%)

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
59.0 (+2%)
88.0

proof_construction_time_poseidon_hash_30_ms
1,527
423
204
230 (+2%)
274 (+1%)

proof_construction_time_poseidon_hash_100_ms
5,651
1,516
679
734 (-1%)
743

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
4,356
7,876
14,884

l1_rollup_calldata_gas
50,076
93,010
178,132

l1_rollup_execution_gas
842,917
1,576,747
3,361,925

l2_block_processing_time_in_ms
253 (+2%)
:warning: 752 (+53%)
820 (-13%)

l2_block_building_time_in_ms
11,057 (+2%)
21,500
42,774 (+1%)

l2_block_rollup_simulation_time_in_ms
11,056 (+2%)
21,500
42,774 (+1%)

l2_block_public_tx_process_time_in_ms
9,414 (+2%)
19,847
41,113 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
:warning: 4,391 (+37%)
:warning: 6,654 (+56%)

node_database_size_in_bytes
12,427,504
16,437,488

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
simulation_time_in_ms
witness_generation_time_in_ms
input_size_in_bytes
output_size_in_bytes
proving_time_in_ms

private-kernel-init
76.3
383 (+2%)
21,377
44,898
N/A

private-kernel-inner
153 (-10%)
675
72,358
45,020
N/A

private-kernel-reset-tiny
274 (-2%)
661 (-5%)
65,018
44,886
N/A

private-kernel-tail
150
126 (-1%)
50,589
52,921
N/A

base-parity
5.58
N/A
160
96.0
N/A

root-parity
35.4 (+1%)
N/A
73,948
96.0
N/A

base-rollup
2,612 (-14%)
N/A
189,169
664
N/A

block-root-rollup
41.2
N/A
58,205
2,448
N/A

public-kernel-setup
78.8
N/A
105,085
71,222
N/A

public-kernel-app-logic
91.8 (-2%)
N/A
104,895
71,222
N/A

public-kernel-tail
803
N/A
390,582
16,414
N/A

private-kernel-reset-small
267 (-1%)
N/A
66,341
45,629
N/A

private-kernel-tail-to-public
:warning: 1,360 (+81%)
576
446,144
1,825
N/A

public-kernel-teardown
78.0
N/A
105,349
71,222
N/A

merge-rollup
20.3 (+1%)
N/A
38,174
664
N/A

undefined
N/A
N/A
N/A
N/A
82,478 (-3%)

Stats on running time collected for app circuits

Function
input_size_in_bytes
output_size_in_bytes
witness_generation_time_in_ms

ContractClassRegisterer:register
1,344
11,731
346 (+1%)

ContractInstanceDeployer:deploy
1,408
11,731
18.2 (+1%)

MultiCallEntrypoint:entrypoint
1,920
11,731
406 (+1%)

FeeJuice:deploy
1,376
11,731
387 (+1%)

SchnorrAccount:constructor
1,312
11,731
62.6 (+1%)

SchnorrAccount:entrypoint
2,336
11,731
370

FeeJuice:claim
1,344
11,731
39.5 (+5%)

Token:privately_mint_private_note
1,280
11,731
70.8 (-1%)

FPC:fee_entrypoint_public
1,344
11,731
24.0 (-1%)

Token:transfer
1,312
11,731
212 (-5%)

Benchmarking:create_note
1,344
11,731
74.6 (+1%)

SchnorrAccount:verify_private_authwit
1,280
11,731
26.3

Token:unshield
1,376
11,731
500

FPC:fee_entrypoint_private
1,376
11,731
664 (-7%)

AVM Simulation
Time to simulate various public functions in the AVM.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
50.1 (+2%)
2,307

FeeJuice:set_portal
:warning: 10.1 (-32%)
2,680

Token:constructor
74.4 (+2%)
13,839

FPC:constructor
49.5 (+5%)
8,553

FeeJuice:check_balance
35.6 (-2%)
2,041

Token:mint_public
:warning: 50.2 (-89%)
4,572

Token:assert_minter_and_mint
:warning: 685 (+142%)
3,006

AuthRegistry:set_authorized
37.7 (+1%)
923

FPC:prepare_fee
82.4 (-9%)
3,925

Token:transfer_public
:warning: 21.4 (+48%)
9,482

FPC:pay_refund
45.6 (+5%)
4,856

Benchmarking:increment_balance
1,169
3,170

Token:_increase_public_balance
38.6 (-3%)
2,284

FPC:pay_refund_with_shielded_rebate
50.9 (-2%)
4,856

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.161 (+4%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.28 (+4%)
3.89 (-1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.118 (+4%)
0.109 (-1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.1 (+1%)
17.9 (-5%)
30.8 (+1%)
60.3 (-8%)
114 (+2%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.106 (+1%)
0.103 (-6%)
0.100 (+1%)
0.103 (-9%)
0.101 (+1%)

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.1 (+1%)
25.7 (-8%)
43.8 (+1%)
85.7 (-13%)
167 (+4%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
108 (+1%)
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.108
0.104 (-9%)
0.101 (-3%)
0.105 (-15%)
0.106 (+5%)

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.7 (-4%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
131 (-1%)
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.108 (-4%)
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,838
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |


Refactoring

Splitting from #517

introduce a new Connections object to track all positional strings passed as the CLI arguments
make xyz use better types - u8 for zoom, u32 for x&y.  Postgres casts those to INT2 and INT8
minor bug in pre-push git hook

Codecov Report
Base: 60.42% // Head: 61.57% // Increases project coverage by +1.15% :tada:

Coverage data is based on head (ba15c3b) compared to base (3357b80).
Patch coverage: 75.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   60.42%   61.57%   +1.15%
==========================================
  Files          23       25       +2
  Lines        1933     1991      +58
==========================================
+ Hits         1168     1226      +58
  Misses        765      765

Impacted Files
Coverage Δ

src/source.rs
82.85% <0.00%> (ø)

src/utils/error.rs
15.38% <15.38%> (ø)

martin-tile-utils/src/lib.rs
72.09% <52.17%> (+22.09%)
:arrow_up:

src/args/connections.rs
70.00% <70.00%> (ø)

src/srv/server.rs
78.97% <77.77%> (-0.60%)
:arrow_down:

src/args/pg.rs
83.45% <100.00%> (-0.58%)
:arrow_down:

src/args/root.rs
92.55% <100.00%> (-0.16%)
:arrow_down:

src/config.rs
60.93% <100.00%> (+3.12%)
:arrow_up:

src/pg/pg_source.rs
74.66% <100.00%> (+2.60%)
:arrow_up:

src/utils/one_or_many.rs
98.24% <100.00%> (+0.68%)
:arrow_up:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CI: enable testing Python 3.13 and NumPy 2.1

Follows #2086 to finally enable testing of Python 3.13 with NumPy 2.1. Currently, both these are available as release candidates. Also note that NumPy 2.0.x does not have any binary wheels out for Python 3.13.
I'm not sure when GEOS 3.13 is ready, but this would ideally be put under the "2024" item too when it's out.

Looks like it needs pyproj wheels for 3.13, which is blocked on https://github.com/pyproj4/pyproj/issues/1425.

This PR now adjusts a few tests for GEOS 3.13.0beta1; see changes.
The more significant change is with RelateNG, which is more tolerant with invalid geometries.
Changes to STRTree are also more tolerant with invalid geometries.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 88.162%

Totals

Change from base Build<PHONE_NUMBER>4:
0.3%

Covered Lines:
2629

Relevant Lines:
2982

💛  - Coveralls


HBASE-25168 Unify WAL name timestamp parsers

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
checkstyle
1m 21s
master passed

+1 :green_heart:
spotbugs
2m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

-0 :warning:
checkstyle
1m  3s
hbase-server: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 24s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m 58s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2524

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 89f63ece9f56 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f34ba06468

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 16s
master passed

+1 :green_heart:
compile
1m 33s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  3s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
1m 32s
the patch passed

+1 :green_heart:
javac
1m 32s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
129m 56s
hbase-server in the patch passed.

+1 :green_heart:
unit
8m 15s
hbase-mapreduce in the patch passed.

168m 21s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2524

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 83ac7812a09b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f34ba06468

Default Java
2020-01-14

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/testReport/

Max. process+thread count
4256 (vs. ulimit of 30000)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 45s
master passed

+1 :green_heart:
compile
1m 22s
master passed

+1 :green_heart:
shadedjars
6m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 41s
the patch passed

+1 :green_heart:
compile
1m 44s
the patch passed

+1 :green_heart:
javac
1m 44s
the patch passed

+1 :green_heart:
shadedjars
8m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
154m 50s
hbase-server in the patch passed.

+1 :green_heart:
unit
9m 46s
hbase-mapreduce in the patch passed.

197m 22s

Subsystem
Report/Notes

Docker
Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2524

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 75c6b172deb7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f34ba06468

Default Java
1.8.0_232

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/testReport/

Max. process+thread count
4404 (vs. ulimit of 30000)

modules
C: hbase-server hbase-mapreduce U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2524/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Please fix the checkstyle issue before merging? @saintstack

Merged manually after fixing checkstyle.


⚠ Bofrost.de has degraded performance

In 861dde1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1611 ms

Resolved: Bofrost.de performance has improved in d3f401e after 13 minutes.


Release flagged as malicious

Hi @Fefedu973
I ran the latest release through VirusTotal and got this result:

https://www.virustotal.com/gui/file/ff841612f6559f53c6748ac8cba6861d4841dfa1123915b2c0dc2561a3ab15e9/detection

Bruh, I think this is because my plugin is downloading the updater in the background when it finds an update which is a common thing that viruses do

Could you please try to build it yourself and compare the hash and put it in virus total to check if there is the same detection?

?

Yes, I also got the win-x64 exe I published flagged:

https://www.virustotal.com/gui/file/947e5f6bac98346370534a97167fa43b505e11b5cf361c8985d76eaac21bb3ab

Yes, I also got the win-x64 exe I published flagged:

https://www.virustotal.com/gui/file/947e5f6bac98346370534a97167fa43b505e11b5cf361c8985d76eaac21bb3ab

Ok so that means that if you check the code (it's open source) and you find nothing malicious (you won't find anything malicious because it is not) that this software is not a malware...
Can I close the issue or not ?
Thanks for your Involvement it saves me of the same question but from people that don't know how all of that works...

Yes, I understand that this is no malicious code in the repo. However, I would recommend to try figure out why some antivirus providers flag this code. It would build trust among users if the release was clean.


Add non_cern_machine (Brussels) profile

Description
Title speaks for itself.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

The profile files for non-CERN machine (here Brussels) need to be saved for reference and backup.
Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@lpetre-ulb @bdorney any updates? If this PR is stale, please let me know and it will be closed

@lpetre-ulb @bdorney any updates? If this PR is stale, please let me know and it will be closed

Currently, this machine is not fully used. However, the data could be used as basis for another non-CERN machine so I will update the PR today. Thank you for the remainder.

Comments should be addressed. The two files aforementioned are excluded from the commit.


[Improvement][API] update web ui user admin default password easy

Describe the question
web ui  user admin default password  is  dolphinscheduler123，the password is difficult to input.
What are the current deficiencies and the benefits of improvement
update user admin default password easy, eg: admin ,123456 ...
let's user easy to start, Just a little bit。

web ui user admin default password is dolphinscheduler123 ,This is just an initial password, you can change a password you want through the password change function.


Add hexathon field to branch model

Description
Adds the hexathon field to the branch model for the tracks section of the registration dashboard and adjusts docs site accordingly.
Issues

HackGT/registration2#12

Looks good!


[HOLD] DO NOT MERGE

Use the links below to test this build in android and iOS. Happy testing!

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/26821/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/26821/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/26821/NewExpensify.dmg
https://26821.pr-testing.expensify.com

This PR was created to make ad hoc builds. Closing


{python{Full,Packages},pypyPackages}: move unversioned aliases to aliases.nix

Motivation for this change
Require in-nixpkgs packages to use versioned names.
:snake: :2nd_place_medal: :chart_with_downwards_trend:
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Sort of an RFC PR.

Python is part of the darwin stdenv bootstrapping, I think a bit of work is still needed to disambiguate it there.

release.nix evaluates already :man_shrugging:

The above ~180 package updates were done with this in one terminal:
while true; do sed -ie 's/python/python2/g' $(nix-env -f . -qaP --no-name --out-path --arg config '{ allowAliases = false; }' 2>&1 | tee /dev/stderr | head -n1 | cut -d' ' -f5  | cut -d: -f1); sleep 1; done

and me committing its changes in another terminal, note not all changes are good, so don't just blindly commit. you have to edit patches.
for f in $(git status | grep "modified:" | cut -d' ' -f4); do echo "$f"; git add -ip "$f"; echo -n "package name? "; read pname; git commit -m "$pname: python -> python2"; done

Require in-nixpkgs packages to use versioned names.

What do we gain by that? In principle we should have only one version of a package (set), but we indeed choose in some cases to have multiple versions. Would you say that, in case one goes from a single attribute to multiple, the single name should no longer be permitted and a versioned one should always be used?
About the python to python2, I pointed out in earlier PR's that I am against doing it this way, and prefer us to try to migrate it to Python 3 first, and when that is not possible, set it to python2. Otherwise we may end up repeating a lot of work.


Document mirror setups

There might be a few already we can pull from in the Trillian examples. It could be as simple as a bash for loop that tails one log with rekor-cli loginfo and rekor-cli get --uuid, then uploads those entries to another Rekor server instance.
Ref #210

We should also document some easy to use "non-transparent" mirrors for internal use. We're planning to throw data into bigquery/pubsub as part of #191. We should document how others can slurp in data directly from the log (and verify it!) then stick it into something queryable/indexable for internal use.

Closing - We don't have any mirrors in the ecosystem and instead would distribute new logs rather than view-only mirrors in a TUF root.


Feature: Add ability to bail from current suite only

I have a lot of tests that are dependent on previous steps, and when an early step fails it causes everything after it to fail too, leading to a lot of unnecessary noise.  There's only so much that makes sense to go in the before() block.  I've implemented the feature myself, but the contributions guidelines say not to PR new features, so I'll just link to my fork here: https://github.com/mochajs/mocha/compare/master...hoverduck:master
It's a relatively simple change, but it's possible (likely) I missed something, so I'd love feedback even if you opt not to accept a PR for it.
My implementation works by calling this.bailSuite( true );  at the top of the suite (inside the describe() block) you want chunked together, and then on failure it will bail out of that suite to the next one at the same level in the hierarchy.

Interesting idea! I realize there's def times where it's hard to manage all the dependencies and requirements for a spec. It's generally considered an anti-pattern to have tests depend on the execution of other tests - a good test suite should be able to have its individual specs run in any order. But as you've highlighted, you can end up with a lot of noise. I generally see this as being a more common issue with acceptance tests using phanntomjs/selenium/nightmare/etc.
That said, I'm not sure I really see the benefit of bailSuite. If you want reduced noise, shouldn't you just use bail? Why continue to run the test suite at all, since bailSuite ends up masking the total number of errors in your suite. Just because the first error'ed doesn't mean others in the test suite would have. So the reporting can't be accurate?
I'm thinking this is something that would make for a good plugin though! :)

I generally see this as being a more common issue with acceptance tests using phanntomjs/selenium/nightmare/etc

Exactly right.  We're running end-to-end acceptance tests of our system.

If you want reduced noise, shouldn't you just use bail?

Bail reduces the noise too much.  I'd rather run all the later tests to know whether I have more problems.  Given the choice between too much noise and not running all the test suites, I'd rather run all the suites.

Why continue to run the test suite at all, since bailSuite ends up masking the total number of errors in your suite

I prefer to think of it as squashing all of the errors into a single report.  You could make the argument that this is basically duplicating the functionality of the before() hook, but I think this just gives some extra flexibility.

I'm thinking this is something that would make for a good plugin though! :)

Sounds good to me.  Is this (https://github.com/mochajs/mocha/issues/1457) the current status of the plugin system?  What's the release schedule look like for that?

@hoverduck no release schedule yet, but code actually exists.

Is there a branch to check out or anything where I could give it a try?  If it's stable enough to warrant outside feedback yet.
Regardless, I'm going to go ahead and close this issue as my code won't be merged into the baseline.


CP-1211 Upgrade to gulp-connect 2.3.1

Just a heads-up that the gulp-connect packaged required in wGulp has some broken stuff in its latest release which affects Smithy builds.  There is a new release in the pipeline, however: https://github.com/AveVlad/gulp-connect/releases/tag/2.3.1  Fix was released 12 minutes ago.

Reported by @jimhotchkin-wf
Changes
Source:

Update gulp-connect dependency

Testing

CI Passes
@jimhotchkin-wf would you be able to supply a testing +10 for this PR?

Code Review
@trentgrover-wf
@evanweible-wf
@dustinlessard-wf
FYI @jayudey-wf

Testing +10 : Smithy builds no longer error out.  Local builds pull down expected version of gulp-connect @ 2.3.1.
Just wondering if you have considered pinning the versions of these packages?
Thanks!

+1

+1

QA Resource Approval: +10

[ ] Testing instruction
[ ] Dev +1's
[ ] Dev/QA +10 with detail of what was tested
performed and documented by Jim Hotchkin
[ ] Unit test created/updated
[ ] All unit tests pass

Merging into master.

rosie


Improve Mesos / Marathon metrics

These are in particular useful to detect when a slave is unregistered from Mesos and what is the status of a Marathon spawn app.

@ktf Would you cool applying these commits to our new split out repos for this projects:
https://github.com/riemann/riemann-marathon
https://github.com/riemann/riemann-elasticsearch
https://github.com/riemann/riemann-mesos
Or I can cherry-pick. Let me know!

What's the point of having one separate repository for per 500 lines ruby script? Isn't that a bit of an overkill? Anyways, fine with me if you want to cherry pick them.

@ktf The dependencies on Riemann tools were getting very complex. For example, before the split, the gem dependencies meant I had to install far more gems than seemed reasonable for say just using Riemann-health.

I've cherry-picked all of these to the specific repositories! Thanks!
@aphyr This can be closed.

Regarding the dependencies hell, why not splitting according to the required dependencies, rather than one repo per file? For what I've seen there is plenty of watchers which are just periodic polling to HTTP based APIs, IMHO it makes no sense to have them so sparse.

They are just split by dependency - the only tools split out are those with dependencies. The rest are in this repo.

No, they are not split by dependencies. Mesos, marathon and elasticsearch share all the same dependencies and could be packaged together in one single repo, for example. I am sure there is more. Sorry for insisting, but having seen multiple times how this kind of split ups diverge in a disastrous manner, I think it would be healthy for the project to regroup those which can be regrouped.

I also think it's a fine idea to use subdirectories in one repo for separate gems--only reason I split out some tools to different repos was to give certain users the ability to maintain their own code.
On Jan 24, 2016 08:33, Giulio Eulisse<EMAIL_ADDRESS>wrote:No, they are not split by dependencies. Mesos, marathon and elasticsearch share all the same dependencies and could be packaged together in one single repo, for example. I am sure there is more. Sorry for insisting, but having seen multiple times how this kind of split ups diverge in a disastrous manner, I think it would be healthy for the project to regroup those which can be regrouped.
—Reply to this email directly or view it on GitHub.

Sorry I misunderstood your comment. I considered grouping by dependency but I've seen that make discoverability more difficult - riemann-tools-faraday versus riemann-mesos. The latter seems much more discoverable. I don't see a huge gain in shrinking repos as the dependency breakdown is:
Mesos, marathon and elasticsearch, rabbit - Faraday
Munin - munin-ruby
AWS (which is multiple tools) - Fog
Docker - docker-api
Riak - yajl-ruby
Regarding divergence - I've had the opposite experience :) - I've seen this split make tools much more usable and mangeable (and certainly installable). And especially here as they are all dependent on the core riemann-tools scaffolding.
But if you're violently opposed then I'll step back and revert all the changes. I don't want to manage it in such a way that you don't want to contribute to it.

As an FYI - this is the conversation upon which the changes were based and discussed: https://github.com/aphyr/riemann-tools/issues/61.

Well, I would name the package riemann-tools-http and put there all the tools where all they do is to call some HTTP based API and push results to riemann. In the end faraday is just an implementation detail.
Notice that having a single repository does not mean you need to have a single gem for all of them, it merely makes it easier to do and commit bulk changes to them and avoids the usual issue where you end up with different leaf packages requiring different version of their base dependencies because they evolved (and got tested) independently.
Anyways, I never "violently" oppose things, I merely have a "warm preference" ;-), so if consensus was reached let's not reopen the discussion.

Okay. :)
The sub-directory approach seems reasonable in the riemann-tools repo. I'll come back to that this weekend or whenever I get a chance.
@aphyr No objections to us dancing back to this repo? :)

I'll defer to you, James! You're project steward here. :)

@aphyr Ha! Thanks. Poison meet chalice. :grin:

This can be closed BTW @aphyr either way I've cherry-picked the commits into the #138.


Fix: Added the tooltip for the eject button

Summary
This is a small fix.
Task Checklist

[x] Added the tooltip for the eject button
[x] Clean up
[ ] Apply requested changes

Known Issues
N/A
PR Checklist

[x] Closes: N/A
[ ] Approval: Have discussed with and got approval from the team[^1]
[x] Tests: Tested accessibility on the local end
[x] Deployment: Deployed the app on the local end
[ ] Localization: Modified en-US string resources[^2]
[ ] Co-authors: N/A

Steps To Validate Changes
N/A
Screenshots
Before

After

[^1]: If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.
[^2]: If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do, instead.

@yaira2 Ready for review.


Test: Add CLA Corporate Console to Datadog Session Replays

Summary
Add CLA Corporate Console to Datadog Session Replays
Background
We need to instrument Session Replay on the CLA Corporate Console to help with troubleshooting issues there. We have the section ready in Datadog at https://app.datadoghq.com/rum/sessions?query=%40application.id%3Aea9b5eb2-c3e0-4e58-a5a6-b3c41212dd05 %40type%3Asession&agg_m=count&agg_m_source=base&agg_t=count&cols=&fromUser=false&track=rum&from_ts=1723068256724&to_ts=1723154656724&live=true
This would be set up the same as the Organization Dashboard is, making sure that we get the User’s username to come through as the User ID in datadog in order to search replays.
Documentation : RUM Browser Monitoring Setup
The values in DD for the Easycla Corporate console are:
import { datadogRum } from '@datadog/browser-rum';
datadogRum.init({
applicationId: 'ea9b5eb2-c3e0-4e58-a5a6-b3c41212dd05',
clientToken: 'pubb7e17154a9ac48f85b92ad67e1de451a',
// site refers to the Datadog site parameter of your organization
// see https://docs.datadoghq.com/getting_started/site/
site: 'datadoghq.com',
service: 'easycla-corporate-console',
env: '<ENV_NAME>',
// Specify a version number to identify the deployed version of your application in Datadog
// version: '1.0.0',
sessionSampleRate: 100,
sessionReplaySampleRate: 20,
trackUserInteractions: true,
trackResources: true,
trackLongTasks: true,
defaultPrivacyLevel: 'mask-user-input',
});

Tested dataDog traces & session on the dev site & found that it properly appears
Refer to the screenshot


Update using-the-debuggerdisplay-attribute.md

F# is added to the list of languages.

@FoggyFinder : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

#sign-off Looks good, thanks!


Upgraded python-velbus package, this fixes a lot of problems with the…

… velbus component
Description:
This just upgrades to the latest velbus package to fix a lot of bugs
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

Update requirements in manifest.json and then, per the instruction in the PR that you checked that you did, run script/gen_requirements_all.py

Fixed, i did run the requirements script but weeks ago, before th requirements thing changed, that's why i missed this.

Thanks!


ADD: Resize Images and accept filename / base64 strings

Resolves #12

The resizing op is my only concern here -- everything else looks good.

@madisonmay Is this still waiting on something?

@anneCarlson this needs to go in before the other one

Alright! Looking at it now!

Alright, I'm a little confused by format images (R might just be way more type flexible than I realize) and have a question there, but otherwise it looks good to me.

thanks for that check @anneCarlson  :+1: it was a good catch

Yay! Merge at will!


How do I add custom x-properties

I am using the actix example essentially.
We have custom requirements at our company to add several extra fields, usually for certain blocks. like the server block, or extra x-properties in the info block.
#[utoipa::path(
    get,
    path = "/echo",
    responses(
        (status = 200, description = "echos back all headers and request body in response"),
    ),
)]
#[get("/echo")]

    #[derive(OpenApi)]
    // ?insert more props on openapi?
    #[openapi(paths(echo))]
    struct ApiDoc;

    let mut openapi = ApiDoc::openapi();
    // ? insert more props on openapi?
    let mut file = std::fs::File::create("openapi.json")?;
    file.write_all(openapi.to_pretty_json().unwrap().as_bytes())?;

I would much rather build this file at compile time as well, but I can manage that on my end if there are no exposed means from this project.
Great freaking project btw, this all worked perfectly out of the box very quick to set up.

In short, at the moment x-properties are not supported and there is no build in way to insert extension properties to the schema.
Perhaps this is something that could be explored in future, and of course PR:s are welcome. :slightly_smiling_face:

@coffeebe4code You can build the server object using the modify trait.

https://github.com/juhaku/utoipa/pull/763
Are these the same x-properties? My PR is for openapi extensions

@lucasgranberg Yes,
@coffeebe4code Info block supports extensions now, but Server does not have support for those as of yet. Though adding that supports is quite quick
.

https://github.com/juhaku/utoipa/commit/b62efb45c7d75f539024306128d073e1e1cd7286
Pretty much this but my fork is too messed up to merge, better to do separately

Right,
It's worth to check https://spec.openapis.org/oas/latest.html which objects supports extensions and add on the same go the support for them if applicable. (I believe that not all objects can support in utoipa those extensions as of current state types.)

This PR adds the extensions to types currently missing the field #1104.


Correct DiskStore into DiskStorage

Example codes written in README.md and src/caskdb/disk_store.py initialize storage with DiskStore. However, this is not working because we need to initialize storage with DiskStorage instead of DiskStore.
Therefore, I corrected DiskStore into DiskStorage.
If the usage of DiskStore is intended or my PR is wrong, please close it.

Thank you for the PR and correcting it. DiskStorage sounds right.


Auto select lockfile and tweak installation instructions

A small PR that adds a script to select the correct lock file according to the host R version. Taken from run-sch/setup_r_env.R.
This also removes the instruction to install the trachoma model manually, since it is listed in pyproject.toml file using the github URL and will be installed automatically when installing the integration package.

I don't love that we don't use (e.g. test) the setup_r_env.R script, but I can see you were having issues with it. I'm gonna try installing renv manually first, since that is what we instruct the users to do, and hopefully that will work.


Converted CRA to Vite.

Converted to Vite from create react app.
Fixes #167

[x] This change requires a documentation update

Test Configuration:
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

@Arnabdaz, deployment still fails. where to find the deployment failure log?

@Arnabdaz, deployment still fails. where to find the deployment failure log?

i would ask the project owner to give access to vercel to see deploy logs

@Arnabdaz deployment log please ?

@agamjotsingh18 can you send a screenshot of the deploy logs as I am unable to access them ...
also @harshit-002 can you try deploying on your vercel account with the changes and see if it fails or not. if it does not fail send the vite configuration so that can be updated here


Add multiple native build workflows

As written in #90, we can use the qemu-with-docker trick with every platform supported by the OCI specification. I played around with it a bit and this adds all platforms which work out-of-the-box:

386 (aka. i386, x86_32)
amd64
arm (armv7, armhf)
arm64 (armv8, aarch64)
linux-arm-v5 (armel)
s390x

I tried to add mips64le and ppc64le, both those seem to be broken on a very low level (ppc64le runs into qemu problems, mips64le has trouble running ant..)

Great progress!

Instead of keeping this in limbo and trying to get perfect coverage of all OCI architectures, I consider this mergeable for now. The only negative is that because we are building in qemu, the slowest build runs ~10 minutes...

To get this faster, we could move all arm builds to arm64 runners, but GitHub doesn't provide any, so someone would probably need to sponsor arm64 runners...

I am not particularly concerned about the length of the jobs. If it becomes really onerous to run all the platforms then we can limit it to release time (to get updated binaries) or just run them periodically. I would not be surprised if GitHub starts offering free aarch64 instances in the near future, as well.
Let's merge it and consider next steps from there!

@TobiX I have pushed #101 where I am attempting to add macOS and Windows and add some caching to the native builds.


STYLE: Rename ITK macro EXPECT_VECTOR_NEAR to ITK_EXPECT_VECTOR_NEAR

Renamed the unit test macro EXPECT_VECTOR_NEAR to ITK_EXPECT_VECTOR_NEAR,
to explicitly indicate that it is an ITK specific extension to GTest.

Does the new name help differentiate from other functions that have a similar name (e.g. Google test macros or functions?)

Does the new name help differentiate from other functions that have a similar name (e.g. Google test macros or functions?)

That's an extension to the philosophical question of @dzenanz   :-)
I thought it was a coding convention of ITK to always use "ITK" or "itk" as prefix for macro names. And I like this convention, as it helps me to find the origin of a macro, when I encounter the macro being used in source code. In general, this convention also prevents naming conflicts with external libraries. What do you think?

Avoiding collisions with other libraries might be the most significant. People really like calling their class vector, so we need prefixes like std, itk and Eigen. As macros don't have namespaces, using prefixes is the norm.

Avoiding collisions with other libraries might be the most significant. People really like calling their class vector, so we need prefixes like std, itk and Eigen. As macros don't have namespaces, using prefixes is the norm.

The macro implementation is generic, it only requires itk::NumericTraits<T1>::GetLength and operator[] so it already works with std::vector and combination with itk Array/vector like objects.

In general we should have an ITK prefix for macros so we know where they come from and avoid conflicts. However, this should be the case with all the testing macros:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/TestKernel/include/itkTestingMacros.h


[identity] Various documentation improvements

Packages impacted by this PR
@azure/identity
Issues associated with this PR

Resolves #25740
Resolves #30383

Describe the problem that is addressed by this PR
This PR adds various documentation updates ported over from other languages,
improving verbiage around authenticate usage and the azure authority host.

API change check
API changes are not detected in this pull request.


Offseting with this library ?

Hello!
I was wondering if it would be possible to implement polygon offseting using this library ? Would it work to offset the polygons the naive way, and then union them with an empty polygon to resolve self-intersections ?
This library looks promising and if it had offseting capabilities I would definitely use it for my projects !!

Hi!
Yes, it will work. It can be done simpler, no need to union and second polygon.
Just look at how simlify works.
You only need to think which FillRule to apply - positive or negative - depending on the order of your polygon points.
I am planning to add this feature. I am very busy right now. I will be able to do it in 2-3 months


Scheduled requests

Big maybe, this starts to enter into apex(1) / Serverless territory, not sure I really want to go there, but it would be nice to not use verbose Terraform stuff just to set up scheduled tasks.

Pro feature imo, if it lands.

Think I'll close this one for now, feature-creeping into evented stuff.

Is this possible with CloudWatch > Rules > Targets > Lambda > Input > "Constant (JSON text)" ? Where the JSON text is something like {"method":"GET","path":"/foo/bar"}?

@jpillora yep! I forget what the properties are off-hand but something like that should be fine

Its actually possible to "secure" the schedule request by hijacking the requestId field of requestContext.
ie if you put the following as your JSON text in your cloud watch rule
{"requestContext":{"requestId":"cron","stage":"staging"},"httpMethod":"POST","path":"/api/cron","body":"{}"}

in your code you can then do something like this:
if (request.headers["x-request-id"] !== "cron") return { status: 403 }

Since x-request-id is always overridden by UP from requestContext a malicious request cant send this as a header. Meaning that you can verify that requests legitimately from cloudwatch schedule.
@tj can you see any issues with this approach? 😅

@cloudkite ahaha interesting yeah that sounds like it'd work! Since we'd have the target path with config—something like below—we'd potentially be able to blacklist it for the user too, but that means that path wouldn't be available externally in any case, but it removes the need to check for == "cron" manually
{
  "cron": [
    {
      "path": "/whatever/here",
      "interval": "30m"
    }
  ]
}

I still question if it's even worth adding for HTTP hahah when regular Lambda + Scheduled events is already great for this. I think the better approach might be to do an Apex 2.0 which has this stuff built in for FaaS

@tj yeah totally agree regular lambda and scheduled events are probably a better fit. I just didn’t want to have to have an additional project to deploy. I’ve got this setup as above and seems to work well. More than fine with it being a manual thing and not built in to UP


Modify default UI components and add TUL logos , fonts to header, footer and homepage

Components to start with:
@HuynhKhoa1601 Use logos, fonts stored on MS Teams storage (check MS Teams/TUL >>> Files)

@milanmajchrak Milan, add list of components that Lock should start with

thanks, I'll do it today

@HuynhKhoa1601
Useful links:

TUL (University of Liberec) actual running DSpace 6.3.: https://dspace.tul.cz/

TUL home page: https://www.tul.cz/en/home-page/

Vanilla UI demo: https://demo7.dspace.org/home

Vanilla BE demo: https://api7.dspace.org/server/#/server/api

Examples of customized Vanilla DSpace: https://registry.lyrasis.org/?gv_search=7.x&filter_10=DSpace&filter_4_6&filter_3&filter_20&filter_28&mode=all


[PromptLab] Version 1.1.0

Description
This update to PromptLab introduces many new features while preserving compatibility with previously created commands. The changes include:

New "PromptLab Menu Item" command for easy access to commands.
New "Manage Models" command to configure models, choose favorites, and set the default.
Added support for multiple chats, switching between chats, configuring chat-specific settings, and viewing chat statistics.
Added custom configuration fields for commands which are filled in by users once the command is downloaded from the store.
Added video feature extraction for selected video files.
Added many new placeholders, support for custom placeholders, flow control directives, and persistent variable directives.
Added placeholder hints in form inputs.
Added placeholders guide, accessible via an action.
Added support for configuring advanced settings by modifying a JSON file in the support directory.
New commands settings for which model to use, whether to accept voice input, whether to speak the output, and whether to display the command in the menu bar.
Restructured much of the code to support the above features and simplify future development.

A more detailed changelog can be read here: https://github.com/SKaplanOfficial/Raycast-PromptLab/blob/promptlab-1.1.0/DEVLOG.md
Screencast
YouTube Video
Images
Manage Models
PromptLab Menu Item
Chat Settings
Command Configuration Fields
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks, no problem! I'll try to keep future PRs a bit smaller 🙂


Problem with  and IGNORE_EOF

I've been facing a problem with IGNORE_EOF recently and I found it was caused by zsh-autosuggestions. I've been getting this on <Control-D>:
<Control-D>
zsh: do you wish to see all 3221 possibilities (3221 lines)?

Instead of the usual:
<Control-D>
zsh: use 'logout' to logout.

This is the minimal configuration in .zshrc to reproduce the issue:
source "$DOT/zsh/.antigen/antigen.zsh"
antigen bundle zsh-users/zsh-autosuggestions
antigen apply
setopt ignore_eof

I managed to walk around the issue binding ^D to beep, but it seems like a bug to me.

Looks like this has something to do with creating a widget that overrides the delete-char-or-list builtin widget:
% zsh -f
%% setopt ignore_eof
%% <Control-D>
zsh: use 'exit' to exit.
%% delete-char-or-list() { zle .delete-char-or-list }
%% zle -N delete-char-or-list
%% <Control-D>
zsh: do you wish to see all 1782 possibilities (594 lines)?

Relevant line in zsh source: https://github.com/zsh-users/zsh/blob/2b7035d974a69d9a47b1f89f868787a4585386a1/Src/Zle/zle_main.c#L1385

I am facing the same Issue, any updates?

For both I keep getting following output: zsh: do you wish to see all 2319 possibilities (773 lines)?

This is still an issue for me on an M1 mac 5 years later.

Same for me; somehow this started happening about a week or two ago (I updated to Ventura, but I'm not sure it coincides with that) and I have no idea what to do.

I'm getting this recently on Manjaro and Ubuntu. Seems to only affect systems accessed via ssh.


Plexrequest using wrong image

Describe the bug
When I try and deploy Plexrequest it shows 'Failure No such image : linuxserver/plexrequestse:latest'
To Reproduce
Steps to reproduce the behavior:

Launch Plexrequest from Portainer

Expected behavior

Portainer deploys the container properly

Possibly solved
It seems as though the most recent extant release of that system is rogueosb/ombi over at rogueosh's Github now that The LinuxServer.IO image.
I'll change the pointer.


Let TagHandler know when all streams have been processed

There are a few ways to accomplish this:

Create an event ITagsHandler::start_of_file(const int stream_count)
Create an event ITagsHandler::end_of_file()
Both?

In any case, I'd like to avoid introducing any kind of state to ITagsHandler and let StreamTagsHandler deal with state as a part of its implementation.

Option 2 has been ready for a while, it's called end_of_stre

In that case, my proposition would be end_of_file or end_of_streams. Could you change the name?

Done. I added ITagsHandler::start_of_stream too so that the lister is aware of the unknown streams.


Preserve TableScan.projection order in push_down_projection optimizer rule

Which issue does this PR close?

Closes #5146.
Rationale for this change

Fixing push_down_projection behaviour for "TableScan-only" queries -- recreation TableScan.projection changes column order in output plan schema, which is unacceptable for the optimizer.
What changes are included in this PR?

Now push down projection preserves original order of projection indices, filtering out not required fields.
Are these changes tested?

Added tests for optimizing scan with randomly ordered projection and optimizing projection over it.
Also added test for randomly ordered projection in CsvExec, as, at first, this issue looked suspiciously similar to #4832 (not that case -- CsvExec was working in 16-17 versions)
Are there any user-facing changes?

I will wait for @jackwener 's review to merge


Darkmode Toggle added

Description

Added a Darkmode and ;light modde toggle which switch the navbar and some texts in dark and light mode by clicking on toggle
Related Issues

Closes #308

Type of PR

[ ✔]  ( Feature Request )

Screenshots / videos (if applicable)

before:

after:

Checklist

[X ] I have gone through the contributing guide
[ X] I have updated my branch and synced it with project main branch before making this PR
[ X] I have performed a self-review of my code
[ X] I have tested the changes thoroughly before submitting this pull request.
[ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ X] I have commented my code, particularly in hard-to-understand areas.

Additional context:

@harshgupta2125 y did u change the button theme it is not looking good i am loosing the PR


Redirect after authentication doesn't always work correctly

[X] I've read the guidelines for Contributing to YOURLS Projects
[X] This request isn't a duplicate of an existing issue
[X] I've read the docs and followed them (if applicable)
[X] This is not a personal support request that should be posted on the YOURLS Discourse community

Describe the bug
When running yourls in a Docker container, the redirect that takes place after authentication doesn't always work. Sometimes (and I haven't been able to pin this down precisely), the redirect is to http://localhost/admin instead of the correct site URL.
As far as I can tell, this is the only place where the yourls code references $_SERVER[SERVER_NAME] rather than YOURLS_SITE. Making that code change fixes the problem.
To Reproduce

Configure docker-yourls to run with YOURLS_SITE set to "http://wibble:8002" and port mapping of 8002:80.

Configure Apache to listen on port 8000 and reverse-proxy to http://localhost:8002. This is deliberate because:
a) we need Apache to be proxying here and
b) we need Apache to listen on a non-standard port to cause the reply redirection to show as incorrect.

Navigate to http://localhost:8000/admin/. Enter valid credentials.

Expected behavior
What should happen is that yourls should return a redirection header of http://wibble:8002/admin/.
Actual behavior
The redirection header is to http://localhost/admin/ instead. Note that there is no port number.
Versions
1.7.6 running inside the yourls Docker container. No extensions or plugins.

Thanks for this report @pcolmer.
Very nice description, appreciated.

where the yourls code references $_SERVER[SERVER_NAME] rather than YOURLS_SITE.

Indeed, but current situation solves many issues regarding domain management.
It's not ideal at all, but by using $_SERVER[SERVER_NAME] YOURLS is able to switch between different domain smothly.
@ozh Thoughts?

There is an alternative approach at https://github.com/YOURLS/YOURLS/pull/2545 but, for some reason, testing resulted in the browser loading a blank page until I re-requested the admin page. Reverting the change back to the one I'm suggesting didn't have that problem.
I can provide more insight/clarity around why using YOURLS_SITE can work if you want me to expand on that.

It seems anyway that using SERVER_NAME can cause some inconsistencies, judging by issues opened. I'm not sure why we're not simply using YOURLS_SITE instead of this complex $_SERVER['SERVER_NAME'] juggling that #2545 proposes
The only place it is used seems to be in functions-auth.php (if search is accurate here on Github)
The reason it is used here is to trigger a redirection to requested page
Maybe we're overthinking this and there is a simpler way to redirect to current page ?

In what case simply using the server part of YOURLS_SITE + $_SERVER['REQUEST_URI'] would not work?
YOURLS_SITE : http://sho.rt/ or https://sho.rt:1337/yourls/
REQUEST_URI : omg, admin/something.php, yourls/admin/ or yourls/omg
Must think about non basic standard cases (IIS, nging, docker, virtual hosting with multiple hosts on same server....)

@pcolmer could you test this please :
functions-auth.php, line 93, simply :
yourls_redirect( yourls_sanitize_url_safe($_SERVER['REQUEST_URI']) );
Not sure why we hardcode the server root after all...

@pcolmer could you test with code in https://github.com/YOURLS/YOURLS/pull/2625 ?

Hi
The redirection after authentication works. Thank you.


HSTS security advice dangerously incorrect

The section on HSTS contains dangerously wrong advice and shows a fundamental serious lack of understanding of how protocol downgrade attacks work and how HSTS prevents them.
In a protocol downgrade attack, the HTTP listener is the man-in-the-middle's HTTP listener, not an HTTP listener on the ADFS server. Thus, the absence of an HTTP listener on the ADFS server does NOT in any way provide the sort of mitigation that HSTS does and this document is dangerously incorrect in stating otherwise.
The whole point of HSTS is to prevent the client from connecting to a MITM's HTTP listener. The lack of an HTTP listener on the ADFS server does NOT accomplish that because there could still easily be a MITM between the client and the ADFS server, regardless of what protocols the ADFS server listens for.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7958465-7224-0c4b-8771-eba606511922
Version Independent ID: ff44e422-e4b1-134a-47bd-88d9abc843e3
Content: AD FS FAQ
Content Source: WindowsServerDocs/identity/ad-fs/overview/AD-FS-FAQ.md
Product: windows-server
Technology: identity-adfs
GitHub Login: @billmath
Microsoft Alias: billmath

#assign:IngridAtMicrosoft
gh issue comment 3978 -b #assign:IngridAtMicrosoft

#assign:IngridAtMicrosoft

Thank you for submitting this issue.  Unfortunately, due to high volumes I was unable to respond to this in a timely manner.  At this point, I am going to close this due to it's age and the possibility that it may have been addressed.  If this is still a problem, please consider submitting a new issue.  Thank you.
#please-close


Generator doesn't work

The whole generator doesn't work for me somehow - I just wanted to create the uniform, but it still doesn't work :(

Check out this issue and see if it solves your problem. You have to have launched arma 3 tools at least once. https://github.com/bijx/ARMA-3-Camo-Mod-Maker/issues/15

I will give you an update as soon as I am back at my PC ;)


feat: AI planner - text completion

Add AI planner implementation, currently only text completion is available.
Response parser to parse JSON plan and DO/SAY syntax in plain text
Do not use TypedDict in turn state data models so we can have better intellisense
DefaultPromptManager now takes our own PromptTemplate type as input, instead of semantick kernel's PromptTemplate
Update the lint command to only fail when there is fetal and error message. The warnings, refactors, etc. should be acceptable to some extent, for example TODO comments in our current stage.
Merge latest code from PYTHON branch

The code has been tested against the prompt in teams chef bot sample manually.
TODO: Add test cases for the code.

@blackchoey looks great, thanks for working my changes into yours so quickly! Made a slight update to instead of ignoring warnings just exclude some rules that I don't think are super important from the lintrc. In the future I think thats the preferred way to go so don't be afraid to do that in a PR next time if you think a pylint rule is just getting in the way and not adding value.

Thank you. As mentioned previously, I feel the warnings are valuable to see but low priority to fix, especially in the early stage. For example, the TODO comments. We can disable this first, but I think we need to invest more on the engineering system later.


bazel_0_4, envoy: remove

Motivation for this change
This old version of envoy is the only reason we ship bazel_0_4. bazel_0_4 however fails to build since 2018-04-29 (and was marked as broken due to that) - so nobody seems to be using envoy.
It might be the best to just remove that package instead of keeping broken stuff.
Closes #49574.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build bazel


Spinbox display does not round properly when using decimal custom arrow steps

Tested versions

Reproducible in: v4.2.2 stable, v4.3 stable

System information
Godot v4.3.stable - macOS 15.0.0 - GLES3 (Compatibility) - AMD Radeon Pro 5300M OpenGL Engine - Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 Threads)
Issue description
Using a 0 step value and a decimal custom arrow step on a spinbox causes the displayed value in the spinbox to round incorrectly at some numbers, despite the internal value being rounded. I'm fairly sure this was working previously on both 4.2.2 and 4.3, so its possible its due to me upgrading to the newest macOS. Also reproduced with arrow steps like 0.2, 0.9, and 1.1, and in brand-new project.
https://github.com/user-attachments/assets/1f842b7b-b639-4ae3-b640-2ec09e82124a
Steps to reproduce
Create a new spinbox node, set its step value to 0 and its custom arrow step to a decimal value besides 0.5. Interacting with the arrows results in the issue
Minimal reproduction project (MRP)
N/A

There's seems to be some disagreement between what's displayed and what's printed even in other parts of my project, but I haven't picked up on any specific patterns besides the spinbox. Is it possible that there's some general rounding issues around the whole engine in macOS 15.0?

Reproducible on Android

Reproducible in 3.6.stable


The docs at chartjs.org is broken?

Hi!
Using safari the doc section at http://www.chartjs.org is broken. Seems to be working with chrome.
Thanks! Great software!

Can confirm. Broken on Safari 9.0.1

Also seeing intermittent issues accessing chartjs.org and https://www.chartjs.org/assets/Chart.min.js

Possibly related, I'm seeing issues with HTTPS on chartjs.org.
https://www.chartjs.org
https://www.chartjs.org/assets/Chart.min.js
The above used to work properly but no longer do.

Issue is that there are lines with semicolons after the close curly brace...this is not valid CSS.
See:  http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.chartjs.org%2Fdocs%2F&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en
I've just verified with the dev tools that updating only the following 6 lines where the validator above indicates a "};" is present - simply remove the semicolon - will have the site rendering properly in safari again.

298
305
312
319
326
333

I don't find the documentation web site files available in any publicly available repo or I'd have simply submitted a PR!

thanks @photusenigma
@nnnick can you update the css?

Full site is in gh-pages branch, we can fix there first.

Nice, fixed there. Only open item is to deploy the latest version of gh-pages.
Closing as that is discussed at #1658


Fix bug in get_mismatch

Our get_mismatch function dingo.gw.gwutils would permanently whiten the input when an ASD was provided, which would lead to downstream bugs if the waveform data is used for anything else after whitening. I fixed this, and also added support for batched data (frequency axis is as always -1).

We should probably use it here https://github.com/dingo-gw/dingo/blob/2d6cc239ee2b9a2eddac04bf943d236dcf54c67c/dingo/gw/SVD.py#L116.


Possible inconsistency with annotation position

Annotations on match key elements come after the key element, while in all other cases, it seems that the annotations come before the object they annotate (e.g. struct fields).
Is there a reason for this?

Yes, it is due to the bison grammar.
Putting them in front makes the grammar ambiguous, since the annotation has an optional list of expressions, which could be interpreted as the key expression.


Quickest way to make this use Lucee 5.x.x instead?

Hi @joshuairl THe quickest way would be to modify the provisioner that installs Lucee to download a version of Lucee 5 instead.

It is not that simple; the directory structure for Lucee 5 is different than Lucee 4. Also, /opt/lucee/tomcat/lib/lucee-inst.jar referenced in setenv.sh no longer exists. I believe the new file is /opt/lucee/lib/lucee-<IP_ADDRESS>.jar. Even when I made all the changes for the new directory structure and reference version 5, I got the following Tomcat error: java.lang.NoClassDefFoundError: javax/servlet/http/HttpServlet. I tried replacing /opt/lucee/tomcat/lib/servlet-api.jar just in case it somehow got corrupted in the installer, but I still go the same error. Eventually I just gave up.


No precision digit for DHT11

Every time I ask for temperature and humidity, no decimal is returned.
Only exact value. It's correct?
sudo ./AdafruitDHT.py 11 4
Temp=22.0  Humidity=35.0

yes its correct


Confused by new examples in ReadMe

Hi,
I am trying to set this up with babel for a specific npm library. I am confused by the new example in the README and I'm not sure if I'm doing this right?
    [
      "babel-plugin-direct-import",
      {
        "modules": [
          "@appbaseio/reactivesearch"
        ]
      }
  ]

Whereas in the documentation for appbaseio, they have it written like this:
  [
          "direct-import",
          [
            "@appbaseio/reactivesearch",
            {
              "name": "@appbaseio/reactivesearch",
              "indexFile"<EMAIL_ADDRESS>            }
          ]
        ]
    ]

Thanks for clarifying

Hello @jkhaui and thanks for the report. I add the migration guide to make it easier to transfer.
This config should work for you. An index file (@appbaseio/reactivesearch/lib/index.es.js) will be automatically resolved from the package.json.
{
  "plugins": [["direct-import", ["@appbaseio/reactivesearch"]]]
}

@umidbekkarimov Thank you very much for your quick reply. The problem is that this configuration is invalid as babel expects an object, but instead your snippet (as well as the others I've tried) have an array instead.
Any ideas>

@jkhaui oops, copied wrong example, try this one
{
  "plugins": [
    [
      "direct-import",
      {
        "modules": ["@appbaseio/reactivesearch"]
      }
    ]
  ]
}

Great thank you, that seems to work!


'module' object has no attribute 'exceptions'

python.exe autosub_app.py -S en -D en "C:\Users\Jonathan\Downloads\SampleVideos.Spanish.-.English\EnglishObama.mp4"
Converting speech regions to FLAC files: 100% |#################| Time: 0:00:01
Traceback (most recent call last):% |                          | ETA:  --:--:--
File "autosub_app.py", line 283, in
sys.exit(main())
File "autosub_app.py", line 231, in main
for i, transcript in enumerate(pool.imap(recognizer, extracted_regions)):
File "apps\Python27\lib\multiprocessing\pool.py", line 668, in next
raise value
AttributeError: 'module' object has no attribute 'exceptions'
Anyone has the same issue? Losing my hairs on this!

probably something wrong with my Python install. I ran in a clean venv and it works fine. Thanks!


Modifier.disabled() does not work

The problem is with:
fun AttrsScope<*>.disabled(value: Boolean = true) {
    attr("disabled", value.toString())
}

The correct implementation would be:
fun AttrsScope<*>.disabled(value: Boolean = true) {
    if (value) {
        attr("disabled", "")
    }
}

Thanks for the report! Will be fixed in 0.18.1.


inline-asm feature causes compile errors on cortex-m0 (samd21)

Using version 0.6.3 with feature inline-asm enabled causes compile errors:
error: invalid instruction, any one of the following would fix this:
  --> /home/johnny/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-0.6.3/src/asm.rs:39:13
   |
39 |             llvm_asm!("1:
   |             ^
   |
note: instantiated into assembly here
  --> <inline asm>:3:19
   |
3  |                   subs r1, $1
   |                   ^

note: instruction requires: thumb2
  --> /home/johnny/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-0.6.3/src/asm.rs:39:13
   |
39 |             llvm_asm!("1:
   |             ^
   |
note: instantiated into assembly here
  --> <inline asm>:3:19
   |
3  |                   subs r1, $1
   |                   ^

note: invalid operand for instruction
  --> /home/johnny/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-0.6.3/src/asm.rs:39:13
   |
39 |             llvm_asm!("1:
   |             ^
   |
note: instantiated into assembly here
  --> <inline asm>:3:28
   |
3  |                   subs r1, $1
   |                            ^

note: operand must be an immediate in the range [0,255]
  --> /home/johnny/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-0.6.3/src/asm.rs:39:13
   |
39 |             llvm_asm!("1:
   |             ^
   |
note: instantiated into assembly here
  --> <inline asm>:3:28
   |
3  |                   subs r1, $1
   |                            ^

note: operand must be a register in range [r0, r7]
  --> /home/johnny/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-0.6.3/src/asm.rs:39:13
   |
39 |             llvm_asm!("1:
   |             ^
   |
note: instantiated into assembly here
  --> <inline asm>:3:28
   |
3  |                   subs r1, $1
   |                            ^

error: aborting due to previous error

error: could not compile `atsamd-hal`

It looks like this issue was about the cortex-m crate, so I've transferred it here. What Rust version are you using, and what target are you building for (in your .cargo/config.toml file or --target command line argument)?

@adamgreig here's a little more info...

rustc 1.48.0-nightly (8b4085359 2020-09-23)
target: thumbv6m-none-eabi

Regarding the target, specifically I'm doing firmware for a atsamd21g18.

Thanks for the info. I can reproduce the error on today's nightly-2020-09-29 and as far back as nightly-2020-08-28 but it's not present on nightly-2020-08-01, so this looks like a change or regression in nightly sometime in August. As a workaround you should be able to use 2020-08-01 (rustup install nightly-2020-08-01 --profile minimal; rustup target add thumbv6m-none-eabi --toolchain nightly-2020-08-01; cargo +nightly-2020-08-01 build).
@jonas-schievink, any ideas?

Seems like a rustc regression, yeah. If you can bisect to a nightly we should be able to nail down the PR that caused it (was the LLVM upgrade in that range?).
That said, this doesn't seem like something that will be fixed, since asm! is now a thing.

Ok, the last nightly that worked is nightly-2020-08-23 (rustc 1.47.0-nightly (663d2f5cd 2020-08-22)) and the first nightly that fails is nightly-2020-08-24 (rustc 1.47.0-nightly (5180f3da5 2020-08-23)).

Commits in that range: https://github.com/rust-lang/rust/compare/663d2f5cd...5180f3da5
Looks like the LLVM 10 upgrade is indeed what caused this

It doesn't look like a rustc bug to me. One should be careful writing inlined asm code as it could be inlined into a code with different thumbness. You can't use some instructions both in ARM and Thumb mode when they do not exist in both modes.
I see two possible solutions:

do not inline this delay code at all
write code universal enough to support both modes

But this is a thumbv6m-none-eabi target; it only runs thumb code and doesn't support ARM mode, so why would that be the issue here?

Hmm, you're right. Disregard my note then.

This should be fixed in cortex-m 0.7

And also on 0.6.4, not sure why this wasn't close automatically. Anyways, thanks for the report.


Running phpunit with WordPress (and testing a plugin)

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
I wanted to know if there is a way to setup or guide on how to setup a WordPress plugin to use the phpunit with DDEV ?
So far my reasearch and tests have not been successfull.
Thank you for your help,
Expected Behavior
I want to use the wp cli scaffold command with the use of their script to install and use phpunit.
But it does not work.
Actual Behavior
I want to setup a WordPress plugin to include phpunit tests.
Steps To Reproduce
No response
Anything else?
I wanted to know if there is a way to setup or guide on how to setup a WordPress plugin to use the phpunit with DDEV ?
So far my reasearch and tests have not been successfull.
Thank you for your help,

Do you already have the phpunit tests in there? Have you composer-installed phpunit?

You need phpunit in your code's vendor directory. Install it with composer.  Having it on your computer is not relevant. The code in the container cannot access anything on your computer.
Please use ddev ssh to start learning about this. When you can use phpunit in there, then you are ready to start.

phpunit when installed is usually in vendor/bin/phpunit, for example. see https://github.com/weitzman/ddev-selenium-standalone-chrome and its readme.

@mandrasch can you offer any help here? (@mandrasch is an expert with WP and DDEV)

@rfay I forgot to mentionned it, I also did try it in ssh in the container.
Here is the error when I then start my unit tests.
mac-dw-eti@rabaischocs-web:/var/www/html/wp-content/plugins/rc-reports$ ./vendor/bin/phpunit
Could not find /tmp/wordpress-tests-lib/includes/functions.php, have you run bin/install-wp-tests.sh ?
I did follow the setup instruction : https://pippinsplugins.com/unit-tests-wordpress-plugins-setting-up-testing-suite/.  you set up wordpress with phpunit, with the wp cli it uses a bash script. After the script has been run. And then try to do any unit test I get the error mentionned.
From our understanding the error would be in the bash script. The script seems to not know it's in a container.

@rfay By the way, I really like working with ddev.

It seems to install something in /tmp/wordpress-tests-lib, and /tmp is a volatile directory in ddev (it gets recreated on every start)

Yes I did run bin/install-wp-tests.sh command.

No response after quite some time, I'll convert this to a discussion.


shift other ranks

When jumping more than one place, shift every one you passed.
Assigned ranks out of range should normalize

need to shift everything if an item is removed


Improve JMS Server Connector documentation

Few suggestions I see on - http://ballerinalang.org/docs/user-guide/0.8/server-connectors/jms-server/

Need to include the documentation for ActiveMQ as well. Currently the doc has WSO2 MB only.
How to run from anywhere for the MB related jms sample and add documentation on how jndi.properties file is configured using the annotation. (is it relative path?)

Created https://github.com/ballerinalang/connector-jms/issues/13 to track this


Example 3: Classification with MLP:, more options = option criterion() not allowed

Load data
webuse iris, clear
Generate a training flag, marking approx 30% of dataset as training
gen training = runiform()<0.3
Run model with one hidden layer, mess with options
pymlp iris seplen sepwid petlen petwid if training==1, type(classify) criterion(entropy) alpha(0.0005) hidden_layer_sizes(5)
option criterion() not allowed
r(198);

Hey - thanks for pointing this out! You found a (significant) typo in the example provided with the internal documentation - the criterion() option really isn't allowed for pymlp, and the example is wrong! I've fixed this in the version I'll push today.

(I happen to be flying right now and JetBlue's in-flight wifi doesn't let me push to GitHub using GitHub Desktop - I'll just push the latest version later today @LPecht)

sounds greats, I have found a second bug. Maybe you can fixed them both before commit. thks.


Processing assert in ProviderContainer.readProviderElement takes a lot of time

Describe the bug
There was no problem with riverpod 1.0.0-dev.11.
After upgrading to riverpod 1.0.0, ProviderContainer.readProviderElement is taking a lot of time in debug mode.
When I checked the time it took, it seems that the assert in ProviderContainer.readProviderElement is taking a long time.
Expected behavior
I want ProviderContainer.readProviderElement to be faster

Which assert is taking a lot of time, and in which condition? And how much time are we talking about?

The following code takes a lot of time.
If I comment it out, it will improve.
It took more than 1 second to update the frame.
    assert(() {
      // Check that this containers doesn't have access to an overridden
      // dependency of the targetted provider

      final targetElement = reader.getElement();
      final visitedDependencies = <ProviderBase>{};
      final queue = Queue<ProviderBase>();
      targetElement.visitAncestors((e) => queue.add(e.origin));

      while (queue.isNotEmpty) {
        final dependency = queue.removeFirst();
        if (visitedDependencies.add(dependency)) {
          final dependencyElement = readProviderElement<Object?>(dependency);

          assert(
              dependencyElement ==
                  targetElement.container
                      .readProviderElement<Object?>(dependency),
              '''
Tried to read $provider from a place where one of its dependencies were overridden but the provider is not.

To fix this error, you can add add "dependencies" to $provider such that we have:

final a = Provider(...);
final b = Provider((ref) => ref.watch(a), dependencies: [a]);
''');

          dependencyElement.visitAncestors((e) => queue.add(e.origin));
        }
      }

      return true;
    }(), '');

But in which condition?

I will investigate the conditions from now on.
I will post as soon as it becomes clear.

Since readProviderElement is called in assert, the same Provider is checked more than once.
The longer the dependency tree, the worse it gets.
final provider1 = Provider<int>((ref) => 0, name: '1');
final provider2 = Provider<int>((ref) => ref.watch(provider1), name: '2');
final provider3 = Provider<int>((ref) => ref.watch(provider2), name: '3');
final provider4 = Provider<int>((ref) => ref.watch(provider3), name: '4');
final provider5 = Provider<int>((ref) => ref.watch(provider4), name: '5');
final container = ProviderContainer();
container.read(provider5);


SINTER support?

Does ioredis support the SINTER command?
I tried
Redis.sinter(key1,key2).then(....
and it returns [].
In redis-cli, doing sinter key1 key2 returns a value to me. Does the client support this command? I can't find any documentation of this command in this github or on the web in general that relate specifically to ioredis. Maybe there's a syntax or command issue I'm missing?

Hi @zbmowrey, the usage above of sinter is correct. Could you confirm you connected to the same Redis instance as redis-cli? Try to run monitor command in the redis-cli and run the code again to see whether the command and arguments sent to Redis are correct.

Closing issue - I was trying to access the Promise object rather than the value. Thanks for the response, the tip to check 'monitor' is something I won't soon forget! :)


really need this future

It has been some time since one of my friends requested that card combos should be purchased every day according to the ratio of their income to their cost, and this is really needed, and maybe the amount of their income is sometimes not high, but we will receive a good profit, which is before buying cards.  Profit should take priority with the combo so that all the money is not spent and he can buy Haru cards, also considering that this robot has this capability in it, you can get help from it (written with a translator)❤
https://github.com/shamhi/HamsterKombatBot

Duplicate of https://github.com/masterking32/MasterHamsterKombatBot/issues/69, please post there about this issue.

Duplicate of #69, please post there about this issue.

I explained differently