handle failing trials

When a trial fails unexpectedly and we don't necessarily know the configuration is bad, allow the training function to return an empty dict when not using ray to inform the tuner about the error.
When using ray, the training function can raise an error (@Yard1 could you please confirm that).
#504

If an exception is raised in the trainable, the trial will be marked as errored by Ray. Returning an empty dict will also raise an error due to inconsistent keys being reported, but that can be suppressed with an env var.


Powershell Script Errors..

I'm sure I am doing something stupid but I am running the .ps1 file locally and get these errors:
Please enter site template XML schema file path: C:\Users\xxxxxx\microsoft-teams-emergency-operations-center-main\Deployment\provisioning\EOC-SiteTemplate.xml
Please enter your tenant name: (contoso): xxxxxxxx
Please enter your tenant admin email<EMAIL_ADDRESS>PnP.PowerShell module found
Checking if site already exists at /sites/TEOCSite
Site doesn't exist, creating new site at /sites/TEOCSite
New-PnPSite : {"SiteId":"","SiteStatus":3,"SiteUrl":""}
At C:\Users\xxxxxxxxxxxxxxxx\microsoft-teams-emergency-operations-center-main\Deployment\provisioning\EOC-Provision
.ps1:49 char:1
+ New-PnPSite -Type TeamSiteWithoutMicrosoft365Group -Title TEOC -Url $ ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (:) [New-PnPSite], Exception
    + FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.NewSite
Creating lists in the EOC site
Invoke-PnPSiteTemplate : The remote server returned an error: (404) Not Found.
At C:\Users\xxxxxxxxxxxxxxx\microsoft-teams-emergency-operations-center-main\Deployment\provisioning\EOC-Provision
.ps1:55 char:1
+ Invoke-PnPSiteTemplate -Path $FilePath
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (:) [Invoke-PnPSiteTemplate], WebException
    + FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.Provisioning.Site.InvokeSiteTemplate
EOC App Provision complete.

Just to be sure, I deleted the Sharepoint site and tried again and got the same error.

HI @thatguy9129,
Thanks for reaching out to us. Can you please delete the site collection from both "Active Sites" and "Deleted Sites" in share point admin center and try again.
Thanks.


RTX TUYA WIFI RS2 RTX WRS2 CBU

Hello, a device slightly similiar to one submitted before by myself, but a different label.
RTX_WRS2_CBU.zip

I don't know if the flash content is the same, please check and add for further users. Thanks!

Added as RTX QS-WIFI-S04-2C WRS2 2 Channel Switch.  This is actually an exact match of Tuya Generic MOD003 2-Channel Smart Relay, but I added the profile under RTX to make it easier to find since we have a fully verified dump.


Build a Chinese documentation?

I would like to help this project by translating the English documentation into a Chinese documentation with the exactly same open source license as the English documentation. Is this necessary? If so, where should the Chinese documentation be placed in a new folder? Which branch should be used as the base for the new branch?

That would be great. The docs aren't currently set up with translations, but they're built with Sphinx and Readthedocs, so it looks like the file structure for new translations can be generated and managed using sphinx-intl.
One consideration is the schemdraw docs have a lot of images auto-generated by jupyter-sphinx - is there text embedded in those images that should be translated, and if so, how does sphinx-intl handle that?
Feel free to fork the repository and try it out there - I may read up on it a bit and think about how to organize it in the main branch.


Blocking RU from accessing site

так всегда с тиранами

why

Hey @GantMan
I'm not sure this will fix anything if "a few Russian IP addresses" abused the hosted demo. I mean couldn't they just use a proxy to bypass this? Having Cloudflare in front of the demo could prevent such attacks better IMO. At the end of the day, it's up to you guys to decide but I think this will only make it look like geopolitics in open-source. :wink:


Fallback to build takes long time - with no progress indicator

Hi,
In my case (Ubuntu 17.04, node 8), during install, it could not find precompiled libraries and fell back to building it.  However, the build takes a long time with no progress indicators.  I was not aware of this, and hit ctrl-C.  Then when running a test sql node program, the import worked ok, but did a core dump.
Perhaps some progress indicator while doing the build can be useful.

You're probably thinking of the mapbox sqlite project, which this project wraps.
https://github.com/mapbox/node-sqlite3

It could also be that we need to update the dep on node-sqlite3 to the latest - feel free to open a PR for it

Hi,
Yes.  Thats correct.  The install takes a long time because of building the node-sqlite3 project.  Don't binaries exist for these?  Today, I installed on a Ubuntu and then on a Raspberry.  Both installs were quite tedious.  Dont know enuf to say whether the update to the latest node-sqlite3 will help.
If I can help in any way, please let me know.

Hrm, I just checked the version we use on sqlite3, and it's currently the latest.
If you tried installing it standalone, do you still get the issues?
npm install sqlite3


Best contigs should be labeled as BEST in the assembly job

As I could not see the IDBA assembly, I thought that the contigs.fa on the assembly job report might be that.  Its not...its the best assembly.  I think the word "best" should be associated with it to avoid confusion...also to avoid users downloading the same contigs twice in their confusion.

We will address this in the new assembler system. Make it unambiguous which contigs are to be used.

Solve with next assembler system soon.


Add HW2

Few things to add:

Due date
AWS information

More notes on things to add to this:

Tell everyone to work together and talk about the design of the locking algorithms.
Remove at least one of the parts.

Hints: For part 1, you'll want to use head/tail pointers and you might not want to use a deque to store the data.


Revert "Add the Network option"

Reverts docker/docker.github.io#9762

Deploy preview for docsdocker ready!
Built with commit 0a3a1b12b65187b3d8b27f71222ab5f4eb31c65a
https://deploy-preview-9776--docsdocker.netlify.com


Add Dato to Menu Bar Tools section

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
Describe each of your changes here to communicate to the maintainers why we should accept this pull request.

If you're adding something to the list, be sure to explain why it should be added.

Dato replaces the system menu bar clock with something much more useful. It gives you a calendar, calendar events, and time zones. It's a popular app that people seem to love.
It currently has 5/5 stars in the US App Store: https://apps.apple.com/us/app/dato/id1470584107?mt=12
Disclaimer: I'm the author.
PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[x] I have added necessary documentation (if appropriate)

Thanks @sindresorhus


Notifications going to all apps

Need control for the live app. Corporate level access for notification to the live app.

Version and app-specific control of notification. Live notification to be authorised.

if this is fixed, please close


Minified code has other behaviour than normal code

Hi, I've got this code:
class Adapter extends Array {
    constructor() {
        super();
        console.log('Hello');
        console.log('World');
    }
}
new Adapter()

which is transpiled using this config:
{
  "presets": [
    "es2015",
    "babili",
  ]
}

Without babili it runs just fine, but with it activated, I get following output:
World
Hello
World

The minified code look as follows:
'use strict';function _classCallCheck(instance,Constructor){if(!(instance instanceof Constructor))throw new TypeError('Cannot call a class as a function')}function _possibleConstructorReturn(self,call){if(!self)throw new ReferenceError('this hasn\'t been initialised - super() hasn\'t been called');return call&&('object'==typeof call||'function'==typeof call)?call:self}function _inherits(subClass,superClass){if('function'!=typeof superClass&&null!==superClass)throw new TypeError('Super expression must either be null or a function, not '+typeof superClass);subClass.prototype=Object.create(superClass&&superClass.prototype,{constructor:{value:subClass,enumerable:!1,writable:!0,configurable:!0}}),superClass&&(Object.setPrototypeOf?Object.setPrototypeOf(subClass,superClass):subClass.__proto__=superClass)}var Adapter=function(_Array){function Adapter(){_classCallCheck(this,Adapter);var _this=_possibleConstructorReturn(this,(Adapter.__proto__||Object.getPrototypeOf(Adapter)).call(this));return console.log('World'),console.log('Hello'),console.log('World'),_this}return _inherits(Adapter,_Array),Adapter}(Array);new Adapter;

The bug is in the simplify plugin.
I noticed that this doesn't happen when you don't use es2015 preset, and also when used with passPerPreset: true ...
{
  "presets": [ "es2015", "babili" ],
  "passPerPreset": true
}

passperpreset is enabled by default .And also, even if I disable that option from babili, it still isn't a problem.


Refactored robot getattr to resist infinite recursion.

This replaces the previous getattr logic with an initial check that determines if the current reference is its own canonical instance.
If this is the case, it short circuits lookups for meta-fields like 'actions', preventing them from making additional queries to the canonical instance (which, in this case, would just be a recursion into the same method anyway).
This seems to address https://github.com/personalrobotics/prpy/issues/262.

Seems good. Thanks @psigen! This resolves #262


The x-axis tick marks are overlapping

The x-axis tick marks are overlapping => hard to find desired epoch

Related issue: #180.

Should be fixed.

Is that okay?

For this case it looks fine. Does this still work for fewer epochs (i.e., that the gaps are not so large)?

How are the breaks computed?

Done with PR #205.


Create Bibliography Entries from LHOM

@vanessa612 Please use this spreadsheet https://docs.google.com/spreadsheets/d/1d7Rlnsteja2sd4911DOAyCrRZWmeZG27NtBDwgH8e0U/edit#gid=0 to find items and add them to our Zotero library.
One (or sometimes more) persons or places treated by the item should be added as Zotero tags in the format
Person: Short Name {URI}
and
Place: Name {URI}
Please also add the tag Source: LHOM to all of them.
For example, the first row "Abattouy, Greek mechanics in Arabic context" takes you to this Worldcat item you can save in Zotero. Then the tag Person: Thābit ibn Qurrah {https://usaybia.net/person/2196} should be added. (It looks like we don't have a URI for al-Isfizari so you can skip that.)
Please refer to our Zotero guidelines for adding items. You can ask questions in this issue.
When you find multiple matching items, use the one that seems to have the most accurate details. If the book is originally Arabic, we should import the Arabic script title/info when it is available.
Thanks!

Forgot to mention: You can find the URIs simply by searching the Usaybia.net website

@FlavioZeska How's it going with the bibliography?

@FlavioZeska How's it going with the bibliography?

@nathangibson Generally speaking it takes longer than expected, but I want it to be done properly. I´ll be glad , if you check a few entries in Zotero as samples.
I have encountered some difficulties with #315 (Worldcat is just offering me scattered pieces of an article) #316 (is a revised reprint of the original PhD thesis; should I leave it as a PhD entry nevertheless?) and #318 (I am not sure how to enter this database into Zotero) and #322 (I have entered it manually as an article, although it only exists as the whole book in Worldcat). Until when do you expect the LHOM task to be finished? Thank you

@nathangibson Generally speaking it takes longer than expected, but I want it to be done properly. I´ll be glad , if you check a few entries in Zotero as samples.
I have encountered some difficulties with #315 (Worldcat is just offering me scattered pieces of an article) #316 (is a revised reprint of the original PhD thesis; should I leave it as a PhD entry nevertheless?) and #318 (I am not sure how to enter this database into Zotero) and #322 (I have entered it manually as an article, although it only exists as the whole book in Worldcat). Until when do you expect the LHOM task to be finished? Thank you

@FlavioZeska Sure, I'm happy to check some. Since this is a new process for us, I wasn't sure how long to expect it to take. But we can try to figure out ways to make it more efficient. So, to help with that:

What's taking a long time? Is it that the links in the spreadsheet don't help you find the item quickly? Or that it takes a long time to edit in Zotero?
Right now the list is sorted by author but we could try to sort it differently. One way would be to first go through and identify the relevant persons/places in the list with Usaybia URIs, then enter all of the related ones together. Do you think that will help?

@FlavioZeska Sure, I'm happy to check some. Since this is a new process for us, I wasn't sure how long to expect it to take. But we can try to figure out ways to make it more efficient. So, to help with that:

What's taking a long time? Is it that the links in the spreadsheet don't help you find the item quickly? Or that it takes a long time to edit in Zotero?
Right now the list is sorted by author but we could try to sort it differently. One way would be to first go through and identify the relevant persons/places in the list with Usaybia URIs, then enter all of the related ones together. Do you think that will help?

@FlavioZeska I'm checking number 322 as an example, Daiber, ‘Survey of Theophrastean material’ = Hans Daiber, ‘A survey of Theophrastean material indirectly transmitted in Arabic’, in Fortenbaugh, Huby & Long, Theophrastus, 103–114.
(https://www.worldcat.org/title/theophrastus-of-eresus-on-his-life-and-work/oclc/812948485 in WorldCat)

This is actually a chapter in a book, so the "type" should be "Book section" and it should include the place & publisher. You'll get used to seeing the way books look in WorldCat vs. journals (but WorldCat typically has books, not individual journal volumes).
The person tags should be in the format Person: Theophrastus of Eresos {https://usaybia.net/person/2219}

Note the curly braces { }
Also note that the URI is without the /tei portion on the end. (I think you're using the clipboard button in the search results, which gives you tei on the end.) But these tags are easy to change all at once in the left sidebar of Zotero if you expand the tags (sometimes hidden at the bottom), then right-click on a tag and "Rename".

For all the items you add, please also add a tag Entered:  with your screen name so that we can properly credit the entry.

Make sense? Questions?

@FlavioZeska I'm checking number 322 as an example, Daiber, ‘Survey of Theophrastean material’ = Hans Daiber, ‘A survey of Theophrastean material indirectly transmitted in Arabic’, in Fortenbaugh, Huby & Long, Theophrastus, 103–114.
(https://www.worldcat.org/title/theophrastus-of-eresus-on-his-life-and-work/oclc/812948485 in WorldCat)

This is actually a chapter in a book, so the "type" should be "Book section" and it should include the place & publisher. You'll get used to seeing the way books look in WorldCat vs. journals (but WorldCat typically has books, not individual journal volumes).
The person tags should be in the format Person: Theophrastus of Eresos {https://usaybia.net/person/2219}

Note the curly braces { }
Also note that the URI is without the /tei portion on the end. (I think you're using the clipboard button in the search results, which gives you tei on the end.) But these tags are easy to change all at once in the left sidebar of Zotero if you expand the tags (sometimes hidden at the bottom), then right-click on a tag and "Rename".

For all the items you add, please also add a tag Entered:  with your screen name so that we can properly credit the entry.

Make sense? Questions?

@nathangibson Thank you for your review. I have now included your remarks into zotero.
Entering an item is taking me up to seven minutes. - I wasn`t sure if I was too slow. The list itself is at its current state efficiently organized.
The only question remaining so far is concerning the "Usaybia" tag. Which URI should I enter?
Thank you in advance

@nathangibson Thank you for your review. I have now included your remarks into zotero.
Entering an item is taking me up to seven minutes. - I wasn`t sure if I was too slow. The list itself is at its current state efficiently organized.
The only question remaining so far is concerning the "Usaybia" tag. Which URI should I enter?
Thank you in advance

@FlavioZeska It's not surprising that it takes that long, but then I need to think about what we should do. With almost 2,000 items that would take all your time. So maybe we'll need to find a way of selecting only some or converting them automatically ... In the meantime, please keep going and we can discuss at the next meeting.
I assume you are using the Zotero Connector to import the item from Worldcat or other sites (instead of entering it manually)? Which part takes the longest, finding the correct item on the web or correcting/adding information to it once you import it?
What do you mean by the Usaybia tag, where did you see it? If you mean the tag for Ibn Abi Usaybia himself, it's Person: Ibn Abī Uṣaybiʿa {https://usaybia.net/person/926}

@FlavioZeska It's not surprising that it takes that long, but then I need to think about what we should do. With almost 2,000 items that would take all your time. So maybe we'll need to find a way of selecting only some or converting them automatically ... In the meantime, please keep going and we can discuss at the next meeting.
I assume you are using the Zotero Connector to import the item from Worldcat or other sites (instead of entering it manually)? Which part takes the longest, finding the correct item on the web or correcting/adding information to it once you import it?
What do you mean by the Usaybia tag, where did you see it? If you mean the tag for Ibn Abi Usaybia himself, it's Person: Ibn Abī Uṣaybiʿa {https://usaybia.net/person/926}

@nathangibson Thank you for your quick response.
Yes, I am using the Connector tool, but most time is consumed by comparing entries with the corresponding Worldcat items. Sometimes they do not match and therefore I have to undertake a little search on the web, in order to enter for example the full title of a bookchapter etc. Sometimes the corrsponding Google scholar or Google book links are too vague or misleading. Nonetheless it is an interesting - to some extent - fun task, because with almost every entry I get to know a different subcategory of the project.

@nathangibson Thank you for your quick response.
Yes, I am using the Connector tool, but most time is consumed by comparing entries with the corresponding Worldcat items. Sometimes they do not match and therefore I have to undertake a little search on the web, in order to enter for example the full title of a bookchapter etc. Sometimes the corrsponding Google scholar or Google book links are too vague or misleading. Nonetheless it is an interesting - to some extent - fun task, because with almost every entry I get to know a different subcategory of the project.

OK, @FlavioZeska, thanks for the details. Let's try some things to speed this up:

I changed the search formula for the links a bit, since I noticed that has problems when the authors have an & sign, which is pretty common. This should give you more accurate search results for some.
I also added (in columns J+) some columns that split the items into parts. It is irregular, but it makes different parts easy to copy for searching. If you hold down CTRL (or CMD on Mac) and then click on the cells you want to search for (even if they're not right next to each other, you can press CTRL-C to copy them, and CTRL-V in the search on WorldCat or Google Scholar. I usually find that a combination of the author's name, part of the title, and the date is usually enough. (See screenshot.)
For now, please skip Arabic authors or items with transliterated Arabic titles. These are probably time consuming because the transliteration can vary quite a bit. We'll figure out a different strategy for these.
Don't search around a lot. If the information seems inaccurate or incomplete in WorldCat/Google, then you can copy it from the spreadsheet or mark it. Otherwise you can mark it "not found" in column G if you don't find it easily.
When you find examples of things that take a lot of time to find, please put them here so I can figure out how to improve the system.
Thanks!

OK, @FlavioZeska, thanks for the details. Let's try some things to speed this up:

I changed the search formula for the links a bit, since I noticed that has problems when the authors have an & sign, which is pretty common. This should give you more accurate search results for some.
I also added (in columns J+) some columns that split the items into parts. It is irregular, but it makes different parts easy to copy for searching. If you hold down CTRL (or CMD on Mac) and then click on the cells you want to search for (even if they're not right next to each other, you can press CTRL-C to copy them, and CTRL-V in the search on WorldCat or Google Scholar. I usually find that a combination of the author's name, part of the title, and the date is usually enough. (See screenshot.)
For now, please skip Arabic authors or items with transliterated Arabic titles. These are probably time consuming because the transliteration can vary quite a bit. We'll figure out a different strategy for these.
Don't search around a lot. If the information seems inaccurate or incomplete in WorldCat/Google, then you can copy it from the spreadsheet or mark it. Otherwise you can mark it "not found" in column G if you don't find it easily.
When you find examples of things that take a lot of time to find, please put them here so I can figure out how to improve the system.
Thanks!

@nathangibson Thank you for your response. It does improve the process a lot.
Besides I have a question related to the taging process. In #335 for example the Worldcat entry is offering me the name ar-Razi in the title, which I already have taged. The short table of content however is displaying more names like Ibn Sina (https://www.worldcat.org/title/traite-sur-le-calcul-dans-les-reins-et-dans-la-vessie/oclc/14806460&referer=brief_results). In the past I have taged all names available in the e.g. abstracts, but have now come to the conclusion it might be in some cases too much. So therefore I am asking you, if I have to tag all names displayed in the worldcat entry or just those appearing in the headlines.
Thank you

@nathangibson Thank you for your response. It does improve the process a lot.
Besides I have a question related to the taging process. In #335 for example the Worldcat entry is offering me the name ar-Razi in the title, which I already have taged. The short table of content however is displaying more names like Ibn Sina (https://www.worldcat.org/title/traite-sur-le-calcul-dans-les-reins-et-dans-la-vessie/oclc/14806460&referer=brief_results). In the past I have taged all names available in the e.g. abstracts, but have now come to the conclusion it might be in some cases too much. So therefore I am asking you, if I have to tag all names displayed in the worldcat entry or just those appearing in the headlines.
Thank you

@FlavioZeska Glad it helps.

Regarding how many names to tag, I think only those apparent from the title, for the sake of time.
Regarding translations and editions, yes, the guidelines are probably not clear ... Please

Put the ancient author only as a tag, such as Author: Abū Bakr al-Rāzī {https://usaybia.net/person/787}. Do not add a Person:  tag for the same person, and do not include the person in Zotero's Author field. The reason is that we need to identify the ancient author by URI, which we can only do well in the tags.
Put the modern translator/editor as an author in Zotero's Author field.
Add the tags Type: Translation and/or Type: Edition. (Sorry, this is new, but necessary.) So 335 for example would be both since WorldCat says "Text and French translation on opposite pages".
Please make sure to include the language codes in the Language field, e.g. for 335 it is ar, fr

@FlavioZeska Glad it helps.

Regarding how many names to tag, I think only those apparent from the title, for the sake of time.
Regarding translations and editions, yes, the guidelines are probably not clear ... Please

Put the ancient author only as a tag, such as Author: Abū Bakr al-Rāzī {https://usaybia.net/person/787}. Do not add a Person:  tag for the same person, and do not include the person in Zotero's Author field. The reason is that we need to identify the ancient author by URI, which we can only do well in the tags.
Put the modern translator/editor as an author in Zotero's Author field.
Add the tags Type: Translation and/or Type: Edition. (Sorry, this is new, but necessary.) So 335 for example would be both since WorldCat says "Text and French translation on opposite pages".
Please make sure to include the language codes in the Language field, e.g. for 335 it is ar, fr

@nathangibson Thank you for the update. I am reworking the entries now.
Sorry for bothering you again, but while revisting the entries in Zotero, another question came into my mind.
For the sake of standardization: How many names of a person should I add to a tag in Zotero? The initial person: tag Thābit ibn Qurrah of this thread could be expanded by al-Ḥarrānī acording to our website entry. In some cases, like al-Razi or Ibn Sina, the short version might already be long enough. But of course this are non objective criteria and therefore not standardized.

@nathangibson Thank you for the update. I am reworking the entries now.
Sorry for bothering you again, but while revisting the entries in Zotero, another question came into my mind.
For the sake of standardization: How many names of a person should I add to a tag in Zotero? The initial person: tag Thābit ibn Qurrah of this thread could be expanded by al-Ḥarrānī acording to our website entry. In some cases, like al-Razi or Ibn Sina, the short version might already be long enough. But of course this are non objective criteria and therefore not standardized.

@nathangibson Here is another question, this time concerning an actual name in the Usaybia database: About LHOM item #314: Here I was confronted with a certain Ibn Athradi in connection to Ibn Butlans banquet of the physicians, the only entries I was able to find in our database were however about a few persons named Ibn Uthrudi (https://usaybia.net/search.html?keyword=Ibn+Uthrudī). After working time I undertook a little search on my own and was able to find the name Ibn Atharudi (e.g. https://books.google.de/books?id=i8sUAAAAIAAJ&pg=PA12&lpg=PA12&dq=ibn+ithirdi&source=bl&ots=Pxz2U0sZvT&sig=ACfU3U1Bp0F3tVgDLWUvVHs1lpG6MNevyw&hl=de&sa=X&ved=2ahUKEwjPo-jOgsLuAhUwx4UKHd8_BUQQ6AEwA3oECAkQAQ#v=onepage&q=ibn ithirdi&f=false). So I wanted to ask what to do.
Thank you in advance

@nathangibson Here is another question, this time concerning an actual name in the Usaybia database: About LHOM item #314: Here I was confronted with a certain Ibn Athradi in connection to Ibn Butlans banquet of the physicians, the only entries I was able to find in our database were however about a few persons named Ibn Uthrudi (https://usaybia.net/search.html?keyword=Ibn+Uthrudī). After working time I undertook a little search on my own and was able to find the name Ibn Atharudi (e.g. https://books.google.de/books?id=i8sUAAAAIAAJ&pg=PA12&lpg=PA12&dq=ibn+ithirdi&source=bl&ots=Pxz2U0sZvT&sig=ACfU3U1Bp0F3tVgDLWUvVHs1lpG6MNevyw&hl=de&sa=X&ved=2ahUKEwjPo-jOgsLuAhUwx4UKHd8_BUQQ6AEwA3oECAkQAQ#v=onepage&q=ibn ithirdi&f=false). So I wanted to ask what to do.
Thank you in advance

@FlavioZeska Summary of our conversation today:

Please add the Zotero link or item number to the spreadsheet when you enter a new item. You can get this by just keeping this page open https://www.zotero.org/groups/2349036/usaybia.net/library , sorted by "Date Modified". (Click on an item and copy the address from the address bar.) If this is taking a long time, you could try the alternative of pasting the "abbreviation" from the spreadsheet into the "Short Title" field in Zotero.
If you find multiple items in Worldcat (or elsewhere), choose any of them with the correct date and title. If the date isn't the same, try to get the same edition, but reprints are okay.
If there is no Usaybia.net entry for a person you need to tag, still add the tag Person:  with the name. We will add a URI later.
It is important to have something in the language field. But if full names are used like "English" instead of "en" you can leave it for us to correct en masse later.

@nathangibson Lately I have encountered another difficulty. Sometimes I am unsure when to add the Type: Edition tag since our Zotero guidelines are in progress concerning this tag and sometimes Worlcat entries are not always clear. So in order to assure myself, I wanted to ask you: What exactly is our definition of the Type: Edition tag ?
Thank you

@FlavioZeska Yes, sorry for the lack of clarity! Type: Edition should be used when the bibliography item contains a historical text in the original language, e.g., an Arabic text. It can be used together with Type: Translation if there is also a translation of the text into another language. If it is only a translation and does not include the original text, please use only Type: Translation.
These things are often not clear from the Worldcat entry. Sometimes it might not be clear if it's only a study of the text or also an edition/translation. So you only need to tag edition/translation if you see it easily from the Worldcat item.

@nathangibson I am a bit unsure how to enter multivolume works like e.g. encyclopaedias. Into which field in Zotero do I enter the number of volumes? Thank you

@FlavioZeska There is a "# of volumes" field in Zotero. Please note that we enter encyclopedias with the item type "book".

Hi @FlavioZeska , Here is some feedback after checking a few items:
Overall, this is looking really great. Consistently accurate, high quality. Great work.
I've added "child notes" to a few items in Zotero with some things to correct. I'll paste them here too. Once you've changed these (if I haven't already), you can delete the note item in Zotero.

The main thing is to correct something I told you wrong at one point (sorry!). For modern editors of an ancient work, please enter them as "Editor", not "Author." This applies to everything tagged "Edition." Currently some of these are listed as "author" and some as "editor." I'm sorry I told you this wrong earlier. It shouldn't take too long to switch back: You can go through the smart folder I've created in Zotero "Change author > editor" and just switch all of them.
Please enter encyclopedia articles as "Book Section". (E.g., Jacquart, Danielle. “Ibn Māsawayh, Yūḥannā.” In Encyclopaedia of the History of Science, Technology, and Medicine in Non-Western Cultures, edited by Helaine Selin, 424–25. Dordrecht; Boston: Kluwer Academic, 1997.)
For Arabic names in the editors, if you're not sure which name should be used as the surname (as in this case perhaps), you can click the button to the right of the name "switch to single field." This will put the entire name of the author in one field, not split by first/last name. (E.g. الجازي, الراضي, and فاروق عمر العسلي, eds. كتاب طب الفقراء والمساكين. تونس: المجمع التونسي للعلوم واالآداب والفنون, 2009.)
Please pay careful attention to diacritics such as "ā" vs. "a" and ʿ or ʾ vs. '. Worldcat sometimes has these wrong, so it is best to check against the LHOM list. (E.g. Bos, Gerrit.  Sir Henry Wellcome Asian series. London: Kegan Paul International, 1997. and Rabin, C. “Ibn Jamīʿ on the Skeleton.” In Science, Medicine, and History : Essays on the Evolution of Scientific Thought and Medical Practice Written in Honour of Charles Singer, edited by Edgar A Underwood, 1:177–202. London: Oxford University Press, 1953.)
If LHOM cites a specific edition, please enter this in the "Edition" field. (E.g. Wright, William, and M. J. de Goeje. The travels of Ibn Jubayr ed. from a ms. in the university library of Leyden. 2nd revised. New York: AMS Press, 1973.)
Sometimes LHOM gives reprint information. It is not important enough for us to enter the reprint as a separate item in Zotero, but you can just paste the reprint info from the LHOM list into the "Extra" field in Zotero. E.g. When you have reprint information, you can just copy this into the "Extra" field like: Repr. of Les générations de médecins et des sages, ed. Fuʾād Sayyid (Publications de l’ Institut d’ Auteurs Orientaux, 10). Cairo: Imprimerie de l’ Institut Français d’ Archéologie Orientale, 1955.
When there are multiple languages, please enter them with commas instead of "and". E.g., "Arabic, Spanish". But ultimately we want to use the 2- or 3-letter abbreviations from https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes such as "ar, es". See the guidelines "14. Language and Script." Don't worry about correcting the ones you've already done. We can correct these en masse later.

@nathangibson Thank you very much for your revision and constructive criticism!

I have now switched all authors to editors, at least where possible. The "dissertation" type entry however does not allow switches to "editor" and in the case of some book chapters, where editors of texts do not equal editors of the whole modern book entry, I find it confusing (e.g. Meyerhof, Max, Las operaciones de catarata de ʻAmmār ibn ʻAli al-Mausilī).
Encyclopaedia entries are now corrected.
Thank you for this advice; sometimes Worldcat clarifies it by commas, sometimes not, so it helps me.
Should the reprint information be placed above or below the OCLC number or does it make no difference?
For clarification: What is the ISO 639-1 code for Syriac? Because I have only encountered the ISO 639-2 code (syc).

Thank you in advance

@FlavioZeska

I'll try to take a closer look at this.
Great.
Good.
Below.
Please use "syr" for Syriac. (There are some complicated issues around this.) ISO 639-2 (or 3 or 4 or 5) codes are fine when an ISO 639-1 code doesn't exist.

@nathangibson

Does this also apply to modern translators, i.e. should they be switched to "translators" in zotero?

Thank you

@FlavioZeska

In the case of editions which are dissertations or book chapters, yes, we should leave the modern editor as "author". But please use "editor" instead of "translator." Unfortunately Zotero doesn't export translators correctly. So it is better if we leave them as editors and we'll know from the "Type: Translation" tag that they are translators.

Duplicates -- entries that are in LHOM 2x, once for ancient author, once for modern editor --> please simply add the Zotero ID to the duplicate row in the table.
Manual Entry in Zotero for items you can't find in online databases
New persons -- we'll meet to discuss

@nathangibson
Here the mentioned list of entries, which came to my attention.
Typos
#1257 Isḥāq ibn ʿAlī al-Ruhāwī, Identity section adab (?) instead of acab https://usaybia.net/person/1257
#1306 al-Jāḥiẓ, Identity section  adab (?) instead of acab https://usaybia.net/person/1306
#1384 al-Khālidiyyān one zero short, second death year, miladi 390/100[0] https://usaybia.net/person/1384
#1586 Muʾayyid al-Dīn al-ʿUrḍī (ca. 596; closing bracket missing, besides, birth date in heading? https://usaybia.net/person/1586
#2168 al-Ṭabarī, Identity section, space missing (JarīrṬabarī) https://usaybia.net/person/2168
Inconsistency
#1026 Ibn Khaldūn year of death Identity section (1406) vs Names section (1057) https://usaybia.net/person/1026
Other
#483 ʿAlī ibn Yaḥyā, names section: possible remains of work instruction? ( toease check punctuation) https://usaybia.net/person/483
#633 Bar Bahlūl, "ERROR" in occupation section https://usaybia.net/person/633
#713 Diocles, adding Diocles [of Carystus] for better differentiation? https://usaybia.net/person/713
#2432 Quṭb al-Dīn al-Shīrāzī (d. 710/1311), dates in heading? https://usaybia.net/person/2432
which date alignment? h/m-h/m (https://usaybia.net/person/1139) or h-h/m-m (https://usaybia.net/person/32)
Same Persons?
#61 and #2312 [Zotero entries all #2312] al-Yaʿqūbī, unique names Wāḍiḥ/Yaʿqūbī (https://www.britannica.com/biography/al-Yaqubi), https://usaybia.net/person/61, https://usaybia.net/person/2312
#136 and #1725 [no Zotero entries] Nāfiʿ ibn al-Ḥārith ibn Kaladah, Abū Bakrah ibn al-Ḥārith ibn Kaladah "son of the slave-girl Sumayyah and, probably, the physician al-Ḥārith ibn Kaladah" https://usaybia.net/person/136, https://usaybia.net/person/1725
#161 and #1136 [Zotero entries all #161] Ibn al-Ṭayyib "Abū l-Faraj ʿAbd Allāh", https://usaybia.net/person/161, https://usaybia.net/person/1136
#598 and #1463 [Zotero entries all #1463] al-Malik al-ʿAzīz/al-ʿAzīz, same time of regency, miladi https://usaybia.net/person/598, https://usaybia.net/person/1463
#1229 and #1294 al-Irbilī, [no Zotero entries] same dates, https://usaybia.net/person/1229, https://usaybia.net/person/1294
#2201 and #2213 [Zotero entries all #2201] Theodosius https://usaybia.net/person/2201, https://usaybia.net/person/2213

@FlavioZeska Excellent, thank you for this!!

Reformatting ...
Typos

[ ] https://usaybia.net/person/1257 Isḥāq ibn ʿAlī al-Ruhāwī, Identity section adab (?) instead of acab https://usaybia.net/person/1257

[ ] https://usaybia.net/person/1306 al-Jāḥiẓ, Identity section  adab (?) instead of acab https://usaybia.net/person/1306

[ ] https://usaybia.net/person/1384 al-Khālidiyyān one zero short, second death year, miladi 390/100[0] https://usaybia.net/person/1384

[ ] https://usaybia.net/person/1586 Muʾayyid al-Dīn al-ʿUrḍī (ca. 596; closing bracket missing, besides, birth date in heading? https://usaybia.net/person/1586

[ ] https://usaybia.net/person/2168 al-Ṭabarī, Identity section, space missing (JarīrṬabarī) https://usaybia.net/person/2168

Inconsistency

[ ] https://usaybia.net/person/1026 Ibn Khaldūn year of death Identity section (1406) vs Names section (1057) https://usaybia.net/person/1026

Other

[ ] https://usaybia.net/person/483 ʿAlī ibn Yaḥyā, names section: possible remains of work instruction? ( toease check punctuation) https://usaybia.net/person/483
[ ] https://usaybia.net/person/633 Bar Bahlūl, "ERROR" in occupation section https://usaybia.net/person/633
[ ] https://usaybia.net/person/713 Diocles, adding Diocles [of Carystus] for better differentiation? https://usaybia.net/person/713
[ ] https://usaybia.net/person/2432 Quṭb al-Dīn al-Shīrāzī (d. 710/1311), dates in heading? https://usaybia.net/person/2432
[ ] which date alignment? h/m-h/m (https://usaybia.net/person/1139) or h-h/m-m (https://usaybia.net/person/32)

Same Persons?

[ ] https://usaybia.net/person/61 and https://usaybia.net/person/2312 [Zotero entries all https://usaybia.net/person/2312] al-Yaʿqūbī, unique names Wāḍiḥ/Yaʿqūbī (https://www.britannica.com/biography/al-Yaqubi), https://usaybia.net/person/61, https://usaybia.net/person/2312
[ ] https://usaybia.net/person/136 and https://usaybia.net/person/1725 [no Zotero entries] Nāfiʿ ibn al-Ḥārith ibn Kaladah, Abū Bakrah ibn al-Ḥārith ibn Kaladah "son of the slave-girl Sumayyah and, probably, the physician al-Ḥārith ibn Kaladah" https://usaybia.net/person/136, https://usaybia.net/person/1725
[ ] https://usaybia.net/person/161 and https://usaybia.net/person/1136 [Zotero entries all https://usaybia.net/person/161] Ibn al-Ṭayyib "Abū l-Faraj ʿAbd Allāh", https://usaybia.net/person/161, https://usaybia.net/person/1136
[ ] https://usaybia.net/person/598 and https://usaybia.net/person/1463 [Zotero entries all https://usaybia.net/person/1463] al-Malik al-ʿAzīz/al-ʿAzīz, same time of regency, miladi https://usaybia.net/person/598, https://usaybia.net/person/1463
[ ] https://usaybia.net/person/1229 and https://usaybia.net/person/1294 al-Irbilī, [no Zotero entries] same dates, https://usaybia.net/person/1229, https://usaybia.net/person/1294
[ ] https://usaybia.net/person/2201 and #https://usaybia.net/person/2213 [Zotero entries all https://usaybia.net/person/2201] Theodosius https://usaybia.net/person/2201, https://usaybia.net/person/2213


migration up or down to the specific version

example:
Enter at the command line:    sea-orm-cli  migrate  up  -V  m20220120_000001_create_post_table

@velasco300 hello! Thank you for contribution! I think we can merge this after: https://github.com/SeaQL/sea-orm/pull/706.

@billy1624 Thank you for your feedback. At first What I thought was that I knew clearly that I wanted to change to a certain version, but I had to understand and handle more details. For example, in shell scripts, You have to do like this: when > version then do something when < version then do something when unknown then do something, such API are not easy to use. I'll fix it later

Appreciated :)

@billy1624 I fixed it, in your case( sea-orm-cli migrate up -V m20220120_000001_create_post_table ),In my case( sea-orm-cli migrate up -V m20220120_000001_create_post_table -f )

Btw... is it possible to add some test cases?

We have upgraded clap to 3.2. We could rebase current PR onto latest master :)

https://github.com/SeaQL/sea-orm/pull/706

upgraded

@billy1624  @tyt2y3  I think the PR is done if you want to review it.


removeUpcomingTracks is removing the currently playing item when an item is already in the queue on Android

Describe the Bug
removeUpcomingTracks is removing the currently playing item when an item is already in the queue on Android.
Steps To Reproduce
Steps to reproduce on Android:

Add multiple tracks to the queue and press play.
Call removeUpcomingTracks.
The currently playing item is removed unexpectedly, and the next item begins playing.

Code To Reproduce
I need to work on this...
Replicable on Example App?
I need to work on this...
Environment Info:
System:
    OS: macOS 13.2.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
    Memory: 1.31 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.17.1 - ~/.nvm/versions/node/v16.17.1/bin/node
    Yarn: 1.22.18 - ~/.yarn/bin/yarn
    npm: 6.14.17 - ~/Repos/podverse-rn/node_modules/.bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8512546
    Xcode: 14.2/14C18 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.9 - /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.1 => 17.0.1
    react-native: 0.66.5 => 0.66.5
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

react-native-track-player
3.2.0-bb749e5d286737681ba8907dfd287480eb1cec45
Real device (haven't tested simulator)
Android 13
How I can Help
What can you do to help resolve this?
Try to make a reproduction demo.
Have you investigated the underlying JS or Swift/Android code causing this bug?
Not really, sorry.

I wonder if this has something to do with the reverse sort happening in removeUpcomingItems in KotlinAudio? It is a recent code change, and if we're removing items in reverse order, then perhaps it is accidentally removing the first item in the queue.
https://github.com/doublesymmetry/KotlinAudio/pull/50/files#diff-f61629c9e3e84e4bd20e36b561ae95c1530db3aa5c76665c9f4667a4edceae9fR166

Bug demo branch here: https://github.com/podverse/react-native-track-player/tree/1953-removeUpcomingTracks-android-bug

Restart app on Android.
Press play.
Press removeUpcomingTracks.
Error: the currently playing track will be skipped.

Should be fixed by https://github.com/doublesymmetry/KotlinAudio/pull/67

https://github.com/doublesymmetry/KotlinAudio/pull/67 has been merged, should be available on jitpack soon and we can bump the version in RNTP.

@jspizziri re: your message in Discord to try submiting a PR to RNTP bumping the KotlinAudio version, I took a stab at it, but I think I did it wrong...
https://github.com/doublesymmetry/react-native-track-player/pull/1968

I saw the commit was available in jitpack, so I specified the commit hash for the kotlinaudio dependency in build.grade. According to my tests locally, Puckey's fix was applied and worked when I did this. Is commit hash ok for this RC?

I updated the changelog, but wasn't sure how to reference the KotlinAudio PR properly.

Is ok if I mix the KotlinAudio upgrade and RC release in the same PR? Seems like for cleanliness I should have made 2. I can do that if you'd like.

a fix for this has landed in rc03: https://github.com/doublesymmetry/react-native-track-player/releases/tag/v4.0.0-rc03


Provide the correct port when using proxy

Fix "create-connection" failures in case of proxied connection.
The proxy needs the remote port information in order to know
to which port to open a tunnel.

This looks like a no-op change. Does the CONNECT verb not imply a default port number when none is present?

It's not a no-op. Imagine the following case:
WS-Host: wss://echo.websocket.org
proxy-host: proxy
proxy-port: 8080
The flow is as follows:
URI path = the WS-HOST
String host = path.getHost();
int port = path.getPort(); //-1 if the ":port" part of the authority is missing
if(hasProxy){
proxyConnect = createProxyRequest(host, port);
}else{
if(-1 == port) then do portDiscovery -> 80/443 depending on ws/wss scheme
...
}
So here in the proxy case the port will be -1, because WS-Host does not specify host. As a result the CONNECT request will not contain port in the request line -> hence invalid CONNECT request.
In the non-proxy case the original code correctly performs port discovery based on the scheme( if a port is not explicitly  provided in WS-Host).
So what I did was to do port discovery if no port is specified, regardless of proxy configuration.

Issue Description
WsWebSocketContainer generates bad CONNECT request when a proxy is used. The host does not contain port information, hence the app cannot connect to wss:// endpoints. Also some stricter proxy servers may reject requests without port info, thus making WsWebSocketContainer.connectToServer() fail for both ws:// and wss:// endpoints.
Steps to reproduce
Prerequisites

Download Tomcat 8.5.9
Configure it to use port 8081
Clone git@github.com:adamfisk/LittleProxy.git
Clone MCVE: git@github.com:SvetlinZarev/websocket-tomcat-bug.git
Build (3), (4) -> mvn clean install (you may want to rename the mcve to ROOT)

How to reproduce it

Start LittleProxy (it defaults to port 8080)
Configure Tomcat use the proxy: export CATALINA_OPTS="-Dhttp.proxyHost=localhost -Dhttp.proxyPort=8080 -Dhttps.proxyHost=localhost -Dhttps.proxyPort=8080"
Start tomcat: catalina.sh run
Request the mcve: http://localhost:8081/ws

Expected behavior
You should see:
Connected. Sending message...
Message: Hello World!
Disconnected:
Actual behavior
An exception is thrown. In case of LittleProxy it is a timeout exception during channel.handshake().get(); In my other case it is a DeploymentException caused by a bad request, because the (stricter) proxy rejected the request because  it does not contain port info.
Additional information
You can play with the mcve by adding the following request parameters:

scheme - i.e. ws://, wss://
server - i.e. echo.websocket.org

Example: 4. Request the mcve with: http://localhost:8081/ws?scheme=wss://&server=echo.websocket.org:443
It will succeed. Now remove the port from teh server string. It will fail.

Does the CONNECT verb not imply a default port number when none is present?

@ChristopherSchultz According to rfc2817 section 5.2:

A CONNECT method requests that a proxy establish a tunnel connection
on its behalf. The Request-URI portion of the Request-Line is always
an 'authority' as defined by URI Generic Syntax [2], which is to say
the host name and port number destination of the requested connection
separated by a colon

Also by the never finalized draft https://tools.ietf.org/html/draft-luotonen-web-proxy-tunneling-01#section-3.1:

The client connects to the proxy server, and uses the CONNECT method
to specify the hostname and the port number to connect to.  The
hostname and port number are separated by a colon, and both of them
must be specified.

Please file this issue into Bugzilla, as documented at
http://tomcat.apache.org/bugreport.html
So that it has proper visibility and can be linked to from a changelog file. (Do you read changelogs?)

Hi, I've already created a bugzilla ticket: https://bz.apache.org/bugzilla/show_bug.cgi?id=60617

Do you read changelogs?

I do.

OK, thank you.


⚠ Spryr has degraded performance

In b464bf5, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5601 ms

Resolved: Spryr performance has improved in 23713f5 after 11 minutes.


Default map location

I would like to be able to set the starting map location instead of having to zoom in from space to a location I normally look at.
A convenient option might be a menu item "save current view as default" or something along those lines.

Most likely. I keep the location turned off since it is not possible to have only triangulation and having GPS on wastes a lot of battery.

Only triangulation is also possible, but only starting with Android 12 where you can choose this during the permission request.
So yeah, it is a valid (albeit less common) use case. I guess one would want an option in settings to choose between

Default (~Europe)
Zoom to current location (not available if location permission disabled)
Custom view (which then allows you to choose on the map)

What about a default view that displays the area of all your favorite locations - if you have defined some.
Else default to all charging locations (eg. Europe).
First choice: Zoom to current location (not available if location permission disabled)

I just checked what Google Maps does when there is no current location available (or permission disabled): It simply keeps the position you viewed when the app was open the last time. I guess this is a pretty convenient solution that is easy to implement and doesn't require an extra menu/settings option.
Using the favorites might also be useful, but this depends on what you use favorites for (e.g. if you have some chargers as favorites around your hometown, but also some at a far away vacation destination, having a default view that shows all favorites is not that much better than showing all of Europe).

With 0d11e45 I implemented the behavior explained above (keep the last viewed location if location data are not available).
With 71c36fb I adjusted it again, so that it will also keep the last viewed location if location data are available, but the user wasn't actually looking at their location the last time they used the app. This is now really equivalent to how e.g. Google Maps does it, and should in my opinion be good enough for most use-cases.


Fixes to the LayoutNG article

What's changed, or what was fixed?
In the LayoutNG article,

Added missing periods/commas.
Fixed a broken word due to a line-break.
Removed hyphens in "For elements that size-to-content".
Removed underscores from _T_, which were probably added to make the T italic, but this doesn't work because we're inside of a block-level element (<figcaption>). However, rather than wrapping the T in <i>, it's probably better to leave it roman type so it's consistent with the way it is mentioned in a paragraph above.
Removed the misplaced space in "Layout NG".

CC: @petele

Edward Cheslow
<EMAIL_ADDRESS>DONE. FINISHED THANKS

On Sep 9, 2019, at 5:48 PM, kyarik<EMAIL_ADDRESS>wrote:
What's changed, or what was fixed?
In the LayoutNG https://developers.google.com/web/updates/2019/06/layoutNG article,
Added missing periods/commas.
Fixed a broken word due to a line-break.
Removed hyphens in "For elements that size-to-content".
Removed underscores from T, which were probably added to make the T italic, but this doesn't work because we're inside of a block-level element (). However, rather than wrapping the T in , it's probably better to leave it roman type so it's consistent with the way it is mentioned in a paragraph above.
Removed the misplaced space in "Layout NG".
CC: @petele https://github.com/petele
You can view, comment on, or merge this pull request online at:
https://github.com/google/WebFundamentals/pull/8100 https://github.com/google/WebFundamentals/pull/8100
Commit Summary
Fixes to the LayoutNG article
File Changes
M src/content/en/updates/2019/06/layoutNG.md https://github.com/google/WebFundamentals/pull/8100/files#diff-0 (24)
Patch Links:
https://github.com/google/WebFundamentals/pull/8100.patch https://github.com/google/WebFundamentals/pull/8100.patch
https://github.com/google/WebFundamentals/pull/8100.diff https://github.com/google/WebFundamentals/pull/8100.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/google/WebFundamentals/pull/8100?email_source=notifications&email_token=AM27LD7C4BQWEPQ5KFUGGD3QI3ACNA5CNFSM4IVAQK6KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKJJXFA, or mute the thread https://github.com/notifications/unsubscribe-auth/AM27LD5ACZ4EF7YGHQXAXW3QI3ACNANCNFSM4IVAQK6A.

:tada: This has been pushed live to https://developers.google.com/web/


Added comments to potentially confusing code

Description
Made comments to go along with any potentially code that I wrote
Type of change
Comments only
Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

 Add Comments for any potentially confusing code that I wrote


fix(android)!: use JDK11 compatible JVM options

See JDK8-->JDK11 migration notes here:
https://discuss.circleci.com/t/android-convenience-image-moving-to-java-v11-on-august-17th/36601/4
Related #120
BREAKING CHANGE: this orb is now officially using JDK11

As suggested by @cortinico this is semantically-tagged up as a commit that will trigger a semver major as it will be officially sanctioning use of JDK11 in the orb
The previous PR #121 will pin the underlying Docker image on JDK8 and may be used for people that need to stick to that.
#121 should be merged and released first, then this should be merged and released

thank you @mikehardy! :)

Thanks so much for merging this in @vonovak ! See you back over on google-signin :laughing:


Static string key

The static string key is frequently written when creating a standard library, so I can write it simply.

Sorry I disappeared for four years 😔 this is implemented now


K8s host config

Fleshed out portion of the HostConfig object in KDD to return an IP address for an IPIP tunnel if requested.
As we are currently using host-local for the IPAM provider in KDD we can assume that the first two IPs are available for use, as host-local reserves those for use.  This change will query the Node for its pod CIDR and grab the first IP from it to return.
fixes projectcalico/calicoctl#1599

I think this needs some UTs.

@robbrockbank This should be the complete set of changes, if it looks good I'll go ahead and rebase.

@robbrockbank Ready for another look.

LGTM.


Update config.toml

Until search is supported may as well not build the search index, site will build slightly faster too.

Good point, thanks!


How to show a ToolTip for a KryptonButton ?

How to show a ToolTip for a KryptonButton ?

Add a ToolTip control on your form and then set the Tooltip on ToolTip1 value of the respective button. Just like regular WinForms.


DmxInput: Cannot get value of channel 512

Using DmxInput::async_read I'm not able to get the value of channel 512, it's always 0.
Most probable cause after much debugging: The PIO pushes the channel values (byte-wise) from the input shift register to the state machine's RX FIFO. The DMA is configured to copy data from there to the user-provided buffer in 32-bit blocks. With the additional DMX start code, channel 511 ends such an 32-bit-block and the DMA copies over. Now when channel 512 is put into the RX FIFO, it won't trigger the DMA copy since the block will never be full. In this case, the DMA IRQ is not triggered as well right after the frame but only when the first bytes of the following frames came in (what I was and briefly mentioned in #13).
Until now I haven't found a proper solution to that problem. Modifying the DMA to work with 8-bit-transfers (instead of 32 bit) didn't work for me since I only saw every 4th channel in my buffer then.
The best I could do was:

In async_read, if num_channels is 512, request one transfer less than calculated so we get the IRQ fired after channel 511 came in
In the IRQ handler, check if num_channels is 512. If so, busy_wait 40µs so we are sure that channel 512 has reached the state machine. Then, make the state machine execute a PULL instruction (not sure why I needed to do so but otherwise the FIFO was empty?)
Read the FIFO manually and write the value to the buffer

However, that doesn't read channel 512 reliably, it just gives more or less random values :(
Ideas are welcome :) Or a proper solution with DMA transfer size of 8, maybe?

Code of method described above: https://github.com/jostlowe/Pico-DMX/compare/main...kripton:inputChannel512_try_A

I'd assume we might have the same problem with RDM responses: Depending on their length, we might currently not be able to get the last 1, 2 or 3 bytes.

Until now I haven't found a proper solution to that problem. Modifying the DMA to work with 8-bit-transfers (instead of 32 bit) didn't work for me since I only saw every 4th channel in my buffer then.
...
Ideas are welcome :) Or a proper solution with DMA transfer size of 8, maybe?

Proper DMA_SIZE_8 has been implemented in #18. The problem why it was not working for me yesterday was that I needed to modify the PIO-program. I did that but the changes were not honored since the #include "DmxInput.pio.h" always used the pre-compiled file in the src-folder instead of the one generated on-the-fly from the .pio-file I modified. Once I removed the pre-compiled .pio.h, it was working for me. But since Android doesn't seem to be able to run pioasm automatically during the build step, I re-added and updated the pre-compiled .pio.h-file


Prisma Schema : Migrate the PostgreSQL database

Summary
This will auto-deploy the schema to PostgreSQL Database.
Fixes
Manually creating and adding tables to Database.
Depends on
Database connection.
adding migrate to package.json
"migrate:dev": "prisma migrate dev",
"migrate:deploy": "prisma migrate deploy",
"migrate:status": "prisma migrate status",
"generate": "prisma generate"
Test plan
npm run migrate:dev
Screenshots

@thesushilsharma thanks for this PR. I've decided to split the UI from the backend which has been completely rewritten in Python since the LangChain Python package is much more feature packed than the TS version at this point.
You can check out the implementation here: https://github.com/homanp/superagent
I'm also looking att recreating the UI from scratch using the latest features of NextJS. Is this something you would be interested in contributing to?

I would be glad to assist. Please list out your issues/bugs, and I will try to help you. Meanwhile, I will fork and try to play with this repo.


Problems with the default key (C) Somehow changing my mouse sensitivity and spyglass itself keeps moving while zoomed in

I have no clue why this is happening, managed to fix the mouse sensitivity issue by changing the key bind to X but the spyglass zoom is still moving on it's own while zoomed in.

I’m sorry, I don’t seem to understand what you mean by “still moving”. Are you referring to smooth movement like a cinematic camera? Or are you saying that the spyglass is moving on its own uncontrollably? If it’s the former, then it’s a new feature in version 1.6.3. If not, then it could be a bug.
Regarding the change in sensitivity, this is actually a new feature designed to prevent the spyglass from moving too quickly when the magnification is too high. However, it should only occur when using the spyglass. If it happens in other situations, then it is indeed a bug. If not, you can try to turn off this feature in the display settings in the configuration to see if the problem you mentioned still occurs, and if you find this feature inconvenient in any way, feel free to share your feedback.
Sorry for the inconvenience caused to you, I will do my best to meet your needs.

Given that I suspect your issue may be related to the new features, your problem should be somewhat resolved in version 1.7.0. Therefore, I will close this issue for now. If you encounter any problems, feel free to reopen this issue or submit a new one at any time~


Boost: fix Android tools

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1371
https://travis-ci.org/ingenue/hunter/builds/204617472

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1372
https://travis-ci.org/ingenue/hunter/builds/204859065

Upload:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1373
https://travis-ci.org/ingenue/hunter/builds/205231386


Implement Order Summery Component

Description
Implement a Order Summery component in the first theme. So that user can see the order summery.
Reference: https://www.figma.com/file/rX1jl4pa04VD9itnzneeih/Webiu?node-id=0%3A1
Changes proposed in the pull request

Implement OrderSummery Component
Implement Story for the component
Create documentation for the component

Screenshots (In case of UI changes):

Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests have passed and it does not give any unexpected error for the same.

Steps To Test

npm i
npm run storybook (story will be displayed in E-Commerce/OrderSummery )

Resolves https://github.com/scorelab/Webiu/issues/244

@charithccmc @dinithminura can you review the PR please :)


[Enhance] Add messaging example

* Please fill in the required items.

Priority*

[ ] High: This PR needs to be merged first for other tasks.
[x] Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
[ ] Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Adds a simple implementation for easy use of the Messages API.
Changes*

Add the messaging package
Separate ready from prepare, a ready command that runs only once

How to check the feature

Use messaging api :)
Reference

README.md preview

Messaging Package
This package contains code messaging api.
To use the code in the package, you need to add the following to the package.json file.
{
  "dependencies": {
    "@extension/messaging": "workspace:*"
  }
}

Messaging API
You can use messaging api to send/receive messages between context.
Usage
import { messaging } from '@extension/messaging';

// Send message
messaging.send('message', { data: 'data' });

// Receive message
messaging.on('message', (payload) => {
  console.log(payload.data); // 'data'
  return 'response';
});

Message Types
You should define message types in the type.ts file.
export interface PayloadAndResponse<P = unknown, D = unknown> {
  payload: P;
  response: D;
}
/**
 * Define the type of messages
 * If you want to add a new message type, you can add it here.
 */
export interface Messages {
  greeting: PayloadAndResponse<string, string>;
  //...
}

Then you can take advantage of the message types in the messaging api.
import { messaging } from '@extension/messaging';

messaging.send('greeting', "Hello").then((response) => {
  console.log(response); // Hi
});

import { messaging } from '@extension/messaging';

messaging.on('greeting', (payload) => {
  console.log(payload); // Hello
  return 'Hi'; // response
});

SendToCurrentTab
You can use sendToCurrentTab to send a message to the current tab.
import { messaging } from '@extension/messaging';

messaging.sendToCurrentTab('message', "this is current tab!");

You can receive the message in the current tabs content script. (e.g. content or content-ui)
import { messaging } from '@extension/messaging';

messaging.on('message', (payload) => {
  // Do something
});

https://github.com/Jonghakseo/chrome-extension-boilerplate-react-vite/pull/747

This might be a better alternative, I'll look into it.


check for positive trade amount

minor improvement to #57

Codecov Report
Patch coverage: 50.00% and project coverage change: -0.02 :warning:

Comparison is base (c0cb0d0) 75.09% compared to head (c535646) 75.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   75.09%   75.08%   -0.02%
==========================================
  Files          55       55
  Lines        3361     3363       +2
==========================================
+ Hits         2524     2525       +1
- Misses        837      838       +1

Flag
Coverage Δ

unittests
75.08% <50.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

elfpy/agents/agent.py
90.19% <50.00%> (-1.65%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


maxConcurrentCount Not working

maxConcurrentCount set to 40. Deployed on a webfarm with 2 instances. only 2 tasks are running while the rest (are queued

Let me take I look I think I have a test that confirms this is working as expected. Might a bit more information on the tasks you are running.

Ok just checked as I use this library myself and it seems to be ok with a simple task of sending emails concurrently.
The defaults though are maxConcurrentCount:1 and millisecondsToWaitBeforePickingUpTask:1000
If you could share what you are doing that would be great.
A simple test would be to test it with a dummy task, that would rule out the task or the library.

I'm using this tool as a way to "Fire and Forget" large running jobs that can take anywhere from 5 minutes to 20 hours.
Using Task.Run i had issues with the job randomly closing with no logged exception. Found out it was the apppool recycle causing the issue so I downloaded this library.
I have this app deployed on 2 servers - chwf3a & chwf3b, and funnily enough, only 2 jobs seem to run.
When I run the jobs, I assign a database id so I can view job progress. The initial status is "Starting". Once queued, becomes "Beginning Preflight", until finished, "Preflight Complete".
I have 1 job set as "Preflight Complete", 2 jobs set as "Beginning Preflight", and 5 set as "Starting", telling me they haven't queued yet
Startup.cs
 public void ConfigureServices(IServiceCollection services)
 {
    services.AddBackgroundQueue(maxConcurrentCount: 40, millisecondsToWaitBeforePickingUpTask: 1000,
              onException: exception =>
              {
                  //logexception
              });
}

PreflightController
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
using System;
using System.Threading.Tasks;
using WebApplication1.Models;
using WebApplication1.Interact;
using System.Collections.Generic;
using WebApplication1.Models.DPX;
using DalSoft.Hosting.BackgroundQueue;

namespace WebApplication1.Controllers
{

    [ApiController]
    [Route("dpx/[controller]")]
    [System.Runtime.Versioning.SupportedOSPlatform("windows")]
    public class PreflightController : ControllerBase
    {

        private readonly ILogger<PreflightController> _logger;
        private readonly BackgroundQueue _backgroundQueue;

        public PreflightController(ILogger<PreflightController> logger, BackgroundQueue backgroundQueue)
        {
            _logger = logger;
            _backgroundQueue = backgroundQueue;
        }

        [HttpPost]
        public ActionResult<int> Post( [FromBody] CRAData runData)
        {
             //Log the start of the job
             int runID = PTADB.startAsyncJob(runData, "Starting");
            _backgroundQueue.Enqueue(async (cancellationToken) =>
                PTADB.updateRun(runID, "Beginning Preflight");
                //Sends an api POST call to another server, and waits until the application is complete
                //This can take anywhere from 30 seconds to 20 hours, depending on how many records are inputted
                 IgniteAPI.runPreflight(runData);
                 PTADB.endAsyncJob(runID, "Preflight Complete");
            });
        }
    }
}

I have the same issue. I just checked the code and BackgroundQueueService.ExecuteAsync seems to await each task one at the time. So the maxConcurrentCount parameter is not really used.. Instead BackgroundQueueService.ExecuteAsync could create a Timer that periodically Dequeue the maximum amount of tasks and awaits them in an async void handler (protected by try-catch). I can make a pull request if you want ?

Sorry for the delay in my reply I've been on holiday. I've been working on sorting out my side over the weekend, and have resolved this outstanding issue with covering tests.  New package release will be pushed to nuget on Monday, and I will close this issue.
https://dalsoft.co.uk/blog/too-many-side-projects/

This has now been fixed and tested https://github.com/DalSoft/DalSoft.Hosting.BackgroundQueue/commit/ef1c383f593c3955e6812a05e36efce0a21a423a
Package
Sorry for the delay in getting this resolved.

Thank you for the modifications. It's better. But there is still an issue. If a single background task takes forever to complete, it will block the whole queue forever. I suggest using a Timer (System.Threading.Timer) instead to await tasks (async void, with a try catch to be safe). And keep the while loop, with the cancellation token. And dispose the Timer properly if task is cancelled. That's how I see it.

Your 100% right using a Timer is the best way to do this 👍
There are two implementations I've done.
v1.1.1 this uses System.Timers.Timer and targets netstandard2.0, works with .NET Core 2.0 and above.
v2.0.0 this uses System.Threading.PeriodicTimer, which is a much better fit for background tasks. v2.0 targets net6.0 and works with .NET 6.0 and above.
The reason for v2.0 changing the targeting to net6.0 is that it's a lot easier to support Dependency Injection, which is fully supported in v2.0 using a service scope per queue item. I want to support scheduled Jobs in the future, and this will be easier to implement using a new version of .NET. Lastly it's nicer for me to use modern C# language features.
v2.0 has a fully working example in the repo using Swagger if you hit POST /backgroundtasks, then keep hitting GET /backgroundtasks you can see tasks being processed in to queue up to the maxConcurrentCount, with millisecondsToWaitBeforePickingUpTask being used to poll the queue, which was my original vision for the package.
Thanks for your patience and advice for improving the package.

Thank you for working on it so fast! I just checked your two implementations using timers.
For the 1.1.1 version
That's what I had in mind, except that

The _backgroundQueue.Dequeue is not currently awaited. I am no async expert, but I think it's best if the callback is async (timer.Elapsed += async (sender, args) => and await _backgroundQueue.Dequeue(..)). A task not awaited has no guaranty to finish, as I read somewhere.
I think there's a maximum of one execution per Timer tick if I read your code correctly? I liked the little while loop with the Task.WhenAll in the 1.1.0

For the 2.0.0 version
Same two issues. But simply awaiting it would mean that we're back with the older issues I mentioned, as the the PeriodicTimer seems to not allow concurrent executions of the 'callback' by design.

Thanks for taking the time to review my code, some notes from me:
Point 1:
My understanding is a Task not awaited has no Continuation, so if an exception occurs it is swallowed, which is why you get a compiler warning. For that we have onException, which handles exceptions in the Task. You can test this with the example project
The the only way I've triggered any problem is Mocking the CreateAsyncScope() call (as it's not in the try catch block) and forcing an exception. This is unlikely to happen in the wild, and why I went with net6.0.
I think people saying a a task not awaited has no guaranty to finish, comes back to not awaiting tasks in say a ASP.NET controller. What they really mean it's not guaranteed to finish before the parent Task i.e. the request is completes, or the even before the server process is shutdown.
We don't have that problem because the Dequeue Task is a nested Task of the BackgroundService.ExceuteAsync. BackgroundService controls the Task lifecycle with it's linked cancellation token, which is passed to the user's Task. So in a way not guaranteed to finish, but user knows the BackgroundService is shutting down.
I've forgotten a lot of my understanding of .NET internals, as it doesn't come up very often, this is a good write up I read today.  One improvement that might be worth investigating is allowing the user to provide TaskCreationOptions for their Task, but not sure if it's micro optimization.
Point 2:
You have me thinking about this now.
The main use case for this package is a drop in replacement for HostingEnvironment.QueueBackgroundWorkItem i.e. safely sending an email in the background. All versions tick that box ✔.
I think you're right about maxConcurrentCount being enough. At the time I developed the package I was migrating legacy code (hence needing a drop in replacement for QueueBackgroundWorkItem) and the servers were flaky, so I was being ultra cautious.
Now I've gone full circle as I don't think we need the timer either. We shouldn't need await the tasks in ExceuteAsync we can just go with a straight up loop, and let the queue and maxConcurrentCount do their jobs.

I can confirm setting the default value of MillisecondsToWaitBeforePickingUpTask to 10ms seems optimum. Now it works by default as most people expect allowing concurrent tasks up to the maxConcurrentCount limit.
Users still have the option if they need to warm 🔥 up a old IBM server before allowing concurrency, by setting MillisecondsToWaitBeforePickingUpTask to a higher value.

Alright! Thanks for the info. Everything seems good to me then.

I've just released v2 of the package! You can check it out here: v2.0.0...v2.0.1.
In this release, I set the default MillisecondsToWaitBeforePickingUpTask to 10ms. I've tested it in my production environments over the past week, and I'm happy to report that it's stable and performing well.
While a failure in CreateAsyncScope() is highly unlikely, I wrote a test to force an exception in the CreateAsyncScope call and found that onException wasn’t being triggered. I’ve fixed this issue, so now if anything fails within a task, onException will be called.
Additionally, I've increased the test coverage for the package.
 Your feedback reignited my motivation to improve this package 😎. Thanks to your input, the background service now properly supports concurrency and handles more advanced scenarios, beyond just being a replacement for HostingEnvironment.QueueBackgroundWorkItem.


Build BCUT when RDK_BUILD_DESCRIPTORS3D=OFF

What does this implement/fix? Explain your changes.
This PR fixes an issue BCUT was not built when RDK_BUILD_DESCRIPTORS3D=OFF.
Any other comments?
BCUT is not 3D-descriptor and requires Eigen3. But Eigen3 is enabled only when RDK_BUILD_DESCRIPTORS3D=ON.

@kazuyaujihara Thank you for the contribution!


Measuring accuracy

Hi, thank you for creating this resource. I have set it up to use my own dataset. I want to compare the performance of the different detectors on my data. How can I do this? Tensorboard only outputs the loss values, so I have no way to compare the accuracies.

Thank you! I got it to work for my data.


Marlowe Symbolic optimisation of Maps

Try to find out if there is a way of fixing the length of the lists that represent maps in symbolic execution, so that it is not necessary to use the symbolic versions of tail and head.

New implementation of symbolic execution uses concrete Maps


Removing the package does not update the graph nodes

Fix this as a general overhaul of graph node provider: respond to changes (update/remove package), fix ordering (issue #1) and more.

This is strange since we already unload/reload the project for "Remove package from project"

Hmm, didn't happen for me...

did you do "Remove package from project" on a paket.references node?

Umm no, I right-clicked one of the packages and chose 'Remove Package'
under packet.dependencies...
On Tue, May 19, 2015 at 4:07 PM, Steffen Forkmann<EMAIL_ADDRESS>wrote:

did you do "Remove package from project" on a paket.references node?
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket.VisualStudio/issues/47#issuecomment-103478549
.

ah yes. than you're right this one doesn't refresh the nodes.


Make TpProcessRequest header unserialized

Previously the header was bytes, requiring TP handlers to go through
the extra step of deserializing it before being able to access it.
Addresses https://jira.hyperledger.org/browse/STL-817

@peterschwarz smallbank had one unused function that had to do with transaction headers. I removed it.


What is the smallest interval that can be set?

I see that the "smallest allowed interval is five minutes" when setting the Schedule property on the "Create Indexer" documentation [https://docs.microsoft.com/en-us/rest/api/searchservice/Create-Indexer#schedule].  Could you please formally include that Indexer Limit on this page in the table above?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05e60837-26b9-1f5a-7a44-88ae8c9a7bc3
Version Independent ID: eaa6fabe-3d51-d626-3a51-d2e46efca454
Content: Service limits for tiers and skus - Azure Search
Content Source: articles/search/search-limits-quotas-capacity.md
Service: search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

@SeanCLeavitt Thank you for your feedback! We will review and provide an update as appropriate.

@SeanCLeavitt The change you requested is live:  https://docs.microsoft.com/en-us/azure/search/search-limits-quotas-capacity#indexer-limits
Thanks for filing this issue. If you feel like it's been addressed correctly, could you close the issue on your side?

Thank you - This is a helpful addition to the matrix of indexer service limits you have laid out.


Can you supply the instructions about how to use real-world data to train model

I viewed the whole code and found that the code only use toy dummy data to train model. So I don't really understand how you use those data to train  GCN model. Can you supply the code or instructions about how to use real-world data to train model?

It's also not clear how to get predictions from the trained model on new data/ a new pair of drugs. Do i put in SIDER codes? STITCH? other codes? in what format?

I am also confused about how to apply the model to the real data.

Please give instructions on how to apply the actual dataset in the code. It is very difficult to understand what the variables represent in the code for dummy data.

I am trying to apply the code to the real datasets. In the first step, I tried to check if I have the same parameters (number of proteins, drugs,...) for the network. The number of proteins as what has mentioned in the paper should be 19085. But, from the protein-protein network(bio-decagon-ppi), I get 19081 proteins. Has anyone tried applying the code to the real dataset? and have you got the same number of proteins for the network? Thanks.

I am also confused about how to apply the model to the real data.  Has anyone solved the problem? Thanks.

Same problem for me, not quite sure how to apply that.

@vidarmehr  I also get 19081 proteins from the protein-protein network(bio-decagon-ppi), and 1317 side effects, not the same as mentioned in paper (1318). Is it the same with your parameters (number of proteins, drugs,...) ? Thanks.

Any updates? Same issue here. We want to reproduce the paper's results.

@chao1224 I was not able to reproduce the results of paper and I decided to stop working on Decagon for now.

@vidarmehr I also get 19081 proteins from the protein-protein network(bio-decagon-ppi), and 1317 side effects, not the same as mentioned in paper (1318). Is it the same with your parameters (number of proteins, drugs,...) ? Thanks.
Sorry for my delay. I just saw your comment. As I mentioned, I am not working on Decagon anymore. Here is data that I got from the paper and from the real datasets:
Number of proteins = 19,085 (paper) ....... Number of proteins = 19,081(ppi data)
Number of drugs = 645 (paper).......... Number of drugs = 645 (polypharmacy side effect data (combo))
Number of protien-protien edges= 715,612(paper) ....... Number of protien-protien edges= 715,612 (ppi data)
Number of drug-drug edges= 4,651,131 (paper) ......... Number of drug-drug edges= 4,649,441 (polypharmacy side effect data (combo))
Number of drug-protein edges= 18,596 (paper) ........ Number of drug-protein edges= 18,690 (Drug-target protein (targets))

@vidarmehr  I got it. Thank you so much for your reply.

Thanks for the reply @vidarmehr.
Just want to quickly clarify a number:

In bio-decagon-targets.csv, there are 18,690 interactions.
In bio-decagon-targets-all.csv, there are 131,034 interactions, and 112,438 of them are invalid (not included in the STITCH list or Gene list). Therefore, there are 131,034 -112,438 = 18,596 valid interactions.

Are there any updates on this issue? I was also unable to reproduce the results in the paper. They say that they only focus on predicting the 964 polypharmacy side effects that each occurred in at least 500 drug combinations. However, the data they provide is the full TWOSIDES dataset. I don't know if they filter out some side effects in the code, but I couldn't find any evidence of this.

@rubjim I only can get 963 side effect types which appear in more than 500 drug combinations. I think the decagon dataset is so confusing that we could not apply it in our research work.

Was anyone ever able to reproduce the results? Or at least get it running properly?

@Dinxin I agree with you, that's what I also get when I filter the side effects myself. However, they claim they predict for 964 which doesn't correspond to the actual numbers in the dataset. @christina-s-wang at least I wasn't able to do it.

NO one cares for these people asking some help? I am in the same spot.

to use this code with real data + python 3.6 try this fork:
https://github.com/DeepVivo/decagon


chore: Refactor create topic

Signed-off-by: suyash-naithani<EMAIL_ADDRESS>What this PR does / why we need it:

Export Create topic page and fix circular dependency
Remove enum types for better performance
Lift state for advance options switch
Merge two different translation files for topic into one

the feature is already implemented in rhosak-ui, closing this in favor of rhosak-ui


Auto discovery not working

I have a single J1S on my network and am trying to use sm2uploader from OrcaSlicer to upload my files. Unfortunately I'm having no luck even when supplying the IP address directly.
When I don't provide an IP it never finds any printer, even though I can ping it and Luban finds it perfectly fine.
When I do provide an IP it still tries to auto discover (I feel like it shouldn't be doing this) and it seems like it connects but then throws an SACP error. See log below.
I'm running firmware v2.6.2 on the printer which it tells me is the latest.
Any thoughts greatly appreciated.
PS C:\Users\admin\Downloads\sm2uploader-win64.exe> .\sm2uploader-win64.exe -debug
2023/12/31 12:45:06 -- Debug mode
2023/12/31 12:45:06 Discovering ...
2023/12/31 12:45:06 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:10 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:14 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:18 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:22 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:26 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:30 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:45:34 -- Discovered 0 printers
2023/12/31 12:45:34 No printers found
2023/12/31 12:45:34 -- Saved known hosts: C:\Users\admin\Downloads\sm2uploader-win64.exe\hosts.yaml
PS C:\Users\admin\Downloads\sm2uploader-win64.exe> .\sm2uploader-win64.exe -debug -host <IP_ADDRESS> "C:\Users\admin\Downloads\test_upload.gcode"
2023/12/31 12:51:50 -- Debug mode
2023/12/31 12:51:50 Discovering ...
2023/12/31 12:51:50 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:51:54 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:51:58 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:52:02 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:52:06 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:52:10 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:52:14 -- Discovering on <IP_ADDRESS>:20054
2023/12/31 12:52:18 -- Discovered 0 printers
2023/12/31 12:52:18 Printer IP: <IP_ADDRESS>
2023/12/31 12:52:18 Uploading file 'test_upload.gcode' [245.7 KB]...
2023/12/31 12:52:22 -- SACP_connect got:
&{0 1 1 32056 172 165 [0 0 0 0 0]}
2023/12/31 12:52:22 got command set/id 172/165 but expected 1/5
2023/12/31 12:52:22 -- Updated printer: @<IP_ADDRESS> -
2023/12/31 12:52:22 -- Saved known hosts: C:\Users\admin\Downloads\sm2uploader-win64.exe\hosts.yaml
PS C:\Users\admin\Downloads\sm2uploader-win64.exe> ping <IP_ADDRESS>

Pinging <IP_ADDRESS> with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time=42ms TTL=64
Reply from <IP_ADDRESS>: bytes=32 time=57ms TTL=64
Reply from <IP_ADDRESS>: bytes=32 time=75ms TTL=64
Reply from <IP_ADDRESS>: bytes=32 time=88ms TTL=64

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 42ms, Maximum = 88ms, Average = 65ms

2023/12/31 12:52:22 got command set/id 172/165 but expected 1/5

Please upgrade the firmware and restart the printer.

Weird... yup, that works. What's stranger though is I had not run Luban to test until after it failed to work the first time (2 minutes after first startup of printer) with sm2uploader.
One question... it still tries to discover printers on the network even with -host and still fails. I thought that providing -host disabled discovery? j1uploader does work with auto discovery... but nothing I can do with sm2uploader gets auto to work.

I'm having a similar issue on an M2 MacBook Pro when communicating with my Artisan. The app connects if I specify the host explicitly, but not if I omit that option. I'm running version 2.8 of sm2uploader. Sometimes I get this:
2024/05/28 11:34:43 Discovering ... 2024/05/28 11:34:43 Error discovering on <IP_ADDRESS>: write udp4 <IP_ADDRESS>:59967-><IP_ADDRESS>:20054: sendto: no route to host 2024/05/28 11:34:43 No printers found
whereas other times, I simply get this:
2024/05/28 11:36:46 Discovering ... 2024/05/28 11:36:50 No printers found


chore(ci): update actions/upload|download-artifact from v3 to v4

Due to deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Just bumping the version is not sufficient, we need to adapt the workflows to work with v4 as there are behavior changes.
Last time I tried upgrading to v4 was in https://github.com/ethereum/beacon-APIs/pull/462 but I didn't get it to work and had done a lot of other changes so I skipped upgrading those. They changed how files are copied and how to deal with existing directories, iirc it throws an error if a directory already exists. There is a overwrite flag (see inputs) but the problem there was it would overwrite the whole folder and since we run this as a matrx it would only keep the last release.
https://github.com/ethereum/beacon-APIs/blob/1cf1adae5bd944108fb6522000d2d392967729ba/.github/workflows/deploy.yaml#L21
There is probably a way to tweak this (ie. by using different folders) to make it work but this needs to be tested in a forked repo first.

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md might be helpful

I opened a PR https://github.com/ethereum/beacon-APIs/pull/487 which updates the workflows to work with v4


Spelling Error for 'Calculator' and Missing Favicon on Home Page

There are two issues on the home page:

The word "Calculator" is spelled incorrectly.
The favicon is missing from the browser tab.

Steps to Reproduce

Open the home page.
Check the spelling of "Calculator."
Notice the missing favicon in the browser tab.

Expected Behavior

The word "Calculator" should be spelled correctly across the website.
A favicon should be visible on the browser tab for better branding and user experience.

I think issue no 1 is already fixed but no 2 can be fixed. I will assign this issue to you


zine build fails if dest/static directory not exists

Which version am I using?
zine 0.3.0 on Mac mini (M1, 2020)
What's the problem?
Zine fails to build a newly-generated project, reporting a panic:
Error: No such file or directory (os error 2)
How to reproduce?

install zine 0.3.0
zine new testproject
cd testproject
zine build
The build should fail by now.

What might cause the issue?
After digging around in the source code, I believe the problem results from include_dir crate.
In 0.3.0, Zine copies the builtin static files into output directory's static folder by using include_dir. When include_dir extracting a file, it simply uses fs::write(TAEGET_PATH), which will panic if TARGET_PATH includes non-existence directory.
Because testproject/build/static directory does not exists when include_dir tries to extract zine's buildin static file, it simply panics.
In version 0.2.1, zine would create the output static directory first before copying static files, so the problem did not exist.

If we create mkdir testproject/build/static manually, then zine build successfully.

You are right, hugely thanks for the feedback. Would you mind submitting a PR? Thanks.

Fixed via #33.


[A11y] Calendar picker UI is not accessible through keyboard navigation

Navigate to https://tempnewsroom.accenture.com/
Navigate to the calendar picker icon through tabbing
Open the calendar picker modal
Click the tab key

ER The focus is on the elements within the calendar modal
AR The calendar modal elements were skipped and the focus directly wen to the elements beneath it

This works exactly like in the current newsroom.accenture.com site. We are also using the same datepicker library.
https://github.com/hlxsites/accenture-newsroom/assets/7074782/bcd674d8-12f5-4a68-94e5-41beaf5108ce


Slow in Linux

I get different experience in windows and linux. In linux is very slow when scroll down the page. Try test with Ubuntu LTS. Thanks!

I'will see this problem later~

Thanks @forsigner :+1:

Firefox上滚动比较慢


[Fix #3300] Do not replace %q()s containing escaped non-backslashes

In %q(...) \\ is the only escape (evaluating to a single \), so if a %q literal contains escaped characters that are not \ we should not change to double quotes, since that will change the string:
irb(main):001:0> puts %q(\\ \')
\ \'
irb(main):002:0> puts "\\ \'"
\ '

Notice how the first prints \' but the second just '

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

This is missing a changelog entry.

Good spot @bbatsov - fixed!

👍


LEGO: Pull request from lego/hb_a13bbffa-1136-4930-9ebe-33895240f846_20210906120531522 to master

LEGO: Pull request from lego/hb_a13bbffa-1136-4930-9ebe-33895240f846_20210906120531522 to master with localized lcls

Btw this PR has merge conflicts.

@jay-o-way Please open a standalone issue for your suggestions.

Why can't I review this kind of pr?


Delete/Rename Tags

There appears to be no way to delete or modify existing Tags for server connections.  Maybe someone knows a PowerShell script that can modify or delete existing tags?
Thanks much.

I upvote this!

Especially useful to get rid of mistyped tags!


Make the .hover element usable for every object?

Hover is separate object. I think it should be possible to add "hover" to every object as syntax element.
Examples:
ard button P5 123 hover-50
ard button P5 123|50
ard button P5 123-50
ard button P5 123h50
... or with attribute:

Click Me

The onLeave value should be 0 by default. To add different value it could look like this:

Click Me

Maybe this feature is useless because you can add div with Involt element inside div with Involt hover.
(I need to check this)

This can be simply done by adding desired element as children of hover element.


stellar boots, flipper upgrade, and depth  strider 3 = insane in-water speed

Issue Description:
What happens: Wearing stellar boots with flipper upgrade and depth strider 3 in water makes you move so fast you can't really do any kind of accurate movement.  it's fast, too fast.
What you expected to happen: Either normal flipper upgrade movement, or normal depth strider 3 movement.
Steps to reproduce:

Stellar boots (probably also dark boots) with flipper enchantment
Add depth strider 3 enchant via anvil
Attempt to walk/swim in water of any depth
...

Affected Versions (Do not use "latest"):

EnderIO: 5.1.52
EnderCore: 0.5.72
Minecraft: 1.12.2
Forge: <IP_ADDRESS>47
SpongeForge? no
Optifine? yes AND no (tested both, still happens with or without Optifine.
Single Player

Your most recent log file where the issue was present:
[pastebin/gist/etc link here] Somewhat embarrasingly, log file is too long to pastebin.

Looks like a Forge bug. It seems EntityAttribute SWIM_SPEED and DepthStriderModifier are applied in a conflicting way.

PS: Could someone please report this to Forge? The SWIM_SPEED attribute is quite new, so it is not surprising it still has bugs.

https://github.com/MinecraftForge/MinecraftForge/issues/6309
It is normal and intended that you move 50 times as fast as usual when using depth strider with any swim speed armor. (That's 106 times as fast with fully upgraded walk speed Dark Steel armor.)


Unable to edit from timeline

I'm using VSCodium 1.88.1 and MarkWhen version 1.4.2
I'm unable to edit events from the timeline, for example:

When in the timeline, I cannot grab an event for drag and drop.
I am able to grab the ends to change the start/stop times individually, but the changes revert to the original  as soon as I release the mouse button.
I cannot add a new event from the timeline, nothing happens when in click the + button

I am using Visual Studio Code Version: 1.89.0 (Universal) and MarkWhen version 1.4.2 and I have the same issues as @kingpatrickj .

Editing from the timeline (except for adding new events) is available in 1.4.4


Displaying the real value on focus now display the locales decimal separator rather then always displaying '.'

This will end up being a major/minor version bump if it gets merged since it will be modifying how existing functionality works.
Live Demo (This launches with the input focused)
Resolves #103

LGTM! +1 from testing advanced setup. See my comment on #103.

@aguirrel Can you look at this when you get the chance?

Hi @nick-woodward and @houmark .
I really love recovering this option, is much more friendly.  I think this should default behavior and add some option parameter to use dot (.) for those who use only numeric pad to input data.
What do you think about this new option?

@aguirrel
I believe you can still enter data with dots if you want to due to how well your parsing logic was written.
If you're modifying a field it'll obviously have the locale specific decimal separator.
However I doubt the user would modify the decimal separator at that point anyways.
I'm game to add a use-model-value binding, but I'm not entirely sure it would be used.

Yes! It works like a charm! Merged! Thanks a lot!

Nice to see this merged! Maybe this should merit a new release? I'd suggest v1.1...

Yes, @nick-woodward is implementing issue "#104 Semantic Release".
@nick-woodward , do you think is better to create a new release before or after #104 is done?

@aguirrel v1.1.0 already contains these changes,


npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

I get the above error when running 'npm install'

Try ‘npm install webgme’

That worked!