Basic illustrations with graphics library

Joy aims to provide a simple and approachable API for illustrating geometric shapes. Of course, one can do it directly with graphics library. The examples directory in this repo has an example that illustrates a circle. It'd be useful to have more examples in there, which we can later compare with the joy API. Here are some ideas for drawings --

A simple rectangle
Circle and a rectangle together
Concentric circles
Three circles in a row
A grid of four circles just touching its adjacent ones
Feel free to come with something

Please mention below if you're working on any of these. Each of these examples can go into a separate ocaml source file within examples. When you're done with one of these, feel free to go ahead and make a PR to add it to examples.  You can refer to the dune file within the directory.

I'd like to start working on this issue with first, the drawing of the simple rectangle. Just to make sure, this is the repo that I have to fork, create a branch and work on right? https://github.com/Sudha247/ocaml-joy

Yes, that's correct.

How do I run the code to make sure that I can view my changes before making any commits? I just viewed the example circle and it's all red on my local machine. Making sure that I do it right

Also, do I create the files in the example folder or in the lib folder?

This is the right directory.
You can run the examples with dune. Please install dune via opam before you proceed.
$ cd ocaml-joy
$ dune build examples/
$ dune exec -- examples/circle.exe

The above commands produce a graphics window with a circle.

This is the result from the terminal

I have dune 3.6.2 installed

Also, I get this error after updating the /dune-project file from (lang dune 3.10) to (lang dune 3.6) and rerunning the command;
File "examples/dune", line 4, characters 12-20:
4 |  (libraries graphics))
^^^^^^^^
Error: Library "graphics" not found.
-> required by _build/default/examples/circle.exe
-> required by alias examples/all
-> required by alias examples/default
PS: I have dune 5.1.2 installed

Hello, I have this error when running
dune exec -- examples/circle.exe

I have the same error. Did you successfully run the dune build examples/ command?

Oh I forgot to mention as @Sudha247 requested, I will love to work in this.
I see @nangahamandine is on it too, I hope both of us can work on same issue?

I have the same error. Did you successfully run the dune build examples/ command?

No @nangahamandine , I didn't succeed

@Mankavelda and @nangahamandine
Did you use opam install graphics to install graphics dependency?

Also, first step on vscode should be to install the ocaml-platform extension.
@nangahamandine you were getting all the rearedd lines because you haven't built your project beforehand, which is done using dune build examples
But since you're getting the dune version error.
Maybe checkout this thread for a possible solution.

Oh I forgot to mention as @Sudha247 requested, I will love to work in this. I see @nangahamandine is on it too, I hope both of us can work on same issue?

We usually assign just one applicant to each issue.
But since everyone is having trouble setting up the repo, and we have multiple figures that one can draw, it's a good idea for both of you to open separate PRs for this one.
But first please coordinate which figure you want to draw, so that we don't get clashing PRs :)

Can you share your opam versions here?
You need opam > 2.x.x
Then after setting up correct version of opam, run
opam update && opam upgrade

Then install the required version of dune using
opam install "dune=x.y.z" // Keep this `3.0 to 3.9 range`

And then you can run the following command inside the examples directory
opam install graphics

This will install the relevant dependencies.
Then run
$ cd ocaml-joy // OR cd ..
$ dune build examples/
$ dune exec -- examples/circle.exe

@Sudha247 are there any other issues i can  attempt

@Sudha247 , i would love to contribute by drawing a sun

@nangahamandine

still no difference.

Do you mean dune still doesn't recognise that the graphics library is installed? It's quite odd. Anyways, I see that you're on a Windows machine. It's recommended to use WSL for running OCaml. You can perhaps try that.
@waringa-mercy - yes, you can go ahead with any of the unclaimed illustrations mentioned in this issue.
@joanita-51 - sure, that sounds great!

@nangahamandine

still no difference.

Do you mean dune still doesn't recognise that the graphics library is installed? It's quite odd. Anyways, I see that you're on a Windows machine. It's recommended to use WSL for running OCaml. You can perhaps try that.
@waringa-mercy - yes, you can go ahead with any of the unclaimed illustrations mentioned in this issue.
@joanita-51 - sure, that sounds great!

Yes. Okay, I'm presently setting up wsl

Can you share your opam versions here? You need opam > 2.x.x
Then after setting up correct version of opam, run
opam update && opam upgrade

Then install the required version of dune using
opam install "dune=x.y.z" // Keep this `3.0 to 3.9 range`

And then you can run the following command inside the examples directory
opam install graphics

This will install the relevant dependencies.
Then run
$ cd ocaml-joy // OR cd ..
$ dune build examples/
$ dune exec -- examples/circle.exe

Hello @AryanGodara, I was able to replicate these steps and my graphics library and dune build are working successfully and I can open run the exec commands for circle and circle graphs. :+1:

Can you share your opam versions here? You need opam > 2.x.x
Then after setting up correct version of opam, run
opam update && opam upgrade

Then install the required version of dune using
opam install "dune=x.y.z" // Keep this `3.0 to 3.9 range`

And then you can run the following command inside the examples directory
opam install graphics

This will install the relevant dependencies.
Then run
$ cd ocaml-joy // OR cd ..
$ dune build examples/
$ dune exec -- examples/circle.exe

Hello @AryanGodara, I was able to replicate these steps and my graphics library and dune build are working successfully and I can open run the exec commands for circle and circle graphs. 👍

That's great @godplayer56
You can now start working on building your own examples from the above list if you have set up the Jupyter kernel

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

Can you paste the steps you took after cloning the repo and the versions of your opam dependencies (dune graphics base server lap server etc) to get more idea

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

Can you paste the steps you took after cloning the repo and the versions of your opam dependencies (dune graphics base server lap server etc) to get more idea

After cloning the repo, I created and switched to a new branch, then I navigated to the ocaml-joy directory and ran the following commands:

dune build examples/  ( after building the pfoject I then ran the following command)
dune exec -- examples/circle.exe

Here are the versions of opam, dune, and graphics:
opam version = 2.1.3
dune version =3.10.0
graphics version = 5.1.2
I don't know if this is enough information to help troubleshoot the problem

Everyone using Windows.
I suggest switching to WSL2. I tried to set up everything on Windows, and there were a lot of conflicts, especially when working with a diverse tech stack.
As for @FanyamTerkuma I'm not able to understand what the issue is in your case.
Is the same issue happening in circle_graph also?

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

Can you paste the steps you took after cloning the repo and the versions of your opam dependencies (dune graphics base server lap server etc) to get more idea

After cloning the repo, I created and switched to a new branch, then I navigated to the ocaml-joy directory and ran the following commands:

dune build examples/  ( after building the pfoject I then ran the following command)
dune exec -- examples/circle.exe

Here are the versions of opam, dune, and graphics: opam version = 2.1.3 dune version =3.10.0 graphics version = 5.1.2
I don't know if this is enough information to help troubleshoot the problem

@FanyamTerkuma I think I understand your issue.
It may be regarding the dimensions of the background and the circle.
You see, in the circle.ml file, the three coordinates may be seen as x , y , radius
So, maybe the pixels are being drawn outside of the visible region of the background, or is too small to view for some reason.
Try to tweak around with the dimensions in the circle.ml file to see if this works

Hello everyone!
I already did the illustrations for a simple rectangle and concentric circles. I'm moving on to write code for the other shapes.
Please let me know  if any of you is presently working on the other shapes. Otherwise, I'd like for this issue to be assigned to me exclusively so I can work on the other shapes and complete them in the next 24 hours

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

Can you paste the steps you took after cloning the repo and the versions of your opam dependencies (dune graphics base server lap server etc) to get more idea

After cloning the repo, I created and switched to a new branch, then I navigated to the ocaml-joy directory and ran the following commands:

dune build examples/  ( after building the pfoject I then ran the following command)
dune exec -- examples/circle.exe

Here are the versions of opam, dune, and graphics: opam version = 2.1.3 dune version =3.10.0 graphics version = 5.1.2
I don't know if this is enough information to help troubleshoot the problem

@FanyamTerkuma I think I understand your issue. It may be regarding the dimensions of the background and the circle. You see, in the circle.ml file, the three coordinates may be seen as x , y , radius So, maybe the pixels are being drawn outside of the visible region of the background, or is too small to view for some reason. Try to tweak around with the dimensions in the circle.ml file to see if this works

I tried that as well, but it did not work. Although it is working in jupyter notebook.

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

Can you paste the steps you took after cloning the repo and the versions of your opam dependencies (dune graphics base server lap server etc) to get more idea

After cloning the repo, I created and switched to a new branch, then I navigated to the ocaml-joy directory and ran the following commands:

dune build examples/  ( after building the pfoject I then ran the following command)
dune exec -- examples/circle.exe

Here are the versions of opam, dune, and graphics: opam version = 2.1.3 dune version =3.10.0 graphics version = 5.1.2
I don't know if this is enough information to help troubleshoot the problem

@FanyamTerkuma I think I understand your issue. It may be regarding the dimensions of the background and the circle. You see, in the circle.ml file, the three coordinates may be seen as x , y , radius So, maybe the pixels are being drawn outside of the visible region of the background, or is too small to view for some reason. Try to tweak around with the dimensions in the circle.ml file to see if this works

I tried that as well, but it did not work. Although it is working in jupyter notebook.

I was going to propose that you tweak the dimensions but I noticed that it's already been proposed.
I faced a similar issue with another illustration but it displayed when I increased the dimensions to (1000, 1000)
Well, since it is working with Jupyter notebooks, maybe you just test the illustrations with that for now.

@Sudha247 and @AryanGodara , I am currently having issues with running OCaml code in vscode, OCaml platform extension has been installed along with the other dependencies but on running this command  "dune exec -- examples/circle.exe" the window displays without the circle. Please, how can I solve this? Here is a snapshot.

Can you paste the steps you took after cloning the repo and the versions of your opam dependencies (dune graphics base server lap server etc) to get more idea

After cloning the repo, I created and switched to a new branch, then I navigated to the ocaml-joy directory and ran the following commands:

dune build examples/  ( after building the pfoject I then ran the following command)
dune exec -- examples/circle.exe

Here are the versions of opam, dune, and graphics: opam version = 2.1.3 dune version =3.10.0 graphics version = 5.1.2
I don't know if this is enough information to help troubleshoot the problem

@FanyamTerkuma I think I understand your issue. It may be regarding the dimensions of the background and the circle. You see, in the circle.ml file, the three coordinates may be seen as x , y , radius So, maybe the pixels are being drawn outside of the visible region of the background, or is too small to view for some reason. Try to tweak around with the dimensions in the circle.ml file to see if this works

I tried that as well, but it did not work. Although it is working in jupyter notebook.

I was going to propose that you tweak the dimensions but I noticed that it's already been proposed.
I faced a similar issue with another illustration but it displayed when I increased the dimensions to (1000, 1000)
Well, since it is working with Jupyter notebooks, maybe you just test the illustrations with that for now.

Yes, I  guess so.

Can you share your opam versions here? You need opam > 2.x.x
Then after setting up correct version of opam, run
opam update && opam upgrade

Then install the required version of dune using
opam install "dune=x.y.z" // Keep this `3.0 to 3.9 range`

And then you can run the following command inside the examples directory
opam install graphics

This will install the relevant dependencies.
Then run
$ cd ocaml-joy // OR cd ..
$ dune build examples/
$ dune exec -- examples/circle.exe

Hello @AryanGodara, I was able to replicate these steps and my graphics library and dune build are working successfully and I can open run the exec commands for circle and circle graphs. 👍

That's great @godplayer56 You can now start working on building your own examples from the above list if you have set up the Jupyter kernel

Thank you @AryanGodara

I am able to see the circle now

I am able to see the circle now

Yay!!!

Thanks for the work everyone! Since we have most of the illustrations in the list in open PRs, I'm closing this issue. Anybody already working on an illustration that's not present in the existing PRs, you can continue to do so. For people starting new, please look at other issues.

@nangahamandine

still no difference.

Do you mean dune still doesn't recognise that the graphics library is installed? It's quite odd. Anyways, I see that you're on a Windows machine. It's recommended to use WSL for running OCaml. You can perhaps try that.
@waringa-mercy - yes, you can go ahead with any of the unclaimed illustrations mentioned in this issue.
@joanita-51 - sure, that sounds great!

Yes. Okay, I'm presently setting up wsl

Please was the wsl helpful? If yes please could you tell me how you did it? I have a Windows computer.

@nangahamandine

still no difference.

Do you mean dune still doesn't recognise that the graphics library is installed? It's quite odd. Anyways, I see that you're on a Windows machine. It's recommended to use WSL for running OCaml. You can perhaps try that.
@waringa-mercy - yes, you can go ahead with any of the unclaimed illustrations mentioned in this issue.
@joanita-51 - sure, that sounds great!

Yes. Okay, I'm presently setting up wsl

Please was the wsl helpful? If yes please could you tell me how you did it? I have a Windows computer.

Hi @fiona-max, I've outline the steps you can follow in the issue you're working on. Please try it out and see. Would be there to hep in whatever way I can


process fake interferes with polyfills

The fake for process below:
https://github.com/axiomhq/axiom-js/blob/main/packages/pino/src/index.ts#L5-L6
Interferes with the polyfills when bundling an app.
Reproduction
https://codesandbox.io/p/sandbox/axiomhq-pino-edge-repro-ypv4xm?file=%2Fserver%2Fmiddleware%2Flogger.ts%3A13%2C53
To build for non-node environment (polyfilled):
NITRO_PRESET=netlify-edge pnpm build

To build for node environment (without polyfills):
pnpm build

When building for non-node environments, process is polyfilled but results in Rollup error.

I have faced errors with this as well on the edge runtime for the e2e app in the repo. Trying to think of a better workaround.

Hi, We have a released a new version that fixes this build issue. It's still rc but maybe you could give it a try.


dmd update to 2.067.0

This update seems to break dub. Maybe dub should be updated as well.

Thanks -- I'll look into it when I get on my home machine

How can I build nixpkgs on my local machine so I don't have to submit a pull request in order to test the build?
Thanks
Charles

Build passes :)

To test the build locally, you can use nix-build or nix-env -f . as described in the Nixpkgs Contributors Guide. The nox-review utility (to be found in the nixpkgs.nox package) might also help.
Also, in your PR branch, please rebase on master rather than merge. Thanks.

Thanks -- when I try nix-build or nix-shell in nixpkgs/ I get failures like
error: assertion failed at "/home/charles/nixpkgs/pkgs/top-level/all-packages.nix":4899:15
I assume there is something different about the travis build environment which I am not getting.
Eventually I did find nox-review but was somewhat frustrated since I was only able to review uncommitted changes or pull requests (but not my local branch)

rebased on master instead of merge and applied in PR branch via git push --force (so it's a bit ugly)

I see -- something like nox-review wip --against master^' should work


Fixed elements are removed when opening the Drawer

When having other fixed elements active on my screen, when activating the Drawer it ends up hiding the fixed and when closing it reappears, is there any way I can open the drawer without removing the fixed elements from the screen?
Preview:
https://github.com/emilkowalski/vaul/assets/56942108/a3a48912-71c6-44ad-a870-6396e48e7c14

Are these sticky or fixed? Sticky elements will disappear as the body has position fixed as long as the drawer is open to avoid iOS bugs. If yours is fixed and you still experience that issue, please provide a codesandbox demo.

are fixed, I will produce a test in codesandbox to analyze

I have the same issue

I think i found the solution, you need to change min-h-[100vh] to h-screen in layout.tsx. From my own test, i found out that when the drawer is open, my page will resort back to the content height even if i set the page div to h-full, might be related to vaul adding css to the parent element to make the whole thing work
Codesandbox

Please use @jordant97' solution.

This still seems to be an issue, the proposed solution by @jordant97 doesn't do the trick. The Sandbox here reproduces it.
The problem lies in the fact that drawer changes the body.style.top to be the current scroll offset at trigger, which helps the animation but, the issue is, children elements that have position: 'fixed' aren't aware of the change, so therefore they are shown relative to the body.

This can be fixed by changing the offset of the child elements when changing body.
Also, thanks for this awesome package and your hard work! 🙏

Hello @emilkowalski!
I was curious whether @mannol suggestion could be implemented, as this issue is marked as closed while it's not solved :)

Hey @emilkowalski, thanks for the awesome library!
Just wanted to mention that issue is affecting me as well. The issue with the solution proposed by @jordant97 is that, while it does prevent fixed elements from going off the screen when the drawer opens, it also makes the div scrollable rather than the body, which results in other issues, such as:

The scrollbar rendering underneath fixed elements such as navigation
On macOS you don't get the same rubber-band animation when you scroll to the end of a div as you do when you scroll to the end of the body
Any code that relies on window.scrollY will break

I expect there may be other differences between overflow on the body and a div that I'm yet to come across.
One idea I had to fix this is a data attribute such as data-vaul-fixed that could be used to let vaul know which elements should have position style overridden when the drawer is open.
Until this is fixed I may have to resort to using the library without background scaling as I haven't found any other workarounds yet. Hopefully this issue can be re-opened as the background scaling looks really nice!

Why is this closed? This is still an issue.

@emilkowalski is there a fix planned for this? The issue still exists.


Generator functions don't work inside the repl

Notice a segfault:
>>> def generator -> int { yield 1; yield 2; yield 3 }
>>> let gen = generator()
>>> for var i in gen {
...     print(i, "\n")
... }
Segmentation fault

This might be because of function pointers not working properly inside the repl because they have the wrong size.

As it is non trivial to change the size of a function pointer just for the repl it might be a good idea to keep a map of allocated pointers to function data, that way it doesn't clash with real function pointers.


Implement HDR rendering + postprocessing pipeline

PlayCanvas by default renders everything in LDR to 8888 targets. Lighting in the shader takes place in linear HDR space, and at the end of the standard shader we apply tone-mapping to bring it to LDR range, and then apply gamma. Post-processing then takes place on top of that, usually directly in the gamma space.
I tried to enable HDR rendering and a bloom filter. The scene rendering takes place in linear HDR as before, and this is directly stored in 16F target in linear space. Great so far.
Then the bloom runs, again in linear space, but internally it uses 8888 targets for blurs, so the HDR is lost. And also, we’re missing a way to apply tone mapping at the end / or somewhere in the post-processing, and also at the end a linear space image is generated, which is very contrasty - we need to bring it to gamma space.
Additionally the bloom does not look very good .. possibly related to the fact it uses LDR targets, but could be something else as well.
exploration PR: https://github.com/playcanvas/engine/pull/4322

I wonder how well rgbm 8888 targets would work... Rgbm should be blurrable etc without having to decode/encode, but not sure what artifacts might result.

Yep, many implementations use RGBM and it's a viable / faster option, with some range limitations.

https://learnopengl.com/Guest-Articles/2022/Phys.-Based-Bloom

related https://github.com/playcanvas/engine/issues/5287

related https://github.com/playcanvas/engine/issues/4284

Ideally we'd implement in using this system when ready: https://github.com/playcanvas/engine/issues/5687

related: https://github.com/playcanvas/engine/pull/5833

I'd call this done in engine 2.1.0, closing.


add build badge

Who doesn't like badges?
📛 🦡

Codecov Report

Merging #327 (84f0d85) into main (7e4fa6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   99.98%   99.98%
=======================================
  Files         232      232
  Lines       12574    12574
=======================================
  Hits        12572    12572
  Misses          1        1
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4fa6a...84f0d85. Read the comment docs.


DBT-presto Glue support

I have a hive DBT project configured to use hive via presto. We are using AWS EMR and AWS Glue Catalogue. I have added recommended configuration for presto
hive.metastore-cache-ttl=0s hive.metastore-refresh-interval = 5s hive.allow-drop-table=true hive.allow-rename-table=true
When I'm running dbt run I'm getting  PrestoUserError(type=USER_ERROR, name=NOT_SUPPORTED, message="Table rename is not yet supported by Glue service")
Is there a way to configure dbt or dbt-presto to run different queries instead of renaming tables?

@oleksandrkovalenko This is really interesting. It is possible to reimplement/override the basic materializations, by copying-pasting-editing from dbt-presto into your own project. In particular, this is the offending bit of logic:
https://github.com/fishtown-analytics/dbt-presto/blob/81efb93ac809cd4874713825833cf63c6350e94e/dbt/include/presto/macros/materializations/table.sql#L41-L43
There's a larger question here that goes beyond table rename. We've always known that Presto's functionality varies tremendously based on the connector being used: transactions, atomic DML, metadata availability, etc. How should we think about structuring a dbt plugin for Presto, given the wide array of functional variety? Does it make sense to have a wide array of plugins, each for use with a different flavor of Presto/Trino/etc?

➕
We have had success reimplementing the table materialisation in our project:
{% materialization table, adapter='presto' -%}  {%- set identifier = model['alias'] -%}
  {%- set old_relation = adapter.get_relation(database=database, schema=schema, identifier=identifier) -%}  {%- set target_relation = api.Relation.create(identifier=identifier,                                                schema=schema,                                                database=database,                                                type='table') -%}
  {{ run_hooks(pre_hooks) }}
  {%- if old_relation is not none -%}      {{ adapter.drop_relation(old_relation) }}  {%- endif -%}
  -- build model  {% call statement('main') -%}    {{ create_table_as(False, target_relation, sql) }}  {% endcall -%}
  {{ run_hooks(post_hooks) }}
  {% do persist_docs(target_relation, model) %}
  {{ return({'relations': [target_relation]}) }}
{%- endmaterialization -%}

IIRC, we took this from the dbt-athena connector. Works fine, except for the downtime. We'll be looking to fix that with some view gymnastics in the next month or so.


CORGI-163 pulp modules

This add setup_pulp_relations task to loadproductdata (and celery beat) and a new loadpulpdata management command. Now when you call loadproductdata management command CDN_REPO relations are setup for all rhel_modules and SRPMS in a pulp repository. In addition Collector models are created using the module metadata in pulp.
When loading the builds in a stream using the loadpulpdata all builds from that stream in the relations table are processed using both slow_fetch_brew_build, and fetch_modular_build commands. The 'fetch_modular_build` command is required to unpack the Collector model relationships and populate the rhel_module RPM children relationships stored in the collector models in the core models.

Created a follow up task for keeping modules in CDN_REPOs up to date:
Created a MR  for ops repo. (component-registry-ops/-/merge_requests/55)

LGTM


Cannot update person custom fields

Hi,
I am just trying to update a person. It is working, except the custom fields of a person. Those are not handled by the PersonController. This seem to be a great bug in the code. When I add the following lines in the method PersonController::updateAPerson in line 455 it seems to work:
foreach ($options as $key => $value) {
    if (!in_array($key, ['id', 'name', 'owner_id', 'org_id', 'email', 'phone', 'visible_to'])) {
        $_parameters[$key] = $value;
    }
}

This is clearly a bug in this lib for me and makes the whole lib pointless/useless.

Hello @mschop . Currently, there is no support for Custom Fields in Persons or Deals. We are working on this and will provide this support in future versions of the library.
Thanks for your report.

Just ran into this same issue trying to update an organization. Making a direct API call works without any problem, but could you please state this in the SDK docs? Had to spend several hours doing tests and talking with Pipedrive support, before using the direct call as a last resource. The whole idea of using a SDK is to not have to develop your own connector.

This library is basically pointless without support for custom fields. @DenisButCheR can we get an up date please. It's starting to feel like this library has been abandoned by Pipedrive.

Okay got it. You can't update custom fields with this SDK. Can you please note it under your documentation? I wasted my time searching around for nothing

This also leaves out some fields that appear to be newer, such as the deal field expected_close_date.   I saw the nifty callOnBeforeRequest callback provided, and it would allow you to add more stuff to the parameters:
         //call on-before Http callback
        $_httpRequest = new HttpRequest(HttpMethod::PUT, $_headers, $_queryUrl, $_parameters);
        if ($this->getHttpCallBack() != null) {
            $this->getHttpCallBack()->callOnBeforeRequest($_httpRequest);
        }

But instead of fetching the parameters from the $_httpRequest using $_httpRequest->getParameters(), when the api call is sent, it just does this:
$response = Request::put($_queryUrl, $_headers, Request\Body::Form($_parameters));

Note $_parameters.  I fiddled around with trying to set the $_parameters array as a reference using &, but no luck there either.

Thank you for the patience and suggestions. The changes implemented in https://github.com/pipedrive/client-php/pull/48 should fix the issues with updating custom fields in deals, persons and organizations endpoints


Mia Market Unbreedable Message

When you attempt to buy an unbreedable Pokemon off the market, Mia should DM you something like "This Pokemon is unbreedable, are you sure you want to proceed? If so, retype your marketbuy command with 'confirm' after it" and require you to retype it like !marketbuy ID confirm
However, if you add confirm the first time you type it, it should instantly buy.
See WonderTrade for intended behavior

but it already shows unbreedable pokemon, that's like "hey wait I didn't realize it was bashful natured" when it legit says

To a new player, showing scissors in the top right corner means nothing and there's absolutely nothing that educates them that this means that. We just assume that they will be told and or ask about it

This has been resolved, the pokemon is specifically referred to as unbreedable and is coloured red in the new market.


Assessment Definitions: allow admin  to specify qualifier ids

Description
Currently the assessment definition admin screen only allows you to set the entity_kind for an assessment definition.
When creating definitions for things like measurable categories  the database (assessment_definition) allows you to set a qualifier so that the assessment only applies to a specific category.
We need to:

[ ] add a qualifier selector with support for:

[ ] Measurable Category
[ ] Legal Entity Relationship Kind

Resourcing
We intend to contribute this feature

Still a bit buggy.  But works well enough to be usable.


Remove setup.py

remove setuppy and update pyproject.toml
Need to move version into pyproject,
Need to update bumpversion.cfg to update that version

some errors from CI


[ISSUE #8096] fix log placeholder

Which Issue(s) This PR Fixes

Fixes #8096
Brief Description

use {} to replace %s %d
How Did You Test This Change?

Codecov Report
Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 42.80%. Comparing base (af43a3e) to head (645c938).
Report is 1 commits behind head on develop.

Files
Patch %
Lines

...mq/client/impl/producer/DefaultMQProducerImpl.java
0.00%
4 Missing :warning:

...g/apache/rocketmq/client/impl/MQClientAPIImpl.java
0.00%
2 Missing :warning:

...pl/consumer/ConsumeMessageConcurrentlyService.java
0.00%
2 Missing :warning:

.../apache/rocketmq/common/stats/MomentStatsItem.java
0.00%
2 Missing :warning:

.../rocketmq/client/impl/ClientRemotingProcessor.java
0.00%
1 Missing :warning:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
50.00%
1 Missing :warning:

...consumer/ConsumeMessagePopConcurrentlyService.java
0.00%
1 Missing :warning:

...impl/consumer/ConsumeMessagePopOrderlyService.java
0.00%
1 Missing :warning:

...he/rocketmq/controller/impl/DLedgerController.java
0.00%
1 Missing :warning:

...pache/rocketmq/test/client/rmq/RMQPopConsumer.java
0.00%
1 Missing :warning:

... and 1 more

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8097      +/-   ##
=============================================
- Coverage      42.89%   42.80%   -0.10%
+ Complexity     10364    10346      -18
=============================================
  Files           1270     1270
  Lines          88681    88681
  Branches       11397    11397
=============================================
- Hits           38042    37960      -82
- Misses         45949    46028      +79
- Partials        4690     4693       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


discord: user typing messages

Implements the discord part of #641

Cool, thanks!

Is it just me or does this cause an infinite loop of typing between two bridges?


feat: redisson/kafka-provider子插件录制和mock

feat: redisson/kafka-provider子插件录制和mock

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


#570066: includes test

So what's the alternative then? Tsd is crucial in build process, how do we ensure that the build will always be successful? It's also part of the testing.

I guess if it's crucial for the tests to run, we must keep it, because there's no way to force a global installation from package.json.


Specific Pull from Private Label

Looking for a way to pull from a specific PL rather than entire DB if possible.
Current behavior
CP pulls all data across all Reqs - want to filter to only a specific PL.
Expected behavior

Steps to replicate behavior

Screenshots
Current
Expected

This might not help but you can do that with the WordPress plugin https://wordpress.org/plugins/bh-staffing-job-listing-and-cv-upload-for-wp/

This issue has been escalated to internal support.


Question: Datatable: posibility to sort by nested fields inside the Object Array?

Sorry to ask this here, in case it is not the right place.
Is there anyposibility to use the Datatable with an array of object with the "order by " fields inside a subobject in the array.
Example:
Instead of this (demo example ):
JSON data:
[
  {
    "name": "Wing",
    "email"<EMAIL_ADDRESS>    "regDate": "2016-01-09T14:48:34-08:00",
    "city": "Paglieta",
    "age": 25
  },
  {
    "name": "Whitney",
    "email"<EMAIL_ADDRESS>    "regDate": "2017-01-23T20:09:52-08:00",
    "city": "Bear",
    "age": 32
  },
(....)

And later use:
 Name
and
 {{i.name}}
Is there any posibiliy to use this data?:
[ {
  "identifier": {"id":"EHRSignedID111",
                  "doctype":"report",
                  "datetime":"2017-02-07"
                } ,
   "extraData": "john"
  },
  {
    "identifier":  {"id":"EHRSignedID222",
                  "doctype":"reportAndDrugs",
                  "datetime":"2017-02-08"
                },
   "extraData": "albert"
  }
]

This works to show the internal data:

 {{i.identifier.id}}

But the order does not work, even if I try:
Id
or        Id
Any idea?
Thanks. And thanks for giving us this component

I solved by my self.
Yes it is perfectly possible, and it seems the source code is ready to do it. It wasnt working 100% in my situation by the |async and some data [] array issues with the variable.
But I saw the component is prepared to sort by inner fields if you use things like:
md2SortBy="identifier.id">Id
SOLVED


Add string and dictionary tests to 'swiftpr' catergory

Now that the Swift String and Dictionary formatters are fixed we want to
move those tests into the switpr category.

@swift-ci please test

If these are stable, just go for it Jonas!

I believe it's the end of Jonas's work day, so I'll go ahead and merge this.

Thanks @dcci & @vedantk!


Connection Error: Failed to Watch Scheduler Jobs in Dapr 1.14.4

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

What version of Dapr?

1.14.4
Expected Behavior

Scheduler jobs should be watched without connection errors.
Actual Behavior

Receiving the following error message:
level=error msg=“failed to watch scheduler jobs, retrying: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp [::1]:6060: connectex: No connection could be made because the target machine actively refused it."” app_id=web instance= scope=dapr.runtime.scheduler type=log ver=1.14.4
Steps to Reproduce the Problem

Run Dapr version 1.14.4 on a local machine using Docker Desktop.
Attempt to watch scheduler jobs.

Release Note

RELEASE NOTE: FIX Bug in runtime causing scheduler job watch failures due to connection errors.

Hi @ernstc - The error message suggests that the Dapr sidecar is having trouble connecting to the Scheduler service, likely because the Scheduler instance is down or unreachable. Do you know if the Scheduler might have been down when this error occurred?
Additionally, it could be related to the port not being open or listening, or there may be network or firewall issues preventing communication between the sidecar and the Scheduler. Could you provide more details about the environment where you encountered this issue?

Hi @cicoyle, I am running Dapr locally with Docker. It seems that the ports used by the scheduler were reserved by another process. Running the commands below in the Terminal with elevated privileges, I have been able to resolve the issue:

Uninstalled Dapr with dapr uninstall
Run net stop winnat
Run net start winnat
Install Dapr with dapr install

Now the issue is not happening again. So, I close the issue.

Hi,
I triec this workaround but it didn't work


False positives with unusual, non utf-8 characters

I encountered what seems to be a bug when trying to match a string against a list of strings which includes an element with non utf-8 characters. The following code should reproduce and illustrate the issue. Sorry if this isn't formatted correctly, I haven't submitted an issue on github before. I've included my local output below the raw code.
from rapidfuzz import fuzz, process

problem_string = '[Evaluation of the Filaria Detect™ IgG4 kit employing recombinant Wb123 antigen for diagnosis of lymphatic filariasis in BrazilEvaluación del estuche Detect™ para pruebas de anticuerpos antifiláricos IgG4, fabricado con el antígeno recombinante Wb123, para el diagnóstico de la filariasis linfática en Brasil].'
title = 'foo'
output = process.extract(title, problem_string, scorer=fuzz.partial_ratio, score_cutoff=90)
print(output)

problem_string = '[Evaluation of the Filaria Detect™ IgG4 kit employing recombinant Wb123 antigen for diagnosis of lymphatic filariasis in BrazilEvaluación del estuche Detect™ para pruebas de anticuerpos antifiláricos IgG4, fabricado con el antígeno recombinante Wb123, para el diagnóstico de la filariasis linfática en Brasil].'
problem_string = problem_string.encode('utf-8')
title = 'foo'

output = process.extract(title, [problem_string], scorer=fuzz.partial_ratio, score_cutoff=90)
print(output)

Local output:
[('o', 100.0, 9), ('o', 100.0, 12), ('f', 100.0, 13), ('F', 100.0, 19), ('o', 100.0, 48)]
[]

You are currently comparing  a string to a iterable of characters, which is probably not want you wanted to to. I assume, that you wanted to use:
problem_string = ['Evaluation of the Filaria Detect™ IgG4 kit employing recombinant Wb123 antigen for diagnosis of lymphatic filariasis in BrazilEvaluación del estuche Detect™ para pruebas de anticuerpos antifiláricos IgG4, fabricado con el antígeno recombinante Wb123, para el diagnóstico de la filariasis linfática en Brasil.']

instead of:
problem_string = '[Evaluation of the Filaria Detect™ IgG4 kit employing recombinant Wb123 antigen for diagnosis of lymphatic filariasis in BrazilEvaluación del estuche Detect™ para pruebas de anticuerpos antifiláricos IgG4, fabricado con el antígeno recombinante Wb123, para el diagnóstico de la filariasis linfática en Brasil].'

Note that utf8 encoding is not supported. I compare strings by comparing their code points. Utf8 uses multiple code points for a single characters, which would be interpreted as multiple characters by RapidFuzz.

Hi Max, thank you very much for responding. I think my original code was slightly unclear - I was putting the problematic test title in a list in the function call itself, so I can see why you may have thought it was being passed directly at a glance. I have updated my example to reproduce the issue to more clearly demonstrate how the trademark symbol is causing an issue, and how converting to a byte string gets rid of it. I'm not an expert on these matters, but the problem was persistent across a dataset of thousands, all of which would produce false positives. Applying the fix I've shown above fixed the problem, so I figured I would update my example in case it isn't some sort of mistake on my part.
Incidentally, it's my understanding that all python strings use UTF-8 encoding by default, so I'm not sure that's the issue - again, I could just be ignorant, I'm just a data analyst that  does a lot of coding in python, not a dev.
P.S. thank you for this library, it's fantastic.

Incidentally, it's my understanding that all python strings use UTF-8 encoding by default, so I'm not sure that's the issue

Python internally stores strings using a flexible representation, which is described in https://www.python.org/dev/peps/pep-0393/

I have updated my example to reproduce the issue to more clearly demonstrate how the trademark symbol is causing an issue, and how converting to a byte string gets rid of it

Thanks for the update. I can now reproduce this issue. I am not sure whats causing the bug yet (something in the get_matching_blocks implementation is broken).

This is fixed in the version 1.7.1.


Add build for tags, figure out OCI registry

should compile everything and docker build
should push the image to a path which is not a personal repo (right now, images have been pushed manually to gotwarlost/crossplane-function-cue:latest)

pushing is happening, need a better registry


Layout redesign phase 1 - rename

Phase 1 of #1609
Phase 1 - Rename

[X] Rename DOM ids
[X] Update skin and structure
[X] Rename statusbar symbols -> status
[X] Rename statusbar-container symbols -> statusbar
[X] Rename statusbar symbols / ns / file -> status-bar
[X] Rename statusbar behaviors -> status-bar
[X] Investigate / maybe rename sidebar symbols / ns / file -> left-bar
[X] Investigate / maybe rename bottombar symbols / ns / file -> bottom-bar
[X] Rename side-bar ns -> sidebar
[ ] Rename #status -> .content
[x] Investigate deprecation message on accessing deprecated variables
[x] Investigate deprecation message on accessing deprecated namespaces (seems unlikely).
[ ] Alert skin plugin writers to impending doom
[ ] Alert bar-contained plugin writers to impending doom

Closing as interest in this has stalled. Happy to reopen if someone wants to pick it up


New module to track contract deliverables and corresponding payments (EscalaC)

Feature specifically requested by Escala Capital.
It is not critical for "all" FIs but it is relevant for Escala to operate, so we must set it up but in the most leanest version… and if needed, revisit afterwards
@sebasdocp will conduct a design session with Escala's team.
[Note from @yolile ]
That way, FIs can make decisions on the credit line if the business is not meeting implementation milestones
Note that this will involve changes in the Application status workflow #39, as the application should remain "open" and visible to the FIs after the credit is granted.

@sebasdocp Is this issue still relevant? If not, briefly describe why not, then close the issue.


add support for an array of paths in  and matchPath

I piggybacked off of the tests written for matchPath() by @Shervanator at #5393, and I'm tackling the issue described by @mjackson at #5866.

Added support for arrays of paths to <Route> and matchPath()
Added a test case to demonstrate that match.path is a string
Added a test case to demonstrate that the component doesn't remount on switches between two matching paths

I'm happy to add docs and examples if everybody is satisfied with the behavior. Let me know if you think any changes are in order as well.

Any word on getting this merged? Looks like it's been sitting a while but would be a great quality of life change for us at Discord.

Should we consider to merge this pr?

Would also love to see this merged, definitely willing to help out if it needs any more work.

@pshrmn @timdorr @mjackson Any thoughts on this PR? Would love to get this merged since this would probably fix the issues of components getting re-mounted on route change.

While wait for https://github.com/ReactTraining/react-router/issues/5866 when this PR is already working?

+1

@mjackson @pshrmn I've rebased this onto the tip of master and added some documentation. Let me know if you need anything else from me to merge this.

Just FYI everyone, this was just released in version 4.4.0-beta.4. You can try it out now by installing from the next tag:

npm install react-router-dom@next react-router-native@next

Hey! That looks nice, but what about support of RegExp in paths?! react-route is still not fully same as it is in https://github.com/pillarjs/path-to-regexp, which supports RegExp

@kevich https://github.com/ReactTraining/react-router/issues/6418#issuecomment-432866435


Error 3070000: WASM Exception in nodeos v2.0.0

[root@ORACLEDB cleos]# ./cleos set contract eosio /home/oracle/eosio.contracts/build/contracts/eosio.system/
Reading WASM from /home/oracle/eosio.contracts/build/contracts/eosio.system/eosio.system.wasm...
Publishing contract...
Error 3070000: WASM Exception
Error Details:
env.preactivate_feature unresolveable
pending console output:
[root@ORACLEDB cleos]# ./cleos set contract eosio /home/oracle/eosio.contracts/build/contracts/eosio.bios/
Reading WASM from /home/oracle/eosio.contracts/build/contracts/eosio.bios/eosio.bios.wasm...
Publishing contract...
Error 3070000: WASM Exception
Error Details:
env.set_proposed_producers_ex unresolveable
pending console output:
cleos version: v2.0.0-rc3-0eb83602d37c8a96b8811b636160aee1da94787f-dirty
nodeos version: v2.0.0-rc3
eosio.cdt: 1.7.0-rc1
eosio.contract: v1.9.0-rc1
I have tried the way described in Fix bios boot tutorial python script due to changes in 1.8.x and above #8287, but it doesn't work.
[root@ORACLEDB build]# curl -X POST http://<IP_ADDRESS>:8888/v1/producer/schedule_protocol_feature_activations -d '{"protocol_features_to_activate":["0ec7e080177b2c02b278d5088611686b49d739925a92d9bfcacd7fc6b74053bd"]}'
{"code":404,"message":"Not Found","error":{"code":0,"name":"exception","what":"unspecified","details":[{"message":"Unknown Endpoint","file":"http_plugin.cpp","line_number":341,"method":"handle_http_request"}]}}

This surprised me too when I recently encountered it. When EOSIO/eosio.contracts#349 was merged, the bios contract now requires that WTMSig be enabled. Of course that causes a chicken and egg problem because you need a system contract present to enable a protocol feature.
EOSIO/eosio.contracts#363 is a new system contract that is even further stripped down so it can be loaded and active features before loading the bios contract. This hasn't been merged yet but is the intended fix for this problem.
For now, the proper procedure for a new chain is to load an older bios contract that doesn't require WTMSig. Maybe documentation and such needs to be updated?

Note documentation for 2.0 for this is in work here: https://github.com/EOSIO/eos/pull/8328

@spoonincode @heifner I see.
Thank you for your reply.

I'd like it keep this open until at least the doc update is merged

Closing this because doc updates were merged to 2.0


Provide some guidance for coming up with default histogram buckets for various metrics

Coming up with default histogram buckets for various metrics can be challenging, as we've seen in #274.
I'd like to propose some guidance for coming up with default histogram buckets which we can lean on in each time the issue of defining default histogram buckets comes up.
Proposal:

If values align with service timings, use our default buckets, translated from millis to seconds, [ 0, 0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10 ] (dropping the zero bucket?)
Otherwise determine roughly the smallest and largest buckets that you care about, e.g. <0.01 seconds and >10 seconds, and use an exponential range in between (consider using base 2 if you need higher granularity and base 10 if you need lower granularity).

These would only be recommendations, and so if there is compelling reason to come up with a completely custom set of buckets for a particular metric that would always be ok.

another option could be to follow the pattern [ .1, .25, .5, .75, 1] in between the low and high buckets, e.g.
[ 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10 ]
and another similar option with less buckets:
[ 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1, 2.5, 5, 10 ]
or even fewer:
[ 0.01, 0.05, 0.1, 0.5, 1, 5, 10 ]

Generalizing your last comment into an algorithm we could encode into the spec might look like:

Start with base 10 "outer" bucket boundaries.
How many and which base 10 orders of magnitude do measurements typically span? E.g. two orders of magnitude (three buckets) starting at 1 would be [1, 10], or [10, 100]if starting at ten. Three order of magnitude (four buckets) starting at 1 would be[1, 10, 100]or[10, 100, 1_000]` if starting at ten.
Decide how many inner buckets you need to get a decent distribution useful to most users most of the time. For each outer bucket boundary (skipping the first), the even bucket boundaries are distributed evenly between [0, out_bucket_bound]. Maybe we constrain it to multiples of two so the buckets boundaries don't fall on numbers with infinitely repeating decimals. For example:

One inner bucket boundary with two outer bucket orders of magnitude starting at 1 yields: [1, 5, 10]
One inner bucket boundary with three outer bucket order of magnitude starting at 1 yields: [1, 5, 10, 50, 100]
Three inner bucket boundaries with two outer bucket orders of magnitude starting at 1 yields: [1, 2.5, 5, 7.5, 10]
Three inner bucket boundaries with three outer bucket orders of magnitude starting at 1 yields: [1, 2.5, 5, 7.5, 10, 25, 50, 75, 100]

The number of buckets becomes equal to orders_of_magnitude * (inner_bucket_boundaries + 1)

The advantage of laying down some convention like this is while there are still domain specific decisions to debate like "how many orders of magnitude is typical?" and "how many inner buckets yield a useful distribution for most users?", it does narrow the solution space quite a bit. It also produces bucket boundaries which are nice even numbers with an intuitive explanation.


I don't understand, does this use openai API or no? does it need cpu or what I Don't understand, please add to readme or docs

I don't understand, does this use openai API or no? does it need cpu or what I Don't understand, please add to readme or docs

Thanks for the feedback! @dorbanianas , would you be interested in helping make the README more clear wrt this?

OpenDevin supports multiple LLMs, but we should make this clearer in the README. I have opened an issue for this!
https://github.com/OpenDevin/OpenDevin/issues/644

@neubig yes I can take care of this 😉


Add leading and trailing options for debounce helper #2380

Q
A

Fixed Issues?
Fixes #2380

Patch: Bug Fix?
No

Major: Breaking Change?
No

Minor: New Feature?
Yes

Tests Added + Pass?
Yes

Any Dependency Changes?
No

This adds leading and trailing options to the debounce helper, as suggested in the linked issue. The first parameter to debounce can now be an options object of format { delayLength: number; leading?: boolean; trailing?: boolean }, or for backwards compatibility can still just be a number specifying delayLength.
leading defaults to false and trailing defaults to true. The behaviour in this case should be unchanged compared to on main.
The behaviour of "leading" and "trailing" should essentially match how it works in lodash.

@neurosnap I just wanted to gently bump this - do you have any concerns about this change? Or are there any further changes required?

Thanks for the bump.  I haven't forgotten about this PR, just need to make time to fully review and test it.  I'll try to get this reviewed by end of week.


🌱 Make bootstrap script able to not deploy

Summary
This PR adds an option to the bootstrap script to skip deploying kcp and KubeStellar, to focus only on fetching them.
This PR also updates the commands doc to make all the headings get indexed and remove documentation of the curl-to-bash scripts that we are no longer recommending to users.
Related issue(s)
Fixes #

/cc @francostellari
/cc @dumb0002
@ronenkat

@MikeSpreitzer your changes look good to me but I will let @ronenkat have the final say.

@ronenkat can you review and see if this satisfies your needs?

@ronenkat added you as contributor so that you can lgtm

/lgtm


fix parsing of leading union/intersection operator

Fixes: #30995
A leading | or & is now part of the union/intersection type's range.
If there's a leading operator and only one constituent type, we still parse a union/intersection type.

Closing in favor of #31017

Reopening as this PR actually fixes the floating token issue if there's no further operator

@rbuckton I added the test case you requested in https://github.com/microsoft/TypeScript/pull/31017#discussion_r281809682: declaration emit ignores leading comments of the leading operator.

Looks good, thanks!


Fix a number of issues in sysV init script.

When using the sysV init script the service actions return codes were not being properly set.
What this means is that the init script would return successfully even when, for instance, it failed to load the configuration and the process wasn't left running.
As the influx process doesn't fork itself we're waiting for the pid file to be created and checking the status of the process afterwards.

Thanks @miguelcnf -- we'll take a look. Have you signed the CLA?

Hi @otoolep, I have now! :)
Also, just pushed a couple more fixes, mainly the ability to run as a non-root user.

I tested this, and it looks good. +1

Failure to launch looks good:
root@script-test:~# service influxdb start
Starting the process influxd [ OK ]
influxd process failed to start [ FAILED ]
root@script-test:~# echo $?
1

LGTM :+1:

Thanks @miguelcnf

Thanks!


add approval values status to interaction table for Interaction by Drug

Interaction results for drug do not currently show approval status, this should be added to the table.

also, indications field. (some interactions may have many possible indications within interaction attributes field. top level is sufficient for now)


The value is updated at the wrong index

Steps to reproduce the issue:

Enter some code (123456) for example at https://codesandbox.io/s/react18-input-otp-0nxzx7?file=/src/App.js
Try to update any field

Actual result:
The wrong field is updated

I will have a look and fix this. Thanks for reporting.

@goonerDp This is fixed.


Does not work in iPad Air 4th generation

IOS 14.7.1
recognises QR code ok (from camera or file) but after selecting add to wallet reproducible message:
"Safari cannot download this file"

As far as I know, the iPad does not really have the wallet app or the integration is incomplete. Can you try it on your iPhone instead?

I confirm works perfectly on iphone.
iPad has wallet but probably slightly differently implemented as you said
Sent from my iPad

On 3 Aug 2021, at 15:22, Marvin Sextro @.***> wrote:

As far as I know, the iPad does not really have the wallet app or the integration is incomplete. Can you try it on your iPhone instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Allow dynamically specify plan-preview command timeout from pipectl

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2297
Does this PR introduce a user-facing change?:

Allow dynamically specify plan-preview command timeout from pipectl

LGTM, but test for pipedstatsbuilder seems to be failed
/lgtm

@khanhtc1202 I think that is a flaky test. I have seen its failures recently.

@khanhtc1202 I think that is a flaky test. I have seen its failures recently.

sorry, lets me check it 👀

🚀
/approve


support transaction statement in diagram, code lenses, etc.

Currently, transaction blocks are not getting rendered in Diagram.
Furthermore, inside transaction body, endpoint code lense is not working and even the endpoints declared there won't get rendered.
It seems we need to update existing visitors of ours to visit transaction blocks.

We can use reflection to write a generic function which visits all block nodes
https://github.com/ballerina-platform/ballerina-lang/blob/master/language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/command/CommandUtil.java#L560

Relevant Language server capabilities have been addressed. Hence removing the label

Diagramming capabilities are  no longer valid for Swan Lake release. Hence, closing it.

Diagramming capabilities are  no longer valid for Swan Lake release. Hence, closing it.


CVXCanon LinOp_data_ndim_set error

On the 1.0 branch I'm getting the following error trying to solve a simple problem with cvxpy. CVXcanon was built from source at master:
=> python pdhg_qp.py
Traceback (most recent call last):
  File "pdhg_qp.py", line 5, in <module>
    import cvxpy
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/__init__.py", line 21, in <module>
    from cvxpy.atoms import *
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/atoms/__init__.py", line 20, in <module>
    from cvxpy.atoms.geo_mean import geo_mean
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/atoms/geo_mean.py", line 23, in <module>
    from cvxpy.utilities.power_tools import (fracify, decompose, approx_error, lower_bound,
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/utilities/power_tools.py", line 21, in <module>
    from cvxpy.atoms.affine.reshape import reshape
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/atoms/affine/reshape.py", line 20, in <module>
    from cvxpy.atoms.affine.affine_atom import AffAtom
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/atoms/affine/affine_atom.py", line 25, in <module>
    from cvxpy.CVXcanon.python import canonInterface
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/CVXcanon/python/canonInterface.py", line 32, in <module>
    import cvxpy.CVXcanon.python.CVXcanon as CVXcanon
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/CVXcanon/python/CVXcanon.py", line 229, in <module>
    class LinOp(_object):
  File "/Users/bodonoghue/miniconda2/envs/python27/lib/python2.7/site-packages/cvxpy-1.0.0-py2.7-macosx-10.6-x86_64.egg/cvxpy/CVXcanon/python/CVXcanon.py", line 247, in LinOp
    __swig_setmethods__["data_ndim"] = _CVXcanon.LinOp_data_ndim_set
AttributeError: 'module' object has no attribute 'LinOp_data_ndim_set'

Yeah this happens sometimes to me too. We're still debugging. One possible cause is that CVXcanon is now part of CVXPY. You shouldn't be installing CVXcanon separately.


Can you provide the download dataset in google drive or pan.baidu?

I am interesting in this project, but can not visit dropbox in the web, can you provide dataset in the title, thanks

Hi, thank you for your interest.
Here is the google drive link for Brueghel: https://drive.google.com/file/d/1dHV_xURCVxQjgtg3pZl3zt2aRlLwhjnS/view
For LTLL and Oxford, they can be downloaded from their official sites.
Hope it helps.

Thank you !


README update to point to correct alpha issues milestone

Relatively minor update, just correcting the URL while I'm making the tests
go green on my end again.

\o/ :shipit:


M5stack cording -

Hi,
I'm trying to run the analogmeter example and hitting an error for the coreink.
divide by zero error, could this be that the size of the screen is not recognised?

[env:m5stack-coreink]
platform = espressif32
board = m5stack-coreink
framework = arduino
lib_deps =
<EMAIL_ADDRESS><EMAIL_ADDRESS>monitor_speed =115200
monitor_filters = esp32_exception_decoder
--- Error
rst:0xc (SW_CPU_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 188777542, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13104
load:0x40080400,len:3036
entry 0x400805e4
Guru Meditation Error: Core  1 panic'ed (IntegerDivideByZero). Exception was unhandled.
Core  1 register dump:
PC      : 0x400d246a  PS      : 0x00060830  A0      : 0x800dcb39  A1      : 0x3ffb27f0
A2      : 0x3ffc2564  A3      : 0x3ffc2560  A4      : 0x3ffc2584  A5      : 0x00000000
A6      : 0x3ffbdb68  A7      : 0x00000000  A8      : 0x800d2463  A9      : 0x3ffb27a0
A10     : 0x00000000  A11     : 0x00000000  A12     : 0x00000000  A13     : 0x3ffc255c
A14     : 0x3ffc2584  A15     : 0x00000015  SAR     : 0x00000006  EXCCAUSE: 0x00000006
EXCVADDR: 0x00000000  LBEG    : 0x4008486d  LEND    : 0x40084875  LCOUNT  : 0x00000027
Backtrace: 0x400d2467:0x3ffb27f0 0x400dcb36:0x3ffb2820
#0  0x400d2467:0x3ffb27f0 in lgfx::v1::LGFXBase::width() const at .pio/libdeps/m5stack-coreink/M5GFX/src/lgfx/v1/LGFXBase.hpp:284
(inlined by) setup() at src/main.ino:160
#1  0x400dcb36:0x3ffb2820 in loopTask(void*) at /.platformio/packages/framework-arduinoespressif32/cores/esp32/main.cpp:42

Hello, @yukimach
I have tried it here and it works fine with no problems.
I have a puzzling point in your ini.
Why do you depend on the Core-Ink library?
Have you made any changes to the source code?
Have you removed the M5GFX init?

I removed the core-ink library now to avoid confusion. the core-ink library was working.
Espressif  platform 5.3.0. (I initially tried with 6 but also same problem). I've reloaded M5GFX a few times also to make sure.
M5GFX display;
display.begin();
has not been removed from the main file.

[env:m5stack-coreink]
platform = espressif32
board = m5stack-coreink
framework = arduino
lib_deps =
<EMAIL_ADDRESS>
monitor_speed =115200
monitor_filters = esp32_exception_decoder
I copy paste the code for analogmeter example, no modification.

Hmmm,,, To check the situation, please run the following program with debug logging enabled.
#include <Arduino.h>
#include <M5GFX.h>
M5GFX display;

void setup(void)
{
  delay(100);
  display.begin();
  printf("w:%d h:%d\n", display.width(), display.height());
}

void loop(void)
{
  display.fillCircle(rand()%display.width(), rand()%display.height(), 16, rand());
  delay(4000);
}

Check the output of the serial monitor to see if M5GFX detects CoreInk.
rst:0x1 (POWERON_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 188777542, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0030,len:1344
load:0x40078000,len:13516
load:0x40080400,len:3604
entry 0x400805f0
[��mum����2-hal-cpu.c:214] setCpuFrequencyMhz(): PLL: 480 / 2 = 240 Mhz, APB: 80000000 Hz
[   144][I][M5GFX.cpp:522] init_impl(): [M5GFX] [Autodetect] load from NVS : board:6
[   156][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:70 = 00f00000
[   157][I][M5GFX.cpp:682] autodetect(): [M5GFX] [Autodetect] M5StackCoreInk
w:200 h:200

Thanks! Yes I think it's this, I was trying to figure out how the library recognizes the board and dimensions, it looks like it's getting a 0 for width and height.
w:0 h:0
Guru Meditation Error: Core  1 panic'ed (IntegerDivideByZero). Exception was unhandled.
Core  1 register dump:
PC      : 0x400d1b16  PS      : 0x00060a30  A0      : 0x800db21c  A1      : 0x3ffb2800
A2      : 0x3ffc25c0  A3      : 0x00000000  A4      : 0x00000000  A5      : 0x00000004
A6      : 0x3ffb8874  A7      : 0x80000001  A8      : 0x800d1b0e  A9      : 0x3ffb27e0
A10     : 0x5851f42d  A11     : 0x3ffb88d4  A12     : 0x00000000  A13     : 0x00000000
A14     : 0xffffffff  A15     : 0x00000001  SAR     : 0x00000017  EXCCAUSE: 0x00000006
EXCVADDR: 0x00000000  LBEG    : 0x4008488d  LEND    : 0x40084895  LCOUNT  : 0x00000027
Backtrace: 0x400d1b13:0x3ffb2800 0x400db219:0x3ffb2820
#0  0x400d1b13:0x3ffb2800 in lgfx::v1::LGFXBase::width() const at .pio/libdeps/m5stack-coreink/M5GFX/src/lgfx/v1/LGFXBase.hpp:284
(inlined by) loop() at src/main.ino:14
#1  0x400db219:0x3ffb2820 in loopTask(void*) at /.platformio/packages/framework-arduinoespressif32/cores/esp32/main.cpp:50

Please enable debug logging.
platformio.ini
build_flags = -DCORE_DEBUG_LEVEL=5

And please post all logs prior to the error.

rst:0xc (SW_CPU_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 188777542, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13104
load:0x40080400,len:3036
entry 0x400805e4
[    17][D][esp32-hal-cpu.c:244] setCpuFrequencyMhz(): PLL: 480 / 2 = 240 Mhz, APB: 80000000 Hz
[   150][I][M5GFX.cpp:522] init_impl(): [M5GFX] [Autodetect] load from NVS : board:0
[   166][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:70 = 00f00100
[   180][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:04 = 00000000
[   195][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:70 = 00f00100
[   209][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:04 = 00000000
[   224][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:70 = 00f00100
[   238][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:04 = 00000000
[   252][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:70 = 00f00100
[   266][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:04 = 00000000
[   281][D][M5GFX.cpp:484] _read_panel_id(): [M5GFX] [Autodetect] read cmd:70 = 00f00100
[   282][I][M5GFX.cpp:589] init_impl(): [M5GFX] [Autodetect] save to NVS : board:0
w:0 h:0
Guru Meditation Error: Core  1 panic'ed (IntegerDivideByZero). Exception was unhandled.

I apologies. I have found the cause of the problem and will correct it. Please wait a moment.
Have you recently purchased a CoreInk? It appears that a newer revision of the driver IC is being used than the one I own. As a result, there is a discrepancy in the determination results and the detection is failing.
I would change the decision formula so that the new driver IC does not cause an error.

Amazing, thank you so much. Yes I just purchased it last month I think.

I have now updated the 'develop' branch.
Please check the operation with the develop version instead of the release version.
platformio.ini
lib_deps = https://github.com/m5stack/M5GFX.git#develop

If there are no problems, it will be included in the next update.

I manually changed it on my end and I confirm the fix works on my board now.
The revision has yet to be released for platformio.

I manually changed it on my end and I confirm the fix works on my board now.
The revision has yet to be released for platformio.

I confirm the develop branch also runs on my board.


fix(app): Remove polling mechanism and fix removeEventListeners refer…

Bugfix: Fix the Event Listeners reference
Perf: Use alternative of polling mechanism

Coverage increased (+3.7%) to 94.172% when pulling ab316ce9fd5f239dc5530932ad107c9cecae54af on pntgupta:fix-remove-polling into 3bd3cf6987fc1dbda3cde243cc62dbad88946f85 on wingify:master.


password check

how can I check if the password is correct when connecting to the database?
Now, if the password is not correct, there are not even any errors

You have to do a query first - you should then get an error SQLITE_NOTADB: file is not a database. Note that you can't distinguish between an incorrect password and a corrupted file - both will give the same error.

For reference, this is the startup logic that I'm using:
      if (key) {
        await db.run(`PRAGMA key = '${key}'`);
        // Migrate to latest defaults
        await db.run(`PRAGMA cipher_migrate`);
        // Confirm that encryption is enabled
        const providerResult = await db.get('PRAGMA cipher_provider');
        if (providerResult == null || providerResult.cipher_provider != 'openssl') {
          throw new Error(`SQLCipher is not enabled - cannot encrypt database.\nProvider: ${JSON.stringify(providerResult)}`);
        }
      }
      // Validate the key (or lack of key)
      try {
        await db.run('SELECT count(*) FROM sqlite_master');
      } catch (err) {
        if (/SQLITE_NOTADB/.test(err.message)) {
          throw new Error(`Database key is invalid, or the database is corrupted.`);
        } else {
          throw err;
        }
      }

thank you
I already found a better solution


There is a problem in the running process to ask you

Hi, how are you? This is a really great project. I have used unity to display your project on the web side, and the effect is really super good.
But currently I have two problems, I have an error problem during the testing process:
Sort.compute: Kernel index (7) is invalid
This seems to be related to the kernel in the Sort.app code, I see you defined 12 kernels, if I want to reduce to 6 what parts need to be changed
Second, I was particularly curious about how to generate unity usable files when importing splat files
Looking forward to your specific reply, I will be very grateful, it will help me a lot!!

Sort.compute: Kernel index (7) is invalid

You can safely ignore this warning if there are no noticeable issues with the effect.

Second, I was particularly curious about how to generate unity usable files when importing splat files

I'm sorry, but I didn’t quite understand what you mean. Could you clarify what you mean by “usable files”?

Sort.compute: Kernel index (7) is invalid

You can safely ignore this warning if there are no noticeable issues with the effect.

Second, I was particularly curious about how to generate unity usable files when importing splat files

I'm sorry, but I didn’t quite understand what you mean. Could you clarify what you mean by “usable files”?

Thank you very much for your reply. Now I want to modify the sort.compute file, because I see you defined 12 kernels, but now I will get an error during the running process, so it cannot be displayed. I want to know where the index of these kernels is called, how should I solve this problem? I am looking forward to your reply, which will help our project go further

Sort.compute: Kernel index (7) is invalid

You can safely ignore this warning if there are no noticeable issues with the effect.

Second, I was particularly curious about how to generate unity usable files when importing splat files

I'm sorry, but I didn’t quite understand what you mean. Could you clarify what you mean by “usable files”?

Thank you very much for your reply. Now I want to modify the sort.compute file, because I see you defined 12 kernels, but now I will get an error during the running process, so it cannot be displayed. I want to know where the index of these kernels is called, how should I solve this problem? I am looking forward to your reply, which will help our project go further


OLS-autocomplete link modification

I was playing a little bit with the OLS-autocomplete examples. This is what I was using:
<form id="local-search" name="local-search" action="http://www.ebi.ac.uk/ols/search" method="get">
  <fieldset>

        <input style="font-weight: normal" size="35" type="text" name="q" data-olswidget="select" data-olsontology=""
               data-selectpath="http://www.ebi.ac.uk/ols/" olstype="" id="local-searchbox"
               placeholder="Enter the term you are looking for" class="ac_input">
        </input>

      <input type="submit" value="Search" class="submit">
      </input>

  </fieldset>
</form>

Here is my use case: I would like to able to search for terms in OLS, but when I click on the term I would like to do a search with that in the Complex-Portal. Currently, when I click on a term it is taking me to the regarding OLS page. But, if I change the action="http://www.ebi.ac.uk/ols/search" from <form id="local-search" name="local-search" action="http://www.ebi.ac.uk/ols/search" method="get"> to action="https://complex-portal.github.io/complex-portal-view/complex/search?quer", I can redirect it to the Complex-Portal using the submit button.
Can I somehow modify the destination for the click event as well?

Hey ya! Please look at the example2.html (And check the console log output). This should do what you want.
If you select a term it should print you all available information to the console log. In a separate step I overwrite the ' onSubmitClick()' event (Just printing an alert message in the example) - but you should be able to do with it whatever you want.

Yes, that is almost all I need! 👍 Can I retrieve the term itself as well? Or is it only available in the URL of the iri field?

I just made some changes so you can get your requested human readable term as well from the widget. Please check the updated example 2, it should do now what you asked for.
(However, keep it mind that IRIs are way more specific - and if you need ontology help in general, you know where to find us)
Cheers.

I think this issue can be close. Please post, re-open or create another issue if you feel otherwise!


Incorrectness with lambda functions and scoping in .apply

Describe the issue:
When using lambda functions with variables, the scope seems to resolve lazily, leading to incorrect behavior. The below code currently runs without warning or error and outputs incorrect values in the dataframe. I wanted to report this because I think this should at least warn you, if possible, though ideally it would work. I was able to get a workaround by using lambda x, y:  and passing in y to the apply function.
Minimal Complete Verifiable Example:
import dask.dataframe as dd
import pandas as pd

kingdoms = {"Mammal": ["Dog", "Cat"],
            "Reptile": ["Lizard"],
            "Insect": ["Ant"]}

df = pd.DataFrame({"Species": ["Dog", "Cat", "Lizard", "Ant"]})
ddf = dd.from_pandas(df, npartitions=1)
for kingdom, species in kingdoms.items():
    ddf[kingdom] = ddf["Species"].apply(
        lambda x: 1 if x in species else 0,
        meta=(None, "int64")
    )
print(ddf.compute())

>>>  Species  Mammal  Reptile  Insect
0     Dog       0        0       0
1     Cat       0        0       0
2  Lizard       0        0       0
3     Ant       1        1       1

Anything else we need to know?:
I know there are workarounds for this, and this isn't a call for coding help. I wanted to see if there was something that could be done, or at least a warning could be issued to avoid this happening, since currently it deviates from the pandas behavior, as well as what is expected.
Environment:

Dask version: 2023.3.1
Python version: 3.10.10
Operating System: linux
Install method (conda, pip, source): pip

This is an issue with Python itself, not with Dask.  In these cases we
recommend using proper functions.  Their scoping rules line up more with
user expectations.
On Mon, Mar 20, 2023 at 12:44 PM Matt @.***> wrote:

Describe the issue:
When using lambda functions with variables, the scope seems to resolve
lazily, leading to incorrect behavior. The below code currently runs
without warning or error and outputs incorrect values in the dataframe. I
wanted to report this because I think this should at least warn you, if
possible, though ideally it would work. I was able to get a workaround by
using lambda x, y: and passing in y to the apply function.
Minimal Complete Verifiable Example:
import dask.dataframe as ddimport pandas as pd
kingdoms = {"Mammal": ["Dog", "Cat"],
"Reptile": ["Lizard"],
"Insect": ["Ant"]}
df = pd.DataFrame({"Species": ["Dog", "Cat", "Lizard", "Ant"]})ddf = dd.from_pandas(df, npartitions=1)for kingdom, species in kingdoms.items():
ddf[kingdom] = ddf["Species"].apply(
lambda x: 1 if x in species else 0,
meta=(None, "int64")
)print(ddf.compute())

Species  Mammal  Reptile  Insect0     Dog       0        0       01     Cat       0        0       02  Lizard       0        0       03     Ant       1        1       1

Anything else we need to know?:
I know there are workarounds for this, and this isn't a call for coding
help. I wanted to see if there was something that could be done, or at
least a warning could be issued to avoid this happening, since currently it
deviates from the pandas behavior, as well as what is expected.
Environment:

Dask version: 2023.3.1
Python version: 3.10.10
Operating System: linux
Install method (conda, pip, source): pip

—
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/10092, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTBFGSFFUZE7JTTO26TW5CJQZANCNFSM6AAAAAAWBNEL7A
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

for kingdom, species in kingdoms.items():
    def f(x):
        ...
    ddf[kingdom] = ddf["Species"].apply(
        f,
        meta=(None, "int64")
    )

right, i wanted to bring it to your attention because it deviates from the pandas behavior quietly. I know dask uses cloudpickle in the background, and a quick test shows that cloudpickle does work when this is done immediately. Perhaps theres something there?
import dask.dataframe as dd
import pandas as pd
import cloudpickle

kingdoms = {"Mammal": ["Dog", "Cat"],
            "Reptile": ["Lizard"],
            "Insect": ["Ant"]}

df = pd.DataFrame({"Species": ["Dog", "Cat", "Lizard", "Ant"]})
ddf = dd.from_pandas(df, npartitions=1)

pickled_functions = {}
for kingdom, species in kingdoms.items():
    pickled_functions[kingdom] = cloudpickle.dumps(lambda x: 1 if x in species else 0,)
    ddf[kingdom] = ddf["Species"].apply(
        lambda x: 1 if x in species else 0,
        meta=(None, "int64")
    )
for k in pickled_functions:
    f = cloudpickle.loads(pickled_functions[k])
    print(k)
    print(f("Dog"))
print(ddf.compute())

>>>
Mammal
1
Reptile
0
Insect
0

  Species  Mammal  Reptile  Insect
0     Dog       0        0       0
1     Cat       0        0       0
2  Lizard       0        0       0
3     Ant       1        1       1

It isn't a cloudpickle thing, it's a lazy thing.  You're not using cloudpickle in that example.  Everything is running in the same process in threads.
The difference is when .compute is called.
Anyway, there isn't anything we can do about lambdas doing lazy scope assignment.  This is a pure Python issue.  There is no bugfix we could apply except in CPython.

ok, that makes sense. thanks for taking a look!

@mdering I'm going to close the issue, but feel free to reopen if you need further help. Thank you!


Follow me

@catch-twenty-two Replacing your PR with this rebased and formatted version.

@catch-twenty-two What is the current state of this right now? Do you have an updated video?

Matching QGC PR, not merged yet and with CI errors: https://github.com/mavlink/qgroundcontrol/pull/2817

@LorenzMeier Great thanks for doing that, No updated video yet. I did go out with friend to test it on a bicycle so I could see how well it tracked a fast moving object and all went well.  I'll do one more test tomorrow with all the updated changes and then call it good.  I'll also I'll see if I can get some more video if possible.

@catch-twenty-two Is there a bug?
void FollowTarget::update_position_sp(bool use_velocity, bool use_position)
{
    // convert mission item to current setpoint

    struct position_setpoint_triplet_s *pos_sp_triplet = _navigator->get_position_setpoint_triplet();

    // activate line following in pos control if position is valid

    pos_sp_triplet->previous.valid = use_position;
    pos_sp_triplet->previous = pos_sp_triplet->current;
    mission_item_to_position_setpoint(&_mission_item, &pos_sp_triplet->current);
    pos_sp_triplet->current.type = position_setpoint_s::SETPOINT_TYPE_FOLLOW_TARGET;
    pos_sp_triplet->current.position_valid = use_position;
    pos_sp_triplet->current.velocity_valid = use_velocity;
    pos_sp_triplet->current.vx = _current_vel(0);
    pos_sp_triplet->current.vy = _current_vel(1);
    pos_sp_triplet->next.valid = false;
    _navigator->set_position_setpoint_triplet_updated();
}

pos_sp_triplet->current.valid is miss? control_auto couldn't work well if we missed it..

@LorenzMeier Happy to report I went out today and everything worked great.  I have some video but my mom took it so I'll have to see if it's worth posting.

pos_sp_triplet->current.valid is miss? control_auto couldn't work well if we missed it. when i switch to follow target mode, the vehicle isn't moving at all.

Hmmm...you are right.  I'm actually surprised my tests went okay today odd.... Good catch.  I'll have to fix it and retest tomorrow.

I always love videos, so I hope it turns out well!

My suggestion for basic follow me support would be to maintain the current height of the Vehicle. Also mantain the current distance/positioning from the target calculated from the first follow me message.

I'm no filmmaker... which is very apparent from this video, it contains:

Me walking with follow me mode activated.
My mother who I recruited to help me, walking with follow me mode activated (all the rest of my friends are at work on weekday mornings, imagine that! :) )
Me riding my Xooter Scooter that I used to get around San Francisco, with follow me activated.

There was a slight wind blowing probably around 7-10 mph the frame type is a DJI style 330.

I always love videos, so I hope it turns out well!

@LorenzMeier Did it turn out well?  No. But hopefully your love of videos makes up for that. lol
https://youtu.be/RxDL4CtkzAQ

Awesome, merged! Now on to the QGC merge, @DonLakeFlyer!


[FLINK-7388][DataStream API] ProcessFunction.onTimer() sets processing time as timestamp

What is the purpose of the change
Before Flink 1.4.0, when called from a processing-time timer, the ProcessFunction.onTimer() method sets the current processing time as event-time timestamp. This behavior is very subtle and might not be noticed by users.
Well, it's harmful because processing-time timestamps are indeterministic and not aligned with watermarks. Besides, user-implemented logic depends on this wrong timestamp highly likely is unintendedly faulty.
So we've decided to fix it. Upon upgrading to 1.4.0, Flink jobs that are using this incorrect event-time timestamp will fail, and users should adapt their jobs to the correct logic.
Brief change log

not set a timestamp for processing-time timer

Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
None
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

@fhueske is this what you had in mind?

Yes, I think this behavior would be better.
Thanks, Fabian

Hi @aljoscha @fhueske , please let me know if you have any more comments

Thanks a lot, @bowenli86. I just merged this. 👍
Could you please close the PR?


Speakers should be grouped for the chosen track & LinkedIn link

If I would like to know Speakers on my chosen Track, it is not so easy. Rather, it would help, if for the chosen track, if I get Speakers on this track, it will be helpful. And also, if their LinkedIn profile link is shared, it will be easy to know their complete profile. We can introduce this an option in the speaker bio.

Do you mean that you want to open their LinkedIn profile? I believe that's already been done. Isn't it?

It is not just adding LinkedIn profile, which is not yet there. Besides, When Speakers' option is chosen all speakers on the app are listed and I have to navigate to speakers connected to the track of my interest. Which is not user friendly. Please refer screenshot.

What solution do you propose?

For whatever track is chosen at the beginning, only related things like Speakers, locations, etc., should be shown.

What do you mean by beginning? Are you talking about when we select a track from the tracks list?

Yes, that is right.


Consider making the I18n class private

What
Do we want to consider I18n "private" whilst we continue changing, refactoring, improving?
We've already noted in https://github.com/alphagov/govuk-frontend/issues/2926 that we may rename our I18n class
Why
Making features "public" means we can't make breaking changes without major releases
Making features "private" (or for internal use) means we're relatively free to make changes where needed
Who needs to work on this
Developers
Who needs to review this
Developers
Done when

[x] Decision made on private versus public
[ ] Change made in code to remove GOVUKFrontend.I18n from govuk/all.js

Concensus at the meeting was to keep it private for now and possibly open it up in a future release, so opened up #2941 to deal with it 😊


set layout in Action Class

I hope to define a layout can also be done this way
public function actions() {
        return [
            'error' => [
                'class' => 'yii\web\ErrorAction',
                'layout' => 'error-layout'
            ],
            'captcha' => [
                'class' => 'yii\captcha\CaptchaAction',
                'fixedVerifyCode' => YII_ENV_TEST ? 'testme' : null,
            ],
        ];
    }

I think it can be done with one of the following approaches:
public function beforeAction($action)
{
    if ($action->id === 'error') {
        $this->layout = 'error-layout';
    }
    parent::beforeAction($action);
}

Or create your own ErrorAction class, that extends from yii\web\ErrorAction and override method beforeRun() as follows:
protected function beforeRun()
{
    return $this->controller->layout = 'error-layout';
}

Or add to your error view line
Yii::$app->controller->layout = 'error-layout';

But I think we still can add the suggested property to the ErrorAction class. @yiisoft/core-developers opinions?

But I think we still can add the suggested property to the ErrorAction class.

This does not make any sense. The best placefor changing layout will be inside the error view file:
<?php
$this->context->layout = 'error-layout';
?>
...


why does scann limits the number of codewords of dimension d/M?

Referring to the paper, it says "With product quantization we encode each datapoint into an M dimensional codeword, each with k possible states".
Here, k directly relates to the compression rate of the dataset so I wanted to know how ScaNN's behavior differs as k varies. However, I could not find a parameter to set k and it seems like k is fixed to 16 in the code.
Is there any reason why ScaNN only supports k=16? If it is, is it because to maximize the benefit of SIMD instruction?
Or is there other way to adjust k?

Did you find out how to access codewords?


[hotfix] list failed deployments with details in vm, k8s

make listing vms && k8s faster (it takes max 10 seconds before timeout)
show number, name and node id of failed deployments

If failed

In case the node is not reachable

same for k8s

This issue fixed here https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1291
Now if we couldn't get the deployment data we will just display its name.


Using angular #var in Form interactive configuration

Hi,
How can we add a field for angular template variable in dxfrom interative configuration?
Here is a Form interactive configuration -https://js.devexpress.com/Documentation/16_2/ApiReference/UI_Widgets/dxForm/
Plunker - Using #var  with devexterme-
http://plnkr.co/edit/W4hCwTGbGIOX0ZKX3IB7?p=preview

Hello @prabhdaffo
You can do this as shown in this example.


Short names

Would be useful to have a "short_name" attribute for some of the more verbose entries such as "United Kingdom of Great Britain and Northern Ireland".
My thoughts are that the biggest thing i can see this being used for is generating country select lists (or currency select lists). However some of the longer country names aren't really ideal in this scenario (and from a UX perspective, users are used to the shorter names).
I know you'll probably not want to add anything that isn't defined by the ISO, but it appears that whilst ISO 3166-1 uses the longer names, ISO 3166-2 appears to use the more common shorter variants (although i'm no expert, and wikipedia is admittedly not always the most truthful of sources).

Yeah most of this is based on search results from https://www.iso.org/obp/ui/#search (try GB there for example). It actually lists that as the "English short name" :-/

The mismatch between what the ISO names are, and what the users expect to see is the reason why projects (Symfony, Drupal, Windows, Mac OS X, etc) don't use ISO 3166 as the data source, but use CLDR instead.
The CLDR dataset is MIT licensed, easy to parse, updated every 6 months, and even contains translations for all major languages. There are several PHP libraries that use it (one my own, as a disclaimer).


chore: publish to NPM and other configurations

@huan I have published https://www.npmjs.com/package/wechaty-cli, but I still have some questions.
The pre-push hook always increase version number per push, will it be OK to update versions so frequently?
The GitHub Action of NPM Publish will run only when pushing to main branch, but we tend to make PR from other branches instead of pushing directly to main branch. So how would we control the version?

I have published https://www.npmjs.com/package/wechaty-cli, but I still have some questions.

That's great!
Please add your NPM auth token to the secret of this repo, with the name NPM_TOKEN, which will be used in our GitHub Actions to publish to npm automatically.

The pre-push hook always increases version number per push, will it be OK to update versions so frequently?

Yes, it's ok and it is required.

The GitHub Action of NPM Publish will run only when pushing to the main branch, but we tend to make PR from other branches instead of pushing directly to the main branch. So how would we control the version?

Just send PR to the main branch, and the CI/CD will be triggered when the main branch gets updated.
Please feel free to let me know if you have more questions, and we can have a discussion in our zoom meeting of the mid-term..


webview: Cross origin requests are only supported for protocol schemes: http, data, chrome, https.

Hi, I am following example given in the "Communicate between renderer process and " section. The problem that I experience is that when I attempt to send message from the webview script to the renderer I get this error:
XMLHttpRequest cannot load electron-safe-ipc:///message?channel=fromWebview&argsJson=%5B%22hi%20renderer%2C%20sup%3F%22%5D. Cross origin requests are only supported for protocol schemes: http, data, chrome, https.
Am I missing some configuration steps?

The problem goes away if disablewebsecurity is set on the webview. Is there a better approach of whitelisting just the electron-safe-ipc protocol?

Hi, sorry for replying late.
Actually I deprecated electron-safe-ipc (https://github.com/seanchas116/electron-safe-ipc#deprecated-use-electron-ipc-within-preload-script-instead).
Using Electron's ipc API might solve the problem, as it doesn't use custom protocols.


TP2000 290 measure edit conditions form doesn't display correct initial data

TP2000-290 measure edit conditions form doesn't display correct initial data
Why

The measure edit form conditions section has required fields that should be pre-populated when conditions already exist.

The with_reference_price_string qs method should return a string that passes validation in validate_duties because it is used to pre-populate the reference_price field on the conditions form and, therefore, the initial data should be valid.

What

Borrows logic from with_duty_sentence_string and updates with_reference_price_string, to ensure that a valid duty string is returned.
Updates MeasureUpdate view to use foreign key pk when populating initial data

Codecov Report

Merging #544 (0bd4606) into master (a10eaae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   92.72%   92.73%
=======================================
  Files         316      316
  Lines       19595    19615   +20
  Branches     1572     1573    +1
=======================================
+ Hits        18170    18190   +20
  Misses       1129     1129
  Partials      296      296

Impacted Files
Coverage Δ

measures/querysets.py
100.00% <ø> (ø)

measures/tests/test_models.py
100.00% <100.00%> (ø)

measures/tests/test_querysets.py
100.00% <100.00%> (ø)

measures/views.py
96.56% <100.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10eaae...0bd4606. Read the comment docs.


Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
Pending Branch Automerge
These updates await pending status checks before automerging. Click on a checkbox to abort the branch automerge, and create a PR instead.

[ ] Update renovatebot/github-action action to v40.1.5

Detected dependencies
github-actions

.github/workflows/renovate-config-validator.yaml

actions/checkout v4.1.1
rinchsan/renovate-config-validator v0.2.0

.github/workflows/renovate-selftest.yaml

actions/checkout v4.1.1
renovatebot/github-action v40.1.4@c134f38c01867794a23c35e86660bd9609caf30c

.github/workflows/renovate.yaml

actions/checkout v4.1.1
renovatebot/github-action v40.1.4@c134f38c01867794a23c35e86660bd9609caf30c

Duplicate