No user info in controllers after login

So, when I use this article to enable Google login, it kinda almost sorta works.
I have created a Blazor app with google login and individual users. As per tutorials.
When I then call the WeatherForecast API, I get that the user is authenticated,
but there is no User.Identity.Name for example.
How do I get the user info in server controllers after login?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6d19b295-f935-3755-4ca4-9d0717b21e75
Version Independent ID: 747a179e-90b7-de07-e270-82414963048a
Content: Google external login setup in ASP.NET Core
Content Source: aspnetcore/security/authentication/social/google-logins.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

https://learn.microsoft.com/en-us/aspnet/core/security/authentication/identity?view=aspnetcore-7.0&tabs=visual-studio
https://learn.microsoft.com/en-us/aspnet/core/security/authentication/scaffold-identity?view=aspnetcore-7.0&tabs=visual-studio
https://learn.microsoft.com/en-us/aspnet/core/security/authentication/add-user-data?view=aspnetcore-7.0&tabs=visual-studio

Thank you for your answer, but it doesn't appear to me, and I might be a complete idiot here, but it seems like these articles describe how to set up authorization in my Blazor app. I seem to have managed that fine, and when I log in with Google, in the top corner of my Blazor pages my email is displayed. So, I have in fact logged in.
From my Blazor app I then call the WebAPI in WeatherController, which has an [Authorize] attribute. However, when that API is called, I can find no information about the login. Inside WeatherController I have the following:
User?.Identity?.Name == null
await _userManager.GetUserAsync(User); returns null
HttpContext?.User?.Identity?.Name
What I am able to do is to grab the bearer token from
Request.Headers["Authorization"];
I can then decode the JWT token and from that get the "sub" - which is the GUID for the user in question from the DB. I doubt this is the standard manner of grabbing the user information from Identity. Is it?

This article is limited to Google external login setup in ASP.NET Core
You need to read and understand Identity topics.

 So far in my developer life I have used Windows auth, and when I do, and I decorate my server controllers with [Authorize], in the controller I will have a User from which I can get information about the logged in user. I can't see anything in these articles about anything of that kind. So, forget all about Blazor, this is not a question about Blazor at all. It is a question about a WebAPI controller where you sign in with Google auth, and get a JWT token as a response from Google.
Assume I am using Postman (not a Blazor app) to access the WeatherController endpoint, how can I, in the WatherController, find the email that I logged in to google with, from the incoming Request? Currently I decode the JWT token my self, grab the user GUID out of the sub part of the JWT token, and do a lookup in the DB, which works. What I wonder about is if there is not a more "direct" way of doing this. I have been looking through all the documentation about Microsoft Identity, and I am not finding anything about this.
I would, for example, think that userManager.GetUserAsync(  ) would do something sensible, but it returns null.
 I have created a number of Golang servers using OAuth and Google auth, and these are straightforward, and I expected Microsoft Identity to be relatively straightforward too, but it is clearly a significant difference in how to handle this on the server depending on which method of auth you use.

For the record - this is the answer:
In the controller constructor, inject UserManager
Whenever you need to get the logged in user, call (or similar)
var user = await _userManager.FindByIdAsync(User.FindFirstValue(ClaimTypes.NameIdentifier) ?? string.Empty);
It is surprising that the UserManager.GetUserAsync doesn't return a user, failing the "last surprise" principle.


[BUG] Not able to fetch player information

Describe the bug
player.py is not able to extract player information. It is giving error - "'NoneType' object has no attribute 'find_all'"
To Reproduce
Just run read me sample:
from espncricinfo.player import Player
p = Player('277916')
p.name
Expected behavior
It should give name of player.
Screenshots

Additional context
AttributeError                            Traceback (most recent call last)
 in
1 from espncricinfo.player import Player
----> 2 p = Player('277916')
3 p.name
C:\Python38\lib\site-packages\espncricinfo\player.py in init(self, player_id)
12         self.parsed_html = self.get_html()
13         self.json = self.get_json()
---> 14         self.player_information = self._parse_player_information()
15         self.cricinfo_id = str(player_id)
16         if self.parsed_html:
C:\Python38\lib\site-packages\espncricinfo\player.py in _parse_player_information(self)
58
59     def parse_player_information(self):
---> 60         return self.parsed_html.find_all('p', class='ciPlayerinformationtxt')
61
62     def _name(self):
AttributeError: 'NoneType' object has no attribute 'find_all'

Can I take this up?

@aman0408 any updates on this ?

@dwillis @aman0408 Friendly bump

I've pushed a fix for this - it removes some of the methods that depend on HTML parsing for now but the Player object remains mostly intact.


Fix bug 1011538: external cross reference

@yannanwang1,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Don't generate .png typegraph files

For consideration.
Untested, as 'make htmlify' is insanely slow on my particular machine at the moment. Should resolve #1063 if it's accepted.

I'll go ahead and merge this in a week with no objection.

Code removed is code that is doesn't have to be maintained.

So the pull request removes 14 lines of code and one feature that could be useful to some. The justification is that it is slow on your machine.
Well, then just implement --light option that doesn't generate png graphs, or maybe even all graphs, so that it is faster on your machine. This would be useful for other purposes too.
👎

Could be, not is.
On Thu, Jan 19, 2017 at 00:30 Aleks-Daniel Jakimenko-Aleksejev <
<EMAIL_ADDRESS>wrote:

Code removed is code that is doesn't have to be maintained.
So the pull request removes 14 lines of code and one feature that could be
useful to some. The justification is that it is slow on your machine.
Well, then just implement --light option that doesn't generate png
graphs, or maybe even all graphs, so that it is faster on your machine.
This would be useful for other purposes too.
👎
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/pull/1131#issuecomment-273685892, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADEUXEhnUnsR013V5IMSQT_g9Zpcebsks5rTvTygaJpZM4Lgorw
.

BTW, the justification is not only that "it is slow on my machine" (the doc build is VERY slow, and this is a drop in the bucket). It's extra time spent on every build, and we don't need two ways to do something when one suffices. Any extra code you have is code that you has to be maintained.
http://caniuse.com/#feat=svg has a listing of all the browsers that support SVG.
I intended the discussion to be centered around whether or not that browser listing is recent enough to drop the PNGs, my assertion being that it is.

Feedback on https://irclog.perlgeek.de/perl6/2017-01-23#i_13975600 seems to generally be: these were useful once but are no longer.

So the pull request removes [...] feature that could be useful to some [...] just implement --light option

I see no reason to add, document, and support an option on a sole basis of "could be useful to some." Especially considering the ease of converting the SVGs to PNGs should anyone actually need the latter (convert does a good job even without any additional settings).

we don't need two ways to do something

Or to waste bandwidth on bots crawling those PNGs (yes, I heard of robots.txt)

whether or not that browser listing is recent enough

It is. SVGs been supported for ages. The only browsers I recall giving trouble are earlier IEs that are no longer even supported by Microsoft in any way. To corroborate, here's a SO question from 5 years ago with the answer that all browsers supported it for years.

I'll go ahead and merge this in a week with no objection.

:+1:

Based on IRC feedback and zoffix's last comment, merging.


Removed BTreeMap from edge_app_server.rs

What does this PR do?
Removed BTreeMap and used HashMap instead. Also fixed redundant clones.
GitHub issue or Phabricator ticket number?
Follow-up of #116
How has this been tested?
Checklist before merging

[ ] If have added tests.
[ ] Is this a new feature? If yes, please write one phrase about this update.
[ ] I've attached relevant screenshots (if relevant).

Closing in favor of #121


GPS Time reference

Hello,
I noticed in the SDK documentation that within the uDatasets class, the ins2.week attribute is defined as:

Weeks since January 1st, 1980

Is this correct, or is it actually based on GPS time which is measured from January 06, 1980?

You are correct.  GPS time is referenced to the 6th of January, 1980.  We will update our documentation.  Thanks for catching that typo.


Running Inference for Unprocess Net on real-world RGB image

Hi,
Questions regarding denoiser models from paper "Unprocessing Images for Learned Raw Denoising". Can I run the inference for some arbitrary already noisy image (RGB) if I don't have access to noise information (shot and read noises) from metadata?
Specifically in the 'dnd_denoise.py' file, I can see the feed_dict comprised of noisy image, read and shot noise tensors.
Thanks!

This model relies very heavily on having metadata for your image. If you can't get it, you could try using the metadata from an image in our unprocessed training data, or from one of the images in the Darmstadt dataset, but all of our experiments suggest that performance will get significantly worse if your metadata is incorrect.

Please see the "Evaluation on Different Real Data" section of our README, which explains what inputs are required, and how to attain those inputs:
https://github.com/google-research/google-research/tree/master/unprocessing#evaluation-on-different-real-data
It is possible to calibrate a new camera to attain shot and read noise as a function of ISO, and it is possible to approximate shot and read noise parameters from a single image. However, the models are only for denoising raw Bayer images, so you will not be able to denoise an RGB image directly.

Thank you I understand! I think I was thrown off since the results were reported for RGB images as well -- but after reading the paper carefully I figured denoising is still done for Raw bayer pattern and just PSNR is computed by converting both GT and denoised images to RGB space. Thank you for your replies!


strain:  verify ordering of actual/expected

In the Jasmine testing framework, it is convention to:
expect(actual).fn(expected)

But some test suites have the following:
expect(expected).fn(actual)

This causes the error messages to be confusing.
Please verify the strain exercise to make sure that the expectations are ordered correctly. If they are, then this can be closed.
This issue will help to close #111

Got it

This one is OK and can be closed

Let's go for it, thanks!


test: some required items

Expected Behavior
Since the "issue template" required item is set to requireAll, this will request more info since only one of the headers is present. Here is a sample: https://codesandbox.io/s/calcite-template-p95kp

Expected Behavior
Using the complete issue template format will remove the need more info label.
Actual Behavior
Let's find out

success


PlatformDependent static initialization ExceptionInInitializerError

Motivation:
PlatformDependent allows some exceptions to escape during static initialization. If an exception escapes it will be translated into a java.lang.ExceptionInInitializerError and render the application unable to run.
Modifications:

Make sure to catch Throwable during static initialization.

Result:
PlatformDependent static initialization doesn't result in java.lang.ExceptionInInitializerError.

@Scottmitch LGTM. Please cherry-pick

Cherry-picked 4.0 (92896bd) for 4.1 see PR https://github.com/netty/netty/pull/4732


Use getCrop in StoriesGrid

I realised that we probably want to use getCrop in StoriesGrid, so all our images are the same size. This would allow us to get rid of all the extra flex styling that is causing this warning in the console
Image with src "https://images.prismic.io/wellcomecollection/d3c3ca54f3b4ffca322ad111d6c217856418e1e1_tamagotchi-16-9.jpg?auto=compress,format" may not render properly as a child of a flex container. Consider wrapping the image with a div to configure the width.

After investigating, we might need to either pull out a lot of code from content or just get our images differently. I'll have a chat with Gareth next week and see what the best solution would be.

Consider using linkResolver instead of url moving forward as well https://github.com/wellcomecollection/wellcomecollection.org/pull/9166/files


GeodesicArea method names differ from Area and ChamberlainDuquetteArea

The Area and ChamberlainDuquetteArea traits have methods with names signed_area() and unsigned_area() whereas the GeodesicArea trait has name area_signed() and area_unsigned(). It would be nice to have these renamed to be in line with the others

This is taken directly from geo:
See chamberlain_duquette_signed_area and geodesic_area_signed.
I'm inclined to keep the API as similar to geo as possible. What do you think.

Ah good point! I agree. I'll make an issue there.


the hashSet error?

it cant pass the unit test
class B
    int b
    construct(int b)
        this.b = b
public class AA
    HashSet<B> a = new HashSet<B>()

@Test function aaa()
    let _1 = new B(1)
    let _2 = new B(2)
    let _3 = new B(3)
    let aa = new AA()
    aa.a..add(_1,_2,_3)..remove(_2)
    for i in aa.a
        print(i.b) // print 1 2. it should be 1 3

for the hashSetTests.wurst
change the last set.remove(3) the 3 to 5 and print the set
you can find something
	// Test remove
	set.get(0).assertEquals(5)
	set.remove(5)
	set.size().assertEquals(2)

	for i in set
		print(i) // print 5 , 6 now

i try to fix it
by
change the add function and remove function but failed.

i believe the ele`s pos is in confusion

good catch. The saved positions had an offset of one because size was used after adding element. Pushed a fix and test.

i think it has more problem because i switched the super.add... and let pos =   .and then in my case is good . but  the hashSetTests.wurst seem to error already

All tests including the one you posted above succeed.
If you have another test that fails, make a new ticket.


[qa] Does commit check work on github actions?

Looking at the current commit message check, I see travis being mentioned a few times:
https://github.com/openwisp/openwisp-utils/blob/30ad216d6e12a7bf4683f131967e763dbcc8363c/openwisp-qa-check#L104-L106
https://github.com/openwisp/openwisp-utils/blob/30ad216d6e12a7bf4683f131967e763dbcc8363c/openwisp-qa-check#L143
I wonder how this impacts on the builds on github actions. @pandafy @atb00ker any suggestion?

The commit check works on GitHub Actions because @atb00ker made commitcheck run every time in https://github.com/openwisp/openwisp-utils/commit/fb3ffcc2c3c42dd065d93248d87433433de31421. Running on GitHub Actions is equivalent to running on a local machine for the script.

@pandafy
However,
  if [ "$TRAVIS" = true ] && [ -z "$TRAVIS_PULL_REQUEST" ]; then
     echo "SKIPPED: Commit message check skipped!"
  fi

this condition was added because when you create a merge commit, it fails on master, so we would need an equivalent condition to don't run on openwisp-[repo]/master! :smile:
Also, I think we shouldn't remove the Travis conditions but just add the GitHub actions conditions so that travis remains usable! (Still required for docker-openwisp, moving that one is hard! 😅 )

@atb00ker if I am not wrong, cases like merge commits are handled here
https://github.com/openwisp/openwisp-utils/blob/7d9dfa1be17e5bb8893c0d05667dc8cd913271f8/openwisp_utils/qa.py#L92-L100

@devkapilbansal this is rather an old comment and the process has been changed since, please ignore the comment if it is not valid.

Hello, Is there anyone working on this issue if not then can you assign this issue to Me?

Hi @Vihar214 ,
You don't need to ask anyone to assign it, you can just work on the issue and create a PR. Someone should look at it soon!
P.S: This ticket is rather old, if it is outdated and not required anymore, please share your findings. 😄


Fixes #5058: use location instead of location_id in vm forms

Fixes #5058

Closes: #5058
What's Changed

Changed filter parameters from location_id to location in virtualization/forms.py.
TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

For whatever reason, I couldn't get either docker or virtualenv working so I wasn't able to do much testing before submitting PR.

@glennmatthews could you please allow checks to run and review? many thanks.

I intentionally didn't change those as I thought that query was looking for the primary key of the record that has location location_id.
I'm still getting familiar with the model but saying the above out loud, I think that statement is wrong and I should have changed those as well.
@glennmatthews do we re open this PR for the next version or just use the same issue and submit a new PR?

Good catch and your analysis is spot on @Lennahrt - those also need to use location (as do lines 537/538 and 607/608 as well).
@tlourey Another PR against the same issue would be totally fine. Thank you!


config not loading when rendering thousands of pieces of latex.

I am accessing the cdn files using http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_HTML
Prior to that, I have added a config block where I use MathJax.Hub.signal.Interest() where I do some action based on the message I get. It has to process hundreds or thousands of latex. but somehow, the cdn config file http://cdn.mathjax.org/mathjax/latest/config/TeX-AMS_HTML.js gives a "file load error". loading the file in a tab in chrome works just fine. also, when just processing a few, the error does not show.

Thanks for the bug report.
Could you provide a live sample that exhibits the problem? Thousands of equations are usually not a problem for MathJax.
Please also take a look at https://github.com/mathjax/MathJax/blob/master/CONTRIBUTING.md#bug-reports for some advice on additional information you might provide.


Always re-import the entire project after executing the gradle task

Extension Name: vscode-gradle
Extension Version:3.6.1
OS Version:Windows_NT x64 10.0.19043
VSCode version:1.60.0-insider (system setup)
Describe the bug
Always re-import the entire project after executing the gradle task
To Reproduce
Use vscode to open a gradle project normally. Wait for the compilation to complete.
Open gradle view to execute any task. Observe the terminal to execute the imported project again
Expected behavior
Do not reimport the project
Screenshots

Output from "Gradle Tasks"
2.log
Does the bug still exist if you disable all other extensions?
Yes
Additional context
Add any other context about the problem here.

@CsCherrYY This phenomenon is related to another issue #930
Because opening Gradle View will reopen a Gradle Deamon JVM. Then recompile the entire project. This wastes a lot of time

Just tried a sample gradle project: https://docs.gradle.org/current/samples/zips/sample_building_spring_boot_web_applications-groovy-dsl.zip, execute app: build in the gradle tasks view and can't reproduce this issue.
I think it's probably because your executed task affects some build files (e.g. build.gradle). It triggers vscode-java to re-import your project.

Because opening Gradle View will reopen a new Gradle Deamon JVM. Then recompile the entire project.

IMO opening Gradle View is more like "configure" the project than "recompile", it will cost less time than recompiling project. As you mentioned in https://github.com/microsoft/vscode-gradle/issues/930#issuecomment-904290075, vscode-gradle indeed starts a different Gradle daemon from vscode-java does. Do you mean to let vscode-gradle reuses the same Gradle Daemon started by vscode-java? If yes, I think it might be a good way to go. Since they are two different extensions it also needs further investigation and collaboration.

additional

And the Deamon JVM started by vscode-gradle does not use the parameter java.import.gradle.user.home

Currently we find a bug about getting daemon status process. This process now started the wrapper without the parameter java.import.gradle.user.home, and the bug will be fixed in #931. I'm not greatly confident about whether it is related to this issue you find, could you just provide a sample project so I can reproduce this issue?

IMO opening Gradle View is more like "configure" the project than "recompile", it will cost less time than recompiling project. As you mentioned in #930 (comment), vscode-gradle indeed starts a different Gradle daemon from vscode-java does. Do you mean to let vscode-gradle reuses the same Gradle Daemon started by vscode-java? If yes, I think it might be a good way to go. Since they are two different extensions it also needs further investigation and collaboration.

I hope that the vscode-gradle plugin will not start a new Deamon, just use the existing Gradle Deamon. Because my project is so big, I have to wait a long time every time. If you don’t change it, I can only give up using it!

Currently we find a bug about getting daemon status process. This process now started the wrapper without the parameter java.import.gradle.user.home, and the bug will be fixed in #931. I'm not greatly confident about whether it is related to this issue you find, could you just provide a sample project so I can reproduce this issue?

This is the same problem. thanks

Currently we find a bug about getting daemon status process. This process now started the wrapper without the parameter java.import.gradle.user.home, and the bug will be fixed in #931. I'm not greatly confident about whether it is related to this issue you find, could you just provide a sample project so I can reproduce this issue?

This is the same problem. thanks

we plan to release 3.7.0 this week including this fix. You can try if this works for you project.

Update: I just tried spring-boot and still can't reproduce. Maybe this issue is related your project.

Currently we find a bug about getting daemon status process. This process now started the wrapper without the parameter java.import.gradle.user.home, and the bug will be fixed in #931. I'm not greatly confident about whether it is related to this issue you find, could you just provide a sample project so I can reproduce this issue?

This is the same problem. thanks

we plan to release 3.7.0 this week including this fix. You can try if this works for you project.

👌

Update:I just tried spring-boot and can't reproduce this issue. IMO it's related to your project. A sample project can reproduce this issue would be very helpful.

i also will test it use springboot. Wait for my message


Release v2.4.2

View rendered CHANGELOG.
@jch I found I did not have the access to push a gem to rubygems.org. You can merge and cut a new version please, thanks!

Let's wait for #257 got merged first. Found a bug for Rails 3.

https://rubygems.org/gems/html-pipeline/versions/2.4.2 released. Thanks!


I got this spawn error in MacOS

After I protractor conf.js, I got this:

My chrome version is 43.0.2357.124, I guess it can not be supported.

Can you post your config & spec files?

Closing as stale.


Auto format using Black (20.8b1) Added black --check to build.

Fixes #1489 (kinda)
My second attempt at this (replacing #1494), now that magic trailing commas has been fixed in Black.

Black is very popular, so many will be familiar with it.
It is good at minimizing diffs
It is very opinionated (the only config I've added is the line length), so there should be minimal discussion about how to configure it
IMO it strikes a good balance between keeping the code nicely formatted (and PEP8 compliant) without making it unnecessarily long.

Here's a comparison of various formatters https://medium.com/3yourmind/auto-formatters-for-python-8925065f9505
As the next step, we could (should) increase the number of rules covered by flake8 (probably switching to ignoring the few rules that we dont like instead of enabling a few favourite ones. something like --ignore E501,W503,E701,E731,E741,E712,E402,F401).

doh, wrong branch...


[FEATURE] STEP_xxx_AVBYTB-8: as a user, I want to get ability for getting line charts

Implement ability to show different line charts.
Acceptance criteria:
– Price chart implemented

solved in https://github.com/Donyelll/av.by-telegrambot/pull/21


Error: Can't resolve 'react/lib/Object.assign' with React 15.0

Using react-spinkit version 1.1.4 with React 15.0 results in the following error:

ModuleNotFoundError: Module not found: Error: Can't resolve 'react/lib/Object.assign' in 'C:\projects\MyProject\node_modules\react-spinkit\dist'

So that require wasn't even being used. Removed it and published 1.1.5. https://github.com/KyleAMathews/react-spinkit/commit/1404b2702e61ad2416a95afacefe20732628b60b

@KyleAMathews awesome, thank you for the fantastic turn-around time!

@KyleAMathews I upgraded to 1.1.5 but still fails; dist/index.js still has the line:
objectAssign = require('react/lib/Object.assign');

Ooops! Forgot to compile the src. I re-published 1.1.6.

@KyleAMathews thanks a lot! Unfortunately there's another issue: React.__spread has been removed in v15.0, and the <div {... @props} syntax seems to compile down to it.

Ha :-) would you mind taking a crack at solving this?
On Thu, Apr 7, 2016 at 4:12 PM nil4<EMAIL_ADDRESS>wrote:

@KyleAMathews https://github.com/KyleAMathews thanks a lot!
Unfortunately there's another issue: React.__spread has been removed
https://github.com/facebook/react/pull/6431 in v15.0, and the <div {...
@props} syntax seems to compile down to it.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/KyleAMathews/react-spinkit/issues/28#issuecomment-207133646

https://github.com/facebook/react/pull/6444

Tracked it down to cjsx-loader, specifically this: https://github.com/jsdf/coffee-react-transform/pull/32. I'll open an issue on there. For now, I can unblock myself by using just the CSS styles; it would be a shame though, since react-spinkit is such a nice library -- thank you again.

If you see the above PR, they're adding it back in.

You should still stop using it :)

This was written back in my hellion Coffeescript days ;-)

I opened https://github.com/jsdf/coffee-react-transform/issues/70 while waiting for React 15.0.1 :smile:.

15.0.1 was released.

@KyleAMathews: jsdf/coffee-react-transform#70 was fixed, removing the use of React.__spread. Would you consider upgrading to version 4.0 to fix this one for good?

Updated and released 1.1.7.


Revert "Use fixed version of pip"

This reverts commit 1fb4f489082045c3160f914fc3456aaf35002026.

@rhcarvalho @mfojtik this change is resulting in failing tests, i'm reverting it for now.

@bparees could you link to the failed test logs?

Just run make test and you'll see it.
Ben Parees | OpenShift
From: Rodolfo Carvalho<EMAIL_ADDRESS>Sent: Jun 12, 2015 2:33 AM
To: openshift/sti-python
Cc: Ben Parees
Subject: Re: [sti-python] Revert "Use fixed version of pip" (#33)

@bparees could you link to the failed test logs?
—
Reply to this email directly or view it on GitHub.


Cant get the game to properly run - constantly encountering error C2-12828-1

Really excited that you have managed to release these long awaited port I have a very great nostalgic memories from playing it more than a decade ago :), but unfortunately it seems I cannot get it running at all.
-followed the set-up instructions and installed the data files as described.
-successfully Verified that my build is exactly the correct one using sha1sum.
-I have libshacccg.suprx in the ur0:/data/ + kubridge.skprx (version 0,3) & Repatch_ex.skprx in my ur0:tai folder and in my config.txt under *KERNEL.
-after encountering error C2-12828-1 when trying to boot the game, i have disabled Repatch_ex.skprx , placed FD_FIX in my ur0:tai and in my config.txt under *KERNEL and restarted my VITA console. yet the game still wont boot.
-installed the older 1.1 & 1.0 versions, but again couldn't get pass the boot screen and encountered error C2-12828-1 yet again.
-Tried to disable all my "optional plugins" in my config.txt file , than rebooted the console and tried to boot the game again - still unsuccessful.
-Uninstalled the game and reinstalled it - again without luck and again error C2-12828-1 popped.
attaching crash dumps + my config.txt file :
Dead space vita crash.zip
I will gladly appreciate your help in trying to determine what else can I do in order to try and get the game running.
Thanks a lot for your great work!

@LeetyBOI sorry for the late reply. Only three possible reasons I can think of:

You have ux0:/tai/config.txt in addition to ur0:/tai/config.txt and thus it's being used instead of the correct ur0: one.
kubridge is not v0.3+, i.e. you might have mis-copied something.
The ioplus plugin is interfering. Try disabling that as well.

Um, also, what firmware version are you using and do you have enso?

Hi, thanks for your reply:
1.Not the case, I have  single tai folder in ur0:/ only.
2. Tried to delete and copy kubridge v0.3 again, didn't help unfortunately.
3. Tried to disable ioplus plugin too, unfortunately didn't help as well.
-My ps vita version is 3.65 , and i have enso as well.
-Tried and failed to boot every version of the Game from 1.0 to 1.3

I am having the same issue


Add check on default_storage for thumbnail

This improve load times on the media library and on pages that use thumbnail often by up to 20x on storages like Amazon S3. The issue is that often the thumbnail has already been made but isn't on the local system because we are using ephemeral storage locally. Without this check we often end up recreating the thumbnail that already exists of the ephemeral storage has been wiped recently like on Heroku for when you push a new update, adding the check saves a ton of processing time.

That's the intended behaviour. It may be 20x slower on the first request after a deploy, but with this change, you'll probably find things to be a lot slower on every request, since presumably you now have a server-side http request for every image on the page, on every request, right?

Yes that would be an issue if no caching is used, on my custom storage backend (using your filebrowser-safe S3 mixin in part) I cache everything so once a file is checked to exist on S3 it then cache.set()'s it and I don't ever have to do an HTTP request again for that key unless a delete is done on the key and it is reuploaded.
I'm working on multiple huge furniture sites and without the caching and this change the media library takes 30 seconds or more to load. With this it loads in 2.5 seconds or less. Since the furniture sites have upwards of around 10,000 images it's not reasonable on every minor update to recreate every single thumbnail.

So this suits your case but likely no one else's :-) That's fine though, I'd suggest just duplicating the thumbnail tag in your own project and make the same change there.

I've done that, you are right this does solve my issue more than others, thanks for checking it though, if someone else has this issue maybe they'll find this!

But they won't find your custom storage backend will they?
Why don't you release that along with a modified thumbnail tag as a separate package for Mezzanine.

Great idea, I'll set that up, it will make implementing it in future sites easier anyways.


Can't run, unknown command line flag noauth_local_webserver

Trying to use gcalci for the first time. I installed it by running
apt-get install gcalcli
When I ran it the first time with gcalcli list I get
Your browser has been opened to visit:

<URL>

If your browser is on a different machine then exit and re-run this
application with the command-line parameter

  --noauth_local_webserver

Then when I try to run gcalcli --noauth_local_webserver list it tells me Unknown command line flag 'noauth_local_webserver', and then prints out the usage message.

Can you report the version number gcalcli --version.  I can't repro this.  I tried on v4.0.4 and v4.1.1 (on debian buster).

Looks like I'm way back on v3.3.2, which seems odd since I just installed today.


flutter 生命周期的一些异常 (lifecyle problem)

我的flutter版本是

我在编写我的代码的时候 发现 flutter的系统生命周期调用出现了一些问题，
经过多次测试在 initstate  build 执行之后 dispose也被执行了，截图如下。
(google translate:  When I was writing my code, I found that flutter's system lifecycle call had some problems. After several tests, the dispose was executed after the initstate build was executed. The screenshot is as follows.)

这个dispose被执行导致，当前 statefulwidget 的context为空，当使用   Navigator.of(context).pop();  等包含 context的方法时会爆出异常如下。
(google translate:  This dispose is executed, causing the current statefulwidget's context to be empty. When using a method such as Navigator.of(context).pop(); that contains a context, an exception is thrown as follows.)

麻烦看一下， 在线等待各位大佬回复～

Please provide the output of flutter doctor and a small self-contained app that demonstrates the problem and we'll look into it. Note also: https://gist.github.com/ is a useful way to share the code.

flutter_app2.zip
here is the demo.
my problem is i create StreamController in provider.
so when the page was dispose,the StreamController.stream.listen is still work.
but current page was dispose, when i do some thing lik setState or Navigator.pusu(), it's crash.
can you add some method like remove  listen, if current page was dispose i can remove StreamControlle.stream.listen

Can you post the minimal runnable code sample to https://gist.github.com/? Thanks.

Can you post the minimal runnable code sample to https://gist.github.com/? Thanks.

here is the demo https://github.com/dioig/testdem  you can see the log

Hi @dioig
It seems you are asking for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Generating in the Linux,The fmu has the .xml and .so

The. so file should be .dll file. Such FMU does not meet FMI specifications.

When generating a Linux FMU, the shared lib must be an so. On Windows, the dll-file is generated in binaries/win64 respectively. What's the problem?


"cf asp APP_NAME" failed with "no config.json" when I installed the plugin first time

when I got my app-autoscaler-cli-plugin installed first time, cf asp APP_NAME return a failue
$ cf asp demoapp2
FAILED

Error: open /Users/zyjiaobj/.cf/plugins/autoscaler_config/config.json: no such file or directory

the expected return msg should be
[zyjiaobj@zyjiaobjs-mbp scripts (master ✗)]$ cf asa
No api endpoint set. Use 'cf autoscaling-api' to set an endpoint.

@cdlliuy  looks like the code does not create the config file if it does not exist...

yes,  it is a bug here. will fix it asap

Fixed.


Create RotatedArraySolution.java

This is the java solution with O(n) time complexity, for the Rotation of unsorted Array problem.

@sparshiigupta , I've made changes according to your suggestions.


reply-to of portal-help is hardcoded in at least one case

The "thanks for requesting an account e-mail" i sent myself on shib-idp1 had:
Date: Mon, 27 Jan 2014 12:15:24 -0500 (EST)
From: www-data<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Subject: GENI Identity Provider Account Request Received
Reply-to<EMAIL_ADDRESS>
All of the e-mail settings for shib-idp1 use gpo-ops, not portal-help, so i think this reply-to indicates a hard-coded recipient, and it looks like there are a few:
$ dpkg -L geni-ar | xargs grep -l<EMAIL_ADDRESS>/usr/share/geni-ar/protected/request_actions.php
/usr/share/geni-ar/protected/acct_actions.php
/usr/share/geni-ar/protected/tutorial_actions.php
/usr/share/geni-ar/www/handlerequest.php
/usr/share/geni-ar/www/request.html

Instead, the $idp_approval_email variable should be used.
Also, while you're in there, this is truly trivial, but the capitalization of "Reply-To:" (capital T) is more standard IMO, and is used other places in the code.
Imported from trac ticket #80,  created by chaos on 01-27-2014 at 12:22, last modified: 02-05-2014 at 12:56

The instance of<EMAIL_ADDRESS>in browser:geni-ar/www/request.html should probably be returned to<EMAIL_ADDRESS>It's a help link, not a header for a generated email. Not sure why it got caught up in the email header commit.
Otherwise, these can all be fixed, pretty easily. Consider introducing a function that generates the standard header fields so we don't have to adjust headers in multiple places throughout the code.
Trac comment by tmitchel (github user: tcmitchell) on 01-27-2014 at 14:27

Added a new config variable in settings.php: idp_help_email.  This will require a puppet change.
Added $AR_EMAIL_HEADERS to ar_constants.php to standardize email headers.  This has precendence, auto-submitted, and reply-to headers.
Changed back the email address for help on the request form to<EMAIL_ADDRESS> I thought that portal-help was the correct address, sorry.
Trac comment by phelinek on 01-29-2014 at 15:47

Removed idp_help_email config variable because idp_approval_email is already set to portal-help.  Use idp_approval_email as Reply-to
Trac comment by phelinek on 01-29-2014 at 16:25

Also changed Reply-to to Reply-To
Trac comment by phelinek on 01-29-2014 at 17:00

Verified that where reply-to works (see [https://github.com/GENI-NSF/geni-ar/issues/81\]), it is no longer set to portal-help on my test system, and that portal-help no longer appears to be hardcoded anywhere in the codebase.
Trac comment by chaos on 02-05-2014 at 12:56


Issues with bin paths when using v7.0.0-rc.4

Deployer version: v7.0.0-rc.4
Deployment OS: Ubuntu

When using the new RC 4 I'm no longer able to use bin path config as before due composer install fails.
This works in v7.0.0-rc.3 without issues:
hosts:
  development:
    bin/php: /usr/bin/php80

What's the error?

Related #2823

What's the error?

It's using the default CLI PHP (7.2.x) instead of the PHP 8.0 bin and so the install fails due to wrong constraints.

#2823 definitely causes this error for me. I think I could add a bin path for composer with prefixed php bin to fix this, but it looks like the issue in 2823 is caused by a misconfiguration of the server.

I think it's caused by a new composer wrapper scripts, there bin/composer is not a phar but a bash wrapper script.

Fixed.


CompilerError - Stack too deep when compiling inline assembly: Variable headStart is 1 slot(s) too deep inside the stack  (Uniswap V3)

When try to complie base86.sol in Uniswap v3 .
solidity version 0.7.6
Complie Error comes up with :

Compiling base64-sol/base64.sol

CompilerError: Stack too deep when compiling inline assembly: Variable headStart is 1 slot(s) too deep inside the stack.

Anything?


Small footprint (~30kB minified, ~15kB gzipped) ?

Hi, Thanks a lot for proving LinkifyJS it is indeed a very bright solution.
Although I don't think of 30kb as small footprint when used on the browser. To my understanding this is a String manipulation library, nothing more, so what makes it up to 30kb ??
If I only import the followings linkifyjs linkify-html, is it 30kb ?
if yes, is it React and jQuery support ? the plugin system ? or something else that makes the bundle that big.
If these are optional, and easy to remove in a peer bundle, that would be very much appreciated.
Thanks a lot !!!!!
edit:
These are some popular libraries and frameworks to have a relative estimate of why I think this is a huge bundle for what it does:

<EMAIL_ADDRESS>=> 6.4 kB Minified
<EMAIL_ADDRESS>=> 5.7 kB Minified

I found out the source maybe of the problem, which is this file
A solution might be a simple Trie data structure. This is a simpler implementation of my own:
https://gist.github.com/bacloud23/ed2ca1c948383158dfb6ecb8f43af2ed
As I couldn't reason about Trie structure for now. You can see in fact it generated into a little bigger size and not lower, but I'm totally sure it can easily be tuned for its aim.

@nfrasser thanks a lot for considering this.

@bacloud23 thanks for the suggestion and for providing that sample code! You're right that the TLDs take up a significant amount of space. Other factors that increase file size include constructions of the URL state machines, options parsing, and regular-expressions for internationalized domain names.
I used a different trie implementation from the one you suggested. It reduces the amount of space the TLDs take up by around 3kB. Along with dropping support for some older browsers, the minified bundle size will now be around 19kB (10kB gzipped).

Addressed in v4.1.0

I used a different trie implementation from the one you suggested. It reduces the amount of space the TLDs take up by around 3kB. Along with dropping support for some older browsers, the minified bundle size will now be around 19kB (10kB gzipped).

So impressed :) I will try to understand how you implemented that. I did not yet see code, but is that the regular Trie structure algorithm ? It is indeed very strong for repeating embedded Strings like natural language worlds.
Anyway, thanks, much gain,


ad-allow-python-system-policies-up-2

@tamilmaran-7 python/system/ksp-allow-python-network-tcp-raw-udp.yaml This policy is not enforceable. Please re-raise the PR.

@salman-accuknox  yasin has raised it not me


Fixed FHIR Code conversion

Added conversion for FHIR.Code type

Partial fix for https://github.com/FirelyTeam/firely-cql-sdk/issues/131
Could not link Issue to the PR properly, seems disabled!


Support helm syntax

Are there any plans to add support for helm definitions as source for metrics? Currently when reading from a helm file with if-guards and apiVersion, kind, metadata and spec fields there is a parsing error with the error message
yaml: did not find expected node content
It would also be nice to have better logging in case of reading from the fromFile is not successful.

helm syntax is just yaml with go template.  Since pat won't have those template variables so it can't render the template and then use the result yaml as input for the roles.
I suggest you run it through helm template first (so it generates a rendered template for the configmap) and then use something like yq to take the specific file content from the configmap.
Something like this:
helm template /path/to/chart -x /path/to/configmap.yaml | yq .data.myrules (replace myrules with the real filename in the rule configmap)


Update makefile.yml

Conducting an evaluation of the chained build command

AppWish Pom requires a change in the version number.


Add "function" to the glossary plus related improvements

added "function" to the glossary. we have a bunch of documentation for specific types of function. the bulk of the cross-references adds links to these function-specific docs (instead of the glossary)
the commit message has more details
where I added cross-references, I ended up reformatting the RST for line-length reasons. I took the opportunity to add a lot of related RST improvements
this is a BIG changeset because there were so many function-related terms to cross-reference and so many RST problems. I think could have improved things if I made one commit per specific function type
if you would like, I think I could probably decompose the changes into three commits:

one for changes to the glossary
one for changes to the main docs
one for changes to the release notes

feedback is welcome for how I can improve my commit strategy for follow-up glossary terms. part of the problem is that adding links to existing paragraphs necessitates re-wrapping and this re-wrapping is what generates most of the diff noise

Edit: for nomi/gloss-20210302-03 I am taking the approach outlined above: splitting things up into glossary additions and separate commits for each term-related main docs changes

@mkleen can I get your review on this? apologies for the size of the diff. I am going to try to spread reviews around the team a bit as I continue work on the glossary

It would be really nice if you could split that up a little bit.

If you can separate formatting changes from content changes that would be also helpful, because I am mainly looking for the content.

@amotl thanks SO much for your comprehensive review
I have pushed fixups
if everything looks good to you, can I get an ack?

@amotl omg thanks! pushed a fixup

Linkchecker is croaking:
https://github.com/crate/crate/pull/11144/checks?check_run_id=2166475385
Nevertheless, I will acknowledge this patch. Thank you very much again!


Adding fix to process 64 bit integers correctly.

Adding fix to process 64 bit integers correctly.

Hello, please follow the contribution guide and include reference to the issue you're fixing. Also, please correct your PR so for tests to pass.


[Mobile] Preview - Default is Desktop, however shows Tablet preview

While viewing the preview panel for the first step, the user notices that the preview default is desktop however the preview panel is showing tablet as the preview.

ready to restest

Verified.


EACCESS ~/.config/Code/User/Cache

🐛 Describe the bug
When tried to upload the settings get this error:

🌴 Visual Studio Code Version : 1.55.2
🌴 Code Settings Sync Version : 3.4.3
🌴 Standard or Insiders : Standard
🌴 Portable or Installed : Installed
🌴 OSS or Official Build : Official build
🌴 Operating System : [ VERSION_HERE ]
🌴 Occurs On: Upload
🌴 Proxy Enabled: NO
📰 To Reproduce
Steps to reproduce the behavior:

Ctrl+Shift+P
Sync: Update/Upload Settings

Tried to give the chmod u+x to this path but it's nothing changed

sudo chmod u+x ~/.config/Code/User && sudo chmod u+x ~/.config/Code/User/*
fixes it.


fix(useGridLayout): Support header groups

Header Groups Bug
Resolves #3537
useGridLayout could not display header groups by default. This seemed like a bug as it is fairly common functionality that it should be able to handle.
Header groups can be supported with the grid layout by using the css grid-column property with a span of the column's totalVisibleHeaderCount.
Column Resizing Bug
useGridLayout has a bug that comes from 'auto' or 'fr' units. When some resizing columns, the cursor doesn't stay with the resizer handle because 'auto' width columns rescale based on the column being resized. e.g. columnResizing state thinks the column width is 150, but it is actually 200 because of grid 'auto' resizing.
This column resizing bug was fixed by locking the width of all columns not being resized. Now, while resizing, this behaves exactly like the Resizing example (with useBlockLayout). After resizing, all columns that have not been resized will default back to their previous value. As a bonus, this supports user-provided 'width' values on columns. If 'auto' width columns is desired (instead of the default 150), that can be set with the defaultColumn useTable prop.
useGridLayout also had a bug where columns could be resized beyond the minWidth and maxWidth values. These values are now taken into account when resizing. However, this MR does not apply minWidth and maxWidth during initial column sizing.

Column maxWidth could be supported with minmax, which has good browser support https://caniuse.com/?search=minmax.
// getTableProps
const width = typeof column.width === 'number' ? `${column.width}px` : column.width
const maxWidth = typeof column.maxWidth === 'number' ? `${column.maxWidth}px` : column.maxWidth
return `minmax(${width},${maxWidth})`
// instead of
if (typeof column.width === 'number') return `${column.width}px`
return column.width

However, I'm not sure if we could support both minWidth and maxWidth at the same time. There doesn't appear to be something like clamp for css grid. Unfortunately you can't do nested minmax functions. If each of the values were numeric, then we could do a min inside of the minmax. However, that removes a lot of the value of using css grid.

Adapted Examples
(since there aren't any examples with useGridLayout)
Column Resizing Example
const Styles = styled.div`
  padding: 1rem;

  .table {
    display: inline-block;
    border-spacing: 0;
    border: 1px solid black;

    .th,
    .td {
      margin: 0;
      padding: 0.5rem;
      border-bottom: 1px solid black;
      border-right: 1px solid black;

      ${'' /* One way to deal with borders in the useGridLayout table
              is to use nth-child pseudo-selectors. */}
      :nth-child(6n + 8) {
        border-right: 0;
      }
      :nth-child(6n + 8):nth-last-child(-n + 7) ~ * {
        border-bottom: 0;
      }

      .resizer {
        display: inline-block;
        background: blue;
        width: 10px;
        height: 100%;
        position: absolute;
        right: 0;
        top: 0;
        transform: translateX(50%);
        z-index: 1;
        ${'' /* prevents from scrolling while dragging on touch devices */}
        touch-action:none;

        &.isResizing {
          background: red;
        }
      }
    }
  }
`

function Table({ columns, data }) {
  const defaultColumn = React.useMemo(
    () => ({
      minWidth: 30,
      width: 'auto',
      maxWidth: 400,
    }),
    []
  )

  const {
    getTableProps,
    headerGroups,
    rows,
    prepareRow,
    state,
    resetResizing,
  } = useTable(
    {
      columns,
      data,
      defaultColumn,
    },
    useGridLayout,
    useResizeColumns
  )

  return (
    <>
      <button onClick={resetResizing}>Reset Resizing</button>

          {headerGroups.map(headerGroup =>
            headerGroup.headers.map(column => (

                {column.render('Header')}
                {/* Use column.getResizerProps to hook up the events correctly */}
                <div
                  {...column.getResizerProps()}
                  className={`resizer ${column.isResizing ? 'isResizing' : ''}`}
                />

            ))
          )}

          {rows.map((row, i) => {
            prepareRow(row)
            return row.cells.map(cell => {
              return (

                  {cell.render('Cell')}

              )
            })
          })}

        {JSON.stringify(state, null, 2)}

    </>
  )
}

Expanding Example
const Styles = styled.div`
  padding: 1rem;

  table {
    border-spacing: 0;
    border: 1px solid black;

    ${'' /* One way to deal with borders in the useGridLayout table
              is to use grid-gap and background. */}
    background-color: black;
    grid-gap: 1px;
    > * {
      background-color: white;
    }

    th,
    td {
      margin: 0;
      padding: 0.5rem;
    }
  }
`

function Table({ columns: userColumns, data }) {
  const {
    getTableProps,
    headerGroups,
    rows,
    prepareRow,
    state: { expanded },
  } = useTable(
    {
      columns: userColumns,
      data,
    },
    useExpanded, // Use the useExpanded plugin hook
    useGridLayout
  )

  return (
    <>

        {headerGroups.map(headerGroup =>
          headerGroup.headers.map(column => (
            {column.render('Header')}
          ))
        )}
        {rows.map((row, i) => {
          prepareRow(row)
          return row.cells.map(cell => {
            return {cell.render('Cell')}
          })
        })}

Showing the first 20 results of {rows.length} rows

        {JSON.stringify({ expanded: expanded }, null, 2)}

    </>
  )
}

Sub-Components Example
const Styles = styled.div`
  padding: 1rem;

  .table {
    border-spacing: 0;
    border: 1px solid black;

    ${'' /* One way to deal with borders in the useGridLayout table
              is to use grid-gap and background. */}
    background-color: black;
    grid-gap: 1px;
    > * {
      background-color: white;
    }

    > div {
      margin: 0;
      padding: 0.5rem;
    }
  }
`

// A simple way to support a renderRowSubComponent is to make a render prop
// This is NOT part of the React Table API, it's merely a rendering
// option we are creating for ourselves in our table renderer
function Table({ columns: userColumns, data, renderRowSubComponent }) {
  const {
    getTableProps,
    headerGroups,
    rows,
    prepareRow,
    state: { expanded },
  } = useTable(
    {
      columns: userColumns,
      data,
    },
    useExpanded, // We can useExpanded to track the expanded state
    // for sub components too!
    useGridLayout
  )

  return (
    <>

        {JSON.stringify({ expanded: expanded }, null, 2)}

        {headerGroups.map(headerGroup =>
          headerGroup.headers.map(column => (

              {column.render('Header')}

          ))
        )}
        {rows.map((row, i) => {
          prepareRow(row)
          return (
            <>
              {row.cells.map(cell => {
                return
{cell.render('Cell')}

              })}
              {/*
                If the row is in an expanded state, render a row with a
                column that fills the entire length of the table.
              */}
              {row.isExpanded ? (

                  {/*
                    Inside it, call our renderRowSubComponent function. In reality,
                    you could pass whatever you want as props to
                    a component like this, including the entire
                    table instance. But for this example, we'll just
                    pass the row
                  */}
                  {renderRowSubComponent({ row })}

              ) : null}
            </>
          )
        })}

Showing the first 20 results of {rows.length} rows

    </>
  )
}

Was this closed by mistake?

@tannerlinsley This PR is for v7 and makes useGridLayout production ready, with all the same features as the other layout hooks, where header groups display correctly and column resizing works.
It's unclear to me if updates will still be made to v7 going forward, but I can open a new PR to the v7 branch if you think this is worthwhile.

Reopened


[Feature request] Drawing tools

Hi all,
i've checked the existing posts and could not find the suggestions i'm bringing forward.
It would be very useful to have some additional picture editing tools to allow:
-To draw an area to get viewer's attention on a particular zone
-To draw lines to get viewer's attention on a sequence of events occurring in the animation.
A possible example of what it could look like would be Irfanview:
-Press c and enter
-Press crtl +  F11 => The screenshot will appear
-Press F12 => Basic image editing tool bar shows up
Tools:
Arrow Line tool
Line Tool
Rectangle tool
Elipse tool
Background/Foreground color, thickness of lines

You can add shapes to your frames and with the next version, v2.27, you'll be able to show focus on some part of the frames by using the obfuscation tool.

I still need to improve the UX, add more shapes, btw.


feature: Do not touch files, if nothing is todo

Could you please elaborate your issue? I'm not understanding exactly what you mean.

Ah sorry ... e.g. lets say I run the command, but the imports are already in the right sorting order. In this case the filesystem does not need to be touched. Would also make for a nice progressbar (especially with --recursive) .. Like
sorting imports for src/main.d -> OK
sorting imports for src/sort.d -> No changes needed

I implemented your idea 👍🏼
The problem is, that you have to re-read the file if changes have to made as buffering files could cost a lot of memory.
I'll try to optimalize it a bit and add an option to always sort files.

I see ... I would have just read in the whole file and compared the sorted version with the original one (don't think someone has sourcefiles that big). But if there is another way, it might be better!
Thanks for implementing .. will test now on a few more projects ...

Works nicely, thanks a lot!


use golang proto for alpn filter

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

cc @kyessenov

@yxue: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio
18787adfb77be6e3e10fc2f1e50753cd907ca1c8
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

How is this filter implemented? Is this an Istio filter or an Envoy upstream filter?

It's a HTTP filter which will be in istio/proxy since currently only istio uses it.

Asking because the upstream socket configuration can be either cluster.transport_socket or cluster.tls_context or cluster.transport_socket_match

The filter will overrides the ALPN in ssl transport socket. https://github.com/envoyproxy/envoy/blob/3582d02f6600057e676629c2afefe5265e669b10/source/extensions/transport_sockets/tls/context_impl.cc#L809 I don't think it related with how transport socket is configured.

Okay sounds good, so it's one layer below the Cluster API, should be fine.

@yxue: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
ed2b1ee1c186287692c555bb07072c3e857fc8e5
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio/wg-security-maintainers could you help to take a look?

BTW we don't want any custom filters long-term. So please make sure to take a task to upstream whatever customizations are needed or use WASM ABI to implement it.

BTW we don't want any custom filters long-term. So please make sure to take a task to upstream whatever customizations are needed or use WASM ABI to implement it.

FYI https://github.com/envoyproxy/envoy/pull/8498
I created the filter in Envoy upstream at the very beginning. Envoy community would like to accept the change until other users require it. We might be able to implement it using WASM.