Fix context deallocation

[x] Balance Py_INCREFs when possible. In particular the easiest way of balancing here is remove the ones from filter methods in the C code, and let Python keep a reference to the context. Certainly it is not the best way to do it, but it involves fewer changes.
[x] Open an issue to describe the problems (#185) with the current design of ResultContext, Node and NodeIterator and how to slightly redesign them to be able to move all the reference tracking to the C part.
[x] Tests for the context, iterators, etc DECREFs (and check their underlying nodes are alive once they go out of scope)

Closes #181

This change is

a discussion (no related file):
Previously, bzz (Alexander) wrote…
Overall looks good, but if that would be possible to improve the "form" i.e make comments describing the tests less verbose/shorter/contain less boilerplate - that would be really help the understanding.
E.g a prefix like This test is intended to test that  does not really assist any understanding of the test itself and can be safely skipped.
Another idea - it may make sense to have only one long preamble before all 3 tests, explaining the details (similar to the one each test has right now) and then a very short one before the tests just explaining the difference.

Done Alex!

bblfsh/test.py, line 398 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Yeah, I think @ncordon meant that the value should be released.
For the test failure, it's usually a segfault. But worth documenting, of course.

No no, the value is not released. When you perform a del in Python, it DECREFs the reference of the underlying CPython object  (and you are allowed to do that only once in the Python side). Since an iterator needs the underlying tree to work, even DECREFing the tree from the Python side should not delete the tree until the iterator has gone out of scope.

bblfsh/test.py, line 400 at r1 (raw file):
Previously, creachadair (M. J. Fromberger) wrote…
typo: iterators

Corrected!

bblfsh/test.py, line 417 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Are you sure this will actually deallocate? Maybe worth running a GC afterward?
Have you tested that it actually fails every single time if the ref balance is incorrect?

It does not deallocate the ctx in fact (and we do not want it to do so, because otherwise when I try to advance the iterator I find that I do not have the unrderlying tree). As I have explained, this DECREFs the count of references to ctx (NodeIterator still has one since that is what the fitler method creates) . And we are only allowed to do del variable once in Python (by constraint of the interpreter itself). The ctx would in fact get released when it (or other objects using it) goes out of scope

bblfsh/test.py, line 417 at r1 (raw file):

Have you tested that it actually fails every single time if the ref balance is incorrect?

Yes, I tested it when doing #176

bblfsh/test.py, line 437 at r1 (raw file):
Previously, creachadair (M. J. Fromberger) wrote…
typo: iterators

Corrected now (I hope!)

bblfsh/test.py, line 483 at r1 (raw file):
Previously, bzz (Alexander) wrote…
Is there a reason why we prefer the comments before the function to the python docstrings?

Well, now that I have unified the comments for all testOrphan{whatever} in a single comment, it does not make sense to use Python docstrings, does it (correct me if I am wrong? Python docstrings are tied to a function (whereas here we have several of them documented with a single comment) so that documentation can automatically be generated for that method (in form of html for example). Here we are not documenting a method of the package, but a test (dev docs), so maybe python docstrings are not necessary?

bblfsh/test.py, line 398 at r1 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Yeah, sorry, I meant it will be released in case we have a bug.
But I'm now wondering if we need to trigger a GC as well, just in case.

Oh yes, I did not think of that. Good catch Denys. I will add that ASAP

bblfsh/test.py, line 398 at r1 (raw file):
Previously, ncordon (Nacho Cordón) wrote…
Oh yes, I did not think of that. Good catch Denys. I will add that ASAP

Done!

bblfsh/test.py, line 419 at r3 (raw file):
Previously, dennwc (Denys Smirnov) wrote…
Another optional suggestion: the del; gc() pattern now repeats a lot in tests, so it may deserve a separate helper.

Done!

a discussion (no related file):
I think I did not introduced that, and is failing because Travis cannot download some dependency:

rpc error: code = Unknown desc = Get https://registry-1.docker.io/v2/bblfsh/cpp-driver/manifests/latest: dial tcp <IP_ADDRESS>:443: i/o timeout

I have tried rebooting the job in Travis, but gives the same error.

a discussion (no related file):
Previously, ncordon (Nacho Cordón) wrote…
I think I did not introduced that, and is failing because Travis cannot download some dependency:

rpc error: code = Unknown desc = Get https://registry-1.docker.io/v2/bblfsh/cpp-driver/manifests/latest: dial tcp <IP_ADDRESS>:443: i/o timeout

I have tried rebooting the job in Travis, but gives the same error.

Now it's working


Fix link to API

It was pointing to the wrong API previously.

@reflectronic : Thanks for your contribution! The author(s) have been notified to review your proposed change.


If map instantiation fails, createDashboard method doesn't throw error state

If we update our internal dependencies (cartodb.js, deep-insights.js,...), we have checked that deep-insights-integration specs are not passing. After a deep check, looks like that if we make fail the map instantiation, nothing is rendered in the builder, so looks like that the error callback is not arriving correctly.

Please, let's take a look as soon as possible on Monday :).

Should be fixed now!


Download documentation for offline

It used to be possible to download this document for offline usage. Now it is not possible.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e4699b7a-fc21-817e-5a37-aa17b55f47a2
Version Independent ID: 23efcd5d-11a5-c46f-a73e-5cc638591bcd
Content: Bulkhead pattern - Cloud Design Patterns
Content Source: docs/patterns/bulkhead.md
Service: architecture-center
Sub-service: cloud-fundamentals
GitHub Login: @dragon119
Microsoft Alias: pnp

Hi @sy-huss Thanks for your feedback. We will review and update as appropriate.

AB#160200 - Thanks for reporting - this issue is under review

Duplicate of #1829


Updated page structure & locations

Adds a plugin to enable a new section inclusion method and modifies the location section to work with it.

The tag {% child_content %} goes through the current directory looking for MD files with the YAML header section_type: inline
These pages are then combined and included in the current page and sub-sections menu

Adds a child page ordering tag section_position for the child section YAML

The pages found are ordered by version, so 1.1.0 > 1.0.4
If no version is specified it takes the version from the previously versioned child or starts at 1.1

looks really good apart from:

cheese (above)
merge conflicts -- shame i did a lot of tinkering with the pages you refactored.  if you didn't change any text then it shouldn't be too hard to merge.  if you did change text probably easiest to look at #19 and replay the changes here
<pot kettle="black"> is it worth documenting the documentation, e.g. explaining how the {% child_content %} thing works, and also other best practices? </pot>  this doesn't need to go into the guide proper, we could just have a dir docs_for_the_docs referenced from README.md.  i worry the children numbering mechanism risks being lost otherwise, plus a lot of other implicit knowledge.  no need for detailed docs (that would make it hard to read imho) but enough so people know the essential tips and tricks.

Thankyou very much for the comments @ahgittin

Looks really good. Only a couple of very minor comments. I'll merge it now, before any more merge conflicts arise.


add cmake references to cpp guidelines

I like the recommendations, I have come across many of them. I also think it is worth to have a designated guide for CMake without mixing this into the C++ one.

I like the recommendations, I have come across many of them. I also think it is worth to have a designated guide for CMake without mixing this into the C++ one.

We could certainly take a subset of this to make a language-agnostic CMake guide as well, but this one is very much c++ CMake guidelines rather than general CMake guidelines (e.g. pretty much all the resources linked here assume c++)


Map processors

This PR replaces PR map-processors which did not merge

Any idea why the unit test fails.
I didn't touch that code, neither the exception emerges from there.

https://travis-ci.org/ojii/django-sekizai/jobs/49452709
I recommend running the tests locally (make a venv, install django-classy-tags, django and pep8. then do python runtests.py).

I already did that and all unit tests pass locally.

Running your branch locally:
(env) jonas:~/workspace/django-sekizai(jrief-map-processors2)$ python runtests.py
Creating test database for alias 'default'...
..............................F........
======================================================================
FAIL: test_pep8 (sekizai.tests.SekizaiTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jonas/workspace/django-sekizai/sekizai/tests.py", line 200, in test_pep8
    "Code not PEP8 compliant:\n{0}".format(errors)
AssertionError: 5 != 0 : Code not PEP8 compliant:
/home/jonas/workspace/django-sekizai/sekizai/tests.py:385:21: E126 continuation line over-indented for hanging indent
/home/jonas/workspace/django-sekizai/sekizai/tests.py:394:21: E126 continuation line over-indented for hanging indent
/home/jonas/workspace/django-sekizai/sekizai/templatetags/sekizai_tags.py:50:80: E501 line too long (96 > 79 characters)
/home/jonas/workspace/django-sekizai/sekizai/templatetags/sekizai_tags.py:51:80: E501 line too long (98 > 79 characters)
/home/jonas/workspace/django-sekizai/sekizai/templatetags/sekizai_tags.py:164:80: E501 line too long (93 > 79 characters)

----------------------------------------------------------------------
Ran 39 tests in 0.140s

FAILED (failures=1)
Destroying test database for alias 'default'...

MacBookPro:django-sekizai jrief$ python runtests.py
Creating test database for alias 'default'...
......................................
----------------------------------------------------------------------
Ran 38 tests in 0.051s

OK
Destroying test database for alias 'default'...

;)

strange my test runner runs only 38 tests

is it up-to-date with master?

is it up-to-date with master?

sure, its build upon commit d5684b81980b1cf7d121845b97c419b562c66140 (Version 0.8.1)

latest master is ed986d2eb3963bcfae2f26a4ae38b8391d9bdcab

all tests passed except 62.17. This is not by a programming error, but by some stream reset during download. So please consider this commit as passed.


Windows Server 2019 image (20240322) - installation fails - 'zstd' is not recognized as an internal or external command

Description
Updating readme file for win19 version 20240322.1 is failing for Azure Devops Agents with the error:
    azure-arm.image: Describing Zstd
    azure-arm.image:   [-] zstd 859ms (619ms|240ms)
    azure-arm.image:    Command 'zstd -V' has finished with exit code 1 and output:
    azure-arm.image:        'zstd' is not recognized as an internal or external command,
    azure-arm.image:        operable program or batch file.
    azure-arm.image:    at "zstd -V" | Should -ReturnZeroExitCode, C:\image\tests\Tools.Tests.ps1:193
    azure-arm.image:    at <ScriptBlock>, C:\image\tests\Tools.Tests.ps1:193

##[error]Error: The process 'C:\ProgramData\Chocolatey\bin\packer.exe' failed with exit code 1

Previously this build was running successfully for other versions.
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Pipelines -> runner-images -> Packer build
Is it regression?
no
Expected behavior
Packer build should be completed with a success code 0  and all tests are passed.:
##[debug]Exit code 0 received from tool 'C:\ProgramData\Chocolatey\bin\packer.exe'
==> Builds finished. The artifacts of successful builds are:
##[debug]Exit code 0 received from tool 'C:\ProgramData\Chocolatey\bin\packer.exe'
##[debug]STDIO streams have closed for tool 'C:\ProgramData\Chocolatey\bin\packer.exe'
Finishing: Packer build

Actual behavior
The build was finished with the Exit code 1 and failed and test is failed for:
Command 'zstd -V' has finished with exit code 1 and output:
    azure-arm.image: Describing Zstd
    azure-arm.image:   [-] zstd 859ms (619ms|240ms)
    azure-arm.image:    Command 'zstd -V' has finished with exit code 1 and output:
    azure-arm.image:        'zstd' is not recognized as an internal or external command,
    azure-arm.image:        operable program or batch file.
    azure-arm.image:    at "zstd -V" | Should -ReturnZeroExitCode, C:\image\tests\Tools.Tests.ps1:193
    azure-arm.image:    at <ScriptBlock>, C:\image\tests\Tools.Tests.ps1:193

==> Some builds didn't complete successfully and had errors:
--> azure-arm.image: Script exited with non-zero exit status: 1. Allowed exit codes are: [0]

==> Builds finished but no artifacts were created.
##[debug]Exit code 1 received from tool 'C:\ProgramData\Chocolatey\bin\packer.exe'
##[debug]STDIO streams have closed for tool 'C:\ProgramData\Chocolatey\bin\packer.exe'
##[debug]task result: Failed
##[error]Error: The process 'C:\ProgramData\Chocolatey\bin\packer.exe' failed with exit code 1
##[debug]Processed: ##vso[task.issue type=error;]Error: The process 'C:\ProgramData\Chocolatey\bin\packer.exe' failed with exit code 1
##[debug]Processed: ##vso[task.complete result=Failed;]Error: The process 'C:\ProgramData\Chocolatey\bin\packer.exe' failed with exit code 1
Finishing: Packer build

Repro steps
In Azure Devops create a new Pipeline to update image in Agents based on win-19 server:

Select a source: GitHub

Agent job: select agents pool which should be updated

Add task 'Packer init'

Add task 'Packer build'

Run the build (takes around 5 hours)

Hello @LubovKrasikova . Unfortunately we cannot reproduce your error.
Here is nightly windows-2019 build  - https://dev.azure.com/github/runner-images/_build/results?buildId=135153&view=logs&j=747417c8-a650-5aed-afed-d9b52dbd7d24&t=f245de8a-85db-5d11-6f6b-a3b45c2b2a6a
Please, use latest commit from main branch for your image generation.  Current builds are not idempotent and if one tries to build a runner image using the specific tag it is not guaranteed that the build will succeed.

We encounter the same failure while using the windows2022 build:
azure-arm.image: Found download url for facebook/zstd version 1.5.6: https://github.com/facebook/zstd/releases/download/v1.5.6/zstd-v1.5.6-win64.zip     azure-arm.image: Downloading package from https://github.com/facebook/zstd/releases/download/v1.5.6/zstd-v1.5.6-win64.zip to C:\Users\packer\AppData\Local\Temp\zstd-v1.5.6-win64.zip...     azure-arm.image: Package downloaded in 0.67 seconds     azure-arm.image: Expand archive 'C:\Users\packer\AppData\Local\Temp\zstd-v1.5.6-win64.zip' to 'C:\tools' directory     azure-arm.image: Pester v5.5.0     azure-arm.image:     azure-arm.image: Starting discovery in 1 files.     azure-arm.image: Discovery found 46 tests in 1.32s.     azure-arm.image: Filter 'FullName' set to ('Zstd').     azure-arm.image: Filters selected 1 tests to run.     azure-arm.image: Running tests.     azure-arm.image:     azure-arm.image: Running tests from 'C:\image\tests\Tools.Tests.ps1'     azure-arm.image: Describing Zstd     azure-arm.image:   [-] zstd 799ms (576ms|223ms)     azure-arm.image:    Command 'zstd -V' has finished with exit code 1 and output:     azure-arm.image:        'zstd' is not recognized as an internal or external command,     azure-arm.image:        operable program or batch file.     azure-arm.image:    at "zstd -V" | Should -ReturnZeroExitCode, C:\image\tests\Tools.Tests.ps1:193     azure-arm.image:    at <ScriptBlock>, C:\image\tests\Tools.Tests.ps1:193     azure-arm.image: Tests completed in 4.99s ==> azure-arm.image: Test run has failed


GridHeatMap null_value_opacity enhancement / workaround

from __future__ import print_function
import numpy as np
from bqplot import *

data = np.random.randn(10, 10)
data[3][5] = None

col_sc = ColorScale()
grid_map = GridHeatMap(color=data, scales={'color': col_sc}, interactions={'click':'select'},
                      selected_style={'opacity': '1.0'}, unselected_style={'opacity': 0.4})

grid_map.null_color = '#00FFFFFF'

Figure(marks=[grid_map], padding_y=0.0)

results in:
TraitError: The 'null_color' trait of a GridHeatMap instance must be a valid HTML color, but a value of '#00FFFFFF' <class 'str'> was specified.

As per https://www.w3schools.com/cssref/css_colors_legal.asp adding a alpha channel should be a valid html color.
eg RGBA
grid_map.null_color = 'rgba(255, 255, 255, 0)'

Appears that ipython Color does not allow an alpha channel for colors - hence looking to add null_value_opacity or make the null value responsive to dark-theme so that appearance will be consistent with other Plots.

Thanks for reporting!
I think that it would make sense for it to change upstream (in ipywidgets) rather than in bqplot.


Build user with 'group' property for name of user's group

Build user with 'group' property for name of user's group
Summary: Required to resolve https://github.com/source-academy/cadet-frontend/issues/753.
Related PRs
Please review this PR in conjunction with this PR on cadet-frontend: https://github.com/source-academy/cadet-frontend/pull/946. Both PRs should be approved together. This PR is complete.
Changelog

Update the /user endpoint to retrieve and transmit the name of the user's group, to enable the front-end to conditionally render the unsubmit button using information about groups

group has type :string, but may be :nil (null) when a user belongs to no group

Last updated 24 Sept 2019, 01:30AM

Pull Request Test Coverage Report for Build 2727

4 of 5 (80.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 91.703%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/cadet_web/views/user_view.ex
1
2
50.0%

Totals

Change from base Build 2721:
-0.06%

Covered Lines:
1039

Relevant Lines:
1133

💛  - Coveralls


Corner Pin not working

Hej,
I am not sure if this isn't supported or if it is a bug:
http://dev.fact-finder.de/test/bodymovin.html
On top you see the export form bodymovin and below the animation as it should be. The map to the right and the text on top of the iPhone have both the "Corner Pin" effect.

Unfortunately, the corner pin effect is not supported.
sorry :/

That's too bad. Thanks for the info!


AVPlayer observer error

Fixes #11 AVPlayer observer error

Thanks @minuscorp

You're welcome! Keep the nice job!


refactor: ditch consumer groups for direct consumers

Apart from replacing cgs with direct consumer, this MR fixes the stop-at-end flag which wasn't functioning before

Why replace consumer-groups:

We're not using the commit offset feature at all since all offsets are tracked in memory with initial value from the target topic
leaveAndResetOffsets seems to fail with UNKNOWN_TOPIC sometimes when a topic is reset causing the offsets to get out of sync
Direct consumers are easier to reason about and we do not have to care about rebalance scenarios


Add Polypik as a Contributor

@PolyPik has made some good contributions lately. Would love for him to be added as a contributor!

@dave-irvine You are the only member of the twigjs organization. I request that you add me to the organization as either a member or as an outsider collaborator.

You can close this now, I got the membership.

Thanks @dave-irvine! :rocket:


Include a configuration option to keep the original text as an alias

Mostly explained by the title.
Would work for some workflows, and be not so great for others.
I use the dates almost exclusively in my Daily Notes - where I will often refer to "next week", "tomorrow", "on Wednesday", etc.  My date format is quite large YYYY-MM-DD (ddd Do MMM), and in a "daily" context, not as easy to mentally parse/process as "tomorrow" in the context of a daily note.
In the case of using the plugin to resolve "next monday", I can do this manually by modifying the markdown to read as [[2020-11-23 (Mon 23rd Nov)|next monday]], for it to read in preview mode as simply next monday
It would be great to include a config option to keep the original text as an alias (or even as a separate command in the command palette)

I did this locally, I'll make a pull request for it but it basically changes  "[[date]]" to  "tag" so the selected text becomes a link to that date instead...

I did this locally, I'll make a pull request for it but it basically changes  "[[date]]" to  "tag" so the selected text becomes a link to that date instead...

@Bejasc v0.3.2 includes the changes in #16 in case you want to give it a try!

@Bejasc v0.3.2 includes the changes in #16 in case you want to give it a try!

I think this can be closed now, right @argenos?

Is there a way to use this feature on mobile? I can only use it on the desktop.


Gitter.im for open discussion for Orion

I just came across http://gitter.im in a repository I was researching on atmospherejs.com . I believe this would be a cool place, to have open discussions, about the project without cluttering the issues. Then if a discussion comes up that should be mentioned in the actual repo, we could refer the person to the repository to create an issue. I believe gitter.im also allows you to go directly to the repo to create an issue.
Let me know your thoughts.

I discussed chat with Nick a while back and we are thinking of either irc
plus etherpad. Meteor has an irc channel maybe we should piggyback on that.
On Apr 17, 2015 10:35 PM, "Ryan Watts"<EMAIL_ADDRESS>wrote:

I just came across http://gitter.im in a repository I was researching on
atmospherejs.com . I believe this would be a cool place, to have open
discussions, about the project without cluttering the issues. Then if a
discussion comes up that should be mentioned in the actual repo, we could
refer the person to the repository to create an issue. I believe gitter.im
also allows you to go directly to the repo to create an issue.
Let me know your thoughts.
—
Reply to this email directly or view it on GitHub
https://github.com/orionjs/orion/issues/109.

Yeah I remember the discussion on about etherpad. Mind if I ask the why not gitter.im , trying to see if there is any underlying issues or dislikes before I start using it on other repos.

Never tried it maybe more modern than freenode  irc. The thing to note
though is majority of opensource projects use irc and meteor does too.
Again gitter is paid right?
On Apr 17, 2015 11:00 PM, "Ryan Watts"<EMAIL_ADDRESS>wrote:

Yeah I remember the discussion on about etherpad. Mind if I ask the why
not gitter.im , trying to see if there is any underlying issues or
dislikes before I start using it on other repos.
—
Reply to this email directly or view it on GitHub
https://github.com/orionjs/orion/issues/109#issuecomment-94120574.

No gitter is free for public chats and 25 members for private discussions . So only 25 in a private discussion which I never see if hitting that limit for s private discussion.  Most of the discussions are on the issue system here and they're all public .
The pro version has the exact same settings except you get unlimited private users in a discussion.  And it's $5

Okay then setup a room and let's start collabNation :)
On Apr 18, 2015 1:09 PM, "Ryan Watts"<EMAIL_ADDRESS>wrote:

No gitter is free for public chats and 25 members for private discussions
. So only 25 in a private discussion which I never see if hitting that
limit for s private discussion. Most of the discussions are on the issue
system here and they're all public .
The pro version has the exact same settings except you get unlimited
private users in a discussion. And it's $5
—
Reply to this email directly or view it on GitHub
https://github.com/orionjs/orion/issues/109#issuecomment-94183825.


ActivityNotFoundException on API 33

Describe the bug
It seems ActivityScenario is having some issues on API 33:
google issue

Fixed in 1.2.2


fix: remove sudo

:tada: This PR is included in version 1.0.10 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fragments and auto expand results

:nextjournal.clerk/auto-expand-results? seems to work differently for things rendered as a fragment.
Best illustrated with an example.
ns settings
(ns parser
  {:nextjournal.clerk/visibility {:code :hide}
   :nextjournal.clerk/auto-expand-results? true}
  (:require [nextjournal.clerk :as clerk]))

Notebook code
So the following:

;; ### Directly

(clerk/html
 [:div
  [:pre "The stuff to parse"]])

[:some-tree
 [:item [:text "hello "] [:text-bold "world"]]
 [:item [:text "hello "] [:text-bold "world"]]
 [:item [:text "hello "] [:text-bold "world"]]
 [:item [:text "hello "] [:text-bold "world"]]
 [:item [:text "hello "] [:text-bold "world"]]]

;; ### Using fragment

(clerk/fragment
 (clerk/html
  [:div
   [:pre "The stuff to parse"]])
 [:some-tree
  [:item [:text "hello "] [:text-bold "world"]]
  [:item [:text "hello "] [:text-bold "world"]]
  [:item [:text "hello "] [:text-bold "world"]]
  [:item [:text "hello "] [:text-bold "world"]]
  [:item [:text "hello "] [:text-bold "world"]]])

Screenshot of initial render

The first view of the tree looks great.
When placing the tree in a fragment then it seems the enclosing collection does not get expanded but the first found collection does get expanded.
I would expect both trees to render the same initially.
For context
I am trying to show some text that will be parsed and its resulting parse tree together. So I will make some function parse that returns something that results in those two things getting displayed in the notebook.

Thanks for the report, hope we get around to fixing it in the coming days.


Bug: Crashes after a single file is attempted

GIVEN I've installed the community plug-in for Obsidian
WHEN I choose "Import Confluence space" from the Obsidan command palette AND I add the path to the Confluence space folder (located within the Obsidian vault)
THEN only 2 folders are extracted containing a single MD file which is still in HTML

I've checked import of a confluence space located inside an obsidian vault and unfortunately was not able to reproduce the problem - the space was successfully imported.
Plz provide some specifics:

OS version
pandoc version
It would be nice, if you could send me compressed vault with the steps to reproduce.

Thanks for the reply.  I was hoping that this wasn't a zombie project.  I'm happy it appears not.

I'm running macOS Sonoma vn 14.0
Pandoc 3.1.8

As for files, I'm happy to share zips of the Obsidian vault and the Confluence space export.  Please contact me directly and I'll email them to you.

Hi!
Thanks for trying the plugin.
Please update the plugin to the v. 0.2.5.
Let me know, if you encounter any problems.
Best of luck!
PS.
I wouldn't recommend importing from a namespace located within the same Obsidian vault.

Fixed in v. 0.2.5


how to insert a new line break at data-caption.

I'm making website , using wordpress (make original-template) , bootstrap and this lightbox system.
Please tell me , how to insert a new line break at "data-caption".
Only HTML file ,  is working.
but, remake wordpress original template , its not working.

@yu-jp are you trying to use PHP in the caption?

@yu-jp are you trying to use PHP in the caption?

yes. Is it incorrect way to use?


$os.readFile and $os.getwd use / as working directory in production enviroment

I was trying to go production and have been following the instruction in the doc
But I noticed that my custom .env reader was throwing an error.
This code ran during onBeforeBootstrap hook:
try {
  envFile = $os.readFile(".env");
} catch (e) {
  console.error(e);
}

And was throwing error:
Apr 17 22:01:43 poe-vpn.localdomain pocketbase[1464]: 2024/04/17 22:01:43 Loading environment variables
Apr 17 22:01:43 poe-vpn.localdomain pocketbase[1464]: 2024/04/17 22:01:43 GoError: open .env: no such file or directory

So I try logging out the working dir with $os.getwd and it logged root:
Apr 17 22:02:42 poe-vpn.localdomain pocketbase[1507]: 2024/04/17 22:02:42 /

pb_migrations got read just fine and new data also get written to pb_data so I think the working directory is set correctly.
My current workaround is to use __hooks variable and traverse up one directory to the root of project.
Note: it works when running ./pocketbase serve but not as a systemd service, here's my systemd service file: pocketbase.service
[Unit]
Description = poemaid-pocketbase

[Service]
Type           = simple
User           = root
Group          = root
LimitNOFILE    = 4096
Restart        = always
RestartSec     = 5s
StandardOutput = append:/root/poe-maid-sveltekit/errors.log
StandardError  = append:/root/poe-maid-sveltekit/errors.log
ExecStart      = /root/poe-maid-sveltekit/pocketbase serve --http="<IP_ADDRESS>:8099"

[Install]
WantedBy = multi-user.target

It is working correctly.
Both $os.getwd and $os.readFile are directly mapped to the Go os.Getwd and os.ReadFile methods (see binds.go) and they follow the same rules for resolving their path based arguments.

I forgot to mention that an alternative to the absolute path could be to define the WorkingDirectory directive in your service file.

So pocketbase didn't use working directory when resolving for pb_* but rather it's own binary path?
As it is not exptected that running pocketbase in a production enviroment puts its working directory on /, this should be mentioned in the document and the WorkingDirectory directive you mentioned should also be included in the example service file.

pb_data by default is relative to the executable (you can inspect the defaults with --help).
For any std Go function (or its JS translation) the relative paths are resolved based on the current directory. It is not guarantee that it will be always / as this will depend on the platform and the user that is running the systemd service. I'll consider adding the WorkingDirectory directive in the example service file with the next release.


net/http/cookiejar: Domain matching against IP address

Hello,
The following test fails:
package foo

import (
    "net/http"
    "net/http/cookiejar"
    "net/url"
    "testing"
)

func TestIPDomain(t *testing.T) {
    u, err := url.Parse("http://<IP_ADDRESS>/")
    if err != nil {
        t.Fatal(err)
    }

    jar, err := cookiejar.New(nil)
    if err != nil {
        t.Fatal(err)
    }

    c := &http.Cookie{Name: "foo", Value: "bar", Domain: "<IP_ADDRESS>"}
    jar.SetCookies(u, []*http.Cookie{c})
    cs := jar.Cookies(u)
    if len(cs) != 1 {
        t.Fatalf("Got %v cookies, expected 1\n", len(cs))
    } else if cs[0].Name != "foo" || cs[0].Value != "bar" {
        t.Fatal("Invalid cookie name/value")
    }
}

Further inspection shows that it fails with errNoHostname here: https://github.com/golang/go/blob/7f0be1f781a523b5acafb527ca123f5b0eac1536/src/net/http/cookiejar/jar.go#L447-L452
I believe the comment refers to RFC6265 5.1.3. It states that the domain string must either be identical with the string it's matched against, OR that all of the three subsequently listed conditions are met, one of which are that the string being matched must be a host name.
In the case of the matched string being an IP address and the domain string being the same IP address, the first condition is met. I therefor believe that L447-L452 should be removed.

The situation is not really simple: RFC 6265 is not clear whether to allow or deny
domain cookies on IP addresses and browsers handle this case differently.
That was the reason for the TODO in line 450 [1] of the cookiejar implementation.
I have the impression that half a decade ago domain cookies on IP addresses
where commonly accepted, sometimes just to match the behavior of Internet Explorer
(see e.g. [2] [3] [4] [10]).
The current implementation in Chromium rejects domain cookies in IP addresses
[5] lines 457-477.  If I my understanding of the Mozilla code [6] is correct then
Firefox silently converts a domain cookie for an IP address to a host cookie.
(I have not done tests on any browsers recently.)
My gut feeling is that cookies with an IP address as the domain-attribute should be
either rejected (an IP address is not a domain) or be converted to host cookie (i.e.
pretending the domain-attribute was not set, a forgivable user error).
RFC 6265 is not really clear here. I read the following

The string is a host name (i.e., not an IP address).

RFC 6265 section 5.1.3, second bullet, third star [7] as a definition of host name in
the sense of: "a host name is not an IP address".
Therefore my understanding of the algorithm to produce a canonicalized host name

Convert the host name to a sequence of individual domain name labels.

RFC 6265 section 5.1.2 step 1 [8] is that an IP address does not qualify as a
canonicalized host name.
As an IP address is not a canonicalized host name I think that  RFC 6265 section 5.3
step 6 first case [9] applies:

If the canonicalized request-host does not domain-match the domain-attribute:
Ignore the cookie entirely and abort these steps.

and the cookie should be dropped as it is done currently.
[1] https://github.com/golang/go/blob/7f0be1f781a523b5acafb527ca123f5b0eac1536/src/net/http/cookiejar/jar.go#L447-L452
[2] https://code.google.com/p/chromium/issues/detail?id=3699
[3] https://codereview.chromium.org/18657/diff/1/net/base/cookie_monster_unittest.cc
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=125344
[5] http://src.chromium.org/viewvc/chrome/trunk/src/net/cookies/cookie_store_unittest.h
[6] https://hg.mozilla.org/mozilla-central/file/3e8dde8f8c17/netwerk/cookie/nsCookieService.cpp#l3502
[7] http://tools.ietf.org/html/rfc6265#section-5.1.3
[8] http://tools.ietf.org/html/rfc6265#section-5.1.2
[9] http://tools.ietf.org/html/rfc6265#section-5.3
[10] https://bugzilla.mozilla.org/show_bug.cgi?id=125344

The Chromium test case you linked as [5] shows that Chromium allows a cookie to be set with a domain attribute if that attribute is an exact match (L470-L472 in the same file).

RFC 6265 is not really clear here. I read the following

The string is a host name (i.e., not an IP address).
RFC 6265 section 5.1.3, second bullet, third star [7] as a definition of host name in
the sense of: "a host name is not an IP address".
The third star is so that suffix matching is only applied on host names. 5.1.3 also states that if the two strings matches each other exactly, they domain-match.

Regarding RFC6265 5.3:

If the canonicalized request-host does not domain-match the domain-attribute:
Ignore the cookie entirely and abort these steps.
If I visit the URL http://<IP_ADDRESS>/ in my browser, it is my understanding that "the canonicalized request-host" is "<IP_ADDRESS>". If the domain-attribute in the Set-Cookie header is set to <IP_ADDRESS>, the canonicalized request-host domain-matches the domain-attribute under the rules of 5.1.3 (exact match).

The comment in the Chromium test case is interesting: "This matches IE/Firefox, even though it seems a bit wrong." Maybe that behaviour is wrong.
One more from the Chromium test case: Chromium treats domain=.<IP_ADDRESS> as an illegal domain attribute. But if you follow RFC 6265 (as package cookiejar tries to) you would chop off the leading trail first (see 5.3.2), even before domain matching it. Chromiums behaviour here is not RFC 6265 compliant no matter if RFC 6265 allows domain cookies on IP addresses or not.
As I said RFC 6265 is not clear here.
I think silently converting the domain cookie to a host cookie is okay, but I do not think that domain cookies on IP addresses make sense at all.
Would you have time to test the behaviour on Chrome, FF, IE, Safari and curl? I thinks showing that all these "browsers" handle domain attributes equal to the request IP address the same would add considerable weight to the proposed change.

For the following web service:
package main

import (
	"net/http"
	"log"
)

func CookieHandler(w http.ResponseWriter, r *http.Request) {
	w.Header().Set("Set-Cookie", "foo=bar; domain=<IP_ADDRESS>")
	w.Write([]byte("foo"))
}

func main() {
	http.HandleFunc("/", CookieHandler)
	log.Fatal(http.ListenAndServe(":8080", nil))
}

curl 7.40.0
Google Chrome 47.0.2503.0 dev
Mozilla Firefox 40.0.3
sets the cookie "foo" for <IP_ADDRESS>
I will be able to test IE, Safari in the beginning of next week.

Safari 9.0 (11601.1.56)
IE 10.0.9200.17492 (Update version 10.0.31, Windows 2012 Server) *
sets the cookie "foo" for <IP_ADDRESS> for the previously mentioned test case.
*: Added Expires attribute to make sure a persistent cookie file was created in "Temporary Internet Files".

This certainly makes it challenging to use httptest.Server and try to set cookies.

Having spent some time working out why a Go test behaved differently to a browser test, I ended up at this discussion. Even after following the referenced links, I find the argument for the current behavior to be unconvincing.
RFC 6265 section 5.1.3 states that there is a match if "the domain string and the string are identical". The only way to make this exclude IP addresses is to infer a definition of the term "string" to mean "host name (i.e., not an IP address)". But if "string" is defined this way for the entire section, then why would the RFC need these exact words as a requirement of the alternative branch? It would be tautological.
Combined with the other evidence that browsers do support exact matches on IP addresses (the Chromium tests, Firefox code, and the last comment by @sebcat), my opinion is that this should be fixed in the Go library.

Please Golang allow ip address, domain setting cookie in next release .I had to comment out this whole part: https://github.com/golang/go/blob/7f0be1f781a523b5acafb527ca123f5b0eac1536/src/net/http/cookiejar/jar.go#L447-L452
to make my code run.
Most of the browsers allow ip address for cookie setting, kindly try to relax that behaviour or atleast mention that somewhere,It took me nearly 1 day to figure out what was going bad.
https://stackoverflow.com/questions/67872836/use-cookies-txt-as-cookies-jar-client-side-in-golang?noredirect=1#comment119971669_67872836

@jayateertha043
You seem to imply that domain-cookies should unconditional be setable on IP addresses if the cookie's domain-attribute is an IP address and equal to the host which also must be an IP address?
Do you consider such cookies domain- or host-cookies?
You mention "Most of the browsers allow ip address for cookie setting". Could you provide evidence of the details, especially:

What if only one of the cookie-domain-attribute and the host is an IP address but the IP address ist that of the domain name on the other? What do browsers do in such cases? Do all browsers behave the same way?
Do browsers treat such cookies a domain-cookies or host-cookies? Does this matter? Do all browsers behave the same?
On which requests do browsers return cookies set with an IP address as the domain-attribute? Only tho the IP address? Or also to the domain name resolving tho this IP?
Are there any security considerations to take care of? If not: Why is the behaviour unproblematic?

Do you consider such cookies domain- or host-cookies?

Do browsers treat such cookies a domain-cookies or host-cookies? Does this matter? Do all browsers behave the same?

It turns out that it doesn't matter - for IP addresses, host and domain cookies are the same.
RFC 6265 Sec 2.3 says:

The request-host is the name of the host, as known by the user agent,
to which the user agent is sending an HTTP request or from which it
is receiving an HTTP response (i.e., the name of the host to which it
sent the corresponding HTTP request)."

This does not appear to exclude IP addresses, since a HTTP request can be sent to an IP address and the IP address would be the only name known by the user agent. This section also refers to request-uri from https://datatracker.ietf.org/doc/html/rfc2616#section-5.1.2 which, via https://datatracker.ietf.org/doc/html/rfc2396, ultimately defines its host component as hostname | IPv4address.
https://datatracker.ietf.org/doc/html/rfc6265#section-5.1.2 defines a "canonicalized host name" and refers to domain name RFC's. So although it is not definitive, we could probably say that this refers to a domain name, and specifically not an IP address. This is backed up by section 5.1.3 which says "The string is a host name (i.e., not an IP address)"
So in RFC 6265 "request-host" includes IP addresses and "host name" does not.
When considering Host cookies (cookies without a Domain attribute):

5.3(4) sets the domain-attribute to an empty string
5.3(6) sets the host-only-flag to true and the domain to the canonicalized request-host.

The phrase "canonicalized request-host" isn't defined, but it is a "request-host" and not just a "host name". The most sensible way to interpret it is as a request-host that has been canonicalized if it is a host name.
So we get a cookie with host-only-flag=true and domain=canonicalized request-host (in this case an IP address).
When we come to send the cookie Sec 5.4(1) says, since the host-only-flag is true, we send the cookie when the canonicalized request-host is identical to the cookie's domain (when sending to the same IP address).
When considering a Domain cookie (cookie with a Domain attribute) returned from an IP address, running through the same sections, since the second part of sec 5.1.3 is inoperable if the request-host is an IP address, the cookie is ignored unless the cookie domain is identical to the request-host, both for the receiving and sending of the cookie. So a cookie from an IP address with the domain set to the IP address is equivalent to an IP address host cookie.

What if only one of the cookie-domain-attribute and the host is an IP address but the IP address ist that of the domain name on the other? What do browsers do in such cases? Do all browsers behave the same way?
On which requests do browsers return cookies set with an IP address as the domain-attribute? Only tho the IP address? Or also to the domain name resolving tho this IP?

Domain name resolution does not occur for cookie management. This is also true for domain names: https://stackoverflow.com/questions/10020987/cname-and-cookies

Are there any security considerations to take care of? If not: Why is the behaviour unproblematic?

The security considerations appear to be the same as those for domain names. e.g. there are potential problems if you use a request-host that reaches a different host on different networks. But the lack of true domain cookies for IP addresses eliminates one class of problems: accidentally giving access to an untrusted subdomain.

@jongiddy Thanks for the detailed analysis. Please note that the problem are cookies with a domain-attribute only. Host-cookies and IP addresses work well, see e.g. the test in https://github.com/golang/go/blob/7f0be1f781a523b5acafb527ca123f5b0eac1536/src/net/http/cookiejar/jar_test.go#L259. RFC 6265 is pretty clear here and this was never in question, so let's focus the discussion on cookies with a domain-attribute which is a IP address only.
I think we agree the other two cases (host-cookies) and cookies with a domain name as domain-attribute) work correctly.

It turns out that it doesn't matter - for IP addresses, host and domain cookies are the same

Basically yes, but:

Are we sure all browsers actually do treat them as "the same" (i.e. not only same by reading RFC 6265 which is not absolutely clear.) While adhering to RFC 6265 is important the main issue here is that browsers do something differently with this type of cookies than net/http/cookiejar.

From when on are these "the same":

Variant A
If on a Set-Cookie header the domain-attribute is a IP address:
    If domain-attribute != request-host:
        ignore the cookie
    Else:
        treat the domain attribute as absent and process it to the current rules for host-cookies.

Variant B
If on a Set-Cookie header the domain-attribute is a IP address:
        treat the domain attribute as absent and
        process it to the current rules for host-cookies
        that is just set it unconditional in the request-host (be it a domain or an IP)

I think you seem to read RFC 6265 as Variant A which is fine, but again: Is this what browsers do?
It seems browser and net/http/cookiejar treat Set-Cookies with a domain-attribute which is an IP address differently. I think RFC 6265 is not crystal clear here and I agree that your interpretation is possible (and your arguments are a bit more convincing than mine in https://github.com/golang/go/issues/12610#issuecomment-140642614). But any change here should be okay with RFC 6265, and (more import) compliant with how browsers treat these cookies.
I do not think that Variant B would be what RFC 6265 intends, but it could be that browsers do behave that way. And in this case we probably should do B and not A.
I do not think that interpretations of RFC 6265's text are helpful in making any progress here. RFC 6258 is not clear here. This is unfortunate. Interpreting it both ways is possible. Progress here will be made once we understand how browsers handle these cookies. Does anybody have insights here? Do we have to make a test here?

I don't see any ambiguity in RFC 6265.
5.3, step 6 clearly rejects a cookie only if the canonicalized request-host does not domain-match a non-empty domain-attribute. 5.1.3 clearly states that a string domain-matches a domain string if the two are identical.
The request-host is the name of the host to which the user agent sent the HTTP request (2.3). Canonicalization applies to DNS names, not IP addresses, so it is not explicitly stated that the request-host for a request to http://<IP_ADDRESS>/ is <IP_ADDRESS>, however it is clear that this is the intent. (If this is not the case, then 5.6, step 6 makes no sense in the case where the domain-attribute is empty: "Set the cookie's domain to the canonicalized request-host.")
A request to http://<IP_ADDRESS>/ resulting in a cookie with a Domain attribute of <IP_ADDRESS> will therefore set the request-host to <IP_ADDRESS> (2.3), the domain-attribute to <IP_ADDRESS> (5.3, step 4). These strings are identical and therefore domain-match (5.1.3), so the cookie's host-only-flag is set to false and the domain is set to <IP_ADDRESS> (5.3, step 6).
Possibly contemporary browsers do something different, but the behavior as detailed by RFC 6265 clearly indicates that a Domain attribute containing an IP address will match on a request URL containing that exact IP address. (Not, of course, a request URL containing a DNS name that resolves to that address.)

@neild And what conclusion do you draw?
Should we just change Jar and allow "IP-Domain-Cookies"?

This particular issue here would be closed.
Browsers from 2015 seem to behave that way as sebcat's experiments showed.
jongiddy doesn't see any security implications.

Do it and call it a day?
Rating the ambiguity of RFC 6265 on a scale from "crystal clear" to "inconsistent" is a nice intellectual exercise but does it (alone) help in deciding what to do with net/http/cookiejar.Jar? I understand your last
statement

Possibly contemporary browsers do something different, but the behavior as detailed by RFC 6265 clearly indicates that a Domain attribute containing an IP address will match on a request URL containing that exact IP address.

that you argue to change Jar, no matter what contemporary browsers do?
Please do not get me wrong: I'm basically convinced that Jar should be changed in regard to "IP-Domain-Cookies", but I'd like to see more evidence that it will do good to existing (and future) users of net/http/cookiejar.Jar than just "RFC 6265 is clear here". Jar is "broken" since several years and complaints about that "bug" are rare. I just want to see any reason why "fixing" Jar won't introduce other problems for existing users.
I'll retry sebcats experiments on 2021 browses. If their behaviour matches your reading of RFC 6265 I'll prepare a CL.

Testcode
package main

import (
	"fmt"
	"log"
	"net/http"
	"os"
)

var ipaddr = "<IP_ADDRESS>"

func CookieHandler(w http.ResponseWriter, r *http.Request) {
	w.Header().Add("Set-Cookie", "hostcookie=123")
	w.Header().Add("Set-Cookie", "legal=456; domain="+ipaddr)
	w.Header().Add("Set-Cookie", "illegal=xxx; domain=<IP_ADDRESS>")
	w.WriteHeader(200)
	for _, c := range r.Cookies() {
		fmt.Fprintln(w, c.Name, " --> ", c.Value)
	}
}

func main() {
	if ip := os.Getenv("IP_ADDR"); ip != "" {
		ipaddr = ip
	}
	http.HandleFunc("/", CookieHandler)
	log.Fatal(http.ListenAndServe(":80", nil))
}

Systems checked
Mac

Chrome Version 90.0.4430.212
Safari Version 14.1 (146<IP_ADDRESS>.5)
Firefox Version 89.0
Opera Version:76.0.4017.177
curl 7.54.0

Windows

Edge Version 90.0.818.62
Chrome Version 91.0.4472.77
Internt Explorer 11.3630.14393.0

Outcome
All show
hostcookie  -->  123
legal  -->  456

on the second request.
Chrome developer tools and curl's jar file hint that the legal cookie is treated as / has been converted to a host-cookie (like hostcookie).

And what conclusion do you draw?

In the absence of evidence that browsers behave differently, net/http/cookiejar should accept cookies with a IP-address Domain equal to the request-host.
By my read, RFC 6265 states that these cookies should have host-only-flag set to false, but it looks like your empirical tests indicate that browsers set it to true. Following the browser behavior seems okay, although I don't see how following the RFC behavior would result in in different behavior visible to clients.
The internal (*entry).domainMatch function claims to implement RFC 6265 domain-match, but it doesn't include the check to verify that the host is not an IP address. If we do accept cookies with HostOnly=true and an IP address in Domain, that function needs updating.

@neild

The internal (*entry).domainMatch function claims to implement RFC 6265 domain-match, but it doesn't include the check to verify that the host is not an IP address. If we do accept cookies with HostOnly=true and an IP address in Domain, that function needs updating.

Why?
If we accept a cookie Set-Cookie: a=1; domain=<IP_ADDRESS> from <IP_ADDRESS> and process this as if it was a host cookie Set-Cookie: a=1 then e.HostOnly==true and domainMatch is basically e.Domain == host.
Domain matching in RFC 6265 section 5.1.3 is the OR of two bullet points.
The second bullet contains the
conditoion ""he string is a host name (i.e., not an IP address)>

Why?

Sorry; I got the flag backwards. I meant to say the opposite: If we accept cookies with HostOnly=false and an IP address in Domain, then domainMatch would need updating to implement the full domain-match algorithm and verify that the request-host string is not an IP address.
I agree that setting HostOnly=true on these cookies is equivalent from a user perspective and requires the fewest code changes.

If changes are made here, it might be a good idea to consider IPv6 addresses. I.e., URIs of the form http://[::1]/ (see RFC 3986) and whether such host names would translate into domain=::1 or domain=[::1].


Calendar does not use 24 hours format like rest of the Dashboard

Using the latest version 8.3.2. When creating a new event in calendar, the time format is using AM/PM when rest of the site is using 24 hours format.

Full Page Cache Lifetime - Every 6 hours (default setting).

# Server Software
Apache/2

# Server API
fpm-fcgi

# PHP Version
5.6.31

# PHP Extensions
bcmath, calendar, cgi-fcgi, Core, ctype, curl, date, dom, ereg, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, intl, ionCube Loader, json, libxml, mbstring, mcrypt, mhash, mysql, mysqli, mysqlnd, openssl, pcre, PDO, pdo_mysql, pdo_sqlite, Phar, posix, Reflection, session, SimpleXML, soap, sockets, SPL, sqlite3, standard, tokenizer, wddx, xml, xmlreader, xmlwriter, xsl, Zend Guard Loader, Zend OPcache, zip, zlib

# PHP Settings
max_execution_time - 30
log_errors_max_len - 1024
max_file_uploads - 20
max_input_nesting_level - 64
max_input_time - 60
max_input_vars - 5000
memory_limit - 256M
post_max_size - 64M
sql.safe_mode - Off
upload_max_filesize - 64M
mysql.max_links - Unlimited
mysql.max_persistent - Unlimited
mysqli.max_links - Unlimited
mysqli.max_persistent - Unlimited
pcre.backtrack_limit - 1000000
pcre.recursion_limit - 100000
session.cache_limiter - <i>no value</i>
session.gc_maxlifetime - 7200
soap.wsdl_cache_limit - 5
opcache.max_accelerated_files - 2000
opcache.max_file_size - 0
opcache.max_wasted_percentage - 5

I found a lot of localization-related issues in the new Calendar features (see https://github.com/concrete5/concrete5/pull/6380 ).
I'll try to fix this issue too.


Logging time duration for generating onheap dictionary

Some use cases using onheap dictionary are suffering from
high latency until we load all the data on heap. This pr
will provide us how long it takes to generate on-heap
dictionary.

Codecov Report

Merging #4204 into master will increase coverage by 0.18%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4204      +/-   ##
============================================
+ Coverage     67.16%   67.35%   +0.18%
  Complexity       20       20
============================================
  Files          1034     1034
  Lines         51491    51511      +20
  Branches       7214     7214
============================================
+ Hits          34585    34693     +108
+ Misses        14520    14435      -85
+ Partials       2386     2383       -3

Impacted Files
Coverage Δ
Complexity Δ

...ore/segment/index/readers/OnHeapIntDictionary.java
61.29% <100%> (+5.73%)
0 <0> (ø)
:arrow_down:

.../segment/index/readers/OnHeapDoubleDictionary.java
57.14% <100%> (+7.14%)
0 <0> (ø)
:arrow_down:

...re/segment/index/readers/OnHeapLongDictionary.java
57.14% <100%> (+7.14%)
0 <0> (ø)
:arrow_down:

...e/segment/index/readers/OnHeapFloatDictionary.java
58.62% <100%> (+6.62%)
0 <0> (ø)
:arrow_down:

.../segment/index/readers/OnHeapStringDictionary.java
64.51% <100%> (+5.25%)
0 <0> (ø)
:arrow_down:

...he/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
0% <0%> (ø)

...r/validation/RealtimeSegmentValidationManager.java
55% <0%> (-26.67%)
0% <0%> (ø)

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
0% <0%> (ø)

...impl/dictionary/FloatOffHeapMutableDictionary.java
81.81% <0%> (-9.1%)
0% <0%> (ø)

...org/apache/pinot/broker/queryquota/HitCounter.java
92.3% <0%> (-7.7%)
0% <0%> (ø)

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac071f...38cd56d. Read the comment docs.

Should a metric be emitted for this well?

@sunithabeeram Given that this is computed only when we restart the server, I don't think it's necessary to add it as a metric.

Isn't it on every segment load and not just server restart?

Aren’t we first loading the segment before telling Helix that’s its ready to serve?

I don't think this is the root cause of the issue. The root cause is serving queries while loading other segments. The correct way should be first load all segments, then start serving queries (use the start-up check feature)

@sunithabeeram @Jackie-Jiang @kishoreg Actually, loading onheap dictionary should not be the issue. Dropping this pr.


Circular dependency issue in Linux install

It appears there are some dependency issues with this release:
ERROR: black 21.11b1 has requirement typing-extensions>=<IP_ADDRESS>, but you'll have typing-extensions <IP_ADDRESS> which is incompatible.
ERROR: pylint 2.12.2 has requirement typing-extensions>=3.10.0; python_version < "3.10", but you'll have typing-extensions <IP_ADDRESS> which is incompatible.
ERROR: astroid 2.9.0 has requirement typing-extensions>=3.10; python_version < "3.10", but you'll have typing-extensions <IP_ADDRESS> which is incompatible.

This then messed up using my ide:
Traceback (most recent call last):
  File "/home/eafpres/.local/bin/spyder", line 8, in <module>
    sys.exit(main())
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/app/start.py", line 236, in main
    mainwindow.main(options, args)
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/app/mainwindow.py", line 2035, in main
    mainwindow = create_window(MainWindow, app, splash, options, args)
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/app/utils.py", line 289, in create_window
    main.setup()
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/app/mainwindow.py", line 848, in setup
    internal_plugins = find_internal_plugins()
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/app/find_plugins.py", line 92, in find_internal_plugins
    mod = importlib.import_module(entry_point.module_name)
  File "/usr/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 848, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/plugins/pylint/plugin.py", line 25, in <module>
    from spyder.plugins.pylint.confpage import PylintConfigPage
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/plugins/pylint/confpage.py", line 16, in <module>
    from spyder.plugins.pylint.main_widget import (MAX_HISTORY_ENTRIES,
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/plugins/pylint/main_widget.py", line 35, in <module>
    from spyder.plugins.pylint.utils import get_pylintrc_path
  File "/home/eafpres/.local/lib/python3.8/site-packages/spyder/plugins/pylint/utils.py", line 16, in <module>
    import pylint.config
  File "/home/eafpres/.local/lib/python3.8/site-packages/pylint/config/__init__.py", line 43, in <module>
    from pylint.config.configuration_mixin import ConfigurationMixIn
  File "/home/eafpres/.local/lib/python3.8/site-packages/pylint/config/configuration_mixin.py", line 4, in <module>
    from pylint.config.option_manager_mixin import OptionsManagerMixIn
  File "/home/eafpres/.local/lib/python3.8/site-packages/pylint/config/option_manager_mixin.py", line 19, in <module>
    from pylint import utils
  File "/home/eafpres/.local/lib/python3.8/site-packages/pylint/utils/__init__.py", line 47, in <module>
    from pylint.utils.ast_walker import ASTWalker
  File "/home/eafpres/.local/lib/python3.8/site-packages/pylint/utils/ast_walker.py", line 7, in <module>
    from astroid import nodes
  File "/home/eafpres/.local/lib/python3.8/site-packages/astroid/__init__.py", line 51, in <module>
    from astroid.nodes import node_classes, scoped_nodes
  File "/home/eafpres/.local/lib/python3.8/site-packages/astroid/nodes/__init__.py", line 27, in <module>
    from astroid.nodes.node_classes import (  # pylint: disable=redefined-builtin (Ellipsis)
  File "/home/eafpres/.local/lib/python3.8/site-packages/astroid/nodes/node_classes.py", line 47, in <module>
    from astroid import decorators, mixins, util
  File "/home/eafpres/.local/lib/python3.8/site-packages/astroid/decorators.py", line 36, in <module>
    from typing_extensions import ParamSpec
ImportError: cannot import name 'ParamSpec' from 'typing_extensions' (/home/eafpres/.local/lib/python3.8/site-packages/typing_extensions.py)

I'm running Ubuntu 20.04 inside of WSLg under Windows 11

tbparse only requires typing-extensions>=3.6.6, so I'm not sure why pip downgrades the typing_extension package from <IP_ADDRESS> to <IP_ADDRESS>. I tried to reproduce this issue on Ubuntu 20.04 (as mentioned in your Reddit thread), but didn't observe such behavior.
If someone encounters the same issue, creating a new virtual environment may solve the problem. Alternatively, you can use pip install typing_extensions==3.10 as mentioned by @eafpres in the Reddit thread.


Hotfix/expiry tests

Codecov Report

Merging #186 (202e000) into master (c802e80) will increase coverage by 0.02%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   43.32%   43.35%   +0.02%
==========================================
  Files          32       32
  Lines        4579     4569      -10
==========================================
- Hits         1984     1981       -3
+ Misses       2595     2588       -7

Impacted Files
Coverage Δ

assemblyline_core/updater/run_updater.py
27.48% <0.00%> (-0.19%)
:arrow_down:

assemblyline_core/expiry/run_expiry.py
69.23% <85.71%> (-0.08%)
:arrow_down:

assemblyline_core/scaler/scaler_server.py
29.91% <0.00%> (-0.73%)
:arrow_down:

assemblyline_core/dispatching/dispatcher.py
74.90% <0.00%> (-0.47%)
:arrow_down:

assemblyline_core/server_base.py
77.41% <0.00%> (-0.15%)
:arrow_down:

assemblyline_core/dispatching/client.py
77.85% <0.00%> (ø)

assemblyline_core/alerter/processing.py
88.48% <0.00%> (+6.60%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 193ec56...202e000. Read the comment docs.


upgrade to the latest docker maven plugin

upgrade to the latest docker maven plugin

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/fabric8-quickstarts-master-pullreq/434/
Test PASSed.


[Feature](table function) support explode_json_array_json

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.62 seconds
stream load tsv:          505 seconds loaded<PHONE_NUMBER>9 Bytes, about 141 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size:<PHONE_NUMBER>8 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230714115708_clickbench_pr_178329.html

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.27 seconds
stream load tsv:          506 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>0 Bytes


This ought to wait

OpenAI set a very restrictive ratelimit for gpt-3.5-turbo-0613 (1 token per minute) on the formal-generic organization. This has to wait.

haha there's plenty of models. I can pick another one. p sure some lean user is using the model I'm using


About :LSoutlineToggle

Description
When I run the command :LSoutlineToggle.
Expected Behavior
open the outline
Actual Behavior
It reports the error as the pic shows
Neovim Built in Behavior

Details

Reproduce

open the nvim
select a .ts file or other file
run the command LSoutlineToggle

Environment

nvim --version output: v0.8.0
Operating system:
lspsaga commit:

outline had been refactor in #586 . please wait for #586


eslint-plugin-typescript-sort-keys 1 major failing

Describe the bug
The version 1.x.x of the dependency eslint-plugin-typescript-sort-keys is not working.
Expected behavior
No error during the lint.
See https://github.com/infctr/eslint-plugin-typescript-sort-keys/issues/17

Was somehow related to https://github.com/jaydenseric/extract-files/issues/13.
Upgrading from node 13.7.0 to 14.3.0 fixed an error.


fix: IDE Header Height usage

Description
Fixes incorrect usage of IDE Header Height which caused bug in the Menu location
Fixes #36284
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10843283682
Commit: 0868d06021b2cf16bd7c7172068cf476d26c3a6f
Workflow: PR Automation test suite
Tags: @tag.IDE
Spec: ``
Fri, 13 Sep 2024 05:01:43 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

Style

Enhanced CSS properties for better rendering consistency across browsers in the Editor component.
Improved formatting for better readability.

/build-deploy-preview


Bio-Formats 6.9.1 updates

Updates to bump Bio-Formats version, add release announcement and new contributors.

Conflicting PR. Removed from build WEBSITE-push#509. See the console output for more details.
Possible conflicts:

PR #583 jburel 'Release 5.6.4'

index.html

Upstream changes

index.html

--conflicts

Conflicting PR. Removed from build WEBSITE-push#50. See the console output for more details.
Possible conflicts:

PR #583 jburel 'Release 5.6.4'

index.html

Upstream changes

index.html

--conflicts

Conflicting PR. Removed from build WEBSITE-push#728. See the console output for more details.
Possible conflicts:

PR #583 jburel 'Release 5.6.4'

index.html

Upstream changes

index.html

--conflicts


Access to production queue in a replay?

Is Observation()->GetRawActions() truly raw actions, or effective actions? If so, then one could filter the actions for production actions and work with that, however it would be advantageous to have access to the production queue for better replay analysis on the macro side of things.

I am not sure what you mean by "raw" and "effective". GetRawActions will contain the production action on the gameloop the action was added to the build queue. (The term "Raw" in the name is just to distinguish it from the "FeatureLayer" version of the same function)
If you just want to inspect the state of the production queue, it exposed in Unit::orders.
It seems like the documentation for that isn't great. The "order" field behaves differently for regular units and production buildings. For regular units like marines the orders are things like move/attack. For production building that don't take regular order like move, it contains their production queue.


Button to delete inactive projects

When a project has been deactivated you can now delete the project.

Thanks @acrogenesis!


Return connection errors from the heartbeat task to the Client

Motivation
We're seeing  "failed servers must set their error slot" panics when Zebra is overloaded.
This panic is caused by the design of the Client connection code. Currently, the Client tasks share an ErrorSlot mutex, which must be updated before they exit.
This ticket stops using the error slot in the heartbeat task.
Designs
Instead of using the error slot, Client tasks should exit and return an error to the client instance.
The Client should exit when any task errors or stops.
We could try something like this:
(click for details)

Replace Client.error_slot with returning a PeerError:

end the task when there is a permanent connection error, returning `Result<(), PeerError>’
check the error via the JoinHandle in the Client
shut down the Client when the heartbeat task exits or errors

Related Work
This is part of:

#3263

Here's the code we need to change:
https://github.com/ZcashFoundation/zebra/blob/42ef8846b34887ecd3635202451d75819e2994db/zebra-network/src/peer/handshake.rs#L1098-L1117


KAFKA-10158 Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

TopicCommandWithAdminClientTest.testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress frequently fails on my local.
Altering the assignments is a async request so it is possible that the reassignment is still in progress when we start to verify the "under-replicated-partitions". In order to make it stable, it needs a wait for the reassignment completion before verifying the topic command with "under-replicated-partitions".
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Could you link the patch to the JIRA and give a summary of the failure, and why this wait for reassignment would fix the problem?

done. https://issues.apache.org/jira/browse/KAFKA-10158

close as #9022 offers a better solution


It is great, but CocoaTextField not support Chinese and Japanese.

Describe the bug
It is great, but not support Chinese and Japanese.
To Reproduce
Just add a Chinese or Japanese keyboard then switch to it, type any words in CocoaTextField, the first word is correct, type one suggestion word, then type any words always are English.

@gliese667c this has been reported before - I'm really not sure what's causing the problem. Could you copy CocoaTextField's implementation and play around with it?

I don't know what the problem is, it' s very weird.

There's an interesting discussion here:
https://github.com/ReactiveX/RxSwift/issues/649
.. it's about RxSwift, not SwiftUI, but it seems rather relevant - as it applies to languages that have multistage text input (such as Chinese and Japanese), and two-way binding.
Note, especially, their fix:
https://github.com/ReactiveX/RxSwift/issues/649#issuecomment-215983367
/**
    Reactive wrapper for `text` property. Notifications are fired only when when there
    isn't any marked text.
    */
    public var rx_nonMarkedText: ControlProperty<String> {
        let textProperty = self.rx_text
        return ControlProperty(
            values: textProperty._values.filter { [weak self] _ in self?.markedTextRange == nil },
            valueSink: textProperty._valueSink
        )
    }

I have no familiarity with these languages and with multistage text editing, however it seems that, while the UITextView has undetermined text (with markedTextRange != nil), you should not fire a notification (update the binding property).
I may be barking up the wrong tree – again, no familiarity with this issue and the languages mentioned.

@mvarie I'll take a look, thank you!

@mvarie I'll take a look, thank you!

I have the same issue.

@gliese667c @mvarie @stevema this has now been fixed! Thank you for your patience.

@gliese667c @mvarie @stevema this has now been fixed! Thank you for your patience.

This issue still remains in TextView component.  Add guard textView.markedTextRange == nil, text?.wrappedValue != textView.text else { return } in textViewDidChange(_ textView: UITextView) function can fix this too.

这是来自邮箱的自动回复。来信已收到，我会尽快回复给您。

@n41l @vmanot Yes, the bug still remains in 0.1.2, plz reopen the issue.

This issue still remains in TextView component. Add guard textView.markedTextRange == nil, text?.wrappedValue != textView.text else { return } in textViewDidChange(_ textView: UITextView) function can fix this too.

这是来自邮箱的自动回复。来信已收到，我会尽快回复给您。


Draft PHP 8.0 min.

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

This is a preliminary version, some comments:

The version of PHPUNIT was increased to 9.6.
Compatibility patches have been removed.
The db tests were moved from build to each db ci, so they won't be tested twice and they will run faster.
The code was not touched, and only changed in tests, depreciated assertions.
Added tests for each db controller, for 8.0, 8.1, 8.2.
The tests for PHP 8.0 for some reason keep getting the segment fault error, so the ci has continue-error: true, but the tests all run correctly.
The Object::class was renamed to ObjectDeprecated::class to avoid the error when executing the tests.

The tests for PHP 8.0 for some reason keep getting the segment fault error, so the ci has continue-error: true, but the tests all run correctly.

I think we can skip 8.0 and go with 8.1 as minimal version.

The version of PHPUNIT was increased to 9.6.

Should it be 10?

Code coverage went up a bit, you have to improve the tests and increase it, but it will be in another PR.
Build-node tests need to be fixed, we need help here.

👍

Nice 👍


⚠ ClamAV has degraded performance

In 061eea2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 82 ms

Resolved: ClamAV performance has improved in 4a70228.


Added the contributors page

"Fixes #461 "

[ x] I have performed a self-review of my code
[ x] My changes generate no new warnings
[ x] I am working on this issue under GSSOC

https://github.com/Satyam1923/Spring-Music-Player/assets/154724111/1d35222a-5b72-4e4a-80fe-b048e008801e

@Satyam1923 Pls review this PR!!!

change white to grayish like other ui elements.

okk

@Satyam1923 Check now and can I get level2 for this?


I dont know how to remove the wallpaper and sticker from vscode.

I also messed up in the setting, pls help.

While the doki theme extension in still installed.

Open up the command palette https://code.visualstudio.com/docs/getstarted/userinterface#_command-palette
Type in remove
Choose Remove Sticker/Background
Restart VSCode

https://user-images.githubusercontent.com/15972415/217690476-4131e3b7-fb61-4d21-9017-8be3d8dca969.mp4


Sorting code

Do you still have the sorting code that you removed a while back? The Zotero-native sorting code doesn't work anymore in Zotero 5. I'd be happy to host the tool on my github and put it back if you had that available.

Hm, no, I'm afraid if it's not here I don't have it...


Manifest can Update Environment Variables for an App

Is there a related GitHub Issue?
#156
What is this change about?
The environment variables provided in a manifest will now update an application's environment variables. This is done as an additive patch, and any environment variables on the app that weren't specified in the app will retain their existing value
Does this PR introduce a breaking change?
No. There is a behavioral change though. Previously, only Apps with environment variables would have Secrets created for them. Now all Apps have a Secret. Also, the Secret now has an OwnerRef back to the App so it will be garbage collected now.
Acceptance Steps
See #156
Tag your pair, your PM, and/or team
@akrishna90

Had to rebase the branch against main... waiting for tests to pass here before merging

This PR is superceded by https://github.com/cloudfoundry/cf-k8s-controllers/pull/249 so I'm closing it


Put caching in all invocations of ptrref_from_ptrcls

We're leaving this out after conversation with @eprans.


installation on linux computer?

Hello,  i have some trouble to compile and install the mt3dms sources on my linux computer with gfortran?  I was wondering if someone has already done this and got a makefile. This will help me a lot. Thank you, Marc

Maybe try here first?  https://github.com/MODFLOW-USGS/executables


I found that part of the official document is inconsistent with the code

I found that part of the official document is inconsistent with the code. For example, websocketcachehandler can't be found in the code. I hope you check it carefully. Thank you

Hi, you can modify the document directly from the website. Recently, it has been modified.

See the lastest document. Thanks.


How to add error highlights for Importing Unknown Packages or Modules in Monaco Editor for newly registered Language Java?

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[X] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response
Reproduction Steps
No response
Actual (Problematic) Behavior
Currently we are integrating Java Language Server to Monaco Editor. There when I am trying to import unknown modules or packages it is not throwing warning or errors.No Error for Unknown Package. Tried using Tokenizer but didn't worked out.

Expected Behavior
When I am importing any unknown package or error I want error some thing red lines below the package name. Similar to how we will get for typescript. I want to know how to add these type to monaco editor for a new language that we are registering.

Additional Context
No response

I'm sorry it doesn't seem to be working, but with so many requests that we get here and in the VS Code issue tracker, we just cannot provide the support we would like to offer.
You can try asking your question on stackoverflow.
That said, if you can track down your issue to a specific problem of the Monaco editor, we are more than welcoming a PR by the community! Please use the bug-report issue template to report the issue.
Thanks for your understanding!


Add launcher test utils

I suggest to make it two separate modules available under different set of features (test-database and test-server). For some cases (see eth-bytecode-db//tests) we may need to initialize only database without the server, and in that case it may make sense to use only one of the modules.
Also, maybe it would be possible to drop the database when the test fails? In my experience, it may be become a mess sometimes when you have lots of test cases persisting in the database from all kind of tests. I believe it may still be useful in some cases (but is not in most), so if we could set it explicitly on initialization if the database should be dropped (but drop it by default) would be really great. I'm not sure if that is possible, though


Failed to compile quantized model

Hi, I am trying to convert a frozen graph to a quantized model which is able to run on edge tpu.
And I tried several configurations, however, none of them worked.
Here are the details:
with tensorflow < 2.4.0:
unable to quantize
with tensorflow 2.4.0:
unable to quantize
error log:
Traceback (most recent call last):
  File "opt.py", line 20, in <module>
    tflite_quant_model = converter.convert()
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/tensorflow/lite/python/lite.py", line 1947, in convert
    return super(TFLiteConverter, self).convert()
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/tensorflow/lite/python/lite.py", line 1313, in convert
    result = self._calibrate_quantize_model(result, **flags)
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/tensorflow/lite/python/lite.py", line 461, in _calibrate_quantize_model
    inference_output_type, allow_float, activations_type)
  File "/opt/conda/envs/tf2/lib/python3.7/site-packages/tensorflow/lite/python/optimize/calibrator.py", line 104, in calibrate_and_quantize
    np.dtype(activations_type.as_numpy_dtype()).num)
RuntimeError: Quantization not yet supported for op: 'SQRT'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'SQUARED_DIFFERENCE'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.
Quantization not yet supported for op: 'DIV'.

with tensorflow 2.5.0 :
able to quantize
unable to compile
error log:
Edge TPU Compiler version 15.0.340273435
Invalid model: tensorflow-2.5.0.tflite
Model not quantized

with tf-nightly-2.6.0.dev20210507:
able to quantize
unable to compile
error log:
Edge TPU Compiler version 15.0.340273435
Invalid model: tf-nightly-2.6.0.dev20210507.tflite
Model not quantized

with tf-nightly-2.7.0.dev20210705:
able to quantize
unable to compile
but the error log is slightly different.
Edge TPU Compiler version 15.0.340273435
ERROR: Didn't find op for builtin opcode 'SQUARED_DIFFERENCE' version '2'

ERROR: Registration failed.

Invalid model: tf-nightly-2.7.0.dev20210705.tflite
Model could not be parsed

And here are the frozen pb model, quantized models, and conversion script. Thanks
https://drive.google.com/file/d/1EDmfcATV6_37BO1NTpKU7lnX5fxCJ9NL/view?usp=sharing

@dentigo can you share your saved model?
try to convert using one of the methods below:

tf.lite.TFLiteConverter.from_saved_model() (recommended): Converts a SavedModel.

tf.lite.TFLiteConverter.from_keras_model(): Converts a Keras model.

instead of tf.compat.v1.lite.TFLiteConverter.from_frozen_graph  method.
Reference: https://www.tensorflow.org/lite/convert

@dentigo can you share your saved model?
try to convert using one of the methods below:

tf.lite.TFLiteConverter.from_saved_model() (recommended): Converts a SavedModel.
tf.lite.TFLiteConverter.from_keras_model(): Converts a Keras model.

instead of tf.compat.v1.lite.TFLiteConverter.from_frozen_graph method.
Reference: https://www.tensorflow.org/lite/convert

Actually, its a tensorflow 1.x model which can be only converted from frozen graph/session/saved_model (tf1 version).

@dentigo have you tried using tf1.x saved_model?

@dentigo please try with the new compiler. I am able to compile the tflite files with new compiler.


Asset path wonkiness

Use url() to ensure we're always making root-relative URLs. I accidentally'd the prefixed / on the Modernizr script in #5373 so it was requiring relative and (duh) not existing. This fixes that and also runs asset paths through url() so we don't make that mistake again in the future!
Also renames PARANEUE_DS_PATH to PARANEUE_PATH since it reads easier.
For review: @weerd

¡OLÉ! :dancer:


Appstudio update test-component-pac-ntsj

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-ntsj-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
11 seconds
init

✅ Succeeded
34 seconds
clone-repository

✅ Succeeded
3 minutes
build-container

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
1 minute
deprecated-base-image-check

✅ Succeeded
4 minutes
clair-scan

✅ Succeeded
3 minutes
clamav-scan

✅ Succeeded
1 minute
sbom-json-check

✅ Succeeded
26 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


Audit and document "paths" in Tekton Pipelines API

Expected Behavior

It should be clear to users of Tekton Pipelines what special directories will be available to executing containers, what the contents of those directories are, and what the consequences are of editing them.
It should be clear to contributors as well, and all directories should be defined in one location in the code

Actual Behavior
There are a number of special directories, but I'm not sure how many or how they relate to each other. There is no one place in the docs to find this info, nor one place in the code (paths like /builder and /workspace are often hardcoded directly).
Additional Info

These directories should be considered part of the Tekton Pipelines API (https://github.com/tektoncd/pipeline/blob/master/api_compatibility_policy.md)
We may want to consider randomizing some of these dir names (e.g. in case someone tries to use a container that has a /workspace already)
While doing this investigation we may discover that we want to actually change some of these paths

/assign @houshengbo

@bobcatfish
Thanks for raising this issue. I have been thinking of the special folders and got baffled all the time.
I used to submit a PR to shield the folder names /workspace/source from users for kaniko: https://github.com/tektoncd/catalog/pull/32.
I actually propose the idea that we keep these special folders as internal as possible, so that user do not need to care about them UNLESS they have to.
With that being implemented, instead of using paths like, /workspace/user_path/something, or /builder/user_path/something, etc, users can directly apply user_path/something. For example, the github repo is taken as the source, we can directly use the path under the home dir of the github repo, like github_path, instead of /workspace/hardcode_source_name/github_path.
IMO, there are really many benefits: 1. We surely simplifies how we use Tekton. Folks only care the path they need to care. 2. Since all the hardcoded path or folders are shielded away from users, we do not have to document these special folders as well. It is a simplification of reading our docs.
Does it make sense?

That's an interesting idea @houshengbo !
I think there are kind of 4 main use cases (maybe some others I'm not thinking of):

Paths to PipelineResources, i.e. inputs and outputs, which have always been at /workspace
Paths to implementation details that users (hopefully) shouldn't have to know about but which are important to ppl working on Tekton Pipelines, e.g. /builder/tools/entrypoint which is the path to the entrypoint binary
The home directory of the node is made available in /builder and is common between steps
Users provide data back to the controller, e.g. the path to a built image digest defaults to /builder/home/image-outputs/{resource-name}

I think what you are proposing would address (1) by making it so that path to resources is always /<resource name>/? (I think (2), (3) and (4) are unrelated?) I think the biggest downside here is that it makes it way more likely that the paths to resources will conflict with paths on the node or in the executing container. E.g. if you called a resource etc you would be conflicting with /etc on disk. Knowing that all resources will predictably be in /workspace reduces the potential conflicts significantly (and if we added randomization onto that, e.g. /workspace-<some-guid>/ then the chances would be almost 0).

A small issue related to name conflicts: right now weird things might happen if we have an input resource named output and another output-only resource ;)

I think we might consider simplifying things for the stuff we get for free, and should either go all-in on "workspace" as a concept or not at all. I get the idea of targetPath customization for input and output resources but it really dilutes the value of the "workspace". Setting HOME to /builder is confusing but perhaps I could be educated here.
Anyway...
If "all-in" for /workspace we would for the task containerspec:

Create a /workspace volumeMount pointing at a shared randomly named emptyDir volume
Set HOME to /workspace
Set workingDir to /workspace
Always map inputs to /workspace/input/{input-name} and output to /workspace/output/{output-name}

[This is basically what we have today with a change to HOME and no targetPath resource support]
OR

Do not create a workspace volume (A user can do this manually)
Do not set HOME (Again can be done manually)
Do not set workingDir (Again can be done manually)
A user MUST provide a mountPath for all input and output

[So efficient... but takes away some of the value of Tekton convention]


Error in train.sh

_I am trying to run example data for training (train.sh) but getting the following error:
WARNING:tensorflow:From ~/.local/lib/python2.7/site-packages/tensorflow/python/ops/nn_impl.py:180: where (from tensorflow.python.ops.array_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.where in 2.0, which has the same broadcast rule as np.where
WARNING (2019-09-26 15:41:00,377): From ~/.local/lib/python2.7/site-packages/tensorflow/python/ops/nn_impl.py:180: where (from tensorflow.python.ops.array_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.where in 2.0, which has the same broadcast rule as np.where
INFO (2019-09-26 15:41:00,617): Loading data ...
INFO (2019-09-26 15:41:00,908): Initializing callbacks ...
Traceback (most recent call last):
File "~/.local/bin/dcpg_train.py", line 836, in
app.run(sys.argv)
File "~/.local/bin/dcpg_train.py", line 195, in run
return self.main(name, opts)
File "~/.local/bin/dcpg_train.py", line 790, in main
callbacks = self.get_callbacks()
File "~/.local/bin/dcpg_train.py", line 459, in get_callbacks
if K._BACKEND == 'tensorflow' and not opts.no_tensorboard:
AttributeError: 'module' object has no attribute '_BACKEND'
Can you help what is this error about?_

Thanks for pointing this out. I removed the K._backend test. It should work once you synced to head.


DNSCrypt Failures

I am experiencing several issues with DNSCrypt.  It is running on OSX 10.11.6 - fully updated.

Connection to the automatically selected DNS server is lost and never re-establishes unless I manually go choose a new DNS server. Often even that fails.  This happens frequently - at least once per day, sometimes many times per day.  Despite having DNSCrypt installed and running most of the time it is not in effect.

Many returns given from a Google Search are not accessible!  If I turn off DNSCrypt I can easily get to the applicable Website.  These are very common Websites that have been in operation for many years.

For Websites I can get to if I attempt to invoke a link from the Home page the operation fails.  This is especially prevalent if it is a Website that requires the user to Login.  The Login link does not function.  If you put the Browser in Debug mode you immediately see that the Login link cannot be resolved.  As soon as DNSCrypt is turned off then the Website works fine.

These issues add up to DNSCrypt being an impediment, not a benefit.  DNSCrypt used to be very reliable.  But over the last year it has become a severe impediment to getting anything done.

Hi,
Sorry to hear that you are having issues resolving some DNS names in a setup involving DNSCrypt.
DNSCrypt is a protocol, not a product. Are referring to the dnscrypt-proxy client? How did you install it and how are you starting it?
Are you using a VPN at the same time?


GetConsoleOutputCP and GetConsoleCP should document error return

I encountered an issue where GetConsoleOutputCP was returning zero, but my code didn't realize that was indicating an error, because the documentation said nothing about this case.
Please add the standard wording for these APIs stating that a return value of zero, to get extended error info call GetLastError(), etc.

Complete.


remove emoji from landing page

Fix #1125
The emojis are hard coded in the .md file which is crashing the windows build. Instead of adding extra env parameter I suggest we stop using emojis in the card header and move to fontawesome icons instead.
I also replaced the one in the readme with markups which is nicely interpreted in all the parsers I know

argh, 1485849 didn't work, they're all black/white: https://pydata-sphinx-theme--1151.org.readthedocs.build/en/1151/
I'll fix it after lunch


Request to merge changes made for nginx setup

Move client.Jenkins to frontend folder
Reconstruct the BASE_URL in routes.jsx
Add Openshift templates to openshift folder

 DevOps | Add NGINX web server to the application and server react code from NGINX (vs. Node) |5| [url forwarding] [reverse proxy] [v0.0.3-alpha]


Javadoc comments with multiple lines not converted to XML documentation

This code will create a summary comment properly
/** Cool field that contains something. */
public int awesomeField;

This code will not
/**
 * Really cool field that contains something.
 * Keep in mind that this field is cooler than awesomeField.
 */
public int reallyAwesomeField;

This is the case with everything, not just fields.

 Maybe try to detect the line endings of the file rather than using Environment.NewLine?


Cleanup analyzers/base in preparation for Java indexer plugin support [phab:D1864]

Created by schroederc at 2017-08-14 16:53:52:

zarko accepted this revision at 2017-08-14 17:17:06

schroederc closed via commit a541ce4bbce4e23c791bf3e9f386744ea80d142c at 2017-08-14 17:20:10


Fix timetravel bugs

Short description

Fixes various timetravel bugs (see below).
In short: timetravelling works, as long as you just want to SEE. If you want to CHANGE things in the past or in the future..... Yeah I think this is not worth the effort.
Please check out any and all edge cases you can think of while keeping the above in mind 😅
Proposed changes

the DB is now properly refreshed after leaving timetravel; previuosly, the last timetravelled-to objects were still shown
the time entered in the output field no longer differs by 1 hour after redirecting (thanks for pointing this out, @noworneverev)
the time travelled to is no longer offset by one hour compared to how the objects are filtered (separate bug, lol)

Side effects

Resolved issues

Fixes: #71 (I guess...)

* When I time travel in ward view, then I switch to timeline mode, the time travel is cancelled and I'm back to the current time. I think this behavior is expected right? If so maybe disable the switch button when user starts time travel. It's unexpected for me that when I switch to timeline and I suddenly back to today.

Fair point. The reason this happens is that multiple redirects happen after clicking the switch, and the GET parameters get lost. I'm sure it can be fixed, but IDK if it is worth the trouble; deactivating the switch sounds like a good idea.

* Is it possible to focus on the date time travel bring me to in timeline mode? When I choose a date, I don't know if it succesfully bring me to the future or past, as it always focus me on today.

Similarly here, I'm sure it's possible, but the timeline has its own way of setting the date. Do you think this is worth trying? The laternative is just not showing the timetravel link in the timeline. After all, the timeline lets us see "all of time", and there's little point in timetravelling there 😄

Could you check if the new solution works for you?

* When I time travel in ward view, then I switch to timeline mode, the time travel is cancelled and I'm back to the current time. I think this behavior is expected right? If so maybe disable the switch button when user starts time travel. It's unexpected for me that when I switch to timeline and I suddenly back to today.

Fair point. The reason this happens is that multiple redirects happen after clicking the switch, and the GET parameters get lost. I'm sure it can be fixed, but IDK if it is worth the trouble; deactivating the switch sounds like a good idea.

Sorry I just found it's frustrated that I cannot click the button whenever I want, I prefer the version before this commit😅.

* Is it possible to focus on the date time travel bring me to in timeline mode? When I choose a date, I don't know if it succesfully bring me to the future or past, as it always focus me on today.

Similarly here, I'm sure it's possible, but the timeline has its own way of setting the date. Do you think this is worth trying? The laternative is just not showing the timetravel link in the timeline. After all, the timeline lets us see "all of time", and there's little point in timetravelling there 😄

I test the timeline, but it can only see the current time onward, I cannot see past stays in timeline.

Oh, right! Forgot about that.

Just to get back on this: It's not a bug, it's to speed up the loading time. Also, we would need to implement a way to lock past bed assignments from being changed retroactively, and filter all of them out before sending them to the solver. IMO it's just a lot of work for virtually no benefit.


Improve instructions how the user should resolve different code coverage issues

If code coverage is too low
If actual code coverage exceeds expected

https://github.com/schubergphilis/mcvs-golang-action/issues/108


Log failed access attempts regardless of settings

Fixes #212

Coverage increased (+0.1%) to 89.201% when pulling a2efeeb018821a29979186615d731445573f5a4c on Maplecroft:master into fd8cf9aeded6db9382dc45a4ee0e0e7424cf698b on jazzband:master.

Thank you

No problem, thanks for merging. Do you think you'll push out a bugfix release to PyPI any time soon?


Update c5a33478-ba81-414d-ad52-804f5da8facf.xml

Add autoshowtaskpane taskpane id to manifest

Is this PR still required, or can we close it?


Change result_key for kinesis to StreamDescription

I'm not sure if this change is preferred behavior, but it should fix this issue: https://github.com/aws/aws-cli/issues/2001
When result_key is StreamDescription.Shards, you can't query for the ARN with "--output text" without "--no-paginate" but you can with "--output json", so I figured this was a paginating issue.

Codecov Report

Merging #1284 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1284   +/-   ##
========================================
  Coverage    98.05%   98.05%
========================================
  Files           45       45
  Lines         7396     7396
========================================
  Hits          7252     7252
  Misses         144      144

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04d301...369026f. Read the comment docs.

Unfortunately, I don't think this will actually work. Setting the result_key to StreamDescription might let you apply the query you want this will actually break the merging of the pages (the last page will win I believe) as the behavior for merging two dictionaries is currently undefined. The result_key must point to a list.


Fix cosem images download error

Description
Some COSEM datasets were not downloadable because of the extra slash in the CosemImage class url field.
Example:
dataset = CosemDataset.fetch("jrc_mus-kidney")
segmentation = dataset.image(name="empanada-mito_seg")
segmentation.read(-1)

throws an error IndexError: Level -1 not found in 'empanada-mito_seg'. Available levels: []
Changes
Added a validator to the url field to strip the extra slash and fix the error.

thank you @veegalinova!