Add link and list package

Resolves #59 and #61 by adding a list and link package. There is only HTML support as of now, so if this gets merged issues for adding LaTeX support should be created. Probably should have split this up into two PRs but the link package was so small I just kept going, if it is a big deal I can split it up now. Could have made the commits reference the larger issues (#57) instead maybe, not sure how to work with small issues in the best way.
Please test the packages to make sure they are working, I have been sick and tired when finishing up :p

Resolves #59
Resolves #61

Additionally, it seems like it doesn't work to number list items 1., 2. and 3., just to number them 1., 1. and 1.. See screenshots. To me, it seems that it should work. You may look at Djot, they allow any numbers, so you may number a list 4. 3. 11. to get 1. 2. 3., or enforce a strict order, but 1. 2. 3. should at least be okay in my mind.

This also resolves #61, but the PR body wasn't formatted so GitHub picked up on it. Edited your PR body to work correctly

Just a heads-up: it seems like you have gotten a merge commit into your branch. This is not good, since merge commits are not allowed in main. I know that I have gotten a lot of problems when I accidentally got one in my branch. Try to rebase again to flatten your branch.

Ye no worries I am aware, fixed a cargo.toml conflict in the web editor and it merged, wanted to see if it would rebase. I'll fix it =).
On another note djot seems to ignore all but the first list item, and it starts the order from that. So 4. 1. 2. becomes 4. 5. 6. Seems reasonable so I will try and implement that.

Ye no worries I am aware, fixed a cargo.toml conflict in the web editor and it merged, wanted to see if it would rebase. I'll fix it =).
On another note djot seems to ignore all but the first list item, and it starts the order from that. So 4. 1. 2. becomes 4. 5. 6. Seems reasonable so I will try and implement that.

Yeah I noticed that later when I tried it out. I think it is to allow "broken" lists like:
1. This is one item
2. This is a second item
and here is some text explaining the second item
3. Here is a third item, numbered 3

Really good job! I tested it a bit in preview, I think it looks very good! The only two things I would comment on is:

It would be nice not having to have a space (I think the dot as a separator in 1., 2. is verbose enough so we don't really need a space as well). I know you have talked about this earlier, and if you think it is too much of a hassle to fix, feel free to skip it!
When actually using it, I think four spaces are too much to need as an indent. I think two spaces is enough and that it is most likely more annoying than helpful to need to have four spaces.

But as said, good work! I love how you can change numbering mid-list by doing
I. This is numbered "I"
I. This is numbered "II"
1. This is numbered "3"

I don't know if it is intentional or not but it is a fun easter-egg. This, unfortanely, breaks down if you do this:
a. This is labeled "a"
b. This is labeled "b"
c. This is labeled "iii" since it treats the "c" as a roman numeral

I don't know if that is too hard to fix or not, and what the best way to fix it is. If you don't think it is worth the effort, skip it. But good job with the module!

I'm not sure I agree with your second point, since you get 4 or more spaces using tab in many if not most editors. In our playground, tab works just fine with this version of list.
I suppose you could add an indent argument so that the user can customize it to their needs.

I am unsure myself, and yes I know most IDEs default to 4 spaces. My initial thought was that that it took some time to write 4 spaces in the playground, didn’t notice you could use tabs, so that was nice! Keep it at 4 then :)

What about the numbering "issue" when doing a. b. c.? Is that something fixable/worth fixing before merging/something intentional? We could just disallow such label switching, or just allow it after a broken list, not mid-list, maybe? Or if it is too troublesome, skip fixing it!

I can chip in and say great work as well! :smile:
I have a question about this though. It was a long time since I dealt with lists in HTML, but this should only be a <ul> and a <ol> right? It seems like a new table is created for each table item  + a extra at the start.

Hm, I think I will skip the . or ) delimiter for now and use the space, does not feel like it is worth spending time on it when there are other issues that can be handled. I used 4 spaces due to tab but I agree that adding an indent argument would be nice, I will do that today it should be easy.
I am not sure how we should handle i) or c) or m).... These are both valid alpha and roman so there could be cases where you want one or the other.  I like the fact that you can switch in the list, djot does not allow this and that way avoids it. The only time this is an issue if you want to start a list with c or i as an alpha. Especially for c this might be something you want to do. Could add an argument to say what should take precedence.
@adelhult ye it would give the same result with one  tag and multiple . The reason it keeps creating lists is because this was the easiest way to make sure that the starting and types are right, but if the type is the same it would be enough with just another . Does not seem to be a problem even though it is a bit unconventional.

If we disallow switching numbering system mid-list, it would not confuse ”a b c”, or if we check if it matches the ”normal” next-following tag (if we have ”a. b.” we check if next is ”c.” and then never change the numbering) would probably work as well. Don’t know what is best

I think a. b. c. is fine because you can do a. a. a. for the same result, the only problem is starting a list with c or i

Added indent argument but found a bug if the list starts with a bullet then uses a number it will not start with that. Will fix tomorrow.

Great work! I don't know if the indent argument is necessary, but it can't be bad. The only thing I feel might be problematic is that, as stated before,
[list]
a. Item
b. Item
c. Item
d. Item
e. Item

gives this:
a. Item
b. Item
iii. Item
iv. Item
e. Item

which is unexpected. But I see your argument above that a. b. c. d. e. is still expressible by a. a. a. a. a., and if you feel like it is not worth fixing, don't. Otherwise, amazing work!

It's not that I don't think its worth fixing, I'm just not sure how I would go about it. I like having the ability to switch types in the list. I would like to be able to start a list with c or d though and I think that will be much more common than wanting  to start with the roman numeral c so I think I might just make alpha take precedence over roman


Version 1.3?

wondering if this is still being worked on or if you gave up on it, but it looks like the latter is definitely the case here which is sad seeing as this is practically a one of a kind plugin for pocketmine. Hope i'm wrong though.

I won't discontinue this project.


fix(lightbox-carousel): accessibility & QA improvements to lightbox carousels

Related Ticket(s)
Closes: #8911 #8913 #8915
Also related: #8912 #8914
Description
This PR makes several accessibility improvements to the DDSCarousel and DDSLightboxMediaViewer components, as well as the lightbox carousel story
#8911 Update Lightbox to use semantic headings ✅
Lightbox titles now render title text within
 tags. This gives them semantic h2 headers but does not bring along the user agent/carbon styles for the element.
#8912 Add label for modal dialog ✅
While elements with [role="dialog"] are required to have a label for WCAG, that label should be relevant to the content within the dialog. Because the component cannot know what content (or even what language) is in it, all we can do is make space for content entry. This already exists within the component in the form of an aria-labelledby attribute pointing to a div that accepts slotted content. This PR adds a visually hidden modal title to the lightbox carousel story
#8913 Announce carousel navigation to screen reader ✅
The carousel's renderStatus() method now renders a visually-hidden span with aria-live="polite" and uses a new formatAnnouncement property function to format that announcement into a string that accounts for single slides or slide groups. This property is written adjacent to the formatStatus property that allows localizing the pagination information.
#8914 Create new landmark region for carousels ✅
~No changes were made for this ticket.~
~8914 suggests, "to provide more context to the screen reader user, the carousel which includes the slides and the Carousel controls could be given in a labelled landmark region." While this would be good, wouldn't adding a landmark region require a label that describes what is in the carousel, not just that it is a carousel? It would not be difficult to add a fallback label if this is not the case.~
The carousel now has an additional
 wrapping the scrolling contents and the navigation. This div has role="region" and an aria-labelledby attribute that points to a new div with a <slot name="title">Carousel</slot>. This allows authors to provide a title relevant to the carousel's contents with the generic fallback label of "carousel"
#8915 Update carousel's next/previous button labels ✅
The carousel allows authors to specify the labels of the previous & next buttons, but we also provide a default. Previously this value was "next page", but the word page can be confusing. We now provide a default fallback that looks at the carousel's pageSize and returns either "next slide" or "next slide group" if more than one slide is visible.
[No Ticket] Refactor carousel item's interactivity based on inert
When the [inert] attribute was added to the carousel, it was added in a way that wasn't implemented fully in safari/firefox, and didn't account for carousels with multiple visible values well. That's been updated to now use an intersection observer, and it will mark carousel items more less than 75% visible as inert and aria-hidden.
Changelog
Changed

Accessibility improvements to lightbox media viewer component
Accessibility improvements to lightbox carousel story
Accessibility improvements to carousel component

@proeung @andy-blum We had a review QA about the a11y issues with this component. For users who rely on screen readers, the labels for previous and next are not really an issue. Simply having previous/next is enough, and in fact next slide group is more confusing. The main point is the visually hidden element with aria-live. The most informative would be an announcement to the effect of 'Slide x of y with n items'. It looks like this announcement is already part of the PR, so QA is going to review the deploy preview and share any comments with us.
One thing to note is the visually hidden element will need to exist for sm, md, and >=lg breakpoints, as the number of slides and items displayed will be different for all 3.

☝ @kennylam I can hop in tomorrow for the QA time at 9

@kennylam @Gopi916 The most recent commit updates the aria-live announcement logic. It utilizes the intersection observer to count the number of visible items and update the announcement text after a brief 100ms delay to ensure the slide transition is fully complete.
If the screen reader issue experience in firefox is a render lifecycle race condition, this fix should hopefully also address that.

@kennylam Looks like this PR is at a good place, but could probably benefit from a code review from your team. Can you take a look and let us know if these changes can be marked as "Ready to merge"? Thanks!

@Gopi916 I've updated the PR to wrap carousels in
 and added a slot for authors to add carousel title text. Additionally, I think the iOS voiceover text should be fixed. I updated the delay from 100ms to 400ms, and it's now using the design token from @carbon/motion.

Updated PR summary to indicate issues that have been closed by @Gopi916 and to update the solution description for #8914

@Gopi916 Can we get testing for #8913 and #8914 on this PR?

Per conversation last week with @Rasubra8 and @kennylam this has passed accessibility review.
@oliviaflory would you mind taking a look to make sure everything is still aligned with the designs?

@andy-blum thanks for fixing the carousel controls! A few additional comments:
1. Unexpected image/video scaling
The image or video is scaling when the browser has a shorter height, see exaggerated examples below. @jwitkowski79 and I were expecting the image to stay the same width as the default lightbox media viewer.
Carousel

Default

2. No fade on mobile
On my iPhone 12 Pro in Safari and Chrome I don't see the gradient fade that appears in the desktop experience. This is helpful for users to know there is more content below. Right now you only see tiny specs of the additional copy. Let me know if this isn't a part of the Default lightbox and we can open a feature enhancement!

Default with gradient fade

3. Difficult to read text with fade
Lastly, it's difficult to read the last line of text with the gradient fade. We might want to account for extra padding at the bottom so the user can scroll the text enough past the gradient to have the text fully visible.

Just merged in the carbon-web-components addition and had to do a bunch of merge conflicts. There may be some regressions at this point.

Thanks @ariellalgilmore !
I've adjusted things around the gradient. Due to the change we made affecing the scoll area at desktop, where the whole body of the lightbox content scrolls together (image / video and title / description), I also needed to change the gradient at desktop such that it spans the whole width of the scrolling area. This is an implementation limitation, I tried at some length to affect only the description, to no avail. In the end, to me this fits the intent of the gratient which by my interpretation is to signal additional contents beyond the visibile area of the scroll container. Curious to get your thoughts!

I believe it was design intention to not have the media scroll in the larger breakpoints, so wondering what @oliviaflory and @RichKummer think. Maybe some background on why this was changed for the Accessibility fixes would be helpful...

We arrived at scrolling the media together with the description with consideration for video. When a video is used in the lightbox carousel, the user needs to be able to scroll to the media controls once playback is initiated. Otherwise, the the scroll was clipped, the user wouldn't be able to access any of the media controls. Taken together with @oliviaflory 's request to avoid scaling the video to fit the available height (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/9149#issuecomment-1279434723), the logical conclusion was to scroll the media and description together, while pinning the carousel controls to the bottom of the lightbox so they remain accessible regardless of available height.

Friendly bump for @ariellalgilmore / @oliviaflory / @RichKummer . Are we OK with the implementation here as is, or is more iteration necessary? Thanks.

just noticing now the tests for react/web components are failing as well @m4olivei

just noticing now the tests for react/web components are failing as well @m4olivei

Thanks for pointing that out. I'll work on that.

Great thanks @oliviaflory ! I also fixed the test failures we were seeing. So as far as I know (still new to the process), we're ready to merge?

@m4olivei hmm it looks like the Test app deploy previews are failing, is that normal @ariellalgilmore ?

i think @kennylam mentioned he was looking at the test app failures, but shouldn't be an issue with this PR

@m4olivei hmm it looks like the Test app deploy previews are failing, is that normal @ariellalgilmore ?

Yep we're looking into that but it doesn't impact the work in this PR.

seems like just changes requested from @jkaeser need to be approved


Update api shield to allow empty payload

Description
It has recently come to our attention that auth_id_characteristics can be empty when sent to the API. This change will fix the payload that goes to the API to send { "auth_id_characteristics" : [] } when the payload is empty.
Has your change been tested?
I added an additional test case for sending an empty auth_id_characteristics payload.
Types of changes
What sort of change does your code introduce/modify?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Codecov Report

Merging #1147 (95544d3) into master (4ddb00c) will increase coverage by 0.46%.
The diff coverage is 70.43%.

@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   50.11%   50.57%   +0.46%
==========================================
  Files         121      123       +2
  Lines       11722    11972     +250
==========================================
+ Hits         5874     6055     +181
- Misses       4565     4614      +49
- Partials     1283     1303      +20

Impacted Files
Coverage Δ

device_posture_rule.go
61.80% <ø> (ø)

pages_deployment.go
34.24% <ø> (-0.24%)
:arrow_down:

pages_domain.go
71.27% <ø> (ø)

pages_project.go
50.81% <ø> (ø)

rulesets.go
35.09% <ø> (ø)

r2_bucket.go
75.67% <40.00%> (-24.33%)
:arrow_down:

workers.go
68.64% <43.75%> (-0.74%)
:arrow_down:

workers_domain.go
67.18% <67.18%> (ø)

queue.go
71.72% <71.72%> (ø)

api_shield.go
59.45% <72.72%> (+5.61%)
:arrow_up:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

you'll need to update your branch here (presumably, your fork). it's removing a bunch of stuff it shouldn't be.

oh weird, let me check

fixed, sorry about that.


iOS 14 compatibility

(First off, I know iOS 14 is really new and not available to everyone yet. I just noticed this and wanted to report on it)
I got the iOS 14 Beta for developers today and when I tried to start the Corona-warn-App all I get is a black screen. I tried reinstalling the app but exposure logging can’t be enabled and the app freezes when trying to enable notifications. I know this isn’t a main problem because almost no one has iOS 14 at this point, I just wanted to make sure the issue is known.
Thanks!

Thanks for pointing that out. The ENF is unfortunately not available in the iOS 14 Beta:
https://developer.apple.com/documentation/ios-ipados-release-notes/ios-ipados-14-beta-release-notes
We will add an FAQ item for that since there seem to be many very early adopters :)

We also added this question and the corresponding answer to the FAQs on the website: https://www.coronawarn.app/en/faq/#ios_14_beta


[Gamut Mapping App] Always display delta

See conversation at https://github.com/color-js/color.js/pull/438#discussion_r1489822585.
The result of a gamut mapping algorithm may change in-gamut colors, so it is useful to see the deltas in those cases as well.

I like this.

The result of a gamut mapping algorithm may change in-gamut colors

As I mentioned in the other PR, gamut mapping should never change in-gamut colors. When this happens, it's a bug.

The result of a gamut mapping algorithm may change in-gamut colors

As I mentioned in the other PR, gamut mapping should never change in-gamut colors. When this happens, it's a bug.

@LeaVerou Even if that's correct (and this comment makes it sound like not everyone agrees with that), isn't it helpful to surface it?

@LeaVerou Even if that's correct (and this comment makes it sound like not everyone agrees with that), isn't it helpful to surface it?

That was my thinking. It isn't that gamut mapping should alter already in gamuts, but it lets you see whether they are.

we should show deltas iff the color is different than the original (whether or not they are in gamut).

I think that would be a fine alternative. It solves the original concern but also filters out the useless noise.

I like that as an alternative, and @jgerigmeyer has offered to implement. Thanks!


obj-c sample code

is there any objc sample code? its mind boggling that the library is (rightfully so) written in objective-c but all the sample code i can find is in swift. which to me i wont touch with a 1000 foot pole. i hope that im wrong, dont want to have to read fully read the source or translate examples to learn how to use it.

Good question! There is one example in ObjC (posts). We're trying to be future friendly with our docs and help adoption. We don't use any special Swift features, everything translates 1:1 to ObjC. If you have any questions about it let us know!

hmm i might not be looking hard enough, i didnt see any objc at all in any of the sample code on this repo..

@lechium https://github.com/Instagram/IGListKit/blob/master/Examples/Examples-iOS/IGListKitExamples/ViewControllers/ObjcDemoViewController.m

thanks! for some reason i never got a notification about your response!


1.6.1 版本

最新版本，项目跑起来
These relative modules were not found:

./components/DraggableContainer in ./node_modules/vue3-draggable-resizable/src/index.js
./components/Vue3DraggableResizable in ./node_modules/vue3-draggable-resizable/src/index.js
components里面的js文件跟上个版本比较都没有了

There's a closed issue where someone resolved this by adding TypeScript
https://github.com/a7650/vue3-draggable-resizable/issues/33
We're using 1.5.4 without TypeScript and it's working.


[Fix] Remove data service dependency for webhook event

Right now, the command service will depend on data service which causes a problem, if the data init process is not done or the data is not up-to-date, then the command service will fail with an exception.
All webhook event should not depend on data service and only use the data inside the event payload to trigger the handlers.

The problem is not because the update procedure breaks, we need to add updateRepoDataSched into globalConfig of an instance.
And the key reason is we do not use the default value of HostingConfigBase and only uses the config in gloablConfig.json which means we need to explicitly point out all the configuration values in the config file.
We need to merge the global config with default config to avoid this.

Actually this is what designed for, the default config file is only an interface and used to generate config description.

Above comments should be for #389 , not this issue.

This is issue is closed by #468 , in the PR, if the data init process is not done yet, we will use author as issue author and -1 as issue number to check the command rather than throw an error.


irken plugin, indent, and syntax files for vim based upon the scheme.vim...

~/.vim/*/irken.vim files (yes. yes, I know.)

Thanks!  vi users are people, too.


Caching

There are only two hard things in Computer Science: cache invalidation and naming things.
-- Phil Karlton

With #3 out of the way, I think another big design question is going to be caching: what is our caching model going to look like? When do we invalidate caches automatically? How do caches relate to scopes?
Let's use the dependency chain C->B->A (C depends on B...)
If B declares itself as "do not use cache" (currently scope=False), does that mean that every time C is requested A, B and C should be re-computed? Or only A and B should be re-computed? Or only B and C? I think that if C is requested, we should just use the cached value for C. If B is requested, we should re-computed B using the cached value for A.
Perhaps we can make this a bit simpler if we say "you cannot depend on any dependencies bound to inner scopes (relative to yours)". So lifespan dependencies can only depend on other lifespan dependencies. Request dependencies can depend on request dependencies or lifespan dependencies. And so on. But I'm not sure if this prohibits any important use cases. And because scopes are dynamic, we can't compile time check this.
What if between executions, a new value is bound? Let's say all dependencies are cached, and we bind / override A. I think we should not invalidate the caches for anything except maybe A (should we even do that?). So if B or C are requested, cached values are returned. If A is requested, it is re-computed and then re-cached for subsequent requests.
So when should caches be invalidated? Clearly when we exit the caching scope they should be. So if A, B and C are cached in the "request" scope, when we exit the request scope the cached values are dropped. I think this is the only time we should automatically invalidate caches.

The invariants above are now being enforced (c061d2b8523f493f20c105b6fc3e3ba747a17cfb):

You can't depend on a narrower scope than yourself
Shared / cached values are invalidated only when exiting a scope

Perhaps we can make this a bit simpler if we say "you cannot depend on any dependencies bound to inner scopes (relative to yours)". So lifespan dependencies can only depend on other lifespan dependencies. Request dependencies can depend on request dependencies or lifespan dependencies. And so on.

Seems like this is how Nest works as well 😃: https://docs.nestjs.com/fundamentals/injection-scopes#scope-hierarchy


test: enable state circuit test for every opcode

Whenever we add an opcode, we add evm circuit test for it using run_test_circuit_incomplete_fixed_table(witness::build_block_from_trace_code_at_start(&bytecode)).
On the other hand, there are only a few hand-written state circuit tests in state.rs. We need to enable state tests for each opcode.

lots of tests fail.   state circuit code is old and a bit under tested and under maintained ..

done. will submit PR tomorrow

closed via https://github.com/appliedzkp/zkevm-circuits/pull/282?


Backend design

In order to solve #4 we need to design a backend:

[ ] Storage information
[ ] Information need to be processed (for example get the tag)
[ ] Login need to be created

This is not a minimal product at this time


Laravel 5.4 conflicts

Apparently, dingo version 1.0.0-beta7 has conflicts with Laravel 5.4.
Most packages like illuminate/routing in dingo requires 5.3.
When is that going to be fixed?

+1

See https://github.com/dingo/api/pull/1314
seems to cover this.

@jasonlewis when will the new branch be released?

it work for me.
#1317

Also seems fine #1317


1.3.2  trace id conflict problem

most of the times,the id is ok,but sometimes  we can find conflict ids.
@Bean
@ConditionalOnMissingBean
public Random randomForSpanIds() {
	return new Random();
}

i doubt that Random can be unique in distributed areas.

it is random,i do not know the details.but i am sure the random can not guarantee unique id in distributed areas.Maybe our apps' tps is  so large.maybe i shoud use zipkin v2 span,which traceId is string ,and i can use UUID to guarantee unique id

You can consider using the spring.sleuth.traceId128=true property
FYI Twitter still uses 64-bit trace ID by default, but likely they will
move to 128-bit trace IDs. I don't think you will have a problem in
practice and if you do why would be an interesting question.

I'll close this issue until you get a sample that can reproduce an issue. Until then i don't see an issue here

can Random really  guarantee unique id in distributed envs? @adriancole  traceId128 can not be spanid accoring the DefaultTracer

a trace ID is unique per operation.
So if your concern is about span ID, you believe there's a reasonable
chance of collision within the same operation.
If your random generator is working, I don't think most use cases this will
be a problem. This approach is used at large scale sites including google.
Issues lists aren't for hypothetical problems, rather for changes need to
the code. I hope some of the context helps, but this isn't a good place to
explore nuance of random generators.

maybe because of our methods tracing,the span counts are too large,so i think i have to use other techs like UUID to guarantee distributed unique ID

Sometimes when there is conflict it isnt because of random, rather a
propagation bug somewhere. For example a span id reused by accident due to
thread local problem. Could this be possible?

If you have custom code please ensure that you're not leaving any spans unclosed. If you can't provide an example we can replicate the problem with then i don't think we'll be able to help you

the example is above, i close the span in finally block,i can not see any error in my  code above.

No, above you have some snippet. I have no idea what it really does. AOP - AOP around what? What does tracer() do? What is CommonUtil?  This snippet doesn't help solve the problem at all. Please upload a sample of the whole project.

i think i have found the problem.
SpanContextHolder.java
static void close(SpanFunction spanFunction) {
SpanContext current = CURRENT_SPAN.get();
CURRENT_SPAN.remove();
while (current != null) {
current = current.parent;
spanFunction.apply(current != null ? current.span : null);
if (current != null) {
if (!current.autoClose) {
CURRENT_SPAN.set(current);
current = null;
}
}
}
}

i use the close function,may be i shoud use detach

I have no idea what you're doing. Also when you paste the code, please format it cause it's difficult to read.

sorry ,i have formatted them,by the way i mean maybe it is a sleuth's bug ,when using tracer's close function ,if current span have parent that is not autoClose,then CURRENT_SPAN become the parent.

our code is ok,we have found some span ids are same,so we will  use es id(we use es to store spans) to replace the random.the parent id is because our validating function had a bug and it droped some spans


CMOS-168: Collect diagnostics information

Always log to files, make stdout optional
Add script to collect diagnostics information
Add HTML page and API endpoint for running it interactively

Currently the latter just dumps the script's output without any formatting - this is a possible area for improvement.
Also, no sanitization or redaction is performed on the output.

Can you include an actual snapshot example as well?

GH won't let me upload tarballs, but here's the content of the snapshot:


xADUser: Add TrustedForDelegation parameter to support Kerberos delegation

Pull Request (PR) description
Added new parameter to allow Kerberos delegation to be set on an Active Directory user.
This Pull Request (PR) fixes the following issues
None
Task list

[x] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: pshamus sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #241 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #241    +/-   ##
====================================
+ Coverage    84%    84%   +<1%
====================================
  Files        16     16
  Lines      1437   1438     +1
  Branches     10     10
====================================
+ Hits       1210   1211     +1
  Misses      217    217
  Partials     10     10

Any update as to the status of this PR? Is there anything missing or are there any comments/questions?

I just haven't gotten the time to reviewing the PR's in this repo yet. I will get to this PR as soon as I can. In the mean while, I just merged a PR that resolved failing tests. Please rebase this PR when you have chance.

No worries, thanks for jumping on this!

Okay, changes applied. Please let me know if you need anything else. This is my first public PR so it's a learning experience.

@pshamus so happy you are here a contributing! We all started out with out very first PR, we are all still learning still. 😃 The rebase looks good, great work!. Although I just merged another PR. So you need to rebase again. :/ But maybe we can see it as a good learning experience though, learning how to rebase 😄
Just do what you did before again and I will make sure to merge this one in next. 🙂

@johlju Okay, done. And no worries on me having to do this again. It's helpful from a learning perspective. :)

@pshamus merged now! Thanks for this! 😃 Looking forward to your next PR! 🙂


frontend and model inheritance

Is model inheritance support by frontend ?
The context processor is unable to find the current_module in the two cases where the models inherit from another in another app, might be a misconfiguration from me and just a  coincidence though. The result is that the views crashes because current_module doesn't find the base template to extend:
django.template.exceptions.TemplateSyntaxError: Invalid template name in 'extends' tag: ''. Got this from the 'current_module.base_template' variable.
[18/Dec/2017 12:16:47] "GET /pmt/pmt/ HTTP/1.1" 500 122404
> /home/jpic/src/django-material/material/frontend/context_processors.py(13)modules()
     12     import ipdb; ipdb.set_trace()
---> 13     if request.resolver_match:
     14         module = getattr(request.resolver_match.url_name, 'module', None)

ipdb> request.resolver_match
ResolverMatch(func=material.frontend.views.list.ListModelView, args=(), kwargs={}, url_name=pmt_list, app_names=[], namespaces=[])
ipdb> request.resolver_match.url_name
'pmt_list'
ipdb> request.resolver_match.url_name.module
*** AttributeError: 'str' object has no attribute 'module'
ipdb>

Internal Server Error: /pmt/pmt/
Traceback (most recent call last):
  File "/home/jpic/.local/lib/python3.6/site-packages/django/core/handlers/exception.py", line 35, in inner
    response = get_response(request)
  File "/home/jpic/.local/lib/python3.6/site-packages/django/core/handlers/base.py", line 156, in _get_response
    response = response.render()
  File "/home/jpic/.local/lib/python3.6/site-packages/django/core/handlers/base.py", line 156, in _get_response
    response = response.render()
  File "/home/jpic/.local/lib/python3.6/site-packages/django/template/response.py", line 106, in render
    self.content = self.rendered_content
  File "/home/jpic/.local/lib/python3.6/site-packages/django/template/response.py", line 83, in rendered_content
    content = template.render(context, self._request)
  File "/home/jpic/.local/lib/python3.6/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/home/jpic/.local/lib/python3.6/site-packages/django/template/base.py", line 173, in render
    with context.bind_template(self):
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/home/jpic/.local/lib/python3.6/site-packages/debug_toolbar/panels/templates/panel.py", line 49, in _request_context_bind_template
    context = processor(self.request)
  File "/home/jpic/src/django-material/material/frontend/context_processors.py", line 13, in modules
    if request.resolver_match:
  File "/home/jpic/src/django-material/material/frontend/context_processors.py", line 13, in modules
    if request.resolver_match:
  File "/usr/lib/python3.6/bdb.py", line 48, in trace_dispatch
    return self.dispatch_line(frame)
  File "/usr/lib/python3.6/bdb.py", line 67, in dispatch_line
    if self.quitting: raise BdbQuit
bdb.BdbQuit
[18/Dec/2017 12:17:25] "GET /pmt/pmt/ HTTP/1.1" 500 120603
^C
18/12 2017 13:17:26 jpic@jpic ~/work/betagouv/mrs  (webpack)
$ cat src/pmt/urls.py
from django.views import generic
from django.urls import include, path, reverse_lazy

from .views import PMTViewSet

urlpatterns = [
    path(
        '',
        generic.RedirectView.as_view(url=reverse_lazy('pmt:pmt_list')),
        name='index'
    ),
    path(
        'pmt/',
        include(PMTViewSet().urls),
    ),
]

18/12 2017 13:17:33 jpic@jpic ~/work/betagouv/mrs  (webpack)
$ cat src/pmt/models.py
from django.db import models
from django.urls import reverse

from mrsattachment.models import MRSAttachment, MRSAttachmentField
from mrsrequest.models import MRSRequest

class PMTManager(models.Manager):
    def allowed_objects(self, request):
        '''Return PMT QuerySet allowed for this request.'''
        mrsrequests = MRSRequest.objects.allowed_objects(request)
        return self.model.objects.filter(mrsrequest__in=mrsrequests)

    def record_upload(self, mrsrequest, upload):
        '''Create a PMT object from the upload.'''
        return PMT.objects.update_or_create(
            mrsrequest=mrsrequest,
            defaults=dict(
                filename=str(upload),
                binary=MRSAttachment.get_upload_body(upload),
            )
        )[0]

class PMT(MRSAttachment):
    mrsrequest = models.ForeignKey(
        'mrsrequest.MRSRequest',
        on_delete=models.CASCADE,
    )
    binary = MRSAttachmentField(
        'pmt_upload',
        'pmt_download',
        'pmt_destroy',
        verbose_name='Prescription Médicale de Transport'
    )

    objects = PMTManager()

    def get_delete_url(self):
        return reverse('pmt_delete', args=[self.pk])

    class Meta:
        ordering = ['mrsrequest', 'id']

18/12 2017 13:17:35 jpic@jpic ~/work/betagouv/mrs  (webpack)
$ cat src/pmt/views.py
from material.frontend.views import ModelViewSet

from .models import PMT

class PMTViewSet(ModelViewSet):
    model = PMT

You can find the full code here: https://github.com/sgmap/mrs/tree/tbinetruy/src/pmt

This was because I was still including urls manually


Force tmux to assume the terminal supports 256 colours.

Force tmux to assume the terminal supports 256 colours.  vim keeps messing up the color.


Use rust-cache for github actions

Finally close #35 properly :)

Discard cargo clean directive
Add a check for try-runtime feature build
Use rust-cache to speed up workflow
Remove NIGHTLY rust as it's no longer needed

LGTM 👍


[docs][typo] Fix some typos in "alter-table" content.

Proposed changes
Fix some typos in "alter-table" content.
Problem Summary:
Fix some typos in "alter-table" content.
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No Need)
Has document been added or modified: (Yes)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (Yes)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

@hf200012 , Sorry to bother you, can you help me review this pr? Thank you.


Rounding Decimals in Kapacitor

Hi,
In my .message property off an alert() node, I use a lot of tags and fields to write a detailed message to Slack. The only part I cannot seem to find online is how to round the decimals to, say, 2 decimal places. It would increase the readability by a large amount, and is quite needed.
If this is not able to be done in Kapacitor, is there a way from the InfluxDB side (because I am using batches and could possibly write the rounding logic in InfluxDB's query language)? I could not find anything on that route either.
Help is greatly appreciated, thank you,
Michael

Have a look at https://github.com/influxdata/kapacitor/issues/479

Thank you very much.


cloudutils: fix adding rocky9 host failure due to missing /etc/sysconfig/libvirtd

Description
This PR fixes the issue while adding rocky9 host failure due to missing /etc/sysconfig/libvirtd

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6582

@blueorangutan test rocky9 kvm-rocky9

@DaanHoogland [SF] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

@blueorangutan test alma9 kvm-alma9

@weizhouapache a [SF] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

@blueorangutan test rocky8 kvm-rocky8

[SF] Trillian test result (tid-7184)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 44290 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7779-t7184-kvm-alma9.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-7190)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44737 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7779-t7190-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

[SF] Trillian test result (tid-7189)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 47144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7779-t7189-kvm-alma9.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Code LGTM. Test results also show no errors on Alma9
@weizhouapache currently we don't have support for Rocky9 on Trillian. Last time it was failing for me with some ansible version, syntax issue. Oracle Linux 9 should work though

@shwstppr yeah, there could be some other issues while setting up a rocky9 environment.
Rohit has shared the steps in his testing: https://gist.github.com/rohityadavcloud/fc401a0fe8e8ea16b4b3a4e3d149ce0c
let's test it later


fix(karma): fix karma webpack manifest initializer

Resolves https://github.com/davezuko/react-redux-starter-kit/issues/572

Current coverage is 70.88%

Merging #709 into master will not affect coverage as of e5ca664

@@            master    #709   diff @@
======================================
  Files           12      12
  Stmts           79      79
  Branches         0       0
  Methods          0       0
======================================
  Hit             56      56
  Partial          0       0
  Missed          23      23

Review entire Coverage Diff as of e5ca664

Powered by Codecov. Updated on successful CI builds.


trakt

sorry to write this here, but is there any way to add trakt to this skill, so trakt works the same as if it was plaing a movie/tv show from the library ?
just in case some one library is messed up ?

I'm not sure I understand. Have Trakt play something instead of the library?

Please have a look here.
http://koditips.com/why-trakt-is-better-than-kodi-library-integration/

No real comment on adding the feature, but if Kodi did move from library to Trakt as is suggested in that 'article,' I'd be moving away from Kodi... I see no evidence that that is the case though.

If you have the Trakt addon already scrobbling your library, when controlling Kodi with this Skill you are still using Kodi as normal and I confirm Trakt works fine.
I think you are talking about controlling a video addon that uses Trakt as a way to browse content and then attempt to stream it. Trakt in itself is just a way of keeping track of what you watch, it is not a way of delivering content.
Your question does highlight a perfect example of why Trakt is not better than Kodi library integration :)
Some addons integrate the strm files into the Kodi library with some level of success, but many of the dedicated streaming addons rely on you wading through menu after menu in order to find stuff.

I think you are talking about controlling a video addon that uses Trakt as a way to browse content and then attempt to stream it.

I think this is it, yeah.  I get weird requests like this for skin.metropolis too and I'm always confused until I go searching outside the kodi forums/wiki.. e.g., stuff not condoned by Team Kodi..

I think this is it, yeah. I get weird requests like this for skin.metropolis too and I'm always confused until I go searching outside the kodi forums/wiki.. e.g., stuff not condoned by Team Kodi..
Yeah sorry that's what I was trying to say, I understand if you don't wish to add this.
Add-on like exodus and salt use a trakt account to search for the links. A few skins have trakt integrated so u can enter the TV show or movie trakt folder in 1 click from the kodi home screen or you can add trakt folders ( tv shows) to a sub menu like in aeon-mq
But what would be great is to use trakt my calendar as found in Salt so you can find out all TV shows that have recently been on overnight.

I'm going to add the ability to open (and hopefully manipulate, to some extent) addons soon.
However, and I don't speak for @m0ngr31, but I personally won't add anything to support piracy.

that great thank you this will help you.
http://docs.trakt.apiary.io/#

The interaction with Kodi will be limited to what Kodi exposes via the JSON RPC interface.  The skill wouldn't be directly talking to Trakt, nor would it really know what Trakt even is.
It would be possible to add more support for specific addons, but going down that road is a maintenance nightmare, since interfaces for addons are a lot more flexible (read: change a lot more often) and not in any way standardized.  I don't know if @m0ngr31 has any intention to go that route, but I'm inclined not to, simply because I don't want to maintain it.
I get requests like this for skin.metropolis a lot too and have experience trying to keep up with it.  I've decided in the end (with regard to my skin) to only support certain addons that have a) solid developers that care to include feedback from the skinners they're supporting, b) reasonably well thought out APIs, c) have a huge user base which helps them achieve a greater lifespan.
The above could very well include the Trakt addon; however, it's not yet certain that we want to go down that road at all for the skill.  That'd be a whole other discussion.

If the addon integrates with the library then it would work fine using this skill.
The official Trakt addon (from the Kodi repository) just sits in the background marking episodes as watched and keeping them in sync with the site (https://blog.trakt.tv/kodi-scrobbler-sync-plugin-1f148b5070a5#.bb3b7a53v)
For what @crowland88 is talking about would require integrating each specific streaming addon, the addon would talk to Trakt itself. But as you say, those types of addons come and go all the time, the maintenance would be a nightmare.

Yeah, sorry, I just kind of went with the assumption that he was referring to integration with specific addons, since, as you said, it would otherwise 'just work' if it were just the Kodi library.
More specifically, he was talking about stuff like Exodus initially.. which I won't even bother looking into.
For the TV Guide-like functionality, I can guess the Trakt addon might have a function to present that.  There are a few addons that do this.  Provided the default open action is this, when I add support for opening addons, you'd automagically get this feature.
I could also extend it to open favorite links, which would give you the ability to navigate anywhere within an addon by voice.  It'd be a bit cumbersome (to set up, not to use), but honestly it's not much different than the way Kodi Skins handle custom furniture anyway, so it'd at least be familiar.

its ok, It was a bad idea, but adding stuff to the favourites would be nice for ustvnow and ontap tv guide addons.
it looks like something is on the way https://www.facebook.com/trakt.tv/videos/1195106010527702/ its a shame it not intergraded with your addon.

it looks like something is on the way https://www.facebook.com/trakt.tv/videos/1195106010527702/ its a shame it not intergraded with your addon.

It's still not clear exactly what you think should be integrated with this skill...?

Yeah, I'm pretty confused by the intended functionality requested here.

So if I understand this thread, this will only really work for hardcopy files that exist on your computer or somewhere stored?  This will not work for add ons like exodus or even the amazon prime or Netflix add on.    If someone can confirm that would be great.  Thx
Is there a way outside of kodi to Control Netflix directly from the web or Windows app?
Is there away to control kodi from Alexa

http://forum.kodi.tv/showthread.php?tid=254502&pid=2443174#pid2443174

Closing this as I don't think there's anything to actually do here.


Adding Special Sections Comment and Literal.

Special section tags do not contain content referring to a context and therefore do no require name resolution:

If the name is "!", the section is a comment block.
If the name is "`", the section is a literal block.

# Comment Sections
data:     { bro: "dawg" }
template: "{{#!}}Don't render me, {{bro}}.{{/!}}"
expected: ""

# Literal Sections
data:     { foo: "bar" }
template: 'var tpl = "{{#`}}<span>{{foo}}</span>{{/`}}";'
expected: 'var tpl = "<span>{{foo}}</span>";'

+1 for comments sections.
i do not mind literal sections, but i see the use-case is valid and can be simplified.
so: +1 for literal sections.


Doesn't find profile automatically under Win 8.1x64

Where I am supposed to put the .exe?
Even next to the profiles.ini it can't find it.

When trying to copy and paste the path it is stripped at 11 characters, but this might be a windows issue.
C:\Users\ad instead of
C:\Users\admin\AppData\Roaming\Mozilla\Firefox\profiles.ini
shadowfox_windows_amd64.exe V1.40

Same issue, well 2 issues:

[ ] Character stripping on paste
[ ] Profile not found when full path given

I have tried running as admin in case it was a permission issue.
Windows 10 64 bit
FF 59.0.2

the pasting issue is a limitation with the library I'm using for the UI, so sadly it can't be fixed until the library fixes it
For the other issue i think that I'm just gonna rewrite the profile finding code for the next version.
Currently the directory the program is in doesn't matter, but I'm gonna make it so that if the program is on the same folder as profiles.ini it will use that folder

Still seeing panic: key-value delimiter not found: error with 1.4.1. Doesn't even prompt for path anymore, is there a settings file I could clear?

Alright, now in v1.4.1 the program will go through these steps to find profiles.ini:

Check if profiles.ini is in the current directory
Try to auto-detect where profiles.ini is based on the default locations
If all else fails it will show you this following screen

This fixes the pasting issue because, well, there isn't an input field to paste to
@SavageCore your error seems really weird, can you show me your profiles.ini file? I have a theory that it might be a problem with the parser for profiles.ini

profiles.txt
Changed to txt for GitHub.

Hmm, I'm pretty sure the file is okay so the problem might be somewhere else in the code. Can you paste the entire error that shows up in v1.4.1? (I want to be 100% sure the problem isn't the parser before trying something else)

C:\Users\SavageCore\AppData\Roaming\Mozilla\Firefox>shadowfox_windows_amd64.exe
 anic: key-value delimiter not found:

goroutine 1 [running]:
main.getProfilePaths(0x7210c0, 0xc042146fc0, 0xc042004158, 0x8, 0x8, 0x6fde60)
        /home/travis/gopath/src/github.com/SrKomodo/shadowfox-updater/ui.go:226 +0x7f7
main.createUI()
        /home/travis/gopath/src/github.com/SrKomodo/shadowfox-updater/ui.go:45 +0x5b
main.main()
        /home/travis/gopath/src/github.com/SrKomodo/shadowfox-updater/main.go:4 +0x27

When double clicking I just get a quick flash of cmd window

Just to tell you, 1.41 autodetect works well on my end.

@stonecrusher Nice! So now all that is left to close this issue is to fix the parser problem

@SavageCore After taking a really close look to your file, I finally figured out the issue. Your file is encoded in UTF-16 LE, meanwhile the ini parser i'm using only supports UTF-8. I will try to either find a better parser or write one myself

That's great! Converted to UTF-8 in Notepad++ and I am all installed!
Auto-detect fine too.


The QA service tab is not closed after renaming it

Storage Explorer Version: 1.27.0-dev
Build Number: 20221101.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.0 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Pin it to Quick Access.
Open the QA blob container.
Right click the QA blob container -> Click 'Rename ...'.
Type a valid name -> Click "Rename'.
Check whether the QA blob container tab is closed.

Expected Experience
The QA blob container tab is closed.
Actual Experience
The QA blob container tab is not closed.

Verified this issue on the build main/20221113.2. Reproduce.
So, we are going to re-open it, will verify on a newer build and close it once it fixed.

By switching to use resourceUID, the node-tab association will be preserved after renaming so we don't need to close the tab. The tooltip of the tab (nodePath) will be incorrect but that's a minor issue at this point so we will address it later.

We will leave the tabs open after renaming quick access items.


Confused about admin and superAdmin

Description
It's confused for users about admin adn superAdmin.
[ ] TBD only one to sue: admin/superAdmin
[ ] the code
[ ] the doc
Versions
develop
Additional Information
https://docs.citahub.com/zh-CN/cita/configuration/chain-config#super-admin-指定超级管理员地址

I'd like to use admin

Maybe it's not a good idea to use only one. Because admin is used for system mangement, superAdmin is used for permission mangement.

Rename superAdmin for a word that below the admin

Follow the exist superAdmin, and fix other admin part.


Study a case where despite having Write Defaults On in a FX sublayer, it needed a mask for Gesture transforms to function

Study a case where despite having Write Defaults On in a FX sublayer, it needed a mask for Gesture transforms to function

It appears that the layer that caused the issue it was a toggle on the topmost layer. The topmost layer is ignored by the Add missing masks process, because of past unverified assumptions, topmost layer might need to be the sum of all masks, and might be modified by VRChat.
However, it appears that adding a mask might be necessary if the topmost layer mandates it


Change Microsoft.Framework.*  to Microsoft.Extensions.*

Change Microsoft.Framework.*  to Microsoft.Extensions.* accordingly to the following annoubcement:
https://github.com/aspnet/Announcements/issues/77

Hi @ORuban, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@ORuban, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Can you add app.UseIISPlatformHandler(); into sample?

@Kagamine I would like to suggest creating another PR for that...  Seems like another scope of changes + I am not familiar with UseIISPlatformHandler

@glennc


database extension data added, not integrated yet

thought it'd be nice if u had a rocket blazing fast DB 🚀

Thanks


Issue with CancellationToken lifetime in Observable.Using (async version)

Bug
In the async version of Observable.Using, in observable factory delegate cancellationToken gets canceled not at the moment of destroying subscription. The synchronous version looks ok as there are no cancellation tokens.
Reproduced in System.Reactive.Linq 6.0.0, x64, Win11, dotnet  version 8.0.100
using System.Reactive;
using System.Reactive.Disposables;
using System.Reactive.Linq;
using static System.Reactive.Linq.Observable;

public class Program
{
    public static async Task Main()
    {
        var enumeration = Observable.Using<int, IDisposable>(
                async (cancellation) => {
                    cancellation.Register(() => Console.WriteLine("Resource factory cancellation called"));
                    await Task.Yield();
                    Console.WriteLine("Created resource");
                    return Disposable.Create(() => Console.WriteLine("Disposed resource"));
                },

                async (resource, cancellation) => {
                    cancellation.Register(() => Console.WriteLine("Resource observable cancellation called")); // why is this called not when subscription disposing?

                    Console.WriteLine("Init resource observable");
                    await Task.Yield();
                    // return -1 immediately and then tick with 1 second interval
                    var underlyingObservable = Observable.Return(-1)
                                                        .Concat(
                                                            Observable
                                                            .Interval(TimeSpan.FromSeconds(1))
                                                            .Select((t,i) => i).Take(10)
                                                        );
                    return new AnonymousObservable<int>((observer) => {
                        Console.WriteLine("Subscribed");
                        return new CompositeDisposable(
                            underlyingObservable.Subscribe(observer),
                            Disposable.Create(() => Console.WriteLine("Unsubscribed"))
                        );
                    });
                }
            );

        enumeration = enumeration.Publish().RefCount();

        var subscription = enumeration.Subscribe(
            num => Console.WriteLine("Next:{0}", num),
            ex => Console.WriteLine("Error:{0}", ex),
            () => Console.WriteLine("Completed")
        );

        await Task.Delay(5000);

        subscription.Dispose();
    }
}

Actual output:
Created resource
Init resource observable
Resource factory cancellation called
Subscribed
Next:-1
Resource observable cancellation called  << here is the problem
Next:0
Next:1
Next:2
Next:3
Unsubscribed
Disposed resource

Expected output:
Created resource
Init resource observable
Resource factory cancellation called
Subscribed
Next:-1
Next:0
Next:1
Next:2
Next:3
Resource observable cancellation called
Unsubscribed
Disposed resource

in observable factory delegate cancellationToken gets canceled not at the moment of destroying subscription

The cancellation token's purpose is not to tell you that the subscription has ended (although under certain circumstances, unsubscription will trigger the thing that it's actually telling you about). Its purpose is to tell the callback that the result the callback was meant to produce is no longer required. This is related to the subscription only insofar as if someone unsubscribes before your callback returns, cancellation may occur. But there are no guarantees at all about what that token does after your callback returns.
Arguably we have a documentation bug here, because where the docs say that these tokens allow:

cancellation at any stage of the resource acquisition or usage

it is at best unclear, and possibly misleading, to say "usage" here. You could reasonably interpret the resource as being "used" for the entire lifetime of the subscription. I think this should really have said:

cancellation at any stage of resource acquisition, or of the creating a new IObservable<TResult>> from that resource

So we use the resource to create an observable. (That's the cancellable part of "using" the resource.) And then we go on to use the resulting IObservable<TResult>>. (And for that stage, it's the call to Dispose that tells us when it's all over, not the cancellation token.)
The design intent is that the cancellation token's state is only meaningful for as long as the callback is running. Once the callback has returned, there's no longer any work left to cancel.
Why am I saying that's the design intent?

there's already a separate mechanism for dealing with this longer type of "usage" (the call to Dispose)
looking at the code, it's clear that these cancellation tokens are only intended to have any meaning for as long as the callbacks are in progress
the unit tests are consistent with this interpretation

So in your example, I wouldn't have expected the cancellation tokens to be signalled at all. However, as the documentation says, this method supports:

best-effort cancellation

So that means two things:

no guarantees about when cancellation will occur
no guarantees about whether or not the token will be cancelled

Since cancellation is described as 'best effort' here, the guarantees are very weak. The only thing that is guaranteed is that each cancellation token won't be signalled while the callback is running if the result of the callback is still required.
There's definitely something a bit peculiar about the behaviour this example produces. I would not have expected the cancellation token to get signalled when nothing needed to be cancelled. (And both of your callbacks run to completion, and the subscription continue to run for some time after that. It's definitely too late to cancel a callback if that callback already returned!) But since the behaviour of the token after it has served its useful purpose is, strictly speaking, undefined, technically it is not a bug the token may be signalled long after it's useful, and that's what you're actually seeing here.
I just want to clarify why I'm saying it's occurring after it's useful (i.e., later than we might reasonably expect), when you're reporting that it's coming earlier than you think it should.
The behaviour you describe as expected behaviour:
Created resource
Init resource observable
Resource factory cancellation called
Subscribed
Next:-1
Next:0
Next:1
Next:2
Next:3
Resource observable cancellation called
Unsubscribed
Disposed resource

is also not what I would have expected here.
Here's the output I was expecting:
Created resource
Init resource observable
Subscribed
Next:-1
Next:0
Next:1
Next:2
Next:3
Unsubscribed
Disposed resource

I.e., I wasn't expecting either of the cancellation tokens to get cancelled, because both of the callbacks ran to completion (meaning that there was no work left to cancel).
If you interpret the documentation ("any stage of the resource acquisition or usage") to extend to the full lifetime of the subscription, your interpretation makes sense. But this has never been what the implementation was actually trying to achieve. So that's why I'm classifying this as a documentation bug.
If you want to know when the resource is no longer in use, the call to Dispose tells you that.
I think it would be cleaner if they never got cancelled in this situation. But there's every chance that code out there somewhere is relying on the fact that they do get cancelled after the work they were meant to govern completes, so I think we're kind of stuck with that behaviour.
So in conclusion:

if I were to modify the behaviour here, it would be to prevent these cancellation tokens from getting cancelled at all in this particular scenario (i.e., neither the behaviour you observed, nor the behaviour you said you expected)
the current behaviour is odd but not outright wrong, and it's possible that some code relies on the current behaviour, so changing it could be counterproductive
the documentation for this method needs to be more clear about what these cancellation tokens are actually for


Readability Suggestions

This is a good page, but it is very long.  There are two changes which I feel would make this page a bit easier to read, and thus for a developer to find key information quickly.

Include a section on configuring monitoring & Application Insights via dependency injection. The page at https://docs.microsoft.com/en-us/azure/azure-functions/functions-dotnet-dependency-injection#logging-services includes good info. It would be helpful if much of that information was inlcuded in a dedicated page to monitoring functions.
The page starts with a short discussion on Application Insights, but does not include details on how to enable Application Insights.  Those instructions (to enable Application Insights) are located near the bottom of the page. I feel the page would flow better if the instructions were closer to the top of the page.
Since this is a long page, I feel it would be helpful if the page was broken into smaller sections, and thus included under the "Monitor" section on the left-side navigation.  There could be sections for enabling Application Insights, configuring dependency injection, writing logs, telemetry, etc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 13672b67-22ea-3dda-8b6b-3332c24e6030
Version Independent ID: fdc60aeb-9971-1d9f-a6ba-b3ad818cf0d5
Content: Monitor Azure Functions
Content Source: articles/azure-functions/functions-monitoring.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @mcollier I have assigned this to content author for further review and update as appropriate.

Thanks @mcollier. This has been a long-term goal, which has now been prioritized by Daria. I'm actually working on improvements now, and I'll loop you in for reviews.


Spaced crons

This increases the spacing of crontasks until we can figure out https://github.com/datamade/devops/issues/41. (I also removed crontasks from blackbox since they aren't particularly sensitive).

looks good @fgregg


deepstream behave unexpectedly

I am using deepstream server(docker images) and using rethinkdb(docker image) as storage. i restart the rethinkdb docker and try to set the record  from deepstream client(record.set()). it's showing error like "storage:ReqlDriverError: Connection is closed."  on both side(deepstream client and server).
but when i restart the deepstream docker also,then it working fine.
why deepstream is behave like this?
i configured deepstream wrong ? or it's bug in deepstream.

Added exitOnPluginError to V4 settings. This will force deepstream to close whenever an error in a plugin occurs.
It's not exactly graceful but it solves alot of problems 👍


Ensure commands are registered only once

Related to https://github.com/microsoft/vscode-python/issues/7170
When we have experiments, the related commands may be registered more than once, which can be confusing (e.g. when looking for it in the keyboard shortcuts view).  Maybe the extension could check to ensure the commands are being registered just once.

Closing as stale.


CAS-550: Ranked Choice Voting

This PR has been merged into: https://github.com/DapperCollectives/CAST/pull/571


[backport] Fix NumPy version in Dockerfile

Backport of #2430

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 6bcaf5fa3c2c68f0d5d9a60914b9372d49b0215a, target branch v6) failed with status FAILURE.

LGTM! Test failures are not related to this PR.

I've released docker images: v6.3.0, v6.3.0-python2


BUG(NodeNotReady): cluster2-create failed in Rancher setup

Running with gitlab-runner 12.9.0 (4c96e5ad)
  on oep-e2e-rancher-runner ZxzsvA-i
Preparing the "docker" executor
Using Docker executor with image mayadataio/tools:gitlab-job-v6 ...
Pulling docker image mayadataio/tools:gitlab-job-v6 ...
Using docker image sha256:2d0add723c266bb3525f5c16076d034d0ceea16aa047a1ad18a53f4cc6b32c7c for mayadataio/tools:gitlab-job-v6 ...
Preparing environment
Running on runner-ZxzsvA-i-project-36-concurrent-1 via ip-172-31-31-43...
Getting source from Git repository
Fetching changes with git depth set to 50...
Reinitialized existing Git repository in /builds/oep/oep-e2e-rancher/.git/
Checking out 2001fa11 as oep-release...

Skipping Git submodules setup
Restoring cache
Downloading artifacts
Running before_script and script
$ chmod 755 ./stages/cluster-setup/cluster2-setup
$ ./stages/cluster-setup/cluster2-setup
Tue Jun 23 05:53:41 IST 2020

************************ Checking if cluster is Engaged or not ************************

Warning: Permanently added '[rack2ml.openebs100.io]:1658,[<IP_ADDRESS>]:1658' (ECDSA) to the list of known hosts.

Cluster Status: Free

************************ Checking the Cluster's Health ********************************

[ Checking for the number of nodes in ready state ] -----------------

Number of nodes in ready state: 5
Cluster State: Unhealthy

Running after_script
Uploading artifacts for failed job
ERROR: Job failed: exit code 1

oep@rack2:~$ kubectl get no
NAME                 STATUS     ROLES               AGE   VERSION
oep-rancher-master   Ready      controlplane,etcd   66d   v1.15.11
oep-rancher-node1    Ready      worker              66d   v1.15.11
oep-rancher-node2    NotReady   worker              66d   v1.15.11
oep-rancher-node3    Ready      worker              66d   v1.15.11
oep-rancher-node4    Ready      worker              66d   v1.15.11
oep-rancher-node5    Ready      worker              66d   v1.15.11

# oep@rack2:~$ kubectl describe no oep-rancher-node2
Name:               oep-rancher-node2
Roles:              worker
Labels:             beta.kubernetes.io/arch=amd64
                    beta.kubernetes.io/os=linux
                    kubernetes.io/arch=amd64
                    kubernetes.io/hostname=oep-rancher-node2
                    kubernetes.io/os=linux
                    node-role.kubernetes.io/worker=true
Annotations:        node.alpha.kubernetes.io/ttl: 0
                    rke.cattle.io/external-ip: <IP_ADDRESS>
                    rke.cattle.io/internal-ip: <IP_ADDRESS>
                    volumes.kubernetes.io/controller-managed-attach-detach: true
CreationTimestamp:  Fri, 17 Apr 2020 19:39:39 +0530
Taints:             node.kubernetes.io/unreachable:NoExecute
                    node.kubernetes.io/unreachable:NoSchedule
Unschedulable:      false
Conditions:
  Type                 Status    LastHeartbeatTime                 LastTransitionTime                Reason              Message
  ----                 ------    -----------------                 ------------------                ------              -------
  NetworkUnavailable   False     Sat, 23 May 2020 23:43:47 +0530   Sat, 23 May 2020 23:43:47 +0530   WeaveIsUp           Weave pod has set this
  MemoryPressure       Unknown   Sat, 23 May 2020 23:46:13 +0530   Mon, 22 Jun 2020 18:22:34 +0530   NodeStatusUnknown   Kubelet stopped posting node status.
  DiskPressure         Unknown   Sat, 23 May 2020 23:46:13 +0530   Mon, 22 Jun 2020 18:22:34 +0530   NodeStatusUnknown   Kubelet stopped posting node status.
  PIDPressure          Unknown   Sat, 23 May 2020 23:46:13 +0530   Mon, 22 Jun 2020 18:22:34 +0530   NodeStatusUnknown   Kubelet stopped posting node status.
  Ready                Unknown   Sat, 23 May 2020 23:46:13 +0530   Mon, 22 Jun 2020 18:22:34 +0530   NodeStatusUnknown   Kubelet stopped posting node status.
Addresses:
  InternalIP:  <IP_ADDRESS>
  Hostname:    oep-rancher-node2
Capacity:
 cpu:                8
 ephemeral-storage:  51175Mi
 hugepages-2Mi:      0
 memory:             32779956Ki
 pods:               110
Allocatable:
 cpu:                8
 ephemeral-storage:<PHONE_NUMBER>1
 hugepages-2Mi:      0
 memory:             32677556Ki
 pods:               110
System Info:
 Machine ID:                 311936e2303b034fe7ef70182235b8cb
 System UUID:                564DF6D2-557B-FA25-637C-AE27270EC6F4
 Boot ID:                    ceddfa77-83b3-4f6e-b3d3-0167b5b33ddc
 Kernel Version:             3.10.0-1062.18.1.el7.x86_64
 OS Image:                   CentOS Linux 7 (Core)
 Operating System:           linux
 Architecture:               amd64
 Container Runtime Version:  docker://1.13.1
 Kubelet Version:            v1.15.11
 Kube-Proxy Version:         v1.15.11
PodCIDR:                     <IP_ADDRESS>/24
Non-terminated Pods:         (3 in total)
  Namespace                  Name                              CPU Requests  CPU Limits  Memory Requests  Memory Limits  AGE
  ---------                  ----                              ------------  ----------  ---------------  -------------  ---
  cattle-system              cattle-node-agent-kgb2q           0 (0%)        0 (0%)      0 (0%)           0 (0%)         66d
  ingress-nginx              nginx-ingress-controller-2xzvq    0 (0%)        0 (0%)      0 (0%)           0 (0%)         66d
  kube-system                weave-net-5pw2x                   20m (0%)      0 (0%)      0 (0%)           0 (0%)         66d
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
  Resource           Requests  Limits
  --------           --------  ------
  cpu                20m (0%)  0 (0%)
  memory             0 (0%)    0 (0%)
  ephemeral-storage  0 (0%)    0 (0%)
Events:              <none>

Above points to following info
Kubelet stopped posting node status

How to get the kubelet logs?

Following factors may incur this,

Need to check if the machines were reverted and restarted successfully.
Need to check if kubelet is running if node is notReady
Need to check if node is healthy when it is notReady.
There is a chance, where node bootup process might be stuck while probing the hardware if the disks have error. We may have to fix errors by running integrity checker.(fsck)
Need to check the network reachability.


add more explanation to the analysis

the analysis is a bit too brief, see other similar journeys with a more in-depth analysis: https://github.com/IBM/pixiedust-traffic-analysis#4-analyze-the-results and https://github.com/IBM/pixiedust-facebook-analysis#7-analyze-the-results

More details has been added already on 24th Aug as per Laura Bennett's comment. Please review and let us know if more details need to be added.


Add English translation

I copied the Japanese language file as the English one was missing some strings. The ones that aren't translated are left because Qt Linguist can't find them in the source code, so presumably they aren't used anymore -- but if I'm missing anything, please let me know!

Looks good to me. I appreciate your help.


Injection might fail on some circumstances

DLL injection might fail sometimes, thus rendering the program unusuable for the time being
Still looking into why it does that

In My Case:
OS: Windows 10
now set to:

Windows Locale is Japanese
Run as administrator and turn off antivirus(windows defender)
add to exclude file/folder list in antivirus
Run in LR2SD and HD both

DLL loading fails because I inadvertently compiled the DLL in debug mode... That means the DLL is looking for debug runtimes, which aren't included in the redistributable package
Fix is to wait for me to recompile the dll in release mode or manually grab the dlls from the internet (don't do that)

Updated release zip with the proper DLL (there are no new features): https://github.com/SayakaIsBaka/LR2Arena/releases/tag/0.0.1


"Include" YAML reference to preexisting Military Affidavit form

The Affidavit questions are included, yes, but Prof. Colarusso suggested in office hours that I reference a pre-existing Military Affidavit project in our database. That's all I meant by this Issue. Upon further review, though, I think my proposed revision is better captured in my more recent Issue regarding how the plaintiff would know the defendant's status and contact info. I will close this one.


SKYRIM AE(1.6.640) SKSE is now 2.2.3, while you are building your mod off of SKSE 2.2.2

Duplicate


添加延安大学

https://www.yau.edu.cn/  (the university official website URL)
http://jsjxy.yau.edu.cn/xygk1/zysz.htm  (4-year IT related course is offered by the university)

@only-gale Pull request merged. Thank you!

@only-gale Pull request merged. Thank you!


PCL to netstandard1_3

Replace CORE_PCL define with NETSTANDARD1_3
Also make other conditional includes more consistent.
Fixes #452

@pharring,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


RFI: use-package and system repo

I've migrated to hand built emacs 29 which includes eglot. I would like to still use stright/use-package but when I
(use-package eglot... )
it's cloning it. Ive browsed through the docs but cant seem to pinpoint what I need to set to stop it cloning if there is a local repo. I obviously dont want to hard code a recipe  pointing to emacs 29 elisp files if at all avoidable.

Hi. Thanks for taking the time to fill out a support ticket.
Please see the following:
https://github.com/radian-software/straight.el#how-can-i-use-the-built-in-version-of-a-package
Does that help?

I totally missed that Nicholas. Thank you. It worked as desired. Would that fall back to straight installing it if the library didnt exist I wonder? eg if I had to move back to emacs 28 (which I wont:)).

Fantastic. I'm trying to manipulate that into the (use-package :straight ...) form referenced above. I shall keep at it - I need to blow the cobwebs away.

The use-package equivalent:

The use-package equivalent from my config. Using a permalink as I can't get elisp embedding properly.
use-package using system libraries based on Emacs version.

(eval `(use-package eglot ,@(when (>= emacs-major-version 29) '(:straight (:type built-in)))
  :config
  (use-package eldoc-box)
  :hook
  (prog-mode . eglot-ensure)
  (prog-mode . eldoc-box-hover-mode)
  :bind
  (:map flymake-mode-map
        ([remap next-error] . flymake-goto-next-error)
        ([remap previous-error] . flymake-goto-prev-error))
  (:map eglot-mode-map
        ("<M-return>" . eglot-code-actions))))

You shouldn't need to eval the declaration.
The :straight keyword can handle the backquoted list as well. e.g.
(use-package eglot
  :straight `(eglot ,@(when (>= emacs-major-version 29) (:type built-in))))

Should roughly expand to:
(progn
  (straight-use-package
   `(eglot ,@(when (>= emacs-major-version 29) (:type built-in))))
  (require 'eglot nil nil))

Unfortunately that doesn't work.

Debugger entered--Lisp error: (void-function :type)
(:type built-in)
(progn (:type built-in))
(if (>= emacs-major-version 29) (progn (:type built-in)))
(cons 'eglot (if (>= emacs-major-version 29) (progn (:type built-in))))
(straight-use-package (cons 'eglot (if (>= emacs-major-version 29) (progn (:type built-in)))))
(progn (straight-use-package (cons 'eglot (if (>= emacs-major-version 29) (progn (:type built-in))))) (defvar use-package--warning105 #'(lambda (keyword err) (let ((msg (format "%s/%s: %s" ... keyword ...))) (display-warning 'use-package msg :error)))) (condition-case err (if (not (require 'eglot nil t)) (display-warning 'use-package (format "Cannot load %s" 'eglot) :error)) ((debug error) (funcall use-package--warning105 :catch err))))
elisp--eval-last-sexp(nil)
eval-last-sexp(nil)
funcall-interactively(eval-last-sexp nil)
command-execute(eval-last-sexp)

Apologies, that was a typo on my phone. The list to splice in needs to be quoted.
(use-package eglot
  :straight `(eglot ,@(when (>= emacs-major-version 29) '(:type built-in))))


Maven 3.9.0 broke some build due to breaking changes.

Description
As reported in Release Notes – Maven 3.9.0 - Potentially Breaking Core Changes:
Maven 2.x was auto-injecting an ancient version of plexus-utils dependency into the plugin classpath, and Maven 3.x continued doing this to preserve backward compatibility. Starting with Maven 3.9, it does not happen anymore. This change may lead to plugin breakage.
It caused a failure just like A required class was missing while executing org.jboss.forge.furnace:furnace-maven-plugin:2.29.1.Final:addon-install: org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory in  https://github.com/windup/windup/actions/runs/4302723286/jobs/7501572355#step:5:10015
Would it be possible to downgrade to Maven 3.8.7?
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 18.04
[X] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Image version 20230227.2
Failed build link https://github.com/windup/windup/actions/runs/4302723286/jobs/7501572355#step:5:10015
Is it regression?
yes, latest working image 20230217.1, latest successful build https://github.com/windup/windup/actions/runs/4232267464/jobs/7351789096
Expected behavior
The Maven build should work.
Actual behavior
The Maven build doesn't run.
Repro steps
Run a Maven build which involves executing a Maven plugin that depends on plexus-utils dependency with Maven 3.9.0

As a workaround, before the failing Maven build, add the step
    - name: Set up Maven
      uses<EMAIL_ADDRESS>      with:
        maven-version: 3.8.7

@mrizzi thank you for reporting and for the workaround. we hope that the issue will be solved in upstream repository soon.

@ddobranic we are unable use unverified git action due company security policy. Is there workaround to downgrade maven version via script on the runner before execution time.
Please advise ?

@brvaland you can see how we install maven here
please use this link for previous version

It is affecting azure pipelines too, did anyone set the version to 3.8.7 in azure-pipelines.yml from default 3.9.0 (without adding the maven directory path from the source directory)
Please advise how to resolve build in azure pipelines.

how to resolve for build in azure-pipelines.yml file? please advise. Getting this issue in build as pipelines is taking default to 3.9.0

Just to be sure, I understand correctly, does that means there is no official way to force the maven version in github action ?

Starting with Maven 3.9, it does not happen anymore. This change may lead to plugin breakage.

If you face plugins which failed because of this  :

You should try to update to a recent version of this plugin. As this should be fixed by plugin maintainer.
If there is no fix, a workaround could to add yourself plexus-utils dependency to this plugin in your build. E.g. for impsort-maven-plugin :

<plugin>
  <groupId>net.revelc.code</groupId>
  <artifactId>impsort-maven-plugin</artifactId>
  <!--  stuck to 1.6.x for java8 compatibility -->
  <version>1.6.2</version>
  <dependencies>
    <!-- Needed because of maven 3.9.0 backward compatibility issue,
         See : https://github.com/revelc/impsort-maven-plugin/issues/64 -->
    <dependency>
      <groupId>org.codehaus.plexus</groupId>
      <artifactId>plexus-utils</artifactId>
      <version>3.5.1</version>
    </dependency>
  </dependencies>
</plugin>

you can try to force maven version in your github action like explain in previous comments :point_up:  BUT

it seems there is no official way to do that.
this will not make your build work locally with maven 3.9 and above.

(I created corresponding stackoverflow question, maybe this will help to give visibility to this issue : https://stackoverflow.com/questions/75652635/a-required-class-was-missing-while-executing-maven-plugin-with-github-action)


typo in docs: one ==> once

in tensorflow/docs_src/programmers_guide/datasets.md

Can one of the admins verify this patch?

I signed it!


Fire damage is inconsistent

Fire will sometimes do zero damage

Tested this with both a laptop and a friend and it seemed fine, but we'll know for sure next playtest with edge scenarios.

Have pushed a new fix that I'm hopeful for; proxy clients should correctly check for fire destruction (previously it appeared to only work in host -> client and client -> host scenarios).


Integrate go string extraction into floss #808

This Pull Request aims to integrate Go string extraction functionality into the Floss project, addressing issue #808

Can you submit a PR to merge this into your Arker123:go-strings branch? That way we can focus this review on the relevant changes. This may has to happen in your fork and I'm happy to review there.


How does the 3D earth disappear

Hi,
In my project , the background 3D earth is not always there, sometimes it is disappeared. How to fix this?

Hi, @m7567, we'll need some more context here. Please ask the question over at the Cesium Forum and include screenshots and/or a code snippet showing the problem using Sandcastle.
There are members of the community and developers from the team who answer these kinds of questions there. Additionally, Cesium's a big project, so we use GitHub for feature requests and bug tracking exclusively. Thanks!


create color blind friendly palette

I'm curious if the default colors in the IPT (e.g. GBIF green) are colorblind friendly? My immediate use case is that we were asked to ensure that the two IPTs managed by USGS are accessible with respect to color blindness, in compliance with government policy. However, it seems like a good thing to be mindful of, or document if it has already been discussed.
Here are a few things I found while I was searching:

I couldn't find a way to learn the values of the default colors myself (RGB or hexadecimal) through the IPT, so I couldn't confirm it on my own.
The IPT manual doesn't explicitly mention it.
I only found one issue in github that seemed tangentially related, but isn't asking the same question.

Hi,
The colours should be chosen from the GBIF palette here: https://www.gbif.org/logos#_gbif-colours
I don't think we rely on colours for meaning, they are supplemental to text labels, so the problem would be low-contrast combinations.  I don't see a problem using an online tester, but maybe @kcopas knows if colour blindness was taken into account when creating the palette.

Note that it is also possible to customize the colours of an IPT (in Administration > UI Management). We did so for our IPT to align it with the brand colours of our institute: https://ipt.inbo.be/resource?r=hg_oostende

@sformel-usgs Thank your time testing this.
Let's keep it open for now

@sformel-usgs Just in case, https://ipt-obis.gbif.us/ is 2.7.1 which is not the most recent version (which is 2.7.3). Since then, we changed type/subtype badges and visibility indicators.
The most recent snapshot version is deployed here https://ipt.gbif-uat.org/

I've upgraded ipt-obis.gbif.us and ipt.gbif.us, they were missing from the upgrade script.

Thank you Matt!

I just noticed the changes, thanks for doing so! I'll do another review with ANDI when I have a spare moment.

@sformel-usgs Thank you very much for testing the IPT and providing suggestions to improve IPT accessibility.
I do like those more contrast colors but aren't they a little too dark?
@javiesgm Would like to hear from you

They might be a little dark.  I was just reporting what the ANDI tool was automatically suggesting.

@sformel-usgs  I've adjusted the colors and added title to languages.
https://ipt.gbif-uat.org/

Excellent!  There are two more contrast flags.  I must have overlooked them before.

The text at the top describing the number of available resources.  The ANDI tool suggests changing it from #61a861 to #3e853e
The RSS feed link at the bottom.  Suggested change from #4ba2ce to #277eaa.

@sformel-usgs Thanks Stephen. Those are configurable in the admin menu (primary and link colors) so one can set whatever color they want.


Contribute page for the PDCM resource

Description
As a developer, I want to have a Contribute page for the PDCM resource.
Acceptance criteria

[ ] done

@ficolo is this a duplicate? If so please close


for x in y by -1

Someone recently tweeted their frustration at for loops in CoffeeScript, and particularly this nasty case:
console.log x for x in y by -1

is an infinite loop for any array y, as this output makes clear:
for (_i = 0, _len = y.length; _i < _len; _i += -1) {
  x = y[_i];
  console.log(x);
}

As you can see, the index is set to 0, then counts down from there until it hits y.length.
I understand the historical reasons for this: by is only intended to be used in conjunction with the for...in range syntax. So the easy fix would be to simply throw a syntax error when by is used with the for...in arr syntax.
But we can do better by supporting for...in arr by step, where step is a constant:

If step is a positive integer value, keep the current behavior. It's fine.
If step is a negative integer value, set the initial index to y.length - 1 instead of to 0 and make the loop criterion _i >= 0; there's no need for _len.
If step is any other value (e.g. 0 or 0.2), throw a syntax error.

Variable step values should also probably be supported, though I'm not sure how zero/non-integer values should be handled; maybe the best approach is to just assume that the user knows what they're doing, in which case the compilation can be to something like
for (_len = y.length; _i = step > 0 ? 0 : len - 1; step > 0 ? _i < _len : _i >= 0; _i += step) {
  x = y[_i];
  console.log(x);
}

I just ran into an issue where I needed to iterate backwards over an array; this would have been really nice. I'm in favor of special-casing constant step values, and inserting a ?: for variable step values would be consistent with what [0..n] generates.


Add on Stamp details in FadePanel

Maybe re-use the ones from site pages?
Followup to:  https://github.com/fps-solutions/FPS-Photo-Form/issues/37

Added


Default Node.js runtime changed from 6 to 10

Fixes #170

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #171   +/-   ##
=====================================
  Coverage      99%    99%
=====================================
  Files          14     14
  Lines         402    402
=====================================
  Hits          398    398
  Misses          4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daedefd...a3df272. Read the comment docs.


Allow to add a namespace for a dependency

I would like to be able to add a namespace for dependencies added with bower.
Example:
  "dependencies": {
    "widgets/component-x"<EMAIL_ADDRESS>    "widgets/component-y"<EMAIL_ADDRESS>    "services/service-a"<EMAIL_ADDRESS>    "utils/service-a"<EMAIL_ADDRESS>  }

Or some other format on how to define a namespace for a Bower dependency.
Which would generate the following file structure:
.
└── bower_components
    ├── services
    │   └── service-a
    ├── utils
    │   └── service-a
    └── widgets
        ├── component-x
        └── component-y

The reason this option would be beneficial for our team is that we're currently re-factoring our codebase, extracting some components to their own repos to be shared with other teams in the company, and:

we want to avoid name collision (for example we have services/service-a and utils/service-a which are 2 different components, one is a service and the other is utilities related to that service);
and to maintain the require structure, so that a file that requires these extracted components will look like:

ComponentX = require 'widget/component-x'
ServiceA = require 'services/service-a'
UtilsA = require 'utils/service-a'

It's a frequent feature request, but we can't implement it. Flat tree in bower_components is integral to how bower internals work. Maybe you can use bower-installer npm package to do so.


Fixed Null exception for transaction receipts

Description:
Applying HotFix onto main.
Related issue(s):
#1734
#1733
Fixes #
Notes for reviewer:
This is being deployed into production environments with release 0.31.2
Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report
Patch and project coverage have no change.

Comparison is base (4b4e416) 76.83% compared to head (e6b02fd) 76.83%.

:exclamation: Current head e6b02fd differs from pull request most recent head 39387d2. Consider uploading reports for the commit 39387d2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   76.83%   76.83%
=======================================
  Files          39       39
  Lines        2914     2914
  Branches      585      585
=======================================
  Hits         2239     2239
  Misses        496      496
  Partials      179      179

Files Changed
Coverage Δ

packages/relay/src/lib/eth.ts
85.75% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@Nana-EC, There are no changes since your last review, just rebased.


Handle special cases for Cilium upgrades when using API

Issue #, if available:
Description of changes:
The new Cilium version changes the port number for envoy-metrics and prometheus but the field names remained the same. This caused "duplicate value" errors when upgrading to the new Cilium version using server-side apply because the merge key for these fields is the port number, not the name. See below:
"err":"failed to reconcile object /v1, Kind=Service, kube-system/cilium-agent: Service \"cilium-agent\" is invalid: spec.ports[1].name: Duplicate value: \"envoy-metrics\"","errVerbose":"Service \"cilium-agent\" is invalid
To alleviate this issue, we will use the client.Updatestrategy to update the object to be compatible with the new version of Cilium. We are only doing this for the Cilium Service, DaemonSet, and Deployment since those are the only objects affected. The rest of the objects in the Cilium upgrade manifest will continue to be applied using server-side apply.
Testing (if applicable):
Tested with Tilt
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold
we might not need this/it might not solve the problem completely

/test eks-anywhere-presubmit

/approve


Evict layers on demand

Closes https://github.com/neondatabase/neon/issues/3439
Adds a set of commands to manipulate the layer map:

dump the layer map contents
evict the layer form the layer map (remove the local file, put the remote layer instead in the layer map)
download the layer (operation, reversing the eviction)

The commands will change later, when the statistics is added on top, so the swagger schema is not adjusted.
The commands might have issues with big amount of layers: no pagination is done for the dump command, eviction and download commands look for the layer to evict/download by iterating all layers sequentially and comparing the layer names.
For now, that seems to be tolerable ("big" number of layers is ~2_000) and further experiments are needed.

My branch builds correctly locally, but here, CI fails with odd errors.
I will rebase and push.

Since there's ample python typing support, should there also be openapi description? I never understood for who is that file maintained -- if control plane autogenerates something out of that, perhaps it's better to leave it out so far.

I've tried to state it in the PR description, and after recent discussions, seems that neither of the API is final, so adding them to the openapi schema seems preliminary?
I agree that it should be done soon, but now

dumping layer map command will get more stat types and might change a few times
evicting and downloading commands might be removed in their regular form

So, not sure about this really. Do you think I still should describe these and potentially leak them into the go codegen?

I'm strongly against documenting any of these APIs in the openapi YML. They're for debugging only, the control plane should never rely on such implementation details.

I've decided to rebase and squash into one commit, since the number of separate commits became quite big for intended, small, set of changes.
I've removed key_start: String and key_end, but left lsn_start: Lsn in the API responses for layers. Layer file names are String, no entities are moved anymore, as it was initially.
The PR seems to contain the rest of the feedback in it, but please note if I missed something.


Escape search string before creating RegExp

The component should handle escaping of the search property of a string type before constructing a new RegExp instance. Fixes #17
It doesn't touch number and boolean types as they are coerced to string automatically.
It uses the escape-string-regexp library because it does the job and it's tested.

Thanks @janmyler — especially appreciate the Travis fix for iojs :)