Fix parsing of nested templates with objects (issue #537)

To fix the issue (see #537) I had to refactor the convertTemplateType function. Basically the problem was that when an embedded expression contained braces, and in this braces another template with embedded expression (etc.), the current number of opened braces was not right.
Indeed storing the current number of opened braces is not sufficient, since in the outer expression we can have an opening brace, then a template string, then the matching closing brace. This means that we need to store the number of braces for a current context, and when we encounter a new embedded expression, create a new clean context. When going back to the initial expression, we take back the matching context.
To do that I chose to store a context stack: the top context is always the current one, and depending of the tokens we encounter, we push and pop new contexts.
Sorry if this isn't very clear; it's was very painful for me to understand where the problem came from, and it's still difficult to explain 😉
I would have been so proud to produce a code that was understandable by itself, but I'm forced to admit that the algorithm is quite complicated to understand, so I had to document the code a lot. I hope and think it's easier to understand and maintain than before.

espree has similar logic for templates since it uses acorn -> esprima output https://github.com/eslint/espree/blob/master/lib/token-translator.js#L43 not I guess my original implementation had a bug that espree didn't? I do wish we could just share it if that was possible @not-an-aardvark @mysticatea

@hzoo Thank you. I checked with espree, then it worked correctly in this case. I have not understood espree's translation logic...

@hzoo @mysticatea The original issue I had was using eslint-plugin-react (see issue https://github.com/yannickcr/eslint-plugin-react/issues/1523). The problem occurred with babel-eslint, not with the default parser. I admit I don't understand how espree token translator works too 😕


BUFFER_READ_OUT_OF_BOUNDS encountered in linear stream

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?

3.3.10
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Custom App
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Chrome Mac
What did you do?

Play back a linear stream. After some random period of time, it will error out with BUFFER_READ_OUT_OF_BOUNDS.
What did you expect to happen?
Playback for eternity
What actually happened?

Please share a stream to test it and please you must to check if it happens in the Demo app. Thanks!


Update sbt, scripted-plugin to 1.4.6

Updates

org.scala-sbt:sbt
org.scala-sbt:scripted-plugin

from 1.0.4 to 1.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt" } ]

labels: library-update, semver-minor

Superseded by #63.

Superseded by #63.


Create/Delete/Read on user test profiles

Description

CRUD operations on test config update using the proto message from SMPS.
Create (POST), returns TEST_ID :
curl --location --request POST 'localhost:9081/api/user/test-prefs' \
--header 'Content-Type: application/json' \
--header 'Cookie: meshery-provider=None' \
--data-raw '{
  "smpsVersion": "v0.1",
  "name": "quick-test",
  "labels": {
    "h1": "v1"
  },
  "clients": [
    {
      "internal": false,
      "loadGenerator": "fortio",
      "protocol": "http",
      "connections": 10,
      "rps": 10,
      "headers": {
        "header1": "val1"
      },
      "cookies": {
        "cookie1": "val1"
      },
      "body": "ReqBody",
      "contentType": "application/txt",
      "endpointUrl": [
        "https://githudfgb.com"
      ]
    }
  ],
  "duration": "1s"
}'

Read (GET):
curl --location --request GET 'localhost:9081/api/user/test-prefs?uuid=<TEST_ID>' \
--header 'Cookie: meshery-provider=None'

Read All (GET):
curl --location --request GET 'localhost:9081/api/user/test-prefs' \
--header 'Cookie: meshery-provider=None'

Remove (DELETE):
curl --location --request DELETE 'localhost:9081/api/user/test-prefs?uuid=<TEST_ID>' \
--header 'Cookie: meshery-provider=None'

Notes to reviewers

This needs a bit more refining before finalizing.
Lacks frontend.
This is a followup on #1148

Checklist

[] Signed commits.
[] PR title includes [<name of area>]:<description>

We will have to consider how and where we will be storing the performance test profiles. @leecalcote I am assuming this should be a functionality of the provider, shall I add function definitions for the same in the provider interface?

Right on. Yes, please, @kanishkarj.

On Jun 21, 2020, at 1:42 PM, Kanishkar J<EMAIL_ADDRESS>wrote:

We will have to consider how and where we will be storing the performance test profiles. @leecalcote I am assuming this should be a functionality of the provider, shall I add function definitions for the same in the provider interface?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

There is an issue with supporting DELETE operation on the test configs. How should we handle the case where the test config has been deleted, but there are perf test results referring to it?
@leecalcote @kushthedude Thoughts on this?

A doubt here, we are referencing to test-profiles while storing results, like the result & the test-profile should be seperate imo. If I delete my test-profile or update it, this should not have any change on the test-results done using the profile, right ?

curl --location --request GET 'localhost:9081/api/load-test-prefs' \
--header 'Cookie: meshery-provider=None'

Is this a typo @kanishkarj ?

There is an issue with supporting DELETE operation on the test configs. How should we handle the case where the test config has been deleted, but there are perf test results referring to it?
@leecalcote @kushthedude Thoughts on this?

A query here, we are referencing to test-profiles while storing results, like the result & the test-profile should be seperate imo. If I delete my test-profile or update it, this should not have any change on the test-results done using the profile, right ?

Yes, exactly. But there are issues of inconsistency here. Let's say a test profile was updated, in a way it invalidates the old test results. Even worse, if a profile was deleted, we'd have dangling references from test results to non existent profiles.

Gorilla/mix sounds good. @nveenjain

On Jun 21, 2020, at 1:58 PM, Kanishkar J<EMAIL_ADDRESS>wrote:

@kanishkarj commented on this pull request.
In handlers/load_test_preferences_handler.go:

+type custTestConf struct {

Val *SMPS.PerformanceTestConfig
+}

+func (c *custTestConf) MarshalJSON() ([]byte, error) {

m := jsonpb.Marshaler{

EmitDefaults: true,

}
val, err := m.MarshalToString(c.Val)
return []byte(val), err
+}

+// UserTestPreferenceHandler is used for persisting load test preferences
+func (h *Handler) UserTestPreferenceHandler(w http.ResponseWriter, req *http.Request, prefObj *models.Preference, user *models.User, provider models.Provider) {
+

if req.Method == http.MethodPost {
Totally, I was considering this. I was actually thinking we must use gorilla/mux. That will allow us to build better REST APIs, check this out. What's your opinion on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have added gorilla/mux but not have restructured the code to exploit its features (might be a separate PR on its own). Also the Store SMPS takes in JSON data instead of application/x-www-form-urlencoded.

I have added gorilla/mux but not have restructured the code to exploit its features (might be a separate PR on its own). Also the Store SMPS takes in JSON data instead of application/x-www-form-urlencoded.

So the curl request in mentioned above needs to be changed into JSON format right ?

Resolving merge conflicts...

@leecalcote regarding storing user test profiles on a local database in case of default provider:

we can modify meshery/models/bitcask_results_persister.go to be more general and support storing performance test configs too.
We can create a copy of meshery/models/bitcask_results_persister.go specific to storing performance test configs.

which do you think we should proceed with?

@leecalcote regarding storing user test profiles on a local database in case of default provider:

we can modify meshery/models/bitcask_results_persister.go to be more general and support storing performance test configs too.
We can create a copy of meshery/models/bitcask_results_persister.go specific to storing performance test configs.

which do you think we should proceed with?

I'm inclined to the latter. While related, Test Profiles and Test Results have independent lifecycles; one can exist without the other. Given that each are their own construct; that each have full CRUD operations, keeping clean separation of their data models makes sense to me.

I'm not sure if there is an open question about the Delete operation for either the test profiles or the test results. But, I'll note that for those persisted by the Meshery remote provider, we'll want to support a soft delete (to tombstone the records and exclude them from resultsets, but not actually delete them) for both test profiles and test results.
Hard deletes are fine for the Meshery local provider.

@kanishkarj What is the test URL for the same? The above request seems not to be working

@kanishkarj is this still working for you? I'm not able to test. I'm not sure if it's my issue or not.

I shall test this rightaway

Thank you, sir. I’m having a side issue with running the provider-UI, which may be causing my issue in terms of being able to initiate a none provider session.

Oh yes, I was not able to get the Provider UI too. I think if I merge to the latest master branch the issue must be solved. Currently you can still test through the requests from curl.

There is some issue loading the front-end. @kushthedude could you help me out with it?

For some reason in my PR, the content-types aren't being set right by meshery server. Let's say the app requests a js file, then meshery doesn't return it with content-type of application/javascript, rather it sends it as text/plain. Thus the browser blocks these responses (security reasons).

Oh yes, I was not able to get the Provider UI too. I think if I merge to the latest master branch the issue must be solved. Currently you can still test through the requests from curl.

@kanishkarj, I & @leecalcote were not able to test the CURL too, the post request given above was failing.
I am not sure but can the problem be due to intermixing of routers, as we have used gorilla-mux for the new routes but we have not configured above old routes according to how gorilla works?

Interesting, it worked on my machine. What error did you get? Also, did you make requests with the updated curl comand above? Because, we have moved to json from form.

Interesting, it worked on my machine. What error did you get? Also, did you make requests with the updated curl comand above? Because, we have moved to json from form.

Oh I don't guess I sent JSON object, let me quickly retry

Interesting, it worked on my machine. What error did you get? Also, did you make requests with the updated curl comand above? Because, we have moved to json from form.

Oh I don't guess I sent JSON object, let me quickly retry

Also when you try, try it out with curl -v ...   This will give a detailed reason why the request failed

@kanishkarj I tried it out, POST & GET for a single test object are working but there is some error with getting for all test configs.
DEBU[0059] page , pageSize:
ERRO[0059] unable to parse page number: strconv.ParseUint: parsing "": invalid syntax
ERRO[0059] error fetching test configs

This was the error I got

Oh.. yes.. the curl command for that is wrong. Basically, to the request could you add 2 http url query parameters:
page=1 and pageSize=10? Also could you check the same for remote provider?

Oh.. yes.. the curl command for that is wrong. Basically, to the request could you add 2 http url query parameters:
page=1 and pageSize=10? Also could you check the same for remote provider?

I tried adding the query params to URL but it is still not working
command used
 curl -v --location --request GET 'localhost:9081/api/user/test-prefs?page=1&pageSize=10' \ --header 'Cookie: meshery-provider=None'
Error logs:
DEBU[0818] page 1, pageSize: 10
DEBU[0818] received page: 1, page size: 10, total: 1
DEBU[0818] computed start index: 10, end index: 19
ERRO[0818] error fetching test configs

the ui does not work Because of some request type errors. I feel it's something to do with the go code. So, let's say the ui loads up and it has to download some js files. What happens is, the meshery front-end requests for the js file with conten-type as plaintext (weird). And the browser blocks this, saying that should have been application/javascript. Check the network tab in the page.
@kushthedude could you look into this?

I will check into it, thanks for the detailed description @kanishkarj


[Bug]: TransportRaceCondition was not found in @ledgerhq/errors

Impacted Library name
@ledgerhq/hw-transport
Impacted Library version
6.30.5
Describe the bug

Expected behavior
There should be no warning .
Additional context
No response

Should be fixed since version 6.31.0


No blur on DX9

Hello,
I cannot get the blur to do anything (Changing the radius or the roughness of the material does not affect anything)
But it works on DX11 and on OpenGL.
Thanks!

Do you get any compilation errors for DX9? Also, can you confirm the latest revision has this issue? I merged my optimization branch yesterday that cuts down a fair amount of instructions - if you were reaching the limit on DX9 maybe the optimized code will help.

I don't have any errors whatsoever. :)
And yes, I use the latest one, I even checked with your project, it does work with DX11 but as soon as I go in DX9 it doesn't blur anymore.
Thank you!

Ok, thanks for the update. I'll try and figure out the issue and report back in here.

Thank you ! :)

I have the same problem, but on both dx9 and dx11. Changing max blur radius or material roughness does not help.
I'm using latest revision, thank you.

I have this same issue as well. If I force the renderer to use OpenGL 2.1 the blur always works. If I set it to DX9 or OpenGL Core it never works, and if I set it to DX11 it sometimes works, as strange as that is. The transitions between working and not working seem to be after restarting Unity or making changes that cause assets to reload. I'm thinking it's something to do with the way Unity is cross-compiling that particular shader?


(Google workspace) support user creation using iambic templates

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Community Engagement
Help us prioritize this request and express your support by adding a 👍 reaction to the original issue. This will assist both the community and the maintainers in addressing this request.
Please avoid leaving "+1" or "me too" comments as they create extra noise for issue followers and do not assist in prioritizing the request. If you are considering working on this issue or have already submitted a pull request, kindly leave a comment.

Any developer likes to take this on? there should be a pretty solid path as the google group support uses the same SDK. So I will outline roughly the implementation need.

define the Pedantic model to represent Google Workspace User (you can use the Google Workspace group as an example)
wire the Google workspace to do a User import action. you have to wire up the Google SDK call similar to other groups import is doing.

There should be a lot of parallel to Google Group implementation.

I primed the pump to have import working. But it will take more iteration to get to support create user.
https://github.com/noqdev/iambic/pull/639
It seems from API docs, create user must supply a password, which is really unfortunately, because we don't want to deal with password. (to minimize risk)


File path injected into settings is invalid

The file path written to the "scode_custom_css.imports" setting appears to be incorrect on windows. It mixes '\' and '/' (I don't think that is allowed...). It also doesn't begin with "file:///", instead it begins with "file://". According to the custom CSS extension docs, it must begin with file:///.
Furthermore, if i click on the filepath generated by VSCode-Animations, it cannot find the file, if I correct what I describe above, I can open the file just fine.

Ok, thank you for making an issue and describing it well. I will fix this and publish the new version soon, until then please just correct it manually.

I think I'll just have to wait for the fix. When I reload the window, VSCode-Animations overrides what is manually entered.
This might be a separate issue, but if there are other entries in the "vscode_custom_css.imports" setting, VSCode-Animations will delete all of them and replace it with just the one import it needs.

Oh ok, do you mind checking what version of the extension you have?
It should be 1.0.11, that separate issue was a previous bug but should have been fixed already.

I'm on v1.0.11

Ok, thanks for checking. I will fix it soon, sorry for the inconvenience.

Almost fixed. One last question if you don't mind: when you fix it to start with file:/// does clicking on the link work or do you also need to correct the slashes?

Should be fixed in the new version 1.0.12. Thanks again for helping fix this.


GitLab Processor: support provider options (similar to GithubReaderProcessor.ts)

Hey, I just made a Pull Request!
Addresses issue: 2581
:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Cool! The github processor unified github and github/api types under one processor due to the rawBaseUrl - is that something you might be willing to take on, or would that perhaps be a separate pull request? I realise it's a bigger task

Oh I see now that you tweaked GitlabReaderProcessor, which talks to a raw endpoint, but have naming inside it like apiBaseUrl that pertain to the API instead of the raw endpoint. Bit of a little mixup it seems

Ah so you are thinking of combining the gitlab reader and gitlabapi reader similar to how the github processor is configured?

yeah exactly, it simplifies things a lot for the users of these interfaces to not have to worry about what precise underlying method of consumption to use - they just post a URL to their gitlab instance and it just works

This one and the github one ought to be super similar to each other after all is said and done :)

@freben apologies for taking my sweet time with this, but hoping this is what we were looking for! 😃

@therealadum hey just checking in - things are moving around a bit and there's a couple conflicts - is there something we can do to help out?

@freben sorry about that! Just getting air from a busy week, should have time today and tomorrow to get this up to snuff 😄

@freben I assume we want to keep the existing/added functionality in spotify:master over the changes in my fork?

Yeah. Sorry to say but it may be easiest to manually apply your changes on top of a clean master since stuff moved around and some things kinda changed purposes (the new UrlReader stuff)


Update microsoft-defender-antivirus-compatibility.md

Updated the Requirements for Microsoft Defender Antivirus to run in passive mode with OS versions.

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/10001

Learn Build status updates of commit 861f431:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-compatibility.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit c86950c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-compatibility.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit dd7e5cf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-compatibility.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 6f2651b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-compatibility.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit fbc9157:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/defender-endpoint/microsoft-defender-antivirus-compatibility.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Redirecting to enabled apps that are in AppEnabler

Opening wi-fi setting from the cc, it will be redirected to TikTok.

What i(Pad)OS version are you running?
What device model are you using?
Are you using any SpringBoard tools such as Serotonin?
How can we reproduce this issue?

What i(Pad)OS version are you running?
What device model are you using?
Are you using any SpringBoard tools such as Serotonin?
How can we reproduce this issue?

Version: 16.6
Model: iPhone11
Environment: Yes, I’m using Serotonin
Issue Reproduction: just do the same as i do

enable DouYin(TikTok of Chinese version) in Bootstrap’s AppEnabler
install a tweak from telegram
click WLAN setting in cc.
it finally switch to DouYin instead of WLAN setting.

What i(Pad)OS version are you running?
What device model are you using?
Are you using any SpringBoard tools such as Serotonin?
How can we reproduce this issue?

Version: 16.6 Model: iPhone11 Environment: Yes, I’m using Serotonin Issue Reproduction: just do the same as i do

enable DouYin(TikTok of Chinese version) in Bootstrap’s AppEnabler
install a tweak from telegram
click WLAN setting in cc.
it finally switches to DouYin instead of WLAN setting.

Could you upload the deb here directly (for those who don't have Telegram)? Also, can you verify this issue still occurs when you reboot and bootstrap but don't enable Serotonin?

What i(Pad)OS version are you running?
What device model are you using?
Are you using any SpringBoard tools such as Serotonin?
How can we reproduce this issue?

Version: 16.6 Model: iPhone11 Environment: Yes, I’m using Serotonin Issue Reproduction: just do the same as i do

enable DouYin(TikTok of Chinese version) in Bootstrap’s AppEnabler
install a tweak from telegram
click WLAN setting in cc.
it finally switches to DouYin instead of WLAN setting.

Could you upload the deb here directly (for those who don't have Telegram)? Also, can you verify this issue still occurs when you reboot and bootstrap but don't enable Serotonin?

i’ll try it now
here’s the deb
DouYin_layer.zip

What i(Pad)OS version are you running?
What device model are you using?
Are you using any SpringBoard tools such as Serotonin?
How can we reproduce this issue?

Version: 16.6 Model: iPhone11 Environment: Yes, I’m using Serotonin Issue Reproduction: just do the same as i do

enable DouYin(TikTok of Chinese version) in Bootstrap’s AppEnabler
install a tweak from telegram
click WLAN setting in cc.
it finally switches to DouYin instead of WLAN setting.

Could you upload the deb here directly (for those who don't have Telegram)? Also, can you verify this issue still occurs when you reboot and bootstrap but don't enable Serotonin?

It still occurred without Serotonin.

I found a more serious issue, all notifications are redirecting to DouYin if I click them.

Duplicate of #217

already fixed in 1.1.1

already fixed in 1.1.1

greatly thanks for your efforts


Fix data types

Problem
*std::min is a template requiring identical data types, so explicitly
specify the datatype.
*Fix signed vs unsigned bitwise operation.
Change overview
Fixing some minor errors related to data types.
Testing
Verified locally with a sample program that ParseInt works as expected.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/rebase

/rebase

fast track: small PR, several checkmarks, has been up sufficient time for all timezone review


[Docs]: Add Copy to Clipboard Button for the source code

Describe what's incorrect/missing in the documentation
While working on the react-router tutorial, I was astonished to find that there is no copy to clipboard button for the code examples probably encouraging devs to write code on their own

Duplicate of #110


VM replacement failed due to network interface attached to current VM

Hi there,
I'm facing this issue that seems is a bug, asked the question in slack pulumi-azure channel, was advised to create a ticket here.
This is pulumi-python to create VM and network interface, then change custom_data of the VM which result in replacement of the resource. Pulumi up returned the following error:
azure:compute:LinuxVirtualMachine (WebVM):
error: creating Linux Virtual Machine "xxxx" (Resource Group "xxxx"): compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="NicInUse" Message="Network Interface networkinterface1 is used by existing resource /subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Compute/virtualMachines/xxxx. In order to delete the network interface, it must be dissociated from the resource.
As both the VM and the NIC are created thru the same pulumi script, I expected pulumi to handle the dependency gracefully to first delete the old VM which would dissociate the NIC and then create the new VM which is to link with the NIC. However, it looks like pulumi tried to create the new VM before deleting the old VM, hence resulted the error above.
Code snippet as following:
network_interface = azure.network.NetworkInterface("NetworkInterface",     location=az_location,     resource_group_name=resource_group_name,     ip_configurations=[azure.network.NetworkInterfaceIpConfigurationArgs(         name="{}-{}-nic".format(project, env),         subnet_id=app_subnet_id,         private_ip_address_allocation="Dynamic",         public_ip_address_id=public_ip_vm_id,     )]     )
web_vm = azure.compute.LinuxVirtualMachine("WebVM",     location=az_location,     resource_group_name=resource_group_name,     network_interface_ids=[network_interface.id],     size=config.require('vm_size'),     source_image_reference=azure.compute.VirtualMachineStorageImageReferenceArgs(         publisher="Canonical",         offer="UbuntuServer",         sku=config.require('os_version'),         version=config.require("vm_ubuntu_ver"),     ),     os_disk=azure.compute.LinuxVirtualMachineOsDiskArgs(         #name="{}-{}-osDisk".format(project, env),         caching="ReadWrite",         #create_option="FromImage",         storage_account_type="StandardSSD_LRS",     ),     admin_username=config.require('vm_admin'),     computer_name="{}-{}".format(project, env),     disable_password_authentication=True,     admin_ssh_keys=[azure.compute.LinuxVirtualMachineAdminSshKeyArgs(         public_key=config.require('ssh_pub_key'),         username=config.require('vm_admin')     )],     custom_data=databytes,     identity=azure.compute.LinuxVirtualMachineIdentityArgs(         type="UserAssigned",         identity_ids=[identity_details["id"]]     ))

Thank you for reporting this. As a workaround, you should be able to set the deleteBeforeReplace option for the VM to get this behavior.

Thank you for reporting this. As a workaround, you should be able to set the deleteBeforeReplace option for the VM to get this behavior.


Please add Linux Support

And I Heavily recommend to use an Windowing Library like GLFW or SDL.

It can compile and run on Linux now with GLFW.

Wow, It has been over a Year... Already forgot that i made this Issue


Feat: add /our-work page

Closes #67 and #205

The plan is for us to use this branch as a base for the tasks in #67.
Devs should preview PRs locally since we won't get Netlify previews for PRs based off this branch. (Our Netlify settings are currently set to only build previews for PRs targeting main, and for this feature, we don't want to worry about changing that). We still have the preview site for this branch and will be able to see the changes as PRs are merged into this branch.

Not going to merge this until all tasks in #67 have been done. Wanted to open this for feedback though if any

I had to redo the commit and force-push to fix formatting

I created a branch protection rule for the feat/our-work branch

👍 thanks!


Feature/ng13

That would have been Nice, why not keeping the pr @stevengunneweg ?

I accidentally made this PR to the repo I forked from instead of my own.
These changes are actually made in ng13-local of this repository. The only changes I made were updating dependencies and a small change on src/post-processors/key-as-default-value.post-processor.ts:8. This last change keeps existing empty translations empty when using the --key-as-default-value flag while new translations are filled with the translation key.
I think my PR could be a nice addition, but only after the ng13-local has been merged first. Until then will keep these changes in my personal repo (also released to NPM).

Thank you @stevengunneweg


[AST] NFC: Remove unused field

This doesn't appear to have ever been used.

@swift-ci please smoke test


[Bug]: Failed to create tray icon at startup warning

MenuTools produces this warning at the start of the system for no apparent reason. Despite this warning, MenuTools is running and working as intended.

MenuTools produces this warning at the start of the system for no apparent reason. Despite this warning, MenuTools is running and working as intended.

It seems this warning can be avoided by setting a 30-second delay for the MenuTools task in task scheduler.

What Windows are you using?
When you see the alert, did you see the icon on the tray icon?
TBH I need to do a review on this, but I've been very busy this past month.

Thank you for the quick reply. This is definitely not something urgent.
As of the operating system, I run Windows 10 Build 20270.
As of the tray icon, it seems like an intermittent bug. Often the icon is created and you can see it in the tray despite the alert. Sometimes the icon is not created and MenuTools is indeed not running after the alert appears and sometimes there is no issue at all. That is what made me think there might be a conflict with some other program starting at startup of the computer and why I tried to delay the start of MenuTools by 30 seconds which seems to have completely resolved the issue.

@Sevastienn yes, seems the issue is related on how Microsoft handles the "new initialization" of programs on the background.
Probably explorer is not ready yet, so that is the major issue.

Yes, that seems likely. Anyway, the delay seems to be effective in avoiding the issue. By the way, thank you for an amazing piece of software!

+1 I've been getting this issue too, but adding the 30-second delay in Task Scheduler did the trick. Thank you for mentioning that!

@Azekthi
I always get that error when rebooting after a Win 10 update - another reboot and its gone, but thanks for the heads-up 👍

visual cue


Tabs from last session are not restored

Describe the Bug

When using the "Show tabs from your last session" option, any open tabs will not appear after closing and re-opening Beaker.
Background tabs however will still be there after opening beaker again, just non-background tabs are lost.
This happens for me with the "Let Beaker run in the background" option on or off.
To Reproduce

Open Beaker
Go to the general settings page
Set "Show tabs from your last session" option
Open https://duckduckgo.com/ and put it in the background
Open https://duckduckgo.com/ and leave it in the foreground
Close Beaker
Open Beaker again
Notice that the homepage is shown, the previous tab is lost and the background tabs are still there

Expected Behavior

After opening the browser again the tabs that were open before closing last time should appear again.
Screenshots

Environment

OS: Fedora 33, x64
Beaker Version: 1.1, AppImage

Additional Context

Electron: 11.0.0-beta.18
Chromium: 87.0.4280.27
Node: 12.18.3
Hyperspace API: 1.13.0

Also I see two warnings like this in the console:
WARNING: attempted to update state of a tab not on the window
WARNING: attempted to update state of a tab not on the window

This is a duplicate of issue #12.


Fixing DocumentPersister::prepareQueryValue() for embedded documents

prepareQueryValue() does not load the metadata of embedded documents correctly. So when trying to access a field like this
->field('bidList.highest.bidder.id')->equals($bidder->getId())

it is not recognizing that bidList.highest is embedding another document and fails to load the mapping for it:
Doctrine\ODM\MongoDB\MongoDBException: No mapping found for field 'bidder' in class 'App\BaseBundle\Document\Item'.

I was very confused that this is not working currently, but after i have fixed prepareQueryValue() to handle these fields correctly, i discovered an older pull request which is adressing the same bug:
https://github.com/doctrine/mongodb-odm/pull/102
Seems it was not merged yet due to conflicts and coding standard issues, so i would like to take a new approach to fix this.

@jwage: I ran this locally and tests pass. The diff appears to be much cleaner than #102, which still needs a rebase according to your last comment from October.
@kaiwa: while this fix is fresh in your mind, do you have any input on the failing test case I created in f4afcb2de3953f75d5346f322d28afd53784c883 (currently in the elemMatch branch). I traced it back to #160, and it seems logically related to what you were fixing here -- the exception being that it was specific to metadata field processing within an $elemMatch operator.


Micro as a cross platform cli text editor

Micro Text Editor - cross platform minimal terminal / CLI text editor that humbly I think should be on your list of editors ...
VIm like syntax highlighting, good for those who don't use Vim enough to be good with it, multiple tabs, decent set of commands and an inline help similar to that of LNAV
Sort of like nano but with themes.

It looks really interesting. Added. Thanks.


Set default user in imported WSL distro

Is your feature request related to a problem? Please describe.
Is there a way to change the default user in an exported distro. The docs says to use "distro.exe config ..." which is not really a applicable
Describe the solution you'd like
Be able to change the default user using wsl.exe
Describe alternatives you've considered
There is this superuser post that tells how to do this by using regedit.exe
But I don't want to mess around with the registry.
I love WSL and it's awesome
I have never used linux apart from WSL. Keep up the great work!
cc @craigloewen-msft

There is an option to set the default user by modifying the content in /etc/wsl.conf!
if you add:
[user]
default=<yourUsername, e.g: craig for me>

You can view our docs on this here: https://docs.microsoft.com/en-us/windows/wsl/wsl-config#user
Where did you see the docs describing this? I'll update them! :)

@craigloewen-msft sorry because I was too lazy to check the docs and believed that guy who asked that question. He said that the docs said to use 'distro.exe config..'
I should have checked the docs. Sorry for the inconvenience that you experienced because of my laziness.

No problem! :) Thank you for filing the issue!


fix data collector pipeline

Description
The data collector pipeline was not properly fully checking out the branches. This PR makes sure the branches are fully checked out before diff-ing them.
part of https://github.com/inmanta/inmanta-core/issues/4886
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

The step where data is sent to influxdb was still failing because some testcase names had invalid characters e.g.:
       <testcase classname="tests.compiler.dataflow.test_model_datatrace"                   name="test_dataflow_trace[implementation-\nentity A:\n    number n\nend\n\nentity B:\n    number n\nend\n\nimplementation ia for A:\n    b = B()\n    self.n = b.n\nend\nimplement A using ia\n\nimplementation ib for B:\n    self.n = 42\nend\nimplement B using ib\n\n\nx = A()\nx_n = x.n\n            -\nx_n\n\u2514\u2500\u2500 x.n\n    SET BYx_n = x.n\n    AT {dir}/main.cf:23\n    SUBTREE for x:\n        \u2514\u2500\u2500 __config__::A instance\n            SET BY x = A()\n            AT {dir}/main.cf:22\n            CONSTRUCTED BY A()\n            AT {dir}/main.cf:22\n    \u2514\u2500\u2500 b.n\n        SET BY self.n = b.n\n        AT {dir}/main.cf:12\n        IN IMPLEMENTATION WITH self = __config__::A instance\n            CONSTRUCTED BY A()\n            AT {dir}/main.cf:22\n        SUBTREE for b:\n            \u2514\u2500\u2500 __config__::B instance\n                SET BY b = B()\n                AT {dir}/main.cf:11\n                IN IMPLEMENTATION WITH self = __config__::A instance\n                    CONSTRUCTED BY A()\n                    AT {dir}/main.cf:22\n                CONSTRUCTED BY B()\n                AT {dir}/main.cf:11\n                IN IMPLEMENTATION WITH self = __config__::A instance\n                    CONSTRUCTED BY A()\n                    AT {dir}/main.cf:22\n        \u2514\u2500\u2500 42\n            SET BY self.n = 42\n            AT {dir}/main.cf:17\n            IN IMPLEMENTATION WITH self = __config__::B instance\n                CONSTRUCTED BY B()\n                AT {dir}/main.cf:11\n                IN IMPLEMENTATION WITH self = __config__::A instance\n                    CONSTRUCTED BY A()\n                    AT {dir}/main.cf:22\n            -x_n-None]"                   time="0.124"/>
I tried to add sanitization with this commit, but it still feels a bit hackish.
              Other than that it seems to be working as expected.

Processing this pull request

Merged into branches master in c918795fd1000a316f56ad800e30a0ed91c799f1


Consider opensourcing GoHANmem

The Vita scene has a deeply anchored openness culture. Almost everything is opensource: HENkaku, the vitasdk, and most homebrews and plugins.
Could you make the source of GoHANmem available?
This has numerous advantages such as allowing other developers to make suggestions about your code, fix issues with pull requests, and keep a backup and a history of your code so that you never lose it.
Thank you for considering my request.

Thank u for using GoHANmem and giving me suggestions.
Yes, open source has its own advantages.
But
I'm not a professional programmer.
Code of GoHANmem were not clean, it may be difficult to read. So GoHANmem will not be a  open source project.
After then, the new project, such as taiGoHAN,  if there is enough time to do a good job,  optimized code, easy for everyone to read, it can be open source.
Too busy to work recently, maybe there's time to do taiGoHAN on June or later.
Thanks and have a nice day~~~

You can release it and we can clean it up.


fix(NativeDateAdapter): work around wrong javascript native Date-to-string conversions

It looks like javascript messes things up when trying to apply DST rules to format some past dates during the Date-to-string conversions. The issue pops up when the past dates don't follow today's DST rules for a given locale (usually as a result of government decisions).

Fixes #9534

Ok I tested Linux, Mac, and IE attempted to reproduce the issue described in https://github.com/angular/material2/issues/7167#issuecomment-336099104 and it seemed to work fine on all browser & OS's that I tested. So looks good


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

Hello World!

hello

Hello World!

Here!

Hello

Hello!

Hi!

Enjoying the course so far

My Comment

Hello from Maynard

Hello

Nice job

Thanks Doug

👍

Running a tad behind - sorry.

Please add me

hello!

Hello
This is samwu668

This is FaizrezaHub

Happy Wednesday !

#@Tittle


tests: subsys: logging:  Tests from /tests/subsys/logging/log_backend_fs fail on nrf52840dk

Describe the bug
A test case test_log_fs_files_max from  /tests/subsys/logging/log_backend_fs fails on nrf52840dk, causing two scenarios to fail:
subsys.logging.log_backend_fs.manualmounted.nrf5840dk and subsys.logging.log_backend_fs.automounted
To Reproduce
Steps to reproduce the behavior:

have nrf52840dk connected
go to your zephyr dir
call /scripts/twister -T tests/subsys/logging/log_backend_fs -p nrf52840dk_nrf52840 --device-testing --device-serial /dev/ttyACM0 -v --inline-logs
See error

Expected behavior
Tests pass.
Impact
Not clear
Logs and console output
START - test_log_fs_files_max
Assertion failed at WEST_TOPDIR/zephyr/tests/subsys/logging/log_backend_fs/src/log_fs_test.c:227: test_log_fs_files_max: (test_mask not equal to 0b11110)
Unexpected file numeration
FAIL - test_log_fs_files_max in 3.407 seconds

Environment (please complete the following information):

OS: Ubuntu 20.04
ToolchainZephyr SDK 0.12.2
Commit SHA or Version used: zephyr-v2.5.0-1463-gc59cf6008b60

@PerMac Thanks for reporting. Will investigate.


Does windows supported?

Does this support windows?

I don't think so, sorry. No such thing is even in the todo list. I suggest to use Docker.


Add flag for exiting with status 0 even in the presence of errors

When running gometalinter as part of a test suite I need to detect if the command ran successfully or not. Currently this is a bit problematic since gometalinter exits with a non-zero exit code in the presence of errors. That's usually fine, but for my use case I would like that to be treated as success, since I will be parsing the output anyway and I would only consider it an error if the command did not run successfully.
Thus my suggestion is to add a flag which, if given, will cause gometalinter to exit with status code 0 even if errors are reported, as long as there were no problems running the linters. I am happy to submit a PR implementing this if it is something you find useful.

In the situation you describe, what do you imagine would result in a non-zero exit status?
I don't think adding a flag is necessary, but exiting with a different status code might achieve what you want?

I am not intimately familiar with the code base so I can't give the most precise suggestions. However, I could envision a few cases where it would still exit with a non-zero exit code:

Cannot write to stdout
One of the linters failed to run or the command did not exist
Specifying an invalid command line invocation (passing a flag that does not exist etc)
Linters timing out

There are probably more. I would prefer a flag over having two different exit codes because in Go it is quite painful to get at the actual code. It is also OS-specific so it makes it harder to write portable programs if you have to distinguish between e.g. exit code 1 and 2. It can be done and is still preferable to no solution, but I would personally prefer the flag. Up to you though :)

Hey, any thoughts on this?

I think I understand what you're trying to achieve now. Currently, timeouts, missing linters, linter failures, etc. are logged but do not result in a non-zero exit status. You'd like to know that all the linters are running correctly to completion.
This seems reasonable to me.
I'd be happy with a flag like --strict that causes gometalinter to exit with a status code > 1 if any of the above issues occur. I don't like the idea of exiting with a zero status for linter failures, as this directly goes against expected behaviour. And for all practical platforms, an exit code shouldn't be an issue.

It turns out that this was more difficult than anticipated, but the new code removes the reliance on cmd/sh which is also a good thing.

Great, thank you for this! The solution you implemented will work nicely for me. And yes, it seems that getting the exit status is more portable than before (I believe windows did not implement syscall.WaitStatus before), so that will be fine. Thanks again!


Don't modify params from the caller

Before contributing, please read our contributing guidelines and code of conduct.
👀 ✔
Overview
Upgrading newrelic_rpm from <IP_ADDRESS>5 to <IP_ADDRESS>7 had an unexpected side-effect of breaking the metrics we sent to another tool because these params were deleted. We've worked around this by cloning the params:
         new_relic.increment_metric(long_name)
-        new_relic.add_custom_attributes(dimensions)
+        new_relic.add_custom_attributes(dimensions.clone)

This PR takes a slightly different approach than https://github.com/newrelic/newrelic-ruby-agent/commit/6348c3a96 and doesn't modify params.
Testing
I looked for some tests associated with 6348c3a96 that I could augment but I couldn't find any. The entire test suite passes locally.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@johnsyweb Thank you for this PR.  We're in the process of bringing our new github actions based continuous integration testing online and retiring Travis CI.  Once we've successfully completed our migration to github actions, we'll be reviewing this PR in-depth and ensuring it runs against all tests.
On first inspection, this looks like a great change and avoids modifying the passed in hash object as you have described.  I do know we make intentional decisions on implementing interactions with hashes like this for performance reasons, but I don't think this particular API call is on a "hot-path" that would negatively impact performance.  To test that hypothesis out, I plan to set up a performance benchmark test and confirm this is indeed the case as part of accepting and merging this PR.

Thanks @mwlang, I appreciate your review.

Now that our CI is setup, I'm going to close and reopen this PR to trigger our fresh CI

Thanks @tannalynn. I merged in the dev branch and CI passes :-)

Performance benchmark results show no adverse changes to processing time.  There is additional allocations, but this is expected and it's also unlikely the API is called for > 2% of all spans generated, so deemed an acceptable trade-off to solve the problem this PR solves.
Baseline vs. PR's implementation

It should be noted that the baseline benchmark compared against itself has roughly similar variance:
Baseline vs. itself


Is there a way to preload all the locales I need instead of loading them async?

We would prefer to have all of the locales we need already loaded instead of requesting them as needed.  I looked but didn't see an obvious way to accomplish this. Do you know of a way to do this?
Thanks

+1 @austhomp did you find a way to do this?


Config Request for AE and RS

Can you add a way to remove the chat message when starting a new world?

Hi @whatthedrunk
As you can see in your screenshot, the message comes from my core mod called SebastrnLib. That mod already has client and server configs for the exact feature you're requesting. Please check it out and let me know if you have any issues.
I'll close this one for now.


[WIP] Validate Project Requests on Create/Update

TL;DR
Increase the validation done on CreateProject and UpdateProject in project_manager.go
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
This is a WIP to Increase the validation done on CreateProject and UpdateProject in project_manager.go:

Validate admin.Project on UpdateProject
Add length validation for project-name Not yet implemented
Add array length validation for labels Not yet implemented

Tracking Issue
https://github.com/lyft/flyte/issues/336
Follow-up issue
NA

Hi @narape, thank you for starting this. Is this PR ready for review? or are you planning to send it once you implement the extra validation? if it's the latter, I would suggest you mark it as "Draft" until ready...

Codecov Report

Merging #132 into master will increase coverage by 0.14%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   61.51%   61.66%   +0.14%
==========================================
  Files         105      105
  Lines        7444     7444
==========================================
+ Hits         4579     4590      +11
+ Misses       2280     2268      -12
- Partials      585      586       +1

Flag
Coverage Δ

#unittests
61.66% <88.88%> (+0.14%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/manager/impl/validation/project_validator.go
77.50% <87.50%> (+0.57%)
:arrow_up:

pkg/manager/impl/project_manager.go
88.88% <100.00%> (+29.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ddcea...0f99b04. Read the comment docs.

I created this PR to start the conversation.
Right now, flyte-admin does the following validations:

project-id must be a DNS 1123 label
project-name must not be empty but there is no limit for how long it could be
project-description shouldn't be longer than 300 characters
All labels must be valid k8s labels but there is no limit on how many elements the array could have*

@katrogan / @kumare3 Do we want to limit name length and label array length? if so what will be the limit for those

I think it'd be nice to transparently offload too large free-form text fields to a blobstore. But that still leaves the question, what is a reasonable limit for text serialized directly in the db? I know Postgres already does something similar with TOAST however for entities with high read volume (so perhaps, not projects :) ) that still looks potentially expensive from a latency perspective.
@kumare3 @EngHabu any thoughts on what a 'reasonable' limit for project attribute fields could be if we wanted to enforce it?

I think it'd be nice to transparently offload too large free-form text fields to a blobstore. But that still leaves the question, what is a reasonable limit for text serialized directly in the db? I know Postgres already does something similar with TOAST however for entities with high read volume (so perhaps, not projects :) ) that still looks potentially expensive from a latency perspective.
@kumare3 @EngHabu any thoughts on what a 'reasonable' limit for project attribute fields could be if we wanted to enforce it?

Ya these should not be offloaded. I think I want the offloading to part of the documentation story.
These direct entities should have small manageable payload and maintain performance

@kumare3 Could you compute p75, p90 and p99 for project-name length and for number of labels among the projects at Lyft to have those numbers as reference?

@narape we can and share those numbers

hey @narape this is difficult to do for labels b/c we store them as serialized bytes but for name and description:
 select percentile_disc(0.75) within group (order by length(projects.name)) as p75, percentile_disc(0.9) within group (order by length(projects.name)) as p90,  percentile_disc(0.99) within group (order by length(projects.name)) as p99 from projects;
 p75 | p90 | p99
-----+-----+-----
  19 |  24 |  39

 select percentile_disc(0.75) within group (order by length(projects.description)) as p75, percentile_disc(0.9) within group (order by length(projects.description)) as p90,  percentile_disc(0.99) within group (order by length(projects.description)) as p99 from projects;
 p75 | p90 | p99
-----+-----+-----
  47 |  67 | 150

@kumare3 @katrogan I went ahead and picked 64 for name and 16 for number of entries in the map. Also do you know how can I fix the other build checks? they failed when trying to push a docker image to github registry

hey @narape can you follow these instructions to try the tests out in a fork? https://github.com/lyft/flyteadmin/tree/master/boilerplate/lyft/github_workflows
@EngHabu says he's working with @evalsocket to make this process less of a pain in the future :)
in the meantime, he adds:

go to your fork -> settings -> secrets and create a secret: FLYTEGITHUB_REPO with <fork>/flyteadmin as the value
Create a PR from your branch admin-check-limits into the own fork's master, this should trigger all the checks and you should have permissions to run them all

mind linking your fork PR once it's ready? sorry again for the extra trouble

@katrogan now my PR is working (thanks to the work done by @EngHabu) can you review this? Specially about the arbitrary limit that I chose

the limits you selected look good! we can always iterate based on user feedback too if they end up being onerous


aTimeout returns a promise so it does not need to be async itself

export async function aTimeout(ms) {
should just be export function aTimeout(ms) {

fixed in latest release 🎉


"Build and run directly in the simulator using Xcode" -> "Module 'Swift' cannot be imported in embedded Swift mode"

I have a fresh clone of the template repo at https://github.com/jverkoey/rolypolyadventure.
When I try to open the Package.swift and build in Xcode, I get the following error:
Module 'Swift' cannot be imported in embedded Swift mode

Sharing here as I've just ran into this, will update this issue as I find ways to work around / resolve this.

Seems related: https://devforum.play.date/t/swift-playdate-examples-build-error-on-m3-macbook-air/16822

swift package pdc from the command line works though.

Did you select the nightly toolchain in the Xcode > Toolchains menu item?
From the toolbar it looks like it's not set, which is usually what gives this error.

Oh! I haven't changed toolchains before and feel like I'm blind; where do I do that in Xcode?

Ah found it in the Xcode menu. I was thrown off by the mention of the toolbar; where did you look in the screenshot to identify the selected toolchain?

Ahh neat, there's a little link icon in the build bar.


Indexing for ReLaion

Will you offer an API for knn search over ReLaion like you did with Laion?
Thanks!

same question , the best work


[cxx-interop] Disable auto-conformance to CxxSequence for non-random-access collections

Iterating over a CxxSequence that is not a CxxRandomAccessCollection triggers a copy of the C++ collection. Let's disable the automatic conformances until we find a more efficient solution.
This means that for now developers won't be able to iterate over a std::set or std::list with a Swift for-in loop. I will submit a separate patch with an alternative solution for such types.
C++ random access collections, such as std::vector or std::string, are not affected.

@swift-ci please smoke test

@hyp we'll still synthesize the conformance to KnownProtocolKind::CxxRandomAccessCollection a few lines below the commented out line. Adding an explicit CxxSequence conformance to RAC is not really necessary, since CxxRandomAccessCollection inherits from CxxSequence.

Makes sense!


Crashed right after dragging the image to animation tab

Godot version
4.0 dev (1ed549e)
System information
Linux mint 20.3 Cinnamon 5.2.7 Intel core i5-7300HQ GTX-1060 Mobile 6gb
Issue description

Steps to reproduce
Crashed right after dragging the image to animation tab
Minimal reproduction project
project.zip

As mentioned above it's currently impossible to reproduce this issue because there isn't enough information and the MRP is not an actual project. I'm going to close this report, but if you can provide more information and a better demonstration of the problem that leads to a crash, we can reopen it.


Many NPCs Broken Aug 14th 2024 Update

Many NPCs seem to have broken with the body-style change on August 14th 2024

Example


Compatibility Goals

Hi there! I've started using this project to help add compression support to one of my own, and it's worked really well. I was going to see if I could help work on the codebase a little bit, to add a few things like standard exports for CompressionStream and DecompressionStream for where you only need it to polyfill a section of the Compression Streams API.
My projects that rely on this are running in modern browser and Node versions, so I don't have to worry about things like TransformStream and other APIs that may be needed for this to run. The only platform currently a little behind now is Node, as it doesn't support the deflate-raw format, while it does support compressing and decompressing for gzip and deflate. So I wanted to add a feature detection for the polyfill that will also apply it when that is the case, as currently Node won't be polyfilled here because parts of the API are supported with the other two formats.
I was also planning on using this in both WebKit and Gecko platforms, but looks like those have only just recently added support for the full Compression Streams API (wow, yay!). So looks like now this can be the best for older browser versions, and also for Node/old Node versions.
How far back in browser support do you plan for this polyfill to go? I was going to refactor things to use modern syntax to do the feature detection, but then I realized that I probably shouldn't use modern features for a polyfill implementation, haha.
Thanks for making this! It really does help to even out the feature parity across platforms, which allows me to write my libraries with one syntax that essentially works everywhere, with a single build output.

Once again, I think I'm going to learn more about the best practices before I recommend changes that don't make sense. But my first thought was to change out the globalThis, self, and global check out to just a single globalThis call, as that's been available across most platforms for a few years now. But if this is meant to go back fairly far in terms of support, then that definitely makes sense to include the global scope check.

Apologies for the delayed response! This polyfill is intended to work on browsers from as far back as roughly 2015, simply because that's the same level of support that web-streams-polyfill offers AFAICT. You're probably right that for most users, globalThis alone is enough, but I felt that supporting a few years of extra browsers could be worth the 20 or so bytes that the extra check costs.

Oops sorry I left this open so long.


Have an attr that allows you to query for data for a given request ID

It would be nice to build a Fido query for a given request ID, for example after you've identified the ID from the datacenter.
You can of course filter this after the search by filtering the QueryResponse table, but it would be nice to search like:
a.stix.uid(xxxx) or a.stix.request_id(xxxx)

Yea it was on my mind would you want it to work on its own e.g. Fido.search(a.Time(), a.Instrument.stix, a.stix.RequestID(123456789) or with a time range? On its own would need to search all directories which would take a while ...

Ok if in addition to time this should be pretty relatively straight forward


Representing specific flow cells for DNA sequencers

cc @turbomam
If we need to represent Illumina NovaSeq 6000 S4, I assume we would create a subclass of
id: OBI:0400043
name: flow cell
def: "Aparatus in the fluidic subsystem where the sheath and sample meet. Can be one of several types; jet-in-air, quartz cuvette, or a hybrid of the two. The sample flows through the center of a fluid column of sheath fluid in the flow cell." []
synonym: "flow_cell" EXACT []
relationship: RO:0000085 OBI:0000370 ! contain function
is_a: OBI:0000967 ! container
and then make a part_of link to the sequencer, eg.
id: OBI:0002630
name: Illumina NovaSeq 6000
def: "A DNA sequencer which is manufactured by the Illumina corporation, with two flow cells and an output of up to 6000 Gb (32-40 B reads per run). The sequencer utilizes synthesis technology and patterned flow cells to optimize throughput and even spacing of sequencing clusters." []
synonym: "NovaSeq 6000" EXACT []
is_a: OBI:0400103 ! DNA sequencer
Would this be a new robot template? E.g. something like:

Sequencers
flow cell
description

Illumina HiSeq 2500
High Output flow cell
Higher throughput but longer run times than Rapid Run mode

Illumina HiSeq 2500
Rapid Run flow cell
Faster run times but lower output than High Output mode

Illumina HiSeq 3000
patterned flow cell
Similar to HiSeq 4000 but with lower throughput

Illumina HiSeq 4000
patterned flow cell
High-output flow cell for various applications

Illumina HiSeq X
patterned flow cell
High-throughput flow cell optimized for human whole-genome sequencing

Illumina iSeq 100
iSeq 100 i1 flow cell
Single flow cell type for iSeq 100

Illumina MiSeq
v1
Lowest output flow cell for MiSeq

Illumina MiSeq
v2
Mid-range output flow cell for MiSeq

Illumina MiSeq
v3
Highest output flow cell for MiSeq

Illumina NextSeq 550
High Output flow cell
Higher capacity flow cell for NextSeq 550

Illumina NextSeq 550
Mid Output flow cell
Lower capacity flow cell for NextSeq 550

Illumina NovaSeq 6000
S1
Lower output flow cell for NovaSeq 6000

Illumina NovaSeq 6000
S2
Mid-range output flow cell for NovaSeq 6000

Illumina NovaSeq 6000
S4
Highest output flow cell for NovaSeq 6000, up to 10B reads

Illumina NovaSeq 6000
SP
Lowest output flow cell for NovaSeq 6000, fastest run times

Ion Torrent PGM
Ion 314 chip
Lowest throughput chip for PGM

Ion Torrent PGM
Ion 316 chip
Mid-range throughput chip for PGM

Ion Torrent PGM
Ion 318 chip
Highest throughput chip for PGM

Ion Torrent Proton
Ion PI chip
High-throughput chip for Proton

Ion Torrent S5
Ion 520 chip
Low to mid-range throughput chip for S5

Ion Torrent S5
Ion 530 chip
Mid to high-range throughput chip for S5

Ion Torrent S5
Ion 540 chip
Highest throughput chip for S5

Oxford Nanopore GridION
R9.4.1 flow cell
Standard flow cell for GridION (same as MinION)

Oxford Nanopore MinION
R10.3 flow cell
Newer flow cell with improved accuracy for MinION

Oxford Nanopore MinION
R9.4.1 flow cell
Standard flow cell for MinION

Oxford Nanopore PromethION
R9.4.1 flow cell
High-capacity flow cell for PromethION

Pacific Biosciences Sequel
SMRT Cell 1M
Standard flow cell for original Sequel system

Pacific Biosciences Sequel II
SMRT Cell 8M
High-capacity flow cell for Sequel II system

I think this has potential, but those flow cell definitions are for cytometers, not sequences.

I like this but it will result in a lot of pre-composed classes over time. Who's going to maintain them, or keep the set complete?

I think we should share with Chris our issues we have had in trying to
maintain definitions for instruments. We initially wanted to follow an
approach like Chris has here, but the problems are that:

much of the information on instruments come from marketing materials,
which are full of 'fast', 'high throughput', 'massively parallel' etc.
statements that don't age well at all.
The same machine may be sold under different names for marketing reasons
or due to company mergers
We have found that most users just want to refer to what sequencer they
used, and really just want a label and identifier; that is what we have
committed to maintaining.

On Thu, Sep 12, 2024 at 11:35 AM Mark Andrew Miller <
@.***> wrote:

I like this but it will result in a lot of pre-composed classes over time.
Who's going to maintain them, or keep the set complete?
—
Reply to this email directly, view it on GitHub
https://github.com/obi-ontology/obi/issues/1820#issuecomment-2346625450,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJX2ITKYXLZ33DBRON7T6LZWGYCNAVCNFSM6AAAAABOBXSD42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGYZDKNBVGA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Bjoern Peters
Professor
La Jolla Institute for Immunology
9420 Athena Circle
La Jolla, CA 92037, USA
Tel: 858/752-6914
Fax: 858/752-6987
http://www.liai.org/pages/faculty-peters

OBI's root DNA Sequencer class can be found here in OLS

Mark and I talked about this a bit offline, I care less about the flowcell IDs since it impacts throughput but not analysis. What I would like to see is

Illumina NovaSeq X added
Groupings by series (ex Illumina HiSeq, Illumina NovaSeq, etc), this makes the ontology easier to read and we have cases where we don't have the model number (ex we know it is illumina NextSeq but not if it is 500 or 550.

Both of those requests are straightforward to implement, and make perfect sense. I am hoping @turbomam can compile all the manufacturer / series you will need, and get it into OBI.

Illumina NovaSeq X was added recently in PR 1804, which will go live in the next OBI release.

I second the motion for grouping terms for the sequencer series. I've also run into situations of not knowing which exact member of the series is in play.

Discussed on Sept 30 call - general agreement that grouping terms for the sequencer series is a good idea.
Mark is going to provide a table with info on related terms from different sources.
He will propose grouping terms along the lines of this example:  'Illumina HiSeq Series sequencer' .

I'm thinking about starting two new issues, in which case I would propose closing this issue about flow cells

add grouping classes for DNA Sequencer series (following the summaries that @mgiglio99 provided above)
adding is_manufactured_by Illumina to all Illumina brand DNA sequencers. They are missing from a few:

runoak --input sqlite:obo:obi info .desc//p=i 'DNA sequencer' .not .child//p=OBI:0000304 Illumina | \
    grep -P 'Illumina|Genome Analyzer'

OBI:0002128 ! Illumina Genome Analyzer
OBI:0002000 ! Genome Analyzer IIx
OBI:0002129 ! Illumina HiSeq X Ten
OBI:0002027 ! Genome Analyzer IIe


PubMedFetcher cache going into "default" directory relative to runtime directory

Problem:
PubMedFetcher cache file "pubmedfetcher.db" is being placed in a novel "default" directory created at runtime by metapub.  Directory is being created as a subdirectory of the current running directory.
Correct behavior:
pubmedfetcher.db should be going into ~/.cache or as otherwise set by developer in PubMedFetcher(cachedir="/some/other/directory")
Solutions:

Best for codebase: refactor caching to use environment variable(s), e.g. "METAPUB_CACHEDIR", with default still ~/.cache

Quick and dirty: put pubmedfetcher.db back into ~/.cache dir

Not sure right now where this bug was introduced.

Fixed in 0.5.11


Fix - adding auth challenge

Needed for working with staging SSL. Without it, we get -999 Cancelled error

Tested locally, merging.


Filter Thead from Table children warning

The warning from #257 is currently showing if there is a <Thead> component in a <Table>.
Example: the sample code here https://github.com/glittershark/reactable#customizing-columns.

Thanks!


Optional boolean resolves to true, false or undefiend

class Foo {
  boolField? = false
}

This resolves to a container type with undefined | true | false so type.isBoolean() check on either the true type or the false type fails.
[
  TypeActivator {
    _name: 'false',
    _fullName: 'false',
    _kind: 2,
    _constructors: [],
    _properties: [],
    _indexes: [],
    _methods: [],
    _decorators: [],
    _typeParameters: [],
    _ctor: undefined,
    _ctorDesc: ConstructorImportActivator {},
    _interface: undefined,
    _isUnion: false,
    _isIntersection: false,
    _types: [],
    _literalValue: undefined,
    _typeArgs: [],
    _conditionalType: undefined,
    _indexedAccessType: undefined,
    _functionType: undefined,
    _genericTypeConstraint: undefined,
    _genericTypeDefault: undefined,
    _isGenericType: false,
    _genericTypeDefinition: undefined,
    _baseType: LazyType {
      typeResolver: [Function (anonymous)],
      resolvedType: [TypeActivator]
    }
  },
  TypeActivator {
    _name: 'true',
    _fullName: 'true',
    _kind: 2,
    _constructors: [],
    _properties: [],
    _indexes: [],
    _methods: [],
    _decorators: [],
    _typeParameters: [],
    _ctor: undefined,
    _ctorDesc: ConstructorImportActivator {},
    _interface: undefined,
    _isUnion: false,
    _isIntersection: false,
    _types: [],
    _literalValue: undefined,
    _typeArgs: [],
    _conditionalType: undefined,
    _indexedAccessType: undefined,
    _functionType: undefined,
    _genericTypeConstraint: undefined,
    _genericTypeDefault: undefined,
    _isGenericType: false,
    _genericTypeDefinition: undefined,
    _baseType: LazyType {
      typeResolver: [Function (anonymous)],
      resolvedType: [TypeActivator]
    }
  }
]

What's your tsconfig?
I get
_ßr.Type.store.set(11356, {
	k: 1,
	isg: false,
	n: "Foo",
	fn: "@@this/dev/quick-tests/index.ts:Foo#11356",
	props: [{
		n: "boolField",
		t: _ßr.Type.store.wrap({
			n: "boolean",
			k: 2,
			ctor: function () {
				return Promise.resolve(Boolean);
			}
		}),
		am: 2,
		acs: 0,
		ro: false,
		o: true
	}],
	indxs: [],
	args: [],
	ctors: [{params: []}],
	ctor: function () {
		return Promise.resolve(Foo);
	}
});

Which is optional boolean property, as it should be.

Okay, I found it. That's cuz of strictNullChecks option.
That's related to #45

I have that turned on. Do you mean exactOptionalPropertyTypes?

The behavior of transformer is wrong and is caused by the strictNullChecks option.
I've already prepared a fix. Right now, I'm looking into the #45, which is the same problem but from another side.

Well I've found some issues with that fix. I've found super simple solution inside TypeScript which just take type and returns original type without "optionality", but it strip off nulls too. Different solution will be complicated but I'm working on it.

I wrote this message a day while working on the solution so I changed my mind several times while progressing.. I keep that so you can see (maybe 😄) why I did what I did in the end.

After some digging I found out that counting with true | false will be necessary.
I've prepared a solution of this case, so with strictNullChecks, there is no undefined if the property is optional and there is only boolean. So that's what u wanted.
But if you do something like this:
class Foo {
	boolField?: boolean | null;
}

the result will be null | true | false. That's just how TypeScript handle that, it's another simplification. Because Boolean is just an union of true and false literals. TypeScript creates one union with all the values rather than union of unions.
We have to count with true and false literals anyway. Image type string | true or "true" | true. You must be able to work with that. That's not boolean, it's only true.
Final thought... We should not remove that undefined from optional things. Imagine that you reflect over method. You want to know what argument it accepts so you will take the first param, take the type of that param and pass it to another method which should do something with that type, eg. resolve some value which can be assigned into that type. If we remove the undefined from that type, we actualy change the type and disallow the undefined value.
And Type.Undefined.isAssignableTo(typeOfThatParameter) will be false which is wrong IMHO.
Solution:
I keep those unions with null and undefined but I did (de)simplification of union true | false into boolean. Sou optional method parameters and optional properties will be always unions with undefined.
Also I added Type.isTrue()and Type.isFalse().
getType<true>().isTrue() returns true.
getType<true>().isBoolean() returns false.
getType<true>().isAssignableTo(Type.Boolean) returns true.
Published versions<EMAIL_ADDRESS><EMAIL_ADDRESS>

working.


Flow catalogue only available on http

If you're accessing node-red over https, the palette editor fails to load the catalogue as it is only available on http.

[ ] Provide better feedback in the editor if a catalogue fails to load
[x] Figure out how to make the catalogue available over https

Have setup CloudFlare for nodered.org's dns - once that has propagated we can push an update to use https by default when accessing the catalogue.


[gws][workflow2] select approver at application time

coverage: 71.029%. first build
when pulling 4b789a4ba379103db8f8d1705e10296e7e33c3fd on pr-gws-workflow2-select-approver-at-application-time
into bcddc55ad44184e0c3bb7996698e84c0b9a7e45b on master.


Need a coooke file that created after login or structure  for manual creating.

You can use an extension like EditThisCookie
Just login to twitch and export the cookies to clipboard, then paste in a file called cookies-username.json

Ty for advice.

Ty for advice. Also i have 2 ideas to resolve login ussie with devtools-drive browsers can' login. 1.Use dev-tools and running not in private mode - how i can recognize using private mode has primary part of that problem. In normal mode login is successful 2.Some third party twich chat sofware like chatterino or orion (now discomtinuied but good login solution in my view) or tc uses web page to login extract required data. A similar method could be solution to this part of the problem.
I hope my perseverance not bother you much.

Yea I will look into using the dev tools directly without puppeteer as that is more likely to work.


Replace usage of RxJava2 with RxJava1 and RxReactiveStreams.

Problem
Tests in reactivesocket-core were using RxJava2 with a DP release. RxJava2 is currently not stable.
Solution
Moved to RxJava1 with RxReactiveStreams. When RxJava2 becomes stable, we can see whether we need to use it again.

ugh

@benjchristensen this is just for unit tests.

Yes I know. That's why I chose v2 as it wasn't production critical but allowed cleaner code.

Modified the description to better depict the change.
@benjchristensen @stevegury if we aren't ok with this, lets close it.

There was tons of progress in RxJava 2 recently, my hope is that it will be usable sooner than I'd have expected.
I would prefer sticking to RxJava 2, and if it's too late, temporarily use Reactor.

Even until RxJava 2 matures, I didn't find any issues while writing this code originally with just using the snapshot it currently uses. Since ReactiveSocket is all about ReactiveStreams, it was incredibly annoying always going to and from RxJava v1 Observables, and made debugging difficult as it was transformed so many times.

Ok, closing the PR. Thanks guys for the feedback!


html-parser plugin not found

const ReactMarkdown = require("react-markdown")
const htmlParser = require('react-markdown/plugins/html-parser')

Result:
Failed to rebuild.
./src/containers/Home.js
Module not found: Can't resolve 'react-markdown/plugins/html-parser' in '/Users/decades/Documents/dfja/dragonfly2/spa/src/containers'

Indeed. There is no such a plugin in the plugins subfolder. What?

@neilyoung the file is included as part of the package, you can see it in npm here<EMAIL_ADDRESS>Can you ensure you have react-markdown installed?
Can you provide a more complete example of what you are trying?

Wow... I don't even remember to have had this problem. Can be closed :)


Partners: Issues with Streaming and MistralAI ainvoke and Callbacks Not Working

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_mistralai.chat_models import ChatMistralAI
chain = ChatMistralAI(streaming=True)
# Add a callback
chain.ainvoke(..)

# Before
# Oberve on_llm_new_token with callback
# That give the token in grouped format.

# With my pull request
# Oberve on_llm_new_token with callback
# Now, the callback is given as streaming tokens, before it was in grouped format.

Error Message and Stack Trace (if applicable)
No message.
Description
Hello

I Identified an issue in the mistral package where the callback streaming (see on_llm_new_token) was not functioning correctly when the streaming parameter was set to True and call with ainvoke.
The root cause of the problem was the streaming not taking into account. ( I think it's an oversight )

I did this Pull Request

To resolve the issue, I added the streaming attribut.
Now, the callback with streaming works as expected when the streaming parameter is set to True.

I addressed this issue because the pull request I submitted a month ago has not received any attention. Additionally, the problem reappears in each new version.
Could you please review the pull request.
System Info
All system can reproduce.

Up ?

Merged ✌


Add BadgeButton Component:

This is BASED on PR dcos-labs/ui-kit#22

feat(badgebutton): add badge button component
This adds the BadgeButton component which is a badge as a button it embraces the same
functionality like the Badge component.

Commit:
ee1224eb1c7c7107d10e9b3baba21a33eb87848c
feat(badgebutton): add on click property to badgebutton
This adds the on click property to the badgebutton and changes the element from a span to a button.
This also changes the style so that the badge button looks similar to the badge.

Commit:
421b0e74d3bd1813ca68a14122b04278bb6e22e9

@Poltergeist I pushed a commit (https://github.com/dcos-labs/ui-kit/pull/23/commits/05d9cf4e7b124fbbf126dff1ea5e59afbae4d176) where removes all the duplicated code since badge button still under the umbrella badge (take a look at the danger preview, that's a button).
For more reference please check:
https://bitbucket.org/atlassian/atlaskit-mk-2/src/291d17eb74a93dd9cbeaf76f13fe93864a85328e/packages/core/button/src/index.js?at=master&fileviewer=file-view-default

I disagree partially with that, in the case of Atlaskit, button is a package by itself. And all components are sorted in the components directory. We decided that we will have one directory per component. We should keep up to that.
What I am agreeing is that we do not necessarily need the duplicated code. So I propose that we move the badgeButton Component again out into its own directory, accompanying some tests. But using the styles from the button. Also adding the other padding definition from the CSS which was the only difference in the style. Which got deleted, unfortunately. Also by changing the export strategy in the button/index.js we introduced a breaking change. Let's not introduce a breaking change for something like that. I am going to add those changes to your commit.


Investigate possible use of Grpc for interprocess communication

look at google docs for information on protobuf

not done yet


VEIOSS-673b | Change to build sbt

retest this please

retest this please

retest this please

retest this please


Start position indexing is different for the first episode requested

CARLA version - 0.8.4
I want to always start episode from the same location so I pass the same start location index every time to game.start_episode function.
However the very first episode requested seems to have different index-to-start_location mapping - I get different location in the first episode.

Hi @Ajk4, sorry for the late response, we were on holidays :)
Sadly this is a known problem, please take a look at #310.
The issue is closed because using 0.9.0 this is not a problem anymore.


Add getCustomScripts as a lifecycle method for pages

Note: this is actually all @sbr1601's work, he just gave me the diff to make a separate PR from his other one.
We wanted to be able to add a custom script to our <head/> in order to preload some images on certain browsers (cough Safari cough). This has been tested with a test page - which is not part of this PR, b/c that was originally built in react-server-test-pages, but I'm wondering if that should go into react-server-integration-tests instead? For that matter, what's the difference between those two folders' intentions? (If it doesn't matter, I'll just push the test page I have right now into this PR.)

what's the difference between those two folders' intentions?

react-server-integration-tests is for automated tests.  No easy way to view the pages that are tested.
react-server-test-pages is a React Server site with pages that exercise interesting behavior in React Server.  You can view them and play with them.  It would be awesome to have some automated tests around these pages.
I'd say if you have a page that works in react-server-test-pages that's a nice place to have it.  Wanna take on #147? 🙏 😁

I feel like this feature needs to come with a big warning saying "DON'T USE THIS!!!".
Which makes me wonder if this is the right way to accomplish the image preloading.  Is there a more targeted API we could expose?

We could expose a getPreloadedImages method that just takes an array of image urls and creates a bunch of Image's with them (which is what we would have done with our custom script). That would certainly be more targeted, though I wonder if there are other applications where we'd want some custom script executed in the <head/>, like custom tracking, or do some setup with a third party integration? Granted, if that request comes by, we could always open up this more flexible (albeit more vulnerable) API in the future.

custom tracking, or do some setup with a third party integration?

Don't do that in the <head/>. 👿
We control where JS goes so the page author can't accidentally block the critical rendering path.  I worry that getCustomScripts is a performance foot gun.  I like your getPreloadedImages idea.  It's safer, and actually more helpful for page authors who actually want to do this.

Long term, the "right" way to handle this is with link rel=preload (not to be confused with rel=prefetch, preconnect, prerender) but Safari doesn't support rel=preload yet.
So I think it makes total sense to have a getPreloadedImages (getPreloadedResources?!) that renders rel=preload on browsers that support it (currently just Chrome, but it's spec'd/standardized) and renders optimized inline script on browsers that don't support it.

@dfabulich Wow, good point!

I am convinced! I'll get cracking on that change then 😊

Support matrix for rel=preload:

@lidawang can we close this pr, then?

Yeah, just Chrome (and Opera, which is Chrome wearing a funny hat and mustache)

@doug-wade omg I have the power to close things? 😮 It shall be done!

BTW - We have https://github.com/redfin/react-server/issues/253 open for rel=preload of JS bundles.
Something to consider for your API.
Maybe not getPreloadedImages but a slightly more general getAssetPreloads?


update CI and CODE codeowners

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Update CI and CODE codeowners
Jira/GitHub Issue numbers (if any): n/a
Preview links/images (Internal contributors only): n/a

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://662fc54ce55fa34429716288--harness-developer.netlify.app


JS DEtail Page

Put the cocktail information and movie information based off selected parameter from the Main page

Maybe split into 2 sides, 1 person for Cocktail APi, other for Movie API


Make the navbar responsive

Is your feature request related to a problem? Please describe.

The newly implemented navbar is not responsive for mobiles and other screen sizes.

Describe the solution you'd like

Make the nav elements collapse when they reach a particular screen size.

Additional context
(Refer to the link below for more information)
https://dev.to/devggaurav/let-s-build-a-responsive-navbar-and-hamburger-menu-using-html-css-and-javascript-4gci

I would like to work on this issue

Sure, go ahead!


Fix #4

Overall behaviour is OK.
However, an exception should be thrown when two modules having the same name are found. Currently, this silently takes the last one found.


supabase.auth.sign_in_with_otp with phone login throws error

Describe the bug
While the following function supabase.auth.sign_in_with_otp(params={"phone": phone, "token": verification_code, "type": "sms"}) successfully sends an OTP to the phone number described, the request returns the following error.
.
.
.
  File "/Users/zzan/Desktop/repositories/zzan-backend-fastapi/./app/routers/users.py", line 23, in post_signin_phone
    data = supabase.auth.sign_in_with_otp(credentials={"phone": phone})
  File "/Users/zzan/Desktop/repositories/zzan-backend-fastapi/venv/lib/python3.9/site-packages/gotrue/_sync/gotrue_client.py", line 299, in sign_in_with_otp
    return self._request(
  File "/Users/zzan/Desktop/repositories/zzan-backend-fastapi/venv/lib/python3.9/site-packages/gotrue/_sync/gotrue_base_api.py", line 119, in _request
    raise handle_exception(e)
gotrue.errors.AuthRetryableError: 5 validation errors for User
id
  field required (type=value_error.missing)
app_metadata
  field required (type=value_error.missing)
user_metadata
  field required (type=value_error.missing)
aud
  field required (type=value_error.missing)
created_at
  field required (type=value_error.missing)

To Reproduce
from supabase import create_client, Client

url: str = "SUPABASE_API_URL"
key: str = "SUPABASE_API_KEY"
supabase: Client = create_client(url, key)

phone: str = "PHONE_NUMBER_WITH_COUNTRY_CODE"

data = supabase.auth.sign_in_with_otp(credentials={"phone": phone})
print(data)

Expected behavior
Should return an AuthResponse class.
class AuthResponse(BaseModel):
    user: Union[User, None] = None
    session: Union[Session, None] = None

Screenshots

Environment (please complete the following information):

Python: 3.9.6
OS: macOS Ventura (v. 13.2.1)

Additional context
It seems that there is an issue occurring when the sign_in_with_otp function is called. The problem seems to be happening when the function tries to return the result of self._request(...), which is a function call in the gotrue_base_api.py module. When the _request function is called, the result variable is an empty dictionary {} which may be causing an issue during the parse_auth_response function invocation in the gotrue package.
Let me know what you guys think! I would love to try to help debug this issue as well.

Closing this as fixed as there hasn't been any reports of this issue persisting in newer versions of the library.

Getting the same error..
AuthRetryableError
gotrue.errors.AuthRetryableError: 5 validation errors for User
id
  Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.3/v/missing
app_metadata
  Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.3/v/missing
user_metadata
  Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.3/v/missing
aud
  Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.3/v/missing
created_at
  Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
    For further information visit https://errors.pydantic.dev/2.3/v/missing

Traceback (most recent call last)
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/gotrue/_sync/gotrue_base_api.py", line 116, in _request
return xform(result)
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/gotrue/helpers.py", line 66, in parse_auth_response
user = model_validate(User, user_data) if user_data else None
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/gotrue/helpers.py", line 28, in model_validate
return model.model_validate(contents)
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/pydantic/main.py", line 504, in model_validate
return cls.__pydantic_validator__.validate_python(
During handling of the above exception, another exception occurred:
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask/app.py", line 2213, in __call__
return self.wsgi_app(environ, start_response)
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask/app.py", line 2193, in wsgi_app
response = self.handle_exception(e)
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask_cors/extension.py", line 176, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask/app.py", line 2190, in wsgi_app
response = self.full_dispatch_request()
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask/app.py", line 1486, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask_cors/extension.py", line 176, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask/app.py", line 1484, in full_dispatch_request
rv = self.dispatch_request()
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/flask/app.py", line 1469, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
File "/Users/lucascassiano/Documents/GitHub/vitrus-ai-vision/gateway-server/./src/main.py", line 330, in user_sign_in
data = supabase.auth.sign_in_with_otp({'phone': phone_number})
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/gotrue/_sync/gotrue_client.py", line 306, in sign_in_with_otp
return self._request(
File "/Users/lucascassiano/.local/share/virtualenvs/gateway-server-1zd7_S6J/lib/python3.10/site-packages/gotrue/_sync/gotrue_base_api.py", line 118, in _request
raise handle_exception(e)
gotrue.errors.AuthRetryableError: 5 validation errors for User
id
Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.3/v/missing
app_metadata
Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.3/v/missing
user_metadata
Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.3/v/missing
aud
Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.3/v/missing
created_at
Field required [type=missing, input_value={'message_id': 'SM724b22e...ecc8ff615e0406e1d92cf8'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.3/v/missing
The debugger caught an exception in your WSGI application. You can now look at the traceback which led to the error.
To switch between the interactive traceback and the plaintext one, you can click on the "Traceback" headline. From the text traceback you can also create a paste of it. For code execution mouse-over the frame you want to debug and click on the console icon on the right side.

You can execute arbitrary Python code in the stack frames and there are some extra helpers available for introspection:

dump() shows all variables in the frame
dump(obj) dumps all that's known about the object
Brought to you by DON'T PANIC, your friendly Werkzeug powered traceback interpreter.

Ah yeah this is probably from the new message_id field - let's track this on a separate issue

@J0 I'm still encountering the issue as well - was the separate issue ever created?

Hey @athon-millane,
I don't think it was, sorry about that. Thanks for flagging this