PackageDeploymentManager with DeferRegistrationWhenPackagesAreInUse and DependencyPackages does not update on next app start

Describe the bug
When trying to (self-)update a MSIX package PackageDeploymentManager.AddPackageByUriAsync() method and AddPackageOptions DeferRegistrationWhenPackagesAreInUse = true AND with some DependencyPackageUris added, the MSIX package will not be updated on the next app start. Instead, the old version is re-registered and the newly staged package is being deleted again.
If you don't add any DependencyPackageUris to the options, then the update works as expected. This is the crazy part and took me lots of hours to debug. The DependencyPackageUris can be any kind of URI, the package doesn't even need to depend on it.

According to the AppxLog, Started deployment RegisterByPackageFamilyName operation on a package with main parameter PackageManagerRegisterTest_ad8pwfkyh69vj is called. But this operation seems to choose the old version instead of the new one. The AppxLog is also attached below.
Linked is a GitHub repository to reproduce the issue. The repo contains source code, and also two self-signed MSIX packages together with the self-signed certificate for testing the update scenario. https://github.com/whiskhub/PackageManagerRegisterTest
Steps to reproduce the bug
Have a MSIX packaged app (e.g. WinUI 3) that can auto-update itself. The update code should look the following:
var packageDeploymentManager = PackageDeploymentManager.GetDefault();

var options = new AddPackageOptions();
options.DeferRegistrationWhenPackagesAreInUse = true;

options.DependencyPackageUris.Add(new Uri("https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx")); // !!! THIS IS THE OFFENDING LINE. REMOVE IT AND THE BUG DISAPPEARS

var uri = new Uri("filepath_to_updated_msix.msix");
var operation = packageDeploymentManager.AddPackageByUriAsync(uri, options);

Execute the self-update within the app. Close the app. Start the app again. See the opened app and verify the version number is still old.
Confirm with PowerShell Get-AppxLog that the deferred registration took place, but with with the old version instead of the new one:

Expand for AppxLog
2024-10-24 19:02:49       603          Started deployment RegisterByPackageFamilyName operation on a package with main parameter PackageManagerRegisterTest_ad8pwfkyh69vj and Options
                                       ForceTargetApplicationShutdownOption,SkipReregisterIfPackageStatusOk,ImmediatePriorityRequest and 0. See
                                       http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing app deployment issues.
2024-10-24 19:02:49       10002        Creating Resiliency File
                                       C:\ProgramData\Microsoft\Windows\AppRepository\b11aecf4-f404-40fd-ad08-7c49d0ef4e96_S-1-5-21-2220047017-4043106817-3966502983-1002_66.rslc for
                                       Register Operation on Package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj.
2024-10-24 19:02:49       607          Deployment Register operation on package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj has been de-queued and is running for user SID
                                       S-1-5-21-2220047017-4043106817-3966502983-1002.
2024-10-24 19:02:49       854          Successfully added the following uri(s) to be processed:  C:\Program
                                       Files\WindowsApps\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj\AppxManifest.xml.
2024-10-24 19:02:49       672          Package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33321.0_x64__8wekyb3d8bbwe does not satisfy a dependency for package
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj. Reason: The package's version is lower than the required MinVersion.
2024-10-24 19:02:49       672          Package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33519.0_x64__8wekyb3d8bbwe does not satisfy a dependency for package
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj. Reason: The package's version is lower than the required MinVersion.
2024-10-24 19:02:49       672          Package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33519.0_x86__8wekyb3d8bbwe does not satisfy a dependency for package
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj. Reason: The package's version is lower than the required MinVersion.
2024-10-24 19:02:49       855          Finished resolving action lists. DeploymentRequest action lists: addPackageList: PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj
                                       destagePackageList: PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj.
2024-10-24 19:02:49       9643         0x0: TerminateApplications successful.
2024-10-24 19:02:49       9643         0x0: TerminateApplications successful.
2024-10-24 19:02:49       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x0, Set=0x20).
2024-10-24 19:02:49       9643         0x0: TerminateApplications successful.
2024-10-24 19:02:49       9643         0x0: TerminateApplications successful.
2024-10-24 19:02:49       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x0, Set=0x820).
2024-10-24 19:02:49       5507         PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj : C:\Program Files\WindowsApps\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj\microsoft.s
                                       ystem.package.metadata\S-1-5-21-2220047017-4043106817-3966502983-1002-MergedResources-*.pri : No user-specific merged files found
2024-10-24 19:02:49       5507         PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj : C:\Program
                                       Files\WindowsApps\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj\microsoft.system.package.metadata\Resources.????????.pri : No shared merged
                                       files found
2024-10-24 19:02:49       5507         PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj : C:\Program Files\WindowsApps\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj\microsoft.s
                                       ystem.package.metadata\S-1-5-21-2220047017-4043106817-3966502983-1002-MergedResources-*.pri : No user-specific merged files found
2024-10-24 19:02:49       5507         PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj : C:\Program
                                       Files\WindowsApps\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj\microsoft.system.package.metadata\Resources.????????.pri : No shared merged
                                       files found
2024-10-24 19:02:49       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x20, Set=0x0).
2024-10-24 19:02:49       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x20, Set=0x0).
2024-10-24 19:02:49       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x10000C00, Set=0x0).
2024-10-24 19:02:49       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x300, Set=0x0).
2024-10-24 19:02:49       400          Deployment Register operation with target volume C: on Package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj from:  (AppxManifest.xml)
                                       finished successfully.
2024-10-24 19:02:49       472          Moving package folder \\?\C:\Program Files\WindowsApps\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj to \\?\C:\Program
                                       Files\WindowsApps\Deleted\PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj724d814e-a6da-4d14-afd4-1aefc1964cec. Result: 0x0.
2024-10-24 19:02:50       613          Performance summary of Deployment Register operation on Package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj:
                                       Overall time: 547 ms
                                       Gap: 16 ms
                                       Enqueue cost: 0 ms
                                       Dequeue delay: 31 ms
                                       Bundle processing cost: 0 ms
                                       Indexing cost: 16 ms
                                       Resolve dependency cost: 0 ms
                                       Check approval cost: 0 ms
                                       Evaluation cost: 15 ms
                                       Hardlinking evaluation cost: 0 ms
                                       Stage required cost: 0 ms
                                       Flushing and closing files cost: 0 ms
                                       Gap: 16 ms
                                       Machine register cost: 0 ms
                                       Stage user data cost: 0 ms
                                       Registration cost: 78 ms
                                       Gap: 16 ms
                                       Repository commit transaction cost: 250 ms
                                       Gap: 62 ms
                                       Data flush cost: 0 ms
                                       Post DeStage repository commit transaction cost: 47 ms
                                       Remaining cost: 0 ms

2024-10-24 19:02:38       604          Started deployment Add operation on a package with main parameter PackageManagerRegisterTest_<IP_ADDRESS>_x64_Debug.msix, dependency parameters
                                       Microsoft.VCLibs.x64.14.00.Desktop.appx and Options 0 and DeferRegistrationWhenPackagesAreInUse. See http://go.microsoft.com/fwlink/?LinkId=235160
                                       for help diagnosing app deployment issues.
2024-10-24 19:02:38       157          The app package signature was validated for core content of the app package published by CN=Contoso Software, O=Contoso Corporation, C=US. Payload
                                       won't be validated until the files are read.
2024-10-24 19:02:38       216          App manifest validation warning: Declared namespace http://schemas.microsoft.com/developer/appx/2015/build is inapplicable, it will be ignored during
                                       manifest processing.
2024-10-24 19:02:38       170          The streaming reader was created successfully for app package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj.
2024-10-24 19:02:40       157          The app package signature was validated for core content of the app package published by CN=Microsoft Corporation, O=Microsoft Corporation,
                                       L=Redmond, S=Washington, C=US. Payload won't be validated until the files are read.
2024-10-24 19:02:40       216          App manifest validation warning: Declared namespace http://schemas.microsoft.com/developer/appx/2015/build is inapplicable, it will be ignored during
                                       manifest processing.
2024-10-24 19:02:40       170          The streaming reader was created successfully for app package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33321.0_x64__8wekyb3d8bbwe.
2024-10-24 19:02:40       10002        Creating Resiliency File
                                       C:\ProgramData\Microsoft\Windows\AppRepository\b11aecf4-f404-40fd-ad08-7c49d0ef4e96_S-1-5-21-2220047017-4043106817-3966502983-1002_65.rslc for Add
                                       Operation on Package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj.
2024-10-24 19:02:40       607          Deployment Add operation on package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj has been de-queued and is running for user SID
                                       S-1-5-21-2220047017-4043106817-3966502983-1002.
2024-10-24 19:02:40       854          Successfully added the following uri(s) to be processed:  file:///C:/Users/user/source/repos/PackageManagerRegisterTest/PackageManagerRegisterTest/bi
                                       n/x64/Debug/net8.0-windows10.0.22621.0/win-x64/AppPackages/PackageManagerRegisterTest_<IP_ADDRESS>_x64_Debug_Test/PackageManagerRegisterTest_<IP_ADDRESS>_x64_De
                                       bug.msix https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx.
2024-10-24 19:02:40       672          Package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33321.0_x64__8wekyb3d8bbwe does not satisfy a dependency for package
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj. Reason: The package's version is lower than the required MinVersion.
2024-10-24 19:02:40       672          Package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33519.0_x64__8wekyb3d8bbwe does not satisfy a dependency for package
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj. Reason: The package's version is lower than the required MinVersion.
2024-10-24 19:02:40       672          Package Microsoft.VCLibs.140.00.UWPDesktop_14.0.33519.0_x86__8wekyb3d8bbwe does not satisfy a dependency for package
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj. Reason: The package's version is lower than the required MinVersion.
2024-10-24 19:02:40       855          Finished resolving action lists. DeploymentRequest action lists: updateList: PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj is updating to
                                       PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj.
2024-10-24 19:02:43       638          Packages were not updated because affected apps are still running.  Running apps: {PackageManagerRegisterTest_ad8pwfkyh69vj!App}, Directly serviced
                                       packages: {PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj}, Indirectly serviced
                                       packages: {NULL}, Number of previous attempts: 0, Is user session locked: false, Force update deferred by package: false
2024-10-24 19:02:43       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x0, Set=0x20).
2024-10-24 19:02:43       638          Packages were not updated because affected apps are still running.  Running apps: {PackageManagerRegisterTest_ad8pwfkyh69vj!App}, Directly serviced
                                       packages: {PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj}, Indirectly serviced packages: {NULL}, Number of previous attempts: 0, Is user
                                       session locked: false, Force update deferred by package: false
2024-10-24 19:02:43       658          Marking package {PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj} for deferred registration because
                                       {PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj} is still running.
2024-10-24 19:02:43       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x0, Set=0x400).
2024-10-24 19:02:43       617          Successfully updated the status for package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj and user
                                       S-1-5-21-2220047017-4043106817-3966502983-1002 (Clear=0x20, Set=0x0).
2024-10-24 19:02:43       400          Deployment Add operation with target volume C: on Package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj from:
                                       (PackageManagerRegisterTest_<IP_ADDRESS>_x64_Debug.msix)  finished successfully.
2024-10-24 19:02:43       613          Performance summary of Deployment Add operation on Package PackageManagerRegisterTest_<IP_ADDRESS>_x64__ad8pwfkyh69vj:
                                       Overall time: 5141 ms
                                       Enqueue cost: 1657 ms
                                       Dequeue delay: 0 ms
                                       Bundle processing cost: 0 ms
                                       Indexing cost: 15 ms
                                       Resolve dependency cost: 16 ms
                                       Check approval cost: 0 ms
                                       Evaluation cost: 3016 ms
                                       Hardlinking evaluation cost: 203 ms
                                       Stage required cost: 62 ms
                                       Flushing and closing files cost: 0 ms
                                       Gap: 47 ms
                                       Machine register cost: 0 ms
                                       Stage user data cost: 0 ms
                                       Registration cost: 0 ms
                                       Repository commit transaction cost: 234 ms
                                       Gap: 47 ms
                                       Data flush cost: 16 ms
                                       Post DeStage repository commit transaction cost: 31 ms
                                       Remaining cost: 0 ms

Expected behavior
After executing an app update with DeferRegistrationWhenPackagesAreInUse = true AND with some DependencyPackageUris added, closing the app and reopening the app, the app opened is updated to the newest version.
Screenshots
No response
NuGet package version
Windows App SDK 1.6.1: 1.6.240923002
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 22H2 (22621, 2022 Update)
IDE
Visual Studio 2022
Additional context
No response

man, how buggy these "Package Management APIs" are! these should be fixed asap.

Microsoft's @DrusTheAxe knows better.

A running package app uses AddPackageAsync with AddPackageOptions.DeferRegistrationWhenPackagesAreInUse=true to auto-update after quit and next run, but (re)Registers the old version instead of the new if any AddPackageOptions.DependencyPackageUris were specified? Now that's interesting.
PackageDeploymentManager passes its parameters down to PackageManager to do the heavy lifting. This appears to be an issue in Windows handling AddPackageOptions .DeferRegistrationWhenPackagesAreInUse=true & 1+ DependencyPackageUris. I have a hunch at the root cause but poking around the implementation hasn't turned up a smoking gun yet. Passing word to @cwruss for further investigation.
Thanks for bringing this to our attention!

https://task.ms/55033078 for link to internal bug tracking this issue


Unable to install awsglue python package

Hi Saumil
I am unable to install awsglue python package in my virtual environment. running the command pip install awsglue is giving below errors:
ERROR: Could not find a version that satisfies the requirement awsglue (from versions: none)
ERROR: No matching distribution found for awsglue

you have to give package using job parameters

closing issue due to inactivity


On-chain payments and addresses should have labels

In the API, it would be useful to have labeling on on-chain transactions and addresses.
For invoices there is a memo field that can be used to keep track of the purpose of payments
For on-chain sends and receives there is no labeling to help describe transactions

[x] Add payment labels

[ ] Add address labels

I've started working on the transactions portion of this. Got me thinking whether we should take advantage of the ability to label transactions when lnd publishes transactions (so, the non user-initiated case).
This would look like a set list of labels (open channel, sweep, close channel) which inform the user what 'type' of transaction this was. Right now, you can figure out what a transaction is by looking at the tx structure (higher skill level) or searching ListChannels/ClosedChannels/ListSweeps (endpoint WIP) for the transaction (higher effort). With these labels, all the lnd published transactions listed in GetTransactions will provide an indication of what they are, which makes it easy for users to then go look up additional information about the tx in the correct place. I think this is a big win, at the minimal cost of a few bytes in walletdb.

There are transaction labels now in LND for channel opens and sweeps. Closing this issue. Can reopen if there are more labeling needs.


Navigation library

Task/Issue URL: https://app.asana.com/0/488551667048375/1204374977096192/f
Description
Implement the navigation library, see asana
task for
more info
Steps to test this PR
NA, nav library not used yet

Current dependencies on/for this PR:

develop

PR #3055   👈

This comment was auto-generated by Graphite.


Problem running docker-compose up

Running   docker-compose up   the following errors occurred:
Gem::RemoteFetcher::UnknownHostError: no such name https://rubygems.org/gems/wkhtmltopdf-binary-<IP_ADDRESS>.gem)

The script continued and then this error occurred:
An error occurred while installing wkhtmltopdf-binary (<IP_ADDRESS>), and Bundler cannot continue.
Make sure that gem install wkhtmltopdf-binary -v '<IP_ADDRESS>' succeeds before bundling.
←[31mERROR←[0m: Service 'rails' failed to build: The command '/bin/sh -c bundle install' returned a non-zero code: 5

Running   gem install wkhtmltopdf-binary -v '<IP_ADDRESS>'   returned:
bash: gem: command not found

Thanks for reporting this Marcy, I've added it to the Docker docs, and hope we see you tomorrow!


fix(logging.py): fix default logging exception capture behavior

default was set to false although it is incorrect

:tada: This PR is included in version 1.46.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Build failure debian stretch pbstream_migrate

Hi,
I've already post an issue in the cartographer_ros repo, before I realise that this repo was the one related to my problem... Sorry for that.
I'm trying to build cartographer package on a debian stretch fresh install and a on ros:melodic-ros-core-stretch docker image. Both are giving me the same error when trying to build cartographer package.
I can't understand what's happening... Can you point me to some hint / ressources to get this build pass ?
Thanks a lot
Here are the installed deb pkg :
apt-get install -qy python-rosinstall python-rosinstall-generator python-wstool build-essential dirmngr
apt-get install -qy gcc g++
apt-get install -qy python-wstool python-rosdep ninja-build
apt-get install -qy ros-melodic-image-geometry ros-melodic-pcl-conversions ros-melodic-tf2-eigen ros-melodic-tf2-sensor-msgs  ros-melodic-joy ros-melodic-tf2-geometry-msgs ros-melodic-move-base-msgs ros-melodic-rotate-recovery ros-melodic-amcl ros-melodic-robot-localization

# Cartographer dependencies
apt-get install -qy libgoogle-glog-dev liblua5.3-dev python3-sphinx  python-cairo ninja-build libceres-dev libprotobuf-dev protobuf-compiler libprotoc-dev cmake g++ git google-mock libboost-all-dev libcairo2-dev libgflags-dev libgoogle-glog-dev liblua5.2-dev libsuitesparse-dev ninja-build
apt-get install -qy clang libcurl4-openssl-dev
apt-get install -qy ros-melodic-teb-local-planner ros-melodic-rgbd-launch
# Map Server dependencies
apt-get install -qy libbullet-dev libsdl1.2-dev libsdl-image1.2-dev

Here is the corresponding output :
<== Finished processing package [2 of 23]: 'ceres-solver'

==> Processing plain cmake package: 'cartographer'
==> Creating build directory: 'build_isolated/cartographer/devel'

==> Building with env: '/builds/pmirabel/catkin_ws/devel_isolated/ceres-solver/env.sh'
==> cmake /builds/pmirabel/catkin_ws/src/pmi_carto/cartographer -DCMAKE_INSTALL_PREFIX=/builds/pmirabel/catkin_ws/devel_isolated/cartographer -G Ninja in '/builds/pmirabel/catkin_ws/build_isolated/cartographer/devel'
-- The C compiler identification is GNU 6.3.0
-- The CXX compiler identification is GNU 6.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Build type: Release
Files /builds/pmirabel/catkin_ws/build_isolated/cartographer/devel/AllFiles.cmake and - differ
-- Found PythonInterp: /usr/bin/python (found version "2.7.13")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found GMock: gmock_main;-lpthread
-- Boost version: 1.62.0
-- Found the following Boost libraries:
--   iostreams
--   regex
-- F[1/384] Running C++ protocol buffer compiler on /builds/pmirabel/catkin_ws/src/pmi_carto/cartographer/cartographer/common/proto/ceres_solver_options.proto
//...//
[70/384] Building CXX object CMakeFiles/cartographer.dir/cartographer/io/internal/in_memory_proto_stream.cc.o
[71/384] Building CXX object CMakeFiles/cartographer.dir/cartographer/io/internal/pbstream_migrate.cc.o
FAILED: CMakeFiles/cartographer.dir/cartographer/io/internal/pbstream_migrate.cc.o
/usr/bin/c++    -isystem /usr/include/eigen3 -isystem /builds/pmirabel/catkin_ws/devel_isolated/ceres-solver/include -isystem /usr/include/lua5.3 -isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/pixman-1 -isystem /usr/include/freetype2 -isystem /usr/include/libpng16 -isystem /usr/local/include -I. -I/builds/pmirabel/catkin_ws/src/pmi_carto/cartographer -O3 -DNDEBUG    -pthread -std=c++11 -fPIC  -Wall -Wpedantic -Werror=format-security -Werror=missing-braces -Werror=reorder -Werror=return-type -Werror=switch -Werror=uninitialized -O3 -DNDEBUG -MD -MT CMakeFiles/cartographer.dir/cartographer/io/internal/pbstream_migrate.cc.o -MF CMakeFiles/cartographer.dir/cartographer/io/internal/pbstream_migrate.cc.o.d -o CMakeFiles/cartographer.dir/cartographer/io/internal/pbstream_migrate.cc.o -c /builds/pmirabel/catkin_ws/src/pmi_carto/cartographer/cartographer/io/internal/pbstream_migrate.cc
/builds/pmirabel/catkin_ws/src/pmi_carto/cartographer/cartographer/io/internal/pbstream_migrate.cc: In function ‘int cartographer::io::pbstream_migrate(int, char**)’:
/builds/pmirabel/catkin_ws/src/pmi_carto/cartographer/cartographer/io/internal/pbstream_migrate.cc:50:76: error: too many arguments to function ‘void cartographer::io::MigrateStreamFormatToVersion1(cartographer::io::ProtoStreamReaderInterface*, cartographer::io::ProtoStreamWriterInterface*)’
                                                   FLAGS_migrate_grid_format);
                                                                            ^
In file included from /builds/pmirabel/catkin_ws/src/pmi_carto/cartographer/cartographer/io/internal/pbstream_migrate.cc:20:0:
/builds/pmirabel/catkin_ws/src/pmi_carto/cartographer/cartographer/io/serialization_format_migration.h:29:6: note: declared here
 void MigrateStreamFormatToVersion1(
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[72/384] Building CXX object CMakeFiles/cartographer.dir/cartographer/io/internal/mapping_state_serialization.cc.o
[73/384] Building CXX object CMakeFiles/cartographer.dir/cartographer/io/internal/pbstream_info.cc.o
ninja: build stopped: subcommand failed.
ound installed version of Eigen: /usr/lib/cmake/eigen3
-- Found required Ceres dependency: Eigen version 3.3.2 in /usr/include/eigen3
-- Found required Ceres dependency: glog
-- Found installed version of gflags: /usr/lib/x86_64-linux-gnu/cmake/gflags
-- Detected broken gflags install in: /usr/lib/x86_64-linux-gnu/cmake/gflags, version: 2.1.2 <= 2.1.2 which defines gflags_LIBRARIES = gflags which is not an imported CMake target, see: https://github.com/gflags/gflags/issues/110.  Attempting to fix by detecting correct gflags target.
-- Found valid gflags target: gflags-shared, updating gflags_LIBRARIES.
-- Detected gflags version: 2.1.2
-- Found required Ceres dependency: gflags
-- Found Ceres version: 1.13.0 installed in: /builds/pmirabel/catkin_ws/devel_isolated/ceres-solver with components: [LAPACK, SuiteSparse, SparseLinearAlgebraLibrary, CXSparse, SchurSpecializations, OpenMP]
-- Found Lua: /usr/lib/x86_64-linux-gnu/liblua5.3.so;/usr/lib/x86_64-linux-gnu/libm.so (found version "5.3.3")
-- Found Protobuf: /usr/local/lib/libprotobuf.a;-lpthread (found suitable version "3.4.0", minimum required is "3.0.0")
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29")
-- Checking for one of the modules 'cairo>=1.12.16'
-- Found Sphinx: /usr/bin/sphinx-build
-- Configuring done
-- Generating done
-- Build files have been written to: /builds/pmirabel/catkin_ws/build_isolated/cartographer/devel
==> ninja -j 3 in '/builds/pmirabel/catkin_ws/build_isolated/cartographer/devel'
<== Failed to process package 'cartographer':
  Command '['/builds/pmirabel/catkin_ws/devel_isolated/ceres-solver/env.sh', 'ninja', '-j', '3']' returned non-zero exit status 1

Reproduce this error by running:
==> cd /builds/pmirabel/catkin_ws/build_isolated/cartographer && /builds/pmirabel/catkin_ws/devel_isolated/ceres-solver/env.sh ninja -j 3

Command failed, exiting.

Some additional informations :
Debian GNU/Linux 9.9 (stretch)
gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
CXXFLAGS =
cmake version 3.7.2
ROS_DISTRO = melodic

Fresh install  of last version of cartographer solved this ... Sorry for the flood !


alt descryption for Image and icon elements

AS A marketing agency
I WANT a codebase that follows accessibility standards
SO THAT our own site is optimized for search engines
Acceptance Criteria 3: Image and icon elements contain accessible alt attributes

alt elements added


Why not have the NSwag studio as an extension to VS

It should be a lot easier if it's part of Visual Studio as a VSIX.
The entire generation process could be automated easily.
It could be integrated with the project/solution settings in Visual Studio.
Defaults configuration can be set right from VS' options.

There are currently no plans for a Visual Studio extension. First it is a big pain to build VS extensions (compared to a simple WPF UI) and second I just don't have the time to also support a VS extension without being paid for it... :-)

An extension is plain WPF...
But I feel you! And thanks for your time and effort for everything you achieved so far it's great!

True, but if we build a VS extension then it should bring more feature than just the standalone NSwagStudio application. For example it should integrate in the project system, so that you can add NSwag to an existing Web API project, or provide context menu on the client project to regenerate the code... maybe we also need project templates for better and simpler integration.

Maybe an extension with the binary and context menu to create and run an nswag.json file?

Yes. That would be a great starting point indeed.


Fix readme for shimmer

I modified some things in the readme for the shimmer app. Feel free to merge or close the PR.

Renamed message to block according to the new naming conventions
Renamed coins to funds
Changed some forgotten Mi to SMR
Updated outdated links to the Ledger documentation

If you merge this PR I can also update the readme file for the IOTA Ledger app.

@MiKeF05 Thank you very much! :hugs:


Angular [conroller] causes console error

Demo with this console error
https://stackblitz.com/edit/swiper-angular-controller?file=src%2Fapp%2Fapp.component.ts

I have 2 sliders, they controll each other.
There are a lot of swiper sliders on pages. But this error present only on pages with [conroller] sliders.
Also screenshot of code.

Important, that I was testing - create copy of simble slider, gave them [conroller] for each other and the same error appear.

Here you can see demo with this console error
https://stackblitz.com/edit/swiper-angular-controller?file=src%2Fapp%2Fapp.component.ts

@StasSpawn
https://stackblitz.com/edit/swiper-angular-controller-vevmx8
does this solve ur issue

@bitrxjs
Unfortunately, no.

I've paste this code, add req imports, but error still present.

@StasSpawn
stackblitz link works fine.
please share template code also

@bitrxjs
Hello. I see, that in your example sliders are not cotrolled by each other. They switching separately from each other.
https://stackblitz.com/edit/swiper-angular-controller-vevmx8

@bitrxjs
Also, error really dissapeared, when I add corrent code to my site. BUT, both sliders has to switch each other. With your code only one slider switch another.

@StasSpawn
try this
https://stackblitz.com/edit/swiper-angular-controller-vevmx8

@StasSpawn
is this what u want
https://stackblitz.com/edit/swiper-angular-controller-qqjhtv

@bitrxjs Yes, this work poerfectly.
So, is this some bug of slider library, or it's how it suppose to work?

@StasSpawn
No bug
The angular wrapper have some issue related to updating controller
So i just used the swiperRef instance and called methods on it directly bypassing the angular wrapper.

@nolimits4web pls close this one

@bitrxjs
Hello. This fix is working, but I haму a third slider in this scheme. Is ther a possibility to add 3 slider and make them all synchronized?
I've tried this code, but it couses error: Uncaught RangeError: Maximum call stack size exceeded
@ViewChild('firstSlider') firstSlider?: SwiperComponent;
  @ViewChild('secondSlider') secondSlider?: SwiperComponent;
  @ViewChild('thirdSlider') thirdSlider?: SwiperComponent;

  ngAfterViewInit() {
    if (this.secondSlider?.swiperRef && this.firstSlider && this.thirdSlider) {
      this.firstSlider.swiperRef.controller.control = [this.secondSlider.swiperRef, this.thirdSlider.swiperRef];
      this.firstSlider.swiperRef.update();

      this.secondSlider.swiperRef.controller.control = [this.firstSlider.swiperRef, this.thirdSlider.swiperRef];
      this.secondSlider.swiperRef.update();

      this.thirdSlider.swiperRef.controller.control = [this.firstSlider.swiperRef, this.secondSlider.swiperRef];
      this.thirdSlider.swiperRef.update();
      ////// END Fix for slider with controller
    }
  }

@bitrxjs Hello. There another bug. I'm not sure is it related to that feature or not.
With loop we must use loopedSlides. But if some data.length there it causes error.

This condition isn't helps.

If I add *ngIf="slidesData" to parent html block - control just not working.
So, basically I need fix error and keep slider control.

@bitrxjs still need help with this :(


Add ESLint rule for "import/no-cycle" with maxDepth option

adds eslint rule to error on dependency cycles.

inspired by https://github.com/breadboard-ai/breadboard/issues/941

Looks like we might have to fix the cycles to get this passing... :D

working on it


Add support for AWS Batch

Includes a minor tweak to rest_json codegen to skip an import for this service, to avoid compiler warnings about unused code.

I'm going to merge this as-is since it's been approved, and open up an issue for a wider discussion of "how do we want to handle service-specific customizations to the codegen?" because there's definitely a need for them.


[FLINK-25676][python] Support set_description in DataStream API

What is the purpose of the change
This pull request add support of set_description in DataStream API
Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: ( no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not documented)

@HuangXingBo Thanks for the review. Will address the comments during merging the PR.


Is there a escape character for the space when I create a file by the shortcuts ma and input the filename?

Environment

Operating System: Debian 8
Vim version :version: 8.1.178
NERDTree version git rev-parse --short HEAD: d6032c8
NERDTree settings applied in your vimrc, if any:
let NERDTreeIgnore = ['.pyc$[[file]]', '.o$[[file]]', '.pro.user$[[file]]']

Process
Normally create a file or directroy by the shortcuts ma provided by the NerdTree.
Current Result
If I input  a filename and end up with spaces, the filename which just created were really end of spaces, the same as the input. It may cause some unexpected faults in programming.
Expected Result
I expect that it can detect the input firstly,  and then ignore the spaces at end of the input before create a file. If the end space were wanted , please add a escape character for it.

If you don't want spaces to be in your filename, just don't type them. NERDTree will take the text you enter to be the exact filename it creates.


Highlight exception variables.

Example
begin
  doSomething()
rescue => ex # Highlight "ex" by this patch.
end

test ruby file https://gist.github.com/pocke/a8354638abf39c73dd76

Thanks!!!!!


Problem Selecting Objects.

Hello, I am new to DSMapStudio but have watched a few videos on how to use it. The first thing is when I select objects they aren't highlighted with an orange outline like I see in every video I have watched. So already off to a great start... The option to even move the objects isn't available except for on Pots and Trees. That is it. And even these are not highlighted. Even bushes and gravestones cannot be highlighted or moved. Yes I meet all the requirements and I also tried reinstalling Microsoft Visual C++ 2015-2019. I'm on Windows 11 64-bit. CPU is AMD Ryzen 9 7945HX and GPU is a RTX 4060. With 16GB of installed RAM. I am trying to use DSMapStudio to mod Dark Souls Remastered. Thank you for your time and I hope that we can get this sorted. Have a good day.

Ah, looks like when we added a toggle for the selection outline (since it gets buggy with large selections) it was set to default as off. Should be in settings to re-enable that.
As for DSR, you may find that for most non-object and non-enemy things in the map, they're actually positioned at 0,0,0 and any "location" they have is a facet of the model, making the usual transform ui elements difficult to see.

I actually just figured out how to enable the outline mode! Thanks for the reply. I still have a question though. Is the only way to move an object like the graves outside of Fire Link by manually typing in the new position? Can you not move them via click and drag with the mouse? Or in another way that is faster and less trial and error then putting in random numbers? Like for Pots I can drag them any way I want. Can I do this for the graves and objects like the graves? Sorry for all the questions. I am learning. :P Thanks!

It'll depend on if they're part of the map geometry or are an individual object. They may be all part of the same map piece even.
Since there's no technical issues remaining (other than a reminder to change default outline setting and look into modifying where the transform ui element appears) I'm going to close the issue.
For better help getting use to using the tool and other modding questions, I recommend joining the ?servername? discord, linked in-program.


Temperature module isn't working

I got no reading some time on disply and thingspeak

temperature module has been changed no it is working fine.


Web Audio Api in options.media.render.remote

Hi contributors!
Is there is a way to directly use Web Audio Api in options.media.render.remote?
Thanks and best regards,
Petr

Potentially, if you provide your UA with a mediaHandlerFactory that returns MediaHandlers whose render method uses AudioContext.createMediaStreamSource (see the example code) to connect the remote stream's audio to the Web Audio graph (this probably won't work in Chrome).


Add progress information to console_progress_indicator

This PR adds progress information (current/total and percent) to console_progress_indicator.
Before it used to look like this:
Time remaining: 12 seconds.

But now it looks like this
Progress: 2172/5000 (43.44%). Time remaining: 12 seconds.

I've found myself adding this extra information many times in my code: most of the time, I want to know the actual number of elements completed out of the total, and the actual progress.
If you don't think this is useful, either close this PR, or tell me to add an extra display_percent parameter to the function.

Cool, works for me :)


fix courses migration conflict

What are the relevant tickets?

https://github.com/mitodl/mitxonline/pull/1651
https://github.com/mitodl/mitxonline/pull/1687
Description (What does it do?)

Fixes course migrations conflict on the main branch
Static file directory was missing: /home/runner/work/mitxonline/mitxonline/frontend/public/build Static file directory was missing: /home/runner/work/mitxonline/mitxonline/frontend/staff-dashboard/build CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0031_backfill_enrollments_from_certificates, 0031_populate_letter_grades, 0032_add_related_programs_table in courses). To fix them run 'python manage.py makemigrations --merge'
How can this be tested?

Run migrations from 0030
manage.py migrate --fake courses 0029 (run this if you have already applied 0030_remove_course_position_in_program.py)
manage.py migrate courses 0030

Does the conversion algorithm in convert_to_letter() apply to all courses or just courses in this specific DEDP program?

Does the conversion algorithm in convert_to_letter() apply to all courses or just courses in this specific DEDP program?

It should only apply to courses (before 3T2022) in the existing DEDP program. The original PR https://github.com/mitodl/mitxonline/pull/1651 doesn't specify that in the description, but its indicated in https://github.com/mitodl/mitxonline/issues/1647#issuecomment-1582499637 and we don't change letter grade for any other courses

Does the conversion algorithm in convert_to_letter() apply to all courses or just courses in this specific DEDP program?

It should only apply to courses (before 3T2022) in the existing DEDP program. The original PR #1651 doesn't specify that in the description, but its indicated in #1647 (comment) and we don't change letter grade for any other courses

I would consider whether that function will ever be reused and therefore added as a utility.  If it's likely to be reused, I think we should very clearly indicate that it will only apply to courses in that DEDP program which were before 3T2022.

convert_to_letter is added to utils.py @annagav should have more context on this since I am not the one who created that PR. This is to address the merge conflict for migration, but I am happy to address other feedback you might have for https://github.com/mitodl/mitxonline/pull/1651

addressed above comments in https://github.com/mitodl/mitxonline/pull/1704/commits/3f4de4b159008add2abb47997397cd76d07fe799


Reference to local file in configuration

In https://github.com/onfleet/ruby-onfleet/blob/main/lib/configuration.rb#L8 there is a reference to @danmenza 's local machine project root. That gives this obvious error when attempted to be used on any other system:
gems/ruby-onfleet-1.0.2/lib/configuration.rb:8:in `read': No such file or directory @ rb_sysopen - /Users/danmenza/onfleet/code/api_wrappers/ruby-onfleet/package.json (Errno::ENOENT)

The correct line there would probably be:
file = File.read(File.expand_path("../../package.json", __FILE__))


function "tu_fifo_peek_at_n" return vlaue incompatible (IDFGH-6508)

Environment

IDF version:
v4.4-beta1

Problem Description
it returned a bool value instead of the data length
Code to reproduce this issue
/******************************************************************************/
/*!
    @brief Read n items without removing it from the FIFO
    This function checks for an overflow and corrects read pointer if required.

    @param[in]  f
                Pointer to the FIFO buffer to manipulate
    @param[in]  offset
                Position to read from in the FIFO buffer with respect to read pointer
    @param[in]  p_buffer
                Pointer to the place holder for data read from the buffer
    @param[in]  n
                Number of items to peek

    @returns Number of bytes written to p_buffer
 */
/******************************************************************************/
uint16_t tu_fifo_peek_at_n(tu_fifo_t* f, uint16_t offset, void * p_buffer, uint16_t n)
{
  _ff_lock(f->mutex_rd);
  bool ret = _tu_fifo_peek_at_n(f, offset, p_buffer, n, f->wr_idx, f->rd_idx, TU_FIFO_COPY_INC);
  _ff_unlock(f->mutex_rd);
  return ret;
}

Just checked, indeed an issue in Espressif's TinyUSB fork here: https://github.com/espressif/tinyusb/blob/075334af80303488a8c874255d725cb4ca15a7de/src/common/tusb_fifo.c#L486
@dreamtrek we will fix it and keep you updated

@dreamtrek,
The fix was merged in commit 6ddf2ea05eaeb7ffb9ea50414b2b7986a4fa8bdd. Will be synchronized with github soon.

Thanks for reporting, feel free to reopen.


Fake diagnostics for simulation

includes #615
requires #https://github.com/ipa320/cob_command_tools/pull/178

I removed the commits related to #615 as my proposed solution does not work :wink:


Minor changes and fixes for new test suite

This is just a heap of commits adjusting the new test suite a little. Not sure if this can be merged completely, will probably refine and cherry-pick commits one by one.
So far I like the new test suite a lot. Implementing it using busted allows us to later improve it further:

Make it Windows-compatible
Try to reduce output noise for successful tests. Typically in busted specs tests don't output anything at all if they pass. On failure, assertion that failed should provide enough information for debugging. This is definitely not true for assert.is_true and assert.is_false assertions that are used when checking command success and failure (it just prints: expected true, got false). If we'll go this way we'll need custom assertions that execute command and print it and its output on unexpected result. A collections of such assertions would be valuable for testing other command-line programs, might want to make that a library.

Wow, thanks Peter! That's a thorough review! I'm glad you like the new test suite, @robooo has been putting a lot of work on it (and it's awesome that we already got it to a mergeable state and he's still basically halfway through his GSoC!)
If both you and @robooo are fine with all these changes, I think they are good to merge.


Ignore non-RF actions

Fixes #2790.

Codecov Report

Merging #2796 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2796   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1391    1394    +3
======================================
+ Hits         1391    1394    +3

Impacted Files
Coverage Δ

src/actionTypes.js
100% <100%> (ø)
:arrow_up:

src/reducer.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ea725...996dad6. Read the comment docs.


lint meta images

fixes: #2694
Add linting to meta images to ensure only png files.
this is working, I just need to fix up these files before i merge
https://github.com/pulumi/pulumi-hugo/actions/runs/4835610804/jobs/8618067274

I am in the process of converting all the existing meta images that are not pngs to pngs in order to get the linter rule added here to pass. I noticed quite a few of the failures are due to gifs being used as a meta image. I can't convert a gif to a regular image file. Should I just add an exception to the linter to ignore gif files used for meta images for now?
@susanev @cnunciato @zchase

@sean1588 want me to deal with the image conversions? i don't mind! let me take a look at when gifs were added.

planning to merge end of day, may 1st, after folks update any meta images they would like to update.


Twitter does not accept anymore callbacks with a query string

You can see I've added two callback URLS, and the one with the query string is considered invalid.
Any workaround?

I think it's safe to say the developer has abandoned this plugin and it will need to be forked in order to continue accommodating Twitter.

If you leave the query string off the end, it will still work.

If you leave the query string off the end, it will still work.

 I just tested it again and it worked.

as soon as I put a "=" the url becomes invalid

@cesare190 :

what's the exact url that you're entering?
does the error remain if you add value after =?
what's the twitter settings page exact url where you're adding this value?

as soon as I put a "=" the url becomes invalid

You don't need it. Just use https://mywebsite.com/wp-content/plugins/wordpress-social-login/hybridauth/


The swarm node disappeared after  node successfully has joined a few minutes

The node disappeared after  node successfully has joined a few minutes.
$ sudo docker --version
Docker version 17.09.0-ce, build afdb6d4
At the worker node ,  sudo docker swarm join .   I could see the node ready at the manager node  with the command "sudo docker node ls ".  But after one minute,  the node disappeared.  BTW,   The manager and the worker node are not in the same Ethernet Subnet, They could be connected with each other.

i got the same problem, any idea?
tail /var/log/syslog
Dec  5 14:15:08 gcsvr03 dockerd[32193]: time="2017-12-05T14:15:08.068140152+08:00" level=error msg="agent: session failed" error="rpc error: code = 7 desc = Permission denied: unauthorized peer role: rpc error: code = PermissionDenied desc = Permission denied: node 44whub2gp4vhkmf5vyuuh571y was removed from swarm" module="node/agent"
Dec  5 14:15:14 gcsvr03 dockerd[32193]: time="2017-12-05T14:15:14.375344762+08:00" level=error msg="agent: session failed" error="rpc error: code = 7 desc = Permission denied: unauthorized peer role: rpc error: code = PermissionDenied desc = Permission denied: node 44whub2gp4vhkmf5vyuuh571y was removed from swarm" module="node/agent"
Dec  5 14:15:16 gcsvr03 dockerd[32193]: time="2017-12-05T14:15:16.939711544+08:00" level=error msg="agent: session failed" error="rpc error: code = 7 desc = Permission denied: unauthorized peer role: rpc error: code = PermissionDenied desc = Permission denied: node 44whub2gp4vhkmf5vyuuh571y was removed from swarm" module="node/agent"

@lh83mail   Refered to your logs ,  this may be a permission problems.  However I don't know why    docker engine told me "already joined" when I try to re-join swarm node.  That means the node was not removed actually ?

@lh83mail please open this issue on https://www.github.com/docker/swarmkit. Sorry for the trouble.


⚠ Samsung has degraded performance

In 8277374, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2868 ms

Resolved: Samsung performance has improved in 6d29433.


Add responseFromCache metadata to DataSourceFetchResult

Hello,
I tried to use the 6.4.0 version's responseFromCache metadata, in a customised solution where our approach is basically

  override async fetch<TResult>(path: string, request: DataSourceRequest = {}) {
    // Create messageId that will be used during the whole request lifecycle
    const messageId = this.getAzureMessageId();

    // Attach messageId to the request headers. Include other headers from client's request.
    request.headers = {
      ...request.headers,
      'x-message-id': messageId,
    };

    // Execute the request
    const result: DataSourceFetchResult<TResult> = await this.semaphore.withLock(() => super.fetch(path, request));

    // Only log request and response for no-depduplicated, successful requests
    if (!result.requestDeduplication.deduplicatedAgainstPreviousRequest) {
      this.logRequest(request as ApolloRequestOptions, path).finally();
      this.logResponse(request as ApolloRequestOptions, result).finally();
    }

    return result;
  }

In this implementation it would be required that I actually get this meta data part of DataSourceFetchResult -- So this can be sent to our logging platform correctly.
@smyrick Have I understood something wrong in this, and is there way for me to use your implementation here without these changes?

@Rikusor Yep, good catch. I didn't propagate the value all the way up. To validate I added more tests and implemented the same here: https://github.com/apollographql/datasource-rest/pull/381
You can either add those to your PR if you want or we can close and merge

Thanks @smyrick  will close this PR.


Upgrade from deb_1.48.2-1598353430 to apt_1.49.0-1599744551 does not install dependency libgbm

VSCode Version: 1.48.2-1598353430 -> 1.49.0-1599744551
OS Version: Ubuntu 20.04.1 LTS

Steps to Reproduce:

libgbm-dev not installed
Download and install code_1.48.2-1598353430_amd64.deb --> VSCode works
Do apt update; apt-upgrade VSCode to 1.49.0-1599744551 --> VSCode fails with:
/usr/share/code/bin/../code: error while loading shared libraries: libgbm.so.1: cannot open shared object file: No such file or directory
apt install libgbm-dev --> VSCode works

Expected:
upgrade checks for dependency and installs missing library

@deepak1556 new Electron 9 dep needs to be declared here?
https://github.com/microsoft/vscode/blob/master/resources/linux/rpm/dependencies.json
https://github.com/microsoft/vscode/blob/92a30ed2650c31839a453bb088be9a4e7935a393/resources/linux/debian/control.template#L4

I didn't know about this dependency configuration in the codebase, yes adding libgbm1 should be sufficient. It is a new dependency for chromium 83 to use memory buffers in gpu code path.

Tested this by upgrading from 1.48.2 to 1.50.1


JAX 0.3.5 stalls on TPU Pods

This tutorial does not work when using the latest jax version 0.3.5. Specifically, code will hang whenever jax.device_count() or jax.local_device_count() is called.
The code prints the following and then stalls.
>>> import jax
>>> jax.local_device_count()
E0410 21:04:57.403257842   30715 f758.cc:310]                no server name supplied in dns URI
E0410 21:04:57.403295131   30715 f872.cc:77]                 channel stack builder failed: {"created":"@1649624697.403284903","description":"the target uri is not valid: dns:","file":"f814.cc","file_line":1090}

This issue does not happen if I install 0.3.4, or run the same code (with 0.3.5) on a non-pod instance like v2-8.

Can you please verify you have the same libtpu_nightly and jaxlib versions installed on all VMs in the TPU pod?

Yes, all VMs have jaxlib==0.3.5 and libtpu-nightly==0.1.dev20220407

No updates yet, but we can reproduce the problem and are looking into it.

We just released jax 0.3.6 with a new libtpu to fix this issue. Please upgrade to jax 0.3.6!


Suggestion: Config option to change the speed of hammers

I also updated all the material speeds to reflect their true mining speeds (previously, it was speed / 3.5f)

Would it be possible to add a config option to change the multiplier on the mining speed for hammers?
Bonus: What about including a config option for the speed multiplier for Curse of Gigantism (default 0.2f)?

Next update will have a universal speed config option (breakSpeedMultiplier); 0.5 would be 50% speed, and 1.0 (default) is normal speed.
Curse of Gigantism is now in Magna, so I'm moving the issue here.


Select with icons + text

Issue description:
Hello,
I have to create a select with icons + text, such as fontawesome field.
Looking and thinking I found the solution visible in the code section.
Do you confirm that it is really the only solution at the moment?
Because this solition has a small problem, as you can see from the images

In short, the html code to display the icon is also included in the title attribute
A future solution to implement, could be to insert an array to specify:

The main text.
The text before and the text after the text of point 1.

Example:
'choices' => array(
            'fa-user'  =>  array(
                           'before'=> '',
                           'text'=> esc_attr__( 'User', 'test' ),
                           'after'=> 'to select'
              ),
)

Result:

       User to select

Version used:
3.0.25
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
Kirki::add_field( 'theme_config_id', array(
	'type'        => 'select',
        'settings'    => 'font5_test_setting',
        'label'       => esc_attr__( 'Font5', 'test' ),
        'description' => esc_attr__( 'Font5.', 'test' ),
        'section'     => 'test_section',
        'default'     => 'fa-address-book',
        'choices'     => array(
            'fa-address-book'   =>  esc_attr__( ' Address Book', 'quick' ),
            'fa-anchor'         =>  esc_attr__( ' Anchor', 'test' ),
            'fa-user'           =>  esc_attr__( ' User', 'test' ),
            'fa-balance-scale'  =>  esc_attr__( ' Balance Scale', 'test' ),
            'fa-bath'           =>  esc_attr__( ' Bath', 'test' ),
        )
) );

Instead of this:
esc_attr__( ' Address Book', 'quick' ),

try this:
sprintf( esc_attr__( '%s Address Book', 'quick' ), '' )

By adding the icon inside the esc_attr__ function you're stripping it and it doesn't show. Moving it out of the function should fix the issue for you - and at the same time make traslations a lot easier since translators won't have to include the icon markup in the translations.

I'm sorry to tell you, but your solution does not work. Doing so does not display icons in the select.
Maybe I'm wrong?

Done. No changes.
Strange. In theory it should work even if I write directly:
'fa-address-book'`   => ' Address Book'

But even so it does not work.

Hello, any news about this little problem?

I am also curious about this. I'd like to be able to filter the fontawesome list to only few choices (for example social media icons), and add custom labels to it.
Is this something you would consider for one of future releases?

This is still a problem. I tried to use with radio control instead, but without success either...
Any idea how can we achieve this? The client saw the Fontawesome field and said "I want the same but with my icons instead"... And I dunno what to do... :(

If I'm not mistaken this works in v4.0-beta.
If you want you can try using the develop branch

Hello and thank you for reporting this issue.
We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.
If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.
Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.
Thank you for your understanding.
Best,
David


Teamwork

Hey there! It looks like you and https://github.com/Zooz/express-ajv-swagger-validation are working on the same thing. Maybe you folks could join forces and share the load.

@philsturgeon , thx for that link. I was looking for a way to add custom keywords (which can be done with AJV and is encouraged by JSON Schema), but it can't be done with this package without any major hacking. The linked package does have support to give all custom keywords needed.

@dietergeerts great insight! I bet the folks over on that other package haven't ever needed to get custom keywords involved, so I bet they'd be very interested to hear your use case. If this is on the only blocker to letting these packages merge then that's excellent news.
Maybe you could start up an issue to see if they'd be open to a PR covering this?

@philsturgeon https://github.com/PayU/openapi-validator-middleware/blob/22b02fa6bb549a69b9c55719bbdf748debd8fb81/test/express/test-server-keywords.js is this the kind of custom keywords support that you are talking about?

@kibertoad I'm talking about whatever type of custom keywords @dietergeerts is talking about. :)

@philsturgeon , I'm talking about keywords for custom validation. It's one of the options of the package: https://github.com/PayU/openapi-validator-middleware#options. And we need it in our project to add some custom validation to our models. We currently use this package, where this is not possible. So we'll have to use the other package now. I did not check out yet what other difference there are though, so don't know if we'll be missing other things.

@dietergeerts yes I thought this is what you meant, I was confused about why @kibertoad toad was asking me.
I am also a bit confused about the rest of this conversation. I am suggesting the authors of these two packages collaborate, but you are a user of one package pointing out there is something stopping you from using the other package?
You could either send a PR to the package missing the thing you want if you'd like to use it, or you could... not and continue using the package you are using. Sorry but I don't understand what is being discussed.


react-measure as hook

Hi y'all,
have you already thought about offering react-measure as a hook? I played a little bit with this idea and created a working proof of concept (see here: https://github.com/thomaskempel/use-resize-observer)
I copied some stuff from this repo and tried to offer similar interfaces. How do you like the idea?
Cheers,
Thomas

Thank you for the proposal @thomaskempel! I recently did some explorations that are more of what I was trying to do in #97. It essentially splits out responsibilities for each phase of collecting measurements for flexibility. As of right now, I'm thinking of shipping a couple of different hook implementations that can be composed together in a useMeasure hook as seen in this codesandbox. My schedule has been a little hectic lately, but I'll put together a PR soon for feedback!

It would be great to have this feature, is it still relevant?..


🚀 Feature: lifecycle state for Templates

🔖 Feature description
Currently, kind: Template does not allow for a field to define what stage of development the template is in.
🎤 Context
We would like for certain templates to only be available to e.g. beta testers.
        <ScaffolderPage
          templateFilter={template => {
            const featureFlagsApi = useApi(featureFlagsApiRef);
            const isFeatureFlagToggled = featureFlagsApi.isActive('enable-beta-templates');
            const isProd = template.SOME_PROPERTY && template.SOME_PROPERTY === 'production';
            return isFeatureFlagToggled || isProd;
          }}
        />

We could (mis-)use an existing field like metadata.tags or metadata.annotations, but that does not feel right (and in case of tags bleeds through to the UI layer easily.
✌ Possible Implementation
Use spec.lifecycle, like in other entity kinds.
Not sure whether it would be enough to add the field to plugins/scaffolder-common/src/TemplateEntityV1beta3.ts?
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Yeah, I think there's also some types in the  scaffolder-common too https://github.com/backstage/backstage/blob/88746203aa6c7b171d381896bc07d77b11d44b1e/plugins/scaffolder-common/src/TemplateEntityV1beta3.ts#L31


Upgrade elasticsearch to 6.X

For next minor version (1.2) we should have updated ES to 6.x
In order to do that we should test that it still works and update the manifests and configurations

EKS seems to cause problems with Elasticsearch 6.x. I've seen the following warning:
ERROR: [1] bootstrap checks failed
[1]: max file descriptors [8192] for elasticsearch process is too low, increase to at least [65536]

Reference: https://github.com/pires/kubernetes-elasticsearch-cluster/issues/215

@falfaro can you open a specific issue for that, please?

Closing this in favour or: https://github.com/bitnami/kube-prod-runtime/issues/427


Dot notation in state name not working

Hi,
With the following config, state restaurants.restaurant doesn't work, attempting to access /restaurants/something simply falls back to /restaurants each time. Only if I comment out the .otherwise or change restaurants.restaurant to restaurants_restaurant or anything else as long as it doesn't contain a dot, does it work.
As far as I'm aware from documentation I've read, dot notation is certainly supported. Am I missing something? Perhaps it doesn't work with html5Mode or something?

App
    .config(
        ['$locationProvider', '$stateProvider', '$urlRouterProvider',
            function( $locationProvider, $stateProvider, $urlRouterProvider ) {
                $locationProvider.html5Mode(true);
                $urlRouterProvider.otherwise('restaurants');
                $stateProvider
                    .state('restaurants', {
                        url: '/restaurants',
                        templateUrl: '/app/venues/index.html',
                        controller: 'venueIndexController'
                    })
                    .state('restaurants.restaurant', {
                        url: '/restaurants/{restaurant}',
                        templateUrl: '/app/venues/show.html',
                        controller: 'venueShowController'
                    });
            }
        ]
    );

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


Pass all references from MSBuild

Motivation
The approach to control framework reference resolution from an MSBuild
project is a bit hacky. Instead, we can take advantage of the entire
NuGet assembly resolution infrastructure from MSBuild.
Modifications
Drop the ResolvedFrameworkReference forwarding and instead forward
ReferencePathWithRefAssemblies from MSBuild to Yardarm as the entire
list of assemblies to be referenced.
Remove all special logic for working with non-csproj projects from the
SDK. Since we're really C# specific on the generation side, let's own
that and expect C# behaviors from MSBuild.
Results
All of the cost of dealing with NuGet is completely avoided during
the generate step, as well as any "hackiness" involved, instead
getting the list from MSBuild just like a normal C# compilation.

/merge


Metrics API not working for OpenAI deployments

Describe the bug
sdk/monitor/azure-monitor-query/samples/async_samples/sample_metrics_query_async.py
--- Example given in above sample python script doesn't work with OpenAI deployments
To Reproduce
Run the sample script for OpenAI deployments
Expected behavior
OpenAI deployment related metrics should be populated (like token counts etc.)

@chintanckg can you share the the package version and example code the reproduces the issue? The sample you linked to doesn't target any metrics for Azure OpenAI (see here for supported metrics: https://learn.microsoft.com/azure/azure-monitor/reference/supported-metrics/microsoft-cognitiveservices-accounts-metrics)


Add parsers

Writing regex can be hard, so I suggest to add parsers into linthell which can parse default formats of popular linters. Using regex must be available too for unsupported linters and custom linter formats

If parsers will be created as plugins, it would be useful: https://setuptools.pypa.io/en/latest/userguide/entry_point.html


set up circle ci for elm test

running npm test on circle ci is mega slow (build time becomes ~20mins)
could be worth adapting this script workaround to cache the elm-test directory
https://gist.github.com/bkuhlmann/765abad66f918dac14eb49ea5f48b014

resolved with pr #63


Add a FeatureToggle bootstrapper.

Since our normal backup file location must be writable since we write back.
This adds support for reading toggles from a place where Unleash does not have write access.
First implementation only adds support for accepting absolute paths to filesystem, but the interface should be extensible enough so we can add s3 or cloud-storage support, though we probably want to keep that out of client-core, to avoid dragging in aws or google dependencies
fixes: #129

It would be nice if the default absolute filesystem path could also support resources on the classpath. That way a resource that was compiled into a 'fat jar' would also be easily usable.

Good point, I'll add support for classpath: resources with this.
I do seem to remember that fat jar resources came with some extra configuration issues since the embedded file most likely is zipped inside a jar. I'll start by making sure we can find resources from classpath.

we can add s3 or cloud-storage support, though we probably want to keep that out of client-core, to avoid dragging in aws or google dependencies

I was thinking it might be enough to support fetching a json file from a URL, maybe with some authentication as part of that.
Maybe you should be allowed to just push in an input stream? Then you can fetch it however you like, and you can just pass on the input stream as part of the configuration? Or would it be better to then say it must be a json string?

I think you're right. We should probably simplify the BootstrapHandler to accept a string which it parses to a set of toggles. Then it would be up to the user to figure out how they want to provide the String. Seeing as how the current FileHandler only uses Java core APIs providing it could be a starter for how to write a ToggleBootstrapHandler. I'll have a look at changing the API a bit

I really like the inversion of control where the user now can just specify a string producer. This means the user can read their warmup state from anywhere (url, redis, S3, memcached, etc) without injecting support for everything in to the SDK.
Would be nice to see a Howto guide at some point where you curate a hot file in a S3 bucket and read it at startup.

I can look into adding a how-to for that


哪个版本可以支持REST服务的接口

如题

I want to know when REST is OK?

We are reviewing the code, we plan to release this part in the next few days.


Pushes not visible in feeds

Updates sent in using butler seem to show up rarely in both the Global feed and My own activity as opposed to updates uploaded through the edit page.

...unless you edit your latest activity after a butler push. Then the update time is reset to now it seems, still without being visible in Global feed? Something seems not quite right between butler and feeds.

tagging @leafo since this is a site issue


Resolve additional database column types

I have recently started using this package and ran into a problem similar to https://github.com/romanzipp/Laravel-Model-Doc/pull/16. After some searching I've found that Laravel has an integrated solution - you just have to add custom casts in database.php config file. Here's an example: https://laravel.com/docs/10.x/migrations#modifying-columns-on-sqlite
Adding casts there will work application-wide. So, this package would only need short documentation and maybe better error message showing which type is not defined.
Thanks for this package!

Could you share and example which column was mapped to a certain type?

I'm using SQL Server in my setup. I believe it should look something like this in database.php:
'dbal' => [
    'types' => [
        // exists in MySQL / MariaDB / SQLite
        'enum' => \Doctrine\DBAL\Types\TextType::class,
        'timestamp' => \Illuminate\Database\DBAL\TimestampType::class, // documented by Laravel

        // SQL Server specific types
        'xml' => \Doctrine\DBAL\Types\TextType::class,
        'hierarchyid' => \Doctrine\DBAL\Types\BinaryType::class,

        // works with user-defined types
        'my_custom_type' => \Doctrine\DBAL\Types\TextType::class
    ],
],


Support for PictureBox

Would be nice to have support for picturebox, and the ability to retrieve the image.

Well, I found that I can just get it as a automationelement, then use capture and that seems to work.


Maximum width of GSCID and PSCID

The architecture presently requires support for 16 bit GSCID and 20 bit PSCID.
In smaller implementation it may be desirable to support a less wider GSCID and PSCID.
Proposed update to the text:
The number of implemented bits of GSCID width, termed GSCIDLEN,
must be 8 bits if the maximum supported device_id width is less than or
equal to 8 bits; else it must be 16 bits.
When GSCIDLEN is 8 bits, Bits 15:8 of GSCID in fields of in-memory
data structures and in register fields must be set to 0 by software. If not set to 0
then the implementation may either ignore the bits 15:8 or use all or parts
it as GSCID.
The number of implemented bits of PSCID width, termed PSCIDLEN,
must be 20 bits if the supported process_id width is greater than 8-bits.
When the supported process_id width is less than or equal to 8-bits, the
PSCIDLEN must be the same as GSCIDLEN.
When PSCIDLEN is not 20 bits, Bits 19:PSCIDLEN in fields of in-memory
data structures and in register field must be set to 0 by software.  If not set to 0
then the implementation may either ignore the bits 19:PSCIDLEN or use all or
parts of it as PSCID.

The bit widths of GSCID and PSCID in the privileged document are 14 and 16, respectively. However, the IOMMU document specifies that the bit widths of the two are 16 and 20. Looking forward to your answer

I understand that the roles of VMID and AISD in privileged documents are the same as GSCID and PSCID, both of which are used to distinguish between virtual machines and address spaces. Are there any other considerations here? Can you provide a more detailed introduction? Thank you for your response,

The key difference is that while ASID and VMID are hart local, GSCID and PSCID are global.
Please see this note from Priv. spec:

If a hart employs an address-translation cache, that cache must appear to be private to that hart. In particular, the meaning of an ASID is local to a hart; software may choose to use the same ASID to refer to different address spaces on different harts.

A future extension could redefine ASIDs to be global across the SEE, enabling such options as shared translation caches and hardware support for broadcast TLB shootdown. However, as OSes have evolved to significantly reduce the scope of TLB shootdowns using novel ASID-management techniques, we expect the local-ASID scheme to remain attractive for its simplicity and possibly better scalability

I have learned a lot from you, and I may need to reconsider some of your answers. If you have any questions, I will ask you again. I wish you good health and a happy family. Thank you very much


Printed PDF not printed correctly and images are misaligned.

Feedback from user of the Chrome extension:

Hi! Absolutely nice Extension - thank you for the effort :) My only problem is the following: On some documents the page looks misarranged when printed, this happens for instance on this document (page 4): http://www.sec.in.tum.de/assets/lehre/ws1314/info1fI/uebungen/exercise_10/exercise_10.pdf
This is how it looks like: http://img5.fotos-hochladen.net/uploads/camerazoom2014jknqdw5pxc.jpg
It only happens with this Plugin. I am using Chromium and Manjaro Linux. Thank you in advance!

This PDF file is not A4, which is probably the reason for failure.
The images in the PDF are also a bit misaligned (print to PDF, taken screenshot):

The PDF link is broken. I think that this bug was fixed with #5828.


Add metric MultiManager and MetricPlotter

Have replaced SimpleManager metric manager with new MultiManager class so this will be a breaking change.
MultiManager can take multiple metric generators of the same type and multiple sets of the same type to generate metrics.
All metrics that take in track and truth can now also take in 2 tracks.
Additional functionality added to MultiManager through new methods to help easier extraction of metrics and insights.
New MetricPlotter class created to make plotting metrics easier.

The breaking change makes this difficult to merge at this point. However, it may be possible to make it backwards compatible fairly easy:

Add back in the SimpleManager, inheriting from MultiManager, with "tracks", "groundtruth_paths" and "detections" as default keys in states_set.
Have property on SimpleManager for tracks, groundtruth_paths and detections that returns values from those dictionary keys mentioned above.
Change metrics so default for tracks_key and truths_key are "tracks" and "groundtruth_paths".
Also provide sensible default generator_name for each metric.

I've not tried this, but something like this should work or at least be a good start.


Move pydantic-core types into a stubs only package

Codecov Report

Merging #445 (2542cad) into main (7a46664) will increase coverage by 0.03%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   95.46%   95.50%   +0.03%
==========================================
  Files          90       90
  Lines       10735    10735
  Branches       10       10
==========================================
+ Hits        10248    10252       +4
+ Misses        484      482       -2
+ Partials        3        1       -2

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a46664...2542cad. Read the comment docs.

Closing in favor of #5206


All Full Page Demos Fail

All of the standalone demos fail, same error.
For example:
http://tombatossals.github.io/angular-leaflet-directive/examples/0300-paths-simple-example.html
Console reports:
$injector:modulerr

The examples site listed on the main page is working:
http://tombatossals.github.io/angular-leaflet-directive/examples/0000-viewer.html#/basic/first-example

The Esri ArcGIS Clustered Layer demo is not working:
http://tombatossals.github.io/angular-leaflet-directive/examples/0000-viewer.html#/layers/esri-clustered-layer-example
From the Console:
TypeError: Cannot read property 'replace' of undefined
at Object.a.Util.cleanUrl (Util.js:392)
at a.Layers.FeatureManager.a.Layers.FeatureGrid.extend.initialize (FeatureManager.js:27)
at a.Layers.FeatureManager.extend.initialize (ClusteredFeatureLayer.js:43)
at new e (leaflet.js:6)
at Object.window.L.esri.clusteredFeatureLayer (ClusteredFeatureLayer.js:26)
at Object.layerTypes.agsClustered.createLayer (angular-leaflet-directive.min.js:37)
at createLayer (angular-leaflet-directive.min.js:37)
at angular-leaflet-directive.min.js:38
at angular.js:14745
at n.$eval (angular.js:15989)
I'm wondering if it has anything to do with this announcement: Esri Leaflet 1.0.0 Announcement


Update PwnedPasswords.php

added cache.
before , a simple script like this :
$pw = new PwnedPasswords();
if($pw->isInsecure('123456')) {
   echo 'Ops, this password have been pwned ' . $pw->getCount('123456');
}

causes 2 curl request, now it only cause one, thanks to the cache.

'PwnedPasswords::isInsecure' now returns true if the password is pawned even once.
consider removing the 'maxUsage' options and keeping the method.

throws RuntimeException if curl failed.

keeping isInsecure() method.
removed $maxUsage option.

added fetch mode ( curl or file )
example :

// uses file_get_contents if curl failed
$pp = new PwnedPassword();
// specify curl options
$pp = new PwnedPassword(null,$curlOptions);
// use file_get_contents
$pp = new PwnedPassword(PwnedPassword::FILE);
// use curl with the given options
$pp = new PwnedPassword(PwnedPassword::CURL,$options);

@ron-maxweb what do you think ?

This is great stuff! Merged in!


Add support for Route 53 as another edge DNS implementation

In addition to the default Infoblox support, Route 53 should be added as an additional edge DNS option.
This should include examples and documentation on the usage and configuration of this option.

Duplicate #162 which is already implemented. Closing.


[WIP, RFC] Compilation server

This PR should bring support for incremental compilation of lean files within emacs, i.e. if you edit a proof at the end of a file, only the last proof will be redone--everything above it is cached.
Status: incremental compilation works, next step will be auto-completion.
The implementation works roughly in a similar way to the lean-server in lean 2, with a few differences:

Instead of transferring only changed lines, we always transfer the whole buffer.
Flycheck errors are done via lean-server as well.
JSON instead of a custom text protocol.
One server per buffer (see below).

Further changes:

Error messages are now stored in the parser as message objects.  This allows us to 1) easily resend them to the client, and 2) also relieves us of parsing headaches (linja silently broke some flycheck errors).
Lean now outputs a warning if the olean file of any imported file is out-of-date compared to the lean file.

To do:

auto-completion via company-mode (@Kha is currently working on this)
go-to-definition (I guess we need to extend declaration objects and olean files to include file/line information)

Line protocol
Communication with lean --server happens via stdin and stdout.  One JSON object on a single line per request, and one JSON object on a single line per response.  A typical exchange looks as follows:
< {"content": "run_command (tactic.trace \"hello, world\")\n", "file_name": "demo.lean", "command": "sync"}
> {"message":"no file changes","response":"ok"}
< {"command": "check"}
> {"is_ok":true,"messages":[{"caption":"trace output","file_name":"demo.lean","pos_col":0,"pos_line":1,"severity":"information","text":"hello, world\n"}],"response":"ok"}

For JSON support in C++, I added a small MIT-licensed library consisting of a single header file (that's the official release).  For now, I put it into src/utils.
I picked JSON for the protocol format mainly because of readily available, reliable, and tested libraries for it.  Possible alternatives would be s-expressions or a plain text format.  S-Expressions are unfortunately not standardized, and almost no premade parsers/formatters exist, requiring us to roll our own solution (and making sure that it's consistent across lean and all possible clients).  A custom text format as in lean 2 (or flycheck in lean 3) has similar issues: again we would need to implement and test a parser for each possible front-end--and there have been bugs even in the heavily-used linja tool.
Project handling
I think the biggest issue with this PR is the handling of projects.  Before, each flycheck invocation called linja to rebuild a temporary copy of the current buffer and its dependencies.  So if you have two lean files and modify one that is the dependency of the other, it will be recompiled (and saved to olean) as soon as you 1) save it and 2) edit the other one.
Right now the situation in this PR is the following: on each flycheck invocation, we only recompile the current file.  Should any olean dependencies have changed, we use the new olean files and recompile from the beginning.  If however only the lean file of the dependency has changed, then you only get a warning and need to linja yourself.
I have added the lean-run-linja command to run linja from within emacs.  Having a "compile the whole project" function seems to be useful regardless of the approach we take here, and it's very nice: we even hyperlink the errors in the linja output.
I'm a bit uncertain as how to deal with this issue.  From my point of view, the following would be nice to have:

When I open two files in emacs, and I change something in one file, then the other should be rechecked if it has the first one as a dependency.  Probably even if I don't save the first one.  Across project boundaries as well?
If a file has errors, I should still be able to use the correct parts from other files.
If I depend on a lean port of the (let's say) four color theorem, then I don't wait for it to compile.
There should be a way to have projects outside of the lean repo which depend on other projects.  Right now I don't believe this is easily possible, as linja will only search in the standard library in addition to the current directory.  Any solution we pick for the compile server should be compatible with this situation.

I'm mentioning these points as we almost have them in lean: parallel compilation/delayed proof checking is implemented, even though currently disabled AFAICT.  I just don't want to spend too much effort on a solution that will only ever work with the current 81+35 files, that we can completely check in under a minute.
Possible approaches:

Require semi-manual linja calls for now.
Keep the current behavior of the flycheck-mode, i.e. call linja on every check.  We could either make linja wrap the lean server (emulating the current implementation where linja calls lean), or call linja from within emacs.
Move linja into lean, i.e. make lean compile the dependencies by itself.  With this approach, we could leverage lean's existing parallel proof checking capabilities, providing a similar user experience to Isabelle/PIDE: you could begin to work on a new project while the proof-checking happens concurrently in the background.

Sebastian suggested the last one, and I'm starting to like it as well.

@gebner @Kha This is awesome!
I will merge it right now.

Sebastian suggested the last one, and I'm starting to like it as well.

Me too.
BTW, another advantage of getting rid of linja is that it depends on ninja and many users had problems with this dependency.

Question: what does it happen if the lean server crashes? Does emacs automatically restart it?

Question: what does it happen if the lean server crashes? Does emacs automatically restart it?

Every time we send a request to the server, we first make sure that it is running.  If it crashed, it will be restarted.


fix: EE client-build failure

Description
Import Appstate from "@appsmith/ " instead of "ce/"
Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=5c7b5f9

/ok-to-test sha=5c7b5f9

/ok-to-test sha=f020eff

/ok-to-test sha=c1c2143


com.android.support Version Error

When trying to use the barcodescanner with another plugin I was not able to build the cordova app.
After working through many errors it appears to come down to the fact that this (barcodescanner) pugin is using “com.android.support:support-v4:26.0.0-alpha1” (alpha version) which is interfering with another plugin using “com.android.support:appcompat-v7:25.3.1” (production version)
So, when the project is trying to merge all the settings from the all the plugins, due to inconsistency of the versions, errors occur.
Is it possible to get a new version of the plugin with the latest version of  “com.android.support:appcompat-v7:25.3.1”?

See #480

Thanks for the link.  I ended up going into the file myapp/platforms/android/phonegap-plugin-barcodescanner/myapp-barcodescanner.gradle and changing the dependency to:
compile 'com.android.support:appcompat-v7:+'
This appears to work.


Cannot handle multple fonts in same cell correctly

How to reproduce

create a file with two cells which are filled by mixing different Bold, Italic, Font and font size.  See attached aaa_multifonts.xlsx.
run a simple read write roundtrip
Open the output file, you will find fonts are not handled well for entire string.
See below snapshot in WPS office, the 2nd and 3th chars are default Simsun。In MS Office, they are Calibri.

code snippt

        let f = "/w/assets/xlsx/aaa_multifonts.xlsx";
        let path = std::path::Path::new(&f);
        let mut book = umya_spreadsheet::reader::xlsx::lazy_read(&path).unwrap();
        let _ = umya_spreadsheet::writer::xlsx::write(&book, &format!("{f}.rw.output.xlsx"));

aaa.xlsx.output.xlsx
aaa_multifonts.xlsx.rw.output.xlsx

@piaoger
Thank you very much for your help here.
I think it is probably a glitch.
We will investigate the cause and take action.

@piaoger
Sorry, could you please provide us with aaa_multifonts.xlsx so that we can understand the situation as accurately as possible.
(I think the two files you attached are probably both post-processed files.)


DNM: Localnet ux e2e test idempotent vlan creation create via bash

📑 Description

Fixes #
Additional Information for reviewers

✅ Checks

[ ] My code requires changes to the documentation
[ ] if so, I have updated the documentation as required
[ ] My code requires tests
[ ] if so, I have added and/or updated the tests as required
[ ] All the tests have passed in the CI

How to verify it

The code introduced in #4807 requires NET_ADMIN / root since it creates a vlan / adds an ip address to it.
Thus, the "create" operations are not suited to be executed with golang code.
Let's try to use netlink to READ, and bash commands ran w/ sudo for creating ...
A follow up PR can improve on this, making the tests themselves run with sudo.

Superseded by #4807


Build for different VTK variants

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This allows people to use the different VTK variants. The EGL and OSMesa variants enable usage on headless (display-less) machines such as on supercomputers.
@looooo, could you please take a look at this?
I have successfully locally built all 3 variants :tada:

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I believe this might actually not be needed, closing for now.


Avoid re-queuing schedule jobs in Whitehall

Jobs that are scheduled on Production get synced overnight to
Staging. The code deleted in this commit would queue up the
schedule workers for all of the scheduled editions in Whitehall.
For editions scheduled for publishing on a date past the day
of the data sync, this was pointless - the workers would be
continually removed and re-queued every day until the publish
happens.
For editions scheduled for publishing on the day of the data sync,
we regularly see issues to do with the redaction process in
govuk_env_sync. If the edition is access limited, its attachments
get renamed to 'redacted.pdf'
and then at time of publishing Whitehall intercepts lots of
'Asset not found' errors from Asset Manager, as it can no longer
find the asset by its legacy_url_path. Consequently, the
edition would be published on Staging but all of its assets
would be unavailable (404 response).
I did consider that we could edit Whitehall's
requeue_all_jobs Rake task
to only re-queue the scheduling of editions which are not
access-limited. However then we're in a confusing situation where
sometimes production-scheduled editions get published on Staging
and sometimes they don't.
Removing this re-queuing code doesn't break manual scheduling
on Staging; if a developer needs to test out scheduling an edition,
they can do so and it will still work. The only impact of this
change is that documents scheduled on Production don't get
published on their schedule date on Staging. This is only a
temporary situation for the edition too as it would fix itself
at the next data sync.
Finally, the code for this re-queuing was
added in 2015
with little explanation as to its benefit. It's quite possible
there is no real 'user need' for this feature.
Trello: https://trello.com/c/RethzUSW/2088-5-fix-assetmanagerservicehelperassetnotfound-errors-on-staging-integration

Thanks for the review, Thomas.

I wonder if we'll see the overdue healthcheck fail more often in integration/staging though: https://github.com/alphagov/whitehall/blob/6a3659944193311ffcc8b78e7460d35cde3876a7/app/controllers/healthcheck_controller.rb#L1-L8 (do we still need that check in those environments?)

Agreed, that healthcheck will need to be removed from integration & staging. We should keep it for Production though. I'll see if I can add a commit to this PR to remove the check from the other environments 🤔

And I also wonder if this might make it harder for 2nd line to debug issues related to scheduled publishing if someone reports an issue the morning after (because the job won't have run on integration/staging).

Do we know how often that happens? I don't think I've run into a scheduling issue on 2nd line yet. My approach would be to re-create a document on Staging and manually schedule it, then compare the Publishing API & Whitehall events with what happened on Production. I doubt Staging would be a particularly reliable debug environment in that scenario anyway, as the attachments, contents, changenotes and email addresses would all have been redacted and could affect the publishing behaviour in unknown ways.

Do we know how often that happens? I don't think I've run into a scheduling issue on 2nd line yet. My approach would be to re-create a document on Staging and manually schedule it, then compare the Publishing API & Whitehall events with what happened on Production. I doubt Staging would be a particularly reliable debug environment in that scenario anyway, as the attachments, contents, changenotes and email addresses would all have been redacted and could affect the publishing behaviour in unknown ways.

Yeah, I don't think it's a big enough concern to prevent this from going in... perhaps we should just wait and see if anyone has problems with it.

@thomasleese I've now pushed up a commit that (I believe) disables the whitehall_overdue_check_period check on Integration and Staging. Could you double check it please?


lettucev5 plugin bug when redis sentinel mode  can't get hosts value

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[√] Bug
[ ] Requirement
[ ] Feature or performance improvement

SkyWalking :8.4.0
Centos7.0+
java version "1.8.0_191"
lettucev5 plugin bug when redis sentinel mode  can't get hosts value,so ui tolopogy will display null:0 , like below pic

because sentinel mode the server nodes info will save in sentinels field, below is debug info, it's clear to understand why this bug happen.

i already fixed this , i will make a pr.

Yes, please.


Stop using deprecated numpy.complex

Follow-up #4605
I checked the occurrences with git grep '\.\(float\|int\|bool\|complex\)\([^0-9a-z_]\|$\)'

pfnCI, test this please.

Jenkins CI test (for commit 60fd86a618634813a0f153017de21bdb8612f8c6, target branch master) failed with status FAILURE.

pfnCI, test this please.

Jenkins CI test (for commit 60fd86a618634813a0f153017de21bdb8612f8c6, target branch master) failed with status FAILURE.

LGTM.