feat: add Message::addHeader() to add header with the same name

Description
For #5041

add Message::addHeader()
implement Message::header() "return an array of header objects": https://github.com/codeigniter4/CodeIgniter4/blob/0ab4d674a0364d5a4837c9ec05f544f342b332ba/system/HTTP/MessageTrait.php#L120-L121

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

The question is not strange. It seems PSR-7 specification is like that.
But I don't think these are the same:

a header with multiple values
multiple headers with the same name

If we handle multiple headers with the same name with a single Header class that has multiple values,
we cannot distinguish them.
If we were to send three Set-Cookie headers, how would we handle them?
We need to know that in the case of Set-Cookies, one value is sent with one header.

The main issue I have with this is that code like this:
$this->request->header('NAME')?->getValueLine();

is no longer guaranteed to work.

If we handle multiple headers with the same name with a single Header class that has multiple values,
we cannot distinguish them.

I don't see much difference when it comes to distinguishing between values, because in both cases we are dealing with a simple array. There are no methods that make it easy to work with multiple objects of the Header class. On the other hand, there are plenty that make it easier to work with multiple values in the Header class.
As you said, the PSR-7 seems to implement it just like we do right now: https://www.php-fig.org/psr/psr-7/#headers-with-multiple-values

Note: Not all header values can be concatenated using a comma (e.g., Set-Cookie). When working with such headers, consumers of MessageInterface-based classes SHOULD rely on the getHeader() method for retrieving such multi-valued headers.

In our case, it would be:
$this->request->header('NAME')?->getValue();

If $this->request->header('NAME')?->getValueLine() works now, it will work.
        $this->message->setHeader('accept', ['json', 'html']);
        $this->message->appendHeader('Accept', 'xml');
        dd($this->message->header('accept')?->getValueLine());
        // "json, html, xml"

But the following code does not make sense, because we cannot use logged_in=no; Path=/, sessid=123456; Path=/.
        $this->message->appendHeader(
            'Set-Cookie',
            'logged_in=no; Path=/'
        );
        $this->message->appendHeader(
            'Set-Cookie',
            'sessid=123456; Path=/'
        );
        dd($this->message->header('Set-Cookie')?->getValueLine());
        // string (43) "logged_in=no; Path=/, sessid=123456; Path=/"

In PSR-7, we also cannot use getHeaderLine() as you pointed out.
require __DIR__ . '/vendor/autoload.php';

$response = new \Laminas\Diactoros\Response();

$cookie1 = 'user_id=123; Path=/; Expires='
    . gmdate('D, d M Y H:i:s T', strtotime('+1 day'));
$cookie2 = 'session_token=abc123; Path=/; Secure; HttpOnly; SameSite=None; Expires='
    . gmdate('D, d M Y H:i:s T', strtotime('+7 days'));

$response = $response->withAddedHeader('Set-Cookie', $cookie1);
$response = $response->withAddedHeader('Set-Cookie', $cookie2);

var_dump($response->getHeader('Set-Cookie'));
var_dump($response->getHeaderLine('Set-Cookie'));

$ php test.php
array(2) {
  [0] =>
  string(58) "user_id=123; Path=/; Expires=Wed, 15 Nov 2023 05:09:03 GMT"
  [1] =>
  string(100) "session_token=abc123; Path=/; Secure; HttpOnly; SameSite=None; Expires=Tue, 21 Nov 2023 05:09:03 GMT"
}
string(159) "user_id=123; Path=/; Expires=Wed, 15 Nov 2023 05:09:03 GMT,session_token=abc123; Path=/; Secure; HttpOnly; SameSite=None; Expires=Tue, 21 Nov 2023 05:09:03 GMT"

After all, our question is:
How do we get and forward all headers with CURLRequest (and Response)?
See #5041

Yes... you are right. I clearly missed a lot. There is no other way around it.
However, I still see some issues.

If $this->request->header('NAME')?->getValueLine() works now, it will work.

And that's the problem. If we call:
$this->request->addHeader('NAME', 'value1');
$this->request->addHeader('NAME', 'value2');

then it will not work. We will receive an error when we try to use it. This should be at least documented in the changelog. Or even better handled just like you showed in Laminas.

Thanks. To get multiple headers and make them into one line does not make sense.
So it should causes an exception. I did so.

Hopefully, others can wave in with a comment about this.
Seems like only a changelog is missing.

PSR-7 cannot handle multiple headers with the same name correctly.

Rebased and added docs.


add possibility to use secret or configmap to reference dataobject data

How to categorize this PR?

/area usability
/kind enhancement
/priority normal
What this PR does / why we need it:
It is now possible to specify secrets and configmaps as source for data imports.
Secretrefs and configmap refs are not allowed in installation templates which means that can only be used in installation that are created by human operators not via aggregations.
This is validated in the default validation check of a blueprint.
the documentation will follow in a different PR where the whole installation is covered. https://github.com/gardener/landscaper/pull/32
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

It is now also possible to specify secrets and configmaps as source for data imports.

/review @Diaphteiros

@Diaphteiros PTAL


[MM-49251] Add day of week field and use in calendar

Summary

This PR is for https://github.com/mattermost/mattermost-server/issues/21920
Aim is to make day of week customisable for user.  And use it in calendar
Example: If user choses Tuesday, then the week should start from Tuesday.
Ticket Link

JIRA: https://mattermost.atlassian.net/browse/MM-49251
Related Pull Requests

Has server changes (https://github.com/mattermost/mattermost-server/pull/22484)

Screenshots

Release Note

Add first day of week in user display setttings
Use first day of week in calendar

Hello @tanmaydatta,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@tanmaydatta webapp is now part of mattermost monorepo now at https://github.com/mattermost/mattermost-server/tree/master/webapp Would you be interested in opening the PR over there?

To elaborate on Zubair's comment, the web app now lives in the webapp/channels over there. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.

Hi @hmhealey
I will make these changes over the weekend
I did face some issues in running the server after the migration to monorepo, but I will try to fix them and will reach out if I am stuck.
Thanks


Consider using GitHub auto-generated release notes

When you add a new release on GitHub you have an option to auto-generate release notes. This is useful for users of your project because, at a glance, they'll see a list of merged PRs and a link to the delta between the current and the previous release (as well as it adds the list of contributors and emphasizes first-time contributors). It is naturally also easier than writing release notes by hand.

Thanks, @Piedone. I will use this feature for future releases. I also added "Full Changelog" link to v2.0.0 release.

Awesome, thanks!


Revert "fix #1540 - declared Term.mutable as volatile"

This reverts commit e44989d686de20665da7a486734193b7760bc165.

@dwightguth please review
I use the benign single racey check pattern here without declaring Term.mutable as volatile because I am not sure if the race is due to undesired sharing of mutable terms between krun instances.


Allow SPA to extend webpack configs

Creating this pull request by way of discussion, in response to issue #532. Currently, this implementation only works for serve, but it would be simple enough to apply to both build and test.
To see our intended use-case, take a look at the Stache2 Code Block pull request and skyuxconfig.json file.

Codecov Report

Merging #100 into master will decrease coverage by 0.7%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage     100%   99.29%   -0.71%
==========================================
  Files          23       24       +1
  Lines         550      565      +15
  Branches       61       64       +3
==========================================
+ Hits          550      561      +11
- Misses          0        4       +4

Impacted Files
Coverage Δ

config/webpack/serve.webpack.config.js
100% <100%> (ø)
:arrow_up:

config/webpack/spa.webpack.config.js
69.23% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695c977...9e00f81. Read the comment docs.


Provider for defaults

Hi @danialfarid (not an issue) what do you think about a provider for configuring directive defaults? I was just thinking about starting this, but thought I would check first to see that it would be a welcomed change.
.config(UploadProvider, function() {
  UploadProvider.setDefaults({
    accept: 'image/*,application/pdf,text/plain,application/rtf,application/msword',
    multiple: true,
    allowDir: false,
    maxSize: 10000
  });
});

This would just be quite handy for not having to repeat the attributes throughout an application.

Was just looking for this feature. I'm working on an application that will have 15+ ng-file-upload inputs and they will all have exactly the same attributes other than the ng-model, so a provider for configuring defaults would save a lot of duplicate code.

Good idea it is welcomed.

Awesome, I'm nearly done with it so will have it up in a PR soon.


Input String format incorrect exception while training.

System Information (please complete the following information):

Model Builder Version: 16.0.2003.302
Visual Studio Version: 2019

Describe the bug
After training a model, Got an exception at the end. I could not go to Evaluate step.
I'm not sure about the translation of the exception, but it should be something like:
Input String format incorrect
Exception:
à Microsoft.ML.ModelBuilder.AutoMLService.Experiments.AutoMLExperiment`3.d__23.MoveNext() dans E:\A_work\1326\s\Microsoft.ML.ModelBuilder.AutoMLService\Experiments\AutoMLExperiment.cs:ligne 108
--- Fin de la trace de la pile à partir de l'emplacement précédent au niveau duquel l'exception a été levée ---
à System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
à System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
à Microsoft.ML.ModelBuilder.AutoMLEngine.d__28.MoveNext() dans E:\A_work\1326\s\Microsoft.ML.ModelBuilder.AutoMLService\AutoMLEngineService\AutoMLEngine.cs:ligne 134
To Reproduce
Steps to reproduce the behavior:

Create issue classification
Put your CSV File and pick columns
Start training
See error

Expected behavior
No exception should be seen and process should continue
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Suspecting this has to do with my regional settings (French) where decimal separator is ','.

I received the same error following the ML tutorial (https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/data).
Visual Studio: v16.5.1
Model Builder: 16.0.2003.302

@Lewis-Fam Are you also in a region where the decimal separator is "," ?

@bmigette Could you share your dataset? I've changed my compute region and I'm not able to reproduce with the wikipedia-detox-250-line-data.tsv

I also tired to repro with a numbers dataset. It worked and I was able to train. If you could share your dataset that would be really helpful!
Data:
Att1,Att2,Att3,Att4,Forgery
3.6216,8.6661,-2.8073,-0.44699,0
4.5459,8.1674,-2.4586,-1.4621,0
3.866,-2.6383,1.9242,0.10645,0
Model builder preview:

Here you go: https://drive.google.com/file/d/1e_bP5Pvq3SNpLR4VvynG9x6FFLjAgWrc/view?usp=sharing
I've chosen Issue classification, and selected trend_next_20 as predicted column.
Removed all trend columns in the input columns.

Sorry for the delay @bmigette.  I've tried with a , separator language on my machine and haven´t been able to reproduce. You are not the only one running into problems with , vs. . and I want to figure out the problem.
To summarize, you're training a numeric dataset that uses . as the decimal separator and , as the delimiter on the file (.csv). Your machine is in a language that expects , as the decimal separator. Training does not complete and you cannot advance to the Evaluate page because an error similar to Input String format incorrect is shown. This only happens sometimes (training time of 180s is okay, training time 1800s fails).
Does training fail right away, or at the end? What language is set for your VS?

Sorry for the delay @bmigette. I've tried with a , separator language on my machine and haven´t been able to reproduce. You are not the only one running into problems with , vs. . and I want to figure out the problem.
To summarize, you're training a numeric dataset that uses . as the decimal separator and , as the delimiter on the file (.csv). Your machine is in a language that expects , as the decimal separator. Training does not complete and you cannot advance to the Evaluate page because an error similar to Input String format incorrect is shown. This only happens sometimes (training time of 180s is okay, training time 1800s fails).
Does training fail right away, or at the end? What language is set for your VS?

Hi,
Here's the number format of my csv:
0.6361155060774996,0.5670212392831645,0.4545838648895267,0.6762474404317713
It fails at the end of the training process. It failed every attempts (so far I made maybe 3 attempts) I have made using default time of 1800seconds. Not sure why it hasn't failed when using 180seconds.
My VS is in english.
I can't tell for sure this has to do with regional settings, but usually error with bad input format can be caused by this.
I can set my windows to US and give it a try if you want, or collect additional logs.

@bmigette I was able to successfully train your dataset on our latest build (<IP_ADDRESS>7905).  Do you want to give it a try and see if the problem is fixed? I think I've tested on all the configurations you might have.

Based on my testing this is fixed in version <IP_ADDRESS>7905. If any comma separator users run into this again please ping we and we can reopen!

@beccamc Another related bug here: https://github.com/dotnet/machinelearning-modelbuilder/issues/1143


eth_call returns insufficient funds in call-simple-transfer test

Describe the bug
The rpc-compat test eth_call/call-simple-transfer returns insufficient funds:
>>  {"jsonrpc":"2.0","id":1,"method":"eth_call","params":[{"from":"0xaa00000000000000000000000000000000000000","gas":"0x186a0","to":"0x0100000000000000000000000000000000000000"},"latest"]}
<<  {"jsonrpc":"2.0","error":{"code":-32003,"message":"Insufficient funds for gas * price + value"},"id":1}
response differs from expected:
 {
-  "error": {
-    "code": -32003,
-    "message": "Insufficient funds for gas * price + value"
-  },
   "id": 1,
   "jsonrpc": "2.0"
+  "result": "0x"
 }

Steps to reproduce
Run hive (#851):
./hive --client reth --sim ethereum/rpc-compat --sim.limit "/eth_call/call-simple-transfer"

Node logs
No response
Platform(s)
No response
What version/commit are you on?
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

blocked by #1959
see description for the new error

@Rjected I wonder if this is also related to https://github.com/paradigmxyz/reth/issues/1951#issuecomment-1482093752?

@gakonst it is related, and fails from insufficient funds because of the same code path. After the HistoricalStateProvider fix, the test fails due to sender not an eoa


Add Cohesion tracking to artist Top Works content

Adds tracking with Cohesion schema.

https://artsyproduct.atlassian.net/browse/FX-1987

Cool!! Cohesion seems great!


Cannot load scenes, stuck at loading ~70%

Having several issues trying to run v1.16.0 on my Forge server, for some reason it won't complete loading and I can't tell what the problem is.  The closest I can find is from the logger when the server locks:
Loaded icons/svg/light.svg (2%) foundry.js:29223:13
Loaded icons/svg/eye.svg (5%) foundry.js:29223:13
Loaded icons/svg/explosion.svg (7%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/sun.svg (9%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/net.svg (11%) foundry.js:29223:13
Loaded icons/svg/cowled.svg (14%) foundry.js:29223:13
Loaded icons/svg/combat.svg (16%) foundry.js:29223:13
Loaded icons/svg/door-open-outline.svg (18%) foundry.js:29223:13
Loaded icons/svg/up.svg (20%) foundry.js:29223:13
Loaded icons/svg/down.svg (23%) foundry.js:29223:13
Loaded icons/svg/aura.svg (25%) foundry.js:29223:13
Loaded icons/svg/skull.svg (27%) foundry.js:29223:13
Loaded icons/svg/daze.svg (30%) foundry.js:29223:13
Loaded icons/svg/light-off.svg (32%) foundry.js:29223:13
Loaded icons/svg/blind.svg (34%) foundry.js:29223:13
Loaded icons/svg/padlock.svg (36%) foundry.js:29223:13
Loaded icons/svg/sound-off.svg (39%) foundry.js:29223:13
Loaded icons/svg/sound.svg (41%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/invisible.svg (43%) foundry.js:29223:13
Loaded icons/svg/deaf.svg (45%) foundry.js:29223:13
Loaded icons/svg/degen.svg (48%) foundry.js:29223:13
Loaded icons/svg/wall-direction.svg (50%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/door-secret-outline.svg (52%) foundry.js:29223:13
Loaded icons/svg/paralysis.svg (55%) foundry.js:29223:13
Loaded icons/svg/falling.svg (57%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/downgrade.svg (59%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/unconscious.svg (61%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/sleep.svg (64%) foundry.js:29223:13
Loaded icons/svg/door-closed-outline.svg (66%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
index.js:126
Loaded icons/svg/door-locked-outline.svg (68%) foundry.js:29223:13
Uncaught Error: The SVG image must have width and height defined (in pixels), canvas API needs them.
onload index.js:126
I do not know if these are related.

Wanted to add I'm using V11 (build 305) as the Foundry version.

You use Firefox ? Version ?

Yes, using Firefox v115.0.2

As a test I did try and run it on Chrome with no issues

Confirmed working in Firefox.


v2 not working anymore

Edit: This is via CFCurl, with CFStreamContext - it works fine.
Since the 23rd of May, v2 can't seem to be able to bypass cloudflare anymore.
The url I'm trying is: https://predb.me/ and outputting the browser check page (instead of the target page, as it successfully did for the last few months).
I don't really know how to debug further. Let me know.

The primary goal of this library is to bypass this:

In your case there is nothing to bypass, only a simple header agent to add
Simple request return 503
curl -X GET 'https://predb.me/'

Using User-Agent return 200
curl -X GET \
  https://predb.me/ \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36'

If your ip got banned  you should change your ip or use a proxy library
Hopefully this will help to clarify

It's possible it depends on country (I'm accessing it from the UK).
Even with user-agent, I get the "Please wait 5 seconds" browser check which before 23rd of May was successfully bypassed by the same php class.
The IP doesn't seem to be banned or in anyway specifically restricted as it pulls the target page just fine using CFStreamContext.

Yes, it's possible!
If you see the "Please wait 5 seconds" than we have a problem.
I have tried with a bunch of proxies from uk, but i still get 200
curl -X GET \
  https://predb.me/ \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36' \
  --proxy tcp://<IP_ADDRESS>:3128

here:
* Added cookie cf_clearance="fd7504bf4550bdafa2a75a1e1f9f2023d4145521-1527655355-604800" for domain (nil), path (nil), expire 0
* Added cookie __cfduid="d5a6b286685c742fef1ad99eaa9ea768a1527655351" for domain (nil), path (nil), expire 0
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to predb.me (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* SSL connection using TLSv1.2 / ECDHE-ECDSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: OU=Domain Control Validated; OU=PositiveSSL Multi-Domain; CN=sni188534.cloudflaressl.com
*  start date: May 13 00:00:00 2018 GMT
*  expire date: Nov 19 23:59:59 2018 GMT
*  subjectAltName: host "predb.me" matched cert's "predb.me"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO ECC Domain Validation Secure Server CA 2
*  SSL certificate verify ok.
> GET /?search=720p+cat%3A-tv-hd%2C-xxx+-s01*+-s02*+-s03*+-s04*+-s05*+-s06*+-s07*+-s08*+-s09*+-s10*+-s11*+-s12*+-s13*+-s14*+-s15*+-s16*+-s17*+-s18*+-s19*+-s20*+-s21*+-s22*+-s23*+-s24*+-s25*&page=1 HTTP/1.1

Host: predb.me

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Accept: */*

< HTTP/1.1 503 Service Temporarily Unavailable

< Date: Wed, 30 May 2018 04:43:24 GMT

< Content-Type: text/html; charset=UTF-8

< Transfer-Encoding: chunked

< Connection: close

* Added cookie __cfduid="daf031cd1eb6662c3b7ba606fcd5e3ec31527655404" for domain predb.me, path /, expire<PHONE_NUMBER>
< Set-Cookie: __cfduid=daf031cd1eb6662c3b7ba606fcd5e3ec31527655404; expires=Thu, 30-May-19 04:43:24 GMT; path=/; domain=.predb.me; HttpOnly

< X-Frame-Options: SAMEORIGIN

< Cache-Control: no-cache

< Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"

< Server: cloudflare

< CF-RAY: 422e8a27fb086a07-LHR

<

* Closing connection 0
* Replaced cookie cf_clearance="13350c64d5ee86ea897dbe0a3fa14dc2b642a95d-1527655408-604800" for domain (nil), path (nil), expire 0
* Replaced cookie __cfduid="dcd130283610061a35da53b410f1e84341527655404" for domain (nil), path (nil), expire 0
* Hostname predb.me was found in DNS cache
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to predb.me (<IP_ADDRESS>) port 443 (#1)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* SSL re-using session ID
* SSL connection using TLSv1.2 / ECDHE-ECDSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: OU=Domain Control Validated; OU=PositiveSSL Multi-Domain; CN=sni188534.cloudflaressl.com
*  start date: May 13 00:00:00 2018 GMT
*  expire date: Nov 19 23:59:59 2018 GMT
*  subjectAltName: host "predb.me" matched cert's "predb.me"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO ECC Domain Validation Secure Server CA 2
*  SSL certificate verify ok.
> GET /?search=720p+cat%3A-tv-hd%2C-xxx+-s01*+-s02*+-s03*+-s04*+-s05*+-s06*+-s07*+-s08*+-s09*+-s10*+-s11*+-s12*+-s13*+-s14*+-s15*+-s16*+-s17*+-s18*+-s19*+-s20*+-s21*+-s22*+-s23*+-s24*+-s25*&page=1 HTTP/1.1

Host: predb.me

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Accept: */*

Cookie: __cfduid=daf031cd1eb6662c3b7ba606fcd5e3ec31527655404

< HTTP/1.1 503 Service Temporarily Unavailable

< Date: Wed, 30 May 2018 04:43:29 GMT

< Content-Type: text/html; charset=UTF-8

< Transfer-Encoding: chunked

< Connection: close

< X-Frame-Options: SAMEORIGIN

< Cache-Control: no-cache

< Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"

< Server: cloudflare

< CF-RAY: 422e8a430acf0a7e-LHR

<

* Closing connection 1

I'll merge as soon as its confirmed a working fix. Really do appreciate the support you are giving here @railken

Sorry for the delay! Unfortunately, still getting the 5 seconds page. Log again below:
`* Added cookie cf_clearance="6b9bb0c172264177abe41467e341b862a7b3b00f-1527947815-604800" for domain (nil), path (nil), expire 0

Added cookie __cfduid="dfcd37d799435f03caf8e3b1c14eec8c91527947811" for domain (nil), path (nil), expire 0
Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to predb.me (<IP_ADDRESS>) port 443 (#0)
ALPN, offering http/1.1
Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
successfully set certificate verify locations:
CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
SSL connection using TLSv1.2 / ECDHE-ECDSA-AES128-GCM-SHA256
ALPN, server accepted to use http/1.1
Server certificate:
subject: OU=Domain Control Validated; OU=PositiveSSL Multi-Domain; CN=sni188534.cloudflaressl.com
start date: May 13 00:00:00 2018 GMT
expire date: Nov 19 23:59:59 2018 GMT
subjectAltName: host "predb.me" matched cert's "predb.me"
issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO ECC Domain Validation Secure Server CA 2
SSL certificate verify ok.

TCP_NODELAY set
Connected to predb.me (<IP_ADDRESS>) port 443 (#1)
ALPN, offering http/1.1
Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
successfully set certificate verify locations:
CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
SSL re-using session ID
SSL connection using TLSv1.2 / ECDHE-ECDSA-AES128-GCM-SHA256
ALPN, server accepted to use http/1.1
Server certificate:
subject: OU=Domain Control Validated; OU=PositiveSSL Multi-Domain; CN=sni188534.cloudflaressl.com
start date: May 13 00:00:00 2018 GMT
expire date: Nov 19 23:59:59 2018 GMT
subjectAltName: host "predb.me" matched cert's "predb.me"
issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO ECC Domain Validation Secure Server CA 2
SSL certificate verify ok.

The "protection of 5 seconds" occurs only when you're searching, there is no protection in the GET /.
Can you confirm me this?
Return 200
curl -X GET \
  https://predb.me/ \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36' \
  -I

Return 503
curl -X GET \
  https://predb.me/?search=anything \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36' \
  -I

In any case i have to add a config "verbose" to help us while debugging, otherwise it's a nightmare

I only overwrote this file, copying it from the RAW view here:
https://raw.githubusercontent.com/railken/cloudflare-bypass/79e2f46309e051f29e210b12510569df51dea261/v2/src/CloudflareBypass/CFBypass.php
Is that enough?
And yes - I confirm the "5 second" thing only pops up when searching. When simply loading predb.me - it outputs the target page.

Yes, thanks for confirming it.
I made a fix and added a config "verbose".
Please a check the same pull #63, add  "verbose" => true in your CFCurl instance and try again.

I've updated both CFCore and CFBypass to the latest versions.
<?
require 'src/autoload.php';
use CloudflareBypass\RequestMethod\CFCurl;

$url = "https://predb.me/?search=720p+cat%3A-tv-hd%2C-xxx+-s01*+-s02*+-s03*+-s04*+-s05*+-s06*+-s07*+-s08*+-s09*+-s10*+-s11*+-s12*+-s13*+-s14*+-s15*+-s16*+-s17*+-s18*+-s19*+-s20*+-s21*+-s22*+-s23*+-s24*+-s25*&page=1";

$curl_cf_wrapper = new CFCurl(array(
	'cache'         => true,
	'max_retries'  => 5,
	'verbose'  => true
));

$ch = curl_init($url);
//$curl_log = fopen("curl.txt", 'w');
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);

//curl_setopt($ch, CURLOPT_VERBOSE, true);
//curl_setopt($ch, CURLOPT_STDERR, $curl_log);
curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36');
$output= $curl_cf_wrapper->exec($ch);
curl_close($ch);
//echo $output;
?>

Here is what I'm getting as an output:

Generated clearance link https://predb.me/cdn-cgi/l/chk_jschl?pass=1528266781.068-XfVkjgfUc%2F&jschl_vc=5e3f0bdf689ed8230e02d1200d28f576&jschl_answer=9.4570250269&search=720p+cat%3A-tv-hd%2C-xxx+-s01*+-s02*+-s03*+-s04*+-s05*+-s06*+-s07*+-s08*+-s09*+-s10*+-s11*+-s12*+-s13*+-s14*+-s15*+-s16*+-s17*+-s18*+-s19*+-s20*+-s21*+-s22*+-s23*+-s24*+-s25*&page=1

Toggling "'verbose' => true" to false doesn't seem to make a difference. The output is the same.

@santah
Working tests (PHP 7.1 and php 7.2) https://travis-ci.org/railken/cloudflare-bypass
Delete all your cache files (or disable it) and try again with #63
@nitemare
PHP Version?
Your sample code?
Log of the request?

Updated to the latest CFBypass.
PHP Version 5.5.38
Same result. In the code I pasted before, I only changed "'cache'         => true" to false and uncommented the curl log to curl.txt.
I don't have any other cache.
Here is the log from curl:
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to predb.me (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* SSL connection using TLSv1.2 / ECDHE-ECDSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: OU=Domain Control Validated; OU=PositiveSSL Multi-Domain; CN=sni188534.cloudflaressl.com
*  start date: May 13 00:00:00 2018 GMT
*  expire date: Nov 19 23:59:59 2018 GMT
*  subjectAltName: host "predb.me" matched cert's "predb.me"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO ECC Domain Validation Secure Server CA 2
*  SSL certificate verify ok.
> GET /?search=720p+cat%3A-tv-hd%2C-xxx+-s01*+-s02*+-s03*+-s04*+-s05*+-s06*+-s07*+-s08*+-s09*+-s10*+-s11*+-s12*+-s13*+-s14*+-s15*+-s16*+-s17*+-s18*+-s19*+-s20*+-s21*+-s22*+-s23*+-s24*+-s25*&page=1 HTTP/1.1

Host: predb.me

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Accept: */*

< HTTP/1.1 503 Service Temporarily Unavailable

< Date: Thu, 07 Jun 2018 17:42:34 GMT

< Content-Type: text/html; charset=UTF-8

< Transfer-Encoding: chunked

< Connection: close

< Set-Cookie: __cfduid=d7f3de32bef283f7e6f41b18058be9f6f1528393354; expires=Fri, 07-Jun-19 17:42:34 GMT; path=/; domain=.predb.me; HttpOnly

< X-Frame-Options: SAMEORIGIN

< Cache-Control: no-cache

< Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"

< Server: cloudflare

< CF-RAY: 4274ea7f3d2f6a0d-LHR

<

* Closing connection 0
* Added cookie __cfduid="d1b47e3eb800370a408899a8eb1473ff41528393358" for domain (nil), path (nil), expire 0
* Added cookie cf_clearance="fcd088a9793d4f63bb89ae0af28d2474839e805f-1528393358-604800" for domain (nil), path (nil), expire 0
* Hostname predb.me was found in DNS cache
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to predb.me (<IP_ADDRESS>) port 443 (#1)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/pki/tls/certs/ca-bundle.crt
  CApath: none
* SSL re-using session ID
* SSL connection using TLSv1.2 / ECDHE-ECDSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: OU=Domain Control Validated; OU=PositiveSSL Multi-Domain; CN=sni188534.cloudflaressl.com
*  start date: May 13 00:00:00 2018 GMT
*  expire date: Nov 19 23:59:59 2018 GMT
*  subjectAltName: host "predb.me" matched cert's "predb.me"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO ECC Domain Validation Secure Server CA 2
*  SSL certificate verify ok.
> GET /?search=720p+cat%3A-tv-hd%2C-xxx+-s01*+-s02*+-s03*+-s04*+-s05*+-s06*+-s07*+-s08*+-s09*+-s10*+-s11*+-s12*+-s13*+-s14*+-s15*+-s16*+-s17*+-s18*+-s19*+-s20*+-s21*+-s22*+-s23*+-s24*+-s25*&page=1 HTTP/1.1

Host: predb.me

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Accept: */*

< HTTP/1.1 503 Service Temporarily Unavailable

< Date: Thu, 07 Jun 2018 17:42:38 GMT

< Content-Type: text/html; charset=UTF-8

< Transfer-Encoding: chunked

< Connection: close

* Added cookie __cfduid="d063075a6ad9c20c280e08e4c0d37ff3b1528393358" for domain predb.me, path /, expire<PHONE_NUMBER>
< Set-Cookie: __cfduid=d063075a6ad9c20c280e08e4c0d37ff3b1528393358; expires=Fri, 07-Jun-19 17:42:38 GMT; path=/; domain=.predb.me; HttpOnly

< X-Frame-Options: SAMEORIGIN

< Cache-Control: no-cache

< Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"

< Server: cloudflare

< CF-RAY: 4274ea9a2b5f0a7e-LHR

<

* Closing connection 1

@santah  Can you please send me the code you are using for attempting to bypass cloudflare for this site to<EMAIL_ADDRESS>?
I'll take a look and see where its going wrong. I have PHP 5.5.36 and its working fine for me.

I have pasted it in its entirety here:
https://github.com/KyranRana/cloudflare-bypass/issues/62#issuecomment-394956596

it works for me. Could we do a join.me session? That's the only way i will be able to see what is going on. Email me.

Will do.

Will do.

I'm using PHP 7.0.30 and i don't know how to get logs of the request. here is the code i'm using:
`
require_once '../libraries/autoload.php';
use CloudflareBypass\RequestMethod\CFCurl;
$siteUrl = "http://torrentz2.eu/584cb082cb19d81dbabe3e201d89976459d495ea";
//$siteUrl = "http://torrentz2.eu/";
//$siteUrl = "http://google.com/";
$curl_cf_wrapper = new CFCurl(array(
'cache'         => true,   // Caching now enabled by default; stores clearance tokens in Cache folder
'max_retries'   => 5       // Max attempts to try and get CF clearance
));
// Get Example: 1
$ch = curl_init($siteUrl);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36');
$site = $curl_cf_wrapper->exec($ch); // Done! NOTE: HEAD requests not supported!
curl_close($ch);
`

nitemare, we can organise a join.me session as well. If you mail me<EMAIL_ADDRESS>I can fix your issue as well.

hey mate im also getting this issue. could i join in :D

@KyranRana Did you find the problem?

my issue was trying to proxy torrentz2.is ... it would just show the 5 seconds page . but i found changing the proxy ip to  a fresh one solved it.

@KyranRana I have not heard back from you, have you made any progress?

@KyranRana I'm using PHP 7. The caching is enable by default. But I'm not seeing any cache folder... Help?

Same with me, do not see cache folder !

@Dibbyo456 @ash121121 @yumedia Have you all set a custom cache path or are you using the default cache path? The default cache path uses the system's temporary folder (dependent on the OS you use).

@KyranRana No. I did not set any custom cache path. I just used the default one.
I just checked /tmp folder on my XAMPP, I could not find any cache..!

Update: Just wanted to let you know, that I'm using CFStreamContext

Create another PHP file and put the following code inside:
<?php echo get_sys_temp_dir();
Run the file and check in that directory if the cf-bypass folder exists.

I think you meant sys_get_temp_dir(). Anyway, YES. cf-bypass exists.
But an empty folder.. No files.. Is it because I'm not using cURL?

Try setting a cache_path on initialisation and set it to a path you can access on your drive.
Run the script and check if a file appears in the path which you have set. The filename should be an MD5 hash.

Just like I suspected in the first place.
When, using CFStreamContext cache does not create at all.
But when CFCurl cache creates properly..

I have fixed the caching issue with CFStreamContext and added some tests to make sure it continues to work. I will put a pull request out later today.

@railken I am having issues running the tests when creating a pull request, Travis CI build keeps failing but it passes on my local environment. Can you help? Its the only pull request available right now. Thanks.

@KyranRana
php 5.6: https://github.com/travis-ci/travis-ci/issues/6339
php 7.1.18 and 7.2: a proxy server is necessary
I have created #65 to fix the proxy server with the new CFStreamContext test
When using travis you should add the PROXY_SERVER env var, i have sent to you an email with more details

@railken I haven't received an email from yourself. Also regarding Travis CI, I noticed the travis.yml file has a command to create a .env file however doesn't append any settings to it.

@KyranRana Isn't<EMAIL_ADDRESS>your email?
btw, add PROXY_SERVER as name and <IP_ADDRESS>:3129 as value here

PHP 5.6 test is the only one failing now. The other 2 pass.
We have to wait for a fix from that thread. :/

As of yesterday, this is no longer working using CFCurl AND CFStreamContext.
(until yesterday, CFStreamContext was working fine).
It now returns 503 error.
No changes on my side.

p

This problem should be resolved. If any of you run into the same problem again. Open a new issue.


Download button doesn't work.

On the product/project page it has a download button that does not work.
Link: http://parall.ax/products/jspdf
If you click on "Download Now Version 0.9.0rc2" nothing happens....
Since this is the first page on Google when we search for "jsPDF" it should work....

Hi there,
Thanks for you issue. Can you try again with the latest release and reopen if it's still happening?
Many thanks,
James

@MrRio It's like @xdhmoore said.... Because the form opens below it, we don't notice it.... (small screen, or not... 1920x1080)


Updated DevCGlobalDirectory.md

What does this PR do?
Updated DevCGlobalDirectory.md
Any relevant issues this PR addresses? (optional)
#59

@BolajiAyodeji @saranshkataria Here's my first PR!
Can you review this please?Thanks in advance:)


[build] Missing -o option for object files in Makefile

Hi there!
I use the zig cc compiler to cross-compile raylib for Windows on Linux and, if not specified, it outputs object files with .obj extension instead of .o. Since the Makefile expects object files to end in .o, compilation fails. This is fixed by adding the -o option to the module targets in the Makefile.
Before:
# Compile core module
rcore.o : rcore.c raylib.h rlgl.h utils.h raymath.h rcamera.h rgestures.h
    $(CC) -c $< $(CFLAGS) $(INCLUDE_PATHS)

After:
# Compile core module
rcore.o : rcore.c raylib.h rlgl.h utils.h raymath.h rcamera.h rgestures.h
    $(CC) -c $< -o $@ $(CFLAGS) $(INCLUDE_PATHS)

@xroberx It works perfectly on the other platforms without the -o, so I prefer not to change it to support a specific use case, zig cc should support the standard conventions.

@raysan5 I think it is good practice to use the -o option anyway, what are your objections against it?

@xroberx that current implementation works in all tested platforms.

@raysan5 Ok, it's a shame though, because zig cc is such a great tool for cross-compiling :( Let me know if you change your mind, I created a pull request.


Fix activity double resolve -- but do we want to?

What was changed:
Fixes double-resolves by squelching them lang side, but this introduces a problem where we can get a workflow task from the server that we have nothing to about. We could simply respond immediately with an empty command list, but that feels a little weird and introduces completions inside poll which is nonobvious.
We can instead just not do this, and expect lang to ignore (or do whatever else it wants) with the extra completion. It would then also have to return an empty response if there is no further work to be done.
Currently, what will happen if there are no other events in the history is the workflow task will be dropped and eventually time out. Results in a history like this:
11
ActivityTaskCancelRequested

12
TimerStarted

13
ActivityTaskStarted

14
ActivityTaskCompleted <-- we don't care about this because we already cancelled it locally

15
WorkflowTaskScheduled

16
WorkflowTaskStarted

17
WorkflowTaskTimedOut
10s (+10s)

Why?

Checklist

Closes issue:
closes https://github.com/temporalio/sdk-core/issues/110
How was this tested:

Any docs updates needed?

Just going to merge everything at once in https://github.com/temporalio/sdk-core/pull/113


Fixes to performance producer to support compact topics

Enhancements to ProducerPerformance to support generation load to Compact topics.
Added a new flag called --key-range which takes in a range like 0-1000. Key is generated using a random number between this range

LGTM.
Push this to Apache/Kafka truck


Unify OfferId formatting within the offer manager

Simplifies the Id class hierarchy within the offer manager
Ensures same formatting using a formatter
Minor fixes to probable bugs

shouldnt this go in a hotfix branch (1.2.2)?


Improve PHPdoc / IDE autocomplete

need "Support Laravel 5.4 MR"

This Pr is ready to merge :)

Merged!


Replace /api/dataserver use in tfc_web/transport/views.py

There remain some references to /api/dataserver in tfc_web/transport/views.py. I'm having some problem following the dependancies. I think two of the references relate to probably obsolete /zones/ and /zone/ endpoints, and one to getting SIRI data at /transport/busdata.json, probably for /transport/map_old/? @abrahammartin can you confirm?
The zone stuff could be converted to the new API, but not the SIRI stuff since we don't have a new API for that and the right route is probably rt_monitor.

[ ] Deal with /zones/ endpoint
[ ] Deal with /zone/ endpoint
[ ] Deal with /transport/busdata.json endpoint

All dependencies of dataserver can be found here: https://github.com/ijl20/tfc_web/search?q=API_ENDPOINT&unscoped_q=API_ENDPOINT
Also the transport API uses the siriVM file feed here (instead of the dataserver feed like the map_old): https://github.com/ijl20/tfc_web/blob/5f42ba6fc1c865763269b67aa7173d84ab9e2205/tfc_web/transport/api/views.py#L311
map_old could stop working as long as we implement the missing features that the current map do not have but the old one does.
The transport API siriVM_to_journey do not depend of dataserver and will only stop working if data_monitor stops working (/media/tfc/sirivm_json/data_monitor/) [see https://github.com/ijl20/tfc_web/blob/5f42ba6fc1c865763269b67aa7173d84ab9e2205/tfc_web/transport/api/views.py#L311]. I think we need to maintain this API endpoint and make it private so only we can use it, as it is very likely that we will use it soon for other purposes.

All dependencies of dataserver can be found here: https://github.com/ijl20/tfc_web/search?q=API_ENDPOINT&unscoped_q=API_ENDPOINT

As far as I can see this is searching 'master', which makes it hard to see what I've fixed in jw35-replace-dataserver. But I think the only remaining references are in tfc_web/transport/views.py

Also the transport API uses the siriVM file feed here (instead of the dataserver feed like the map_old):
tfc_web/tfc_web/transport/api/views.py
Line 311 in 5f42ba6
Path('/media/tfc/sirivm_json/data_monitor/' + listdir('/media/tfc/sirivm_json/data_monitor/')[0])

That's not an issue here.

map_old could stop working as long as we implement the missing features that the current map do not have but the old one does.

And we should - covered by #156

The transport API siriVM_to_journey do not depend of dataserver and will only stop working if data_monitor stops working (/media/tfc/sirivm_json/data_monitor/). See:
tfc_web/tfc_web/transport/api/views.py
Line 311 in 5f42ba6
Path('/media/tfc/sirivm_json/data_monitor/' + listdir('/media/tfc/sirivm_json/data_monitor/')[0])
I think we need to maintain this API endpoint and make it private so only we can use it, as it is very likely that we will use it soon for other purposes.

I'm not entirely convinced that a poling API endpoint is appropriate here - surely a pushed web sockets interface would be better for data changing with this frequency? In which case we could (in due course) drop this endpoint from the API. And in the mean time we could hide it. In any case /api/dataserver isn't involved so this isn't an issue here (but see #143).

So I think we understand /transport/busdata.json
Anyone know anything about the /zones/ and /zone/ endpoints? They don't seem to work - with /zones/ giving
Reverse for 'zone' with arguments '('',)' not found. 1 pattern(s) tried: ['zone/(?P<zone_id>\\w+)/$']


Visit issue

Hey Kendall your visits display is set to 0 and doesn't work

Hey Kendall your visits display is set to 0 and doesn't work

Yes, I noticed that. I will fix it soon.

It's still there..


updated cli tool to be used to generate openapi document

Changes proposed in this pull request:

Updated to working cli to generate openapi document and handle multiple versions

Have not added build to generate console app, but added support for win, linux and mac os
Resolves #303, #305
Ready for review @justinyoo

Have not added build to generate console app, but added support for win, linux and mac os

Resolves #303, #305

@Nibell Thanks for the PR! I'll take a look and get back to you.

Hi @Nibell! Nice one on the refactor to integrate working CLI tooling to generate swagger file.
Currently we use Azure Functions v3 and are searching for a good way to generate the swagger file after building the function-app to incorporate automatic updates to the APIM we also use.
Now we wait for @justinyoo to get back to you.

Updated PR to :NET 6 @justinyoo

@Nibell Here's what I ran:
azfuncopenapi.exe -p "C:\path\to\functionapp" -v v3

But I get the exception:
Could not load file or assembly 'Microsoft.Azure.WebJobs, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

Can you reproduce this error on your end? The function app path is completely outside this repo.

@justinyoo I can reproduce the error (Microsoft.Azure.WebJobs version 3.0.31 is missing).
There is a stray package reference in the CLI's csproj (<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.5" />). If I update that to 3.0.31 it fixes that error, but I get
Could not load file or assembly 'Microsoft.Azure.WebJobs.Extensions.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

after that. It looks like some dependencies are not loaded into memory. I don't think it is a good idea to add those missing items as package as it tightly couples the CLI tool with the exact versions used by the function app of which the open api docs are generated.

@ThomasBleijendaal
To fix the out-of-process/in-process coupling would it make sense to make Microsoft.Azure.Functions.Worker.Extensions.OpenApi.Cli for Out-of-process?

As the PR, #489, has been merged, you can generate the OpenAPI doc on-the-fly, within the GitHub Actions workflow.

I think it is really a pitty that this PR has been closed. We would definitly use it, the on the fly generation really feels cumbersome.
@justinyoo could you consider re-opening this and make it only support out-of-proc functions? As with the new azure function roadmap the webjobs functions are not supported  in the future anyway.


Bugfixing and Refactoring

Hey gsempe,
i loved the wwdc 2015 session about Advanced NSOperations and i am adapting it in some of my projects. here are some changes I made and hope, that this api will become much more powerful ;)
kind regards,
phillipp

Reorganize Project Structure
Reformatted Code
Added Demo Target
Bugfix in NegatedCondition
Bugfix in LocationOperation
Bugfix in Timer class from NetworkOperation
adapted access modifier

Thank you for the pull request.
As it is a lot code modification I'll review it in the next days and give you feedbacks.

@gsempe any progress?


When Collection is required any message was return

Hi,
I have a CollectionInputFilter setted with setIsRequired, at least one of my target element should exists, but when I submite without any target element, isValid return false, but getMessages is empty, any reason/message was returned...

Same here :(

+1
I have the same issue.
any updates?

Having the same issue the most of time.
Does someone here already have solution?
Am currently at zend 2.3.8?

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Request for the release of datasets?

Can you release all the datasets mentioned in your paper, including Steam, Yoochoose, Yelp, GoogleLocal and GoodReads?

The datasets are available online:
Steam/GoogleLocal/GoodReads:
Yoochoose:
Yelp:


emacsWrapper: preload autoloads

Description of changes
This commits changes the wrapper, that is being constructed for Emacs, when built with additional packages, to preload all autoload definitions. The list of all definitions is generated at build-time. Packages do not need to be (require)d for them to work.
With this commit it is now possible to do:
nix-shell -I "nixpkgs=$PWD" -p "emacs.pkgs.withPackages(e:[e.magit])" \
          --run "emacs -Q -nw -f magit"

Magit opens.  Without this commit:
nix-shell -p "emacs.pkgs.withPackages(e:[e.magit])" \
          --run "emacs -Q -nw -f magit"

Error: "Symbol’s function definition is void: magit"

On a slight downside, this commit adds 10ms to the startup of Emacs.
Before:
$ nix-shell -p "emacs.pkgs.withPackages(e:[])" \
            --run "time emacs -Q --batch -f kill-emacs"

real	0m0.069s
user	0m0.045s
sys	0m0.024s

After:
$ nix-shell -I nixpkgs=$PWD -p "emacs.pkgs.withPackages(e:[])" \
            --run "time emacs -Q --batch -f kill-emacs"
real	0m0.078s
user	0m0.055s
sys	0m0.023s

More information on autoloading:
https://www.gnu.org/software/emacs/manual/html_node/eintr/Autoload.html
@adisbladis @AndersonTorres What do you think?
@ParetoOptimalDev This may also address the issue https://github.com/nix-community/emacs-overlay/issues/212 that you opened.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

On a slight downside, this commit adds 10ms to the startup of Emacs.

As if Emacs wasn't waiting 4.5 seconds to load 250 packages already :)

Maybe a better redacting of the commit message:

This commits changes the Emacs wrapper, in order to preload all autoload definitions when built with additional packages. The list of all definitions is generated at build-time. Packages do not need to be (require)d for them to work.
Before this change, a code like
nix-shell -I "nixpkgs=$PWD" -p "emacs.pkgs.withPackages(e:[e.magit])"  --run "emacs -Q -nw -f magit"

will fail with the message Error: "Symbol’s function definition is void: magit"
After the change, the same code above will open Emacs with magit enabled.
A slightly longer startup time of ~10ms was detected in local, informal experiments.

Updated

I have made one small additional change in which I now also byte-compile ( and optionally native-compile ) this generated autoloads list. This may or may not help a little bit with larger package lists.

Let's risk a bit.

I am sorry, to have caused this trouble. It seems that this is caused when building the wrapper with an empty package list. I will try to fix the issue.

I can confirm that your fix as solved the issue for me.

I will prepare a PR for this.

For reference, this can be tested with this line:
nix-shell -I nixpkgs=$PWD -p "emacsNativeComp.pkgs.withPackages(e:[])" --run "emacs -Q -nw"

I also want to build some tests for this wrapper in the future to catch these things.

I think this also broke emacsclient since the wrapper is also used for it and it adds -l cl-loaddefs -l nix-generated-autoload and -l is not supported by emacsclient.
❯ emacsclient README.md
/nix/store/wj5smb3gajv52wc2g6kqigcyhxf7hrfc-emacs-pgtkgcc-20220417.0/bin/emacsclient: unrecognized option '-l'
Try '/nix/store/wj5smb3gajv52wc2g6kqigcyhxf7hrfc-emacs-pgtkgcc-20220417.0/bin/emacsclient --help' for more information

😧 Let me fix this in the other PR too. Thank you for noticing.

@nagy this is a great idea indeed. However, my emacs is no longer able to run as a daemon after this change -- emacs --daemon --debug-init process seems to get stuck forever without any error.
I can confirm the new wrapper's "preload autoloads" caused the emacs daemon problem because after changing the last line of generated emacs from:
exec /nix/store/.../bin/emacs -l cl-loads -l nix-generated-autoload "$@"

to
exec /nix/store/.../bin/emacs -l cl-loads "$@"

the daemon works like before.
I believe it's some elisp package's autoload is the root cause, however that'll be hard to change and there are so many of them.
I guess we should make nix-generated-autoload optional. What do you think? @nagy

Yes I agree, this has already caused a greater fallout than I was expecting. I will make a PR that optionalizes this, with the default being off.
However, the generated nix-generated-autoload file consists of #'load calls which are called with arguments, that they should not raise errors. @myguidingstar , if you can figure out which packages caused the breakage for you, then I would be very curious.

Thank you very much. Too bad my nixfu is too terrible to automate this, while my list of elisp package is rather long to even bisect this, so I don't think I can provide the info any time soon :(

@nagy confusingly this didn't fix the autoloads problem I described. If I install haskell-mode for instance with this issues code, I still get an error because the haskell-doc autoload doesn't happen.

Thank you very much. Too bad my nixfu is too terrible to automate this, while my list of elisp pkgs is rather long to even bisect this, so I don't think I can provide the info any time soon :(

Can you list your elisp packages in case someone is interested in bisecting or debugging?

@nagy This problem of emacs not firing numerous autoloads for various packages is exactly what I'm seeing... but it's for recent niv sources for nixpkgs, home-manager, emacs-overlay etc.
Any suggested fixes or work-arounds would be great. Thanks!
problems
autoloads for lsp and treemacs don't appear to be loading properly (and likely various other packages also).
config
...
in
{
  imports = [
    nur.repos.rycee.hmModules.emacs-init
    nur.repos.rycee.hmModules.emacs-notmuch
  ];

  nixpkgs.overlays = [ (import sources.emacs-overlay) ];

  programs.emacs.init = {
...

      lsp-treemacs = {
        enable = true;
        after = [ "lsp-mode" "treemacs" ];
        command = [ "lsp-treemacs-errors-list" ];
        config = ''
          (lsp-treemacs-sync-mode 1)
        '';
      };

      treemacs = {
        enable = true;
        defer = true;
        bind = {
          "C-c t /" = "treemacs";
          "C-c t B" = "treemacs-bookmark";
          "C-c t 0" = "treemacs-select-window";
          "C-c t 1" = "treemacs-delete-other-windows";
          "C-c t d" = "treemacs-select-directory";
          "C-c t f" = "treemacs-find-file";
          "C-c t t" = "treemacs-find-tag";
        };
        config = ''
          (setq treemacs-python-executable "${python3}/bin/python3")
          (setq treemacs-follow-after-init t
                treemacs-project-follow-mode t
                treemacs-display-current-project-exclusively t
                treemacs-follow-mode t
                treemacs-filewatch-mode t
                treemacs-fringe-indicator-mode 'always)
          (treemacs-git-mode 'advanced)
          (add-to-list 'treemacs-pre-file-insert-predicates #'treemacs-is-file-git-ignored?)

          (autoload 'treemacs-create-dir "treemacs-file-management" nil t nil)
          (autoload 'treemacs-create-file "treemacs-file-management" nil t nil)
          ;;(autoload 'treemacs-common-helpful-hydra "treemacs-hydras" nil t nil)
        '';
        defines = [
          "treemacs-project-follow-mode"
        ];
      };

      treemacs-icons-dired = {
        hook = [ "(dired-mode . treemacs-icons-dired-enable-once)" ];
        enable = true;
        after = [ "treemacs" ];
        defer = true;
      };

      treemacs-magit = {
        enable = true;
        after = [ "treemacs" "magit" ];
        defer = true;
      };

niv
emacs-overlay
  branch: master
  description: Bleeding edge emacs overlay [maintainer=@adisbladis]
  homepage:
  owner: nix-community
  repo: emacs-overlay
  rev: 3571b94216954399d7c18e4b2f6df4372f447497
  sha256: 00jwhh25b87345hk95qg16d2yng15mqbk09aa9n6wcg0b4rdc8gx
  type: tarball
  url: https://github.com/nix-community/emacs-overlay/archive/3571b94216954399d7c18e4b2f6df4372f447497.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
home-manager
  branch: release-22.11
  description: Manage a user environment using Nix
  homepage: https://rycee.gitlab.io/home-manager/
  owner: nix-community
  repo: home-manager
  rev: b0be47978de5cfd729a79c3f57ace4c86364ff45
  sha256: 1gf97qpywcr6ckvwah3j5szrjl1xhv99w5jkbw2nlhj6w7j29cns
  type: tarball
  url: https://github.com/nix-community/home-manager/archive/b0be47978de5cfd729a79c3f57ace4c86364ff45.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
ligature.el
  branch: master
  description: Display typographical ligatures in Emacs
  homepage: <barabajagal>
  owner: mickeynp
  repo: ligature.el
  rev: 3d1460470736777fd8329e4bb4ac359bf4f1460a
  sha256: 1rnx2mp8y1phnvfirmf4a6lza38dg2554r9igyijl9rgqpjax94d
  type: tarball
  url: https://github.com/mickeynp/ligature.el/archive/3d1460470736777fd8329e4bb4ac359bf4f1460a.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
niv
  branch: master
  description: Easy dependency management for Nix projects
  homepage: https://github.com/nmattia/niv
  owner: nmattia
  repo: niv
  rev: 689d0e5539eddd0b0f566aee7bb18629eee7df74
  sha256: 1rld3lk42l6b01f2gcrhq8qm9vry1awmfl29zmpiqda9dy89vbx0
  type: tarball
  url: https://github.com/nmattia/niv/archive/689d0e5539eddd0b0f566aee7bb18629eee7df74.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
nixpkgs
  branch: nixpkgs-22.11-darwin
  description: Nix Packages collection
  homepage:
  owner: nixos
  repo: nixpkgs
  rev: 523b39618444fa921d3230c8f10f1563612d785d
  sha256: 0k8gn6cdnjls5scvb17w3zwqj3afhylcfwfc79747kkahrw8ylhd
  type: tarball
  url: https://github.com/nixos/nixpkgs/archive/523b39618444fa921d3230c8f10f1563612d785d.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
nur
  branch: master
  description: Nix User Repository: User contributed nix packages [maintainer=@Mic92]
  homepage: https://nur.nix-community.org/
  owner: nix-community
  repo: NUR
  rev: ae3612965891321559e354bfa9deabfbf0729b4f
  sha256: 17pmz9lmz5i9brh5vwkrvckw6v9s4ayshkipsmy8xn3xfx6prqg7
  type: tarball
  url: https://github.com/nix-community/NUR/archive/ae3612965891321559e354bfa9deabfbf0729b4f.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
emacs-overlay
  branch: master
  description: Bleeding edge emacs overlay [maintainer=@adisbladis]
  homepage:
  owner: nix-community
  repo: emacs-overlay
  rev: 3571b94216954399d7c18e4b2f6df4372f447497
  sha256: 00jwhh25b87345hk95qg16d2yng15mqbk09aa9n6wcg0b4rdc8gx
  type: tarball
  url: https://github.com/nix-community/emacs-overlay/archive/3571b94216954399d7c18e4b2f6df4372f447497.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
home-manager
  branch: release-22.11
  description: Manage a user environment using Nix
  homepage: https://rycee.gitlab.io/home-manager/
  owner: nix-community
  repo: home-manager
  rev: b0be47978de5cfd729a79c3f57ace4c86364ff45
  sha256: 1gf97qpywcr6ckvwah3j5szrjl1xhv99w5jkbw2nlhj6w7j29cns
  type: tarball
  url: https://github.com/nix-community/home-manager/archive/b0be47978de5cfd729a79c3f57ace4c86364ff45.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
ligature.el
  branch: master
  description: Display typographical ligatures in Emacs
  homepage: <barabajagal>
  owner: mickeynp
  repo: ligature.el
  rev: 3d1460470736777fd8329e4bb4ac359bf4f1460a
  sha256: 1rnx2mp8y1phnvfirmf4a6lza38dg2554r9igyijl9rgqpjax94d
  type: tarball
  url: https://github.com/mickeynp/ligature.el/archive/3d1460470736777fd8329e4bb4ac359bf4f1460a.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
niv
  branch: master
  description: Easy dependency management for Nix projects
  homepage: https://github.com/nmattia/niv
  owner: nmattia
  repo: niv
  rev: 689d0e5539eddd0b0f566aee7bb18629eee7df74
  sha256: 1rld3lk42l6b01f2gcrhq8qm9vry1awmfl29zmpiqda9dy89vbx0
  type: tarball
  url: https://github.com/nmattia/niv/archive/689d0e5539eddd0b0f566aee7bb18629eee7df74.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
nixpkgs
  branch: nixpkgs-22.11-darwin
  description: Nix Packages collection
  homepage:
  owner: nixos
  repo: nixpkgs
  rev: 523b39618444fa921d3230c8f10f1563612d785d
  sha256: 0k8gn6cdnjls5scvb17w3zwqj3afhylcfwfc79747kkahrw8ylhd
  type: tarball
  url: https://github.com/nixos/nixpkgs/archive/523b39618444fa921d3230c8f10f1563612d785d.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz
nur
  branch: master
  description: Nix User Repository: User contributed nix packages [maintainer=@Mic92]
  homepage: https://nur.nix-community.org/
  owner: nix-community
  repo: NUR
  rev: ae3612965891321559e354bfa9deabfbf0729b4f
  sha256: 17pmz9lmz5i9brh5vwkrvckw6v9s4ayshkipsmy8xn3xfx6prqg7
  type: tarball
  url: https://github.com/nix-community/NUR/archive/ae3612965891321559e354bfa9deabfbf0729b4f.tar.gz
  url_template: https://github.com/<owner>/<repo>/archive/<rev>.tar.gz

@ldeck What does your file wiring the niv overlays look like? What programs.emacs.package do you use? Do those emacsPackage versions match?

Okay the work-around is here: https://github.com/nix-community/emacs-overlay/issues/212

@ldeck What does your file wiring the niv overlays look like? What programs.emacs.package do you use? Do those emacsPackage versions match?

@ParetoOptimalDev See https://github.com/ldeck/nix-home/pull/6#issue-1619672565 (and recent commits) for more details

@ParetoOptimalDev To answer your question specifically (as I was in a rush before):
./switch.sh runs nix-shell --run "home-manager switch$ARGS".
This makes use of shell.nix which loads the niv sources.
let

  sources = import ./nix/sources.nix;

  nixpkgs = sources."nixpkgs";

  pkgs = import nixpkgs {};

in pkgs.mkShell rec {

  name = "home-manager-shell";

  buildInputs = with pkgs; [
    niv
    (import sources.home-manager {inherit pkgs;}).home-manager
  ];

  shellHook = ''
    export NIX_PATH="nixpkgs=${nixpkgs}:home-manager=${sources."home-manager"}"
    export HOME_MANAGER_CONFIG="./home.nix"
  '';

}

./home.nix loads the various modules defined in my nix-home.
But the nixpkgs in play when the config is being applied is the one from niv.
So then when my emacs module is enabled programs.emacs... will be using the niv defined one thanks to shell.nix.
{ config, pkgs, lib, ... }:

with lib;

let
  sources = import ../../nix/sources.nix;

  nur = import sources.nur { };

  pcfg = config.programs.emacs.init.usePackage;

  python3 = pkgs.python311;

  enableNotMuch = false && pcfg.notmuch.enable;

in
{
  imports = [
    nur.repos.rycee.hmModules.emacs-init
    nur.repos.rycee.hmModules.emacs-notmuch
  ];

  nixpkgs.overlays = [ (import sources.emacs-overlay) ];

  programs.emacs.init = {
    enable = false;
    packageQuickstart = false;
    recommendedGcSettings = true;
    usePackageVerbose = false;

    earlyInit = ''
    ...
    '';

    prelude = ''
      ;; See https://github.com/NixOS/nixpkgs/pull/168954
      (dolist (path load-path)
        (when (string-match-p "/nix/store/[a-z0-9]\\{32\\}-emacs-packages-deps.*" path)
          (dolist (autoload-file (directory-files path t "-autoloads.el"))
            (with-demoted-errors "init.el error: %s"
              (load autoload-file nil t)))))

        ...
    '';

    usePackage = {
        ...
    };
  };
}

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/home-manager-configured-emacs-not-configuring-autoloads/26087/2


How to specify hx-on:click etc?

I'm trying to figure out how to do something like <div hx-on:click="alert('Clicked!')">Click</div> with fasthtml.
Is this possible? There seems to be only an hx-on attribute, but here we actually want something like hx-on:click as the attribute which isn't a legal python argument name.
See https://htmx.org/attributes/hx-on/

Hey @corneliusroemer 👋🏻
This doc on FT Component attributes should provide the answer. 😄 If not, ping me by name and I'll reopen this ticket.

It does indeed, thanks @pydanny!
For those who don't want to go to the docs and find the answer, here it is:
Div(**{"hx-on:click": "alert('Hello World!')"})


Android image to texture bug

Godot version: Godot v3.1.1 stable win32
OS/device including version: Windows 7/PC and Android 6.0/ARM
Issue description: When use the ImageTexture function create_from_image(), the output texture failed to be recognized in android while it runs ok in desktop.
Steps to reproduce:
Create a new Image.
Load a png file in it.
Resize,colorize or do somenthing with it.
Create new ImageTexture.
Use ImageTexture.create_from_image() with the former Image.
Create new Sprite.
Assign Sprite.texture=ImageTexture
In Windows it works just fine, the sprite shows the modified Image texture. In android, nothing but empty sprites.
Minimal reproduction project:
No point, it will be a empty screen.

is png file loaded successfully?

Yes. As I said, it works fine in desktop, so the file loads properly.  Same code, failed in android.

It would seem a "path" problem, but without a minimal project to analyze it is difficult to fix.

you can't say png is loaded successfully on android because it works on pc.
on windows, a file can be loaded regardless of capital letters with the path.
like res://image.PNG can be loaded with res://image.png
but not on android or other platforms.

It´s not a path issue, to the extent of my knowledge. Same path loaded into a sprite works fine both in desktop/android. Loaded trought the expalined pipeline Image->ImageTexture->Sprite.texture, failed only in android. I just check again for the thrid time.

Maybe it's a format problem? Do you have ETC/ETC2 ticked in project settings?

@Bethleem can you share a reproducible project?

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


MNT mark tests requiring internet

Marking the test which requires internet, and is much slower than others.
Fixes #43
cc @skops-dev/maintainers

Love a green CI!

@adrinjalali I resolved a merge conflict. If you're fine with the outcome, let me know and we can merge this.

Yes. looks good to me!


Generate a Brew cask Formula

If users could cask install new updates instead of downloading them from Github, this would streamline the distribution process.

As reference: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/discord.rb
This also allows us to simplify the cleanup process going forward.

Not that it's a good metric but this repo probably has enough stars by now to qualify for a cask: https://docs.brew.sh/Acceptable-Casks#rejected-casks

Submitted a cask for consideration: https://github.com/Homebrew/homebrew-cask/pull/161585

October is now available via Homebrew: brew install --cask october.
You'll need to run brew update the first time to pull in the cask definition


Revision is missing from the clone

Followed the example to clone a package.
Cli throws error that --revision is invalid flag.
$ kpt alpha rpkg clone  test-catalogue-93b612f846d238c0ee3cae8441f2e924d07eeca1  foo --repository=test-catalogue --revision=v1
error: unknown flag: --revision

Expected behaviour

Cli to clone a repository should support revision.

The documentation is outdated, sorry about that! Revisions now get assigned upon publishing, and draft package revisions are uniquely identified by their workspaceName.
You should be able to run this successfully:
$ kpt alpha rpkg clone  test-catalogue-93b612f846d238c0ee3cae8441f2e924d07eeca1  foo --repository=test-catalogue --workspace=my-workspace

I will update the documentation.


Generator should not mark "constant" property settable

Example: https://github.com/Azure/azure-rest-api-specs/blob/b5d8eef5bf187dc99f1c18e8323b19e0c37a7124/specification/storage/resource-manager/Microsoft.Storage/stable/2021-08-01/storage.json#L2753
Generated Code: https://github.com/Azure/azure-sdk-for-net/blob/49cf740213ff3e31d280b9607bf2554a6fd4d966/sdk/storage/Azure.ResourceManager.Storage/src/Generated/Models/VirtualNetworkRule.cs#L43
Instead of this generated code, we would like the generated code to be like:
public string Action { get; }

It is a constant, therefore it should never change

Reported by storage team

What makes Action a constant?  The link you have above shows a default value, but doesn't say its constant?  Are we implying its constant because the enum has only 1 value?  If so that is dangerous if they ever add another value.

What makes Action a constant? The link you have above shows a default value, but doesn't say its constant? Are we implying its constant because the enum has only 1 value? If so that is dangerous if they ever add another value.

Sorry the line might be misleading - nothing to do with the default, the generated result will not change if we remove the default.
Modeler will generate modelAsString: false enums (sealed choices) with only one value as a ConstantSchema, and we generate a property with ConstantSchema in this way.
I have a POC of the fix in this PR now: https://github.com/Azure/autorest.csharp/pull/2174


C1774 signup changes

CartoDB/cartodb-central#1731
Multi-part PR
We are tracking this in the central PR: CartoDB/cartodb-central/pull/1774

Added do not merge yet because we need to open a new ticket only for the migration.

Both fields should take the same space than website field, for example.

Did the backend change.

Acceptance accomplished! Found just those 3 things. Taking care of the frontend ones.

The problem about the name in the dropdown comes from the user_decorator, it only includes the first name, not both, could you take care of it @javitonino ?


[#182952356]: Default Aspect Ratio option limits interactive height to viewport.

This PR makes several fixes to support different aspects of interactive sizing. In working on this story it became clear that the "Manual" and "Default" options weren't always working properly. In the first case it was because custom_native_width and custom_native_height weren't overwriting the interactive's native_width and native_height. In the latter case there were a number of issues that have been addressed.
To see the differences this PR makes I think it is helpful to run this activity both in activity player and in this branch on localhost and compare them against one another.

I've merged the pinning PR into master so now this PR is targeting master instead of that PR.
I made a tag off of master beforehand so I could continue to compare all 3 versions of the code.

Before these interactive sizing changes.
https://activity-player.concord.org/version/pre-interactive-sizing-updates/?activity=https%3A%2F%2Fauthoring.concord.org%2Fapi%2Fv1%2Factivities%2F9620.json
After first PR https://github.com/concord-consortium/activity-player/pull/381:
https://activity-player.concord.org/branch/pinned-interactive-bug/?activity=https%3A%2F%2Fauthoring.concord.org%2Fapi%2Fv1%2Factivities%2F9620.json
This PR: https://activity-player.concord.org/branch/limit-height-to-viewport/?activity=https%3A%2F%2Fauthoring.concord.org%2Fapi%2Fv1%2Factivities%2F9620.json

Note: One thing missing from the test activity are the headers and reset buttons around most of the interactives. I'm not sure it is worth adding them to this activity. The activity serves 2 purposes:

to explain to authors how things behave
to help developers test changes
So adding the headers and reset buttons would help the 2nd, but will make things even more complicated for authors.

I figured out the flicker was just because I had the developer tools open. 🤦 So nothing to fix there.
So the things remaining to do are:

handling inherit logic for aspect_ratio_method on full-width code in embeddable.tsx
handle inherit logic for native width and height
explain why 20 pixels are taken out of responsive width

Github messed up the "threading" so this comment got put in the wrong place: https://github.com/concord-consortium/activity-player/pull/382#discussion_r987135048


IBAction functions connected in nib files to UITextfields are not called

I’m using Visual Studio 2017. In releases 0.2 170411 (Apr 7, 2017) and 0.2 170228 (Feb 28, 2017), IBAction functions connected in nib files to UITextfields are not called. Adding the same IBActions programmatically to the UITextfields loaded from nib does work. Affects at least UIControlEventEditingChanged and UIControlEventEditingDidEnd events.

Was this working for you in Visual Studio 2015?  Do you have a repro app you could share?

I have not tried it with VS 2015 and I don't have a repro app.

Thank you, we'll prioritize this accordingly.


Fix SyncUI not being updated

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #6233

Details of Changes
Add details of changes here.

Fixes SyncUI not being updated: SyncUI need to be constructed on the main thread

Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

@hez2010 thank you!


Feat/faucet changes

Mobile view
Default to connected wallet when wallet is connected
Change color of "Come back in hh:mm:ss after requesting"
Only make API request when address is complete in External address (This will help us ping the API less)
Get tx hash in order to navigate to testnet when claim is done

Branch has conflicts

It's not like in the design

It's not like in the design

It's not like in the design

Link from the notification center opens wrong explorer

Request button isn't disabled when address isn't valid

wrong placeholder

@Ishkhan
, what action should be triggered when the floating notification is clicked?
@Anton
the notification list should open below the Notifications button (edited)
https://g7dao.slack.com/archives/C073H2C4BMK/p1728031153577929?thread_ts=1727795961.178169&cid=C073H2C4BMK


MaxDate next month button fix

Fixed an issue where the next month button would always be hidden when a maxdate was set.  The logic needs to be the opposite for a mindate vs maxdate however it was attempting to use the same function for both

Ah, Nice catch. For future reference - can you edit the files in the src folder not the dist folder as the the file you edited is actually a compiled file so it'll get overwritten. (Also it's really hard to spot the changes to the templates in this view).

I pushed another commit.  This time it's at least 10% more better :)

Awesome, thanks. I'll get this merged in later.

Apologies for the delay - got a heap of work and forgot about it. I'm finding some time to work on this soon.


Added Scrolling

Able to scroll from step to step

Oop my bad didn't mean to push that! I'll roll it back later today (note that the scrolling isn't smooth - as of yet)

OK, it's not really scrolling but more a 'mouse wheel' support.
It seems nice, but I don't think it necessary and may be confusing. To be honest I'd probably expect mouse wheel to zoom in/out that to move next/prev.
There are also some not very nice coding practices used there (I've commented on the commit itself).
So I won't merge it at this point. But I'll keep that in mind.
When the impress API will be ready, so that next, prev, etc methods will be available it would be possible to add such feature as optional 'plugin'.
Thanks!


Dark Mode and Macbook with dark theme

Describe the bug
When you set dark theme on macbook and run the app on chrome (WEB), the library return always dark theme
To Reproduce
Run the app on a macbook with dark theme set.
Try ti switch to light theme. It doesn't work.
If macbook theme is on light or automatic non problem occur.
Library version 2.1.0
Flutter version 2.0.4
MacOS Big Sure 11.2.3
BR

@teipeps I was able to reproduce this. It seems that due to some recent changes this is happening. Old versions seems to be working fine. I'll fix this as soon as possible.

@BirjuVachhani TNKS !!!!!

@teipeps Fixed in v2.1.1


QT Creator & Dlib

Hi,
I spend 4 hours to figure out to integrate  dlib to my Qt Create project which I already successfully added Opencv.
I compiled as usual and give the below parameters tofaceRec.pro in qt project:
`#-------------------------------------------------
QT       += core gui
greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
TARGET = faceRec
TEMPLATE = app
DEFINES += QT_DEPRECATED_WARNINGS
SOURCES +=
main.cpp
mainwindow.cpp
../Downloads/dlib-19.8/dlib/all/source.cpp
HEADERS +=
mainwindow.h
FORMS +=
mainwindow.ui
#INCLUDEPATH += -L/Users/alpullu/Downloads/dlib-19.8/dlib
#LIBS += -L/Users/alpullu/Downloads/dlib-19.8/build/dlib
INCLUDEPATH += -L/Users/alpullu/Downloads/DLIB-lib/include
LIBS += -L/Users/alpullu/Downloads/DLIB-lib/lib
LIBS += -ldlib
QMAKE_CXXFLAGS += -std=c++11  -I/opt/X11/include -v
INCLUDEPATH += -L/opt/X11/include/X11
LIBS += -pthread
CONFIG += link_pkgconfig
CONFIG +=c11
#PKGCONFIG += x11
`
I also added the all/source.cpp  to the my project source .
Also put dlib/dlib folder to my project .
I got :
"_XwcTextPropertyToTextList", referenced from:
dlib::get_from_clipboard(std::__1::basic_string<wchar_t, std::__1::char_traits<wchar_t>, std::__1::allocator<wchar_t> >&) in source.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
How we can use dlib from qt Creator?
I chosed this qt standard way. there is also cmake project alternative in Qt Creator but needs too much effort.
Best
thx.

very sadly :)  it makes me crazy, Qt . Yes great tool but if you stuck you stuck . and have to wait next prophet :)
thanks

I don't understand the problem. Dlib is C++, so is Qt. Qt doesn't make the process any easier.
Heck I can open a dlib example app and start writing Qt in it.
Qt works perfectly with CMake. Dlib works perfectly with qmake.

you can use https://github.com/mshobeyri/QFaceRecognition repo that is a qt/qml wrapper on dlib.


Add specification for computing the matrix transpose (matrix_transpose)

This PR:

adds a specification for computing the transpose of a matrix (or a stack of matrices).

Background
The addition of a matrix_transpose API is meant to replace the use of the transpose API. The transpose API was found to be problematic due to its API supporting more general axes permutation (see gh-228).
Similar to other linear algebra APIs, the proposed matrix_transpose API operates on stack of matrices and thus more succinctly and explicitly allows expressing matrix operations in accordance with mathematical intuition and obviates the need for doing transpose(x, axes=[-2,-1]) whenever wanting to perform a batched matrix transpose. Batching is the default behavior.
The matrix_transpose API serves as a functional complement to the proposed .mT attribute (see gh-246).

Adding the matrix_transpose was discussed in the consortium meeting held 09-02-2021. No objections were raised, as this PR provides the desired behavior of batched matrix transpose.
Merging...


Add the ability to disable items

With my server, I'm personally not a fan of paxels, tree axes, and excavators. Please add the ability for us to disable the crafting recipes for all types of items in the configuration .json.

You do that with data packs now

How/where do I get that from?

If you mean by using a recipe datapack to make the materials air and the resultant item a barrier block, that's not removing the item, that's making it uncraftable. It will still show in REI and the like.

when mojang added the registry freeze, disabling items/blocks via config is no longer recommended.  Disabling via datapack or KubeJS is preferred.

I don't have a pre-made datapack for that mod.  you can make it yourself or wait until I make one.

Are you using 1.18.2 or 1.19?

1.18.2. We'll be updating to 1.19 in about 2 weeks, just waiting for mods to be stable.

I can use KubeJS to block the recipes.


Fix locationHint to use local path URIs

Fixes @goneall's concern about using file: URI scheme for locationHint.


KOGITO-2546  Refactor process/rules/decision-specific config out of ApplicationConfig

A lot of the logic in ApplicationConfig is really for ProcessConfig. We can move this logic in a generated ProcessConfig class, and generate that as well. Same for other type of configs (rules, decisions)

Create different config classes depending on the underlying runtime (CDI, Spring, None -- i.e. codegen tests)
Use templates for different types of runtime for code clarity

The code looks "more" but it's actually being substituted by templates, and I think the clarity has improved a lot. There are less conditional branches that insert framework-specific logic to the generated classes, and instead there are framework-specific templates, so it's easy to see what goes where.
The framework-agnostic codegen has been preserved -- it has its own template when appropriate.
Expect more of this to come (re: Application.java and Process/Decision.java, etc.)
https://issues.redhat.com/browse/KOGITO-2546

I am adding a bunch of reviewers, not because they're all necessary, but because they might be interested, as this was a conversation we had, or it was something we may have tangentially discussed.

@cristianonicolai @danielezonca @tiagodolphine I am merging this because it's been sitting here and I don't want to risk more conflicts ( had one today :) ). We can further refine with more PRs!


fix: correct external topology metric name

We used kindling_entity_request  to name those request metrics captured from the server-side which shows the working status of the service, the key to identifying server-side metrics is a label named 'is_server'.
That makes a mistake when we are trying to use server-side metrics to show topology from outside the cluster.
The generated topology should be named with the prefix kindling_topology_request, but now they are named with the prefix kindling_entity_request since the  'is_server' label is true.
This PR will fix this.

Please update the changelog.


update mutect regex to better handle sample name extraction

The previous regex fails when there are lines in the bam header like this, which contain the SM tag as well as trailing information, all of which gets captured.
@PG     ID:bwa.2        PN:bwa  VN:0.7.12-r1039 CL:bwa mem -t 8 -T 0 -R @RG\tCN:BI\tDT:2010-03-12T00\tID:61D5N.8\tLB:Solexa-21878\tPL:illumina\tPU:61D5NAAXX100312.8\tSM:TCGA-AB-2821-03B-01W-0728-08 /alignment/reference/GRCh38.d1.vd1.fa /alignment/scratch1yVgmO/fastq/rmdup/61D5N.8_1.fq.gz /alignment/scratch1yVgmO/fastq/rmdup/61D5N.8_2.fq.gz
This change restricts to looking at @RG lines and only captures the sample name.
It will fail on sample names with spaces in them, but a space in a filename is a space in one's soul. (and I'm fairly confident that there are other places in these pipelines that would break with spaces as well)

I'm a little confused by this change.  The previous regex is taken directly from 1.3 of the SAM specification.  That makes me think this is an invalid case this change is trying to handle?  (It's not quite clear to me what's a tab vs a space vs a newline in that example header.)

Here's a little more context from this header, which is taken straight from the NCI genomic data commons.
@PG                 ID:bwa              PN:bwa              VN:0.7.12-r1039     CL:bwa mem -t 8 -T 0 -R @RG\tCN:BI\tDT:2010-03-12T00\tID:61D5N.4\tLB:Solexa-21878\tPL:illumina\tPU:61D5NAAXX100312.4\tSM:TCGA-AB-2821-03B-01W-0728-08 /alignment/reference/GRCh38.d1.vd1.fa /alignment/scratch1yVgmO/fastq/rmdup/61D5N.4_1.fq.gz /alignment/scratch1yVgmO/fastq/rmdup/61D5N.4_2.fq.gz
@PG                 ID:bwa.1            PN:bwa              VN:0.7.12-r1039     CL:bwa mem -t 8 -T 0 -R @RG\tCN:BI\tDT:2010-03-12T00\tID:61D5N.6\tLB:Solexa-21878\tPL:illumina\tPU:61D5NAAXX100312.6\tSM:TCGA-AB-2821-03B-01W-0728-08 /alignment/reference/GRCh38.d1.vd1.fa /alignment/scratch1yVgmO/fastq/rmdup/61D5N.6_1.fq.gz /alignment/scratch1yVgmO/fastq/rmdup/61D5N.6_2.fq.gz
@RG                 ID:61D5N.4          CN:BI               DT:2010-03-12T00:00:00+0000             LB:Solexa-21878     PL:illumina         PU:61D5NAAXX100312.4                    SM:TCGA-AB-2821-03B-01W-0728-08
@RG                 ID:61D5N.6          CN:BI               DT:2010-03-12T00:00:00+0000             LB:Solexa-21878     PL:illumina         PU:61D5NAAXX100312.6                    SM:TCGA-AB-2821-03B-01W-0728-08

The regex as exists matches SM:... multiple times in this header.  It matches on the @RG lines, which is expected, but also matches the command line string, where fields were specified explicitly as inputs with \t (not tab characters), thus giving the first result as:
TCGA-AB-2821-03B-01W-0728-08 /alignment/reference/GRCh38.d1.vd1.fa /alignment/scratch1yVgmO/fastq/rmdup/61D5N.8_1.fq.gz /alignment/scratch1yVgmO/fastq/rmdup/61D5N.8_2.fq.gz

(matches the SM field, plus everything folllowing it)
After review, you're right that we could also solve this by restricting the existing code to only look at @RG lines (I misunderstood how the pattern matching was working in that regex).  I'll make that modification and test it.

Thanks for the explanation!  Including the tab in the regex preceding the SM: could solve this (since the command line must necessarily escape it). Restricting to @RG lines seems like a good idea, too.

I was going to go with /^@RG.+SM:([ -~]+)/, but do I understand right that you're suggesting /^@RG.+\tSM:([ -~]+)/?

Yeah, I'd include a \t.  (I might hope nobody makes a library name with SM: in it, but y'never know 😄)

modified and tested - ready for re-review!


fix interdc blocking

This small change fixes a bug that could cause the interDC layer to block, resulting in updates from other DCs to buffer forever.  It only happens with 3 or more DCs, and usually needs a high update rate at multiple DCs.  The problem happens when two updates from two different DCs arrive at a third DC and each of them depend on a timestamp for the other DC that is more recent than the latest timestamp received at the third DC.  (Note that the reason why they are not processed until their dependencies are satisfied is so that updates are sent to the materialiser in causal order)
To fix this, when an update cannot be applied due to its dependencies not being met, the "received time" for the DC that sent this update is increased to 1 minus the commit time of this update.  This is safe to do because updates from an external DC are processed in the order of their commit time.
Note that these are per "shard" dependencies, so the visibility of these updates is still governed by the global stable time.

Would it be possible to write a (riak-)test to cover the scenario?

I will try to come up with something.  It's a bit tricky because it depends on the timing of messages and physical clocks, but I can probably instrument something.
On this topic though, we should really have some automated test that runs a cluster of several nodes at high load for a few minutes, then at the ends check that the results are 'correct'.  Something like this would be extremely helpful on many levels of debugging, performance testing.

Test added, this blocks in master, but runs here.


[now dev] should warn if no source files matched by builds

I've refactored the project structure a bit and moved handlers into a sub-directory, updated routes in now.json, but forgot to update builds. now dev was returning HTTP 404 whatever URL I specify. An attempt to deploy the project helped me to figure out the problem:

It would be nice if now dev also provided such assistance.

This was fixed by https://github.com/zeit/now-cli/pull/2594.


Project still maintained?

@mitch-dc Are you still maintaining this, do you need help in looking after this and working through some of the super simple PRs?

Having now upgraded to 2024.11, this integration has stopped working.
I’m praying that this integration can be maintained, it’s a brilliant integration 🤞🤞

@ryaaanmorgan Feel free to try out my fork, where I copied a fix that was proposed here.
https://github.com/I7L0/volkswagen_we_connect_id

Me too, after last update has topped working.
I tried to copy the ITL0's fork, but doesn't work :-(

He guys
Ive merged some of the prs and will take a look at some maintance asap.
My car was broken for a while (half dead battery after 110k km) and life is busy.
Car is back! Life is still busy but will make some updates!

Would be nice to get it working again. My installation isn't loading since some time either. If you need the log just let me know!

Would be nice to get it working again. My installation isn't loading since some time either. If you need the log just let me know!

Go to My Volkswagen and accept the new agreement, then it will work like before.

Unfortunately no, it does not.

ONE day later it stopped working again.  After that it is running now some weeks.


Add header to get public images. Cut source links.

All thanks to @tommoor for this fix 🙌
Summary

Use the new public-file-urls-expire-in header to fetch Linear markdown with public image URLs
Remove image source links and their swapping logic

Test Plan

Open a ticket with an image to the issue markdown via Linear. Ensure the image renders on GitHub.
Edit the ticket with more images. Ensure new and old images render on GitHub.
Repeat from GitHub. Ensure the image renders on Linear (there is some flash of "could not load image" before it re-uploads)

Related Issues
Closes #114

Great stuff, this will help me a ton 🙏🏻🫡


How to add conditions on one property with AND between

Seems like a stupid question, but how do I generate a query like this one:
MATCH (someNode:SomeLabel)
WHERE someNode.someProperty > 1 AND someNode.someProperty < 100

I want to be able to add any type of conditions, not just < and >, so please don't tell me to use between 😛
Since you need to pass an object to and, it seems like there's no way to combine multiple conditions on a single property

Hey Thomas,
That's a good pickup. Definitely a bug that I will try to look at.
In the meantime, the only other workaround I can recommend is to add a space after the property name for each condition you want to check on. Very hacky, but it may or may not be a cleaner workaround than the one you came up with:
new cypher.Query().where({
  someNode: {
    someProperty: cypher.greaterThan(1),
    ['someProperty ']: cypher.lessThan(100),
  },
}).toString();
// WHERE someNode.someProperty > $someProperty AND someNode.someProperty  < $someProperty2;

I believe #99 and #14 would fix this issue, allowing you to write:
new cypher.Query().where({
  someNode: {
    someProperty: cypher.and([cypher.greaterThan(1), cypher.lessThan(100)]),
  },
}).toString();
// WHERE someNode.someProperty > $someProperty AND someNode.someProperty  < $someProperty2;

Hey Thomas,
That's a good pickup. Definitely a bug that I will try to look at.
In the meantime, the only other workaround I can recommend is to add a space after the property name for each condition you want to check on. Very hacky, but it may or may not be a cleaner workaround than the one you came up with:
new cypher.Query().where({
  someNode: {
    someProperty: cypher.greaterThan(1),
    ['someProperty ']: cypher.lessThan(100),
  },
}).toString();
// WHERE someNode.someProperty > $someProperty AND someNode.someProperty  < $someProperty2;

Oh I didn't think of that, that's definitely a better workaround than what I did 😄
I can try to open a PR for https://github.com/jamesfer/cypher-query-builder/issues/14 next week
Thanks a lot for this lib btw, it has already helped a lot 🙏


python311Packages.google-cloud-vision: 3.6.0 -> 3.7.0

Changelog: https://github.com/googleapis/python-vision/blob/v3.7.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 289045 run on x86_64-linux 1

4 packages built:

python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist
python311Packages.layoutparser
python311Packages.layoutparser.dist


Refresh tests button is shown twice

One is from the python extension.
vscode-mocha-test-adapter	hbe	2.13.3
vscode-test-explorer	hbe	2.21.1
python	ms-	2022.5.11111003
vscode-pylance	ms-	2022.4.2
jupyter	ms-	2022.4.1001171005
jupyter-keymap	ms-	1.0.0
jupyter-renderers	ms-	1.0.6
test-adapter-converter	ms-	0.1.6

@karthiknadig Python should adopt the native refreshHandler which will fix this.


Handle NA reference_allele for some INS

Reference_allele should be - but in many studies they are NA or multiple -.

I guess it doesn't hurt to do this but the data should and will be fixed: https://github.com/cBioPortal/datahub/issues/621

@jjgao That would be great! Thanks! But maybe I can still do it for now, since it doesn't hurt and not so complicated


Version 0.9.1 bug

Since the upgrade, I no longer get a batch save when I click "Save" in Image Picka.  Instead I get a separate Windows "Save As" page for each image, which I then have to save individually.

Yeah batch download shouldn't use saveAs option:
https://github.com/eight04/image-picka/blob/dc4baa70c39241b3510a365c386c27ef69356654/extension/background/background.js#L407


add "delete current row" to mouse navigation

It's already supported via keyboard command d l

Should work now.

added in 4919bdcbb89f793be509187c2bb92287e47f0123 (thx @labusch)


Optimize unstream loop (3x better on micro benchmark)

Affected macro benchmarks' improvement range from 2%  to 34%. More details are available in the commit message.
I have also added corresponding micro benchmarks. Also added strictness annotation for replicateCharI args.
This change was motivated by a perf measurement for pure Haskell unicode normalization code that I am working on. While comparing the performance with text-icu normalization I found that just stream/unstream with no other processing in between was taking more time than what text-icu was taking for normalizing English text. Now, with this change stream/unstream is performing better than that.

Really nice work, thank you!