Define the Acronym or link to document on otr

otr notation is vague and should be defined better for the subscription api
https://rocket.chat/docs/developer-guides/realtime-api/subscriptions/stream-notify-user
https://github.com/RocketChat/Rocket.Chat.Docs/blame/master/6. Developer Guides/Realtime-API/2. Subscriptions/2. Stream Notify User/README.md#L8

I figured it out from using the source  off the record
https://github.com/RocketChat/Rocket.Chat/blob/7b1e076cbcd6d33eb24dd4cf40e32cce5a62643e/packages/rocketchat-otr/package.js


PC Standalone App performs worse than when running on UnityEditor

System information

OS Platform and Distribution (e.g., Linux Ubuntu 20.04): Windows10
Target Platform: Windows10
MediaPipeUnityPlugin version or commit id: 0.7
Bazel version:
GCC/G++ version:

Describe the current behavior
I am using the system with a Kinect azure camera which is activated as a webcam stream. However handtracking works at very low fps (20) instead of 30 fps (camera framerate) when running in sync mode (I compute delta time for fps at each new output that is drawn).  Inside Unity Editor it works at 30 fps
Describe the expected behavior
It should work at 30fps also outside the Unity Editor.
Steps to reproduce the issue
I have only added a fps checking in the sync if in handtrackingsolution. The issue is observed only when building the system as executable and running it outside editor.
Full logs
Player.log
Additional context
The system works perfectly fine inside the editor

What's the resolution of your display? I was doing some tests here: when I'm using a 4K resolution the GPU reaches 100% of usage. When I change to FullHD there's no delay because GPU is only 50%.  Is that your case?
PS. I'm not using the new version of the plug-in

I have a screen with 1280x720 resolution which is also the camera resolution.  I haven't observe any saturation problem, os resources demand is high but does not saturate resources either in Editor and outside. I am running the code on a minipc with Intel Core i5-10300H (quad-core 2.5 GHz, up to 4.5 GHz) and NVIDIA GeForce RTX 2060 6GB GDDR6 192-bit

Ok, since it's not the same case, I'll investigate more about my problem and maybe open another issue.

@homuler could you provide me a feedback?

I'm not sure, but if the problem doesn't occur in UnityEditor, I feel it's a problem with the build settings on your side.
Please try or answer the below.

Use the latest version (i.e. v0.8.2)
Share the command you ran to build the library (e.g. python build.py build --desktop cpu -vv)
Share the diff

I have only added a fps checking in the sync if in handtrackingsolution.

If you've changed build settings, share the diff, too.
If possible, find out which lines in particular take longer time

@homuler thanks for your reply. While I try your suggestions, I have identified these differences in the log files produced by the run in the editor (Editor.log) and the run in build (Player.log). In Player.log there isn't the message about Tensorflow Lite delegate, is it possible that the delegate is missing? I have also noticed that it seems like some assets are not found, a c and a dll file...can you confirm me that this behaviour is normal?

I have also noticed that it seems like some assets are not found, a c and a dll file

You can ignore these messages safely.

In Player.log there isn't the message about Tensorflow Lite delegate, is it possible that the delegate is missing?

If XNNPACK delegate is not used, it can explain why it runs slower, but it looks like to me that the Glog logs are simply not being output to Player.log.
By the way, the sample app of the latest version is configured to be built in development mode by default.
I don't know which version you're using, so I'm not sure, but are you comparing performance in that state?

@homuler I have tried installing the lastest version and running it in debug mode, but the result is the same (the development build works at half the fps with respect to running the sample app in the Unity Editor. I have setup everything according to your Windows 10 tutorial.  Could it be something related to the fact that I am using Windows 10 Pro as operating system?

@homuler would it work if I add to build command you suggest in the tutorial the option  --define tflite_with_xnnpack=true to ensure that XNN PACK delegate is used in any case?

I just tested it, and XNNPACK delegate is being used properly, but I could confirm that the performance seems to be degraded even in my environment.

So where could this reduction in performance come from? I had a lot of D9002 and D9025 warning during build related to tflite and delegate, for example:
INFO: From Compiling tensorflow/lite/tflite_with_xnnpack_optional.cc:
cl : warning from command line D9002 : unknown option '-O3' will be ignored
which is also cited here https://github.com/tensorflow/tensorflow/issues/37744
and about D9025
INFO: From Compiling absl/base/internal/spinlock_wait.cc:
cl : warning from command line D9025 : override of '/w' with '/W3'
Are they normal? Could they be relevant? You find all of them in the txt file in my previous comment (sorry they are in italian but u can find them using the warning code).
Thanks for ur replies, I am available for further investigation.

I did not find any significant difference in performance when measured using Stopwatch.
Can you confirm?
diff --git a/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs b/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs
index f1a78a1..4e6b2fa 100644
--- a/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs
+++ b/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs
@@ -8,6 +8,8 @@ using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;

+using Stopwatch = System.Diagnostics.Stopwatch;
+
 namespace Mediapipe.Unity.HandTracking
 {
   public class HandTrackingSolution : Solution
@@ -21,6 +23,7 @@ namespace Mediapipe.Unity.HandTracking
     [SerializeField] private TextureFramePool _textureFramePool;

     private Coroutine _coroutine;
+    private Stopwatch _stopwatch;

     public RunningMode runningMode;

@@ -50,6 +53,7 @@ namespace Mediapipe.Unity.HandTracking
       }
       base.Play();
       _coroutine = StartCoroutine(Run());
+      _stopwatch = new Stopwatch();
     }

     public override void Pause()
@@ -123,6 +127,8 @@ namespace Mediapipe.Unity.HandTracking
       SetupAnnotationController(_handLandmarksAnnotationController, imageSource, true);
       SetupAnnotationController(_handRectsFromLandmarksAnnotationController, imageSource, true);

+      _stopwatch.Start();
+
       while (true)
       {
         yield return new WaitWhile(() => isPaused);
@@ -139,10 +145,12 @@ namespace Mediapipe.Unity.HandTracking
         if (runningMode == RunningMode.Sync)
         {
           // TODO: copy texture before `textureFrame` is released
+          _stopwatch.Restart();
           _screen.ReadSync(textureFrame);

           // When running synchronously, wait for the outputs here (blocks the main thread).
           var value = _graphRunner.FetchNextValue();
+          Debug.Log(_stopwatch.ElapsedMilliseconds);
           _palmDetectionsAnnotationController.DrawNow(value.palmDetections);
           _handRectsFromPalmDetectionsAnnotationController.DrawNow(value.handRectsFromPalmDetections);
           _handLandmarksAnnotationController.DrawNow(value.handLandmarks, value.handedness);

Yes, I can confirm the behaviour...

I see what u meant, but you are only evaluating inference time, whereas the way in which I measured time was including the full time from graph output to next graph output (including point visualization on screen) so the two approach cannot really be compared. Hence, could be the issue related not to inference time but to the full visualization procedure (I still experience the problem).

I see. Please try this.
diff --git a/Assets/Mediapipe/Samples/Common/Scripts/WaitForResult.cs b/Assets/Mediapipe/Samples/Common/Scripts/WaitForResult.cs
index 6fbb3b2..ea31325 100644
--- a/Assets/Mediapipe/Samples/Common/Scripts/WaitForResult.cs
+++ b/Assets/Mediapipe/Samples/Common/Scripts/WaitForResult.cs
@@ -53,6 +53,14 @@ namespace Mediapipe.Unity
             break;
           }
           tmpResult = _inner.Current;
+
+          if (_inner.Current is CustomYieldInstruction customYieldInstruction)
+          {
+            if (!customYieldInstruction.keepWaiting)
+            {
+              continue;
+            }
+          }
         }
         catch (Exception e)
         {
diff --git a/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs b/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs
index f1a78a1..69371a7 100644
--- a/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs
+++ b/Assets/Mediapipe/Samples/Scenes/Hand Tracking/HandTrackingSolution.cs
@@ -8,6 +8,8 @@ using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;

+using Stopwatch = System.Diagnostics.Stopwatch;
+
 namespace Mediapipe.Unity.HandTracking
 {
   public class HandTrackingSolution : Solution
@@ -21,6 +23,7 @@ namespace Mediapipe.Unity.HandTracking
     [SerializeField] private TextureFramePool _textureFramePool;

     private Coroutine _coroutine;
+    private Stopwatch _stopwatch;

     public RunningMode runningMode;

@@ -50,6 +53,7 @@ namespace Mediapipe.Unity.HandTracking
       }
       base.Play();
       _coroutine = StartCoroutine(Run());
+      _stopwatch = new Stopwatch();
     }

     public override void Pause()
@@ -123,18 +127,25 @@ namespace Mediapipe.Unity.HandTracking
       SetupAnnotationController(_handLandmarksAnnotationController, imageSource, true);
       SetupAnnotationController(_handRectsFromLandmarksAnnotationController, imageSource, true);

+      long a, b, c, d, e, f;
+
       while (true)
       {
+        _stopwatch.Restart();
         yield return new WaitWhile(() => isPaused);

         var textureFrameRequest = _textureFramePool.WaitForNextTextureFrame();
         yield return textureFrameRequest;
         var textureFrame = textureFrameRequest.result;
+        a = _stopwatch.ElapsedMilliseconds;

         // Copy current image to TextureFrame
         ReadFromImageSource(imageSource, textureFrame);
+        b = _stopwatch.ElapsedMilliseconds;

         _graphRunner.AddTextureFrameToInputStream(textureFrame).AssertOk();
+        c = _stopwatch.ElapsedMilliseconds;
+        d = e = c;

         if (runningMode == RunningMode.Sync)
         {
@@ -143,13 +154,18 @@ namespace Mediapipe.Unity.HandTracking

           // When running synchronously, wait for the outputs here (blocks the main thread).
           var value = _graphRunner.FetchNextValue();
+          d = _stopwatch.ElapsedMilliseconds;
           _palmDetectionsAnnotationController.DrawNow(value.palmDetections);
           _handRectsFromPalmDetectionsAnnotationController.DrawNow(value.handRectsFromPalmDetections);
           _handLandmarksAnnotationController.DrawNow(value.handLandmarks, value.handedness);
           _handRectsFromLandmarksAnnotationController.DrawNow(value.handRectsFromLandmarks);
+          e = _stopwatch.ElapsedMilliseconds;
         }

         yield return new WaitForEndOfFrame();
+        f = _stopwatch.ElapsedMilliseconds;
+
+        Debug.Log($"FrameRequest: {a}, Copy: {b - a}, Send: {c - b}, Fetch: {d - c}, Render: {e - d}, Yield 2: {f - e}");
       }
     }

When the app runs at 60FPS, it takes about 16ms to wait for one frame, which seems to cause this issue.

I tried the code you provided me. There is  quite a huge gap in the time for the frame request (2/3 ms vs >9 ms). Where do you think this issue could come from?

So can we think the above code solve this issue?

Where do you think this issue could come from?

I wrote that in my comment above.

When the app runs at 60FPS, it takes about 16ms to wait for one frame, which seems to cause this issue.

The gap between the two versions (editor and build) is still not completely closed though even using your code (I suppose the modification you are talking about is the one in WaitForResult.cs)...Why is it not possible to have the same frame request time in both the versions?

I see, so you were talking about the time gap between running on UnityEditor and Standalone.
You'll have to ask Unity developers why it runs so fast in UnityEditor, but it all boils down to this comment.

When the app runs at 60FPS, it takes about 16ms to wait for one frame, which seems to cause this issue.

Try this sample code if you're interested (I tested in an (almost) empty project).
using System.Collections;
using System.Collections.Generic;
using UnityEngine;

using Stopwatch = System.Diagnostics.Stopwatch;

public class CoroutineTest : MonoBehaviour
{
  // Start is called before the first frame update
  void Start()
  {
    StartCoroutine(Run());
  }

  private IEnumerator Run()
  {
    var stopwatch = new Stopwatch();

    while (true)
    {
      long a, b, c;
      stopwatch.Restart();

      yield return new WaitWhile(() => false);
      a = stopwatch.ElapsedMilliseconds;

      yield return new WaitUntil(() => true);
      b = stopwatch.ElapsedMilliseconds;

      yield return new WaitForEndOfFrame();
      c = stopwatch.ElapsedMilliseconds;

      Debug.Log($"WaitWhile: {a}, WaitUntil: {b - a}, WaitForEndOfFrame: {c - b}");
    }
  }
}

Here are excerpts of the logs when I ran it in my environment.

Editor.log
...
WaitWhile: 0, WaitUntil: 0, WaitForEndOfFrame: 1
WaitWhile: 0, WaitUntil: 0, WaitForEndOfFrame: 1
WaitWhile: 0, WaitUntil: 1, WaitForEndOfFrame: 0
WaitWhile: 0, WaitUntil: 0, WaitForEndOfFrame: 1
...

Player.log
...
WaitWhile: 16, WaitUntil: 17, WaitForEndOfFrame: 0
WaitWhile: 16, WaitUntil: 17, WaitForEndOfFrame: 0
WaitWhile: 16, WaitUntil: 16, WaitForEndOfFrame: 1
WaitWhile: 16, WaitUntil: 17, WaitForEndOfFrame: 0
...

After all, I guess we should avoid to yield IEnumerator if not necessary.

Yes, I confirm that the issue is related to those yeld instruction.

We are finding the same issue here, in Editor the responsiveness is much faster than the build. Is there anything we can do to help solve this?

Thanks for your hard work on this @homuler 🧡

I think this issue is resolved by #471 and #472 because now the yield instruction is called only once in each loop when running in synchronous mode.
However, as mentioned in https://github.com/homuler/MediaPipeUnityPlugin/issues/428#issuecomment-1026435131, if the built app runs at 60FPS, each sample scene may run faster on UnityEditor.
If the app can run in your environment at the same FPS as in UnityEditor, the new Non-Blocking sync mode should run faster than the synchronous mode.
If the issue is not fixed, please let me know.

Just to add to this, if anyone is confused why their app runs worse in build than editor still, if you goto Project Settings > Quality and for any quality settings you have including default, set VSync Count to 'Don't Sync' so that your build can run faster than the refresh rate of the monitor you are using.


Dragging while the text selection toolbar is up should close it

On Flutter desktop, it's currently possible to keep the text selection toolbar open and updating while you drag some selection around:

Steps to reproduce

Run an app with a text input, such as the example below, on desktop.
Right click somewhere on the text to open the text selection toolbar.
Left click and drag somewhere else on the text.

Expected: The menu closes and selection does not change (tested on Linux).
Actual: The menu stays open and selection begins.

Code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(title),
      ),
      body: const Center(
        child: TextField(),
      ),
    );
  }
}

investigated this, looks like an easy fix, need to write test tho.


mixing uuid's with strings

Bug description
Prisma throws an error when mixing uuid's with plain strings

How to reproduce

Schema

model User {
  id Int @id @default(autoincrement())
  values String[]
}

Add data

const items = [
  'sample 1 string',
  '7fb1aef9-5250-4cf6-92c7-b01f53862822',
  'sample 3 string',
  '575e0b28-81fa-43e0-8f05-708a98d55c14',
  'sample 5 string',
]

 await prisma.user.create({
    data: {
      values: {
        set: items,
      },
    },
  })

Prisma throws the above error (screenshot)
Expected behavior
It should insert the strings correctly
Environment & setup

OS: Debain
Database: Postgres
Prisma version: 2.0.0
Node.js version: 12.17.0

I can confirm this issue, thanks for the detailed report.

thanks so much @ryands17!

Thanks a lot for reporting 🙏
This issue is fixed in the latest dev version of @prisma/cli.
You can try it out with npm i -g @prisma/cli@dev.
In case it’s not fixed for you - please let us know and we’ll reopen this issue!


Port to 1.18

Haven't changed the readme or mods.toml to credit me for the port as it was pretty trivial. If you want to credit feel free though.

This looks fine, but I'm not entirely sure about where the apache license bit comes in? This mod is MIT licensed

I'm not sure where you're getting an apache license from? I just based it off the 1.17 branch

Oh I was mistaken -- something to do with the gradle files I read incorrectly

https://github.com/eerussianguy/Better-Foliage/commit/fde244a9298c671d696155575aca24b441ae852b

Thanks for the work you've been putting in around the modding community -- it is people like you that keep the community going. For real


Entire subtitles are shown in the first few seconds for some videos

Expected behavior: Subtitles to be readable throughout the entire video
Actual behavior: The entire subtitles are shown in the first few seconds, without any more for the rest of the video
Steps to reproduce: Run pipe-viewer https://www.youtube.com/watch?v=_FCZnrUq3N4
Screenshot:

Additional details:
Config: pipe-viewer.conf.gz
The mangled subtitles of videos affected by this bug I've seen: affected-subs.tar.gz
If I set a breakpoint in GetCaption.pm:221 and run p $xml, I get the following output: _FCZnrUq3N4.xml.gz
I've figured out the cause by looking at yt-dlp's source code. If you're fine with that, then open the following section:

In GetCaption.pm:221, if I get $url, remove the tlang parameter, and fetch the URL with wget, the output looks fine. Additional links:

https://github.com/yt-dlp/yt-dlp/blob/01aba2519a0884ef17d5f85608dbd2a455577147/yt_dlp/extractor/youtube.py#L4324
https://github.com/yt-dlp/yt-dlp/issues/2956#issuecomment-1059849276

Given that there's a commit that uses code from yt-dlp, I'm assuming that using information from yt-dlp to fix this bug is fine? If so, let me know so that I can take a jab at this


[Hub Generated] Review request for Microsoft.Billing to add version 2018-11-01-preview

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-java

Can one of the admins verify this patch?

Automation for azure-sdk-for-net
A PR has been created for you:
https://github.com/azure/azure-sdk-for-net/pull/5602
.NET SDK Commits:
https://github.com/adxsdknet/azure-sdk-for-net/pull/5602/commits/259be18b00e377e4d141151f0527cc72a1c4e365

startbuild

startbuild

@majastrz Can you provide ARM feedback for this please?

      },

Another asynchronous GET

Refers to: specification/billing/resource-manager/Microsoft.Billing/preview/2018-11-01-preview/billing.json:436 in 90e03b4. [](commit_id = 90e03b4d5e0828cd03d06a49e2c854d026c26f0e, deletion_comment = False)

@jhendrixMSFT Thanks - we've opened a bug to clean up the operation ids in a future PR (before we publish corresponding SDKs).

@AutorestCI regenerate azure-sdk-for-go


[T2A2][T05-A3] Marx Low

Used refractor, extract local variable to field, Line 1173

You have created this PR against the wrong repo :-)


Audit the libraries for Node compatibility

I've been trying to get the breadboard working on Vercel - it looked simple, however it ran up against an issue straight away where CustomEvent is not defined. This was because Vercel runs Node 18 LTS and CustomEvent is classed as Experimental.
There might be other APIs being used which mean the code might not be able to run on cloud providers (it looks like Firebase Functions might be ok)

Update: a lot of the main projects work, below will be a list of things that need to change.

Breadboard uses CustomEvent which can be enabled with an environment variable NODE_OPTIONS='--experimental-global-customevent', this will mean however that the code will not work in Node 16.


Redgifs low quality

Ripme version:1.7.95
Java version:
Operating system: Win10

Exact URL you were trying to rip when the problem occurred: https://www.reddit.com/user/TheEmilyLynne/
Please include any additional information about how to reproduce the problem:
RipMe only donwloads gifs from Redgifs in mobile-quality (low quality), last time I used RipMe I always got the highest available quality.

Expected Behavior
The highest available quality should be downloaded.
Actual Behavior
It only downloads the Gifs in low quality.

Duplicate of issue #1857

Duplicate of issue #1875


Feature request: animation abort controller

Hi, when animation a camera position I would love to have an abort controller support so I can relinquish camera control to the user if they start trying to move the view.
Currently I use my own camera moving scripts and do this
const controller = new AbortController();
const canvas = scene.getEngine().getRenderingCanvas();

const onFocus = () => controller.abort();

canvas?.addEventListener('focus', onFocus);
canvas?.addEventListener('wheel', onFocus);

// move camera
await Promise.all([
  animateCameraTo(camera, scene, controller.signal),
  animateCameraTo({ ...camTarget, prop: 'target', duration: 500 }, scene, controller.signal),
]);

canvas?.removeEventListener('focus', onFocus);
canvas?.removeEventListener('wheel', onFocus);

and I think it would be a great addition to the run function.

You can save result of animation and stop them when it need.
this.pointAnimatables = EasyPropAnimation.run(camera, {
  target: newTarget,
  transition: 'all 1s linear',
});

private stopPointAnimation(): void {
  this.pointAnimatables?.forEach((animatable) => animatable.stop());
}


Small tweaks to journald logging

Two changes to better match docker functionality:
Change MESSAGE_ID to CONTAINER_ID_FULL, as well as add CONTAINER_ID (truncated at 12 characters)
Change stdout output to an info instead of a notice log level
Also small change with where the log buffer is null terminated
Now, the callee doesn't depend on an unchecked invariant that num_read < strlen(buf)
Signed-off-by: Peter Hunt<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

@giuseppe @mrunalp @rhatdan PTAL

/ok-to-test

Codecov Report

Merging #2171 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2171   +/-   ##
=======================================
  Coverage   31.46%   31.46%
=======================================
  Files          76       76
  Lines        6770     6770
=======================================
  Hits         2130     2130
  Misses       4522     4522
  Partials      118      118

/retest

changes LGTM

/retest

/hold
(I have one more thing I'm trying to implement)
On Tue, Mar 26, 2019, 12:19 PM Giuseppe Scrivano<EMAIL_ADDRESS>wrote:

@giuseppe approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cri-o/pull/2171#pullrequestreview-219006754,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIqYJ4VWnekCnLd4ah6HEdwE89ZxKXhYks5vakhrgaJpZM4cKPbd
.

/hold cancel

Note: I'd love to have a test for CONTAINER_PARTIAL_LINE but the only way I have been able to cause it is by running podman with a top container and sending it sigkill. Any advice would be nice :)

/retest

Note: I'd love to have a test for CONTAINER_PARTIAL_LINE but the only way I have been able to cause it is by running podman with a top container and sending it sigkill. Any advice would be nice :)

I was testing partial lines with something similar to podman run fedora sh -c 'printf hello; sleep 1'

/teat e2e_rhel

/retest

/test e2e_fedora

/lgtm

/test e2e_rhel

/retest
On Wed, Mar 27, 2019 at 3:29 PM OpenShift CI Robot<EMAIL_ADDRESS>wrote:

@haircommander https://github.com/haircommander: The following test
failed, say /retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_fedora 17cbc3a
https://github.com/kubernetes-sigs/cri-o/commit/17cbc3a9cae03b70800afe0d1feb7162c8829f07
link
https://openshift-gce-devel.appspot.com/build/origin-federated-results/pr-logs/pull/kubernetes-sigs_cri-o/2171/test_pull_request_crio_e2e_fedora/2118/ /test
e2e_fedora
Full PR test history
https://openshift-gce-devel.appspot.com/pr/kubernetes-sigs_cri-o/2171. Your
PR dashboard https://openshift-gce-devel.appspot.com/pr/haircommander.
Please help us cut down on flakes by linking to
https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests
an open issue
https://github.com/kubernetes-sigs/cri-o/issues?q=is:issue+is:open when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cri-o/pull/2171#issuecomment-477314828,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIqYJ9NcbywPFaWJS74kSEEusDkGSIJCks5va8aKgaJpZM4cKPbd
.

/retest
On Wed, Mar 27, 2019, 4:58 PM OpenShift CI Robot<EMAIL_ADDRESS>wrote:

@haircommander https://github.com/haircommander: The following test
failed, say /retest to rerun them all:
Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_fedora 17cbc3a
https://github.com/kubernetes-sigs/cri-o/commit/17cbc3a9cae03b70800afe0d1feb7162c8829f07
link
https://openshift-gce-devel.appspot.com/build/origin-federated-results/pr-logs/pull/kubernetes-sigs_cri-o/2171/test_pull_request_crio_e2e_fedora/2129/ /test
e2e_fedora
Full PR test history
https://openshift-gce-devel.appspot.com/pr/kubernetes-sigs_cri-o/2171. Your
PR dashboard https://openshift-gce-devel.appspot.com/pr/haircommander.
Please help us cut down on flakes by linking to
https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests
an open issue
https://github.com/kubernetes-sigs/cri-o/issues?q=is:issue+is:open when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/cri-o/pull/2171#issuecomment-477344796,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIqYJyVYzXSXk7p9nCf5mfu8c9vQEPC4ks5va9tqgaJpZM4cKPbd
.

Huh I have the label And happy tests... Can someone try to trigger it again?

I seek approval
@umohnani8 @mrunalp @giuseppe

LGTM

LGTM

Can someone throw me a /approve? :)

/approve

Not sure I've the juice to /approve, but we'll see.

/approve


[RFC]: add @stdlib/assert/is-same-accessor-array

Description
This RFC proposes adding a new assertion package to test whether two arguments are both accessor arrays and have the same values.
Package: @stdlib/assert/is-same-accessor-array
Alias: isSameAccessorArray
Related Issues
No.
Questions
No.
Other
@stdlib/assert/is-same-array-like provides a reference implementation. One should only need to

update descriptions
use is-accessor-array
update tests
update examples and documentation

Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

I'd Love to work on this issue.

@example
var Complex128Array = require( '@stdlib/array/complex128' );
var isSameAccessorArray = require( '@stdlib/assert/is-same-accessor-array' );

var x = new Complex128Array( [ 1, 2, 1, 2 ] );
var y = new Complex128Array( [ 1, 2, 1, 2 ] );

var out = isSameAccessorArray( x, y );
// returns true

@example
var Complex128Array = require( '@stdlib/array/complex128' );
var isSameAccessorArray = require( '@stdlib/assert/is-same-accessor-array' );

var x = new Complex128Array( [ 1, 2, 1, 2 ] );
var y = new Complex128Array( [ 2, 1, 2, 1 ] );

var out = isSameAccessorArray( x, y );
// returns false

@example
var Complex128Array = require( '@stdlib/array/complex128' );
var isSameAccessorArray = require( '@stdlib/assert/is-same-accessor-array' );

var x = new Complex128Array( [ 1, 2, 1, 2 ] );
var y = [ 1, 2, 3 ];

var out = isSameAccessorArray( x, y );
// returns false

I've went through '@stdlib/assert/is-accessor-array' and i found out that only Complex64Array and Complex128Array are accepted as accessor arrays in<EMAIL_ADDRESS>Based on that I've come up with these examples, I hope this is what you're looking for @kgryte. I have a basic patch ready for this feature and i can raise a PR soon if you're satisfied with this. I'd love to correct myself if you feel that this is not what you were looking for.


OSMCha shows features and tags not edited in the selected changeset

I'm submitting a  bug report
Brief Description
OSMCha shows features and tags not edited in the selected changeset.
What  is the current behaviour?
For example, in changeset #114816402, only one feature has been edited but OSMCha shows two:

The other feature was edited in changeset #114816420.
Moreover, for the feature edited in the changeset OSMCha reports two tag changes, but only one was added. The other was added in changeset #114816412.

What  is the expected behaviour ?
Only changes in the current changeset should be shown.
When does this occur ?
Very often, especially with changeset made with StreetComplete.
Please tell us about your environment:
Firefox 95.0 on Fedora 35/x64_64.
Firefox 95.0 on Windows 10/x64_64.

That’s very likely an overpass API limitation. StreetComplete is known for uploading multiple versions of an object in a very short amount of time. Overpass cannot distinguish those object versions, in case they were created at the exact same hour:minute :second, giving you incorrect results for a particular changeset.

As @mmd-osm said, it's an issue on Overpass and StreetComplete

It is not a StreetComplete bug, as uploading multiple changesets shortly after each other is perfectly fine behaviour of OSM API.
Though it is anyway covered by #492

Depends a bit on your point of view. Every other editing app would merge multiple changes to the same object into a single object version upload only.
SC has its reasons to work differently. The more messages I see in my log files, the more I’m disagreeing with it.

Hmm, adding one second delay may be actually doable. Open issue on SC issue tracker once you will be sufficiently disagreeable with it.
(no promising anything as I have no idea how this code works, but maybe it is possible to achieve more friendly behaviour)

That’s very likely an overpass API limitation. StreetComplete is known for uploading multiple versions of an object in a very short amount of time. Overpass cannot distinguish those object versions, in case they were created at the exact same hour:minute:second, giving you incorrect results for a particular changeset.
Related discussion: streetcomplete/StreetComplete#2318 (comment)

I do not agree. Achavi is also based on overpass but it doesn't show this behaviour.
For example, changeset #114816412:
https://nrenner.github.io/achavi/?changeset=114816412

Let's take a look at the queries both tools are sending to the Overpass instances. First of all, you need to enable relations for Achavi, to have comparable queries: https://nrenner.github.io/achavi/?changeset=114816412&relations=true
Achavi: https://overpass-api.de/api/interpreter?data=[adiff:"2021-12-11T12:33:05Z","2021-12-11T12:54:14Z"];(node(bbox)(changed);way(bbox)(changed);relation(bbox)(changed););out%20meta%20geom(bbox);&bbox=8.0519203,45.5679148,8.052059,45.5685817
OSMCha: https://overpass.maptime.in/api/interpreter?data=[out:xml][adiff:"2021-12-11T12:32:58.000Z,","2021-12-11T12:54:14Z"];(node(bbox)(changed);way(bbox)(changed);relation(bbox)(changed););out%20meta%20geom(bbox);&bbox=8.0519203,45.5679148,8.052059,45.5685817
It seems that OSMCha is using an earlier start time: 12:32:58 vs. 12:33:05 in Achavi. Apart from this difference, I don't see other differences? Maybe this is reason for different results.

This is a case of changesets overlapping by time and bbox [1] (shortened):
c114816420 s2021-12-11T12:33:23Z e2021-12-11T12:54:14Z TStreetComplete:quest_type=AddBuildingLevels,
c114816412 s2021-12-11T12:33:06Z e2021-12-11T12:54:14Z TStreetComplete:quest_type=AddWayLit,
c114816402 s2021-12-11T12:32:59Z e2021-12-11T12:54:14Z TStreetComplete:quest_type=AddRoadSurface,

StreetComplete opens multiple changesets in parallel, one for each active quest.
Each changeset has only one modify edit, two editing the same object [2] (shortened):
  <way id="340649056" version="3" changeset="114816420" timestamp="2021-12-11T12:33:23Z"
  <way id="314892545" version="6" changeset="114816412" timestamp="2021-12-11T12:33:07Z"
  <way id="314892545" version="5" changeset="114816402" timestamp="2021-12-11T12:32:59Z"

Using the times and bbox of changeset 114816402 (metadata, OSMCha) for the Overpass adiff query, it returns changes from other changesets that are within the same time range and bbox:
<way id="314892545" version="6" timestamp="2021-12-11T12:33:07Z" changeset="114816412"
<way id="340649056" version="3" timestamp="2021-12-11T12:33:23Z" changeset="114816420"

https://overpass.maptime.in/api/interpreter?data=[out:xml][adiff:"2021-12-11T12:32:58.000Z,","2021-12-11T12:54:14Z"];(node(bbox)(changed);way(bbox)(changed);relation(bbox)(changed););out meta geom(bbox);&bbox=8.0519203,45.5679148,8.052059,45.5685817
As the adiff query only returns the state at the given start and end time, not changes in between, version 5 of way 314892545 for this changeset is missing because of the later change in version 6.
Other examples
by same user later in December (with filter listing all other changesets in edit session) [3]:

115164251
115015641 (S3 json elements not empty as in other examples (?), changes from changeset 115015640),
115015639,
115015637 (node<PHONE_NUMBER> v3 and v4 in same second)
114920616
114880955

What OSMCha could do

Filter out other changesets from the fallback query result.
I suppose this is already done in the server (see also changeset-map#103), therefore the elements property is empty in the S3 json.
Don't run the client-side fallback query when the server-side was successful and an empty result is expected with the current implementation
Request missing versions with an additional query, e.g. using timeline/retro (blog):[out:json];
timeline(way, 314892545, 5);
for (t["created"])
{
  retro (_.val)
  {
    way(314892545);
    out meta geom;
  }
}

Overpass Turbo
Limitation: does not work for same-second versions  (like node<PHONE_NUMBER> v3, Overpass Turbo)

Footnotes

[1] curl -s "https://www.openstreetmap.org/api/0.6/changesets?display_name=xxx&time=2021-12-11T12:32:59Z,2021-12-11T12:54:14Z" | osmium cat -F .osm.xml -f .opl
changesets API call using changeset 114816402 metadata user (anonymized), created_at and closed_at, formatted as osmium-tool OPL (object per line)
[2] curl -s https://www.openstreetmap.org/api/0.6/changeset/{114816420,114816412,114816402}/download | grep changeset
[3] get later changesets by user (anonymized), manually group into edit sessions (same/close changeset closed timestamp), check each session for empty json elements using Content-Length HTTP header

wget -qO - "https://www.openstreetmap.org/api/0.6/changesets?display_name=xxx&time=2021-12-11T12:32:59Z" | osmium cat -F .osm.xml -f .opl
curl -s --head https://s3.amazonaws.com/mapbox/real-changesets/production/{114816402,114816412,114816420}.json | grep "Content-Length"


Update NVIDIA partners' base image knob to use publicly available NGC images

Make NVIDIA's partners' submission code use NGC public image as the base image instead of private base images dropped to the partners.
The NGC public image (published before the submission deadline https://catalog.ngc.nvidia.com/orgs/nvidia/teams/mlperf/containers/mlperf-inference/tags ) has the same software stack used by NVIDIA submission and no regression will be observed with this change on partners' submissions.

@mrmhodak Please review and merge.


ROS2: Publish an array with rqt

Hi everyone, I have been using rqt to publish messages to test my applications, however I still haven't found a way to publish a message that includes an array.
In my custom message I have a variable size array declared as uint8[]. I notice in rqt that the expected type is "sequence".
I have tried different expressions, but couldn't figure out the correct one. Could someone provide an example please?

If we assume get_slot_types functions correctly, then my fix here allows us to publish arrays.  However, as mentioned in this related ticket, a much larger PR should probably be merged first, before addressing this issue.
If anyone has any guidance on the guidance to help get these changes through, I'll be happy to help where fit.

As porposed in #34 i tried to compile the rolling release and still got the error
Traceback (most recent call last):
  File "/colcon_ws/install/rqt_publisher/lib/python3.10/site-packages/rqt_publisher/publisher.py", line 158, in change_publisher
    new_text = handler(self._publishers[publisher_id], topic_name, new_value)
  File "/colcon_ws/install/rqt_publisher/lib/python3.10/site-packages/rqt_publisher/publisher.py", line 257, in _change_publisher_expression
    success, _ = self._evaluate_expression(computed_expression, slot_type)
  File "/colcon_ws/install/rqt_publisher/lib/python3.10/site-packages/rqt_publisher/publisher.py", line 376, in _evaluate_expression
    if successful_eval and isinstance(value, slot_type):
TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union

after i typed array('I',[1,2,3])
or got this error if i used array.array('I',[1,2,3])
[ERROR] [1673339078.788973249] [get_message_class]: Malformed message_type: sequence<uint32>
Python eval failed for expression "array.array('I',[1,2,3])" with an exception "type object 'array.array' has no attribute 'array'"
Publisher._evaluate_expression(): failed to evaluate expression: "array.array('I',[1,2,3])" as Python type "None"
Traceback (most recent call last):
  File "/colcon_ws/install/rqt_publisher/lib/python3.10/site-packages/rqt_publisher/publisher.py", line 158, in change_publisher
    new_text = handler(self._publishers[publisher_id], topic_name, new_value)
  File "/colcon_ws/install/rqt_publisher/lib/python3.10/site-packages/rqt_publisher/publisher.py", line 274, in _change_publisher_expression
    user_expression, slot_type.__name__)
AttributeError: 'NoneType' object has no attribute '__name__'. Did you mean: '__ne__'?

If i understood the other Issue #34 correctly this should have worked? I am using a UInt32 MultiArray

There is still no way, or at least no documented way on doing this. Can anybody help out?

Right now there is no way to do this since rqt_publisher does not support the array.array type and the common libraries don't support sequence<X> builtin types. I just submitted #39 to humble to fix both of these.
If you want to use it, strings are represented as normal lists, e.g.: ["joint_1", "joint_2"]
Numerical arrays are represented as array types, e.g.: array('d', [5.5, 4.5]) or array('i', [3, 2]).
See a complete list of numerical typecodes at https://docs.python.org/3/library/array.html


/api/interpreter does not respond after initial clone, times out with 504

With the following docker-compose.yml file, after initially cloning and then restarting the service, the logs indicate that everything starts up correctly.
When I make an API call however, the service only responds with an HTTP 504 gateway timeout.
volumes:
  overpass-db:

version: "3.8"
services:
  overpass_api:
    image: wiktorn/overpass-api
    restart: always
    ports:
      - "8080:80"
    volumes:
      - overpass-db:/db
    environment:
      - OVERPASS_RULES_LOAD="50"
      - OVERPASS_FASTCGI_PROCESSES="8"

The logs after the second startup of the service (after clone)
Starting overpass-server_overpass_api_1 ... done
Attaching to overpass-server_overpass_api_1
overpass_api_1  | Starting supervisord process
overpass_api_1  | 2022-01-10 22:01:26,383 CRIT Supervisor is running as root.  Privileges were not dropped because no user is specified in the config file.  If you intend to run as root, you can set user=root in the config file to avoid this message.
overpass_api_1  | 2022-01-10 22:01:26,384 INFO supervisord started with pid 1
overpass_api_1  | 2022-01-10 22:01:27,387 INFO spawned: 'overpass_dispatch' with pid 11
overpass_api_1  | 2022-01-10 22:01:27,389 INFO spawned: 'nginx' with pid 12
overpass_api_1  | 2022-01-10 22:01:27,392 INFO spawned: 'fcgiwrap' with pid 13
overpass_api_1  | 2022-01-10 22:01:27,394 INFO spawned: 'update_overpass' with pid 14
overpass_api_1  | 2022-01-10 22:01:27,397 INFO spawned: 'dispatcher_areas' with pid 15
overpass_api_1  | 2022-01-10 22:01:27,398 INFO spawned: 'areas_rules' with pid 16
overpass_api_1  | /app/bin /
overpass_api_1  | 2022-01-10 22:01:28,405 INFO success: overpass_dispatch entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
overpass_api_1  | 2022-01-10 22:01:28,405 INFO success: nginx entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
overpass_api_1  | 2022-01-10 22:01:28,406 INFO success: fcgiwrap entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
overpass_api_1  | 2022-01-10 22:01:28,406 INFO success: update_overpass entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
overpass_api_1  | 2022-01-10 22:01:28,406 INFO success: dispatcher_areas entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
overpass_api_1  | 2022-01-10 22:01:28,406 INFO success: areas_rules entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
overpass_api_1  | <?xml version="1.0" encoding="UTF-8"?>
overpass_api_1  | <osm version="0.6" generator="Overpass API 0.7.57 93a4d346">
overpass_api_1  | <note>The data included in this document is from www.openstreetmap.org. The data is made available under ODbL.</note>
overpass_api_1  | <meta osm_base=""/>
overpass_api_1  |
overpass_api_1  | After 0h0m15s: in "query", part 4, on line 13. Stack: 0 of 0 0 of 0

Does it work if you instead of cloning, download a small subset (such as Monaco)?
I don't even see the 504 response in the logs here so I'm not sure, if the requests reaches this container. Similar like this 404 that I've simulated below:
<IP_ADDRESS> - - [10/Jan/2022:22:11:05 +0000] "GET /nonexistent HTTP/1.1" 404 153 "-" "curl/7.79.1"

I will try a subset next. The timeouts were coming from the health check it looked like. If I open a browser to a nonexistent URL I get the following in the logs:
overpass_api_1  | 2022/01/10 22:18:10 [error] 33#33: *35 open() "/usr/share/nginx/html/nonexistent" failed (2: No such file or directory), client: <IP_ADDRESS>, server: localhost, request: "GET /nonexistent HTTP/1.1", host: "osm.audiom.xrnavigation.io"
overpass_api_1  | <IP_ADDRESS> - - [10/Jan/2022:22:18:10 +0000] "GET /nonexistent HTTP/1.1" 404 188 "-" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36"
overpass_api_1  | 2022/01/10 22:18:10 [error] 33#33: *35 open() "/usr/share/nginx/html/favicon.ico" failed (2: No such file or directory), client: <IP_ADDRESS>, server: localhost, request: "GET /favicon.ico HTTP/1.1", host: "osm.audiom.xrnavigation.io", referrer: "https://osm.audiom.xrnavigation.io/nonexistent"
overpass_api_1  | <IP_ADDRESS> - - [10/Jan/2022:22:18:10 +0000] "GET /favicon.ico HTTP/1.1" 404 188 "https://osm.audiom.xrnavigation.io/nonexistent" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36"

The failed health checks look like:
overpass_api_1  | 2022/01/10 22:22:36 [error] 33#33: *9 upstream timed out (110: Connection timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: localhost, request: "GET /api/interpreter?data=[out:json];node(1);out; HTTP/1.1", upstream: "fastcgi://unix:/nginx/fcgiwrap.socket", host: "localhost"
overpass_api_1  | <IP_ADDRESS> - - [10/Jan/2022:22:22:36 +0000] "GET /api/interpreter?data=[out:json];node(1);out; HTTP/1.1" 504 494 "-" "curl/7.64.0"

Any results with smaller subset?
The error message suggests problem with connecting to dispatcher, but there are no errors in the log showing, that it indeed failed.  That's strange.

Hi, I had a similar issue and fixed it by initializing a VM in Docker with more ram. Like I was using a VM with 4GB and when I set 8GB it worked perfectly (considering that I mounted Argentina region).

SImilar results over here, running on a 16GB VM in Docker
version: '3.5'
services:
  overpass:
    container_name: overpass
    image: wiktorn/overpass-api:<IP_ADDRESS>
    ports:
      - 6080:80
    volumes:
      - overpass-db:/db
    environment:
      - OVERPASS_META=no
      - OVERPASS_MODE=init
      - OVERPASS_PLANET_URL=http://download.geofabrik.de/europe/monaco-latest.osm.bz2
      - OVERPASS_DIFF_URL=http://download.openstreetmap.fr/replication/europe/monaco/minute/
      - OVERPASS_UPDATE_SLEEP=3600
      - OVERPASS_USE_AREAS=false
    healthcheck:
      test: ["CMD-SHELL", "curl -qf 'http://localhost/api/interpreter?data=[out:json];node(1);out;' | jq '.generator' | grep -q Overpass || exit 1"]
      start_period: 48h
volumes:
    overpass-db:

and all I'm getting is:
overpass  | <IP_ADDRESS> - - [02/Mar/2023:16:08:15 +0000] "POST /api/interpreter HTTP/1.1" 504 635 "-" "-"
overpass  | <IP_ADDRESS> - - [02/Mar/2023:16:08:18 +0000] "POST /api/interpreter HTTP/1.1" 504 635 "-" "-"
overpass  | <IP_ADDRESS> - - [02/Mar/2023:16:08:22 +0000] "POST /api/interpreter HTTP/1.1" 504 635 "-" "-"

@mmisztal1980 I tried your docker-compose and started it using:
$ docker-compose up

Once it completed to initialize the database, I started it again and
curl -v "http://localhost:6080/api/interpreter?data=\[out:json\];node(1);out;"
*   Trying <IP_ADDRESS>:6080...
* Connected to localhost (<IP_ADDRESS>) port 6080 (#0)
> GET /api/interpreter?data=[out:json];node(1);out; HTTP/1.1
> Host: localhost:6080
> User-Agent: curl/7.82.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Server: nginx/1.21.6
< Date: Fri, 03 Mar 2023 21:53:36 GMT
< Content-Type: application/json
< Transfer-Encoding: chunked
< Connection: keep-alive
<
{
  "version": 0.6,
  "generator": "Overpass API <IP_ADDRESS> 76e5016d",
  "osm3s": {
    "timestamp_osm_base": "2023-03-03T07:04:24Z",
    "copyright": "The data included in this document is from www.openstreetmap.org. The data is made available under ODbL."
  },
  "elements": [

  ]
}

So works perfectly fine. On console also looks good:
overpass  | <IP_ADDRESS> - - [03/Mar/2023:21:53:36 +0000] "GET /api/interpreter?data=[out:json];node(1);out; HTTP/1.1" 200 298 "-" "curl/7.82.0"

What kind of the POST requests you're sending to your instance?


products page

Products page

[x] Prisma model
[x] Set up uploading images
[x] UI

[x] Product Creation
[x] Uploading
[x] All products page

Done


docs: formatting is_odd as the other ops

Describe your changes
Prior to this PR:

After this PR:

Checklist before requesting a review

Repo forked and branch created from next according to naming convention.
Commit messages and codestyle follow conventions.
Relevant issues are linked in the PR description.
Tests added for new functionality.
Documentation/comments updated according to changes.

note: the second commit only aligns the table, probably easier to review these two commits independently


data modeling is not portable across backends

The Irmin_mem backend allows the user to store values at any point within key hierarchy, while the Irmin_git.FS backend does not. Rather than trying to describe the problem further in prose, consider the following pseudo-ish code:
Store.update (v "fst one") ["fst"] "ok" >>= fun () ->
Store.update (v "snd one") ["fst"; "snd"] "maybe?"

If Store is created from the Irmin_mem.Make functor, then both operations will succeed. On the other hand, if Store is created from the Irmin_git.FS functor, the second operation will fail with a Unix.Unix_error(Unix.ENOTDIR, "chdir", "/path/to/repo") exception.
The behavior I expected was for data modeling that I perform and verify to be correct using one backend will be just as correct when I switch to another backend. The behavior I observed was that this is not the case, at least for the in-memory and git backends.
I'm working with irmin 0.9.4.

This is indeed a bug due to changing back and forth the behaviour between releases. I am now convinced that the proper behaviour is to disallow contents in the nodes, e.g. to look like a normal filesystem. The Irmin_mem backend needs to be fixed.
Thanks for the report!

btw, 0.9.5 should be a bit better regarding the error message of the Git backend.

The new behaviour is now much stricter:

A node cannot be at the same time a filename and a directory anymore.
Irmin.update always overwrite the node kind:

if /fst is a file, then Irmin.update /fst/snd foo will make fst become a dirname.
if fst is a dirname, then Irmin.update /fst foo will make fst become a filename. All /fst/** will be automatically deleted.

This also needs a patch in ocaml-git to fix non-bare Git repositories.

One other possibility that crossed my mind last week was to allow any key to be used as a "file" and as a "directory". So, for example, you have the following operations
Irmin.update "/fst" "ok"
Irmin.update "/fst/snd" "maybe"

the filesystem this would produce is
/
|-- fst
    |-- __value__
    `-- snd
        `-- __value__

While this makes for a slightly messier filesystem, it provides much more flexible API. I suppose one drawback of this approach is that the semantics of delete aren't completely obvious.

This was indeed exactly like that at one point, but it causes all kinds of problems. I'm still unsure about the correct solution for this, but at least now it is consistant.

:+1: Feel free to close when the PR lands.


Jump to reference

the lsp-references command creates a buffer with references in the format: path_to_file:line:column.
I have created a small function to jump to the indicated location of such a reference.
I am not sure if this is worth including in kak-lsp, but if you want I can create a PR.
define-command open-location %{
    execute-keys xs^.*?(:\d+){1,2}<ret>
    evaluate-commands %sh{
        echo "edit $kak_selection" | sed -e "s/:/ /g"
    }
}

kak-lsp implicitly depends on https://github.com/mawww/kakoune/blob/master/rc/core/grep.kak for jumps (filetype of *references* buffer is grep), but it might worth adding this command straight into lsp.kak for those who don't use grep.kak.

Ah there is a grep-jump command, I couldn't find it.
I would say, make the optional dependency on grep.kak explicit and let users handle it.


Can't enter 2 factor code

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Picked up iOS development again. Started fresh with fastlane and ran into issues with 2 factor authentication. Fastlane never prompts me for my 2 factor code.
-> % bundle exec fastlane --version
fastlane 1.111.0

Complete output when running fastlane, including the stack trace and command used

Invalid 2 step response {"trustedPhoneNumbers"=>[{"numberWithDialCode"=>"•• (•••) •••-••27", "obfuscatedNumber"=>"(•••) •••-••27", "pushMode"=>"sms", "id"=>1}], "securityCode"=>{"length"=>6, "tooManyCodesSent"=>false, "tooManyCodesValidated"=>false, "securityCodeLocked"=>false}, "authenticationType"=>"hsa2", "recoveryUrl"=>"https://iforgot.apple.com/phone/add?prs_account_nm=[REDACTED]", "cantUsePhoneNumberUrl"=>"https://iforgot.apple.com/iforgot/phone/add?context=cantuse[REDACTED]", "recoveryWebUrl"=>"https://iforgot.apple.com/password/verify/appleid?prs_account_nm=[REDACTED]", "repairPhoneNumberUrl"=>"https://gsa.apple.com/appleid/account/manage/repair/verify/phone", "repairPhoneNumberWebUrl"=>"https://appleid.apple.com/widget/account/repair?#!repair", "aboutTwoFactorAuthenticationUrl"=>"https://support.apple.com/kb/HT204921", "autoVerified"=>false, "showAutoVerificationUI"=>false, "managedAccount"=>false, "supportsRecovery"=>true, "trustedPhoneNumber"=>{"numberWithDialCode"=>"•• (•••) •••-••27", "obfuscatedNumber"=>"(•••) •••-••27", "pushMode"=>"sms", "id"=>1}, "hsa2Account"=>true}
[23:45:51]: An error occured during the setup process. Falling back to manual setup!

Environment

Captured Output
Command Used: env
Output/Log

[23:42:47]: Generating fastlane environment output, this might take a few seconds...
✅ fastlane environment ✅

### Stack

| Key                 | Value                                       |
| ------------------- | ------------------------------------------- |
| OS                  | 10.13.4                                     |
| Ruby                | 2.3.7                                       |
| Bundler?            | true                                        |
| Git                 | git version 2.17.0                          |
| Installation Source | ~/.rbenv/versions/2.3.7/bin/fastlane        |
| Host                | Mac OS X 10.13.4 (17E199)                   |
| Ruby Lib Dir        | ~/.rbenv/versions/2.3.7/lib                 |
| OpenSSL Version     | OpenSSL 1.0.2o  27 Mar 2018                 |
| Is contained        | false                                       |
| Xcode Path          | /Applications/Xcode.app/Contents/Developer/ |
| Xcode Version       | 9.2                                         |

### System Locale

| Variable | Value       |   |
| -------- | ----------- | - |
| LANG     | en_US.UTF-8 | ✅ |
| LC_ALL   |             |   |
| LANGUAGE |             |   |

### fastlane files:

**No Fastfile found**

**No Appfile found**

### fastlane gems

| Gem                 | Version | Update-Status  |
| ------------------- | ------- | -------------- |
| credentials_manager | 0.16.4  | 💥 Check failed |
| fastlane_core       | 0.59.0  | 💥 Check failed |
| spaceship           | 0.39.0  | 💥 Check failed |
| cert                | 1.4.4   | 💥 Check failed |
| deliver             | 1.16.1  | 💥 Check failed |
| frameit             | 3.0.0   | 💥 Check failed |
| gym                 | 1.12.1  | 💥 Check failed |
| sigh                | 1.12.1  | 💥 Check failed |
| match               | 0.11.1  | 💥 Check failed |
| pem                 | 1.4.1   | 💥 Check failed |
| pilot               | 1.12.1  | 💥 Check failed |
| produce             | 1.3.2   | 💥 Check failed |
| scan                | 0.14.2  | 💥 Check failed |
| screengrab          | 0.5.6   | 💥 Check failed |
| snapshot            | 1.16.4  | 💥 Check failed |
| supply              | 0.8.0   | 💥 Check failed |
| fastlane            | 1.111.0 | 💥 Check failed |

### Loaded fastlane plugins:

**No plugins Loaded**

Loaded gems

| Gem                       | Version      |
| ------------------------- | ------------ |
| did_you_mean              | 1.0.0        |
| bundler                   | 1.16.1       |
| CFPropertyList            | 3.0.0        |
| concurrent-ruby           | 1.0.5        |
| i18n                      | 0.9.5        |
| minitest                  | 5.11.3       |
| thread_safe               | 0.3.6        |
| tzinfo                    | 1.2.5        |
| activesupport             | 4.2.10       |
| public_suffix             | 3.0.2        |
| addressable               | 2.5.2        |
| atomos                    | 0.1.2        |
| babosa                    | 1.0.2        |
| colored                   | 1.2          |
| highline                  | 1.7.10       |
| commander                 | 4.4.4        |
| security                  | 0.1.3        |
| credentials_manager       | 0.16.4       |
| excon                     | 0.62.0       |
| gh_inspector              | 1.1.3        |
| json                      | 1.8.6        |
| multi_json                | 1.13.1       |
| plist                     | 3.4.0        |
| rubyzip                   | 1.1.7        |
| terminal-table            | 1.4.5        |
| fastlane_core             | 0.59.0       |
| multipart-post            | 2.0.0        |
| faraday                   | 0.14.0       |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20170404 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| faraday_middleware        | 0.12.2       |
| fastimage                 | 1.6.8        |
| multi_xml                 | 0.6.0        |
| claide                    | 1.0.2        |
| fuzzy_match               | 2.0.4        |
| nap                       | 1.1.0        |
| cocoapods-core            | 1.4.0        |
| cocoapods-deintegrate     | 1.0.2        |
| cocoapods-downloader      | 1.1.3        |
| cocoapods-plugins         | 1.0.0        |
| cocoapods-search          | 1.0.0        |
| cocoapods-stats           | 1.0.0        |
| netrc                     | 0.11.0       |
| cocoapods-trunk           | 1.3.0        |
| cocoapods-try             | 1.1.0        |
| colored2                  | 3.1.2        |
| escape                    | 0.0.4        |
| fourflusher               | 2.0.1        |
| molinillo                 | 0.6.5        |
| ruby-macho                | 1.1.0        |
| nanaimo                   | 0.2.4        |
| xcodeproj                 | 1.5.7        |
| cocoapods                 | 1.4.0        |
| dotenv                    | 2.2.2        |
| mini_magick               | 4.5.1        |
| rouge                     | 2.0.7        |
| xcpretty                  | 0.2.8        |
| net-ssh                   | 4.2.0        |
| net-sftp                  | 2.1.2        |
| krausefx-shenzhen         | 0.14.11      |
| slack-notifier            | 1.5.1        |
| xcpretty-travis-formatter | 1.0.0        |
| jwt                       | 2.1.0        |
| little-plugger            | 1.1.4        |
| logging                   | 2.2.2        |
| memoist                   | 0.16.0       |
| os                        | 0.9.6        |
| signet                    | 0.8.1        |
| googleauth                | 0.6.2        |
| httpclient                | 2.8.3        |
| hurley                    | 0.2          |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| uber                      | 0.0.15       |
| representable             | 2.3.0        |
| retriable                 | 2.1.0        |
| google-api-client         | 0.9.28       |
| terminal-notifier         | 1.8.0        |
| word_wrap                 | 1.0.0        |
| xcode-install             | 2.0.9        |
| ocunit2junit              | 1.5.1        |

*generated on:* **2018-04-09**

[23:42:53]: Open https://github.com/fastlane/fastlane/issues/new to submit a new issue ✅

✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.4

Ruby
2.3.7

Bundler?
true

Git
git version 2.17.0

Installation Source
~/.rbenv/versions/2.3.7/bin/fastlane

Host
Mac OS X 10.13.4 (17E199)

Ruby Lib Dir
~/.rbenv/versions/2.3.7/lib

OpenSSL Version
OpenSSL 1.0.2o  27 Mar 2018

Is contained
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

credentials_manager
0.16.4
💥 Check failed

fastlane_core
0.59.0
💥 Check failed

spaceship
0.39.0
💥 Check failed

cert
1.4.4
💥 Check failed

deliver
1.16.1
💥 Check failed

frameit
3.0.0
💥 Check failed

gym
1.12.1
💥 Check failed

sigh
1.12.1
💥 Check failed

match
0.11.1
💥 Check failed

pem
1.4.1
💥 Check failed

pilot
1.12.1
💥 Check failed

produce
1.3.2
💥 Check failed

scan
0.14.2
💥 Check failed

screengrab
0.5.6
💥 Check failed

snapshot
1.16.4
💥 Check failed

supply
0.8.0
💥 Check failed

fastlane
1.111.0
💥 Check failed

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

bundler
1.16.1

CFPropertyList
3.0.0

concurrent-ruby
1.0.5

i18n
0.9.5

minitest
5.11.3

thread_safe
0.3.6

tzinfo
1.2.5

activesupport
4.2.10

public_suffix
3.0.2

addressable
2.5.2

atomos
0.1.2

babosa
1.0.2

colored
1.2

highline
1.7.10

commander
4.4.4

security
0.1.3

credentials_manager
0.16.4

excon
0.62.0

gh_inspector
1.1.3

json
1.8.6

multi_json
1.13.1

plist
3.4.0

rubyzip
1.1.7

terminal-table
1.4.5

fastlane_core
0.59.0

multipart-post
2.0.0

faraday
0.14.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.12.2

fastimage
1.6.8

multi_xml
0.6.0

claide
1.0.2

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.4.0

cocoapods-deintegrate
1.0.2

cocoapods-downloader
1.1.3

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.0.0

netrc
0.11.0

cocoapods-trunk
1.3.0

cocoapods-try
1.1.0

colored2
3.1.2

escape
0.0.4

fourflusher
2.0.1

molinillo
0.6.5

ruby-macho
1.1.0

nanaimo
0.2.4

xcodeproj
1.5.7

cocoapods
1.4.0

dotenv
2.2.2

mini_magick
4.5.1

rouge
2.0.7

xcpretty
0.2.8

net-ssh
4.2.0

net-sftp
2.1.2

krausefx-shenzhen
0.14.11

slack-notifier
1.5.1

xcpretty-travis-formatter
1.0.0

jwt
2.1.0

little-plugger
1.1.4

logging
2.2.2

memoist
0.16.0

os
0.9.6

signet
0.8.1

googleauth
0.6.2

httpclient
2.8.3

hurley
0.2

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.0.15

representable
2.3.0

retriable
2.1.0

google-api-client
0.9.28

terminal-notifier
1.8.0

word_wrap
1.0.0

xcode-install
2.0.9

ocunit2junit
1.5.1

generated on: 2018-04-09

Same problem here.
Session token expired, Fastlane requires for a new one but It can't give me the time to insert the code.

@cmckni3 @BubiDevs Heyyyy 👋 So, TBH, I don't use two factor on my accounts I use for fastlane (as I find it easier to have a separate account dedicated to fastlane stuff) but I think what you might be able to do to get a new prompt would be to open up Keychain Access and search for a password stored by fastlane / spaceship and delete that? That should hopefully reset you

Thanks @joshdholtz. I ended up creating a separate account last week.


不能下载了

我现在已经下载不了最新的版本了，
https://vscode-update.azurewebsites.net/latest/win32-x64-archive/stable
浏览器打不开这个

English please.
Try the link later. Everything is good for me.

我现在已经下载不了最新的版本了，
I can't download the latest version now.
https：
//vscode-update.azurewebsites.net/latest/win32-x64-archive/stable
浏览器打不开这个
· the browser can't open this

Still an issue? @octref any known update server issues?

It can't be downloaded on the Chinese Internet

The day before yesterday was fine

I wonder what happened

Does this link work for you? https://az764295.vo.msecnd.net/stable/64ce3f02d422c8c2c80455c6e711067ab7b58025/VSCode-win32-x64-1.36.0.zip


Adding support for 10 bit depth video?

There's a fair amount of H.264/AVC content out there using 10 bit depth video encoding formats. Would you please consider adding support for this?

More specifically the content is using the "High 10" profile with YUV420P10LE color space.

infringement of copyright 48 cfr 102 uk 48 cfr 101 japan farmer president international canabis project intellectual property meaning bussines requirements unlawful intrest in a public contract is a violation 2921.15 ohio merchabilty and fitness is a stand alone policy


fix(javascript): incorrect lsp formatting for tsx

Fixes https://github.com/emacs-lsp/lsp-mode/discussions/3308
lsp-mode doesn't detect the correct indentation, since it treats the derived tsx-mode as a web-mode. This change modifies the lsp-mode internal alist to recognize tsx-mode correctly. Ideally lsp-mode would have a better way to modify its known mode lists but I couldn't see it.

Thanks again for your help!


Clean up project

Minor cleanup before starting a huge optimization. This PR addresses some small issues and tidies up the codebase, laying the groundwork for more significant improvements and optimizations in the upcoming work.

manually tested. everything works as normal.


Dead libcurl-compat link

On the troubleshooting page here, the link for libcurl-compat in the Arch Linux section is dead. That package has been moved to Community here. If there is a more appropriate place for web admin stuff like that, please let me know.

Thanks, fixed. Updated online, will be fixed in the next dev release for offline docs.
And nope, this is a fine place for that report, thanks!


Standardize/cleanup timeouts in Go e2e tests

From @zmerlynn in PR#4269
We now have three timeout mechanisms that I know of in the system

There's this one, which is actually nice because it's "true".
There's this one: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/util.go#L43 (which uses the "sleep and add up the sleeps" method).
And then when I was porting Brendan's endpoints test, I gutted his goroutine based individual timeouts and actually forced the test into a full test timeout: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/service.go#L248 (which is the combination of that timeout and the "done Done" on the function signature).

I can't decide if we want fine-grained timeouts for individual actions or to just go through and profile whole tests, honestly. We probably want some combination of both.

I did some testing last week with the last form of timeout (the ginkgo native timeout). As is probably obvious, the biggest issue we're going to have is that any test that is using the defer SomeCleanupFunc(someResource) pattern to do a leaf cleanup at the end of the test is going to have issues, because Ginkgo, as it should, shoots the whole goroutine in the head and the defers never run.
Given that, I think the right approach is actually the following:

Each API action, or state loop should have an associated fine-grained timeout
Each test should have a full test timeout
Each test should be tolerant of its own resources being still around when it starts (i.e. before it tries to create foo, it should test for foo and delete it)
Jenkins should keep its full e2e run timeout (for "someone violated these rules")

This bug should be an umbrella to getting us there. I propose that the existing shell tests be ignored for this bug.

Personally, I think you should never create a resource called "foo" in e2e tests -- you should make a unique name for it by suffixing it with a string from the UUID library. That makes the test even more resilient to failed cleanup and allows multiple instances of the test to run in parallel.

Agreed. Changing my comment to match.
On Tue, Feb 17, 2015 at 4:39 PM, Satnam Singh<EMAIL_ADDRESS>wrote:

Personally, I think you should never create a resource called "foo" in e2e
tests -- you should make a unique name for it by suffixing it with a string
from the UUID library. That makes the test even more resilient to failed
cleanup and allows multiple instances of the test to run in parallel.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/4292#issuecomment-74787574
.

cc @quinton-hoole


Update ComputePressureObserver

Hello.
I have been working on updating our electron app to the latest electron version (20.0.1, previously we used 17.3.1) and we had a breakage in our use of babylon.js when the scene is disposed:

TypeError: Failed to execute 'unobserve' on 'ComputePressureObserver': 1 argument required, but only 0 present.

Note that not all electron applications will experience this problem. ComputePressureObserver is only exposed if you use experimentalFeatures: true.
It appears that electron 19 and up is using a Chromium version with an updated ComputePressureObserver API. Here is the relevant change in the working draft:

https://github.com/WICG/compute-pressure/issues/21
https://github.com/WICG/compute-pressure/pull/25

The error is ignored in observe but not in unobserve. My first commit here catches the error in unobserve. I first tried to use catch() like in observe but it didn't work so I had to use try { ... } catch {}. Even though it isn't documented in the spec, observe is returning a promise but unobserve is not.
The second commit updates the use of the observer to work with electron >= 19. This disables the observer for electron < 19 (ComputePressureObserver.supportedSources is not defined), but I don't think many will notice since the only thing this is used for is the CPU utilization metric in the Realtime Performance Viewer.

The spec appears to have more updates than what electron supports. Doesn't look like the samplerate property works.
I made this simple Electron Fiddle that can be used to test with: https://gist.github.com/stefansundin/4cee8e88133efb196f54f2d2a9f05155. You need to run npm run start to run the babylon.js server as well.
Please let me know if you want me to change anything! Thanks!

LGTM but I'll tag @deltakosh to give a look too

This is a great one! Thanks for updating our support ;)
Please fix the format issue and we can merge

Thanks for the reviews!
I ran npm run format and npm run lint but I got these errors:
$ npm run format

><EMAIL_ADDRESS>format
> npm run format:check && npm run format:fix

><EMAIL_ADDRESS>format:check
> prettier --check ./packages/**/src/**/*.{ts,tsx,js,json,scss,css}

Checking formatting...
[error] No files matching the pattern were found: "./packages/**/src/**/*.json".
[error] No files matching the pattern were found: "./packages/**/src/**/*.css".
All matched files use Prettier code style!

$ npm run lint

><EMAIL_ADDRESS>lint
> npm run lint:check && npm run lint:fix

><EMAIL_ADDRESS>lint:check
> eslint ./packages/**/src/**/*.{ts,tsx,js,json}

Oops! Something went wrong! :(

ESLint: 8.11.0

No files matching the pattern "./packages/**/src/**/*.json" were found.
Please check for typing mistakes in the pattern.

The solution was to run the commands with updated patterns, i.e.:
$ prettier --check ./packages/**/src/**/*.{ts,tsx,js,scss}
$ eslint ./packages/**/src/**/*.{ts,tsx,js}

So I guess for some reason my setup doesn't have the missing files so the whole command failed instead of running it on the files that actually do exist. A potential solution to this might be to add a few dummy files that will always exist so that the patterns are always satisfied.
Just thought I should raise this potential issue that might bite babylon.js newcomers! :)

To fix formating: npm run format:fix :)


Include in the process the ability to follow up with the service teams

Examples of instances where we want to follow up with service teams during the release process:

After an Informational meeting to make sure they are not blocked and understand the process to follow.
After an API/SDK review and changes are requested
“check in” with a team (cadence?) during the process.

Dup of #4060


Pip Installed Inside VENV Is Showing Module Not Found

Type: Bug
I have created new VENV & activated it, I've used pip install spacy now. But, when I run "import pandas" it is showing module not found. I recently updated, looks like there is an issue when new VENV created.
VS Details:
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Hi! Can you try installing spacy using python -m pip install spacy to ensure you are doing this install on your venv? What I guess might be happening is you have created this venv, but are referencing your global version of python when you look to install packages. If you have a mac you can use which python to check that the python you are attempting to run with is the one you think it is. Let me know if this helps!

Sorry for late reply, this solution worked. But, I need to lower the Python version itself to 3.11.
So, I have created new venv using python path : Programs\Python\Python311\python.exe -m venv uninstall VIRTNAME
Then installed spacy to get it worked.


Elrs receiver send telemetry

Two elrs receivers are connected to the same transmitter. To telemetry conflicts only one receiver is allowed to send telemetry. Telemetry has to be disabled for the receiver of the tracker.
With elrs 3.4.0 the receiver loose the "disable telemetry" setting after some power cycles. This is an elrs problem and should be fixed in version 3.4.3 (no yet tested)

Updated to 3.4.3 , we will see....


[SPARK-14603] [SQL] [FOLLOWUP] Verification of Metadata Operations by Session Catalog

What changes were proposed in this pull request?
This follow-up PR is to address the remaining comments in https://github.com/apache/spark/pull/12385
The major change in this PR is to issue better error message in PySpark by using the mechanism that was proposed by @davies in https://github.com/apache/spark/pull/7135
For example, in PySpark, if we input the following statement:
>>> l = [('Alice', 1)]
>>> df = sqlContext.createDataFrame(l)
>>> df.createTempView("people")
>>> df.createTempView("people")

Before this PR, the exception we will get is like
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/dataframe.py", line 152, in createTempView
    self._jdf.createTempView(name)
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/lib/py4j-0.10.1-src.zip/py4j/java_gateway.py", line 933, in __call__
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/utils.py", line 63, in deco
    return f(*a, **kw)
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/lib/py4j-0.10.1-src.zip/py4j/protocol.py", line 312, in get_return_value
py4j.protocol.Py4JJavaError: An error occurred while calling o35.createTempView.
: org.apache.spark.sql.catalyst.analysis.TempTableAlreadyExistsException: Temporary table 'people' already exists;
    at org.apache.spark.sql.catalyst.catalog.SessionCatalog.createTempView(SessionCatalog.scala:324)
    at org.apache.spark.sql.SparkSession.createTempView(SparkSession.scala:523)
    at org.apache.spark.sql.Dataset.createTempView(Dataset.scala:2328)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:237)
    at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
    at py4j.Gateway.invoke(Gateway.java:280)
    at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:128)
    at py4j.commands.CallCommand.execute(CallCommand.java:79)
    at py4j.GatewayConnection.run(GatewayConnection.java:211)
    at java.lang.Thread.run(Thread.java:745)

After this PR, the exception we will get become cleaner:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/dataframe.py", line 152, in createTempView
    self._jdf.createTempView(name)
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/lib/py4j-0.10.1-src.zip/py4j/java_gateway.py", line 933, in __call__
  File "/Users/xiaoli/IdeaProjects/sparkDelivery/python/pyspark/sql/utils.py", line 75, in deco
    raise AnalysisException(s.split(': ', 1)[1], stackTrace)
pyspark.sql.utils.AnalysisException: u"Temporary table 'people' already exists;"

How was this patch tested?
Fixed an existing PySpark test case

Test build #58618 has started for PR 13126 at commit 4c65b6c.

Test build #58618 has finished for PR 13126 at commit 4c65b6c.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class QueryExecutionException(CapturedException):

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58618/
Test FAILed.

Test build #58620 has started for PR 13126 at commit f2cce12.

Test build #58620 has finished for PR 13126 at commit f2cce12.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58620/
Test PASSed.

Test build #58661 has started for PR 13126 at commit dc884a6.

Test build #58661 has finished for PR 13126 at commit dc884a6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58661/
Test PASSed.

@andrewor14 Does the latest change address your comment? Thanks!

thanks merging into master 2.0.


cli: warning messages do not exit

closes https://github.com/inveniosoftware/invenio-cli/issues/249
A warning always get's an exit code > 0. The difference with an error is that it should not exit the program.

@fenekku yes, wanted us all to agree before doing tests. Will do soon.


Workflow-Controller panic: can't create an event with namespace 'default' in namespace 'argo''

Summary
I've noticed a unexpected restart of the pod
What happened/what you expected to happen?
This is instance managed by ArgoCD instance and currently not being actively used
What version is it broken in?
v3.2.6
What version was it working in?
Diagnostics
What Kubernetes provider are you using?
GKE on 1.21.5-gke.1802
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
Emissary
...
time="2022-01-21T07:54:25.370Z" level=info msg="Update leases 200"
time="2022-01-21T07:54:29.124Z" level=info msg="List workflows 200"
time="2022-01-21T07:54:29.124Z" level=info msg=healthz age=5m0s err="<nil>" instanceID= labelSelector="!workflows.argoproj.io/phase,!workflows.argoproj.io/controller-instanceid" managedNamespace=
time="2022-01-21T07:54:30.377Z" level=info msg="Get leases 200"
time="2022-01-21T07:54:30.385Z" level=info msg="Update leases 200"
time="2022-01-21T07:54:35.431Z" level=info msg="Get leases 200"
time="2022-01-21T07:54:35.442Z" level=info msg="Update leases 200"
time="2022-01-21T07:54:48.550Z" level=info msg="Get leases 500"
E0121 07:54:48.551558       1 leaderelection.go:325] error retrieving resource lock argo/workflow-controller: etcdserver: request timed out
I0121 07:54:50.443189       1 leaderelection.go:278] failed to renew lease argo/workflow-controller: timed out waiting for the condition
E0121 07:54:50.443268       1 leaderelection.go:301] Failed to release lock: resource name may not be empty
time="2022-01-21T07:54:50.443Z" level=info msg="stopped leading" id=argo-workflow-controller-7797b9c9d5-p48p5
E0121 07:54:50.443353       1 event.go:273] Unable to write event: '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".16cc39f57309758c", GenerateName:"", Namespace:"default", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"Lease", Namespace:"", Name:"", UID:"", APIVersion:"coordination.k8s.io/v1", ResourceVersion:"", FieldPath:""}, Reason:"LeaderElection", Message:"argo-workflow-controller-7797b9c9d5-p48p5 stopped leading", Source:v1.EventSource{Component:"workflow-controller", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xc072b7929a6a118c, ext:542583113832237, loc:(*time.Location)(0x3346660)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xc072b7929a6a118c, ext:542583113832237, loc:(*time.Location)(0x3346660)}}, Count:1, Type:"Normal", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'can't create an event with namespace 'default' in namespace 'argo''(may retry after sleeping)
panic: http: Server closed

goroutine 148 [running]:
github.com/argoproj/argo-workflows/v3/workflow/metrics.runServer.func1(0x1, 0x21eabe1, 0x8, 0x2382, 0x0, 0x0, 0xc0007bc0e0)
	/go/src/github.com/argoproj/argo-workflows/workflow/metrics/server.go:56 +0x11d
created by github.com/argoproj/argo-workflows/v3/workflow/metrics.runServer
	/go/src/github.com/argoproj/argo-workflows/workflow/metrics/server.go:53 +0x27e

Message from the maintainers:
Impacted by this regression? Give it a 👍. We prioritise the issues with the most 👍.

@shuker85 how do you install argo workflow?

https://github.com/kubernetes-sigs/kind/issues/717

Helm chart handled by app-of-apps pattern

Leader election is confused somehow, thinking it is is the wrong namespace.
Are you using managed namespace feature where controller is in different namespace to workflows?

Hi! I'm also running into this error. In my case, I've installed Argo Workflows as part of Kubeflow, and yes, our workflows are in different namespaces from the controller. Can you suggest any other steps I can try to troubleshoot? Thank you!

please add stack trace

Thanks @alexec!
I0224 06:27:16.729930       1 leaderelection.go:278] failed to renew lease kubeflow/workflow-controller: timed out waiting for the condition
E0224 06:27:16.730011       1 leaderelection.go:301] Failed to release lock: resource name may not be empty
time="2022-02-24T06:27:16.730Z" level=info msg="stopped leading" id=workflow-controller-f78bdfff-8ntb2
E0224 06:27:16.730072       1 event.go:273] Unable to write event: 'can't create an event with namespace 'default' in namespace 'kubeflow'' (may retry after sleeping)
time="2022-02-24T06:27:16.730Z" level=info msg="Shutting workflow TTL worker"
panic: http: Server closed

goroutine 235 [running]:
github.com/argoproj/argo-workflows/v3/workflow/metrics.runServer.func1(0x1, 0x1eeb199, 0x8, 0x2382, 0x0, 0x0, 0xc00aa43500)
	/go/src/github.com/argoproj/argo-workflows/workflow/metrics/server.go:56 +0x117
created by github.com/argoproj/argo-workflows/v3/workflow/metrics.runServer
	/go/src/github.com/argoproj/argo-workflows/workflow/metrics/server.go:53 +0x27e

Are you using --managed-namespace?

The panic is a red herring. It is caused by the shutdown, but will not have impact. Any fix for that would go here, but I think it is just annoying, so not needed:
https://github.com/argoproj/argo-workflows/blob/06d4bf76fc2f8ececf2b25a0ba5a81f844445b0f/workflow/metrics/server.go#L54
The event issue is coming from here, but I can't see the problem:
https://github.com/argoproj/argo-workflows/blob/06d4bf76fc2f8ececf2b25a0ba5a81f844445b0f/workflow/controller/controller.go#L290
There is probably a bug in client-go upstream library:
https://github.com/kubernetes/client-go/issues/966
I think all we need to do is this:
	ReleaseOnCancel: false,

@shuker85 would you like to submit a PR?


Synchronize containerd and docker configuration with machine-controller

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>
What this PR does / why we need it:
Currently, containerd configuration is not dynamic and a very basic configuration is specified in the OSP like this. There was a need to make it dynamic to add support for mirror registries, auth, etc.
For container runtime configuration we now rely on the methods defined in machine-controller. This helps us ensure that changes are synched across these. Eventually, container runtime configurations will be completely removed from machine-controller and will be shifted to OSM.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #123
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

* Support for mirror registries, insecure registries, containerd auth config

/unhold


Adding dependency resources

Hi,
We are having issues including library-type resources into our Liberty assemblies for, say, adding a JDBC-driver. The datasource definition goes into the server.xml and we add a dependency to the jar-file for the driver, which should get pulled from our build-artifact repository, but we can't find a way to tell the plugin where to put the library definition (i.e. usr/shared/config) and jar-file (i.e. usr/shared/resources).
Is this supposed to be handled outside the plugin?
thx:Mike

You can use the Maven Dependency plugin to do this:
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-dependency-plugin</artifactId>
    <version>3.0.0</version>
    <executions>
        <execution>
            <id>copy-derby</id>
            <phase>package</phase>
            <goals>
                <goal>copy</goal>
            </goals>
            <configuration>
                <artifactItems>
                    <artifactItem>
                        <groupId>org.apache.derby</groupId>
                        <artifactId>derby</artifactId>
                        <version><IP_ADDRESS></version>
                        <outputDirectory>${project.build.directory}/liberty/wlp/usr/shared/resources</outputDirectory>
                    </artifactItem>
                </artifactItems>
            </configuration>
        </execution>
    </executions>
</plugin>

Good tip! A little more config than I hoped for, but it'll sure do the trick.

Closing this issue since the provided config above is the recommended solution.

@mikehenry-se  , I hope you don't mind the notification two years later here, but just browsing through this issue, I wanted to bring this enhancement to your attention as an improved solution to this problem https://github.com/OpenLiberty/ci.maven/issues/705 .
If I waited too long and am now spamming you, I apologize !

@scottkurz Thank you for coming back to give me the heads-up. And for working so diligently to solve this problem in such an elegant way.
Don't worry about spamming, this is why this community is so awesome and why I use nothing but Liberty for my cloud-native Java projects.


Upgrade v3 docs favicon to be web 3.0 compatible

Dynamic chromatic elements
Spacial orientation adjustment
More alpha

@Gerg can you take a screenshot of your browser tabs and attach it to this PR? That would make it easier to visualize! 👨🎨

You can 👁 is here: https://raw.githubusercontent.com/cloudfoundry/cloud_controller_ng/09228237cb3496e7deeef354cfcf219585431ffa/docs/v3/source/images/favicon.ico

Wow! Looks downright luxurious. 💎 🥇

Thanks @Gerg, you're a modern-day Da Vinci. 🎨 👨🎨


RC Spot-Check Test: Projectile Sampling Distributions 1.0.0-rc.6

RC Spot-Check Test
Mentions: @matthew-blackman @samreid
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html
phet-io wrapper index
link to phet-io zip file

Test Matrices
General Test:

[ ] Tester = KW, Platform = Win 11 Chrome, Time = .25
[ ] Tester = , Platform = , Time =

PhET-iO Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Additional Features Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Features included

[x] PhET-iO
[x] Dynamic Locale
[x] Alternative Input
[x] UI Sound
[x] Sonification
[ ] Description
[ ] Voicing

Focus and Special Instructions

This is a spot check before sim publication. Please verify that the issues listed below are fixed. No further extensive testing is needed beyond the scope of the issue descriptions.
Issues to Verify
These issues should have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.

[x] https://github.com/phetsims/projectile-data-lab/issues/306
[x] https://github.com/phetsims/projectile-data-lab/issues/319

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test some query parameters. (See QA Book for a
list of query parameters.)
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
is a problem.
As the RC ends, notify the developer of any new QA credits that need to be added.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

@KatieWoe can you also spot-check issue https://github.com/phetsims/projectile-data-lab/issues/322? Here are updated RC links with the fix in place:
https://phet-dev.colorado.edu/html/projectile-sampling-distributions/1.0.0-rc.7/phet/projectile-sampling-distributions_all_phet.html
https://phet-dev.colorado.edu/html/projectile-sampling-distributions/1.0.0-rc.7/phet-io/

Looks good aside from https://github.com/phetsims/projectile-data-lab/issues/323

@KatieWoe adding issue https://github.com/phetsims/projectile-data-lab/issues/323 to this Spot-Check. Here are updated RC links with the fix in place:
https://phet-dev.colorado.edu/html/projectile-sampling-distributions/1.0.0-rc.8/phet/projectile-sampling-distributions_all_phet.html
https://phet-dev.colorado.edu/html/projectile-sampling-distributions/1.0.0-rc.8/phet-io/

I think we're ok to go

This is published. Closing


Incompatible with Equipment and Quickslots?

Describe the bug
When both mods "Equipment and Quickslots" and "AdventureBackpacks" are activated, Im stuck on the loading screen, even though the console says I'm ingame.
To Reproduce
Steps to reproduce the behavior:

Activate both mentioned mods
try to login with any character

Expected behavior
I expect the game to load und throw me out of the loading screen.
Screenshots

Mod List (please list your mods that are being used):
Player log:
Player.log

denikson-BepInExPack_Valheim
Azumatt-Official_BepInEx_ConfigurationManager
GoldenJude-Blacksmiths_tools
AllTheHeims-EpicLootPatching_AdventureBackpacks
CW_Jesse-BetterNetworking_Valheim
ValheimModding-HookGenPatcher
ValheimModding-Jotunn
NoPetRides-NoPetRides_ModUtils
WackyMole-WackysDatabase
shudnal-TradersExtended
blacks7ar-RenegadeVikings
ishid4-BetterArchery
SpikeHimself-XPortal
OdinPlus-TeleportEverything
Azumatt-BetterWards
Roses-SmarterContainers
rendl0449-CraftFromContainers
Goldenrevolver-Quick_Stack_Store_Sort_Trash_Restock
MathiasDecrock-PlanBuild
aedenthorn_nexus-AutoFeed
JewelHeim-Magic_Crystal_Table
RockerKitten-BoneAppetit
Digitalroot-Triple_Bronze_JVL
Therzie-Warfare
Therzie-Armory
ValadrielTheMad-ValadrielsMadArmory
GoldenJude-Judes_Equipment
Goldenrevolver-Obtainable_Stone_Pickaxe_and_Upgradeable_Antler_Pickaxe
RandyKnapp-EpicLoot
Vapok-AdventureBackpacks
OdinPlus-BetterLanterns
VikingGlory-ChestReloaded
plumga-Clutter
NexusTransfer-ValheimRAFT
OdinPlus-OdinCampsite
OdinPlus-OdinTrainingPlace
OdinPlus-OdinsHorsePen
OdinPlus-OdinHorse
OdinPlus-OdinArchitect
Marlthon-OdinShipPlus
OdinPlus-BeeQueen
BetterUI_ForeverMaintained-BetterUI_ForeverMaintained
RandyKnapp-EquipmentAndQuickSlots
RustyMods-Seasonality
RustyMods-Seasonality_HD_Texture_Pack

EDIT: correction of list
Unfortunately the modlist in my r2modman profile contained all installed mods, even those which werent active at that time.
EDIT 2:
also happens whe deactivated "BetterUI_ForeverMaintained-BetterUI_ForeverMaintained"
EDIT 3:
deactivated AdventureBackpacks and activated Backpacks by Smoothbrain, and now the loading screen unloads. I'd still like to play with your mod though :(
Additional context
No additional context to be mentioned

Hi @ReFleXzZ,
I actually develop against Equipment and Quickslots and Epic Loot to ensure compatibility, so I know that Adventure Backpacks has for a long time had total support of EAQS.
My assumption is that you have other errors going on.  I'll need the full LogOutput.txt though to be able to diagnose the errors that might be coming up.
If you'd like to provide your log, that'd be great.

Actually, just realized you put the log in there.  You are running the wrong version of Adventure Backpacks.
This log shows:
[Info   :   BepInEx] Loading [Adventure Backpacks 1.7.5]
You should be running 1.7.7.

That's interesting, sice I tested this after r2modman asked me about the update. I Updated it already and in the modmanager it was shown "1.7.7".

Reinstalled all mods and log still says, I'm on 1.7.5

Yeah I dunno... I use r2modman and it works just fine.  Something in your profile is trying to load an old version though.

You know.. one second.

I forgot to increment the version number... hang on.

I'll be releasing 1.7.8 in a few minutes to fix the version issue.
But YOUR issue appears to be coming from Smoothbrain's Blacksmithing based on the error above.