Error Message after camera recognized motion

Describe the bug
The installation of the adapter is complete and everything is fine.
But, when the camera detect a motion I get this error.
To Reproduce
Steps to reproduce the behavior:

Insatll adapter
Configute it
Go to test camera (eufyCam 2 (T8114)) to test it
See error

Expected behavior
No error message.
Screenshots & Logfiles

`2021-08-15 12:30:56.418  - info: eufy-security.0 (12904) Downloading video event for device T8114P02195101D3 in 18.979 seconds...
2021-08-15 12:32:29.481  - error: eufy-security.0 (12904) ffmpegPreviewImage(): An error occurred: ffmpeg exited with code 1: Output #0, image2, to '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C.jpeg':
Output file #0 does not contain any stream
2021-08-15 12:32:29.483  - error: eufy-security.0 (12904) ffmpegPreviewImage(): ffmpeg output:
2021-08-15 12:32:29.483  - error: eufy-security.0 (12904) ffmpegPreviewImage(): ffmpeg stderr:
ffmpeg version 4.4-static https://johnvansickle.com/ffmpeg/  Copyright (c) 2000-2021 the FFmpeg developers
built with gcc 6.3.0 (Debian 6.3.0-18+deb9u1) 20170516
configuration: --enable-gpl --enable-version3 --enable-static --disable-debug --disable-ffplay --disable-indev=sndio --disable-outdev=sndio --cc=gcc --enable-fontconfig --enable-frei0r --enable-gnutls --enable-gmp --enable-libgme --enable-gray --enable-libfribidi --enable-libass --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-librubberband --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libvorbis --enable-libopus --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvpx --enable-libwebp --enable-libx264 --enable-libxml2 --enable-libxvid --enable-libzimg
libavutil      56. 70.100 / 56. 70.100
libavcodec     58.134.100 / 58.134.100
libavformat    58. 76.100 / 58. 76.100
libavdevice    58. 13.100 / 58. 13.100
libavfilter     7.110.100 /  7.110.100
libswscale      5.  9.100 /  5.  9.100
libswresample   3.  9.100 /  3.  9.100
libpostproc    55.  9.100 / 55.  9.100
[hls @ 0x43a5620] Skip ('#EXT-X-VERSION:3')
[hls @ 0x43a5620] Cannot get correct #EXTINF value of segment /opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C0.ts, set to default value to 1ms.
[hls @ 0x43a5620] Opening '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C0.ts' for reading
[aac @ 0x43b12b0] More than one AAC RDB per ADTS frame is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
[aac @ 0x43b12b0] channel element 3.15 is not allocated
[aac @ 0x43b12b0] Multiple frames in a packet.
[aac @ 0x43b12b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x43b12b0] Inconsistent channel configuration.
[aac @ 0x43b12b0] get_buffer() failed
[aac @ 0x43b12b0] Number of bands (3) exceeds limit (1).
[aac @ 0x43b12b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x43b12b0] Inconsistent channel configuration.
[aac @ 0x43b12b0] get_buffer() failed
[aac @ 0x43b12b0] Assuming an incorrectly encoded 7.1 channel layout instead of a spec-compliant 7.1(wide) layout, use -strict 1 to decode according to the specification instead.
[aac @ 0x43b12b0] channel element 2.13 is not allocated
[aac @ 0x43b12b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x43b12b0] Inconsistent channel configuration.
[aac @ 0x43b12b0] get_buffer() failed
[aac @ 0x43b12b0] Number of bands (29) exceeds limit (20).
[aac @ 0x43b12b0] Number of bands (51) exceeds limit (43).
[aac @ 0x43b12b0] Number of bands (7) exceeds limit (2).
[aac @ 0x43b12b0] channel element 2.0 is not allocated
[aac @ 0x43b12b0] channel element 3.5 is not allocated
[aac @ 0x43b12b0] channel element 1.0 is not allocated
[hls @ 0x43a5620] decoding for stream 1 failed
[hls @ 0x43a5620] Could not find codec parameters for stream 0 (Video: h264 ([27][0][0][0] / 0x001B), none): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[hls @ 0x43a5620] Could not find codec parameters for stream 1 (Audio: aac (Main) ([15][0][0][0] / 0x000F), 5.1, fltp): unspecified sample rate
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
Input #0, hls, from '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C.m3u8':
Duration: 00:00:00.00, start: 1.400000, bitrate: 1232 kb/s
Program 0
Metadata:
variant_bitrate : 0
Stream #0:0: Video: h264 ([27][0][0][0] / 0x001B), none, 90k tbr, 90k tbn, 180k tbc
Metadata:
variant_bitrate : 0
Stream #0:1: Audio: aac (Main) ([15][0][0][0] / 0x000F), 5.1, fltp
Metadata:
variant_bitrate : 0
Output #0, image2, to '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C.jpeg':
Output file #0 does not contain any stream
2021-08-15 12:32:29.484  - error: eufy-security.0 (12904) ffmpegPreviewImage - station: T8010P23195004D7 device: T8114P021951045C - Error [{}]
2021-08-15 12:34:23.746  - info: eufy-security.0 (12904) Downloading video event for device T8114P02195101D3 in 19.092 seconds...
2021-08-15 12:42:29.820  - error: eufy-security.0 (12904) ffmpegPreviewImage(): An error occurred: ffmpeg exited with code 1: Output #0, image2, to '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C.jpeg':
Output file #0 does not contain any stream
2021-08-15 12:42:29.822  - error: eufy-security.0 (12904) ffmpegPreviewImage(): ffmpeg output:
2021-08-15 12:42:29.823  - error: eufy-security.0 (12904) ffmpegPreviewImage(): ffmpeg stderr:
ffmpeg version 4.4-static https://johnvansickle.com/ffmpeg/  Copyright (c) 2000-2021 the FFmpeg developers
built with gcc 6.3.0 (Debian 6.3.0-18+deb9u1) 20170516
configuration: --enable-gpl --enable-version3 --enable-static --disable-debug --disable-ffplay --disable-indev=sndio --disable-outdev=sndio --cc=gcc --enable-fontconfig --enable-frei0r --enable-gnutls --enable-gmp --enable-libgme --enable-gray --enable-libfribidi --enable-libass --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-librubberband --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libvorbis --enable-libopus --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvpx --enable-libwebp --enable-libx264 --enable-libxml2 --enable-libxvid --enable-libzimg
libavutil      56. 70.100 / 56. 70.100
libavcodec     58.134.100 / 58.134.100
libavformat    58. 76.100 / 58. 76.100
libavdevice    58. 13.100 / 58. 13.100
libavfilter     7.110.100 /  7.110.100
libswscale      5.  9.100 /  5.  9.100
libswresample   3.  9.100 /  3.  9.100
libpostproc    55.  9.100 / 55.  9.100
[hls @ 0x2cfa620] Skip ('#EXT-X-VERSION:3')
[hls @ 0x2cfa620] Cannot get correct #EXTINF value of segment /opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C0.ts, set to default value to 1ms.
[hls @ 0x2cfa620] Opening '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C0.ts' for reading
[aac @ 0x2d062b0] More than one AAC RDB per ADTS frame is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
[aac @ 0x2d062b0] Multiple frames in a packet.
[aac @ 0x2d062b0] Number of bands (24) exceeds limit (12).
[aac @ 0x2d062b0] channel element 1.1 is not allocated
[aac @ 0x2d062b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x2d062b0] Inconsistent channel configuration.
[aac @ 0x2d062b0] get_buffer() failed
[aac @ 0x2d062b0] channel element 1.0 is not allocated
[aac @ 0x2d062b0] Assuming an incorrectly encoded 7.1 channel layout instead of a spec-compliant 7.1(wide) layout, use -strict 1 to decode according to the specification instead.
[aac @ 0x2d062b0] channel element 3.12 is not allocated
[aac @ 0x2d062b0] SBR was found before the first channel element.
[aac @ 0x2d062b0] Number of bands (38) exceeds limit (30).
[aac @ 0x2d062b0] Dependent coupling is not supported together with LTP
Last message repeated 17 times
[aac @ 0x2d062b0] channel element 3.6 is not allocated
[aac @ 0x2d062b0] channel element 2.9 is not allocated
[aac @ 0x2d062b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x2d062b0] Inconsistent channel configuration.
[aac @ 0x2d062b0] get_buffer() failed
[aac @ 0x2d062b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x2d062b0] Too large remapped id is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
[aac @ 0x2d062b0] If you want to help, upload a sample of this file to https://streams.videolan.org/upload/ and contact the ffmpeg-devel mailing list<EMAIL_ADDRESS>[aac @ 0x2d062b0] Sample rate index in program config element does not match the sample rate index configured by the container.
[aac @ 0x2d062b0] Too large remapped id is not implemented. Update your FFmpeg version to the newest one from Git. If the problem still occurs, it means that your file has a feature which has not been implemented.
[aac @ 0x2d062b0] If you want to help, upload a sample of this file to https://streams.videolan.org/upload/ and contact the ffmpeg-devel mailing list<EMAIL_ADDRESS>[aac @ 0x2d062b0] channel element 1.9 is not allocated
[hls @ 0x2cfa620] decoding for stream 1 failed
[hls @ 0x2cfa620] Could not find codec parameters for stream 0 (Video: h264 ([27][0][0][0] / 0x001B), none): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[hls @ 0x2cfa620] Could not find codec parameters for stream 1 (Audio: aac (Main) ([15][0][0][0] / 0x000F), 3.0, fltp): unspecified sample rate
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
Input #0, hls, from '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C.m3u8':
Duration: 00:00:00.00, start: 1.400000, bitrate: 1232 kb/s
Program 0
Metadata:
variant_bitrate : 0
Stream #0:0: Video: h264 ([27][0][0][0] / 0x001B), none, 90k tbr, 90k tbn, 180k tbc
Metadata:
variant_bitrate : 0
Stream #0:1: Audio: aac (Main) ([15][0][0][0] / 0x000F), 3.0, fltp
Metadata:
variant_bitrate : 0
Output #0, image2, to '/opt/iobroker/iobroker-data/eufy-security.0/T8010P23195004D7/last_event/T8114P021951045C.jpeg':
Output file #0 does not contain any stream
2021-08-15 12:42:29.823  - error: eufy-security.0 (12904) ffmpegPreviewImage - station: T8010P23195004D7 device: T8114P021951045C - Error [{}]`
Versions:

Adapter version: <0.6.0>
JS-Controller version: <3.3.15>
Node version: <14.17.5>
Operating system: <raspbian 10>

Please set the adapter in debug mode and then send me the logs by mail.
You can find the mail address here.


fix(@schematics/angular): skip SSR routing prompt in webcontainer

Apparently inquirer requires async_hooks which isn't supported in webcontainers, therefore prompting the user fails. Instead we always fall back to the default option.
See: https://github.com/SBoudrias/Inquirer.js/issues/1426

The changes were merged into the following branches: main, 19.0.x


add team city integration testing

with the addition of untrusted builds feature https://www.jetbrains.com/help/teamcity/untrusted-builds.html running integration tests on TeamCity is likely more feasible. The integration tests could then be build into the test pipeline.

This was done, it worked, and then we found a way to do it all on Github.


onDelete cascade sqlite3

I know that constraints work if I enable PRAGMA foreign_keys = ON for each request, but how do I implement this?
In Yii it can be solved in such way:
'db'=>array(     'connectionString' => 'sqlite:'.dirname(__FILE__).'/../data/testdrive.db',   'initSQLs'=>array(    'PRAGMA foreign_keys = ON',   ), ),

Hi, how be a best practice in Laravel 5?


[Feature Request] A way to know if there are any puppeteer browser instances running?

Is it possible to implement a feature where we can find out if any browsers launched from puppeteer are running?
My Use case:
I have multiple puppeteer scripts and each script opened it's own browser instance. I wanted to make it so that each scripts runs in it's own page instead of running in it's own browser instance. To do that I wanted to implement a logic like so:
Browser.js:
if(puppeteer instance exists){
  return browser.wsEndpoint()
} else {
  browser = await puppeteer.launch();
  return browser.wsEndpoint();
}

Browser.js will be imported into each of my scripts and when it is called it returns the wsEndpoint of the already running instance of the browser and if a browser instance isn't running then it will create a new instance and return only the weEndpoint. I thought of using puppeteer.connect(returned wsEndpoint) to achieve this. But now I couldn't find anything that let's me find if there is an instance already running or any way to get its wsEndpoint.

There's no reliable way to do that since browsers could be launched by many different means (e.g. via chrome-launcher or just manually).
You'll have to track the browsers you're interested in on your end, e.g. using generic-pool module (there are some resources regarding this on the bugtracer), or building something simple like this:
// instance.js
const pptr = require('puppeteer');
let instance = null;
module.exports.getBrowserInstance = async function() {
  if (!instance)
    instance = await pptr.launch();
  return instance;
}

And later using it in all your scripts:
const {getBrowserInstance} = require('./instance');

async function doWork() {
  // ....
  const browser = await getBrowserInstance(); // this will reuse single browser
  // ....
}

Hope this helps.


7.2-5

Compared to CLRS2e, defines \beta as 1-\alpha and uses different notation of the desired results.


lnrpc: introduce new TapTweak field for key path spends

In this commit, we add a new field `TapTweak` to be used for key path
spends. Before this commit, we'd overload the existing `WitnessScript`
field to pass this information to the signing context. This was
confusing as for tapscript spends, this was the leaf script, which
mirrors the other script based spending types.

With this new filed, users need to set this to the script root for
keypath spends where the output key commits to a real merkle root, and
nothing when bip 86 spending is being used.

Added the two commits to https://github.com/lightningnetwork/lnd/pull/6450.


Can't configure card

Are there any issues with the openpgp card app after the last firmware update to the ledger nano s? I can generate passwords and sign documents with it, but I fail to even get a card-status update. Everytime I try I get a message like this:
DIEGOs-Mac-Pro:~ diego$ gpg --card-status
gpg: selecting openpgp failed: Operation not supported by device
gpg: tarjeta OpenPGP no disponible: Operation not supported by device

As mentioned in issue #21 I am facing the same issue, as of April 16th

Any update on this?

I need more info. Any log?

Just started trying to charactorise the issue.
Using pcsc_scan v1.5.2 (from MacPorts), justs spins indefinitely:
pcsc_scan PC/SC device scanner V 1.5.2 (c) 2001-2017, Ludovic Rousseau<EMAIL_ADDRESS>Plug'n play reader name not supported. Using polling every 1000 ms. Scanning present readers... Waiting for the first reader... |
Increasing the log level within /usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle/Contents/Info.plist has no effect within dmesg and Console:
        <key>ifdLogLevel</key>         <string>0x0003</string>
A quick check within System Information shows that the USB attributes are unchanged and correspond to Info.plist:

Other applications on the Ledger continue to work fine on the Mac, tested: U2F ID and BitCoin.  Interestingly spinning up a VMWare on the same MBP and assigning the Ledger to that.  I'm able to perform OpenPGP operations.   Suggests a strange interaction below ccid on MacOS.

With a Ledger plugged in, expected to see it at the bottom of list:
system_profiler SPSmartCardsDataType
SmartCards:

    Readers:

    Reader Drivers:

      #01: org.debian.alioth.pcsclite.smartcardccid:1.4.27 (/usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle)

    Tokend Drivers:

    SmartCard Drivers:

      #01: com.apple.CryptoTokenKit.pivtoken:1.0 (/System/Library/Frameworks/CryptoTokenKit.framework/PlugIns/pivtoken.appex)

    Available SmartCards (keychain):

    Available SmartCards (token):

Same here. Followed same configuration as in #21. Running system_profiler SPSmartCardsDataType gives same output as @atishnazir. Running pcsctest outputs
MUSCLE PC/SC Lite Test Program

Testing SCardEstablishContext    : Command successful.
Testing SCardGetStatusChange
Please insert a working reader   :

But never completes as it cannot find the ledger nano s.

I've the same issue. Everything works on the ledger firmware 1.4.1 + app v1.1.0 but fails on firmware 1.4.2 + app v1.2.1 on the same machine.
Any Ideas how to debug this @cslashm ?

I'm having exactly the same problem here.

You need to have the latest drivers for Ledger Nano S
org.debian.alioth.pcsclite.smartcardccid:1.4.30
system_profiler SPSmartCardsDataType
SmartCards:

    Readers:

      #01: Ledger Nano S (ATR:<3b00>)

    Reader Drivers:

      #01: org.debian.alioth.pcsclite.smartcardccid:1.4.27 (/usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle)
      #02: org.debian.alioth.pcsclite.smartcardccid:1.4.30 (/usr/local/libexec/SmartCardServices/drivers/ifd-ccid.bundle)

I made a tutorial for GPG tools, Ledger nano S and Mojave.
Please follow the link below:
https://github.com/savenas/docs/blob/master/gpg_ledger_mojave.md

Cool @savenas - Will try that out asap.

You need to have the latest drivers for Ledger Nano S
org.debian.alioth.pcsclite.smartcardccid:1.4.30
system_profiler SPSmartCardsDataType
SmartCards:

    Readers:

      #01: Ledger Nano S (ATR:<3b00>)

    Reader Drivers:

      #01: org.debian.alioth.pcsclite.smartcardccid:1.4.27 (/usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle)
      #02: org.debian.alioth.pcsclite.smartcardccid:1.4.30 (/usr/local/libexec/SmartCardServices/drivers/ifd-ccid.bundle)

I made a tutorial for GPG tools, Ledger nano S and Mojave.
Please follow the link below:
https://github.com/savenas/docs/blob/master/gpg_ledger_mojave.md

Hi, the link is not accessible anymore. Do you mind adding the instructions here? I'm sure others like me still have the same issue... Thanks!

@savenas your tutorial is unavailable any more? I am struggling to install 1.4.30 driver to my mac to detect Nano X as smart card

@cslashm bonjour, unfortunately even with the latest #01: org.debian.alioth.pcsclite.smartcardccid:1.4.32 (/usr/libexec/SmartCardServices/drivers/ifd-ccid.bundle) installed on mac os Catalina my ledger nano x is still undetectable as a smart card in OpenPGP app mode. When will we have a natural support for ledger smart card on mac os? it's been three years and the issue is still not solved. Merci

I'd love to see this happen, perhaps with Big Sur? It could make obsolete the SSH Ledger app, as GnuPG can run as an agent.

@philihp I ended up spinning up an ubuntu in virtualbox on my macbook air and setting up my ledger nano x with OpenPGP app there. So now I have both https://github.com/romanz/trezor-agent SSH/GPG app running natively on mac os and Ledger OpenPGP app running in the virtual machine. Both have been tested positive in delete and restore mode on nano x

Why is this closed? The problem seems to still exsits..

Same issue here on MacOS Big Sur 11.4 and gpg (GnuPG) 2.3.1
~ gpg --card-status
gpg: selecting card failed: Operation not supported by device
gpg: OpenPGP card not available: Operation not supported by device

Issue still persists on macOS Big Sur 11.6.1 using GnuPG 2.2.32 (the latest version at the time of writing). I also have the correct driver org.debian.alioth.pcsclite.smartcardccid:1.4.32 and libusb 1.0.24 is installed and up to date according to brew.
Tried both a Nano S and Nano X and the OpenPGP and OpenPGP.XL apps. Firmware on both Ledgers is up to date as were the apps.
Just like everyone else I am still getting the same error no matter what when running commands from gpg, including after setting GNUPGHOME to the "ledger" directory:

gpg --card-status
gpg: selecting card failed: Operation not supported by device
gpg: OpenPGP card not available: Operation not supported by device

However... using the Python scripts I was able to successfully run:

ledger-gpg init "Name<EMAIL_ADDRESS>-e ed25519 -v

On my Nano X, and when I used the ~/.gnupg/ledger directory as GNUPGHOME running gpg -K listed only the new PGP key I just generated.
So it's not fully unable to connect, something is working somewhere, the Ledger is just not able to connect to the gpg-agent so commands are not passed through gpg (gpg -K worked because it just reads the keychain db, and I changed the environment variable to point it at the Ledger one stored in my home folder, it still won't interact with the Ledger).
I believe there is a config you can put into gpg.conf that lets you point it to a different agent, and if you point it to the path of ledger-gpg-agent that might fix it. I don't want to risk losing my existing keychain though so I just undid all the changes and left it.
This has pushed me to look into Yubikey and similar devices though, if they have a functional USB interface instead of all this mess they certainly seem very useful for security. Shame I couldn't use the device I already have though.

I am with @ftpmorph here. Unfortunately the not working gpg forces me to have a look an YubiKey 😕


Sandbox

Hi and thank you for doing all this work and releasing it to the public.
I'm having issues using the sandbox environment. The authentication runs nicely, but any other call from there seems to go through the production URLs.
These will both raise Syntax Errors:
visma_eaccounting = VismaEaccounting::Request.new(token: current_user.visma_eaccounting_token, :sandbox)
or
visma_eaccounting = VismaEaccounting::Request.new(token: current_user.visma_eaccounting_token, environment: :sandbox)
And it doesn't seem to want it in the initialiser either.
Any hints on what I'm doing wrong?
BR,
Andreas

Try api_environment. Sorry should document it better.

Fixed by https://github.com/espen/visma_eaccounting/commit/f6c25bcba05c1e50f76dad765d9fc053064c2221


Fix various linting and formatting errors

Description

Fix various linting and formatting errors

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

/merge


Upgrade manifests to kustomize v5

Components manifests update to v5 proposal.
Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

@gmfrasca @franciscojavierarceo @danielezonca @terrytangyuan @andrewballantyne @LaVLaS @harshad16 @dhirajsb @ruivieira


Release <IP_ADDRESS> (develop)

Update project structure

stylish-haskell configuration
updated travis configuration
pre-commit
nix-shell with mkShell

Bump base dependence version
Generate relative references as well

@velveteer can I get a stamp on this one too?


No design pattern has been applied

The current code is not implemented with design patterns in mind.  Correction is required.

Resolved by #4


After upgrade to Flutter 1.22.0, VS Code "Failed to initialize Flutter: Process exited with code 1."

Steps to Reproduce

Upgrade to Flutter 1.22 on Stable channel
Flutter doctor
Open any project in VS Code (1.49.2)
Error: "Failed to initialize Flutter: Process exited with code 1."

Restarting computer didn't change anything. I couldn't find any relevant help via Google.
I've reinstalled 3 times. Maybe need to delete and reinstall?
Logs
flutter doctor --verbose
[✓] Flutter (Channel stable, 1.22.0, on Mac OS X 10.15.7 19H2, locale en-CN)
    • Flutter version 1.22.0 at /Users/Orca/flutter/flutter/flutter
    • Framework revision d408d302e2 (2 days ago), 2020-09-29 11:49:17 -0700
    • Engine revision 5babba6c4d
    • Dart version 2.10.0
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/Orca/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.49.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.

Have you tried Flutter clean?

Hi @van-8
No issues with VSC 1.49.2  on v3.15.0 VS Code Flutter  extension

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.0, on Mac OS X 10.15.7 19H2, locale en-GB)
    • Flutter version 1.22.0 at /Users/tahatesser/Code/flutter_stable
    • Framework revision d408d302e2 (3 days ago), 2020-09-29 11:49:17 -0700
    • Engine revision 5babba6c4d
    • Dart version 2.10.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.0

[✓] Connected device (1 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios • iOS 14.0.1

• No issues found!

Following the indication of VS Code Flutter Extension, the correct way to address the problem is to open an issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Maximum number of compute nodes

Which is the maximum number of nodes that can be added to a scale-out group? I can't find that info/limit anywhere.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: acaaf25c-0a4e-05af-dc8f-307ff92e3b17
Version Independent ID: 14446de6-0c23-fae4-135c-4cc34aff96a3
Content: Configure PolyBase scale-out groups on Windows - SQL Server
Content Source: docs/relational-databases/polybase/configure-scale-out-groups-windows.md
Product: sql
Technology: polybase
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@xxflop -- thank you for your question.  You may find answers here:

DBA Stack Exchange
Stack Overflow

Shouldn't this be officially documented somewhere at docs.microsoft.com? Most SQL Server limits are documented and it is important to know how many nodes can be part of a PolyBase Scale-out configuration. The max number of distributions in Synapse is 60 but I guess that PolyBase can be limited to a lower value (8?) and maybe it can be also the maximum of nodes. Pointing to Stack Overflow and DBA Stack Exchange is not a solution for that.


Make email optional in docker login

As per https://github.com/docker/docker/issues/6400 email is now not required for docker login

Closed in favour of https://github.com/garethr/garethr-docker/pull/589 which fixes the same issue. Thanks, and sorry again for taking so long to get around to looking at this.


Still "Upgrading packages" after 30 minutes

Using Debian 10 (as root) and the quick install guide on a new server. It seems to be stuck on "Upgrading packages", or it's still on that after ~30 minutes. Is this normal behaviour or a problem?
Box is dedicated with i7 2600 & 16GB DDR3 (+ 4x4TB HGST in RAID0)

Looking through the script, this did not happen:
aptitude -q=5 upgrade >> $logfile 2>&1 if ! [ $? = 0 ]; then   echo "Problem upgrading packages. Run 'aptitude upgrade' successfully and rerun the script" && exit
I ran aptitude upgrade, rebooted, and now it's showing the next step (Installing required packages). I believe it's an issue that the message wasn't displayed.

And the installation is now complete and I'm using it. The only issue was the part above (echo not echoed).

The code is:
aptitude -q=5 upgrade >> $logfile 2>&1
if ! [ $? = 0 ]; then
  echo "Problem upgrading packages. Run 'aptitude upgrade' successfully and rerun the script" && exit
fi

So, the upgrade did not happen successfully which should have triggered the if statement in the line after and exited with the message, correct? And you think the last part of the first line ( >> $logfile 2>&1) is the issue?
If so, do you think changing the first line to this would help?
aptitude -q=5 -y upgrade | tee -a $logfile

Please re-open the issue if it persist.


42 creation like button

added like and unlike button,

conflict check, ready to be merged

Solves #42


LogGroup: Importing existing log group does not work

What happened?
Wanted to take ownership over an existing log group using the crossplane.io/external-name annotation, but Crossplane tries to create a new LogGroup instead. This is failing because the LogGroup already exists.
How can we reproduce it?
Create a log group manually in AWS called /not/working
Create a managed resource in kubernetes with matching logGroupName and external name annotation:
apiVersion: cloudwatchlogs.aws.crossplane.io/v1alpha1
kind: LogGroup
metadata:
  annotations:
    crossplane.io/external-name: /not/working
  name: not-working
spec:
  deletionPolicy: Orphan
  forProvider:
    logGroupName: /not/working
    region: eu-north-1
    retentionInDays: 7
  providerConfigRef:
    name: default

Will result in:
create failed: cannot create LogGroup in AWS: ResourceAlreadyExistsException: The specified log group already exists
What environment did it happen in?
Crossplane version: v1.6.1
EKS v1.21.9

@petteja will you open the PR also here ? faced the same issue in our environment yesterday


Remove unnecessary custom.css

This was a bad copy and paste from other Qiskit projects. It only has rules for .toggle, which no longer exists in the qiskit_sphinx_theme (which this project isn't using either way.)

By the way, I'm Eric! I joined IBM Quantum 3 months ago to improve Qiskit documentation, including for the Ecosystem. Let me know if I can help you out with documentation or if you have suggestions to improve things :)
In June/July, we'll be adding a new "ecosystem theme variant" to qiskit_sphinx_theme so that it better fits projects than the current styling we use on e.g. https://qiskit.org/ecosystem/nature/ (like no top nav bar). There's no expectation that Ecosystem projects must use the theme, but I'll coordinate once this is released to see if you all would be interested and to make the migration for you if you'd like :)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Will do! Also, you're welcome to start using qiskit_sphinx_theme now if you'd like. See https://qiskit.org/ecosystem/nature/ for an example.
We'll soon be improving the visual design by switching the base theme from a Pytorch fork to Furo, which is a nicer and more modern Sphinx theme. It's used by pip, Black, and attrs.
So, the design will soon improve & we'll add the ecosystem variant theme. But, it's valid to start using the current theme now.
Let me know. I'd be happy to put up a PR :)


Update snRNA-seq and scRNA-seq alt names

For snRNA-seq we want to add snRNAseq as an alt name.
For scRNA-seq we want to add scRNAseq as an alt name.
This is to support the Ingest Validation Tools with the latest CEDAR updates.
@bhonick for reference

The primary issue is that when submitting a dataset for pipeline processing the metadata.tsv file requires a field for assay_type. When scRNAseq is specified, which is a supported datatype as per the Ingest Validation Tools, a POST is made to https://search-api.dev.sennetconsortium.org/assayname with the request body of:
{
    "name": "scRNAseq"
}

This endpoint returns all attributes found in the UBKG /datasets endpoint for the provided assay type (including alt-names). The UBKG supports "scRNA-seq" but not "scRNAseq".
After discussing with @shirey and @bhonick more information needs to be gathered before making any decisions. Currently we trying to verify what scRNAseq and snRNAseq equate to (e.g. does snRNAseq equal snRNA-seq (10x Genomics v3)) from the CEDAR spec (https://bioportal.bioontology.org/ontologies/HRAVS/?p=classes&conceptid=https%3A%2F%2Fpurl.humanatlas.io%2Fvocab%2Fhravs%23HRAVS_0000248).
Another point that emerged from this discussion is the potential that snRNA-seq and snRNA-seq (10x Genomics v3) may equate to the same thing and could be redundant.

One potential resolution for this may be to alter the existing data types of scRNA-seq and snRNA-seq and then updating the Neo4j databases to modify the existing datasets to match the updated spec.

@AlanSimmons I believe we want to replace the existing scRNA-seq with this one from HuBMAP

@shirey does that seem right?

Additionally we will also want to bring over the "scRNAseq-10xGenomics-v2" assay type

There was some confusion over this that has only now been resolved.
scRNA-seq is not really a v1 data_type. It is not in the SenNet workflows, for example.
It's more like one of the new "Dataset Data Types"--i.e., a category.
I recommend that we synchronize data_types between HuBMAP and SenNet, at least for the data types and pipelines that are common to both applications.

@AlanSimmons There has been A LOT of recent back and forth on this the result of which confirms that doing what Max is asking here will actually put us in line with getting the correct pipelines aligned with the correct data in SenNet.

@AlanSimmons and @maxsibilla when this has been released the database Dataset.data_types fields will need to be updated on the affected datasests.

I identify at least 7 requests in one card. I'm not sure whether some of the things are actual requests or proposed requests.
Please confirm that this is the request:

For existing data_type snRNA-seq, add the alt-name snRNAseq.
For existing data_type scRNA-seq, add the alt-name `scRNAseq'.
Delete the existing snRNA-seq, as it is a duplicate of snRNA-seq (10x Genomics v3).
Synchronize the existingsnRNA-seq (10x Genomics v3) in the SENNET ontology with the HUBMAP ontology.
Delete the existing scRNA-seq.
Copy over the scRNASeq-10xgenomics dataset from HUBMAP.
Copy over the scRNASeq-10xgenomics-v2 dataset from HUBMAP.

But wait--you asked both to add an alt-name to scRNA-seq and also to delete it. Do you mean to add an alt-name to the scRNASeq-10xgenomics dataset that we're copying over from HUBMAP? Should we also add the alt-name to the scRNASeq-10xgenomics-v2 dataset that we're copying over from HUBMAP? Why don't the HUBMAP versions already have the alt-name, if we're just porting things over?

@AlanSimmons After much discussion (only a bit of it documented here) the last two comments from Max are what we need.  @maxsibilla if it helps, maybe close this card and create a new one.

@AlanSimmons I wasn't sure whether to just close this card and create a new one or just update this one.
The ask is to:

Remove the existing scRNA-seq assay type
Copy over the scRNAseq-10xGenomics-v3 dataset from HUBMAP.
Copy over the scRNAseq-10xGenomics-v2 dataset from HUBMAP

Changes to SENNET source:

Removed scRNA-seq and its associated nodes.
Copied over scRNASeq-10xGenomics-v3 assay and associated nodes.
Copied over scRNASeq-10xGenomics-v2 assay and associated nodes.
Changed derived_from relationship from scRNA-seq (10x Genomics) [Salmon] dataset from scRNA-seq to above 2 assays. (This is currently transparent, but was in the ontology.)

in Globus


Conditionally hide/disable Submit button

I'd love to be able to conditionally hide or disable the Submit button based on the value of another field.
An example use case for this is when a respondent is asked to enter their email address twice for confirmation, and the addresses do not match. A calculated field can detect that the addresses are different - and branching logic can be used to display a warning - but there is no way to prevent a user from submitting the survey anyway.

I've done it with Shazam, but it would be nice to make this easy...
-A

From: Sam Gardiner<EMAIL_ADDRESS>Sent: Monday, November 30, 2020 8:21 PM
To: susom/redcap-em-survey-ui-tweaks<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [susom/redcap-em-survey-ui-tweaks] Conditionally hide/disable Submit button (#3)
I'd love to be able to conditionally hide or disable the Submit button based on the value of another field.
An example use case for this is when a respondent is asked to enter their email address twice for confirmation, and the addresses do not match. A calculated field can detect that the addresses are different - and branching logic can be used to display a warning - but there is no way to prevent a user from submitting the survey anyway.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/susom/redcap-em-survey-ui-tweaks/issues/3, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABY5VMLQJZKWBNLHRFYITH3SSRVL3ANCNFSM4UIO6JDA.


Exception when using tabs in Firefox

Hello,
I receive some exceptions with your plugin when I use it with tabs. The first panel is well rendered (if it's the active one), but not the others (which are hidden by default) :

The problem comes from line 214 :
var textWidth = dummyText.node().getBBox().width;
It seems getBBox() does not work very well in Firefox when using it inside tab panels.
This issue advises to use getBoundingClientRect() instead of getBBox(), and it works for me.
By the way thank you for this plugin !

Thanks for the information!


reduce number of connections

currently on mainnet, average number of connections is around 200 connections per node, and this is mainly due to the high storage radius and high number of nodes (relative to the radius) so the max connections per bin should be adjusted.
We can achieve this by reducing the over saturation peers count from 20 to 16 in kademlia.

May I ask what is the reason to reduce the number of connections? Number of connections influences the network topology with the consequence of changing the number of hops required for a chunk to reach the desired node. It would be good to measure what is the benefit in respect of the download and upload performance (speed and resource consumption) before settling on the saturation peers count. I would even say that a dynamic saturation peers count is a good thing to have based on the network conditions, but that would be a bit larger feature to add.

That reminds me of an old branch from 3 years ago :) https://github.com/ethersphere/bee/pull/2530
The simple reason is to reduce the connection count or limit it without hopefullt not hurting performance.
I believe we can achieve better performance by increasing the peer count for shallower bins and fewer peers for deeper bins. This may seem counterintuitive but on average half of the chunk requests will go to bin 0 because relative to your address, half of the network falls in your bin 0.
So instead of having 16 suffix addresses (4 bits) for all of the bins, image that we have 64 balanced addresses for bin 0, then 32 for bin 1, 16 for bin 3, 8 for the rest of bins, request hops could be drastically reduced, and the total sum of connection count will lower than 200.

May I ask what is the reason to reduce the number of connections?

I believe the origin of this request is due to some home routers becoming completely saturated and leaving the local network unusable when multiple bee nodes are run.

I believe the origin of this request is due to some home routers becoming completely saturated and leaving the local network unusable when multiple bee nodes are run.

A configurable maximal number of connected peers would be good to have for such situations for users to fine tune based on resources. Kademlia already has SaturationPeers in its Options struct it just is not configurable using cli flags or configuration files.
I still believe that reducing the number of peers is not the best solution, but to address the issue in the syncing protocols.

This should definitely be a SWIP first.
Actually, the peercount in the PO bins ought to be chosen to reflect 1) the connectivity restrictions of a node and 2) the throughput requierments.

should be calibrated or bounded by a configurable constant non-negative integer (yes, in fact setting it to 0 should create a non-connected local client).

should be informed by the distribution of chunk push and retrieve requests.

is working the following way.
A) Let's consider a random sample of N swarm chunks. When you take the chunks PO with respect to a particular address the POs follow a reverse expobential scale. In particular, in PO i, you will have 2^{1-i}*N chunks. Therefore when a node sends requests for these N chunks the number requests that should be routed to a peer in PO bin i is 2^{1-i}*N.
The chunks falling into a bin are uniformly distributed so as long as the peers in the bin are balanced each gets the same amount of requests.

Our ultimate goal is to handle requests most efficiently, i.e., to potentially max out the throughput of each peer in the event of a lot of requests.
With the naive assumption of the throughput of each peer connection being constant (or at least a distribution independent of the peer). the best strategy to max out throughput is to have a uniform distribution of requests over peers.
You need to connect to each node within the neighbourhood designated by the storage depth D, i.e., cca S*2^{-D}
If the max of peers is M, you got R=M-S*2^{-D} connections to allocate to the first D PO bins.
So if you operate a swarm node with a local API calls and do not participate in to guarantee uniform distribution, then you  need 2^{1-i}*R peers in PO bin i.
The same applies if the node is serving requests to light clients with 1 connection
Interestingly, if you are a node operator and not using the API, ie. only do forwarding for full nodes with saturated kademlia table, then the distribution of requests is constant across bins so you need to put R/(D-1) peers in each of the bins 1, ..., d-1
So,

using the exponential decay formula peers in shallower bins will idle when it is forwarding traffic.
using the constant formula, peers in deeper bins will idle when it is API or light cllient traffic.
opportunistic caching probably tiltts the whole thing towwwards expo decay..

now go figure

Actions taken so far:

Oversaturation count per bin has been reduce from 20 to 18. https://github.com/ethersphere/bee/pull/4760
The prune bin function was using the wrong counting method, so 1-2 peers were being pruned frequently unnecessarily https://github.com/ethersphere/bee/pull/4759
Stopped pullsyncing with peers below a certain bin  https://github.com/ethersphere/bee/issues/4762


Create a SvelteKit  construct

Not sure what to leave in the comments here but it would be cool if there was a SvelteKit construct. An adapter would have to be written similarly to how Astro works - https://kit.svelte.dev/docs/writing-adapters.
I would be willing to work on the adapter if help is wanted.

Duplicity with #2128

Also registering our interest in a SvelteKit component!

@hmprt leave a message in here? https://github.com/serverless-stack/sst/issues/2128

Officially released the SvelteKitSite construct.
Get started here — https://docs.sst.dev/start/svelte


showXLabels opstion dont work on line chart

Hello, im tryin to build a line chart, ihave too many xlabels il trying to hide it by step, i passed this options (see code below) but seem like it dont work. Did somebody have an idea.
Thanks.
const Options = {responsive: true,showXLabels: 4};

<PanelChart title ="GRAPH WATTAGE">
           <Line data={data} height={100} options={Options} />
         </PanelChart>

Hi,
Haven't configured it in that way so far. But check http://www.chartjs.org/docs/#chart-configuration , there is xLabels property you can add to data property.
At least so it seems .

Thanks a lot, by the way good job this component is really useful

Thanks  a lot @lilwayne470 ! Cuddos are going to contributors 👍


REST API & Text on screen

Congratulations for this project.
2 ideas for improvements:

Add a REST API to be able to control the screen via home automation
Offer the possibility to send a text to scroll on the screen

I like the idea! Maybe an endpoint to which you can send the matrix and a few settings. You can do that now with websockets, but you have to establish a connection first.

Hello
Just a small contribution to separate the control part of the panel from the rest of the application and add compatibility with Adafr_it GFX (possibilité to print text): https://github.com/mlemarrec/ObegransadPanel
If you are interested I can try to integrate it into your project.

Just a small contribution to separate the control part of the panel from the rest of the application and add compatibility with Adafruit_GFX: https://github.com/mlemarrec/ObegransadPanel

I was also trying to implement this but as my cpp skills are not the best I  still dont have it working.
I would loooove a REST API to send my current solarpanel panel power as a by time growing bar graph. The posibility to send a Json containing the array would be more than enough for me.


New header design

Here are some examples:
<vue-cal header-type="row" />

<vue-cal title="My events" header-type="row" />

<vue-cal title="My events" header-type="row" :header-order="['title-bar','name','menu']" />

@EdnaldoNeimeg, Thanks for your PR and nice layout idea!
Let's keep this outside of Vue Cal though as you can already customize enough to get to this layout :)


Zero value color option

Description

What was changed in this pull request?

This adds the option zeroValueColor for the horizontal-multivec track.

Why is it necessary?

Users may want to customize the color mapping for zero values.
Fixes #851
Checklist

[ ] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[x] Unit tests added or updated
[x] Documentation added or updated
[ ] Example(s) added or updated
[ ] Update schema.json if there are changes to the viewconf JSON structure format
[ ] Screenshot for visual changes (e.g. new tracks or UI changes)
[x] Updated CHANGELOG.md

Actually, I just realized that this is more useful than I originally thought. If it's not too much trouble, do you think you could add this option to regular heatmaps as well?
Here's an example: http://higlass.io/l/?d=d43xOBm2RXmAlQ13Ag5nBQ
You should see two faint dots in that view. If you zoom in, they'll disappear because the color scale will be from 2 to 2 and be completely white. Having a zero color would make this example work as expected.
And it would be nice to also have this selectable in the track's config menu. That's really easy to add, you just have to add the option's name to the track info for each track it should apply to:
https://github.com/higlass/higlass/blob/develop/app/scripts/configs/tracks-info.js
And then define the available options in the menu. Should be as simple as copying one of these entries and giving it a name:
https://github.com/higlass/higlass/blob/6cfce1d0e24a0c43c40684e211a3a67e8feb59ce/app/scripts/configs/options-info.js#L248

Yes I will look into that tomorrow. Thanks for pointing me to the options menu info.
And I am getting some kind of chrom-sizes error for the example:

You can ignore that error. It's the genome position search box looking for chromosome sizes to use.

Ah I see now, I did not realize I just had to zoom out in the example, and that that was the whole point. I added the option to the heatmap track type and options menu config in the latest commit

Looks good.
* How do we currently render zero values?

Currently they are rendered based on the colorScale function

* Is it possible to make zero values transparent?

I have added this functionality here https://github.com/higlass/higlass/pull/852/commits/a0cca45b5cbab1763c09a56c803db0fb4b236841#diff-96ac9aced876173486b7f83ac8d7ace2R5

* The zero color is different from the NaN color? If so would you mind clarifying that in the docs?

If the value is NaN then no value is set in pixData https://github.com/higlass/higlass/blob/develop/app/scripts/worker.js#L154


Published version on npm doesn't generate bin directory.

The version published on npm doesn't include or generate the bin (now named dist) directory. Might be worth publishing a new version with the most recent changes.

Hi,
I've fixed it by

Open package.json

Find:
  "main": "bin/push.js",

Replace as:
  "main": "push.js",

Open push.js

find:
module.exports = (factory(global, global.document))();

replace as:
module.exports = new (factory(global, global.document))();

A good temporary workaround, however this could do with being fixed on the published version too.

This was fixed in PR #8. The npm package now only contains a package.json and a dist directory. Version 0.0.3 was published this morning containing the fix.


Got rid of Could not find module 'nativescript-health-data' error

Fixes #6

After thinking, this shouldn't go to master


Facebook (new interface) doesn't show December birthdays regardless of language

Even if I switch to one of the 4 supported language, https://www.facebook.com/friends/birthdays still does not show December birthdays (I do have friends born in December), and your extension also fails to get them. Obviously it's an upstream issue, but just letting you know.

Update: December birthdays do show on https://m.facebook.com/events/calendar/birthdays

Adding custom birthdates added in #94


Nightly test fix: add filter to warnings

Description
nightly test fails because of warnings that have been introduced. However there are no ways to not get the warnings at the moment. Adding filters to ignore them.
That's a bad solution, but I think it's worst to simply ignore warnings in the nightly tests. We need to either remove the warnings that have been introduced in : https://github.com/apache/incubator-mxnet/pull/14214, suppress the warnings in the imports / onnx load API or update the API to specify the type at model loading time.

@mxnet-label-bot add [Test, pr-awaiting-review]

I run it on my EC2 instance and all failed tutorials are working now.


Can I make a container resizable?

I am trying to add a navigation bar inside the golden-layout. And unlike other components, I don't want it to be resizable, I will give it height and width after that user can not drag to resize the container.
So is that possible to achieve this function? Or Is there any way that I can make the resize bar disappear?

You can set the css of the reisze to display none to remove the resize. Dont think there is a property.
Or do you mean the container for the whole layout?


Unable to deploy HTTPTrigger function to the function app

Repro steps:

Deploy a local python function to my Azure subscription function app

VS Code output deploy FA.txt

Action: azureFunctions.deploy
Error type: BadRequest
Error Message: Encountered an error (InternalServerError) from host runtime.
Version: 0.20.0
OS: win32
Product: Visual Studio Code
Product Version: 1.40.1
Language: en

Call Stack
extension.bundle.js:218:2797983extension.bundle.js:218:2797983
s extension.bundle.js:218:111766
s extension.bundle.js:164:25792
extension.bundle.js:164:27034extension.bundle.js:164:27034
o extension.bundle.js:164:670342
extension.bundle.js:164:24705extension.bundle.js:164:24705
$._callback extension.bundle.js:1:636382
$.t._callback.t.callback.t.callback extension.bundle.js:194:5590
$.emit events.js:200:13
$.<anonymous> extension.bundle.js:194:18450
$.emit events.js:205:15
IncomingMessage.<anonymous> extension.bundle.js:194:17282
Object.onceWrapper events.js:288:20
IncomingMessage.emit events.js:205:15
endReadableNT _stream_readable.js:1154:12
processTicksAndRejections task_queues.js:84:9

This seems like the important line:
Failed to upload because Azure Storage responds 403.
8:56:09 AM avtdevwus2fasilvercreekplt: This request is not authorized to perform this operation.

Do you have permissions for that storage account?
You can also try a new deployment method which doesn't directly access the storage account like that. See https://github.com/microsoft/vscode-azurefunctions/wiki/Remote-Build


[docs-infra] Support product-specific bell notifications

Currently, we display all notifications present in notifications.json across all documentation websites, regardless of product.

{
    "id": 68,
    "title": "Check out Base UI today 💥",
    "text": "Love Material UI, but don't need Material Design? Try Base UI, the new \"unstyled\" alternative. Read more in this announcement."
  }

I propose adding a productId key to this notification object, which would be an array of product IDs on which to show the notification. If not present, the default behaviour would still be to render this across all docs websites.

For example,
{
    "id": 85,
    "title": "Shape Toolpad's future",
    "productId": ["toolpad-core", "toolpad-studio", "x-data-grid", "x-charts", "material-ui"],
    "text": "Love the speed of low-code, but feel limited because of a lack of customization? We're building Toolpad Core, the fastest way to bootstrap dashboards and internal tools with React and Material UI. Share your opinion in the RFC.."
  }

We can use pageContext.productId to make sure that the messages array in the <Notifications /> component reacts to changes in the page and is filtered based on the current productId.

Search keywords:

Notification, Product-specific, separate notifications

it seems like this is a duplicated of https://github.com/mui/material-ui/issues/41664, right?


Can not edit code

When I press "e", it has not effect and won't enter vim mode. I have set the ext and path in config file.

Yes, it's a bug, will be working on it. Thanks for reporting.

Are you running "leetcode" inside tmux?

No, just normal mode. Tried both Terminal and iTerm on MacOS.

Did you set tmux_support in your config.cfg?

No

Could you try to run command export EDITOR=vi before run leetcode again?


Space around globe

Love the project, congrats!
When I set width and height, there is still much space on each side. May there be a way to set a padding? And the canvas is always centered. a "position: left"-option would be very nice :-)

adding margin + fix world3d

https://github.com/earthjs/earthjs/commit/28c0f3c3c58c20611b4762e80b23f0bf861b74ef

Thank you very much, works fine!


Infinite recursion during compilation

Hi @Naios
Our team develops https://github.com/soramitsu/kagome/ in C++17. We decided to use continuable instead of callbacks to simplify our code.
We integrated latest master (42af23f) and started to refactor interfaces.
Me and my team mate (separately) run into the same problem of infinite recursion during compilation.
We both use latest Mac OS, latest CLion for development, same compiler (Apple LLVM version 10.0.1 (clang-1<IP_ADDRESS>)).
In my case, it occurred after I added this chain (branch feature/ref-transport-continuable):
https://github.com/soramitsu/kagome/blob/feature/ref-transport-continuable/core/libp2p/transport/tcp/tcp_transport.cpp#L29
It looks legit, and I don't see any bugs there, but when you build tcp_transport target, it just never finishes (recurses infinitely). At some point I run out of disk space (clangd consumed more than 70GB) and compilation died.
Steps to reproduce:
I don't have time to create small self-container repo with repro code, but instead I will just share our project.
1. git clone --recursive https://github.com/soramitsu/kagome/
2. cd kagome
3. mkdir build
4. cd build
# this step may take a while, since hunter builds all our dependencies during cmake time
# after it completes, you can remove ~/.hunter
5. cmake ..
6. make tcp_transport

@Warchant, I ran into the same issue a while back. This is a bug in Clang and it has been already fixed (in Clang).
I remember that I managed to find a workaround for it, but sadly I do not remember what it was. I believe this was fixed in Clang 7.0. You could install Clang 7+ using Homebrew or another package manager and use a newer Clang without this bug. It's a bit sad how slow Apple is when updating their AppleClang with upstream Clang.

@Warchant could you test whether updating Apple Clang to version 7 fixes your issues then?

@Naios

clang-8.0.0_1 - problem persists.

clang version 8.0.0 (tags/RELEASE_800/final)
Target: x86_64-apple-darwin18.6.0
Thread model: posix
InstalledDir: /usr/local/Cellar/llvm/8.0.0_1/bin

Explicit types solved the problem
conn->resolve(rendpoint.value())
-    .then([conn](auto&& iterator) {
+    .then([conn](TcpConnection::ResolverResultsType iterator) {
       return conn->connect(std::move(iterator));
     })
     .then([self, conn]() {
       return self->upgrader_->upgradeToSecure(conn);
     })
-    .then([self](auto&& secureConn) {
+    .then([self](std::shared_ptr<connection::SecureConnection> secureConn) {
      return self->upgrader_->upgradeToMuxed(std::move(secureConn));
    })
    .then([promise{std::move(promise)}](
-              auto&& capableConn) mutable {
+              std::shared_ptr<connection::CapableConnection> capableConn) mutable {
      return promise.set_value(std::move(capableConn));
    });

I will take a look into this if I have some spare time. The issue probably isn't severe if this can be fixed through concrete types. Also it might be that this isn't related to this library at all and caused by a compiler bug.

The problem persists even if the types are explicitly specified as follows:
cti::make_continuable<std::string>([](cti::promise<std::string> promise) {
    promise.set_value("hello");
}).then([](std::string str) {
    // do not return new continuable
}).then([](int num) {

});

cti::make_continuable<std::string>([](cti::promise<std::string> promise) {
    promise.set_value("hello");
}).then([](int num /* inconsistent type */) {

});

@eldenchen Can you give more details about your affected environment? (compiler and toolchain version)?

Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

I've found the problem that caused this issue:
The library triggers a static_assert correctly if a callable can't be called with a subset of its arguments but it seems like this is not enough to stop clang causing the generation
of a 0 - 1 -> std::size_t::max length index sequence which obviously causes infinite work.
I've specialized the code such that the generation of an infinited index sequence is prevented (this happened before only if the code was malformed and a static_assert was triggered previously).
Thanks @eldenchen for the reproducible example.


Site build on master pages

Hi,
I'm n00b using travis CI. I have managed to build a site using gh-page, but now i want to make use of the Jasper theme on a USERNAME.github.io site, that use master branch, I change to  but I have an error on the build can you helpme:
bundle exec rake site:deploy --quiet
Cloning into '../adle'...
error: pathspec 'source' did not match any file(s) known to git.
rake aborted!
Command failed with status (1): [git checkout source...]
/home/travis/build/acercadelaeducacion/acercadelaeducacion.github.io/Rakefile:60:in `block (2 levels) in <top (required)>'
/home/travis/.rvm/gems/ruby-2.1.10/bin/ruby_executable_hooks:15:in `eval'
/home/travis/.rvm/gems/ruby-2.1.10/bin/ruby_executable_hooks:15:in `'
Tasks: TOP => site:deploy
(See full trace by running task with --trace)

Sorry, Its done, I take of
branches:
only:
master
and it work.


Support caching for STS server

Please provide a description for what this PR is for.
Add fetched access token into cache. If the remaining life time is larger than grace period (default: 5 min), STS server returns cached token.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
https://github.com/istio/istio/issues/20133

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
fc4db9a2e88eaee1e10414d5559721b7b1377a53
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
fc4db9a2e88eaee1e10414d5559721b7b1377a53
link
/test lint_istio

gencheck_istio
fc4db9a2e88eaee1e10414d5559721b7b1377a53
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
fc4db9a2e88eaee1e10414d5559721b7b1377a53
link
/test gencheck_istio

lint_istio
6e90e4eb4016089fdda821e191d4b976e7bdac92
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
b68fb7025ee555175e73e799904fc330091a9d53
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

/test integ-telemetry-k8s-tests_istio

/test integ-mixer-k8s-tests_istio

In response to a cherrypick label: new pull request created: #21051


Uncaught TypeError: Cannot read property 'make' of undefined - Jodit

Getting this error recently on the React project.
Jodit Version - 1.0.42
React version (CRA) - 16.13.1
Reference Image

having this error too.
"jodit-react": "1.0.42",

This appears to be fixed in the latest version.  The issue must have been related to xdan/jodit#414


Fixed profile and auth UI

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[x] Mobile width screenshots

[x] Testing

[x] Changes have been manually tested

What are the relevant tickets?
Fixes #175
Fixes #178
What's this PR do?

Gets rid of the profile view page, and changes the profile link to go directly to the profile edit page
Fixes the styling for the profile/account settings pages and all of the auth pages so that the spacing is consistent and the cards still show up as expected in mobile screen widths
Makes some common sense fixes (e.g.: moving the title inside of the card and changing the buttons on profile/account pages to match the styling of the auth pages, getting rid of unnecessary HTML elements, incorrect grammar in error messages)

How should this be manually tested?
This PR touches every auth page and the profile/account settings pages, so a thorough functional test would include looking at all of these pages and making sure they look good in for all screen widths:

Sign in
Create account
Create account "thank you" (where you land after you submit an email to the Create Account form)
Forgot password
Register details (where you land when you click the email verification link)
Edit profile
Edit account settings

Any background context you want to provide?

The profile/account settings pages were not included in the mitxonline designs, so we kept a lot of styling from mitxpro for those pages. To me it made sense to match the styling of those pages/forms to the auth pages, which do have designs for mitxonline, so I made a lot of judgment calls to work toward that goal

Screenshots (if appropriate)
AUTH PAGES (mobile)

PROFILE/ACCOUNT PAGES

Does this fix https://github.com/mitodl/mitxonline/issues/178 as well?

@pdpinch It does. Thanks for the reminder. I forgot to put that in the PR description

We got designs for these pages now. If it's not too late, can we incorporate them?
https://invis.io/ZF11PHMQJ6CK#/458318719_MITx_-_Profile_-_Edit
https://invis.io/KH11PMX9ZRQE#/458318720_MITx_-_Account
https://invis.io/EF11PMX5X3TY#/458325008_Username_States

Do you know how removing the static profile page interacts with open edX?
I'm not sure, but I think there are two places where open edX might link to a profile:

user menu, where linking to a profile edit form makes sense
forum post, which probably isn't working at all

now that I write this down, I think it's out of scope for this PR, but we should take a look at open an necessary follow-up issues.

@pdpinch I actually wasn't aware that edX might have links to a profile page. I can add an issue to explore that. Re: the designs, I think the only impact on this PR is a label on one of those fields + a header text change. I'll update this. I'm also pretty certain that you don't want to mess around with a user-uploaded profile image in this PR, so we can discuss that for a separate issue

@pdpinch Screenshots updated

@pdpinch could you please review the updated screenshots?

Codecov Report

Merging #185 (6a44431) into main (4c6a42e) will increase coverage by 6.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   90.74%   97.00%   +6.25%
==========================================
  Files         217      121      -96
  Lines        6301     2767    -3534
  Branches      308        0     -308
==========================================
- Hits         5718     2684    -3034
+ Misses        496       83     -413
+ Partials       87        0      -87

Impacted Files
Coverage Δ

static/js/components/UserMenu.js
100.00% <ø> (ø)

static/js/components/forms/ChangeEmailForm.js
100.00% <ø> (ø)

static/js/components/forms/ChangePasswordForm.js
100.00% <ø> (ø)

static/js/components/forms/EditProfileForm.js
100.00% <ø> (ø)

static/js/components/forms/EmailForm.js
100.00% <ø> (ø)

static/js/components/forms/LoginPasswordForm.js
100.00% <ø> (ø)

static/js/components/forms/RegisterDetailsForm.js
100.00% <ø> (ø)

static/js/components/forms/RegisterEmailForm.js
91.66% <ø> (ø)

static/js/components/forms/ResetPasswordForm.js
87.50% <ø> (ø)

static/js/containers/pages/login/LoginEmailPage.js
100.00% <ø> (ø)

... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6a42e...6a44431. Read the comment docs.

@umarmughal824 great catch! I'll take a look


[6751] Update PII info when sending DQT updates if allowed

Context
Changes proposed in this pull request
Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Send additional PII data to DQT via the update end point


Generates results in OpenMetrics format

Is your feature request related to a problem? Please describe.
Gtilab can display results if in OpenMettrics format.
Describe the solution you'd like
Generate metrics in OpenMetrics format.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Labels:

appid
branch
date ?
http_requests_total{service="users-directory", instance="<IP_ADDRESS>"}`
Metrics:
carboncrush_energy_Wh{appid="123", branch="branch2"}=1250
carboncrush_consumption_W{appid="123", branch="branch2"}=125
carboncrush_duration_s{appid="123", branch="branch2"}=10


fix: jump to correct definition when names overlap

Fixes #1170.
This PR adds the module name to RefIdent in order to distinguish conflicting names from different files. This also fixes related issues in find-references or the call hierarchy feature.
It also adds some docstrings and stylistically refactors a bunch of code.

!bench

Thank you so much, this will make my current project a lot easier to work with :-)


watch : Could not find a MSBuild project file in 'C:\Users\bhavi'. Specify which project to use with the --project option.

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/hello-world-tutorial/run
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
watch : Could not find a MSBuild project file in 'C:\Users\bhavi'. Specify which project to use with the --project option.

Is there subdirectory with the project? When you create new project it would typically create subdiretory in the current project.


Visualize JS

This replaces #4117.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

I merged the commits for the tools.  I haven't tested the other changes yet.


ImageDecoder.DecodeImage(PsdFile psdFile); does not support transparent background

My .psd file has a transparent background but when i call the DecodeImage-method and pass the loaded PsdFile the result bitmap have a white background color.
Can't find any overloads or settings to change this behavior.

To be able to render with transparency, you must render each layer on top of another with multiple calls to DecodeImage(Layer)


Create login page

ok

ok akash i will assign it you.

I want to work on this issue. I have previosly made some login pages UI . Kindly assign this issue to me.

I will assign it you when contribution will be started. till then you can connect with us on discord channel

I want to work on this issue under JWOC, can you assign me this @codervivek5

I want to work on this issue under JWOC

I am keenly interested to create a login page for this project , please assign me this issue under JWOC.

I want to work on this issue under JWOC

Add with sign-up


Adjust yarn commands

Ruby was setup for running the packages's unit tests, which wasn't necessary. This PR removes that redundant configuration and performs related changes.
Changes

Change postinstall script to after-install so that Ruby bundle command is not automatically run after yarn install, which is unneeded when working with the DS packages.
Remove run commands from yarn.
Break GHA workflow tests into unit tests and sauce workflows.
Minor docs adjustments to reflect changes.

Testing

PR checks should pass.

Merging in @wpears absence


remove useless AllocateNetwork

AllocateNetwork is replaced by ConfigureNetwork for a long time.
Signed-off-by: Gao feng<EMAIL_ADDRESS>

It seams that ReleaseNetwork() is not called by anyone either.

This should be a bug, we need release the ip address after pod destroyed at least. @laijs

could you also fix it please?


Unable to install contribution

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
When we try to install a new contribution to the WebUI fails with the following error in the server logs:
 Maximum call stack size exceeded {"stack":"RangeError: Maximum call stack size exceeded
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8670:23)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)
 at ContribInstallController.updateInstallState (/flogo-web/apps/server/main.js:8672:14)"}

Expected behavior
We should be able to  install new contributions to the WebUI
Minimal reproduction of the problem with instructions

Click on Install Contribution in the global header
Try to install github.com/project-flogo/contrib/activity/jsexec to the WebUI
Notice that the installation is failed with the above message in the server logs

Flogo version: latest (master)

Whats the status of this? Not being able to add contributions is a bit of a blocker

Just opened #1206 to fix it. It should only be affecting the master branch and not the latest released version (v0.9.0).

Thanks!


add prepa OnLine SEP México

Hi Could you add  my high school pls, its a public school in Mexico thx

https://prepaenlinea.sep.gob.mx/

@angeleskarina Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Make Modules configurable

The modules of the API needs to be configurable.
The configuration should be stored within the database.
Originally posted by @eddiejaoude in https://github.com/EddieHubCommunity/EddieBot/issues/573#issuecomment-874805732

We should handle the case if theres no config provided in the DB as well

Thank you for raising 👍

I'd put the configs in a own collection. Because of that I'd probably handle the Config-Logic in a own Module. What would be a good name for that module? I think we cant use ConfigModule as this is provided from the Nest-package.

Good question 🤔
What about ConfigDataModule? 🤷♂

Maybe this Issue should be split up into several smaller ones to prevent the PRs from getting to back. I think this issue might be more work than it looks at first glance

Yep, we could split it up per module

I think thats not relevant anymore either, because we dont want to run a multi-tenant approach anymore


ChangeDetectionStrategy.OnPush when using google places the map won't get updated on address click.

Issue description
when using   changeDetection: ChangeDetectionStrategy.OnPush the map is not auto updated when user clicks on the address.
Steps to reproduce and a minimal demo of the problem
I'm using google places autocomplete and when using  changeDetection: ChangeDetectionStrategy.OnPush the map is not auto updated when user clicks on the address.
I'm using the latest version 0.17.0.
If i don't use onPush then everything is fine. Is this behaviour expected?

Please create a plunkr.

here's the plunkr http://plnkr.co/edit/JioZS0CanaEUFIYMHTmd?p=preview  select and adrress, the map won't refresh until clicked outside of it.

This is intended. Even if you run it in the zone, the Change detection for the component won't run. You have to mark the component for a check with the ChangeDetectorRef service: ChangeDetectorRef#markForCheck.
Closing this as it is no bug. Feel free to reopen.

Thanks Sebastian, I was almost sure that this is normal behaviour.

Sebastian i updated the plunkr and it's working with ChangeDetectorRef, http://plnkr.co/edit/0V89B3BqW6ZurW8PbXuz?p=preview
I believe is ok now, if you have any better approach please let me know.
Thanks


update modal design

Codecov Report

Merging #122 into development will increase coverage by 0.02%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development     #122      +/-   ##
===============================================
+ Coverage        86.92%   86.94%   +0.02%
===============================================
  Files               20       20
  Lines              497      498       +1
===============================================
+ Hits               432      433       +1
  Misses              65       65

Impacted Files
Coverage Δ

src/modal/index.js
96.15% <100%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c7117...a126f56. Read the comment docs.


Update customer-key-availability-key-roll.md

We had a large customer 125k seats Rave case # 35048920 that initiated the roll process for the first time. They disabled the old key and saw clients unable to access mailboxes in growing numbers - re-enabled the disabled rolled key and were able to reconnect in 5 minutes for all mailboxes affected.  We only indicated not to delete this change changes that to delete or disable in the warning at the top. and also adds under Exchange DEP section "While this cmdlet starts the key roll operation for Exchange Online, the action doesn't complete immediately."

@KCCross Please merge this PR. Thanks

@KCCross Gentle reminder

@mabauerms Thanks for your feedback! New issues and pull requests for this content are closed while we update this content to support upcoming feature improvements.


Link to ASP.NET Core docs

ASP.NET Core has a pretty nice Create React App integration. Let's link to its docs.

Thanks @Daniel15!


improve mockability of generated code

The code generator emits a lot of boilerplate that could be captured in a base interface, and thus simplify the task of mocking a collection proxy. For example,
    public interface IItemCollection : ProxyExtensions.IReadOnlyQueryableSetBase<Models.IItem>

    {

        Models.IItemFetcher GetById(System.Guid id);

        Task<ProxyExtensions.IPagedCollection<Models.IItem>> ExecuteAsync();

        Task AddItemAsync(Models.IItem item, System.Boolean deferSaveChanges = false);

        Models.IItemFetcher this[System.Guid id]    { get; }
    }

...could become
    // unique to my model
    public partial interface IItemCollection : IEntityCollection<Models.IItem>
    {
        Models.IEntityFetcher<Models.IItem> GetById(System.Guid id);
    }

    // shared by all entity definitions, perhaps in ProxyExtensions assembly
    public interface IEntityCollection<T> : ProxyExtensions.IReadOnlyQueryableSetBase<T>
    {
        Task<ProxyExtensions.IPagedCollection<T>> ExecuteAsync();

        Task AddItemAsync(T item, System.Boolean deferSaveChanges = false);

        Models.IEntityFetcher<T> this[System.Guid id]    { get; }
    }

    public interface IEntityFetcher<TSource>

    {
        Task<T> ExecuteAsync();

        T Expand<TTarget>(System.Linq.Expressions.Expression<System.Func<TSource, TTarget>> navigationPropertyAccessor);
    }

Is the team amenable to this kind of refactoring?

@jeffMSFT Thank you for the issue. Yes, we may be open to this at some point in the future. We just aren't in a position right now to take pull requests and review them.


docs(explore/overview): rework page

Docsathon
This PR removes some superfluous or duplicated information and makes it more of an overview.

@slonka Updated some parts of the page a little but more. I'll merge this but let me know if something else can be improved!


google.protobuf.message.DecodeError: Error parsing message when using tf.function

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 21.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): conda binary
TensorFlow version (use command below): tf.2.5
Python version: python 3.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: cuda 11.4, cudatoolkit 11.0.221,  cudnn <IP_ADDRESS>
GPU model and memory: NVIDIA TITAN RTX, 24Gb

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Successfully opened dynamic library libcudart.so.11.0 v2.5.0-rc3-213-ga4dfb8d1a71 2.5.0
Describe the current behavior
I write a custom model involving the tf.gather_nd function. When the 'train_step' function is not decorated   by 'tf.function', the model can be well-trained. But when I use 'tf.function' to decorate the 'train_step' function, I get the error 'google.protobuf.message.DecodeError: Error parsing message'.

Describe the expected behavior
The model can be trained.
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing): no

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf
import numpy as np

class GatherModel(tf.keras.Model):
    def __init__(self,ind1,w1):
        super(GatherModel, self).__init__()
        self.ind1=ind1
        self.w1=tf.cast(w1,tf.float32)
        self.lambda1 = tf.Variable(initial_value=tf.constant(0.1), trainable=True, name='lambda1')

    def __call__(self, inputs,training=0):
        y=inputs
        for i in range(5):
            y=tf.transpose(y, [1, 2, 3, 0])
            y=tf.gather_nd(y*1.0, self.ind1)
            y=y*self.w1
            y=tf.reduce_sum(y,0)
            y=tf.transpose(y,[3,0,1,2])
            y = self.lambda1*y
        return y

# @tf.function
def train_step(model, inputs, labels, Loss, optimizer):
    with tf.GradientTape() as tape:
        predictions = model(inputs, training=1)
        loss = Loss(labels, predictions)
    grads = tape.gradient(loss, model.trainable_variables)
    optimizer.apply_gradients(zip(grads, model.trainable_variables))
    return loss

if __name__ == '__main__':
    ind1=np.random.randint(0,300,[367, 217, 721, 2])
    w1=np.random.normal(size=[367, 217, 721, 1, 1])
    Model=GatherModel(ind1,w1)
    inputs=tf.random.normal([2,256,256,1])
    labels= tf.random.normal([2,217,721,1])
    loss=tf.keras.losses.MeanSquaredError()
    optimizer=tf.keras.optimizers.Adam(0.001)
    for i in range(10):
        LL=train_step(Model,inputs,labels,loss,optimizer)
        print(LL)

In the google colab   https://colab.research.google.com/drive/1TrTctTKjYOIrZ2rvKhQmdTDS77d0gmg9#scrollTo=WMcegEVFWW_M, it says that the program is crashed because of  exhausting of RAM.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Hi! @wangwei-cmd ,@sanatmpa1 , I was able to replicate this in TF 2.4/2.5/2.6 .providing gist for reference . Colab environment crashed when decorated @tf.function

It looks like the crash is unrelated with the original error message ("google.protobuf.message.DecodeError: Error parsing message"). The crash is likely due to the huge tensors ind1 and w1. That might also be the cause of the DecodeError, but let's rule it out by using smaller shapes which fit inside colab's RAM.
@mohantym can you reproduce the DecoderError in a gist?

@mdanatg, yes, I think the crash is because the RAM were exhausted. I don't how why @tf.function needs so many RAM. Can someone  explains the reasons. Thanks a lot.

@mdanatg Thank you. But if self.w1 is a fixed numpy array, how can I modified the code to avoid RAM exhausting.

@wangwei-cmd ! Can this issue be closed then?

Yeah, the problem is solved. please close it.

Ok @wangwei-cmd ! Thanks for confirming the same. Closing this issue as it seems to resolved.


Test Cases

Describe the solution you'd like
We need 60 more test cases, 20 per team member, that improve the reliability of the codebase by improving the branch, line, and function coverage of this extension. We also need new test cases for new features added the project. Reference this issue when your commit includes test cases for new/existing features.

Resolved by PRs #9 #11 #12 #14

20 test cases added to the codebase by each team member.


Pilot alert and console flavortext

About the PR
Adds extra flavor text to consoles.
Replaces placeholder PILOT alert with a OC icon drawn by me.
Screenshots

Changelog

:cl: CrudeWax

add: Added additional flavor text to consoles
tweak: Replaced placeholder piloting alert icon

Not a big fan of the changes:

The majority of them have spelling / grammar mistakes.

Most of them just make the description unnecessarily long to put teh funney in.
I'm not a big fan of the alert icon but it's better than what we have I guess.

Some of the added descriptions seem pointless to me/make it unnecessarily bloating.
Also im sorry but i dont like that icon, it just looks weird and isnt descriptive :D I was more thinking putting a spaceship there or smth? maybe just the classic tilted rocket?

Just trim it down to the icon to merge and we can talk about the descriptions in another PR or on discord.


A11y design enhancements

What I did
I have modified the X and check marks to be more accessible because the color of the X alone is difficult extract meaning from if you are visually impaired. They now are colored and list out the severity/urgency of the issue (which really provides better information anyway).
OLD:

NEW:

I also updated the text that appears when there aren't any rules within a tab. It used to use the word "A11y" and now it uses the word "accessibility". This helps people that don't understand what a11y means.
OLD:

NEW:

The global checkbox and all of the badges now respond nicely (when the addons panel is mobile, vertical, or horizontal).
OLD:

NEW:

How to test

Is this testable with Jest or Chromatic screenshots? Sure
Does this need a new example in the kitchen sink apps? no
Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

Wow! Looks good!
Firstly, I think need to fix conflicts.

Shoot I removed that magic number constant when I was testing something.
Nice catch!  I’ll make sure to add that back in. I originally had media
queries but media queries aren’t responsive when the addon panel is
shortened in width in the vertical view.
On Thu, Apr 18, 2019 at 4:07 PM Arman<EMAIL_ADDRESS>wrote:

@Armanio requested changes on this pull request.
In addons/a11y/src/components/Report/Rules.tsx
https://github.com/storybooks/storybook/pull/6563#discussion_r276808866:

fontWeight: '400',

} as any);
-const Item = styled.div({

display: 'flex',

flexDirection: 'row',

marginBottom: '6px',

-});
+const Item = styled.div(({ elementWidth }: { elementWidth: number }) => ({

flexDirection: elementWidth > 407 ? 'row' : 'inherit',

hmm, the magic number
why 407? what is it?
In addons/a11y/src/components/Report/Rules.tsx
https://github.com/storybooks/storybook/pull/6563#discussion_r276813047:

switch (rule.impact) {

case ImpactValue.CRITICAL:

 badgeType = 'critical';

 break;

case ImpactValue.SERIOUS:

 badgeType = 'negative';

 break;

case ImpactValue.MODERATE:

 badgeType = 'warning';

 break;

case ImpactValue.MINOR:

 badgeType = 'neutral';

 break;

default:

 break;

}

⬇ Suggested change

}

+const badgeType = rule.impact in ImpactValue ? rule.impact : null;
can simplify?
In addons/a11y/src/components/Tabs.tsx
https://github.com/storybooks/storybook/pull/6563#discussion_r276814069:

},

-}));
+const GlobalToggle = styled.div(({ elementWidth }: { elementWidth: number }) => {

const maxElementWidth = 450;

return {

cursor: 'pointer',

fontSize: '14px',

padding: elementWidth > maxElementWidth ? '12px 15px 10px 0' : '12px 0px 3px 12px',

height: '40px',

border: 'none',

marginTop: elementWidth > maxElementWidth ? '-40px' : '0px',

float: elementWidth > maxElementWidth ? 'right' : 'left',

display: elementWidth > maxElementWidth ? 'flex' : 'block',

alignItems: 'center',

width: elementWidth > maxElementWidth ? 'auto' : '100%',

borderBottom: elementWidth > maxElementWidth ? 'none' : '1px solid rgba(0,0,0,.1)',

why you didn't use media queries?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/pull/6563#pullrequestreview-228474095,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDCQBRRUFITHIZWYC6OPODPRDIJPANCNFSM4HG6OIUQ
.

I did try to find a css solution before going with a JS solution but
nothing came up for what I needed for this use case.
On Thu, Apr 18, 2019 at 4:10 PM Alexander Wilson <
<EMAIL_ADDRESS>wrote:

Shoot I removed that magic number constant when I was testing something.
Nice catch!  I’ll make sure to add that back in. I originally had media
queries but media queries aren’t responsive when the addon panel is
shortened in width in the vertical view.
On Thu, Apr 18, 2019 at 4:07 PM Arman<EMAIL_ADDRESS>wrote:

@Armanio requested changes on this pull request.
In addons/a11y/src/components/Report/Rules.tsx
https://github.com/storybooks/storybook/pull/6563#discussion_r276808866
:

fontWeight: '400',

} as any);
-const Item = styled.div({

display: 'flex',

flexDirection: 'row',

marginBottom: '6px',

-});
+const Item = styled.div(({ elementWidth }: { elementWidth: number }) => ({

flexDirection: elementWidth > 407 ? 'row' : 'inherit',

hmm, the magic number
why 407? what is it?
In addons/a11y/src/components/Report/Rules.tsx
https://github.com/storybooks/storybook/pull/6563#discussion_r276813047
:

switch (rule.impact) {

case ImpactValue.CRITICAL:

 badgeType = 'critical';

 break;

case ImpactValue.SERIOUS:

 badgeType = 'negative';

 break;

case ImpactValue.MODERATE:

 badgeType = 'warning';

 break;

case ImpactValue.MINOR:

 badgeType = 'neutral';

 break;

default:

 break;

}

⬇ Suggested change

}

+const badgeType = rule.impact in ImpactValue ? rule.impact : null;
can simplify?
In addons/a11y/src/components/Tabs.tsx
https://github.com/storybooks/storybook/pull/6563#discussion_r276814069
:

},

-}));
+const GlobalToggle = styled.div(({ elementWidth }: { elementWidth: number }) => {

const maxElementWidth = 450;

return {

cursor: 'pointer',

fontSize: '14px',

padding: elementWidth > maxElementWidth ? '12px 15px 10px 0' : '12px 0px 3px 12px',

height: '40px',

border: 'none',

marginTop: elementWidth > maxElementWidth ? '-40px' : '0px',

float: elementWidth > maxElementWidth ? 'right' : 'left',

display: elementWidth > maxElementWidth ? 'flex' : 'block',

alignItems: 'center',

width: elementWidth > maxElementWidth ? 'auto' : '100%',

borderBottom: elementWidth > maxElementWidth ? 'none' : '1px solid rgba(0,0,0,.1)',

why you didn't use media queries?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/pull/6563#pullrequestreview-228474095,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDCQBRRUFITHIZWYC6OPODPRDIJPANCNFSM4HG6OIUQ
.

The width logic sounds good to me. There's no way to tell container dimensions with media queries so when the addon panel's orientation changes it may end up using a suboptimal layout.

@CodeByAlex build fails:
yarn run v1.12.3
$ node ./scripts/repo-dirty-check
 M yarn.lock
Git repo is dirty, please consider updating lockfiles by running `yarn bootstrap --reset --core`

@Shilman Done!

Wow, this takes the a11y addon from 'useful' to 'amazing', this is fantastic @CodeByAlex !


Standalone setup file

Thanks for this plugin!
When I tried to move the setup config into a standalone lua file like I did for other plugins, an error occurs:
Error detected while processing /Users/ce/.config/nvim/init.lua:
E5113: Error while calling lua chunk: ./tabout.lua:1: loop or previous error loa
ding module 'tabout'
stack traceback:
        [C]: in function 'require'
        ./tabout.lua:1: in main chunk
        [C]: in function 'require'
        /Users/ce/.config/nvim/lua/plugins/tabout.lua:1: in main chunk
        [C]: in function 'require'
        /Users/ce/.config/nvim/lua/plugins/init.lua:9: in main chunk
        [C]: in function 'require'
        /Users/ce/.config/nvim/init.lua:1: in main chunk

Here is my config structure
.
├── after
│   └── ftplugin
├── init.lua
└── lua
    ├── init.lua
    └── plugins
        ├── init.lua
        ├── cmp.lua
        ├── ...
        └── tabout.lua

I require every files in the plugins directory in the lua/plugins/init.lua file.
And here is my tabout config (the example config):
require'tabout'.setup({
    tabkey = '<Tab>', -- key to trigger tabout, set to an empty string to disable
    backwards_tabkey = '<S-Tab>', -- key to trigger backwards tabout, set to an empty string to disable
    act_as_tab = true, -- shift content if tab out is not possible
    act_as_shift_tab = false, -- reverse shift content if tab out is not possible (if your keyboard/terminal supports <S-Tab>)
    default_tab = '<C-t>', -- shift default action (only at the beginning of a line, otherwise <TAB> is used)
    default_shift_tab = '<C-d>', -- reverse shift default action,
    enable_backwards = true, -- well ...
    completion = true, -- if the tabkey is used in a completion pum
    tabouts = {
      {open = "'", close = "'"},
      {open = '"', close = '"'},
      {open = '`', close = '`'},
      {open = '(', close = ')'},
      {open = '[', close = ']'},
      {open = '{', close = '}'}
    },
    ignore_beginning = true, --[[ if the cursor is at the beginning of a filled element it will rather tab out than shift the content ]]
    exclude = {} -- tabout will ignore these filetypes
})

Maybe this is a trivial issue, but since I haven't encountered it before, I have no clue. Thanks for any help!

Hi @zcysxy
Looks similar to my approach at first glance.
Can you do some test runs?
Start with a completly empty tabout.lua file, that should not throw. If it does, something is off in your configs.
Then just add require'tabout'.setup() to the file, that should also work. If not, maybe tabout is not installed correctly. And then add your config line by line. After adding a line, start nvim. If it fails here, it may be spelling or a comma...or I messed a function up. Let me know what it is.

Thanks for the reply @abecodes! Yeah, it works with the empty taubout.lua, but a single line require'tabout'.setup() throws the error. I install the plugin with Packer:
    use { 'abecodes/tabout.nvim',
        wants = {'nvim-treesitter'},
        after = {'nvim-cmp'}, }

And PackerStatus and the plugin folder show tabout.nvim correctly. I also tried reinstalling the plugin.

Hmm,
I guess its an issue with the load order then.
If you just install it with packer, remove the tabout.lua and run :lua require'tabout'.setup() it should work. If you get the :Tabout completion, it worked and the load order of your scripts is somehow wrong.
Hope that helps 😊


Unset pointer focus when surface is destroyed

Pointer focus is stored as surface_id integer, and it is not unset when surface is destroyed. I modified to code to unset pointer focus and store it as pointer of ivisurface. I simplified code a little bit by passing ivisurface pointers instead of surface_ids. Because it is easier to get ivi_layout_surface, seat_ctx or input_context from the ivisurface.

@HarshaMM Please review

@eucan started review

looks good for me, review-by


Support quick fix for override keyword "Add member to base class" in typescript

Add override quick fix to add member to base class

Sorry about missing context.
In typescript language add quick fix: "Add member to base class" for override method missing in base class.

/needsMoreInfo

Hi, sorry about missing context.
In typescript language add quick fix: "Add member to base class" for override method missing in base class.

Please share an example of what this would look like

I'll try explain the request.
Inside a typescript class that extends a base class writing override someMethodName(){} will have a quick "Add member to base class" in case someMethodName is not defined in base class.

Thanks, opened https://github.com/microsoft/TypeScript/issues/45172 to track upstream