Add sub menu to main menu

Hi,
is it possible to add a sub menu to a main menu item? If yes, how?

Hi @sowinski. Could you elaborate a little bit more? All menu types will render sub menus for pages selected as menu items, but only if the child pages are published and have show_in_menus set to True.

I beleive there are some alternative menu apps out there now that are based on Streamfield, and allow multiple levels of menu items to be defined. You might like to shop around, if that's the kind of functionality you need.
Unfortunately, Streamfield wasn't really an option when I implemented this, and there's no good way to support multiple levels in the UI using InlinePanel - it just gets incredibly messy.

@ababic

I beleive there are some alternative menu apps
Which one? I found only your project

I just want to add to my main menu a sub menu
For Example:
Home
Pricing
Contact
Language: English, French, Etc. (Submenu)
How can I add child elements?

@sowinski sorry, I'm not clear on what you're trying to achieve here. It doesn't sound like the language options should be something that is controlled in the UI... have you tried just overriding the main menu template and hardcoding the extra menu items?

@ababic
This was just an example. I just want to have a second level for a specific element.
Like you can see on the picture.

@sowinski If the top-level item you want to add a sub-menu to is a custom link, then there's not much that wagtailmenus can do for you I'm afraid. If the top-level item is a page, then you may have some luck with this: https://wagtailmenus.readthedocs.io/en/stable/abstractlinkpage.html

Hmm, really?
Maybe my English is not good enough to explain what I mean.
Even on the main page on Github there is an image with a submenu.
https://raw.githubusercontent.com/rkhleics/wagtailmenus/master/docs/source/_static/images/repeating-item.png
What is shown on the image is exactly what I want and I think this is also for most of the websites out there a default case.
Thank you :)

@sowinski wagtailmenus uses your existing page tree to power sub menus. So, if you select a page as a menu item and tick the "Allow sub-menu for this item" checkbox, if that pages has children that are live and have a show_in_menus value of True, those pages should appear as menu items in a sub menu below that item (you can control how many levels are rendered using various rendering options).
There's a bit more about this in the docs on the following page:
https://wagtailmenus.readthedocs.io/en/stable/overview.html#multi-level-menus-generated-from-your-existing-page-tree
You might also find the template tag documentation helpful:
https://wagtailmenus.readthedocs.io/en/stable/rendering_menus/template_tag_reference.html#the-main-menu-tag

@ababic
Thank you for helping me.
I solved my problem by creating fake "page objects". I will share my code after I solved my last problem.
The last thing I need is to be able to attach to my sub_menu also "icons", "descriptions" etc.
For the main_menu I just created an AbstractMainMenuItem with additional fields. But what can I do for my sub_menu?

I solved my problem by just sub classing MenuPage (And added some custom fields  )and added it to all models. Bit complicated because I had a lot of PageModels already but it seems to work :)

I was trying to use a "DummyPage" element but I got the following error.
MyCode
class MenuDummyPage(MenuPage):

    menu_header         = models.CharField(max_length=255, blank=True)
    menu_description    = models.CharField(max_length=255, blank=True)
    menu_icon           = models.CharField(max_length=255, blank=True)

    settings_panels = [
        FieldPanel('menu_header'),
        FieldPanel('menu_description'),
        FieldPanel('menu_icon'),
        menupage_panel
    ]

If I create a page and add it to the main_menu I got this error:
TypeError at /
issubclass() arg 1 must be a class
Request Method:	GET
Request URL:	http://<IP_ADDRESS>:8000/
Django Version:	2.0.9
Exception Type:	TypeError
Exception Value:
issubclass() arg 1 must be a class
Exception Location:	/home/myproject/git/myvenv/lib/python3.5/site-packages/wagtailmenus/models/menus.py in _prime_menu_item, line 562
Python Executable:	/home/myproject/git/myvenv/bin/python3
Python Version:	3.5.3
Python Path:
['/home/myproject/git/test/source/myproject',
 '/usr/lib/python35.zip',
 '/usr/lib/python3.5',
 '/usr/lib/python3.5/plat-x86_64-linux-gnu',
 '/usr/lib/python3.5/lib-dynload',
 '/home/myproject/git/myvenv/lib/python3.5/site-packages']
Server time:	Di, 9 Jul 2019 15:43:27 +0200
Error during template rendering
In template /home/myproject/git/myvenv/lib/python3.5/site-packages/wagtailmenus/templates/menus/bootstrap3/main_menu_dropdown.html, error at line 7

issubclass() arg 1 must be a class
1	{% load menu_tags %}
2

3	{% for item in menu_items %}
4

5	        {{ item.text }}{% if item.has_children_in_menu %} {% endif %}
6	        {% if item.has_children_in_menu %}
7	        	{% sub_menu item template="menus/bootstrap3/sub_menu_dropdown.html" %}
8	        {% endif %}
9

10	{% endfor %}
11

12

Sorry @sowinski. I'm afraid I haven't seen that error before.
Sub menu items are just page objects with some additional attributes added. If you want fields from those pages to be available in sub menu templates, look at using the use_specific option... You don't have to subclass MenuPage for all your page types.

@ababic
Do you have a working example somewhere?

@sowinski You can set the default use_specific value on the menu itself via the CMS (Look under the Settings tab). You'll want to set 'Specific page usage' to  'Always', like so:

Then you then can just access custom page fields in your sub menu template like so:
{% for item in menu_items %}

            {{ item.icon }}
            {{ item.text }}
            {{ item.description }}

        {% if item.has_children_in_menu %}
            {% sub_menu item template=current_template %}
        {% endif %}

{% endfor %}

@ababic
Awesome! Thank you! :)
Last question:
Where should I store my custom fields?
Currently I replaced MenuPage with Page from my MenuDummyPage object.
class MenuDummyPage(Page):

    menu_header         = models.CharField(max_length=255, blank=True)
    menu_description    = models.CharField(max_length=255, blank=True)
    menu_icon           = models.CharField(max_length=255, blank=True)

    settings_panels = [
        FieldPanel('menu_header'),
        FieldPanel('menu_description'),
        FieldPanel('menu_icon'),
    ]

I could also add this MenuDummyPage to all my other pages, so that all will have the same feature.
Is this the correct way now? :)

@sowinski If you have fields that you want all page types to have in your project, the best approach is to define an abstract BasePage model, and subclass that for all your other page types. For example:
class BasePage(Page):
    menu_header = models.CharField(max_length=255, blank=True)
    menu_description = models.CharField(max_length=255, blank=True)
    menu_icon =  models.CharField(max_length=255, blank=True)

    # including the original panels here too, but that's up to you
    settings_panels = Page.settings_panels + [
        FieldPanel('menu_header'),
        FieldPanel('menu_description'),
        FieldPanel('menu_icon'),
    ]

    class Meta:
        abstract = True  # this is important

class GeneralPage(BasePage):
    pass

class SomeOtherPage(BasePage):
    pass

@ababic
Thank you :) That's working perfect now!

Hello, is there a fully working example with sub menus?

@alfredo-ardito There are some new examples in the docs to help explain how multi-level menus work:
https://wagtailmenus.readthedocs.io/en/latest/overview.html#multi-level-menu-examples
If you want to see actual working code, you can clone the project and follow these steps to run the test project on your local machine, or you can just explore the test app code online, if that's more your thing.

does Bootstrap5 is supported for wagtail-nav-menus?????

@Durgavasu58
Unfortunately this project is dead. No one is currently maintaining this package any more.
You should consider to avoid this package, because currently it is not supporting the newer wagtail versions..
(Hopefully this changes soon)

does Bootstrap5 is supported for wagtailmenus?????
You can use this package with any css framework you want. What stops you using bootstrap 5?

i need a mutlievel dropdown for my project


Disable command button if device is not online

Here is some small fool-tolerance fix that disables the command button on the devices panel if a device is not online (or become not online)

It doesn't seem like a right approach. You can register listener inside DevicesController class. You don't need to modify the store.

I know that it is not very good to do it in store but I could not find any events in Ext.grid.Panel or Ext.grid.column.Column that fired on store update.

Check this example:
https://github.com/tananaev/traccar/blob/master/web/app/view/StateController.js#L32

Shame on me, miss right solution.

I thought fire event would be in the spirit of asynchronous nature of javascript.

One last small thing. Please use this.getView() instead of this.view.

Hope next time my pull requests need less correction.

Merged, thanks.


width in mat-form-field-theme mixin makes it problematic to have multiple themes

Bug, feature request, or proposal:
Using classes to change from a default theme changes the specificity of form field widths.
What is the expected behavior?
Changing theme should not change form field widths.
What is the current behavior?
Using a theme class changes the specificity of the default form field width.
What are the steps to reproduce?
http://plnkr.co/edit/WcreafWOoGGgLxNuSZh0?p=preview
What is the use-case or motivation for changing an existing behavior?
Changing theme shouldn't cause the width of form fields to change.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
beta 10
Is there anything else we should know?
It seems like the width in mat-form-field-theme() should be in a mixin called by mat-core instead?

Closing as this will be covered #7083


Add --fix to ruff check

Describe the bug
Since the very useful #175, we can now check and format with Ruff
To Reproduce

Mess up some Python files in a way that ruff check isn't happy about, e.g. unused import
run nix fmt

Expected behavior
Anything that can be fixed should be fixed.
Actual behavior
There are errors printed, but no action taken, e.g.
    ...
    tests/test_auth.py:6:27: F401 [*] `unittest.mock.create_autospec` imported but unused
    tests/test_auth.py:7:32: F401 [*] `starlette.requests.Request` imported but unused
    Found 15 errors.
    [*] 15 fixable with the `--fix` option.

/cc @pvsr


Commit convensions

I think it's better to have commit conversions since it's an open-source project it might be easier for new developers to see common commit conversions for example:
feat, chore, update, add, etc.
Also, separate your commits to subjects, and don't commit all your changes in one commit.

I think they did it because it was implement outside of GitHub, and then pushed here.
And I agree about the commit message styles (https://www.conventionalcommits.org/en/v1.0.0/)

Even if they internally had conventions, now when it's open-source I can already see some merged PRs without any conversion, check out "- Done." commit.
Maybe it would be better to specify the conversions on README.md or CONTRIBUTION.md

Any news with this one? I can add readme if you want @MiriShalev
Commits are still messy.


optimize.UglifyJsPlugin is not being executed

I have the following setup:

    new AutoDllPlugin({
      context: path.join(__dirname, '..'),
      filename: '[name].js',
      entry: {
        vendor: [
          'react',
          'react-dom',
          'react-redux',
          'redux',
          'rudy-history/createBrowserHistory',
          'transition-group',
          'redux-first-router',
          'redux-first-router-link',
          'fetch-everywhere',
          'babel-polyfill',
          'redux-devtools-extension/logOnlyInProduction'
        ]
      },
      plugins: [
        new webpack.optimize.UglifyJsPlugin(uglifyOpts),
      ]
    })

but the UglifyJsPlugin is not ran and the vendor.js is not minified.
Any ideas?

Hi @rcalabro,
I released a new version.  It should work now.

Thanks! It is working!


Copy file contents

Is there a way to copy the full contents of a file?

Command-A

Use Runestone editor added in 1.8.0.


Can't install tensorflow v1.15.0 from requirements.txt

Collecting tensorflow~=1.15.0 (from rasa==1.5.0a1)
  Could not find a version that satisfies the requirement tensorflow~=1.15.0 (from rasa==1.5.0a1) (from versions: 0.12.1, 1.0.0, 1.0.1, 1.1.0rc0, 1.1.0rc1, 1.1.0rc2, 1.1.0, 1.2.0rc0, 1.2.0rc1, 1.2.0rc2, 1.2.0, 1.2.1, 1.3.0rc0, 1.3.0rc1, 1.3.0rc2, 1.3.0, 1.4.0rc0, 1.4.0rc1, 1.4.0, 1.4.1, 1.5.0rc0, 1.5.0rc1, 1.5.0, 1.5.1, 1.6.0rc0, 1.6.0rc1, 1.6.0, 1.7.0rc0, 1.7.0rc1, 1.7.0, 1.7.1, 1.8.0rc0, 1.8.0rc1, 1.8.0, 1.9.0rc0, 1.9.0rc1, 1.9.0rc2, 1.9.0, 1.10.0rc0, 1.10.0rc1, 1.10.0, 1.10.1, 1.11.0rc0, 1.11.0rc1, 1.11.0rc2, 1.11.0, 1.12.0rc0, 1.12.0rc1, 1.12.0rc2, 1.12.0, 1.12.2, 1.12.3, 1.13.0rc0, 1.13.0rc1, 1.13.0rc2, 1.13.1, 1.13.2, 1.14.0rc0, 1.14.0rc1, 1.14.0, 2.0.0a0, 2.0.0b0, 2.0.0b1)

Which is your pip version?
TensorFlow from > 1.15 changed to "manylinux2010" tag and does requires pip > 19.0
https://www.python.org/dev/peps/pep-0571/

I have the same error using python 3.7.3 and upgrading the pip to pip==19.3.1, How I could fix this issue.
ERROR: Could not find a version that satisfies the requirement tensorflow~=1.15.0 (from rasa) (from versions: none)
ERROR: No matching distribution found for tensorflow~=1.15.0 (from rasa)

pip 9.0.1 from /usr/lib/python3/dist-packages (python 3.7)
Python 3.7.5
Error:
Collecting tensorflow~=1.15.0 (from rasa)
Could not find a version that satisfies the requirement tensorflow~=1.15.0 (from rasa) (from versions: 1.13.0rc1, 1.13.0rc2, 1.13.1, 1.13.2, 1.14.0rc0, 1.14.0rc1, 1.14.0, 2.0.0a0, 2.0.0b0, 2.0.0b1)
No matching distribution found for tensorflow~=1.15.0 (from rasa)

Got this working!
sudo curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
python3 get-pip.py

Installing collected packages: pip
Found existing installation: pip 9.0.1
Uninstalling pip-9.0.1:
Successfully uninstalled pip-9.0.1
Successfully installed pip-19.3.1

Thank you for you reply @amarflybot18 I have installed pip-19.3.1 but I still have the same Error.

Whats your version of python?

You can upgrade PIP by removing the system python-package and then running:
sudo python3 -m pip install --upgrade pip
You can install it locally with "--user" but the system wide installation for PIP is the recommended AFAIK.
@AmalM7 can you run: pip --version just to be sure about it?

I have pip and pip3 both, But here I have used pip3.

Me too @amarflybot18. It have to be pip3 cause rasa requires Python 3.6/3.7. That may be your problem @AmalM7 .

after running pip --version :  pip 19.3.1 from c:\users\asus\my-venv\lib\site-packages\pip (python 3.7)

Thanks for the question, our Github issue board is for bugs and feature requests only, though 😕
Please ask this question in the forum✨
If you were describing a bug, please create a report and fill out the template.

Thanks @amarflybot18. The issue was in pip 9.0.1. It works.

Downgrade Python version to <= 3.6.7.

@AmalM7 did you manage to solve it? I have the same problem. I'm running pip 19.3.1 with python 3.7 and still have that issue.

@testforpepper did you upgrade your pip?

@mrjazz yes, it's pip 19.3.1

Got this working!
sudo curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
python3 get-pip.py

Installing collected packages: pip
Found existing installation: pip 9.0.1
Uninstalling pip-9.0.1:
Successfully uninstalled pip-9.0.1
Successfully installed pip-19.3.1
Then:
pip3 install rasa

Can you please tell me for windows10?

@testforpepper I am using windows 10, even with upgrading pip it doesn't work. However, it works fine with Ubuntu.

@AmalM7 Thank you very much for your repIy! tried it on Raspbian and it still doesn't work

@testforpepper I am using windows 10, even with upgrading pip it doesn't work. However, it works fine with Ubuntu.

Its work fine by creating a virtual environment of python 3.6.10 by command conda create -n myenv python=3.6  then  conda activate myenv

@UmerMIB  Its work fine by creating a virtual environment of python 3.6.10 by command conda create -n myenv python=3.6 then  conda activate myenv
Should I use the virtual environment for the whole rasa installation or just upgrading pip?

@UmerMIB  Its work fine by creating a virtual environment of python 3.6.10 by command conda create -n myenv python=3.6 then  conda activate myenv

Thank you! Should I use the virtual environment for the whole rasa installation or just upgrading pip?

I am new to RASA I can't guide well , well this creating environment is effective for me this time

Dear's
I tried all the above solutions but still i am getting the below error.
ERROR: Could not find a version that satisfies the requirement tensorflow-cpu~=1.15.0 (from rasa<=1.7,>=1.6.1->rasa-x) (from versions: none)
ERROR: No matching distribution found for tensorflow-cpu~=1.15.0 (from rasa<=1.7,>=1.6.1->rasa-x)
I have pip version 20.0.2
I tried installing rasa with both tensorflow 1.12.0 and tensorflow 2.1.0
I installed below from Tensor flow website for mac os and for python 3.6
https://storage.googleapis.com/tensorflow/mac/cpu/tensorflow-2.1.0-cp36-cp36m-macosx_10_9_x86_64.whl
please help me to resolve this issue.

Still have the same error, with pip 20.0.2 and have tried Python 3.7 & 3.6.

okay, guys here is the simple solution that I found out with it.
In Windows, your TensorFlow version would be installed on the python that you have available for all users (ie. which is in system variable PATH not in user variable PATH in environment variable section). So make a new environment with something like virtualenv venv which will use your system variable PATH python, and then try installing TensorFlow.
In Linux, it's pretty much the same.

Old tensorflow wheels can be downloaded from https://pypi.org/project/tensorflow/1.15.2/#files and installed directly with pip, pip install <downloaded file>.


Re-running Power BI Workspace module results in "Conflict"

Bicep version
Bicep CLI version 0.4.1272 (a69022dd2c)
Describe the bug
When I create a Power BI Workspace with the attached Bicep script, I can't rerun the script because it errors out with "Conflict" and no other error information
To Reproduce
Just run the script twice in a resource group
Additional context

@description('The Azure region into which the resources should be deployed.')
param location string

@description('The name of the Power BI Workspace')
param workspaceName string = 'power-bi-workspace-${uniqueString(resourceGroup().id)}'

resource powerBiWorkspace 'Microsoft.PowerBI/workspaceCollections@2016-01-29' = {
  name: workspaceName
  location: location
  sku: {
    name: 'S1'
    tier: 'Standard'
  }
}

output workspaceName string = powerBiWorkspace.name

Apparently, this API has been deprecated:
https://azure.microsoft.com/en-us/updates/pbiwsc-retirement/
Going to close this for now, but feel free to continue the discussion.


FIX: Missing metadata in some cases & handle metadata if using package slug in dependencies

Fixes:

Missing metadata in some cases. Previously, we did generate metadata for declared pkgs only. Now, all pkgs including their dependencies have their metadata generated.
In the following declaration: nearby#L180, the slug (instead of the package name) was used in the package: option.

.product(name: "AbseilCXX17", package: "abseil-cpp-SwiftPM")

In this case, we simply generate 2 different metadata files. One corresponds to the package name (ie. AbseilCXX17), the other corresponds to the package slug (ie. abseil-cpp-SwiftPM)

/integration-test


Rancher-compose file not updated with new answers on catalog upgrade

Rancher Versions:
Server: 1.5.3
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Use this repository as a custom catalog. It basically has a template for an nginx service that relies on the port_rules for load balancers in the rancher-compose.yml file.
rancher-compose.yml from template
.catalog:
   name: "Catalog Test"
   version: "0.1.0"
   description: "Testing catalog thingy"
   questions:
     - variable: "host_alias"
       description: |
         The instance's alias or host name. This is how the container will be accessed as a URL
       label: "Host Alias"
       type: "string"
       required: true
     - variable: "host_root"
       description: |
         The root domain of the host
       label: "Host Domain"
       type: "string"
       required: true

webby:
  scale: 1
  lb_config:
    port_rules:
      - target_port: 80
        hostname: ${host_alias}.${host_root}

Specifically, when launching the stack you can specify (through questions/answers) what hostname you would like to bind to on the load balancer.
If you update the stack and change your answer, the load balancer rules are not changed.
Example below:
Launch a stack from the catalog with alias alias_here and domain domain.here.com

After launching, viewing the config of the stack shows that the host alias and domain were replaced in both the docker compose and rancher compose files properly:

Now, update the stack and change the answer for host_alias to new_host_alias. Expected behavior would have it substitute the new answer for that question in both the rancher-compose and docker-compose files, but the substitution only occurs in the docker-compose file:

Duplicate (https://github.com/rancher/rancher/issues/8175), please comment if you think this does not match your issue.


fix: add a basic Lua mod creation tutorial

Add a basic tutorial how to create a Lua mod in UE4SS.
The included example should be basic and generic enough to run on a number of supported games.

This looks good, thank you!


Make filesystem skiplist a constant, skip iso9660 and udf

being dealt with in https://github.com/synthesist/panoptimon/pull/88


CPU utilization for down to 50~% when training FFN. Was 100% last week.

After I pulled yesterday the CPU utilization during training is way down from what it was last week. I do not have any benches on actual training time, though.
I'm using MKL on Windows 10 with:

MKL_DYNAMIC=FALSE
MKL_NUM_THREADS=8 (same as my logical count)

Here's some screenshots to show what's going on:

Hotspots: https://files.gitter.im/deeplearning4j/deeplearning4j/earlyadopters/B40C/blob
Heap: https://files.gitter.im/deeplearning4j/deeplearning4j/earlyadopters/8jdD/blob
CPU: https://files.gitter.im/deeplearning4j/deeplearning4j/earlyadopters/S7NL/blob

Curious if you could also run the same with openblas?

Could you also please add a screenshot of the backtraces for your hotspots (i.e. what calls all the array allocation?)

That looks like you using add() rather than addi. That isn't us. Try using the inplace version first.
It'd be one thing if that was our code but that's all you.

Alright, so using inplace lead to faster training, but the CPU utilization remains the same. I will try and do a better benchmark later.

Alright; cached the doc vec calculations causing this. It's fast again now. Closing.


Enforce Python 3.6.x version during setup

Changes

Only allow ADS installation for Python versions 3.6.x
Revert Path() syntax in setup.y, which errors for versions before <=3.5 without a descriptive message (related to Python version).

If someone tried to install ADS with an incompatible Python version, they will now get something like following message.

AxonDeepSeg requires Python '>=3.6, <3.7' but the running Python is 3.5.2

I looked into if I could customise this message or append one, but after a lot of searching it appears it's not possible (for unsuccessful installs).

Coverage remained the same at 82.738% when pulling 2dd3077f21f444650e042e33a57a003099ef416e on pypi_pyver into c52516ee5559e07c336524583aa3955f712e936b on master.

The changes you made in changelog aren't reflecting in RTD. There are two files of changelog that is  docs/source/documentation.rst and CHANGELOG.md. I think CHANGELOG.md is the main file which reflects changes made and appropriate changes must be made there also. But still I don't understand why there are 2 files of changelog instead of one.

But still I don't understand why there are 2 files of changelog instead of one.

This was discussed at the last meeting, it's been like this for a while. Up until now, any changes always had to be added in both CHANGELOGS (I've corrected that for your PRs a few times).
I am going to look into how to remove the hardcoded changelog in the ReadTheDocs files and simply import the CHANGELOG.md file.

The changes you made in changelog aren't reflecting in RTD.

That is because the RTD link you linked here points to "latest" which is the version in the master branch. Only after this branch is merged will the changes be reflected there.

Shouldn't we change date as well in the latest version of ADS (that is 2.2dev) ?

This PR isn't releasing a new version of ADS yet (which would warrant upgrading to 2.3). Per discussed at the last meeting, this will be done once your data augmentation branch is merged (since it will be a more "complete" keras upgrade than the current "partial" one).
The date on the changelogs will be updated accordingly once that release is done.

To test this PR, what should be done is try installing (pip install -e .) in three different virtual environments: one with python <3.6, one with >=3.7, and one with a 3.6.x (x can be any number between 0 and 8).
You can create a conda env with a specific python version using the following command:
conda create -n ads python=3.6.8
Only the 3.6.x one should install correctly; the other two should give you the warning that I described in the description of this PR

To test this PR, what should be done is try installing (pip install -e .) in three different virtual environments: one with python <3.6, one with >=3.7, and one with a 3.6.x (x can be any number between 0 and 8).
You can create a conda env with a specific python version using the following command:
conda create -n ads python=3.6.8
Only the 3.6.x one should install correctly; the other two should give you the warning that I described in the description of this PR

I followed the instructions and for python version < 3.6 it's working fine but not for python version >= 3.7. I am on  Python 3.7.3 ( Conda virtual environment) and it throws no warning. Can you recheck on python >=3.7


Remove autoware auto tf2

Description
Remove unused autoware_auto_tf2 package from Autoware.Universe
This should be merged after https://github.com/autowarefoundation/autoware.universe/pull/7217.
Related links
https://github.com/autowarefoundation/autoware.universe/pull/7217
The package was originally made when the tf2 package in ROS 2 wasn't still mature enough, but many of the functions were migrated to the upstream and no packages depend on Autoware's tf2 package anymore. (example)
Tests performed
I have done the build test on my local machine
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I have made this a draft PR since it depends on https://github.com/autowarefoundation/autoware.universe/pull/7217 and we don't want to merge this by mistake, but the PR is ready for review.


Web Interface

Placeholder commit for the web interface issue #24

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   57.14%   57.14%
=======================================
  Files           1        1
  Lines          56       56
=======================================
  Hits           32       32
  Misses         21       21
  Partials        3        3

Impacted Files
Coverage Δ

plex/myplex.go
57.14% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe8b18...805c1de. Read the comment docs.

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   57.14%   57.14%
=======================================
  Files           1        1
  Lines          56       56
=======================================
  Hits           32       32
  Misses         21       21
  Partials        3        3

Impacted Files
Coverage Δ

plex/myplex.go
57.14% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe8b18...805c1de. Read the comment docs.

Fixes #24


Add option to save the model during build job

This change is

machine/jobs/build_nmt_engine.py line 91 at r1 (raw file):

    parser.add_argument("--clearml", default=False, action="store_true", help="Initializes a ClearML task")
    parser.add_argument("--build-options", default=None, type=str, help="Build configurations")
    parser.add_argument("--save-model", default=False, action="store_true", help="Save the model")

So we would be able to invoke it through a command line option or by putting {save-model: true} in the build-options?

machine/jobs/shared_file_service.py line 81 at r1 (raw file):

    def save_model(self, model_path: Path) -> None:
        if model_path.is_file():
            self._upload_file(f"models/{self._build_id}" + "".join(model_path.suffixes), model_path)

Wasn't the naming going to be {engineId}_{buildRevision}?  Otherwise, the machine side would be much more complicated.  I can send down the buildRevision as a passed argument.

.vscode/settings.json line 12 at r2 (raw file):

    "editor.formatOnSave": true
  },
  "black-formatter.path": ["poetry", "run", "black"]

the back formatter is already called out - is this to make it call poetry's version instead of whatever is running in the command line?

machine/jobs/build_nmt_engine.py line 91 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
You can pass it as an arg in the job script. Putting it in the build options won't work. I am assuming that the parameter to save a model would be specified in the build config.

Good enough for me.

machine/jobs/shared_file_service.py line 81 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Yes, but I thought about it a bit more. The model download would be associated with the build from the Serval perspective. So Serval will request a download url from the engine using the build id. If the file is labelled with the build id, Machine should be able to easily for the download url.

A few things:

What if the most recent build failed or wasn't saved?  Then Serval would have to implement logic as to which build was valid and saved and is now requestd
As for removing old models, since only the most recent one could be requested, I am wanting to delete old models from previous builds.  Using the engineId_buildNumber scheme would make that straightforward.

machine/jobs/shared_file_service.py line 81 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…

When a download url is requested for a build's model, Serval would be able to check if the build was successful and a model was saved. If the model isn't available for that build, Serval would return a 4xx status code, otherwise it would request the download url from the engine.
I thought that we could just remove the old models based on the date created/modified. We probably don't want to delete a model as soon as another model is trained for the same engine. A user might be in the middle of downloading the model.

For Killing old models, I was thinking of marking it twice and then killing it after a day if it is not needed, to address issues like that.
IDX was concerned about deleting models after 30 days - that they may want to use them for longer term things.

It isn't working because of the OutOfMemory and torch 2.1.2 issue.  I'll ignore coverage for the time being.

machine/jobs/shared_file_service.py line 79 at r3 (raw file):

        return self._download_folder(f"parent_models/{language_tag}", cache=True)

    def save_model(self, model_path: Path, name: str) -> None:

What about the suffixes?

machine/jobs/shared_file_service.py line 79 at r3 (raw file):
Previously, johnml1135 (John Lambert) wrote…
What about the suffixes?

Ah - I see it now.

.vscode/settings.json line 12 at r2 (raw file):
Previously, johnml1135 (John Lambert) wrote…
the back formatter is already called out - is this to make it call poetry's version instead of whatever is running in the command line?

Not worth holding up.  It should be fine.

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4267780) 87.65% compared to head (fd774d6) 86.69%.

Files
Patch %
Lines

machine/jobs/shared_file_service.py
25.00%
3 Missing :warning:

machine/jobs/nmt_engine_build_job.py
33.33%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   87.65%   86.69%   -0.96%
==========================================
  Files         226      222       -4
  Lines       13515    13011     -504
==========================================
- Hits        11846    11280     -566
- Misses       1669     1731      +62

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

There's code cov!


Add slash icon/improve [*-]slash metadata

Or, maybe it should match the slash/divide of https://lucide.dev/icon/equal-not …?

@danielbayley Can you rebase the PR?


Rename Crate

yew-router is taken, invalidating yew_router.
Alternatives:

yewstack-router
yew-routing

Closing in favor of https://github.com/yewstack/yew_router/issues/78


Armijo Rule and Backtracking Line Search Accomodation

In ./utils/first_order , every class has a _reset() method. Change method call from self._reset to self._reset() for more stable experience on lower python version.


year check in LICENSE.txt

Let's create a check in pom.xml (somehow), that will fail the build if LICENSE.txt doesn't have 2014-2016 text.

@yegor256 I tagged this as "bug"

@yegor256 attached this issue to milestone "1.0" (let me know if this is wrong)

@yegor256 thanks for tis bug, I topped your account for 15 mins, transaction 000-333acd31

@raphaelln can you please help? Keep in mind this. If you have any technical questions, don't hesitate to ask right here... The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

@davvd the issue was closed, could you proceed please.
thanks.

@rultor rultor closed it (automatically), @yegor256 please take a look

@rultor rultor closed it (automatically), @yegor256 please take a look

@davvd I'm sorry, I don't understand you :( Check this page and try again please

@davvd the issue was closed, could you proceed please.
thanks.

@raphaelln no problem :)

@raphaelln please post a link to the pull request, where it was fixed

@raphaelln thanks

@ypshenychka please, check this issue for QA compliance, as per par.24

@davvd Quality is good.

@davvd Quality is good.

@ypshenychka thanks a lot :)

@davvd everything is ok here could you please proceed.

@davvd everything is ok here could you please proceed.

@raphaelln OK

@raphaelln I added 10 mins to @ypshenychka (for QA review) in transaction 81197360; thanks, I just added 30 mins to your account, payment AP-22D74699JV219591B, 254 hours and 34 mins spent; +30 to your rating, your total score is +90


fix: add  to fix ssr problem

#7 this should fix the problem I guess

Sorry, I tested this pull request and it did not fix the bug.


[Bug] build_runner won't detect anything

Describe the bug
My generated .dart file has
part 'dart_bridge_generated.freezed.dart';
and even though flutter_rust_bridge automatically runs build_runner, it detects nothing. build_runner is on my dependencies. Also, I tried manually:
flutter pub run build_runner build
[INFO] Generating build script...
[INFO] Generating build script completed, took 398ms

[WARNING] Invalidated precompiled build script due to core package update
[INFO] Precompiling build script......
[INFO] Precompiling build script... completed, took 8.6s

[SEVERE] Nothing can be built, yet a build was requested.
[INFO] Initializing inputs
[INFO] Reading cached asset graph...
[INFO] Reading cached asset graph completed, took 99ms

[INFO] Checking for updates since last build...
[INFO] Checking for updates since last build completed, took 673ms

[INFO] Running build...
[INFO] Running build completed, took 6ms

[INFO] Caching finalized dependency graph...
[INFO] Caching finalized dependency graph completed, took 48ms

[INFO] Succeeded after 72ms with 0 outputs (0 actions)

Codegen logs with RUST_LOG=debug environment variable
[2022-06-30T21:00:26Z INFO  lib_flutter_rust_bridge_codegen::commands] Running build_runner at /home/dev/project/liblibsomething/../flutter_libsomething_app
[2022-06-30T21:00:26Z DEBUG lib_flutter_rust_bridge_codegen::commands] execute command: bin=sh args=["-c", "cd \"/home/dev/project/liblibsomething/../flutter_libsomething_app\" && dart run build_runner build --delete-conflicting-outputs"] current_dir=None cmd="sh" "-c" "cd \"/home/dev/project/liblibsomething/../flutter_libsomething_app\" && dart run build_runner build --delete-conflicting-outputs"
[2022-06-30T21:00:54Z DEBUG lib_flutter_rust_bridge_codegen::commands] command="sh" "-c" "cd \"/home/dev/project/liblibsomething/../flutter_libsomething_app\" && dart run build_runner build --delete-conflicting-outputs" stdout=[INFO] Generating build script...
    [INFO] Generating build script completed, took 341ms

    [WARNING] Invalidated precompiled build script due to core package update
    [INFO] Precompiling build script......
    [INFO] Precompiling build script... completed, took 7.5s

    [SEVERE] Nothing can be built, yet a build was requested.
    [INFO] Initializing inputs
    [INFO] Reading cached asset graph...
    [INFO] Reading cached asset graph completed, took 61ms

    [INFO] Checking for updates since last build...
    [INFO] Checking for updates since last build completed, took 689ms

    [INFO] Running build...
    [INFO] Running build completed, took 2ms

    [INFO] Caching finalized dependency graph...
    [INFO] Caching finalized dependency graph completed, took 34ms

    [INFO] Succeeded after 49ms with 0 outputs (0 actions)

     stderr=
[2022-06-30T21:00:54Z DEBUG lib_flutter_rust_bridge_codegen::commands] execute format_dart path=/home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.freezed.dart line_length=80
[2022-06-30T21:00:54Z DEBUG lib_flutter_rust_bridge_codegen::commands] execute command: bin=sh args=["-c", "dart format /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.freezed.dart --line-length 80"] current_dir=None cmd="sh" "-c" "dart format /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.freezed.dart --line-length 80"
[2022-06-30T21:00:54Z DEBUG lib_flutter_rust_bridge_codegen::commands] command="sh" "-c" "dart format /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.freezed.dart --line-length 80" stdout=Formatted no files in 0.01 seconds.
     stderr=No file or directory found at "/home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.freezed.dart".

[2022-06-30T21:00:54Z DEBUG lib_flutter_rust_bridge_codegen::commands] execute format_dart path=/home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.dart line_length=80
[2022-06-30T21:00:54Z DEBUG lib_flutter_rust_bridge_codegen::commands] execute command: bin=sh args=["-c", "dart format /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.dart --line-length 80"] current_dir=None cmd="sh" "-c" "dart format /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.dart --line-length 80"
[2022-06-30T21:00:55Z DEBUG lib_flutter_rust_bridge_codegen::commands] command="sh" "-c" "dart format /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.dart --line-length 80" stdout=Formatted /home/dev/project/liblibsomething/../flutter_libsomething_app/lib/dart_bridge_generated.dart
    Formatted 1 file (1 changed) in 0.35 seconds.
     stderr=
[2022-06-30T21:00:55Z INFO  lib_flutter_rust_bridge_codegen] Success!
[2022-06-30T21:00:55Z INFO  flutter_rust_bridge_codegen] Now go and use it :)

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
No response
Version of flutter_rust_bridge_codegen
No response
Flutter info
No response
Version of clang++
No response
Version of ffigen
No response
Additional context
No response

Solution:
flutter pub add --dev freezed
but also make sure of the following:
flutter pub add freezed_annotation
flutter pub add --dev build_runner

Solution

Yes you need to do that.
Feel free to PR :) For example, when flutter_rust_bridge_codegen runs and wants to output a freezed dart class, it should check pubspec.yaml, and ensure there are freezed, freezed_annotation, build_runner there.


Azure Data Lake Analytics

It may be worth mentioning on this page that this service is about to be retired. It's thus not suitable as a technology choice for any new solutions.
https://azure.microsoft.com/en-us/updates/migrate-to-azure-synapse-analytics/

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 60cbefa1-b1c1-0edc-cdf7-4cae8a8ca2f5
Version Independent ID: c6850420-2cc7-d17a-6adb-b4e69399efd7
Content: Data lakes - Azure Architecture Center
Content Source: docs/data-guide/scenarios/data-lake.md
Service: architecture-center
Sub-service: azure-guide
GitHub Login: @PRASADA1207
Microsoft Alias: prasada

@VitalyMCT
Thanks for your feedback! We will investigate and update as appropriate.

Thank you for your feedback.  We have created internal ticket 87891 to track and investigate this issue.

#please-close


[8.x] Add excludes method to collection

This PR has been recreated from #32961
I think the contains method is one of the most used feature of the Collection class. And in quite a handful of scenarios, I find the need of an inverse.
For example, a real example that I used to work with:
if (! $email->tags->contains('name', 'ATTACHMENTS_DOWNLOADED')) {
    $email->attachments->each->download();
    $email->tag('ATTACHMENTS_DOWNLOADED');
}

That could be changed to:
if ($email->tags->excludes('name', 'ATTACHMENTS_DOWNLOADED')) {
    $email->attachments->each->download();
    $email->tag('ATTACHMENTS_DOWNLOADED');
}

A different example could be:
if ($freeShippingPostcodes->excludes($address->postcode)) {
    // Go on to charge normal shipping costs.
}

Ping @JosephSilber

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


AWS::IoTWireless::WirelessDevice do not update DestinationName

Cloudformation do not handle correctly modification of the value DestinationName of a AWS::IoTWireless::WirelessDevice
If we deploy an AWS::IoTWireless::WirelessDevice device using cloudformation and later change the DestinationName value of the sensor, Cloudformation will detect the change but do not change the destination name of the resource in the console.
How to reproduce the problem:

deploy the following template :
aws_iot_device_destination_bug3.txt
It will create the following resources:

an AWS::IoTWireless::WirelessDevice
the AWS::IoTWireless::ServiceProfile requiered to create a WirelessDevice
the AWS::IoTWireless::DeviceProfile to create a WirelessDevice
It will also create an AWS::IoTWireless::Destination that we don't have asked for

update the stack by changing the value of the DestinationName, cloud formation will detect the change, "apply change" but in the console the destination name will stay the same, also the AWS::IoTWireless::Destination resource is not modified

A workaround, is to do the modification manually in the console or with the CLI. Another way is to delete the resource and recreate them back but at the cost of closing the LoraWan connection. Sensor then need to pair again with the network and it can take days (because sensor are transmitting without looking for ACK and do not spot that the encrytion key they are using to communicate was revoked by AWS).


Missing 2.27 screenshots

Where to find the issue
coronawarn.app/en/screenshots
Describe the issue
There is no screenshot information for the current version of the app 2.27, released on Sep 28, 2022 (see https://www.coronawarn.app/en/blog/2022-09-28-cwa-2-27/).
Steps to reproduce
Go to https://www.coronawarn.app/en/screenshots Look for "Version 2.27" in version drop-down list. Note that it is missing.
Suggestion

Either add a message in the 2.25 screenshot description to say that the screenshots also apply to version 2.26 & 2.27 or
add a new screenshot page for 2.27

Credits
I took over the issue description from @MikeMcC399's issue #3094.

Internal Tracking ID: EXPOSUREAPP-14065

@Ein-Tim

There is no screenshot information for the current version of the app 2.26, released on Sep 28, 2022

You mean 2.27.

@MikeMcC399
Thanks, fixed.

@dsarkar You added the "Fix 2.27" label but nothing changed with the release of version 2.27. The screenshots are still missing.

@Ein-Tim We are going to provide screenshots. I added the label, since it is related to 2.27 although delivered late. Idea is that it might be easier to find PR/issue related to a release.

This issue has been fixed with https://github.com/corona-warn-app/cwa-website/pull/3131.


Navigate animation drops frame even when using InteractionManager

Hello,
I my projects usually I use createContainer and inside it I do some linking of collections EX:
export default createContainer((params) => {
	const handle = Meteor.subscribe('subs-name');

	let listing;
	let subscriptionsReady = false;

	if(handle.ready()){
		listing = Meteor.collection('listings').findOne({_id: listingId});
		listing.user = Meteor.collection('users').findOne({_id: listing.userId});
		listing.city = Meteor.collection('cities').findOne({_id: listing.cityId});
		listing.images = Meteor.collection('images').find({objectId: listing._id});
		listing.features = Meteor.collection('features').find({_id: {$in: listing.features}});
		listing.isFavorite = Meteor.collection('favorites').findOne({listingId: listing._id});

		subscriptionsReady = true;
	}

	return {
		listing,
		listingId,
		subscriptionsReady
	};
}, ListingDetail);

Some times subscription is to fast and the code inside handle runs and the animation drop some frames even when using InteractionManager, but thats obvious because InteractionManager will run in my component not inside the container.
I have solved this adding this to the createContainer mixin in react-native-meteor.
componentWillMount() {
  InteractionManager.runAfterInteractions(() => {
    Data.waitDdpReady(()=>{
      if(this.getMeteorData) {
        this.data = {};
        this._meteorDataManager = new MeteorDataManager(this);
        const newData = this._meteorDataManager.calculateData();
        this._meteorDataManager.updateData(newData);
      }
    });
  });
},

I know this can be done in a separate component, but maybe something like this could be a good feature to have.
I would like to hear what you people think about it.

You are right. I was just testing that and I found what you described. I removed it.


Using Windows docker integration test to display the error of win32.kernel

Describe the bug

pulsar: 2.5.2
os: win10 64bit
docker: v20.10.5

The issue had no activity for 30 days, mark with Stale label.

Closing as stale and no activities.
Please open a new issue if it's still relevant to maintained versions.


Intergrate with shiki-magic-move

What problem will this feature address?
https://github.com/shikijs/shiki-magic-move
Describe the solution you'd like
With https://github.com/shikijs/shiki-magic-move built-in, I can use in MDX and React component
\`\`\`\`md magic-move
\`\`\`ts
1
\`\`\`
\`\`\`ts
2
\`\`\`
\`\`\`\`

export const Component = () => {
  return (
    <MagicMove>
      <CodeBlock>
</CodeBlock>
      <CodeBlock>
</CodeBlock>
      <CodeBlock>
</CodeBlock>
    </MagicMove>
  )
}

Describe alternatives you've considered
I create a React component manually do this but seems like it not works great, IDK why the font size looks slightly bigger than fumadoc one's
https://github.com/run-llama/LlamaIndexTS/blob/main/apps/next/src/components/magic-move.tsx
Additional context
No response

I create a React component manually do this but seems like it not works great, IDK why the font size looks slightly bigger than fumadoc one's

Preferably I encourage people to create a React component on their own which gives you more freedom than a tiny wrapper.
You can set the font size with CSS, I think Shiki works great with it.
Would like to hear the problems you have encountered when creating it

First one is theme, I thought fumadoc uses github dark and github light but I create a shiki with them, looks like it's not
Second is font-size, I use default css. left one looks larger
Left: shiki, Right: rumadoc

We use vesper theme, and font size is 13/14px

Thanks, I hope it's documented!

Hmm about integrating Shiki magic moves or the default styles of code blocks? Surely will work on that later

I hope there is a global hook useShiki in client side and getShiki in server side. So I don’t need look up what the correct style

read the source code seems like this is hard to implement. because it's created inside buildMDX stage

I think we will encourage people to create their own component instead for now.
Welcome to bring an example if you have get it working!


update: Soccer apps - add display of PK score if applicable

Description
add display of PK score if applicable
tweak coloring on team color display to be able to see final score in some conditions
Copilot

🤖 Generated by Copilot at ccb7e23
Summary
:soccer::soccer::soccer:

This pull request adds penalty shootout score display and improves team color readability for three soccer apps: soccermens, soccersingle, and soccerwomens. It also updates the version numbers and comments of the app files.

A feature was added to soccermens
To show how the shootouts would end
The colors were tweaked
And comments were speaked
The version was bumped to ascend

Walkthrough

Add comment to indicate code update date and features in soccermens.star, soccer_single.star, and soccerwomens.star (link, link, link)
Update VERSION variable in all three files to reflect code changes (link, link, link)
Add code to display penalty shootout score and color in get_match_info function in all three files (link, link, link)
Modify color attribute of render.Box widgets to make team colors more transparent and less saturated in render_match function in all three files (link, link, link)
Replace #222 color code with #222222 in get_color function in all three files for consistency (link, link, link)

:shipit:

added code to pull tournaments dynamically - this way I have less PRs in the future


RxBinding for ChipGroup checked events

Added RxBinding for ChipGroup checked events.

Hi can someone helps me with this build failure? I am not quite familiar with Travis-CI build


Wrong information

Device : Samsung S21
OS :  One UI 4.0 (Android 12)
When I leave the application and come back after several hours, a lot of information is incorrect, such as the "Airing Schedules" section which does not take into account the filters activated when they are activated. There is also the Seasons section which does not display the correct season anime. And I think there is another section too.
But when I completely quit the application (not just by pressing the home button) and return to the application, everything is back to normal.
I can send you pictures on discord but you're not too active on it anymore

The same thing happens to me.


Eliminate str_to_json() method and unicode casting

What is the problem?
For example, if the song "Before Æons Came" is parsed, the script will crash and print out something along the lines of

UnicodeEncodeError: 'ascii' codec can't encode character u'\xc6' in position 7: ordinal not in range(128)

Why is this happening?
The reason this method was initially created is because much of what is parsed may be in Unicode. If Python 2 encounters non-ASCII characters, which is the case here, it will cause that error and terminate.
What is the current workaround?
This method is only one of the workarounds that is set in place; this method replaces their ASCII representation (I think) with their actual UTF-8 values. The second workaround in place is casting all strings as unicode values when strings are expected. See here for an example.
What should be done?
This workaround should be avoided if at all possible. Manually replacing offending characters and casting to unicode values is a poor implementation of parsing UTF-8 characters.
On top of this, casting to unicode is not in Python 3. However, research has shown that Python 3 handles Unicode characters much nicer, but this cannot be tested in full until gmusicapi fully supports Python 3.

Resolved in ac777ca4e4a06b1692f7a25f5447073cec027195.


Frontend doesnt recognise and rename roms

Hi!
It would be great if the frontend would recognise and rename the Mame, CPS1, CPS2,CPS3 and Neogeo roms as did it in case of Final Burn roms. Currently the frontend shows the file names instead of the game name. In case of Final Burns roms its work great.
https://youtu.be/2Q4XetM3nl0

Daijishou Wiki: Arcade Platforms not scraping


Add a flag to generate constructor arguments

Fixes #850.
I will be adding tests.

turned on by default for non google3 use

How would you implement this? By patching the library internally, or with an env variable, or ...?

How would you implement this? By patching the library internally, or with an env variable, or ...?

Maybe by passing the option to not create the named parameters from the blaze-rule that compiles the protos?

Jumping in to plus one this PR - I did encounter the usability difference in creating proto objects in a project I'm working on (dartpad uses protos to communicate between the frontend and backend).

@sigurdm PTAL.

Still LGTM.
I would still prefer for the constructor arguments to be generated by default. I think that is the most user friendly and what most people should use. Google3 (and others) are free to turn them off if they really think it saves them anything significant.

As a non-google user of this library I agree that having the constructors generated by default is preferable. As I understand, the only reason one would not want to have constructors is to reduce the final binary size. I cannot speak for the whole community, but I believe this optimization is not something many people worry about. The PR which removed constructors mentions the increase in binary size but with no concrete numbers, perhaps the file size increase is indeed significant? I also fear that people will simply not know about the constructor option and new users will just use the cascade operator construction.

Google3 (and others) are free to turn them off if they really think it saves them anything significant.

@sigurdm I don't think this makes sense for internal users. Internal users don't explicitly update their dependencies, so they won't check the changelog and see if they need migration.
It's also not feasible to reach out to every single user, as there are just too many.
So projects with binary size benchmarks will potentially be notified, and then they have to figure out what changed and how to revert the changes. Projects without binary size benchmarks will silently get larger.
Also, no one "needs" this feature (it's not enabling anything new), and no internal user so far requested this feature even though it's been in the open source version for 2+ years (since Nov 2020).
So there seems to be no benefit for the internal users, but their projects may get slightly larger.
That said, I actually investigated a little bit why some projects get larger with these arguments. TFA is quite good at dropping unused arguments, and I've confirmed that VM and dart2wasm projects are not affected if they don't use the arguments. The problem is with dart2js projects, as dart2js doesn't use TFA and it doesn't seem to be dropping the arguments as aggressively.
Something else I've considered is to make this the default in open source, and just modify one line internally:
-      _generateFactory(out);
+      out.println('factory $classname() => create();');

But the problem is tests and golden files need to be different too, it's not as simple as just one line. This problem also exists if I somehow implement different defaults in internal and OS versions.

is it already included in a release ? how to check that ?

This was included in version 21.1.0
https://pub.dev/packages/protoc_plugin/changelog#2110

i am running
libprotoc 26.0-rc1 and it do not generate object with name constructors

What version of protoc_plugin are you using? Try re-installing it:
dart pub global deactivate protoc_plugin
dart pub global activate protoc_plugin

Indeed the global protoc version I used was old.
Something surprising is that all objects get generated with nullable fields.


Failure metadata test update

For benefit glorious PR https://github.com/broadinstitute/cromwell/pull/2055

👍

:+1:

:+1:


Curry bug when a function has a default value in params

I reproduce the error in Ramda REPL:
Link
This function doesn't work
const getUniqueValuesByKeys = R.curry((init = {}, keys, data) =>
  data.reduce((acc, item) => {
    const x = { ...acc };

    for (const i of keys) {
      if (!Array.isArray(x[i])) x[i] = [];

      if (!_.isNil(item[i]) && !_.includes(x[i], item[i])) {
        x[i] = [...x[i], item[i]];
      }
    }
    return x;
  }, init ),
);

But if params are set like this: (init, keys, data) without init default value it works.

Well, first of all, there are problems with non-defaulted parameters after defaulted ones.  They are simply overridden at call time:
const foo = (a, b, c) => ({a, b, c})

foo (6, 7, 8) //=> {a: 6, b: 7, c: 8}
foo (6, 7)    //=> {a: 6, b: 7, c: undefined}  // as expected
foo .length   //=> 3

const bar = (a = 42, b, c) => ({a, b, c})

bar (6, 7, 8) //=> {a: 6, b: 7, c: 8}
bar (6, 7)    //=> {a: 6, b: 7, c: undefined}  // note that the default is overridden
bar .length   //=> 0

From Ramda's point-of-view, though, the larger problem is the function arity.  Note that bar.length is 0.  That's because any default parameters (as well as any subsequent ones) are not counted towards the function arity.  And the arity is critical in how Ramda curries functions.
Because of this, Ramda does not play very well with default parameters, or really with any other technique of handling optional parameters except for the common FP idiom of partially applying initial parameters to one function to get another:  const derivedFn = baseFn (defaultVal), where baseFn is curried.
So this is something central that Ramda could not fix if it wanted to.  For your case, I would suggest not using the default parameter, and simply do something like
const yourFnNameHere = getUniqueValuesByKeys ({name: ['hi']})

and then using yourFnNameHere instead of the original.

@BravenxX  you could use R.curryN(3, myFunction) this will fix the arity at 3.


First run on mac fails

Using freshly installed Monterey 0.2.0 I tried to create the esnext-typescript app, by telling Monterey to fetch it from GitHub navigation skeletons repo.

Starting Monterey app after installing it results with OSX feeling suspicious

Click on the Open button solves this, but I was hoping to be treated more friendly given the fact that the app is signed.

2. The "interview" went fine and I chose not to run NPM in that stage. So, I got to see Monterey in it's full glory, where only a few tiles were installed (there are more tiles in Windows).

3. I started the NPM tile and got this - Note the wheel spinning endlessly

Despite the wheel spinning, I was able to click on the Install button - and here is what happened:

Note the amount of time spent (this takes only a few seconds on my PC. As it was still doing something I went for another screenshot
![screen shot 2016-07-27 at 3 59 37 pm]
(https://cloud.githubusercontent.com/assets/2712405/17190960/ed0f9b20-5415-11e6-894a-c694ef2c9afe.png)
and only then realized that the npm install failed.
No sense in trying anything before this gets properly understood and addressed.

This is not a problem with the app, but rather a courtesy to the user, this probably happens with any executable downloaded from the internet

Ah yes. The tiles you see in windows are specific for windows (explorer.exe does not exist on mac so no reason to show it on mac). We probably need a finder tile for mac

Not sure

Does it really take seconds? Npm install on a new project takes minutes for me (especially skeletons as they have a lot of npm modules). When npm install has already been run it is much quicker though

Something is going wrong with npm, will check

About 1, I have seen the app to be blocked conpletely where you need to disable the firewall to get it to launch, also got an error that the app was created by an unkown developer and you had to explicitly allow the app to run. So the warning you are getting now doesnt seem so bad

After returning back to my PC, I tried to repeat the same steps (I did not do the TypeScript skeleton ever before). Here is what took place

This shows incomplete error handling (the wheel continues to spin), there is no recovery from here (Previous button results with error warning "this is not possible"), so I clicked Close - which does not do anything

try and open devtools, it should show you an error in the console

So the warning you are getting now doesnt seem so bad

I agree and disagree at the same time. The idea of installing an app is so dramatically different from using a web app that I want absolutely no friction in the installation process. This is not to be considered a critical comment to the current installation process, but rather an encouragement to do better :-)

I have the same ambition, but changing apple's gatekeeper software to remove this generic message is not within my power :smile:

Yeah i'd like to, but I have no idea what we would need to do. This really looks like a feature of mac to give users a last chance not to open something (even though the app was signed), as every article on how to remove this warning is about making changes to the OS, not the app

Something we can look into later is deploying monterey through the app store. This would remove this warning as it wouldn't be downloaded from the internet

found this

The app store (https://github.com/electron/electron/blob/master/docs/tutorial/mac-app-store-submission-guide.md) seems to have some gotchas we need to think about (link)

You are getting very close to the solution. As I am a registered app developer let me pick it up from here

Just so we're not miscommunicating, the image I showed explains that the only successful outcome of the test is the message you showed. I've had the other errors but those went away went the signing process got executed correctly. Let me know if you find anything

I understand and agree!

I believe we tackled all issues that we had to tackle :smile:


Fix performance bottlenecks

There is a significant performance issue when performing SQL queries with a large number of results.
Although the query itself takes only 500ms, it takes JS 5 seconds.
I believe there are also additional performance issues with adding many thousands of elements to an array of objects. Vue.js is trying to observe them all when it's not necessary.

Suggest moving from 2D canvas to using Three.js for improved WebGL performance


Use struct instead of generic %{} map

It would be better to define a struct, say %Geolix.Result{} where the map keys are always present, as opposed to building it up with Map.put, because right now, some keys, like subdivisions, are not added to the map for certain addresses, causing a crash.

Well, there probably will never be "that one result struct", simply because the actual result completely depends on the database used. If you look at the official Python library there is some nice documentation about what database type can return what: https://github.com/maxmind/GeoIP2-python/blob/master/geoip2/records.py
That said I am not against a "per database type result struct" if I could put that together in a manageable fashion.
Otherwise there should always be the possibility to just force the Geolix result into the structure you need using Kernel.struct/2 and all default values you need. Or just pattern matching deep into the result and extracting the single values.

All responses are now structs matching the used database type, for example %Geolix.Result.Country{} if you are using a country database. The individual result parts are also structs, for example %Geolix.Record.Location{} for the location information (latitude, longitude, ...).
Please note that if some information are completely unavailable the result key will return nil instead of an empty struct. These cases should be really rare as it mostly looks like a "country entry inside the city database", like "<IP_ADDRESS>". This behavior might change while adding support for the official web services.
Also have a look at the changed usage of Geolix.lookup/2 if you are querying a specific database instead of all available (and registered).


Initialize f.lowest_pixel_mem

It does, I just didn't realize that. I'll rebase on your change.

Fixed in #978 already.


Document YodaConditionals you must

A basic example of a proper (and improper) Yoda conditional, with links back to full documentation on why.

Related #1722

FYI: I've opened a PR in PHPCS upstream to fix the weird word wrapping which is happening with the multi-line standard block: https://github.com/squizlabs/PHP_CodeSniffer/pull/2541

FYI: upstream PR for the weird line breaks has been merged and will be included in PHPCS 3.5.0.

I've rebased the PR and added one commit to make the last fixes needed. Let's get this merged!
For whomever will merge this: probably squash/merge would be a good idea.


Implement first pass CI with build, test, lint, verify

Adds the following flow:

Build + Vet
Unit Tests
Lint (optional, fyi)
Codegen check.

/lgtm
/approve


Expand documentation for central config plugin

Current documentation is out of date and needs a step by step example

How filters are applied.
Tutorial from english requirements to long form
From long form to short form
Explain shorthand filters in more detail
Several short examples with their english meaning

https://github.com/Innablr/revolver/issues/136

Closing. Addressed by https://github.com/Innablr/revolver/pull/154


Directory of ~24,000 files slows things down considerably ..

Describe the bug
I have a directory of about 24,000 files, with some hundred sub-folders, perhaps an additional 10,000 files scattered throughout the tree.  spf slows down considerably on scrolling operations in the root (24k) folder.  Default homebrew install, spf version v1.1.2 MacOS Monterey 12.7.4
To Reproduce
Steps to reproduce the behavior:

Create or use your own local collection of files, approximating 24k.
Scroll through the list as quickly as you can.
Compare to a directory containing a lesser amount, e.g. 100.
See error

Expected behavior
UI performance doesn't slow down with larger lists of files.
System information:

OS: MacOS Monterey
Version 12.7.4
Superfile Version v1.1.2

I'm pretty sure there's this bug to fix.

@seclorum Thanks for your report!
I think this should have been successfully fixed.
The following video demonstrates the smoothness at 50,000 files.
https://github.com/yorukot/superfile/assets/107802416/fca7102c-1625-4a09-8581-f8f3b8aaaec7

Can confirm, is definitely more performant..  Nice!


updating the version of black to fix errors in pre-commit

Updating black to fix issue here: #188
Please pull branch and test on your local jupyter notebook to verify fix.

PR redundant because version update has been handled in #187


Installing packages from git repositories

I couldn't find instructions on installing packages from git repositories. https://github.com/pypa/pipfile seem to suggest that the spec is:
pinax = { git = 'git://github.com/pinax/pinax.git', ref = '1.4', editable = true }

but i'm not sure whether this is supported or implemented.
I wouldn't mind making a pull request if it's not done yet.

Hey @jeeyoungk, thanks for taking the time to check in on this. Version Controlled dependencies were implemented in 3.5.0, so it should be working fine now. Please let us know if you're encountering problems.


Update CHANGELOG for security fixes

Overview
Update CHANGELOG for security fixes. This accounts for all the security fixes that could be made using dependabot.
Connects #781
Notes
See:
https://github.com/open-apparel-registry/open-apparel-registry/pull/784
https://github.com/open-apparel-registry/open-apparel-registry/pull/785
https://github.com/open-apparel-registry/open-apparel-registry/pull/786
https://github.com/open-apparel-registry/open-apparel-registry/pull/787
https://github.com/open-apparel-registry/open-apparel-registry/pull/788
https://github.com/open-apparel-registry/open-apparel-registry/pull/789
https://github.com/open-apparel-registry/open-apparel-registry/pull/790
Testing Instructions

trivial

Checklist

[ ] fixup! commits have been squashed
[ ] CI passes after rebase
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Thanks!


Fix load_model from hf:// preset

Follow-up PR after https://github.com/keras-team/keras/pull/19854 fixing load_model when trying to load a model from the Hugging Face Hub.
At the moment (keras==3.5.0), running the following snippet
# Available backend options are: "jax", "tensorflow", "torch".
import os

os.environ["KERAS_BACKEND"] = "torch"

import keras

model = keras.saving.load_model("hf://Wauplin/densenet_121_example")

fails with
Traceback (most recent call last):
  File "/home/wauplin/projects/huggingface_hub/az.py", line 10, in <module>
    model = keras.saving.load_model("hf://Wauplin/densenet_121_example")
  File "/home/wauplin/projects/huggingface_hub/.venv310/lib/python3.10/site-packages/keras/src/saving/saving_api.py", line 179, in load_model
    file_utils.copy(filepath, local_path)
  File "/home/wauplin/projects/huggingface_hub/.venv310/lib/python3.10/site-packages/keras/src/utils/file_utils.py", line 478, in copy
    return gfile.copy(src, dst, overwrite=True)
  File "/home/wauplin/projects/huggingface_hub/.venv310/lib/python3.10/site-packages/tensorflow/python/lib/io/file_io.py", line 581, in copy_v2
    _pywrap_file_io.CopyFile(
tensorflow.python.framework.errors_impl.UnimplementedError: File system scheme 'hf' not implemented (file: 'hf://Wauplin/densenet_121_example')

To load a model with the current version, one need to use keras.src.saving.saving_lib.load_model which is not the intended way:
import keras

# works !
model = keras.src.saving.saving_lib.load_model("hf://Wauplin/densenet_121_example")

The error comes from the fact that in keras.saving.load_model we don't check if the filepath is a hf:// preset. This PR fixes this.

How to test
Run the first snippet above and it should load properly.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.70%. Comparing base (a3b4e20) to head (ffae2fb).

:exclamation:  There is a different number of reports uploaded between BASE (a3b4e20) and HEAD (ffae2fb). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (a3b4e20)
HEAD (ffae2fb)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20215       +/-   ##
===========================================
- Coverage   79.37%   57.70%   -21.68%
===========================================
  Files         501      501
  Lines       47435    47436        +1
  Branches     8710     8710
===========================================
- Hits        37652    27372    -10280
- Misses       8020    18356    +10336
+ Partials     1763     1708       -55

Flag
Coverage Δ

keras
57.70% <100.00%> (-21.53%)
:arrow_down:

keras-jax
?

keras-numpy
57.70% <100.00%> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Clean up ordering of internal handlers.

I've been running this on Septapus for a couple of days, no issues.


Add alert for when user needs to upgrade plan

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
Add an alert bar for when user needs to upgrade their plan.
📝 Additional Context
No response
Acknowledgements

[X] My issue title is concise and descriptive.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

Fixed in #649


[AMS] update AMS stable version to include Edge list api

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[x] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

Signing off from ARM side.

/azp run automation - sdk

/azp run automation - sdk


Services build

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_49_ossviwj/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:52: invalid_url: http://segyio.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:31: remove_python_pinning: On arch specific packages, python deps should not be constrained.
clone/recipe/meta.yaml:34: remove_python_pinning: On arch specific packages, python deps should not be constrained.
===== Final Report: =====
2 Errors and 3 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_db7w29qnmg/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:52: invalid_url: http://segyio.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 3 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_bbftx4f9wz/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:52: invalid_url: http://segyio.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 3 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_328zogtvrc/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:52: invalid_url: http://segyio.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 3 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_89wjhfyzp8/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:52: invalid_url: https://segyio.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_9645i_aprp/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:52: invalid_url: https://segyio.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d8xcbr0gk1/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:45: python_build_tool_in_run: The python build tool setuptools is in run depends
clone/recipe/meta.yaml:63: invalid_url: https://segyio.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_addmupeoyu/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:46: python_build_tool_in_run: The python build tool setuptools is in run depends
clone/recipe/meta.yaml:64: invalid_url: https://segyio.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found


Logout Pop-up added

Fixes:  #2526
Description
Added Logout pop-up
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/ed47984e-a49f-40cc-90e1-fb67f355e74f
Checklist:

[X] I have made this change from my own.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X]  My changes generate no new warnings.
[X]  I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

niceee....


ArduCAM_Host_V2 not working?

I have a ArduCam Mini Ov2640 with ESP8266 NanoV2. I have been able to use the capture and Vid2SD examples and they all work. But I am trying the Host_V2 in Windows 10, and I can connect to the IP, but when I click Capture, no picture or stream is captured. I have SaveImage checked and a path selected, but no file is saved. I can type in the IP address with /stream or /capture in my browser and I get an image/stream from the camera. Should a window open from the Host program and display the feed?

Hi,
Very for pur host's bug, Please download  it https://github.com/UCTRONICS/pic/raw/master/ArduCAM_Mini_QT.exe
and copy to your ArduCAM_Host_V2.0_Windows path.

Hi,
Thank you, this version gives me a picture and a live stream from the camera. But this version does not allow the functions to change the Light or Color or Contrast. Also it doesn't allow to 'SaveImage'. Is there a bug in the Host_V2 program?

@JSField
Hi，
Yes, at present, our esp8266 demo  don't support setting more functions.
we will update it in the future.


PiVPN on docker

Installing PiVPN with docker would be cleaner and safer.
With association with Pihole (Docker)

Yeah, docker works perfectly. But two minor limiations:

Docker doesn't like bridge interfaces if it's not under Linux env
Docker is not mainstream with small customers

1 - Iptables & Networking does not work the same way inside docker containers
2 - you need to account for the certificates generation and make sure that not everybody ends up having the same certificates.
3 - It forces a MAJOR refactor on the whole pivpn code.
So now that you have the guidelines ... I am more than glad to review a pull request that accomplishes what I have (so far) failed to do!


Odometer units for first part of protocols

Made changes to use meters in KEY_ODOMETER
Other changes to use right keys in some protocols

Excellent, thanks for pull request.

Oh, I've found the problem:
I've replaced in few places parser.next() to parser.nextDouble() or parser.nextInt() and they both return  0 or 0.0 even if match is optional. For example my wondex device do not send odometer, but it always 0.0 because of that calculated distance is always "0.0"
Add check if (parser.hasNext()) for such optional cases will be correct?

Yes, it should be fine if you call hasNext.


RN CD July 14

RN PR: https://64b05bda7d9564440ef1aa97--harness-developer.netlify.app/release-notes/continuous-delivery

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@michaelcretzman I added suggestions to add the following to delegate items:
This item requires Harness Delegate version 79xxx. For information about features that require a specific delegate version, go to the Delegate release notes.
Also, should https://harness.atlassian.net/browse/CDS-73127 be included? Release Notes Candidate is set to Yes, but there isn't a Public Release Notes Summary.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Fix vs std11 commands

Fixes #2630 and #2335
The issue is that we were marking all commands as "handled" for VSConstants.VsStd11 and Guids.guidInteractive command groups.
If we can't handle these commands we'll just let the others in the command chain have a chance to handle them.
Thanks to @majocha for help with the code.

@JoshVarty
Thanks for this mate
Kevin


2017 Pre-season Data seems to be missing

Nu2All, I don't see 2017 Pre-season data.
Is there something additional required to get 2017 statistical data?

Closing issue needed to run:
python update_sched.py --year 2017 with correct permissions..


Install Instructions? Alternatively, HACS manifest?

I looked at the PR into HA, and it seems like there are a lot more to the integration then what is in this repo.
I've tried dropping it into my custom_components folder (I have other custom components that work, installed from HACS) but I'm not seeing anything.
The readme also mentions HomeKit -- Does it integrate as a homekit device?

OK -- im realizing now that this isn't a custom component, but instead a piece thats included in the HA integration.
I guess I'll just wait for them to merge it (tried copying the files from your branch into custom components with no luck.

@applehat I've just created a new repo along with installation instructions for registering this as a custom component:
https://github.com/bm1549/home-assistant-frigidaire

Awesome. Thanks man!
Hopefully you get merged into Core soon
On Sun, Jun 27, 2021 at 9:38 PM Brian Marks @.***>
wrote:

@applehat https://github.com/applehat I've just created a new repo
along with installation instructions for registering this as a custom
component:
https://github.com/bm1549/home-assistant-frigidaire
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bm1549/frigidaire/issues/3#issuecomment-869294921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACAC7BXRGDPGMO5VJ66RMTTU7OCXANCNFSM46R6RUXA
.

@applehat I added the repo to HACs as a custom repository which made install a breeze.


feature: assign reviewer for community request

Is your feature request related to a problem? Please describe.
We'd like to be able to assign a specific community member as reviewer for a request. This is useful for managing large numbers of requests that need curation
Describe the solution you'd like
We'd like a new field in requests called reviewer. This field would accept any community member. It would be listed as a facet in the requests page, and allow for curators to view only the records they would be responsible for. We would not expect this field to change the permissions model (all curators would have the same permissions), but be used for organizing the review process.

Still active


Update missing streets

http://www.ebru.be/Streets/bruxelles-1000-rue-christine.html
i thought adding osm tag of etymology would update this but it's not the case right?

Hello @eMerzh ,
The process is indeed based on OpenStreetMap name:etymology:wikidata (so no need to update gender.csv file)!
But the process looks first for the type=associatedStreet relation !
I added the tag on the relation, it will be updated at the next update.
Thanks a lot for the feedback!

Rue Herrewege already has been updated: https://equalstreetnames.brussels/fr/index.html#17.21/50.868959/4.330374


Update compiling, parsing, printing

These updates avoid the following error:
lander@MacBook-Pro-de-Lander:/tmp/new_HRIM/HRIM (master)$ python hrim.py generate --platform ros2 all
Traceback (most recent call last):
  File "hrim.py", line 5, in <module>
    from printing import ModulePrinter
  File "scripts/printing.py", line 1, in <module>
    import lxml.etree as ET
ImportError: No module named lxml.etree

I know that this is on the README.md but just in case. Take or leave it, is just a suggestion.

I'd go through with this, maybe after reviewing https://github.com/erlerobot/HRIM/pull/21 (as this code would probably have to be modified). Also easy to add more platforms.


feat!: use generics instead of cbg.Deferred

Experimenting with generics to do away with the deferred value decoding step.
The generic must conform to [T HamtValue[T]] where:
type HamtValue[T any] interface {
	Equal(T) bool
	MarshalCBOR(io.Writer) error
	UnmarshalCBOR(io.Reader) error
}

* pointers are kind of awkward in this, tho I'm not sure I can do much better without heavier changes (e.g. there's situations where you want to pass nil to indicate deletion)
The Equal is a little annoying, but necessary to know whether we're mutating in certain situations
FindRaw is gone, doesn't make sense anymore I think.
Find has a current use-case where you pass nil as the decoder and that means "I just want to know if it's there"; for certain types T it'll be more expensive to decode the full node with T elements than it was to do the cbg.Deferred cbor token skip job. Maybe.
Needs some benchmarking in cases like the lotus actor state migration where I'm suspecting this might be of benefit.
Maybe this could be /v4 but we still retain the /v3 variant for some cases.

Experimentation with this going on over at https://github.com/filecoin-project/go-state-types/pull/298

Rebased on #121, which has the restored cbor-gen code in it, so this now depends on https://github.com/whyrusleeping/cbor-gen/pull/103 for cbor-gen generics support.

Bailing on this for now, as per https://github.com/whyrusleeping/cbor-gen/pull/103#issuecomment-2398852941


Detailed Review // "Published At Date" is always empty

Hi.
I am using the newest version (download and installation on 2024-11-07).
If I active "Detailed Reviews", the column "Published At Date" is always empty.
"Published At" in text format is working, but date format is empty.
On "Featured Reviews" everything works fine.
Please fix.
Thanks in advance.
Tobi

That data point is only available for english language, as we compute it.

Hi @Chetan11-dev.
Thanks for the quick response.
I did not get it. On "Featured Reviews" is is working - even I change the language to not be english. See screenshot with German language.
Best,
Tobi

detailed reviews date is derived fro, text field, as such format data is not provided.

technically not possible


Add diag log env variable

@MarcoRossignoli  what do you think? Should we make it more configurable? (verbosity?) and change the naming some more?

Looks good...but yep maybe we should add the verbosity so we can ask to start with Error and after Verbose during the analysis, improving a bit the perf.

Maybe I should only call it VSTEST_DIAG, to keep the same name as the argument?

Maybe I should only call it VSTEST_DIAG & VSTEST_DIAG_VERBOSITY to keep the same name as the argument?

Yep sorry misread

:shipit:

@nohwnd I have added some minor comments, feel free to disregard them all.


question

does anyone know what is going on here
file has not been edited

you need Haxe 4.3, also this isn't the repo to make this issue

you need Haxe 4.3, also this isn't the repo to make this issue

...haxe/lib...

you need Haxe 4.3, also this isn't the repo to make this issue

...haxe/lib...

this isn't an haxelib issue, this is just an haxe issue, or rather an you issue


Added SPFx 1.7 Release Notes

Category

[x] Content fix
[ ] New article

What's in this Pull Request?
Added link to SPFx 1.7 release notes to the README.md page.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx @hugoabernier, appreciated.


Improve isCreditCard coverage to 100%

Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:

[x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Coverage increased (+0.03%) to 74.205% when pulling 3bc2df61d7a475d19ea98e3c268df2a5bccd2a1d on Gigaxel:credit-card-validation-coverage into 9e2ea4038020b5c7e3802a21cfa4e3afcfdcd276 on go-playground:master.


Add Grit migration script

You can try this out by running
grit apply valibot_v03

Grit also includes built-in testing for the markdown file. Just run grit patterns test in this repo.

You can always copy the output to our playground to see if the transformed code is valid.

If I run grit apply valibot_v03 I get the following error: Error: Permission denied (os error 13)

Once I can confirm that the codemod works, I will add instructions on how to run it to our migration guide. Do people need to manually add the .grit/patterns/valibot_v03.md file to their repo to run the command? Does it only works on Linux and MacOS?

If I run grit apply valibot_v03 I get the following error: Error: Permission denied (os error 13)

Hmm, what steps did you take to install it / can you provide reproduction instructions? This isn't expected.

Do people need to manually add the .grit/patterns/valibot_v03.md file to their repo to run the command?

Yes, currently they will need to download it. I'm planning to add a feature for applying remote patterns directly too.

Does it only works on Linux and MacOS?

We also have Windows releases available.

Hmm, what steps did you take to install it / can you provide reproduction instructions? This isn't expected.

I followed the Quickstart guide and executed: npm install --location=global @getgrit/launcher. I can run grit. So the installation was successful.
I got it to work with sudo but it should work without it. I will test the codemod in the next few days and get back to you. Thanks again!

Yes, currently they will need to download it. I'm planning to add a https://github.com/getgrit/gritql/issues/356 for applying remote patterns directly too.
We also have Windows releases available.

👍

I got it to work with sudo but it should work without it.

Agreed, sudo definitely shouldn't be required. Maybe you can try running grit doctor without sudo to figure out why. I'm also happy to help debug on Discord.

I get the same error when I type grit doctor. With sudo it prints out environment and configuration info. I will get back to you on Discord tonight or in the next few days. In the meantime, if you have time, you can try to get the following codemod to work.

Hint: transform and brand can be deeply nested and should now be placed next to each other in the pipeline of the wrapped schema.

// Before
const Schema = v.transform(
  v.brand(v.string(), "Name"),
  (input) => input.length
);

// After
const Schema = v.pipe(
  v.string(),
  v.brand('Name'),
  v.transform((input) => input.length)
);

This now handles brand and transform.


[WIP] elasticsearch adoption command

@t0ffel FYI

/cc @jcantrill
So that's a separate binary, which will be run in a separate image prior to running the operator, right?
The adoption binary doesn't register the CRD , who will be registering it?

@t0ffel Correct, we will update the operator deployment object to have an init container which will run and execute this command. The customer or the cluster logging operator will register the CRD, I believe.