Amplify Hosting failing Hugo builds

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d3q5nd3xz6zwmz
Region
us-east-1
Amplify Hosting feature
Backend builds, Build settings, Not applicable
Describe the bug
Trying to deploy my Hugo static site. Amplify worked fine before and now failing during frontend build process with very little information around what has occurred. Site builds fine locally.
2022-07-01T22:51:34.637Z [INFO]: DEBUG 2022/07/01 22:51:34 Render XML for "sitemap" to "/sitemap.xml"
2022-07-01T22:51:34.673Z [INFO]: DEBUG 2022/07/01 22:51:34 Render 404 page to "/404.html"
2022-07-01T22:51:34.691Z [INFO]: DEBUG 2022/07/01 22:51:34 Render page  to "/index.json"
2022-07-01T22:51:50.115Z [WARNING]: /codebuild/output/src930700667/src/mysite.net/amplify.sh: line 36:  2372 Killed                  hugo --gc --cleanDestinationDir --debug
2022-07-01T22:51:50.172Z [ERROR]: !!! Build failed
2022-07-01T22:51:50.177Z [ERROR]: !!! Non-Zero Exit Code detected
2022-07-01T22:51:50.177Z [INFO]: # Starting environment caching...
2022-07-01T22:51:50.189Z [INFO]: # Uploading environment cache artifact...
2022-07-01T22:51:50.328Z [INFO]: # Environment caching completed
Terminating logging...

Expected behavior
Site passes build step and deploys
Reproduction steps

Commit update to GitHub
Wait for amplify pipeline to fail

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - curl -s https://api.github.com/repos/gohugoio/hugo/releases/latest | grep "browser_download_url.*hugo_extended.*_Linux-64bit\.tar\.gz" | cut -d ":" -f 2,3 | tr -d '\\"' | wget -qi -
        - tar -xzf "$(find . -name "*Linux-64bit.tar.gz")"
        - chmod +x hugo
        - mv hugo /usr/bin/hugo
        - rm -rf "$(find . -name '*Linux-64bit.tar.gz')"
        - hugo version
    build:
      commands:
        - hugo version
        - hugo --debug
  artifacts:
    baseDirectory: public
    files:
      - '**/*'
  cache:
    paths: []

Additional information
Hugo+Extended version is what i use.

The issue is so random as well. Same codebase, just worked for some odd reason in dev but when dev merged into prd, same failure again.
Both development and main branches are identical.
I bet on my next push to development that it will fail again.

Some additional logging info, not sure if it helps, my development is failing on builds again as well so that pass must have been a fluke:
2022-07-05T22:59:16.445Z [INFO]: DEBUG 2022/07/05 22:59:16 Render page  to "/index.json"
2022-07-05T22:59:19.204Z [INFO]: Alloc = 4.7 GB
                                 TotalAlloc = 59.9 GB
                                 Sys = 6.3 GB
                                 NumGC = 81
2022-07-05T22:59:24.324Z [INFO]: Alloc = 5.4 GB
                                 TotalAlloc = 60.6 GB
                                 Sys = 6.7 GB
                                 NumGC = 81
2022-07-05T22:59:31.882Z [INFO]: Alloc = 5.5 GB
                                 TotalAlloc = 60.7 GB
                                 Sys = 6.8 GB
                                 NumGC = 81
2022-07-05T22:59:31.962Z [WARNING]: /codebuild/output/src688803540/src/geeklingo.net/amplify.sh: line 36:  2457 Killed                  hugo --verbose --debug -D --printI18nWarnings --printMemoryUsage --printPathWarnings --printUnusedTemplates
2022-07-05T22:59:31.966Z [ERROR]: !!! Build failed
2022-07-05T22:59:31.967Z [ERROR]: !!! Non-Zero Exit Code detected

Hi, I have the same issues.    I can have a site build in AWS amplify time after time. The it suddenly fails and keeps failing to build.
It's pretty painful.   This usually bites me in the arse after some minor update I decided to do just before bed time or going out.

I have the similar issue. When building the frontend, an error is reported that parse failed in a template file.
This issue was resolved by specifying that Amplify build to use the latest version of Hugo.
First make sure the template file has no syntax errors.
Then specify the Hugo version: AWS Amplify Console -> Your App -> App Settings -> Build settings -> Build image settings - "Edit" button -> Live package updates -> Hugo -> Version,
fill in the latest Hugo version number, for example: 0.105.0. Be careful not to add the letter v in front of the version number.
Hugo released versions can be viewed here https://github.com/gohugoio/hugo/releases/

Hi everyone 👋 , thanks for your continued patience and apologies for the delayed response on the thread.
Currently, the Amplify Hosting compute container uses Hugo version 0.75.1 by default to build your Hugo sites. If you are running into errors during the frontend build step, our recommendation would be to use the live package update feature for the Hugo package to override the default version and you can either specify a specific version or ensure that the latest version is always installed during the build.
Hope this information helps unblock your builds!


Use ' instead of " in our scripts for literal strings

We should use ' instead of " in our scripts for literal strings.
Ex:
MEILISEARCH_ENVIRONMENT="development"

should be
MEILISEARCH_ENVIRONMENT='development'

I can work with this issue

Can i work on this issue?

We assigned you, please go 🔥
thank you


Show links from the caption

Hi I have been trying to browse for this issue but unfortunately can't seem to find it. I am trying to show the links from the caption of an instagram post. Can someone help? TIA

Hi @jpdpueyo - Can you show an example of your code? A CodePen or JSFiddle example would be really helpful. Thanks!

Hi @benjamin-hull! Thanks for the response. Here is my code.
https://codepen.io/jpdpueyo/pen/aKmwYY
What I'm trying to do is to get the link that I have placed in the caption then display it in my website feed.
I have seen some projects like this. I would like to replicate them. Can you help? Thanks!

Dear All,
The same problem I have it, like @jpdpueyo .
I had to read a lot of suggestions but unfortunately no one have the right way
Please @benjamin-hull I appreciate that if you can helping me.
Thanks in Advance
Mustafa

Hi guys,
If I understand correctly, you want to detect URLs in the image caption, and convert them to links?
If so, you'll need to do a little extra work with javascript make that happen. Doing this for any possible URL is harder than it seems at first glance. There are various packages out there to do a thorough job, for example https://soapbox.github.io/linkifyjs
Check this pen: https://codepen.io/benjamin-hull/pen/qKjXxX for an example of how to use instafeed.js success callback to run through and 'linkify' all the captions before they're inserted into the page.
Hope that helps - let me know how it goes!

Dear @benjamin-hull,
Thanks a lot for your time and Effort to help us.
For me I found the solution but now I have another problem with the CSS to make it responsive but I hope I'll find the solution, if not I will write to you if that possible?
wish you a beautiful day.
Mustafa

Hi @benjamin-hull Thank you very much for your assistance. Really appreciate it. More power!


add mybinder for examples. update license. add authors file.

Let me know if the format of the authors file is okay! Additionally, I have the binder generate within the examples folder, so it might make sense to add a section of the README that describes available examples and move the badge there.

I just tried running a binder and everything worked with the exception of pandas. Do we need to add some sort of requirements file or environment file in order to get this to work?

we do! I'll add that, I forgot it wouldn't take it from the requirements already there. my bad.

You're right at that pandas is missing. it's because binder sources from the requirements.txt file in the base repo. Since we only need pandas for these examples and not the reps, it's not an actual dependency. I don't see an easy way to list it only as a dependency for the notebooks, but i'm looking further into it.
I will fix these commits, but i need to push to my branch to test binder right now

Can we do something with an enviroment.yml as we did for QMMM?

So as of now, I actually think the best option is to have a requirements.txt that exists only inside of a binder directory that can install binder from pip and then pandas.  Mybinder will default to look in the binder folder,  but when  the binder folder exists, it no longer will install the setup.py by default. This necessitates the install from pip.  What do you think about this?
Did we reset up the pypi to reflect the organization switch? This links (https://pypi.org/project/chemreps/) homepage points back to @dlf57 repository and the badges seem off.

What if we did a pip install git+https://github.com/chemreps/chemreps? I think it would be better to point here as it will ensure that it is always grabbing the latest reps even if we have yet to update pypi. Also, yes we do need to update pypi.

Also, I had missed your comment at the top about posting the binder badge in the readme of the examples. Do you think it would be good to have it in both readmes? That way if someone is just checking the examples out they can click it from there instead of going all the way back but also keep it on the main readme as a quick way if people know they just want to start looking at the examples?

Edit2: I see you have a requirements.txt instead of the postBuild script. What if we put git+git://github.com/chemreps/chemreps@master in the script as they talk about here

this is exactly what I was looking for. I didn't love installing from pip as updates between versions may include new tests. this is much nicer. Thanks!

Do you think it would be good to have it in both readmes?

Absolutely. This is the kind of clearness I was hoping for, slipped my mind we had a README in examples already! I have made those changes.

Thanks for figuring this out guys. It's nice to see this is possible.


Correct hipsparseLtGetProperty function name

Fix for https://github.com/ROCm/hipSPARSELt/issues/157.
Correct typo from hipsparseLtGetPorperty to hipsparseLtGetProperty in library/src/hcc_detail/hipsparselt.cpp.

The CI seems not running,
Used local test instead.
The local test is passed.
[----------] Global test environment tear-down
[==========] 105252 tests from 4 test suites ran. (3778249 ms total)
[  PASSED  ] 105252 tests.
hipSPARSELt version: 202


pip install -r

Hi,
RTD is installing modules from requirements.txtand I can't understand why is it required, because of this my build is failing because some of the C library packages are not there.
Now is there any way to skip the installation of modules from requirements.txt file.
Thanks

Hi @stsewd , sorry for the late reply.
I did not give the build and project url because I thought it's a general question.
https://readthedocs.org/projects/testthug/builds/7066425/ - this should suffice I guess.
Moreover I have requirements.txt for my tool but do not want to specify an extra requirements.txt for RTD. I am looking for ways in which I can disable the installment of the modules because it's not necessary.

@kira0204 did you delete your project? I can't see your build or your project. RTD always look for a requirements file on your project (first on the docs/ directory and then in the project root), that's a RTD feature, I think you can create an empty requirements.txt file in the docs/ directory.

@stsewd I got my privacy level as private which I changed it now, sorry for the inconvenience. Also I provided a conf.py file in my docs folder to mock one of the modules (RTD FAQs suggested this) but I don't think RTD is reading my file because I think in the build it should mention something along the lines cat /path/to/conf.py

Update: Blank requirements.txt file works, but I would really love an option where I can select whether RTD should install requirements or not. Thanks @stsewd

@kira0204 yeah, that's part of the rtd philosophy, a user imports a project and should just work, I'll try to see if we can put this as an option for the yaml file.


Patch 1

podspec add the weak_framework setting of SceneKit

I don't understand when something should be a weak framework or not. Why is this under weak and not just frameworks like the rest?

I don't understand when something should be a weak framework or not. Why is this under weak and not just frameworks like the rest?

Year, frameworks is ok.  I thought “SceneKit” is base on iOS 11， The original is On iOS 8


[question] pl/sql execution

Hi,
When I try to execute an oracle pl/sql script (with ALT+X ) for exemple:
BEGIN
FOR i IN 0..10 LOOP
dbms_output.put_line(i);
END LOOP;
END;
/
I'm always receiving  the following error message:

As the script is working fine with other database tool like TOAD, I'm asking if there is any configurations/parameters to be applied.
thanks in advance

DBeaver doesn't support (yet) Oracle style of scripts dividing.
Workaround: select your query and run with CTRL+Enter.

Effectively , the workaround is working fine .
Thank you for this great db tool.


Add 'mobile-center init' command

The command helps to integrate Mobile Center SDKs of user's choice (Analytics, Crashes, Distribute and Push SDKs are supported) into any supported project.
Current state supports SDK integration into Android ans iOS native projects (Java and ObjC/Swift respectively) and can be relatively easily extended to support other platforms/types of projects
The result of running mobile-center init command is an interactive wizard that asks user for all requred information and updates source files. For Android no further steps required and after integration project is ready to be built, for iOS user needs to run pod install in terminal to install required dependencies.
The command is indempotent and supports consequent runs againts the same project multiple times. Consequent runs overwrite changes made by previous command call.
This commit is a summary of work made by Dmitry Zabello<EMAIL_ADDRESS>and Denis Kudelin<EMAIL_ADDRESS>For the full history of the work see https://github.com/foreverest/mobile-center-cli/commits/master

@vladimir-kotikov,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


fix(v2): add a11y support for dropdown

Motivation
After that, you can open dropdown (and navigate it) using the keyboard, this is good for accessibility.
In addition to that, in current PR, for consistency and easier code understanding, I changed the naming of some args and moved the custom CSS class to the end of the class list. This is a simple refactoring.

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

I am merging this PR, because I think that these are safe changes.


batch requests

Hi, thank you for your great job!
But i encountered a problem that the method bacthOfRequests: has been delete when i updated the AFNetworking 3.0 .
I read your code , maybe your SessionOperation can help me, Could you make some suggests for me ?
Thank you!

Yes, batchOfRequestOperations was retired, and yes, you can achieve similar functionality using this operation subclass because this enjoys all of the NSOperation features. Thus, if you want notification when all the requests are done, you can do that using operation dependencies, for example:
NSOperation *completionOperation = [NSBlockOperation blockOperationWithBlock:^{
    NSLog(@"all done");
}];

AFHTTPSessionManager *manager = [AFHTTPSessionManager manager];
manager.responseSerializer = [AFImageResponseSerializer serializer];

NSOperationQueue *queue = [[NSOperationQueue alloc] init];
queue.maxConcurrentOperationCount = 3;

NSArray *filenames =<EMAIL_ADDRESS>@"file2.jpg", @"file3.jpg", @"file4.jpg", @"file5.jpg", @"file6.jpg"];

for (NSString *filename in filenames)  {
    NSString *urlString = [@"http://example.com" stringByAppendingPathComponent:filename];
    NSOperation *operation = [AFHTTPSessionOperation operationWithManager:manager HTTPMethod:@"GET" URLString:urlString parameters:nil uploadProgress:nil downloadProgress:^(NSProgress *downloadProgress) {
        NSLog(@"%@: %.1f", filename, downloadProgress.fractionCompleted * 100.0);
    } success:^(NSURLSessionDataTask *task, id responseObject) {
        NSLog(@"%@: %@", filename, NSStringFromCGSize([responseObject size]));
    } failure:^(NSURLSessionDataTask *task, NSError *error) {
        NSLog(@"%@: %@", filename, error.localizedDescription);
    }];
    [completionOperation addDependency:operation];
    [queue addOperation:operation];
}

[[NSOperationQueue mainQueue] addOperation:completionOperation];

Or you can monitor the progress of the individual downloads in aggregate using NSProgress, like shown in the Swift example on the README page. There are tons of options.


Print clang tree for debugging

For simplification of debug, we can create function print for clang ASTree.

There is already a way to print out the clang AST from the CLI?


infinite build times on hf private spaces using docker image

Issue Type
Bug
Source
docker
Giskard Library Version
not sure i just used the gui
OS Platform and Distribution
huggingface spaces (not sure , used the image from hf)
Python version
not sure , didnt check, sorry !
Installed python packages
from docker image

Current Behaviour?
infinite build times on private spaces deployment on huggingface

Standalone code OR list down the steps to reproduce the issue
using the hf gui to launch docker image on private spaces

Relevant log output
https://huggingface.co/spaces/open-acc/giskard?logs=build

===== Build Queued at 2024-11-20 19:52:18 / Commit SHA: ecc877b =====

Hey @Josephrp  - Sorry, we've deprecated this Docker image in favour of a newer product: https://www.giskard.ai/products/llm-evaluation-hub
We don't distribute this product on HF spaces but via hosted SaaS or on-private-Cloud k8s installation. Could you give us more information of you AI use case and testing need?
@Inokinoki could you add a note on the documentation on huggingface side to remove it and mark the deprecation?


Allow creation of white items

I could not find another option as loading an included item and stripping it off its attribues. It would be nice to have all base items ready as well.

I second this.  I was trying to test something, and discovered that I couldn't add armor bases to creat armor runewords for testing...

#101


stargaze-js v0.40.0

Removes the old proto files, uses the new.

Broken... : (
Will make a working version.


[issue-58] - create block for discover holidays

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--jet2holidays-portugal--aemsites.aem.live/
After: https://issue-58--jet2holidays-portugal--aemsites.aem.page/drafts/rnecsoiu/banner

https://issue-58--jet2holidays-portugal--aemsites.aem.page/drafts/rnecsoiu/banner

Hey, fixed the padding and some sizes. For the font, for now i've added an import from google fonts, they are getting it also from there, would it be okay for us to also do it?


Removes unnecessary CSSLayoutContext param from CalculateLayout

Closes #222 for the csharp implementation which does not use the CSSLayoutContext parameter in the CalculateLayout method call.

Thanks! looks good. I'll merge this on Monday morning

Thanks for importing. If you are a Facebook employee, you can view this diff on Phabricator.


openshift/v4_10_exp: Add kdump configuration for MachineConfig

Enabling kdump requires much configuration such as a systemd unit, kernel arguments, configuration files. This change simplifies the configuration by introducing a syntax sugar discussed in #175 for openshift.

Thank you for the comments. I will update the PR.

I'm afraid I got busy for other tasks after the last comment and have not been able to spend time on this work.


Automated Package Upgrade

:tada: This PR is included in version 12.4.130 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SSL/TLS errors

Environment

OS: CentOS
Erlang/OTP: R2.0
EMQ: 2.3

Description
After setting our own SSL/TLS certificate,
we got the crash errors as below, is there any solution to fix this up?
2017-11-01 21:12:20.171 [error] <0.23124.0> CRASH REPORT Process <0.23124.0> with 0 neighbours crashed with reason: {ssl_error,{options,{keyfile,"/.     ",{error,{asn1,{{invalid_length,6},[{asn1rt_nif,decode_ber_tlv,1,[{file,"asn1rt_nif.erl"},{line,85}]},{'OTP-PUB-KEY',decode,2,[{file,"OTP-PUB-KEY.erl"},{line,1103}]},{public_key,der_decode,2,[{file,"public_key.erl"},{line,238}]},{ssl_config,init_private_key,5,[{file,"ssl_config.erl"},{line,106}]},{ssl_config,init,2,[{file,"ssl_config.erl"},{line,38}]},{ssl_connection,ssl_config,3,[{file,"ssl_connection.erl"},{line,...}]},...]}}}}}} in esockd_connection:upgrade/1 line 131
2017-11-01 21:12:20.172 [error] <0.1977.0> Supervisor 'esockd_connection_sup - <0.1977.0>' had child connection started with emqttd_client:start_link([{max_publish_rate,0},{client_idle_timeout,30000},{client_enable_stats,false},{max_clientid_len,...},...]) at <0.23124.0> exit with reason {ssl_error,{options,{keyfile,"/",{error,{asn1,{{invalid_length,6},[{asn1rt_nif,decode_ber_tlv,1,[{file,"asn1rt_nif.erl"},{line,85}]},{'OTP-PUB-KEY',decode,2,[{file,"OTP-PUB-KEY.erl"},{line,1103}]},{public_key,der_decode,2,[{file,"public_key.erl"},{line,238}]},{ssl_config,init_private_key,5,[{file,"ssl_config.erl"},{line,106}]},{ssl_config,init,2,[{file,"ssl_config.erl"},{line,38}]},{ssl_connection,ssl_config,3,[{file,"ssl_connection.erl"},{line,...}]},...]}}}}}} in esockd_connection:upgrade/1 line 131 in context connection_crashed

@hbahn  Would you please provide more informations?
For example:

listener.ssl.external.keyfile = ?, certfile = ? in etc/emq.conf
etc/certs directory details?


[ WIP ] Added basic check to exit given no sass path

Fix #91

Add test for module with no sass, only js - seems to pass but could be false positive?

After more digging it appears that tweaking pancake isn't actually required. The problem that started this PR and #91 was the thought that pancake can't handle a sass dependant component that requires a non-sass dependant component, this doesn't seem to be true.
What is required though is the pancake.sass key be set with 'name': false correctly on the non-sass dependant component.
We should still add a test for this specific case but it turns out pancake actually handles this correctly.

Closing this in favour of #93


gen_data.py assumes that sql table exist, no code to create them?

It looks like python/gen_data.py is assuming that a number of tables exist in the SQL database - events, gd_runs and there is no code to create them, and one is left trying to guess what the schema for those tables is supposed to be and then creating them manually.

I tracked down my original schema file and made a gist: https://gist.github.com/dselsam/cd0f46c3ca366120c6074bf73d49a1f9

Thank you! Will try it now. But as I was trying to recreate it manually, I realized that DB initialization seems to include not only the table schemas, but some actual preloading of SAT problems into the DB - so I guess would still need to figure that one out...

The problems also take up a ton of space.

Yes, I know. But do you have a script to populate the sql db you can share? Thanks!

No. If I recall, many of the SATCOMP downloads were unreliable back then and I ended up retrying a lot manually at different times.


An issue inside HJBLQ class

Hello Prof. Han,
I read your DeepBSDE paper with great interest. I was focusing on understanding especially the LQGC example. I enjoyed studying your paper and learned a lot from it. Thank you for making such a nice contribution and for writing the paper so clearly.
I also appreciate the fact that you provided your code. It is so helpful! I just wanted to double-check something with you about the code in the equation.py file. Inside HJB class, I understand that the f function for that case should be -\lambda*||\nabla u||^2. So inside the code, you have written -self.lambd * tf.reduce_sum(tf.square(z), 1, keepdims=True) where z is used to denote \nabla u.
However, inside solver.py and also in the paper you use z to denote \sigma^T *\nabla u. It seems that z is used to denote both \nabla u and \sigma^T *\nabla u in that case. Is this accurate? If so, to resolve this issue, should we multiply the expression inside f_tf for HJBLQ class by 0.5 and write it as  -self.lambd * tf.reduce_sum(tf.square(z), 1, keepdims=True)*0.5?
I just wanted to double-check if I am confused or there may be a typo in the code. Would you mind letting me know? Thank you very much!

Hi, your understanding is absolutely correct. There should be a factor 0.5 in the f_tf, coming from sigma = sqrt(2). Thanks for pointing it out. The bug may be introduced when I refactored the code. I will double-check and fix it.

Thank you very much for reply!


Mobile text message rendering

The various states are all working. Not going to worry about message wrapping yet -- will look into that next w/ markup formatting.

:eyeglasses: @keybase/react-hackers

The commits ea373fcd7ac9...222eaed75d9e introduce visual changes on linux. :mag_right: 2 new, 7 changed

Added: Text_Message-edited

Added: Stacked_Text_Message-Stacked_two_messages_one_edited

Changed: Text_Message-failed_You (before) (after)

Changed: Text_Message-failed_Not_Following (before) (after)

Changed: Text_Message-failed_Following (before) (after)

Changed: Text_Message-failed_Broken (before) (after)

Changed: Stacked_Text_Message-Stacked_one_sent_one_failed (before) (after)

Changed: Attachment_Message-Basic_Preview_Image_Failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Generic_File_Failed (before) (after) (diff)

The commits ebf7e3e6678c...082a30cd655a introduce visual changes on linux. :mag_right: 2 new, 7 changed

Added: Text_Message-edited

Added: Stacked_Text_Message-Stacked_two_messages_one_edited

Changed: Text_Message-failed_You (before) (after)

Changed: Text_Message-failed_Not_Following (before) (after)

Changed: Text_Message-failed_Following (before) (after)

Changed: Text_Message-failed_Broken (before) (after)

Changed: Stacked_Text_Message-Stacked_one_sent_one_failed (before) (after)

Changed: Attachment_Message-Basic_Preview_Image_Failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Generic_File_Failed (before) (after) (diff)

The commits e9038c9d12bb...f3f82377d21c introduce visual changes on linux. :mag_right: 2 new, 7 changed

Added: Text_Message-edited

Added: Stacked_Text_Message-Stacked_two_messages_one_edited

Changed: Text_Message-failed_You (before) (after)

Changed: Text_Message-failed_Not_Following (before) (after)

Changed: Text_Message-failed_Following (before) (after)

Changed: Text_Message-failed_Broken (before) (after)

Changed: Stacked_Text_Message-Stacked_one_sent_one_failed (before) (after)

Changed: Attachment_Message-Basic_Preview_Image_Failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Generic_File_Failed (before) (after) (diff)

any idea why you still have the desktop visdiff?

@chrisnojima aha, this is due to switching the retry component to flex. Will look at an alternative or add back the margins.

The commits a7614ea9c19e...c275312e2ce4 introduce visual changes on linux. :mag_right: 3 new, 7 changed

Added: Text_Message-first_new_message

Added: Text_Message-edited

Added: Stacked_Text_Message-Stacked_two_messages_one_edited

Changed: Text_Message-failed_You (before) (after)

Changed: Text_Message-failed_Not_Following (before) (after)

Changed: Text_Message-failed_Following (before) (after)

Changed: Text_Message-failed_Broken (before) (after)

Changed: Stacked_Text_Message-Stacked_one_sent_one_failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Preview_Image_Failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Generic_File_Failed (before) (after) (diff)

@chrisnojima This is ready for further review. I fixed the original visdiff, but there's still a one-pixel discrepancy. On desktop, this is the height of the retry line changing from 17px to 16px. I think the new, 16px height is more correct.

The commits 775b77b3ccad...4ca857405c77 introduce visual changes on linux. :mag_right: 3 new, 7 changed

Added: Text_Message-first_new_message

Added: Text_Message-edited

Added: Stacked_Text_Message-Stacked_two_messages_one_edited

Changed: Text_Message-failed_You (before) (after)

Changed: Text_Message-failed_Not_Following (before) (after)

Changed: Text_Message-failed_Following (before) (after)

Changed: Text_Message-failed_Broken (before) (after)

Changed: Stacked_Text_Message-Stacked_one_sent_one_failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Preview_Image_Failed (before) (after) (diff)
Changed: Attachment_Message-Basic_Generic_File_Failed (before) (after) (diff)


Swift 3 Migration

Hi guys,
I use MapboxDirections in my app (https://itunes.apple.com/ie/app/bikey/id1048962300?mt=8).
I am migrating my app to Swift 3 in preparation for it's GA release and was wondering what the plans are with MapboxDirections.swift.
Do you guys have plans to get a Swift 3 branch up and running?
I would also love to contribute, so if you guys don't have plans to do this right now, I could definitely help out with this.
Best,
Pete

This is currently blocked by raphaelmor/Polyline#31, but a PR in the meantime for this library would be greatly appreciated.

Hey @1ec5, it looks like I don't have push access writes. I would like to push my WIP swift3 branch. Could you give me access please.

Added you as a collaborator, @superpeteblaze. Thanks!

Awesome @1ec5, thanks!

Hey @1ec5, I tried to push to repo but it looks like I still don't have access. As a test, I attempted to open the readme for editing on github to check my access and I get 'You’re editing a file in a project you don’t have write access to.'
Can you check my access settings again?

@superpeteblaze, GitHub says you have an outstanding invitation. I think you’ll be able to push once you accept it.

Oh man, sorry about that @1ec5, must have missed a notification. Thanks man

Hi guys,
What about Swift 3
When will release?

@anatoliykant There is already a Swift 3 branch. Just point your podfile to it as follows;
pod 'MapboxDirections.swift', :git => 'https://github.com/mapbox/MapboxDirections.swift.git', :branch => 'swift3'

Thanks a lot!!!
What's about mapbox ios sdk?
Have you plans to re-write them in swift3?

Be sure to follow #64 to find out when the Swift 3 branch gets merged to master.

What's about mapbox ios sdk?
Have you plans to re-write them in swift3?

The Mapbox iOS SDK’s public interface is written in Objective-C, which automatically bridges to whatever version of Swift you happen to be using.
For the time being, we have no plans to rewrite the SDK in Swift. The vast majority of the SDK is written in cross-platform C++, with a layer of Objective-C++ to bridge to the public Objective-C interface. Swift lacks support for C++ bridging. If C++ interoperability is added to Swift in the future, we’ll definitely take a rewrite into consideration.
In the meantime, if there are any pain points for working with the SDK in Swift, please raise them at the mapbox/mapbox-gl-native repository. It’s conceivable that we might provide a CocoaPods subspec with some Swift helpers the way OHHTTPStubs does.

Thank you.

#64 landed, so the master branch is written in Swift 3, and so will the next release. Thanks to @superpeteblaze @Eldorado234 for helping with this migration, and to everyone for their patience.
If you specified swift3 in your Podfile or Cartfile, please see the important note in https://github.com/mapbox/MapboxDirections.swift/pull/64#issuecomment-280970725.


chore(main): release 1.5.1

:robot: I have created a release beep boop
1.5.1 (2024-03-07)
Bug Fixes

Domain status output (47ae43b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pythoninthegrass/gopappy/releases/tag/v1.5.1 :sunflower:


Update Nerdbank.GitVersioning

The new version may work on Travis CI.
If it works, we can close https://github.com/dotnet/Nerdbank.GitVersioning/issues/368

@mhutch I guess Travis CI isn't running on this PR. Would you care to test it yourself, or is Azure Pipelines all you need to work nowadays?

@AArnott thansk for the followup! These days I'm pretty much only using GitHub Actions,  GitVersioning works great there - I'd suggest you close the issue unless someone else can repro.


Added Object.id as part of response

Added the ID in the responses with filters.
Added test to validate responses.

Commited


Error when trying to generate wrapped npm module

Firstly I think this tool has great potential.
I am trying to create a new generator to include a wrapped npm module called react-facebook-login.
I have been trying various things to get this to work. There is an old version in the market place under Generics/Wrappers/FaceBookLogin which i created and have been trying to .modify to get to work.
The npm module has 3 directories under the root with the following files.
dist
facebook-login.js
src
facebook.js
index.js
styles
facebook.scss
The docs describe a sample.
'use strict';
import React from 'react';
import FacebookLogin from 'react-facebook-login';
class MyComponent extends React.Component {
constructor(props) {
super(props);
};
responseFacebook = (response) => {
console.log(response);
};
render() {
return (

)
}
}
export default MyComponent;
Which i changed to:
import React, { Component, PropTypes } from 'react';
import FacebookLogin from 'react-facebook-login';
class <%= componentName %> extends Component {
constructor(props) {
super(props);
};
responseFacebook = (response) => {
console.log(response);
};
render() {
return (

)
}
}
export default <%= componentName %>;
I created the structor dependancies as follows:
{
"packages": [
{
"name": "react-facebook-login",
"version": "",
"copy": [
{
"from": "dist/facebook-login.js",
"to": "react-facebook-login/dist/facebook-login.js",
"isImport": true
},
{
"from": "styles/facebook.scss",
"to": "react-facebook-login/styles/facebook.scss",
"isImport": true
},
{
"from": "src/facebook.js",
"to": "react-facebook-login/src/facebook.js",
"isImport": true
}
]
}
]
}
when i try and save and generate the preview i get the following errors in a popup box:

Can you help me understand what I am doing wrong.
many thanks
Peter

@rodenp I apologise for a long delay. I made a new release of Structor with now is integrated with react-boilerplate project. From now Structor will be installed as a tool for react-boilerplate - it is adopted to the boilerplate's source code structure and has many other coupling points.
From now Structor's projects should be cloned from React Boilerplate project. Thats why for your convenience I created a fork of react-boilerplate repo and made some changes in it for the Structor compatibility. Please find this fork here: https://github.com/ipselon/react-boilerplate
Unfortunately, there is no the ability to publish own generators so far. But I'm intensively working on this feature and it will be more convenient than it is in the previous versions of Structor.
I'll try to migrate your generator into React Boilerplate project and will give you a notice when it will be available on Structor Market.

Hi Alex,
I really like the passion and commitment you have towards structor.
What would really help is more examples and more documentation about generators and how to use the template versions as well as create brand new ones.
What would especially help is more details on creating npm wrappers. I am confused about npm modules that have multiple directories.
Could you give me some guidance on getting the facebooklogin generator to work?
RegardsPeter
Get Outlook for iOS
	_____________________________

From: Alex Pustovalov<EMAIL_ADDRESS>Sent: Saturday, September 3, 2016 4:27 PM
Subject: Re: [ipselon/structor] Error when trying to generate wrapped npm module (#69)
To: ipselon/structor<EMAIL_ADDRESS>Cc: Mention<EMAIL_ADDRESS>rodenp<EMAIL_ADDRESS>@rodenp I apologise for a long delay. I made a new release of Structor with now is integrated with react-boilerplate project. From now Structor will be installed as a tool for react-boilerplate - it is adopted to the boilerplate's source code structure and has many other coupling points.
From now Structor's projects should be cloned from React Boilerplate project. Thats why for your convenience I created a fork of react-boilerplate repo and made some changes in it for the Structor compatibility. Please find this fork here: https://github.com/ipselon/react-boilerplate
Unfortunately, there is no the ability to publish own generators so far. But I'm intensively working on this feature and it will be more convenient than it is in the previous versions of Structor.
I'll try to migrate your generator into React Boilerplate project and will give you a notice when it will be available on Structor Market.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@rodenp I'm closing this issue - now there is a guide which covers a majority of what Structor can.


Create document that describes how to fix Did not find functions with language [node]

We do not have any public documentation that describes how to fix this error. After we have this new doc, we will create an aka link and update the error message to redirect the user to this new doc.
Below is an answer on how to fix this issue from ChatGPT:
The error message "Did not find functions with language [node]" typically occurs when there is an issue with the programming environment or the Node.js installation. Here are a few steps you can take to fix this error:

Verify Node.js installation: Make sure Node.js is correctly installed on your system and the installation directory is added to the system's PATH variable. You can check the Node.js installation by opening a command prompt or terminal and typing node --version. If Node.js is not recognized, you may need to reinstall it or adjust the system's PATH variable.

Confirm Node.js version: Ensure that you're using a compatible version of Node.js for the code you're trying to run. If the code requires a specific Node.js version, verify that it's installed and active.

Check programming environment: If you're using an integrated development environment (IDE) or code editor, ensure that it's properly configured to recognize and execute Node.js code. Some IDEs may require additional setup or extensions to work with Node.js.

Update packages: If you're using any Node.js packages or libraries, make sure they are installed and up to date. You can use the npm package manager to install or update packages. For example, npm install packageName installs a package, and npm update packageName updates an existing package.

Restart the environment: Sometimes, restarting your programming environment or terminal can resolve temporary issues. Close and reopen your IDE or command prompt and try running the code again.

Verify code syntax: Double-check your code for any syntax errors or typos that could be causing the issue. Ensure that you're using correct Node.js syntax and that all required functions are defined.

Review documentation and community resources: If none of the above steps resolve the issue, consult the documentation or online forums specific to the programming environment or libraries you're using. Others may have encountered similar problems and found solutions.

By following these steps, you should be able to troubleshoot and fix the "Did not find functions with language [node]" error.
Could you please add any information that might be missing and remove anything that is incorrect? Thank you.

We added a general Node.js troubleshooting guide: https://learn.microsoft.com/en-us/azure/azure-functions/functions-node-troubleshoot
We plan to continue improving that guide, but I think we can close this particular issue.


Documentation / script updates

Regarding the moiunting issue, you can see from mount propogation, that you
need to set the `containers[*].volumeMount` with the additional field
`mountPropagation=Bidirectional`, a typical case when a pod needs to mount a
hostpath volumn.
I tried this, but the container was not set with the proper securityContext,
and I couldn’t get that to work properly, the instructions for a
securityContext aren’t working as I expected.


Exception on sending any message

I tried with multiple oobabooga commits with any configuration and i always get this exception once i sent a message in telegram to the bot
user_text hi
generate_answer 'NoneType' object has no attribute 'encode'
cannot unpack non-iterable NoneType object
Exception in thread Thread-5 (thread_get_message):
Traceback (most recent call last):
  File "/home/-/Git/oobabooga_linux/installer_files/env/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/home/-/Git/oobabooga_linux/installer_files/env/lib/python3.10/threading.py", line 953, in run
    self._target(*self._args, **self._kwargs)
  File "/home/-/Git/oobabooga_linux/text-generation-webui/extensions/telegram_bot/TelegramBotWrapper.py", line 765, in thread_get_message
    raise e
  File "/home/-/Git/oobabooga_linux/text-generation-webui/extensions/telegram_bot/TelegramBotWrapper.py", line 746, in thread_get_message
    answer, system_message = self.generate_answer(
TypeError: cannot unpack non-iterable NoneType object

Just updated oobabooga via shell script, but bot still work.
Will do clear reinstall when got fast internet connection)
p.s. try to change in telegram_config.json:
"generator_script": "GeneratorTextGeneratorWebuiApi"
and run oobabooga  with --api.
This force telegram_bot interact with oobabooga via API, perhaps will help.
let me know if api mode help)

I just made clear install of oobaboba and telegram_bot but I can't repeat your bug.
I am using llama7b4bit model and flags:
"--chat --gpu-memory 6 --cpu-memory 6 --model llama7b4bit --sdp-attention --api --extensions telegram_bot"
Can you share details about you command flags and config? I see you are not alone with this bug https://github.com/innightwolfsleep/text-generation-webui-telegram_bot/issues/121

Hey thanks for your response but like one day later it suddenly worked again. I noticed though that this error also comes up as soon as you text the bot without having a model loaded. (I had a model loaded when i had this issue though) still thank you for your effort in helping me!


LF emails can't be parsed anymore

removed in #1113 / master branch
I have many eml files in my specs with just LF separator, that passes on 2.6.6 stable
HEADER
LFLF
BODY

when normalization was removed, header separator doesn't work with it anymore, the parser thinks that the whole email is a header which is wrong.
HEADER_SEPARATOR = /#{CRLF}#{CRLF}/

according to the RFC, header separator should be always 2x CRLF
https://www.ietf.org/rfc/rfc2822.txt
so my question is, should eml files with just LF separators be parsable or not?
It doesn't comply with RFC, but standard mail clients like Outlook or Thunderbird can open and work with these files just fine. It also used to work with mail 2.6.6.

Yep, looking at supporting this before release. Correctness first!
Some related discussion on the commit: https://github.com/mikel/mail/commit/21222e1b48f08f6f848d26643d6b6fb1d873d18c#commitcomment-22366140

great, thanks!


Closing current window by clicking on the xwindow module

Is your feature request related to a problem? Please describe.
I use i3 without window borders to save on-screen space, which means there are no clickable buttons for closing, maximizing etc.. In most cases, I don’t miss these buttons, but sometimes, when I use a mouse driven-application, it may show a window that has no other way of closing it with the mouse.
Why does polybar need this feature?
If the xwindow module had the feature of closing the window currently in focus by clicking on the module, I wouldn’t need to reach for the keyboard just for closing the window without borders.
Describe the solution you'd like
The user clicks on the xwindow module and then the window whose title it displayed closes. This could be made optional by a setting such as
close-on-click = true

Describe alternatives you've considered
I could write a bash script for doing what the module already does and what I’m proposing, although using that might be more resource hungry, especially if I wanted it to query the window title every few milliseconds.
Also, in the past I’ve tried mapping one of my extra mouse buttons to a script that would close the current window, but it didn’t always work for some reason.

I don't think this feature is necessary. You can already use action tags with a command (or script) that kills the current window to create a clickable area in your xwindow module.

Thank you for the advice! I could do it by modifying the polybar config as follows (I’m including this in case anyone else happens to be looking for the same solution):
[module/xwindow]
label = %{A1:xdotool getwindowfocus windowkill:}%title:0:30:...%%{A}

Thank you for the advice! I could do it by modifying the polybar config as follows (I’m including this in case anyone else happens to be looking for the same solution):
[module/xwindow]
label = %{A1:xdotool getwindowfocus windowkill:}%title:0:30:...%%{A}

Hello I've followed your advice but I'm experiencing the bar freezing after I press the text. Have you or anybody else that is reading this experienced something similar and if that is the case how do I solve it.
Thank for reading.

@MiguelRodrii I've never experienced anything like that, at least not because of this.
In any case, here's what I've been using for almost a year. I've customised it further for my personal needs.
[module/xwindow]
; Label with mouse actions (A1: left click; A2: middle click; A3: right click)
label = %{A1:i3-msg floating toggle:}%{A2:xdotool getwindowfocus windowkill:}%{A3:i3-msg move scratchpad:}%title:0:30:...%%{A}%{A}%{A}

@MiguelRodrii Are you using an old version of polybar? Before 3.5.0 polybar could freeze while a click command was running.

@MiguelRodrii Are you using an old version of polybar? Before 3.5.0 polybar could freeze while a click command was running.

Well after a while trying to figure out what was the cause it seems like xfwm somehow doesn't works well with what I'm trying to do. I'm currently trying to move my workflow to openbox where everything works fine.
I would also like to report the bug to the xfwm team but I don't know how to elaborate the report because it's so specific.
Thanks for your response btw haha ^^.


Update cli-using-understanding-core-command-groups.md

fix broken link at Understanding core command groups
Working https://docs.zowe.org/stable/user-guide/cli-using-displaying-help
Broken: https://docs.zowe.org/stable/user-guide/cli-using-understanding-core-command-groups/cli-using-displaying-help

Hi jb,
Thanks for approving my first issue request!
It must have been since the most recent merge because it wasn’t working for
me on the official docs site on the day I submitted the issue. All seems to
be working now though (-:
Cheers,
cng008
On Mon, Aug 22, 2022 at 6:32 AM JamesBauman @.***>
wrote:

Hello @cng008 https://github.com/cng008 -
In what version of the docs site was this issue discovered? In the current
release, the link is not broken:
https://docs.zowe.org/stable/user-guide/cli-using-understanding-core-command-groups
Try it!
Unless i am missing something :)
Please advise...
thx,
jb
—
Reply to this email directly, view it on GitHub
https://github.com/zowe/docs-site/pull/2359#issuecomment-1222369664, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWEGGV2C7TVXCDPUWZSGX7TV2N6P3ANCNFSM566VWYMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
http://christienng.com/
christien ng
e: @.***
m: +1<PHONE_NUMBER>

@cng008
Hi Christian - thank you for reporting the error!  Congrats on your first contribution!
After you submit PR, we have github automation that generates a Deploy preview build so that you can review your changes. The link is contained in the Checks section of the PR (when it is still open). Just click the link to review your changes.
Thanks again!
PS: I got weird behavior testing the link in the live site.  In Chrome and FF, I got the 404 error, but not in Edge.  I cleared my Edge cache and was finally able to confirm the issue that you detected.


Update the doc AAD use only HTTP GET for logout response now

[Enter feedback here]
AAD doesn't support HTTP POST when sending logout response use only HTTP GET now.
Can you please update this doc mentioning this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76d4eac0-25d3-b5d5-f58e-cdd1024f32b4
Version Independent ID: 7771f280-3701-4f88-cb9f-add968d494de
Content: Azure Single Sign Out SAML Protocol
Content Source: articles/active-directory/develop/single-sign-out-saml-protocol.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@Melody-Fu Thank you for catching this. We will review with the content team and have this updated.

@rwike77  Can you please look into this ?

@Melody-Fu  thanks for the feedback, you are correct.  I've submitted a doc update.  #please-close


Northstar dll crash when not supplying atleast semi valid rpak.json

To reproduce:
put rpaks in rpaks folder of mod, don't put json file in.
can be circumvented with a rpak.json file that isn't even valid like:
{
    "Preload":
    {
        "example.rpak": false
    }
}

(yes, it doesn't care about if that rpak even exists, putting this in resolves the crash)

henlo frens! i would like to request to reserve this issue for myself, id like to try and fix this if possible :)
was looking at the code rn because this issue once again happened to me today on accident and it seems like the fix could be simple.

Closed by #762


Fastlane checks for playstore descriptions

Fastlane checks for playstore descriptions

Why should we run this on master?

no reason, and not very useful. closing.


Added support for setting center of rotation

Uses the css 'transform-origin' to set the center of rotation.

Two minor requests:

Please remove the comments with your name in - git makes those superfluous :-)
Can you also include an update to the README.md to document how to use your new functionality?

Thanks
~gwh

Closing pull request. Please re-open if you have time to make requested modifications.

Hi, sorry I forgot completely to do the changes you requested. :O Now fixed.

Great! I'll reopen the pull request and you can commit the new changes.

No idea how to do that! There is some 'pull request', but it says it can be done by 'project collaborators'..
 Den torsdag, 21 maj 2015 16:47 skrev godswearhats<EMAIL_ADDRESS>
Great! I'll reopen the pull request and you can commit the new changes. —
Reply to this email directly or view it on GitHub.


ManagedContext.insertObjects: misleading new transaction

Related to #571 but could be changed independently from it:
ManagedContext.insertObjects creates a new transaction to insert all objects in that newly created transaction. Unfortunately when creating a new transaction outside this method for other purposes using context.transaction((transaction) {}) the transaction object given as a parameter to transactionBlock is a ManagedContext object as well. Calling transaction.insertObjects() then leads to the misleading assumption that it would insert all the objects within the same transaction but instead it creates a new transaction. If an error occurs in the transaction block the insert operations that were performed in the separate transaction block within insertObjects are NOT being rolled back.
Suggestion: a) don't create a separate transaction in ManagedContext.insertObjects(). b) Instead use a new Query.insert method as proposed in #571 which would allow for bulk inserts and let the user decide which operations belong to which transaction. a) does not require b).
There is code for establishing a parent child relationship when creating a transaction. Apparently this does not have an effect on the child transaction when an error occurs in the parent transaction. I used an insert operation to test this. Looking at the database I can see the rows being inserted within the child transaction even though the parent transaction threw an exception. (I did not check for rows of the parent transaction if an error would occur in a child transaction).

My apologies for not seeing this earlier. I agree that the current implementation of insertObjects is poor (it is also slow) and that #571 will resolve it.
In your last paragraph, are you identifying an issue whereby nested transactions do not behave as expected?


fix: typescript interface variable assignment

Fixed an issue where a constant in an interface model type would try to assign a value to the variable, which resulted in invalid TypeScript. Tested with both class and interface modeltypes. Issue described in comments of #1471

@Samridhi-98 when you have a moment to review 😄

@Samridhi-98 when you have a moment to review 😄

/rtm

@all-contributors please add @Ksisa for code


Look up for all folders in downloaded package

Pre-review checklist

[x] I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
[x] I've added or updated automated unit tests to verify correctness of my new code.
[ ] I've added or updated integration tests to verify correctness of my new code.
[x] I've confirmed that my changes are working by executing CLI's commands manually.
[x] I've confirmed that my changes are up-to-date with the target branch.
[ ] I've described my changes in the release notes.
[ ] I've described my changes in the section below.

Changes description
Closes #555
We want to create a package with azure-eventhub (as it's not available in SF Anaconda channel).
Here is the log (don't pay attention to root user as I ran it in Docker): package-azure-eventhub.txt
Notice the following line in logs:
Package azure-core: deleting 2 files
SnowCLI actually deletes now only azure-core (because it's available in SF Anaconda) but also azure-eventhub.
After investigation I found that error lies in get_downloaded_packages function in src/snowcli/utils.py:
record_entries = list(
    {
        line.split("/")[0].split(",")[0]
        for line in record_file.readlines()
    },
)

Notice that the code above iterates over installed files (in a package) and picks up only top-level folders from it. The problem is that azure-core is installed in azure/core while azure-eventhub is installed in azure/eventhub. The top-level folder for both packages is the same: azure. So while deleting azure-core package (because it's available in SF Anaconda) SnowCLI also deletes azure/eventhub.

@kokorin Thanks for your contribution!
I'll finish the review of this PR tomorrow but it looks really good to me.
Don't worry about failed integration tests. We don't run them yet on PRs from external contributors but I will run them manually on your code.

@kokorin
Nice work! I ran integration and e2e tests manually and everything's ok.
I'd like to merge the PR but I need you to fix the formatting of txt files which you have added.
"Check linting" failure: https://github.com/Snowflake-Labs/snowcli/actions/runs/6961025962/job/18941766943?pr=556
It should be checked and fixed automatically before the commit if you have installed precommit like described here. I suggest to do it this way instead of fixing formatting manually.

Done


cdk nag suppression error in cdk pipelines

Describe the bug
Error: Suppression path "/controlplane-stack/AWS679f53fac002430cb0da5b1234567/ServiceRole/Resource" did not match any resource. This can occur when a resource does not exist or if a suppression is applied before a resource is created.
Expected Behavior
sbt control plane deploys in a stack from cdk pipelines
Current Behavior
when i run cdk synth it will throw an error. when sbt resources are commented out, it will synth successfully.
Reproduction Steps
none
Possible Solution
remove cdk nag and let users of SBT apply nag rules to the resources deployed from the construct
Additional Information/Context
this is a known issue and i've followed these instructions as well:
https://constructs.dev/packages/cdk-nag/v/2.27.136?lang=typescript#suppressing-awscdklibpipelines-violations
https://github.com/cdklabs/cdk-nag/issues/1726
CDK CLI Version
2.151.0
Framework Version
No response
Node.js Version
18
OS
macos
Language
TypeScript
Language Version
No response
Other information
No response

Thanks for reporting this. Can you share steps to reproduce this?
I've tried synthesizing both control-plane and app-plane constructs, but couldn't find the AWS679f53fac002430cb0da5b1234567 resource in either of the resulting CFN templates.

Hi, @suhussai thanks for taking a look, the problem is when you add any sbt resources in stack that's deployed in a stage from a cdk pipeline. Since SBT is using cdk nag under the hood of the construct, it appears the cdk pipelines can't synth the resources because it errors out due to the error in the nag rule.
This is very limiting especially for multi-account and multi environment deployments.
`// ./lib/cdktest-stack.ts
import * as cdk from "aws-cdk-lib";
import { Construct } from "constructs";
import * as sbt from '@cdklabs/sbt-aws';
export class CdktestStack extends cdk.Stack {
constructor(scope: Construct, id: string, props?: cdk.StackProps) {
super(scope, id, props);
const cognitoAuth = new sbt.CognitoAuth(this, 'CognitoAuth', {
  setAPIGWScopes: false,
});

const controlPlane = new sbt.ControlPlane(this, 'ControlPlane', {
  auth: cognitoAuth,
  systemAdminEmail: 'ENTER YOUR EMAIL HERE',
});

}
}
// ./lib/cdktest-stage.ts
import * as cdk from "aws-cdk-lib";
import { Construct } from "constructs";
import { CdktestStack } from "./cdktest-stack";
export class CdkTestStage extends cdk.Stage {
constructor(scope: Construct, id: string, props: cdk.StageProps) {
super(scope, id, props);
new CdktestStack(this, "cdk-test-stack");
}
}
// ./lib/pipeline.ts
import * as cdk from "aws-cdk-lib";
import { Construct } from "constructs";
import * as pipeline from "aws-cdk-lib/pipelines";
import { CdkTestStage } from "./cdktest-stage";
export class PipelineStack extends cdk.Stack {
constructor(scope: Construct, id: string, props: cdk.StackProps) {
super(scope, id, props);
const synthBuildStep = new pipeline.CodeBuildStep("Synth", {
  input: sourceCodeCommit,
  installCommands: ["npm install -g aws-cdk"],
  commands: [],
  primaryOutputDirectory: "pipeline/cdk.out",
});

//Pipeline de base
const pipelineInfra = new pipeline.CodePipeline(this, "pipelineInfra", {
  synth: synthBuildStep,
});

pipelineInfra.addStage(new CdkTestStage(this, "cdk-test-stage", props));

pipelineInfra.buildPipeline();

}
}
// bin/main.ts
#!/usr/bin/env node
import "source-map-support/register";
import * as cdk from "aws-cdk-lib";
import { AwsSolutionsChecks } from "cdk-nag";
import { PipelineStack } from "../lib/pipeline";
const app = new cdk.App();
new PipelineStack(app, "PipelineStack", {
env: {
region: "us-east-1",
account: "111111111",
},
});
cdk.Aspects.of(app).add(new AwsSolutionsChecks());`

Thanks for listing out the steps.
When I synth the cdk app you described above, I got a similar error, but it was referring to a different resource:
Error: Suppression path "/cdk-test-stage-cdk-test-stack/AWS679f53fac002430cb0da5b7982bd2287/ServiceRole/Resource" did not match any resource. This can occur when a resource does not exist or if a suppression is applied before a resource is created.
    at .../node_modules/cdk-nag/src/nag-suppressions.ts:115:15
    at Array.forEach (<anonymous>)
    at Function.addResourceSuppressionsByPath (.../node_modules/cdk-nag/src/nag-suppressions.ts:98:15)
    at new CognitoAuth (.../src/control-plane/auth/cognito-auth.ts:482:23)
    at new CdktestStack (.../lib/cdktest-stack.ts:9:25)
    at new CdkTestStage (.../lib/cdktest-stage.ts:8:5)
    at new PipelineStack (.../lib/pipeline.ts:22:28)
    at Object.<anonymous> (.../bin/main.ts:20:1)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module.m._compile (.../node_modules/ts-node/src/index.ts:1618:23)

Can you paste the entire the error? I'd like to see where in the SBT code that NagSuppression exists that is causing the error in your example.
Assuming that's just a minor thing, I looked at different ways to solve this like enclosing the problematic NagSuppression in a condition to first check if the resource in question (AWS679f53fac002430cb0da5b7982bd2287) even exists:
    if (cdk.Stack.of(this).node.tryFindChild('AWS679f53fac002430cb0da5b7982bd2287')) {
      // https://github.com/aws/aws-cdk/issues/23204
      NagSuppressions.addResourceSuppressionsByPath(
        cdk.Stack.of(this),
        [
          `/${cdk.Stack.of(this).stackName}/AWS679f53fac002430cb0da5b7982bd2287/ServiceRole/Resource`,
          `/${cdk.Stack.of(this).stackName}/AWS679f53fac002430cb0da5b7982bd2287/Resource`,
        ],
        [
          {
            id: 'AwsSolutions-IAM4',
            reason: 'Suppress usage of AWSLambdaBasicExecutionRole.',
            appliesTo: [
              'Policy::arn:<AWS::Partition>:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole',
            ],
          },
          {
            id: 'AwsSolutions-L1',
            reason: 'NODEJS 18 is the version used in the official quickstart CFN template.',
          },
        ]
      );
    }

Unfortunately, that still didn't work, which is confusing because the NagSuppression shouldn't apply unless that resource exists, but for some reason it does apply, but then it throws an error saying that the related ServiceRole/Resource resource does not exist.
I also tried upgrading the cdk-nag and cdk versions to make sure they weren't the issue, but that didn't help.
Given this, I think a simple (but not ideal) solution that should fix this is to use a flag to disable the problematic NagSuppression. It can be a boolean called runAsStage and if it is set, we skip creating that specific NagSuppression in the cognito-auth.ts file, as all of the other ones work fine.
@tobuck-aws , do you have any thoughts here?

I updated the NagSuppression as part of this PR #90 and when I tested it using the template you sent, the error did not show up.
I'll try and get it merged today. If you have a minute, can you confirm whether the fix worked for you when we've merged it in?

Auto-closed.
Reopening until we get confirmation that the issue has been resolved.

@suhussai that worked! Thank you very much! This will be very helpful for multi-account deployments!

Thanks for the feedback and for closing the loop on this. Glad it worked out!


Comments

Syntax: %* comment stuff here *%
Put it in TemplateFragmentExt and then discard it

done in latest (uncommited) changes


View Secret Key title and text styles

1a. Add back arrow to title. You can find the component for titles with a back arrow here: https://www.figma.com/file/8CaxP6TRWskoTO9cmlvX9M/📐Connect?node-id=231%3A8212
1b. Title font size: H4, which is Open Sauce at 24px
1c. Hide menu icon, also not sure we need the testnet indicator here (?)
2. I'd make this copy C1 (14px) so it takes up less space. That way the secret key and buttons are visible.
3. Same as above

This appears resolved


Make getContent to be static

This allow conversion of content state without using BraftEditor

@margox let me know if this is okay

This is combinator of pr #161  and static changes


Create Krish-PR1.md

Added a PR that hasn't been merged. I would appreciate it if you could help.
This is a level 2 PR.
PR LINK: https://github.com/PriyaGhosal/BuddyTrail/pull/1842
Thank you!

its level1 as mentioned in the issue


HyperOS QUERY_ALL_PACKAGES permission is denied by default

Steps to reproduce
On HyperOS, the system seems to deny the QUERY_ALL_PACKAGES permission by default and requires the user to navigate through the app settings for several layers to find this advanced permission and to grant it.

Expected behavior
QUERY_ALL_PACKAGES should be granted by the user manually or the system automatically.
Actual behavior
Permission is denied by default with no prompt to grant it. This causes the extension list to be empty on app restart.
Crash logs
No response
Mihon version
0.16.4
Android version
HyperOS
Device
Xiaomi phones with HyperOS
Other details
If possible, Mihon should ask for this permission during the Onboarding flow, or when it detects failure of a package scan on the installed extensions screen.
If not possible, it has to be mentioned somewhere (Onboarding? Website? Support-FAQ thread?) that this is something users have to consider and grant manually.
Proposed command/hint/website entry:
How to fix empty installed extensions list / disappearing extensions on HyperOS:
App info for Mihon > Permissions > Other Permissions > Access List of Installed Apps > Always Allow

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.4.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Update: I myself am using HyperOS <IP_ADDRESS> now and I cannot see half the options this user had on their phone. Will contact them again to provide OS version info.

Update: Another user with HyperOS has reported an issue that ended up being solved by granting:
App Info > Permissions > Other Permissions > Access list of installed apps
(which is what the previous demo video also showed).
Their phone uses the India region version of HyperOS, while mine uses the Global one. It appears that this permission is only available on certain regional variants of HyperOS.

Chinese version of HyperOS has implemented this Mobile terminal application list permission implementation guide. It requires developer to request com.android.permission.GET_INSTALLED_APPS permission dynamically just like requesting READ_EXTERNAL_STORAGE.
If no actual implement action were taken, QUERY_ALL_PACKAGES might be ignored by HyperOS.


Multi stage stats

At this moment this PR is a draft where I'm trying to modify the way stats are collected and encoded in multi-stage engine.
The plan is to:

Use enums as stat keys
Collect stats per stage.

Each OpChain will collect a partial view for its stage and the stages upstream.
OpChains that receive data from more than one OpChain of the same stage will merge them.
The root stage (on the broker), where there is only one OpChain, will collect the full view.

Change the way stats are encoded. Instead of JSON we will use a binary format equal or more effective than the one used in DataTable.
Create new stats for specific multi-stage operators where it makes sense
Export these stats to broker clients

Current state:

[x] Define the StatMap that will map from enums to values.
[x] Define the encoding
[x] Define the StageStats
[x] Substitute OpChainStats with StageStats in OpChain
[x] Merge StageStats in receiving mailboxes.
[x] Return the StageStats to broker clients
[x] Create new stats for specific multi-stage operators where it makes sense
[x] Pass all tests

see https://github.com/apache/pinot/pull/12704#issuecomment-2051326915

[x] Create new tests
[x] Document new stats

Changes
Stats added

All stages:

executionTimeMs (long): clock time (in ms) spent executing this operation, including their upstreams.
emittedRows (long): number of rows emitted by this operation.

AGGREGATE:

numGroupsLimitReached (bool): if true, we have reached the max number of groups.

MAILBOX_RECEIVE:

fanIn (int): How many send mailboxes are being read by this receive operator.
inMemoryMessages (int): How many messages have been received in heap format by this mailbox.
rawMessages (int): How many messages have been received in raw format and therefore deserialized by this mailbox.
deserializedBytes (long): How many bytes have been deserialized by this mailbox.
deserializationTimeMs (long): How long (in CPU time) it took to deserialize the raw messages received by this mailbox.
downstreamWaitMs (long): How long (in CPU time) it took to offer the messages to downstream operator.
upstreamWaitMs (long): How long (in CPU time) it took to wait for the messages to be offered to downstream operator.

JOIN:

maxRowsInJoinReached (bool): if true, we have reached the max number of rows in join.
timeBuildingHashTableMs (long): How long (CPU time) has been spent on building the hash table.

MAILBOX_SEND:

stage (int): The id of the stage whose root is this operator.
fanOut (int): How many receive mailboxes are being written by this send operator.
inMemoryMessages (int): How many messages have been sent in heap format by this mailbox.
rawMessages (int): How many messages have been sent in raw format and therefore serialized by this mailbox.
serializedBytes (long): How many bytes have been serialized by this mailbox.
serializationTime (long): How long (in CPU time) it took to serialize the raw messages sent by this mailbox.

Stats that are populated now

threadCpuTimeNs and systemActivitiesCpuTimeNs, which were set in InstanceResponseOperator but only for single stage. Now StreamingInstanceResponseOperator set these properties as well.

Stats that are not populated

nettyConnectionSendResponseLatency: Doesn't make sense, given we use GRPC instead of Netty
requestDeserialization: It seems difficult to measure by table time right now
responseSerialization: It seems difficult to measure by table time right now
schedulerWait: It seems difficult to measure by table right now

Broker stats added
A new stat called maxRowsInOperator has been added.
This stat contains the max number of documents emitted by a single logical operator.
This is shown in the Pinot Console UI and it can be useful in cases where joins generate a lot of rows

Multi-stage uses this new API
In multi-stage, stats are always send in EOS
Before this change, each stage kept the stats in the context and they were only sent in the EOS block on mailbox send operators.
Stats are not serialized/deserialized in the same stage. They are also not serialized when traveling from one stage to another if they are in the same server. A future optimization would be to prioritize local receivers in send mailbox.
In multi-stage, stats are shown in tree format
For example, the query:
SELECT
	/*+  joinOptions(max_rows_in_join='10000000') */
	1
FROM baseballStats_OFFLINE as a2
  JOIN (
	select
	* from
      baseballStats_OFFLINE AS a1
      JOIN dimBaseballTeams_OFFLINE AS b
	  --on a1.teamID = b.teamID
	  on 1 = 1
  ) as c on a2.teamID = c.playerID

Generates the following json with and without tracing (click to see):
{
   "resultTable": {...},
    "rows": [...]
  },
  "requestId": "...",
  "stageStats": {
    "type": "MAILBOX_RECEIVE",
    "executionTimeMs": 342,
    "fanIn": 3,
    "rawMessages": 3,
    "deserializedBytes": 1668,
    "upstreamWaitMs": 1029,
    "children": [
      {
        "type": "MAILBOX_SEND",
        "executionTimeMs": 1022,
        "stage": 1,
        "parallelism": 3,
        "fanOut": 1,
        "rawMessages": 3,
        "children": [
          {
            "type": "TRANSFORM",
            "executionTimeMs": 1022,
            "children": [
              {
                "type": "HASH_JOIN",
                "executionTimeMs": 1022,
                "timeBuildingHashTableMs": 1002,
                "children": [
                  {
                    "type": "MAILBOX_RECEIVE",
                    "executionTimeMs": 21,
                    "emittedRows": 97889,
                    "fanIn": 1,
                    "inMemoryMessages": 11,
                    "rawMessages": 22,
                    "deserializedBytes": 287151,
                    "downstreamWaitMs": 960,
                    "upstreamWaitMs": 1030,
                    "children": [
                      {
                        "type": "MAILBOX_SEND",
                        "executionTimeMs": 883,
                        "emittedRows": 4992339,
                        "stage": 3,
                        "parallelism": 3,
                        "fanOut": 3,
                        "inMemoryMessages": 13,
                        "rawMessages": 25,
                        "serializedBytes": 13541990,
                        "serializationTimeMs": 167,
                        "children": [
                          {
                            "type": "TRANSFORM",
                            "executionTimeMs": 619,
                            "emittedRows": 4992339,
                            "children": [
                              {
                                "type": "HASH_JOIN",
                                "executionTimeMs": 469,
                                "emittedRows": 4992339,
                                "timeBuildingHashTableMs": 6,
                                "children": [
                                  {
                                    "type": "MAILBOX_RECEIVE",
                                    "executionTimeMs": 10,
                                    "emittedRows": 97889,
                                    "fanIn": 1,
                                    "inMemoryMessages": 4,
                                    "rawMessages": 9,
                                    "deserializedBytes": 448569,
                                    "deserializationTimeMs": 1,
                                    "upstreamWaitMs": 41,
                                    "children": [
                                      {
                                        "type": "MAILBOX_SEND",
                                        "emittedRows": 51,
                                        "stage": 5,
                                        "parallelism": 1,
                                        "fanOut": 3,
                                        "inMemoryMessages": 2,
                                        "rawMessages": 4,
                                        "serializedBytes": 657,
                                        "children": [
                                          {
                                            "type": "LEAF",
                                            "table": "dimBaseballTeams_OFFLINE",
                                            "executionTimeMs": 1,
                                            "emittedRows": 51,
                                            "numDocsScanned": 51,
                                            "numSegmentsQueried": 1,
                                            "numSegmentsProcessed": 1,
                                            "numSegmentsMatched": 1,
                                            "totalDocs": 51,
                                            "threadCpuTimeNs": 111660
                                          }
                                        ]
                                      }
                                    ]
                                  },
                                  {
                                    "type": "MAILBOX_RECEIVE",
                                    "executionTimeMs": 5,
                                    "emittedRows": 153,
                                    "fanIn": 1,
                                    "inMemoryMessages": 2,
                                    "rawMessages": 4,
                                    "deserializedBytes": 870,
                                    "upstreamWaitMs": 6,
                                    "children": [
                                      {
                                        "type": "MAILBOX_SEND",
                                        "executionTimeMs": 8,
                                        "emittedRows": 97889,
                                        "stage": 4,
                                        "parallelism": 1,
                                        "fanOut": 3,
                                        "inMemoryMessages": 3,
                                        "rawMessages": 9,
                                        "serializedBytes": 448333,
                                        "serializationTimeMs": 8,
                                        "children": [
                                          {
                                            "type": "LEAF",
                                            "table": "baseballStats_OFFLINE",
                                            "executionTimeMs": 14,
                                            "emittedRows": 97889,
                                            "numDocsScanned": 97889,
                                            "numEntriesScannedPostFilter": 97889,
                                            "numSegmentsQueried": 1,
                                            "numSegmentsProcessed": 1,
                                            "numSegmentsMatched": 1,
                                            "totalDocs": 97889,
                                            "threadCpuTimeNs": 11355810
                                          }
                                        ]
                                      }
                                    ]
                                  }
                                ]
                              }
                            ]
                          }
                        ]
                      }
                    ]
                  },
                  {
                    "type": "MAILBOX_RECEIVE",
                    "executionTimeMs": 611,
                    "emittedRows": 4992339,
                    "fanIn": 3,
                    "inMemoryMessages": 13,
                    "rawMessages": 26,
                    "deserializedBytes": 13542792,
                    "deserializationTimeMs": 2,
                    "upstreamWaitMs": 2667,
                    "children": [
                      {
                        "type": "MAILBOX_SEND",
                        "executionTimeMs": 336,
                        "emittedRows": 97889,
                        "stage": 2,
                        "parallelism": 1,
                        "fanOut": 3,
                        "inMemoryMessages": 10,
                        "rawMessages": 21,
                        "serializedBytes": 286843,
                        "serializationTimeMs": 6,
                        "children": [
                          {
                            "type": "LEAF",
                            "table": "baseballStats_OFFLINE",
                            "executionTimeMs": 78,
                            "emittedRows": 97889,
                            "numDocsScanned": 97889,
                            "numEntriesScannedPostFilter": 97889,
                            "numSegmentsQueried": 1,
                            "numSegmentsProcessed": 1,
                            "numSegmentsMatched": 1,
                            "totalDocs": 97889,
                            "threadCpuTimeNs": 24490,
                            "systemActivitiesCpuTimeNs": 740
                          }
                        ]
                      }
                    ]
                  }
                ]
              }
            ]
          }
        ]
      }
    ]
  }
}

Codecov Report
Attention: Patch coverage is 65.53156% with 415 lines in your changes are missing coverage. Please review.

Project coverage is 61.70%. Comparing base (59551e4) to head (dec1e22).
Report is 213 commits behind head on master.

Files
Patch %
Lines

...pinot/query/runtime/plan/MultiStageQueryStats.java
64.45%
66 Missing and 25 partials :warning:

...requesthandler/MultiStageBrokerRequestHandler.java
0.00%
86 Missing :warning:

...e/operator/LeafStageTransferableBlockOperator.java
58.53%
66 Missing and 2 partials :warning:

...ava/org/apache/pinot/common/datatable/StatMap.java
74.61%
30 Missing and 19 partials :warning:

...t/common/response/broker/BrokerResponseNative.java
64.63%
26 Missing and 3 partials :warning:

...y/runtime/operator/BaseMailboxReceiveOperator.java
62.06%
7 Missing and 4 partials :warning:

...common/response/broker/BrokerResponseNativeV2.java
0.00%
9 Missing :warning:

.../pinot/query/runtime/blocks/TransferableBlock.java
77.14%
6 Missing and 2 partials :warning:

...g/apache/pinot/common/datablock/MetadataBlock.java
87.27%
6 Missing and 1 partial :warning:

...ot/query/runtime/operator/MailboxSendOperator.java
78.57%
5 Missing and 1 partial :warning:

... and 20 more

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12704      +/-   ##
============================================
- Coverage     61.75%   61.70%   -0.05%
- Complexity      207     1202     +995
============================================
  Files          2436     2464      +28
  Lines        133233   135647    +2414
  Branches      20636    20969     +333
============================================
+ Hits          82274    83700    +1426
- Misses        44911    45706     +795
- Partials       6048     6241     +193

Flag
Coverage Δ

custom-integration1
?

integration
?

integration1
?

integration2
?

java-11
?

java-21
61.70% <65.53%> (+0.07%)
:arrow_up:

skip-bytebuffers-false
46.50% <70.57%> (-15.25%)
:arrow_down:

skip-bytebuffers-true
27.80% <0.00%> (+0.07%)
:arrow_up:

temurin
61.70% <65.53%> (-0.05%)
:arrow_down:

unittests
61.70% <65.53%> (-0.05%)
:arrow_down:

unittests1
46.50% <70.57%> (-0.39%)
:arrow_down:

unittests2
27.80% <0.00%> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

There seems to be an randomly detected by integration tests where we end up timing out. I'm trying to find why.

Will there be downtime when broker and servers are running different versions? Please add a section in the PR description describing what to expect during upgrade.

Regarding the race condition, it might be related to the early termination. I'll also look more into it, but I remember seeing similar issues for other classes

Is it possible to break this PR into smaller ones? Currently it covers too many topics and is hard to track all the changes

I can try, but I think most of the topics are related.


Provide default Tween values for transition and easing types

Helps #26529.
TRANS_LINEAR and EASE_IN_OUT are chosen as defaults for interpolation and follow methods.

Thanks!


Property X never defined on Y

I'm running into this issue,
// index.js
import Type from './Type'

const t = new Type()
t.fromXML('Hello world', { name: 'test', optional: false })
console.log(t.type)

// Type.js
/**
 * A representation of a type.
 * @extends {typal.Type}
 */
export default class Type {
  fromXML(content, props) {
    this.type = props.name
    this.desc = content
  }
}

// depack/prop/externs.js
/** @const */
var typal = {}
/**
 * @typedef {{ type: string, desc: string }}
 */
typal.Type

I'm pretty sure if something extends an extern, it should preserve its own methods as well.
-jar compiler.jar --compilation_level ADVANCED \
--language_out ECMASCRIPT_2017 \
--formatting PRETTY_PRINT --externs depack/prop/externs.js \
--module_resolution NODE \
--js depack/prop/index.js depack/prop/Type.js

Compiles fine though
class a {
}
;const b = new a;
b.type = "test";
b.desc = "Hello world";
console.log(b.type);

Don't want the warning though.
depack/prop/index.js:4: WARNING - Property fromXML never defined on Type
t.fromXML('Hello world', { name: 'test', optional: false })
  ^^^^^^^

0 error(s), 1 warning(s), 87.0% typed

Created internal issue http://b/130165924

Here's a repro using the online debugger, including a bit of extra stuff I was using to experiment.
https://closure-compiler-debugger.appspot.com/#input0%3D%252F**%2520%2540typedef%2520%257B%257B%2520type%253A%2520string%252C%2520desc%253A%2520string%2520%257D%257D%2520*%252F%250Avar%2520LocalType%253B%250A%250A%252F**%250A%2520*%2520A%2520representation%2520of%2520a%2520type.%250A%2520*%2520%2540extends%2520%257BLocalType%257D%250A%2520*%252F%250Aexport%2520class%2520Type%2520%257B%250A%2520%2520%252F**%250A%2520%2520%2520*%2520%2540param%2520%257Bstring%257D%2520content%250A%2520%2520%2520*%2520%2540param%2520%257B%257Bname%253A%2520string%252C%2520optional%253A%2520boolean%257D%257D%2520props%250A%2520%2520%2520*%252F%250A%2520%2520fromXML(content%252C%2520props)%2520%257B%250A%2520%2520%2520%2520this.type%2520%253D%2520props.name%253B%250A%2520%2520%2520%2520this.desc%2520%253D%2520content%253B%250A%2520%2520%257D%250A%257D%26input1%3Dimport%2520%257BType%257D%2520from%2520'.%252Finput0'%253B%250A%250Aconst%2520t%2520%253D%2520new%2520Type()%253B%250At.fromXML('Hello%2520world'%252C%2520%257B%2520name%253A%2520'test'%252C%2520optional%253A%2520false%2520%257D)%253B%250Aconsole.log(t.type)%253B%26conformanceConfig%26externs%3Dconst%2520console%2520%253D%2520%257B%257D%253B%250A%252F**%250A%2520*%2520%2540param%2520%257B...%257D%2520args%250A%2520%252F%250Aconsole.log%2520%253D%2520function(args)%2520%257B%257D%253B%250A%250A%252F**%2520%2540const%2520*%252F%250Avar%2520typal%2520%253D%2520%257B%257D%253B%250A%252F**%250A%2520*%2520%2540typedef%2520%257B%257B%2520type%253A%2520string%252C%2520desc%253A%2520string%2520%257D%257D%250A%2520*%252F%250Atypal.Type%253B%250A%250A%250A%252F**%250A%2520*%2520%2540record%2520%257B%257B%2520type%253A%2520string%252C%2520desc%253A%2520string%2520%257D%257D%250A%2520*%252F%250Atypal.TypeAsRecord%2520%253D%2520class%2520%257B%250A%2520%2520constructor()%2520%257B%250A%2520%2520%2520%2520%252F**%2520%2540type%2520%257Bstring%257D%2520*%252F%250A%2520%2520%2520%2520this.type%253B%250A%2520%2520%2520%2520%252F**%2520%2540type%2520%257Bstring%257D%2520*%252F%250A%2520%2520%2520%2520this.desc%253B%250A%2520%2520%257D%250A%257D%253B%250A%26refasterjs-template%26includeDefaultExterns%3Dtrue%26CHECK_TYPES%3Dtrue%26MISSING_PROPERTIES%3Dtrue%26TRANSPILE%3Dtrue%26CLOSURE_PASS%3Dtrue%26PRESERVE_TYPE_ANNOTATIONS%3Dtrue%26PRETTY_PRINT%3Dtrue

The compiler should not allow you to say @extends {typedefname} on an ES6 class.
I'll file a separate issue for that.
@zavr-1 I believe you can resolve your problem by changing your code to be something like this.
// externs
/** @const */
var typal = {};
/**
 * @record
 */
typal.Type = class {
  constructor() {
    /** @type {string} */
    this.type;
    /** @type {string} */
    this.desc;
  }
};

// Type.js
/**
 * A representation of a type.
 * @implements {typal.Type}
 */
export default class Type {
  constructor() {
    /** @type {string} */
    this.type = '';
    /** @type {string} */
    this.desc = '';
  }

  /**
   * @param {string} content
   * @param {{name: string, optional: boolean}} props
   */
  fromXML(content, props) {
    this.type = props.name;
    this.desc = content;
  }
}

Please update this issue to let us know if that works for you.
Thanks.

hi yeah i've figured it out I could do that thank you, did something like that, please feel free to close this.
   /**
     * The name of the type.
     * @type {?string}
     */
    this.name = null
    /** @type {?string} */
    this.type = null

@zavr-1
I'm glad you've found a solution.


Array Jumping Game II edge case

Something small to account for the jumping game II not returning 0 if the first of the array is 0 resulting in repeated failed attempts.

Thanks


track 415 errors

Hello! First of all, thank you very much for creating and sharing this package!
While using it, I came across a bug when DRF returns a 415 response, because the exception is raised when trying to access request.data (property data calls _load_data_and_files, which calls _parse, which raises an UnsupportedMediaType exception).
This caused DRF to exit initial before self.request.log was created in LoggingMixin, which caused an AtributeError exception in finalize_request: AttributeError("'Request' object has no attribute 'log'",).
(Lots of "whichs" in this description.)
I hope this PR is useful!

Changes Unknown when pulling ef613b9ff67a542e2f37d2c1b9d19297e1f17fc8 on MissFilly:master into ** on aschn:master**.

Changes Unknown when pulling 1f743320a327073d61e6391e56ec64ac201a118a on MissFilly:master into ** on aschn:master**.

@MissFilly Thank you for you contribution!


Conflict with Onedrive file on-demand feature

VSCode Version: 1.14.0
OS Version: Windows 10 Build 16237

Steps to Reproduce:

Enable File on-demand feature in Onedrive
Open a file in Onedrive folder

Reproduces without extensions: Yes
Verbose Log:
[6184:0712/152810.854:INFO:CONSOLE(28)] "Unable to open 'all.ps1': File not found (c:\Users\Jack\OneDrive\all.ps1).: Error: Unable to open 'all.ps1': File not found (c:\Users\Jack\OneDrive\all.ps1).
at Object.t.create (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:65895)
at t.doHandleSetInputError (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:422757)
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:29:422451
at Object.v [as _notify] (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:53344)
at Object.enter (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:56836)
at n.Class.derive._creator._run (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:58157)
at n.Class.derive._creator._chainedError (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:57516)
at n (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:55339)
at n.Class.define.cancel.then (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:58966)
at Object.enter (file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:55408)", source: file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js (28)

#27285


error: file "/opt/homebrew/opt/socket_vmnet" is a symlink

Description
❯ limactl start template://vmnet
? Creating an instance "vmnet" Proceed with the current configuration
FATA[0000] networks.yaml field paths.socketVMNet error: file "/opt/homebrew/opt/socket_vmnet" is a symlink

I have to set absolute real path, not symlink
paths:
socketVMNet requires Lima >= 0.12 .
socketVMNet has precedence over vdeVMNet.
socketVMNet: "/opt/homebrew/Cellar/socket_vmnet/1.1.2/bin/socket_vmnet"
Setting it up like this made it work for me

Thank you!!!


rhel8 - Spyder crashing (DISA STIGed)

Issue Report Checklist

[X] Searched the issues page for similar reports
[X] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[X] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[X] Tried basic troubleshooting (if a bug/error)

[X] Restarted Spyder
[X] Reset preferences with spyder --reset
[X] Reinstalled the latest version of Anaconda
[X] Tried the other applicable steps from the Troubleshooting Guide

[X] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Cannot launch Spyder on any Hardened (STIG) Red Hat Enterprise Linux 8 system. Receive errors when launching Spyder, as it crashes immediately. Tested on an non-hardened RHEL8 Workstation without issue. It seems to be a DISA STIG causing the issue. I am look for guidance on what could potentially be blocking based on the error output below.
What steps reproduce the problem?

Hardened RHEL8 system (using Ansible-Lockdown project for RHEL8)
Installed the latest version of Anaconda, using the published .sh file follwing steps:

sudo su -
cd /root
mkdir -p /usr/local/src/tmpinstall
cp -vi Anaconda3-2021.11-Linux-x86_64.sh /usr/local/src/
TMPDIR=/usr/local/src/tmpinstall bash /usr/local/src/Anaconda3-2021.11-Linux-x86_64.sh -u -p /opt/anaconda3
vim .condarc
    Add:
        channel_alias: https://artifactory.URL/artifactory/api/conda
        channels:
          - conda-forge
          - conda-pytorch
          - anaconda-main
        default_channels:
          - https://artifactory.URL/artifactory/api/conda/conda-forge

/opt/anaconda3/bin/conda init bash
/opt/anaconda3/bin/conda update conda
/opt/anaconda3/bin/conda update --all
dnf install libXScrnSaver libXScrnSaver-devel
/opt/anaconda3/bin/spyder

What is the expected output? What do you see instead?
Expected outcome is Spyder to launch. What we see instead:
[root@its-conda-test ~]# /opt/anaconda3/bin/spyder
Update LANGUAGE_CODES (inside config/base.py) if a new translation has been added to Spyder
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
link image0 hasn't been detected!
[120336:120336:0429/231430.943903:FATAL:credentials.cc(137)] Check failed: error == EPERM || error == EUSERS || error == EINVAL || error == ENOSYS.  I have a couple of comments about what you reported:

I don't understand why you're trying to run Spyder as root.  I mean, this could be part of the problem.
Your problem seems similar to the one reported here. To avoid it, we added a CLI option called --no-web-widgets that's going to be available in our next version (5.3.1), to be released in a couple of weeks. So you should wait until it's available and try again.

Hello @ccordoba12,

I got the same exact results as multiple user accounts. Root was just the elevation I was when I grabbed the snippet. Account or privledge did not affect the results, typically we only run Spyder as the user.
When will 5.3.1 release? I have customers who need this functionality for projects they are working on, as I been struggling to find a resolution. This works fine on non-hardened (DISA STIG) RHEL8 workstations, and it works fine on RHEL7 Workstations regardless of hardened or non-hardened. I am just trying to determine if something is blocking Spyder, or perhaps permissions to a resource.

When will 5.3.1 release?

In a couple of weeks, but Anaconda is way behind in our versions (more than six months at this point), so I wouldn't hold my breath on it.

Closing for now. Please comment if 5.3.1 fixes your problem when it's out.


Error object in callback is null

When calling '/appointments/:id' with an invalid id, the error object is returned as the 'appointment', and the 'err' variable is set to null.
Here is my javascript code:
function updateAppointment() {
  var options = {
    method: 'PUT',
    body: {
      firstName: "updated first name"
    }
  }

  return new Promise((resolve, reject) => {
    acuity.request(`/appointments/invalid_id`, options, (err, _res, appointment) => {
      console.log(err) // output: null
      if (err) {
        // this code is never reached
        reject(err)
      }
      console.log(appointment) // output: { "status_code":404, "message":"Not Found", "error":"not_found" }
      resolve(appointment)
    })
}

Am I missing something, or is this broken?

Hey @ryan-saffer — you've got that right!  err will populate if there's been some error making the request, such as a network or other connection error.  Requests which are successfully made populate the response status code and the SDK parses any JSON response from the server, including for non-200 responses.

Hey @cesutherland, thanks for the response.
This design seems very strange to me, and I don't see why the error value in the callback doesn't wrap up both network/general errors along with acuity specific errors.
Since I am making these calls inside my own express app, I need to amend the code to look like:
return new Promise((resolve, reject) => {
  acuity.request(`/appointments/invalid_id`, options, (err, _res, appointment) => {
      if (err) reject(err)
      if (appointment.error) reject(appointment)

      resolve(appointment)
  })
}

But now that this is clear, I can at least work with it for now :)
On another note... any chance this npm package will get a @types package for TypeScript?

@ryan-saffer all clear!  Our library (more or less) is built on top request.js and matches that API pretty closely — so that's the underlying reason.
We don't have any plans for major improvements to our SDK at this time, any large future improvements would almost certainly include TS & types.  Appreciate the feedback!