tighten fmt in libmamba

Checklist

[X] Used a static YAML file for the patch if possible (instructions).
[ ] Only wrote code directly into generate_patch_json.py if absolutely necessary.
[ ] Ran pre-commit run -a and ensured all files pass the linting checks.
[ ] Ran python show_diff.py and posted the output as part of the PR.
[X] Modifications won't affect packages built in the future.

fmt 10.2.0 breaks libmamba on Windows: https://github.com/conda-forge/fmt-feedstock/pull/39

Sorry for breaking libmamba by merging that 10.2 release. Please merge this :)
Is this in any way libmamba specific or is fmt 10.2 just a breaking ABI change? @jaimergp
If so, we probably need to update the run-exports of fmt (and also make that change to the previous 10.x builds…)

I agree with all @saraedum said above. This PR seems like the right path forward.

recipe>python show_diff.py
================================================================================
================================================================================
linux-armv7l
================================================================================
================================================================================
win-32
================================================================================
================================================================================
osx-arm64
osx-arm64::libmamba-1.5.6-h90c426b_0.conda
osx-arm64::libmamba-1.5.0-h6089622_1.conda
osx-arm64::libmamba-1.5.4-h0a6dc31_0.conda
osx-arm64::libmamba-1.5.1-h0a6dc31_2.conda
osx-arm64::libmamba-1.5.3-h0a6dc31_1.conda
osx-arm64::libmamba-1.5.1-hace0f30_1.conda
osx-arm64::libmamba-1.5.2-h0a6dc31_1.conda
osx-arm64::libmamba-1.5.2-h0a6dc31_0.conda
osx-arm64::libmamba-1.5.1-h6089622_0.conda
osx-arm64::libmamba-1.5.5-h0a6dc31_0.conda
osx-arm64::libmamba-1.5.3-h0a6dc31_2.conda
-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",
================================================================================
================================================================================
linux-ppc64le
linux-ppc64le::libmamba-1.5.1-h5f46139_2.conda
linux-ppc64le::libmamba-1.5.3-h5f46139_2.conda
linux-ppc64le::libmamba-1.5.6-h5f46139_0.conda
linux-ppc64le::libmamba-1.5.3-h5f46139_1.conda
linux-ppc64le::libmamba-1.5.0-hcbafca5_1.conda
linux-ppc64le::libmamba-1.5.2-h5f46139_1.conda
linux-ppc64le::libmamba-1.5.4-h5f46139_0.conda
linux-ppc64le::libmamba-1.5.5-h5f46139_0.conda
linux-ppc64le::libmamba-1.5.1-h2246aa7_1.conda
linux-ppc64le::libmamba-1.5.1-hcbafca5_0.conda
linux-ppc64le::libmamba-1.5.2-h5f46139_0.conda
-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",
================================================================================
================================================================================
linux-aarch64
linux-aarch64::libmamba-1.5.2-hea3be6c_1.conda
linux-aarch64::libmamba-1.5.1-hea3be6c_2.conda
linux-aarch64::libmamba-1.5.1-h5d583b4_1.conda
linux-aarch64::libmamba-1.5.3-hea3be6c_2.conda
linux-aarch64::libmamba-1.5.0-h604a1c0_1.conda
linux-aarch64::libmamba-1.5.2-hea3be6c_0.conda
linux-aarch64::libmamba-1.5.1-h604a1c0_0.conda
linux-aarch64::libmamba-1.5.6-hea3be6c_0.conda
linux-aarch64::libmamba-1.5.4-hea3be6c_0.conda
linux-aarch64::libmamba-1.5.3-hea3be6c_1.conda
linux-aarch64::libmamba-1.5.5-hea3be6c_0.conda
-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",
================================================================================
================================================================================
noarch
================================================================================
================================================================================
win-64
win-64::libmamba-1.5.1-h925f7fc_1.conda
win-64::libmamba-1.5.0-h16d0179_1.conda
win-64::libmamba-1.5.2-h3f09ed1_0.conda
win-64::libmamba-1.5.1-h3f09ed1_2.conda
win-64::libmamba-1.5.3-h3f09ed1_1.conda
win-64::libmamba-1.5.3-h3f09ed1_2.conda
win-64::libmamba-1.5.6-h3f09ed1_0.conda
win-64::libmamba-1.5.1-h16d0179_0.conda
win-64::libmamba-1.5.4-h3f09ed1_0.conda
win-64::libmamba-1.5.2-h3f09ed1_1.conda
win-64::libmamba-1.5.5-h3f09ed1_0.conda
-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",
================================================================================
================================================================================
osx-64
osx-64::libmamba-1.5.5-hb976dfd_0.conda
osx-64::libmamba-1.5.3-hb976dfd_1.conda
osx-64::libmamba-1.5.6-ha449628_0.conda
osx-64::libmamba-1.5.2-hb976dfd_1.conda
osx-64::libmamba-1.5.1-h08141de_1.conda
osx-64::libmamba-1.5.3-hb976dfd_2.conda
osx-64::libmamba-1.5.0-hb45792e_1.conda
osx-64::libmamba-1.5.2-hb976dfd_0.conda
osx-64::libmamba-1.5.1-hb45792e_0.conda
osx-64::libmamba-1.5.4-hb976dfd_0.conda
osx-64::libmamba-1.5.1-hb976dfd_2.conda
-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",
================================================================================
================================================================================
linux-64
linux-64::libmamba-1.5.0-h744094f_1.conda
linux-64::libmamba-1.5.3-had39da4_2.conda
linux-64::libmamba-1.5.1-hfcfce90_1.conda
linux-64::libmamba-1.5.6-had39da4_0.conda
linux-64::libmamba-1.5.5-had39da4_0.conda
linux-64::libmamba-1.5.1-h744094f_0.conda
linux-64::libmamba-1.5.3-had39da4_1.conda
linux-64::libmamba-1.5.2-had39da4_1.conda
linux-64::libmamba-1.5.4-had39da4_0.conda
linux-64::libmamba-1.5.2-had39da4_0.conda
linux-64::libmamba-1.5.1-had39da4_2.conda
-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",

I merged this to stop the bleeding, but we still have a bunch of work to do (short of marking 10.2 as broken and not releasing it again). Everything built against 10.1 needs to get the run-export tightened (incl fmt 10.1 itself, as well as the migrator).

Thanks so much @h-vetinari. Would this plan of action agree with your expections? Am I missing any steps?

Release a new build of fmt 10.2 with a tighter run-export
Backport the tighter run-export to fmt 10.1 (and possibly other versions)
Mark older fmt packages without the tighter run-export as broken

& 2. are good, and it would be nice if you could do it. 3. should not be necessary, but we need a repodata patch that replaces

-    "fmt >=10.1.1,<11.0a0",
+    "fmt >=10.1.1,<10.2.0a0",

for any packages built against fmt.
I can do the change for the migrator (which currently injects fmt 10 into host, but really needs to do fmt 10.1 to stay consistent with everything built for that ABI).

Great. Item 1 is here: https://github.com/conda-forge/fmt-feedstock/pull/40
For item 2, I can backport this change to 10.1.1 once that PR is merged. Any other versions I should backport to?

For item 2, I can backport this change to 10.1.1 once that PR is merged. Any other versions I should backport to?

Backporting to 10.1 should be enough (as that's the version that we've been building against for almost 5 months).

Release a new build of fmt 10.2 with a tighter run-export

I am not opposed to this but why do we think that this is necessary? It seems to me that the fmt authors are careful about ABI changes. (In fact, I don't understand what's the actual problem here. On Linux, I don't see a problematic ABI change.)

@bdice @h-vetinari is anybody working on the repodata patch already or should I have a go at it?

I am not opposed to this but why do we think that this is necessary?

The fact that things broke is a pretty strong argument that it is necessary, unfortunately.

It seems to me that the fmt authors are careful about ABI changes.

I know. Perhaps they can be enlisted to help (or at least elucidate what happened)?

In fact, I don't understand what's the actual problem here. On Linux, I don't see a problematic ABI change.

Are you able to pinpoint the ABI break (or otherwise problematic change) on windows?

is anybody working on the repodata patch already or should I have a go at it?

Please go for it!

Are you able to pinpoint the ABI break (or otherwise problematic change) on windows?

No, I didn't look into extracting the symbol table of a Windows DLL on my Linux machine.

The fact that things broke is a pretty strong argument that it is necessary, unfortunately.

Shouldn't we then pin x.x.x and not just x.x.
I guess an alternative could be to add an integration test to the fmt feedstock that tries to install mamba and checks whether it still works.

So, the problematic symbol is this one:
-                  bool __cdecl fmt::v10::detail::write_console(struct _iobuf * __ptr64,class fmt::v10::basic_string_view<char>)
+                  bool __cdecl fmt::v10::detail::write_console(int,class fmt::v10::basic_string_view<char>)

So, the problematic symbol is this one:

Cool, thanks for digging! Do you want to open an issue in fmt if such an ABI break in a minor-version was intentional?

Yes, will do once I understand why it happened.

Upstream issue: https://github.com/fmtlib/fmt/issues/3785

@h-vetinari wouldn't the proper and easier fix here be to provide the missing symbol again in a patch, rebuild, and then mark build 0 as broken on Windows?

wouldn't the proper and easier fix here be to provide the missing symbol again in a patch, rebuild, and then mark build 0 as broken on Windows?

Yeah, that's what I was saying in the other issue. Thanks again for digging into this!


GNOME - Small spacing tweaks

https://gitlab.gnome.org/Teams/Circle/-/issues/143#note_1682052

I guess we're finally joining the Circle after this! 🎉


Fix for PWM tone in transmission

Based on this info: https://github.com/egzumer/uv-k5-firmware-custom/issues/405#issuecomment-2087617024 I've changed the value for the tone to not be audible during the transmission.

Great, @armel,
Thanks!

Hey, @armel
Did you manage to test?
Thanks!

Hello @s1lviu, yes, the change will be added in version 2.8.
Armel F4HWN

Commit is here :)

Great, I saw the PR still open and just wanted to see if everything is okay.
73

Muito obrigado pela sua dedicação e empenho por este firmware.


Auto Login

I'm trying to implement an auto login function for Joomla 4 website. Can this be done and whats the best approach for this?

Auth Adapter!


Combine RGB textures not export?

Hello. I tried to export gltf with metallic and roughness separately (but combined by "Combine RGB"), but Blender does not export this texture. Blender have no own image processing library? Would be good ImageMagick, for example, inside of Blender.

Merging the seperate channels could be done with Blender and there is no need for ImageMagick inside Blender.
This feature is out of scope for the exporter. The glTF PBR nodes expect the textures as they are defined in glTF 2.0.
However, your idea is good and I suggest you implement a command line tool using ImageMagick, which is combining these channels. If it is working, please list it here:
https://github.com/KhronosGroup/glTF/issues/867


Support SQLAlchemy >= 1.4

This change is

Coverage decreased (-0.2%) to 93.313% when pulling 5c7486742d2407e9a19295df3d341271398b3e8d on riklaunim:sqlupdate into 2f82e6fcc87bc5d479861bf67f850c035104c14c on socialwifi:master.


[Improvement] Cursor after pasting image is behind image

First of all, thanks for this amazing plugin.
Thanks to  the compression, my images are now only a third its size.
And being able to specify a default size is also something that I greatly appreciate (its how I found this plugin at first :D).
Anyway, there is a small inconvenience.
After pasting an image the cursor is now behind the image link.
Which means I have to move my cursor again to the front to continue writing.
Nothing big, but it would improve my quality of life a little bit, if it were possible to fix that. : )
Thanks for your work
Video to demonstrate the inconvenience:
https://github.com/xRyul/obsidian-image-converter/assets/49547606/af572636-c79b-43f7-8439-0a0eae73b30b

This is happening due to this code.
editor.setCursor({ line: currentLine, ch: 0 });

After pasting the file and renaming, it places the cursor at the start position. I commented the line and generated a main.js file, replaced into my plugins folder and the cursor seems to be fine after pasting.
main.js.zip
I am still learning Obsidian Plugins, so I am not sure what the correct logic should be. Perhaps it should be an easy fix for @xRyul

As many are already used to the current behaviour it would be very beneficial to have this as a setting so people can choose.
I would personally much more prefer the cursor being at the end of the line as usually you paste an image in and then continue to write. How it is now is probably because some people prefer pasting in images and having the text about the image above it.


iOS - preview blurred and no scan on Pro models (with 3 cameras)

QRKit version - 1.0.2 1.0.3
XCode version - 15.4
Kotlin version - 1.9.23
AGP - 8.2.2

The library works as intended on android, but running it on iOS has been a challenge.
Issues noticed

In the last week only once was when the scan worked on iOS, haven't then been able to replicate the same. How can I debug what could be going wrong? I tried running the demo app in the repo but the build never succeeds. - RESOLVED after updating to 1.0.3 This issue is still happening, scans are not working most times. Tested on IPhone SE2 and iPhone Xr
On the iPhone 15 pro, the preview is always blurred and it does not focus when held up towards the QR.
Preview is stuck post scan, which I believe has been already reported here.

Can you guide on what steps can be taken to either debug or fix this please? Let me know if you need any more info.

Thanks for reporting! Let us check and get back to you

@ctn-mobile-innovation we would be happy to contribute for the blur issue as this is something we've fixed on native for iOS. Is the library open sourced elsewhere or is it closed? Could not find it in this repo.

@ctn-mobile-innovation any updates here?

We have worked on fix! will publish an update this week, and yes we will be happy if you can contribute!

Was the fix released @ctn-mobile-innovation ? Any ETAs?

@jishinhv Please check in new version and let us know!

@ctn-mobile-innovation The app is frozen on launch and I get the following error when running on iOS with the latest version 1.0.7 -
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[AVCaptureMetadataOutput setMetadataObjectTypes:] Unsupported type found (catBody) - use -availableMetadataObjectTypes'
*** First throw call stack:
(0x19ba06418 0x198d6de88 0x1ba273720 0x1069cfb1c 0x1069d3a34 0x1069d4a78 0x106150740 0x1066beff4 0x1066c06b0 0x10614f1d8 0x1062aebc8 0x1063b50ac 0x1062a45cc 0x10629f530 0x1062a005c 0x1063b47f8 0x1062c5268 0x1062c97bc 0x1062c9a04 0x10614f1d8 0x106270ad4 0x1062713a8 0x1066818fc 0x10675ac84 0x1066e5cd8 0x1054a4a60 0x10673be64 0x10676593c 0x10673277c 0x106735068 0x10673716c 0x10673723c 0x106150740 0x106737f84 0x106738038 0x19d509e90 0x19d5081fc 0x19d507d94 0x19e2141bc 0x19e213e0c 0x19e214ca0 0x19b9d928c 0x19b9d9220 0x19b9d6d5c 0x19b9d5f04 0x19b9d5714 0x1e74d11c4 0x19e549564 0x19e5f7530 0x1a011fefc 0x1a00fa538 0x1a00fd398 0x1049d8474 0x1049d8520 0x1c157fcd0)
libc++abi: terminating due to uncaught exception of type NSException

Hey @ctn-mobile-innovation, We've not been able to confirm the fix released with 1.0.7 because of the above reported crash and would really appreciate if you could help us out here with a quick resolution.

Raised a new issue for the crash  - https://github.com/Chaintech-Network/QRKitComposeMultiplatform/issues/7

Please check in Latest version 1.0.8

This works. Thanks @ctn-mobile-innovation 🙌


fix(driver): expose native-host option and set default to <IP_ADDRESS>, closes #3815

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[x] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information
Closes #3815.
Adding the --host option has no effect in Windows, but it does not harm either.

@chippers Thanks a lot for the quick merge and release. And thank you for your work on tauri-driver. It is very valuable. :-)


Upgrade any .NET Framework area to .NET Core 3

.NET Core 3 upgrade
Update all sections that use .NET to .NET Core 3
.NET Framework 4.7.2

[x] ColorPicker <- done by @snickler
[x] MarkdownPreviewHandler <- #8405
[x] PreviewHandlerCommon <- #8405
[x] SvgPreviewHandler <- #8405
[x] SVGThumbnailProvider <- #8405

Tests

[x] Microsoft.Interop.Tests <- done by @eriawan
[x] PreviewPaneUnitTests <- #8405
[x] UnitTests-PreviewHandlerCommon <- #8405
[x] UnitTests-SvgPreviewHandler <- #8405
[x] UnitTests-SvgThumbnailProvider <- #8405
[x] PowerToysTests <- done by @riverar WinAppDriver tests

.NET Standard 2.0

[x] Managed Common
[x] Telemetry
[x] Settings.UI.Library
[x] PowerLauncher.Telemetry

.NET Core 3.1

[x] FancyZonesEditor
[x] Settings.UI.Runner
[x] Settings.UI.UnitTests
[x] UnitTest-ColorPicker
[x] ImageResizerUI
[x] ImageResizerUITests
[x] PowerLauncher
[x] Wox.Infrastructure
[x] Wox.Plugin
[x] Wox.Test

UWP

[x] Settings.UI

Things to include

ReadyToRun should be timed to verify boost.  see blog post
PublishTrimmed to reduce file size.  see blog post

This issue has a pre-requisite https://github.com/microsoft/PowerToys/issues/866

Added the resolved label since on our side this is done.
Added the external label to indicate we are waiting of an external dependency to be available.

We might need to revert this guy after the migration.

Moving to backlong since we don't know when .Net Core will be available in the store compared to our roadmap.

We will adopt .Net Core 3.1

If #866 is solved, what's holding this back?

@haakoo, doing it this iteration :)  only so many hours in the day for the team and they were focusing on helping add in 4 new utilities and the 2 more new ones we will be shipping soon.

For FancyZone editor is better to do it in 0.19

. NET 5?

This is needed for #490

@davidegiacometti  what item(s) are you working on?  want to be sure we are not having anyone duplicating work

@crutkas

MarkdownPreviewHandler
PreviewHandlerCommon
SvgPreviewHandler
SVGThumbnailProvider
PreviewPaneUnitTests
UnitTests-PreviewHandlerCommon
UnitTests-SvgPreviewHandler
UnitTests-SvgThumbnailProvider

@davidegiacometti
please, open one PR per project, so it will be easier and faster to review and merge each one.
Thanks.

I'll take on porting the Color Picker

Will take a look at PowerToysTests <- WinAppDriver tests

I'm taking Microsoft.Interop.Tests migrate to .NET Core 3.1

.NET Core 3 upgrade
Update all sections that use .NET to .NET Core 3
.NET Framework 4.7.2

[x] ColorPicker <- done by @snickler

[x] MarkdownPreviewHandler <- #8405

[x] PreviewHandlerCommon <- #8405

[x] SvgPreviewHandler <- #8405

[x] SVGThumbnailProvider <- #8405

Tests

[x] Microsoft.Interop.Tests <- done by @eriawan

[x] PreviewPaneUnitTests <- #8405

[x] UnitTests-PreviewHandlerCommon <- #8405

[x] UnitTests-SvgPreviewHandler <- #8405

[x] UnitTests-SvgThumbnailProvider <- #8405

[x] PowerToysTests <- done by @riverar WinAppDriver tests

.NET Standard 2.0

[x] Managed Common

[x] Telemetry

[x] Settings.UI.Library

[x] PowerLauncher.Telemetry

.NET Core 3.1

[x] FancyZonesEditor

[x] Settings.UI.Runner

[x] Settings.UI.UnitTests

[x] UnitTest-ColorPicker

[x] ImageResizerUI

[x] ImageResizerUITests

[x] PowerLauncher

[x] Wox.Infrastructure

[x] Wox.Plugin

[x] Wox.Test

UWP

[x] Settings.UI

Things to include

ReadyToRun should be timed to verify boost.  see blog post

PublishTrimmed to reduce file size.  see blog post


fix(MultipleTooltip): changed tooltips and it's backdrop styles

Hi
In this PR, I propose to change the tooltip styles

The background color of the tooltip itself has been changed with the help of the product design team.
Backdrop style is suggested to correct the wrong appearance in different themes.

As a basic idea, I took the background color variable and made a gradient.

Before (AS IS)
After (TO BE)

UPD: I just received approval from the product design team for the 2nd point.


destroyStrategy is not clearing the model in custom field

Hi,
My custom fields are not having their model destroyed when they are hidden. In a lot of cases ive simply wrapped the html from the original default field (like text input) in my own custom field and added some stuff. My custom declaration looks like this
(function () {
  angular.module('cohesionApp').config(function (schemaFormDecoratorsProvider, sfBuilderProvider) {

    schemaFormDecoratorsProvider.defineAddOn(
      'bootstrapDecorator',           // Name of the decorator you want to add to.
      'cohTextBox',                     // Form type that should render this add-on
      'scripts/form-elements/coh-text-box/coh-text-box.html',  // Template name in $templateCache
      sfBuilderProvider.stdBuilders                     // List of builder functions to apply.
    );

  });
})();

I expected that the model would be destroyed as i have not made any changes to the global options for destroyStrategy. I actually purposely put destroyStrategy 'null' and destroyStrategy 'remove' on the field but this had no effect either.
The model remained no matter what i did, though the conditions for showing hiding triggered properly.
I cant provide a plunkr... its way too complicated and big to set up.
I can think of 2 things that might be causing this.

the keys and conditions are both being re-written on the fly as my form is very dynamic and can be reorganised. This hasn't caused any other bugs though and models are always linked up properly and conditions always trigger.

I am using a custom field i made myself

It all depends on your templates, can you share one? Destroy strategy is managed by sf-field directive, if you don't have that then it won't destroy anything and you would have to manage it yourself with your own directive.

Sure, here is an example. You'll see its basically the same as the standard text box but its been wrapped with a few extra bits.

    {{form.title}}
    <coh-helper-button info="form.helperInfo"></coh-helper-button>

    <var-switcher></var-switcher>

        <input
          ng-if="!form.fieldAddonLeft && !form.fieldAddonRight" ng-show="form.key" type="text" step="any"
          sf-changed="form" placeholder="{{form.placeholder}}" class="form-control {{form.fieldHtmlClass}}"
          id="{{form.key.slice(-1)[0]}}" ng-model-options="form.ngModelOptions" sf-field-model="replaceAll"
          ng-model="$$value$$" unique-value
          ng-disabled="form.readonly" schema-validate="form" name="{{form.key.slice(-1)[0]}}"
          aria-describedby="{{form.key.slice(-1)[0] + 'Status'}}">

          <input ng-show="form.key" type="text" step="any" sf-changed="form" placeholder="{{form.placeholder}}"
                 class="form-control {{form.fieldHtmlClass}}" id="{{form.key.slice(-1)[0]}}"
                 ng-model-options="form.ngModelOptions" sf-field-model="replaceAll" ng-model="$$value$$"
                 ng-disabled="form.readonly" unique-value="$$value$$"
                 schema-validate="form" name="{{form.key.slice(-1)[0]}}"
                 aria-describedby="{{form.key.slice(-1)[0] + 'Status'}}">

        {{ hasSuccess() ? '(success)' : '(error)' }}

@Lorless any chance you can show an example of it rendered too, may help see what is and isn't working?

Are there any errors in console?

Sure, here is the rendered field including its sf-decorator. There are no console errors. It appears that the destroy event in schema-form.js is never fired.
<sf-decorator ng-repeat="item in form.items" form="item" class="ng-scope">

    Padding bottom
    <coh-helper-button info="form.helperInfo">

</coh-helper-button>

    <var-switcher>

    <input class="form-control ng-pristine ng-untouched ng-valid ng-empty" id="styles:variable:6685" placeholder="Enter variable name" type="text" ng-change="dir.changeVariableValue()" ng-model="dir.proxyVariable" ng-disabled="form.disableVariable" aria-invalid="false">

</var-switcher>

        <input ng-if="!form.fieldAddonLeft && !form.fieldAddonRight" ng-show="form.key" type="text" step="any" sf-changed="form" placeholder="" class="form-control ng-touched" id="value" ng-model-options="form.ngModelOptions" sf-field-model="replaceAll" ng-model="model['styles']['xl']['padding-bottom']['value']" unique-value="" ng-disabled="form.readonly" schema-validate="form" name="value" aria-describedby="valueStatus" aria-hidden="false" aria-invalid="false">

</sf-decorator>

@Anthropic So I've been investigating this and it seems that the custom directive is not to blame, ive tried it with the default text field and it still does not remove the model. I've put loggers on lines 2131 and 623 on schema-form.js just underneath the $destroy events but it seems they arent being fired at all.

I've just realised that none of the fields inside my custom directives (apart from the very top level custom directive) have sf-field attached to their container divs. I think this may be because i've used
 <sf-decorator ng-repeat="item in form.items" form="item"></sf-decorator> in my custom directives where the custom directive has its own items array to render.
If the sf-field directive is not present, would this stop any $destroy event firing?

@Lorless two quick responses, first, you mentioned schema-form.js I assume that means you are using 0.8.13, have you tried with the alphas, could you please if not?
Secondly, yes, sf-field is where the destroy activity is managed from, so I would expect that it needs to be in the template.

@Anthropic I believe we tried to move over to the alpha a little while ago and it broke our system. We will of course migrate eventually but its hard to make a case for it right now.
Is there any reason why the sf-field directive wouldn't be applied to items rendered from sf-decorator inside a custom field? That seems to be the heart of the problem. I have custom fields like accordions that render more form fields inside themselves using that sf-decorator with a repeat

@Lorless ideally if you are appending new items using a builder would be the better method, I haven't got time to provide more info tonight, if you haven't found a solution by 20 hours from now let me know nad I will try to help tomorrow night :)

@Anthropic tried updating to v1.0.4 and well... nothing. The form doesn't render at all, not even a  lonely div. No errors either.

@Lorless are you on IE by any chance? If so you need a polyfill for Object.assign, I will be added it to the next alpha either directly or in a legacy browser support file.

@Anthropic no, im on chrome, although i've just been informed i may need to install the bootstrap decorator separately.

@Anthropic So i think i've hit the brick wall here. If i implement the builder function you suggested i think it will break the forms I have where the user can add form fields as they go. The current sf-decorator with repeat im using means any form fields added will simply be created when angular finishes its digest cycle. If i use the builder the only time any children will get built is on initialisation and on schemaFormRedraw which i cannot use due to the way the angular.copy() detaches the newly drawn form from the current one.
Thanks for your help. I think i'll close this one.


Update AbstractServiceHostBuilder.Generic.cs

var service = model.Services.Single vs  var service = model.Services.FirstOrDefault();
The Single method throws exception when the collection has more one item. I have wrote my own ServiceHostBuilder to allow Service with multiple interfaces.
But this instruction don't allow me  to do.
protected override void ValidateComponentModel(ComponentModel model)
{
//base.ValidateComponentModel(model);
}
protected override void ValidateServiceModel(ComponentModel model, ESPServiceModel serviceModel)
{
//  base.ValidateServiceModel(model, serviceModel);
}

Closing as stale. We also need a unit test for this change.


Runtime API Review

[x] ~SqlDatabase.Helper: I don't think I like the name "Helper". What about "Schema"? Subtypes are implementations of schema initializers and migrators.~ #982
[ ] Should SqlPreparedStatement.Type's EXEC be named EXECUTE for a future world with different dialects?
[ ] SqlResultSet: What if we modeled the result set as an Iterator<SqlResultRow> where the same SqlResultRow was returned every time and was documented to not be usable after calls to Iterator.next(). This creates a much nicer consumption API than the Cursor-like ResultSet where you mutate what row it's pointing at by calling next(). This is similar to how we always return the same thread-local Transaction object in SQL Brite and calling close() on it just forwards a call and doesn't actually close anything.
[ ] SqlDatabaseConnection: Do we need to expose this? Can the connection's APIs be directly on DB and the connections be an implementation detail of the driver. I'm pretty sure all driver's pool connections in some form anyway (either thread locals or just a normal pool).
[ ] QueryList can become List<Query> and we can have an internal expect factory function which delegates to CopyOnWriteList on JVM and a normal list on JS. I guess normal list for native until its threading model is more known.
[ ] Transacter.transaction's finally block is still scary. Need lots of tests for expected and unexpected exceptions in all places.

Whats the reasoning of execute vs exec? I'm pretty impartial on it, was just wondering if there was a motivation for it.
SqlResultSet is not really for consumer usage, its more to be implemented. SQLite itself, jdbc, and Android all have a step over function so I think it makes sense to keep it this way, making each individual implementor extremely simple and just a delegate to whatever engine you're using.
I'm not super ready to make a call on the connection stuff since sqlite is single connection per process anyways. If anything thats probably an argument for ditching it and then we can revisit when we support other dialects.
Theres still some @Ignore tests for the transaction finally thing. Definitely should figure that out before 1.0, but I'm scared to copy CompositeException from rx.
agree on other stuff

Whats the reasoning of execute vs exec? I'm pretty impartial on it, was just wondering if there was a motivation for it.

Mostly just preferring real words instead of abbreviations. The others are real words.

What about naming SqlResultSet as SqlCursor then? I'm just trying to hide or embrace the mutability–even if for internal API consumption only.

makes sense


QuickLaTeX backend howto?

Hi,
is it possible from the Atom's agda-mode to access the QuickLaTeX backend to load a scope-checked version of the code?

Hmm, I don't know.
First I tried agda --latex somefile.lagda in the terminal (without the  --only-scope-checking flag).
It said it typed checked the file, but then in the next line it failed with
kpsewhich: readCreateProcessWithExitCode: runInteractiveProcess:
exec: does not exist (No such file or directory)

Am I doing this right?

Does the issue #agda/agda#4507 help?

Thanks, found it!
https://github.com/agda/agda/blob/8c30a29fd73f4b19f2866f31712be102929dbfe5/src/full/Agda/Interaction/Base.hs#L407-L413
So it turned out to be a backend itself, and it's not available from the Atom's agda-mode yet.
It shouldn't be difficult to add a new backend option to the settings, but perhaps we need a new field for specifying arguments?

Would this be available as a keybinding? Maybe it is also an option not having QuickLaTeX as a setting, because otherwise to scope check and then load the file, one has to:

change the setting Backend to  QuickLaTeX
use the keybinding to scope check
change the setting back to GHC
C-C C-l

It would be better that when using the keybinding of the scope check, one has not to change the backend in settings, is this possible?

Yes that would be possible!


Extend the Readme

As of now, the README has been kept quite minimal.
I would suggest to extend the README to at least follow a structure like:

Overview
installation
Usage
(Contributing)
License

Most of this is already to some extent included in the documentation, so it would just be copy paste in the end.
Still, this would imho make the OBR repo a little more "attractive".

Furthermore, i quite like those "pipeline: passing" widgets, what do you think @greole ?


Integrate ITREX to support int8 model on the CPU-only devices

1st PR for https://github.com/stochasticai/xTuring/issues/264 to integrate Intel-Extension-for-Transformers to support int8 model on the CPU-only devices.
Usage
from xturing.models import BaseModel

# Auto detect the device and load int8 with Itrex if cpu-only
model = BaseModel.create("llama2_int8")

# Inference model with Itrex's highly optimized kernels
output = model.generate(texts=["Why are the LLM models important?"])
print(output)

TODO

[x] Load model with Itrex for CPU-only device
[x] Add example (gpt2, llama2)
[ ] Add UT (WIP)
[ ] Doc

@StochasticRomanAgeev

Hi @StochasticRomanAgeev, could you please take the time to conduct a preliminary review?

Hi @StochasticRomanAgeev @tushar2407 @MarcosRiveraMartinez, could you please take your time to review the PR, thanks :)

Hi @yiliu30,
Done merging, thanks for doing this integration!

It would be great if you could include a brief description of update into CPU inference section in the README. I intend to provide this enhancement in a subsequent PR.

It would be great if you could include a brief description of update into CPU inference section in the README. I intend to provide this enhancement in a subsequent PR.

Sure, I'll add an introduction in a follow-up PR soon :)


CITZ ICT - new CIT v4.0 development coordination

Describe the issue
A new perspective and design should be made for v4.0 of the IMB CIT (Community Information Tool). IMB will leverage NTT resources to improve the design and developing the code to make the service as ephemeral as possible (ie. can be recreated from scratch using code - as much as possible)
Additional context
Note that some of this project relies on some IaaS resources currently (servers) so challenge will be how to make this ephemeral (ie. not rely on 'Azure Backups' except for 'quick recovery only'.  Focus should be a complete project recreation (to support a full DR recovery scenario - resync from on-prem data source if necessary to support the IaaS components)
Definition of done

Work with ICT CIT dev team to help coordinate this design change and answer questions
Additional project 'Test' enviro RG should be created for testing the new code (IaC)
Result should be that they should be able move their service to Azure 'prod' (SEA) quickly once that is ready

Initial meetings held on CIT v4 needed design updates - for IaC more ephemeral service stance - Improve DR and prep for future Prod instance.  To have business-side meeting for this project to bring this project's stakeholders up to date with documentation and management understanding of what support\processes will be need in future to ready this service for proper Prod supprot

Still no word on documentation improvements but CIT v4 is currently in development and they appear to be incorporating more DevOps principals into their cloud app development work now.  Emphasis has also been on getting them operational using a IaC based cloud app\infra resource provisioner like Terraform or a similar methodology to ensure repeatability for app generation in the cloud for better management and ability to handle most levels of DR capability.  They will also separate out the data aspects of the app and handle DR separately.

Last meeting with their PO and Julian (advance meeting to discussion w ED's) - discussed the business side aspects of maintaining this CIT application moving forward, especially since Minister announcement has been made and it appears to be a more permanent service.  On-going improvement to app moving forward and establishing a proper support structure for it were discussed and there will be internal work for them on that

Daniel Hirner moved on and Krista Zens has taken over as lead for CIT v4 (may move to someone else again).  They have recommendations sent by me to make v4.0 CI\CD more prod ready (complete rebuild\DR from scratch capable & and build from Gov controlled\centralized platform) but will have to be seen what gets produced in end.  To re-verify before moving them over to Azure SEA prod to ensure they either completed this app prod-prep or will do beforehand.

Closing ticket


Use Immutable as prefix for all data types

Using Map collides with ES6 Map, and explicit renaming of every Map inside import is not ideal. Besides, in JS world Map is mutable by default and therefore naming Immutable.Map just as a Map is a bit tricky.
This of course applies to all types (List, Range...)

you can:
import { Map as IMap } from 'immutable';
// or
const IMap = Immutable.Map;

I know that I can, yet neither one solution seems ideal, and taking the vague naming into consideration ImmutableMap by default makes biggest sense to me.

Closing this aging issue


tp-link wr1043nd v2

Hi
I put your firmware on my router.
Please help me with nest issues:
1.i set a root password but the router on every page told me
"No password set!
There is no password set on this router. Please configure a root password to protect the web interface and enable SSH.
Go to password configuration"
2.i can login with my new password and without password

i setted my pppoe user and pass.i connected to my provider, but after reboot the rooter these settings disapper , not saved

4.if i install a torrent client , it show in my software list , but after reboot it is deleted.
5.how can i put my factory firmware back, because if i upgrade from web ui interface , the router after reset begin with your firmware again
MANY MANY THANKS FOR YOUR HELP AND TIME

OpenWrt 15.05 Chaos Calmer runs fine here on a TP-Link TL-WR1043ND v2.

What “firmware” did you put on your router (URL to .bin file)?
How did you “set” root password (detailed steps)?

Sounds like not a luci issue.


Failed to load resource: Frame load interrupted Safari

On Safari doesn't work.
How I can implement this on Safari.
var blob= new Blob([xmlDoc],{type:'application/octet-stream'});
saveAs(blob,fileName);

What's the status of this? We intend to go to Production, but the customer uses Safari

1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Has anyone figured this out yet?

+1

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @hrivera2014, @brunowego, @alexedev, @robprado-dev, @meysammaboudi, @hkderekchan, @IamFlashUser

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @ramir07, @tungbt94, @14glwu, @00mjk, @vicentxxye, @burakoner, @abanchev

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
mhorn69, @OrgesKreka, @2a588, @torronen, @TonyMilton, @chenxx08, @abc0xmattyic333, @z79422957, @enervey, @turober, @Abecid, @jarroda, @klimisa, @vebin, @MathieuDSTP, @amdeva, @molekilla, @angelinai, @Wagyuuu, @tim-hub


Stream logs to UI console

What problem or use case are you trying to solve?
When OD runs a long command, like apt-get install foo, it kind of just hangs for a while, and the user can't see what's happening
Describe the UX of the solution you'd like
I'd love to see the logs stream in
Do you have thoughts on the technical implementation?
This will probably be hard to do. Currently the websocket sends events in chunks...we might need to change that

Maybe we can stream it to another terminal instance? I've already seen remnants of a custom addon that uses the existing WS class, so it may be worth exploring this approach (just need to extend the refactored refactor of the terminal hook to accept addons).
There is also an official attach addon from XTerm, but I'm not sure how compatible it is with a custom WS class (if relevant at all to this case).

Hello @xingyaoww if you have a few minutes to give a cursory look (not a full review) at #2818 which tries to achieve this.
Still working on some issues.


how to make the menu sidebar shrinked when browser load this application.

Issue type

[ ] bug report
[x ] feature request
[ ] question about the decisions made in the repository

Issue description
Current behavior:
When the browser load the application, the menu sidebar is stretched, only when I click one button, the sidebar will be shrinked.
Expected behavior:
When the browser load the application, the menu sidebar is shrinked.
Steps to reproduce:
reload the application.

I have fixed this issue by adding the following code in the app\pages\pages.component.ts file
ngAfterViewInit(){ this.sidebarService.toggle(true, 'menu-sidebar'); }


Fix for #19 : Compatibility issue since jQuery dependency removal

Fix for #19 : improve browser compatibility on scrollTop calculation
By the way, some changes for stricter mode (avoid window and document global vars reference)

Thanks for your contribution!

Thanks for your efficiency!


supermium cause rdp server close connection

Describe the bug
When switching between supermium and other applications, RDP server will stop the connection.
To Reproduce
Steps to reproduce the behavior:

Connect to a windows server 2012 R2 that installed supermium x64 installer version.
Click the supermium task bar icon to switch between supermium and other applications several times.
RDP force stopped by the server.

Desktop (please complete the following information):

OS: Windows server 2012 R2 x64
v124 x64

Additional context
Error 0x904 extended error 0x0

related windows events logs

The firefox backport(Pale Moon) is working fine without any problem.
But any chromium based backports like supermium，thorium, etc have the exact same problem.

Try running Supermium by the command prompt, with the switch --enable-logging. Does anything appear?


Exception: The plugin file_picker could not be built due to the issue above.

The built failed likely due to AndroidX incompatibilities in a plugin.
Building plugin file_picker...

Perhaps #508 or #637 could help you?

Thanks it works

Duplicated


3D carousel 2 added

🛠 Adding a Feature
Closes #148 3D carousel

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
This is a 3D Carousel made using Vanilla Js and CSS3 .

📷 Screenshots

3D carousel added.


Fix inconsistent money request and task behavior

Details

On the money request confirm page, if no participant is selected, the submit button is disabled. We want to keep it enabled and instead show an error when pressed. Also, a few issue is fixed:

Blank money request confirm page view when no participant is selected
Task confirm page info are not updated dynamically

Fixed Issues

$ https://github.com/Expensify/App/issues/50577
PROPOSAL: https://github.com/Expensify/App/issues/50577#issuecomment-2405431272
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Web/mWeb
Open the same app on 2 tabs

For both tabs, press FAB > Submit expense and proceed to the confirm page
On the 2nd tab, submit the expense
On the 1st tab, verify the page is not empty/blank
On the 1st tab, verify the submit button is enabled
On the 1st tab, press the submit button and verify an error is shown
For both tabs, open any chat, start the Assign Task flow, and proceed to the confirm page
On the 2nd tab, submit the task
On the 1st tab, verify the task info is cleared
On the 1st tab, submit the task
On the 1st tab, verify an error is shown

Desktop/iOS/Android

Press FAB > Submit expense. Make sure the amount is still empty
Deeplink to the money request confirm page (e.g., staging.new.expensify.com/create/submit/confirmation/1/7929715303670174)
Verify the page is not empty/blank
Verify the submit button is enabled
Press the submit button and verify an error is shown
Close the page and open any chat
Press the + button and choose Assign task. Make sure the title and description are empty when open (if not, reopen to clear it)
Deeplink to the task confirm page (staging.new.expensify.com/new/task)
Submit the task
Verify an error is shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/8ed632a3-917b-4270-beae-b0bbff5e690b

Android: mWeb Chrome

https://github.com/user-attachments/assets/23aa7ccc-9ee7-4441-942f-1f76761a46a0

iOS: Native

https://github.com/user-attachments/assets/fe6f6c95-8132-4c0b-98eb-f449d321b657

iOS: mWeb Safari

https://github.com/user-attachments/assets/75c79abf-7a05-40c2-8a84-c8d167af46a1

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/4d484efc-a452-4ab9-af63-c37c05252834

MacOS: Desktop

https://github.com/user-attachments/assets/9a1a1350-26e7-4885-a0e5-06c7a36a5aa9

MoneyRequestConfirmationList Onyx migration is being handled here

I'm getting not found page on the second tabs.
https://github.com/user-attachments/assets/efd1655b-d8f7-4099-9492-f8d16db61e24

@hungvu193 I sometimes can repro it. The not found page is shown because the transaction draft is cleared when we submit the expense.
https://github.com/Expensify/App/blob/c4fb434fea6dab0f69577bf4b7faf5c263a96f30/src/pages/iou/request/step/IOURequestStepConfirmation.tsx#L672
But there is a useEffect here that init the money request back when the transaction is cleared. The effect sometimes is triggered while the RHP is closing, but sometimes not.
https://github.com/Expensify/App/blob/c4fb434fea6dab0f69577bf4b7faf5c263a96f30/src/pages/iou/request/IOURequestStartPage.tsx#L64-L69
The not found page is also shown when the screen is focused.
https://github.com/Expensify/App/blob/c4fb434fea6dab0f69577bf4b7faf5c263a96f30/src/pages/iou/request/step/withFullTransactionOrNotFound.tsx#L50-L57

I think we might need to fix it as well.

Hmm, what should be the expected behavior? The not found view is from WithFullTransactionOrNotFound. I think it's fine to show the not found page when the transaction data is undefined. The issue we are trying to fix is when the transaction data isn't undefined but the participant is missing.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/3098efdd-9d0c-4143-b4e1-aa2d825401f0

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/6e562fd4-cc63-4365-9f40-c36a0c55d4bf

MacOS: Desktop

https://github.com/user-attachments/assets/c146e06b-7d67-495a-be7c-140ffa75513d

@bernhardoj Let's merge main 😄

@hungvu193 done

Looks like there's a deprecation warning for withOnyx causing the ESLint action to fail.

Yes, I noted it here

Ah ok, it looks like in that case we're ok with merging then.

Not an emergency, see comments above – the withOnyx deprecation is being taken care of in https://github.com/Expensify/App/issues/50532

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Update pinax-documents requirement

pinax-documents is now at version 0.4.1 with improved documentation.

Thank you @grahamu!


Fix multiplier and divisor for TS011F (TZ3210) (Mercator White Smart Zigbee Isaac Double Outlet Power Point)

Have added a Mercator White Smart Zigbee Isaac Double Outlet Power Point with USB Port to HA, four sensors automatically added and all seem fine except sensor.laundry_smart_plug_smartenergy_metering_summation_delivered, which is waaaay off. Its showing 5.5 billion kw/h used since plugging in a couple weeks ago. In the last hour, its gone up by 500 million kw/h, whereas I believe it should only be 500 watts.
Sensors:
sensor.laundry_smart_plug_electrical_measurement
sensor.laundry_smart_plug_electrical_measurement_rms_current
sensor.laundry_smart_plug_electrical_measurement_rms_voltage
sensor.laundry_smart_plug_smartenergy_metering_summation_delivered
Zigbee Device Signature:
{
"node_descriptor": "NodeDescriptor(logical_type=<LogicalType.Router: 1>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress|RxOnWhenIdle|MainsPowered|FullFunctionDevice: 142>, manufacturer_code=4098, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=False, *is_full_function_device=True, *is_mains_powered=True, *is_receiver_on_when_idle=True, *is_router=True, *is_security_capable=False)",
"endpoints": {
"1": {
"profile_id": 260,
"device_type": "0x0051",
"in_clusters": [
"0x0000",
"0x0003",
"0x0004",
"0x0005",
"0x0006",
"0x0702",
"0x0b04",
"0xef00"
],
"out_clusters": [
"0x000a",
"0x0019"
]
},
"2": {
"profile_id": 260,
"device_type": "0x0051",
"in_clusters": [
"0x0003",
"0x0004",
"0x0005",
"0x0006",
"0xef00"
],
"out_clusters": []
},
"242": {
"profile_id": 41440,
"device_type": "0x0061",
"in_clusters": [],
"out_clusters": [
"0x0021"
]
}
},
"manufacturer": "_TZ3210_pfbzs1an",
"model": "TS011F",
"class": "zigpy.device.Device"
}

Closing issue (opened in wrong place) - have opened new issue here: https://github.com/zigpy/zha-device-handlers/issues/1403


Multiple <Helmet> tags will break (only one will render)

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
A component has a <Helmet> component tag inside it. That component is rendered along-side another <Helmet> tag. However, the contents of only one <Helmet> tag will render.
If the current behavior is a bug,
please provide the steps to reproduce and if
possible a minimal demo of the problem.
Your bug will get fixed much faster if we can run your
code and it doesn't have dependencies other than React and react-helmet.
Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or
CodeSandbox (https://codesandbox.io/s/new) example below:
https://codesandbox.io/s/sparkling-dust-qc0zgn?file=/src/index.js
What is the expected behavior?
The contents of both <Helmet> tags will render
Which versions of React and react-helmet, and which browser / OS are affected by this issue?
Did this work in previous versions of React and/or react-helmet?
React 16.14.0 / React-Helmet 6.1.0

Additional context -- I've checked this with React 17 and the issue persists. React 18 didn't seem to have the issue, but we're not ready to upgrade to React 18.

I think this may be a bug related to this feature:

Nested or latter components will override duplicate changes

In this case, these are not duplicates but are completely unique tags. But they are obliterated by the later <Helmet> call.

+1 same for us. In our case our site uses react-helmet and we have a web component running inside of it using also react-helmet. It initially renders the main site helmet tags and deletes them when the web component is rendered.


problem with thumbnail creation

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
I am uploading images to bookstack.
With some images I receive errors:
Failed to handle image upload and/or create thumbnails due to system recource limits.
The image is uploaded correcty, but no thumbnails are shown. When I get into the gallery, i recive the error message:
Failed to create gallery thumbnails due to system resource limits.
Whe I try to re- create the thumbnail for an image, I receive the error message:
Failed to create image size variations due to system resource limits.
In tghe php.ini I have the following values:
upload_max_filesize = 1024M
post_max_size = 1024M
As far as i see the file size is not the problem, as the files are much smaller (e.g. 2.2 MB). For me it seems to be more the problem of resolution (5840x4140). But this is only guessing.
Could you advise me wghat setting I need to change in order to avoid this error message?
Thank you
Exact BookStack Version
v23.10.4
Log Content
No response
Hosting Environment
docker using portainer on synology nas.
image: image: lscr.io/linuxserver/bookstack

Hi @ap2de,
This will be likely due to hitting the PHP memory limit, which is controlled via a memory_limit PHP option. You can try doubling the default to see if that helps:
memory_limit = 256M

Hi @ssddanbrown,
thank you, this did the job!


Async Google LLM + Gemini Flash transcription example

Two fixes to Google LLM service

We should be using generate_content_async() instead of generate_content(). This didn't matter very much for most pipelines, because services downstream from the LLM are waiting on output from the LLM. Only the initial inference request operation was not async. We were waiting on the streamed chunks asynchronously. But this does matter if we are trying to do things in a ParallelPipeline, for example.
We were overwriting any system instructions provided as constructor arguments with None if no system instructions were extracted from the context messages list.

This also includes a complete, commented example showing how to use Gemini Flash as a (quite reliable) transcriber.

Wow! This works surprisingly well.
I'm wondering if we can roll it up into a single processor (or set of processors that work together), so that it's easier to deploy in a pipeline. WDYT @kwindla?

Wow! This works surprisingly well.
I'm wondering if we can roll it up into a single processor (or set of processors that work together), so that it's easier to deploy in a pipeline. WDYT @kwindla?

Yes! That's a nice idea. I think we could do that in a next step.
Grabbing your comment from our internal Slack and putting it here for posterity and adding comments ...
pipeline = Pipeline(
    [
        transport.input(),
        context_aggregator.user(), # extended to handle audio aggregation
        ParallelPipeline(
            [  # transcribe
                transcription_llm # a new LLM-for-STT service class
            ],
            [  # conversation inference
                conversation_llm,
            ],
        ),
        tts,
        transport.output(),
        context_aggregator.assistant(), # extended to replace user audio input with text equivalent
    ]
)


XR-Loop (VR) - Picker Functionality not working

As soon as the XR frame loop is started, the ray camera picker method does not find any objects in the scene anymore.
Probable origin of the bug:
https://github.com/vale-sch/FUDGE/blob/11c5a02f773b56477bd11a5da5456d32212371d9/Core/Source/Render/Viewport.ts#L182-L211
https://github.com/vale-sch/FUDGE/blob/11c5a02f773b56477bd11a5da5456d32212371d9/Core/Source/Render/RenderWebGL.ts#L118-L121
Called from drawVR():
https://github.com/vale-sch/FUDGE/blob/11c5a02f773b56477bd11a5da5456d32212371d9/Core/Source/Render/XRViewport.ts#L45-L83

Du musst mich wahrscheinlich zum Kollaborateur machen, damit Du mir den Issue zuweisen kannst

Durch Reset des crc.viewports nach dem stereoskopen Rendern konnte das Problem behoben werden. Es sind noch Performanceuntersuchungen erforderlich.


Mapping stages from disease table in CDA

See file OpDiagnosisMapper
Create TSV file with Stage terms (e.g. https://ontobee.org/ontology/NCIT?iri=http://purl.obolibrary.org/obo/NCIT_C27966) -- limit to "generic" stage terms such as Stage III.
Consider how to model this with the MapEntry class -- do we need a class hierarchy (because right now the labels of the "neoplasm_types.tsv" file are hard coded)
Add this to OpDiagnosisMapper and then add the Stage to the Disease entry in Phenopacket.

Update, the stage mapping is the sole responsibility of oncoexporter.cda.mapper.OpDiseaseStageMapper.


Performance when rendering many components

I'm rendering a list that contains Toggle and TextInput components. When this list gets long, the initial render is super slow. Also the subsequent renders of the list are slow, but I can solve this problem in application code by wrapping the Belle components and implementing shouldComponentUpdate.
I did some profiling and noticed that lots of CPU time gets consumed in functions injectStyles and removeStyle. It looks like the performance could be improved by refactoring how the style storage is used and styles updated. I'm thinking immutable data structures and batching the updates. But this is just guessing since I don't know the code well.
Is anyone working on this already? Any thoughts?
I also understand that the main objective in Belle is good UX and the performance optimizations shouldn't interfere with that. Optimal solution for the long list use case would be to use components that only implemented the needed functionality and focus on performance. But I've been happy using Belle so far, so thanks for the great work with it!

Hey @mattikl, thanks for your kind words & the feedback. Super valuable. Especially that you already did some profiling.
Yes, I'm working on a solution, but it will more be a complete restructuring of the architecture of Belle (using CSS Modules by default, but you can use anything class based). Here is what we came up so far: https://github.com/nikgraf/future-react-ui/ - I'm curious what you think about such a hard cut …
Right now I'm fixing a few bugs and upgrade Belle 2 to the lastest dependencies to do a final release for Belle 2 before focusing on Belle 3.

Hi @nikgraf, that's all very interesting. I haven't seen enough real-life usage to really compare the different techniques, but that's sounds like a good approach for Belle 3.
So rather than trying to optimize Belle 2's ad hoc styling, I'll wait for Belle 3 development to start and hope to help you out with that.


VM Snapshot will fail if last_host_id points to a removed host

ISSUE TYPE

Bug Report

COMPONENT NAME

API, UI, DB-related

CLOUDSTACK VERSION

4.11.3

CONFIGURATION

Hypervisor used is VMware ESXi but may happen on other Hypervisor types too
OS / ENVIRONMENT

N/A
SUMMARY

If a stopped VM is on a Host which will be removed the last_host_id will still point to the removed host. If you now try to create a VM Snaphost (may other actions will fail too but not tested yet) it will create a NPE as it can't connect to the old Host.
STEPS TO REPRODUCE

1. stop a VM which is on Host 1
2. remove Host 1 from the inventory
3. try to create a snapshot on the stopped VM

EXPECTED RESULTS

VM Snapshot should succeed as there are other Hosts which can take care of it

ACTUAL RESULTS

NPE as it tries to create the Snapshot over the Host which was removed. Here the exception:

2020-02-17 10:05:45,096 ERROR [cloud.api.ApiAsyncJobDispatcher] (API-Job-Executor-78:ctx-299e1e51 job-2404677) Unexpected exception while executing org.apache.cloudstack.api.command.user.vmsnapshot.CreateVMSnapshotCmd
java.lang.RuntimeException: Unexpected exception
        at com.cloud.vm.snapshot.VMSnapshotManagerImpl.createVMSnapshot(VMSnapshotManagerImpl.java:482)
        at sun.reflect.GeneratedMethodAccessor1021.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
        at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212)
        at com.sun.proxy.$Proxy199.createVMSnapshot(Unknown Source)
        at org.apache.cloudstack.api.command.user.vmsnapshot.CreateVMSnapshotCmd.execute(CreateVMSnapshotCmd.java:113)
        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150)
        at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:581)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:529)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
        at com.cloud.vm.snapshot.VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VMSnapshotManagerImpl.java:1199)
        at sun.reflect.GeneratedMethodAccessor1022.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        ... 26 more

@Doni7722 is this still an issue with 4.14 or master?

@rhtyd I could not reproduce it under 4.14

@Doni7722 please compare
https://github.com/apache/cloudstack/issues/3264
searching for "snapshot fail" gives 560 closed PRs alone so I couldn't tell which one to backport.
As a workaround you may try to first restart or migrate the VM and then try again.

@DaanHoogland in #3264 was nothing changes as the issue was closed. I searched a little as well but had no success.

@Doni7722 it was closed as not-a-bug, and you could not reproduce in a newer version... can we close this one?

@DaanHoogland I guess so - if I see smth similar under 4.14 I'll open a new one.


Added tests for createComponent workflow and removed the logs of gradle test

Signed-off-by: Owais Kazi<EMAIL_ADDRESS>Description
Added tests for createComponent workflow, ExtensionsSettings and removed the logs of gradle test
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-sdk/issues/25 and closes https://github.com/opensearch-project/OpenSearch/issues/3082
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @saratvemulapalli and @dbwiddis for the thorough review.


Session.get() always return null after update to 0.3.4

Hi! Thanks for great extension. I have a trouble after update to 0.3.4, Session.get('key') always returns null for both temporary and persistent keys used in app. All keys at local storage become equal null. After reverting version to 0.3.3 or removing package, it`s ok.
Meteor version <IP_ADDRESS>, my config is set to persistent, but I've seen this behavior for all possible options.
{
  "public": {
    "persistent_session": {
      "default_method": "persistent"
    }
  }
}

This happens to me as well, even with session keys set directly in the devtools console in my hasty attempts to see if it was a problem with my code.

For me unset session keys are returning the string "null", which is bad because it evaluates to true, versus if it returned just null. When I remove the package, Session.get('foo') returns false.

Sorry, it's not unset session keys, it's only one's that I've set to false:
Session.get('foo')
undefined
Session.set('foo',false)
undefined
Session.get('foo')
"null"

+1

Whoops, sorry about that. That was a sloppy release on my behalf. You should be able to keep it at 0.3.3 with no problems, and I'll have a fix out hopefully tomorrow.

Lol, just spent an hour debugging this.

+1 happening all the time with setTemp variables and got crazy debugging :_)

Sorry about that folks! That was sloppy on my behalf, and I'll be more careful about pushing updates in the future. More importantly, we'll push harder to get a solid test suite in place :)
I've reverted the offending commit and pushed version v0.3.5. I'll get around to fixing #27 soon (other work is getting in the way, unfortunately :( )


Update autoexpanding-archiving.md

Updated that you cannot use the o365 import service to import PST files to auto expanding archive.
reference attached in the issue
fixes#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/10419

Learn Build status updates of commit 66b6d98:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/autoexpanding-archiving.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@cabailey Please merge this PR. Thanks

Do not merge without confirmation of this change of support statement from an authoritative source

This PR is not suitable to merge (or fix the conflict), closing.  Support statements for PST import belong with the PST import docs, now removed from this page.


DPLL Parser breaks on multiple ¬¬

The infix-to-postfix converter parses ¬¬a as ¬a¬ (expected result a¬¬, which results in an error when attempting to construct the tree afterwards.
¬¬a should be a valid expression.

Fixed as of b6bef104f27e7a750593a1052b5b263df63f49a6


Implement url layer rule method

Added implementation of url('~/somepath*') method.
Fixed issue where isHomepage layer rule fails on non default tenants if url was in '/tenant-prefix' and not '/tenant-prefix/' as the request path returns an empty string.

The fact that the request path could be "/" or "" might actually depend on the presence of the trailing / on the domain, like https://google.com vs https://google.com/ and nothing to do with the default tenant. But it doesn't affect this PR.

Actually I found that entering the URL http://localhost:2918/ or http://localhost:2918 yielded the same result for the default tenant, but I dont know if that was because if that was of masked behaviour of the browser to not really show you the full URL of a root website in chome. It has been prettified.


pylance

An internal error occurred while type checking file "d:_bp\gameserver\server\monitor\views.py": Error: Debug Failure. False expression.
at getAliasedSymbolTypeForName (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\typeEvaluator.ts:14259:9)
at evaluateTypesForImportAs (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\typeEvaluator.ts:13283:26)
at Object.evaluateTypesForStatement (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\typeEvaluator.ts:14577:21)
at callback (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\typeEvaluatorWithTracker.ts:66:66)
at i.timeOperation (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\common\timing.ts:40:20)
at run (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\typeEvaluatorWithTracker.ts:42:46)
at Object.evaluateTypesForStatement (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\typeEvaluatorWithTracker.ts:66:13)
at C.visitImportAs (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\checker.ts:946:25)
at C.visitNode (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\parseTreeWalker.ts:250:26)
at C.walk (c:\Users\FDD.vscode\extensions\ms-python.vscode-pylance-2021.3.2\dist\pyright-internal\src\analyzer\parseTreeWalker.ts:96:37)

python script is run ok, but output this error

Thanks for the bug report.
Is your project checked in to a public github repo perhaps? Having access to the code would help reproduce the problem. If you can't share the code, perhaps you can narrow down the problem and share a self-contained piece of code that exhibits the problem?

I believe this should be fixed in the next release via https://github.com/microsoft/pyright/commit/706a5a4b9a20cd36a86ee31fbae1f1f800e65a63.

This issue has been fixed in version 2021.4.2, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202142-21-april-2021


test_frcnn.py not working?

The result_img didn't contain the bounding box. And when I print out true_x, true_y , .v..vv.... It just an empty list. Is there any way I can fix this?

I've also been facing the same problem, maybe the dataset is too small and the code is incapable of transfer learning

i use the voc2012, i've also been facing the same problem.

I went into checking the code of this file; found out that the bboxes dict is empty, thereafter, running a for loop on it will be nullified (which contains the bbox plotting). I guess reducing bbox threshold may fix it, tho I haven't tried it yet.

I train VOC2012 epochs=126 loss rpn classifier = 3.22 oscillate around 3 without falling.

Maybe the data set is too big? Or is there a problem with the parameters of the training?

My model is currently only able to detect people and train for 8 hours. The current box is not very accurate

Dataset is of 3471 images (originally of 267 images, increased by augmentation). Parameters of training are as default except I changed the learning rate to 0.01, and others optimizers, but same result.

@3ST4R I have tested this and it seems even if the bbox threshold is set to zero there still is no bbox.

I figured the issue out. The weight's are never loaded when doing inference
print('Loading weights from {}'.format(C.model_path))
model_rpn.load_weights(C.model_path, by_name=True)
model_classifier.load_weights(C.model_path, by_name=True)

model_rpn.compile(optimizer='sgd', loss='mse')
model_classifier.compile(optimizer='sgd', loss='mse')

all_imgs = []

classes = {}

bbox_threshold = 0.8

visualise = True

for idx, img_name in enumerate(sorted(os.listdir(img_path))):
    if not img_name.lower().endswith(('.bmp', '.jpeg', '.jpg', '.png', '.tif', '.tiff')):
        continue
    print(img_name)
    st = time.time()
    filepath = os.path.join(img_path,img_name)

    img = cv2.imread(filepath)

    X, ratio = format_img(img, C)

    if K.image_dim_ordering() == 'tf':
        X = np.transpose(X, (0, 2, 3, 1))

    # get the feature maps and output from the RPN
    [Y1, Y2, F] = model_rpn.predict(X)

    R = roi_helpers.rpn_to_roi(Y1, Y2, C, K.image_dim_ordering(), overlap_thresh=0.7)

    # convert from (x1,y1,x2,y2) to (x,y,w,h)
    R[:, 2] -= R[:, 0]
    R[:, 3] -= R[:, 1]

    # apply the spatial pyramid pooling to the proposed regions
    bboxes = {}
    probs = {}

    for jk in range(R.shape[0]//C.num_rois + 1):
        ROIs = np.expand_dims(R[C.num_rois*jk:C.num_rois*(jk+1), :], axis=0)
        if ROIs.shape[1] == 0:
            break

        if jk == R.shape[0]//C.num_rois:
            #pad R
            curr_shape = ROIs.shape
            target_shape = (curr_shape[0],C.num_rois,curr_shape[2])
            ROIs_padded = np.zeros(target_shape).astype(ROIs.dtype)
            ROIs_padded[:, :curr_shape[1], :] = ROIs
            ROIs_padded[0, curr_shape[1]:, :] = ROIs[0, 0, :]
            ROIs = ROIs_padded

        [P_cls, P_regr] = model_classifier_only.predict([F, ROIs])

model_classifier_only is used for inference but the weights are loaded for model_classifier

@collinarnett I also checked your post about weights not loading, and I tried that, still there is no bbox.
So, what should be a possible solution to this problem. As, I see the blogs where people getting it working absolutely fine, without any digging into the code, I wonder how.

@3ST4R have u fixed this problem? I'm facing this problem too.

I train VOC2012 epochs=126 loss rpn classifier = 3.22 oscillate around 3 without falling.

@3ST4R, @collinarnett  im facing with this problem too. Maybe you fix this problem..?

@mkvashennikov I haven't looked a this since 2019. I don't remember fixing it. I think I used another implementation.


custom request headers form submit

We use custom request headers on form submit for server side processing. Is there a way to add this?

Hi @mschipperheyn , got new version out with headers option. I chose not to go further than just the header object for now. Let me know if you get into a situation where more is needed :-)


Updated

Sorry for this PR, I've only taken commits that I needed... It won't be merged as it is, so I'm gonna close this one.
It seems there's an up-to-date version (for SF7) here : https://github.com/jfsenechal/DoctrineBehaviors/tree/sf7.0
I need this fix (https://github.com/KnpLabs/DoctrineBehaviors/pull/744) :grimacing:
@jfsenechal do you accept PR on your fork? I can open this one on your side...


[20.03] nixos/gitlab: Fix services.gitlab.enableStartTLSAuto

Motivation for this change
'toString false' results in an empty string, which, in this context,
is a syntax error. Use boolToString instead.
Fixes #86160
(cherry picked from commit c0a838df38c03cb269061905510c33dd071b517a)

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test gitlab