aws-cloudfront-apigateway-lambda can't be deployed elsewhere than in us-east-1

configure your profile to deploy in eu-west-1
run cdk deploy
it fails with the following error
The function must be in region 'us-east-1'. ARN: arn:aws:lambda:eu-west-1:204847680503:function:LandingPageStack-testcloudfrontapigatewaylambdaClo-1F9QY441H38IK:1 (Service: AmazonCloudFront; Status Code: 400; Error Code: InvalidLambdaFunctionAssociation; Request ID: 42fefc2e-52b1-4db1-90ae-b3d26b2cadaa)
Reproduction Steps

try to deploy this
new CloudFrontToApiGatewayToLambda(this, 'test-cloudfront-apigateway-lambda', {
  lambdaFunctionProps: {
      code: lambda.Code.fromAsset(`${__dirname}/lambda`),
      runtime: lambda.Runtime.NODEJS_12_X,
      handler: 'index.handler'
  }
});

Error Log
4:56:08 PM | CREATE_FAILED        | AWS::CloudFront::Distribution | testcloudfrontapig...stribution4AF2BFE4
The function must be in region 'us-east-1'. ARN: arn:aws:lambda:eu-west-1:204847680503:function:LandingPageStack-testcloudfrontapigatewaylambdaClo-1F9QY441H38IK:1 (Service: AmazonCloudFront; Status Code: 400; Error Code: InvalidLambdaFunctionAssociation; Request ID: 42fefc2e-52b1-4db1-90ae-b3d26b2cadaa)
    new CloudFrontWebDistribution (/home/bouteru/repos/landing-page/node_modules/@aws-cdk/aws-cloudfront/lib/web_distribution.ts:871:26)
    \_ Object.CloudFrontDistributionForApiGateway (/home/bouteru/repos/landing-page/node_modules/@aws-solutions-constructs/core/lib/cloudfront-distribution-helper.ts:146:66)
    \_ new CloudFrontToApiGateway (/home/bouteru/repos/landing-page/node_modules/@aws-solutions-constructs/aws-cloudfront-apigateway/lib/index.ts:66:16)
    \_ new CloudFrontToApiGatewayToLambda (/home/bouteru/repos/landing-page/node_modules/@aws-solutions-constructs/aws-cloudfront-apigateway-lambda/lib/index.ts:106:51)
    \_ new LandingPageStack (/home/bouteru/repos/landing-page/lib/landing-page-stack.ts:9:5)
    \_ Object.<anonymous> (/home/bouteru/repos/landing-page/bin/landing-page.ts:7:1)
    \_ Module._compile (internal/modules/cjs/loader.js:1137:30)
    \_ Module.m._compile (/home/bouteru/repos/landing-page/node_modules/ts-node/src/index.ts:858:23)
    \_ Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    \_ Object.require.extensions.<computed> [as .ts] (/home/bouteru/repos/landing-page/node_modules/ts-node/src/index.ts:861:12)
    \_ Module.load (internal/modules/cjs/loader.js:985:32)
    \_ Function.Module._load (internal/modules/cjs/loader.js:878:14)
    \_ Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)

Environment

**CDK CLI Version      : 1.60.0 **
CDK Framework Version: 1.60.0
**AWS Solutions Constructs Version     : 1.60.0 **
OS                   : Ubuntu LTS 18.04
Language             : Typescript

Other

This is :bug: Bug Report

And if it's a known limitation, it is not documented  in  https://docs.aws.amazon.com/solutions/latest/constructs/aws-cloudfront-apigateway-lambda.html?did=cs_card&trk=cs_card

Thanks for opening the issue. This pattern, by default, deploys a Lambda@Edge function for injection of best practice HTTP security headers in all responses from CloudFront WebDistribution, which fails to deploy in any region other than us-east-1. There is a limitation on Lambda@Edge function to exit in us-east-1 region for it to be triggered from Cloudfront, as documented here
While we come up with a fix for it, the workaround would be to disable the Lambda@Edge function deployment, we will update the documentation accordingly
new CloudFrontToApiGatewayToLambda(this, 'test-cloudfront-apigateway-lambda', {
  lambdaFunctionProps: {
      code: lambda.Code.fromAsset(`${__dirname}/lambda`),
      runtime: lambda.Runtime.NODEJS_12_X,
      handler: 'index.handler'
  },
  insertHttpSecurityHeaders: false
});

We will look into the recently released Cloudfront Functions (replacing Lambda@Edge function) to insert the best practices HTTP security headers
https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/example-function-add-security-headers.html

Implementing the CloudFront constructs with CloudFront Functions can be followed in this issue.


Add Contiv to CNI supported networking

I'm happy to push the button on this. @jainvipin, a minor, procedural thing: would you mind re-pushing the commit with a commit message like "README: ...". Just so we conform with the established convention.

@squaremo thanks; done.

Thanks Vipin!


error on large mbox file

gives error bufio.Scanner: token too long

I'd guess that the buffer of your mbox.Scanner instance is too small. Try to increase your buffer size.
To double the buffer size you'd do something like this (untested code, written out of my head):
s := mbox.NewScanner(...)

bufsize := 2*bufio.MaxScanTokenSize
buf := make([]byte, bufsize)
s.Buffer(buf, bufsize)

thx, I actually increases the buffer size to 10 MiB

Sorry for answering late. Did you fix the issue by increasing the buffer size?

Yeah, it works, thx

Cool, so I'll close this issue.


[BUG] ImBlocker 1.0.10 crash in MC1.16.4

Describe the bug
Game crash when using this mod in mc1.16.4.
I have tried to disable all other mods, still crash.
For details, check the link at last.
Client Software
MultiMC(MC: 1.16.4)
mods
shows in the crash log at last.
To Reproduce
Just use this mod in MC version 1.16.4
Expected behavior
Game should be launched without error.
Screenshots
No need for screenshots.
Environment(please complete the following information):

OS: Windows10 20H2 (19042.662)
JRE: 1.8.0_251

Additional context
crash log with other mods
crash log without other mods

BTW, I used the latest fabric loader, which is 1.10.8 now.

同 #13 , 打扰了，但希望还是能尽快修复一下

请查看1.0.10版本。

重新下载后可以正常使用了，所以是更新过一次文件然后没有换版本号？我看版本都是1.0.10以为就是最新的了...


OCPVE-616: fix: add check of correct lv state of thin-pool when vg is already created

This introduces new checks when the LV was already created as a thin pool to ensure correct status updates even after the VG was setup initially.
Checks include:

LV is present
LV is of type Thin-Pool and was not wrongly converted
lv is active
has <95% metadata usage (as LVM will crash on most I/O if on entire thin-pool if there is a metadata volume overflow, as by consulting the man-page of lvm: Metadata space exhaustion can lead to inconsistent thin pool metadata and inconsistent file systems, so the response requires offline checking and repair.), allowing users to still circumvent with lvextend --poolmetadatasize in case of overprovisioning. This allow users to avoid having to reboot the node and repair the deactivated LV

Codecov Report

Merging #381 (aa76c61) into main (a962b90) will increase coverage by 39.48%.
Report is 12 commits behind head on main.
The diff coverage is 68.34%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #381       +/-   ##
===========================================
+ Coverage   16.59%   56.07%   +39.48%
===========================================
  Files          24       26        +2
  Lines        2061     2247      +186
===========================================
+ Hits          342     1260      +918
+ Misses       1693      896      -797
- Partials       26       91       +65

Files Changed
Coverage Δ

pkg/vgmanager/lvm.go
52.03% <ø> (+4.06%)
:arrow_up:

pkg/vgmanager/vgmanager_controller.go
6.46% <43.18%> (+6.46%)
:arrow_up:

pkg/cluster/leaderelection.go
57.57% <57.57%> (ø)

pkg/vgmanager/devices.go
72.86% <62.50%> (-1.33%)
:arrow_down:

pkg/vgmanager/lv_attr.go
92.59% <92.59%> (ø)

controllers/lvmcluster_controller.go
60.00% <100.00%> (+60.00%)
:arrow_up:

controllers/topolvm_controller.go
94.14% <100.00%> (+94.14%)
:arrow_up:

... and 9 files with indirect coverage changes

/lgtm
/approve

/test lvm-operator-e2e-aws


Remove Ops.ALU

Ops.ALU is not used anymore, which used to be arg, is now op.
There were two occurrences in tests that still referenced Ops.ALU, I replaced them with GroupOp.ALU

Woo thanks!


Callback-Based Response Retrieval

One of the limitation in lua-https is that it's not possible for application to create download progress bars on it (if the Content-Length header is available). This is because https.request will wait until all the response data is retrieved.
My proposal is to add optional 3rd and 4th parameter callback and context. Callback is defined as these fields:
local callback = {
    -- `context` in here means user-supplied data (4th-parameter), which can be anything.
    response = function(context, status, headers)
        -- Called when HTTP status code and headers has been retrieved. Called once.
        -- `status` is HTTP status code
        -- `headers` is HTTP headers in **all lowercase** for the keys.
    end,
    body = function(context, data)
        -- Called when new HTTP body data arrives. Called multiple times as new data arrives.
        -- `data` is response data as Lua string.
        -- Return "falsy" value and additional error message (default is "aborted") to abort the request
        return true -- success
        return false, "aborted" -- failure
    end,
    complete = function(context, err)
        -- Called when data has been transferred, or an error occurs.
        -- `err` will be the error message, or `nil` if everything worked as intended.
    end,
}

Example usage:
local data = {current = 0, length = 0}

https.request("https://love2d.org", {}, {
    -- `context` in here means user-supplied data (4th-parameter), which can be anything.
    response = function(context, status, headers)
        print("HTTP status code", status)
        if headers["content-length"] then
            context.length = tonumber(headers["content-length"]) or 0
        end
    end,
    body = function(context, data)
        context.current = context.current + #data
        if context.length > 0 then
            print(string.format("Received data %d bytes (%.2f)", #data, context.current * 100 / context.length))
        else
            print(string.format("Received data %d bytes", #data))
        end
    end,
    complete = function(context, err)
        if err then
            print("Download error", err)
        else
            print("Download completed!")
        end
    end,
}, data)

As an additional feature/requirement, the callback table can be a class object (not instance) by retrieving the function list using Lua C function that invokes metamethod and the context can be the class instance itself such that when a class is declared like this:
local MyDownloader = class "MyDownloader"

function MyDownloader:response(status, headers)
end

function MyDownloader:body(data)
    return true
end

function MyDownloader:complete(err)
end

Doing something like this simply works and calls the appropriate functions.
local dlinstance = MyDownloader() -- new class instance
https.request("https://love2d.org", {}, MyDownloader, dlinstance)

The return value of https.request when using this variant would be questionable.

Returning the status code, body, and the headers will preserve backward compatibility, but at same time make things redundant (the library has to keep everything until the function returns instead of discarding them).
Returning only true or false + error message (assert-compatible style) means less redundancy, but breaks backward compatibility.

I probably can do this, but the question becomes "should this is be done?" and/or "is this valid usecase to justify the feature addition?".

Is it possible to make it api-compatible with luasocket like luasec and lapis do? I think using a single API will be more convenient and clearer than creating a new one.

No, it's not possible to do so.
The intention of lua-https is clear: to make HTTP(S) request using OS-provided or popular library API. If lua-https is modified to have similar API as LuaSec then you're looking for TLS alone. Furthermore, if OS decided to support future HTTP version such as HTTP3 in the future, lua-https doesn't require any change to the API.
Meanwhile if you're using LuaSec-style API, then implementing HTTP2 is difficult, if not impossible. You most likely stuck in HTTP 1.1 protocol.

Hi, interested to know what the state of this features is. Is it possible to use lua-https for partial responses using a callback to e.g. implement streaming openai api responses?
If not please do advise which library would be my best bet for this functionality.
Thank you so much!

There is no callback-based API currently implemented. Also, while I'm interested in implementing something like this and other improvements for general use, I am not interested in helping with AI/LLM-related topics.

I can understand that. However the openai usage was just an example I used to explain.
Could you perhaps point me in the right direction of where to find the desired functionality of receiving chunked responses in lua please? Much appreciated!


Android crash on load splash screen

Hi
I get this error on android (RN version 0.30.0)

This happens because I invoke the call to
new RCTSplashScreenPackage(MainActivity.activity)

before calling
    @Override
    protected String getMainComponentName() {
        activity = this;
        return "app";
    }

so MainActivity.activity is null.
Anyone experiencing this as well?

Yes I'm having the exact same issue.

@pikusinski Thanks, I've seen your reply only now. have you tried it? Does it work as expected?


Fix minimum/maximum date validation

What is the context of this PR?
There is a bug that is stopping runner from evaluating minimum and maximum values correctly.
This bug may have been introduced when we implemented repeating sections, as the code that evaluates the answer value for the minimum date is missing the list_item_id as an argument. The validation still works on Census Individual surveys.
We need to fix date_form.py so that the list_item_id is passed to the method that retrieves the answer value.
How to review
Is this a viable solution/temporary solution? Does runner need to be refactored?

 Fix minimum and maximum date validation


[Bug]: stopBackup should handle disconnects

Is there an existing issue already for this bug?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[X] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[X] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
<EMAIL_ADDRESS>Version
older in 1.22.x
What version of Kubernetes are you using?
1.29
What is your Kubernetes environment?
Cloud: Amazon EKS
How did you install the operator?
YAML manifest
What happened?
Some backups are kept on started state blocking newer backups. One of the causes seems to be that connection is closed within the backupConnection struct and there is no re-connecting strategy. Sample log:
{
  "level": "error",
  "ts": "2024-05-05T10:44:04Z",
  "msg": "while stopping PostgreSQL physical backup",
  "step": "stop",
  "logging_pod": "mycluster-1",
  "error": "sql: connection is already closed",
  "stacktrace": "github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:128\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres/webserver.(*backupConnection).stopBackup.func2\n\tpkg/management/postgres/webserver/backup_connection.go:214\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres/webserver.(*backupConnection).executeWithLock\n\tpkg/management/postgres/webserver/backup_connection.go:94\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres/webserver.(*backupConnection).stopBackup\n\tpkg/management/postgres/webserver/backup_connection.go:212"
}

https://github.com/cloudnative-pg/cloudnative-pg/blob/ae692bf86f96467f8ef97eee2ec97e0c1cfb4b5c/pkg/management/postgres/webserver/backup_connection.go#L213
Not sure if my reasoning is right but looks like a reconnect could solve the issue we are facing.
Cluster resource
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @csdaraujo, sadly, reconnecting wouldn't solve the issue.
The instance manager should allow a new backup to be started, and this is something we think we have fixed.
Is it possible for you to try to replicate the bug using the latest operator version?

Hello @csdaraujo, sadly, reconnecting wouldn't solve the issue. The instance manager should allow a new backup to be started, and we think we have fixed this.
Can you try to replicate the bug using the latest operator version?
Thank you very much for your time and report.

Hi, @armru. After leaving the new released version for two weeks I can confirm that there are no more pending/blocking backups so far. Only issue that was identified so far seem related to the issue reported:
{"level":"error","ts":"2024-07-01T10:45:34Z","msg":"while stopping PostgreSQL physical backup","step":"stop","logging_pod":"xyz","error":"sql: connection is already closed","stacktrace":"github.com/cloudnative-pg/cloudnative-pg/pkg/management/log.(*logger).Error\n\tpkg/management/log/log.go:128\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres/webserver.(*backupConnection).stopBackup.func2\n\tpkg/management/postgres/webserver/backup_connection.go:214\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres/webserver.(*backupConnection).executeWithLock\n\tpkg/management/postgres/webserver/backup_connection.go:94\ngithub.com/cloudnative-pg/cloudnative-pg/pkg/management/postgres/webserver.(*backupConnection).stopBackup\n\tpkg/management/postgres/webserver/backup_connection.go:212"}

Do you think it is worth keeping this open?
Thank for keeping an eye!

Sorry. Forgot to leave the error message on the Backup object status field: can't execute snapshot backup: trying to stop backup with name: , while reconciling backup with name: xyz-backup-20240701104525"

Yeap. All good! 👏


Update the App Service Application Settings names

To match the structure of the appsettings.json file and how the application loads these configurations all of the application settings in the app service need to be prefixed with FraudProtectionSettings: . Without this the solution results in a token code error.

@Brand-Wylie : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Approved. Thanks!

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Sidebar text color ignored when highlighted in mobile

Setup

Browsers and versions: Safari on ios 13.7 and earlier
MediaWiki version: 1.30 and 1.31
Pivot version: 2.1 and 2.2
occurs on Pivot demo website

Issue
From a mobile, highlighting a side bar menu item changes the background colour but not the text color of the link.
Pivot.css v2.2 code
@@ -798,6 +815,7 @@ ul.side-nav label {  	background: #517398;      color: #fff;      padding: .25em .5em;      pointer-events: none; }

To change the text color, you have to select the  tag within the  tag, so in your case ... ul.side-nav label a ...
Hope this helps.


“Install and Set Up kubectl…” tasks mention fixed bug

try to resolve https://github.com/kubernetes/website/issues/42553

/lgtm
/approve


[question] Revalidate field after add error to error bag

Vue v2.5.17
Vee Validate v2.1.0-beta.9

Hey there, I want to know if is possible "revalidate" all fields inside a scope after add errors dynamically using error.add.
My code
// Add the field error dynamically
 this.errors.add({ field, msg, scope });

// validate if all fields in scope are valid (used to disable a button)
Object.values(scope).every(value => value.valid);

My problem is after I add the field error to error bag, the field continue valid but would should be invalid.
Thank you!

From what I can tell by your code sample, after adding your error you want to check if there are any errors inside that scope, you can do that using either:
errors.has('scope.*');

errors.any('scope'); // currently bugged and will be fixed in next release.

Thanks @logaretm, errors.has('scope.*') worked fine for me


Support scalable_msize() or similar function for memory pools API

Hi,
I'm using TBB API related to pool management:
https://github.com/01org/tbb/blob/ab775e45cbda7115de05fa5465321f6324b2ac6c/include/tbb/scalable_allocator.h#L185-L195
I was trying to obtain size of block of memory allocated by API mentioned above.
I was trying to use scalable_msize() function, but unfortunately when I used debug version of TBB library to assure that I'm using library correctly I hit the assert:
https://github.com/01org/tbb/blob/314792356bf75f4a190277536aea543b9b6b310b/src/tbbmalloc/frontend.cpp#L2611
Could You please provide support function in official API for memory pool management to get the information about of allocated memory block using memory pool API (e.g. pool_malloc() function )

Hi @michalbiesek, notifying you that the problem was resolved by introducing new Memory Pool API:
pool_msize(MemoryPool *memPool, void *object)

It works just like scalable_msize but accepts a pool pointer, from which this object was allocated. In debug, this function also checks whether this pointer was really allocated from the provided memory pool.


Unable to install Specter on 1.6.1

There seems to be a few things missing during setup

dialogcancel(0)
Loop Setting unchanged.
RTL Webinterface Setting unchanged.
BTC-RPC-Explorer Setting unchanged.
Cryptoadvance Specter Setting changed ..
bonus.cryptoadvance-specter.sh on
--> INSTALL Cryptoadvance Specter ***
--> Enable wallets in Bitcoin Core
Multiwallet is active and wallet.dat is used.
The bitcoin core wallet is already on
--> Installing prerequisites
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'libusb-1.0-0-dev' for regex 'libusb-1.0.0-dev'
The following package was automatically installed and is no longer required:
libbluetooth3
Use 'sudo apt autoremove' to remove it.
The following additional packages will be installed:
libusb-1.0-doc python3-virtualenv
The following NEW packages will be installed:
libffi-dev libudev-dev libusb-1.0-0-dev libusb-1.0-doc python3-virtualenv virtualenv
0 upgraded, 6 newly installed, 0 to remove and 128 not upgraded.
Need to get 110 kB/594 kB of archives.
After this operation, 2,435 kB of additional disk space will be used.
Err:1 http://raspbian.raspberrypi.org/raspbian buster/main armhf libudev-dev armhf 241-7~deb10u4+rpi1
404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://raspbian.raspberrypi.org/raspbian/pool/main/s/systemd/libudev-dev_241-7~deb10u4+rpi1_armhf.deb  404  Not Found [IP: <IP_ADDRESS> 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

The installation also seems to get a little confused (doesn't detect the failures). Blitz "thinks" it successfully installed, but trying to connect to the specter IP/port displayed on the screen doesn't actually work.

Specter installs got updated already in released v1.6.2 ... v1.6.3 will even have a more updated version. Closing issue.


exhibitor: bump

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (required)

D2IQ-ID JIRA title / short description.

Related tickets (optional)

D2IQ-ID JIRA title / short description.

@mesosphere-mergebot test teamcity/dcos/build/dcos teamcity/dcos/build/tox

@mesosphere-mergebot test all

@mesosphere-mergebot test all

@mesosphere-mergebot test all


Roll engine 7892c69445d4..59b5a0cf7676 (1 commits)

git@github.com:flutter/engine.git/compare/7892c69445d4...59b5a0cf7676
git log 7892c69445d4..59b5a0cf7676 --no-merges --oneline
2019-11-16<EMAIL_ADDRESS>Roll src/third_party/dart fdb9d19826..d6b0a27665 (19 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.

This seems to have regressed hot reload performance.


Rule request: Allow omitted return type for implementations of abstract methods

For classes that extend traits or abstract classes, the return type of a public method is redundant. In other words:
trait Foo {
  def bar: Int
}

class Bar extends Foo {
  def bar = 1
}

The method bar in the Bar class doesn't need to have the type annotation, as it is already defined in the Foo trait.
On the other hand, it would still be nice to enable this rule to enforce/suggest that public methods that aren't implementations must/should have the type annotation.

This isn't possible in a generic way in Scalastyle. It only knows about details in the current file.


Allow axis events to be updated. fixes #308

what?
Allow updating axis eventhandlers.
https://github.com/highcharts/highcharts/pull/15658 fixed updating axis evenhandlers. This PR just adds code to call updates for events.
I have a feeling this might be a breaking change, but I am not sure. At least it requires highcharts 9.1.1 to work properly.
fixes #308

Codecov Report

Merging #333 (863e006) into master (7e0baae) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   89.76%   89.79%   +0.02%
==========================================
  Files          82       82
  Lines        1094     1097       +3
  Branches      213      213
==========================================
+ Hits          982      985       +3
  Misses        100      100
  Partials       12       12

Impacted Files
Coverage Δ

...s/react-jsx-highcharts/src/components/Axis/Axis.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0baae...863e006. Read the comment docs.

In combination with #335, seems like this should be a major version.

I'd like to also drop prop-types at the same time. The typescript typings are much more complete. Is that okay?


Control Layer Output not flipped

The control layer SVG is not flipped horizontally, making milling incorrect & not lined up properly.

Same as #67 - closing this


Fix typos in README, docs and docstrings

Hi @yinleon, are there any issues with this PR? If so, please let me know.


docs: Add documentation to core (and some other items).

This closes #265 and #267 (for now).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 92.594%

Files with Coverage Reduction
New Missed Lines
%

imap-types/src/core.rs
2
88.89%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9064

Relevant Lines:
9789

💛  - Coveralls


Failure during import of large (~3GB) S3 files

It looks to me like the s3 copier may need to block until the upload ID is created. Sometimes the first few parts will fail copying, but the rest will succeed:
Initiated multipart copy from 's3://cactus-alignments/tenway--Chimp' to 's3://cactus-jcarmstr-tenway-pp--files/86d1d2f8-6eb2-4dfb-a6eb-171f0b9b8a1a'.
Failed to copy part number 12:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/toil/jobStores/aws/jobStore.py", line 96, in copyPart
    headers=headers)
  File "/usr/local/lib/python2.7/dist-packages/boto/s3/multipart.py", line 306, in copy_part_from_key
    query_args=query_args)
  File "/usr/local/lib/python2.7/dist-packages/boto/s3/bucket.py", line 888, in copy_key
    response.reason, body)
S3ResponseError: S3ResponseError: 404 Not Found
<Error>NoSuchUpload<Message>The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.</Message><UploadId>fVDG2y81z0Ptix9dK0cwu.K228.m8gbA8$
faZOAhWMrRbxd_xkvBRpqJu3kzSb8Dqg4j9i3v3H9VOGL36wY6BSVCUH6I8cOZFop9jV52weUk5Jp2Def_9pTfxJMRtdKZfTF1J.Iuztw_Yz.vYrXSR2.V_pyTapP6MU.ESiRFNyA-</UploadId><RequestId>116C4E2F81B7F0B4</RequestId><HostId>B6cGk8MZb7uowe$
/Vr4mjvEORiQ42lebHtaRFHrq5SxwqNddoMDoY15W98oibpVJ8nrOOOvM62U=</HostId></Error>
Failed to copy part number 10:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/toil/jobStores/aws/jobStore.py", line 96, in copyPart
    headers=headers)
  File "/usr/local/lib/python2.7/dist-packages/boto/s3/multipart.py", line 306, in copy_part_from_key
    query_args=query_args)
  File "/usr/local/lib/python2.7/dist-packages/boto/s3/bucket.py", line 888, in copy_key
    response.reason, body)
S3ResponseError: S3ResponseError: 404 Not Found
<Error>NoSuchUpload<Message>The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.</Message><UploadId>fVDG2y81z0Ptix9dK0cwu.K228.m8gbA8$
faZOAhWMrRbxd_xkvBRpqJu3kzSb8Dqg4j9i3v3H9VOGL36wY6BSVCUH6I8cOZFop9jV52weUk5Jp2Def_9pTfxJMRtdKZfTF1J.Iuztw_Yz.vYrXSR2.V_pyTapP6MU.ESiRFNyA-</UploadId><RequestId>9F40C320BE4F703C</RequestId><HostId>yb7FrZMlM7NvBB$
jTqwomrxUbo8z3cavVuCaRX8X9cLS9L9c9G54p3B/o+hwOvBI0jQWoRgpFps=</HostId></Error>
Failed to copy part number 18:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/toil/jobStores/aws/jobStore.py", line 96, in copyPart
    headers=headers)
  File "/usr/local/lib/python2.7/dist-packages/boto/s3/multipart.py", line 306, in copy_part_from_key
    query_args=query_args)
  File "/usr/local/lib/python2.7/dist-packages/boto/s3/bucket.py", line 888, in copy_key
    response.reason, body)
S3ResponseError: S3ResponseError: 404 Not Found
<Error>NoSuchUpload<Message>The specified upload does not exist. The upload ID may be invalid, or the upload may have been aborted or completed.</Message><UploadId>fVDG2y81z0Ptix9dK0cwu.K228.m8gbA8$
faZOAhWMrRbxd_xkvBRpqJu3kzSb8Dqg4j9i3v3H9VOGL36wY6BSVCUH6I8cOZFop9jV52weUk5Jp2Def_9pTfxJMRtdKZfTF1J.Iuztw_Yz.vYrXSR2.V_pyTapP6MU.ESiRFNyA-</UploadId><RequestId>DDAE108168AD081A</RequestId><HostId>lvWhbj8EC8yBjZ$
+s2pRdy9dMN7VpnKIBEF+MSnLoxJxLNwAN33a0CF8rkQE0C7d685m/ZJy4XU=</HostId></Error>
Successfully copied part 8 of 63.
Successfully copied part 14 of 63.
Successfully copied part 4 of 63.
Successfully copied part 13 of 63.
Successfully copied part 3 of 63.

Interesting.. Is this on a relatively up-to-date Toil version? Previously we weren't blocking on uploads but I believe I fixed that issue. I'll see if I can dig up the issue/PR to see if they're related to this.

Hi CJ,
Sorry for the long delay. My toil version has everything in master up to ~ April 1st. I had looked through the unmerged commits and didn't see anything that seemed to be relevant at first glance.
Regardless, I wasn't able to trigger this bug on the latest toil master branch. So it's gotta be something in the unmerged commits, or some conflict that I resolved improperly. Either way, it's on my end, so I'm closing this.


Out of memory when opening a PHP project

VSCode Version: 1.19.1
OS Version: Windows 10 Professional

Steps to Reproduce:

This happens when I open a folder with Laravel a project
This happens only if I have PHP Intellisence 2.2.2 installed. I've removed all my extensions, but when I installed this one, the memory when up.

Reproduces without extensions: No

The problem is found by the author of the extension


Can't connect to Phoenix

hbase-2.2.4
phoenix-hbase-2.1-5.1.2-bin
DBeaver 21.3.5
I used phoenix to connect to hbase in centos successfully.
as follows：
[xxx]$ ./sqlline.py 192.168.xx.xx:2181:/hbase
Setting property: [incremental, false]
Setting property: [isolation, TRANSACTION_READ_COMMITTED]
issuing: !connect -p driver org.apache.phoenix.jdbc.PhoenixDriver -p user "none" -p password "none" "jdbc:phoenix:<IP_ADDRESS>:2181:/hbase"
Connecting to jdbc:phoenix:<IP_ADDRESS>:2181:/hbase
Connected to: Phoenix (version 5.1)
Driver: PhoenixEmbeddedDriver (version 5.1)
Autocommit status: true
Transaction isolation: TRANSACTION_READ_COMMITTED
sqlline version 1.9.0
0: jdbc:phoenix:192.168.xx.xx:2181:/hbase>
But int windows10 and DBeaver 21.3.5
When I finished editing the driver settings to phoenix-client-hbase-2.1-5.1.2.jar.
Press the test connection, as follows：
Unexpected driver error occurred while connecting to the database
java.lang.RuntimeException: class org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback not org.apache.hadoop.security.GroupMappingServiceProvider
java.lang.RuntimeException: class org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback not org.apache.hadoop.security.GroupMappingServiceProvider
class org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback not org.apache.hadoop.security.GroupMappingServiceProvider
class org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback not org.apache.hadoop.security.GroupMappingServiceProvider
Then Restart DBeaver and connect:
Always  loading : connect to jdbc:phoenix:192.168.xx.xx:2181:/hbase : Connecting Main (0%)

It works with predefined driver but not the latest version (latest version doesn't work in Java 11)
Try version 4.14.1-HBase-1.4 :

I will set this driver version as default in the next DBeaver version

verified


Implemented restoring search query

When user enters a search query for a *ListFragment the query will
now be restored on device configuration changes and when
*ListFragment is restored from the backstack.
Fixes issue #161

Needs more testing.


GtkSourceView mapping missing

Hi,
I am trying to search around but not seeing the gtksourceview mapping is implemented. I might miss places, not sure if it is not yet done, or any plan to make it happen?
See the sibling project https://godoc.org/github.com/pekim/gobbi/lib/gtksource whihc has it, but as it warns me it is not as matured like gotk3 , I hope gotk3 has it...

Hi,
you look for syntax highlighting or other stuff provided by GtkSourceView ?
p.s: GtkSourceView is not yet implemented in gotk3 ...

HI thanks, I am looking for syntax highlighting at first and might be the print utilities there as well.

I tried to take gobbi a bit and found that it is so different from gotk3, it would be lots of effort to port from gotk3 to gobbi. From pygtk3 perspective gotk3 is so easy to work with, thus I hope gtksourceview is available.

I can help you for syntax highlighting, i've made this PR about highlight support for textview via pango, it use chroma too.
hope this help.

That would be a awesome approach. Thanks - will try it very soon.

Thanks a lot, I implement mine based on your suggestions and it works perfectly.

perfect !
If i make a new version with more faster processing i will inform you.


ngDocs: angular.mock.dump is not injected to window

https://docs.angularjs.org/api/ngMock/function/angular.mock.dump
the docs now implys dump function is available on window. it's not true

Hm, I'm using it pretty often. Are you sure you have the ngMock module included when you try to call it?

@Narretz, you probably mean that it is available as window.angular.mock.dump, but @e-cloud is right: it is not available on window (window.dump) as documented.
Bug or docs issue ?
Since it isn't necessary on window, let's fix the docs to avoid breaking tests where window.dump is defined by the developer.

There are some situations I've found where not all ngMock globals are not truly published to window, mainly when transpilers like TypeScript or Babel are involved.
When using TypeScript, I've found that I've had to use angular.mock.module, but strangely inject worked fine.

This is different though. We are not publishing angular.mock.dump on window, so transpilers are hardly to blame :)
I can see why module would get overwritten with transpilers that try to support CommonJS and put things on module.exports :smiley:

Ah, I mistook the issue...and that makes sense, I think I knew that but forgot - sorry for the diversion!


Basic sitemap class

Added a basic Sitemap class using the Atom one as a model

Thanks for the PR, but we're trying to remove werkzeug.contrib. This would be good as a separate package if you or anyone else is interested.


cannot import name 'LLM' from 'vllm' (unknown location)

I am building vllm from source, and I am unable to import LLM from vllm.

from vllm import LLM, SamplingParams

It was working fine yesterday(I built it from source and checked around 16 hours ago), I'm using the older commit for the time being.


this$1 is undefined

Versions

vee-validate: 2.1.0-beta.0
vue: 2.5.2

Describe the bug
once i follow guide from official documentation, atached vee-validate to Vue, added markup to html,
and onnce i open browser (mozilla firefox) i see "this$1 is undefined" error
To Reproduce
Steps to reproduce the behavior:

vue init webpack testvee
cd testvee
npm install -s vee-validate
import VeeValidate from 'vee-validate'
Vue.use(VeeValidate)
{{errors.first('name')}}
npm run dev
open localhost:8080 in browser
open console, see error

Expected behavior
work without errors in console and validate input
Demo Link
https://drive.google.com/file/d/1ndKRJnftEcyKKyhHYaWiNTqGgb0ZitgB/view?usp=sharing
https://drive.google.com/file/d/19sj1HVbmIuWNWLv9ewBhvWgG5N_lLQux/view?usp=sharing
If applicable, add a minimal demo link to help explain your problem. You can use jsfiddle or Codesandbox.
Desktop (please complete the following information):

OS: ubuntu 16.04
Browser mozilla firefox
Version latest

Additional context
screenshot and my sources
https://drive.google.com/file/d/1ndKRJnftEcyKKyhHYaWiNTqGgb0ZitgB/view?usp=sharing
https://drive.google.com/file/d/19sj1HVbmIuWNWLv9ewBhvWgG5N_lLQux/view?usp=sharing

2.0.9 works ok for me

duplicate of #1360


processor with config breaks

UPDATE: seems to be an issue of plugins in config, hex colors seems to be ok
actually do you get it in browser console aswell? if i add config to options like shown below, i get. without config everything is fine
Uncaught TypeError: can't access property "handler", e is null
source config parsed with following loading script
require(require('path').resolve(windi.config.js))
module.exports = {
  plugins: [
    require('windicss/plugin/typography'),
    require('windicss/plugin/forms'),
    require('windicss/plugin/aspect-ratio'),
    require('windicss/plugin/line-clamp'),
    require('windicss/plugin/filters'),
    require('windicss/plugin/scroll-snap'),
  ],
};

to
window.windicssRuntimeOptions = {
  extractInitial: false,
  preflight: false,
  mockClasses: true,
  config: {
     "plugins":[
        null,
        {

        },
        {
           "config":{
              "theme":{
                 "aspectRatio":{

                 }
              },
              "variants":{
                 "aspectRatio":[
                    "responsive"
                 ]
              }
           }
        },
        {
           "config":{
              "theme":{
                 "lineClamp":{

                 }
              },
              "variants":{
                 "lineClamp":[
                    "responsive"
                 ]
              }
           }
        },
        {
           "config":{
              "theme":{
                 "filter":{
                    "none":"none",
                    "grayscale":"grayscale(1)",
                    "invert":"invert(1)",
                    "sepia":"sepia(1)"
                 },
                 "backdropFilter":{
                    "none":"none",
                    "blur":"blur(20px)"
                 },
                 "blur":{
                    "none":"none"
                 }
              },
              "variants":{
                 "filter":[
                    "responsive"
                 ],
                 "backdropFilter":[
                    "responsive"
                 ]
              }
           }
        },
        {
           "config":{
              "theme":{
                 "snapMargin":{

                 },
                 "snapPadding":{

                 }
              },
              "variants":{
                 "snapMargin":[
                    "responsive"
                 ],
                 "snapPadding":[
                    "responsive"
                 ]
              }
           }
        }
     ]
  }
}

seems to be an issue of plugins in config, hex colors seems to be ok

@alexanderniebuhr, can you provide an example of how to use this using custom config and plugin?

https://github.com/windicss/svelte-windicss-preprocess/blob/main/src/index.ts#L128-L153

@alexanderniebuhr, Thanks got the custom config part, I am facing an issue with plugin config. Here is my config provided and written in script tag of Html file.
// const generateSolidButtons = (colors, theme) => {
//   const returnValue = {}

//   for (const [_, color] of colors.entries()) {
//     returnValue[`.btn-${color}`] = {
//       'backgroundColor': theme(`backgroundColor.${color}.500`),
//       'color': theme('colors.white'),
//       '&:hover': {
//         backgroundColor: theme(`backgroundColor.${color}.600`),
//       },
//     }
//   }

//   return returnValue
// }

// const generateLightButtons = (colors, theme) => {
//   const returnValue = {}

//   for (const [_, color] of colors.entries()) {
//     returnValue[`.btn-${color}-light`] = {
//       'backgroundColor': theme(`backgroundColor.${color}.100`),
//       'color': theme(`colors.${color}.500`),
//       'backgroundOpacity': theme('backgroundOpacity.50'),
//       '&:hover': {
//         backgroundOpacity: theme('backgroundOpacity.100'),
//       },
//       '&:active': {
//         backgroundColor: theme(`backgroundColor.${color}.200`),
//       },
//     }
//   }

//   return returnValue
// }

window.windicssRuntimeOptions = {
  mockClasses: true,
  targetElementId: 'watcher',
  config: {

    mode: 'jit',
    theme: {
      extend: {
        colors: {
          primary: {
            100: '#e4e1fe',
            200: '#cac3fd',
            300: '#ada4fa',
            400: '#968cf6',
            500: '#7367f0',
            600: '#554bce',
            700: '#3c33ac',
            800: '#27208b',
            900: '#181373',
          },
          success: {
            100: '#f1fcd4',
            200: '#dff9aa',
            300: '#c4ee7d',
            400: '#a7de5a',
            500: '#7fc92a',
            600: '#64ac1e',
            700: '#4b9015',
            800: '#36740d',
            900: '#266008',
          },
          warning: {
            100: '#fff4d1',
            200: '#ffe5a3',
            300: '#ffd375',
            400: '#ffc152',
            500: '#ffa319',
            600: '#db8212',
            700: '#b7650c',
            800: '#934a07',
            900: '#7a3804',
          },
          danger: {
            100: '#ffe6d9',
            200: '#ffc7b4',
            300: '#ffa28e',
            400: '#ff7e72',
            500: '#ff4444',
            600: '#db3140',
            700: '#b7223c',
            800: '#931536',
            900: '#7a0d32',
          },
        },
        fontFamily: {
          headings: ['Montserrat', 'sans-serif'],
          content: ['Montserrat', 'sans-serif'],
        },
        container: {
          padding: '2rem',
          center: true,
        },
      },
      sprinkleConfig: {
        borderRadius: 'lg',
      },
    },
    // plugins: [plugin(({ addComponents, theme }) => {
    //   addComponents({
    //     '.btn': {
    //       'borderRadius': theme(
    //         `borderRadius.${theme('sprinkleConfig.borderRadius')}`,
    //       ),
    //       'padding': `${theme('padding.3')} ${theme('padding.5')} ${theme(
    //         'padding.3',
    //       )} ${theme('padding.5')}`,
    //       'fontSize': theme('fontSize.sm'),
    //       'fontWeight': theme('fontWeight.medium'),
    //       'display': 'flex',
    //       'alignItems': 'center',
    //       'transitionProperty': theme('transitionProperty.DEFAULT'),
    //       'transitionDuration': theme('transitionDuration.200'),
    //       'transitionTimingFunction': theme('transitionTimingFunction.in-out'),
    //       '&:focus': {
    //         outline: theme('outline.none'),
    //       },
    //     },
    //     ...generateSolidButtons(['primary', 'success', 'warning', 'danger'], theme),
    //     ...generateLightButtons(['primary', 'success', 'warning', 'danger'], theme),
    //   })
    // })],
  },
}

My doubt is, how to work with require statements windicss config?

sems to be an issue of plugins in config, hex colors seems to be ok

plugins can't be used without multiple custom workarounds. Therefore, I opened the issue, so you just post the same issue I posted earlier above.

Ok, Thanks @alexanderniebuhr got it, I thought you had a slightly different issue. Any plan to working on it? or can you guide little bit then I might also work on this issue then?

Currently not on my priority list.
Workarounds might be with using cdn like jsdelivr / unpkg to load the plugins and then do some logic in the config script to get them.
If you find a good general solution, pr is welcome. But all workarounds I found are project specific

Okay Sure.

Hey @alexanderniebuhr, There is one general solution I am thinking but before start implementing I like to have a suggestion on what do you think about it.
Here's what I am thinking...

We can export UMD of each export of official windicss exports (Including plugin and others).
Then serve UMD via CDN.
Put needed config imports (UMD script tag with src of CDN link) as they will be available via window object.
Then we can resolve the needed config in the browser as well.

Thanks and regards.

/cc @antfu what do you think of that proposal?

hI @alexanderniebuhr, Here is my implementation of in-browser windiCSS looks like (Forked windiCSS and made separate npm package) to serve IIFE of windiCSS (using rollup config). Have look at demos and share views. Would love to make PR on official windiCSS as well you like.
HTML demo link: https://codesandbox.io/s/html-windicss-live-playground-b2kbh
React demo link: https://codesandbox.io/s/react-windicss-live-playground-5j7xr

@MpMeetPatel Thanks so much.  Ported the issue over to the core repo, to see all team's opinion of whether to merge it into core or to leave it as an additional integration maintained by the community. Hope this is all fine for you.
However, if we merge it in core, I guess we would have to split parts into core and parts into this runtime-dom package.
Thanks a lot for your time and your ideas.

@alexanderniebuhr, Thanks man, I am fine with any solution which provides web-APIs via plugin or in core windicss or runtime-dom or any other.

Yeah, you could also just open the pr for the rollup in core, and one in here to import them. But keep in mind that this might take longer than the RFC discussion :)

@alexanderniebuhr, No problem. I will do that till then I will use my separate fork for my project.


Cuda feature flag is currently commented-out

See here: https://github.com/risc0/zeth/blob/main/host/Cargo.toml#L42
This means cargo build --release -F cuda does not work as expected.

Is this still an open issue?

fixed by https://github.com/risc0/zeth/pull/113


verifying requests come from alexa?

I saw in the docs for hosting custom skills, requests need to be verified if they come from alexa. Does this library do that? I can't seem to find any code that alludes to any mechanisms, but I could be missing something.
https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/developing-an-alexa-skill-as-a-web-service

You're right, this library did not validate the signature or timestamp.
I've added the verification checks and bumped the version to 1.0.0 (since the API has changed slightly)


Adds utility to draw bounding boxes

Closes #2556  Supersedes #2631
As per the new API discussion, I will make this compatible with output of detection models.
This will be compatible with only VOC format boxes as this is our default for Input and Output in torchvision.
Users can convert the boxes using the new box_convert function and pass. (We can fix this internally too but let's leave it for now)
Will try to get this in before October release 😃

[x] Adds code
[x] Adds docs
[ ] Adds tests

Got it working with Faster RCNN outputs 😄

Hopefully I will clean my dirty code (which I didn't commit and push)

Current caveats.

Image to be passed should be (C, H, W) and not (B, C, H, W). (B, C, H, W) is input format for detection models in eval() mode.

I would like to know best way to handle this.
Should we ask user to pass list of tensors ? Or simply do squeeze(0) and allow to pass (1, C, H, W) ? Or we process the entire batch of images (slow operation can be issue then) ?

Should we return the image drawn tensor? I'm not sure about why we are doing so.

If user wants to fill the bounding box, how it can be semi-transparent. We don't want a filled up rectangle, but something like mask.

Hey, @pmeier I too gave a thought on above points. Let me summarize a few pointers.

I think we can handle (B, C, H, W) situation using squeeze(0). Also raise an error if B>1. I think this is just a simply extension to present functionality, and that should suffice. (Lets see what users think)

Let's return the tensor. 👍

Filled bounding box makes little sense to me. Stuff would be completely invisible inside box.
Also for segmentation tasks, we should probably have another utility draw_masks like we have this. That will draw only Instance segmentation / semantic segmenation masks for tasks.

The colors, width, draw labels these parameters can be optimized further.
E.g Labels should probably not be drawn beyond the image. If the label is too long, it should be split in 2 lines etc.
As you pointed width should be something in ratio of image.
Also colors should restore to default if there is error. Can we automatically assign them to be class specific colors? if possible.

I guess there is too much scope in these improvements, but we should first have tests, proper documentation and minimal implementation working.

I agree with 1. - 3. IMO we should include the proper color handling in the original PR. The automatic line with adaptation as well as the label drawing could be done in separate PRs.

I will try to fix up the colors in this PR. There are lot of edge cases to think though. Below are my thoguhts,

User passes no colors -> Handled already We use PIL's default and draw all boxes with same colors
User passes colors for only specific classes -> Not sure, I think we should through error or draw others with default?
User passes colors for all classes with names of colors in string -> Handled already, we draw as they need
User passes colors for all classes with names of colors in rgb tuple -> Should probably convert his and work like 3.

Same doubt is about label names.

User passes no label names : - We simply draw the class number as text
User passes only some label names : - Not sure here, this is not probably how people should use.
User passes all label names : - We draw the label texts.

Problem arises when case 2 in colors and case 2 in label names both occur together. Coz this lead to some unexpected conditions.
Maybe that label has label name or not. Again making this API super complex to maintain.
I feel user should either give everything needed or avoid at all. We can raise Errors to ensure user passes correct content.

I too think the same.
We should probably discuss more about this API, since in future possibly we will extend utlitities to visualize segmentation outputs too.
I think this would be half baked till 0.8.0 release (with release being probably this week)  and we can provide this feature in next one.

Let me write here how this API works with torchvision models right now
# We need to specify all 91 COCO clasess I'm keeping it short
label_names = ['background', 'person', 'bicycle']

# Again all 91 are needed.
colors = {1: "blue", 2: "aqua"}

    image = Image.open(img_path)
    image = T.ToTensor()(image)

    # For detection model
    image = torch.unsqueeze(image, 0)

    model = fasterrcnn_resnet50_fpn(pretrained=True)
    model = model.eval()
    out = model(image)

    boxes = out[0]["boxes"]
    labels = out[0]["labels"]

    img_drawn = draw_bounding_boxes(image, boxes, labels, label_names, colors=colors)

Yes, let's chat a bit more about this after the release. I'm pretty busy today preparing the branch cut etc so I won't have much time to iterate today, but I gave this function a try and I faced a few issues / problem that I enumerate below:

The default colors being all white is a bit annoying, it would be preferable to have distinct default (maybe given by a fixed function like the one I used for maskrcnn-benchmark.
When I tried passing colors to the function it didn't seem to work, although I might have done something wrong
When I tried passing a uint8 image tensor to the function I got an error

I'll check back on this PR by the end of the week, but here are a few things I would like us to think about:
Labels
Now we need to pass two tensors for printing the labels. What I was originally thinking was to let the user directly specify the labels for each box, so that they can do arbitrary customization (including scores). This way, we don't need to expose a class_label argument to the function either.
Here is what I had in mind:
# let the user create the description for each box
description = [f'{CLASSES[cls_id]} : {s:02f}' for cls_id, sin zip(labels, scores)]
# now just pass it to the visualization function
draw_bounding_boxes(images, boxes, description

I'm not sure how much of a hassle for the user it would be to do this one-liner, but at least it makes things more generic.
Thoughts?

Let's not hurry over this. We can work on this after the release 😄

I think the color choice has to improve (colors remain major discussion). I think we can give good default colors for labels.
Maybe someting like distinct rgb values generated from label id ?

Colors should probably work, I have tried them locally and had attached output. Maybe I will share more code.

For the labels API which you proposed I think the folowing.

It can surely do much more job than the current one.
It is quite complicated and doesn't seem intuitive, most probably users are going to face errors in it which will be hard to debug too. I'm not quite sure what else would someone plot apart from labels (description) and scores. This is quite more open ended and I'm not sure if people will use the same one-linear (might not be obvious to all).

I guess trade-off question that is this API for plug and play to torchvision models or generic one ❓
I had in my mind it is plug and play (hence supporting image with 4 dims, allow to pass detection model outputs).
My thoughts were since this is utility function for torchvision and not for computer visionin general it should adhere to this API only.
Currently.
Label names is optional and can contain description of class / class name so it is quite flexible.
For scores I propose a new optional parameter though.
I'm not sure what else a person might be interested to plot.
I guess there is lot to discuss over this (maybe I have misunderstood something). Lets catch this up after 0.8.0.

Hi ! @fmassa @pmeier .
I guess we can continue on this now. Since 0.8 is here. (Really nice release)
This PR has a long but great discussion. I guess we can think more on this now 😄

Hey @oke-aditya and thanks for your patience. @fmassa and I have plans to discuss this. We'll get back to you when we agreed on something to avoid further back and forth with the functionality.

Great😀

Hi @oke-aditya
Sorry for the delay in getting back to you.
In general, I still think that it is preferable to have a slightly more generic function, even if it requires the user to be a bit more verbose. I think it's an ok trade-off to be made, as it would allow more use-cases for the function. The function would become something like visualize_boxes_with_annotations or something like that, where the annotations for each box can be arbitrary and provided by the user. We just ensure that the annotations are located in a particular location wrt the bounding boxes.
If you don't have enough bandwidth to work on this refactoring for now it's ok, @datumbox agreed to help and to build on top of your PR so that we can get this functionality merged in torchvision soon. Otherwise @datumbox will help co-design / review this PR.
Let us know what you think.

Hi @fmassa.
I think this will take some significant changes, refactoring.
I'm happy both the ways.
I think @datumbox  will have something great in his mind.  Two people handling this might slow down it.
I will leave it to @datumbox  if he would like to take-over completely or help to codesign and allow me to continue on this.

hi @oke-aditya, it's completely up to you!
We think that this PR is useful and we would like to merge it soon. If you think you have the time to make the changes discussed above, I'm happy to support. Else I'll take your PR and make the necessary changes, so that we can merge it ASAP. Just don't close your branch because I plan to make the changes in-place.
Let me know! :)

Looks like all of us want this 😄 .
@datumbox You can go ahead 🚀 . I won't close or delete this branch.
Let me know if you need access to this fork, etc. Super Eager to see this PR getting to master

Lots of thanks to @oke-aditya and @sumanthratna for their thorough investigations and contributions on the final API and implementation.

That's so kind of you @datumbox . Not much from me, it was your great work to get this done.


Type referenced from a stored property in a '@frozen' struct must be '@usableFromInline' or public

I'm getting the following error on this line in Xcode 12.5 beta 3 (12E5244e) that I wasn't getting in Xcode 12.4.
https://github.com/xavierLowmiller/AppStorage/blob/db62f9cd3aec28e901900b9ea71ec38c0665d9f3/Sources/AppStorage/AppStorage.swift#L7

Type referenced from a stored property in a '@frozen' struct must be '@usableFromInline' or public

I apparently fixed it locally by removing @frozen on line 5 but not sure if the other option is a better solution.

Thanks for bringing this to my attention! I'll look into providing a fix soon.

All good now, thank you!
Thanks for this fantastic project too by the way :)

Thanks!
I'm glad I could help :v:


EnvoyFIlter listener math support multi-port numbers

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Currently, only a single port number is supported for envoyfilter listener matching. If multi-port numbers use the same filter config, I need to configure one for each port number. Use envoy.extensions.filters.http.lua.v3.Lua to extend envoyfilter, each file has a lot of duplicates, only the ports are different.
Describe alternatives you've considered
The alternative is to support referencing lua code as a data source, and only one lua code needs to be written.
Affected product area (please put an X in all that apply)
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

If we are going to do this we should make it generic to EnvoyConfigObjectMatch being a repeated value

I don't think we have plans to extend this


Mass conversion from ABAP system to files

details see the commits

fb4e7c13e09e403af612f94eaaf6dd0ad376f036 has to be reverted

This branch/pr is used as a vehicle to show and discuss the diffs between A: what the report writes and B: content of git repo.

cherry-picked commits in #220

continued in #222


Enable mypy for examples/amm

Treat optionally - Enables mypy for examples/amm.
Rationale:

Since we intend the AMM example to be a good starting point for builders, I provide the PR under the assumption that we'd recommend mypy as good hygiene.
While working through the PR, I see friction between external method default parameters + mypy.  I still hold the opinion that mypy is a net value-add.  But, I think it's ultimately up to reviewers to make a call.

Note:  The PR branches off of https://github.com/algorand-devrel/beaker/pull/87.  I opted to include https://github.com/algorand-devrel/beaker/pull/87 changes here rather than chaining into my fork.  Once https://github.com/algorand-devrel/beaker/pull/87 is merged, I'll update this PR.

For added reviewer context, here's the set of mypy errors addressed by the PR:
❯ make mypy
mypy --show-error-codes beaker examples/amm
examples/amm/amm.py:157: error: Incompatible default for argument "pool_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:158: error: Incompatible default for argument "a_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:159: error: Incompatible default for argument "b_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:235: error: Incompatible default for argument "pool_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:236: error: Incompatible default for argument "a_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:237: error: Incompatible default for argument "b_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:300: error: Incompatible default for argument "a_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm.py:301: error: Incompatible default for argument "b_asset" (default has type "ApplicationStateValue", argument has type "Asset")  [assignment]
examples/amm/amm_test.py:134: error: Argument 1 to "_opt_in_to_token" has incompatible type "Optional[str]"; expected "str"  [arg-type]
examples/amm/amm_test.py:165: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:181: error: List item 1 has incompatible type "Optional[str]"; expected "str"  [list-item]
examples/amm/amm_test.py:204: error: List item 1 has incompatible type "Optional[str]"; expected "str"  [list-item]
examples/amm/amm_test.py:221: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:291: error: List item 1 has incompatible type "Optional[str]"; expected "str"  [list-item]
examples/amm/amm_test.py:293: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:308: error: List item 1 has incompatible type "Optional[str]"; expected "str"  [list-item]
examples/amm/amm_test.py:319: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:322: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:344: error: List item 1 has incompatible type "Optional[str]"; expected "str"  [list-item]
examples/amm/amm_test.py:346: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:360: error: List item 1 has incompatible type "Optional[str]"; expected "str"  [list-item]
examples/amm/amm_test.py:372: error: Invalid index type "Optional[str]" for "Dict[str, Dict[int, int]]"; expected type "str"  [index]
examples/amm/amm_test.py:413: error: Incompatible return value type (got "Tuple[Union[bytes, str, int], Union[bytes, str, int], Union[bytes, str, int]]", expected "Tuple[int, int, int]")  [return-value]
examples/amm/main.py:189: error: Unsupported operand types for / ("bytes" and "int")  [operator]
examples/amm/main.py:189: error: Unsupported operand types for / ("str" and "int")  [operator]
examples/amm/main.py:189: note: Left operand is of type "Union[bytes, str, int]"
Found 25 errors in 3 files (checked 59 source files)
make: *** [mypy] Error 1

Note - Line numbers might be slightly off.  I enabled + fixed mypy and then realized there's a failing test, which led to https://github.com/algorand-devrel/beaker/pull/87.


redirects change https requests to http locations

I'm running Caravel in AWS with this configuration:

ELB terminates SSL (and accepts only https requests)
Docker container runs gunicorn + caravel

Many requests hang in the browser because the https request is redirected to a http location.
$ curl -Ik https://caravel.example.com/
HTTP/1.1 302 FOUND
Content-Length: 239
Content-Type: text/html; charset=utf-8
Date: Thu, 18 Aug 2016 16:30:20 GMT
Location: http://caravel.example.com/caravel/welcome
Server: gunicorn/19.6.0
Connection: keep-alive

I'm not sure if this is an issue with Caravel or upstream in Flask or Flask-AppBuilder.
I tried setting PREFERRED_URL_SCHEME = 'https' in caravel_config.py hoping that would propagate to flask, but either it did not propagate, or it had no effect.  (That config instructs flask what scheme to use when it cannot be determined.)
I think the right way to deal with this is to determine the protocol from the 'X-Forwarded-Proto' header.  But I'm not sure if this is a bug in Caravel or Flask.
thanks,
Dennis

We run behind a reverse proxy (nginx) that is https while the site is served by gunicorn on http and redirects are fine on our side.
Seems like a configuration issue in your reverse proxy.

Thanks @mistercrunch
I'll try adding nginx to the mix and report back.
Just for kicks, I tried testing this to get an idea of where this might be breaking down.  Here's a very simple app that just does a re-direct from '/a' to '/b'.
# app.py
from flask import Flask, redirect, url_for
app = Flask(__name__)

@app.route('/a')
def a():
    return redirect(url_for('b'))

@app.route('/b')
def b():
    return 'you made it!'

And testing this in straight-up Flask, the 'X-Forwarded-Proto' header is not recognized. (Notice the Location is https even though the header requested https.)
$ FLASK_APP=app.py flask run
...
$ curl -Ik -H "X-Forwarded-Proto: https" localhost:5000/a
HTTP/1.0 302 FOUND
Content-Type: text/html; charset=utf-8
Content-Length: 211
Location: http://localhost:5000/b
Server: Werkzeug/0.11.10 Python/3.5.2
Date: Sun, 21 Aug 2016 22:52:23 GMT

And running with gunicorn it does handle the 'X-Forwarded-Proto' header.  (Notice the Location is https now.)
$ gunicorn -b <IP_ADDRESS>:5000 app:app
...
$ curl -Ik -H "X-Forwarded-Proto: https" localhost:5000/a
HTTP/1.1 302 FOUND
Server: gunicorn/19.1.0
Date: Sun, 21 Aug 2016 22:53:13 GMT
Connection: close
Content-Type: text/html; charset=utf-8
Content-Length: 211
Location: https://localhost:5000/b

So gunicorn looks like it should be doing the right thing.
I think this can be closed since I believe the problem is not in Caravel.  And I'll update this issue with whatever I learn.
thanks,
Dennis

Thanks for the heads up, closing then.

For the record, I found the cause of the problem and the fix.  When gunicorn is run on a different machine from the load balancer (nginx or ELB), it needs to be told explicitly to trust the X-Forwarded-* headers sent.  gunicorn takes an option --forwarded-allow-ips which can either be a comma separated list of ip addresses, or "*" to trust all.
I'm starting caravel with this command (with gunicorn running behind an ELB):
gunicorn \
  --error-logfile - \
  --access-logfile - \
  -w 8 \
  -k gevent \
  -b <IP_ADDRESS>:8080 \
  --timeout 120 \
  --limit-request-line 0 \
  --limit-request-field_size 0 \
  --forwarded-allow-ips="*" \
  caravel:app

More details are in the gunicorn docs:
http://docs.gunicorn.org/en/stable/deploy.html
cheers,
Dennis

@dennisobrien In http://airbnb.io/superset/installation.html#configuration-behind-a-load-balancer

If the load balancer is inserting X-Forwarded-For/X-Forwarded-Proto headers, you should set ENABLE_PROXY_FIX = True in the superset config file to extract and use the headers.

Have you tried this setting?

I recently ran into this as well when trying to use a AWS load-balancer to a container and fixed it the following way.

superset v0.17.1 with docker image: python:3.6
Set ENABLE_PROXY_FIX = True in superset_config.py
Used a Application Load Balancer (ALB) instead of a classic ELB going to the container port over http and https

@ecliptik I'm using the below configuration, running superset in python virtualenv

Superset v0.17.0 : python:2.7.12,
Set ENABLE_PROXY_FIX = True in superset_config.py
Using the ALB.

I'm able to access the application using the ALB endpoint, while logging in, it says "Invalid login", eventhough giving the valid credentials
could help me on resolving this.

I am having similar problem: ALB works find with HTTP, but when I binding HTTPS to the ALB, I get error: 502 Bad Gateway. I have tried to figure out more details about the error, but not much information logged in S3. Is there anywhere I can see more information about this error? There is no any error from the superset console. I suspect the problem happens in ALB, some headers not matched maybe?
and I have tried ENABLE_PROXY_FIX = True in superset_config.py and also environment variable FORWARDED_ALLOW_IPS=*, but not luck.
my Gunicon version is 19.7.1, superset is 0.18.5.
Any suggestion or tip is appreciated! Thanks
Jay

For people may come across the same problem, I have found the problem. By mistake, I set protocol of target group to HTTPS. When I change it to HTTP, everything works!

@Jie-Yang can you close the issue then?

@mistercrunch Can we actually re-open it? I'm using the latest 0.24.0 within docker (https://github.com/amancevice/superset). In front of this container, I have nginx where my SSL certificate is installed.
Everything is working fine, except that I have superset in an Iframe, and that as soon as the user login, it gets redirected to HTTP and the browser doesn't like it...
Here is the call I'm making to the login page with the user being login already, and how it gets redirected back an forth:
=> `https://superset.example.com/login/`
-> `http://superset.example.com (301)`
-> `https://superset.example.com (302)`
-> `http://superset.example.com/welcome/ (301)`
-> `https://superset.example.com/welcome/ (302)`

The 301 is happening because I have a rule in nginx to force HTTPS. However the issue is with the application redirect()
I tried all the config variables listed here, but still nothing:
ENABLE_PROXY_FIX = True
PREFERRED_URL_SCHEME = 'https'

@Maxwell2022  hello,I want to use superst in an inframe,I use https url，but redirect to http,can you tell me the file location that contain the config PREFERRED_URL_SCHEME?

This problem can be easily solved if the application is running behind AWS ALB.
Step 1. Create two listener in ALB, one running on port 80 and another running on 443 with certificate attached to it.
Step 2. Write a redirect rule in listener with port 80 for permanent redirect to port 443, your rule should look like below
https://#{host}:443/#{path}?#{query
So any redirect happens on the application level will redirect to https. Hope this helps.

Hey, I think redirects on ALB/Nginx level from 80 to 443 is a workaround, not a solution. I am not familiar with flash/gunicorn/whatever runs the Superset but anyway tried to force redirects go to https rather than http, but without success. I ended up with redirect solution JUST for Superset. Is there ANY other way to force Superset to use https? Middleware or something?

I have added a comment here which worked for me.

@ajm135x @ajayy1608 It can be fixed with relative URL in my #22355 PR because Werkzeug 2.1.0 uses relative URL by default.

Scheme relative URL:
The browser will try to open the URL using the same scheme it's currently on; if it's currently on HTTPS, it will request the URL with HTTPS and vice versa for HTTP


[Feature]: Shape Limits

What feature do you want to see in the upcoming releases?
I like what this mod does, i think some mining shapes might be a bit more overpowered then others, i would like to request a way  to remove/limit which mining options/shapes are available to a players? I'm not trying to exclude mineable blocks, but rather the options for shapes the player can use... for example i only want the player to be able to use shapeless and small tunnel options...

Thank you for reporting! ✨
This feature will be added in the next update ❤

awesome, thank you... i'm guessing its not the 1.21 - 1.21.1 | v1.0.2 release, right?

This is the new version. Just update the mod, and you can use the new feature. ✨
The settings can be modified in the config file at "ultimine_addition/common-config.toml."

🗒 Ensure that this setting is adjusted identically on both the Client and Server.


How to get objects.count() and objects.order_by()

Suggestions for basic crud types https://github.com/hasura/graphql-engine


Project 📃: Blood Alcohol Content (BAC) Calculator JS Project

WebMasterLog Repository (Proposing new issue)
:red_circle: Project Title : BAC - Calculator
:red_circle: Aim :The calculator will estimate the BAC based on the number of drinks, weight, gender, and time since the last drink.
:red_circle: Tech Stack Used :  HTML, CSS, JS
:red_circle: Category :   Vanilla-JS-Projects
Screenshots 📷

N/A

:white_check_mark: To be Mentioned while taking the issue :

Full name : Amruta Jayanti
GitHub Profile Link : AmrutaJayanti
What is your participant role? GSSOC

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@AmrutaJayanti calculators are not allowed.


Art

Can I use your art to make my own collection? Thanks

Yes, all 24x24 pixel art int the punk.starter repo is in the public domain. Free to (re)use.


ReferenceError: fetch is not defined after upgrading

I asked this already at Stackoverflow but will do it here again for the sake of visibility.

I recently upgraded redux-api-middleware from 2.3.0 to 3.0.1 When running my tests with<EMAIL_ADDRESS>I get this ReferenceError:
    ReferenceError: fetch is not defined

      19 | export function sortPolicyChain (payload: Array<ChainPolicy>): SortPolicyChainAction {
      20 |   return { type: 'SORT_POLICY_CHAIN', payload }
    > 21 | }
      22 |
      23 | export type UpdatePolicyInChainAction = { type: 'UPDATE_POLICY_IN_CHAIN', policyConfig: ChainPolicy }
      24 | export function updatePolicyInChain (policyConfig: ChainPolicy): UpdatePolicyInChainAction {

      at Object.<anonymous> (node_modules/redux-api-middleware/lib/index.cjs.js:404:3)
      at Object.<anonymous> (app/javascript/src/Policies/actions/PolicyChain.jsx:21:27)
      at Object.<anonymous> (spec/javascripts/Policies/actions/PolicyChain.spec.jsx:3:20)

The stacktrace points to this line in PolicyChain.jsx:
    export function fetchChain (serviceId: string): RSSAAction {
      return {
        [RSAA]: {
          endpoint: `/admin/api/services/${serviceId}/proxy/policies.json`,
          method: 'GET',
          credentials: 'same-origin',
          types: [REQUEST, SUCCESS, FAILURE]
        }
      }
    }

According to the documentation here:

If provided, the fetch option must be a function that conforms to the
Fetch API. Otherwise, the global fetch will be used.

But it looks like the global fetch can't be found. Any ideas?
Relevant code at https://github.com/3scale/porta/pull/463.

This is also a problem for isomorphic apps. What makes it especially problematic is that the code where the global fetch is assumed happens in the global scope of middleware.js, so an error is thrown as soon redux-api-middleware is included (ie, on startup). So we don't even get a chance to pass in fetch from node-fetch or the like, as we were in 2.3.0, and our app fails out of the gate.
I propose waiting until within createMiddleware() to set the default value of fetch, assuming it wasn't passed in through options.

Hitting this same problem trying to use this in a Gatsby app. The build fails as fetch is undefined.

For anyone else wanting to get this working with Gatsby, I got rid of the error by adding isomorphic-fetch as a webpack plugin in gatsby-node.js.
exports.onCreateWebpackConfig = ({ actions }) => {
  actions.setWebpackConfig({
    plugins: [
      new webpack.ProvidePlugin({
        fetch: path.resolve(path.join(__dirname, "node_modules/isomorphic-fetch/fetch-npm-node"))
      })
    ]
  });
};

@darthrellimnad is right about fetch
Any suggestions as to how this could be handled better?

@nason I would suggest to make a breaking change and remove apiMiddleware and let users replace it with
const apiMiddleware = createMiddleware({ fetch: /* any fetch compilat library */ })

This way we get rid of any global instances.

Hmm, in my opinion this seems a bit harsh, considering that most of the consumers of the library probably use polyfills to resolve such issues.
If implementing globalThis proposal is a bit of a hassle, I think we could actually implement a simpler - to evaluate user-defined fetch implementation first (if set), then try to use global fetch 🤔 In this case, the library should be usable in all use cases.
Any thoughts?

Long story short. I have a fix. But I don't know how exactly it will behave.
The difference between v2 and v3 that throws error I think it has something to do with 'use strict'; mode.
And I'm still for that to deprecate apiMiddleware in favor of createMiddleware.
https://github.com/agraboso/redux-api-middleware/pull/251

Released in https://github.com/agraboso/redux-api-middleware/releases/tag/v3.2.1

Awesome! Though i suggest investing in proper solution, as we will still need to update the babel preset eventually.. Sorry for not contributing, did not have the time

i suggest investing in proper solution

Proper sollution I think is to drop apiMiddleware in favor of createMiddleware.
And get rid of all global dependencies.

we will still need to update the babel preset eventually

I'll take a look again when will have some time.


Prefix tags with 'v'

What this PR does / why we need it:
Ref gardener/gardener#1096 (comment).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

The release tags from now are prefixed with `v`.

/assign @amshuman-kr

@ialidzhikov Thanks for the PR!


[Automated PR] Resynced OWNERS file for backplane-2.0

Updated OWNERS to match source of truth.

/lgtm


Bugfix/16

Fixed memory and performance issues for Linear Separator.
Covered new features by tests.

Coverage decreased (-1.0%) to 95.606% when pulling 09b9242ed999e7e6d8e55e7c2a8fe5114e814e9b on bugfix/16 into c5a58bff28081dd7b4506b1efd5ae410e026fe79 on feature/linear-classifier.

Coverage increased (+0.4%) to 96.948% when pulling a034887c4b9a4246ab6b249bfc13a1647f1be006 on bugfix/16 into c5a58bff28081dd7b4506b1efd5ae410e026fe79 on feature/linear-classifier.


Clarification of aoe2insights

Just added a little description to aoe2insights.com

Thank you @sighalt ! :)

Thank you @sighalt ! :)


All networks are shown as Ethereum

Describe the bug
After connecting metamask, any network is shown as Ethereum
SDK Version

2.0.0

To Reproduce
Steps to reproduce the behavior:

Go to '...' https://docs.walletconnect.com/2.0/web3modal/react/installation
Follow steps to install and implement in react app
Choose any network after connecting metamask
see that any network chosen does not change network icon, it stays ethereum

Expected behavior
After connecting to network, this network image should apear also
const { selectedChain, setSelectedChain } = useWeb3ModalNetwork()
should show this network
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser chrome
Version 109.0.5414.76

Additional context
Add any other context about the problem here.

useWeb3ModalNetwork hook will be going away in next release, does same issue happen when you use wagmi hooks?
https://wagmi.sh/react/hooks/useSwitchNetwork
and
https://wagmi.sh/react/hooks/useNetwork

let me check :)

if that doesn't work, another temporary sollution could be something like this https://github.com/WalletConnect/web3modal/issues/815#issuecomment-1405306744

so using :
import { useNetwork } from 'wagmi'

Usage
import { useNetwork } from 'wagmi'

function App() {
  const { chain, chains } = useNetwork()

  return (
    <>
      {chain &&
Connected to {chain.name}
}
      {chains && (

Available chains: {chains.map((chain) => chain.name)}

      )}
    </>
  )
}

gave expected result:

so the issue with wrong network in web3 modal button and switch remains

How are you switching the chain? Is it from ui, extension or using wagmi useSwitchNetwork? I've tried to replicate these and everything works as expected.
In #845 there will be an option to set default chain i.e one use before user connects, but after that everything should be managed via wagmi or modal ui.
https://user-images.githubusercontent.com/3154053/215071730-2fa700ad-1c76-4ef1-950c-5b32bee1ca91.mov

to switch between networks I use:
`
							<Web3NetworkSwitch /> `

that were in example:
https://docs.walletconnect.com/2.0/web3modal/react/installation
when I used :
`import { useNetwork, useSwitchNetwork } from 'wagmi'
function App() {
const { chain } = useNetwork()
const { chains, error, isLoading, pendingChainId, switchNetwork } =
useSwitchNetwork()
return (
<>
{chain && Connected to {chain.name}}
{chains.map((x) => (
<button
disabled={!switchNetwork || x.id === chain?.id}
key={x.id}
onClick={() => switchNetwork?.(x.id)}

{x.name}
{isLoading && pendingChainId === x.id && ' (switching)'}

))}
{error && error.message}

 )
}
` the name of chain is correct

so in your video the icon of chain is correctly showing avax when chain is avax, here at mine its always ethereum, on screenshot you may see matic icon with matic amount but ethereum chain icon (in metamask it swtiched correctly to polygon)

Sorry, still trying to understand your use case 😅 any chance you can deploy live preview / video or provide git repo url that can demonstrate it in detail?

Sure! Here link to a video:
https://drive.google.com/file/d/14m965b4aQ3fCfX3hkfUcN38-UJVNYDl-/view?usp=share_link
i found out that after changing a network different to ethereum then click on this network again makes a change to a correct icon of the network, so high likely just a state of current chain is not updated

Hi again, I found the reason causing this error, I needed to reinstall metamask and update all dependencies and now work as intended, ready to be closed

btw i moved also wagmi config wrap into main _app making it available for all pages maybe this also helped

Oh, definitely, wagmi provider needs to wrap whole app, plus things like configureClient should be initiated outside of react as well (so they are not re-created). I am also memoising web3modal in next version just in case (it doesn't need to re-render at all and it's state is separate from react entirely).

problem came back, idk, i see it is connected to defaultCHain like:
				<Web3Modal
					projectId={projectId}
					ethereumClient={ethereumClient}
					defaultChain={polygon}
				/>

when it is not filled or it is undefined it is always mainnet, then icon after changing network for sec shows correct, then switches to default icon ;p


cfripper: 1.3.3 -> 1.4.2

Motivation for this change
https://github.com/Skyscanner/cfripper/releases/tag/1.4.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 162362 run on x86_64-linux 1

1 package built:

cfripper


chore(deps): update dependency org.apache.maven.plugins:maven-compiler-plugin to v3.12.1

closing as now applied via dependabot.


Make JestHttpClient implement Serializable

Many of the modern framework use that basic feature to serialize beans across nodes of the cluster. So for instance if you want to use it in Apache Spark you'll always face the issue: java.io.NotSerializableException: io.searchbox.client.http.JestHttpClient
Would be possible to get JestHttpClient implementing Serializable?

In my mind there's 2 things here:

Configuring your client
Opening the HTTP connections, etc.

JestHttpClient already has a handle on all of the connections and other bits specific to the jvm where it is created. Does it even make sense to ship it?
On another hand taking a factory/lambda/configuration used to instantiate a JestHttpClient and serializing that could be very useful.
wdyt?

In my use case I want to:

Configure the client just once on the init method
Open connections from any node of the spark cluster

Basically I'd like to avoid creating a new client on each node on step the 2nd step.
Currently I'm using JestClient, but I do not understand what you mean how JestHttpClient globally handles al requests at the JVM level. Could you please point me some documentation?

Below is one way to get JestHttpClient which works almost like apache HttpClient
public JestHttpClient jestClient() {
// Construct a new Jest client according to configuration via factory
JestClientFactory factory = new JestClientFactory();
HttpClientConfig httpClientConfig = new HttpClientConfig.Builder(
http://localhost:9200).multiThreaded(true).connTimeout(300)
.readTimeout(150)
.maxTotalConnection(20)
.gson(new GsonBuilder().setDateFormat("yyyy-MM-DD'T'hh:mm:ss").create())
.build();
factory.setHttpClientConfig(httpClientConfig);
JestHttpClient jestHttpClient = (JestHttpClient) factory.getObject();
CloseableHttpClient closableHttpClient = HttpClientBuilder.create().build();
jestHttpClient.setHttpClient(closableHttpClient);
return jestHttpClient;
}

@wikier I meant the persistent http connections that are opened to each node in the cluster - those are associated with a specific PID. Maybe I'm missing your point.


Save to MongoDb in sim mode?

I need a little help: I'm currently developing a web api and web ui for zenbot and would like to view sim results in this web ui. So I'm extending sim.js with the following code but it actually never saves to mongodb. Is there any hidden flag that disables the db or am I missing something?
// Save the SIM Session
var sessions = get('db.sessions')
let session = {
id: crypto.randomBytes(4).toString('hex'),
selector: so.selector,
started: new Date().getTime(),
mode: so.mode,
options: so
}
console.log(session)
      sessions.save(session, function (err) {
        if (err) {
          console.error('\n' + moment().format('YYYY-MM-DD HH:mm:ss') + ' - error saving session')
          console.error(err)
        }
        if (s.period) {
          engine.writeReport(true)
        }
      })

Dear issue reporter,
We have slightly changed our github issue policy and would now kindly request folks that have questions that they ask them in our zenbot subreddit.
You can find it here: https://reddit.com/r/zenbot
This issue will be closed, but if you disagree with your ticket being marked as a question feel free to leave a comment defending your case.
Thanks for contributing time and effort!
Greetings,
🤖


Add files under /docs/tutorial/complete-bicep-files to same validation as /docs/examples

We should run the tutorial files through the same validation as the example files

Another nice-to-have would be to pass anything between  ```bicep tags in our markdown documents through the parser & pretty-printer, to ensure our syntax samples are all up-to-date and correctly formatted.


Fix minimum_character_width in LineEdit

Fixes a small mistake in the "minimum_character_width" constant name for LineEdit.
Error was introduced by this commit: https://github.com/godotengine/godot/commit/28537d8c84a from this PR: https://github.com/godotengine/godot/pull/45923

Thanks!


APIDoc Generation

Description
Sets up Sphinx to generate API docs.
pip install -r dev_requirements.txt
sphinx-build -M html .\docs\ .\docs\

You'll find the API Docs in docs\html\index.html

Not really relevant to the PR- but just wanted to note this if someone else hits it.
Had to do pip install -r dev_requirements.txt  --user
Without --user I hit
ERROR: Could not install packages due to an OSError: [WinError 2] The system cannot find the file specified: 'C:\\Python311\\Scripts\\pygmentize.exe' -> 'C:\\Python311\\Scripts\\pygmentize.exe.deleteme'


[Issue] The Scroll Bar Arrow Hide on 1366x768 Screen

Scroll bar arrow missing.
Page: http://<IP_ADDRESS>/dashboard
Screen resolution: 1366x768

fixed.


Transport not determined for some object types

Seems like * as object name does not work when TR_CHECK_TYPE delegates to CHECK_TYPE. * and space lead to replacing 'L' with ' ' before returning. Using any other dummy value seems to work.

https://github.com/larshp/abapGit/blob/f7dfcb71789792f98bb1cc8c386dadd7bc86be16/src/zcl_abapgit_cts_api.clas.abap#L104-L112

Yes, there were all locked in the same transport.


Status Bar toggle not working

Toggling the Status Bar setting on and off does nothing and the Status Bar remains disabled despite the toggle being enabled.
No log in the console when toggling between enabled and disabled.
Using Obsidian v0.9.19 and Day Planner v0.5.3

Do you mean the "Status Bar - Circular Progress" or "Status Bar - Now and Next" setting?
A status bar should always appear if you have a day planner linked to a note with an active task. This means having a task that starts before the current time and has a following task starting after the current time.
Do you have anything being displayed in the timeline view when you do not see a status bar being displayed?
Are you also using the Hider plugin?

Both elements of the status bar remain hidden/do not show in the status bar.
I do see the timeline view perfectly fine, which is a great feature.
I’m not using the hider plugin no.

Same issue here. I'm using a couple other plugins, but not hider. It doesn't seem to be working in either mode.

I have the same problem. I checked see console and saw theses errors:
app.js:1 Obsidian Developer Console
main.ts:179 Loading Day Planner plugin
main.ts:232 loading markdown-table-editor plugin
main.ts:232 Found existing settings file
parser.ts:24 Error: ENOENT: no such file or directory, open 'home/Day Planners/Day Planner-20201203.md'
file.ts:25 TypeError: Cannot read property 'split' of undefined
    at PlannerMarkdown.parseDayPlanner (eval at <anonymous> (app.js:1), <anonymous>:6219:9)
    at async eval (eval at <anonymous> (app.js:1), <anonymous>:7532:33)
main.ts:179 TypeError: Cannot read property 'calculate' of undefined
    at eval (eval at <anonymous> (app.js:1), <anonymous>:7533:25)

But the file is at the correct location. Maybe the plugin is faster in trying to check if the file is there than in creating the file. Maybe this also hinders the Status Bar from popping up.

Update on my issue - If I enable to status bar, add in time entries to populate the chart, then quit and reopen Obsidian, the status bar works. It will not work for me unless I quit and reopen the app once I have populated things into the day plan.

Definitely seems like I have introduced a bug! @nickwarters and @wfischer42 are you seeing similar errors in the console to @mikebarkmin?

@lynchjames I'm not seeing any output in the console.
Right this moment it is 07:16 and I have added 3 times into the plan: 06:00, 07:00, and 08:00.
The 06:00 is marked as completed, but not the 07:00, and the status bar shows "All Done".

I have found a bug with the File mode when a new note is first created meaning that the status bar would not be displayed. There will be a fix in the next release.

This should now be fixed in the latest release (0.5.4).


Route component keys

I was reading https://github.com/rackt/react-router/blob/latest/docs/guides/advanced/ComponentLifecycle.md#lifecycle-hooks-when-routing , the third bullet point

/invoice/123 to /invoice/789

activating:

Component
Lifecycle Hooks called

App
componentWillReceiveProps, componentDidUpdate

Home
N/A

Invoice
componentWillReceiveProps, componentDidUpdate

Account
N/A

Is there a way to add keys to my components related to the routing so that my lifecycled called would actually because of keys resolution (different keys would mean different component and so not receiveProps/didUpdate and rather willUnmount/didMount)

Component
Lifecycle Hooks called

App
componentWillReceiveProps, componentDidUpdate

Home
N/A

Invoice
componentWillUnmount, componentDidMount

Account
N/A

I find it a lot simpler to keep myself to those and keep state managing outside of those components.

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of React Router.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with React Router and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.

Yeah never mind, I'm already on discord, totally forgot to go there.

'passing props' example


Choose menu selection tool via env var

Because there are many alternatives to dmenu and rofi is not the only one, it would be great if any dmenu-compatible tool could be specified using an environment variable like MENU_SELECTOR=rofi.

I am all for such settings, but the problem would be the options used in the script to call those programs. Even the dmenu option in Rofi to emulate dmenu needs some special care. So such a menu selector would only work, if the program options are 100% compatible to dmenu/rofi. Does any such alternative exist?
In case you are interested into, I rewrote  this in Python with much more options (including alternative menus such as rofi, dmenu and commandline fzf and even more ways). It also comes with commandline options to use alternative program nameds --rofi CMD in example: https://github.com/thingsiplay/emojicherrypick

I have added the environmental variable EMOJIPICK_CMD, which can be used to set an alternative path or entire command with options. It still needs to be compatible to rofi or dmenu and therefore quite limited. Here are two examples setting the env variable and running the script:
$ EMOJIPICK_CMD='rofi -dmenu' ./emojipick

$ EMOJIPICK_CMD='dmenu -fn' ./emojipick

The -fn in for dmenu is still required, in case you want do some custom options.


messages: Eliminate redundant realm fetch in has_message_access.

Accessing .realm will cause a fetch query from the database if the attribute hasn't been fetched already earlier in the codepath. That's completely redundant if we're just comparing realms, and we should only access .realm_id attribute. This seems to eliminate a query in some codepaths, which is nice in this performance-sensitive function.

Good find, merged, thanks @mateuszmandera!