Service Name Resolution is not working

Hi There
I have a ubuntu multi-node cluster set up - running. I am able to create pods, controllers and services at will. But I am facing the issue where service name resolution is not working. As part of the guestbook example, I have created redis-slave, redis-master and frontend services. But when containers are trying to talk to each other through this service interface, it is not working.
E.g

When PHP application try and talk to redis-slave:6379 - it fails (This call dont get routed any where)
When redis slave try to synch with master using redis-master , it doesnt work.
When I try and ping redis-master from inside the container, it comes back with unknown host error.

Some logs to show you the problem
[8] 10 Apr 00:03:57.902 # Unable to connect to MASTER: Connection timed out
[8] 10 Apr 00:03:58.905 * Connecting to MASTER redis-master:6379
[8] 10 Apr 00:03:58.909 # Unable to connect to MASTER: Connection timed out
[8] 10 Apr 00:03:59.913 * Connecting to MASTER redis-master:6379
Temporary failure in name resolution [tcp://redis-slave:6379]' in /vendor/predis/predis/lib/Predis/Connection/AbstractConnection.php:141
I do see Kube-Proxy is making the right iptable entries.
I0409 13:04:47.690367   20353 proxier.go:556] Opened iptables from-containers portal for service "redis-master" on TCP <IP_ADDRESS>:6379
I0409 13:04:47.696276   20353 proxier.go:567] Opened iptables from-host portal for service "redis-master" on TCP <IP_ADDRESS>:6379
I0409 13:11:50.223702   20353 proxier.go:556] Opened iptables from-containers portal for service "redis-slave" on TCP <IP_ADDRESS>:6379
I0409 13:11:50.252093   20353 proxier.go:567] Opened iptables from-host portal for service "redis-slave" on TCP <IP_ADDRESS>:6379
I0409 13:14:17.024773   20353 proxier.go:556] Opened iptables from-containers portal for service "frontend" on TCP <IP_ADDRESS>:8000
I0409 13:14:17.034296   20353 proxier.go:567] Opened iptables from-host portal for service "frontend" on TCP <IP_ADDRESS>:8000
I0409 13:14:17.046845   20353 proxier.go:556] Opened iptables from-containers portal for service "frontend" on TCP <IP_ADDRESS>:8000
I0409 13:14:17.057679   20353 proxier.go:567] Opened iptables from-host portal for service "frontend" on TCP <IP_ADDRESS>:8000
I0409 13:14:17.067562   20353 proxier.go:556] Opened iptables from-containers portal for service "frontend" on TCP <IP_ADDRESS>:8000
I0409 13:14:17.077085   20353 proxier.go:567] Opened iptables from-host portal for service "frontend" on TCP <IP_ADDRESS>:8000
Do you know what is missing in the set up which is causing this problem ? I do not have any DNS (skydns) running here and think that it is desirable but not needed.
What might be going wrong here ?

It sounds like something about your network is not configured correctly. I think you have to tell every node what range of IP addresses it should answer to.
@thockin is it possible to make kube-proxy configure that? Seeing as it's already doing IPTables magic.

@lavalamp - I am trying to figure out what. To work around this, in my code, when I refer to 'Services' using the IP address 11.1.X.X range, it worked just fine. That confirms that Service names are not getting resolved at all.  I don't know much about where these services names are registered and resolved. None of the logs that I have access to shows why the name resolution failed or any issues while creating the new service. I am clueless.  Are there any specific logs or commands I must run to get some insights here ? Appreciate your help.

A few things.
First, 11.* is a real IP range - you probably should not be using it unless
you own it :)
Second, you actually do have to run the DNS server to get DNS resolution.
On Fri, Apr 10, 2015 at 12:36 PM, sacashgit<EMAIL_ADDRESS>wrote:

@lavalamp https://github.com/lavalamp - I am trying to figure out what.
To work around this, in my code, when I refer to 'Services' using the IP
address 11.1.X.X range, it worked just fine. That confirms that Service
names are not getting resolved at all. I don't know much about where these
services names are registered and resolved. None of the logs that I have
access to shows why the name resolution failed or any issues while creating
the new service. I am clueless. Are there any specific logs or commands I
must run to get some insights here ? Appreciate your help.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/6667#issuecomment-91660885
.

@thockin - Thanks for the quick note.
IP Range : I dont own it :). I just didnt change any of that when I built the binaries and kept the config files as is to large extent. I can take care of that.
Name resolution: So I do need to run the DNS even for the intra-cluster (I just need this to work between PODS since it gives a nice abstraction) ?  If So, any idea on whats recommended for Kubernetes on Ubuntu Cluster that is not on GCE ?

The IP range isn't likely to be a real problem, but it is a routable
range, so if you ever find a real site with an 11. prefix that you want to
hit, you'll be debugging for weeks :)
If any of our docs say to use 11. they are wrong and should be fixed.
For DNS: Our DNS service is exactly for intracluster use.
https://github.com/GoogleCloudPlatform/kubernetes/tree/master/cluster/addons/dns
Start with the README - it covers what to run and how, and has template pod
and replication controller configs for you.
On Fri, Apr 10, 2015 at 1:00 PM, sacashgit<EMAIL_ADDRESS>wrote:

@thockin https://github.com/thockin - Thanks for the quick note.
IP Range : I dont own it :). I just didnt change any of that when I built
the binaries and kept the config files as is to large extent. I can take
care of that.
Name resolution: So I do need to run the DNS even for the intra-cluster (I
just need this to work between PODS since it gives a nice abstraction) ? If
So, any idea on whats recommended for Kubernetes on Ubuntu Cluster that is
not on GCE ?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/6667#issuecomment-91666622
.

@thockin  - Thanks..
DNS : I read quite a bit from last 2 days on the above link but what I am suspecting is, this is not supported on Ubuntu cluster. The reason being, I dont see this configuration option on the bits I have for ubunut-cluster.

am I missing some thing ? { I hope to hear Yes and able to use it to resolve the issue}. will look deeper in the mean time
On the Portal IP Base address (11.*) , I think it is part of the GuestBook example.

It looks like the ubuntu-cluster does not start DNS.  You can start it
manually.
Follow the "If you are not using a supported cluster setup" part of
https://github.com/GoogleCloudPlatform/kubernetes/tree/master/cluster/addons/dns/README.md
I don't find any examples that use an 11.* for portals?
On Fri, Apr 10, 2015 at 2:17 PM, sacashgit<EMAIL_ADDRESS>wrote:

@thockin https://github.com/thockin - Thanks..
DNS : I read quite a bit from last 2 days on the above link but what I am
suspecting is, this is not supported on Ubuntu cluster. The reason being, I
dont see this configuration option on the bits I have for ubunut-cluster.
[image: screen shot 2015-04-10 at 2 05 31 pm]
https://cloud.githubusercontent.com/assets/6346188/7097509/fd7c4a04-df8a-11e4-953a-8bb8f971870d.png
am I missing some thing ? { I hope to hear Yes and able to use it to
resolve the issue}. will look deeper in the mean time
On the Portal IP Base address (11.*) , I think it is part of the GuestBook
example.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/6667#issuecomment-91693997
.

@thockin : Thanks for pointing the process around launching DNS in Ubuntu Cluster. I will try the manual steps and report back the findings..
Regarding the Portal IP (11.1.*) : I think I found some thing that should help :).  As I mentioned, I did not add any thing new on my own but just followed the steps to get the cluster up and running.  I indeed find a reference to portal IP 11.1 series in default_scripts directory for API_SERVER.  Check it out. Hope this helps.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/ubuntu-cluster/default_scripts/kube-apiserver

@sacashgit I am the author of this deployment approach.Sorry for the late. I learned this portal net configuration from the single-node ubuntu and it works fine in my lab.I will make it configurable.In fact I am working on it https://github.com/GoogleCloudPlatform/kubernetes/pull/5498#issuecomment-95256604.Once this pr is merged you can configure it as you want

This is fixed now, yes?  Please reopen if not.

@sacashgit
Is this problem fixed or not ?
I have the same problem in my ubuntu cluster,
services are not working.

Yes - problem fixed, after installing the SkyDNS service on Ubuntu Cluster. All Good now.


Scale compute power

acceptance criteria

[x] All new/changed patches are checked within 2h.
[x] We benchmarked the tests on "C" type machines to see if that's faster.
[x] We have benchmarks for 16, 32 and 64 cores for:

clean build
cached build
ninja check
ninja check-all

setting up VM for testing:
sudo apt-get update
sudo apt-get install -y --no-install-recommends cmake ninja-build git ca-certificates clang-7 lld-7  clang ccache python python3 build-essential python-psutil arcanist zip wget python3-pip python3-setuptools
git clone --depth=1 https://github.com/llvm/llvm-project.git
cd llvm-project
git clone https://github.com/google/llvm-premerge-checks.git
mkdir build
cd build
export CC=clang-7
export CXX=clang++-7
export LD=LLD
export CCACHE_PATH=~/ccache
mkdir -p ${CCACHE_PATH}
cmake -GNinja ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_LLD=ON  -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;libcxx;libcxxabi;lld" 	-DLLVM_CCACHE_BUILD=ON -DLLVM_CCACHE_DIR="${CCACHE_PATH}" -DLLVM_CCACHE_MAXSIZE=20G     -DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_CXX_FLAGS=-gmlt     -DLLVM_LIT_ARGS="-v --xunit-xml-output ${WORKSPACE}/build/test-results.xml"

# clean build
time ninja all
# incremental build
time ninja all

results: https://docs.google.com/spreadsheets/d/1ArXlUQYUbdumUXQakWKSbeo1ttMRP4QcoiAf_7-fB3M/

Testing is sublinear because of Amdahl's Law. In short, as more cores are added, the time to complete the test suite equals the time to complete the longest test. Adding more cores means fixing slow tests or relegating them to a bot that only tests "long tests" (Swift has this development model).

In short, as more cores are added, the time to complete the test suite equals the time to complete the longest test.

This applies equally to the building phase though right? (which suffers from the link being a bottleneck frequently)

Yup. That being said, developers are more motivated to fix slow compiles or links than slow tests.

For example:
d488daa0329c6d6edac929687fa842f759375c1a
d15f31936a5987a06066a2d49fba388c69a027eb


Sidebar Menu: Update UI

@alexhoffman617 @duluca  please add more details, or close.

yeah, check on load
do leave a daily periodic check running in the background
but feel free to remove the setting about it
and thus all questions about it etc
or by default do you think weekly?
OR
check on load, but throw a notification bubble on the side bar icon
therefore no need for continuous reminders
ah I got it
so like that
but just show 1
and the Play icon on the sidebar, we can swap it out with a Refresh icon
which would re-run the update-check logic

so if you update
and 1 is still showing
if you hit refresh, it'd go away
otherwise goes away when you restart IDE

@duluca currently we have a play button that will re-run the update. The side ui is not very rich in terms of showing updated graphics from what I can tell. Rather it is more for list and item operation. More brainstorming may be required or use of webpanel.


Errors compiling with external protobuf and abseil

What version of gRPC and what language are you using?
grpc v1.30.2
What operating system (Linux, Windows,...) and version?
Linux Mint 19
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
What did you do? What did you expect to see? What did you see instead?
I am trying to build protobuf against external installations of abseil and protobuf that are not in the standard system installation locations, ie /usr/include.  In doing this I had to overcome two specific issues that I wanted to get clarification on usage or input so that I could help contribute the modifications back to the repo.

Issues with referencing an external directory for protobuf installation.

When I specified the -DgRPC_PROTOBUF_PROVIDER=package flag at build time, the FindProtobuf.cmake file does not resolve the installation without additional information.  I was able to make this work by providing the -DProtobuf_ROOT=${protobuf_install_location} and -DCMAKE_POLICY_DEFAULT_CMP0074=NEW flags at build time as well.  A couple of suggested improvements here could make this easier, either adding the cmake_policy(SET CMP0074 NEW) insde the cmake/protobuf.cmake file or potentially exposing an additional variable like -DgRPC_PROTOBUF_ROOT.  Also adding some addition documentation on how to handle this specific case.

Abseil package provider not available.

When specifying -DgRPC_ABSL_PROVIDER=package flag there is an error:
CMake Error at cmake/abseil-cpp.cmake:38 (find_package):
  Could not find a package configuration file provided by "absl" with any of
  the following names:
abslConfig.cmake
absl-config.cmake

Even with the CMP0074 policy set, something like adding DABSL_ROOT=${abseil_install_location} still does not work.  I was able to make it work by providing the install location with the -DCMAKE_PREFIX_PATH argument.  Maybe either making some adjustments in cmake/abseil-cpp.cmake or adding a new cmake/modules/FindAbsl.cmake file would make this behavior a little more natural?
Anything else we should know about your project / environment?
I am using cmake version 3.18.0

Get exactly the same issue trying to install to docker with the following dockerfile:
FROM debian:stretch

RUN apt-get update && apt-get install -y \
  build-essential autoconf libtool git pkg-config cmake \
  && apt-get clean

# install protobuf first, then grpc
ENV GRPC_RELEASE_TAG v1.35.x
RUN git clone -b ${GRPC_RELEASE_TAG} https://github.com/grpc/grpc /var/local/git/grpc && \
    cd /var/local/git/grpc && \
    git submodule update --init && \
    echo "--- installing protobuf ---" && \
    mkdir -p cmake/build && \
    cd cmake/build && \
    cmake ../.. && \
    make && \
    cmake ../.. -DgRPC_INSTALL=ON -DCMAKE_BUILD_TYPE=Release -DgRPC_ABSL_PROVIDER=package \
      -DgRPC_CARES_PROVIDER=package -DgRPC_PROTOBUF_PROVIDER=package -DgRPC_RE2_PROVIDER=package \
      -DgRPC_SSL_PROVIDER=package -DgRPC_ZLIB_PROVIDER=package && \
    make && make install

Tried both ENV GRPC_RELEASE_TAG v1.35.x and v1.37.x with the same error.

Same here, does anyone know of a workaround?

I was able to make it work by providing the install location with the -DCMAKE_PREFIX_PATH argument. Maybe either making some adjustments in cmake/abseil-cpp.cmake or adding a new cmake/modules/FindAbsl.cmake file would make this behavior a little more natural?

@jgornowich, could you provide the command that got it working for you?

Friendly ping as this is still reproducible

Still reproducible :(

Still having the problem in 2023.

looks like the "lang/other" tag resulted in this not getting attention

@jgornowich How did you install protobuf and absl? We install protobuf and absl in our CI and haven't run into such issues.

@Scrier In your example, I don't see a command to install protobuf.

@yashykt : I am not installing it , im building it from source and installing it. with the make && make install

@Scrier I meant that your commands use gRPC_PROTOBUF_PROVIDER=package but it doesn't seem that you are installing protobuf. Can you remove that option and try again?


Further Customization of Strata Regions

Please describe the feature you'd like to see:
This feature has already been discussed on discord but I'll put it here as a reminder just in case.
I'd like to see a feature dedicated for customizing the strata. For instance the strata can be tweaked by using several sliders which would be similar how you would do biomes.
What considerations for gameplay/performance/user-experience should be made:
It should be easy to use and have some safe-guards to prevent in-game crashes.
What alternatives or examples have you considered:
None.

"What considerations for gameplay/performance/user-experience should be made:"
Sometimes 1-block-thick layers are ugly, and it'd be nice to be able to put weights on particular types of stone (i.e. igneous, sedimentary, metamorphic) if they are tagged as such in their respective mods (if such a thing is possible, @Quizer9O8 might be able to do so with Strata and other mods' stone that isn't tagged is treated merely as vanilla stone).
Sometimes when you find a particular stone type you like and then realising it's only 1-block-thick in the strata layers can be a little frustrating.

There can be a 'strata region size' slider.

The rest of the system is too dynamic to represent with a static UI but is very flexible should 3rd party mods what to take control via the API.
The strata system was added in part to encourage exploration - if that isn't a user's "jam" then they can:

disable it
make a datapack to remove the stone types they don't want
use a datapack to make other stone types usable in crafting recipes

I see. However there aren't particularly stones I (or perhaps others) want to remove, but just have thicker layers of them. A slider or two to adjust the min and max thicknesses of each layer would be a neat feature to have.

As explained above, that won't happen


Hide wheels directory used on Debian-like systems (Ubuntu)

Reasons for making this change:
I keep having to do this when I create virtual environments for development on Ubuntu 18.04.1 LTS, so I thought it might help others to add it here. This affects all virtual environments created using, e.g., python3 -m venv ., in my experience.
Links to documentation supporting these rule changes:
This seems to be required by Debian Python Packaging Policy as outlined in Section 3.2 here
In particular:

When these binary packages are installed, *.whl files must be placed in the /usr/share/python-wheels directory. The location inside a virtual environment will be rooted in the virtual environment, instead of /usr.
(emphasis added to original)

🙇

@TwoBitAlchemist thanks!


Describe the order tags are sorted in and add tests

Tags are always deduplicated, and alphabetically ordered.
This is not true. They are at least not sorted.

Hi @nixjdm. I think you'd opened this issue as a result of my mentioning that the lektor-tags README.md says "Tags are always deduplicated, and alphabetically ordered". I'd asked how to sort them in my templates\macros\blog.html, and you helpfully told me I could just do the sort like this:
{% for t in post.tags | sort %}
I just came across a reason, though, why we might not want tags automatically sorted by lektor-tags. I've been adding some meta tags to my web site (under development) recently. One of them is:

For a blog post tagged via lektor-tags, the tags are just the right thing to use for the keywords list.
But according to both https://www.metatags.org/meta_name_keywords and https://www.metatagseo.com/, this meta tag should ideally list keywords in descending order of importance.
Currently:
{% for t in post.tags %}
orders a blog post's tags in the order they were entered in the post's contents.lr.
That allow a user to choose what order he wants them displayed in blog posts, a blog index page, and/or a 'keywords' meta tag.
He can either default to the order the tags were entered in, or sort them.
I now think this current implemtation is the desired behavior.
So, rather than changing lektor-tags to sort the tags, I'd recommend instead removing ", and alphabetically ordered" from the lektor-tags README.me.
And, perhaps, (for newbies like me) underneath the README.md's suggestion to use "{% for t in this.tags -%}" in templates\blog-post.html, mention the option to sort it with "{% for t in this.tags | sort %}".
{I used post.tags, instead of this.tags, since I did this in templates\macros\blog.html, rather than templates\blog-post.html.}
Thanks.

Thanks @RussellJQA, that makes sense. I rewrote the title of this issue, and I'll close this after rewriting the readme some. Thank you for presenting an argument for keeping the tag sorting the way it is. I didn't realize it's order was consistently the order in which they were created. That's something we could add a test for too, since we're looking at it as a feature now.

You're welcome @nixjdm. Thanks for all of your hard work maintaining Lektor.

I changed the Readme by specifying the current order and how to manipulate it with Jinja here https://github.com/nixjdm/lektor-tags/commit/5a7d36dd927c2529678d9105cac5d70e9948d841. I'll make a separate ticket for general testing.


Updating textarea content before submit

It's a question, not an issue
Browser version: Safari 12 / Chrome 69
OS: macOS
Screen resolution: 2560 x 1440
How to reproduce the bug?
Hi! I was trying to find some information about that by browsing all issues, but couldn't find necessary details.
I run Trumbowyg on multiple objects on page by class .texteditor (inputs and textareas) I understand that script updates them automatically after clicking submit form. But the problem is that I also have some code that I want to perform after changes in textarea.
What I'm trying to do is something like that:
$('.texteditor').trumbowyg().on('tbwblur', function(){
	--UPDATE THIS TEXTAREA OR INPUT WITH CONTENT FROM TEXTEDITOR--
});

But I don't know how to call to the current textarea that is edited by Trumbowyg... If I had only one I could do that by ID, but in that case... I found something about "syncTextarea", but there's nothing about it in documentation and I don't know how to use it...
If you could explain this to me, I would be grateful!

Ok, I came up with something like this:
$('.texteditor').trumbowyg().on('tbwblur', function(){
	var TXT = $(this).trumbowyg('html');
	$(this).html(TXT).trigger('change');
});

...and it works 😊 But could you explain if there is maybe better way to do that? Or what is 'syncTextarea" and how to use it?
Thanks!

Why did you just not use trumbowyg on a textarea?

Well, that's exactly what I did, my .texteditor class was assigned to textarea, but it wasn't automatically updating its' content...

Try some hacky way:
$('.texteditor').trumbowyg().on('tbwblur', function () {
	$(this).trumbowyg('execCmd', {cmd: 'syncTextarea'});
});

Idk if this works ^^'

Hey. Same problem happened to me. I applied trumbowyg on $('textarea'). It is correctly appearing but not refreshing textarea when i am pressing key. So i added this
$('textarea').trumbowyg().on('tbwchange', function () {
	$(this).trumbowyg('execCmd', {cmd: 'syncTextarea'});
});

The tbwchange event is correctly fired, but then nothing :(
I am using the master version.

Actually i have a form with different input and textarea, the submit button is calling an ajax method. I correctly get data from raw input and textarea but i get nothing from the textarea replaced by trumbowyg.
I suppose trumbowyg is suppose to be in a form so it should works correctly.

Trumbowyg does not need to be in a form. It should works... Can you make a demo page of the bug with jsbin or something like this?


Add MsgFlag::MSG_NOSIGNAL

(I guess I will see if I did the cfg block correctly)

Looks good, but could you please add a CHANGELOG entry?

Changelog is done, I checked libc and realized I forgot illumos so that is added.

bors r+


Update examples

Hey there,
As boot2docker is deprecated and gcloud container is not longer in preview you might want to update the setup steps for the examples.
Thx

Hello,
I have an additional request, would be great to have the examples updated with Google Cloud Run.
thank you.

Closing: this has been replaced by a new image, which has up-to-date instructions: https://hub.docker.com/_/dart


fix google pay catch error message

Summary
google pay cancel event propagate [object object] instead of statusMessage
Tested scenarios
catched error is string not [object object]

@strublos thanks for contributing to the repository.
Can you share step-by-step how to get the  [object object] as part of the error message?
I am not managing to get this on my environment. Ex: When closing the pop-up, I get proper error message in the onError callback.

@ribeiroguilherme Hi I not able to reproduce this error, but we are logging these type of error and get only [object object]. If you look at interface PaymentsError there is statusMessage, so log error with error.toString() is nonsense, it is object.

Hi @strublos ,
Sorry for the delay getting back to you.
We didn't really manage to reproduce the error being logged as [object object] . We tested by closing/cancelling the GooglePay pop-up,  and we are getting the CANCEL AbortError: User closed the Payment Request UI message.
I also tested applying your proposed changes but the statusMessage message is being returned undefined  (at least in the CANCEL scenario), so this fix would not work unfortunately.
In this case, I can suggest you to access the error object that comes within the cause  property. You can access it and perhaps report back the error.message and see if it works for you.
Thanks for reaching out!


invalid memory address error when joining github_user on a column with null value

repro
create table test (full_name text, author_login text);

insert into test (full_name, author_login) values ('aws/aws_cdk', '0gajun');
insert into test (full_name, author_login) values ('aws/aws_cdk', '14kw');
insert into test (full_name, author_login) values ('aws/aws_cdk', null);

 select
    g.login,
    g.name,
    g.company,
    g.email,
    g.twitter_username
  from
    github_user g
  join
    test t
  on
    t.author_login = g.login;

ERROR: runtime error: invalid memory address or nil pointer dereference

background
I was revisiting the scripts at https://github.com/turbot/steampipe-samples/tree/main/github-external-contributor-analysis, and they were failing for the above reason.
I added a null check, e.g. https://github.com/turbot/steampipe-samples/blob/main/github-external-contributor-analysis/aws_cdk.sql#L48, which solved the problem, but had to do a lot of printf-style debugging in the github plugin in order to track it down.
issue-specific discussion
The scripts haven't changed since I wrote them, and I would guess there were always commits with null author_login, so I wondered if this was a regression since v.9 which was the version in play when the scripts first ran successfully. However I tried rolling back to that Steampipe/github-plugin combo and was still hitting the error, so I dunno.
general discussion
It seems generally hard to assemble context around this class of error when it happens. I'm wondering: is that just how it goes with golang (terrible pun, sorry), or are there ways the app could deliver more context when this happens.

@kaidaguerre thanks for the quick action here.

golang seems pretty bad when nil pointer exceptions occur - it can be very hard to trace the issue.

I'm a newbie but yeah, that's my observation so far. It's tempting to gripe about ignoring lots of experience with exception handling in other languages, but I'm trying to keep an open mind here, and will be interested to see how this evolves as we go forward.


Freeze: Formatting message with Soap message takes to long time, skipping this formatter

This Soap Message formatter is freezing the whole app, related message can be shown in internal logs.
Formatting message with Soap message takes to long time, skipping this formatter
Disabling it is indeed solving the freeze issue

Can you append a example Logfile with a working parser?

@donatelloOo it would be very helpful to get the steps for reproducing this issue so that we can get it fixed.
Can you provide the app version where this was first encountered?
Can you also provide an example log file (as @svennissel previously requested) so that we can try and reproduce it? We will also use that file to test the fixed code.

I am reproducing it using OLV 1.4.15 with Socket Listener using Log4j2 Json Parser.
Thus I don't have a file to share, but it can be reproduced every time for a log4j2 producer with following configuration:
Configuration:
  status: info
  monitorInterval: 300

  properties:
    property:
      name: AsyncLogger.ThreadNameStrategy
      value: UNCACHED

  appenders:
    Socket:
      name: SocketJsonAppender
      host: localhost
      port: 50505
      connectTimeoutMillis: 3000
      JsonLayout:
        eventEol: true
        compact: true
        charset: UTF-8
        endOfLine: "\n"
        properties: true
        locationInfo: true
        includeStacktrace: true
        stacktraceAsString: true

    Root:
      level: info
      AppenderRef:
        ref: SocketJsonAppender

I created a spring boot application with a socket appender
<?xml version="1.0" encoding="UTF-8"?>
<Configuration>
    <Appenders>
        <Console name="console" target="SYSTEM_OUT">
            <PatternLayout>
                <Pattern>%d %p %c{1.} [%t] %m%n</Pattern>
            </PatternLayout>
        </Console>
        <Socket name="SocketJsonAppender" host="localhost" port="50505" reconnectionDelayMillis="5000">
            <JsonLayout eventEol="true" compact="true" charset="UTF-8" properties="true" locationInfo="true" includeStacktrace = "true" stacktraceAsString="true" endOfLine="\n">
            </JsonLayout>
        </Socket>
    </Appenders>

    <Loggers>
        <Root level="info">
            <AppenderRef ref="console" />
            <AppenderRef ref="SocketJsonAppender"/>
        </Root>
    </Loggers>
</Configuration>

In the application i log a soap message:
for(int i=0; i<1000; i++) {
      LOGGER.info("<?xml version=\"1.0\"?>\n" +
        "<SoAp:Envelope xmlns:SoAp=\"http://schemas.xmlsoap.org/soap/envelope/\">\n" +
        "  <SoAp:Header>\n" +
        "  </SoAp:Header>\n" +
        "  <SoAp:Body>\n" +
        "    <m:GetStockPrice xmlns:m=\"http://www.example.org/stock\">\n" +
        "      <m:StockName>aaa</m:StockName>\n" +
        "    </m:GetStockPrice>\n" +
        "  </SoAp:Body>\n" +
        "</SoAp:Envelope>");
      Thread.sleep(3_000L);
    }

for me it works fine. I use the version 1.4.18.
Did you have very big soap messages?
What happens if you deactivate soap or all other formatter?

Actually the issue happened on standard messages.
No need to produce a soap message log, a hundred of very simple strings like "[INFO] com.exemple.logger Starting app..." should be enough to reproduce.
Workaround is indeed to disable (all) the formatters, especially soap one, but as they are enabled by default it's a recurrent issue.

I cannot reproduce it. I have generate 20000 Messages in a second with and without soap. I see no internal log entries. The formatting of messages took 2ms - 160ms. Sorry with no logfiles or samples I cannot help you.


Improve union of multi markers

Relates-to: https://github.com/python-poetry/poetry/issues/5192

[x] Added tests for changed code.
[ ] Updated documentation for changed code.

Improves the union of multi markers with all kinds of markers. See added test cases for new simplifications that were not possible before.
Improving the union of multi markers is similar but a bit more complicated than #226. That's because both MarkerUnion.intersect() and MarkerUnion.union() as well as MultiMarker.union() prefer to return a MarkerUnion of MultiMarkers instead of a MultiMarker of MarkerUnions. Therefore, in addition to the standard MultiMarker.union() method a MultiMarker.union_simplify() method is introduced. This method prefers to return a MultiMarker instead of a MarkerUnion, but returns None if no simplification is possible in order to avoid an endless recursion.

@dimbleby I wonder if you might review this change? Even if your review doesn't affect mergeability, I think it could increase confidence and speed up the process, since you have already made some changes in that direction and seem to have a good understanding of marker handling.

This is all getting quite elaborate, isn't it?
I don't see a way in which this is not correct, it clearly does achieve some new simplifications and the test coverage is reassuring.
However... I must admit that I am finding it quite hard to follow!
We are beginning to reach diminishing returns on these marker simplifications: this one is a fairly significant increase in overall complexity, for relatively modest gains.
To my taste - and probably this is a matter of taste, reasonable people might disagree - I think it's not worth it.
But that's not a hill that I would want to die on, I don't intend to argue about it.  As I say, I don't see bugs.

I can understand your concerns and I agree that it is a significant increase in complexity but I think it is a significant gain, too. If it was just about cosmetics I might even doubt whether it is worth it. But the main reason why marker simplifications are necessary is that they lay the foundations for reducing the number of overrides (regarding python-poetry/poetry#4695) - and that is not just a performance issue.
Any omitted marker simplification can lead to an unnecessary override and any unnecessary override can lead to an unnecessary failure in dependency resolution because the solver tries to find a solution for a case that is not relevant due to markers that can never be fulfilled. Considering that users experiencing an unfounded solver failure sometimes can't do anything but reducing the number of supported python versions, I think it's worth it.
Nevertheless, thanks for the review. If someone comes up with a simpler solution, I will be happy to adopt it. If there isn't one, at least in my opinion a complex solution is better than no solution at all.


feat(esdoc-brand-plugin): add support for varying logo types

Adds support for any type of image supported by browsers as the brand logo. Prior to this change, only .jpg was allowed.

Thank you, bencevans!


docs: Expand on how to use the crate

Fixes #31

I think you consider this PR ready. I will merge i as soon as actions succeed.


enable to build binary with cn GOPROXY

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement

What this PR does / why we need it:
Originally, make build does not respect env REGION. Thus, when user uses REGION=cn, the build command will still use GOPROXY as go env GOPROXY which may be not reachable in China. This PR can solve the problem.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm


Add Option to Select Supplier

When creating a new invoice from ERPNext, there should be an option to fill the supplier name and id boxes by beginning to type the supplier name, then selecting from the list of options that match

Can autocomplete by supplier number but should be able to autocomplete by supplier name as well


Use vueuse scroll lock on root

#12

@Elliot-Alexander  we can close this out as the IOS scroll prevention should already be included in Dialog component from radix-vue 😁


insert html file by built local machine.

GitHub Actions !!!!
Signed-off-by: i13302<EMAIL_ADDRESS>

#9


fix(reset validation to default): reset validation to default

reset validation to default

:tada: This PR is included in version 2.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


refactor modelgen.NewGenerator use WithXXX to pass options

As discussed in https://github.com/ovn-org/libovsdb/pull/159#discussion_r650986095

Pull Request Test Coverage Report for Build 937801318

10 of 19 (52.63%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 72.329%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

modelgen/generator.go
10
19
52.63%

Files with Coverage Reduction
New Missed Lines
%

modelgen/generator.go
1
40.43%

Totals

Change from base Build 928973283:
-0.1%

Covered Lines:
2857

Relevant Lines:
3950

💛  - Coveralls


Please provide example for creating a correlation filter rule.

Could you please provide an example for creating correlation filter rule.  We I try to specify a correlation filter argument (like --to), it errors out saying:
BadRequest - Value cannot be null.
Parameter name: sqlExpression

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fd5960a-ea47-7542-6837-3e4e49e95d0a
Version Independent ID: c8a9f5b6-2a2f-4820-3be4-c87e3896a6b7
Content: az servicebus topic subscription rule
Content Source: src/azure-cli/azure/cli/command_modules/servicebus/_help.py
Service: service-bus
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@damiandiaz76, thank you for your inquiry. This helps us understand any gaps in our documentation or samples. We are looking for a public document that provides an example of a correlation filter rule.

By the way, please provide the filter that you are using? It sounds like you are using a SQL filter expression.

I'm trying to not use an sql filter.  I want to create a correlation filter.  I want this correlation filter to use the "to" field.  I tried specifying the "--to" option: "--to requests" but received the sqlExpression error.

Related to https://github.com/Azure/azure-cli/issues/12369.

HI @damiandiaz76 , this has been fixed in our latest release. You should be able to create SQL filter rule now.
Here is some sample cmdlet example : az servicebus topic subscription rule create --resource-group {rg} --namespace-name {namespacename} --topic-name {topicname} --subscription-name {subscriptionname} --name {rulename} --filter-type CorrelationFilter --correlation-id r00012d --label myvalue --message-id mid --reply-to reply --session-id ids --reply-to-session-id hi --content-type hi --to hi
Please test it out and let us know in case you observe any discrepancies.

I tried out the command to add a correlation filter using the --to option and it worked.  Thanks for the update.

Thanks for confirming @damiandiaz76. With above confirmation, I would mark the issue as closed.


elasticsearch_dsl.exceptions.IllegalOperation

运行model中的文件时，会报错：elasticsearch_dsl.exceptions.IllegalOperation: Index object cannot have multiple types, doc already set, trying to assign article.

@saler-1  请确认你下载的是elasticsearch-rtf以及安装的elasticsearch dsl 版本:
elasticsearch==5.5.2
elasticsearch-dsl==5.3.0


recipe for target 'run' failed

Im getting the following error on make run
(nltk) shan@shan-HP-ZBook-15:~/Accelirate/sequence_tagging$ make run
python build_data.py
Building vocab...
- done. 20312 tokens
Building vocab...
- done. 400000 tokens
Writing vocab...
- done. 17789 tokens
Writing vocab...
- done. 45 tokens
Writing vocab...
- done. 84 tokens
python train.py
/home/shan/python-virtual-environments/nltk/lib/python3.6/site-packages/tensorflow/python/ops/gradients_impl.py:108: UserWarning: Converting sparse IndexedSlices to a dense Tensor of unknown shape. This may consume a large amount of memory.
  "Converting sparse IndexedSlices to a dense Tensor of unknown shape. "
Initializing tf session
2018-10-10 15:13:20.715735: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
Epoch 1 out of 15
702/702 [==============================] - 453s - train loss: 9.3642
Traceback (most recent call last):
  File "train.py", line 26, in <module>
    main()
  File "train.py", line 23, in main
    model.train(train, dev)
  File "/home/shan/Accelirate/sequence_tagging/model/base_model.py", line 121, in train
    score = self.run_epoch(train, dev, epoch)
  File "/home/shan/Accelirate/sequence_tagging/model/ner_model.py", line 295, in run_epoch
    metrics = self.run_evaluate(dev)
  File "/home/shan/Accelirate/sequence_tagging/model/ner_model.py", line 324, in run_evaluate
    lab_chunks      = set(get_chunks(lab, self.config.vocab_tags))
  File "/home/shan/Accelirate/sequence_tagging/model/data_utils.py", line 398, in get_chunks
    default = tags[NONE]
KeyError: 'O'
makefile:7: recipe for target 'run' failed
make: *** [run] Error 1

The original format of CoNLL-2003 are as follows:
Indian NNP I-NP I-MISC
all-rounder NN I-NP O
Phil NNP I-NP I-PER
The tag is in the fourth column, so you need to modify 'model/data_utils.py', in Line 75:
word, tag = ls[0],ls[1]------->word, tag = ls[0],ls[3]

This is an out-of-vocabulary issue (some tags are not in the vocab).


Checking for specific functions

Support checking of not using specific functions / classes of packages, e.g.,"do not use fmt.Prinln", but some logging library instead.
[ Idea by @datosh, I moved this from the README to an issue for better discussion ]

Imo, this is out of scope for a unit testing package. It would require much more complex parsing of the source code, where we currently only parse the imports. Something like this can be better archived with static checkers like ashanbrown/forbidigo.


Using env (previously constant) in a calc

Using env (previously constant) within a calc throws a syntax error e.g.
padding-left: calc(10px + env(safe-area-inset-left));

This should be valid CSS, but postcss-cssnext flags it as a syntax error:

Error: Parse error on line 1: 10px + env(safe-area-inset- -------^ Expecting 'SUB', 'LPAREN', 'NESTED_CALC', 'NUMBER', 'CSS_VAR', 'LENGTH', 'ANGLE', 'TIME', 'FREQ', 'RES', 'EMS', 'EXS', 'CHS', 'REMS', 'VHS', 'VWS', 'VMINS', 'VMAXS', 'PERCENTAGE', got 'PREFIX'

See:

https://www.quirksmode.org/blog/archives/2017/10/safeareainset_v.html
https://css-tricks.com/the-notch-and-css/
https://webkit.org/blog/7929/designing-websites-for-iphone-x/

I run into the same issue. For now, the only solution I've figured is disabling reduce-css-calc - e.g.:
require('postcss-cssnext')({
  features: {
    calc: false
  }
  ...

Of course, this has its own implications.

@vadikom Thanks for the response.
Is this something that should be raised as an issue with reduce-css-calc do you think?

I believe it's actually a known issue:
https://github.com/MoOx/reduce-css-calc/issues/34

Possibly resolved by #445 as a side effect of dropping calc minification.

postcss-cssnext has been deprecated in favor or postcss-preset-env. Read more at https://moox.io/blog/deprecating-cssnext/


Comment:Chat-Processing

I wasn't asked what method the hook should be used on.

Make you have the latest version of feathers-cli. feathers --version should show 2.3.7 or later.
When generating the hook make sure you do not pick the "I will add it myself" option. You will then be prompted for the type, service and methods:


Lock membership keys after peer provider call

What changed?
Membership keys locking is done later

Why?
Depending on Peer Provider implementation, locking at the begging is a risk to block for too long

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 2a7896d4-d6d5-4b8d-9c4f-6b3e1c26a8d0

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
104 unchanged lines in 12 files lost coverage.
Overall coverage decreased (-0.05%) to 56.833%

Files with Coverage Reduction
New Missed Lines
%

common/membership/hashring.go
1
84.81%

common/task/weightedRoundRobinTaskScheduler.go
1
89.64%

service/matching/matcher.go
1
91.06%

common/task/parallelTaskProcessor.go
2
92.75%

service/history/handler.go
2
48.69%

service/history/shard/context.go
2
66.02%

common/types/history.go
4
24.89%

service/history/historyEngine.go
4
71.65%

common/task/fifoTaskScheduler.go
5
84.54%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
9
54.59%

Totals

Change from base Build 587bfc12-0d97-4912-92e3-8afd1a5a268c:
-0.05%

Covered Lines:
82917

Relevant Lines:
145897

💛  - Coveralls


I put some colors in html with the style tag but nothing append :/

Nobody knows why plsss :+1:  ?!

maybe you have some print css overwrites. If you're using bootstrap, that's most likely the problem.


Sliding

can u add sliding

Sorry for a very delayed response. Sliding would be a pretty complex thing to add, but if there is demand for it then I will get to work on implementing it. I haven't really played any games that have sliding, (and if I have I didn't use it) but I can just look up how it works.

Sliding is turning out to be a very difficult thing to add because I don't know what the end result looks like. Hopefully someone can figure this out in the future.


[move-prover] make the no_opaque test ignore internal functions only - (27)

Motivation
To reduce CI time, Instead of ignoring  pragma opaque for all test functions , we are now ignoring only for internal functions  And also to align with intended below use cases
Prior to this commit, the no_opaque test ignores pragma opaque in almost every function.
Although the prover does not time out in 40s, this is still a non-trivial amount of time spend in unit test. More importantly, this might not align with what we have envisioned for how the specs are supposed to be written: specs are expected to be written and complete for public-facing functions --- as a result, the public-facing functions can be opaque from a verification point of view, hence increasing compositionally of the specs. Inlining public functions destroy such compositionally.
A lot of the .exp file updates are due to the removal of the
// separate_baseline: no_opaque directive in certain files. The key
change will be highlighted below.
This PR also cleans up a few inv-v1_exp and inv_v2_exp files, as
we do not have the inv-v1 test anymore.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI

:sunny: Canary successful

/land

:lock: Merge Conflict

/land

:lock: Merge Conflict

/land

:lock: Merge Conflict

/canary

:lock: Merge Conflict

/canary

/canary

:broken_heart: Test Failed - ci-test

:broken_heart: Test Failed - ci-test

/canary

:broken_heart: Test Failed - ci-test

/land

:broken_heart: Test Failed - ci-test

Closing this PR due to technical error, raised new PR
New PR link : https://github.com/diem/diem/pull/10569


Allow targeted env var for CRATE_CC_NO_DEFAULTS and CROSS_COMPILE

I needed to do this:
export CROSS_COMPILE_arm_unknown_linux_gnueabi=arm-none-linux-gnueabi

@m-ou-se Sorry for tagging you. Is it possible to get this merged? Is there anything else that is needed?

Can you share a bit more about the use cases?
Does setting CC_arm_unknown_linux_gnueabi=arm-none-linux-gnueabi-cc not suffice?
Specifically for arm-none-linux-gnueabi, it might be best to change prefix_for_target to use find_working_gnu_prefix for arm-unknown-linux-gnueabihf to automatically pick between arm-linux-gnueabihf and arm-none-linux-gnueabihf, such that no environment variables are necessary at all.

Thanks, I didn't know that you could specify CC_arm_unknown_linux_gnueabi. This works for me:
CC_arm_unknown_linux_gnueabi = "arm-none-linux-gnueabi-gcc"
CXX_arm_unknown_linux_gnueabi = "arm-none-linux-gnueabi-g++"
AR_arm_unknown_linux_gnueabi = "arm-none-linux-gnueabi-ar"

I will open PR with find_working_gnu_prefix  a bit later.


Added Api

Bookstore: connect to API
In this branch, I have connected the React-Redux application to an existing API to create and remove books on a remote server.

In the list below, I have highlighted all the activities made in this branch.

Highlights :+1:

[x] I have fetched the book list from Bookstore API on Books page load.
[x] I have added an Action Creator, that returns a function.
[x] I fetched the list of books.
[x] I dispatched another action that will pass the API response to the reducer and update the state.
[x] I refactored the add book and remove book features to persist changes in the server.
[x] I changed the existing Action Creators, so they return functions.
[x] I made all changes by using API.

Cheers and happy reviewing! :v:

Thank you @DammyShittu
I have fixed the issue now

https://github.com/TuyishimireEric/bookstore/blob/2befb0f2233e8cad339daced1ac42144adb1304f/src/redux/configureStore.js#L1-L12
According to the project requirements, you should use createAsyncThunk for creating thunk action creators.

You don't have to use the code exactly as written in the example, just make sure you employ the createAsyncThunk method. Please make sure you refactor all of your action creators using this method.

Thank you @uwadonat for approving my project :+1:


Retry streaming exceptions (this time for sure, Rocky!)

Supersedes #3930.
Closes #3775.
/cc vkedia

@vkedia, @bjwatson PTAL

After @vkedia says yes, I will start the process for a Spanner release.

Thanks @lukesneeringer, @tseaver, and @jonparrott!

Is this approved, @vkedia?


RHOARDOC-1441

Sorry about the build issues, will fix this ASAP.

@geoand , I've put together a metrics procedure based on the metrics configuration section of the micrometer documentation.
I had to create an example of an annotated method, which is probably not completely correct, and I'd a appreciate any suggestions for improvement:)
Please let me know what you think. Thank you.

@geoand @liborfuka @tradej @Ladicek Thank you for the feedback. I've updated the PR based on your comments, please let me know what you think.

@tradej Please feel free to merge if everything looks OK to you. Thank you.


Too small buffer size, too big viewport problem

Some kind of race condition occures when the viewport is big enough while the "buffer-size" is small enough.  Look at the demo! Scroller tries to break through the top border of the viewport. 5 times it loads data packs (of 3 items, per "buffer-size" = 3) and scroll position does not change, it stays at the very bottom, while should move up per each iteration.

Workaround: play with "buffer-size", "padding" and the viewport height.

I've played a lot with butter-size and padding but it didn't work for me. The only thing that solves it in my app is to give every item a fixed size in CSS. Using computed values like ng-style doesn't seem to work.

@MisterDev The problem has been fixed in effective-height branch and it will be included in the next release. The branch' distributive is also available: https://raw.githubusercontent.com/angular-ui/ui-scroll/effective-height/dist/ui-scroll.js.

The fix is in 1.7.0-rc.2 published version.


fix: loading pre 1.11.0

Currently can't load results without version, e. g. {"test": {"en": {"accuracy": 0.7285810356}}, "mteb_dataset_name": "MassiveIntentClassification"}
Checklist

[X] Run tests locally to make sure nothing is broken using make test.
[X] Run the formatter to format the code using make lint.

@Samoed can you add an empty commit starting with fix: ? That way we'll get a new release

If you are about CI I rerun failed test

@x-tabdeveloping added commit

Cool!


Allow events to have multiple options for times

This is related to #416.

[ ] In Contentful, make a content type called Date - (should also include a registration link)
[ ] Make the Events link to multiple Dates
[ ] On the events page, show the different options on the card
[ ] On the event template, show the different options with registration buttons if there are multiple options, otherwise embed the registration form

Actually, I think this will be simpler:

[ ] In Contentful, make events link to other events and add a subtitle
[ ] On the events page, show the different options on the card
[ ] On the event template, show the different options with registration buttons if there are multiple options, otherwise embed the registration form


Sass hook contribution

Cool. Two things:

It would be nice to not crash and burn if the sass binary isn't available. I am going to see how it likes that right now.
It would be cool if the files weren't regenerated everytime, but the more I think about this, the less I think it would be easy, since SASS has a way to include on other files.

I added some error handling and logging as well.


Typings for Typescript

Any chance of including "typings" flag in your package.json pointing a typings.d.ts file with the following?
Would be helpful for Typescript.
"typings": "lib/typings.d.ts"

export interface IParsedDomain {
    domain?: string;
    subdomain?: string;
    tld?: string;
}
export declare type ParsedDomain = (url: string, customTlds?: RegExp | string[], privateTlds?: boolean) => IParsedDomain;

Shipped with v2.3.1


implementing the LMOVE and BLMOVE commands

closes #1503
closes #1447
Note - this passes in completion again - once my pr to fix unit tests is merged in. Checkboxes here are checked based on that assumption.
Pull Request check-list
Please make sure to review and check all of these items:

[X] Does $ tox pass with this change (including linting)?
[X] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[X] Is the new or changed code fully tested?
[X] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Added support for the redis lmove and blmove command, new in 6.2. See #1434

@abrookins The recent doc update for blmove now shows that a timeout was required. Updates to blmove and tests to reflect that are now in this PR.


Updated data model to handle duplicate gcp_inventory record

Creating another branch off 2.0-dev instead, the commit is not clean in this one.


Make the CLI more responsive

Closes #227.
Demo:

The main remaining bottleneck in the CLI's spinner is virtual environment creation itself, i.e. EnvBuilder.create(). We can probably hook further into that with the public interface it provides, but I figured that's best kept for a follow-up.


Bug - Failed to run tests

Hi everyone, everything fine?
I am running the following command:
sudo make test

and i am having these glitches how can i solve this?
Test Summary Report
-------------------
../test/recipes/80-test_ssl_new.t                (Wstat: 256 Tests: 29 Failed: 1)
  Failed test:  12
  Non-zero exit status: 1
Files=158, Tests=2640, 104 wallclock secs ( 2.14 usr  0.28 sys + 94.47 cusr 20.53 csys = 117.42 CPU)
Result: FAIL
make[1]: *** [Makefile:208: _tests] Error 1
make[1]: Leaving directory '/usr/local/src/openssl-1.1.1m'
make: *** [Makefile:205: tests] Erro 2

Try make test VERBOSE=1 to get proper output.

I also ran into similar fails. Adding VERBOSE=1 in "make test " does not provide extra error message:
`Test Summary Report
../test/recipes/80-test_ssl_new.t                (Wstat: 256 Tests: 29 Failed: 1)
Failed test:  12
Non-zero exit status: 1
Files=155, Tests=1264, 42 wallclock secs ( 0.70 usr  0.22 sys + 47.26 cusr  4.66 csys = 52.84 CPU)
Result: FAIL
make[1]: *** [Makefile:208: _tests] Error 1
make[1]: Leaving directory '/home/user/openssl-1.1.1g'
make: *** [Makefile:205: tests] Error 2
`

That's the end of the output.  Look back to where the SSL new test was run.  There should be more information there.

To just run the ssl_new test you can do this make VERBOSE=1 TESTS=test_ssl_new test

That's the end of the output. Look back to where the SSL new test was run. There should be more information there.

When running this command it returns me: make: Nothing to be done for 'test'.

marking as inactive, will be closed at the completion of 3.4 dev without further input


Memory allocations

While inspecting my project using derailed, I found a few critical parts of neo4j-core that could be rewritten to reduce memory allocations.
Here's the report before this fix:

allocated memory by gem
31097340  neo4j-core-6.1.4
....
allocated memory by location
18067500  internal:prelude:76
11602260  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/2.3.0/net/protocol.rb:172
7755258  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/multi_json-1.12.1/lib/multi_json/adapters/oj.rb:15
5084800  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/neo4j-core-6.1.4/lib/neo4j-core/query_clauses.rb:155

After this fix:

allocated memory by gem
27064240  2.3.1/lib
25810900  neo4j-core/lib
...
allocated memory by location
18067500  internal:prelude:76
11602260  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/2.3.0/net/protocol.rb:172
7755138  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/multi_json-1.12.1/lib/multi_json/adapters/oj.rb:15
3808240  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/2.3.0/net/http/response.rb:340
3404160  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-db5546e1b0ec/lib/neo4j/active_node/has_n.rb:228
3001600  /Users/progm/lavoro/neo4j-core/lib/neo4j-core/query.rb:335
2813080  /Users/progm/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/neo4j-db5546e1b0ec/lib/neo4j/active_node/query/query_proxy_link.rb:22
2758080  /Users/progm/lavoro/neo4j-core/lib/neo4j-core/query_clauses.rb:155
...

1-2758080/5084800 -> 45,7% less memory
31097340 - 25810900 = 5.286.440 ~ 5mb less memory in my test.
It's not that much, but it's something (and with no effort)
What do you think?
P.S. Since tests are broken, I can't check if it breaks something
Pings:
@cheerfulstoic
@subvertallchris

Coverage increased (+2.3%) to 67.099% when pulling 89caffd705b034cf7c761f3b1dd36107dbbabc2f on memory-optimizations2 into 5efe9c1b11378800b61a2b858572b1c7bf6610e3 on master.

This seems great!  master is failing because of half-finished new cypher API stuff in there (sorry ;( ).  My currently priority is to get that stable so that we can merge it back into master.  I'll like to get an alpha release soon so that we can start getting feedback on all of the great stuff that's been going in.

Coverage decreased (-0.6%) to 92.611% when pulling 4e7bd139d3853b51d2fc21e3dc0fa8f34bb5c56b on memory-optimizations2 into 03ee9a10488852a367e788dfa18b95dabc0dc25f on master.


Move generator to separate package

I think the correct way is to move the /example to the /packages/ folder, so Lerna will process its references to the devextreme-react package
And possibly rename it to Sandbox, how do you think?


Edge case for lens template processing in Google Map view

The following is a part of a custom lens template (for an image src tag) that is failing in the map view:
ex:src-content=".thumbnail"
An example of a definition for .thumbnail is -
http://maps.google.com/maps/api/staticmap?center=48.148376300000002,-122.4197436&zoom=2&size=100x100&markers=color:orange|label:|48.148376300000002,-122.4197436&maptype=satellite&sensor=false
When I inspect this element with FireFox Web Tools and 'Copy Outer HTML' it shows the following -
http://maps.google.com/maps/api/staticmap?center=48.148376300000002,-122.4197436&zoom=2&size=100x100&markers=color:orange|label:|48.148376300000002,-122.4197436&maptype=satellite&sensor=false
I use the same definition with both timeline and tabular views - which do not encode '&'  -  and therefore work as expected.
Note that this has become an issue since moving to Exhibit Version 3.0. Also note that this same Map Lens Template displays properly in IE. But I saw in the code where there is a fall-back to Version 2.0 for IE - which was very confusing at first.
I have scoured the source and cannot isolate where this might be happening.
See http://clearinghouse.marinedebris.noaa.gov/visualize for the site this is hosted on.
Thanks in advance for any insight.

I've got a student who may be able to tackle the underlying problem, but it would be easier if you could recreate the "broken" version for us to look at somewhere---since it will take effort to migrate your entire exhibit to our servers.

Unfortunately, we are in the midst of a reorganization and I don't have the
additional resources to provide a broken version.
On Tue, Apr 28, 2015 at 3:28 PM, David Karger<EMAIL_ADDRESS>wrote:

I've got a student who may be able to tackle the underlying problem, but
it would be easier if you could recreate the "broken" version for us to
look at somewhere---since it will take effort to migrate your entire
exhibit to our servers.
—
Reply to this email directly or view it on GitHub
https://github.com/simile-widgets/exhibit/issues/8#issuecomment-97198711
.


Existing pr e2e

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Replaced main with refs/heads/main for CodeQL

Current dependencies on/for this PR:

main

PR #189   👈

This comment was auto-generated by Graphite.


No classes or methods are public

None of them seem to be accessible when the lib is installed via Cocoapods. Am I missing something?

Apologies. I am new to Cocoa Pods and did not realise the requirements. I will try and fix it asap. Unless you want to help out of course ;-)

I tried to make some changes but now pod spec lint ... Would you have some time to take a look?

All good! I'll fork in a bit

Could you do a pull request with your changes?

Yup. Will do when I get it working

Resolved with
https://github.com/mmick66/KDDragAndDropCollectionView/pull/23

I still get
 -> KDDragAndDropCollectionViews (1.2)
    - WARN  | url: There was a problem validating the URL https://github.com/mmick66/KDDragAndDropCollectionView.
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - ERROR | xcodebuild:  KDDragAndDropCollectionViews/Classes/KDDragAndDropCollectionView.swift:51:31: error: use of undeclared type 'KDDragAndDropCollectionViewDataSource'
    - ERROR | xcodebuild:  KDDragAndDropCollectionViews/Classes/KDDragAndDropCollectionView.swift:85:52: error: use of undeclared type 'KDDragAndDropCollectionViewDataSource'
    - ERROR | xcodebuild:  KDDragAndDropCollectionViews/Classes/KDDragAndDropCollectionView.swift:118:60: error: use of undeclared type 'KDDragAndDropCollectionViewDataSource'
    - ERROR | xcodebuild:  KDDragAndDropCollectionViews/Classes/KDDragAndDropCollectionView.swift:195:54: error: use of undeclared type 'KDDragAndDropCollectionViewDataSource'
    - ERROR | xcodebuild:  KDDragAndDropCollectionViews/Classes/KDDragAndDropCollectionView.swift:295:46: error: use of undeclared type 'KDDragAndDropCollectionViewDataSource'
    - ERROR | xcodebuild:  KDDragAndDropCollectionViews/Classes/KDDragAndDropCollectionView.swift:335:60: error: use of undeclared type 'KDDragAndDropCollectionViewDataSource'

I do not know what I changed but it seems I cannot push it as a POD. The protocol is definitely there and the project runs fine (I hate cocoapods) Any ideas?

I think it might need to be retagged. 1.2 looks like it was before my fork.

You where right! I retagged on 1.3 and it worked.. I am now getting only one warning
 -> KDDragAndDropCollectionViews (1.3)
    - WARN  | url: There was a problem validating the URL https://github.com/mmick66/KDDragAndDropCollectionView.

Any idea to what it might be?

Well, it seems that the issue was here. Cocoa pods working again. Thanks!

Thanks a bunch :)


Throwing exception in a mocked method

Description
I am mocking a method in order to raise an exception (using Trompeloeil) and I want to check if its caller protect itself catching the exception correctly.
Steps to reproduce
This is a very simplified version of my code:
struct Foo
{
    virtual void mayThrow() = 0;

    virtual bool throwerCaller()
    {
        bool res = false;
        try
        {
            mayThrow();
            res = true;
        }
        catch(...)
        {
            res = false;
        }
        return res;
    }
}

The test should check whether the method mayThrow throws an exception, its caller method (throwerCaller) returns false.
    struct MockedFoo : Foo
    {
         MAKE_MOCK0( mayThrow(), void() );
    };

    TEST_CASE("Foo")
    {
         MockedFoo foo;
         foo.REQUIRE_CALL( foo, mayThrow() ).THROW( std::exception() );
         CHECK_FALSE( foo.throwerCaller() );
         // Even using CHECK_THROWS_AS( foo.throwCaller(), const std::exception& ) works
    }

Running this code it will abort due to a crash:
FATAL ERROR: test case CRASHED: SIGABRT - Abort (abnormal termination) signal

Not sure that this is an issue of Doctest or Trompeloeil.

doctest version: 2.3.3
Operating System: macOS 10.14.6
Compiler+version: clang-1<IP_ADDRESS>

well this is printed by the doctest framework - it has intercepted a SIGABRT signal... You could try defining DOCTEST_CONFIG_NO_POSIX_SIGNALS before including doctest in the entire test binary - that will disable signal catching on UNIX and you'll get the original SIGABRT message - virtual functions could be the reason for SIGABRT - here is one example of how you could shoot yourself in the foot with virtual functions and constructors/destructors: https://rextester.com/JVBF97486
I don't know enough about Trompeloeil but I doubt that this issue is related to doctest.

Thank you for the reply.
Anyway, that's strange, since my method throwerCaller is wrapping the call to mayThow with a try{} catch{}, so no exception should be propagated.
Uhm... Maybe it's a Trompeloeil issue?

I don't know... Did you try defining DOCTEST_CONFIG_NO_POSIX_SIGNALS so doctest doesn't capture the signals on its own? Have you tried stepping through the code with a debugger to see on which line the crash happens? Or perhaps even printf-debugging - logging messages between the lines?

I tried and now it's failing with another error:
The output from the failed tests:

1/1 automatictests                          FAIL     0.37 s (killed by signal 6 SIGABRT)

--- command ---
/.../build/tests/automatictests
--- stderr ---
terminate called after throwing an instance of 'std::exception'
  what():  std::exception
-------

I debugged the code and it crash as it calls mayThrow even if it is wrapped by a try-catch.
This is the real code:
        {
            // Stop should not fail!
            stop(); // Crash here when this mocked method is throwing an exception
            state = CommunicationState::Stop;
        }
        catch ( const std::exception& exc )
        {
            ...
        }
        catch ( ... )
        {
            ...
        }

I don't think this is related to doctest - you could try to separate this from the doctest stuff and try to reproduce it in a simple main() function. I also don't have experience with mocking frameworks - you could ask this in the issues section of Trompeloeil - and make sure to include the entire code and not separate snippets, so it's easier to understand.

@onqtam you have been very supportive and kind.
I've followed your hint and I tried to rewrite the test bypassing Trompeloeil (so implementing manually a mocked class) and it works as expected, so I guess that there is something that I'm missing in Trompeloeil.
Thank your patience and I'm sorry wasted your time.


Slug update when saving a draft

Repro:
Write a new post and save it as a draft. Edit the draft and change the title. Save it as a draft.
Actual: A JS alert message for updating the slug is displayed asking the user if they want to update the slug or not. This doesn't make sense when saving a draft because there should be no external links to break anyway, since no external links should refer to a draft, which isn't public.
Expected: No alert message. The slug is updated automatically based on the new title.
The same scenario happens when a draft is published. There shouldn't be a slug update alert in this case; either -- the slug should just be generated from the updated title.

Address after ViewModels refactoring (PR #93) is merged.

Fixed in PR #145

The blog owner is prompted with a slugUpdateWarning when publishing a blog post that was originally saved as a draft (not ever published before).
Will fix this by modifying the drafts model. A draft should not have a slug since no external links should refer to the draft anyway.

Fixed in PR #153


iSTFTNet and LibriTTS

I'm curious if you can share any observations about using iSTFTNet with LibriTTS. The paper implies that the performance of iSTFTNet was insufficient for LibriTTS and so HiFiGAN was adopted, but I was wondering if you did any experiments with iSTFTNet and LibriTTS and what you saw.

We did this in our most recent work on vocoder: https://github.com/yl4579/HiFTNet
Basically, we could achieve close-to-ground truth performance with HiFiGAN architecture on LibriTTS but not with iSTFTNet.

Awesome, thanks for the pointer! Any particular reason for the switch from the C8C8 architecture in the paper to the C10C6 setup in this repo?

Because this repo is 24 kHz while the original one is 22.5 kHz.


How to use taskcat deploy which is an alpha feature? There is no manual on how to use the other commands. What are the sub commands?

I replaced “test” command with “deploy” and I got the below warnings and error.
version 0.9.17
00:18:11  [WARN   ] : deploy is in alpha feature, use with caution
00:18:11  [WARN   ] : Region not set in credential chain, defaulting to us-east-1
00:18:11  [INFO   ] : fetching git repo https://github.com/aws-quickstart/quickstart-run.git
00:18:11  [ERROR  ] : GitProtocolError unexpected http resp 401 for https://github.com/aws-quickstart/quickstart-run.git/info/refs?service=git-upload-pack
[Pipeline] }
I am running the below command from the Jenkins Pipeline and got the above error.
taskcat deploy run -p ./RDS/ci

This was addressed out of band. Closing.


Plugin manager request

Description
Updating the paths for the plugin installation tool.
https://github.com/jenkinsci/plugin-installation-manager-tool
https://issues.jenkins-ci.org/browse/HOSTING-777
Submitter checklist for changing permissions
Always

[ x] Add link to plugin/component Git repository in description above

Just wondering, why put Jenkins into the names? For plugins at least, we generally don't want "Jenkins" in the name

@stopalopa ping on my previous question?

Earlier in the development process I merged in some changes suggested by @batmat (https://github.com/jenkinsci/plugin-installation-manager-tool/pull/2/commits/aa4ede47e463428e8751c582be5e2e70f09e7941), which included having Jenkins in the artifactId. Is this something I should change?

@batmat We generally don't want jenkins in the artifactId, but if you have a good reason, we can bypass that "rule"

No strong opinion here. IMHO it can be safely removed

My rationale was that, contrary to plugins, the Jenkins plugin-manager tooling was likely to be used quite outside of a Jenkins context.
Like we have dozens of core modules in Central that become a mess when dumped as is on the classpath.
Like jenkins-core in Jenkins: https://github.com/jenkinsci/jenkins/blob/master/core/pom.xml#L35 or jenkins-war https://github.com/jenkinsci/jenkins/blob/master/war/pom.xml#L34 (cli sounds like a mistake to me, though, but well).

What's the status on this one?

I'm going to close this out (not merge) unless someone says otherwise.


Release Google.Cloud.CloudBuild.V1 version 2.8.0

Changes in this release:
No API surface changes; just dependency updates.

Created release for Google.Cloud.CloudBuild.V1-2.8.0


Question: AngularJS Implicit Client, Silent Renew failing with invalid state when calling processTokenCallbackAsync

I want to know if someone experimented this issue configuring silent renew uri,
I am using an angularjs controller as a callback url, my oidc token manager object is craeted once the application is started into a singleton factory caled AuthService.
The processResponseAsync function is throwing  invalid state
Thanks

If you use the Angular Way to define and access the TokenManager object, you'll get in trouble very quickly. Try a global js variable for TokenManager, outside the angular scope. You'll have access to that variable as an instance of the TokenManager in all your controllers, services and factories.
Otherwise, if you define TokenManager with a factory or service, everytime you access it, angular will create a new instance of TokenManager and the amount of your silent renew counters increase by one for every access. Which means, you will soon have 2, 3, 5... TokenManager objects counting down for a token renewal. And with every call to the TokenManager, a new TokenManager object with different state and nonce values will be created, and when the time comes for a renewal, the values which were stored in the localstorage (or session storage) the first time, will be overriden by the second, third... The active TokenManager which timesout for the token renewal will always have different nonce and state values, thus you get these errors.


Add more tests which check CSR functionality

Thanks for the test suite. It's super helpful for developing simulators and RTL.
Maybe I missed something but I think the tests currently don't take into accout vxrm, frm, mstatus, sstatus, vsstatus and other CSRs.

I'm currently busy with other things, but I will add them.

I already added vxrm and vxsat support.

Thanks so much! :tada:

I think some vstart related tests would also be helpful.
So far my ISA simulator always set vstart to zero which should lead to issues I think
but there are no test cases covering it as far as I can tell.

Normally, vstart is written by hardware on a trap, which is not straightforward to fit into our test framework. vstart can also be written by csrrw[i], which is a usage scenario not recommended by the v-spec, I can at least add support for the latter case.

Note that implementations are not required to support non-zero vstart for instructions where they would never take a trap in the middle of execution.

Indeed. Then we have to make vstart support optional for arithmetic instructions if we add it to the test.
Page 14:

For example, some implementations will never take interrupts during execution of a vector arithmetic instruction, instead waiting until the instruction completes to take the interrupt. Such implementations are permitted to raise an illegal instruction exception when attempting to execute a vector arithmetic instruction when vstart is nonzero.

It is also possible that an implementation that does not support exceptions only supports vstart == 0.


Inject CsrfToken as a dependency

The token is already injected into the filter strategy.  The token storage and response filter are, therefore, using different tokens causing false negatives.

Using a factory instead will be easier on consumers of the library.  The factory method will require the token.


No default image for Win10  in KnownWindowsVirtualMachineImage

There is no constant for default Win10 image in KnownWindowsVirtualMachineImage
How do we create a VM from the Win10 Pro image in the marketplace:
new->marketplace->compute->Win10 Pro, Version 1709
PUBLISHER: Microsoft

@anuchandy Any pointers for this? How do we find the details like offer, sku, publisher and version to create an "ImageReference"?

ImageReference imageReference = new ImageReference();
imageReference.withPublisher("MicrosoftWindowsDesktop");
imageReference.withOffer("Windows-10");
imageReference.withSku("RS3-Pro");
imageReference.withVersion("latest");

This test shows how to enumerate images.

@anuchandy  Thanks!


Use the new field type.

Fixes https://github.com/jhu-idc/iDC-general/issues/387.

Depends on https://github.com/jhu-idc/idc_defaults/pull/5 for the CI to pass I think.

What needs to happen now is composer update jhu-idc/idc_defaults needs to be run to pull in the latest idc_defaults module hash.  Do you have time to do that Jordan?

Can do that sure.


Fixed indentation in diff code block and improved sentence structure

Q
A

Bug fix?
yes

New feature?
no

License
MIT

I've messed up the indentation of the diff code block in my previous PR https://github.com/symfony/ux/pull/627, thus its not rendered correctly on https://symfony.com/bundles/ux-live-component/current/index.html#installation. Also, the structure of the introduction sentence was a bit unwieldy, at least for my non-native-English-speaker ears, and is now hopefully improved.

Thank you Manuel!


Error while creating function from VS Code - Azure Function Extention

Repro steps:
Action: azureFunctions.createNewProject
Error type: Error
Error Message: Failed to run "py -3.6" command. Check output window for more details.
Version: 0.13.1
OS: win32

@EricJizbaMSFT it seems my environment is making issue, because same command (py -3.6 -m venv .env) is not working locally as well. so installed "virtualenv" module and created virtual env manually rather than going through mentioned command.  i am closing the issue.
Thanks !!


Add support of colors when exporting to URDF geometries with material element

We use the //visual/material/diffuse SDF element and convert it into the visual/material/color@rgba URDF attribute.
Note that other material properties of SDF are ignored. We cannot work around it since the material properties of URDF are more limited than those of SDF.
Additional information on SDF materials:

http://sdformat.org/tutorials?tut=spec_materials

Note that other material properties of SDF are ignored. We cannot work around it since the material properties of URDF are more limited than those of SDF.

Just for completeness: it is probably not worth it, but a way to fully support all SDF materials in URDF is to generate new meshes on the fly in Collada and/or obj format, encode the material information there, and use those material-aware meshes in URDF instead of the meshes used by SDF.

Note that other material properties of SDF are ignored. We cannot work around it since the material properties of URDF are more limited than those of SDF.

Just for completeness: it is probably not worth it, but a way to fully support all SDF materials in URDF is to generate new meshes on the fly in Collada and/or obj format, encode the material information there, and use those material-aware meshes in URDF instead of the meshes used by SDF.

I never saw this done elsewhere, interesting approach! It seems quite convoluted to do by hand, but doable in code and a good candidate in rod. If someone needs full color support, this could be a great workaround to the feature disparity between URDF and SDF.

I never saw this done elsewhere, interesting approach! It seems quite convoluted to do by hand, but doable in code and a good candidate in rod. If someone needs full color support, this could be a great workaround to the feature disparity between URDF and SDF.

Yes, due to technical difficulties in handing mesh files users and libraries tend to think of meshes as "black box" that can't be modified, while effectively they are part of robots description exactly as the URDF and SDF files.


generalizing the UI

Removed all ML logo and mentions from viewer.

LGTM

Why?
andy
Begin forwarded message:

From: Juliana Nazaré<EMAIL_ADDRESS>Subject: [digital-certificates/viewer] generalizing the UI (#15)
Date: May 26, 2016 at 3:58:34 PM EDT
To: digital-certificates/viewer<EMAIL_ADDRESS>Reply-To: digital-certificates/viewer<EMAIL_ADDRESS>Removed all ML logo and mentions from viewer.
You can view, comment on, or merge this pull request online at:
https://github.com/digital-certificates/viewer/pull/15 https://github.com/digital-certificates/viewer/pull/15
Commit Summary
generalizing the UI
File Changes
M conf_template.ini https://github.com/digital-certificates/viewer/pull/15/files#diff-0 (2)
M viewer/formatters.py https://github.com/digital-certificates/viewer/pull/15/files#diff-1 (4)
M viewer/forms.py https://github.com/digital-certificates/viewer/pull/15/files#diff-2 (2)
A viewer/static/img/logo.png https://github.com/digital-certificates/viewer/pull/15/files#diff-3 (0)
D viewer/static/img/mllogo.png https://github.com/digital-certificates/viewer/pull/15/files#diff-4 (0)
M viewer/templates/award.html https://github.com/digital-certificates/viewer/pull/15/files#diff-5 (14)
M viewer/templates/bitcoinkeys.html https://github.com/digital-certificates/viewer/pull/15/files#diff-6 (9)
M viewer/templates/faq.html https://github.com/digital-certificates/viewer/pull/15/files#diff-7 (16)
M viewer/templates/index.html https://github.com/digital-certificates/viewer/pull/15/files#diff-8 (15)
M viewer/templates/layout.html https://github.com/digital-certificates/viewer/pull/15/files#diff-9 (18)
M viewer/templates/request.html https://github.com/digital-certificates/viewer/pull/15/files#diff-10 (13)
M viewer/templates/user.html https://github.com/digital-certificates/viewer/pull/15/files#diff-11 (4)
Patch Links:
https://github.com/digital-certificates/viewer/pull/15.patch https://github.com/digital-certificates/viewer/pull/15.patch
https://github.com/digital-certificates/viewer/pull/15.diff https://github.com/digital-certificates/viewer/pull/15.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/digital-certificates/viewer/pull/15

To provide a more universal set of tools that others can use to deploy their own digital certificate systems.   Rather than everyone forking the ML viewer, we created a general viewer that's easier to customize.


Better error scheme for gateway ui faililng to connect to the gateway

currently just always gives invalid password

I attempted to replicate the error in different scenarios, but I was unable to get the same result.
Here are the details of the tests I performed:
Invalid password with gateways active
Result: Error fetching gateway info with Status: 401 Unauthorized.

Correct password with gateways active
Result: Error fetching balance with Status: 404 Not Found.

Invalid password with gateways inactive
Result: Error fetching gateway info with Status: 401 Unauthorized.

Correct password with gateways inactive
Result: Error fetching balance with Status: 404 Not Found.

If you could provide more details about the environment in which the error occurred or additional specific steps, it would help me investigate further and better understand the issue.

that 3rd picture is the issue: if you put the correct password in when the gateway is down it doesn't give you a failed to connect error, it gives you a 401 unauthorized

Hi Kody, after testing, I see that the system is actually working as expected:

When gateway is down and using incorrect password:

Returns 401 Unauthorized (correctly indicating invalid credentials)
UI shows "Invalid password"

When gateway is down and using correct password :

Returns 404/405 errors (correctly indicating connectivity issues)
UI shows connectivity errors
Maintains credentials in session

The authentication flow properly differentiates between:

Authentication failures (401)
Connectivity issues (404/405)

(getting 401 with correct password when gateway is down) isn't occurring in my tests. Please, could you provide more details?


[e2e tests]: fix flaky migration test 1862

Signed-off-by: Igor Bezukh<EMAIL_ADDRESS>What this PR does / why we need it:
There was no special need to use Alpine test tooling image
in the current test. Moreover, the test tooling image requries
some cloud-init configuration in the VMI spec.
In this particular case I am not using libvmi because we
don't have yet builder functions for the DV PVC configuration.
The fix is just return the Alpine image to the simple one, not the tooling.
Fixes #
https://storage.googleapis.com/kubevirt-prow/reports/flakefinder/kubevirt/kubevirt/flakefinder-2022-08-28-168h.html#row22\
Special notes for your reviewer:
In this case I've decided not to refactor the test to use libvmi because we don't have
enough VM builders for storage configurtaion, and adding them in this PR will cause a drift
in the scope.
Release note:
NONE

/cc @dhiller

/retest


Blur issue happened on the flatten region

Hi author, thanks for your great work. I try to reproduce the training flow as the paper. However I face a problem on my retrained model. Even if the sharpen and detail region on inference results looks make sense, the flatten or low frequency region is blurred. The state of blur is more serious than the input low quality patterns. Is the root cause of this problem due to the normalized l1 (or l2 loss), should add some gradient normalizing methods on the Lora training or others? Sorry, I try lots of methods but still not work. Hope you can provide some help, thank you.

Hi author, thanks for your great work. I try to reproduce the training flow as the paper. However I face a problem on my retrained model. Even if the sharpen and detail region on inference results looks make sense, the flatten or low frequency region is blurred. The state of blur is more serious than the input low quality patterns. Is the root cause of this problem due to the normalized l1 (or l2 loss), should add some gradient normalizing methods on the Lora training or others? Sorry, I try lots of methods but still not work. Hope you can provide some help, thank you.

Hello, is the blur problem solved after removing L2 loss? I also encountered a similar problem.


[Internal] Add Cache Refresh and Accelerating Networking information in telemetry payload.

It is an extension of #2385.
As part of telemetry, below information has to be collected:

Cache Refresh Information has to be collected
Accelerating Networking (enabled/disabled)

For Cache Collection, there is separate issue has been created i.e https://github.com/Azure/azure-cosmos-dotnet-v3/issues/2895

Separate Issue has been created for accelerating network flag i.e. https://github.com/Azure/azure-cosmos-dotnet-v3/issues/3082
hence closing this to avoid duplicity


RFC: new FaceDancer 3.0 feature -- declarative syntax for defining devices

All:
I've been working on a new major version of FaceDancer for the past few days in an effort to clean up a lot of the things that have been bothering me. It's not yet a complete rewrite (but it will be, soon!). There are going to be a bunch of new features -- in addition to a compatibility layer that should keep old code working.
I'm particularly interested in the community's thoughts regarding a new/alternate "declarative" syntax for defining USB devices. The intent of the alternate syntax is to:

Dramatically speed up the process of creating new emulated device definitions.
Allow device definitions to naturally follow the way USB classes are conceptually structured.
Take full advantage of the new Python data-classes to remove a lot of the boilerplate.

An ultra-simple example (a device that only handles one vendor request) might look like:
@use_inner_classes_automatically
class VendorOnlyDevice(USBDevice):

    name           : str = "Proprietary Company"
    product_string : str = "Very vendor device"

    vendor_id      : int = 0x3456
    product_id     : int = 0x1234

    @vendor_request_handler(number=3)
    def handle_silly_request(self, request):

        # NOTE: these are the old names; this will be cleaned up
        self.send_control_message(b"1234")
        self.ack_status_stage()

You can see a more complex example, here:
https://github.com/usb-tools/Facedancer/blob/future/facedancer/devices/keyboard.py
I welcome everyone's thoughts!

Declarative device definition is now a standard feature as of Facedancer 3.0.0


An error occurs when loading Google Sheets data.

There are 1500 lines of data in the Google Sheets. Previously, there was no problem loading the data, but suddenly errors started to occur. Please let me know what the cause might be.

The error occurs when there is a newline character in the column.
When I have some spare time, I will create an example of the column causing the error and send it to you by email. Thank you for always being helpful.

I also reproduced this, Keeping the fields as single line was enough. However this may be an issue for simple projects without localization, where the dev may want to use fields for custom texts or descriptions


Add support for sveltekit:prefetch on Navigation link

Hi,
I'm using sveltestrap with svelte kit and wanted to add support for prefetch on navigation links.
Is support for svelte kit in the roadmap of this project?
If this is something other people find useful I can make a PR.

Hi @dngferreira ,
Thanks, yes we've been trying to keep up with the latest in Sveltekit.
Support sounds good, though what would need updating?
PR sounds great assuming we don't have to directly import Sveltekit code into the lib.


update to LLVM 7, also update some random components of our Docker

setup, this is for CI and should not affect any non-souper-developers
this contains an old LLVM patch for de-fanging InstCombine, Zhengyang
will patch it up soon

merging as obvious


refactor potions and leather armor

note: this PR contains #520 so you should probably merge that one first
this PR performs some refactors to leather armor textures then it migrates potions from static images to a system like leather armor
before:

after:

1.16:

1.8:

thanks @dukio

This PR has a vulnerability I need to fix can someone with write access convert it to a draft for me

Fixed the potential vulnerability ready for review again
also added a Note for server maintainer to the original comment


Getting undefined when using promises

Hi Guys, I am getting undefined when trying to use promises.
everything works well without promises, but when I change it to promises I am getting undefined from import.
Here is a sample code, any ideias?
var gpiop = require('rpi-gpio').promise;

gpiop.setup(38, gpiop.DIR_OUT)
    .then(() => {
        return gpiop.write(38, true)
    })
    .catch((err) => {
        console.log('Error: ', err.toString())
    })

The error is:
gpiop.setup(38, gpiop.DIR_OUT)
      ^

TypeError: Cannot read property 'setup' of undefined
    at Object.<anonymous> (/home/pi/Projects/RaspberryPiRelayControl/index.js:10:7)

That's really odd. Could you run these commands and give us the output, just to help sanity check?
node -v
npm ls

Maybe you could try running this as well to see what object is being imported, and why it seems to lack the promise interface:
var gpio = require('rpi-gpio');
console.log(gpio);


⚠ Bofrost.nl has degraded performance

In 87e70df, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1008 ms

Resolved: Bofrost.nl performance has improved in 054f681.


Excludes mocks from requiring their own unit tests

We're seeing a Danger failure in this PR because I added a new mock, and Danger is insisting we write a unit test for that mock: https://github.com/artsy/emission/pull/2027
It's expecting that src/lib/Scenes/Settings/__mocks__/LoggedInUserInfo.tsx has a corresponding src/lib/Scenes/Settings/__mocks__/__tests__/LoggedInUserInfo-tests.tsx test file. This update excludes mocks from the Danger rule.
EDIT: Forgot to say that I tested this change locally using DANGER_GITHUB_API_TOKEN=MY_PERSONAL_ACCESS_TOKEN yarn danger pr https://github.com/artsy/emission/pull/2027 and it works 👍

:rocket: PR was released in v1.21.2 :rocket:


Updates needed before 2024.2.0

https://developers.home-assistant.io/blog/2023-057-21-change-naming-mqtt-entities

link is wrong, correct one: https://developers.home-assistant.io/blog/2023/07/21/change-naming-mqtt-entities?_highlight=mqtt

lol looks like I was right at the time: https://web.archive.org/web/20230729005010/https://developers.home-assistant.io/blog/2023-057-21-change-naming-mqtt-entities/
But yes, that is indeed the correct link. Thanks!


identity request returned error

Hi, we wrote an extension on iOS 18 beta3 and ran this demo locally, they worked well, except for a few issues :
We got this error (printed in console) when a phone call come and the system trying to block / identity the call number :
identity request returned error: Error Domain=com.apple.CipherML Code=400 "Error Domain=com.apple.CipherML Code=401 "Unable to request data by keywords batch: missing configuration" UserInfo={NSLocalizedDescription=Unable to request data by keywords batch: missing configuration, NSUnderlyingError=0x65e235e60 {Error Domain=CipherML.CipherMLError Code=25 "missing configuration" UserInfo={NSLocalizedDescription=missing configuration}}}: missing configuration" UserInfo={NSLocalizedDescription=Error Domain=com.apple.CipherML Code=401 "Unable to request data by keywords batch: missing configuration" UserInfo={NSLocalizedDescription=Unable to request data by keywords batch: missing configuration, NSUnderlyingError=0x65e235e60 {Error Domain=CipherML.CipherMLError Code=25 "missing configuration" UserInfo={NSLocalizedDescription=missing configuration}}}: missing configuration, NSUnderlyingError=0x65e235e60 {Error Domain=CipherML.CipherMLError Code=25 "missing configuration" UserInfo={NSLocalizedDescription=missing configuration}}}

Is there any solution to this problem ?

It sounds like the system is trying to fetch configuration for a "usecase" that your server instance is not hosting, which results in the error you got: the system does not have configuration for the "usecase".
In Running the service it is said that:

The name will be used by the device to identify the dataset. In this example, we assume that the bundle identifier of the on-device Live Caller ID Lookup Extension is net.example.lookup. Then the system will try to fetch the blocking information from net.example.lookup.block and the identity information from net.example.lookup.identity.

Make sure you modify the usecase names in service-config.json file based on your extension name.

That's the problem. Now it works after fixing the bundle identifier, thanks for your help ^^


updated deprecation process doc

Updating the deprecation process doc in a new file.
TODO:

[x] In a separate PR, update krista's doc on running the script if needed.
[x] Check that documentation update step is descriptive enough
[x] point deprecation aka.ms link to new doc
[x] Follow up with Jim on updating the overview/conceptual docs in docs.microsoft.com.
[x] Ask about: "Post a blog on the Azure Blog, essentially stating that a new package is available which replaces the old package, the old package is scheduled to be deprecated on a specific date, and guidance on adjusting code to use the new package." --> Consider doing this and reaching out to a PM if unsure. (ask Rohit)
[x] Ask about general guidance of: ~Add 3 year end-of-support warning, and align the deprecation of the SDK with the service retirement.~ --> EOLDate : if new package, date of release. O/w service retirement.

~Based on the retirement policy, I think it makes sense to deprecate the package with the service retirement and add the warning to the readme before then. If the service is deprecated, we should mention that only security fixes will go in and nothing else.~ --> not needed.

Tagging @scbedd for review of the Remove the entry in the github.io docs section, where it says to contact him directly.

/check-enforcer override


Helpers may not be used in the element form

I replaced this:
<button {{action "toDay"}}> Today </button>
… with this:
<button {{route-action "toDay"}}> Today </button>
... and got this error:
ember.debug.js:19695 Uncaught Error: Assertion Failed: Helpers may not be used in the element form, for example <div {{my-helper}}>.

@fknoll The correct form is
<button {{action (route-action "toDay")}}> Today </button>

@martndemus  Thanks! I just reviewed documentation, and realize I must have missed the text about the correct form. I apologize.


Implement and figure out unit tests

Unit testing would help us catch smaller bugs that have plagued the bot, especially with the point/rank handling systems we have.

Won't be considered as we're most likely rewriting the bot


Call Breeze Controller with Windows authentication

I need call ASP.NET Web API Breeze controller which use Windows authentication from Angular 5 / Breeze app.
I tried some modification for ajaxAdapter

Option

	import { config } from 'breeze-client';

        let ajaxAdapter = <any>config.getAdapterInstance('ajax');

        ajaxAdapter.defaultSettings = {
            headers: {
                'Content-Type': 'application/x-www-form-urlencoded'
            },
            withCredentials: true
        };

Option

	import { config } from 'breeze-client';

        let ajaxAdapter = <any>config.getAdapterInstance('ajax');

        ajaxAdapter.defaultSettings = {
            headers: {
                'Content-Type': 'application/x-www-form-urlencoded'
            },
            xhrFields: {
                withCredentials: true
            }
        };

Not work.
Request header doesn’t contains Authorization: NTLM ...
When I call Web API controller (no Breeze) which also require Windows authentication with Angular HttpClient it works.
    const headers = new HttpHeaders({
        'Content-Type': 'application/x-www-form-urlencoded'
    });

    this._httpClient.get(url, { headers, withCredentials: true }));

Request header contains Authorization: NTLM ...
Web Client:
"@angular/core": "^5.0.0",
"typescript": "~2.4.2"
"breeze-bridge-angular": "^4.0.2",
"breeze-client": "^1.6.3",

Any Idea?
Solution:
Use https://github.com/Breeze/breeze.bridge2.angular + angular HttpInterceptor

The new Angular HttpClient service allows for interceptors to mutate an outgoing request. This is where you would mutate the request to add things like authentication etc.
Here'a an article that might help.
https://alligator.io/angular/httpclient-interceptors/