Just initialize auto backend once

What was wrong?
Issue #35
How was it fixed?
Autobackend was initialized every time it was called. Just init it once when object is created.
Previous results
eth_hash 10.747742728999583
web3 14.371859122999012
cryptodome 7.886241019998124
pysha3 0.6233324849999917

When setting ETH_HASH_BACKEND="pysha3":
eth_hash 6.742922992998501
web3 10.079077139998844

Results after PR
eth_hash 4.656213931999446
cryptodome 7.79646546100048
pysha3 0.6171151390008163

When setting ETH_HASH_BACKEND="pysha3"
eth_hash 0.8036113110010774
cryptodome 7.874447432999659
pysha3 0.6161410700005945

[x] Clean up commit history

[ ] Add entry to the release notes

Cute Animal Picture

I'm aware that some tests need to be adjusted, but I just wanted to know this is the way to go

In typical usage, where you're reusing the same hasher instance

The problem is that this is used broadly in web3.py (for example, in the formatter when converting all the addresses to the EIP55 version), and hasher is not reused.

Like if you ran a hash once in the benchmark setup, I expect that the PR wouldn't cause any meaningful change.

Oh nope, this guess was wrong!
from eth_hash.auto import keccak

def monkey_patch(backend):
    old_init = keccak._backend._initialize

    def new_init():
        print("Initializing again...")
        old_init()

    backend._initialize = new_init

if __name__ == '__main__':
    monkey_patch(keccak._backend)
    print("Run 1:")
    print(keccak(b''))
    print("Run 2:")
    print(keccak(b''))

You'll see:
Run 1:
Initializing again...
Initializing again...
b"\xc5\xd2F\x01\x86\xf7#<\x92~}\xb2\xdc\xc7\x03\xc0\xe5\x00\xb6S\xca\x82';{\xfa\xd8\x04]\x85\xa4p"
Run 2:
Initializing again...
b"\xc5\xd2F\x01\x86\xf7#<\x92~}\xb2\xdc\xc7\x03\xc0\xe5\x00\xb6S\xca\x82';{\xfa\xd8\x04]\x85\xa4p"

So what happens is that this "optimization" of saving the hasher directly to Keccak256.hasher saves the unoptimized version of AutoBackend, which keeps getting called over and over:
https://github.com/ethereum/eth-hash/blob/fc3b9dda5f1ce5f908c7c0cbbbc63adb4e030da9/eth_hash/main.py#L25-L27

In order to avoid initializing the backend at import time, we could make this change:
diff --git a/eth_hash/main.py b/eth_hash/main.py
index f814449..1503e3b 100644
--- a/eth_hash/main.py
+++ b/eth_hash/main.py
@@ -22,15 +22,18 @@ class Keccak256:
         This is a bit of a hacky way to minimize overhead on hash calls after
         this first one.
         """
+        # Execute directly before saving method, to let any side-effects settle (see AutoBackend)
+        result = self._backend.keccak256(in_data)
         new_hasher = self._backend.keccak256
         assert new_hasher(b'') == b"\xc5\xd2F\x01\x86\xf7#<\x92~}\xb2\xdc\xc7\x03\xc0\xe5\x00\xb6S\xca\x82';\x7b\xfa\xd8\x04]\x85\xa4p"  # noqa: E501
         self.hasher = new_hasher
-        return new_hasher(in_data)
+        return result

     def _preimage_first_run(self, in_data: Union[bytearray, bytes]) -> PreImageAPI:
-        new_preimage = self._backend.preimage
-        self.preimage = new_preimage
-        return new_preimage(in_data)
+        # Execute directly before saving method, to let any side-effects settle (see AutoBackend)
+        result = self._backend.preimage(in_data)
+        self.preimage = self._backend.preimage
+        return result

     def __call__(self, preimage: Union[bytearray, bytes]) -> bytes:
         if not isinstance(preimage, (bytearray, bytes)):

Which causes the earlier mokeypatch test to print out the desired:
Run 1:
Initializing again...
b"\xc5\xd2F\x01\x86\xf7#<\x92~}\xb2\xdc\xc7\x03\xc0\xe5\x00\xb6S\xca\x82';{\xfa\xd8\x04]\x85\xa4p"
Run 2:
b"\xc5\xd2F\x01\x86\xf7#<\x92~}\xb2\xdc\xc7\x03\xc0\xe5\x00\xb6S\xca\x82';{\xfa\xd8\x04]\x85\xa4p"```

Hi! You mean making the change besides the changes I proposed?

Hi! You mean making that change besides the changes I proposed?

No, I meant to replace your proposal with my suggested changes.
The issue with your proposal is that initialization happens at import time. It would be great to minimize import time.

Sure, done!

Argh, I'm having trouble getting Circle working. I reset some settings, and was hoping the new commit would trigger it. But no luck. Hopefully it works on master!

Do you think we could do a release so eth-utils and web3.py can use the optimization?

Yep, thanks for the tag. I wasn't watching this repo! Yep, can do!

@Uxio0 I just released v0.3.3! The dependency ranges are such that you should be able to use it in both eth-utils and either web3.py v5 or web3.py v6 without problems, but let me know if you run into anything. Thanks again for the contribution!


Improving tracing typing

Trying to see if I can push it to remove all Any.
So far I get mypy happy, and pyright:
          Parameter 1: type "*tuple[P.args, ...]" cannot be assigned to type "*tuple[P.args, ...]"
            "builtins.tuple" is incompatible with "builtins.tuple"
          Parameter 4: type "P.kwargs" cannot be assigned to type "P.kwargs"
            Type "P.kwargs" cannot be assigned to type "P.kwargs" (reportGeneralTypeIssues)

which feels pyright bug (needs to reproduce in a smaller example).
Need to write some script with invalid typing on purpose to see if actually mypy is working, or just not complaining.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-core

Discussed has invalid syntax in https://github.com/microsoft/pyright/issues/5844 and https://github.com/python/mypy/issues/14832


Add cycle nodes list to Dependency Cycle Found Error.

Currently there is the list of nodes in an error message for the Dependency Cycle error.
It would be great if this could be added as a cycleNodes property to the error itself.

Great idea - looks related to #23.


./test1: symbol lookup error: ./test1: undefined symbol: cblas_sbgemm

I build openblas whith "make BUILD_BFLOAT16=1". Why I got an error when I ran my program?
./test1: symbol lookup error: ./test1: undefined symbol: cblas_sbgemm

What is your CPU type?
Does it build without parameter?
Full build log (after make clean )?

I have solved the problem. Openblas has no problem.


Bug paragraph inside div

Bug Report
I get an error when I put a paragraph inside div with the format HTML
MDX:
---
name: Tipografias
route: /tipografias
menu: Estilos
---

# Title
Lorem Ipsum

## Fonts

H1 Display

H2 Display

H3 Display

Parágrafo normal

The error:
SyntaxError: unknown: Expected corresponding JSX closing tag for
 (15:0)
Environment

OS: OSX 10.14.5
Node/npm version: v11.3.0/6.8.0

Additional context/Screenshots

I encountered the same problem. If I change the @mdx-js/react package to version 1.0.21 the  tag inside a  will work. Will test if everything is ok with the version upgrade and will make a pull request for it.

I have encountered the same problem. I changed the version of @mdx-js/react to a newer version and this seems to solve the problem. Will make a pull request for this change.


Valset update

🚧 WIP
Collect all changes to the active validator set and report them to the virtual staking contract async
This is an early version to explore integration points and define contract messages

I give up on starship tests. I can not run them locally and it takes forever to wait for CI. 🤷


Commercial houdini license downgrade to indie once egRedTools installed... no warning

Hi,
i've lost my mind for 3 days on this. After installing this suite of open gl and redshift tools, my license was always downgraded to indie.
houdini does not tell you anything about this or why.... i've found out that agRedshiftTools, once installed, makes houdini open as Indie license.
I don't know if you can fix it or not, but at least a warning, could be usefull!

Hey,
thanks for reaching out. I am no longer maintaining this toolset actively, but I added another line in the readme. With the only hdaLC assets provided your scenes always will be downgraded to Indie.


The relevant part of the node path is displayed next to the tab's name when only one tab is open for a blob container or table

Storage Explorer Version: 1.36.0-dev (101)
Build Number: 20240926.1
Branch: main
Platform/OS: Windows11
Architecture: arm64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Open one blob container.
Check whether no relevant part of the node path is displayed next to the tab's name.

Expected Experience
No relevant part of the node path is displayed next to the tab's name.

Actual Experience
The relevant part of the node path is displayed next to the tab's name.

Additional Context

For now, we only occurred this issue against blob containers and tables on Windows ARM64 and it is unstable.
This issue can't be reproduced consistently.
Here is the record:

Here is the log:
2024-09-27_055658 (2).zip
2024-09-27_055658.zip

@v-xianya Can you verify whether this only reproduces on Windows ARM64? Or does this also reproduce in Windows x64 or other platforms?

Unfortunately, the logs you attached don't contain much useful information. I'm going to add some extra verbose logging to help us narrow down the problem. If you can repro, please share any relevant verbose output from the renderer process (or just share the renderer process logs).

Got it, will share the logs once we reproduce this issue.

We reproduced this issue on Linux(.tar) using build 20241008.1. Unfortunately, we didn't set the log to verbose when this issue occurred😓

Hi @craxal @richardMSFT  Today we met this issue on 3 platforms MacOS ARM, Windows ARM, Linux.
These are the most likely steps to reproduce this issue. I hope this helps.
Steps:

Ensure there are two blob containers with the same name but from different storage accounts.
Expand one storage account and temporarily open the blob container.
Expand the other storage account and temporarily open the blob container with the same name.

Here is the render log on Windows ARM.
2024-10-09_074651_renderer_6888.log
Below is the record:

@richardMSFT Verified this issue on the rel build 20241011.2. It doesn't reproduce. However, I noticed that the relevant part of the node path briefly flashes after opening a secondary temporary tab. I'm not sure if this requires further attention. Here is the record.

The flash comes from the time between adding the new temporary tab to the collection of tabs (which causes path differentiations to be recalculated) and removing the old temporary tab. We can address this in 1.37.0.

Initial problem is resolved, but we won't worry about the "flash".


thin_film_bsdf separately fails compile due to undefined variables

An edge case when trying to create shader code with just this node:
<?xml version="1.0"?>
<materialx version="1.38">
  <thin_film_bsdf name="thin_film_bsdf" type="BSDF">
    <input name="thickness" type="float" value="550" unittype="distance" unit="nanometer" />
    <input name="ior" type="float" value="1.5" />
    <output name="out" type="BSDF" />
  </thin_film_bsdf>
  <surface name="shader_thin_film_bsdf_out" type="surfaceshader">
    <input name="bsdf" type="BSDF" nodename="thin_film_bsdf" />
  </surface>
  <surfacematerial name="material_thin_film_bsdf_out" type="material">
    <input name="surfaceshader" type="surfaceshader" nodename="shader_thin_film_bsdf_out" />
  </surfacematerial>
</materialx>

Gives this GLSL error when accessing thin_film_bsdf_out.response.
Error also occurs for OSL so assume it's a generic code gen issue.
0(923) : error C1503: undefined variable "thin_film_bsdf_out"
0(932) : error C1503: undefined variable "thin_film_bsdf_out"
``
[thin_film_bsdf_ps.glsl.txt](https://github.com/AcademySoftwareFoundation/MaterialX/files/10428633/thin_film_bsdf_ps.glsl.txt)

This issue has been addressed in #1413 for the in-progress v1.39 of MaterialX, so let's go ahead and mark this as resolved.


hhmi: update image tags

Updating hhmi-spyglass-image tag based on request from LorenFrank lab via Slack.

Image tag change only. Self-merging.


[Regulator] Add Regulator Service

What does this implement/fix? Explain your changes.

[x] Add REGULATOR_PRIVATE_KEY as parameter for the container to configure a private key for the Regulator Service.
[x] Add endpoint registerPairSenderReceiver to receive client calls with { PKa, PKb, PKx, pkx * PKb } parameters and result of scalar mult { pkr * PKb }. This registration will store parameters in some collection transfer_secrets.
[x] Update the client service to be able to decrypt commitments for the regulator using the previous information and the commitments from transactions. Use another commitment collection commitments_regulator in the database for the regulator commitments.
[ ] Add the corresponding tests

Does this close any currently open issues?
What commands can I run to test the change?
Any other comments?

Moved to private repo


Provide type hints and add static type checking

Add type hints to as code documentation, IDE hints and possibly catching errors. Add flake8-annotations to pre-commit and enable mypy in CI.

Cool project that could kickstart this issue:
https://zenodo.org/record/5151994
https://pypi.org/project/typing-copilot/

Used https://github.com/JelleZijlstra/autotyping in https://github.com/ing-bank/popmon/pull/262


Source view does not distinguish between empty files and selecting a directory

@Nemo157 I blame you.
https://docs.rs/crate/stylish/0.0.0/source/src/lib.rs

@jyn514
could you provide more info here? Or can this be closed?

@syphar if you click on the file, there's no feedback to tell you that it's empty; the page looks exactly the same before and after.
Not a giant deal, I don't mind closing the issue, but it seems nice to indicate that you've selected the file somehow, so you can tell it really is empty and there's not a docs.rs bug.


chore: remove Fintype.card_fin_even

This instance was meant to apply to even literal numbers. Because Lean 4 no longer uses bit0/bit1 for literals, it no longer serves that purpose. Instead, a specific instance for Fin 2 is added.

Thanks! :tada:
bors merge


Update README.md

Adds $ to code blocks that represent commandline operations, but be consistent with style in other CFPB repos.
Mention Mac OSX with homebrew in installation instructions.

@ascott1 Ready for review n merge. Thx!

Also adds bold intro text to troubleshooting item, so if other troubleshooting items are added they can be differentiated.

Looks good!


Ubuntu problem (Linux)

I think there is a problem with the JVM in linux. When I make a to any method of the API (TLRequestHelpGetConfig for example) I always get a timeOutException. But when I Try it on windows or mac, I get te correct answer. Does anyone know if there is any differences between de JVM??

It started working for me after I updated Server IP Address in the MemoryStateAPI class, as shown below -
 public void start(boolean isTest) {
        connections = new HashMap<>();
        connections.put(1, new ConnectionInfo[]{
                new ConnectionInfo(1, 0, isTest ? "<IP_ADDRESS>" : "<IP_ADDRESS>", 443)
        });
    }

Can you please send me compiled working code to my email<EMAIL_ADDRESS>I shall be grateful to you

Hi all,
have you finally found a solution to this problem?
could you be so kind to share a complete working code ?
Many thanks in advance for the support.

Hi, I am facing this same issue when sending the auth.checkPhone request. However while sending the auth.sendCode request I was able to solve this problem by adding the java parameters as Floens mentioned. Anybody knows what's happening?
I am using CentOs 6.5 with eclipse luna and java 8

@vaibhavthapliyal

It's because java by default uses /dev/random which blocks.

Hi,
Thanks for the reply. But as I mentioned, I have already applied the runtime parameters that you have suggested and because of that the auth.sendCode was successfully made. But this new request auth.checkphone seems to fail with a TimedOutException.
Thanks
Vaibhav

Ah. Well try to see with the debugger where the thread hangs (pause the jvm). This library is very old so you might want to look for another telegram solution.

It seems that this is the only JAVA API library for working with the telegram API. I have recompiled this to work with Layer 18 API and was able to run the sendCode request. Were you able to get this done when you were working on it? Is there any other library that you found helpful?

This answer explains the issue if it is not related to /random
http://stackoverflow.com/a/33941544/234125

Thanks for the link. I'm not sure what happened but the error disappeared by itself. Everything is working now.

I am continuing to have issues with this library. The author has moved on, so it is understandable.
But I stumbled across this library which is recently released: https://github.com/badoualy/kotlogram


community: add router chain based on the classify API from Jina AI

Thank you for contributing to LangChain!
add router chain based on the classify API from Jina AI

[X] PR title: "package: description"

Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..."  for template changes, "infra: ..." for CI changes.
Example: "community: add foobar LLM"

[X] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change
Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!

[X] Add tests and docs: If you're adding a new integration, please include

a test for the integration, preferably unit tests that do not rely on network access,
an example notebook showing its use. It lives in docs/docs/integrations directory.

[X] Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

Make sure optional dependencies are imported within a function.
Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
Most PRs should not touch more than one package.
Changes should be backwards compatible.
If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@baskaryan The PR is ready for review. I am not sure whether the documentation is at the right place

@efriis Any comment?

Hey there! This PR is currently in "Needs support" per our review process: https://python.langchain.com/docs/contributing/reference/review_process/
It currently doesn't have enough upvotes to prioritize a review.

@efriis hey, Erick. I think this PR has collected enough upvotes for moving forward.

hey there! sorry for even putting this in needs support could have closed this earlier. we're not merging in new routerchains at this time. instead would recommend building some demo use cases using the classify api in a langgraph agent, so the community can use this classify api in conditional edges!


Integrate this as a submodule

Any reason why this is a remote module and not a submodule ?

This is not ready to be a submodule yet.

Agreed.
On Tue, Aug 14, 2018, 2:28 AM mwestphal<EMAIL_ADDRESS>wrote:

This is not ready to be a submodule yet.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/issues/230#issuecomment-412811540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDHFP794gPETsBZpTOV9HWoUquMWxks5uQpgggaJpZM4V8Eh8
.


Subscribe to user updates

Using the Socket.io adapter, it would be great to automatically subscribe to the user model's changes to reflect those change for app.get('user').
// Assuming events are filtered appropriately
app.service('users').on('patched', function(user) {
  app.set('user', user);
});

@beevelop I haven't tried this but is it not already possible? Are you thinking server side or client side or both? With feathers-rx this is made a lot easier.
I guess what I'm looking for is:

Can you not do this?
What is the use case?

:beers:

I was briefly looking into this. I think it is a good idea but the client side authentication currently does not know about the user endpoint so it can't hook into the service events.

@daffl Can it not assume it's /users or can we get people to provide an endpoint?

@ekryski This feature would be client-side only and is definitely possible. I use this implementation already, but I think it might be more intuitive to get the latest (patched) user data when calling app.get('user') by default or by specifying this behavior explicitly when registering feathers-authentication in the frontend.
@daffl: Wouldn't a configuration option to specify the user endpoint not meet this problem? You could simply default to /users.

I agree. The one thing we'll have to consider is potentially passing a user service, not just an endpoint so that you can potentially be getting user updates from a completely separate backend service, not necessarily the same one as you are authenticating with.

This is going to be left up to the developer because we can't assume that every app will have a user. Therefore:

we don't want to add more configuration options to enable such functionality on the client at this point.
and we don't want to be registering socket listeners unnecessarily.


Picture Repository

Can't get query to work. Trying to pull all pictures sorted chronologically, but it causes errors.
Line 19 of PictureRepository.java

fixed


Does Windows Terminal support CUDA?

Since WSL does not support CUDA, I really expect this feature.

I'm also concerned with it.

this has nothing to do with the terminal app this repo is about. The terminal is "only" rendering text it gets from ConPTY and so on.
what you are asking is related to wsl2 for which there is no repo up yet.


file:memory does not appear to work

Dear maintainer,
I use the sqlitex.Pool for simulating in-memory testing connections, but it does not appear to work when using file:memory?mode=memory with multiple connections as described below:
func NewPool(uri string, opts PoolOptions) (pool *Pool, err error) {
	if uri == ":memory:" {
		return nil, strerror{msg: `sqlite: ":memory:" does not work with multiple connections, use "file::memory:?mode=memory"`}
	}
       // ...
}

[ ] Created tables are unique per connection instead of being shared in the Pool. Using PrepareConn option just creates individual tables in fragmented memory space - the data is not shared between connections.
[ ] There is a small typo there with double :: between file and memory.

I care about this, because my authorization code occasionally may make a database call, which will block the Pool, making this impossible to test. I can work around this by writing my own wrapper around the Pool and returning the same connection when in `file:memory:" mode, but I want to know if I am doing something wrong here, or may be there is a better way. Thank you!

You will also need to pass in OpenSharedCache (not on by default) in order for a pool of in-memory connections to work as you expect.

edit: I believe adding &cache=shared will also work. If that's the case, the error message should probably be amended to include that to avoid future confusion.

This worked perfectly! You are amazing!

I will gladly submit a documentation PR - would you like me to? I write ok docs.

Sure, sounds good. 👍


Track pointer initialization for zero values

This fixes a bug where a pointer was initialized, but to the zero value. Like a *bool initialized to &false. Previously this would be considered "unset" because false is the zero value for a boolean. Now envconfig considers whether the pointer was initialized first, before checking whether the value is zero.

Fixes https://github.com/sethvargo/go-envconfig/issues/71
/cc @capri-xiyue


Move s390x-unknown-linux-musl to build.sh

Fixes #2085
r? @ghost

@bors try

:hourglass: Trying commit 9a29ee3bfe75ff3b31b10baff01ed29a2ba2ccfc with merge 0ad3ed28c69b1ed48ff23b10ec757ac8dcac101d...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 9fca60945aad6bec70e85dea30470fecc90a0ff5 has been approved by JohnTitor

:hourglass: Testing commit 9fca60945aad6bec70e85dea30470fecc90a0ff5 with merge 449b00bccdea9274c3420d9582fb787ec21b0b47...

:broken_heart: Test failed - checks-actions

Failure:
error[E0412]: cannot find type `ipc_perm` in the crate root
  --> src/unix/linux_like/linux/musl/b64/mod.rs:51:25
   |
51 |         pub shm_perm: ::ipc_perm,
   |                         ^^^^^^^^ not found in the crate root

error[E0412]: cannot find type `ipc_perm` in the crate root
  --> src/unix/linux_like/linux/musl/b64/mod.rs:64:25
   |
64 |         pub msg_perm: ::ipc_perm,
   |                         ^^^^^^^^ not found in the crate root

error[E0412]: cannot find type `__rlimit_resource_t` in the crate root
   --> src/unix/linux_like/linux/musl/b64/s390x.rs:205:25
    |
205 | pub const RLIMIT_RSS: ::__rlimit_resource_t = 5;
    |                         ^^^^^^^^^^^^^^^^^^^ not found in the crate root

error[E0412]: cannot find type `__rlimit_resource_t` in the crate root
   --> src/unix/linux_like/linux/musl/b64/s390x.rs:206:24
    |
206 | pub const RLIMIT_AS: ::__rlimit_resource_t = 9;
    |                        ^^^^^^^^^^^^^^^^^^^ not found in the crate root

error[E0412]: cannot find type `__rlimit_resource_t` in the crate root
   --> src/unix/linux_like/linux/musl/b64/s390x.rs:207:29
    |
207 | pub const RLIMIT_MEMLOCK: ::__rlimit_resource_t = 8;
    |                             ^^^^^^^^^^^^^^^^^^^ not found in the crate root

error[E0412]: cannot find type `__rlimit_resource_t` in the crate root
   --> src/unix/linux_like/linux/musl/b64/s390x.rs:208:28
    |
208 | pub const RLIMIT_NOFILE: ::__rlimit_resource_t = 7;
    |                            ^^^^^^^^^^^^^^^^^^^ not found in the crate root

error[E0412]: cannot find type `__rlimit_resource_t` in the crate root
   --> src/unix/linux_like/linux/musl/b64/s390x.rs:209:27
    |
209 | pub const RLIMIT_NPROC: ::__rlimit_resource_t = 6;
    |                           ^^^^^^^^^^^^^^^^^^^ not found in the crate root

error: aborting due to 7 previous errors

For more information about this error, try `rustc --explain E0412`.
error: could not compile `libc`

@bors try

:hourglass: Trying commit 8898ff33c9c10a3c0805a0fd06736495e4c509d7 with merge 05863d9e25bc48fd8bcfdcb0145f4d8e541bcf50...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit<PHONE_NUMBER>4823ae3cb782828e153d56ee1cb9c0 has been approved by JohnTitor

:hourglass: Testing commit<PHONE_NUMBER>4823ae3cb782828e153d56ee1cb9c0 with merge 73c3a3ee33fae240124e837197ae6fb7f3ecdc11...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 8e12d7d3e497b12aa726460f9675020fc6b175a7 has been approved by JohnTitor

:hourglass: Testing commit 8e12d7d3e497b12aa726460f9675020fc6b175a7 with merge ee1236055376613ebf8aa853fca27030e48c14fc...

@bors retry r-

@bors r+

:pushpin: Commit 51d8538863bb61b54cdf74f68750d539f9ada62e has been approved by JohnTitor

:hourglass: Testing commit 51d8538863bb61b54cdf74f68750d539f9ada62e with merge 0b5f21160b53ddbcdf4182919d57dc420db2262d...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 9f2acfaa53566709a7a57c7be5c4287ec2f046d5 has been approved by JohnTitor

:hourglass: Testing commit 9f2acfaa53566709a7a57c7be5c4287ec2f046d5 with merge 04db260ac44d071eb98509970720cfc18932303b...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 04db260ac44d071eb98509970720cfc18932303b to master...


Added announcements application customizer sample

Q
A

Bug fix?
no

New feature?
no

New sample?
yes

Related issues?
n/a

What's in this Pull Request?
Added announcements application customizer sample

@waldekmastykarz,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thx Waldek, appreciated.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-24-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1386

Questions ?
Please refer to the Backport tool documentation


[Network] private link add Microsoft.Web/hostingEnvironments provider

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Network


Network/component start/stop notification

A network should notify the runtime when it has finished processing with stop event as well as when it has started with start event. A network is considered as stopped when the in-flight process counter is 0. Pending operations and broken components may prevent it from stopping correctly.
There are 2 common types of components in NoFlo:

Regular components which activate, get input, do something, send output and deactivate
Generator components which listen for external events, activate themselves, send output and keep listening for external events

For regular components the convention of notifying the network is the following:

The runtime sends activate event to the network right before calling the process function.
The process function is responsible for notifying the runtime and network of its status either by

Calling send or resolve callback with a map of output ports and the result values
Calling done callback if its output behavior is not so trivial

Upon receiving such a call, the runtime sends deactivate to the network

Generator components: WIP

Needs to address #221 and #261

Also see #385

So, basics:

There should be only a single start event emitted by the network per execution
There should be only a single end event emitted by the network per execution
Between the start and end events the network is considered to be "running"
Execution starts by calling network.start()
Execution ends either by calling network.stop() or when all components have finished processing
No packets may be transmitted, and components may not do any work while network is not running

Information we have currently available:

Socket status (connected, disconnected, packet count in buffer)
Component processing functions (return state/callback): c.process, WirePattern callback, AsyncComponent.doAsync
We have components that use one of the above, and also components that use the "pure" port API

@trustmaster regarding generator components, won't they work exactly the same way as "regular" components in this sense? They're anyway activated by an inbound packet (for example, a "bang") and so can use the process function. HTTP server as a "generator" example:
c = new noflo.Component
c.inPorts.add 'start',
  datatype: 'int'
c.inPorts.add 'stop',
  datatype: 'int'
c.outPorts.add 'request',
  datatype: 'object'

c.servers = {}
c.process (input, output) ->
  if input.has 'start'
    # We start the server when we receive a port to listen for
    port = input.get 'start'
    return unless port.type is 'data'
    return output.sendDone new Error "Already listening to #{port.data}" if c.servers[port.data]
    c.servers[port.data] = http.createServer (req, res) ->
      # New requests are sent out with send but without calling done
      output.send
        request: req
    c.servers[port.data].listen port.data, (err) ->
      if err
        c.servers[port.data] = null
        output.sendDone err
        return
    c.servers[port.data].on 'close', ->
      c.servers[port.data] = null
      # Done for this processing function is called only when the server closes
      output.done()

  if input.has 'stop'
    port = input.get 'start'
    return unless port.type is 'data'
    return output.sendDone new Error "Not listening to #{port.data}" unless c.servers[port.data]
    c.servers[port.data].close (err) ->
      return output.sendDone err if err
      output.done()

@bergie yes, generators need to be ignited by a incoming packet at some point, the question is how they activate and deactivate on incoming data or requests.
E.g. an HTTP server just starts and sets its handlers, it doesn't keep being activated all the time. In the above example we could imitate that long-running behavior by calling activate() on start packet and deactivate() on stop.
Another example is a component reading data from a Node.js stream or listening for DOM events. It is likely to be activated and deactivated on every chunk/event. The runtime is more probably interested in stream end event though. And for DOM events I dunno.

@trustmaster I think a generator should be considered "active" when it is listening to some external stuff, and "deactivated" when it stops listening. Doesn't really matter whether we're talking about a network service, a stream reader, or even setInterval.

Here's a quick-and-dirty diagram of how the network states change:

@bergie how did you generate that diagram?

@jonnor manually :-)

Regarding component state, here's what the Dataflow book says:

A node can be in one of a few states:

Not yet initiated: The initial state of all nodes
Terminated: Signifies that nodes will never be activated again
Active: The node is currently activated. This may be further subdivided into active-normal and active-suspended (active but waiting on an external event)
Inactive: The node is not activated but it is not terminated

Key notes from a Slack discussion:
There are 2 sets of 2 events each emitted by components and their parent networks:

started - a node has been initialized and started accepting packets
activated - a node has started processing some packets
deactivated - a node has finished processing current packets
stopped - a node has no jobs queued and has stopped accepting and processing packets

For normal components, process function, WirePattern, or AsyncComponent doAsync handles the activated/deactivated automatically. Generators have to emit these themselves and should be provided with methods to send these events to parent network.
If a component sends a packet to its outport while the network isn't running or the component has earlier declared itself as deactivated, the packet should be dropped and the network should emit a process-error.
Long-running networks can activate/deactivate for many times during a single lifecycle. Their lifecycle is normally ended by calling stop() externally.
Batch networks (ran via noflo-nodejs --batch) should call stop() on themselves automatically after receiving deactivated event.

Regarding generators, here is a simple one that can be used as an example about the lifecycle notifications:
https://github.com/noflo/noflo-core/blob/97c365ad7c0b1e5211d4f93a1ca792df9e6db92b/components/RunInterval.coffee

@trustmaster is this fine now that #455 is merged?

@bergie #455 makes the Network emit correct events and require callbacks. Then it's up to runtime how to use them. If you think it's beyond scope of this issue, then feel free to close it.


qt6: 6.4.0 → 6.4.1

Description of changes
Previous nixpkgs update: #193511
Release Notes: https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.4.1/release-note.md
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Note: some packages built but not extensive. Would appreciate a nixpkgs-review since I am currently working on a gcc12 branch.

Note: some packages built but not extensive. Would appreciate a nixpkgs-review since I am currently working on a gcc12 branch.

I'm working on one now, will be done probably in about an hour or so.

Result of nixpkgs-review pr 202086 run on x86_64-linux 1

3 packages marked as broken and skipped:

libsForQt512.fcitx5-qt
libsForQt514.fcitx5-qt
obs-studio-plugins.obs-hyperion

1 package failed to build:

obs-studio-plugins.obs-ndi

78 packages built:

beamerpresenter
beamerpresenter-poppler
calcmysky
calibre
cudaPackages.nsight_compute
cutemaze
duckstation
fcitx5-chinese-addons
fcitx5-configtool
fcitx5-unikey
fcitx5-with-addons
jami-client-qt
ladybird
libsForQt5.fcitx5-qt
maestral-gui
mozillavpn
obs-studio
obs-studio-plugins.input-overlay
obs-studio-plugins.looking-glass-obs
obs-studio-plugins.obs-backgroundremoval
obs-studio-plugins.obs-gstreamer
obs-studio-plugins.obs-move-transition
obs-studio-plugins.obs-multi-rtmp
obs-studio-plugins.obs-nvfbc
obs-studio-plugins.obs-pipewire-audio-capture
obs-studio-plugins.obs-source-record
obs-studio-plugins.obs-vkcapture
obs-studio-plugins.wlrobs
prismlauncher
python310Packages.pyqt6
python310Packages.pyqt6-webengine
python39Packages.pyqt6
python39Packages.pyqt6-webengine
qMasterPassword
qt6.full
qt6.qmake
qt6.qt3d
qt6.qt5compat
qt6.qtbase
qt6.qtcharts
qt6.qtconnectivity
qt6.qtdatavis3d
qt6.qtdeclarative
qt6.qtdoc
qt6.qthttpserver
qt6.qtimageformats
qt6.qtlanguageserver
qt6.qtlottie
qt6.qtmultimedia
qt6.qtnetworkauth
qt6.qtpositioning
qt6.qtquick3d
qt6.qtquick3dphysics
qt6.qtquicktimeline
qt6.qtremoteobjects
qt6.qtscxml
qt6.qtsensors
qt6.qtserialbus
qt6.qtserialport
qt6.qtshadertools
qt6.qtspeech
qt6.qtsvg
qt6.qttools
qt6.qttranslations
qt6.qtvirtualkeyboard
qt6.qtwayland
qt6.qtwebchannel
qt6.qtwebengine
qt6.qtwebsockets
qt6.qtwebview
qt6Packages.kcoreaddons
qt6Packages.poppler
qt6Packages.quazip
qt6Packages.qxlsx
qutebrowser-qt6
stellarium
tdesktop
zint

looks like the failure was only due to an unfree license, so we should be clear to merge.


UI Improvement for add to cart

I want to enhance the alert when any product is added. If possible assign this issue to under hacktoberfest 2023. Thanks for consideration :).

@Anuragpal010104 Assigned. Please make sure star the repo and follow me on github (https://github.com/karamraj).
Join Discord Server for this repo - https://discord.gg/SH6XRrHs8E

hey @Karamraj i have solved the issue and also created a PR with a screenshot, kindly merge my PR

hey @Karamraj please check my PR,

@balkishan69 Please tag this issue in your PR.

@Karamraj Done, kindly check


[JTC] Reject messages with effort fields (#699) (backport #719)

A manual backport without merge conflicts now.

Failing CI job is not related to this change imho, because it has failing tests with trajectories without efforts field.


Fix responsivity for EditTemplateButton & add responsivity for DeleteTemplateButton

This is done and merged.
https://github.com/ohtutraininghub/traininghub/pull/366


clarification on content

Under Test the asynchronous solution, its given that

In the synchronous version, the text box is cleared just before the counts appear for the second time, when the downloads are completed and the UI thread is free to do other work. In the asynchronous version, the text box clears immediately after you choose the Start button.

I think it's not possible as we have already used
// Disable the button until the operation is  #complete. startButton.IsEnabled = false;
and
// Reenable the button in case you want to run the operation again. startButton.IsEnabled = true;
So, how can we click on the Start button, when it is disabled?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 494fdee9-0e2c-55bc-dfc0-bc1e5809476f
Version Independent ID: 3f6b5873-7f2c-a463-bcd3-8093f4af9a2a
Content: Walkthrough: Accessing the Web by Using async and await (C#)
Content Source: docs/csharp/programming-guide/concepts/async/walkthrough-accessing-the-web-by-using-async-and-await.md
Product: dotnet-csharp
Technology: csharp-async
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for writing this @ranjan-ranjan
The purpose of using async calls in UI applications is to enable the UI to remain responsive. That's true in this application. But, the only action in the UI is to start the same action again. The sample should be expanded to have other actions possible while the download takes place. Possibly a timer, or some other action that could happen while the download is in progress.


Change getting started doc

Documentation Changes
This is part of this pull-request and issue.
Done

Modified contents from tutorial to readme. (I talked more about that here)
Changed the example repo because the skaffold does not have a docker image inside the project.
Changed task builder image from kaniko to buildah. (I think it is more user-friendly)
Changed the image registry to docker hub instead of gcr.
Changed service account to user docker hub api token.
Remove Pre-reqs or move them to before we start.

In Progress

Change the pipeline to support changes to the task.
Create a Table of Contents. Cause this 'tutorial' is really like 3 tutorials in 1. (hello world w/ taskrun, build-push image w/ taskrun, build-push-deploy-image w/ pipelinerun).
Clarify some confusion with a Task vs TaskRun and Pipeline vs PipelineRun.
Run the entire new edited version on a clean cluster
Change the output logs because they are out of date

Comments

There is a 'surprise' task under the pipeline section that will allow the user to deploy a simple image. I think cramming this task at the end of the pipeline section without a lot of explanation is confusing. Especially, since the word 'deployment' was not even mentioned until the very end. So, if anyone has sneaky ideas of introducing this task please let me know.

TL;DR: I once told a man, "I will get it done by lunch". I lied

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

/assign @dibyom

/assign @vdemeester

/assign @skaegi

/kind documentation

Thank you for all the updates! Could you squash all the commits before we LGTM?

Yeah, I need to rebase with master, squash commits and run this on local a few times before changing it from draft to a full pr.

oof, I goofed up the commit history.


ortb_blocking_supported and description section

@piotrj-rtbh added a single comment, please consider updating the text. We should be good to go then.


feat(bridge-history): change FinalizeBatch event logic

Purpose or design rationale of this PR
Upgrade the logic when dealing with FinalizeBatch event.
This is intended to support darwin as well as backward compatible.
One thing need caution: "GetLastFinalizedBatchIndex" from db can not use any index and it's not suitable to add such index since there will be almost 100% batches are all finalized as time goes. Do we need add a key-value mode cache to save the "last finalized batch index"? it can be a small kv table in postgres or using redis..
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[ ] build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
[ ] ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
[ ] docs: Documentation-only changes
[x] feat: A new feature
[ ] fix: A bug fix
[ ] perf: A code change that improves performance
[ ] refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
[ ] style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
[ ] test: Adding missing tests or correcting existing tests

Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?

[ ] No, this PR doesn't involve a new deployment, git tag, docker image tag
[ ] Yes

Breaking change label
Does this PR have the breaking-change label?

[x] No, this PR is not a breaking change
[ ] Yes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.84%. Comparing base (229809a) to head (e24f10f).

Additional details and impacted files
@@              Coverage Diff               @@
##           feat/upgrade4    #1404   +/-   ##
==============================================
  Coverage          53.84%   53.84%
==============================================
  Files                156      156
  Lines              12047    12047
==============================================
  Hits                6487     6487
  Misses              5055     5055
  Partials             505      505

Flag
Coverage Δ

bridge-history-api
72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This feature can be directly merged into the develop branch since it's backward compatible, we can deploy it first.
For discussion about: One thing need caution: "GetLastFinalizedBatchIndex" from db can not use any index and it's not suitable to add such index since there will be almost 100% batches are all finalized as time goes. Do we need add a key-value mode cache to save the "last finalized batch index"? it can be a small kv table in postgres or using redis..
this can be mitigated by the "composite index" as follows:
CREATE INDEX IF NOT EXISTS idx_be_batch_index_batch_status ON batch_event_v2 (batch_index, batch_status);

but I think using batch_index is sufficient since in your newly added query, it's sorted by batch_index desc, there won't be too many iterations before finding the first finalized batch.

I will open another PR with target branch "develop".
If the other is merged this can be closed anytime

This feature can be directly merged into the develop branch since it's backward compatible, we can deploy it first.
For discussion about: One thing need caution: "GetLastFinalizedBatchIndex" from db can not use any index and it's not suitable to add such index since there will be almost 100% batches are all finalized as time goes. Do we need add a key-value mode cache to save the "last finalized batch index"? it can be a small kv table in postgres or using redis..
this can be mitigated by the "composite index" as follows:
CREATE INDEX IF NOT EXISTS idx_be_batch_index_batch_status ON batch_event_v2 (batch_index, batch_status);

but I think using batch_index is sufficient since in your newly added query, it's sorted by batch_index desc, there won't be too many iterations before finding the first finalized batch.

shall we discuss in new pr ? or discuss here first

This feature can be directly merged into the develop branch since it's backward compatible, we can deploy it first.
For discussion about: One thing need caution: "GetLastFinalizedBatchIndex" from db can not use any index and it's not suitable to add such index since there will be almost 100% batches are all finalized as time goes. Do we need add a key-value mode cache to save the "last finalized batch index"? it can be a small kv table in postgres or using redis..
this can be mitigated by the "composite index" as follows:
CREATE INDEX IF NOT EXISTS idx_be_batch_index_batch_status ON batch_event_v2 (batch_index, batch_status);

but I think using batch_index is sufficient since in your newly added query, it's sorted by batch_index desc, there won't be too many iterations before finding the first finalized batch.

shall we discuss in new pr ? or discuss here first

both LGTM.


Bump cardano-addresses

Issue Number
Release.
Overview

[x] Bump cardano-addresses

Comments

I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release

Bump includes:
- [Increase default mnemonic phrase length](https://github.com/input-output-hk/cardano-addresses/pull/53)
- [Allow to inspect reward accounts wrt #46](https://github.com/input-output-hk/cardano-addresses/pull/56)
- [Allow to generate stake addresses #58](https://github.com/input-output-hk/cardano-addresses/pull/58)
- [Make 'payment' subcommand generate testnet hrp, wrt #55](https://github.com/input-output-hk/cardano-addresses/pull/59)

bors r+

Regenerating nix fails because of * Missing (or bad) C library: sodium
./nix/regenerate.sh                                                                                (6s 360ms)
these derivations will be built:
  /nix/store/d6k5nb583v6ghskqjiwy4q57a8fzlv92-saltine-lib-saltine-<IP_ADDRESS>.drv
  /nix/store/lc1c33qwizwskqya926l429iffsjbkvh-hnix-store-core-lib-hnix-store-core-<IP_ADDRESS>-config.drv
  /nix/store/jwyw6w770m1aqr30hpavk192723aqz6y-hnix-store-core-lib-hnix-store-core-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/dza3053l9zbxrlxq0sw6zv3hgr90mds7-hnix-store-core-lib-hnix-store-core-<IP_ADDRESS>.drv
  /nix/store/nqp05d762xfh7b13qrvcrj83r3qr8k09-hnix-lib-hnix-0.8.0-config.drv
  /nix/store/7h8x8yr653nn4n4skc2hi798dfmqhsip-hnix-lib-hnix-0.8.0-ghc-8.6.5-env.drv
  /nix/store/jbfp7nrs3ar79b6yq7ww73l1kzwhl3c4-hnix-lib-hnix-0.8.0.drv
  /nix/store/kxfqi9wc6qza3z0y5znxy5qlakv3ic1v-nix-tools-lib-nix-tools-<IP_ADDRESS>-config.drv
  /nix/store/jnx4lap268a5dsm3vim4njigk1gkfnj7-nix-tools-lib-nix-tools-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/hxywjd0jc1axnvxhk332395wrch67yhp-nix-tools-lib-nix-tools-<IP_ADDRESS>.drv
  /nix/store/2q7hb0z0mkzrwysgqh14y947yypnb74l-nix-tools-exe-lts-to-nix-<IP_ADDRESS>-config.drv
  /nix/store/44yqwwzgmp6w0f5zl10vd1aq2pgw9zya-nix-tools-exe-stack-to-nix-<IP_ADDRESS>-config.drv
  /nix/store/4pd6qhs3687mskbjz4r52g9mfsbvizix-nix-tools-exe-plan-to-nix-<IP_ADDRESS>-config.drv
  /nix/store/s9kvyj0sdcqa96mgkh3bamzy9s549s88-nix-tools-exe-stack-repos-<IP_ADDRESS>-config.drv
  /nix/store/5z5q6anz2b33h2shb088l413qsc3qccg-nix-tools-exe-stack-repos-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/7flrjpkdibh5lwhw67kqwxyj4msh1sz0-nix-tools-exe-hackage-to-nix-<IP_ADDRESS>-config.drv
  /nix/store/93251rn98bpppayad2frrq6jnwsg32f8-nix-tools-exe-stack-repos-<IP_ADDRESS>.drv
  /nix/store/j17jy1dnrl4wd54kl266l5a85vr1pjzx-nix-tools-exe-cabal-name-<IP_ADDRESS>-config.drv
  /nix/store/cn0ws5qarnrghgk0frynsgaki6k1pn6v-nix-tools-exe-cabal-name-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/j8jp8z5ciww94xqnam9qlw1kx3jwgia5-nix-tools-exe-hashes-to-nix-<IP_ADDRESS>-config.drv
  /nix/store/qg0apmkvsqwmgs2h53gpvj5z1mssra0p-nix-tools-exe-hashes-to-nix-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/cn3366f5qlvhkns87md51kldvrsgn8n8-nix-tools-exe-hashes-to-nix-<IP_ADDRESS>.drv
  /nix/store/fswkdg5cyk64p6igvsx0w6wraj6x4vls-nix-tools-exe-plan-to-nix-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/qbclhhdb5qdvq3jcb3jwzp251xf6cwin-nix-tools-exe-cabal-to-nix-<IP_ADDRESS>-config.drv
  /nix/store/qqvhdn5bkcsihz0xccfippxcyxr0klsx-nix-tools-exe-cabal-to-nix-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/gp2k935m7cam3d2zy5kl8dlpap12iadc-nix-tools-exe-cabal-to-nix-<IP_ADDRESS>.drv
  /nix/store/iwzza3kyzlx4rqys6wnk5api62ysmj3w-nix-tools-exe-lts-to-nix-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/hj0mlm77in84dzfd0g3f33k4vjmvvmg3-nix-tools-exe-lts-to-nix-<IP_ADDRESS>.drv
  /nix/store/y6kjmhvdymdvpsybm8v8n514dqmvch8j-nix-tools-exe-stack-to-nix-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/hw977krma2vpmk04sdn58dla6f7javn4-nix-tools-exe-stack-to-nix-<IP_ADDRESS>.drv
  /nix/store/iv075y9qr9w69spjdbcf8p1yvwp8y5xc-nix-tools-exe-hackage-to-nix-<IP_ADDRESS>-ghc-8.6.5-env.drv
  /nix/store/iz42vm7bgcpif535mkqwww8s8k9rsjzw-nix-tools-exe-plan-to-nix-<IP_ADDRESS>.drv
  /nix/store/jddxx1nyvyymva8hx98ql6j7dma27z65-nix-tools-exe-cabal-name-<IP_ADDRESS>.drv
  /nix/store/nwn8i9639kmdkmh8lm113x8l4lmlzd0h-nix-tools-exe-hackage-to-nix-<IP_ADDRESS>.drv
  /nix/store/mbd36wsamk7qb4mx5a0spmhdwpdkj8lv-nix-tools.drv
  /nix/store/vpjssbczqhhsfg31ndsfk42s92w96rf9-nix-tools-regenerate.drv
building '/nix/store/d6k5nb583v6ghskqjiwy4q57a8fzlv92-saltine-lib-saltine-<IP_ADDRESS>.drv'...
unpacking sources
unpacking source archive /nix/store/g26wd0dpwr7jj0cnlf3nfrycmjjcc5jp-saltine-<IP_ADDRESS>.tar.gz
source root is saltine-<IP_ADDRESS>
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file saltine-<IP_ADDRESS>/tests/Util.hs
patching sources
configuring
Configure flags:
--prefix=/nix/store/5v45dsvmymcjsl9n0178w4vdxi4vwwdh-saltine-lib-saltine-<IP_ADDRESS> lib:saltine --package-db=clear --package-db=/nix/store/j7gljbghidmv3sdzw6jvwmi8a59hs782-saltine-lib-saltine-<IP_ADDRESS>-config/lib/ghc-8.6.5/package.conf.d --exact-configuration --dependency=profunctors=profunctors-5.5.2-4f1L4urpgFX4DbJxgxiTx3 --dependency=hashable=hashable-<IP_ADDRESS>-1RsrIcitxVDKffGN1TuMlm --dependency=rts=rts --dependency=ghc-heap=ghc-heap-8.6.5 --dependency=ghc-prim=ghc-prim-0.5.3 --dependency=integer-gmp=integer-gmp-<IP_ADDRESS> --dependency=base=base-<IP_ADDRESS> --dependency=deepseq=deepseq-<IP_ADDRESS> --dependency=array=array-<IP_ADDRESS> --dependency=ghc-boot-th=ghc-boot-th-8.6.5 --dependency=pretty=pretty-<IP_ADDRESS> --dependency=template-haskell=template-haskell-<IP_ADDRESS> --dependency=ghc-boot=ghc-boot-8.6.5 --dependency=ghc=ghc-8.6.5 --dependency=array=array-<IP_ADDRESS> --dependency=binary=binary-<IP_ADDRESS> --dependency=bytestring=bytestring-<IP_ADDRESS> --dependency=containers=containers-<IP_ADDRESS> --dependency=directory=directory-<IP_ADDRESS> --dependency=filepath=filepath-<IP_ADDRESS> --dependency=ghc-boot=ghc-boot-8.6.5 --dependency=ghc-compact=ghc-compact-<IP_ADDRESS> --dependency=ghc-prim=ghc-prim-0.5.3 --dependency=hpc=hpc-<IP_ADDRESS> --dependency=mtl=mtl-2.2.2 --dependency=parsec=parsec-<IP_ADDRESS> --dependency=process=process-<IP_ADDRESS> --dependency=text=text-<IP_ADDRESS> --dependency=time=time-<IP_ADDRESS> --dependency=transformers=transformers-<IP_ADDRESS> --dependency=unix=unix-<IP_ADDRESS> --dependency=xhtml=xhtml-3<IP_ADDRESS> --with-ghc=ghc --with-ghc-pkg=ghc-pkg --with-hsc2hs=hsc2hs --with-gcc=cc --with-ld=ld --with-ar=ar --with-strip=strip --disable-executable-stripping --disable-library-stripping --disable-library-profiling --disable-executable-profiling --enable-static --enable-shared
Configuring library for saltine-<IP_ADDRESS>..
Warning: The flag --disable-executable-profiling is deprecated. Please use
--disable-profiling instead.
Setup: Missing dependency on a foreign library:
* Missing (or bad) C library: sodium
This problem can usually be solved by installing the system package that
provides this library (you may need the "-dev" version). If the library is
already installed but in a non-standard location then you can use the flags
--extra-include-dirs= and --extra-lib-dirs= to specify where it is.If the
library file does exist, it may contain errors that are caught by the C
compiler at the preprocessing stage. In this case you can re-run configure
with the verbosity flag -v3 to see the error messages.

builder for '/nix/store/d6k5nb583v6ghskqjiwy4q57a8fzlv92-saltine-lib-saltine-<IP_ADDRESS>.drv' failed with exit code 1
cannot build derivation '/nix/store/lc1c33qwizwskqya926l429iffsjbkvh-hnix-store-core-lib-hnix-store-core-<IP_ADDRESS>-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dza3053l9zbxrlxq0sw6zv3hgr90mds7-hnix-store-core-lib-hnix-store-core-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nqp05d762xfh7b13qrvcrj83r3qr8k09-hnix-lib-hnix-0.8.0-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jbfp7nrs3ar79b6yq7ww73l1kzwhl3c4-hnix-lib-hnix-0.8.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gp2k935m7cam3d2zy5kl8dlpap12iadc-nix-tools-exe-cabal-to-nix-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nwn8i9639kmdkmh8lm113x8l4lmlzd0h-nix-tools-exe-hackage-to-nix-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cn3366f5qlvhkns87md51kldvrsgn8n8-nix-tools-exe-hashes-to-nix-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hj0mlm77in84dzfd0g3f33k4vjmvvmg3-nix-tools-exe-lts-to-nix-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/iz42vm7bgcpif535mkqwww8s8k9rsjzw-nix-tools-exe-plan-to-nix-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kxfqi9wc6qza3z0y5znxy5qlakv3ic1v-nix-tools-lib-nix-tools-<IP_ADDRESS>-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hxywjd0jc1axnvxhk332395wrch67yhp-nix-tools-lib-nix-tools-<IP_ADDRESS>.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mbd36wsamk7qb4mx5a0spmhdwpdkj8lv-nix-tools.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vpjssbczqhhsfg31ndsfk42s92w96rf9-nix-tools-regenerate.drv': 1 dependencies couldn't be built
error: build of '/nix/store/vpjssbczqhhsfg31ndsfk42s92w96rf9-nix-tools-regenerate.drv' failed

Thanks @rvl!
bors r+

It looks like the regenerate script may not work on macos. CI only builds it for linux at the moment.

bors r+

bors r+

bors r+

bors r+

Oh, this might be a real problem, not just flakiness 🤦♂

bors try

bors r+

bors r+

bors r+


[Feature]: Discuss how to deal with dev.launch

Description
Currently the distributed devroute calls a different launchfile than the normal devroute:
https://github.com/una-auxme/paf/blob/2b11fb2c4a38e7bcf87e87511ee88350a09cd55d/build/docker-compose.devroute-distributed.yaml#L11
Is the dev.launch still needed?
Definition of Done
No response

[ ] Comment the prupose of https://github.com/una-auxme/paf/blob/main/code/agent/launch/dev.launch
[ ] Remove from devroute-distributed
[ ]


Add "fools protection" in BootstrapWidgetTrait

Q
A

Is bugfix?
✔/❌

New feature?
❌

Breaks BC?
❌

Fixed issues
#49

Doesn't this make debugging more complicated? If the element is not present, you don't see an exception in browser console any more with this change.

@simialbi I expressed my opinion in #49, but I think that he is not alone... I don't planed break popular extensions :)

Ok. So kartik's gridview uses the widget without rendering the button? Maybe there is a better solution which does not break debug option 🤔.

@simialbi his widget using template like as $template = "{head}{body}{footer}"; and renders   blocks for all placeholders, but user can customize template and remove some placeholders:  $template = "{head}{body}"; in this case {footer} block still rendered. Footer output BS widget and widget add self JS to page.

@simialbi my solution is use preg_replace_callback('/{\w+}/', $callback, $template) instead strtr($template, ['head' => $this->renderHead(), ...]), but I don't plan to seminars "How optimize your code" for authors of popular extensions (:

Doesn't this make debugging more complicated? If the element is not present, you don't see an exception in browser console any more with this change.

Hi... When using earlier with jQuery in yii2-bootstrap5 v2.3 - no debug/error message was thrown even if the selector does not exist because of the way jQuery inherentlyworks ...
"jQuery('#$id').$name($options);"  // will not throw error even if selector with $id does not exist

I assume the same behavior should be implemented for use without jQuery.
var bs5pluginElement = document.getElementById('$id');
// this will throw an error when bs5pluginElement is used in subsequent javascript operations
// without validating if it is undefined

IMO... individual developers can choose to validate whether the element exists or not before initializing the plugin.


Crashes when playing AV1 video

When trying to play a video with the AV1 codec it crashes the app, it is working fine with Windows Media player.
I have installed the AV1 codec from the Microsoft Store, before that it would just not play the video.

I pushed a solution to github, it can solve this issue.
However this solution didn't handle the odd video width/height,
so I will handle it in these two days, and then will push to pub.dev
If you need the temp solution ASAP, please try the newest version on github:
dependencies:
  video_player: ^2.4.7
  video_player_win:
    git:
      url: https://github.com/jakky1/video_player_win.git
      ref: master

By the way,
I can't find the way to play AV1 video with K-lite codec, (even though it can be played by Windows Media Player...)
but this solution can play AV1 with "AV1 video extention" in Microsoft Store you mentioned.
I will add this information into README later.

Thank you! It's now working perfect.


HTTP1 codec: Remove dead code.

Signed-off-by: Kevin Baichoo<EMAIL_ADDRESS>
Commit Message: Cleanup dead code in HTTP1 codec.
Additional Description:

See coverage, but also the fact that between the two calls to resetStreamCalled() none of the calls change would change that state.


Doesn't work out of the box, Module not found: 'react/lib/React'

Hi there,
after following the latest install-with-template instructions and running yarn run web the following error appears:
Failed to compile.

Error in ./~/react-dom/lib/ReactMount.js
Module not found: 'react/lib/React' in /Users/User/dev/testing/react-native/r10/node_modules/react-dom/lib

 @ ./~/react-dom/lib/ReactMount.js 1:156-182

Steps:
react-native init r10 --template everywhere
cd r10
node scripts/addDevDependencies.js
yarn run web

I thought that maybe react-dom is too old and upgraded to 16.0.0-alpha.12, which changed the error to:
Failed to compile.

Error in ./~/react-native-web/dist/modules/injectResponderEventPlugin.js
Module not found: 'react-dom/lib/EventPluginHub' in /Users/User/dev/testing/react-native/r10/node_modules/react-native-web/dist/modules

 @ ./~/react-native-web/dist/modules/injectResponderEventPlugin.js 1:20-59

Any idea where the issue might be?
I've added my current package.json here:
https://gist.github.com/berstend/02e2b3b8319a051f86353789afec6cff

Seems to be a compatibility issue with react-native-web. It is not ready for react 16 yet. Look at the note here.

Replace your package.json with the content in the gist below:
https://gist.github.com/amoghbanta/d0bf78ff4e29100a311f9ab2987cf9c6
delete your node_modules:
 rm -rf node_modules
install new dependencies:
yarn install or npm i
finally run the project and also delete the cached content
 yarn run web --reset-cache

Do tell me if this works for you. I'll update the dependencies and add a note in readme.

Great, thanks for the fast reply @amoghbanta
I've followed your instructions (as well as removing the yarn.lock file) and got this error:
Failed to compile.

Error in ./~/react-native-web/dist/index.js
Module build failed: ReferenceError: Unknown plugin "transform-react-remove-prop-types" specified in "/Users/User/dev/testing/react-native/r10/node_modules/react-native-web/package.json" at 0, attempted to resolve relative to "/Users/User/dev/testing/react-native/r10/node_modules/react-native-web"
    at Array.map (native)
 @ ./index.web.js 1:164-187

After adding babel-plugin-transform-react-remove-prop-types as dependency the above error was resolved and the demo runs smoothly now. 🎉
Thanks a lot!

I had the same issues with the fresh install. I'm currently trying to play with React 16 which was installed anyway as the dependency of<EMAIL_ADDRESS>so I have upgraded react-dom too. Have hit all these 3 errors, the final one being somethign wrong with the config in my understanding.


unify shortcut on Mac

'paste' events are triggered with 'Command + V' on Mac, but 'copy' actions in jExcel are triggered with 'Ctrl + C' regardless, thus inconsistent.

Thank you for your pull request.


OCPBUGS-44031: Verify tls while pulling down IPA

This image was originally pulled down without tls
verify in ironic-image and the flag was then carried around as the code moved. Remove the flag.

/retest-required

/test e2e-metal-ipi-ovn-ipv6


argo list does not show workflows from all instances or accept --instanceid

Checklist:

[x] I've included the version.
[x] I've included reproduction steps.
[x] I've included the workflow YAML.
[ ] I've included the logs. (N/A - can do if necessary.)

What happened:
We have deployed an argo 2.7.3 workflow controller with an instance ID in the configmap alongside a 2.3.0 controller.
argo list only shows workflows from the controller with no instance ID (2.3.0) and I can't work out how to get it to show the other workflows (see reproduction steps below.)
kubectl get workflows functions as expected.
What you expected to happen:
argo list could show all workflows, or support the --instanceid argument.
How to reproduce it (as minimally and precisely as possible):
! ~ $ argo submit --instanceid 27 https://raw.githubusercontent.com/argoproj/argo/master/examples/hello-world.yaml
Name:                hello-world-c29t6
Namespace:           whatever-dev
ServiceAccount:      default
Status:              Pending
Created:             Wed Apr 22 16:18:05 +0100 (now)
! ~ $ argo submit https://raw.githubusercontent.com/argoproj/argo/master/examples/hello-world.yaml
Name:                hello-world-xbb22
Namespace:           whatever-dev
ServiceAccount:      default
Status:              Pending
Created:             Wed Apr 22 16:18:14 +0100 (now)
! ~ $ argo list | grep hello-world
hello-world-xbb22      Running     3s     3s         0
hello-world-mbg4n      Succeeded   1d     5s         0
hello-world-jpfbf      Succeeded   142d   18s        0
! ~ $ argo list --instanceid 27
Error: unknown flag: --instanceid

Anything else we need to know?:
Environment:

Argo version: 2.7.3

$ argo version

Kubernetes version :

v1.14.9-eks-502bfb

Message from the maintainers:
If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

Are you connecting to the Argo Server - if so you will not see any workflows that the server cannot see.

I don't think so, I tried with that and get connection closed, but it's going through a k8s ingress so that might be something off in our setup:
! ~ $ argo --argo-server argo27.xyz.xyz.xyz:443 list
FATA[0000] rpc error: code = Unavailable desc = connection closed

Ok  - we don't support #2764 yet for the CLI. This most likely means you're using the CLI in "classic" mode and there is a bug.


Document what users should do instead of containerized build actions

We intend to never support using a container runtime as an input to a Bazel action, because

it's so difficult to be hermetic (e.g. remote execution with a container runtime)
also difficult to be deterministic (avoiding timestamps in the output, etc).
hard to get the container runtime for the exec platform (we'd need to bulid a Bazel toolchain to supply the container runtime for the right platform) and also ensure the container is built for that architecture.

Possibilities for users migrating from run_and_commit_layer and related rules:

When the run_and_commit_layer is just to build a base image with 3p tools, recommend hosting their own base image, or use rules from distroless-tools
User could wire up their own thing to use emulation
User can still write their own rule to spawn an action that does work in a container (e.g. run_binary rule) - we just don't want to commit to supporting that use case.

closing as duplicate of #132


Max uuid

add Max uuid

LGTM, but please address the conventional commits error in the tests.  Thank you!

Please give me a hint, which questions need to be corrected? Thanks!
I add go 1.18 support in go.mod

Please give me a hint, which questions need to be corrected? Thanks! I add go 1.18 support in go.mod

Can you please revert this and send it in a separate commit? Best to keep these things separate.

I fixed the title and applied automerge. Bots will squash-merge the commits with the title as the commit, which conforms to the conventional commit spec.
Please remove the Go 1.18 change though.

ok already revert . Thank you!


Update README with babel plugin ordering

Had a hard time today figuring out why a very simple mobx react sandbox app did not work.
Turned out that the issue was due to the order of babel plugins in my .babelrc.
transform-decorators-legacy has to appear first in the list, otherwise it will break with at least either transform-function-bind or transform-class-properties plugins if they defined before it, with the wrong orders, observables are not triggered at all.
Would be great to update README to clarify this.

wow, never noticed that the order is relevant. thanks for reporting, I'll update it

Maybe that's something that mobx could catch? (like if the class property decorator gets a function instead of an object/array ref), would be great to add a console warning if it can be safely catchable.

good one, I'm gonna check whether it is detectable

Thank you so much for posting this, I've been tearing my hair out trying to understand why nothing was working.


[Linux] PyTorch build ERROR on release-1.1

on Linux, got the following error when building pytorch according to the installation instruction:

error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^

at the step
pushd 3rdparty/pytorch/tools/
REL_WITH_DEB_INFO=1 python build_libtorch.py
popd

whole error log:

[ 22%] Building CXX object third_party/protobuf/cmake/CMakeFiles/libprotobuf.dir//src/google/protobuf/util/type_resolver_util.cc.o
[ 22%] Building CXX object third_party/protobuf/cmake/CMakeFiles/libprotobuf.dir//src/google/protobuf/wire_format.cc.o
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp: In member function ‘void mkldnn::impl::cpu::_ref_rnn_common_t::pack_weights(int, int, int, int, int, int, int, float**, int, int*, const float*, float*, bool)’:
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:36: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:36: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp: In member function ‘void mkldnn::impl::cpu::_ref_rnn_common_t::free_packed_weights(int, int, int, float**)’:
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:17: error: ‘void cblas_sgemm_free(float*)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:17: error: ‘void cblas_sgemm_free(float)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp: In instantiation of ‘void mkldnn::impl::cpu::_ref_rnn_common_t::pack_weights(int, int, int, int, int, int, int, float*, int, int*, const float*, float*, bool) [with mkldnn_prop_kind_t aprop = (mkldnn_prop_kind_t)64u]’:
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:1183:17:   required from here
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:53: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:53: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:53: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp: In instantiation of ‘void mkldnn::impl::cpu::_ref_rnn_common_t::free_packed_weights(int, int, int, float**) [with mkldnn_prop_kind_t aprop = (mkldnn_prop_kind_t)64u]’:
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:1183:17:   required from here
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:33: error: ‘void cblas_sgemm_free(float*)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:33: error: ‘void cblas_sgemm_free(float)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:33: error: ‘void cblas_sgemm_free(float)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
[ 22%] Building CXX object third_party/protobuf/cmake/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/wrappers.pb.cc.o
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp: In instantiation of ‘void mkldnn::impl::cpu::_ref_rnn_common_t::pack_weights(int, int, int, int, int, int, int, float*, int, int*, const float*, float*, bool) [with mkldnn_prop_kind_t aprop = (mkldnn_prop_kind_t)128u]’:
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:1184:17:   required from here
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:53: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:53: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:891:53: error: ‘float* cblas_sgemm_alloc(CBLAS_IDENTIFIER, int, int, int)’ is deprecated [-Werror=deprecated-declarations]
weights(i, d, p) = cblas_sgemm_alloc(CblasAMatrix, m_p, n, k_p);
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:791:25: note: declared here
MKL_DEPRECATED_C float* cblas_sgemm_alloc(const  CBLAS_IDENTIFIER identifier,
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp: In instantiation of ‘void mkldnn::impl::cpu::_ref_rnn_common_t::free_packed_weights(int, int, int, float**) [with mkldnn_prop_kind_t aprop = (mkldnn_prop_kind_t)128u]’:
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:1184:17:   required from here
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:33: error: ‘void cblas_sgemm_free(float*)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:33: error: ‘void cblas_sgemm_free(float)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float dest);
^
/home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:979:33: error: ‘void cblas_sgemm_free(float)’ is deprecated [-Werror=deprecated-declarations]
cblas_sgemm_free(weights(i, j, k));
^
In file included from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/gemm/os_blas.hpp:39:0,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.hpp:30,
from /home/chenyuyang01/git/TorchCraftAI/3rdparty/pytorch/third_party/ideep/mkl-dnn/src/cpu/ref_rnn.cpp:39:
/home/chenyuyang01/anaconda3/envs/sc2/include/mkl_cblas.h:804:23: note: declared here
MKL_DEPRECATED_C void cblas_sgemm_free(float *dest);
^
Scanning dependencies of target c10_StreamGuard_test
[ 22%] Building CXX object c10/test/CMakeFiles/c10_StreamGuard_test.dir/core/StreamGuard_test.cpp.o
Scanning dependencies of target c10_DeviceGuard_test
[ 22%] Building CXX object c10/test/CMakeFiles/c10_DeviceGuard_test.dir/core/DeviceGuard_test.cpp.o
Scanning dependencies of target c10_TensorTypeId_test
[ 23%] Building CXX object c10/test/CMakeFiles/c10_TensorTypeId_test.dir/core/TensorTypeId_test.cpp.o
Scanning dependencies of target c10_registry_test
[ 23%] Linking CXX executable ../../bin/c10_InlineDeviceGuard_test
[ 23%] Building CXX object c10/test/CMakeFiles/c10_registry_test.dir/util/registry_test.cpp.o

Hello, and thank you for reporting this bug
It looks like this bug might be related to having an outdated version of PyTorch on our end - but until we get that sorted out (@ebetica ?), maybe it's easier for you to downgrade MKL version if possible.
Reference: https://github.com/pytorch/pytorch/issues/18365


153 conditional UI

Issue #, if available: #153
Description of changes:
Makes the PCAUI stack optional, default to on. New parameter EnableTranscriptGui.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bharvillsos My apologies that we have not acted on this PR till now... I will discuss with @kishd - our new PCA primary maintainer..

I resolved conflicts caused by code divergence and merged via new PR #264
Closing this PR.
Thanks @bharvillsos - if testing goes well this will be in the next release.


⚠ Fortnite has degraded performance

In 2cb5e8c, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1644 ms

Resolved: Fortnite performance has improved in 2af8337.


Automated Package Upgrade

:tada: This PR is included in version 13.0.106 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Deployment from Redesign Repos to Production (Volvo Only)

We have defined the overall process of the deployment from Redesign repos to Prod here:
https://projects.netcentric.biz/wiki/display/VOLVOFN/Deployment+process+of+Production+ready+redesign+blocks
to summarise from the main document, the main ideas would be:

Netcentric will do QA smoke regression testing of the PR to be merged upstream and
Netcentric proposal to Volvo is to have an UAT testing and sign off step before merging the new functionality into production, this may require some content preparation upfront in some cases to ensure a specific page is ready for the new blocks.

Next Steps:

Assess the importance of each of bugs found and they are blockers or not to go-live. :white_check_mark:
Those filtered in are the ones we would to estimate (high-level) effort. :white_check_mark:
Plan based on the priorities of those bugs (and, of course, taking into account the ongoing redesign backlog work priorities as well) :white_check_mark:
Execute the bug fixing step  ( 2d)
UAT testing (2d)

We would be targeting next Thursday (ideally 9/28) to sync up prod repos. We would like to confirm with you, header and footer updates to prod repos are fine.

Agile Requirement
As a business owner, I want to approve the signed off code before going live.
Description
Test the following URLs (QA and UAT) to sign them off:
Also, test the header and footer prior to deployment.
Acceptance Criteria

The above-mentioned urls and header and footer are tested and approved by business before they are merged to production.

Above QA/UAT comment updated. FYI @Andrei-Boiangiu , @ZoeBeykirch , @BeckyMedlin , @Kannan-CM ,
@Joesturbo

@manuel-vara @DanielaPedrochevd Should this be split into 2 stories - one for Volvo and one for Mack?

Posting here content ( or possible content) issues.

on Homepage https://develop--vg-volvotrucks-us-rd--netcentric.hlx.page/

Images from Trucks Lineup carousel are displayed as compressed on Mobile view

On Trucks -> VNL -> Exterior  https://develop--vg-volvotrucks-us-rd--netcentric.hlx.page/trucks/vnl/exterior/

Video does not play

Footer needs to be updated before pushing to production for small content text change - reference  https://github.com/Netcentric/vg-volvotrucks-us-rd/issues/145

https://develop--vg-volvotrucks-us-rd--netcentric.hlx.page/

confirmed as fixed

additional possible content issue for PDP page
https://develop--vg-volvotrucks-us-rd--netcentric.hlx.page/pdp
on the Trucks Lineup Carousel, the first three Truck images are displayed as stretched and not aligned when compared to the last two trucks

On hold until we get the images we need to fix the content issue reported in the previous comments.

@Kannan-CM Have the content issues noted in this ticket been resolved yet?

Hi @BeckyMedlin ,
belileve the new images fixed the issue.


Startcom (M-Lab Sites's CA) is deprecated

Related: https://blog.gerv.net/2016/10/wosign-and-startcom/
Nodes use Thawte, which should be okay. But perhaps we should plan to move to Let's Encrypt?

It doesn't appear that CloudFront supports Let's Encrypt. But Amazon has it's own certificate management tool (ACM), and I've generated a wildcard certificate for *.measurementlab.net and applied it to both www.measurementlab.net and speed.measurementlab.net. The certs are signed by Amazon's own CA, which is apparently supported by all major browsers.

@nkinkade: That's fine, but to be clear, CloudFront definitely supports Let's Encrypt.


Use common protobuf version to generate API files

PR Template:
Describe your changes

Built a dockerized protoc to pin the protobuf versioning for all.
Updated make config and make api to use dockerized protoc instead of user installation.
protoc version pinned @ v27.1

Ticket reference (if applicable)
Fixes # https://issues.redhat.com/browse/RHCLOUD-33323
Checklist

[ ] Are the agreed upon acceptance criteria fulfilled?

[ ] Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

[ ] Do your changes have passing automated tests and sufficient observability?

[ ] Are the work steps you introduced repeatable by others, either through automation or documentation?

[ ] If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
[ ] An SOP (Standard Operating Procedure) was created

[ ] The Changes were automatically built, tested, and  - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

[ ] Are the agreed upon coding/architectural practices applied?

[ ] Are security needs fullfilled? (e.g. no internal URL)

[ ] Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

[ ] For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Just tested on your branch and it runs great. Image building takes a while, but the image is retained on the next run of make api, so it's very quick after that.


GoDaddy DynDNS update through Godaddy API

Add plugin for Dynamic DNS updates for Godaddy using the API.

Hi, I came looking for this, I'm not sure how much is shared with the DynDNS service and pfSense, but I note they have it available.

I was about to log a ticket, but see this here... any update? migrated from pfsense to opnsense. The dashboard broke on pfsense (complete mystery, causing the move). Now I do not have this functionality to update my DNS dynamically, where pfsense had it out-of-the-box... I see the last comment was made on 2 Feb... is this being looked into?

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.

This issue should be resolved by the basic support of GoDaddy DynDNS provided by the following merge request:
https://github.com/opnsense/plugins/pull/1654


New memo version

Codecov Report
Patch coverage: 69.09% and project coverage change: +3.42 :tada:

Comparison is base (3312c50) 58.67% compared to head (ddee68f) 62.09%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #280      +/-   ##
==========================================
+ Coverage   58.67%   62.09%   +3.42%
==========================================
  Files          35       37       +2
  Lines        5326     5952     +626
==========================================
+ Hits         3125     3696     +571
- Misses       2201     2256      +55

Impacted Files
Coverage Δ

zingo-memo/src/lib.rs
37.50% <37.50%> (-35.42%)
:arrow_down:

zingo-memo/src/utils.rs
69.35% <69.35%> (ø)

zingo-memo/src/memo_serde.rs
72.72% <72.72%> (ø)

zingolib/src/blaze/fetch_full_transaction.rs
85.55% <83.33%> (ø)

zingolib/src/wallet.rs
63.69% <100.00%> (-0.21%)
:arrow_down:

... and 12 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Missing power, toughness, loyalty, and falvor_text attributes

That's just it. The CardObject class is missing the missing power, toughness, loyalty, and falvor_text attributes

Does this mean that if I create a creature object from Swiftfall.card(“Tarmogoyf”) it’s power and toughness aren’t tracked?

It just means that I forgot to add a way to access it. If you use card.scryfallJson['power'] you can still access the power value.
I'll add this in the next update but I'm working on issue #6 right now, unless someone makes a pull request directly to develop branch.

Closing issue, solved from pull request #9


Developing a GraphQL playground dedicated for AOTF

As part of MVP II phase, there was a discussion on developing a GraphQL playground dedicated for "Associations on the Fly"
Originally posted by @buniello in https://github.com/opentargets/issues/issues/2913#issuecomment-1535023736

The public platform API playground has PPP widgets in the Query Variables which ideally should not be there.


Service Location Map

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix
Test URLs:

Before:

https://main--shredit--stericycle.aem.live/drafts/piyush/map

After:

https://sl-map--shredit--stericycle.aem.live/drafts/piyush/map

Search Functionality is not implemented as of now

@dkuntze Can you please review it