[libconfig] Unable to find libconfig-config.cmake when including in build

Host Environment

OS: Windows 10
Compiler: MSVC 19.28.29336

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libconfig
CMakeLists.txt contains:
find_package(libconfig CONFIG REQUIRED)
...
target_link_libraries(main PRIVATE libconfig)

cmake .. -G "Visual Studio 16 2019" -A Win32 -DCMAKE_TOOLCHAIN_FILE=D:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake
cmake --build . --config Debug
Failure logs
[cmake] -- Running vcpkg install
[cmake] Detecting compiler hash for triplet x86-windows...
[cmake] The following packages will be built and installed:
[cmake]     libconfig[core]:x86-windows -> 1.7.2#3
[cmake] Using cached binary package: C:\Users\thoma\AppData\Local\vcpkg\archives\ec\ec7f4f0637b7ee9a479aeb8df8ba749a734e1060.zip
[cmake] Starting package 1/1: libconfig:x86-windows
[cmake] Building package libconfig[core]:x86-windows...
[cmake] Building package libconfig[core]:x86-windows... done
[cmake] Installing package libconfig[core]:x86-windows...
[cmake] Installing package libconfig[core]:x86-windows... done
[cmake] Elapsed time for package libconfig:x86-windows: 178.2 ms
...
[cmake] CMake Error at external/vcpkg/scripts/buildsystems/vcpkg.cmake:650 (_find_package):
[cmake]   Could not find a package configuration file provided by "libconfig" with any of
[cmake]   the following names:
[cmake]
[cmake]     libconfigConfig.cmake
[cmake]     libconfig-config.cmake
[cmake]
[cmake]   Add the installation prefix of "libconfig" to CMAKE_PREFIX_PATH or set "libconfig_DIR"
[cmake]   to a directory containing one of the above files.  If "libconfig" provides a
[cmake]   separate development package or SDK, be sure it has been installed.

@thschneider-lgn , Use the following code:
cmake_minimum_required(VERSION 3.0)
project(test)

add_executable(test CMakeProject22.cpp)

find_path(LIB_LIB_DIR libconfig.h)
find_library(LIB_LIB_LIBRARY NAMES libconfig)

target_include_directories(test PRIVATE ${LIB_LIB_DIR})
target_link_libraries(test PRIVATE ${LIB_LIB_LIBRARY})

having a similar issue in CLion.
CMakeLists.txt contains:
cmake_minimum_required(VERSION 2.6)
project(silver rod)

file(GLOB screen_sources "screens/*.c")

add_executable(${PROJECT_NAME} ${PROJECT_NAME}.c ${screen_sources})
if (NOT TARGET raylib)
    find_package(raylib 2.0 REQUIRED)
endif()
target_link_libraries(${PROJECT_NAME} raylib)

file(COPY "resources/"  DESTINATION "resources/")

when i try to reload CMakeList.txt:
"C:\Program Files\JetBrains\CLion 2020.3.1\bin\cmake\win\bin\cmake.exe" -DCMAKE_BUILD_TYPE=Debug -G "CodeBlocks - MinGW Makefiles" C:\Users\18432\Desktop\medoing\silver_rod
CMake Error: Could not find cmake module file: CMakeDeterminerodCompiler.cmake
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_rod_COMPILER_ENV_VAR
CMake Error: Error required internal CMake variable not set, cmake may not be built correctly.
Missing variable is:
CMAKE_rod_COMPILER
CMake Error: Could not find cmake module file: C:/Users/18432/Desktop/medoing/silver_rod/cmake-build-debug/CMakeFiles/3.17.5/CMakerodCompiler.cmake
CMake Error at CMakeLists.txt:2 (project):
  No CMAKE_rod_COMPILER could be found.

  Tell CMake where to find the compiler by setting the CMake cache entry
  CMAKE_rod_COMPILER to the full path to the compiler, or to the compiler
  name if it is in the PATH.

CMake Error: Could not find cmake module file: CMakerodInformation.cmake
CMake Error: CMAKE_rod_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
See also "C:/Users/18432/Desktop/medoing/silver_rod/cmake-build-debug/CMakeFiles/CMakeOutput.log".

[Failed to reload]

Hi @sme-ek  ,This issue is opened for libconfig. If the port involved in your question is not libconfig, please reopen an issue, thank you

@thschneider-lgn ，Has this problem been solved?


Compiling HTML5 with mods and lua enabled

Describe your problem here.
First off, does it work even?
If it does, I keep getting this error:
source/TitleState.hx:19: characters 8-22 : You cannot access the sys package while targeting js (for sys.FileSystem) source/Main.hx:32: characters 37-47 : ... referenced here
and for the life of me I can't figure out how to fix it
Are you modding a build from source or with Lua?
Source
What is your build target?
HTML5/Browser
Did you edit anything in this build? If so, mention or summarize your changes.
I edited the project.xml file to disable videos for web and enable mods and lua regardless.

psych engine isn't really made for html5

Describe your problem here.
First off, does it work even?

wait till shadowmario or someone brings up fixes

update:
so real quick status update.
Even in a fresh install of all the haxe shit and with an unmodified psych engine source build (besides the project file shit)
doesnt work either and gives the same errors.
i know for a fact that sys.io.file works just fine in openFL for html5, so im pretty sure that its just a janky build lmao

you can't

update:
so real quick status update.

Closed this because (as far as I can tell) it just isnt possible in haxe.


Linted paper scripts and notebooks

Summary by Sourcery
Lint and refactor paper scripts and notebooks to enhance code quality and maintainability, and add comprehensive documentation for the 'diverse-seq' application.
Enhancements:

Lint and refactor paper scripts and notebooks to improve code quality and maintainability.

Documentation:

Add comprehensive documentation for the 'diverse-seq' application, detailing its features, usage, and performance.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.892%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
1190

Relevant Lines:
1295

💛  - Coveralls


What is actual pytorch, cuda , mmdet,mmcv version used?

Since there are multiple version on which mmdet and mmcv works.
It would be cool if we can recreate exact environment used by this github.
Would you share the environment file?

This repo use mmdet==2.14.0
According to get_started.md, correct version of mmcv (for mmdet 2.14.0) are mmcv-full>=1.3.8, <1.4.0


Added New Generic Table View named BEKMultiCellTable

[ADD]
-Added new Component BEKMultiCellTable at the end of the TableView's list.
Project URL
https://github.com/behrad-kzm/BEKMultiCellTable
Category
Table View
Description
A generic table view based on MVVM that allows you to add multiple cell types at runtime to the table view in a single line of code.
Why it should be included to awesome-ios (mandatory)
This table view Cocoapod is unbelievably easy to use.
I used #generics and add multiple kinds of 'TableCell' to the 'TableView' without any extra codes.
Also, there is no need to implement the DataSource protocol.
Checklist

[ ] Has 50 GitHub stargazers or more
[x] Only one project/change is in this pull request
[x] Isn't an archived project
[ ] Has more than one contributor
[ ] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@behrad-kzm We cannot merge your PR yet until you fill all of the contribution guideline requirements. Feel free to open PR once it is ready.
Please check our CONTRIBUTION GUIDELINES

@vsouza Thanks for checking my repo. please tell me which parts of the guidelines are missed.

@behrad-kzm You can check our requirements in the CONTRIBUTION GUIDELINES.


ROX-11524: (Part 4/4) Migrate PermissionSet to remove AuthPlugins

Description

Migrate permission sets
Remove the AuthPlugins bucket

Extracted from #2507.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Automated tests.

Looking into the test failure:
pkg/grpc/authz/user/user.go:11:2: no required module provides package github.com/stackrox/rox/pkg/grpc/authz/internal/permissioncheck; to add it:
go get github.com/stackrox/rox/pkg/grpc/authz/internal/permissioncheck
Can you make sure the import is removed if it is not needed anymore ? I think the consumer code was removed in the previous PR.

@rhybrillou Fixed! Let's wait for CI


fix fix count(*) performance fallback in external table query

What problem does this PR solve?
Related PR: #41789
Problem Summary:
This PR #41789 change the local shuffle logic, but forget to implement numScanBackends()
in FileQueryScanNode, which causing select count(*) from hive_table query performance fallback.
This PR implement this method in FileQueryScanNode()
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[x] Manual test (the daily performance test covered this case)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


Multiple request at same time and smart config it's true

I had smart with true value in poller config and sometimes i see in browser request, 2 or 3 pending requests at the same time. When requests gives timeout , are again started.This should not be avoided with the option smart : true?
I need to change something to only send new request if the previous one is resolved?

Hi @vitornobrega
If you are using pollerConfig.smart = true; you really should not see multiple pending requests to the same resource at the same time. I'm guessing you have multiple pollers to different resources running at the same time.
smart flag only makes sure that new requests are sent after the previous on is resolved - and that could mean success or failure. If you want to handle the timeout case, you can take a look at https://github.com/emmaguo/angular-poller#error-handling.
Let me know if you have more questions.


Incorrect "exports" in package.json

Related to #30

First of all, thank you for a great package!
What
This library currently points to index.web.js for the import condition. That is incorrect. What ends up happening is that Node.js ESM (which resolves the import condition) tries to load the browser build of this package, resulting in a failure.

This package, basically, assumes that import is used only in the browser. Luckily, we can use ESM in Node.js now. I want to be able to use this package there too!

Proposal
Instead, provide environment-based export conditions to correctly distribute this package:
  "exports": {
    ".": {
      "types": "./index.d.ts",
-     "import": "./index.web.js",
+     "node": {
+       "import": "./index.node.mjs",
+       "require": "./index.node.js"
+     },
      "browser": "./index.browser.js",
      "require": "./index.node.js",
      "default": "./index.web.js"
    }
  },

Note that you can nest import/require/default/etc. export conditions inside an environment condition. We've been using that to a great effect in MSW for years now (ref).
Bundling
The node.import condition must points to an ESM build of this package for Node.js. If the said build target doesn't exist, let's add it.
Additional context
I am willing to open a pull request for this.

That sounds great.

It would be good to extend the test setup to cover this import case as part of that

Yeah, this is always tricky. I wish there was better tooling around module compatibility testing. We have an entire test setup designated just for that in MSW. It's actually great, just not reusable.

since the wasm-pack web target is explicitly intended for a browser ESM environment

This should still be okay as long as brotli-wasm doesn't rely on any browser APIs (which I believe it doesn't).


Include README.rst in doc/ files

Description of the modifications
https://github.com/ansys/openapi-common/blob/main/doc/source/index.rst and https://github.com/ansys/openapi-common/blob/main/README.rst share a significant amount of content, but this content is duplicated between the two. Additionally, there is content in the README.rst which does not appear in the HTML document, e.g.  the section on HTTP certificates
Useful links and references
No response

We have just done a new release for this, but we could do a post or a patch release to include this.


[Feature Request] Support setting registry file content from UI for k3d provider

Only the registry file-path can be set in k3d cluster creating UI page. We should support setting registry-file content like other providers.

Tested with v0.8.0-rc1. UI support config private registry content for K3d provider.


Gpuindexing

Still did not work on gadi

Wrapping the whole collect depth worked on gpu. Still need to try in on gadi but should have done it now so a depth can be found on GPU().


Reduce layout shift upon searching

Right now, the layout of the page shifts when you start searching. We should reduce that.

If it's okay with you, I would like to do this.


Add GA4 'filter' events to the analytics docs

What

Adds the filter events to the docs
Adds the focus loss tracker to the docs
Updates the .gitignore as it tries to add node_modules to your commits and .DS_Store if you've ever worked with images in this repo

Thanks @andysellick - should be ready for another review 👍


Add revision to GetReleaseHistory

Towards giantswarm/giantswarm#9900
See https://github.com/giantswarm/apiextensions/pull/400#issue-400886114.
Checklist

[ ] Update changelog in CHANGELOG.md.

Tested on giraffe.


fix #134: remember settings

No, I think what you implemented now is better. It allows storing default option on a project basis.
Thanks!


Playback Error

For Some reason I cannot get ffmpeg to work correctly. Keep getting this error no matter what I change or try. Also the webviewer  doesnt give this error but also just does nothing
2024-10-05T13:08:35.738Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321"}
error: {}
2024-10-05T13:08:35.739Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321"}
error: {}
2024-10-05T13:08:35.740Z [error]: Error playing video {"code":254,"cmd":"/usr/bin/ffmpeg -hide_banner -threads 4 -fflags +genpts+discardcorrupt+igndts -loglevel warning -readrate 1.0 -readrate_initial_burst 45 -ss 136.19 -i /TV Shows/Metalocalypse/Season 1/Metalocalypse - S01E01 - The Curse of Dethklok - [WEBRIP-1080P]-[AC3]-[2.0-Channel]-[X265]-[10Bit] -[X265].mkv -filter_complex [0:1]anull[audio];[audio]aresample=48000,aresample=async=1:first_pts=0,apad=whole_dur=555682ms[padded] -map 0:0 -c:v libx264 -b:v 10000k -maxrate:v 10000k -bufsize:v 1000k -sc_threshold 0 -video_track_timescale 90000 -map [padded] -flags cgop+ilme -b:a 192k -maxrate:a 192k -bufsize:a 50k -ac 2 -ar 48k -map_metadata -1 -movflags +faststart -muxdelay 0 -muxpreload 0 -fps_mode cfr -metadata service_provider="tunarr" -metadata service_name="Adult Swim" -t 555682ms -g 120 -keyint_min 120 -force_key_frames expr:gte(t,n_forced*2) -f hls -hls_time 4 -hls_list_size 0 -segment_list_flags +live -hls_flags program_date_time+omit_endlist+discont_start+append_list -hls_segment_type mpegts -hls_base_url /stream/channels/8be2d5f0-42fa-458d-86dd-6fba2c7cc321/hls/ -hls_segment_filename streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/data%05d.ts -master_pl_name master.m3u8 streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/stream.m3u8"}
2024-10-05T13:08:35.753Z [info]: Concat Wrapper FFMPEG exited. (signal=null, code=0, expected?=true) {"args":"-nostdin -threads 1 -hide_banner -loglevel warning -user_agent Ffmpeg Tunarr/0.12.3 -nostats -fflags +genpts+discardcorrupt+igndts -reconnect 1 -reconnect_at_eof 1 -readrate 1 -i http://localhost:8000/stream/channels/8be2d5f0-42fa-458d-86dd-6fba2c7cc321.m3u8?mode=hls -map 0 -c copy -f mpegts pipe:1"}
2024-10-05T13:08:37.091Z [error]: Bailing on stream start, had error! {"sessionId":"7be425b1-2455-48c4-8df9-96c15d5864d2","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
err: {
"type": "Error",
"message": "Error in underlying FFMPEG process: (code=254)",
"stack":
Error: Error in underlying FFMPEG process: (code=254)
at _FfmpegTranscodeSession. (file:///tunarr/server/build/bundle.js:271941:24)
at _FfmpegTranscodeSession.emit (node:events:531:35)
at _FfmpegProcess. (file:///tunarr/server/build/bundle.js:269015:12)
at _FfmpegProcess.emit (node:events:531:35)
at ChildProcess. (file:///tunarr/server/build/bundle.js:268953:14)
at ChildProcess.emit (node:events:519:28)
at ChildProcess._handle.onexit (node:internal/child_process:294:12)
at Process.callbackTrampoline (node:internal/async_hooks:130:17)

Sorry you're having trouble! Best thing to do for this type of issue is to turn on ffmpeg logging (under settings > ffmpeg). Change the log level to warning or info, try running the stream, and then paste the output here.

Thank you for the quick reply. This is what I get after updating the ff log
2024-10-05T13:21:20.929Z [info]: Searching for legacy dizquetv directory at /.dizquetv
2024-10-05T13:21:21.435Z [info]: XMLTV Updated at 10/5/2024, 1:21:21 PM
2024-10-05T13:21:21.461Z [info]: HTTP server listening on host:port: http://<IP_ADDRESS>:8000
2024-10-05T13:22:27.513Z [warn]: No underlying session of type hls found for existing concat session (channel id = 8be2d5f0-42fa-458d-86dd-6fba2c7cc321). Removing dangling session and recreating
2024-10-05T13:22:27.548Z [warn]: No last segment found {"sessionId":"4778291d-37c2-461a-a2bd-12d6a02f652c","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
[in#0 @ 0x556de8177880] Error opening input: Immediate exit requested
Error opening input file http://localhost:8000/stream/channels/8be2d5f0-42fa-458d-86dd-6fba2c7cc321.m3u8?mode=hls.
2024-10-05T13:22:57.460Z [info]: Concat Wrapper FFMPEG exited. (signal=null, code=0, expected?=true) {"args":"-nostdin -threads 1 -hide_banner -loglevel warning -user_agent Ffmpeg Tunarr/0.12.3 -nostats -fflags +genpts+discardcorrupt+igndts -reconnect 1 -reconnect_at_eof 1 -readrate 1 -i http://localhost:8000/stream/channels/8be2d5f0-42fa-458d-86dd-6fba2c7cc321.m3u8?mode=hls -map 0 -c copy -f mpegts pipe:1"}

I also made  another channel and tried that and seems like a slightly different error but same result.
2024-10-05T13:31:39.324Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"c79f4dc6-fa35-4cef-afa1-237620e2b85a"}
error: {}
2024-10-05T13:31:39.325Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"c79f4dc6-fa35-4cef-afa1-237620e2b85a"}
error: {}
2024-10-05T13:31:39.326Z [error]: Error playing video {"code":8,"cmd":"/usr/bin/ffmpeg -hide_banner -threads 4 -fflags +genpts+discardcorrupt+igndts -loglevel info -reconnect 1 -reconnect_on_network_error 1 -reconnect_streamed 1 -multiple_requests 1 -readrate 1.0 -readrate_initial_burst 45 -ss 159.002 -i https://192-168-1-13.f85e63350a2d4839be9686b04402aa13.plex.direct:32400/library/parts/84129/1630852156/file.mkv?X-Plex-Token=REDACTED -filter_complex [0:1]anull[audio];[audio]aresample=48000,aresample=async=1:first_pts=0,apad=whole_dur=1160326ms[padded] -map 0:0 -c:v libx264 -b:v 10000k -maxrate:v 10000k -bufsize:v 1000k -sc_threshold 0 -video_track_timescale 90000 -map [padded] -flags cgop+ilme -b:a 192k -maxrate:a 192k -bufsize:a 50k -ac 2 -ar 48k -map_metadata -1 -movflags +faststart -muxdelay 0 -muxpreload 0 -fps_mode cfr -metadata service_provider="tunarr" -metadata service_name="Channel 2" -t 1160326ms -g 96 -keyint_min 96 -force_key_frames expr:gte(t,n_forced*2) -f hls -hls_time 4 -hls_list_size 0 -segment_list_flags +live -hls_flags program_date_time+omit_endlist+discont_start+append_list -hls_segment_type mpegts -hls_base_url /stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a/hls/ -hls_segment_filename streams/stream_c79f4dc6-fa35-4cef-afa1-237620e2b85a/data%05d.ts -master_pl_name master.m3u8 streams/stream_c79f4dc6-fa35-4cef-afa1-237620e2b85a/stream.m3u8"}
[in#0 @ 0x55a427d11880] Error opening input: Immediate exit requested
Error opening input file http://localhost:8000/stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a.m3u8?mode=hls.
Exiting normally, received signal 15.
2024-10-05T13:31:39.341Z [info]: Concat Wrapper FFMPEG exited. (signal=null, code=0, expected?=true) {"args":"-nostdin -threads 1 -hide_banner -loglevel info -user_agent Ffmpeg Tunarr/0.12.3 -nostats -fflags +genpts+discardcorrupt+igndts -reconnect 1 -reconnect_at_eof 1 -readrate 1 -i http://localhost:8000/stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a.m3u8?mode=hls -map 0 -c copy -f mpegts pipe:1"}
Input #0, png_pipe, from 'http://localhost:8000/images/generic-error-screen.png':
Duration: N/A, bitrate: N/A
Stream #0:0: Video: png, rgba(pc, gbr/bt709/iec61966-2-1), 1920x1080 [SAR 2835:2835 DAR 16:9], 25 fps, 25 tbr, 25 tbn
[out#0/nut @ 0x55c83a35efc0] Codec AVOption sc_threshold (Scene change threshold) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream.
Stream mapping:
Stream #0:0 (png) -> format:default
realtime:default -> Stream #0:0 (rawvideo)
arealtime:default -> Stream #0:1 (flac)
Press [q] to stop, [?] for help
[flac @ 0x55c83a362540] encoding as 24 bits-per-sample, more is considered experimental. Add -strict experimental if you want to encode more than 24 bits-per-sample
Output #0, nut, to 'pipe:1':
Metadata:
service_provider: "tunarr"
service_name    : "Channel 2"
encoder         : Lavf61.1.100
Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p(unknown/bt709/iec61966-2-1, progressive), 1920x1080 [SAR 1:1 DAR 16:9], q=2-31, 597196 kb/s, 24 fps, 49152 tbn
Metadata:
encoder         : Lavc61.3.100 rawvideo
Stream #0:1: Audio: flac ([172][241][0][0] / 0xF1AC), 48000 Hz, mono, s32 (24 bit), 128 kb/s
Metadata:
encoder         : Lavc61.3.100 flac
2024-10-05T13:31:41.347Z [error]: Bailing on stream start, had error! {"sessionId":"4778291d-37c2-461a-a2bd-12d6a02f652c","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
err: {
"type": "Error",
"message": "Error in underlying FFMPEG process: (code=8)",
"stack":
Error: Error in underlying FFMPEG process: (code=8)
at _FfmpegTranscodeSession. (file:///tunarr/server/build/bundle.js:271941:24)
at _FfmpegTranscodeSession.emit (node:events:531:35)
at _FfmpegProcess. (file:///tunarr/server/build/bundle.js:269015:12)
at _FfmpegProcess.emit (node:events:531:35)
at ChildProcess. (file:///tunarr/server/build/bundle.js:268953:14)
at ChildProcess.emit (node:events:519:28)
at ChildProcess._handle.onexit (node:internal/child_process:294:12)
at Process.callbackTrampoline (node:internal/async_hooks:130:17)
}
2024-10-05T13:31:41.349Z [error]: Error starting stream after retrying {"sessionId":"4778291d-37c2-461a-a2bd-12d6a02f652c","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
err: {
"type": "Error",
"message": "Error in underlying FFMPEG process: (code=8)",
"stack":
Error: Error in underlying FFMPEG process: (code=8)
at _FfmpegTranscodeSession. (file:///tunarr/server/build/bundle.js:271941:24)
at _FfmpegTranscodeSession.emit (node:events:531:35)
at _FfmpegProcess. (file:///tunarr/server/build/bundle.js:269015:12)
at _FfmpegProcess.emit (node:events:531:35)
at ChildProcess. (file:///tunarr/server/build/bundle.js:268953:14)
at ChildProcess.emit (node:events:519:28)
at ChildProcess._handle.onexit (node:internal/child_process:294:12)
at Process.callbackTrampoline (node:internal/async_hooks:130:17)
}
2024-10-05T13:31:41.350Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"c79f4dc6-fa35-4cef-afa1-237620e2b85a"}
error: {}
frame=    3 fps=0.0 q=-0.0 size=       0KiB time=00:00:00.28 bitrate=  12.1kbits/s speed=0.00358x

Can you make sure you're posting the complete logs? In the 2nd comment it looks like the logs begin right after another failure.
There does seem like an issue with opening up an error stream that we pop up in the case the main ffmpeg process fails, but I think that is unrelated.

Sorry about that. It was snippets as I was worried the posts would be too long. Here's the full log from starting the container and attempting to play both channels:
2024-10-05T14:08:14.962Z [info]: Searching for legacy dizquetv directory at /.dizquetv
2024-10-05T14:08:15.596Z [info]: XMLTV Updated at 10/5/2024, 2:08:15 PM
2024-10-05T14:08:15.615Z [info]: HTTP server listening on host:port: http://<IP_ADDRESS>:8000
2024-10-05T14:08:49.304Z [warn]: No underlying session of type hls found for existing concat session (channel id = 8be2d5f0-42fa-458d-86dd-6fba2c7cc321). Removing dangling session and recreating
2024-10-05T14:08:49.338Z [warn]: No last segment found {"sessionId":"c7372594-19e3-4b5c-8bec-241cbdadf950","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
2024-10-05T14:08:52.364Z [info]: First stretch to 1440 x 1080. Then add padding to make it 1920 x 1080  {"channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321"}
Input #0, matroska,webm, from 'https://192-168-1-13.f85e63350a2d4839be9686b04402aa13.plex.direct:32400/library/parts/58579/1659085944/file.mkv?X-Plex-Token=JMFztUUg8zeGikenbpeq':
Metadata:
encoder         : libebml v1.4.2 + libmatroska v1.6.4
Duration: 00:11:28.96, start: 0.000000, bitrate: 8612 kb/s
Stream #0:0(eng): Video: h264, yuv420p(tv, bt709, progressive), 1440x1080 [SAR 1:1 DAR 4:3], 29.97 fps, 29.97 tbr, 1k tbn (default) (original)
Metadata:
BPS             : 8226674
DURATION        : 00:11:28.921000000
NUMBER_OF_FRAMES: 20647
NUMBER_OF_BYTES : 708441097
_STATISTICS_WRITING_APP: mkvmerge v66.0.0 ('Josie') 64-bit
_STATISTICS_WRITING_DATE_UTC: 2022-07-28 09:21:08
_STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
Stream #0:1(eng): Audio: ac3, 48000 Hz, stereo, fltp, 384 kb/s (default) (original)
Metadata:
title           : English
BPS             : 384000
DURATION        : 00:11:28.960000000
NUMBER_OF_FRAMES: 21530
NUMBER_OF_BYTES : 33070080
_STATISTICS_WRITING_APP: mkvmerge v66.0.0 ('Josie') 64-bit
_STATISTICS_WRITING_DATE_UTC: 2022-07-28 09:21:08
_STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
Stream #0:2(eng): Subtitle: subrip (srt) (original)
Metadata:
title           : English
BPS             : 191
DURATION        : 00:11:15.341000000
NUMBER_OF_FRAMES: 305
NUMBER_OF_BYTES : 16187
_STATISTICS_WRITING_APP: mkvmerge v66.0.0 ('Josie') 64-bit
_STATISTICS_WRITING_DATE_UTC: 2022-07-28 09:21:08
_STATISTICS_TAGS: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
Stream mapping:
Stream #0:0 (h264) -> null:default
Stream #0:1 (ac3) -> anull:default
format:default -> Stream #0:0 (libx264)
apad:default -> Stream #0:1 (aac)
Press [q] to stop, [?] for help
[libx264 @ 0x555915e58440] using SAR=1/1
[libx264 @ 0x555915e58440] using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX FMA3 BMI2 AVX2 AVX512
[libx264 @ 0x555915e58440] profile High, level 4.0, 4:2:0, 8-bit
Output #0, hls, to 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/stream.m3u8':
Metadata:
service_provider: "tunarr"
service_name    : "Adult Swim"
encoder         : Lavf61.1.100
Stream #0:0: Video: h264, yuv420p(tv, bt709, progressive), 1920x1080 [SAR 1:1 DAR 16:9], q=2-31, 10000 kb/s, 29.97 fps, 90k tbn
Metadata:
encoder         : Lavc61.3.100 libx264
Side data:
cpb: bitrate max/min/avg: 10000000/0/10000000 buffer size: 1000000 vbv_delay: N/A
Stream #0:1: Audio: aac, 48000 Hz, stereo, fltp, 192 kb/s
Metadata:
encoder         : Lavc61.3.100 aac
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/data00000.ts' for writing
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/stream.m3u8.tmp' for writing
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/master.m3u8' for writing
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/data00001.ts' for writing
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/stream.m3u8.tmp' for writing
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/data00002.ts' for writing
[hls @ 0x555915e6a300] Opening 'streams/stream_8be2d5f0-42fa-458d-86dd-6fba2c7cc321/stream.m3u8.tmp' for writing
[in#0 @ 0x55e374b48880] Error opening input: Immediate exit requested
Error opening input file http://localhost:8000/stream/channels/8be2d5f0-42fa-458d-86dd-6fba2c7cc321.m3u8?mode=hls.
 Shutting down {"sessionType":"hls","channelId":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321"}
error: {}
2024-10-05T14:10:10.888Z [warn]: No underlying session of type hls found for existing concat session (channel id = c79f4dc6-fa35-4cef-afa1-237620e2b85a). Removing dangling session and recreating
2024-10-05T14:10:10.931Z [warn]: No last segment found {"sessionId":"c7372594-19e3-4b5c-8bec-241cbdadf950","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
[https @ 0x55a10174c3c0] HTTP error 400 Bad Request
[in#0 @ 0x55a10174bb80] Error opening input: Server returned 400 Bad Request
Error opening input file https://192-168-1-13.f85e63350a2d4839be9686b04402aa13.plex.direct:32400/library/parts/84130/1630852155/file.mkv?X-Plex-Token=JMFztUUg8zeGikenbpeq.
Error opening input files: Server returned 400 Bad Request
2024-10-05T14:10:17.144Z [info]: Raw Stream FFMPEG exited. (signal=null, code=8, expected?=false) {"args":"-hide_banner -threads 4 -fflags +genpts+discardcorrupt+igndts -loglevel info -reconnect 1 -reconnect_on_network_error 1 -reconnect_streamed 1 -multiple_requests 1 -readrate 1.0 -readrate_initial_burst 45 -ss 1154.603 -i https://192-168-1-13.f85e63350a2d4839be9686b04402aa13.plex.direct:32400/library/parts/84130/1630852155/file.mkv?X-Plex-Token=REDACTED -filter_complex [0:1]anull[audio];[audio]aresample=48000,aresample=async=1:first_pts=0,apad=whole_dur=131691ms[padded] -map 0:0 -c:v libx264 -b:v 10000k -maxrate:v 10000k -bufsize:v 1000k -sc_threshold 0 -video_track_timescale 90000 -map [padded] -flags cgop+ilme -b:a 192k -maxrate:a 192k -bufsize:a 50k -ac 2 -ar 48k -map_metadata -1 -movflags +faststart -muxdelay 0 -muxpreload 0 -fps_mode cfr -metadata service_provider="tunarr" -metadata service_name="Channel 2" -t 131691ms -g 96 -keyint_min 96 -force_key_frames expr:gte(t,n_forced2) -f hls -hls_time 4 -hls_list_size 0 -segment_list_flags +live -hls_flags program_date_time+omit_endlist+discont_start+append_list -hls_segment_type mpegts -hls_base_url /stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a/hls/ -hls_segment_filename streams/stream_c79f4dc6-fa35-4cef-afa1-237620e2b85a/data%05d.ts -master_pl_name master.m3u8 streams/stream_c79f4dc6-fa35-4cef-afa1-237620e2b85a/stream.m3u8"}
[in#0 @ 0x55f1dd7fb880] Error opening input: Immediate exit requested
2024-10-05T14:10:17.145Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"c79f4dc6-fa35-4cef-afa1-237620e2b85a"}Error opening input file http://localhost:8000/stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a.m3u8?mode=hls.
Exiting normally, received signal 15.
error: {}
2024-10-05T14:10:17.146Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"c79f4dc6-fa35-4cef-afa1-237620e2b85a"}
error: {}
2024-10-05T14:10:17.147Z [error]: Error playing video {"code":8,"cmd":"/usr/bin/ffmpeg -hide_banner -threads 4 -fflags +genpts+discardcorrupt+igndts -loglevel info -reconnect 1 -reconnect_on_network_error 1 -reconnect_streamed 1 -multiple_requests 1 -readrate 1.0 -readrate_initial_burst 45 -ss 1154.603 -i https://192-168-1-13.f85e63350a2d4839be9686b04402aa13.plex.direct:32400/library/parts/84130/1630852155/file.mkv?X-Plex-Token=REDACTED -filter_complex [0:1]anull[audio];[audio]aresample=48000,aresample=async=1:first_pts=0,apad=whole_dur=131691ms[padded] -map 0:0 -c:v libx264 -b:v 10000k -maxrate:v 10000k -bufsize:v 1000k -sc_threshold 0 -video_track_timescale 90000 -map [padded] -flags cgop+ilme -b:a 192k -maxrate:a 192k -bufsize:a 50k -ac 2 -ar 48k -map_metadata -1 -movflags +faststart -muxdelay 0 -muxpreload 0 -fps_mode cfr -metadata service_provider="tunarr" -metadata service_name="Channel 2" -t 131691ms -g 96 -keyint_min 96 -force_key_frames expr:gte(t,n_forced*2) -f hls -hls_time 4 -hls_list_size 0 -segment_list_flags +live -hls_flags program_date_time+omit_endlist+discont_start+append_list -hls_segment_type mpegts -hls_base_url /stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a/hls/ -hls_segment_filename streams/stream_c79f4dc6-fa35-4cef-afa1-237620e2b85a/data%05d.ts -master_pl_name master.m3u8 streams/stream_c79f4dc6-fa35-4cef-afa1-237620e2b85a/stream.m3u8"}
2024-10-05T14:10:17.160Z [info]: Concat Wrapper FFMPEG exited. (signal=null, code=0, expected?=true) {"args":"-nostdin -threads 1 -hide_banner -loglevel info -user_agent Ffmpeg Tunarr/0.12.3 -nostats -fflags +genpts+discardcorrupt+igndts -reconnect 1 -reconnect_at_eof 1 -readrate 1 -i http://localhost:8000/stream/channels/c79f4dc6-fa35-4cef-afa1-237620e2b85a.m3u8?mode=hls -map 0 -c copy -f mpegts pipe:1"}
Input #0, png_pipe, from 'http://localhost:8000/images/generic-error-screen.png':
Duration: N/A, bitrate: N/A
Stream #0:0: Video: png, rgba(pc, gbr/bt709/iec61966-2-1), 1920x1080 [SAR 2835:2835 DAR 16:9], 25 fps, 25 tbr, 25 tbn
[out#0/nut @ 0x5617451d2fc0] Codec AVOption sc_threshold (Scene change threshold) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some encoder which was not actually used for any stream.
Stream mapping:
Stream #0:0 (png) -> format:default
realtime:default -> Stream #0:0 (rawvideo)
arealtime:default -> Stream #0:1 (flac)
Press [q] to stop, [?] for help
[flac @ 0x5617451d6540] encoding as 24 bits-per-sample, more is considered experimental. Add -strict experimental if you want to encode more than 24 bits-per-sample
Output #0, nut, to 'pipe:1':
Metadata:
service_provider: "tunarr"
service_name    : "Channel 2"
encoder         : Lavf61.1.100
Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p(unknown/bt709/iec61966-2-1, progressive), 1920x1080 [SAR 1:1 DAR 16:9], q=2-31, 597196 kb/s, 24 fps, 49152 tbn
Metadata:
encoder         : Lavc61.3.100 rawvideo
Stream #0:1: Audio: flac ([172][241][0][0] / 0xF1AC), 48000 Hz, mono, s32 (24 bit), 128 kb/s
Metadata:
encoder         : Lavc61.3.100 flac
2024-10-05T14:10:19.756Z [error]: Bailing on stream start, had error! {"sessionId":"c7372594-19e3-4b5c-8bec-241cbdadf950","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
err: {
"type": "Error",
"message": "Error in underlying FFMPEG process: (code=8)",
"stack":
Error: Error in underlying FFMPEG process: (code=8)
at _FfmpegTranscodeSession. (file:///tunarr/server/build/bundle.js:271941:24)
at _FfmpegTranscodeSession.emit (node:events:531:35)
at _FfmpegProcess. (file:///tunarr/server/build/bundle.js:269015:12)
at _FfmpegProcess.emit (node:events:531:35)
at ChildProcess. (file:///tunarr/server/build/bundle.js:268953:14)
at ChildProcess.emit (node:events:519:28)
at ChildProcess._handle.onexit (node:internal/child_process:294:12)
at Process.callbackTrampoline (node:internal/async_hooks:130:17)
}
2024-10-05T14:10:19.759Z [error]: Error starting stream after retrying {"sessionId":"c7372594-19e3-4b5c-8bec-241cbdadf950","channel":"8be2d5f0-42fa-458d-86dd-6fba2c7cc321","sessionType":"hls"}
err: {
"type": "Error",
"message": "Error in underlying FFMPEG process: (code=8)",
"stack":
Error: Error in underlying FFMPEG process: (code=8)
at _FfmpegTranscodeSession. (file:///tunarr/server/build/bundle.js:271941:24)
at _FfmpegTranscodeSession.emit (node:events:531:35)
at _FfmpegProcess. (file:///tunarr/server/build/bundle.js:269015:12)
at _FfmpegProcess.emit (node:events:531:35)
at ChildProcess. (file:///tunarr/server/build/bundle.js:268953:14)
at ChildProcess.emit (node:events:519:28)
at ChildProcess._handle.onexit (node:internal/child_process:294:12)
at Process.callbackTrampoline (node:internal/async_hooks:130:17)
}
2024-10-05T14:10:19.761Z [error]: Received error from session. Shutting down {"sessionType":"hls","channelId":"c79f4dc6-fa35-4cef-afa1-237620e2b85a"}
error: {}

Interesting. It looks like the the underlying error is a request error from your Plex server for some reason...

https @ 0x55a10174c3c0] HTTP error 400 Bad Request
[in#0 @ 0x55a10174bb80] Error opening input: Server returned 400 Bad Request
Error opening input file https://192-168-1-13.f85e63350a2d4839be9686b04402aa13.plex.direct:32400/library/parts/84130/1630852155/file.mkv?X-Plex-Token=REDACTED.
Error opening input files: Server returned 400 Bad Request

Strange...After reading your comment I tried plex on another device and it works on there... Curious to what the issue is when trying to view it through the plex container

Hmmm.. that's interesting. Perhaps there is an issue of network communication between the containerized Plex + Tunarr.

@Liquidbings wondering if this is still an issue for you?

Please lmk if this is still an issue we can reopen and investigate !

Sorry just getting back to this. But it is still an issue. I have yet to get this working for some odd reason. I've tried several others and all of them work but not well. I have high hopes for this ones I just need to figure out why it wont work lol.

Hey thanks for the update. It's been months and the code changed substantially since the original issue was opened. I think we'll need some new logs and details in order to debug further.


Changed the CI and the example folders to use new repo name

Not including:

example readme files
docs

These will be added in separate PR's due to the size of this PR.

/hold
This is WIP. Changed from "ocm" to "redhatcs". If accepted - we should also update the examples and ci.

/approve

/retest

/retest-required

/retest

/retest

/retest-required

/test unmanaged-oidc-config-e2e-presubmit

/retest

/unhold


Question: is tensorflow-lite 2.12.0 supported under dunfell?

While looking through the repository, I was not able to find any support matrix for the embedded version and the TFLite version. So, I was wondering if it is possible to support TFLite under dunfell, because that is what I need. If this is not explicitly unsupported, I'm happy to contribute.

The versions supported by dunfell are as follows.

https://github.com/NobuoTsukamoto/meta-tensorflow-lite/tree/dunfell/recipes-framework/tensorflow-lite

2.3.4
2.4.4
2.5.3
2.6.5
2.7.4
2.8.4

To maintain compatibility, all other than revisions are fixed. For this reason, dunfell does not plan to support versions 2.9 or higher. It may be possible to change LAYERSERIES_COMPAT_meta-tensorflow-lite from mickledore to dunfell, but I have not done so.
I think a version support matrix is a good idea. It's necessary for the README.

@BMMevius -san
I've added the supported versions to the README.
If you need anything else, please send me a pull request.


{AKS} add support to create cluster with kube-proxy configuration

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

AKS

Please the lint issues scanned by CI.
Also need to rebase from main (including this change) to fix failures in Integration Tests, Build Tests....

Rebased with main.
Locally I see some lint issue but they are not related to any of my changes from what I can tell, I think main just has lint issues in it?

/azp run

Please the lint issues scanned by CI.
Also need to rebase from main (including this change) to fix failures in Integration Tests, Build Tests....

Rebased with main.
Locally I see some lint issue but they are not related to any of my changes from what I can tell, I think main just has lint issues in it?

Yeah, if the CI could pass, that would be fine.

Azure.azure-cli-extensions (CLI Linter on Modified Extensions)

azure-cli-extensions (CLI Linter on Modified Extensions)  would be the relevant CI here, right? That seems to pass. If there is any other changes needed, please let me know.

Hey @mattstam, there are some errors in Azure.azure-cli-extensions (Static Analysis) need to be fixed.

/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:92:1: E302 expected 2 blank lines, found 1
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:397:1: W293 blank line contains whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:2392:45: E221 multiple spaces before operator

Besides, there's another NRP API version update in official CLI, which leads to the errors in Integration Tests, Build Tests..., fixing this in PR .


Update of Polish translation

In this pull request I translated the one new line from commit 7a2c6241c0c6889ea3db24f7fe4786a7772307ea.

🤔


fix: articles/hdinsight/kafka/apache-kafka-connector-iot-hub.md

Replace "text" language blocks with specific language formats

@nschonni : Thanks for your contribution! The author, @hrasheed-msft, has been notified to review your proposed change.

#sign-off

@JasonWHowell: I'm sorry - only the author of this article, @hrasheed-msft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Thanks for the signoff, @JasonWHowell! I'll merge this now.


Fix changelog for 3.0.1 release; add 3.0.2

Description of the change
A 3.0.1 tag was made, so when the 3.0.1 GH release was made for #27, the old tag was used rather than the current point of main. This updates the changelog and preps a 3.0.2 release.

Checklist:

[ ] Added the change to the changelog's "Unreleased" section with a link to this PR and your username
[ ] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation in the README and/or documentation directory
[ ] Added a test for the contribution (if applicable)

CC @thomashoneyman

This is already updated in the CHANGELOG.md


Youtube caption corrections

This PR adds a new dataset of YouTube captions, error and corrections. This dataset was created in just the last week, as inspired by this sprint!

Sorry about forgetting flake8.
Rather than use up the circleci resources on a new push with only formatting changes, I will wait to push until the results from all tests finish and/or any feedback comes in... probably tomorrow for me.

So... my normal work is with mercurial and seem to have clearly forked this up using git... :(
What I did is after calling:
git fetch upstream
git rebase upstream/master

I then I attempt to pull in my most recent changes UI commit changes based on @lhoestq's feedback with:
git pull

... which I now suspect undid the above fetch and rebase. Will look into fixing later today when I have more time. Sorry!

My dummy data seems quite large as a single row is composed of tokens/labels for an entire youtube video, with at least one row required for each file, which in this case 1 file per 13 youtube channels.
To make it smaller I passed --n_lines 1 to reduce about 5x.
I then manually reduced size of the particularly long youtube lectures to get the size to about 30KB. However, after recompressing into a zip, and running dummy data test I got the following error:
FAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_youtube_caption_corrections - OSError: Cannot find data file. , despite file being there, which I haven't had a chance yet to debug.

I wrote a small script to generate a smaller json file for the dummy_data, with the hope that I could resolve the pytest error noted above (in case related to a manual typo I could have introduce), however the test contains to fail locally... here's to hoping it can pass on remote!

Sorry for delayed comments here. Last commit made two changes:

Increased the valency of the labels from just True/False to more categories to describe the various types of diffs encountered. This required some rewrite of the README
Reduced the number of remote files to be downloaded from 13 to 4, by combining all 13 of the channel-specific files together, and the splitting them up in a way to meet Github file size requirements. This also reduces size of the dummy-data.

@lhoestq, thank you for the great feedback, especially given how busy you guys are now!
I checked out GitHub release tags and looks cool. I have added the version tag to the url, instead of the commit sha as originally suggested, with the hope that it serves the same purpose of pinning the content to this url. Please let me know if I have misunderstood.
In regard to dynamically changing the number of files downloaded by first downloading a JSON listing the files, I love that idea. But I am a little confused, as I was thinking that any changes to the dataset itself would require a new PR with an updated dataset_infos.json, e.g. num_examples would increase.
If the purpose of this is not to permit dynamic (without a PR needed) growth of the number of files, but instead to provide stability to the consumers of the dataset, maybe I continued use the release tags, maintaining access to old releases could serve this purpose? I am still learning about these release tags...

For dynamic datasets, i.e. datasets that evolve over time, we support custom configurations: they are configurations that are not part of the BUILDER_CONFIGS or in the dataset_infos.json
For example for wikipedia, you can use the latest wiki dump by specifying date= inside load_dataset(). A configuration is created on the fly for this date and is used to build the dataset using the latest data.
Therefore we don't need to have PRs to update the script for each wikipedia release.
One downside though is that we don't have metadata in advance such as the size of the dataset.
I think this could be a nice addition for the youtube caption dataset in the future to be have a system of releases and be able to load the latest one easily. What do you think ?

For dynamic datasets, i.e. datasets that evolve over time, we support custom configurations: they are configurations that are not part of the BUILDER_CONFIGS or in the dataset_infos.json

I think this could be a nice addition for the youtube caption dataset in the future to be have a system of releases and be able to load the version we want easily. What do you think ?

Thank you for the suggestion! This sounds great! I will take a look at the some datasets that do this, and would love to give it a try in the future, if I continue to grow the captions dataset in a meaningful way.
Appreciate all the help on this. It has been a really great experience for me. :)

Excited to merge! And sorry to be such a github n00b, but from what I've quickly read, I don't 'Close pull request', but rather the next steps are action taken on your end... Please let me know if there is some action to be taken at my end first. :/

Alright merging this one then :)


Incorrect rendering of shading pattern +  stencil

Attach (recommended) or Link to PDF file here:
PATTYP2.pdf
Configuration:

Web browser and its version: FF 88.0.1
Operating system and its version: W10.0.19042.985
PDF.js version: https://mozilla.github.io/pdf.js/web/viewer.html

Steps to reproduce the problem:

open file to display

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

(memo for me: when fixed, check the files in https://issues.apache.org/jira/browse/PDFBOX-1958 )

When we paint the image mask object we create the fill gradient with the size and transform of the image instead of the entire page. I'm seeing a similar issue in #11050, but that one is related to a grouped smask. To fix we'll either need to create the gradient with the original size/transform or transform the gradient so it translates and scales to the correct offset. It will probably be better to translate/scale, since then we draw the gradient on the smaller clipped canvas.


Solves issue #170: HTTP Header parsing is inconsistent

This push request solves issue #170 by moving the code from Response::_parseCode to Response\Headers::fromString.

How should I handle the lower case problem?

Hi there.
How should I handle the lower case problem?

I removed the lower case code and reverted the test

I just fixed all the issues. Headers remain as entered.

Is there any intereset oin this pull request by upstream?

Absolutely.


feat!: update core and opentracing to v1

BREAKING CHANGE: update core and opentracing to v1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0%) to 82.979%

Totals

Change from base Build 760429843:
-0.0%

Covered Lines:
39

Relevant Lines:
47

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0%) to 82.979%

Totals

Change from base Build 760429843:
-0.0%

Covered Lines:
39

Relevant Lines:
47

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


basic demo of using the self hosted DB client

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


 Latest version at the time
Description of the bug
HeadsPlus can't detect vault
To Reproduce
Steps to reproduce the behavior:

Start server

Have you been able to reproduce the bug more than once?
Every time I start the server
Expected behavior
I expect it to hook up  to vault, so I can use /sellhead
Screenshots

Has a debug report been generated?
https://pastebin.com/EU3ZRcM4
Required information

Server version: git-Paper-124 (MC: 1.14.3)
HeadsPlus version: 6.5.1
Whether or not the plugin uses MySQL: no, it does not
Server type (e.g Spigot, Paper): Paper
Uses Vault: can't really tell, it can't detect vault

Additional information
I'm using the latest version of vault (1.7.2-b107)
HeadsPlus config file is default (no changes, as generated)
Latest log from console: https://pastebin.com/9BuGeHrJ

Please do /vault-info. If Economy comes up as null, that means there is no economy plugin which HeadsPlus can actually use. Examples of economy plugins include Essentials and DKCoins.

Thank you, with economy installed everything works fine. May I suggest changing the WARN message from "Vault not found!" to "Vault and/or economy not found!"? It may clear things up for others.

Probably would be a good idea if it wasn’t for the fact I’d have to do some locale changes (which I absolutely hate to mess around with), but will make changes regardless.

I know it's the wrong place to ask but do you want a polish translation for headsplus? I could help if you want.

You sure can, here's an idea of how to do so:

Fork the repository, so that you can make changes easily and so that you'd be able to make a pull request to directly push the changes.
The file in question which I'd prefer you editing is this one: https://github.com/Thatsmusic99/HeadsPlus/blob/master/MAIN/src/main/java/io/github/thatsmusic99/headsplus/locale/pl_pl.java
(You can edit messages.yml instead though if you're more comfortable with it, and can send it to me directly via Pastebin or similar).
The English translations which you can use are here: https://github.com/Thatsmusic99/HeadsPlus/blob/master/MAIN/src/main/java/io/github/thatsmusic99/headsplus/locale/en_uk.java

Although it's only if you definitely want to, and you don't have a time limit on it either, especially considering I'm unable to make online payments so literally volunteering is a godsend to me. Any questions you have, feel free to ask and I'll answer whilst I can. Thanks again!

I have finished with translating (I used the fork method). Can I send it to my friend so he can check for mistakes and correct what's wrong?

Of course, I have no problem with it!

I made a pull request with all lines translated


FEATURE ADD : Derived keys, Serialization of Secret Keys

Hey I added a function that allows the user to derive a key from a seed in addition to serializing and storing the secret key as a file.

I'm trying to fix a bug in it. It passed all the test cases but when I added the forked repository as a cargo package into another project I ran into some issues. So I'm just trying to iron those out, once that's done I'll create a new PR

Thanks a lot for the comments I'll try to get through it by tomorrow and reopen this PR with them

I'll close this; feel free to reopen if you eventually want to merge something like that.


failOnError: true, won't work, build doesn't fail on error.

const path = require('path');
const WebpackShellPlugin = require('webpack-shell-plugin');
const webpack = require('webpack');
const WebpackNotifierPlugin = require('webpack-notifier');
const UnminifiedWebpackPlugin = require('unminified-webpack-plugin');

const minimize = process.argv.indexOf('--mini') !== -1;
const lint = process.argv.indexOf('--lint') !== -1;
const notify = process.argv.indexOf('--notify') !== -1;
const updateBimServiceSDK = process.argv.indexOf('--sdk') !== -1;

const plugins = [];
const preLoaders = [];

preLoaders.push({
  test: /\.js$/,
  exclude: /(node_modules|.babelrc)/,
  loader: 'babel',
  query: {
    presets: ['es2015-nostrict', 'stage-3'],
    plugins: [
      'transform-runtime',
      'transform-async-to-generator',
      'transform-regenerator',
      'syntax-async-functions',
    ],
    babelrc: false,
    comments: false,
  },
});

if (notify) {
  plugins.push(new WebpackNotifierPlugin({ alwaysNotify: true, }));
}

if (lint) {
  preLoaders.push({
    test: /\.js$/, // include .js files
    exclude: /(node_modules|vendor|BimService)/,
    loader: 'eslint-loader',
  });
}

plugins.push(new webpack.optimize.LimitChunkCountPlugin({ maxChunks: 1 }));
plugins.push(new UnminifiedWebpackPlugin());

const config = {
  entry: ['babel-polyfill', path.resolve(__dirname, 'src/index.js')],
  output: {
    path: path.resolve(__dirname, 'build'),
    filename: minimize ? 'SDK.min.js' : 'SDK.js',
    sourceMapFilenname: '[file].map',
  },
  module: {
    preLoaders,
    loaders: [{
      test: /\.css/,
      loader: 'css',
    }, {
      test: /\.png/,
      loader: 'base64-image-loader',
    }, {
      test: /\.json$/,
      loaders: ['json'],
    }, ],
  },
  plugins,
  eslint: {
    formatter: require('eslint-friendly-formatter'),
    failOnError: true,
    configFile: './.eslintrc.js',
  },
  devtool: 'source-map',
  node: {
    fs: 'empty',
  },
};

module.exports = config;

Please provide a better explanation, I don't have time to try to understand your problem. Feel free to make a PR with a failing test.

@yqrashawn I had this same issue, and what fixed it for me was updating my webpack config to include the following:
const config = {
  bail: true,
  cache: false,
  entry: ...
}

Also, maybe run webpack with the --bail flag: webpack --bail, and maybe raise your eslint error options to emitError: true

Closing to due to lack of feedback.


Update to version <IP_ADDRESS> in preparation for HybridApp

Details

Updates version to <IP_ADDRESS> in order to start matching the New and Old apps version for HybridApp deploy. This solves the problem of having OldDot pick a wrong version, and helps us track down bugs between Old and New apps.
Fixed Issues

$ https://github.com/Expensify/App/issues/43185
Tests

Verified version is <IP_ADDRESS> when building locally

QA Steps

Verify version is at least <IP_ADDRESS> on all platforms

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@AndrewGable 👋 Does this actually require my C+ review ?

If you want to review, feel free! It should be really easy to confirm <IP_ADDRESS> on all platforms.

This PR is going to have a ton of conflicts, so feel free to review then I will quickly resolve merge conflicts and then we can merge in one go.

@ikevin127 no C+ review needed here imo, just a version bump

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.0-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.0-9 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Avoid traceback when exception is del-ed in except

Fixes a regression introduced by
2a698f87c02a43d4489e30481e9def14ed4b4431.
This would fail with a KeyError:
try:
pass
except Exception as e:
del e
Fixes lp:1578903

:+1:
I've been testing with an if block instead of a try except, as I cant see how we might benefit from a try except.
but both fix the bug.

:+1:


apple-cursor: init at 1.2.3

Description of changes
Adds https://github.com/ful1e5/apple_cursor.
This theme seems to have most/all cursor icons, which is nice, it quiets some noise in my sway log, for example.
Review Considerations:

apple-cursor vs apple_cursor for the nixpkgs attr name

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg test

@ofborg eval

@ofborg eval

Result of nixpkgs-review pr 171300 run on x86_64-linux 1

1 package built:

apple-cursor

I could be wrong but it seems like my cursor is rendering rather small after bumping this up to 2.0.0:  https://github.com/ful1e5/apple_cursor/issues/92


Web App Creation issue

We have given task as -
Create the App service plan where pricing tier is strictly recommended for a Production environment but takes the minimum cost.
for this we used code as but not sure how we add prod environment strickly.
az appservice plan create -g user-jeyhyrrhkgrc -n MyPlan --sku F1
Create two Web Apps using the app service plan created in the last step.
For this trying as -
az webapp config set -g user-jeyhyrrhkgrc -n myweb --always-on true --subscription 23c7f465-e27b-418b-b8a7-21616582f9bb
it showing my web not exit, so we did as-
az configure --defaults web=myweb
Still not working. Hence please suggest us.

route to service team

we resolved the issue with help of https://github.com/Azure-Samples/azure-cli-samples/blob/master/app-service/deploy-deployment-slot/deploy-deployment-slot.sh
thanks


Add k8s ingress discovery

Depends on https://github.com/prometheus/prometheus/pull/3111

based it against next-released and change tls to TLS.

:+1:


not getting code assistance

After installing thymeleaf in my STS ide I am not getting the code assistance.

Is the Thymeleaf nature enabled (Right-click on the project>Configure>Add Thymeleaf Nature or Right click on the project>Thymeleaf>Add Thymeleaf Nature)?

This plugin was made for the Eclipse WebTools HTML Editor, which hasn't been the default HTML editor in the Spring Tool Suite for quite some time (I'm not even sure if it's packaged w/ STS any more).  I've updated the note in the readme so that this is hopefully clearer, including a note to check what editor is being used in HTML files.


Setup tests

[ ] check results against existing pipelines from researchers
[ ] check SI, CatGT, IBL against each-other

Reconfigure tests so they do not share output paths such that they can be parallelised with pytest-xdist or pytest-parallel

Do a confidence check that the last dict entry of PreprocessData get_traces() is the same data as written in the preprocessed output binary folder.

full backwards compatibility tests

at least one sanity check test that the sorting output matches some canonical data

Save test data on datalad so at least non-kilosort sorters can be tested on CI.

Still need to test:
    # ----------------------------------------------------------------------------------
    # Not Implemented
    # ----------------------------------------------------------------------------------

    def test_sorting_only_local(self):
        raise NotImplementedError

    def test_sorting_only_slurm(self):
        raise NotImplementedError

    def test_postprocessing_only_local(self):
        raise NotImplementedError

    def test_postprocessing_only_slurm(self):
        raise NotImplementedError

    def test_preprocessing_only_local(self):
        raise NotImplementedError

    def test_preproecssing_only_slurm(self):
        raise NotImplementedError

    def test_configs(self):
        # not really sure how to do this...
        raise NotImplementedError

    def test_reordering_sessions_and_runs(self):
        raise NotImplementedError

    def test_select_postprocessing_to_run(self):
        raise NotImplementedError

    def test_delete_intermediate_files(self):
        raise NotImplementedError

    def test_slurm_options(self):
        raise NotImplementedError


Not able to read dilithium private key using PEM_read_bio_PrivateKey routine

I was trying to read the private key generated using dilithium with "PEM_read_bio_PrivateKey" routine but it's returning null ptr. On adding error routines to check what went wrong, we got the following output:
ERR_peek_last_error() => 50331766
ERR_error_string(ERR_get_error(), NULL) => error:1E08010C:DECODER routines::unsupported
Kindly help with how we can achieve the same for PQC signature algorithms. Thanks in advance!

I'm afraid I don't have the bandwidth to recreate your setup manually. Just looking at the error message, I'd guess that oqsprovider is not active thus leading to an "unsupported" output. Conceptually, it should work as these APIs are used in the more high level (private key en/decoding) tests we have for oqsprovider.
My recommendation is you debug into the calls into the openssl code to find out why/where NULL is returned. Another proposal is to raise the question in the openssl community as this is not an API maintained within oqsprovider.

@aniket-rulez could you please check that oqsprovider is loaded?

Closing without further input received. Assuming issue is resolved when oqsprovider is correctly loaded. @aniket-rulez please re-open if you have further news to report.

Hi @baentsch and @beldmit, thanks for your inputs! The oqsprovider was not being loaded correctly and after the load, the issue was resolved.


Broken link to Eclipse Marketplace in README.md

The link for IBM Monitoring and Diagnostics Tools - Health Center client in the first section of README.md is broken. It has extraneous "**" on the end of the link.

Fixed by PR #27


Authentication Provider Command Does Not Work With Dependencies

Describe the bug
When parsing terragrunt.hcl files as part of interacting with a dependency, the terragrunt-auth-provider-cmd flat does not get executed.
This can be problematic if dependencies use calls like get_aws_account_id(), and need access to AWS credentials via the auth provider command.
Steps To Reproduce
Steps to reproduce the behavior, code snippets and examples which can be used to reproduce the issue.
Add this:
locals {
  aws_account_id = get_aws_account_id()
}

To:
test/fixture-auth-provider-cmd/multiple-apps/app3/terragrunt.hcl
You can see it fail here in CircleCI.
Expected behavior
The authentication provider command is re-run before parsing any terragrunt.hcl files in order to ensure that the credentials are available while trying to interact with resources that could require authentication.
Nice to haves

[ ] Terminal output
[ ] Screenshots

Versions

Terragrunt version: 0.63.6
OpenTofu version: 1.7.3
Environment details (Ubuntu 20.04, Windows 10, etc.): GitHub Actions Ubuntu Latest

This was actually more complicated to reproduce due to the nature of the integration tests.
This more accurately captures it, with associated CircleCI tests failing to prove it.


fix(adapter-planetscale): Map CHAR columns to text column types

CHAR db type does not mean single character. It should be mapped to
Text type instead.
Fix #21592

@jkomyno, removed JS CHAR in this PR, will send follow up to rust side later.

@jkomyno Char type exists in quaint, so maybe not.


Bump: sentry-android to 5.2.0 (#)

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Codecov Report

Merging #594 (fe6bb52) into main (6ebc780) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   90.37%   90.37%
=======================================
  Files          89       89
  Lines        2951     2951
=======================================
  Hits         2667     2667
  Misses        284      284

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebc780...fe6bb52. Read the comment docs.


Multi-threading issues on information_schema queries

I'm switching a few projects to this dbt-athena community adapter and I notice a regression bug 🐛
Locally, I use threads: 4. I have a few databases defined in my dbt_project.yml:
models:
  test_jesse:
    silver:
      test_a:
        +schema: silver_test_a
      test_b:
        +schema: silver_test_b
      test_c:
        +schema: silver_test_c

When I run dbt --debug run I see it starts by making 3 parallel queries to INFORMATION_SCHEMA (corresponding to the 3 custom schemas)

Output of the failing `dbt --debug run`:
23:22:00.639968 [info ] [MainThread]: Found 79 models, 9 tests, 0 snapshots, 0 analyses, 498 macros, 0 operations, 0 seed files, 64 sources, 0 exposures, 0 metrics
23:22:00.642584 [info ] [MainThread]:
23:22:00.642973 [debug] [MainThread]: Acquiring new athena connection "master"
23:22:00.645492 [debug] [ThreadPool]: Acquiring new athena connection "list_awsdatacatalog"
23:22:00.652730 [debug] [ThreadPool]: Acquiring new athena connection "list_awsdatacatalog"
23:22:00.654241 [debug] [ThreadPool]: Acquiring new athena connection "list_awsdatacatalog"
23:22:00.655511 [debug] [ThreadPool]: Using athena connection "list_awsdatacatalog"
23:22:00.655686 [debug] [ThreadPool]: Using athena connection "list_awsdatacatalog"
23:22:00.655861 [debug] [ThreadPool]: Using athena connection "list_awsdatacatalog"
23:22:00.656061 [debug] [ThreadPool]: On list_awsdatacatalog: /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:22:00.656238 [debug] [ThreadPool]: On list_awsdatacatalog: /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:22:00.656446 [debug] [ThreadPool]: On list_awsdatacatalog: /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:22:00.656774 [debug] [ThreadPool]: Opening a new connection, currently in state init
23:22:00.660507 [debug] [ThreadPool]: Opening a new connection, currently in state init
23:22:00.673268 [debug] [ThreadPool]: Opening a new connection, currently in state init
23:22:00.675392 [error] [ThreadPool]: Athena adapter: Got an error when attempting to open a Athena connection due to 'credential_provider'
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.9/site-packages/dbt/adapters/athena/connections.py", line 155, in open
    handle = AthenaConnection(
  File "/opt/homebrew/lib/python3.9/site-packages/pyathena/connection.py", line 139, in __init__
    self._client = self._session.client(
  File "/opt/homebrew/lib/python3.9/site-packages/boto3/session.py", line 299, in client
    return self._session.create_client(
  File "/opt/homebrew/lib/python3.9/site-packages/botocore/session.py", line 951, in create_client
    credentials = self.get_credentials()
  File "/opt/homebrew/lib/python3.9/site-packages/botocore/session.py", line 507, in get_credentials
    self._credentials = self._components.get_component(
  File "/opt/homebrew/lib/python3.9/site-packages/botocore/session.py", line 1112, in get_component
    del self._deferred[name]
KeyError: 'credential_provider'
23:22:00.688091 [debug] [ThreadPool]: Athena adapter: Error running SQL: /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:22:00.688642 [debug] [ThreadPool]: Athena adapter: Error running SQL: macro list_schemas
23:22:00.688916 [debug] [ThreadPool]: On list_awsdatacatalog: No close available on handle
23:22:07.156437 [debug] [ThreadPool]: SQL status: OK -1 in 6.5 seconds
23:22:07.158140 [debug] [ThreadPool]: On list_awsdatacatalog: Close
23:22:07.159025 [debug] [ThreadPool]: SQL status: OK -1 in 6.5 seconds
23:22:07.159950 [debug] [ThreadPool]: On list_awsdatacatalog: Close
23:22:07.160520 [debug] [MainThread]: Connection 'master' was properly closed.
23:22:07.160681 [debug] [MainThread]: Connection 'list_awsdatacatalog' was properly closed.
23:22:07.160892 [debug] [MainThread]: Connection 'list_awsdatacatalog' was properly closed.
23:22:07.161071 [debug] [MainThread]: Connection 'list_awsdatacatalog' was properly closed.
23:22:07.161847 [debug] [MainThread]: Flushing usage events
23:22:07.162046 [error] [MainThread]: Encountered an error:
Runtime Error
  Runtime Error
    Database Error
      'credential_provider'

When I switch back to Tomme's adapter (dbt-athena-adapter==1.0.1), It makes three queries in parallel successfully.

Output of the failing `dbt --debug run`:
23:23:51.801549 [info ] [MainThread]: Found 79 models, 9 tests, 0 snapshots, 0 analyses, 490 macros, 0 operations, 0 seed files, 64 sources, 0 exposures, 0 metrics
23:23:51.804227 [info ] [MainThread]:
23:23:51.804618 [debug] [MainThread]: Acquiring new athena connection "master"
23:23:51.807446 [debug] [ThreadPool]: Acquiring new athena connection "list_awsdatacatalog"
23:23:51.814927 [debug] [ThreadPool]: Acquiring new athena connection "list_awsdatacatalog"
23:23:51.816278 [debug] [ThreadPool]: Acquiring new athena connection "list_awsdatacatalog"
23:23:51.817486 [debug] [ThreadPool]: Using athena connection "list_awsdatacatalog"
23:23:51.817641 [debug] [ThreadPool]: Using athena connection "list_awsdatacatalog"
23:23:51.817786 [debug] [ThreadPool]: Using athena connection "list_awsdatacatalog"
23:23:51.817940 [debug] [ThreadPool]: On list_awsdatacatalog: -- /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:23:51.818153 [debug] [ThreadPool]: On list_awsdatacatalog: -- /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:23:51.818459 [debug] [ThreadPool]: On list_awsdatacatalog: -- /* {"app": "dbt", "dbt_version": "1.3.1", "profile_name": "athena", "target_name": "dev", "connection_name": "list_awsdatacatalog"} */

    select
        distinct schema_name

    from awsdatacatalog.INFORMATION_SCHEMA.schemata

23:23:51.818715 [debug] [ThreadPool]: Opening a new connection, currently in state init
23:23:51.828140 [debug] [ThreadPool]: Opening a new connection, currently in state init
23:23:51.832063 [debug] [ThreadPool]: Opening a new connection, currently in state init
23:23:58.460654 [debug] [ThreadPool]: SQL status: OK -1 in 6.64 seconds
23:23:58.461749 [debug] [ThreadPool]: On list_awsdatacatalog: Close
23:23:58.465697 [debug] [ThreadPool]: SQL status: OK -1 in 6.65 seconds
23:23:58.466534 [debug] [ThreadPool]: On list_awsdatacatalog: Close
23:23:58.473755 [debug] [ThreadPool]: SQL status: OK -1 in 6.66 seconds
23:23:58.474907 [debug] [ThreadPool]: On list_awsdatacatalog: Close

When I use threads: 1 or threads: 2 it works and successfully deploys the dbt project, but it starts failing with 3 or more threads.
This might be a regression? I found a similar issue https://github.com/Tomme/dbt-athena/issues/41
💡 If this only happens with the information_schema queries, we might fix this by calling the Glue API (faster) instead of querying information_schema in Athena? See suggestion: https://github.com/dbt-athena/dbt-athena/pull/4#issuecomment-1305576711

I could reproduce starting from this adapter's first release (1.0.4): https://github.com/dbt-athena/dbt-athena/pull/7/files
The PR that looks suspicious seems to be https://github.com/dbt-athena/dbt-athena/pull/16
I made a local change and reverted one line in connections.py and it deploys my project again with 8 threads 👌
            handle = AthenaConnection(
                s3_staging_dir=creds.s3_staging_dir,
                endpoint_url=creds.endpoint_url,
                schema_name=creds.schema,
                work_group=creds.work_group,
                cursor_class=AthenaCursor,
                formatter=AthenaParameterFormatter(),
                poll_interval=creds.poll_interval,
-               session=get_boto3_session(connection),
+               profile_name=creds.aws_profile_name,
                retry_config=RetryConfig(
                    attempt=creds.num_retries,
                    exceptions=(
                        "ThrottlingException",
                        "TooManyRequestsException",
                        "InternalServerException",
                    ),
                ),
            )

But I wonder if switching to the Glue API instead of querying information_schema would not be a better solution instead?

Could be that the regression was introduced by Share same boto session between every calls, I honestly think that switching to Glue API is better.

I have a branch with the Glue API implemented instead of information_schema but the multi-threading error in botocore still happens.
Found this to be very interesting:

https://stackoverflow.com/questions/52820971/is-boto3-client-thread-safe
https://github.com/boto/botocore/issues/1246#issuecomment-632444392
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/resources.html#multithreading-or-multiprocessing-with-resources

The tl;dr is

... for boto3 you can see that they recommend one client per session as there is shared data between instance that can be mutated by individual threads.

So you need one session per thread. We use 1 global session right now, which is causing the multi-threading errors: https://github.com/dbt-athena/dbt-athena/blob/main/dbt/adapters/athena/session.py#L9-L15C10
Which was introduced in https://github.com/Tomme/dbt-athena/pull/125
I can create a fix where we change session.py to the code below. This runs perfectly with 8 threads:
import boto3.session
from dbt.contracts.connection import Connection

def get_boto3_session(connection: Connection = None) -> boto3.session.Session:
    if connection is None:
        raise RuntimeError(
            "A Connection object needs to be passed to initialize the boto3 session"
        )

    return boto3.session.Session(
        region_name=connection.credentials.region_name,
        profile_name=connection.credentials.aws_profile_name,
    )


[BUG] Different services not connecting on the same ActorSystem

Describe the bug
When we try to connect two different services (different deployments) to the same ActorSystem, the services cannot communicate.
Errors:
On the bootserver service
2023-04-13 20:52:51.789 [botserver@<IP_ADDRESS>]:[pid=<0.2743.0> ]:[warning]:[libcluster:proxy] unable to connect to<EMAIL_ADDRESS>[18:00]

In wppbot service
2023-04-13 20:52:52.234 [wppbot@<IP_ADDRESS>]:[pid=<0.2743.0> ]:[warning]:[libcluster:proxy] unable to connect to<EMAIL_ADDRESS>
It seems that libcluster's Kubernetes.DNS strategy is not properly configured or does not serve our purposes. Need to look more closely.
To Reproduce
Steps to reproduce the behavior:

Apply ActorSystem
Apply ActorHost with application 1 referencing the ActorSystem from step 1
Apply ActorHost with application 2referencing the ActorSystem from step 1

Expected behavior
Both ActorHosts connect successfully.
Kubernetes (please complete the following information):

Provider:  k3d or Any other

Spawn Operator (please complete the following information):

Version 0.5.x

Spawn Proxy (please complete the following information):

Version 0.5.x

Close this by 6af4e25

Wow 0/

nice work


Enable link opening from agenda

The Agenda:open_link function is almost identical to OrgMappings:open_at_point. Any suggestions on how to (and where) to de-duplicate it are appreciated. The moving of get_link_under_cursor to Hyperlinks.lua is a proposal.

Emacs orgmode functionality is actually a bit more complicated than this:

C-c C-o (org-agenda-open-link)
Follow a link in the entry. This offers a selection of any links in the text belonging to the referenced Org node. If there is only one link, follow it without a selection prompt.

This means that it will find all the links under the headline, and show you something like inputlist() to select which one you want to open, or just default to first one if it's the only one.
This can be maybe done differently:

Find the headline from the org state
Add a method to it called getHyperlinks()
Show the list or go to first if single

Regarding finding hyperlinks, we could try using a tree-sitter query with custom predicate which I'm using for highlighting (https://github.com/nvim-orgmode/orgmode/blob/master/queries/org/markup.scm#L14). I'm not sure if that would work though, would need to give it a test.

Some questions:

If I recall correctly I was concerned about links that are part of the headline. Emacs also allows you to open headlines with links in the body, correct?
Does Emacs go down recursively into child headings or is it just the body of this one heading?

Yes
I haven't tested this scenario. I can get back to you on this tomorrow

I haven't tested this scenario. I can get back to you on this tomorrow
It doesn't go recursive. It takes only that specific headline, at least by default. I don't know if there's some specific setting for it, I didn't find any.


Bump submariner-operator version to get GN RBAC changes

@tpantelis can you please eloborate why we have to update the submariner-operator in subctl repo?

@tpantelis can you please eloborate why we have to update the submariner-operator in subctl repo?

The RBAC yaml is in submariner-operator but it's subctl that actually deploys it. So we need to pull in he changes and publish an updated subctl otherwise E2E will fail in submariner.


MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 data listeners added. Use emitter.setMaxListeners() to increase limit

The code will cause this.streams.stderr to repeatedly listen for the same event:
const Shell = require("node-powershell");

const test = async () => {
  const ps = new Shell({
    executionPolicy: "Bypass",
    noProfile: true
  })
  for (let index = 0; index < 10; index++) {
    ps.addCommand(`echo ${index}`)
    const res = await ps.invoke()
    console.log("im index and res: %n %s", index, res)
  }
}
 test()

https://github.com/rannn505/node-powershell/blob/b0a0f7f33f7c0b07351e875007e97a20d217b420/lib/Shell.js#L174-L228
I have noticed that every time you run the invoke function, you will recreate the ShellStreamBuffer instance, this should be optimizable.
https://github.com/rannn505/node-powershell/blob/b0a0f7f33f7c0b07351e875007e97a20d217b420/lib/Shell.js#L180

pretty much hit this leak anytime i'm needing to run a powershell command and get back the output in a looped format... but even if i didn't as stated above, basically everytime we call invoke() we eat up a little memory that we never end up releasing. For me I'm simply using this in a 1-shot fashion so i'd be content with even the ability to inject as a config option to the frontend class of node-powershell the ability to set emitter.setMaxListeners(n) when its instantiated.

@FloatingShuYin @zenion ,
A fix will be released with the next version.
working on that :)

 Fix MaxListenersExceededWarning

Thank you for your work @rannn505 ! Do you have an idea on when this might be released?
And has anyone looked into what issues might occur due to this? Is it 'just' a leak or is there functionality that is missing as soon as the limit is hit?

@sopelt,
I'm aiming for Saturday 🤞

@sopelt,
I still have some small things left before I can release, but I won't have enough time to fix them today.
I believe it will be released tomorrow.
Thank you for your patience.

@rannn505 Is this fixed ? because im still having this issue on the latest Version from NPM and I also cant see any new releases on Github...
I am also having the same issue and im using Node-Powershell to obtain information about processes every 5 seconds...
Hope this gets fixed soon.

@sopelt take a look on:
https://github.com/rannn505/node-powershell/pull/116
Its not ready for publish but this is a good alpha :)

@rannn505 I'm currently facing this problem as well. In the meantime, is there any simple fix or workaround?

hey @rannn505 , the branch looks like you went all in ;)
Is there a plan to rename the package or what does node-shell refer to?
I have built the branch locally, installed it in my project and started refactoring (mostly import, constructor options, result handling). Do you have any tips or are you aware of anything I should add to my configuration to get as close to the previous behavior as possible? ;)
Currently I am looking at why I see lots of Expressions are only allowed as the first element of a pipeline. in the errors ... and why I seem to have some newlines in stderr ...

@sopelt

Regarding the name thing, this version I implemented the NPS base classes with an abstract layer that would now allow me to apply a cover to any other shell I want quite easily and fast. The name of the package will not change but new packages (like node-bash etc ..) will be added very soon. All of them will be here in this repo (and I plan to use lerna to manage all the new packages). it will be fun :)

Hi @rannn505 , I've seen that you published a new release/preview to npm? How far along is that? ;)
Sorry for not providing feedback yet. I've looked at using a local package a few weeks back but other tasks came up... :-/
I'll try to drop in the new version in our project this week.

Hi @rannn505 .. I installed 5.0.0-next.1 and tried running https://github.com/rannn505/node-powershell/blob/node-shell/examples/2.longer-basic-usage.ts and don't quite get it to work. After the first invoke the internal state of the shell shows Failed and I can't figure out why. Any ideas? Other than that it looks like a bit of refactoring to unwrap the result text of the invoke returns as this is now an object but that is understandable.

@sopelt

Regarding the name thing, this version I implemented the NPS base classes with an abstract layer that would now allow me to apply a cover to any other shell I want quite easily and fast. The name of the package will not change but new packages (like node-bash etc ..) will be added very soon. All of them will be here in this repo (and I plan to use lerna to manage all the new packages). it will be fun :)

Wow, chain syntax looks pretty good

Hi, do you have any delivery forecast for this fix?

Thanks @rannn505 for your work! I am looking forward to giving 5.0.1 a spin ;)


chore: make clippy happy

fix this check

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.36%. Comparing base (7413344) to head (fc4279a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
- Coverage   78.38%   78.36%   -0.03%
==========================================
  Files         240      240
  Lines       77121    77122       +1
  Branches    77121    77122       +1
==========================================
- Hits        60455    60435      -20
- Misses      13568    13572       +4
- Partials     3098     3115      +17

Flag
Coverage Δ

unittests
78.36% <100.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automate Slack flags when Prismic linting errors are found

Currently, Natalie writes to #wc-editorial when the Prismic linting script reports errors on the dashboard. We'd like to automate that so we don't have to keep an eye on it anymore.
https://github.com/wellcomecollection/wellcomecollection.org/pull/11200

Sylvester is well and alive https://wellcome.slack.com/archives/C3N7J05TK/p1727365106255049
I've made all devs managers of the workflow.


Bundles size increases dramatically when importing vue-strap component.

So I'm just including a component like this:
import { aside } from 'vue-strap'

This is increasing my bundles size by 120kb, not sure why.

using it that way include all the vue-strap components.
if you want to include only the aside component, try this way:
import sidebar from 'vue-strap/src/Aside'

Note that I used sidebar instead of aside... in html5 aside is a native tag, so is better to use a different tag name.


Update plural and singular title for bulk actions

Update plural and singular title for bulk actions, there were previous caseas using the length to decide about plural or singular. Standarize this one.

There are other places that same concept should be applied, such as actionButtonText but it might be addressed in a follow up PR.

Followed up with @jamestalton and the usage of count variable for plural should be the one used whenever possible, I will add an entry to README to deal with that one, and update this PR.


AB#6775 privacy and terms page

It looks like there may be some new items missing that hold the privacy/terms content? I see some broken links where the content might have gone on those items. On the front end of the site I do not see the text.

@mintsitecore I moved the content datasource items under the pages instead of the global components folder. Please do a quick test of the updates. Thanks!


Furnace recipe

The furnace recipe for Glass is missing from MISC.

You can create a JSON file on your computer like this:
{
  "type": "minecraft:smelting",
  "ingredient": {
    "item": "minecraft:sand"
  },
  "result": "minecraft:glass"
}

and drag it onto the server computer to do a JSON import


add support for ElementHandle as an argument and a return value to evaluate

adding support for ElementHandle as both a valid argument and return value to evaluate will make the api more powerful for end users.
i'd expect both of the following to work.  (they are both broken)
const elem = await page.$('input')
const b = await page.evaluate((a) => { return a }, elem)
await b.click()

const b = await page.evaluate(() => { return document.querySelector('input') })
await b.click()

Just ran into this myself writing some new examples. Bump for priority :)

Related #303

Closing in favor of #382.


Automation set up with Yarn link and Yarn link react-hook-form

I am trying to set up automation env for react-hook-form and having an app running which references back to the source code in the src folder.
I have used yarn link at /src folder and then run yarn link react-hook-form at /app folder. however, when I start the app, I am getting this issue:

there is definitely no duplicated react.
wondering if anyone has experience or know how to fix this issue. PR welcome :) ❤

ah... I know this one.. (ran into it myself a bunch of times)(
Do what you did.... plus:

Go into your node_modules/react folder
Run yarn link
Go to your app where you're testing, and run yarn link react

The problem is that with hooks, you need to ensure the exact same react instance you built react-hook-form with is the one you're testing with.

wow gonna give it a try! thanks @barrymay!

Go into your node_modules/react folder within the react-hook-form codebase
oops there is no react in the node_modules folder, cause it's
"peerDependencies": {
    "react": "^16.8.0",
    "react-dom": "^16.8.0"
  },

OMG! @barrymay you are the GOD. It's working! thank you so much again ❤

(fwiw, it's something I'm definitely hoping they get rid of 16.9+, as it has hit me sooo many times)... But it's definitely the big tricky to know when linking with 3rd party packages

oh yea I did face this issue before, but never thought about link react was the solution. really appreciated your help (as usual). ❤  now I can start writing automation this weekend!