instrumentation-fastify fails to initialise if "type" is set to "module" in package.json

What version of OpenTelemetry are you using?
Latest versions available:
    "@opentelemetry/api": "^1.4.1",
    "@opentelemetry/auto-instrumentations-node": "^0.37.0",
    "@opentelemetry/exporter-metrics-otlp-proto": "^0.39.1",
    "@opentelemetry/exporter-prometheus": "^0.39.1",
    "@opentelemetry/exporter-trace-otlp-proto": "^0.39.1",
    "@opentelemetry/instrumentation": "^0.39.1",
    "@opentelemetry/instrumentation-fastify": "^0.31.3",
    "@opentelemetry/instrumentation-http": "^0.39.1",
    "@opentelemetry/resources": "^1.13.0",
    "@opentelemetry/sdk-metrics": "^1.13.0",
    "@opentelemetry/sdk-node": "^0.39.1",
    "@opentelemetry/sdk-trace-base": "^1.13.0",
    "@opentelemetry/sdk-trace-node": "^1.13.0",
    "@opentelemetry/semantic-conventions": "^1.13.0",

What version of Node are you using?
v18.16.0
What did you do?

Tried to use @opentelemetry/instrumentation-fastify on a new project did not understand why the instrumentation did not work.
What did you expect to see?
@opentelemetry/instrumentation-fastify Applying patch for<EMAIL_ADDRESS>What did you see instead?
nothing
Additional context
instrumentation-http works in both modes:
@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>

support for instrumenting ESM was recently merged (see https://github.com/open-telemetry/opentelemetry-js/pull/3698) but it's not yet in a release.
Please retest once a new release is out.

New release is out. Can you please confirm if this is fixed?

Closing this as it should work as of the latest release.
Feel free to comment if we should re-open the issue. :slightly_smiling_face:

This appears to still be a problem. We converted the Fastify example to ESM and see the HTTP modules being patched, but not fastify. https://github.com/nlindley/opentelemetry-js-contrib/compare/main...fastify-esm

Downgrading @opentelemetry/instrumentation to ^0.40.0 and deduping node modules helps, but we have to be particular in how we import Fastify. If we depend on ^0.41.0, then 0.40.0 will be installed inside @opentelemetry/instrumentation-fastify’s node modules along with a different version of import-in-the-middle, and the fastify instrumentation will fail.

A working version can be seen here: https://github.com/nlindley/opentelemetry-js-contrib/compare/main...fastify-esm-working

We have some more details and some minimal reproductions for the Fastify instrumentation.
When using the default import, the instrumentation crashes the app when a new instance is created by invoking fastify(). https://github.com/nlindley/otel-esm-examples/tree/master/fastify-default
When using the named import, the instrumentation does not crash, but the library is not wrapped and no spans are created. https://github.com/nlindley/otel-esm-examples/tree/master/fastify-named

FYI I opened a PR to fix this issue: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1624
This may be relevant for other instrumentations as well, you cannot depend on moduleExports being a function and always need to look at named exports/default export in order to make sure wrapping works in ESM as well.

This seems to still be an issue when using the named fastify export through ESM.
Using the latest version of the Fastify instrumentation, I see that the default export is successfully patched, but the named export does not seem to patch beyond the constructor. It appears that the library is not fully wrapped and no spans are created through the Fastify instrumentation.
Given how Fastify provides its constructor through the default export (a function with an applied fastify constructor method, resolved within CommonJS), perhaps we need to look at wrapping both default and fastify within the ECMAScript Module Namespace representation?
Here is an updated minimal reproduction demonstrating the default export successfully patching:
https://github.com/nlindley/otel-esm-examples/tree/master/fastify-default
and another reproduction demonstrating that the named export does not fully patch:
https://github.com/nlindley/otel-esm-examples/tree/master/fastify-named

This is still an issue.


Experience multiplier malfunctioning

Describe the bug
By applying an experience multiplier lower than the default value (1) when there is already a leaderboard and there are members of different levels in it, when gaining experience these members level up sooner than expected.
To Reproduce
Steps to reproduce the behavior:

Make sure there is at least one member above level 9 (for results to be inmediately conclusive).
Set the value of difficultyModifier to 0.5 (in leveling.json).
Restart the bot (except if using the devStart npm script).
The member from step 1 must send one or more messages rewarded by XP points.
Observe how for each message, the member levels up.

Expected behavior
The member should only level up after gaining the experience indicated by the /stats command.
Screenshots

The bug was introduced in 1fe36539768a8def8624c5385aee3a13c76378f9 as part of an update to fix a similar bug.

It has been decided to remove this feature (12a4ca095b178fbd82e5ad3868d8a2b53d7a6683) in favor of the minimum and maximum XP control already present in the leveling configuration file.


fix document of functions.embed_id

Link of See also at http://docs.chainer.org/en/stable/reference/functions.html#embed-id is missed.

Thank you!


Bug: Frontend shows multiple stocks for same partner and same material after request.

The screenshot situation occurs in case the following steps are done:

start local deployment (local/docker-compose)
open customer Frontend (localhost:3000) and trigger partner product stock request update
Switch to dashboard and Stock view to reload data and check partner product stock for material

Target: either differentiation criteria should be visible or it should be one. Please analyze

solved with #93


Update Markdown example showing rehype-minify plugin

Our example for Markdown plugins (https://docs.astro.build/en/guides/markdown-content/#markdown-plugins) shows a rehype-minify plugin being used. But, this is a collection of plugins, not a plugin itself.
The plugin used in the example code should be replaced. Maybe the preset rehype-preset-minify should be used instead? Maybe @bholmesdev has an opinion?

This is my astro config file using the rehype-preset-minify plugin, which leaves me with a "invalid input" error:
import { defineConfig } from 'astro/config';
import tailwind from "@astrojs/tailwind";
import deno from "@astrojs/deno";
import remarkMath from "remark-math";
import rehypeKatex from 'rehype-katex';
import rehypePresetMinify from 'rehype-preset-minify';

export default defineConfig({
  integrations: [tailwind({
    config: {
      applyBaseStyles: false
    }
  }),],
  markdown: {
    remarkPlugins: [remarkMath],
    rehypePlugins: [rehypeKatex, rehypePresetMinify],
    extendDefaultPlugins: true,
    shikiConfig: {
      theme: 'github-light',
      langs: [],
      wrap: false
    }
  },
  output: "server",
  adapter: deno()
});


How to use this plugin

Hello,
I've installed the package to Sublime Text 3.1.1, but the .vue files (with <template,

There's nothing else to do than install it, there's no additional step.

Yep, I just found out when I create a NEW .vue file, then it works. But the "old" .vue files (that were already opened with Sublime) still have no highlighting... even when I restart Sublime or the computer.
However, thanks. I think this can be closed, it's not an issue.

Shouldn't this be fixed? Otherwise, I can't use this plugin for my existing projects.


Fix and improve do_truncate

Quoting https://twitter.com/dakami/status/778661907179958272:

All user experiences that use ... after exposing almost an entire message, are failed user experiences. File bugs.  I'm serious.

If Dan Kaminsky thinks it's a good idea, it is.

Ensure that the requested max length be at least as long as the
requested end value (e.g. 3 in the case of '...'). Fixes #539
Add leeway parameter so that strings that just barely miss the
requested max length cutoff can still be spared from unwanted truncation.
Default value is 5.
No longer append a space before appending end under any circumstances.
Adding whitespace before ellipsis punctuation in English is grammatically
incorrect.

I've been wanting to fix 2. and 3. for a while. The @dakami tweet finally prompted me to submit this PR.
Happy to tweak the leeway default to something other than 5, but thought that's a reasonable value.

Thanks!

Thanks for merging!

The default leeway of 5 breaks many existing usages of truncate which don't specify the leeway. It should be defaulted to 0 for backwards compatability.

Is there any backwards compatibility requirement given that this landed in 2.9, which had other backwards-incompatible changes? It's possible more users are happy to get this change for free when they upgrade Jinja without having to change their code. If it should have worked this way by default from the beginning, it'd be good to at least make it the default behavior at some point.

I added a filter policy for this so you can reconfigure the default.


Add bower.json file

A bower.json file would be great to be included.

Upstream has been updated to 0.8.1, including a merge of the most recent commits from your fork.
Would you mind either pulling the latest and updating the bower version or unpublishing it so I can update it?


Allow Children query to have zero members

What problem does this solve or what need does it fill?
Currently when querying an entity which may or may not have children (for example, walking a tree), you have to write the query like this:
    mut view_query: Query<(&mut MyComponent, Option<&Children>)>,

In other words, Children has to be optional because otherwise the query won't return entities that have no children. However, this makes processing inconvenient because now you have to unwrap the children list.
What solution would you like?
I'd like to have the ability to query Children and always have it return a result. If the entity has no children, it will return a zero-length list. For backwards-compatibility, this could be a different predicate, perhaps ChildrenList or something.
What alternative(s) have you considered?
For now, I'm using conditional logic:
let children = match view_query.get(parent) {
    Ok((_, Some(ch))) => ch,
    _ => &[],
};

However, it would be nice to get rid of boilerplate like this.

Hmm. I'm strongly opposed to special-casing this. The alternative is to keep empty Children components around? But then we lose the ability to query for "all entities with at least one child".

Note that you can create a custom WorldQuery that does this.
#[derive(WorldQuery)]
pub struct Kids {
    children: Option<Children>,
}

impl Deref for Kids {
    type Target = [Entity];
    fn deref(&self) -> &Self::Target {
        self.children.map_or(&[], |c| &*c)
    }
}

Closing issue. It was "only a suggestion".


Bug report: Syntax Error: Expected Name, found "}".

I encountered an error: Syntax Error: Expected Name, found "}".

Closing as same issue as
https://github.com/warrenday/graphql-network-inspector/issues/135
Discussion will continue there


fix(amplify-codegen): have correct error msg for api meta not found

Issue #, if available:
fix #121
Description of changes:
Change the error message for api metadata not found scenario in case of confusing users.
How are these changes tested:
yarn test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM


[OTHER] link is giving 404 error

This link is giving 404 error .
Check out our awesome profiles here
Additional information

Seems to be fixed now. The page wasn't being deployed.


31 update dependencies

0.5.6

[UPDATE] Updates dependencies, most notably egui
[REFACTOR] Implements a command pattern for game action commands in the UI, see Readme.md
[REFACTOR] Moves around some code to give it more structure and also in parts for encapsulation reasons

See Readme for detials.

Just realized another posibiliity to do command handling (without hooking it into the update mehtod and the Rc) would be to add the window as part of the SecCardGameApp struct. Then one could call the handle_command function with the command as agrument directly. Without havin borrow or lifetime issues.
Here is an example https://github.com/maschmi/egui_command_pattern for this, main branch has no command pattern. Inside this branch https://github.com/maschmi/egui_command_pattern/tree/command_callback you can find it with the command pattern.

I changed it after some experiments in here https://github.com/maschmi/egui_command_pattern/tree/non_self_windows
Now Rc is not needed anymore. However, I just thought I understood borrowing and now there is somehting new to understand and learn :D


ObjectAppendingMarker in v7.0+ has no means to access the fieldValue as its object type

Describe the bug
Have a test using AssertJ that accesses the field in ObjectAppendingMarker. It previously was called object and the test could access it as the correct object type. v7.0 renamed the field to be fieldValue and the AssertJ reflection favours the getFieldValue method over the field itself, and the getter always returns a string.
Is there a way to get the fieldValue as its type rather than a string? I have a value that is a map, and having this converted to a string makes testing problematic.

@tim: is the proposed PR ok for you ?

@brenuart that sounds good to me. Appreciate the quick response! Thanks


How to connect a Azure Sphere downstream device

I'd like to connect a Azure Sphere device as a downstream device, how can I make Sphere trust the owner CA certificate using C ? And is it possible to connect using the GatewayHostName in the connection string with Sphere ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de9562a7-4f9a-c733-6239-1af7f5f91854
Version Independent ID: 9fcc5069-27af-350c-6261-71f3526397b1
Content: Create a transparent gateway with Azure IoT Edge - Windows
Content Source: articles/iot-edge/how-to-create-transparent-gateway-windows.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

@janlange Thank you very much for your interest in Azure products and service. We are investigating and will update you shortly.

Hello @janlange we currently don't have a sample with the scenario described. There is work in progress in that though. Can I kindly ask you to open a new feature request here ?
Thank you!

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Adding as a reference: https://feedback.azure.com/forums/907045-azure-iot-edge/suggestions/35859580-document-how-to-connect-azure-sphere-device-as-dow


Settings when action should return error

Currently the action only return an error code, when the trivy scan return an error.
It would be helpful to set the severity/level for the vulnerabilities/best-practices when the action should return an error.

Hi @Smuu, it is not clear what is the desired outcome here. Can you please share an example to help us understand the use case better.

Closing this issue. Please feel free to re-open with more details.


Adds missing Windows resource classes

Description

Adds machine executor resource classes for Windows resources.

Implementation details

Adding windows.medium and other sized resource classes to the list of valid resource_class enum values.

How to validate

Add a Windows resource class to a Machine executor, such as windows.medium, and check that it validates as expected.

Hey @loderunner!
I'm a little confused here. publicschema.json is completely missing the Windows executor, yet the SchemaStore you mentioned, has them available. (I understand this is the schema our UI Config Editor uses as well.)
https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/circleciconfig.json#L551-L559
From my limited understanding, I believe the issue lies in the fact that we aren't validated Windows resource correctly on this line:
https://github.com/CircleCI-Public/circleci-yaml-language-server/blob/8c75190add027ce3b598fbdf1ab6de07382f321e/pkg/parser/validate/executor.go#L233
It should instead be something like this, no?
var ValidWindowsResourceClasses = []string{
	"windows.medium",
	"windows.large",
	"windows.xlarge",
	"windows.2xlarge",
}

If my understanding is correct, happy to open a PR!

@loderunner
I have limited context to this repository but I am thinking @imlogang 's points above are true.

We added a list of valid windows executors here
This is then used for validating the windows executors

If so, re: a PR, would this then mean:

Update the list of valid windows executors with the windows. prefix as Logan suggested
Update our executor tests to include validating the windows executors (perhaps here?)

@kelvintaywl Yes, that seems about right. With the new list and the executor test, we should be able to approve and merge the PR.

All executors resource classes and images have been updated with #293. Closing this issue.


In Staff Reviews for Concept notes, the "Other Comments" field is marked required

Further, the other fields that are required to be filled in are not marked required.

I believe all fields that are required to add to a form also becomes required when filling out the form.
@todd-dembrey Maybe can explain how this works.

Yes, that is the case. If a field must be included within the form it is marked as required. I think that assumption holds True for Applications, but might be a bit odd for Reviews. We could look to add an option to make these non-required within the Review forms.
It is hardcoded here:
https://github.com/OpenTechFund/opentech.fund/blob/4b878dc87440127e15f6afc40b50a0cbd119277a/opentech/apply/utils/blocks.py#L151
We would look to vary it here:
https://github.com/OpenTechFund/opentech.fund/blob/4b878dc87440127e15f6afc40b50a0cbd119277a/opentech/apply/review/blocks.py#L38:35
We would also want to make sure we have a default blank string for these.


Add promotion for March 2016 Budget to homepage [not before until March 14]

Zen ticket: https://govuk.zendesk.com/agent/tickets/1257975
Replace the find a job promotion on the homepage with a promotion for the March 2016 Budget which is being published on the 16th.
Expected changes
URL on gov.uk

Removes promotion "Find a job"
Adds promotion "March 2016 Budget"

Before

After

The release date for this has been moved to the 14 March 2016, have updated description accordingly.

This is now ready for review/merge for deployment at 4pm

It'd be worth optimising the image, at 124k it's a little bigger than we'd normally include.
Otherwise LGTM and i'm happy to merge once the image is updated. :+1:

New image is :+1:
@erikse: The build failure looks unrelated to the change, so once that's resolved i'd be happy for you to self-merge


Refresh Stat Bug

If you open starfi.re app and refresh someone stat(including yourself), you can't refresh other people stats anymore. You can only refresh one person when you enter the app. Please fix this issue

Also if you press more detail at the upcoming chest of the others, chest cycle that appear will be yours
I don't know if you wanna keep chest cycle private or it's a bug so please reply me


Slave don't connect to master

Hello,
First I would like to thank you for this very usefull Docker clusterisation of Postgresql which is a mess.
I've got a strange behaviour I would like to expose when trying to start containers once by once (and not with Docker compose):

I start the first pg Container as master with this command:

docker run --rm --name Pg1 --env INITIAL_NODE_TYPE=master --env NODE_ID=1 --env NODE_NAME=node1 --env CLUSTER_NODE_NETWORK_NAME=pgmaster --env POSTGRES_PASSWORD=monkey_pass --env POSTGRES_USER=monkey_user --env POSTGRES_DB=monkey_db --env
 CONFIGS="listen_addresses:'*',logging_collector:on" --env CLUSTER_NAME=pg_cluster --env REPLICATION_DB=replication_db --env REPLICATION_USER=replication_user --env REPLICATION_PASSWORD=replication_pass --env FORCE_CLEAN=1 -p 5432:5432 -v
 /data/pg1:/var/lib/postgresql/data paunin/postgresql-cluster-pgsql

The PG is active and all seams to be OK.

I try to start the 2nd pg Container as slave with this command:

docker run --rm --name Pg2 --env INITIAL_NODE_TYPE=standby --env NODE_ID=2 --env NODE_NAME=node2 --env CLUSTER_NODE_NETWORK_NAME=pgstandby --env CONFIGS="listen_addresses:'*',logging_collector:'on'" --env CLUSTER_NAME=pg_cluster --env REP
LICATION_UPSTREAM_NODE_ID=1 --env FORCE_CLEAN=1 --env REPLICATION_PRIMARY_HOST=localhost --env REPLICATION_PRIMARY_PORT=5432 -p 5433:5432 -v /data/pg2:/var/lib/postgresql/data paunin/postgresql-cluster-pgsql

but the PG embedded in this container never start and never connect to master. Here are the logs:
For node with initial type standby you have to setup REPLICATION_UPSTREAM_NODE_ID
>>> Will wait db replication_db on pgstandby:5432, will try 50 times with delay 5 seconds
>>> Will wait db replication_db on localhost:5432, will try 50 times with delay 5 seconds
psql: could not connect to server: Connection refused
	Is the server running on host "pgstandby" (<IP_ADDRESS>) and accepting
	TCP/IP connections on port 5432?
psql: could not connect to server: Connection refused
	Is the server running on host "localhost" (::1) and accepting
	TCP/IP connections on port 5432?
could not connect to server: Connection refused
	Is the server running on host "localhost" (<IP_ADDRESS>) and accepting
	TCP/IP connections on port 5432?
...

Any help would be grealty appreciated.
EDIT:
The docker run for pg2 was wrong. I fix it.
EDIT2:
The first server is running and listening:
$ netstat -an | grep 5432
tcp6       0      0 :::5432                 :::*                    LISTEN

When looking to entreypoint.sh I see that Postgresql in not started in case of not master server:
if [[ "$INITIAL_NODE_TYPE" == "master" ]]; then
cp -f /usr/local/bin/cluster/primary.entrypoint.sh /docker-entrypoint-initdb.d/
/docker-entrypoint.sh "$@" &
else
/usr/local/bin/cluster/standby.entrypoint.sh "$@" &
fi
Postgres is started by the /docker-entrypoint.sh shell and it is not called in case of slave server.
Do I miss something ?

OK, I found what is going wrong. My Pg2 container must be linked to the Pg1 as pgmaster. The correct docker run for Pg2 is:
docker run --rm --name Pg2 --link Pg1:pgmaster --env INITIAL_NODE_TYPE=standby --env NODE_ID=2 --env NODE_NAME=node2 --env CLUSTER_NODE_NETWORK_NAME=Pg2 --env REPLICATION_UPSTREAM_NODE_ID=1 --env FORCE_CLEAN=1 --env REPLICATION_PRIMARY_HO
ST=pgmaster --env REPLICATION_PRIMARY_PORT=5432 --env CLUSTER_NAME=pg_cluster --env REPLICATION_DB=replication_db --env REPLICATION_USER=replication_user --env REPLICATION_PASSWORD=replication_pass -p 5433:5432 -v /data/pg2:/var/lib/postg
resql/data paunin/postgresql-cluster-pgsql


Improved: the error message for the zip-code field on shipping and payment page(#589)

Related Issues
#589
Closes #589
Short Description and Why It's Useful

Updated the error message for the zip code field on the shipping and payment page
Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

Change looks perfect, Please update the change log as they have a conflict in them

Resolved the conflicts in the changelog.

@Fifciu these changes look good to me, we can merge these as well

@ymaheshwari1 please resolve conflicts. I will merge this.


Multi use commands return the wrong error if you provide wrong arguments

If you have a command with multiple types of arguments it always returns CommandError.UnknownCommand when you provide the wrong arguments.
Code:

Well..... Isn't that kind of expected? If neither argument could be parsed, the CommandService doesn't know which overload was intended to be used, so UnknownCommand is the best Error status available.
I think @FiniteReality has a PR in the works that makes overloads better in this regard (not sure if something like CommandError.OverloadResolutionFailed is already set to be added, but if it isn't, here's the idea).

CommandError.UnknownCommand isn't referenced anywhere in the Command Parser, so it's not returning that during the parsing. Can you use a breakpoint to see what commands are loaded into your Command Service? Just to make sure.

@Joe4evr In this case, we'd return the overload which was most likely to be the one the user wanted, which would be decided using PriorityAttribute.


How to get remaining string

Hi,
this is an example：

$parser->push('{ "id": 1, "name":');

$data = $parser->push('"first" }{ "id": 3, "name":'); // ['id'=>1, 'name' => 'first']

However how to get  { "id": 3, "name":  from $parser

@slince Thank you for filing this feature request! This is indeed not currently supported, but I agree that it makes perfect sense to add a getBuffer() (or similar) to this project :+1:
Do you feel like filing a PR? :shipit:

@clue  no problem

#8


additional slash cause error

Openapi2aspida auto add slash like const PATH0 = '/commodity/list' but it causes 'input' must not begin with a slash when using 'prefixUrl' error when used with ky
Is there anyway to remove the prefix slash to const PATH0 = 'commodity/list' after generating apis?

Thanks for posting.
For the following reasons, I may stop updating aspida/ky.

Cannot compile with tsc and development is too much work
Low number of users (less than 10 users/day)

To resolve this issue, I need to fix aspida itself.
But I can not fix aspida for aspida/ky.
Sorry.


Skip testScreenshot if Metal is not supported

We could eventually do this with python decorators, but this works for now.


Do task about clean code

Please, see an example: https://github.com/rimus/aircompany/tree/clean-code-solution/JS


DBT DREMIO CANNOT RUN WITH UNION ALL

Hi Fabrice,
Lately, I have using dremio-dbt to run create or replace a view
CREATE OR REPLACE VIEW AS "credit_overview_1923" AS
(
    WITH temp_table AS (
    SELECT 1 as name
    UNION ALL
    SELECT 2 as name
    )
    SELECT *
    FROM temp_table
)

then Dremio make in parsing query error but
when I run
WITH temp_table AS (
    SELECT 1 as name
    UNION ALL
    SELECT 2 as name
    )
    SELECT *
    FROM temp_table

it complete successfully
Please indicate the root cause of this problems, and the solution. Thank you so much

Hi @thuybt , thank you for using dbt-dremio !
The problem is not in the adapter,
as the problem still remains when you try executin the query in the dremio UI (I am pretty sure there is no AS between VIEW and the view name)
CREATE OR REPLACE VIEW <> "credit_overview_1923" AS
(
WITH temp_table AS (
SELECT 1 as name
UNION ALL
SELECT 2 as name
)
SELECT *
FROM temp_table
)
But this works :
CREATE OR REPLACE VIEW "credit_overview_1923" AS
(
WITH temp_table(name) AS (
VALUES(1),(2)
)
SELECT *
FROM temp_table
)
It must be a calcite parsing problem, I will try to find out more on the web.

Hi @thuybt , as this not dbt-dremio's fault, I will close this issue if you don't mind.
Would you please give the new adapter version a try ?
Best,


'Flemish' language entry is overriding 'Dutch' language

import countryData from 'country-data';
console.log(countryData.languages.nl.name); //outputs Flemish instead of Dutch
This is because the languages.csv file has the entries Dutch and Flemish with identical values alpha2=nl
alpha3=nld
bibliographic=dut
I suggest removing the Flemish entry since Flemish it's considered not a language but rather an adjective/thesaurus to define Dutch dialects.
Dutch is the correct English word to define the Dutch language spoken in both The Netherlands and Belgium.
I can prepare a Pull Request with the Flemish entry removed from the languages.csv file.

@giorgio-zamparelli
could you make a pull request to
https://github.com/Sonatrix/country-list
regarding this issue

Hi @Sonatrix! Has @evdb abandoned this repository permanently and country-data-list is the main fork under development?!

Hi @giorgio-zamparelli ,
@evdb is not maintaining this library anymore, I created a fork of it and maintaining it.


Add wrapper for GDALGetRasterUnitType

[X] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

I've added a wrapper for GDALGetRasterUnitType into rasterband. Since I had no test file that has a unit, I added a test file from the original GDAL repo:  https://github.com/OSGeo/gdal/blob/96096ae1e61b1b7afdc686ab9a00ca4fee772ba6/autotest/gdrivers/data/usgsdem/114p01_0100_deme_truncated.dem

Wow, I love the undelimited numbers in that .dem file.

Wow, I love the undelimited numbers in that .dem file.

If you have another file at hand with a unit, I can use it. I just got one from the osgeo gdal repo.

If you have another file at hand with a unit, I can use it. I just got one from the osgeo gdal repo.

No, it's fine, I was just surprised that GDAL actually parses that.

I'll wait a bit, then merge this, it's pretty trivial.

@bors r+

bors r+


Error when running flutter build ios --release

If you press the run button in xcode to run it as debug, it builds without problems.
However, when I run the app with the flutter ios build --realeaes command in the terminal, a crash error occurs.
This is the crash error log of my app.
Flutter crash report.
Please report a bug at https://github.com/flutter/flutter/issues.
command
flutter build ios --release -v
exception
FormatException: FormatException: Missing extension byte (at offset 16)
#0      _Utf8Decoder.convertChunked (dart:convert-patch/convert_patch.dart:1893:7)
#1      _Utf8ConversionSink.addSlice (dart:convert/string_conversion.dart:314:28)
#2      _Utf8ConversionSink.add (dart:convert/string_conversion.dart:310:5)
#3      _ConverterStreamEventSink.add (dart:convert/chunked_conversion.dart:72:18)
#4      _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:111:24)
#5      _rootRunUnary (dart:async/zone.dart:1434:47)
#6      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
#7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
#8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
#11     _StreamController._add (dart:async/stream_controller.dart:648:7)
#12     _StreamController.add (dart:async/stream_controller.dart:596:5)
#13     _Socket._onData (dart:io-patch/socket_patch.dart:2314:41)
#14     _rootRunUnary (dart:async/zone.dart:1442:13)
#15     _CustomZone.runUnary (dart:async/zone.dart:1335:19)
#16     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1244:7)
#17     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#18     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#19     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
#20     _StreamController._add (dart:async/stream_controller.dart:648:7)
#21     _StreamController.add (dart:async/stream_controller.dart:596:5)
#22     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1839:33)
#23     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1322:14)
#24     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#25     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
#26     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:122:13)
#27     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:193:5)

flutter doctor
[✓] Flutter (Channel stable, 2.10.2, on macOS 12.1 21C52 darwin-arm, locale ko-KR)
    • Flutter version 2.10.2 at /Users/sinjeong-won/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 097d3313d8 (1년, 1달 전), 2022-02-18 19:33:08 -0600
    • Engine revision a83ed0e5e3
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/sinjeong-won/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.73.1)
    • VS Code at /Users/sinjeong-won/Downloads/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] VS Code (version 1.73.1)
    • VS Code at /Users/sinjeong-won/Library/Mobile Documents/com~apple~CloudDocs/Desktop/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • 신정원의 iPhone (mobile) • 00008020-001C646C3601002E • ios            • iOS 15.5 19F77
    • Chrome (web)         • chrome                    • web-javascript • Google Chrome 111.0.5563.64

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Closing this as a duplicate of https://github.com/flutter/flutter/issues/81666.
Kindly subscribe to the issue linked above for updates.
Thank you


Parameterize diagsettings for appservice

allow user to select what logs are included
less repeated code

Would something similar to what you're doing for the App Services deployment also apply to the Function App deployment as well?

Yes, that is true. The reasoning behind this is that the appServicePlan sku P1v3 is quite expensive (when testing / proof-of-consept), and is not able to scale down to sku B1 without first removing one dignostic setting only available to the premuim sku.
So both diagSettings and sku names is something I would like to choose myself as I'm deploying.

While that is true, I've done extensive testing and the Engine container is extremely resource intensive due to the numerous calculations it performs. Reducing the SKU is highly discouraged because it has a quite negative impact on the performance of the solution.
I'm not opposed to this, but perhaps we'll need some documentation explaining that while you CAN lower the SKU, we can only guarantee performance when using SKU's X/Y/Z, for example. I'm trying to avoid numerous GitHub issues related to performance when end users have knowingly chosen a SKU that will impact the performance of the IPAM solution.
I hope that makes sense...


Intermittent issues launching on Windows when using dual (heterogeneous) GPUs

Since I updated my desktop configuration to use both my Intel HD 4600 (on my Core i7-4700) and my discrete NVIDIA 635 GT OEM, roughly half the time I start Atom, I get an "Editor not responding" window. No other changes occurred at that time, and I did try re-installing with the installer from the web site.
Filing the issue here because I presumed it to be related to the GPU acceleration in the shell getting confused over which GPU to create resources on, since I had similar problems recently in my own code...

The "Editor not responding" dialog can occur for many reasons, but it has never been caused by hardware issues.

since I had similar problems recently in my own code

Can you say more about it?

Closing until more information is provided.

Sorry about the lack of follow up - so it happens when I try to open a second Atom window - the first one always opens fine, but the second one will sometimes (often) open to just the default background before giving the timeout.
My own code: http://osvr.github.io though the specific code I'm thinking of isn't open source - doing directx rendering for virtual reality headsets using some vendor-specific calls.
When I switched my system to the hetgpu setup, it revealed that the code was assuming that the NVIDIA adapter was the default adapter, and thus calling D3D11CreateDevice with a null first parameter, and D3D_DRIVER_TYPE_HARDWARE second parameter, to let Windows choose the default adapter when creating the device.
Instead, we needed to do some magic calls to NVIDIA, and/or DirectX, so that we'd end up getting a specific IDXGIAdapter. For safety, then, we always (though really only needed in multi-gpu setups) pass that in the first parameter and thus D3D_DRIVER_TYPE_UNKNOWN in the second parameter (because that's what Microsoft says you have to do if you pass in a non-null adapter pointer)


Permission denied

After a pip install I try
npc-engine run --models-path models --port 5555
I am greeted with
Traceback (most recent call last):
File "/home/lucky/miniconda3/envs/npc-engine/bin/npc-engine", line 8, in
sys.exit(cli())
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/click/core.py", line 829, in call
return self.main(*args, **kwargs)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/npc_engine/cli.py", line 78, in run_command
run(port, start_all, models_path, http, host)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/npc_engine/cli.py", line 93, in run
server = ZMQServer(context, control_service, metadata_manager, start_all)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/npc_engine/server/server.py", line 115, in init
super().init(zmq_context, service_manager, metadata, start_services)
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/npc_engine/server/server.py", line 44, in init
self.socket_ipc.bind(build_ipc_uri("self"))
File "/home/lucky/miniconda3/envs/npc-engine/lib/python3.8/site-packages/zmq/sugar/socket.py", line 214, in bind
super().bind(addr)
File "zmq/backend/cython/socket.pyx", line 540, in zmq.backend.cython.socket.Socket.bind
File "zmq/backend/cython/checkrc.pxd", line 28, in zmq.backend.cython.checkrc._check_rc
zmq.error.ZMQError: Permission denied

Could you please check permissions on the folder printed out by this command? Does npc-engine process has access to this folder?
python -c "import os, appdirs; print(os.path.join(appdirs.user_cache_dir('npc-engine'), 'self'))"

total 0
d????????? ? ? ? ?            ? .
d????????? ? ? ? ?            ? ..
s????????? ? ? ? ?            ? self

OK that was the problem I think ty


Use existing module for xml building?

Why not node-xml or other existing xml builder rather than implementing our own? Better testing coverage and more edge-cases probably already dealt with. Same for https://github.com/digidem/osm-p2p-server/blob/master/lib/h.js

I agree, this seems like a potential for all sorts of small and hard to notice errors.  I really want to use this lib for my user-facing osm project, but it would be a bigger risk, both stability and security-wise.  BTW (unrelated) - if possible, please include an example of parsing OSM API requests/responses. I suspect they should be fairly similar to file parsing.  Thanks!!!


Fractional Knapsack | C

Fractional Knapsack in C -
what will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding,

Please assign me this issue, I want to contribute to this.

I have solution of this problem. please assign this to me and also i have good knowledge of data structure and algorithm.


Book, don't run rust code snippets and update getting started

A typo fix and some small suggestions to the book.
Disables running of rust examples. They don't compile and the error output makes the page cluttery. The button is right next to the copy button and is easy to click:

Looks good, and thanks for the thoughtful comments so I knew what the point of each change was!


Add RemoteTech Redev Antennas from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of TaxiService, to add RemoteTech Redev Antennas to CKAN.
Mod details:
name = /mod/1929/RemoteTech%20Redev%20Antennas
author = TaxiService
abstract = Standalone and optional antenna package of RemoteTech Redev for Kerbal Space Program's stock CommNet
license = GPLv3
Homepage = https://forum.kerbalspaceprogram.com/index.php?/topic/139167-144
description = Standalone and optional antenna package of RemoteTech Redev for Kerbal Space Program's stock CommNet.
The art assets are not licensed to the general public and may not be redistributed without permission from their original creators.
Please direct questions about this pull request to TaxiService.

This was added in #6658.


requirements.txt file is missing

Hey, can you please add requirements.txt file to easily install the dependencies?

Sorry, I just noticed this. Added the requirements for client and server


Release 0.55.0

Codecov Report

Merging #813 (74d84b1) into main (dc94c2d) will decrease coverage by 24.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #813       +/-   ##
===========================================
- Coverage   53.57%   29.21%   -24.37%
===========================================
  Files         392      390        -2
  Lines       36905    30816     -6089
  Branches     8237     6386     -1851
===========================================
- Hits        19771     9002    -10769
- Misses      11071    19060     +7989
+ Partials     6063     2754     -3309

Flag
Coverage Δ

unittests-aries-vcx
29.21% <ø> (-24.26%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 246 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat: simultaneous git status and remote compare api calls

Description
Segregating api calls for status and remote
PR fixes following issue(s)
Fixes #26038
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

New feature (non-breaking change which adds functionality)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test sha=afa4b1c

@Parthvi12 I have added tests, you can review now

/build-deploy-preview

/ok-to-test sha=7ea28cb

/build-deploy-preview

@brayn003 On DP, when we open git sync modal, it takes less time to fetch status but there is no loader or other component stating that, is this expected?  Adding video for current behaviour in DP vs Release:
https://github.com/appsmithorg/appsmith/assets/80334441/ca8214e0-ee6b-4521-858c-4c535edd2674

/ok-to-test sha=6ac2bd8

/build-deploy-preview

/ok-to-test sha=321eef3

/build-deploy-preview

@Parthvi12 should be fixed now


Remove "grabber" icons

The grabber and grabber-small tier-1 icons have been replaced by dragger. We should remove the old ones in the next major release.

Repo is archived.


drivers/bch: Drivers may not support command BIOC_FLUSH

Summary
drivers/bch: Drivers may not support command BIOC_FLUSH.
Calling bchlib_flushsector() maybe enough on some devices.
Impact

drivers/bch (e.g. fsync() on bch device may returns failure without this patch)

Testing

Selftest with fsync()
NuttX CI

@Donny9 @chirping78 Could you review this PR please?


ClassToAPI.classCanonicalName spec

Let's keep this one open in case we decide to not change the behaviour in #381, we still merge the spec.

This makes sense. As there's no change in behaviour in this one, I'm merging it.


Error: Cannot resolve module react-native

When running flow I get the following error:
Error ┈┈ index.js:3:29

Cannot resolve module react-native.

     1│ /* @flow */
     2│
     3│ import { AppRegistry } from 'react-native';
     4│ import App from './src/App';
     5│
     6│ AppRegistry.registerComponent('myApp', () => App);

Found 1 error

Now, I don't care about checking that my code is calling in to libraries (like react-native) with the correctly annotated Flow types. So I don't need to import type libs for these external libraries. I simply want to get rid of this error, and just have Flow check my own code files for type errors (at least for now).
Is there a config option I can use to ignore these types of errors (which are not code errors)?

Add something like this to your .flowconfig:
[options]
module.name_mapper='^react-native$' -> '<PROJECT_ROOT>/src/react-native-dummy.js'

Contents of src/react-native-dummy.js:
// This is for Flow which complains about the missing module when it checks the RN code, which
// during ONE development is not needed to it is not installed. This module is configured as
// "react-native" module replacement in .flowconfig

declare export default {NativeModules: Object};

@lll000111 that worked perfectly. thanks!

This is the only option that has worked for me.

declare export default {NativeModules: Object};

Perfect!


when I want to clear cache by bust function, but the cache show more picture

I want to clear the picture in cache, but show double number of picture in the cache .seens like copyed again the source in the path

@firstBird-1 bust only re-downloads the image for the cache entry. It doesn't remove any files. Were you expecting a different behaviour?

So there is any function to clear cache or remove the image from cache?

@wcandillon I see the explain "The lifetime of this cache is the one of the running application".If I turn off the App, the Cache will be done with all the image deleted?

@firstBird-1 Not at the moment because I find this feature orthogonal. Image are stored in the iOS/Android cache folder and they have a lifecycle on their own.
@firstBird-1 yes for images cached with the mutable attribute.

@wcandillon Thanx~~

@firstBird-1 you're welcome, feel free to reopen if you have more questions.


--env tensorflow-1.4

Hello,
Sorry for bothering you, but I want to make sure that there will be no errors during the training due to the version of python.
You used --env tensorflow-1.4, which is py3.6 on Floyd.
I did the same, and I used the .sh files you provided.
But in object_detection-0.1\object_detection\utils\visualization_utils_test.py line 148 there is a syntax error, although the server completed the installation correctly as it seems when I tested it using the run_test.sh file, which gave me the same output I get when running it on my pc.
line 148 is:
print 'Writing output image %d to %s' % (i, output_file)
Which is py2.7 not py3.6 nor py3.5 (I am using)
I ran your command with adding :py2:
floyd run --env tensorflow-1.4**_:py2_** \
  --data junji/datasets/sushi_detector/1:data \
  "bash ./floyd/setup.sh && cp -R /data/* /output && sh ./floyd/train.sh"

And I got no errors.
So, will it effect the training later on?
Maybe it looks like a newbie question (I am), but I'm working on my senior project, and I wanna make sure that everything is right before starting the training, I cannot waste hours of training because I'm on budget ! :(

@AboHadi313
Sorry for the late reply. And thank you for trying my repo.
I think it will work fine if the run_test.sh which runs python -m object_detection.builders.model_builder_test without errors.
If you worry about your steps, I recommend you to train on your local machine to make sure if everything is working fine and then train further to Floydhub.
I hope this repo helped you.


Tp 651 retry upload on connectivity fail

This splits upload task into separate subtasks, for upload and notify.
This makes it easier to retry one of those parts if the other fails, and has the benefit of not blocking the task queue, if uploads fail.
In the detail -

Adds settings to control the exporter task retrying behaviour.
Encapsulates the data returned to the upload_transactions management command.
Ensure upload is safe, by locking the Envelope table in the upload task.

I think we are in need of some more high level documentation about how this system works and fits together, as I have lost track of the general shape here. I can see various objects in the system now and am not very clear on each of their intended responsibilities (e.g. RenderedTransactions vs EnvelopeTransactions…)
In particular I am also not very clear on UploadStatus and what it is used for, how these objects move around the system, and where they eventually end up.
I'm also not very clear on what happens when the tasks fail and would like to understand more about what state the system is left in when this happens, particularly around if the retry limits are exceeded. E.g. I'd like to understand whether we lose track of what things have been sent if the tasks fail, and if not how the system would pick these things up again. It would also be good to know how long the remote systems could be down for before the tasks are abandoned, given the current config.

This makes sense, there are quite a few moving parts + docs and a couple of small diagrams could clarify things.

Codecov Report

Merging #269 (74e79c5) into master (efae562) will increase coverage by 0.65%.
The diff coverage is 73.59%.

:exclamation: Current head 74e79c5 differs from pull request most recent head 26ad44f. Consider uploading reports for the commit 26ad44f to get more accurate results

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   89.25%   89.91%   +0.65%
==========================================
  Files         260      260
  Lines       12640    12777     +137
  Branches      944      965      +21
==========================================
+ Hits        11282    11488     +206
+ Misses       1174     1093      -81
- Partials      184      196      +12

Impacted Files
Coverage Δ

...xporter/management/commands/upload_transactions.py
0.00% <0.00%> (ø)

exporter/models.py
87.50% <ø> (+9.37%)
:arrow_up:

exporter/util.py
62.12% <53.70%> (+28.78%)
:arrow_up:

exporter/serializers.py
88.33% <62.50%> (+15.91%)
:arrow_up:

exporter/tasks.py
79.04% <72.34%> (+40.29%)
:arrow_up:

common/util.py
82.50% <86.66%> (+0.96%)
:arrow_up:

common/serializers.py
82.95% <100.00%> (+4.66%)
:arrow_up:

conftest.py
85.38% <100.00%> (+7.03%)
:arrow_up:

exporter/tests/test_exporter_tasks.py
100.00% <100.00%> (+57.69%)
:arrow_up:

settings/common.py
73.80% <100.00%> (+0.63%)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efae562...26ad44f. Read the comment docs.


ICU-695 - Fixing paragraph spacing for last child

Summary
ICU-695 - Fixing paragraph spacing for last child
Ticket Link
https://mattermost.atlassian.net/browse/ICU-695
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

@asaadmahmood Take a look at this PR https://github.com/mattermost/mattermost-webapp/pull/739
I think it does the same thing as this fix, but it is cleaner. I am assigning you to review and, if you think it is a better solution, assign @hmhealey to it as well.

Should we close this one then?


Highlight item is highlighting all items in inventory

Having an issue where the highlight item function only sometimes works. Searching for 'comb' for example will highlight all items until the 'b' is typed, while a search for 'spider' highlights all items, not just the spider eye:

Looks like the same issue was reported on the JEI issue page as well: https://github.com/mezz/JustEnoughItems/issues/1195
jei_1.12.2-<IP_ADDRESS>.jar
moreoverlays-1.13-mc1.12.1

#49

Fixed in e188322


ThrottleRequest breaks when trying to access undefined getAuthIdentifier method

Laravel Version: 5.5.3
PHP Version: 7.1
Database Driver & Version: -

Description:
If User Model do not implement the Authenticatable interface, the ThrottleRequests breaks at resolveRequestSignature when it tries to access undefined method getAuthIdentifier() from the $user property.
In our system, we uses Account to authenticate users, while User do not inherit the Authenticatable interface. It's working fine from 5.0 to 5.4, and it breaks when I upgrade to 5.5.3.
Suggestion:
Change the resolveRequestSignature in \Illuminate\Routing\Middleware\ThrottleRequests to cross check if it has implemented Authenticatable or not:
protected function resolveRequestSignature($request)
{
    if (($user = $request->user()) && $user instanceof \Illuminate\Contracts\Auth\Authenticatable) {
        return sha1($user->getAuthIdentifier());
    }

    if ($route = $request->route()) {
        return sha1($route->getDomain().'|'.$request->ip());
    }

    throw new RuntimeException(
        'Unable to generate the request signature. Route unavailable.'
    );
}

Will update the docs for this breaking change, but you should implement this interface in your Account model as per the docs: https://laravel.com/docs/5.5/authentication#the-authenticatable-contract

You are expecting developer to implement authenticatable when using ThrottleRequest? For our use case is that we have two type of users that one implements authenticatable (with username/password, global account) that translates to local user which does not implement it. If this is a won't fix then my only solution now is to extend ThrottleRequest and rewrite this method then. Thanks!

Ok will open a PR addressing that, you have a point. Thanks :)


Distributed training error multiple terminals

Thanks for your great work!
I want to train multiple instances concurrently in different terminals ,using the commands  following.
terminal 1:CUDA_VISIBLE_DEVICES=1 torchrun --nproc_per_node=1 --nnodes=1 --node_rank=0 training/exp_runner.py --conf confs/replica_objsdfplus.conf --scan_id 4
terminal 2:CUDA_VISIBLE_DEVICES=2 torchrun --nproc_per_node=1 --nnodes=1 --node_rank=0 training/exp_runner.py --conf confs/replica_objsdfplus.conf --scan_id 5
I also change the local_rank value.But it still has port error.
RuntimeError: The server socket has failed to listen on any local network address. The server socket has failed to bind to [::]:29500 (errno: 98 - Address already in use). The server socket has failed to bind to <IP_ADDRESS>:29500 (errno: 98 - Address already in use).
How can I correct the code ?

You can try to specify a new master port for each experiment (e.g. 60004& 60005):
CUDA_VISIBLE_DEVICES=1 torchrun --nproc_per_node=1 --nnodes=1 --node_rank=0 --master_port=60004 training/exp_runner.py --conf confs/replica_objsdfplus.conf --scan_id 4
CUDA_VISIBLE_DEVICES=2 torchrun --nproc_per_node=1 --nnodes=1 --node_rank=0 --master_port=60005 training/exp_runner.py --conf confs/replica_objsdfplus.conf --scan_id 5

Thanks for your quick reply，I will try later.


$emit in confirm dialog invalid

Version
2.6.10
Reproduction link
Steps to reproduce
parent code
<do-more @onreloadtab="reloadTab" :selectFolder="selectFolder">
methods: {
reloadTab:function(){
console.log('reload')
}
}
child code
.....
methods: {
async delete (row) {
let that = this
await this.$confirm("Are you sure to delete?", "confirm")
.then((config) => {
that.$emit('onreloadtab')
return
})
.catch(() => {
});
}
What is expected?
I tried to get the request sent by the child page from the parent page, but it was unsuccessful
What is actually happening?
why parent cannot get emit message

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.


after uploading json it doesnt load the next page for annotation

after uploading json it doesnt load the next page for annotation

I got this issue while running the application locally. please check if the training JSON file you are trying to load is valid.
I can see that there is a potential bug in the code which I intend to fix in few days, more on that later.

Thanks I will check the json
Regards,
Aarthi
On Sun, Jan 5, 2020 at 11:04 PM Rahul Jain<EMAIL_ADDRESS>wrote:

I got this issue while running the application locally. please check if
the training JSON file you are trying to load is valid.
I can see that there is a potential bug in the code which I intend to fix
in few days, more on that later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cdqa-suite/cdQA-annotator/issues/41?email_source=notifications&email_token=AFOPHUBJUYMRM6XKM2TODS3Q4IK27A5CNFSM4KBHOU5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEID3TTA#issuecomment-570931660,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFOPHUDISTCEW6U6ZWNT2WLQ4IK27ANCNFSM4KBHOU5A
.

Even i am getting the same issue , @rsjain1978 , i have created a sample j.son of the same Squad-1.1 version, still I am facing this issue:
Kindly help me in this or if there is any other way i can convert my text data into a proper squad format:


View disappears when cursor hovers/crosses the color map bar

When the cursor crosses or hovers over the color map bar the data in view disappears. Changing the LUTs or the values of the display range have no effect. Resizing the window in order to (naively) force a re-draw of the image view has no effect.
I'm using the following system:
sciview version: 0.4.1 built from main
OS: Ubuntu 24.04 LTS
CPU: i7-1185G7
GPU: Intel Iris Xe Graphics
Here's a short gif of the behavior:

oh interesting! i did notice a change when mousing over the colormap, but for me it didn't cause the volume to disappear but actually to just update to the currently selected texture.
@skalarproduktraum i think there were some recent optimizations in the TF editor. can they cause this?

This is already being addressed in https://github.com/scenerygraphics/scenery/pull/759
Once this is merged, we can make a new scenery release and fix this issue.


Fix generating links for gitlab repos in subgroups

Hey,
first of all, thanks for the great package. I found a minor bug when using it with gitlab repositories.
Gitlab allows creating subgroups, for instance here is one of the gitlab repostiories: https://gitlab.com/gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers . The source git path for that repo has many / signs:
git@gitlab.com:gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers.git

The regex that is used to substitute package url does not allow for that, it only allows single / sign in path. As a result, it generated a line like that for me:
| istruct/component-developer       | Downgraded | 0.5.2 | dev-feature/tools a463df1 | [Compare](git@git.mydomain.example.com:istruct/component/developer/compare/0.5.2...a463df1)    |

As you can see, it left the git@ part in the comparison link, because preg_replace pattern didn't match anything.
I propose a simple fix that allows / in repository namespaces.
Additionally, comparison links across forks like:
https://gitlab.acme.org/IonBazan/package/compare/3.12.0...acme:3.12.1

don't work on gitlab for me, they have slightly different syntax:
https://gitlab.acme.org/IonBazan/package/compare/3.12.0...3.12.1?from_project_id=27069907

Unfortunately, we cannot generate it without knowing internal numerical project id, so I propose to simply return null in gitlab links generator when project namespaces don't match.

Thanks @trakos! ❤

I appreciate the quick merge @IonBazan ! 🙇  Your change definitely makes sense, it's better to give link to the target release.


Send link to generated API review to PR pipeline caller

PR pipelines send request to APIVIew to create a review. APIView should send a link to the generated APIView as response.

@weshaggard  Can you please approve this change? @weidongxu-microsoft  needs this change to integrate SDK automation to generate review link comment.


This idea is good.

This idea was designed by me last year, I think that's good.
After this, Prometheus can be partitioned for data.
Prometheus 1.* version  the memory problem was prominent. The  data partition helps to solve the data redundancy problem.

This idea was designed by me last year, I think that's good.

Did you happen to share your idea anywhere back then? If there previous art in form of design documents or similar it would be interesting to see.

ping @barnettZQG

Closing due to no activity.


Add automated a11y testing

Suggested tools:

pa11y (we used this in 1.x)
aXe cli from Deque

Previous implementation: https://github.com/AusDTO/gov-au-ui-kit/blob/develop/test/pa11y.js


loading data using partition decorators by row timestamp field,

Hi,
1.How can I load data (using streaming - "table.insertAll") to a partition decorators
(https://cloud.google.com/bigquery/docs/partitioned-tables#loading_data_using_partition_decorators)
2. can I do it by providing field name from the data row (the field is in timestamp format ), and insert each row to the relevant partition by getting the date from the timestamp.
Thanks
Nir

Sorry for the delay, I'll look into this as soon as I can. You might get a quicker/better response by posting on StackOverflow. If you do post, please cross-link so others can follow along.

Closing as I believe we addressed this adequately here: https://github.com/GoogleCloudPlatform/gcloud-node/issues/1455
Let me know if that's incorrect. Thanks!


ErrorException in ParagraphsStrategy.php line 57: Undefined index: property

This error is thow when DOCUMENT_TEXT_DETECTION is applied, have any luck ?
$apiKey = "API_KEY";
$vision = new \Vision\Vision(
$apiKey,
[
// See a list of all features in the table below
// Feature, Limit
new \Vision\Feature(\Vision\Feature::DOCUMENT_TEXT_DETECTION, 1),
]
);
	$imagePath = public_path().'/uploads/1.jpg';
	$response = $vision->request(
		// See a list of all image loaders in the table below
		new \Vision\Request\Image\LocalImage($imagePath)
	);

Hi there,
Sorry that this has taken me this long. This has just been added to the 1.8.0 release.
Thanks for reporting.


Refactor to use FastAPI instead of Flask

This change replaces Flask with FastAPI.
This is a non breaking change from a user perspective.
Two new URLs are added:

/api/docs for Swagger UI
/api/redoc for redoc documentation of the newly generated OpenAPI specs

@fliiiix I've documented the API doc endpoints in the getting-started ;)


feature request: notification when account is linked

It would be useful if ACM sent a notification to the consortium helpscout email address when a user links their account and can be added to groups.

@wkirdp this might be a good issue for you to work on. I think the steps would be:

Add a setting ANVIL_ACCOUNT_VERIFY_NOTIFICATION_EMAIL
If setttings.ANVIL_ACCOUNT_VERIFY_NOTIFICATION_EMAIL is set, after a user verifies an account with views.AccountVerify send an email to the email specified in settings.ANVIL_ACCOUNT_VERIFY_NOTIFICATION_EMAIL.
Add a test to check if the email is sent when settings.ANVIL_ACCOUNT_VERIFY_NOTIFICATION_EMAIL is set.
Add a test to check if the email is not sent when settings.ANVIL_ACCOUNT_VERIFY_NOTIFICATION_EMAIL is not set.
Update documentation.


fix: bug 1771 negative entiites shouldn't be addable in action creator

:tada: This PR is included in version 0.329.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support continuous ragged array as output option

Continuous ragged arrays do not require netCDF4 functionality. They also support software languages where netCDF4 ragged arrays are hesitantly supported (i.e. Fortran).
See #11 for discussion.

Added an option to write_netcdf for the CFGeometryCollection for using continuous ragged arrays: https://github.com/bekozi/netCDF-CF-simple-geometry/blob/0ba22c077daf61f0dfdb2fbf697dc60f4508ecd4/src/python/ncsg/geometry/base.py#L57.


Fullscreen back button event on Android.

Is there any event for backbutton when exit full screen on Android?
Clappr.Events.CONTAINER_FULLSCREEN doesn't fire this way. Thank you.

As a hotfix I started to watch fullscreen class with setInterval(). Checked the clappr.js file and it looks like there is method enableResizeObserver with setInterval() too, so no sign of the proper listener here too.

hey @GeorgySerga I think it makes sense to have a EXIT_FULLSCREEN event, do you mind submitting a PR with it?

Sure @flavioribeiro , I wanna try. I'll think of the way to do it and write my thoughts/questions here, or submit a PR itself to judge. Thank you.

Issue closed due to inactivity.


[SEDONA-338] Refactor Raster Construction to use AffineTrasform instead of Envelope

Did you read the Contributor Guide?

Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?

Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-338. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?

Refactor Raster Construction

How was this patch tested?

Verified existing tests

Did this PR include necessary documentation updates?

No, this PR does not affect any public API so no need to change the docs.

I've taken over this task and submitted https://github.com/apache/sedona/pull/940.


feat: Add onBeforeSignIn hook

This will allow the user to store the current url to return to after signing in
Also allow non async functions in onSignIn/Out

Awesome! Maybe you could describe the usage of this? I'll accept it right away, but it would be nice to see some real-world examples of it in use!


Add new clock face CLI Clock Enhanced

This is a version of the existing clock face with some changes and enhanced for the Bangle JS2 with a bigger time label and margins adjusted to reduce screen space wastage

Thanks! Any reason for the closure, or was it accidental?


Xtensa: basic ESP32 flashing

This PR makes probe-rs able to flash Xtensa-based ESP32 MCUs. The flash loader algorithms are very simple, very hacky, and they also ignore the stack pointer provided by probe-rs. The flashing process at the moment is very slow and only tested on the ESP32-S3.

A bit of status report / note to self:

resetting the core through XDM != resetting the system using the probe. The former leaves the WDT uninitialized, but the latter can bring the system out of weirdly inconsistent states a bit better (i.e. probe-rs reset should maybe do a probe reset?)
probe-rs can now correctly erase the device
downloading data seems to ignore data_section_offset. The cleanest way to support Xtensa devices seems to be splitting up their flash algos into two parts - an instruction part (loaded to load_address), and a data part, loaded to either data_section_offset or some third address. We need this, because not every instruction may load data from IRAM, and probe-rs current downloads data into IRAM, leading to the program function to freak out.

This is now ready. The flash loaders need to be tested on ESP32 and S2, as I don't have hardware with me and there's a chance they might end up in exceptions at the moment.

I haven't done a review of the code yet, but I'm happy to say I can flash one of my esp32s3 boards! One didn't work, one with octal spi, so I would imagine we have to modify the flash loader to support this.
I think for the initial impl we can just focus on the esp32s3, as its the only Xtensa chip with a espusbjtag, which makes it the easiest to work with. We can follow up with esp32 and esp32s2 support in another PR.

We need to remove the ESP32 due to the potential destructive aspects, and I'm unsure enough about the S2 to just yank it. Happy to re-add, though

We need to remove the ESP32 due to the potential destructive aspects

It's only destructive if we try and flash though, right? I'm suggesting leaving the yaml with everything but the flashing algo.

It's only destructive if we try and flash though, right?

every time it resets with an incorrect TDI level, it's possible that a 1.8V esp32 goes up in smoke. It's not flashing-specific

Ah okay, fair enough, lets just keep this simple with esp32s3 only for now.