extract print_stats method, add printing for diff_tables

I have a use-case where it's nice to have similar output to cli --stats while using the data_diff Python package. To accomplish this I did the following:
I extracted the print logic in main to a method under DiffResultWrapper
Added flags/logic to diff_tables to use print method

Hi, I'm okay with extracting print_stats(), but yeah, this is too much code duplication. I'm sure it can be done with less code.

How about a shared _setup_table_diff() method in init.py?

If you look at diff_table.py, you'll see TableDiffer.diff_tables() returns DiffResultWrapper. Maybe you should move the print logic as a method if it?

If you look at diff_table.py, you'll see TableDiffer.diff_tables() returns DiffResultWrapper. Maybe you should move the print logic as a method if it?
i.e. diff_wrapper.print_stats(json=json_result, ...)

updated

Don't you think it's better if diff_tables() got a print_stats boolean argument?

Don't you think it's better if diff_tables() got a print_stats boolean argument?

I do think that would be better, we'd have to change the current return type though since the print method iterates through the diffs

I think I fixed the table name collisions:
    unittest-parallel -v -s . -p test_api.py
Running 3 test suites (3 total tests) across 3 processes

test_api_print (test_api.TestApi) ...
test_api (test_api.TestApi) ...
test_api_print_json (test_api.TestApi) ...
test_api_print_json (test_api.TestApi) ... ok
test_api_print (test_api.TestApi) ... ok
test_api (test_api.TestApi) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.399s

OK

@erezsh I'm going to rework this to return json or a string. But close to complete

Why not make two methods, one for text and one for JSON? They can use a shared method of computing the particulars.

Why not make two methods, one for text and one for JSON? They can use a shared method of computing the particulars.

I guess I'm just not seeing the downside. It would make unit testing easier, but I the repo only contains functional tests currently (from what I've seen)

The downside is that it's less flexible. If in the future we'll want to add the option to produce a YAML (just for example), we'll have to turn the 2-tuple into a 3-tuple, which is more likely to break someone's code.
If it's done through separate functions, we can add as many as we like. The extra computation doesn't really matter, and if it does we can easily cache it.

The downside is that it's less flexible. If in the future we'll want to add the option to produce a YAML (just for example), we'll have to turn the 2-tuple into a 3-tuple, which is more likely to break someone's code.
If it's done through separate functions, we can add as many as we like. The extra computation doesn't really matter, and if it does we can easily cache it.

Good point, I'll extract methods

@dlawin In case you're stuck, the problem is with dict[str, int]. It's newer syntax, and isn't supported in Python 3.8 or below.
You just need to change it to Dict[str, int]


WIP: Document KEP 3157 (watch-list) for milestone 1.30

TODO: Document WatchListClient as well.

/remove language zh
/remove language hi

/remove-language zh
/remove-language hi

/hold
pending assignment of publication date
/sig api-machinery

Hello /sig api-machinery :wave: please provide a final review for this PR by March 26th 2024 18:00 PT to get this into the release. Thank you!
cc: @sftim

The streaming feature didn't make it to 1.30. Hopefully, the feature will be completed in the next release, and I will be able to update this PR.

/remove-area blog
I'll close the pull request. You are very welcome to open a new PR against the development branch for a future release (and to reuse the work you did here).
/close

Heads up that dev-1.31 branch is created now, if you choose to reopen this for the new release.


logo with siteRoot not working

Describe the bug
Hi,
I used the fauna example to create my docs. The only difference is using the siteRoot. It throws an exception during the docs generation.
Reproduction
import {fileURLToPath} from 'url'
import path from 'path'

function relativePath(target) {
    return path.join(path.dirname(fileURLToPath(import.meta.url)), target)
}

function markdown(string) {
    // Takes the first indent and trims that length from everywhere.
    // Markdown templates don't like the extra space at the beginning.
    const target = string[0]
    const trimSize = /^\s+/.exec(string)[0].length
    return target
        .split('\n')
        .map((line) => line.substr(trimSize - 1))
        .join('\n')
}

export default {
    introspection: {
        type: 'sdl',
        paths: ['./storage/app/lighthouse-schema.graphql']
    },
    website: {
        template: 'carbon-multi-page',
        output: './public/docs/',
        staticAssets: relativePath('public/assets'),
        options: {
            siteRoot: '/docs',
            appTitle: 'my GraphQL API',
            appLogo: '/logo.png',
            appFavicon: '/logo.png',
            siteMeta: {
                description: "my GraphQL API documentation.",
            },
            pages: [
                {
                    title: 'Welcome',
                    content: markdown`
                        # 👋 Hi
                        Welcome to my GraphQL API documentation.
                      `,
                }
            ],
        },
    },
}

Logs
✓ built in 44.87s
  301 /docs -> /docs/welcome
file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:53
                                        throw new Error(format(details));
                                              ^

Error: 404 /logo.png does not begin with `base`, which is configured in `paths.base` and can be imported from `$app/paths` - see https://kit.svelte.dev/docs/configuration#paths for more info (linked from /docs/welcome)
    at file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:53:12
    at visit (file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:185:4)
    at Object.fn (file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:175:22)
    at dequeue (file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/core/postbuild/queue.js:40:42)
    at file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/core/postbuild/queue.js:49:7
[vite-plugin-sveltekit-compile] Failed with code 1
✓ built in 1m 6s
error during build:
Error: Failed with code 1
    at ChildProcess.<anonymous> (file:///tmp/carbon-multi-page@3.6.0/node_modules/.pnpm/@sveltejs+kit@1.14.0_svelte@3.57.0_vite@4.2.1/node_modules/@sveltejs/kit/src/utils/fork.js:68:13)
    at ChildProcess.emit (node:events:513:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:293:12)
 ELIFECYCLE  Command failed with exit code 1.

System Info
System:
    OS: Linux 5.15 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (8) x64 Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz
    Memory: 4.94 GB / 7.62 GB
    Container: Yes
    Shell: 5.1.4 - /bin/bash
  Binaries:
    Node: 16.19.1 - /usr/bin/node
    npm: 9.6.4 - /usr/bin/npm

Severity
Annoyance

Hi @mostafa-rz. Thanks for raising this issue. You should be able to work around this issue by changing your appLogo and appFavicon to
appLogo: '/docs/logo.png',
appFavicon: '/docs/logo.png',

I believe the reason I did not append the base URL to this is because you could decide to use a full URL instead of a static asset (hosting the logo outside the website). I could add some logic to append the base URL in the current refactoring, but this might take a bit of time. I'm rather busy these days.

Thanks @pelletier197 for your response and it is working now.


arch/perf: modify the return value of up_perf_gettime to clock_t

Summary

arch/perf: modify the return value of up_perf_gettime to clock_t
clock/perf: add critical section protection

Impact
none
Testing
sim

[Experimental Bot, please feedback here]
No, this PR does not fully meet the NuttX Requirements.
Here's why and how to improve it:
Summary:

Missing "Why":  You haven't explained the reasoning behind these changes.

Why modify the return type of up_perf_gettime? What problem does it solve, or what improvement does it offer?
Why add critical section protection to the clock/perf code?  Is there a specific concurrency issue this addresses?

Lack of Detail:

"modify the return value..."  Be more specific. What was the old return type? What is clock_t and why is it more suitable?
"add critical section protection" Where exactly is this protection added? What specific race conditions were possible before?

Impact:

Unlikely to be "none":

Return Type Change: Changing the return type of a function almost always impacts users, as existing code calling that function may need modification.
Critical Section:  Adding synchronization primitives can have performance implications.

Testing:

Insufficient: "sim" is not descriptive enough. Which simulator? Which architecture?
Missing Logs:  You need to provide actual log output from your tests, both before and after the changes. This helps reviewers understand the problem you're solving and verify your fix.

How to Improve the PR:

Expand the Summary:  Provide a clear and concise explanation of the "why" behind your changes. Be specific about the issues being addressed.
Detailed Impact Analysis: Carefully consider all potential impacts, even if they seem minor.  For example:

Compatibility: Will existing applications break due to the return type change? If so, is there a migration path?
Performance:  Will the critical section introduce noticeable overhead in performance-critical code paths?

Thorough Testing:

Specify the exact simulator(s) and architectures used for testing.
Include relevant log snippets demonstrating the problem before the change and the correct behavior after the change.

Remember: A good PR focuses on clarity and providing reviewers with all the information they need to understand, evaluate, and merge your changes effectively.


SSR rehydration breaks when certain characters are present.

(Probably the title could be better)
Steps to reproduce:

Check out a fresh kit & npm install
Change config.addReducer('counter', counterReducer, { count: 0 }); in app.js to config.addReducer('counter', counterReducer, { count: 0, bogus: `
` });(there is a U+2028 character in the bogus key's string value)
npm run start
Navigate to localhost:8081
Observe failure to rehydrate and syntax error message in the console.

A PR with a fix will follow shortly

Apologies for the generic response, but I've released a new v3.0 kit, which has been re-written from the ground up.
It bumps the ReactQL stack to Webpack 4, React 16.4, Apollo Client 2.0, and adds Styled Components, full SSR (even in development), and has been re-written in Typescript. It's leaner, faster and has been brought completely up-to-date.
If you're still using ReactQL (and I appreciate you may not be, given the time lag in my response), I'd recommend checking out the new kit to see if your issue has been answered. If not, please feel free to post a new issue at https://github.com/leebenson/reactql


Add Ibc sample contract

Addresses #692
It builds  on some other items:
#711 to define the entry points we use (MERGED)
#716  to add stargate support and ibc entry points to the vm (MERGED)

[x] README of for ibc-reflect contract
[x] Implement basic logic
[x] unit tests
[x] integration tests working (with ibc vm calls)
[x] Address open TODOs

Note: a unit test brought up https://github.com/CosmWasm/serde-json-wasm/issues/27 but this is not blocked on that (it parses correctly in the vm code, and we never parse this type in contracts).

Okay, I think this is done (and a bit of refactoring for future contracts as well).
Happy for a final review, then I can merge it and use as a demo contract for wasmvm integration

Okay, I think this is done (and a bit of refactoring for future contracts as well).
Happy for a final review, then I can merge it and use as a demo contract for wasmvm integration

This should be ready for a merge now.
I will start integrating the last commit (
62b9fc7) into https://github.com/CosmWasm/wasmvm/pull/167

This should be ready for a merge now.
I will start integrating the last commit (
62b9fc7) into https://github.com/CosmWasm/wasmvm/pull/167


Upgrade Singular to 4.1.0.p3

The patches seem to be included in this patch-release already, so they can be dropped.
Note that some shared libraries provided by Singular change their version
number with this patch release (apparently they forgot to set their version
when they rolled out the original 4.1.0 release.)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


feat: batch primitive jobs in ParamShift gradients

Summary
This PR adds batching capabilities to the parameter-shift gradients. This results in a significant speedup for the backwards propagation step in Qiskit Machine Learning's QNNs. For example an EstimatorQNN with batch size 20 has a ~10x speedup:

Prior to this PR
After this PR

35s
3s

Details and comments

[ ] extend changes to other gradients
[ ] extract common code from gradients

Co-authored-by: @ElePT

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 22 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 84.545%

Totals

Change from base Build<PHONE_NUMBER>:
0.009%

Covered Lines:
62465

Relevant Lines:
73884

💛  - Coveralls


Tensor size not matched during training

After running the Training on Human3.6M steps in Experiments.md.
python -m torch.distributed.launch --nproc_per_node=1 \
       src/tools/run_fastmetro_bodymesh.py \
       --train_yaml Tax-H36m-coco40k-Muco-UP-Mpii/train.yaml \
       --val_yaml human3.6m/valid.protocol2.yaml \
       --arch hrnet-w64 \
       --model_name FastMETRO-L \
       --num_workers 1 \
       --per_gpu_train_batch_size 16 \
       --per_gpu_eval_batch_size 16 \
       --lr 1e-4 \
       --num_train_epochs 60 \
       --output_dir FastMETRO-L-H64_h36m/

I had encounter the following error
File "/hdd/input_pruning_exp/HMR_transformer/FastMETRO/src/modeling/_smpl.py", line 99, in forward
    v_posed = v_shaped + torch.matmul(posedirs, lrotmin[:, :, None]).view(-1, 6890, 3)
RuntimeError: The size of tensor a (480) must match the size of tensor b (16) at non-singleton dimension 0
Killing subprocess 5813

It seems like the v_shaped dimension does not match posedirs and lrotmin with a batch size 16. I had printed out the tensor size for v_shaped, posedirs & lrotmin for reference
v_shaped.shape = torch.Size([480, 6890, 3])
lrotmin[:, :, None].shape = torch.Size([16, 207, 1])
posedirs.shape = torch.Size([16, 20670, 207])

The files on SMPLify had been updated to version 1.1.0. The problem had been solve by finding and replacing the basic model back to 1.0.0 version.


Controller not detected: Logitech G920 Driving Force Steering Wheels

I am unsure about what I need to do to find out how to add this since I don't see any readme, but I'd be happy to provide the right information if someone can tell me what to run.
I am on Fedora Silverblue 35.

Hello @alvarlagerlof, my understanding is that the udev rules in this repo are to help Steam Input (a subsystem of Steam that allows for gamepad input remapping) and for VR equipment to have the hardware access it needs to work properly. As far as I know, support for steering wheels has not been implemented, so individual games need to handle input from wheels themselves, or via a middleware library like SDL or Proton.
Steam not detecting steering wheels should not be an indicator that it won't work in all games,

Okay, then maybe this is the wrong place. I don't know where to go really. I have these two games that I run in Proton, where the wheel does not work or show up. They both support the wheel in windows. Is there a better repo to make an issue?

Issues with games run with Proton are being tracked in compatibility reports on the Proton issue tracker, with one issue report per unofficially supported game title. Feel free to do a search for the affected games and add a note to the game's compatibility report.

If https://github.com/systemd/systemd/issues/22681 makes progress, then that might be a way to resolve this more generally than just for Steam Input.


How to update local state once async remote data arrived, without refreshing constantly?

When rendering a component,
I need a local state to update some elements involving interactive sub-components,
and the local state should be initialized by requesting remote serving data.
But, when I used use_future response data to update the local state variable, like following:
let a_state = use_state(&cx, || 0);
let res = use_future(&cx, (), move |_| {
    to_owned![url];
    async move {
        reqwest::get(url)
            .await
            .unwrap()
            .json::<MyModel>()
            .await
    }
});
let m0 = MyModel::default();
let model_info = match res.value() {
    Some(Ok(v)) => {
        a_state.set(v.id);
        v.to_owned()
    },
    Some(Err(err)) => {
        m0
    },
    None => {
        m0
    },
};

tracing::info!("model_info: {:?}", model_info);
tracing::info!("a_state: {:?}", a_state);

The local state variable a_state updated accordingly,
but this procedure ran on and on, with flooded flushed tracing infos.
While fortunately, there was just one successful HTTP GET record.
So, how can I set the local state just once time?
Thanks.

The issue is that you're calling .set in the render function, which schedules another render, indefinitely.
If you really must update the state, consider moving the .set inside the future's closure:
// inside the future:

// you'll have to `.clone` the `a_state`, and move the clone to use it here

let response = reqwest::get(url)
            .await
            .unwrap()
            .json::<MyModel>()
            .await;
a_state.set(response.id);

However, based on your code, I would recommend avoiding the additional state altogether. In this case, I think you can do something like:
let default_model = MyModel::default();
let model_info = res.unwrap_or(default_model);
let id = model_info.id;

Note that this will construct a new MyModel instance on every render. This might be expensive, so I would also suggest working directly with the Result<MyModel,_>, and handling the error case separately. Something like
match response {
   Err(error) => todo!("render error case")
   Ok(response) => todo!("render whatever")
}
// note: response.clone() and ::default() not needed at all

The issue is that you're calling .set in the render function, which schedules another render, indefinitely.
If you really must update the state, consider moving the .set inside the future's closure:
// inside the future:

// you'll have to `.clone` the `a_state`, and move the clone to use it here

let response = reqwest::get(url)
            .await
            .unwrap()
            .json::<MyModel>()
            .await;
a_state.set(response.id);

Fine description and nice suggestion!
Thanks indeed!


matrix_chain.py

It does the matrix chain multiplication problem with python.

Please read Contributing.md carefully and send a new PR that adheres to the guidelines given.


tikv-ctl: fix a modify-tikv-config usage tips error

Signed-off-by: mahjonp<EMAIL_ADDRESS>
What have you changed?

Fix a tikv-ctl subcommand modify-tikv-config usage tips error. When I operated tikv-ctl according to current usage tips, I got the usage help printed, this is because -h is the shortcut of --help.

What is the type of the changes?

Misc (other changes)

How is the PR tested?
manual test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

/merge


[Proposal] - API

I've had a (as-yet-private) conversation with a party interested in consuming a REST API from Symposium.
MVP, to me, would be read-only REST-style endpoints for talks, with oAuth2 authentication.
Thoughts? I'll probably spec something out but don't want to go too far into it until we have more conversations.

(ping @adamwathan @dhicking @besologic)

Yeah that sounds good to me, I think we need to hammer out exactly how it would work with revisions and versions though, so maybe this is a good time to figure out the best way for that to work.
Re: revisions, what's the goal for those? To be able to revert to a previous version if you realize you don't like the changes you've made?
Re: versions, I think we agreed we might be able to drop these right, and just encourage people to track different talk versions as different talks? I think that would be much simpler all around, even for the end user.
Would we want /talks to return a list of talks with titles (even though that can change per revision) and talk revision IDs, or just the full talk details for the latest revision? I'm tempted to say latest revision makes the most sense vs. exposing revisions as an API resource, or at least using the latest revisions info directly in the talk resource as far as the API is concerned, with a list of revision IDs if you really needed to access a previous revision through the API, but I think we can avoid making that a V1 thing.
I think this is enough to start with...
/users/{id}/talks
/talks/{id}

Yah, I think we dump the concept of showing revisions from the API--it only opens up the latest revision.
As to versions... Ugh. It is time to make that decision for sure.
Revisions is the ability to both see the history, but also to associate a submission (e.g. I submitted talk A to conference B) with a particular revision of the abstract in its history. Which one succeeded, etc.
I think /talks (and the entire API) only hits the current version of each talk. We could open a list of revision IDs on the talk and let that be query able later if we want, but I totally agree.
I agree RE: the endpoints. Assuming we drop versions. which I'm 98% the way to reaching. Let me ponder just a BIT longer...

Awesome :+1:
Re: versions, what sort of benefits come from keeping it as a real thing? Does it simplify managing your talk proposals at all, like would certain things be able to auto update across all versions saving you repetitive tasks, or anything like that? Or is it purely to "bind" separate talks together under one shared parent just to feel like it's more organized?
The main reason I'm pushing to punt on them at least for now is I think adding another level of drilling down or nesting is gonna hurt the UI a lot.
I would say lets try and see what we can build without them, and wait until it becomes obvious that they are gonna be a killer feature before building them back in?

RE: Versions, chat here: #48
I think it primarily just binds talks together. Can't think of any other benefit.
I think they're super complex for sure. I'm pretty much sold on dropping them.

Cat is out of the bag.
I have done some prototyping and PoC'ing and the concept works. So I'm working on Pronto! the CfP facilitator. http://rdohms.github.io/pronto/
Regarding the API stuff, yeah all i need is a list of talks and detailed info on them.
If you guys are dropping versions then its even easier for me to integrate that.
Of course Oauth is also something required.
This should be a nice way to take symposium to every single CfP tool, regardless of API's

Getting started in #84 (might be best to finish #82 first but not sure)

Initial feedback.
So i made a sample json from the talk properties. And tossed it into my filler... we got a good start.
Title and description went right in to OpenCFP. Now i need to work a bit on the notes and other fields.
We may want to think about the talk types and see if we can align them better with the usual options, i'll raise some stats on that.
In general the idea is to take away "most of the work" but still let you manually do a few more tweaked fields, like category, sponsor etc... so we are on the right track.

@rdohms Any news on those talk types?

@mattstauffer which ones? i was thinking regular, keynote, lightning, workshop.
But i need to go look at all different CfP's for matching types

@rdohms oh, sorry. In an earlier comment you had said "We may want to think about the talk types and see if we can align them better with the usual options, i'll raise some stats on that." Just wanted to see if you had a normalized list that you liked. :)

not yet, i was away for a week on vacation/conference with "please kill me" wifi only.. i'll get back to raising this.

@rdohms haha no stress at all! :)

Completed via #84


Resolving issue by returning Promise<[U]> instead Guarantee<[U]>

PromiseKit: 6.10.0 (or older version)
fix parameter matching confusion, which cause by:
on protocol Guarantee:
func mapValues(on: DispatchQueue? = conf.Q.map, flags: DispatchWorkItemFlags? = nil, _ transform: @escaping(T.Iterator.Element) -> U) -> Guarantee<[U]>
on protocol Thenable:
func mapValues(on: DispatchQueue? = conf.Q.map, flags: DispatchWorkItemFlags? = nil, _ transform: @escaping(T.Iterator.Element) throws -> U) -> Promise<[U]>

@ahmetgeymen - Any plans of merging this and releasing it soon? We are using CancellablePromiseKit and seeing this issue.

@ahmetgeymen - Any plans of merging this and releasing it soon? We are using CancellablePromiseKit and seeing this issue.

@mansibarodia10057 - I don't have any authority to accept this pull request. I'm not the owner of this repo. I just wanted to add fix done by @moshiwu to the original repo. We also use this library too.

Sorry for the delay, guys.
@ahmetgeymen Thanks for your PR! However, I have been working on the 0.3.0 version that fixes the issue. I just released it finally.
@mansibarodia10057 Time to run 'pod update' :)

@ahmetgeymen and @johannesd - Thanks! Able to build the app now after pod update.


Create LICENSE

Close #43

Needs a license = "BSD-3" line in Cargo.toml, and will need confirmation from the other contributors before merging (https://github.com/open-spaced-repetition/fsrs-optimizer-burn/issues/43#issuecomment-1698558590)

Thanks @asukaminato0721! Because approving a pull request is a little ambiguous, it would be great if you could confirm in a comment that you're happy to license your past contributions under the BSD-3 license.

I think it's ready to merge? All contributors have responded in their way.

I am happy to license my past contributions under the BSD-3 license.


Can't login with GenericOpenIdConnectBackend

I'm testing with the latest main branch, commit 40ea121f50cf23f38975e625289f9631dcf0dbb5.
SOCIAL_AUTH_OIDC_ENABLED_IDPS = {
    "FGAuth": {
        "oidc_url": "https://auth.example.com/", # Changed to "example.com" for privacy
        "display_name": "FGAuth",
        "client_id": "zulip",
        "secret": get_secret("social_auth_oidc_secret"),
        "auto_signup": True,
    },
}

After clicking the OIDC login button, and login with the ODIC provider, I was redirected back to
https://zulip.example.com/complete/oidc/?code=xxx&scope=openid+profile+email&state=xxx

Then redirected again to
https://zulip.example.cn/accounts/find/

Why am I not logged-in? Is the config wrong?
Thanks for the help!

@NexZhu Is https://zulip.example.com the subdomain where the organization you want to log into exists? And are you initiating login from the https://zulip.example.com/login/ page?

Yes, but I replaced my actual domain to example.com in the issue.
I deployed and I'm serving Zulip at https://zulip.example.com and initiating login from https://zulip.example.com/login/, my OIDC provider is serving at https://auth.example.com/, which is tested with many other apps.

@NexZhu Hmm, okay - could you check whether your browser sends the session cookie  when you get redirected back from  the IdP to https://zulip.example.com/complete/oidc/?

Yes, after redirected back, I got 3 cookies:
__Host-csrftoken
authelia_session
__Host-sessionid

Also, I inspected this the redirect request:
https://zulip.example.com/complete/oidc/?code=xxxxx&scope=openid+profile+email&state=xxxxx
It's status code is 302 and in the response header there's: location: /accounts/find/

@NexZhu Hmm, I'm out of the obvious ideas - we could try debugging further by inserting logging in some relevant places etc. - or would it be possible for you to setup  test client credentials with your oidc IdP that I could use to directly test this myself by setting up my own deployment with OIDC using those credentials? This looks fairly likely to indicate either a bug or some quirk of how this IdP does oidc (and ideally our code/documentation should be prepared for such quirks), so it'd be quite valuable for us to track this down.

Sure, Can I contact you by... maybe community Zulip?

Never mind, seems like it didn't successfully create the organization last time, after trying to create the organization again, I can login now.

Great, thanks for the update! Though if the organization was not properly created, how were you going through the "Login in" button? I wonder if there isn't something we should be improving here (or a bug with the login page being shown despite the organization not being created?)

Yes, the login page and the OIDC login button were there as soon as I first run the server, before I even tried to create the organization.


Hit Test for Irregular Shapes

I am developing a graphics application using Avalonia, which has a mouse drag function. During the process of dragging graphics with the mouse, I need to obtain other graphics that have collided. Currently, I have found that Avalonia only has point hit testing. I hope to add the hit testing function for irregular graphics. Thank you very much

@maoyy our hit-testing is not there for this purpose. It exists in order to test if a pointer has hit the shape.
Imo, while this is a valid request in your case, in 95% of each apps this is not even a thing. So I think this is something one should implement per App or in an own controls library rather than in Avalonia directly.

will mark this as an Idea to discuss about for now. If we decide its useful to add this API, this will be a feature request with proper description etc.


Should distributionGroupId be destinationGroupIds?

Looking through the source code, should the documentation mention destinationGroupIds rather than distributionId when the destination type is Groups?
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/AppCenterDistributeV3/appcenterdistribute.ts#L511

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da6643ac-ea32-1761-a7e9-0f17a3c0b8ee
Version Independent ID: 2442af0f-3f01-a91c-a98a-29c2f32d35b9
Content: App Center Distribute task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/app-center-distribute.md
Product: devops
Technology: devops-cicd
GitHub Login: @DavidStaheli
Microsoft Alias: dastahel

This feature 'destinationGroupIds' isn't working. No matter what value is used in this setting, the app is always distributed to the default 'Collaborators' group. To whom should I report the issue?

The documentation is wong!!! I spent hours on this problem. The devOps task AppCenterDistribute@3 would not drop the application in the specified group. No matter what I did, it would drop the release in the default (collaborators) group. It wasn't until I came across this case and the link to the source code that I figured it out. The documentation () states:
distributionGroupId - Destination IDs
Input alias: destinationGroupIds. string. Optional. Use when destinationType = groups.

The IDs of the distribution groups who will receive the build release. Leave it empty to use the default group, and use commas or semicolons to separate multiple IDs.

But if you look at the source code, the actual name of the property is: destinationGroupIds Emphasis on the 's'.


safer-destructive-actions: broken

Description
It has been broken for a while. See expected style in https://github.com/refined-github/refined-github/issues/410 and https://github.com/refined-github/refined-github/pull/5600
How to replicate the issue + URL
Here
Extension version
24.7.10
Browser(s) used
Safari
Token ⚠

[X] I set a token in the options page. I understand that some features require a token to work.

In some cases this is because there are 2 other empty elements next to it, so "there's no space".
I don't know what's supposed to appear there though. Since the element already has flex-wrap enabled, I think it's safe to set width: 100%


Your brand name on the email builder

Hey there,
I'm curious if your brand name is displayed on the email editor upon integration and usage. Additionally, could you confirm if it's compatible with Angular 17?
Thanks
Kiko
-LOOKING FOR MORE?
Waypoint is an email API service with a hosted 'pro' template builder with Markdown, dynamic variables, loops, conditionals, drag and drop, layouts, and more.

Hi, it does not (on both, EmailBuilder.js and on Waypoint).
Regarding EmailBuilder.js, the output you see on the playground is the exact output shown on the emails – and you can see and edit the HTML.

Thanks Jordani


Price field diplays 0 on accounts page.

Screenshots

Check Price and Tax fields in below images.
ON ecbsdev

On Live

Nice One. :)
TYpo mistake


:sparkles: [6.1 backport] Update Application import template

6.1 backport of https://github.com/konveyor/tackle2-ui/pull/788
Tag Type was renamed to Tag Category. Updating column names in application CSV import template. Column structure can stay unchanged.
Fixes: https://issues.redhat.com/browse/MTA-256

Thanks @ibolton336 :+1:


Create source jar with source-jar

At the moment the source jar is empty. We can populate it with the actual source

This is already the case :)


Installation Failed on Larave 11

Problem 1
- Root composer.json requires sagor110090/livewire-crud * -> satisfiable by sagor110090/livewire-crud[1.0.1, ..., 1.0.6, 2.0.0].
- sagor110090/livewire-crud[1.0.1, ..., 1.0.6, 2.0.0] require laravel/framework ^10.0 -> found laravel/framework[v10.0.0, ..., v10.48.4] but it conflicts with your root composer.json require (^11.0).

i updated for laravel 11 you can try

Thanks I will try and update

@sagor110090 its fixed


Keyboard delete button does not work on mobile

On mobile (iOS at least), I can't press the delete button when searching for classes.

Unable to reproduce


Picking photo at iOS 10.3.3 (14G60) causes MediaService.PickPhotoAsync exception: UIKit.UIKitThreadAccessException: UIKit Consistency error: you are calling a UIKit method that can only be invoked from the UI thread.

Bug Information
Version Number of Plugin: <IP_ADDRESS>-beta
Device Tested On: Apple iPad Pro 9.7 Wi-Fi 32GB MLMP2FD/A
Simulator Tested On: <not_tested_yet>
Version of VS: 15.4.3
Version of Xamarin: <IP_ADDRESS>71-pre2
Versions of other things you are using:
Steps to reproduce the Behavior
Invoke:
MediaFile mediaFile = await CrossMedia.Current.PickPhotoAsync();
pick photo from iOS gallery picker.
Expected Behavior
mediaFile object should be "mapped" to selected photo.
Actual Behavior
await CrossMedia.Current.PickPhotoAsync() throws MediaService.PickPhotoAsync exception: UIKit.UIKitThreadAccessException: UIKit Consistency error: you are calling a UIKit method that can only be invoked from the UI thread..
Full stacktrace:
https://gist.github.com/Szymaniuk/6af1d591b24615c474c406e093746290
Code snippet
https://gist.github.com/Szymaniuk/bf95acec554dc709b8d47e4d05df409f
Screenshots

Lol, I've just builded same code in REALSE mode, and it's working fine.
I'll try to rebuild again in DEBUG (where the issue occured) mode and try to reproduce it again.

Confirmed after cleaning and rebuilding - it's crashing at DEBUG mode again.

@Szymaniuk could you take a latest code from issue-393 branch and test it locally from the source to see if it fixes the issue for you

I've just moved to issue-393 branch, created DLL's locally, and unfortunately able to reproduce the issue:
https://gist.github.com/Szymaniuk/f15abb393b6ea4d74d08543aea54b80b

@jamesmontemagno , as I mentioned here https://github.com/jamesmontemagno/MediaPlugin/issues/393#issuecomment-344177355 , proposed fix is not working.

@Szymaniuk that's rather strange! I will take another look at it

@Szymaniuk I am not able to reproduce this. Could you put a break point here when debugging
https://github.com/jamesmontemagno/MediaPlugin/blob/198a3634b3b424f170408590a3323db62f88fd94/src/Media.Plugin.iOS/MediaPickerController.cs#L50

Yeah @Szymaniuk if you have the code, give us the line of code where it is blowing up.

@jamesmontemagno @prashantvc
UIKitThreadAccessException is throwing for me on line 30 of MediaPickerController.cs, which is called from line 51 of the same file.  Seems that setting Delegate must be done on the UI thread.

UIKitThreadAccessException - UIKit Consistency error: you are calling a UIKit method that can only be invoked from the UI thread.
Detailed Stack Trace..   at UIKit.UIApplication.EnsureUIThread () [0x00023] in /Users/builder/data/lanes/5520/51128b8c/source/xamarin-macios/src/UIKit/UIApplication.cs:88
at UIKit.UIImagePickerController.set_Delegate (Foundation.NSObject value) [0x00000] in /Users/builder/data/lanes/5520/51128b8c/source/xamarin-macios/src/build/ios/native/UIKit/UIImagePickerController.g.cs:456
at Plugin.Media.MediaPickerController.set_Delegate (Foundation.NSObject value) [0x00009] in /Users/cboehm/Projects/svn/[redacted]/iOS/temp/MediaPickerController.cs:30
at Plugin.Media.MediaPickerController.Dispose (System.Boolean disposing) [0x00037] in /Users/cboehm/Projects/svn/[redacted]/iOS/temp/MediaPickerController.cs:51
at Foundation.NSObject.Dispose () [0x00000] in ....

Issue goes away for me when I change line 51 of MediaPickerController.cs to the following:
InvokeOnMainThread(() => Delegate = null);
I'm using an iPad Mini on iOS 10.2.1, by the way.

@iupchris10 thanks for confirming this. James merged this fix few days ago

@prashantvc I'm afraid you may have misread my comment. I feel that the bug is still present even after the merge. It looks like in the commit that you fixed line 50, but line 51 needs run on the main thread as well.

I am getting UIKit Consistency errors in v<IP_ADDRESS>-beta.
Is it supposed to be fixed in that version?

@duzenko The issue is still occurring on some devices in the latest version. I committed a fix today but waiting for it to be merged. Stay tuned.

.188 beta appears to have fixed it


Zenodo models

The MLPerf inference models are residing in https://zenodo.org/communities/mlperf and there are duplicates in there. We need to clean-up the repo, along with GitHub.

I reviewed the page, see other issues, but don't see duplicates.

TODOs for me on the MobileNet quantized model: Apache 2.0 licensing, add an explanation of how the weights were defined, tag with MLPerf inference 0.5. Will close by 7/3.

I assume this is done @DilipSequeira ?

Yes.


Different colours for identifying Valid, Redundant and Invalid Restrictions

It would be great if we could have different colours to identify or differentiate between valid, invalid and redundant TR nodes or points, so that it becomes easier while adding, checking and validating.

Can be implemented via data driven styling


Rotated Box set to Zero on attribute change

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce

Open an task with existing rotated boxes, imported from a different CVAT user (say an external contractor, CVAT VIDEO format).
Change an attribute in an existing label-track.
The rotated box angle is reset to ZERO.
USER has to rotate the box again to the previous angle.

Expected Behavior
No response
Possible Solution
No response
Context
No response
Environment
server 2.1
core 5.0.1
canvas 2.13.2
ui 1.37

The version is too old, please submit bugs only from latest releases.
Try to upgrade.


Traefik-V2 Doesn't support Wildcard certificate generation By DNS-N1

Do you want to request a feature or report a bug?
Feature
What did you expect to see?

My Second question is:
It can generate a specific domain certificate by useing above configuration, But I have hundreds of domains,  It's impossible to generate a Wildcard certificate and How?

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

https://docs.traefik.io/https/acme/#wildcard-domains


Develocity: fix warnings

See the current pom.xml :

cc @atomfrede

@pascalgrimaud : I don't have the issue. Have you tried to allow IntelliJ to import the xsd from the xsi:schemaLocation (Alt+Enter on the xsd url in red)?

thanks @murdos, manually download external resource, fix the issue with IntelliJ


Support for Kibana 7.10.x

Hello,
Followed the instructions from here:
https://github.com/dlumbrer/kbn_network
and no joy, details of the errors below:
[<KIBANA_HOME>/bin]# ./kibana-plugin --allow-root install file:///home/ec2-user/kibana_plugins/kbn_network.tgz Found previous install attempt. Deleting... Attempting to transfer from file:///home/ec2-user/kibana_plugins/kbn_network.tgz Transferring 27818147 bytes.................... Transfer complete Retrieving metadata from plugin archive Error: end of central directory record signature not found     at /usr/share/kibana/node_modules/yauzl/index.js:187:14     at /usr/share/kibana/node_modules/yauzl/index.js:631:5     at /usr/share/kibana/node_modules/fd-slicer/index.js:32:7     at FSReqWrap.wrapper [as oncomplete] (fs.js:467:17) Plugin installation was unsuccessful due to error "Error retrieving metadata from plugin archive"
Any pointers appreciated to support Kibana 7.10.x
Cheers!

The support for Kibana 7.10.0 is now available at "releases" section

The support for Kibana 7.10.0 is now available at "releases" section


No consistency when using calibrate_camera_lidar.py

Hi,
I am attempting to use this package and among other issues, there is absolutely no consistency when running calibrate_camera_lidar.py and pressing enter to choose points. Sometimes I start the node, press enter and then I can select points, but then when I close the windows and select a new pose pressing enter does nothing. Sometimes I start the node and pressing enter does not bring up the windows and it's really annoying having to start and stop the node 5 times in the hope that it will work just to pick points for one pose. What could be causing this? How can I fix this?

I have the sam problem, how to fix it?

Apologies for the inconsistencies, this was developed a long time back and has not been maintained since. I'm working on a new version that uses Open3D point picker and hopefully should resolve these issues.


ADDING COOL DESIGNS

ADDING A TINCH OF DESIGNING MAY HELPS...WITH LOGIN OPTION AND SELF ASSESSMENT FORM

Thank you @Swastik200 but as of now, there's no need for a login/self-assessment form. Thank you closing here #15


Fix handling of query params and fragments in endpoint paths

What does this PR do?
Fixes handling of query params and fragments when getting the URL for a given endpoint.
What issues does this PR fix or reference?
Fixes https://github.com/devfile/devworkspace-operator/issues/713
Is it tested? How?
Test cases are included. Can be tested with reproducer from #713 :
kubectl apply -f https://eclipse-che.github.io/che-devfile-registry/main/devfiles/java-web-spring/devworkspace-che-code-insiders.yaml

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

/test v8-devworkspace-operator-e2e, v8-che-happy-path


feature support nested loop semi/anti join

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.95 seconds
load time: 469 seconds
storage size:<PHONE_NUMBER>1 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221113064349_clickbench_pr_45013.html


Automatically show tree when loading level

This would be the same as calling git gud show-tree right after git gud load X or git gud reset. Anything that loads the level

Hey, I'm going to start working on it


e2e: refactor utils into e2eutil/ pkg

@etcd-bot retest this please
weird failure..
# github.com/coreos/etcd-operator/vendor/k8s.io/kubernetes/vendor/github.com/docker/docker/pkg/term
exec: "gcc": executable file not found in $PATH
# github.com/coreos/etcd-operator/vendor/k8s.io/kubernetes/vendor/github.com/opencontainers/runc/libcontainer/system
exec: "gcc": executable file not found in $PATH
# github.com/coreos/etcd-operator/vendor/k8s.io/kubernetes/vendor/github.com/coreos/pkg/dlopen
exec: "gcc": executable file not found in $PATH
# github.com/coreos/etcd-operator/vendor/k8s.io/kubernetes/vendor/github.com/google/cadvisor/utils/cpuload/netlink
exec: "gcc": executable file not found in $PATH
FAIL	github.com/coreos/etcd-operator/test/e2e [build failed]
Fail! ===

Can we create a file (util.go) inside e2e pkg for now? i am not convinced we need to separate pkg.

@xiang90
We need to make them public for #348
It's too big a change. We'd better have this a separate PR.

It's too big a change. We'd better have this a separate PR.

I do not understand. Putting funcs into a different file instead of a different pkg results a smaller change.

@xiang90
So we change it to a different pkg as needed by another PR.
Disregards the "too big change" comment. Not very useful.

So we change it to a different pkg as needed by another PR.

Commented in that PR.

@xiang90
See #https://github.com/coreos/etcd-operator/pull/348 . It says its dependent PRs.

@hongchaodeng I mean I commented in that PR: https://github.com/coreos/etcd-operator/pull/348#discussion_r86704479

Close this in favor of #363


Add peewee ORM

I converted the queries using two styles:

The datasets query in a typical ORM style where you select everything you need and then convert it in Python code
The annotations query in a data mapper style where you just use the ORM as a query builder and get the output in dicts

Peewee's query support was more flexible than I expected, but PyCharm can't do very good type inference on it, so I got very little IDE help.
Benchmark
with db.connection_context():
  ds_ids = [id for id, in DbDataset.select(DbDataset.id).tuples()[:1000]]

print('## ds_old:')
%timeit -r 3 -n 1 [es._select_ds_by_id(ds_id) for ds_id in ds_ids]
print('## ds_new:')
%timeit -r 3 -n 1 [es._select_ds_by_id_peewee(ds_id) for ds_id in ds_ids]
print('## ann_old:')
%timeit -r 3 -n 1 [es._select_annotations_by_ds_id(ds_id, 22) for ds_id in ds_ids]
print('## ann_new:')
%timeit -r 3 -n 1 [es._select_annotations_by_ds_id_peewee(ds_id, 22) for ds_id in ds_ids]

# Validate (re-do queries because %timeit throws out assignments)
ds_old = [es._select_ds_by_id(ds_id) for ds_id in ds_ids]
ds_new = [es._select_ds_by_id_peewee(ds_id) for ds_id in ds_ids]
ann_old = [es._select_annotations_by_ds_id(ds_id, 22) for ds_id in ds_ids]
ann_new = [es._select_annotations_by_ds_id_peewee(ds_id, 22) for ds_id in ds_ids]
assert ds_old == ds_new
assert ann_old == ann_new

Results:
## ds_old:
154 ms ± 1.48 ms per loop (mean ± std. dev. of 3 runs, 1 loop each)
## ds_new:
416 ms ± 8.99 ms per loop (mean ± std. dev. of 3 runs, 1 loop each)
## ann_old:
1.89 s ± 7.41 ms per loop (mean ± std. dev. of 3 runs, 1 loop each)
## ann_new:
2.36 s ± 19.2 ms per loop (mean ± std. dev. of 3 runs, 1 loop each)

@intsco Several things make me want to ditch peewee and stick with SQL:

Peewee's docs aren't great. I spent a lot longer looking for answers related to common usage than I did with e.g. knex or TypeORM.
Inserting complicated trees of objects isn't any easier. I was hoping to be able to write:with db.connection_context():
    DbDataset(id='dataset1', name='new_ds_name', is_public=True).save()
    GqlDataset(id='dataset1',
               user=User(name='submitter_name',email='submitter_email'),
               group=Group(name='group_name', short_name='group_short_name'),
               group_approved=True,
               dataset_projects=[
                   DatasetProject(project=Project(name='proj1'), approved=True),
                   DatasetProject(project=Project(name='proj2'), approved=True),
               ]).save()

Instead I had to write:with db.connection_context():
    DbDataset.insert(id='dataset1', name='new_ds_name', is_public=True, config=ds_config).execute()
    GqlDataset.insert(id='dataset1',
                      user=User.insert(name='submitter_name',email='submitter_email').execute(),
                      group=Group.insert(name='group_name', short_name='group_short_name').execute(),
                      group_approved=True).execute()
    DatasetProject.insert(dataset='dataset1', project=Project.insert(name='proj1').execute(), approved=True).execute()
    DatasetProject.insert(dataset='dataset1', project=Project.insert(name='proj2').execute(), approved=True).execute()

Similar to TypeORM it's very painful mixing queries that have both Entities and plain data (e.g. selecting a dataset + the date of the last finished job)
Unlike any ORM I've seen before, when you try to access a many-to-one relation (e.g. gql_dataset.group) when that relation is null, instead of returning None it raises an error. This makes it frustrating to access nested fields in a nullable relation.

Looking at performance, however, I'd say peewee was completely acceptable. Extrapolating the above, it would only add ~6 minutes to the 6.5 hour job of reindexing all datasets.

Per discussion, some lessons were learned, but without support for Python type hints the cost of adding peewee as an ORM outweighed the benefit.


Cannot import ENCODERS_BY_TYPE

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I am migrating my code from V1 to V2. In my V1 code, I modified ENCODERS_BY_TYPE to turn bson ObjectIds. I can no longer import ENCODERS_BY_TYPE, how should I fix this issue?
Example Code
from pydantic.json import ENCODERS_BY_TYPE
from bson import ObjectId
ENCODERS_BY_TYPE[ObjectId] = lambda v: str(v)

Python, Pydantic & OS Version
"
             pydantic version: 2.5.2
        pydantic-core version: 2.14.5
          pydantic-core build: profile=release pgo=true
                 install path: /home/tom/miniconda3/envs/routingdeploy2/lib/python3.10/site-packages/pydantic
               python version: 3.10.0 (default, Mar  3 2022, 09:58:08) [GCC 7.5.0]
                     platform: Linux-6.1.11-76060111-generic-x86_64-with-glibc2.35
             related packages: email-validator-2.0.0.post2 typing_extensions-4.8.0 pydantic-settings-2.1.0 fastapi-0.105.0

As a direct replacement, you can do the following on V2:
from bson import ObjectId
from pydantic import BaseModel, ConfigDict

BaseModel.model_config["json_encoders"] = {ObjectId: lambda v: str(v)}

class Item(BaseModel):
    model_config = ConfigDict(arbitrary_types_allowed=True)

    id: ObjectId

item = Item(id=ObjectId("5ff1e194b6a9d7a5f9a2741c"))
print(item.model_dump_json())

I'll leave this issue open till we document it. 🙏

As a direct replacement, you can do the following on V2:
from bson import ObjectId
from pydantic import BaseModel, ConfigDict

BaseModel.model_config["json_encoders"] = {ObjectId: lambda v: str(v)}

class Item(BaseModel):
    model_config = ConfigDict(arbitrary_types_allowed=True)

    id: ObjectId

item = Item(id=ObjectId("5ff1e194b6a9d7a5f9a2741c"))
print(item.model_dump_json())

I'll leave this issue open till we document it. 🙏

Hi, I'd like to work on this documentation issue. Thank you

@bL34cHig0,
Go for it! Thanks! I'll review your work.

@bL34cHig0,
Go for it! Thanks! I'll review your work.

@sydney-runkle Thank you for assigning me this issue.
Just for clarification, do I add the workaround code to the Migration Guide in the docs?
from pydantic import BaseModel, ConfigDict

BaseModel.model_config["json_encoders"] = {ObjectId: lambda v: str(v)}

class Item(BaseModel):
    model_config = ConfigDict(arbitrary_types_allowed=True)

    id: ObjectId

item = Item(id=ObjectId("5ff1e194b6a9d7a5f9a2741c"))
print(item.model_dump_json())

@bL34cHig0,
Yep, the migration guide would be an appropriate location for this!

@sydney-runkle
I appended the workaround code to the Migration Guide with a little explanation.
Could you please take a look before submitting a PR?

@bL34cHig0 The explanation should be a general explanation for replacing ENCODERS_BY_TYPE rather than the specific example for instances of ObjectId

@bL34cHig0,
Looks good overall! Feel free to open a PR and I can provide some more detailed feedback there 👍. Thanks!

Thanks @sydney-runkle, will do that right away!


1.43.25 is very unstable，it often crashed inside！

i update the package 1.43.25 at lastweek，and my users said to me，the program often crashed on windows 10
i use try catch，but it not worked
i use Windows Event Viewer to find the issues，it point to pyMeow.pyd
the pyMeow will crashed inside
it maybe about “nimraylib_now“ i think
“nimraylib_now“ The project will no longer be maintained,and i cannot download it for reCompiling pyMeow
at last i uninstall 1.43.25 version and use 1.27.15 instead！
it is a good idea for using raylib，but if the project is not stable，i will use raylib for python instead！

i will never use this package again and  i will tell everyone i know about your repley

Feel free to not use this library. Thank you.


Error on filter when not exist a value

when applying a filter from a host that exists, only the selected host is returned.

when applying a filter from a host that doesn't exist, all metrics for the hosts are returned.
this problem happens in the combinations below
grafana 8.4.0
plugin 4.2.5
grafana  8.2.6
plugin 4.2.1

this problem happens in the combinations below
grafana 8.4.0
plugin 4.2.5
grafana  8.2.6
plugin 4.2.1

When the host does not exist, the Group filter is being ignored... Palliatively if set the Application filter to null and Host that does not exist return No data...

I was able to reproduce this in my instalation:
Grafana: v8.2.6
zabbix-plugin 4.2.5
zabbix: v5.0.19

Same problem on grafana 8.3.7, zabbix 5.2.7 and plugin 4.2.5

Hi! Looks like the same issue as #1427. So it's fixed and will be included in next patch release.


Turning into u map

Codecov Report

Merging #195 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   89.68%   89.71%   +0.02%
==========================================
  Files          87       87
  Lines        3489     3489
  Branches      659      755      +96
==========================================
+ Hits         3129     3130       +1
+ Misses        357      356       -1
  Partials        3        3

Impacted Files
Coverage Δ

src/singlepage/UMAPVisualization.tsx
76.38% <83.33%> (+0.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2920823...d830b06. Read the comment docs.


Global Agents

Think about having agents globally available to all molecules.

Since they are globally available, it means they can't really be molecule aware, if they're not molecule aware, there would be no advantage you could just use a js map and be done with it.


Pass headers with sendFile request

You could remove build for 0.8 and add build for 0.11 with allowed_failure. What do you think?

doing this now.
@frankrousseau : do you want to support node 0.8 with request-json-light ?

@aenario no :)


Embedding HydroShare in an iFrame as in HydroLearn does not work on a Chrome Browser.

The screen shot below is from a Page in HydroLearn, where HydroShare has been embedded in iFrames shows no content, in Chrome.  It works in Firefox.
See https://edx.hydrolearn.org/courses/course-v1:Utah_State_University+CEE6400+2019_Fall/jump_to/block-v1:Utah_State_University+CEE6400+2019_Fall+type@vertical+block@fc08f6dfe6c34b3fa1d3846f82390fb0 if you want to reproduce.
This may be to do with different Browser cookie settings, but it would be good to understand to advise users if this is the case.

Duplicate of #4043

Closing as duplicate but refer to #4043


tensorflow.python.framework.errors_impl.NotFoundError: ; No such file or directory

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mac OS Sierra 10.12.6
TensorFlow installed from (source or binary):
source
TensorFlow version (use command below):
1.4.0
Python version:
python3
Bazel version (if compiling from source):
sorry, I don't know
GCC/Compiler version (if compiling from source):
sorry, I don't know
CUDA/cuDNN version:
sorry, I don't know
GPU model and memory:
radeon pro 560 4G

Describe the problem
I try to use object detection using tensorflow API
I follow this youtube
https://www.youtube.com/watch?v=JR8CmWyh2E8
but there is a error
Source code / logs
MacBook-Pro-de-Jongwun:~ jongwuni$ cd /Users/jongwuni/Documents/Jongwunibang/Neural_network/models
MacBook-Pro-de-Jongwun:models jongwuni$ cd object_detection
MacBook-Pro-de-Jongwun:object_detection jongwuni$ python3 train.py --logtostderr --train_dir="/Users/jongwuni/Documents/Jongwunibang/Neural_network/models/object_detection/training" --pipline_config_path="/Users/jongwuni/Documents/Jongwunibang/Neural_network/models/object_detection/training/faster_rcnn_inception_resnet_v2_atrous_coco.config"
Traceback (most recent call last):
File "train.py", line 163, in
tf.app.run()
File "/anaconda/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "train.py", line 106, in main
overwrite=True)
File "/anaconda/lib/python3.6/site-packages/tensorflow/python/lib/io/file_io.py", line 385, in copy
compat.as_bytes(oldpath), compat.as_bytes(newpath), overwrite, status)
File "/anaconda/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line 473, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: ; No such file or directory

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Exact command to reproduce

@jongwun  did you fix the issue?
Thanks

I met the same issue. Has anyone fixed this yet? Thanks

@thanhtu19392  are you using external HDD as a path or storage?

I fixed the error. It's an error from my side. Thanks anw

@thanhtu19392 I'm having this error - how did you fix it?


add all metadata in enterobase to blazegraph

this can be seen as a followup to https://github.com/superphy/backend/issues/210

For future reference, case we ever need it:
ubcsamsung [5:32 PM]
Hi Kevin

kevin [5:33 PM]
Howdy

ubcsamsung [5:33 PM]
Could you tell me how you get the filename when you download the genome data from enterobase?

[5:33]
There seems to be some mismatch

kevin
[5:34 PM]
Hmm

[5:34]
so we take the `barcode` value under the `experiment` dictionary as the filename

[5:35]
(after appending `.fasta`

[5:35]
There are checks for files which aren’t assembled or are not found on enterobase

[5:35]
Namely lines `52` and `9`

[5:36]
can you elaborate on the mismatch?

ubcsamsung [5:37 PM]
We are trying to match the serotype data from enterobase to the genome we have

[5:37]
For example

[5:38]
Hmm give me a sec

kevin
[5:38 PM]
If im not mistaken

[5:39]
this would be related to the difference between the `barcode` name in the `experiment` dicts vs the `strains` dict

ubcsamsung [5:39 PM]
yes

kevin
[5:39 PM]
for example, under `strains`, this might be `'ESC_AA7740AA` and `ESC_CA1647AA_AS` under `experiment`

ubcsamsung [5:40 PM]
there seems to be some difference between assembly barcode and just barcode

kevin
[5:41 PM]
try backtracing the `barcode` in `experiment` to its `id`

[5:42]
this should give you a match to the row in `strains`

ubcsamsung [5:42 PM]
where is the experiment file?

kevin
[5:42 PM]
ie., barcode `ESC_AA7740AA` and `ESC_CA1647AA_AS` both use id `7740`

[5:43]
you can start up a python interpretive environment (or use a script, if you’d like) and run
```    r = requests.post('http://enterobase.warwick.ac.uk/get_data_for_experiment', data=options)
    d = r.json()
    # d.keys()
    # [u'strains', u'experiment']
    strains = d['strains']
    experiment = d['experiment']```

[5:43]
after running `import requests`, ofc

ubcsamsung [5:45 PM]
options is?

kevin
[5:45 PM]
ah right sorry

[5:45]
this is from https://github.com/superphy/backend/blob/master/scripts/enterobase.py
GitHub
superphy/backend
Semantic superphy backend for distributing predictive genomics tasks

[5:45]
where
```    options = {
        'no_legacy':'true',
        'experiment':'assembly_stats',
        'database':'ecoli',
        'strain_query_type':'query',
        'strain_query':'all'
    }```

[5:46]
just mimicks the behavior of the `GET` request

Tests are passing as of https://github.com/superphy/backend/commit/e6aa5b75dd322b12bd338bffb55592ec23fb239a

Example of the metadata file expected is provided in https://github.com/superphy/backend/blob/218-metadata/app/tests/example_metadata.xlsx
Will test via reactapp now.

PR in https://github.com/superphy/backend/pull/251

Merged, closing issue.


Non-optimized post-processing may be broken

@kajiglet  (internal erosion) and @tweigand (density dependent flow) have seen some velocity fields that should have been 1d but had some corner effects near the boundary.
We need to check Larson-Nicklasson examples to make sure still working at least

I found that pwl-bdm does't work in parallel in general, but I'm not sure it was ever designed to. pwl-bdm-opt does. I think we just need to update/cleanup/test proteus.PostProcessing. I'd like to add ('grad(velocity)',ci) and ('div(velocity)',ci) calculations as well, when we do that.


Updated default version of VegaLite

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   93.88%   93.88%
=======================================
  Files          14       14
  Lines         180      180
  Branches        8        8
=======================================
  Hits          169      169
  Misses         11       11

Impacted Files
Coverage Δ

...com/coxautodata/vegalite4s/providers/package.scala
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc7f11...b1aa878. Read the comment docs.


Feature request: Marginal benefit for equipment evaluation

I would love to have a view that shows the DPS benefit of e.g. 1 Strength vs 1% attack speed vs 1 added phys, etc. I calculate them by hand right now, and use them to generate weights for putting into poe.trade.

Duplicates #146.


warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>

Could you upgrade to React 16 ? :)

@wwwtyro

Hm. I'm not quite sure, doing that without a major version bump would cause the same kind of warning for all legacy projects that use dis-gui - in my case a couple - and they would complain to please upgrade react 16, which is of course not that easy in a grown/legacy project without upgrading a bunch of other react-* libraries, which in turn might have undergone breaking changes etc.
I think it's not worth it right now without any other changes or improvements, and that bumping to v3.0.0 for just the react 16 change is also not worth it.
I think that, ideally, one would spend some quality time with the codebase, tackle https://github.com/wwwtyro/dis-gui/issues/5 and https://github.com/wwwtyro/dis-gui/issues/9, then both bump the react dependency version to 16 and the dis-gui version to 3.0.0.
@wwwtyro What's your opinion on this?
@Aarbel I guess you know that it's just a warning and nothing serious, thus the smiley in your initial request.. I hope you're not too disappointed with my response and you understand the reasoning behind it?
Actually, I will have some time in the second half of February and I might use it to tackle all of this, but I can't promise..

@loopmode, i agree it's not a major maintenance issue.
Right now dis-gui is working in a React 16 environment without throwing errors.
Thanks a lot for your work !


Late Join Spawning Is Goofed

Description
Spawned late join QM. Expected to be at arrivals. Was at station arrivals instead. Instinctively got on shuttle, got left in space. Others did too, they got gibbed from arrivals returning. At least 3-4 gibbed, and saw others spawn later in shift too
Reproduction
Similar silliness happened with #32017
Also, more of us spawned at AI in a next round late join on Cog station.
Screenshots
Additional context
Does not appear to be job or map specific.
My character spawn preference is None
First Time:
Server: Leviathan
Map: Bagel
Round ID: 65490
Second Time:
Server: Leviathan
Map: Cog
Round ID:

@metalgearsloth

fixed by https://github.com/space-wizards/space-station-14/pull/32093


Adapt cron trait to laster camel-k-runtime

See https://github.com/apache/camel-k-runtime/blob/ced4a97058519e89293e83e3267c800a91dff94f/camel-k-runtime-cron/src/test/java/org/apache/camel/k/cron/CronTest.java#L41-L42

Relates to https://github.com/apache/camel-k-runtime/issues/255

For true quarkus support we need https://github.com/quarkusio/quarkus/pull/7681


Add CONTRIBUTING.md

As maintainer of this repository, I will add CONTRIBUTING.md with contribution guidelines.

Resolved with https://github.com/dadwalakshay/the-django-boilerplate/pull/8


[Bug] improve --extended does nothing

I've tried to use the new improve --extended twice now and next to nothing happens.  All I get are the eye emojis, nothing else occurs.  How can we determine if it's working?  Regular /improve is working as expected.

https://github.com/Codium-ai/pr-agent/pull/246#issuecomment-1694593269 (for example)
/improve --extended works


Add support for emojis

I've been using the keyboard for a few days and have found the lack of emoji inputs frustrating. To make the keyboard more functional and useful, i feel an emoji input option must also be added that allows user to type in emojis as well (most 3rd party keyboards like swift already have this option).
I'd like to work on it if it is to be implemented.

Any updates on this?

@FleetAdmiral Long press on Enter key can give you Emojis

@FleetAdmiral Thanks for reporting the bug.
Like @balasankarc posted above. Emojis are already supported. But we know that it is not in a prominent, easy to find place.
Next version of the keyboard, which I'm working on right now, will have better support.

Alright, hadn't seen it in the tutorial so maybe if you could have a guided tutorial and mention this there it'd be nice. @jishnu7 Is the project being shifted to another repository because i'm using the keyboard as my default keyboard and would like to report and work on/contribute enhancements or issues i find, if thats fine with you?

Yeah we are lacking good contributions in tutorials. May be you can write one?
Project is not moving. I'm just upgrading the code to the latest aosp base.
We always welcome contributions.

@jishnu7 Yea, i'll start work on the guided tutorial!
Also, would you be applying for GSoC this year?

If you are talking about tutorial inside the app, then I won't recommend doing it right away. A lot of code related to that is changing, and there are already some changes pending in PRs. It might become a a double work. I recommend you to star with something else. If you really want to do tutorial, then I suggest you to write blog posts (which we can publish in indiproject / smc website), video tutorials or even create a website itself for Indic Keyboard.
About GSoC, We might apply again for next year.

@jishnu7  Alright, i'll hold off on any android issues until further notice. I could write a blog post but i feel that there would be more of a use if we make a website for Indic keyboard by itself, so i'll work on that.
Any requirements as of now?
Also, where should i push it to? I feel it'd be better if we had a public repo under your organisation so that others can contribute to that if they wish to.

@jishnu7 ^Could you let me know where i can maintain the website if i work on it? Is there already a repository i could work in, maybe if you intend this to be a subdomain or static page of an already existing website?

@FleetAdmiral Here is the repo.
https://gitlab.com/smc/indic-keyboard-website
There were few people working on it before, I asked them to upload the files. Not sure how much progress they made in HTML/CSS. There is a design source file available. They will upload that for sure.

@jishnu7 The repo is empty as of now, should i ask for the files to be uploaded on irc?

@FleetAdmiral I'll ping the person responsible for uploading the files, again.

Hey @FleetAdmiral got the files -> https://gitlab.com/rejah/Indic-Keyboard-Webpage/

Got the design files! I'll start working on it and keep you updated.

thanks @FleetAdmiral . you can send PRs to https://gitlab.com/smc/indic-keyboard-website. I'll make sure they get merged.

or, just give me your gitlab account, I'll add you for the repo, so that you can directly push your code.

That'll do! My gitlab username is FleetAdmiral (https://gitlab.com/FleetAdmiral).
Also, i'm guessing this will be a single page application (in accordance with the psd design files), something like http://demo.massivedynamic.co/app1/?
Right?


changing RDGW instance type to t3a.small causes termination

I attempted to rightsize the RDGW from 8GB since it was using very little RAM. I changed it to a t3a.small and tried to start it. I received a message that the instance type was incompatible, I refreshed and saw that the instance was terminated. The public IP address showed as unassociated.
Is there anything that can be done to address this from the QuickStart? I don't know why this happened, but I think it has happened to me before.
A few ideas in case there is no technical solution or the problem lies with AWS design:

Offer .medium instances and make this the default for RDGWs
Make a note in the documentation, perhaps with a list of other precautions when deploying this quickstart (I am making a list)
Document this in tags noting the compatibility

This is the system log showing only the initial start.
2019/11/07 16:23:32Z: Windows sysprep configuration complete.
2019/11/07 16:23:35Z: Message: Waiting for meta-data accessibility...
2019/11/07 16:23:35Z: Message: Meta-data is now available.
2019/11/07 16:23:37Z: AMI Origin Version: 2019.10.09
2019/11/07 16:23:37Z: AMI Origin Name: Windows_Server-2016-English-Full-Base
2019/11/07 16:23:38Z: OS: Microsoft Windows NT 10.0
2019/11/07 16:23:38Z: OsProductName: Windows Server 2016 Datacenter
2019/11/07 16:23:38Z: OsInstallOption: Full
2019/11/07 16:23:38Z: OsVersion: 10.0
2019/11/07 16:23:38Z: OsBuildLabEx: 14393.3269.amd64fre.rs1_release.190929-1234
2019/11/07 16:23:38Z: Language: en-US
2019/11/07 16:23:38Z: TimeZone: Coordinated Universal Time
2019/11/07 16:23:38Z: Offset: UTC 00:00:00
2019/11/07 16:23:38Z: AMI-ID: ami-0df99cdd65bce4245
2019/11/07 16:23:38Z: Instance-ID: i-0c9e2e96005d7dcc9
2019/11/07 16:23:38Z: Instance Type: m4.large
2019/11/07 16:23:42Z: Driver: AWS PV Driver Package v8.3.2
2019/11/07 16:23:42Z: Driver: Intel(R) 82599 Virtual Function v<IP_ADDRESS>
2019/11/07 16:23:42Z: Launch: EC2 Launch v1.3.2001360
2019/11/07 16:23:42Z: SSM: Amazon SSM Agent v2.3.634.0
2019/11/07 16:23:43Z: RDPCERTIFICATE-SUBJECTNAME: EC2AMAZ-OA3DQG4
2019/11/07 16:23:43Z: RDPCERTIFICATE-THUMBPRINT: 6C554062536E7DAA97151D01E5EDA6396F72A58D
2019/11/07 16:23:56Z: HibernationEnabled: false
2019/11/07 16:23:56Z: Username: Administrator
2019/11/07 16:23:56Z: Password: <Password>
NlfobVz3SFbxDfEZqgOmsATgskaDUdyvNx3FEcQL/sRNYprTZuk/fDNvmdG/UQnr4hI5zQo2ZKDKihDMihLumHFgyL7yCZ4Ao9tVzrcnkkmbcCRP2t+BdF1FK6ZNYYKeKO2YdUBN+0es1sd+XIM5+nE6qF4sqGOtEkmRwG3LXhyFzPjqbnGJHa5Pf1Zf2mYEQTIUsKhf++EOGKq3o5cPBoXbR6EYSy2Ulr9p6nZMT+zxK0z/DEgejj/HZVqi7j8laSn8/0/Edl7FiH5AYAz2ewfAf6z1sWNW2CxaFVvqR3UYQr8D4iw47byQzgRcYs7JOjiaAd+V3JoO1AkOlcQbDQ==
</Password>
2019/11/07 16:23:58Z: Message: Windows is Ready to use

It turns out that a new instance started and got joined to the domain as a new IP and host name.  This provided an opportunity to replicate this behavior.
Instance ID	i-07fc32b33ff549b76
Instance Type
 EBS-optimized
An error occurred while trying to change the ebs optimized support of this instance
The instance 'i-07fc32b33ff549b76' is not in the 'stopped' state.

Then I tried changing it to t3a.medium
Instance ID	i-07fc32b33ff549b76
Instance Type
 EBS-optimized
An error occurred while trying to change the ebs optimized support of this instance
The instance 'i-07fc32b33ff549b76' is not in the 'stopped' state.

I found this AWS forum post that was not answered.
I refreshed again and found this instance terminated and another one spun up now on another RDGW spun up but this time on a new public IP address. I guess it picks a public IP address at random rather than trying to use the former IP address attached to the VM.
I would like to know how to rightsize the RDGWs.


[IOTDB-3104] Add Consensus Module StateMachine Event API

Coverage decreased (-0.01%) to 53.696% when pulling 8915741ae601e54d18d1d53cfbbe53d6d633b227 on addEventApi into a67a260d23abec347801b0086131437c823cdf09 on master.


bintools: Add dynamic loader path for FreeBSD native

Description of changes
Switched from the "native libc" for FreeBSD hosts to the "hosted libc" with the dynamic loader in the nix store.
Also adds an assertion which was helpful for debugging a separate issue.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[ ] x86_64-freebsd

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Terribly sorry for messing up the rebase on the other PR. I had thought seen one of the maintainers do something similar for one of my pull requests and then remove the reviewers before merging, but I cannot find it so I think I misinterpreted something else. Again, sorry. I've re-read the contributing document.

I put it in its own commit with a commit message indicating it produces better error messages, which is kind of self-evident from examining just this one file.

Oh I thought you meant a code comment, sorry. All good!


Intermediate checkboxes mis-naming.

Hey there :wave:
Looking through this for the first time - so much good stuff to see here! Just wanted to flag up a mis-naming - the boolean property for when the checkbox is neither checked or unchecked should be "indeterminate" not "intermediate". See: https://css-tricks.com/indeterminate-checkboxes/

thanks for catching this @parkersweb 🙏


Remove Saved Query typo

Describe the bug
In the Data Export feature, there's a typo on the saved query removal button.
To Reproduce
Steps to reproduce the behavior:

Go to 'Data Export'
Click on the arrow next to "Save Query"
See the typo

Expected behavior
The label should say "Remove Saved Query" instead of "Removed Saved Query"
Screenshots

Desktop:

Browser chrome
Version 1.16

Additional context
I could fix it and create the PR.

1.17 is live 🚀


There doesn't seem to be a way to use the latest docker images (without the "v1" tag)

As mentioned in https://github.com/google/oss-fuzz/issues/7206#issuecomment-1106677842 I'm planning to unpin CFLite but looking at the action it appears for some reason it uses tags to download the docker images:
$ git grep v1 actions/
actions/build_fuzzers/action.yml:  image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-build-fuzzers:v1'
actions/run_fuzzers/action.yml:  image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-run-fuzzers:v1'

Those tags are bogus in the sense that they keep rolling forward so I wonder if it's possible to remove them to make it clear that they always point to the latest images.
The idea is to always use the "main" branch and the latest images (by analogy with CIFuzz) and avoid getting bogus Dependabot updates when/if https://github.com/google/oss-fuzz/issues/7212 is implemented

On a somewhat related note, once I unpin CFLite the "security posture" of systemd is going to get worse even more. it would be great if OSS-Fuzz/CIFuzz/CFLite can somehow affect the scorecard fuzzing check (which is totally bogus as this point: https://github.com/ossf/scorecard/pull/1816#issuecomment-1099933020). To be honest I think that instead of adding even more bogus checks like "webhooks" scorecard should probably focus on fixing the existing checks.

As mentioned in google/oss-fuzz#7206 (comment) I'm planning to unpin CFLite but looking at the action it appears for some reason it uses tags to download the docker images:
$ git grep v1 actions/
actions/build_fuzzers/action.yml:  image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-build-fuzzers:v1'
actions/run_fuzzers/action.yml:  image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-run-fuzzers:v1'

The tags aren't exactly bogus. We're doing this in case we make breaking changes to the API in v2

On a somewhat related note, once I unpin CFLite the "security posture" of systemd is going to get worse even more. it would be great if OSS-Fuzz/CIFuzz/CFLite can somehow affect the scorecard fuzzing check (which is totally bogus as this point: ossf/scorecard#1816 (comment)).

I'm not happy about this situation either and i've complained to scorecards but it doesn't seem like they will budge. I agree I think pinning provides little security benefit, fuzzing (for C++) provides a big security benefit, so using CFLite without pinning makes a project more secure not less and that scorecards is wrong

The tags aren't exactly bogus. We're doing this in case we make breaking changes to the API in v2

Agreed. After a lengthy discussion in https://github.com/google/clusterfuzzlite/pull/96 I switched to the tags. For that to fully work https://github.com/google/clusterfuzzlite/releases/tag/v1 would have to be bumped automatically though. (@oliverchang bumped it yesterday manually)

using CFLite without pinning makes a project more secure not less and that scorecards is wrong

I have to admit I'm not even sure what scorecard is trying to accomplish anymore with all those checks and a few new ones. I decided to just ignore it altogether.


jacoco-report-aggregation ignores the 2nd submodule with the same name and group

I am not 100% sure this is a bug, but it's something which confused me today and I've spent ~1 hour to realize what is wrong.
Expected Behavior
Aggregated report to contain data from both modules (coverage for Model1 and Model2 classes in my example)
Current Behavior
Aggregated report silently builds aggregated info only from one module. There is no warning or error.
Context
Suppose I have a monorepo for 2 apps: app1 and app2. Each of apps is split into modules: domain/adapters/etc. For simplicity, let's focus only on one module: domain. Here is the project structure for clarity:
├── app1
│   └── domain
│       ├── build.gradle.kts
│       └── src
│           ├── main
│           │   ├── java
│           │   │   └── example
│           │   │       └── Model1.java
│           └── test
│                ├── java
│                   └── example
│                       └── Model1Test.java
├── app2
│   └── domain
│       ├── build.gradle.kts
│       └── src
│           ├── main
│           │   ├── java
│           │   │   └── example
│           │   │       └── Model2.java
│           └── test
│               ├── java
│                   └── example
│                       └── Model2Test.java
├── build.gradle.kts
└── settings.gradle.kts

The problem: If each project has the same "group" + the same module name (which will be domain in my example), then the aggregated report will contain results only from one module instead of 2.
If you use different "group" in appX/model/build.gradle.kts or rename one of domain to  i.e. domain2, then the problem goes away.

Steps to Reproduce

settings.gradle.kts:

rootProject.name = "jacoco-aggregation-bug"
include("app1:domain", "app2:domain")

root build.gradle.kts:

plugins {
    id("jacoco-report-aggregation")
}

repositories {
    mavenCentral()
}

dependencies {
    jacocoAggregation(project(":app1:domain"))
    jacocoAggregation(project(":app2:domain"))
}

reporting {
    reports {
        @Suppress("UnstableApiUsage")
        val jacocoRootReport by creating(JacocoCoverageReport::class) { // <.>
            testType.set(TestSuiteType.UNIT_TEST)
        }
    }
}

build.gradle.kts in each appX/domain has the same group - com.example:

plugins {
    `java-library`
    jacoco
}

group = "com.example" // <<--- same group causes the problem

repositories {
    mavenCentral()
}

testing {
    suites {
        val test by getting(JvmTestSuite::class) {
            useJUnitJupiter("5.8.2")
        }
    }
}

execute ./gradlew clean jacocoRootReport && open build/reports/jacoco/jacocoRootReport/html/index.html

Your Environment
Build scan URL: https://scans.gradle.com/s/csq4so7exssg6

@gavvvr Your assessment is right.  Ultimately, when resolving dependencies, Gradle looks at group+name, so projects that have the same group and name appear to be "the same module" to the dependency resolution engine. You can see this in the build scan: https://scans.gradle.com/s/csq4so7exssg6/dependencies?focusedDependency=WzAsMyw0MSxbMCwzLFs0MV1dXQ&toggled=W1swXSxbMV0sWzAsM10sWzAsMyxbNDFdXV0
This usually isn't a problem because if you had two projects that were published to an external repository, you'd necessarily give them different group+name coordinates. In your case, you're probably not publishing anything externally, so overlapping coordinates aren't important.
I would recommend setting a different group for the subprojects, e.g., com.example.app1 for all the subprojects under app1. We could improve this by setting the group name to something useful and unique by default.

The root cause for this is #847

I am still having the issue with my project structure, where there is no possibility to have different group names. Here is the project structure.
├── app1
│      ├── build.gradle
│       └── src
│           ├── main
│           │   ├── java
│           │   │   └── example.A
│           │   │       └── Model1.java
│           └── test
│                ├── java
│                   └── example.A
│                       └── Model1Test.java
├── app2
│      ├── build.gradle
│       └── src
│           ├── main
│           │   ├── java
│           │   │   └── example.B
│           │   │       └── Model2.java
│           └── test
│               ├── java
│                   └── example.B
│                       └── Model2Test.java
├── build.gradle
└── settings.gradle
├── app3
│      ├── build.gradle
│       └── src
│           ├── main
│           │   ├── java
│           │   │   └── example.C
│           │   │       └── Model3.java
│           └── test
│               ├── java
│                   └── example.C
│                       └── Model3Test.java
├── build.gradle
└── settings.gradle
app2 we have a dependency
dependency {
example.A:artifactoryId:versionNumber
}
In a common build.gradle
dependencies {
jacocoAggregation project(':app1')
jacocoAggregation project(':app2')
jacocoAggregation project(':app3')
}
jacoco aggregation only get reports for app2 and app3 and skipping app1, however if i directly add a dependency
in app2 as
dependency {
implementation(:app1)
}
it works fine, but this is not feasible as it required that the version number for app1 and app2 is in sync.
Also adding a different group name is not possible as it breaks many services having a dependency on this library due to changes in group id.
Looking forward for any help. Thanks!


e2e: use unix port for release tests

Fix https://github.com/coreos/etcd/issues/5947.
When we restart, the previous port could have been still bind
by the OS. Use Unix port to avoid such rebind cases.

@heyitsanthony All addressed. PTAL.
Thanks!

lgtm from the stop/stopall code duplication. Thanks!


Support for oTel agent in shared library format (.so file) ?

Hi,
When running the otelcol with Java Spring boot application on CloudFoundry (via build pack) I get a following error:

The agent is passed via environment variable: JBP_CONFIG_JAVA_OPTS: 'java_opts: "-agentpath:$PWD/collector/otelcol"'
The oTel binary agent I used : x86_86(or amd64) - otelcol_0.59.0_linux_amd64.tar.gz.
For binary oTel agents, it would be nice to have .so format (eg: otelcol_0.59.0_linux_amd64.so) for use with java_opts.

That's new to me, and I'm intrigued. I thought JVM agents were only for Java applications. This probably shows my ignorance on the subject, but shouldn't you be using the Java auto-instrumentation agent?
https://github.com/open-telemetry/opentelemetry-java-instrumentation

https://github.com/open-telemetry/opentelemetry-java-instrumentation

I check it already. It works fine. With this I had to use a slightly different option:
JBP_CONFIG_JAVA_OPTS: 'java_opts: "-javaagent:BOOT-INF/lib/opentelemetry-javaagent-1.17.0.jar"'
Loosely it translates to following start command(Omitted few options for simplicity):
 META-INF/.java_buildpack/jvm/bin/java  -javaagent:BOOT-INF/lib/opentelemetry-javaagent-1.17.0.jar -Djava.io.tmpdir=/home/vcap/tmp -Dlog4j2.formatMsgNoLookups=true -agentpath:META-INF/.java_buildpack/jvm_kill/jvmkill-1.16.0.RELEASE-trusty.so=printHeapHistogram=1  org.springframework.boot.loader.JarLauncher
As you would know -javaagent:BOOT-INF/lib/opentelemetry-javaagent-1.17.0.jar does the trick.
Notice the different between the two in the java_opts argument. In case of a non-java agent binary, it would be
-agentpath and for java agent it would be -javaagent. The concern with using javaagent is that many supported frameworks are still in alpha and subject to broken changes (as noted here).
For example:

Similarly, other framework support is also in alpha :io.opentelemetry.jdbc, io.opentelemetry.apache-httpclient-4.0, io.opentelemetry.spring-webmvc-3.1.
Besides this, it also a popular option to use native agent based on the platform. Eg: For Cloud Foundry, this is Linux x86_64(AMD64). Vendors like Dynatrace also support it.
Dynatrace, for example uses this approach to inject its OneAgent binary via the build pack, see framework-dynatrace_one_agent. In this approach, the OneAgent is automatically supplied when the application is run in CloudFoundry with a service binding to Dynatrace as following:
Final start command:
JAVA_OPTS="-agentpath:$PWD/.java-buildpack/jre/bin/jvmkill-1.16.0_RELEASE=printHeapHistogram=1 -Djava.io.tmpdir=$TMPDIR -XX:ActiveProcessorCount=$(nproc)
                 -agentpath:$PWD/.java-buildpack/dynatrace_one_agent/agent/bin/<IP_ADDRESS>20715-135319/linux-x86-64/liboneagentloader.so -Xshare:off -Djava.ext.dirs=
                 -Djava.security.properties=$PWD/.java-buildpack/java_security/java.security $JAVA_OPTS" &&
                 CALCULATED_MEMORY=$($PWD/.java-buildpack/jre/bin/java-buildpack-memory-calculator-3.13.0_RELEASE -totMemory=$MEMORY_LIMIT -loadedClasses=20063 -poolType=metaspace -stackThreads=250
                 -vmOptions="$JAVA_OPTS") && echo JVM Memory Configuration: $CALCULATED_MEMORY && JAVA_OPTS="$JAVA_OPTS $CALCULATED_MEMORY" && MALLOC_ARENA_MAX=2 DT_TENANT=<tenant_id>
                 DT_TENANTTOKEN=<dt_token>
                 DT_CONNECTION_POINT=<dt-URL>
                 DT_APPLICATIONID=service-a DT_LOGSTREAM=stdout SERVER_PORT=$PORT eval exec $PWD/.java-buildpack/jre/bin/java $JAVA_OPTS -cp
                 $PWD/.:$PWD/.java-buildpack/container_security_provider/container_security_provider-1.19.0_RELEASE.jar org.springframework.boot.loader.JarLauncher

Especially, notice the option: -agentpath:$PWD/.java-buildpack/dynatrace_one_agent/agent/bin/<IP_ADDRESS>20715-135319/linux-x86-64/liboneagentloader.so. It would be nice to have something similar with OpenTelemetry releases as well. From our project stand point, I'm doing an evaluation on various approaches to use a Telemetry agent when the application runs on different runtimes like CloudFoundry and K8S.


Invalid Python release specifier

Bug report
Checklist
[x] I have searched for similar bugs in the issues.
[x] I will add the bug label to this issue.
Version Info

Simber version: 0.2.5

How Simber was installed?
It cannot be installed.
Description
This is currently blocking the build for ytmdl: https://github.com/chaotic-aur/packages/issues/1595
Setup fails because there's an invalid release specifier here:
https://github.com/deepjyoti30/simber/blob/b80cc11752818f0323b99f7111af67d62980500f/setup.py#L31
This results in the following error in python-simber.log:
Warning: 'classifiers' should be a list, got type 'tuple'
error in simber setup command: 'python_requires' must be a string containing valid version specifiers; Invalid specifier: '>=3.*'

According to Python packaging guidelines the appropriate syntax is:
python_requires=">=3",

@Technetium1 Thanks for pointing out the issue. It is fixed in the latest release: 0.2.6.


[D9VK] Mudrunner consumes all 8GB of VRAM and locks system.

I play Mudrunner https://store.steampowered.com/app/675010/MudRunner/ on default settings.
I use radeontop to monitor VRAM consumption.
On vanilla maps the game consumes about 4-5GB and cause heavy sound stuttering during loading. When map loaded VRAM usage drops to ~1GB and game becomes playable. When I try to play some modded maps with lots of new geometry the game consumes all my 8GB of VRAM and locks system. Some times before system lock I can catch "radv/amdgpu: Not enough memory for command submission" message in console and similar messages in dmesg. After lock the only way out is reset button or sysrq+B. I replaced radv with amdvlk but it doesn't help. Bug reproducible with my system wine and with different proton versions in steam (checked Experimental, 8.0, 5.13). The only way to fix is disabling dxvk "PROTON_USE_WINED3D11=1 %command%" command line in Steam. I've found similar report here https://bbs.archlinux.org/viewtopic.php?id=298993
System information
AMD Radeon RX 7600 (0x1002:0x7480:0xCF)
amdgpu
mesa-24.2.1
wine-staging 9.16
DXVK: v2.4
Apitrace file(s)
https://disk.yandex.ru/d/TbL8V0tLwj-XVw
Log files
game.log

I'm not seeing excessive memory usage when replaying the trace so I'm not sure if this is your problem, but the game creates several huge textures every single frame and then immediately destroys them. Needless to say, this is exceptionally dumb, and since DXVK needs to manually clear memory we're keeping these textures alive for several frames.

Can I workaround this setting low FPS limit (DXVK_FRAME_RATE=2) during game loading? Can I later set it back to 60 on the fly?

@barthess  Far as I know changing DXVK_FRAME_RATE value won't do it on the fly.
Instead you can use Mangohud where you can set several fps limits in its config file and switch by press R.Shift + F1 (in my case).

@jrugia Thanks! It works for me. 20 FPS limit is enough to successful map load. Loading process became much slower but game became playable with SpintiresMod.

@barthess Could you give this a shot with 2.5.1 to see if anything has changed?

@Blisto91 Nothing changed. I tested it with proton experimental with the following dxvk version
2064.724:0124:0128:info:dxvk-nvapi:NvAPI_Initialize
2064.724:0124:0128:info:dxvk-nvapi:DXVK-NVAPI experimental-9.0-20241121b NVAPI gcc 10.3.0 x86_64 plain (MudRunner.exe)
info:  Game: MudRunner.exe
info:  DXVK: v2.5.1-2-gdd15328ccf87f70
info:  Build: x86_64 gcc 10.3.0

I was (partially) wrong. This huge modded map https://steamcommunity.com/sharedfiles/filedetails/?id=2608775781 locks my system as usual. But small 1kmx1km maps work better. Now there are no HEAVY stutters just after map loading especially when you rotate camera view with mouse.


feat(tcgc): bump to 0.47.4

Description

bumpt latest emitter
bump tcgc to 0.47.4

resolve https://github.com/microsoft/typespec/pull/4939
Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

Regen preview: https://github.com/Azure/azure-sdk-for-net/pull/46945


advertise client urls accepts empty hosts

A command line misconfiguration from irc:
$ SPELLEDOK="localhost"
$ etcd --listen-client-urls=http://<IP_ADDRESS>:2379 --advertise-client-urls=http://$SPELEDOK:2379 &
$ etcdctl member list
8e9e05c52164694d: name=default peerURLs=http://localhost:2380 clientURLs=http://:2379 isLeader=true

etcd should probably detect empty advertise hostnames and exit with an error.
/cc @kbrwn

/cc @harryge00  would you like to help on this one?

Hi, I'd like to work on this issue if it's not taken already. This would be my first contribution so I'd appreciate some help regarding where to get started. 😄

@shubheksha That would be great. Please start from https://github.com/coreos/etcd/pull/8384 as reference. And let us know if you need more help.
Thanks!


Refactor tools/

tools/ is almost entirely SDK specific. Move the unshared ones into aws/ and change the review requirements on these directories

This is a breakdown of which tools could be moved to the aws/ directory (marked SDK):

tools/ci-build/changelogger: shared
tools/ci-build/crate-hasher: SDK
tools/ci-build/difftags: shared (PR bot codegen diff)
tools/ci-build/publisher: partially shared (publish to crates.io); has a lot of SDK-only subcommands in it
tools/ci-build/runtime-versioner: shared (enforces runtime crates are version bumped when changed)
tools/ci-build/sdk-lints: shared (despite the name, lints for the entirety of smithy-rs)
tools/ci-build/sdk-versioner: SDK
tools/ci-cdk/*: SDK

The publisher tool really should be split up too. It has a bunch of non-publishing functionality in it now that is SDK-specific.