Split commands from shell script in dockerfile

Description
As the first step to parse Dockerfile RUN instruction commands, we need to split commands from a dockerfile RUN commands. A full shell script contains these elements,

variable assignment : eg. dpkgArch="$(dpkg --print-architecture)";
command line: eg. wget -O go.tgz "$url";
branch: eg. case .... esac;, if ... fi;
function:  eg. foo(){.....}
In this task, we need to parse a shell script into above parts and store them, possible in a List. For branches, we may need another task to parse its branches into variable assignment and command line.

To Do
Given a full shell script from RUN instruction of dockerfile, return a data structure that stores the parsing result. Most modifications will be made in general.py.

We can add a function called parse_shell_script() in general.py as a main function. It receives a string of RUN instruction, which is a shell script. It returns a command dict containing all the possible command in the given shell script.
Once the above command dict is given, we can modify the parse_command() in general.py to parse the command dict to find possible installed software. This could be implemented by the following task issues.

Something need to be discussed:

Data structure can be List.

Maybe we can define a class for the parsed elements. It has a property shows what is this element, like variable assignment or command line etc. We can implement further parse like parsing the branch as the class function.

Or maybe we can use dict as the elements, it has a key called statement whose value can be variable assignment or command line etc. And we add new functions in general.py.

How to handle branch.
I am thinking adding a extra key pr property for the command line indicating if it is in a branch.
At first we can take the default branch as the command for parse. In the further plan, we can add more analyze on this like considering varibles, or if this branch only infects the version we install but not the software name we install.
Should we consider function?

Background
On looking at the type of parsing needed for full shell scripts embedded in the run command, we may need to develop a shell script parser to catch all places where software could have been installed.
Super Issues
#521

An example of RUN commands in a Dockerfile that is difficult to parse:
https://github.com/docker-library/python/blob/06d7952f07eae237666f2fd0ccf6189a5d8ee83c/3.9-rc/buster/Dockerfile

Here is a shell script containing loop, and the current output is
buster-slim.txt.
In line 63, the for loop is treated as a command, so we need to consider adding another element loop to the parsing procedure. I have file an issue #706 to fix this.

Fixed in PR #717. Closing.


many issues with dark themes

love this apllication, but many many issues with the black theme windows , wrong color on many places cant see text etc
hope u fix this _=)  need white text and sub bar black or with anyway black text color , now its white on white

I agree, had to use default theme cause of this...sad..hope get fix soon!!!

I am using autohide menu. When hovering over menu, selected friend and search bar are transparent.
Issue is not affecting default theme.

Please fix! I wanted to use the dark/mosaic themes but I can't read what I'm typing so I always switch back to the default theme :(

I fixed most of dark theme problems for the next release...
If you want to help me. Give the css class of the objects that are wrong and it will then be very easy for me to fix them.

It doesn't look like this at all with 1.4.7 :o

and how to install the 1.4.7 version? please tell us!!

@skyli91  How to install 1.4.7? Mine is 1.4.3 and says it's the latest version.

Yes its my build (on my fork), but I now am one the official maintainer of the app. I will do a release really soon. You can install my fork builds meanwhile if you want.

@Sytten sadly i don't have any idea how to do that. LOL I just came here to report.

@tristankhalil
https://github.com/Sytten/Facebook-Messenger-Desktop/releases/tag/v1.4.7
There is the link to version 1.4.7

@lilchancep WOW thank you!

Please see https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/458


Validation on Lookup editors -Attribute "Not null" does not work as expected

It looks like the lookup editor validation does not work as expected ,I am referring to attribute "Not Null" .
Demo project eg Northwind -> Orders ->(New Order) -> Tab General , If the user clicks save button without any inputs . Required fields are Customer and Order date, if you observe the Customer lookup editor validation does not change the color to Red and the error tool tip is also not displayed.
Is it a known issue?
While using Not Null - ideally I was expecting the editor to change the colour to RED and the tooltip message as "This field is required"
In my case apart from above issue, it displays the label name within the tool tip instead of the standard error tooltip message.
Thanks

yes known issue,
you can fix with this css below;
maybe we can request from @volkanceylan to fix this css if there is no obstacle :)
.s-Form .required.error {
    border: 1px solid #ff4040 !important;
}

This is because validation is performed on the hidden input and error class is appended to that input, while actual visible control is select2 container div. Thus, the border is there but can't be seen. Will try to apply a workaround though.

Ok, this commit should solve the issue: https://github.com/volkanceylan/Serenity/commit/78950a58ace07701ab0150da632696bce4c8dc01


Bump .node-version to 18

Summary
Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/
Node 16 EOL: 2023-09-11
https://nodejs.org/en/blog/announcements/nodejs16-eol/
Node 18 EOL: 2025-04-30
Follow-up

https://github.com/facebook/react-native/pull/34171

Ref

https://github.com/react-native-community/docker-android/pull/187

cc @ramonmedel @cortinico @gengjiawen
Changelog

[JavaScript] [Changed] - Bump .node-version to 18
Test Plan
Everything builds and runs as expected

I think we can do that, but you'll have to also update the Node version on CircleCI and make sure that everythign is green:
https://github.com/facebook/react-native/blob/main/.circleci/config.yml#L42-L43
Prev-LTS should be 16, and current should be 18.

can you fix the changelog entry? [Javascript] is not a valid argument?

looks valid no? so it's passing
https://github.com/facebook/react-native/blob/55b09da62a50ee4ef03b53002266e2cc5e8db1c2/packages/react-native-bots/dangerfile.js#L62
if js/javascript been deprecated, happy to create another PR to remove both opts

looks valid/appropriate no? so it's passing
https://github.com/facebook/react-native/blob/55b09da62a50ee4ef03b53002266e2cc5e8db1c2/packages/react-native-bots/dangerfile.js#L62
if js/javascript been deprecated, happy to create another PR to remove both opts and update to [General]

oh wow then the docs are outdated 😅 https://reactnative.dev/contributing/changelogs-in-pull-requests <- that one will need to be fixed; thanks for spotting!


Endpoints of Microsoft Whiteboard should be added to the Office 365 URLs and IP address ranges

The following endpoints should be added to the Office 365 URLs and IP address ranges for Microsoft Whiteboard.
whiteboard.microsoft.com
wbd.ms
*.whiteboard.microsoft.com
whiteboard.ms

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66bd8666-3566-a901-b25b-eb6baba6264a
Version Independent ID: e9f6310f-2207-8c81-d31a-3d5a80beb26b
Content: Office 365 URLs and IP address ranges - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/urls-and-ip-address-ranges.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@kelleyvice-msft Please help us in resolving this issue. Thanks

@yogkumgit Thank you for your triage.

@kelleyvice-msft Could you let us know the current status?

Hi  -- This topic is autogenerated from an internal tool used to maintain endpoint data. It cannot be manually edited. I will follow up to see if this is a gap.

Thanks for reaching out. I have informed the appropriate engineering team of this issue and requested that they go through the process of adding their endpoints to the web service. Once they complete this process, the endpoints should be included in future updates. -Kelley

by way of explanation, currently MS WB URLs augloop.office.com and *.whiteboard.microsoft.com are only covered by the "Default" O365 IP Address and URL category and this means corporates following MS guidance send the traffic to proxy appliances.  Proxy appliances that are typically doing SSL Break and Inspect to keep out malware and DLP.  SSL Break and Inspect breaks WebSockets.  At least having this info published and kept up to date somewhere like the O365 IP Addresses and URLs Web Service gives corp IT depts a fighting chance to keep services running in a secure way.  here is an example from Edge Dev Tools where web sockets are blocked in WhiteBoard app.

could this issue be reopened until either an explanation of why this cannot happen is provided, or WhiteBoard is moved in to the web service please @kelleyvice-msft ?

Tagging @pandrew1 for comment. The writing team does not have visibility into status of service onboarding to the endpoint process.


Update some dev-tools to new versions

Motivation for changes:
Get pre-commit hooks working again
Detailed changes:

Changes to pre-commit config and dev-requirement to allow for newer versions

Maybe we should split out a dev-requirements.in which has looser requirements. Having things pinned is nice because the test and release scripts use these versions, and it's not so nice for them to be able to break when some of our dev tools upgrade.

Good Idea...Starting the above recommendation

Cool, looks good. We could probably do this with our dev-requirements.in as well, to avoid having conflicts between deps shared between dev and regular requirements.


Error on clean install of latest HA OS

Hi. I just installed the latest version of HA OS (2024.6.3), and copied over the settings from a running container version (2024.6.0).
I however get the following error:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 594, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/nhc2_backup_2/init.py", line 134, in async_setup_entry
dev_reg = hass.helpers.device_registry.async_get(hass)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: async_get() takes 1 positional argument but 2 were given
NHC2 still runs fine in the containered version. What could be the issue?

Are you using the latest version of the integration?

Yes: version": "v4.3.4"

Is there a reason why the component is installed in /config/custom_components/nhc2_backup_2? Could it be that this is a backup that should not be used?

@minosrex as there is no response from you I will close this issue.
Feel free to reopen it if you think this is not correct.


Proposal for side of x membrane

'cytoplasmic side of membrane': OBSOLETE 11 EXP
'lumenal side of membrane': OBSOLETE : 1 EXP

Proposal: change labels to

'cytoplasmic side of apical plasma membrane' -> cytosol adjacent to apical plasma membrane -> 30 EXP

'cytoplasmic side of dendritic spine plasma membrane' -> cytosol adjacent to dendritic spine plasma membrane -> single annotation (RGD), consistent with new label

'cytoplasmic side of early endosome membrane' -> cytosol adjacent to early endosome membrane

'cytoplasmic side of endoplasmic reticulum membrane' -> cytosol adjacent to endoplasmic reticulum membrane

'cytoplasmic side of endosome membrane' -> cytosol adjacent to endosome membrane

'cytoplasmic side of Golgi membrane' -> cytosol adjacent to Golgi membrane

'lumenal side of Golgi membrane' -> Golgi lumen adjacent to Golgi membrane

'cytoplasmic side of late endosome membrane' -> cytosol adjacent to late endosome membrane

'cytoplasmic side of lysosomal membrane' -> cytosol adjacent to lysosomal membrane

'cytoplasmic side of mitochondrial outer membrane' -> cytosol adjacent to mitochondrial outer membrane

'cytoplasmic side of plasma membrane' -> cytosol adjacent to plasma membrane

'cytoplasmic side of rough endoplasmic reticulum membrane' -> cytosol adjacent to rough endoplasmic reticulum membrane

'cytoplasmic side of smooth endoplasmic reticulum membrane' -> cytosol adjacent to  smooth endoplasmic reticulum membrane

'cytoplasmic side of trans-Golgi network transport vesicle membrane' -> cytosol adjacent to trans-Golgi network transport vesicle membrane

'cytoplasmic side of transport vesicle membrane' -> cytosol adjacent to transport vesicle membrane

'external side of cell outer membrane' -> extracellular region adjacent to cell outer membrane

'external side of mycolate outer membrane' -> cytosol adjacent to mycolate outer membrane

'external side of plasma membrane' -> extracellular region adjacent to plasma membrane (space??)

'external side of apical plasma membrane' -> extracellular region adjacent to apical plasma membrane

'periplasmic side of plasma membrane' -> periplasmic space adjacent to plasma membrane

'internal side of mycolate outer membrane'   ->

'lumenal side of early endosome membrane' -> endosome lumen adjacent to early endosomal membrane

'lumenal side of endosome membrane'  -> endosome lumen adjacent to early endosomal membrane

'lumenal side of endoplasmic reticulum membrane'  -> endoplasmic reticulum lumen adjacent to endosomal membrane

'lumenal side of late endosome membrane'  ->

'lumenal side of lysosomal membrane'  ->

'lumenal side of membrane''lumenal side of plastid thylakoid membrane'  ->

'lumenal side of membrane''lumenal side of rough endoplasmic reticulum membrane'  ->

'lumenal side of membrane''lumenal side of smooth endoplasmic reticulum membrane'  ->

'lumenal side of membrane''lumenal side of trans-Golgi network transport vesicle membrane'  ->

'lumenal side of membrane''lumenal side of transport vesicle membrane'  ->

'lumenal side of membrane''lumenal side of trans-Golgi network transport vesicle membrane'  ->

'lumenal side of membrane''matrix side of mitochondrial inner membrane'  ->

'lumenal side of membrane''periplasmic side of cell outer membrane'  ->

'lumenal side of membrane''stromal side of plastid inner membrane'  ->

'lumenal side of membrane''stromal side of plastid thylakoid membrane'  ->

Q will these terms still be children of "membrane"?  because the existing terms were children of membrane I have used for membrane attached proteins, located on a specific side of a membrane (usually lipid anchored etc).

Thanks for pointing that out; I think these terms indeed mean that the proteins are somehow in the membrane (at least anchored); so, yes, they would remain children of membrane. Is this consistent with all annotations?

so in this image
https://user-images.githubusercontent.com/4782928/33712835-27722394-db49-11e7-9752-078a6abdd7cb.png
I would annotate
beta 2AR, alpha, and gamma subunits to membrane.
I might also annotate additional complex subunits if they were part of the. same "functional unit" like a transport
or adaptor (I am not sure about this I would need to check). I  would not annotate the proteins they recruited to perform some other activity, or connect to other cortical structures (for example).

I was specifiically thinking of those to be labelled "cytosol adjacent to x" would be classed as cytosolic not membrane? vs the annotation of proteins which are anchored - which would be classed as in the membrane.

In this case  "cytosol adjacent to x"  would be equivalent to "cell cortex"
The region of a cell that lies just beneath the plasma membrane and often, but not always, contains a network of actin filaments and associated proteins.

Yes....for PM that would be the case. But for the organelles...

That would be useful. I somehow missed this proposal. I knew it was on the cards, but I did not seem to be tagged in. any tickets.

I think we decided to stick with the current terms. OK @ValWood ?

OK for me.


`STRICT_ANSI' not defined

I got this warning when compiling on Ubuntu and the whole project is built without pch as normal build:
warning: /home/utility/cotire/IO.Utility_CXX_prefix.hxx.gch: not used because '__STRICT_ANSI__' not defined [-Winvalid-pch]
So is there a way to fix this warning?
I don't have any issues when compiling on Windows.

Do you have __STRICT_ANSI__ as an add_definition in your CMakeLists.txt?

No, I don't have this definition in my CMakeLists.txt
I try to add this definition by:
add_definitions(-D__STRICT_ANSI__)
I have new warning:
warning: /home/utility/cotire/IO.Utility_CXX_prefix.hxx.gch: not used because 'linux' is defined [-Winvalid-pch]

Please double check that you do not modify any target properties that affect compilation after you have applied cotire.

I found out that this issue caused by
set_property(TARGET example PROPERTY CXX_STANDARD 11)
set_property(TARGET example PROPERTY CXX_STANDARD_REQUIRED ON)
But I cannot remove these set commands because I use lots of c++11 features in my project. What can I do now? Thank you.

Please gist the output of a cmake -DCOTIRE_DEBUG=On run.

Below is the output with debug on:
admin@ubuntu:~/Documents/cotire-master/build$ cmake ../ -DCOTIRE_DEBUG=On
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Boost version: 1.54.0
-- Found the following Boost libraries:
--   date_time
--   filesystem
--   system
--   regex
/usr/include
-- cotire 1.7.8 loaded.
-- C source file extensions: c;m
-- C ignore extensions: h;H;o;O;obj;OBJ;def;DEF;rc;RC
-- C exclude extensions: m;mm
-- CXX source file extensions: C;M;c++;cc;cpp;cxx;mm;CPP
-- CXX ignore extensions: inl;h;hpp;HPP;H;o;O;obj;OBJ;def;DEF;rc;RC
-- CXX exclude extensions: m;mm
-- Filtered example CXX sources: main.cpp;example.cpp;log.cpp
-- CXX target example cotired.
-- CXX source file extensions: C;M;c++;cc;cpp;cxx;mm;CPP
-- CXX ignore extensions: inl;h;hpp;HPP;H;o;O;obj;OBJ;def;DEF;rc;RC
-- CXX exclude extensions: m;mm
-- Filtered example CXX sources: main.cpp;example.cpp;log.cpp
-- # cotire.cmake 1.7.8 generated file
/home/admin/Documents/cotire-master/build/src/example_CXX_cotire.cmake
set (COTIRE_ADDITIONAL_PREFIX_HEADER_IGNORE_EXTENSIONS "inc;inl;ipp")
set (COTIRE_ADDITIONAL_PREFIX_HEADER_IGNORE_PATH "")
set (COTIRE_CLEAN_ALL_TARGET_NAME "clean_cotire")
set (COTIRE_CLEAN_TARGET_SUFFIX "_clean_cotire")
set (COTIRE_CMAKE_MODULE_FILE "/home/admin/Documents/cotire-master/CMake/cotire.cmake")
set (COTIRE_CMAKE_MODULE_VERSION "1.7.8")
set (COTIRE_DEBUG "On")
set (COTIRE_INTDIR "cotire")
set (COTIRE_MAXIMUM_NUMBER_OF_UNITY_INCLUDES "0")
set (COTIRE_MINIMUM_NUMBER_OF_TARGET_SOURCES "3")
set (COTIRE_PCH_ALL_TARGET_NAME "all_pch")
set (COTIRE_PCH_TARGET_SUFFIX "_pch")
set (COTIRE_PREFIX_HEADER_FILENAME_SUFFIX "_prefix")
set (COTIRE_TARGETS_FOLDER "cotire")
set (COTIRE_TARGET_CONFIGURATION_TYPES "None")
set (COTIRE_TARGET_CXX_COMPILER_LAUNCHER "COTIRE_TARGET_CXX_COMPILER_LAUNCHER-NOTFOUND")
set (COTIRE_TARGET_IGNORE_PATH "/home/admin/Documents/cotire-master")
set (COTIRE_TARGET_INCLUDE_PRIORITY_PATH "")
set (COTIRE_TARGET_LANGUAGE "CXX")
set (COTIRE_TARGET_MAXIMUM_NUMBER_OF_INCLUDES "")
set (COTIRE_TARGET_POST_UNDEFS "")
set (COTIRE_TARGET_PRE_UNDEFS "")
set (COTIRE_TARGET_SOURCES "main.cpp;example.cpp;log.cpp")
set (COTIRE_UNITY_BUILD_ALL_TARGET_NAME "all_unity")
set (COTIRE_UNITY_BUILD_TARGET_SUFFIX "_unity")
set (COTIRE_UNITY_OUTPUT_DIRECTORY "")
set (COTIRE_UNITY_SOURCE_EXCLUDE_EXTENSIONS "m;mm")
set (COTIRE_UNITY_SOURCE_FILENAME_SUFFIX "_unity")
set (CMAKE_GENERATOR "Unix Makefiles")
set (CMAKE_BUILD_TYPE "")
set (CMAKE_CXX_COMPILER_ID "GNU")
set (CMAKE_CXX_COMPILER_VERSION "4.8.4")
set (CMAKE_CXX_COMPILER "/usr/bin/c++")
set (CMAKE_CXX_COMPILER_ARG1 "")
set (CMAKE_INCLUDE_FLAG_CXX "-I")
set (CMAKE_INCLUDE_SYSTEM_FLAG_CXX "-isystem ")
set (CMAKE_CXX_SOURCE_FILE_EXTENSIONS "C;M;c++;cc;cpp;cxx;mm;CPP")
-- example unity source max includes: 0
-- unity files: /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_unity.cxx
-- add_custom_command: OUTPUT /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_unity.cxx COMMAND /usr/local/bin/cmake;--warn-uninitialized;-DCOTIRE_BUILD_TYPE:STRING=$;-DCOTIRE_VERBOSE:BOOL=$(VERBOSE);-P;/home/admin/Documents/cotire-master/CMake/cotire.cmake;unity;/home/admin/Documents/cotire-master/build/src/example_CXX_cotire.cmake;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_unity.cxx DEPENDS /home/admin/Documents/cotire-master/build/src/example_CXX_cotire.cmake
-- add_custom_command: OUTPUT /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.cxx COMMAND /usr/local/bin/cmake;--warn-uninitialized;-DCOTIRE_BUILD_TYPE:STRING=$;-DCOTIRE_VERBOSE:BOOL=$(VERBOSE);-P;/home/admin/Documents/cotire-master/CMake/cotire.cmake;prefix;/home/admin/Documents/cotire-master/build/src/example_CXX_cotire.cmake;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.cxx;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_unity.cxx DEPENDS /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_unity.cxx
-- add_custom_command: OUTPUT /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx COMMAND /usr/local/bin/cmake;--warn-uninitialized;-DCOTIRE_BUILD_TYPE:STRING=$;-DCOTIRE_VERBOSE:BOOL=$(VERBOSE);-P;/home/admin/Documents/cotire-master/CMake/cotire.cmake;combine;/home/admin/Documents/cotire-master/build/src/example_CXX_cotire.cmake;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.cxx DEPENDS /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.cxx
-- add_custom_command: OUTPUT /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx.gch /usr/local/bin/cmake;--warn-uninitialized;-DCOTIRE_BUILD_TYPE:STRING=$;-DCOTIRE_VERBOSE:BOOL=$(VERBOSE);-P;/home/admin/Documents/cotire-master/CMake/cotire.cmake;precompile;/home/admin/Documents/cotire-master/build/src/example_CXX_cotire.cmake;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx.gch;main.cpp DEPENDS /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx IMPLICIT_DEPENDS CXX /home/admin/Documents/cotire-master/build/src/cotire/example_CXX_prefix.hxx
-- CXX source file extensions: C;M;c++;cc;cpp;cxx;mm;CPP
-- CXX ignore extensions: inl;h;hpp;HPP;H;o;O;obj;OBJ;def;DEF;rc;RC
-- CXX exclude extensions: m;mm
-- Filtered example CXX sources: main.cpp;example.cpp;log.cpp
-- add target EXECUTABLE example_unity  EXCLUDE_FROM_ALL log.h;example.h;/home/admin/Documents/cotire-master/build/src/cotire/example_CXX_unity.cxx
-- unity target example_unity link strategy: COPY_UNITY
-- Configuring done
-- Generating done
-- Build files have been written to: /home/admin/Documents/cotire-master/build

Please also post your modified CMakeLists.txt from the example.

I removed all message() commands for clarity, so there are just few lines:
add_executable(example main.cpp example.cpp log.cpp log.h example.h)
cotire(example)
set_property(TARGET example PROPERTY CXX_STANDARD 11)
set_property(TARGET example PROPERTY CXX_STANDARD_REQUIRED ON)

And here is your problem. Cotire must be applied after the properties CXX_STANDARD and CXX_STANDARD_REQUIRED are set, i.e.:
set_property(TARGET example PROPERTY CXX_STANDARD 11)
set_property(TARGET example PROPERTY CXX_STANDARD_REQUIRED ON)
cotire(example)

Also see the manual section on common pitfalls. Under Windows it works by chance because these properties do not affect compilation when using Visual Studio.

Thank you, I try to set those properties before applying cotire but I sill get the same issue

Try recreating your build folder.

Have run into this, including with clean build - slightly different in that I set the CXX_STANDARD / CXX_STANDARD_REQUIRED flags globally.

+1
After adding the definition
add_definitions(-D__STRICT_ANSI__)
my error changed to
not used because '__GLIBCXX_BITSIZE_INT_N_0' is defined [-Winvalid-pch]
The workaround for me was commenting out the CXX_STANDARD_REQUIRED line:
set (CMAKE_CXX_STANDARD 14)
#set (CMAKE_CXX_STANDARD_REQUIRED ON)

Fixed in 1.7.9.


Question: Choice Rules vs. Multiple Rules

Hello,
I hope you'll indulge another beginner ASP question. I have cases in my program where a rule has multiple implications, like so:
b :- a.
c :- a.

When the body of the rule is very complicated, it's confusing to repeat the body for each implication, as I must read it carefully to determine it's actually the same rule. One solution that was proposed to me was a choice rule:
2 { b; c } :- a.

This seems to me to have different semantics: "choose 2 of the 2 following choices", which seems rather round about. It's not really a choice rule if there's no choice.
If the choice rule is the accepted idiom, I can bite the bullet and write my rules that way. But does that impact performance vs. just having two rules? If so, I'd rather have a macro like the following:
b, c :- a.
% expands to
b :- a.
c :- a.

Is there no way to express what I mean here, or am I missing something more fundamental?

In my experience it seldom occurs that there are a lot of rules having the same body. I would try to avoid this. I cannot really tell from the propositional example but maybe it is a modelling issue?
If there are really some rules with the same bodies then I see no problem writing them twice (maybe introducing an auxiliary atom to avoid writing complex bodies over and over). For example
p(X,Z) :- p(X,Y), p(Y,Z).
p(Z,X) :- p(X,Y), p(Y,Z).

could be written as
q(X,Z) :- p(X,Y), p(Y,Z).
p(X,Z) :- q(X,Z).
p(Z,X) :- q(X,Z).

Note that you can actually write a, b :- c but it has a different semantics. Comma in the head is a disjunction not a conjunction.

I figured it might be the case that my real problem is in the model, not the syntax. I'll see if I can't resolve my issue at that level.
Thanks!

If you get stuck, just describe your problem and send a small example. Maybe someone can help.


fix: resolve pid 0 to system_processes

The resolves pid 0 to system_processes without (throwing) any error since there is no command associated with it. This commit fixes the following log
I0802 03:24:03.647656  733341 process_bpf_collector.go:100] failed to resolve comm for PID 0: process not running: stat /proc/0: no such file or directory, set comm=system_processes
I0802 03:24:03.648079  733341 process_bpf_collector.go:100] failed to resolve comm for PID 0: process not running, set comm=system_processes
I0802 03:24:03.648108  733341 process_bpf_collector.go:100] failed to resolve comm for PID 0: process not running, set comm=system_processes

@sthaha can you check if this fix has any impact on model accuracy? There is a MSE/MAPE regression since this change
https://sustainable-computing-io.github.io/kepler-metal-ci/validation/2024-08-02/report-v0.7.11-66-gdf3a4b6c.html


[Docs] Feedback on /docs/tutorials/websocket - Thu, 21 Mar 2024 01:29:38 GMT

Discussed in https://github.com/orgs/asyncapi/discussions/1116

Originally posted by asyncapi-bot March 21, 2024
The final code document does not validate in Studio.
note from Lukasz
it is related to https://www.asyncapi.com/docs/tutorials/websocket
and yeah, we have formatting issue, indentation issue to be precize
correct document that should be in last code sample is:
asyncapi: '3.0.0'
info:
  title: Create an AsyncAPI document for a Slackbot with WebSocket
  version: '1.0.0'
  description:  |
    The Heart-Counter manages popular messages in a Slack workspace by monitoring message reaction data.
servers:
  production:
    host: wss-primary.slack.com
    pathname: /link
    protocol: wss
    description: Slack's server in Socket Mode for real-time communication
channels:
  root:
    address: /
    messages:
      hello:
        $ref: '#/components/messages/hello'
      reaction:
        $ref: '#/components/messages/reaction'
    bindings:
      ws:
        query:
          type: object
          description: Tokens are produced in the WebSocket URL generated from the [apps.connections.open](https://api.slack.com/methods/apps.connections.open) method from Slack’s API
          properties:
            ticket:
              type: string
              description: Temporary token generated when connection is initiated
              const: '13748dac-b866-4ea7-b98e-4fb7895c0a7f'
            app_id:
              type: string
              description: Unique identifier assigned to the Slack app
              const: 'fe684dfa62159c6ac646beeac31c8f4ef415e4f39c626c2dbd1530e3a690892f'
operations:
  helloListener:
    action: receive
    channel:
      $ref: '#/channels/root'
    messages:
      - $ref: '#/channels/root/messages/hello'
  reactionListener:
    action: receive
    channel:
      $ref: '#/channels/root'
    messages:
      - $ref: '#/channels/root/messages/reaction'
components:
  messages:
    reaction:
      summary: Action triggered when the channel receives a new reaction-added event
      payload:
        $ref: '#/components/schemas/reaction'
    hello:
      summary: Action triggered when a successful WebSocket connection is established
      payload:
        $ref: '#/components/schemas/hello'
  schemas:
    hello:
      type: object
      properties:
        type:
          type: string
          description: A hello string confirming WebSocket connection
        connection_info:
          type: object
          properties:
            app_id:
              type: string
            num_connections:
              type: integer
            debug_info:
              type: object
              properties:
                host:
                  type: string
                started:
                  type: string
                build_number:
                  type: integer
                approximate_connection_time:
                  type: integer
    reaction:
      type: object
      properties:
        user:
          type: string
          description: User ID who performed this event
        reaction:
          type: string
          description: The only reaction that we need is a heart emoji
        item_user:
          type: string
          description: User ID that created the original item that has been reacted to
        item:
          type: object
          properties:
            channel:
              type: string
              description: Channel information of original message
            ts:
              type: string
              description: Timestamp information of original message
        event_ts:
          type: string
          description: Reaction timestamp

works well in https://studio.asyncapi.com/
provide fix in https://github.com/asyncapi/website/blob/master/pages/docs/tutorials/websocket/index.md

Hello @derberg! I don't see anyone assigned to this yet, I can take it up.

@VaishnaviNandakumar awesome, please go ahead


Is there support for webhook notifications to send different REST API methods?

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
I'm working on setting up Uptime Kuma to work with Atlassian Statuspage (I know Kuma has a statuspage itself but this fits my situation better) to relay uptime/downtime. To do this I was going to use the webhook notification method however I noticed by the looks of it that Kuma only supports the POST method, is there a way to send in a different method like PATCH which is what Atlassian requires?
Any help is much appreciated!
📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
1.23.2
💻 Operating System and Arch
Ubuntu 22.04.3 LTS
🌐 Browser
Opera GX
🐋 Docker Version
Docker 22.04.6
🟩 NodeJS Version
No response

No, this is currently not possible. See https://github.com/louislam/uptime-kuma/issues/2413 for a possible solution.
As always: Pull Requests welcome.
I think this is a can be integrated into this feature request https://github.com/louislam/uptime-kuma/issues/2413
If you agree, could you please close this Issue, as duplicates only create immortal zombies and are really hard to issue-manage.

I agree and have left a comment on there, thanks!


Save link to forwarded message

Use info from
"forward_from_chat":{"id":-1001000275375,"title":"Evil Martians","username":"evilmartians","type":"channel"},"forward_from_message_id":1040"

To build link to message https://t.me/evilmartians/1040
and add it to evernote (details URL or just to end of text)

@kis-xt done, you can check

works!


[i need ideas] for make API :v

give me ideas pls.
for my ModPEPlus Library.

Uhhhh...this isn't the place for discussion?

@sliceofcode eiddik detceted

Yeah, not a place to discuss.


Randomized loading screens from a script

Describe your problem here.
Am i able to add randomized loading screens?
from Lua or the script file located in mods cause i want that to showcase credit art and loading screens.
please
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No.

Check the Funkin Playback game. They made a custom loading screen there.


Version 1.1.0 release candidate

Most Prominent Changes 📓

Support for third party plugins using the core package and IPlugin system! 🎉
Three shiny new syntaxes to model with 😎
General code refactorings to make the codebase even easier to work with 🤓
And uncountable bugfixes and refactorings 🐛

Autogenerated changelog
full-changelog (2023-11-08)
Bug Fixes

actually deprecate the editor settings field for showing inspector pane (9bd4418)
add isTargetDrawpane to keyevents as well (d19173a)
add license file back in (eac13be)
add new file button to file panel (6315932)
add outer rect for initial lts states (55bc1ab)
add petrinet description (00fed3c)
add tooltips to petrinet tools (b1530b6)
add unbind for view model edges (3b16ce7)
also serialize the initial property (6a36f9a)
check if git is installed before calling it (b1b5b47)
custom vertex controllers can now bind the width and height shape properties (000cf92)
deb repackaging (c71930a)
default pref width of the sidepanel (3dbf82c)
desktop file now have the correct name and location (529855a)
dont show the syntax selector in the second toolbar (421c7c8)
edges should be behind vertices (d51f6c8)
editor is now launchable even if there are no plugins loaded (c2fcab3)
enable json prettyprinting for better git-compatibility (8f83682)
initial changing is also an event (9af6911)
inspectorpane wasnt scrolling correctly (ab1da14)
make bottom pane and file pane freely resizable (4f02b74)
make it impossible to change syntax when graph is nonempty (7f71fca)
make syntax factory collection di injection type safe (da80bff)
model edges are classes now too (159bebc)
move getLineOffsetYBinding and getLineOffsetXBinding functions into BindingsUtils (44707dc)
move inverse mouse-drag into DragUtil (6de729a)
move new model file functionality into editor actions (af476bb)
new places start with 0 tokens (744f3c6)
new syntax vertex listener events (5a19c0b)
petrinet syntax fixes (23ba594)
plugin collection is now observable (1a49e92)
plugin system now actually works (184de2b)
pn transitions are rectangles too (96e7419)
prettier initial indicator (cd8fa40)
rectangle width bind on lts state and text vertices (509677f)
reenable Shortcut+N for newfile and move the modals to Shortcut+Shift+8/9/0 (5b92672)
remove already fixed todo (23a9353)
remove already fixed todos (7bb4d99)
remove old igrapheditapplicationwrapper interface (3dc2dbb)
remove project files view panel view fxml file (d8e8d99)
remove spi subproject (17d92a9)
remove todo (03a9ee2)
remove todo (3675da1)
remove todo (0b6b692)
remove unnecessary files (207b089)
repackage deb to install desktop file the correct place (fb36d29)
resolve bug where edge create tool could get stuck in "addition" mode (3cb45f4)
shape scale shouldn't be inspectable (8e5e60b)
shaped bindings will now react to shape type changes (1123496)
slightly better, but not good, about page (1298d7b)
solve todo (fdb9c2f)
sort and unify dependencies (b337c08)
syntax toolbar is now automatically refreshed when switching syntax (18edb66)
undeprecate the dragutil and add a javadoc (b53a247)
unify dependencies (759b658)
unmagic magic number (14309cc)
unmagic the metadata syntax key (48b68b8)
update makefile target for flatpak (586b472)
update screenshots (4d29956)
update version number (64d7b77)
use some slightly better icons and spacing (1ce9e67)
use the new open model editor action in file panel (648d68a)
use the new toolbox ctor (6e70e4a)
windows does not support system menu bars (72ba2d9)
wrap git gradle commands better (5c9b742)
write lts description (33ae4bb)

Features

add configdir/plugins as part of the dirs to look for plugins (26c5231)
add controllers for lts syntax (44540d9)
add default plugins loading support (cee7fd3)
add flatpak building (4bf8f8c)
add migrater interface and implementation for demo syntax (91167b4)
add model and viewmodel for lts syntax (9de82aa)
add on-init and on-destroy events to plugins (6c775bd)
add open model editor action (accbf92)
add petrinet syntax (7c879c5)
add petrinet syntax factory (e88371b)
add plugin system (a75ee67)
add sidepanel with tabs for plugins (f6e97dd)
add signing and publishing gradle stuff for core (6020bcc)
add statusbar (907b5f2)
add std and move fileview into it (645b3c6)
add string bindings to the bindingsutil (2164061)
add support for renaming syntaxes (ca4cad8)
add view controllers for petri net syntax (f66ec22)
ctrl + scroll to zoom (1dc590c)
dockerfile for javadoc site (4baa443)
extract all non-default syntaxes into standard plugin (aabe784)
extract inspector panel into std plugins (77dcb31)
new, more complicated example syntax (d8c9327)
petrinet niceness features (650e5aa)
rightclick drag to move the viewport (6b3ce30)

Before I am willing to merge, we should test that the installations are working as expected

[x] macos
[ ] debian based linux
[ ] rpm linux
[ ] windows

Also javadoc for core should be complete


Can't add class to checkbox

I'm not able to add class attribute to the checkbox because it is a fragment

Fixed. Available in the next version.

Thank you


You need to add psr-4 in your composer.json

Hi, docs for configuration or installation lack of info that you need to add path to modules as psr-4 autoload in composer.json
Thanks

You do not if you use the default module path, as they would be contained within the app directory, which is already autoloaded.
You only need to add it to your PSR-4 autoload list if you move the module path outside of app. This is stated in the documentation.


Disposition server crashes

That were logged in QA and Production.  Understand and triage.

The main one I have been seeing that keeps cropping up is:
2024-04-04 03:34:06
serval-api <fail> fail: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HN2JQ55RS8NI", Request id "0HN2JQ55RS8NI:00000038": An unhandled exception was thrown by the application.
      MongoDB.Driver.MongoCommandException: Command update failed: WriteConflict error: this operation conflicted with another operation. Please retry your operation or multi-document transaction..
         at MongoDB.Driver.Core.WireProtocol.CommandUsingCommandMessageWireProtocol`1.ProcessResponse(ConnectionId connectionId,
2024-04-04 03:34:05
serval-api <fail> fail: MassTransit[0]
      R-FAULT loopback://localhost/mediator 01000000-e37e-929f-855a-08dc54799af0 00:00:00.0978377
      MongoDB.Driver.MongoCommandException: Command update failed: WriteConflict error: this operation conflicted with another operation. Please retry your operation or multi-document transaction..
         at MongoDB.Driver.Core.WireProtocol.CommandUsingCommandMessageWireProtocol`1.ProcessResponse(ConnectionId connectionId, CommandMessage responseMessage)
         at MongoDB.Dr
2024-04-04 03:34:05
serval-api <fail> fail: MassTransit[0]
      R-FAULT loopback://localhost/mediator 01000000-e37e-929f-855a-08dc54799af0 Serval.Shared.Contracts.DataFileDeleted Serval.Translation.Consumers.DataFileDeletedConsumer(00:00:00.0449604)
      MongoDB.Driver.MongoCommandException: Command update failed: WriteConflict error: this operation conflicted with another operation. Please retry your operation or multi-document transaction..
         at MongoDB.Driver.Core.WireProtocol.CommandUsingCommandMessageWireProtocol`1.Pro
2024-04-04 03:34:05
serval-api <info> info: Serval.Shared.Controllers.ErrorResultFilter[0]
      Client ZVFeO8livsYcjG8P7zX7eDParKlaNRHN@clients made request:
       {
        "action": "GetCurrentBuild",
        "controller": "TranslationEngines",
        "id": "65398d41e73fc85d889ac695",
        "version": "1"
      }.
       Serval responded with code 408. Trace: 00-ff6acc50a8544d487219668eaf74262a-5e972c6c4ce0353a-00
2024-04-04 03:34:05
machine-job <info> info: System.Net.Http.HttpClient.TranslationPlatformApiClient.LogicalHandler[101]
      End processing HTTP request after 17.6568ms - 200
2024-04-04 03:34:05
machine-job <info> info: System.Net.Http.HttpClient.TranslationPlatformApiClient.ClientHandler[101]
      Received HTTP response headers after 17.5994ms - 200
2024-04-04 03:34:05
machine-job <info> info: System.Net.Http.HttpClient.TranslationPlatformApiClient.ClientHandler[100]
      Sending HTTP request POST http://serval-api:81/serval.translation.v1.TranslationPlatformApi/BuildCompleted
2024-04-04 03:34:05
machine-job <info> info: System.Net.Http.HttpClient.TranslationPlatformApiClient.LogicalHandler[100]
      Start processing HTTP request POST http://serval-api:81/serval.translation.v1.TranslationPlatformApi/BuildCompleted

Basically, it looks like this is happening: https://www.mongodb.com/community/forums/t/mongoservererror-writeconflict-error-this-operation-conflicted-with-another-operation-please-retry-your-operation-or-multi-document-transaction/206298/14
Options include:

Trying up increase the retrying thresholds for transactions.

I found it - we are using the Core API, not the Callback API.  It appears to me that we should use the higher level API.  @ddaspit, do you have any objection?

I don't have a problem with using the callback API, since it retries if possible. We just need to be careful with some cases where transactions are used. There are a couple of cases where there is a "point of no return" in the middle of a transaction and we purposefully make committing the transaction noncancelable.


Error during npm install sharp

I should start off by saying a lot of this falls outside my area of expertise, so I might be incorrectly opening an issue for something that isn’t relevant to this library. Not 100% sure.
When I try to install sharp via npm, I get the following errors:
npm WARN package.json<EMAIL_ADDRESS>No repository field.

><EMAIL_ADDRESS>install /Users/gscottolson/test
> node-gyp rebuild

  CXX(target) Release/obj.target/sharp/src/sharp.o
../src/sharp.cc:119:22: error: use of undeclared identifier 'VIPS_ANGLE_0'; did you mean 'VIPS_ANGLE_D0'?
  VipsAngle rotate = VIPS_ANGLE_0;
                     ^~~~~~~~~~~~
                     VIPS_ANGLE_D0
/usr/local/Cellar/vips/7.42.1/include/vips/conversion.h:65:2: note: 'VIPS_ANGLE_D0' declared here
        VIPS_ANGLE_D0,
        ^
../src/sharp.cc:124:18: error: use of undeclared identifier 'VIPS_ANGLE_90'
        rotate = VIPS_ANGLE_90;
                 ^
../src/sharp.cc:126:18: error: use of undeclared identifier 'VIPS_ANGLE_180'; did you mean
      'VIPS_ANGLE_D180'?
        rotate = VIPS_ANGLE_180;
                 ^~~~~~~~~~~~~~
                 VIPS_ANGLE_D180
/usr/local/Cellar/vips/7.42.1/include/vips/conversion.h:67:2: note: 'VIPS_ANGLE_D180' declared here
        VIPS_ANGLE_D180,
        ^
../src/sharp.cc:128:18: error: use of undeclared identifier 'VIPS_ANGLE_270'; did you mean
      'VIPS_ANGLE_D270'?
        rotate = VIPS_ANGLE_270;
                 ^~~~~~~~~~~~~~
                 VIPS_ANGLE_D270

At some point, the variables VIPS_ANGLE_XXX were renamed to VIPS_ANGLE_DXXX:
https://github.com/jcupitt/libvips/commit/154796a8dc091ad545b6d56896b47e324c1471ab
Is this a version incompatibility with the libvips package? Is there an easy way to resolve this?

Yes, as you spotted, the libvips API for angles changed slightly in 7.42.0.
v0.7.0+ of sharp has the https://github.com/lovell/sharp/commit/46f229e308da94074b6aeaa69b0a9a790ff6c0a2 fix, which allows it to work with versions of libvips before and after this.
If you're going to upgrade libvips and therefore upgrade sharp from v0.6.2, I recommend taking it all the way to the latest v0.8.4 to pick up changes that improved colour/profile handling and image quality.

Thanks, @lovell. I appreciate the quick reply.

@gscottolson Were you able to get this working with a more recent version?

Yes! Thanks for following up. Feel free to close this issue.


[Suggestion] Open config file location button

@Void48 I believe Open in default text editor should usually do the job?

@Void48 I believe Open in default text editor should usually do the job?

That just opens the config file. At least there should be text saying that its located in %localappdata%

@Void48 I believe Open in default text editor should usually do the job?

That just opens the config file. At least there should be text saying that its located in %localappdata%

I believe that's kind of unnecessary, considering how many text editors reveal the path.
(Except the new Notepad, but you can figure that out using Save as)

I'll add an option to customize config file path in settings.

@minusium I believe you should just force the Windows provisioned path for MSIX.

I believe you should just force the Windows provisioned path for MSIX.

I have to do that too.

I believe you should just force the Windows provisioned path for MSIX.

I have to do that too.

Well it isn't difficult to check if the app is in MSIX, at all. In fact there's a NuGet for that (DesktopBridge.Helpers)

Well it isn't difficult to check if the app is in MSIX, at all. In fact there's a NuGet for that (DesktopBridge.Helpers)

I already do that to figure out I should use Win32StartupService or UwpStartupService, it just a call to GetCurrentPackageFullName if it fails then it means app is not packaged.


File.exists? is deprecated, changed to File.exist?

I am going to merge these changes to master after a rebase and merge --no-ff.

Merge rebased.


Mustache on Rails [Documentation]

It seems as though there is no solid way to get Mustache up and running on Rails 2 or 3. Could further documentation or footnotes be added to the read me for this, I feel quite lost in the current status of things.

+1

Try @goodmike's mustache_rails3 project. I actually have yet to try this but I have looked at the code and it looks very, very simple.

Looks like mustache_rails3 has some problems in Rails 3.1. For example, all requests after the first fail with some load path errors.

I'd recommend stache by @agoragames. Works perfectly on Rails 3.1 and 3.2.


Add Local Rate Limit Filter

This is still work-in-progress.. will ping when it's ready for review.


Unclear how to run a flutter_driver test from Atom

I have a test_driver/main_test.dart file in my project. I've opened that project in Atom. I'm not clear how to run this via Atom.
I tried right-clicking on main_test.dart and choosing "Run Application", but that kicked off:
flutter run --checked --debug-port=16162 --start-paused --device-id 84B7N15A07007628 • flutter logs
awesomesauce/ • checked mode • debug
Building APK...
Warning: signing the APK using the debug keystore.
Generated APK to build/app.apk.
Installing app.apk on device.
Running lib/main.dart on Nexus 6P...
Showing Nexus 6P logs:
--------- beginning of system
--------- beginning of main
W/ActivityManager: Permission Denial: getCurrentUser() from pid=22034, uid=10141 requires android.permission.INTERACT_ACROSS_USERS
W/ActivityManager: Permission Denial: getCurrentUser() from pid=22034, uid=10141 requires android.permission.INTERACT_ACROSS_USERS

Which isn't what I expected.
I see a comment in main_test.dart: flutter drive --target=test_driver/main_test.dart, but I don't know how to run that command via Atom. Can I add that to .atom/main.yaml  as a supported run configuration?

cc @yjbanov

I don't think Atom has been taught about flutter drive (or flutter test for that matter).  FYI @devoncarew.  I suspect these will just be command-line only and a small wart in our Atom support for a while.

I'm OK with Atom not formally supporting it. But I wonder what we can do to make Atom not run flutter run if you right click on the driver test and choose "Run application"

Yeah, that part we should fix.

Why should we prevent the developer from being able to launch a driver test app from Atom? After all, it is a plain Flutter app. In some situations a developer might need to debug the test app for a while before they run the driver test. For example, perhaps they want to mock out HTTP with canned data (UI-only integration tests generally won't have a server to talk to).

Why should we prevent the developer from being able to launch a driver test app from Atom? After all, it is a plain Flutter app.

If you can teach us how to launch it, we might be able to edit the main.yaml file used by Atom to control launches.

Sorry, misunderstanding on my part. We should allow the developer to launch the app under test from Atom, but not the driver test, for now. So yes, I fully agree with

make Atom not run flutter run if you right click on the driver test and choose "Run application"

Going to close this in favor of the IntelliJ plugin.


broken test archive tests/issues/issue33_1.zip

Issue33 test fails,
Ark also doesn't open archive: Couldn't load the archive .....

@dfooz Can you give more details: your operating system, how you build it, how you called my unit tests, are you in the good folder when doing unit tests ? ... Your description is too light for me to help you. Strange since my unit tests passed for Linux and Mac OS, did you notice an issue in my tests ?

Closed because I do not have enough information to fix it. Feel free to re-open it with more feedback.


[backport Galactic]  Efficiently handle 3-bytes pixel formats (#743)

Signed-off-by: ahcorde<EMAIL_ADDRESS>[backport Galactic] Efficiently handle 3-bytes pixel formats (#743)

Linux
Linux-aarch64
macOS
Windows


Create Gamm helper method to manipulate into given spot price

Closes: #3003
What is the purpose of the change
Create Gamm helper method to manipulate into given spot price
Brief Changelog

Add a new way we can get the target spot price in a pool

Testing and Verifying
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
How is the feature or change documented?  not documented

Hi @mattverse, can you check this implementation

I have update logic, can you plz check it @czarcas7ic

LGTM, want another review before merge


Data is not sent to the server (using Server Actions) if the input is disabled (disabled=true)

Describe the bug
If I fetch some data from the API and use it as the initial value for the form. And at the same time set the parameter to input disable={true} and then send the form using Next Server Action, then formData for this row is not taken into account and is not sent to the server. If the disabled parameter is disabled, then everything is fine.
Why does it work like this?
Your minimal, reproducible example
https://tanstack.com/form/latest/docs/framework/react/examples/next-server-actions
Steps to reproduce
Set the parameter for the input to disabled (i.e. cannot be edited) and try to send via Server Actions, the data will not be sent.
Expected behavior
The data is transferred to the server regardless of whether I can edit the input or not.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Next.js 14, latest version TanStack Form
TanStack Form adapter
react-form
TanStack Form version
0.29.1
TypeScript version
No response
Additional context
No response

When an HTML form is submitted, the browser only sends the values of the form fields that are enabled. If you have an input field with disabled={true}, its value will not be included in the form data sent to the server. This behavior is by design in HTML, not specific to TanStack Form, Next.js or server actions.
Thank you ChatGPT :) i think this is answer on my "bug".


internal/poll: cancel pending I/O in FD.Close() on Windows

I propose this, roughly
 // Close closes the FD. The underlying file descriptor is closed by
 // the destroy method when there are no remaining references.
 func (fd *FD) Close() error {
        if !fd.fdmu.increfAndClose() {
                return errClosing(fd.isFile)
        }
+       if !fd.pollable {
+               syscall.CancelIoEx(fd.Sysfd, nil)
+       }
        // unblock pending reader and writer
        fd.pd.evict()
        err := fd.decref()
        // Wait until the descriptor is closed. If this was the only
        // reference, it is already closed.
        runtime_Semacquire(&fd.csema)
        return err
 }

And the result is

On Windows, (*os.File).Close() cancels pending I/O operations for all files. I think this is a good feature.
#25835 is fixed. The other ways to fix this are much more complex.
#23019 can be fixed on Windows. #23019 has the same issue with #25835.

Other notes:
CancelIoEx requires Windows vista or later.
https://docs.microsoft.com/en-us/windows/desktop/fileio/cancelioex-func

This sounds like a bug fix, not a proposal, so I've adjusted the labels.
CC @alexbrainman

@crvv if it is a bug fix, I need to see description of a bug. Otherwise I do not know what your change fixes.
Please answer these questions so I can understand what your bug is. Thank you.
What version of Go are you using (go version)?
Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
What did you see instead?

I think I have wrote what the change fix.

#25835 is fixed.

I don't think this issue is a bug fix. It is not a bug for Close not cancelling pending I/O.
This issue just proposes a behavior change and the change happens to fix a bug.

I don't understand the issue here.  Someone is going to have to send a change that includes a test case.  @crvv: Do you want to do that?  Thanks.

I think I should add more details to this issue.
It is about this behavior of Close
https://golang.org/pkg/os/#File.Close

On files that support SetDeadline, any pending I/O operations will be canceled and return immediately with an error.

This is the current situation. The issue is going to cancel pending I/O operations for all files on Windows.
Why this change can fix #25835?
#25835 is that Close is blocked by a concurrent Read. It is equivalent to

What operating system and processor architecture are you using (go env)?
Windows, AMD64
What did you do?
https://play.golang.org/p/Avsxc4QYDhd
What did you expect to see?
call r.Read()
call r.Close()
closed
read |0: file already closed

What did you see instead?
call r.Read()
call r.Close()

and hangs forever.

#25835 is just a complex example of this.
On Unix, the bug is fixed by 0f3ab149ec41cd35a9f61f49ce17bbc5af02537e

On Unix, the bug is fixed by 0f3ab14

The change adds TestCloseWithBlockingRead to the os package. But TestCloseWithBlockingRead (along with all others in pipe_test.go source file) does not run on Windows. I think, first step here - we should make TestCloseWithBlockingRead and all other tests in pipe_test.go run on Windows.  I will try to do that when I have time.
Thank you.
Alex


document-management-page

Create document management page that mimics a DMS dashboard

this is a mock demo for that may look like Alfresco or Hubspot. No need some garbage architecture, just break down the features to tasks.


Can no longer open Sheet after updating to 8.6

After updating from 7.10 to 8.6 and reenabling the module can no longer open the Sheets of any NPCs that have their sheets set to loot sheet

This seems to be working now


Stop appending empty title tags

Description
With the introduction of Gatsby head API, users won't be able to migrate piecemeal because this plugin appends empty <title> tag to pages so that when you specify a Head export with a <title>, you end up with multiple title tags subsequently breaking Seo.
This change ensures that empty title tags aren't appended
gatsby-plugin-react-helmet also introduced a similar change in https://github.com/gatsbyjs/gatsby/pull/36303

Thanks for this :)


Create a footer section

Hi @AtriSukul1508
I am interested to work on the issue.  under JWOC

I would like to work on this . Please assign this to me .

go ahead @PARASnagpal99 ,  while creating a pull request , make sure to attach a screenshot

I want to work on this issue under JWOC

@PARASnagpal99 any updates?

@ManasaKaza you can now work on that issue

I want to work on this issue under JWOC

@TuhinBanerjee31 you can now work on that


Fix: namespace creation optional for csi-secret-store-provider-aws module

Address the issue: https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/1281#issuecomment-1370896054 introduced in the #1281
:bangbang: PLEASE READ THIS FIRST :bangbang:
The direction for EKS Blueprints will soon shift from providing an all-encompassing, monolithic "framework" and instead focus more on how users can organize a set of modular components to create the desired solution on Amazon EKS. We have updated the examples to show how we use the https://github.com/terraform-aws-modules/terraform-aws-eks for EKS cluster and node group creation. We will not be accepting any PRs that apply to EKS cluster or node group creation process. Any such PR may be closed by the maintainers.
We are hitting also the pause button on new add-on creations at this time until a future roadmap for add-ons is finalized. Please do not submit new add-on PRs. Any such PR may be closed by the maintainers.
Please track progress, learn what's new and how the migration path would look like to upgrade your current Terraform deployments. We welcome the EKS Blueprints community to continue the discussion in issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/1421
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

Resolves #

More

[ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Yes, I have updated the docs for this feature
[ ] Yes, I ran pre-commit run -a with this PR

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

Fixed in #1538


[fix][broker] Fix exposeBundlesMetricsInPrometheus=true not working

Motivation
Broker configuration exposeBundlesMetricsInPrometheus was introduced in #9302, but it is true, broker just calculate the size of backlog and didn't expose it.
Modifications

if and only if exposeBundlesMetricsInPrometheus=true, expose the metric as pulsar_subscription_back_log_size

Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change added tests and can be verified as follows:

if exposeBundlesMetricsInPrometheus=false, it shouldn't expose the metric
if exposeBundlesMetricsInPrometheus=true, it should expose the metric

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[x] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[x] doc-required
[ ] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/Shawyeok/pulsar/pull/6

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

PTAL @codelipenghui

@Shawyeok A PIP is required If the change will introduce a new indicator to the metrics endpoint. Please see https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md and the discussion under the mailing list https://lists.apache.org/thread/bmwtk6zcyt4ft4t95jmz1bnsxbysjw8m
I support the motivation.

@Shawyeok A PIP is required If the change will introduce a new indicator to the metrics endpoint. Please see https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md and the discussion under the mailing list https://lists.apache.org/thread/bmwtk6zcyt4ft4t95jmz1bnsxbysjw8m
I support the motivation.

Ok, I'll draft a PIP in the weekend.


drivers: i2c: Move "Use 10-bit addressing" option to i2c_msg

Fixes #3806
Added new message flag I2C_MSG_ADDR_10_BITS while keeping the old flag for 10 bit addressing for backward compatibility.
Modified nrf i2c driver to check this flag instead, now all other drivers should be modified in the same way.

@carlescufi @nashif Could we get this merged?

@MaureenHelm @galak can you take a look at this one?


Better support for exclude config setting

Allows the exclude config setting to be used as well as pretzel > exclude and adds support for folder excludes instead of only by full path.

Thanks for the PR!
Good point about the config setting, but instead of duplicating the setting I think we should only accept the same as Jekyll: exclude.
And please add or modify tests, we don't accept code that is not tested.
One more thing, is it possible that you update the include setting as well?
Thanks.

That sounds like a better option, I'll update and write some tests for the new structure and update the PR.

@laedit Not sure why my other commit hasn't come through to the PR but this has been done.

Great!
Is it possible to include a folder like you made possible to exclude one?

Excellent, thanks!


Fix multiple scroll bars

📦 Published PR as canary version: 1.0.4-canary.29.411.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v1.0.4 :rocket:


Minor dedupe of code in partial_eval.py

By the way, I think we could just make all primitives have multiple results, by making single-result primitives just return a singleton tuple. That would remove the Primitive.multiple_results tag and all the code that switches on its behavior. I'm not sure how that would play out, and it might be a significant amount of work, but I thought I'd mention it in case multiple_results is annoying to you too!

By the way, I think we could just make all primitives have multiple results, by making single-result primitives just return a singleton tuple. That would remove the Primitive.multiple_results tag and all the code that switches on its behavior. I'm not sure how that would play out, and it might be a significant amount of work, but I thought I'd mention it in case multiple_results is annoying to you too!

Are we still hoping to merge this change? (It has conflicts against head, if nothing else.)

I don't know if anyone cares to merge it but I've fixed the conflict!

@mattjj should we merge this?

Closing as stale.


td-toolbelt.rb: uncomment zap stanza

I’m not sure this is correct at all, but it seems like it was commented out before zap was implemented.
@rolandwalker Do you remember what should be done with this?

Yes, it's good.  Something I forgot to do.


Verify how we use year in service

at the moment, we accept an analysis year as an argument of an ImpactAreaStageDamage constructor, but we do not allow the user to specify the analysis year. to use the year in service attribute, we'll need to add analysis year to the stage damage compute control.

I am adding an analysis year to the calculated stage damage. When importing from old FDA is there a value for this year or should I just make it the current year? For now I have added it as the current year.

Just make it current year. 1.4.3 kept track of analysis years differently.

The analysis year has been added to the UI:

The year gets passed into the ImpactAreaStageDamage constructor when computing. I haven't tested what happens in the compute with the addition of this analysis year.
This work was completed on branch scenario_year_894


Lazy load thumbnails

When you have hundreds of photos in an album, the frontend makes a request for all of the thumbnails at once causing reduced performance.  This should also make the thumbnails load in faster since they're only requested when in view.
I'm more than happy to take on this issue, but wanted to make sure it was something that would be accepted first.

I like the idea. What would be the result in the sense of how would it interact with e.g. the Justified layout?
Would the pictures just bee filled with grayed placed holder until you actually scroll to them?
Would you still be able to load the full page little by little, e.g. once the first batch of thumbnail is received you query for the next batch?
 If so do you think this it possible to have it as a setting to enable (either via the more... or via an actual toggle button)?

What I'm experimenting with now is that the layout and page load would be exactly the same but the "image" would be a blank placeholder until you scrolled to it, yes. Not sure if this would be a config option you can toggle or not, that depends on the library I use. Should that be a requirement as I look into doing this?

not necessarily a requirement, but if the page still load completely while you are not scrolling (like first load the part you are scrolling and then load the rest) then I think it is fine.
One of the use case is you want to show a specific picture to someone but you don't really remember where it is in your album aside from it is in the bottom. How would that work with the lazy loading? :)

How would you normally do that now? Just jump all the way to the bottom?

yup and let firefox / chrome / IE load those pictures first. :)

It takes my browser about 1.2 s to fully load this page with 472 pictures : https://photography.viguier.nl/gallery#1551392811988

Right, so with what I'm doing, if you just hit "page down" then it will jump to the bottom of the page and only load those images. It will probably load the ones at the top first as well since the page loads at the top, but you skip over the ones in the middle so they shouldn't get loaded.
I'm about to submit a PR. Give it a test drive and let me know what you think.

:+1:

PR submitted. This will also make mobile performance much better as well as saving on bandwidth.

@ildyria FYI, your gallery page took 28.85s to load for me... And that's with a >100Mbps download link. So I certainly think that what @alex-phillips proposes has value :smile:

:smile:


Error on drag when sortHandle contains an SVG

My sortHandle is a span containing an SVG icon, but when I try to drag on it, I get this error: Uncaught TypeError: e.target.className.indexOf is not a function
The culprit is this line; for an SVG, the className is not a string but an SVGAnimatedString object, which does not have an indexOf property. This case should probably be handled somehow.

Yeah, thanks for your digging, will be fixed soon.

By the way, is your sortHandle defined on a SVG element?

No, it's a span that contains the SVG.

Hi, 1.4.2 should resolve this issue, and here is related test suite.

Excellent, thanks for the swift fix.


TOML: Improve Track attributes

In GitLab by @mclemente on Dec 12, 2023, 01:50
Add a "repeat" property which sets how many times it is generated on a sheet.
Also add a text input field to set the names of the factions.
Related to #104 (move Tracks there) and #106 (rework data).

In GitLab by @mclemente on Dec 12, 2023, 01:50
added #91 as parent issue


[* NumberWithUnit] Unit should be normalized and not language dependent

using french language, "20 kilometres" resolves to [ value = 20, unit = "Kilomètre" ]
using english language, "20 kilometers" resolves to [ value = 20, unit = "Kilometer" ]
Shouldn't the units be normalized using international/imperial system of units (km, mi, Euro, USD...) or at least have same constants for all languages ? This would be easier for conversions and data process.

Hi @RomainWilbert,
thanks for the feedback. Users had previously requested to have the "localized unit name" in the response.
But we agree that a standard/normalize unit name is very useful in many scenarios and we plan to also have a separate field for the SI unit (or equivalent).
Currency is the first to get it. English Currency already has isoCodes for the units.
Other languages are coming soon, followed by other units.

Any contributions are also greatly welcomed! :)


Check for comma after async keyword to make sure we are parsing an async function

In object literal short hand case the async, when used as a var name, can be followed by a comma. We were not considering this case which was causing a SyntaxError.

Fixing https://github.com/Microsoft/ChakraCore/issues/4158


Reference frames in ant_imu_leverarm.yaml and vehicle_imu_extrinsics.yaml

Hello,
I'm trying to use MSF localization according to https://github.com/ApolloAuto/apollo/blob/master/docs/howto/how_to_run_MSF_localization_module_on_your_local_computer.md. I have a couple of questions as follow.
Q1. Could you let me know the reference frame of offsets in modules/localization/msf/params/gnss_params/ant_imu_leverarm.yaml? Is it IMU frame or Vehicle frame?
Q2. Could you let me know the reference frame of translation and rotation in modules/localization/msf/params/vehicle_params/vehicle_imu_extrinsics.yaml? Is it IMU frame or Vehicle frame?

@robotsoft
For Q1, the ant_imu_leverarm.yaml, there is no Vehicle frame. It is the offset(extrinsic) between imu(Novatel) and the two antennas, the primary and secondary antenna, for the purpose of 双天线测向.
For Q2, vehicle_imu_extrinsics.yaml, it is extrinsic between Vehicle Frame and IMU Frame. While, in apollo coordinate definition, the Vehicle Frame is same as the Novatel(IMU) Frame exactly, whose original is the rear center of the vehicle.

@xmyqsh,
Do you mean I need to leave vehicle_imu_extrinsics.yaml by default even though IMU frame and Vehicle frame is different in my platform? If not, could you let me the reference frame of vehicle_imu_extrinsics.yaml? Is it IMU frame or Vehicle frame?

@robotsoft It depends on your definition. Questions like who is the parent or child frame, it doesn't matter. Just cope with it in the code accordingly.  Well, it indeed does matter from the aspect of calculation efficiency, error propagation, and code convenience.
Anyway, I think most people like to set the Vehicle frame as the parent frame.
On the other hand, it is best for you to set the Imu(Novatel) Frame the same as Vehicle frame if it is possible. First, the imu's frequency is the highest. Attaching IMU on the Vehicle Frame could get rid of lots of calculation.  Second, you can not find a data-driven method to calibrate the extrinsic matrix between your Imu and Vehicle Frame if there is no sensor attached on your Vehicle Frame.
Also, it is best to bundle Imu and Gps together as Novatel does. Because Imu can only generate relative data.


[SMALLFIX]Replace collections.sort() with list.sort

Change
Collections.sort(sortedCRF, Comparator.comparingDouble(Entry::getValue));

to
sortedCRF.sort(Comparator.comparingDouble(Entry::getValue));

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, check this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2891/
Test FAILed.

Open another new pull request

Open another new pull request


#2726 Bump MSRV to 1.8, so we can drop lazy_static (leptos 0.7 )

As state in the acompaning issue #2726 the drive of this issue is to reduce the attach surface
by removing a dependecy.
It been suggested here
https://github.com/leptos-rs/leptos/pull/2727#issuecomment-2258746196
That I generate a PR for 0.7
In terms of review , the follwing change is needed to pick up a nighlty build .. consistent with the new rust version 1.8

rust-toolchain: nightly-2024-04-14

rust-toolchain: nightly-2024-07-26

the jump to the new branch, means I had to reimplement the idea behind the patch .. not just copy and paste. .. so there manybe some unexpected build errors.

When I visually inspect that last auto matic merge .. I see errors
The best next step is the close .. and reupload a clean PR
Sorry for the noise.


[HOLD for payment 2023-05-23] Show individual split amount on Bill Split IOU Previews

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Within bill split IOUPreviews, show the individual's split amount in the IOUPreview.
Bill Split IOUPreview DD section for reference (you won't find anything specific to this task though).
Action Performed:

Create a bill split with 3+ users
Look at the IOUPreview
Beneath the participant avatars, the Split AMOUNT is missing

Note: Don't worry about the missing Chevron icon, font, ect. that's being done here.
Current

Desired

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: main
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01989c5cb9060980c4
Upwork Job ID:<PHONE_NUMBER>533535744
Last Price Increase: 2023-05-10

Merged the PR

Ah, the internal label tripped me up (I have like +10 to get through since coming back from EC3).
Okay, so do you want to accept the offer and I'll increase to $1,500? I've also sent an offer of $1,500 to @Santhosh-Sellavel for the review.

Settled up with @0xmiroslav. Awaiting @Santhosh-Sellavel.

Donezo!


LUCENE-9823: Fix not to rewrite boosted single term SynonymQuery

Description

When rewriting a SynonymQuery with a single term, we create a BoostQuery wrapping a TermQuery.

However,

it now multiplies the final TermQuery score instead of multiplying the term frequency before it's passed to the score calculation.

JIRA: https://issues.apache.org/jira/browse/LUCENE-9823
Solution
Remove unsafe codes of SynonymQuery and CombinedFieldQuery.
Tests
Added:

TestSynonymQuery#testRewrite

Fixed:

TestCombinedFieldQuery#testRewrite

Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] ~I have created a Jira issue and added the issue ID to my pull request title.~ I've picked newdev ticket
[x] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.

Thanks for reviewing, @jtibshirani !
I added TestSynonymQuery#testRewrite and fixed the same problem of CombinedFieldQuery. I may not fully understand the meaning of:

The same consideration affects CombinedFieldQuery in sandbox.

If the fix of bc85a2a is  incorrect, please explain what is the same consideration.
Thanks.

Thanks for explaining and reviewing again!
I fixed :)


created at date crash in PCMultipartMessage

What?
Offending line per the attached crash report:
let createDate = pcMultiPartMessage.createdAtDate

May also be of interest:
nsexception
{
  "name": "NSInvalidArgumentException",
  "referenced_object": {
    "address": -9223372036854776000,
    "type": "objc_object",
    "ivars": {
      "tagged_payload": 0
    }
  }
}
reason
-[NSIndexPath countByEnumeratingWithState:objects:count:]: unrecognized selector sent to instance 0x8000000000000000
type
nsexception

Environment

**PusherChatkit version:**1.4.4
**Xcode version:**10.2.1
**Swift version:**4.2
**Platform(s) running PusherChatkit:**iOS

Demo Project (if you have one; it helps a lot!)
The symbolicated crash report:
bugsnag_error_stacktrace_NSInvalidArgumentException_event_5cbeccb90037e2bc06b60000.txt

I also encountered a similar issue, it has been fixed in 1.7.2 / 1.7.3

Since @SeanLintern implied that this issue is fixed and because we haven't heard anything further in some time I am going to close this issue.  Please re-open with more details if this is still an issue on the latest version of the SDK.


Add Bubble Sort (C)

Bubble sort is an algorithm used to efficiently arrange the different objects of an array in a specific order.
The working branch should be c
The branch can be found here
The changes should be in /Sorting/Insertion Sort
The file should be named bubbleSort.c
Happy Open-Sourcing!

I am up for this task 👍

Sure! Go ahead and make a PR! Make sure that the branch is C

We are not assigning anyone right now

please check