Discussion: Handle data type of response data type in HeuristicsProductNavigationPage (BrowserResponse vs HttpResponse)

Problem
Currently, HeuristicsProductNavigationPage uses HttpResponse as one of the dependencies (code ref). This causes the spider to send 2 separate requests to ZAPI if the extract_from parameter is set to "browserHtml":

{"productNavigationOptions": {"extractFrom": "browserHtml"}, "productNavigation": true, "url": "https://books.toscrape.com/"}
{"httpResponseBody": true, "url": "https://books.toscrape.com/"}

This is also true when it's left to the default value which is extract_from=None.
Note that this issue is not related to https://github.com/scrapy-plugins/scrapy-zyte-api/issues/91 since https://github.com/scrapinghub/scrapy-poet/pull/175 has addressed it.
The problem that we face is that the dependency of HeuristicsProductNavigationPage should be dynamic depending on the extract_from input value:

response: BrowserResponse, if extract_from=browserHtml
response: HttpResponse, if extract_from=httpResponseBody

I think https://github.com/scrapinghub/andi/pull/30 should allow to express this kind of dependencies in page objects.

Yes, it would 👍
Though some new interface in page objects should be made to allow declaration of dynamic dependencies. For example, depending on the extract_from value, it would logically switch between BrowserResponse or HttpResponse.

@BurnzZ I've checked this approach with AnyResponse for Articles and it's actually resolves handling the case with extract_from (browserHtml or httpResponseBody) argument for spider.
But the issue with doubling the requests is still here.

After double checking I see that this is working, thanks!
In my case, previously, doubled requests were only for HttpResponse, and for BrowserResponse everything was in one response.
Now, I'm just curious if we can handle HttpResponse the same way as BrowserResponse here https://github.com/scrapy-plugins/scrapy-zyte-api/pull/161/files#diff-67cea92ffa3989fe30ffd7f4bbe868f953810e0f4fdf2ddfe7f18bc54fba505eR81 - at this moment PO with HttpResponse is not even handled by ZyteApiProvider

Both browserHtml and httpResponseBody should be handled @PyExplorer . For the latter, was the extract_from spider parameter input updated to httpResponseBody?

Yes, extract_from is httpResponseBody, but I mean that here https://github.com/scrapy-plugins/scrapy-zyte-api/pull/161/files#diff-67cea92ffa3989fe30ffd7f4bbe868f953810e0f4fdf2ddfe7f18bc54fba505eR81 in to_provide we don't have HttpResponse (if we asked response: HttpResponse in PO) but we have BrowserResponse (if we ask response: BrowserResponse) in PO

in to_provide we don't have HttpResponse (if we asked response: HttpResponse in PO)

The PR in https://github.com/scrapy-plugins/scrapy-zyte-api/pull/161 has been updated so that providers can also use the instances created by earlier providers. That is, HttpResponse is made by HttpResponseProvider. Later on, AnyResponse can be created by ZyteApiProvider as it can use the HttpResponse that was made earlier.
The new PR in https://github.com/scrapinghub/scrapy-poet/pull/184 also made this possible.


FileUpload imageEditor cannot restrict free cropping

Package
filament/forms
Package Version
v3.0.0
Laravel Version
v10.10
Livewire Version
No response
PHP Version
8.1
Problem description
Cannot crop based on Aspect Ratios.
FileUpload::make('image')     ->image()     ->imageEditor()     ->imageEditorAspectRatios([         '1:1',     ])

Expected behavior
User can only crop based on permitted aspect ratios.
Steps to reproduce
->imageEditorAspectRatios([         '1:1',     ])
Reproduction repository
https://github.com/NaungYeHtet/filament-ascept-ratio
Relevant log output
No response

When there is only one aspect ratio, you can use imageEditorViewportHeight and imageEditorViewportWidth to force the aspect ratio.
It's not very clear and I'm not sure those 2 methods do what their name suggest.


TailwindCSS 2 Support

A bit of dependancy inception but TailwindCSS 2.0+ depends on PostCSS 8.  Where this (otherwise amazing) Gridsome plugin depends on postcss-import-url, which is presently NOT PostCSS8 compatible, and cannot switch to TailwindCSS 2.
In looking at postcss-import-url, this module is sporadically maintained.   Would it be possible to fork it to provide the functionality needed for this plugin so that we can migrate to PostCSS 8, and thus migrate to TailwindCSS 2.0?

Should drop support for the URL plugin TBH.

@thinkflo does the compat build work?

I have what I assume is a related issue. I get Error: PostCSS plugin tailwindcss requires PostCSS 8. when trying to run gridsome develop today after installing the plugin in a newly created site.
I am a bit clueless about managing node packages, how can I force gridsome-plugin-tailwindcss use an older version of tailwind? I tried installing the compatibility build mentioned here but that didn't seem to affect the version the plugin was using. Any help much appreciated!
Cheers
Alex

https://github.com/brandonpittman/gridsome-plugin-tailwindcss/releases/edit/untagged-60868df1c7d3c0fc9d97 should sort this out.
All deps are now peer deps.

@brandonpittman sorry but in the end what's the proper way to use 2.0 now? Is there a working example?

@sergeyfilimonov Are the instructions in the README not working?

@brandonpittman nope:

@sergeyfilimonov That's probably Gridsome's fault. Try the Tailwind 2 compat version.

@brandonpittman thanks! It helped but the instructions of Tailwind lack information on postcss-import. One should not install v.13, it should be yarn add postcss-import@^12. Otherwise when shouldImport is set to true you'll get an error about PostCSS 8 as well.

@sergeyfilimonov Big reason why I turned off the plugins by default. I don't use any other PostCSS plugins either. I'd recommend organizing your code so that you don't need @import. I also haven't used @apply in a year either. I really wish I had just pulled out the shouldImport and shouldTimeTravel configs.

@brandonpittman what if you want to create some global classes like .h1, .h2, .h3 — where would you put this? In the main Layout? Or if you need to create some animations which often have tens of lines of code. This all needs to be put in separate files which have to be imported.

Yeah, I'm in a similar boat.  Too many PostCSS errors.  The 7 compat version doesn't help.  And I need to be able to use @apply since there is inline HTM I am rendering in Gridsome templates that come from a WYSIWYG editor in a CMS. So I don't have a way to decorate the elements with tailwind classes so I @apply them using selectors.  Losing this ability is a dealbreaker.

@thinkflo check this https://tailwindcss.com/docs/installation#post-css-7-compatibility-build and my reply https://github.com/brandonpittman/gridsome-plugin-tailwindcss/issues/68#issuecomment-735773442 — it works fine for me now with these versions.

Will try.  Thanks!

So this won't resolve until postcss-import-url updates? It'll be a while, looking at that package's changelog... I agree with @brandonpittman, that package should probably be dropped or at least forked for the time being. Should I file a compatibility issue on the Gridsome repo?

@Sergix fork it if you want.

@brandonpittman  I am not sure but if I am not using shouldImport and shouldTimeTravel then the plugin should work right?


fresh install - help to setup

The Error:
solid-styled.js  Uncaught (in promise) Error: Unexpected use of css. Make sure that solid-styled's plugin is setup correctly.
Tested with fresh installs of,

vite 4.4.5 solidjs 1.7.8
vite 5.0.0 reverted to 4.4.5 solidjs 1.8.5 (Vite 5 not yet compatible with solidjs)

npm i solid-styled
npm i -D postcss

In app.jsx added before the App function return statement:
import { css } from 'solid-styled';
css`
    .read-the-docs {
      color: red;
    }
  `;

Then error in browser console as mentioned at the top.
Also tried

Got the plugin for vite working, but with issues, will open another issue if cannot resolve.


Update Mapped Types.md

Instead of this one https://github.com/microsoft/TypeScript-Website/pull/1854.

Thanks!


Prysm: wrong alerts for slashing

User reported issue with getting alerts, but they are not correct. Validators are not slashed and node works as intended (source beaconcha.in). Validator public keys/indexes won't be posted here to keep the user's funds anonymous.

probably caused by https://github.com/grafana/grafana/issues/19163
I think I reproduced it - it's fixable by removing ONE panel (the entire panel, not just the alert) with an alert, then adding the same panel again and also add the alert. All other firing alerts switch back as soon as the new alert on the new panel is saved along the dashboard.

probably caused by https://github.com/grafana/grafana/issues/19163
I think I reproduced it - it's fixable by removing ONE panel (the entire panel, not just the alert) with an alert, then adding the same panel again and also add the alert. All other firing alerts switch back as soon as the new alert on the new panel is saved along the dashboard.

closing due to inactivity


Added missing STL header includes

Without these includes, megamol failes to compile with GCC 11.2.0 (tested on Arch Linux 5.16.4-arch1-1).
Summary of Changes
#include <limits> for std::numeric_limits in MultiPerformanceHistory.h
#include <memory> for std::shared_ptr in Log.h

/format

@Thinkpiet could you please clang-format the files? CI is probably hoping for an alphabetical order of includes and the bot cannot manipulate your fork, it seems...


UI sending notifications despite setup

Bug description
Despite podman UI showing that podman has been setup and is running,

And resources UI confirming the same,

Same confirmed from the cli as well
$ podman machine ls NAME         VM TYPE     CREATED      LAST UP            CPUS        MEMORY      DISK SIZE podman-rhel  wsl         9 hours ago  Currently running  4           1GiB        100GiB
Podman UI keeps sending notifications that Podman needs to be setup.

Operating system
Windows 10 Enterprise
Installation Method
Installer from website/GitHub releases
Version
1.12.0
Steps to reproduce
On windows 10 Enterprise
Install using the airgap installer for v1.12.0 and setup a RHEL machine.
once your machine is setup, you should intermittently observe notification pop-ups on your desktop that podman needs to be setup.
Relevant log output
No response
Additional context
No response

Same issue on Win 11 popping up continually every ~30s or less.

https://github.com/user-attachments/assets/870d7ce5-b6dc-4587-9e8b-40a3fc33edaf
Should have same versions and rhel image, but cannot reproduce


chore(deps): update css-loader to version 6.11.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.287%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
288

Relevant Lines:
337

💛  - Coveralls


Support multiple server

Expand configuration to ask multiple bamboo server in the query.

#3

Implemented in #3


Make the built-in VS XAML language service work with Avalonia

The built-in XAML language service expects the XmlnsDefinitionAttribute in the System.Windows.Markup namespace. If we only move Avalonia's attribute there, we would get a lot of the XAML functionality working without the VS extension. I think it can go a long way to reduce friction in adopting Avalonia.
To make everything work, I also added the ContentProperty, so the designer would be aware of child elements.
There's just one ugly workaround - the ItemsControl.Items property is IEnumerable, so the designer won't allow adding children to it. I had to create an IList ItemsList property that shadows it to use as the content property.
WDYT?
Completion & namespaces:

Markup extensions:

Some validation:

At first, I've also tried the approach of making VS to support our XAML, but ended up with my own implementation.

It will cause compilation errors in applications where Avalonia is embedded into WPF application.
We already have basic autocomplete for properties. Our extension currently only lacks binding completion. Which we'll have to implement ourselves anyway, since we have custom extensions and VS won't be able to detect DataContext type for for styles and templates. Support from the native XAML language service will never be perfect.
It will also limit us in stuff that we want to do in the future (e. g. we won't be able to add/change something, because it breaks support from VS).

In my opinion, this change won't introduce enough value to outweigh those points.

We might get away with compilation errors by using type forwarding, but I still don't think that it's worth the trouble.

I don't think it would introduce that trouble.

It's easy to work around these using extern alias (I've done this in the Avalonia.Win32.Interop assembly). I don't think type forwarding would help since the namespace is what matters to the language service.

Additionally, I believe this kind of situation should be very rare - you'd have to actually apply those attributes in one of the assemblies that reference both Avalonia and WPF.
Another point - I wouldn't expect many people to actually need the WPF interop, but I may be wrong. Was it born out of user requirements of was it just easy to implement?

Not perfect may be good enough for a lot of people. Like many others, I choose which extensions I install into VS very carefully, since they can dramatically affect my daily productivity. And if I could get by with basic completion without adding another designer I'd do it.

DataContext may work by adding the d:DataContext design-time attribute.

Can you give an example? I don't see how this would be limiting. These two attributes are basically the only thing needed for the language service to work properly.

Lastly - Microsoft is standardizing XAML. I think we should get on board instead of forking, especially for the most basic stuff. Those attributes are in System.Xaml (which might also go netstandard in the future).

Pseronally, I'm on the fence about this. I agree it would be really nice to have but do worry about copying a class from the BCL with an identical namespace!

Closing this for now. I will find another way to hack the XAML language service without modifying Avalonia.

I know this item is closed, however, I'm upgrading Prism.Avalonia to Prism v8.1 and the ModuleCatalog requires the [ContentProperty("Items")] attribute.
What (if any) is the current workaround for including using System.Windows.Markup;?

@DamianSuess Avalonia has content attribute, which is assignable on the specific property.

@maxkatz6 thank you, I appreciate the feedback & will look onto it more so.
In the meantime of using [content], will we ever see a more XAML compliant contentproperty feature? This way we can stay aligned with WPF WinUI/UWP, & Xamarin/MAUI syntax.

is there any functional differences between Content and ContentProperty? If there's none then i'm not sure there's any merit in matching their naming.


gitlab - not not add/remove undefined labels - 41

[Auto generated]
Number: [#41]

github-gitlab-webhook-server: Closing issue for PR: gitlab - not not add/remove undefined labels.
PR was closed.


Difftool poorly handles new or deleted files.

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:34:09.706Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author (truncated)
Version

githistory
don
0.2.2

haskell-linter
hoo
0.0.6

Ionide-fsharp
Ion
2.28.0

hoogle-vscode
jca
0.0.4

language-haskell
jus
2.3.1

csharp
ms-
1.11.0

PowerShell
ms-
1.4.1

vs-keybindings
ms-
0.1.7

elm
sbr
0.14.1

code-spell-checker
str
1.3.2

haskero
Van
1.3.1

vim
vsc
0.9.0

markdown-pdf
yza
0.1.7

Reproduces without extensions: Yes (via disable them all, before)

I have Git (2.13.3.windows.1), configured as:
[diff]
  tool = vs_code
[difftool]
  prompt = false
[difftool "vs_code"]
  cmd = code --wait --diff \"$LOCAL\" \"$REMOTE\"

I have a sample repository which contains: one new, one removed and one edited file. All those files are added to the index.
Steps to Reproduce:

In an external console, just type: $ git difftool --cached
An existing and modified files will display in two column diff - as expected.
Added file will display as just opened file - nothing indicates it is a diff's window.
Removed file displays also like opened file, but with strange name suffix (from Git?) - also hard to spot as diff.

I would expect that new or removed files will be display with empty left or right column respectively. New file has not any previous version, so left side of diff is empty. Deleted file has not any future version, so current version (right side of diff) should be empty.
Also I do not understand why we have to run VS Code with a --wait flag for diff, and block Git until VS Code window was closed. Without the flag: --wait, Git could open multiple VS Code's tabs (with a flag: --reuse-window), so I could start difftool and then go for a coffee and then just see all changes without wait for open every instance of VS Code. But --diff without --wait does not work at all: modified files are displayed in separated tabs without the diff view and new or deleted files behave as described in this issue.

@bpasero If one of the diff files is empty, is should appear as empty in the workbench.


Loop with branches and 'continue' causes incorrect results

The following function gives incorrect results when compiled with Numba 0.22.0:
from numba import jit

def loop_with_branches_and_continue(x):
    ret = 2
    for _ in range(1):
        a = x
        if a != x:
            if a != x:
                a = x
            continue
        if a == x:
            ret = a
    return ret

def test():
    pyfunc = loop_with_branches_and_continue
    cfunc = jit(nopython=True)(pyfunc)

    x = 1
    expected = pyfunc(x)
    got = cfunc(x)

    assert expected == got, 'expected: {}, got: {}'.format(expected, got)

if __name__ == "__main__":
    test()

Can you reproduce this? I tried to minimize the example but did not look at any compiled code, so I have no idea what is causing it.

I can reproduce this error.

The bug:
There is an erroneous del a inserted after the innermost assignment to a in the numba IR.
def loop_with_branches_and_continue(x):
    ret = 2
    for _ in range(1):
        a = x
        if a != x:
            if a != x:
                a = x   # `del a` inserted after this line
            continue
        if a == x:
            ret = a
    return ret

This is likely to be a bug in the lifetime analysis.  That somehow has a nonlocal effect.

Looks like this is resolved by #1611.


Healthchecks for notary-server

Fixes #190.
This PR makes notary-server unhealthy if:
- the connection to the trust service is dead
- it takes too long to answer an RPC call
- the trust signer service is unhealthy
- the trust key manager service is unhealthy

the DB does not have the right tables

Update: It logs an error if the following are true:

the connection to the trust service is dead
it takes too long to answer an RPC call
the trust signer service is unhealthy
the trust key manager service is unhealthy

Since the server can operate with the signer down, but someone should get paged.
Note that the DB table query times out after a little while, the GRPC one seemed to hang forever (by which I mean about 10 minutes by wall clock).  It keeps trying to reconnect, but meanwhile the outstanding RPC call blocks.
The timeout should probably be in the distribution/health package, but since passing timeout arguments to all the functions breaks the existing API, maybe the health package should be split out and then projects can pin to a particular version or not?

Other than the debug flag, LGTM
Everything else is just notes, mostly about things I'd like to tighten up so we don't accidentally abuse structs we've exposed in the future.

@endophage Have addressed the review comments other than unexporting NotarySigner, if you wanted to take another look.

LGTM.
Love the tests. Big fan of lots of short tests.


Unable to run linux container on windows using ctr and lcow

Description
It seems that there is a bug preventing users from being able to run linux containers via ctr, on windows host using lcow. Discussion that led to discovery can be found on the containerd slack.
Steps to reproduce the issue
On a windows host...

Pull alpine image  . 'C:\Program Files\containerd\bin\ctr.exe' images pull --snapshotter windows-lcow --platform linux docker.io/library/alpine:latest
Attempt to run image . 'C:\Program Files\containerd\bin\ctr.exe' run --isolated --platform linux --runtime io.containerd.runhcs.v1 --rm --snapshotter windows-lcow docker.io/library/alpine:latest lcow-test sh -c "hello"
Observe image cannot be ran, output: ctr: no match for platform in manifest sha256:21a3deaa0d32a8057914f36584b5288d2e5ecc984380bc0118285c70fa8c9300: not found

Describe the results you received and expected

Expected output: hello
Received output: ctr: no match for platform in manifest sha256:21a3deaa0d32a8057914f36584b5288d2e5ecc984380bc0118285c70fa8c9300: not found

What version of containerd are you using?
containerd github.com/containerd/containerd v1.5.7 8686ededfc90076914c5238eb96c883ea093a8ba
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

Thanks for this! I'll look into things, hopefully by EOW

Sorry for the delay here, I'll put in the relevant platform functionality soon for ctr, however there was another issue in the shim that you would have hit shortly after. That's being resolved here https://github.com/microsoft/hcsshim/pull/1270 (whenever we decide what approach to take haha). Hopefully we can get this in before 1.6. Question though, you'll need a rootfs with the guest agent inside (https://github.com/microsoft/hcsshim/tree/master/cmd/gcs), and a kernel to use. LCOW works by booting a lightweight vm to host the containers and not by emulating anything and running on the host itself.

so how do you fix this problem?

Is this problem fixed? Can we run linux container without docker desktop but only containerd.io?

Is this problem fixed? Can we run linux container without docker desktop but only containerd.io?

I think the problem still exists

This is such a shame - it looks like the only option to run linux containers on Windows is via mirantis or WSL...

Like u say. For my understanding, as we run containerd on windows there exists no linux context to run linux containers. Container tools like "Docker Desktop", "Podman Desktop" are using the WSL and set-up a vm to run the linux containers.
It would be awesome to get it work within "containerd"!
and nice to get an answer/link just if it would be possible (in future) or not.

From what I understand from my limited research, this is what made it possible: https://github.com/linuxkit/lcow


Error with running multiple training commands on a single node

FileNotFoundError: [Errno 2] No such file or directory: '~/.cache/torch_extensions/py39_cu121/gsplat_cuda/lock'
This happens only when I have multiple training scripts running on the same machine.
Here is the trace:
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/nerfstudio/models/base_model.py", line 143, in forward
    return self.get_outputs(ray_bundle)
...
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/gsplat/project_gaussians.py", line 61, in project_gaussians
    return _ProjectGaussians.apply(
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/torch/autograd/function.py", line 539, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/gsplat/project_gaussians.py", line 110, in forward
    ) = _C.project_gaussians_forward(
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/gsplat/cuda/__init__.py", line 7, in call_cuda
    from ._backend import _C
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/gsplat/cuda/_backend.py", line 73, in <module>
    _C = load(
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1308, in load
    return _jit_compile(
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/torch/utils/cpp_extension.py", line 1722, in _jit_compile
    baton.release()
  File "~/miniforge3/envs/gs/lib/python3.9/site-packages/torch/utils/file_baton.py", line 49, in release
    os.remove(self.lock_file_path)
FileNotFoundError: [Errno 2] No such file or directory: '~/.cache/torch_extensions/py39_cu121/gsplat_cuda/lock'

Any idea how to fix this?

This is caused by multiple JIT building happens at the same time and every JIT building is trying to remove the same lock file after building.
One solution is that you build the gsplat at installation to avoid JIT building. This can be done via pip install .
The other solution is a bit hacky, which is to comment out the error raising line:

File "~/miniforge3/envs/gs/lib/python3.9/site-packages/torch/utils/file_baton.py", line 49, in release
os.remove(self.lock_file_path)

@liruilong940607 Thanks for explaining this.
Can you please elaborate what you mean by this:

One solution is that you build the gsplat at installation to avoid triggering JIT building. This can be done via pip install .
Which installation are we building gsplat at? Do you mean before every training script starts running?

@liruilong940607 If there is a better way to fix this (by adding a few checks in the cuda/__backend__.py), I can add a PR for that. Please let me know how to do so.

Btw, why would the initial import fail:
  File "/srv/flash1/gchhablani3/miniforge3/envs/dn_splat/lib/python3.9/site-packages/gsplat/cuda/_backend.py", line 56, in <module>
    from gsplat import csrc as _C
ImportError: cannot import name 'csrc' from 'gsplat' (/srv/flash1/gchhablani3/miniforge3/envs/dn_splat/lib/python3.9/site-packages/gsplat/__init__.py)
```?

I would love to have a fix for this but honestly I dont know what to do about it. If you have any idea I would love to hear it!

It should now be fixed on the main branch with the above PR. If not feel free to reopen it!


Deprecate old java date times (Joda and java.util) use java.time instead

Deprecate old java date times (Joda and java.util) and replace them with Java8 time (java.time).

Modify java.time converter from UTC to ZoneId.systemDefault() to be aligned with previous logic (of Joda time LocalDate).

This might break someone's production.


Add the unstable feature and document it

Is this used by anything at the moment?

It will be used by the channel-api and the new rc api


Passing a negative argument to nth or every doesn't error

In Nushell, passing a negative argument to nth or every gives a range error. In engine-q, negative arguments to these commands are cast to usize by usize's implementation of FromValue instead of giving an error. For example, on 64-bit targets, nth -1 will get the<PHONE_NUMBER>3709551616th row of the input.
I think it would probably make more sense for these commands to error when a negative argument is provided.

agreed.

This problem is also in many other commands taking a SynatxShape::int and internally converting it into an usize. The problem is the implementation of FromValue for usize; in some places there are also as u[64, size] (e.g. crates/nu-command/src/filters/first.rs:69).
I think there should be a TryFromValue.


Number of views by loaction

As a service manager, I would like to see how many visitors from Europe have viewed ScholarSphere content, so that I can help demonstrate the global reach of the service.

@patriciahswe & @mahirakgun I think the view are possibly covered by google analytics: https://analytics.google.com/analytics/web/?authuser=0#report/visitors-geo/a33252017w60487619p61852754/


crates: add wonnx

wonnx is a very promising GPU inference runtime for neural networks represented in the ONNX format. As it uses wgpu, it can run anywhere where wgpu runs (and the features it requires are available), including the web!

Currently this change won't render if merged because of #112. But since wonnx is already published to crates.io, it is preferable to add it with:
- name: wonnx
   topics: ["neural-networks", "gpu-computing"]

The rest of the metadata can be pulled from the crates.io API.

Looks good. Last ask before I merge would be to move it up to being sorted alphabetically by crate name (i.e. around line 364)

Done - apologies about the delay. I initially had it alphabetically sorted, but wasn't sure because of the non-alpha entries at the end. Might want to add in a delineating line until #112 is fixed?


Send ocr processing messages to active mq

add functions to send task action messages to ocrd_lib.sh
update activemq client
use process function to set task from OPEN state to INWORK
use close function to close task over task action message queue

Very nice!
I see a couple of points that still need to be addressed:

the ERR trap currently only logs locally, but should now also be used to signal via MQ; I suggest adding a line to logerr which uses kitodo_production_task_action_error_open with a suitable custom message (involving $BASH_COMMAND and/or $(caller) to be as concrete as possible)

For Kitodo I suggest to prevent detailed messages. I think the user should only be informed that a problem occurs and get more information in the monitor to fix the problem.

in case the Kitodo side does not have the right version installed, shouldn't we fall back to the old KitodoProduction.FinalizeStep.Queue interface?

Currently, I am not sure how we can find out. Do we provide another enviroment variable with which to pass the Version of Kitodo? Or do we expect the Kitodo Version as a parameter to the Kitodo script.

we must make sure that if no Kitodo is configured, then also ACTIVEMQ stays empty. Currently it will read : and fail. So either catch that specifically, or avoid just setting $MQ_HOST:$MQ_PORT in docker-compose.yml

Good point i will change this.

For Kitodo I suggest to prevent detailed messages. I think the user should only be informed that a problem occurs and get more information in the monitor to fix the problem.

Yes, the details are already in the OCRD logs that can be viewed in the Monitor. We could also just use your default message – but we must add the signal.

Do we provide another enviroment variable with which to pass the version of Kitodo? Or do we expect the Kitodo version as a parameter to the Kitodo script. Alternatively maybe a flag but we can not introduce flags for every case.

IIRC there are a couple of variables available from Kitodo scripts – if the version is among them, that would be the cleanest solution. (We already have an ENV ACTIVEMQ_CLIENT – we could add a runtime variable ACTIVEMQ_PROTOCOL for example.)

Good point i will change this.

In the simplest case, just add another test "$ACTIVEMQ" != :

Changed the implemenation with your hints from review. Now you can configure the queue over env variable and if no variable is set the default queue is used.

bertsky approved these changes now

strange that GH sees it this way, although it knows that that review only applied to the last commit (view changes since...)


feat(layout): improvement layout

show LayoutAside only on screen lg
remove 'max-w-screen-2xl' and only use 'container'

Screenshot:

Thanks for the contribution! The logo cursor pointer issue is a great catch!
Although the other changes I'm not so sure. The style is meant to be consistent with the original shadcn-ui docs.

aside is indeed shown on md, and I do think it is a good idea as it better utilizes the horizontal space.

the header does have a max-w-screen-2xl on it.

the icons in aside should be aligned with each other rather than with the left boundary imo.

main
This PR


Icon buttons don't have labels

Icon buttons in the toolbar should have either tooltips or aria-labels describing the purpose of each action.
Using Tooltip introduced in V23.3 will help both regular users and screen reader users.
For earlier Vaadin versions adding aria-label will solve the screen reader accessibility issue.

Closed by #16


release: update manifest and helm charts for v1.2.1 (part 2)

--rm-dist is deprecated, using --clean instead.

This is a no-op change to trigger the release pipeline for v1.2.1


Luazip update

Motivation for this change
More automation \o/
Things done
tested with nix-review

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @7c6f434c

Well, I don't actually have any opinion on specific Lua packages… abstractly looks good

haha I just didn't want to push and merge my own commits without external review but I guess this is not critical enough that I can do it :)


Publish 11/12/2020 10:30 AM PT

Docs Build status updates of commit 37366fd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/mdop/Microsoft.Medv.Administration.Commands.WorkspacePackager/export-medvworkspace.md
:white_check_mark:Succeeded

docset/mdop/Microsoft.Medv.Administration.Commands.WorkspacePackager/new-medvworkspace.md
:white_check_mark:Succeeded

docset/mdop/agpm/add-controlledgpo.md
:white_check_mark:Succeeded

docset/mdop/agpm/get-controlledgpo.md
:white_check_mark:Succeeded

docset/mdop/agpm/lock-controlledgpo.md
:white_check_mark:Succeeded

docset/mdop/agpm/publish-controlledgpo.md
:white_check_mark:Succeeded

docset/mdop/agpm/remove-controlledgpo.md
:white_check_mark:Succeeded

docset/mdop/agpm/unlock-controlledgpo.md
:white_check_mark:Succeeded

docset/mdop/appv/convertfrom-appvlegacypackage.md
:white_check_mark:Succeeded

docset/mdop/appv/test-appvlegacypackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/add-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/add-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/add-appvpublishingserver.md
:white_check_mark:Succeeded

docset/mdop/appvclient/disable-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/enable-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientapplication.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientconfiguration.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientmode.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvpublishingserver.md
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvvirtualprocess.md
:white_check_mark:Succeeded

docset/mdop/appvclient/mount-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/mount-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/publish-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/remove-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/remove-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/remove-appvpublishingserver.md
:white_check_mark:Succeeded

docset/mdop/appvclient/repair-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/repair-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/send-appvclientreport.md
:white_check_mark:Succeeded

docset/mdop/appvclient/set-appvclientconfiguration.md
:white_check_mark:Succeeded

docset/mdop/appvclient/set-appvclientmode.md
:white_check_mark:Succeeded

docset/mdop/appvclient/set-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/set-appvpublishingserver.md
:white_check_mark:Succeeded

docset/mdop/appvclient/start-appvvirtualprocess.md
:white_check_mark:Succeeded

docset/mdop/appvclient/stop-appvclientconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvclient/stop-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvclient/sync-appvpublishingserver.md
:white_check_mark:Succeeded

docset/mdop/appvclient/unpublish-appvclientpackage.md
:white_check_mark:Succeeded

docset/mdop/appvsequencer/expand-appvsequencerpackage.md
:white_check_mark:Succeeded

docset/mdop/appvsequencer/new-appvpackageaccelerator.md
:white_check_mark:Succeeded

docset/mdop/appvsequencer/new-appvsequencerpackage.md
:white_check_mark:Succeeded

docset/mdop/appvsequencer/update-appvsequencerpackage.md
:white_check_mark:Succeeded

docset/mdop/appvserver/add-appvserverconnectiongrouppackage.md
:white_check_mark:Succeeded

docset/mdop/appvserver/get-appvserverconnectiongroup.md
:white_check_mark:Succeeded

docset/mdop/appvserver/get-appvserverpackage.md
:white_check_mark:Succeeded

docset/mdop/appvserver/get-appvserverpackagedeploymentconfiguration.md
:white_check_mark:Succeeded

docset/mdop/appvserver/get-appvserverpackageuserconfiguration.md
:white_check_mark:Succeeded

docset/mdop/appvserver/grant-appvserverconnectiongroup.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Feature request: add "panelBorder" theme option

Example: https://stackoverflow.com/questions/26191833/add-panel-border-to-ggplot2

Added: https://github.com/JetBrains/lets-plot/pull/546


suggest : execute open file

Can you add a tool menu? When I open the python file, I can choose to execute the file.

The menu is
File -> Launch -> Command...

OK


Editor - embed card doesn't always accept key input on create

Issue summary
When you add multiple embed cards every card past the first one no longer accepts keyboard input events despite the fact that the cursor appears within the codemirror editor.

Steps to reproduce

Add an embed card with the slash menu.
Close it and add a second embed card.
Try and add text.

Technical details
Ghost Version: https://github.com/TryGhost/Ghost-Admin/commit/b98a804ace7b37c6507ab73527ecaccd36df9860
Browser/OS: Chrome/MacOS

I think this is related to https://github.com/TryGhost/Ghost/issues/8385
Basically when a card is placed in edit mode the user clicks on Edit on the toolbar which fires the click event on the entire card, so although the card is in edit mode it's actually been clicked as well which puts it in hardSelect mode.
I've been contemplating removing the edit toolbar from the card wrapper and placing it absolutely. One of the issues is that there is a bug in mobiledoc which is hard to replicate is if you press delete at precisely the right moment mobiledoc will put the content of the toolbar into the document. I have no idea why it does it, it shouldn't.
Otherwise it's going to be a bit of a race condition between the edit mode toggling and the hard-select mode toggling.


path.existsSync is now called fs.existsSync.

I get this warning when starting my node app.
This should be changed. I'm not sure what the line number is.

I've submitted #22 to address this.  The path.exists and path.existsSync deprecated functions were recently removed, so the behavior has changed from a warning to a fail.  Though I'm not sure if anyone is still maintaining this repository.


Bulloak VSCode extension

Features:

Syntax highlighting for *.tree files better than what is offered by Tree (e.g. different colors for "when" and "given")
Parse the tree nodes and check that all start with "when", "given", or "it"
Continuously check that the implementation matches the spec (with a setting to turn this behavior on and off)
Run scaffold as a command (i.e. via CMD+SHIFT+P) with two options:

Run on one file alone
Run on entire code base

Right-clicking the contents of any *.tree file should contain an option to scaffold

I imagine that this is an idea for the long term and that it may be overkill at the moment.

I recently added basic support for scaffolding and .tree files to vscode-solidity-inspector extension. Let me know if you would like this feature to be available as a standalone extension. Any feedback is greatly appreciated! TIA :))
Preview:
https://github.com/PraneshASP/vscode-solidity-inspector/assets/42379522/2a3d591b-bc80-46cc-88c9-7e4faa0bb043

Ooooh! @PraneshASP, that looks great! I'll take a good look tomorrow, but I love what I see.
What were your thoughts when parsing errors? Was it too cumbersome? Would be happy to make them more composable/easier to parse.


[Bug] Hamburger menu not working in component category pages

Fix the hamburger menu not coming up in every component category pages.

HI @Rakesh9100 Please Assign this to me

Go ahead @pb0126

Please go ahead @pb0126


HDFS-16204.Improve FSDirEncryptionZoneOp related parameter comments.

Description of PR
Improve some unclear comments in FSDirEncryptionZoneOp. This is the purpose of this pr.
How was this patch tested?
This is an improvement related to the documentation and does not require excessive testing.
More details:HDFS-16204

Thanks @ayushtkn  for the comment.

@ferhui , can you help me check the code?
If there is something to be corrected, I will continue to work.
Thank you very much.

@jianghuazhu Thanks for contribution. @ayushtkn @virajjasani Thanks for review! Merged to trunk.


Duplicate TCP packets on host

Bug report

General Information

Cilium version (run cilium version):

cilium-cli: v0.8.6 compiled with go1.16.6 on darwin/amd64
cilium image (default): v1.10.3
cilium image (stable): v1.10.3

Kernel version (run uname -a): 4.18.0-305.10.2.el8_4.x86_64
Orchestration system version in use (e.g. kubectl version, ...): 1.22.1
Generate and upload a system zip:
cilium-sysdump-20210820-152443.zip

How to reproduce the issue
I have a problem with duplicate TCP SYN packets after masq. Cilium status looks like this:
KVStore:                Ok   Disabled
Kubernetes:             Ok   1.22 (v1.22.1) [linux/amd64]
Kubernetes APIs:        ["cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Namespace", "core/v1::Node", "core/v1::Pods", "core/v1::Service", "discovery/v1::EndpointSlice", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:   Strict   [bond0 <IP_ADDRESS> (Direct Routing)]
Cilium:                 Ok   1.10.3 (v1.10.3-4145278)
NodeMonitor:            Listening for events on 72 CPUs with 64x4096 of shared memory
Cilium health daemon:   Ok
IPAM:                   IPv4: 7/62 allocated from <IP_ADDRESS>/26,
BandwidthManager:       Disabled
Host Routing:           Legacy
Masquerading:           BPF   [bond0]   <IP_ADDRESS>/26 [IPv4: Enabled, IPv6: Disabled]
Controller Status:      40/40 healthy
Proxy Status:           OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000
Hubble:                 Ok   Current/Max Flows: 4095/4095 (100.00%), Flows/s: 6.43   Metrics: Ok
Encryption:             Disabled
Cluster health:         3/3 reachable   (2021-08-20T10:56:16Z)

I try to wget http://google.com from a busybox on that node which leads to a connection reset (cilium monitor):
-> stack flow 0x327043ff identity 9324->world state new ifindex 0 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:48302 -> <IP_ADDRESS>:80 tcp SYN
-> endpoint 101 flow 0x0 identity world->9324 state reply ifindex lxcc9722b79a843 orig-ip <IP_ADDRESS>: <IP_ADDRESS>:80 -> <IP_ADDRESS>:48302 tcp ACK, RST

From a small wireshark dump i created on the host i can see that the masq packet has been duplicated for whatever reason:

Your problem is not in the packet duplication which is related to how you take the trace (you probably trace with -i any or equivalent) and thus you see the same packet transiting on several internal Linux network interface. It is just that wireshark does not know that and flags the packet as a retransmission.
You can see in your capture that all packet are duplicated (DNS UDP too, even if as it is UDP wireshark does not flag them as such).

Summarizing the Slack discussion:
There is actually only one packet, but Wireshark sees it on three different interfaces. The TCP RST seem likely to be caused by a lack of masquerading. BPF masquerading is enabled on the bond0 device:
Masquerading:           BPF   [bond0]   <IP_ADDRESS>/26 [IPv4: Enabled, IPv6: Disabled]

But maybe there's an issue because of the bond device. Next step would be to check with the ens2f3 device, which is part of the bond. Tracing the connection at the destination would also help confirm that masquerading is the issue. Finally, testing with iptables-based masquerading could confirm this is an issue with the BPF-based masquerading.


getting time and gap

I would like to add two methods in the interface to call CPXgetmiprelgap and CPXgettime, but I guess I should first add them in MathProgBase. As far as I know, there are no equivalent methods currently in MathProgBase. Right?

get_rel_gap is the function calling CPXgetmiprelgap and it is already implemented. the MathProgBase corresponding function getobjgap. There is also the function getdettime for getting the time. So my issue wasn't really one.


protoc-gen-go/grpc: inline errUnimplemented function

Avoid using an errUnimplemented function, which requires us to
give a name to it, causing possible conflicts.
Instead, just inline it's functionality.
Fixes #817

For folks using this repo using go get, their go builds will fail as It would throw errors like imported "google.golang.org/grpc/codes but not used. Its because their .proto files services defination not uses error codes. To fix use the older release of this repo ie. 1.3.1 by compiling using source instead of go get.
In case of docker :
RUN mkdir -p ${GOPATH}/src/github.com/golang/protobuf && \     curl -sSL https://github.com/golang/protobuf/archive/v${PROTOC_GEN_GO_VER}.tar.gz | tar -xz --strip 1 -C ${GOPATH}/src/github.com/golang/protobuf &&\     cd ${GOPATH}/src/github.com/golang/protobuf && \     go build -ldflags '-w -s' -o /golang-protobuf-out/protoc-gen-go ./protoc-gen-go && \     install -Ds /golang-protobuf-out/protoc-gen-go ${OUTDIR}/usr/bin/
where PROTOC_GEN_GO_VER = 1.3.1


 Separating the drought narrations into two subsections like I did on mobile for next iteration will fix this problem and make the paragraphs easier to read overall.

See #38 for screenshots

Fixed as of #44


allowPartAttributes?

In the context of Web Components, part attributes are used to apply styles to the items under an open shadow DOM.
Having an option to allow part attributes for the Sanitizer Builder API would be helpful to make the sanitizer work with custom elements.
I thought the carried risk would be similar to allowClassAttributes, but I would love to hear your thoughts.

Could you share more context on your use case?
Where is the HTML coming from? Is it user controlled?
We are generally trying to better understand the use cases of our users, and we don't have a lot of feedback on custom elements.
I agree the risk should be similar to the class attributes.

My usecase is around a project called BudouX. It's a word segmenter library for Asian languages that don't have word delimiters like Latin languages. It has a custom element <budoux-ja> that inserts <wbr> tags to the given HTML snippet to provide proper line breaking opportunities. The conversion is done by parsing the given HTML and outputting the result to the shadow dom.
https://github.com/google/budoux/blob/main/javascript/src/webcomponents/budoux-base.ts
In order to keep the control over the converted output under the shadow dom, retaining part attributes would be preferred. The following example shows how part attributes will be used.
https://codepen.io/tushuhei/pen/WNgdzYw
The HTML can be come from a trusted source or user inputs depending on how the developer uses the BudouX Web Component in their website.

Sorry for the slow response, @neuracr is currently out of office, so I will attempt to help:
Have you considered directly building a DomFragment instead of returning strings from your parser ?
This would allow you to avoid unnecessary serialization/parsing/sanitization steps.
Something like this:
// in dom.ts
function parseFromString(html: string): Node {
  const template = document.createElement('template');
  template.innerHTML = html;
  return template.content;
}

// parser.ts
function translateHTMLString(html: string): Node {
  if (html === '') return new DocumentFragment();
  const fragment = parseFromString(html);
  if (Parser.hasChildTextNode(fragment)) {
    const wrapper = document.createElement('span');
    wrapper.append(...fragment.childNodes);
    fragment.appendChild(wrapper);
  }
  this.applyElement(fragment.firstChild as HTMLElement);
  return fragment;
}

// in budoux-base.ts
sync() {
  const translated = this.parser.translateHTMLString(this.innerHTML);
  this.shadow.textContent = '';
  this.shadow.appendChild(translated);
}

You can even avoid having to parse anything at all if you clone the existing nodes instead of grabbing this.innerHTML.
// in budoux-base.ts
sync() {
  let translated: HTMLElement;
  if (Parser.hasChildTextNode(this)) {
    translated = document.createElement('span');
    translated.append(...this.childNodes.map(node => node.cloneNode(true)));
  } else {
    translated = this.firstElementChild!.cloneNode(true) as HTMLElement;
  }

  this.parser.applyElement(translated);

  this.shadow.textContent = '';
  this.shadow.appendChild(translated);
}

This is also likely to be more performant than parsing and serializing the tree multiple times.

Sorry for my late reply.
Thanks for your suggestions! Let me follow up on this at https://github.com/google/budoux/issues/273
That being said, I believe this won't resolve the issue that the elements inside the shadow element are not stylizable from outside. Of course this is by design of a shadow element, but allowing part attributes will provide a workaround for users to control the style from outside for specific elements, as shown in my demo.

Thanks again for your insightful suggestions on using DomFragment. Since we've switched to Light DOMs and no longer need to worry about shadow DOM styling limitations, I'm closing this issue.


TOTK cheats clashing with gbatemp fps patches

I was having issues with the fps patches on gbatemp, the animations were still sped up when over 20fps, but these issues were fixed every time I removed the cheats. Is it possible to fix this? Or is it a specific cheat that I shouldn't enable? I'm not sure how exactly your cheats would interfere with animation speed, I don't have any speed cheats enabled.

Your new update fixed this, thanks!

Sorry, I was mistaken and closed the issue. This is still a problem

What patches from gba?

These ones here https://gbatemp.net/download/loz-tears-of-the-kingdom-fps-static-fps-and-visual-fixes-patch-collection.37996/history

I have absolutely no idea why, but this is fixed for me now. Thank you for your time.


Handle EAGAIN properly

Thanks. I believe you're running into #1486. It's a Kernel regression so I'd rather not a merge temporary fix. The patch is not needed because we should not see EAGAIN on blocking read. Failed to read /dev/tty error only occurs during blocking read.

https://github.com/junegunn/fzf/blob/0.17.5/src/tui/light.go#L155
https://github.com/junegunn/fzf/blob/0.17.5/src/tui/light.go#L291-L294

Oh sorry, I didn't even mean to make this pull request against this repo yet. I thought I made a pr from a branch in my fork to master in my fork. I wanted to include a pr description before making a pull request, and maybe clean this up a little.
You're correct that #1486 describes my issue. Thanks for the fast response.


embed the make process into the Dockerfile

I'm opening an issue as it is up for discussion - should we have the Make process part of the Dockerfile?
Here's an example of the Dockerfile I've modified (inc. other modifications):
FROM centos:8

LABEL project="centos8-gluster-build"
LABEL maintainer<EMAIL_ADDRESS>

RUN yum -y install --setopt tsflags=nodocs --enablerepo=powertools automake autoconf libtool flex bison \
    openssl-devel libxml2-devel libaio-devel \
    readline-devel glib2-devel userspace-rcu-devel \
    libacl-devel fuse-devel redhat-rpm-config rpcgen libtirpc-devel \
    make python3-devel rsync libuuid-devel rpm-build \
    git attr libcurl-devel selinux-policy-devel firewalld liburing-devel rpcgen && yum clean all

RUN yum -y update --setopt tsflags=nodocs && yum clean all && rm -rf /var/cache/yum

#RUN yum -y install --setopt tsflags=nodocsI epel-release

#RUN yum -y install --setopt tsflags=nodocs --enablerepo=powertools rpcgen

#RUN yum clean all && rm -rf /var/cache/yum

CMD ["/usr/sbin/init"]

RUN git clone --depth 1 https://github.com/gluster/glusterfs.git
WORKDIR glusterfs
RUN ./autogen.sh
RUN ./configure
WORKDIR extras/LinuxRPM
RUN make glusterrpms

Optimized Dockerfile and startscript as below. We need to pull the already built docker image from quay and run only the daily build to generate rpms, that way it looks optimised from my point of view.
===============================Dockerfile==============================
FROM centos:8
LABEL project="centos8-gluster-build"
LABEL maintainer<EMAIL_ADDRESS>RUN yum -y --setopt tsflags=nodocs --enablerepo=powertools install automake autoconf libtool flex bison
openssl-devel libxml2-devel libaio-devel
readline-devel lvm2-devel glib2-devel userspace-rcu-devel libcmocka-devel
libacl-devel fuse-devel redhat-rpm-config rpcgen libtirpc-devel
make python3-devel rsync libuuid-devel rpm-build perl-Test-Harness
git attr libcurl-devel selinux-policy-devel firewalld liburing-devel rpcgen -y
RUN dnf -y install epel-release --setopt tsflags=nodocs
RUN yum -y update --setopt tsflags=nodocs
RUN yum clean all
CMD ["/usr/sbin/init"]
COPY ./startscript.sh /
RUN chmod +x /startscript.sh
CMD /startscript.sh
=====================startscript===================
/usr/sbin/init
git clone --depth 1 https://github.com/gluster/glusterfs.git
cd glusterfs
./autogen.sh
./configure
cd extras/LinuxRPM
make glusterrpms

I think combining the update and the cleanup is useful to reduce layering:
 RUN yum -y update --setopt tsflags=nodocs && yum clean all

I don't think you need libcmocka-devel perl-Test-Harness

Noted, will update the changes into the file..


Luarocks Dependency: api-gateway-cachemanager

2016/11/07 14:36:16 [error] 508#508: *1435 lua entry thread aborted: runtime error: ...ocal/share/lua/5.1/api-gateway/aws/AWSIAMCredentials.lua:13: module 'api-gateway.cache.cache' not found:
	no field package.preload['api-gateway.cache.cache']
	no file './api-gateway/cache/cache.lua'
	no file '/usr/share/luajit-2.0.3/api-gateway/cache/cache.lua'
	no file '/usr/local/share/lua/5.1/api-gateway/cache/cache.lua'
	no file '/usr/local/share/lua/5.1/api-gateway/cache/cache/init.lua'
	no file '/usr/share/lua/5.1/api-gateway/cache/cache.lua'
	no file '/usr/share/lua/5.1/api-gateway/cache/cache/init.lua'
	no file '/var/www/watashineko/api/v1/api-gateway/cache/cache.lua'
	no file './api-gateway/cache/cache.so'
	no file '/usr/local/lib/lua/5.1/api-gateway/cache/cache.so'
	no file '/usr/lib/x86_64-linux-gnu/lua/5.1/api-gateway/cache/cache.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
	no file './api-gateway.so'
	no file '/usr/local/lib/lua/5.1/api-gateway.so'
	no file '/usr/lib/x86_64-linux-gnu/lua/5.1/api-gateway.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'

https://luarocks.org/modules/adobe-api-platform/lua-api-gateway-aws

@yoshida-mediba in case you didn't upload it yourself by now here it is: http://luarocks.org/modules/adobe-api-platform/lua-api-gateway-cachemanager

is this probably a duplicate of https://github.com/adobe-apiplatform/api-gateway-aws/issues/20 ?

closing it as duplicate since @mrgonza78 has validated it works.


Add flutter generative RTL design

Description & Motivation
Added generative web UI for generation of the RTL code.

BLoC design pattern (cubit)
Material UI widget

The sample application can be view at here:
https://quekyj.github.io/rohd-hcl/#/ - flutter app
https://quekyj.github.io/rohd-hcl/api/ - api docs
This repository will need to use website as the branch to serve the github page.
Related Issue(s)
Nope.
Testing

Added unit test for each of the components.
Added widget test to simulate clicking and assert for correct results.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.
Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No.

What's this?

What's this?

I am not sure why this shows up after build. It doesn't show this when I run flutter run -d chrome. I suspect it is a flutter bug.

What's this?

I am not sure why this shows up after build. It doesn't show this when I run flutter run -d chrome. I suspect it is a flutter bug.

Fixed this.

Close this pull request. The development of the flutter UI will be move to https://github.com/mkorbel1/rohd-hcl/tree/flutter_refactor instead.


[settings] Acrylic opacity option could/should include percent sign.

Description of the new feature/enhancement
Currently, when selecting the opacity of the acrylic option of a profile, the values range from 0 to 100. However in reality (and in the API of the AcrylicBrush) the values range from 0 to 1 (0 to 100%).
Proposed technical implementation details (optional)
I think we can just include a % sign at the end of the label.
Open questions
Does this need to be localized? Is a % sign optimal here or are there better alternatives?

If it's fine I would like to try work on this issue.

That seems fine to me, good idea!


Recommended way to install Python requirements

Hello, is there a recommended way to install the Python package requirements for this repo? I've tried a lot of combinations with conda but haven't been able to get all of the packages to install without incompatibilities. Specifically, is there a particular PyTorch/CUDA version that works well for this repo? Thanks!

Sorry I didn't provide any requirement file for installation.
I don't remember the exact version I used for pytorch. My guess is that 1.7 or 1.8 could work given the timeline I worked on the project.


A plan for making esmvaltool more stable and user/developer friendly

Below I describe an idea for making ESMValTool more friendly to use for developers and users, based on the discussion in  #769 and elsewhere. Please comment if you have any ideas about this @ESMValGroup/esmvaltool-coreteam
Split core from diagnostic code
As discussed in #769, it would be desirable to split the core esmvaltool code (i.e. the esmvaltool command, recipe parsing code, preprocessor, etc) from the diagnostics/recipes, so we would get two public GitHub repositories. Private GitHub repositories would then be forks of the public diagnostic/recipes repository.
This would have several advantages:

diagnostic developers can develop their diagnostics against a stable version of esmvaltool installed simply with pip, instead of against the development version that keeps changing
it will no longer be possible to mix changes to the core of esmvaltool with diagnostic development, making it easier to maintain good quality standards and keep pull requests manageable
much less synchronization needed between public and private repository
it will no longer be necessary to install a hefty list of requirements if you just want to use the esmvaltool core, e.g. in a Jupyter notebook (see #1030), or esmvaltool core + diagnostics in a single language.

Packaging and publishing
The esmvaltool core, in it's own public GitHub repository, could be a pure Python package that can be installed from PyPI.
Out of the diagnostics + recipes GitHub repository, we would probably make several different packages:

one for recipes on PyPI
one for Python diagnostics on PyPI
one for NCL diagnostics on PyPI
one for R diagnostics on CRAN
one for Julia diagnostics in the Julia package repository
for diagnostic development in progress it will remain possible to work with (private) diagnostic + recipe GitHub repositories.

and finally we would probably like a single esmvaltool package on PyPI (and Conda) that installs all the others as dependencies, so we can have a single command installation.

cheers for the plan, General Bouwe @bouweandela :medal_military:
I completely agree with all, but we need to make sure that the diagnostic packages are maintained at the same level as the independent core (continuous integration, good testing etc) which is gonna be hard since we need to designate people for that, and we're not too many at the moment. How do you see we get around that?

I'm not sure if that is quite on topic here, but just to answer your question: the easiest way to do continuous integration/test diagnostics is probably to get a big machine with all the data on it and run the diagnostic and compare the output to a previous run whenever something changes in the code. Everything automated as much as possible. i think that we cannot expect every scientist that contributes a diagnostic to write unit tests, so just running the diagnostic will probably as good as it gets regarding testing.

I'm not sure if that is quite on topic here, but just to answer your question: the easiest way to do continuous integration/test diagnostics is probably to get a big machine with all the data on it and run the diagnostic and compare the output to a previous run whenever something changes in the code. Everything automated as much as possible. i think that we cannot expect every scientist that contributes a diagnostic to write unit tests, so just running the diagnostic will probably as good as it gets regarding testing.

In theory all sounds good, man, the true logistics will be much harder for the real situations that we'll face, hence my concern about the number of man hours per qualified dev person that will have to maintain each of the separate language packages. In any case, let's not dabble on it just yet, I am very happy with the plan you put forward irrespective of what sort of manpower issues we may face. That's why we need to get a strong structure of the team in the future too (part of the gov issue) :beer:

As a first step in implementing this, we will need to rename/move some directories and come up with names for them. We need names for the various packages listed above (suggestions welcome!) and will need to move any directories that are not part of the esmvaltool core framework out of the esmvaltool directory into the root of the repository (and give them more meaningful names).
Idea for renaming:
Core repository:
esmvaltool -> esmval? esmvalcore? something else?
Diagnostics repository:
esmvaltool/diag_scripts -> esmvaltool-diagnostics
esmvaltool/utils/cmorizers -> esmvaltool-cmorizers
esmvaltool/utils -> esmvaltool-utils

Core repository:
esmvaltool -> esmval? esmvalcore? something else?

What about esmvaltool-core, consistent with the other names you suggested?
One question: shouldn't cmorizers and utils be part of the core?

What about esmvaltool-core, consistent with the other names you suggested?

That would be a rather long name for a Python package, e.g. to use a preprocessor function, you would need the python code
from esmvaltool_core.preprocessor import regrid

One question: shouldn't cmorizers and utils be part of the core?

I think most of the utils are mostly tools for diagnostic development and not really part of the esmvaltool Python package as it is defined at the moment.
Regarding the cmorizers, wasn't the plan to start using cistools in the future? Why are we writing our own cmorization package? Is that just because cistools doesn't support NCL?

Regarding the cmorizers, wasn't the plan to start using cistools in the future? Why are we writing our own cmorization package? Is that just because cistools doesn't support NCL?

Not only, also because not all datasets we use are included in CIS.

Yes, but wouldn't it be better contribute a plugin for those datasets? That will make the cmorization script available to a much wider community and also we avoid doing duplicate work by not having to implement and maintain our own cmorization framework.

I like esmval for the core!
I also like esmval-toolkit that can include cmorizers and utils
I also like esmval-diagnostics
I also like beer :beer:

Yes, but wouldn't it be better contribute a plugin for those datasets? That will make the cmorization script available to a much wider community and also we avoid doing duplicate work by not having to implement and maintain our own cmorization framework.

maybe. But bear in mind that the cmorizers are as the diagnostics -> community developed and I bet you my boots only 10% of scientists are familiar with CIS and know how to work and develop with it

Just another thought in case we decide to split the ESMValTool into two repositories (core and diags): what happens to the documentation? So far, I always saw the documentation as a "user's and developer's guide". Such a manual naturally contains documentation of both, the core functionality and the diagnostics. In some cases, things are mixed up as they do not clearly belong to one or the other part such as, for example, documentation of shared code that does not belong to a single diagnostic or a description of the coding rules and standards that largely apply to both parts. So not sure what to do about the documentation. Any thoughts?

I think we'll need to split the documentation too, This shouldn't be too big a problem, because we can always link from one readthedocs page to another, so there will be no need to duplicate things. A good starting point can be that esmvaltool diagnostics build on top of esmvaltool core, so we would mostly refer from the diagnostic documentation to the core documentation, where needed.

documentation of shared code that does not belong to a single diagnostic

This would be part of the diagnostics repository, as it's shared between diagnostics, not used by the core

a description of the coding rules and standards that largely apply to both parts

I think we can just create a link to the relevant sections in the core documentation from the diagnostic documentation, and add some extra text to describe the differences (e.g. unit tests are not required for diagnostics).

I bet you my boots only 10% of scientists are familiar with CIS and know how to work and develop with it

Yes, but at least we wouldn't be forcing them to learn two systems, ESMValTool cmorizers and CIS, just knowing CIS would be enough

Splitting the ESMValCore from the ESMValTool is done now.

a virtual :beer: to @bouweandela


[23.11] nixos/amdvlk: init module

Description of changes
Manual backport of #318175 sans release note changes
conflicts with and closes https://github.com/NixOS/nixpkgs/pull/319555

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

23.11 is so late in its release cycle. Do we really want to add a new feature to it?

23.11 is so late in its release cycle. Do we really want to add a new feature to it?

I really not into it either, hence why i propose https://github.com/NixOS/nixpkgs/pull/319555

I'm also on board with closing this and merging the 24.05 backport, which in effect means nixos-hardware softly drops support for 23.11 two weeks early.

Closing this due to lack of interest


Added the missing minX function.

I'm assuming the documentation will need to be built again as well.

@beaudesigns -- Thanks for letting me know.   Normally I would just accept the pull request; but I was ofline while I was fixing some other fluentReports issues.  Since it was a simple function, I just added the missing minX function manually with the last release so it could all be pushed up to NPM at the same time.


How to reproduce 4-bit QAT (Section 5.4) results reported in the MQBench paper?

Can you provide some instructions on reproducing the results in Section 5.4?

Can you please point me to the config files for results reported in the paper? It seems there is no directory named application/lsq_config.

@kartikgupta-at-anu See #23


Feature caching with docker-compose

I have a project with a docker-compose based devcontainer setup.
I have a dockerfile for my devcontainer image as well as a number of features defined in the devcontainer.json.
I can't figure out how to get the caching to work for our github actions.  It seems that everytime I use this devcontainer within github actions it spends ~5 minutes rebuilding the container and all of it's features.
Is there an example of caching setup properly with a docker-compose setup?

Hi 👋
Have you looked at https://github.com/devcontainers/ci? Let us know if that helps, else happy to chat about other possible solutions. Thanks!

ah thanks @samruddhikhandale I think I put this issue into the wrong repo.  I'll close this one and open one in that repo, thanks.


refactor(ci): Get npm feed URLs from centralized variable group

Description
Update pipelines to get the URLs for the different npm feed from the centralized variable group we created a while ago.
More detailed test results in the comments in AB#3266.

Failed checks are optional, from manual runs I did of pipelines to test this change, and unrelated to it.

I'm assuming you did test runs for the affected pipelines?

Yep, ran all of them since most were going to ask for permissions to use the variable group. The ADO item mentioned in the description has details (not too interesting, tbh, but for the record).


I get an error when using this crate

Here are my deps:
[dependencies]
...
fltk-grid = "^0.1"

[dependencies.fltk]
version = "^1.3"
features = [ "no-pango",]
git = "https://github.com/fltk-rs/fltk-rs"

And here's the error (on Linux; but same on Windows):
    Updating crates.io index
error: failed to select a version for `fltk-sys`.
    ... required by package `fltk v1.3.0`
    ... which satisfies dependency `fltk = "^1.3"` of package `fltk-grid v0.1.0`
    ... which satisfies dependency `fltk-grid = "^0.1"` of package `diffpdf v7.0.0-a1 (/home/mark/commercial/comparepdfcmd2/diffpdf)`
versions that meet the requirements `=1.3.0` are: 1.3.0

the package `fltk-sys` links to the native library `fltk`, but it conflicts with a previous package which links to `fltk` as well:
package `fltk-sys v1.3.28 (https://github.com/fltk-rs/fltk-rs#350b5a67)`
    ... which satisfies git dependency `fltk-sys` (locked to 1.3.28) of package `fltk v1.3.28 (https://github.com/fltk-rs/fltk-rs#350b5a67)`
    ... which satisfies git dependency `fltk` (locked to 1.3.28) of package `diffpdf v7.0.0-a1 (/home/mark/commercial/comparepdfcmd2/diffpdf)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='fltk-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

failed to select a version for `fltk-sys` which could resolve this conflict

I get the same with the same deps. I think both (fltk and fltk-grid) need to be pulled from crates.io registry for Cargo's dependency resolution to succeed. I'll publish a new version of fltk-rs tomorrow hopefully. Just need to pull some fixes from FLTK first.

I tried adding the patch thing but it didn't work.
I'd be happy to use the built-in table type if I could figure out how to have widgets span columns.

use fltk::{prelude::*, *};

fn main() {
    let a = app::App::default();
    let mut win = window::Window::default().with_size(500, 400);
    let mut table = table::Table::default()
        .with_size(400, 130)
        .center_of_parent();
    table.begin();
    table.set_frame(enums::FrameType::NoBox);
    table.set_scrollbar_size(-1);
    table.set_rows(5);
    table.set_cols(5);
    if let Some((x, y, w, h)) = table.find_cell(table::TableContext::Cell, 0, 0) {
        button::Button::new(x, y, w, h * 5 /* number of cells we want to span vertically */, None).with_label("Submit");
    }
    if let Some((x, y, w, h)) = table.find_cell(table::TableContext::Cell, 2, 2) {
        input::Input::new(x, y, w * 3 /* number of cells we want to span horizontally */, h, None);
    }
    table.end();
    win.end();
    win.show();
    a.run().unwrap();
}

Thank you!


CR/LF in Windows 10 causing long read/load times

Notice that the .xml guide files are generated with very long lines, sometimes in excess of 1,5000.000 characters. This causes slow read/parsing times in Kodi with PVR Simple Client.
Perhaps could end with a hard CR/LF at for each ... block.
Would be happy to provide a consolidated .xml file if an example is needed, but be wary, this is large ~120MB in size.

sometimes in excess of 1,5000.000 characters

Which guide are we talking about here?

sometimes in excess of 1,5000.000 characters

Which guide are we talking about here?

Trying to isolate it. It could also be due to a Kodi add-on, IPTV Merge as well. For now, i'll close this issue until i can get much better information on what's causing this.


Run client and server in same app with unified timeline

Objective
In the current "listen-server" mode, we create 2 Apps (client_app, server_app) that communicate via channels.
This is already pretty good but there are a couple of issues:

there is a slight input delay even if the latency should be 0 because the inputs from the client will get received by the server on a later tick. Also the client timeline might still be a little different than the server timeline
there could be an overhead from running 2 Apps, 2 Worlds with similar archetypes, etc.

Instead we could have a model where the ClientPlugin and ServerPlugin are both running inside the same App.
Ideally, there would be as little code change as possible between this mode and the other ways of running lightyear. (dedicated server)
Which means that in a first phase, we will keep the Interpolated/Predicted/Confirmed components even though they aren't actually needed:

there is no need for prediction, the client could just move directly the server-authoritative entity. (but maybe the client could predict other players? see RocketLeague)
there is no need for interpolation. Interpolation exists because the server updates are sporadic. In this case the client and server are in the same app so the client has access to the server state every frame!

Design
I guess there's 2 main options:
A) This is what we'll do in this PR. We create both plugins in the same app connected via local channels. The main changes compared to 2 apps are:

there is only one TimeManager that is shared between the client and the server . This means that the client operates on the SAME timeline as the server, instead of being ahead (for client-prediction)
We cannot update the TimeManager's time in the SyncManager because the timeManager's time is the client's prediction time but also the server's time! Also we don't need to do it since the goal of SyncManager is to keep the two timelines in sync, and in this case there are perfectly in sync. We also need to adjust the interpolation time code.
Change the ClientGlobalMetadata code to only use the client_id received from the server (i.e. without Replicate component)
For inputs to work with 0 latency, we will send inputs directly via channels to the server's InputEvents receiver (otherwise there would be a one-frame delay because the inputs would be received on the next frame. Also having inputs not being received instantly on the server is incompatible with the unified timeline, since if that's the case the client would have to run slightly ahead of the server.
So basically I have to either:
separate the TimeManager into a ClientTimeManager and a ServerTimeManager
or force inputs to have 0 latencies in this unified mode, and use the same timeline.
I think the second option is easier to implement and has other benefits (true 0-delay input latency if running in singleplayer) so let's try this first. (we can keep the second option as fallback).

This has another consequence: even if there is a link conditioner adding delay, the local client will always have 0 input latency from client -> server.
B)

do not use io at all between the server/client, and instead have the client reuse directly the server entities
if a client has ShouldBePredicted, instead of spawning a new Predicted entity we just add a Predicted component
if a client has ShouldBeInterpolated, instead of spawning a new Interpolated entity, we just add an Interpolated component to the server entity
either the client doesn't connect to the App (no io needed since they are sharing the same world). This might need a couple of adjustments in the example code.
The problem is that there are some places in the code that expect a client-id, and maybe also a connection?
Can investigate this; maybe we need to create a fixed ClientId for the 'Unified' usecase.
This might be a good long term solution, but might be hard to get working in the short-term (need to let the app run with no io, no netcode, etc.)
I guess in this mode almost nothing related to the ClientPlugin is needed? no need for io, prediction, interpolation, etc. Maybe we could just run with the ServerPlugin? In which case the changes needed are:
server creates the entity directly (not when a client connects! Maybe we can emit a connection event for a "local" client)
inputs need to affect that entity

Changes

Make TimeManager be a shared resource created in SharedPlugin
Add unified field in SharedConfig
Update Sync to work with a unified timeline
make sure TimeManager::update() is called only once, even in unified mode
Split out the input_buffer in a separate InputManager, and handle unified mode separately (send inputs via a channel)
add a ReplicationConfig to specify in which direction the replication will be (a better long-term solution will be to add a ReplicationDirection component)
Update client GlobalMetadata to work correctly in unified mode.

Blockers

[ ] Update all examples

[x] Simple box
[x] Replication groups
[x] priority
[ ] leafwing inputs: BUG
[ ] interest management: interpolation timeline is wonky on the unified server
[x] client replication
[ ] bullet prespawn: problem with prespawn, and also with controls

[x] Refactor TimeManager so that it can be shared between ClientPlugin and ServerPlugin
[x] Register SharedPlugin only once if both ClientPlugin and SharedPlugin are called
[x] For inputs, do NOT network the client inputs to the server if we are in the same app, instead just directly write to ServerEventInputs so that the inputs are read on the same tick by the server

[X] check if it works for leafwing

[X] Update the SyncManager to work correctly
TODO: maybe in unified mode, we add a component ReplicatedFromServer/ReplicatedFromClient to identify entities?

BUGS:

[ ]: when another client connects, the interpolated entity in the unified app has no components
[ ]: the interpolation delay on other clients seems very long!

I'll just merge this for now as there are too many changes in this PR to be manageable, but I think that running the ClientPlugin and the ServerPlugin in the same world for now is not manageable:

a Replicate entity is replicated both from client->server and server->client so we have to add extra components ReplicateToClientOnly and ReplicateToServerOnly
the replication system-sets have to be separated between client and server
-all queries have to be adjusted to keep in mind that client entities and server entities are living in the same world
the examples have shown that it's very hard to be able to have client and server in the same world without significant mental loaded added

This discord thread: https://discord.com/channels/691052431525675048/747940465936040017/1223411454334734436 by @msvbg outlines 3 potential approaches for client and server on the same machine:

A) 2 separate apps (unity way, also what the current 'listen-server' mode does with local channels as io
B) 1 world with both Client and Server Plugin (what this PR does, but which proves to be too much of a footgun)
C) 1 world with only the Server Plugin, but the server also acts as a player

I'll merge this now and focus my effort and getting C) working. B) would work only when bevy supports multiple worlds in the same app


Update SearchSuggestionOption Score field

See https://www.elastic.co/guide/en/elasticsearch/reference/6.2/search-suggesters-completion.html
According to the link above the Score field in the SearchSuggestionOption references a missing tag, which should be _score rather than score.
{
  "_shards" : {
    "total" : 5,
    "successful" : 5,
    "skipped" : 0,
    "failed" : 0
  },
  "hits": ...
  "took": 2,
  "timed_out": false,
  "suggest": {
    "song-suggest" : [ {
      "text" : "nir",
      "offset" : 0,
      "length" : 3,
      "options" : [ {
        "text" : "Nirvana",
        "_index": "music",
        "_type": "song",
        "_id": "1",
        "_score": 1.0,
        "_source": {
          "suggest": ["Nevermind", "Nirvana"]
        }
      } ]
    } ]
  }
}

I came across this exact same issue #764. Sorry, should have checked the closed issues. Figured this would be a hole-in-one.
Quick repro, using the ES docs.
docker run -p 9200:9200 docker.elastic.co/elasticsearch/elasticsearch-oss:6.2.4

curl -X PUT "localhost:9200/music" -H 'Content-Type: application/json' -d'
{
    "mappings": {
        "_doc" : {
            "properties" : {
                "suggest" : {
                    "type" : "completion"
                },
                "title" : {
                    "type": "keyword"
                }
            }
        }
    }
}
'

curl -X PUT "localhost:9200/music/_doc/1?refresh" -H 'Content-Type: application/json' -d'
{
    "suggest" : {
        "input": [ "Nevermind", "Nirvana" ],
        "weight" : 34
    }
}
'

Querying:
curl -X POST "localhost:9200/music/_search?pretty" -H 'Content-Type: application/json' -d'
{
    "suggest": {
        "song-suggest" : {
            "prefix" : "nir",
            "completion" : {
                "field" : "suggest"
            }
        }
    }
}
'

Returns:
{
  "took" : 3,
  "timed_out" : false,
  "_shards" : {
    "total" : 5,
    "successful" : 5,
    "skipped" : 0,
    "failed" : 0
  },
  "hits" : {
    "total" : 0,
    "max_score" : 0.0,
    "hits" : [ ]
  },
  "suggest" : {
    "song-suggest" : [
      {
        "text" : "nir",
        "offset" : 0,
        "length" : 3,
        "options" : [
          {
            "text" : "Nirvana",
            "_index" : "music",
            "_type" : "_doc",
            "_id" : "1",
            "_score" : 34.0,
            "_source" : {
              "suggest" : {
                "input" : [
                  "Nevermind",
                  "Nirvana"
                ],
                "weight" : 34
              }
            }
          }
        ]
      }
    ]
  }
}

Thanks @jjhbw. I can reproduce this.
Now I only have to figure out why the unit test works fine with score instead of _score. Let me see.

Okay. So PhraseCompletion returns score, not _score. Oh my...

So the situation around suggesters and score looks like this:

Term suggester returns its score as score
Phrase suggester returns score as score
Completion suggester returns score as _score
Context suggester returns score as _score

In fact, I have to review the whole situation around "options" passed back from suggesters (maybe by using typed keys and then doing the right thing at deserialization time). It seems that completion suggester basically returns a SearchHit (plus some additional fields), not an option like the other suggesters. Hence _score, not score.
As a workaround, I could add a 2nd field to SearchSuggester that allows to grab both score and _score. While ugly, it is a quick fix around the situation of not being able to retrieve the _score at all.

I will post a hotfix in 6.1.16 in a minute. For now, read the score for your suggester from one of these fields in SearchSuggestionOption:
	Score           float64          `json:"score"`  // term and phrase suggesters uses "score" as of 6.2.4
	ScoreUnderscore float64          `json:"_score"` // completion and context suggesters uses "_score" as of 6.2.4

I created issue #765 as a reminder to clean up this mess and come up with a proper solution.

Thanks @olivere and @jjhbw! I meant to follow up with this. I appreciate the hard work you put into this library.

I see, nice finds! Confusing choices on the part of ES... Thanks for your quick replies!


Program fails when dependency is not installed. Null value is sent through port

Program fails when dependency is not installed. Null value is sent through port

This implies that these dependencies are not taken into account when post processing the files (to fix operator precedence, e.d.).


feat: Allow unsetting devtool flag (#85)

Setting 'mode' and 'devtool' in webpack.config.js to allow user provided webpack configuration to override those values.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


DAPP details title unreadable (black on black) for Abandoned projects

Example: https://dapps.ethercasts.com/dapp/etherpoker
while we'll create a new UI/UX, please create a hotfix for this in the meantime.

Fixed :)


Uncaught TypeError: Cannot read property 'length' of undefined

Hi,
I can'use ide-purescript :(
I get error messages as soon as I import a project.

Generate a new project with pulp init
Open it
That's it.

I'm on windows 10 64 bit.
Atom Version: 1.8.0
System: Unknown Windows Version
Thrown From: ide-purescript package, v0.14.2
Stack Trace
Uncaught TypeError: Cannot read property 'length' of undefined
At C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:1604

TypeError: Cannot read property 'length' of undefined
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:1604:53
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:1666:71
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:10510:113
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:2621:23
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:2577:7
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:2621:27
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:2655:11
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:2566:13
    at C:\Users\Utente\.atom\packages\ide-purescript\lib\main.js:10329:25
    at F (C:\Users\Utente\.atom\packages\ide-purescript\node_modules\which\which.js:69:16)
    at E (C:\Users\Utente\.atom\packages\ide-purescript\node_modules\which\which.js:81:29)
    at C:\Users\Utente\.atom\packages\ide-purescript\node_modules\which\which.js:90:16
    at C:\Users\Utente\.atom\packages\ide-purescript\node_modules\which\node_modules\isexe\index.js:44:5
    at C:\Users\Utente\.atom\packages\ide-purescript\node_modules\which\node_modules\isexe\windows.js:29:5
    at FSReqWrap.oncomplete (fs.js:82:15)

Commands
     -6:55.8.0 tree-view:remove-project-folder (span.name.icon.icon-file-directory)
     -5:55.7.0 application:add-project-folder (ol.tree-view.full-menu.list-tree.has-collapsable-children.focusable-panel)

Config
{
  "core": {},
  "ide-purescript": {
    "fastRebuild": true
  }
}

Installed Packages
# User
ide-purescript, v0.14.2
language-haskell, v1.7.18
language-purescript, v0.7.0
linter, v1.11.14
terminal-plus, v0.14.5

# Dev
No dev packages

Guessing you haven't had this working with an earlier version. 2 things, clearly there is a bug in the package but I think you're hitting a case where you don't have psc-ide-server in your path. If you installed from npm, this means that your npm bin dir where psc-ide-server.cmd resides should be in PATH.

I was able to reproduce and I have a fix for the incorrect error Uncaught TypeError: Cannot read property 'length' of undefined. However I think you will also have seen the other error around your PATH as above which you will need to fix in your environment.

psc-ide-server.cmd is in my path. I think that the issue is that it's defined as Path and not PATH

Yes, I think that's an Atom issue that it must be PATH. Looks like that will be solved in 1.9.0 https://github.com/atom/atom/issues/11302
If you can't set the expected PATH variable you can also configure an explicit path for all commands in the package settings.

Manually setting the path for psc-ide-server made this error disappear too

Fixed by https://github.com/kRITZCREEK/purescript-psc-ide/commit/ce8ba5f38841752f690973a522f128dcce5ab121 - I need to update bower.json and make a release.

Closing as the bad error is now fixed, and the PATH/Path issue is related to the linked atom issue.


Terraform destroy doesn't work

Describe the bug
When we destroy the module, the requested spot instances are not canceled, and the terraform process timeouts on the following step:
We are using the currently latest stable, 7.2.2 version of this module.
The issue is due to the fact, that the module.terminate_agent_hook is deleted before the aws_autoscaling_group.gitlab_runner_instance module, so the lambda function is not triggered in time.
It creates a loop that can be solved only with a manual interaction (terminate the spot instances) when we try to destroy the module.
To Reproduce
Steps to reproduce the behavior:

Create your gitlab-runner from the 7.2.2 version
Wait until it is initiated
Run terraform destroy
4 You will see the timeout issue in this step since the spot runners are not terminated/canceled by the module itself:

module.spot_runner.aws_security_group.docker_machine[0]: Still destroying... [id=sg-04d8bdc6b45747c0c, 2m20s elapsed]
module.spot_runner.aws_security_group.docker_machine[0]: Still destroying... [id=sg-04d8bdc6b45747c0c, 2m30s elapsed]

Expected behavior
We can destroy the module without any issues or manual interaction.
Additional context
Our runner setup:

runner_worker_docker_machine_fleet  is enabled
runner_worker_docker_machine_instance_spot is enabled
runner_worker is docker+machine

As far as I remember the problem was to detect the destroy operation and then run a script to stop the spot instances. There are also some other operations which might lead to manual interactions, e.g. changes to the security group which causes a recreate, ...
From my point of view the terraform destroy is not the main problem as you won't do that on regular bases. But updating the module and changing resources which are still in use is the main problem here. Not sure how to tackle it.
We have already a Lambda function in place killing the Runners in case the Agent goes down. At the moment this Lambda function is destroyed before the Agents shuts down. So maybe we can create a depends_on making sure that the Runners are destroyed as well. This would solve the destroy problem while updating the module might still causes errors.
What do you think?

Unfortunately, the depends_on solution can't work here, because the lambda function has several parameters from the created autoscaling groups.
It would create a loop and break the terraform code (I've tested it on my forked code).
Basically, that's why I created this issue, because to solve the destroy situation, it will require either a brand new lambda function with different logic or the existing one needs to be refactored deeply.


Trait-based color conversions to/from Vec4 are too implicit and should be removed

          No problem! I felt like `Vec4::from(color).truncate()` is a bit boilerplate-y, so I opened this PR.

Originally posted by @st0rmbtw in https://github.com/bevyengine/bevy/issues/10318#issuecomment-1784969213
Instead of the existing approach (and the one proposed in the linked PR), I think we should have explicit impl methods such as Color::rgba_from_vec4(vec: Vec4).
It is very easy to screw up your color spaces currently, and forcing conversion methods to declare the color space used will improve matters.

We would need also:
Color::rgb_from_vec3(vec: Vec3)
Color::rgba_from_vec4(vec: Vec4)
Color::rgb_linear_from_vec3(vec: Vec3)
Color::rgba_linear_from_vec4(vec: Vec4)
Color::hsl_from_vec3(vec: Vec3)
Color::hsla_from_vec4(vec: Vec4)
Color::lch_from_vec3(vec: Vec3)
Color::lcha_from_vec4(vec: Vec4)

in order to match the current Color API.
And maybe also *_to_vecX()?


@craigspaeth => Initial Venice Biennale Layout

cc @eessex, @owendodd
This lays out things like assets, files, tests, etc and some things like nav and the cover.

Also removed those demos. We're going with Google VR View for the player (a custom one) and we're experimenting with mp4 and HLS for file types.

LGTM! Very excited to see this project kick off 👏 . None of my comments are blockers. Great start!


Recursively reload dependencies and packages.

#20 implemented reloading of dependencies and dependent packages. However, dependencies can also depend on other dependencies. Dependencies can declare their own dependencies with a dependencies.json file, just like packages. Admittedly, not many do, because Package Control doesn't do anything with that information (though there is a PR). But when a dependency does have a dependencies.json file, it makes sense to reload it when its dependencies are reloaded. (Not doing so could leave that dependency in a broken state.)
This PR implements that. When a dependency is reloaded, all of its dependents are reloaded, including other dependencies, and this is fully recursive.

Thanks. To be honest, I don't have a good start point of testing this. It looks great though, so I am going to merge it.


make: Nothing to be done for 'folder'

I try to use the comman that "make ./gmc D:/code/tracking/code/SportsMOT-main/sportsmot_publish/dataset/basketball/train/*"
but get nothing to be done for ....
I wonder if there were something wrong, the dataset is part of the SportsMOT and it contain the img1 folder and gt folder and seqinfo.ini in a folder...
the result is below...

hopping your reply and give me some advise, thank you very much!!!

You need build gmc first, Each line below is a separate instruction

cd gmc
mkdir build
cd build
cmake ..
make
./gmc ${SPORTSTRACK_ROOT}/data/sportsmot_publish/dataset/test/*   #this will generate a gmc.txt file in each input directorys
./gmc ${SPORTSTRACK_ROOT}/data/sportsmot_publish/dataset/val/*

All instructions have only been tested on ubuntu 18.04.


POSSIBLE HOTFIX: Index resources with no logical files as "Generic Data" in discovery.

Currently Composite Resources with no logical files are associated with no content types at all in discovery. If you search by content type they do not appear at all. This fix makes them all appear as "Generic Data". More than 2000 resources containing .csv files are affected.
@sblack-usu @cuahsimarko @martinseul @dtarb This has a profound effect upon discovery and I propose as a hotfix.

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]
Create a resource only containing a .csv file. It should appear in discovery results for content type "Generic Data".

Obviously I need to post against develop in order for the patch to be reviewed. Repointing at develop.


Fix various CS IT and core UT errors

Contents:

CS errors: integration-test
UT errors: core

@gregito Yes, those are required for and used solely by StackV4RequestToStackConverterTest. As the latter was moved to the correct package (where the test target StackV4RequestToStackConverter is located), the JSONs had to be moved as well. (These files are read by getRequest() of the parent class, and file paths are assumed to match the package of the invoking class.) Without moving them, all unit tests failed as the JSONs could not be found & read.


Route user when connecting from the landing page to the app page

Look into potentially using subdomain "app" this may require us to upgrade to a pro subscription to vercel

@TristHund  will close this ticket  since we agreed the landing page won't be there anymore

Okay is it open to account for any of the routing work? I am moving it at least to in progress

Took out of project but leaving open to come back to after the hackathon


Sort products by last edited on top both for Products and In Progress tabs

Completed as part of the ticket #2288