400 Bad Request error when loading in a BibTex file

Hi! I'm not sure what exactly I am doing wrong, but it seems like it isn't porting in the link for my Notion database URL. Any help would be appreciated! It also seems like the truncation issue that was talked about in a previous post is popping up here as well. Maybe it will still work if I fix the first issue, but just thought I should ask.
1/23: Publication(key="10.1039/c5ra11101c", title="{A review on natural surfactants}")
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_client/client.py", line 118, in _parse_response
    response.raise_for_status()
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/httpx/_models.py", line 749, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: Client error '400 Bad Request' for url 'https://api.notion.com/v1/pages'
For more information check: https://httpstatuses.com/400

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.10/bin/ns", line 33, in <module>
    sys.exit(load_entry_point('notion-scholar==0.2.0', 'console_scripts', 'ns')())
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_scholar/main.py", line 143, in main
    return run(**config_manager.get_run_kwargs())
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_scholar/run.py", line 41, in run
    add_publications_to_database(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_scholar/notion_api.py", line 59, in add_publications_to_database
    client.pages.create(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_client/api_endpoints.py", line 199, in create
    return self.parent.request(
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_client/client.py", line 194, in request
    return self._parse_response(response)
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/notion_client/client.py", line 126, in _parse_response
    raise APIResponseError(response, body["message"], code)
notion_client.errors.APIResponseError: body failed validation: body.properties.Bibtex.rich_text[0].text.content.length should be ≤ `2000`, instead was `2071`.

Can you put in the conversation the bibtex of the publication, so I can replicate the issue ?
1/23: Publication(key="10.1039/c5ra11101c", title="{A review on natural surfactants}")

Here's a link to the file: https://lists.papersapp.com/7RMuL8xbPpJc

I committed some changes that should have fixed the issue, can you please let me know if everything is alright now ?

Yup! Looks good, thanks a ton!


[Request] config size change

Hiya, thanks for the mod. Looks really nice but would it be possible to add an option to not change the size of the token? It screws up the maps too much for me and makes it hard to tell people which squares that the enemies are in. Other then that, solid work and thanks for sharing.

@paulo-roger https://github.com/paulo-roger/flying-tokens/pull/2/ :)

Included in the new release.
Thank you guys!


Results do not reproduce between self-hosted and hosted rewards model.

Describe the bug
When using the same simple conversation, I do not get consistent rewards between self hosted and hosted versions of the reward model.
Steps/Code to reproduce bug
Using the hosted API:
curl https://integrate.api.nvidia.com/v1/chat/completions \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer nvapi-_______________________________________________________" \
  -d '{
    "model": "nvidia/nemotron-4-340b-reward",
    "messages": [{"role":"user","content":"What is 1+1?"},{"role":"assistant","content":"Ooogo boogu shmugu loogu"}]  }'

{"id":"3cd3fd74-20d1-48bd-b537-2f20d70923b1","choices":[{"index":0,"message":[{"content":
"helpfulness:0.349609375,correctness:-0.357421875,coherence:2.984375,complexity:0.1044921875,verbosity:0.146484375"
,"role":"assistant"}],"logprobs":{"content":[{"token":"helpfulness","logprob":0.349609375,"top_logprobs":[]},{"token":"correctness","logprob":-0.357421875,"top_logprobs":[]},{"token":"coherence","logprob":2.984375,"top_logprobs":[]},{"token":"complexity","logprob":0.1044921875,"top_logprobs":[]},{"token":"verbosity","logprob":0.146484375,"top_logprobs":[]}]},"finish_reason":"length"}],"usage":{"completion_tokens":1,"prompt_tokens":60,"total_tokens":61}}%

Using the self-hosted version:
user: What is 1+1?
assistant: Ooogo boogu shmugu loogu
HELPFULNESS: -0.18
CORRECTNESS: 1.77
COHERENCE: 3.07
COMPLEXITY: 2.11
VERBOSITY: 1.77
[-1.7056844234466553, 0.2631499767303467, -1.4244399070739746, -0.6987995505332947, -0.18262653052806854, 1.772430419921875, 3.068037986755371, 2.105722427368164, 1.767025351524353]

Expected behavior
I would expect it to be possible to get consistent results (to make sure that the integration was successful).
The system prompt may be the reason for this discrepency, but we cannot specify our own system prompt with the hosted API.
Is there a system prompt in the hosted version?
Environment overview (please complete the following information)

Environment location: GCP
Method of NeMo-Aligner install: From docker

Environment details
Using the docker image recommended in the reward model's tutorial on huggingface.
Additional context
Running on 2 A100 machines.

Hi, thanks for your interest in the 340B Reward Model.
The hosted 340B RM is hosted based on TRTLLM while the self-hosted one is based on nemo-aligner so there's subtle differences wrt the kernels used etc. We tested both versions before releasing them and they should be similar in performance.
However, we appreciate that there is a large difference between what you see in the two settings.
I think the large difference is mostly attributable to the fact that the response Ooogo boogu shmugu loogu is totally irrelevant to the prompt What is 1+1? and hence entirely out of domain for the reward model and the differences might magnify. I would encourage you to try with responses like 2 or 3 (incorrect) to see if the answers make sense (2 should be approaching correctness 4 while 3 should be much closer to correctness 0).
Can I also check that you're using this docker docker pull nvcr.io/nvidia/nemo:24.01.framework?
Re. your qn on system prompts, can you also check that you're using the right prompt template (including system prompt)? The right templates are here https://github.com/NVIDIA/NeMo-Aligner/blob/main/examples/nlp/data/steerlm/attribute_annotate.py#L108 and https://github.com/NVIDIA/NeMo-Aligner/blob/main/examples/nlp/data/steerlm/common.py

I had the same issue. Studying the example code, it seems that one has to add the LABEL_PREFIX at the end of the assistant turn, i.e.
prompt = "I am going to Paris, what should I see?"
response = "Ah, Paris, the City of Light! There are so many amazing things to see and do in this beautiful city ..."
text = SYSTEM_PROMPT_TEMPLATE.format(value=SYSTEM_PROMPT)
text += USER_TURN_TEMPLATE.format(value=prompt)
text += ASSISTANT_TURN_TEMPLATE.format(value=response)
text += LABEL_PREFIX

With this, the results from self-hosted (PyTriton) and online match quite closely
# self-hosted
helpfulness: 1.6516182
correctness: 1.7003369
coherence: 3.2883744
complexity: 0.5568955
verbosity: 0.5116548
 # online
 helpfulness: 1.6171875
correctness: 1.6484375
coherence: 3.3125
complexity: 0.546875
verbosity: 0.515625

Thanks @andreasdoerr for this! Question: Did you get closer results with add_eos = True or False?

The numbers are for ‘add_eos=False’.
Setting EOS yielded worse results.

I can confirm that by adding the default system prompt, setting add_eos=False and adding the label prefix to the prompt, I receive the same results as the API by up to 0.01 on each score. Thanks!


Add Prometheus exporter

Added a Prometheus exporter to allow monitoring neohub with Prometheus.
Created Dockerfile to deploy this as part of a monitoring stack.
Also fixed a bug where HolidayEnd should be a string and failed to Unmarshall

I changed it so that all of the device-by-device code with args is now just a for loop and we return the device name as a label


WIP: Avoid uploading to tlog when upload is false

Goal is to be able to successfully sign and verify container images without having to communicate with tlog when --upload=false
Status:

[ ] - Disable uploading to tlog
[x] - Supporting verification of tlog bundle

Related to #1373

Do you need any help on this one?

Hey @sabre1041 is this ready for review?

@priyawadhwa Let me rebase off of main and do some testing again and circle back in the next day or two


Minor style fixes.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


misc(v2): change blog front matter to snake_case

Motivation
Standardize our front matter. Front matter should be snake_case 🐍. I'm preserving the camelCase for legacy reasons, so users using the camelCase will still work.
Also, I'm removing two following fields:

authorFBID - This is really unnecessary and we don't need it. People should just provide the FB Graph API image URL if they wanted a FB profile picture
authorTwitter- This was never ported to D2, but is still in the template and examples

I'm not updating the docs and template yet because it should be done only after alpha.35 is published or else there will be a mismatch between the doc and latest version.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Blog loads.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@endiliey done. Thanks for the tip


Is this even maintained?

I tried installing in PHP 4.5 and it won't work. I really need this for my business, I am literally losing money because of this!!!

Forgot to mention: the host is shared.

+1

Does it have support for the StrapiJS PHP rewrite?
https://twitter.com/strapijs/status/1377559734325276673?s=21

@freekmurze @rubenvanassche @AlexVanderbist @sebastiandedeyne @AdrianMrn @willemvb @brendt why are you ignoring this? please provide an answer ASAP

unacceptable.....

@WouterBrouwers kan jij deze eens bekijken? ;)

我也最好自己做

@AlexVanderbist, I don't have any time at the moment, but @jefvdv will maintain this package from now on.
His track record is immaculate ✨

Reopening as this is a very important issue.

@freekmurze you just sold me forever to Spatie! This company takes important issues seriously!

Reopening as this is a very important issue.

It's still closed though @freekmurze ?

Lol, reopening

Still investigating, hold on!

any update?

It's 2021. Fix this!

It's a 2021 bug. We need to wait until January 1st 2022.

@jefvdv it's 6 of january already, any updates on this?

Sorry but I got long covid on January 1st because of drinking contaminated champagne on December 31st.
My long covid will be over on April 1st. I will then start investigating whether we're using Log4j and maybe even fix it because something's going on.
You can rest assured this package is properly being taken care of!

It's quite disappointing to read that a global pandemic is more important than my issue.

@WouterBrouwers @jefvdv THIS NEEDS TO BE FIXED ASAP!

Folks, we're now in 2023 and this still hasn't been addressed. 😩

I'M WAITING, don't ruin my precious time!

Spatie is considered harmful!!!!!

Can I suggest a rewrite in Rust? 🦀

So folks, I think I fixed it, maybe someone can quickly check out #7 ?

My Company depends on this package and I demand from the maintainer to resolve this issue fast.

Why isn't this compatible with Laravel 12?

Feel free to send a PR


python312Packages.pytest-textual-snapshot: 0.4.0 -> 1.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.pytest-textual-snapshot is: Snapshot testing for Textual applications
meta.homepage for python312Packages.pytest-textual-snapshot is: https://github.com/Textualize/pytest-textual-snapshot
meta.changelog for python312Packages.pytest-textual-snapshot is: https://github.com/Textualize/pytest-textual-snapshot/releases/tag/v1.0.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.0 with grep in /nix/store/khyj5inrnfmp02iwd2spqqbhflacw8vq-python3.12-pytest-textual-snapshot-1.0.0
found 1.0.0 in filename of file in /nix/store/khyj5inrnfmp02iwd2spqqbhflacw8vq-python3.12-pytest-textual-snapshot-1.0.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

browsr
python311Packages.pytest-textual-snapshot
python312Packages.pytest-textual-snapshot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/khyj5inrnfmp02iwd2spqqbhflacw8vq-python3.12-pytest-textual-snapshot-1.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.pytest-textual-snapshot https://github.com/r-ryantm/nixpkgs/archive/0c2e6f18fdfcda215322f81f0dcbab7dd82803ed.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0c2e6f18fdfcda215322f81f0dcbab7dd82803ed#python312Packages.pytest-textual-snapshot

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/khyj5inrnfmp02iwd2spqqbhflacw8vq-python3.12-pytest-textual-snapshot-1.0.0
ls -la /nix/store/khyj5inrnfmp02iwd2spqqbhflacw8vq-python3.12-pytest-textual-snapshot-1.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

browsr
browsr.dist

4 packages built:

python311Packages.pytest-textual-snapshot
python311Packages.pytest-textual-snapshot.dist
python312Packages.pytest-textual-snapshot
python312Packages.pytest-textual-snapshot.dist

Maintainer pings
cc @fabaff for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 336106 at 0c2e6f18 run on x86_64-linux 1

3 packages built successfully:

browsr
python311Packages.pytest-textual-snapshot
python312Packages.pytest-textual-snapshot


Update lambda.md

Purpose of this pull request
This pull request is to fix the FER scope (specific data) as requested.
Select the type of change

[x] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions, updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

lgtm


Find out if fallbackLanguage was used in $translate

Hi angular translate Team,
thanks for your awesome work it's really incredible, it solves every translation problem on my current Project -so far.
By the way is there some way to donate a little money for your efforts?
Find out if fallbackLanguage was used in $translate
I need to find out if a translation was made with the active language or using a fallback.
My best bet so far is the custom Error Handler, since at least the missing translation logger seems to log missing translation based on each language. Is this the right way to go or is there some better approach?
Your environment

version of angular-translate
v 2.13.0
version of angular
v 1.5.8
which browser and its version
chrome 54.0.2840.71

Steps to reproduce
Really no steps to reproduce.
Expected behaviour
Concept of how to find out if fallbackLanguage was involved in the translation.
Actual behaviour
Just fine, but can't find out where the translation is from. (If a fallback Language was involved)

Maybe the last part "Using Post processing functionality" can help you here in combination with a "uses" call to determine current language and fallback etc. - see  https://angular-translate.github.io/docs/#/guide/16_error-handling

thanks a lot, i'm going to look into it and post the results

Ok, thanks a lot! This is what worked for me:
During the post Processing i add a specific string containing the language, like "###en-us" to the translation.
Later, when i receive the translation i split the received translation at the ###, seperate the translation from the language, and check if the language from the translation is the same as the active language.
Maybe not the best way but it works.
Thanks a lot for guiding me to the post processing functionality!


[Feature] Activity Heartbeats

What was changed
This PR implements Activity heartbeats. To be rebased and merged after #82
Checklist

Closes #83

How was this tested:
Unit tests and integration tests added

Any docs updates needed?
Docs will be updated before the release (#88)

Rebased against main without changes ^


Reinstate type-checking in unit tests

But only once https://github.com/kulshekhar/ts-jest/issues/1967 has a good resolution as otherwise we are faced with a massive memory leak.
See: #156

@RobinKnipe: This might be the reason for the unit tests not having type checking at the moment!

Or to be more exact, this: #159


pull request for e2e test at 11/15/2016 11:15:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Penny-Pincher: A budget app

Hello 👋
In this project I:

Created a Ruby on Rails application that allows the user to:

register and log in, so that the data is private to them.
introduce new transactions associated with a category.
see the money spent on each category.

Added authentication with devise

Added unit and integration test for main components

Used controllers to handle requests and render empty views.

Used params from browser requests in a safe way.

Used preprocessed html file with embedded Ruby code.

Used layouts and templates for shared content.

Used database migration files to maintain database schema.

Used validations for models.

Secured app from n+1 problems.

Here is the live demo link. Video
And here is the deployed app. Live

Thank you so much @Alfredbis29


stval already cannot be zero on breakpoints, misaligned addresses

Why does stval cannot be zero on breakpoints and misaligned addresses? The spec explicitly says it can be.

@YenHaoChen:  This is an old commit, and my assertion was (probably?) correct for the version of the document on Aug 16, 2021, but is no longer correct.  I recall there being a debate about this topic at the time.  The current Priv ISA 1.12, which was ratified four months later in December, 2021, changed the comment to say this:

For breakpoint and memory access traps that write a nonzero value to stval, GVA is redundant with field SPV (the two bits are set the same) except when the explicit memory access of an HLV, HLVX, or HSV instruction causes a fault.  In that case, SPV=0 but GVA=1.

So the current ratified Priv spec allows for zero in stval.  Furthermore, the comment quoted above remains the same in the latest draft for Priv 1.13 (not yet ratified).

@jhauser-us Thanks for your reply and clarification.
I was searching for the answer: If a breakpoint trap due to an EBREAK instruction writes zero to STVAL from VS/VU-mode, what should the GVA value be?
The current spec states: For any trap (breakpoint, ...) that writes a guest virtual address to STVAL, GVA is set to 1; otherwise, GVA is set to 0. The sentence isn't clear enough to me whether a breakpoint trap due to an EBREAK instruction writing zero to STVAL applies to the condition or not.
While searching for the answer, I found this deprecated commentary that clarifies the question. Since STVAL can be zero on a breakpoint trap due to the EBREAK instruction, the old commentary provides a better description of the GVA during traps.
Should we consider reverting this commit?

@YenHaoChen, if you think the current text you quoted isn't clear enough about whether a zero written to stval on an EBREAK trap counts as a guest virtual address when the EBREAK instruction's actual guest virtual address is not zero, please open a new GitHub issue requesting clarification on this specific question.  From there, you can point back to this commit.


Fix bugs

Make cplex 12.7 to work

Implement set_linear_coefficients in scipy_interface

Current coverage is 86.78% (diff: 64.58%)

Merging #56 into devel will decrease coverage by 0.30%

@@              devel        #56   diff @@
==========================================
  Files             8          8
  Lines          2285       2315    +30
  Methods           0          0
  Messages          0          0
  Branches        507        516     +9
==========================================
+ Hits           1990       2009    +19
- Misses          189        198     +9
- Partials        106        108     +2

Powered by Codecov. Last update b06eff8...6fd27c3

closes #53


recommendation invalid request

when making a recommendations request such as:
recommend = sp.recommendations(target_energy = 0.5)
I get the error:
Traceback (most recent call last):
File "script.py", line 62, in
recommend = sp.recommendations(target_energy = 0.5)
File "/usr/local/lib/python2.7/dist-packages/spotipy/client.py", line 804, in recommendations
return self._get('recommendations', **params)
File "/usr/local/lib/python2.7/dist-packages/spotipy/client.py", line 146, in _get
return self._internal_call('GET', url, payload, kwargs)
File "/usr/local/lib/python2.7/dist-packages/spotipy/client.py", line 124, in _internal_call
headers=r.headers)
spotipy.client.SpotifyException: http status: 400, code:-1 - https://api.spotify.com/v1/recommendations?target_energy=0.5&limit=20:
invalid request
any particular reason why this is giving an invalid request?

Looks like you didn't get token authorization for the session. The error message says "no token provided"

I think that is because you have to put at least one of these parameters in the request:

seed artists;
seed genres;
seed tracks.
Target_energy isn't sufficient.

@JessicaMartini212887 is correct, we need to update the doc accordingly

I think that is because you have to put at least one of these parameters in the request:

seed artists;
seed genres;
seed tracks.
Target_energy isn't sufficient.

At least one is enough? I tried just by giving the seed track. And I still got an error stating 'invalid request'. Or should we give more than one track_id?

@AkiMosi can you please share the exact request being made + full stacktrace

@AkiMosi can you please share the exact request being made + full stacktrace/error
And does that same request work if you try it on this web UI? https://developer.spotify.com/console/get-recommendations/

I found what I did wrong with the code, by going through issue #305
I did not give it as a list, I just gave the id as a string.
Thanks for your quick response, and it would be great if you add a little code snippet in the examples of the documentation.

Cool! Please feel free to open a PR to add an example
Just for reference, since this is about types I'm linking this issue https://github.com/plamere/spotipy/issues/439

When attempting to pull down recommendations, I am getting the following error:
HTTP Error for GET to https://api.spotify.com/v1/recommendations returned 400 due to invalid request
Traceback (most recent call last):
  File "/home/darkmage/.local/lib/python3.8/site-packages/spotipy/client.py", line 245, in _internal_call
    response.raise_for_status()
  File "/usr/lib/python3/dist-packages/requests/models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://api.spotify.com/v1/recommendations?limit=20&seed_artists=Katy+Perry

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "bug_recommendations.py", line 12, in <module>
    main()
  File "bug_recommendations.py", line 9, in main
    results = sp.recommendations(seed_artists=artist_list)
  File "/home/darkmage/.local/lib/python3.8/site-packages/spotipy/client.py", line 1597, in recommendations
    return self._get("recommendations", **params)
  File "/home/darkmage/.local/lib/python3.8/site-packages/spotipy/client.py", line 291, in _get
    return self._internal_call("GET", url, payload, kwargs)
  File "/home/darkmage/.local/lib/python3.8/site-packages/spotipy/client.py", line 261, in _internal_call
    raise SpotifyException(
spotipy.exceptions.SpotifyException: http status: 400, code:-1 - https://api.spotify.com/v1/recommendations?limit=20&seed_artists=Katy+Perry:
 invalid request, reason: None

I followed the API documentation, here is the script generating the error:
import spotipy
from spotipy.oauth2 import SpotifyClientCredentials

def main():
    sp = spotipy.Spotify( auth_manager=SpotifyClientCredentials( client_id="CLIENT_ID", client_secret="CLIENT_SECRET"))
    result_amount = 5
    artist_list = [ "Katy Perry" ]
    results = sp.recommendations(seed_artists=artist_list)

if __name__ == "__main__":
    main()

@mikedesu see https://github.com/plamere/spotipy/issues/290#issuecomment-399616161

@mikedesu see #290 (comment)

My apologies, the issue isn't answered of in that comment, hence the post.
However, I realize the problem now. The artist list must be comprised of artist IDs, not artist names.
Thanks.


Fix ctrl-Z handling

To correctly mimic the behavior of a terminal we need to send SIGTSTP to the whole foreground process group, instead of just sending it to ourselves.
Fixes go-delve/delve#3605

Is this how we make PRs for this fork?

This looks like what I would expect - thanks for finding it!


internal/runner: multiline inline executions get cut off

The following test (in service_test.go/Test_runnerService) will not pass - the resulting $LICENSE will get cut off after the first new line. This is a test script in the example README file.
	t.Run("ExecuteLicenseCat", func(t *testing.T) {
		t.Parallel()

		stream, err := client.Execute(context.Background())
		require.NoError(t, err)

		execResult := make(chan executeResult)
		go getExecuteResult(stream, execResult)

		err = stream.Send(&runnerv1.ExecuteRequest{
			ProgramName: "bash",
			Commands: []string{
				"export LICENSE=$(cat ../LICENSE)",
				"echo \"LICENSE: $LICENSE\"",
			},
		})
		assert.NoError(t, err)

		result := <-execResult

		assert.Len(t, result.Responses, 3)
		assert.Greater(t, len(result.Responses[1].StdoutData), 20)
	})

I can reproduce it. The problem is with reusing buffers in readLoop(). I thought that using two alternating buffers is enough but no message can be altered/reused after calling SendMsg() and there is no indicator when that's possible except for GC.


App steals system focus to notify user of non-error.

Each time my journals are read your app notifies me of these errors. The ingame situation arises like this:

Land on a world
deploy an SRV onto the surface
disembark the SRV, leaving it in the boarding location
board the ship on foot, using the light column
use the role panel to board the SRV - this teleports you into the SRV on the surface. If it is running, your app will minimize the game to alert me of the error. This is not necessary, it isn't a common occurance, but perfectly acceptable gameplay.

Very useful app, thanks. I appreciate it enough that I signed up to Github to tell you this.
Full readout of errors:
5 errors encountered.
Error reading file Journal.2022-04-24T081012.01.log: The JSON value could not be converted to Observatory.Framework.Files.ParameterTypes.VehicleSwitchTo. Path: $.To | LineNumber: 0 | BytePositionInLine: 73.
Error reading file Journal.2022-05-16T124642.01.log: The JSON value could not be converted to Observatory.Framework.Files.ParameterTypes.VehicleSwitchTo. Path: $.To | LineNumber: 0 | BytePositionInLine: 73.
Error reading file Journal.2022-06-19T105304.01.log: The JSON value could not be converted to Observatory.Framework.Files.ParameterTypes.VehicleSwitchTo. Path: $.To | LineNumber: 0 | BytePositionInLine: 73.
Error reading file Journal.2022-07-19T162012.01.log: The JSON value could not be converted to Observatory.Framework.Files.ParameterTypes.VehicleSwitchTo. Path: $.To | LineNumber: 0 | BytePositionInLine: 73.
Error reading file Journal.2022-07-23T215444.01.log: The JSON value could not be converted to Observatory.Framework.Files.ParameterTypes.VehicleSwitchTo. Path: $.To | LineNumber: 0 | BytePositionInLine: 73.
Full error details logged to ObservatoryErrorLog file in your documents folder.

While the loss of focus is annoying, I think the error here is:
The JSON value could not be converted to Observatory.Framework.Files.ParameterTypes.VehicleSwitchTo.
I encounter the same error when trying to read all journals.
This seems to be fixed by 229e76b
@Xjph is there a timeline for a hotfix release?

I believe this should be fixed already, sorry I didn't respond here earlier. Feel free to reopen this if I'm wrong.


Dev Test: Virtual Workshop

@amanda-phet, @kathy-phet, @mattpen, @KatieWoe the Virtual Workshop is ready for another round of dev testing. Please document issues in https://github.com/phetsims/website-meteor/issues and link to this issue.
Assigning @kathy-phet for prioritization.

General Dev Test

What to Test

Click every single button.
If there is sound, make sure it works.
Try to include browser version numbers

Focus and Special Instructions
Please make sure all links work as expected, the page navigation works appropriately in both desktop and mobile view (the column on the left side only, not the top nav bar), and that the responsive layout handles the content without looking buggy. Sometimes the animations can be slow to respond as the page is loading, however, please look out for performance issues once loading is complete. If loading takes excessive time on a device + browser, please let me know.
There have been updates to the left-column navigation. Please report any buggy-looking behavior, or ask me (@chrisklus) on slack if unsure.

General Dev Test Platforms

[x] Latest macOS, Chrome and Safari (Time = 4.5 hrs )
[x] NVDA (Time = 1.5 hours)
[x] JAWS (Time = 1.5 hours)
[x] Latest iOS, Safari (Time = 2 hrs)
[ ] Windows 10, all browsers (IE dropped) (Time = 3.0hrs )
[x] Latest Chrome OS, Chrome (Time = .75 hours)

Link(s)

Virtual Workshop

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

QA is done

A new test has been opened, closing.


Test - first

Test - first

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: content-bot:x: RotemWork:x: ilappe:x: dependabot[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


GONOPROXY doesn't whitelist my private modules

What version of Go are you using (go version)?

$ go version
go version go1.12.6 linux/amd64

Does this issue reproduce with the latest release?

What did you expect to see?
My whitelisted private modules should not be queried to proxy.golang.org
What did you see instead?
go: finding gitlab.com/localmeasure/std v0.0.0-20190618060853-6f2e594241de
go<EMAIL_ADDRESS>unexpected status (https://proxy.golang.org/gitlab.com/localmeasure/std/@v/v0.0.0-20190618060853-6f2e594241de.info): 410 Gone
go: error loading module requirements

Seems to me like you're misusing the pattern. You likely want gitlab.com/localmeasure/*.
Also, see the new GOPRIVATE var being added in 1.13, which is more appropriate for these purposes. It uses the same syntax.

thanks @mvdan, still no luck with gitlab.com/localmeasure/* though
export GOPROXY=https://proxy.golang.org
export GONOPROXY=gitlab.com/localmeasure/*
export GONOSUMDB=$GONOPROXY
...
source ~/.profile
go clean -modcache
...
go get -d ./...
go: finding gitlab.com/localmeasure/std v0.0.0-20190618060853-6f2e594241de
go<EMAIL_ADDRESS>unexpected status (https://proxy.golang.org/gitlab.com/localmeasure/std/@v/v0.0.0-20190618060853-6f2e594241de.info): 410 Gone
go: error loading module requirements

Be careful with characters like * in the shell; they might be getting expanded. You might want to verify that it's being set properly via go env | grep gitlab or something similar.

that could be the problem then, my go env doesn't have GONOPROXY nor GONOSUMDB, it only picks up GOPROXY
export GOPROXY="https://proxy.golang.org"
export GONOPROXY="gitlab.com/localmeasure/*"
export GONOSUMDB="gitlab.com/localmeasure/*"

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/khoa/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/khoa/go"
GOPROXY="https://proxy.golang.org"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build090552563=/tmp/go-build -gno-record-gcc-switches"

Right. These were added in master as part of the 1.13 cycle, so you can't use them in 1.12.x

Thought it was ready :) , appreciate your help.


connect to csv file, everything gets converted to multipolygon

This is my csv file, however, when i upload it to cartoDB, how come everything gets converted to POLYGON? how can i keep them as LINESTRING and POINTS?
"the_geom","layer"
"LINESTRING(-171.123046875 83.89571893465583,-174.462890625 83.9050579559856,-174.462890625 81.22826656005543)","walls"
"LINESTRING(-160.927734375 83.92369331796976,-126.5625 83.9422719152186)","walls"
"LINESTRING(-116.89453125 83.9329897014893,-76.201171875 83.96079391869429,-76.201171875 75.6504309974655,-174.19921875 75.58493740869223,-174.462890625 79.95126549716151,-150.380859375 79.981890541616)","walls"
"LINESTRING(-144.84375 79.90515411752526,-144.66796875 75.6504309974655)","walls"
"POLYGON((-96.240234375 75.84516854027044,-96.240234375 82.68748032987172,-76.81640625 82.68748032987172,-76.81640625 75.84516854027044,-96.240234375 75.84516854027044))","rooms"
"LINESTRING(-89.20898437499999 82.72096436126803,-76.201171875 82.73209178206493)","walls"
"LINESTRING(-96.50390625 82.69865866056999,-96.591796875 75.71563324165896)","walls"
"POLYGON((-173.84765625 75.82365950624266,-173.84765625 79.85883334713468,-145.37109375 79.85883334713468,-145.37109375 75.82365950624266,-173.84765625 75.82365950624266))","rooms"

Thx

CARTO importer does not support different geometry types as explained on our Docs.


Cargo fmt with unstable features

Fresh version of #1670 off the latest main.
Mostly fixing documentation wrapping.

This is just cargo fmt using the unstable cargo fmt features from rustfmt.toml.

@cart this is done now with the option removed. Please merge this ASAP so I can stop rebasing <3

bors r+


Calculate COCO mAP

This PR expands on evaluate_detections to compute pycocotools style mAP and introduces a COCODetectionResults to print the mAP and plot PR curves from the evaluation.
import fiftyone.zoo as foz
import fiftyone as fo

dataset = foz.load_zoo_dataset("quickstart").clone()
results = fo.evaluate_detections(dataset, "predictions")

results.metrics()

{'accuracy': 0.1970163774931085, 'precision': 0.1970163774931085, 'recall': 0.1970163774931085, 'fscore': 0.1970163774931085, 'mAP': 0.3957238101325777}

pycocotools also computes an mAP of 0.396
results.plot_pr_curves(classes=["person"])

I haven't forced a classwise=False calculation even though it would be nice so that we can get more interesting confusion matrices. The MSCOCO evaluation uses True by default, I'm thinking just let the user change it if they want.

What do you think about not computing mAP values by default? I'm concerned that it will slow down evaluation quite a bit for large datasets, and may not be relevant to users in all cases (which is problematic while COCO-style evaluation is our only evaluation option).
Here's couple ideas that come to mind on how to handle this:
(a) Provide an optional COCOEvaluationConfig parameter that controls whether IoU sweeps are performed so that mAP and PR curves can be generated. The user has to opt-in to this in order to have the relevant information populated
(b) Never perform IoU sweeps inside evaluate_detections(); instead, pass the necessary parameters through to the COCODetectionResults object and let it perform the IoU sweeps only if the user calls a method like mAP() or plot_pr_curves() on the results object
I'm torn on how to best proceed here... since I see some cons to both approaches:
(a) If the user doesn't opt-in to IoU sweeps, then the mAP() and plot_pr_curves() methods of their results object will have to raise errors. Which indicates that the results object may need to be able to compute this information anyway as in (b)
(b) This will require the SampleCollection and other information be passed to the results object. This is not technically an issue, but it does break an existing convention that results objects contain all the necessary information to generate eval results without needing to touch the user's dataset again. Many of the methods of EvaluationResults do perform computations, though, so maybe this is okay...
What are your thoughts?

Man, that's a tough problem. I would prefer to have the user opt-in to running evaluation with IoU sweeps if they want mAP() and plot_pr_curves(). I don't like the idea of results being tied to a SampleCollection. If we were to go that way, it may make more sense to make results part of a SampleCollection.
Though I also don't like the idea of having mAP() raise errors based on what was passed into the COCODetectionResults. I feel like a solution may be to just return DetectionResults unless you opt-in to computing mAP, which would then return COCODetectionResults that lets you access mAP() and plot_pr_curves().

What do you think about not computing mAP values by default? I'm concerned that it will slow down evaluation quite a bit for large datasets, and may not be relevant to users in all cases (which is problematic while COCO-style evaluation is our only evaluation option).
Here's couple ideas that come to mind on how to handle this:
(a) Provide an optional COCOEvaluationConfig parameter that controls whether IoU sweeps are performed so that mAP and PR curves can be generated. The user has to opt-in to this in order to have the relevant information populated
(b) Never perform IoU sweeps inside evaluate_detections(); instead, pass the necessary parameters through to the COCODetectionResults object and let it perform the IoU sweeps only if the user calls a method like mAP() or plot_pr_curves() on the results object
I'm torn on how to best proceed here... since I see some cons to both approaches:
(a) If the user doesn't opt-in to IoU sweeps, then the mAP() and plot_pr_curves() methods of their results object will have to raise errors. Which indicates that the results object may need to be able to compute this information anyway as in (b)
(b) This will require the SampleCollection and other information be passed to the results object. This is not technically an issue, but it does break an existing convention that results objects contain all the necessary information to generate eval results without needing to touch the user's dataset again. Many of the methods of EvaluationResults do perform computations, though, so maybe this is okay...
What are your thoughts?

Man, that's a tough problem. I would prefer to have the user opt-in to running evaluation with IoU sweeps if they want mAP() and plot_pr_curves(). I don't like the idea of results being tied to a SampleCollection. If we were to go that way, it may make more sense to make results part of a SampleCollection.
Though I also don't like the idea of having mAP() raise errors based on what was passed into the COCODetectionResults. I feel like a solution may be to just return DetectionResults unless you opt-in to computing mAP, which would then return COCODetectionResults that lets you access mAP() and plot_pr_curves().

Okay yeah I think this sounds good to me then:

If a user does not request IoU sweeps, then they get a DetectionResults instance, even though "COCO-style" evaluation was performed (without the IoU sweeps, there's not much that's COCO-specific going on)
If a user does request IoU sweeps, they get a COCODetectionResults object as you've implemented that contains the precision and recall numbers

Alrighty @brimoor , I addressed your comments and added a compute_mAP argument to the COCOEvaluationConfig that defaults to False so that evaluate_samples returns a DetectionResults object. It will return COCODetectionResults if compute_mAP is True.


removes fetch override

closes #8
There's a bug with this extension that breaks live logs from github actions due to the fetch api being manipulated to add a __account__ query parameter to every request. This causes a 400 when trying to query the github pipeline API.
This "fix" is to just remove all of the code surrounding the fetch override and any other references to __account__. As far as I can tell, everything about the extension still works fine as well as live logs from github actions.
I'm happy to have another crack at this if there is a reason for the code I've removed to still exist.

The __account__ parameter is the trick to avoid the account conflict. I'm afraid that we cannot remove it.

Could you explain the conflict in a little more detail? I've been using my fork since I created it and haven't experienced any issues.

As I remember, the __account__ trick is to help determine which account the request belongs from. I was planning to support using multiple accounts without manually switching or auto-switching. But I don't know whether it is relevant now.
I will checkout your code to test it locally.


Disc play error: "Sign in to confirm you`re not a bot" (seems like youtube ratelimiter)

This server is running Paper version git-Paper-496 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 7ac24a1
on ver/1.20.4)

pv-addon-discs: 1.0.6
pv-addon-lavaplayer-lib: 1.0.9

Error when i try to use /disc burn command. In console no errors yet.
I'm ready to provide more information of my issue.
Apparently I need to provide the plugin with an authorization cookie or authorization data so that it can use the account to access YouTube. But it seems that there is no such possibility.

UP!

UP! Because I have the same problem, but when I insert a burned disc into the player.
pv-addon-discs: 1.0.7
pv-addon-lavaplayer-lib: 1.0.10

Ребята, будет ли фикс этой проблемы?
Ведь плагин не работает на версии 1.21...


Tunnel endpoint IPs of manual SPDs do not get updated for DynDNS peers

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x ] I have searched the existing issues and I am convinced that mine is new.

Describe the bug
When an IPsec tunnel to a DynDNS peer is created with manual SPD entries in phase2, the tunnel endpoint IP for these entries in the SPD database does not get updated when the peer IP address changes. Only the manual SPDs are affected, the others are updating without problems. Even a restart of the IPsec service does not clear the incorrect entries, a reboot of the OPNsense is neccessary to get rid of them.
To Reproduce
Steps to reproduce the behavior:

Create an IPsec tunnel to a DynDNS peer
Add a manual SPD in phase2
Let the peer change its IP address
Verify the entries under VPN-> IPsec-> Security Policy Database
Result: The manual SPD entry still refers to the old tunnel endpoint IP

Expected behavior
All SPD entries refer to the new tunnel endpoint IP.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.1.4 (amd64, OpenSSL).

I think this more or less duplicates https://github.com/opnsense/core/issues/4860

I think this more or less duplicates #4860

Not sure about that. Maybe I should add some more information:

Both peers are running OPNsense
The tunnel works perfectly fine until the IP address of the DynDNS peer changes.
After the DynDNS peer has changed its IP, only traffic originating from the primary source network defined in phase2 is able to pass through the tunnel. Traffic from the network which is defined as manual SPD no longer passes the tunnel because of the incorrect tunnel endpoint IP in the Security Policy Database.

which I think is the same thing as the other issue, since it probably does a reverse lookup instead of pointing to the dyndns name. you could check the contents of /usr/local/etc/ipsec.conf to be sure.

you could check the contents of /usr/local/etc/ipsec.conf to be sure.

I checked that file, I have the DynDNS fqdn both in the right and rightid parameter.

If you need a DynDNS peer for testing, I'm happy to provide one.

I have exactly the same problem.

same problem here. please fix it

Locking this, please don't ping closed tickets from tickets from 2021 and add your problem description too.


Label title fix

Aims to fix problem set out in this issue.
https://github.com/benawad/dogehouse/issues/2516

Possible duplicate of #2492

dupe of #2492


Trying to use PostgreSQLContainer but no postgres container is being started

Using the following code in a spring boot app test
@Rule  public PostgreSQLContainer postgres = new PostgreSQLContainer("postgres:alpine")       .withDatabaseName("postgres")       .withUsername("postgres")       .withPassword("password");
The tests work when I manually start a postgres:alpine container but when I run the code with the above rule I get exceptions like this
org.postgresql.util.PSQLException: Connection to <IP_ADDRESS>:5432 refused. Check that the hostname and port are correct and that the postmaster is accepting TCP/IP connections.
The output I see from docker events is as follows and seems to suggest it's using a default alpine:3.5 container and not the one I have specified?
2017-11-05T20:25:49.602139889Z container create eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori) 2017-11-05T20:25:49.961818675Z network connect 2f245451bd81f3faf19bd33bbfa4e13ec092dd637607e4aabab2c68fd21b4df2 (container=eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22, name=bridge, type=bridge) 2017-11-05T20:25:50.429203163Z container start eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori) 2017-11-05T20:25:50.439917834Z container exec_create: df -P eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori) 2017-11-05T20:25:50.454331797Z container exec_start: df -P eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori) 2017-11-05T20:25:50.522639649Z container archive-path eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori) 2017-11-05T20:25:50.701537187Z container kill eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori, signal=9) 2017-11-05T20:25:50.750975128Z container die eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (exitCode=137, image=alpine:3.5, name=confident_cori) 2017-11-05T20:25:51.153292105Z network disconnect 2f245451bd81f3faf19bd33bbfa4e13ec092dd637607e4aabab2c68fd21b4df2 (container=eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22, name=bridge, type=bridge) 2017-11-05T20:25:51.332111665Z container destroy eff497e66e117b1adcc7e5610704767cd4e32f29ce2e8d31026a4f6a1025cd22 (image=alpine:3.5, name=confident_cori)
$ docker --version
Docker version 17.05.0-ce, build 89658be
uname -a
Linux robslappy 4.4.94-040494-generic #201710211231 SMP Sat Oct 21 16:33:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Really like the idea of using testcontainers it's a great idea and exactly what I was looking for.

Hi @RobMaskell,

<IP_ADDRESS>:5432

you should use getJdbcUrl() instead of trying to connect to 5432 port. TestContainers assigns random ports to ensure that parallel tests will not affect each other.
Another option is to form the URL manually and use getFirstMappedPort() or getExposedPort(0)

Hi @bsideup  Thanks for the response, I can try that but I'd feel better about refactoring if I saw a postgres container start up? Should that not appear in the docker events?

@RobMaskell we perform some pre-flight checks before starting your containers, this is why you see alpine:3.5 there. You can also disable them with checks.disable=true in ~/.testcontainers.properties file :)

I did check the logs and see some checks which must be these pre-flights but I think they all passed, my app started up and then failed, but still no postgres:alpine container in the events.
I'll make the changes you suggest and see what happens.

You can also monitor the running Docker containers directly, to get more information:
watch docker ps

Thanks @kiview
Ok so changing to @ClassRule I get a postgres:alpine container but spring boot seems to have already created a datasource by the time the Initializer tries to use postgres.getJdbcUrl() to set the property
@ClassRule
public static PostgreSQLContainer postgres = new PostgreSQLContainer("postgres:alpine")
		.withDatabaseName("postgres")
		.withUsername("postgres")
		.withPassword("password");

public static class Initializer implements ApplicationContextInitializer<ConfigurableApplicationContext> {
	@Override
	public void initialize(ConfigurableApplicationContext configurableApplicationContext) {

		EnvironmentTestUtils.addEnvironment("testcontainers", configurableApplicationContext.getEnvironment(),
				"spring.datasource.url=" + postgres.getJdbcUrl()
		);
	}
}

Any idea how to get the container to fire up earlier before spring creates the datasource from the details in application.properties and tries to run schema.sql against a database that isn't there.
I'm using testcontainers because I trying to create multiple databases, one per tenant and it's Db specific so testcontainers is ideal. However if I use the jdbc:tc:postgress... method I end up with a container per tenant and that doesn't work either, although it does solve my ordering issue.

@RobMaskell sure, take a look at:
https://github.com/bsideup/testcontainers-microservices-example/blob/5d28ca32d29d9fd7f3101044a02ec2660b0678fd/src/test/java/org/testcontainers/example/demo/support/AbstractIntegrationTest.java#L38

Here is another example of doing this:
https://github.com/testcontainers/testcontainers-java-examples/blob/master/spring-boot/src/test/java/com/example/AbstractIntegrationTest.java
The trick is, to configure the datasource before the Spring application context is initialized, so you have to get the point in the Spring lifecycle right.
I'll close this issue, if you need further help, would you like to post a question on Stackoverflow and maybe post the link in this issue, or in our Slack?

I have it working now, thanks for the help


[glib] build failure

Operating system
windows-arm
Compiler
msvc
Steps to reproduce the behavior
vcpkg install glib --triplet=arm-windows

Failure logs
missing linking with three libraries - advapi32.lib, shell32.lib ole32.lib.
Additional context
manually adding these link arguments to the ninja build file results in success. how can the port files be modified to include these? so when a glib is built as part of another package it can succeed?

also package cairo is missing ole32.lib for arm-windows

also package pango is missing advapi32.lib for arm-windows

also sassc missing shell32.lib

also gtk3 missing Gdi32.lib shell32.lib ole32.lib advapi32.lib for arm-windows
is there some global settings for vcpkg on a per triplet basis?

Do you really want to target 32-bit arm instead of arm64?
Please show proper error logs.
glib is built with meson.
For windows, vcpkg normally passes implicit link libraries as initialized in CMake to meson, via a generated "machine file".
(And meson doesn't use that list for configuration tests...)


remove faraday version

Motivation (Why)
Fix bundle install in main app
Resolving dependencies.......
Bundler could not find compatible versions for gem "faraday":
  In snapshot (Gemfile.lock):
    faraday (= 0.15.4)
  In Gemfile:
    chartmogul-ruby was resolved to 1.5.0, which depends on
      faraday (~> 0.15.0)
    xpm_ruby was resolved to 0.1.0, which depends on
      faraday (~> 1)
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

Great catch on the Gemfile.lock :+1:


Use Supplier to pass a name to isDeleteTarget

This is a workaround to problem with createQualifiedObjectName failing
with "Catalog must be specified when session catalog is not set"
exception when called for Table object during process of Hive view
expansion and when session catalog is not set.
The problem comes from fact that main query and query being view
definitition are parsed in different contexts and then merged without
augmentation into single AST tree.
Issue: https://github.com/prestosql/presto/issues/6294

@martint I do not expect this is a proper solution to a problem. But let's use this PR to discuss how it actually should look like :)
One think I can think of is to use RefNode instead QualifiedObjectName as Analysis.target and then change isDeleteTarget to take Node as a parameter.
Maybe we can also change the AST we get from parsing query from the VIEW so the names are always fully qualified.
WDYT?
cc: @kasiafi @findepi

The problem comes from fact that main query and query being view
definitition are parsed in different contexts and then merged without
augmentation into single AST tree.

Does it mean that view using unqualified table names was referencing wrong table name, when session catalog & schema was set?
Or, it was referencing wrong table name in this particular place only, so it was user-invisible bug?

The problem comes from fact that main query and query being view
definitition are parsed in different contexts and then merged without
augmentation into single AST tree.

Does it mean that view using unqualified table names was referencing wrong table name, when session catalog & schema was set?

No, it does not seem so. The analysis of view is done in correct context with catalog/schema set to match catalog where view as defined.

Or, it was referencing wrong table name in this particular place only, so it was user-invisible bug?

I think problem is only with this call.

No, it does not seem so. The analysis of view is done in correct context with catalog/schema set to match catalog where view as defined.

Can we use the correct context here, for constructing the qualified name?
BTW, this will still not be fully correct, since my query can read and delete from the same table at once:
DELETE FROM t
WHERE x IN (SELECT y FROM FROM t WHERE ....)

it will be sufficient for views though, since we do not allow DELETE from VIEW today.

@losipiuk analysis already has Table -> QualifiedObjectName mapping,
see: io.prestosql.sql.analyzer.Analysis#registerTable and io.prestosql.sql.analyzer.Analysis#registerTable.
You should be able to use it.

Replaced with https://github.com/prestosql/presto/pull/6296


href redirection after browser back button

Hi,
I'm using jstree with lazy loading from a database, that returns json objects. Leaf nodes contain a link and redirect the user on click. The problem is, when the user hits the back button after getting redirected to the new page, the tree is first loaded in the previous state, and then the user is immediately redirected again. I'm using plugin state to save the states of all nodes. Is it possible to prevent this redirection after hitting the back button? Perhaps by only saving the state of opened nodes, but not of selected? Here is the code I used for the tree:
$('#ajax').jstree({
                 'core' : {
                        'data' : {
                                 "url" :  function(node) {
                                         return node.id === '#' ? "./tree.php" : "./tree.php?id="+node.id;
                                },
                                type: 'GET'
                        }
                },
                'plugins' : ['state'],
         }).on("select_node.jstree", function (e, data) {document.location = data.instance.get_node(data.node, true).children('a').attr('href')});

Thanks a lot for your help in advance.

You can filter the state object using:
https://www.jstree.com/api/#/?q=state.filter&f=$.jstree.defaults.state.filter
Remove the core.selected property and selection will not be restored.
Alternatively - attach your handler only after state_ready.jstree has fired:
https://www.jstree.com/api/#/?q=state_ready&f=state_ready.jstree


Added Wheel Picker for Android platform

Thanks for submitting a PR! Please read these instructions carefully:

[x] Explain the motivation for making this change.
[x] Provide a test plan demonstrating that the code is solid.
[x] Match the code formatting of the rest of the codebase.
[x] Target the master branch, NOT a "stable" branch.

Motivation (required)
Create Wheel picker like DatePickerIOS for Android Platform
What existing problem does the pull request solve?
Test Plan (required)
Checkout https://github.com/ElekenAgency/ReactNativeWheelPicker
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
If you have added code that should be tested, add tests.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.

@ArtemKosiakevych this will be better off as an independent package :)

We are trying to not overcomplicate core repository, this kind of functionality should be implemented as a separate module/package.


Remove PyTorch Profiler experiment (enable the feature by default)

The experiment seems to be running to 100% of users.

cc @brettcannon @karthiknadig


Typo fix (uppercase "Poisson" instead of "poission")

Very minor change in the doc

@frantzmiccoli I appreciate your contribution, no matter how minor :)
I would like to change the pyGAM license to allow proprietary use of the library, which means downstream users would NOT need to release the source-code of their application when they use pyGAM.
The current GPLv3 license is quite strict, and the hope is that a more passive license will encourage (proprietary) contributors to keep improving this library.
Please let me know if you are ok with this change.
Thanks,
Danny
PS:
I am considering the following licenses:

Lesser GPLv3, (tldr: any modifications must be made open-source, but downstream applications do not need to be open-sourced, and can use a different license)
Apache 2.0 (tldr: any use and modifications are allowed, with any license, with or without release source-code. all modifications must be explicitly stated.)
MIT (tldr: you can do anything you want with the software, and the software comes with no warranties)

Current GPLv3 license for reference. (tldr: any modifications and downstream applications must be made open-source and released with the same license)

I would vote for MIT, but anything you like!


[Request] Implement Private Profiles

Problem: Opendota still has my historical data even if I have Expose Match Data setting off. Even though it's my fault to enable it one year ago for a moment - it is still a problem that I cannot make my data go private - I just don't want my match history/past stats to be shown to everybody. This was also requested many times in #general discord channel.
Motivation: With recent Valve news on cheaters and draft anonymity I think it's clear that Valve want to support anonymity and respect private data. So it would be nice for OpenDota to follow the example. Maybe there is some law thing too, but I don't want to nerd it out; it just would be humanly-nice to be able to set my opendota to private.
Valve made profiles hidden during the draft but in theory players still can google my name/see my avatar in Opendota and get the stats. So next step for better anonymity is either for Valve to hide names/avatars in draft or for Opendota to implement Private Profiles.
Solution: For example, Stratz, Dotabuff already respect the Expose setting and hide my profile data from others.

Dotabuff approach would be perfect: where the data is hidden from others but I can still access it if I log in.
Stratz approach to hide the data from everybody including me is also fine. (edit: now you can view your data if you login in stratz too)

OverwolfDotaPlus also respected Valve decision and removed sniping-people data in the draft stage too.
Alternative solution: odota/web#2883 where OP suggests manual opt-in/out, but I think just following Stratz/Dotabuff example would be more intuitive.

I'm on board with this change if someone wants to create a PR, but don't currently have the bandwidth to work on it directly.
I think we have the necessary data to do it already--we can just not load the matches list for players in all the player data endpoints if fh_unavailable (we set this when we try to fetch match history for a player) in the SQL database is true and the cookie doesn't match the user ID.
In the UI if we want to create a message showing that the player is private, that's a bonus

Erm, does it fully work actually? Am I missing something?
Opening my profile in incognito (https://www.opendota.com/players/112636165) leads to this attached picture below:
While it clearly has a lot of zeros and doesn't show data like "Counts", "Players Played With". etc. - It still shows my match history from before I last enabled Expose Setting and "Averages/Maximums".
Also there is no clear message that my profile is supposed to be private, like we discussed stratz/dotabuff examples.

Updated to hide last 20 matches, MMR (although this is many years out of date anyway) and rankings as well.
The showing an improved message is tracked in https://github.com/odota/web/issues/3133

Also put in a fix for the showing matches to logged in users, but haven't tested it directly since my own account is not private

Doesn't look like it.

Tried another fix (web client wasn't passing login info)

Made some more fixes for recentMatches--should work again!
As for the storing all data for players, we have not made that change yet. It requires some more planning around how we store the data. So for now, if you want to have data available, you will need to make your profile public temporarily, request a refresh, and then turn it off again.


throttle group sensor updates

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 97.989%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
3070

Relevant Lines:
3133

💛  - Coveralls


Add SFTP input + output

Here is code for adding an input for files that are on an SFTP server. There is an option for processing an individual file or all files within a directory. I followed what was done for the Azure Blob Storage input, thanks @mihaitodor for all the help with this!
Also, have an SFTP test file that has tests that are being skipped. Initially I just removed it since it causes drone tests to fail due to using dockertest, but added it back with skips since I think it could be helpful for testing new features or changes. Although I wouldn't mind removing it if it's not necessary or helpful.
Closes: #539

@Jeffail Thanks for the feedback, I think I have covered all of your comments with my latest changes.
Mainly, I reworked the SFTP input so that it looks more like the file input instead of the Azure blob one.

@Jeffail Thanks for the feedback, I think I have covered all of your comments with my latest changes.
Mainly, I reworked the SFTP input so that it looks more like the file input instead of the Azure blob one.

Looks good, thanks @nmbryant! Just a heads up that I might make a few tweaks to some of the field defaults.

Looks good, thanks @nmbryant! Just a heads up that I might make a few tweaks to some of the field defaults.


Sub-pattern: Image with caption changes needed for the Solutions page template

This epic contains links to the work needed to the Image with caption for the Solutions page template

This work will not be done.


Don't have contrib-dependencies

Currently, we can't build the luigi debian package. The reason is that
the requirements in setup.py is including dependencies that are for
packages that (at least should) belong to contrib.
I also removed requests as I didn't see it being used anywhere. The test
suite should reveal if it was required or not. :)

LGTM, let's merge


Refactor vulncheck's Eval() to address high cyclomatic complexity

Fixes https://github.com/stacklok/minder/issues/1438

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Greg Furman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Audio Event and Background Music event update

Should fix #211 and #151

I found some bugs if you really want to mess with them. But for what it's worth I'll approve it as is and then if someone really wants to break them they can create the bug reports.
The only thing I would like changed is that they are open by default when you create them (like the text events) right now it seems weird that when you create an event you have to open it as well to start editing

@coppolaemilio You are right that is annoying. I did this because I found it annoying to have them be unfolded on default (when you open a timeline), because they just make it longer. I wanted to find out wether I can just open it when it's newly created, but didn't finish it. What do you think?
Do you like to be more specific about the bugs? Do you mean the problem if you delete the audio bus?

Ideally it should be like this anyway:

so even if it is closed you get the most important part of the editor, and if you want the extra options you can open it.

Do you like to be more specific about the bugs? Do you mean the problem if you delete the audio bus?

It wasn't about the audio buses (didn't test it too much) It was regarding the order of the events. Like, if you create an event with background music 2s fadeout and the next event is another song with 0s fade, you will hear some weird things happening and the first event will "prevail". But again, I don't know why would anyone do that 🤷🏻♂

Okay I updated it so that they are open by default.


Lumigo Injector container running as root in pod that disallows it

Warning  Failed            1s (x5 over 46s)  kubelet            Error: container has runAsNonRoot and image will run as root (pod: "test-app-594fc9665c-nm5rc_test-app(70735e7e-b84a-453e-af66-64a9e3cbd420)", container: lumigo-injector)

Injector container should run not as root if hosting pod is not running as root.

We should also ensure that, if FSGroup is set, the Injector containers runs with the same group (and is therefore able to write to the shared emptyDir).


[VL] Updated documentation, refactoring and added more testcases for BNLJ

What changes were proposed in this pull request?

Updated documentation for CartesianProduct and BroadcastNestedLoopJoin
Added fallback test cases for BNLJ
Renamed methods in BroadcastApi to generic names since it is being used for both HashedBroadcastMode as well as IdentityBroadcastMode (discussed here)

How was this patch tested?
Tested using unit tests

CC: @zhouyuan @zhztheplayer

@zhztheplayer Thank you for the review!
can you please tell, how can I rerun failed run for "centos7"?

@Surbhi-Vijay many thanks for your big help on this feature!

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4782_time.csv
log/native_master_03_06_2024_bddc3fd79_time.csv
difference
percentage

q1
35.04
38.77
3.735
110.66%

q2
22.35
24.36
2.006
108.98%

q3
38.06
39.60
1.543
104.05%

q4
37.74
37.58
-0.160
99.58%

q5
71.79
69.92
-1.865
97.40%

q6
5.56
8.34
2.773
149.85%

q7
84.70
84.40
-0.308
99.64%

q8
85.32
86.73
1.416
101.66%

q9
125.52
119.49
-6.033
95.19%

q10
44.57
43.18
-1.388
96.88%

q11
20.79
20.86
0.075
100.36%

q12
22.29
28.05
5.758
125.83%

q13
46.72
44.55
-2.176
95.34%

q14
23.74
17.03
-6.708
71.74%

q15
29.29
28.15
-1.141
96.10%

q16
14.15
14.07
-0.077
99.45%

q17
102.30
101.46
-0.839
99.18%

q18
144.07
145.26
1.196
100.83%

q19
12.62
13.99
1.365
110.82%

q20
27.61
28.21
0.610
102.21%

q21
225.61
224.18
-1.423
99.37%

q22
14.75
14.99
0.238
101.61%

total
1234.58
1233.17
-1.403
99.89%


Add disk usage info to the status page

Mind posting a screenshot of the final hackathon result?

This is currently blocked by a needed API change in the store interface, so I'm going to close it for now.


Adding static methods should not be breaking

I believe adding a static method to a class should not be a breaking change. Maybe, I'm missing something and it is breaking, but I can't come up with an example.
Discovered on:

https://github.com/dart-lang/native/pull/1322#issuecomment-2225001307

P.S. Thanks for a great tool! ❤

I agree! Will fix that


Add files via upload

Thank you for your PR!
Unfortunately a solution similar to yours has already been submitted :/
The goal is to find creative/abstract new solutions to FizzBuzz.
See The top 5 samples here.
Thanks anyway! :)


Bump fabric-protos-go dependency

Pickup new version of hyperledger/fabric-protos-go.
There appear to be issues with hyperledger/fabric-chaincode-go in master.

Looks like the fabric-chaincode-go dependencies may not be ready yet. Looking...

Opened FAB-17376 for the flake in etcdraft.

/ci-run

/ci-run


The lib symlink doesn't work on Windows

in src/main there is a lib symlink that points to ../../libbut I found that doesn't work on Windows. The compiler will complain that lib/setImmediate/setImmediate.js not found.
To workaround it, I deleted the original lib file and run mklink lib ..\..\lib in that folder, creating a Windows symlink and it worked

thanks for the heads up.  I didn't want to mix haxe/js source dirs, but it looks like that may need to happen.

What about extraParams.hxml?


Can I use MARLlib in my custom environment?

Hello there, I'm really impressed with the work that your project has accomplished so far. However, I noticed that it seems to only support the 15 environments that are currently mentioned in the readme and guide.  I'm interested in using your framework for my work and I'm wondering if it would be possible to implement support for additional or custom environments. Alternatively, would it be something that you plan to include in your future work?

Thank you for your interest. One of the main features of MARLlib is its support for new environments. You can refer to the example in the MARLlib repository, which demonstrates how to incorporate new environments into the library.


Issue with Azure AD metadata import in linux based system with Tomcat as application server

Reference:
https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/configure-federated-single-sign-on-non-gallery-applications
Facing issue while importing SAML SSO Azure AD IDP metadata in SP (Linux based system. Tomcat as application server).
Error:
SignatureValidationFilter      : Signature trust establishment failed for metadata entry https://sts.windows.net/XXXXXXXXXX.
We also have added certificate to java key store but still having signature trust establishment error.
When we are modifying setMetadataTrustCheck to false SSO is working.
How can we work it with setMetaDataTrustCheck to true?
Also what is the significance of setMetadataTrustCheck ?
Can anyone please help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05a5938f-9900-7728-3a10-7eef686b1dd0
Version Independent ID: c36ef90a-df18-efa1-02f7-321c22b2574a
Content: How to configure federated single sign-on for a non-gallery app
Content Source: articles/active-directory/manage-apps/configure-federated-single-sign-on-non-gallery-applications.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@AmitavaHazra Thank you for your query . We use github for documentation improvement . The guidance on the page is generic guidance for any type of non-gallery application . The issue you have described would require troubleshooting and I would suggest you to open a thread on Microsoft QnA for troubleshooting issues unrelated to bugs in the azure documentation and we will help you get it answered there. Azure-docs repo is mainly for issues within the documentation itself. hence we will be closing this issue here and request you to open a new thread on Microsoft QnA .

@shashishailaj,
the below link for Microsoft QnA is not working.
request you to open a new thread on Microsoft QnA .

I have got link . Thanks.

@AmitavaHazra My apologies . I have corrected the link . https://docs.microsoft.com/answers/index.html . I saw your link on QnA . https://docs.microsoft.com/en-us/answers/questions/42146/index.html . Please allow us some time and we will try to find the reason for the same . Thank you.

Thanks shashi. I will be waiting for your reply over there.


Small improvements

Change logic to remove partially redundant line
Function pointer instead of two conditional loops

Please break this apart into distinct PRs that can be discussed individually.
As stated in our contributing guide:
"Issue 1 Pull Request per feature. Don't lump unrelated changes together."


[SPARK-18667][PySpark][SQL] Change the way to group row in BatchEvalPythonExec so input_file_name function can work with UDF in pyspark

What changes were proposed in this pull request?
input_file_name doesn't return filename when working with UDF in PySpark. An example shows the problem:
from pyspark.sql.functions import *
from pyspark.sql.types import *

def filename(path):
    return path

sourceFile = udf(filename, StringType())
spark.read.json("tmp.json").select(sourceFile(input_file_name())).show()

+---------------------------+
|filename(input_file_name())|
+---------------------------+
|                           |
+---------------------------+

The cause of this issue is, we group rows in BatchEvalPythonExec for batching processing of PythonUDF. Currently we group rows first and then evaluate expressions on the rows. If the data is less than the required number of rows for a group, the iterator will be consumed to the end before the evaluation. However, once the iterator reaches the end, we will unset input filename. So the input_file_name expression can't return correct filename.
This patch fixes the approach to group the batch of rows. We evaluate the expression first and then group evaluated results to batch.
How was this patch tested?
Added unit test to PySpark.
Please review http://spark.apache.org/contributing.html before opening a pull request.

cc @davies

Test build #69549 has started for PR 16115 at commit 7cd606b.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69549/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Test build #69553 has started for PR 16115 at commit 7cd606b.

Test build #69553 has finished for PR 16115 at commit 7cd606b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69553/
Test FAILed.

Test build #69563 has started for PR 16115 at commit 8b0ef1e.

Test build #69563 has finished for PR 16115 at commit 8b0ef1e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69563/
Test PASSed.

Merged build finished. Test PASSed.

cc @cloud-fan @hvanhovell too

ping @davies again

good catch! Merging to master/2.1, thanks!


Question: setting up multiple assets folders?

Hi, I'm sorry if this isn't the right place to ask, but there is any easy way of working with multiple assets folders? I tried to work around this by placing some subfolders in the assets directory, but whatever i put there doesn't get copied.
So, is there any easy way of working with multiple assets?

everything inside app/assets, or any other directory which is named as assets (e.g. app/styles/components/assets should get copied to the public dir.
What path is not getting copied for you? Which brunch / node / npm ver are you on?

Think I answered you on Stack Overflow.


Streamline release process

(e.g. via goreleaser)

Decided not to go with goreleaser, but I've built build.sh and that's been working well. Added in v0.2.0.


[WIP] Add basic information for kperf measurement result (#35)

As https://github.com/knative-sandbox/kperf/issues/35 mentioned, add basic information for measurement result such as the version of knative, start and end time .....

[ ] Show them in measurement output:

-------- Measurement --------
Basic Information:
  - Versions:
    Serving: v0.20.0
    Eventing: v0.20.0
Total: 2 | Ready: 2 NotReady: 0 NotFound: 0 Fail: 0
Service Configuration Duration:
Total: 49.000000s
Average: 24.500000s
.........

[ ] Show them in HTML
[ ] Store them in JSON file

@gyohuangxin as we discussed, would you please also add Knative ingress controller solution, using istio/kourier/xxx and its version. Thanks!

@gyohuangxin as we discussed, would you please also add Knative ingress controller solution, using istio/kourier/xxx and its version. Thanks!

Sure, but is there a uniform ways to get ingress controller info for kperf? Thanks.

@gyohuangxin you can refer to this ConfigMap to decide the ingress controller
kubectl get configmap/config-network --namespace knative-serving

by default, it is istio
    ingress.class: "istio.ingress.networking.knative.dev"

if Knative is using other options, like Kourier
 '{"data":{"ingress.class":"kourier.ingress.networking.knative.dev"}}'

@zhanggbj Thank you!

@zhanggbj Hi, ingress controller solution can be shown using above way. However, how can I get their version through knative?
I can only get istio version from this configmap in istio owned namespace kubectl get cm istio -n istio-system -oyaml

@gyohuangxin
For the first step, wo do not need to cover all the networking solutions. For now, kperf only support Istio.
So 1) If it is using Istio, get version from istio deployment labels in istio-system. (Or any func in istio client can get the version?)

If it is using other options, just put version as an Unknown, we can update this step by step after kperf started to support other options.

@zhanggbj Thanks for your reply. Now, get the ingress solution from the config maps "config-network" data.ingress.class in namespace "knative-serving", and then

If it is using Istio, get version from istio deployment labels in istio-system.

-------- Measurement --------
Basic Information:
  Start Time: 2021-03-02 15:22:43
  End Time: 2021-03-02 15:22:48
  - Knative Versions:
    Serving: 0.20.0
    Eventing: 0.20.0
  - Ingress Information:
    Controller: Istio
    Version: 1.7.3
Total: 18 | Ready: 2 NotReady: 16 NotFound: 0 Fail: 0

If it is using other options, just put version as an Unknown

-------- Measurement --------
Basic Information:
  Start Time: 2021-03-02 15:30:11
  End Time: 2021-03-02 15:30:21
  - Knative Versions:
    Serving: 0.20.0
    Eventing: 0.20.0
  - Ingress Information:
    Controller: Unknown
    Version: Unknown
Total: 18 | Ready: 18 NotReady: 0 NotFound: 0 Fail: 0

@gyohuangxin Generally looks good! just left some minor comments. thanks!

@zhanggbj @maximilien
Now the measurement result is shown as:
-------- Measurement --------
Basic Information:
  - Knative Versions:
    Serving: 0.20.0
    Eventing: 0.20.0
  - Ingress Information:
    Controller: Istio
    Version: 1.7.3
Total: 18 | Ready: 18 NotReady: 0 NotFound: 0 Fail: 0

And I think it's better to open another PR to store results in JSON files and show them in HTML.
So remove the WIP label and could you have a review again? thanks!

@gyohuangxin Thanks for the PR! LGTM.
Please open another issue for the dashboard, and perhaps tag Yajiao if needed. Thanks!


Revert removed handleTap and handleLongPress methods

This resolves issue #432.

@johnpryan ?

Moved to #436, closing.


[mtl] Lazier vertex buffer binding

This is a follow-up to #2078, which fixes an issue where a vertex buffer wouldn't be bound upon switching the PSO after binding vertices.
PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends: metal

Thanks!
Bors r=grovesNL

On May 31, 2018, at 00:14, Josh Groves<EMAIL_ADDRESS>wrote:
@grovesNL approved this pull request.
Seems reasonable to me 👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Client transmits sender's IP

Emails sent from the Whiteout client reveal the sender's IP, the mail/mx.wmail.io servers preserve it in the headers.
Even mainstream services are now supressing sender IP (Gmail, FastMail) when using their web client.

Gmail still seems to show the client-ip. What do you mean they are suppressing the sender IP?

This isn't Whiteout adding your IP, it's the mail server. Nearly every SMTP server adds an X-Originating-IP; it goes unnoticed because it won't be added if you use the web mail interface. Try using Thunderbird or any other mail client and you'll see the same issue.
The only free SMTP servers I know that don't add X-Originating-IP are wmail.io and riseup.net.
Return-Path<EMAIL_ADDRESS>X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on spoonbill.riseup.net
X-Spam-Level: *
X-Spam-Pyzor:
X-Spam-Status: No, score=1.1 required=11.0 tests=AM_TRUNCATED,DKIM_SIGNED,
    DKIM_VALID,DKIM_VALID_AU,FORWARD_RELAY,FROM_ALMOST_TO,NEAR_EMPTY,
    RCVD_IN_BL_SPAMCOP_NET,T_RP_MATCHES_RCVD shortcircuit=no autolearn=disabled
    version=3.4.0
Delivered-To<EMAIL_ADDRESS>Received: from mx1.riseup.net (mx1-pn.riseup.net [<IP_ADDRESS>])
    (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
    (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
    by spoonbill.riseup.net (Postfix) with ESMTPS id 0B069F4
    for<EMAIL_ADDRESS>Thu, 10 Dec 2015 05:06:45 -0800 (PST)
Received: from mail.wmail.io (mail.wmail.io [<IP_ADDRESS>])
    (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
    (Client did not present a certificate)
    by mx1.riseup.net (Postfix) with ESMTPS id 31EC01A1E75
    for<EMAIL_ADDRESS>Thu, 10 Dec 2015 05:06:44 -0800 (PST)
Authentication-Results: mx1.riseup.net; dkim=permerror
    reason="verification error: signature timestamp in the future"
    header.d=wmail.io<EMAIL_ADDRESS>header.b=RVlvMEbJ;
    dkim-adsp=none (unprotected policy); dkim-atps=neutral
Received: from mx.wmail.io (mx.wmail.io [<IP_ADDRESS>])
    by mail.wmail.io (Postfix) with ESMTPSA id DEB053F8A9
    for<EMAIL_ADDRESS>Thu, 10 Dec 2015 13:17:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wmail.io; s=mail;
    t=1449753479; bh=2I87ZOF4NKM9Wqwf4GAFvHrWsLLF93qKkwDCClfxLT4=;
    h=Subject:From:To:Date:From;
    b=RVlvMEbJUfOGysc3vQJp85uDIbJob+zHVpVvQNe3PeAh/fpKrYfqBrpSzlHPk1IuU
    YkxMr3jxhj9Ja0V62tXh5JAquHbnhVNxi/gpmL+NOXyUDueXgBb4DP+vFxh+V76NCl
    4kHtKhJwjhd8+iIj9dfjwCQXSbU6wht5nx9KVWIU=
Received: from <IP_ADDRESS> by mx.wmail.io with SMTP; Thu, 10 Dec 2015 13:13:13 +0000 (UTC)
Content-Type: multipart/encrypted; protocol="application/pgp-encrypted";
    boundary="----sinikael-?=_1-14497527654640.9497128049843013"
Content-Description: OpenPGP encrypted message
Content-Transfer-Encoding: 7bit
Subject: Test
From: David Manouchehri<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Date: Thu, 10 Dec 2015 13:06:05 +0000
Message-Id<EMAIL_ADDRESS>MIME-Version: 1.0
X-Virus-Scanned: clamav-milter 0.98.7 at mx1.riseup.net
X-Virus-Status: Clean


skipEmptyLines support for string type

Pull Request Test Coverage Report for Build 60

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.931%

Totals

Change from base Build 42:
0.0%

Covered Lines:
46

Relevant Lines:
50

💛  - Coveralls


Updates to Code Dx GitHub Action

Jira:

Support specifying analysis branch
Renaming Code Dx -> SRM
Allow specifying project name rather than id (pending)

This PR aims to make few updates to the existing Code Dx GitHub Action, allowing for:

Specifying branches for analysis: See Tyler's comment for explanation.
Renaming instances of Code Dx -> SRM, mainly in log outputs, references and file names.
Allow specifying project name: Currently, we can only pass projectId (integer) to start the analysis. This should allow for specifying the project name as well. (pending)

Added two new config options for specifying branch parameters:

base-branch-name (baseBranchName): Used to specify the parent branch of the target. Useful in cases where the target branch is a new child branch that has to be created from an existing parent.
target-branch-name (targetBranchName): Used to specify the target branch for the analysis. If not specified, it will assume the default branch. If it is a new branch, a parent branch has to be specified to create the new target branch.

Added a new config option: project-name, which can be used to choose the SRM project by name. We would expect either of project-id or project-name to be specified in the config; an error will be thrown if both or neither are specified.
Also, if multiple projects with the same name are found, then an error is thrown since it is unclear which project the user would want.


qtd. in references

Find a solution for when a definition is quoted in another source. For example: Adelung's 1786 definition for text was quoted in the source hay_does_1998. So the definition is Adelung's, but we've only been able to consult the quoted version in Hay's essay.
To preserve all the necessary information, I have given text_1786_adelung.md (and similar qtd. in defs) the following front matter:
source: adelung_versuch_1786
page: n.p.
qtd_in: hay_does_1998
qtd_in_page: 65

(n.p. here stands for "no page" because Hay neglected to specify where he found the quote in Adelung's text).
In the end,  the reference should read: (Adelung 1786, n.p.; qtd.  in Hay 1998, 65).
To my knowledge, jekyll-scholar doesn't provide a simple solution to solve this problem.

I have tried it with the following Liquid if statement in _layouts/definition.html, but it doesn't work yet:
{% if page.qtd_in%}; {% cite page.qtd_in %} p{{ page.qtd_in_page}} {% endif %}

fixed this using jekyl-scholar's {% bibliography %} tag while redesigning the structure of the lemmas in the lexicon.


How to find the end of audio response ?

I want to know the end of audio response(audio out) to start a new session.
Use case:
User : Set alarm
Response : what time ?
User : 6:30
Response : Ok,Setting alarm to 6:30
For this case, i need to know audio finish status after the response "what time ?" to start new session.
Kindly help .

You can listen to the Converse Response event END OF UTTERANCE.
On Aug 4, 2017 2:42 AM, "Ranjith1992"<EMAIL_ADDRESS>wrote:

I want to know the end of audio response(audio out) to start a new session.
Use case:
User : Set alarm
Response : what time ?
User : 6:30
Response : Ok,Setting alarm to 6:30
For this case, i need to know audio finish status after the response "what
time ?" to start new session.
Kindly help .
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/androidthings/sample-googleassistant/issues/36, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADI587e2e7Ql6ouDPDwb0m9FD6I3TWssks5sUst3gaJpZM4OtYkE
.

Maybe we could update the sample to listen for END_OF_UTTERANCE?

Yeah definitely working on it
On Aug 9, 2017 5:08 AM, "Johan Euphrosine"<EMAIL_ADDRESS>wrote:
Maybe we could update the sample to listen for END_OF_UTTERANCE?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/androidthings/sample-googleassistant/issues/36#issuecomment-321236569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADI58xna8ZvSjqDK1Jc1iFmNeIvaYpzUks5sWaFLgaJpZM4OtYkE
.


Improve CosSinNumericalEncoder (part 2)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (15ebaae) to head (1d6197d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #355   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          101       101
  Lines         3218      3235   +17
  Branches       283       283
=========================================
+ Hits          3218      3235   +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


AAC-263 Upgrade to Ruby 3

What
Upgrade to Ruby 3 (3.0.3) from 2.7.2
Ticket
AAC-263
Why
Answer to why can be found here
How
Update the dockerfile, circleci config, .ruby-version and Gemfile to use ruby 3.0.3
Run bundle which also upgrades some gems and specifies that the Gemfile.lock was upgraded with ruby 3.0.3
(Devs will notice an error when trying to run rails server, which should lead them to upgrading their local bundler version)
To note:
You may need to update your bundler to 2.2.3 with gem install bundler:2.2.3

Approved the additional changes made by @pking-moj


Add imagePullSecretes to the Helm chart

Signed-off-by: Armin<EMAIL_ADDRESS>What this PR does / why we need it:
Adding the imagePullSecrets to the Helm deployments to allow authenticated Docker registries.
It replaces #211

/azp run pr-e2e-azure


express js and mongodb

linter issues are coming for minified js files which we can ignore

linter issues are coming for minified js files which we can ignore


Fix compatibility with rspec-puppet 4+

These settings where used for compatibility with Puppet 7.10 and older
(Puppet 7.10 was released more than 2 years ago).  rspec-puppet 4
removed them:
https://github.com/puppetlabs/rspec-puppet/pull/73
In order to avoid this kind of accident in the future, add an upper
bound on the rspec-puppet dependency.  Version 5.0.0 is also working
with this change, so accept anything before 6.0.0.

CI is still failing because it depends on this to be merged:
https://github.com/dylanratcliffe/puppet_controlrepo/pull/21

Thanks for this @smortex! I ended up fixing this in a larger upgrade effort but thanks for the tips