Rename CommunicationTurnCredentialsResponse to CommunicationRelayConf…

…iguration
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[X] Other, please clarify

Rename of a model

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[X] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@ajpeacock0 was this breaking change approved, or is this the case where the swagger doesn't match what's on the wire?

@ajpeacock0 was this breaking change approved, or is this the case where the swagger doesn't match what's on the wire?

I don't believe this is classified as a breaking change, since the request/response contract between the client and server doesn't change. If a model field was renamed (e.g. turnServers) that would change the request/response contract and be a breaking change.
Even if this was a breaking change, since we're in Private Preview, what approval would be needed?

It's a breaking change from an SDK perspective as the type name returned from the API has changed.
@johanste can you review this?

As long as we haven't shipped a GA library based on the swagger, this change is fine.

It's a breaking change from an SDK perspective as the name of the type returned from the API has changed.
@johanste can you review this?

If it's the SDK that we're referring to as a breaking change, we currently have a directive renaming "CommunicationTurnCredentialsResponse" model to "CommunicationRelayConfiguration" for our .NET SDK and our JS SDK so this just aligns the swagger with the SDKs.
Sorry for not making that clear earlier

/azp run


Add steps to form

Upon entering the car car mileage should be checked.

duplicate of https://github.com/CodeForPoznan/pah-fm/issues/159


Change cursor to multi-selection cursor when selecting text in Console

Godot version:
3.1
Issue description:
Selecting text inside the Console in the editor doesn't change the cursor from the regular pointer to a multi-selection cursor.
Steps to reproduce:
select the text inside the Console that is in the editor.
Example of expected behaviour:

Console is just a RichTextLabel, so this functionality could be added to all labels (as an option).

@KoBeWi Not all RichTextLabels are selectable, and it might not make sense for all selectable RichTextLabels (where you don't need to copy text often).

That's why I said as an option. It just shouldn't be exclusive to console.

@KoBeWi There's already an option to use a different cursor when hovering the RichTextLabel :slightly_smiling_face:
Let's not add more options than we actually need, otherwise the inspector would end up showing a lot of properties most people won't change.

Ah, I didn't know that xd
This makes the issue trivial to fix.

@KoBeWi ping

ping

Why tho?

Oh, I was checking on some old issues for a friend. I thought you wanted to work on it.

I just said that it should be easy to do and wanted to leave it for new contributors. It's not important to fix, so it can stay for a while longer.
(also, if I wanted to work on it then, it would be fixed on the same day xd)

Hello, I'm new into both GitHub & Godot contributing, and I've come with a very simple solution to this bug (see below) but I'm not sure whether or not it handles every possible case.
Control::CursorShape RichTextLabel::get_cursor_shape(const Point2 &p_pos) const {
       if (!underline_meta)
                return CURSOR_ARROW;
       if (selection.click)
               return CURSOR_IBEAM;
      ...
      return CURSOR_ARROW;
}

Can you format your changes into a pull request and then we can code review it?

Done !


issue deploy in production mode

The deploy in productionmode cause layouting issues.
The layout is completely destroyed.
maven profile: production-mode

Please update the issue description to match the bug issue template.

I was able to reproduce your issue on Version 2.0.7, using plain Jetty.
Thanks for reporting, but please consider next time providing a proper issue description to give the maintainer more to work with.

Ok sorry for that.
Thank for fixing!


Chess board not responsive & has a fixed width/height

Hey, thanks for all the work you've done here, I'm having fun implementing https://dailychess.club and want it to work on mobile.
Seems like the board has a fixed width and height of 560px and setting it to anything else doesn't seem to allow it to take 100% of the width of the viewport. I'm not finding any option to allow it to be responsive.
What's your opinion on the matter? Are you able to make it responsive for mobile phones on your end?
Thanks !

https://github.com/Clariity/react-chessboard/blob/6e4857359c648911647bdd10fa0bdb64c2955d63/example/src/index.js#L16
Please read the docs and the examples for how to set the chessboard size and make it responsive

That's on me for not seeing this option in the docs. But given most people will have to implement responsiveness, do you think it's worth it to add a bullet point in the "NOTES" or maybe an example in the docs?
Thanks again

I'm currently working on version 2 which will come with some upgrades such as the board being responsive out the box, written entirely in typescript and adding storybook. This should help to clear up any confusion as I know the current implementation isn't ideal

v2 is now released: https://github.com/Clariity/react-chessboard/releases/tag/v2.0.7
Docs at https://react-chessboard.com


Environment listing page is not performing refetch after creating a new environment

What happened:
After creating a new environment, the listing page is not showing the latest environment. Have to refresh the page to get the latest data.
What you expected to happen:
After environment is created listEnvironments API to get prefetched and update the page automatically upon successful creation of the env.
Where can this issue be corrected? (optional)

How to reproduce it (as minimally and precisely as possible):
Create a new environment and check after closing the modal, the latest is not listed, will have to refresh the page.
Anything else we need to know?:

just curious! Would putting the API call in a useEffect hook solve this bug?


Reimplement using entity id based storage

Currently ecsalator stores the data on a component-based storage.
{
  componentA: {
    1: { ... },
    2: { ... }
  },
  ...
}

However, it might be better to store the data on a entity id based storage.
{
  1: {
    componentA: { ... }
  },
  2: {
    componentB: { ... }
  }
}

There are pros and cons, so we would need to decide what to use.

This will be solved after refactoring the code.


[Question] Why called XService at API side when you can call it XRepository?

hi Guys,
Why named XService at API side when you can name it XRepository since it interact with DBContext/Database?
I understand the client side XService naming.
I am just curious?
Cheers

A Repository is essentially a facade for persistence that uses Collection style semantics (Add, Update, Remove) to supply access to data/objects. It is a way of decoupling the way you store data/objects from the rest of the application.
A service supplies coordination or other "services" that are required to operate your application. They are very different in that Services don't typically know how to access data from persistence, and repositories typically only access data/objects for any services you may have.


chore(master): release 1.1.143

:robot: I have created a release beep boop
1.1.143 (2023-08-06)
Miscellaneous

deps: update dependency secretlint to v7.0.6 (383243e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/keywind/releases/tag/v1.1.143 :sunflower:


Introduce parsing positional arguments

Added positional_argument.proto and make it build via proto_library
rule in the stout/v1/BUILD.bazel.

Closing in favor of #53.


fix: Content and button are not visible in svg option

Describe the bug
In Simulator for converting the diagram to svg the buttons and contents are not visible like png,jpeg,bmp,gif
To Reproduce
Steps to reproduce the behavior:

Go to 'https://circuitverse.org/simulator'
Click on 'Download as image'

Click on SVG option
See error

Expected behavior

Screenshots

Device Information [optional]:

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
You can check from your side maybe this is from my side
Are you working on this issue? (Yes)

This is a main simulator issue and is not present in the vue simualtor.

where should i raise this issue ??

closing this issue


Too slow

After I downloaded and installed all the dependencies, I run python app.py, but it just sits there and do nothing, not even after 30 minutes. What could be going on?

It seems that the first time you run it, it takes a while.

Is it working for you?

The issue is resolved now.


[$500] Distance - Map does not zoom in when Start location is in San Francisco

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.5-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Precondition: Location access is not allowed, so that the default view is San Francisco.

Go to staging.new.expensify.com.
Go to workspace chat > Request money > Distance.
Click Start.
Enter an address in San Francisco area (e.g. 88 Kearny Street, San Francisco, CA 94104, USA) and save it.

Expected Result:
The map will zoom in to show the location.
Actual Result:
The map does not zoom in to show the location. This issue does not happen with other addresses that are not in San Francisco.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Uploading Bug6295845_1701344089583!bandicam_2023-11-30_10-41-37-305__1_.mp4…

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b7ddc9c68ed1ff3c
Upwork Job ID:<PHONE_NUMBER>851979776
Last Price Increase: 2023-12-07

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01606e11baa8e9dce3
The issue you're facing with the map in your React Native application is related to the zoom level and the initial region. The problem is that the map is not zooming in when the start location is in San Francisco. To solve this issue, you can adjust the latitudeDelta and longitudeDelta values in the initialRegion object. Here's a step-by-step guide to address the issue:
Identify the initialRegion object in your code. It should look something like this:
javascript
const initialRegion = {
latitude: 37.78825,
longitude: -122.4324,
latitudeDelta: 0.0922,
longitudeDelta: 0.0421,
};
Adjust the latitudeDelta and longitudeDelta values to better suit your needs. For example, you can decrease the latitudeDelta and longitudeDelta values to zoom in more closely:
javascript
const initialRegion = {
latitude: 37.78825,
longitude: -122.4324,
latitudeDelta: 0.042,
longitudeDelta: 0.042,
};
Update the map view in your component to use the adjusted initialRegion object:
javascript
<MapView
style={styles.map}
initialRegion={initialRegion}
onRegionChangeComplete={(region) => {
// Your code to handle region change
}}
/>
By adjusting the latitudeDelta and longitudeDelta values, you can control the initial zoom level and center of the map. Make sure to experiment with these values to find the optimal configuration for your application.
Thank you.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~017143740211b6ca21

Contributor details
Your Expensify Account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~011ac332a8ff6c74da
Here is technical solution to address the issues of the map not zooming in when the start location is in San Francisco in React Native Project.
const handleStartLocation = (location) => {
if (location === 'San Francisco') {
const region = {
latitude: 37.7749,
longitude: -122.4194,
latitudeDelta: 0.1,
longitudeDelta: 0.1,
};
mapRef.current.animateToRegion(region, 1000); // Adjust duration as needed
}
};
I hope to work with your company. I can start working immediately.
Best Wishes, Timofii

Not overdue

@eVoloshchak could you review the proposals above? This is still reproducible

@rojiphil is correct, this happens because SF is a default address, so when you select SF as a waypoint, the map doesn't move/zoom, since it's already displaying the correct location
However, there is an inconsistency between native and web: web/mWeb doesn't zoom In when you select a waypoint, while native platforms do (that's why it appears that only web has this issue). Setting higher zoom value as @shubham1206agra is suggesting will resolve both this issue and the inconsistency between mWeb and native platforms, I think we should proceed with the proposal

@rojiphil is correct, this happens because SF is a default address, so when you select SF as a waypoint, the map doesn't move/zoom, since it's already displaying the correct location
However, there is an inconsistency between native and web: web/mWeb doesn't zoom In when you select a waypoint, while native platforms do (that's why it appears that only web has this issue). Setting higher zoom value as @shubham1206agra is suggesting will resolve both this issue and the inconsistency between mWeb and native platforms, I think we should proceed with the proposal
🎀👀🎀 C+ reviewed!

@eVoloshchak
The approved proposal is suggesting to keep 10 or 15 across all platforms. I think that does not solve the problem. Also, the proposal seems vague.
As per my proposal, I suggest to keep the zoom level to 10 initially and change it to 15 when there is at least one waypoint.
Isn’t this better?

@eVoloshchak @luacmartins
The approved proposal is suggesting to keep 10 or 15 across all platforms. I think that does not solve the problem. Also, the proposal seems vague. The proposal was updated with the zoom value of 15 only after my proposal came up. Please check the history.
I was the first to suggest keeping the zoom level to 10 initially and changing it to 15 when there is at least one waypoint.

@eVoloshchak @luacmartins
The approved proposal was suggesting to keep zoom level of 10 or 15 across all platforms. I think that does not solve the problem. Also, the proposal seems vague. The proposal was updated with the zoom value of 15 only after my proposal. As shown below, the attached screenshots show the relevant edit timestamps and changes.
I was the first one to suggest keeping the zoom level to 10 initially and changing it to 15 when there is at least one waypoint.

This is a minor comment. I suggested making it consistent and updating the comment to show the preferred zoom.

@shubham1206agra

Make the zoom the same, i.e., make them 15 or 10, across all platforms.

As I understand, your original proposal mentions making them 15 or 10.
Can you please explain how making it 10 solves the problem?

@shubham1206agra

Make the zoom the same, i.e., make them 15 or 10, across all platforms.

As I understand, your original proposal mentions making them 15 or 10. Can you please explain how making it 10 solves the problem?

Making it 10 on the native platform would solve the visual inconsistency across platforms, which is why this issue was raised.
@rojiphil How does saying 15 only would make your proposal different from mine?

@shubham1206agra

Making it 10 on the native platform would solve the visual inconsistency across platforms, which is why this issue was raised.
@rojiphil How does saying 15 only would make your proposal different from mine?

First of all, I think we have a different understanding of the problem itself. As I understand, this issue was not raised to solve the visual inconsistency problem across platforms. The problem statement states that map does not zoom in. And that I think is the problem.
No wonder we differed from the RCA perspective too. Your RCA stressed on visual inconsistency across platforms and my RCA stressed on the need of increasing the zoom level on web platforms.
Your proposed solution to set the zoom level to 10 or 15 gels well with your RCA. However, setting 10 will not solve the problem here. We need to set it to 15 as per my proposal.
So, to me, it looks like your proposal is different from mine even from the RCA and the problem understanding perspective.

@eVoloshchak

@rojiphil is correct, this happens because SF is a default address, so when you select SF as a waypoint, the map doesn't move/zoom, since it's already displaying the correct location

Setting higher zoom value as @shubham1206agra is suggesting will resolve both this issue and the inconsistency between mWeb and native platforms

I think my proposal had the correct RCA. Not only that, I was the first one to suggest setting a higher zoom value as pointed out in my comment here.
So, I request you to please also consider this fact while approving the proposal.

This makes the zoom non-apparent in web platforms

@rojiphil I think you missed this line while claiming you only have the correct RCA here.

Not only that, I was the first one to suggest setting a higher zoom value as pointed out in my https://github.com/Expensify/App/issues/32261#issuecomment-1854471202.

This is factually incorrect. I also proposed the higher zoom, but left the leeway for zoom level 10 as we don't know why https://github.com/Expensify/App/pull/30506/files#r1426190110 was changed to 10 here.

@shubham1206agra

This is factually incorrect. I also proposed the higher zoom

I never claimed that you did not mention 15 in your proposal.
What I am simply pointing out is this:

Setting higher zoom value as @shubham1206agra is suggesting

I am not sure if it is fair to attribute the suggestion of higher zoom value to you as the phrase (preferably 15) was only added after my proposal. I think you were ok with both 10 and 15 until then.
I would leave it to @eVoloshchak to conclude on this.

I think I am just pointing out that adding clarification does not constitute a new proposal as I haven't changed the solution a little bit, just added some minor comments for clarity

I think we should proceed with @shubham1206agra's proposal as agreed and determined by @eVoloshchak.
There are lots of other places where contributions are needed, and your efforts are welcomed everywhere, so I don't think it is worth getting caught up in debating this issue when the next expected step in this process is a PR.
@shubham1206agra please can you raise your PR when you are ready. Thanks!

Sorry for the late reply, I agree with @0xmiroslav and @muttmuure above and we'll go with @shubham1206agra's proposal. Thanks everyone.

PR is ready

@eVoloshchak - $500 C+

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/30506
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30506/files#r1463933665
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, the bug is pretty minor

Regression Test Proposal

Make sure the location permissions are not granted
Go to any chat > Request money > Distance.
Click Start.
Enter an address in San Francisco area (or just San Francisco)
Verify the map zooms in

Do we agree 👍 or 👎

$500 approved for @eVoloshchak based on comment above.


What is the JSON I send supposed to look like?

Has it occurred to you lot that just by showing people the json we're supposed to send we could fix a lot of issues? I'm not a JavaScript expert and wouldn't really like to take a guess at what's supposed to be going on.
This is my Json
{   "results": [     "Chemie",      "Erziehungswissenschaften",      "Politikwissenschaften",      "Sprach- / Kulturwissenschaften",      "Informatik",      "Volkswirtschaftslehre",      "Physik",      "Geowissenschaften",      "Geschichte",      "Biologie",      "Philosophie",      "Sozialwissenschaften",      "Psychologie",      "Mathematik",      "Medien- / Kommunikationswissenschaften",      "Betriebswirtschaftslehre",      "Kunst / Musik"   ] }
Is it right or wrong?

I'll do the honours of providing the correct JSON format somewhere relevant to this project.
it is:
{     "results":[          {              "id":"X",              "text":"X"          },           {              "id":"Y",              "text":"Y"          },      ] }

The section in the docs for that is not yet written:
https://select2.github.io/options.html#what-should-the-results-returned-to-select2-look-like
But it's equivalent to the array data adapter format:
https://select2.github.io/options.html#data


[ansible] Patching an ansible operator creates two pods: one with new image without leader and a pod with old image

Bug Report

What did you do?
Patched an ansible operator (kiali-operator)
in order to update a tag with the following command oc patch deployment kiali-operator -n kiali-operator --type='merge' -p='{"spec":{"template": {"metadata": {"labels": {"app": "kiali-operator", "version": "latest"}}, "spec": { "containers": [{"name": "ansible", "command": ["/usr/local/bin/ao-logs", "/tmp/ansible-operator/runner", "stdout"], "image": "quay.io/kiali-qe/kiali-operator:latest", "imagePullPolicy": "Always", "volumeMounts":[{"mountPath": "/tmp/ansible-operator/runner", "name": "runner", "readOnly":   true }] }, {"name":"operator", "image": "quay.io/kiali-qe/kiali-operator:latest", "imagePullPolicy": "Always", "volumeMounts": [{"mountPath": "/tmp/ansible-operator/runner", "name": "runner"}], "env": [{"name": "WATCH_NAMESPACE", "value": ""}, {"name": "POD_NAME", "valueFrom": {"fieldRef": { "fieldPath": "metadata.name" }}}, {"name": "OPERATOR_NAME", "value": "kiali-operator"}]}]}}, "selector":{"matchLabels": {"app": "kiali-operator", "version": "latest"}}}}'
What did you expect to see?
One ansible operator container after the removal of the old
What did you see instead? Under which circumstances?
3 containers and eventually 2 containers (one container with old image and new one with new image but no leader key)
Environment

operator-sdk version: 0.8.1

go version: 1.17.1

Kubernetes version information: 1.13.4

Kubernetes cluster kind:

Are you writing your operator in ansible, helm, or go? ansible

Possible Solution

Additional context
Add any other context about the problem here.

Related #1736

cc @jmazittelli


Add testing for cron_manage.

Description
Adds testing for manage including kitchen configuration so that converting definition to resource has testing to match up.
Issues Resolved
Prep work for #62 (doesn't resolve it).
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Woot


[libunibreak] Add the missing header files

Fixes https://github.com/microsoft/vcpkg/issues/37669
Add a header file containing function ub_get_char_eaw_class().

[X] Changes comply with the maintainer guide.
[ ] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:
x64-windows

Thanks for the fix!


MultiFiltered Select

Description
The multi filtered select has 2 error for now:

On keeping it open it is getting scrollable, rather is should make tha page unscrollable .
It isn't allowing to collapse
Steps to reproduce
Test the component with above condition
Insert an image/gif

Hey @SySagar, I think the second issue you mentioned has been resolved in my PR #1265. Please check it once to see if you are referring to the same issue.

@SySagar pls tell how you setup and run this repo in your local machine

@AnshuPathak-88825 please converse in the community chat. Spamming in the pr is not advisable.


Fix race in setting controller namespace

Change Overview

Uses a well known namespace to run the controller
Delete/recreates the namespace at test startup

Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[x] :robot: Test

Test Plan
Fixes integration test

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Approved but added hold off tag so it didn't auto merge.  Remove when you want.


Restyling web

done style irecipe card, done grid event pages, done restyle banner recipe, restyling all pages, restyle profile card header, restyle grid profile recipes,

Nice,thanks li


[DNM][ownership] Move OME out of the diagnostics pipeline.

This moves ownership stripping out of the diagnostics pipeline.
At -Onone it now runs /after/ we serialize, but before we print SIL (this
ensures I can update tests in a subsequent PR).
At -O, to temporarily work around serialization issues with transparent
functions, we strip ownership from all but transparent functions at the
beginning of the performance pipeline, serialize, and then strip ownership from
transparent functions. For this to work, I needed to make sure that the
performance pipeline passes that do not support ownership SIL, just skip such
functions. So the transparent functions will arrive (mostly) untouched in
serialized SIL and the rest of the pipeline will optimize non-transparent
functions as they should.

NOTE: This is DNM since I need to benchmark still and fix one bug that I found running this offline.

I have been fixing this in different PRs.


Yet another issue about submodules

Hi,
Project: u-bmc
Error: https://readthedocs.org/projects/u-bmc/builds/8054931/
u-bmc uses submodules quite heavily and contains a lot of data. There is no earthly reason for readthedocs to check that out and I'd like to disable it.
I found some PRs and some other issues that talks about how this is possible, but I did not see any documentation about how to enable it for my own repo. Am I correct in assuming that:

There is a secret internal tag you set on projects for now to disable submodules?
There will be support in the upcoming v2 configuration, but there is not in the current v1?

If so, could I ask for the secret flag on u-bmc?
Thanks!

both, 1 and 2 are true. but I think there is something else causing the error, I'll investigate now

Sure thing! The build time has the suspicious number of 899 seconds, and I read you have a 900 seconds timeout, so if you start a betting pool you know where my bet is ;-).

So, yeah, it's failing on git submodule update --init --force --recursive u-boot linux

Hi again,
Just making sure this didn't fall between the metaphorical chairs. @stsewd , what's the next steps here?

Sorry, I almost forgot, not sure what to do here, but I'll ask the team. Some possibilities could be:

Wait to release config v2 (probably not the best solution because of the time)
Set a flag to use the alfa version of v2 (which include submodules settings, but the schema is open to changes, so you'll need to change that on the final release, and we don't have deployed docs)
Set the current magical flag (we are trying to not abuse of this because v2 is coming soon)

:+1: on just setting the feature flag for now, if you don't need any of the submodules for the project.

Sgtm! The submodules are just for building.

@bluecmd I added the flag to skip submodules checkout to your project.
I'm closing this issue here, but feel free to reopen if it doesn't work as you expected or give us feedback/update ;)
Thanks!


SQL start of / end of string syntax highlighting error

In SQL files, VSCode highlights the opening quote and the ending quote in different colours...and the ending quote the string value is also picked up as part of the scope—

Ideally, I'd like to style the quotes in a different colour than the string, but right now, the opening quote is grey, and the closing quote is the colour of the string itself. How can I solve this? Thanks!

I'm not seeing this happen anymore.


Why not re-export @nestia/fetcher types to avoid requiring the user to add it as a dependency?

Question
The @nestia/fetcher package's README mentions:

if you're a client developer who've installed an SDK library which has been generated by the @nestia/sdk, you also need to install this @nestia/fetcher module. With the IConnection and HttpError instances provided by this @nestia/fetcher, you can enjoy the SDK library much conveniently.

Why not just re-export the needed types (IConnection, HttpError, etc.) in the generated SDK code to avoid requiring the user to add it as a dependency?
And another question, why doesn't the SDK code generation just generate a basic package.json? Or maybe it does? It's not clear from the docs.

If a frontend project imports multiple SDK libraries, then it is not possible to catch HttpException error by duplication.
I'm newly making documents in the new domain https://nestia.io
Thanks for your suggestion.


Add online services option to the search funnel

There is currently an online services filter option that completely replaces the search query in the ... menu with the query @tag:usesOnlineServices:

I would like to add that same option to the search funnel dropdown menu, so that users can find it more easily:

In the latter case, the @tag:usesOnlineServices filter is either added or removed to the search widget query, depending on whether that filter is already in the query.
Two issues:

What should we do about the duplicate options? Is it safe to remove the options in the ... menu, for example, and tell users to use the search funnel instead?
The "Modified" and "Online services" options are different than the other options in the dropdown, in the sense that they don't just add a filter to the search query each time a user clicks on them. Therefore, I haven't appended "..." to those labels, but now they seem to stand out against the other labels. How can we write or sort the labels better so that those options don't stand out so much?

Yeah, I think we can remove the options from the editor gutter ... menu now that we have the new filter button
That's ok. I would put the Modified button first, it's probably the most popular, and the Online Services last.

We can think more about whether moving the online services toggle to this button makes it too prominent. It's important to have it available but it probably isn't needed on a regular basis.

Considering the CI lint fail, I think it'll be easier for me to apply just point 2 of the feedback for now.
I can then add some feature flags to remove the options from the other menus.


feat(config): enable parser.decorators by default

Description:

Set parser.decorators to true when parsing user configuration.
Mark decorators as optional in ScriptParseConfig
Remove parser in example/decorators/farm.config.ts

Resolved: #1110

I'm using @type-ignore to ignore typing checks with non-optional parameters, if that's not appropriate enough, feel free to ask me to change it.

enter npx changeset to update patch version of @farmfe/core in in the terminal


Small bunch of changes to make examples compileable.

It includes such types of fixes:
1)Missed semicolons;
2)Typos;
3)Endless code without :skip-test;
4)Convert flags table to actual table, not code.
Review is welcome.

Seems fairly uncontroversial to me :)


The app store displays confusing incompatibility warning during app installation

Observed behavior
When installing a new app, the app store will show a confusing warning:

The installed version of this app is not compatible with this AiiDAlab environment.

See also screenshot:

Expected behavior
The app store should not check compatibility during the installation, but only after the installation has completed.

This might not be fully resolved.


Add addon checker

For native addons, there's several checks that we should add. For example, ensuring the use of something like the nan package and the like.
There will be more, but we should field ideas from folks who are more familiar with native addons.

Not just because NAN started off as mine, but because NAN is now officially supported and recommended by core and modules not using NAN have severe compatibility problems I'd say NAN support is a must at this stage. There is also https://github.com/tjfontaine/node-addon-layer but it's abandonware at this stage and the only uses of it that I've heard of in the wild (not open source stuff in npm) have since been converted to NAN.
Lack of reliance on non-bundled dependencies would also be something to measure. For instance, consider node-canvas which requires you to have external dependencies (lots of them, and they're all awkward on Windows) vs packages like leveldown and couchbase and many others which bundle their dependencies for compilation. You could probably check this by looking at the binding.gyp and checking what include_dirs there are.
I'd mark down anything that doesn't use https://github.com/tootallnate/node-bindings because they are more likely to not support Debug builds because the author doesn't realise that's a thing.
Anything publishing with precompiled binaries should get a +1, at the moment you only need to look for modules packaging with node-pre-gyp although you may want to follow links to see whether there are binaries for the major platforms for the main node versions (the matrix is complex and most of them don't have full support for the full matrix so many people have fall back to compile anyway). We're moving to more options here, aiming for an official prebuild system, anything not supported by that should be penalised when we get there because the pain for Windows users is so so huge for compiling stuff.
You could check compiler compliance, if they are using too much C++11 or C++14 (or whatever!) stuff then that could be a -1 because it places restrictions on what compilers you need to have available.

This checker has been added. Initially it currently scores for having "nan" and "bindings" as dependencies (in 2 steps) and ensuring that "node-gyp" is declared as a devDependencies item.
There are many other checks to be added of course, but for now, those are good low hanging fruit.


Icon before select in form overlapping

I can't get an icon before a select box like the normal input fields.

code:

                          receipt
                          <select>
                            <option value="" disabled selected>Method</option>
                            <option value="post">Post</option>
                            <option value="get">Get</option>
                          </select>
                          The method that is used while sending the parameter

Is it a bug or is there a mistake in my code?

It's look select element didn't support prefix icons yet

Fixed in 1090e81df399c2a6ae05eb1a8a347dcce152785b

Still not fixed unfortunately. Or is it my code?

Nevermind, when I add

It works. I have the latest version included though.


new

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: DannyArp sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Support WebP File Types for Images

WebP is a now widely support image file extension, and it being utilised by many
companies.
This commit will add Flow support for the .webp file extensions, removing the
need to use $FlowFixMe in files using both Flow type checking and WebP images.
WebP Support

Thanks, I'm going to close this in favor of #8453 though because it also adds tests.


Error getting GitHub Issue when 'Show Issues Comments' is enabled

Github Issues comments for kiwiirc/kiwiirc was unable to receive or process the remote website's content!
Error message: Unexpected response from upstream. cUrl error: (0) PHP error:
Query string: action=display&bridge=GithubIssue&context=Project+Issues&c=on&u=kiwiirc&p=kiwiirc&format=Atom
Version: git.master.43acb55

@em92, can you merge pull request #1950, it fixes this error.
Related issue: #1940

@em92, can you merge pull request #1950, it fixes this error.
Related issue: #1940

Just tested it and all works as expected.

Just tested it and all works as expected.


[FLINK-18977][datastream] Extract WindowOperator construction into a builder class

What is the purpose of the change
Extracts the logic from WindowedStream into a builder class so that there is one definitive way to create and configure the window operator. This is a pre-requisite to supporting the window operator in the state processor api.
Verifying this change
This change is a trivial rework / code cleanup without any new test coverage, however, I did execute the end 2 end tests as additional verification.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@aljoscha I think you're the best person to take a look at this.

For context, this is how the changes will be used: https://github.com/sjwiesman/flink/blob/c39bafc44c0258dff5d66094089426ade792fc21/flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/WindowedOperatorTransformation.java

grazie, aggiusterà e fonderà

This guy... 😂


record-edit-form does not work inside the modal

Embeding ligthning-record-edit-form inside the modal shows weird behavior.

all fields are set as errors
the 'required' validation is not working

<c-modal modal-header="Create New Claim"
             modal-save-handler={firstModalSaveHandler}
             modal-button-text="Save"
             data-id="first-modal">
        <div slot="modalContent" class="modalContent slds-modal__content slds-p-around_medium">
            <lightning-record-edit-form object-api-name="ImpartnerMDF__FundsClaim__c" onsuccess={handleSuccess}>
                <lightning-messages></lightning-messages>
                <lightning-input-field field-name="ImpartnerMDF__FundsRequest__c" value={recordId} disabled></lightning-input-field>
                <lightning-input-field field-name="ImpartnerMDF__PaymentAmount__c" required></lightning-input-field>
                <lightning-input-field field-name="ImpartnerMDF__InvoiceNumber__c" required></lightning-input-field>
                <lightning-input-field field-name="Invoice_Payee_Name__c" required></lightning-input-field>
                <lightning-input-field field-name="Invoice_Date__c" required></lightning-input-field>
            </lightning-record-edit-form>
        </div>
    </c-modal>

 firstModalSaveHandler = (event) => {
        this.template.querySelector('lightning-record-edit-form').submit();
    }

    lastClaimId;

    handleSuccess(event) {
        const file = this.template.querySelector('lightning-file-upload');
        file.recordId = event.detail.id;
        this.lastClaimId = event.detail.id;

        this.template.querySelector('[data-id="first-modal"]').toggleModal();
        this.template.querySelector('[data-id="second-modal"]').toggleModal();
    }

@Damecek interesting, I believe I know what the issue is. I may not have the chance to investigate till later in the week but I will keep you updated - thanks for reporting this!

@Damecek I wasn't able to get to this issue this weekend but it is now my top-most priority. Apologies for the delay - I will keep you updated.

@jamessimone I implemented workaround with toast message so no need to hurry. I managed to locate the issue into the focusFirstChild function, if I comment it out all looks to be working as expected.

@Damecek yup, that’s what I expected. It “breaks” one of the accessibility pieces of the modal: it’s expected that when a modal opens, the first focusable element is selected, but I’m glad you’ve found a workaround for now

@Damecek you can get the updated version now - I don't intend for the current fix to be there long-term, but I need to follow up with the LWC team on the exact issue that you were experiencing now that I've looked into it a bit more. In any case, thanks for reporting this!


[OSPO Book] Chapter 4 - Section - Recommendations (also known as "Scenarios and Recommendations")

Document for collaboration https://docs.google.com/document/d/1b18wJA8OnSvJCnPMXlNeifl1BYcGCORS8Ai-tJwJ0_4/edit?pli=1

@anajsana @todogroup/ospology-book-content I have reviewed this and it's ready for re-editing. Let me know if the suggestions are helpful and if you would like to chat more about it!

@alice-sowerby are the two recommendations showing at https://ospobook.todogroup.org/04-chapter/ reviewed already? should this be moved to done?

@anajsana thank you, it's now moved to translate as it's not on the chinese version yet.


Substudy: Adjust image size as command line option

The tool is great but the images are a little small for me. I guess defaulting to small images is to save on disk space but it would be great to able to select image size.
I'm not so familiar with Rust so I couldn't figure out from the code how image size is handled currently, but perhaps allowing the user to scale the input resolution by a factor of the original would be the simplest way.

Substudy does not, in general, provide any command-line options to customize how it works or what output it produces. This is deliberate—if there's a problem, I'd rather try to fix the problem for everyone, rather than having 20 options so that everyone can try to fix the output themselves.
Given the increases in screen resolution and pixel density since substudy was written, it might be worth increasing image sizes by 50% for everyone. Would that be large enough for your use case?
I'm reluctant to go too big, because (1) I don't want to indirectly abuse the AnkiWeb server by having people upload tons of large images, and (2) the images are intended as a visual mnemonic, not as something where the user actually needs to see the details. But I suspect that the current image size is at least a bit too small for modern systems. Thank you for the suggestion!


Update sbt to 1.4.5

Updates org.scala-sbt:sbt from 1.3.13 to 1.4.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-minor

Codecov Report

Merging #540 (62cca15) into master (2490f5c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   85.44%   85.44%
=======================================
  Files         128      128
  Lines        2974     2974
  Branches      109      109
=======================================
  Hits         2541     2541
  Misses        433      433

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2490f5c...62cca15. Read the comment docs.

We need team city to support sbt 1.4.x prior to merging this. See: https://github.com/JetBrains/sbt-tc-logger/issues/23


how to use in react native

Share example for integration of inmobi for react native

@avinashclassy Currently we do no support integration with react native platform.

Any other solution to use inmobi in react native

As of today, we do not officially support any solution. However, we will consider this as a request and if we come up with the solution in the future then we will update this thread.

@RajSuvariya-InMobi  thanks for the quick response.


Set current CompatibilityInfo outside of driver_lib

How it works now:
Information about compatibility is stored in the form of protobuf in a global object CompatibilityInfo of type TCompatibilityInfo:
https://github.com/ydb-platform/ydb/blob/main/ydb/core/driver_lib/version/version.h#L169
To change the compatibility information for binary we need to change the constructor:
https://github.com/ydb-platform/ydb/blob/stable-23-3/ydb/core/driver_lib/version/version.cpp#L27
The problem with this approach is that NBS uses YDB code by directly linking it without copying or modifying, therefore, in their binary the compatibility information remains the same as in arcadia/ydb.
What is proposed:
We propose to move the construction of the current compatibility information into a separate function and define this function in a separate source file, differing for NBS and YDB. This can be main.cpp or some new file.
How it would look with the main.cpp option:
ydb/core/driver_lib/version/version.cpp
...

TCompatibilityInfo::TCompatibilityInfo() {
    ...

    auto current = MakeCurrentCompatiblityInfo();

    ...
}

...

ydb/apps/ydbd/main.cpp
...

#include <ydb/core/driver_lib/version.h>

...

NKikimrConfig::TCurrentCompatibilityInfo TCompatibilityInfo::MakeCurrentCompatiblityInfo() {
    using TCurrentConstructor = TCompatibilityInfo::TProtoConstructor::TCurrentCompatibilityInfo;
    using TVersionConstructor = TCompatibilityInfo::TProtoConstructor::TVersion;

    return TCurrentConstructor{
        .Application = "ydb",
        .Version = TVersionConstructor{
            .Year = 23,
            .Major = 3,
        }
    }.ToPB();
}

...

cloud/blockstore/apps/server/main.cpp
and
cloud/filestore/apps/server/main.cpp

...

#include <ydb/core/driver_lib/version.h>

...

NKikimrConfig::TCurrentCompatibilityInfo TCompatibilityInfo::MakeCurrentCompatiblityInfo() {
    using TCurrentConstructor = TCompatibilityInfo::TProtoConstructor::TCurrentCompatibilityInfo;
    using TVersionConstructor = TCompatibilityInfo::TProtoConstructor::TVersion;

    return TCurrentConstructor{
        .Application = "nbs",
        .Version = TVersionConstructor{
            .Year = 23,
            .Major = 3,
        }
    }.ToPB();
}

...

I think it would be better to define the version for YDB app in a separate file, rather than main.cpp, to include this file in UT configurations.

https://github.com/ydb-platform/ydb/pull/2753


⚠ Tada Wallet Web has degraded performance

In 2281612, Tada Wallet Web ($WALLET_WEB_URL) experienced degraded performance:

HTTP code: 200
Response time: 6009 ms

Resolved: Tada Wallet Web performance has improved in 8a24e31.


Replace ballots with indexed map

closes https://github.com/confio/poe-contracts/issues/83
I expanded Ballot structure, so now it contains also address of voter and proposal id.
It got me thinking - now this is basically the same structure as VoteInfo link, BUT... it is using String instead of Addr type as in Ballot now.
Options:

Leave it as it is
Get rid of separate Ballot structure and use VoteInfo in voting-contract everywhere instead
2a) but check for Addr correctness before each query.
2b) replace String with Addr in VoteInfo structure

proposal_id wouldn't be needed

That's right, I kept it mostly for consistency. Good point, removed.

I think it makes sense for voter to be String there.

Cool, that's why I asked. Anyway, I removed proposal_id so question is irrelevant now.

@uint

Now that I think about it, shouldn't we mark this as breaking-state?

I actually removed "breaking" label, since all changes are done internally. IAnd although technically state.rs file is changed, it doesn't even need any adaptation in contracts that already uses this new functionality (so tgrade-validator-voting and tgrade-community-pool).

@uint

Now that I think about it, shouldn't we mark this as breaking-state?

I actually removed "breaking" label, since all changes are done internally. And although technically state.rs file is changed, it doesn't even need any adaptation in contracts that already uses this new functionality (so tgrade-validator-voting and tgrade-community-pool).

Yeah, but if there are live voting contracts out there that have already stored some ballots on the blockchain, they will probably break when migrating since their stored data is structured differently now (Map -> IndexedMap).


Update screenshot

Update screenshot https://docs.microsoft.com/en-us/azure/iot-hub/media/iot-hub-metrics/enable-metrics-2.png
Now we have new UX (modern is default. classic visible on screenshot  is not default)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 128ea613-ba7a-88bc-4f2b-cc425df00fe7
Version Independent ID: e2732359-a5c9-1333-d5ec-4e5f2af0527c
Content: Use metrics to monitor Azure IoT Hub
Content Source: articles/iot-hub/iot-hub-metrics.md
Service: iot-hub
GitHub Login: @nberdy
Microsoft Alias: nberdy

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Fix on the way


Contributors update.

Don't give me patch branches. Just git clone the repo, edit the README, commit and push.

Don't give me patch branches. Just git clone the repo, edit the README, commit and push.

Okay.

Not accepted. Closed.


Issues with triggering the classification

Hi,
I've been trying to use the classification endpoint in Snow Owl, without any luck so far.
Could you please clarify what are the expected values for the reasonerId field?
I know Snow Owl is equipped with ELK; I tried to input both "org.semanticweb.elk.elk.reasoner.factory" and "ELK 0.4.3", returned from the reasoners endpoint as extendionId and name, respectively, but it didn't work. In both cases the classification was scheduled and failed later without any error message.
Thanks in advance for your help!

Hi @cristinacivili-work,
An example request would look like this to trigger a classification on the MAIN branch:
POST http://localhost:8080/snowowl/snomed-ct/v3/classifications
{
  "branch": "MAIN",
  "reasonerId": "org.semanticweb.elk.elk.reasoner.factory"
}

The equivalent curl command:
curl -X POST "http://localhost:8080/snowowl/snomed-ct/v3/classifications" -H "Content-Type: application/json;charset=UTF-8" -d "{ \"branch\": \"MAIN\", \"reasonerId\": \"org.semanticweb.elk.elk.reasoner.factory\"}"

I hope this works for you. Let me know if you have any further questions.
Cheers,
Mark

Hi Mark,
thanks for your prompt answer!
The one above looks like my first attempt. Any idea on what could cause a failure?

Hi @cristinacivili-work,
Do you have access to the logs? That might have something that can be used to figure out what's the root cause of the issue.
The logs are located in Snow Owl's serviceability directory <SO_HOME>/serviceability/logs/log.log.
In case of using the official docker container, use the docker logs <container-name> command to access the logs.
Regards,
Mark

Hi @cristinacivili-work,
Just tried on our latest 7.7.0-SNAPSHOT server, it works fine with those settings.
Here are the relevant log lines for reference:
[2020-06-03T13:21:30.946] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   lock                                                             Lock acquired for branch 'MAIN' of repository 'snomedStore' (classifying the ontology).
[2020-06-03T13:21:30.967] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active concept IDs using revision searcher
[2020-06-03T13:21:34.250] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active concept IDs using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:21:34.251] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering concept IDs from stream
[2020-06-03T13:21:34.252] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering concept IDs from stream<EMAIL_ADDRESS>s]
[2020-06-03T13:21:34.262] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active concept flags (exhaustive) using revision searcher
[2020-06-03T13:21:34.269] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active concept flags (fully defined, exhaustive) using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:21:34.269] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active stated IS A graph edges using revision searcher
[2020-06-03T13:21:34.312] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active stated IS A graph edges using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:21:34.312] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active stated non-IS A relationships using revision searcher
[2020-06-03T13:21:34.377] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active stated non-IS A relationships using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:21:34.377] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active inferred relationships using revision searcher
[2020-06-03T13:21:44.516] INFO  eventbus-1592                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":3}}
[2020-06-03T13:21:54.036] INFO  eventbus-1651                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":3}}
[2020-06-03T13:22:03.392] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active inferred relationships using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:22:03.392] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active additional grouped relationships using revision searcher
[2020-06-03T13:22:03.410] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active additional grouped relationships using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:22:03.411] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering 'never grouped' type IDs using revision searcher
[2020-06-03T13:22:04.035] INFO  eventbus-1656                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":18}}
[2020-06-03T13:22:05.097] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering 'never grouped' type IDs using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:22:05.097] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active stated OWL axioms using revision searcher
[2020-06-03T13:22:13.294] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active stated OWL axioms using revision searcher<EMAIL_ADDRESS>s]
[2020-06-03T13:22:13.294] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active concept flags (exhaustive, fully defined) using concept ID stream
[2020-06-03T13:22:13.294] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active concept flags (exhaustive, fully definied) using concept ID stream<EMAIL_ADDRESS>s]
[2020-06-03T13:22:13.295] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active stated IS A graph edges from relationship stream
[2020-06-03T13:22:13.295] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active stated IS A graph edges from relationship stream<EMAIL_ADDRESS>s]
[2020-06-03T13:22:13.295] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active stated non-IS A relationships using relationship stream
[2020-06-03T13:22:13.295] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active stated non-IS A relationships using relationship stream<EMAIL_ADDRESS>s]
[2020-06-03T13:22:13.296] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active inferred relationships using relationship stream
[2020-06-03T13:22:13.296] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active inferred relationships using relationship stream<EMAIL_ADDRESS>s]
[2020-06-03T13:22:13.296] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                >>> Registering active additional grouped relationships using relationship stream
[2020-06-03T13:22:13.296] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy                                                <<< Registering active additional grouped relationships using relationship stream<EMAIL_ADDRESS>s]
[2020-06-03T13:22:13.513] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   lock                                                             Lock released for branch 'MAIN' of repository 'snomedStore' (classifying the ontology).
[2020-06-03T13:22:13.730] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy-inferrer                                       >>> Classification and inferred taxonomy extraction
[2020-06-03T13:22:13.735] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.config.ConfigurationFactory                  Loading default configuration parameters for class org.semanticweb.elk.reasoner.config.ReasonerConfiguration
[2020-06-03T13:22:13.810] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.Reasoner                            ELK reasoner was created
[2020-06-03T13:22:13.812] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Loading of Axioms started
[2020-06-03T13:22:13.814] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Loading of Axioms using 12 workers
[2020-06-03T13:22:13.814] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy-inferrer                                       --- Reasoner task: Loading [--.-%]
[2020-06-03T13:22:14.016] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy-inferrer                                       --- Reasoner task: Loading [00.5%]
[2020-06-03T13:22:14.020] INFO  eventbus-1622                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":3}}
[2020-06-03T13:22:20.504] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Loading of Axioms took 6690 ms
[2020-06-03T13:22:20.504] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Property Saturation Initialization started
[2020-06-03T13:22:20.504] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Property Saturation Initialization using 12 workers
[2020-06-03T13:22:20.504] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Property Saturation Initialization took 0 ms
[2020-06-03T13:22:20.504] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Reflexive Property Computation started
[2020-06-03T13:22:20.509] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Reflexive Property Computation using 12 workers
[2020-06-03T13:22:20.512] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Reflexive Property Computation took 8 ms
[2020-06-03T13:22:20.513] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Object Property Hierarchy and Composition Computation started
[2020-06-03T13:22:20.517] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Object Property Hierarchy and Composition Computation using 12 workers
[2020-06-03T13:22:20.529] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Object Property Hierarchy and Composition Computation took 16 ms
[2020-06-03T13:22:20.530] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Context Initialization started
[2020-06-03T13:22:20.530] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Context Initialization using 12 workers
[2020-06-03T13:22:20.531] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Context Initialization took 1 ms
[2020-06-03T13:22:20.531] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Consistency Checking started
[2020-06-03T13:22:20.533] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Consistency Checking using 12 workers
[2020-06-03T13:22:20.539] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Consistency Checking took 7 ms
[2020-06-03T13:22:20.539] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Class Taxonomy Computation started
[2020-06-03T13:22:20.545] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.AbstractReasonerStage        Class Taxonomy Computation using 12 workers
[2020-06-03T13:22:23.273] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.stages.LoggingStageExecutor         Class Taxonomy Computation took 2733 ms
[2020-06-03T13:22:24.020] INFO  eventbus-1649                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":3}}
[2020-06-03T13:22:27.349] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   reasoner-taxonomy-inferrer                                       <<< Classification and inferred taxonomy extraction [13.62 s]
[2020-06-03T13:22:27.400] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   org.semanticweb.elk.reasoner.Reasoner                            ELK reasoner has shut down
[2020-06-03T13:22:27.408] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   c.b.snowowl.snomed.reasoner.normalform.NormalFormGenerator       >>> Distribution normal form generation
[2020-06-03T13:22:27.409] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   c.b.snowowl.snomed.reasoner.normalform.NormalFormGenerator       --- Initializing node graphs for types: [733928003, 774081006, 738774007, 733930001]
[2020-06-03T13:22:34.058] INFO  eventbus-1593                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":2}}
[2020-06-03T13:22:44.027] INFO  eventbus-1592                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":3}}
[2020-06-03T13:22:54.040] INFO  eventbus-1651                                    request                                                          {"locales":[],"expand":{},"fields":[],"limit":50,"options":{"SORT_BY":[{"ascending":false,"field":"timestamp"}]},"operation":"browse","type":"CommitInfoSearchRequest","repositoryId":"valuesetStore","metrics":{"responseTime":2}}
[2020-06-03T13:23:27.811] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   c.b.snowowl.snomed.reasoner.normalform.NormalFormGenerator       --- Use node graphs for hierarchy computation
[2020-06-03T13:23:52.266] INFO  eventbus-1656                                    request                                                          {"type":"ServerInfoGetRequest","metrics":{"responseTime":0}}
[2020-06-03T13:24:32.938] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   c.b.snowowl.snomed.reasoner.normalform.NormalFormGenerator       <<< Distribution normal form generation [2.092 min]
[2020-06-03T13:24:32.947] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   index.snomedstore                                                Updated 1 classificationtask documents with bulk update with script 'completed'
[2020-06-03T13:24:32.987] INFO  Worker-1: a7b515f7-200d-4f11-b4e8-cdad161726aa   index.jobs                                                       Updated 1 job documents with bulk update with script 'withDone'

Cheers,
Mark

Thank you Mark, we will try with the latest version then. I have two related questions:

What is the expected behaviour regarding inferred statements? Are stated and inferred statements disjoint sets, or should we expect the set of inferred statements to contain the stated ones too?
Should we trigger the classification explicitly to produce inferred statements, or is it something internally scheduled/done at write time?

Thank you for clarifying these features!

Hi @mattecasu,

What is the expected behaviour regarding inferred statements? Are stated and inferred statements disjoint sets, or should we expect the set of inferred statements to contain the stated ones too?

Please refer to the official SNOMED International documentations/papers regarding inferred statement generation:
https://confluence.ihtsdotools.org/display/DOCOWL/2.5.+Generating+Necessary+Normal+Form+Relationships+from+the+OWL+Refsets
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2243264/pdf/procamiasymp00002-0666.pdf
Snow Owl generates the NNF from the available stated definitions during the normal form generation phase of the classification. A stated definition of a concept can become more specific and can result in more specified ISA relationships (the concept pushed down in the hierarchy to represent its correct placement), or other relationships can appear on the concept based on the supertypes defined via the ISA relationships.

Should we trigger the classification explicitly to produce inferred statements, or is it something internally scheduled/done at write time?

Snow Owl provides APIs to generate the inferred definitions of the concepts (aka classify the SNOMED CT content) and it does not schedule this periodically or generate the inferred definitions incrementally. The reason for this is that classification heavily depends on the authoring cycle a SNOMED CT Extension Authoring team uses. Some authors classify after each new concept, some have scheduled classification times, some classify only before the release, etc.. So Snow Owl cannot make any assumptions on when it would be a good time to classify, it relies on manual execution triggered by an external source (be it a human or a machine).
I hope this answers your questions.
Cheers,
Mark

Good morning Mark,
unfortunately we are still experiencing issues with triggering a classification run.
When I start a new classification task on a branch (exactly as you suggested above), the classification is created and then stay in a SCHEDULED state for days. So far we haven't be able to see any of these scheduled task change status.
In the DEBUG logs I see a pattern repeating every five minutes where each message starts with [Classification task cleanup] that could be related, but no ERROR log is involved.
This is what I found in the logs:
`
Jul 13, 2020 @ 17:52:36.952	16:52:36.952 [Classification task cleanup] DEBUG org.elasticsearch.client.RestClient - request [POST https://<host>.amazonaws.com/snomedstore-classificationtask/_search?typed_keys=true&max_concurrent_shard_requests=5&ignore_unavailable=false&expand_wildcards=open&allow_no_indices=true&ignore_throttled=true&search_type=query_then_fetch&batched_reduce_size=512&ccs_minimize_roundtrips=true] returned [HTTP/1.1 200 OK]

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAddCookies - CookieSpec selected: default

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager - Connection leased: [id: http-outgoing-50][route: {s}->https://<host>.amazonaws.com:443][total kept alive: 3; route allocated: 4 of 10; total allocated: 4 of 30]

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAuthCache - Re-using cached 'basic' auth scheme for https://<host>.amazonaws.com:443

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.InternalHttpAsyncClient - [exchange: 240592] Connection allocated: CPoolProxy{http-outgoing-50 [ACTIVE]}

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][r:r][ACTIVE][r][NOT_HANDSHAKING][0][0][0]: Set timeout 0

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager - Connection request: [route: {s}->https://<host>.amazonaws.com:443][total kept alive: 4; route allocated: 4 of 10; total allocated: 4 of 30]

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.InternalHttpAsyncClient - [exchange: 240592] Request connection for {s}->https://<host>.amazonaws.com:443

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAuthCache - No credentials for preemptive authentication

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.MainClientExec - [exchange: 240592] start execution

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.elasticsearch.client.RestClient - request [DELETE https://<host>.amazonaws.com/_search/scroll] returned [HTTP/1.1 200 OK]

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][r:r][ACTIVE][r][NOT_HANDSHAKING][0][0][0]: Set attribute http.nio.exchange-handler

Jul 13, 2020 @ 17:52:36.947	16:52:36.947 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][rw:r][ACTIVE][rw][NOT_HANDSHAKING][0][0][0]: Event set [w]

Jul 13, 2020 @ 17:52:36.944	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][rw:r][ACTIVE][rw][NOT_HANDSHAKING][0][0][0]: Event set [w]

Jul 13, 2020 @ 17:52:36.944	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.InternalHttpAsyncClient - [exchange: 240591] Connection allocated: CPoolProxy{http-outgoing-50 [ACTIVE]}

Jul 13, 2020 @ 17:52:36.944	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager - Connection leased: [id: http-outgoing-50][route: {s}->https://<host>.amazonaws.com:443][total kept alive: 3; route allocated: 4 of 10; total allocated: 4 of 30]

Jul 13, 2020 @ 17:52:36.944	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][r:r][ACTIVE][r][NOT_HANDSHAKING][0][0][0]: Set attribute http.nio.exchange-handler

Jul 13, 2020 @ 17:52:36.944	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][r:r][ACTIVE][r][NOT_HANDSHAKING][0][0][0]: Set timeout 0

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager - Connection request: [route: {s}->https://<host>.amazonaws.com:443][total kept alive: 4; route allocated: 4 of 10; total allocated: 4 of 30]

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.InternalHttpAsyncClient - [exchange: 240591] Request connection for {s}->https://<host>.amazonaws.com:443

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAuthCache - No credentials for preemptive authentication

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.elasticsearch.client.RestClient - request [POST https://<host>.amazonaws.com/snomedstore-classificationtask/_search?typed_keys=true&max_concurrent_shard_requests=5&ignore_unavailable=false&expand_wildcards=open&allow_no_indices=true&ignore_throttled=true&scroll=60s&search_type=query_then_fetch&batched_reduce_size=512&ccs_minimize_roundtrips=true] returned [HTTP/1.1 200 OK]

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAddCookies - CookieSpec selected: default

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAuthCache - Re-using cached 'basic' auth scheme for https://<host>.amazonaws.com:443

Jul 13, 2020 @ 17:52:36.943	16:52:36.943 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.MainClientExec - [exchange: 240591] start execution

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAddCookies - CookieSpec selected: default

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][rw:r][ACTIVE][rw][NOT_HANDSHAKING][0][0][0]: Event set [w]

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager - Connection request: [route: {s}->https://<host>.amazonaws.com:443][total kept alive: 4; route allocated: 4 of 10; total allocated: 4 of 30]

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.InternalHttpAsyncClient - [exchange: 240590] Request connection for {s}->https://<host>.amazonaws.com:443

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.MainClientExec - [exchange: 240590] start execution

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAuthCache - No credentials for preemptive authentication
Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][r:r][ACTIVE][r][NOT_HANDSHAKING][0][0][0]: Set timeout 0

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.client.InternalHttpAsyncClient - [exchange: 240590] Connection allocated: CPoolProxy{http-outgoing-50 [ACTIVE]}

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager - Connection leased: [id: http-outgoing-50][route: {s}->https://<host>.amazonaws.com:443][total kept alive: 3; route allocated: 4 of 10; total allocated: 4 of 30]

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.impl.nio.conn.ManagedNHttpClientConnectionImpl - http-outgoing-50 <IP_ADDRESS>:42854<-><IP_ADDRESS>:443[ACTIVE][r:r][ACTIVE][r][NOT_HANDSHAKING][0][0][0]: Set attribute http.nio.exchange-handler

Jul 13, 2020 @ 17:52:36.939	16:52:36.939 [Classification task cleanup] DEBUG org.apache.http.client.protocol.RequestAuthCache - Re-using cached 'basic' auth scheme for https://<host>.amazonaws.com:443`

Hi @cristinacivili-work,
Could you please try to set the log level to TRACE to see if there are any additional log messages coming from the classification service?
Thanks,
Mark

Hi @cmark,
I managed to run a classification job and it finished successfully. However, there is no documentation about how to actually apply the changes found after that. Looking at the code I gathered I have to update the job to SAVED state. Did that but for the last few hours now it's been stuck in SAVING_IN_PROGRESS.
Do you know what I can do to check if it actually do something or how long is it actually supposed to take for the saving, is this normal, seems unlikely. Also what exactly should the values of the update request be, I am having trouble figuring out the assigner one?
Thanks,
Ivelina

Hi @cmark,
After experimenting with different values I  managed to transition a job to SAVED state with:

namespace - our own namespace
module - our own module
status  - SAVED
assigner - randomly chose "extension" as I saw there are 2 implementation of the SnomedNamespaceAndModuleAssigner but that's probably not correct

this however resulted in loosing a whole lot of concepts and relationships and they are nowhere to be found now.
Can you please describe the whole complete process of classification L

running the job
after done - review the changes
save/apply the changes - how?
where are those actually applied?

Thanks

Hi @ivelina-yordanova,

this however resulted in loosing a whole lot of concepts and relationships and they are nowhere to be found now.

I'm sad to hear you have lost data after you have performed a save through the classification endpoint.
This unfortunately originates from the same issue, Snow Owl does not yet fully support Elasticsearch clusters where the HTTP communication request size is limited to a certain amount. Snow Owl is currently limiting all save operations to 10Mb of bulk action items (or 10_000 bulk action items, whichever threshold reached first). This 10Mb threshold however is only honored by Elasticsearch BulkProcessor and not by other bulk requests (bulk update/delete operations). Those will limit themselves to 10_000 items. I have created a PR (#690) to allow users to configure these values in the snowowl.yml configuration file, which might help you solve the issue by reducing the values to 5_000 and 5 (MB) respectively.

Can you please describe the whole complete process of classification L
running the job
after done - review the changes
save/apply the changes - how?
where are those actually applied?

Process step-by-step is as follows:

Initiate the classification through POST /classifications by selecting the target branch and the classifier to use.
Wait until the classification is complete (poll the endpoint until you see a different status than SCHEDULED and/or RUNNING)
Reviewing the changes can be done by retrieving information from the following endpoints:

GET /classifications/:classificationId/equivalent-concepts - it is recommended (but not required) to resolve those first, then reclassify and continue with the review using the new data
GET /classifications/:classificationId/relationship-changes - inferred (aka to be added)/redundant (aka to be removed) relationships to apply on concepts

When review is complete and the classification result can be saved send a PUT /classifications/:classificationId request with the following JSON body to save the results

{
  "assigner": "extension", // there are two known open source implementation, default and extension (recommended for extensions, like yours), default uses the values configured in the request only (see next two values), while extension uses a more specific algorithm to assign namespace and module values to the newly created inferred relationships
  "module": "string", // this should be your module
  "namespace": "string", // this should be your namespace
  "status": "SAVED"
}

Wait until save is complete, poll until status changes from SAVING_IN_PROGRESS to either SAVE_FAILED or SAVED.
Classification is done and can be viewed on affected concepts and the inferred hierarchy

The classifier generates new inferred relationships based on the new hierarchy information generated by the selected reasoner (eg. ELK). The new relationships will alter the inferred hierarchy in a way to match the stated definition of the concepts. They will move to a more appropriate parent if needed and new inferred information will be added and so on to the affected concepts. This information then can be used in ECL and other queries for you analytics and data retrieval needs.
I hope this clarifies the implementation of the classification process.
Let me know if you have any further questions.
Cheers,
Mark

Hi all,
I'm closing this due to inactivity. Feel free to reopen if you have any new information or need help.
Cheers,
Mark


Link issue section of this repo in readme.md

In the screenshot below :

The 'contributions welcome' image takes us to dwyl/esta github repo. It should take us to this (ridsuteri's) issue section.
I would love to work on this issue.
I'm a GSSoC'22 Contributor.
Please assign this to me.

@ridsuteri I would like to work on this, I have understood the flow of the readme how it should be presented and assure you that changes will enhance the reader experience. \
Please Assign this issue to me as a GSSOC'22 Contributor.

@Pranshu321  Assigning issues work on first come first serve basis. If I'm unable to do it in a day after assigned, then you will get a chance.

Yes @Pranshu321, issues will be assigned on fcfs basis. But don't worry once @aaryahjolia submits his pr, you can open another issues if you feel any need of further enhancement in the readme :)


math:tan: Implement the tangent function

This is an implementation of the tangent function as a polynomial approximation with error less than 2e-8.
I left the existing unit testing data file alone.

This is about 25% faster than the GNU libm.

You need to sign off commits ("commit -s....")

Sorry my bad..didn't notice.


⚠ Rumah123 has degraded performance

In 6024128, Rumah123 (https://www.rumah123.com) experienced degraded performance:

HTTP code: 200
Response time: 16140 ms

Resolved: Rumah123 performance has improved in 10b6067.


[netcore][12.nlp with luis] Add missing resource file and fix recipe file

Fixes Microsoft#814
Proposed Changes

Add 34.luis file to deploymentScripts/msbotClone folder
Add LUIS service in bot.recipe file

Closed due to Microsoft#831


add page to compare path in form

it was always wiki/compare instead of wiki/compare/page_path, so root page will be compared instead of current page

Fixed by now, @page is passed to url helper explicitly.


weird logFC values

I got some genes with large logFC, what is the problem?

This happens when expression of one group is very small while the other one is relative large. There is no shrinkage like DESeq2 for DEG analysis right now.


isso: fix tests

Description of changes
Due to some dependency bump, isso ceased to build its tests for a deprecated API usage. A PR has been sent upstream, see in the diff and it is applied via substitution here.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Fixes https://github.com/NixOS/nixpkgs/issues/264081.

Result of nixpkgs-review pr 264338 run on x86_64-linux 1

3 packages built:

isso
isso.dist
isso.doc


Feature/abort

I added the abort event listener. This way when the player is disposed, the websocket is closed. Otherwise it would stay open forever.
I also added the editorconfig to ensure the space code indentation. It's natively supported by a lot of IDEs.

Thanks!


refactor(devtools): add types to Explorer

Add types to Explorer component with as minimal functional changes as
possible while still getting type safety
#2742

can you try adding some more tests please

can you try adding some more tests please

Can do

@TkDodo are you be happy for me to do some additional clean up in this file too?

@TkDodo are you be happy for me to do some additional clean up in this file too?

sure :)

@Liam-Tait this looks like a nice addition, but the PR is still in draft state. Is ready for review? Thank you

@TkDodo I think this still needed some more tests. I haven't added enough to maintain or increase coverage, however most of these changes are adding types to existing code.

@TkDodo Addressed issues, ready for a re-review

seems like there are some type errors now:
Error: src/devtools/tests/Explorer.test.tsx(39,11): error TS2322: Type '{ label: string; toggleExpanded: Mock<any, any>; pageSize: number; handleEntry: () => Element; expanded: false; subEntryPages: { label: string; }[][]; }' is not assignable to type 'IntrinsicAttributes & RendererProps'.
``

@TkDodo Fixed

:tada: This PR is included in version 3.34.17 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0-alpha.22 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@Liam-Tait I'm now seeing some react key related warnings when running the react-query devtools tests:
``
console.error
Warning: Each child in a list should have a unique "key" prop.
Check the render method of `Explorer`. See https://reactjs.org/link/warning-keys for more information.
    at HandleEntry (react-query/src/devtools/Explorer.tsx:242:21)
    at Explorer (react-query/src/devtools/Explorer.tsx:185:3)

can you maybe have a look at those please?

@Liam-Tait we sadly have 2 more (minor) issues reported that are likely introduced with this PR:

Data Explorer now shows white background for expandable fields:

3.4.16:

3.4.17:

was this an intended change?

expanded entries in the explorer now collapse if there is a background refetch that didn't actually change anything.

For example, take a look at this sandbox

click on the query in the devtools, and expand the owner field
then, re-focus the window

--> the owner collapses.
If you take the sandbox back to 3.4.16, owner stay expanded.

Could you take a look at these two things please? Should we open separate issues? Thank you!

ah, issue 1 is caused by wrapping the clickable element in a button, but it's unstyled.
https://github.com/tannerlinsley/react-query/pull/2949/files#diff-a29eb5ef62b495218e2308396eb9064e59c6630c92421a6ceef78a0836d07fe3R17


Initiating release of 0.10.0

Initiating release of 0.10.0

The process is looking for a release-0.10 branch, but it doesn’t exist.

Anyone know what's going on with these failures? Also seen here: https://github.com/submariner-io/releases/pull/188#issuecomment-895262877

Once we merge this, it will create the branch that E2E is looking for I think.


Add bt driver for rtl87x2g series

Add bt driver for rtl87x2g series

Add bt driver for rtl87x2g series
hi @janegu593
I create a new PR with your commit, where I rebase the code to the newest.
https://github.com/rtkconnectivity/zephyr/pull/9


some color emoji don't display properly

default theme:

dev theme:

Install font AppleColorEmoji.ttf fix this issue.

Hmm, I guess my hack for Emoji fonts may have misses for some unicode ranges. Glad that you can fix your issue with AppleColorEmoji.ttf

For Linux users their system might not install AppleColorEmoji.ttf by default.

Hmm, I guess my hack for Emoji fonts may have misses for some unicode ranges. Glad that you can fix your issue with AppleColorEmoji.ttf


Main Menu: Global Search

Description
The global search at the top of the main view needs a REST-Endpoint that searches among all Entities of type package, publisher, journal ... that contains the given title/name.
Implementation
GET /entities?name=’physics’&offset=10&limit=10

{
  data: [
    {
      type: 'journal , package, publisher or ...',
      name: 'the name used for the view',
    },...  ],
    _pagination: {
      offset : 10
      limit: 10,
      total : 55
    },
    _links: {
      self: { href: ‘/entities?name=’physics’&offset=10&limit=10’ },
      first: { href: ‘/entities?name=’physics’&offset=0&limit=10’ },
      last: { href: ‘/entities?name=’physics’&offset=50&limit=10’ },
      prev : { href: ‘/entities?name=’physics’&offset=0&limit=10’ },
      next: { href: ‘/entities?name=’physics’&offset=20&limit=10’ }
  }
}

We should discuss the ordering/grouping of the results. What makes sense?
Estimated Workload: 1 d
Actual Workload:

The result comes grouped in chunks of size . Ordering by some sort of natural order (alphanumerically) makes sense, changing that order in a paginated list seems pretty much useless to me.

Results will be retrieved via Elasticsearch and would therefore be ordered by relevance score (unless otherwise specified).

Currently the parameter name does a lookup for whole words only, whereas suggest does a truncated search.


Fix spotify password error if it has spaces

Change-type: patch
Connects-to: #90
Hi i hope it fixes the password problem. I couldn´t check it, because i don´t know how to do it. Could someone test if it works now?

I couldn't reproduce the error but this change doesn't harm anything and seems to be more resilient so happy to merge.

@balena-ci retest


🚩: Milestone 8: Space Travelers' Hub | feature/listsRenderRockets

🚩: Milestone 8: Space Travelers' Hub | feature/listsRenderRockets - >>branch<< -
Here is a summary of what has been done:

Use useSelector Redux Hook to select the state slices and render lists of rockets it route.
Added some basic styles to the Rockets component and modified some properties of the index.css.

In this Branch, I have MODIFIED the succeeding 📂* folders and 📄** files

📂* public/

**📄 index.css

📂* src/styles/

**📄 Rockets.css

Added new selectors/properties to improved the style.

📂* src/components/

**📄 Rockets.jsx

Updated the component to render the rockets list or a message if the list is empty.

Thank you for taking the time to review this PR ⭐!

STATUS: APPROVED! 🍾 🎆 🥇
Hi @Ruthmy
You did a great job working on this milestone, your milestone is complete! 🚀
There is nothing else to say other than... it's time to merge it 🤖
Congratulations! 🎉

Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


Fix header not get passed into method

player.play(url: url,headers: ["Authorization": "Bearer eyJhbGciOiJI...."])
When passing header as above is getting replaced by empty headers

Nice catch