NewImageFromImage causes panic: buffered: the command queue is not available yet at Pixels

short error:
panic: buffered: the command queue is not available yet at Pixels

package main

import (
	"fmt"
	"image"
	"log"

	"github.com/hajimehoshi/ebiten"
	"github.com/hajimehoshi/ebiten/ebitenutil"
	"github.com/peterhellberg/gfx"
)

type game struct{}

func init() {
	img := gfx.MustOpenImage("noise.png")
	baseImage, err := ebiten.NewImageFromImage(img, ebiten.FilterDefault)
	if err != nil {
		log.Fatal()
	}

	thingV1 := baseImage.SubImage(image.Rect(0, 0, 8, 8).Add(image.Pt(8*1, 8*0))).(*ebiten.Image)
	thingImage, _ := ebiten.NewImageFromImage(thingV1, ebiten.FilterDefault)
	fmt.Println(thingImage)
}

func (g game) Update(_ *ebiten.Image) error {
	return nil
}

func (g game) Draw(screen *ebiten.Image) {
	ebitenutil.DebugPrint(screen, "template")
}

const (
	screenWidth  = 800
	screenHeight = 600
)

func (g game) Layout(w, h int) (int, int) {
	return screenWidth, screenHeight
}

func main() {
	g := &game{}
	if err := ebiten.RunGame(g); err != nil {
		log.Fatal(err)
	}
}

Long error
panic: buffered: the command queue is not available yet at Pixels

goroutine 1 [running, locked to thread]:
github.com/hajimehoshi/ebiten/internal/buffered.checkDelayedCommandsFlushed(...)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/internal/buffered/command.go:90
github.com/hajimehoshi/ebiten/internal/buffered.(*Image).Pixels(0xc000060480, 0x8, 0x0, 0x1, 0x1, 0x20300000000000, 0x4f3ffff, 0x4f61668, 0x10010004f3ffff, 0x0)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/internal/buffered/image.go:135 +0x4e5
github.com/hajimehoshi/ebiten/internal/mipmap.(*Mipmap).Pixels(...)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/internal/mipmap/mipmap.go:90
github.com/hajimehoshi/ebiten.(*Image).At(0xc0000b4000, 0x8, 0x0, 0xc0000acc00, 0x411f835)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/image.go:722 +0xce
image/draw.drawRGBA(0xc0000b40c0, 0x0, 0x0, 0x8, 0x8, 0x444d420, 0xc0000b4000, 0x8, 0x0, 0x0, ...)
	/usr/local/Cellar/go/1.14.2_1/libexec/src/image/draw/draw.go:519 +0x1e8
image/draw.DrawMask(0x444e4a0, 0xc0000b40c0, 0x0, 0x0, 0x8, 0x8, 0x444d420, 0xc0000b4000, 0x8, 0x0, ...)
	/usr/local/Cellar/go/1.14.2_1/libexec/src/image/draw/draw.go:180 +0x982
image/draw.Draw(...)
	/usr/local/Cellar/go/1.14.2_1/libexec/src/image/draw/draw.go:101
github.com/hajimehoshi/ebiten.imageToBytesSlow(0x444d420, 0xc0000b4000, 0x0, 0x10, 0x8)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/imagetobytes.go:88 +0x213
github.com/hajimehoshi/ebiten.imageToBytes(0x444d420, 0xc0000b4000, 0x0, 0xc0000b6030, 0x8)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/imagetobytes.go:74 +0x39f
github.com/hajimehoshi/ebiten.NewImageFromImage(0x444d420, 0xc0000b4000, 0x0, 0x10, 0x8, 0x444d420)
	/Users/test/go/src/github.com/hajimehoshi/ebiten/image.go:850 +0x112
main.init.0()
	/Users/test/go/src/github.com/kyeett/games/examples/troubleshooting/main.go:23 +0xdd
exit status 2

Thanks!
Further minimized case:
package main

import (
        "github.com/hajimehoshi/ebiten"
)

func init() {
        img, _ := ebiten.NewImage(10, 10, ebiten.FilterDefault)
        ebiten.NewImageFromImage(img, ebiten.FilterDefault)
}

func main() {
}

This is because NewImageFromImage tries to call At of the given image, which is forbidden before the main loop.

Let me mark this as 'won't fix'.

NewImageFromImage invokes At of the given image, but this cannot be called before the main loop especially due to Android.
Giving an Ebiten image to NewImageFromImage is not so useful. You can copy Ebiten's image by ReplacePixels or DrawImage if you want.

Just curious, why is this forbidden (I just ran into the same issue with the same setup)? I wanted to do some pixel level manipulation of the image after loading it, but before I draw it to the screen. :)
I'm loading an image with NewImageFromFile function in an init function before I call RunGame, but I cannot call At of that loaded image.

Good question. This is for portability. On some environments like Android, OpenGL cannot be initialized before the main loop. (Ebiten's Android application works as a shared library, and when init function is called, there is no guarantee that OpenGL functions are available)
To solve this issue, I think I'd need to implement a software rendering instead.
BTW, instead of NewImageFromImage, you can copy the ebiten.Image by NewImage and DrawImage.

Ok, so just checking, there isn't a way to check if the OpenGL functions are available and then run a Init function once (where I do all of my image manipulation before using them), before starting to run all the Update and Draw functions?

No, there is no way to detect whether OpenGL is available.

Thanks for the help. Btw, this library is a joy to use, thanks for making it!


Electron + Wavesurfer waveform not showing.

Wavesurfer.js version(s): 3.0.0(?)
Browser and operating system version(s):
Chromium on Windows 10 1903
Code needed to reproduce the issue:

                <button type="button" class="btn btn-secondary" id="prev" onclick="wavesurfer.skipBackward()">skip_previous</button>
                <button type="button" class="btn btn-secondary" id="play" onclick="wavesurfer.playPause(); if (document.getElementById('playpause').innerText == 'pause') {document.getElementById('playpause').innerText = 'play_arrow'} else {document.getElementById('playpause').innerText = 'pause'};">pause</button>
                <button type="button" class="btn btn-secondary" id="next" onclick="wavesurfer.skipForward()">skip_next</button>

              <input type="range" min="1" max="100" value="50" class="slider" id="myRange">

Use behaviour needed to reproduce the issue:
I'm using Electron.js v6.0.6 with Wavesurfer.js to make an app. Electron uses Chromium as the browser.
My issue is that the waveform does not show up when it should be made. My code to generate the waveform is here:
        stream.on('finish', () => {
            console.log('stream end');
            wavesurfer.load('./temp_music/song.mp3');
            wavesurfer.on('ready', () => {
              wavesurfer.drawer.container.style.display = '';
              wavesurfer.drawBuffer();
              ytdl.getBasicInfo(id, (err, info) => {
                if (err) throw err;
                console.log(info)
                var jsonSend = {
                  dur: wavesurfer.getDuration(),
                  author: info.author.name,
                  title: info.title
                }
                require('electron').ipcRenderer.send('presence', jsonSend)
              })
              wavesurfer.play()
            })
        });

Here is what it looks like
https://dabon.me/ASBIgD7c.png
The middle empty space is where the waveform should be, but it isn't showing.
What do I do?
Thanks.

Why are you using this code?
wavesurfer.drawer.container.style.display = '';
wavesurfer.drawBuffer();

I looked up my issue and that was a possible solution, it didn't work however @thijstriemstra.

can you reproduce this issue without electron? if not, I'm not sure what to say any further about this issue.

Not really, I'm importing modules within the HTML file so that is almost impossible.

I'm having the same problem when I call updateSize()
The element went blank and I need to call drawBuffer() to redraw it

Why are you using this code?
wavesurfer.drawer.container.style.display = '';
wavesurfer.drawBuffer();

Thans！Using "wavesurfer.drawBuffer()" after "wavesurfer.drawer.updateSize()" can resize the canvas.


The ClientWrapper should use model.Row instead of FlatRow

Current workaround would be to use FlatRowAdpater with GCJ's BigtableDataClient#readRowCallable.

We determined that FlatRow is acceptable.


add mock definition

@boranx we're collaborating on unit tests off of this branch https://github.com/openshift/osd-network-verifier/tree/OSD-9228. Could you please change the PR destination to that branch instead?

@boranx we're collaborating on unit tests off of this branch https://github.com/openshift/osd-network-verifier/tree/OSD-9228. Could you please change the PR destination to that branch instead?

Let's just merge this one.
/lgtm


feat: allow passing file as pipeline

Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

The biggest problem I have is that the UX is not consistent. Prior to this change, ilab data generate properly handles a collection of taxonomy additions, regardless of their type (knowledge, grounded skill, freeform skill).

See https://github.com/instructlab/dev-docs/pull/109#discussion_r1671554462
IMO we need to think of "full" or "simple" as a set of (knowledge.yaml, freeform_skills.yaml, grounded_skills.yaml) ... and the UX for custom pipelines should be about providing a custom set

This PR, as the title suggests, allows "passing file as pipeline".
It does this simple thing, and nothing more.
It allows a user to do so, in or outside of the context of running it against multiple YAMLs of different types (freeform, grounded, knowledge), to use a custom pipeline.
I 100% agree with that the UX for running a custom pipeline from file against multiple YAMLs of different types is inconsistent and not good, but it's out of the scope of this PR and should be addressed as a follow up or so.

@russellb please see above.
as a simple example, most of the time people just run ilab data generate against a single YAML file that they introduce. in this case this PR allows one to use --pipeline to specify the pipeline they want

This PR, as the title suggests, allows "passing file as pipeline". It does this simple thing, and nothing more. It allows a user to do so, in or outside of the context of running it against multiple YAMLs of different types (freeform, grounded, knowledge), to use a custom pipeline. I 100% agree with that the UX for running a custom pipeline from file against multiple YAMLs of different types is inconsistent and not good, but it's out of the scope of this PR and should be addressed as a follow up or so.

Yep, I understand what this does!
We've got an ordering issue here too. What needs to happen:

We sort out remaining design questions on how we expect configuration to work end-to-end. That's in https://github.com/instructlab/dev-docs/pull/109
In parallel with #1, we get instructlab and sdg PRs that can be tested together to implement the feature
We have to merge the sdg side first
We need a release of the sdg library that includes the new flow config file support
Then we come back to the instructlab PR (this one or something similar). We can merge it along with a change to requirements.txt that changes instructlab>=0.1.0 to be the version number that includes the feature that is required for this feature to work.

If we merge this first, we've got ilab claiming a feature that doesn't exist and will just produce an error if someone tries it. We also might end up needing a different set of changes once we get to this point.
The PR is quite small, so there's not really any cost to having to hold it. Conflicts will be minimal, if at all.

Cool. @russellb I'm with you that we need to have the SDG PR merged & released first.

Cool. @russellb I'm with you that we need to have the SDG PR merged & released first.

cool, let's make it happen this week! go team :)

@cdoern @aakankshaduggal @RobotSail i had to add an additional commit to reflect the final design and implementation based on the details in https://github.com/instructlab/dev-docs/blob/main/docs/sdg/sdg-flow-yaml.md
I tested it with the latest sdg code that includes config file support
bogus alias
❯ ilab data generate --num-instructions 1 --pipeline foo
Usage: ilab data generate [OPTIONS]
Try 'ilab data generate --help' for help.

Error: foo is not a valid pipeline alias ("simple" or "full") or path to a directory including pipeline configuration files.

before i put files in place ...
❯ ilab data generate --num-instructions 1 --pipeline ~/src/instructlab/customflows
...
Generating dataset failed with the following error: Error: pipeline directory (/Users/rbryant/src/instructlab/customflows) does not contain knowledge.yaml.

with files in place and a change to the block name ...
$ ilab data generate --num-instructions 1 --pipeline ~/src/instructlab/customflows
...
INFO 2024-07-12 12:15:45,160 pipeline.py:69: generate Running block: i_hacked_this_pipeline_yay

i also tested --pipeline simple and that's still fine


Upgrade prawn-svg

Hello,
I'm using bytefield-svg which is heavily using the dominant-baseline of SVG attribute to make the texts center-aligned. However, prawn-svg cannot recognize the attribute. Therefore, I made a PR to support the feature, and it has been merged into main branch successfully. Moreover, the newest release 0.33.0 has included the feature. I hope the asciidoctor-pdf can upgrade it as well.
Thank you!

Three of the visual tests are failing. However, when I inspect the changes manually, I cannot perceive any difference, so likely it is some sort of rounding difference. Therefore, I'll update the expected output files and proceed.

OK. Thanks for your help!

Hi @mojavelinux , is it possible to upgrade the version of the release recently? I want to update the dependency of my project. Thank you!

I don't have any plans for an immediate release, but once I come back around to the project and make a few other updates, I'll push out a release.

OK. I'll wait for the release. Thanks!


GCRoot tests non-deterministicly fail

GCRoot tests also looks to have non-deterministic failures.  This looks like a real product issue.

I'd like to take a closer look at this when I'm free. Could you share the trace logs (GCROOTTRACE) of test failures?

Sure, as soon as I have some time I want to add an infinite loop of GCRoot to LongRunningTests, which should reproduce the problem.  You should be able to test it locally with any flags when I do that.  Not sure if I'll get around to it today but it'll be the next thing I work on.

Ended up figuring out what was wrong here and fixing a few other unrelated problems along the way.

Still failing non-deterministicly.  Will look again tomorrow.

Nit
The active test run was aborted. Reason: Test host process crashed : Unhandled exception. Microsoft.Diagnostics.Runtime.AssertionException: Assertion Failed
   at Microsoft.Diagnostics.Runtime.DebugOnly.Fail(String message) in clrmd\src\Microsoft.Diagnostics.Runtime\src\Extensions\DebugOnly.cs:line 25
   at Microsoft.Diagnostics.Runtime.DebugOnly.Assert(Boolean mustBeTrue, String msg) in clrmd\src\Microsoft.Diagnostics.Runtime\src\Extensions\DebugOnly.cs:line 19
   at Microsoft.Diagnostics.Runtime.DebugOnly.Assert(Boolean mustBeTrue) in clrmd\src\Microsoft.Diagnostics.Runtime\src\Extensions\DebugOnly.cs:line 13
   at Microsoft.Diagnostics.Runtime.Utilities.CallableCOMWrapper.InitDelegateWorker[T](T& t, IntPtr entry) in clrmd\src\Microsoft.Diagnostics.Runtime\src\Utilities\COMInterop\CallableComWrapper.cs:line 107
   at Microsoft.Diagnostics.Runtime.DacInterface.SOSDac.EnumerateHandles(ClrHandleKind[] types) in clrmd\src\Microsoft.Diagnostics.Runtime\src\DacInterface\SosDac.cs:line 630
   at Microsoft.Diagnostics.Runtime.Builders.RuntimeBuilder.Microsoft.Diagnostics.Runtime.Implementation.IHeapHelpers.EnumerateDependentHandleLinks()+MoveNext() in clrmd\src\Microsoft.Diagnostics.Runtime\src\Builders\RuntimeBuilder.cs:line 504
   at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items)
   at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source)
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Microsoft.Diagnostics.Runtime.Implementation.ClrmdHeap.EnumerateObjectReferences(UInt64 obj, ClrType type, Boolean carefully, Boolean considerDependantHandles)+MoveNext() in clrmd\src\Microsoft.Diagnostics.Runtime\src\Implementation\ClrmdHeap.cs:line 351
   at Microsoft.Diagnostics.Runtime.GCRoot.<PathsTo>g__GetRefs|15_0(ClrObject obj, Boolean& found, LinkedListNode`1& end, <>c__DisplayClass15_0& ) in clrmd\src\Microsoft.Diagnostics.Runtime\src\Common\GCRoot.cs:line 417
   at Microsoft.Diagnostics.Runtime.GCRoot.PathsTo(ObjectSet deadEnds, Dictionary`2 knownEndPoints, ClrObject source, UInt64 target, Boolean unique, CancellationToken cancellationToken)+MoveNext() in clrmd\src\Microsoft.Diagnostics.Runtime\src\Common\GCRoot.cs:line 294
   at Microsoft.Diagnostics.Runtime.GCRoot.WorkerThread(BlockingCollection`1 queue, ConcurrentQueue`1 results, ObjectSet seen, Dictionary`2 knownEndPoints, UInt64 target, Boolean all, Boolean unique, CancellationToken cancellationToken) in clrmd\src\Microsoft.Diagnostics.Runtime\src\Common\GCRoot.cs:line 182
   at Microsoft.Diagnostics.Runtime.GCRoot.<>c__DisplayClass11_1.<EnumerateGCRoots>b__0() in clrmd\src\Microsoft.Diagnostics.Runtime\src\Common\GCRoot.cs:line 122
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

That assert should have been fixed in https://github.com/microsoft/clrmd/commit/31c031acd63f1dd00b15e0cb3d7e4dff88d3e9c9#diff-a7deaa30b8ecd20f5c1994f44c495387 ?
Let me know if you see that still.

Oh, no that introduced the assert.
The issue is that we can race to create the delegate on multiple threads.  That's fine, but the assert will trigger if another thread raced to fill the value.
Since we only call InitDelegateWorker in one place, there's no reason to assert there.

Another test report:
Test Name:	Microsoft.Diagnostics.Runtime.Tests.GCRootTests.GCRoots
Test FullName:	Microsoft.Diagnostics.Runtime.Tests.Microsoft.Diagnostics.Runtime.Tests.GCRootTests.Microsoft.Diagnostics.Runtime.Tests.GCRootTests.GCRoots
Test Source:	clrmd\src\Microsoft.Diagnostics.Runtime.Tests\src\GCRootTests.cs : line 213
Test Outcome:	Failed
Test Duration:	0:00:00

Test Name:	Microsoft.Diagnostics.Runtime.Tests.GCRootTests.GCRoots
Test Outcome:	Failed
Result StackTrace:
at Microsoft.Diagnostics.Runtime.Tests.GCRootTests.AssertPathIsCorrect(ClrHeap heap, ImmutableArray`1 path, UInt64 source, UInt64 target) in clrmd\src\Microsoft.Diagnostics.Runtime.Tests\src\GCRootTests.cs:line 374
   at Microsoft.Diagnostics.Runtime.Tests.GCRootTests.CheckRootPaths(ClrHeap heap, UInt64 target, GCRootPath[] rootPaths, Boolean mustContainStatic) in clrmd\src\Microsoft.Diagnostics.Runtime.Tests\src\GCRootTests.cs:line 250
   at Microsoft.Diagnostics.Runtime.Tests.GCRootTests.GCRootsImpl(GCRoot gcroot, ClrHeap heap, UInt64 target, Int32 parallelism, Boolean unique) in clrmd\src\Microsoft.Diagnostics.Runtime.Tests\src\GCRootTests.cs:line 242
   at Microsoft.Diagnostics.Runtime.Tests.GCRootTests.GCRootsImpl(GCRoot gcroot) in clrmd\src\Microsoft.Diagnostics.Runtime.Tests\src\GCRootTests.cs:line 229
   at Microsoft.Diagnostics.Runtime.Tests.GCRootTests.GCRoots() in clrmd\src\Microsoft.Diagnostics.Runtime.Tests\src\GCRootTests.cs:line 220
Result Message:
Assert.Contains() Failure
Not found: SingleRef 39c3010
In value:  <EnumerateObjectReferences>d__50 [DoubleRef 39c2e60]

Oops, I accidentally closed this. This may not have been fully resolved.

No worries!
Yep this is still an issue.  I think the underlying problem with the test here is that we throw all GC roots into a parallel queue and sometimes the handle roots win, and sometimes the stack roots win...but I haven't tested it yet.  This would be "fixable" by making the parallel gcroot code process all handle roots first and when they are done then process all other roots.
However I may just have a bug in this code, it's a really tough algorithm to get right in parallel.  I'm leaving this issue open for now.

I did a bit of research here.  There's still two problems here:
Static roots:  None of the GCRoot code currently favors pinned object handles (including static variables) as it should.  This isn't something that the API guarantees, but it's a really nice property to have since FQ roots and the majority of stack roots are short-lived.  The fix here would essentially be processing all handle roots first,


Feature: Dispatch separate requests for multiple versions

[ :heavy_check_mark: ] I have read the CONTRIBUTING guidelines

Feature request

Currently with sdk install gradle 5.6.4 4.10.3 SDKMAN only installs the first entry, 5.6.4, and ignores the second entry (only accepts one arg).  sdk could support multiple args to be passed to the install command, where each arg is a different version which is dispatched in a separate sequential request.  Thus making it easier for end users to install multiple versions of the same tool.

This requires changes to sdk-main.sh, which I have already implemented in a commit in my commits-pending-merge queue.
These changes were to clean up convoluted code, to support any number of arguments to sdk commands, and to support varargs.  I also created argument validation functions that would output both informative errors and color-coded command usage messages.  I have only implemented varargs in one command, but I can easily add varargs support to additional commands once the main changes have been merged.

@rgoldberg Awesome!  When you open the PR can you link it to this issue?  I was mainly looking at sdk-install.sh's __sdk_install() function.  The vararg is actually the second argument out of three in that function, version.
I have a little imperfect test boilerplate that could be used as a starting point for getting $version in there while still preserving $folder:
#!/usr/bin/env bash

### shift_args.sh

# ./shift_args.sh 1 2 3 4 blah_/bleh-/bluh.
# 1 : 2 : blah_/bleh-/bluh.
# 1 : 3 : blah_/bleh-/bluh.
# 1 : 4 : blah_/bleh-/bluh.

# ./shift_args.sh 1 2 (for single version)
# 1 : 2

candidate=
version=
folder=

folder_regex='[-_.\w]*'
args_count="${@: -1}"

if [[ "$#" > 2 ]]; then
    candidate="$1"
    while [ "$2" != "" ]; do
        version="$2"
        if [[ $args_count =~ $folder_regex ]]; then
            folder="$args_count"
        fi
        echo "$candidate : $version : $folder"
        shift
        if [ "$#" == 1 ]; then
            break
        fi
    done
else
    candidate="$1"
    version="$2"
    echo "$candidate : $version"
fi

After looking at the logic for handling $folder again, this example needs work.  It assumes that every time $version is set then $folder is set too unless there are only two args (i.e. sdk install gradle 4.10.3).  $folder_regex may prove to be irrelevant later.

I forgot about the local path argument, which is stored in the local variable folder.
@marc0der How do you want to handle local paths?
It would be simplest to just use a flagged option, like -p <local path> (-p for path; it could be -l for local, or something else).
I know that you were against flagged options, but, to support more complex usages, they're really handy.  There are other places in which flagged options might be useful.  I can't remember off the top of my head, but I remember thinking about them for other new features.
My not-yet-merged argument validation functions can validate flagged options (using single characters like -p, not words like --local-path).

varargs should also be allowed for the last argument of each of the following commands:

current
flush
uninstall
upgrade

Also, supporting varargs requires updating argument validation for the vararg.  Given that I have not-yet-merged argument validation functions that can handle varargs, we should probably switch to using them before supporting varargs in existing commands.  Better to not waste time rewriting argument validation when a better validation system is already available.

I don't think we should enable global varargs across all commands, let's start small and only do so on the install command for starters.
@d4n1k For now, let's rather go with your approach of bringing change in the sdkman-install.sh. I'd be very happy for you to pick this work up, as it was your idea and you originally volunteered to do the work.
@rgoldberg I also don't want to make huge changes to the way the CLI works wrt adding flags, changing behaviour of existing commands etc. as this will confuse and alienate our users. The CLI works (and has always worked) on imperative commands that read like sentences. Hence we have no flags in our CLI, which is a design choice from the start.
Let's get this feature working in the simplest way possible :-)

You can’t just make the change in sdkman-install.sh. sdkman-main.sh must also be modified as per my next pending commit.
The commands other than install can support varargs later, but it won’t take long to add such support once general vararg code & arg validation code has been merged.

A vararg version for install, however, introduces ambiguity as to whether the third argument is a local path or a version (this ambiguity wouldn’t exist for varargs in any other command). Should it be considered a local path if it is currently a valid path, and a version otherwise? If there are more than 3 args, can the last arg ever be a local path, or can local paths only be used for exactly 3 args? If local path can possibly used with 4+ args, is the penultimate arg the version for the local path as last arg?

@d4n1k
folder is the local path for a local installation, and should never be used for more than one version.  It should only be used for at most one of the version arguments, but your code would apply it to every version.
Your regex will match any string since it uses *,  so there's no point to it.

@rgoldberg Yes that is correct... I'll take a look at the code closer today.
@marc0der I will start working on this again today.

@d4n1k It makes sense to determine how local paths will be handled before working on this. You can’t implement something if you don’t know what that something is.

Yup, that is spot on.  I'm trying to avoid restructuring the whole command just to support varargs.  To me, that defeats the whole purpose, but maybe it does make sense to break apart local installations into a separate function altogether triggered by a flag.  Perhaps something like:
sdk install -l java .java/path

There are 2 issues with using a version vararg for sdk install and setting the default version for a candidate.
Issue 1: User Prompting
Should the user prompt to change the default version:

be displayed as one user prompt that lets a user choose between all newly installed versions (thus no longer a Y/n prompt)?
be displayed as one user prompt for each newly installed version, in argument order?
not be displayed when more than one version is being installed?
be displayed some other way?

Issue 1: Auto Answer Settings
How will $sdkman_auto_answer & $auto_answer_upgrade be handled?  i.e. If either are true, which version is selected to be the new default?  I can imagine:

the first by argument order
the last by argument order
the newest (which would require some ordering for versions)
none, if more than one version is being installed

@ghost this is a summary of what I suggested on Slack. I suggested we consider turning the local installation into a brand new command called local. That frees up install to take varargs of versions only. In other words we would have:
sdk local java 1.8.0 /path/to/java

and then to install multiple versions:
sdk install java a.b.c x.y.z

I also suggest that as always we start with tests. How about we update the existing install_candidate.feature and local_development_versions.feature to reflect our desired behaviour? Once we have come to agreement regarding the specs, we can think about the simplest way of implementing this.


⚠ Bofrost.es has degraded performance

In 70fd208, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1771 ms

Resolved: Bofrost.es performance has improved in 2b693ec after 6 minutes.


added Clear command

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM

Thank you @r3dsquirr3l for your contribution and congratulations on your first PR merge to this repo. 🎉


CLN: Removed colSpace parameter

Title is self-explanatory.  Seems like it was already done in DataFrame.to_string() some time ago.

Current coverage is 85.25% (diff: 100%)

Merging #13857 into master will not change coverage

@@             master     #13857   diff @@
==========================================
  Files           140        140
  Lines         50455      50455
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          43014      43014
  Misses         7441       7441
  Partials          0          0

Powered by Codecov. Last update 59f2557...20de50d

amazing we don't have tests to remove :<


[DO NOT MERGE!!] Render results based on devolved administration availability from the content item

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Trello.
What?
This task is part of an epic to give publishers control over specifying devolved administration availability of a service. As a result of this work, we will render local transaction results pages based on devolved administration availability data from the content item.
Currently the functionality to display different results pages based on devolved administration availability exists, but the availability data is read from the local_transactions_config.yml file. The existing functionality has been removed as part of this PR.
As well as now reading the devolved administration availability data from the content item, the views and content have been updated. See the Trello card to understand what the design/content should be.
Why?
At the moment, adding service data to the yml file involves developer intervention. Adding this as a feature to the publishing application will make things easier for content designers and developers. Although there are only 2 services specified in the yml file, we have identified that there are many other services that are unavailable to devolved administrations. Publishers will also be able to update these services via the publishing tool, which should make for better results to users.
Screen shots

Please note that I later removed the full stop at the end of the button text... but don't have time to deploy the branch to integration and set up the data again so please imagine it isn't there...

Devolved administration availability with alternative URL

Service unavailable to devolved administration

Devolved administration availability (local authority service/default)

I think it would be good to get a review from a designer and content person as some of the content doesn't quite match up to the design, for example I am not sure if we should be rendering a 'Your postcode has been matched' for devolved_administration_service.html.erb.

@kevindew thanks for your review, it is ready for re-review.
I have re-written it to make use of the LocalTransactionPresenter and it a way better approach.
I think it could also be good to get a review from a content writer/designer. I will take some screen grabs on Monday using integration and ask for them to look them over. I am not 100% confident due to the content example (word doc) not including as much text as the web pages we used for design reference. I am not sure if the lines not included in the content don't need changing, or if they shouldn't be included.

Thanks @kevindew. It is ready for re-re-review. I updated the screen grabs in the PR description.

Thanks @kevindew it is ready for review again. I updated the commit message to explain why the more_information section isn't rendered. I also updated the GA values and added the rationale from your email into the commit.

@kevindew thanks! Have made the updates. Sorry about the matched_postcode_html I must have messed up rewriting the commit somehow.

Thanks @kevindew :)


Bump version to 8.1.0.GA.5 for releasing multi-arch set

No code changes, but we need a new build to be released together with the full set for multi-arch (x86_64 server, s390x server, operator multi-arch, bundle multi-arch). Just bumping the version and re-spinning.
Took the change to introduce:
JDG-4063 Use new specification for ubi8-minimal base image
See https://docs.engineering.redhat.com/pages/viewpage.action?pageId=87727140
https://issues.redhat.com/browse/JDG-4063

Thanks @osnipso


Touchscreen Scrolling in Help

Instead of scrolling the entire pane moves when attempting to scroll down in the pop-up help.

Should be fixed in the v5.


How to stop centos7 container correctly?

I download and run centos7 container
lxc image copy images:centos/7/amd64 local: --alias=centos7-image
lxc init local:centos7-image centos7
lxc start centos7
lxc list
+--------------+---------+-----------------------+------+------------+-----------+
|     NAME     |  STATE  |         IPV4          | IPV6 |    TYPE    | SNAPSHOTS |
+--------------+---------+-----------------------+------+------------+-----------+
| centos7      | RUNNING | <IP_ADDRESS> (eth0) |      | PERSISTENT | 0         |
+--------------+---------+-----------------------+------+------------+-----------+

Then I stop container.
lxc stop centos7

And the stop command hangs.
But lxc stop centos7 --force works. As I understand --force kill container and application inside it.
How to stop centos7 container  correctly?

Can you please include the "lxc info" output as requested as part of the bug report template?
LXD when used with LXC 2.0.4 (liblxc1 at version 2.0.4 or higher) should be able to shutdown centos containers cleanly. I just tried it here and it worked fine.

I use latest Ubuntu Server 16.04 LTS
(ubuntu)[root@ubuntu /]# uname -a
Linux ubuntu 4.4.0-36-generic #55-Ubuntu SMP Thu Aug 11 18:01:55 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

(ubuntu)[root@ubuntu /]# lxc info centos7
Name: centos7
Architecture: x86_64
Created: 2016/09/04 07:39 UTC
Status: Stopped
Type: persistent
Profiles: default

(ubuntu)[root@ubuntu /]# lxc version
2.0.3

Please update your system, LXC and LXD 2.0.4 have been available as updates for Ubuntu 16.04 for about a week now.

I have the same problem with debian jessie (amd64) containers. Just plain containers from images:, without any changes. I already use 2.0.4 and rebooted so the version in RAM is def .4!
I also have a problem with ubuntu and debian containers regarding apt. I just can't update or install software. Apt does gets the ip via DNS, but then just stalled. Nothing happens just staying at 0%.
DNS in the containers works, pinging, tracerouting. I can even send text via netcat to the containers (tcp). 0% [Connecting to archive.ubuntu.com (<IP_ADDRESS>)]  . Not sure if related but i thought i mention it.

The jessie problem is unrelated.
Sep 06 16:53:05 jessie systemd[1]: Starting Halt...
Sep 06 16:53:05 jessie systemd[1]: Assertion 'sd_id128_randomize(&id) >= 0' failed at ../src/core/dbus.c:688, function bus_on_connection(). Aborting.
Sep 06 16:53:05 jessie systemd[1]: Caught <ABRT>, dumped core as pid 172.

So it's basically systemd in jessie just crashing on shutdown. The shutdown sequence itself was triggered properly, so it's down to a systemd bug.

Thanks for finding the cause. It looks like it is already reported in DBTS and upstream.

I'm update Ubuntu by aptitude upgrade and centos7 container stoped correctly.
Thanks!


Editor inserts  when URL contains underscores

Problem:
When Italic and Link extensions are active, URL with underscores turns into italic.
Test Editor: https://tiptap.scrumpy.io/links
Test URL: http://google.com/test_test_test

also see #284 and corresponding pull request (#285) for another fix concerning the given test-case


Unable to send Lumens

{
"type": "https://stellar.org/horizon-errors/server_error",
"title": "Internal Server Error",
"status": 500,
"detail": "An error occurred while processing this request.  This is usually due to a bug within the server software.  Trying this request again may succeed if the bug is transient, otherwise please report this issue to the issue tracker at: https://github.com/stellar/horizon/issues. Please include this response in your issue.",
"instance": "horizon-live-002/WbPeIf66nB-25841297"
}

Seems to be working again.


Release v3.18.1

Overview
This is a checklist for releases. This is filled in by both the releaser and the reviewer where necessary.
Update Documentation

[x] Create a new release in the whats-new section and copy the release CHANGELOG from TheThingsIndustries/lorawan-stack. The title is the release version and the date is the release date.
[x] Remove empty sections from the created release file.
[x] Update the documentation version to match the current PATCH, if necessary (3.${minor}.${patch}). Note that this previously included a "v" prefix and only included a minor, but the patch must be included or repository and CLI links will break, and no "v" should be prefixed.
[x] To generate documentation, create a clone of TheThingsIndustries/lorawan-stack, and checkout the git tag of the release.
[x] To generate API documentation, run the following from within the clone of TheThingsIndustries/lorawan-stack:

$ tools/bin/mage ttiProto:hugoData

[x] Copy generated files to lorawan-stack-docs by running the following commands in lorawan-stack-docs:

$ rsync --recursive --delete --remove-source-files ../lorawan-stack/api/ttn.lorawan.v3/ ./doc/data/api/ttn.lorawan.v3/
$ rsync --recursive --delete --remove-source-files ../lorawan-stack/api/tti.lorawan.v3/ ./doc/data/api/tti.lorawan.v3/

NOTE: This assumes that the parent directory of lorawan-stack-docs also contains lorawan-stack. If not, you'll need to adjust the commands accordingly.

[x] To generate and export CLI documentation from within the clone of TheThingsIndustries/lorawan-stack, first run the following command to build the CLI:

$ go build -tags tti ./cmd/tti-lw-cli

[x] Then export the CLI documentation using following commands:

$ HOME='$HOME' ./tti-lw-cli gen-md-doc -o ../lorawan-stack-docs/doc/content/ttn-lw-cli

$ HOME='$HOME' ./tti-lw-cli gen-json-tree -o ../lorawan-stack-docs/doc/data/commands

[x] Replace links to end-devices/templates with templates as they are not exported correctly:

$ sed -i.bak 's/end-devices_templates/templates/g' ../lorawan-stack-docs/doc/content/ttn-lw-cli/ttn-lw-cli_end-devices.md

[x] Clean up:

$ rm ../lorawan-stack-docs/doc/content/ttn-lw-cli/ttn-lw-cli_end-devices.md.bak

NOTE: This assumes that the parent directory of lorawan-stack-docs also contains lorawan-stack. If not, you'll need to adjust the commands accordingly.

Check (for reviewers)

[ ] A new section has been created in whats-new with the corresponding CHANGELOG from TheThingsIndustries/lorawan-stack. The title is the release version and the date is the release date.
[ ] The documentation version is up to date with the latest PATCH (3.${minor}.${patch}). No "v" is prefixed.
[ ] The TTI and TTN API documentation has been generated and updated in doc/data/api. This includes the following files:

doc/data/api/tti.lorawan.v3/messages.yml
doc/data/api/tti.lorawan.v3/services.yml
doc/data/api/tti.lorawan.v3/enums.yml
doc/data/api/ttn.lorawan.v3/messages.yml
doc/data/api/ttn.lorawan.v3/services.yml
doc/data/api/ttn.lorawan.v3/enums.yml

[ ] The TTI CLI documentation has been generated and updated in doc/data. This includes the following files:

doc/data/commands/ttn-lw-cli.json
doc/content/ttn-lw-cli/*.md

[ ] All generated documentation matches the version that is being released.

Closed with #825


Make lookup-joins work with arbitary sub-queries for the smaller sides

Summary of the changes / Why this improves CrateDB
This is a first POC to make lookup-joins work with arbitrary sub-queries for the smaller side. It includes the following changes:

Make sub-queries of MultiPhase accessible to the optimizer as sources. This is necessary to optimize further on the sub-queries.
Introduce PlannedRelation as PlaceHolder for SelectSymbol.

Checklist

[x] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

@mfussenegger I am not looking for a full review, but just some early-feedback. Thanks a lot!


What's the purpose of speech-processor.js in version 1.4.1 zip package?

Documentation mentions two files in the zip package but there are more than 2. There's also a file in the 1.4.1 zip package called speech-processor.js which is not mentioned in documentation. Is that needed for the client?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a765d478-6ca6-7555-dfc8-260e7adf7523
Version Independent ID: 211f0cc9-2958-98fe-17f2-cecdf5f57f40
Content: Quickstart: Recognize speech, JavaScript (Browser) - Speech Services - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/quickstart-js-browser.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @fmegen
Microsoft Alias: fmegen

@siddiqaa Thanks for your question. We are checking on this and will respond to you soon.

@SumanthMarigowda-MSFT Thank you - I edited my original issue description with more details and look forward to the response.

@siddiqaa Thanks for pointing this out. It looks like this file is a recent addition for the implementation of the AudioWorkletProcessor  This file will be loaded only in recent browsers that supports Audio worklet. It is
currently in js because it needs to be in es6.
@fmegen Do we have a plan to update this documentation to add more information about this file in the latest package?

@siddiqaa We will now proceed to close this thread. If there are further questions regarding this matter, please tag @RohitMungi-MSFT in your reply. We will gladly continue the discussion and we will reopen the issue.


Inspirational generation

Hi @Molugan , thank you for this great repo!
I have trained the stylegan using my own dataset and tried to do the inspirational generation following your instruction. I have conducted
python save_feature_extractor.py vgg19 feature_extractor_345 --layers 3 4 5
And then run
python eval.py inspirational_generation -n stylegan_outdoor -m StyleGAN --input_image fake_data_outdoor/gen_0.jpg -f feature_extractor_345
Yet I got error as following:
0 :  56.091831
Traceback (most recent call last):
  File "eval.py", line 54, in <module>
    out = module.test(parser, visualisation=vis_module)
  File "/models/eval/inspirational_generation.py", line 429, in test
    outPathSave=outPathDescent)
  File "/models/eval/inspirational_generation.py", line 258, in gradientDescentOnInput
    loss.sum(dim=0).backward(retain_graph=retainGraph)
  File "/.virtualenvs/cv/lib/python3.6/site-packages/torch/tensor.py", line 198, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph)
  File "/.virtualenvs/cv/lib/python3.6/site-packages/torch/autograd/__init__.py", line 100, in backward
    allow_unreachable=True)  # allow_unreachable flag
RuntimeError: Trying to backward through the graph a second time, but the buffers have already been freed. Specify retain_graph=True when calling backward the first time.

Besides, there might be a typo in the readme file, as the command should be
--input_image $pathTotheInputImage
instead of
--inputImage $pathTotheInputImage
Any insights on how to solve the RuntimeError issue? Any help would be greatly appreciated!

Hi, I just solved this issue by amending this line
to
loss.sum(dim=0).backward(retain_graph=True)

Hi @Molugan , one more question about the functionality of inspirational generation.
I used one of the generated samples as input image, namely the following

And I got this as output image:

Together with this json file:
{
  "gen_0_inspiration": [
    52.50878143310547
  ],
  "Barycenter": {
    "meanDist": 0.0,
    "stdAngles": NaN,
    "meanAngles": 1.0
  },
  "kwargs": {
    "evaluation_name": "inspirational_generation",
    "no_vis": false,
    "np_vis": false,
    "module": "StyleGAN",
    "name": "stylegan_outdoor",
    "dir": "output_networks",
    "iter": null,
    "scale": null,
    "config": null,
    "partition_value": null,
    "statsFile": null,
    "featureExtractor": [
      "feature_extractor_345"
    ],
    "inputImage": "fake_data_outdoor/gen_0.jpg",
    "nRuns": 1,
    "learningRate": 1,
    "suffix": "inspiration",
    "lambdaD": 0.03,
    "nSteps": 6000,
    "weights": null,
    "gradient_descent": false,
    "random_search": false,
    "size": 128,
    "nevergrad": null,
    "save_descent": false
  }
}

and two pt files gen_0_inspirationvector.pt and gen_0_inspirationvectors.pt.
it would be great if you could share more detailed information on this workflow, namely how to interpret the result derived using this function?


Radio questions can be configured to show an OR separator

Changes in this PR
This change allows Radio questions within Contentful to specify a new attribute within it's existing option field called separated_by_or.
If omitted or set to false, no separator will be shown.
[
    {
        "value": "Yes"
    },
    {
        "value": "No",
        "separated_by_or": true
    }
]

Screenshots of UI changes
Before

After

FYI: When reviewing this you may notice the same bug I did. When you click between radio options that don't have further_information configured the page will jump up and down as the gem inserts and toggles an unused container element. I'll fix this seperately now.


For semantic segmentation tasks eraser size is static but should be adjustable

Is your feature request related to a problem? Please describe.
The current eraser size for semantic segmentation tasks is static and cannot be changed. For tasks requiring pixel-accuracy it's too big.
Describe the solution you'd like
The brush slider should also work for the eraser. Instead, when moving the slider the brush tool is selected again.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Fixed with version 1.3.0 release.


Reformat Kotlin code to upgrade ktlint version

Motivation:
To upgrade ktlint version from 0.36.0 to ktlint-gradle plugin's default (0.43.2).
Armeria's some kotlin code violates the new ktlint version's default ruleset, especially, when it comes to adding newlines.
Modifications:

Run ./gradlew ktlintFormat task once.
Manually reformat some code for better readability.

@minwoox @ikhoon @jrhee17
I've updated the PR to reformat kotlin code as per the discussion in https://github.com/line/gradle-scripts/pull/134.
PTAL 🙏. It would be nice if you can give some advice about the right process of updating line-gradle-scripts.

Thanks for updating it. 😄

It would be nice if you can give some advice about the right process of updating line-gradle-scripts.

We use git-subrepo.
https://github.com/line/armeria/blob/master/gradle/scripts/.gitrepo#L4
The process is:

Sending a PR to /line/armeria to check if it works.
Sending a PR to /line/gradle-scripts that contains the changes of Gradle scripts.
Merging the gradle-scripts PR.
Updating the Armeria PR using git-subrepo. (In the root directory, you can just execute git subrepo pull gradle/scripts)
Merging and Done.

https://github.com/line/gradle-scripts/pull/134
https://github.com/line/gradle-scripts/pull/135
are merged. Could you pull the changes using subrepo, please?

@minwoox
Pulled the new master!
But I couldn't just do git subrepo pull gradle/scripts and succeeded after adding -f flag.
It looks like the original parent SHA in .gitrepo file no longer exists.

retest this please

@ks-yim, thanks soooooo much! 😄


feat: allow to ignore Accept-Encoding through the CLI argument

What kind of change does this PR introduce?
Feature
Description
WIP...

What's the use case for this?

rebased


Add GitHub Action for Python code check

Goal
Add a GitHub Action that would check the Python code during the PR stage. We should check for types and format.

The simplest, first version is up and ready for the pull requests. Check the workflow file for more insights. We will iterate from here.


Make authenticateUser function throwing

This pull request adds a throwing version of authenticateUser function.
By making this function throwing we remove from the user the need to handle third (most likely never happening) state where both user and error are nil.

Nice catch! Thanks for contributing @Tunous!


ROX-25618: Add the ability to download policies as CR

Description
Adds the ability to save non-system policies as kubernetes custom resources via:

Policy table row menu
Policy table bulk action menu
Policy detail page header menu

Saved policies will be bundled into a zip file before being downloaded.
User-facing documentation

[ ] CHANGELOG is updated OR update is not needed
[ ] documentation PR is created and is linked above OR is not needed

Testing and quality

[ ] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[ ] CI results are inspected

Automated testing

[ ] added unit tests
[x] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests

How I validated my change
From the policy table page, open a row menu for a policy and select "Save as Custom Resource"

From the modal, confirm by selecting 'Yes':

A zip file containing a single YAML for the policy should be downloaded:

Select multiple policy checkboxes in the table and choose "Save as Custom Resource (#)" from the bulk actions menu:

A modal will be displayed, showing the count of selected non-system policies. Select 'Yes' to download the zip.

A zip file containing a separate YAML for each selected policy should be downloaded:

From the policy detail page, open the menu in the page header and select "Save as Custom Resource". A zip file containing a single YAML for the policy should be downloaded:

Tested against https://github.com/stackrox/stackrox/pull/13007 and can be merged when that PR is merged.


chore: release v3

Codecov Report

Merging #45 (7a21b87) into main (ff29459) will decrease coverage by 2.64%.
The diff coverage is 89.89%.

:exclamation: Current head 7a21b87 differs from pull request most recent head e04d95c. Consider uploading reports for the commit e04d95c to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   99.62%   96.98%   -2.64%
==========================================
  Files           3        3
  Lines        1851     2390     +539
  Branches      205      239      +34
==========================================
+ Hits         1844     2318     +474
- Misses          7       72      +65

Impacted Files
Coverage Δ

src/utils.ts
46.78% <36.26%> (-53.22%)
:arrow_down:

src/index.tsx
99.39% <98.73%> (-0.26%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


std.traits: Add trait for determining if a type has padding/alignment holes

ibuclaw (@ibuclaw) reported this on 2020-08-23T22:08:23Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=21192
CC List

ibuclaw (@ibuclaw)

Description
Created attachment 1802
example implementation

Such a trait could be used by core.internal.convert.toUbyte() to determine whether it is safe to return all bits of a struct to compute the hash, or does it need to selectively copy all fields.

Rationale: structs that are passed around in registers typically discard any memset() operation done to zero all alignment holes, so comparing all bits for equality may not work.

Attached example implementation.

!!!There are attachements in the bugzilla issue that have not been copied over!!!

ibuclaw (@ibuclaw) commented on 2020-08-23T22:14:39Z
Created attachment 1803
example implementation - no pragma(msg)

ibuclaw (@ibuclaw) commented on 2020-08-24T07:02:11Z
(In reply to Iain Buclaw from comment #1)
> Created attachment 1803 [details]
> example implementation - no pragma(msg)

Example implementation is missing creal and ireal support - should be added to the same condition as is(T == real).


V1 Patch - Configurable base branch

Hi @brunobesson!
Thank you for all the prompt updates and work on this project. Would you be so kind to release a patch version for v1 that includes the fix made in #349 so that repositories using v1 can benefit from it? There are certainly a good number of repositories that relies on the npx browserslist@latest --update-db command for now being in transition, because update-browserslist-db doesn't work on projects running on Node versions prior to 15 (npm 6).
This PR just includes some simply copy updates matching v2, and the new base_branch input.
Thank you!

Thank @nfmohit for the hint. I have released v1.5.0 with your suggested backports.

Thank you for the kind update!


Fixed tab request approval issue

Build status  - All builds passed
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/5411190102


Apex 18.2 not supported

Is it possible to upgrade this plugin to v18.2? Currently is not possible to use this in Apex 18.2 - there is some JS error when you click on item.

it is supported since 1.2.0.


support list of enforce group ids to associate with google project

Rather than only supporting the association of a single enforce group id, support multiple group ids, as a list.
Toward addressing https://github.com/chainguard-dev/customer-issues/issues/66
Signed-off-by: Kenny Leung<EMAIL_ADDRESS>

manually ran terraform-docs and there was no diff, not sure why the check is failing

this is ready for another look.
thanks


Create a CosmosClient fails, because of the usage of deprecated field of jackson.core in Utils.java

Describe the bug
I have included azure-cosmos 4.63.3 into my project and wanted to create a simple Cosmos Client.
It fails, because it references as dependency jackson.core 2.17.2, where JsonParser.Feature.ALLOW_TRAILING_COMMA as been deprecated since 2.10.0. This results in a NoSuchFieldError exception thrown in com.azure.cosmos.implementation.Utils, because mentioned field is used in line 113.
Exception or Stack Trace
Caused by: java.lang.NoSuchFieldError: ALLOW_TRAILING_COMMA
at com.azure.cosmos.implementation.Utils.createAndInitializeObjectMapper(Utils.java:113)
at com.azure.cosmos.implementation.Utils.(Utils.java:74)
at com.azure.cosmos.implementation.CosmosMicrometerMetricsConfig.toJson(CosmosMicrometerMetricsConfig.java:47)
at com.azure.cosmos.implementation.Configs.(Configs.java:218)
at com.azure.cosmos.CosmosClientBuilder.(CosmosClientBuilder.java:120)
at com.custom.azure.CosmosDBUpdater.init(CosmosDBUpdater.java:17)
... 49 more
To Reproduce
Try to create a simple Cosmos Client, this will throw the exception
client = new CosmosClientBuilder()
.endpoint(serviceEndpoint)
.key(key)
.buildClient();
Code Snippet
private static ObjectMapper createAndInitializeObjectMapper(boolean allowDuplicateProperties) {         ObjectMapper objectMapper = new ObjectMapper();         objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);         objectMapper.configure(JsonParser.Feature.ALLOW_SINGLE_QUOTES, true);         objectMapper.configure(JsonParser.Feature.ALLOW_TRAILING_COMMA, true);         if (!allowDuplicateProperties) {             objectMapper.configure(JsonParser.Feature.STRICT_DUPLICATE_DETECTION, true);         }         objectMapper.configure(DeserializationFeature.ACCEPT_FLOAT_AS_INT, false);         tryToLoadJacksonPerformanceLibrary(objectMapper);         objectMapper.registerModule(new JavaTimeModule());         return objectMapper; }
Expected behavior
No exception
Setup (please complete the following information):

IDE: eclipse
Library/Libraries: com.azure:azure-core:4.63.3
Java version: 8
App Server/Environment: IDE

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Bug Description Added
[x] Repro Steps Added
[x] Setup information Added

@kushagraThapar Thank you for the hint and sorry for making noise where its wrong. You are right an older version of jackson library (2.2.2) gets loaded prior to mine. Try to find a workaround.
Thanks again!

Issue is caused by an older version of jackson library loaded prior to the necessary one in the local application.

@srasp - no worries, glad we found the issue :)


modify ssa_names and update ir_parser tests

@bgogul As per the suggestion above, this PR handles SsaNames. Any further changes related to Value will be done in another PR. PTAL the changes made based on review comments.

Note: No new PR is created for Values. Had some time before another round of review to fix value changes in this PR. Sorry for the confusion.


How to kill tracks when they leave scene?

First of all, thanks for the package. I am currently working on tracking cars using the detections from a yolov5 network. The problem is that it works fine when cars go through different lanes. My problem is that I am recording an entrance and exit (same lane) and when a car leaves and another one enters they get matched as the same car. I tried reducing the point_transience but that did not really help. Also, is there a common practice when setting up the hyperparameters of the tracker (like recording the average distance between detections?

@ManuConcepBrito That is odd, if the object leaves the scene for some time the object_id should be removed from the pool, and a new object_id should be assigned for the object that enters the scene. You may have your hit_inertia_max be too high.
@nikky4D Just set past_detections_length to how many detections you want to keep through the life of the project, and then if you want embeddings just add embeddings to the .data property of the object, which you can later use in you distance function. This is not properly documented at the moment, and there are no examples, but we'll add some soon. Docs

Thanks for the help! I finally figured out the issue. We were only passing detections to the tracker when a detection was in the frame so we skipped the empty frames and that's why it didn't kill the tracked objects.

Awesome!


Inventory

In this milestone I made sure the UI;

display a list of inventories created by the logged-in user as in the wireframe.
lead to inventory details.
navigation menu that allows users to open all of the pages you created.

@taldr27 Thank you for your review. Working on it asap

@taldr27 Thank you. Have a nice day


feat(contracts): use require to throw error message

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (yarn build) was run locally and any changes were pushed
[ ] Lint (yarn lint --check) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

I don't think this is the approach we should take. If we're going to use string error messages they need to be very short, like 2-3 characters. But I think we should keep the error objects like we currently have.
I think a better approach is make a table in the docs showing the error message hash and what the hash means. Each error message is hash is calculated like keccak256(MessageName,arg1Type,arg2Type).

But in hardhat environment the error hash is not shown :(

Another solution is that if we change the deployment method from typechain UnirepFactory to hardhat getContractFactory
https://github.com/Unirep/Unirep/blob/50d165fb1af0543e3fdc74b2f7c142518bdaebe9/packages/contracts/deploy/deploy.ts#L133
and getContractFactory can link libraries
The custom error can be displayed
How do you think? @vimwitch

We should bump our hardhat version, 2.10.2 adds support for showing the custom error selector.

We should probably bump to 2.11.x, it adds support for post-merge chains.

We should probably bump to 2.11.x, it adds support for post-merge chains.

I found that they only change this file
https://github.com/NomicFoundation/hardhat/blob/fda6bd9b1519f7b9cd433fb40e355a295043a7e0/packages/hardhat-core/src/internal/hardhat-network/stack-traces/error-inferrer.ts#L524
(commitment: https://github.com/NomicFoundation/hardhat/commit/85bd04ee85611611ff511ab52154bf4c2282b9cb)
but not this
https://github.com/NomicFoundation/hardhat/blob/fda6bd9b1519f7b9cd433fb40e355a295043a7e0/packages/hardhat-core/src/internal/hardhat-network/stack-traces/solidity-errors.ts#L274
We can create a PR for hardhat 😅

https://github.com/NomicFoundation/hardhat/pull/3384
Okay I think I can create a table for error selectors in this PR. And wait the hardhat PR to be merged.

This LGTM but I'd like to hold off on publishing until https://github.com/NomicFoundation/hardhat/pull/3384 is done. Maybe we could include a note saying that hardhat support for this is pending?

yeah I think it is okay to pend this PR until it is merged and published

and in some places there are require instead of revert ErrorMessage()
https://github.com/Unirep/Unirep/blob/dd870015b0b45fe881d2fc124993a12a2969e343/packages/contracts/contracts/Unirep.sol#L228
will we change all the require to revert ErrorMessage()? @vimwitch

I think we can merge this, I'm seeing this in the logs:
    body: '{"jsonrpc":"2.0","id":118,"error":{"code":-32603,"message":"Error: VM Exception while processing transaction: reverted with an unrecognized custom error","data":{"message":"Error: VM Exception while processing transaction: reverted with an unrecognized custom error","data":"0xa225656d0000000000000000000000000000000000000000000000010000000000000002"}}}',

This is the error selector with the ABI encoded argument.

yeah it is the original behavior. I wrote it in the info block in errors.md

Oh, then why do we need the hardhat pull request? That's plenty to debug

ah like this. it doesn't show in hardhat node
https://github.com/Unirep/Unirep/pull/234#issuecomment-1331668362
but I think if users use js/ts all the time it can be shown while js/ts returns error

Ah right, now i remember. This is good to know.

I think this is ok to merge. Can you post the script you used to generate the event identifiers?

It was like
const iface = new ethers.utils.Interface(ABI)
for (const error of Object.keys(iface.errors)) {
    console.log(error, iface.getSighash(error))
}


Tab to create new list is broken in @latest

Running the latest versions in the demo seems to break pressing tab on a new line to create a new list.
 "@prezly/slate-lists": "latest",
 "slate": "latest",
 "slate-history": "latest",
 "slate-react": "latest"

Load: https://codesandbox.io/p/sandbox/prezly-slate-lists-demo-forked-967p63?file=%2Fsrc%2FMyEditor.tsx%3A125%2C41

Press Tab on an existing list item

List is indented

Go to a new line and press Tab

Nothing happens

I can confirm this issue started to happen on version 0.86.0.


OSX pkg doesn't seem to have PostGIS

I downloaded the 0.9.0 .pkg for OSX yesterday, and just now I'm trying to create a stream with the following query:
CREATE STREAM test (geom geometry)
To which I get that type "geometry" does not exist. I then try with:
CREATE EXTENSION postgis
And I get:
ERROR:  could not open extension control file "/usr/local/lib/pipelinedb/share/pipelinedb/extension/postgis.control": No such file or directory
It seems like the .pkg does not include the PostGIS extension. Should I build from source then?

We removed PostgGIS from being automatically built and installed with PipelineDB. And pipeline_kafka will also be removed with the next release. It was just complicating our build process and most packaging problems were coming from PostGIS.
You can get PostGIS which is compatible with PipelineDB here: https://github.com/pipelinedb/postgis


pythonbrew off doesn't deactivate the virtualenv (unset the VIRTUAL_ENV env. variable)

because of this while the python is reset back to system python the virtualenv isn't deactivated and hence the confusion that one is still using the pythonbrew python with the virtualenv.

Merging the pull request on #46 (https://github.com/utahta/pythonbrew/pull/46) will automatically(hopefully) solve this issue.


label_maps/ missing

Hi,
It looks like files under label_maps/ are missing. Would it be possible for you to share these files?

Thanks for adding the files!


Add compute environment

As an informatician, before I get started, it would be useful to know how many cores, diskspace, memory, etc.
It would also be useful to know what environments it has been tested in linux, aws, macos, etc.
https://github.com/GenomicMedLab/variation-normalizer-manuscript/blob/1fa8cf94a2fc5ea726efd62732efd29e5d8662e7/README.md?plain=1#L8

This was done in #93


Fix compiler and hlint warnings.

This is not passing CI, I'll look into it.

I've also added a GHC 8.6 build to the Travis matrix.

OK, thanks!


About some settings of constant params

Hi, there.
I notice that the constant number like the number of anchor pixels, negative samples, like in yaml, setting as 256 and 50. Could you please tell me how you calculated these numbers? Are they based on the input size?
Thanks alot!

Hi, thanks for your attention of our work.
We simply obtained these two hyper-parameters from ReCo [ICLR 2021]: https://github.com/lorenmt/reco
It is better to ablate these two parameters if you want to apply our U2PL to new datasets.

Thanks for suggestions! :)


Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/compute/gallery
Module Details
This module was migrated from CARML by @krbar without an owner.
Note: when someone volunteers to be the owner of this module, please reach out to @krbar to for changing the ownership of the existing GitHub teams as well.

Module proposal: https://github.com/Azure/Azure-Verified-Modules/issues/453
PR: https://github.com/Azure/bicep-registry-modules/pull/752

Do you want to be the new owner of this module?
No
Module Owner's GitHub Username (handle)
ReneHezser
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

@matebarabas, @jeanchg if we still need an owner for this, I can take it.

Hi @ReneHezser,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I confirm I wish to own this AVM module and understand the requirements and definition of a module owner

Hi @ReneHezser,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
We just want to ask you to double check a few important things.
Please use the following values explicitly as provided in the module index page:

You must be the owner of the GitHub teams as outlined here.
Please check that your name has been updated in the module index page (this should happen shortly after you confirmed ownership).

You can now take ownership of this module and start improving it as needed! ✅ Happy coding! 🎉
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@ReneHezser, since this module has been migrated by @krbar (Kris Baranek), he's created the required GH teams. Please work with him to take ownership over these teams and let me know in a comment here when it happened. Thanks!

@matebarabas FYI: The GitHub Teams are transferred to @ReneHezser

Thanks, @krbar, for confirming! Closing this issue now.


Arm64 irq

Summary
arm64: simply the vectors
Impact
Testing

@lipengfei28
Please give the detail " what you have changed"

save FPU regs  enter exception and retore exit exception every time
simp the vectors
save sp_el0 enter exception and restore sp_el0 exit exception every time

@lipengfei28 please fix the conflict


Add a sentence about open access to the TOC meeting notes

Fixes #53

I am not totally happy with the wording. However, this brings in the important information and I would suggest some further editing of the section anyway (created #63).

I am not totally happy with the wording. However, this brings in the important information and I would suggest some further editing of the section anyway (created #63).


dotty 0.26.0-RC1, mill 0.8.0: cannot find main when using main functions

I found that with this dotty release, the main class was not automatically found whereas in 0.7.3 and previous version of dotty it was found. I had to add def mainClass = Option("mymain.run") to the build file under the above versions.

Can you provide a small example to reproduce?

Works for me.
$ mill all version example1.run
[1/37] version
0.8.0
[27/37] example1.compile
[info] Compiling 1 Scala source to /tmp/mill-957/out/example1/compile/dest/classes ...
[info] Done compiling.
[37/37] example1.run
example1

This is my dir layout:
$ tree .
.
├── build.sc
└── example1
    └── src
        └── example1.scala

Do you have more than one main defined?

Not in the example1 project. Having said that, I wonder if the out dir was not cleared as I had potentially did at one point have another main defined that was compiled.
If there was more than one main would it report that it could not find a main vs reporting there is more than one main?

It would say something like: "Multiple main classes found [...] please explicitly specify which one to use by overriding mainClass"

Closing this one. If you have any idea want went wrong and the issue re-appears, feel free to comment / re-open this ticket.


Refactor and improve Windows builds

opam was being build with mingw even in the msvc images. Separate mingw and msvc builds into two functions. Separate the msvc build into more build steps. Fix the origin of Install.cmd from avsm/ocaml-dockerfile to ocurrent/ocaml-dockerfile.
See diff at https://github.com/ocurrent/docker-base-images/pull/223.

This requires https://github.com/ocaml/opam/pull/5514.


Images are chaotic

I ran the pre-trained model and the images are pretty incoherent. Did I load something wrong or is this the current state-of-the-art?

I got the same with the pre-trained model

Any solution. I feel that the pre-trained model is just 90 epochs old and the authors showed results after 600 epochs


[BUG] - the setting toggle covering the footer nav.

[BUG] the setting toggle covering the footer nav.
Describe the bug :
the setting toggle in the bottom right side of the HOME page, is covering the the footer nav menu.
how to reproduce the issue :
steps -

Go to The Home page - https://demo.adminkit.io/
Scroll down to the bottom.

Screenshot

if it is alright with you, I would like to resolve this bug.

As the setting toggle element is provided solely for demonstration purposes, we do not consider it a 'bug.' However, we understand that it may be inconvenient for users who are actively utilizing on it in their production environment.
This feature is exclusively available in the Pro version, so we are closing this matter. If you wish to relocate the position of the element, you can achieve this by updating the '/src/scss/3-components/_settings.scss' file.


Update to helm v3.6.0

Issue
https://github.com/rancher/rancher/issues/31145
Problem
Need to upgrade to Helm to 3.5.2+
Solution
Upgrade to latest stable Helm version 3.6.0

Added in the new helm shell trag v0.1.7 so that the shell was also at v3.6.0


The information about hybrid connections being OS-independent is contradictory

See these two texts.
The first one says it is OS-independent:

This enables your apps to access resources on any OS, provided it's a TCP endpoint

The second one makes one think the only relay agent is available for Windows.

The Hybrid Connections feature requires a relay agent in the network that hosts your Hybrid Connection endpoint. That relay agent is called the Hybrid Connection Manager (HCM). To download HCM, from your app in the Azure portal, select Networking > Configure your Hybrid Connection endpoints.
This tool runs on Windows Server 2012 and later. The HCM runs as a service and connects outbound to Azure Relay on port 443.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 645d01fc-eae4-67c0-ef63-77d34d854d5e
Version Independent ID: 516bc8a7-d927-d080-36a6-69ca95686feb
Content: Hybrid connections - Azure App Service
Content Source: articles/app-service/app-service-hybrid-connections.md
Service: app-service
GitHub Login: @madsd
Microsoft Alias: madsd

@ciufudean
Thanks for your feedback! We will investigate and update as appropriate.

@ciufudean Both statements are correct. The client can only run on Windows Server but as long as you have that, you can access resources anywhere on your network as long as it has a TCP endpoint.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Made Premium tier scale out limits clear without reading fine print

Hi @snobu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@yochay can you please verify that this tweak is correct (it probably is, but I am very careful with pricing stuff).

Signed-off on by @Yochay.

@snobu thank you for your contribution to this topic. We do appreciate your help improving the quality of Azure docs.


Error when copying files

When a file being copied has multiple ext for example main.min.css. Currently Tapestry will split the filename by last dot and then slugify the filename. This means that main.min.css becomes output as main-min.css which is not expected behaviour.
A suggested modification would be to have the filename split by first instance of dot and slugify that instead. For example main.min.css would be filename of main and ext of min.css

Fixed by #214


Crawling added to the game as per Gregend's PR #42 request. Ship prices of Diamond and Blockhead tweaked.

Crawling from Nuke Station added to Pax / thanks Gregend for sorting it out. It is a step closer to better combat/PvP-PvE mechanics.

originally requested in PR https://github.com/Pax-Astralis-Dev/pax-astralis-station/pull/42


store-admin application added

store-admin application is added to carbon-store apps. store-admin app now has the functionality to edit configuration files of store and publisher(store.json , publisher.json).Login functionality is also available.
In the sso-idp-config.xml file following ServiceProvider details needs to be added.
<ServiceProvider>
            <Issuer>store-admin</Issuer>
           <AssertionConsumerService>https://localhost:9443/store-admin/acs</AssertionConsumerService>
            <SignResponse>true</SignResponse>
            <CustomLoginPage>/store-admin/controllers/login.jag</CustomLoginPage>
 </ServiceProvider>

As this is PR is no more valid, I'm closing this.


Deployment Failing

Hi Team ,
       When i try to deploy company communicator from PowerShell i get this error please help me out with the next steps

Hi @shreebharaath ,
The above-mentioned issue occurs sometimes during ARM template deployment. Depending on the resource failed, please follow the below steps,
•	App service
•	Data-function : Azure function
•	Prep-function : Azure function
•	Function: Azure function
User can manually fix the issue by following the below steps:
•	Go to the Azure portal  Resource group which got created  App Service
•	Go to the "Deployment center" section of the app service that failed to deploy.
•	Click on "Sync" to restart the deployment.

•	Post successful deployment of app service the Status will change as “Success”.
•	If you don’t see the Git URL mapped to app service, then please add External Git repo URL and then click on Sync.
•	Repeat the same steps for the failed Azure functions as well.
Since deployment failed, users may not have received the authorBotId, userBotId  and appDomain values at the end of the deployment. To find them, go to the "Configuration" section of your App Service.
•	authorBotId : It can be found in the "AuthorAppId" field of your configuration.
•	userBotId : It can be found in the "UserAppId" field of your configuration.
•	appDomain : It is the value in the "AzureAd:ApplicationIdURI" field of your configuration without the "api://" e.g. appName.azurefd.net. For the following steps, it will be referred to as %appDomain%.
From here you can continue with the further  steps of deployment.

Hi @gsv022
I have already checked it there is nothing deployed

Hi @shreebharaath ,
To redeploy the app service issue please follow the below steps:

Click on Source and select external git.

Click Save and then click on sync.

Another way is to repeat all the deployment procedure.

Hi @shreebharaath , Please let us know if the issue is resolved and we are good to close this request.

Hi @v-royavinash ,
                I deleted all the resource group and redeployed from the beginning it worked . But i am not sure how to solve the error if reoccurs again

Hi @shreebharaath,
The steps mentioned above will fix the issue. If you encounter the issue later please reach out to us.
For now closing the issue.

Hi @gsv022 ,
            Okay hope i don't face anymore issues thanks for the support @gsv022


Feedback for “Tailwind CSS”

Regarding this page: https://nextra.site/docs/guide/advanced/tailwind-css
My install does not have an _app.js or globals.css so I can't simply "follow the official Tailwind CSS documentation for Next.js to set up Tailwind CSS". I figure I need to add an _app.js but not sure how it should look if the only purpose is adding tailwindcss via globals.css.

I got it to work by adding this _app.ts in pages dir:
import '../globals.css'

export default function Nextra({ Component, pageProps }) {
  return (
    <>
      <Component {...pageProps} />
    </>
  )
}

@ajthinking solution worked for me !!


Uncaught (in promise) TypeError: Invalid attempt to destructure non-iterable instance(…)

Hi, I'm trying to use embed.js in a meteor.js application. I've called
require('es6-promise').polyfill();
import EmbedJS from 'embed-js';

and I've copied the div and js code from the youtube example, however I receive the error:

Uncaught (in promise) TypeError: Invalid attempt to destructure non-iterable instance(…)

I'm curious if you have received this error before and if you know what steps I can take to resolve this issue. Thanks!

Can you provide the whole error stack ? That will help

Hey ritz, thanks for the reply. I have a misconfiguration issue and I'll let you know if I run into further problems.


Added NINO page to request a TRN journey

Context
We’re building an interim solution that replaces Galaxkey for requesting a TRN for NPQ participants.
Changes proposed in this pull request
Include a summary of the change.
Guidance to review
Add a National Insurance number page (following the [Request a TRN] Figma designs) under /request-trn/national-insurance-number
If the question is not answered, show an error ‘Tell us if you have a National Insurance number’. If ‘Yes’ is answered but the entered NINO is empty, show an error ‘Enter your National Insurance number’. If the entered NINO is not valid, show an error ‘Enter a valid National Insurance number’.
When the form is valid and Continue is clicked, store the ‘has NINO’ and NINO on the FormFlow instance and redirect to /request-trn/address if no NINO was entered or /request-trn/check-answers otherwise.
If the evidence question has not yet been answered, redirect to /request-trn/identity.
Checklist

[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Get a TRN - NINO page


syan/batch upload

PR in progress for batch upload mode. Endpoint currently working, testing in progress.
TODO:

re-write the generic parser to use the batch endpoint

Closing Sample metadata parsers can fail midway through (and are slow) #130

Generic parser now uses batch endpoint for samples and sequences (not analyses).
Example return value for a two sample insert/update.
{'808': {'sample_id': 'CPGLCL8088', 'sequences': [1044]}, '809': {'sample_id': 'CPGLCL8096', 'sequences': [1043]}}

All comments addressed. PR open for re-review


Investigate 502 error from api

The error could not be reproduced with the deloyed or local ensuresec API. The endpoint tmf-api/slaManagement/v1/listener/slaViolationCreateEvent was spamed 30-40 minutes but still working fine. The issue is most likely due to restrained server ressources on the free heroku tier.


Class "Composer\InstalledVersions" not found

Hello
Getting this error for composer 1. You should do a composer version control first. Sorry I can't use it.
Class "Composer\InstalledVersions" not found

Hey @akiftezcan38 , the bug should be fixed now :) Please try again!


Upgrade dependencies to more current versions, including react 16

I couldn't run the starter app locally until I upgraded the dependencies

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ryanrogalski sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This pull request fixed the project for me!
Note. I also had to use npm as yarn seems to do something strange when installing dependencies (see here) so make sure to include both the package-lock.json as well as the package.json.

@jpdenford glad to hear it 🙏🏻


Fix cannot use gamePin (type string) as type int and add gopass to installation section in README

What are you doing? The gamePin error you are seeing shouldn't be happening. It almost looks like you updated some files in the repo, but not the main kahoot library, where NewConn now takes a string instead of an int.

NewConn should take a string, but it did not which caused the error (gamePin is a string), I am not sure why this is happening, but it also did with a fresh clone of kahoot-hack
I will try it in a fresh docker with no other Go packages to see if that was a problem

This seems very strange

What am I doing, indeed.
Apparently, I had an older copy of kahoot-hack in my GOROOT which wanted gameId as an int.


Running on the latest version on bungeecord.

The plugin still works it just gives this issue!
https://haste.coolcomputers.info/tavosadose.sql

try using 5.0.1 it just released should work on the latest waterfall / bungeecord builds what fork of those are you using

Using on bungeecord itself no fork. Just the spigot bungeecord. Also i will try 5.0.1

No change i still have the issue.

No change i still have the issue.

Just use waterfall then

please check your config some things are missing from the config so just regenerate the config on 5.0.1 and then edit it to your specific needs and then let me know if its fixxed im running it on the latest waterfall so try using that

I should not have to use waterfall in order to use this plugin in my opinion i should be able to use bungee since it builds onto bungee.

Same issue when running 5.0.1 on waterfall...

I am also getting this on waterfall but not bungee.
It also no longer sends me to my queue server it just rams through to the main server.
https://haste.coolcomputers.info/tufovivese.properties


ReplicateBlob on deletion: add the unit test for compacted blob.

Add the unit test that the source blob is deleted and compacted.
ReplicateBlob will fail with Blob deleted.
The DeleteOperation fails with its original error.

will take a look and get back


Documentation link broken on readme

Because of the refactor of the docs to change js-sevices to javascript, and java-services to java, the docs link in readme.md must be updated to:
https://developer.lightbend.com/docs/akka-serverless/javascript/

Fixed in #36


Peer review - Week #3 - EJS code

Review

Smart that you're using SVGs instead of images! 🔥
Form in order.ejs is semantic & clean

No need to solve anything here 😎🔥

Thanks for the feedback 👍 😄


DateTime Recognizer Doesn't Recognizer MM-DD-YYYY H:MMam/pm to/until MM-DD-YYYY H:MMam/pm

When you attempt to recognize in LUIS or in the Recognizer Nuget the following query (any datetime range with indicated format will repro)
12-04-2019 6:00am until 12-05-2019 5:00pm
You will not get a correct recognizer result
timex (2019-12-05T00,2019-12-05T04,PT4H)
type datetimerange
start 2019-12-05 00:00:00
end 2019-12-05 04:00:00
timex (2019-12-05T12,2019-12-05T16,PT4H)
type datetimerange
start 2019-12-05 12:00:00
end 2019-12-05 16:00:00
Or at least I cannot make sense of it. It doesn't even talk about the 4th anywhere I can tell.
It can recognize 12-04-2019 6:00am just fine by itself
It can recognize 12-05-2019 5:00pm just fine by itself
Steps to reproduce the behavior:

Use Recognizer Nuget in .NET CORE application
var result = Microsoft.Recognizers.Text.DateTime.DateTimeRecognizer.RecognizeDateTime(turnContext.Activity.Text, "en-us");
     foreach (var r in result)
     {
         foreach (var item in r.Resolution)
         {
             if(item.Value is List<Dictionary<String,String>> dictionaryList)
             {
                 foreach (var listItem in dictionaryList)
                 {
                     foreach (var kvp in listItem)
                     {
                         System.Console.WriteLine($"{kvp.Key} {kvp.Value}");
                     }
                 }
             }
         }
     }

Expected behavior
It should provide a datetimerange that is accurate
timex (2019-12-04T06:00,2019-12-05T17:00,PT35H)
type datetimerange
start 2019-12-04 06:00:00
end 2019-12-05 17:00:00
This is possible if I change the format of the datetime from MM-DD-YYYY to YYYY-MM-DD
Sample input/output
Doesn't work: 12-04-2019 6:00 am until 12-05-2019 5:00pm
Does work: 2019-12-04 6:00am until 2019-12-05 5:00pm

Platform: .NET
Environment: Nuget Microsoft.Recognizers.Text.DateTime, LUIS
Version of package 1.1.4, not sure about what LUIS is using.

Additionally it seems to be fine if I use / instead of - to separate the date parts.
12/04/2019 vs 12-04-2019

Upgraded to package 1.2.9 still same result.

It appears that the BaseDateTimePeriodParser.MergeDateWithSingleTimePeriod finds that there is a time "00am until 12" and so then it doesn't try the BaseDateTimePeriodParser.MergeTwoTimePoints which does provide the correct result.
Not really sure how you would determine one over the other is correct.


Support PathLike input in save_to_disk / load_from_disk

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Double flatcar VMs boot timeout

What type of PR is this?
/kind bug
What this PR does / why we need it:
This is an attempt at fixing the current timeout issue.
Which issue(s) this PR fixes:
None
Does this PR have test?
Flatcar e2e tests
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Codecov Report

Merging #1048 (c81119e) into main (e3e77aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   50.09%   50.09%
=======================================
  Files          42       42
  Lines        4779     4779
=======================================
  Hits         2394     2394
  Misses       2299     2299
  Partials       86       86

superseded by https://github.com/kubernetes-sigs/security-profiles-operator/pull/1047


Add ability to wrap lines

Wrapping lines in the editor should be optional and disabled by default. It should be surfaced as an option in some general settings.

Hi, I think I can take this, but I was checking and didn't figure out where to add the setting for the user. If you could guide me, I could finish it.

@GaboFDC I suppose it could be a checkbox menu item, under "Edit"

@sebbrudzinski @GaboFDC  This issue is not yet implemented/closed, can I take the issue?

@sabbir044 There was no activity in this ticket for over half a year, so feel free to take it :)

@sebbrudzinski I am having a bit of problem here. I can add menuitem in menu and can response on click of menuitem using annotations (like other menuitems in menu package). But I want to add a JCheckBoxMenuItem but I dont know how I can do that. There are lack of resource in google and I am following The Definitive Guide to Netbeans Platform 7, where I did find anything to add  JCheckBoxMenuItem. Can you help me to find good resource to learn Netbeans Platform or any source/project where I can look for these kind of things.
I have another idea that I may skip JCheckBoxMenuItem, instead add a normal menu item with a select icon. I will only show the icon when wrap line is enabled. But problem is, I do not no where to initialize the icon when application starts (to set last sessions wrap line settings).

@sabbir044 I agree that NetBeans Platform documentation is hard to browse... I'm often having troubles finding something there as well. I've managed to find some links that seem to have what we want, but they are pretty old... I'm not sure how much has changed since NetBeans Platform 6.X but it's worth to give it a try:

https://blogs.oracle.com/geertjan/entry/jradiobuttonmenuitem_jcheckboxmenuitem_on_the_netbeans
https://dzone.com/articles/netbeans-platform-tip-booleans

Feel free to let me know if you are still stuck.

Thanks for resources. Implemented the feature :)

Great! I've merged the pull request so I'll close this issue now. Thanks @sabbir044