Train new model for spinal cord segmentation

Context
SCT's current most used function for spinal cord segmentation is sct_deepseg_sc. With the recent introduction of sct_deepseg, we would like to create a new spinal cord segmentation model that would ultimately replace sct_deepseg_sc.
Motivations

sct_deepseg will replace all deep learning functions in SCT, facilitating the maintenance of the other individual CLIs and specific APIs.
This replacement will enable us to get rid of TensorFlow dependency (given that sct_deepseg depends on Pytorch)
sct_deepseg will leverage ivadomed for the following tasks:

Image pre-processing (resampling, splitting into patches, etc.)
Image post-processing (fill holes, threshold, small object removal, etc.)

Specifications

A current limitation of sct_deepseg_sc is that a specific model was trained for each contrast (T1, T2, T2*, DWI). We would like to replace this approach, and have a single model only, trained with all contrasts. Several possibilities to explore:

Pool all the contrasts and train a single-model using U-Net architecture
Do what is listed in the previous point, with the FiLM architecture, where the contrast is used to modulate FiLM layers
Do what is listed in the previous point, with the HeMIS architecture, allowing to input multiple contrasts at once (possibly more robust), and allowing for missing contrasts. This point is under investigation by @leandervaneekelen (https://github.com/ivadomed/ivadomed/projects/3)

Another limitation is that the segmentation result varies across contrasts. For example, the segmentation is smaller on the T1 vs. on the T2, as discussed in this forum post.
We could consider joining the efforts of @leandervaneekelen and making it a multi-class segmentation project (cord & CSF).
We could consider using a softseg training, which would potentially provide a more accurate computation of CSA down the line.
Implement an uncertainty feature.
Make sure to include a variety of "bad" datasets (artifacts)
Make sure to include data with pathologies (MS, compression, etc.)

List of tasks

Identify the datasets to consider

https://github.com/spine-generic/data-multi-subject (public)
sct_testing/large (private)

Organize the datasets with git/git-annex so the SHA can be incorporated in the training script, so that the model can be reproduced.
Check ground truth segmentations

Especially: update the ones for the T1w contrast (under-segmented).
We adopt a "deep active learning" strategy: start training a "good" model with little data, then apply it to a bigger pool, then correct segmentations in a few data, then re-train with bigger pool, etc.

Establish a procedure for co-registering all existing contrasts, for each subject, in a maximum number of dataset. Also see https://github.com/ivadomed/ivadomed/issues/471.

* Check ground truth segmentations

  * Especially: update the ones for the T1w contrast (under-segmented).
  * We adopt a "deep active learning" strategy: start training a "good" model with little data, then apply it to a bigger pool, then correct segmentations in a few data, then re-train with bigger pool, etc.

* Establish a procedure for co-registering all existing contrasts, for each subject, in a maximum number of dataset. Also see #471.

A suggestion of "First step" would be to (maybe before re doing the GT / co registration):

train a basic 2D Unet on sct_testing/large + spine-generic with "Pool all the contrasts" strategy
run this model on an independent, heterogeneous and challenging dataset made of images with lesions, severe compressions and exotic contrasts
identify the flaws of this model and iteratively brainstorm solutions for each of them: eg (1) T1w undersegmentation --> manually correct T1w GT ; (2) difference of performance across contrasts --> let's help the network with contrast info via FiLM... helpful? if not, train per contrast? etc. ; (3) improvement needed in cord delineation --> use a soft training ; (4) CSA measures vary across contrast --> use co registered GT during training when possible.

thanks @jcohenadad.
I have some trouble with VPN access to polymtl. I assume when this is resolved I will also have access to sct_testing/large (not sure where this is located yet).
I had a chat with @andreanne-lemay today and she informed me there is no need to deal with the sct toolbox repo for the training part. I will focus only on Ivadomed, correct?
I'll start with the training on my laptop and when the VPN and access to sct_testing is ready I will move to Rosenberg and follow @charleygros 's suggestions.
One last thing I will probably need:

run this model on an independent, heterogeneous and challenging dataset made of images with lesions, severe compressions and exotic contrasts

You have a list of these datasets, or we will have to manually search?

I have some trouble with VPN access to polymtl. I assume when this is resolved I will also have access to sct_testing/large (not sure where this is located yet).

yup! i'll just need you to sign an NDA (i'm working on it)

I had a chat with @andreanne-lemay today and she informed me there is no need to deal with the sct toolbox repo for the training part. I will focus only on Ivadomed, correct?

correct

I'll start with the training on my laptop and when the VPN and access to sct_testing is ready I will move to Rosenberg and follow @charleygros 's suggestions.

👍  note that you can also have access to compute canada-- in fact, i would like that the lab start using this amazing ressource-- one collateral benefit is that when rosenberg is down, research does not stop

One last thing I will probably need:

run this model on an independent, heterogeneous and challenging dataset made of images with lesions, severe compressions and exotic contrasts

You have a list of these datasets, or we will have to manually search?

it's under sct_testing/large. We need to curate it. A meeting will be needed to talk about that. For now there is always the spine-generic dataset which is available

I tried to start working on the training from my laptop but it runs out of RAM (16GB). Not sure if you want me to spend time trying to optimize the RAM resources during training. Let me know if you want me to dig into this.
Charley sent me a video with instructions on how to use Rosenberg but to my understanding I won’t have access to it until I hear back regarding the NDA and a Grames account and Rosenberg login credentials are issued to me. Through that video I see that I will also need access to the GPU sheet to block GPU resources.
As a last resort I just applied for a compute Canada account with you as my sponsor. My previous accounts are affiliated to my previous labs and are not valid.

I tried to start working on the training from my laptop but it runs out of RAM (16GB). Not sure if you want me to spend time trying to optimize the RAM resources during training. Let me know if you want me to dig into this.

no, that's a waste of time, i think rosenberg should be available now

Charley sent me a video with instructions on how to use Rosenberg but to my understanding I won’t have access to it until I hear back regarding the NDA and a Grames account and Rosenberg login credentials are issued to me. Through that video I see that I will also need access to the GPU sheet to block GPU resources.

NDA: done
GRAME: should be done, if not pls cc me in conversation with JS
GPU sheet: @alexfoias can you pls grant access

As a last resort I just applied for a compute Canada account with you as my sponsor. My previous accounts are affiliated to my previous labs and are not valid.

i saw and approved 👍

I would encourage you to join forces with @leandervaneekelen on https://github.com/ivadomed/ivadomed/issues/471, and especially the next step: https://github.com/ivadomed/ivadomed/issues/471#issuecomment-722006121. Having two people working on this critical pipeline will be very useful. At the end of the day, what matters the most is having high quality training data and ground truth, and this is what this pipeline is about.

Hi @alexfoias, I can open the GPU sheet, but I can still not edit it. Can you please grant me access?
@jcohenadad 👍
I will finally start working on this this week since my Rosenberg credentials were granted last Friday

@mpompolas I added you on the google calendar. Sorry for the delay.

@mpompolas You can not comment/suggest on the Google document.

Just checked it and it works. Thank you very much @alexfoias

run this model on an independent, heterogeneous and challenging dataset made of images with lesions, severe compressions and exotic contrasts

hey @charleygros @jcohenadad , you have any suggestions for which datasets to test the models on?

hey @charleygros @jcohenadad , you have any suggestions for which datasets to test the models on?

Yep good question: I feel there are data in sct_testing/large which are quite exotic / heterogeneous / challenging!
What I would recommend would be to:

keep some centers aside, for testing only! For this, there is the param center_test in the config file! In particular, I would recommend the "center" sctUsers, which is not really a center per se --> data sent by SCT users, often because the current segmentation tools were failing --> Perfect to test the news develloped model, to challenge it!
keep some patient data in the testing dataset only and look at the model performance specifically for these patients (both quantitatively and qualitatively). Just to name a few: DCM --> twh, ALS --> paris2017Pradat, MS: bwh
we could also think of a split per disease, using the method param in split config, using pathology in participants.tsv
to really control the split, we could refine the split "manually" and use the fname_split param (here). Not sure if we need to go "that far", but possible.
more challenging data? we could ask @lrouhier for high compression data and @andreanne-lemay for SC with tumors.

So far, the strategy is the following:

So far, we focus on simple model (no fancy FILM, etc.) and we compare with sct_deepseg_sc
We need to establish a reproducible framework for comparing performance with sct_deepseg_sc

This repos would be hosted on a new repos here: https://github.com/sct-pipeline

Action task

@charleygros identify the list of subjects that were used for sct_deepseg_sc
@lrouhier find the segmentations from the DCM project (AOSpine data)

* So far, we focus on simple model (no fancy FILM, etc.) and we compare with `sct_deepseg_sc`
* We need to establish a reproducible framework for comparing performance with `sct_deepseg_sc`
  * This repos would be hosted on a new repos here: https://github.com/sct-pipeline

Agree! With the defaults param of sct_deepseg_sc --> output violin plots with Dice!
Would be good to able violin plots for the specifics:

per contrast_groups (i.e., the ones of sct_deepseg_sc, so t1, t2, t2s, dwi)
for specific datasets: subset of spineGeneric, subset of DCM patients (see pathology column in `participants.tsv), subset of ALS, subset of MS patients

Suggestion for training/testing splitting:

Datasets to use: large + spineGeneric
Data used to train sct_deepseg_sc (I will send this list today) = subset of large --> to include into the training dataset of the new model
New data (i.e., spineGeneric + data from large which were not used for sct_deepseg_sc) --> Do a random split 60% for training validation and 40% for testing. Make sure that the testing includes some MS, ALS, DCM data.

So in summary:

Training data = training data from sct_deepseg_sc + 60% of new data
Testing data = 40% of new data

@jcohenadad & @mpompolas : What are your thoughts?

sounds great. but once we want to ship a model for production, we want to use 100% for training, right?
datasets: i would also add part of UK biobank

sounds great. but once we want to ship a model for production, we want to use 100% for training, right?

Absolutely! The above message aims at drawing a splitting strategy to ensure that the trained model is at least as good as sct_deepseg_sc via a fair comparison (i.e., not using old_training_data to do our present testing).
So basically: looking at the results of this comparison:

while (ivadomed_model less good than sct_models) --> redesign more complicated approach: e.g., hyperparam opt? using FiLM? using one contrast per model?
then (i.e., ivadomed_model as good or better than sct_models) --> retrain the selected ivadomed using ALL data with available GT

datasets: i would also add part of UK biobank because these are brain scans. Also we have the manual segs 😁

Oh great, updating above message.

@mpompolas : Here the dataset used to train sct_deepseg_sc:
/home/GRAMES.POLYMTL.CA/chgroc/duke/projects/ms_seg/sct_deepseg_sc_info/dataset.pkl
This pandas contains a column named train_valid_test with 1 for train, 2 for validing, 3 for testing.
Note: the subject names are slightly different from the one in large because it has been done before we moved to the BIDS convention! Please let me know (or @alexfoias ?) if you need some help with that!

Here the dataset used to train sct_deepseg_sc:
duke/projects/ms_seg/sct_deepseg_sc_info/dataset.pkl

can we move this to the deepseg_sc model repos? and add in the README this relevant information

this is great. thanks for the thorough explanation.
Two clarifications:

when I checked the spinal cord toolbox I had to indicate the contrast that is being tested (t1, t2, t2s), so I assumed there was a separate model trained for each modality.
Is there also a model that was also trained on all of them that we could compare with a potential "one to rule them all" model?

The sc_deep_seg was trained only on the entire or part of the large dataset (no spinegenereric)?

1. when I checked the spinal cord toolbox I had to indicate the contrast that is being tested (t1, t2, t2s), so I assumed there was a separate model trained for each modality.

Correct, one model per contrast (t1, t2, t2s, dwi). In the above dataframe there is a column called contrast which indicates the model_contrast for which this image has been used to, eg t2s --> this image has been used to train the t2s model.

   Is there also a model that was also trained on all of them that we could compare with a potential "one to rule them all" model?

We did preliminary experiments where we trained a model with all images together. These preliminary experiments suggested that the model with all contrasts together was less good than the models trained per contrast. So we focused on training models per contrast.
I think we should do the comparison with the models in sct_deepseg_sc since there are the ones we want to replace!

2. The sc_deep_seg was trained only on the entire or part of the `large` dataset (no spinegenereric)?

Only on a part of large (see here). spinegeneric was not used.

can we move this to the deepseg_sc model repos? and add in the README this relevant information

Done, here.

Done, here.

@charleygros I want to run testing on the pretrained deepseg_sc models you mentioned but I have trouble loading them with keras:
from tensorflow.python.keras.models import load_model

file = '/home/nas/PycharmProjects/deepseg_sc_models/t2_sc.h5'
model = keras.models.load_model(file)

Python 3.8.5 (default, Sep  4 2020, 07:30:14)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.18.1 -- An enhanced Interactive Python. Type '?' for help.
PyDev console: using IPython 7.18.1
Python 3.8.5 (default, Sep  4 2020, 07:30:14)
[GCC 7.3.0] on linux
In[2]: runfile('/home/nas/PycharmProjects/ivadomed-personal-scripts/convert_sct_models_to_onnx.py', wdir='/home/nas/PycharmProjects/ivadomed-personal-scripts')
2021-01-18 15:26:54.820500: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
Traceback (most recent call last):
  File "/home/nas/.local/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3417, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-2-4aed73caf3e8>", line 1, in <module>
    runfile('/home/nas/PycharmProjects/ivadomed-personal-scripts/convert_sct_models_to_onnx.py', wdir='/home/nas/PycharmProjects/ivadomed-personal-scripts')
  File "/home/nas/Programs/pycharm-2020.2.3/plugins/python/helpers/pydev/_pydev_bundle/pydev_umd.py", line 197, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "/home/nas/Programs/pycharm-2020.2.3/plugins/python/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/home/nas/PycharmProjects/ivadomed-personal-scripts/convert_sct_models_to_onnx.py", line 15, in <module>
    model = load_model(file)
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/saving/save.py", line 182, in load_model
    return hdf5_format.load_model_from_hdf5(filepath, custom_objects, compile)
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/saving/hdf5_format.py", line 177, in load_model_from_hdf5
    model = model_config_lib.model_from_config(model_config,
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/saving/model_config.py", line 55, in model_from_config
    return deserialize(config, custom_objects=custom_objects)
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/layers/serialization.py", line 171, in deserialize
    return generic_utils.deserialize_keras_object(
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 354, in deserialize_keras_object
    return cls.from_config(
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/engine/training.py", line 2238, in from_config
    return functional.Functional.from_config(
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 616, in from_config

Is there another package or command you use to load it?
I can load it with h5py so the files are not corrupt.

Done, here.

@charleygros I want to run testing on the pretrained deepseg_sc models you mentioned but I have trouble loading them with keras:
from tensorflow.python.keras.models import load_model

file = '/home/nas/PycharmProjects/deepseg_sc_models/t2_sc.h5'
model = keras.models.load_model(file)

Python 3.8.5 (default, Sep  4 2020, 07:30:14)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.18.1 -- An enhanced Interactive Python. Type '?' for help.
PyDev console: using IPython 7.18.1
Python 3.8.5 (default, Sep  4 2020, 07:30:14)
[GCC 7.3.0] on linux
In[2]: runfile('/home/nas/PycharmProjects/ivadomed-personal-scripts/convert_sct_models_to_onnx.py', wdir='/home/nas/PycharmProjects/ivadomed-personal-scripts')
2021-01-18 15:26:54.820500: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library libcudart.so.10.1
Traceback (most recent call last):
  File "/home/nas/.local/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3417, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-2-4aed73caf3e8>", line 1, in <module>
    runfile('/home/nas/PycharmProjects/ivadomed-personal-scripts/convert_sct_models_to_onnx.py', wdir='/home/nas/PycharmProjects/ivadomed-personal-scripts')
  File "/home/nas/Programs/pycharm-2020.2.3/plugins/python/helpers/pydev/_pydev_bundle/pydev_umd.py", line 197, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "/home/nas/Programs/pycharm-2020.2.3/plugins/python/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/home/nas/PycharmProjects/ivadomed-personal-scripts/convert_sct_models_to_onnx.py", line 15, in <module>
    model = load_model(file)
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/saving/save.py", line 182, in load_model
    return hdf5_format.load_model_from_hdf5(filepath, custom_objects, compile)
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/saving/hdf5_format.py", line 177, in load_model_from_hdf5
    model = model_config_lib.model_from_config(model_config,
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/saving/model_config.py", line 55, in model_from_config
    return deserialize(config, custom_objects=custom_objects)
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/layers/serialization.py", line 171, in deserialize
    return generic_utils.deserialize_keras_object(
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/utils/generic_utils.py", line 354, in deserialize_keras_object
    return cls.from_config(
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/engine/training.py", line 2238, in from_config
    return functional.Functional.from_config(
  File "/home/nas/.local/lib/python3.8/site-packages/tensorflow/python/keras/engine/functional.py", line 616, in from_config

Is there another package or command you use to load it?
I can load it with h5py so the files are not corrupt.

@mpompolas : if you use the SCT python it should work (as sct_deepseg_sc does). Or directly using sct_deepseg_sc and batch script? Would it be useful?

@mpompolas : if you use the SCT python it should work (as sct_deepseg_sc does). Or directly using sct_deepseg_sc and batch script? Would it be useful?

Thanks @charleygros. Doing the loading through SCT should work.
I just want to load the SCT trained models and convert them to .onnx or .pt so I can do a comparison with the newly trained models.

Thanks @charleygros. Doing the loading through SCT should work.
I just want to load the SCT trained models and convert them to .onnx or .pt so I can do a comparison with the newly trained models.

Thanks @charleygros. Doing the loading through SCT should work.

Yes, I think so too!

convert them to .onnx or .pt so I can do a comparison with the newly trained models.

Why do you need to convert them to this format? (Not sure if that's possible (I never tried it tho).)

Thanks @charleygros. Doing the loading through SCT should work.

Yes, I think so too!

convert them to .onnx or .pt so I can do a comparison with the newly trained models.

Why do you need to convert them to this format? (Not sure if that's possible (I never tried it tho).)

Why do you need to convert them to this format? (Not sure if that's possible (I never tried it tho).)

Lazy way to use the ivadomed toolbox for the training with the pretrained SCT models (check issue 643)
I thought of converting the trained SCT model to "~/logs/best_model.pt" and run the testing. This would create automatically a ~/logs/results/evalueation3Dmetrics.csv and easily do the the violinplots comparisons we discussed about previously.
Since this seems to be more complicated than I thought, I will just use sct_deepseg on the testing set and manually create the required files.

Why do you need to convert them to this format? (Not sure if that's possible (I never tried it tho).)

Lazy way to use the ivadomed toolbox for the training with the pretrained SCT models (check issue 643)
I thought of converting the trained SCT model to "~/logs/best_model.pt" and run the testing. This would create automatically a ~/logs/results/evalueation3Dmetrics.csv and easily do the the violinplots comparisons we discussed about previously.
Since this seems to be more complicated than I thought, I will just use sct_deepseg on the testing set and manually create the required files.

I thought of converting the trained SCT model to "~/logs/best_model.pt" and run the testing. This would create automatically a ~/logs/results/evalueation3Dmetrics.csv and easily do the the violinplots comparisons we discussed about previously.

OoooOOoooo I see! That was clever!!

Since this seems to be more complicated than I thought, I will just use sct_deepseg on the testing set and manually create the required files.

Ok, makes sense to me!

I thought of converting the trained SCT model to "~/logs/best_model.pt" and run the testing. This would create automatically a ~/logs/results/evalueation3Dmetrics.csv and easily do the the violinplots comparisons we discussed about previously.

OoooOOoooo I see! That was clever!!

Since this seems to be more complicated than I thought, I will just use sct_deepseg on the testing set and manually create the required files.

Ok, makes sense to me!


Downloaded models not showing after VSCode restart

Downloaded models not showing after VSCode restarted.  AI Toolkit Download buttons are enabled again for already downloaded models , does not appearing in Playground as well

This is resolved. Issue was I updated the "Playground Agent Model Storage" in AI Toolit settings path to different location. After copying models from ".aitk" to my set path, its working now.


Why use array_view when std::span exists?

Hey folks!
I was looking through your code and I noticed your use of your own array_view class, which seems to be an implementation of C++20's std::span.
This raises the question of which standard you guys are targeting, since there does not appear to be much to indicate it.
I have noticed your discord.py which seems to imply C++20 for linux and C++17 otherwise.
I would also like to ask if such perhaps nit-picky glances at your code is welcome, or if it is unnecessary.
Thanks,
Johny

Hey Johny!
Thanks for giving the code a read and this is definitely welcomed feedback.
At the moment, we still need to support C++17 on some of our platforms so we couldn't use std::span but we would like to migrate to it eventually.
In retrospect, maybe we should have a dave::span implementation that matches the standard to make migration easier.
We weren't able to open source our build files in this first round but we're planning on generalizing them so they can be added to this repo.


Revert syntax for lambda

What problem did you solve?
Closes #656
#647 introduces some bug in syntax. This PR reverts the part that causes syntax highlighting to stop working.
@Ikuyadeu I suggest that we do a quick release for this.

Can confirm that this fixes syntax highlighting for me (Windows 10, vscode 1.57.0-insider).


code coverage improvement

[ ] 92.68% to 100% coverage
[ ] less time dependent
[x] coverall

0.3.2
Statements   : 95.87% ( 464/484 )
Branches     : 82.22% ( 148/180 )
Functions    : 91.3% ( 105/115 )
Lines        : 95.68% ( 421/440 )

0.8.1 96.52%


Nice work!!! is impossible to input a image and video ?

Nice work

Hey. potentially it is possible, but not on the current version. Maybe for model 5B it will be available.


Kmesh: disable kmesh for waypoint pod

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm
/approve


Verify pertinence of using GetPrimitiveArrayCritical

The Java_org_kortforsyningen_proj_Transform_transform method gets an access to the Java double[] array by a call to the JNI method GetPrimitiveArrayCritical. Compared to the more usual GetDoubleArrayElements method, the "critical" version increases the chances to avoid an array copy, but at the cost of some restrictions. We should verify if it really avoids a copy. If not, GetDoubleArrayRegion would be a better alternative.

Tests suggest that GetPrimitiveArrayCritical(…) has the desired behaviour (to not copy data) at least on my Linux machine. Consequently we do not implement the alternative approach based on GetDoubleArrayRegion(…) for now, but we log a warning if a copy has been done so we know that a particular platform may have a performance issue. The logging message is:

Java Native Interface (JNI) had to copy coordinate array on this platform. This constraint may reduce performance.

The logging level is DEBUG (map to FINE in java.util.logging).
Note: reading the documentation of IBM virtual machine and Android suggests that the use of GetPrimitiveArrayCritical instead of GetDoubleArrayElements really increase the chances of getting a direct access to the Java array elements.


python3Packages.django-phonenumber-field: 7.2.0 -> 7.3.0

Description of changes
And use the package from PyPI since the compiled gettext files have been removed from the repository.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 280237 run on x86_64-linux 1

12 packages built:

python310Packages.django-payments
python310Packages.django-payments.dist
python310Packages.django-phonenumber-field
python310Packages.django-phonenumber-field.dist
python310Packages.django-two-factor-auth
python310Packages.django-two-factor-auth.dist
python311Packages.django-payments
python311Packages.django-payments.dist
python311Packages.django-phonenumber-field
python311Packages.django-phonenumber-field.dist
python311Packages.django-two-factor-auth
python311Packages.django-two-factor-auth.dist


res.clearCookie() don't work in supertest

Hello,
It seems there is a problem to remove a cookie. On logout I removed 'remember_me' cookie. And I run the following functional test :
I simplify the test. The second request failed because I have a status 200 because remember_me cookie always exist and server reconnect.
   browserSession[0]
    .post('/auth/logout')
    .expect('set-cookie', /remember_me=; Path=\//)
    .end(function(err, res){
        browserSession[0]
            .get('/auth/status')
            .expect(401, done);
    });

Thanks !

Did you ever find out the reason for this problem? Was there a solution?


Clarify difference between Partial and Full verification

Purpose of the PR

Clarifies the difference between Partial and Full verification in Primary, demo Primary, and demo Director code. This mostly revises docstrings, but also simplifies some demo code conditionals.
In the demo, strips all CAN-related communication code intended for a CAN-based Partial verification Secondary.

These are in the same PR because of overlap, but they're fairly related.
Motivation
Initial motivation for this comes from the fact that this code seemed to be confusing to students. I'm much happier with the clarify of the result, but I'm sure there are related bits I can clarify. As for the CAN contents, less clutter is better, since this wasn't being used.

Coverage remained the same at 96.186% when pulling 6c05bd3fa13fd97c82ee03aacafd0e2ed8a2ce2d on awwad:clarify_partial_vs_full_and_strip_can into f2f5bbc215c18d887def32a3b6c21a8fe9c60966 on uptane:develop.

The tree is getting a bit messy, so I'm going to merge this because the demos and tests all worked, and it's mostly documentation changes. I'll still want the review sometime, but there's no rush. (:


get chef info on login. Added BioCtrl

waiting for service to be implemented, but this can be already reviewed

except a few comments, all good :+1:

@dbaq, i've incorporated your feedback, please review again

@valdrinkoshi I just have a doubt about 2 run function, can you check please?

yes they are both executed, i've tested it. If you prefer i can put it before declaring the states

I am just not used to it. No big deal. Let's merge it! :beers:

\o/


Secure clusters

Does this work for secure clusters?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 332adf66-c461-392a-022c-6dc9e71fcf05
Version Independent ID: c5985abe-ddc1-11e8-a6dc-f86f76ec073b
Content: Azure Service Fabric application resource model
Content Source: articles/service-fabric/service-fabric-concept-resource-model.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

Thanks for the question! We are investigating and will update you shortly.

@javaadpatel I don't see anything that would cause issues using this with a secured cluster. Are you running into any issues?

Hi Micah,
I'm not running into any issues, I was just curious because I didn't see
anywhere where you specify the certifcate to use, and usually when I
interacted with my secure cluster there would be somewhere where it would
allow me to specify certificate details.
On Fri, Aug 16, 2019 at 6:11 PM Micah<EMAIL_ADDRESS>wrote:

@javaadpatel https://github.com/javaadpatel I don't see anything that
would cause issues using this with a secured cluster. Are you running into
any issues?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/37225?email_source=notifications&email_token=AFOGKTTEZCDKPKGPLXPWHVDQE3GTLA5CNFSM4IMFXIRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4PBEGA#issuecomment-522064408,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFOGKTVXJGWTFV4R34I25PTQE3GTLANCNFSM4IMFXIRA
.

You can find more info about the certs in the next page
https://docs.microsoft.com/en-gb/azure/service-fabric/service-fabric-application-and-service-manifests
The link also provides additional links to examples
https://docs.microsoft.com/en-gb/azure/service-fabric/service-fabric-service-manifest-resources#example-specifying-an-https-endpoint-for-your-service
https://docs.microsoft.com/en-gb/azure/service-fabric/service-fabric-application-secret-management

@javaadpatel any update on this?

@javaadpatel I will go ahead and close this out. If you want to continue the discussion just let me know and we can always reopen the issue :)


Optional dependency skipping and npm start error.

Steps that i have followed are :

forked the repository

cloned the repository

removed the remote origin

tried to install the dependencies using npm install - there i get optional dependency skipping message

tried to run locally using npm start - there too i get error
 Can someone help me running this locally ?

Tried removing the node_modules folder and re-installing the packages still not working

i'm also experiencing this issue.

Im also facing the same issue... if anybody have solved.. please help!

Me too... anyone can help, please?

@saratkumar17mss040 @iamobregon @imkarthiknr @JanRolenc Hi!
I would like to know the status of this issue, is it still happening for some of you? did some of you solved this issue?
Let me know!


perf: remove duplicated rootkey fetch inpruning (9% pruning speedup on osmosis)

Currently delete version duplicatedly fetches rootkeys. This rootkey fetch does not go through the normal caching logic (as the rootkey fetch call does a direct call to the underlying database. Its not routed through the standard GetNode cache wrappers)
I did a 2 hour long block sync on osmosis, which got through 66000 blocks.
We should cache this root setting logic. Right now root key fetching is ~37% of the block pruning time during my latest sync. And block pruning is 40% of the overall sync time.
This PR does a quick cache to reduce from 4 calls to 3 calls. (TraverseOrphans has 2 calls as well) Ideally we can setup a second cache later on to ensure none of these DB calls get repeated, but for now wanted to keep it simple/uncontroversial with this PR, getting an 9% speedup to pruning's sync time component. (and ~4% to overall block sync)

Summary by CodeRabbit

New Features

Introduced a caching mechanism for root keys to enhance retrieval efficiency.
Added methods for managing root key caching, including fetching and updating keys.

Bug Fixes

Optimized version deletion process by reducing database access through caching.

Aiming to update this tmrw to have a better cache that should de-duplicate 3 out of the 4 relevant root key calls here

@mergifyio backport release/v1.2.x

@Mergifyio backport release/v1.3.x


Search Affiliation Topic Tags Not Displaying

Overview
At Search Projects Page the Affiliations tag results are not displaying from our database.

See issue #952


Move lambda to node 16

##What
Update lambda to Node 16
Involves upgrading @pulumi/aws to 5.43.0 and "@pulumi/pulumi" to 3.35.0
##Why

node 14 not allowed anymore
Temporary fix to the master workflow deployment

merging this with one approval as auth workflow requires this


Inconsistent Behavior: 'with_scale_factor_override' Method Fails to Adjust Window Size as Expected

Bevy version
0.13.0
Description:
The bug affects the window scaling functionality in Bevy version 0.13.0 when setting a scale factor override for the window resolution.
Reproduction Steps:

Attempt to create a window with a specific resolution and scale factor using Bevy.
Set the scale factor using the with_scale_factor_override builder method.
Run the application and observe the window size.

fn main() {
    App::new()
        .add_plugins(
            DefaultPlugins
                .set(ImagePlugin::default_nearest())
                .set(WindowPlugin {
                    primary_window: Some(Window {
                        title: String::from("My Game"),
                        resolution: WindowResolution::new(200., 200.)
                            .with_scale_factor_override(8.),
                        ..default()
                    }),
                    ..default()
                })
        )
        .run();
}

Expected Behavior:
The window should display with a size adjusted according to the specified scale factor.
Actual Behavior:
The window retains its original size, disregarding the scale factor override.
Additional Information:

The set_scale_factor_override method sets the scale factor override correctly.

fn main() {
    let mut resolution = WindowResolution::new(200., 200.);
    resolution.set_scale_factor_override(Some(8.));

    App::new()
        .add_plugins(
            DefaultPlugins
                .set(ImagePlugin::default_nearest())
                .set(WindowPlugin {
                    primary_window: Some(Window {
                        title: String::from("My Game"),
                        resolution,
                        ..default()
                    }),
                    ..default()
                })
        )
        .run();
}

Resolution:
The 'with_scale_factor_override' method should use 'self.set()' to set the physical pixels with the scaled resolution like the 'set_scale_factor_override' method does.

I would like to try to fix this bug if possible!


Add docs for ClusterQueuePreemption

What would you like to be added:
We should add docs for ClusterQueuePreemption.
Why is this needed:
It helps users to understand the Preemption.
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

Maybe, we need to add docs to https://kueue.sigs.k8s.io/docs/concepts/cluster_queue/ and https://kueue.sigs.k8s.io/docs/tasks/administer_cluster_resources/.

/kind documentation


Dolphin Scheduler with Podman/Docker Image not executable ?

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
i installed on my host a Podman and a Postgres Server inside.  Images are from  docker.io/apache/dolphinscheduler used.
inside there is a Network "pgNetwork" created within the i range  10.*. because i installed pgAdmin as well in Podman and want access to database per Name "pgPostgresServer" . Both Applications working well together i can use pgAdmin to work in postgres.
So i tried now to install the dolphin scheduler also within podman and want to reuse this db i already have.
Until a very long conversiation with ChatGPT it was not very helpfull i found ot that i have to set the DATABASE_ parameters by my selfe and the mapping of application.yaml ( code next ) has no effect because the start scripts overwriting the SPRING_ parameters with that. :(
So far so good it looked like dolphin useing the Database now and i also found tables created inside there. I used this podman command below to debug and start the scheduler but it run into some springframework errors which i cant mitigate.  ( debug log is in the attachment !)
Any idea how i can solve this issue ? Is it a Bug or simple do i miss a konfiguration to solve it .
thanks br thomas
cat /usr/share/scripts/postgres/application.yaml
spring:
datasource:
url: jdbc:postgresql://pgPostgresServer:5432/dolphinscheduler
username: postgres
password: 62686400
driver-class-name: org.postgresql.Driver
Podman Start Container
podman run -d --name dolphinscheduler --network pgNetwork
-v /usr/share/scripts/postgres/application.yaml:/opt/apache-dolphinscheduler-2.0.5-bin/conf/application-postgresql.yaml
-e DATABASE_HOST=pgPostgresServer
-e DATABASE_PORT=5432
-e DATABASE_USERNAME=postgres
-e DATABASE_PASSWORD=62686400
-e SPRING_DATASOURCE_URL=jdbc:postgresql://pgPostgresServer:5432/dolphinscheduler
-e SPRING_DATASOURCE_USERNAME=postgres
-e SPRING_DATASOURCE_PASSWORD=123456789
-p 12345:12345
apache/dolphinscheduler:latest all
dolphin_log.log
What you expected to happen
dolphin scheduler could be reached by  localhost:12345 from my host
How to reproduce

install podman
install images for postgres , pgAdmin and dolphin scheduler
create a network interface for all oth them
create container with this network interface
try to create a dolphin container fails with comman in the problem under what happend.

Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You should rebuild images if you want to use podman.


Check the blobs before creating symlink

Sometimes, the blobs will be deleted unexpected like by manual or be GCed, then the symlink will link to a non-exist file, let's check first to avoid this case happen again.

/kind bug

close for now
/close


feat(baseline-implementation): Update singleWorker helpMarkDown

Details

Motivation

Context

Pull request checklist

[ ] Addresses an existing issue: Fixes #0000
[ ] Added relevant unit test for your changes. (yarn test)
[ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[ ] Ran precheckin (yarn precheckin)
[ ] (after PR created) The Accessibility Checks (pull_request) check should fail. All other checks should pass.

Codecov Report

Merging #901 (24adee3) into main (2861845) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   87.61%   87.61%
=======================================
  Files          39       39
  Lines         840      840
  Branches      102      102
=======================================
  Hits          736      736
  Misses        104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2861845...24adee3. Read the comment docs.


Data Binding Error with Open Records with Numbers

Consider the following sample service:
import ballerina/http;
import ballerina/io;

type Entry record {
    string src;
    string ref;
};

@http:ServiceConfig {
    basePath: "/"
}
service testSvc on new http:Listener(9090) {

    @http:ResourceConfig {
        path:"/store",
        methods: ["POST"],
        body: "entry"
    }
    resource function store(http:Caller caller, http:Request request, Entry entry) returns error? {
        io:println("Input: ", entry);
        check caller->ok();
    }

}

And the following requests:
$ curl -d '{"src":"s1","ref":"r1"}' http://localhost:9090/store
$ curl -d '{"x":1,"src":"s1","ref":"r1"}' http://localhost:9090/store
$ curl -d '{"x":1.3,"src":"s1","ref":"r1"}' http://localhost:9090/store
data binding failed: error("{ballerina/lang.typedesc}ConversionError",message="'map<json>' value cannot be converted to 'Entry'")

With the open record, if we set a numerical value to a field that is not mentioned there in the record, with a fractional value, it fails with the above error.
Version: Ballerina slp4.

This behaviour has induced due to https://github.com/ballerina-platform/ballerina-lang/issues/26624.
A possible workaround would be to explicitly define the decimal field and make it optional in the Entry record as follows until the bug is fixed.
type Entry record {
    decimal x?;
    string src;
    string ref;
};

Tested issue with
Ballerina Swan Lake Beta 1
Language specification 2021R1
Update Tool 1.3.5

import ballerina/http;
import ballerina/io;

type Entry record {
    string src;
    string ref;
};

service on new http:Listener(9090) {
    resource function post store(@http:Payload Entry entry) returns http:Ok|error? {
        io:println("Input: ", entry);
        return {};
    }
}

Output
[ballerina/http] started HTTP/WS listener <IP_ADDRESS>:9090
Input: {"src":"s1","ref":"r1"}
Input: {"src":"s1","ref":"r1","x":1}
Input: {"src":"s1","ref":"r1","x":1.3}

The issue has been resolved via ballerina-platform/ballerina-lang#26624., hence closing the issue


cast: Add option to use local source code for --debug and --decode-internal

Component
Cast
Describe the feature you would like
If I'm not mistaken, cast currently only uses Etherscan sources when using cast run with the --debug or --decode-internal arguments. It would be great to be able to pass the path of a local foundry project to use its sources.
Additional context
No response

Somehow linked to this: would be great to have --flamechart for cast run as well

Also looking for this support in some way. We are dealing with private contracts with non-published sources that emit custom errors and make calls to other private library functions. We would like to be able to see the decoded data where possible when using cast run.
As there is not a clear relationship between a contract and its source for contract addresses without a published source, would it be possible to add a flag to provide a mapping from contract address to a local contract name, similar to the current --label syntax, and potentially look in the broadcasts directory to pre-populate these entries? Worst case scenario the contract has changed name or ABI, in this case a matching signature cannot be found, and that call/error is not decoded.
I understand the above might not be as easy to validate for the --debug case as you need to be sure the contract has not changed since deployment and that you are aware of the constructor arguments, but it should solve the decoding issues for traces with/without the --decode-internal flag as these only need to match in the ABI signatures?


Handle material for instances

When using mesh instances with different materials, these are stored in the object - not the mesh.

I've attached a simple file (2.80) showing the issue:
instancing.zip

At first glance this seems good.  I didn't test it on my machine yet, will try to do that tomorrow.  Might be worth adding a test to the suite to make sure that materials come out the intended way.

Hmmm it fails roundtrip test 02_shared_mesh. I think it's because the cache_wrapper now sees meshes as different because of the different blender_object param. I originally tried passing down the material list, but had issues that the cache_wrapper couldn't handle list args 🤔

Updated this to do caching correctly. Also properly handle meshes without material assigned.
Now output will be something like (reusing same attribute accessors for same mesh data):
{
    "meshes" : [
        {
            "name" : "CubeMESH",
            "primitives" : [
                {
                    "attributes" : {
                        "POSITION" : 0,
                        "NORMAL" : 1,
                        "TEXCOORD_0" : 2
                    },
                    "indices" : 3,
                    "material" : 0
                }
            ]
        },
        {
            "name" : "CubeMESH",
            "primitives" : [
                {
                    "attributes" : {
                        "POSITION" : 0,
                        "NORMAL" : 1,
                        "TEXCOORD_0" : 2
                    },
                    "indices" : 3,
                    "material" : 1
                }
            ]
        }
    ]
}

NOTE: from debugging I noticed that cache_wrapper does NOT work properly with bpy.types objects, which is the reason I had to change several places from passing around blender_mesh: bpy.types.Mesh to blender_mesh_name: str. This issue with cache_wrapper is likely to cause problems elsewhere :S

Managed to fix an issue where things broke if the mesh had no materials (i.e. only object instances had materials).
Here is a little test with 1000 monkeys:
1000_monkeys.zip

This PR is cooler than it looks.  There's actually no way in master right now to re-use a mesh multiple times with different materials (aka "instancing"), and this enables that as a new export feature.
The automated tests pass and I did a little manual testing too.  I'm going to merge this, and when I have time I will write a new automated test to look specifically for this feature.
Thanks @pjoe!

NOTE: from debugging I noticed that cache_wrapper does NOT work properly with bpy.types objects, which is the reason I had to change several places from passing around blender_mesh: bpy.types.Mesh to blender_mesh_name: str. This issue with cache_wrapper is likely to cause problems elsewhere :S

@pjoe This introduce a very bad regression : we can't export applying modifiers anymore ... This is already reported in several bug reports as #546 #536
I currently working on a better cache wrapper, for fixing this bug and some other cache issue with bpy.types

@julienduroure Damn, sorry about that regression. Anyway obviously as you say best solution is to handle this generally in the cache_wrapper and revert back to passing actual Mesh objects instead of names.

NOTE: from debugging I noticed that cache_wrapper does NOT work properly with bpy.types objects, which is the reason I had to change several places from passing around blender_mesh: bpy.types.Mesh to blender_mesh_name: str. This issue with cache_wrapper is likely to cause problems elsewhere :S

Hello @pjoe
This is quite an old report, but I'm currently looking some test cases where cache_wrapper was not working properly with bpy.types
Do you remember what was your test case when you debugged ?

@julienduroure Must admit this is a while back. IIRC the issue was later addressed in cache_wrapper. My main testing for this PR was instancing, but I think that was fully fixed.


Add Learner Credential Wallet text to first open screen

The open screen only displays a folder.  Add text" Learner Credential Wallet" below it.

Labeling as "needs design" but it should be a quick review to add centered text below the folder icon.

I think the text looks good on iOS and Android LCW v2.0.11-Build 66 on Moto g and iPhone 13 Pro.


[Regression] TextBox with ContextMenu: Right click clears selection

Previous issue: #2692
Dev environment

Latest master (36c34b4 as of writing)

Description
When you right click a text box and the text box has a ContextMenu, it clears the selection. This is a problem for context menus (copy, paste, etc.).
The problem
When the ContextMenu opens, it opens a Popup. The ContextMenu takes focus when the Popup opens (https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/ContextMenu.cs#L162), which then causes TextBox.OnLostFocus to be called.
protected override void OnLostFocus(RoutedEventArgs e)
{
    base.OnLostFocus(e);
    SelectionStart = 0;
    SelectionEnd = 0;
    _presenter?.HideCaret();
}

This function doesn't care why the TextBox lost focus -- the selection is removed. We need the ContextMenu to be focused so that keyboard navigation works (4a5e11f6aaee79a3183aa7d703b60c4fa912a971).
The naive fix of "hey is the thing that got focused our ContextMenu? yes? ok let's not clear our selection." within OnLostFocus isn't a good fix because if you open the context menu and then select a different TextBox, the original one will never have OnLostFocus called, so the selection is never cleared.

Yeah I've noticed this too. We need to take a look at WPF and see how this is handled there.

Fixed by #4498


Expose the raw JSON parameters of a provisioning request

This allows consumers to decode the params to their own custom structs

Hi David,
Thanks for taking the time to create a PR.
I guess the problem that you are trying to solve here is deserializing the parameters into a struct with JSON annotations. Trying to convert a map[string]interface{} to a struct by copying over individual fields would look weird.
For the proposed solution, I think passing down both map[string]interface{} and a []bytes looks a bit ugly. Also, one might have a similar issue while binding and updating, so those endpoints should change  as well.
We recognize the issue, but we would like to take some time to think if there are better alternatives. We are planning to have another conversation about this next week, will come back to you then.
Till then might I suggest a "workaround", you could JSON serialize the map[string]interface{}, and deserialize it back to your struct.

Merged, and also removed Parameters, leaving only RawParams.
Thanks!
@craigfurman & Maria


 I do have a fully working connection for you in c++ if you ever want it
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows
From: @.>
Sent: Thursday, July 14, 2022 8:24 AM
To: @.>
Cc: @.***>
Subject: [IRC7/IRC7] Draft MSNPROFILE component (Issue #4)
—
Reply to this email directly, view it on GitHubhttps://github.com/IRC7/IRC7/issues/4, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMGJ36VNDU6FZAMDMC3ZRLVUAIIZANCNFSM53SIAD2Q.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@godzhand  oh wow thats confusing did you send this in July? either way thanks for keeping tabs on this project. cant imagine a need for the C++ client but if you want you could upload it somewhere and give everyone access to it? dont forget to make a github project for it.


fix(listview): Adds context to new work item create flow. Fixes #279.

This adds context to the new WI flow. Adding a new work item from the toolbar or the empty list now has iteration and area preselected.

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-2 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-5 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-6 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-7 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-9 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@nimishamukherjee this is not currently supported, due to the area not part of the query parameter. If we add the area to the q param, this should work out-of-the-box.

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-11 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-13 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-15 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io

@michaelkleinhenz fabric8/fabric8-ui:SNAPSHOT-PR-2188-16 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2188-fabric8-planner.badger.fabric8.io


Windows: avoid modifying the global keyboard state with ToUnicode

Since Windows 10 version 1607 we can make use of a new flag that
makes ToUnicode operate on a process-private keyboard state.
Reference:
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-tounicode
Note: this is a coordinated effort across various open source projects

GTK
Chromium

This should be fixed now with ad01c1b614868c3cbc79306aa6a19c9fc06f34a6. Thank you!


Include more examples

Kubernetes
AWS Beanstalk

Added the examples on 6.0.2 version
Docker-compose examples revised by: @beenanner and @mcfedr
Thank you!


⚠ Jenkins Plugins Artifactory has degraded performance

In 66a9745, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1203 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 4333152 after 14 minutes.


LightsOff: fix the Classic pack, Level 9 puzzle

Change the unsolvable puzzle:

to the correct one:

Fixes #24

Thanks for doing all the checking and fixing!


Submit button on the home page does nothing.

Hi,
Yes, we are having an issue with Jenkins. We are working on it right now.
Thanks,
Alakh

@arswaroop We fixed it. Can you please check and let us know?
http://<IP_ADDRESS>:3001/
We changed the UI IP
Thanks,
Alakh

Yes its working now


docs: update user guide with best practice usage of async pipe

Updates the documentation in line with what was discussed in https://github.com/MrWolfZ/ngrx-forms/issues/219

Thank you for this contribution.


Modified Labels of Contact Us Form

Related Issue
Modified Labels of Contact Us Form and changed the color of Address
Fixes:  #4086
Description
Modified the color of Labels of Contact Us Form and changed the color of Address so that they are visible in dark mode

Type of PR

[x] Bug fix
[x] Feature enhancement

Screenshots / videos (if applicable)
Before

After

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

highlight the email box also with the color in dark mode .

highlight the email box also with the color in dark mode .

Completed the task

why have u made changes in .vscode/settings.json file ?

Sorry for the inconvenience but i haven't made that change , it might be due to my vs code
Sorry for the inconvinience caused


Set the rgw_create_pools pools application to rgw

Set the application to rgw for pools created from rgw_create_pools. On Ceph Nautilus the heath is set to HEALTH_WARN with the message "application not enabled on X pool(s)" if an application isn't specified for a pool.
Signed-off-by: Kevin Coakley<EMAIL_ADDRESS>

Sorry about the previous pull request, I am not sure why I assumed push to stable branch instead of master.

CI failure, unrelated.


The Event Listener/Mapper Doesn't check for simple Annotations...

[Semantical Error] The annotation "@Id" in property  ......
Standard Error however this is in use in a framework where I cannot switch the Annotations to Extended versions.. Really I think this is a base problem with Doctrine not allowing separate eventmanagers but there has to be a way to monkey patch it ..
My Specific use case has the subscribers attached to a separate entitymanager WITH extended annotations but its receiving the simple ones on the metadataload event..

meh I guess this is more of a DriverManagerChain issue.. closing sorry


feat(selenium API): add handling of Drawer on Selenium API

Please check if the PR fulfills these requirements

[x] The commit(s) message(s) follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Drawer is not present in the API.
What is the new behavior?
We can access to Drawer from the API.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

I would really like a getForm() and getForms which return  tag(s)


Fieldtype for hasOne relationship

Description
Currently runway offers fieldtypes that support 'belongs to' and 'has many' relationships. I need a fieldtype that would be used for HasOne relationship. Currently, in my code I have to implement HasMany field type, limit 'maximum allowed entries' to 1.
I have 2 models: Article and ArticlePackagingUnit. They have 1 to 1 relationship and method for that looks like this:
/**
 * @return HasOne<ArticlePackagingUnit>
 */
public function articlePackagingUnit(): HasOne
{
    return $this->hasOne(ArticlePackagingUnit::class);
}

But for runway, for HasMany fieldtype, I also have to add this because there is no fieldtype for HasOne
/**
 * For runway addon purposes. Article actually has only one packaging unit
 * but runway has only hasMany relationship field available
 *
 * @return HasMany<ArticlePackagingUnit>
 */
public function article_packaging_unit(): HasMany
{
    return $this->hasMany(ArticlePackagingUnit::class);
}

I could use belongsTo fieldtype on the model that has foreign key and I did. ArticlePackagingUnit has 'belongs to' field type on article_id field, but I really need to have relationship field on the article model as well.
In article_packaging_unit blueprint:
-
  handle: article_id
  field:
    resource: article
    create: false
    type: belongs_to
    display: Article
    listable: true
    visibility: read_only
    relationship_name: article
    title_format: '{{description_short}}'

In article blueprint:
-
handle: article_packaging_unit
field:
  resource: article_packaging_unit
  relationship_name: article_packaging_unit
  create: false
  title_format: 'quantity per package: {{quantity_per_package_unit}} price per unit: {{price_per_unit}}'
  max_items: 1
  type: has_many
  display: 'Article Packaging Unit'
  visibility: read_only

Steps to reproduce

create 2 models that have One to One relationship
create resources for those models in statamic runway
add HasMany fieldtype for that relationship in the blueprint of the model that does not have foreign key

Environment
Environment
Application Name: Statamic
Laravel Version: 11.19.0
PHP Version: 8.3.11
Composer Version: 2.7.8
Environment: local
Debug Mode: ENABLED
URL: localhost:8080
Maintenance Mode: OFF
Timezone: Europe/Zurich
Locale: de
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Broadcasting: null
Cache: file
Database: sqlite
Logs: stack / daily
Mail: log
Queue: sync
Scout: collection
Session: file
Locales
Installed: de, en, fr
LaravelLang\Lang\Plugin: 15.5.6
Locales Version: 2.9.2
Protected: de
Publisher Version: 16.4.0
Sentry
Enabled: MISSING DSN
Environment: local
Laravel SDK Version: 4.7.1
PHP SDK Version: 4.8.1
Release: NOT SET
Sample Rate Errors: 100%
Sample Rate Performance Monitoring: NOT SET
Sample Rate Profiling: NOT SET
Send Default PII: DISABLED
Statamic
Addons: 4
Sites: 1
Stache Watcher: Disabled
Static Caching: Disabled
Version: 5.19.0 PRO
Statamic Addons
aryehraber/statamic-logbook: 3.3.0
statamic-rad-pack/runway: 7.7.3
statamic/eloquent-driver: 4.12.0
tv2regionerne/statamic-safeguard: 1.4.0
Statamic Eloquent Driver
Asset Containers: file
Assets: eloquent
Blueprints: file
Collection Trees: eloquent
Collections: file
Entries: eloquent
Forms: file
Global Sets: file
Global Variables: eloquent
Navigation Trees: eloquent
Navigations: file
Revisions: file
Sites: file
Taxonomies: file
Terms: eloquent
Tokens: eloquent

I could use belongsTo fieldtype on the model that has foreign key and I did. ArticlePackagingUnit has 'belongs to' field type on article_id field, but I really need to have relationship field on the article model as well.

Sorry, I must be misunderstanding... which part of this doesn't work.
The Belong To relationship should work for HasOne relationships too.

I could use belongsTo fieldtype on the model that has foreign key and I did. ArticlePackagingUnit has 'belongs to' field type on article_id field, but I really need to have relationship field on the article model as well.

Sorry, I must be misunderstanding... which part of this doesn't work.
The Belong To relationship should work for HasOne relationships too.

Belongs To works, but I can't use Belongs To on Article resource/model. On Article resource I have to use Has Many field because there is no Has One field available. And the main problem is that I have to add this method in order to make it work:
/**
 * For runway addon purposes. Article actually has only one packaging unit
 * but runway has only hasMany relationship field available
 *
 * @return HasMany<ArticlePackagingUnit>
 */
public function article_packaging_unit(): HasMany
{
    return $this->hasMany(ArticlePackagingUnit::class);
}

This method does not reflect the actually relationship between Article and ArticlePackagingUnit. It returns HasMany, but article has only one ArticlePackagingUnit. I am forced to do this kind of workaround and it seems like a bad practice.
Desired behaviour would be that there is Has One relationship field supported by runway so that I can have a method like this:
public function article_packaging_unit(): HasOne
{
    return $this->hasOne(ArticlePackagingUnit::class);
}

Hmm, where is the foreign key stored? On the ArticlePackagingUnit model?

Yes, correct

I don't have time to dig into this now, but I'll take a look the next time I'm back on Runway.
Would it be possible for you to create an example repository demonstrating the relationship? It'll make it much easier for me to get everything setup when I'm able to look at this. Thanks!

As I haven't heard back in a while, I'm going to close this issue.
If you're still having issues, please provide an example repository demonstrating the issue and I can take a look. Thanks!


[WIP] Move a few constants to OS-specific files

This is a bit more convoluted than it could as one crc-embedder build needs access to the constants for all platforms.

@cfergeau https://github.com/code-ready/crc/pull/1086/commits/8e365df293add5ce715c87408e04c6dd30d9fad8 should be in place irrespective to this PR.

@cfergeau 8e365df should be in place irrespective to this PR.

Thanks for the reminder, moved it to its own PR.

GIven the latest discussions that we had, it's almost a Proof of Concept rather than a Work in Progress ;)

retest this now

Retest this please.

Closing this PR.


Updates Local Benchmark Results

This PR updates the benchmark results for the local environment.
Note 1: I had to update the command line instruction to run the benchmarks locally , in order run them faster and consistently with the previous version.

r and w are specifying the minimum time (seconds) to spend at each measurement warmup iteration/iteration.

Note 2: GCP result will be updated in a separated PR.
Fixes #25

Yes, that would be the idea ;)
Thanks for the review.


Exporting videos out of mpv?

I'm not sure if anyone has tried this but I've been testing with the vs.placebo plugin in vapoursynth and applying Anime4K filters seem to have no impact on the clip? I do notice that the dynamic range of the video becomes compressed which is likely a side effect from the clamp highlights shader not working.
I'm not aware of any other alternatives that could parse mpv glsl shaders and directly output a video, maybe someone who has already went on this path can guide me through it?

This might be similar to https://github.com/bloc97/Anime4K/issues/144#issuecomment-991957519 . You just have to remove //!SAVE MAIN lines in the shaders for them to work with libplacebo. (If this behaviour is intended they will be removed in the next release.)
The clamp highlights shaders don't currently work with libplacebo, they can be removed without negative effect in most cases.

Hey @banjaminicc, were you successful in outputting the video? Can you please share the script to do it?

Hey @banjaminicc, were you successful in outputting the video? Can you please share the script to do it?

Unfortunately, no. I was still met with other VS errors, I used the template from the GUI hybrid so maybe you could look into that

Hey @banjaminicc, were you successful in outputting the video? Can you please share the script to do it?

I figured it out now
As mentioned by bloc, simply use the fix in the quoted issue and then place the shaders in the order recommended and they work perfectly.

@banjaminicc can you please share your scripts, have been trying to achieve the same thing as u but was unsuccessful


Update docs for v2.0.0

Replace "ModuleLoader image" with "kmod image".
Adapt to the new worker Pods workflow.
Prefer installation via OLM.
Add events to the troubleshooting section.
Change the theme to something more familiar.
Fixes #916
/cc @yevgeny-shnaidman

/lgtm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8e5c16) 76.29% compared to head (29a4bed) 76.29%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   76.29%   76.29%
=======================================
  Files          60       60
  Lines        5677     5677
=======================================
  Hits         4331     4331
  Misses       1123     1123
  Partials      223      223

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding an ADC implementation

Adding the ADC implementation I finally got working yesterday together with an example for it. Furthermore I added @Jan561 as an author as he did most of the work on the ADC except solving a few issues with them. (I'm doing this PR instead of him as he's currently out on vacation)

Again, I'm unfortunately too busy to test this right now but it looks good to me. @richardeoin @jordens any comments?

Awesome, I can have a look at this over the next few days. I have a suggestion to use the enum definitions from stm32h7 rather than repeating them here - will comment this on the code.

I'm swamped with proposal writing. I won't be able to help until next week.

(As my commit message says I fixed an error I made when translating my i2c implementation to this HAL, i messed up the order of a line which causes the I2C peripheral to end in reset state permanently)

I've added some more review comments, around helping users understand how to use this implementation.
The most complicated issue is the provision of a suitable adc_ker_ck. Annoyingly the chip doesn't do this by default. It should be explained in the example and checked with assert!

Great, nice work on getting these sorted so quickly @hargoniX
The checking ADC1/ADC2 enable before resetting isn't quite right. The check is after enable_clock, so the if statement will always evaluate to false. Maybe store the previous state in a variable?
Other than that small point, ready to merge.

That issue is also fixed now I think, thanks for the feedback from your side!


Add multipage support

Fixes #151

index.html should probably also have the TOC inline like in the HTML multipage specification

@ExE-Boss every page already has the TOC built into it.


Supported standard OTEL exporter protocol environment variables

Reason for This PR
OpenTelemetry has some standardised environment variables for choosing which client to use: https://opentelemetry.io/docs/specs/otel/protocol/exporter/#specify-protocol
In Go, these can be consumed using the 1st-party package https://pkg.go.dev/go.opentelemetry.io/contrib/exporters/autoexport, but because this otel plugin already does some custom stuff, I've opted to try reimplementing the semantics of the spec in the plugin.
Description of Changes
In case the client is unset in the config, check the standardised environment variables OTEL_EXPORTER_OTLP_TRACES_PROTOCOL and OTEL_EXPORTER_OTLP_PROTOCOL for a configured protocol.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[ ] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[ ] Any required documentation changes (code and docs) are included in this PR.
[ ] Any user-facing changes are mentioned in CHANGELOG.md.
[ ] All added/changed functionality is tested.

Summary by CodeRabbit

New Features

Enhanced configuration flexibility by allowing users to dynamically set the client protocol based on environment variables for improved adaptability to different runtime environments.

Bug Fixes

Added logging for unrecognized environment variable values to improve error handling and user awareness.

Hey @devnev 👋 Thanks you for the PR 👍 I added a few minor comments, feel free to check 😃

@rustatian do you think its worth putting effort into making this plugin fully compliant with the spec? I can give it a go, but also I think the goal should be to use https://pkg.go.dev/go.opentelemetry.io/contrib/exporters/autoexport directly, but I imagine that can't be done in a non-breaking way.

Maybe a new option auto:bool or something, which, if true, ignores the other settings and uses the autoexport package?

ping @rustatian

Hey @devnev, sorry for the long review 🥲

No worries, thanks for the review


Adds a variety of new options for passenger loadouts.

About the PR
Adds a lot of new options for passenger loadouts. Mainly jumpsuits - colored jumpsuits, Hawaiian shirts, casual jumpsuits - but also adds a few new misc items, like cheap sunglasses and colored shoes.
Why / Balance
Passenger has the least responsibility and the most adaptability when it comes to character creation, gameplay variety, and roleplay. Almost every single item added to their loadouts in this PR can be obtained from basic clothing vendors scattered around the station, cargo, and uniform printers. Nothing added to their loadouts is generally out of their control to obtain, and almost all of it can be obtained very easily. The only real exception to this is the Gar Glasses, which I would accept being removed in favor of remaining as maintenance loot.
Very few of these outfits can be used to disguise yourself as another department, and acquiring the outfits to do so is already quite easy. However, to prevent raiders from abusing this, and to ensure that it is still somewhat readable when someone is a new join, there is a 5 hour playtime requirement on most of these additional clothing items.
Technical details
Changes the passenger.yml loadout file, and the loadout_groups.yml file.
Media
https://youtu.be/hKRkzUpxIxY

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog

:cl:

add: Added new customization options for passenger loadouts.

would that build check happen to be my fault? i'm not good at parsing these things.

Random test fail, happens sometimes. I'm re-running it for you.

the UI looks so bad with this many clothing options, feel like it could be done differently in a better way

the UI looks so bad with this many clothing options, feel like it could be done differently in a better way

I agree, I wish we had a matrix of icons to highlight, and the names just appeared on mouse hover.

the UI looks so bad with this many clothing options, feel like it could be done differently in a better way

i think a UI change would be nice at some point, but i don't think it looks that bad as is. guess it's mostly up to maintainer preference.

It'd be a good idea to read #29872

It'd be a good idea to read #29872

seems like that didn't reach a proper conclusion and was only closed due to merge conflicts and lack of merging after over a month.
the other PR attached does seem to prove that maints - or at least sloth - would prefer to not have every colored jumpsuit. i think changing it down to the basic non-colored suits (casual jumpsuits, hawaiian shirts) would be a fair compromise. i'd like to see if that's the conclusion to be reached before making the change, though.


Set relative url root in dev environment

@mishaschwartz I did a search through the codebase for :3000 and found a usage in autotest.rake. Looks like we should change that? (Test by reseeding)

@david-yz-liu Thanks for catching that.


Ethernet & TCP/IP

Are there any plans on making use of the Ethernet port on the stm32f7 discovery board?

It's definitely on the TODO list, please tell us if you start working on it.

If you look at the svd branch, there's examples/ethdemo that starts implementing some support for it. You can start from that and add what's missing.

The SVD branch has now been merged in master. So indeed, if you want to contribute, please have a look at components/eth.
This has not been integrated yet with the general framework as it's still a very early stage driver, but that's some basis you can start with.
Best regards,

Jerome


Feature/cancelable file upload browser

What happened here?

What happened here?

closed it by mistake

rebased off develop to fix build problems


⚠ ESPN has degraded performance

In b7546a0, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 4004 ms

Resolved: ESPN performance has improved in 62dedd3.


everybody needs support for buckets or regions :-)

This is in fact a feature request ;-)
or it's me and it is already there?
--EDIT--
Just to be sure, i know about multiple instances, but if your not able to get them we need a native way to simulate this within one - lets say shared - instance

what exactly are you asking for?

What i mean:

i want to use 1 Memcached-Server running 1 Memcached-Instance, cause of web-hosting limitations
the web application has different consumers "sharing" this Memcached-Server-Instance
BUT: every consumer MUST HAVE it's own cache, because they're using identical keys to cache values so they would get values from other consumers == fail :-(

What i want:

a kind of "option" to define seperated "regions" at connection setup
so consumer A is routed to store key/values only in region A and consumer B only in region B in this single instance (e.g. bins in chouchdb)
this would prevent consumer A getting values from consumer B

In short:

to avoid naming collisions i need to partition key/value data with buckets like:
http://docs.couchbase.com/developer/dev-guide-3.0/buckets.html
http://docs.couchbase.com/developer/dev-guide-3.0/partition-data.html

Ok. The storage engine branch we had years ago could do this to a degree. Dustin had created a bucket engine which ran other engines underneath it... Unfortunately we weren't able to reconcile the branches.
It's quite a lot of work to get the current code to do that. It would take a series of patches and/or another attempt at a storage engine system. While it's definitely not everybody who needs it, I don't want to use that as an excuse. Instead I'll use the excuse of "I have limited time, no other active maintainers, and very few people asking for this sadly complicated feature" :) Hopefully someday we could get it.


Layouts don't always work when a prototype is migrated

What
The use of layouts should be consistent when creating or migrating a prototype so that they are consistent with the documentation for version 13.
Version 12 and before had app/views/layout.html (and app/views/layout-unbranded.html)
Version 13 has app/views/layouts/main.html
The idea being we can rely on layouts being in the layouts folder, and possibly offer the user a choice of layouts when creating pages from templates.
Layouts help the user make changes that affect multiple pages, for example a custom header, footer, scripts and so on.
In migration, if the old layout.html has changed at all, we do not provide a new layouts/main.html. This means new pages made from templates will not work or even viewed. This is not highlighted to the user as a migration fail.
We could:

fix the migration script to process layouts better, and warn about this issue
add a check to the kit that helps users who have already migrated to fix it via the Manage Prototype UI

Who needs to work on this

developers

Who needs to review this

developers

Done when

[x] Dev discussion on whether we make change @joelanman @nataliecarey
[ ] Raise a ticket to fix the migration script
[ ] Design the UX for people who have migrated and have a missing layouts/main
[ ] The way layouts are used matches the version 13 documentation for both create and migrate

discussed with @nataliecarey  - this is a regression, there should be a fallback layout if layouts/main is missing so templates continue to work

investigated again, the fallback does seem to work. There is definitely a bug in migration though - it should error if layout.html has been edited


Traffic manager gives rpc::timeout while calling RPC function 'unregister_vehicle'

Hello, there. Thanks so much, first for offering this brilliant work, which helps my research a lot.
I am now working towards having multiple training agents running in parallel in no_rendering mode. My program is able to run for about 10 min, then the client will complain rpc::timeout: Timeout of 2000ms while calling RPC function 'unregister_vehicle', I guess it's one function in the source code of traffic manager? It happens when i tried to remove the current hero car, and spawn it in a new location in the same world. The fps is around 120. And at the end, it just complains about too many open files in a process.
I wonder why this occurs, and how I should handle this. I tried to reset the world in this case within the same process, but no luck so far. It's in the latest version of <IP_ADDRESS>. Thanks

Hi,
I am assigning also @pravinblaze to this issue. Before we dig in deeper for a possible bug, I want to make sure of a few things:

Have you set up the experiment in a way that is compatible with the  documentation about multiple Traffic Managers?
Could you provide more information about the script? Is it running multiple agents in the same CARLA simulation, or do you have more simulations running?
 You can check how to do so in the several sample scripts we provide.

Sorry for the late reply. I managed to circumvent this issue by wrapping the client inside another process. Thanks still!


feat(helm chart): allow pod to restart automatically when configmap is updated

Description
It's an official trick from helm.
As an example, it's already used by mongodb chart which is a statefulset.
I will be more convenient from user side
Type of change

New feature (non-breaking change which adds functionality)

Testing
How Has This Been Tested?

[x] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

please no

@pratapaprasanna @sharat87 any chance for you to take a look ?

@pratapaprasanna @sharat87 any chance for you to take a look ?


🚑 hotfix: Fix dependencies for the examples

Solved the problem of dependencies to compile the examples on Linux

Excellent contribution, thank you very much
Solution to issue 7


Barba + wordpress  styles not reloading

Hello & thank for that plugin.
I'm using barba with wordpress and that almost working great. I just have smalls issues :
1.
From my home page when i go to  a new page : ok is work perfectly
but if i go back to my home page, some height for few  are dynamically set via a js file :
but their values are not set again :
$(window).ready( function() {       var windowWidth = $(window).width();       var windowHeight = $(window).height();    $(".projet-container").css("height" , windowHeight * 0.9); });
i also try to copy that code inside a : $(window).on('load', function() { ...
but that not working to
How can i tell to barba to reload my js ?
2.
My structure look like  basically :
< head > All my WP style and others...</ head >
< div class="content" >
< div id="barba-wrapper" >
< div class="barba-container" >
< section id="projects" >
.... content of my all page
	</ section >
</ div >

</ div >
</ div >
< footer >< /footer >
My problem is : if i refresh my page after click on a link i just have the barba container working ? Same if someone arrive on a sub page
all of my head section is not loading.
is that a way to change that. I think i can manage that if i put my barba container with head & footer inside but that loosing the ajax's goal if the whole page is reloading.
SORRY FOR MY POOR ENGLISH...
thank.

Hello @twoclickdesign .
Barba.js uses a PJAX technique, that means that it transforms your website in a kind of Single page application, so your JS is "loaded once".
To run some specific code when switch page you can use barba events or views.
I also suggest you to read this article for more information on how barba.js works under the hood.

Thank. I manage my code to make it work.
I try the views but without success. I guess i miss something. he return me error


Adding an utter_* action in interactive learning

Rasa version:
rasa-core (0.13.6)
rasa-core-sdk (0.12.2)
rasa-nlu (0.14.6)
Python Version: Python 3.6.7
Operating System: Linux- Ubuntu 18.04.2 LTS
Issue: Interactive learning should not throw this warning for an utter_* action because it's an utterance template.  What is the next action of the bot?  (Use arrow keys)
 » <create new action>
   1.00 utter_unclear
   0.00 __main__.ApiAction
   0.00 action_deactivate_form
   0.00 action_default_ask_affirmation
   0.00 action_default_ask_rephrase
   0.00 action_default_fallback
   0.00 action_listen
   0.00 action_restart
   0.00 action_retrieve_image
   0.00 action_revert_fallback_events
   0.00 utter_ask_picture
   0.00 utter_did_that_help
   0.00 utter_goodbye
   0.00 utter_greet
   0.00 utter_happy
   0.00 utter_question_answer

------
? What is the next action of the bot?  <create new action>
? Please type the action name utter_answer_age
Thanks! The bot will now run utter_answer_age.

2019-03-29 14:17:36 ERROR    rasa_core.server  - **Encountered an exception while running action 'utter_answer_age'. Bot will continue, but the actions events are lost. Make sure to fix the exception in your custom code.**
? WARNING: You have created a new action: 'utter_answer_age', which was not successfully executed. If this action does not retu
rn any events, you do not need to do anything. If this is a custom action which returns events, you are recommended to implemen
t this action in your action server and try again.  (Y/n)

Any update on this please?

well, this isn't an error. This is intended. If you don't have your action implemented it can't be executed.  However, this seems to be an utter_ template, so you should be able to hit "no" here.
I'm going to keep this issue and rename it, because it actually shouldn't be throwing this warning if you add an action with an utter_ prefix.

Thank you @akelad for clarifying it.
Yeah, that was my question exactly. Since this is an utter_ action, I think it should not throw any exception when creating this action. Also it does not continue with template creation process after throwing this exception. In this case, the user has to edit the domain.yml manually to create a template for this new utter_ action. I believe, this is not the expected behavior.

yep, @paulaWesselmann will look into fixing it :)

Thank you for the support.

@anoop2503 I'm working on a PR fixing this so that the user can add templates for 'utter_` actions and choose newly created actions from the same session.

Great, thank you @paulaWesselmann

Hey @paulaWesselmann, hope this is still in progress.

Hey @anoop2503 if you need a quick fix for this please look at the PR. The review is in progress and will be merged once we get to it.

sure, thank you @paulaWesselmann

@anoop2503  Hi. Can you share the code through which you started interactive learning. I'm not able to get any command line command to start interactive learning except rasa interactive \   -m models/20190515-135859.tar.gz \   --endpoints endpoints.yml
This doesn't seem to be working for me
I tried this code as well but seems like this doesn't work with my rasa_core version. My rasa_core version is 0.14
python -m rasa_core.train -d domain.yml -s stories.md -o models/dialogue --endpoints endpoints.yml --online


Change QuestionList module to use Accordion

Updated QuestionList to use Accordion instead of List
Used QuestionList on Home and How It Works

I'll take a look at those. I seriously appreciate you pointing out details, it helps me improve for next time. :)


Visual Studio Code extension and Python package

VS Code extension, extension settings, everything is automatic 😎: https://marketplace.visualstudio.com/items?itemName=VladKolesnikov-vladkol.azure-debug-relay
Python package: https://pypi.org/project/azure-debug-relay/
Updated README.

Fixes #3 and #5.

Should we move _check_for_debugging outside the code sample? I am using very similar code (the same) in my samples as well.

Should we move _check_for_debugging outside the code sample? I am using very similar code (the same) in my samples as well.

Great idea for a helper function. One tricky moment is that argparse doesn’t like unknown arguments unless they are passed with a non-default prefix (like +debug instead of --debug: https://stackoverflow.com/questions/12818146/python-argparse-ignore-unrecognised-arguments


Using hmpo-radios the govuk-frontend radio button divider does not get translated

When using the hmpo-radios component.
If you add a divider to your radio button in the fields.js like the below

    newRadioButtons: {
      type: "radios",
      label: "",
      legend: "",
      items: [{value:"Option One"}, {value:"Option Two"}, {divider: "or"}, {value:"Option Three"}],
      validate: ["required"],
    },

https://design-system.service.gov.uk/components/radios/

When you add locales the divider text does not get translated like the other items.
If you add this line
if (item.divider) item.divider = translate(contentKey + '.items.' + item.divider + '.label');
Into globals.js hmpoGetItems. Then you can use the same syntax in your locales files to translate the divider text
fields.yml
newRadioButtons:
  items:
    or:
      label: <or in desired language>

I'd rather leave the legacy/govuk behaviour where the divider being a string is what gets rendered. instead i propose having: { divider: true } to use a default localisation key lookup of fields.newRadioButtons.divider.label and fields.default.divider.label or specifying a key: { divider: true, key: 'full.localisation.key' } to match key specifying functionality of items.
https://github.com/HMPO/hmpo-components/pull/139/files
Also the divider items should be ignored in hmpo-form-wizard when auto-adding an items validator:
https://github.com/HMPO/hmpo-form-wizard/pull/189/files

merged and released (including hmpo-form-wizard update to ignore divider items)


simplify API for reparsing srcset and src attributes on image elements

This change simplifys the API for reparsing elements, if no mutation plugin is in use.

@aFarkas Looks like the original branch for this has been deleted. We still looking to get this in or can we close this one out?

Yes, I want this in.

Ping. Please merge ;-)

Looks good to me. Someone else should probably review as well though.


Embed a .wasm file for the jpeg2000 decoder in order to reduce the bundle size

For reference:
https://github.com/mozilla/pdf.js/pull/17946#discussion_r1566004430

I might be misunderstanding the intent here, however having a separate file seems quite unfortunate given all the ways that the general library can be used:

With the code running in a web-worker.
With the code running on the main-thread, i.e. when "fake workers" are used or in the standalone image_decoders build.
With the code running in Node.js environments.

Also, requiring third-party users to bundle an additional file will likely lead to a support "challenge"...

I'm assuming that the current file-size issue is related to the fact that Base64 is a very inefficient data format?
Hence the following, possibly stupid, idea that unfortunately depends on a new web-platform feature becoming available in Firefox (see this and that):

During building of the external OpenJPEG code, generate a separate .wasm file.
Read that .wasm file (during building), and convert it to a Uint8Array.
Bundle that data as e.g. const wasmBase64Str = wasmArray.toBase64(); into the openjpeg.js file.

maybe I wrongly understood what you proposed but I've the impress that it's almost what it's currently done (I mean embedding the wasm array as a base64 string in openjpeg.js).

My idea would add a Uint8Array in the file, which is more efficient, and during runtime when calling OpenJPEG() convert that into the necessary Base64-string.

But having a string Uint8Array([1,2,3, ...]) should take more space than a base64 one, no ?

But having a string Uint8Array([1,2,3, ...]) should take more space than a base64 one, no ?

Quite possibly yes, I've not really thought a lot about this. Hence me saying that it probably was a stupid idea :-)

That said, I can update the script to build openjpeg in the two ways: a single file and two files, then use the single version for non-Firefox versions and the two files one for Firefox (but in finding a way to remove the document.baseUri).

Yes, if we use this multi-file approach that "must" be limited to the Firefox PDF Viewer to avoid a barrage of issues elsewhere.


Add FEATURE_FLAG for claim UI

We shouldn't display it on prod yet.

need to set assignView: true, only if ASSIGN_UI_FEATURE_FLAG is enabled and isCataloger orisSuperUser` (https://github.com/inspirehep/inspirehep/blob/22f728bead6b016a5b9326e3a5d2e45f91e0e845/ui/src/authors/containers/AuthorPublicationsContainer.jsx#L50)
Use config.js/getConfigFor(flag) to read the state.
flag should enabled locally and on QA but disabled on PROD.


Fix delete person tag bug

Fixed indirect tag deletions to properly get rid of hanging tags (tags that should not exist but are still appear to be) involved in

editContactCommand (contact has tag removed, tag has goes from 1 contact to 0 contacts. With no child-tags, tag should be deleted too)
deleteContactCommand (contact deleted might be the only contact in a tag with no child tags. Tag should therefore be deleted)
editTagCommand (a parent-tag with no direct contacts and only one sub-tag has its only sub-tag removed. Tag should be deleted)
any of the above causing a parent tag to have its only child tag deleted. If this parent tag has no direct contacts, it should be deleted too (same goes for any of its parent tags, etc.)

Update test cases for new methods implemented in ContactTagIntegrationManager that replaces the AddressBook methods in ModelManager.
Added a portion in UG to specify that tags can exist (and thus cannot be added) even if there are no contacts currently displayed that have them..

Just a comment regarding single responsibility principle

My understanding of this is that ModelManager class should definitely not handle the logic of both removing the Person and editing the TagTree.


HBASE-28500 Rest Java client library assumes stateless servers (Adden…

…dum:fix spotbugs warning)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.