Fix RELATIVE_PROMPT and RELATIVE_PROMPT_WO_REF

Description
This PR fixes both RELATIVE_PROMPT and RELATIVE_PROMPT_WO_REF as those were defined in the opposite way i.e. the one claiming to be without reference was the one with reference, and the other way around.
Additionally, I believe that an lstrip may be missing in the templates for both the prompts and the rubrics? cc @scottsuk0306 @SeungoneKim @eltociear
Thanks for the great work with Prometheus 2 🎉

Thank you @alvarobartt for catching this 🙂 I will add the lstrip as well!

Anytime! We are almost done integrating PrometheusEval as a task in distilabel, and it worked great so far with both your model as well as other models like Llama 3 70B, Command R+, GPT-4, etc.; but it's great that Prometheus is only 7B 👏🏻

Thanks great to hear! Sure, let's stay connected!


Home page overflowing

page overflowing
features drop-down bug

kindly assign this issue to me for GSSOC'23

the home page is overflowing through the right and the UI of features drop down is somehow amendable .

kindly assign this issue to me for GSSOC'23

Hey , this is getting fixed in the latest PR , closing the issue.


close socket when connecting to the server fails!

close socket when connecting to the server fails!

code style format does not match: please modify if (MQTT_SUCCESS_ERROR != rc){ to if (MQTT_SUCCESS_ERROR != rc) {

close socket when connecting to the server fails!

thanks for your contribution~


Fix env variables not accessible.

Salut les gars !
As discussed with @Atinux in https://github.com/nuxt/nuxt.js/pull/2171, this PR fixes this issue:
env: {
  FOO: 'bar'
}

console.log(process.env['FOO']); //bar
const key = 'FOO'; console.log(process.env[key]); // undefined

Also, we don't need the @0pt1m1z3r PR anymore. (His/her issue is fixed automatically by this one (side effect).
The principle is to replace directly the whole process.env, so we can access it like a normal object without any trick.
It's (obviously) fully tested (I've added some tests to check the complete env feature (context and process)
We also need to update the documentation, as this warning is not required anymore:
https://nuxtjs.org/api/configuration-env#process-env-
Thanks for the amazing job and see you!

Codecov Report

Merging #2974 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #2974   +/-   ##
====================================
  Coverage   100%    100%
====================================
  Files        23      23
  Lines      1242    1240    -2
====================================
- Hits       1242    1240    -2

Impacted Files
Coverage Δ

lib/builder/webpack/server.config.js
100% <100%> (ø)
:arrow_up:

lib/common/utils.js
100% <100%> (ø)
:arrow_up:

lib/builder/webpack/client.config.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d2bce...da67152. Read the comment docs.

An other thing: for now, we don't transfer automatically the server environment variables to the application, and we need a module to handle .envfiles. Is it by choice, or just because it's not implemented yet in the core?
(for example create-react-app handle both: .env file, and all env variable which start with REACT_APP)
Would you like a pull request with this/theses feature(s)?

@mathieutu @Atinux @clarkdo
This decision does not solve the problem, which solves my PR #2171 .
You just replace only process.env.
So, process.env.object.obj.again will be replace to { // full env object }.object.obj.again. And that's exactly what I decided.
But I also think that for large objects need to use other way (store) instead of process.env.

@clarkdo: Hem.. actually I have no idea of that. I'm looking for that.
@0pt1m1z3r: ok, my bad, I didn't understand that it was your problem. So our PRs are completely opposed 😅! What's your problem with the { // full env object }.object.obj.again? It work's perfectly at the end.
I don't know if we can do a mix of both, I will investigate.

@qm3ster
Your comment makes sense, webpack will replace all process.env to an env object {...}.
Although UglifyJSPlugin may remove some dead and useless codes, but the others may contain the duplicate codes of the env object, if the object is big, if will affect the bundle size and performance indeed.

@mathieutu don't worry about mix. I can fix my PR after merge your PR.
full env object can be very big, and process.env can be use very often. So one code will be repeated many times and take up a lot of space.

Yeah it's relevant and I totally can understand that, but if we cannot handle a mix, ie replace directly process.env.foo to bar and replace process.env to {foo: "bar"}, I don't see any way to fix the issue key = 'FOO'; process.env[key];
If we can do that, it will be perfect both for the bundle size and Uglify!
I'll try to test that today.

Hey!
I've tested a yarn build on my branch, and actually I can't reproduce what you said @0pt1m1z3r!
I've tried a
mounted() {
        //env: {FOO: 'baz}
        const key = 'FOO';
        console.log(process.env[key], process.env.FOO, process.env['FOO']);

        if (process.env.FOO === 'baz') {
            console.log('it should appear');
        }

        if (process.env.FOO === 'bar') {
            console.log('it should not appear');
        }
    },

and when I check in the webpacked file it appears as:
mounted:function(){console.log(Object({NODE_ENV:"production",VUE_ENV:"client",FOO:"baz"}).FOO,"baz","baz"),console.log("it should appear")}

which seams to be totally perfect!!
If your read at the webpack documentation:

Usage
Each key passed into DefinePlugin is an identifier or multiple identifiers joined with ..
If the value is a string it will be used as a code fragment.
If the value isn't a string, it will be stringified (including functions).
If the value is an object all keys are defined the same way.
If you prefix typeof to the key, it's only defined for typeof calls.
The values will be inlined into the code allowing a minification pass to remove the redundant conditional.

So for me it works perfectly out of the box! 🎉
Do you agree?

I precise that in the light of the last finds, this PR should not be a breaking change, and could be merged in the next 1.* release! 😇

@mathieutu I do not understand what you are trying to explain now.
Our PRs are different and they make different changes.
It will not be difficult for me to adapt my PR to your changes.

@mathieutu Pay attention to this:
process.env[key]
replaced to
Object({NODE_ENV:"production",VUE_ENV:"client",FOO:"baz"}).FOO

@0pt1m1z3r I was answering to your comment https://github.com/nuxt/nuxt.js/pull/2974#issuecomment-371764782, where you told that by setting the whole env instead of each key, webpack replace the entire env at each time. I've tested and it's not the case, the default behavior of webpack handle that.
In my piece of code, you can see that when using the standard process.env.FOO and process.env['FOO'] it works exactly the same. It is replaced by a whole object just when you want to take a env variable dynamically (it doesn't know what will be the key), like in the const key = 'FOO'; console.log(process.env[key]); example.
So it doesn't alter the current usage and performances: the actual behavior is unchanged.
The question of nested env (which is in fact a webpack issue, and not nuxt's) is still here, but as you said, it comes easy to handle it.

Could you try with key being imported from another file of more complex than being a string (could be done cacatenation with others variables), Webpack has a feature where it already knows what key value is when it’s simple operations.

In this example, it will be the same as in the dynamic process.env[key] so it will replaces process.env by all the env object. It will do that all the time in that case.
console.log(Object({NODE_ENV:"production",VUE_ENV:"client",FOO:'bar'}})[a.a]
where a.a is a minified variable calculated by webpack.
To summarize again:

for  process.env.FOO and process.env['FOO'] it works exactly the same than before.
for process.env[dynamicallyGeneratedKey] it will replace by the all object.

So, the performances are untouched for the static/standard/old way, and it just allows you to use the dynamic way, even if in this case the all object is used.
I've checked in other projects (React ones), and they have done it this way.

Here we go!
Last commit handle nested object performance, no need to change anything anymore @0pt1m1z3r! 😉
And for information, the replacement feature works with foo.bar.baz, foo['bar'].baz, foo.bar.1.baz, foo.bar[1]['baz'], etc...
I've tested it manually, watching in the compiled files, and added some tests with the values you provided to be sure to handle all your cases:
env: {items: [{id: 1, name: 'Kobe'}, {id: 2, name: 'Michael'}], foo: {bar: {baz: 'hello', 'wi-fi': true}, 'a"-"b': {'b\'c': {}}}}

However, I do not know how to unit test the definePlugin feature and check what was replaced after webpack compilation..
Let me know if I can do something else guys!

waiting for this... :）

@Atinux @pi0 Hi guys, do you need something more to merge it, or is it just a matter of time ?

Hey @mathieutu. Sorry for late answering. Actually, this would be a really good enhancement for Webpack/Nuxt.js. But I have strong reasons to not directly including this for all users (and probably is not recommended)
First, nor webpack or web browsers had never any support for Environment Variables thing. This is just a magical hack of webpack's DefinePlugin to statically replace process.env.* during compile time. Such variables are not actually variable but just a constant value copied everywhere being used. An example that many users may wrongly use when using process.env.object:
  data() {
    const a = process.env.object.obj.x
    const b = process.env.object.obj.y

    return { processEnv: process.env.object }
  }

This will actually compile into this:
/* harmony default export */ __webpack_exports__["default"] = ({
  layout: 'custom-env',
  data: function data() {
    var a = {"bool":false,"string":"ok","num2":8.23,"obj":{"again":true}}.obj.x;
    var b = {"bool":false,"string":"ok","num2":8.23,"obj":{"again":true}}.obj.y;

    return { processEnv: {"bool":false,"string":"ok","num2":8.23,"obj":{"again":true}} };
  },

What if env object was bigger and used in many more places?
Besides of that, this is probably not what you want: "runtime environment variables." We internally talked with the nuxt team and we may instead make a Nuxt module that supports real dynamic env variables using SSR hydration and also supporting .env files. Also if above behavior if what you clearly want, we can have a module for it :)

Hey @pi0 !
Sorry by I don't totally understand your point! 😅
Firstly your example is wrong. If you're trying to compiled it you will have:
data: function data() {
    var a = {"again":true}.x;
    var b = {"again":true}.y;

    return { processEnv: {"bool":false,"string":"ok","num2":8.23,"obj":{"again":true}} };
  },

and it's only because x and y don't exist in obj, It's exactly the same behavior without the PR.
If they do, you will directly have their value: process.env.object.obj.again will be directly compiled as true.
The only two things this PR change are:

Dynamically call an env variable. (process.env[dynamicallyGeneratedKey])
Increase performance of nested object (see https://github.com/nuxt/nuxt.js/pull/2171 for explanation, it includes it)

If you want to transfer the whole env feature to a module, why not, but does it really worth it? Imo this is a pretty current need.
For .env file, a friend of mine have already done a module which is available in nuxt-comunity repo (but it can be perfected).
I know I'm not a good English speaker, so maybe I don't succeed to make me understood,. If one a of the french brothers want to translate, we eventually could exchange in French... 😞

Bonjour!
Hi all. This is a comment and my thoughts related to env vars and not an invalidation of the work done here. I'm sure we all want consistent behavior and I see this ticket looks like the one holding such a conversation.
I'm also, Trying to figure out how to properly handle SSR, Nuxt custom serverMiddleware and client side XHR using Axios that's used all over the place (serverMiddleware, SSR, client-side).
I agree that env variables aren't supported client side.
The intent, for many cases here, I assume, is to make nuxt service know at startup time what settings to use while using exactly the same code and build output.
Because maybe the same build artifact would run from staging.foo.example.org, as much as foo.example.org, than other domain names such as example2.org.
Domain names, TLS or not, API keys, and so on shouldn't be visible in build output.
Instead of  using a module that risk of getting mingled and become part of a build output, maybe by programmer mistake, why not having a server-side endpoint that exposes a selected list of key-values.
GET /env  and ONLY nuxt from server render knows this route and answers with the runtime values set.
Has there been attempts around this idea?
On my side, I'm making a PR to @clarkdo hare that might do just that.
(TODO; place links)

Following up on @pi0's comments, I believe this falls way off the Unix philosophy / standards. Environment variables aren't supposed to be nested objects, or objects at all. Unix environment variables cannot hold complex datatypes across platforms. Use process.env.VAR directly (in a server context) to access the fresh value of an environment variable. Nuxt's env is perhaps misnamed, but intended to provide environment-provided constants in server and client contexts, seamlessly.
Closing this for the time being. @Atinux @pi0 @clarkdo @manniL if you have further comments, please reopen.


Requests Session no longer accepts params

From requests 1.0.0 api for Session doesn't accept any parameter. Following code will break.
from mwapi import MWApi
m = MWApi(host="http://ta.wiktionary.org")

Link to new Api: https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L137

It looks like this was fixed by https://github.com/yuvipanda/python-mwapi/pull/2


menu missing

Thank you. I have found the issue. Enabling Dark Reader causes the menu to disappear. Simply adding the domain to the whitelist and refreshing the page will restore everything to normal.
https://github.com/darkreader/darkreader
This is the value of accounts.default.features when Dark Reader is enabled.

[
  "arkose_enabled",
  "arkose_enabled_for_subscription",
  "beta_features",
  "bizmo_settings",
  "breeze_available",
  "browsing_available",
  "chart_serialization",
  "chat_preferences_available",
  "chatgpt_ios_attest",
  "chatgpt_team_plan",
  "code_interpreter_available",
  "d3_controls",
  "d3_editor",
  "d3_editor_gpts",
  "dalle_3",
  "gizmo_reviews",
  "gizmo_support_emails",
  "graphite",
  "invite_referral",
  "memory_ga",
  "mfa",
  "model_ab_use_v2",
  "model_switcher",
  "new_plugin_oauth_endpoint",
  "paragen_mainline_alternative",
  "plugins_available",
  "privacy_policy_nov_2023",
  "sentinel_enabled_for_subscription",
  "shareable_links",
  "starter_prompts",
  "sunshine_available",
  "user_settings_announcements"
]

Can you help to open network panel in devtool, find backend-api/accounts/check/v4-2023-04-27 API request
And then copy the value of accounts.default.features

Thank you. I have found the issue. Enabling Dark Reader causes the menu to disappear. Simply adding the domain to the whitelist and refreshing the page will restore everything to normal.
https://github.com/darkreader/darkreader
This is the value of accounts.default.features when Dark Reader is enabled.

[
  "arkose_enabled",
  "arkose_enabled_for_subscription",
  "beta_features",
  "bizmo_settings",
  "breeze_available",
  "browsing_available",
  "chart_serialization",
  "chat_preferences_available",
  "chatgpt_ios_attest",
  "chatgpt_team_plan",
  "code_interpreter_available",
  "d3_controls",
  "d3_editor",
  "d3_editor_gpts",
  "dalle_3",
  "gizmo_reviews",
  "gizmo_support_emails",
  "graphite",
  "invite_referral",
  "memory_ga",
  "mfa",
  "model_ab_use_v2",
  "model_switcher",
  "new_plugin_oauth_endpoint",
  "paragen_mainline_alternative",
  "plugins_available",
  "privacy_policy_nov_2023",
  "sentinel_enabled_for_subscription",
  "shareable_links",
  "starter_prompts",
  "sunshine_available",
  "user_settings_announcements"
]

In Firefox, aside from Dark Reader, Privacy Badger also seems to cause the menu to disappear.

My menu is also missing. I'm using a Chromium-based browser and without Dark Reader. My features list is exactly the same as SzVLsY's, though.

I'm using Arch Linux 6.9.9-arch1-1 with Brave "1.68.141 Chromium: 127.0.6533.120 (Official Build) (64-bit)". I also have a different browser installed: base Chromium "126.0.6478.182 (Official Build) Arch Linux (64-bit)" installed.
For both of my two OpenAI accounts, the Export button does not show on Brave, and for both accounts, the Export button still shows on Chromium. In both cases, I'm only using Tampermonkey. Both Chromium and Brave were using the same v4-2023-04-27 file.
I could try doing some further debugging on my end, including trying Firefox, if I have time later

I don't have Arch Linux environment, but I will be able to test it on Mac M-chip tomorrow.

In at least one of my Brave tests I had no extensions enabled besides Tampermonkey, so I don't think any others are interfering, but I could try private mode too later. Besides macOS, maybe also try testing Brave on Windows 11, in case that's the problem

Hey, can you check this?
I think they are A/B testing the remix version.

source: https://twitter.com/btibor91/status/1828342132643332514

Both Brave and Chromium have <html data-build="remix-prod-(hash...) in the source for me. Both have the same hash, starting with b13f36.
However, I apologize, as I've realized that some of my previous comments were misleading. I did previously attempt to run the exporter script without any other extensions active, but I see now that Tampermonkey wasn't running correctly there, because that profile had Developer Mode off.
In my other profile, with more extensions, I did some tests and it looks like the Export button disappears when the Stylus extension is active, even if the injected stylesheet I configured doesn't apply to any elements on the page.
It still might be related to Remix because even with Stylus active, ChatGPT Exporter has been working up until a few days ago

@rndwalker maybe you can check these

https://www.torn.com/forums.php#/p=threads&f=67&t=16255988&b=0&a=0
https://github.com/lisonge/vite-plugin-monkey/issues/1

CSP issue cannot be fixed on my end. 🙏

@rndwalker But im curious, when did you start to notice that the export button disappeared?

@rndwalker Not sure what's your enviroument, but I can successfully see my script on a brand new chrome profile with only Tampermonkey and this script. I do see other scripts triggered the CSP error on my PC after disabling the force remove CSP restricition options, but this chatgpt-exporter doesn't require that option to be enabled. So maybe you can try disable other scripts and test again?

I assume everyone here seems hit on different walls to see the menu.

CSP issues
Tampermonkey not enabled / haven't follow the steps after updating to MF3
The script itself do have issue in some scienrio

During the testing, I noticed that the menu will disappear if the screen is not big enough to see the left panel on page load. I will release a fix and try to enhance the menu injection to avoid any other scripts/extentions to corrupt the menu.

I just released v2.24.5. Please help to see if it fixes the issue.

Based on https://github.com/pionxzh/chatgpt-exporter/pull/252#issuecomment-2336761125, I assume this issue has been fixed. I will close the issue. Let me know if you still cannot see the menu.

I just released v2.24.5. Please help to see if it fixes the issue.

I tested the new version, and when I enable Dark Reader, the menu disappears again. Additionally, the menu also disappears when I enable some scripts. However I would say there is some improvement, as I no longer need to completely disable the extensions; I just need to add them to the whitelist. Thank you for your work.

Can anyone share a combination that can reproduce the issue? I tried these, all work correctly.
* Windows 11, Chrome 127

* Windows 11, Edge 128

* Windows 11. Firefox 130 (With `Privacy Badger`)
  ![image](https://private-user-images.githubusercontent.com/9910706/364039097-8ee8921d-a370-4e1d-8e08-0816c1ca5e16.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU4ODkxOTEsIm5iZiI6MTcyNTg4ODg5MSwicGF0aCI6Ii85OTEwNzA2LzM2NDAzOTA5Ny04ZWU4OTIxZC1hMzcwLTRlMWQtOGUwOC0wODE2YzFjYTVlMTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDlUMTMzNDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWJhNDI1YTg5MjdjODlhNjI1OTkxMDU2YTQwOGRjZGEwOWY3NDg2YWZjYzFkOWExZWIzZTIyYTRhOGIyMmY0NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.op_bm-Rqw3LhwazWoWFT9IkGxEhwZkkbsRDZQIHZC-U)

All tested with the dark reader on/off
btw, if you are using userscript manager other than Tampermonkey, please also let me know

On Windows 10 with Chrome 129 and version 2.24.6, the menu disappears after enabling Dark Reader.
Sometimes, the menu works fine one day and suddenly disappears the next. When I tried installing the PR version I compiled, everything was fine the first night, but the menu disappeared again after a day. The browser extensions and scripts were not updated.

when I enable Dark Reader, the menu disappears again
That's weird. I also tested it with Dark Reader, but it works totally fine.

I just need to add them to the whitelist
Can you elaborate more on what whitelist you changed?

when I enable Dark Reader, the menu disappears again

That's weird. I also tested it with Dark Reader, but it works totally fine.

I just need to add them to the whitelist

Can you elaborate more on what whitelist you changed?

when I enable Dark Reader, the menu disappears again

That's weird. I also tested it with Dark Reader, but it works totally fine.

I just need to add them to the whitelist

Can you elaborate more on what whitelist you changed?

Update:
Today, both versions completely stopped working. This is really strange—I simply refreshed the page, and then the menu disappeared. I've tried restarting the browser, and today I disabled all extensions and scripts except for the export script, but that didn't work.

when I enable Dark Reader, the menu disappears again

That's weird. I also tested it with Dark Reader, but it works totally fine.

I just need to add them to the whitelist

Can you elaborate more on what whitelist you changed?

Today, I noticed that when I refresh the page, the menu appears, and then when the page finishes loading, the menu disappears. Version 2.24.6.
When I reinstall version 2.24.4, the menu appears fixed in the top left corner, but when I refresh the page, the menu disappears. I have to resize the window again.

Thanks for the verification. I'm trying to fix it in #258

The Remix framework must be doing this. It constantly monitors the elements it manages, and if any changes are detected, it immediately reverts them back.


Add RPInteraction

Review page interaction - handy and pretty way to ask for review.
Project URL
https://github.com/nbolatov/RPInteraction
Category
Animations
Description
Add RPInteraction
Checklist

[X] Only one project/change is in this pull request
[x] Has unit tests, integration tests or UI tests
[X] Addition in chronological order (bottom of category)
[X] Supports iOS 9 / tvOS 10 or later
[X] Supports Swift 4 or later
[X] Has a commit from less than 2 years ago
[X] Has a clear README in English

          1 Warning

:warning:
Found 3 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

850
301
https://github.com/alexdrone/FlexboxLayout redirects tohttps://github.com/alexdrone/flexboxswfit_deprecated

878
301
https://github.com/GrupoZapVivaReal/Compose redirects tohttps://github.com/grupozap/Compose

3148
302
http://ios-goodies.com redirects tohttps://ios-goodies.com/#_=_

  Generated by :no_entry_sign: Danger

@nbolatov We cannot merge your PR yet until you write some tests for your lib. Feel free to open another PR once it is ready.


The cli module has no method err(), should be error()

Fixes the following TypeError when unable to connect to docker socket
TypeError: Object #<Object> has no method 'err'
    at ~/src/docker-mon/index.js:38:24
    at Request._callback (~/src/docker-mon/utils/index.js:20:20)
    at self.callback (~/src/docker-mon/node_modules/request/request.js:373:22)
    at Request.emit (events.js:95:17)
    at Request.onRequestError (~/src/docker-mon/node_modules/request/request.js:971:8)
    at ClientRequest.emit (events.js:95:17)
    at Socket.socketErrorListener (http.js:1552:9)
    at Socket.emit (events.js:95:17)
    at net.js:441:14
    at process._tickCallback (node.js:442:13)

npm install installed cli:v0.6.5

Thanks!


Avoid Android crashes caused by onDestroy NullpointerExceptions

A NullpointerException in onDestroy() method caused crashes, that was reported in play store. This pull request try to avoid crashes.

+1

You have created a NullPointer in your fix. If rootView is null, your catch-block will throw like the original code did.


Add option to return signedTicket object in "negotiate"

In cases when we dont work with money we can do simplified attestation - validate ticket signature only
it will improve UX and require single click only
but we can't share signed ticket to any requestor, because it can be copied and used on other pages. (scammer can use hidden iframe to reads all user tickets data if we dont use whitelist)
what we have to update to make ticketAttestation flow secure as possible:

move tokenConfig to separate file so all TN instances will read it from single location. its important to avoid confision of different configs for same token. I implemented it simply: https://devconnect.smarttokenlabs.com/devconTokenConfig.js . Later we can read config from XML file.
Add to the config "whitelist" field, where we can add list of domains
negotiator have to return to Whitelisted domains decoded tickets + signed Ticket. Other domains will receive only decoded tickets (like it works right now)
Remove signedTicket from input data for authenticate()

@micwallace @AW-STJ @nicktaras , does it make sense?

@oleggrib looks pretty straight forward to me. I'll get this done over the next few days.

Added to the project board, next sprint.


Adding config option to toggle zprint

zprint is an awesome pretty-printer for EDN files but it can get pretty slow once its input starts getting large. This PR adds a catchpocket config option to skip zprint formatting and just use (pr-str) to output results, and an option to pass in formatting configuration parameters to zprint.
I've also bumped some dependencies and cleaned up the circle.yml config somewhat.

🍔


Initializing inside a transformed CSS block invalidates CodeMirror's positioning assumptions.

CodeMirror assumes that it is being initialized in a non-transformed state. These assumptions have bearings on a lot of math within the editor for handling layout positioning.

For anyone that wants to display a transformed codemirror, here is a partial workaround:
reverse-transform the codemirror cursor by the inverse of the overall transform.
That is, if you have something like this that transforms some codemirrors:
$(element).css({
    transform: `scale(${x})`
});

Then reverse the effect of this on the codemirror cursor by scaling by 1/x:
$('.CodeMirror-cursors').css({
    transform: `scale(${1/x})`,
    transformOrigin: '0 0'
});

This will put the cursor in the right place again. However, the codemirror-sizer element for some reason still has issues, so the code and cursors will display fine, but the size of the code mirror box will be off. You'll get some blank space or a scroll bar that does nothing.

For anyone that wants to display a transformed codemirror, here is a partial workaround:
reverse-transform the codemirror cursor by the inverse of the overall transform.
That is, if you have something like this that transforms some codemirrors:
$(element).css({
    transform: `scale(${x})`
});

Then reverse the effect of this on the codemirror cursor by scaling by 1/x:
$('.CodeMirror-cursors').css({
    transform: `scale(${1/x})`,
    transformOrigin: '0 0'
});

This will put the cursor in the right place again. However, the codemirror-sizer element for some reason still has issues, so the code and cursors will display fine, but the size of the code mirror box will be off. You'll get some blank space or a scroll bar that does nothing.

Hello,
Just giving my two cents on that issue since I experienced the same problem. Based on the answer from @robertstrauss, here is a code to fix the mouse cursor position and also user selected code bg/position:
.CodeMirror-cursors,
.CodeMirror-measure:nth-child(2) + div{
    transform:scale(1.1); // Reverse scale from 0.9
    transform-origin: 0 0;
}

Hope it helps!

Hello,
Just giving my two cents on that issue since I experienced the same problem. Based on the answer from @robertstrauss, here is a code to fix the mouse cursor position and also user selected code bg/position:
.CodeMirror-cursors,
.CodeMirror-measure:nth-child(2) + div{
    transform:scale(1.1); // Reverse scale from 0.9
    transform-origin: 0 0;
}

Hope it helps!

For what it is worth, using inputStyle: "contenteditable" works much better than inputStyle = "textarea" when a codemirror editor is inside of a CSS tranform.

Note: this happens, e.g., with reveal.js when the window size changes #4189
and is quite annoying.

Codemirror 6 apparently can handle scale() but not more complex transformations.

Possible more robust workaround (based on @acf-extended, but using more reliable addressing of containers than jQuery) for CodeMirror 5:
Reveal.on( 'resize', (event) => {
  let scale="scale("+(1/event.scale)+")";
  document.getElementsByClassName('CodeMirror').forEach((x)=>{
    x.CodeMirror.display.cursorDiv.style.transform=scale;
    x.CodeMirror.display.cursorDiv.style.transformOrigin="0 0 0";
    x.CodeMirror.display.selectionDiv.style.transform=scale;
    x.CodeMirror.display.selectionDiv.style.transformOrigin="0 0 0";
})});

Multi-line selection appears to be still unreliable, it may assume a wrong line height due to the scaling.


Update .all-contributorsrc

Adding Otis and Tom who both wanted to be acknowledged for their contributions :)
Thanks Tom and Otis

Merging to my master branch


Use extras to reduce size of dependencies

As contexual has a lot of depedencies that are not necessary for all use-cases, would it be possible to split the depedencies in different sets of extra requirements (similar to the strategy of https://hanxiao.io/2019/11/07/A-Better-Practice-for-Managing-extras-require-Dependencies-in-Python/ ). This would help reduce the size of the installed depedencies and also reduce potential version conflicts.

@skbaur  Thank you for the suggestions. It's indeed a pain point for some library users who only want to use part of the modules. We will follow up to work on this. Here is the todo card: https://github.com/SAP/contextual-ai/projects/1#card-70787117
Feel free to fork and raise PR if you already have some solutions.


typo in requirements.txt

There is a minor typo in the requirements.txt file on line2 where there is an unnecessary '=' sign after logru:
ftfy
loguru=
matplotlib

The below pull request should get rid of it.

@Hiromasa-H PR merged:)


I have a Tobii 4C eye tracker, but I am unable to use it.

After importing this package into VRCFT, the device can be detected but cannot be used. It shows as unsupported. Could you please add support for my Tobii 4C eye tracker in the future?

Thank you for your suggestion.
Currently the plugin only supports wearable devices (VR headsets).
At this time, I do not plan to add desktop devices support.
However, I am open to accepting a pull request if you or someone else would like to contribute it.


Fix keras version problem

I met this problem when I try to fix this issue, and here is the bug-triggered script:
import tvm
import tvm.relay as relay
import numpy as np
from tensorflow import keras
from tensorflow.keras import layers, models

input_shape = (1, 5, 7, 6, 2)

input_data = np.random.random(size=input_shape)
x = layers.Input(shape=input_shape[1:], dtype='float64')

layer = keras.layers.Conv3D(filters=1, kernel_size=3)
layer.set_weights(layer.get_weights())

y = layer(x)
model = models.Model(x, y)
model.summary()
res_keras = model(input_data)

shape_dict = {'input_1': input_shape}
mod, params = relay.frontend.from_keras(model, shape_dict,layout='NDHWC')
with tvm.transform.PassContext(opt_level=3):
    model = relay.build_module.create_executor("graph", mod, tvm.cpu(0), 'llvm', params).evaluate()

test_x_tvm = input_data
res_tvm = model(tvm.nd.array(test_x_tvm.astype('float64'))).numpy()

relay.frontend.from_keras invokes the following error:
Traceback (most recent call last):
  File "/Users/mahaoyang/repo/tests/python/test.py", line 21, in <module>
    mod, params = relay.frontend.from_keras(model, shape_dict,layout='NDHWC')
  File "/Users/mahaoyang/repo/tvm/python/tvm/relay/frontend/keras.py", line 1530, in from_keras
    import keras.engine as E
ModuleNotFoundError: No module named 'keras.engine

The reason for this error is that keras.engine has been changed into keras.src.engine in my installed tensorflow(2.13.0), in which keras's version is 2.13.1.
So I add a if to judge the version of keras and fix this compatibility issue.

@echuraev

Thank you for the fix. LGTM!


Update index.html

Updated the html file for the dark theme code added in css

I don't see any changes to the site, you just added a link to the index file


Add setters macro

This might not be worth it, but I decided to play around with creating a macro_rules macro for declaring setters in request builders. This reduces the amount of repetition.
Setters are now declared like this:
setters! {
  user_agent: &'a str => Some(UserAgent::new(user_agent)),
  activity_id: &'a str => Some(ActivityId::new(activity_id)),
  consistency_level: ConsistencyLevel => Some(consistency_level),
}

I also removed the private getters since they're not really needed.

@MindFlavor Thoughts on this?

I really like it, it makes the code much more lean and manageable. I also agree that getters are not needed in request builders, further simplifying the code.
Great work 🥇 !

@MindFlavor this is ready for review!


Mode 1332 ported CndSequencer to 3.x

updated Windows binary compatibility in the binary store
fixed cache sizes when copying files

Invalid commit (master)


Add config section

@josegonzalez as per req

This isn't just a configuration section, these are all 'new' packages to be listed so might take a little time to check them all out. Maybe submit them separately?
I haven't checked them all yet but I vouch for @josegonzalez's package as I use it on a daily basis.
The php-wise package should be completely removed (only one that was on the list already) because it has been abandoned 3 years ago!

@jadb lol what? It doesn't take long to check a package, like 5 seconds maybe. You're right about php-wise though.

@m1 please read the Contributing guidelines.
Closing this as it does not adhere to the guidelines and I suggested making changes already.


update .gitattributes

Some files were moved or deleted.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

ref: #5737 #5191 #5964

Thank you @totoprayogo1916


Auto commenting feature for new PR raised

This feature aims to address the problem of delayed and inconsistent communication following the raising of PRs. By automatically commenting on PRs as soon as they are raised, it ensures that contributors receive immediate feedback and acknowledgment for their efforts. This fosters a positive and supportive environment for collaboration, encouraging continued participation and engagement from contributors.
Could you please assign me this issue under GSSOC'24.

Hi @suhanipaliwal
Thank you for your suggestion and for taking the initiative to improve our project! 😊
The auto-commenting feature for new PRs sounds like a great idea. It will definitely help in providing immediate feedback and acknowledgment to contributors, fostering a positive and supportive environment. This can encourage continued participation and engagement, which is fantastic for our community!
I've assigned this issue to you under GSSOC'24. We're excited to see your implementation and appreciate your efforts to enhance our project! 🚀


net: icmpv4: fix incorrect IP header checksum

IPv4 header's checksum was set when 'setup_ipv4_header', but in that
times IPv4 header's source ip and dest ip address haven't setted. So
it may be set an incorrect checksum.
Fixes: #7989
Signed-off-by: qianfan Zhao<EMAIL_ADDRESS>

Is the issue also present in net_icmpv4_send_error()?
Looks like it to me.

Yes they has the same problem and I had fixed it

recheck

Codecov Report

Merging #8058 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master    #8058   +/-   ##
=======================================
  Coverage   64.54%   64.54%
=======================================
  Files         420      420
  Lines       40131    40131
  Branches     6759     6759
=======================================
  Hits        25902    25902
  Misses      11106    11106
  Partials     3123     3123

Impacted Files
Coverage Δ

subsys/net/ip/icmpv4.c
39.88% <50%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386b3e6...655cb46. Read the comment docs.


Correct docstring for Retry backoff factor

Correct the docstring for the backoff_factor argument to the Retry object, to reflect the fact that a wait is not applied before the second try, as per issue #847

Thank you very much! :)


Fix output

Thanks @lukasz-mitka. Would you mind fixing the test as well?

Done

You guys rock!!!

@sondrelg waiting for a release then!

v2 released, finally. Thanks for all the great help @lukasz-mitka :clap:


Update google groups.

Sync members of the google-kubeflow-team.
Create a new team for Googlers with admin privileges on kubeflow.org resources

This change is

/assign @richardsliu

/lgtm
/approve

/approve


Hide,Copy Button: Add option for tooltip

Add a new prop to show a tooltip on buttons while hovering
Also add the TCustomize prop on both the components

Once above points are completed:

Remove the custom hide and custom copy components from the credentials component.

Can I work on this? @AbhinavMV

Hi @AbhinavMV,  I joined the Moralis discord but unable to find web3uikit channel in there. Could you please help me with that?

Hey @niteshseram
here is the link -> https://discord.com/channels/819584798443569182/932913723503431680
if you still have trouble here is my discord username -> Abhinav_MV#8280 , feel free to ping me 🙌🏻

Finally, I found the right discord server. The server link in the readme of this project was taking me to some other discord server
Thanks @BillyG83 @AbhinavMV


RDM-8829 - flag to enable/disable case-assignments rest api.

Merged relying on the nature of change, code reviews and current stage of development, which would collectively reduce the value of a dedicated further QA of this.


Docstring everything:

Add docstrings to all methods in the code, so that the Sphinx docs that are
generated will document all the code in our repository.
Where docstrings existed already, they are fixed where appropriate so they are
displayed properly in HTML.
Update the Sphinx configuration so that the README document is automatically
read into the index.html file, so that the content is reproduced in the HTML
format too.

Once this code lands, the updated docs will be visible at https://tiernan8r.github.io/quantum_computing_project/


chore: skip VHD scanning during official builds

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.409%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
2620

Relevant Lines:
3669

💛  - Coveralls


Unexpected behavior for WebviewMessageParticipant interface

Currently, using the WebviewMessageParticipant instead leads into a non-obvious pitfall:
https://github.com/TypeFox/vscode-messenger/blob/f8746a5717931a900309729d356dc239194354a5/packages/vscode-messenger-common/src/messages.ts#L26-L32
As both webviewId and webviewType are optional, I believed them both to be truly optional. However, at least one of them is needed. This fact is not reflected in the type definition. Instead, the type should probably look something like this:
export type WebviewMessageParticipant = WebviewIdMessageParticipant | WebviewTypeMessageParticipant;

export interface WebviewIdMessageParticipant {
    type: 'webview'
    /** Identifier of a specific webview instance. */
    webviewId: string
}

export interface WebviewTypeMessageParticipant {
    type: 'webview'
    /** Webview panel type or webview view type. */
    webviewType: string
}

Changed as proposed. Also added isWebviewIdMessageParticipant to check the WebviewMessageParticipant type
Thanks @msujew !


Library name change request

Library repository URL
https://github.com/dvarrel/AsyncTCP

Hi @dvarrel. I am confirming your request.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will close this issue when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

Solved in https://github.com/arduino/library-registry/pull/2335#issuecomment-1377582030


Instr MCPL split should not enforce component names

The Instr method that splits an instrument in two, inserting an MCPL output and an MCPL input component at the break, should not force specific component type names to allow variants to be used.
By adding keyword inputs to its signature, new MCPL output/input components could be used without modifying mccode_antlr further.

Enabled by #64


[Tech Debt] refactoring getInitActions(settings.epic.ts)

EPAM AI DIAL chat version
0.20.0
What happened?
add flag for each reducer and init only first time
Confidential information

[X] I confirm that do not share any confidential information

Verified on staging successfully.
Waiting for UAT to test performance optimization.
Reported #2642


[BUG]I cannot read an excel file without styles.xml

Argument 1 passed to PhpOffice\PhpSpreadsheet\Reader\Xlsx\Styles::__construct() must be an instance of SimpleXMLElement, boolean given, called in ***/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Xlsx.php on line 568

Please fill in the issue template.
Also please report this at the right package. The exception comes from the PhpSpreadsheet package.


Input toolbar does not show up

Hi
I add a contact selection bar at the top of the view controller (like iMessages). The input toolbar does not show up when i tap on the searchbar to search contacts! Can you help for this?
Thanks
Ninh

Thanks @siliconprime-ninhvo ! :smile:
Please provide all the information in the issue template so we can help!
And don't forget to read our contribution guidelines. :blush:


Handle Memory / CPU Configuration more explicitly?

Is your feature request related to a problem? Please describe.
My experience with nf-core pipelines suggests that memory requirements are handled centrally, e.g. by defining these in a base.config file on a per-process level, which can then be imported by various infrastructure profiles easily. (example here for the rnaseq pipeline)
This makes it incredibly easy for users to define their own hardware-specific profiles by adding on top, e.g.
base, , (singularity|docker) - done!
I was quite unsure how to do this in Sarek properly and had to come up with an entire profile describing these resource requests, hardware specific configuration parameters etc pp.
One issue was for example in using the buildReferences.nf script, when the toGiga() method requires a memory parameter to be set, which wasn't done in our binac profile so far. There was no mentioning of that in the documentation, so I added it myself, but more newbie users might be lost with that info unfortunately.
Describe the solution you'd like
Being able to define just the hardware specific requirements (e.g., cluster scheduler, max memory, max cpus) and then using the pipeline as is :-)
Describe alternatives you've considered
Adding my own profiles from scratch, which is quite a lot of work and would be required by anyone else trying to use the pipeline too :-)

cf #504 #559

Done on nf-core/sarek


Introduce an oauth-scope-bindings.xml.j2 file to add scope binding via deployment.toml file

Describe the issue:

Up to IS-6.0.0 oauth-scope-bindings.xml file is not tempted (ie; doesn't have an oauth-scope-bindings.xml.j2 file)
Therefore, the user should directly edit the oauth-scope-bindings.xml file, if he introduces new permissions with feature customization and he wants to add scope binding for each permission.
If there is a templated j2 fie which supports adding new scope bindings via deployment.toml file would be easier.

Need a migration issue for this. If anyone added more configs to oauth-scope-bindings.xml file manually, they need to add relevant deployment.toml configs with the introduction of oauth-scope-bindings.xml.j2

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix CI

Add missing packages (install them directly for now).

xref https://github.com/NSLS-II/profile-collection-ci/issues/2

This PR is outdated, the fixed will go into #19.


Display error message on unsupported routing table configuration

Defines an error to represent unsupported routing table configurations, UnsupportedRoutingTable.
Instructs the user to disconnect other VPNs, as we hypothesize this is the leading cause for multiple interfaces with gateways (a.k.a. unsupported routing tables).
Introduces error codes in OutlineService.

@alalamav Forgot to remind you to make sure the new OutlineService.exe is checked. Thanks! (just filed an issue to presubmit this).


Fix adds rm in-use container so rmi can succeed

Fixes https://issues.redhat.com/browse/PORTENABLE-481

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.888%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/actions/extract_index.go
0
5
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
18

Relevant Lines:
2028

💛  - Coveralls


Few spelling fixes for a template.

I understand this is a trivial change, feel free to close this issue and commit the changes by Yourself.

Thanks!


Improve import quickfix

[x] All compiled assets are included (atom packages are git tags and hence the built files need to be a part of the source control)

I have improved quickfix to import modules.
These are the behaviour I fixed.
import statement generation for default exported module
In my case, all of my modules are default exported. Therefore, I should remove brackets all time after quick fixed import.
So I append a quickfix to generate not import {A} from "./A" but import A from "./A".
I guess there would be other people using default exported modules.
path generation for importing js file with d.ts
When I use js files with d.ts, the path generation for the module is invalid.
Assume there was A.js and A.d.ts . When I quickfixed that to import , quick fix would generate import A from "./A.d". But it should be import A from "./A"
path generation for external modules not specified as typings
If you have module A, and package.json of that module specifies node_modules/A/index.ts as 'typings',quickfix should generate as import A from "A". I know this feature works fine.
But if there was node_modules/A/B/C.ts, that should be able to be refered as import C from "A/B/C". But, that import would be generated as ../node_modules/A/B/C".

Is there any problem to merge?

Nope. I looked at it yesterday and it seems fine, just need to find some time to test. Will try to get to it this week.

LGTM, minus the failing specs. Something might have messed up when you were fixing the indentation.

👍


Idea: Bulk applying techniques

This is a brain dump but thinking of standard techniques to apply configuration or lists, reporting, in bulk but generalized.
e.g.

JSON list of sites, configuration
CSV, Text Files

We have may samples covering different patterns, so just thinking of having a sample to cover some of those.

Perhaps combining it with the SP Starter kit?


Make approval UI talk to REST endpoints

Follow up to

https://github.com/ProfessionalWiki/PageApprovals/issues/2

@waximabbax you finished this, right?

This will be affected by #37. I think it will make sense to update the JS as part of that task.

@waximabbax you finished this, right?

Yes.


Update Valo dependency

Remove copy-paste vertical tabs from “hide-scroll-buttons” Valo variation demo.

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Logo is too small on mobile

Fixed! turns out the original media query made the logo smaller and lower on the page for some reason.


Client clock 1 sec faster than server -> HTTP Error 401: UNAUTHORIZED

I sync my time with the internet and was able to poll without exception. I reduced my time for 1-9 sec. Server should accept it cause 15 sec difference are allowed. The calculation is wrong.  Header date to old! 86392 >= 15

workaround. sync your time with the internet and reduce it ~5 sec. That way you should not be faster than the server.

There is a second bug in the header date validation. Delta.seconds only returns the seconds of one day. Next day, week, year it is possible to send the old header date again.
Fixed that as well. I will add some unit test later.

Retest with new server version (develop branch) was ok. Both bugs are fixed.


Control order of search result fields

There is no way to control the order of the result fields in the hosted app. Previously you could do this by typing the field names in the order you want and separating them with commas. There appears to be no way to do this now with the new UI (which is much better than the old one, thank you!) Perhaps add the ability to reorder the list of field names in the configuration page?

Glad to hear that you like the UI changes! This is an interesting idea. I'm going to put it in the backlog for consideration in a future release.

@karmstro77 : For the next AGOL release (Q1 '16) we are replacing the current search widget with the same one used in many of the other templates. The new widget lets you specify the order of the fields returned in the search results.

Change was reverted from 4.1


Add objectSelector for portieris webhook

Configured to run if anything is different from the labels on the Portieris pods themselves
https://github.com/IBM/portieris/issues/112

Nah. This is a super bad idea, anyone could just match the labels on a deployment in a namespace where they're allowed to deploy and skip the webhook.


buiild(cargo): Update deps

https://github.com/swc-project/swc/blob/4efefb0f4ef4fcbc50b32dd7b9e7b21509ab7309/crates/swc_ecma_transforms_react/Cargo.toml#L28 Could  (sha-1 = "=0.10.0") also be updated, another crate I am trying to use is conflicting as it's trying to use ^0.10.1

Closing as obsolete


Missing dependencies

Webpack is throwing the following errors at me after installing and trying to import mixpanel:

ERROR in ./~/https-proxy-agent/https-proxy-agent.js
Module not found: Error: Cannot resolve module 'net' in /home/alexander/Documents/Programming/reactfire/node_modules/https-proxy-agent
 @ ./~/https-proxy-agent/https-proxy-agent.js 6:10-24

ERROR in ./~/https-proxy-agent/https-proxy-agent.js
Module not found: Error: Cannot resolve module 'tls' in /home/alexander/Documents/Programming/reactfire/node_modules/https-proxy-agent
 @ ./~/https-proxy-agent/https-proxy-agent.js 7:10-24

net and tls are built-in Node.js modules. If you're targeting browser environments you should use the mixpanel-browser package rather than mixpanel-node.

Glad this seems solved, going to close this issue out.


Add Various Test Reports for RL 8.5

NOTE: This pull request template is being created and may not be complete.

Author checklist (to be completed by original Author)

[x] I have signed the Rocky Open Source Contributor Agreement (ROSCA).
[x] I certify this contribution complies with all conditions of the
Testing repository contributions guide
[x] If applicable, steps and instructions have been tested to work on a real
system.
[x] I have installed pre-commit and all commits in this PR pass.
[ ] If applicable, I have GPG signed all commits and unploaded my private key
to Github.

Rocky Testing checklist  (to be completed by Rocky team)

[ ] 1st Pass (Check that contribution is good fit for project and the Testing
repository is the appropriate location)
[ ] 2nd Pass (Confirm all pre-commit tests pass)
[ ] 3nd Pass (Technical Review - check for technical correctness)

VMware Workstation 16 Player VM with Secure Boot, Windows 10 host;
Microsoft Hyper-V VM with Secure Boot, Windows 10 host.


Unable to start the server.

Need help to run this project.

There is no dev task in gulpfile.js.
gulp dist is throwing error.

[13:51:41] Requiring external module babel-register
C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:180
throw new ReferenceError(messages.get("pluginUnknown", plugin, loc, i, dirname));
^
ReferenceError: Unknown plugin "react-hot-loader/babel" specified in "C:\Users\singmaya\Documents\GitHub\grommet-ferret\.babelrc" at 1, attempted to resolve relative to "C:\Users\singmaya\Documents\GitHub\grommet-ferret"
at C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:180:17
at Array.map (native)
at Function.normalisePlugins (C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:158:20)
at OptionManager.mergeOptions (C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:233:36)
at OptionManager.init (C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:367:12)
at compile (C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\lib\node.js:103:45)
at loader (C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\lib\node.js:144:14)
at Object.require.extensions.(anonymous function) [as .js] (C:\Users\singmaya\Documents\GitHub\grommet-ferret\node_modules\babel-register\lib\node.js:154:7)
at Module.load (module.js:487:32)

I have the same issue, the error is
Task 'dev' is not in your gulpfile.

can you try npm install react-hot-loader --save-dev ?
If this works, can you send a pull request to add it to out package.json?
gulp dev is coming from the toolbox.

It did not work, still the same issue

can you confirm the version of node and npm?

The node version is 7.5.0 and npm version is 4.1.2

npm start server/server.js will run dev server

same for me:
[15:17:00] Using gulpfile ~/desa/tmp/work/grommet-ferret/server/gulpfile.js
[15:17:00] Task 'dev' is not in your gulpfile
[15:17:00] Please check the documentation for proper gulpfile formatting
I tried both solutions npm install react-hot-loader --save-dev and npm start server/server.js.

I'm currently updating ferret to the latest grommet and the latest grommet-cli. I will push the changes very soon.

@alansouzati hey, did you solve it? Because I'm having the same problem witch 'react-hot-loader/patch'

@burakuluu cc @alansouzati I think the README is just incorrect (or outdated)? I had these errors but then I looked at the code and was up and running with these commands -- two terminals, run both from the root of the repo (no cd-ing into server/)
first terminal
npm i
npm run start:dev

second terminal
gulp dev

also, the prod server part can be fixed with
npm run build
npm run start

Can't just run node server/server.js directly because its needs babel to transpile

Hi,
running npm run start:dev results in a crash

[nodemon] app crashed - waiting for file changes before starting...

running npm run build and start results in errors for me

npm ERR! Darwin 16.5.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v6.10.2
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: gulp dist
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'gulp dist'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the grommet-ferret package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp dist
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs grommet-ferret
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls grommet-ferret
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/daniellozynski/grommet-ferret/npm-debug.log

@carolineartz I can confirm that running the 2 commands you provided fixes the issue. The Server starts and also the app. You can go ahead and create a PR with the changes to the README.

@radumiron sounds good, will do.

Updated the README instructions to make them more accurate and complete, and verified that they work.
Added the cross-env package as a dev dependency and added it to the start:dev script.


[Bug Report] TimePicker to set the format attribute, the Li element shows dislocation, not vertical center

Element UI version
1.3.2
OS/Browsers version
Latest
Vue version
2.3.3
Reproduction Link
https://jsfiddle.net/xhb186fg/
Steps to reproduce
Just click
What is Expected?
正常显示
What is actually happening?
li元素显示错位，字体没有垂直居中

Looks they are centered. What is your OS and browser?

确实无法居中。
系统：macOS 10.12.4
浏览器：chrome： 58.0.3029.110

@Leopoldthecoder

ubuntu 16.04 / 64 bit, chrome 58.0.3029.110 (64-bit)
I also test in macOS 10.12.4, chrome 58.0.3029.110 (64-bit), but it looks very normal. It is strange.

@Leopoldthecoder
Windows 10 1703 64bit
Chrome 58.0.3029.81 (64-bit)
FireFox 52.0.1 (64bit)
Microsoft Edge 40.15063.0.0
These browser got same problem on my os.

I tested in:

Chrome 58 on macOS 10.12.4
Safari 10.1 on macOS 10.12.4
Firefox 53 on macOS 10.12.4
Chrome 58 on Windows 10
Microsoft Edge on Windows 10
Firefox 51 and 53 on Windows 10
Microsoft IE 11 on Windows 10
and they are all centered. I have no access to ubuntu.

Could you figure out why they are not centered? It looks like a CSS problem. Send us a PR if you can. I really couldn't help because it cannot be reproduced in my machines.

I have test in:

Chrome on Ubuntu 16.04
Chrome on Windows 10
Edge on Windows 10
IE on Windows 10

the commit above can fix this problem.

Hopefully this is fixed in #4847, which will be shipped in 1.3.3 tomorrow.

I hope so..

@pengchongfu So you tested that fix on ubuntu and numbers are centered?

@Leopoldthecoder , yes, It fixed in 4 browsers that I mentioned above. Before changed, the height of div was not 190px but 175px, so the number was not centered.

@pengchongfu OK, thanks.


pgsql: add tests with alert metadata - v3

Check for transaction metadata in PGSQL alerts.
Add engine-analysis tests for the used rules, as well, to better describe them and compare with expected behavior.
Related to
Task #7000
Previous PR #1991
Suricata PR
https://github.com/OISF/suricata/pull/11618
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7113
https://redmine.openinfosecfoundation.org/issues/7000

Replaced with https://github.com/OISF/suricata-verify/pull/2014


Recovery Process stuck in u-boot on nitrogen8m

Dear all,
I am currently trying to recover a Boundary Devices Nitrogen8m using uuu. I have followed this tutorial (https://boundarydevices.com/recovering-i-mx-platforms-using-uuu/). As suggested I used uuu_1.3.154 and the u-boot.nitrogen88m provided here (http://linode.boundarydevices.com/u-boot-images/). Additionally I tried with uuu_1.4.139 and a custom built u-boot.nitrogen8m that was bootable on another board.
For all setups I faced the following Problem: The boot process seemed to be stuck somewhere in Uboot.
The Output from the board was the following:

U-Boot SPL 2020.10-52989-g5c1c757368 (Sep 10 2021 - 11:02:34 -0700)
Setting voltages
config to do 3200 1d training.
config to do 667 1d training.
config to do 3200 2d training.
Normal Boot
Trying to boot from USB SDP
SDP: initialize...
SDP: handle requests...
Downloading file of size 1132928 to 0x40400000... done
Jumping to header at 0x40400000
Header Tag is not an IMX image
Found header at 0x4040ea00
U-Boot 2020.10-52989-g5c1c757368 (Sep 10 2021 - 11:02:34 -0700), Build: jenkins-uboot_v2
020.10-141
CPU:   i.MX8MQ rev2.0 at 1000 MHz
Reset cause: POR
Model: Boundary Devices i.MX8MQ Nitrogen8M
Board: nitrogen8m
Watchdog enabled
DRAM:  2 GiB
MMC:   FSL_SDHC: 0
Loading Environment from MMC...
OK
Display: hdmi:1920x1080M@60 (1920x1080)
[*]-Video Link 0cdn_api_checkalive: keep-alive counter did not increment for 10us...
HDMI enable failed, ret -1!
(1920 x 1080)
[0] display-controller@32e00000, video
[1] hdmi@32c00000, display
In:    serial
Out:   serial
Err:   serial
BuildInfo:

ATF 63a678c

Starting fastboot...
Saving Environment to MMC... Writing to MMC(0)... OK
Net:   AR8035 at 4
FEC [PRIME], usb_ether

The output from uuu was:

$ sudo ./uuu -d u-boot.nitrogen8m_latest
uuu (Universal Update Utility) for nxp imx chips -- libuuu_1.3.154-0-g47ddef5
Success 2    Failure 0
1:4      3/ 3 [Done                                  ] SDPV: done

Has someone experienced a similar issue or has any idea what could have caused it?
Thank you and best regards

The Ctrl-C did the trick to reach the u-boot console. Thank you very much!

Unfortunaly it didn't last long. I was able to get to the u-boot console after pressing Ctrl-C and then flash a working u-boot on my board. The problem that it froze at "FEC [PRIME], usb_ether" persisted, even for the flashed U-Boot. Running "fastboot 0" also seemed to freeze and had to be interrupted with Ctrl-C. I settled for the Ctrl-C option to get my shell and boot, however after a few reboots, it is not possible anymore to reach the u-boot console. After pressing Ctrl-C the board remains frozen, in the recovery mode as well as in normal boot mode. Do you have any idea what my have caused that, @nxpfrankli ?

It is your uboot behavior. Your uboot look like try download image from network or usb_ether, instead of boot from storage.
Please check your uboot environment variable.  Which is not related uuu tools.

Ok, thank you for the hint! How is it possible to access the environment variables without a u-boot shell? I only know of and found the way with 'print', 'setenv' and 'saveenv' from the u-boot console.

Some variable saved in emmc special location, or a file at file partition.  And u-boot have default environment.
It is highly customized.  Efforts of analyze these data is quite high without u-boot console.

Ok, good to know, thank you.
I'll close this now since it's not really uuu related.


nghttp2: 1.24.0 -> 1.31.0

Semi-automatic update. These checks were done:

built on NixOS
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.dmypy-wrapped -h got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.dmypy-wrapped --help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.dmypy-wrapped help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/dmypy -h got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/dmypy --help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/dmypy help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.mypy-wrapped -h got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.mypy-wrapped --help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/mypy -h got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/mypy --help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.stubgen-wrapped -h got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.stubgen-wrapped --help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/.stubgen-wrapped help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/stubgen -h got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/stubgen --help got 0 exit code
ran /nix/store/ml19prlfk05s39z9252ppjs31ryjfn36-mypy-0.570/bin/stubgen help got 0 exit code

cc @wkennington

Success on x86_64-darwin (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/dij7z87kv3lqzin1scahb5mdy42q0xrn-nghttp2-1.31.0-bin/bin
patching script interpreter paths in /nix/store/dij7z87kv3lqzin1scahb5mdy42q0xrn-nghttp2-1.31.0-bin
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rdn8bz1prx8yqz7pavwc07v5pjb2saq3-nghttp2-1.31.0
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/64nqikw064bw2jzph2jh4l95dcl2bvy3-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/64nqikw064bw2jzph2jh4l95dcl2bvy3-nghttp2-1.31.0-dev
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nf3dxjkcsn7bgzgf1ddcj4cycyg7v56a-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/nf3dxjkcsn7bgzgf1ddcj4cycyg7v56a-nghttp2-1.31.0-lib

Success on aarch64-linux (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/ax3azklykp6v25ghhkvf41296x46g4ch-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/ax3azklykp6v25ghhkvf41296x46g4ch-nghttp2-1.31.0-dev
checking for references to /build in /nix/store/ax3azklykp6v25ghhkvf41296x46g4ch-nghttp2-1.31.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/9645ivyy6dgn11a5ll3paq30lfsi8bfr-nghttp2-1.31.0-lib
shrinking /nix/store/9645ivyy6dgn11a5ll3paq30lfsi8bfr-nghttp2-1.31.0-lib/lib/libnghttp2.so.14.16.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9645ivyy6dgn11a5ll3paq30lfsi8bfr-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/9645ivyy6dgn11a5ll3paq30lfsi8bfr-nghttp2-1.31.0-lib
checking for references to /build in /nix/store/9645ivyy6dgn11a5ll3paq30lfsi8bfr-nghttp2-1.31.0-lib...
/nix/store/8150cyhj74hwdqcg4v797gnap74if5q4-nghttp2-1.31.0-bin

Success on x86_64-linux (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/74vn3y0dxaxdfa0410bwg50a5ygvcvb4-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/74vn3y0dxaxdfa0410bwg50a5ygvcvb4-nghttp2-1.31.0-dev
checking for references to /tmp/nix-build-nghttp2-1.31.0.drv-0 in /nix/store/74vn3y0dxaxdfa0410bwg50a5ygvcvb4-nghttp2-1.31.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/zbf805da99d9g8jcdijq7x9ybrfjh5m9-nghttp2-1.31.0-lib
shrinking /nix/store/zbf805da99d9g8jcdijq7x9ybrfjh5m9-nghttp2-1.31.0-lib/lib/libnghttp2.so.14.16.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zbf805da99d9g8jcdijq7x9ybrfjh5m9-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/zbf805da99d9g8jcdijq7x9ybrfjh5m9-nghttp2-1.31.0-lib
checking for references to /tmp/nix-build-nghttp2-1.31.0.drv-0 in /nix/store/zbf805da99d9g8jcdijq7x9ybrfjh5m9-nghttp2-1.31.0-lib...
/nix/store/zp6sba54dbrakfvxysg4vh4dfki7gf25-nghttp2-1.31.0-bin

Success on x86_64-darwin (full log)
Partial log (click to expand)
patching script interpreter paths in /nix/store/r7fspj68msjblwg8wck31yfn6cn6l2gj-nghttp2-1.31.0-bin
strip is /nix/store/sd1yb0p2yx3ak2qkz1a687zw5zlmbnzg-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/nqbcgs0f0y8078ixwad3ibx2d3i7m8y2-nghttp2-1.31.0
strip is /nix/store/sd1yb0p2yx3ak2qkz1a687zw5zlmbnzg-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8xcisa60kq35dsy94frg4xz80zq1xag7-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/8xcisa60kq35dsy94frg4xz80zq1xag7-nghttp2-1.31.0-dev
strip is /nix/store/sd1yb0p2yx3ak2qkz1a687zw5zlmbnzg-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/w7myzfyb0a0ya89z6667yycff587g3bp-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/w7myzfyb0a0ya89z6667yycff587g3bp-nghttp2-1.31.0-lib
/nix/store/r7fspj68msjblwg8wck31yfn6cn6l2gj-nghttp2-1.31.0-bin

Success on aarch64-linux (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/5nbwcq8akffdx5la5xky6icf483w31rj-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/5nbwcq8akffdx5la5xky6icf483w31rj-nghttp2-1.31.0-dev
checking for references to /build in /nix/store/5nbwcq8akffdx5la5xky6icf483w31rj-nghttp2-1.31.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/s5j39m9nvn4d3bn7fy4vin82kmx4kwsc-nghttp2-1.31.0-lib
shrinking /nix/store/s5j39m9nvn4d3bn7fy4vin82kmx4kwsc-nghttp2-1.31.0-lib/lib/libnghttp2.so.14.16.0
strip is /nix/store/fib7s4bkwwh54jz3b9yhb3sqmlcdks0n-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/s5j39m9nvn4d3bn7fy4vin82kmx4kwsc-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/s5j39m9nvn4d3bn7fy4vin82kmx4kwsc-nghttp2-1.31.0-lib
checking for references to /build in /nix/store/s5j39m9nvn4d3bn7fy4vin82kmx4kwsc-nghttp2-1.31.0-lib...
/nix/store/wh8sz2gvp8i88lznwasfbqprnm3rscpx-nghttp2-1.31.0-bin

Success on x86_64-linux (full log)
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/ci28kix6c82hvdq39lwf8f45sz7lnx3g-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/ci28kix6c82hvdq39lwf8f45sz7lnx3g-nghttp2-1.31.0-dev
checking for references to /tmp/nix-build-nghttp2-1.31.0.drv-0 in /nix/store/ci28kix6c82hvdq39lwf8f45sz7lnx3g-nghttp2-1.31.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/gmm6zx46ng4fgcr2pha25zzxq1r9xgdg-nghttp2-1.31.0-lib
shrinking /nix/store/gmm6zx46ng4fgcr2pha25zzxq1r9xgdg-nghttp2-1.31.0-lib/lib/libnghttp2.so.14.16.0
strip is /nix/store/y2z2g4n8dsv0isjq36cjn9ldp8h9z3gs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gmm6zx46ng4fgcr2pha25zzxq1r9xgdg-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/gmm6zx46ng4fgcr2pha25zzxq1r9xgdg-nghttp2-1.31.0-lib
checking for references to /tmp/nix-build-nghttp2-1.31.0.drv-0 in /nix/store/gmm6zx46ng4fgcr2pha25zzxq1r9xgdg-nghttp2-1.31.0-lib...
/nix/store/62g6dpw7d234xxdrgmlzihyq06adrzrb-nghttp2-1.31.0-bin

See also #36462 (and PR linked from there).


Bump-up utils version to 1.18.0

Description
Bump-up utils version to 1.18.0
Fixes #631
Type of change

Bump-up dependent library (no changes in the code)

Testing steps
Done on CI
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #632 (03915ff) into master (033a805) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   58.34%   58.34%
=======================================
  Files          17       17
  Lines        1438     1438
=======================================
  Hits          839      839
  Misses        495      495
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033a805...03915ff. Read the comment docs.


[T3A4][T10-A2] Low Yong Cheng

Ignore the other 2 files, I updated the master yesterday so the Address book is manipulated already. The Storage File is where the Excepted is added

Ready for review

@yongchenglow Some comments added. Please close the PR after reading comments.


Fix sensitive supported check

Description
The sensitive check currently uses the ChefGem resource to see if the attribute exists. But even on the newer Chef versions this does not exist (makes no sense either). Check on the File resource instead.
Motivation and Context
In the current code sensitive will never be used, even if supported.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

Hi @thoutenbos, thanks for taking the time to open a PR. Looks like the Travis check failed due to upstream changes in the erlang cookbook which I have fixed in #492.
If you'd care to rebase this branch on current develop, I think Travis should be able to test them now.

@cwjohnston thanks for fixing, rebased to develop and tests are passing now 👍


Infinite Stream recognition

@nnegrey
Please review

Is there a way to test this?
Did we test the microphone sample?

Is there a way to test this?
Did we test the microphone sample?

No we do not have tests for the microphone sample and the only way to test this currently is to do it manually.

@nnegrey
Thanks for reviewing.Fixed the comments. Please let me know if there is anything else that maybe required.


Could we store all CssClasses and make it public for each component ?

As this said

Store strings for class names defined by this component that are used in JavaScript. This allows us to simply change it in one place should we decide to modify at a later date.

It is also good for using in other frameworks, like Angular or React
For example:
MaterialTextfield.prototype.CssClasses_ = {
  ROOT: 'mdl-textfield',
  // elements
  LABEL: 'mdl-textfield__label',
  INPUT: 'mdl-textfield__input',
  ERROR: 'mdl-textfield__error',
  EXPANDABLE_HOLDER: 'mdl-textfield__expandable-holder',
  // modifies
  FLOATING_LABEL: 'mdl-textfield--floating-label',
  ALIGN_RIGHT: 'mdl-textfield--align-right',
  FULL_WIDTH: 'mdl-textfield--full-width',
  EXPANDABLE: 'mdl-textfield--expandable',
  IS_DIRTY: 'is-dirty',
  IS_FOCUSED: 'is-focused',
  IS_DISABLED: 'is-disabled',
  IS_INVALID: 'is-invalid',
  IS_UPGRADED: 'is-upgraded'
};
MaterialTextfield.CssClasses = MaterialTextfield.prototype.CssClasses_;

React version
import { MaterialTextfield } from 'material-design-lite-cjs/src/textfield';
import IconButton from '../buttons/IconButton';

const CssClasses = MaterialTextfield.CssClasses;

class Textfield extends React.Component {
  render() {
     const {
      className,
      inputClassName,
      error,
      expandableIcon,
      fullWidth,
      alignRight,
      floatingLabel,
      label,
      maxRows,
      rows,
      style,
      ...otherProps } = this.props;

    const hasRows = !!rows;
    const inputId = 'textfield-' + label.replace(/[^a-z0-9]/gi, '');
    const inputTag = hasRows || maxRows > 1 ? 'textarea' : 'input';

    const inputProps = {
      className: classNames(CssClasses.INPUT, inputClassName),
      id: inputId,
      key: inputId,
      rows,
      ref: 'input',
      ...otherProps
    };

    const input = React.createElement(inputTag, inputProps);

    const inputAndLabelError = [
      input,
      {label},
      error ? (
        {error}
      ) : null
    ];

    const containerClasses = classNames(CssClasses.ROOT, {
      [CssClasses.FLOATING_LABEL]: floatingLabel,
      [CssClasses.FULL_WIDTH]: fullWidth,
      [CssClasses.ALIGN_RIGHT]: alignRight,
      [CssClasses.EXPANDABLE]: expandableIcon
    }, className);

    const field = expandableIcon
      ? React.createElement('div', { className: CssClasses.EXPANDABLE_HOLDER }, inputAndLabelError)
      : inputAndLabelError;

    return (

        {expandableIcon ? (
          <IconButton
            name={expandableIcon}
            component='label'
            htmlFor={inputId}
          />
        ) : null}
        {field}

    );
  }
}

export default Textfield;

Once material-design-lite updated a little small, downstream packages will be safe.
For bigger changes, this way will be easier to location the changed things.

In my opinion, this is bad component design for other frameworks/libraries. If you are going through the effort of building custom implementations, just go full in and write natural handling for that structure entirely.
Essentially, think of our provided JS as a reference implementation of what is needed to make things work at this point. From there, build naturally for X system and don't require our JS get included at all. This will allow for more natural usage within your application and better performance.
Our class names aren't (as far as we can control) going to outright change within a major version. And when a new major comes around, well it is major expect work.
Closing this initially since it isn't something we should do, but open to more discussion going on in case things change.

Thanks.
Indeed. I found we are not really need to use the original javascript,
Just want to maintain the css classes map to make easier for updates.
Styling should be use the same one.


bzcat segfault

File here:
http://www.cs.utah.edu/~regehr/foo.bz2
causes a segfault when run like this:
toybox bzcat < foo.bz2
I haven't checked if this can be used to get remote code execution but out-of-bounds stores controlled by untrusted data are generally bad.

Seems fixed in commit 5ad93f32da3e2ac70b1fa929889d3034c79f7ed6


Ubuntu Server 20.4 Error Line 129

Thank you for the code.
However, when dl + ran I get:
129: Syntax error: redirection unexpected
Printed the error line:
$(grep " <host " ./tmp/gethosts.xml)

In case anyone else has this issue as well. It's because sh doesn't support the here string syntax (<<<) and a few other things in the script as well. It does work as a bash script though, so just change the shebang at the top and it'll run fine.
TL;DR
#!/bin/sh

to
#!/bin/bash

just an fyi here - I would recommend using the following instead
#!/usr/bin/env bash


Tagilla and Killa missing some magazines in their "mod_magazine" for some weapons.

General information:
Project issue is for:
SPT 3.7.6 SPT 3.8
Tagilla and Killa are missing other magazines in their "mod_magazine" section for RPK-16 for both Killa and Tagilla, AKS-74UN for Tagilla, Saiga for Tagilla and AKMS for Killa.
RPK-16: 6L31 60 round magazine
AKS-74UN: 6L31 60 round magazine
AKMS: AKMS aluminium 30 round magazine
Saiga: SAI-02 10 round magazine

Originally written by Armanello

Do you have any pics of the bosses with these items on live? we've gotten 974 Tagilla dumps from live and the data you see in bossTagilla.json is what's been collected

Originally written by chomp

They will have these magazines when they have drum magazines or extended 40 round mag for AKMS in case of Killa. For 6L31 for AKS-74UN - I'm not sure.
https://escapefromtarkov.fandom.com/wiki/Killa
https://escapefromtarkov.fandom.com/wiki/Tagilla

Originally written by Armanello

Raiders spawning with drum mag in their guns and regular 30 round magazines in chest rig

Attachments

2024-06-19[23-24]_-88.9, -13.1, -7.8_0.2, 0.8, -0.4, 0.5_11.83 (0).png (2454 KiB)

Originally written by Armanello


Localization Validation Error Reference (time difference too large)

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
Received the following error:
[localization.pose_estimator.ndt_scan_matcher]: Validation error. The reference time is 2071.972686[sec], but the target time is<PHONE_NUMBER>.258270[sec]. The difference is<PHONE_NUMBER>.285584[sec] (the tolerance is 1.000000[sec]). (validate_time_stamp_difference() at /home/kai/autoware/src/universe/autoware.universe/localization/ndt_scan_matcher/src/pose_array_interpolator.cpp:85)
Using physical lidar, works with rosbag and use_sim_time==true, but once use_sim_time==false then receive this error. What does this error mean?
Expected behavior
Smooth launching without validation error
Actual behavior
As shown above
Steps to reproduce
Physical lidar testing with autoware.launch.xml
Versions
No response
Possible causes
No response
Additional context
log file for reference
launch.log

It's from here: https://github.com/autowarefoundation/autoware.universe/blob/25f9d6a03adf91ed2312741b9acdf937560245a9/localization/ndt_scan_matcher/src/pose_array_interpolator.cpp#L78-L92
Which probably is called here: https://github.com/autowarefoundation/autoware.universe/blob/e70df1239c67d8ae86a7a8bf8d6c83bc20e7ece7/localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp#L362C25-L364
Since ndt_scan_matcher needs an initial guess pose for optimization, it uses the EKF outputs. But since we need to use a proper EKF outputs with a close timestamp with the received LiDAR timestamp, we add the above timestamp validation. Without it, Autoware may use old EKF pose output and NDT ends up in non-optimal poses.

So what would cause the timestamps to have such a large difference?

use_sim_time==false probably is the direct cause

but if I set use_sim_time=true, the LIDAR pointcloud becomes sluggish as if it's in slowmo.
What might cause this?

Now I got the issue :+1: I think it's better to change the title as the current one is a bit misleading. It seems it's not about specific package's implementation but rather an issue as an whole system.
Could you elaborate more on how it's sluggish? You mean on RViz? Could you share any videos that captures the issue here? Please also make it clear when exactly that issue happens. Is it when you are using logging_simulator with your recorded rosbag? Or using autoware.launch.xml with your onboard PC on your real robot or something?

This happens when using logging_simulator or autoware.launch.xml, use_sim_time=true. It does not occur when ros2 bag play  --clock.
https://github.com/autowarefoundation/autoware.universe/assets/112715209/cd5c6c35-c051-458f-b026-a52e649a83aa

You should not use autoware.launch.xml with use_sim_time=true as long as you are not providing /clock. So your rosbag should also contain /clock as well

The issue has been solved by ensuring the LIDAR driver syncs with system time on my laptop. Thanks!


ADD directive output to know when the component close

Please update README.md for this feature.

Related to #127

Ok I added a part on outputs in the README.md

Thank you for the merge, is it possible to have a new tag on npm ?


added automatic scraping by openshift prometheus

Fixes #90. This PR adds some needed labels and rbac that are needed for the automatic scraping of OpenShift prometheus

/assign @sahar2339

/approve
/lgtm
/meow


ORC-236: Support UNION type in Java Convert tool

What changes were proposed in this pull request?
This patch add support to convert json to UNION type in orc file. For
example, for schema struct<foo:uniontype<int,string>>, the following
json lines can be parsed into UNION type.
{"foo": {"tag": 0, "value": 1}}
{"foo": {"tag": 1, "value": "testing"}}
{"foo": {"tag": 0, "value": 3}}

Why are the changes needed?
This add a missing support for UNION type in java convert tool.
How was this patch tested?
Manually test against handcrafted json file.

cc @guiyanakuang and @williamhyun , too

Is this applicable to branch-1.7, @rizaon ?

@dongjoon-hyun If backport is clean, it should be applicable.

Thank you, @rizaon . I set the milestone, v1.7.3.

It might be nice to make Convert more generic, some existing json data may not have tag and value fields, adding an option for the user to customize the method of getting tag and value would be great. : )

Hello @guiyanakuang, thanks for your feedback!
Does it help if I add parameters to specify the tag and value json-key? Maybe, --union_tag and --union_key like this?
java -jar ./java/tools/target/orc-tools-1.8.0-SNAPSHOT-uber.jar convert -o sample.orc \
  -s "struct<foo:uniontype<int,string>>" --union_tag="tag" --union_value="value" sample.json

@rizaon. I think it's good that this can handle simple situations. If there is complex json data we can keep upgrading

I switched the milestone to 1.8.0 since 1.7.3 will be released in two weeks and this is a new improvement which is not a blocker for https://github.com/apache/orc/milestone/4?closed=1 .

@rizaon . I added you to the Apache ORC contributor group and assigned ORC-236 to you.
Welcome to the Apache ORC community!

Thank you, @dongjoon-hyun @guiyanakuang !


iOS print issues

Hi there,
Thank you for your package.
I have an issue with ios printing
as you see below image
the top one is printed by an Android device and the bottom one is printed by an iOS device (iPhone 10)
I really don't know where the white line comes from and how to solve it.
By the way, why do Android devices print faster than iOS devices?

thank you

hi,  I have updated the ios implementation, could you check it?

Now it does not print at all.
Worked till before updating package.
Now libGSDK.a is removed.

Hi,
Thank you for keeping up to date with this package.
I just discover that not only ios devices but also some Android devices get the same issues
Like this kind of machine

I have tested 2 machines.
I'm not sure if it is because of devices or the code issues,
for the receipt widget, I just follow the example

@M6268 i decided to implement from the CoreBluetooth instead libGSDK. Its happened to the example project?

there is no logs from IOS side what is happening.

@ekasetiawans yes it does

Hi, Thank you for keeping up to date with this package. I just discover that not only ios devices but also some Android devices get the same issues
Like this kind of machine  I have tested 2 machines. I'm not sure if it is because of devices or the code issues, for the receipt widget, I just follow the example

Usually android printers wont work by default, you have to manually add UUID of the device , it can be found from sunmi android sdk

@M6268 i decided to implement from the CoreBluetooth instead libGSDK. Its happened to the example project?

i haven;t tried the example yet, i will update

@M6268 could you debug the example project from the xcode?

@M6268 it does print but it got a white line through the text as I mentioned above image

@M6268 could you debug the example project from the xcode?

yes

2022-12-13 14:13:49.257944+0530 Runner[50448:2804378] Metal API Validation Enabled
2022-12-13 14:13:49.515916+0530 Runner[50448:2804378] Warning: Unable to create restoration in progress marker file
2022-12-13 14:13:49.562128+0530 Runner[50448:2804878] flutter: The Dart VM service is listening on http://<IP_ADDRESS>:49422/tG5MTzXIxcs=/
2022-12-13 14:13:50.012529+0530 Runner[50448:2804852] fopen failed for data file: errno = 2 (No such file or directory)
2022-12-13 14:13:50.012594+0530 Runner[50448:2804852] Errors found! Invalidating cache...
2022-12-13 14:13:50.044212+0530 Runner[50448:2804851] fopen failed for data file: errno = 2 (No such file or directory)
2022-12-13 14:13:50.044243+0530 Runner[50448:2804851] Errors found! Invalidating cache...
This is the only thing found from console

It connects with the printer , in my printer connectivity LED is on after few seconds it get disconnected.

@M6268 it does print but it got a white line through the text as I mentioned above image

Its hard for me to find out the cause, its seems like the raster size is too big for your printer, but I'm not sure about that.

Text printing is working fine.
Image printing with a single line of text in receipt fails

Text printing is working fine.
Image printing with a single line of text in receipt fails

https://github.com/ekasetiawans/flutter_bluetooth_printer_plugin/blob/3e2975368fcb5bfb87e3c75eae5f8f9742ec8aac/packages/flutter_bluetooth_printer/lib/src/flutter_bluetooth_printer_impl.dart#L60
You can try to change this by hardcode to lower value.

This is the error getting from Xcode.

hi @M6268, I have added option useImageRaster on print method, it will use an obsolete method to raster the image, could you try it?

hi @M6268, I have added option useImageRaster on print method, it will use an obsolete method to raster the image, could you try it?

Sure, i will update, is the above error is related to that ?

hi @M6268, I have added option useImageRaster on print method, it will use an obsolete method to raster the image, could you try it?

Sure, i will update, is the above error is related to that ?

I'm not sure enough, but its seems error while sending data to the printer.

Still Error Domain=CBATTErrorDomain Code=13 "The value's length is invalid." UserInfo={NSLocalizedDescription=The value's length is invalid.}

Two left are from iPhone X iOS 15.6.1 and the right side is from Redmi S2 Android 9PKQ1

Still Error Domain=CBATTErrorDomain Code=13 "The value's length is invalid." UserInfo={NSLocalizedDescription=The value's length is invalid.}

I think it caused by limitation of BLE payload length. You can try change the size here (total/5) with smaller value depending your device for example explicit to 30 bytes each payload.
https://github.com/ekasetiawans/flutter_bluetooth_printer_plugin/blob/95f507d42614508d6c69dc210bb02aca5c912bcb/packages/flutter_bluetooth_printer/ios/Classes/Bluetooth/BluetoothPrinterManager.swift#L293

Two left are from iPhone X iOS 15.6.1 and the right side is from Redmi S2 Android 9PKQ1

Did you tried with the latest version I'd recently published?

Two left are from iPhone X iOS 15.6.1 and the right side is from Redmi S2 Android 9PKQ1

Did you tried with the latest version I'd recently published?

Yes I do, I just clone and run it

Still Error Domain=CBATTErrorDomain Code=13 "The value's length is invalid." UserInfo={NSLocalizedDescription=The value's length is invalid.}

I think it caused by limitation of BLE payload length. You can try change the size here (total/5) with smaller value depending your device for example explicit to 30 bytes each payload.
https://github.com/ekasetiawans/flutter_bluetooth_printer_plugin/blob/95f507d42614508d6c69dc210bb02aca5c912bcb/packages/flutter_bluetooth_printer/ios/Classes/Bluetooth/BluetoothPrinterManager.swift#L293

can give an idea on size/5

https://stackoverflow.com/questions/24349945/maximum-data-size-when-sending-data-via-btle-on-ios
It seems the data was corrupted while being transmited to the device because there are difference maximum supported payload length on every device.
I think this is related issue, i will implement it when I have enough time.

Still Error Domain=CBATTErrorDomain Code=13 "The value's length is invalid." UserInfo={NSLocalizedDescription=The value's length is invalid.}

I think it caused by limitation of BLE payload length. You can try change the size here (total/5) with smaller value depending your device for example explicit to 30 bytes each payload.
https://github.com/ekasetiawans/flutter_bluetooth_printer_plugin/blob/95f507d42614508d6c69dc210bb02aca5c912bcb/packages/flutter_bluetooth_printer/ios/Classes/Bluetooth/BluetoothPrinterManager.swift#L293

Thanks for idea.
size set to 50. and working .

Still Error Domain=CBATTErrorDomain Code=13 "The value's length is invalid." UserInfo={NSLocalizedDescription=The value's length is invalid.}

I think it caused by limitation of BLE payload length. You can try change the size here (total/5) with smaller value depending your device for example explicit to 30 bytes each payload.
https://github.com/ekasetiawans/flutter_bluetooth_printer_plugin/blob/95f507d42614508d6c69dc210bb02aca5c912bcb/packages/flutter_bluetooth_printer/ios/Classes/Bluetooth/BluetoothPrinterManager.swift#L293

Thanks for idea. size set to 50. and working .

Yeayy!! Now we should think to make it flexible depending on the device

Yes, but still the same slow printing !

Yes, but still the same slow printing !

Yes, because the payload is more smaller on every write

Yes, but still the same slow printing !

Yes, because the payload is more smaller on every write

Trying to make chunk size dynamic.

Yes, but still the same slow printing !

Yes, because the payload is more smaller on every write

Trying to make chunk size dynamic. i will update the results.

Cool thank you

hi @M6268 I have updated the chunkSize based on peripheral, please check it if you have time

hi @M6268 I have updated the chunkSize based on peripheral, please check it if you have time

I ll check and update.

For iOS print getting better now, but still abit more issue
by theway QR is not scannable

For iOS print getting better now, but still abit more issue

could you try to run the example project, and print the example receipt?


Math equations cannot be labelled in lists

The following math equation is correctly rendered by myst, but the (eq:HI_isotherms) bit appears in the text instead of being interpreted as the equation's label:
* Integration along isotherms: $T$ is constant, $\rho$ varies. The Helmholtz free energy difference is given by
$$
F(\rho_2, T) - F(\rho_1, T) = N\int_{\rho_1}^{\rho_2} \frac{P(\rho)}{\rho^2} d\rho,
$$ (eq:HI_isotherms)
where the integrand can be obtained *e.g.* with canonical simulations.

I have tried prepending the equation with (eq:HI_isotherms)=, but that messes up the formatting, as the text that comes after the equation will not be interpreted as part of the same bullet point.

To give an equation a label, you can use the
directive (https://mystmd.org/guide/math#math-directives) and set the name option), or use \label{} (https://mystmd.org/guide/math#dollar-math)
E.g. https://mystmd.org/sandbox?tab=demo&myst=KgAgAEkAbgB0AGUAZwByAGEAdABpAG8AbgAgAGEAbABvAG4AZwAgAGkAcwBvAHQAaABlAHIAbQBzADoAIAAkAFQAJAAgAGkAcwAgAGMAbwBuAHMAdABhAG4AdAAsACAAJABcAHIAaABvACQAIAB2AGEAcgBpAGUAcwAuACAAVABoAGUAIABIAGUAbABtAGgAbwBsAHQAegAgAGYAcgBlAGUAIABlAG4AZQByAGcAeQAgAGQAaQBmAGYAZQByAGUAbgBjAGUAIABpAHMAIABnAGkAdgBlAG4AIABiAHkACgAkACQACgBcAGwAYQBiAGUAbAB7AGUAcQA6AEgASQBfAGkAcwBvAHQAaABlAHIAbQBzAH0ACgBGACgAXAByAGgAbwBfADIALAAgAFQAKQAgAC0AIABGACgAXAByAGgAbwBfADEALAAgAFQAKQAgAD0AIABOAFwAaQBuAHQAXwB7AFwAcgBoAG8AXwAxAH0AXgB7AFwAcgBoAG8AXwAyAH0AIABcAGYAcgBhAGMAewBQACgAXAByAGgAbwApAH0AewBcAHIAaABvAF4AMgB9ACAAZABcAHIAaABvACwACgAkACQAIAAKAHcAaABlAHIAZQAgAHQAaABlACAAaQBuAHQAZQBnAHIAYQBuAGQAIABjAGEAbgAgAGIAZQAgAG8AYgB0AGEAaQBuAGUAZAAgACoAZQAuAGcALgAqACAAdwBpAHQAaAAgAGMAYQBuAG8AbgBpAGMAYQBsACAAcwBpAG0AdQBsAGEAdABpAG8AbgBzAC4ACgAKAFMAZQBlACAAQABlAHEAOgBIAEkAXwBpAHMAbwB0AGgAZQByAG0AcwAgAGYAbwByACAAbQBvAHIAZQA%3D

Thank you so much!


failure to compress on android if react-native-reanimated library is installed

Current behavior
When trying to compress a video in android and you have the react-native-reanimated library installed, you get this error:
TypeError: Cannot read property 'adaptViewConfig' of undefined
Expected behavior
Should compress the video without any problem, since they are different libraries that do not interact.
Platform

[X] Android

React Native Version
0.72.4
React Native Compressor Version
^1.8.3
Reproducible Steps And Demo
Install version "react-native-compressor": "^1.8.3" of and "react-native-reanimated": "^3.5.2"

@CadenaCristian it is working on my side, can you provide any repro github example?

@CadenaCristian we are already using reanimated lib with this package in example directory
https://github.com/numandev1/react-native-compressor/blob/24a573028f38cdc0f7bd3753086388fd29103e9e/example/package.json#L32

I think this issue is not from react-native-compressor you should open this issue on the react-native-reanimated repo, i am closing it now, please feel free to reopen it if you have this error again


docs: update readme

Which issue does this PR close?
Closes #
Rationale for this change
What changes are included in this PR?
update readme, add WeChat QR code
Are there any user-facing changes?
no
How does this change test
no need

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chunshao.rcs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Only rename CI YAML, force merge.