[discuss] Improve CR Status Feedback

Running builds in cluster using any strategy, users should be able to access the current status of any build request. After the build config obejct is submitted, we should be able to access information about it. mainly

what all stages are there for a single build?
what is the current stage of the build?
durations in the stages?
success/failure logs for particular build.

After going through code base of build v1, tektoncd pipeline what I could figure out as current buildstatus spec is
build stages:

FetchInputs
PullImages
Build
PostCommit
PushImage

IMO we can add an optional stage as "PreBuild" before Build Stage, to support any config or binary specific changes in the build time.
we can also show all the stages (already run or will run next) and mark the build accordingly.
I am digging more around the tekton and build strategies will keep on updating here.
Please do share how you think on this?
@sbose78 @otaviof

Hi all,
I think we could show some basic build information in the status of the build:

Like using corev1alpha1.Status to show the Succeeded, Reason, StartTime and  CompletionTime informations
If possible, provide the step lists to show each step status and result
If possible, show the git info (url or revision) info to let the user know which git commit they used for this build
If possible, show the base image/builder image info to let the user know which image (version or tag) they used to build their image.

(Item 3 and 4 can be useful for the future trigger support)
And I think the Item 1 is the first priority because right now, Build v2 just update the Status once taskrun provide the status, it cannot provide the status if there is any build native error, and cannot know the basic info like Succeeded or Time.
Hope it is helpful.

Thanks for the input, I believe we can show the logs in case of error in the build process. so that user knows what is breaking where. Build stages (steps) are available in build v1 I believe we can use some kind of similar things in build v2  as well.

It would be also good if conditions can be used as a list of Condition as mentioned here https://github.com/redhat-developer/build/blob/master/pkg/apis/core/v1alpha1/condition_types.go#L24 .  and then Succeeded that is used here https://github.com/redhat-developer/build/blob/master/pkg/controller/buildrun/buildrun_controller.go#L317 can be used as a ConditionType. More conditions can then be added to the conditions list.
For more reference refer- https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties

This topic have been widely discussed, the latest state around the main enhancements are:

BuildRun supports conditions(already in master branch)
Build is gonna get an enhancement inside its Status field, WIP at https://github.com/shipwright-io/build/issues/463#issuecomment-743076936

This topic have been widely discussed, the latest state around the main enhancements are:

BuildRun supports conditions(already in master branch)
Build is gonna get an enhancement inside its Status field, WIP at https://github.com/shipwright-io/build/issues/463#issuecomment-743076936


Add an end-point to provide statistics for the victims in the backend

https://dashboard.missingpersonsug.org//victim-statistics
Which provides the following:
{
  "data": [
    {
      "security-ogs": {
        "Police": 4,
        "Joint Forces": 3
      },
      "holding-locations": {
        "Jinja Road Police Station": 4,
        "Naggalama Police Station": 2,
        "Kitalya": 3,
        "Unknown": 7
      },
      "status": {
        "Remanded": 5,
        "Unknown": 7
      },
      "gender": {
        "Female": 30,
        "Male": 45
      }
    }
  ]
}

Now available https://dashboard.missingpersonsug.org/api/victim-statistics


Ensure shortcut set explicit working directory

Ideally we should let the manifest specify a working directory, but for now let's at least make sure it is by default set to the directory of the shortcut's target.

What are the side effects of not having a working directory set?

The working directory will be "random" and some programs which need to read some files from the base directory will not work. After a second thought, while setting this always to the directory of the target should be fine and helps for those programs, it may still not work for all programs and it is not clean. I am thinking about adding a third item to the shortcut array like this: ["path", "Name", "workdir"], of course the third one will be optional. One small concern about this is that since it is an array instead of an object, it is not easy to tell which one is for which, may we could also optionally support using an object notation, I am thinking just use all the property names of the shortcut object as-is:
Arguments        Property   string Arguments () {get} {set}
Description      Property   string Description () {get} {set}
FullName         Property   string FullName () {get}
Hotkey           Property   string Hotkey () {get} {set}
IconLocation     Property   string IconLocation () {get} {set}
RelativePath     Property   string RelativePath () {set}
TargetPath       Property   string TargetPath () {get} {set}
WindowStyle      Property   int WindowStyle () {get} {set}
WorkingDirectory Property   string WorkingDirectory () {get} {set}

Then we can just apply the properties to the created shortcut object by enumerating all the properties of the shortcut object in manifest.
Let me know which approach you prefers.
Thanks

@lukesampson  P.S. Can you share info on how do you test scoop while developing it? Thanks

I used set-alias scoop c:\github\scoop\bin\scoop.ps1 to test the changes; I will abandon this and create a new PR with the other approach I mentioned above.

OBS Studio need a correct WorkingDirectory to start properly.
Rufus doesn't start in portable mode it can't find rufus.ini in it's working directory (which is set to C:\Windows\System32\C:\Windows\System32\ when started from start menu)
See https://github.com/lukesampson/scoop-extras/pull/579
Every program installed on windows sets the working directory the same as the main executable. I think we should default to this behavior.


Update metadata instead of creating one

Thanks for the great plugin! And as seeing a Korean plugin author! 😉
I want to get a new command Insert metadata into the current note instead of Create new book note, since I already have a lot of the book pages.

Thank you! Good idea.
I am constantly updating new features.

Great idea, agreed!


[BLD]: Unpinning hnswlib in pyproject

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Currently due to pinned hnsw dep in pyproject installing chroma on py312 causes rebuild hnsw - this change aligns requirements and pyproject.toml to unpin the version and allow for 0.7.5 (py312) binary whl to be installed

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
N/A

#2491  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Array objects returning error

Whenever I try to use array objects I keep getting the following error:
NoMethodError:
       undefined method `to_sym' for #<Hash:0x007fed4a4a7dd0>

Here's my schema:
{
  "type": "array",
  "properties": {
    "id": { "type": "string" },
    "ref_id": { "type": "string" },
    "type": { "type": "string" },
    "channel": { "type": "object" },
    "customer": { "type": ["null", "object"] },
    "sent_by": { "type": ["null", "object"] },
    "notify": { "type": "boolean" },
    "created_at": { "type": "string" },
    "updated_at": { "type": "string" }
  },
  "required": ["id", "ref_id", "type", "channel", "customer", "sent_by", "notify", "created_at", "updated_at"]
}

My JSON:
[
  {
    "id": "881aca4e-75c9-11e5-a49f-b74cb0894375",
    "ref_id": "0b8f7afe-4cb0-4a2d-be01-4e826ce8de4e",
    "type": "task",
    "channel": {
      "text": "Hello back!"
    },
    "customer": {
      "id": "8818c078-75c9-11e5-a49f-cb411e8d161b",
      "name": "Anthony Smith",
      "phone_number": "+11932468578",
      "created_at": "2015-10-18T18:53:33.686Z",
      "updated_at": "2015-10-18T18:53:33.686Z"
    },
    "sent_by": {
      "id": "88166120-75c9-11e5-a49f-6f93c6bb584f",
      "name": "Anthony Smith",
      "email"<EMAIL_ADDRESS>      "photo_url": null,
      "timezone": "Eastern Time (US & Canada)",
      "contact_email": null,
      "notes": null,
      "vcard_url": "/vcards/original/missing.png",
      "account": null,
      "location": null,
      "created_at": "2015-10-18T18:53:33.670Z",
      "updated_at": "2015-10-18T18:53:33.670Z"
    },
    "notify": false,
    "created_at": "2015-10-18T18:53:33.699Z",
    "updated_at": "2015-10-18T18:53:33.699Z"
  }
]

This validates using an online validator.

Stack trace:
 # ./.gems/gems/json-schema-2.2.5/lib/json-schema/attributes/properties_v4.rb:45:in `block in validate'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/attributes/properties_v4.rb:32:in `select'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/attributes/properties_v4.rb:32:in `validate'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/validator.rb:96:in `block in validate'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/validator.rb:94:in `each'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/validator.rb:94:in `validate'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/schema.rb:40:in `validate'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/validator.rb:225:in `validate'
     # ./.gems/gems/json-schema-2.2.5/lib/json-schema/validator.rb:396:in `validate!'
     # ./.gems/gems/json_matchers-0.4.0/lib/json_matchers/matcher.rb:17:in `matches?'
     # ./.gems/gems/json_matchers-0.4.0/lib/json_matchers/rspec.rb:62:in `block (2 levels) in <top (required)>'
     # ./spec/requests/api/v1/api_v1_messages_spec.rb:23:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:70:in `block (3 levels) in <top (required)>'
     # ./.gems/gems/database_cleaner-1.5.1/lib/database_cleaner/generic/base.rb:16:in `cleaning'
     # ./.gems/gems/database_cleaner-1.5.1/lib/database_cleaner/base.rb:92:in `cleaning'
     # ./.gems/gems/database_cleaner-1.5.1/lib/database_cleaner/configuration.rb:86:in `block (2 levels) in cleaning'
     # ./.gems/gems/database_cleaner-1.5.1/lib/database_cleaner/configuration.rb:87:in `call'
     # ./.gems/gems/database_cleaner-1.5.1/lib/database_cleaner/configuration.rb:87:in `cleaning'
     # ./spec/rails_helper.rb:69:in `block (2 levels) in <top (required)>'

Could you try altering your schema?
{
  "type": "array",
  "items": {
    "type": "object",
    "properties": {
      "id": { "type": "string" },
      "ref_id": { "type": "string" },
      "type": { "type": "string" },
      "channel": { "type": "object" },
      "customer": { "type": ["null", "object"] },
      "sent_by": { "type": ["null", "object"] },
      "notify": { "type": "boolean" },
      "created_at": { "type": "string" },
      "updated_at": { "type": "string" }
    },
    "required": ["id", "ref_id", "type", "channel", "customer", "sent_by", "notify", "created_at", "updated_at"]
  }
}

@anthonator were you able to resolve your issue?

Sorry! Lost track of this. It's been a while and I'm not sure if I ever got this resolved or not. I'm going to close and open back up if I run into this again.

This still doesn't seem to be working for me.


Upgrade dependencies

Direct:
golang.org/x/exp v0.0.0-20221002003631-540bb7301a08 golang.org/x/net v0.0.0-20221002022538-bcab6841153b golang.org/x/sync v0.0.0-20220929204114-8fcdb60fdcc0
Indirect:
golang.org/x/crypto v0.0.0-20220926161630-eccd6366d1be golang.org/x/sys v0.0.0-20220928140112-f11e5e49a4ec

Codecov Report

Merging #403 (fb91137) into master (7f33ba0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   70.62%   70.57%   -0.06%
==========================================
  Files          68       68
  Lines        5750     5750
==========================================
- Hits         4061     4058       -3
- Misses       1291     1294       +3
  Partials      398      398

Impacted Files
Coverage Δ

pkg/runner/periodic/periodic.go
92.00% <100.00%> (ø)

dtls/server.go
85.11% <0.00%> (-1.79%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Create a Makefile to easily make/install the application - chtaylo2

Create a Makefile to easily make/install the application

This is completed and checked into development


Building on macOS fails

Hi,
I am trying to build things on macOS and the configure script fails. This is due to neither mysqlclient nor mariadb usually being in the library path (at least not when installing the connector via brew). The way to build things is to use mysql_config --cflags or mariadb_config --cflags, which will return the correct locations for building on both macOS as well as GNU/Linux systems, so I think it is better to use that than to attempt to compile a detect.c.

If you're interested, I can provide a pull request to adjust the build to use the configuration binaries.

Seems like a good idea. For the PR you'll probably also need to use --libs for the mariadb_connector oasis flag.


quiche: Add (http2|quic|spdy)_flags_impl to QUICHE platform implementation.

Description:
Add basic implementation of QUICHE feature and protocol flags. This PR replaces predecessor #6247.
In Google and Chromium code, flag values can be set via the command-line. Per feedback from #6247, in Envoy it would make more sense to (eventually) support setting these via config protobuf. This PR does not include that wiring, but does include a mechanism to set flags reflectively given flag names and values as strings, to serve as the tail end of that config plumbing.
Risk Level: minimal. Code not used yet.
Testing: Unit tests.
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]

/assign @wu-bin

Looks like ASAN is failing due to an initialization order issue that I still need to work out.

Looks like ASAN is failing due to an initialization order issue that I still need to work out.

It turns out the problem was that in the version of Abseil that we are using (which is 6 months old), absl::Mutex cannot be used for variables with static storage duration--that ability was added in a more recent commit, that introduced the absl::Mutex(absl::kConstInit) constructor.
There are a few options for solving this:

Update the Abseil dependency
Use std::mutex instead, which does not suffer from this limitation, but is forbidden by tools/check_format.py.
Remove the mutex, since registration of flags occurs during static initialization, while name-based lookup happens at runtime.
Do something fancy with std::atomic.

I've opted to temporarily remove the mutex, and (separately) try to get the Abseil dependency updated.

It turns out the problem was that in the version of Abseil that we are using (which is [6 months old]

Actually, my comment above is incorrect. Newer Abseil doesn't help. std::mutex works, but is unseemly. So I've reworked the code to initialize FlagRegistry on first use at runtime, which also removes the need for a mutex.

@alyssawilk I think this is ready for a look--thanks!

I'm told @alyssawilk is on vacation. @mattklein123 could you take a look instead? Thanks!

Bumping this to make sure it doesn't get lost.
/assign @alyssawilk

/retest

/retest

Coverage is borked right now.  We're working on it. :-(
On Tue, Apr 30, 2019 at 1:34 PM repokitteh[bot]<EMAIL_ADDRESS>wrote:

🔨 rebuilding ci/circleci: coverage (failed build
https://circleci.com/gh/envoyproxy/envoy/207319?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
)
🐱
Caused by: a #6510 (comment)
https://github.com/envoyproxy/envoy/pull/6510#issuecomment-488043843
was created by @mpwarres https://github.com/mpwarres.
see: more
https://github.com/envoyproxy/envoy/pull/6510#issuecomment-488043843,
trace
https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/282b9430-6b6e-11e9-924d-32fe1a896e53
.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/6510#issuecomment-488043879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AELALPNX4W7BZCLNHNS3IJTPTB7K5ANCNFSM4HEJUC3Q
.


  At the moment the converter only includes the 7 bit ASCII characters in the generated image file, which we might want to extend later on. Perhaps we could at generate a ASCII and a ISO 8859-1 variant of each font. Any other encodings can be handled by the BDF crate.
I've included some new public domain BDF fonts from the xorg project. The necessary e-g types in the mono_font module aren't included yet, but here is an overview of the fonts:

LGTM, assuming e-g integration will come in a future PR.

I'll open an issue for this, because there are some details we will need to discuss before this can be added.

LGTM, assuming e-g integration will come in a future PR.

I'll open an issue for this, because there are some details we will need to discuss before this can be added.


Initial try for connection restart

Summary of the Pull Request
This targets #3726 & #4379
Surprisingly, it works.

References

PR Checklist

[ ] Closes #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

/cc @zadjii-msft. WDYT? Does this looks like the correct way?

FWIW I agree with Dustin on this one. I think stashing the ValueSet for the connection settings should be an easy enough way of keeping all the information relevant to starting a new clone of the connection.

Yeah you guys are right. This PR is just a demonstration.


Update dependency versions

This should let us build Specimin with a modern JDK, and also hopefully fix the issue @LoiNguyenCS is seeing with Spotless, by updating it to the latest version

@LoiNguyenCS I can't add you as a reviewer, so please accept the invitation to become a collaborator on this repo and then assign yourself as a reviewer to this PR (and then review it).
Hopefully, this should fix the issue you emailed me about wrt spotless.


C Syntax Highlighting Following Type Cast with No Space

VSCode Version: 1.38.1
OS Version: Windows_NT x64 10.0.18362

Steps to Reproduce:

Write a line of C code with no space following a type cast

Does this issue occur when all extensions are disabled?: Yes

Can you add a copy/pastable example?

(float)MovAvgGet( &ave[AUX].rawCounts);		//(HW_GetChnData( AUX ));
(float) MovAvgGet( &ave[AUX].rawCounts);		//(HW_GetChnData( AUX ));

Thanks! Looks like this is already fixed in Insiders. You can install the Insiders build or wait for the next stable release.


Maui blazor desktop quick fix

Testing changes to get Maui Blazor Desktop Working.

This should be good, but will let the pipeline test it real quick before readying.


New package: GTcloud v0.1.0

Registering package: GTcloud
Repository: https://github.com/SmartTensors/GTcloud.jl
Created by: @montyvesselinov
Version: v0.1.0
Commit: 1f7e6ab6883e2b80a95714d8c17bb268be7a0cd0
Reviewed by: @montyvesselinov
Reference: https://github.com/SmartTensors/GTcloud.jl/commit/1f7e6ab6883e2b80a95714d8c17bb268be7a0cd0#commitcomment-48872107

I suggest writing out the abbreviation GT in the package name.

ok; GeoThernalCloud is submitted; you can close this one


Cost matrix image

Visualization of the costmatrix, where current heading, chosen waypoint and smoothed waypoint are marked. This 2D visualization is very helpful for debugging
The greener the matrix the more costly from a goal or smoothing perspective the cell is. The reder a cell the more expensive it is due to obstacle distance. The darkest cell is the least expensive one. The dark blue cell (here pink because it is in the red area) is current heading, the light blue one currently chosen best cell, the white one the smoothed setpoint which is actually sent to the pixhawk
Different fixes:

fix bug in smoothing function
change smoothing kernel to be non energy conservant
increase box size
take out histogram relevance check (get rid of unnecessary moving parts which could cause troubles which are hard to find)

We would like to to one more test flight, then this should be ready to go. Praying for nicer weather...

➤ Tanja Baumann commented:
flight test was good, merged


. in attributes value seems to break attributes encoding / decoding on Linux

It seem that fallback implementation of dns-sd has some bug because if service announces attributes like {version:'1.0'} it seems to get discovered as {'0': '', version:'1'} which I suspect is an issue in either attributes encoding or decoding logic, it also appears that native implementation on OSX does not have that issue
https://travis-ci.com/Gozala/libdweb/builds/80314933

Migrated to https://bugzilla.mozilla.org/show_bug.cgi?id=1572219


Removed plan9 extensions from libusb

Signed-off-by: Keith Poole<EMAIL_ADDRESS>

LGTM
And this is it! We're now free of the ken c legacy!

LGTM


Better search for Chinese users

Description of the new feature / enhancement
When using the PowerToys Run function, is it possible to use pinyin instead of Chinese characters to search for Chinese character content
Scenario when this would be used?
When I am not using Chinese input method, I need to switch input methods before I can search for Chinese content
Supporting information
No response

It seems to have been implmented by #21465 and been released in v0.65.0. However it does not work on my machine even if I'm using the latest release from either winget or ms store (just tried the github release, not working either). I'm not sure if this is caused by my environment. Have you tried the lastest release and does it work?

I saw the latest version of the changelog before I remembered the pinyin search Chinese, it seems that there is none

Oh looks like that's what I wanted, I mean, you mentioned my article

It seems to have been implmented by #21465 and been released in v0.65.0. However it does not work on my machine even if I'm using the latest release from either winget or ms store (just tried the github release, not working either). I'm not sure if this is caused by my environment. Have you tried the lastest release and does it work?

https://github.com/microsoft/PowerToys/issues/3587#issuecomment-1348338119

/dup #3587


Add Apache License to source

I just noticed that the pom referenced the license.   I think it's still a good idea to add a license to the source repository as a standard file.


initially ok but after a while using, my customized rueidis connection is "stuck"

initially ok but after a while using, my customized rueidis connection is "stuck" sending with 100% cpu. any ideas why? it's sending part.
i think either

connection dropped or
sending failed for whatever reason.
using the Get pool version mentioned previously.

i've disabled PING. not sure what else to disable etc.

how do i disable pipeline mode?

You could use kill -3 pid to terminate your program with a goroutine dump. From the dump, you could see where it stuck on.
Pipeline mode will not be enabled until you send concurrent requests through the client. Once enabled, it will always use pipeline mode and there is no way to disable it.
Actually, pipelining is native behavior of bidirectional connection, such as tcp. I think any server should support pipelining natively without configuration if it use such connection for communication with clients.

everything's running fine now. i think something to do with "QUIT" command issued (automatically) not sure.

how do i disable being issued quit command?
does this client issue "additional" commands that is not normally issued manually? seems like a lot of background things going without developer input. so just want to make sure no more hiccups just in case. i "disabled" being issued "QUIT" command and it's running fine now. what else shld i be looking out for?

after some time, it freezes according to the pool u sent.
i think the connection is closed or something but i cant confirm.
do u have a ruiedis pool at hand? please make this possible. thx

I am sorry, but I don't get what pool you are referring to.


Error : 'createElement' Is not a function

Hi, So I'm getting this issue suddenly with v1.3.4.
I have seen the issues on here and they are related to v1.2.X, and the fix was applied by the creator, so there was no way I could try and fix it. Did a full reinstall, but nothing changed.
reverted to 1.2.17 for now and that works.

Seems to be something tied with that version, I stuck with 1.3.1 for a while, you can use that one, I am looking forward to a 1.3.4 release for the mobile touch fix

https://www.npmjs.com/package/vue-dndrop/v/1.3.5
On this version ther is no problem :)

Just checked, no still, you can't drag and drop with touch screen in 1.3.5, same issues as before, first touch move works and after that stops workin


Make reducer more aggressive, e.g. by pulling cases out of switch statements

See: https://github.com/KhronosGroup/glslang/issues/1830#issuecomment-511100739
The reducer could have produced a significantly smaller example for this issue; not sure yet what the limitations are, but it likely doesn't pull cases out of a switch statement.

Fixed via #618


Message Extensions - New meeting experience

New Meeting Experience under settings in Microsoft Teams enabled. when using chatbox and click on the ellipses, the messaging extensions button is not enabled. I see it, but not able to click on it.
Turn off 'New meeting experience" and the messaging extensions work normally.
Huge impact for Teaching and Learning on our EDU tenant.

Hi @dblig:
Could you please have a look on this document to know how messaging extensions will enable.

Hi @dblig:
Could you please have a look on this document to know how messaging extensions will enable.

Hi @dblig:
Could you please have a look on this document to know how messaging extensions will enable.

Thanks for your reply. Forgive my ignorance but how does this help our end users that are trying to delivery online lessons via teams. They try to use message extensions to use forms bot however it is greyed out. Turning off the new meeting experience enables the message extensions again. The Teams app appears to have a bug with the new meeting experience.
Other Microsoft 365 tenants do not have this issue........

Hi @dblig:
Could you please have a look on this document to know how messaging extensions will enable.

Thanks for your reply. Forgive my ignorance but how does this help our end users that are trying to delivery online lessons via teams. They try to use message extensions to use forms bot however it is greyed out. Turning off the new meeting experience enables the message extensions again. The Teams app appears to have a bug with the new meeting experience.
Other Microsoft 365 tenants do not have this issue........

Hi @dblig:
Sorry for delayed response!
We can able to see message extensions, please have a look on below screenshot.

Could you please share us the screen shot with repro steps?

Please attached screenshot just taken. The only way to enable the extensions is to turn off the new meeting experience. A backward step.
From: Rama-MSFT<EMAIL_ADDRESS>Date: Thursday, 11 February 2021 at 07:48
To: MicrosoftDocs/msteams-docs<EMAIL_ADDRESS>Cc: dblig<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/msteams-docs] Message Extensions - New meeting experience (#2626)
Hi @dblighttps://github.com/dblig:
Sorry for delayed response!
We can able to see message extensions, please have a look on below screenshot.
[image]https://user-images.githubusercontent.com/71380905/107611823-de7d0300-6c6a-11eb-91db-76a2a9abe300.png
[image]https://user-images.githubusercontent.com/71380905/107612015-47fd1180-6c6b-11eb-8cc1-59410a28c8e9.png
Could you please share us the screen shot with repro steps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/msteams-docs/issues/2626#issuecomment-777257391, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASPWFGTLFN2ONZHJGZWZQMTS6ODVFANCNFSM4WFSXZ7A.

Please attached screenshot just taken. The only way to enable the extensions is to turn off the new meeting experience. A backward step.

Hi dblig,
Could you please have a look and follow the document.

@dblig - Are you still facing the issue? if yes please reopen the issue. Closing the issue for now.


Timedelta dt accessor does not work

MCVE Code Sample
# Your code here
import xarray as xr
import datetime as dt

now = dt.datetime.now()
dt_array = xr.DataArray([now + dt.timedelta(seconds=i) for i in range(10)])

dt_array.dt.second #works

start_t = dt_array - dt_array[0]
start_t.dt.second #fails

Expected Output
Last line should give me the time timedelta in seconds. Instead it raises an exception. Same for hour and minute.
Output of xr.show_versions()

INSTALLED VERSIONS
------------------
commit: None
python: 3.7.3 (default, Apr 24 2019, 15:29:51) [MSC v.1915 64 bit (AMD64)]
python-bits: 64
OS: Windows
OS-release: 10
machine: AMD64
processor: Intel64 Family 6 Model 158 Stepping 10, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None
LOCALE: None.None
libhdf5: None
libnetcdf: None
xarray: 0.14.0
pandas: 0.25.3
numpy: 1.17.4
scipy: 1.2.1
netCDF4: None
pydap: None
h5netcdf: None
h5py: None
Nio: None
zarr: None
cftime: None
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: None
dask: None
distributed: None
matplotlib: 3.1.1
cartopy: None
seaborn: None
numbagg: None
setuptools: 42.0.2.post20191203
pip: 19.1.1
conda: None
pytest: 5.0.0
IPython: 7.7.0
sphinx: 2.2.1

Per Pandas documentation, the following are the defined attributes for Timedelta:

asm8
Return a numpy timedelta64 array scalar view.

components
Return a components namedtuple-like.

days
Number of days.

delta
Return the timedelta in nanoseconds (ns), for internal compatibility.

microseconds
Number of microseconds (>= 0 and less than 1 second).

nanoseconds
Return the number of nanoseconds (n), where 0 <= n < 1 microsecond.

resolution
Return a string representing the lowest timedelta resolution.

resolution_string
Return a string representing the lowest timedelta resolution.

seconds
Number of seconds (>= 0 and less than 1 day).

and since xarray coerces the dataarray to a Pandas Series prior accessing the requested attribute, calling start_t.dt.second fails.

Since seconds is a defined attribute for pandas.TimeDelta, I expect start_t.dt.seconds to work. However, it fails:

In [33]: start_t.dt.seconds
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-33-e1e0943720f8> in <module>
----> 1 start_t.dt.seconds

AttributeError: 'DatetimeAccessor' object has no attribute 'seconds'

This is likely a bug in xarray.

Pandas appears to be establishing differences between DatetimeProperties and TimedeltaProperties differently:

In [16]: start_t_series.dt
Out[16]: <pandas.core.indexes.accessors.TimedeltaProperties object at 0x7f2afafd45c0>

In [17]: dt_array_series.dt
Out[17]: <pandas.core.indexes.accessors.DatetimeProperties object at 0x7f2bf7ccd320>

Xarray, on the other hand, seems to be treating them the same:
In [18]: dt_array.dt
Out[18]: <xarray.core.accessor_dt.DatetimeAccessor at 0x7f2afb6e8710>

In [19]: start_t.dt
Out[19]: <xarray.core.accessor_dt.DatetimeAccessor at 0x7f2afb6a20f0>

Should xarray establish differences between DatetimeProperties and TimedeltaProperties??

This is more unimplemented feature than a bug. .dt is really a DatetimeAccessor.
The Timedelta functionality hasn't been implemented e.g.
https://github.com/pydata/xarray/blob/2ee89c36a7ed512a221d38e09e7637429ced22d3/xarray/core/accessor_dt.py#L204

@dcherian, Thank you for chiming in! Are there any other issues with discussions about  implementation for Timedelta functionality? I am happy to take a stab at implementing this.

I think this would be a welcome feature. It seems like there should be a lot of shared code between the two accessors.


⚠ API - Lens has degraded performance

In d996dbf, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 343 ms

Resolved: API - Lens performance has improved in 438580c after 9 minutes.


keras: Add python as dependency

Add python 3.9 as dependency to the keras codeset as tensorflow
does not support python > 3.9.

Is 3.9 needed? We have 3.6 in other codesets btw

this codeset uses latest tensorflow which supports python 3.9. So I see no reason to use an older version.


[TEST] Verify uninstallation and upgrade for all gitops solutions

What's the test to develop? Please describe
Verify uninstallation for all gitops solutions.
Describe the tasks for the test

Additional context

Also update the doc for the uninstallation and upgrade by the GitOps tools.
cc @innobead @mantissahz

@derekbit Upgrade has been handled in https://github.com/longhorn/longhorn/issues/8240.

For Fleet gitops, the way to uninstall an application is to delete the corresponding GitRepo custom resource:
After the GitRepo custom resource deleted, Longhorn uninstallation job is created, and most of resources are deleted, but longhorn-ui and custom resources still remain:
$ kubectl -n longhorn-system patch -p '{"value": "true"}' --type=merge lhs deleting-confirmation-flag
setting.longhorn.io/deleting-confirmation-flag patched

$ kubectl delete -f longhorn-gitrepo.yaml
gitrepo.fleet.cattle.io "longhorn" deleted

yang@yang:~/Code/fleet-demo$ kubectl -n longhorn-system get pod -w
NAME                                                READY   STATUS        RESTARTS   AGE
longhorn-manager-7lhrf                              1/1     Running       0          114s
longhorn-ui-5f4b7bbf69-vbsft                        1/1     Running       0          114s
longhorn-ui-5f4b7bbf69-2hmjm                        1/1     Running       0          114s
longhorn-manager-df5lt                              1/1     Running       0          114s
longhorn-manager-hs8bx                              1/1     Running       0          114s
longhorn-driver-deployer-9f4fc86-cdx25              1/1     Running       0          114s
instance-manager-099326780217ac44cf8c137319c9a735   1/1     Running       0          101s
instance-manager-00257776f3685a6806ee2224a1ffbfd2   1/1     Running       0          102s
instance-manager-3b9717437bbacfffcd9552daa84f8727   1/1     Running       0          101s
csi-provisioner-667796df57-v67zb                    1/1     Running       0          68s
csi-attacher-5c4bfdcf59-cqrgn                       1/1     Running       0          68s
csi-attacher-5c4bfdcf59-w8j62                       1/1     Running       0          68s
csi-snapshotter-959b69d4b-fccf9                     1/1     Running       0          68s
csi-resizer-694f8f5f64-txfqt                        1/1     Running       0          68s
csi-snapshotter-959b69d4b-gq47p                     1/1     Running       0          68s
csi-provisioner-667796df57-wl6ns                    1/1     Running       0          68s
longhorn-csi-plugin-7rq7b                           3/3     Running       0          68s
csi-resizer-694f8f5f64-c92nw                        1/1     Running       0          68s
longhorn-csi-plugin-27n68                           3/3     Running       0          68s
csi-attacher-5c4bfdcf59-mgd9p                       1/1     Running       0          68s
csi-provisioner-667796df57-zc2nh                    1/1     Running       0          68s
csi-resizer-694f8f5f64-vgk5m                        1/1     Running       0          68s
csi-snapshotter-959b69d4b-gztdx                     1/1     Running       0          68s
longhorn-csi-plugin-k2627                           3/3     Running       0          68s
longhorn-uninstall-8ffzr                            1/1     Running       0          5s
engine-image-ei-5cefaf2b-4xd2b                      1/1     Terminating   0          102s
engine-image-ei-5cefaf2b-d9lt5                      1/1     Terminating   0          102s
engine-image-ei-5cefaf2b-vq97w                      1/1     Terminating   0          102s
engine-image-ei-5cefaf2b-vq97w                      0/1     Terminating   0          116s
engine-image-ei-5cefaf2b-4xd2b                      0/1     Terminating   0          116s
engine-image-ei-5cefaf2b-d9lt5                      0/1     Terminating   0          116s
engine-image-ei-5cefaf2b-d9lt5                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-4xd2b                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-vq97w                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-vq97w                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-vq97w                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-vq97w                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-4xd2b                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-4xd2b                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-d9lt5                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-d9lt5                      0/1     Terminating   0          2m12s
engine-image-ei-5cefaf2b-d9lt5                      0/1     Terminating   0          2m12s
instance-manager-00257776f3685a6806ee2224a1ffbfd2   1/1     Terminating   0          2m13s
instance-manager-3b9717437bbacfffcd9552daa84f8727   1/1     Terminating   0          2m12s
instance-manager-00257776f3685a6806ee2224a1ffbfd2   0/1     Terminating   0          2m13s
instance-manager-099326780217ac44cf8c137319c9a735   1/1     Terminating   0          2m13s
instance-manager-3b9717437bbacfffcd9552daa84f8727   0/1     Terminating   0          2m13s
instance-manager-099326780217ac44cf8c137319c9a735   0/1     Terminating   0          2m13s
longhorn-manager-hs8bx                              1/1     Terminating   0          2m26s
longhorn-manager-df5lt                              1/1     Terminating   0          2m26s
longhorn-manager-7lhrf                              1/1     Terminating   0          2m26s
instance-manager-3b9717437bbacfffcd9552daa84f8727   0/1     Terminating   0          2m13s
instance-manager-3b9717437bbacfffcd9552daa84f8727   0/1     Terminating   0          2m13s
instance-manager-3b9717437bbacfffcd9552daa84f8727   0/1     Terminating   0          2m13s
instance-manager-00257776f3685a6806ee2224a1ffbfd2   0/1     Terminating   0          2m14s
instance-manager-00257776f3685a6806ee2224a1ffbfd2   0/1     Terminating   0          2m14s
instance-manager-00257776f3685a6806ee2224a1ffbfd2   0/1     Terminating   0          2m14s
longhorn-manager-df5lt                              0/1     Terminating   0          2m26s
longhorn-manager-7lhrf                              0/1     Terminating   0          2m26s
longhorn-manager-hs8bx                              0/1     Terminating   0          2m26s
longhorn-manager-7lhrf                              0/1     Terminating   0          2m26s
instance-manager-099326780217ac44cf8c137319c9a735   0/1     Terminating   0          2m13s
instance-manager-099326780217ac44cf8c137319c9a735   0/1     Terminating   0          2m13s
instance-manager-099326780217ac44cf8c137319c9a735   0/1     Terminating   0          2m13s
longhorn-manager-7lhrf                              0/1     Terminating   0          2m27s
longhorn-manager-7lhrf                              0/1     Terminating   0          2m27s
longhorn-manager-hs8bx                              0/1     Terminating   0          2m27s
longhorn-manager-hs8bx                              0/1     Terminating   0          2m27s
longhorn-manager-hs8bx                              0/1     Terminating   0          2m27s
longhorn-manager-df5lt                              0/1     Terminating   0          2m27s
longhorn-manager-df5lt                              0/1     Terminating   0          2m27s
longhorn-manager-df5lt                              0/1     Terminating   0          2m27s
csi-attacher-5c4bfdcf59-w8j62                       1/1     Terminating   0          101s
csi-attacher-5c4bfdcf59-cqrgn                       1/1     Terminating   0          101s
csi-attacher-5c4bfdcf59-mgd9p                       1/1     Terminating   0          101s
longhorn-driver-deployer-9f4fc86-cdx25              1/1     Terminating   0          2m27s
csi-attacher-5c4bfdcf59-w8j62                       0/1     Terminating   0          101s
csi-attacher-5c4bfdcf59-mgd9p                       0/1     Terminating   0          101s
csi-attacher-5c4bfdcf59-cqrgn                       0/1     Terminating   0          101s
longhorn-driver-deployer-9f4fc86-cdx25              0/1     Terminating   0          2m28s
csi-provisioner-667796df57-wl6ns                    1/1     Terminating   0          102s
csi-attacher-5c4bfdcf59-cqrgn                       0/1     Terminating   0          102s
csi-attacher-5c4bfdcf59-cqrgn                       0/1     Terminating   0          102s
csi-provisioner-667796df57-v67zb                    1/1     Terminating   0          102s
csi-attacher-5c4bfdcf59-cqrgn                       0/1     Terminating   0          102s
csi-provisioner-667796df57-zc2nh                    1/1     Terminating   0          102s
longhorn-csi-plugin-27n68                           3/3     Terminating   0          102s
longhorn-driver-deployer-9f4fc86-cdx25              0/1     Terminating   0          2m28s
csi-attacher-5c4bfdcf59-w8j62                       0/1     Terminating   0          102s
longhorn-csi-plugin-k2627                           3/3     Terminating   0          102s
longhorn-driver-deployer-9f4fc86-cdx25              0/1     Terminating   0          2m28s
longhorn-driver-deployer-9f4fc86-cdx25              0/1     Terminating   0          2m28s
csi-attacher-5c4bfdcf59-w8j62                       0/1     Terminating   0          102s
longhorn-csi-plugin-7rq7b                           3/3     Terminating   0          102s
csi-attacher-5c4bfdcf59-w8j62                       0/1     Terminating   0          102s
csi-provisioner-667796df57-wl6ns                    0/1     Terminating   0          102s
csi-provisioner-667796df57-zc2nh                    0/1     Terminating   0          102s
csi-attacher-5c4bfdcf59-mgd9p                       0/1     Terminating   0          102s
csi-provisioner-667796df57-v67zb                    0/1     Terminating   0          102s
csi-attacher-5c4bfdcf59-mgd9p                       0/1     Terminating   0          102s
csi-attacher-5c4bfdcf59-mgd9p                       0/1     Terminating   0          102s
longhorn-csi-plugin-27n68                           0/3     Terminating   0          102s
longhorn-csi-plugin-7rq7b                           0/3     Terminating   0          102s
csi-provisioner-667796df57-zc2nh                    0/1     Terminating   0          102s
longhorn-csi-plugin-k2627                           0/3     Terminating   0          102s
csi-provisioner-667796df57-zc2nh                    0/1     Terminating   0          103s
csi-provisioner-667796df57-zc2nh                    0/1     Terminating   0          103s
csi-resizer-694f8f5f64-vgk5m                        1/1     Terminating   0          103s
csi-resizer-694f8f5f64-c92nw                        1/1     Terminating   0          103s
csi-resizer-694f8f5f64-txfqt                        1/1     Terminating   0          103s
csi-resizer-694f8f5f64-c92nw                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-vgk5m                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-txfqt                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-txfqt                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-txfqt                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-txfqt                        0/1     Terminating   0          103s
longhorn-csi-plugin-27n68                           0/3     Terminating   0          103s
csi-provisioner-667796df57-v67zb                    0/1     Terminating   0          103s
csi-provisioner-667796df57-v67zb                    0/1     Terminating   0          103s
csi-provisioner-667796df57-v67zb                    0/1     Terminating   0          103s
longhorn-csi-plugin-27n68                           0/3     Terminating   0          103s
longhorn-csi-plugin-27n68                           0/3     Terminating   0          103s
csi-snapshotter-959b69d4b-fccf9                     1/1     Terminating   0          103s
csi-snapshotter-959b69d4b-gq47p                     1/1     Terminating   0          103s
csi-provisioner-667796df57-wl6ns                    0/1     Terminating   0          103s
csi-snapshotter-959b69d4b-gztdx                     1/1     Terminating   0          103s
csi-provisioner-667796df57-wl6ns                    0/1     Terminating   0          103s
csi-provisioner-667796df57-wl6ns                    0/1     Terminating   0          103s
longhorn-csi-plugin-7rq7b                           0/3     Terminating   0          103s
csi-resizer-694f8f5f64-c92nw                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-c92nw                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-c92nw                        0/1     Terminating   0          103s
longhorn-csi-plugin-7rq7b                           0/3     Terminating   0          103s
longhorn-csi-plugin-7rq7b                           0/3     Terminating   0          103s
csi-snapshotter-959b69d4b-fccf9                     0/1     Terminating   0          103s
csi-resizer-694f8f5f64-vgk5m                        0/1     Terminating   0          103s
csi-snapshotter-959b69d4b-gq47p                     0/1     Terminating   0          103s
csi-resizer-694f8f5f64-vgk5m                        0/1     Terminating   0          103s
csi-resizer-694f8f5f64-vgk5m                        0/1     Terminating   0          103s
longhorn-csi-plugin-k2627                           0/3     Terminating   0          103s
longhorn-csi-plugin-k2627                           0/3     Terminating   0          103s
longhorn-csi-plugin-k2627                           0/3     Terminating   0          103s
csi-snapshotter-959b69d4b-gztdx                     0/1     Terminating   0          103s
csi-snapshotter-959b69d4b-gq47p                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-gq47p                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-gq47p                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-fccf9                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-fccf9                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-fccf9                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-gztdx                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-gztdx                     0/1     Terminating   0          104s
csi-snapshotter-959b69d4b-gztdx                     0/1     Terminating   0          104s
longhorn-uninstall-8ffzr                            0/1     Completed     0          42s
longhorn-uninstall-8ffzr                            0/1     Completed     0          43s
longhorn-uninstall-8ffzr                            0/1     Completed     0          44s
longhorn-uninstall-8ffzr                            0/1     Completed     0          44s
longhorn-uninstall-8ffzr                            0/1     Terminating   0          44s
longhorn-uninstall-8ffzr                            0/1     Terminating   0          44s

$ kubectl -n longhorn-system get pod
NAME                           READY   STATUS    RESTARTS   AGE
longhorn-ui-5f4b7bbf69-vbsft   1/1     Running   0          2m40s
longhorn-ui-5f4b7bbf69-2hmjm   1/1     Running   0          2m40s

$ kubectl get crd | grep longhorn
backingimagedatasources.longhorn.io         2024-04-26T01:33:08Z
backingimagemanagers.longhorn.io            2024-04-26T01:33:08Z
settings.longhorn.io                        2024-04-26T01:33:08Z
replicas.longhorn.io                        2024-04-26T01:33:08Z
volumeattachments.longhorn.io               2024-04-26T01:33:08Z
backupvolumes.longhorn.io                   2024-04-26T01:33:08Z
instancemanagers.longhorn.io                2024-04-26T01:33:08Z
sharemanagers.longhorn.io                   2024-04-26T01:33:08Z
engines.longhorn.io                         2024-04-26T01:33:08Z
systemrestores.longhorn.io                  2024-04-26T01:33:08Z
supportbundles.longhorn.io                  2024-04-26T01:33:08Z
systembackups.longhorn.io                   2024-04-26T01:33:08Z
backups.longhorn.io                         2024-04-26T01:33:08Z
recurringjobs.longhorn.io                   2024-04-26T01:33:08Z
backupbackingimages.longhorn.io             2024-04-26T01:33:08Z
snapshots.longhorn.io                       2024-04-26T01:33:08Z
orphans.longhorn.io                         2024-04-26T01:33:08Z
backingimages.longhorn.io                   2024-04-26T01:33:08Z
backuptargets.longhorn.io                   2024-04-26T01:33:08Z
engineimages.longhorn.io                    2024-04-26T01:33:08Z
nodes.longhorn.io                           2024-04-26T01:33:08Z
volumes.longhorn.io                         2024-04-26T01:33:08Z

@derekbit Do you have any suggestion?

For Flux gitops, running flux delete helmrelease longhorn-release -n longhorn-system correctly uninstalled Longhorn without remaining any resources.

For ArgoCD, after running argocd app delete longhorn and kubectl delete -f https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml, most of Longhorn resources will be deleted except engineimages.longhorn.io and nodes.longhorn.io:
$ kubectl delete -f https://raw.githubusercontent.com/longhorn/longhorn/v1.6.1/deploy/longhorn.yaml
namespace "longhorn-system" deleted
customresourcedefinition.apiextensions.k8s.io "backingimagedatasources.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "backingimagemanagers.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "backingimages.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "backupbackingimages.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "backups.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "backuptargets.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "backupvolumes.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "engineimages.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "engines.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "instancemanagers.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "nodes.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "orphans.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "recurringjobs.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "replicas.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "settings.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "sharemanagers.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "snapshots.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "supportbundles.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "systembackups.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "systemrestores.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "volumes.longhorn.io" deleted
customresourcedefinition.apiextensions.k8s.io "volumeattachments.longhorn.io" deleted
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": priorityclasses.scheduling.k8s.io "longhorn-critical" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": serviceaccounts "longhorn-service-account" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": serviceaccounts "longhorn-ui-service-account" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": serviceaccounts "longhorn-support-bundle" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": configmaps "longhorn-default-setting" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": configmaps "longhorn-storageclass" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": clusterroles.rbac.authorization.k8s.io "longhorn-role" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": clusterrolebindings.rbac.authorization.k8s.io "longhorn-bind" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": clusterrolebindings.rbac.authorization.k8s.io "longhorn-support-bundle" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-backend" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-frontend" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-conversion-webhook" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-admission-webhook" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-recovery-backend" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-engine-manager" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": services "longhorn-replica-manager" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": daemonsets.apps "longhorn-manager" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": deployments.apps "longhorn-driver-deployer" not found
Error from server (NotFound): error when deleting "https://raw.githubusercontent.com/longhorn/longhorn/master/deploy/longhorn.yaml": deployments.apps "longhorn-ui" not found

$ kubectl -n longhorn-system get pod
No resources found in longhorn-system namespace.

$ kubectl get crd | grep longhorn
engineimages.longhorn.io                2024-04-26T02:59:19Z
nodes.longhorn.io                       2024-04-26T02:59:19Z

@derekbit Do you have any suggestion about how to correctly clean up the crds?


RFC: LLM -> StrInStrOutLLM

Find this interface name very confusing (not specific enough). Thoughts on updating? Open to other names, just want it to be specific.
Think it's backwards compat but very well might be overlooking something

what's opposite of "batched"? non-batched? could also call it something like that (NonBatchedLLM)

Hm I agree the _call naming is confusing and it'd be easier if we went the other way (generate -> batch_generate). Could call it something like _call_single() or something

Hm I agree the _call naming is confusing and it'd be easier if we went the other way (generate -> batch_generate). Could call it something like _call_single() or something

i like idea of this being generate and other one being batch_generate, just worried that that may be too big of a change at this pt
i like generate more than call, call doesn't mean much to me. i also think its more than just "single", which to me would imply you're returning a single Generate object. but this is even less than that, its a single string output

another idea: SimpleLLM


Meltano distribution versioning scheme

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/136
Originally created by @mbergeron on 2018-10-23 13:46:42

Our current distribution scheme is currently based of the master branch of the meltano/meltano repo. I think we need to figure how we'll version the artifacts (docker images and PyPI package) so that we limit the issues on the end-user side.
Right now, the gitlab-analytics runners uses the singer_runner:latest image, which is built automatically of the master branch. I think it would be sensible to at least have some tags to limit the regressions they might have.
I think we should mimic as much a possible the GitLab release process, but streamline it to the minimum. Who could help us define that process?
/cc @jschatz1 @iroussos @tayloramurphy

View 10 previous comments from the original issue on GitLab


Secure infos sent by the agent, add TLS layer over UDP

based on https://github.com/pixelbender/go-dtls


Fix argument parsing for pass through commands

cluster ssh|kubectl now escape every flags coming after its mention
and pass the through to the consecutive subcommand. Fixes #5
Fix argument parsing for pass through commands `kubectl` and `ssh`

/lgtm


Idea: Calendar Module

In case of having a "Community Calendar" we could integrate this to the Api, to access Data from that Calendar in other projects as well.
Before realizing that we should definitly specify some more Details - Feel free to Add Ideas in the Comments!

I think this would be great 👍
The Discord bot could read/write to this to add / list events, and the web ui could list the events on a web page
On the list api end-point, it should only return up and coming events, other the list will get too long

The calendar data might look like
{
   name: string;
   description: string;
   url: string;
   platform: "YouTube" | "Twitch"; // we should only have an allowed list
   author: {
      platform: "discord" | "github"; // these events could be created via the discord bot or a GitHub Action triggered by an issue
      uid: string
   };
   startDate: Date;
   endDate: Date;
}

Notes:

future: on the GET the list should only bring back current events going on and future events
history: another idea is to have a parameter on the GET to be able to retrieve historic events, but this can come later on in another PR
delete can only be by the same author (in the future by admin but we have no admin facility for this yet)

Is the uid in the author-object generated by the api or sent by the client? I'm not 100% clear what uid this is 😅

In my mind (which could be wrong), I was thinking of the uid being the user object from their respect platforms, so in the Discord Bot it would send through their Discord unique identifier and on the GitHub Action it would be their GitHub username - only approved apps can send through the data, so I think we can trust this data?

Oh now I get it :D I thought about using the uuid-package for this.
I think you are right, with the Authentication we can trust the provided data.
I think we need to add an id for the actual calendar-object as well.
Do we need info about created or updated?

When doing the date calculations which event is in the past, which one is ongoing and which one is the future, I'd like to use a third-party package for that. I really enjoy using date-fns when it comes to this.
Is this okay for you?

I think we need to add an id for the actual calendar-object as well.
Do we need info about created or updated?

Good point, yes and yes 👍

I really enjoy using date-fns when it comes to this.

Good idea 👍

I implemented the response for the getAll-Endpoint like shown above:

The Events are already sorted in future and ongoing, so the client doesnt need to implement this logic.
When using a database we should define the timeranged before making the request and not filtering like here.


Finalizing Select All

Go over select all rows logic & documentation in regard to async.

select all is finished, with a small caveat - If using an a-sync flow with pagination, than supplying a page size or batch size that don't match each other might cause the table to request only part of the rows in the page. This means that the select all might not be able to select all the rows of the page.
An obvious fix is to match the page size as batch size via props.
But I am thinking maybe we should do that by default..
It would mean that, if uncontrolled, the batch size will change whenever the page size changes.
@NadavShaar I can't decide if this is a good default behavior.

select all is finished, with a small caveat - If using an a-sync flow with pagination, than supplying a page size or batch size that don't match each other might cause the table to request only part of the rows in the page. This means that the select all might not be able to select all the rows of the page.
An obvious fix is to match the page size as batch size via props.
But I am thinking maybe we should do that by default..
It would mean that, if uncontrolled, the batch size will change whenever the page size changes.
@NadavShaar I can't decide if this is a good default behavior.

@ilayofir please sync batch size and page size and disable "All" mode selection for async.

@ilayofir please sync batch size and page size and disable "All" mode selection for async.

synced!

synced!


Create a helper as a shortcut for method spoofing

Similar to csrf_field().

Hmm the idea is ok, but not sold on the name... Maybe "method_field" or something.

You're right, makes more sense. Changed the name to what you suggested.

You're right, sorry. I'm not a native speaker, so sometimes these things happen.


Update shared/README.md

Update README for new layout.

@keybase/react-hackers

if we're putting this into shared we might want to merge the one in desktop also

Moved desktop docs in here too.


buildFHSUserEnv{Chroot,Bubblewrap}: link gsettings-schemas to the FHS…

… location

Motivation for this change
Supersedes  #83705
Things done
Tested by launching with XDG_DATA_DIRS= ./result/bin/ssb-patchwork and selecting a profile picture which opens a file picker

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

moved mkdir -p $out/share/glib-2.0/schemas out of a if block to make sure it always exists

TODO remove gsettings-desktop-schemas and hicolor-icon-theme  from packages that use the appimage builder
Result of nixpkgs-review pr 161739 run on x86_64-linux 1

2 packages marked as broken and skipped:

ovftool
timedoctor

1 package blacklisted:

appimage-run-tests

5 packages failed to build:

ciscoPacketTracer7
ciscoPacketTracer8
houdini
quartus-prime-lite
runescape

109 packages built:

Sylk
altair
android-studio (androidStudioPackages.stable)
androidStudioPackages.beta
androidStudioPackages.canary
androidStudioPackages.dev
anki-bin
anytype
appimage-run
apple-music-electron
arduino
arduino-ci
arduino-cli
arduino-core
beekeeper-studio
betterdiscord-installer
beyond-identity
bitscope.chart
bitscope.console
bitscope.display
bitscope.dso
bitscope.logic
bitscope.meter
bitscope.proto
bitscope.server
bloomrpc
bottles
buttercup-desktop
chrysalis
clonehero
conda
cozy-drive
crypto-org-wallet
devdocs-desktop
dropbox
dropbox-cli
electron-mail
electronplayer
esphome
fahclient
firefly-desktop
flexoptix-app
flutter (flutterPackages.stable)
fspy
heroic
hover
irccloud
itch
itch-setup
joplin-desktop
keeweb
kodiPackages.steam-launcher
lbry
ledger-live-desktop
left4gore-bin
lens
lightworks
losslesscut-bin
lunar-client
lutris
lutris-free
marktext
mate.caja-dropbox
mathpix-snipping-tool
minigalaxy
mobilecoin-wallet
molotov
mycrypto
neo4j-desktop
notable
notion-app-enhanced
nuclear
octant-desktop
p3x-onenote
pdfstudio
pdfstudioviewer
platformio
playonlinux
plex
plexamp
protontricks
radicle-upstream
rambox-pro
saleae-logic-2
session-desktop-appimage
shticker-book-unwritten
sidequest
ssb-patchwork
standardnotes
station
steam
steam-run
steam-tui
steamcmd
teensyduino
timeular
trezor-suite
tusk
unityhub
unvanquished
via
vial
vmware-horizon-client
vscode-fhs
vscodium-fhs
wootility
ytmdesktop
zettlr
zulip


ISA-tab import fails when no material present in assay

Importing ISA-tabs where Sample Name is the only material in the assay file fails with the following message:
No materials in assay "a_assay_name.txt": Importing sheets with tables containing zero lines is currently not supported.
This is not an Altamisa exception. Altamisa parses this ISA-tab without any error messages.
Expected Behavior
ISA-tabs with only Sample Name as a material in the assay sheet should be imported. Workaround: Add an empty material or data column to ISA-tab.

Not a bug, expected behaviour. Empty assays will be supported in the future when creating new studies and assays in the editor is added. If not there, I will add a note about it in the manual.

Sorry, should have clarified. Sample Name is not the only node in this assay. The graph looks like this: Sample Name > Process > Process > Process
There are assist
While not having a final material


Added StockPosition entity

This should add the StockPosition entity. According to the API documentation, this entity is not Storable and as such, that corresponding trait has not been added in.

Thanks for adding!
Op di 10 mei 2016 om 15:22 schreef Jan-Marten de Boer <
<EMAIL_ADDRESS>
Closed #1 https://github.com/exactonline/exact-php-client/pull/1.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/exactonline/exact-php-client/pull/1#event-655744855

@johmanx10 we would like to accept your pull request on or fork. Can you re-open the pull request? Thanks!

@rubenmijwaart I have moved the pull request to the original repository and they have released a new version to correspond with that https://github.com/picqer/exact-php-client/releases
Perhaps a simple synchronization with the original repository would be a good idea for this fork.

Yes, that will do the job, thanks!


defmt-print: Recover from decoding-errors

This PR uses the new StreamDecoder-API in defmt-print and utilizes it to recover from decoding errors.
Fixes #559

bors r+

bors retry


Create framework.yaml reference documentation

I think this is part of the Developer documentation so I kind of already did that.


Update devtest-lab-faq.md

Fixed a typo in the script as under:
When you execute following script after replacing , you get "New-AzRoleDefinition: Scope 'subscriptions/4a1cd4de-3bfa-49db-bfa6-ea23a330eb8a' should begin with '/subscriptions' or '/providers'." error:
$policyRoleDef = Get-AzRoleDefinition "DevTest Labs User"
$policyRoleDef.Actions.Remove('Microsoft.DevTestLab/Environments/*')
$policyRoleDef.Id = $null
$policyRoleDef.Name = "DevTest Labs Advanced User"
$policyRoleDef.IsCustom = $true
$policyRoleDef.AssignableScopes.Clear()
$policyRoleDef.AssignableScopes.Add("/subscriptions/")
$policyRoleDef.Actions.Add("Microsoft.DevTestLab/labs/virtualMachines/Start/action")
$policyRoleDef.Actions.Add("Microsoft.DevTestLab/labs/virtualMachines/Stop/action")
$policyRoleDef = New-AzRoleDefinition -Role $policyRoleDef
This proposed change will fix this issue.

@sriniambati : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Elements get hidden on window resize (in combination with wow.js)

Hey there,
i noticed that when you combine rellax.js with wow.js (for unveiling elements on scroll) elements get hidden by wow.js when you scroll to an element which makes use of both libraries and the change the window width ob the browser:

Any Ideas?

because wowJS is setting visibility: hidden. there's no code which alters the visibility in the rellax library so this is not related to rellaxJS. maybe the wow.sync() function is helping if you call it manually on resize. 🤔

I never found a solution for this.
For now wouldn't recommend using wow and rellax in combination.


[SYSTEM] FIX Double Entries

System should not accept double entries/records.

Level double entry

Curriculum double entry

double entry @ requirements

Double entry in admission

Fix double entry in Fees


Background colors only extend as far as text

See screenshot for an example, this is happening for headers and blocks, and is reproducible on several machines with this minimal config file. I've added a bunch of spaces to the end of the header here but it happens on headers of all levels. Any ideas how to debug it?
(setq custom-theme-directory "~/.emacs.d/packages/emacs-material-theme")
(load-theme 'material-light t)

As far as I know this is just how emacs does it.
But looking at the first screenshot of e.g. https://github.com/fniessen/emacs-leuven-theme#screenshots
it seems that the background extends the whole width of the buffer, even if the overline does not.
The second screenshot seems to contradict that though.
So maybe you can check if leuven-theme does it correctly. If it indeed does we should be able to check their config to replicate it for material theme.

Hmm strange it does it for leuven too. For the sake of versions I'm running emacs 27.1 and org 9.3, I wonder if downgrading my org version might help. And yeah looking at those screenshots it doesn't seem very consistent - I suppose I'm more concerned with the src blocks not extending the width than the headers though. Also having a hard time finding another user with this question in general... blarg.
Thanks for the response btw

I think if you want a definite answer if it is even possible it might be best to inquire on the emacs reddit

so I think I've tracked this down to an issue caused by emacs 27, (relevant reddit thread) making a change to highlighting lines - in particular the new :extend attribute.
I can put in a PR with the minimal lines that I got it working for but I'm not sure if that'll maintain the version 24 compatibility you have. In fact I think this would only go back to 26 without raising an error. What do you think?

I'm happy to include that. So if you could open a PR that would be great.
I'll have to check if backwards compatibility is important or if older emacs versions just get a older version of the theme through MELPA automatically.

I consider this closed by #50
Please reopen if other faces need to be fixed


Automatic screenshot upload along with error log

Hi
thank you for this
thats a great idea
ill add it to the todo

Thank you.
If you could get the error log and the screenshot should be in the same testrail result entry, that'd be much helpful.

hi there
just did it,...and it looks promising.
should be released after christmas...but its already in dev-master (no guarantee yet) :)

That's good to hear. Thank you very much.

hi there
just published 2.5.0 with this feature
please see the README for more :)
i will now close this ticket, thx for the great idea


⚠ Bofrost.be has degraded performance

In ca82bd2, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1559 ms

Resolved: Bofrost.be performance has improved in 650ff89.


added a reference to custom roles

Hi @jurajsucik, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@jurajsucik - thanks very much for your contribution!
@kgremban - can you have a look at this PR? Juraj is a MSFT employee. The PR is currently in merge conflict, so it's probably best if you can review these and decide if they should be rolled into a different/internal PR. LMK and I can close this one after you have a chance to review. Thanks!

@BryanLa This branch is in conflict because I separately made an update similar to the one @jurajsucik requested. This PR can be closed. Thank you for the feedback, Juraj!

@kgremban Done. Thanks again!

Hi @jurajsucik, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@jurajsucik - please ignore the bot message. The GitHub UI hung for a second, causing a brief reopen/close.


fix(csharp): returning result with incorrect lang identifer

I'm sorry for my stupid mistake :weary:

I'm sorry for not reviewing properly 😩


fix incorrect description in device-plugins.md

The /var/lib/kubelet/pod-resources should mounted as a volume in Device Monitoring Agent but not Device Plugin.

@onlydole @jimangel Any suggestions?

/sig node


Add options to suppress loading of JS libraries

AngularFaces checks whether third-party libraries such as AngularJS and jQuery are included by the current JSF page. If not, it adds the dependency itself. Unfortunately, this check fails if the third-party files are renamed or merged into a single file containing every JS dependency. This is a common scenario, so AngularFaces needs an option to suppress to automatic include of AngularJS and jQuery.

Now it's possible to control each file individually:
	<context-param>
		<param-name>AngularFaces.includeAngularJS</param-name>
		<param-value>false</param-value>
	</context-param>
	<context-param>
		<param-name>AngularFaces.includeJQuery</param-name>
		<param-value>false</param-value>
	</context-param>
	<context-param>
		<param-name>AngularFaces.includeJQueryUI</param-name>
		<param-value>false</param-value>
	</context-param>
	<context-param>
		<param-name>AngularFaces.includeAngularMessages</param-name>
		<param-value>false</param-value>
	</context-param>

done


Add Makefile rules for building gdbserver and flash program

Sorry; the other commit (d0e853f) was the subject of a separate pull request.

I guess I didn't understand that pull requests stayed open. Anyhow, there's an extra pull request I can close...


[BugFix] fix connector scan operator fail to handle limit

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #18278
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

Maybe we can make this optimization/bugfix more general-purpose.
For all connectors, we can check

set has_predicate by checking conjuncts
and fix limit by peeking has_predicate

run starrocks_admit_test

@Mergifyio backport branch-3.0


Native proxy on windows (didn't try other OS) doesn't work #18511

Description
Native proxy on windows (didn't try other OS) doesn't work because in the ZIP package the plugins "org.eclipse.core.net.win32.x86_64" and "org.eclipse.core.net.win32" are missings.
If i add those plugins in the plugins directory and add it to the bundles.info, it works then.
Same as : https://github.com/dbeaver/dbeaver/issues/18511
DBeaver Version
CE 24.0.0
Operating System
Windows 10
Database and driver
No response
Steps to reproduce
Try to set "Native" on Preferences > Network Connection
Additional context
No response

Thanks for the bug report

Is it possible to add a test to avoid that this issue reoccures in future releases ?


Not working after mojang update

Its working for me, make sure your settings are set right

Its working for me, make sure your settings are set right

I'm getting the same, settings used to work.

I'm getting the same, settings used to work.

Turn on debug mode and see if any errors shows up

Turn on debug mode and see if any errors shows up

None.

None.

none

none


Better globby/promise support in light of #1

Instead of:
globby('assets/fav*.ico').then(assets => lnk(assets, 'dist', {
    …
}));

It would be nice to allow:
lnk(globby('assets/fav*.ico'), 'dist', {
    …
});

Landed with v1.1.0.


Share template between user and org explore pages

Allow user pages and organization pages in exploration, single pages to show more users/organizations.

Before
After

Templates on both places look pretty similar, can we share them via a subtemplate?

I don't have a preference for this, but we already have a users template, so it shouldn't be users

users-list maybe?

users-list contains users and orgs, will this cause ambiguity in reading?

owners-list?

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@371dd96). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #21879   +/-   ##
=======================================
  Coverage        ?   47.88%
=======================================
  Files           ?     1037
  Lines           ?   141213
  Branches        ?        0
=======================================
  Hits            ?    67618
  Misses          ?    65483
  Partials        ?     8112

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Seems we forgot about this PR. I recall the incorrect image alignments were fixed recently, so that will be one reason for conflict.

Is this PR active?

It has been stale for a long time and I can't think of a way to handling it other than closing it. Feel free to reopen if there's any new progress and I could also help.


Buttons are broken in Safari

Make sure these boxes are ticked before submitting a new issue:

[x] I have checked that this is not a duplicate

For Safari browsers it's important to override default styling.
See: https://css-tricks.com/almanac/properties/a/appearance/

@williamkolmacka If it's possible, remove all default styling, as I mentioned in the specification. Only default styling that should stay is a focused state.

@Fallion Did you see this issue on the Button component which is now on master branch? The new Button component looks alright, so I don't know if it's important to fix it because we will update current Button component soon for the new one.

Closed by #135


Fix template restart bug

Coverage increased (+0.003%) to 68.109% when pulling 0e70ac87cc3d3624b1d2797c5a5352b33d02a4b8 on fix_template_restart_bug into 2784603be1cc95db488c84c9265f06db3c13674f on master.

LGTM

Hi, it seems that the failure of E2E test has nothing to do with this PR, but with PR 3292. Could you please check what the problem is?


Add option to search path

Added option to search PATH variable for more coverage.

Now is prepared to merge, I fixed some errors and tested on Windows and Ubuntu.
If you want to review @HarbingerOfFire you are free to do it.

Looks good to me


Port 5000 is not exposed

Currently in the Dockerfile port 5000 is not exposed. Without this you can't connect with a docker client?

Technically you can use any port for connecting to a docker repository. You need to choose which port you want to use when you setup your docker repo inside of Nexus, thus, we do not expose any port by default, since you will need to do this yourself.


Implement logsumexp backend for opt_einsum

Addresses #915
Pair coded with @eb8680
This implements a logsumexp backend for opt_einsum.contract() and sumproduct(). To use this for logsumexp contraction, set the appropriate backend:
log_factors = [...]
log_result = sumproduct(log_factors, backend='pyro.ops.einsum.torch_log')

To share comptation among multiple calls, you can combine this with the deferred backend
from pyro.ops.einsum.deferred import deferred_tensor, shared_intermediates

log_factors1 = [...]
log_factors2 = [...]
with shared_intermediates():
    log_factors1_ = [deferred_tensor(t) for t in log_factors1]
    log_factors2_ = [deferred_tensor(t) for t in log_factors2]
    results_ = [sumproduct(log_factors1_ + [t], backend='pyro.ops.einsum.deferred')
                for t in log_factors2_]
results = [t.eval(backend='pyro.ops.einsum.torch_log') for t in results_]

Tested

added tests against naive implementation

Codecov Report

Merging #1314 into dev will decrease coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##              dev    #1314      +/-   ##
==========================================
- Coverage   95.39%   95.38%   -0.01%
==========================================
  Files         119      120       +1
  Lines        6357     6411      +54
==========================================
+ Hits         6064     6115      +51
- Misses        293      296       +3

Impacted Files
Coverage Δ

pyro/ops/einsum/torch_log.py
94.44% <94.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd36b6b...178b6c4. Read the comment docs.


c++14

discuss!

Travis doesn't seem to support this without additional steps, so I'll look into that unless someone else knows the story?

or alternatively that we don't want this

please check if fbandroid and fbobjc support c++14 before you turn this switch on. Last time I checked (4 months back) fb android didn't support it. It would be extra work to deal with the compile time issues for all new c++14 stuff.

@lehecka stop suggesting std:make_unique then!

sorry, I might have forgotten...
there is also folly::make_unique doing the same thing in C++11.
Maybe I'll just shutup..


Rewording for clarity.

This page stated that the property returns a "read-only" font object. This is contradicted by the remarks and by the example. I suggest "stand-alone" instead of "read-only", and  some other wording changes to attempt to make clear the relationship between the specified font and the returned font object.

Hi @RHolton, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Corrected property description in local master branch. Will merge by May 31


e2e: Add e2e tests for policy-age and policye-heat-idlepage

Add policy-heat-tracker-idlepage e2e test
Add policy-age-tracker-idlepage e2e test
Add policy-age-tracker-softdirty e2e test
Rename test01-swap under policy-heat to test01-swap-softdirty
Move test02-routines under policy-heat to no-policy

This patch is picked from https://github.com/askervin/cri-resource-manager/pull/4 which was merged to 5FD_memtierd_devel.

/assign @askervin


juicefs crash when sync

What happened:
chengdeMacBook-Pro:scripts chengzhou$ ./juicefs sync --dirs /Users/chengzhou/Documents/juicefs2/pkg/ juicesync_dir/ --exclude ?
2022/08/17 16:00:47.516335 juicefs[58902] : Syncing from file:///Users/chengzhou/Documents/juicefs2/pkg/ to file:///Users/chengzhou/Documents/juicefs2/.github/scripts/juicesync_dir/ [sync.go:619]
panic: match [ with chunk: syntax error in pattern
goroutine 107 [running]:
github.com/juicedata/juicefs/pkg/sync.matchKey({0xc000121ab8, 0x1, 0x0}, {0xc00005a312, 0x0})
/Users/chengzhou/Documents/juicefs2/pkg/sync/sync.go:808 +0x365
github.com/juicedata/juicefs/pkg/sync.filter.func1()
/Users/chengzhou/Documents/juicefs2/pkg/sync/sync.go:766 +0xb8
created by github.com/juicedata/juicefs/pkg/sync.filter
/Users/chengzhou/Documents/juicefs2/pkg/sync/sync.go:761 +0xcf
What you expected to happen:
should not crash
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
Cloud provider or hardware configuration running JuiceFS:
OS (e.g cat /etc/os-release):
Kernel (e.g. uname -a):
Object storage (cloud provider and region, or self maintained):
Metadata engine info (version, cloud provider managed or self maintained):
Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
Others:

use ./juicefs sync --dirs /Users/chengzhou/Documents/juicefs2/pkg/ juicesync_dir/ --exclude \?
or ./juicefs sync --dirs /Users/chengzhou/Documents/juicefs2/pkg/ juicesync_dir/ --exclude '?'

It is not necessary to print stack information here.


Id as body param

Viem.sh adds a new param called id into body, but mock does not catch it.
https://github.com/httptoolkit/mockthereum/blob/7305bf991705b54421e66c3e4de94adbd8c3a02e/src/jsonrpc.ts#L12
Is there a way to extend this rules?

Hmm, I'm not sure what you mean - the matcher here should match requests that contain id - it's a flexible JSON match, meaning the request must include the fields specified, but can include extra fields too.
I think the issue is that the body here doesn't include params: [], which is supposed to be required. That might be a bug in Viem.sh, as every example I've seen (e.g. every method example listed on https://ethereum.org/en/developers/docs/apis/json-rpc/) does include this.
Do you know if there's any formal documentation that defines whether that's required?


Support parser inheritance

argparse supports setting a parser as a parent parser for another parser. The inheriting parser gets all arguments automatically from the parent parser.
We currently can't support this through simple inheritance since the @arcparser decorator transforms the shape object into a Parser instance which is an object and can't be subclassed.
There are 2 options how this could be implemented:

@arcparser decorator could accept a collection of parent parser shapes: @arcparser(ParentArgs1, ParentArgs2)
the resulting parser could be implemented as a new class and not an object. This would require a vast rewrite of the current parser code.

Nevermind, not wrapping the parent in @arcparser is enough.


Option to skip packaging externals

Hey,
I have these options in my SLS config:
package:
    exclude:
        - 'cache-manager'
        - 'class-transformer'
        - 'class-validator'
        - '@nestjs/microservices'
        - '@nestjs/websockets'
    individually: true
custom:
    esbuild:
        bundle: true
        minify: true
        keepNames: true
        sourcemap: true
        external:
            - 'cache-manager'
            - 'class-transformer'
            - 'class-validator'
            - '@nestjs/microservices'
            - '@nestjs/websockets'
        plugins: 'esbuild.plugins.js'

However, once it bundles, it runs this:
Packing external modules: cache-manager, class-transformer, class-validator, @nestjs/microservices, @nestjs/websockets

I want to completely skip it as these packages are opt-in in NestJS. Is there any way to achieve it? I see from the code that this plugin packages externals. Is there any way to completely skip them?

Hello @samrith-s
You can list modules in the external section to not include them in the final artifact.

The package specified in the exclude option is passed to esbuild as external, but it is not included in the function bundle either. The default value for this option is ['aws-sdk'].

Hey @vamche ,
Thanks for your response. Afaik, I am already doing that. All the packages are listed in custom.esbuild.external and package.exclude, yet it packages them.

@samrith-s I was talking about the serverless-esbuild config. Could you please list them in custom.esbuild.external and try?
   custom:
    esbuild:
        bundle: true
        minify: true
        keepNames: true
        sourcemap: true
        external:
            - 'cache-manager'
            - 'class-transformer'
            - 'class-validator'
            - '@nestjs/microservices'
            - '@nestjs/websockets'
        exclude:
            - 'cache-manager'
            - 'class-transformer'
            - 'class-validator'
            - '@nestjs/microservices'
            - '@nestjs/websockets'
        plugins: 'esbuild.plugins.js'

@samrith-s Did you get a chance to try with custom.esbuild.external?

Closing the issue since there is no activity anymore.


Aggregate published RG sets for OAI server

After digging into the OAI endpoint for Combine, it's becoming clear that it will likely make sense to aggregate all published RecordGroups to a single location.
This will allow:

detection of record dupes (by ID)
retrieval of a single record via GetRecord
much easier logic for resumption tokens
customized indexing in ES for this aggregate record group

Done - all but dupes, but will return to that in separate issue.


Moving powerbidedicated (1),purview (1),recoveryservices (7) resources to v1beta1 version

Description of your changes
Moving powerbidedicated (1) resources to v1beta1 version

[x] azurerm_powerbi_embedded

Moving purview (1) resources to v1beta1 version

[x] azurerm_purview_account

Moving recoveryservices (7) resources to v1beta1 version

[x] azurerm_backup_container_storage_account
[x] azurerm_backup_policy_file_share
[x] azurerm_backup_policy_vm
[x] azurerm_backup_protected_file_share
[x] azurerm_backup_protected_vm
[x] azurerm_recovery_services_vault
[x] azurerm_site_recovery_fabric

Fixes https://github.com/upbound/provider-azure/issues/168
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manually:
azurerm_powerbi_embedded - This resource needs valid administrator email

azurerm_backup_protected_vm - This resource needs sourceVmId - ID for Virtual Machine

Uptests:

[x] azurerm_purview_account - https://github.com/upbound/provider-azure/actions/runs/3960591800/jobs/6784955447
[x] azurerm_backup_container_storage_account
[x] azurerm_backup_policy_file_share
[x] azurerm_backup_policy_vm
[x] azurerm_backup_protected_file_share
[x] azurerm_recovery_services_vault
[x] azurerm_site_recovery_fabric

/test-examples="examples/purview/account.yaml"

/test-examples="examples/purview/account.yaml"

/test-examples="examples/recoveryservices/backupcontainerstorageaccount.yaml"

/test-examples="examples/recoveryservices/backuppolicyvm.yaml"

/test-examples="examples/recoveryservices/backupprotectedfileshare.yaml"

/test-examples="examples/recoveryservices/siterecoveryfabric.yaml"

/test-examples="examples/recoveryservices/vault.yaml"

/test-examples="examples/recoveryservices/backuppolicyfileshare.yaml"

/test-examples="examples/recoveryservices/backupcontainerstorageaccount.yaml"


Open viewer at specific URL (study) when hosting static files on Tomcat

I have deployed OHIF static files on Tomcat inside webapps/ohif folder. I changed PUBLIC_URL and routerBasename to /ohif/ to match the URL and Everything is working fine.
The only problem is that when i try to open specific OHIF URLs (for example a study), Tomcat returns 404. However, when i run OHIF locally, i can open specific URLs. For example:
http://<IP_ADDRESS>:17000/ohif/ -> Works fine
http://<IP_ADDRESS>:17000/ohif/viewer/1.2.392.200036.9<IP_ADDRESS>.1762671362.1578986208.521930 -> 404 from Tomcat
Is that something related to Tomcat?

hi,
i have shared a details video link in below where to guide how to setup a static viewer of ohif on custom domain or any domain
https://www.youtube.com/watch?v=tvA2jdBLLtc


udp connectivity failure detection no longer working

Following the switch of topology communication to gossip, the udp connectivity failure detection is no longer working.
Previously, a tcp connection would not see regular communication until it had been marked as 'established', because in the topology communication scheme would periodically send 'FetchAll' only after that. So in the absence of udp connectivity we'd time out. The timeout could of course occur for other reasons, namely disrupted tcp connectivity, but the combination of a timeout and 'not established' points at lack of udp connectivity as a likely cause.
In the new gossip-based topology communication, however, gossip (of anything, not just topology) occurs as soon as we have tcp connectivity. Therefore we will no longer encounter a timeout when just udp connectivity is disrupted. Which makes our test invalid.

One possible fix is to introduce one-shot timer, created on handshake, which when it fires checks whether the connection has been marked as 'established' and logs a warning about lack of connectivity otherwise. Or it could even tear down the connection, if we want to replicate the previous behaviour more closely. The latter may be important...
It is possible that udp connectivity works when the connection is initiated by A to B, but not vice versa. Consider the case of a firewall in front of B that has been configured to allow all outbound udp, and inbound udp on the weave port but is lacking udp 'connection' tracking.
Previously, the tearing down of connections on udp connectivity failure, combined with our reconnection logic, would ensure that in such a situation we'd eventually initiate the connection in the other direction.


v0.0.35

Codecov Report
Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (338fb06) to head (12b472f).

Files with missing lines
Patch %
Lines

client/src/auth.ts
71.42%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   83.25%   83.20%   -0.05%
==========================================
  Files           3        3
  Lines         400      399       -1
  Branches       70       70
==========================================
- Hits          333      332       -1
  Misses         67       67

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.