How to attach additional volume to VM?

I can create VM and volume but cant find resource to attach additional volume to VM
resource "hyperstack_core_volume" "volume" {
  name             = var.vm_config.name
  description      = var.vm_config.name
  environment_name = var.vm_config.environment_name
  size             = var.vm_config.volume_size
  volume_type      = "Cloud-SSD"
}

resource "hyperstack_core_virtual_machine" "virtual_machine" {
  name               = var.vm_config.name
  environment_name   = var.vm_config.environment_name
  flavor_name        = var.vm_config.flavor_name
  key_name           = "devops"
  assign_floating_ip = true
  user_data          = ""
  image_name         = "Ubuntu Server 22.04 LTS R535 CUDA 12.2 with Docker"
}

I've just reached the same point. I need to attach a freshly created volume to the VM but there is no resource for that nor attribute on the VM itself.

Hi @vladimirpodr @szczad,
The provider is automatically generated from OpenAPI spec generator, and it seems like there are no resource for attaching volume to the virtual_machine in the provider code at the moment. Let us work on fixing this.


Frontend/feature/profile route

Separate profile route (view and edit your own profile) from user route (view other users profile)
This is a follow up for #1200 and simplifies our code on some places.
Closes #1272

Frontend checklist

[x] Formatted my code with yarn format && yarn lint --fix
[x] There are no warnings from yarn lint
[x] There are no console warnings when running the app
[x] Added any new components to storybook
[x] Added tests where relevant
[x] All tests pass
[x] Clicked around my changes running locally and it works
[x] Checked Desktop, Mobile and Tablet screen sizes

When I currently go to another user's profile, the "Profile" tab is highlighted as active. I think that bug is related to this PR.

When I currently go to another user's profile, the "Profile" tab is highlighted as active. I think that bug is related to this PR.

Ah yes, I can fix that with this issue

Also the renames that had to be done here has broken the EditProfilePage tests and broken CI. Do you mind fixing that as well please? 😬  Hopefully should just be updating the variable that test file is referencing...

Nice, thanks for fixing the references stuff as well 🎉

Hope you don't mind if I merge this!


tarpc-lib build errors

Hello,
I've tried building from the git repo for with various recent nightlies and I keep getting build errors. Even when I used the same one as the last CI build that succeeded.
rustc 1.31.0-nightly (4bd4e4130 2018-10-25)]
tarpc = { git = "https://github.com/google/tarpc", features = ["serde1"] }
error[E0310]: the parameter type `C` may not live long enough
   --> /home/greg/.cargo/registry/src/github.com-1ecc6299db9ec823/tarpc-lib-0.1.0/src/client/dispatch.rs:211:1
    |
211 | / {
212 | |     let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer);
213 | |     let (cancellation, canceled_requests) = cancellations();
214 | |
...   |
239 | |     })
240 | | }
    | |_^
    |
    = help: consider adding an explicit lifetime bound `C: 'static`...

error[E0310]: the parameter type `Resp` may not live long enough
   --> /home/greg/.cargo/registry/src/github.com-1ecc6299db9ec823/tarpc-lib-0.1.0/src/client/dispatch.rs:211:1
    |
211 | / {
212 | |     let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer);
213 | |     let (cancellation, canceled_requests) = cancellations();
214 | |
...   |
239 | |     })
240 | | }
    | |_^
    |
    = help: consider adding an explicit lifetime bound `Resp: 'static`...

error[E0310]: the parameter type `Req` may not live long enough
   --> /home/greg/.cargo/registry/src/github.com-1ecc6299db9ec823/tarpc-lib-0.1.0/src/client/dispatch.rs:211:1
    |
211 | / {
212 | |     let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer);
213 | |     let (cancellation, canceled_requests) = cancellations();
214 | |
...   |
239 | |     })
240 | | }
    | |_^
    |
    = help: consider adding an explicit lifetime bound `Req: 'static`...

Clearly these build errors want us to add explicit lifetimes.
I can try adding lifetimes and creating a PR tomorrow, but I'm confused as to why my build fails while Travis CI's succeeds.

It looks like you're on an older version of tarpc, because dispatch.rs was renamed channel.rs. can you try running cargo update && cargo build?

Hmm. Yes, I tried that. I just tried it again. Changing it from git = "https://github.com/google/tarpc" to git = "https://github.com/google/tarpc.git" gave me this:
$ cargo update && cargo build
    Updating crates.io index
    Updating git repository `https://github.com/google/tarpc.git`
    Removing tarpc v0.13.0 (https://github.com/google/tarpc#e2c4164d)
      Adding tarpc v0.13.0 (https://github.com/google/tarpc.git#e2c4164d)
    Removing tarpc-lib v0.1.0 (https://github.com/google/tarpc#e2c4164d)
      Adding tarpc-lib v0.1.0 (https://github.com/google/tarpc.git#e2c4164d)
    Removing tarpc-plugins v0.5.0 (https://github.com/google/tarpc#e2c4164d)
      Adding tarpc-plugins v0.5.0 (https://github.com/google/tarpc.git#e2c4164d)
    Removing tarpc-trace v0.1.0 (https://github.com/google/tarpc#e2c4164d)
      Adding tarpc-trace v0.1.0 (https://github.com/google/tarpc.git#e2c4164d)
   Compiling tarpc-lib v0.1.0
   Compiling tarpc v0.13.0 (https://github.com/google/tarpc.git#e2c4164d)
error[E0310]: the parameter type `C` may not live long enough
   --> /home/greg/.cargo/registry/src/github.com-1ecc6299db9ec823/tarpc-lib-0.1.0/src/client/dispatch.rs:211:1
    |
211 | / {
212 | |     let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer);
213 | |     let (cancellation, canceled_requests) = cancellations();
214 | |
...   |
239 | |     })
240 | | }
    | |_^
    |
    = help: consider adding an explicit lifetime bound `C: 'static`...

error[E0310]: the parameter type `Resp` may not live long enough
   --> /home/greg/.cargo/registry/src/github.com-1ecc6299db9ec823/tarpc-lib-0.1.0/src/client/dispatch.rs:211:1
    |
211 | / {
212 | |     let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer);
213 | |     let (cancellation, canceled_requests) = cancellations();
214 | |
...   |
239 | |     })
240 | | }
    | |_^
    |
    = help: consider adding an explicit lifetime bound `Resp: 'static`...

error[E0310]: the parameter type `Req` may not live long enough
   --> /home/greg/.cargo/registry/src/github.com-1ecc6299db9ec823/tarpc-lib-0.1.0/src/client/dispatch.rs:211:1
    |
211 | / {
212 | |     let (to_dispatch, pending_requests) = mpsc::channel(config.pending_request_buffer);
213 | |     let (cancellation, canceled_requests) = cancellations();
214 | |
...   |
239 | |     })
240 | | }
    | |_^
    |
    = help: consider adding an explicit lifetime bound `Req: 'static`...

It seems like it's compiling the latest git commit, since they have the same hash e2c4164d.

I just noticed that the example-service uses bincode-transport version = 0.2, but mine is at 0.1. Changing it to 0.2 fixes the problem. Thanks!


REPORT! - Visual Inaccuracies

My findings of playing Resident Evil 4 HD Project v1.0.
Not all inaccuracies are important, just reporting as an additional pair of eyes.
I did not start taking screenshots until Chapter 3-2.
If this is helpful, I'll replay the beginning as well as take note on other game modes.
I'll respond to questions and requests for clarification as soon as I am able.
Some stretching of the circular tiles above Leon in the first Novistador tunnel/the sewers.

Notes commonly state "the Las Plagas" or "the Los Illuminados" which is redundant (the/las/los being the same word). Voiced characters don't usually state it this way iirc.

Toilet model does not have drainage or plumbing. Also, too big.

After draining the water, it is apparent there is nowhere for the water to actually go. There's (I believe) a Velvet Blue in the grating here. Removing the back wall into a black abyss would solve the issue.

Window texture is stretched. Over the rail to the left past the fountain of crows.

Inaccessible room to the right before locked room where Leon encounters Ada for the first time. This room has no windows (save for this) and no doors which leaves the castle dwellers with the chilling challenge of finding a way out! (Haunted Mansion laugh). Adding a door would solve this, but also not a big deal.

Skybox in the area with the dog maze is too bright, particularly compared to the other night skies.

All quotation marks in notes are using right quotes for the end of a word without left quotes for the beginning. If making two quotes is difficult with the text table, using vertical quotes like " is also fine.

Normals are too aggressive on gold bars.

Texture stretching on the fallen sand.

Typewriter appears to be floating but isn't. I think it's a misalignment of the baked shadow underneath.

While there is a ledge, here is nowhere for the cultists to actually enter the room (Garrador cage) or drop down from. Adding a door or a simple hole in the ceiling like in other areas would fix this.

Model stretching in the glass case with the free RPG.

The door left of the foyer (requiring the three emblems) of the castle has inverted text, likely as a result of being mirrored. Not a big deal but I had a hard time reading it backwards!

I believe this was already mentioned at one point but the floors after the first rail cart are too aggressively reflective.

Multiple misaligned paintings in the hallways during the Grail segment.

Broken Butterfly shaders are too aggressive and reads as black or white instead of a silvery gray.

Since we're talking about it, the Mine Thrower textures are too uniform and aggressive. The model is too boxy, particularly around the detachable portion that holds the mines and the curvature of the frame for the arm in the back. Might be a matter of personal taste and difficult to remedy with polygon limits and since it's a fake gun design in the first place.

The Merchant hasn't had glowing eyes during the whole game so far. If I recall correctly, he's supposed to have them as soon as night falls. (Playing further, he does have them the first time you see him on the Island but only then (so far).

Another issue I've heard about, Leon's shotgun clips through his arm. Sometimes a shell also pops out of his hands while reloading (60 fps) but I've had difficulty capturing it in a screenshot. Can send a video if needed.

In the left side passage when fighting the two Garradors after the clocktower, the candelabra closer to the entrance is aligned uncomfortably close to the wall while the one opposite is not. The first is good, the second is less good.

This texture behind the grating looks too flat and doesn't match the quality of the rest of the mod pack. I don't really have a solution for this one but I only bring it up because it is common throughout the Verdugo fight.

Saddler's hands clip through the arms of his throne in the custcene introducing Krauser.

In menus, Hand Grenades have a white shader around the top before the metallic portion by the pin. This is good, but the Incendiary and Flash Grenades do not. The text is aligned differently and the lines on the bottom are also exclusive to the Hand Grenade. I haven't yet checked if this is consistent with their view models.

This is more in-game behavior and I'm not sure if it's a bug, but this Chainsaw Ganado never will come down either via the ladder nor the door making this encounter awkward, especially since, iirc, the door beneath him can be opened without unlocking it.
(Side Note: There was pathing issues for Ashley WAAAY back fighting the Bella Sisters. This is also the map with the bonus room enterance so I imagine something happened there.)

This elevator leading up to the final encounter with Salazar has you pushing crates off before it will work. At least  one of the crates will fall through this wooden walkway while also not allowing Leon to walk on it. It may be better to have nothing there at all.

On the Island after climbing up the ladder just before the room with the Golden Lynx, to the left is an invisible wall and couldn't walk further than pictured. Adding more crates or adjusting collision will solve this issue.

I always thought these bodies were wrapped in plastic bags or something but never sure. Here it looks kind of like a stone texture? I'm not really sure.

Some of the arms of corpses are clipping through tarps and blankets in the room where you receive the Infrared Scope. This looks more awkward in HD. Not sure how to address this one.

Leon comments that they're growing things in these petri dishes but they are empty.

That's all for now.

Some good reports here, have you posted them on re4hd.com as well? I'm not really sure if albert is checking the re4_tweaks github issues that much.
(wonder if maybe making a separate github for re4hd-related issues might be a good idea, githubs issue system would be better than handling them in comments threads... I guess that's up to albert if he wants to do that though)

Ah, will do. I've seen Albert linking this github over for reports like this so I thought it the thing to do. I'll link it there as well. If there's a cleaner or preferred method of reporting in the future, please let me know. Thanks!

This is an odd spot. There's a machine behind the fencing that is jittering so hard I thought it was a bug but seems to be just engine rumble. Maybe tone it down? The adjacent fencing has a light texture that obscures the other side.

I have never really used the Mine Thrower until this run and certainly never used the scope so I can understand how this was overlooked. It looks like the text elements are still the original SD textures. It doesn't look like real text, though and doesn't seem to indicate actual useful information. Would probably be fine if they were gone entirely or else some kind of new verbiage is required.

When 'it'/U3 attacks Leon, there seems to be a lot of breakage of rock. When Leon (optionally) returns via the lift, there's no breakage or rubble. Maybe add a few stones here and there, maybe a missing bit of cliff?

The most minor of minor inaccuracies, after defeating Krauser and escaping, if you turn around and return to the arena after the explosion, the tower will be missing and there's this barely noticeable texture stretching. More noticeable on higher FOVs. The first is default, the second is max.

Leon doesn't hold onto ziplines with his index fingers.

General performance or technical issues:

Krauser and Ada cutscene at the radio tower. Ada has a visible seem on her mouth in one shot. (Failed to get a screenshot.)
Some audio stutter when hitting the final button to drop the cage in the U3 fight.
Some radio dialogue subtitles are cut off early, particularly Leon's "A senior moment perhaps."
Upon entering Krauser's arena, fps dropped between 45-55 while looking toward the center of the area.

Text inaccuracies:
"Saddler you..." --> "Saddler, you bastard!" (probably weird censorship)
"Stranger. Stranger, Now that's a weapon." --> Stranger, Stranger... Now that's a weapon!"
"Not enough cash." --> "Not enough cash, Stranger."

Ah, I must have misunderstood. I suppose he was deferring issues related to programming or outside his expertise here rather than all issues be reported here. Apologies. Thank you for allowing me to keep posting here, though! I hope Albert finds it useful in some capacity. I enjoy playtesting and bug hunting.


[5.7] Fix pagination slider when it's too close to the end

Make the number of pages that are shown close to the end, equal to
the number of pages that are shown close to the beginning.

As you can see before the fix when current page is close to the end, the pagination shows 9 pages close the end, but when the current page is close to the beginning, it shows only 8 pages close to the beginning.
I thought it should be symmetric.

No plans to change on a point release.


YouTube playlist disparity

When entering a YouTube playlist link in the control panel the correct video is shown, however, the front-end output is always the first video. Is there a difference with how these are rendered?

It seems that any parameters other than the video id are ignored.

Embedding a YouTube playlist does seem to default to the first video in the playlist, which is consistent with the embed code you'd get directly from the YouTube playlist page, but embedding a specific video from the playlist seems to correctly show that video on both the control panel and front-end. There definitely shouldn't be any difference in how the embed is rendered in the control panel and front-end unless embedded asset methods like getIframeCode() are being used in your templates to add parameters; admittedly I can't be sure how things were behaving back when this issue was opened, but if there were any issues with Embedded Assets / Embed / YouTube that were causing inconsistencies at that time, they appear to be resolved now.


Error in the last 2 steps

Description of the bug
Please help. While running the pipeline, there was an error on the second to last step of it
I have since gone into the conda environment in which R was installed and updated it, but all that did was get rid of the first four lines of the message:
 Warning message:
  package ‘optparse’ was built under R version 4.0.5
  Warning message:
  package ‘scales’ was built under R version 4.0.5

Command used and terminal output
nextflow run nf-core/viralrecon --input samplesheet.csv --outdir results/viralrecon --protocol amplicon --genome MN908947.3 --primer_set artic --primer_set_version 3 --platform illumina --skip_assembly --max_cpus 8 --max_memory 13.GB -profile conda

Warning message:
  package ‘optparse’ was built under R version 4.0.5
  Warning message:
  package ‘scales’ was built under R version 4.0.5
  Loading required package: grid
  Error: package or namespace load failed for ‘ComplexHeatmap’:
   .onLoad failed in loadNamespace() for 'Cairo', details:
    call: dyn.load(file, DLLpath = DLLpath, ...)
    error: unable to load shared object '/home/yelbur/Desktop/03-consensus/uk_illumina/work/conda/env-05a634cd6ec064941b9d92badb58aa6c/lib/R/library/Cairo/libs/Cairo.so':
    libicuuc.so.70: cannot open shared object file: No such file or directory
  Execution halted

Relevant files
No response
System information
I'm on ubuntu with conda 4.13.0

Hi @Yelbur ! Did you manage to fix this issue? It looks like your Conda environment is trying to load libraries that may or may not be pre-installed on your system and is failing. Using Conda is susceptible to these sorts of issues and isn't reproducible either. I would recommend using Docker / Singularity if possible. Is this an option for you?
The error appears to be unrelated to the pipeline itself so I will close for now. Please feel free to join the #viralrecon channel on the nf-core Slack where you can get real-time help from the community.

Sorry to reopen a closed issue.  I believe it can be fixed by updating the package version used for conda from conda-forge::r-base=4.0.3 to conda-forge::r-base=4.0.5.


Fix plumbing of 2020-resolver to Pip.

Previously this was not working for Python 2.7.
Fixes #1179

@butlern this fix has an integration test drawn straight from your example. Thanks again for digging on this.

@butlern this fix has an integration test drawn straight from your example. Thanks again for digging on this.

💯 Thanks for the quick turnaround!

💯 Thanks for the quick turnaround!


[Bug] echarts.init opt set height 100%, result show 100px not full height

Version
5.5.1
Link to Minimal Reproduction
https://codepen.io/Ovilia/pen/dyYWXWM
Steps to Reproduce
`
const props = withDefaults(defineProps(), {
height: () => '100%',
...
lineChart.value = ECharts.init(lineRef.value, null, {
height: '100%'
})
...

`
![image](https://github.com/user-attachments/assets/49bb64ac-c467-449a-8a32-dc45b64b939c)
comment height,

Current Behavior

Expected Behavior

Environment
- OS:
- Browser:
- Framework:

Any additional comments?
No response

The grid component has default values for top, bottom, left and right.

Encountered the same issue when I was using react I had to delay the render or re-render the graph to actually take on the parent size.

The grid component has default values for top, bottom, left and right.

You can adjust the grid top/left/bottom/right as needed. For example,
grid: {
  top: 6,
  bottom: 0,
  right: 0,
  left: 0,
  containLabel: true
}

Encountered the same issue when I was using react I had to delay the render or re-render the graph to actually take on the parent size.

@SeanErvinson You must ensure the container has real width and height before rendering the chart. If you try to render the chart when the container is not visible, the chart may fail to get the size. There should be a warning like Can't get DOM width or height in the development environment.


Remove global average pooling out of "forward_head"

Great job on your work! I have a small suggestion regarding the code in inceptionnext.py. It would be more convenient if the line "x = x.mean((2, 3)) # global average pooling" was moved from the "self.forward_head" function to the end of the "self.forward_features" function. This way, we can directly command the line "x = self.forward_head(x)" when we have our own classification layer, without needing to keep the "MlpHead" class and command the lines after "x = x.mean((2, 3)) # global average pooling". The current setup is a little inconvenient.

Hi @abcsimple ,
Thanks for your suggestion. This repo is based on timm, and timm also merges the global average pooling into the classifier, see timm's classifier.py. The current implementation may help it to match the code style of timm.


how can I visualize the data

Hello, how can I visualize the data, such as painting PR curves, etc.

After getting the detection results of the val set, you can plot whatever curve you want.

@Charcy-yang  I just created the visualization program, you can check it
Stephenfang51/mmdetection_visualize

获得val集的检测结果后，您可以绘制所需的任何曲线。

Thanks.

@Charcy-yang 我刚创建了可视化程序，你可以查一下
Stephenfang51 / mmdetection_visualize

Thanks


🐛 Bug Report: SonarQube plugin fails on config check

📜 Description
When using the following config in the app config file the app runs as expected but when we run the 'yarn backstage-cli config:check --config app-config.yaml --lax --strict' it errors out says the config is not right.
sonarQube:
  baseUrl: https://xyz.com
  apiKey: <SONAR_TOKEN>

Error:
Error: Configuration does not match schema
Config must NOT have additional properties { additionalProperty=apiKey } at /sonarQube
👍 Expected behavior
It shouldn't error out on the following config when the config check runs
sonarQube:
  baseUrl: https://xyz.com
  apiKey: <SONAR_TOKEN>

👎 Actual Behavior with Screenshots
It actually looks at the config of the sonar plugin frontend: https://github.com/backstage/backstage/blob/master/plugins/sonarqube/config.d.ts and not the backend config: https://github.com/backstage/backstage/blob/master/plugins/sonarqube-backend/config.d.ts.
👟 Reproduction steps

Install Sonar frontend and backend plugins.
Add the config to the app config.
Run 'yarn backstage-cli config:check --config app-config.yaml --lax --strict'

📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

@Ritesh007 and I chatted briefly on this. I wonder if the fix is to REMOVE the configuration schema entirely from the frontend plugin, which uses it to generate APIs to SonarQube, and leave it only in the backend plugin with the @visibility frontend directive?  i feel like the --strict check may just be picking it up from the frontend w/o doesn't use the apiKey, hence the error.
thoughts?

The issue is that the SonarQube backend plugin config isn't properly included in the package. That was fixed in #17850 and will be released into main-line next week. Closing as fixed.


[Bug] accepted filetypes audio on iPhone doesn't work

Is there an existing issue for this?

[X] I have searched the existing issues

Have you updated FilePond and its plugins?

[X] I have updated FilePond and its plugins

Describe the bug
If using the plugin FilePondPluginFileValidateType on an iPhone the file browser in iPhone only displays movie files.
acceptedFileTypes: ['audio/*']
When used on Chrome macOS it displays the test m4a file correctly.
But on iOS Safari the file is grayed out and the only selectable files are movie-files. But when selecting them you get the wrong filetype error from Filepond.
Reproduction
`import "filepond/dist/filepond.min.css";
import FilePondPluginFileValidateType from "filepond-plugin-file-validate-type";
import { create, registerPlugin } from "filepond";
registerPlugin(FilePondPluginFileValidateType);
const inputElement = document.querySelector('input[type="file"]');
create(inputElement, {
acceptedFileTypes: ["audio/*"]
});`
https://codesandbox.io/s/thirsty-tristan-47ctw2?file=/src/index.js
Environment
- Device: iPhone
- OS: iOS 16.6
- Browser: Safari

A work around was adding acceptedFileTypes: ["audio/*","audio/x-m4a"]
Now it works for both iOS and macOS. But it feels like the asterix should handle the m4a.
https://codepen.io/rikschennink/pen/NzRvbj gave me the iOS mime type.

Glad to hear it's resolved, this is a problem with the input element itself and the OS, not with FilePond so I'll close the issue for now.


Module not Loading

First off, I'd like to thank you @mykle1 for all your space modules for MM.  My kid loves space and he is thrilled that he is going to have his own "space dashboard".
I'm using just about all of your modules, ISS-Live and ISS are working but none of the others.  I don't know if you are still active with any of this but I figured I'd drop an issue report.  It seems like "Astronauts" "Launches" "NASA" "NEO" are all behaving the same.  Nothing loads except the innerHTML from the 'if' statement to check if the module loaded.  It appears all the API feeds they are pulling from are still working.  I'll update if I'm able to figure anything out and resolve them.

I just downloaded and tested each of the modules you mentioned. They are all working with the exception of MMM-Launch. Actually, MMM-Launch is working but it takes about 45 seconds to respond, then it performs as expected.
I'd much rather troubleshoot this on the forum, if you don't mind. Lets do one at a time. I'm sure it's something simple. What I suggest you try first is delete them from your modules folder and reclone them. Using the config entry from each module would also be a good idea.  If not, post a topic on the forum and I'll get you sorted

Sounds good, I'll open a thread on the forum and then I'll clean all the modules out tonight when I get home and load 1 to start.  It's actually happening on the Jeopardy module too so whatever it is I'm sure it's simple and will fix all of them.
Thanks!


[patch] Return object from calls to load()

Change Description:
Aligns return value for load with that used in production (i.e., return the object).

Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)

No.

Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)

No.
If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed:
Wrote a test. Tested manually

@millerds looks like you're the most active merging PRs. This is a tiny change, but brings the mocks into better alignment with the real API. Hopefully it's an easy review, but let me know if anything's unclear. :octocat:

/azurepipelines run

Thanks for your contribution!


[ANCHOR-375] Create wallet reference server and client status callback e2e tests

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What

Create wallet reference server
Create the wallet reference server client classes
Implement status callback signature validation
Create client status callback e2e tests

Why
For client status callback e2e test

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr1025.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr1025.previews.kube001.services.stellar-ops.com/


Failed assertion: line 26: ''

Steps to Reproduce

  Widget buildBody(BuildContext context) {
    final listView = Flexible(
      child: RefreshIndicator(
        key: _refreshIndicatorKey,
        onRefresh: reloadData,
        child: Scrollbar(
          child: ListView.builder(
            scrollDirection: Axis.vertical,
            shrinkWrap: true,
            itemCount: list.length,
            itemBuilder: (context, index) {
              if (index == list.length - 1 && !isLoading && !endReached) {
                SchedulerBinding.instance.addPostFrameCallback((_) {
                  print('reloading - last element reached: $index');
                  loadData();
                });
              }
              var w = listBuilder(context, index);
              if (widget.canEditItems)
                w = GestureDetector(
                  child: w,
                  onTap: () => editItem(index),
                );
              return w;
            },
          ),
        ),
      ),
    );

    final header = buildHeader();
    var widgetTree = <Widget>[listView];
    if (header != null) widgetTree.insert(0, header);
    widgetTree = <Widget>[
      Column(
        children: widgetTree,
      )
    ];

    if (isLoading)
      widgetTree.add(Stack(
        children: [
          new Opacity(
            opacity: 0.3,
            child: const ModalBarrier(dismissible: false, color: Colors.grey),
          ),
          new Center(
            child: new CircularProgressIndicator(),
          ),
        ],
      ));
    return new Stack(children: widgetTree);
  }

Logs
Launching lib\main.dart on LGM G600L in debug mode...
Initializing gradle...
Resolving dependencies...
Running Gradle task 'assembleDebug'...
Built build\app\outputs\apk\debug\app-debug.apk.
Installing build\app\outputs\apk\app.apk...
Syncing files to device LGM G600L...
I/flutter (25002): UserData
I/flutter (25002): {"_id":null,"count":12}
I/flutter (25002): [{"_id":"5d00b5fb1b61d305a92234c5","status":"Opportunity","serialNumber":19,"date":"2019-06-12T08:21:15.807Z","salesperson":"Dwight Schrute"},{"_id":"5cbde86198edd338c2faa5cc","status":"Opportunity","serialNumber":17,"date":"2019-04-22T16:14:25.152Z","property":{"_id":"584efea5fc6ad00d29de5152","name":"Shops at Dakota Crossing"},"client":{"_id":"584efe61fc6ad00d29de514f","name":"CBRE Washington DC"},"salesperson":"Dwight Schrute"},{"_id":"5cbdd2db98edd338c2faa5ac","status":"Opportunity","serialNumber":16,"date":"2019-04-22T14:42:35.680Z","source":"This","dueDate":"2019-04-16T04:00:00.000Z","property":{"_id":"5c768b8efbf9410db664a54d","name":"Scranton Branch"},"client":{"_id":"5c26282a0017651e7fefa963","name":"Dunder Mifflin"},"salesperson":"Paul Test"},{"_id":"5cbdd2c598edd338c2faa5a0","status":"Opportunity","serialNumber":15,"date":"2019-04-22T14:42:13.016Z","salesperson":"Dwight Schrute"},{"_id":"5cacae9e6ce2222e0962ced4","status":"Opportunity","serialNumber":14,"date":"2019-04-09T14:39:26.510Z","property"
I/ViewRootImpl(25002): ViewRoot's Touch Event : ACTION_DOWN
I/ViewRootImpl(25002): ViewRoot's Touch Event : ACTION_UP
I/flutter (25002): {"_id":null,"count":12}
I/flutter (25002): [{"_id":"5d00b5fb1b61d305a92234c5","status":"Opportunity","serialNumber":19,"date":"2019-06-12T08:21:15.807Z","salesperson":"Dwight Schrute"},{"_id":"5cbde86198edd338c2faa5cc","status":"Opportunity","serialNumber":17,"date":"2019-04-22T16:14:25.152Z","property":{"_id":"584efea5fc6ad00d29de5152","name":"Shops at Dakota Crossing"},"client":{"_id":"584efe61fc6ad00d29de514f","name":"CBRE Washington DC"},"salesperson":"Dwight Schrute"},{"_id":"5cbdd2db98edd338c2faa5ac","status":"Opportunity","serialNumber":16,"date":"2019-04-22T14:42:35.680Z","source":"This","dueDate":"2019-04-16T04:00:00.000Z","property":{"_id":"5c768b8efbf9410db664a54d","name":"Scranton Branch"},"client":{"_id":"5c26282a0017651e7fefa963","name":"Dunder Mifflin"},"salesperson":"Paul Test"},{"_id":"5cbdd2c598edd338c2faa5a0","status":"Opportunity","serialNumber":15,"date":"2019-04-22T14:42:13.016Z","salesperson":"Dwight Schrute"},{"_id":"5cacae9e6ce2222e0962ced4","status":"Opportunity","serialNumber":14,"date":"2019-04-09T14:39:26.510Z","property"
I/ViewRootImpl(25002): ViewRoot's Touch Event : ACTION_DOWN
I/zygote64(25002): Do partial code cache collection, code=27KB, data=25KB
I/zygote64(25002): After code cache collection, code=27KB, data=25KB
I/zygote64(25002): Increasing code cache capacity to 128KB
I/ViewRootImpl(25002): ViewRoot's Touch Event : ACTION_UP
I/flutter (25002): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter (25002): The following assertion was thrown during paint():
I/flutter (25002): Rect argument contained a NaN value.
I/flutter (25002): 'dart:ui/painting.dart': Failed assertion: line 26: '<optimized out>'
I/flutter (25002):
I/flutter (25002): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter (25002): more information in this error message to help you determine and fix the underlying cause.
I/flutter (25002): In either case, please report this assertion by filing a bug on GitHub:
I/flutter (25002):   https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter (25002):
I/flutter (25002): When the exception was thrown, this was the stack:
I/flutter (25002): #2      _rectIsValid (dart:ui/painting.dart:26:10)
I/flutter (25002): #3      Canvas.drawRect (dart:ui/painting.dart:3322:12)
I/flutter (25002): #4      ScrollbarPainter._paintVerticalThumb (package:flutter/src/widgets/scrollbar.dart:135:14)
I/flutter (25002): #5      ScrollbarPainter._paintThumb (package:flutter/src/widgets/scrollbar.dart:201:12)
I/flutter (25002): #6      ScrollbarPainter.paint (package:flutter/src/widgets/scrollbar.dart:218:9)
I/flutter (25002): #7      RenderCustomPaint._paintWithPainter (package:flutter/src/rendering/custom_paint.dart:523:13)
I/flutter (25002): #8      RenderCustomPaint.paint (package:flutter/src/rendering/custom_paint.dart:566:7)
I/flutter (25002): #9      RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2104:7)
I/flutter (25002): #10     PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (25002): #11     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:123:15)
I/flutter (25002): #12     RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2104:7)
I/flutter (25002): #13     PaintingContext._repaintCompositedChild (package:flutter/src/rendering/object.dart:128:11)
I/flutter (25002): #14     PaintingContext.repaintCompositedChild (package:flutter/src/rendering/object.dart:96:5)
I/flutter (25002): #15     PipelineOwner.flushPaint (package:flutter/src/rendering/object.dart:859:29)
I/flutter (25002): #16     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:349:19)
I/flutter (25002): #17     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:701:13)
I/flutter (25002): #18     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:286:5)
I/flutter (25002): #19     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1012:15)
I/flutter (25002): #20     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:952:9)
I/flutter (25002): #21     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:864:5)
I/flutter (25002): #25     _invoke (dart:ui/hooks.dart:219:10)
I/flutter (25002): #26     _drawFrame (dart:ui/hooks.dart:178:3)
I/flutter (25002): (elided 5 frames from class _AssertionError and package dart:async)
I/flutter (25002):
I/flutter (25002): The following RenderObject was being processed when the exception was fired:
I/flutter (25002):   RenderCustomPaint#5cfed relayoutBoundary=up5
I/flutter (25002):   creator: CustomPaint ← RepaintBoundary ← NotificationListener<ScrollNotification> ← Scrollbar ←
I/flutter (25002):   NotificationListener<OverscrollIndicatorNotification> ←
I/flutter (25002):   NotificationListener<ScrollNotification>-[GlobalKey#8f3db] ← Stack ←
I/flutter (25002):   RefreshIndicator-[LabeledGlobalKey<RefreshIndicatorState>#3c40e] ← Flexible ← Column ← Stack ←
I/flutter (25002):   MediaQuery ← ⋯
I/flutter (25002):   parentData: <none> (can use size)
I/flutter (25002):   constraints: BoxConstraints(0.0<=w<=360.0, 0.0<=h<=495.0)
I/flutter (25002):   size: Size(360.0, 0.0)
I/flutter (25002): This RenderObject had the following descendants (showing up to depth 5):
I/flutter (25002):   RenderRepaintBoundary#316c3 relayoutBoundary=up6
I/flutter (25002):     RenderRepaintBoundary#a03a8 relayoutBoundary=up7
I/flutter (25002):       RenderCustomPaint#dd408 relayoutBoundary=up8
I/flutter (25002):         RenderRepaintBoundary#27471 relayoutBoundary=up9
I/flutter (25002):           _RenderScrollSemantics#b5007 relayoutBoundary=up10
I/flutter (25002): ════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter (25002): {"_id":null,"count":12}
I/flutter (25002): [{"_id":"5d00b5fb1b61d305a92234c5","status":"Opportunity","serialNumber":19,"date":"2019-06-12T08:21:15.807Z","salesperson":"Dwight Schrute"},{"_id":"5cbde86198edd338c2faa5cc","status":"Opportunity","serialNumber":17,"date":"2019-04-22T16:14:25.152Z","property":{"_id":"584efea5fc6ad00d29de5152","name":"Shops at Dakota Crossing"},"client":{"_id":"584efe61fc6ad00d29de514f","name":"CBRE Washington DC"},"salesperson":"Dwight Schrute"},{"_id":"5cbdd2db98edd338c2faa5ac","status":"Opportunity","serialNumber":16,"date":"2019-04-22T14:42:35.680Z","source":"This","dueDate":"2019-04-16T04:00:00.000Z","property":{"_id":"5c768b8efbf9410db664a54d","name":"Scranton Branch"},"client":{"_id":"5c26282a0017651e7fefa963","name":"Dunder Mifflin"},"salesperson":"Paul Test"},{"_id":"5cbdd2c598edd338c2faa5a0","status":"Opportunity","serialNumber":15,"date":"2019-04-22T14:42:13.016Z","salesperson":"Dwight Schrute"},{"_id":"5cacae9e6ce2222e0962ced4","status":"Opportunity","serialNumber":14,"date":"2019-04-09T14:39:26.510Z","property"

D:\dev\pavement>flutter doctor -v
[√] Flutter (Channel stable, v1.5.4-hotfix.2, on Microsoft Windows [Version 10.0.17134.765], locale en-GB)
    • Flutter version 1.5.4-hotfix.2 at C:\tools\flutter
    • Framework revision 7a4c33425d (8 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at c:\tools\Android-SDK
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = c:\tools\Android-SDK
    • Java binary at: C:\tools\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\tools\android-studio
    • Flutter plugin version 36.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[!] VS Code, 32-bit edition (version 1.34.0)
    • VS Code at C:\Program Files (x86)\Microsoft VS Code
    X Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (1 available)
    • LGM G600L • LGMG600Lf8469764 • android-arm64 • Android 8.0.0 (API 26)

! Doctor found issues in 1 category.

@duzenko could you try running the code against the current master branch? It might have been fixed on master already.

@LongCatIsLooong
How do I do that?

Run flutter channel master
https://github.com/flutter/flutter/wiki/Flutter-build-release-channels

Apparently does not happen in master

@duzenko thanks for confirming! I'm going to close the issue. The next stable release will contain the fix.


[TEST] Implement test case test_pvc_storage_class_name_from_backup_volume

What's the test to develop? Please describe
Implement test case test_pvc_storage_class_name_from_backup_volume, it only have test skeleton and marked as skip by pytest now
Describe the tasks for the test

Additional context

Test case passed on master and v1.5.x pipeline


'instanceof' narrowing works awkwardly with empty object types & primitives

Try in the playground.
class Dog {
}

declare let x: Dog | string;

if (x instanceof Dog) {
    x
}
else {
    x.toLowerCase()
}

Expected: No error, first branch's x has type Dog, second branch's x has type string
Actual: Property 'toLowerCase' does not exist on type 'never'. (first branch is string | Dog, second is never)
We should be accounting for primitives a little less sloppily. instanceof checks don't work on primitive types.

Specifically, any changes here should ensure that
function foo(x: number | string) {
    if (x instanceof Number) {
        x
    }
}

x is not narrowed in the above example.

Actually, we should just issue an error when no constituent of a union is a primitive.


IMM_CONFIG_PATH env variable does not work

When running the scripts/imm, the  IMM_CONFIG_PATH env variable does not have any effect since it is always set to ~/.immconfig
https://github.com/IntelAI/inference-model-manager/blob/master/scripts/imm_utils.sh#L18

fixed


Dutch National Flag Algorithm

Dear Maam
I am solve the issue which assign to me #958
Please merge my solution.
Thank you

Maam
I write code in Special Algo folder code in python.
Please tell me maam which folder I choose.

Maam
I write code in Special Algo folder code in python.
Please tell me maam which folder I choose.

Look for an algorithm folder and in that, there is a special algorithm folder. Link your code with that and add yr code in Python Folder :)

Maam
I already created python folder in special algo floder.This file also in python folder.

Plz link your code with appropriate folder.

Heyy, you need to link yr code. Plz go through tge guidelines and the pinned issues.

Maam
Please tell me where error in code merging.How I merge this code.


More readings from BMS, e.g. Cell voltages/deviation

Great integration, thank you!!!
Can I raise an improvement request?
Would be great, if the integration would read out BMS values like cell voltages or cell voltage deviations because the whole DIY community tracks their cell voltages carefully. Currently I need to read them via mqtt but doing this with your integration would be a lot easier...

The integration can only provide the information provided by the GX device over Modbus. I had a look through the spec and while minimum/maximumn cell voltage is provided, it is set to 0 on a managed battery. The full list is here:
Modbus registers list
This is the same as the MQTT data available, so it is not available via either side. If Victron can add it to the list, it can be exposed via the integration.

Cell Voltage is available in Mqtt, it can
also be displayed in the console for certain battery types.

Yes, they can, but my point was that this is a modbus integration, so only values available via the modbus registers are available. It might be possible for some, but not a general thing that can be easily made available.

Adding won't fix for now since this isn't currently exposed by victron as mentioned by @braamvh.
@pos-ei-don if you want to open a feature request for this on the victron forum to get this added feel free to link this issue.
If not this issue will be archived after 01-04-2023 if no further activity occurs

This is however dependant on victron's willingness to approve a pr I will be making


Unlimited bounces are exported as 0 bounces

Setting max light bounces to 0 doesn't export them as unlimited, render zero bounces instead

#87

Fixed.  Any ray bounce tagged as 'unlimited' is simply not exported.


Nitro enclaves

Fixes #
Description
Enable Karpenter to use nitro enclaves in EKS - https://docs.aws.amazon.com/enclaves/latest/user/kubernetes.html. This is possible with nitro based instances with some exceptions - https://docs.aws.amazon.com/enclaves/latest/user/nitro-enclave.html#nitro-enclave-reqs
How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Seeing this is still marked draft. Happy to discuss any blockers.

Thanks for the PR @andrewhibbert, feel free to pull the PR out of draft when you're ready for a review.

@andrewhibbert have you had a chance to look at this one?

+1, any update here ?

1 - Do we have a roadmap to implement this capability?

this will be very helpful. do we have any plan of when we will have this?

@andrewhibbert going to close this since there hasn't been activity in a while, but if you're still able to work on this, feel free to reopen! We'd love to get Nitro support added to Karpenter. I've added a feature issue to track this: https://github.com/aws/karpenter/issues/3693


tests: migrate unit tests to Rust

To avoid issues like python2 not available on distros, we should simply migrate unit tests to Rust. That would make more sense, as the main code is already written in Rust.
Add edition in Cargo.toml to fix builds.
Without edition = 2021, build fails due to a missing "extern crate ...".
Specifying an edition, Build passes without having to add it.
As Rust does not support global variables by default, it is necessary to make use of lazy_static, so the variables could be accessed in multiple tests.
Fixes: https://github.com/flatcar/Flatcar/issues/1081

All addressed, but it still has a few issue, like test_enable failing due to collisions during clean up.

Replaced tempdir with tempfile, as the tempdir crate was deprecated.

Replaced users with uzers, as the users crate was deprecated.

Thanks.


Upgrade @untemps/utils, #74

Closes #74

:tada: This PR is included in version 1.7.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow typing hints for Array class (in GDScript and Inspector)

Closes #3586, by implementing the 1b variation mentioned there.
Use as:
export(Array, IntArray) var map
export(Array, Array, int, FLAGS, "Walkable", "Mineable") var map

Assigning to @reduz for review.

I feel like I need to read all docs again for 3.0. :)

@bojidar-bg If you want to update the docs of the master/latest branch btw ;)

@akien-mga Make an issue and assign me, please :smiley:

Does this support specifying object type known by the editor? If I'm reading the code correctly, you can only specify Variant::Type as an integer and you can't add a specific object type as a string if the type is Variant::OBJECT.

You can specify any hint string for the elements of the array, thus hintstrings of Variant::OBJECT exports would be preserved.
E.g.
export(Array, ImageTexture) var x

Results in a export hint of itos(Variant::OBJECT) + "/" + "ImageTexutre" == "17/ImageTexture" and export type of Variant::ARRAY.
Later, ArrayPropertyEdit would parse the hint, and use the 17 as type and the ImageTexture as hint for elements of the array.

Thanks for clarifying, although the format seems to be more like $subtype_idx[/$subtype_hint_idx]:$subtype_hint_string, e.g. 17:ImageTexture or 2/1:0,20,1 (int range 0-20).
I tried specifying "17:SpatialMaterial" as a hint, and the editor recognized the object type, but when I clicked on the array item cell to specify the material, no dropdown appeared. Is it a known issue?

@endragor That's strange, can you ensure that GDScript makes the same hint string and export type? (since the export type must be Variant::ARRAY, otherwise it won't parse it as an array hint string)

I use NativeScript, not GDscript, but yeah the editor recognizes the type as Array correctly, the problem occurs when I try to add an object to the array.

Hi,
I'm attempting to use this feature to provide the user a way to specify an array of textures.
export(Array, Texture) var textures
However, the editor presents an error when I attempt to do this.
I can only seem to do this with basic types, such as:
export(Array, int) var int_values
Unfortunately I don't know enough about the source to debug this issue, let alone implement and test the fix. Can someone please help? Reading this thread it seems that it should work but currently it isn't.
Thanks

Thank you for the update, I will look into the issue you linked.
On Sat, Apr 7, 2018, 02:22 Bojidar Marinov<EMAIL_ADDRESS>wrote:

@DevinPentecost https://github.com/DevinPentecost Yes, this is a known
issue, sorry for the hassle.
See #15961 https://github.com/godotengine/godot/issues/15961 (issue)
and #16418 https://github.com/godotengine/godot/pull/16418 (unmerged PR
solving it).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/6930#issuecomment-379456086,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3olJJY8dwYBbMpdv-1MhJJuENIWuD1ks5tmIVCgaJpZM4KhH0v
.


Autoruns / Space in executable path to hide from autoruns

Looks like autoruns can be fooled by inserting a space in a executable path since Command and Arguments attribute get concatenated with a space in between. Interesting corner case but would be great if autoruns would check for this condition.
Details:
TL;DR; Creating a scheduled task with a space in the file path will “hide” the executable from Autoruns. The file path is split on the space, the first part becomes the scheduled task’s command and the second part is treated as the command’s arguments. Autoruns uses the command as the image (executable) path for scheduled tasks. Tested on Windows 7, 2012, and 10. The task only ran on Windows 2012 and 10.
https://medium.com/@jdferrell3/scheduled-task-command-with-space-hides-the-file-from-autoruns-1c7bfe38a67c

Thanks for reporting this, we've added it to our backlog.


Fix - status active : sidebar submenu not shown, submenu collapssed

Background :
Feedback from Facebook Group :
"untuk sub menu yang active mohon untuk , dropdown menu nya ttep active jga mas"
input by mas https://www.facebook.com/groups/226276471968988/user/100012087074706/
Current Condition :
When a submenu item is clicked (and now in the right pages), the menu parents is not opened, and he active submenu is not highligted. Possible confuse user on finding which pages he is currently in.

fixed on https://github.com/tonitegarsahidi/samboilerplate-11/commit/08d374ad257f8649e40989bcff1c4de75c90a3e2


file_list and file_ind order mismatch in oak:base.py

Commit hash (the first line of output from git show):
commit fdaffea4d82ccc16f908455e92e54cbcaa646ab3 (HEAD -> develop, origin/develop, origin/HEAD)
Describe the bug
Beginning on line 531 of base.py in oak module, the following identifies the indices of the files that should be read in for a given d_datetime:
# find file indices for this d_ind
file_ind = [i for i, x in enumerate(dates_shifted)  if x == d_datetime]

The enumeration is over dates_shifted, which is derived from dates, which is derived from file_dates. file_dates is sorted on line 475. file_dates is based on file_list, which contains a list of all accelerometer files for a given user. Note: file_list is never sorted. The code to read the raw data for a given day begins on line 541:
# load data for a given day
for f in file_ind:
    logger.info("File: %d", f)

    # read data
    file_path = os.path.join(source_folder, file_list[f])
    data = pd.concat([data, pd.read_csv(file_path)], axis=0)

The code above iterates over the file indices, but indexes file_list to grab the actual file name. However, file_list is not sorted and therefore does not have the same order as dates_shifted. As a result, the incorrect files are read.
To reproduce
Inspect dates_shifted and file_list and compare ordering.
Observed behavior
Accelerometer data for a specified day is not being read in correctly.
Expected behavior
Additional context
I believe a quick fix would be to sort file_list right after it is created on line 467 of base.by.
file_list = os.listdir(source_folder)
###proposed fix
file_list.sort()

Thank you, will implement your solution!


functional tests: set cpu isolator correctly

The ACE spec defines limit as:
limit: cores that can be consumed before the kernel temporarily throttles
the process
and core as:
core: seconds/second that the app/pod will be able to run. e.g. 1 (or
1000m for 1000 milli-seconds) would represent full use of a single CPU
core every second.
So setting 100 would mean 100 seconds/second which doesn't make sense.
Somehow this wasn't failing until now but testing the flavor src with
the (yet to be released) systemd v231 makes it fail.

The 2 following changes makes systemd refuse percentages that are over 100%:

https://github.com/systemd/systemd/pull/3481/files#diff-7710df8bc0393477682a0cfc6031dd62R87
https://github.com/systemd/systemd/pull/3481/files#diff-327855c3af836dac88385f2811f3929dR550

Is the error user-friendly if the ACI manifest wrongly contains "limit": "250" instead of "limit": "250m"?
Otherwise, LGTM.

No

Test failures are not related, I'm gonna merge this.
If we want to protect from users writing things like "250" we can do a follow-up to update the isolator validator in the spec.


Track: Ship 1.1.0

(Tracking issue)

[ ] Write release notes
[ ] Tag release => Create GitHub release
[ ] Upload to NuGet

Hi, I'm currently using 1.1.0 from the AppVeyor feed. Is there any estimated date of publishing it to the official NuGet gallery?
BTW, thanks for sharing your great library 👍

I've had some problems finding time for it, only have one work item left to do (deprecated RunAsync() but all tests use it.. theoretically I could just release without it).
but It's good to know that it works for you so a better chance it'll work 👍 (I pushed support for a builder API that will allow adding new config features without blowing up the createservice() function and my mind with it)
thanks for your patience! glad you like it!

I had some trouble getting this into the main product using it very late into a release cycle and am on vacation now, but will be back next week.

Does it's working on win 64 bit?

@maxfuterman it is architecture independent and as such works everywhere a .net standard library can work.

1.1.0 finally uploaded to NuGet and awaiting indexing.


Dutch translation ready for integration

All necessary strings have been translated to Dutch on Weblate.
Can the translation be integrated in the next build?

Wow, that was fast, thanks a lot! I have merged your changes and enabled the Dutch language for the next release.


How can we pass dynamic json with and  OR condition

how can we improve on that aspect any idea?

Not following the question. Some code might help.


Can't select specific columns from DB

Hello there! Congratulations for this awesome package. I love it. I'm currently developing a single page app with AngularJS and Lumen for the front-end and WordPress for the back-end.
I'm having some issues. When I do Post:all() I get all the posts, which is fine. But it's too much unnecessary data. I want index to have a subset of the data of each post like the title, the excerpt, featured image... But I can't select which columns I want using get([array, of, columns]) or paginate(10,

Hi,
make sure to include the post_type column :
$posts = Post::get(['post_name', 'post_type']);

Thanks! will try this out.
On Jul 19, 2016 7:00 AM, "Mickael Burguet"<EMAIL_ADDRESS>wrote:

Hi,
make sure to include the post_type column :
$posts = Post::get(['post_name', 'post_type']);
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jgrossi/corcel/issues/176#issuecomment-233610939, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrcKF9zPuH-KlH0_BjuiFVhpFU5RnmJks5qXLxZgaJpZM4JPXT1
.

It seems to work but I'm still getting some null columns. I think they're
are the custom attributes set by the package. Do you know any way around
this. Thanks!
On Jul 19, 2016 11:36 AM, "Jean Gérard Bousiquot"<EMAIL_ADDRESS>wrote:

Thanks! will try this out.
On Jul 19, 2016 7:00 AM, "Mickael Burguet"<EMAIL_ADDRESS>wrote:

Hi,
make sure to include the post_type column :
$posts = Post::get(['post_name', 'post_type']);
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jgrossi/corcel/issues/176#issuecomment-233610939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHrcKF9zPuH-KlH0_BjuiFVhpFU5RnmJks5qXLxZgaJpZM4JPXT1
.

And also the returned columns are double up. It gives post_title and title,
post_name and slug and so on. The issue is still there. Please help.
On Jul 19, 2016 11:42 AM, "Jean Gérard Bousiquot"<EMAIL_ADDRESS>wrote:

It seems to work but I'm still getting some null columns. I think they're
are the custom attributes set by the package. Do you know any way around
this. Thanks!
On Jul 19, 2016 11:36 AM, "Jean Gérard Bousiquot"<EMAIL_ADDRESS>wrote:

Thanks! will try this out.
On Jul 19, 2016 7:00 AM, "Mickael Burguet"<EMAIL_ADDRESS>wrote:

Hi,
make sure to include the post_type column :
$posts = Post::get(['post_name', 'post_type']);
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jgrossi/corcel/issues/176#issuecomment-233610939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHrcKF9zPuH-KlH0_BjuiFVhpFU5RnmJks5qXLxZgaJpZM4JPXT1
.

Hi, they're not in double, the short names are just eloquent accessors

Okay but they are still outputted. Having a big post_content and its twin
content is a huge bandwidth issue I think. What about getting array of
columns like ['title', 'content', ...]? Isn't that possible, for now?
On Jul 19, 2016 1:39 PM, "Mickael Burguet"<EMAIL_ADDRESS>wrote:
Hi, they're not in double, the short names are just eloquent accessors
https://laravel.com/docs/5.1/eloquent-mutators#accessors-and-mutators
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jgrossi/corcel/issues/176#issuecomment-233726627, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrcKL_XVo2JDPgXAbnZ-IpJA_5W0DTlks5qXRn4gaJpZM4JPXT1
.

Have a look at the eloquent models serialization methods

Thanks a lot Mickael! You saved me the day. Thanks again mate!
By the way do you any way to pull different featured image size? For now I
got one image but it's kind of big.
On Jul 19, 2016 2:38 PM, "Mickael Burguet"<EMAIL_ADDRESS>wrote:

Have a look at the eloquent models serialization
https://laravel.com/docs/5.2/eloquent-serialization methods
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jgrossi/corcel/issues/176#issuecomment-233742303, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrcKAiTzwyK4qPl3oua3u3XrYo4yPHTks5qXSeqgaJpZM4JPXT1
.

@jgbneatdesign Can you give us an update about your problem? Is it solved?


Agent update

Proposed change(s)
I have added a random action agent implemented with the low-level API (as per Braitenberg) and fixed the reliability of the braitenberg agent.
Types of change(s)

[X ] Bug fix
[ X] New feature
[ ] Code refactor
[ ] Breaking change
[ ] Documentation update
[ ] Other (please describe)

Checklist

[X ] Added tests that prove my fix is effective or that my feature works
[ ] Updated the changelog (if applicable)
[ ] Updated the documentation (if applicable)
[ ] Updated the migration guide (if applicable)

Other comments
Screenshots (if any)

have you also considered the versioning? Is this a breaking change (becomes version 5.0.0) to the braintenberg agent? Or can we go to 4.1.0 OR 4.0.2 depending on the scale of the changes @kozzy97


Different Fragment item each item view and image

Thanks in advance for responding to bug I reported yesterday. and can you gives an example of the use of NTB with 4 Fragment different? because I have tried but to no avail, oh I want to create a navigation reference to NTB like Instagram. and whether the icon NTB may directly input in the form Bitmap without having at Convert to BitmapDrawable?

Hello again. Thanks. You can just put a Drawable. If you want to create a NTB with 4 fragments use ViewPager, like in sample app.

i have doit
and this my code https://gist.github.com/triasbrata/537a6309b929d25c57d0246127447c87


overwriting dependencies gives wrong results when run on a empty repository

For the repository https://github.com/Licenser/mdns_client_lib/tree/rebar3 the rebar.config file looks like this:
{erl_opts, [debug_info, warnings_as_errors, {parse_transform, lager_transform}]}.
{deps,
 [
  {lager, ".*", {git, "git://github.com/basho/lager", {tag, "2.1.1"}}},
  {pooler, ".*", {git, "https://github.com/seth/pooler.git", {tag, "1.4.0"}}},
  {mdns_client, ".*", {git, "https://github.com/Licenser/erlang-mdns-client.git", {tag, "0.1.2"}}}
 ]}.

{profiles,
 [{pkg,
   [{deps,
     [
      {lager, "2.1.1"},
      {pooler, "1.4.0"},
      {mdns_client, "0.1.2"}
     ]}]}]}.

all the following command are run on an fresh repsoitory with no _build or rebar.lock.
running rebar3 compile prints as expected:
===> Verifying dependencies...
===> Fetching lager ({git,"git://github.com/basho/lager",{tag,"2.1.1"}})
===> Fetching mdns_client ({git,
                                      "https://github.com/Licenser/erlang-mdns-client.git",
                                      {tag,"0.1.2"}})
===> Fetching pooler ({git,"https://github.com/seth/pooler.git",
                                  {tag,"1.4.0"}})
===> Fetching goldrush ({git,"git://github.com/DeadZen/goldrush.git",
                                    {tag,"0.1.6"}})
===> Compiling mdns_client
===> Compiling pooler
===> Compiling goldrush
===> Compiling lager
===> Compiling mdns_client_lib

All code is fetched, as it should, now deleting both _build and rebar.lock re-run with the pkg profile rebar3 as pkg compile we get the following output:
===> Verifying dependencies...
===> Fetching lager ({git,"git://github.com/basho/lager",{tag,"2.1.1"}})
===> Linking _build/default/lib/lager to _build/pkg/lib/lager
===> Fetching mdns_client ({git,
                                      "https://github.com/Licenser/erlang-mdns-client.git",
                                      {tag,"0.1.2"}})
===> Linking _build/default/lib/mdns_client to _build/pkg/lib/mdns_client
===> Fetching pooler ({git,"https://github.com/seth/pooler.git",
                                  {tag,"1.4.0"}})
===> Linking _build/default/lib/pooler to _build/pkg/lib/pooler
===> Fetching goldrush ({git,"git://github.com/DeadZen/goldrush.git",
                                    {tag,"0.1.6"}})
===> Linking _build/default/lib/goldrush to _build/pkg/lib/goldrush
===> Compiling mdns_client
===> Compiling pooler
===> Compiling goldrush
===> Compiling lager
===> Compiling mdns_client_lib

Which seems wrong since the dependencies in pkg should take precedence. Looking at the rebar.lock file it looks like:
[{<<"goldrush">>,
  {git,"git://github.com/DeadZen/goldrush.git",
       {ref,"71e63212f12c25827e0c1b4198d37d5d018a7fec"}},
  1},
 {<<"pooler">>,
  {git,"https://github.com/seth/pooler.git",
       {ref,"6a12e4419c8fe504c77cd6393bcc11cb8993aa24"}},
  0},
 {<<"mdns_client">>,
  {git,"https://github.com/Licenser/erlang-mdns-client.git",
       {ref,"b33c9621234d690b74c9694acc66f1ddb6a77d65"}},
  0},
 {<<"lager">>,
  {git,"git://github.com/basho/lager",
       {ref,"d33ccf3b69de09a628fe38b4d7981bb8671b8a4f"}},
  0}].

Now running rebar3 as pkg upgrade gives the next oddity
===> Verifying dependencies...
===> No upgrade needed for lager
===> Upgrading pooler
===> No upgrade needed for goldrush
===> No upgrade needed for mdns_client
===> No upgrade needed for lager
===> Fetching pooler ({pkg,<<"pooler">>,<<"1.4.0">>})
===> No upgrade needed for goldrush
===> No upgrade needed for mdns_client

Regarding that only pooler was upgrades (it should not need to have been fetched but that is a small site note), however the rebar.lock file now looks like:
[{<<"mdns_client">>,{pkg,<<"mdns_client">>,<<"0.1.2">>},0},
 {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.6">>},1},
 {<<"pooler">>,{pkg,<<"pooler">>,<<"1.4.0">>},0},
 {<<"lager">>,{pkg,<<"lager">>,<<"2.1.1">>},0}].

Note, I realized this issue is due to the pkg profile using hex packages and the default profile using git deps. Because of how git deps take precedence that is what is screwing up the fact that pkg profile deps should/would take precedence.
See tests like https://github.com/rebar/rebar3/blob/master/test/rebar_profiles_SUITE.erl#L91-L105 which test that the profile takes precedence but only tests this is true for deps of the same resource type.

So half of this was fixed but the half about 'rebar3 as pkg compile' not installing the package deps because they exist as git deps in default can't be fixed.
Close it if it is ok.

To get into specifics, profile merging yields the list of dependencies:
[{lager, "2.1.1"},
 {lager, ".*", {git, "git://github.com/basho/lager", {tag, "2.1.1"}}},
 {pooler, "1.4.0"},
 {pooler, ".*", {git, "https://github.com/seth/pooler.git", {tag, "1.4.0"}}},
 {mdns_client, "0.1.2"},
 {mdns_client, ".*", {git, "https://github.com/Licenser/erlang-mdns-client.git", {tag, "0.1.2"}}}]

The other bit about it is that rebar3 has a rule that source deps always take precedence over packages (so that someone can override a package dependency chain without publishing to hex). The end result there is that only with deps, profiles cannot be overriden that way because we make an explicit decision to pick git before pkg no matter the declaration order.
I don't think there's a good way to fix it without breaking other rebar3 rules.

I got a plan, once hooks can modify state I'll make a plugin that takes care of this for publishing to hex. But yes as a basic rule pick src over pkg makes a lot of sense and modifying it wouldn't be good, I agree. Closing it :).


Implement persistent text label without tooltip

Followup from the conversation in https://github.com/mui-org/material-ui/pull/12856
Since the tooltip appearing and disappearing based on mouse movements is not required at all for this case, use of the tooltip can be avoided.
@oliviertassinari

@oliviertassinari great idea! @hashwin Thanks for running with it.
Unfortunately the label doesn't always seem to be correctly positioned, similar to the problem you fixed in #12590:

I haven't looked any deeper...

No, definitely this one:
HEAD is now at a8e3c2a1c... Update docs

I restarted the server and reloaded the page to be certain...

OK, NVM, I had to shift-reload.

@mbrookes Fixed

@mbrookes @oliviertassinari Good to go?

@hashwin Nearly! Could you try to correct this?

One thing that jumps out is that the labels all show up together, while the actions animate in sequence.

Also, if we're going to re-implement the tooltip, I wonder if we should use this instead of Tooltip in the other mode?

@mbrookes Not sure about that. Tooltip already has the mouseover logic that we need and as discussed with @oliviertassinari it also contains the separate logic for touch and click devices. I don't think that should have to be reimplemented here.

Okay, thanks @hashwin. In that case lets look to unify the styling.

@mbrookes Seems like the behavior specified by material design is not to use tooltips when hovering over, rather use extended FABs as specified here: https://material.io/design/components/buttons-floating-action-button.html#extended-fab
But that seems like it's independent of this feature, so I would leave that for a different PR.

@mbrookes I updated the tooltip style so it will be consistent with the open text label style.

Additionally also added a fix for hybrid click/touch devices (should resolve https://github.com/mui-org/material-ui/issues/13006)

That looks great!
@eps1lon could you take a final look, particularly at the fix for #13006?

Test failures look unrelated - it's some other file, I only changed variable names and the previous build passed.
Not sure how to rebuild though.

@eps1lon please see the discussion here: https://github.com/mui-org/material-ui/pull/12856

@eps1lon please see the discussion here: #12856

So no. Thanks for helping me out here.
From what I gathered is that the tooltip somehow resizes. Why is this behavior there in the first place? Why is this fix not applied to the Tooltip component?
If I read that correctly there is already a bug that the Tooltip assumes the touch implies a mobile device. I could not find a section in the material design spec that defines when a device is considered mobile.
Using a different component if the tooltip is permanently open screams micro-optimization to me.

If I read that correctly there is already a bug that the Tooltip assumes the touch implies a mobile device.

@eps1lon What do you mean by implies a mobile device? Right now a touch (from a large or small screenà implies that the tooltip styles need to be increased so it's doesn't stay behind the user's finger.

I think I'm slowly piecing it together.
Here's my proposal:

stick with Tooltip since it's a tooltip after all
discuss why an already open tooltip has to change size and position on touch (could not find a section about this in the spec)

Maybe the answer to the problem is really simple. Why do we override the CSS to always looks like

No matter the touch interactions/screen size.

Maybe the answer to the problem is really simple. Why do we override the CSS to always looks like [...]
no matter the touch interaction / screen size?

That's more reasonable than changing to component tree. All for it :+1:

discuss why an already open tooltip has to change size and position on touch (could not find a section about this in the spec)

@eps1lon So the tooltip doesn't stay behind the user's finger. Do you have an alternative in mind?

I need to understand the issue first. What do you mean "behind"?

My views on the matter:
For Tooltip:

Unified implementation and styles
Automatic animation and correct placement

Against Tooltip:

Tooltip animation may differ from the speed dial animation
Nowhere in the material design spec do I see a mouseover tooltip along with the Speed Dial. The only way it is described is using an Extended FAB https://material.io/design/components/buttons-floating-action-button.html#extended-fab (See video: https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F1Jmstk1Jw6xAnO4IY1dbE9morbTzcNzSY%2Fextended-fab-behavior-speeddial.mp4)
Mouseover logic is never used when tooltipOpen prop is given.

In any case, I would like to see a consensus reached quickly as I would like to push this out to users in my app ASAP as the current implementation contains the buggy touch logic contained within Tooltip.

Maybe we misinterpreted the design spec. We shouldn't have added the tooltip by default and just add a label prop the SpeedDialAction.
The issue is that we do not support wrapping the children of the SpeedDial in a Tooltip. It's similar to #12921.
If you want to speed up the process I would advise you open a separate PR that just contains the bugfix. I would recommend using your own fork if you're using lab components in production. They'll always be in alpha so bugs should be expected and we currently release lab and core at the same time so it might take a week or so until a fix is applied.

If you want to speed up the process I would advise you open a separate PR that just contains the bugfix
That bugfix was contained in https://github.com/mui-org/material-ui/pull/12856 😄

I would recommend using your own fork if you're using lab components in production.
Fair enough, I will do that for now.

Please let me know if I can help with the implementation once consensus is reached.

I would recommend using your own fork if you're using lab components in production.

Sorry, a sidenote - Since the material lab package is contained within this, how can I point it to my fork in my package.json? For other libraries, I have used this format:
"react-select": "hashwin/react-select#25ac73796f5a52c37bf461ca500391dfd84463a5",

Is there a way to do it like this without actually publishing my own fork to npm?

Build locally and then use file:// or use the link commands from npm or yarn.

Build locally and then use file:// or use the link commands from npm or yarn.

I do that for testing but what about actually using it in my production environment? Anyway, I will just publish my own version to npm, seems like there is no other way. Thanks

I need to understand the issue first. What do you mean "behind"?

@eps1lon Let's say you are using a Window surface and a media query based logic to change the tooltip style, you might miss the information displayed

I need to understand the issue first. What do you mean "behind"?

@eps1lon Let's say you are using a Window surface (large screen) and a media query based logic to change the tooltip style, you might miss the information displayed when using a long touch to display the tooltip.

@oliviertassinari  Can you link me some sites that have the same behavior? I have pretty big hands/fingers and I can still see that something popped up after a touch. How do you determine where the tootip would not be hidden behind the users finger? If I reach from the right and the placement is below nothing has to change. If I reach from the right and the placement is right I might not see it (as you said).

Can you link me some sites that have the same behavior?

@eps1lon Not I'm aware off. It's really about an interpretation of the specification. My point is that it should be touch/mouse based, it's better than a screen size based logic. It's what I believe provide a better UX.

FWIW I have had this branch running in my production app, and my users have reported that all the issues (hybrid device clicks, glitchy tooltip size, positioning and click behavior) have all been resolved.

Maybe the answer to the problem is really simple. Why do we override the CSS to always looks like

I think perhaps you meant "why don't we"? In that case, I agree - it solves the problem (even if those big-ass tooltips are a bit ugly).

@oliviertassinari @mbrookes @eps1lon Apologies, I haven't followed up on this, just wanted to check, was there any consensus on this? As I mentioned I have been using this branch AS IS on my production app and have had absolutely no problems.

@hashwin Are you happy to wrap this up?

@mbrookes Sure I will try to clean this up this weekend

@mbrookes I updated the branch, getting a regression failure with a screenshot, not sure how to fix it.

@hashwin I have changed the target branch to next, as master is now only for bug fixes, but I'm afraid that means you will have to rebase again, sorry.  After that I can we can accept the visual regression.

I'm closing, feel free to continue the effort :)


Update 3stars.txt

Good use of default names for commits. Would be good to include a description along with the pull request and a more descriptive title such as 'Translate spanish review in 3stars.txt' or just 'Remove spanish review'.


User- and query-embeddings

TODO:

Set up user- and query-embeddings that we can use to adjust the scores of articles retrieved from ElasticSearch (when we have done training of course)

I will look at what was done in the Colab exercises, to see what we can do to make our embeddings and train our model.


Added weaver completion bash completion command.

This PR introduces a weaver completion command that spits out a bash completion script that enables tab completion for the weaver command. For example:
$ weaver <tab><tab>
generate   gke        gke-local  multi      single     ssh        version
$ weaver single <tab><tab>
dashboard  deploy     help       metrics    profile    purge      status     version
$ weaver single p<tab><tab>
profile  purge

To enable the tab completion, you run source <(weaver completion). This mirrors kubectl completion bash. Source the file in your ~/.bashrc if you always want it to be enabled.
I added weaver completion selfishly, as I thought it was useful. If others find it useful, we can advertise it to users. There is a bit of overhead in updating it whenever commands change, and the gke commands could be stale, so it would require work to be more robust. Also happy to leave this out of the repo and have it privately for myself.

This work has been deprioritized.


meson: Install CMake and pkg-config files into architecture-independe…

…nt directories
toml++ is header-only so these should be installed into architecture-independent directories to allow them to be found for crosscompiling regardless of the architecture they were installed on.
Fixes #59.

Oh, that was fast, thanks @tambry! Want to add yourself to the contributors list in README.md before I merge it?

Oh, that was fast, thanks @tambry! Want to add yourself to the contributors list in README.md before I merge it?

I'd rather not add myself for such a small change. Feel free to go ahead and merge. 🙂


Intermittent CI errors

CI jobs occasionally fail with:
  1) preserve environments integration with --preserve-environments set and --environment, --create-symlinks unset should exit with error status due modules in production environment not being found
     Failure/Error: expect(@result.exception).to be_a_kind_of(OctocatalogDiff::Errors::CatalogError)
       expected #<Parallel::DeadWorker: Parallel::DeadWorker> to be a kind of OctocatalogDiff::Errors::CatalogError
     # ./spec/octocatalog-diff/integration/preserve_environments_spec.rb:97:in `block (4 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-retry-0.5.0/lib/rspec/retry.rb:112:in `block in run'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-retry-0.5.0/lib/rspec/retry.rb:101:in `loop'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-retry-0.5.0/lib/rspec/retry.rb:101:in `run'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-retry-0.5.0/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
     # ./vendor/bundle/ruby/2.0.0/gems/rspec-retry-0.5.0/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

It looks like we need to rescue Parallel::DeadWorker and raise OctocatalogDiff::Errors::CatalogError at some point.

Resolved by https://github.com/github/octocatalog-diff/issues/111


ERC-1155 NFT image and metadata not showing

Images for ERC-1155 NFTs aren't appearing - just a plain square shows with the symbol characters.
When you call uri in an ERC-1155 NFT contract it returns something like:
https://game.example/api/item/{id}.json
You must replace the {id} string with the actual token ID, in lowercase hexadecimal (with no 0x prefix) and leading zero padded to 64 hexadecimal characters, as specified in the ERC-1155: Multi Token Standard.
e.g. for token ID 2 you would replace {id} with<PHONE_NUMBER>000000000000000000000000000000000000000000000000000002 to get the JSON metadata at https://game.example/api/item/0000000000000000000000000000000000000000000000000000000000000002.json

Thanks, I wasn't aware of that nuance.

Thanks @JamesSmartCell , it works now when viewing the NFTs of a collection.
Though in the wallet "Collectibles" pane it still just shows a square with the symbol characters as the collection image. Maybe it should show the image of the first NFT found instead of just a plain square.

Thanks @JamesSmartCell , it works now when viewing the NFTs of a collection.
Though in the wallet "Collectibles" pane it still just shows a square with the symbol characters as the collection image. Maybe it should show the image of the first NFT found instead of just a plain square.

Yes that's something I've been intending to add for a while.


Muted Users: Hide name in group PM

Not hiding the name in group PMs in the left side bar in the web app is definitely a bug -- good eye @chrisbobbe ! I posted to https://chat.zulip.org/#narrow/stream/101-design/topic/Hiding.20user-muted.20messages/near/1179851.

Made the requested changes, going ahead and merging.

Thanks @WesleyAC and all!
I've just pushed a couple of small fixes to these changes:
9e27f2329 pm-conversations: Use useCallback for an event handler.
49a931641 pm-conversations [nfc]: Fix grouping of imports.

The solution to that problem is `useCallback`.  Generally we always
want to use that when translating a constructor-initialized callback
like this onto a function component.

Noted, thanks!


Unmanaged exception when running the script

Hi,
all config steps are completed succesfully, but when I try to execute the script I get the following result:
pi@raspberry-4:~/domoticz/scripts/atc_pvvx $ ./atc_pvvx_monitor.py --log-level DEBUG -t -d
2024-09-11T16:24:12.281 - INFO: /home/pi/domoticz/scripts/atc_pvvx/./atc_pvvx_monitor.py started.
2024-09-11T16:24:12.282 - INFO: Log level = DEBUG
2024-09-11T16:24:12.282 - INFO: Reading "thermometers.yaml" YAML configuration file.
2024-09-11T16:24:12.288 - INFO: Configuration file "thermometers.yaml" successfully parsed.
2024-09-11T16:24:12.366 - INFO: Platform "Linux" detected.
2024-09-11T16:24:12.367 - DEBUG: BLE scanner parameters: scanning_mode = passive, bluez = {'or_patterns': [OrPattern(start_position=0, ad_data_type=<AdvertisementDataType.SERVICE_DATA_UUID16: 22>, content_of_pattern=b'\x1a\x18')]}.
2024-09-11T16:24:12.367 - INFO: Starting BLE scanner.
2024-09-11T16:24:12.373 - CRITICAL: Unmanaged exception "[org.freedesktop.DBus.Error.AccessDenied] Rejected send message, 2 matched rules; type="method_call", sender=":1.120" (uid=1000 pid=6585 comm="python3 ./atc_pvvx_monitor.py --log-level DEBUG -t") interface="org.freedesktop.DBus.ObjectManager" member="GetManagedObjects" error name="(unset)" requested_reply="0" destination="org.bluez" (uid=0 pid=15676 comm="/usr/local/libexec/bluetooth/bluetoothd --experime")", terminating.
2024-09-11T16:24:12.373 - INFO: Exiting.

My themometers.yaml:
A4:C1:38:B4:56:2B:
    name:           Reserve
    key:            bd16d2c7dd3d044d1d54e50255d6d0d0
    batt_soc:       off
    clients:
    # a Domoticz client
    -   hostname:   <IP_ADDRESS>
        port:       8080
        user:       xxxxxxxxx
        password:   xxxxxxxxx
        encrypt:    no
        insecure:   no
        idx:        1607

I'm running this on a raspberry 4:
pi@raspberry-4:~/domoticz/scripts/atc_pvvx $ uname -a
Linux raspberry-4 5.10.103-v7l+ #1529 SMP Tue Mar 8 12:24:00 GMT 2022 armv7l GNU/Linux
pi@raspberry-4:~/domoticz/scripts/atc_pvvx $ systemctl status bluetooth.service
● bluetooth.service - Bluetooth service
   Loaded: loaded (/lib/systemd/system/bluetooth.service; enabled; vendor preset: enabled)
   Active: active (running) since Tue 2024-09-10 17:30:27 CEST; 22h ago
     Docs: man:bluetoothd(8)
 Main PID: 15676 (bluetoothd)
   Status: "Running"
    Tasks: 1 (limit: 4915)
   CGroup: /system.slice/bluetooth.service
           └─15676 /usr/local/libexec/bluetooth/bluetoothd --experimental

Sep 10 17:30:27 raspberry-4 systemd[1]: Starting Bluetooth service...
Sep 10 17:30:27 raspberry-4 bluetoothd[15676]: Bluetooth daemon 5.9
Sep 10 17:30:27 raspberry-4 systemd[1]: Started Bluetooth service.
Sep 10 17:30:27 raspberry-4 bluetoothd[15676]: Starting SDP server
Sep 10 17:30:27 raspberry-4 bluetoothd[15676]: Bluetooth management interface 1.18 initialized
pi@raspberry-4:~/domoticz/scripts/atc_pvvx $

Any idea what culd cause this?
Kind regards,
Jeroen

Hi,
As stated in the description of this repository, in Linux it needs Bluez (bluetoothd) ≥ 5.43, your system is running 5.9.
Is feasible to update it to a more recent version? In my case I needed to update Raspbian from bullseye to bookworm.
Hope this helps, regards.

Hi,
too easy, I tricked myself by just taking the version on the bottom of the list, instead of looking a bit more carefull at the versions.
I installed version 5.59 now, and had to solve some other issues with permission.
But now I have the script running without errors, next step is to get some results from the thermometers and push it into domoticz.
Thanks for the good work!


Additional test cases

See:
Issue https://github.com/microsoft/Power-Fx/issues/1327.
PR https://github.com/microsoft/Power-Fx/pull/1421.

✅ No public API change.


[Extractor] Retrieve and link to policy and Open API files

Possibility for the extractor to retrieve, create and link to open API and policy files. This is useful for APIM repositories tracking open API files. This in combination with linking to a policy file, gives a more human readable repository.

This is currently not possible with how we store data in API Management. We will keep it in the backlog.

Closing as this is now a duplicate issue and has been implemented.


ToolTip not working properly when assigned to a button 🐛

Describe the bug
When wrapping a button (or it's child) in a ToolTip. I get the following behaviour:

To Reproduce
Wrap a ToolTip around a Button.
Expected behavior
See the ToolTip until i move the cursor away

Apparently, the tooltip works correctly if the character count is 8 or less—no idea why.

I can not reproduce this issue.
You can test it on the example app (https://bdlukaa.github.io/fluent_ui/). Open the app and go to Tooltip tab. If you hover the button, the tooltip is displayed correctly.
Can you post here a reproducible code snippet?