Missing stream item in Python NDJsonProtocolReader when previous stream is empty

Using the Streams protocol: https://github.com/microsoft/yardl/blob/7a0ab26b0a1050a2e9b2394486ea971d9e8a11d3/models/test/unittests.yml#L174-L183
When serialized, if one of these streams is empty and followed by a non-empty stream, the first element of the non-empty stream is accidentally discarded.
Example:
import test_model as tm

json = "test.json"
with tm.NDJsonStreamsWriter(json) as w:
    w.write_int_data(range(0))
    w.write_optional_int_data([1, 2, None, 4, 5, None, 7, 8, 9, 10])
    w.write_record_with_optional_vector_data([])
    w.write_fixed_vector(([1, 2, 3] for _ in range(4)))

with tm.NDJsonStreamsReader(json) as r:
    assert len(list(r.read_int_data())) == 0
    assert len(list(r.read_optional_int_data())) == 10
    assert len(list(r.read_record_with_optional_vector_data())) == 0
    assert (huh := len(list(r.read_fixed_vector()))) == 4, huh

Fails on the last line because it only reads 3 fixed_vectors, instead of the expected 4.
This was exposed by the same test described in #142 (mixing empty and non-empty streams in roundtrip test).

Resolved in #144


fix only return multi result when CLIENT_MULTI_STATEMENTS been set (#36759)

pick from master #36759
multi statement support by PR #3050.
But there is a minor issue in implementation.
as MySQL dev doc say in
https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_command_phase_sp.html#sect_protocol_command_phase_sp_multi_statement
server should only process multi statement
when client set CLIENT_MULTI_STATEMENTS.
When client not set CLIENT_MULTI_STATEMENTS, server should treat query as single statement.
but Doris do slightly different with MySQL server. Doris always treat query as multi statement, but only return multi result when client set CLIENT_MULTI_STATEMENTS. When client do not set CLIENT_MULTI_STATEMENTS, Doris will return the last statement result only.

Proposed changes
Issue Number: close #xxx

run buildall


chore: bootstrap releases for path: .

Configuring release-please for monorepo packages
We would also need to setup github credentials for it: https://github.com/google-github-actions/release-please-action?tab=readme-ov-file#github-credentials

Tested the release please github action + deploy. Good news: It works! Bad news, some packages got updated and published to npm 😅 if that's fine, we can just merge this PR. If not, we can try deleting the packages from npm first and then moving back to the previous versions.
cc @kyranjamie @pete-watters

I think thats actually more great news than good or bad. It has just updated all the package versions and added the changelog. Now we have moved from patch versions to the first minor version.
Let's give Kyran final say on merging as he has some outstanding comments


Bug Report- AZL Accelerator deploy platform DevOps and automation empty

Describe the bug
During the deployment of AZL Accelerator the part related to "platform DevOps and automation" is empty.
Screenshots

Hey @fabriziogiovannetti,
Thanks for reporting. This happens when you do not select a management subscription. Please select a Management Subscription and then go back to this tab and it will appear.
This is as per this condition: https://github.com/Azure/Enterprise-Scale/blob/main/eslzArm/eslz-portal.json#L840
Hope that helps
Thanks

Hi Jack thanks for your explain. BR Fabrizio


Fix errors; improve ENT

raise Exceptions when wrong login info (fix #127)
fix some errors (fix #128)
add tests for ENT functions

No but mypy joke I don't know why it generates this error😭😭 Can you help me please @bain3 😅


Support for Tipsy parameter on ingest

@BrandonHaynes not sure if these TypeErrors in the tests are new, but they need to be fixed.

@bmyerz Any idea why these tests started failing?  I don't think they're related to this PR.

@BrandonHaynes checking it out. I'm wondering if something about travis changed. These are new tests but they've passed in master when they got merged.

appears to be due to Travis #493

@bmyerz @senderista I went ahead and corrected the change in behavior with httmock in this PR; should be good to merge.

@BrandonHaynes find a workaround at #493

@bmyerz While #493 contains a workaround, this PR now contains an actual fix for the httmock issue :)

@BrandonHaynes awesome! I figured later httmock version was more careful about the spec

You can find the fix for the above failed test at https://github.com/uwescience/raco/tree/tipsy-fix-get-sql

tipsy branch merged in 2d8af658492e6424020ea60d44c877829a2cf254


added lifebeats coin

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.
Solana will be used to build our app's in-game currency. We will extend our app further into other platforms including Solana defi. Currently on iOS with Android on the way. https://apps.apple.com/app/id1523170810

I can help refer this zakimzf/profile#1
PS: if you don't need my help.. please ignore this!


Add install ruby step to mac os installation guide

If a mac user followed the standard installation guide and had the standard mac os ruby installed he would have a very ugly and almost unworkable history behaviour (see https://github.com/thoughtbot/gitsh/issues/177).
This adds the simple solution for this issue to the install guide, so other users don't need to dive into the github issue history to get a nice gitsh experience.

Thanks for this.
Since #256 gitsh's used a custom Readline integration, which means we can avoid these problems regardless of the line editor that Ruby was compiled with.
I'm working on a release today, and once that's out the extra brew install ruby step won't be required.

Sweet! Thanks for the great work.


File.Copy and File.Move - Impersonation only works on .net461 because of #if preprocessor

Noticed that the Task doesn't work on Frends when using impersonation a.k.a Use given user credentials for remote connections setting even if the process is targeting framework 4.7.1. This is because the  #if preprocessor is too strict: https://github.com/FrendsPlatform/Frends.File/blob/e3ff453ec9da1cc5367fcb92a6f2bc4613f006e9/Frends.File/File.cs#L141-L148
The impersonation worked in version 1.1.36 because the project target was then net461, but after the last change the target was changed what caused the impersonation to not work on newer targets.

We have the same issue and can't use the new crossplatform  version Frends.Files.Move  yet, so is it possible to fix this?

Yes, we se this too. Please fix current Frends.File version to work on FrameWork 4.7.1 bases environments too!

This has now been fixed in the newest release.
#26


Error when parsing kernel version in proc background reader

<probe> ERRO: 2016/03/07 12:20:57.204694 getNamespacePathSuffix: cannot get kernel version: Malformed version: 4.3.5-300.fc23.x86_64

Full logs https://gist.github.com/janwillies/54083a50358718a4fb21

From semver.org, 4.3.5-300.fc23.x86_64 is not a valid version, as the pre-release section contains the _ character. Based on googling, I'm assuming this is for Fedora 23?

I have no idea, this came from user jcw on scope-public: https://weaveworks.slack.com/archives/scope-public/p1457352064000743
I am getting a similar error in the Weaveworks ECS AMI:
<probe> ERRO: 2016/03/11 13:49:24.314985 getNamespacePathSuffix: cannot get kernel version: Malformed version: 4.1.17-22.30.amzn1.x86_64

My bad, for not looking into more version examples (and not adding a unit tests).


Migration tweaks

Description
Accomplishes the following:

Moves migration scripts to their own folder.
Adds a new keywords tests for geometry optimizations
Moves testing database to test_qcarchivedb to be more explicit

Status

[ ] Changelog updated
[x] Ready to go

Looks like there is a file clash which needs to be resolved first


basic query about looping through query results

Hi
Sorry to ask a basic question (I'm new to Crystal).
my_query = "select firstname, lastname from table where lastname = 'smith'"
a = conn.query
puts a
gives the string array within an array, e.g.
[["Billy", "Smith"], ["Jane", "Smith"]]
Just to get a basic test working, I'm trying to loop through results using something like:
a.each do |result|
puts result
end
but I get an error 'undefined method 'each' for Nil.
Any tips would be appreciated. Thanks alot.
Cheers
Michael.

If you try outputting pp typeof(a), you will see that it is a union type: Array(Mysql::Types)?. Question mark at the end is the same as |Nil, which, effectively, means, that a is an array of mysql types, or it is a nil.
When compiler fails with Nil error, it tells you that it doesn't know what to do, when the value will be Nil at runtime. You can provide it with information by verifying the type:
a = conn.query(...)
if a
  a.each { ... }
else
  puts "Couldn't make query :("
end

If you are convinced, that value can not be nil, story is simpler: use not_nil!:
a = conn.query(...)
a.not_nil!.each { ... }

Thanks alot for your generous explanation. Much appreciated. Please consider to make some tutorials on your site. Your Crystal experience would be appreciated by new users.

Yes, thank you. I ran into this same exact issue.


Default Max and Min frequency for base profiles

@adorney99 How are the max and min frequencies for the base profiles (performance, balance-power, balance-performance) set? Does it depend on any hardware characteristics or is it defined somewhere within intel power manager? If defined, can we change them before deployment, without having to edit later.

Hi @sahanirn, The values used are based on hardware frequency ranges. The frequency values are calculated by getting the system frequency range (total max - total min), taking a set percentage of that value and subtracting it from the maximum core frequency. The min is just this value minus 200.
We don't have any user facing method of changing these values as users can create their own custom profiles but if you're alright with building images locally you can edit the percentages here to change the percentages used. For example balance performance takes 25% of the system frequency range and subtracts it from the system max frequency


Fix wrong cypress integration link in readme

:tada: This PR is included in version 1.7.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Updated readMe

Removed metricInterval, does not exist anymore.
Updated metricExporter to MetricReader.

Hi @vomba would you mind ammending your commit with conventional commit standard? https://www.conventionalcommits.org/en/v1.0.0/
I kinda need that to release new versions.

Is this good ? to be honest, i haven't used --amend before


LivebookInstall-0.6.3-macos-aarch64.dmg failed install on MacBook Air(m1)

Environment

Elixir & Erlang/OTP versions (elixir --version): Erlang/OTP 25 [erts-13.0.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit] [dtrace].  Elixir 1.13.4 (compiled with Erlang/OTP 24)
Operating system:  MacBook Air (M1, 2020) macOs Menterey Version 12.4
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc):  dmg
Livebook version (use git rev-parse HEAD if running with mix):
Browsers that reproduce this bug (the more the merrier):
Include what is logged in the browser console:
Include what is logged to the server console:

Current behavior
After I instal livebook on my mac , it failed to open it.
error info in ~/Library/Logs/Livebook.log:
ERROR!!! [Livebook] Your hostname "192" does not resolve to a loopback address (<IP_ADDRESS>/8),
which indicates something wrong in your OS configuration, or EPMD is not running.

Make sure your computer's name resolves locally or start Livebook using a long distribution name. Please try one of the fixes below:

  * If you are using the Livebook App, please open up a bug report.

  * If you are using Livebook's CLI, consider using longnames:

        livebook server --name<EMAIL_ADDRESS>
  * If you are running it from source, do instead:

        MIX_ENV=prod elixir --name<EMAIL_ADDRESS>-S mix phx.server

[os_mon] memory supervisor port (memsup): Erlang has closed
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed

The computer name is indeed not a valid host name. You need to change the computer name accordingly following these instructions: https://support.apple.com/guide/mac-help/change-computers-local-hostname-mac-mchlp2322/mac

I don't know if the root issue for @helloworldcoding is the same, but the recommendations on #1303 solved this problem for me without requiring I change my computer name: https://github.com/livebook-dev/livebook/issues/1303#issuecomment-1201556386


proposal: cmd/go: narrow 'mod download' default set

Context
go mod download is often used in build systems to "warm the cache" so subsequent operations don't need to fetch any more data. However, it can currently download more than expected. See #41431.
In https://github.com/golang/go/issues/41431#issuecomment-694232902, @bcmills suggests using go list -test -deps ./... instead. This would only fetch only the modules transitively imported by packages in the main module.
A similar suggestion of go list -test all was made recently in the Gophers slack.
Proposal
This issue proposes changing the default selection for go mod download to match go list all. This would make go mod download more intuitive for the cache-warming case which typically does not involve needing dependencies' test dependencies.
The current selection could be moved to a flag if necessary.

CC @jayconrod @matloob

For clarity, right now go mod download downloads the modules listed by go list -m all.
This proposal is to limit it to the modules supplying packages for go list all, which is a smaller set.
Note that we would still need to download go.mod files for something like the whole original set,
and those should still be reported in go mod download -json, in entries that would simply omit
the full-source links if the full source was not downloaded.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

This would break the cache warming case for when you only have go.mod and go.sum and none of the code, as I described in: https://github.com/golang/go/issues/45551#issuecomment-819044194
This case is common when building docker containers as it allows you to populate a module cache before you copy the code in. If the module cache state is solely dependent on the code (which is what go list all effectively does), then the cache is populated after the code is added in a new layer, and any code change will invalidate the layer and cause the cache to be thrown away.
It seemed like based on https://github.com/golang/go/issues/45551#issuecomment-819053637 that this was a supported case and would actually be improving in the future, but go list all when I only have go.mod and go.sum nets me no packages while go list -m all does appear to query them.

@zikaeroh, if you're setting up a fast Docker builder, you probably want to prime the build cache too — not just the module cache.
In that case, you would either want to go build $PACKAGES (where $PACKAGES is an externally-computed list of the packages that you expect to be relevant to the build), or go ahead and upload a baseline copy of the code to be build and run go test -c -o /dev/null ./... or similar.
Or, to put it another way: if you're ok with wasting some space on the build image (as you would be with go mod download today), then you're likely better off wasting that space on a redundant copy of the source code for your module instead of redundant copies of the source code for unused modules in your dependency graph.

if you're setting up a fast Docker builder, you probably want to prime the build cache too — not just the module cache.

In my experience, getting the 2 GB of dependencies my project needs (or about 1 GB non-test) is much, much more time consuming than the actual build itself.

In that case, you would either want to go build $PACKAGES (where $PACKAGES is an externally-computed list of the packages that you expect to be relevant to the build), or go ahead and upload a baseline copy of the code to be build and run go test -c -o /dev/null ./... or similar.
Or, to put it another way: if you're ok with wasting some space on the build image (as you would be with go mod download today), then you're likely better off wasting that space on a redundant copy of the source code for your module instead of redundant copies of the source code for unused modules in your dependency graph.

Docker can't work this way. The build context for docker is based on the current file system. I can't pre-copy a different version of the code into the container when building because there's only one version; the current one. If I make any change to the source code, any layer that depended on it is invalidated, hence why I only copy in go.mod and go.sum, as they don't change that often and provide the info required to pre-populate the cache (even if overzealous).
Note that I'm not "wasting space"; I build the binary, then copy it to another image (see: https://github.com/hortbot/hortbot/blob/master/Dockerfile). In this case, the only "waste" is the cache that'd on the builder (versus where the image runs), which is what I want to happen anyway. This is a common pattern when building docker images.

It can work that way: use an old version of your build stage as the base image for your newer builds. (Note newer docker versions can mount volumes as caches removing the need for layering gymnastics)
The "wasting space" refers to your build stage, which you are obviously caching to be able to reuse it. In most cases an old copy of your code + accurate dependencies takes up less space than the extended set of dependencies. The wasted space also translates to longer build times if your CI is stateless as it now needs to restore/save larger caches from a remote

If you believe it can be done, then I would appreciate some sort of example to look at; I'm having a hard time conceptualizing how that would work without shifting the caching responsibility to me or extra scripts (managing which parent image I'm using when that's encoded in Dockerfile, removing old items, etc) or breaking statelessness (some at-build volume). It seems like a shame to have to be managing all of this when it was so simple to achieve before following only docker's best practices documentation.

This is only about changing the default for go mod download with no arguments.
@bcmills, would go mod download all still get the old behavior?
Or maybe the default should be "what's listed in go.mod", which would work well with the new module pruning?

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc I understand go mod download all would retain the current behaviour of downloading when only go.mod/sum exists? I totally supprt @zikaeroh‘s case of fast docker builds without additional steps or mounting volumes (which you might not have on CI). Making this change would break all those builds but at least allow fixing them by adding all.

Or maybe the default should be "what's listed in go.mod", which would work well with the new module pruning?

This would not break anybody‘s builds (and even get rid of the parsing step?)- are there negative side effects?

This would not break anybody‘s builds (and even get rid of the parsing step?)- are there negative side effects?

If the definition of "what's listed in go.mod" is that it will download only the modules listed in go.mod and none of their dependencies (as "all deps and their deps" is the old behavior), then the effect of that change would be to change over-warming to under-warming, as the rest of the dependencies would be pulled in at some future step, probably during go build. This would cause some element of unpredictability based on what projects happen to import (and what their deps import), and probably will cause some confusing caching changes for existing Dockerfiles.
The only way to avoid the unpredictability would be to bump the module to 1.17 to enable lazy loading and the extra entries in go.mod (which I'm not sure all projects will do given the misconceptions/lack of clarity around what the version actually indicates; #46201, #30791).

@zikaeroh

The only way to avoid the unpredictability would be to bump the module to 1.17 to enable lazy loading and the extra entries in go.mod

Or, conversely: to only enable the new go mod download behavior for modules that specify go 1.17 or higher.

I like the idea of making the change contingent on the go version and defaulting to downloading only the modules listed explicitly in the go.mod file. That gives the ability to run go test ./... (which I expect is what most CI systems are running) after go mod download without the need to re-scan the entire package import graph.
I agree that go mod download all should continue to download all of the modules in go list -m all regardless.

OK, so it sounds like we are converging on changing the 'mod download' set for go.mod that use module graph pruning (go 1.17+), but this feature would ship in Go 1.18 since we are already in the Go 1.17 freeze.
Do I have that right?

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group


Added alternative option for importing modules into testing files

Addresses issue #12 by adding another option to importing a module into the test suite. If this isn't the best approach, please feel free to let me know why it isn't (not following how the previous approach would be the only ideal solution) 😄 .
Will get around to updating the guide as well in the next few days as well.

I think i'd prefer to keep this as-is.


OCPBUGS-17245: ports for bonds

display also ports under the link-aggregation property

Hi @upalatucci , does this PR include any visual change in the UI? Thanks!

/jira refresh

/jira refresh

/lgtm


Fonts not loading properly.

I just installed the template, and the default fonts are not loading properly.
The only thing that I did was to ignore deployment configuration when installing the template. Any ideas how to fix it?

Removing the font family from the extended configuration in the tailwind.config.ts file seems to fix it.

Hmmm.... Seems to be working in production: https://www.epicstack.dev

@kentcdodds I re-installed everything and looks like its working now... Maybe a random issue. Close it for now.


feat: Revise open source interests

This is in the context of the https://maps.datascience.wisc.edu/open-source/

Remove repeated use of 'open source' in subtopics/subinterests to avoid overuse, as the lists are short enough to all still be visbly under "Open Source".
Rename 'Open Source Sharing' to 'Maintainership' as the topics listed are ones that generally full under the responsibility of project maintainers to steer and be responsible for. Some, but not all, of these topics are also usually categorized as 'governance' issues.
Rename 'Open Source Culture' to 'Practices' as project 'culture' is usually more focused on the mechanics of community/contributor and maintainer interactions and the interactions of the broader community. 'Practices' places more of an emphasis on how projects implement different aspects of the broader concept of 'open source'.

Note that this is only focusing on the open source terms, as the others are found across multiple different maps and so this PR is just for those specific to the open source map.

It appears that you may have removed references to licensing and IP (perhaps I'm mistaken). If so, I think these are important topics that should be included.

@amegahed No, I just moved them to a different section.

(Rebased to resolve merge conflicts from 472cc8d4b12b38092ebbc6ec66cbe959f0df58f2)


⚠ Bofrost.at has degraded performance

In d9a87c2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1681 ms

Resolved: Bofrost.at performance has improved in 829d872 after 311 days, 14 hours, 31 minutes.


Update doc.md

Add destination folder to do_install_append(), without the {D} a system absolute path will be used.
External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

[ ] Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description
Please describe your pull request.
Thank you!

Re-submitted at https://github.com/mendersoftware/mender-docs/pull/1480


disable hermetic build for git-cloner & waiter

- rpm dependencies can't be met hermetically for now.
   It should be possible in future to do so.
- revert to using ubi-minimal

Signed-off-by: Satyam Bhardwaj<EMAIL_ADDRESS>rh-pre-commit.version: 2.3.0
rh-pre-commit.check-secrets: ENABLED

These changes are incorporated in #200


Use most recent version of DSE (6.8.37)

Updates DSE to latest released version 6.8.37

Replaced by https://github.com/k8ssandra/cass-operator/pull/568


Published 0.7.0

Updated dependencies

Do we want to resolve https://github.com/PistonDevelopers/image-png/pull/14 before publishing?

@nwin , @mbrubeck is it ok to publish a new version now?

Ok


Zoom bad interaction

Microsoft PowerToys version
v0.49.1
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Install zoom
Install powertoys
Init Zoom
Zoom Crashes
✔ Expected Behavior
Zoom does not crash and we can use the two programs simultaneously
❌ Actual Behavior
Zoom crashes
Other Software
Zoom 5.8.4 (1736)

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue #13984
Thanks for helping us to make PowerToys a better piece of software.

Duplicate of #13984


Events not returning

When calling pool.list Events are not always returning when tags are included in the filter.
This could just be an issue with how often I am calling (shouldn't be but a few times). Adding this issue here in case others are having a similar issue.
You can find my work here https://github.com/TimA314/JiYou
The call is in the useListEventsHook.

Looks like this is just a limiting issue. If sufficient time is given events will return even with tags. Closing this issue.


Does it work for Web Components (native, Polymer)?

It'd be nice if Web Components would be rendered.

I suppose yes, it is based on headless chrome

I think it is more complicated than that. Shadow DOM is the biggest issue if I'm not mistaken. Look into this: https://github.com/skatejs/ssr/blob/master/README.md and this: https://github.com/Polymer/polymer/issues/3955
I don't think SSR for web components is fully possible yet.

@motss do you have example of small website with components? I would like to run some tests

@stereobooster, here are two examples with web components:
https://github.com/Polymer/shop
https://github.com/PolymerElements/polymer-starter-kit

Still, haven't a chance to look into it. As far as I understand you can prerender Shadow DOM to actual DOM, like rendertron does, but to there is no easy way to prerender and rehydrate. Skate.js, for example, prerenders shadow dom and serializes it to JS


RISC-V32 MMU Implementation

We're currently looking at configuring a kernel build for NuttX for using 32 bit risc-v architecture.
I can see that there is a MMU implementation for 64-bit risc-v in arch/risc-v/src/common/riscv_mmu.h.
/* SvX definitions, only Sv39 is currently supported, but it should be
 * trivial to extend the driver to support other SvX implementations
 *
 * Sv39 has:
 * - 4K page size
 * - 3 page table levels
 * - 9-bit VPN width
 */

#ifdef CONFIG_ARCH_MMU_TYPE_SV39
#define RV_MMU_PTE_PADDR_SHIFT  (10)
#define RV_MMU_PTE_PPN_MASK     (((1ul << 44) - 1) << RV_MMU_PTE_PADDR_SHIFT)
#define RV_MMU_PTE_PPN_SHIFT    (2)
#define RV_MMU_VPN_WIDTH        (9)
#define RV_MMU_VPN_MASK         ((1ul << RV_MMU_VPN_WIDTH) - 1)
#define RV_MMU_PT_LEVELS        (3)
#define RV_MMU_VADDR_SHIFT(_n)  (RV_MMU_PAGE_SHIFT + RV_MMU_VPN_WIDTH * \
                                 (RV_MMU_PT_LEVELS - (_n)))
#define RV_MMU_SATP_MODE        (SATP_MODE_SV39)
#define RV_MMU_L1_PAGE_SIZE     (0x40000000) /* 1G */
#define RV_MMU_L2_PAGE_SIZE     (0x200000)   /* 2M */
#define RV_MMU_L3_PAGE_SIZE     (0x1000)     /* 4K */

/* Minimum alignment requirement for any section of memory is 2MB */

#define RV_MMU_SECTION_ALIGN        (RV_MMU_L2_PAGE_SIZE)
#define RV_MMU_SECTION_ALIGN_MASK   (RV_MMU_SECTION_ALIGN - 1)
#else
#error "Unsupported RISC-V MMU implementation selected"
#endif /* CONFIG_ARCH_MMU_TYPE_SV39 */

Is there any guidance or plans for implementing something similar for 32-bit? Or possibly someone has attempted something similar in the past?

64bit MMU is added by @pussuw. @pussuw could you give some hint?

The implementation I need is 64-bit only so at least I don't plan to do / will not do anything regarding riscv32.
But it should be pretty easy to extend the implementation for other SvXX types also (including Sv32). I intentionally wrote the driver keeping scalability for other architectures in mind.
In theory you only need to do the above definitions for Sv32 and the implementation "should work". Might be a good idea to check the macros outside of that #ifdef as well. Obviously this has never been tested with Sv32 but I use the Sv39 implementation daily and it works just fine.
When I did the implementation riscv32 and riscv64 had separate implementations, which were merged into one later. So the driver and the public interface might not be 100% compatible with Sv32 as-is.
The most important document obviously is the riscv privileged specification which tells you how the address translations work.
Please do keep in mind that when running riscv in supervisor mode you need some sort of SBI implementation. That implementation is out-of-scope here and you need to choose and integrate it yourself.


[2055] Add build new course endpoint

Context
Add an endpoint that the course creation steps can use to build a new course to validate it and retrieve relevant metadata (like the edit options) without persisting it.
Changes proposed in this pull request
Adds the endpoint.
Guidance to review
Nothing particular!
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Add "courses/build_new" endpoint to support course creation steps

@timabell rebased, tests seem green, merging soon :shipit:

:ship:


Deprecate a part of daal/onedal examples

The PR aims to exclude the following daal/onedal examples from OS and binary distributions:

make (all OSes)
MSVS solutions on Windows

./deploy/local/generate_win_solution.py  should be removed as well

./deploy/local/generate_win_solution.py should be removed as well

do we want to remove makefile generator as sell?

./deploy/local/generate_win_solution.py should be removed as well

do we want to remove makefile generator as sell?

yes, let's also clean it

/intelci: run

Agreed with @homksei that he will address the issues in testing.

/intelci: run


Add support for hex and rgba colors

Now the user can type when they want to change the color:
!todo color 1 success
!todo color 1 #f1f1fc
!todo color 1 rgb(255,255,0)
!todo color 1 rgba(255,255,0,75)

Awesome!! Thank you. :)

@all-contributors please add @gigili for ideas, code


[ci skip] adding user @username

Hi! This is the friendly automated conda-forge-webservice.
I've added user @username as instructed in #6.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #6

Sorry, I failed to change the example text when copying and pasting.


Expose lua version to ziglua module and rename

The build option version to set the Lua version to build with should be exposed publicly in ziglua. This would allow users of ziglua to utilize conditional compilation and target multiple versions of lua.
With this, I think version isn't as clear as it could be. Especially with the recent Luau support and LuaJIT coming soon.
I propose renaming the option to lang. This would make usage look like this
Running tests
$ zig build test -Dlang=lua51

Dependency
const ziglua = b.dependency("ziglua", .{
    .target = target,
    .optimize = optimize,
    .lang = .luau,
});

Variable
if (ziglua.lang == .lua52) {
    // do something
}

I agree that lang is better.  Could also be something like flavor or lua_flavor?  But lang is fine too.


Deployment with CMake

Hi!
I was trying to use the project in my source code (mainly by creating a conanfile.py).
I saw that there is a different repo which also tries to to do that.
Cause you are using cmake, i think it could be more "generic" to use CMake functions to deploy and generate an "importable" package. See https://cmake.org/cmake/help/v3.28/guide/importing-exporting/index.html#exporting-targets.
So the package could be used also with conan and cmake External.... Methods in the same way and the proper deployment (libs and headers) its up to the cwt-cucumber project.
Any doubts/concerns about that idea?

Hi there,
I honestly never used cmake's exporting targets. So if this works out for you and you're able to use it, I don't see any problem here.
Most of my projects use conan and in order to use cwt-cucumber as conan package I just create the package locally. I think this u meant with a different repo? (I didn't push it to the conan center or any other package center yet)

Thanks a lot, I just merged the branch and close this issue


Pass additional options to JVM (WIP)

Description
Allow passing additional java options to the startup command

Additional context and related issues
Users may need to set additional java options, e.g. using -Djavax.net.ssl.truststore=/path/to/truststore in combination with a volume for mounting a certificate bundle.

Release notes

( ) This is not user-visible or is docs only, and no release notes are
required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text:

Helm Chart
Allow passing additional java options to the startup command

If we go with this approach where the whole command is configurable.. which is fine by me .. we should update commit message, PR name, release notes suggestion, and also add relevant info to the docs.


Add tags variable to terraform

Pivotal Story
This ticket adds a new variable to allow a user of the module to add their own tags to the logs s3 bucket.
This implementation is modeled after terraform-aws-rds

Ah, an edge case I haven't thought of. I don't know but I'll run a case where that happens.

Well, the tests ran fine interestingly. I don't know what it does with it though. @eeeady

Writing tests!


fixed some issues with css and readme.md, added a timing function

Replaced fluid-container class with container-fluid,
fixed some plain text spelling in readme.md file including a file name,
added my name in the contributors file,
added my name in the contributors' list in the footer section

Added a timing function to display time on the page

Really good work! I like the fixes and I think the timer is a cool feature! Thanks for contributing


DeveloperGuide: Update Appendix A.1 Storage component

Developer guide's appendix A.1 storage component has a solution which links to a PR. This PR fails Travis CI build, because XmlAddressBookStorage does not implement abstract method backupAddressBook. Is the API method supposed to be written in Storage interface instead of AddressBookStorage interface? Because the latter has no real reason for a new backup method, since the logic implemented in StorageManager class does not require it.

@yamgent any thoughts?

I think you're right. ^^
XmlAddressBookStorage already has saveAddressBook(ReadOnlyAddressBook addressBook, String filePath) to specify saving to a different location.
As such, I think the API method should be written in Storage interface, and StorageManager implements it.

Is the API method supposed to be written in Storage interface instead of AddressBookStorage interface? Because the latter has no real reason for a new backup method, since the logic implemented in StorageManager class does not require it.

The method is supposed to be placed in AddressBookStorage, because backupAddressBook() is a method specific to address books, not to any storage in general.
Having a backupAddressBook() allows you to generate a backup file without having the caller to pass in the filepath of the backup file. Whether that is useful is debatable (depends on how you bring the project further), but at least that was the intention of the method.

because XmlAddressBookStorage does not implement abstract method backupAddressBook.

And yes you are right, I did not implement backupAddressBook for XmlAddressBookStorage. My bad. It should also saves to a backup file for the xml version (e.g. abcd-**backup.xml**).

The method is supposed to be placed in AddressBookStorage, because backupAddressBook() is a method specific to address books, not to any storage in general.

This is arguable since Storage has methods like readAddressBook(), saveAddressBook(ReadOnlyAddressBook), so having the concept of a address book in Storage seems ok (Also, Storage extends AddressBookStorage).
But I think we can leave this as that since we didn't have time to tidy up the Storage component :P  There are definitely better ways to improve the design.

After having a clearer view of what this is supposed to do from Wang Leng, I think for this issue we should do something like: Instead of having a backupAddressBook() method, we can have a backupData() to be implemented in the Storage interface. Since other components access the Storage component of the program through Storage, it's necessary that Storage interface exposes a method to backup data.

Having a backupAddressBook() allows you to generate a backup file without having the caller to pass in the filepath of the backup file. Whether that is useful is debatable (depends on how you bring the project further), but at least that was the intention of the method.

I agree that this is debatable. The backupData() method in StorageManager can look something like:
public void backupData() {
    abStorage.saveAddressBook(abStorage.readAddressBook(), BACKUP_FILEPATH);
}

or
public void backupData() {
    abStorage.backupData();
}

I think both are fine as of the current design.

Should be resolved as #594 is updated.


Fixed TheGamesDB scraper by adding a document tree segment 'scrapers' to the config file

This allows the user to pass an API key for the gamesdb scraper. It works by letting users add scraper configurations to es_systems.cfg (maybe not the right place?)
Here's an example of what the segment looks like:
<scrapers>
	<scraper>
		<name>gamesdb</name><!-- only valid scraper name atm -->
		<path>api.thegamesdb.net/Games/ByGameName</path><!-- currently unused -->
		<APIKey>REDACTED/APIKey>
	</scraper>
</scrapers>

The idea is try to make scrapers as configurable as possible, but at the moment the only valid name is gamesdb and the only used child element of a scraper is <APIKEY>. The code I have works, but obviously this needs to be cleaned up. For one thing, ratings, developers, publishers and genres aren't yet supported. For another, it's a long way from truly configurable. But hopefully this is a good enough starting point for some feedback.
Update
Basic support for scraping developers, publishers and genres has been added. Currently, there doesn't appear to be a way to access ratings through the TheGamesDB API. Fetching each requires a minimum of 3 synchronous API requests, at the moment. I expect that I'll want to make those asynchronous - similar to the image/thumbnail fetches - in the future. But it's a bit more complex than those because the fetched information is share-able between all games scraped with that scraper.
But I digress. Next up is refining the configuration files a bit.

I guess this shoulda been a draft :P

Hi there, I'm currently the lead dev behind TGDB, just a small comment about this PR, we're not handing out keys to individual users, since we expect you to use the public key, since the key is limited per IP, so you can have as many users using it as you'd like. it also allows us some basic statistics on how and by which project the requests are made. Note, public key doesn't need to be obscured, since we don't expect malicious use, nor do we have an hard to meet requirement to obtain one.
P.S, Ideally the project owner would use their own key, but that's not set in stone.

Unfortunately I think the project owner has left this project.
Good to hear that I can just put my public key in there, thanks for letting me know.


Azure Go SDK Service Bus / Event Hubs idle connection bug possibly impacting Keda

Report
This is a heads-up that a bug was identified in github.com/azure/go-amqp, the shared library for the Azure SDK for Go Service Bus and Event Hubs SDKs (Keda only uses the Service Bus SDK from here it seems).
I'm a Dapr maintainer and we have observed this issue. This bug occurs when a connection has been idle (server idle timeout is 10 minutes) and then an attempt is made by the SDK to close the connection. This closing operation can take 30 seconds. In the case of the azservicebus SDK an attempt to send a message (for example) after a connection has become idle and therefore is closed (and recreated) unnecessarily stalls for 30 seconds.
Depending on the frequency in peek operations of the Keda scaler this might impact Keda! For that reason I'm letting you know of this issue. If this impacts Keda most likely the behavior would be the following:
If a topic or queue has become idle (no peek within 10 minutes), the next peek operation likely will force the connection to close - and this closing operation will take 30 seconds before the connection is recreated and peek is performed. This could potentially mean that a scale from zero would occur 30 seconds later than expected.
However, if the peek frequency of the Keda scaler is a lot more frequent, I believe that would prevent the queue from becoming idle and as a result this problem would not be encountered.
On Monday https://github.com/Azure/go-amqp/releases/tag/v1.0.5 will be released to address this, and on Tuesday https://github.com/Azure/azure-sdk-for-go/tree/sdk/messaging/azservicebus/v1.6.1 (or maybe the version number will be different).
I would encourage Keda to upgrade the Service Bus scaler with these library versions.
Expected Behavior
N/A
Actual Behavior
N/A
Steps to Reproduce the Problem
Not tested / Observed.
Logs from KEDA operator
N/A
KEDA Version
2.13.1
Kubernetes Version
Other
Platform
Microsoft Azure
Scaler Details
Azure Service Bus
Anything else?
No response

@berndverst thanks a ton for the information!


dynamic_stitch op gpu version

Issue(#7251)
Have implemented the GPU version dynamic_stitch. all tested passed locally.
use the script do a quick benchmark.
Env:
Based TF Version: r1.3
cuda: 8.0
cudnn: 5.1
GPU: Tesla M40
Result:
CPU Version: Time 1000: 40.180424s
GPU Version: Time 1000: 5.095576s
The thought reference @MycChiu code, thanks for great jobs.
Thanks @girving for precious suggestions.

Can one of the admins verify this patch?

@ekelsen fixed it. thanks.

Jenkins, test this please.

@ekelsen Is there someone to call Jenkins to test this PR?

I don't think I can do it either

Jenkins test this please

Ping @benoitsteiner ?

Is there someone to test and merge this PR?

@tensorflow-jenkins test this please

@nolanliou I'm sorry this was not tested earlier. I'm oncall this week and will make sure we get it tested etc.

@nolanliou It looks like you are missing a registration:
2017-08-08 20:13:55.937575: I tensorflow/core/kernels/logging_ops.cc:79] Hello[3]
.2017-08-08 20:13:56.003997: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1042] Creating TensorFlow device (/gpu:0) -> (device: 0, name: Tesla K80, pci bus id: 0000:00:0a.0)
2017-08-08 20:13:56.089320: E tensorflow/core/common_runtime/executor.cc:643] Executor failed to create kernel. Not found: No registered 'DynamicStitch' OpKernel for GPU devices compatible with node y_shape = DynamicStitch[N=2, T=DT_INT32](stitch_idx0, i, x_shape, stitch_val1)
(OpKernel was found, but attributes didn't match)
.  Registered:  device='GPU'; T in [DT_INT64]
device='GPU'; T in [DT_COMPLEX128]
device='GPU'; T in [DT_COMPLEX64]
device='GPU'; T in [DT_DOUBLE]
device='GPU'; T in [DT_FLOAT]
device='GPU'; T in [DT_HALF]
device='CPU'; T in [DT_STRING]
device='CPU'; T in [DT_BOOL]
device='CPU'; T in [DT_COMPLEX128]
device='CPU'; T in [DT_COMPLEX64]
device='CPU'; T in [DT_DOUBLE]
device='CPU'; T in [DT_FLOAT]
device='CPU'; T in [DT_HALF]
device='CPU'; T in [DT_INT8]
device='CPU'; T in [DT_UINT8]
device='CPU'; T in [DT_INT16]
device='CPU'; T in [DT_UINT16]
device='CPU'; T in [DT_INT32]
device='CPU'; T in [DT_INT64]
 [[Node: y_shape = DynamicStitch[N=2, T=DT_INT32](stitch_idx0, i, x_shape, stitch_val1)]]

@rmlarsen Should we support the DT_INT32 for gpu version? I checked some Ops and there are no DT_INT32 registration.

Maybe it's necessary, I have updated the code.

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

@rmlarsen could you help to check what's going on the MacOS CPU Tests? I cannot see the log, thanks.


0.10.x removed extract-text-webpack-plugin?

I edit the nuxt.config.js:
build: {
        loaders: [
            {
                test: /\.scss$/,
                loader: ExtractTextPlugin.extract({
                    use: ['vue-style-loader', 'css-loader', 'sass-loader']
                })
            }
    ],
     plugins: [
            new ExtractTextPlugin({
                filename: 'styles.css'
            })
     ]
}

but not work

Can you explain more about what you are trying to do?

After npm run build, The style in components  is built into a .js file
I want to build the style in components into a .css file.

#471 #478

Just found this nice article that shows possible improvements of inlining css :)
https://www.smashingmagazine.com/2017/04/guide-http2-server-push/

@pi0 Just for a better understanding, the article you mentioned says about inlining CSS: "The poison pill we swallow when we do this, however, is that the inlined content can’t be efficiently cached."
So am I right to assume, that the advantage of inlining is greater than the ability to cache a bigger CSS file like bootstrap for example?


[Frontend][TFlite] use qnn helper function in softmax

Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
Use qnn helper function in softmax to make calculation logic more centralized.

LGTM too

Thanks @u99127 @wyc-ruiker @inadob !


shellenv: recommend .bash_profile

Fixes #7516

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Note that Ubuntu (and I assume WSL Ubuntu?) uses ~/.profile by default, and not ~/.bash_profile. If you create a ~/.bash_profile from scratch, you effectively disable any configuration that the user has in ~/.profile, including the system defaults, which can lead to unexpected behaviour.

I'm fine with recommending the same thing consistently. I noticed more references to bash_profile than .profile: hence the change.

Work in progress PR: https://github.com/Homebrew/brew/pull/7550
Needs more testing.


Use tabs to delimit columns.

This avoids the columns breaking when an environment variable value contains an '='.

Looks nice. Thanks.

Sorry, on further testing this isn't doing what is intended. It's using literal t character, not tabs, working on a fix for this now.

Ok. Let me know.


Huobi: conclude host parameters inside initServices

Make BitVC work again via exchangeSpecificParams use_bitvc=true. This must have broken with the introduction of initServices.

Merged directly as only a tiny change.


Using The Default Lsp Config

Now I don't understand how this plugin works completely so excuse my ignorance, but if I want to keep my Lsp config separate from the navigator config, specifying only this in my navigator config
require("navigator").setup({ 	debug = false, -- log output, set to true and log path: ~/.cache/nvim/gh.log 	width = 0.75, -- max width ratio (number of cols for the floating window) / (window width) 	height = 0.3, -- max list window height, 0.3 by default 	preview_height = 0.35, -- max height of preview windows 	border = { "╭", "─", "╮", "│", "╯", "─", "╰", "│" }, -- border style, can be one of 'none', 'single', 'double', 	-- 'shadow', or a list of chars which defines the border })
Will this alter anything in my lsp config? Also what functionality will I lose (if any)?

suppose you have your own config for pylsp, you can passed in to navigator.
pylsp_cfg ={youconfig}
require'navigator'.setup({
  lsp={
   pylsd=pylsp_cfg
  }
})

If you have your own keymaps and other setups defined in on_attach, you can hook your on_attach in navigator config.
Also, you can move your key definition blocks to the keymaps field and it will override default maps.
One of my earlier goal for this plugin is help remove chunky lsp-config setup. In fact, you do not need to do much and the plugin will setup everything for you.
You can take a look of
attach.lua
client.lua
And other files in lspclient folder.

Sorry forgot to close this, took a look and everything worked out thanks.


Updated new features in Readme with sample workflows

Added workflow samples for using the new env variables to enable traceability features for dockerfile, manifests, helmcharts and acr.

V1.2 has been updated, so the new features are available in the action. I can now merge this PR once it is approved, so that users can see the new env-variables/ labels expected for traceability in the README.


Added more visualisations to Hedging using Cryptocurrencies Model

Explanation of the Additional Visualizations I added:
Moving Averages: Plots showing the 50-day and 200-day moving averages for S&P 500 and Bitcoin.
Bollinger Bands: Plots showing Bollinger Bands for S&P 500 and Bitcoin, indicating price volatility.
Comparative Close Prices: Line plots comparing the closing prices of major stock indices and cryptocurrencies.
Volatility Comparison: Bar chart comparing the volatility of stock indices and cryptocurrencies based on their daily returns.

Resolves #120

Hi  @Akshat111111 , Please assign labels GSSOC  and level 2 to this PR else it wont update in Leader board as mentioned in latest GSSOC guidelines.


Upgrade legacy clients to dotnet v9

Description
.net9 has standard time support until May 12, 2026, but we should take the time to upgrade and not wait for .net 10.
Additional Information
.NET Core Support lifecycle
Container Patching
Tasks

[ ] Update base images in the dockerfile for .net9
[ ] Bump all projects; src and test, to .net9
[ ] Update any build pipelines to support .net9
[ ] Update any github workflows with .net9
[ ] Check if we need to change anything in SonarCloud

Acceptance Criterias

[ ] Legacy clients application is built with .net9 tooling and runs on .net9

This package should keep targeting .net8 as long as no Apps are upgraded to .net9. It's possible to target both .net8 and .net9, but I'm not sure .net9 is important enough to do the work. We can discuss it in refinement.


Tensorflow 2.0 alpha/beta performance

System information
Google Colab system (GPU mode) with TensorFlow 2.0 and Python 3.
Describe the current behavior
Using TensorFlow 2.0 beta (pip install) on a CNN-RNN (two bidirecional lstm), is taking about 25 minutes to complete a single epoch (training).
Describe the expected behavior
The curious thing is that when using the same code, same file/platform (google colab) but with the Alpha version of the TF 2.0 (pip install), the same epoch takes around only 70 seconds.
Other info / logs
Everything is the same in both scenarios and also the identification of the GPU:

Found GPU at: / device: GPU: 0

Another thing I noticed is that the alpha warning disappeared:

W0608 02:52:12.500632<PHONE_NUMBER>58816 tf_logging.py:161] <tensorflow.python.keras.layers.recurrent.UnifiedLSTM object at 0x7f86d4231da0>: Note that this layer is not optimized for performance. Please use tf.keras.layers.CuDNNLSTM for better performance on GPU.

Maybe it has something related?

@arthurflor23  Refer to #29506

Sorry for the performance regression, we are aware of this issue, and trying to address it right now. Please monitor on https://github.com/tensorflow/tensorflow/issues/29506 which is the same issue.


python3Packages.connect-box: 0.2.8 -> 0.3.0

Motivation for this change
Update to latest upstream release 0.3.0
Change log: https://github.com/home-assistant-ecosystem/python-connect-box/releases/tag/0.3.0

Related Home Assistant change: -
Target Home Assistant release: current (only dependency update, no code changes

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 124496 run on x86_64-linux 1

2 packages built:

python38Packages.connect-box
python39Packages.connect-box

Result of nixpkgs-review pr 124496 at 4b6ff1c9 run on aarch64-linux 1

2 packages built successfully:

python38Packages.connect-box
python39Packages.connect-box


Honor branch specified in .gitmodules

Previously switched to master branch on each build. Fixes #14082

Nice catch! Thank you!

Landed in https://github.com/ariya/phantomjs/commit/936ba7a922365c9856541154925d5defc55c2cc5


It is necessary to highlight the names of fields that contain UUID in color

Is your feature request related to a problem? Please describe.
With the new standard RFC 9562 "Universally Unique IDentifiers (UUIDs)" coming into force, UUIDv7 are becoming widely used as keys in databases. Functions that generate UUIDv7 appear in the DBMS.
System analysts need to quickly find fields containing UUIDs of any version in order to use these fields as primary or foreign keys.
Describe the solution you'd like
Please highlight the names of such fields in color.
For details, see paragraphs 15 and 6 of the article "Specification of unique UUIDv7 identifiers for database and distributed system keys according to the new RFC9562 standard".

Спецификация уникальных идентификаторов UUIDv7 для ключей баз данных и распределенных систем по новому стандарту RFC9562

If there is an index (for single column or composite): for the light theme - strong blue highlighting #0043ce rgb(0,67,206), and for the dark theme - very light blue #85b1ff rgb(133,177,255).
If there is no index: for the light theme - pure orange highlighting #f34900 rgb(243,73,0), and for the dark theme - light orange #ff9766 rgb(255,151,102).
These colors are colorblind-friendly and contrasting.
A field in a database table may contain not only a UUID, but also a suffix. Such fields must also be highlighted.


Won't start after update

Hi, I've just updated Datalens and it won't correctly start after update. GUI opens but w/o projects with:
An unexpected error has occurred. Try to refresh the page in a few moments.
ECONNREFUSED
{
"title": "Error",
"description": "An unexpected error has occurred. Try to refresh the page in a few moments."
}
Also found in startup logs:
datalens-pg-us               |
datalens-pg-us               | PostgreSQL Database directory appears to contain a database; Skipping initialization
datalens-pg-us               |
datalens-pg-us               | 2024-12-11 09:14:26.300 UTC [1] FATAL:  database files are incompatible with server
datalens-pg-us               | 2024-12-11 09:14:26.300 UTC [1] DETAIL:  The data directory was initialized by PostgreSQL version 13, which is not compatible with this version 16.6.
datalens-pg-demo-connection  |
datalens-pg-demo-connection  | PostgreSQL Database directory appears to contain a database; Skipping initialization
datalens-pg-demo-connection  |
datalens-pg-demo-connection  | 2024-12-11 09:14:26.441 UTC [1] FATAL:  database files are incompatible with server
datalens-pg-demo-connection  | 2024-12-11 09:14:26.441 UTC [1] DETAIL:  The data directory was initialized by PostgreSQL version 13, which is not compatible with this version 16.6.
datalens-pg-us exited with code 1
datalens-pg-demo-connection exited with code 1
Seems could be problem because of new PostgreSQL?
Pls. find startup log attached.
Many thanks in advance.
dl-startup-log-11dec24-1.txt

@sgialexa, hi! Could you provide us more details about version of release https://github.com/datalens-tech/datalens/releases ?

It's the latest - I've updated today with
docker compose down
git pull
docker compose up

Hi @sgialexa, you can downgrade your postgres version in compose file to version 13 for pg-us container or make upgrade
// stop compose deployment
docker compose stop

// run old postgres server
docker run -d --name pg-us-old -v ./metadata:/var/lib/postgresql/data postgres:13-alpine

// make dump
docker exec pg-us-old pg_dump -d us-db-ci_purgeable -U us > dump.sql

// stop and remove old postgres server
docker stop pg-us-old && docker rm pg-us-old

// mv current postgres metadata to different folder
mv ./metadata ./metadata-old

// up compose deployment
docker compose up -d

// restore backup to new version from dump
docker compose exec pg-us pg_restore -U us -v -d us-db-ci_purgeable < ./dump.sql

// up all compose services
docker compose up -d

Please do not remove ./metadata-old folder before you check the entire system after recovery

Hi @goshander, unfortunately this doesnot work. I've got only OpensourceDemo in Workbooks and Collections.
I had to remove containers and images because of
Error response from daemon: Conflict. The container name "/datalens-pg-us" is already in use by container "7629ea1973f4adad3d0786c5767f03a242aecde74d538625524a698728eec6b9". You have to remove (or rename) that container to be able to reuse that name.
So basically I started old postgress server, created a dump, git pull, docker compose up (got error), removed all containers and images, docker compose up, restore db backup, docker compose up...


[LogicalTrees] Trait Primary Constructor

As shown in https://github.com/DavidDudson/paradise/commit/2076604266f381826ef8816aaade719ee7c4f2e8 (sbt test:compile fails)
The problem is g.Empty Tree is passed in: https://github.com/scalameta/paradise/blob/2.11.8/plugin/src/main/scala/org/scalamacros/paradise/converters/LogicalTrees.scala#L485
What is the solution to this problem? Do we make Def.Trait's PrimaryCtor Optional in Meta? Or is there some other way to solve this issue?

@dveim Could you comment on this?

Looks like this issue is fixed in https://github.com/dveim/paradise/commit/1d9a66fa564df312b88bf8b9057b31f1382715ed. Going to make PR soon.
As far as I understand, changing scalameta's API would require big effort. Another solution for such cases with EmptyTree -- use some zero analogue for particular tree.

@xeno-by can this issue be closed now, If I recall correctly that PR was merged?

Yes, that's right. Thanks!


Subdomain limit of 50

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d3f0vp9f8i81gz
Region
us-east-1
Step
Domain management
Status
Failed
Issue or question
I use AWS Amplify for managing my app (https://pickleplanner.com), and I love it.  Every time a customer signs up they get their very own web address (e.g. https://my-club-name.pickleplanner.com).  My latest customer just tried to sign up but received an error because it exceed the 50 subdomain limit (that I was unaware of).  Please help me to get this subdomain limit increased, I'll do anything.  Thanks.
Error message
Too many sub domains requested, the maximum allowed in your account is 50
Additional information
Feel free to call me at<PHONE_NUMBER>

I seemed to have found the place to request an increase to the quota.  https://us-east-1.console.aws.amazon.com/servicequotas/home/services/amplify/quotas/L-A6716586

Hi @scottmanny 👋🏽 thanks for raising this question. There is a default limit of 50 subdomains for each domain used in a region. You can proceed to request a limit increase here if you have not already.
For additional documentation on our service limits, feel free to reference our Amplify service quotas. Thank you!


Pickup latest release from CJson

Issue #, if available:
Pick up change from https://github.com/DaveGamble/cJSON/releases/tag/v1.7.16
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch and project coverage have no change.

Comparison is base (5c736d5) 82.23% compared to head (977ddda) 82.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   82.23%   82.23%
=======================================
  Files          52       52
  Lines        5641     5641
=======================================
  Hits         4639     4639
  Misses       1002     1002

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ability to configure smooth jump speed when smooth scrolling is enabled

Hello,
I like to feel how below or above the next match of a find result. Without smooth scrolling, jumps between found matches are instant. Smooth scrolling breaks this and makes you feel it's jumping up or down; but it is too much fast that you cannot perceive the difference between a 300 lines of jump and a 3000 lines of jump.
If there were a configuration for it, I would slow down the smooth jump speed so I would perceive the distance.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


first PR for cleaner data team A

initial .ipynb for cleaner data,
CSV uploaded.

Good first confirmed police incident dataset


[SQL] Add support for FLOAT64 to DataCatalogTableProvider

Support FLOAT64

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.


A ENOENT system error occurred

I tried to create the jupyter datascience-notebook with all defaults
Command 'Dev Containers: Add Dev Container Configuration Files...'
resulted in an error
A system error occurred (ENOENT. no such file or directory, open

Forgot to mention that no devcontainer.json was created.

I can reproduce, with slightly more error output from VS Code but not enough to be of much help—I filed microsoft/vscode-remote-release#9344 for the unhelpful failure mode.
I think this is a bug in the tooling for option value substitution, or else maybe we are supposed to encode option placeholders in a different way than ${templateOption:baseVariant} for additional files like the Dockerfile as opposed to devcontainer.json…
The spec says (emphasis mine):

A supporting tool will parse the options object provided by the user. If a value is selected for a Template, it will be replaced in the files (within the sub-directory of the Template).

So substitution should work in all files, but I have not yet found any example in specs or another template in the wild that uses options in places other than the devcontainer.json.
Triage Investigation
I installed the current release of the devcontainer CLI reference implementation, and a rudimentary example with only a devcontainer.json works fine:
$ devcontainer templates apply \
    -t ghcr.io/devcontainers/templates/debian \
    -a '{"imageVariant": "buster"}'
[1 ms] @devcontainers/cli 0.55.0. Node.js v21.5.0. darwin 22.6.0 x64.
{"files":["./.devcontainer/devcontainer.json"]}

but ours breaks for me, seemingly at the point of handling the Dockerfile because after the error I'm left with the expected .devcontainer/devcontainer.json but no sibling Dockerfile is written:
$ devcontainer templates apply \
    -t ghcr.io/devcontainers-community/templates/jupyter-datascience-notebooks \
    -a '{ "baseVariant": "minimal-notebook", "imageVariant": "latest" }'
[3 ms] @devcontainers/cli 0.55.0. Node.js v21.5.0. darwin 22.6.0 x64.

✂✂ SNIP HERE output of what looks to be the entire minified JS of the CLI app ✂✂

TypeError: Cannot read properties of undefined (reading '0')
    at /usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:45532
    at Array.every (<anonymous>)
    at n (/usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:45522)
    at o (/usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:45603)
    at /usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:46030
    at Set.forEach (<anonymous>)
    at s (/usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:46019)
    at /usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:45627
    at i (/usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:53461)
    at /usr/local/Cellar/devcontainer/0.55.0/libexec/lib/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:11:54533

Node.js v21.5.0

I'm not versed in Node.js debugging, I guess next steps would be giving it a source map for that dist version, or just go the CLI source repo and try creating a failing test case.

Dug further, it's the same underlying issue as this: https://github.com/devcontainers/cli/issues/699#issuecomment-1857139272
Different code path (we're not failing on Features), but same issue with the tar library choking on an archive containing spurious hard links. I followed the same exercise as that comment, and our published TAR looks like this:
$ tar --list -v -f ds-notebooks.tar
-rw-r--r--  0 runner docker   1070 Aug 17 08:23 devcontainer-template.json
drwxr-xr-x  0 runner docker      0 Aug 17 08:23 .devcontainer/
-rw-r--r--  0 runner docker   1600 Aug 17 08:23 .devcontainer/devcontainer.json
-rw-r--r--  0 runner docker    351 Aug 17 08:23 .devcontainer/Dockerfile
hrw-r--r--  0 runner docker      0 Aug 17 08:23 .devcontainer/Dockerfile link to .devcontainer/Dockerfile
hrw-r--r--  0 runner docker      0 Aug 17 08:23 .devcontainer/devcontainer.json link to .devcontainer/devcontainer.json

Not sure if there is something we can do to prevent this from happening in the build + deploy process, otherwise a fix would be waiting for upstream.

Thanks for your help. Will try and wait for a fix.

@jimmyseow An unglamorous workaround in the meantime is to manually copy this repo's .devcontainer folder to your project, and edit the Dockerfile to use datascience-notebook – the FROM line is currently the only place where there is any template variable you'd need to fill in by hand.

Same issue here sadly. Error: ENOENT: no such file or directory, open 'C:\Users\username\AppData\Local\Temp\tmp-output-dir-1711239583039.devcontainer\devcontainer.json'


composer: Move check for sequence action size to collectors

Currently in composer. When a sequence action is sent from Collector to the Executor. It is added to a bundle. Before adding to the bundle, we check if the sequence action is larger than the max size permitted in a bundle which is set by https://github.com/astriaorg/astria/blob/main/crates/astria-composer/local.env.example#L48 . If a sequence action is larger than the max size permitted in a bundle, the sequence action is dropped in the executor. This is bad UX as we don't have any way to communicate back to the user that their tx is dropped currently because it is too large.
We could probably just move the sequence action size check in collectors which can reject the rollup tx before even sending it to the Executor.

This issue was closed because it was stale


Updated keyboard support

This PR updates keyboard support for moving the crop area in react-easy-crop using the arrow keys, addressing issue https://github.com/ValentinH/react-easy-crop/issues/574.

Users can now hold the shift key when moving the crop area using the arrow keys, in order to move it by a smaller amount.
Moving the crop area using the arrow keys no longer causes unintended scrolling.

Thank you for this PR!


Fix crash if biome monster spawn list is empty for some reason. (Usua…

…lly due to someone emptying it with craftweaker of similar)

Oops, put the closing } in the wrong place 🤦♂
Should be fixed 😄


Update acrylic.md - correction of the accent-based acrylic brushes name

Correction for the name of brushes about "acrylic using the user-specified accent color". I've picked the correct name from generic.xaml, SDK 16299.

@mijacobs: PR passes review checklist. Please evaluate for technical accuracy.

It seems that the file was moved from windows-apps-src/style/acrylic to windows-apps-src/design/acrylic. Should I open a new PR for new file?


Update Spec for Explainers

Provides an update to the spec to allow explainers to be specified.
As this creates a new level in the spec will need changes to existing code/yaml once agreed.

This change is

/assign @ellis-bigelow

Can I get your review on this explainer spec as broadly discussed in the weekly meeting yesterday.
@ellis-bigelow @rakelkar @animeshsingh @yuzisun
As we agreed Explainers can be canaried and also should not interact with min/max replicas specified for predictors a new level in the spec hierarchy has been created.

From conversations with @ellis-bigelow  I've updated to make the spec backwards compatible for now. So we can move to breaking changes in v1alpha2.

This looks good to me Clive!
Would love consensus from the group and then we can merge.

Looks good to me - is it fair to assume that when the explainer is instantiated the model URI will be passed to it? Will be interesting to see this evolve with v1alpha2 :)

@rakelkar  Yes the predict endpoint will be passed so "black box" explainers can access the internal service point to make calls.

I wonder if we should decide a set of environment variables passed to all
components like:
Predict uri
Storage uri
Explain uri
Etc.
That way, any custom spec will have the power to utilize the graph however
it needs.
On Mon, Jul 15, 2019, 10:54 PM cliveseldon<EMAIL_ADDRESS>wrote:

@rakelkar https://github.com/rakelkar Yes the predict endpoint will be
passed so "black box" explainers can access the internal service point to
make calls.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/kfserving/pull/237?email_source=notifications&email_token=AATXLCD6J6FDAP23OSC5LXLP7VPCRA5CNFSM4IBEAUG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7Y4UQ#issuecomment-511675986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATXLCCXT3FYUDCYVEXNVZDP7VPCRANCNFSM4IBEAUGQ
.

Sounds reasonable to me...
On Mon, Jul 15, 2019, 11:25 PM Ellis Bigelow<EMAIL_ADDRESS>wrote:

I wonder if we should decide a set of environment variables passed to all
components like:
Predict uri
Storage uri
Explain uri
Etc.
That way, any custom spec will have the power to utilize the graph however
it needs.
On Mon, Jul 15, 2019, 10:54 PM cliveseldon<EMAIL_ADDRESS>wrote:

@rakelkar https://github.com/rakelkar Yes the predict endpoint will be
passed so "black box" explainers can access the internal service point to
make calls.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/kubeflow/kfserving/pull/237?email_source=notifications&email_token=AATXLCD6J6FDAP23OSC5LXLP7VPCRA5CNFSM4IBEAUG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7Y4UQ#issuecomment-511675986
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AATXLCCXT3FYUDCYVEXNVZDP7VPCRANCNFSM4IBEAUGQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/kfserving/pull/237?email_source=notifications&email_token=AA2CTBKFGXXQVXJMEQ6IZELP7VSWDA5CNFSM4IBEAUG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ72V4Q#issuecomment-511683314,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2CTBOBCJNEZ3IWD64QYFDP7VSWDANCNFSM4IBEAUGQ
.

@rakelkar Yes the predict endpoint will be passed so "black box" explainers can access the internal service point to make calls.

How do we define "black box" eplainers here?

@ellis-bigelow @cliveseldon
its looking good to me, though any chance we can get a diagrammatic representation of the spec tree? where we settle for now, and what will change with alpha2? Will make these conversatoins much smoother

Will also be good to get an example of whitebox.. that might help
inform/influence #222
On Tue, Jul 16, 2019, 10:42 PM Animesh Singh<EMAIL_ADDRESS>wrote:

@ellis-bigelow https://github.com/ellis-bigelow @cliveseldon
https://github.com/cliveseldon
its looking good to me, though any chance we can get a diagrammatic
representation of the spec tree? where we settle for now, and what will
change with alpha2? Will make these conversatoins much smoother
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/kfserving/pull/237?email_source=notifications&email_token=AA2CTBLVZORA3R2OEWRS35LP72WNXA5CNFSM4IBEAUG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DDCDA#issuecomment-512110860,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2CTBKQACPD4UH4OHQ4PJTP72WNXANCNFSM4IBEAUGQ
.

@animeshsingh
Probably easiest to see in an example. For v1alpha1 for an sklearn model with explainer then non-breaking change it will be like:
apiVersion: "serving.kubeflow.org/v1alpha1"
kind: "KFService"
metadata:
  name: "sklearn-iris"
spec:
  default:
    sklearn:
      modelUri: "gs://kfserving-samples/models/sklearn/iris"
    explain:
      alibi:
        type: "anchor_tabular"
        savedExplainerUri: "gs://kfserving-samples/models/sklearn/iris_explainer"

The v1alpha2 proposal is to change to:
apiVersion: "serving.kubeflow.org/v1alpha1"
kind: "KFService"
metadata:
  name: "sklearn-iris"
spec:
  default:
    predict:
      sklearn:
        modelUri: "gs://kfserving-samples/models/sklearn/iris"
    explain:
      alibi:
        type: "anchor_tabular"
        savedExplainerUri: "gs://kfserving-samples/models/sklearn/iris_explainer"

@animeshsingh whitebox should be the same. Blackbox explainers need to be autowired with the predict URI while whitebox need the model URI. Both are available to kfserving at reconcile time.

Can you draft an example of what that might look like? How would you expect
the model initializer to kick in?
On Wed, Jul 17, 2019, 7:46 AM cliveseldon<EMAIL_ADDRESS>wrote:

@animeshsingh https://github.com/animeshsingh whitebox should be the
same. Blackbox explainers need to be autowired with the predict URI while
whitebox need the model URI. Both are available to kfserving at reconcile
time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/kfserving/pull/237?email_source=notifications&email_token=AA2CTBKXISF3NNIJOZKRI4DP74WGBA5CNFSM4IBEAUG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2EOLEY#issuecomment-512288147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2CTBMPLX2NOHSCXX63AHLP74WGBANCNFSM4IBEAUGQ
.

@rakelkar
The modelInitializer would work identically to how it works for predictors. The Alibi explainer takes a command line arg for the savedexplainerUri location in the same way as our built in predictors do for modelUri. So the same mutation logic can be run.

@rakelkar, if we detect a storageURI for any spec (explain/predict/preprocess), we should mount up that DIR and get it local.

Can we get at-least one sample - specifically for a feature like this, that gives the path for testing?

There can only be an example once the controller-manager is updated which will need to be done after this is merged. We could create a example based on the existing example in https://github.com/kubeflow/kfserving/tree/master/docs/samples/explanation/income but the yaml would be unusable until the controller-manager work is done.

Think this is ready to merge.

/lgtm
/approve


[Bug]: In the desktop version, if the Oracle schema library name is in lowercase letters, the database cannot be opened.

ODC version
ODC423
OB version
Oceanbase2277
What happened?
In the desktop version, if the Oracle schema library name is in lowercase letters, the database cannot be opened.

What did you expect to happen?
The web version can open this table, just like the web version
How can we reproduce it (as minimally and precisely as possible)?
chat privately
Anything else we need to know?
No response
Cloud
No response

pass


fix: add HTTPRoute controller for watching HTTPRoute to enqueue KongUpstreamPolicy needing to update ancestor status

What this PR does / why we need it:

Add a controller for watching HTTPRoute to watch HTTPRoutes if ancestor statos of related KongUpstreamPolicy.
Removes the dependency of HTTPRoute of KongUpstreamPolicy.
Which issue this PR fixes:

fixes #5729
Special notes for your reviewer:

We may need to backport it to 3.1.x.
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

I think we should add an envtest in which we ensure that KongUpstreamPolicies used with Services and Ingress work as expected when Gateway API CRDs are not installed. I'm afraid this could still be a problem because of this HTTPRoute list in the original reconciler.

Removed the extra dynamic controller and added a CRDExists check for HTTPRoute. When HTTPRoute exists, KongUpstreamPolicy controller enables features requiring HTTPRoute. Also added test cases in envtest to verify that KongUpstreamPolicy works both with and without HTTPRoute.


Is there an option to limit number of devices to be connected

ie. passing an argument through shell, --numdevices=2, so that it never allows more than 2 devices to be connected at a moment.

No. And hostapd doesn't have any option for it. Maybe it can be done with RADIUS, but it will be compicated solution.


GUACAMOLE-1322: Include SAML Plugin in Docker Image

Addressing the issue of missing SAML Plugin in Docker Image.
Please include in next release. Thank You!

added another commit to fix the whitespace issue hopefully.

Code looks good!  You need to re-do all of your commits to have the issue tag at the front, like this: GUACAMOLE-1322: fixed whitespaces

I wasn't aware of that. I assume the commits would get squashed on merge anyway.
I've done a rebase of the last 3 commits. Hopefully that was the intended solution.

You need to re-do all of your commits to have the issue tag at the front, like this: GUACAMOLE-1322: fixed whitespaces

Also, please do not use a commit message like "fixed whitespaces". There just isn't any context there. Like a code comment, a good commit message should describe the nature of the change, not the literal change:
https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/
For example, after seeing your commit, I still had no idea what whitespace issue you were referring to or why anything needed to be fixed. I looked at the content of the commit itself and was able to see for myself, but that sort of information should already be apparent from the message.
With something like:

GUACAMOLE-1322: fixed whitespaces

A developer looking through the git history is left wondering what happened.
On the other hand, something like:

GUACAMOLE-1322: Correct indentation of SAML property assignments to match established code style.

is very clear. If (somehow) the change didn't achieve what it aimed at achieving, that would be apparent even weeks to months down the line.
No commit or change is too trivial to warrant a good message.

@mike-jumper I agree with your arguments and am always willing to improve. Before I do another rebase and alter my "fixed whitespaces" commit message, are the other ones I used somewhat OK or are they still within an acceptable range?

@mike-jumper I agree with your arguments and am always willing to improve. Before I do another rebase and alter my "fixed whitespaces" commit message, are the other ones I used somewhat OK (are they still within an acceptable range)?

The other messages are better, for sure. If you'd like to improve those messages:

Avoid shorthand like "ext" and "env" for "extension" and "environment variable". It's unnecessarily obfuscated for something that's intended to be documentation.
Avoid describing what you're modifying by its filename alone - git already tells us this, and someone reading through the git history may not be as familiar with the purpose of each file. Describing things at a high level is better than saying "Update something.foo include BAR cfg"

For example, consider:

GUACAMOLE-1322: Update build-guacamole.sh - include saml ext.
GUACAMOLE-1322: Update start.sh include SAML env

vs.

GUACAMOLE-1322: Build and include SAML authentication extension within Docker image.
GUACAMOLE-1322: Add Docker environment variables for configuring SAML.

I've just been testing the changes and for some reason the .jar file for saml is not present in the docker image:

guacamole@aaf35270b1e9:/opt/guacamole/saml$ ls -al
total 8
drwxr-xr-x 2 root root 4096 Jun  3 09:17 .
drwxr-xr-x 1 root root 4096 Jun  3 09:17 ..

If someone spots the problem, any help would be appreciated.
Will update, if I find it myself.
Until that's solved: This pull request is not ready to be merged!

Commit Messages have been corrected as requested. Please continue with the review. I'll remove the Draft status.
The docker image I've build for my usecase seems to run. Still working on getting the SAML integration with my coportate IdP to work.
Hopefully the documentation is right about this:

Often the metadata file contains most of the required properties for SAML authentication and the other parameters are not required.

From my side the changes worked for my deployment together with the IdP that my customer uses. If any more changes are needed, please let me know. Otherwise a merge before the next release would be appreciated. 🥇

I still can have a look if you give perms 😅

I just added you to the project.

I've implemented the requested changes :)

is this still being monitored?

Yep, I just got real busy toward the end of last year. I'll try to look over this later today.

What's the status of this PR? Will it be included as a feature in 1.5.0?

I've rebased on master and removed commits dealing with adding the saml jar since it's already included with all other sso plugins. should be good @mike-jumper 🤞

I've found a bug in this pull request - captured here: https://issues.apache.org/jira/browse/GUACAMOLE-1570
I think the logic when deciding to load the SAML extension is incomplete. @petzsch


Encountered an error (InternalServerError) from host runtime when syncing trigger

Does this occur consistently? Yes
Repro steps:

Deploy app via Visual Studio
20:18:40 timetrigger3: Syncing triggers...
20:19:21 timetrigger3: Syncing triggers (Attempt 2/6)...
20:19:32 timetrigger3: Syncing triggers (Attempt 3/6)...
20:19:52 timetrigger3: Syncing triggers (Attempt 4/6)...
20:20:33 timetrigger3: Syncing triggers (Attempt 5/6)...
20:21:54 timetrigger3: Syncing triggers (Attempt 6/6)...
20:21:59: Error: Encountered an error (InternalServerError) from host runtime.

Action: azureFunctions.deploy
Error type: BadRequest
Error Message: Encountered an error (InternalServerError) from host runtime.
Version: 0.22.0
OS: win32
OS Release: 10.0.18363
Product: Visual Studio Code
Product Version: 1.44.2
Language: en

Call Stack
extension.bundle.js:225:2842864extension.bundle.js:225:2842864
retryCallback extension.bundle.js:225:114550
retryCallback extension.bundle.js:157:31063
extension.bundle.js:157:32676extension.bundle.js:157:32676
handleRedirect extension.bundle.js:171:7752
extension.bundle.js:157:29848extension.bundle.js:157:29848
Request._callback extension.bundle.js:1:669125
Request.n._callback.n.callback.n.callback extension.bundle.js:201:4483
Request.emit events.js:203:13
Request.<anonymous> extension.bundle.js:201:17592
Request.emit events.js:208:15
IncomingMessage.<anonymous> extension.bundle.js:201:16382
Object.onceWrapper events.js:291:20
IncomingMessage.emit events.js:208:15
endReadableNT _stream_readable.js:1168:12
processTicksAndRejections task_queues.js:77:11

@sparisSigfox this does not reproduce for me with just those steps. Please add more detailed information about your setup and how you got to this point


Plain text HTTP response for Acme challenge.

The current version was failing (Python 3 and Django 1.10, Heroku).
The response would return the challenge answer in HTML tags, and Let's Encrypt/Certbot would fail.
This fix renders the response in plain text, and also cleans up the templating which isn't necessary anymore.

That's interesting, because my installation was returning plain text, but this is worth looking into! Did you have any examples from your install, something like curl outputs?

@urda Yes of course! I ran another test with a dummy acme challenge:
This is the curl output from the current version which was failing for my install:
curl https://petercuret.com/.well-known/acme-challenge/Msx4UbGPq-BaPdcUMwb0y2ZpC0WIvIUKOTQD_i272jw

Msx4UbGPq-BaPdcUMwb0y2ZpC0WIvIUKOTQD_i272jw.M025Ez9-B5rPPf501JTmCQtUMTaKghu27LSu9qfI4YA

Maybe a bit redundant, but this is the response with my change:
curl https://petercuret.com/.well-known/acme-challenge/Msx4UbGPq-BaPdcUMwb0y2ZpC0WIvIUKOTQD_i272jw

Msx4UbGPq-BaPdcUMwb0y2ZpC0WIvIUKOTQD_i272jw.M025Ez9-B5rPPf501JTmCQtUMTaKghu27LSu9qfI4YA

I wonder if it has to do with the server environment..

Very interesting you got HTML tags at one point, because I'm not sure how that would have happened. Regardless, once you fix your build I think your render route may be the better way to go.

@urda I fixed the blank lines but a test is failing:
Line 130 in tests.py:
       # Check content of response         self.assertEqual(response.content, self.expected_response_bytes)         self.assertEqual(             response.content.decode(response.charset),             self.expected_response_decode,         )
Throws an assertion error:
AssertionError: 'challenge_view_test_response' != 'challenge_view_test_response\n'
Which does make sense, the expected response doesn't have a newline initially.

Yes, but the old template did have a newline, and we have changed our response (which broke the test) 😃 . In the setUp of TestAcmeChallengeViews we will need to update the expected_response_bytesand probably the expected_response_decode as well.

@urda 👍  I pushed an update with the import cleanup. Looks like the build passed :)

@urda I pushed some cleanup commits. I tried squashing the commits but I'm having trouble because they have been pushed to the repo already. There should be an 'squash and merge' option when merging the pull request in Github. Could you have a look?

Tracking PR From #30 Now


Diego

Hi Gaby, We worked on payment microservice so I send you this pull request for you to review please. thanks in advance!

Changes applied to branch payment


Response truncated

Hi,
I have a strange issue with the http client I was hoping you could help me with.
I am running an s3 "select object content" request using the c++ http client (not the s3 client as its not yet supported). I'm encountering a problem when using 36 processes in parallel to download ~750MB+ of data in several parts.
It works well for smaller numbers of processes (I have tested up to 8) but when running with a larger number, like 36, some of the responses are truncated. That is to say... the request completes before I have received all the data. I am using a DataReceivedEventHandler to receive data as it arrives.
Strangely MakeRequest returns 200 before the DataReceivedEventHandler has received everything (but only with a lot of parallel processes).
It's implemented as a Python extension implemented in a C++ shared object. The processes are created in Python with each invoking the so. Build details below. Timeouts a very large and am using separate Aws::InitAPI(options); etc. for each invocation.
Any ideas?
What platform/OS are you using?
Linux 4.4.0-134-generic #160-Ubuntu SMP Wed Aug 15 14:58:00 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
What compiler are you using? what version?
Python 2.7.12
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
What's your CMake arguments?
Python distutils invokes the following:
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Ivenv/local/lib/python2.7/site-packages/numpy/core/include -Ibuild/thirdparty -I/usr/include/python2.7 -c scan/src/scan.cpp -o build/temp.linux-x86_64-2.7/scan/src/scan.o -std=c++11 -Ofast
c++ -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/scan/src/scan.o /usr/local/lib/libaws-c-common.a /usr/local/lib/libaws-checksums.a /usr/local/lib/libaws-c-event-stream.a -laws-cpp-sdk-core -laws-cpp-sdk-s3 -laws-c-common -laws-checksums -laws-c-event-stream -o build/lib.linux-x86_64-2.7/scan.so
Can you provide a TRACE level log? (sanitize any sensitive information)
It's very big :( Can perhaps send parts if useful?

There're too many variables in this issue. It's hard to give any help without having access to a repro case and source code. That being said, we're working on official support for S3 select in the SDK. Hopefully that will resolve the issues you're having.

can you provide code to reproduce on our end?

Code is under repository https://github.com/yxymit/s3filter
It's a research project so hasn't been set up to be easily navigable I'm afraid. That said, main areas of interest are:

scan/src/scan.cpp - The C++ source file for the Python shared object (there is only one).
s3filter/sql/native_cursor.py - An example of a Python class that invokes it. You simply feed it with an instance of the library (e.g. import scan) and you can then use select(s3key, s3sql).execute(callback) to run a query against s3 select. Bucket is hardcoded in C++ source at present so you will need to change that to experiment.
build.sh - a build script of sorts.
setup.py - config for compiling/linking scan.so.

Oh... and thanks :)

Have tested a plain s3 get object that follows (largely) the same code path and the issue does not occur. Am guessing it's something to do with the request sent to the s3 select endpoint or capturing the bytes that are returned.

Can you get the trace level log of SDK itself when that happen?


feat(formatters): add eslint formatter

Added ESLint, because not all people use eslint_d.
In this case, the arguments that must be passed to eslint are exactly the same as in eslint_d, so there should be no problems.

Unfortunately, ESLint does not have a flag that can be used to output files to stdout. After some digging, I also realized that it is impossible to use the --fix flag with --stdin, only --fix-dry-run is available there


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 47c2008:
:clock10: Pending: waiting for processors (25 builds ahead of you)
:warning: Docs Build is busy, currently there are 25 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 47c2008:
:clock10: Full build: the average full build time is 5 min(s) 12 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 47c2008:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


added Windows Server 2019

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/6673

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @mypil, for your information
Thank you