Bedrock Edition not starting, failed port.

Bug Report
System Information

Operating System: Ubuntu 18.04.3 LTS
AMP version and build date: <IP_ADDRESS> - 26/09/2019 13:40
Which AMP release stream you're using: Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms
I am trying to launch a bedrock instance, and when I start the server it errors saying the port is already in use.

NO LOG FILE! - setting up server logging...
[20:42:30] [INFO]: Starting Server
[20:42:30] [INFO]: Version <IP_ADDRESS>
[20:42:30] [INFO]: Session ID 64ab4c9b-27ae-424d-91e6-c6fd8743e85d
[20:42:30] [INFO]: Level Name: world
[20:42:30] [INFO]: Game mode: 0 Survival
[20:42:30] [INFO]: Difficulty: 2 NORMAL
[20:42:33] [INFO]: IPv4 supported, port: 0
[20:42:33] [INFO]: IPv6 supported, port: 0
[20:42:33] [ERROR]: Network port occupied, can't start server.
Quit correctly
[20:42:33] [Minecraft:c0de Warning] : The application stopped unexpectedly.

Reproduction
Fresh install of AMP and fresh bedrock instance, trying to start the server causes it to error. I have tried setting the port via AMP, and manually via the server.properties, but it always tries to start on port 0.

Not an AMP issue, it's a bug in the Bedrock server itself. https://bugs.mojang.com/browse/BDS-752

Is there a way to specify the ipv6 port and ipv4 ports for bedrock via AMP? Is there a way to change the launch string? Is there any solution to this bug within AMP, or is bedrock not working with AMP until this gets patched?

This issue isn't even related to AMP, it's a bug in the bedrock server itself that AMP has nothing to do with. This isn't an issue of bedrock not working with AMP, its an issue of bedrock not working full stop for reasons that aren't entirely clear.

I can run bedrock completely fine without AMP. That is why I asked if there was a way to specify ports for ipv6 manually so that AMP does not assign the same port for ipv4 and ipv6. Bedrock works perfectly outside of AMP, but because there is no way to specific the port bindings for ipv6 in AMP, the instance tries to start with the same port causing the bug to occur.
So any suggestion on how to specify an ipv6 port separately?

You don't need to. Someone posted a workaround for the bug in Bedrock in the very thread I linked you to.


[Q] Is there a way to tell whether wandb is initialized?

As titled, I want some logic like
if wandb.is_initialized():     wandb.log()
is there such an api for accessing wandb status?
Many thanks!

Hi @jojo23333,
When a run is not initialized, the run object is set to None. Therefore, you should be able to do the following:
if wandb.run is not None:
    wandb.log()

Thanks,
Ramit


Adding Socials at the footer of each page

I want to add community socials with a hover effect at the footer of each page. If you find it relevant, then I request you to please assign it to me.

something like this

Hey, I would like to work on this issue could you assign me this?

@AbhishekTiwari23

Can I work on this issue? @AbhishekTiwari23

Hey, @AbhishekTiwari23 work on this. 🚀

Hey, @AbhishekTiwari23, work on this. 🚀

Thanks for assigning me. I will respond as soon as possible.

Is there any update @AbhishekTiwari23

@Rajdip019 can you assign this to me?

Sure no worries. @AbhishekTiwari23

is it done @Rajdip019

is it done @Rajdip019

I made a pr, but it has a conflict, and I forgot about that. I will give an update soon.

Hi Rajdeep,Can I work on this issue I will complete it quick.

Hi @Rajdip019
I have changed the footer text with icons.. plz look and give me suggestions. Can raise PR for this?

@Rajdip019 we can place the social media icon in place of these names i want to work on this.


The free to use version of the simple labyrinth game where you would find the exit.
How to play your game?
Simply, you would use W to move up, A to move left, S to down, D to right and J to restart, you cannot push the box to the end.
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for PR!

its a kit, so you can use without crediting.

hmm interesting! how about adding a little more? to make it more different from getting_started

hmm interesting! how about adding a little more? to make it more different from getting_started
Actually it isnt heavily inspired from getting_started, I actually wrote the code from help.

hmm but what about adding more mechanisms? as a "coding demo" because "help" is practically getting_started

actually this is labyrinth trilogy mechanism, also I just increased the level number to 2 to understand the game kit itself.


faac/faad2: other homepage

Because it seems the audiocoding.com domain expired

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

/marvin opt-in

I don’t think Wikipedia can really count as a homepage. If there’s no homepage any more, just delete the line.

If there’s no homepage any more, just delete the line.

Ah, didn't realize it was optional :+1:, updated


Enhancements made according to ISC

Here is a summary of the enhancements :

Provisioning - Alarm Mapping Renamed:
o	The "Alarm Mapping" tab has been renamed to "Alarm Transformation".
Bulk Device Provisioning:
o	Added the ability to provision bulk devices on a selected tenant using bulk upload features.
EPL Rules Provisioning:
o	List all default EPL rules in the current tenant.
o	Deploy these rules across all selected tenants if the multi-tenant Apama microservice is not used.
Analytics Builder Model Provisioning:
o	List all default analytics builder models in the current tenant.
o	Deploy these models across all selected tenants if the multi-tenant Apama microservice is not used.
Firmware Provisioning Check:
o	Before provisioning firmware, now it checks if the firmware with the same version already exists; if it does, it will ignore it; otherwise, it will provision the selected firmware.
Global Roles Management:
o	Added tenant ID at the header level for context identification of global roles.
o	Added centralized management (Create/Update/Delete) of global roles by redirecting to the standard Cumulocity implementation i.e, Administration -> Global roles.
o	Included a list of applications where these global roles are applied.
o	Display associated permissions within each role.
o	Renamed the header from "Role" to "Permissions" for better representation.
Tenant Options:
o	Added tenant ID at the header level to identify the context of tenant options.
Firmware Statistics Fix:
o	Fixed the issue where firmware statistics did not display the correct value. Diagram to check which firmware version is installed on which amount of devices for a specific sub-tenant

Please also consider to split this PR into multiple ones (e.g. one per feature) to make the review a bit simpler.


[STORM-801] Add Travis CI badge to README

Travis CI has a fancy little badge that shows the build status of the project. We should add it to the README.markdown file now that #486 is in.

Oh, I forgot it. :) LGTM.

+1


Enhance editorconfig

These non-standard keys allow eclint to recognize /* */-style comments.
From https://github.com/conedevelopment/sprucecss/pull/12#issuecomment-1683749305
Let's see CI run!

Thank you!


python3Packages.sqids: 0.4.0 -> 0.4.1

Description of changes

https://github.com/sqids/sqids-python/blob/v0.4.1/CHANGELOG.md#changelog
https://github.com/sqids/sqids-python/compare/v0.4.0...v0.4.1

A very small change to make sqids compatible with Python 3.6. Since 3.6 and 3.7 are unmaintained already, they stay disabled in this pkg.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.sqids
python310Packages.sqids.dist
python311Packages.sqids
python311Packages.sqids.dist

@ofborg build python311Packages.sqids python310Packages.sqids


[NEW ICON] SolidJS and UnoCSS (Premade Icons Included)

Skill Name
SolidJS and UnoCSS
Why?

SolidJS
A declarative, efficient, and flexible JavaScript library for building user interfaces.

UnoCSS
The instant on-demand atomic CSS engine.

Reference Image

✅ Added solid in 59059d9d1a2c092696dc66e00931cc1181a4ce1f! Please put the other icon in a sep issue next time. Thanks for your helpful reference images.


chez: 9.5.1 -> 9.5.2

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS

[x] Tested execution of all binary files (usually in ./result/bin/)

@GrahamcOfBorg build chez


Wrong IP address detection in case of multiple interfaces with private addresses

This code in lib/vagrant-chef-zero/env_helpers.rb incorrectly detects address of chef-zero server (it takes address of another interface with private address)
ip_address = Socket.ip_address_list.detect{|intf| intf.ipv4_private?}.ip_address

Essentially it'll take the first match rather than checking for the one matching the network of the provider. This is currently necessary since the chef_server_url must be set before vagrant validates the configuration of any chef_client provisioner steps.
The only solutions appear to be binding to all addresses using '<IP_ADDRESS>' (any security concerns?), or insert a dummy url, move the start and upload to after the provider runs and before the provisioner steps, and extract the correct network address to use from the provider.
I've also seen problems with network interface selection and Window's systems with various firewalls (really painful in a corporate env when frequently you can't modify or disable them) where using the machines public interface worked but none of the private ones could be communicated with from within the guest.

The only solutions appear to be binding to all addresses using '<IP_ADDRESS>' (any security concerns?)

I thing this is the best variant. People concerned about security of their development/testing environment already have firewall.


Watch Query doesn't get destroyed on reactive variables

i'm doing this on my conversation component
    apollo: {
      conversation() {
        return {
          query: this.$gql.queries.Conversation,
          variables: () => ({
            id: this.conversationId
          })
        };
      }
    }

everything is Polled every second on the global apollo config here
  const client = new ApolloClient({
    link: mainLink,
    cache: new InMemoryCache(),
    connectToDevTools: true,
    queryDeduplication: true,
    defaultOptions: {
      watchQuery: {
        pollInterval: ssrMode ? null : POLL_INTERVAL
      }
    },
    ssrMode
  });

then when i change routes it still polling the old one and not unsubscribing it

I'd have to this to remove the observer
    watch: {
      $route() {
        console.log(this.$apollo.queries.conversation);
        this.$apollo.queries.conversation.observer = null;
        // this.$apollo.queries.conversation.stopPolling();
        // this.$apollo.queries.conversation.startPolling(1000);
      }
    },

Please reopen if you still have the issue.

Probably having the same issue here.
    this.$apollo.addSmartQuery('query', {
      query: QUERY,
      variables(): QUERY.Variables {
        return {
          permlink: this.permlink,  // a prop variable from router
          offset: 0,
          limit: 3,
        };
      },
    });
this.$apollo.queries.recentContributors.startPolling(5000);

When the router changes, it seems that it is still send the query using the same permlink instead of updated.


How to set request setTimeout?

I use this method to set request timeout, but it doesn't work. Anyone could tell how to setTimeout when using http2 request?
method:
request.setTimeout(1000, function () { });

The same issue here. This function exists, but it doesn't work.


Clarify react-native usage

There is an open 3rd party IP issue, where clarification is needed.
See the issue comment.
I am wondering, where and why we need react-native, since I was under the impression, that we are building a webapp only.
FYI @ClosedSourcerer

Hi @ClosedSourcerer,
I cannot find any usage of react-naitive components. I also cannot find any hint in the commit, that added the react-native dependency initially. See commit
When removing the dependency from the list, I can at least build the app locally. Unfortunately there seem to be no tests, that could further verify that. Could you please find someone, who can verify, if this dependency can be removed without issues?

@SebastianBezold
I contacted to original authors. We should get a qualified answer within a week.

Hi @ClosedSourcerer,
did you already receive feedback from the original authors?
I don't want to keep the EF ticket open for too long. If we cannot get an answer, I could also remove the dependency for now and leave the testing for someone picking up development in the future

@SebastianBezold
Not yet, I upgrade this to an weekly escalation cycle.

HI @Ruskyy, thanks for the update. Then I'll remove the lib and let the EF know on the 3rd party IP issue.

Removed in ab322a8


Rolling Update to New "latest" Image

Is it possible to do a rolling update where kubernetes pulls and uses the newest Docker image with the "latest" tag rather than having to change the replication controller spec to use version 2.0.0 instead of 1.2.3 for example?

Using "latest" leads to unpredictable behavior. Any pods that happen to be created for any reason (node death, scaling, rolling update of some other field) after the latest tag is retargeted to a new version would pull that new version. Is that what you want? (Well, there's also the issue of whether the imagePullPolicy may interfere.)
Or, would you like "latest" to be automatically translated to a tag referring to the current version? That was proposed in #1697. The v2 registry API should make that more feasible.

cc @nikhiljindal @ironcladlou


ignore specific files

Your documentation explain how to ignore specific keys, but what about a config to ignore specific files ?

Hi @skyporter,
Actually, YAML files are almost always prefixed by one, or maybe a couple of keys, but not more.
So if you want to completely ignore a YAML file you can add something like this:
config.ignored_key_prefixes = [
    'root_key_of_your_yaml_file.', # don't forget the trailing dot
 ]

If you happen to have a lot of first-level keys in your YAML file, you can still do something like this:
config.ignored_key_prefixes = YAML.load(File.read('config/locales/ignored.en.yml'))['en'].keys.collect { |k| "#{k}." }
# => ["admin.", "enumerize.", "activerecord."]

It's not "neat" but it should work too.

Hi,
Thanks for the alternative suggestions, unfortunately not applicable to my case as I have a file that only contains backend translations.
For example, I have a Customer model which should be only translated in only one language. I manage that by storing "customers keys" on a dedicated file backend-activerecord.fr.yml:
fr:
  activerecord:
    models:
      customer:
        one: "Fiche client"
        other: "Fiches clients"

and my generic activerecord.fr.yml file contain all others keys:
fr:
  activerecord:
    models:
      user: Utilisateur
      ...

As suggested, my only alternative with translation.io is to do that:
  config.ignored_key_prefixes = [
    "activerecord.models.customer.",
    "activerecord.attributes.customer."
  ]

It would have been easier with the exclusion of the file.

Now I understand why you need something like this.
That's not a very common YAML structure and I'm not sure we should add a new ignored_yaml_files configuration for this.
Wouldn't it possible for you to add a small helper method to ignore some specific keys of you models?
Something like this:
def ignore_for_backend(models)
  models.collect { |m| ["activerecord.models.#{m}.", "activerecord.attributes.#{m}."] }.flatten
end

config.ignored_key_prefixes = ignore_for_backend(['customer', 'projects'])

I'm going to leave that issue open.
We could consider adding this option if many users need it.

Yes, I can probably code a script to automate this. Meanwhile, I can always add the keys one by one.
Thanks for your help.


Fetching game list for specific user/profile

Is there REST endpoint for fetching list of games for specific XUID or authorized profile.

Any info for this one ?

Hi @unckleg, we're looking into your question, thank you for your patience.

@aablackm Thanks, waiting for response :)

@unckleg Hi I'm Cameron from the Xbox ATG team.  All of the Xbox Live Service API's are shims for REST based service calls.  So yes, there is a URL to the Xbox Inventory service that you can use to check what the user is entitled to.  But you must be providing an XSTS token in the Authorization header for that service.  Can you give me some more info on why you are wanting to call the URL directly or what the flow of your code would be?
If you are wanting to do this check from a server backend (b2b) that can be done and is outlined in many of the Xbox Live developer forum posts.  For b2b you would need a Delegated Auth XSTS token which is a whole other discussion, but there we have good samples, whitepapers, and past conference talks on them.

Hi @CameronGoodwin I'll take a look tomorrow at our implementation and inform you detailed about the same. So we can discuss about  the problem.

Hi @CameronGoodwin,
I didn't mention that we are authorized and we are sending XBL3.0 authorization header for every request. Many other services that are behind the Authorization layer are working correctly but we just have problem with Inventory service, when I send request to 'inventory' endpoint I get '403 forbidden' status code.
Here is linked issue: #514

@CameronGoodwin @aablackm @KevinAsgari
Any news on this one ?
Thanks!

Sorry @unckleg I apparently am not getting notifications when there are updates to this thread.  Without seeing a trace or the MS-CV value of a 403's response header to look up some logs it is not easy to say what the issue is.  However, if you have delegated auth working for other services my guess would be that you are using the same XSTS token for those services as you are for calling Xbox Inventory.  In that case then I would expect a 403 ;).  You see most of the Xbox Live services use the relying party for "http://xboxlive.com", but xbox inventory uses a different one.  That means you have to specifically ask for a delegated auth XSTS token with a relying party of "http://licensing.xboxlive.com" to be able to talk to the xbox inventory service.  Check to make sure you are asking for a token with that relying party.

Please follow up on the Xbox Live developer forum if you have further questions on this topic


Fix wrong safemath lowering

What was wrong?

Right shift operation isn't lowered sar when operands are signed type
negate operation isn't lowered into safe_sub call.

How was it fixed?
🔪

[ ] OPTIONAL: Update Spec if applicable
[x] Add entry to the release notes (may forgo for trivial changes)
[x] Clean up commit history

Codecov Report

Merging #723 (52256eb) into master (f810961) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   81.68%   81.65%   -0.03%
==========================================
  Files         105      105
  Lines       11843    11851       +8
==========================================
+ Hits         9674     9677       +3
- Misses       2169     2174       +5

Impacted Files
Coverage Δ

crates/codegen/src/yul/isel/function.rs
80.50% <60.00%> (-0.56%)
:arrow_down:

crates/mir/src/ir/value.rs
61.53% <100.00%> (+3.20%)
:arrow_up:

crates/analyzer/src/context.rs
60.83% <0.00%> (-0.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f810961...52256eb. Read the comment docs.


New builds not showing up in build dashboard

I'm seeing a lot of unscheduled and pending builds on the build dashboard:

However, looking at a particular bot, it looks like it has been consistently running and finished builds:
https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-2

It looks like there are a handful of "pending" tasks that haven't actually started yet (Possibly related to https://github.com/flutter/flutter/issues/116738). I looked at some of the tests that are "pending", and all of the bots in the associated pools are currently busy. With that being said, I'm not exactly sure why it got behind in the first place.

Is this related to multiple PRs being tested for release candidate branches?

Is this related to multiple PRs being tested for release candidate branches?

Ahh, yeah, probably!

Lowering to P3 given the knowledge that it is related to the release candidate branch commits. The question left is how to make it clear that things not visible on the dashboard were the reason for the bot pools being so busy

I filed https://github.com/flutter/flutter/issues/120395. Why would the release candidate branches fail to schedule any builds? This doesn't seem to be a bot busy issue

@nehalvpatel can we promote this to P2? This is severely blocking releases and rolls. Consistently, the oncall needs to rerun 70+ builds which isn't a reasonable workaround.

As FYI, I landed https://github.com/flutter/cocoon/pull/2471 as a mitigation for this a while back. This is still happening frequently, and is really only visible on the release branches now due to the vacuum only running against tip of tree.

@CaseyHillers can you/release team ping me when another release is opened and we hit this? Or is there another release branch in this state right now possibly that I can look at? The one I was using was a little old and I think the tasks were unstuck by the release team.

Yeah definitely not just a release branch issue. I found a currently commit with the same issue in flutter.

The top row shows the issue where builds are not being scheduled:

Here is the amount of tasks that do not have build numbers in Datastore related to that commit:

There are a significant number that have not been scheduled when there are idle machines that can take the build.
It appears that cocoon is not scheduling these tasks initially.

There are a significant number that have not been scheduled when there are idle machines that can take the build.
It appears that cocoon is not scheduling these tasks initially.

I believe only one instance of a particular task is scheduled and run at a given time, even if there are multiple commits with that task waiting to be run. So in this case, some of the yellow tasks on the left likely finished their runs for the 3rd commit earlier, so they were able to get scheduled for the top two commits.

Some of the yellow tasks have not been run. I have found an instance where the tasks is showing as yellow but it is not in the tasks.
Here is the commit:

The related task:

The list of the tasks if you click the view logs:

And here is the newest log entry pertaining to that task:

And if you query Datastore you can see that there was no task created for the run:

This is a secondary rate limit problem. We are simply generating far too much traffic. This is why cleaning up the commits works since the cleanup interval is 3 hours we have a better chance of creating the checkRun and associated build.
Eventually the builds get scheduled. The problem is github and the amount of requests we make.
I did some research and it looks like github.com has a hard cap for its rate limit per hour.
https://docs.github.com/en/apps/creating-github-apps/creating-github-apps/rate-limits-for-github-apps
Which limits what you can do. It looks like since we have an Organization account that we are limited to 15,000 requests max per hour.
The other thing that is a problem is with the checkruns. You can only create a single check run at a time which is a single request. So for a post submit we make anywhere from 310 - 350 create check run requests for a single PR.
So depending on how many active requests are open we could easily hit the hard cap.

The best thing to do here is to actually read the headers and take action based on those. There are 4-5 header values that are returned that tell you what is happening when you are throttled when making a request.

Potentially related to #121989

Summarize a bit:

Original posted issue should be related to high queued number of tasks (related bug: https://github.com/flutter/flutter/issues/121989)
There are two issues related https://github.com/flutter/flutter/issues/120395#issuecomment-1444810718. Created corresponding bugs to track.

Yellow boxes that are actually not scheduled: https://github.com/flutter/flutter/issues/122117
Secondary rate limit issue from batch-backfiller api: https://github.com/flutter/flutter/issues/122116

With that, I am closing this one in favor of the above two.


Implement COMMAND INFO

Is your feature request related to a problem? Please describe.
Based on this SO question: https://stackoverflow.com/questions/77220056/programmatically-adding-commands-to-fakeredis-in-python. Should work with https://github.com/redis/redis-om-python.

#248


Ability to ignore/mute items.

Are there any plans to add the ability to ignore or mute items in a feed?
Similar to what Feedly has done: https://blog.feedly.com/mute-filters/ ?
Thanks

is that not a duplicate of #226 ?

Hi - yes it is a duplicate. Thanks for linking it!


MapReduce fails when when map emits objects {...} as keys

Hi,
MapReduce fails when when map emits objects {...} as keys
$$$fongoEmits$$$[param1] was  string "object" in such case
Thanks,
Vladimir

Thanks :)


Database Username and Password?

I'm using your project to do APM monitoring with AppDynamics for a special project. What is the DB connection information? Thanks

Found it in the pom.xml


Template tests “fixes #35”

Wasn't able to test logFileError function. It's logging with fmt.Print at the moment, and I can't get the stdout for assertion.
If I swap to logrus the format for the line output is lost.

I've been switching most loging to github.com/KablamoOSS/go-cli-printer, see https://github.com/KablamoOSS/kombustion/blob/master/internal/manifest/init.go for a good example.
But, right I coverage on if there's an error rather than the error content is sufficient. We'll do another pass closer to the 1.0.0 for that.

Pull Request Test Coverage Report for Build 248

7 of 9 (77.78%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+10.5%) to 35.577%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/cloudformation/template.go
7
9
77.78%

Totals

Change from base Build 232:
10.5%

Covered Lines:
444

Relevant Lines:
1248

💛  - Coveralls


Add Ouais Ouais (ft. SlyLeaf) x Into The Night by LemKuuja x Yoasobi

Song Name
Ouais Ouais (ft. SlyLeaf) x Into The Night
Artist Name
LemKuuja x Yoasobi
Source
Direct file download
Youtube Link
No response
Direct File Link
https://www.mediafire.com/file/i5oyu4na35pae7w/787153.mp3/file
Song ID
787153
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 59626284

Update 1 : Voice Kuzureta

reject
Must be a link to a proper CDN, Not Google Drive, Dropbox or MediaFile.


Fix: use the -static ldflag only for the 'build-ci' target

cc/ @jimil749

@SamuAlfageme I tested this locally and this works fine! Thank you. :)


Segmentation fault in fetchBrokerMetadata

Hi,
Thanks for the library. I receive a segfault when calling fetchBrokerMetadata per the example in the docs. The issue seems to be in InternalRdKafka.hs.
{#sizeof rd_kafka_metadata_broker_t#}

This line calculates the size of rd_kafka_metadata_broker_t to be 20. However, the size is really 24 with gcc v4.9.2 on Debian. The result is that in getMetadata in Haskakafka.hs calling peekElemOff brokersPtr i will create a bogus RdKafkaMetadataBrokerT.  The subsequent peekCString (host'RdKafkaMetadataBrokerT bmd) that occurs in constructBrokerMetadata is the line that causes the segfault.
There's an issue for this in haskell/c2hs: https://github.com/haskell/c2hs/issues/129. They state that using c2hs's current design, it's not possible to correctly compute the sizes in this instance due to limitations in what is available in Foreign.Storable.
I looked at other packages for deriving Storable instances, but they had the same issues. What do you suggest? I'm currently explicitly inserting the values in a local version of haskakafka.
Similarly, the size of rd_kafka_metadata_topic_t should be 32. However, that doesn't cause a segfault, just an enum conversion error.

I believe this issue has been fixed in c2hs. See https://github.com/haskell/c2hs/issues/156.

Oh awesome. Thanks fantastic. I'll try it out.
On Mon, Apr 4, 2016 at 11:40 PM, takano-akio<EMAIL_ADDRESS>wrote:

I believe this issue has been fixed in c2hs. See haskell/c2hs#156
https://github.com/haskell/c2hs/issues/156.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cosbynator/haskakafka/issues/20#issuecomment-205641106

That did the trick! If anyone else runs into the issue, updating to the resolver to nightly-2016-04-05, or a version that has c2hs v0.28.1 fixed the issue. Thanks for the heads up takano-akio.


0.7.0 release

Headline is major PG Vector enhancements & fixes, e.g.

[x] #54
[x] #55
[x] #57
[x] #59
[x] #60
[x] #61
[x] #64 - Only remaining one to merge; pending review

Also:

[x] #50
[x] #56

CHANGELOG is updated.

released to GitHub and sent to PyPI https://pypi.org/project/OgbujiPT/0.7.0/. still need to write up a blogpost real quick for the website

released to GitHub and sent to PyPI https://pypi.org/project/OgbujiPT/0.7.0/. still need to write up a blogpost real quick for the website

If you draft one I'll polish it up.

Just updating that the news item & blog entry are ready, pushed & scheduled to go live Monday. Think that's good enough to close this.


⚠ File access has degraded performance

In ff7049d, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 2773 ms

Resolved: File access performance has improved in 4887494 after 8 minutes.


Usage.fromMap fails on completions property

I get the following when requesting some completions:
error: type 'Null' is not a subtype of type 'int' in type cast, stacktrace: #0      new Usage.fromMap (package:openai_client/src/model/shared_models/usage.dart:17:53)
I imagine it happens when no results are generated by openAI

Hello @tomtaila, would you be able to reproduce the error and share the code snippet? Thanks a lot in advance!


using needsApp and variableArgs leaves -a appname in context.args

Using the undocumented needsApp: true and variableArgs:true I'd expect the -a appname to be stripped from context.args so my plugin doesn't have to deal with them.  Currently, -a appname is still in context.args.

fixed!

:cake: :sparkles: Do I need to wait for/install a release or will it be automatically updated?

it will eventually autoupdate, but you can trigger with heroku update

tres cool, thanks


Protractor failed to start firefox latest version - Accessibility support partially disabled

I am trying to run protractor with Firefox latest version. It failed to start Firefox, showing the following warning.
"Accessibility support is partially disabled due to compatibility issues with new Firefox features"

Protractor currently only supports Firefox 47, though it can be made to work with Firefox 51 (see https://github.com/angular/protractor/pull/3953) using directConnect. Unfortunately, Firefox 51 will not work using Selenium Standalone 3.0.1 - this is due to a fixed bug (https://github.com/SeleniumHQ/selenium/issues/3115), so we're waiting on the next Selenium release.
Sorry for the inconvience. Once Firefox 51 and the next version of Selenium are released, things will be better.

Closing as duplicate of #3823


Error: ENOENT: no such file or directory, open '//routes.json''

When I try to create GitHubApi, I catch this error
[ 'Error: ENOENT: no such file or directory, open \'//routes.json\'',   'at Error (native)',   'at Object.fs.openSync (fs.js:641:18)',   'at Object.fs.readFileSync (fs.js:509:33)',   'at new module.exports (/home/azhivaeva-bmt/projects/media-shop-service (copy)/.webpack/api/github/handler.js:1254:33)',   'at new GitHub (/home/azhivaeva-bmt/projects/media-shop-service (copy)/.webpack/api/github/handler.js:1127:23)',   'at createIssue (/home/azhivaeva-bmt/projects/media-shop-service (copy)/.webpack/api/github/handler.js:1109:18)',   'at handler (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/serverless-offline/src/index.js:732:25)',   'at Object.internals.handler (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/handler.js:96:36)',   'at request._protect.run (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/handler.js:30:23)',   'at internals.Protect.run (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/protect.js:64:5)',   'at exports.execute (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/handler.js:24:22)',   'at each (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/request.js:384:16)',   'at iterate (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/items/lib/index.js:36:13)',   'at done (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/items/lib/index.js:28:25)',   'at internals.Auth.payload (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/auth.js:223:16)',   'at each (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/request.js:384:16)',   'at iterate (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/items/lib/index.js:36:13)',   'at done (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/items/lib/index.js:28:25)',   'at onParsed (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/route.js:402:20)',   'at Subtext.parse (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hapi/lib/route.js:423:20)',   'at next (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/subtext/lib/index.js:45:26)',   'at Wreck.read (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/subtext/lib/index.js:242:16)',   'at finish (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/subtext/node_modules/wreck/lib/index.js:373:20)',   'at wrapped (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/hoek/lib/index.js:875:20)',   'at onReaderFinish (/home/azhivaeva-bmt/projects/media-shop-service (copy)/node_modules/subtext/node_modules/wreck/lib/index.js:447:16)',   'at g (events.js:292:16)',   'at emitNone (events.js:91:20)',   'at emit (events.js:185:7)',   'at finishMaybe (_stream_writable.js:512:14)',   'at endWritable (_stream_writable.js:522:3)',   'at Writable.end (_stream_writable.js:487:5)',   'at IncomingMessage.onend (_stream_readable.js:511:10)',   'at IncomingMessage.g (events.js:292:16)',   'at emitNone (events.js:91:20)',   'at IncomingMessage.emit (events.js:185:7)',   'at endReadableNT (_stream_readable.js:974:12)',   'at _combinedTickCallback (internal/process/next_tick.js:80:11)' ]
In this sting:
this.routes = JSON.parse(fs.readFileSync(__dirname + "/routes.json", "utf8"));
My code:
const GitHubApi = require('github');
export class GitHub {
  private github;
  constructor() {
    this.github = new GitHubApi({
      debug: false,
      Promise: require('bluebird'),
      timeout: 5000,
      host: 'api.github.com',
      protocol: 'https',
      headers: {
        'Accept': 'application/vnd.github.v3+json'
      },
      requestMedia: 'application/vnd.github.v3+json',
      followRedirects: false
    });

Are you using npm or running locally from source?
Try creating a small project from scratch to test:
npm init
npm install -S github
create index.js
node index.js

I'm getting this same problem for an Electron App, but only in the Karma unit test. Its installed via the package.json: "github": "^9.3.1",, commenting out the import GitHubApi from 'github'; and its related code gets rid of the error.
Electron 1.8.0 (Node 8.2.1) ERROR
  Uncaught Error: ENOENT: no such file or directory, open 'C:\routes.json'
  at fs.js:652

Electron 1.8.0 (Node 8.2.1): Executed 0 of 0 ERROR (0.698 secs / 0 secs)

Appears to be working fine when actually running the app.

Can you please try if that patch fixes it for you?
https://github.com/mikedeboer/node-github/commit/9c2ee388039f6518edf3f833acbf7d910acf3fcc, it’s in the remove-fs-readfile branch
you can set the version in package.json to "mikedeboer/node-github#remove-fs-readfile" to try it out

I'm currently getting the same using Electron. I believe its related to WebPack, when I add a sample code to the index.html directly it works, when its in one of the scripts that gets build it no longer works __dirname is just /.
Didn't find the solution yet, but I'm just figuring out WebPack so looking further into that.
Dunno if @azhivaeva-bmt  also uses Electron and if its the same. Def. does sound like it with @jojobyte
@gr2m doing require('./routes.json') doesn't resolve it for me, at least not yet, probably due to underlying issues Re the above. (Uncaught Error: Cannot find module ".")

Ok so here's what I've found out that works for me / what I found that didn't work for me, but might for someone else who comes here.
This did not do the trick for me, but for many others it did help.
https://github.com/webpack/webpack/issues/1599#issuecomment-186841345
Adding this to my webpack.config.js file
const { dependencies } = require('./package.json')
[...]
module.exports = {
...
externals: [
    ...Object.keys(dependencies || {}).filter(d => !['vue'].includes(d))
  ],
...
}

Figured this out by grabbing the Electron-Vue  sample app and started tearing it apart to remove all that was not needed to see when it would break (as it did work out of the box there)
@gr2m I don't believe there's anything wrong this repo as the initial/current code looked fine (although using a Path.join() here would add for consistency.

Has any solution been determined when using this library from within an electron app?

@atrauzzi @JeroenSormani et all, I think this should be resolved now, I’ve removed the us of fs in the library. Could you please give it another try?
If it persist, it would help a ton if someone could create a repository for a minimal electron app that uses this library. I can use that as a test case to see how to work around it. Thanks for all your help!


fix(types): fix Configuration interface

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Configuration needs to be an interface to be extended by modules types.
NuxtConfig is the right import to do over Configuration in configuration files, and it extends Configuration interface to have types extended by modules that relies on Configuration.
I'm unsure if we can deprecate it cause it's extended by several modules, so I removed deprecated type description for now.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

@pi0 I'm unsure, the issue is that :

It's deprecated cause we want user to use NuxtConfig over Configuration
It's also not deprecated cause modules extend it

Codecov Report

Merging #7590 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #7590   +/-   ##
=======================================
  Coverage   70.26%   70.26%
=======================================
  Files          88       88
  Lines        3747     3747
  Branches     1020     1020
=======================================
  Hits         2633     2633
  Misses        905      905
  Partials      209      209

Flag
Coverage Δ

#unittests
70.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c8b9b...dac1e39. Read the comment docs.

It's also not deprecated cause modules extend it

Indeed. For me deprecated means something was possible, it is currently still possible but is not encouraged and will not be possible in future versions :D


Implement basic handling for time units in refinement expressions

Kotlin side tests to come along with some added sanity checks for maths with time values and support for 'creationTimestamp'

/gcbrun

/gcbrun
Not sure why this is failing, looks like it gets stalled for a very long time on downloading Android SDK related stuff and then by the time it has finished there's another run that's already using one or more of the ports that sigh normally uses for running servers for test purposes. Will look into this more if it happens again.

/gcbrun

/gcbrun
Hit an OOM, not sure what would cause it in my change.

/gcbrun
Once more (wasm timeouts)

/gcbrun
Failed on build-test-apks

/gcbrun (after rebase, now that most flakes have been dealt with)


check there are no pending entries in SQLite

With our new design, we're not putting pending entries in the local SQLite (or FileDB) database any more, so in a case where a user is migrating from master to super_duper, there might be some pending entries in the database that we simply won't be looking at.
Checking for those at startup and refusing to go on should take care of this (if not outright migrating them to etcd?).

This can no longer happen because we've changed the SQLite schema.
We'll cover this scenario in the documentation.


MetricName class cannot be found

As per given in the documentation on https://github.com/wavefrontHQ/java/tree/master/dropwizard-metrics/4.0, The MetricName class cannot be resolved in the given maven dependency or the git given in  setting up the maven (git clone https://github.com/dropwizard/metrics.git,
git clone https://github.com/wavefrontHQ/java.git).

This should now be fixed.


Creative inventory tabs not right

Xtones-1.12-1.0.2-4
forge-1.12-<IP_ADDRESS>2-installer-win
All of the inventory tabs in Creative mode have all of the Xtones items and blocks listed in them, including all the vanilla tabs and all the mod tabs.
BoP had the same issue until today, but they just fixed it.

Oh, that's an interesting change to how Creative tabs are handled. Thanks Mojang.

lol :)  Guessing it won't be the last time I'm reporting this issue :)


a2_questionnaire_design_part_a

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[X] I can confirm that my changes are working as intended

A2: INCOMPLETE
Please specify which sampling strategy would be most appropriate here (Simple random sample/ Starta/ Cluster etc..).
I would also suggest to avoid open ended questions on a questionnaire, as it is hard to collect data of that nature.

A2: INCOMPLETE Please specify which sampling strategy would be most appropriate here (Simple random sample/ Starta/ Cluster etc..). I would also suggest to avoid open ended questions on a questionnaire, as it is hard to collect data of that nature.

@Melokazz - Thank you for the comment and suggestions!  I've updated the assignment as following.  When you get a chance, would you please verify it?

Specified which sampling strategy would be most appropriate here - stratified random sampling.
Changed the all open ended questions by providing options.

Thank you!
George


Fixed "stm32f4-hal" package issue

Fixed stm32f4-hal package issue and tested on hardware.

Acknowledged

good work @imrank03 💯

please add a working copy of (debug) logs to the stm32f411 bootloader folder (dont forget to edit the lengthy compiler output).


Add set_params in multi-framework attacks

Description
This pull request adds specific set_params method to attacks with implementations for multiple frameworks and updates notebooks.
Type of change
Please check all relevant options.

[x] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@hesseltuinhof Thank you very much for your review and noticing these bugs!


Fix flaky specs in updater

Reproducer:
$ script/ci-test-updater './spec/dependabot/dependency_group_engine_spec.rb[1:4:1]' './spec/dependabot/updater_spec.rb[1:2:1]' --seed 24926

There was one spec causing side effects that was missing cleanup.
Also I changed cleaning up side effects to be done after the specs that create them, not before.

Thanks ❤

Also I changed cleaning up side effects to be done after the specs that create them, not before.

Oof, nice catch! 😍


chore: event bus usage

helps [CDP] iOS Native Refactor: Creation of journeys module#11651
This PR demonstrated the usage of Event Bus, what problem is it solving and how.
Overview
Building on the recently implemented EventBus framework, this PR demonstrates its integration within the MessagingPush and MessagingInApp modules. Additionally, it introduces the EventHandlingManager, a utility class designed to further streamline event management tasks, the role Journey was supposed to play.
Changes

Integration of EventBus: The MessagingPush and MessagingInApp modules now utilize EventBus for handling events.
EventHandlingManager: A new class responsible for managing event subscriptions and handling the storage and retrieval of events. This class plays a key role in managing event lifecycle within our modules.
Use Cases and Examples: Examples of how EventBus and EventHandlingManager are used within the MessagingPush and MessagingInApp modules.

Key Features

Improved Event Handling: Streamlined process for managing event subscriptions and dispatch within the modules.
Event Buffering and Dispatch: EventHandlingManager handles the buffering of events when no subscribers are present and dispatches them once subscribers are available.
Enhanced Modularity: Demonstrates the practical application of EventBus in our existing modules, showcasing its potential to improve modularity and reduce coupling.

merging to make newer PRs with notification center


Supergraph handler fails with same field name

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[ ] 1. The issue provides a reproduction available on
Github,
Stackblitz
or
CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
Using the supergraph handler, if two fields on different types on the same subgraph have the same signature and are fetched identically, an error (Cannot return null for non-nullable field [...] occurs
To Reproduce Steps to reproduce the behavior:

Clone https://github.com/nk-coding/graphql-mesh-supergraph-bug
Start the servernpm install
npm start

Open the browser and go to http://localhost:4000/graphql
Run the following query:query {
    products(first: 1) {
        id
        name
        discounts {
            id
        }
        categories {
            id
            discounts {
                id
            }
        }
    }
}

You will receive the following error:{
    "data": {
        "products": [
        null
        ]
    },
    "errors": [
        {
            "message": "Cannot return null for non-nullable field Category.discounts.",
            "path": [
                "products",
                0,
                "categories",
                0,
                "discounts"
            ]
        }
    ]
}

Expected behavior
Not getting the error and instead getting the data
Environment:

OS: Windows 11
@graphql-mesh/cli: 0.89.4,
@graphql-mesh/supergraph: 0.2.4,
graphql: 16.8.1
NodeJS: v18.19.0

Additional context
After some debugging, I found out that the error most likely has something to do getLoader
Tldr: is seems like both Product.discounts and Category.discounts seem to use the same dataloader, maybe due to wrong cache key
First, when enabling debug logging, I see the following requests:
[start-services] [start-gateway-delayed] Executing DISCOUNT with args: {
[start-services] [start-gateway-delayed]   document: 'query ($_v0_representations: [_Any!]!) {\n' +
[start-services] [start-gateway-delayed]     '  __typename\n' +
[start-services] [start-gateway-delayed]     '  _entities(representations: $_v0_representations) {\n' +
[start-services] [start-gateway-delayed]     '    ... on Product {\n' +
[start-services] [start-gateway-delayed]     '      __typename\n' +
[start-services] [start-gateway-delayed]     '      id\n' +
[start-services] [start-gateway-delayed]     '      discounts {\n' +
[start-services] [start-gateway-delayed]     '        id\n' +
[start-services] [start-gateway-delayed]     '      }\n' +
[start-services] [start-gateway-delayed]     '    }\n' +
[start-services] [start-gateway-delayed]     '    __typename\n' +
[start-services] [start-gateway-delayed]     '  }\n' +
[start-services] [start-gateway-delayed]     '}',
[start-services] [start-gateway-delayed]   variables: { _v0_representations: [ [Object] ] }
[start-services] [start-gateway-delayed] }

[start-services] [start-gateway-delayed] Executing DISCOUNT with args: {
[start-services] [start-gateway-delayed]   document: 'query ($_v0_representations: [_Any!]!) {\n' +
[start-services] [start-gateway-delayed]     '  __typename\n' +
[start-services] [start-gateway-delayed]     '  _entities(representations: $_v0_representations) {\n' +
[start-services] [start-gateway-delayed]     '    ... on Product {\n' +
[start-services] [start-gateway-delayed]     '      __typename\n' +
[start-services] [start-gateway-delayed]     '      id\n' +
[start-services] [start-gateway-delayed]     '      discounts {\n' +
[start-services] [start-gateway-delayed]     '        id\n' +
[start-services] [start-gateway-delayed]     '      }\n' +
[start-services] [start-gateway-delayed]     '    }\n' +
[start-services] [start-gateway-delayed]     '    __typename\n' +
[start-services] [start-gateway-delayed]     '  }\n' +
[start-services] [start-gateway-delayed]     '}',
[start-services] [start-gateway-delayed]   variables: { _v0_representations: [ [Object] ] }
[start-services] [start-gateway-delayed] }

Note that the first one should be for Product.discounts, while the second one should be for Category.discounts.
Even though the second one should be for the Discount entity, however it still does  ... on Product, thus no data is returned and the error occurs.
With some debugging, I found out that both use the data loader under the cache key
_entities{
   discounts {
     id
  }
}

(and the cache map is also the same). I suspect that this causes both using the same data loader, and thus the second one uses the wrong query.
When I provide an alias for one of the two discount fields, it starts working, and two different data loaders are used.
I think this could potentially be fixed by including the "parent" type name (I mean Product/Category in the example) in the cache key, however I do not have sufficient knowledge of this project to be sure.

This might fix it;
https://github.com/ardatan/graphql-tools/pull/5998
Could you try it by adding @graphql-tools/batch-delegate as 9.0.2-alpha-20240319205135-b2f28663ded1506586af727ffda76b36e3016094 to resolutions in your package.json file?
Thanks for the issue!

works as expected, thx


NLog 4.6 RTM todo

Features:

#2363 + #2899 + #3085 + #3091 Database target: support for DbType for parameters (including SqlDbType) -  (@hubo0831,@ObikeDev,@sorvis, @304NotModified, @snakefoot)
#2610 AsyncTargetWrapper with LogEventDropped- + LogEventQueueGrow-events (@Pomoinytskyi)
#2670 + #3014 XmlLayout - Render LogEventInfo.Properties as XML (@snakefoot)
#2678 NetworkTarget - Support for SSL & TLS (@snakefoot)
#2709 XML Config: Support for constant variable in level attributes (level, minlevel, etc) (@304NotModified)
#2848 Added defaultAction for <filter> (@304NotModified)
#2849 IRawValue-interface and ${db-null} layout renderer (@304NotModified)
#2902 JsonLayout with support for System.Dynamic-objects (@304NotModified)
#2907 New Substring, Left & Right Wrappers (@304NotModified)
#3098 <rule> support for one or more '*' and '?' wildcards and in any position  (@beppemarazzi)
#2909 AsyncTaskTarget - BatchSize + RetryCount (@snakefoot)
#3018 ColoredConsoleTarget - Added EnableAnsiOutput option (VS Code support) (@jp7677 + @snakefoot)
#3031 + #3092 Support ${currentdir},${basedir},${tempdir} and Environment Variables for internalLogFile when parsing nlog.config (@snakefoot)
#3050 Added IncludeGdc property in JsonLayout (@casperc89)
#3071 ${HostName} Layout Renderer for full computer DNS name (@amitsaha)
#3053 ${AppSetting} Layout Renderer (app.config + web.config) moved from NLog.Extended for NetFramework (@snakefoot)
#3060 TargetWithContext - Support for PropertyType using IRawValue-interface (@snakefoot)

Enhancements:

#2989 JsonLayout includes Type-property when rendering Exception-object (@snakefoot)
#2891 LoggingConfigurationParser - Extracted from XmlLoggingConfiguration (Prepare for appsettings.json)  (@snakefoot)
#2910 Added support for complex objects in MDLC and NDLC on Net45  (@snakefoot)
#2918 PerformanceCounter - Improve behavior for CPU usage calculation  (@snakefoot)
#2941 TargetWithContext - Include all properties even when duplicate names  (@snakefoot)
#2974 Updated resharper annotations for better validation (@imanushin)
#2979 Improve default reflection support on NetCore Native (@snakefoot)
#3017 EventLogTarget with better support for MaximumKilobytes configuration (@Coriolanuss)
#3039 Added Xamarin PreserveAttribute for the entire Assembly to improve AOT-linking (@snakefoot)
#3045 Create snupkg packages and use portable PDB (@snakefoot)
#3048 KeepFileOpen + ConcurrentWrites on Xamarin + UWP - #3079 (@304NotModified)
#3082 + #3100  WebService Target allow custom override of SoapAction-header for Soap11 (@AlexeyRokhin)
Various refactorings (15 pull requests) (@beppemarazzi , @304NotModified, @snakefoot )

Performance:

#2650 AsyncTargetWrapper using ConcurrentQueue for NetCore2 for better thread-concurrency (@snakefoot)
#2890 AsyncTargetWrapper - TimeToSleepBetweenBatches changed default to 1ms (@snakefoot)
#2897 InternalLogger performance optimization when LogLevel.Off (@snakefoot)
#2935 InternalLogger LogLevel changes to LogLevel.Off by default unless being used. (@snakefoot)
#2934 CsvLayout - Allocation optimizations and optional skip quoting-check for individual columns. (@snakefoot)
#2949 MappedDiagnosticsLogicalContext - SetScoped with IReadOnlyList (Prepare for MEL BeginScope) (@snakefoot)
#2973 IRenderString-interface to improve performance for Layout with single LayoutRenderer (@snakefoot)
#3103 - StringBuilderPool - Reduce memory overhead until required (@snakefoot )

LibLog Breaking change

https://github.com/damianh/LibLog/pull/181 - Sub-components using LibLog ver. 5.0.3 (or newer) will now use MDLC + NDLC (Instead of MDC + NDC) when detecting application is using NLog ver. 4.6. Make sure to update NLog.config to match this change. Make sure that all sub-components have upgraded to LibLog ver. 5.0.3 (or newer) if they make use of OpenNestedContext or OpenMappedContext.

See also NLog 4.6 Milestone

@304NotModified new: #3082

Added to the list of enhancements.

new:

#3103
https://github.com/NLog/NLog/pull/3098

Would like to have these fixed before the final NLog 4.6:

NetworkTarget improvement by stealing KeepAlive-config from SysLog-Target.'
DatabaseTarget with AllowDbNull-property for parameter
XmlDocLayout as HeaderFooter-Layout that inserts <?xml> with attributes.
Service Fabric Shared Process support by reducing the number of static variables

Allowing multiple concurrent ${configsetting}-lookups
Allowing multiple factory CreateInstance-overrides with different dependency injection-sources.

Would like to have these fixed before the final NLog 4.6:

moved to #3122


Assess the need for glibc>2.17

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.86
OS Version: RHEL 7.9

Steps to Reproduce:

Use RHEL 7
Have problems

Many users of our supercomputer have reported that updating VS Code to 1.86 causes remote desktop to stop working; this is in line with what everybody seems to be reporting.
Apologies if this has been addressed somewhere, but is there a specific need for a new glibc? I've installed many hundreds of pieces of software from source on our supercomputer, and I've never seen a case where a new glibc is actually necessary even when it's claimed to be--usually a newer compiler is required to build, but when I install said compiler from source then build the software in question using the new compiler, it invariably works with glibc 2.17. Is there a specific reason to move to 2.28, or is that just what happens to ship with the OS that you build releases on?
My suggestion would be to build releases of VS Code with whichever supported operating system has the oldest glibc. If it would be helpful and if there isn't a verified reason for moving to glibc 2.28, I can make a reference container based on CentOS 7 (or something else if it has glibc<2.17) that has the necessary components for building VS Code (including new compiler, yarn, etc.) and validate that it works.
For our use case, we only need to survive with 1.85 for a few months since we've been working to transition to RHEL 9 for a while. Even so, it's an odd move to drop support for an operating system that hasn't reached EOL, and telling our users to refrain from security upgrades on their personal machines to retain core functionality is icky.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Please see #204135 which covers what is planned for a recovery release to address the issue.

That will certainly work for our use case, but it does seem more complicated than just compiling on an older OS, no?
I do imagine that fix will cover most users, but if I'm understanding correctly, it doesn't do anything for people running natively on e.g. CentOS 7, unless you link glibc (and whatever else is troublesome) statically or ship external libraries with subsequent releases of VS Code.

I'm sorry, I rarely vent, but enterprise/professional internal development using vs code to remote SSH into our older RHEL 7 staging server just came to a screeching halt with 1.86.0. Yes, our production server is RHEL 8, but really?

I implemented a script to temporarily solve this problem. The idea is consistent with Shipping glibc, libstdc++ dynamic libraries as part of the server package at https://github.com/microsoft/vscode/issues/204135#issue-2114877463.
repositry is: https://github.com/rectcircle/patch-vscode-1-86-for-old-linux

Open VSCode Remote SSH and connect to the old Linux device once. Once you see the message "Waiting for server log...", you can close the VSCode window.
SSH into the old Linux device and execute the patch script:

wget -O - https://raw.githubusercontent.com/rectcircle/patch-vscode-1-86-for-old-linux/master/patch.sh | sudo bash -s $(whoami)

Retry opening VSCode Remote SSH again and reconnect to the old Linux device.

Apologies if this has been addressed somewhere, but is there a specific need for a new glibc?

Yes this is requirement for our remote server executable which is a Node.js binary https://nodejs.org/en/blog/announcements/v18-release-announce#toolchain-and-compiler-upgrades. Node v16 was the last LTS that worked on these affected distros. We have already extended this support by building the binaries on custom toolchain since v1.82 but there is cost to maintaining a fork.
New extended timeline for support has been commented in https://github.com/microsoft/vscode/issues/203375#issuecomment-1927893504. Please follow that issue and the upcoming release 1.86.1 for updates.


Tree-based decoding

First of all, congratulations for this outstanding project. Creating a machine translation engine has never been this easy! The translations results are remarkable.
When translating form English into German, I've encountered some issues with verbs. If the verb consists of several parts, only the first part is translated. For example, "the door opens quickly" is translated as "Das Tor geht schnell" instead of "Das Tor geht schnell auf".Could this be due to the phrase-based model? Would a tree-based model help? Can I use treee-based decoding in MMT?

Hi @mehmedes and thanks for your comment. Tree-based decoding is not an option with MMT.
From September, we will start experimenting MMT with English-German, too.  Yes, the kind of error
you describe could be partially due to limitations of the phrase-based approach: the word "opens" aligns to two non-contiguous phrases "geht" and "auf", and during decoding only one-to-one phrases are generated. Hence, the hope is that for frequent expressions, if you have enough training data, the system contains the entire phrase-pair "opens quickly" "geht schnell auf".  Yes, tree-based decoding e.g. with a hierarchical model, could in principle solve the problem, as it would handle phrases with gaps. In this case, with a rule : X-> opens X | geht X auf
I would suggest that we go back to this issue in a couple of months, when we will start digging into En-De translation.

Thanks for your quick reply. I’m looking forward to it. You do a great job!
I was wondering whether there could be any improvements if I increased/reduced the number of n-grams.


fixed a small typo

Just a small typo at the start of the doc! This project is pretty cool!!

Thanks ! 👍


fix(45501): VS Code removes spaces between empty object literals even if insertSpaceAfterOpeningAndBeforeClosingEmptyBraces is true

Fixes #45501

Should object literals and blocks even be controlled by the same setting?

@andrewbranch  I think it depends., the option name is insertSpaceAfterOpeningAndBeforeClosingEmptyBraces does that mean {} object literals? or only blocks? Maybe formatter should have two options insertSpaceAfterOpeningAndBeforeClosingEmptyBlockBraces, insertSpaceAfterOpeningAndBeforeClosingEmptyObjectLiteralBraces. I think it is a discussable question.

What do other popular formatters do here?

@andrewbranch I'm not sure that Prettier has the option to handle spaces between empty braces{}. There is option bracketSpacing, however, it removes spaces between empty braces and leaves in non-empty object literals
{
  "bracketSpacing": true
}

Before
export function foo() { }
export const a = { };
export const b = { x: 1 };

After
export function foo() {}
export const a = {};
export const b = { x: 1 };


Add logging for identity

Add logging for Azure Identity credential types:

ClientSecretCredential
ClientCertificateCredential
ChainedTokenCredential
DeviceCodeCredential
DefaultAzureCredential
UsernamePasswordCredential
ManagedIdentityCredential
EnvironmentCredential

Can one of the admins verify this patch?


refactor: x/oracle: make GetExchangeRateBase more efficient

Description
Resolves a small efficiency issue with the GetExchangeRateBase function + will add some tests for it
closes: #865

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #866 (a949c9a) into main (87cb558) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   50.93%   50.94%   +0.01%
==========================================
  Files          64       64
  Lines        9428     9425       -3
==========================================
  Hits         4802     4802
+ Misses       4383     4380       -3
  Partials      243      243

Impacted Files
Coverage Δ

x/oracle/keeper/keeper.go
78.80% <0.00%> (+1.07%)
:arrow_up:

We should follow up on this in #661 by cleaning up this test file a bit - could be table driven


Generalised donation banner, other misc changes

Made several changes to the donation banner, making it significantly more general and usable across sites.
Additonally, improved readme language concerning configuriation.

made language more concise, and general as opposed to describing pomf.se
replaced links to neku's Flattr and PayPal donation links with swig variables found in Gruntfile.js
replaced neku's BTC address similarly; label is filled out according to siteName
added conditional statements so that only the buttons that have their matching info filled in appear
improved readme configuration section to clarify that there are settings in both site_variables.json, and settngs.inc.php, and their purpose
moved config-related, such as siteName and bitcoinAddress, variables from Gruntfile.js to site_variables.json

@ewhal

This change is

I'd squash some of those commits.

Squash the commits and swig automatically looks for global.json in the root directory I believe.
So rename site_variables.json to global.json and place it in the root folder.

Closing to remake with cleaner branch


Add deployment logs

Add deployment logs to the Vercel tab per https://github.com/ndimatteo/sanity-plugin-vercel-deploy/issues/10
Summary
This PR adds the option to view the 5 most recent deployments by clicking on the new "Logs" button that is displayed on each deployment. To accomplish this, it reuses the credentials from the deployment to query the Vercel API and displays that info in a table within a dialog.
Because I reused the same status labels, I refactored this out into a component. I also added a TimeAgo component.
Issues

The dialog width parameter didn't seem to work for me, so set to null, it takes up most of the screen width. This should probably be smaller
Paging/"view more" functionality is not implemented
Polling is not implemented
I didn't add tests, but would be happy to do so if you'd like

Screenshots
Button addition:

Dialog open:

@kylekarpack sorry for taking so long to get this added in! There were a few other nagging issues to address first, but I was able to adapt your solution in the latest version! Give it a go and let me know if you have any issues with it!
And thanks again for putting this together 🙏

Looks great, thanks @ndimatteo!


cmd/compile: reclaim binary size increase from CL 35554 constant to interface allocation optimizations

In CL 35554 for #18704, @josharian added some very nice allocation optimizations, as part of his efforts to claw back some of the allocation penalty of #8405, but at as a result had a modest increase in binary size.
In CL 35554, @josharian mentioned that the ~0.5% binary size increase could likely be recovered in the future, and there was some discussion of adding a tracking issue for that.
I did a quick look for that follow-up tracking issue a couple years ago, and again searched just now, but both times haven't found it.
Posting this new issue now in case it is helpful to either:

serve as the tracking issue for that possible future work, or
if that is already tracked (or even completed!), help a future gopher more easily follow the issue trail through cross linking ;-)

Here is a snippet from CL 35554:

This CL adds ~0.5% to binary size, despite
decreasing the size of many functions,
because it also adds many static symbols.
This binary size regression could be recovered in
future (but currently unplanned) work.
There is a lot of content-duplication in these
symbols; this statement generates six new symbols,
three containing an int 1 and three containing
a pointer to the string "a":
fmt.Println(1, 1, 1, "a", "a", "a")
These symbols could be made content-addressable.
Furthermore, these symbols are small, so the
alignment and naming overhead is large.
As with the go.strings section, these symbols
could be hidden and have their alignment reduced.

Another reason for posting now is that there is some recent renewed energy around binary size (#6853).
Sorry if I missed something obvious. @josharian or anyone else, feel free to close if this is already addressed or tracked elsewhere.

I attempted content addressability and failed, and never picked it up again. https://go-review.googlesource.com/42170
I’m not sure whether the alignment and symbol visibility changes happened. I imagine so, but cc @cherrymui just in case.

Thanks @josharian for the quick comment. Also, I should have said this explicitly that of course this might not be worth doing, especially given finite time and opportunities for other improvements. 😅


datetime vs timestamp

Hello, I was seeing some weird (to my eye) things when using this library in relation to timestamps vs datetime. Please bear with me as it's been awhile since I've wandered into the murky swamps of timezones and MySql and I'm just trying to understand what I'm seeing fully.
Looking through the code it seems that we say we support timestamps in the documentation but what is actually happening is that we throw away the timezone information and send it using datetime instead.
Now, looking through the history I saw this
https://github.com/elixir-ecto/myxql/issues/30
Now normally what happens with a timestamp (since it has timezone information) is that the server receives it and stores it at UTC. Upon retrieval the SHOW VARIABLES like 'time_zone'; is consulted and formatted - for example, if it's UTC it would stay UTC or if the local connection was "America/New_York", then the time changes to reflect that based on the current setting of "time_zone". And in the code I even see reference to this behavior
in lib/myxql/protocol/values.ex
  # TIMESTAMP vs DATETIME
  #
  # https://dev.mysql.com/doc/refman/8.0/en/datetime.html
  # MySQL converts TIMESTAMP values from the current time zone to UTC for
  # storage, and back from UTC to the current time zone for retrieval. (This
  # does not occur for other types such as DATETIME.)
  #
  # Comparing to Postgres we have:
  # MySQL TIMESTAMP is equal to Postgres TIMESTAMP WITH TIME ZONE
  # MySQL DATETIME  is equal to Postgres TIMESTAMP [WITHOUT TIME ZONE]

But what we actually do is use Datetime and throw away the tz information such that the time that comes back from MySql will always be UTC, i.e. setting the time_zone variable on the sever will have no effect. Notice the mysql type :mysql_type_datetime instead of :mysql_type_timestamp
  defp encode_binary_datetime(%DateTime{
         year: year,
         month: month,
         day: day,
         hour: hour,
         minute: minute,
         second: second,
         microsecond: {microsecond, _},
         time_zone: "Etc/UTC"
       }) do
    {:mysql_type_datetime,
     <<11, year::uint2(), month::uint1(), day::uint1(), hour::uint1(), minute::uint1(),
       second::uint1(), microsecond::uint4()>>}
  end

  defp encode_binary_datetime(%DateTime{} = datetime) do
    raise ArgumentError, "#{inspect(datetime)} is not in UTC"
  end

Is this what the following is getting at?
Datetime fields are represented as NaiveDateTime, however a UTC DateTime can be used for encoding as well

Is this what is intended or is the timestamp a work in progress? If it's intended I might add some additional documentation, if it's still in progress I'd be happy to help. Also if I'm confused, I'd be very happy to be enlightened.
Cheers!

As an illustration, if I insert a timestamp as UTC i.e. ~U[2024-07-06 02:06:58Z] when I read it out of the database it's the same.
converting this datetime we see
DateTime.shift_zone(m.updated_at, "America/New_York")
{:ok, #DateTime<2024-07-05 22:06:58-04:00 EDT America/New_York>}

if however, the time_zone of the Mysql changes, for example
SET GLOBAL time_zone = 'America/New_York';

And we do a select we get ~U[2024-07-05 22:06:58Z] that seems very similar to our shifted timezone doesn't it? Because Mysql has done the conversion for us, so we think got UTC back but we didn't, and thus if we try to convert it again we get the incorrect time.
DateTime.shift_zone(m.updated_at, "America/New_York")
{:ok, #DateTime<2024-07-05 18:06:58-04:00 EDT America/New_York>}

It's worth pointing out, that setting the database time to anything other than UTC (on Mysql) will end up with an incorrect UTC time for since we assume we're always getting UTC from mysql which in this case, it no longer is. I suspect if the time_zone for mysql doesn't change between insertion and selection we probably get the right value in Elixir, however other clients that might access the database will could get the wrong value, for example if the time is always set to "America/New_York"
It's also worth noting that I'm using an older version of MariaDb in these tests. I can test this out on the latest version as well.

I am pretty sure we work under the same assumption that the time zone in the database is UTC. Here is what we say for Postgrex:

(2) Timezones will always be normalized to UTC or assumed to be UTC when no information is available, either by PostgreSQL or Postgrex

For MyXQL, we say that:

Datetime fields are represented as NaiveDateTime, however a UTC DateTime can be used for encoding as well

I think the wording could be a bit clearer on both but the general behaviour is the expected one.

For completeness, Postgrex always converts the timezone to UTC when we read it and it is only accepts UTC datetimes when writing. I am not sure if MySQL provides similar affordances.

looking through the examples, I suspect the fix is to make the mysql connection always use UTC, as per this example.
  Run a query after connection has been established:

      iex> {:ok, pid} = MyXQL.start_link(after_connect: &MyXQL.query!(&1, "SET time_zone = '+00:00'"))
      {:ok, #PID<0.69.0>}

We can enforce it (perhaps also allow to turn it off), but maybe documenting that we expect UTC is enough.

confirmed that adding the following to my Ecto.Repo configuration solves my issues
 after_connect: {MyXQL, :query!, ["SET time_zone = '+00:00'", []]}

Agreed about docs for now. Closing in favour of #189.


codimd: js-sequence-diagrams: use git source rather than the NPM tarball

Motivation for this change
It seems as NPM just removed the tarballs of the unpublished package,
hence codimd isn't buildable. The sources for the package are
available on github[1] and fix the build.
For further information about the js-sequence-diagrams workarounds,
please refer to 5feec424de6bb9596880a778bb608f0cb5d1c570.
[1] https://github.com/Moeditor/js-sequence-diagrams
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test codimd
This should also be backported to release-19.03.

ok, so now there's https://github.com/codimd/server/pull/41/files which uses a fork of js-sequence-diagrams in the codimd org. I'll update the PR accordingly.

This doesn't seem to be possible right now as node2nix generates mismatching hashes when using the git source of codimd/js-sequence-diagrams (https://github.com/svanderburg/node2nix/issues/139)

Updated the commit message to fix a small typo. @marsam are you still okay with this? :)

Just had a short chat with @WilliButz. We both agreed that this is the best solution for now and unless I hear otherwise, I'd merge/backport the fix tonight.
I know that this isn't the best solution, but it should be fine for now. As mentioned in original issue, it's planned to switch to yarn2nix in the long term as it will significantly reduce the complexity of the current packaging situation for codimd.

As announced, I'll merge this for now. As soon as @WilliButz or I have sufficient time, the bump to 1.3 with yarn2nix will be done.

Backported as 0b8977564d2e3d4e679ff49a44f42821e6e23205.


Notebook console loop "Jupyter completion time"

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
Hi,
I get this problem when typing on a fresh new notebook created by "name".ipynb on the explorer menu, when typing on a new cell it starts spamming "[debug] Jupyter completion time:" on console and it doesn't stops.
It ramps up CPU usage and had already tryed everything to get rid of it (uninstalling vscode, python, ipykernel, extensions)  and nothing seems to fix it.
Version: 1.86.2 (system setup)
Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda
Date: 2024-02-13T19:40:56.878Z
Electron: 27.2.3
ElectronBuildId: 26908389
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
VS Code Version
1.86.2
Jupyter Extension Version
v2024.1.1
Jupyter logs
...
07:40:05.009 [debug] Jupyter completion time: 7
07:40:05.013 [debug] Jupyter completion time: 11
07:40:05.021 [debug] Jupyter completion time: 6
07:40:05.026 [debug] Jupyter completion time: 11
07:40:05.033 [debug] Jupyter completion time: 16
07:40:05.034 [debug] Jupyter completion time: 17
07:40:05.040 [debug] Jupyter completion time: 23
07:40:05.044 [debug] Jupyter completion time: 27
07:40:05.046 [debug] Jupyter completion time: 24
07:40:05.050 [debug] Jupyter completion time: 28
07:40:05.055 [debug] Jupyter completion time: 19
07:40:05.059 [debug] Jupyter completion time: 23
07:40:05.071 [debug] Jupyter completion time: 7
07:40:05.074 [debug] Jupyter completion time: 10
07:40:05.079 [debug] Jupyter completion time: 15
07:40:05.082 [debug] Jupyter completion time: 18
07:40:05.087 [debug] Jupyter completion time: 21
07:40:05.095 [debug] Jupyter completion time: 6
07:40:05.099 [debug] Jupyter completion time: 10
07:40:05.108 [debug] Jupyter completion time: 5
07:40:05.113 [debug] Jupyter completion time: 9
07:40:05.119 [debug] Jupyter completion time: 5
07:40:05.126 [debug] Jupyter completion time: 12
07:40:05.128 [debug] Jupyter completion time: 8
07:40:05.135 [debug] Jupyter completion time: 5
07:40:05.139 [debug] Jupyter completion time: 9
07:40:05.144 [debug] Jupyter completion time: 8
07:40:05.148 [debug] Jupyter completion time: 12
07:40:05.154 [debug] Jupyter completion time: 9
07:40:05.158 [debug] Jupyter completion time: 13
07:40:05.164 [debug] Jupyter completion time: 15
07:40:05.172 [debug] Jupyter completion time: 7
07:40:05.187 [debug] Jupyter completion time: 7
07:40:05.191 [debug] Jupyter completion time: 10
07:40:05.198 [debug] Jupyter completion time: 17
07:40:05.200 [debug] Jupyter completion time: 19
07:40:05.208 [debug] Jupyter completion time: 5
07:40:05.213 [debug] Jupyter completion time: 10
07:40:05.217 [debug] Jupyter completion time: 13
07:40:05.221 [debug] Jupyter completion time: 12
07:40:05.230 [debug] Jupyter completion time: 8
07:40:05.234 [debug] Jupyter completion time: 12
07:40:05.237 [debug] Jupyter completion time: 8
07:40:05.241 [debug] Jupyter completion time: 10
07:40:05.249 [debug] Jupyter completion time: 6
07:40:05.254 [debug] Jupyter completion time: 10
...

Coding Language and Runtime Version
Python 3.11.8
Language Extension Version (if applicable)
Python v2024.0.1
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local

Please could you
ms-toolsai-jupyter-insiders.vsix.zip

Please install VS Code Insiders (not stable)
Download the attached file
Extract this file
Open VS Code and select the command Install from VSIX
Select the above extracted VSIX
When prompted to reload VS Code, please do so
Try to replicate the issue once again

Also, do you have the Jupyter Powertoys extension  installed?

Yes, i do.

Please can you try disabling that extension and re-installing your old version of Jupyter extesnion (i.e. install v2024.1.1) Then try again.
The Poweroys extension is known to cause a few issues, I will be looking into that this week.

I installed powertoys because of the problem, to maybe help debug and let me close the kernel that stucks on that loop. But the interesting thing come as follows:
By uninstalling the vsix extension on the vscode insiders and installing the release (v2024.1.1), the problem appears again:

By disabling the power toys extension on vscode (not insiders) and typing, the problem continues to appear:

Any additional info let me know, i'm happy to help ^^

ms-toolsai-jupyter-insiders.vsix (1).zip
Please can you install this VSIX in VSCode insiders and let me know if the problem still persists?
Thanks for your help.
I'm trying to figure out whether the fix will be in tomorrows release or next month/
The first VSIX i gave contains fixes that will go int the next month,
The above VSIX is what we will ship as the next official relese in the next few days.

ms-toolsai-jupyter-insiders.vsix (1).zip
Please can you install this VSIX in VSCode insiders and let me know if the problem still persists? Thanks for your help. I'm trying to figure out whether the fix will be in tomorrows release or next month/ The first VSIX i gave contains fixes that will go int the next month, The above VSIX is what we will ship as the next official relese in the next few days.

Seems stable for me

Thanks, closing this issue for now,
The fix will be in the next release (some time this week)
Thanks for your help.


Add option to read state file from ASReview project file

Added function and changed existing functions to read .asreview files,.

This part of the code still feels a little awkward to me (with the duplication), but that's more with the design. Either way, nice addition. :)

I think you are right. It makes more sense to have open_state as the (only?) public function in this submodule and deprecate(?) state_from_file. I think the return value of state_from_file should be the state, not the file path and state.
Another thing:
with open_state(state_fp) as state:
        assert isinstance(state, JSONState)

This one fails now. I think it should open in read_only mode.
Maybe we should merge this PR first and make another PR to resolve some of these issues. Interested to work on this?

I think the obvious thing is to call states_from_file from state_from_dir. I don't think there is a good reason not to. Apart from that I think it's "fine". Personally I would keep it as is.

It seems logical to do everything with open_state and deprecate state_from_file. I wasn't really sure why there where two functions to access a state file, so I just left it as it was. In the analysis module (and in visualization as well) I think the filepath is used as an identifier, so that's why it is included in the output of state_from_file.
This was the first time I wrote a unit test, so if there's something wrong there, just let me know.
The following from open_state seems a little bit strange as well. If the try part raises an exception, state will never be defined, so there will be an error in the finally section?
   try:
        state = state_class(state_fp=fp, *args, read_only=read_only, **kwargs)
        yield state
    finally:
        state.close()

Thanks for your thoughts on this. I'm postponing this PR to version 0.15 such that we can have a look at the duplicate functions (in another PR).
The try-finally syntax seems to be correct. See context managers for more information on error
handling: https://book.pythontips.com/en/latest/context_managers.html.

Stop me if I'm being too nitpicky, but I think there's a difference :)
@contextmanager
def open_file(name):
    f = open(name, 'w')
    try:
        yield f
    finally:
        f.close()

In this example f is defined before the try part. In our case, state is not defined before the try part, only state_class is. Not that it will ever matter, I guess, because the way state_class is defined will catch all errors already.

Stop me if I'm being too nitpicky

I love it :) I think you are right. Thanks. At the moment, this might not be a problem. But this can become a problem when a new (database-based) state gets developed. So it would be nice to apply your suggestions. Can you open a new PR on this?

Thanks @PeterLombaers, really nice contribution.
We are facing some issues with the visualization package and asreview project files https://github.com/asreview/asreview-visualization/issues/15. So we can't make beautiful plots with it right now, but hopefully, someone can resolve this :)


4.0 GB of file

Hi all,
I'm trying to upload a file that have size of 4.6 GB via tus. But after file is about 4.0 GB the PATCH method return an error message
read tcp <IP_ADDRESS>:1080-><IP_ADDRESS>:61596: i/o timeout

Any idea?

How do you use tusd? If you use the tusd binary, please supply the exact arguments using which you invoked the binary.

I'm using tusd binary version 0.2.0 with following command
Rabitron:tusd_darwin_amd64 jirapong$ sudo ./tusd -timeout 60000 -max-size<PHONE_NUMBER>0
[tusd] Using './data' as directory storage.
[tusd] Using 10240.00MB as maximum size.
[tusd] Using <IP_ADDRESS>:1080 as address to listen.
[tusd] Core: ✓ Terminater: ✓ Finisher: ✗ Locker: ✓ GetReader: ✓ Concater: ✗

updated, I still can't find a reason but based on tus-js-client/demo/index.html itself. It is uploaded successfully

Sadly, I am not able to reproduce this. Is the timeout only triggered for bigger files (> 4GB) or do small files also not work?

Thank you. It seems like this issue went away after put the chunksize on the tus-js-client library. Thank you.


RegistryMirror Followup

What would you like to be added:

[ ] Extract the whole containerd config to a separate template so we can reuse it in different providers and also test it independently.
[ ] Standalone template for registry mirror and mirror map cleanup
[ ] Add registry mirror cert to registrymirror.RegistryMirror and possibly credentials as well
[ ] CAPI change to support multiple registry mirrors for bottlerocket

Why is this needed:

Any traction on this? It is more often than not on eks anywhere being a onprem and edge solution that mirroring private registry is a common occurrence, bottlerocket OS is the native and natural choice, without this feature there is a downside that can become major when using EKSA and Bottelrocket OS on large scale scenarios.
An ETA or considerations around the feature would be greatly appreciated.


main / module / ES2015

I wonder why we need umd set as main entry. It doesn't really work with AngularCLI and doesn't matter with SystemJS.

http://angularjs.blogspot.it/2017/03/angular-400-now-available.html?m=1
https://github.com/rollup/rollup/wiki/pkg.module


NoSuchMethodError: Class 'String' has no instance method '>'.

[ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: NoSuchMethodError: Class 'String' has no instance method '>'.
any way to fix this error?
I am trying to fix a List<CartItem> I need to sort by group then by code.
_cartItems.multisort([false, false], ['group', 'code']); not sure if this is the right way to sort.
class CartItem {
  String qty;
  final String code;
  final String desc;
  final String invt;
  final String codealt;
  final String descalt;
  final String group;
  final String price;
  final String disc1;
  String globalPrice;
  String total;
  bool isSelected;

  CartItem(
      this.qty,
      this.code,
      this.desc,
      this.invt,
      this.codealt,
      this.descalt,
      this.group,
      this.price,
      this.disc1,
      this.globalPrice,
      this.total,
      {this.isSelected = false});

  CartItem.fromJson(Map<String, dynamic> json)
      : qty = json['qty'],
        code = json['code'],
        desc = json['desc'],
        invt = json['invt'],
        codealt = json['codealt'],
        descalt = json['descalt'],
        group = json['group'],
        price = json['price'],
        disc1 = json['disc1'],
        globalPrice = json['globalPrice'],
        total = json['total'],
        isSelected = false;

  Map<String, dynamic> toJson() {
    return {
      "qty": this.qty,
      "code": this.code,
      "desc": this.desc,
      "invt": this.invt,
      "codealt": this.codealt,
      "descalt": this.descalt,
      "group": this.group,
      "price": this.price,
      "disc1": this.disc1,
      "globalPrice": this.globalPrice,
      "total": this.total,
    };
  }

  ///get function to get the properties of Item
  dynamic get(String propertyName) {
    var _mapRep = toJson();
    if (_mapRep.containsKey(propertyName)) {
      return _mapRep[propertyName];
    }
    throw ArgumentError('propery not found');
  }
}

Try to edit the multi-sort.dart file
replace  else if (a.get(preferrence[i]) > b.get(preferrence[i])) with
 else if (a.get(preferrence[i]).compareTo(b.get(preferrence[i])) > 0)
And let me know if it works or not. I'll fix this when I get free.

@deependra227 I faced the same problem as I wanted to compare strings. Funnily I fixed it for myself first and then looked for this issue here. I can confirm that "our" solution works :)
Oh and by the way, as far as I can see, preferrence can be typed as a List<String>.

It's awesome you can confirm it works, because I feel bad for not being able to test, I went for another native solution instead of package dependent and don't have the time to setup/test properly.
Feel free to close this if there is a need.

@thomasschwarzott Thank you for the confirmation.


Updated PageStreaming

Added PagedListResponse, Page and FixedSizeCollection
Added tests

Addressed PR comments, PTAL

[Current coverage][cc-pull] is 88.40% (diff: 85.92%)

Merging [#19][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.85%

@@             master        #19   diff @@
==========================================
  Files            14         16     +2
  Lines          1024       1104    +80
  Methods         107        121    +14
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            914        976    +62
- Misses          110        128    +18
  Partials          0          0

Powered by Codecov. Last update [49cb3ba...c876f12][cc-compare]
[cc-base-branch]: https://codecov.io/gh/googleapis/gax-php/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/googleapis/gax-php/compare/49cb3babf85285a3ba3ece9c2df5a566d57cbb49...c876f1274dd71ce79396632fc977893972c3658e?src=pr
[cc-pull]: https://codecov.io/gh/googleapis/gax-php/pull/19?src=pr

LGTM


Get All shared services for cost reporting

As a TRE developer,
I want to get all shared services
So that I provide those ids in Cost Management ARM REST API

@joalmeid, the user story is not accurate, we neet to get all shared services to join with Cost Management REST API response so we could return Id, Name and costs.

Reviewed. Thanks @guybartal


Skip bump mapping after glossy/diffuse bounces

Should be optional (default: skip).
What other effects can we skip after glossy/diffuse bounces?

I think it's shader dependent. It can be some SSS layers (or decrease SSS complex computation), whole reflections (when its thin enough or only visible on surface borders (fresnel)), roughness increase (to avoid high specular and so, fireflies), the classic "bounce clamp", IOR to 1, etc.
Everything that can increase convergence of glossy/diffuse rays is interesting. It's not (only) about making indirect computation faster, it's (mainly) about improving convergence with less accuracy (all you want is visual indirect "effect").
You are totally right it has to be optional and we (appleseed) choose option that give good result/speed in 90% of the case.
And as those options are always tricky for the user to understand, we should test them before (with/without).

Totally agree with everything you said!
Actually I might revise my earlier suggestion to skip bump mapping after glossy/diffuse bounces, and instead:

Be correct by default (no approximation)
Present a clear panel with all the approximations that can be enabled one by one

@dictoon @est77 this ticket might still be interesting. Adding this to our shaders in their respective advanced tab under optimizations ? Disabled by default (i.e, do not skip bump mapping on any rays), and presenting the option to disable bumping in diffuse and specular rays when ray depth > 1?

Yes, I agree, still very relevant.

Doing this manually with a 'rayswitch' node to a simpler shader in indirect bounces is common practice for me for massive speedups in other renderers... ;)

@boberfly yes, i was thinking something along those lines, built-in into the advanced settings of the shaders. I'll be testing this and measure the performance gains to see if the gains justify the added complexity.


Continuous scanner only QR code allowed

Description of the problem:
Hi guys.
I am using your Continuous scanner sample app and I have following problem. I want to allow only QR code scanning. I tried to do research but couldn't find the solution. Is there way to do this?
Thanks.
Which library version are you using? E.g. 3.5.0
Does the same happen on other devices or an emulator? Yes

You have to look closer at the code ZXing allows to include only QR codes. I think you have to set the option in the Intent.

You can configure it to scan any type of barcode - see the samples.


Technical debt output not escaped

The technical debt plugin doesn't make the message output safe, so if you have TODO and FIXME tags in HTML and JS files you can get bits of actual HTML and javascript inserted into the page

This should be easy to fix in PHPCI/Plugin/TechnicalDebt.php:
                    $content = trim($allLines[$lineNumber - 1]);

To:
                    $content =  htmlspecialchars(trim($allLines[$lineNumber - 1]));

If I don't get around to creating a PR for this over the next few days, please feel free to go ahead and do it. :)

Searched pull requests and couldn't see one.
Implemented @mikebronner 's suggested fix.

That's much of a front-end issue. It would be better to store the data unaltered and escape it in the view/JavaScript.

@Adirelle that was what I was thinking
@adamazing @mikebronner Sorry about not doing the pull request, been a bit busy

No worries @REBELinBLUE I just happened to be bored and browsing the easy-fix tag and thought I'd help. I'm rushed off my feet now so I'll just delete the PR and leave the issue open for another person/time. :)