GO:0006544 glycine metabolic process remove parent?

GO:0006544 glycine metabolic process
is_a
GO:0042133  neurotransmitter metabolic process
but this is not true for all glycine metabolism? e.g. tRNA metabolism, porphyrin biosynthesis..

This is right according to
https://en.wikipedia.org/wiki/Glycine#As_a_neurotransmitter

Yup so is glutamine, just not in all contexts.

yes, so what I mean is that
"neurotransmitter metabolic process" is to "glycine metabolic process"
like
"homologous recombination" is to "DNA repair"
some times it is part of it, sometimes not, so it shouldn't be an is_a?

Ah interesting idea ! @cmungall @ukemi : could we sort out this 'roles' problem by using a different relation?

Fixed by @krchristie  CheBI roles work?

Fixed by @krchristie CheBI roles work?

Looking at the inferred view of the editors file in Protege, it looks to me like this relationship has been removed by ceasing to infer over roles, so yes I think this is fixed.

@ValWood - thanks for tagging me on this

Can we go further and just remove neurotransmitter {metabolism,catabolism,biosynthesis}?
They are not useful as query classes as results will be confusing incomplete
They seem not particularly useful as classes to directly annotate to. we surely always known more specifically what the chemical is. or in some cases there may be a more informative term for the synaptic context.
E.g
https://www.ncbi.nlm.nih.gov/books/NBK11110
I thought at one point we had decided to remap these to something like synthesis and part-of some neurotransmission?
Some of the direct annotations to biosynthesis come from a mapping from
https://reactome.org/PathwayBrowser/#/R-HSA-112311
it's not clear why this is mapped to the term. Made a separate ticket: https://github.com/geneontology/pathways2GO/issues/113
We also get a lot of annotations to these groupings from
https://www.uniprot.org/keywords/KW-0531
https://www.uniprot.org/keywords/KW-0531
I think a more descriptive term may be more useful here


Kinetic Preloader added

Description
Fixes #323
Type of change

[x] New feature (non-breaking change which adds functionality)

No testing required.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

This looks cool!!

@VidhiBhatt01  Please merge the PR. I have already raised the PR

PA will merge it soon

I can only review it.

Okay mam

@varisha-025 template is cool but please make this PR in amazing css effects


[Fix] warning raised when tests

Summary
Many warnings, including the following FutureWarning, are raised when testing. They should be fixed.
Codes
Run tests in the ./tests directory.
Outputs
../covid19-sir/covsirphy/gis/_layer.py:128: FutureWarning: In a future version, `df.iloc[:, i] = newvals` will attempt to set the values inplace instead of always setting a new array. To retain the old behavior, use either `df[df.columns[i]] = newvals` or, if columns are non-unique, `df.isetitem(i, newvals)`
  df.loc[:, self._layers] = df[self._layers].astype("string").fillna(self.NA)

Environment

CovsirPhy version: 2.27.0
Python version: 3.10.7
Installation: poetry
System: Linux

In tests with pytest, un-ignorable warnings should be marked as errors and fixed.

How to capture warnings:
https://docs.pytest.org/en/6.2.x/customize.html#pyproject-toml


frontend: Adds filter feature for app catalog

Add Filter for Verified and Official Apps in App Catalog
Description
Fixes Issue #21
This PR introduces a new filter in the app catalog that allows users to choose whether to display apps based on their verification and official status. By default, the app catalog will only show apps that are verified and official, enhancing security and ensuring that users are installing trusted applications. Users can use the new filter to include apps that are not verified or official if needed.
Changes

[x] Added a filter option in the app catalog UI to toggle the display of verified and official apps.
[x] Set the default filter state to only show verified and official apps for enhanced security.
[x] Implemented functionality to allow users to change the filter settings to include apps that are not verified or official.
[x] Updated the app catalog logic to respect the filter settings and dynamically display the appropriate apps.

Verification

[x] Verified that the default state of the filter shows only verified and official apps.
[x] Tested the filter functionality to ensure users can toggle the display of unverified and unofficial apps.

Screenshots

-- the last push

have options to filter by verified, official, and cncf (commented out verified and official)
sets default search params to be true for verified and official
note: any non verified or official charts will not display, to access them turn on commented buttons and toggle

currently the issue is that we do not render anything that does not match the search parameters (that are currently set on a default) so charts that are not verified or official do not show up
this is tricky as we use the facets object from the api response to use for our displayed charts and pages navigation

Previous push
Fixed

[x] fixed issue where toggle would reset on leaving page
[x] fixed issue where local storage would not save
[x] Added table for additional plugin options
[x] Added working switch for "show verified" items

Next

[ ] need to fix issue where last page would not render correct items (renders empty error message)
[ ] need to fix or add a redirect link

Previous push
Fixed

[x] Fixed last page not rendering the items for default
[x] Fixed total number of items to accurate helm items

To do

[ ] Need to fix last page of filter search (currently using filter options like Networking and CNCF does not display the right number of items for that criteria)

Previous push
Fixed

[x] ! Refactoring the way pages are set and how we find totals for items

Before we were taking the total number of all the different kinds in facets and adding them together to get the total of items and not using the number of helm items that are available like on the main site

[x] ! NICE Fixed total number of items to accurate helm items (USING THE HEADER TO FIND THE TOTAL NUMBER OF ITEMS)

[ ] MOSTLY FIXED Need to fix last page of filter search (DOUBLE LOADS ON OPTIONS CHANGE AND DOES NOT KEEP UP WITH OPTIONS CHANGE)

To do

[ ] Need to fix new offset setting
[ ] NEED Fix last page not rendering the items for default

Prev push feat progress
Done

[x] Add section for settings using name value table in the extra settings
[x] Add hover tool tip for show verified
[x] Add a link to the settings page from the catalog page
[x] Remove buttons from catalog view
[x] Remove CNCF filter options from logic

Current screenshots
Main Catalog Page

When clicking settings link

App-Catalog Settings Page

Push note

refactoring improvements

moving to WIP until solution for the response header proxy is in

Notes for the pagination issue:
When running 'dev only app' our localhost is set to 3000 via ELECTRION_ and we hit a cors wall which does not provide the header for pagination total count
If the app mode is ran with 'npm run dev' the origin is not set to localhost 3000 and cors does not apply
(This can be done by referencing the Network tab and looking for the 'origin' field under Request Headers)

note that the X-Cache reads 'Miss from cloudfront' on this example where the pagination response header is not reached

This means it will not work with 'npm run start' and 'npm run dev only app' but for production and 'npm run dev' it will

When reviewing the app catalog pages should be somewhere in the 500s meaning the default off a fresh start is set to true, if it is in the 1000s this means the default is set to false for new starts (which needs to be set to true and there is an error somewhere)

@illume @sniok
After running the plugin in a new env I noticed that the feature does not default to true when loaded up for the first time. This is a main point of the feature for security reasons that it would need to default to the showVerified being true for new users (they can choose to disable it in the settings later). I am rolling back a few changes that clash with the intended functionality.
the changes for store.useConfig() does not provide the fields needed to extract the showVerified boolean, where as store.get() does provide an empty object on first load that when paired with the useEffect on page load would set the store to showVerified default to true. I am also removing the previous showVerified usage that is tied to a useEffect watch parameter as it would kick off an unneeded page reload for first time users when the showVerified is set to true.
The list view is a sperate page from the settings view, which does nothave a way for users to manually change the showVerified option from the list page (they would need to leave the page, click settings to nav them to the settings page, and then nav back to the list page, thus making the reloading of the useEffect on the List view whenever the showVerified changes also unneeded)

Trying to use the const config = store.useConfig and then trying to use config.showVerified does not work and will constantly return empty, this will always set the verified boolean to true in this example below

on the first box, they both default to true
the middle box is when users switch to true to false
the last box is when returning to the page, the config is not saved and config.showVerified will never exist
This is what I have previous minus the use of the empty useEffect hook. It still functions as intended and changes the boolean as needed from the settings.

closed the outdated ones

hey hey.
I just noticed the commit messages messages need mending:

AppCatalog: Fixes stories for AppCatalogTitle and SettingsLink
frontend:

Use app-catalog: and the component(s) as the context.
Use a singular verb to start it. Fix, not Fixes.
app-catalog: ChartsList: Fix verified publisher bug
app-catalog: ChartsList.stories: Add verified publisher states

hey hey.
I just noticed the commit messages messages need mending:

AppCatalog: Fixes stories for AppCatalogTitle and SettingsLink
frontend:

Use app-catalog: and the component(s) as the context. Use a singular verb to start it. Fix, not Fixes.
app-catalog: ChartsList: Fix verified publisher bug app-catalog: ChartsList.stories: Add verified publisher states

Should be the right way now!

Should be the right way now!

Awesome & thanks.


feat(core): Implement revalidate for reads

Implement revalidate for reads.

Coverage decreased (-1.3%) to 80.523% when pulling 72ee6e0967ebcb6f8fb0acdbfbb32af089486d85 on feature/revalidate into e2aa45f1df4068d87a856a2d6013f54bfaf79f80 on master.


Provision a Principal per-namespace

Trying to provision a Principal at the same time as any other AWS
resources using the service operator can lead to a race condition where
the IAM role hasn't been created by the time CloudFormation tries to
provision the other resources. At this point the stack creation with
fail and everything ends up in a bad state.
We might as well provision a Principal when setting up the namespace
to allow for trouble-free provisioning of AWS services in the
namespace's own charts.

Huh. If there's a race condition it feels like we could be using CloudFormation more effectively.
I would suggest that to avoid race conditions we could consider using nested stacks.  The idea is that we have a CloudFormation templates for:

a Principal, with an Output with the ARN of the Role
a Queue, with a Parameter with a list of ARNs that can access the SQS queue
a top-level template, which provisions a Principal and a Queue and feeds the output of the Principal stack into the Parameter of the Queue stack.

That way, CloudFormation handles the orchestration of provisioning the different stacks and ensures that the Queue stack waits until the Principal has been created.
I'm probably missing quite a lot of context though.

Yeah I would suggest making service operator smarter rather than doing this. It feels like it undermines the point of the principal resource. If we come to rely on this we may as well just terraform all the roles for each namespace and remove the Principal concept from the service operator.

@philandstuff nested stacks sound like the way we'd want to go - how does it work if we want multiple AWS resources? Would the service operator keep modifying the top-level stack template?

(Worth noting before anyone begins a big service operator rewrite that @chrisfarms is currently doing a lot of work on it)

Now that #472 is merged, can this be merged too?

I think with that merged we probably don't need this anymore, it should've solved the underlying problem this was aiming to address.

Fair, I saw a link to a PR and the words "address the race condition" and assumed one was a pre-requisite. Closing. Please re-open if this is still required.


PEVs for Waxholm atlas missing

I noticed that the ParcellationEntitiyVersions for the Waxholm atlas are missing (all PEVs for all versions). This might be because they were "forgotten" in the migration from the SANDS repo to the instances repo or because something should be updated before they can be migrate here.
@lzehl could you please check why these have not been moved here? Thank you!

Resolved with PR #46


Force opam to use "sh" sytanx

suggested by @Ilazki
should solve https://github.com/akabe/ocaml-jupyter/issues/154

Thank you for your patch!


Added 'danger willrobinson' easter egg

Every command line tool needs an easter egg with breathtaking ASCII art.

Interestingly enough, the motto of house Danger is: everything is fixable.

Wait, is that REALLY orta?

heh, yep. This project is named after my girlfriend, Danger. That's her house motto. Mine is; Time and Patience.

I'm confused :confused:

haha

we should ship this? Either that or we ship an ASCII version of my girlfriend ;)

Hi there o/

[danger warning] Hi there o/

danger ⚠ HPull Request exceeds maximum number of changed lines

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

  | 1 Errors
------------- | ------------ Orta is not really orta
  | 1 Warnings
------------- | ------------ Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign:
Orta is not really orta

1 Warnings

:warning:
Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

2 Errors

:no_entry_sign: | Orta is not really orta

:no_entry_sign: | Some random warning

:white_check_mark: No warnings found

  Generated by
    danger
  on
  2016-01-04

2 Errors

:no_entry_sign: | Orta is not really orta
:no_entry_sign: | Some random warning

:white_check_mark: No warnings found

  Generated by
    danger
  on
  2016-01-04

:white_check_mark: No errors found
:white_check_mark: No warnings found

  Generated by
    danger
  on
  2016-01-04

Awesome, orta is now orta. The universe breathes a sigh of relief.

Fixed @orta

:white_check_mark: No errors found
:white_check_mark: No warnings found

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

1 Messages

:book: | This pull request adds 0 new lines

  Generated by
    danger
  on
  2016-01-04

1 Errors

:no_entry_sign: | Orta is not really orta

1 Warnings

:warning: | Some random warning

1 Messages

:book: | This pull request adds 0 new lines

  Generated by
    danger
  on
  2016-01-04

2 Errors

:no_entry_sign: | Orta is not really orta
:no_entry_sign: | Unkown author

1 Warning

:warning: | Some random warning

1 Message

:book: | This pull request adds 0 new lines

  Generated by
    danger
  on
  2016-01-04

2 Errors

:no_entry_sign: | Orta is not really orta
:no_entry_sign: | Unkown author samritchie

1 Warning

:warning: | Some random warning

1 Message

:book: | This pull request adds 0 new lines

  Generated by
    danger
  on
  2016-01-04

1 Error

:no_entry_sign: | Orta is not really orta

2 Warnings

:warning: | Some random warning
:warning: | Author @samritchie is not a contributor

1 Message

:book: | This pull request adds 0 new lines

  Generated by
    danger
  on
  2016-01-04

1 Error

:no_entry_sign: | Orta is not really orta

2 Warnings

:warning: | Some random warning
:warning: | Author @samritchie is not a contributor

2 Messages

:book: | This pull request adds 0 new lines
:book: | #<Sawyer::Resource:0x007f92ccbab4c0>

  Generated by
    danger
  on
  2016-01-04

:white_check_mark: No errors found

1 Warning

:warning: | Author @samritchie is not a contributor

1 Message

:book: | Tests are updated / added

  Generated by
    danger
  on
  2016-01-04

:white_check_mark: No errors found

1 Warning

:warning: | Author @samritchie is not a contributor

1 Message

:book: | Tests are updated / added

  Generated by
    danger
  on
  2016-01-04

:white_check_mark: No errors found

1 Warning

:warning: | Author @samritchie is not a contributor

1 Message

:book: | Tests are updated / added

  Generated by
    danger
  on
  2016-01-04

Alright, I'm calling this ( especially as it's now full of felix-bot comments :D ) and closing it, I like the idea, but not yet, easter eggs can come post-1.0


store: Query failure on Seg fault

Similar to https://github.com/thanos-io/thanos/issues/3497
Reported by @arvidsnet

not sure if it is the same issue, but I have SIGSEGV errors also in store 0.17. Attached logs.
store-0.17.SIGSEGV.log

(Marking as query failure as from v0.17.1 code should treat Seg faults as recoverable panics, if not - let us know :hugs: )

unfortunately I do not know how to reproduce it. So far it happened only 2 times since upgrade to v0.17.

Still valid. Need investigation.


Implement serde traits for Weight

For types that do not have a specified serialisation format we provide explicit functions so users are forced to make a decision when serializing. We do this for

Amount
SignedAmount
FeeRate (in #3666)

Since Weight has a unit (weight units), has no specified serialisation format, and could be confused with virtual bytes perhaps we should do the same for Weight?

No, Weight is literally named after the unit it represents. It is an integer number of weight units. We should just serialize it as an integer. There is no other way that makes sense.
Anybody who legitimately confuses weight with vb (not just making typos that hopefully the compiler will catch) has no hope of writing correct code anyway and we don't need to worry about them.

I added a serde label because there is a to of serde work that needs doing soon.


Bug fix - Logical not doesn't work with browser conditions

Issue:

Logical not doesn't work with browser conditions #175

Changes:

updated not arrow function to simple function
Test case added regarding issue

fixes https://github.com/webdriverio/wdio-wait-for/issues/175

Released in v3.0.11. Thanks a lot!


athena and uploader cleanup

[ ] bz2 compression for uploads is duplicated between athena and uploader

Can you split this up into smaller, self-contained PRs? For example, adding type hints is a nice easy to merge PR. Let's also split this by athena/uploader unless there's a reason not to.


Add tempest/tempestconf options

This patch introduces:

tempestconfRun section for the Tempest CR. This field allows a user to specify parameters with which discover-tempest-config should be executed inside the Tempest pod.

a set of parameters for the tempestRun section in the Tempest CR. These new parameters allow a user to specify aruments with which tempest command should be executed inside the Tempest pod.

The documentation is updated as well so that it demonstrates how the new fields should be utilized.

Related patch for tcib: https://github.com/openstack-k8s-operators/tcib/pull/95

@arxcruz here is the related PR for tcib => https://github.com/openstack-k8s-operators/tcib/pull/95

tcib PRs got merged, we can proceed with this one now

/recheck

/lgtm


Bug fix for Docker example in docs: make Geckodriver container only accept connections from localhost

This is a fix for issue #38.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Erno Kuusela seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Just the CLA remaining. +1

ping @erno , would be nice to get this in :+1:

Just the CLA remaining. +1

ping @erno , would be nice to get this in :+1:

Docker installation is changing so no need for that geckodriver image to be installed separately. Thanks for the PR anyway!


Fix & add

Fix EnumHelper.GetDescription() : if there is no description attribute, the description is the ToString() of the enum value.
Add AtomicBoolean: thread-safe management of an boolean
Add DateTimeSmart: makes it easy to convert a string to a datetime

I recreate the issue making forks and branches in my repository. Follow me on these frequencies!


edit file

@MagOneDevX lib/domains/tlds.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@MagOneDevX Hello. Modification of system files and code is not allowed in the repository. Also, the domain that you wish to add has been abused recently and will not be added to the trusted list.
Please use an alternative method to get the license: please enroll to GitHub Student Developer Program at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).
I have to close this request without merging.
Thank you for your understanding!


feat: use aind data schema v1.0

closes #82, closes #74

pins aind-data-schema 1.0.0
update unit tests due to new qc field and removed mri_session
update external_links format for future records

Please note:

The external_links default value is still set to [] in aind-data-schema. I created a ticket in aind-data-schema to fix this.
We will modify the existing external_links in docdb in a future ticket in aind-data-migration-scripts

@jtyoung84 FYI this repo doesn't have a dev branch yet so merges to main will take effect in the next indexer run


big qa net (30k accounts, small epoch) died in epoch 7 (for the second qa net in a row?)

I think this network is not successful because k is too and epoch is too short and catchup doesn't happen quickly enough.
The network is a live for ~24 hours (1/4 20:00 - 1/5 20:00), and produced ~240 blocks.
fish-block-producer-3 restarted at 1/5 04:57 (there's no log shows why it restarted at the first place), after it booted up, it didn't need to do bootstrap, and before it finishes catchup, it would first try to calculate the next block production time. At this moment, it only has the root (genesis_block), and thus an empty epoch is detected and it crashes. And this would repeat forever.
The next one is whale-block-producer-3; first crashes at 1/5 12:42
The next one is whale-block-producer-1; first crashes at 1/5 14:54
The next one is fish-block-producer-4; first crashes at 1/5 16:54
The next one is fish-block-producer-5; first crashes at 1/5 18:17
At around 1/5 19:57, a lot of nodes restarted. There's no crash logs says why they crashes at the first place. But once they restarted, they hit the empty epoch.

I think this network is not successful because k is too and epoch is too short and catchup doesn't happen quickly enough.
The network is a live for ~24 hours (1/4 20:00 - 1/5 20:00), and produced ~240 blocks.
fish-block-producer-3 restarted at 1/5 04:57 (there's no log shows why it restarted at the first place), after it booted up, it didn't need to do bootstrap, and before it finishes catchup, it would first try to calculate the next block production time. At this moment, it only has the root (genesis_block), and thus an empty epoch is detected and it crashes. And this would repeat forever.
The next one is whale-block-producer-3; first crashes at 1/5 12:42
The next one is whale-block-producer-1; first crashes at 1/5 14:54
The next one is fish-block-producer-4; first crashes at 1/5 16:54
The next one is fish-block-producer-5; first crashes at 1/5 18:17
At around 1/5 19:57, a lot of nodes restarted. There's no crash logs says why they crashes at the first place. But once they restarted, they hit the empty epoch.


Use source version of alphabetical_paginate

Chris' PR was merged into master (and is the only change since v2.3.3 which was the previous version we used).
We want to use the changes in his PR to ensure that we're ready for Rails 6.

I've raised a PR on the source repo to bump the gem version.  If this gets merged then we can revert to using plain old rubygems


Performance of Select Mode for MapboxGL/MaplibreGL Adapters

There have been reports (#44) that selection mode in MapLibreGL Adapter could be better.
I don't have any intimidate ideas of how to improve this as most of the performance improvement options were exhausted by #30. One option for users is to increase the dragEventThrottle up from 5 to 10/15. This may help slightly in rendering performance however it may change the UX of dragging for users (worth just experimenting and seeing what feels right).

Hi @JamesLMilner, I had a quick look at this issue, as I was experiencing something similar in code I was writing. I think (if I'm tracing this code correctly) the setData(...) is getting behind because it's kind of a slow operation. So we can end up getting "lag" on slow devices. So essentially the following series of events ends up getting applied, even though you've already decided to update with another value.
A --> B --> C --> D --> END
A -------------------> B -------------------> C -------------------> D  -------------------> END

What we want instead is for change B and C to be skipped, and replaced with a single update to D
A --> B --> C --> D --> END
A ---------------------> D-------------------> END   (we skipped B and C here)

The code trail in the maplibre-gl-js code

https://github.com/maplibre/maplibre-gl-js/blob/fbdb32dc439f41c37d1a6dc2d695f10446b72016/src/source/geojson_source.ts#L222-L227
https://github.com/maplibre/maplibre-gl-js/blob/fbdb32dc439f41c37d1a6dc2d695f10446b72016/src/source/geojson_source.ts#L345
https://github.com/maplibre/maplibre-gl-js/blob/fbdb32dc439f41c37d1a6dc2d695f10446b72016/src/source/geojson_source.ts#L378

I've had a go at writing a setDataLazy(...) helper, which appears to be helping locally. However I need to test this more and deal with edge cases / error conditions.
private async _setDataLazy(sourceId: string, newData: any) {
	const source = this._map.getSource(sourceId) as GeoJSONSource;

	if (source) {
		const queueItem = this._queue.get(source);

		if (queueItem) {
			if (queueItem.nextPromise) {
				// If we're already waiting just update the data for the next iteration + the count.
				console.log("number waiting:", queueItem.nextCount);
				this._queue.set(source, {
					...queueItem,
					nextData: newData,
					nextCount: (queueItem.nextCount ?? 0) + 1,
				});
				await queueItem.nextPromise;
			} else {
				// Unwrap a promise.
				let resolve: (value: any) => void;
				const p = new Promise<boolean>((_resolve) => (resolve = _resolve));

				this._queue.set(source, {
					...queueItem,
					nextData: newData,
					nextPromise: p,
					nextResolve: resolve!,
					nextCount: (queueItem.nextCount ?? 0) + 1,
				});
				await p;
			}
		} else {
			(source as GeoJSONSource).setData(newData);
			const p = new Promise<boolean>((resolve) => {
				this._map.on("data", (e: any) => {
					// Wait for the update to respond from the worker.
					if (
						e.dataType === "source" &&
						e.sourceDataType === "content" &&
						e.sourceId === sourceId
					) {
						resolve(true);
					}
				});
			});

			this._queue.set(source, { pendingPromise: p });
			try {
				await p;
			} catch (err: any) {
				console.error(err);
			}

			// Because we're async previously, fetch the data again to see if we have a pending update.
			const queueItemAfter = this._queue.get(source);

			this._queue.delete(source);
			if (queueItemAfter && queueItemAfter.nextResolve) {
				await this._setDataLazy(sourceId, queueItemAfter.nextData);
				queueItemAfter.nextResolve(true);
			}
		}
	}
}

There is a branch over at https://github.com/JamesLMilner/terra-draw/compare/main...orangemug:terra-draw:fix/set-data-lazy if you want to give it a try.


Template colour changer

Feature Request report

[x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I’ve read and agree to the Code of Conduct.
[x] I’ve searched for any related issues and avoided creating a duplicate issue.

Template colour changer:

As a user I want to share the custom colour scheme
As a user I want to input my colours and see them in the design system
As a user I want a fast and accessible experience
As a user I want to change the colours in IE8
As a user / team member I want to share and talk about the product, a memorable name will be useful

Tasks

[ ] Create a server that either sends back either:

[ ] A themed html page with a new css file
[ ] A css file to inject into a html page

[ ] This response should be added to designsystem.gov.au inside an iframe
[ ] The URL for the iframe should point to the server
[ ] On submission of form change the url and update the iframe src to load a new page
[ ] On refresh of the page the iframe src should be based off the page url
[ ] The URL with eight colours will be very long and have encrypted symbols ( # = %23 ), see if we can shorten it with base64
[ ] Load different template HTML
[x] A fun name for the tool ( and fun comments / error messages ) --> Chameleon
[ ] Make it work in IE8 and make it accessible
[ ] Make sure the colours submitted are actually colours, otherwise there needs to be an error ( server side preferably )
[ ] Update iframe and URL without refreshing the page
[ ] Work out an efficient way to get templates and any necessary custom styles ( pulling in HTML from https://govau.github.io/uikit-starter/ and replacing css does not give custom styles )
[ ] Look into a11y colour checker and how it works, technically we should be able to give all white and it should work out a colour scheme that works for foreground and background (edited)

I've migrated alot of the relevant issues to https://github.com/govau/chameleon/issues.
Let me know if I've missed some that still need to be done

I am going to close this issue as we have a new repository! wuhuu thanks @adamzerella


Standardize client and converter methods

Up to this point, I've ignored the fact that clients (formerly readers) and converters have different methods and/or methd parameters. This is fine in a programmatic enfironment where you're dealing with one system. I'm starting to want to deal with multiple systems, and I want to be able to do so in a standard way. To that end, I've standardized the method names and some of the parameters.
Highlevel changes:

Renamed "Reader" to "Client"
Standardized clients to have ls, create, and get_schema methods.
create takes standard URL parameters (from urllib.parse.urlparse)
Add recap.clients.create_client factory method to create clients from URLs
Moved type conversion logic for dbapi clients into the converter package

I did all this because I want to be able to have a CLI like this:
recap add my-pg-db postgres://user:pass@host:port/db
recap ls my-pg-db
recap ls my-pg-db/some_catalog
recap ls my-pg-db/some_catalog/public
recap schema my-pg-db/some_catalog/public/some_table

or
recap add my-confluent-registry https+csr://my-confluent-registry:1234/some/root
recap ls my-confluent-registry
recap schema my-confluent-registry/some-topic-value

I also want to mimic this behavior in a Recap gateway with a URL structure like:
http://some_recap_gateway/ls/<path...>
http://some_recap_gateway/schema/<path...>

Both the CLI and gateway will use python-dotenv to manage environment variables via a .env file. The variables will be read using pydantic-settings.
In cases where the URL scheme is not enough to determine the client type, a '+' must be included in the scheme. See the https+csr example above for the Confluent Registry (+csr).

@mjperrone @cpard FYI- This is a significant refactor. I want to make sure you guys have visibility into it. There shouldn't be any behavioral changes, but see the commit for details on what and why I'm doing this. LMK if you have any questions/comments/concerns/feedback.


Fix avatar on other pages.

The styling wasn't being set on the parent container so you ended up
with weird things.
@keybase/react-hackers

:thumbsup:


Refactoring and fixing build

Do not be scared by the large number of files.  I moved directories and it includes all the files in those directories.
Only files changed

build.sh
CMakeList.txt

Moved some folders around to better follow RAPIDS.
Changes some build commons to match other RAPIDS so that arguments are consistent
updated the build process (cmake) for the new paths/folders
Added an empty CHANGELOG file
The next PR will address docs, so ignore that part of the build script

LGTM, thanks!


readOnly schema property wrong behaviour

bug report
Current behavior
If readOnly is present in schema field is disabled no matter what value it has.
Expected behavior
readOnly value should represent state (disabled/enabled) of form control.
If "readOnly" has a value of boolean true, it indicates that the value of the instance is managed exclusively by the owning authority, and attempts by an application to modify the value of this property are expected to be ignored or rejected by that owning authority.
Minimal reproduction of the problem
StackBlitz
It blocks different implementations even with mapFunction
public mapFun(mappedField: FormlyFieldConfig, mapSource: JSONSchema7 & MySchema): FormlyFieldConfig {
    mappedField.hideExpression = mapSource.hidden;
    mappedField.templateOptions.disabled = false; //after this line field with readOnly property is still disabled
    return mappedField;
}

readOnly should be boolean, if you want to use disabled state pass it throughout widget or use map fn,
here is a working example https://stackblitz.com/edit/angular-q5jhl7-atef96

It doesn't matter what is in readOnly property if it is present I cannot change disabled state. Field is always disabled. Cannot change it trought widget. How is this the way it should be. If you can present the way to change this by checkbox or something cause your described way doesn't work:
example

fixed in 5.1.2, passing false value to readOnly should not disable the input.


Rename folder collapses it

Issue Type: Bug
1.Rename folder

VS Code version: Code - Insiders 1.21.0-insider (efa33330fb0ab23b022bdff125311bdb21494b71, 2018-02-21T09:22:14.399Z)
OS version: Windows_NT x64 10.0.16299
Reproduces without extensions

Code pointer https://github.com/Microsoft/vscode/blob/isidorn/searchPanel/src/vs/workbench/parts/files/electron-browser/fileActions.ts#L208

feature-request - does it mean that this is the expected behavior?

I m on it.

@usernamehw it is always debatable if something is a feature-request or a bug. I guess this is more of a bug, but I took the artistic freedom and assigned feature-request.

@isidorn it does not seem to restore the full expansion state, only the first level is that true?

@bpasero yes, only the first level.
@ntovas could improve the PR and try to restore more.

Yes, i can do that.

@ntovas great, tree should have api to get the exapnsion state. And once the pr is ready just ping me on it.

@bpasero  @isidorn  a good candidate is the refreshChildren() on treeModel:450 but its already too long.
Should i make 2 new methods, one to return all the expanded children as array and one to expand them again?

@isidorn Is this ready for verification?

@sandy081 @bpasero ben already verified and can add a verified label. There are some limitation which @ntovas will tackle in a pr for next milestone


Add missing API methods

https://developer.uber.com/v1/api-reference/

Could you please update the README with documentation on these new end points?

@stevenmaguire updated

Great Thank you.


Update frontier-squid documentation

This renames squid.md to frontier-squid.md and updates it to the current twiki version.
https://twiki.grid.iu.edu/bin/view/Documentation/Release3/InstallFrontierSquid

[x] Enter date into "Migrated" column of google sheet
[ ] Add migration header to TWiki document

I am mostly OK with them. Pretty extensive changes though, and they'll need to be applied to the other pages as well. I had noticed the ::console in other pages but couldn't get it to work, I think because I was accidentally trying three colons. I had put in the  lines after code blocks because that was the only way I could get it to put enough whitespace there. It looks OK on this page but might be a problem on the cvmfs page.
One questions, though: Is it really necessary to tell people to do a complete wipe of their yum cache and update of all rpms just to install frontier-squid? I think that's a bit much.

The console seems to work for me with 2 and 3 colons, curiously enough.
As for clearing the cache and updating all RPMs, it is our general recommendation to our users when installing packages from our repos. Merging.


docs: update keywords

idk how (given the changes you made) but the docs build is broken. does it work locally when you try to run yarn build in the website folder?

giving same error locally too 🤔

@B4nan fixed

dont tell me its about www. prefix, that sounds more like a fluke to me. let me check locally.

the build is working just fine on my end locally without your "fix" :] probably a fluke, please revert that and let's try again. also you should clone the repo and make a branch instead of forking, it could have an effect on the PR checks too since you won't get all the secrets available if you run against a fork (although it sounds weird that it would be the culprit here).

the build is working just fine on my end locally without your "fix" :] probably a fluke, please revert that and let's try again. also you should clone the repo and make a branch instead of forking, it could have an effect on the PR checks too since you won't get all the secrets available if you run against a fork (although it sounds weird that it would be the culprit here, especially since now it works fine).

:P ok! will do that. make sense, was failing on my local setup too. will clone directly.

so its passing as i expected. weird that it wasn't working before...


[Python] List array conversion to Numpy N-d array

When converting a single-dimensional array to numpy, the dtype is preserved

import pyarrow as pa
x = pa.array([.234,.345,.456])
x.to_numpy().dtype # dtype('float64')

But when doing the same for a multi-dimensional array, the dtype is lost and cannot be set manually

x = pa.array([[1,2,3],[4,5,6]]).to_numpy(zero_copy_only=False)
print(x.dtpye) # object
x.astype(np.float64) # ValueError: setting an array element with a sequence.

Which is to say that numpy believes this array is not uniform. The only way to get it to the proper dtype is to convert it to a python list then back to a numpy array.
Is there another way to achieve this? Or, at least, can it be fixed such that we can manually set the dtype of the numpy array after conversion?
I know that pyarrow doesn't support ndarrays with ndim>1 (https://issues.apache.org/jira/browse/ARROW-5645) but I was curious if this can be achieved going the other way.
Reporter: Ben Epstein
Note: This issue was originally created as ARROW-14320. Please see the migration documentation for further details.

Does the arrow team plan on building an internal fix for this?

There has been recent discussion around support for tensors as a canonical extension type.  That might be a better and more general purpose solution for this ask.  I am not as familiar with all of the nuance involved but I would encourage you to take a look at 123 and see if that proposal could work.

Wouldn't it be better to convert an arrow tensor type into an arrow list of structs?
This would make multidimensional matrixes searchable..
You could also write this efficiently to parquet.
What is missing in the solution above are the names for x (3 columns) and y (2 rows).
    Bob | Mary | John

Kids         1 | 2 | 3
Cars         4 | 5 | 6
[{'Bob', 'Kids',  1}, {'Bob', 'Cars', 4}, {'Mary', 'Kids',  2}, {'Mary', 'Cars', 5}, {'John', 'Kids',  3}, {'John', 'Cars', 6}]
pa.schema([
    pa._list(
        pa.struct([
            pa.field('person', pa.string()),
            pa.field('has', pa.string()),
            pa.field('count', pa.int32()),
        ])
    )
])


Add to LD_LIBRARY_PATH for MatlabEngine.so etc

Matlab libraries are in a funny place on Linux. They therefore need to be added to the LD_LIBRARY_PATH for SPM to be able to use them.

Eric, could you try this? (not 100% sure of paths etc)
# go to superbuild
cd ~/devel/SIRF-SuperBuild
# check out this PR
git remote add rijobro https://github.com/rijobro/SIRF-SuperBuild.git
git fetch rijobro
git checkout linux_matlab_fix
# Tell SIRF to use PR here: https://github.com/CCPPETMR/SIRF/pull/603
cd ~/devel/build
cmake . -DSIRF_URL:STRING=https://github.com/rijobro/SIRF.git -DSIRF_TAG:STRING=fix_matlab_linux -DDISABLE_MATLAB:BOOL=OFF
# make
make -j
# if successful, ctest
cd ~/devel/build/builds/SIRF/build
ctest -VV

Let me know if any steps fail.

I find it slightly scary to add Matlab stuff to LD_LIBRARY_PATH

I agree, but currently it seems it's either that or expecting the SIRF user to know to do it themselves.

could run into https://github.com/CCPPETMR/SIRF-SuperBuild/issues/257

I think it works now. The following tests failed:
	  2 - MR_TESTS_PYTHON (Failed) 	  7 - SYN_TEST_CPLUSPLUS (Failed) 	  8 - SYN_TEST_PYTHON (Failed)
Another question: How can I add spm to Matlab?

Before we merge this, @Ede1994 can you paste the content of the ${Matlab_ROOT_DIR}/extern/bin/glnxa64 here? If there's versions of system/gcc files here, I wouldn't want to merge this PR.

@Ede1994 you can get output of tests by running with ctest -VV for instance. Adding SPM to your Matlab path would be by creating a startup.m, see e.g. https://uk.mathworks.com/help/matlab/ref/startup.html, or via the GUI.
These questions don't seem to belong in this PR though...

Before we merge this, @Ede1994 can you paste the content of the ${Matlab_ROOT_DIR}/extern/bin/glnxa64 here? If there's versions of system/gcc files here, I wouldn't want to merge this PR.

returns:  bash: /extern/bin/glnxa64: file or directory not found

@ede1994, you would need to do ls <path/to/Matlab>/extern/bin/glnxa64, where I think your computer, Matlab is installed in somewhere like /usr/local/Matlab2019b.

Sorry, you'll need to find out what M atlab_ROOT_DIR is. CMake should tell you.

okay. The content is:
libMatlabDataArray.so  libMatlabEngine.so

Only that? In that case, I'm happy to proceed, but still best to add a warning to our install instructions.

Hold off merging this one. Seems unnecessary for my current build, not sure what I've changed.


Examples for developer

Supplement example in seata-skeleton https://github.com/PandaLIU-1111/seata-skeleton

@self


[Macros] Diagnose undocumented conformances in extension macro expansions.

Extension macros can only add conformances that are documented in the conformances: list of the @attached(extension) attribute. Diagnose an error if the macro adds any conformances that are not documented.
Resolves rdar://112163965

@swift-ci please smoke test


How do we create playlists?

I was wondering how we would incorporate the playlist functionality of the jwPlayer.

Check the JWPLayer documentation for the kind of options you need, and then just use those options. This is just a wrapper to the JS object


Check if model is fine-tunable

Before we can finetune a model, we need to make sure that this is actually possible.
This is the list of constraints defined here:

Model config of the previous checkpoint should be exactly the same as the new config, except for the number of epochs of ML components like DIETClassifier, ResponseSelector and TEDPolicy
The labels for each ML component should also be the same between the two versions of data the models are trained on

labels: entity names, intent names, action names
they also need the same order!

Previous checkpoint trained with the “MINIMUM_COMPATIBLE_VERSION” of Rasa Open Source.

The labels for each ML component should also be the same between the two versions of data the models are trained on
labels:

entity names, intent names, action names
they also need the same order!

Is there anything in domain.yml that we are able to change?


Suggestion: add HTTPS

Because you have a custom domain, the SSL certificate provided by Github/Fastly won't work. A workaround is to use Cloudflare.
See: https://gist.github.com/coolaj86/e07d42f5961c68fc1fc8

Looks like this can be closed:

cpppatterns.com is indeed being served over HTTPS.
Additionally, after the creation of this issue, HTTPS is available for custom domains with a little configuration.


1.1.3: default values for checkbox and toggle

Coverage decreased (-0.09%) to 82.682% when pulling fc61fcd034f37e8886b6845abc7ca0bd07a62322 on dev into d92a4da9ff916e39653883fc67154515d03bfcb4 on master.


Delete User

Could you create a way to delete a user, for example if they leave the company, even if they have already paid invoices?, or if you delete it, it forces you to download the entire invoice record

Sure @DaxSosa  the user deletion is already being worked on.
Regarding the second, "if you delete it, it forces you to download the entire invoice record", can you explain the requests.
If you delete a user, they wont have access to your payroll, so who is downloading the entire invoice record?

Thank you, for the response, I explain, the administrator is obliged to download the entire payment history of the user before deleting it

alright. Got it.  Would look into that. Thank you

Hey @DaxSosa,
Based on our discussion I have opened issues #25 & #26. Now that we have deletion of users & disabling of user this should handle the case of person leaving employment fully.
So I will close this issue in favor of new issues where we are handling this functionality.

Thanks
El El lun, 18 mar 2024 a la(s) 2:41 p. m., rockstardev <
@.***> escribió:

Hey @DaxSosa https://github.com/DaxSosa,
Based on our discussion I have opened issues #25
https://github.com/rockstardev/BTCPayServerPlugins.RockstarDev/issues/25
& #26
https://github.com/rockstardev/BTCPayServerPlugins.RockstarDev/issues/26.
Now that we have deletion of users & disabling of user this should handle
the case of person leaving employment fully.
So I will close this issue in favor of new issues where we are handling
this functionality.
—
Reply to this email directly, view it on GitHub
https://github.com/rockstardev/BTCPayServerPlugins.RockstarDev/issues/20#issuecomment-2004947761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACB4LVWHRMNYUY3YFT4EMJLYY5GODAVCNFSM6AAAAABD7IFJUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUHE2DONZWGE
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


[Drawer] Pressing escape key when a modal Dialog is active triggers the Drawer to close

Description
See the title for the description. Appears to false trigger exit event despite a dialog being above an open drawer. When escape is pressed, MUI does not check that the Drawer is the highlighted component. Causes unpredictable behavior with modal dialogs.
Images & references

Versions

Material-UI: 0.17.0
React: 15.4.2
Browser: Chrome 15.x

Forgot to mention for others experiencing the issue: a workaround for now in the UI is simply to not trigger the close event in onRequestChange if the second parameter is "escape", or to manually keep track of the dialog states (luckily in this case I have a dedicated component for stacking dialog calls...), but in the first case it still requires disabling the escape functionality entirely and in the second, it can be a bit too much boilerplate for a UI library.

I know in our apps we never have more than one dialog open at once. This also follows the Material Design spec (at least when I last checked!). In the past we had multiple dialogs and hitting ESC always caused unpredictable behavior.

I understand the material design philosophy, but in some senses drawers are not a typical modal dialog as it comes out from the right.
For example, if you commonly have a prompt for confirmation of an action, it is a bit inconsistent (and in some cases just bad design) to do that in various different places. I know my example above isn't the neatest :) Also, Dialogs and Drawers are not represented externally by the same component [and since I was on a deadline, I did not have the ability to stack state for dialogs as I did in the case with others]. Dialogs themselves also don't seem to use the same restriction as Drawers, and thus don't need them.
In any case, it is still a functionality issue if two dialogs can physically be up, yet escape closes one which has no focus. There is also the potential of an entirely external library (or in a worse example, advertisement) which comes up above your app content where focus should be checked.

Right on. Agreed that it presents a problem in its current iteration. The next branch has a Drawer component built out, but I don't see any functionality built in (yet) to handle using the ESC key to close.

The v1-beta branch use a modal manager to take care of that issue. We can close :).


routetables: 改正同步

这个 PR 实现什么功能/修复什么问题:

按vpc粒度同步
自动命名，避免-1, -2这样的名字

是否需要 backport 到之前的 release 分支:

release/2.8.0

/cc @ioito
/cc @swordqiu

Codecov Report

Merging #933 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #933      +/-   ##
=========================================
+ Coverage    7.61%   7.62%   +<.01%
=========================================
  Files         357     357
  Lines       55591   55599       +8
=========================================
+ Hits         4236    4237       +1
- Misses      50957   50964       +7
  Partials      398     398

Flag
Coverage Δ

#aFlag
7.62% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/routetables.go
2.64% <0%> (-0.08%)
:arrow_down:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/util/rbacutils/rabc.go
73.86% <0%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae49f3c...fdca24b. Read the comment docs.

/cherrypick release/2.10.0

/cherrypick release/2.9.0

/cherrypick release/2.8.0

/lgtm
/approve

release/2.8.0 手工cherrypick，https://github.com/yunionio/onecloud/pull/942


testwidgets() in widget_tester.dart does not accept a string for skip parameter

Steps to Reproduce

Write a test you want to skip
Try to skip the test, using a String for the reason for skipping
Error: The argument type 'String' can't be assigned to the parameter type 'bool.

From widget_tester.dart:
@isTest
void testWidgets(String description, WidgetTesterCallback callback, {
  bool skip = false,
  test_package.Timeout timeout
}) {
  final TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
  ...

I believe the line: bool skip = false,
should be: dynamic skip = false,
Making this change allows me to skip using a string.

Logs

n/a

No issues found! (ran in 2.7s)

jjerome:~ jmj$ flutter doctor -v
[✓] Flutter (Channel beta, v0.7.3, on Mac OS X 10.13.6 17G65, locale en-US)
    • Flutter version 0.7.3 at /Users/jmj/Documents/Development/flutter
    • Framework revision 3b309bda07 (8 days ago), 2018-08-28 12:39:24 -0700
    • Engine revision af42b6dc95
    • Dart version 2.1.0-dev.1.0.flutter-ccb16f7282

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/jmj/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 27.0.3
    • ANDROID_HOME = /Users/jmj/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 28.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] IntelliJ IDEA Community Edition (version 2018.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[✓] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 1 category.

Would this really be a severe API break?
It would make the method be less strict with what it takes (changing bool to dynamic), so would it actually break existing code?

There is an other problem: testWidget has an explicit default value of skip: false
Contrary to the original test method that is null by default.
The null value allows the skip parameter to be overridden by a surrounding group.

With the explicit skip: false on testWidget, we can't skip an entire group.
This is the intented behavior of the orignal test method: https://github.com/dart-lang/test/issues/545#issuecomment-281509103
I think, the parameter should be declared like the orignal: testWidget({dynamic skip})

I've worked around this by wrapping the test with a skipped group that has the message I want:
group("Some test", () {
  testWidgets("It does something, but not really", (tester) {
    ...
  });
}, skip: "I wanted to skip inside, but can't because of this issue");

I'd rather be able to add the message to the individual test, though, since it'll be more clear as to which test is being skipped with the reason.

At some point since this issue was opened, the signature of testWidgets() changed to:
https://github.com/flutter/flutter/blob/ba393198430278b6595976de84fe170f553cc728/packages/flutter_test/lib/src/widget_tester.dart#L141-L152
bool? skip seems like it's a step closer to supporting a skip reason.
The body of this method is primary a call to test():
https://github.com/flutter/flutter/blob/ba393198430278b6595976de84fe170f553cc728/packages/flutter_test/lib/src/widget_tester.dart#L165-L198
This call to test() includes skip: skip.
test() takes dynamic skip:
https://github.com/flutter/flutter/blob/ba393198430278b6595976de84fe170f553cc728/packages/flutter_test/lib/src/test_compat.dart#L122-L124
https://github.com/flutter/flutter/blob/ba393198430278b6595976de84fe170f553cc728/packages/flutter_test/lib/src/test_compat.dart#L157-L166
It seems like the stage is set for this to be a trivial, non-breaking change. Is anyone on the Flutter team still subscribed to this issue?


Nice work you did, congratulations is it possible for 5B model in the future ?

First, congratulations for your work.
I was wondering about the support for 5B model, any plan to work on that ?

Hi, maybe in the next few weeks because I only have 4 A6000 :)


Update Jest to v24

The version of jest has been updated to jest 24, jest config has been split out from package.json to its own file. Jest coverageThreshold has been added, this will fail test scripts if coverage falls below a 95% threshold. setupTestFrameowrkScriptFile has been changed to setupFilesAfterEnv which demands an array value. testMatch's relative path has been removed (to better handle micromatch v3, part of jest v24).
Changes to collectCoverageFrom. An extra item has been added to cope with tests in hoc that were not previously being collected. Changes to which filenames can be collected from to add support for would be typescript and jsx. A noteworthy change in jest v24 is that index files whose only purpose was to export object declared as defaults in other files are now being recorded as having zero coverage and this has had asmall impact on overall coverage.
Checklist:

[ ] Documentation N/A
[ ] Tests N/A
[x] Ready to be merged

Deploy preview for govuk-react processing.
Building with commit<PHONE_NUMBER>8aa43ee3ec0cc7f74c571288c67c13
https://app.netlify.com/sites/govuk-react/deploys/5c86a225fb0f5a000b991865

Codecov Report

Merging #599 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   99.65%   99.65%
=======================================
  Files          97       97
  Lines         576      576
  Branches       66       66
=======================================
  Hits          574      574
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a7cd2...2416199. Read the comment docs.


Flickering Triggers

When the triggers are set to a keyboard key, they can not be held down. Instead, the trigger flickers on and off rapidly.

This is a issue with the keyboard and mouse being called after one another, I was going to make it one or the other but this is a issue I currently know off and I am trying to find a solution for it.
Here is the issue:
In the input thread, we take the keyboard input and then the mouse input. on the current build the mouse resets the trigger on each call without checking if the keyboard had turned on the trigger. As for right now this bug will have to stay until I can find a better way of stating that a key was pressed.

I believe this is fixed - at least I haven't noticed it anymore in my branch.  Close?


Upload test result files to recipe artifact location

Copy test result files to recipe artifact location exposed in https://github.com/flutter/flutter/pull/74378.
detailFiles will include perf test trace files.

00:07 +19 -1: test\host_agent_test.dart: dump files copies files and directories [E]
  Expected: true
    Actual: <false>

  package:test_api                 expect
  test\host_agent_test.dart 69:7   main.<fn>.<fn>
  test\host_agent_test.dart 53:42  main.<fn>.<fn>

Hmm Windows didn't like this.

Closing in favor of FLUTTER_TEST_OUTPUTS_DIR recipe-side solution. https://flutter-review.googlesource.com/c/recipes/+/11622


Issue35 documentation

Documentation on "Examples" page
Adjustments for readability; final steps of Issue #35 and some adjustments from Issue #63

Adjustments made for grammar, readability, capitalization, and punctuation
Adjustments for style guide (ex: numpy to NumPy, etc.)
Fixed remaining single to double backticks

Page Status:
✔ README
✔ Index
✔ Installation
✔ Matplotlib Backends
✔ Comparison to ipywidgets
✔ API
✔ Examples
✔ Gallery - n/a
✔ Contributing

Hi, @ianhi,
These are the final page edits, as I can see right now. There are only a few tiny things I would go back and fix (if you want me to):

[ ] Adjust the headers so H1, H2, H3, H4 are the same across all pages
[ ] Any stylistic changes you wanted to be done (draft example: PR #95)
[ ] You mentioned the docstrings in PR #64

Other than that---I think you have an amazing set of web docs! 🎉 🥳
Best,
Sam.

Hi @samanthahamilton I'm really sorry I let this get away from me so much. Had a stressful few weeks, and then I felt bad about not having looked at this and then vicious cycle etc :(...
As ever these are great edits! Idk if I'm an official enough person to be listed as a reference but you should absolutely feel to what you did here when advertising yourself, and I'd be happy to speak well on your behalf.


[DEV-2801] deactivationDate + userDataReactivation

Release Checklist
Pre-Release

[ ] Check migrations

No database related infos (sqldb-xxx)
Impact on GS (new/removed columns)

[ ] Check for linter errors (in PR)
[ ] Test basic user operations (on DFX services)

Login/logout
Buy/sell payment request
KYC page

Post-Release

Test basic user operations
Monitor application insights log

[ ] add migration


Compile Time Execution

Any plans on implementing this in Rust? nimlang has this cool feature and Im wondering if Rust will have it soon.

You can already do it with a macro implemented in a compiler plugin.

Thats not as General as a full CTFE though.

And using compiler plugins means we need to split our code that runs at different times into different files, which doesn't help much when we just want to initialize some datastructures that the code is making use of.
(Not to mention that we don't actualy have a documented/stable plugin interface)

Isnt it possible to do it the way Nim does it? http://hookrace.net/blog/what-is-special-about-nim/#run-regular-code-at-compile-time

This has been noted by the community many times as a desired post-1.0 feature.

I think this can be closed in favor of https://github.com/rust-lang/rfcs/pull/911


Reduce the amount of generated code

Code generated by the parser can be very clustered due to numerous wrapping function calls and type casts in Read/WriteSettings functions.
The base ISettingsMaster class should provide utility functions that will provide the functionality of multiple functions in one, simpler package. Example: instead of StringToFloat(ReadSettingValue()) it should simply be ReadFloatSettingValue().

Needs testing

Also handled in 53527488c37c029eb4ef5ca4af55bf2086bcec45


Relationship delete operation appears broken

Given the following state:
{
  "data": {
    "User": [
      {
        "id": "2943efbf-fe4f-490a-8acf-c5d93c95a498",
        "name": "katie",
        "owns": [
          {
            "dst": {
              "__typename": "World",
              "id": "5e8b4e74-5796-4f84-ac07-26430e9593ca",
              "name": "katiesworld"
            }
          }
        ]
      },
      {
        "id": "6a39e3b2-79fc-4630-81ea-5e5a38f40de4",
        "name": "javi",
        "owns": [
          {
            "dst": {
              "__typename": "World",
              "id": "f1ef7315-ab29-4762-97f2-31cfb16bd30c",
              "name": "javisworld"
            }
          }
        ]
      }
    ]
  }
}

Attempted the following query (which had no effect):
mutation {
  UserOwnsDelete (input: {
    match: {
      src: {
        User: {
          name: "javi"
        }
      }
      dst: {
        World: {
          name: "javisworld"
        }
      }
    }
  }
  )
}

When the src block is omitted, the operation succeeds.

The changes that added Neptune support made some significant changes -- dare I say improvements? -- to the way queries are constructed. Those changes were merged after this bug was filed. It's possible they fixed this bug as well, but I'd want to test to be sure. @drkatie, I don't suppose you still have the configuration files and whatever else you used to uncover this problem, and could give it another try or send them to me?
If not, it's no problem for me to create a test case. I just thought I'd go the lazy route if you happened to still have something conveniently at hand.


Add deZem documentation to cloud-integrations

Summary
Add deZem documentation to cloud-integrations.
...
Changes

Add directory dezem to integrations/cloud-integrations containing _index.md and image files

Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[ ] Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
[x] Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
[x] Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

Unfortunately I wasn't able to test the search bar. I could only test that the doc page looks like it should.

Unfortunately I wasn't able to test the search bar. I could only test that the doc page looks like it should.

@philippdzm this is great! Please take a look at my suggestions above, I'll merge this as soon as it is approved.


Not syncing from Redis to in-proc when adding new item

I have two clients; one with an in-process cache and the other without, but both using the same distributed Redis instance as a backplane.
This is what I am trying to achieve:

Client A adds a new item to the Redis handler
Client B's in-proc handler is synced with this new item
When Client B gets this item, it is retrieved straight from in-proc (and not from Redis)

But when Client B requests the item, it is still retrieved from Redis.
Client A configuration:
CacheManager = CacheFactory.Build<IAggregateRoot>(p => p
    .WithRedisConfiguration("redis", connectionString)
    .WithRedisBackplane("redis")
    .WithRedisCacheHandle("redis", true)
);

Client B configuration:
CacheManager = CacheFactory.Build<IAggregateRoot>(p => p
    .WithSystemRuntimeCacheHandle("inprocess")
    .And
    .WithRedisConfiguration("redis", connectionString)
    .WithRedisBackplane("redis")
    .WithRedisCacheHandle("redis", true)
);

How can I get Client B's in-proc cache synced when items are added to the Redis handler from Client A?

Client B has to retrieve the item at least once from Redis, that's the only way for Client B to get the data.
So, the first Get Client B is doing, will retrieve the item from Redis, every consecutive call eventually gets the item from the in-proc handle directly.
That's the expected behavior.
There is not really a reason for you to sync Client B's in-proc handle "preemptively" so to say, as Client B has to retrieve the item from Redis at some point anyways, right?

Due to performance reasons, we need this specific cache to be prepopulated from the start.
So an item would only sync to Client B for an update or delete, but not for an add?
I hooked up some event logging on OnAdd and OnGet. I get the following:

[Client A] ADD [MyKey] from Local
[Client B] ADD [MyKey] from Remote
[Client B] GET [MyKey] from Local

The first log occurs when the item is added to the cache by Client A. Client B adding from remote immediately logs afterwards.  The last log is Client's get call; why is this from Local? Surely it should be from Remote?

So an item would only sync to Client B for an update or delete, but not for an add

Kind of, yes, on Update/Delete CacheManager tries to remove it from the in-proc handle(s) of other Clients connected to the same backplane channel, if the item exists, because the "source" changed.
CacheManager never transfers the actual cached data with change events through the backplane. That would cause massive performance issues and would be kinda pointless because the item is available in Redis anyways.

The last log is Client's get call; why is this from Local?

 The local or remote flag is the origin the event came from. Get events do not get transported via backplane either; Get events will always be local.
In general, you already found that you can use the event system to preemptively populate your in-proc cache in Client B.
If you really need that kind of functionality, it should work fine. I'm not doing that per default for good reasons.
Hope that makes sense ;)

Yes, that makes sense.
So, all I would really need to do is configure the following event on Client B, This would populate the in-process cache when something is remotely added to the Redis cache.
CacheManager.OnAdd += PropagateOnRemoteAdd;

private void PropagateOnRemoteAdd(object sender, CacheActionEventArgs e)
{
    if (e.Origin == CacheActionEventArgOrigin.Remote)
    {
        CacheManager.Get(e.Key, e.Region);
    }
}

Yup, that should work.

CacheManager.Get(e.Key, e.Region);

I'd check if e.Region is null and then call the Get without region, otherwise you'll get an ArgumentNullException

Right, yes. Thanks @MichaCo :)

This also require's Client B to be configured with CacheUpdateMode.Up:
CacheManager = CacheFactory.Build<IAggregateRoot>(p => p
    .WithSystemRuntimeCacheHandle("inproc")
    .And
    .WithRedisConfiguration("redis", connectionString)
    .WithRedisBackplane("redis")
    .WithUpdateMode(CacheUpdateMode.Up)
    .WithRedisCacheHandle("redis", true)
);

That should be the default value (if nothing is defined), but yes.


ACL check

Added ACL rule check for findAll queries, this does not work for any mutations at the moment.

hello, why did you close this?


simplify messagesAdd reducer

Remove the code that thought messages could be from multiple conversations
Improve logging in the reducer
Fix bug with "find existing" skipping messages that may be desynced from the ordinal list.

I'd recommend hiding whitespace changes when looking at this.


I know this is supposed to work with brook wingman adapters but does anyone know if it works with mayflash adapters? Thanks!

It works great with the MAYFLASH Magic NS Wireless adapter. Is there a specific Mayflash adapter you're curious about?

Yes. I use it on PS4/PS5 with Mayflash Magic Pro 2 and Magic Ultimate.

@okkdev
What is the difference between those two adapters and which one do you recommend?

Ultimate is the successor of the Pro 2. Get the Ultimate. :)

@okkdev
Okay thank you so much!

Closing issue, glad to hear it works.


Release 1.3 version

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #121   +/-   ##
======================================
  Coverage    80.6%   80.6%
======================================
  Files           9       9
  Lines         263     263
======================================
  Hits          212     212
  Misses         51      51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341a0f7...c9f9443. Read the comment docs.


_get_physical_type_id is a performance bottleneck and could be cached

Please describe the use case that requires this feature.
Profiling units code, much time is spent in Unit._get_physical_type_id, which is used in e.g. is_equivalent.
Although this never changes per unit instance, this does expensive operations every time it is called (decompose, list comprehension, conversion to tuple.
Describe the solution you'd like
Use caching (replace with lazyproperty) or calculate once in __init__.
Describe alternatives you've considered
None, this is a major bottleneck.
Additional context
Profiling creation of Angle, Latitude, Longitudes:
   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
  1865738    3.235    0.000   18.422    0.000 /home/maxnoe/Projects/astropy/astropy/units/quantity.py:407(__new__)
  1950033    2.698    0.000    5.314    0.000 /home/maxnoe/Projects/astropy/astropy/units/core.py:665(_get_physical_type_id)
  1054469    2.398    0.000   19.349    0.000 /home/maxnoe/Projects/astropy/astropy/coordinates/angles.py:107(__new__)
    81118    1.967    0.000    5.951    0.000 /home/maxnoe/Projects/astropy/astropy/coordinates/angles.py:380(_wrap_at)
  1947225    1.188    0.000    1.189    0.000 {built-in method numpy.array}
   973371    1.131    0.000    9.220    0.000 /home/maxnoe/Projects/astropy/astropy/units/core.py:916(is_equivalent)
 12034225    1.063    0.000    1.064    0.000 {built-in method builtins.isinstance}
2109569/2109567    0.894    0.000    1.625    0.000 {method 'view' of 'numpy.ndarray' objects}

Sorry, this should have been an astropy issue.


Fix for Dockerfile smell DL3059

Description
Hi!
The Dockerfile placed at "Dockerfile" contains the best practice violation DL3059 detected by the hadolint tool.
The smell DL3059 occurs if there are multiple consecutive RUN instructions. Each RUN will correspond to a layer of the final Docker image, thus is recommended to compact them to reduce the number of layers for the final image.
This pull request proposes a fix for that smell generated by my fixing tool. The patch was manually verified before opening the pull request. To fix this smell, specifically, The consecutive RUN instructions have been chained until a comment or a different instruction appears.
This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.
Thanks in advance
Purpose
This pull request is a:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Downloading file to memory stream (feature request)

Currently the only available option for downloading a file from Telegram servers is downloadFile which writes file to the disk. If the file is not needed for long then (i.e. you need file for one second) a write and read from disk plus a delete should be done.
If there be a getFileStream method which returns a memory stream, then such a problem does not happen.
Thanks

yeah, thats true, we'll need streaming

You can use getFileLink to get the link and create an stream with [your favourite HTTP request module].

@yagop I think we can work on adding a getFileStream method. It would be quite helpful for most users I presume.

Just added TelegramBot#getFileStream() on master branch. Please try it out and give us feedback.

Shipped in v0.30.0.


Only try to use reflection to access default nameservers when using J…

…ava8 and lower
Motivation:
We should only try to use  reflection to access default nameservers when using Java8 and lower as otherwise we will produce an Illegal reflective access warning like:
WARNING: Illegal reflective access by io.netty.resolver.dns.DefaultDnsServerAddressStreamProvider
Modifications:
Add Java version check before try to use reflective access.
Result:
No more warning when Java9+ is used.

This only happens if we can not lookup the default name servers via JNDI which can for example happen if "offline mode" is used.

/cc @ddossot

@netty-bot test this please

Just a note as I experimented the problem recently:
We use a "customized" JVM with jlink, to only embed the modules we thought necessary.  The module jdk.naming.dns was not linked into the produced JVM, as we had no clue that under the hood Netty does use the com.sun.jndi.dns.DnsContextFactory class to get the DNS name servers.
Without that fix merged: we were able to get the name servers for the underlying platform (on Linux  defined in /etc/resolv.conf thanks to the reflective call that was done afterwards. Unfortunately when looking up the default name servers via JNDI fails, it silently fails: the catch block is empty; should we consider adding a trace at least ?
So that means to have the name servers defined by the underlying platform, the module jdk.naming.dns is required by Netty. Don't know if you want to add a word on this in some documentation ?

@laurentvaills yes this sounds like a good idea... Can you do a PR with the trace logging + docs ?


Rise / Transit / Set times for stars seem to be off by 1 hour

Hi there,
thanks again for providing the api that calculates rise and set times for stars. I played around with it a little bit and compared the results to SkySafari. Of course the minutes do not exactly match since there might be small differences between the equatorial coordinates and the geographic coordinates in my code and in SkySafari, so that is fine. The strange thing is that all times seem to be off by one hour.
I picked two different locations and calculated rise/transit/set times for 3 Sagittarii on August the 24th, 2020. I am currently in UTC+2 so I created a DateFormatter with my current timezone and locale to get compareable results to SkySafari.
Here is my code:
        let timeZone = TimeZone.current
        let dateTimeFormatter = DateFormatter()
        dateTimeFormatter.dateStyle = .short
        dateTimeFormatter.timeStyle = .short
        dateTimeFormatter.timeZone = timeZone
        dateTimeFormatter.locale = Locale.current
        print("The current timezone is: \(timeZone)")
        print("Hours from GMT: \(timeZone.secondsFromGMT() / 60 / 60)")
        print("The current locale is: \(Locale.current)\n")

        let day = JulianDay(year: 2020, month: 8, day: 24, hour: 12, minute: 0, second: 0)

        let threeSgr = AstronomicalObject(
            name: "3 Sagittarii",
            coordinates: EquatorialCoordinates(rightAscension: Hour(.plus, 17, 47, 33.62), declination: Degree(.minus, 27, 49, 50.85)),
            julianDay: day
        )

        let rehbergTower = GeographicCoordinates(positivelyWestwardLongitude: Degree(7.970309), latitude: Degree(49.181973))
        let hoernumBeach = GeographicCoordinates(positivelyWestwardLongitude: Degree(8.279082), latitude: Degree(54.752388))

        let resultsForRehbergTower = threeSgr.riseTransitSetTimes(
            for: rehbergTower
        )

        let resultsForHoernumBeach = threeSgr.riseTransitSetTimes(
            for: hoernumBeach
        )

        print("Rehberg Tower")
        print("3 Sagittarii rises on \(dateTimeFormatter.string(from: resultsForRehbergTower.riseTime!.date))")
        print("3 Sagittarii transit occurs on \(dateTimeFormatter.string(from: resultsForRehbergTower.transitTime!.date))")
        print("3 Sagittarii sets on \(dateTimeFormatter.string(from: resultsForRehbergTower.setTime!.date))\n")
        print("Hörnum Beach")
        print("3 Sagittarii rises on \(dateTimeFormatter.string(from: resultsForHoernumBeach.riseTime!.date))")
        print("3 Sagittarii transit occurs on \(dateTimeFormatter.string(from: resultsForHoernumBeach.transitTime!.date))")
        print("3 Sagittarii sets on \(dateTimeFormatter.string(from: resultsForHoernumBeach.setTime!.date))")

Here is the output:
The current timezone is: Europe/Berlin (current)
Hours from GMT: 2
The current locale is: en (current)

Rehberg Tower
3 Sagittarii rises on 8/24/20, 6:30 PM
3 Sagittarii transit occurs on 8/24/20, 10:04 PM
3 Sagittarii sets on 8/25/20, 1:37 AM

Hörnum Beach
3 Sagittarii rises on 8/24/20, 7:12 PM
3 Sagittarii transit occurs on 8/24/20, 10:05 PM
3 Sagittarii sets on 8/25/20, 12:58 AM

And here are the results from SkySafari:
Rehberg Tower
Rise: 5:29 PM
Transit: 09:02 PM
Set: 12:40 AM
Hörnum Beach
Rise: 6:08 PM
Transit: 9:01 PM
Set: 11:54 PM
At first I thought that it was some kind of local date conversion problem so I looked at the results as JulianDay and they were off by one hour as well. Is this a bug or did I miss something that must be done before calling riseTransitSetTimes?

Hi. Thanks for the report, that's strange indeed. If I read well your message, the origin of the problem seems to lie in the JulianDay computation. Mine are well covered with tests, but who knows, I may have missed something.
Can you provide here a date and the corresponding JulianDays with SKySafari and SwiftAA ? We will compare with a third souce...

I reproduce your problem with SkySafari. Here are screenshots (sorry in French):
First show date, as in your code. JulianDay seems correct. It is also what we can obtain with SwiftAA:

Second shot shows site: Rehberg Tower

Last shows 3 Sagittarii infos. And rise, transit, set times are off.

"Se lève" = "rises": 7:34 PM, instead of 6:30 PM
"Passe" = "transits": 10:04 PM, instead of 11:07 PM
"Se couche" = "sets": 2:45 AM, instead of 01:37 AM (??)

But I just noticed that if you specify UT Offset for Rehberg Tower of one (1) hour instead of 2 (which usually accounts for summer time offset) inside SkySafari, you get correct values!
Rises: 6:34,
Transits: 10:07
Sets: 01:45

In conclusion I would say, your setup of Rehberg Tower is wrong by one hour. Could you confirm ? (or not) :-D

Hi,
thank you for the hint. You are completely right, my location setup was messed up by one hour 🙈
I fixed the locations and now everything is fine, SwiftAA calculates the correct rise/transit/set times. I apologize for wasting your time, this issue can be closed :)


[Snyk] Security upgrade alpine from 3.18 to 3

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 4 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

Dockerfile

We recommend upgrading to alpine:3, as this image has only 3 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Write SNYK-ALPINE318-BUSYBOX-6913411
  80

Use After Free SNYK-ALPINE318-BUSYBOX-7249236
  80

Use After Free SNYK-ALPINE318-BUSYBOX-7249265
  80

Use After Free SNYK-ALPINE318-BUSYBOX-7249265
  80

Use After Free SNYK-ALPINE318-BUSYBOX-7249419
  80

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use After Free

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Submitting Additional Fields

Is it possible to submit additional fields beyond just "email" using AjaxChimp?
Regards,
Dillon

Also trying to submit a hidden field.

The plugin just calls submit() on the form. If the form has additional fields, those should be submitted as well.


[Suggestion] About default tab on issues-view page

Having "Notes" as default tab may be more user-oriented.

Take my company as example,
Changes to issue are just garbage information to end-user such as customers and engineers (and even product managers), because they are focusing on communications.
Supervisor may in few scenarios check issue changes.
Changes only matter to software manager and Redmine administrator.
I am posting it here because I have no JAVA skill. It take me some time to hardcode each time updating Purplemine2 to latest.

Hi!
This is a good suggestion, however, these tabs are now supported by Redmine itself since version 4.1: https://www.redmine.org/news/127. And it defaults to displaying just Notes when they're available.
Is it possible for you to upgrade to the latest Redmine?

Hello mrliptotea,
Thanks for your time checking this suggestion and sharing Redmine 4.1 info.
Redmine 4.1 looks fancy. I am currently using 3.2 and do have plan to update it, although updating plugins is expectably time-consuming. I will keep hardcoding until that happens.


Scripts to download, rescale, and use photos for team members

The need came up with today's downtime of github when I was giving a presentation where team page was enabled and @bendichter photo was not showing :-/ To avoid dependence on external hostings, I think it is better to embed all photos.
scripts were generated by chatgpt through iterative improval ;-) I reduced the size to be more lightweight and consistent - now some where too large and thus causing undue bandwidth consumption to display.
Not yet 100% certain that such specification of photo would work -- do you know @satra? I don't have jekyll working locally atm to try somehow.
BTW -- download of photo only didn't work for @djarecka url for some reason -- was getting html, so I just did wget for that single one "manually"

confirmed that photos show and have good urls


Supporting a subset of markdown syntax?

Hi! I would like to support a subset of markdown syntax: Only bold, cursive, strikethrough and automatic links (so https://google.com becomes https://google.com). I don't understand how I can do that with this package.
I found the documentation for writing custom elements here: https://ssssota.github.io/svelte-exmarkdown/docs/03-override-component.
However it is not clear how to override links. I mean both links like [Duck Duck Go](https://duckduckgo.com) and also automatically convert URL in normal text to link. There is also no list of the default renderers which would be useful to see. Perhaps something like that could be added to the documentation? 🙏
Lastly, I would like to know how to configure bundle splitting in an efficient way, as I would like to not bundle all the default renderers in my application as they are not used.
Thank you!

Thank you for your question!
I'm sorry, but I can't answer you right now.
I would like to confirm a few things, so I will answer a little at a time once I have done so.

First, let's talk about auto-links.
You can also create your own plugin:
// ref. https://github.com/remarkjs/remark-gfm/blob/2d4c9569158afc66dcf1e51ca7d43d680a39c6e8/index.js
import {
  gfmAutolinkLiteralFromMarkdown,
  gfmAutolinkLiteralToMarkdown,
} from 'mdast-util-gfm-autolink-literal';
import type { Plugin } from 'svelte-exmarkdown';

export const autoLinkPlugin: Plugin = {
  remarkPlugin: function () {
    const data = this.data();
    data['fromMarkdownExtensions'] ??= [];
    data['fromMarkdownExtensions'].push(gfmAutolinkLiteralFromMarkdown);
    data['toMarkdownExtensions'] ??= [];
    data['toMarkdownExtensions'].push(gfmAutolinkLiteralToMarkdown);
  },
};

ref. https://stackblitz.com/edit/svelte-exmarkdown-autolink?file=src%2Fautolink.ts

Lastly, I would like to know how to configure bundle splitting in an efficient way, as I would like to not bundle all the default renderers in my application as they are not used.

Default renderers are made with <svelte:element /> element.
So, I don't think there will affect bundle size.

I would like to support a subset of markdown syntax: Only bold, cursive, strikethrough

Of course, there is the plugin-based method.
But there is also the method using string replacement. You can try it:
const disableMarkdownSyntaxes = (md: string): string => {
  return md
    .replace(/^(\s*)(#+ )/gm, '$1\\$2') // disable heading
    .replace(/^(\s*)(-|=|\+|\*)/gm, '$1\\$2') // disable unordered list, alternative heading and <hr>
    .replace(/^(\s*\d+)(\. )/gm, '$1\\$2') // disable ordered list
    .replace(/^(\s*)(>)/gm, '$1\\$2') // disable ordered list
    .replace(/`/g, '\\`') // disable code (block and inline)
    .replace(/!\[/g, '!\\[') // disable image
}

ref. https://stackblitz.com/edit/svelte-exmarkdown-disable-syntax?file=src%2FApp.svelte

⭐ Thank you so much for the detailed response, it helped me! 🙇


HISTORY.rst isn't included in the distribution

Don't think that the HISTORY.rst file is included in the distribution.  Installing directly from source works just fine.
pip3 install es2csv --user
Collecting es2csv
  Using cached es2csv-5.2.1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-w54tvjbj/es2csv/setup.py", line 26, in <module>
        with open('HISTORY.rst') as history_file:
    FileNotFoundError: [Errno 2] No such file or directory: 'HISTORY.rst'

Duplicate #33


Is this repository open for contribution?

I'm wondering if this repo is open for contribution/pull requests.
There are several PRs, but they're rather old.
If the answer is yes, what are the constraints?

@cosieLq The repository is definitely open to contributions and very much appreciated!
This repository is a mirror of a private GitLab repository hosted within Bloomreach so we will not be able to merge your changes directly in GitHub, but they will be accepted and be part of the package :)
Very soon we will move the repository to GitHub and make it the main repository.


Feature: generic workflow/library

In addition to the generic API we have, there is a need for a generic workflow that calls a CLI/API with:

A lock file -> the reusable workflow can generate an SBOM from it. Example builder generate-sbom -lock-file <lock-file>
A list of commands to vendor the dependencies and tarball them to be shared with the building VM (useful for hermetic builds). In Npm, the download part would be npm ci. Example: builder vendor -cmds "npm ci"
A list of commands to build. In Npm, this would be npm build or npm pack. Example: builder build -cmds "untar-deps, npm pack"
Provenance generation: we already have this part built. Example: builder generate-provenance <TODO>

/cc @lumjjb @bcoe @MarkLodato @ianlewis @asraa @joshuagl

Is the idea here is to better support ecosystem builders? or is this something meant to have its own reusable workflow where user specifies commands to be executed?
If the latter, I've been thinking that supporting a config yaml file in the repo root would be the best approach rather than having lots of inputs to the workflow that just get put on the command line.

Is the idea here is to better support ecosystem builders?

yes, to help build a single reusable workflows that works across multiple ecosystems.

I like this a lot. A generic workflow and CLI will be enough to bootstrap many ecosystems. Where it is not, the CLI and generic workflow will make the phases and how to implement them much more concrete, as well as providing a building block for proof of concept.
I will start implementing a PoC this over the next week or so, focusing on supporting a Gradle project. Feel free to assign this Issue to me. I can report back.

An additional data point for ko https://github.com/laurentsimon/slsa-on-github-test/blob/main/.github/workflows/ko-caller.yml

I think we can close this once we GA the generic workflow(s).

I'm going to just close this since there's nothing more to be done for this issue specifically. If we need something else let's create a new issue.


TensorFlow Linear Model Tutorial code

Not sure this is right place for my question...
At any rate, I'm trying to follow the Linear model tutorial , there is a code link there but leads to the wide and deep code , what am I missing here?

OK, now I see it's the same code


Website throws error when going to "Packages" in https://web.pulsar-edit.dev/

Thanks in advance for your bug report!

[X] Have you reproduced this issue in incognito/private browsing?
[X] Have you made sure you issue doesn't already exist?

Where is the URL that this occurs?
https://web.pulsar-edit.dev/packages
What's your issue?
When going to https://web.pulsar-edit.dev/ and clicking on "Packages" in the top left the website will encounter an error
Which OS/Browser/Version does this happen on?
Arch-Linux/Firefox/112.0.2(64-Bit)
Firefox is from Official Arch Repos
Steps to Reproduce/Additional Details:

Go to https://web.pulsar-edit.dev/
Click on "Packages" located on the top left
It will show error
https://imgur.com/a/unjnbFD

This one is definitely new, I've clicked that one many times before.

Thanks a ton for the bug report, I'll see what I can do


v2alpha1 malfeasance API

Motivation
This implements the malfeasance API for v2alpha1.
Description
For every malfeasance proof the API returns:

The SmesherID the proof was created for
The Domain of the proof (for ATXv1 proofs n/a but will be relevant for ATXv2)
The Type of the proof
The properties of the proof: this is a map of string-string pairs that depends on the type of the proof and gives additional information about it.

Additionally I updated events to not have wire.MalfeasanceProof as part of the event any more but instead only the raw bytes of the proof - listeners of events in general should only care about which identities are marked as malicious and not why.
Test Plan
Added test for new API and updated tests of existing handlers.
Tests in grpcserver/v2alpha1 where sharing setup code between them which caused tests to get stuck if they are executed in a different order. I updated the tests to all setup their environment individually to avoid this.
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


Builder Pattern

Creation of entities using Builder Pattern
Each group member must be responsible for at least two entities.
Merge correct, error-free pull requests from group members

Complete


Use external table ( Tabulator or DataTables ) doesn't work

Hello,
I'm new grafana user and I install the Business Text plugin to user some external tools like "Tabulator" or "DataTables".  But the table is not rendering properly into the plugin. It's like the javascript doesn't run.
The example below is for a Datatables test :

The example below is for a Tabulator test :

I don't know if it is some issue or there is some configuration to do. Note : I changed disable_sanitize_html = true in grafana.ini file.
Regards
Mauro

@mauro-serao We explained how to import modules in the documentation and YouTube tutorials: https://volkovlabs.io/plugins/business-text/external/


Fixing wrong parameter name

Fixing wrong parameter name "machineName" to "vmName"

@PrateekKumarSingh : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Adjust Cell Widths for better formatting

This is more of a presentation issue then a content issue. Just to make the final results more professional.

Did some testing of this and it will help with forcing wrapping of long lines of text. Just need to work out good cell widths to use.

New report format addresses this, and has been merged into development branch.


Can't catch exception: InsufficientFunds

Hello!
Well, from my understanding, I should be able to catch the InsufficientFunds exception, right?
>>> from bitcoinrpc.exceptions import InsufficientFunds
>>> try:
...     conn.sendtoaddress('n2ReFEassvxBRqcAvBhbe9muH9YGjMYk9s', 100)
... except InsufficientFunds:
...     pass
...
Traceback (most recent call last):
  File "<input>", line 2, in <module>
  File "/home/vagrant/.pythonbrew/pythons/Python-2.7.3/lib/python2.7/site-packages/bitcoinrpc/connection.py", line 270, in sendtoaddress
    raise _wrap_exception(e.error)
WalletError: Insufficient funds
>>>

No, can't do :(
Using bitcoin-python==0.3
Thanks.

This repository is unmaintained (see https://github.com/laanwj/bitcoin-python#not-actively-maintained) so there is no one to handle issues. Closing this, sorry.