React 0.13 Broken for 0.8.x

Just happened over the weekend all versions of 0.8.x break my automated tests that touch React Slick in a React 0.13 project. Downgraded to 0.7.2 to avoid the pain.
  Error: Invariant Violation: Slider.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.
      at invariant (node_modules/react/lib/invariant.js:42:15)
      at [object Object].ReactCompositeComponentMixin._renderValidatedComponent (node_modules/react/lib/ReactCompositeComponent.js:821:46)
      at [object Object].wrapper [as _renderValidatedComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at [object Object].ReactCompositeComponentMixin.mountComponent (node_modules/react/lib/ReactCompositeComponent.js:237:30)
      at [object Object].wrapper [as mountComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at ReactDOMComponent.ReactMultiChild.Mixin.mountChildren (node_modules/react/lib/ReactMultiChild.js:192:44)
      at ReactDOMComponent.Mixin._createContentMarkup (node_modules/react/lib/ReactDOMComponent.js:289:32)
      at ReactDOMComponent.Mixin.mountComponent (node_modules/react/lib/ReactDOMComponent.js:199:12)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at [object Object].ReactCompositeComponentMixin.mountComponent (node_modules/react/lib/ReactCompositeComponent.js:247:34)
      at [object Object].wrapper [as mountComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at [object Object].ReactCompositeComponentMixin.mountComponent (node_modules/react/lib/ReactCompositeComponent.js:247:34)
      at [object Object].wrapper [as mountComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at mountComponentIntoNode (node_modules/react/lib/ReactMount.js:248:32)
      at ReactReconcileTransaction.Mixin.perform (node_modules/react/lib/Transaction.js:134:20)
      at batchedMountComponentIntoNode (node_modules/react/lib/ReactMount.js:269:15)
      at ReactDefaultBatchingStrategyTransaction.Mixin.perform (node_modules/react/lib/Transaction.js:134:20)
      at Object.ReactDefaultBatchingStrategy.batchedUpdates (node_modules/react/lib/ReactDefaultBatchingStrategy.js:66:19)
      at Object.batchedUpdates (node_modules/react/lib/ReactUpdates.js:110:20)
      at Object.ReactMount._renderNewRootComponent (node_modules/react/lib/ReactMount.js:404:18)
      at Object.wrapper [as _renderNewRootComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactMount.render (node_modules/react/lib/ReactMount.js:493:32)
      at Object.wrapper [as render] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactTestUtils.renderIntoDocument (node_modules/react/lib/ReactTestUtils.js:52:18)
      at Context.<anonymous> (test/DynamicLead/index.js:10:33)

+1
I was running "react-slick": "0.8.2", so something happened that

introduced a breaking change in a patch version of what is claimed to be known-good @ https://www.npmjs.com/package/react-slick
overwrote an existing semver release on NPM

How did this even happen?

@jordansexton,
So, NPM versions cannot be overwritten, but… in s module's package.json you can loosely specify the modules the this particular module depend on. Npm provides the ability to say, "this version plus any patch versions after it" (~), or even "this version or any minor versions after it" (^). When you install a version'd module, npm grabs the latest applicable dependencies with it. And, this can lead to breakage. The way to avoid that, is with npm shrinkwrap, which you should be doing for anything "in production". It's  annoying to maintain a shrinkwrap file, but it's the price you pay for stability.

can you post your error messages here
On Wed, Nov 4, 2015 at 6:23 AM, Rob Colburn<EMAIL_ADDRESS>wrote:

@jordansexton https://github.com/jordansexton,
So, NPM versions cannot be overwritten, but… in s module's package.json
you can loosely specify the modules the this particular module depend on.
Npm provides the ability to say, "this version plus any patch versions
after it" (~), or even "this version or any minor versions after it" (^).
When you install a version'd module, npm grabs the latest applicable
dependencies with it. And, this can lead to breakage. The way to avoid
that, is with npm shrinkwrap, which you should be doing for anything "in
production". It's annoying to maintain a shrinkwrap file, but it's the
price you pay for stability.
—
Reply to this email directly or view it on GitHub
https://github.com/akiran/react-slick/issues/165#issuecomment-153536580.

Mine is identical to @robcolburn's OP:
 Error: Invariant Violation: Slider.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.
      at invariant (node_modules/react/lib/invariant.js:42:15)
      at [object Object].ReactCompositeComponentMixin._renderValidatedComponent (node_modules/react/lib/ReactCompositeComponent.js:821:46)
      at [object Object].wrapper [as _renderValidatedComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at [object Object].ReactCompositeComponentMixin.mountComponent (node_modules/react/lib/ReactCompositeComponent.js:237:30)
      at [object Object].wrapper [as mountComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at ReactDOMComponent.ReactMultiChild.Mixin.mountChildren (node_modules/react/lib/ReactMultiChild.js:192:44)
      at ReactDOMComponent.Mixin._createContentMarkup (node_modules/react/lib/ReactDOMComponent.js:289:32)
      at ReactDOMComponent.Mixin.mountComponent (node_modules/react/lib/ReactDOMComponent.js:199:12)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at [object Object].ReactCompositeComponentMixin.mountComponent (node_modules/react/lib/ReactCompositeComponent.js:247:34)
      at [object Object].wrapper [as mountComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at [object Object].ReactCompositeComponentMixin.mountComponent (node_modules/react/lib/ReactCompositeComponent.js:247:34)
      at [object Object].wrapper [as mountComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactReconciler.mountComponent (node_modules/react/lib/ReactReconciler.js:38:35)
      at mountComponentIntoNode (node_modules/react/lib/ReactMount.js:248:32)
      at ReactReconcileTransaction.Mixin.perform (node_modules/react/lib/Transaction.js:134:20)
      at batchedMountComponentIntoNode (node_modules/react/lib/ReactMount.js:269:15)
      at ReactDefaultBatchingStrategyTransaction.Mixin.perform (node_modules/react/lib/Transaction.js:134:20)
      at Object.ReactDefaultBatchingStrategy.batchedUpdates (node_modules/react/lib/ReactDefaultBatchingStrategy.js:66:19)
      at Object.batchedUpdates (node_modules/react/lib/ReactUpdates.js:110:20)
      at Object.ReactMount._renderNewRootComponent (node_modules/react/lib/ReactMount.js:404:18)
      at Object.wrapper [as _renderNewRootComponent] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactMount.render (node_modules/react/lib/ReactMount.js:493:32)
      at Object.wrapper [as render] (node_modules/react/lib/ReactPerf.js:70:21)
      at Object.ReactTestUtils.renderIntoDocument (node_modules/react/lib/ReactTestUtils.js:52:18)

I've meaning to do some deeper debugging. For now, (based on some console.log statements) what I know is:

we get inside Slider's render function, and inside the conditional to create an InnerSlider
we do not reach InnerSlider's render function

I haven't figured out to trigger node's repl debugger while running mocha. For now, reverting to 0.7 is working for me.

@robcolburn Are you seeing this issue with 0.8.1 as well ?
Last week end I released 0.8.2.  It may have problem but 0.8.1 should be fine

@akiran - started occurring on 0.8.1, attempted 0.8.2 and 0.8.3 before going back to 0.7.2

I was on 0.8.2 using React 0.13.3, and it was stable. I'm also running 0.7.2 now.

Same issue happening here.

Same issue here with react 0.13.3. Had to roll back to 0.7.2.
I get the issue with 0.8.0 and up.

Same here

Same issue here

yeah, me too :confused:

+1

I will look into this today

awesome, thanks

Counting on you :+1:

sweet, can't wait :moyai:

Awesome thank you, looking forward to the update!

<EMAIL_ADDRESS>now works with both react 0.13, 0.14.
Please check and let me know if your issues are resolved

Still having trouble with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Uncaught Error: Invariant Violation: Slider.render(): A valid ReactComponent must be returned.
All demos worked well with<EMAIL_ADDRESS>

I'm stumped. I can't get anything to work. Even something simple:
import React from 'react';
import Slider from 'react-slick';

var sliderMount = document.getElementById('slider-mount');
React.render(
  <Slider>

1

  </Slider>
  , sliderMount);

from package.json:
  "dependencies": {
    "axios": "^0.5.4",
    "babel-core": "^5.6.15",
    "babel-loader": "^5.2.2",
    "json-loader": "^0.5.3",
    "node-libs-browser": "^0.5.2",
    "react": "^0.13.3",
    "react-slick": "^0.9.2",
    "webpack": "^1.10.1"
  },

Maybe webpack related?

@gbrassey are there any console errors?

Confirming we are seeing the same issue. A coworker installed 0.9.2 last week and it runs fine, but installing it yesterday and today is throwing this error.
Running npm shrinkwrap produces different outputs between the older and newer installs, with new installs showing the full react 0.14 dependency tree, so wondering if this is an issue with react 0.14?

<EMAIL_ADDRESS>is including<EMAIL_ADDRESS>even though my project is using 0.13.3. The error is likely caused by two competing versions react. The project works if I delete node_modules/react-slick/node_modules/react (react-slick falls back to react@0.13.3).

@gbrassey and @akiran : React should be a peerDependency (here they discuss the problem: https://github.com/yahoo/react-intl/issues/79 ). If you specify a react version in devDependencies or dependencies, react-slick will work only with that version. Check also<EMAIL_ADDRESS>

thanks for the info and references @ChrisCinelli


[BUG]route: Checking timeout: IP/Hostname of testsvc-trait-56d649fdfd-auto-created ingress is generating

run vela status first-vela-app ,
❯ vela status first-vela-app
About:

  Name:      	first-vela-app
  Namespace: 	default
  Created at:	2020-11-19 14:49:18.118536 +0800 CST
  Updated at:	2020-11-19 14:49:18.118536 +0800 CST

Services:

  - Name: testsvc
    Type: webservice
    HEALTHY Ready: 1/1
    Traits:
      - ✅ route: Checking timeout: IP/Hostname of testsvc-trait-56d649fdfd-auto-created ingress is generating
    Last Deployment:
      Created at: 2020-11-19 14:35:11 +0800 CST
      Updated at: 2020-11-19T14:49:18+08:00

and to describe ingress ,found "default-http-backend" not found
❯ kubectl describe ingress testsvc-trait-56d649fdfd-auto-created
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
Name:             testsvc-trait-56d649fdfd-auto-created
Namespace:        default
Address:
Default backend:  default-http-backend:80 (<error: endpoints "default-http-backend" not found>)
Rules:
  Host                 Path  Backends
  ----                 ----  --------
  testsvc.example.com
                          testsvc-trait-56d649fdfd:8000 (<IP_ADDRESS>:8000)
Annotations:           kubernetes.io/ingress.class: nginx
Events:                <none>

continue get the ingress , found:
❯ kubectl get ingress testsvc-trait-56d649fdfd-auto-created -o wide
Warning: extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
NAME                                    CLASS    HOSTS                 ADDRESS   PORTS   AGE
testsvc-trait-56d649fdfd-auto-created   <none>   testsvc.example.com             80      18m

Thanks for reporting，could you help retry vela status now，is it always saying ingress is creating while it's already created

The same issue.

Thanks for reporting，could you help retry vela status now，is it always saying ingress is creating while it's already created

yes, It's always。

Hi @kingsir2011 Thanks for reporting.
Could you provide step by step guide on how to reproduce your error? It looks like you ingress controller has some issues. Maybe it would be great to show us how you set up your k8s as well.

@kingsir2011 maybe you didn't install nginx ingress and untill now,route will auto use nginx as ingress.I report this in #849 and try to fix it

@kingsir2011 maybe you didn't install nginx ingress and untill now,route will auto use nginx as ingress.I report this in #849 and try to fix it


Document rotated logfile filenames

I would suggest adding documentation detailing the filename format used for rotated logs.
Thanks a bunch for this, it's great!

Good idea, thanks, I will add that.

Done! Finally.

Thank you ^__^


Gradle kotlin-dsl plugin partially relies on jcenter

Expected Behavior
org.gradle.kotlin:gradle-kotlin-dsl-plugins:1.4.9 can be downloaded when jcenter is having issues and when it's shut down next year.
Current Behavior
Gradle fails because it times out when trying to find the .module file on jcenter:
A problem occurred configuring project ':buildSrc'.
> Could not resolve all artifacts for configuration ':buildSrc:classpath'.
   > Could not resolve org.gradle.kotlin:gradle-kotlin-dsl-plugins:1.4.9.
     Required by:
         project :buildSrc > org.gradle.kotlin.kotlin-dsl:org.gradle.kotlin.kotlin-dsl.gradle.plugin:1.4.9
      > Could not resolve org.gradle.kotlin:gradle-kotlin-dsl-plugins:1.4.9.
         > Could not get resource 'https://plugins.gradle.org/m2/org/gradle/kotlin/gradle-kotlin-dsl-plugins/1.4.9/gradle-kotlin-dsl-plugins-1.4.9.module'.
            > Could not GET 'https://jcenter.bintray.com/org/gradle/kotlin/gradle-kotlin-dsl-plugins/1.4.9/gradle-kotlin-dsl-plugins-1.4.9.module'.
               > Read timed out

Context
This broke our builds even when jcenter was down today even though we don't rely on jcenter otherwise.

The plugin infrastructure of Gradle has ties into JCenter. The team is working on removing them.
Unfortunately that means for now JCenter disruptions impact Gradle builds that do not have all dependencies cached.

@ljacomet And this is why I threw up a storm a few years ago when gradle started automatically deleting local caches...  Seeing that for gradle to work currently caching is required, when at the same time gradle in the past has said don't depend on caching is just maximum irony.

Hey @ljacomet , is there any updates on the timeline when a fix for the kotlin-dsl will be released?
JCenter will be doing service brown-outs between April 12-26th (Mentioned here https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ ). This means that the same issue can occur multiple times.
Is there an alternative suggestion on what can be done?

As of today, the Gradle plugin portal will no longer redirect to JCenter when a .module file, for coordinates hosted on the portal, is requested.

As of today, the Gradle plugin portal will no longer redirect to JCenter when a .module file, for coordinates hosted on the portal, is requested.

Still have the same issue but with pom files with version 2.1.7 using gradle 7.3 trying to download dependencies from Jcenter.
   > Could not resolve org.jetbrains.kotlin:kotlin-scripting-compiler-impl-embeddable:1.5.31.
     Required by:
         project :buildSrc > org.gradle.kotlin.kotlin-dsl:org.gradle.kotlin.kotlin-dsl.gradle.plugin:2.1.7 > org.gradle.kotlin:gradle-kotlin-dsl-plugins:2.1.7 > org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.31
      > Could not resolve org.jetbrains.kotlin:kotlin-scripting-compiler-impl-embeddable:1.5.31.
         > Could not get resource 'https://plugins.gradle.org/m2/org/jetbrains/kotlin/kotlin-scripting-compiler-impl-embeddable/1.5.31/kotlin-scripting-compiler-impl-embeddable-1.5.31.pom'.
            > Could not HEAD 'https://jcenter.bintray.com/org/jetbrains/kotlin/kotlin-scripting-compiler-impl-embeddable/1.5.31/kotlin-scripting-compiler-impl-embeddable-1.5.31.pom'.
               > Connect to jcenter.bintray.com:443 [jcenter.bintray.com/<IP_ADDRESS>] failed: Połączenie odrzucone (Connection refused)

Any solution for this issue?

Ok
We have found the solution for this one. Add following entry to your build.gradle.kts if you have this issue.
pluginManagement {
    repositories {
        mavenCentral()
        gradlePluginPortal()
    }
}


Can not lock!an ActiveRecord instance

Add this to spec/models/post_spec.rb and it will fail:
describe Post do
  describe "Reloading a record" do
  ....
    context "while locking" do
      it "does not throw an error" do
        expect(lambda { subject.lock! }).to_not raise_error
      end
    end

I have a PR #54 that fixes this but also wanted to leave the issue here formally.

Hi @alexagranov , since this repository is kind deprecated, I created a gem to do that: https://github.com/wbotelhos/idy
I tested this scenario and it works. I would love your feedback.


SAMZA-1718: Simplify management of Zookeeper coordination state

Currently coordination related state is spread across several Zookeeper classes. There are also back-and-forth flows that exist between the ZkJobCoordinator, ZkControllerImpl, ZkControllerListener and ZkLeaderElector. This PR nukes un-necessary interfaces (and their implementation classes), simplifies state management and unifies state in the ZkJobCoordinator class.

Clearly defined life-cycle hooks on events:

Protocol validations happen once during the lifecycle of a StreamProcessor (instead of each new session)
New subscriptions to listeners happen at each a new Zk session

@dnishimura @prateekm @shanthoosh for review

@prateekm : thanks for reviewing. I've addressed all of the feedback. take another pass at it when you get a chance?


Feature/updatedreadme

Changes to read me

Codecov Report
Base: 60.32% // Head: 60.32% // No change to project coverage :thumbsup:

Coverage data is based on head (e042d37) compared to base (d99918c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #545   +/-   ##
========================================
  Coverage    60.32%   60.32%
========================================
  Files           26       26
  Lines         2798     2798
========================================
  Hits          1688     1688
  Misses        1110     1110

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Anyway to make chat async?

Great plugin, thanks. I find myself mostly using it via chat, and sometimes waiting around while it types a long answer.  I know neovim/vim 8 have async features -- would this be possible/hard to build in?

Hi, that is a great idea! But I am not sure if it is possible in vim. Do you have any clue how to do that or do you know any plugin that does something similar?

There is a library called denops that can implement vim plugins with deno.
https://github.com/vim-denops/denops.vim
Here is an example of a plugin that just runs the chatgpt API asynchronously using denops (about 130 lines of code).
https://github.com/tani/hey.vim
I'd be happy to get a reference if you'd like.

Wow vim-denops looks really cool! Seems they manipulate vim buffer from a different process what makes all processing asynchronous. The only problem I can see with this approach is that it would probably mess up the undo tree after completion (user would need to hit undo many times to undo a single completion).
Anyway at this point I don't want to introduce any 3rd-party dependencies into vim-ai.

I attempted to try chat gpt's web browsing capabilities by asking chat gpt 4 how it would make this repository (I gave it a link) async and — though it didn't actually browse/do anything with the link — this is what it said:
Prompt:
Check out this plugin, which lets you use an openai key to interact with chat-gpt inside (neo)vim:
https://github.com/madox2/vim-ai
It'd be nice if it was asynchronous -- what do you think would be the easiest way to do that without introducing any third party plugin dependencies?
Response:
In general, making network requests asynchronous in Vim or NeoVim can be done using their built-in features. Here are a few approaches that can be considered:

Job Control: NeoVim has support for job control, which allows you to run commands asynchronously. You can use this feature to execute the OpenAI API call in a separate job and handle the result when it's done. Here is a very basic example:
function! s:handle_exit(job_id, data, event) dict
    " process the data
endfunction

let s:job = jobstart(['command', 'arg1', 'arg2'], {
            \ 'on_exit': function('s:handle_exit')
            \ })

In this example, command arg1 arg2 is executed asynchronously. When it's done, the s:handle_exit function is called with the job's output.

Timers: Vim 8 and NeoVim have support for timers. You can use this feature to run a function in the background at regular intervals. This won't make the API call itself asynchronous, but it can be used to poll for the result of an asynchronous call.
function! s:poll_for_result(timer)
    " check if the result is available
endfunction

let timer = timer_start(1000, 's:poll_for_result', {'repeat': -1})

In this example, the s:poll_for_result function is called every 1,000 milliseconds (1 second) until the timer is stopped.

Channels: Vim 8 introduced the concept of channels, which can be used for communication with external processes. This is similar to the job control in NeoVim but works slightly differently.
function! s:ReadMessage(channel, msg)
    " handle the message
endfunction

let channel = ch_open('localhost:8765')
ch_sendexpr(channel, 'some message')
ch_setoptions(channel, {'callback': 's:ReadMessage'})

In this example, a channel is opened to a local server, a message is sent, and then a callback is set to handle responses.

Please note that these are just examples and you would need to replace 'command', 'arg1', 'arg2', localhost:8765, and 'some message' with the actual command, server, and message you want to use, respectively.
In the case of the Vim plugin you linked to, the easiest way to make it asynchronous would probably be to use job control if it's targeted at NeoVim, or channels if it's targeted at Vim 8. This way, the OpenAI API call could be executed in a separate process, and the result could be processed when it's done. This would avoid blocking the editor while waiting for the API response.

Maybe this could be useful? https://github.com/prabirshrestha/async.vim

Looks cool but this plugin does not execute external commands like bash but rather use built-in python.

Is there a way we have this feature implemented? Although this plugin is really cool, it loses to the web version everyday.
Features you have while using the web version:

Async, just paste your code/question on the chat and continue your vim session and come back later.
Free, since it doesn't require an openapi key, its free.

Features you have while using the plugin:

You stay in vim, so you don't require the browser.

I would argue that the vim features are really low when comparison with the web version.

I would argue that the vim features are really low when comparison with the web version.

I disagree, I use this (along with the .aichat files) almost 100% of the time.  Cost is a non-issue, yeah open ai can subsidize it/offer a free version on their site because they developed the models but how is @madox2 supposed to have it be free in this plugin?  Also it's pretty cheap, especially with the new GPT4 Turbo.
Agree async would be nice/seems like it should be possible though.

I disagree, I use this (along with the .aichat files) almost 100% of the time.

The web version also allows for that. I do like that this plugin also offers it.

Cost is a non-issue, yeah open ai can subsidize it/offer a free version on their site because they developed the models but how is @madox2 supposed to have it be free in this plugin? Also it's pretty cheap, especially with the new GPT4 Turbo.

I'm not saying this plugin should have a work around the open api pricing, let's not jump into conclusions... Given the fact that you are stuck waiting for the job to finish it's no different than using the web version and the web version is free (for now).
With that, the original quoted statement still remains true.

I would argue that the vim features are really low when comparison with the web version.

But I'll rephrase it for a better meaning of what I meant.
This is exactly ChatGPT inside Vim, no more, a tad less. Unless being inside Vim holds that much value.

Although it is not an ideal solution, you could chat in the new terminal within vim, that would make it async. (e.g. spawn a new vim instance in the split :vert term vim and use this window for AIChat)

That looks promising and worth experimenting. Just wondering how it would update chat buffer without interrupting user doing different actions and if it could keep consistent undo sequences

I don't know if this could be helpful: https://github.com/tpope/vim-dispatch they seem to have async stuff running in the background. For LLMs it is maybe more complex as it impacts the buffer.

I'd suppose that the main difficulty is that the output is continuously written into the buffer. Apparently :Start achieves something similar, giving the example of a REPL, but this rather seems to open a terminal inside Vim instead of an editable buffer; the output halts on leaving the buffer.


External TDB Requires Device ROT

Initially posted here: https://github.com/ARMmbed/mbed-os/issues/13327
After testing, it seems that it is necessary to call DeviceKey::get_instance().device_inject_root_of_trust() before using kv store in external TBD mode (either with RBP or without). It would be helpful to update this example to include that.

@ARMmbed/mbed-os-core

@DMCEngineering it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@DMCEngineering it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@DMCEngineering it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@DMCEngineering it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@DMCEngineering it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@DMCEngineering it has been 5 days since the last reminder. Could you please update the issue header as previously requested?

@DMCEngineering Thank you for reporting the issue. Since you were testing this use case, could you consider providing a fix? We appreciate your help to keep this example up to date.

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTOSM-2832

Hi @DMCEngineering, I've created #66 to fix this, thanks.

Hi @evedon, would you please close this as it wasn't automatically closed by the PR?


Dmoynihan patch 4

Things To Remember:

Be sure to merge into the right branch. The choices are:

master if your PR runs on the current version of Tableau.
dev-2020.1
2020.2

You should update at least one of the following:

The changelog of the project you modified.
The root README.md if the PR is a release of the SDK, Connector Packager, or TDVT.
=====

Is this the same as https://github.com/tableau/connector-plugin-sdk/pull/648?


Memory leak in case of high load

Running RTSPtoWeb with many camera streams (above 25 here) causes the memory to rise until OOM occurs.
I have diagnosed the problem and found the trigger of the memory leak in the function func (client *RTSPClient) startStream() of vdk. If the OutgoingProxyQueue of the RTSPClient is full, the the succeeding return causes the stream to be restarted since SignalStreamRTPStop is emitted. However, It seems that not all resources are freed correctly.
To confirm the analysis, I have replaced the return in the case of a full channel with a continue. In this case no leak occurs and the memory consumption of the server is stable.
Relevant part of the code (vdk, format/rtspv2/client.go):
if client.options.OutgoingProxy {
  if len(client.OutgoingProxyQueue) < 2000 {
    client.OutgoingProxyQueue <- &content
  } else {
    client.Println("RTSP Client OutgoingProxy Chanel Full")
    return
  }
}
pkt, got := client.RTPDemuxer(&content)

Digging deeper with pprof the majority of the memory is allocated in vdks format/rtspv2/client.go:
       .          .    710:                                   if client.fuStarted {
       .     6.84MB    711:                                           client.BufferRtpPacket.Write(content[offset+2 : end])
       .          .    712:                                           if isEnd {
       .          .    713:                                                   client.fuStarted = false
       .          .    714:                                                   naluTypef := client.BufferRtpPacket.Bytes()[0] & 0x1f
       .          .    715:                                                   if naluTypef == 7 || naluTypef == 9 {
       .          .    716:                                                           bufered, _ := h264parser.SplitNALUs(append([]byte{0, 0, 0, 1}, client.BufferRtpPacket.Bytes()...))
       .          .    717:                                                           for _, v := range bufered {
       .          .    718:                                                                   naluTypefs := v[0] & 0x1f
       .          .    719:                                                                   switch {
       .          .    720:                                                                   case naluTypefs == 5:
       .          .    721:                                                                           client.BufferRtpPacket.Reset()
       .          .    722:                                                                           client.BufferRtpPacket.Write(v)
       .          .    723:                                                                           naluTypef = 5
       .          .    724:                                                                   case naluTypefs == 7:
       .          .    725:                                                                           client.CodecUpdateSPS(v)
       .          .    726:                                                                   case naluTypefs == 8:
       .          .    727:                                                                           client.CodecUpdatePPS(v)
       .          .    728:                                                                   }
       .          .    729:                                                           }
       .          .    730:                                                   }
     2MB        2MB    731:                                                   retmap = append(retmap, &av.Packet{
  1.22GB     1.22GB    732:                                                           Data:            append(binSize(client.BufferRtpPacket.Len()), client.BufferRtpPacket.Bytes()...),
       .          .    733:                                                           CompositionTime: time.Duration(1) * time.Millisecond,
       .          .    734:                                                           Duration:        time.Duration(float32(timestamp-client.PreVideoTS)/90) * time.Millisecond,
       .          .    735:                                                           Idx:             client.videoIDX,
       .          .    736:                                                           IsKeyFrame:      naluTypef == 5,
       .          .    737:                                                           Time:            time.Duration(timestamp/90) * time.Millisecond,

share you streams and config Im fix it

check lock loop add continue after https://github.com/deepch/RTSPtoWeb/blob/c15b3b04ee9fc2e4cd43aec4031a5296cfb73cf7/streamCore.go#L140C3-L140C53

please get report if usage 8G+

check lock loop add continue after https://github.com/deepch/RTSPtoWeb/blob/c15b3b04ee9fc2e4cd43aec4031a5296cfb73cf7/streamCore.go#L140C3-L140C53

If i skip the packetAv Processing (i.e. discard the package, i got meny ErrorStreamNoVideo logs), the memory stays way below 100 MiB.
Does this mean this might be only a buffer bloat caused by some performance bottleneck while sending the packages?
The interesting part is, that I can avoid the issue by starting multiple instances of the the server in parallel. Thus, we might se some lock contention here. For example, the function StreamChannelCast is locked on the StorageST struct, i.e. we have effectively a global lock at this place.

So i used a profiler to see where all the time is spend. Most of the time is caused by muxing the HLS Stream M3u8. This even happens despite no HLS Stream is actually streamed. Only WebRtc streams are actually connected. As far as I have seen the Streams dont even have an audio channel at all. Thus, it might benefit if we only do the HLS / Audio Muxing when it is actually needed.
(pprof) top20
Showing nodes accounting for 31.30s, 62.26% of 50.27s total
Dropped 515 nodes (cum <= 0.25s)
Showing top 20 nodes out of 162
      flat  flat%   sum%        cum   cum%
     9.51s 18.92% 18.92%      9.51s 18.92%  runtime.memmove
     4.71s  9.37% 28.29%      4.77s  9.49%  runtime.cgocall
     2.56s  5.09% 33.38%      2.93s  5.83%  runtime.findObject
     2.03s  4.04% 37.42%      8.43s 16.77%  runtime.scanobject
     1.50s  2.98% 40.40%      1.50s  2.98%  runtime.stdcall2
     1.14s  2.27% 42.67%      2.27s  4.52%  runtime.greyobject
     1.13s  2.25% 44.92%     14.93s 29.70%  runtime.concatstrings
     0.99s  1.97% 46.89%      0.99s  1.97%  github.com/pion/srtp/v2.xorBytes
     0.95s  1.89% 48.78%     20.06s 39.90%  main.(*MuxerHLS).UpdateIndexM3u8
     0.89s  1.77% 50.55%      0.89s  1.77%  strconv.rightShift
     0.71s  1.41% 51.96%      6.50s 12.93%  runtime.mallocgc
     0.68s  1.35% 53.31%      0.68s  1.35%  runtime.markBits.isMarked (inline)
     0.65s  1.29% 54.61%      0.65s  1.29%  runtime._ExternalCode
     0.64s  1.27% 55.88%      2.30s  4.58%  runtime.(*mheap).allocSpan
     0.64s  1.27% 57.15%      0.64s  1.27%  runtime.heapBits.bits (inline)
     0.55s  1.09% 58.25%      0.55s  1.09%  crypto/sha1.blockAVX2
     0.55s  1.09% 59.34%      0.58s  1.15%  strconv.(*decimal).Assign
     0.50s  0.99% 60.33%      0.50s  0.99%  runtime.stdcall6
     0.49s  0.97% 61.31%      2.20s  4.38%  runtime.sweepone
     0.48s  0.95% 62.26%      0.48s  0.95%  crypto/aes.encryptBlockAsm

try comment line //Storage.StreamChannelCast(streamID, channelID, packetAV) and test again

Yes, it can be done better, but for hls you need at least 4 segments of 4 seconds to render the video.

try comment line //Storage.StreamChannelCast(streamID, channelID, packetAV) and test again

I think the issue here is quite the opposite. If I just keep the above line (an the keyTest timer) everything runs smooth, otherwise the HLS Muxer is always run (even without any connected client) and that causes the Buffer / OutgoingPacketQueue channel to blow up. Is there a reason the hls clients are not registered the same way as MSE and WebRtc clients via Storage.ClientAdd? This would allow the execution of the HLS Muxer only in cases the HLS stream is actually requested.

Ok, I have been investigating the problem a bit more and there is indeed a memory leak, which is more likely unter high load (disconnecting Clients):
The gin context in
func HTTPAPIServerStreamWebRTC(c *gin.Context) {
is only valid until the function returns. However the goroutine is still alive afterwards and the line https://github.com/deepch/RTSPtoWeb/blob/93ae33bbe4a0a75a3161ad22e475421ff93b376a/apiHTTPWebRTC.go#L70C1-L70C1  does not reliably delete the clients, because in some cases the streamID and clientID are sometimes overwritten with different values.


Allow explicitly setting light theme independently of dark theme

Is your feature request related to a problem? Please describe.
This feels like an impossible ask, but when exporting, I wish I could use a particular theme for the light colorscheme and a totally different theme for the dark colorscheme.
Describe the solution you'd like
I could imagine nesting a couple new options under the "Theme toggle" feature, e.g., if you enable theme toggle, you get two new theme selection options, like:
Theme to use for dark    ____[theme selector]_____   [reset-to-default-button]
Theme to use for light   ____[theme selector]_____   [reset-to-default-button]

(Of course by default, both options would inherit the current theme.)
This way, I could mix and match -- use a particular low-contrast theme for dark and a totally different more boring high-contrast one for light. (For example.)
Describe alternatives you've considered
Obviously with enough time & perseverance, I could achieve anything I'm aiming for by tweaking css snippets and/or creating my own custom theme....
Additional context
None.
But the word "additional" makes me think of something even more preposterous than the above RFE: It would be so cool to export with more than two stylesheets, e.g., instead of the exported content having just a binary sun/moon toggle, what if it could have a drop-down that lets the visitor select from a few different themes? Man that would be awesome. (I have colorschemes that me and most of my peers love but which are hated by some colorblind friends and friends over 65 who complain about the contrast.)

Thanks! I don't think I will ever add this. The main problem is that this would require exporting two themes with the website which have to be BOTH loaded before the page will be displaed which is going to slow everything down. And then I have to load or unload them based on which theme we are in (this would both be slow and technically challenging).
It would be much better to create your own theme by copying the colors from your two themes and making a mashup theme. Additionally, some themes have a lot of configuration if you use the Style Settings plugin. This allows you to change different colors for dark and light mode. This is the intended approach and I beleive adding support for two different themes would end up being a worse experience in the end.
Thank you for this idea though, don't stop them coming :)

Thanks! I don't think I will ever add this. The main problem is that this would require exporting two themes with the website which have to be BOTH loaded before the page will be displaed which is going to slow everything down. And then I have to load or unload them based on which theme we are in (this would both be slow and technically challenging).

OH wow! I had no idea that was what happens under the hood. Yikes.

It would be much better to create your own theme by copying the colors from your two themes and making a mashup theme. Additionally, some themes have a lot of configuration if you use the Style Settings plugin. This allows you to change different colors for dark and light mode. This is the intended approach and I beleive adding support for two different themes would end up being a worse experience in the end.

Gotcha. I've tried to play with style settings with no luck yet. I'll give it a try again soon.

Thank you for this idea though, don't stop them coming

You rock!


[SP-4170] - Backport of PDI-16884 - Cassandra Output step does not wo…

…rk with apache-cassandra-2.1.0 (8.0 Suite)

JUnit test is provided

@pentaho-lmartins, @mchen-len-son, could you please take a look?

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -f build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  src/org/pentaho/cassandra/legacy/CassandraColumnMetaData.java
  test-src/org/pentaho/cassandra/legacy/CassandraColumnMetaDataTest.java


Non-shell based archive handling

Description of the new feature / enhancement
Relying on the Windows shell archive/zip handler feels a bit... fragile?  Odd?  I just ran into an issue with winget failing due to the archive handler being unregistered (see https://github.com/microsoft/winget-pkgs/issues/171477 for details).  That problem is certainly my fault, and I shot myself in the foot with it.  However, I noticed there's other issues in this project (e.g. #3311 and #3505) that may be a direct result of using the shell's archive handler, and I wonder if it's wise in the long term to use an archive library directly?  No idea what lib would be best for this project, or the work that would be involved, but... figured I'd raise the question.
Proposed technical implementation details
No response

The only place this caused trouble was in the system context which is why the following was implemented:

https://github.com/microsoft/winget-cli/pull/4541

We had looked at libarchive, but it wasn't available in earlier versions of Windows where WinGet is supported. We also didn't want to bloat ourselves by bringing a library along for the ride when others are already available on the system.

Fair enough, and hard to argue when my argument is based on "feels", but it also seems like the two linked issues aren't fixable while the shell extractor is being used.

If the default registry association does not support opening the zip file as an IShellFolder, winget could fall back to accessing it directly by CLSID.

That would certainly be lovely.


1.0 tck tests - Added steps for Cypher compliance kit

Also added:
Missing headers
runtests will NOT run tests tagged with in_dev

I had a few minor code formatting issues but deleted them. Not worth delaying the merge here.


Add the ability for uv pip compile to include build dependencies

Right now uv pip compile does not include build dependencies in its output. It would be incredibly helpful if there was a way to include them.

👍 Can you walk me through how you'd use this? Like, if they were included in the requirements.txt, how would you "restore" / respect them in subsequent commands given build isolation?

(I want to support this.)

My immediate use case is to prepare constraints files that can be used with --build-constraints

Now that uv build has --build-constraint support, this would enable easily building those constraints files. Right now we do it by manually preparing a requirements.in from the build-system.requires, but that's obviously manual and error prone.

What if the build requirements conflict between different packages though?

Interesting question, I hadn't considered that. I'm not sure that would occur in our use case (taking specific local projects and getting their build dependencies), but clearly in the general case, it'd be a problem.

If I'm understanding this rightly, then this is also desirable for building wheels in a Docker container from source, in which situation you want to programmatically obtain the build requirements before doing a --no-build-isolation run of pip download. You may assume here they are compatible, and just need resolving (i.e. a uv pip compile step), without this you just do this by hand by inspecting the build-system.requires TOML section of each package's build dependencies).
In this case conflict would be fine to error out on, it'd just cue the user to split this download process up per-requirement (or use separate lists? I've not encountered that problem myself... yet!)

Here's my 2 cents:

Unlike pip-compile which includes build dependencies in it's regular output with --all-build-deps, uv pip compile should only have an option to output build dependencies only, this is because uv supports --build-constraints where as pip-tools is bound by the fact pip can only pass build constraints via PIP_CONSTRAINT
It should be recommended / defaulted / forced to use --only-binary :all: when resolving build dependencies, as not to deal with recursive build requirements
It should be documented that if the user wants maximum reproducibility they must create the build requirements of each runtime requirement source distribution, and build each one with it's own build constraints
If there is a conflict in build requirements point them to some version of 3, that they must build the packages independently

Build dependencies are complicated enough that you will not be able to capture all use cases in a requirements file, but this approach should be "good enough" for a lot of users I think. Most users will probably find they are pinned to some versions of setuptools and some version of hatch, and maybe one or two more build backends, and that's it.
However, for true locking you would need to be able to capture the potential recursive nature of build requirements in a lock file format. Unfortunately when I asked some questions anout PEP 751 the response was to drop build requirements from the spec.
Finally these would be "nice to have" features if this uv pip compile "build-requirements" options existed:

Generate build requirements for all the packages in a requirement file and it only generate the requirements for those packages that are "allowed" to be sdists, taking into account --only-binary and --no-binary options.
The hash output not include sdist hashes

Doing build deps only would be fine for me
On Tue, Sep 17, 2024, 12:34 PM Damian Shaw @.***> wrote:

Here's my 2 cents:

Unlike pip-compile which includes build dependencies in it's regular
output
https://github.com/jazzband/pip-tools?tab=readme-ov-file#maximizing-reproducibility
with --all-build-deps, uv pip compile should only have an option to
output build dependencies only, this is because uv supports
--build-constraints where as pip-tools is bound by the fact pip can
only pass build constraints via PIP_CONSTRAINT
It should be recommended / defaulted / forced to use --only-binary
:all: when resolving build dependencies, as not to deal with recursive
build requirements
It should be documented that if the user wants maximum
reproducibility they must create the build requirements of each runtime
requirement source distribution, and build each one with it's own build
constraints
If there is a conflict in build requirements point them to some
version of 3, that they must build the packages independently

Build dependencies are complicated enough that you will not be able to
capture all use cases in a requirements file, but this approach should be
"good enough" for a lot of users I think. Most users will probably find
they are pinned to some versions of setuptools and some version of hatch,
and maybe one or two more build backends, and that's it.
However, for true locking you would need to be able to capture the
potential recursive nature of build requirements in a lock file format.
Unfortunately when I asked some questions anout PEP 751 the response was to drop
build requirements
https://discuss.python.org/t/pep-751-lock-files-again/59173/222 from
the spec.
Finally these would be "nice to have" features if this uv pip compile
"build-requirements" options existed:

Generate build requirements for all the packages in a requirement
file and it only generate the requirements for those packages that are
"allowed" to be sdists, taking into account --only-binary and
--no-binary options.
The hash output not include sdist hashes

—
Reply to this email directly, view it on GitHub
https://github.com/astral-sh/uv/issues/7052#issuecomment-2356406708, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAGBDPNF3AMPKAKWE7W73ZXBK25AVCNFSM6AAAAABNVFZFTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWGQYDMNZQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yeah the thing I don't know how to solve is (4) -- that every dependency defines its own build requirements, and they're welcome to conflict.

Yeah the thing I don't know how to solve is (4) -- that every dependency defines its own build requirements, and they're welcome to conflict.

For producing a constraints file (and not a structured lock file) I don't think it's possible.
The user would be responsible for handeling this situation themselves, they would need to build each package seperately with their own file, e.g by making a script that loops over their requirements and running:
for package_name in sdist-requirements.txt:
    uv pip compile {build dependency options} {package_name} > build-constraints-package_name}.txt
    uv build {package_name} --build-constraints build-constraints-package_name}.txt
    {move wheel to index / file location}
uv pip install {install options that include newly build wheel}

However, I suspect this would affect a very small number of users.

I guess my answer would be: within the limits of the requirements.txt
format, you probably can't solve it fully.
But then what Damian says comes in: it effects probably a small number of
users, and just unifying all of them likely works well enough, and doesn't
precludes a better format later.
On Tue, Sep 17, 2024, 1:56 PM Charlie Marsh @.***>
wrote:

Yeah the thing I don't know how to solve is (4) -- that every dependency
defines its own build requirements, and they're welcome to conflict.
—
Reply to this email directly, view it on GitHub
https://github.com/astral-sh/uv/issues/7052#issuecomment-2356564030, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAGBGUEM6RINC5YRBHS2TZXBULXAVCNFSM6AAAAABNVFZFTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWGU3DIMBTGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[DOCU-2783] Plugin ordering in Kong Manager

Summary

Added instructions for how to configure plugin ordering with Kong Manager. This is for Gateway 3.1.
Reason

DOCU-2783
Testing

Go to: KM tabs in /gateway/latest/kong-enterprise/plugin-ordering/get-started/
Questions for writer reviewers:

I originally created a "Plugin Ordering" subsection in the Kong Manager section of the docs for this info, but I was mostly copying what was in the Kong Enterprise "Plugin Ordering" subsection, so I figured I'd just add it there. Does this work, or should this live in Kong Manager? I thought maybe at one point we ripped out KM instructions during 3.0 and moved them to the KM section.
I know this is documenting the UI, but I think it's okay here because it's focused on teaching the user how plugin ordering works with an example vs. generic plugin ordering instructions. Thoughts?

@Leopoldthecoder Hi! Could you review the changes I made in this PR for technical accuracy? Here's the link to the doc preview: https://deploy-preview-4790--kongdocs.netlify.app/gateway/latest/kong-enterprise/plugin-ordering/get-started/
I also had a few questions:

Is this for enterprise only, or is this feature free?
Are all the steps correct for Kong Manager? I looked at the configurations for the API and yaml to figure out what fields in Kong Manager would need to be configured, but I just wanted to double check.

@cloudjumpercat Hi!

Is this for enterprise only, or is this feature free?

This is for enterprise only.

Are all the steps correct for Kong Manager?

Yes, you got them right.🚀


✨ Rename Overlay to SearchPanel

Description
Upon closer inspection, it looks like the following UI elements in Xcode all use the same view called IDESourcePanel.

Library
Open Quickly
Quick Actions

We should rename relating items in CodeEdit to be consistent with Apple's naming conventions in Xcode.
The following changes should be made:

OverlayPanel becomes SearchPanel
OverlayView becomes SearchPanelView

@austincondiff I'd like to work on this.


Micheline support

This is just the first step, allowing you to describe Michelson code buried in Micheline expressions, the code was written by @xvw and me and we decided to postpone the code description DSL to a future MR.

I did a peer-review with @xhtmlboi and the test gives us good guarantees that it's enough to build contract calls! I'm merging!


Links in tables "float" when the plugin is enabled.

Hi!
I'm seeing strange behavior in Markdown-tables when the GitHub Embeds plugin is enabled.
Behavior without plugin enabled:

Behavior with plugin enabled:

It would be great to fix this...
Thanks for plugin!

I'll look into this!


ui: improve design of IBC page

@jessepinho I think we can make some simple changes to make this look nicer, eg. change color of light grey screen box for shielding funds, removing the arrows and moving inbound / outbound boxes around, etc.

There's been a good deal of discussion regarding design of this page: https://github.com/penumbra-zone/web/pull/808. Think we've come to the end of what the eng team is reasonably able to contribute on this front. If there are specific things to immediately improve, we can certainly consider it. However, this page's design generally (along with the rest of minifront) should lean on Sam's expertise when he is ramped up.

closing in favor of a more detailed UX design process for IBC page


shp file importing with no geometry

get this file https://s3.amazonaws.com/metro-extracts.mapzen.com/madrid_spain.osm2pgsql-shapefiles.zip
uncompress it and get the line files compressed in a single file
import it in cartodb

You get no rows

Reason of the empty import. All individual rows end up failing at ogr2ogr due to encoding errors:
2015-06-29 07:16:35 UTC: ogr2ogr output:    ERROR 1: COPY statement failed.
ERROR:  character with byte sequence 0x81 in encoding "WIN1252" has no equivalent in encoding "UTF8"

Opening with QGIS and saving as with UTF-8 encoding works as expected:


perf: update error icons

This commit will update the filled and stroke error icons to increase the size for better consistency
Changes to be committed:
modified:   src/icons/error-filled.svg
modified:   src/icons/error-stroke.svg
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #248
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
BEFORE:

AFTER:

Type of change:

[ ] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[x] Update existing icons

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Michelle Noelke seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Latest build published:
http://alaska.iconstails.surge.sh/

:tada: This PR is included in version 4.41.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Missed variable $scrubbedPayload definition in send method on FluentSender

Missed variable $scrubbedPayload definition in send method
Pull request created for fix this
https://github.com/rollbar/rollbar-php/pull/392

Hi,
do you have any estimated date on this bug fix?
Thanks

It should be now fixed in release v1.6.1. Can you please double check that the fix works for you?

Hi,
i check the change and still going to fail because when uuid is defined is
using undefined $scrubbedPayload.
Create new pull request.
Saludos
El lun., 6 de ago. de 2018 a la(s) 18:16, Artur Moczulski <
<EMAIL_ADDRESS>escribió:

It should be now fixed in release v1.6.1. Can you please double check
that the fix works for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rollbar/rollbar-php/issues/393#issuecomment-410870391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADBMtdJs0l7JBhnYhVuqbqGdkg0cAP9xks5uOMApgaJpZM4VtUhG
.

Gotcha. My bad. PR merged in now.


Turn into react npm package with a nice wrapper component??

would it be possible to change this into a nice wrapped component so we can use it like
import Audio from 'react-audio-visualizer'

Hey @The-Code-Monkey !
Yeah, it's possible, but for now, I'm focused to improve some items (you can read more in the board)

@The-Code-Monkey just a little feedback, i'm so busy now, but i'll take a look in this issue when i back code into player project okay.

I'm back, I liked your suggestion, thanks!

@The-Code-Monkey I'm working on It.

https://github.com/AwesomeWebProjects/React-Player/releases/tag/v1.0.0


feat: Add additional Karpenter permissions for spot pricing improvements

Description

Add additional Karpenter permissions for spot pricing improvements

Motivation and Context

Changes in v0.13.0 release have added additional permission requirements

Breaking Changes

No

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 5.2.0 :tada:


Quest List: Add menu options for all available filters

Having to click through them to get to the one you want isn't great, I'd like to be able to directly select one. (Especially if a fifth filter is added to resolve #8689)

Would a right-click menu solve this issue? Sounds like that would be reasonable UI and UX.

Yee thats what I meant by menu options, should have been clearer there


luci-theme-bootstrap: Remove jql.min.js which does not exist

Fix 404 error
Signed-off-by: Hsing-Wang Liao<EMAIL_ADDRESS>

@jow-
That line with the reference to the non-existing jql.min.js is from your commit:
https://github.com/openwrt/luci/commit/b3c69b123a698e596a5df4797378d976718247f0#diff-7fa9a24152eff24c800bf0579b65553eR175
Any idea what was the intention?

Maybe this script reference to https://github.com/Cerdic/jQl, I am not sure.

Sorry for the delay - the introduction of this script reference was unintentional. I was playing with some lightweight jquery implementations locally and probably forgot to nuke the script tag when copying the .htm file off my router.

@kuoruan - merged, thanks a lot!


Added, timestamp is added in build time to load playground resources.

Signed-off-by: Xue, Haifeng<EMAIL_ADDRESS>

does it make sense to add timestamp to the api resources itself ? =)


Detect usage of env() function outside from config folder

[x] Added or updated tests
[x] Documented user facing changes

Closes #1695.
Changes

Hello!
This PR adds a rule to report any env calls outside the config directory. Currently it just checks for a config directory in the file name where the call is located. A more robust solution might be to use the container to grab the configured config path? However this is more complicated and I wasn't sure how exactly to do such a thing.
Thanks!

Looks like tests are currently failing on 2.x for L11

Hi,
I think we can use config_path() function and do the comparison with that.
Also I do not remember exactly now, but we might need to check that the function is actually coming from Laravel. Or at least that the function is in global namespace and not in Some\Namespace\env
Lastly, I'd prefer that it is disabled by default.

Done

@szepeviktor should be fixed now, thanks for catching!

Thank you!


Performance concern, dotTrace analysis

I used dotTrace to profile an application of mine and noticed that Swashbuckle middleware consumed an unexpectedly high amount of CPU when calling my own endpoints.
VERSION:
Version 4.0.1
.NET Core 2.1 Web API
STEPS TO REPRODUCE:
Create a Web API project and add a few endpoints.
Add Swashbuckle following the instructions here - https://github.com/domaindrivendev/Swashbuckle.AspNetCore.
Hit your own endpoints, NOT the swagger endpoints.
EXPECTED RESULT:
I expected there to be very little overhead from Swashbuckle when calling only my own action methods.
ACTUAL RESULT:
I made 210 requests to my endpoints and saw that SwaggerMiddleware and SwaggerUIMiddleware consuming on average 486 ms of CPU per request.

I am wrong about this. The numbers are high because the swagger middleware executes the next middleware and that executes the next and so on until the code that does the heavy lifting is called.
But to dotTrace it looks like swagger initiated it all.


Feature/update dockerfile

Changes ADD to COPY as mentioned in both the docker best practices page and codacy.
Also added PR template at the same time as it is a small change.

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   82.85%   82.85%
=======================================
  Files          14       14
  Lines        1044     1044
=======================================
  Hits          865      865
  Misses        179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b25cd...94052bd. Read the comment docs.


Playwright version 1.33.0

Hi,
I was trying the experimental playwright with your web components implementation, but I got some errors for the latest version of playwright (1.33.0)
Error: Package subpath './lib/mount' is not defined by "exports" in<EMAIL_ADDRESS>
Was able to "run" the tests for version 1.32.1 (the run is on quotes because of #8)

Hi @Anmo, thanks for creating the issue! Will fix this later this weekend, hopefully.

just released the fix in v1.33.0


Code appears to be injected but view doesn't refresh

I'm using the latest version 1.1.8, 5.0.0 Xcode 15.3, xrOS, device and TCA injection https://github.com/johnno1962/InjectionIII/releases/tag/5.0.0, and Xcode 15.3.
Everything properly connects and correct lists file updates.
💉 Injected type #1 '....'
However, the visuals of the view are never updated in the simulator. It's unclear if this is an issue with HotSwiftUI or InjectionIII.

Do you have an @ObserveInjection property wrapper var in the view?

Yes,I have:@ObserveInjection var forceRedraw in the view. The view does appear to refresh, but doesn't include the code changes. For example, if I set a random color for a view, the view does change color when saving file changes. However, the actual changes aren't applied (eg. changing size or adding new views).
The very first time I save a file, I get the following warning which I imagine could be related.
💉 ⚠ Injection may have failed. Have you added -Xlinker -interposable (without double quotes and on separate lines) to the "Other Linker Flags" of the executable and frameworks? ⚠
However, I do have linker flags setup.

I'm not sure if it matters, but we also configure Xcode using Package.swift. Our app is modular and uses a number of modules throughout. I've included the linker flags in each module too, but that doesn't appear to help remove the warning.
extension [SwiftSetting] {
    static let common: Self = [
        .unsafeFlags(["-Xlinker", "-interposable"]),
            .when(configuration: .debug)),
    ]
}```

You'll have to sort out the problem with your linker flags for display update to work. That error message means the new version of your View body function has not "interposed" (something like swizzling).

You'll have to sort out the problem with your linker flags for display update to work. That error message means the new version of your View body function has not "interposed" (something like swizzling).

Are there any limitations in terms of using many modules in a project? We essentially have a fully modularized project with about 100 modules that get built into a single framework and then they get added to our main project. From what I can tell, the linker flags are properly set (I see them in the build log), so it's unclear what's missing.


[boost-cobalt] Build error on x64-windows

issue_body.md

-- Using cached boostorg-cobalt-boost-1.84.0.tar.gz.
-- Cleaning sources at C:/Users/teranlab/vcpkg/buildtrees/boost-cobalt/src/ost-1.84.0-f1b8232bac.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/teranlab/vcpkg/downloads/boostorg-cobalt-boost-1.84.0.tar.gz
-- Using source at C:/Users/teranlab/vcpkg/buildtrees/boost-cobalt/src/ost-1.84.0-f1b8232bac.clean
-- Including C:/Users/teranlab/vcpkg/ports/boost-cobalt/b2-options.cmake
-- Found external ninja('1.10.2').
-- Getting CMake variables for x64-windows
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Command failed: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v
Working Directory: C:/Users/teranlab/vcpkg/buildtrees/boost-cobalt/x64-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
C:\Users\teranlab\vcpkg\buildtrees\boost-cobalt\config-x64-windows-dbg-CMakeCache.txt.log
C:\Users\teranlab\vcpkg\buildtrees\boost-cobalt\config-x64-windows-rel-CMakeCache.txt.log
C:\Users\teranlab\vcpkg\buildtrees\boost-cobalt\config-x64-windows-out.log
Call Stack (most recent call first):
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:252 (vcpkg_execute_required_process)
installed/x64-windows/share/boost-build/boost-modular-build.cmake:120 (vcpkg_cmake_configure)
ports/boost-cobalt/portfile.cmake:17 (boost_modular_build)
scripts/ports.cmake:170 (include)
error: building boost-cobalt:x64-windows failed with: BUILD_FAILED
Elapsed time to handle boost-cobalt:x64-windows: 1.3 s
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+boost-cobalt
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[boost-cobalt]+Build+error+on+x64-windows&body=Copy+issue+body+from+C%3A%2FUsers%2Fteranlab%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

See #30604 How to report a package build failure [Explanation Video]

Error code: 1
See logs for more information:
C:\Users\teranlab\vcpkg\buildtrees\boost-cobalt\config-x64-windows-dbg-CMakeCache.txt.log
C:\Users\teranlab\vcpkg\buildtrees\boost-cobalt\config-x64-windows-rel-CMakeCache.txt.log
C:\Users\teranlab\vcpkg\buildtrees\boost-cobalt\config-x64-windows-out.log

What is/are the error(s) listed in the mentioned logs?

Boost.Cobalt is supported since Clang 14, GCC 10 and MSVC 19.30 (Visual
Studio 2022).  Detected compiler is MSVC 1929.

Current Visual Studio you have installed is 19.29, but it needs to be updated to at least 19.30
Run the Visual Studio installer and upgrade.

@rczheng218, Have you tried @StarGate-One's suggestion?

C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30154 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.
So, boots  must be compiled with vs2022?

C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional>cl Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30154 for x64 Copyright (C) Microsoft Corporation. All rights reserved.
So, boots must be compiled with vs2022?

Yes, MSVC 1930 and above is VS2022.

@rczheng218, We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.


clock 1.0.1

Closes #705

I will make the commit comment actually descriptive.

I wonder whether to split this up into two commits (I have now done so). The first commit is only the generator change. However it is not 100% compatible with clock 1.0.0; it would change the test name to testTests. So maybe they should just be one commit. If you have an opinion, you should say so, otherwise I'll squash on merge because the intermediate state is not useful. The history can remain in this PR in case one needs to be reverted separately.


Add full install instructions

Builds on #31 but includes commands here that could be useful to some people, certainly would be useful for an ealier version of me! Alternative is add a link to the issue https://github.com/a-b-street/docs/issues/29#issuecomment-1003972044

LGTM, thanks! I'm not sure what skills are safe to assume, but just including both a terse and step-by-step version works! It's unfortunate that the Windows and Mac install experience can't be this easy, but sadly, both of those are blocked on figuring out how to generate signed packages.


RuntimeError: PyTorch is not linked with support for X devices

Describe the bug
I'm testing https://github.com/NixOS/nixpkgs/pull/192391 and would like to use my AMD GPU. Since i don't have HIP setup yet (CUDA translation), i tried OpenCL, Vulkan and OpenGL. All fail with this error.
[davidak@gaming:~]$ whisper --device opencl --model medium --language de test.mp4
Traceback (most recent call last):
  File "/nix/store/c1fkpcpz17mccwk9q586a6y2smlwzsbd-python3.10-whisper-unstable-2022-09-21/bin/.whisper-wrapped", line 9, in <module>
    sys.exit(cli())
  File "/nix/store/c1fkpcpz17mccwk9q586a6y2smlwzsbd-python3.10-whisper-unstable-2022-09-21/lib/python3.10/site-packages/whisper/transcribe.py", line 276, in cli
    model = load_model(model_name).to(device)
  File "/nix/store/0rz5lf0gzlc7a5zsigbk354bdwmnaxl8-python3.10-torch-1.12.1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 927, in to
    return self._apply(convert)
  File "/nix/store/0rz5lf0gzlc7a5zsigbk354bdwmnaxl8-python3.10-torch-1.12.1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 579, in _apply
    module._apply(fn)
  File "/nix/store/0rz5lf0gzlc7a5zsigbk354bdwmnaxl8-python3.10-torch-1.12.1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 579, in _apply
    module._apply(fn)
  File "/nix/store/0rz5lf0gzlc7a5zsigbk354bdwmnaxl8-python3.10-torch-1.12.1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 602, in _apply
    param_applied = fn(param)
  File "/nix/store/0rz5lf0gzlc7a5zsigbk354bdwmnaxl8-python3.10-torch-1.12.1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 925, in convert
    return t.to(device, dtype if t.is_floating_point() or t.is_complex() else None, non_blocking)
RuntimeError: PyTorch is not linked with support for opencl devices

Steps To Reproduce
Steps to reproduce the behavior:

nix run nixpkgs#nixpkgs-review pr 192391
open another shell and run the result there (it fails in nixpkgs-review shell)

[nix-shell:~/.cache/nixpkgs-review/pr-192391]$ ll results/
total 4
lrwxrwxrwx 1 davidak users 82 Sep 23 10:15 openai-whisper -> /nix/store/c1fkpcpz17mccwk9q586a6y2smlwzsbd-python3.10-whisper-unstable-2022-09-21

/nix/store/c1fkpcpz17mccwk9q586a6y2smlwzsbd-python3.10-whisper-unstable-2022-09-21/bin/whisper --device opencl --model medium --language de test.wav

Expected behavior

Options for --device appear to include: cpu, cuda, ipu, xpu, mkldnn, opengl, opencl, ideep, hip, ve, ort, mps, xla, lazy, vulkan, meta, hpu, privateuseone

Source: https://github.com/openai/whisper/discussions/55
I don't know what most of these are, but if most PyTorch distributions support them, ours should too.
cpu works, but is slow. cuda might work on nvidia, when cudaSupport is enabled for PyTorch.
Additional context
Add any other context about the problem here.
Notify maintainers
@mweinelt @teh @thoughtpolice
Metadata

system: "x86_64-linux"
host os: Linux 5.15.67, NixOS, 22.05 (Quokka), 22.05.3065.178fea1414a
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.8.1
channels(root): "home-manager-22.05.tar.gz, nixos-22.05, nixos-hardware, nixos-unstable"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Planning to implement ROCm support for pytorch.
Related:  #197885

We added ROCm support to torch in e539c148f39d7450c6ac701f0ec3404568764859.
I'm not sure how OpenCL support is going to go, but if you use an AMD GPU you should be set for now.


ADD: launcher updates

This adds launcher updates in the background without any dialogs atm.
Updater-Activities are logged via electron-log

What happens when the update fails? Is the app still able to run?

Yes, the updater finds a realease to update and downloads it. So if that fails nothing happens.
and the installation after restart shouldn't be problem if the steps before succeed.
The updater has no issues finding the right repo and the yamls are also accessable as long as they exist.


feature requests: uncomment comment box

as title says

Hey @xuestrange , you should already be able to do this with the Remove Comment Box command.
https://github.com/slysherz/vscode-comment-box/blob/master/images/usage-example.gif
(check the end of the gif)

Thank you! you're so sweet. I should remove and update comment box with the same style which I customize for myself. It's really powerful and easy-use, good job!

Thanks for the kind words : )

I should remove and update comment box with the same style

Yes, for now you have to do that. In the future I intend to make it detect the right style automatically, but that will take a while.


Questions about positional information

Hello author.
Thanks for sharing the relevant data, it's a great job.
But I have some doubts about the positional encoding in your data. As mentioned in the Readme, you have normalized the data to [0,1], but in the actual data set, the position information has a part greater than 1. can you check what is causing it

That's a great question. I have tried to normalize coordinates of each bounding box with its shape (which supposed to be normalized too, but actually it's not). Moreover, it is said that (x1, y1) is left top point, but in fact it is left bottom, and components can be negative. The only approach is to filter invalid bounding boxes, assuming that the slide size is defined by the absolute difference between the extreme components of the points on the slide $|max_x - min_x|, |max_y - min_y|$.


Resource files with non-English characters cannot be downloaded or viewed

Files with non-English characters cannot be downloaded or viewed through the file URL.
Test Environment
Video

See #2538 where I suggested limiting allowed characters in file names to be from a portable character set.

@alvacouch I am not able reproduce this issue locally. I created a file with filename containing non-english character. If I use that file on prod/beta I can see the issue. However, the same file I can download locally. One thing to note that locally I am not running nginx. I have not yet been able to run nginx locally. Do you think nginx may be causing this file download issue?

in 1.48


Record type annotations as bounds to type parameters

So far I think that this code should be OK, but we don't resolve T to its bounds.
num foo<T extends (num, {String name})>(T r) => r.$0;

The comment for DartType _resolveTypeParameter references https://github.com/dart-lang/language/issues/1182, which might be pertinent, but might be not.

https://dart-review.googlesource.com/c/sdk/+/260420


Testers needed

I want to release the first version of this fork soon, but before I can do that, I want it to be properly tested. Because I spent a lot of time developing it, I don't have all that much time to test it. Therefore, I'm looking for people with some time on their hands to test it, with the additional benefits of having earlier access to versions and having a say in the project.
Please DM me on Discord to get involved: TPGamesNL#0880

Or just join this: https://discord.gg/jDW8UbD


Ambiguous use of 'compactMap'

Bug report

[ x ] I confirm this is a bug with Supabase, not with my own application.
[ x ] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
An empty xcode swiftui project with supabase installed will not build. This is before even having it initialized.
I am getting Ambiguous use of 'compactMap' error in 3 functions for in the RealtimeChannel+AsyncAwait.swift
  public func postgresChange(
    _: InsertAction.Type,
    schema: String = "public",
    table: String? = nil,
    filter: String? = nil
  ) -> AsyncStream<InsertAction> {
    postgresChange(event: .insert, schema: schema, table: table, filter: filter)
      .compactMap { $0.wrappedAction as? InsertAction } ERROR: Ambiguous use of 'compactMap'
      .eraseToStream()
  }

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Create a new empty xcode project
Add Supabase as a repository
Try to build it

Expected behavior
A clear and concise description of what you expected to happen.
For it to work build...
Screenshots
If applicable, add screenshots to help explain your problem.

System information

OS: MacOS

Additional context
Add any other context about the problem here.

Hi, which Xcode version are you using?

Got the same error .. I am using Xcode Version 15.0.1 @grdsdev

Oh so it's really an error for everyone same using xcode version 15.0.1

I don't have Xcode 15.0.1 installed locally, but I added Xcode 15.0.1 to the CI and it is building fine https://github.com/supabase/supabase-swift/actions/runs/11956197767/job/33330387648?pr=607
Can you try cleaning derived data and all caches and trying again? Let me know if issue persists, and I'll try to get get Xcode 15.0.1 installed locally for testing.

Strange, CI runs on:

macOS 14; Xcode 15.0.1
macOS 14; Xcode 15.4
macOS 15; Xcode 16

And all working fine, let me try on macOS 13

This workflow ran on macOS 13, Xcode 15.0.1 and passed https://github.com/supabase/supabase-swift/actions/runs/11961059909/job/33346456563?pr=607
If anyone has an idea on why this strange behavior is happening, I appreciate.
PS: It says macOS 14 but it is actually macOS 13

Your CI is running xcodebuild on macOS, but the failure I'm seeing is from swift build. I guess there must be some subtle difference?
I made a simple action that just runs swift test, and you can see here that it fails on macos-13.

So i tried updating macos + Xcode, and it seems like the error is gone now.

Thanks for the fix @marcprux, please everyone update to latest v2.23.0 version.


Implement text to speech service for summary

We should create functionality to read the summary aloud for users.
@mwizasimbeye11 suggested using Microsoft's TTS API

Nice! If that doesn't work out, we could take a look at gTTS.

Nice! If that doesn't work out, we could take a look at gTTS.

I am now integrating the service.


Stop using distutils in invoke tasks

What does this PR do?

Remove uses of distutils in invoke tasks.
The only use was distutils.dir_util.copy_tree(src, dst), which is equivalent to shutil.copytree(src, dst, dirs_exist_ok=True).
Motivation

distutils is deprecated, and not installed by default starting with Python 1.12.
Since it is imported at the top of tasks files, running any invoke task requires having it, so you need to install it explicitly starting with Python 1.12.
In particular for Github workflow runners (ie. not buildimages) you would need to install it to use a more recent Python version.
Additional Notes

Possible Drawbacks / Trade-offs

To the best of my knowledge distutils.dir_util.copy_tree(src, dst) is equivalent to shutil.copytree(src, dst, dirs_exist_ok=True).
If they don't behave exactly the same then there might be unexpected behaviors, but I expect the CI to catch it.
Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Remove disqus and use internal comment tool

The new internal comment tool must have

Markdown support
Identify user

Spliting this task in smaller ones

Hey @filipeximenes @andersonresende We're already using django_markdown to edit the How to reproduce field in the Error form.
But django_markdown does not support django >= 1.8 Because it tries to do the following:
from django.conf.urls import patterns, url
Causing the error: ImportError: cannot import name 'patterns'.
Eve though you forked the django_markedown to fix that, sometimes the django_markdown is not working when you submit a new Error.
We could try use the django-pagedown, it's straightforward to use, we can make a preview and customize the css of the editor.

@alessandroHenrique I think this lib only works inside the django admin. Could you check?

@andersonresende I just checked the django-pagedown lib in the error form, placing it in the How to reproduce field and it worked.

@alessandroHenrique cool!


Predefined colors

Issue #71
I wasn't sure where predefinedColor should be. I finally put it in FillDesignable since it seems to be the best place. It works well, and as predefinedGradient, it will set its color only if fillColor isn't set.

Very good, later on, we can add on Material Colorado when we work on v4 material design elements.

I like the idea to have the completion when tapping .Flat. I just updated the PR to add the prefix "Flat" for each color. The name is a bit longer, but I don't think it's an issue since we don't choose the name of each color.

Since, the issue #94  is related to this one, I updated the implementation of all the Animatable... FillDesignable in order to have only one way to conform the protocol.

Well done @tbaranes , just merged it into master.


StyleGuide - Prefer inputs over the @Attribute  parameter decorator

*To be discussed ... *
I copied several of these from early discussions and will list them as issues for future discussion after ngConf
cc // @mgechev @wardbell

Prefer inputs over the @Attribute parameter decorator.
Why?: The input creates one-way binding which means that we can bind it to an expression and its value gets automatically updated. We can inject a property with @Attribute to a controller's constructor and get its value a single time.
/* AVOID */
@Component({
  selector: 'sg-button',
  template: `...`
})
class ButtonComponent {
  label: string;
  constructor(@Attribute('label') label) {
    this.label = label;
  }
}

/* RECOMMENDED */
@Component({
  selector: 'sg-button',
  template: `...`
})
class ButtonComponent {
  @Input() label: string;
}

We can inject a property with @Attribute to a controller's constructor and get its value a single time.

I think this should be inject an attribute instead of inject a property. This can only be used to read statically added attributes AFAIK.


enable os x file drop, add osx torrent file icon

fixes #131
partially addresses #77 for osx (now handles .torrent files)

:revolving_hearts: lots of love to go around now :revolving_hearts:

LGTM!


CMS Search & Relation Widget – fails – with large projects

Description:
I have a large project with 3 collections, two of the collections have over 2k items each. The backend is Github and I am using the use_graphql: true – which has helped to some extent as these issues were worse before.
But I'm noticing the site search can not find some items within the collections and the relation widget has the same issue which I am assuming is connected.
The site search is not a massive issue, but the relation widget is a problem, if you can't find the item you can't save a relationship.
CMS version is 2.9.7
Has anyone experienced this issue? any workarounds or ideally fixes?

UPDATE (additional info):
Regarding relationships, if you manually add the relationship to the MD file via GitHub, the CMS still does not list the relationship in the relation field even though it exists.

Can you share your config.yml?

@tomrutgers sure (removed some info)
backend:
  name: github
  repo: github/repo/address
  branch: master
  base_url: custom/auth/url
  auth_endpoint: /auth
  use_graphql: true

site_id: sitename
logo_url: /cms-logo.png
show_preview_links: false
display_url: https://sitename.com
site_url: https://sitename.com

public_folder: /img
media_library:
  name: uploadcare
  effectsTab: true
  config:
    publicKey: public-key

publish_mode: editorial_workflow

collections:

  - name: home-headers
    label: Home Headers
    folder: content/home-headers
    create: true
    summary: '{{title}}'
    editor:
      preview: false
    fields:
      - { label: Headline, name: title, widget: string }
      - { label: Description, name: body, widget: markdown, buttons: [link] }
      - { label: Image, name: background_image, widget: image }

- name: issues
    label: Issues
    folder: content/issues
    create: true
    editor:
      preview: false
    summary: '{{title}} - {{content_title}} - {{month}}.{{day}}.{{year}}'
    fields:
      - { label: Title, name: title, widget: string }
      - {
          label: Content Title,
          name: content_title,
          widget: string,
          required: false,
        }
      - { label: Description, name: body, widget: markdown }
      - {
          label: Featured Media,
          name: featured_media,
          widget: object,
          required: true,
          fields:
            [
              {
                label: Hero Image,
                name: hero_image,
                widget: image,
                hint: 'Upload / Select Image',
                required: true,
                allow_multiple: false,
              },
              {
                label: Header Image,
                name: header_image,
                widget: image,
                hint: 'Upload / Select Image',
                required: true,
                allow_multiple: false,
              },
            ],
        }
      - {
          label: Publish Date,
          name: date,
          widget: datetime,
          dateFormat: YYYY-MM-DD,
          timeFormat: false, # HH:mm,
          format: YYYY-MM-DD HH:mm,
        }
      - {
          label: Regions,
          name: regions,
          widget: select,
          options: ['Southern CA', 'Northern CA'],
          multiple: true,
        }
      - {
          label: Display Region,
          name: display_region,
          widget: string,
          required: false,
          hint: 'Just for display purposes on an issue page',
        }
      - {
          label: Selected Stories,
          name: selected_stories,
          widget: relation,
          collection: stories,
          searchFields: ['title', 'content_title', 'id'],
          valueField: id,
          displayFields: ['title'],
          multiple: true,
          required: false,
          hint: 'Search with the title or content title (displayed by title)',
        }
      - {
          label: Issue Type,
          name: issue_type,
          widget: select,
          options: ['standard', 'listicle', 'listicle_editor'],
          required: true,
          hint: 'Standard & Listicle uses selected stories, editor is freetext',
        }

  - name: stories
    label: Stories
    folder: content/stories
    create: true
    summary: '{{title}} - {{content_title}} - {{month}}.{{day}}.{{year}}'
    editor:
      preview: false
    fields:
      - { label: Title, name: title, widget: string }
      - {
          label: Content Title,
          name: content_title,
          widget: string,
          required: false,
        }
      - {
          label: Unique Identifier,
          name: id,
          widget: ncw-id,
          hint: Automatically generated unique read-only id,
        }
      - {
          label: Publish Date,
          name: date,
          widget: datetime,
          dateFormat: YYYY-MM-DD,
          timeFormat: false, # HH:mm,
          format: YYYY-MM-DD HH:mm,
        }
      - {
          label: Summary,
          name: excerpt,
          widget: string,
          required: false,
          hint: 'Please limit to 300 characters max',
        }
      - { label: Story, name: body, widget: markdown }
      - {
          label: Featured Media,
          name: featured_media,
          widget: object,
          required: true,
          fields:
            [
              {
                label: Hero Image,
                name: hero_image,
                widget: image,
                hint: 'Upload / Select Image',
                required: true,
                allow_multiple: false,
              },
              {
                label: Summary Image,
                name: summary_image,
                widget: image,
                hint: 'Upload / Select Image',
                required: true,
                allow_multiple: false,
              },
              {
                label: Video,
                name: video,
                widget: file,
                hint: 'Upload / Select Video',
                required: false,
                allow_multiple: false,
              },
            ],
        }
      - {
          label: Regions,
          name: regions,
          widget: select,
          default: 'Northern CA',
          options: ['Northern CA', 'Southern CA'],
          multiple: true,
        }
      - {
          label: Location,
          name: location,
          widget: select,
          required: false,
          options:
            [
              'Los Angeles County',
              'Orange County',
              'San Diego County',
              'Ventura County',
              'Inland Empire',
              'Deserts',
              'Greater California',
              'Points Beyond',
              'San Francisco',
              'East Bay',
              'North Bay',
              'Peninsula & South Bay',
            ],
        }
      - {
          label: Categories,
          name: categories,
          widget: relation,
          collection: categories,
          searchFields: ['name'],
          valueField: name,
          displayFields: ['name'],
          multiple: true,
          required: false,
        }
      - {
          label: Sponsorship,
          name: sponsorship,
          widget: object,
          required: false,
          hint: 'Adding sponsorship details will flag this story as a sponsored story',
          fields:
            [
              { label: Active, name: active, widget: boolean, default: false },
              { label: Name, name: name, widget: string, required: false },
              {
                label: Freetext,
                name: freetext,
                widget: string,
                required: false,
              },
              {
                label: Link / URL,
                name: link,
                widget: string,
                required: false,
              },
            ],
        }

  - name: categories
    label: Categories
    folder: content/categories
    create: false
    editor:
      preview: false
    summary: '{{name}}'
    fields:
      - { label: Name, name: name, widget: string }
      - { label: Description, name: description, widget: markdown }
      - { label: Image, name: image, widget: image }

Are you experiencing this issue with all of your relation widgets?

Just the relation widget which uses the stories collection (1.2k+ items in this collection), I only have one other relation widget, but this is for categories and its a much smaller collection.
The site search is also failing to find exactly the same items – so I'm assuming it's related.

@neilkinnish  what's your CMS version. I think your issue is related to #2406, which has been fixed.

@barthc version is 2.9.7
I was in the other issue and it did definitely help adding the use_graphql: true as the issue was worse before, but now I am seeing this again. Unless you think one of the beta versions has a fix?

@barthc @tomrutgers did you have any ideas, not sure how best to proceed?

Forgot to ask, when you visit the entries collection page do you see all 1.2k + items?

@barthc I can see from the console it's doing a lot of work to load in all the items, but no I think it's missing some. Checking the XHR requests it also seems to be missing some.

I would need you to test with the most recent beta version without using the use_graphql: true which also have a fix for the post limit.

@barthc beta appears to solve the issue – thanks.

@barthc should I definitely not use use_graphql: true though?

should I definitely not use use_graphql: true though?

I think there is an issue with graphql post limit, but @erezrokah  ran some test here  and confirmed that over 1k + items were returned.  I guess we need to test the graphql query post limit again to confirm.

I created a repo to simulate the issue:
https://github.com/erezrokah/netlify-cms-relation-widget/tree/master/content/stories
It has 3000 stories (tried 5000 at first but got hit by GitHub API limit).
I was able to search with use_graphql: true and use_graphql: false:

But I had to wait for all the stories to load first into the local cache before I could do anything.
I think the next step to improve on this is to add pagination support for GitHub but that's for another issue.

Closing this, please re-open if necessary

@erezrokah Is 5k a hard limit for collections due to the github limits?
If so, having the ability to sort collections or list by date would be useful.

GitHub API has a limit of requests per hour of 5000.
I reached the limit since I didn't have any of the files cached locally so on initial load the CMS had to download all of them. We might be able to use the GraphQL API to batch file downloads, but regardless we should look into pagination like the other backends.
As for sorting, I completely agree and we have an issue for that https://github.com/netlify/netlify-cms/issues/54

Thanks for the update 👍


support mongo dump excludeCollectionsWithPrefix or excludeCollections

I need to back up all dbs except some collections. Is it easy to add this feature? Or can someone points to me the place?

well, i don't have this need. But welcome for PR