DatabaseType does not default to "Microsoft Access"

While testing this function, I found out you had to include this parameter with the "Microsoft Access" value in order to execute the function.
Otherwise, a 2057 error is thrown when trying to import/export/link to an Access database.
Example references of this issue:
http://www.pcreview.co.uk/threads/run-time-error-2507.3780386/
http://www.access-programmers.co.uk/forums/showthread.php?t=274207

Thank you for the input to this method. The DatabaseType parameter is not required for importing actions but is required for exporting and link data actions.


bugfix for get address

I'm not sure this is correct fix.
Every time I refresh my page, I got the login page(Does this happen to you?)
And this fix is kind of update address in hooks
BUT, this also called the login endpoint every time user refresh page.
I also thought about store address in localStorage, I think it's fine and safe, right?

I'm not sure this is correct fix. Every time I refresh my page, I got the login page(Does this happen to you?) And this fix is kind of update address in hooks BUT, this also called the login endpoint every time user refresh page.
I also thought about store address in localStorage, I think it's fine and safe, right?

yes I had a not so perfect system, lots of room to

oops, closed by mistake :D

I think this is non-issue now, different fix is needed for login flow.


Improve tutorial with macros to e.g. allow to point to demo website

see https://github.com/fralau/mkdocs_macros_plugin#Using-variables

for testing:
# install mkdocs (just once)
scripts/mkdocs --install
# rebuild pages
mkdocs build
# sever locally
mkdocs serve
# upload new version to http://justpy.io
scripts/mkdocs --release

First example for this feature is at https://justpy.io/charts_tutorial/stock_charts/

the actual pointers should imho be tracked with the still open #487


Don't distribute Core\Testing when possible

For more context, please see https://github.com/googleapis/google-cloud-php/pull/1363

@dwsupplee how could a PR help you guys? Didn't quite really understand what was wrong with the previous one. Thx!!

The issue with #1363 was that we have other packages which rely on the shared Testing tooling. If you'd like to open a new PR with the thoughts you outlined here we'd be happy to take a look :).

Closing due to inactivity.


Update to 1.13.12

Would it be possible to update this to 1.13.12. The current newest version has a bug which makes it unusable in my case. I tried to do it myself but was not able to understand how to update everything properly.

if you're still looking for it, I just created a fork and a pull request for 1.13.17.
Best regards


Not able to use crop image .

I m not able to use crop images. I add dependency and even in the manifest file. but in the manifest file, it showing an error.

https://github.com/ArthurHub/Android-Image-Cropper/issues/838


Handlebars in Ver. 2?

Hi,
I'm beta testing Ver. 2.  Is it possible to use handlebars in the new version?  For example, once I get a template created, it would be great if I could just populate it via a YML file.  Is that currently possible?

If you're using the template project, you can populate content with external JSON or YML files. The Foundation for Sites docs for Panini cover this (it's the same library).
It only lets you generate page content programmatically, but you can't generate actual pages from data.

Where would I put the "data" folder and how would I tell the build process to include it?  The foundation for sites zurb template already has a data folder included.  However, the email template project doesn't.
Also, looking at the gulpfile for the template project, I don't see any reference to data or handlebars:
function pages() {   return gulp.src('src/pages/**/*.html')     .pipe(panini({       root: 'src/pages',       layouts: 'src/layouts',       partials: 'src/partials'     }))     .pipe(inky())     .pipe(gulp.dest('dist')); }
Whereas the gulpfile for sites has a reference to both the data folder and handlebars:
function pages() {   return gulp.src('src/pages/**/*.{html,hbs,handlebars}')     .pipe(panini({       root: 'src/pages/',       layouts: 'src/layouts/',       partials: 'src/partials/',       data: 'src/data/',       helpers: 'src/helpers/'     }))     .pipe(gulp.dest(PATHS.dist)); }
Do I need to include those additions to the email gulpfile?

So I managed to get it working but I had to modify gulpfile.babel.js as per the following:
function pages() {
return gulp.src('src/pages/**/*.{html,hbs,handlebars}')
.pipe(panini({
root: 'src/pages',
layouts: 'src/layouts',
partials: 'src/partials',
data: 'src/data/'
}))
.pipe(inky())
.pipe(gulp.dest('dist'));
}

Glad you got it working :)
We don't have the custom helpers or custom data features enabled by default in the template, because we anticipate (for now) that the majority of people won't use them. That src directory already has a lot of folders inside of it, so we don't want to overwhelm folks too much with all of the different features.
However, we can make sure it's clear in the documentation how to enable these features if you want them.

Following up here as the requested change in documentation still hasn't been made. There's still nothing at the panini docs that tells you that you have to modify the gulpfile.babel.js:
http://foundation.zurb.com/sites/docs/panini.html


Fetch each exercise individually from the A+ API

Description of the PR
This PR fetches each exercise individually from the A+ API. First, all exercise groups are added to the exercises tree without any exercises. Currently, an empty exercise group gets interpreted as everything being filtered out, which would need to be fixed. After the empty groups have been added, all exercises of each group are fetched, and the tree is updated after each complete group has been fetched.
The PR fixes #547 by using the list of files to be submitted to determine whether an exercise is submittable or not. This then also removes the special meaning assigned to the exerciseModules mapping in the course configuration JSON, which was used to determine exercise submittability. The exerciseModules mapping has to be maintained manually and it (before this PR) requires an entry for every submittable exercise, which makes it a burden to maintain.
I would also recommend considering whether to determine the points of exercises simply by iterating through the submissions and looking for the best points. It should become even easier when #521 is merged, which adds knowledge about best submissions to exercises. I didn't yet change it in this PR, as I haven't verified whether max points of submissions == points of user in all cases in the A+ API. I added TODO comments in the relevant parts of the code.
Testing

unit
integration
e2e
manual

- [ ] new unit tests created
- [ ] all unit tests pass

- [ ] new integration tests created
- [ ] all integration tests pass

- [ ] new e2e tests created
- [ ] all e2e tests pass

- [ ] manual testing went well

Have you updated the TESTING.md or other relevant documentation on your branch?

[ ] Yes.
[ ] Not yet. I will do it next.
[x] Not relevant.

As @nikke234 leaves, I take over this PR and the linked issue. 🙂👌

As @nikke234 leaves, I take over this PR and the linked issue. slightly_smiling_faceok_hand

Great! If any questions come up about why I've done something, feel free to ask :+1:

Note: UI tests need to be fixed.