Stop changing |enable_widevine| in gyp.

Changing it used to make sense because we used to enable it on Windows
by default before reverting that change. We're now always setting it to
the same value it has by default upstream.
Related BUG=XWALK-6207

@darktears @heke123

LGTM

LGTM


Error with effects from mods

I'm play with mod Alex's mobs and whenever I get effect from this mod i get an Error and model resets strangely

Thanks for your report!
First, I wrote the following in the readme:

This avatar is designed for work with no resource pack and no other mods are installed. An unexpected issue may occurs when you use it with any resource packs and mods (texture and armor inconsistencies, etc.).However, I won't support in these cases.

However, there is no good thing if I reject your report, so I will do it later.

This issue has been fixed. A new version will be released soon.
Thank you for your report!


Hide caption and credit for magazine banner

Feature Flagged

[ ] web\pageComponents\shared\Hero\FullImageHero.tsx

LGTM ✅


Undefined request never calls function

This bit me when an object property didn't exist. Per most callback patterns, I would expect the request() function to always return either an error or a valid object. However, when the variable for the URL evaluates to undefined, then request() will fail silently without generating an error.

Had that problem too, it just silently does nothing. This caused 1.5 hours of desperate debugging today.


Problem with texteditor in Chrome on Windows

If I want to add a link in the texteditor, the overlay appears, but I can't confirm my input. The "OK" button is missing.

on which version this bug occur? #1457

Ok I see ... in this project we have version 1.0.4

@c00n84 please check this! if its not fixed reopen it!


Display selection context/popup menu/button in-place

Like @molily's selection menu or @xdamman's selection-sharer.

@dandv thank you. I believe there a lot of bugs in this repo. I should work on it soon. :)

In the meantime I built a module that brings the best features from both SelectionMenu and selection-sharer.
https://github.com/iDoRecall/selectionmenu


Programmatically set focus on select

Hello,
How do I set the focus via JS on the bootstrap-select? I tried the focus() function on the select tag, and in the button tag of the generated code (I also tried the div, ul and li, hehehe) but without success. Does anyone know how to set focus on a bootstrap-select?
Thanks

I'm currently doing it like this. The focus moves to the select element insde the dropdown...
$("input").selectpicker().parent().find(".selected a").focus();

Doesn't work for me :/ I can't find how to put the focus too.. That's really odd

Use:
$('#select').data('selectpicker').$button.focus();

addEmploye.js:17 Uncaught TypeError: Cannot read property '$button' of undefined.
This is what i got with your code :/

Thanks ! Works like a charm !

Much better, thanks!
Now I'll do it in one step. Example for autocomplete:
$("select.autocomplete").selectpicker().data("selectpicker").$searchbox.focus();

None of the above worked in my case. It focus when selected for the first time after that it's not working

We were using
$(document).ready(function() {
    $('button[data-id=ENTER_ID_OF_THE_SELECT_ELEMENT]').focus();
});

which seems to be an unambiguous way, because the ID of the select element is used, which contains the selectpicker CSS class.

Focusing on the select element now focuses the button. So you can just do $('#select-id').focus().

Focusing on the select element now focuses the button. So you can just do $('#select-id').focus().

@caseyjhol Hm, didn't work for me with v1.13.17, while $('button[data-id=ENTER_ID_OF_THE_SELECT_ELEMENT]').focus(); still does.

@axunonb Could you link me to an example of it not working?

@caseyjhol Yes, here is the JsFiddle for it.
Strange enough, on Firefox there is no focus, while on Chrome it does focus, but displays the 'original' select:

You see the 2 alternatives for focusing at the very bottom of the demo code. My working solution is uncommented.

@axunonb I'm not able to recreate the issue where the native select element is displayed, but I am able to recreate the focus issue. It looks like it's not working because of jQuery - changing the jQuery version to 3.3.1 in your example, instead of 3.5.1 fixes it (https://jsfiddle.net/caseyjhol/xvurwn1t/3/). It appears the change was introduced in jQuery 3.4.0.

changing the jQuery version to 3.3.1 in your example, instead of 3.5.1 fixes it

Looks like jQuery's 3.5.x versions introduced a couple of issues, like this one with Bootstrap. Unfortunately using jQuery < 3.5 does not seem to be a good idea because of its vulnerabilities.
Thanks a lot, also for the workaround!


Added changelog entry that was forgotten in #412

Signed-off-by: Sönke Liebau<EMAIL_ADDRESS>Description
Added changelog entry that was forgotten in #412

Review Checklist

[ ] Code contains useful comments
[ ] (Integration-)Test cases added (or not applicable)
[ ] Documentation added (or not applicable)
[ ] Changelog updated (or not applicable)
[ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

bors r+


fix(keyviz): find nearest id if not found

Codecov Report

Merging #1268 (5849af5) into master (46de2ae) will decrease coverage by 7.42%.
The diff coverage is 65.78%.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   31.90%   24.48%   -7.43%
==========================================
  Files         297       92     -205
  Lines       17102     9369    -7733
  Branches      680        0     -680
==========================================
- Hits         5457     2294    -3163
+ Misses      11414     6934    -4480
+ Partials      231      141      -90

Flag
Coverage Δ

be_integration_test_latest
?

be_integration_test_v4.0.1
?

be_unit_test
24.48% <65.78%> (+0.36%)
:arrow_up:

e2e_test
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46de2ae...5849af5. Read the comment docs.

Please fix the lint.
Also I believe you need more tests to cover the "findOne" function. For such complicated logic function, maybe better to ensure 100% branch coverage.

How about using sort.Search to discover a lower bound, and then whether it meets upper bound? In this way you don't need to manually write the binary search or lower_bound algorithm.
Here is an example of using sort.Search to implement lower_bound: https://go-review.googlesource.com/c/go/+/29333/3/src/sort/example_search_test.go#45


Players can't leave jobs (sporadic issue)

One of my players, who has joined the fisherman job, says he can't leave the job because it says he isn't in the job.
However, his Chat title still has Fr in it, and he can't join another job because it says he has 3.
However, when he tries to quit, or when I try to fire him with admin perms, it just says "Player does not have the job Fisherman." But he clearly does.

This is really becoming quite an issue. I'll post on the thread too.

Should be fixed in latest builds


chore: testing handles package inconsistencies

:tada: This PR is included in version 1.32.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added normals calculation for non-split vertices

Hi Oskar,
Thanks for this great tool. I needed normals for non-split vertices, so I have added it to the export method.
Tested with some different models, but unsure if there are some edge-cases where it would fail.

Been too long since I wrote this to properly remember the details on this part of the code, but it looks reasonable and if you've tested it, i'm happy to merge it.


chore: add specs to the codebase

I caught a really nice issue with generative testing which was reported before grimradical/clj-semver#7

I caught a really nice issue with generative testing which was reported before grimradical/clj-semver#7

That's really cool.

Please consider using explicitly defined function applications instead of partial:
My arguments:

my stylistical preference
static analysis can arity-check better
negligible performance increase: https://www.tiagoespinha.net/2016/12/clojure-beware-of-the-partial/
less characters to write for the common case of single non-fixed arity

Was it necessary to set ^:no-gen on so many functions? If yes, was that because those had side effects? If still yes, consider suffixing their names with ! or, possibly even better, factor out the side effects.

Yes, unfortunately those functions are depending on each other and side effecting. Although your comment is valid and I'll try to extract that part into a separate function and use arguments instead in a separate pull request.


Create test in modifiedNLM

Create test module with sigma estimate and Rician denoising

It is done, I did a push into my branch.

Still needs documentation improvements before merging

I guess it is done, I added new names to the sample images and write a little about how to use test function. Besides I renamed the folder in my branch to modifiedNLM to merge with master branch later.

New documentation added for module tests and new names for sample images.


Make concurrency of RNWorkers configurable

What problem does this PR solve?
Issue Number: ref #7689
Problem Summary:
What is changed and how it works?

profiles.default.dt_fetch_page_concurrency_scale: Concurrency of fetching pages of one query equals to num_streams * dt_fetch_page_concurrency_scale.
profiles.default.dt_prepare_stream_concurrency_scale: Concurrency of preparing streams of one query equals to num_streams * dt_prepare_stream_concurrency_scale.

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-integration-test


Type "Azure Cosmos emulator"→"Azure Cosmos Emulator"

https://docs.microsoft.com/en-us/azure/cosmos-db/local-emulator-release-notes

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@SnehaGunda: I'm sorry - only the author of this article, @milismsft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#Sign-off

#sign-off

@SnehaGunda it looks like I can't sign-off either... I believe the changes must be pushed through https://github.com/MicrosoftDocs/azure-docs-pr in order to be approved and merged


Added support for SROS 19.x with SR-1 chassis for integrated model

Hi,
I've added support for Nokia SROS 19.x that removed support for the SR-c chassis for the integrated VSIM model. The only SR chassis supported for integrated model are SR-1 and SR-1s as per documentation.
I've changed the launch.py script accordingly with appropriate smbios options and card/mda config, while remaining backward compatible with previous releases (hence the major rel check).
Port configs are not backward compatible as this chassis only supports QSFP28 with breakout cables, so the port config becomes {iom_slot}/{mda_slot}/{connector-id}c/{port-id}.
Closes #200

Some output as proof and to speed up the PR :)  https://gist.github.com/wdesmedt/e39b67bcbc68f79c5760f2cc400ae33e

Actually 19.5 still supports the older integrated chassis. From the release notes for 19.5.R1.
An integrated vSIM is created when the configured chassis type is SR-c4, SR-c12, SR-1, or SR-1s. All other chassis types require a “distributed” model of deployment.
Wish I knew why they removed the c4/c12 in 19.7.


Insert pandas dataframe into InfluxDB issues

@tzonghao @aviau @xginn8 @sebito91
I am trying to store some trading data into InfluxDB using the DataFrameClient with the write_points method. I have read the documentation online as well as the following two issues, https://github.com/influxdata/influxdb-python/issues/286 and https://github.com/influxdata/influxdb-python/issues/510.
Here is what my data looks like:

Date
Ticker
Close
Volume

2018-04-15 00:00:00+00:00
MSFT
1.3
2.50

2018-04-14 00:00:00+00:00
MSFT
3.5
4.24

2018-04-15 00:00:00+00:00
AAPL
7.0
11.00

2018-04-14 00:00:00+00:00
AAPL
6.0
1.00

Below is my code:

client = DataFrameClient(host, port, user, password, dbname)
headers = ["Date","Ticker","Close", "Volume"]
data = [["2018-04-15","MSFT",1.3,2.5],         ["2018-04-14","MSFT",3.5,4.24],         ["2018-04-15","AAPL",7,11],         ["2018-04-14","AAPL",6,1]]
df = pd.DataFrame(data, columns = headers)
df.Date = pd.to_datetime(df["Date"])
df = df.set_index("Date")
tags = { "Ticker": df[["Ticker"]]}
client.write_points(df, 'test', tags = tags, protocol = "json")

However this gives this below error message when I call write_points

InfluxDBClientError: 400: {"error":"partial write: unable to parse 'test,Ticker=\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ Ticker': missing fields\nunable to parse 'Date\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ ':

A similar message shows up when I try to separate out the "Ticker" tags column out of the data frame I write, so:

timeValues = df[["Close","Volume"]]
client.write_points(timeValues, 'test', tags = tags, protocol = "json")

Leads to the same error message above. I have three questions I would really love to get help on!:

How do I fix what I am doing above?  Is it the protocol thats wrong? In the documentation, the comment suggests to use "json" as a workaround for some reported bugs
I also have the same time stamp for two different tag values (ie the same dates for both MSFT and APPL). Is this an issue when I write into the database?
For the time series I am trying to write, there will be certain nan values for some of the tickers. For example, what if volume field value for 4-14 is nan for APPL? Will this still work? There were a few bug reports that seemed to suggest I cant write nan into database. EDIT: I found this https://github.com/influxdata/influxdb-python/issues/422 posted and it seems like the work around is to have separate measurements by field and then drop the na rows before writing to database.

@dz123

I've not tried to run your code, but it seems you'd want to use tag_columns=['Ticker'] instead of tags=tags.
Should be OK, since InfluxDB series consist of "measurement" + "tags", i.e. different tags == different series.
NaN and inf are not supported in InfluxDB, see here.

@tzonghao  Thanks! That helped!

@tzonghao Thanks! That helped!

@dz123  what did you do with this error, what did you change?


Call an endpoint without Authorization header

I have a view derived from viewsets.ModelViewSet. When I call it with Authorization header, request is checked for authentication. But if I call it without the header, the access is granted.
I found this line of code. It seems to me if the header is not valid it simply returns None instead of raise exception.
Have I correctly read the code?

Now I think I know the reason: an application can have multiple authentication backend.


Make send-and-exit a public API

Isolate groups were enabled by-default in the September beta (though it's still possible to disable it via the flag).
In the October or November beta we're going to remove the flag entirely and make it the only option (if we don't hear anything concerning until then). As part of that we should make send-and-exit a public API.
@aam Could you work with @lrhn on this?

I'd love to see this API in the October beta so we could potentially get some feedback prior to going to stable

I'll start brainstorming.
As I understand it, sendAndExit will take a native SendPort and an object to send, and then terminate the isolate immediately after sending.
It's basically:
/// Sends [message] to [port] and synchronously terminates the current isolate.
static Never sendAndExit(SendPort port, Object? value) {
  port.send(value);  // If port isn't a native send-port
  Isolate.exit(); // Synchronously kills the current isolate, like `Process.exit` would for the process.
}

I'd make it static method, not an instance method on SendPort, both since it's not something you can implement on your own class that implements SendPort, and because it acts on the isolate at least as much as on the send port.
With that, we should also add Isolate.exit as a primitive, because even if we don't, you can implement it yourself as:
  static Never killCurrentIsolate() {
    sendAndExit(RawReceivePort().sendPort, null);
  }

So, maybe we should instead make Isolate.exit be the basic operation, and give it an optional "final words" argument:
class Isolate {
  ...
  /// Terminates the current isolate synchronously.
  ///
  /// This operations is potentially dangerous and should be used judiciously.
  /// The isolate stops operating *immediately*. A call to this message does not return and
  /// also doesn't throw. Pending `finally` blocks are not executed,
  /// control flow will not go back to the event loop,
  /// scheduled asynchronous asks will never run,
  /// and even pending isolate control commands may be ignored.
  /// (The isolate will send messages to ports already registered using [Isolate.addOnExitListener],
  /// but no further Dart code will run in the isolate.)
  ///
  /// If [finalMessagePort] is provided, the [message] is sent to that port
  /// as the final operation of the current isolate.
  /// (If the port is a native port, one provided by [ReceiverPort.sendPort] or [RawReceivePort.sendPort],
  /// the system may be able to send this final message more efficiently than normal port communication
  /// between live isolates.)
  external static Never exit([SendPort finalMessagePort, Object? message]);

So, basically, the operation is "exit (and maybe send)" instead of "send and exit".
Since exiting is the one guaranteed side-effect, and sending can go wrong for any number of reasons (like using a send port linked to an already closed receive port), making exit be the primary part of the name and description makes sense.
So, that's my initial API suggestion: Isolate.exit(messagePort, "It's dead, Jim.");.
I think it reads well, as a kind of "isolate exit and return this value".
(We can't make the message required if finalMessagePort is provided, which is sad, because sending null is probably not that useful.)
Considerations:
Q. What if you want to send more than one message?
A. Then send a list. Isolate communication is always between cooperating entities who can agree on a protocol.
Q. What if I want to send the message to more than one port?
A. Then send it normally. We can't optimize that anyway. Sending is secondary to exiting in this API.
It's still incredibly dangerous to just drop all finally blocks and scheduled async operations. There is no knowing which clean-up won't happen because of that.
Another alternative could be to have exit instead schedule an asynchronous task, and not execute it until control comes back to the event loop (or microtask loop, maybe with an option to choose). I think we may sometimes want to complete all microtasks first, and only exit as the next operation of the top-level event loop.
Scheduling two exits will be an error (unless we provide a way to cancel it again, which may be useful. Imagine the horror of a program knowing that it has scheduled an exit, and desperately trying to keep coming up with microtasks, just to stay alive! Or don't anthropomorphise programs. Anyway ...).
Then the exit would essentially be equivalent to sending the Isolate.addOnExitListener message to yourself with the port and message, then follow it with an Isolate.kill control message (with a suitable priority), just without the copying of the message object that you'd normally get by sending through the command port,
and also marked as being sent by merging heaps when the on-exit response is sent.
That should be easily implementable. Should be named something like:
class Isolate {
  ...
  /// Schedules the isolate to terminate as soon as possible.
  ///
  /// Sets the current isolate to terminate as if by receiving an [Isolate.kill] command.
  /// Must only be called once.
  ///
  /// If [finalMessagePort] is provided, the [message] is sent to that port when the isolate has terminated,
  /// just like ports and messages registered using [Isolate.addOnExitListener].
  /// (If the port is a native port, one provided by [ReceiverPort.sendPort] or [RawReceivePort.sendPort],
  /// the system may be able to send this final message more efficiently than normal port communication
  /// between live isolates.)
  external static void scheduleExit([SendPort? finalMessagePort, Object? message]);
}

Piggy-backing on Isolate.kill does not allow for running the microtask queue. It's always required to terminate at the latest before the next event (which includes microtask events). With an "immediate" priority, it may be able to kill running code like Isolate.exit above, if the implementation allows it. Not sure we want that.

Awesome brainstorm @lrhn !
Just wanted to note that sendAndExit can fail if you are trying to send some objects that we do not allow to send. So from this perspective it might be confusing to see that exit(message) fails in this fashion as your expectation might be that you are exiting first and foremost, sending message is secondary effect.
Only other consideration I have is that having sendAndExit go into effect immediately feels important because you want to be sure that object you are sending is what you have at hand when you call sendAndExit. Probably you don't want to have any tampering done to this object by async/finally code.

related: https://github.com/dart-lang/sdk/issues/37835

I would probably agree with @lrhn about finally blocks not running being problematic. For example, you might be using a finally to flush and close a file descriptor, and be surprised to find that sometimes your file doesn't end the way you expected (or get closed precisely when you thought it would).

From the other thread, the concern about whether an object gets collected on a different thread probably isn't a huge deal - the VM already does that to us anyway, e.g. when running a multi-threaded collection I've observed the object finalizers getting run on a VM worker thread rather than the mutator thread.

Another reason to have sendAndExit take effect right away without execution of the finally clauses is that that is what Isolate.kill is doing and one can argue that sendAndExit is effectively killing current isolate and sending some message to some designated SendPort.

Perhaps sendAndKill would be a clearer name then?
Alternatively, if possible, have some kind of parameter to sendAndExit to control whether it's killed or allowed to finish anything.

The word Exit matches Process.exit and therefore carries the connotation of immediately exiting. (And avoids the "kill"/"die" wording, which honestly should be avoided. Sorry about Isolate.kill, it should have been .shutdown or .exit instead).
As mentioned before, we can make it delay the send until being back at the event loop, but that only ensures evaluation of synchronous finally block, not async ones, so it's only a partially solution. Even then, I suggested returning a Future which would complete if sending failed, possibly with the error (and not if sending succeeded, because then the isolate would have shut down). That would also entirely delay serialization until that point, rather than doing double work.

Agree, and as I mentioned, it only runs synchronous finally clauses, so it's only removing some of the risk of an early exit, not all of it. So, exiting immediately is probably fine.

Just to be sure - Flutter's compute function would be fine here because how we set up the ports right?
See https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/foundation/_isolates_io.dart#L92
If we changed line 98 to use sendAndExit, and then removed the call to isolate.kill, all finally blocks within the callback would still execute (assuming some error did not result in early termination of the isolate)?

@dnfield yes, Flutter's compute should be fine(back when we introduced sendAndExit internally we tested that too).
The callback should be done and all it's finally clauses should be completed by the time we get to sendAndExit(or Isolate.exit(port, object) as @lrhn proposed) at line 98.

Great. In that case I'm fine with this. I think if anything we'd just add a comment in the implementation to remind ourselves that we have to make sure any important work is finished because anything that's unawaited or in a finally block will not execute after sendAndExit.

(Flutter's compute does not seem to be adversely affected by this. It's not actually safe as written: There is no guarantee about the order of delivery of events sent to different receive-ports, even between the same two isolates. With the current code, It's technically possible to send a result, terminate, send the onExit event, and have the onExit handler react before the result handler. With the current code, an error event could also arrive at any time, if the error happens after sending the result.
Consider using the same port to receive all the messages, using null for the onExit message, a one-element list with the result and a two-element list for errors. I think we do promise events sent to the same receive-port from the same isolate to be delivered in-order.)

Filed https://github.com/flutter/flutter/issues/90693


Change Search Icon According To Latest Material Design

Hi @no-go,
thanks for your awesome app!
This PR just updates the search icon so that your app is fully Material now.  😅

Hi Kerstin. Thanks for your PR. But something is a bit stange: you changed android-drawable/ic-menu-search to drawable/ic-search ... but normally in my drawable resources there is no ic-search icon.

😎 in the very next days I will try it. thanks for your contributing 👍

Hi Kerstin.
Your pull request locks very strange to me:

the first request does not have the icons, you want to have to update
the update of your pull request consist icons that are unusable for me. My design needs with ones and not black.

 You did not recognise the screenshots of my app.

I am new to Android, so my changes might be indeed strange. Sorry for the confusion.
My idea was to change the search icon (the magnifying glass).
This is your app now:

My plan was to use that new icon: https://material.io/tools/icons/?search=search&icon=search&style=baseline
I hope you get my point now.

hm. I will think about it. material is not my favourit and it cost to much time to change just that single icon to a white one 🙄

I found a good white icon in the android defaults. I try to use this one. Thank you for the hint - it looks realy a bit better. I fix a small bug, thus an update was necessary anyway 😌

Thank you so much, @no-go! 😎
That is exactly what I imagined. It looks fabulous.
And again, sorry for the confusion with my crazy code.


Custom Font Support

Is your feature request related to a problem? Please describe.
I'm writing my own GitHub Codespace image for my personal GitTea but with neovim.
And i use Nerdfonts for my Icons. I tried to use a fork but he adopted it not fully a lot broken and it dose not work in my Dockerfile.
It would be really nice if it were possible to use custom fonts.
My repo: https://git.lorenzzz.dev/lorenzhohermuth/nvim-pod

https://github.com/tsl0922/ttyd/wiki/Serving-web-fonts


Incorrect tip amount scaling (only native currency) in partial fill scenario when using fulfillOrders

Component
API
Have you ensured that all of these are up to date?

[X] seaport-js
[X] Node (minimum v16)

What version of seaport-js are you on?
4.0.1
What function is the bug in?
fulfillOrders
Operating System
macOS (Apple Silicon)
Describe the bug
Tip amounts in native currency are incorrectly scaled when performing a partial fill resulting in a much lower fee amount being charged than intended.
The most recent SDK version(4.0.1) includes a fix intended to address the issue where tip amounts were not at all scaled to the proportion of the order being filled in a partial fill scenario when using fulfillOrders. Unfortunately that fix has introduced a new bug where tip amounts are being incorrectly scaled (scaled to a much lower value than required) because the tip amounts sent to the Seaport contract are the scaled down values when they should infact reflect the original full order view.
Scenario:

Create an order to sell 10 ERC1155 tokens at 1 ETH per token so total order value if 10 ETH.
Include a 2% fee on the order which will be 0.2 ETH for the entire order or 0.02 ETH per token.
Execute a partial fill for 2 units of the order by invoking sdk.fulfillOrders()

Expected
Actual

Cost of tokens
2 ETH (2 * 1 ETH)
2 ETH (2 * 1 ETH)

Fees
0.04 ETH (2 * 0.02 ETH)
0.008 ETH (2 * 0.004 ETH)

Total
2.04 ETH
2.008 ETH

Note: This issue affects only partial fill scenarios using native currency which are executed by calling fulfillOrders and only seen in v4.0.1 of the SDK.

PR to address this.


ResetModel and updateInitialValue form options does not work when model is updated within code

Description
ResetModel and updateInitialValue form options does not work when model is updated within code
Minimal Reproduction
https://ngx-formly-edit-model-reset.stackblitz.io
Steps to reproduce

Enter some value in text and options
click on Update initial Values button
click on edit button
click on reset button

Current behaviour
model / form values are not getting reset to initial value. it takes editModel value.
Actual behaviour
model / form values should get reset to initial value.
Your Environment

Angular version: 7
Formly version: 5.10

That`s expected behavior when the model input changes the initial value is updated too.

what is your recommended solution to implement this scenario.
currently i am storing initial model values in temp variable then whenever i want to reset i just replace model with temp variable. is this correct approach?

I think so, or you can pass the initialModel to resetModel method:
options.resetModel(initialModel)


working on serialization of World and Creature

Because Creature contains Box<dyn Genotype>, I'm trying to use erased-serde to do the serialization.
But I'm struggling to see how to derive from erased-serde::Serialize.

@GDYendell @garryod any ideas?
See https://github.com/gilesknap/eyes2/blob/6a1f8e736af66b2b1086efd71cbfa38d03adb6ed/eyes2-lib/src/entity/creature.rs#L38-L46

Looks like you've missed the #[macro_use] extern crate erased_serde; and the serialize_trait_object! macro on Genotype. Not sure about serializing a mpsc::Sender though

Thanks @garryod the #[macro_use] seemed to only work in the lib.rs file - don't really understand what it is doing. But the secret was to use the Serialize from serde_derive.


promiseContinuationCallback will be unavailable after GC

Path :Chakra-Samples/Chakra Samples/JSRT Universal Windows Apps Hosting Samples/C#/JsRT_UWP_Sample/ChakraHost.cs
Line32:             JavaScriptPromiseContinuationCallback promiseContinuationCallback = delegate (JavaScriptValue task, IntPtr callbackState)             {                 taskQueue.Enqueue(task);             };

Thanks for pointing it out! Added a quick fix to extend the lifetime. https://github.com/Microsoft/Chakra-Samples/commit/6f26a2023a250bb4906de0224592891940309c88


Fix RapierDebugRenderPlugin::always_on_top.

Resolves #345.

Looks like this is already fixed as of #340, so you could use the master branch until the crate is updated.

I just experienced this issue, @dimforge please can you expedite review/merge?

I'm not sure that this PR does anything, always_on_top seems to work on the master branch at the moment.

@Aceeri after commenting I switched to master and can confirm this bug is fixed.
Probably worth a patch release to crates.io and closing this PR if it is now redundant.
Great work to everyone involved to date!

Thanks for the PR. Since it’s already fixed on master I’ll close it and make a new release shortly.


PHP 7.x UnitTests do not run

No PHPUnit tests for PHP 7+ have been run in Travis since PHP 7 support was added. PHPUnit init fails and exits before tests run, but still returns passed.

Fixed in v2.1.0.


v1.2.0 Crash App on Android

Stacktrace
com.facebook.react.bridge.NativeArgumentsParseException: RNScreenshotPrevent.enableSecureView got 1 arguments, expected 0
at com.facebook.react.bridge.JavaMethodWrapper.invoke(Unknown Source)
at com.facebook.react.bridge.JavaModuleWrapper.invoke(Unknown Source)
at com.facebook.jni.NativeRunnable.run(Native Method)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(Unknown Source)
at android.os.Looper.loopOnce(Looper.java:230)
at android.os.Looper.loop(Looper.java:319)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(Unknown Source)
at java.lang.Thread.run(Thread.java:1012)

same

Argument Error in react-native-screenshot-prevent Package v1.2.0 with React Native 73.6 or Higher
Description:
In addition to the issue with the react-native-screenshot-prevent package in version v1.2.0, I'm encountering difficulties when trying to compile my React Native application with version 73.6 or higher using the New Arch configuration enabled. The compilation fails during the process, adversely affecting the progress of my application development.
Steps to Reproduce:
Install the react-native-screenshot-prevent package in version v1.2.0 in a React Native project with version 73.6 or higher.
Configure and use the RNScreenshotPrevent.enableSecureView function as documented.
During the execution of the application, observe the com.facebook.react.bridge.NativeArgumentsParseException error indicating that RNScreenshotPrevent.enableSecureView received an incorrect number of arguments.
Attempt to enable the New Arch configuration.
Execute the application compilation process.
Expected Behavior:
The RNScreenshotPrevent.enableSecureView function should be used correctly, without argument errors, according to the documentation provided by the package.
The application should compile successfully, even with the New Arch configuration enabled.
Current Behavior:
During the execution of the application, the com.facebook.react.bridge.NativeArgumentsParseException error occurs, indicating that RNScreenshotPrevent.enableSecureView received an incorrect number of arguments.
The compilation of the application fails during the process, preventing the generation of the compiled application.
Additional Information:
Version of the react-native-screenshot-prevent package: v1.2.0
React Native Version: 73.6 or higher
New Arch Configuration: enabled
Specific details about the compilation failure, if available (e.g., error messages, stack trace)
Other relevant dependencies and versions
This issue is creating a significant obstacle in the development of my application. Any assistance or guidance on how to resolve this issue would be greatly appreciated.

I just started using/testing the lib and I got the same issue, for Android the code inside enable() and enableSecureView() seems to do the same thing, so as a workaround I'm only calling RNScreenshotPrevent.enableSecureView() if the platform is iOS to avoid the issue.
RNScreenshotPrevent.enabled(enable);
Platform.OS === 'ios' && RNScreenshotPrevent.enableSecureView();

I just started using/testing the lib and I got the same issue, for Android the code inside enable() and enableSecureView() seems to do the same thing, so as a workaround I'm only calling RNScreenshotPrevent.enableSecureView() if the platform is iOS to avoid the issue.
RNScreenshotPrevent.enabled(enable);
Platform.OS === 'ios' && RNScreenshotPrevent.enableSecureView();

PR #40: Pull Request Submitted for Fixing the Problem
I've opened a Pull Request to address the issue at hand. I'm hopeful that the maintainer will review and approve it promptly. This fix will allow us to resume using the application smoothly and in accordance with the official documentation. Thank you for your attention to this matter.

same issue here

@amalStorilabs Unfortunately, the maintainer hasn't responded to this issue yet, but we already know why it happens. After the last update, which allows placing an image for the secureView (supported only for iOS), a treatment wasn't added to prevent sending this to the Java code, causing the app to break because the Java code isn't expecting a parameter. I sent a PR to fix this issue, which unfortunately hasn't been reviewed by the author yet. I hope we can get a response soon. For now, follow @rafaelsmag's steps:
Platform.OS === 'ios' && RNScreenshotPrevent.enableSecureView();

pls check 1.2.1 version

pls check 1.2.1 version

solved for me


Theme is not applied when components are imported in a different project

I have a monorepo with two projects. The first is an Admin library providing a UI skeleton for the application and it is meant to be reused in other projects too. It provides an Admin Template with layouts, mui components and UI logic.
The second project is the actual application which uses the first.
In my Admin library project I expose a root component <AdminPanel />. Inside it I have a ThemeProvider with a mui theme.
All mui components that are imported in the Admin library are styled after this theme.
In my Application, I have pages that use mui components. I import those componets directly from<EMAIL_ADDRESS>(@mui/material is installed as dependency in both the library project and in the application project. same version in both).
I realised that the mui components imported in my application project do not get styled after the theme I create in the <AdminPanel /> component. The only way to style them was to re-export all mui components I need from within the library project, and in my application project I import those re-exported components and not directly from @mui/material.
Is this expected behavior?
What I would like to have:
// in my-library project
import { ThemeProvider, createTheme } from '@mui/material/styles'

const theme = createStyles(...);

export const AdminPanel = ({ children }) =>{
    return (
    <ThemeProvider theme={theme}>
        <TextField label="search" ... /> // <-- This text field gets styled
        {children}
    </ThemeProvider>);
}

// in app project
import { AdminPanel } from 'my-library'
import TextField from '@mui/material/TextField'

export Page = () => (
   <AdminPanel>
      <TextField label="name" ... /> // <-- This text field doesn't get styled
   </AdminPanel> )

What I have now
// in my-library project
import { ThemeProvider, createTheme } from '@mui/material/styles'
export { default as TextField } from '@mui/material/TextField'  // <-- I re export the component

const theme = createStyles(...);

export const AdminPanel = ({ children }) =>{
    return (
    <ThemeProvider theme={theme}>
        <TextField label="search" ... /> // <-- This text field gets styled
        {children}
    </ThemeProvider>);
}

// in app project
import { AdminPanel, TextField } from 'my-library' // <-- I need to import the re-exported component

export Page = () => (
   <AdminPanel>
      <TextField label="name" ... /> // <-- Now this text field also gets styled with same style
   </AdminPanel> )

I feel a little stupid. The problem was a not hoisted @mui dependency, leading to two instances of mui in the application. After deleting all node_module folders and lock files and re-installing, problem was solved.


Legacy clean

Addresses different style issues and "code smells" in effort to make the code easier to understand and maintain. Some style issues are addressed just to make code more consistent across modules.  Also fixes licences to BSD-2. pom-scijava is updated to 20.1.0 but no further due a build issue.

It's annoying that the update in https://github.com/bonej-org/BoneJ2/pull/94/commits/cd0051ea9ae750dbc4a989771c0e767c738d4892 breaks mvn install for now, but it's more important to depend on an up-to-date version of pom-scijava.


Set core dep version to 1.1.0

There were additive changes made to core which caused the dependency version of core to be updated. These changes are, right now, only needed by a single library and are causing problems with other libraries that need to release since the new version of core has not been released. This is a temporary change to unblock those releases while further discussion around these kinds of changes is reviewed.

Should the other Azure Core modules use a current version dependency on Azure Core given that they ship in unison? Also, I think that would resolve all the PR validation failures happening here.

Should the other Azure Core modules use a current version dependency on Azure Core given that they ship in unison? Also, I think that would resolve all the PR validation failures happening here.

As per our conversation, there was a second additive change to core that wasn't accounted for in the first commit that is for the second.


 I think it warrants a gem cut, as people are asking for the ability to set timeout values.

Relevant commits: https://github.com/oscardelben/firebase-ruby/commit/138b1e1461ff33da506b0d7992b42e3544be9cf1 and https://github.com/oscardelben/firebase-ruby/commit/8cb61f70392968c4b6ac0d3f5ce124a98c1e131b

Hi, I will try to push a new version tomorrow. Thanks for all the work!

@oscardelben I'm also happy to admin the rubygems bit too, if you want another pair of hands there.

New version pushed!


⚠ Bofrost.lu has degraded performance

In 53cb781, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2238 ms

Resolved: Bofrost.lu performance has improved in b01d827 after 8 minutes.


Updated documentation and comments that mentioned StrSubstitutor.

Problem:
StrSubstitutor was recently replaced by StringSubstitutor in the code, but some mentions in the comments and documentation were not updated.
Solution:
Replaced mentions, including naming of library that the replacement came from.
Result:
Docs a little more up to date with the code.

Good catch! I missed the doc references when making the change. Thank you!


SetContents: Table and List in HTML: List not displayed

Describe the bug
I try to load html content for a simple ul or li list with table included. But List is missing in editor.
To Reproduce
Use this Strings with "editor.setContents(html)". Also try with "value" in options.
List is Missing - This is the bug:

Test head II

Simple List

deep

asd

asd

asd

asd

Check (just removed the table in code) - This is working:

Test head II

Simple List

deep

How to reproduce by yourself:

Load the Editor
Write a headline, a simple list, a table
Save the String with editor.getContents(false) (also tried with true)
Use this String with setContents

Expected behavior
Should show list AND table.
Desktop (please complete the following information):

OS: Windows 10
Browser Firefox
Version 98.0

The 2.43.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Feature Request: multiple saves/in game load menu

I would love to be able to have multiple saves since I don't often have time to do long runs anymore because of life. When I do get the chance to resume a longer run, I would often like to start a different run with a different character but don't want to lose my good run progress. It would be sweet to have a little menu that pops up that has a list of all my in progress runs and shows the character I was playing, stage number, and run time. For multiplayer, it could also show a quick list of other player names/character icons. Lastly, could have a load and delete button on the bottom for once you've selected a run. I know a lot of these features are a long shot but I figured I'd put in a request anyway, it's been something I've been thinking about for a while, thank you for your time!

Hello, thanks for your request, but I won't do it. That makes no sense since there are unlockables that will not be available in saved games. And I don't like the idea of multiple saves in rogue-like games. None of the other rogue-like games I know do multiple save, it's always only a continue button.


O365ConnectorCardHttpPOST setBody doesn't set the body correctly

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.6.0-preview7
Describe the bug
When creating a O365 Connector Card, if we set the Body for the action - it fails to set the same on the O365ConnectorCardHttpPOST object.  On verification of the code in bot-schema lib - we see that the setBody(withBody) method sets body=body instead of body = withBody.

@TeamMateTech Thanks!  Fix will be in the next release coming up any day now


Non-standard-address

thread 'main' panicked at 'Non-standard address', /Users/XXXX/.cargo/registry/src/github.com-xxxxxxxxx/umya-spreadsheet-0.8.3/src/structs/address.rs:41:13

I get this error when I try to read few files (not all) using umya_spreadsheet::reader::xlsx::read()
when I copy the sheet content through excel and paste it in new excel file, it is read without any fail.
Can someone please help with this

Thank you for contacting us.
Hmmm, perhaps the error is caused by an unexpected value being passed when reading the Excel file.
We will investigate the cause.
Please provide us with the Excel file that causes the error, or the characteristics of the file, detailed error information, etc., to the extent possible.


feature request: accepts multiple argument strings.

I'm using enogu in https://github.com/EdamAme-x/rippu.js
Enogu is nice library.
Can you please accept multiple argument stringst?
(...str: string[])=> string
That way I can write cleaner code.
red(...runeList)
instaed of
red(runeList.join(""))

Thank you for your suggestion.
I will give it a positive consideration.
Please allow me some time to investigate the performance issue.


drag and drop on react big calendar does not work in an iframe (onSelectSlot not getting called)

Do you want to request a feature or report a bug? Bug
It does not look like drag and drop on react-big-calendar work in an iframe. With an iframe, it doesn't look like rbc picks up the select slot event (onSelectSlot). Everything else seems to work fine.
What's the current behavior?
dragging on empty slots does nothing.
What's the expected behavior?
Rbc works similar in an iframe as out of it.

stale


⚠ ClamAV has degraded performance

In e1adf28, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 245 ms

Resolved: ClamAV performance has improved in 767d581 after 6 minutes.


The canvas view moves in the direction of the cursor

Steps to Reproduce

Launch Ketcher
Create any structure
Click the Ctrl+C buttons.
Click the Ctrl+V buttons.

Actual behaviour:
The canvas view moves in the direction of the cursor
https://github.com/epam/ketcher/assets/62464241/577bf6af-2ee9-4ef2-bf94-6f14cf8aa096
Expected behaviour:
The canvas view is staying in place
Ketcher version [e.g. v2.4.2].
Version 2.13.0-rc.2

Tested. Bug is fixed.


GitLab CI Trusted Publisher Docs Are Misleading in Regards to Workflow File Path

The trusted publisher docs describe the workflow file path field for Gitlab as follows:

The file path of the publishing workflow, relative to the project's root. This file should exist in the project configured above (external workflows are not supported).

In the security considerations page, the docs add:

The claims defined in an OIDC token are bound to the workflow, meaning that a workflow defined at foo.yml in org/repo cannot impersonate a workflow defined at bar.yml in org/repo.
[…]
Trust the correct workflow: you shouldn't trust every workflow to upload to PyPI; instead, you should isolate responsibility to the smallest (and least-privileged) possible separate workflow. We recommend naming this workflow release.yml.

This makes it seem like the workflow file path field should be set to a the YML file that's included from the top-level .gitlab-ci.yml file. For example, if a project had .gitlab-ci.yml as the top-level CI config, and from that file included ci/release.yml, you would think that workflow file path should be set to ci/release.yml.
However, this isn't the case. The warehouse code compares workflow file path to the path in the ci_config_ref_uri field of the Gitlab CI JWT claim. This field is defined in Gitlab's documentation as follows:

ci_config_ref_uri: The ref path to the top-level pipeline definition, for example, gitlab.example.com/my-group/my-project//.gitlab-ci.yml@refs/heads/main. Introduced in GitLab 16.2. This claim is null unless the pipeline definition is located in the same project.

Thus, since the claim contains the path to the top-level pipeline definition, even if all the release steps are contained in the ci/release.yml, the workflow file path in PyPI must be set to .gitlab-ci.yml to actually work.

Thanks for the report @crgwbr!
Yeah, this looks like a mistake in our documentation: ci_config_ref_uri is always going to reference the top-level CI definition (which is typically .gitlab-ci.yml, but can be configured to something different).
I think the docs there were probably copied over from GitHub Actions and its concept of multiple independent workflows in individual files. For GitLab, we should probably just suggest .gitlab-ci.yml as the default workflow path and remove the "minimal scoping" suggestion (since AFAIK GitLab is entirely YAML inclusion based and doesn't have the ability to separate permissions by include).

PR open here: https://github.com/pypi/warehouse/pull/15921


Customize sass variables not work in rtl mode

First problem: I can't import bootstrap's rtl to custom.scss
Second problem: I can't change default values of variables

Hi there.
You can't import RTL files to your Sass since there's no such thing in Bootstrap. We use a single Sass source, which outputs our LTR files, then run RTLCSS on it to compile their RTL counterparts.
RTLCSS allows customizations using comments block in the LTR sources, as mentionned in our docs.
We might be clearer on how to proceed, I guess: any suggestion is welcome.

Hi there.
You can't import RTL files to your Sass since there's no such thing in Bootstrap. We use a single Sass source, which outputs our LTR files, then run RTLCSS on it to compile their RTL counterparts.
RTLCSS allows customizations using comments block in the LTR sources, as mentionned in our docs.
We might be clearer on how to proceed, I guess: any suggestion is welcome.

I'm closing this but I added a mention in #32330 to see what can be done in our docs.

I'm closing this but I added a mention in #32330 to see what can be done in our docs.


v1.3 compat

added Project.toml, updated LDA.jl and Topicmodels.jl to compile and run under Julia v1.3

lgtm, thanks!

cool.  I'm working on a PR that includes some refactoring to support a
current project.  I'm hoping you like it, but if you don't I won't be
offended.
On Mon, Mar 2, 2020 at 10:09 AM Jonathan Chang<EMAIL_ADDRESS>wrote:

lgtm, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/slycoder/TopicModels.jl/pull/8?email_source=notifications&email_token=AACRZ453PW7HAZZLC63SOM3RFPY4TA5CNFSM4K7ISGXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQK3WY#issuecomment-593538523,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACRZ4ZFJ2GE5ULEA7VC3TLRFPY4TANCNFSM4K7ISGXA
.


Question: Changing m-file has no effect.

Hi,
I am doing some tests and have an m-file test.m. I am calling this with
mat"""
result = test();
"""
@mget result
println(result)

Everything works great. My result is extracted from Matlab into Julia and I can print it to the REPL, BUT if I change the m-file, the output is unchanged.
I guess this illustrates a misunderstanding on my part? I thought mat"..." simply called my Matlab function, but if that were the case, changes to test.m would be reflected in Julia, but changes are not being reflected. Why is that? Is there some way to have changes to the m-file reflected in Julia?

Here is a sample code that has me confused:
using MATLAB

function test()
    path = Pkg.dir("Coherent","src","matlab")
    println(path)
    mat"""
    cd($path)
    p = which('test');
    a = test(4,5);
    """
    @mget p
    println(p)
    @mget a
    println(a)
    txt = open(readall,p)
    println(txt)
end

test()

The output is:
julia> include(Pkg.dir("Coherent","src","matlab","matlab.jl"))
C:\Users\Eric Forgy\.julia\v0.4\Coherent\src\matlab
A MATLAB session is open successfully
C:\Users\Eric Forgy\.julia\v0.4\Coherent\src\matlab\test.m
[0.4034911431245899 0.3316652387426293 0.8841530577496601 0.04740146202915074 0.5449058982446715
 0.12202051825212956 0.15223401286294647 0.09427839006414607 0.3423735031607398 0.6862234629840409
 0.26843882139728314 0.34800765971611347 0.930040626107489 0.7359661588801641 0.8936326959336016
 0.2578461701126047 0.12165845430772615 0.3990199690345555 0.7946821573338052 0.054791789919732437]
function results = test(m,n)

% results.name = 'Test';
% results.a = rand(m,n);

results = 'Test';

Basically, I get the path of my m-file and print it to the REPL: looks good.
Then, I cd into that path from with mat"..." and try a which to make sure I am calling the correct test.m and store the path to a Matlab variable. I extract that variable to Julia and print it to the REPL: looks good.
Then, I run the Matlab test code and store the results to a variable and extract that variable from Matlab to Julia and print it to the REPL. not good. The results correspond an old version of test.m.
Then, to make sure there isn't something strange with my paths, etc., I actually read the m-file contents into Julia and print them to the REPL. Looks good. I can see the latest code.
But why isn't that code running and the old test is running. Is it getting compiled/cached somewhere? If so, how do I stop it from doing that? Clear the cache somehow? How?
Thanks!

It's my fault, but I'm really in a bind and need to sort this out soon. Hope someone can help :sweat:

I don't really know how this package works, but have you tried sending a clear all to matlab?

Thanks @tkelman !
My Matlab code is pretty big with a heavy initialization step and then I want to send light update requests from Julia. So clear all helps with the initialization step, but then when I later call update, I don't want to clear all again or I lose my initialization. But even if I clear all just in the initialization step, the update called after a clear all in the initialization step is still stale and doesn't recognize changes in the m-file. The only way I can get the update to recognize changes in my m-file is to reboot my computer. So there must be something saved somewhere :sweat:

How about rehash $PATH?

Thanks @inhorton. Will try :muscle:
We have a product demo and was saving this piece until last because I was "confident" it would work :sweat_smile:

Apparently this is possible from the Python engine driver (at least if you open the editor via the engine?):
http://www.mathworks.com/help/matlab/matlab_external/call-user-script-and-function-from-python.html

Thanks @ihnorton . I just tried rehash and no luck. In fact, I was wrong earlier. Even rebooting my computer doesn't help. It is still running the old test.m from 2 days ago.
I would be happy to learn I am doing something completely stupid if it got me a solution, but I am quite sure this is something with MATLAB.jl.

 It remains that I need to restart my computer in order to have MATLAB.jl see my changes to the m-file.

My demo went "OK", but could not use MATLAB.jl. I doubt it is a problem with MATLAB.jl and it is probably just a problem with using Matlab via ActiveX. Conclusion.


how to test if a state's requested controller is actually instantiated?

I'm writing unit tests for the various ui-router state configurations for an app. I would like to test if the controllers named in state configuration objects are actually instantiated and have the resolved dependencies successfully injected.
I have tried a variety of methods to obtain a reference to the controller within a karma/mocha unit test, but to no avail. I have found that
$state.$current.controller

when used in a state containing a named function just returns a string of the name of the function requested. If a controller is directly defined on the state config object, it returns a reference to the function.
I've been through every ui-router testing doc/blog post/article that I can find, but none of them appear to address this problem. Basically I just want to get a reference to the requested controller and/or its scope object after the controller has been instantiated and injected with the state's resolved dependencies so I can test if everything is instantiated correctly.
I've implemented a solution that feels like a total kludge, by forcing a state change to the intended state (actually a child state b/c I'm testing an abstract state), getting the resolved deps from the globals object, and manually instantiating the controller using $controller:
      // instantiate GenesViewController using resolved deps from event.genes state
      goFromState('initial').toState('events.genes.child', { geneId: 238 });
      expect($state.$current.name).to.equal('events.genes.child');
      var deps  = $state.$current.parent.locals.globals;
      scope = $rootScope.$new();
      GenesViewController = $controller('GenesViewController', {
        $scope: scope,
        Genes: deps.Genes,
        MyGeneInfo: deps.MyGeneInfo,
        gene: deps.gene,
        myGeneInfo: deps.myGeneInfo
      });

Is there a better way to do this?

It should be enough to test the resolves, the current (not the lack of $) name and that the controller is a string or function. You could always move the controller to a named one to make it easier to test.
If you do come up with something better, write it up in a blog post because others will probably find that useful and we can tweet it or link it or something.


Discuss NASA dataset

Opening a thread to discuss NASA dataset. We can add comments and discuss its characteristics, suitability for using it for benchmarking.

Can this code be used for multi variate dataset?

@sajinpgupta yes! Checkout our multivariate tutorial https://github.com/sintel-dev/Orion/blob/master/tutorials/Multivariate_Input.ipynb
Also related #265.


Oneof must have at least one field

Using the master branch of nanopb, I have not been able to get any .proto files with oneof working. My other proto files, without oneof work correctly.
I'm using 3.6.1 protoc installed via Homebrew (<IP_ADDRESS>)
Proto2: sample.proto
syntax = "proto2";

message Bar {
  optional bytes data = 1;
}

message Foo {
  oneof value {
    Bar bar = 1;
  }
}

  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1861, in <module>
    main_plugin()
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1846, in main_plugin
    results = process_file(filename, fdesc, options, other_files)
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1727, in process_file
    headerdata = ''.join(f.generate_header(includes, headerbasename, options))
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1404, in generate_header
    yield msg.fields_declaration(self.dependencies) + '\n'
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1028, in fields_declaration
    defval = self.default_value(dependencies)
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1127, in default_value
    desc = google.protobuf.descriptor.MakeDescriptor(optional_only)
  File "/usr/local/Cellar/protobuf/<IP_ADDRESS>_1/libexec/lib/python2.7/site-packages/google/protobuf/descriptor.py", line 1015, in MakeDescriptor
    _message.default_pool.Add(file_descriptor_proto)
TypeError: Couldn't build proto file into descriptor pool!
Invalid proto descriptor for file "d68bf30050157c4439e43ac1aba6144e.proto":
  Foo.value: Oneof must have at least one field.

--nanopb_out: protoc-gen-nanopb: Plugin failed with status code 1.

Proto3: sample.proto
syntax = "proto3";

message Foo {
  oneof value {
    int32 bar = 1;
  }
}

Traceback (most recent call last):
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1861, in <module>
    main_plugin()
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1846, in main_plugin
    results = process_file(filename, fdesc, options, other_files)
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1727, in process_file
    headerdata = ''.join(f.generate_header(includes, headerbasename, options))
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1404, in generate_header
    yield msg.fields_declaration(self.dependencies) + '\n'
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1028, in fields_declaration
    defval = self.default_value(dependencies)
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1127, in default_value
    desc = google.protobuf.descriptor.MakeDescriptor(optional_only)
  File "/usr/local/Cellar/protobuf/<IP_ADDRESS>_1/libexec/lib/python2.7/site-packages/google/protobuf/descriptor.py", line 1015, in MakeDescriptor
    _message.default_pool.Add(file_descriptor_proto)
TypeError: Couldn't build proto file into descriptor pool!
Invalid proto descriptor for file "5df690209b200d56fb41c82ebf9a1f91.proto":
  Foo.value: Oneof must have at least one field.

--nanopb_out: protoc-gen-nanopb: Plugin failed with status code 1.

I've pushed a possible fix (in two commits) for this problem, but for some reason I'm having trouble reproducing it myself so can't be sure if it fixes it.
If problem still occurs, could you try adding in nanopb_generator.py line 1129 before MakeDescriptor() call a print statement and post the debug info:
    sys.stderr.write("DESCRIPTOR: %s\n" % repr(optional_only))

Thanks for the quick reply!
As a result of the latest master branch, same proto3 as above:
syntax = "proto3";

message Foo {
  oneof value {
    int32 bar = 1;
  }
}

I get (with the added sys.stderr):
DESCRIPTOR: name: "Foo"
oneof_decl {
  name: "value"
}

  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1864, in <module>
    main_plugin()
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1849, in main_plugin
    results = process_file(filename, fdesc, options, other_files)
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1730, in process_file
    headerdata = ''.join(f.generate_header(includes, headerbasename, options))
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1407, in generate_header
    yield msg.fields_declaration(self.dependencies) + '\n'
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1028, in fields_declaration
    defval = self.default_value(dependencies)
  File "/Users/sureshjoshi/Developer/Scratch/nanopb/generator/nanopb_generator.py", line 1129, in default_value
    optional_only.ClearField('oneof_decl')
TypeError: field name must be a string
--nanopb_out: protoc-gen-nanopb: Plugin failed with status code 1.

If I remove the commit that added 'ClearField' - then we go back to the original problem
Unfortunately, I don't understand what is going on here, because I'd like to pitch in to help any way that I can.

Thanks, that at least gives more information. Can you check output of this command:
python -c 'from google.protobuf.internal import api_implementation; print(api_implementation._default_implementation_type)'

Based on https://github.com/protocolbuffers/protobuf/issues/3658 it seems the reason you're having different results could be if your system has cpp implementation, while mine has python implementation of Google's library. I didn't even know there are two different implementations, I'll have to add this to my test systems.
I pushed a further fix that might now work.

python -c 'from google.protobuf.internal import api_implementation; print(api_implementation._default_implementation_type)'
cpp

And yes, that latest fix works. Thanks!

I'll keep this open so that I'll remember to add this to the test suite.


Health probe section not covered for service type LB.

[Current AKS supported versions have upstream doc that talks about health probe protocol, port and path config as detailed here https://cloud-provider-azure.sigs.k8s.io/topics/loadbalancer/#loadbalancer-annotations but these are not covered in our doc.
Can this doc be updated with some examples if this is supported and if not supported, can we get that posted explicitly ?]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 60a7a0a8-97e7-0fda-763c-1a9972f4e9bc
Version Independent ID: 82b46441-43fc-fe48-97e2-0f3fca3d6eab
Content: Use a public load balancer - Azure Kubernetes Service
Content Source: articles/aks/load-balancer-standard.md
Service: azure-kubernetes-service
Sub-service: aks-networking
GitHub Login: @asudbring
Microsoft Alias: allensu

@rp-msft
Thanks for your feedback! We will investigate and update as appropriate.

@rp-msft
I'm going to assign this to the document author so they can take a look at it accordingly.
@asudbring
Can you please check and add your comments on this doc update request as applicable.

#reassign:schaffererin


UCD T

UCD T
Originally posted by @yazdanidana in https://github.com/prisma/prisma/issues/4729#issuecomment-1005183854

This issue is clearly spam and was reported to GitHub.

@.***
On
Sent with Aqua Mail for Android
https://www.mobisystems.com/aqua-mail


Clock snap running on Unity 7 and Unity 8

This snap should work on both versions of Unity.

Known issues:

For some reason, the .desktop file is not picked up on Unity 7. I've checked for typos, but I've not seen anything obvious.
On Unity 8 it needs to be installed with --devmode to work. Only in Unity 7 does it work with strict confinement.
On Unity 8 the icon does not appear on the launcher
On Unity 8 the icon does not appear in the Apps scope

This change is

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):

cd $SNAP
exec $SNAP/usr/bin/qmlscene $SNAP/usr/share/ubuntu-clock-app/ubuntu-clock-app.qml --desktop_file_hint=unity8

I added this as Unity 8 apps seem to use it, but I'm not sure about its function and if it has any effect on Unity 7

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.

ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):

description: The clock app for all Ubuntu devices
confinement: devmode

Changed to devmode, as otherwise it does not work under strict confinement in unity 8. Perhaps a unity8 interface is still missing?

Comments from Reviewable

ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):
Previously, dplanella (David Planella) wrote…
> I added this as Unity 8 apps seem to use it, but I'm not sure about its function and if it has any effect on Unity 7

Do you think you can add this as an XXX: to the wrapper or README so other who copy and paste this are aware of this? :-)

Comments from Reviewable

ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):
Previously, dplanella (David Planella) wrote…
> Changed to devmode, as otherwise it does not work under strict confinement in unity 8. Perhaps a unity8 interface is still missing?

Do you recall if there were any log messages?

Comments from Reviewable

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):

Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表;
Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表;
Exec=ubuntu-clock-app.clock

I think this is ubuntu-clock-app now.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

ubuntu-clock-app/snapcraft.yaml, line 6 [r2] (raw file):
Previously, dholbach (Daniel Holbach) wrote…
> Do you recall if there were any log messages?

Yes, on Unity 8, with strict confinement and using the unity7 plug it said it could not connect to the Mir server and coredumped. I've been told there was some initial work on a unity8 interface, but it's stalled: https://github.com/snapcore/snapd/pull/1229

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):

Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表;
Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表;
Exec=ubuntu-clock-app.clock

Will fix it.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

ubuntu-clock-app/clock.wrapper, line 66 [r2] (raw file):
Previously, dholbach (Daniel Holbach) wrote…
> Do you think you can add this as an XXX: to the wrapper or README so other who copy and paste this are aware of this? :-)

Done.

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):
Previously, dplanella (David Planella) wrote…
> Will fix it.

Done.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 4 unresolved discussions.

ubuntu-clock-app/setup/gui/ubuntu-clock-app.desktop, line 134 [r2] (raw file):
Previously, dholbach (Daniel Holbach) wrote…
> I think this is `ubuntu-clock-app` now.

Done.

Comments from Reviewable

Comments from Reviewable

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Path for whitelisting the hashes is in different location

https://github.com/secure-device-onboard/pri-fidoiot/blob/master/component-samples/demo/rv/README.md
config.properties file exists in /util/storage-samples/storage-rv-sample/src/main/resources/
But in readme file, it has different path

Fixed in commit e74c21e8


Show header height when show state

Show header height when show state

Wait https://github.com/neo-project/neo/pull/2259.


package main disallowed import path

What version of Go are you using (go version)?

$ go version
go version go1.13.3 darwin/amd64

Does this issue reproduce with the latest release?
i don't know ,first use module, mac down but linux works well with the same situation
What operating system and processor architecture are you using (go env)?
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/crusj/Library/Caches/go-build"
GOENV="/Users/crusj/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/crusj/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/crusj/go/src/micro/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/x8/v_x56q612ml4rk7b51lmy5140000gn/T/go-build739983740=/tmp/go-build -gno-record-gcc-switches -fno-common"
go env Output

What did you do?
go run main.go

├── go.mod
├── go.sum
├── main.go
└── test
    └── test.go
main.go
package main

import (
	"fmt"
	"github.com/crusj/testmod"
	"mod/test"
)

func main() {
	fmt.Println(testmod.Hi("roberto"))
	test.T()
}

test.go
package test
func T(){
  println(111)
}

go.mod
module mod

go 1.13

require github.com/crusj/testmod v1.0.1

What did you expect to see?
111
What did you see instead?
package main
imports mod/test: disallowed import path "mod/test"

This is working as expected.  In general import paths should either be in the standard library or should start with a domain name.  In effect the go tool treats all paths starting with "mod" as being in the standard library, but none of those paths may be imported.

3q


No automatic README update after release

The workflow fails ... of course.
Have no time now, will fix that later this week.
NPM publishing succeeded.

Forgot that the release is not on a branch :grimacing:

Ah now I know, to prevent a new readme after release started before release published.
Fixing.


Revert "Flutter tool support for dynamic code"

Reverts flutter/flutter#20543
several of the iOS builds are now failing with "018-08-15T13:02:25.952794: stderr: Invalid argument(s): Could not find an option named "dynamic"." That seems to be related to this PR.

RSLGTM

cc @sbaranov

Landing on red to fix the build


SPARQL query execution result with no PREFIX

The result of a SPARQL query execution does not return any PREFIX which is already defined in the query. Is there a way to parse the query in order to get Namespaces/Prefixes from the query?
Is there a way to execute a query in such a way that the result contains Prefixes as well?

Not quite sure what you are after ...
what about assigning those explicitely in the body of the query? e.g.:
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix p1: <http://p1.org/>
prefix p2: <http://p2.org/>
prefix p3: <http://p3.org/>

select * {
    {
        values ?prefix {p1: p2: p3: rdfs:}
    } union {
        bind (1 as ?other)
    }
}

Not quite sure what you are after ...
what about assigning those explicitely in the body of the query? e.g.:
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
prefix p1: <http://p1.org/>
prefix p2: <http://p2.org/>
prefix p3: <http://p3.org/>

select * {
    {
        values ?prefix {p1: p2: p3: rdfs:}
    } union {
        bind (1 as ?other)
    }
}

So following is the query I use:
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX welcome: <http://welcome/services/1.0/>
				CONSTRUCT {
					?dip rdf:type welcome:DIP_request_info .
					?dip welcome:dip_age ?age .
					?dip welcome:dip_residence_address_city ?city .
				}
				WHERE {
					?dip rdf:type welcome:DIP_request_info .
					?dip welcome:dip_age ?age .
					?dip welcome:dip_residence_address_city ?city .
				}

Here is the result I get:

http://welcome/services/1.0/dip1 http://www.w3.org/1999/02/22-rdf-syntax-ns#type http://welcome/services/1.0/DIP_request_info
http://welcome/services/1.0/dip1 http://welcome/services/1.0/dip_age  "26"
http://welcome/services/1.0/dip1 http://welcome/services/1.0/dip_residence_address_city  "unknown"

In the Construct query I define PREFIXes, but the result has no Prefix. Therefore, the model which is generated from the above statements have no Namespaces. I tried to parse SPARQL query and set namespaces manually but unfortunately couldn't find anything to do that.
Honestly, I don't know how to assign prefixes in the body of the query.

just provide a suitable RDF format for the result of your query that support such feature as prefix - e.g. Accept: text/turtle format for instance

Thank you very much :)
I was using Repositories class to execute queries instead of RepositoryConnection.


 I think we should start failing tasks using this handler in our next release (m161) and completely remove it in the following release.
@vtbassmatt are you still good moving forward with this? Looks like you had some say in this last time, not sure if you remember any context to add

I'm +1 on making this change.
We shouldn't make this an adoption blocker for Server 2020, though. I propose we start failing tasks with that handler right now, but leave in an option to override / get back to old behavior. After we snap for 2020 (meaning that 2020 will ship with an agent capable of -- but not happy to -- run these legacy tasks), we can fully remove it in the next agent release. Thoughts?

We'll postpone this until 163 to give RM a chance to update their tasks.


windows/server, windows/servercore container manifest broken: no matching manifest for windows/amd64

the windows/server https://hub.docker.com/_/microsoft-windows-server docker image's manifest is broken: get error no matching manifest for windows/amd64 on docker running on windows-server.
Describe the bug
The dockerhub page lists that the image tags ltsc2022 are multiarch. However when I try to pull the image using docker-ce installed on my windows server, I get the error saying no matching manifest for windows/amd64 10.0.17763 in the manifest list entries.
I have installed docker following Windows Server instructions for Docker CE / Moby available at https://learn.microsoft.com/en-us/virtualization/windowscontainers/quick-start/set-up-environment?tabs=dockerce#windows-server-1  to install docker on my windows server, which is running Windows Server 2019 Datacenter.
To Reproduce

Install Docker on a Windows Server 2019 using the Docker CE / Moby instructions available at https://learn.microsoft.com/en-us/virtualization/windowscontainers/quick-start/set-up-environment?tabs=dockerce#windows-server-1
try pulling any windows/server or windows/servercore docker images. e.g.  docker pull mcr.microsoft.com/windows/server:ltsc2022

Expected behavior
The docker image is successfully pulled
Configuration:

Edition: Windows Server 2019 Datacenter
Base Image being used: windows server
Container engine: docker
Container Engine version: Server Version: master-dockerproject-2022-03-26

Additional context
Please see the screenshot showing the error, as well as the docker info.

You're trying to run a Windows Server LTSC 2022 container on Windows Server LTSC 2019, that's not supported.
The full error is telling you that: "no matching manifest for windows/amd64 10.0.17763 in the manifest list entries", i.e. docker is looking for a Windows Server LTSC 2019-compatible AMD64 image, and not finding one.
Try pulling mcr.microsoft.com/windows/server:ltsc2019, that should work.


obs-ndi 4.7.1 -> 4.9.1

Project description
The version for the obs-ndi plugin is a bit out of date
Metadata

homepage URL: https://github.com/Palakis/obs-ndi
license: gpl2+
platforms: linux

ping maintainer @peti
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/video/obs-studio/obs-ndi.nix


Refactor getPage (in the worker), and attempt to use the Linearization dictionary to lookup the first Page

/botio-windows test

/botio-linux preview

/botio test

Good to have this; thanks!


Cannot sign messages v2.0.0-alpha.8

Describe the bug
I am trying to sign a message as follows. The message is constructed with a nonce fetched from API, so I cannot use the signMessage hook. However, I am unable to sign and receive this error:
index.js:289 Uncaught (in promise) Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"id\":42,\"error\":{\"code\":-32601,\"message\":\"The method personal_sign does not exist/is not available\"}}", error={"code":-32601}, requestBody="{\"method\":\"personal_sign\",\"params\":[\"0x416c6c2074683238383238323832323132\",\"0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266\"],\"id\":42,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="https://rpc.walletconnect.com/v1/?chainId=eip155:1&projectId=ad4b621ec25179121f07c6d0cd5c7a60", code=SERVER_ERROR, version=web/5.7.1)

SDK Version
@web3modal/react:  2.0.0-alpha.8
To Reproduce
  const { account, isReady } = useAccount()
  const { provider } = useProvider()
  const signer = provider.getSigner(account.address)
  signer.signMessage("message")

Expected behavior
Successful signature

Ty for bringing this up, looks like something is erroring on our rpc level related to personal_sign. I will propagate this to our infra team 👍 Meanwhile, any chance you could configure this with public or your own custom rpc and check if you are still getting that error?
Also, could you explain why exactly you are not able to use signMessage hook, perhaps I could adopt it to account for workflows that include nonce.

Thanks for the update - I got it to work successfully with the hook by passing in the constructed message. I was confused with the example but I figured out we can pass the message directly into signMessage() instead of setting it initially with useSignMessage
Example
const { data, error, isLoading, signMessage } = useSignMessage({
  message: 'WalletConnect web3modal message'
})
signMessage()

Implementation (this works)
  const { data, error, isLoading, signMessage } = useSignMessage()

async function handleSignIn() {
    // user object is usually fetched from API
    const user = {
      "nonce":<PHONE_NUMBER>8212,
      "id": 1,
      "public_address": "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266",
      "email": null,
      "created_at": "2022-10-25T22:27:27.682Z",
      "updated_at": "2022-10-25T22:27:29.185Z"
    }

  const message = `Login code: ${user.nonce}`

  try {

    const signature = await signMessage({ message })

    // validate signed message with nonce on backend
    const response = await fetch(`/api/users/signin?public_address=${account.address}&signature=${signature}`, {
      method: 'post'
    })
    const apiResponse = await response.json()
    setSignedIn(apiResponse.authenticated)
  } catch (e) {
    console.log('Wallet login canceled - please try again')
    console.error(e)
  }
}

I also tested by  using @web3modal/core directly and was able to sign:
import { SignerCtrl } from '@web3modal/core'

  async function handleSignIn() {
    const signer = await SignerCtrl.fetch({ chainId: 1 })
    const message = `Login code: ${user.nonce.toString()}`
    const signature = await signer.signMessage(message)
  }

Awesome! I'll see if we can improve docs / examples to make this more clear. Hook tries to account for 2 use cases

Message is known initially
Message is constructed later (your use case)


tokenrequest: add webconsoleurl to basicauth challenger

This is to sync the lib-go code with what's in oc.
xref https://github.com/openshift/oc/pull/991

/lgtm


IOError: [Errno Input overflowed] -9981

I am getting below error when I try to run Jasper.
sudo python jasper.py
*******************************************************
*             JASPER - THE TALKING COMPUTER           *
* (c) 2015 Shubhro Saha, Charlie Marsh & Jan Holthuis *
*******************************************************
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.hdmi
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.hdmi
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.modem
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.modem
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.phoneline
ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.phoneline
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
Traceback (most recent call last):
  File "jasper.py", line 148, in <module>
    app.run()
  File "jasper.py", line 118, in run
    conversation.handleForever()
  File "/home/pi/jasper/client/conversation.py", line 31, in handleForever
    threshold, transcribed = self.mic.passiveListen(self.persona)
  File "/home/pi/jasper/client/mic.py", line 121, in passiveListen
    data = stream.read(CHUNK)
  File "/usr/lib/python2.7/dist-packages/pyaudio.py", line 605, in read
    return pa.read_stream(self._stream, num_frames)
IOError: [Errno Input overflowed] -9981

Note:I have tested ALSA configuration using arecord (sudo arecord test.wav) and aplay (sudo aplay -D plughw:0,0 test.wav) and it works fine.
Any help regarding this will be greatly appreciated.

This is a configuration issue with your audio device.  Please see the forum.


Save table in Docker problem

Hey there!)
I got some problems using the package in docker. I got this traceback inside:
>>> df = pd.DataFrame({"1": [1, 2, 3], "2":[5, 1, 5]})
>>> dfi.export(df, "pic.png")
[0819/121227.333151:ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.6/site-packages/dataframe_image/_pandas_accessor.py", line 24, in export
    return _export(obj, filename, fontsize, max_rows, max_cols, table_conversion, chrome_path)
  File "/usr/local/lib/python3.6/site-packages/dataframe_image/_pandas_accessor.py", line 73, in _export
    img_str = converter(html)
  File "/usr/local/lib/python3.6/site-packages/dataframe_image/_screenshot.py", line 167, in run
    img = self.take_screenshot()
  File "/usr/local/lib/python3.6/site-packages/dataframe_image/_screenshot.py", line 119, in take_screenshot
    img = mimage.imread(buffer)
  File "/usr/local/lib/python3.6/site-packages/matplotlib/image.py", line 1496, in imread
    with img_open(fname) as image:
  File "/usr/local/lib/python3.6/site-packages/PIL/ImageFile.py", line 121, in __init__
    self._open()
  File "/usr/local/lib/python3.6/site-packages/PIL/PngImagePlugin.py", line 676, in _open
    raise SyntaxError("not a PNG file")
SyntaxError: not a PNG file

Dockerfile with relevant to the issue part:
FROM python:3.6.14-buster

RUN apt-get update && \
    apt install chromium-driver libpng-dev tree -y

COPY requirements.txt .
RUN pip install --upgrade pip
RUN pip install -r requirements.txt

I do use: dataframe-image==0.1.1; matplotlib==3.3.4
I have installed chromedriver ChromeDriver 90.0.4430.212
you can also see libpng-dev installation, it was one of my tries to fix the problem.. so I guess that image may not contains needed  utils for the correct working of chromedriver
maybe this problem has already been solved or, can you list what dependencies are needed tho?
Thank you!)

I was able to resolve this in a more secure manner by following this post.  I am now able to save a table to png in a docker image.

@rogfut
thanks you for you answer, but I still have a problem
I have tried both variants:

I have tried to add "privileged: true" string in my docker-compose
I also have tried to add this file  and asked docker-compose

        security_opt:
          - "seccomp=./chrome.json"

both times I got an error:
[0928/124915.366587:ERROR:zygote_host_impl_linux.cc(90)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.
Could you please describe what you have done in more detail?

any update on this? still facing the same issue in python-docker.

I am also facing the same issue in docker (and running the docker container with --privileged is not working for me).

@ShiraUnger , have you tried the latest 0.1.2 version?

With setting dataframe_image to version 0.1.2 i still have the issue
FROM ubuntu:22.04
ARG DEBIAN_FRONTEND=noninteractive

RUN apt update; apt install -y python3-pip
RUN pip install jupyter tqdm pandas==1.4 numpy seaborn==0.11 matplotlib scipy dataframe_image==0.1.2
RUN apt-get update && apt install chromium-driver libpng-dev tree -y

With setting dataframe_image to version 0.1.2 i still have the issue
FROM ubuntu:22.04
ARG DEBIAN_FRONTEND=noninteractive

RUN apt update; apt install -y python3-pip
RUN pip install jupyter tqdm pandas==1.4 numpy seaborn==0.11 matplotlib scipy dataframe_image==0.1.2
RUN apt-get update && apt install chromium-driver libpng-dev tree -y

I have tried the same image and found error is different:
Python 3.8.10 (default, Jun 22 2022, 20:18:18)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pandas as pd
>>> df = pd.DataFrame({"1": [1, 2, 3], "2":[5, 1, 5]})
>>> import dataframe_image as dfi
>>> dfi.export(df, "pic.png")

Command '/usr/bin/chromium-browser' requires the chromium snap to be installed.
Please install it with:

snap install chromium

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/dist-packages/dataframe_image/_pandas_accessor.py", line 48, in export
    return _export(
  File "/usr/local/lib/python3.8/dist-packages/dataframe_image/_pandas_accessor.py", line 117, in _export
    img_str = converter(html)

Try snap install chromium in your image

Move temp html directory under $HOME in 0.2.0 and should solve this problem.


Refactor sidebar

Description: Refactor the application's sidebar to make it more versatile and allow for the addition of more items. This includes adding a button that enables users to create new menus directly from the sidebar. This enhancement streamlines menu management and improves overall navigation within the application.
Tasks:

Redesign the sidebar to accommodate additional items and a "Create New Menu" button.
Implement the functionality to create new menu pages when the button is clicked.
Ensure that the sidebar remains user-friendly and intuitive after the refactor.
Each menu page must have its own URL
Test and validate the updated sidebar's behavior and responsiveness.


Recommend what to do with output from cron jobs

When a cron job creates any output, normally a mail is sent to the owning (or configured) user. Because  phusion/baseimage-docker does not contain an executable named sendmail, cron just logs in syslog that the output is discarded.
Since phusion/baseimage-docker is about "Getting everything right", I suggest to handle this case or to mention how to handle it.
my collection of suggestions:

add a simple mta (like dma) and configure it to deliver local only
and handle the files in /var/spool/mail/ (cat messages to syslog, inform about new mail on stdout, ...)
write a simple sendmail which accepts the message and forwards it to syslog or stdout or ...
when sendmail binary shall not have an effect on other processes, set a special PATH in cron.runit
in case it is not for cron only, handling modes set by arg -bm and -bs
mention in the doc how to handle the output of cron jobs

pipe to logger: * * * * * my-executable-run-by-cron 2>&1 | logger --id=$$ --tag cronJobName # so handled by syslog
redirect to "normal" stdout/stderr: maybe * * * * * my-executable-run-by-cron 1> /proc/1/fd/1 2> /proc/1/fd/2
ignore when unimportant: * * * * * my-executable-run-by-cron | grep -v -e toIgnore -e otherToIgnore | ... or maybe * * * * * my-executable-run-by-cron >/dev/null 2>/dev/null
duplicate to a log file, to check this when the warning comes from syslog: my-executable-run-by-cron 2>&1 | tee /var/log/my-log
recommend some other tricks: * * * * * chronic my-executable-run-by-cron | ...

Note: piping the output hides the exit status code.

I was not the first with the idea of redirecting to /proc/1/fd/1, see https://github.com/phusion/baseimage-docker/issues/550

mentioned tools:
dma: https://github.com/corecode/dma
chrinic: https://joeyh.name/code/moreutils/
hint for any custom dma: cron calls sendmail like this: sendmail -- -i -FCronDaemon -B8BITMIME -oem username (username is the sending user)


Greenkeep build dependencies

For big fixes and performance improvements. This should also get rid of a console deprecation warning when building fusion apps.

!merge


Fix Gulp Minification Issue

@alexei  Found this issue today but I been using your repo for a long time, weird.

Thanks!


Dex IdP

Hi,
I am using a self-hosted Netbird setup with dex as IdP. The configuration is similar as described by @Thunderbottom in issue #898, which works good. The only difference is, that I use the BuiltIn (Local) connector instead of google.
However, I have noticed two things:

The login persists only in the current browser tab, if I open a new tab, I need to login again.
The Email address is not set for my user, which leads to the following error in the management log:
management/server/http/events_handler.go:84: failed to resolve email for initiator:<PHONE_NUMBER>

Any ideas how to solve this?

Hi, although we have moved away from Dex IdP to the Google login flow, I'll try to help you out here.

Can you tell me if alwaysShowLoginScreen here is set to false, if not, you will probably need to set that to make this work.
This I'm not really sure about, but it seems like you'll probably need to set the email ID in the configuration as specified here

I believe this is just a minor configuration issue.

Hi @Thunderbottom, really appreciate your reply!
Yes alwaysShowLoginScreen is set to false and the email is set in the staticPasswords section.
I have made some further observations:

I assume that this is related to how the OIDC flow is done with dex, since dex can not be configured in the IdpManagerConfig section of the management server. Therefore the dashboard takes care of it instead of the management server. The oidc.token will be set in the session storage, so if I open a new tab, the session storage of course is empty and a new login is required. I also have a second Netbird stack with zitadel as IdP. Zitadel sets some cookies, which allow to "rebuild" the session storage and automatically login again without entering the credentials.
The email claim is set correctly in the JWT. So I assume, that Netbird does not do any mapping with the email claim. It only uses the specifed claim in the httpConfig as UserID e.g.: "AuthUserIDClaim": "email"

Therefore I am not really sure, if this is a configuration issue.

Hm, then I suggest you check out if there's any similar issues on the Dex IdP repository, since that would be a better place to ask about this issue. In the meanwhile, I too shall try to figure out if there's anything I can find and update here.


getdents64 misses last 100 entries?

I am running Windows 10 1703 build 16188.1000 and it seems that getdents64 doesn't return all the entries, more specifically it seems to miss last 100 entries.
Self contained script to reproduce a problem follows. I build it while debugging Go project compilation issue, so it might not be an absolute minimal test case, but it reproduces error 100% of the time, so it might be a good start:
#!/bin/bash
set -ue

cat >test.go <<"EOF"

package main

import (
   "os"
   "fmt"
)

func main() {
   if err := os.RemoveAll("testdir"); err != nil {
        fmt.Printf("ERROR:%s\n", err)
   }
}
EOF

[[ -d go ]] || {
   echo "Downloading and unpacking go 1.8.1"
   curl -L -s https://storage.googleapis.com/golang/go1.8.1.linux-amd64.tar.gz | tar -xz
}

GO=./go/bin/go
export GOROOT=./go

go build test.go

rm -rf testdir
git clone https://go.googlesource.com/sys testdir
(cd testdir; git checkout 9ccfe848b9db8435a24c424abbc07a921adf1df5)

strace -s 1000 -o strace.log -f ./test || echo "os.RemoveAll() failed, trying again"
#./test
#echo "Works second time"

run it in empty dir on  a lxfs mount (I didn't check drvfs yet).
You'll see that it can't delete directory testdir/unix with an error
ERROR:remove testdir/unix: directory not empty

looking at what is left in testdir/unix, you'll see that exactly 100 files are left there. Script produces strace.log output with following lines among others:
10533 unlinkat(AT_FDCWD, "testdir/unix", AT_REMOVEDIR) = -1 ENOTEMPTY (Directory not empty)
10533 lstat("testdir/unix", {st_mode=S_IFDIR|0755, st_size=512, ...}) = 0
10533 openat(AT_FDCWD, "testdir/unix", O_RDONLY|O_CLOEXEC) = 4
10533 getdents64(4, /* 110 entries */, 4096) = 4070

so it returns 110 entries, but on a clean git clone at a given commit, testdir/unix directory has 210 entries
It is not reproducible with rm -rf though, probably because coreutils use getdents version of syscall, which seem to work fine

The second time around on getdents64(4, ...) something goes awry. strace interprets the buffer as containing 3 entries. Golang finds more, but not 100 more (which wouldn't fit in 127 bytes anyway). Possibly something was disturbed by #1769. Possibly this exact pattern hasn't tripped before. Full trace is here.
<...first call to getdents64() with 110 entries per OP>
[pid  1172] openat(AT_FDCWD, "testdir/unix", O_RDONLY|O_CLOEXEC) = 4
[pid  1172] getdents64(4, /* 110 entries */, 4096) = 4070
<...here is the next call to getdents64() on fd 4>
[pid  1172] getdents64(4, /* 3 entries */, 4096) = 127
[pid  1172] getdents64(4, /* 0 entries */, 4096) = 0
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/syscall_unix_gc.go", 0) = 0
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/syscall_unix_test.go", 0) = 0
[pid  1172] getdents64(4, /* 3 entries */, 4096) = 127
[pid  1172] getdents64(4, /* 0 entries */, 4096) = 0
<...more than 3 get subsequently unlinked but not 100>
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/types_darwin.go", 0) = 0
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/types_dragonfly.go", 0) = 0
<...>
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/ztypes_openbsd_386.go", 0) = 0
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/ztypes_openbsd_amd64.go", 0) = 0
[pid  1172] unlinkat(AT_FDCWD, "testdir/unix/ztypes_solaris_amd64.go", 0) = 0
[pid  1172] getdents64(4, /* 0 entries */, 4096) = 0
[pid  1172] close(4)                    = 0

@therealkenc , shouldn't second call just return 0 (EOF)? First call passes buffer 4096 entries long, surely whole response would fit there

No it doesn't work like that. For example here is the same test on Real Linux™. The first call coughs up 94 entries:
[pid 30810] unlinkat(AT_FDCWD, "testdir/unix", 0) = -1 EISDIR (Is a directory)
[pid 30810] unlinkat(AT_FDCWD, "testdir/unix", AT_REMOVEDIR) = -1 ENOTEMPTY (Directory not empty)
[pid 30810] lstat("testdir/unix", {st_mode=S_IFDIR|0777, st_size=12288, ...}) = 0
[pid 30810] openat(AT_FDCWD, "testdir/unix", O_RDONLY|O_CLOEXEC) = 4
[pid 30810] getdents64(4, /* 94 entries */, 4096) = 4088
[...]

The ABI doesn't make any guarantees about how the entries are packed, only that d_off points to the next entry.

@benhillis , @zadjii-msft this was still not labeled as a bug, which is concerning, were you able to reproduce it on your systems?

Just checked Build 16215, problem still present

I'll mark it as a bug so that the kernel team can triage.

Also adding @SvenGroot as FYI.

Not wanting to go on a ping storm, there are a number of other untriaged "real bugs" that are getting lost in the generally low signal to noise ratio. 1878, 2086, others.

It turns that that we can end up skipping entries if you unlink files in between calls to getdents(64). I'm working on fixes for both LxFs and DrvFs.

Fixed in 16237.

I can confirm that it is fixed now.