Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#775 b5a4202 Thanks @threepointone! - node compat fixes

pick up correct build from 'exports' condition defined in a dep's package.json
correctly import cloudflare: dependencies

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Speed up slow tests

These test cases are slow:

[ ] TestSyncIndices
[x] TestHarvestStudyVocabulary
[x] TestMetadataTreeView
[x] TestSyncMetadata

Deleted a lot of fixture data to speed up loading. Can't really do much for creating and destroying indices for tests. Those remain marked as "slow"


how to convert entire project in node js

I want to generate series of address for all types of cyptocurrencies listed in this project, in node js, can you please guide us for this

I won't write a guide but have a look at these libraries:
https://github.com/bitcoinjs/bip39
https://github.com/bitcoinjs/bitcoinjs-lib
https://github.com/bitcoinjs/bip44-constants
https://github.com/bitcoinjs/bip32
https://github.com/bitcoinjs/bech32
https://github.com/bitcoinjs/bip32-utils
and this file containing network parameters for all the extra networks
https://github.com/iancoleman/bip39/blob/master/src/js/bitcoinjs-extensions.js


Remove Monodraw

I chatted with the author of Monodraw about updating this cask as
it's currently broken. His preference was for its removal as its
shareware, and will cost money once out of beta. For the time being,
it can be downloaded (with email registration) at:
http://monodraw.helftone.com/
I think respecing the authors intentions is important, and have removed
the Monodraw cask with this commit.

Thanks @fanquake!

Thanks for the proactive response and diligence on this @scw!
However, from reading that twitter conversation, I think there may be a misunderstanding about the type of apps we include here. Cask is much more about automation than it is about distributing only Free Software. Even for commercial software, it's still incredibly valuable to be able to automate the installation.
We currently include 248 Casks with license :commercial, including big-name apps like 1Password, RubyMine, Kaleidoscope, Parallels Desktop, Sketch, VMware Fusion, etc etc etc etc.
Given my personal love for Monodraw the app, it would be sad for me to see it excluded from our project, since I know it makes automation/CLI obsessed users like me much less likely to use it. I'd imagine the overlap ASCII-diagram-lovers and Cask-users is non-trivial.
I'll jump into the twitter thread and point the Monodraw team to this update and see what they say. :+1:

Hi @phinze, great! Thanks for joining the conversation over on twitter. I did look around at the licensing stanza and tried to understand what their business model was before submitting this PR, but agree that if the authors are happy to have a model that lets them do licensing in a separate way than binary distribution, it's a win for everyone. I hope they accept your suggestion and do so, as an old-school FreeBSD user, every time I run an installer / use an opaque system to manage my software, I cringe a little.


[AutoPR keyvault/data-plane] Update Certificate Type description

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7762

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/6368


Not able to add product to Wishlist from product page.

Framework Version: 0.1.5

Framework Version:0.1.5
Fixed


Fixed register in navigation

Hey @Joe8Bit I'm Mike, I'll be helping with some of the issues with the website. I've fixed the register button in the nav and have it pointing in the right place now.

@MikeZTaylor merged, if you fancy checking out anything in the issues that'd be grand.


Replace usages of the try! macro with the question mark operator

Can you update this PR so it will merge cleanly please? Merging https://github.com/borntyping/rust-psutil/pull/41 has introduced some conflicts.

Aye aye! :)


NPM:  No matching version found for<EMAIL_ADDRESS>

Hey Im running into an issue with your package versions on an npm ci. We are currently installed @2.19.3 but on a clean install we're getting a No matching version found for<EMAIL_ADDRESS>error. Also, in the npm docs you have 2.19.3 attached to the latest but when I install react-color@latest I end up with "react-color": "^0.0.0-master.12398",. Do you have any fixes for this?

Actually this looks like an issue on my end.


Installation failed on Ubuntu 14.04 for Vagrant 1.8.1

Installation failed on Ubuntu 14.04 for Vagrant 1.8.1
==> rancher-01: Machine booted and ready!
No installation found.
The guest's platform ("linux") is currently not supported, will try generic Linux method...
Downloading VirtualBox Guest Additions ISO from http://download.virtualbox.org/virtualbox/4.3.36/VBoxGuestAdditions_4.3.36.iso
Copy iso file /home/joepython/.vagrant.d/tmp/VBoxGuestAdditions_4.3.36.iso into the box /tmp/VBoxGuestAdditions.iso
mount: mounting ��� on /mnt failed: Invalid argument
Cleaning up downloaded VirtualBox Guest Additions ISO...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mount /tmp/VBoxGuestAdditions.iso -o loop /mnt

Stdout from the command:

Stderr from the command:

mount: mounting ��� on /mnt failed: Invalid argument

We're no longer supporting our vagrant repo and have moved to supporting docker-machine to start up RancherOS. As a result, we will be closing the issues tab in the repo.
Learn how easy it is to use RancherOS with docker-machine.


New SaveAs option: Select multiple file types at once

@Robin Bloemberg (Von Gahlen)
https://community.sw.siemens.com/s/question/0D54O000089PMu6SAG/solid-edge-housekeeper-v20236-released

Maybe next time.


Comment out consistently failing tests.

As per our discussion in Slack, this PR comments out tests that are consistently failing on develop. We want to get to a place where we trust our testing strategy. That starts by removing tests that always fail on develop. Removing these will make a failed check on develop mean something.

Thanks for grabbing this! What do you think about deleting it altogether? itll still be available in the git history if/when we need to the code back.

Great call. Updating the branch now


UI and Functionality Enhancements Across Multiple Pages

Expected Behavior
The application should reflect the following updates:

The floating menu should be moved to stick to the bottom of the page.
A voting period text should be added to the voting page, with a modal pop-up providing additional information when the user clicks the information button.
An upload function should be added to the edit DAO page.
A top banner should be introduced on the discover page.
Individual date and time should be displayed for each entry in the points history.

Current Behavior
These proposed changes do not currently exist within the application, leading to a less cohesive user experience.
Specifications

As a user,
I want an intuitive and consistent UI,
so that my experience while navigating and interacting with the platform is seamless and informative.

Acceptance Criteria

[ ] The floating menu is relocated to the bottom of the page and behaves consistently across all screens.
[ ] A voting period text is present on the voting page, with a functional information button that triggers a modal pop-up from the bottom.
[ ] The edit DAO page includes a fully functional upload feature.
[ ] The discover page features a prominently displayed top banner.
[ ] Points history entries are accompanied by their respective individual date and time.

Features

Floating Menu Update: Ensure the menu sticks to the bottom and is responsive.
Voting Page Enhancement: Implement functionality for the information button to trigger a modal.
Edit DAO Page: Integrate an upload feature allowing for file submissions.
Discover Page: Design and implement a top banner.
Points History: Display date and time for each point entry.

Development Tasks

[ ] Refactor the floating menu to stick to the bottom.
[ ] Add the voting period text and implement the modal functionality on the voting page.
[ ] Develop the upload function within the edit DAO page.
[ ] Design and implement the top banner on the discover page.
[ ] Update points history to include individual date and time entries.

Dependencies
Check for any existing frameworks or libraries that might need updates or integration for new features such as the modal or upload functionality.
Additional Context
Ensure designs are consistent with the existing UI/UX guidelines. Consider cross-browser testing to maintain compatibility.
References

Existing design guidelines and UX documentation.
Previous issues related to UI changes for reference.

Feature deployed in v2.9.0


[CON-243] systemMessage not effective for claude 3

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS:*
- Continue:*
- IDE:*

Description
It seems we're not sending the system message to Claude 3. Need to double check that this is actually the case and if so make the quick fix
To reproduce
No response
Log output
No response
CON-243

When will this bug be fixed? systemMessage is very important to me

This is now resolved!


Build 08-wasm without cgo option

Summary
Similarly to x/wasm add a NewKeeper constructor func for 08-wasm which panics when used. This should be guarded by the: //go:build !cgo build flags.
Additionally, we can add //go:build csgo for the keeper file which already exists.

https://github.com/CosmWasm/wasmd/issues/1129
https://github.com/CosmWasm/wasmd/pull/1166

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

This should allow users to consume types without needing the entire CGO stack for wasmvm.

We have chosen to use a separate build tag ibcwasm_novm instead of completely disabling cgo. It's possible that a binary may need cgo dependencies as well as wanting 08-wasm types only available to them

Renamed the issue to reflect the desired behaviour


added close connection method, so the API is similar to the official one

Related issue: https://github.com/motherduckdb/duckdb-async/issues/25

Thanks for the PR. I'd already made the changes in a branch to address this for #25.  Now that 0.10.0 is published, I've merged that branch into main, and published duckdb-async on npm as 0.10.0.


minor clarification I missed in #145 (why should you declare Win10 compat?)

In my recent change #145 , I forgot to explain on one doc page why you'd want to declare Windows 10 compatibility. This fixes that.

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@metathinker : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Support/Feature Request: Allow empty values in picker

Hi!
Love the component, very simple but effective. I use the component to allow users to pick opening hours for managed venues. It would be great if the component allowed for an empty value in the drop down picker, as far as I can tell, there is no way to do this with the component at present state (please correct me if I'm wrong! 😄 )
For now, I have added a "Closed" boolean to each day of the week, it will do the job.

Hi @atomicacorn, sorry for the late.
My friend, Pete, made this project but sadly he passed away so he won't be able to make any updates and I'm not really in the position to do that either.
Would you like to have a go at a PR? I'll be happy to review it.


Ordinals.com possible performance regressions

Request to this sat page took almost 9 seconds - https://ordinals.com/sat/736753070579047

The site has felt laggy overall recently.

There are a few things we can do here:

We're making a bunch of separate calls into the index. This creates multiple read transactions and opens tables multiple times. We could refactor Server::sat to make one call into the index.
This winds up fetching a block, but only needs the header. We could add a block height to block header table, which should be small, which would let us only fetch a header.

The server is pretty fast now.


Move the unitycatalog-ai directory to a new "ai" directory

PR Checklist

[X] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes
This migrates unitycatalog-ai to the ai directory for simplification and discoverability and ensures that namespace references are correct for the recent package changes.

@tdas @dennyglee Here's the directory move PR :)

approved!


nbtscanner: refactor

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361407

x86_64-linux

:white_check_mark: 1 package built:

nbtscanner

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361407

x86_64-linux

:white_check_mark: 1 package built:

nbtscanner


Add Remote desktop section

@quseleba : Thanks for your contribution! The author(s) have been notified to review your proposed change. @msftman


Improve the istructions in READEME file

I would really appreciate some constructive feedback here. At which points do you think information is missing? I think there is a clear step-by-step guide. Where do you struggle?

Yes, I appreciate the instructions are quite clear except I thought configuration part instructions could be more elaborated, I couldn't push my branch and raise PR.
Anyway thanks for this amazing actions 🤩

I think you should either provide a clear list of things you would like to have explained in more detail (which concrete piece of information is missing) or ideally provide a PR. "could be more elaborated" is way too fuzzy...


PFRelation

Have you been able to get this working if one of the PFObjects has a PFRelation associated with it? I wrote a simple PFRelation+NSCoding category to serialize the targetClass property, but when the -initWithCoder: tries to deserialize the PFRelation and set it I get an exception:
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'PFObject values may not have class: PFRelation'

Hi guys, anyone resolve this problem I also got this
Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'PFObject values may not have class: PFRelation'
don't even know where this problem came from~~

I'm having the same issue. @zake1989  have you found a solution yet?


chore: Release v1.0.0

close: #4656
PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

wrong target branch


Fixed server doc

Was pointing to controller before
Also removed slugs

Thanks @ColmBhandal
EDIT: let's wait for the CI to be green, I re-ran the jobs.

Weird. CI still failing.

Closing since PR doesn't work with forks.


🐛 broken explorer link

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #7684
[ ] Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[ ] My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at fcce151
This pull request enhances the NeoNftCard component and its subcomponents to support custom card link URLs and stacked NFTs. It also introduces a new type NeoNFT to unify the token data structure and simplify the code. It affects the files NeoNftCard.vue, NFTMediaInfo.vue, NFTMediaInfoStacked.vue, types.ts, and ItemsGridImageTokenEntity.vue.

🤖 Generated by Copilot at fcce151

Sing, O Muse, of the skillful coder who wrought
Many a change to the NeoNftCard component,
Adding new props and types to shape the token data,
And customizing the link to each NFT's content.

@daiagi this alignment was solved in the past ?

this alignment was solved in the past ?

Not thoroughly enough.no
I thought I did but the regular cards change height with screen size


Question about Paginator.coffee

This is in regards to the example blog that comes with Wintersmith.
I'm able to discern how paginator.coffee generates the index and subsequent pages. However, I don't understand where/when/how the /articles folder is rendered and placed in the /build folder (aka the individual article pages, not the article list pages). If anyone has a clue to share, please do. I've sifted through the code several times but nothing has caught my eye.

Cleaning up old issues, feel free to create a new one if this still is a problem.


fix date-picker.plugin locale defaulting to de

1. Why is this change necessary?
date-picker.plugin defaults to de. it is supposed to default to default aka en
2. What does this change do, exactly?
this.options.locale.substring(0,2) returns de when locale is default.
By checking if locale is not "default" and then substringing, we get the intended behavior
3. Describe each step to reproduce the issue or behaviour.
Assign data-date-picker to an input field
4. Please link to the relevant issues (if any).
NEXT-22354
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-22354
Please use this issue to track the state of your pull request.

We have some concerns that this is a soft-break for developers who don't explicitly set a locale as they might not expect the default to change. Could you put your change behind a feature flag? This way it will be the default behavior when the next major release comes around and breaks are to be expected:
import Feature from 'src/helper/feature.helper';

if (Feature.isActive('v<IP_ADDRESS>')) {
    // new behavior
} else {
    // old behavior
}

Hey,
I will close this ticket as it's inactive for a while. Feel free to create a new pull request when you added the missing parts


[HOLD for payment 2023-03-09] Keyboard is visible for a brief moment on request/send money page after getting back from currency search page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app in android
Open any report
Click on plus
Click on Request money/ send money/ split bill
Click on currency
On currency search page, when keyboard is displayed for search, click on 'X' to close and get back to previous page

Expected Result:
Keyboard should close first and then app should get back to previous request/send money screen
Actual Result:
App navigates to request/send money screen first and then closes the keyboard (works properly on mWeb android chrome)
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native

Version Number: 1.2.70-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/218354150-0006248d-a0c9-4717-b341-8147d7320f82.mp4
https://user-images.githubusercontent.com/43996225/218354181-6d0eeffe-3009-4383-ade2-88fe0749b6b9.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676043921470679
View all open jobs on GitHub

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hello, I'm Nicolay from Callstack and I'm interested in taking and analysing this issue to work on a fix for it.

Proposal
Please re-state the problem that we are trying to solve in this issue.
App doesn't automatically hide keyboard on android - while moving between screens.
What is the root cause of that problem?
The main issue - when user goes back - no events fires to app to dismiss keyboard (if keyboard has been already opened)
What changes do you think we should make in order to solve the problem?
The main change should be:

using new event handler to detect when user wants to live current screen.
when event triggers - needs to close keyboard (if keyboard has been already opened)
Example:

        this.beforeRemoveSubscription = this.props.navigation.addListener('beforeRemove', () => {
            if (this.props.isKeyboardShown) {
                Keyboard.dismiss();
            }
        });

What alternative solutions did you explore?
We can solve issue in 2 ways - globally and locally.
For global one - we can add subscription to event beforeremove inside ScreenWrapper class and add in compose withKeyboardState HOC - which will guaranty that keyboard will be closed on any screen which was wrapped in  ScreenWrapper
For local one - doing the same steps - but only under IOUCurrencySelection class

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

We are trying to avoid making changes related to react-navigation now as we are reworking this. I think we could try this solution locally @narefyev91 and confirm it works well there on all the native platforms.
Can you please create a PR and fill in the template with testing done on all the platforms? Thank you very much!

@narefyev91, @mateocole, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

PR is being reviewed.

PR is going to be merged soon

Merged

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.77-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15205

If no regressions arise, payment will be issued on 2023-03-09. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@narefyev91 / @0xmiroslav] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@mateocole] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Okay, here is an upwork post for everyone to apply to for payment:
https://www.upwork.com/jobs/~01115b5c443336b31a

This is only going to be:

250 for @dhanashree-sawant
1000 for @0xmiroslav

@narefyev91 is handled differently

Hi @mountiny, thanks I have applied to the upwork job.

Okay contracts sent!

Alright payments sent

I believe i reported a similar issue a few months ago and we ended up resolving a dupe issue while original issue was on hold https://github.com/Expensify/App/issues/13449. So i think i am also eligible for reporting bonus here.

Ltts keep it in that issue, even on hold I the reporting bonus should be paid I believe once we will put it off hold

Jumping in here. Doesn't the fix for this issue also fix https://github.com/Expensify/App/issues/13449? In fact, I've tested that issue and I'm no longer able to reproduce it, so I'm pretty certain the answer is yes.

Assuming we all agree on that last comment, then I agree that @syedsaroshfarrukhdot should be eligible for a reporting bonus and we should close the related issue. I'm happy to do it there, though let's first ensure that we agree on the next steps in this issue before I move forward.

Checking, seems like this is the case. I think we can close and pay @syedsaroshfarrukhdot


Android 7.0 vs 7.1 does not work

How can I help you?

can u give some log please?

ya this is the issue
java.lang.UnsatisfiedLinkError: dlopen failed: /data/app/bestvideoplayer.com.bestvideoplayer-2/lib/x86/libijkffmpeg.so: has text relocations

Use giraffeplayer2 by tcking from Giraffeplayer2 with supported ABI's


Change AbstractFileReference>>#gtSaveContents: to not leave behind .backup files

Change AbstractFileReference>>#gtSaveContents: to not leave behind .backup files
It is a good idea to first write to a new file and switch over when that is successful

The new implementation, like the old implementation loses the original creation timestamp since the file is deleted before being renamed (new implementation) or written (old implementation)

Tested on Windows


bool flag wants a bool value as well

$ magictune.py --dry-run run
usage: magictune.py [-h] [--dry-run DRY_RUN]
                    [--hide-low-volume HIDE_LOW_VOLUME] [--sleep SECONDS]
                    {run,balance,asset-pairs}
magictune.py: error: argument --dry-run: Boolean value expected.

should specifying dry-run not be enough to consider it true without having to specify true as well(--dry-run true)?

It's not a bad idea. Would you like to implement this change?

not in the slightest, i am python impaired

@tzapu It can be implemented by setting action='store_true' in the add_argument() function.


syncthing-discovery: 1.27.4 -> 1.27.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/syncthing/syncthing/releases.
meta.description for syncthing-discovery is: Open Source Continuous File Synchronization
meta.homepage for syncthing-discovery is: https://syncthing.net/
meta.changelog for syncthing-discovery is: https://github.com/syncthing/syncthing/releases/tag/v1.27.5
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.27.5 with grep in /nix/store/swjw9g6kd6svg912ykbfkv5zi4kddqp0-syncthing-discovery-1.27.5
found 1.27.5 in filename of file in /nix/store/swjw9g6kd6svg912ykbfkv5zi4kddqp0-syncthing-discovery-1.27.5

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
qsyncthingtray
syncthing
syncthing-discovery
syncthing-relay
syncthingtray
syncthingtray-minimal

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/swjw9g6kd6svg912ykbfkv5zi4kddqp0-syncthing-discovery-1.27.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A syncthing-discovery https://github.com/r-ryantm/nixpkgs/archive/d9596f995ea1961ff646c19b0f8b6240330470f6.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d9596f995ea1961ff646c19b0f8b6240330470f6#syncthing-discovery

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/swjw9g6kd6svg912ykbfkv5zi4kddqp0-syncthing-discovery-1.27.5
ls -la /nix/store/swjw9g6kd6svg912ykbfkv5zi4kddqp0-syncthing-discovery-1.27.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

6 packages built:

qsyncthingtray
syncthing
syncthing-discovery
syncthing-relay
syncthingtray
syncthingtray-minimal

Maintainer pings
cc @jokogr @peterhoeg @andrew-d for testing.

Result of nixpkgs-review pr 300983 run on x86_64-linux 1

6 packages built:

qsyncthingtray
syncthing
syncthing-discovery
syncthing-relay
syncthingtray
syncthingtray-minimal


add pyserini onnx encoder support

Added support for Pyserini usage of ONNX on-the-fly query encoder
Related PR

Codecov Report
Patch coverage: 2.22% and project coverage change: -0.13 :warning:

Comparison is base (4aeb3ef) 59.17% compared to head (a015837) 59.05%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2113      +/-   ##
============================================
- Coverage     59.17%   59.05%   -0.13%
  Complexity     1200     1200
============================================
  Files           194      194
  Lines         11352    11377      +25
  Branches       1488     1488
============================================
+ Hits           6718     6719       +1
- Misses         4146     4170      +24
  Partials        488      488

Impacted Files
Coverage Δ

...nserini/analysis/HuggingFaceTokenizerAnalyzer.java
77.77% <ø> (ø)

...main/java/io/anserini/eval/RelevanceJudgments.java
56.94% <ø> (ø)

...c/main/java/io/anserini/search/SimpleSearcher.java
69.66% <ø> (ø)

...in/java/io/anserini/search/query/QueryEncoder.java
0.00% <ø> (ø)

...uery/SpladePlusPlusEnsembleDistilQueryEncoder.java
0.00% <0.00%> (ø)

...ch/query/SpladePlusPlusSelfDistilQueryEncoder.java
0.00% <0.00%> (ø)

.../io/anserini/search/query/UniCoilQueryEncoder.java
0.00% <0.00%> (ø)

...va/io/anserini/search/topicreader/TopicReader.java
66.29% <ø> (ø)

.../java/io/anserini/search/SimpleImpactSearcher.java
71.42% <8.33%> (-7.30%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Can we have some test cases? At the very least, let's not have coverage go down?

hey @ArthurChen189 I just got this issue:
Results :

Failed tests:   testOnnxEncoder(io.anserini.search.SimpleImpactSearcherTest): expected:<3.053449> but was:<3.05345>

Tests run: 675, Failures: 1, Errors: 0, Skipped: 0

This is on my M1 Mac, so floating point tolerance issues... should we adjust precision?


api/ngx_stream_lua_api.h should export ngx_stream_lua_request_t

Hi,
I think https://github.com/openresty/stream-lua-nginx-module/blob/master/src/api/ngx_stream_lua_api.h is not usable currently.
Since ngx_stream_lua_request_t defined in below, are not exported, including ngx_stream_lua_api.h solely makes compile failed.
https://github.com/openresty/stream-lua-nginx-module/blob/e3eb228c08e5bab30404d5d715bd9b5a545f68a8/src/ngx_stream_lua_request.h#L22-L35
Currently, I added #include "../ngx_stream_lua_request.h" to ngx_stream_lua_api.h for workaround, but only exporting ngx_stream_lua_request_t will be more suitable.
I want to submit pull request.  Is moving ngx_stream_lua_request_t to ngx_stream_lua_api.h and include ngx_stream_lua_api.h from ngx_stream_lua_request.h suitable?

i have met same problem when i build kong with openresty-build-tools.
../ngx_stream_lua-0.0.7/src/api/ngx_stream_lua_api.h:49:1: error: unknown type name 'ngx_stream_lua_request_t'; did you mean 'ngx_stream_lua_value_t'?
 ngx_stream_lua_request_t *ngx_stream_lua_get_request(lua_State *L);

anyone can resolve it?

I have the same problem :(

up. same problem too

@doujiang24
Maybe we can delete ngx_stream_lua_request_t *ngx_stream_lua_get_request(lua_State *L); from the api.h? Since nobody could use it actually.

@spacewander Agreed.

@spacewander Agreed, let's do it.

According to my memory, this module will update when ngx_meta_lua_module release, and I remember the newest ngx_meta_lua_module has fix this problem?


Add interval now line

I have seen in other calendars, the ability to show an interval now line on the today's date representing the current time which reactivity moves on each minute past.
I would love the have a similar feature in the qcalendar. It's already awesome but this, for me is the cherry on top of features.
vue-cal and daykeep-calendar-quasar has similar features, vue-cal's line doesn't reactivity change where as daykeep-calendar-quasar does.
The interval now line is usually red but an added feature, have the ability to change its color.

Great idea! Thanks! I have a heap of other work I need to do before this is implemented. There will likely be a new QCalendar release before this is done. But, don't worry, it's on my list not. Thanks for the suggestion! :heart:

@iamgmd I have added a new slot that lets you do this in devland. I have also included two examples of how to do this.

Fix will be available in v1.0.8


Prl 899 welsh document translation

JIRA link (if applicable)
PRL-899
Change description
Add template name for dogmosis
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Closing as merged into master.


Dragging an event in the RTL month view calendar

Do you want to request a feature or report a bug?
A bug
What's the current behavior?
When dragging an event in the RTL  month view calendar, the calendar gets confused and the event goes in the opposite direction
My browser is google chrome,
React big calendar version 0.28.5
I found this, which fully describes my issue, but for me, it keeps happening
https://github.com/jquense/react-big-calendar/pull/172

What's the expected behavior?
While dragging, I expect the event to hover over the date which I am selecting

I released the same issue, I made a 2 days research to control it manually, but no solutions unfortunately, so I removed the drag and drop for the moment.

I released the same issue, I made a 2 days research to control it manually, but no solutions unfortunately, so I removed the drag and drop for the moment.

For me, the drag and drop is crucial, so I made the calendar LTR while my whole website is RTL, this so very unfortunate.


Add other asset types for pricing

USDC, USDT, other stablecoins?

Just for the record from our conversation:
Option to select and use price in native tokens of Algo network - For example USDC and others tokens running on Algo network (It's a question of each seller's preference which he wants to use if platform enabled payments via that token.)

https://github.com/barnjamin/rareaf/tree/price-tokens addressing in this branch


Installation on Ubuntu 20.04

How do I install it on Ubuntu 20.04?

Hi @jingxixu , You can download the binary from the release page. Or use cargo to install it from source: cargo install --locked csview


Remove duplicated HTTP filters

The current per-route filter implementation creates a filter in the HCM filter chain for each ir.HTTPRoute. This can result in duplicated HTTP filters with the same configuration and cause a huge Envoy configuration file.  To optimize this, we should only create one filter for each unique ODIC/ExtAuth/BaiscAuth configuration and reuse it across all applicable ir.HTTPRoute.
Thanks @guydc for identifying this during the ExtAuth PR review.

should we close this?

this may need to be done for all per route filters :)


Feat/document public classes

Codecov Report

Merging #23 (7d645a6) into main (fbdcec6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   90.16%   90.13%   -0.03%
==========================================
  Files          24       24
  Lines         437      436       -1
==========================================
- Hits          394      393       -1
  Misses         43       43

Impacted Files
Coverage Δ

lib/src/common/logger/common_logger.dart
0.00% <ø> (ø)

lib/src/core/rpc/impl/operations_monitor.dart
100.00% <ø> (ø)

lib/src/crypto/impl/crypto_error.dart
70.00% <ø> (ø)

lib/src/signature/impl/signature.dart
100.00% <ø> (ø)

lib/src/core/client/impl/tezart_client.dart
100.00% <100.00%> (ø)

lib/src/core/client/impl/tezart_node_error.dart
77.27% <100.00%> (-0.99%)
:arrow_down:

lib/src/crypto/impl/encode_decode.dart
100.00% <100.00%> (ø)

lib/src/keystore/impl/keystore.dart
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdcec6...7d645a6. Read the comment docs.


Localized Zoom (in web application)

Is your feature request related to a problem?
I would like to be able to zoom into the application: increasing the size of all elements proportionally while the gui stays the same.
Describe the solution you'd like
Web pages can be zoomed in without changing the layout of the page. I would like the same behaviour in egui.
Describe alternatives you've considered
I first thought of reacting to zoom requests by changing the font size of all types at the same time... but that does not solve the issue as there might be other elements (for example images) in the app.
I imagine that the solution may involve the draw textured triangles engine (which I have no clue about). Together with introducing "top-level" scrolls (vertical and horizontal scrolls outside the gui).
Additional context
This is particularly useful on small screen devices.
egui allows to code complex applications... but using these in a mobile phone is a bit tricky as you can not "travel" across the screen to different windows: it is like if you HAVE to see the whole application all the time.
This is also a problem for big-screen devices. In the online demo, you can easily make some parts of the app inaccessible by increasing the font size (steps to reproduce: go to the online demo->Backend->Settings->Fonts->Set Body to max). Allowing all windows to scroll is not a solution, as it changes the gui.
This might be related to accessibility issue #167
There was some previous question in #261
For example, while doing this issue, i can zoom in the website and everything changes proportionally.

Normal mode

After zooming in
Note the relationship of the element within the webpage did not change, but the relationship with the time (from Windows, outside the page) did change. Also, top-level scrolls were introduced.

Note that simply controlling pixels_per_point is not a solution: when pixels_per_point is increased too much,

Windows get re-arranged
Panels are superposed
Even if the whole app is located in a ScrollArea, scrolling will not get activated.

If you visit https://emilk.github.io/egui/ on a big-screen device you can actually pich-to-zoom outside the egui canvas and get the effect you want. The problem is that any pinching inside the egui canvas is swallowed by egui, and so the browser doesn't zoom. The reason is that some egui widgets (like the plot) wants to listen for zoom events (you want to pinch-to-zoom a egui plot, not the whole egui application).
The solution is to have egui_web only swallow the zoom events if there is an egui widget underneath that is interested in the zoom event, but otherwise (normally) pass them on to the web browser.
One way to approach this is to add an egui::Sense for zoom (and perhaps also for scroll) so that egui can tell if a widget is interested in it (and report to egui_web).

Thank you for the answer!
I think both your solution and approach sound just perfect!

One way to approach this is to add an egui::Sense for zoom (and perhaps also for scroll) so that egui can tell if a widget is interested in it (and report to egui_web).

I would add that Panels and Window should also have a sense method :) (if I understand correctly, they are not a "widget").


Adding more events to the list!

Google season of docs- Takes palce in June
Jenkins UI-UX Hackfest- Takes place in May

Thank You @garimasingh128

Can you please add Psoc as well?

Do I need to add it in the README only?

if you like to add in the website then https://github.com/Catalyst-IN/OpenSourceEvents-Frontend this is the repo for the website.

Both done @garimasingh128

Thank You :p


tutanota-desktop: 220.240319.1 -> 220.240321.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/tutanota-desktop/versions.
meta.description for tutanota-desktop is: Tuta official desktop client
meta.homepage for tutanota-desktop is: https://tuta.com/
meta.changelog for tutanota-desktop is: https://github.com/tutao/tutanota/releases/tag/tutanota-desktop-release-220.240321.0
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 220.240321.0 with grep in /nix/store/4vpwmvmfxn9isz8hij6393cg8yhwfa1n-tutanota-desktop-220.240321.0
found 220.240321.0 in filename of file in /nix/store/4vpwmvmfxn9isz8hij6393cg8yhwfa1n-tutanota-desktop-220.240321.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
tutanota-desktop

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4vpwmvmfxn9isz8hij6393cg8yhwfa1n-tutanota-desktop-220.240321.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tutanota-desktop https://github.com/r-ryantm/nixpkgs/archive/75bcf9ed70967c57cfe429417c2c0aa6df5fd8fe.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/75bcf9ed70967c57cfe429417c2c0aa6df5fd8fe#tutanota-desktop

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4vpwmvmfxn9isz8hij6393cg8yhwfa1n-tutanota-desktop-220.240321.0
ls -la /nix/store/4vpwmvmfxn9isz8hij6393cg8yhwfa1n-tutanota-desktop-220.240321.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

tutanota-desktop

Maintainer pings
cc @WolfangAukang for testing.

Result of nixpkgs-review pr 301190 run on x86_64-linux 1

1 package built:

tutanota-desktop


FloatingActionButton Overlap

Hey guys. I am trying to achieve the following layout: Single activity with bottom bar, having 4 different fragments for each tab, while only one of the fragments has a floating action button above the bottom bar.
The fragments are scrollable and the bottom bar should be shyAttached.
I tried playing around with different layouts but failed, therefore I need your help.
Thank you!

How are you implementing the fragments?
through xml or java code?
did you try it this way?
activity______
mBottomBar = BottomBar.attachShy((CoordinatorLayout) findViewById(R.id.myCoordinator),
findViewById(R.id.myScrollingContent), savedInstanceState);
xml_______
<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/myCoordinator"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fitsSystemWindows="true">
<android.support.v4.widget.NestedScrollView
    android:id="@+id/myScrollingContent"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <!-- Your loooong scrolling content here -->

</android.support.v4.widget.NestedScrollView>

</android.support.design.widget.CoordinatorLayout>

@Xstar97 where in your example is the Floating Action Button placed and attached to?

I also have the same issue.
Bottombar and FAB both are direct child of CoordinatorLayout.
The floating action button is overlapping the bottombar due to a fixed "layout_marginBottom" attribute value. Please help.

has anyone found a solution yet? got the same problem

Does the behavior of the FAB correctly depend on the BottomBar-type?


Could not locate compile command for storyboard

Hi,
I've been struggling for last few days with storyboard hot reloading. I have an older test project where it works just fine, but now with a newly created one with Xcode 13.3 and only HotReloading added by SPM I can't make it work, always getting that error "Could not locate compile command for storyboard"
That generated command.sh doesn't give any output (you should also give that file +x permission when automatically created).
I thought that Xcode project format could be the reason so I've tried setting it to an older 9.3 compatible, but that didn't help also. I can see that no optimization is turned on (completely new test project, just HotReloading added, linker flags too, tried with and without that run script that starts daemon, injecting from code works ok) and the path should not be a problem, I guess. Do you have any suggestions how to investigate what could be the issue?

Hi, I hadn't check storyboard injection with the newish standalone version of injection and have pushed a commit c08ce66e4b1b6456c93ebf2e4829da4d52842d19 that caters for it. Can you sync to this version and try again please?

Yep, now it works, thanks :)
In the meantime, I tried the old way by installing InjectionIII app (latest Github version) and it worked too.

Excellent!


Fix building on Java 16

Gradle settings need to be changed due to upstream fabric changes

Whoops, I made this PR to the wrong branch


Add ability to specify Kustomize's options

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1039
Does this PR introduce a user-facing change?:

Add ability to specify Kustomize's options

/cc @nakabonne


Adding new pairs to binance

Note: for support questions, please join our Discord server

I'm submitting a ...
[ ] bug report
[x ] feature request
[ ] question about the decisions made in the repository

Action taken (what you did)
Trying to update according all the help given

Expected result (what you hoped would happen)
i would like to add

41
BLZ/BNB
0.01
BLZ
0.00001
BNB
1
BNB

42
AE/BNB
0.01
AE
0.00001
BNB
1
BNB

43
RPX/BNB
0.01
RPX
0.00001
BNB
1
BNB

44
NCASH/BNB
0.01
NCASH
0.00001
BNB
1
BNB

45
POA/BNB
0.01
POA
0.00001
BNB
1
BNB

46
ZIL/BNB
0.01
ZIL
0.00001
BNB
1
BNB

47
ONT/BNB
0.01
ONT
0.00001
BNB
1
BNB

added them to >exchanges>binance.

Actual result (unexpected outcome)
ive got an all error when running an binance market

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc)

can someone give me a step by step walktrough on how to do it? or can some update the exchange>binance files

You doing it in /exchanges/binance-markets.json file
First add asset in list like:
"ONT",
After that add somewhere down:
{
"pair": [
"BNB",
"ONT"
],
"minimalOrder": {
"amount": 0.01,
"price": 0.00001,
"order": 1
}
},
After that restart gekko
GL

Geez, i forgot the last , pfffffff. Thanks bud for you assistance. Do you also know a thing or 2 about stratagies? i want to set up my own strategy but need some help


Jest is unable to mock modules with names containing .js

🐛 Bug Report
Opening a bug to track what appears to be a known issue, according to the discussion in #6420 .
For my use case, the issue is occurring due to attempting to mock a module named 'data-api.js-core'. I would try to resolve this by creating a module alias; however, my team is trying to avoid ejecting from create-react-app (which has no support for external module aliases unless I'm mistaken).
To Reproduce
Steps to reproduce the behavior:

Create a React application via create-react-app (http://create-react-app.dev/)
Install a dependency that has .js in the module name (e.g. https://github.com/pixijs/pixi.js)
Add a usage of the dependency to the application and a corresponding unit test
Attempt to define a Jest mock for the dependency
Execute yarn test

Expected behavior
The test is executed.
Actual behavior
The test output shows the following:
  ● Test suite failed to run

    Cannot find module 'type' from 'index.js'

    However, Jest was able to find:
    	'./data-api.js'

    You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['web.js', 'js', 'web.ts', 'ts', 'web.tsx', 'tsx', 'json', 'web.jsx', 'jsx', 'node'].

    See https://jestjs.io/docs/en/configuration#modulefileextensions-array-string

Furthermore, create-react-app does not support specification of moduleFileExtensions in the Jest configuration.
These options in your package.json Jest configuration are not currently supported by Create React App:

  • moduleFileExtensions

envinfo
  System:
    OS: macOS 10.15.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Binaries:
    Node: 10.16.0 - ~/.nvm/versions/node/v10.16.0/bin/node
    Yarn: 1.22.4 - ~/.yarn/bin/yarn
    npm: 6.13.7 - ~/.nvm/versions/node/v10.16.0/bin/npm

I've just learned the 'data-api.js-core' module name and API are modeled after analytics.js-core from Segment. Hopefully this helps troubleshoot.

Just discovered a workaround for my use case. Renaming all instances of 'data-api.js-core' to 'data-api.js-core/dist/data-api' (library contains /dist/data-api.js) for imports/mocks appears to resolve the issue.
Going to leave this bug open because it sounds like this is still a bug in Jest based on #6420 . Feel free to close if that's not the case!

Hey @ghaagsma, I tried reproducing this with a view to submitting a PR to fix.
// component using a dep with .js in it
import * as PIXI from 'pixi.js-legacy';

const Mini = () => {
  const app = new PIXI.Application({ width: 256, height: 256 });

  return app.view;
};

export default Mini;

// and a test
import { render } from '@testing-library/react';
import React from 'react';
import * as PIXI from 'pixi.js-legacy';
import Mini from '.';

jest.mock('pixi.js-legacy', () => {
  return {
    Application: jest.fn().mockImplementation(() => {
      return {
        view:
I am the mocked view

      };
    })
  };
});

describe('breaking jest imports repro', () => {
  it('should not run this test at all', () => {
    const { container } = render(<Mini />);

    expect(PIXI.Application).toHaveBeenCalled();
    expect(container).toMatchInlineSnapshot(`

          I am the mocked view

    `);
  });
});

The test ran okay:
 PASS  src/components/Mini/index.test.jsx
  breaking jest imports repro
    ✓ should not run this test at all (16ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   1 passed, 1 total
Time:        2.166s
Ran all test suites related to changed files.

Watch Usage: Press w to show more.

Are you able to reproduce or even drop some snippets for me to do some digging?
Cheers!


embedding more than one python file

Just an idea.
Currently, I have one python file that I write to interface w/ ocaml (let's call it itf.py).
I.e. the ocaml side only calls functions defined in this file.
However, this said file may rely on other python files in the same directory to implement
complex things.
It would be nice if we can embed in some way those other files too.
Currently, I had to include by hand the other files into itf.py.
But, I hate to do this, I just duplicated code, if there are some bugs, I will need to correct in two places from now on.
Do you understand my need?
Would it be doable?
I ~could~ (should?) create a python library containing all those other files.
But then, the ocaml exe will rely on this library to be installed at runtime.
In terms of deployment, it would be nicer is the ocaml exe can embed everything needed (i.e. itf.py plus
all its required python files dependencies).

This is a sort of hacky solution, but do you know about stickytape?  It is a script that allows you to "rollup" all the imported modules of your python program into a single mega script.  Then you (I think) should probably be able to use the mega-script as your interface instead of your original interface.

Check this example out: https://github.com/mooreryan/pyml_bindgen_stickytape_example
The executable that it generates is movable...it works on my computer from any directory, and on a different server, without having to mess around with the PYTHONPATH or anything.

Ok, very interesting.
No, I did not know about this.
It might do the trick.
On Sun, May 14, 2023 at 2:49 PM Ryan Moore @.***> wrote:

Check this example out:
https://github.com/mooreryan/pyml_bindgen_stickytape_example
The executable that it generates is movable...it works on my computer from
any directory, and on a different server, without having to mess around
with the PYTHONPATH or anything.
—
Reply to this email directly, view it on GitHub
https://github.com/mooreryan/ocaml_python_bindgen/issues/10#issuecomment-1546814197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFUFAA3EWQA634SN5O3OGTXGBW6TANCNFSM6AAAAAAX7KHPJA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I consider this question has been properly answered. I will try soon the proposed solution.

I think, this suggestion is great, but I will just use the unix cat command and achieve the same effect
in my gen_bindings.sh which invokes pyml_bindgen. :)


introspector: add another target oracle api

Introspector supports an additional API oracle for target querying. It would be nice to make this available for prompt development.

/gcbrun exp -n dk1000-4


Using different tags instead of FDOFFSET.

How to use different type of tags instead of FDOFFSET which is defined in libdft/src/config.h
When I am trying to use other tags such as UINT8, UINT32SET by changing the makefile.rules line
TOOL_CXXFLAGS += $(LOGGING_FLAGS) -DCUSTOM_TAGS_FDOFFSET -std=c++11 -I$(LIBDFT_PATH) -I./include
to -DCUSTOM_TAGS_UINT8 or any other tag name
and similar change in makefile.libdft in support directory.
When i am again doing make. I am getting errors in dtracker.H files in PROVLOG inline functions.

Currently this isn't supported in the master branch. You may want to check the bitset branch, where I have refactored a lot of stuff to make this easier. You will have to reimplement the syscall hooks for the tag type you want to use.
Pull requests that add support for new tag types are welcome.

@m000
I am trying to add another tag type which is based on efficient representation of sparse bitvectors.http://bmagic.sourceforge.net/.
You can find the code changes here: https://github.com/m000/dtracker/compare/bitset...vivek425ster:bitset
And i have also changed tag_traits.cpp and tag_traits.h file accordingly in the libdft.Here are the contents of the file https://gist.github.com/vivek425ster/5b1aa2446e6ba0b17a19
I am getting following error during runtime
E:Unable to load /home/vivek/libdft/bitset_new/dtracker/./obj-ia32/dtracker.so: /home/vivek/libdft/bitset_new/dtracker/./obj-ia32/dtracker.so: undefined symbol: _Z20tagmap_setb_with_tagjRKN2bm7bvectorINS_9mem_allocINS_15block_allocatorENS_13ptr_allocatorEEEEE
Can you please help me in resolving this error.
Thanks

I resolved the previous error. I wasn't doing make clean for libdft.
Now the program is always throwing segmentation fault after the end of 1st basic block i.e after call <memory address> instruction. It correctly works for the Bitset Tag. But throws segmentation fault for bvector tag which i have defined. Even when i removed the case of call near in ins_inspect function so that it goes into the default switch case, it is throwing segmentation fault. I am unable to understand how the tag is affecting the program.
The code changes are https://github.com/m000/dtracker/compare/bitset...vivek425ster:bitset
and the file tag_traits.cpp and tag_traits.h are https://gist.github.com/vivek425ster/5b1aa2446e6ba0b17a19
Can you please help in resolving the error.
Thanks

Could you post a stack trace on pastebin?
2016-03-04 16:41 GMT+01:00 vivek425ster<EMAIL_ADDRESS>
I resolved the previous error. I wasn't doing make clean for libdft.
Now the program is always throwing segmentation fault after the end of 1st
basic block i.e after call  instruction. It correctly
works for the Bitset Tag. But throws segmentation fault for bvector tag
which i have defined. Even when i removed the case of call near in
ins_inspect function so that it goes into the default switch case, it is
throwing segmentation fault. I am unable to understand how the tag is
affecting the program.
The code changes are bitset...vivek425ster:bitset
https://github.com/m000/dtracker/compare/bitset...vivek425ster:bitset
and the file tag_traits.cpp and tag_traits.h are
https://gist.github.com/vivek425ster/5b1aa2446e6ba0b17a19
Can you please help in resolving the error.
Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192327448.

@m000
I have used gdb backtrace to generate the stack trace
It gives me following
#0  0x8002a3f3 in std::basic_ostream<char, std::char_traits<char> >& std::operator<< <std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*) [clone .part.2] ()
and the pintool.log file is
Pin 2.13 kit 62728  mov eax, esp  call 0xb77237c0
I have logged the instructions which are getting executed.

Is that all of the stack trace? Because this one line seems only related to
the C++ streams library.
2016-03-05 18:45 GMT+01:00 vivek425ster<EMAIL_ADDRESS>
@m000 https://github.com/m000
I have used gdb backtrace to generate the stack trace
It gives me following
#0 0x8002a3f3 in std::basic_ostream<char, std::char_traits >&
std::operator<< <std::char_traits >(std::basic_ostream<char,
std::char_traits >&, char const*) [clone .part.2] ()
and the pintool.log file is
Pin 2.13 kit 62728
mov eax, esp
call 0xb77237c0
I have logged the instructions which are getting executed.
—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192697710.

Yes,  this is the only thing it is showing.
Are there any other methods to generate the stack trace?
On Saturday, March 5, 2016, Manolis Stamatogiannakis <
<EMAIL_ADDRESS>wrote:

Is that all of the stack trace? Because this one line seems only related to
the C++ streams library.
2016-03-05 18:45 GMT+01:00 vivek425ster<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>:

@m000 https://github.com/m000
I have used gdb backtrace to generate the stack trace
It gives me following
#0 0x8002a3f3 in std::basic_ostream<char, std::char_traits >&
std::operator<< <std::char_traits >(std::basic_ostream<char,
std::char_traits >&, char const*) [clone .part.2] ()
and the pintool.log file is
Pin 2.13 kit 62728
mov eax, esp
call 0xb77237c0
I have logged the instructions which are getting executed.
—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192697710.

—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192703842.

I doubt this is all. The displayed stack frame corresponds to the "<<"
operator of an output stream. This must have happened in some context. You
can't have this on top-level.
Try compiling everything with the "-g" flag and enable core dumps, or start
your program from within gdb.
2016-03-06 6:11 GMT+01:00 vivek425ster<EMAIL_ADDRESS>
Yes, this is the only thing it is showing.
Are there any other methods to generate the stack trace?
On Saturday, March 5, 2016, Manolis Stamatogiannakis <
<EMAIL_ADDRESS>wrote:

Is that all of the stack trace? Because this one line seems only related
to
the C++ streams library.
2016-03-05 18:45 GMT+01:00 vivek425ster<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>>:

@m000 https://github.com/m000
I have used gdb backtrace to generate the stack trace
It gives me following
#0 0x8002a3f3 in std::basic_ostream<char, std::char_traits >&
std::operator<< <std::char_traits >(std::basic_ostream<char,
std::char_traits >&, char const*) [clone .part.2] ()
and the pintool.log file is
Pin 2.13 kit 62728
mov eax, esp
call 0xb77237c0
I have logged the instructions which are getting executed.
—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192697710.

—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192703842.

—
Reply to this email directly or view it on GitHub
https://github.com/m000/dtracker/issues/3#issuecomment-192807090.

http://pastebin.com/pX8nwJBt
This is the stack trace


when update opencv to 4.1.0？

pls, thx

@yveshield https://github.com/grigorov/gocv-docker

@grigorov thx, but https://github.com/yveshield/gocv-alpine

done


[Feature Request] Alternate view for Browse screen

Why/User Benefit/User Problem
Users will be able to see all relevant content (such as Trending, Latest, New, recommendations) from a source at the same time.
What/Requirements
The view can be enabled to be default browse view in More > Settings > Browse. A display mode button can be put on top right to switch back and forth between the modes easily. More info on Discord server
Example

Requesting to modify this feature to show something like this. It would show this screen directly on Browse instead of Source/Extension, and users would switch to new sources using dropdown.

Only doable for Mangadex which is half broken every other day, make too many network calls and not viable for other sources. Closing

@jobobby04 Reopned this after seeing Paperback's tabs for Sources in Browse, and it looks incredible imo. Pls add this 🙏

Here's a video of it
https://discord.com/channels/673606787290759230/676014470316949504/826595944836890664

Hmmm, looks a bit impossible for most sources lol

Could probably only be applied to the sources which Paperback uses, maybe?


device_map error

System Info
- `Accelerate` version: 0.12.0
- Platform: Linux-4.18.0-305.25.1.el8_4.x86_64-x86_64-with-glibc2.17
- Python version: 3.8.13
- Numpy version: 1.23.1
- PyTorch version (GPU?): 1.11.0a0+gitbc2c6ed (True)
- `Accelerate` default config:
      Not found

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[X] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
File "/net/llm-shared-nfs/nfs/mayank/transformers-bloom-inference/bloom-inference-server/models/hf_accelerate.py", line 33, in __init__
    self.model = AutoModelForCausalLM.from_pretrained(**kwargs)
  File "/net/llm-shared-nfs/nfs/yelkurdi/conda/miniconda3/envs/bloom-server/lib/python3.8/site-packages/transformers/models/auto/auto_factory.py", line 463, in from_pretrained
    return model_class.from_pretrained(
  File "/net/llm-shared-nfs/nfs/yelkurdi/conda/miniconda3/envs/bloom-server/lib/python3.8/site-packages/transformers/modeling_utils.py", line 2324, in from_pretrained
    model, missing_keys, unexpected_keys, mismatched_keys, error_msgs = cls._load_pretrained_model(
  File "/net/llm-shared-nfs/nfs/yelkurdi/conda/miniconda3/envs/bloom-server/lib/python3.8/site-packages/transformers/modeling_utils.py", line 2386, in _load_pretrained_model
    raise ValueError(
ValueError: The current `device_map` had weights offloaded to the disk. Please provide an `offload_folder` for them.

This happend with max_memory = {0: '0GIB', 1: '51GIB', 2: '51GIB', 3: '51GIB', 4: '51GIB', 5: '51GIB', 6: '51GIB', 7: '51GIB'}
and device_map = "auto" in kwargs for BLOOM-176 B.
This issue was not seen in transformers 4.21.2
@sgugger fyi
Expected behavior
related: https://github.com/huggingface/transformers-bloom-inference/issues/17

Without seeing the code you run, it's hard to see the root. Are you sure you passed along the torch_dtype? I don't see any problem on my side when this argument is passed.
Also note that now you only need to pass device_map="balanced_low_0" and not memory_map to achieve the the same results (fill all the GPUs to the max and put as little as possible on the first one).

ok, ill try to replicate and share a minimal script

@sgugger
max_memory_per_gpu = {
0: "0GIB",
1: "51GIB",
2: "51GIB",
3: "51GIB",
4: "51GIB",
5: "51GIB",
6: "51GIB",
7: "51GIB",
}
and device_map = "auto" fails.
but your suggestion is working well.
Should I close this issue? Or does this need a fix?

Found where the bug was coming from, the PR linked above should fit it.


[Marker.io] Text and button label is getting trimmed in show room section

Steps to reproduce:

go to showroom section
2)notice the button label and text

Actual result: it is getting trimmed
Expected result: should be shown properly

Reported by: Vinod<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://proav-stg.webflow.io/
Issue details: Open in Marker.io
Device typemobileBrowserSafari 17.6Screen Size375 x 812OSiOS 17.6.1Viewport Size375 x 710Pixel Ratio@3x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


Fix to create_ecg_epochs.

Closes https://github.com/mne-tools/mne-python/issues/3038
The function tried to create the synthetic channel even if channel was provided.

thx @jaeilepp !


News displayed on home page

Fixes #97
Description
Successfully fetched the news and displayed it on the home page
Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
GSSoC'24

Please review my pull request @SiddharthBahuguna


update screenshots and links

The screenshot and some of the links are out of date and should be updated.

Thank you @vabarbosa for creating a PR with the required changes.
Thank you @stevemar for approving the PR.


feat(popOver): appendTo

Having the popover always appended to body, will cause issues if it's not the main scraollable container. Popover will stay at the initial position and will not scroll.
Added an argument append-to. The popup will be appended to the given CSS selector.
Added a basic example to the index.html.

Coverage remained the same at 100.0% when pulling d0d07a1758d92c50e3e84888ecdd0bebe9514701 on redlink-gmbh:master into 3006a35b74064f571b4c271c7d30f5acad12082a on mattlewis92:master.


The rangeAtIndex throws an IndexSizeError error

Describe the bug
Sometimes the library will throw IndexSizeError.
IndexSizeError
Failed to execute 'setStart' on 'Range': The offset<PHONE_NUMBER> is larger than the node's length (3).

Here's where the error occurred https://github.com/inokawa/rich-textarea/blob/main/src/vendor/range-at-index.js#L47
Called by https://github.com/inokawa/rich-textarea/blob/main/src/input.tsx#L270 and https://github.com/inokawa/rich-textarea/blob/main/src/textarea.tsx#L247
I haven't set selection in my code, I don't know why it's causing this error, it could also be a browser bug, but it looks like you can avoid a component crash by simply checking the selectionStart.
To Reproduce
I only have the bug report, not the actual reproduction.
Expected behavior
Check the parameters, or catch an error so that the component does not crash.

Platform:

Safari 17.5
Chrome 128.0

Additional context
Add any other context about the problem here.

https://github.com/slab/quill/issues/3080#issuecomment-652000347
https://github.com/ueberdosis/tiptap/issues/954#issuecomment-788133825


Test workflow changes

This fixes a deprecation and adds filtering for branch names, just testing on a PR.

User 'obfyds80oo84l6nh' has exceeded the 'max_user_connections' resource (current value: 10)
lolwut
well ghostprev-caps-etc-test was created at least 😬

and destroyed! So I deem this a success.


Support removing definitions in REPL

@andrey-kuprianov had a great suggestion for extending .clear with the following logic:

...it would be nice to have
.clear [def]
i.e. the possibility to provide an optional 1 definition to clear; otherwise clear everything

I'd rather just support shadowing.


WIP: Validation messages

Issue: #PutYourIssueNumberHere

[X] Tick here to confirm that you have run RunCodeFormatter.ps1

Description:
Briefly describe the work that has been done and how that differ from what was there before. Only a few sentences since reviewer should be able to find more information in the issue linked at the top.
Test:
Build and run Nether.Web
Call methods on swagger ui with missing information (e.g. sign in as admin and call POST /players without passing userid), and you should get a 400 BadRequest message with details of why the request was not handled

Hi @stuartleeks, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Do I need python for this?

'python' is not recognized as an internal or external command,
operable program or batch file.
What the heck?

Figuered that out.


Android 5 permission issue (duplicate permission RECEIVE)

Hello out there, i am fine with mixpanel with each version, but not Android 5.
I am using the permissions like that (in order to get it running on 6)
<permission android:name="com.google.android.c2dm.permission.RECEIVE"/>
<uses-permission android:name="com.google.android.c2dm.permission.RECEIVE" />

But here i get the following error during installation
INSTALL_FAILED_DUPLICATE_PERMISSION perm=com.google.android.c2dm.permission.RECEIVE

Any suggestion?

hi @mlostekk thanks for writing in! it looks like this issue commonly happens on Android 5.x when updating an existing app and not installing a new version of the app.
can you confirm this error is on an upgrade of the current app and not a new install? if so, do you mind going to Settings > Apps, uninstalling the app, and then installing again to see if this fixes the issue?

well, sorry for asking so fast..
but i played around with it and see that when i use only the <uses-permission> tag, then it works fine on android 4, 5 and 6.

oh, and yes i did try uninstalling, cache clearing all that stuff

no worries! the <permission android:name="com.google.android.c2dm.permission.RECEIVE"/> is for older API levels, so if you are not supporting these in your app anyways you should be fine removing this tag

ah okay. i thought its needed for the manual permission request on android 6. seems i have to read that doc :)
thanks!

feel free to let me know if you run into any problems with this approach as you implement!


KOGITO-7270: Patch PR for KOGITO-7269 with doc improvements in tooling guide

JIRA: https://issues.redhat.com/browse/KOGITO-7270

Description: Patch PR for KOGITO-7269 with doc improvements in tooling guide

https://github.com/kiegroup/kogito-docs/pull/113
Please make sure that your PR meets the following requirements:

[x] You have read the contributions doc
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[x] The nav.adoc file has a link to this guide in the proper category
[x] The index.adoc file has a card to this guide in the proper category, with a meaningful description

@ederign Please review the changes in this PR and let me know if the changes look good.

thanks @hmanwani-rh !


Toaster not hiding after timeout

I have a problem where toaster is not closing after it pops unless I move mouse over it. This is my config:
      if (showSuccessToast) {
      const toast: Toast = {
        type: 'success',
        title: 'Well Done !',
        body: toastMessage ? toastMessage : 'Operation successful.',
        showCloseButton: true,
        timeout: 2000,
        // closeHtml: '

'
      };

      this.toasterService.pop(toast);
      }

Any solution?

Hi, Can you add jsFiddle for this issue?

I just started noticing this as well :-/.

If you still have this problem make sure to only include the  in the root component template. My problem was that i accidentally included it in root AND my other component, which caused two toasts to appear but only one of them to disappear after the timeout.


no coalesced keys + key separator

What's changed?
Do not coalesce keys by default. The current behavior was to always coalesce the keys into a single key separated by dots when possible, but it's not actually true that for yaml they are equivalent. So instead of:
a.b.c: true

we will have:
a:
  b:
    c: true

For scenarios when keys with dots are required, added an extra configurable parameter to change the key separator. So we can support having
a:
  b.c: true

if that's the intended behavior.
What's your motivation?
This recipe has a lot of tests and involved in a lot of issues (some of them still open) regarding coalescing keys (or not coalescing them), and this has implications when later on we also use the MergeYaml visitor to merge results, since MergeYaml does not consider to be the same
a:
  b: true

than
a.b: true

because in yaml specification, it is not... Just in some scenarios and frameworks that uses yaml for configuration/properties files, this happens to be the same.
Anything in particular you'd like reviewers to focus on?
I'm worried that changing the recipe expectations/api, this could cause unwanted behavior in people who is using this recipe, although, based on the tests and open issues, the new behavior is the expected/wanted by most users. However, we are only using this recipe in Spring here and for people that is using this recipe in a pinned version, it might not even be a problem
Anyone you would like to review specifically?
@timtebeek @shanman190
Any additional context
I think that this requires more discussion/agreement, maybe we can use this PR to come to an agreement.
Also, "fixed" all the existing tests to pass, but I have the feeling that a lot of them were added due to "issues" in coalesced keys that don't have sense anymore, that could be remove because they are redundant...
Checklist

[x] I've added unit tests to cover both positive and negative cases
[x] I've updated the documentation (if applicable)

I think overall the change looks fine. One alternative to note is the possible use of the jsonpath style. With the Json path style properties, they opt to quote properties with dots in them that should not be separated (ex: a.b."c.d".e.f). Either the current implementation or a jsonpath style seems like they would get the job done accurately from my perspective.

I think overall the change looks fine. One alternative to note is the possible use of the jsonpath style. With the Json path style properties, they opt to quote properties with dots in them that should not be separated (ex: a.b."c.d".e.f). Either the current implementation or a jsonpath style seems like they would get the job done accurately from my perspective.

I also thought of this approach, to use quotes or ticks to specify keys that cannot be separated, the problem is that (I believe) even all those characters are valid characters for a key according to the spec, although it's probably super uncommon...

Some related issues that would fix with this:
https://github.com/openrewrite/rewrite/issues/3426
https://github.com/openrewrite/rewrite/issues/1249
https://github.com/openrewrite/rewrite/issues/1841
https://github.com/openrewrite/rewrite/issues/1873
https://github.com/openrewrite/rewrite/issues/1114
https://github.com/openrewrite/rewrite-spring/issues/189

have we tested a snapshot of this with rewrite-spring, and ChangeSpringPropertyKeyTest?
It looks like the strategy for the tests in this PR has been to adjust the recipe arguments to recreate the exact existing before/after. That feels like the wrong choice.
We know in the short term that existing usages of this recipe will bring their existing arguments, and we expect in the long term that most usages of this recipe would still choose to use the default value for this new argument. Explicitly overriding this arg is the least common pattern, but that's now the majority of what our test cases cover.
Instead, I'd recommend:

revert the test cases to use their old/existing recipe args (aside from some new test cases to prove the new arg)
adjust the before/after of each test case accordingly
in this PR, have a healthy review/discussion of whether the new before/after scenarios are acceptable for existing usage (mainly ChangeSpringPropertyKey)

My local clone/IntelliJ is misbehaving today when running failing rewrite tests (java.lang.SecurityException: class "org.eclipse.jgit.util.FS"'s signer information does not match signer information of other classes in the same package from the classloader at org.openrewrite.internal.InMemoryDiffEntry.<init>(InMemoryDiffEntry.java:62)- something amiss between rewrite's shaded jgit and regular jgit?...), but when I try these (new) test cases:
        @Test
        void foo() {
            rewriteRun(
              spec -> spec.recipe(new ChangePropertyKey("spring.profiles", "spring.config.activate.on-profile", null, null)),
              yaml(
                """
                  spring.profiles: prod
                  """,
                """
                  spring:
                    config:
                      activate:
                        on-profile: prod
                  """
              )
            );
        }

        @Test
        void bar() {
            rewriteRun(
              spec -> spec.recipe(new ChangePropertyKey("spring.profiles", "spring.config.activate.on-profile", null, null)),
              yaml(
                """
                  spring:
                    profiles: prod
                  """,
                """
                  spring:
                    config:
                      activate:
                        on-profile: prod
                  """
              )
            );
        }

...the former case fails, having produced:
spring:  config:    activate:      on-profile: prod (no newlines).
rewrite-spring uses ChangeSpringPropertyKey to make a lot of changes just like that one, so that would be a considerable regression.

Hi @nmck257, thank you very much for the feedback!
The problem that I see with this recipe, is that it relies on an invalid assumption, that a.b: c equals a: b: c (with new lines). That's no true for yaml, and when it relies on MergeYaml to do the merges, it usually fails to properly merge the keys, and adding a new "coalesced" key at the end. For most tests that just checks the moving of one single key, this might not be an issue, but when it comes to real cases, we have "new coalesced keys" that do not merge with previously existing properties....
Most of the tests, uses keys with dots (which I do not think are the same as coalesced keys). Because having a key called files.enabled, enable.process.file or management.metrics makes sense semantically, the dot is just as an "space", and does not make sense to always split them. Probably it would be better to use slashes (-) instead of dots in a yaml ecosystem, but thats completely out of our scope. Here comes the issue, the usage of the dot (.) both as a character in a key and as a key separator in the path to reference a key in the parameters. How we can support outputting some key with dots, when we try to split by dots to merge the keys?
Previously, the behavior was to always "coalesce" the new key, so it will maintain keys with dots joined, but also creates a new "coalesced" key that does not match and cannot be merged properly with existing keys... And as said, for single scenarios checked in a test it seems to work, but fails in a more general context.
I agree that changing all the tests parameters to make them pass is probably not the best idea, because probably we are even removing the original idea around this test, so it might be not needed anymore or we are missing some corner case... But how we can "fix" those tests were there are keys with dots (the default of these tests) without adding this extra parameter? Since this only affects output, because we can sort out the "input" part, maybe the idea of @shanman190 of Json path style with quotes is a good idea, but I'm worried because then we are removing the possibility of having those quotes as a characters in the key (which are valid yaml keys, but probably not used that much?).
And finally, some of the yaml tests (ans usages) of this recipe on rewrite-spring would. need to be changed too... Right now the first test even changes the key servlet-path for servlet.path, which without any change will result in an "split"... But this will happen no matter the solution we use... on how to keep keys with dots.

My local clone/IntelliJ is misbehaving today when running failing rewrite tests (java.lang.SecurityException: class "org.eclipse.jgit.util.FS"'s signer information does not match signer information of other classes in the same package from the classloader at org.openrewrite.internal.InMemoryDiffEntry.<init>(InMemoryDiffEntry.java:62)- something amiss between rewrite's shaded jgit and regular jgit?...), but when I try these (new) test cases:
        @Test
        void foo() {
            rewriteRun(
              spec -> spec.recipe(new ChangePropertyKey("spring.profiles", "spring.config.activate.on-profile", null, null)),
              yaml(
                """
                  spring.profiles: prod
                  """,
                """
                  spring:
                    config:
                      activate:
                        on-profile: prod
                  """
              )
            );
        }

        @Test
        void bar() {
            rewriteRun(
              spec -> spec.recipe(new ChangePropertyKey("spring.profiles", "spring.config.activate.on-profile", null, null)),
              yaml(
                """
                  spring:
                    profiles: prod
                  """,
                """
                  spring:
                    config:
                      activate:
                        on-profile: prod
                  """
              )
            );
        }

...the former case fails, having produced: spring: config: activate: on-profile: prod (no newlines).
rewrite-spring uses ChangeSpringPropertyKey to make a lot of changes just like that one, so that would be a considerable regression.

Fixed this issue with the newlines when the matching key is on the root! Thanks for the feedback! :)

Hey @joanvr,
I think we're approaching this recipe with different design goals. Re:

The problem that I see with this recipe, is that it relies on an invalid assumption, that a.b: c equals a: b: c (with new lines). That's no true for yaml,

Agreed that this isn't true for general Yaml. But this recipe isn't targeting general Yaml; that's what ChangeKey does. This recipe is specifically targeting the Spring Boot config scenario, as described in the comment at the top (this is also implied by the presence of the relaxedBinding option, which is explicitly a Spring concern):
https://github.com/openrewrite/rewrite/blob/eda18b5582148608b5dd0d91933ff1519747f260/rewrite-yaml/src/main/java/org/openrewrite/yaml/ChangePropertyKey.java#L40-L47
With that assumption in place, dot-separating vs nesting are both correct and equivalent. Currently, the recipe prefers dot-separating the output, but I think that was an arbitrary choice. If we see benefit in preferring nesting, then that's a fine change.
And it sounds like (based on your comments) that we do see benefit in preferring nesting, for example, in the case where we run ChangePropertyKey / MergeYaml to produce a bunch similar/overlapping keys.
In that example, if I understand correctly, a preference for dot-separation might produce something like this:
a:
  b.c.d: qwe
  b.c.e: qwe
  q.z: qwe
  b.g: qwe

...whereas a preference for nesting might produce something like this:
a:
  b:
    c:
      d: qwe
      e: qwe
    g: qwe
  q:
    z: qwe

...and we expect that the latter is more-desirable for most users. That's reasonable to me. But my key point is that in the scope of this recipe, both of those outputs are logically correct; just stylistically different.

@joanr, I was thinking about this some more and the quote version in source that you're mentioning, could appear in two different shapes for a single-level property key (unsplit): a."b.c".d (omitting the yaml spec's optional key quotes) or "a.\"b.c\".d" (using the yaml spec's optional key quotes). Given this, I don't think it would come off confusing to a user to have to escape the inner quotes for keys which appeared in the raw source themselves as they would have to be escaped had the optional, full-key quotes been present.
To me, this seems to match more closely with the heart of the yaml spec as any character can appear in the yaml key, but if it contains a YAML special character them it must be quoted and potentially escaped. Even for the current test cases using : as the delimiter, those could appear in raw source keys without any issue if the original source key was quoted (ie. "a:b" is a valid yaml key).

I think where the problem comes in is that frameworks like Spring have chosen to interpret "a.b.c.d": value, a: b: c: d: value (using newlines), and all patterns in between as having equality to each other. This attribute is kinda counter to the yaml spec itself where each of those is truly different and could all appear even in the same document without a collision.
With this said, it makes me wonder if the rewrite-spring, etc frameworks really need a specialized yaml visitor that turns it's head to the yaml spec just like their internal configuration parsers do and treats every key path, including those in source, as being their fully separated with new lines equivalent. This would probably simplify some of the issues that we end up seeing here in terms of yaml merging not behaving as a user would expect.


HDDS-2098 : Ozone shell command prints out ERROR when the log4j file …

…is not present.
Manually tested change on cluster.

/label ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
108
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
724
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
896
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
616
the patch passed

+1
mvnsite
0
the patch passed

-1
shellcheck
33
The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
770
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
112
hadoop-hdds in the patch passed.

+1
unit
297
hadoop-ozone in the patch passed.

+1
asflicense
45
The patch does not generate ASF License warnings.

3806

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1411

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 5ce4281a3c08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / b15c116

shellcheck
https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/artifact/out/diff-patch-shellcheck.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common U: hadoop-ozone/common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
71
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

0
shelldocs
0
Shelldocs was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
605
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
880
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1
mvninstall
565
the patch passed

+1
mvnsite
0
the patch passed

+1
shellcheck
32
There were no new shellcheck issues.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
768
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1
unit
108
hadoop-hdds in the patch passed.

+1
unit
290
hadoop-ozone in the patch passed.

+1
asflicense
44
The patch does not generate ASF License warnings.

3560

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1411

Optional Tests
dupname asflicense mvnsite unit shellcheck shelldocs

uname
Linux 075bdf979e4e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bb0b922

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/2/testReport/

Max. process+thread count
310 (vs. ulimit of 5500)

modules
C: hadoop-ozone/common U: hadoop-ozone/common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1411/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.4.6

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I have a question
During ozone tarball build, we do copy ozone-shell-log4j.properties to etc/hadoop (like we copy log4.properties then why do we see this error?

I have a question
During ozone tarball build, we do copy ozone-shell-log4j.properties to etc/hadoop (like we copy log4.properties then why do we see this error or something need to be fixed in copying this script?
https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/dist/dev-support/bin/dist-layout-stitching#L95

Yes, while starting ozone from snapshot tar ball, it works perfectly. However, when Ozone is deployed through a management product like Cloudera Manager, the log4j properties may not be individually configurable. We may have to rely on a default log4.properties. In that case, printing a FileNotFoundException for ozone shell commands is something we can avoid.

Closing this out since we can handle it from the cluster management tool.

Thanks for fixing this @avijayanhwx.


[HOLD for payment 2024-04-15] Remove comment linking beta

Problem
We build comment linking, but the menu item to actual copy links to reportActions is hidden behind a beta.
Solution
Add all users to the beta, then remove the beta.

taking over this issue as Rory gave it to me 😄

app PR merged, once it hits prod we'll need to follow-up with removing the beta from the back-end as well

@hayata-suenaga @roryabraham what is the payment amount for this PR review? $250?

yep, $250

@getusha offer sent!

@getusha payment sent and contract ended - thank you! 🎉


Can not buy license

I can't not buy license, since it comes to the github.

Download the latest version.


Handle possible overflows

Fixed wrong error message being shown when index is out of bounds
Ensures potential price and price range input overflows are handled

Codecov Report
Base: 51.18% // Head: 51.24% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (467f06f) compared to base (f265a7b).
Patch coverage: 69.23% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     51.18%   51.24%   +0.05%
- Complexity      557      558       +1
============================================
  Files           129      129
  Lines          2409     2416       +7
  Branches        309      310       +1
============================================
+ Hits           1233     1238       +5
- Misses         1088     1090       +2
  Partials         88       88

Impacted Files
Coverage Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
58.20% <ø> (ø)

...ava/seedu/address/model/pricerange/PriceRange.java
74.19% <42.85%> (-4.38%)
:arrow_down:

...u/address/logic/parser/EditBuyerCommandParser.java
100.00% <100.00%> (ø)

.../main/java/seedu/address/model/property/Price.java
85.00% <100.00%> (+3.75%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.