Better documentation for NodePool "Exists" operator

The Scheduling documentation for v0.36.0 says in part:

The Exists operator can be used on a NodePool to provide workload segregation across nodes.
With the requirement on the NodePool, workloads can optionally specify a custom value as a required node affinity or node selector. Karpenter will then label the nodes it launches for these pods which prevents kube-scheduler from scheduling conflicting pods to those nodes. This provides a way to more dynamically isolate workloads without requiring a unique NodePool for each workload subset.

I would like elaboration on this topic.
First, marking a NodePool with a requirement that a certain label key exists suggests that it will only launch nodes with that label. That puts it in conflict with the statement "...without requiring a unique NodePool for each workload subset" because I would need to create a unique NodePool for each label. I guess it doesn't actually work this way, but it is non-obvious that a "requirement" for a node label would merely be an option to allow such a node label, and if this is the case, it should be explicitly explained.
Second, how does having a label on a node "prevent kube-scheduler from scheduling conflicting pods to those nodes"? AFAIK a node label is not any kind of taint that would prevent pods without a node selector from being deployed to the node.
Third, what is a "conflicting pod"?

I would like elaboration on this topic

Agree that this could be clarified a bit and we'd happily accept a contribution to add to this part of the scheduling docs if you think that this could be improved.

AFAIK a node label is not any kind of taint that would prevent pods without a node selector from being deployed to the node

You're correct on this. I think the statement is implying that all of your application pods have a label with a given key and you can use Karpenter to isolate pods based on the value of that key. For instance, if you had a key team and you enforced that every pod that ever ran on your cluster had that key, then you would know that for each different value for that key, you would have isolated nodes. Another example is the kubernetes.io/role label.

I would like elaboration on this topic

Agree that this could be clarified a bit and we'd happily accept a contribution to add to this part of the scheduling docs if you think that this could be improved.

@jonathan-innis I'd consider contributing documentation if I understood what was going on, but I don't. My request here is because I don't understand how this feature works.

AFAIK a node label is not any kind of taint that would prevent pods without a node selector from being deployed to the node

You're correct on this. I think the statement is implying that all of your application pods have a label with a given key and you can use Karpenter to isolate pods based on the value of that key. For instance, if you had a key team and you enforced that every pod that ever ran on your cluster had that key, then you would know that for each different value for that key, you would have isolated nodes. Another example is the kubernetes.io/role label.

I would not have guessed this at all. In fact, I had to read what you wrote a few times to even begin to think I understood it. Restating:

Configure "key exists" in a NodePool
The NodePool will only consider pods that have a value of that key set in node affinity or node selector
Furthermore, NodePool will set the value of that key on each node, such that different pods having the same key but different values for the key will be placed on separate nodes

marking a NodePool with a requirement that a certain label key exists suggests that it will only launch nodes with that label

This is true. If you have an Exists requirement on your NodePool, Karpenter will either: 1) Use the label if it exists on the workload pod that you are trying to schedule or 2) Auto-generate the label if there is no label provided by the workload pod and it needs to generate a value for the required key in the Exists statement.

Do the pods need to be labeled, or is nodeSelector sufficient?
If the pod has no label or affinity or node selector, what prevents it from being scheduled on a node with a label other pods have specified?
If 10 pods have no label or affinity, but the Exists requirement is in effect, does that mean each pod will get its own node?

The NodePool will only consider pods that have a value of that key set in node affinity or node selector

You have everything right except for this statement above. If the application pod doesn't have a value for the key that you specify with the Exists operator, Karpenter will generate one for you. You can see this if you specify the following configuration:
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  name: default
spec:
  template:
    spec:
      nodeClassRef:
        apiVersion: "karpenter.k8s.aws"
        kind: "EC2NodeClass"
        name: default
      requirements:
        - key: app
          operator: Exists
---
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
  name: default
spec:
  role: KarpenterNodeRole-${CLUSTER_NAME}
  amiFamily: AL2023
  subnetSelectorTerms:
    - tags:
        karpenter.sh/discovery: ${CLUSTER_NAME}
  securityGroupSelectorTerms:
    - tags:
        karpenter.sh/discovery: ${CLUSTER_NAME}

If I then try and deploy the following deployment:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: inflate
  namespace: default
spec:
  replicas: 1
  selector:
    matchLabels:
      app: inflate
  template:
    metadata:
      labels:
        app: inflate
    spec:
      terminationGracePeriodSeconds: 0
      containers:
        - name: inflate
          image: public.ecr.aws/eks-distro/kubernetes/pause:3.2
          resources:
            requests:
              cpu: 1
              memory: 100Mi

The output of a Node that Karpenter generates for me contains the app label but has a randomly generated value, since the pod didn't specify one
apiVersion: v1
kind: Node
metadata:
  annotations:
    karpenter.k8s.aws/ec2nodeclass-hash: "8427593205629377792"
    karpenter.k8s.aws/ec2nodeclass-hash-version: v2
    karpenter.sh/nodepool-hash: "17611978632695636306"
    karpenter.sh/nodepool-hash-version: v2
    node.alpha.kubernetes.io/ttl: "0"
  creationTimestamp: "2024-04-21T21:20:25Z"
  finalizers:
  - karpenter.sh/termination
  labels:
    app: "4724084926046977451"
   ...

Do the pods need to be labeled, or is nodeSelector sufficient?

Pod labels don't do anything when being scheduled against nodes; it's only nodeSelectors and node affinities that are going to have any bearing here.

If the pod has no label or affinity or node selector, what prevents it from being scheduled on a node with a label other pods have specified

The answer: nothing. Karpenter will schedule this pod with either a generated label or a label that was generated from a previous pod in the scheduling loop that had the key. In the same way that the kube-scheduler would allow these pods to schedule unless they had an affinity/selector or taint that prevented it from doing so, so does Karpenter.

If 10 pods have no label or affinity, but the Exists requirement is in effect, does that mean each pod will get its own node

You should be able to check this behavior, but the answer from my testing is that you will get a single node with a karpenter-generated label and the rest of the pods can all schedule to that same node -- so you get 10 pods on a single node.

@Nuru I just posted a docs update PR (#6070). Please take a look and review to see if there's anything in there that needs to be additionally clarified that we should add before we merge it.


Adding Infinispan documentation

This also tries to make best use of the Antora features to write small and self-contained pages that answer to a single purpose/user's need.
Closes #170

@mhajas - I created a PR that contains some new structures that are helpful for Antora, as well as adding the things I know about the Infinispan setup.
To edit the content, I recommend IntelliJ and the AsciiDoc plugin. The preview should be ok to edit content.
To create a local preview, follow the readme in the antora folder.
Thinking a bit more about Infinispan and how it advertises its address, I assume that the setup with the node port doesn't work. Please give it a test run. If it doesn't work, I could remove the contents from the docs plus also the node part.
For any changes to my suggested content, I suggest you create a PR to this PR. Please let me know what you think.

@mhajas - thanks for your comment; accepted your changes. Also added the the node port can be used from the CLI.


Support Kubernetes 1.28

Hi,
Kubernetes 1.28.0 was released on Aug 15th 2023
Could the next Moco release include support for this version ?
Regards,

Replying to myself:
I didn't face any issue deploying moco on a 1.28.2 cluster from the helm-chart so... I guess it's supported already!
Missed that, sorry for the noise.

By "support", we mean we've tested it on our CI.
1.28 has not been tested in that sense, but I guess it should work with any recent Kubernetes releases.


Showing warning in Extensions

Issue Type: Performance Issue
Whenever I search for any Extension in Visual Studio Code it shows this type of warning: "We cannot connect to the Extensions Marketplace at this time, please try again later"
plz help me to solve this error.
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z)
OS version: Windows 10

Now, I have download a latest version of visual studio code... but still it shows the same error.

@kshitij-github I recently had the same error. Turned out I had a not valid proxy configured in the vscode settings.

Just in case you have the same problem.

Please check if there are errors in the following:
- Help -> Toggle Developer Tools -> Console
- Help -> Toggle Developer Tools -> Network - Please check if requests to Marketplace succeed

@sandy081  Sir... This type of Errors and Warning are showing in the Console...

Seems there are proxy issues - please check your proxy settings.


Validate and test slug, petnames

This leads to ambiguity when parsing slashlinks @carol.bob.alice e.g. Alice's Bob's Carol
Shifting to https://github.com/subconsciousnetwork/subconscious/issues/629, as noosphere petnames should support most characters for now, outside of the empty string.

Fixed via #382


Froogaloop.js  does not load sometimes

There are some physical locations in which the froogaloop script does not load for me:
https://f.vimeocdn.com/js/froogaloop2.min.js
This could be due to black list ip address or some other reason like that.
Or perhaps there is some variable missing in the implementation similar to how this is due to missing a required variable:
https://vimeo.zendesk.com/hc/en-us/articles/4409305565069-Embedded-player-displays-This-video-does-not-exist-message
I am trying to hardcode the entire froogaloop script into a patch for now, but it is not working, yet.
Has anyone experienced anything similar with the iframe?
(This may relate to this issue: https://github.com/MetaLabs-inc/react-native-vimeo-iframe/issues/19 )

Hey, @zeusstl we will be publishing the new version (1.1.0) of the library these days.
In this version we're not going to use Froogaloop anymore. Let us know if you experience this bug again.
Regards,
Marco


some fixes and code quality improvements

The menu state was not always updated correctly when trying to change the selection with the arrow keys.
The request JSON document is now built using jq to supports user input that needs to be quoted.
ShellCheck is introduced as test workflow. Existing warnings have been fixed or ignored.
Some formatting improvements for README.md.

The changes have been tested on GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu).
I hope that they're sufficiently compatible, but testing them with other versions might be advisable, if available.
Please let me know if you'd prefer smaller PRs for the individual changes.

Will try it on Mac as well. Thanks for all the improvements.


"Kick" only when the current tile is renderable

This is a PR into #1032 so merge that first.
Fixes #1033
This is a draft because they are some test failures. I think it's just tests asserting conditions that are purposely changed here, but I need to think through it more thoroughly.

I've fixed the test failures and this is ready for review now.

Thanks @j9liu! I think I've addressed your comments, or at least responded to them.


Error code: 112 , Not Permissions Issue.

Command:
..\diskspd.exe -b8k -d30 -o4 -t4 -h -r -w25 -Z1g -L -c10G T:\iotest.dat > Results.txt
Returns
Error setting end of file (error code: 112)
Error generating I/O requests
What might be the cause?

Not going to disagree that at minimum it would be nice-if DISKSPD provided the error code strings in a common error handling routine.
In this case:
https://docs.microsoft.com/en-us/windows/desktop/Debug/system-error-codes--0-499-
ERROR_DISK_FULL
Make sure you actually have 10GiB of freespace on the T: drive.
You should also reconsider whether your test will need a 1GiB random write source buffer – that’s quite large. The source buffers are chosen on 512B aligned boundaries within it. A 50MiB buffer would provide 50MiB/512 = ~102,000 different, which is likely more than enough depending on the strength of an inline, realtime deduplicator.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: RandyDotCom<EMAIL_ADDRESS>Sent: Tuesday, February 5, 2019 8:47:33 AM
To: Microsoft/diskspd
Cc: Subscribed
Subject: [Microsoft/diskspd] Error code: 112 , Not Permissions Issue. (#85)
Command:
..\diskspd.exe -b8k -d30 -o4 -t4 -h -r -w25 -Z1g -L -c10G T:\iotest.dat > Results.txt
Returns
Error setting end of file (error code: 112)
Error generating I/O requests
What might be the cause?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/diskspd/issues/85, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIVpKUXb0v2bf7PzCoO2laaZTiM9Vu1Cks5vKbWkgaJpZM4ajn-z.

Actually, Just adding the link to the readme would be 90%.


trouble compiling on amazon linux 2 (with gcc10) and graviton arm

Describe the bug
I used to be able to compile on amazon linux 2 after installing gcc10, but now I get the following error:

  --- stderr
  CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
    Compatibility with CMake < 3.5 will be removed from a future version of
    CMake.

    Update the VERSION argument <min> value or use a ...<max> suffix to tell
    CMake that the project does not need compatibility with older versions.

  CMake Warning at CMakeLists.txt:178 (message):
    Something went wrong determining gcc tune:
    -mtune=armv8.2-a+crypto+fp16+rcpc+dotprod+ssbs not valid, falling back to
    -mtune=native

  CMake Error at CMakeLists.txt:264 (message):
    A minimum of g++ 9 is required for C++17 support

  thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 1

I am running gcc version 10.5: and g++ version 10.5:
root@ip-10-148-161-36 /u/s/noseyparker (main)# gcc --version
gcc (GCC) 10.5.0 20230707 (Red Hat 10.5.0-1)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@ip-10-148-161-36 /u/s/noseyparker (main)# cpp --version
cpp (GCC) 10.5.0 20230707 (Red Hat 10.5.0-1)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

root@ip-10-148-161-36 /u/s/noseyparker (main)# g++ --version
g++ (GCC) 10.5.0 20230707 (Red Hat 10.5.0-1)
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

To Reproduce
install amazon linux 2, install gcc 10.5 from amazon extras, install rust using rustup to version 1.76
Expected behavior
System gives error messages as noted in output above.  Please note my os verison as reported by uname `linux 5.10.209-.amzn2.aarch64 #1 SMP Tue Feb 13 18:46:45 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux
Screenshots
If applicable, add screenshots to help explain your problem.
Output of noseyparker --version
Additional context
The 'older' version used to compile.

NM it seems to compile when its in /src for some wierd reason! So I guess you can ignore?

might be useful for people using in /usr/src or with broken gcc installed.....

@munntjlx I'm not sure what's going on here. All I can say is that I have not tried building Nosey Parker on Linux for ARM, only for x86_64. It ought to work in principal, but there may be rough edges.
What did you have to do to get the build working?

Funnily enough just changing the directory and recloning the repo.
I suspect it was looking at some things that were patched (I had to horribly hack the os to get things to work due to the extreme age of the os!). I can provide you a working RPM/Binary if you are interested.
thomas

From: Brad Larsen @.***>
Sent: Monday, 26 February 2024 17:19
To: praetorian-inc/noseyparker
Cc: Munn, Thomas (LNG-RDU); Mention
Subject: Re: [praetorian-inc/noseyparker] trouble compiling on amazon linux 2 (with gcc10) and graviton arm (Issue #133)
*** External email: use caution ***
@munntjlxhttps://github.com/munntjlx I'm not sure what's going on here. All I can say is that I have not tried building Nosey Parker on Linux for ARM, only for x86_64. It ought to work in principal, but there may be rough edges.
What did you have to do to get the build working?
—
Reply to this email directly, view it on GitHubhttps://github.com/praetorian-inc/noseyparker/issues/133#issuecomment-1965404338, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVIUB3JCOIT4NZHMJAFSPLYVUDAVAVCNFSM6AAAAABD2ZEUV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGQYDIMZTHA.
You are receiving this because you were mentioned.Message ID: @.***>


Cheers

Cheers

Originally posted by @tharkhay in https://github.com/jeroenpardon/sui/pull/26#issuecomment-1510758962

__


Adding deep tracing

#46  Adding deep tracing:
This PR proposes changes to be made in order to incorporate the Deep Tracing Feature for Permify.
Changes made:
These changes make use of spans and spawning new spans where the request is forwarded to internal/commads and internal/services.
So far only permissions have been deeply traced. If we agree on the approach, we can apply it to others as well.

Thanks for the changes Ahmad, I just resolce some conflicts you can continue on other folders.

Got it @tolgaOzen. Moving to the next folders now.


How to get PKCE data

First of all, I would like to send my thanks to this libary.
I am using this libary to implement SSO login for my Nuxtjs App (v2). I already sign in successful to get the authorization code from authorization server.
My problem is: after get the code, I need to send another api to my internal server to get access token, the params for this api must be include PKCE data that is used when sign in into the authorization server (code_verifier, state,...).
I tried to use data from local storage as I see there's a item named 'oidc._id' created in localstorage. But the response of api to get access_token is always 401. And my back-end team claims that the PCKE data is not correct.
So I would like to know how can I get the PCKE data that is used when I signing in into the authorization server. I really need it to compare with the params of api get acess_token to internal server.
Or can I get the full URL of the authorization_endpoint that is sent by oidc-client-ts, it look likes:
mydomain/auth?client_id=id&redirect_uri=uri...
Thank you so much

@vanminhquangtri did you manage to solve this? ran into the same problem


fix: fix dependency error in the job image

Split up the unitxt and openai dependencies to avoid the conflict.

one thing to add is that: manually installing the unitxt would be removed once we upgrade to lm-eval v0.4.4, since it was added to the core dependeicnes. We will only need to install the openai by then.


Add OCR_NOTIFY_URL env variable and functionality

If specified, it will try to post to that url with a json containing the path to the pdf, and if sidecar is used, also the path to the txt file.
Would also be great if you update the template to reflect this parameter. Thank you!
https://github.com/cmccambridge/unraid-templates/blob/master/cmccambridge/ocrmypdf-auto.xml

Thanks very much @ChristianRiesen, this is a great idea and addition!
Quick skim looks good - I'll take a closer read and get this merged tonight if I have time, otherwise certainly this coming weekend.
I'll do an update to the unraid template as well once merged... I've been curious to see whether the template update process works properly. Initially in my testing everything worked fine (including pulling updated images from quay.io instead of the more typical Docker Hub) but lately I've seen this container stuck in a permanently "Update Ready" state... I'll see if I can sort that out as well. Have you noticed similar strange behavior compared to other unraid containers?

No idea about that. I see it as update ready as well. Maybe a rebuild was triggered?


extended tests run in go 1.6

Similar to the fix in https://github.com/openshift/aos-cd-jobs/pull/102 , a fix is needed to compile extended tests using go 1.7.

@jim-minter which jobs are mis-compiling? build-rpm-release.sh should be run inside of hack/env for the test_pull_request_origin_extended_conformance_{gce,install} jobs.


refactor: enable batch inserts

Resolves https://github.com/Attacktive/troubleshooter-editor-back-end/issues/142.
Needs testing, though, if it's actually working.
SQLite might not work with rewriteBatchedInserts or rewriteBatchedStatements.

Appending JDBC URL parameter reWriteBatchedInserts does NOT seem to work. Plus, connection.metaData.supportsBatchUpdates() returns true.
I'm not sure what made me create this issue. :shrug:
Closing.


UnicodeWarning on Python 2 with non-ASCII URLs in HTTP redirection

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Description of your issue, suggested solution and other information
Originally reported at https://github.com/rg3/youtube-dl/commit/efbed08dc20c530fe428256e4dcbea4dc4423d0d#commitcomment-17573052.
On Python 2, Location header is a bytes-like object, while escape_url always return a unicode object. As a result, an UnicodeWarning may occur:
$ python2 -W error youtube_dl/__main__.py -vF http://lifenews.ru/news/98736
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-vF', u'http://lifenews.ru/news/98736']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Git HEAD: 78d3b3e
[debug] Python version 2.7.11 - Linux-4.5.1-1-ARCH-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 3.0.2, ffprobe 3.0.2, rtmpdump 2.4
[debug] Proxy map: {}
[lifenews] 98736: Downloading page
Traceback (most recent call last):
  File "youtube_dl/__main__.py", line 19, in <module>
    youtube_dl.main()
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/__init__.py", line 421, in main
    _real_main(argv)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/__init__.py", line 411, in _real_main
    retcode = ydl.download(all_urls)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/YoutubeDL.py", line 1736, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/YoutubeDL.py", line 676, in extract_info
    ie_result = ie.extract(url)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/extractor/common.py", line 341, in extract
    return self._real_extract(url)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/extractor/lifenews.py", line 84, in _real_extract
    video_id, 'Downloading page')
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/extractor/common.py", line 501, in _download_webpage
    res = self._download_webpage_handle(url_or_request, video_id, note, errnote, fatal, encoding=encoding, data=data, headers=headers, query=query)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/extractor/common.py", line 408, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/extractor/common.py", line 388, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/YoutubeDL.py", line 1946, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 437, in open
    response = meth(req, response)
  File "/home/yen/Executables/Multimedia/youtube-dl/youtube_dl/utils.py", line 865, in http_response
    if location != location_escaped:
UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal

Fixed as #9604 pushed to master.


[BUG] WINTER pipeline creates q3c extensions every time it is run

Describe the bug
Every time WINTER pipeline is run, it creates q3c extensions on a table. This takes forever to run (also possibly scales with the number of entries present in the db), causing the pipeline to stall for many many minutes before it actually starts reducing the images. Also this is is not necessary and we shouldn't be doing it. We can probably check whether the extension exists and make it only if it does not.
Additional context
Add any other context about the problem here.

I agree with your suggested solution!

Solve

FYI this had created several (hundred) copies of the same index on the tables in the database. big mess.


Problems with multiple header files with same name

In the image below, working down from the top, it's correct up to registry.h. However, my project has two files with that name (this is hard to avoid when using lots of third party libs). The chain of files shown to be includers of registry.h (those below it in the image) are in fact includers of the other file, not the one that includes compilednodedefinition.h.

Not sure if this is a bug/oversight in CompileScore, or a limitation of the compilers? I also don't know at this point if this bug extends to the timings, or if it's just in the include graph. You would probably know right away whether or not they're backed by the same data.
Thanks for a great tool btw.

This issue should be fixed on MSVC extractor on the latest version. Sadly I have not pushed the extension to the marketplace yet because Clang sources return relative paths, this makes figuring out 2 header files are the same more complicated. Also I was having problems with Clang not giving me any header information in version 14+, possibly due to some regression on Clang itself.
If you are on MSVC I would recommend just trying out manually installing v1.7.0 and check if the issue is still present.

Ah sorry, I should have checked for the latest release. That's awesome, I'm using with build2 so already using the manual data extractor anyway. I'll give the latest a go and report back.

From initial testing with 1.7.0, all looks to be sorted. Thanks!


1.5.1-pre1 Released

I just release 1.5.1-pre1 on NuGet.
Note: I said I will target .netstandard, I have to revert this. This version is targeting PCL Profile 259 still.
Please report any problems regarding this version here. If your bugs are fixed, please close them.

@TorbenK thank you! Everything is working perfectly now

Good Work.!

@TorbenK are there any plans for a UWP version? :)
I might need it in a little while, else I will try to have a go at it

@jfversluis well, it was planned. But as I said plenty of times here, I don't have the time to implement this. It would be glad if somebody else goes ahead and does it.
I'm also looking for people able to manage this project alongside me(merging PRs, fixing bugs, updating NuGet and all those stuff).

@TorbenK Well, if you would have me I can help out a bit. I do have to implement some features for UWP already, so I could give it a try 😄

Good Work!


Fix metrics decoder uptime test

A couple of fixes:

Expected and actual were flipped.
Uptime test was calling time.Since and comparing to a time.Since value generated in the code without fixing the creation or current times. It works most of the time because the delta is usually 0, but is  non-deterministic.

Can one of the admins verify this patch?

ok to test

LGTM


DCC Official: tables, rules bug fixes

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Bug Fixes

FIXED: "Base spell check" on wizard and elf are not pulling from the intelligence stat  - they are blank on the sheet and +0 under spells.
ROLL20 ISSUE: Modal bonus value not working on certain things. We tested it on Melee Attack for Warrior and every caster using a spell - the addded number does not add to the roll
FIXED: No modal bonus option for NPC's attacks. If a sheet is on NPC mode, there is no option to add a bonus when rolling their attacks/initiative/etc
FIXED: A "hit dice" button (or even just line displaying the value) somewhere on the character sheet for each class. There isn't much to leveling up in this game, so including what the hit dice are on the sheet somewhere - and making it rollable - would be a nice feature.
FIXED: Remove "range" field showing from melee weapons
FIXED: Add an ammunition counter underneath for ranged weapons
FIXED: Strange bug - when magic user classes roll initiative after casting a spell, the spell description text for the previous spell appears again in the initiative roll.
FIXED: The Deed Die roll for Warriors does not include additional Deed Damage, just the bonus to attack.

New Features
ADDED:

Ability to roll all tables found in compendium. Can customize dice used and bonus rolled.

Character Sheet Info Roll20 Internal Use only.


Add ability to save date in tip history

This means you also need to save the other values you were not initially saving.


Crash on Execution: _C is not defined in ms_deform_attn.py

Description:
I encountered an error when executing the grounded_sam2_local_demo.py script in a Docker environment built for the Grounded-SAM-2 project. The error arises specifically within the ms_deform_attn.py file, indicating that the _C variable is not defined.

Environment:
Hardware: NVIDIA GeForce RTX 4060 Ti
Host: Operating System: Ubuntu 20.04
Docker Version:
Client:
Version:    24.0.7
Context:    default
Debug Mode: false
Server:
Containers: 11
Running: 4
Paused: 0
Stopped: 7
Images: 62
Server Version: 24.0.7
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Using metacopy: false
Native Overlay Diff: true
userxattr: false
Logging Driver: json-file
Cgroup Driver: cgroupfs
Cgroup Version: 1
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 nvidia runc
Default Runtime: runc
Init Binary: docker-init
containerd version:
runc version:
init version:
Security Options:
apparmor
seccomp
Profile: builtin
Kernel Version: 5.15.0-124-generic
Operating System: Ubuntu 20.04.6 LTS
OSType: linux
Architecture: x86_64
CPUs: 20
Total Memory: 31.18GiB
Name: rtx4060ti
ID: 1ca7cc46-dbd0-45a2-bcf4-fda93d13f064
Docker Root Dir: /var/lib/docker
Debug Mode: false
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false
Docker NVIDIA-SMI Version: 560.35.03

Host CUDA Version: 12.6
Docker CUDA Version: 12.1
Docker Python Version: 3.10.14
Docker PyTorch Version: 2.3.1

import torch
torch.version.cuda
'12.1'

Steps to Reproduce:
Clone the Grounded-SAM-2 repository.
Navigate to the Grounded-SAM-2 directory and build the Docker image with the command: make build-image.
Start the Docker container with: make run.
Execute python3 grounded_sam2_local_demo.py.
Expected Behavior:
The script should execute without errors, providing the output for the demo successfully.
Actual Behavior:
Execution halts with a NameError, indicating that _C is not defined. Here is the relevant portion of the traceback:
File "/home/appuser/Grounded-SAM-2/grounding_dino/groundingdino/models/GroundingDINO/ms_deform_attn.py", line 53, in forward
output = _C.ms_deform_attn_forward(
NameError: name '_C' is not defined
Additionally, there were warnings about:
Running in CPU mode due to failing to load custom C++ ops.
The need to specify indexing arguments in future torch.meshgrid releases.
Converting non-writable NumPy array to tensor.
torch.utils.checkpoint behavior change in the future release.
None of the inputs have requires_grad=True, leading to None gradients.
Possible Cause:
It looks like the issue might be related to the custom C++ extensions not being properly compiled or loaded, most likely the _C reference is supposed to be a bridge to these compiled C++ extensions.
Requested Assistance:
Any guidance on resolving this error would be greatly appreciated. Is there a specific setup or dependency that I might be missing? Additionally, any tips on ensuring the custom C++ ops are correctly compiled and loaded would be helpful.

Regarding the warning message, “Failed to load custom C++ ops. Running on CPU mode Only!”, I am curious as to why the system defaults back to CPU-only mode despite running on an environment equipped with an NVIDIA GeForce RTX 4060 Ti graphics card.
Could you please offer some guidance on potential reasons for this issue? Specifically, I am wondering about the following:
Could this issue be related to the mismatch between the CUDA version used inside the Docker (12.1) and the CUDA version on the host machine (12.6)?
Is there a way to ensure custom C++ operations utilize GPU acceleration, even in the presence of CUDA version discrepancies?
Are there recommended steps to debug or check why PyTorch or custom C++ ops are not properly recognizing or utilizing my GPU resources?
I am confident that the correct NVIDIA drivers are installed in my environment and that nvidia-smi successfully identifies my GPU card, showing the correct CUDA version information.
Thank you!


feat: sub-select a project from the run plan

Implements GUILD-1158.
You can see it in action in this job:

Also took the opportunity to align the action name with the code: replaced all occurrences of "create run plan" with "discover run plan".
Validated in:

https://github.com/Vandebron/github-actions/pull/298
https://github.com/Vandebron/Vandebron/pull/17404
automatic PR workflow run
manual tag deployment with sub-selection

Yeah, most of the environment-specific logic is in the pipeline now 👍


fix #11480, disallow delete operator on readonly property or index  signature

Fixes #11480
It changed more tests than I thought. Should we check delete operator only if it is a property access or indexer?

Looks good to me.
Do you mean "check readonly property only when delete property access or indexer" is good or "disallow delete anything other than property access or indexer"?
For the latter, I think it would break namespace.
namespace A {
  export var a = 123;
  delete a;
}

And it would break unintentional code like
// in other file like html
window.globalProperty = 123
// in ts
declare var globalProperty
delete globalPropery

I believe both of those should be errors for the sake of clarity (unless there are some compelling use cases from real code to bring up).
In the namespace case, it would be very confusing because the behavior would have to change (to become an error) depending on whether you wrote export (since non-exported vars don't become properties). Writing delete A.a is much clearer.
In the global case, we often require globals to be prefixed by window. anyway, which seems like the correct thing to do here as well. And since we'd have to resolve this differently in modules vs non-modules anyway, it's also confusing in that regard.

@ahejlsberg I found resolvedIndexInfo is removed in #11929 . Is it intended?
I need indexInfo in checkDeleteExpression, otherwise I need to handle delete in getPropertyTypeForIndexType

@HerringtonDarkholme can you refresh the PR.

@dotnet-bot test ci please

@dotnet-bot test ci please


httpgetter does not reuse tcp connections

Recently we noticed in flux that the httpgetter from the getter package does not support reuse of tcp connections.
Here's some of our findings, which will be followed-up by a PR to sparkle some discussions.
The problem seems to be that  a new transport is being created per request. Impairing go's ability to reuse pre-established TCP connections.
Sample Code:
func main() {
	chartUrl := "https://github.com/prometheus-community/helm-charts/releases/download/kube-prometheus-stack-32.2.0/kube-prometheus-stack-32.2.0.tgz"
	g, err := helmgetter.NewHTTPGetter()
	if err != nil {
		panic(err)
	}
	options := []helmgetter.Option{
	}
	for i := 0; i < 100; i++ {
		buf, err := g.Get(chartUrl, options...)
		if err != nil {
			panic(err)
		}

		fmt.Printf("[%d] Downloaded: %d\n", i, buf.Len())
	}
}

Current Results
### The netstat command below was checked using watch to show the connections while they were occurring:
$ netstat -t | grep ESTABLISHED | grep https | grep cdn
tcp        0      0 laptop-x13:52278             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52260             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52204             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52230             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52256             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52266             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52268             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52246             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52262             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:51522             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52180             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52190             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52252             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52274             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52186             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52244             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52222             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52276             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52280             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52286             cdn-185-199-109-1:https ESTABLISHED
tcp        0      0 laptop-x13:52238             cdn-185-199-109-1:https ESTABLISHED
....

$ netstat -t | grep ESTABLISHED | grep https | grep cdn | wc -l
100

$ /bin/time -p ./current
real 22.56
user 1.08
sys 0.54

Supporting transport reuse
The follow-up PR proposes a new WIthTransport option that can be used throughout get calls enabling this:
	options := []helmgetter.Option{
		helmgetter.WithTransport(&http.Transport{}),
	}

Reusing Transport
The same application, downloading the same chart 100 times results on a single TCP connection being created.
$ netstat -t | grep ESTABLISHED | grep https | grep cdn
tcp        0      0 laptop-x13:52310             cdn-185-199-109-1:https ESTABLISHED

$ netstat -t | grep ESTABLISHED | grep https | grep cdn | wc -l
1

$ /bin/time -p ./reuse-conns
real 14.72
user 1.14
sys 0.59

It may be worth to also improve the default settings of the http.Transport created by the getters:
https://github.com/helm/helm/blob/ae8e88e0d93e2f0c0edc4521db18774ada6334bd/pkg/getter/httpgetter.go#L110-L111
For example, by not setting IdleConnTimeout it means it is 0 which translates in idle connections never being closed.
Ideally, this would be inspired by the official defaults:
https://github.com/golang/go/blob/58804ea67a28c1d8e37ed548b685bc0c09638886/src/net/http/transport.go#L38-L54

Closing this given that https://github.com/helm/helm/pull/10568 was merged.


Additional clarification for the creation of the account key

According to #50 was the wording in Step 1 a little ambiguous.

Thanks!


DO NOT SUBMIT

This change is

#385  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on  Graphite


[[Dont' merge]branch-2.11][license] Fix license issue.

Motivation
When run license check, it throw the following exception :
amqp-client-5.5.3.jar unaccounted for in lib/presto/LICENSE
commons-collections4-4.4.jar unaccounted for in lib/presto/LICENSE
jsr305-2.0.1.jar unaccounted for in lib/presto/LICENSE
log4j-api-2.18.0.jar unaccounted for in lib/presto/LICENSE
log4j-core-2.18.0.jar unaccounted for in lib/presto/LICENSE
log4j-slf4j-impl-2.18.0.jar unaccounted for in lib/presto/LICENSE
metrics-jmx-<IP_ADDRESS>.jar unaccounted for in lib/presto/LICENSE
netty-transport-native-epoll-4.1.77.Final.jar unaccounted for in lib/presto/LICENSE
rocksdbjni-<IP_ADDRESS>.jar unaccounted for in lib/presto/LICENSE
rxjava-3.0.1.jar unaccounted for in lib/presto/LICENSE
listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar mentioned in lib/presto/LICENSE, but not bundled
failsafe-2.4.4.jar mentioned in lib/presto/LICENSE, but not bundled
jersey-entity-filtering-2.34.jar mentioned in lib/presto/LICENSE, but not bundled
jersey-media-json-jackson-2.34.jar mentioned in lib/presto/LICENSE, but not bundled
jersey-media-multipart-2.34.jar mentioned in lib/presto/LICENSE, but not bundled

Documentation

[x] doc-not-needed
(Please explain why)

We don't have a CI check guard for this regression. See #16783.

We don't have a CI check guard for this regression. See #16783.

We need to fix this.


[QUESTION] Confusion About ToCollection concerns?

Prerequisites
Versions

PHP version: 7.1.2
Laravel version: 5.7.1
Package version: 3.1.0

Description
The import functionality is not intuitive how it is all supposed to work together,  and not documented well enough to alleviate the lack of intuition.  I am confused as to what the point of a ToCollection concern is exactly?
I tried to setup a very simple toCollection import. I don't want the items actually stored in a database at the time of Excel file reading because I need to sum and run calculations on the data first, then pass it off to other objects that actually handle the importing and logging.  I don't want a mega import class.
So I setup a simple Import using the toCollection concern, like so:
<?php

namespace App\Services\Revenue\ExcelImports;

use Illuminate\Support\Collection;
use Maatwebsite\Excel\Concerns\ToCollection;

class KargoImport implements ToCollection
{
    public function collection(Collection $rows)
    {
        return $rows->transform(function($row) {
           return [
               'date' => $row[0],
               'site' => $row[1],
               'impressions' => $row[2],
               'revenue' => $row[3]
           ];
        });
    }
}

Then I tried to import using:
$records = Excel::import(new KargoImport(), $filePath);

Which returns a MaatWebsiteExcel object that I can't seem to access the collection of data.  And not even that, I stuck a DD in my collection() method of KargoImport, and the function doesn't even get hit?
So instead I tried:
$records = Excel::toCollection(new KargoImport(), $filePath);

That at least returned my data, but again,  it was not run through the collections() function at all.
I get the same exact results when I pass in a null importer like so:
$records = Excel::toCollection(null, $filePath);

So that tells me for my purposes, the Importer is useless?  But it doesn't seem it should be? I would think the first example, using the Excel::import() function with a ToCollection importer as param, would return the collection of rows already run through the Importer->collection() method.  This would also allow me to use the other functions/traits for chunking reads and other functionality.
Additional Information
None

@patrickbrouwers So how then do you actually accomplish what @nickpoulos wanted to do and what I want to do.
Which is to call a method that returns a collection that's been put through a transformer first and that's it, no models involved, just return a transformed collection from a .csv file.. seems like a simple enough task that this package should be able to handle easily

phew.. managed to get something working
in my controller:
        $import = new MyImport();
        Excel::import($import, $csvFile);
        dd($import->collection);

MyImport.php:
<?php

namespace App\Imports;

use Illuminate\Support\Collection;
use Maatwebsite\Excel\Concerns\ToCollection;

class MyImport implements ToCollection
{
    public $collection;

    public function collection(Collection $collection)
    {
        $this->collection = $collection->transform(function ($row) {
            return [
                'rank' => $row[0],
                'name' => $row[1],
            ];
        });
    }
}

@patrickbrouwers i am trying to use skierrors and skipfailure traits with tocollection but its not working. But with toModel its working fine. how can i skip errors in toCollection and collect them in the last?

Wow I am very happy to see not only have the docs been updated, but it seems that the behavior of the class has been changed to work as I expected it?  I was surprised considering how swiftly my comment was dismissed and my issue request was closed.

Wow I am very happy to see not only have the docs been updated, but it seems that the behavior of the class has been changed to work as I expected it?  I was surprised considering how swiftly my comment was dismissed and my issue request was closed.


System.AccessViolationException running AttackSurfaceAnalyzer v.2.1.34-beta+fc82c7bde8  FileSystemCollector

Steps to reproduce
install latest version from https://github.com/microsoft/AttackSurfaceAnalyzer/releases

cd \Asa-win-2.1.34-beta\res>
.\asa.exe gui

Expected behavior
FileSystemCollector should finish as it does when run from cmd.exe
[21:29:22 INF] AttackSurfaceAnalyzer v.2.1.34-beta+fc82c7bde8
Hosting environment: Production
Content root path: C:\Users\user\Downloads\Asa-win-2.1.34-beta\res
Now listening on: http://localhost:5000
Application started.

Actual behavior
[22:58:03 INF] AttackSurfaceAnalyzer v.2.1.34-beta+fc82c7bde8
Hosting environment: Production
Content root path: C:\Users\user\Downloads\Asa-win-2.1.34-beta\res
Now listening on: http://localhost:5000
Application started.  System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at AttackSurfaceAnalyzer.Utils.NativeMethods.WinVerifyTrust(IntPtr, System.Guid, WinTrustData)
   at AttackSurfaceAnalyzer.Utils.NativeMethods.WinVerifyTrust(IntPtr, System.Guid, WinTrustData)
   at AttackSurfaceAnalyzer.Utils.NativeMethods.VerifyEmbeddedSignature(System.String)
   at AttackSurfaceAnalyzer.Collectors.FileSystemCollector.FileSystemInfoToFileSystemObject(System.IO.FileSystemInfo, Boolean, Boolean)
   at AttackSurfaceAnalyzer.Collectors.FileSystemCollector.<ExecuteInternal>b__7_0(System.IO.FileSystemInfo)
   at System.Threading.Tasks.Parallel+<>c__DisplayClass44_0`2[[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<PartitionerForEachWorker>b__1(System.Collections.IEnumerator ByRef, Int32, Boolean ByRef)
   at System.Threading.Tasks.TaskReplicator+Replica.Execute()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(System.Threading.Thread, System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

Environment data
Name                           Value
----                           -----
PSVersion                      7.0.0-preview.5
PSEdition                      Core
GitCommitId                    7.0.0-preview.5
OS                             Microsoft Windows 10.0.19018
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

https://github.com/microsoft/AttackSurfaceAnalyzer/issues/317#issuecomment-557244023

confirmed to still exist in newest pwsh preview 6

Perhaps ASA tries to read a file locked by pwsh.


digdag disable - Cannot build RestScheduleSummary, some of required attributes are not set [project]

When trying to run the digdag disable command (digdag disable my-project -e $HOST:$PORT) I am running into the following error:
error: javax.ws.rs.ProcessingException: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of `io.digdag.client.api.ImmutableRestScheduleSummary`, problem: Cannot build RestScheduleSummary, some of required attributes are not set [project]
 at [Source: (org.jboss.resteasy.client.jaxrs.internal.ClientResponse$InputStreamWrapper); line: 1, column: 258] (response processing)

Current DigDag version: 0.10.3
Java version: JDK 11.0.12+0
OS: MacOS Catalina
This is pretty important to me, as I want to automatically disable my dev project for cost reduction.
Any feedback would be much appreciated.
Cheers

The error message seems to indicate that the "project" attribute is missing; perhaps there was some change in the way the arguments are parsed for this command, and it is not detecting the first argument as the project?
If there's any additional information I can provide, please let me know!

Hello, @FredericoCoelhoNunes Could you tell us more reproduction steps.
In my environment.

macOS: 11.6
digdag: 0.10.3
Java: 11.0.12

test.dig
schedule:
  minutes_interval>: 1

+task1:
  echo>: ${session_time}

% digdag server -m

digdag push disable_test
2021-10-04 20:06:14 +0900: Digdag v0.10.3
Creating .digdag/tmp/archive-8053323234080642508.tar.gz...
  Archiving test.dig
Workflows:
  test.dig
Uploaded:
  id: 1
  name: disable_test
  revision: f16c262f-766b-4ae7-b7c2-7139b368c198
  archive type: db
  project created at: 2021-10-04T11:06:17Z
  revision updated at: 2021-10-04T11:06:17Z

Use `digdag workflows` to show all workflows.

digdag disable disable_test
2021-10-04 20:07:04 +0900: Digdag v0.10.3
Disabled schedule id: 1

digdag disable disable_test -e localhost:65432
2021-10-04 20:12:12 +0900: Digdag v0.10.3
Disabled schedule id: 1

Hi @hiroyuki-sato , my apologies for wasting your time.
I just noticed that I updated my client version to 0.10.3 but my server was still running 0.9.42, which is most likely where the error was coming from. Tested with a local Docker deployment (both 0.10.3) and it worked.
Can close the issue. Thanks a lot for your quick reply


re-flex: init at 3.3.1

Description of changes
https://github.com/Genivia/RE-flex
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 219895 run on aarch64-linux 1

1 package built:

re-flex


Factor in line length

Prefer breaking a line into multiple line as the length grows?

Useful in, for example:

long record expressions
datatype declarations with many constructors

May be able to combine multi-line expressions into one line on occasion, as well; for example, fn nil => true | _ => false.


html code block is evaluated instead of inserted as is

I guess it is a bug. If I insert the following code block ( from the docs ), it is processed as an html block and not shown as a block quote.
~~~

 Marine iguanas are truly splendid creatures.

 Evolution is cool.

~~~

See an example here, with source

Okay, this is weird. It works on github pages, but doesn't locally (screenshot included). You can reproduce by pulling the repo and running ] instantiate and using JuDoc; serve()

Ok so I may be misunderstanding your issue, apologies if that's the case. Your code:
@def title = "Issue325"
@def hasplotly = true
(...)
Some text here in the "standard" layout then you can inject raw HTML:

```
~~~
<div class="row">
  <div class="container">
    <img class="left" src="/assets/infra/rndimg.jpg">
    <p> Marine iguanas are truly splendid creatures. </p>
    <p> Evolution is cool. </p>
    <div style="clear: both"></div>
  </div>
</div>
~~~
```
(...)

So from looking at this, I'm assuming that you want to  show actual HTML, i.e. that you are expecting something that looks like:

 Marine iguanas are truly splendid creatures.

 Evolution is cool.

If that's the case, then you need to be aware of one thing: if you just leave HTML inside a code block, it will still be rendered (this is not a JuDoc problem see this SO post), the HTML must be escaped see this point in the doc
Further you must have @def hascode = true this is why you have this shitty rendering of code:

Does that answer your question? otherwise can you be more specific about what you want to  appear on your page?

First of all, I completely missed the new documentation  (I just bookmarked the docs and have beeing using it since), therefore I did not find the FAQ section. It looks awesome btw!
And yes, you perfectly answered my question! Thanks!
(You can ignore the using LinearAlgebrah nonsene, it was just for myself.)
I guess, I should just learn html before moving on...

I guess, I should just learn html before moving on...

Don't worry, I'm also fairly new to HTML and JuDoc kind of stemmed from my frustration of coding in plain HTML which I find a bit shit and difficult to maintain but clearly that also shows that I'm not very good  with it...
Anyway, keep the feedback coming please, it's very encouraging and it helps  add things to the docs that others may find  useful  some day or, to add features for things that help people. Ideally I'd like the tool to "just work" intuitively without having to  require the  users to know that much web-dev...


STLUX385 support

There currently is not header for the STLUX 385. AFAIK, ST replaced it by the STLUX385A, but the older STLUX385 is still widely available at distributors.

done


updated to swift 3.0

Updated from swift 2.3 to swift 3.0

@appoulsen why did you change setubNib() from private to public? 🤔

I think what you're looking for is fileprivate @appoulsen

fileprivate wouldn't work cause if someone was to implement there own nibdesignable with the nibdeisgnableprotocol. They wouldn't be able to acces the function. Alternative it could be internal that should work. Or completely shutting out developers with making the nibdesignableprotocol fileprivate

Pull Request #42 has been merged, so I am closing this one.


Enable Android

Fixes #.
Build CalcManager native library for Android. Other fixes for Android head to build.
Description of the changes:

How changes were validated:

The build passes, but android is not built 🙂


User reset password

WP doesn't have a wp_reset_password function, so this is a hack that calls retrieve_password() in wp-login.php.

I use this as a way to prevent sending customer passwords in plain text over email. Create the account and send the reset password link instead.

So why would you do this via wp-cli?
Why not create a plugin that does it automatically? i.e. whenever a new user is created, prevent the email with the plain text password and send the one with the password reset link.


Make develop branch compatible with ghcjs-dom-<IP_ADDRESS> and the newest GHCJS

Merge ryantrinkle/develop and ryantrinkle/hamishmack-master to make develop branch compatible with ghcjs-dom-<IP_ADDRESS> and the newest GHCJS thanks to @hamishmack's work on ryantrinkle/hamishmack-master.
I did not introduce any changes beyond solving merge conflicts.
It compiles fine, but I don't know more than that. Right now I am trying to port some code compatible with ryantrinkle/hamishmack-master to the new API and see how it goes. Maybe @hamishmack can comment on whether there is something special to keep in mind?

I know this is a big pull request, I am mainly putting it here for discussion and to learn about where reflex-dom is headed regarded the recent breaking changes in ghcjs and ghcjs-dom.

Thanks for putting this together!  This is exactly the direction we want to be headed in.  We'll have to do some testing with the new ghcjs work before I can merge it to develop, but it shouldn't be very long.

How's this coming?

@3noch Check out the ghcjs-improved-base2 branch (in this repo and/or in try-reflex).  I'm testing this, and once I'm able to verify that everything works properly, I'll do the merge.

Awesome.

The develop branch is now compatible with the latest ghcjs-dom.


Add automerge

@conda-forge-admin, please add bot automerge.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/betterproto-feedstock#3.


After the version 2.7.3 update, SVG parsing loses details。

I lost some SVG details when I updated the 2.7.3 version, See the code after sure is https://github.com/pocketsvg/PocketSVG/commit/42078d1040cb35b45d9af167ad3aa88d8e69e4f2 the problems after the commit, I deleted this update and everything worked fine.
In addition, I found in use that the framework does not support some tags. Such as:
<defs> </defs>

The contents wrapped in these labels cannot be interpreted,
Will these tags be supported in the future?

另外有些SVG中会设置：fill-rule
如果不做区别会使填充的效果有差异，对应的CALayer 也有 fillRule 属性，希望添加兼容。

Other SVG Settings include: fill-rule
If no difference is made, the filling effect will be different. The corresponding CALayer also has the fillRule attribute, hoping to add compatibility.

Hello @CodeForRabbit
sorry for the delay.
It looks like the only change after that commit was your PR:
https://github.com/pocketsvg/PocketSVG/compare/42078d1040cb35b45d9af167ad3aa88d8e69e4f2...master
This should only have affected colours. What other information is missing?

I want to error from https://github.com/pocketsvg/PocketSVG/commit/42078d1040cb35b45d9af167ad3aa88d8e69e4f2 to submit the while loop line 542 from the beginning.
You can test the butterfly svg in my attachment, parsing it will lose some details.

What's the error you're referring to?

I confirm, SVG parsing is corrupted in version 2.7.3.

我确认，SVG 解析在 2.7.3 版中已损坏。

I changed the `    while (!scanner.isAtEnd) {
NSUInteger zeros = 0;
while ([scanner scanString:@"0" intoString:NULL]) { ++zeros; }
// Start of a 0.x ?
if (zeros > 0 && [scanner<EMAIL_ADDRESS>intoString:NULL]) {
--zeros;
scanner.scanLocation -= 2;
}
for (NSUInteger i = 0; i < zeros; ++i) { _operands.push_back(0.0); }
            float operand;
            if (![scanner scanFloat:&operand]) {
                break;
            }
            _operands.push_back(operand);
        }` of the SVGEngine.mm file back to `

for(float operand;
[scanner scanFloat:&operand];
_operands.push_back(operand));` and everything worked fine

我确认，SVG 解析在 2.7.3 版中已损坏。

I changed the line:542~557 of the SVGEngine.mm file back to before and everything worked fine


Fix leak when switching XFT fonts

Switching fonts on dzen's XFT builds using fn() command, causes
the old font to not get unloaded, hence slowly leaking memory.

I'm still seeing a leak when using fn()
@Cloudef is it really fixed for you?


Payment options not shown in German language

Expected behavior
All payment options are enabled for all locales.
Actual behavior
For all languages the payment options are shown, except for the German language. Then only an empty <div> is rendered
Steps to reproduce the behavior
Not sure, was working before... replacing old versions don't fix this problem
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 4.4.3
PHP version: 7.2.34

Hi @Fruitboompje,
Thank you for reaching out to us, and thank you for bringing our attention to this issue.
In order to resolve this, could you please check in your BO->International->Localization if the language codes have this format?

In case your shop already has the correct language codes, could you share your BO+FTP credentials to<EMAIL_ADDRESS>We would be more than happy to investigate this further with our developer.
Looking forward to your reply!
Best regards,
Invertus Support team

Hi @Fruitboompje,
Let us know once you're ready to continue with this!
For now, we will mark this issue as resolved.
Best regards,
Invertus Support team


Update run command to support nodelocaldns tests.

This will enable setting up ci to trigger nodelocaldns tests.
/assign @krzysied

/lgtm


MOBILE-1843 : Quick fix for fail at appium-windows-driver

Dev env setup failing due to issues with appium-windows-driver package.

Hello,
thanks for working on this, I've submitted it for peer-review via the https://tracker.moodle.org/browse/MOBILE-1843 issue.
You should subscribe (watch) this issue in the tracker to get further notifications


Refactor api keys and naming

Description
This rather large commit has two main goals:

Remove all "api_key" variables and manage API keys solely through environment variables.
Remove many mentions to OpenAI where they are not necessary.

References

Fixes https://github.com/neulab/prompt2model/issues/330
Fixes https://github.com/neulab/prompt2model/issues/332
Also relevant to https://github.com/neulab/prompt2model/issues/310

Blocked by

NA

Re: the main question, yes, lightllm automatically loads the API key from environment variables.


Define Android namespace via Gradle

Task :processDebugManifest
package="com.juul...." found in source AndroidManifest.xml: src/androidMain/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here:
https://developer.android.com/studio/build/configure-app-module#set-namespace

Blocked by #187.


Works With my PS3 controller. EXCEPT

It needs a confiurable deadzone feature, my joysticks are kinda borked so if they are resting just one tick to the side, they will send input and turn/move my charecter.
example of this you could look at is mcjoypad

Download 0.4.0. I added the ability to change the deadzone.


Test Fix and single test run command

The test TestKeysFromCertificatesCreatedWithMultipleCryptoProviders was failing because it was trying to cast an RSACng private key into an RSACryptoServiceProvider and that isn't possible. The test is attempting to verify that csp providers roundtrip properly so it isn't designed to cope with Cng keys.
I've changed the certificate path fetch logic to return null for non-csp private keys without crashing and added a check on the path so the loop skips to the next item if the path is null. This effectively skips the cng provider(s).
I also updated two tests to make sure that if a certificate file is generated it will be cleaned up even if the test fails. This stops certificates being added to the store and never removed. I had quite a few in there.
Test Microsoft.Data.SqlClient.ManualTesting.Tests.AlwaysEncrypted.CspProviderExt.TestRoundTripWithCSPAndCertStoreProvider is marked as [Fact(Skip = "Failing in TCE")] what is tce? It's the other place that uses the get csp path function.
I added the run command needed for running a specific command in case it's help for anyone else trying to debug single tests in future.

what is tce?

Token Controlled Encryption


Use LF line endings

This adds a .gitattributes file as it appears in the master branch. By checking out with LF line endings, when later packed the NPM package will contain LF line endings as bash requires in order to parse #! first lines of text files.
Fixes #110
Fixes #112
Thanks for contribution! Please go through following checklist before sending PR.

@blueww merging this didn't automatically close the two issues that it fixes.

@AArnott
Just to confirm: Are the 2 related issue fixed with the PR?
If so, I will close them.

The two appear to be duplicates, and both I fully expect to be fixed when you release a new npm package that includes this change.

Hi @edwin-huber, do you think a v2 release avaiable?


Cognito Adding To Group

** Which Category is your question related to? **
Auth
** What AWS Services are you utilizing? **
Cognito, Amplify
** Provide additional details e.g. code snippets **
So i'm working on a project that uses 3 roles and for simplicity I will call them User, Editor, Admin.
When I setup auth I was able to order the groups and by default User is the group people are added to.
I have rewritten now a new signup menu because the default withAuth menu has limitations and isn't documented on how to add custom fields or a profile picture etc. So my new menu has all these fields and at the bottom a switch, if ON then add the user to editor, if not add user to group. I originally planned to use twilio to do verification for the groups but it seemed like a waste of time for now.
What I can't seem to figure out is, how can I pass this switch state to say postConfirmation? What I would like to do is let users choose a role in the signup process but i'm unsure how to even pass data to the lambda function. I have no idea were it is called, as far as I understand postConfirmation exists and just works. It gets the group and user information in the add-to-group.js and runs. So how can I tell it to add a user based on the switch?

Transferring to Amplify CLI to see if they have any insights on their side for the lambda function configuration cc @renebrandel

I think we could possibly close this. I managed to solve the issue by using the metadata parameter and passing the selected group to the lambda function.

Understood, resolving. Thanks for responding back quickly to us @Rafcin !

Np, sorry I kept it open. I'll actually go look through older cases and close and upload solutions if I found any.
For this issue if anyone is curious you can use ``clientMetadata.```, a parameter that exists for a few various actions listed at https://aws-amplify.github.io/amplify-js/api/classes/authclass.html
When you execute a confirmation or any other supported action you can pass any value to clientMetadata and in your lambda function read it as event.request.clientMetadata.{name}. In my case it was event.request.clientMetadata.signup_group


initDB should be not be helm hook

https://github.com/waldur/waldur-helm/blob/f94d0515bf04c2080074cbc6aef74eec22dd862c/waldur/templates/job-initdb.yaml#L9C1-L9C1
InitDB job should be created parallel to other services and loop in connect attempts until DB is up and ready.
Helm hook will add circular dependency, which for example in ArgoCD will never have the job created as deployments will never succeed.
Kubernetes good practise is initContainers or startupProbes.

This helm chart is thereof currently unusable with ArgoCD.

Hi!
Thank you for the note!
We are working on a possible solution for this.
Please tell me if you use the --wait flag for helm install/upgrade commands. If not, what exactly causes the error in ArgoCD?
Thank you in advance!

Hi!
We have added ArgoCD's hooks to the initdb and bootstrap jobs, so now:

initdb is a PreSync hook
bootstrap is a ProstSync hook

Could you please try waldur-helm with the updated jobs?

Please reopen if you still have an issue.


Fixed usage of deprecated React lifecycle method componentWillUpdate

Please move this along!

Hey @JedWatson could you please consider merging this?


Ignite disabled per-partition map

Closing PR as https://issues.apache.org/jira/browse/IGNITE-2329 is closed


Cranelift: failure to coalesce loads

In discussions in #2489, I found that one of the issues I was seeing was related to load coalescing in the new x64 backend--i.e., the load should have been coalesced into a subsequent instruction but was not. The x64 backend does correctly coalesce the following load + scalar_to_vector to a single movss   0(%rdi), %xmm0:
function %load32_zero(i64) -> i32x4 {
block0(v0: i64):
    v1 = load.i32 v0
    v2 = scalar_to_vector.i32x4 v1
    return v2
}

But when I add a block, the load is no longer coalesced. As @cfallin explained re: the code here, cranelift ensures (using colors) that effectful instructions cannot be coalesced across block boundaries (which conservatively increments the color). But in the following example the load + scalar_to_vector is not coalesced across a boundary--it seems to me that this should coalesce:
function %load32_zero(i64) -> i32x4 {
block0(v0: i64):
    v1 = load.i32 v0
    v2 = scalar_to_vector.i32x4 v1
    jump block1
 block1:
    return v2
}

cc: @bnjbvr, @julian-seward1

cc: @bnjbvr, @julian-seward1


Fix compilation of benchmarks

Currently, the benchmarks fail to build when obtained from Hackage, since the tarball does not include the modules on which Main.hs depends. This PR explicitly adds them to the .cabal file to fix this.
See also https://github.com/fpco/stackage/issues/1372#issuecomment-213020065

Thanks!

Pushed to hackage as psqueues-<IP_ADDRESS>.


OAuth Prompt validDomains undefined, when manifest is valid.

Version
v4.2.2 and Teams app.
Azure Blob Storage
Describe the bug
OAuth Prompt fails to show in Teams web app. Looking at the developer console.

The error appears only in personal chat on Teams. Groups and Emulator work okay, even when the bug appears in Teams.
To Reproduce
The error states that the manifest is undefined. Although, it was working prior to today [Feb 13, 2019].
We have not found a way to actually reproduce it every time. After working normally for a few days, the error appears.
Expected behavior
Attempting to gain access token to user's OneDrive using the OAuth Prompt.
Once the login button is clicked, expected to get an OAuth Prompt, upon logging in. Prompt closes and a TokenResponse is returned.
Screenshots

[bug]

@TaranbirBhullar Thank you for reporting this.  We are transferring the issue internally to the MS Teams team.
Internal tracking incident has been created for the Teams Team: https://icm.ad.msft.net/imp/v3/incidents/details/112562691/home

Given that this is now tracked via ICM, closing this issue as the ICM is the master tracking issue.

@TaranbirBhullar Is this bot sideloaded into your teams?  A Teams engineering Program manager states: "I have seen this happen before with multiple versions of the same app are sideloaded in different teams."


Delegated method returns T.untyped instead of the known return value

Input
→ View on sorbet.run
# typed: true

class Foo
  extend(T::Sig)

  sig { returns(String) }
  def method
    T.unsafe(nil)
  end
end

class Bar
  extend(T::Sig)

  delegate :method, to: :foo

  sig { returns(Foo) }
  def foo
    T.unsafe(nil)
  end
end

T.assert_type!(Bar.new.method, String)

Observed output
editor.rb:23: Expected a type but found T.untyped for T.assert_type! https://srb.help/7007
    23 |T.assert_type!(Bar.new.method, String)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expected behavior
Sorbet should know that Bar.new.method returns a String

I'm seeing the same behavior on my project. My current work-around is to not use delegate, create a new method and then copy and paste the sig from the other method to my new method.

Seeing the same... I don't see anything on the docs about delegate, is this something that was supposed to work? Or should I not get my hopes up?


Add ability to debug tests

Add
debugger;

line in your tests where you want to start debugging and run

npm run debug-test test/unit/

Then open url printed in stdout in browser and hit run button in
Devtools toolbar.

Codecov Report

Merging #688 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   95.95%   95.89%   -0.06%
==========================================
  Files          29       29
  Lines        2470     2605     +135
  Branches      208      368     +160
==========================================
+ Hits         2370     2498     +128
+ Misses        100       95       -5
- Partials        0       12      +12

Impacted Files
Coverage Δ

browser/pages/confirm/controller.js
78.88% <0%> (-2.93%)
:arrow_down:

browser/model/kompose.js
91.66% <0%> (-1.82%)
:arrow_down:

browser/services/componentLoader.js
98.78% <0%> (-1.22%)
:arrow_down:

browser/services/data.js
98.54% <0%> (-0.46%)
:arrow_down:

browser/services/platform.js
91.97% <0%> (-0.24%)
:arrow_down:

browser/services/request.js
100% <0%> (ø)
:arrow_up:

browser/pages/install/controller.js
100% <0%> (ø)
:arrow_up:

browser/directives/pathValidator.js
100% <0%> (ø)
:arrow_up:

browser/pages/location/controller.js
100% <0%> (ø)
:arrow_up:

browser/model/installable-item.js
100% <0%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db2d77...12635cb. Read the comment docs.


Remove backpack:publish-assets command from v6

@pxpm  asked to remove backpack:publish-assets command from v6
WHY
backpack:publish-assets not required in v6 & Solves https://github.com/Laravel-Backpack/CRUD/issues/5246

@karandatwani92 thank you! This seems good to me!
Did you check in v6 docs if we don't mention this anywhere? Just to make sure before we merge this 🙏
Let me know if I can go ahead and merge this!

Removed from docs here https://github.com/Laravel-Backpack/docs/pull/485
@pxpm Please merge!


Clock not working after latest update?

Hi there,
After the last update my clock's % characters are not being displayed. Sorry I don't know how to check the version that I have.
I am using a custom format as follows:
"%d/%m     %H:%M   "

I have include the quotes above to show spacing, but they are not part of the format string. This now renders on my screen as that, it is not converted to the current time.
I did find that by including the swatch time I was able to have it work, therefore until this is resolved my format string is as follows:
"%d/%m     %H:%M                          %;@"

Would appreciate any input.

Duplicate of #13.


Make restic more faster for rebuild-index

100 hour for rebuild the index of 5Tb
I don't know but rebuild a index  is too much. there is any way to go faster? parallel downloads?
[1:02:56] 2.42%  26301 / 1087537 packs
I have a 500Mb symmetric Fiber Line.
In my opinion on a dissarter rebuild the index is critical, and two days restore a backup...

Please fill out the bug report template unless you have a very good reason to ignore it.
The performance of rebuild-index highly depends on the used backend, e.g. for a local repository accessed via rclone it took me approx. one hour to rebuild the index for a 8 TB repository.

Sorry is true:
restic 0.9.6 compiled with go1.13.4 on linux/amd64
try tor recreate the cache index.
the backend is B2
https://www.backblaze.com/b2

From what I've read, it's quite common to see people report slowness with Backblaze backends. I don't understand why people keep using that stuff..

Is cheap.. very cheap.
I use this comand line to upload the number of conexion.
-o b2.connections=20
With this default parameter:
root@servidorjuanbravo23:~#  ls -l /proc/$(pgrep restic)/fd | grep socket: | wc -l
5
With the new conexions =20
root@servidorjuanbravo23:~#  ls -l /proc/$(pgrep restic)/fd | grep socket: | wc -l
10
There is a diference (and I see on the speed, at least double).

The default limit for b2 connections is 5. rebuild-index is currently limited to 10 workers, thus increasing the number of connections beyond 10 does not help. You would need to modify const listPackWorkers = 10 in internal/index/index.go.
It would probably be useful if index.New would max out the number of allowed simultaneous backend connections.

Closing this in favor of #1467 .


Make post edit button static

Issue Summary
Currently, the button to edit a post scrolls with the page. It would be better if it remained fixed. This is especially bothering with very long posts, where scrolling back to the top to edit a typo or something is an unnecessary bother.
Solution
From my testing, simply adding
.icon-edit {   position: fixed;   transform: translate(-20px, -10px); }
to the admin css fixes this, and keeps the button in (roughly) the same place.

@trnglina you can also press e at any time whilst previewing a post in the content screen to start editing it.

that's good to know, but hardly made clear. In the end, this is a small little thing that helps UX and doesn't really hurt anything.

I agree with @trnglina, I saw the same issue a couple of days ago.

Closing and adding a reference to the content screen overhaul issue.


LowCardinality and Nullable

Implementation of LowCardinality and Nullable. When implementing it, I focused on the Python client. LowCardinality in C++ looks much more complex with a large number of options, but I haven't understood it in much detail yet.
While debugging LowCardinality, I made the table in ClickHouse non-consistent several times and a couple of times ClickHouse fell into the core. It seems that I have fixed everything, but I hope that you will also look at it carefully, since there is a danger of such unpleasant events

Given that you now contributed like half the source code of this library, if this was still my private repo, I feel like it would only be appropriate to ask you whether you'd like to be become a proper maintainer / collaborator of this repo. However, I don't have permissions to do so and also don't really know if this is how things are done in the JuliaDatabases  organization.
@quinnj it would be great if you could help us out here and provide some info on the management of this organization!
@waralex By the way, if you don't want to and rather continue just being an unassociated contributor, that is totally fine as well!

@athre0z Of course, I would be happy to become the so-maintainer / collaborator of this repo. However this does not relieve you of the obligation to review my changes :) Just as I am ready to review any changes made by other people

However this does not relieve you of the obligation to review my changes :)
Heh, yes, obviously. Any non-trivial changes (trivial = typos, reformatting, ...) would still get reviewed.

@athre0z, I've given you admin privileges (sorry that didn't happen w/ the migration to JuliaDatabases!)
@waralex I've given you maintainer rights.
Love to see all the activity going on here! I opened #12 and assigned myself and I'll try to implement that this week.


Types fail to resolve with "moduleResolution": "NodeNext"

🔎 Search Terms
moduleResolution
types not resolving
library types not loading
nodeNext
jump to definitino
🕗 Version & Regression Information

I was unable to test this on prior versions because it's the opposite of an error: there are no errors. Incorrect types are allowed.

⏯ Playground Link
No response
💻 Code
Reproduction repo.
🙁 Actual behavior
Invalid types are allowed when using "moduleResolution": "NodeNext",
The below video is from the reproduction repo linked above. It shows how errors are not detected when changing the module resolution.

Video types failing
Screencast from 21-10-2023 14:28:49.webm

🙂 Expected behavior
Invalid types should be caught and reported.
Additional information about the issue
tsc Version 5.2.2

Looks like the issue is with solid-js, not TypeScript:
https://arethetypeswrong.github.io/?p=solid-js%401.8.3

Thanks @fatcerberus, that's a handy resource.


Token Transformer doesn't preserve references on typography and boxshadow tokens

Describe the bug
When setting the --resolveReferences param to false or 'math' the references are kept accordingly on simple/flat token values, but not on composite/complex/nested typography and boxshadow tokens (as well as boxshadow[] arrays).
To Reproduce
Steps to reproduce the behavior:

Include typography or boxshadow tokens with references and/or math expressions in the composite/nested values.
Run token-transformer cli with --resolveReferences param set to false or 'math'
See references are resolved to their values and not kept in the output json.

Expected behavior
I would expect references/aliases are kept in the output of composite/complex/nested typography and boxshadow tokens.
JSON (optional)
{
  "name": "typography.h1",
  "type": "typography",
  "value": {
    "fontFamily": "Roboto",
    "fontSize": "{text.size.base}",
    "fontWeight": "{text.fontWeight.light}",
}

@six7 I didn't come across this specific scenario when adding the --resolveReferences option to the token transformer, but found out afterwards when trying out the updated release on actual tokens 😊
I've created a fix and PR + updated the resolveReferences tests. Let me know, if you would rather have these added parts of the tests in their own separate tests 🤷🏻


Use more C++11 features:

Remove beast::static_initializer
Remove noexcept VS2013 workaround
Use variadic constructor
Use [[noreturn]] attribute
Default move constructors

Just a few minor suggested tweaks.  I love how much smaller and simpler this makes rippled!

@nbougalis: Windows appears to be failing unit tests (see appveyor): Assertion failed: type_ == nullValue || type_ == arrayValue, file C:\projects\rippled-179\src\ripple/json/impl/json_value.cpp, line 819

These changes clean things up nicely. I'll give a thumbs up after the issues with windows unittests pass and the SharedData constructor are resolved.

@seelabs: I saw that failure and am not sure what's going on there.

@nbougalis @seelabs Appveyor has a 40 minute time limit, and fails silently when it hits it. Seems to be more related to Appveyor being busy and not anything in our code. Unfortunately, I'm not able to restart the build.

This all tested out for me. :+1:   I haven't looked at the travis/appveyor failures.

Well, VS2015 isn't cooperating:
C:\projects\rippled-179\src\ripple/app/ledger/impl/LedgerCleaner.cpp(98): error C2512: 'beast::SharedData<ripple::LedgerCleanerImp::State,beast::SharedMutexAdapter<beast::RecursiveMutex>>::SharedData': no appropriate default constructor available
scons: *** [build\msvc.debug\src\ripple\unity\app_ledger.obj] Error 2
scons: building terminated because of errors.

I prefer we removed SharedData instead of "improving" it.

@vinniefalco as a matter of fact: https://github.com/nbougalis/rippled/commits/shareddata

@nbougalis It looks like VS2015 is not handling the is_constructible correctly in SharedData.h (or less likely, the enable_if). This patch removes the enable_if: https://github.com/seelabs/rippled/commit/2976c0470b96c8978d08719cd23f6fb729e7cbbc

Better to NOT TOUCH the class and REMOVE It instead!

I have removed the changes to SharedDate since the entire class is removed with #1348. All other review comments and suggestions have been incorporated and the changes have been squashed.

Current coverage is 49.34%

Merging #1341 into develop will decrease coverage by -0.04% as of 78146b3

@@            develop   #1341   diff @@
=======================================
  Files           962     960     -2
  Stmts         65925   65838    -87
  Branches          0       0
  Methods           0       0
=======================================
- Hit           32560   32487    -73
  Partial           0       0
+ Missed        33365   33351    -14

Review entire Coverage Diff as of 78146b3

Powered by Codecov. Updated on successful CI builds.

:+1: Side note: Gcc 5.2 is issuing two warning about unused variables:

CreateOffer.cpp:652:17: warning: unused variable ‘uPaysCurrency’

Transactor.cpp:665:23: warning: unused variable ‘a_seq’

However, these are unrelated to your changes.

Those warnings are my fault, and are fixed in https://github.com/ximinez/rippled/commit/08ff164ca6db35e5e45d2497af401e41b14ed3ac (part of #1230)

Merged as 570bb2e13920e386f10f1295cf1e62ca41fce05d.


Allow storing of test and non-production data in the HCA - ignore for indexing purposes

See https://docs.google.com/document/d/1isYNP_l8y6he5GjcJ-ABkZ19do_-l6x0tjh3vN4qMPQ/edit?ts=5b6d9e22#heading=h.1m391awqmqc9.
We propose to leverage the inclusion of an enum (or similar) in a "provenance" field in the metadata schema. This field could store flags such as:
"testing data"
"benchmarking data"
"draft-schema"
"development data"
Initially, the Data Browser will filter this field, hiding data by default that contain any of the above flags.

Moved to azul https://app.zenhub.com/workspace/o/databiosphere/azul/issues/212


Heroku deploy button not working

I tried several times to deploy the app in heroku but I never could finish the process.
Is there any special stuff to do ?

I need to take a closer look because they've changed a bunch of the underlying implementation since they launched.

@atmos Are you running heaven on heroku now ?

I am, I just haven't used the button in a while. I recently started working at heroku so I'll try to get one spun up now that I don't have to worry about paid accounts. It's a long story.. :smiley:

Awesome! How is heroku treating you ? Nice place to work ?


Extends CrudApiPlugin to support Entra auth. Closes #556

Extends CrudApiPlugin to support Entra auth. Closes #556
To test, you can use the northwind db sample
Update orders-api.json for example to:
{
  "$schema": "https://raw.githubusercontent.com/microsoft/dev-proxy/main/schemas/v1.0/crudapiplugin.schema.json",
  "baseUrl": "https://api.northwind.com/orders",
  "auth": "Entra",
  "entraAuthConfig": {
    "validateSigningKey": true
  },
  "dataFile": "orders-data.json",
  "actions": [
    {
      "action": "getAll"
    },
    {
      "action": "getOne",
      "url": "/{order-id}",
      "query"<EMAIL_ADDRESS>== {order-id})]"
    },
    {
      "action": "create"
    },
    {
      "action": "merge",
      "url": "/{order-id}",
      "query"<EMAIL_ADDRESS>== {order-id})]"
    },
    {
      "action": "delete",
      "url": "/{order-id}",
      "query"<EMAIL_ADDRESS>== {order-id})]"
    }
  ]
}

Call the API from curl by passing a valid Entra token:
curl -ix http://<IP_ADDRESS>:8000 -H "authorization:Bearer eyJ0eXAiOiJKV1QiLCJhbG...." https://api.northwind.com/orders

In entraAuthConfig you can specify several options as to what parts of the token you want the API to validate:

audience: set to the audience string from the token to validate the audience, eg. https://manage.office.com
issuer: set to the ID of the IdP that issued the token, eg. https://sts.windows.net/06fde681-d710-4b73-8bc6-90585c5630e9/
scopes: set to define the list of scopes for all actions. The token must have at least one of the scopes
roles: set to define the list of roles for all actions. The token must have at least of the roles
validateLifetime: set to true for the API to validate if the token hasn't expired
validateSigningKey: set to true for the API to validate if the token signature is valid. Requires you to specify a valid and untempered with token issued by Entra

All these properties can be overriden on each action, which allows you to for example specify unique scopes/roles for each action:
{
  "$schema": "https://raw.githubusercontent.com/microsoft/dev-proxy/main/schemas/v1.0/crudapiplugin.schema.json",
  "baseUrl": "https://api.northwind.com/orders",
  "auth": "Entra",
  "entraAuthConfig": {
    "validateSigningKey": true
  },
  "dataFile": "orders-data.json",
  "actions": [
    {
      "action": "getAll",
      "auth": "Entra",
      "entraAuthConfig": {
        "scopes": [
          "orders.read"
        ]
      }
    },
    {
      "action": "getOne",
      "url": "/{order-id}",
      "query"<EMAIL_ADDRESS>== {order-id})]",
      "auth": "Entra",
      "entraAuthConfig": {
        "scopes": [
          "orders.read"
        ]
      }
    },
    {
      "action": "create",
      "auth": "Entra",
      "entraAuthConfig": {
        "scopes": [
          "orders.write"
        ]
      }
    },
    {
      "action": "merge",
      "url": "/{order-id}",
      "query"<EMAIL_ADDRESS>== {order-id})]",
      "auth": "Entra",
      "entraAuthConfig": {
        "scopes": [
          "orders.write"
        ]
      }
    },
    {
      "action": "delete",
      "url": "/{order-id}",
      "query"<EMAIL_ADDRESS>== {order-id})]",
      "auth": "Entra",
      "entraAuthConfig": {
        "scopes": [
          "orders.write"
        ]
      }
    }
  ]
}

Does calling other endpoints work? Seems odd that curl would do something with the access token. What's the command you're using? Is the cert trusted on your box?


'change' event

'change' is a bad choice because it is a native DOM form input event which will necessarily bubble up to the window. Perhaps an amok- prefix for these custom events?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27828254-change-event?utm_campaign=plugin&utm_content=tracker%2F12689110&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F12689110&utm_medium=issues&utm_source=github).

Ups, yeah good call. Maybe call it watch?

So I'll be renaming the events to be have more descriptive names.

scriptChange
fileChange

Cool. scriptChange being the new patch?

Correct :+1:

It'll go out in 2.0 (https://github.com/caspervonb/amok/commit/74956c2e16671e5e69673d040670b0e1cc197758) currently on master, but I have some more things I want to break before pushing out a major.
In the meantime you can test for detail which indicates that its a custom event, and you can be pretty sure its not a DOM event.


Crashing when opening AC6 with this plugin enabled

Tested on

ChimeraOS 43/44
Proton 8
AyaNeo 2D

When opening Armored Core 6, after EAC, the screen flashes white, and the game closes. If I disable settings on the plugin configuration, game launches just fine.

I meant AyaNeo 2S

If smt is closed, try opening it

What is SMT?


build: enable services-mysql for Java and Python bindings

Follow up https://github.com/apache/opendal/issues/5000 and https://github.com/apache/opendal/pull/5013
We're now using sqlx so that as long as services-postgres works, MySQL may be fine.

Not sure if we test services mysql against bindings and how we add such tests.

Not sure if we test services mysql against bindings and how we add such tests.

They are always tested but not released because Linux x86_64 consistently works correctly, whereas other platforms do not.


MM-T1539: Verify :man-gesturing-ok: is rendered with the correct gender

Summary

Verify 🙆♂ is rendered with the correct gender
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/18163
Related Pull Requests

No related PRs.
Screenshots

No UI changes.
Release Note

NONE

Hello @sk409,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

I will move spec file and change describe's name.

@sk409 Could you, please use ts instead of js, we are currently running a typescript migration campaign, and these will eventually add up to tech debt. Thanks

@AshishDhama
Thank you for your review!
I renamed .js to .ts.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/249259

@sk409
Can you please lint errors ?

@yasserfaraazkhan @furqanmlk
I forgot to run make fix-style.
I fixed style.

/update-branch

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

What is the review status of this PR?