[Feature] Change schedule on run time

Hi @merencia,
I have added this change due to sometimes we would like to manage the job on run time.
Could someone guide me on how to make a test to the new method?

Is this feature available yet?

Is this feature available yet?

I have closed the pull request, due to they don't merge the pull request but you could try this on your project.


Changelog for January 2023 release

Title says it all

Thanks for putting this together, see comments for the suggested changes.

Ready for another look @jfomhover


[WIP] Iron handler

I started implementing the handler, to separate the server from the data.
This is a work in progress PR, not ready to merge yet.

I close this because it's superseded by #32


Display SSP Network Architecture

As a user of the OSCAL Viewer, I want to see the Network Architecture of a System Security Plan (example) including any specified inline images so that I can understand the top-level networking components of the system.
Acceptance Criteria

A Network Architecture section is displayed in System Characteristics if present in the OSCAL SSP
The Network Architecturedescription field is displayed
The Network Architecture remarks is displayed
Any Network Architecture diagram images are displayed with any defined caption

Implementation Notes

For sizing purposes, we will assume #225 has already been completed
We're likely to develop a Diagram component that can be re-used across Authorization Boundary, Network Architecture, and Data Flow components
We could potentially modify the existing oscal-rest-service test SSP to include an authorization boundary section pointing to an actual image, but any example SSP with that data will suffice

@kylelaker, would you mind duplicating the oscal-rest-service test data changes to the oscal-demo-content repo as well?
In the future we'll look to pull the demo content as the test data rather than duplicating.


[DO NOT MERGE] ⚠ Debugging arm64_32 Float Printing ⚠

buildbot_incremental,tools=RA,stdlib=RA,test=watchOS,type=device
@swift-ci Please test with preset macOS

preset=buildbot_incremental,tools=RA,stdlib=RA,test=watchOS,type=device
@swift-ci Please test with preset macOS


⚠ Thumbnails API Endpoint has degraded performance

In cee0df1, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1093 ms

Resolved: Thumbnails API Endpoint performance has improved in c5f788f.


Add to project tester for dmd

See here: https://github.com/MartinNowak/io/issues/27#issuecomment-550503871

Requires that it builds properly with dmd-nightly, which currently it doesn't.

Fixed in https://github.com/dlang/ci/pull/411


Keyvault macros deprecate and new names

closes #5588
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

It might be nice to include a reproduction of the customer scenario so we can confirm that it's fixed by this change (or that the customers scenario can be fixed after this change).

added repro

I still think we shouldn't be shipping the macro-build test app as part of the SDK, to end customers. Unless I am missing something (which is quite possible), please move it to BUILD_TESTING. Let me know :)
That is the only blocker.

I agree with Ahson on this one - if it's conditionally under the BUILD_TESTING macro, then it won't be built on customer machines when they download the SDK. If it's not under BUILD_TESTING, it will be built on every customers machine, which seems unnecessary.

I still think we shouldn't be shipping the macro-build test app as part of the SDK, to end customers. Unless I am missing something (which is quite possible), please move it to BUILD_TESTING. Let me know :)
That is the only blocker.

I agree with Ahson on this one - if it's conditionally under the BUILD_TESTING macro, then it won't be built on customer machines when they download the SDK. If it's not under BUILD_TESTING, it will be built on every customers machine, which seems unnecessary.

Done.

/azo run cpp - core - ci

/azp run cpp - core  - ci


CustomVisionObjectsのusingが必要？

本手順通りに進めたつもりですが、Chapter 11まで進めても
CustomVisionTrainer.csとCustomVisionAnalyser.csにコンパイルエラーが残りました。
両クラスにusing static CustomVisionObjects;を追加し、さらにCustomVisionObjects.csのMultipartObjectをpublicに変更したところ正常にコンパイルできたのですが、この方法でよかったのでしょうか？
それとも私の実装手順が誤っていますでしょうか？

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 889db7e9-a0ea-abb3-9b25-f9db5527655c
Version Independent ID: 6fd8a913-c2ae-a45e-1461-357f46105e34
Content: MR and Azure 302b - Custom vision - Mixed Reality
Content Source: mixed-reality-docs/mr-azure-302b.md
Product: windows
GitHub Login: @DrNeil
Microsoft Alias: v-arood

Hi, @haveagit.
I'm having trouble understanding where you issue is; are you saying that you cannot compile the project using the code provided?
If the above is true, can you please confirm that the following is correct for your project:

You are using Unity 2017 LTS (anything later will not work).
You have imported the Newtonsoft DLL plugins, and set them up correctly.
You have your project set to Universal Windows Platform.
Remember, as per instructions, the MultipartObject class is OUTSIDE the CustomVisionObjects class, as are all other tags and objects. The CustomVisionObjects class itself should be empty.

Hello, elliotmoule
Thank you for your reply.

are you saying that you cannot compile the project using the code provided?

Yes. compile error occurred.
but I had skip reading 'outside' in Chapter 7.
I modified code refferd your advice Then compiling succeeded.
Thanks.

Hi @haveagit,
Very pleased that you were able to solve your issue 👍
If you are satisfied that your issue has been solved, please close the issue.
Thanks for using the MR and Azure Docs, feel free to message if you have any other troubles.
Regards,
Elliot Moule.

Hi,
the application stack on Analysis (red cursor)  in both training and analysis mode i donno from where the issue comes.
plz help
thanks.

Hi,
the application stack on Analysis (red cursor) in both training and analysis mode i donno from where the issue comes.
plz help
thanks.

Hi @kaled1993 ,
Are you able to provide some more information about your issue?

What course (MR and Azure 3..?)
Any errors that you are getting in the console.
Screenshots of your issue.

Regards,
Elliot


Add regression test for multiple engine reloads

🦟 Bug fix
Summary
Similar to previous crashes we have had, we weren't appropriately cleaning up resources in our rendering objects.
I uncovered this while testing gz-sensors7, as it wasn't revealed by tests here.
As a result, I have added a regression test that will attempt to load and unload a rendering engine multiple times while also instantiating sensors.  If everything is cleaned up correctly, this test runs without any segfaults.
A have also included fixes for the DepthCamera and GpuRays sensor that were detected via this test.
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

I also removed a few members that I discovered were unused in my debugging.

I have been unable to reproduce INTEGRATION_depth_camera_ogre_gl3plus locally, but it seems to fail consistently across our platforms. I will try it on macos and see what happens.

@darksylinc There seems to be something specifically wrong with the OGRE 1 depth camera.  I have valgrind/gdb for a bit and I'm kind of stumped.  I think it's a viewport not getting disconnected correctly?
If you have a quick guess I can try to track down, it would be appreciated.
EXPORT GZ_ENGINE=ogre
EXPORT GZ_ENGINE_BACKEND=gl3plus
gdb --args ./bin/INTEGRATION_depth_camera --gtest_filter="*DepthCameraBoxes"

#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=140737320557760) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=140737320557760) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=140737320557760, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x00007ffff7902476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x00007ffff78e87f3 in __GI_abort () at ./stdlib/abort.c:79
#5  0x00007ffff79496f6 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7ffff7a9bb8c "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#6  0x00007ffff7960d7c in malloc_printerr (str=str@entry=0x7ffff7a9e5d8 "malloc_consolidate(): unaligned fastbin chunk detected") at ./malloc/malloc.c:5664
#7  0x00007ffff7961a0c in malloc_consolidate (av=av@entry=0x7ffff7ad9c80 <main_arena>) at ./malloc/malloc.c:4750
#8  0x00007ffff7962f20 in _int_free (av=0x7ffff7ad9c80 <main_arena>, p=0x5555565bb1b0, have_lock=<optimized out>) at ./malloc/malloc.c:4674
#9  0x00007ffff79654d3 in __GI___libc_free (mem=<optimized out>) at ./malloc/malloc.c:3391
#10 0x00007ffff2dda6e5 in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.470.141.03
#11 0x00007ffff2abdac8 in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.470.141.03
#12 0x00007ffff2f094dc in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.470.141.03
#13 0x00007ffff2bb05b0 in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.470.141.03
#14 0x00007ffff2f0af78 in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.470.141.03
#15 0x00007ffff2b79113 in ?? () from /lib/x86_64-linux-gnu/libnvidia-glcore.so.470.141.03
#16 0x00007ffff1804b4d in Ogre::GLTexture::freeInternalResourcesImpl() () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/RenderSystem_GL.so
#17 0x00007ffff5abc11d in Ogre::Texture::unloadImpl() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#18 0x00007ffff5a00c48 in Ogre::Resource::unload() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#19 0x00007ffff17fefed in Ogre::GLTexture::~GLTexture() () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/RenderSystem_GL.so
#20 0x00007ffff17ff06d in Ogre::GLTexture::~GLTexture() () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/RenderSystem_GL.so
#21 0x00007ffff58de3a9 in ?? () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#22 0x00007ffff5a8da81 in Ogre::ShadowTextureManager::clearUnused() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#23 0x00007ffff5a41da1 in Ogre::SceneManager::destroyShadowTextures() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#24 0x00007ffff5a269a7 in Ogre::SceneManager::~SceneManager() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#25 0x00007ffff13d210b in ?? () from /usr/lib/x86_64-linux-gnu/OGRE-1.9.0/Plugin_OctreeSceneManager.so
#26 0x00007ffff5a4c860 in Ogre::SceneManagerEnumerator::removeFactory(Ogre::SceneManagerFactory*) () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#27 0x00007ffff5a21e0e in Ogre::Root::shutdownPlugins() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0
#28 0x00007ffff5a1d21a in Ogre::Root::shutdown() () from /lib/x86_64-linux-gnu/libOgreMain.so.1.9.0

Valgrind seems a bit more interesting:
==1799311== Invalid write of size 1
==1799311==    at 0x4B46E4D: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_assign(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.30)
==1799311==    by 0x6E470B1: assign (basic_string.h:1387)
==1799311==    by 0x6E470B1: operator= (basic_string.h:681)
==1799311==    by 0x6E470B1: setMaterialScheme (OgreViewport.h:276)
==1799311==    by 0x6E470B1: gz::rendering::v7::OgreRTShaderSystem::DetachViewport(Ogre::Viewport*, std::shared_ptr<gz::rendering::v7::OgreScene>) (OgreRTShaderSystem.cc:287)
==1799311==    by 0x6E58FF7: gz::rendering::v7::OgreRenderTarget::~OgreRenderTarget() (OgreRenderTarget.cc:64)
==1799311==    by 0x6E598BE: gz::rendering::v7::OgreRenderTexture::~OgreRenderTexture() (OgreRenderTarget.cc:310)
==1799311==    by 0x6E5994C: gz::rendering::v7::OgreRenderTexture::~OgreRenderTexture() (OgreRenderTarget.cc:310)
==1799311==    by 0x124321: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:168)
==1799311==    by 0x6DD88BE: ~__shared_count (shared_ptr_base.h:705)
==1799311==    by 0x6DD88BE: ~__shared_ptr (shared_ptr_base.h:1154)
==1799311==    by 0x6DD88BE: ~shared_ptr (shared_ptr.h:122)
==1799311==    by 0x6DD88BE: ~OgreDepthCameraPrivate (OgreDepthCamera.cc:31)
==1799311==    by 0x6DD88BE: operator() (unique_ptr.h:85)
==1799311==    by 0x6DD88BE: operator() (unique_ptr.h:79)
==1799311==    by 0x6DD88BE: ~unique_ptr (unique_ptr.h:361)
==1799311==    by 0x6DD88BE: gz::rendering::v7::OgreDepthCamera::~OgreDepthCamera() (OgreDepthCamera.cc:87)
==1799311==    by 0x6DD8A5C: gz::rendering::v7::OgreDepthCamera::~OgreDepthCamera() (OgreDepthCamera.cc:87)
==1799311==    by 0x6DB8BBF: _M_release (shared_ptr_base.h:168)
==1799311==    by 0x6DB8BBF: ~__shared_count (shared_ptr_base.h:705)
==1799311==    by 0x6DB8BBF: ~__shared_ptr (shared_ptr_base.h:1154)
==1799311==    by 0x6DB8BBF: ~shared_ptr (shared_ptr.h:122)
==1799311==    by 0x6DB8BBF: gz::rendering::v7::BaseNode<gz::rendering::v7::OgreObject>::RemoveChildren() (BaseNode.hh:302)
==1799311==    by 0x48B9805: gz::rendering::v7::BaseScene::Clear() (BaseScene.cc:1423)
==1799311==    by 0x48AF6B0: gz::rendering::v7::BaseScene::Destroy() (BaseScene.cc:1434)
==1799311==    by 0x6E5D62C: gz::rendering::v7::OgreScene::Destroy() (OgreScene.cc:300)
==1799311==  Address 0x6b7aef5 is 5 bytes inside a block of size 34 free'd
==1799311==    at 0x484BB6F: operator delete(void*, unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==1799311==    by 0x734F21C: Ogre::Viewport::~Viewport() (in /usr/lib/x86_64-linux-gnu/libOgreMain.so.1.9.0)
==1799311==    by 0x7279354: Ogre::RenderTarget::removeAllViewports() (in /usr/lib/x86_64-linux-gnu/libOgreMain.so.1.9.0)
==1799311==    by 0x6DD841E: gz::rendering::v7::OgreDepthCamera::Destroy() (OgreDepthCamera.cc:117)
==1799311==    by 0x6E2F937: gz::rendering::v7::BaseStore<gz::rendering::v7::Sensor, gz::rendering::v7::OgreSensor>::DestroyImpl(std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<gz::rendering::v7::OgreSensor> > >) (BaseStorage.hh:956)
==1799311==    by 0x6E29B39: gz::rendering::v7::BaseStore<gz::rendering::v7::Sensor, gz::rendering::v7::OgreSensor>::DestroyAll() (BaseStorage.hh:734)
==1799311==    by 0x48BF0BD: gz::rendering::v7::BaseCompositeStore<gz::rendering::v7::Node>::DestroyAll() (BaseStorage.hh:1216)
==1799311==    by 0x48B97D3: DestroyNodes (BaseScene.cc:333)
==1799311==    by 0x48B97D3: gz::rendering::v7::BaseScene::Clear() (BaseScene.cc:1419)
==1799311==    by 0x48AF6B0: gz::rendering::v7::BaseScene::Destroy() (BaseScene.cc:1434)
==1799311==    by 0x6E5D62C: gz::rendering::v7::OgreScene::Destroy() (OgreScene.cc:300)
==1799311==    by 0x6E2E890: gz::rendering::v7::BaseStore<gz::rendering::v7::Scene, gz::rendering::v7::OgreScene>::DestroyImpl(std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<gz::rendering::v7::OgreScene> > >) (BaseStorage.hh:956)
==1799311==    by 0x48ADCEF: gz::rendering::v7::BaseRenderEngine::DestroyScene(std::shared_ptr<gz::rendering::v7::Scene>) (BaseRenderEngine.cc:163)

Actually, this is a better valgrind trace (without some of my modifications/checks)
==1807158== Invalid write of size 2
==1807158==    at 0x48529E3: memmove (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==1807158==    by 0x4B46EAE: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_assign(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.30)
==1807158==    by 0x6E470B1: assign (basic_string.h:1387)
==1807158==    by 0x6E470B1: operator= (basic_string.h:681)
==1807158==    by 0x6E470B1: setMaterialScheme (OgreViewport.h:276)
==1807158==    by 0x6E470B1: gz::rendering::v7::OgreRTShaderSystem::DetachViewport(Ogre::Viewport*, std::shared_ptr<gz::rendering::v7::OgreScene>) (OgreRTShaderSystem.cc:287)
==1807158==    by 0x6E58FA7: gz::rendering::v7::OgreRenderTarget::~OgreRenderTarget() (OgreRenderTarget.cc:66)
==1807158==    by 0x6E5986E: gz::rendering::v7::OgreRenderTexture::~OgreRenderTexture() (OgreRenderTarget.cc:312)
==1807158==    by 0x6E598FC: gz::rendering::v7::OgreRenderTexture::~OgreRenderTexture() (OgreRenderTarget.cc:312)
==1807158==    by 0x124321: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() (shared_ptr_base.h:168)
==1807158==    by 0x6DD88BE: ~__shared_count (shared_ptr_base.h:705)
==1807158==    by 0x6DD88BE: ~__shared_ptr (shared_ptr_base.h:1154)
==1807158==    by 0x6DD88BE: ~shared_ptr (shared_ptr.h:122)
==1807158==    by 0x6DD88BE: ~OgreDepthCameraPrivate (OgreDepthCamera.cc:31)
==1807158==    by 0x6DD88BE: operator() (unique_ptr.h:85)
==1807158==    by 0x6DD88BE: operator() (unique_ptr.h:79)
==1807158==    by 0x6DD88BE: ~unique_ptr (unique_ptr.h:361)
==1807158==    by 0x6DD88BE: gz::rendering::v7::OgreDepthCamera::~OgreDepthCamera() (OgreDepthCamera.cc:87)
==1807158==    by 0x6DD8A5C: gz::rendering::v7::OgreDepthCamera::~OgreDepthCamera() (OgreDepthCamera.cc:87)
==1807158==    by 0x6DB8BBF: _M_release (shared_ptr_base.h:168)
==1807158==    by 0x6DB8BBF: ~__shared_count (shared_ptr_base.h:705)
==1807158==    by 0x6DB8BBF: ~__shared_ptr (shared_ptr_base.h:1154)
==1807158==    by 0x6DB8BBF: ~shared_ptr (shared_ptr.h:122)
==1807158==    by 0x6DB8BBF: gz::rendering::v7::BaseNode<gz::rendering::v7::OgreObject>::RemoveChildren() (BaseNode.hh:302)
==1807158==    by 0x48B9805: gz::rendering::v7::BaseScene::Clear() (BaseScene.cc:1423)
==1807158==    by 0x48AF6B0: gz::rendering::v7::BaseScene::Destroy() (BaseScene.cc:1434)
==1807158==  Address 0xc697c60 is 0 bytes inside a block of size 34 free'd
==1807158==    at 0x484BB6F: operator delete(void*, unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==1807158==    by 0x734F21C: Ogre::Viewport::~Viewport() (in /usr/lib/x86_64-linux-gnu/libOgreMain.so.1.9.0)
==1807158==    by 0x7279354: Ogre::RenderTarget::removeAllViewports() (in /usr/lib/x86_64-linux-gnu/libOgreMain.so.1.9.0)
==1807158==    by 0x6DD841E: gz::rendering::v7::OgreDepthCamera::Destroy() (OgreDepthCamera.cc:117)
==1807158==    by 0x6E2F937: gz::rendering::v7::BaseStore<gz::rendering::v7::Sensor, gz::rendering::v7::OgreSensor>::DestroyImpl(std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<gz::rendering::v7::OgreSensor> > >) (BaseStorage.hh:956)
==1807158==    by 0x6E29B39: gz::rendering::v7::BaseStore<gz::rendering::v7::Sensor, gz::rendering::v7::OgreSensor>::DestroyAll() (BaseStorage.hh:734)
==1807158==    by 0x48BF0BD: gz::rendering::v7::BaseCompositeStore<gz::rendering::v7::Node>::DestroyAll() (BaseStorage.hh:1216)
==1807158==    by 0x48B97D3: DestroyNodes (BaseScene.cc:333)
==1807158==    by 0x48B97D3: gz::rendering::v7::BaseScene::Clear() (BaseScene.cc:1419)
==1807158==    by 0x48AF6B0: gz::rendering::v7::BaseScene::Destroy() (BaseScene.cc:1434)
==1807158==    by 0x6E5D5DC: gz::rendering::v7::OgreScene::Destroy() (OgreScene.cc:300)
==1807158==    by 0x6E2E890: gz::rendering::v7::BaseStore<gz::rendering::v7::Scene, gz::rendering::v7::OgreScene>::DestroyImpl(std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<gz::rendering::v7::OgreScene> > >) (BaseStorage.hh:956)
==1807158==    by 0x48ADCEF: gz::rendering::v7::BaseRenderEngine::DestroyScene(std::shared_ptr<gz::rendering::v7::Scene>) (BaseRenderEngine.cc:163)

Didn't I submit a PR to fix similar issues recently? I can't find it!

Ahhh it wasn't a PR
It was a patch: https://github.com/gazebosim/gz-rendering/pull/679#issuecomment-1199866379
I suspect the other problems have similar solutions.

To be more specific this part was super important:
  if (this->dataPtr->thermalInstance)
  {
    // Do not leave a reference to this->dataPtr->thermalMaterial
    Ogre::MaterialPtr nullMaterial;
    this->dataPtr->thermalInstance->getTechnique()
      ->getOutputTargetPass()
      ->getPass(0)
      ->setMaterial(nullMaterial);
  }

Because otherwise a texture would linger in a material that still exists. We need to unset the texture from that material.

To repro all this I need to checkout https://github.com/gazebosim/gz-rendering/tree/mjcarroll/ogre_depth_camera_segfault ?

To repro all this I need to checkout https://github.com/gazebosim/gz-rendering/tree/mjcarroll/ogre_depth_camera_segfault ?

That is all that is necessary.  I attempted to duplicate the patch from the thermal and wide angle cameras, but this one doesn't use the same structure to the texture/material/compositor

Valgrind is indeed finding something wrong on Gazebo side.
~OgreRenderTarget() calls DetachViewport but this has already been done in OgreRenderTexture::DestroyTarget and there are no checks either.
This stray DetachViewport call sounds like an accidental left over from either a refactor or a git merge. I'm still looking into it.

This patch fixes INTEGRATION_depth_camera:
diff --git a/ogre/src/OgreDepthCamera.cc b/ogre/src/OgreDepthCamera.cc
index 0dd31cce..b6139696 100644
--- a/ogre/src/OgreDepthCamera.cc
+++ b/ogre/src/OgreDepthCamera.cc
@@ -109,12 +109,14 @@ void OgreDepthCamera::Destroy()

   if (this->dataPtr->pcdTexture)
   {
-    this->dataPtr->pcdTexture->RenderTarget()->removeAllViewports();
+    this->dataPtr->pcdTexture->Destroy();
+    this->dataPtr->pcdTexture.reset();
   }

   if (this->dataPtr->colorTexture)
   {
-    this->dataPtr->colorTexture->RenderTarget()->removeAllViewports();
+    this->dataPtr->colorTexture->Destroy();
+    this->dataPtr->colorTexture.reset();
   }

   if (!this->ogreCamera || !this->scene->IsInitialized())
diff --git a/ogre/src/OgreRenderTarget.cc b/ogre/src/OgreRenderTarget.cc
index d7ed64af..c1f02a81 100644
--- a/ogre/src/OgreRenderTarget.cc
+++ b/ogre/src/OgreRenderTarget.cc
@@ -63,8 +63,7 @@ OgreRenderTarget::~OgreRenderTarget()
 {
   // TODO(anyone): clean up check null

-  OgreRTShaderSystem::Instance()->DetachViewport(this->ogreViewport,
-      this->scene);
+  GZ_ASSERT(this->ogreViewport == nullptr, "DestroyTarget not called!");
 }

 //////////////////////////////////////////////////
@@ -339,6 +338,8 @@ void OgreRenderTexture::DestroyTarget()
   if (nullptr == this->ogreTexture)
     return;

+  this->materialApplicator.reset();
+
   OgreRTShaderSystem::Instance()->DetachViewport(this->ogreViewport,
       this->scene);

@@ -351,6 +352,7 @@ void OgreRenderTexture::DestroyTarget()
   auto engine = OgreRenderEngine::Instance();
   engine->OgreRoot()->getRenderSystem()->_cleanupDepthBuffers(false);

+  this->ogreViewport = nullptr;
   this->ogreTexture = nullptr;
 }

OK here goes another attempt. Nothing crashes anymore, gpu_rays and lidar fail; but they don't crash:
diff --git a/ogre/src/OgreCamera.cc b/ogre/src/OgreCamera.cc
index fafc217a..76ec9469 100644
--- a/ogre/src/OgreCamera.cc
+++ b/ogre/src/OgreCamera.cc
@@ -44,6 +44,12 @@ void OgreCamera::Destroy()
   if (!this->ogreCamera)
     return;

+  if (this->renderTexture)
+  {
+    this->renderTexture->Destroy();
+    this->renderTexture = nullptr;
+  }
+
   Ogre::SceneManager *ogreSceneManager;
   ogreSceneManager = this->scene->OgreSceneManager();
   if (ogreSceneManager == nullptr)
diff --git a/ogre/src/OgreDepthCamera.cc b/ogre/src/OgreDepthCamera.cc
index 0dd31cce..b6139696 100644
--- a/ogre/src/OgreDepthCamera.cc
+++ b/ogre/src/OgreDepthCamera.cc
@@ -109,12 +109,14 @@ void OgreDepthCamera::Destroy()

   if (this->dataPtr->pcdTexture)
   {
-    this->dataPtr->pcdTexture->RenderTarget()->removeAllViewports();
+    this->dataPtr->pcdTexture->Destroy();
+    this->dataPtr->pcdTexture.reset();
   }

   if (this->dataPtr->colorTexture)
   {
-    this->dataPtr->colorTexture->RenderTarget()->removeAllViewports();
+    this->dataPtr->colorTexture->Destroy();
+    this->dataPtr->colorTexture.reset();
   }

   if (!this->ogreCamera || !this->scene->IsInitialized())
diff --git a/ogre/src/OgreRenderTarget.cc b/ogre/src/OgreRenderTarget.cc
index d7ed64af..a170e52a 100644
--- a/ogre/src/OgreRenderTarget.cc
+++ b/ogre/src/OgreRenderTarget.cc
@@ -63,8 +63,7 @@ OgreRenderTarget::~OgreRenderTarget()
 {
   // TODO(anyone): clean up check null

-  OgreRTShaderSystem::Instance()->DetachViewport(this->ogreViewport,
-      this->scene);
+  GZ_ASSERT(this->ogreViewport == nullptr, "Destroy() not called!");
 }

 //////////////////////////////////////////////////
@@ -339,6 +338,8 @@ void OgreRenderTexture::DestroyTarget()
   if (nullptr == this->ogreTexture)
     return;

+  this->materialApplicator.reset();
+
   OgreRTShaderSystem::Instance()->DetachViewport(this->ogreViewport,
       this->scene);

@@ -351,6 +352,7 @@ void OgreRenderTexture::DestroyTarget()
   auto engine = OgreRenderEngine::Instance();
   engine->OgreRoot()->getRenderSystem()->_cleanupDepthBuffers(false);

+  this->ogreViewport = nullptr;
   this->ogreTexture = nullptr;
 }

diff --git a/ogre/src/OgreThermalCamera.cc b/ogre/src/OgreThermalCamera.cc
index 508c267c..19be0544 100644
--- a/ogre/src/OgreThermalCamera.cc
+++ b/ogre/src/OgreThermalCamera.cc
@@ -291,6 +291,12 @@ void OgreThermalCamera::Destroy()
     this->dataPtr->thermalImage = nullptr;
   }

+  if (this->dataPtr->thermalTexture)
+  {
+    this->dataPtr->thermalTexture->Destroy();
+    this->dataPtr->thermalTexture = nullptr;
+  }
+
   if (!this->ogreCamera || !this->scene->IsInitialized())
     return;

diff --git a/ogre/src/OgreWideAngleCamera.cc b/ogre/src/OgreWideAngleCamera.cc
index 860dd2c1..856e244e 100644
--- a/ogre/src/OgreWideAngleCamera.cc
+++ b/ogre/src/OgreWideAngleCamera.cc
@@ -156,6 +156,12 @@ void OgreWideAngleCamera::Destroy()
     this->dataPtr->wideAngleImage = nullptr;
   }

+  if (this->dataPtr->wideAngleTexture)
+  {
+    this->dataPtr->wideAngleTexture->Destroy();
+    this->dataPtr->wideAngleTexture = nullptr;
+  }
+
   for (unsigned int i = 0u; i < this->dataPtr->kEnvCameraCount; ++i)
   {
     if (this->dataPtr->envRenderTargets[i])

@osrf-jenkins retest this please


Flaky test: ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate

Saw this test failure on Travis today. Appears to have failed this assertion:
Assert.True(aborted.Wait(TimeSpan.FromSeconds(60)));

Failed   ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate
Error Message:
 Assert.True() Failure
Expected: True
Actual:   False
Stack Trace:
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.ResponseTests.<ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate>d__64.MoveNext() in /home/travis/build/aspnet/KestrelHttpServer/test/Kestrel.FunctionalTests/ResponseTests.cs:line 2499

https://travis-ci.org/aspnet/KestrelHttpServer/jobs/252952635#L994-L1000
cc @cesarbs

Caused 2 failures of the Ubuntu mirror:

http://aspnetci/viewLog.html?buildId=290526&tab=buildResultsDiv&buildTypeId=CoreCLR_Linux
http://aspnetci/viewLog.html?buildId=290537&tab=buildResultsDiv&buildTypeId=CoreCLR_Linux

We need to prioritize fixing this test since it's causing slowdowns and manual work in build steps like the mirror.

@cesarbs please take a look.

I'm seeing this fail again and I can't tell if it's because of my changes or if it's because this test is generally flaky.

I think this test is still flaky. Just failed again.
http://aspnetci/viewLog.html?buildId=339030&tab=buildResultsDiv&buildTypeId=Lite_KestrelStressTest
The request was not aborted within the timeout period.
Expected: True
Actual:   False
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.ResponseTests.ConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate() in C:\b\w\33bdfc1cae7b2a38\.r\KestrelHttpServer\test\Kestrel.FunctionalTests\ResponseTests.cs:line 2496

And more recently: http://aspnetci/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=347655&_focus=191588

Is this still failing?

It's been long enough since this failed in dev that we can close this. If it starts showing up again we can always re-file.


undefined symbol 'Atoi'

my script as follows:
strconv = import("strconv")

index, _ = strconv.Atoi("12")
println(indx)

Thank you for handling it so quickly, later I used the strconv.ParseInt function instead which also worked.


Add support for loading files from s3

VegaFusion could support loading files from s3 compatible object storage.
The DataFusion connection would use the object_store crate as in https://docs.rs/object_store/latest/object_store/aws/struct.AmazonS3Builder.html and https://github.com/apache/arrow-datafusion/blob/main/datafusion-examples/examples/query-http-csv.rs.
The DuckDb connection would use the httpfs extension as in https://duckdb.org/docs/guides/import/s3_import.html.
In both cases, AWS credentials would be loaded from the standard environment variables, and the Vega spec could contain s3 URLs like s3://<bucket>/<path>.
This would work for VegaFusion server as well as VegaFusion Python.
In terms of implementation, the Connection.scan_* methods would need special handling for s3 urls somewhere around here for scan_csv.
https://github.com/hex-inc/vegafusion/blob/6d352b78df1a2fca4db0b9a29aae2e5283df9a43/vegafusion-sql/src/connection/datafusion_conn.rs#L144
Cross reference https://github.com/hex-inc/vegafusion/issues/87 for adding scan_parquet support, which is particularly well suited for storage on s3.

We should be able to test this locally and on CI with minio, which is available from conda-forge as minio-server

Partial implementation in progress in https://github.com/hex-inc/vegafusion/pull/417. This does not include the duckdb connection support discussed above

Polars support is possible, but would be a pretty big project. I'm hoping we'll eventually get support for Ibis, which can wrap Polars along with a bunch of other backends.

Duckdb parquet + s3 support added in 1.5.0


cannot clone with lazy doc/ directory error

        ...eutronVim/lazy/lazy.nvim/lua/lazy/manage/task/plugin.lua:84: Vim:E154: Duplicate tag "intro.nvim-colors" in file /home/daUnknownCoder/.local/share/NeutronVim/lazy/intro.nvim/doc//intro-nvim.txt

config:
return {
  "OXY2DEV/intro.nvim",
  config = function()
    local intro_status_ok, intro = pcall(require, "intro")
    if not intro_status_ok then
      print("intro not found!")
    end
    intro.setup({
      preset = "nvim_color_animated",
      animations = { delay = 0, updateDelay = 100 },
      components = {
        type = "time",
      },
    })
  end,
}

I removed the duplicate tag in the help file. I can install it via lazy now.
Can you check if the issue is resolved?
On a side note, I am currently working on changes to the plugin. So the help file may be a bit outdated(especially the presets section, as I am working on it right now).

{
  preset = "intro_animated"
}

No longer works
Use this instead
{
  preset = {
    name = "nvim",
    opts = { "animated" }
}

ok the error of lazy is gone but how do i start it?
return {
  "OXY2DEV/intro.nvim",
  lazy = false,
  event = "VeryLazy",
  config = function()
    local intro_status_ok, intro = pcall(require, "intro")
    if not intro_status_ok then
      print("intro not found!")
    end
    intro.setup({
      preset = {
        name = "nvim_color_animated",
        opts = { "animated" },
      },
      animations = { delay = 0, updateDelay = 100 },
      components = {
        type = "time",
      },
    })
  end,
}

You should do it like this
intro.setup({
  preset = {
    name = "nvim",
    opts = { "animated" }
  }
});

In case you are wondering, the start delay and frame delay don't need manual setup anymore. As they are applied by the preset.
Option merging(using a preset and normal options at the same time), no longer works. It will be added later.

bro i meant, how to get the startscreen plugin?

bro i meant, how to get the startscreen plugin?

I don't think I actually understood what you meant. Your config shows that you are installing the plugin.
Can you elaborate?

according to my config, the thing should popup on startup, but it takes me to an empty buffer, nothing on startup

no doesnt work, it doesnt open on startup

no doesnt work, it doesnt open on startup

What happens on Neovim's start?
Does it open the normal Neovim intro page?

Or does it open a completely empty buffer (with no text)?
If the buffer is completely empty run the following command
:lua print(vim.bo.filetype)

If the plugin is working it would print intro if the plugin is working and won't return anything if it isn't.

can ya open the issue?

akinsho/nvim-bufferline, lualine

can ya open the issue?
 akinsho/nvim-bufferline, lualine

It shouldn't be saying new file. Are you sure the plugin is loading?
Just to make sure the plugin is loading you can check for a command
:Gradient "111111" "ffffff" 10

See if it throws an error.

If the buffer is completely empty run the following command
:lua print(vim.bo.filetype)
returns nothing,
:Gradient "111111" "ffffff" 10
E492: Not an editor command: Gradient "111111" "ffffff" 10

in the lazy menu, i see its not loaded:
return {
  "OXY2DEV/intro.nvim",
  config = function()
    require("intro").setup()
  end
}

with this config:
return {
  "OXY2DEV/intro.nvim",
  lazy = false,
  config = function()
    local intro_status_ok, intro = pcall(require, "intro")
    if not intro_status_ok then
      print("intro not found!")
    end
    intro.setup({
      preset = {
        name = "nvim_color_animated",
        opts = { "animated" },
      },
      animations = { delay = 0, updateDelay = 100 },
      components = {
        type = "time",
      },
    })
  end,
}

i get :lua vim.print(vim.bo.filetype) is intro, but it looks like:

and the gradient command also return something

I am testing with the plugin and have found this bug too.
I will see what I can do to fix it.

I did a fresh installation of the plugin and it seems to work just fine. I thought the plugin was bugged but found nothing.
I checked the code of the plugin and it works like normal. So it can't be from there.
Here's the config I used to test.
return {
  "OXY2DEV/intro.nvim",
  config = function()
    require("intro").setup()
  end
}

I can't seem to recreate the issue.  You can check it via the :messages command.
Since the buffer is getting correctly named then the plugin is doing what it's supposed to do.
But for some reason vim.cmd() isn't doing what it's meant to.
What are you running Neovim on? And what version are you using?
The plugin is meant to work on 0.9.5 as that's what I am using.

ok i get the plugin by updating:

current config:
return {
  "OXY2DEV/intro.nvim",
  name = "intro",
  lazy = false,
  config = function()
    local intro_status_ok, intro = pcall(require, "intro")
    if not intro_status_ok then
      print("intro not found!")
    end
    intro.setup({
      preset = {
        name = "nvim",
        opts = { "animated" },
      },
      animations = { delay = 0, updateDelay = 100 },
      components = {
        type = "time",
      },
    })
  end,
}

https://github.com/OXY2DEV/intro.nvim/assets/84800625/009aba52-c3af-4e5b-9087-5d45d8e0de0e
but i dont get animation...

Just use intro.setup(). You are just setting everything up again.
The animation is happening. It's just that some other plugin or your terminal is messing with it.
For some odd reason your terminal isn't updating the screen(like it should be doing). You can see that once all the animation is finished it just jumps to the end instead of playing it.
Here's what you can do to diagnose the issue. If you are on linux go to ~/.local/share/nvim/lazy/intro.nvim/lua/intro/. Inside you will see a file named presets.lua. Open that file.
The first table(after the function) is named nvim. Go to the table and check for a property named animated. Inside it there's another property called animations.
Inside you will see this
delay = 15

It's in line 129.
Change 15 to something like 500 and open Neovim. Tell me what happens.

Just use intro.setup(). You are just setting everything up again.
The animation is happening. It's just that some other plugin or your terminal is messing with it.
For some odd reason your terminal isn't updating the screen(like it should be doing). You can see that once all the animation is finished it just jumps to the end instead of playing it.
Here's what you can do to diagnose the issue. If you are on linux go to ~/.local/share/nvim/lazy/intro.nvim/lua/intro/. Inside you will see a file named presets.lua. Open that file.
The first table(after the function) is named nvim. Go to the table and check for a property named animated. Inside it there's another property called animations.
Inside you will see this
delay = 15

It's in line 129.
Change 15 to something like 500 and open Neovim. Tell me what happens.

This is the line

Due to lack of activity, this issue will be closed.


Use local_action to ensure Ansible executes under python2

connection: local opens an SSH connection to localhost, using whatever python interpreter in env. Ansible doesn't run under python3, which a lot of distributions have as default nowadays. Using local_action executes the action from the Ansible process on the host, so it's also more efficient.

@ti-mo did you get a chance to try the patch and make sure that it works? :)

Hey @leseb, had to make this change in order to get it to run on my Arch machine. Standard py2 on py3 error:
failed: [nsg-os-ceph-01] => {"failed": true, "parsed": false}
  File "/home/timo/.ansible/tmp/ansible-tmp-1435935120.5-246786600187704/command", line 738
    except OSError, e:
                  ^
SyntaxError: invalid syntax

failed: [nsg-os-ceph-02] => {"failed": true, "parsed": false}
failed: [nsg-os-ceph-03] => {"failed": true, "parsed": false}
  File "/home/timo/.ansible/tmp/ansible-tmp-1435935120.5-170258903166995/command", line 738
    except OSError, e:
                  ^

Ok sounds reasonable to me :) thanks!


Overwrite the some params with record

Sometimes I want to overwrite the params such as "severity"
This patch makes it possible.
If the record does not contain "severity" or "facility", it will works as usual

Thanks! A new version will be release.


Introduce metered container

Motivation
When looking for the performance of the storage, the solution is a metered wrapper. This is introduced
here and implemented for RocksDb, ScyllaDb and DynamoDb.
Proposal
The following was done:

Introduction of the MeteredStore and proof of conservation of ReadableKeyValueStore, etc.
Unfortunately, I could not address the DirectWritableKeyValueStore because of a mysterious lifetime issue.
Implementation for RocksDb, ScyllaDb, DynamoDb. It is controlled by the "metrics" feature
The metric is done for the original container, but also for the LruCaching and ValueSplitting ones.

Test Plan
The CI does not change, but the use has to be checked.
Release Plan
That should be used by developer mostly.
Links

reviewer checklist

@MathieuDutSik Still in the summary:

Unfortunately, I could not address the DirectWritableKeyValueStore because of a mysterious lifetime issue.

I believed you solved this issue, right?

@MathieuDutSik Still in the summary:

Unfortunately, I could not address the DirectWritableKeyValueStore because of a mysterious lifetime issue.

I believed you solved this issue, right?

No, I did not. However, I consider that this is not blocking for merging the PR.


Fixing typos

Fixed one typo in credstash.py and seven typos in README.md. (Line 17 of the README replaces "an" with "and"; "it's" with "its")

:+1:


Other Expenses Screen Order

The form will ask the user if they have any other expenses that they would like to record, aside from the expenses that the form explicitly asks for. We have had two ideas about where to put this screen after we implemented the checkboxes into the "expenses" questions. The first option would be to add the "other expenses" as an optional button for the checkboxes and then conditionally ask the user about their other expenses at the end. The second option would be to not include an "other expenses" button and automatically ask about their other expenses at the end.
The third thought of ours was to add a "review" screen that shows all of their expenses, including the ones they did not check off, and allow them to edit/add other expenses on that screen.

idea: after user selects expenses categories, show them what they selected, then ask if any other expenses, for example diapers.
After this, ask for amounts.


Refactor BaseObject

Goal
Refactor BaseObject to be able to change the architecture.
How to test
Run all tests.

 [Nova UI] Refatorar BaseObject


MSX1 and MSX2 scrapes data from wrong platform

I have scraped data from ScreenScraper.fr for MSX1 and MSX2 system but 99% of information where not found. Data for almost every game are avaible on ScreenScraper.fr.
After analyzing the few games it scrapped I'm almost sure that when connecting to ScreenScraper.fr MSX1 scraped data from MSDOS repository instead of MSX1 repository, and something similar is happening for MSX2.
To reproduce the bug, in MSX try scraping with string Knightmare, you will find that it is downloading MSDOS picture and not the MSX1 one. Another way to reproduce it is this... try input the string Hook, a game does not exist for the MSX, it results displaying Hook MSDOS game.

Not an EmulationStation issue.  Needs to be fixed in the batocera.linux repository.


Fix datasource selection

Hey.
This should fix #51 and #139. But beware that I'm a total Grafana dashboard noob. ^^
In my tests however it seems to be working, and even the Host: field is updated depending on the chosen datasource.
But better try and verify before merging.
Cheers,
Chris.

Oh and see als https://github.com/rfmoz/grafana-dashboards/issues/51#issuecomment-1828960572 ... with the thing about the 00000001 UIDs.

@rfmoz Could you possibly have a look and review this (and merge it if it's well enough)? :)

Thanks for the update and the reponses in other issues. It seems to work great!


Adding in parameters for using a proxy host connection

validation logic to move to validator class
increment version in pom.xml

@vamshi-sfdc Do you recall the name of the validator class? It doesn't jump out at me?

@pauldavidchristian  : Validator classes for the arguments are in the package com.sforce.cd.apexUnit.arguments. Please follow PercentageInputValidator class; you need to implement IParameterValidator for the JCommander framework to execute the validation method for a given command line argument

@pauldavidchristian : After looking at your validation code, I feel you can use PositiveIntegerValidator validator class . Please use the "validateWith" option in the parameter definition and mention the validator class

@adarsh-ramakrishna-sfdc Changes are in. Please let me know if you see anything else.


Fix cross compilation

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wolfv @xhochy I've trouble for making cross-compilation working properly on my setup for osx arm architecture.
When looking at the azure ci, it appears that for this specific build, the path to numpy is given by:
-- checking for numpy
--   NUMPY_INCLUDE_DIRS=$BUILD_PREFIX/venv/lib/python3.9/site-packages/numpy/core/include
--   NUMPY_VERSION=1.19.5

Do you know whether it could be rather pointing to: $PREFIX/venv/lib/python3.9/site-packages/numpy/core/include?
Thanks in advance for your help,
Best,
Justin

In fact, the question is rather why Numpy has been installed in $BUILD_PREFIX/venv/lib/python3.9/site-packages/numpy/core/include?

In fact, the question is rather why Numpy has been installed in $BUILD_PREFIX/venv/lib/python3.9/site-packages/numpy/core/include?

Because it is listed as a build dependency and that is OK.
I think the correct fix would be to explicitly set -DNUMPY_INCLUDE_DIRS=${SP_DIR}/numpy/core/include in the cmake call.

Because it is listed as a build dependency and that is OK.

OK as in we need that for the cross-python magic to work.

In fact, the question is rather why Numpy has been installed in $BUILD_PREFIX/venv/lib/python3.9/site-packages/numpy/core/include?

Because it is listed as a build dependency and that is OK.
I think the correct fix would be to explicitly set -DNUMPY_INCLUDE_DIRS=${SP_DIR}/numpy/core/include in the cmake call.

I've tested that but it appears that the path does not exist on the build machine, while eigenpy needs it for compiling.

Should I perform a symbolic link?

It's a bit spooky that ${SP_DIR}/numpy/core/include doesn't exist as the same path exists in the build environment. Otherwise this looks fine.

It's a bit spooky that ${SP_DIR}/numpy/core/include doesn't exist as the same path exists in the build environment. Otherwise this looks fine.

@xhochy Seems to work finally. Thanks for your help.


Proposal: XWS ids

Added a proposal for XWS ids.
Ids are generated as follows:

Take the English-language name as printed on the card
Lowercase the name
Convert non-ASCII characters to closest ASCII equivalent (to remove umlauts, etc.)
Remove non-alphanumeric characters
Check for collisions; If there’s a collision add a numeric identifier. (sabinewren -> sabinewren-2)
Check for collisions; If there’s a collision increase the numeric identifier until there is no collision. (sabinewren-2 -> sabinewren-3)

Initial ordering has been done as follows:

Order alphabetically by ship name
Order by initiative
Order alphabetically by pilot name

@sirjorj, @mu0n: As we discussed on Slack. Let me know what you think

Looks good everything breaks on September 13th

Since there are already collisions to deal with (I think?), then populate this list by order of 2.0 SKU?

The SKUs for the conversion kits have a lot of pilots that get added at once.  I'm not sure that idea will hold up.
Here's a more heavy handed idea:

Factions can be reduced to a 2 character code (RB, IM, SC, FO, RS).
The dials have a 2 or 3 character ship code
Pilot name gets the same treatment as xws

Ex: IMTFhowlrunner or IM_TF_howlrunner - something like that.
This would NOT handle the 1.0 Poe Dameron scenario, but I highly doubt that will translate to 2.0.  Just in case, maybe it wouldn't hurt to include initiative in the scheme anyway (IM_TF_5_Hownrunner).  That could make the default ordering pretty convenient.
Does that seem reasonable or is it overkill?

Eli's thoughts on a UNIQUE PILOT KEY:
add a new key:value inside each pilot
where key="xws2"
value="faction-ship-pilot-sku" (but where -sku is optional and only needed in case there's a collision)
e.g. galacticempire-tielnfighter-howlrunner
and applying the same logic to 1st edition's Poe Dameron ps9, we'd have gotten
resistance-t70xwing-poedameron-swx57
My own additional thoughts:
missing JSON properties
per pilot:
List actions
List conditions
suggested faction names:
rebelalliance
galacticempire
scumandvillainy
firstorder
resistance
galacticrepublic
separatistarmy

another key:value to add to every pilot:
"shipability":"description"
see: http://xhud.sirjorj.com/xwing.cgi/pilot2?pilot=autopilotdrone&faction=scum&ship=escapecraft
vs
http://xhud.sirjorj.com/xwing.cgi/pilot2?pilot=outerrimpioneer&faction=scum&ship=escapecraft
as an example where 2 pilots of a single ship type can have different ship abilities

This was replaced by https://github.com/guidokessels/xwing-data2/pull/20 after discussions on Slack.


Release 4.9.3

Spec updates
Stone Updates
Test fixes

Thank you! Make sure you re-generate the nuget package after fixing the typo!


feat: add @manytomany directive

Description of changes
This PR adds a new @manyToMany directive.
Note to simplify reviewing this, the first six of the seven commits are #8035, so only the last commit needs reviewed here.
Issue #, if available
Description of how you validated changes
Manual, unit, and E2E testing.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8195 (c37f0ba) into master (f3044ee) will increase coverage by 0.13%.
The diff coverage is 93.70%.

@@            Coverage Diff             @@
##           master    #8195      +/-   ##
==========================================
+ Coverage   54.42%   54.55%   +0.13%
==========================================
  Files         663      664       +1
  Lines       37872    37990     +118
  Branches     7786     7792       +6
==========================================
+ Hits        20611    20725     +114
- Misses      16416    16420       +4
  Partials      845      845

Impacted Files
Coverage Δ

...mation/src/graphql-transformer/transform-config.ts
8.00% <0.00%> (ø)

...rc/graphql-transformer/transform-graphql-schema.ts
15.12% <16.66%> (-0.15%)
:arrow_down:

...plify-graphql-relational-transformer/src/schema.ts
94.28% <83.33%> (-1.07%)
:arrow_down:

...ransformer/src/graphql-many-to-many-transformer.ts
100.00% <100.00%> (ø)

...mplify-graphql-relational-transformer/src/index.ts
100.00% <100.00%> (ø)

...mplify-graphql-relational-transformer/src/utils.ts
100.00% <100.00%> (ø)

...-transformer/src/graphql-searchable-transformer.ts
96.34% <100.00%> (ø)

packages/graphql-auth-transformer/src/resources.ts
92.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3044ee...c37f0ba. Read the comment docs.


Release 3.0.1

fix(pencil): update README & test new environment
This will start the samantic-release process and should (might not do to no functional code changes) result in:

Bumping the version to 3.0.1
creating a Release on github with that version tag
create notes/changelog
Publishing that version tag to NPM

If I understood it correctly, I think the contents of the fix(...) parentheses are supposed to be what you fixed... at least, that's how I interpreted the example of fixing the design of the pencil.

Ahh, you are probably right. I wonder if it uses that as part of the analyzer or more for the notes it generates. I don't think it will cause a big problem here, but I could try to change the commit message.

:tada: This PR is included in version 3.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


AKD Quorum distributed change auditor

Overview
To prevent a split-view attack the root hash of every epoch needs to have a signature signed by a private key which cannot be leaked from the quorum (via shared-secret methodology). This quorum participates to independently validate the append-only proof of the key directory and each participant provides their partial shard of the quorum signing key and when enough participants agree, the changes are signed off on and stored in persistent storage.
That way a proof only needs to give the root hash, and the signature on it to ascertain the quorum has agreed on the changes, and the AKD (or any other 3rd party) cannot generate its own signatures.
Eventually these auditors can be participants from external entities who can participate in the quorum vote.
Requirements

The Quorum Key (QK) is long-lived and securely managed such that individual (or a few) participants cannot generate their own signatures and invalidate the trust of the system
The quorum participants can evolve over time (i.e. removal in the face of failures, and additions for future collaborative growth or upgrades).
Communication channels are secure, such that 3rd parties cannot sniff the key shares over the wire and compromise the QK.
The public key of the QK is publicly distributed such that it's easy to client-side validate the validity of the epochs without additional I/O operations to a potentially malicious acting key directory.

Initial design overview
A Quorum Key is generated at the beginning of the life of the quorum, and the private key is broken into "shards" via Shamir secret sharing.
These shards are transmitted to the quorum participants who hold them in secure storage. The shards are generated with the following properties

There are 3 f + 1 nodes in the quorum
2 f + 1 nodes need to agree to reconstruct the signing key (quorum key)
The public key is given publicly to every client which will need to verify the signature

Communcation with the quorum
The collection of nodes in this quorum receive commands from an external 3rd party (key directory epoch notification or admin interface for example).
The messages they can receive are the following

New epoch publication - The AKD has published a new epoch and the quorum should validate the changes and generate a signature
Quorum member enrollment - The quorum should attempt to add the new member to the set. A series of independent tests will be
performed against the new member and if they pass, a new shard-set will be generated and the node enrolled
Quorum member removal - The quorum has a member which should be removed. If 2 f + 1 nodes agree, the Quorum Key is reconstructed and new shards are generated and
distributed to the remaining membership.

For any of these messages, whichever node receives the request is denoted as the leader. We do not need the full RAFT
protocol, since we have no need for a persistent leader and the nodes are effectively stateless in between operations.
The temporary request leader is responsible for communicating with the other quorum members and gathering
their votes, reconstructing the shards, and either signing the commitment or enrolling the new member (re-generating shards and transmitting them).
Inter-node messages:

Vote - args: (proof and hash information)
a. Reply: Success(shard) or Failure (errors)
Generate enrollment test - args: (member information, public key, etc)
a. Reply: A "test" of enrollment for a new quorum member, with the result temporarily stored in the local machine
Process enrollment test result - args: (member reply to specific proof)
a. Reply: If test successful, return the shard to the "leader". If not, return failure and don't disclose the shard
Remove member - args: (node_id)
a. Reply: Agree(shard) or Disagree (error)
Update stored shard - args: (new_shard, commitment_over_shard_signed_by_quorum_key)
a. We need to provide a commitment, so the membership doesn't replace shards with invalid information which is potentially a different quorum key and
corrupting the quorum

Retrieval of the latest commitment
Since the public key is available to anyone who cares, external parties can read directly from the storage layer to minimize I/O to the quorum, as they
will likely be resource constrained with validating the commitments between epochs and processing membership changes.
NOTE: If the storage layer is mutated directly, then the quorum will start failing commitments and signatures will not match so the system fault will be detectable.

Closing this issue since it is not something we are pursuing at the moment. But the notes + linked PRs here are excellent to base off of if we revisit this in the future


Try a new build for 0.13.1

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge/core, something seems to be amiss with the CircleCI configuration.  We recently switched from noarch to py3k only.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Yep we're working on it.

All green, good to merge?

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


Create a formula-testing spreadsheet with dummy data

As we iterate on the google spreadsheets we use for assembling the website index, it would be helpful to have a duplicate spreadsheet that has very small data sets (5-20 URLs each) that I can use to experiment with formulas

done


Editor parameter isn't respected

Hi,
Sorry to bother you (again).
I'm not sure if it's my system problem (NixOs is a really strange distro) or if -e nvim, -e=nvim, --editor nvim or --editor=nvim is overridden by $EDITOR (nano)

markx overrides --editor options by EDITOR environment variables. This is specifications of markx.
Please try this command (bash) if you want to remove EDITOR environment variables.
unset EDITOR

Ah..., I will change --editor and EDITOR priority.

Try this.
markx -e nano -c 'echo {}' 1 2 3
markx -e nvim -c 'echo {}' 1 2 3


Implement shard_spaces related api calls

relevant upstream Issue: https://github.com/influxdb/influxdb/issues/571

We focus on 0.9 support, so no additional effort will be made for 0.8 related stuff


Update logic for detecting if the output stream is connected to a terminal

https://github.com/remkop/picocli/issues/2083

Thank you for raising this! Overall the PR looks good, please look at the minor change I requested to find the Console class via reflection.

Merged. Thank you for the contribution!


Script Variables in Inspector is not work when script had extends other script

Value that we edit will return to the beginning when we save scene or play the scene.
And if had export variable in a parent script, Script Variables section will be disappear from Inspector when save or play the scene too.

Actually a duplicate of #582.


🌵 Fix README.md

🥴 What do you want to do?

I want the README to be more stylish
And I want to add "table of contents" field first and badges

🐌 Purpose

for noticing Volcano's details to the world

🎩 Images
Nothing

🌋 TODOs

[x] fix README.md in a stylish way


Add treatment info for patient to data

[x] Add an additonal row per patient, to confirm (= 1) if a patient underwent treatment during the time of measurement; unclear or unknown treatment status (= 0 )?
[x] Include treatment info in heatmap
[x] Include treatment info in Table 2 manuscript

53a67fc


Resharper plugin for Visual Studio 2017?

Hi,
I recently moved to visual studio 2017 and I'm not able to find the plugin in resharper's gallery
What are the plans on releasing an updated plugin for this version of VS?
Thanks,

Yes, a new version will be released soon, but probably closer to the RTM date.

Assuming you mean RTM 2017.1 for R# (As VS'17 is now in the wild). Looking forward to it :)

All updated, should be available in the extension manager.

Thanks!!


Add partial Korean translations

This PR adds partial Korean translations only with strings used in the output documentation.

Thank you!


[BugFix] Fix union isnullable error

Fixes #issue
For SQL:
SELECT t1.c_1_0
FROM t1
RIGHT JOIN t0 ON t1.c_1_0 = t0.c_0_1
UNION ALL
SELECT t1.c_1_0
FROM t1
RIGHT JOIN t0 ON t1.c_1_0 = t0.c_0_1

t1 must empty table, the optimizer will trans SQL to
SELECT NULL
FROM t0
UNION ALL
SELECT NULL
FROM t0

the union set output expr's isnullable error
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 8 / 8 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
8
8
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 9 / 9 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
9
9
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.2


Allow subfolders in the Actions folder

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Sometimes it can useful to be able to organise actions into subfolders. Fastlane already supports this, in fact the actions that live in a subfolder of the actions folder are found and used.
The only issue is that they are not shown in the initial dashboard and, if there are no actions in the root Actions/ folder, a warning is shown at every run.
Description
This change makes Fastlane look for actions also in subfolders of the action folder when the plugin is discovered and loaded by considering all the folders that have /actions in the path and not only the ones that have it has the last part of the path.

What do you refer to by "initial dashboard"?
Any documentation to update?

What do you refer to by "initial dashboard"?

Oh, sorry I wasn't clear. I mean the message that is shown when fastlane starts.
This one:
+-----------------------------------+---------+----------------------------------------------------------------------------------------+
|                                                             Used plugins                                                             |
+-----------------------------------+---------+----------------------------------------------------------------------------------------+
| Plugin                            | Version | Action                                                                                |
+-----------------------------------+---------+----------------------------------------------------------------------------------------+
| fastlane-plugin-XXX                          | X.Y.Z   | No actions found                                                                       |
| fastlane-plugin-YYY                          | XX.YY.ZZ   | action_1 action_2 action_n  |
+-----------------------------------+---------+----------------------------------------------------------------------------------------+

[!] No actions were found while loading one or more plugins
    Please use `bundle exec fastlane` with plugins
    More info - https://docs.fastlane.tools/plugins/using-plugins/#run-with-plugins

Any documentation to update?
I don't think. The actions are not shown in that table, but if you then call them they work flawlessly, so this PR doesn't change any actual behaviour.


iiiftilesource.js only fetches jpg images regardless of format quality

Hi all,
I noticed that iiiftilesource.js is hardwired to grab only a jpg representation of an image, regardless the actual format(s) specified in the "qualities" attribute from info.json.
see lines 235-8: https://github.com/openseadragon/openseadragon/blob/dfe465f79e8b45f4522a747d5ac5627230825c6b/src/iiiftilesource.js#L235
is this a known issue?  we are able to work around it if necessary.
thanks,
-c

I don't think it's known. Would you be up for writing a fix for it?
@jpstroop @azaroth42 Any thoughts?

@azaroth42 mentioned last night in another thread that IIIF doesn't support other formats, so I'll just close this bug. Thanks, though!

It's a known non-issue, as all IIIF compliant systems are required to support the jpg format (along with other non-mandatory formats).
References:

http://iiif.io/api/image/2.0/compliance.html#format
Discussion issue in IIIF:  https://github.com/IIIF/iiif.io/issues/449
iiif-discuss post: https://groups.google.com/forum/?hl=en#!topic/iiif-discuss/3VDEu1rFIEs
Original mirador issue: https://github.com/IIIF/mirador/issues/517


Marten needs to warn users that you can't use calculated indexes on DateTime or DateTimeOffset

A user had trouble with this, but it's working just fine in our tests. I'm closing this.


HPCC-29973

Copy over the content from Attila Vamos' OBT repository to the HPCC Systems one.

@AttilaVamos

@jakesmith please check and merge.

Do we actually want OBT to be part of the community repository and not in its own repository?
That was the original idea, in fact an empty repository was created for that purpose a while back : https://github.com/hpcc-systems/OBT
@ghalliday - what's your view on this?

@AttilaVamos do you want to transfer the OBT repo to hpcc-systems instead of copying the files in one commit.  The difference is whether you retain the commit history or not.

@AttilaVamos closing because there is no response to the question.  Transferring ownership may be a better idea.

Closing


driver: print maximum memory usage on macOS

What are the reasons/motivation for this change?
Yosys on macOS doesn't print peak memory usage, even though the resource usage API should provide it anyway, except it's in bytes, not kilobytes.
Explain how this is achieved.
Adjust ifdefs and divide max resident memory usage by 1M
If applicable, please suggest to reviewers how they can test the change.
$ yosys -p "read_verilog invert.v"
where invert.v is
module invert_n_times #(parameter N = 100000) (
    input wire in,
    output wire out
);
    wire [N:0] intermediate;

    assign intermediate[0] = in;

    genvar i;
    generate
        for (i = 0; i < N; i = i + 1) begin : invert_loop
            assign intermediate[i+1] = ~intermediate[i];
        end
    endgenerate

    assign out = intermediate[N];
endmodule

on my Linux machine prints End of script. Logfile hash: a63152f4f6, CPU: user 3.40s system 0.18s, MEM: 637.87 MB peak. If the memory usage reported is now similar on a macOS device, the PR does what it's supposed to

Works for me 👍
End of script. Logfile hash: 817291f8eb, CPU: user 2.58s system 0.07s, MEM: 502.66 MB peak
Yosys 0.44+20 (git sha1 4847caac4, clang++ 18.1.8 -fPIC -O3 -flto=thin)
Time spent: 100% 2x read_verilog (2 sec)


Invalid target condition in .csproj

What is the idea of using condition And !Exists('wwwroot\dist') in .csproj ? If I change smth in my code, the source in wwwroot\dist will not change because of this condition.
Also If I execute dotnet run after dotnet publish I will have a production build in my wwwroot\dist folder.
Maybe it's better to use:
 <Target Name="DebugRunWebpack" BeforeTargets="Build"       Condition=" '$(Configuration)' == 'Debug'">
instead of
 <Target Name="DebugRunWebpack" BeforeTargets="Build"       Condition=" '$(Configuration)' == 'Debug' And !Exists('wwwroot\dist')">
Thanks

You are ignoring that we have a bunch of build commands in the package.json. If you forcibly want to re-compile your stuff in the wwwroot, you can do many different commands to do this, basically, if you use either:
npm run build:dev
or
npm run build:prod
These should both recompile all of the files you are asking for. The reason that is in the csproj, is so

you don't have to restart in order to rebuild
so that startup is much faster.


Auto Effects:  Bite(Wolf)

The monster "Wolf" imports with a bite that just needs to have prone added to it so it applies it via midi transfer.  I just used the wrench and added prone there as the simplest, but make sure you set a duration on the Item of SPECIAL and then set a duration in the ae of -1 in seconds so that it goes permanently passive.
Here is a link to the item showcase of it on posney's discord.  https://discord.com/channels/915186263609454632/1170378998602289283/1170378998602289283

You could follow this same pattern for all the dogs, I think mastiff/sled dog also have this.

Hmm, this should already be adding this effect so I will find out what's gone wrong

Hmm, this should already be adding this effect so I will find out what's gone wrong

I think I might have gotten my wolf from the adventure muncher and it may not have given me the auto effects version


HTML / JSON injection issue with languages

Evalhalla-designer's parser is incorrectly adding HTML when generating JSON.
Language tags ('/en', '/fr') replacement is supposed to happen for HTML generation, however it is also happening for JSON generation.

This is fixed with the CORTEX json format. When we start consuming Kafka messages we should be able to avoid the issue, or be able to render straight from the payload


I appreciate you!

Thank you for this pwa notification demonstration and am very happy you provided your sources which is a great inspiration for me too.

Thank you for your kind words!

Please create a discussion on the repo, well I don't know how that works but couldn't find it.

Here we go!
https://github.com/webmaxru/push.foo/discussions/2


resource_type not defined correctly for manifest v11

In the manifest v11, resource_type parameter for ModelNode is defined as Any here. Due to this the actual value from manifest.json maps as a str type in pydantic model.
In the previous manifest v10,v9 this used to be mapped as an enum in python. Example here and here
This is causing dtype mismatching while processing the v11 manifest.
Solution would be to convert the v11 resource_type attribute to enum instead of any
@yu-iskw

@OnkarVO7 Thank you for raising it. I want to address the short-term solution and the mid/long-term solution. What do you think?

Short-term: Let's tentatively, manually replace them. As we automatically generate the pydantic classes from the manifest JSON, we have to manually catch up with changes in dbt Core.
Mid/Long-term: I will make a proposal to improve the JSON schema of manifest v11 to dbt Core so that we can automatically generate the pydantic class with the desired data type(s).

Thanks @yu-iskw that sounds good.
For long term, definitely a generalised approach would help in maintaining the manifest versions.

@OnkarVO7 I don't have much time to solve the issue. Can you address the short-term solution on behalf of me?

@OnkarVO7 let's take a look at this and see if we can help fix it


How Do I Get The Music Bot To Automatically Skip Private YouTube Videos in A Playlist

I Have The Bot Run Continuously, How Do I Make It Skip Private Videos in A YouTube Playlist Automatically Without Giving an Error.

Private YouTube videos shouldn't cause the bot to crash.


Possession

See comments from https://github.com/dbjorge/jorbs-spire-mod/pull/511 - mixup with local branch names, this one has all the comments that were requested by brosmike in first one.


Tempo and pitch on Windows/Android

Some platforms/systems use a sampleRate of 48000. This results in faster, higher pitched play back. The fix is to use the sampleRate from the audio context:
_loadSong(midiBuf) {
	const optsPtr = this._lib._mid_alloc_options(
		this._audioContext.sampleRate || DEFAULT_SAMPLE_RATE,
		AUDIO_FORMAT,
		NUM_CHANNELS,
		BUFFER_SIZE
	)

I saw this too in bitmidi.com and another site that used this API.
I never thought the results of browser code would be OS-dependent.


Modified color not updating till I resource my vimrc

Every time I open a new instance of vim, Airline is not correctly updating the "modified" color in the bottom status bar. It solves when I resource my vimrc. How do I debug this?

did you modify your vimrc in between?

Nope, same vimrc when I resource it.


travis: test against different Symfony versions

Just realized it allows Symfony 3, but with no proof
Inspired https://github.com/KnpLabs/KnpSnappyBundle/pull/119

Close due to no response timeout.


Selection color

The selection color is still magenta
Can the selectionColor preference altered to match up with the cursor color?

Solved!


[stable/filebeat] set default config empty

Signed-off-by: Taehyun Kim<EMAIL_ADDRESS>
What this PR does / why we need it:
#12199
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes filebeat's #12199 issue

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @sstarcher

So by default this will do pretty much nothing.  Any reason you could not override the values that you want?  I don't believe setting the default setting to be useless is a good move and we should consider something else.

https://github.com/helm/helm/issues/5184 if working properly means you can override the output.file to null "remove" it but it doesn't seem to be working properly. If this worked properly you most likely wouldn't need to have empty configuration?

@sstarcher prospector was deprecated since 6.3, and deprecation warning log is printed in this chart.
Setting filebeat.prospectors as null or empty list [] couldn't unset prospectors, so filebeat.inputs can't be used.

That's fine so this configuration should take a different tact.  We should not wipe out the default config.
Possibly a new option
overrideConfig: |
  Whatever random config you want

If overrideConfig is set use it and don't use the default at all.
My concern with these changes is you are breaking everyone and the default configuration for this chart is basically useless.  Why don't we try and find a way to make both a reality.

@kimxogus when the bug for “null” works properly what issue will that not fix?

@sstarcher overrideConfig seems like a good solution :)
Added overrideConfig as suggested.

/ok-to-test

merged master

fixed conflicts. @sstarcher can you please review?

/lgtm


XML syntax - invalid character entity & (no semicolon) -

Hi
I tried with this version : 1.4.4 and V2.
I get this error when I save the XMLTV file :
[xTeVe] [ERROR] XML syntax error on line 36: invalid character entity & (no semicolon) -
if we find this character &, I get the error.
In order to do a test, I downloaded the m3u file and I minutely removed all the lines having an & (title or URL), all with the same result.
I tried this browser : Chrome, Edge and FireFox.
thanks

XML and m3u are two different things.

You're right. Thanks

Ran into the same issue - would be great if xTeve accepted the special characters. If it were possible.


cloudfoundry-cli: 8.7.8 -> 8.7.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/cloudfoundry-cli/versions.
meta.description for cloudfoundry-cli is: The official command line client for Cloud Foundry
meta.homepage for cloudfoundry-cli is: https://github.com/cloudfoundry/cli
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.7.9 with grep in /nix/store/3c4kv2xk8w4iad11jac3xrww2zaipd2z-cloudfoundry-cli-8.7.9
found 8.7.9 in filename of file in /nix/store/3c4kv2xk8w4iad11jac3xrww2zaipd2z-cloudfoundry-cli-8.7.9

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cloudfoundry-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3c4kv2xk8w4iad11jac3xrww2zaipd2z-cloudfoundry-cli-8.7.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cloudfoundry-cli https://github.com/r-ryantm/nixpkgs/archive/f182ef3a4f7735594d7b46dfa000878d5aaa2611.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f182ef3a4f7735594d7b46dfa000878d5aaa2611#cloudfoundry-cli

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3c4kv2xk8w4iad11jac3xrww2zaipd2z-cloudfoundry-cli-8.7.9
ls -la /nix/store/3c4kv2xk8w4iad11jac3xrww2zaipd2z-cloudfoundry-cli-8.7.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

cloudfoundry-cli

Maintainer pings
cc @risicle for testing.

Result of nixpkgs-review pr 298606 run on aarch64-darwin 1

1 package built:

cloudfoundry-cli


Auto login(skip login page) for ADFS and identity server 4

Hello Guys,
Just wondering if anyone can help me with this question on StackOverflow: https://stackoverflow.com/questions/59731578/auto-loginskip-login-page-for-adfs-and-identity-server-4
Thanks in advance

StackOverflow is a more appropriate place for your question.
If you or your company need commercial support, please see here for more information.
Thanks!


EIP-2333

This is just a question.
The KeyGen function directly derive a secretKey from a seed and optional parameters. I guess this might be compliant with EIP-2333, but not very sure.
Would anyone please confirm it does, or how we derive masterKey and child keys with the provided functions? Thanks.

The keygen is compliant with H2C keygen spec not EIP2333.
You need to build your own EIP2333 key generator.
You can find my implementation here: https://github.com/status-im/nim-blscurve/blob/7e8de1e/blscurve/eth2_keygen/eth2_keygen.nim
You will need to recreate HKDF mod r as BLST does not expose it it's internal https://github.com/status-im/nim-blscurve/blob/7e8de1e/eth2_keygen/hkdf_mod_r_blst.nim#L83-L127

If there is wider interest/demand, it can be added... There is a caveat though. One of the project's goal is to validate the implementation, and the scope is mostly fixed by now. Or in other words, such add-ons won't be validated.

Looking forward to seeing the EIP2333 implementation added in.
On Thu, Mar 11, 2021 at 11:40 PM Andy Polyakov @.***>
wrote:

If there is wider interest/demand, it can be added... There is a caveat
though. One of the project's goal is to validate the implementation, and
the scope is mostly fixed by now. Or in other words, such add-ons won't be
validated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/supranational/blst/issues/60#issuecomment-796828089,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPN5SZFWG2XJ6PSL7XHBLDTDDQAPANCNFSM4XZOIV5A
.

We could really use EIP2333 support as well.

Added blst_derive_master_eip2333 and blst_derive_child_eip2333.


fix: change Header::nonce to B64

Motivation
It was changed to u64 by accident probably, this nonce is not the same entity as transaction nonce (it is a hash, not a number), and it is reported by RPC as a 8-byte hex string
Solution
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

hmm this is also u64 in reth https://github.com/paradigmxyz/reth/blob/main/crates/primitives/src/header.rs#L76-L78 , not sure we should change this to B64?

yeah not sure if this should actually be u64 in consensus types
it was B64 in rpc-types and reth is currently pinned to alloy commit which has it as B64 in rpc_types::Header: https://github.com/alloy-rs/alloy/blob/6aab2164b92c3174cdd81fcb403177361338e594/crates/rpc-types/src/eth/block.rs#L104

The spec defines it as bytes8 so it should definitely by serialized/deserialized as B64 https://github.com/ethereum/execution-apis/blob/90a46e9137c89d58e818e62fa33a0347bba50085/src/schemas/block.yaml#L72


close connection with 'finally'

Hi,  :-)  close connection with 'finally' .

Let me take a look :)

Looks good to me. Sorry for the delay.


Sandbox bash scripts used in tests

Currently, cargo test readme extracts BASH scripts from readme files and run them without sandboxing. This is ok but also a bit scary. We may want to use some (light) sandboxing depending on the execution platform.
https://github.com/containers/bubblewrap
https://www.karltarvas.com/macos-app-sandboxing-via-sandbox-exec.html
https://github.com/ocaml/opam/blob/master/src/state/shellscripts/sandbox_exec.sh

Maybe we could sandbox all our tests?  Rust code is no less capable than bash code of wreaking havoc :)


Load_Daily_Data: Add more output info for failed scenarios

When there are scenarios mismatch, this will now show the expected and actual results in the output.
This PR is for merging with the latest tag v0.9.6-perf.  You can compare the difference here:
https://github.com/cfpb/owning-a-home-api/compare/cfpb:v0.9.6-perf...amymok:add-info-failed-scenarios
Changes

Added expected and actual results for message output

Review

@fna

@amymok looks like our tests that review the output started failing because the output changed


Fix mongoid test failed problem

The problem is mongoid tests are failed due to a validation error. Like this.
  1) Error:
DatabaseAuthenticatableTest#test_should_not_mutate_value_assigned_to_string_whitespace_key:
Mongoid::Errors::Validations:
Problem:
  Validation of User failed.
Summary:
  The following errors were found: Email is already taken
Resolution:
  Try persisting the document with valid data or remove the validations.
    mongoid (4.0.2) lib/mongoid/persistable.rb:78:in `fail_due_to_validation!'
    mongoid (4.0.2) lib/mongoid/persistable/savable.rb:45:in `save!'
    /home/travis/build/plataformatec/devise/test/models/database_authenticatable_test.rb:55:in `block in <class:DatabaseAuthenticatableTest>'

All log I run on Travis CI is here.
When using mongoid, test data is preserved. ActiveRecord is no problem. It seems like Mongoid.purge! is not working.
Getting namespaces in collection_names
namespaces = self["system.namespaces"].find(name: { "$not" => /#{name}\.system\.|\$/ })

return [].
My solution session drop is a little slow, and It might be moped's problem. So, it might not be the best way.

The build time on travis looks the same, so even that it is slow I prefer the tests to be green than faster. We can fix forward if we need to. Thank you so much for looking on this.


Migrate Meshery Adapter Play to Functional Component with MUI v5 Styling and Sistent Component use. Fixes issue: #12119.

Migrate Meshery Adapter Play to Functional Component with MUI v5 Styling and Sistent Component use #12119
Notes for Reviewers
This PR fixes #12119
Signed commits

[ ] Yes, I signed my commits.

@SankarshanMishra thanks
Could you update properly the PR title to match what it does. Fix issue XXX don't give any details or context until we are going and open the issue.

@SankarshanMishra thanks
Could you update properly the PR title to match what it does. Fix issue XXX don't give any details or context until we are going and open the issue.

Done.

Thanks again @SankarshanMishra !
Once you incorporate the sistent components, tokens and styling changes, I believe we should be good.
You can also refer to this doc to understand how to use Sistent

Thanks again @SankarshanMishra ! Once you incorporate the sistent components, tokens and styling changes, I believe we should be good. You can also refer to this doc to understand how to use Sistent

I have made the necessary changes thank you for providing me with the documentation it did help a lot. kindly let me know if there are any more changes I have to make.

@SAHU-01 kindly merge the pr request or let me know if I have to make any more changes.

Thanks for making the updates @SankarshanMishra , you need to add the styled import from sistent as mentioned in the reviews, additionally, not just Button, but all the other sistent components that we have like Grid, Typography, etc need to be imported from sistent as well .
Once done, i belive the finish line is close, and we can get it merged

@SAHU-01, Greetings Ma'am, actually this is my first time making a meaningful contribution to opensource I am a little confused,
23:7   error  'StyledButton' is assigned a value but never used                                                 no-unused-vars
28:7   error  'PlayRoot' is assigned a value but never used                                                     no-unused-vars
33:7   error  'styles' is assigned a value but never used                                                       no-unused-vars
102:9   error  'theme' is assigned a value but never used
in eslint test                                                    no-unused-vars
am getting these errors But I don't know if I could remove these variables or how to implement them, could you help me out a little here please.

Hello! Kindly review and accept my pull request. Thank you @ianrwhitney


BE: Set up structs for spaces, kubes + players

charlotte pls tell me if good ty

Do you think it's easier to use space.x, space.y or have a coordinate field of type [u64; 2]?

I just realised I did the lecturer/tutor thing of saying "do you think" rather than "I think we should" :P so I think we should use [u64; 2] instead.


[BUG] Meta was causing a crash at Baileys

When trying to use the AI meta on the number that is connected it is causing bugs and infinite crash in baileys

TODO: add msmsg support


Node upgrade, fix link / add example

I can only guess to where the original link pointed to. Replaced it with the docs page for upgrading node.
Also added an example, how to run reinstall in the container.

I manually corrected the link in beta branch. Thanks for the suggestion.
Regards,
André


fix(breadcrumb): center breadcrumb itemLink

Description

During the SWC implementation of breadcrumbs, it was noticed that there might be some misalignment of the breadcrumb items, specifically for large/mobile scale:
https://github.com/user-attachments/assets/33dc71fb-2f5a-4fee-8985-538457d914ac
In the video above, when breadcrumbs is toggled to the mobile scale, the margin around the separator icon increases from 19px to 25px. That margin causes the spectrum-Breadcrumbs-item element to increase in height in comparison to the last breadcrumb item, which has display: none set on its corresponding separator icon. You can see in the screenshots below that the last breadcrumb item is shorter in height without the additional margin increase from the icon:

Because of the increase in height, as well as the margins placed on the spectrum-Breadcrumbs-itemLink element, you can see that element increases in height, filling any remaining space. Although the spectrum-Breadcrumbs parent element has align-items: center, that was only affecting the spectrum-Breadcrumbs-item element, and not the spectrum-Breadcrumbs-itemLink element that houses the text node. As the item link element grows, you can see the visual misalignment of text to the separator icon because the text node was not centered in the item link element. This also leads to the first few breadcrumbs' text to look misaligned to the last breadcrumb text:

Adding align-self: center to spectrum-Breadcrumbs-itemLink resolves the height increase and corresponding text node misalignment. Additionally, align-self: center was added to the spectrum-ActionButton in use cases where an icon is used.
before:

after:

The example below is from the Spectrum CSS Storybook, toggling between desktop and mobile scale:
https://github.com/user-attachments/assets/aaa3105b-14bd-454c-80bf-20cc86203b72
This example below uses the preview URL from the SWC breadcrumb PR, adding align-self: center in the inspector, and toggling it on and off:
https://github.com/user-attachments/assets/055f48a9-c6bd-4b3c-a498-c30819726601
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps

Visit the breadcrumbs default story page
Toggle the scale to "large" for mobile viewing, and turn on both the border and measurement tools

Inspect one of the spectrum-Breadcrumbs-itemLink elements.
Toggle the align-self: center in the inspector. You should see the borders of the item link elements change, and the text within them move up, away from the center line of the container

With align-self: center turned off, measure the heights of spectrum-Breadcrumbs-itemLink. You should see a height difference with the first two items, in comparison to the last item/current breadcrumb. The first two items will be taller
Turn on align-self: center in the inspector, and remeasure all breadcrumb item links. All should be the same height now
In the Storybook controls, change the variant to compact or multiline. Repeat the process of checking that align-self: center better aligns the text nodes to the separator icons, and keeps the height of spectrum-Breadcrumbs-itemLink the same across all breadcrumb items (note that the final breadcrumb item in the multi-line variant should have a different height)

Additional validation

Pull down the branch and run locally
In breadcrumbs/breadcrumbs.stories.js, add the following to  Default.args.items (add this before the last item):

  {
    iconName: "FolderOpen",
    isDisabled: true,
  },

Visit the breadcrumbs default page (with the large scale, borders on, and measurement on)
Back in the browser, you should now have additional breadcrumb with a disabled action button and folder icon
Inspect the action button and toggle the align-self: center property. You should see the same behavior as with the text nodes, where align-self: center turned on ensures the action button is centered with the separator, and that property turned off leaves the action button unaligned.

Regression testing
Validate:

The documentation pages for at least two other components are still loading, including:

[ ] The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

[ ] VRTs have been run and looked at.
[ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

[x] I have read the contribution guidelines.
[ ] I have updated relevant storybook stories and templates.
[ ] I have tested these changes in Windows High Contrast mode.
[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[ ] ✨ This pull request is ready to merge. ✨

can we take care of it by doing an align-items: center; on the parent (.spectrum-Breadcrumbs-item) rather than the individual children (.spectrum-Breadcrumbs-itemLink and .spectrum-Breadcrumbs-item > .spectrum-ActionButton), or would that cause some kind of unintended side effect?

@rise-erpelding- I struggled with this. I pushed up the align-items: center for spectrum-Breadcrumbs-item. Personally, I think that's the best way to do this in the long run. The reason I went with the align-self was because I was specifically trying to find a fix just for the mobile scale (which was where this was noticed originally). I guess I was concerned that align-items: center on Breadcrumb-item was moving the separators in desktop, centering them. I don't think that's a bad thing- it's still technically got all of their margin, just centered within spectrum-Breadcrumbs-item now. But if I look at the S1 design file, and even the S2 file, they're not technically centered? I thought I read somewhere that the designs (at least for S2 right now) were geared towards desktop, so I was trying not to touch desktop and just fix it for mobile (although the action button is now centered in desktop with that too. 🤦♀ ). What do you think? I'm definitely open to the align-items: center fix, but maybe I got hung up on the "mobile" part.

is there a better way to measure that this is centered that I maybe missed?

I'm not sure. In Chrome, if I hover over align-items: center in the inspector, it will give me a grid line. Firefox does something sort of similar, but just extends the bounding boxes (it's definitely more "by eye" in Firefox).


[Feature Suggestion] Helper functions for common use cases?

Would there be any interest in adding helper functions such as:
const Component = styled.button`
    color: green;

    ${has('alternate')`
        color: yellow;
    `}

    ${is('alternate', 'danger')`
        color: red;
    `}
`;

<Component alternate />
<Component alternate="danger" />

I keep running into situations where I need to apply several styles based on props or prop values and this would make the resulting code more readable.
Would there be any interest in merging something like this if I were to submit a PR?

Kinda reminds me of this: https://github.com/eveningkid/pretty-components
fwiw, I've been handling this by creating a simple wrapper component that is just a switch to return different variations, e.g.
// The Button from the last section without the interpolations
const Button = styled.button`
  color: palevioletred;
  font-size: 1em;
  margin: 1em;
  padding: 0.25em 1em;
  border: 2px solid palevioletred;
  border-radius: 3px;
`;

// A new component based on Button, but with some override styles
const TomatoButton = styled(Button)`
  color: tomato;
  border-color: tomato;
`;

render(props) {
  switch (props.kind) {
    case 'tomato':
      return <TomatoButton>Tomato Button</TomatoButton>;
    default:
      return <Button>Normal Button</Button>;
  }
}

I'd love a way to do this without adding additional nodes to the tree!

@evandavis
I've basically solved this by writing a set of helpers that I can just import into projects as needed:
https://github.com/sbacic/styled-components-helpers
Though I still think it should be part of the core library.

I'll close this for now, since you have a library of your own to address this. I'd basically say that an excessive amount of small helpers doesn't actually help the average user (ha 😅)
It'd increase the API surface for something that's essentially quite small, and it'd then become questionable what the appropriate way to write a certain interpolation is as there'd be more than one idiomatic approach