Failures appear in red

I'm trying Whitebread to write my acceptance tests.
One of the things I noticed is that failures don't appear in red in the console.
Is it possible to set up colors for the output of tests?
If not I'm happy to submit a pull request to implement that.

@javflores to be honest I just never got around to adding colours to the console. Happy to receive a PR. A good starting point would be this module lib/white_bread/outputers/console.ex as it handles output to the console.

Fixed by #29 released in 2.2.0


Is it possible to use this operator with existing grafana service?

I would like to use this operator for dashboard and datasource crd with prometheus-operator grafana.

It is possible, as long as the name of the existing service does not conflict with the one created by the operator (grafana-service). You can disable the route/ingress but there is currently no way to stop the operator from creating that service.

@kernel164 did the suggested solution work for you?

Haven't tried yet. Will probably give it a try by next week. I don't want to have another grafana running. Any plans to support this feature ?
Something like this...
apiVersion: integreatly.org/v1alpha1
kind: Grafana
metadata:
  name: external-grafana
spec:
  service:
    host: grafana.monitoring
    port:
    apikey:
  dashboardLabelSelector:
    - matchExpressions:
        - {key: app, operator: In, values: [grafana]}

or probably have a different Kind: GrafanaService

Right, so i misunderstood this. You didn't mean a 'Service' in the Kubernetes networkig sense but another Grafana instance. No, the operator will always create a deployment with a Pod running Grafana.


Scroll doesn't work on IOS

For some reason Scroll doesn't work in modals on IOS. It works well, on other platforms.
To view this issue:

Visit https://www.givingway.com/search.give?searchMode=online on an iphone.
Open the tasks filter.
Try to scroll the screen.

Files in production include source-maps. Specifically visit

I tried locally adding "overflow-y: scroll; -webkit-overflow-scrolling: touch;" but the issue persists.

Hmm I am also having an issue on my iPad. However the demo at https://bodyscrolllock.now.sh works fine on the iPad too. Could there be a different implementation than the default?

After testing and playing with the functions for a few hours on various platforms, there is no problem with the library, but how I was using it. I think the documentation could be improved. Specifically, that the element we would like to allow scroll on, is the same element we should pass to disableBodyScroll (and not a parent of that element) and on which we should apply the following css:
    overflow-y: autp;
    -webkit-overflow-scrolling: touch;

As more reusable solution I created the following component (Written in Typescript, using an Emotion Styled component):
const style = css`
	label: scroll-box;
	overflow-y: auto;
	-webkit-overflow-scrolling: touch;
`

class ScrollBoxW extends React.Component<IStyledComponentProps, {}> {
	public allowScrollRef: React.RefObject<HTMLElement> = React.createRef()

	public componentDidMount = () => {
		disableBodyScroll(getElementFromRef(this.allowScrollRef), {
			reserveScrollBarGap: true,
		})
	}

	public componentWillUnmount = () => {
		clearAllBodyScrollLocks()
	}

	public render() {
		const {stl, children, ...props} = this.props
		return (
			<Box stl={[style, stl ? stl : undefined]} innerRef={this.allowScrollRef} {...props}>
				{children}
			</Box>
		)
	}
}

Suggestions:

Perhaps we can create a similar component, which is more generic and not dependent on Emotion, and export it as part of the library?
The documentation should elaborate on how to use the library. My English is not native, but I can offer a PR.

#104 fixed this for me

I agree with @carpben that we should put more focus in README onto which node should be passed to disableBodyScroll(targetElement).

Specifically, that the element we would like to allow scroll on, is the same element we should pass to disableBodyScroll (and not a parent of that element) and on which we should apply the following css:

It would probably save my last 1-2h ;p

Thank you @carpben I was trying for years to figure out the combination where everything would work as intended.

Readme updated to emphasise target element that you want to persist scrolling for is element you want to allow scroll ON, and not the parent of the element you want to allow scrolling for.
Thanks for the tip.  😃

Aside from overflow-y: auto and -webkit-overflow-scrolling: touch, I had to add height: calc(100% + 1px) in order for scroll to work on iOS Safari when content is dynamically rendered

let

-webkit-overflow-scrolling  is non-standard, why are we using it
I am unable to scroll on iOS using any browser
https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-overflow-scrolling

You don’t have to use WebKit-overflow-scrolling if you don’t want. It makes scroll smooth on iOS as is optional. It won’t do anything on other browsers but is widely used for iOS.
Overflow-y: auto and height: 100%+1px fixes two iOS scroll bugs.
I believe this library uses overflow: hidden. iOS doesn’t respect overflow hidden for scroll lock containers but overflow auto does work.
Height: 100% + 1px is a hack to allow scroll lock for dynamic content that goes beyond the height of the view port (again, iOS). This forces iOS to allow for vertical scroll of content that goes beyond the height of the view port.
@jmayergit if you try out this CSS (see my example above) you should be able to get it to work.

@alxhghs great. setting 'overflowY: auto' and height: 'calc(100% +- [number]px)' allows for scrollable content on iOS modals

height: calc(100% +- [number]px) hack works but as I reach at the end of the scroll. Scrolling  doesn't work again.

They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use.
npm i body-scroll-lock-upgrade

repair log，Refer to the releases page.


Wrong endpoint finding description aggregation in reimport Nessus report if new or mitigated endpoint

The description given at the time of a nessus vulnerability reimport.
When the vulnerability title and endpoint are maintained, but there was an update in the output presented by the tool, this new vulnerable version is not presented in the defectdojo description. Even if the endpoints changes when mitigated ou new to the finding de description still the same.
Example images follow

Steps to reproduce
Steps to reproduce the behavior:

Create an engagment and import .nessus scan result in some test;
Change de version of vulnerable version showing in .nessus
You will see that for some reason Dojo still show the old version in description.

Expected behavior
Update de description information in Dojo when the version, or endpoints changed in the finding.
Deployment method (select with an X)

[x] Docker Compose
[ ] Kubernetes
[ ] GoDojo

Environment information
Operating System:
Distributor ID: Ubuntu
Description: Ubuntu 22.04.1 LTS
Release: 22.04
Codename: jammy
DefectDojo version v. 2.18.1 ( release mode )

This is because the Nessus parser uses these settings for deduplication:
'Nessus Scan': ['title', 'severity', 'vulnerability_ids', 'cwe'],
As it doesn't use the description then it sees that the reimport is the same as the old one and doesn't update it. Most of the parsers don't use description, so I'm not sure TBH if it should be changed or not.


A TypeError on page dataQuality

TypeError: Cannot read properties of undefined (reading 'data')
at /ares/src/widgets/pivot/ui/Pivot.vue:65:58
at Array.reduce ()
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screen resolution: 1728 x 1117

Did the error occur as soon as you loaded the page or it happened due to some action on the page?
I've been yet unable to reproduce the issue using 3 different sources: with correct data, with old format data and with no data.

I'm having a hard time recreating. I'll open again if I hit it.


HOSTEDCP-2075: DNS and NodePort address CEL

/hold
goes after https://github.com/openshift/hypershift/pull/5155
What this PR does / why we need it:
Add cel and e2e input validation for DNS and nodepool.address
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/hold cancel

/test unit

/test unit

/test unit

I'm splitting this into two different PRs
https://github.com/openshift/hypershift/pull/5171


fixes to power-test-config.odg

clarify how the controlling GPIO signals connect to the circuit

...so I can upload the file.


ATV has port, but no logical address, doesn't work with current implementation

I'm not sure how to enter this, whenever I choose a random port number I see the app runaway wildly turning it on in a loop.
Command output:
{
"connection": true,
"icon": "meta:playbackdevice",
"label": "Apple TV",
"title": "Player 1",
"uri": "extInput:cec?type=player&port=1"
},
My config:
"cecs": [{
"label": "Apple TV",
"logaddr": 0,
"port": 1
}]
The result:
[2018-3-23 03:28:06] [Sony] Turning on the TV...
[2018-3-23 03:28:07] [Sony] Turning on the TV...
[2018-3-23 03:28:07] [Sony] Turning on the TV...
[2018-3-23 03:28:07] [Sony] Turning on the TV...
[2018-3-23 03:28:08] [Sony] Turning on the TV...
[2018-3-23 03:28:08] [Sony] Turning on the TV...
[2018-3-23 03:28:09] [Sony] Turning on the TV...
[2018-3-23 03:28:09] [Sony] Turning on the TV...
[2018-3-23 03:28:09] [Sony] Turning on the TV...
[2018-3-23 03:28:10] [Sony] Turning on the TV...
[2018-3-23 03:28:10] [Sony] Turning on the TV...
[2018-3-23 03:28:10] [Sony] Turning on the TV...
[2018-3-23 03:28:10] [Sony] Turning on the TV...
[2018-3-23 03:28:10] [Sony] Turning on the TV...
[2018-3-23 03:28:10] [Sony] Turning on the TV...
[2018-3-23 03:28:11] [Sony] Turning on the TV...
[2018-3-23 03:28:11] [Sony] Turning on the TV...
[2018-3-23 03:28:11] [Sony] Turning on the TV...
[2018-3-23 03:28:11] [Sony] Turning on the TV...
[2018-3-23 03:28:11] [Sony] Turning on the TV...
[2018-3-23 03:28:12] [Sony] Turning on the TV...
[2018-3-23 03:28:12] [Sony] Turning on the TV...
[2018-3-23 03:28:12] [Sony] Turning on the TV...
[2018-3-23 03:28:12] [Sony] Turning on the TV...
[2018-3-23 03:28:12] [Sony] Turning on the TV...
[2018-3-23 03:28:13] [Sony] Turning on the TV...
[2018-3-23 03:28:13] [Sony] Turning on the TV...
[2018-3-23 03:28:13] [Sony] Turning on the TV...
[2018-3-23 03:28:13] [Sony] Turning on the TV...

Hm can you try activate Apple TV with Bravia sync and try again getting the logical address
It must be detected as meta:cec and Not meta:playback

Yeah I tried that, and it says: meta:playbackdevice

Hmm, i will look later, maybe there is a workaround to Start a cec device

So it is not possible to start a cec device without logical adress, its only possible to change the hdmi input. Do you have checked the cec settings from apple tv? Normally all devices that support cec must be shown as cec in the output, otherwise it is not possible to start it
i will change the code to prevent getting error without logical adress

i checked the icon tag of my cec devices and "meta:playback" is correct, so just forgot what i have said above with "meta:cec" ^^

Yeah it shows the Apple TV in the CEC settings as enabled. Very strange! I'm guessing different models have different implementations of the protocol, which is kinda mad.

I'm able to wake my Apple TV with this command:
curl -H "Content-Type: application/json" \
  -H "X-Auth-PSK: sonytv" \
  -X POST \
  -d '{"id": 20, "method": "setPlayContent", "version": "1.0", "params": [{"uri":"extInput:cec?type=player&port=1"}]}' \
  http://<IP_ADDRESS>/sony/avContent

I used this kind of as reference, but I don't think even that is identical to mine. The plugin may need to dynamically figure out what's supported before using it, to properly support different Bravia TV's. :-/

There is already a function to check the tv state first before turning on the cec device. If there is an "error" in response, it tries to turn on the tv, if there is "result" in response it tries to turn on the cec device.
Here is the problem. It always tries turning on with port AND logical adress, and if there is no logical adress you got an "error" in response and the plugin thinks the tv is off and try everything again
To solve this, we must check the given parameter in the config file. If there is only port given, so we need an uri without the logical adress, if both is given, we need an uri with port and logical adress
I will check this and publish a new version later

Why not just change it to taking the uri directly? Then it should work in all cases. Glad to hear you handle the power off case!

Because the uri which is working for you doesnt work for me :/ so i need to check the given Parameter and Change dynamically the uri

taking it directly were a good Solution ^^

should be fixed with v2.3

I like the auto-config in the new one!
It works while the TV is on, but when it's off, it turns the TV on then crashes with this error:
[2018-3-25 21:58:06] [Sony] Turning on the TV...
/Users/elp/.nvm/versions/node/v7.6.0/lib/node_modules/homebridge-sonybravia-platform/accessories/Inputs.js:185
                                        this.SourceSwitch.getCharacteristic(Characteristic.On).setValue(self.state);
                                                         ^

TypeError: Cannot read property 'getCharacteristic' of undefined
    at Timeout._onTimeout (/Users/elp/.nvm/versions/node/v7.6.0/lib/node_modules/homebridge-sonybravia-platform/accessories/Inputs.js:185:58)
    at ontimeout (timers.js:469:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)

Should be fixed with https://github.com/SeydX/homebridge-sonybravia-platform/commit/3d142c6c3a657c8900977e2b376d2fa195a8b80e
new Version is on the way

can you try the latest version and give some feedback pls

It's working great, turns the TV on then turns the ATV on exactly as expected, thanks!

Hey this stopped working exactly as it was – when I have the definition set to HDMI4, it still maps to HDMI1. I'm not sure when this changed, exactly.
I'm using this:
				"title": "Player 1",
				"hdmiport": 4
			}]
		}```

With that, I see in the Home App HDMI2, HDMI3, HDMI4 and "Sony Player 1" which maps to HDMI1. When I turn on the TV with HDMI4 selected (where the Apple TV is), the HDMI4 tile is lit, and not "Sony Player 1".

Any ideas?


Unable to Install Piranha CMS in ASP.Net MVC Application: Failed to add reference to 'System.Linq'

Piranha CMS looks like it would be a great fit for our existing site. I wanted to test out the functionality so I followed the guide found here:
https://piranhacms.org/docs/introduction/getting-started
When I try to install it into my VS 2015 project with NuGet (using Install-Package PiranhaCMS.Mvc) the process works through several packages, and gets to the point where I see these lines:
Adding package 'PiranhaCMS.Core.2.2.6' to folder 'C:<MyPath>\SolutionDirectory\packages'
Added package 'PiranhaCMS.Core.2.2.6' to folder 'C:<MyPath>\SolutionDirectory\packages'
Install failed. Rolling back...
After it finishes removing packages I see this:
Failed to add reference to 'System.Linq'. Please make sure that it is in the Global Assembly Cache.
Whats strange is that my project is built against .net 4.5.2. and as far as I am aware system.linq is now just a part of System.Core.dll so I wouldn't expect it to be on its own in the GAC.
Any ideas on how I might resolve this issue?

Hmmm.. The current version builds against the .NET 4.5 framework for backwards compatibility. If you can install 4.5.2 as a standalone installation my guess is that you don't have the GAC assemblies for System.Linq for 4.5?
Regards


Update OtaPalWriteBlock_t comment with a note

Update OtaPalWriteBlock_t comment with a note about returning from the function and exception condition.
Description

Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] My code is formatted using Uncrustify.
[x] I have read and applied the rules stated in CONTRIBUTING.md.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updated at #436 . Close this PR.


this 2 500s should be a 400

400, better UX

==========================
==========================
500s  BAD UX

Query asks for data past end of contig

Malformed query; start point 101333 lies after end point 100833

To summarize, it looks like there are 3 issues at play:

User selects an end for the sequence that is before the start of the sequence. This causes a 500 instead of a 400. This is especially easy to do for a newbie if you don't know the length of the sequence and your selecting the beginning starting "downstream from the start" and the ending starting "upstream from the end".

User selects an endpoint that is past the end of the contig. This also causes a 500 instead of a 400. This one is also easy to do if you don't know the length of the sequence:

Note: the end of the sequence in the example is cut off, but is specified as 1000

User requests more than the total allowed bases. This is correctly thrown as a 400, but there might be some work to map it properly in the ProcessQuery in WDK.

This other ticket was created as a follow-up based on UX discussions that resulted from this ticket.


VW MQB: Add FW for 2016 Volkswagen Tiguan

Add firmware for the EU/RoW 2016 Volkswagen Tiguan.
Dongle ID: 21aed36c451a54e9
Thanks to community Tiguan owner mikkelamby.
I'm not really sure what to do with README on this. It's a new model-year for us, but it falls into the confusing area I described in #20695. I could asterisk it somewhat like the Passat, add a footnote to the 2020 mentioning EU/RoW 2016 is supported too?

Could swear we'd done MYs in the release notes before, but I guess not. Whichever way you want is fine.
Any thoughts on the README? I know it's supposed to be US-centric, but it seems odd to leave out entirely.

The README is a bit odd since it's US-centric for model years plus models that don't exist in the U.S. Let's merge this to get the FW in, and we'll think about how to handle this case going forward.


addSubView() not works expectedly

Instead of using in an UINavigationController I tried to add it's view to an UIViewController class:
let contactScene = EPContactsPicker(delegate: self, multiSelection: true, subtitleCellType: SubtitleCellValue.Phonenumer)
self.view.addSubview(contactScene.view)

This shown up the EPContactsPicker effectively but when tap on any entry, the entries disappears leaving only grid lines. Am I supposed to add EPContactsPicker in above way, or what I need to do differently?

@santanu4ver I intended to create this component as viewcontroller. Will checkout your scenario and will update soon

Thanks. Appreciate your effort. This API is very good looking.


Wrong netflix

I have setup the docker and smartdns.  All the script is executing right.  I am however using a tunnel from Singapore and testing from a system over in asia.  I can reach Netflix.com ok but it is always netflix singapore.  Don't know if this is due to the tunnel?  How can I troubleshoot find out why it is not going to Netflix US?
I have another windows system in the same location as the smartdns and I can access netflix US from there.
Any help would be greatly appreciated.

Can you try creating a tunnel on a different tunnel server (you have max. 3 on an account) and redeploy using this tunnel. You can specify a tunnel index as a parameter to  the build script, starting from 1 (first tunnel in the portal).

I already tried with Los Angeles, Seattle, Ashburn, and 1 of the Fremont but each time the build script will fail
at around "bringing up IPv6 tunnel" the error is along the line of "not being able to reach the tunnel"
Not sure which region to use since I have used 3 accounts already to change regions
If I were to change region now, can I just run build.sh or do I have make changes manually?

From: Anton Belodedenko<EMAIL_ADDRESS>Sent: Tuesday, May 24, 2016 5:39 AM
To: ab77/netflix-proxy
Cc: dupuyol; Author
Subject: Re: [ab77/netflix-proxy] Wrong netflix (#175)
Can you try creating a tunnel on a different tunnel server (you have max. 3 on an account) and redeploy using this tunnel. You can specify a tunnel index as a parameter to the build script, starting from 1 (first tunnel in the portal).

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/ab77/netflix-proxy/issues/175#issuecomment-221217617

Also I can only have 1 tunnel configured for 1 IPv4 (which is that of the VPS/Node correct?)

The best way is to destroy your VPS and start from scratch, providing the -n parameter with the index number of the required tunnel. For example -n 2 for the second tunnel in the portal.
Correct, HE won't allow you to create multiple tunnels to the same IPv4 address.

Been destroying and rebuilding the whole day so far :) and since my VM only has 1 IP I can only create 1 tunnel.  My VM is in the US (Dallas) but the script has failed for the US regions I mentioned above except for Singapore.  Any suggestion for a region that would not crash the build script?

Do you have the netflix-proxy.log from the failed attempts?

@ab77 forgive me but I was under the impression that HE was a pure US tunnel provider. From what you said, the only reason there are multiple locations is to reduce congestion on the path to our Netflix server/Netflix itself.

I don't have the logs, I wiped the VM and recreated but I am going to try to recreate again with a new region and give you the log if it fails.

HE are based in the US, but they have local POPs all over the world. However, the geo
-ip info for these local POPs is mainly messed up, which is why Netflix sometimes thinks you are in Switzerland or some other location, not corresponding with the actual tunnel server physical location.

is there any other tunnel broker that would be more reliable?

Not that I know of. I have the build automatically tested on a HE NYC tunnel with the Droplet running  in nyc3. It works.

OK, sorry for the delay in responding,  It seems that it working now.  My problem may have been setting up the DNS server at the router/DHCP level.  It seems to be working also from the Roku box I have (will be testing with xbox and chromecast to see) - Thanks

No problem. I can't say for sure about Xbox, but I know Gen1 ChromeCasts didn't support SNI.


Read again the ABORT_TEST_TIMEOUT attribute of the test

This way, test can modify the test timeout according to some calculations made in the setup phase

Do NOT forget to update the upseto.manifest hash as well!!


Hierarchy view empty if class not selected

This may not be a bug, but it's kind of misleading API if this is intentional.
In 3.0.22, the only time I see the hierarchy tab not blank, is if I first am on the class tab and select a class.  In that case, if I go to the hierarchy tab it shows me that class's hierarchy view.
The tab make it seem like these are alternate ways to look at the list of classes in the package, rather than the hierachy tab being a view for that class only... that sort of thing would make more sense on the lower half.

What you are seeing is by design. I wasn't sure what the default hierarchy view should look like so I left it blank.  Otherwise the hierarchy view is blank.
However, I've got a potential improvement for this in Oscar3.0.25.  It shows the top level Object class and it's peers. My concern all along has been that it would be too slow. However, I did a little bit of tuning and I can bring up the formerly-blank hierarchy view in under 2 seconds.
This will be checked in for 3.0.25. Please review and let me know what you think. I can take back out if need be.

On the whole, I think you should back out the change. I don't see that it helps, since it's not really a practical way to find a class.  It's not super-slow, but you don't get anything really useful to justify looking at that dialog.

@LisaAlmarode Had another idea that wouldn't involve Object. If there's no selection in the class list and the hierarchy tab was clicked, what if we selected the first class in the class list and displayed that hierarchy?
I'll check that into 3.0.28 for your review.

In Pharo (at least older views) and tODE, only the classes in the list are displayed in hierarchy order ... then you get tos the relationship of the classes in the list ... I’ve a method (or 2) with the algorithm lying around if you are interested

@dalehenrich  Can you point me at the methods with the algorithm for computing the hierarchy of just the listed classes that you mentioned? https://github.com/GemTalk/Jadeite/issues/125#issuecomment-418399044

Fix in 3.0.32 for Lisa to review incorporates Dale's recommendation.

I like this new behavior.


Get image by tag

Hi,
I am using your library for performing scanning in google Artifact Registry. Version I am using is:
 implementation("com.google.cloud:google-cloud-artifact-registry:1.18.0")
With the following code I was able to get image metadata:
GetDockerImageRequest request = GetDockerImageRequest.newBuilder()
                    .setName(
                        DockerImageName.of("my-project",
                                "europe", "repository", "imageName@sha256:0a4994d8f9b0aba9e142e9bf09cf140798dde2f22a31ab41645aee41b8f24b16")
                            .toString())
                    .build();
                DockerImage dockerImage = artifactRegistryClient.getDockerImage(request);

Here I had to use digest of the image to be able to access it.
I tried to get the same image by tag. Like this:
GetDockerImageRequest request = GetDockerImageRequest.newBuilder()
                    .setName(
                        DockerImageName.of("my-project",
                                "europe", "repository", "imageName:1.0.0")
                            .toString())
                    .build();

but then I got an error:
 io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.
Is there a possibility to get image by tag using your library?
Thank you in advance

Would you share the entire stacktrace of the error message?

Thank you for stacktrace. Reassigning to Lawrence.

Hi @SvetaAndriyanchik, thanks for providing a snippet. I was able to reproduce this locally.
I took a look at the underlying proto and found that it seems to suggest that we're supposed to be providing a digest for docker image parameter: https://github.com/googleapis/googleapis/blob/974c49f05ed50ba22fa471a29eabb5959581e3ac/google/devtools/artifactregistry/v1/artifact.proto#L51
I uploaded a sample hello-world container to my local artifact registry and pulled it down to see what the server is responding with. I see that the DockerImage's name is returned as projects/{MY_PROJECT}/locations/us-east4/repositories/test-repository/dockerImages/hello-world@sha256:7e9b6e7ba2842c91cf49f3e214d04a7a496f8214356f41d81a6e6dcad11f11e3
Do you have a constraint with including the digest as part of the name in the request?

hi @lqiu96 thank you for the update. yes, I also noticed that name has a digest part in it.
so there is no way to pull image by tag?

Unfortunately, I don't think so (my local tests also haven't been able to find a way). It seems that the server is expecting a digest in the URL path.

Feel free to comment or re-open if you have further questions. Going to close this.


ToolBarDropdownOptions

A dropdown option switch that chooses between different options and then triggers a callback based on the selected option.
It should be built on top of ToolBarItem.
References: https://guide.freecodecamp.org/javascript/tutorials/how-to-create-a-dropdown-menu-with-css-and-javascript/

There should probably be also a way to programmatically update the selected item, for example, if another part of the package modified the value.


Error "getVariable is not a function" when used with OZ upgrade-plugin.

I am not sure whether this is a known limitation or it's just that I am missing something, so here is the description:
I try to use it with an OZ UUPS proxy I get: getVariable is not a function
The contract must be deployed using the upgrades.deployProxy() from the OZ upgrades HH plugin, and I managed to get no complaints from typescript:
const ProxyMock = await smock.mock("MyContract");
const proxyMock = await upgrades.deployProxy(ProxyMock as MockContractFactory<MyContract__factory> & MyContract__factory, [...]) as MyContract & MockContract<MyContract>;

However that does not help.
How should I hook into the customized deployment of the upgrade-plugin, if that is possible, or how can I get around it with some manual work around?
Thanks

Well... I avoided it by not using smock, creating my own infrastructure that tests the real code instead.
More work but a lot better testing in my case.


Planar crystal: Discontinuity in the etendue

Maybe this is due to me building things incorrectly, but I'm seeing a sudden drop in the etendue on the central vertical channel. This is with a (33,1) pixel mesh.

I've noticed when refining the vertical pixel mesh that when the number of pixels is even then that central hollowing widens and get populated with nan's. This is with a (33,4) pixel mesh:

Refining the horizontal mesh doesn't seem to impact this behavior

Minimum working code. Same as attached in Issue #755 :
make_tofu_spec.txt
The pixel mesh is defined by variables: nx0, nx1


Support of "appearance"

if you'll create style:
select {
    appearence: none;
}

it doesn't add any styles with prefixes, but according to http://caniuse.com/#search=appearance it should

FYI appearance: none has been accepted by the CSS WG, source. It has already been added to the CSS UI L4 editor’s draft: Chapter 8.

+1

Nice news. I will add it to 5.2.

Uu-hu!

Simple question on scope. If I want to remove the arrow thing on <select> elements, I can use -prefix-appearance:none on WebKit/Blink and Firefox, but IE 10+ needs select::-ms-expand {display: none;}.
My understanding is that Autoprefixer would add moz and webkit prefixes for the appearance property, but will not add the IE-specific code since a) it differs significantly and b) there is no way to detect that appearance:none was used on a selector targetting a select element. Is that correct?

@fvsch yeap, select::-ms-expand is not a task for Autoprefixer.

Becuase appearance with auto and none became a standard again, Autoprefixer 5.2 will have appearance support.

@fvsch You can write own processor for this task.


Include opensearch.yml setting for compatibility mode.

This cluster setting is explained in documentation, but this can also be set on a node inside of opensearch.yml.
We should also include the correct setting name on this page to avoid confusion.
compatibility.override_main_response_version: true

We should also document that the setting should be added to the .yml if you are upgrading and taking live traffic. That's the scenario in  https://github.com/opensearch-project/OpenSearch/issues/1022 - without it you get client failures until you set the cluster setting.


SWARM-1298: avoid double logging when using swarm.logging.category system properties

Motivation
If I use -Dswarm.logging.category.name=DEBUG to enable
debug logging, I get each of the debug log messages twice.
This appears e.g. in the ArqLoggingLevelsTest test.
The ultimate reason is that LoggingFraction.applyDefaults(Level),
which adds the logger to the WildFly logging subsystem,
configures a handler for the logger. The thing is that by default,
log messages are already sent to the parent's logger handlers,
so in combination, the log message gets sent to 2 handlers.
Modifications
The newly created logger no longer has a handler set up.
This is how loggers are typically added with WildFly.
Another possibility would be to set the use-parent-handlers
management attribute to false.
Result
No more double logging.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

retest this please

Retest this please

retest this please

retest this please


Tapping "X" on Android CustomTab interface does not close window

This is a re-submission of #306 which was closed due to inactivity for request for a reproducible code sample. I provided one after it was closed, but was never re-opened. This is still occurring in our app today and we need to identify a fix for it.
Xamarin.Auth Issue
On <IP_ADDRESS> for Android, CustomTab is not closing when the user taps the "X" button to close the custom tab and navigate back. It launches another custom tab instead. Tapping "X" on the new custom tab window will finally close the window.
Logging in normally works fine otherwise.

[Xamarin.Auth / Xamarin.Auth.XamarinForms ] nuget version = <IP_ADDRESS>
[Xamarin Forms version <IP_ADDRESS>9982]
[NetStandard 2.0]

Steps to reproduce
Please see my reproduction here: https://github.com/kensykora/xamarin-auth-issue-306

Launch App
Tap "Login" Button
Observe that chrome custom tab browser opens
Tap the "X" button in the upper left.

Expected: Browser closes, the Authenticator Completed event occurs, with the user being not logged in.
Actual: Custom tab opens up again, same page
Workaround: After step 4, perform step 5:

Tap "X" in the upper left a second time on the new window that opened. Observe that the browser closes and the Authenticator Completed event occurs, with the user being not logged in.

@kensykora thanks for resubmiting and providing a sample.  I will get @moljac to look into it for you
Regards

I have checked and it seems that custom_tabs_intent.LaunchUrl(activity, uri); it is called twice when closing, once outside the delegate and once inside the delegate.
https://github.com/xamarin/Xamarin.Auth/blob/master/source/Core/Xamarin.Auth.XamarinAndroid/UINativeNonIntegratedBrowsers/CustomTabsUtilities/CustomTabActivityHelper.cs#L109-L123
      custom_tabs_intent.LaunchUrl(activity, uri);   ------------------------>HERE
				custom_tabs_activity_manager.CustomTabsServiceConnected +=
                                // custom_tabs_activit_manager_CustomTabsServiceConnected
                                delegate
                                    {
                                        System.Diagnostics.Debug.WriteLine("CustomTabsActivityManager.CustomTabsServiceConnected");

                                        custom_tabs_activity_manager.LaunchUrl(uri.ToString()); ------------> HERE

                                        System.Diagnostics.Debug.WriteLine("CustomTabsActivityManager.LaunchUrl");

                                        return;
                                    }
                                ;
                System.Diagnostics.Debug.WriteLine($"CustomTabsActivityManager.BindService({package_name_for_custom_tabs})");

@kensykora @lewixlabs  could you provide a PR for this so we can merge the changes in to the code
Regards

@kensykora @lewixlabs could you provide a PR for this so we can merge the changes in to the code
Regards

@newky2k i made a pull request
https://github.com/xamarin/Xamarin.Auth/pull/332
I have a demo project i built & tested and all seem working, CustomTab is open once, not twice, and result is sent on my callback in custom url scheme correctly! 👍
Tomorrow i will do other tests, let me know if you need more infos.
Thanks!
Lewix


Request for Documentation on Macros and API Usage

Issue Description:
Firstly, I must say that your module is absolutely incredible! However, I would like to kindly request the addition of documentation specifically focused on the usage of macros and the API.
Request:
I kindly request that you consider adding comprehensive documentation that covers the usage and implementation of macros and the API within your module. Such documentation would greatly benefit users like myself who are eager to explore and utilize the full potential of these features.
Keep up the great work!

@brunocalado Thank you!
Can do - detailed documentation is on my to-do list anyway, along with a quick GIF video demo showcasing how to use this module.
I've never actually added formal, generated API documentation before.  Any suggestions?  If not, I will go ahead and just wing it with some manual descriptions and examples.

I'll do it.

docs card.txt

video demo:
https://github.com/orcnog/orcnog-card-viewer/assets/4999783/ad6dcc8a-5da0-4c7c-915c-931b1d5b8006

You're awesome.  Thank you for this.  I'm adding to it and will push it live soon.

Added.

You could this video too:
https://github.com/orcnog/orcnog-card-viewer/assets/4999783/ad6dcc8a-5da0-4c7c-915c-931b1d5b8006


Fix chromedriver renaming issue for M1 on Selenium 3.x

Summary
Can we get a patch for this issue but for people who are still stuck on selenium 3.x ?
https://github.com/titusfortner/webdrivers/issues/237
According to the changelog at https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md#500-2021-10-19, webdriver 5.x requires selenium 4.x. I am still using     webdrivers (4.6.1) which is only about one year old.
It is not easy to migrate from selenium 3.x to 4.x so it would be better to backport https://github.com/titusfortner/webdrivers/issues/237 for the people who are still using selenium 3.x
Debug Info
Please provide the following information for bug reports:

Webdrivers version:
Ruby version:
Operating system / CI Environment:
Browser and version:

Expected Behavior
What you expect to happen.
Actual Behavior
What is actually happening: Error message, stack trace, DEBUG log if applicable (set Webdrivers.logger.level = :DEBUG after you require webdrivers)

@tchiaspko Your best bet would be to monkey patch webdrivers in your code and override Chromedriver#driver_filename with the definition from #239. If multiple users end up requesting this, we would consider creating a new v4 release, but I don't have time right now unfortunately.

This code is using features in Selenium 4, and we don't want to maintain multiple code bases.
Moving to Selenium 4 should be pretty easy if you aren't using deprecated capabilities (which should both be easy to fix and be better conform to what modern drivers expect).


IBM POWER 8 arch support

Hello!
Are there any plans to support this architecture in the near future? I'm aware that GotoBLAS supported older POWER architectures, like 6 and 7. Would i be able to use this older GotoBLAS code in the newer POWER 8 ?
TIA,
Fabricio

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/9209082-ibm-power-8-arch-support?utm_campaign=plugin&utm_content=tracker%2F69691&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F69691&utm_medium=issues&utm_source=github).

I cannot access the POWER 8 machine. Thus, I am not sure how to use older GotoBLAS code on the newer POWER.  According to #463 , I think it not easy to port old code on the new POWER and AIX.

I can provide you access to a POWER8 machine running current OS, as Debian, Ubuntu or Fedora. Is it something you might be interested in?

I am interesting in optimizing OpenBLAS on newer CPUs. I can try it on my spare time.

Great. Please ask for the account on a POWER box using the following request:
http://openpower.ic.unicamp.br/minicloud/

Hi @xianyi, any updates on this?

@fabioperez  Sorry, I am very busy. I didn't try it yet.


Support latest Visual Studio Update 3 (npm 3.10)

Hi!
Due to a breaking upgrade of VS 2015, node-gyp stopped working and need to be updated to 3.4.10
In order to support that, NPM should be updated to 3.10.3

Is this why even after clearing out node_modules, updating npm and updating the global node-gyp to latest as well as npm's node-gyp I still get the following when installing electron-rebuild?  If so is there a workaround as this has cause a rather big problem for me.
$ npm install electron-rebuild

><EMAIL_ADDRESS>install G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog
> node-gyp rebuild

G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog>if not defined npm_config_node_gyp (node "C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  main.cc
  nslog_win.cc
  win_delay_load_hook.c
C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers [G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog\build\nslog.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134): note: see declaration of '__pfnDliNotifyHook2'
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\buildbot\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog
gyp ERR! node -v v4.4.7
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\buildbot\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install" "electron-rebuild"
npm ERR! node v4.4.7
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nslog package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nslog
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nslog
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     G:\windows-worker-1\launcher-build-windows\build\Launcher\npm-debug.log

That's the error :) you have to use the newest nodegyp shipped with npm
3.10 to support vs 2015 3
On Thu, Jul 7, 2016, 8:41 PM aelana<EMAIL_ADDRESS>wrote:

Is this why even after clearing out node_modules, updating npm and
updating the global node-gyp to latest as well as npm's node-gyp I still
get the following when installing electron-rebuild? If so is there a
workaround as this has cause a rather big problem for me.
$ npm install electron-rebuild

<EMAIL_ADDRESS>install G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog
node-gyp rebuild

G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog>if not defined npm_config_node_gyp (node "C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\....\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
main.cc
nslog_win.cc
win_delay_load_hook.c
C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373: '__pfnDliNotifyHook2': redefinition; different type modifiers [G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog\build\nslog.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134): note: see declaration of '__pfnDliNotifyHook2'
gyp ERR! build error
gyp ERR! stack Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd G:\windows-worker-1\launcher-build-windows\build\Launcher\node_modules\nslog
gyp ERR! node -v v4.4.7
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\buildbot\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js" "install" "electron-rebuild"
npm ERR! node v4.4.7
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nslog package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nslog
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nslog
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     G:\windows-worker-1\launcher-build-windows\build\Launcher\npm-debug.log
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/electron/electron-rebuild/issues/82#issuecomment-231169709,
or mute the thread
https://github.com/notifications/unsubscribe/ABeA4Tzb6Fcw9ZFUmfBSOjy5mclyWwLmks5qTUhmgaJpZM4JHHDU
.

I thought I had been but it turns out there were old cached versions that kept overriding I cleared out all the various places windows hides node modules (%USERDATA%, program files, local directory, etc...) and I think I am past the problem.

Also seeing this.  Emptying node_modules did not help.
node v6.3.1
npm v3.10.3
node-gyp v3.4.0
msbuild 14.0.25420.1

I'm seeing this too :( @aelana could you let us know exactly which directories you needed to clear out?

i am experiencing the same problem, it fails to rebuild after i update VS update 3, can you detail your steps how you manage to solve it?

In the end I think I was able to get it to work via setting the environment variable npm_config_node_gyp to point to the node-gyp.js I wanted it to use.

Considering I (and many others) are on VS2015 Update 3 with no issues at the moment I can assume that the dependency chain resolves to a working set of modules now 👍


Add data format value for t-route configs

Creating a simple DataFormat value for the format of t-route config data.

FYI @aaraney, I need the format value to exist for some of the composite dataset work I have going.  If it needs tweaking in any way to align with what you have been doing, just let me know.

I think we need this too. Not to open too much of a can of worms, I am wondering as this enum grows if we should reconsider how we are modeling dataset formats in the future? t-route's config file requires several input files depending on a simulations needs. Below are all the input files that could be specified in a t-route config. Although, this may not be an exhaustive list, this is for v3 of troute and they are now on v4.

preprocess_source_file
geo_file_path
mask_file_path
level_pool_waterbody_parameter_file_path
reservoir_parameter_file
reservoir_rfc_forecasts_time_series_path
lite_channel_restart_file
lite_waterbody_restart_file
wrf_hydro_channel_restart_file
wrf_hydro_channel_ID_crosswalk_file
wrf_hydro_waterbody_restart_file
wrf_hydro_waterbody_ID_crosswalk_file
wrf_hydro_waterbody_crosswalk_filter_file
diffusive_domain
topobathy_domain
qlat_input_folder
qlat_files
usgs_timeslices_folder
usace_timeslices_folder
gage_segID_crosswalk_file
wrf_hydro_lastobs_file
gage_lakeID_crosswalk_file
chanobs_filepath
parity_check_input_folder
validation_files

For simplicity, are you thinking the t-route config file (the literal yaml file) and all the dependent input files would be part of a single composite dataset that could also include realization configs for example?

For simplicity, are you thinking the t-route config file (the literal yaml file) and all the dependent input files would be part of a single composite dataset that could also include realization configs for example?

In part.  I need the notion of a t-route config dataset to exist, standing on its own.  The reason I need it is so that I can copy data items from it to a new composite configuration dataset.  Parts of the code for all that (and certainly parts beyond it eventually) require the DataFormat value.

Not to open too much of a can of worms, I am wondering as this enum grows if we should reconsider how we are modeling dataset formats in the future?

Yeah, this is getting a bit tricky.  We should only need to care about things we consider indices of the format that go into defining its domain: i.e., the hydrofabric giving it context, the set of catchment ids for a realization config, etc.  So perhaps this needs a little more - like the index for the discrete list of files in the dataset - but I think we can still what we need out of this approach.
I'd like to continue treating configurations as data so we can store them in datasets and make them available the same way we do other data.  It is not easy to strictly define all the details of the config-related DataFormats (like we would for a forcing format), but I am pretty sure it isn't necessary for how we use such things.  That said, if you have either a counter example or an alternative approach, we should consider it.

In part. I need the notion of a t-route config dataset to exist, standing on its own. The reason I need it is so that I can copy data items from it to a new composite configuration dataset. Parts of the code for all that (and certainly parts beyond it eventually) require the DataFormat value.

👍🏻

Yeah, this is getting a bit tricky. We should only need to care about things we consider indices of the format...

Yeah, I agree with emphasis on the we. A listing of additional files seems good enough for now. It seems crucial that we have a good idea of the use cases we need to support that rely on t-route in some way or else this area of the code is susceptible to scope creep.

It is not easy to strictly define all the details of the config-related DataFormats (like we would for a forcing format), but I am pretty sure it isn't necessary for how we use such things. That said, if you have either a counter example or an alternative approach, we should consider it.

Yeah, I agree for the most part. I hope we can ignore the majority of the details. The only counter example that comes to mind is deriving a t-route config for some simulation. It seems that we may not be able to select a t-route config on-the-fly, but instead it will require some human intervention to verify the knobs, dials, and input files are to the users requirements. I dont think that is an issue, so long as it falls within what we need to support.


Unable to install react-scripts via npm install

I'm getting the error below when I just did a fresh clone of my project:
Unexpected end of JSON input while parsing near '...0","jodid25519":"^1.0'
I then tried to manually run npm i react-scripts after clearing the cache & deleted the node modules folder but still received the same error above.
I've included attached the log file below.
Node & Npm version details:
node v8.12.0
npm  v6.4.1

2018-10-31T02_11_16_630Z-debug.log

Please clear your npm cache or switch to Yarn. If clearing your npm cache (npm cache clean --force) doesn't work, please file an issue with npm.


Unable to extract photos

I'm unsure if I'm using the program correctly. I can't get it to extract photos.
I extract the .zip. I put my save folder into the same folder as the program, then dragged the save folder on top of the .exe, and cmd window pops up for a brief moment before closing. I saw text once, but it closes too quickly to get a screenshot of what it says.
I installed both the x64 + x86 versions of the .net framework. Running Win10.
I dumped my save using JKSV. This is what the folder looks like.

Help? I really want to get my photos extracted!

Works fine for me on the hotfixed build under releases.
Run the following from command prompt under the folder where NewSnap.App.exe is located:
NewSnap.App.exe -sav <path_to_save_here>

You'll then be greeted to a bunch of new folders, XX_out, which will contain your extracted save data contents.

Ah, thank you! I finally got it to work!


LIVY-375. Change Livy code package name to org.apache.livy

This PR propose to change Livy code package name to org.apache.livy. This is one part to move Livy to Apache.

Codecov Report

Merging #12 into master will increase coverage by 0.08%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage      70.5%   70.58%   +0.08%
+ Complexity      730      729       -1
============================================
  Files            96       96
  Lines          5163     5161       -2
  Branches        779      779
============================================
+ Hits           3640     3643       +3
+ Misses         1006      999       -7
- Partials        517      519       +2

Impacted Files
Coverage Δ
Complexity Δ

.../apache/livy/server/batch/CreateBatchRequest.scala
62.5% <ø> (ø)
19 <0> (?)

.../server/interactive/CreateInteractiveRequest.scala
80.64% <ø> (ø)
22 <0> (?)

...scala/org/apache/livy/repl/SparkRInterpreter.scala
65.78% <ø> (ø)
3 <0> (?)

...main/scala/org/apache/livy/server/CsrfFilter.scala
0% <ø> (ø)
0 <0> (?)

core/src/main/scala/org/apache/livy/msgs.scala
9.09% <ø> (ø)
0 <0> (?)

...in/java/org/apache/livy/rsc/driver/JobWrapper.java
80.64% <ø> (ø)
8 <0> (?)

...che/livy/server/recovery/BlackholeStateStore.scala
100% <ø> (ø)
5 <0> (?)

...rg/apache/livy/repl/AbstractSparkInterpreter.scala
53.04% <ø> (ø)
1 <0> (?)

...g/apache/livy/client/common/AbstractJobHandle.java
85.71% <ø> (ø)
13 <0> (?)

rsc/src/main/java/org/apache/livy/rsc/PingJob.java
100% <ø> (ø)
2 <0> (?)

... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb5b8aa...e7a3cc4. Read the comment docs.

Merging to Master to unblock any follow-up PR.

ASF git has some issues syncing with Github, waiting for INFRA to fix it.


Microk8s: Error: No such option: --socket-path

V2022.07.2 is out and the instructions for installing microk8s on a microk8s cluster is updated on the website, but the archest-cli library doesn't seem to be updated to be able to use the socket-path option. After running pip install --upgrade orchest-cli the version I have is 0.4.2

(Continuation on issue: https://github.com/orchest/orchest/issues/1101.)
Hi @Bogehaven, I've just created a virtual environment and installed the orchest-cli using pip install --upgrade orchest-cli and when running orchest install --help I do see the --socket-path option listed.
Are you sure you are actually invoking the newly installed orchest-cli? For example, you can check which orchest to see the path to the executable.
To verify that you are indeed using version 0.4.2 could you run orchest --version and share the output?

I assume you have managed to resolve the issue and were able to successfully use the --socket-path option. Feel free to re-open in case you haven't :innocent:


RSDK-4289 remove MoveSingleComponent from motion service

@Otterverse we will need to manually merge this, can you help with that?

@Otterverse we will need to manually merge this, can you help with that?

Bug me on slack about this. I want to confirm that it's still in a "good to go" state before I merge.

@Otterverse we will need to manually merge this, can you help with that?

Bug me on slack about this. I want to confirm that it's still in a "good to go" state before I merge.

Actually, other merges have gone in since this built protos. You may need to rebase and retrigger the build process here, or it'll lose the newer changes. I'm gonna go ahead and remove protos-compiled label.


Potential Dos on account.get_utxo because it doesn't have limit

account.get_utxo endpoint doesn't have limit on numbers of items returned. this can break the whole watcher when get dos on an account that has high number of utxo

IMHO there is no link between #1257 and this #1274, info’s get_utxos and security’s get_exitable_utxo are different endpoints

IMHO there is no link between #1257 and this #1274, info’s get_utxos and security’s get_exitable_utxo are different endpoints

Ah sorry I didn't put why I thought they're related. Yup agree that they're different endpoints.
The only relation is that the discussions that took place were on utxos retrieval but there are actually 2 separate places to fix. So adding a relation here so we don't mistake fixing only one issue being "the utxos retrieval issue is solved"
I've added this reasoning to my old comment above. Thanks!

Fixed by https://github.com/omisego/elixir-omg/pull/1436


Screenshot URL broken in README

Looks like the screenshot in the "What it looks like" section is not available anymore.

Was it meant to be https://stripe.com/img/blog/posts/scaling-email-transparency/gaps.png ?

This has been fixed! Thanks for the report


Adding support for compressed stub for snappy compression

Proposal
Currently, wiremock does not have any support to internally compress the response for snappy compression, developers have to provide the compressed response as the stub to mock the response.
Request
Wiremock should internally check for the headers, if header contains: Accept-encoding: snappy, then the stub should be compressed automatically with sending content-encoding: snappy as the response headers.
References
No response

+1


Mayo: add version 0.8.0

Add bucket for Mayo application

[x] I have read the Contributing Guide.

/verify

/verify


Linemapped command output indents the trailing newline

This code:
    const CMD_INDENT: &'static str = "      ";
//...
            let result = command
                .output_and_write_streams(
                    line_mapped(std::io::stdout(), add_prefix(CMD_INDENT)),
                    line_mapped(std::io::stderr(), add_prefix(CMD_INDENT)),
                )

Expected: That it only affects the outputlines of the command being run.
Actual: It adds indentation to the trailing newline which affects the next output.
Example:
- Bundle install
  - Running `BUNDLE_BIN="/layers/heroku_ruby/gems/bin" BUNDLE_CLEAN="1" BUNDLE_DEPLOYMENT="1" BUNDLE_GEMFILE="/workspace/Gemfile" BUNDLE_PATH="/layers/heroku_ruby/gems" BUNDLE_WITHOUT="development:test" bundle install`
      Fetching gem metadata from https://rubygems.org/..
      Fetching rake 13.0.6
      Installing rake 13.0.6
      Fetching rack 2.2.3
      Fetching webrick 1.7.0
      Using bundler 2.4.5
      Installing webrick 1.7.0
      Installing rack 2.2.3
      Bundle complete! 3 Gemfile dependencies, 4 gems now installed.
      Gems in the groups 'development' and 'test' were not installed.
      Bundled gems are installed into `/layers/heroku_ruby/gems`
              - Done (5.733s)

The bundle install command returns a newline as the very last character and the line_mapped prefix of   is added to it and then the next line is appended with additional indentation.
The short term workaround is to add a println!() afterwards so it looks like this:
- Bundle install
  - Running `BUNDLE_BIN="/layers/heroku_ruby/gems/bin" BUNDLE_CLEAN="1" BUNDLE_DEPLOYMENT="1" BUNDLE_GEMFILE="/workspace/Gemfile" BUNDLE_PATH="/layers/heroku_ruby/gems" BUNDLE_WITHOUT="development:test" bundle install`
      Fetching gem metadata from https://rubygems.org/..
      Fetching rake 13.0.6
      Installing rake 13.0.6
      Fetching rack 2.2.3
      Fetching webrick 1.7.0
      Using bundler 2.4.5
      Installing webrick 1.7.0
      Installing rack 2.2.3
      Bundle complete! 3 Gemfile dependencies, 4 gems now installed.
      Gems in the groups 'development' and 'test' were not installed.
      Bundled gems are installed into `/layers/heroku_ruby/gems`

  - Done (5.733s)

However long term it would be nice to: not indent the final trailing newline or introduce a new method with that behavior

@schneems Is this issue fixed by the new build_output module? Or will it need a separate fix? Do we need any new tests in this repo for it, or is it covered by the tests added in #721?


Update Issue Templates

Is your feature request related to a problem? Please describe.
Issue templates need to be consistent across repos
Describe the solution you'd like
Update the repo to use the same solution as added here and here

Fixed with https://github.com/AlaskaAirlines/ODS-WC-Generator/commit/7f57397817a2855ab9264c890005d6d461da89e2


[Hacktoberfest] Covert PayPalScriptProvider.test.js to TypeScript

We have a bunch of tests that are still using plain JavaScript even though this library is written in TypeScript.
For this issue, convert the PayPalScriptProvider.test.js to TypeScript.

@gregjopa sounds interesting, I would like to take a look at it 👍

Hey Greg! I can take this up. Could you please assign it to me?

you may want to wait until we merge #174 (or cherry-pick the package.json changes from that PR) as I ran into some missing types and a mocking library which will probably be helpful for all the test file conversions.


Add data and/or content folder for static generated part of application

I plan on using nuxt generate to create static sites and blogs. Other alternates, obviously, are Jekyll, Hexo, Hugo, etc.
Currently, like the mentioned alternatives, nuxt provides:

layouts or templates
components or partials
dynamic urls or routing
assets (css, images, etc.)

However, the main features it does not provide:

Data files for reusable information that can be used inside pre-compiled files (this can be done inside HTML templates locally with the data component property, but there is no global data configurations that can be used inside markdown files before they are compiled as vue components)

Front-matter/metadata that facilitates content organization (e.g. by date, title, category etc.)

Before I go off and try to incorporate these features on my own, my question is: would it make any sense to incorporate these features into Nuxt?

Hi,
Nuxt-Modules will be available in the next release and will give you the opportunity to add such functionality to Nuxt.


Use PodPreset to complement PodPolicy

Currently most fields of PodPolicy can be replaced by PodPreset. For example, env, labels, etc. There might be more and more. It is native kubernetes objects and provides better modularity.

Another benefit of this is that it only needs some docs. No additional work :)


Windows log watcher still doesn't pick up new entries until kicked externally

Observed on a server running Windows Server 2012 R2. Though it has a recent build with the "kicker" thread enabled, the log content didn't appear until I ran an agent that listed the files in that directory.

I haven't seen this in a while, though I wouldn't be surprised if it's still there. I'll leave this issue open in case it shows up again.


Update Workload Admitted condition to true on a best-effort basis.

What would you like to be added:
Update the workload admitted condition to true when the workload gets admitted. Currently users can look at the admission field in the spec to check if a workload was admitted, we can sync that with the workload's admitted condition on a best effort basis. Meaning we can do it in the workload controller (we will get an event for the addition of the .spec.admission field).
Why is this needed:
Improves UX.

/assign

/kind ux


Can you clarify the training process?

There's no training code included in the repo, so it's hard to tell exactly how the training was done.
The paper states:
"We use the Pile dataset (L. Gao, Biderman, et al. 2020), and follow the training recipe described in Brown et al. (2020)."
Is this for the transformer models, or also for Mamba? The details of Brown training recipe have a number of different steps and parameters, which parts were used? The LR warmup over 375M tokens? The batch size linear increase from 32K tokens to 0.5M/1M/2M/3.5M tokens over the first 4-12B tokens of training?
The training details in E.2 say "By default, the peak learning rate is the GPT3 specification" or "a peak value of 5× the GPT3 value" in the improved recipe. Depending on the GPT-3 model size, the learning rate ranged from 6e-4 to 6e-5 -- Were different learning rates used to train the differently sized Mamba models?
The readme mentions that the models were trained with AMP. Can I assume that the whole forward function was wrapped in torch.autocast?
Thanks for any additional details you can provide, I'm trying to replicate the training for the smaller sized models in preparation for training a large model

"We use the Pile dataset (L. Gao, Biderman, et al. 2020), and follow the training recipe described in Brown et al. (2020)." Is this for the transformer models, or also for Mamba? The details of Brown training recipe have a number of different steps and parameters, which parts were used? The LR warmup over 375M tokens? The batch size linear increase from 32K tokens to 0.5M/1M/2M/3.5M tokens over the first 4-12B tokens of training?

For both transformers and Mamba. LR warmup 10% of the training steps (you can warm up for less as well, doesn't really change the end result). We don't do batch size ramp up, but keep batch size constant.

The training details in E.2 say "By default, the peak learning rate is the GPT3 specification" or "a peak value of 5× the GPT3 value" in the improved recipe. Depending on the GPT-3 model size, the learning rate ranged from 6e-4 to 6e-5 -- Were different learning rates used to train the differently sized Mamba models?

Yes, for the 125m Mamba model we use lr 3e-3, 350m we use lr = 1.5e-3 etc.

The readme mentions that the models were trained with AMP. Can I assume that the whole forward function was wrapped in torch.autocast?

Yes

Thanks for any additional details you can provide, I'm trying to replicate the training for the smaller sized models in preparation for training a large model

In general different hparams don't really change the end results, lr is prob the most important one.

Thanks, so just to be clear for the 790M model you do linear scheduling up to 5 * 2.5e-4 (the 2.5e-4 is from GPT-3 Large 760M) over the first 10% of tokens, and then cosine decay down to 1e-5?

Yes that's right.


[SPARK-31124][SQL] change the default value of minPartitionNum in AQE

What changes were proposed in this pull request?

AQE has a perf regression when using the default settings: if we coalesce the shuffle partitions into one or few partitions, we may leave many CPU cores idle and the perf is worse than with AQE off (which leverages all CPU cores).
Technically, this is not a bad thing. If there are many queries running at the same time, it's better to coalesce shuffle partitions into fewer partitions. However, the default settings of AQE should try to avoid any perf regression as possible as we can.
This PR changes the default value of minPartitionNum when coalescing shuffle partitions, to be SparkContext.defaultParallelism, so that AQE can leverage all the CPU cores.
Why are the changes needed?

avoid AQE perf regression
Does this PR introduce any user-facing change?

No
How was this patch tested?

existing tests

cc @maryannxue @JkSelf

Test build #119676 has started for PR 27879 at commit 6db3394.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24405/
Test PASSed.

Test build #119679 has started for PR 27879 at commit 73e74ed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24408/
Test PASSed.

Test build #119676 has finished for PR 27879 at commit 6db3394.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CoalesceShufflePartitions(session: SparkSession) extends Rule[SparkPlan]

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119676/
Test PASSed.

Test build #119679 has finished for PR 27879 at commit 73e74ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119679/
Test PASSed.

Also, do we need to update the default value of minNumPartitions in ShufflePartitionsCoalescer.coalescePartitions?

We may can remove  the default value minNumPartitions in ShufflePartitionsCoalescer.coalescePartitions.  And also pass the sparkSession in OptimizeSkewedJoin to get the SparkContext.defaultParallelism when reducing partition number  in the rule of OptimizeSkewedJoin.

We may can remove the default value minNumPartitions in ShufflePartitionsCoalescer.coalescePartitions.

We can remove the default value, but it may not be a good idea to pass SparkSession, as it makes the method harder to test.

Test build #119695 has started for PR 27879 at commit 6a587d9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24424/
Test PASSed.

Test build #119697 has started for PR 27879 at commit 4f1b33b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24426/
Test PASSed.

LGTM.

Test build #119695 has finished for PR 27879 at commit 6a587d9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #119697 has finished for PR 27879 at commit 4f1b33b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119697/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119695/
Test FAILed.

retest this please

Test build #119703 has started for PR 27879 at commit 4f1b33b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24433/
Test PASSed.

Test build #119703 has finished for PR 27879 at commit 4f1b33b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119703/
Test PASSed.

thanks for review, merging to master/3.0!


Usage examples

It may be me, but is there a better usage example for how we would proceed after wait-for completed?
I use docker-compose and have no idea what to do, i.e. how to run another command in a container after this is finished.
Would you be able to provide at least another example on how this works in practice?
Thanks.

You can use wait-for command inside the command property of a service in your docker-compose.yml.
In the following example, you can see two services: the first one is a PostgreSQL (postgres) and the second one
a Flyway container (schema). The Flyway waits for PostgreSQL to be available and then run the migration command:
version: '3'
services:
  postgres:
    image: postgres:11-alpine
    container_name: postgres
    ports:
      - 5432:5432
    volumes:
      - ./init.sql:/docker-entrypoint-initdb.d/init.sql

  schema:
    build:
      context: .
      dockerfile: Dockerfile
    container_name: flyway-postgres
    command: >
      bash -c "wait-for --type postgres \
        --host postgres \
        --port 5432 \
        --user test \
        --password test \
        --name test \
        --seconds 2 \
        --maxAttempts 20 && \
        flyway \
          -url=jdbc:postgresql://postgres:5432/test \
          -schemas=test \
          -user=test \
          -password=test migrate" # Here
    volumes:
      - ./migrations:/flyway/sql
      - ./drivers:/flyway/drivers
    depends_on:
      - postgres

And inside the schema Dockerfile we add wait-for v0.0.3 to do that:
ENV WAIT_FOR_VERSION=v0.0.3

# Adding wait-for
RUN wget "https://github.com/ArcanjoQueiroz/wait-for/releases/download/${WAIT_FOR_VERSION}/wait-for" \
  && chmod u+x wait-for && mv wait-for /usr/local/bin/wait-for \
  && echo -ne "- with Flyway $FLYWAY_VERSION\n" >> /root/.built

Wait-for follows the Unix programming convention, so you can use as you wish.
I am going to add some examples inside examples directory.

That's fantastic, thank you very much :)


Test virtual document links

[x] any os @bpasero
[ ] any os @kieferrm

#3676, make sure links in virtual document. Test that:

you link to a document on disk, e.g file:///Users/far/b.oo
you link to a virtual document, e.g. virtual:some/path
you can jump to a line using the #L32 notion, file:///Users/far/b.oo#L42
you can invoke a command using using the command scheme and the command as path, like so command:deleteLeft
you can invoke a command with arguments by adding a JSON-array of them as query

@jrieken can you give an example for how a link needs to look like if you want to execute a command?

Nevermind, found it! E.g. "a href='command:workbench.action.zoomIn'"


checked mode not checking return type of async function

import 'dart:async';

var r = 'a';

Future<int> foo() async {
  return r;
}

main() {
  foo().then((_) {
    print("no error");
  });
}

This should error when compiled with dart2js in checked mode, but it prints "no error"

This is working as intended. The dynamic return-type of any async function is Future<dynamic>, which is assignable to Future<int>.

I still think this is a bug. Section 17.12 of the spec contains:
Let S be the runtime type of o [the returned object]. In checked mode:
• If the body of f is marked async (9) it is a dynamic type error if o is
not null (16.2) and Future<S> is not a subtype of the actual return type
(19.8.1) of f.

The "actual return type of f" is defined to be the declared return type of f as it appears in the program source code, in this case Future<int>. So I believe the spec is saying this should be a dynamic type error in checked mode.

Interesting. I didn't remember that this was part of the spec.

I'm closing this since strong mode will check the types once https://github.com/dart-lang/sdk/issues/32830 is implemented.


Purpose of yosys and difference of verilog file before and after yosys

Is the main purpose of yosys to create a .blif file? . After yosys, i get 2 files .blif and output_verilog.v.  File output_verilog.v to simulation but I realize the function of the 2 benchmark before and after yosys is different.

Befor yosys
```
wire q_next;
assign q_next = Q & D;
always @(posedge clk or negedge reset_n ) begin
if(~reset_n)
Q <= 0;
else
Q <= q_next;
end

+ After yosys **output_verilog.v**

assign 0 = 8'h80 >> { reset_n, D, Q };
always @(posedge clk)
Q <= 0;
This difference makes the output of **output_verilog.v** after simulation is X
To solve this problem, I see your examples always initializing the output. Is this mandatory?
how to solve this when the benchmark has a large number of outputs?

My suggestion is to initialize the values, which makes Yosys happy.


Fix most compiler warnings

Motivation and Context
Compiler warnings make it hard to find actual errors and make people think its okay to have warnings as they add code. This PR removes most of them.
Side note: we should consider turning on -Werror to treat warnings as errors.
How Has This Been Tested

tests pass

Types of changes

[x] Docs change / refactoring / dependency upgrade

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

As @aclegg3 pointed out as well, I would keep parameter names in the *.h files for documentation purposes, and use either CORRADE_UNUSED or static_cast<void>(foo) to suppress warnings.

we should consider turning on -Werror to treat warnings as errors

I don't recommend that, often a minor compiler / dependency upgrade causes warnings to appear, and -Werror is then blocking further progress until the warning is circumvented. (Also Magnum is issuing deprecation warnings on API upgrades, and treating those as errors would basically go against my effort of providing backward compatibility.)


Add Excluded Locations setting

Adds a setting to the menu with “None”, “Mask of Truth”, and “40/50/MoT” options. These locations won't appear on the checklist. Settings presets are updated accordingly.

I like the idea. I would want something more general though, similar to rando's interface for all possible locations.

I mostly went with the presets because SAWS has a lot of excluded locations and it would be annoying to have to select them manually every time.

This feature has been implemented for all possible locations in each supported randomizer branch. See Disabled Locations in the game settings tab.


ruby template

A rewritten ruby template.

So, I finally got around to looking at this.  Code seems to work fine, however your patch strips out all comments, including the copyright.

The  git diff  is confused.   The script is a full write from scratch and
it just shares the same name.   That said,  I officially cede all ownership
of this script to you for your use and abuse.
Regards,
James
On Mon, May 29, 2017 at 9:11 PM, Brian Gallew<EMAIL_ADDRESS>wrote:

So, I finally got around to looking at this. Code seems to work fine,
however your patch strips out all comments, including the copyright.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BrianGallew/script_templates/pull/3#issuecomment-304770261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDuLbPIXIqlmRhcnbNOyHw8ohCHJ5zMks5r-5bWgaJpZM4NLu6-
.


Update Makefile with -march=native for 25%+ CPU speedup

-march=native Results in a 25%+ speedup on all the platforms I've tried, for train_gpt2
model name      : Intel(R) Core(TM) i3-9100F CPU @ 3.60GHz
step 0: train loss 5.356172 (took 15197.876634 ms)
vs
step 0: train loss 5.356185 (took 10418.548668 ms)

model name      : AMD Ryzen 5 3600 6-Core Processor
step 0: train loss 5.356173 (took 3599.359234 ms)
vs
step 0: train loss 5.356185 (took 2708.045790 ms)

doh, missed this flag when I was porting Makefile from llama2.c, nice find.
I don't get speedup on macOS but I do get the speedup on my linux box.
Thank you!


ChatGPT support

Why are these changes needed?
Support tuning ChatGPT models.
Related issue number

Checks

[x] I've used pre-commit to lint the changes in this PR, or I've made sure lint with flake8 output is two 0s.
[ ] I've included any doc changes needed for https://microsoft.github.io/FLAML/. See https://microsoft.github.io/FLAML/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

"The following code will take a while to evaluate all the 144 test data instances. Compared to the baseline success rate (46%) on the HELM benchmark, the tuned config has a success rate of 71%" It sounds like 46% is the success rate of chat.

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

"The following code will take a while to evaluate all the 144 test data instances. Compared to the baseline success rate (46%) on the HELM benchmark, the tuned config has a success rate of 71%" It sounds like 46% is the success rate of chat.

I removed the confusing words. Could you check again?

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

Chat and Completion have the same HELM success rate (46%) on HumanEval? Possible typo?

The 46% is the number from HELM. HELM doesn't have numbers for Chat.

"The following code will take a while to evaluate all the 144 test data instances. Compared to the baseline success rate (46%) on the HELM benchmark, the tuned config has a success rate of 71%" It sounds like 46% is the success rate of chat.

I removed the confusing words. Could you check again?

looks good to me


Configure to use C++ on .h files

Hey guys, I'm using C++ to do some work development. I don't use a compile_commands.json because the compilation environment runs on a VM, so generated compile_commands.json use VM's paths. But I configured the flags manually with compile_flags.txt file, just have a few flags.
I noticed that .h are triggering C and not C++ language. So when I open these kind of file I got an error of "Invalid argument" for using -std=c++11 flag. Also got some errors for STL includes, like map or string. I believe this can be solved with some easy configuration but really don't know how to do it.
PS: I just installed coc.nvim plugin and coc-clangd. Besides that, the only configuration I've done was the compile_flags.txt file.

Yes, -xc++ or -xc++-header is the flag you want.


Tabs are overlapping the search bar when not maximized

Hello,
as you can see in the screenshot below, the tabs are overlapping the search bar when firefox is not maximized.

When i maximize firefox, i dont have this issue. Either way, thank you for making this theme, looks really good!

https://github.com/vinceliuice/WhiteSur-firefox-theme/commit/157812e789358475e765da1f692db698fc7c5bd0
I can see in this commit that it should have fixed it, but i guess not.

Oh nevermind this gets fixed if i uncheck the titlebar option in customize toolbar. But now, the buttons are right, instead of left.

and also overlapping


continuous notification "The mode has failed while tokenizing the input"

VSCode Version: Kode Studio 1.4.0 (c9038f8e16ebca8ffc83e6dd81e38f0bb8cf1cea, 2016-08-24T18:33:53.502Z)
OS Version: Linux x64 4.7.0-sabayon

Steps to Reproduce:

open any file
open another file

I've seen that once when somebody copied a new version of Kode Studio into an old Kode Studio directory. Did you maybe do that?

Hmm, i don't think so.

I think i better reinstall or build form source or something. I'm having difficulty with kha.khaPath as well. The path is correct but it reports to not find anything in the depth of the path. On top of that /kha contains .current which reads 16.1.2 but the folder reads /kha/16,1,2/

It's a real mess, nothing of the code i've tried works as expected.

I think i had been naieve and used the master branch, trying with v16.7.x

No change, remove ~/.kodestudio, installed from https://github.com/KTXSoftware/KodeStudio/releases/download/v16.7.3/KodeStudio-linux64.zip same message when opening a file "The mode has failed while tokenizing the input"

This is what i get starting kodestudio from a shell
./kodestudio
bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell

Version 16.7.3
Commit e698221ac971850e0a3766dc5bafda21e7ee796d
Date 2016-08-03T19:24:49.649Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0

This is stupifying, i see a tutorial work but none of this works with this version or any other of KodeStudio on Linux ( Sabayon/Gentoo)

This error is not displayed with vscode when run from http://code.visualstudio.com/docs/?dv=linux64

Two things to try: Get the current version (which is 16.8). And don't use haxelib Kha with Kode Studio, that's a super outdated version of Kha which doesn't work with Kode Studio. Don't know how any of that could get you that particular error message though, still worth a try I guess.

Same problem. All tested.
Honestly, i'd prefer to have an extension for Kha on VsCode than KodeStudio. It's very buggy.

Ah, so you are the guy from the forum. I don't understand how you get to the conclusion "it's very buggy" because of a single problematic installation. I'm not interested in providing vscode extensions, Kode Studio has changes to vscode itself which I can not replicate in an extension and I witnessed more than one person who failed to even setup vshaxe correctly (vs one person who failed to get Kode Studio running).
Do you get any additional messages when you run Kode Studio from a terminal? Maybe some .so files are linked to a clib you do not have.

Thanks for explaining. I've not found a way to diagnose what's going wrong, all i know it's not an issue with vscode.

I'm very interested in getting Kode Studio to run everywhere though so I hope you won't run away.
Can you help me out to find the sabayon version you use so I can try myself? 4.7.0 is the kernel version, right?

Thank's, i'm willing to help in any way i can. Yes , this is a 4.7.x version of the kernel.
I thought of rebuilding it from source but the process is not entirely clear to me.

What i can do is provide output from strace such as for $strace -f -o kodestudio-strace.log ./kodstudio
Could this be of interest to you?

Cool! Yes, strace could prove very useful.

One of the reasons i entered the rant (sorry) is the extensions also did not load. I'll try and provide the strace feedback asap.

Extensions should work fine (though you have to download them manually). Guessing the problems are closely related.

I just found this: https://forums.bistudio.com/topic/182917-vs-code-sqf-visual-studio-code-sqf-language-release-arma-3-arma-2/ Pointing to a similar but not identical issue.

@RobDangerous I've finaly come round to uploading an strace output, it's quite big but i assume you'd know what you'd be looking for.
tracelog_kodestudio.txt

Hey guys
I just downloaded this in my CentOS 7 box and I get the same error
had nothing before today related to Kha, there's no Haxe related stuff in this machine whatsoever actually hehe.
Running from terminal shows no issues at all.
thanks

Hm, about time to fix this. Downloading CentOS...

Could finally reproduce. One step further...

So, I think it's Linux problem No 1 again - wrong glibc. If you replace resources/app/node_modules/oniguruma/build/Release/onig_scanner.node with the one in vscode 1.7.1 it works fine. Will use an older gcc to build the next release or just copy the libs from the vscode release.

oh yes that works, thanks
yeah Centos is not very modern, stays behind a while, I use it because most of the VFX/3D apps I use run better here, most developers use redhat or centos to develop so, less issues when running this apps.
thank you Rob

Glad I finally figured it out. @oxitech239 can you test if that fixes it for you, too?

Awesome, let's have a look

Confirmed, it fixed the issue. Thanks.


Capture build scans on ge.apache.org to benefit from deep build insights

This PR publishes a build scan for every CI build on Jenkins and GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.
The build scans of the Apache Groovy project are published to the Gradle Enterprise instance at ge.apache.org, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by the Apache Groovy project and all other Apache projects.
Currently, the Apache Groovy build is configured to publish build scans to the publicly available scans.gradle.com. This pull request enhances that functionality by instead publishing build scans to ge.apache.org. On this Gradle Enterprise instance, Apache Groovy will have access not only to all of the published build scans but other aggregate data features such as:
Dashboards to view all historical build scans, along with performance trends over time
Build failure analytics for enhanced investigation and diagnosis of build failures
Test failure analytics to better understand trends and causes around slow, failing, and flaky tests
Very soon, we will follow up this PR with one that connects the Apache Groovy build to a remote build cache node solely for the Apache Groovy project to further help speed up builds with build caching.
If interested in exploring a fully populated Gradle Enterprise instance, please explore the Maven builds already connected to ge.apache.org, the Spring project’s instance, or any number of other OSS projects for which we sponsor instances of Gradle Enterprise.
Please let me know if there are any questions about the value of Gradle Enterprise or the changes in this pull request and I’d be happy to address them.

The old build had an opt-out mechanism. Is this easy with the changes?

The old build had an opt-out mechanism. Is this easy with the changes?

Good question. The added publishIfAuthenticated requires the user running the build to be authenticated to ge.apache.org. ASF committers can authenticate local builds by logging in to ge.apache.org with LDAP credentials and creating an access key. So effectively, this changes to opt-in rather than opt-out.

Merged, thanks!


Set npm/yarn/pnpm version

Description:
Similar to how we can set the node version I'd like to set the npm version.
node-version: 1.16.x
npm-version: 8.5.5

There is a similar issue here https://github.com/actions/setup-node/issues/213, but it's for a different reason and this one can be resolved by setting the node version. However this is not enough for the problems I have been facing.
Justification:
Currently I am struggling with a bug in npm from versions 8.11 to 8.13. These are automatically installed when you chose node version 1.16. This means I have to set back my npm version so the ci can run, which I can do in an extra ci step.
However to me the issue is that the npm version will change over time, without our input. We'd like control over this to prevent issues like the one above from showing up.
Are you willing to submit a PR?
Not currently but I might in the future.

Hi @stijn-gravity, thank you for your proposal, we will consider it.

I will be opening a PR on this!

Two options for specifying a solution could be querying the volta section of the package.json if you manage versions via that, or via the engines portion of the package.json https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines

With corepack support in #482 you can set yarn/pnpm version.
You can also "set" npm/yarn/pnpm version if you manually install them:
npm install<EMAIL_ADDRESS>yarn set version a.b.c
npm install<EMAIL_ADDRESS># Or use pnpm/action-setup which has a version option

This should be solved by #531

Also see #546


[Snyk] Upgrade @hashgraph/sdk from 2.18.5 to 2.28.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @hashgraph/sdk from 2.18.5 to 2.28.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 28 versions ahead of your current version.
The recommended version was released a month ago, on 2023-06-23.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Closing this as this dependency can't be changed as it's part of the examples


🌐 Modify the description of zh - Traditional Chinese

As people are adding Traditional Chinese support to the document, the description of zh has been changed from Chinese (汉语) to Simplified Chinese (简体中文) for better differentiation (https://github.com/tiangolo/fastapi/pull/10505).
It might also be worth switching from zh to zh-hans, but that would cause a lot of merge conflicts.

📝 Docs preview for commit 38e565ba76287f3d47fae5a17976703dfdde1704 at: https://9fd0a301.fastapitiangolo.pages.dev

Great, thank you @cherinyy! And thanks for the review @mahone3297 🍰


Updated translations

Delta translations for all languages.

@sara-akhtar You'll need to resolve the merge conflicts before this will build.

@matthoward366 can this get merged in?


fix tooltip with overlapping points

I believe this will resolve #221

@senluchen2015: @drosen0 closed this without merging because related issue #221 was closed as not a bug.

Reopening because Contour is calling the custom formatter with the wrong data point.


Refine the theming docs

I refined the content of the theming documentation to be more user-friendly and more complete.

The module upath is causing trouble; we either have to update it or redefine the node version (v.9) on Netlify.

Hi, are you still considering updating the theming docs?


cmd ref: status: ignoring cache that is not in local cache nor in remote

Command reference for status should probably describe situation when target is missing both in local cache and remote.
Target missing both in cache and remote may happen if Alice executes dvc add data.csv, git add data.csv, git commit and git push but doesn't execute dvc push and Bob executes dvc status -c data.csv on another machine.
For context see https://github.com/iterative/dvc/issues/4383

It should be probably described in "Examples" section but I was unable to come up with nice and simple one therefore it's only issue and not PR.

Good idea for a note or example. We could also clarify the bullet list in the Description: some bullets are confusing e.g. "new" inside "changed deps or changed outs", and the explanation of "not in cache" seems contradictory.

OK so in summary, we agree to add a missing bullet to https://dvc.org/doc/command-reference/status#comparison-against-remote-storage 🙂


Replace Angular's $location service

The use of Angular's $location object should be replaced. Make sure the tests still pass for all the chapter navigation stuff. This will involve mocking the path behavior. We should create our own $Path substitute in the utility module that exposes the same API and produces the same output to avoid rewriting code/tests.

Working this ticket on branch: https://github.com/MapStory/story-tools-composer/tree/dja-replace-location-svc