Fix RTL support for sidebar and icon badge

[x] Changes have been thoroughly tested to not break existing functionality.
[ ] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Before

After

I saw this, that this is for padding, i don't know why,
I am trying to find the cause of this

its working well when change content width

This issue is Mozilla browser related, as it works fine on Chrome and Safari.

Hmm, weird that the padding is wrapping to a new line.


Test against shapely pre-release

This PR resolves  #678.

- package shapely-2.0b1-py37h649dd7e_0 is excluded by strict repo priority

It seems that micromamba is not happy about mixed channels. We can potentially install It from PyPI if it makes it easier. We do it in GeoPandas as well https://github.com/geopandas/geopandas/blob/403b7fa936bcae58134efbca51e10dce7a7c6639/ci/envs/39-latest-conda-forge.yaml#L39-L41

This actually seems to be more complicated than expected.

the env still shows 1.8.5 somehow
I've noticed that there is pygeos installed as well. In that case, we need to ensure that we have set and env variable USE_PYGEOS=0 to ensure shapely is actually used. (https://geopandas.org/en/stable/getting_started/install.html#using-the-optional-pygeos-dependency)

this is weird.
I can fix this.

Can we try the conda way again and set channel-priority to flexible? https://github.com/mamba-org/provision-with-micromamba#channel-priority
Hope it does not mess the other envs...

Got it 🎉


[PodSetInfo] Skip duplicate Tolerations during merge.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Skip duplicate Tolerations during PodSetInfo merge.
Which issue(s) this PR fixes:

Fixes #2427
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Skip duplicate Tolerations during PodSetInfo merge.

What is the user-facing behavior? The release note talks in terms of code.

/release-note-edit
Skip duplicate Tolerations when an admission check introduces a toleration that the job also set.

/cherry-pick release-0.7


Can't get correct ~ ($HOME) within cap rake task.

Steps to reproduce
Because i set deploy_to to a string prefix with  ~/app (use ~ instead of $HOME)
set :deploy_to, "~/apps/#{fetch(:application)}_#{fetch(:stage)}"

it expand well when deploy use cap.
But, when i create a new cap task like this to try to get the absolute path of deploy_to, it get wrong result.
# ...
# expand ~ into my local laptop $HOME, this is not correct.
Pathname("#{deploy_to}/current/config/#{service_name}").expand_path # => /home/zw963/current/config/

# I have to workaround to use following command get correct result.
capture("cd #{deploy_to}/current/config/#{service_name}; pwd") # => /home/deployer/current/config

# ...

So, is there exist a correct way to do this? which i don't know?
Thank you.

My recommendation is to use the explicit path instead of relying on the shell to expand it for you. In this case, you know that the home directory of the deployer user is /home/deployer. So use that in your :deploy_to setting. This is how I've always done it.
set :deploy_to, -> { "/home/deployer/apps/#{fetch(:application)}_#{fetch(:stage)}" }

Note that this will not work:
Pathname("#{deploy_to}/current/config/#{service_name}").expand_path

That is because Pathname and .expand_path are plain Ruby concepts that don't know anything about the remote host that you are interacting with in Capistrano. They will always be evaluated locally to your laptop. In Capistrano, Ruby code is never executed on the remote host. Only the shell commands inside strings, like "cd #{deploy_to}" are actually executed remotely.

@mattbrictson , so, double confirm, there is never exists a ruby block way, to wrap all ruby code to run only on remote ruby environment on remote server, right?

What i means is, there maybe exists a block, e.g. like
within release_path do
   # we know we run command within release path
end

so, i curious, if exists another block like this.
eval_on_remote_server do
   # some ruby code will eval on remote server
end

I spend hours to try to write one task like this:

read a file use ruby ERB from remote server
read a yaml file and parse it from remote server
generate parsed content
save those content into a new file on remote server.

project_config_file = "/home/deployer/app/current/config/nginx_production.rb"

# step 1, it work
erb = ERB.new("#{capture("cat #{project_config_file}")}")

# step 2, it work
config = YAML.load(capture("cat #{deploy_to}/current/system_config.yml")).dig(service_name, fetch(:stage).to_s)

# step 3, works

content = erb.result_with_hash(config).to_s

# step 4, i want to save content into a new file, with same name, same format, how to do that from a cap task?

Following is my attempt:

execute "cat <<< \"#{xx}\" > #{project_config_file}"

it not work, because generated string all "\n" stripped, e.g. original nginx config change to like this:
upstream app_server {; server <IP_ADDRESS>:3000;; }; ; server {; listen 80;; server_name localhost;; ; location ~ \.(aspx|php|jsp|cgi)$ {; return 410;; }; ; location / {; proxy_set_header X-Forwarded-For ;; proxy_set_header Host ;; proxy_set_header   X-Real-IP   ;; proxy_pass http://app_server;; proxy_buffering on;; proxy_buffers 32 16k;; proxy_set_header   Upgrade ;; proxy_set_header   Connection Upgrade;; # gzip off;   # 当 https 时, 应该关闭?; }; ; location ~ \.(js|css) {; root /home/deployer/apps/marketbet_crawler_production/shared/public;; gzip_static on;; expires max;; add_header Cache-Control public;; add_header Access-Control-Allow-Origin *;; }; }

Can you please give me some idea about how to resolve this?
i can't find answer on stackoverflow, thank you.

so, double confirm, there is never exists a ruby block way, to wrap all ruby code to run only on remote ruby environment on remote server, right?

Correct. Capistrano has no ability to run code in a remote ruby environment.
The only way you could hack it is by manually invoking the ruby interpreter. Assuming ruby is installed on the remote host and in the PATH, you could theoretically do this:
on roles(:app) do
  output_from_remote_ruby = capture(%Q{ruby -e 'puts "hello from remote ruby"'})
end

Probably not what you want. 😅

it not work, because generated string all "\n" stripped

I'm not sure capistrano can accomplish what you are trying to do. If you pass a string to execute that contains newlines, capistrano assumes you mean to run several individual commands separated by newlines. You can see that code here:
https://github.com/capistrano/sshkit/blob/7473458b0422e27dbcadcdcfcffa65fa46bb64c1/lib/sshkit/command.rb#L236-L238
The only thing I can think of is using the upload! approach. Capistrano (via SSHKit, on which it is based) has the ability to upload a file or a string from your local machine to a path on the remote host. Check out the examples here:
https://github.com/capistrano/sshkit/blob/master/EXAMPLES.md#upload-a-file-from-disk
Anyway, this conversation has now strayed pretty far from the original topic ("Can't get correct ~ ($HOME) within cap rake task") and GitHub issues is not a general support/discussion forum, so I will close this issue. Good luck!

@mattbrictson
I resolve this issue use you suggested ruby -e solution.  ; )
like this: (add to cap task)
if project_config_file.extname.end_with? ".erb"
      new_project_config_file = project_config_file.sub_ext('') # remove .erb suffix
      ruby_script = <<-HEREDOC
require 'erb'
require 'yaml'
erb = ERB.new(File.read("#{project_config_file}"))
config = YAML.load_file("#{_deploy_to}/current/system_config.yml").dig("#{service_name}", "#{fetch(:stage)}")
File.write("#{new_project_config_file}", erb.result_with_hash(config))
HEREDOC
      execute "cat '#{ruby_script.inspect}' |ruby"
    end

It dirty, but work anyway, thanks for you help.

BTW:  i don't remember the exact reason i use ~ in my cap config like this
set :deploy_to, "~/apps/#{fetch(:application)}_#{fetch(:stage)}"

but, in fact, i can add above code into config/deploy.rb instead individual stage file, anyway, eliminate duplicate code.


python extension can't convert .ipynb to .py

I downloaded a vscode before, then I downloaded anaconda. And I found anaconda is very useful, especially jupyter, so I want to combine its function with vscode.
I have tried to operate jupyternotebook to the vscode for a long time, but it doesn't work even once. I'm very upset, so I came here for professional help.
I have to admit that I am a novice in this area, here is the specific situation.
OS：windows 10
the latest version of vscode and anaconda with jupyter
the situation is that I can't open a ipynb file in the format of py (with run cell icon, etc.)
when I click "import jupyter notebook to python code", it doesn't give a respond.
Then I try to use the #%% to create a test file, but when I click the run cell button, there comes an error report shows "Executing code failed : Error: Activating Python 3.7.3 64-bit ('base': conda) to run Jupyter failed with Error: StdErr from ShellExec, ϵͳ�Ҳ���ָ����·���� ."
I am desperately helpless, and I will appreciate your help!

I'm reproing this right now using VS Code 1.61-insiders and the latest Jupyter insiders extension.

More specifically, I chose: File->Convert Notebook to Python Script and I get an export error:
> ~\AppData\Local\Programs\PythonCodingPack\python.exe -m jupyter nbconvert --version
Info 2021-09-21 13:34:57: Process Execution: > ~\AppData\Local\Programs\PythonCodingPack\python.exe -m jupyter nbconvert --version
> ~\AppData\Local\Programs\PythonCodingPack\python.exe -m jupyter nbconvert --version
Error 2021-09-21 13:34:58: Export failed Error: Importing notebooks requires Jupyter nbconvert to be installed.
    at g.importFromFile (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:52:972930)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at s.export (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:52:922146)
    at b.exportToFormat (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:52:919661)
    at b.performExport (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:52:918846)
    at b.export (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:52:918360)
    at c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:90:268958
    at u.waitWithStatus (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:90:232715)
    at k.importNotebookOnFile (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:90:268881)
    at k.listenForErrors (c:\Users\jimg\.vscode-insiders\extensions\ms-toolsai.jupyter-2021.9.1001256920\out\client\extension.js:90:264660)
    at a._executeContributedCommand (c:\Users\jimg\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:94:112416)

latest issue is just dealing with exporting a notebook, not Interactive window


Improved flows dx

[BREAKING CHANGE] Again changes to flows so typings are better. Check the updated flow section of the documentation to see how to work with them now (should be much easier).

Coverage decreased (-1.3%) to 88.269% when pulling d952d97b496008cc3bfc311f12d4ca4527c6b347 on improved-flows-dx into e42f941a464b8bd84c6706cb54691f99dfb3630a on master.


Build task removes slashes in path

Issue Type: Bug
After I updated to the current version, when running a task I am now getting an error saying the path doesn't exist because the \ have been removed.
I have no .vscode/tasks.json file set up. All I have is a tsconfig.json, and that is what I am telling the editor to watch. Before, it would run the task, now it is removing the slashes when running the task.

Executing task: tsc --watch -p c:\Users\rnaddy\Documents\vscode\projects\red5\tsconfig.json <

error TS5058: The specified path does not exist: 'c:UsersrnaddyDocumentsvscodeprojectsred5tsconfig.json'.
 Which shell do you have configured for the terminal?

@dbaeumer I am using git bash for my terminal

I have the same issue, running on Win 10 x64, and I am also using Git Bash as a terminal.

This is a know issue when using bash. Dups https://github.com/Microsoft/vscode/issues/35593.
Currently the task engine assumes that when running under Windows the path separator is \. However this is not true for bash implementations.


problem with 11.10

trying out teleport with new Ubuntu 11.10 server.
README states 11.10 is supported, comment in output "warning - Ubuntu 11.10 hasn't been tested with Teleport yet "
when trying to run teleport with a Telfile of only
ruby "1.9.3"

gives an error
Reading state information...
Package libreadline5-dev is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  libreadline-gplv2-dev lib64readline-gplv2-dev

E: Package 'libreadline5-dev' has no installation candidate
[14:07:56] Failed!

Hi anithri. Support for 11.10 is in the master branch, but not yet released. I should have it out within the next few days. You can try it with master or just wait for the release. Thanks!

Anithri - Teleport 1.0.4 is out now, with support for 11.10. Let me know if you have any problems!


[Responsive Navigation] Drilldown doesn't work with visibility class

How can we reproduce this bug?

Create a menu using data-responsive-menu, but hide one of the <li> using .show-for-medium
Open the page on small screen

What happened instead?
The menu has now a 0px height
Here is a codepen to see this nasty bug in live ^^ http://codepen.io/anon/pen/MKgwVW

In my opinion this bug is quite specific but come from
https://github.com/zurb/foundation-sites/blob/develop/js/foundation.drilldown.js#L297
The menu height is calculated from the first element height (with is 0 since it's hidden for small screens).

Awesome. Thanks for pointing this out.


improve code snippet under Extension attributes

fix:

reference: https://learn.microsoft.com/en-us/azure/active-directory-b2c/user-profile-attributes#extension-attributes

@kengaderdus
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@spottedmahn
Thank you for your contribution. #sign-off


[Feature] Deprecated flag for icons

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #224 #225
Summary:
This PR is to provide new deprecated flag for the icons data, which is used to alert consumer for a lists of deprecated ones. #225
Type of change:

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 4.34.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Configurable release name and tag name in config file

Added optional config:

release name (default value: version_to_release)

release:
    name: "Release Name"

tag name (default value: version_to_release)

tag:
    name: "Tag Name"

@enzoLorenzo thank you so much for contribiution!
Can you provide test verifing if we can use varaibles in this name?
Can you add this information do README.md ?

Dear @enzoLorenzo ,
I want to take a moment to express my sincere gratitude for your invaluable contributions to the valhalla project within the logchange organization. Your dedication, expertise, and hard work have made a significant impact, bringing us closer to our goals.
The effort you’ve put into this is truly commendable, and it does not go unnoticed. Your commitment to excellence and innovation has been a driving force in making the project a success.
Thank you for being an integral part of this journey. Together, we’re building something remarkable, and I’m excited to see what the future holds for Valhalla with your continued support.
With appreciation,
logchange Organization
cc @witx98


Small Fix in README Examples + Angular2 wrapper

Hi,
thanks for this module.
Some points i found:
Code Examples
The 2 examples in readme is not working because the js link has change to https://szimek.github.io/signature_pad/js/signature_pad.js
The links that are wrong:
Other demos
Erase feature: https://jsfiddle.net/szimek/jq9cyzuc/
Undo feature: https://jsfiddle.net/szimek/osenxvjc/

Smooth
In the main demo, when i draw i can see some smooth in the line thickness.
But using this wrapper it does not work like that.. any ideas how this can be fixed?
https://github.com/wulfsolter/angular2-signaturepad/issues/61
Thanks!

Thanks for reporting these issues! I've already fixed both examples.
Regarding the Angular wrapper - I'm not really sure. The demo at http://lathonez.com/angular2-signaturepad-demo/ seems to work fine. You can play with values of minWidth and maxWidth and see if changing them makes any difference.

Awesome!!
Well.. i used the vanillajs and have the smooth behaviour.. so its something related with the wrapper..
thanks!


Remove casablanca lib as a dependency

Remove casablana lib as dependency, just pulling in headers/implementations of things we actually care about.  Still need to move to libHttpClient web sockets and remove casablanca ones.
Adding Xbl task wrappers
Wrapping up many todos

#define XBOX_SERVICES_API_VERSION_STRING "2<IP_ADDRESS>";

need to alter Utilities\VSOBuildScripts\preCompileScript.cmd to match.  simple edit

Refers to: Source/Shared/build_version.h:6 in 6f85e17. [](commit_id = 6f85e1756397c8d46a3479e5df8ee980e768047f, deletion_comment = False)


New nodes: R datasets, Table [Plotly]

Two new nodes were added: R Dataset and Table

Please always include a handful of app and ctrl panel screenshots!
In the ctrl panel, please make sure that the table uses colors from the Figma flojoy brand guide
plotly's table looks pretty bad in small (thumbnail) formats - in the flow chart app, probably want to show only preview the first 2 columns and 4 rows for a table node

Please also move the example app over to the docs repo https://docs.flojoy.io/
We're going to keep example apps in the docs repo instead, and delete the apps repo


Adding different Box layouts example

So there is a layout example currently. I could add AspectRatioBox to that layout example but I feel like it would be lost amongst the other elements. Could I add an example that shows off the different types of "sized boxes". Eventually there will be, AspectRatio, ConstrainedBox, UnconstrainedBox, FractionallySizedBox and a few more I believe. I feel like all of these and SizedBox, should be within one example that demonstrates them all.

I would ultimately like to reduce the total number of examples, but I can see how your idea could be helpful. What I think might be helpful is eventually splitting out the 'layout' widgets from other widgets (a widgets::layout module?) And then having good documentation there that describes the different layout widgets and what you might want to use them for.

Do you count things like FractionallySizedBox and AspectRatioBox as layout? If so then, maybe there could be something like https://flutter.dev/docs/development/ui/layout/constraints but for druid. Maybe it could be a tour of layout and pitfalls to look out for. So instead of thinking of how to understand constraints, it can go into how to use the widgets to affect layout. The tour of layout and how to use the different widgets could maybe go in the book. The actual docs could link to this tour. I'm not too sure.
Maybe there could also be a place to write about constraints, but this should probably go in the Druid book. The layout model shouldn't change right? So this kind of documentation wouldn't have to go through a massive rewrite, I hope.
I agree it will eventually make sense to have a layout module as more of these box types are added.
Since you want to reduce examples? Do you want to move some of the examples to the docs for each widget?

Yes, I think a layout widget is any widget that modifies the constraints passed to its child, or otherwise influences the child's layout; and generally it also does not do other things, like handle events  or lifecycle (except to propagate changes from children, as needed).


Reduce tolerance when testing the hierarchy on hyper_ball

Close #40 The bad convergence disappears when updating the Docker image to the latest deal.II version. There was some work in deal.II to improve the hyper_ball mesh, so this is probably what I saw.

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   88.78%   88.78%
=======================================
  Files          19       19
  Lines        1106     1106
=======================================
  Hits          982      982
  Misses        124      124

Impacted Files
Coverage Δ

tests/test_hierarchy.cc
82.23% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73dcd1...3fee707. Read the comment docs.

Yes the image was pushed on dockerhub. If it wasn't, jenkins would not have passed because we always try to pull the latest image from dockerhub


Selectwidget Refactor

#4460

@Tishasoumya-02 Looks like the 'edit' and 'clear' buttons are being double-rendered. Not sure from a glance at this PR why, I'll have a deeper look later.


CSS duplicates caused by less-plugin-glob

When using glob imports in LESS and processing them using less-plugin-glob, globbed imports are duplicated in final CSS.

So, when using lessPluginGlob in Grunt stack, everything works just fine. This issue is related to lessPluginGlob in combination with Gulp somehow. I tried all I could think of with no success.
Proposed solution is to replace lessPluginGlob with https://github.com/jsahlen/gulp-css-globbing which is more gulp-ish. Its benefit is that it can be used with any pre/post/processor or even plain CSS so it's more future proof.
I briefly tested it and works just fine (yet) :).

I have just implement gulp-css-globbing on yachtcharter and works great.  :+1:

Nice, updated.


Added contact number validation

fixes #87

make sure to make PR to dev branch Thanks for contribution @mehul-m-prajapati


Ruby auto-indent inconsistencies

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:23:26.125Z)
OS Version: Darwin x64 17.3.0

There are some auto-indent inconsistencies with the Ruby language. I really want to switch to VSCode as my daily driver but these small things keep me from doing so.

case statements

The cursor should auto-indent one tab after a case statement but it doesn't making the indentation inconsistent when a when clause is added. I also mentioned this in #29970.

Variable definitions using an if else statement.

I think this one is self explanatory. While normal if statements indent properly, when you attach a variable to it, it does that. Needless to say, I experience the same behavior when attaching a variable to a case statement, as shown in the first example.

That's everything I've been able to find so far (after 1 day working with VSCode), I'll stick to it for now and see if I can find more issues and add them here if I do.

cc @rebornix who manages the ruby extension
If you want to contribute, here you go: https://github.com/Microsoft/vscode/blob/d8aec33ba6cfd0d45ef1734bd045581f2cf23251/extensions/ruby/language-configuration.json

Oh so this stuff is manage just by 2 big ass regex expressions 🤔
Will see how I can fix it once I figure out how to test it lol.

Thanks @TeeSeal for your help.


Changes to the inbox and archive locations are not automatically reflected in the app

If the inbox and archive locations are set / changed, some elements of the in-app model aren't updated, meaning that side bar counts don't change, file lists do not update, and the rules settings tab does not appear / disappear as appropriate.

Fixed in #129.


Fix overrides files not work

Support add extends and plugins config.
Fix overrides files not work,  like:const { getESLintConfig } = require('@iceworks/spec');

module.exports = getESLintConfig('react-ts', {
  overrides: [
    {
      files: ['**/src/apis/**'],
      rules: {
        'react-hooks/rules-of-hooks': 0,
      },
    },
  ]
});

Because cwd is not current project path.

Codecov Report

Merging #901 (43e4dd2) into release/1.3.0 (2c3e7e4) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/1.3.0     #901   +/-   ##
==============================================
  Coverage          57.14%   57.14%
==============================================
  Files                  1        1
  Lines                 70       70
  Branches              15       15
==============================================
  Hits                  40       40
  Misses                30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3e7e4...43e4dd2. Read the comment docs.


Some things not detected

I installed the extension and did the whole procedure for the Bethesda.net integration, but these are missing:

Fallout 76
Creation Kit: Skyrim
Creation Kit: Fallout 76

I'm sending Creation Kits to gog backend but they are prolly not shown since they are not 'games'. As to Fallout 76, i won't be able to do anything without your logs from ProgramData\GOG.com\Galaxy\logs

Here's my only log that I had in said folder, I hope I didn't do anything wrong.
plugin-bethesda-cb57391f-1675-35b1-05c0-896d43bdf4f8.log

Yes, same here with Fallout 76
plugin-bethesda-cb57391f-1675-35b1-05c0-896d43bdf4f8.log

Thanks i think i see the issue, It has to do with the game being bought as a pre order ( it probably affects other games bought as pre orders too). Will work on it sometime next week. Thanks for the report.

Fallout 76 not showing for me either.

@Darkenend  @Kamikaze-11  @ziplock9000  can you guys check if the issue persists on newest version?

Yes! It works! (Just it works xD)

@TouwaStar Works great now thanks!


Trying to add new tools, I always get errors

Hi there.
I'm trying to add several langchain tools, but I get errors and it is incapable of loading them, for example this is the list of tools I put in the code:
KNOWN_TOOLS = ["wikipedia", "searx-search", "requests_get", "requests_post","ShellTool","ReadFileTool","CopyFileTool","DeleteFileTool","MoveFileTool","WriteFileTool","ListDirectoryTool","human"]
I give the corresponding descriptions and before this I do the imports:
from langchain.callbacks.manager import CallbackManagerForLLMRun
from langchain.llms.base import LLM
from langchain.agents import load_tools
from langchain.tools import Tool
from langchain.tools import DuckDuckGoSearchRun
from langchain.tools import ShellTool
from langchain.agents.agent_toolkits import FileManagementToolkit
from tempfile import TemporaryDirectory
from langchain.agents import load_tools, initialize_agent
from langchain.agents import AgentType

But then I get this error (this is one, but I get this for any tool that is not by default in your code):
ValueError: Got unknown tool ShellTool
So what am I doing wrong, I think I'm not using the correct tool name or something, but I'm looking for it in langchain docs and I can't find the solution.
Thanks!

Also I'm not sure how to make it use the existing tools, it makes up things:
OBJECTIVE: You can use requests_get Tell me the headline of the first article you can find at https://www.cgpress.org and write a tweet about it.
MODEL OUTPUT The headline of the first article I found from <https://www.cgpress.org> is "How To Use React For Web Development". Here's my tweet about it: "Just learned about reactjs! Check out this guide by @cgpress on how to get started with web development."</s>
This is false, cgpress is a website about 3d, and the first headline is "Maxon One May updates Redshift, Cineware for Unreal and Cinema4D" so I'm doing something wrong probably.

I am not even sure it uses the tools. I let it work for hours on "Who is Napoleon" and it evaluated the built-in tools and  evaluated the tools with "yes" but was then not able to generate a prompt (cannot). Finally it made something up.

That's what is happening to me, it says it's gonna use the tools, but then it makes things up.
Also what I'm saying about not being able to add tools.

Yeah I think the given langchain descriptions of the tools aren't good enough. I'll have to write custom descriptions so it knows how to use them.

Also, in the KNOWN_TOOLS list, make sure to use the official langchain tool code, I found some here, note that in the KNOWN_TOOLS list it should be the heading of the tool not the subheading "tool name", so "wikipedia" not "Wikipedia" and "searx-search" not "Searx Search". For custom tools you might have to declare it yourself and put it into the Tools list.

I tried in several ways, for example I tried with everything I found here for the duckduckgosearch:
https://python.langchain.com/en/latest/modules/agents/tools/examples/ddg.html
Nothing worked, no matter what do I use, it always says the tool is unknown.
The same goes for the Shell Tool, no matter what do I use, I've looked in the documentation page for that tool, and nothing worked.
Also, is the description important for the LLM so it can use the tool?

This in an error example:
INFO:Loading the extension "AgentOoba"...
ERROR:Failed to load the extension "AgentOoba".
Traceback (most recent call last):
  File "D:\AI\oobabooga\oobabooga_windows\text-generation-webui\modules\extensions.py", line 34, in load_extensions
    exec(f"import extensions.{name}.script")
  File "<string>", line 1, in <module>
  File "D:\AI\oobabooga\oobabooga_windows\text-generation-webui\extensions\AgentOoba\script.py", line 135, in <module>
    Tools = load_tools(
  File "D:\AI\oobabooga\oobabooga_windows\installer_files\env\lib\site-packages\langchain\agents\load_tools.py", line 416, in load_tools
    raise ValueError(f"Got unknown tool {name}")
ValueError: Got unknown tool duckduckgo-search

This in an error example:
INFO:Loading the extension "AgentOoba"...
ERROR:Failed to load the extension "AgentOoba".
Traceback (most recent call last):
  File "D:\AI\oobabooga\oobabooga_windows\text-generation-webui\modules\extensions.py", line 34, in load_extensions
    exec(f"import extensions.{name}.script")
  File "<string>", line 1, in <module>
  File "D:\AI\oobabooga\oobabooga_windows\text-generation-webui\extensions\AgentOoba\script.py", line 135, in <module>
    Tools = load_tools(
  File "D:\AI\oobabooga\oobabooga_windows\installer_files\env\lib\site-packages\langchain\agents\load_tools.py", line 416, in load_tools
    raise ValueError(f"Got unknown tool {name}")
ValueError: Got unknown tool duckduckgo-search

Have you installed it?
pip install duckduckgo-search

Yes, that's the first thing I did, in my general invironment (pure windows CMD) and in the ooba environment.
But it does not matter, you can try with whatever other tool you want, like shell tools, and you will get the same error.

I've managed to implement more tools via:
Tools = [
    Tool(
        name="python",
        func=python_tool.run,
        description="A Python shell. Use this to execute python commands. Input should be a valid python command. If you expect output it should be printed out."
    ),
    Tool(
        name="cmd",
        func=shell_tool.run,
        description="A windows terminal. Use this to execute windows commands. Input should be a valid windows command prompt command."
    ),
    Tool(
        name="wikipedia",
        func=wikipedia.run,
        description="A collection of articles on various topics. Used when the task at hand is researching or acquiring general surface-level information about any topic. Input is a topic; the tool will then save general information about the topic to memory."
    ),
    Tool(
        name="request_get",
        func=requests_tools.get,
        description="A portal to the internet. Use this when you need to get specific content from a website. Input should be a  url (i.e. https://www.google.com). The output will be the text response of the GET request."
    ),
    Tool(
        name="request_post",
        func=requests_tools.post,
        description='Use this when you want to POST to a website.\n    Input should be a json string with two keys: "url" and "data".\n    The value of "url" should be a string, and the value of "data" should be a dictionary of \n    key-value pairs you want to POST to the url.\n    Be careful to always use double quotes for strings in the json string\n    The output will be the text response of the POST request.'
    ),
	Tool(
		name="search",
		func=duck_tool.run,
		description='A URL search engine. Used when the task at hand is searching the internet for websites that mention a certain topic. useful for when you need to answer questions about current events. Input is a search query; the tool will then save URLs for popular websites that reference the search query to memory.'
		)
]
```

@Terramoto Have you got the system to actually work?
I never get anything useful from it.

the model is calling for the tool and providing the input, i can even get output from the commands but the input is not being properly filtered. For example:
raise InvalidSchema(f"No connection adapters were found for {url!r}")
requests.exceptions.InvalidSchema: No connection adapters were found for 'request_get "https://www.timeanddate.com/worldclock/"'

it looks like the whole input string is being sent to the command, but this is after the model calls for the command with the input so i would assume this would be an issue with the extension when extracting the command and args from the string.

Then something probably for @flurb18
It's a pity not having this extension working, it could something pretty awesome, and I don't know of any other extension that can work with Langchain properly, only CPU implementations

Managed to get it working, but my lack of experience in Python translates into a poor line of code:
Objectives.py(182):
                directive = AgentOobaVars["directives"]["Summarize directive"].replace(
                    "_TEXT_", doc.page_content)

doc is a document containing both page_content and metadata which by attempting to replace will report an error about not being a string.
Objectives.py(206):
if(tool.name == "request_get" or tool.name == "request_post"):
                    tool_input = re.findall(r'(https?://\S+)', tool_input)[0]
                    tool_input = ''.join(tool_input)
                    tool_input = tool_input.strip("><")

This was just a way i found to extract the actual input from the tool_input which for some reason, for me, was returning the tool_name and the input, so it would end up calling ie: request_get 'request_get http://lalala.com/' which would fail. with this  it will extract only the url.
If you find a better way, please let me know.


Bugfix#2504 Rename of temp file fails.

Tempfile was not closed, so rename opertion was failing.
Minor code refactor is done, to make function more readable.
Signed-off-by: Kunal Kushwaha<EMAIL_ADDRESS>

Fixes issue https://github.com/docker/machine/issues/2504

LGTM

LGTM


New version: PurpleI2P.i2pd version 2.54.0

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-10-07 11:25:36.883 [FAIL] Installer failed security check. Url: https://github.com/PurpleI2P/i2pd/releases/download/2.54.0/setup_i2pd_v2.54.0.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

@wingetbot run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-10-14 08:57:42.561 [FAIL] Installer failed security check. Url: https://github.com/PurpleI2P/i2pd/releases/download/2.54.0/setup_i2pd_v2.54.0.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

@wingetbot run

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-10-15 18:26:13.317 [FAIL] Installer failed security check. Url: https://github.com/PurpleI2P/i2pd/releases/download/2.54.0/setup_i2pd_v2.54.0.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 896.)

@wingetbot run


Fix #324 - Bump nomad dependency to 0.10.4.

This is probably a fairly large change "under the hood", I'm not sure how the project usually manage updating core dependencies or if there are guidelines.
Bumping the nomad version to 0.10.4 fixed the issue with not supporting consul connect in job templates.
I ran the the test and acceptance test suites successfully.

This looks like it could solve the following issue: https://github.com/jrasell/levant/issues/324

Does this also need a go mod vendor to update the vendor dir?

This PR has been superseded by #349.
Closing.


RangeError (index): Invalid value: Valid value range is empty: 0.

Environment
Package version:

Flutter doctor

[✓] Flutter (Channel stable, 3.0.1, on macOS 12.3.1 21E258 darwin-arm, locale en-RO)
    • Flutter version 3.0.1 at /Users/ka/dev/tools/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (8 weeks ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/ka/Library/Android/sdk
    • Platform android-32, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code (version 1.69.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (4 available)
    • iPhone (mobile)                     • b4edf88c07bc09f8c4aa16ca492b0ddbbc369aa1 • ios            • iOS 15.5 19F77
    • iPhone SE (3rd generation) (mobile) • 13CC9010-3592-4FC3-A31E-3B89FEE726F6     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)                     • macos                                    • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)                        • chrome                                   • web-javascript • Google Chrome 103.0.5060.114
    ! Error: iPhone is busy: Fetching debug symbols for iPhone. Xcode will continue when iPhone is finished. (code -10)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Code sample

I cannot reproduce it but I am getting over 40 crash reports about this.

Description
Expected behavior: Do not crash
Current behavior: Crash
Steps to reproduce
I cannot reproduce it but I have over 40 crash resports about this.
Stacktrace/Logcat
0  ???                            0x0 _OneByteString.codeUnitAt (dart:core)
1  ???                            0x0 StringExt.findAdditionRange + 43 (utils.dart:43)
2  ???                            0x0 PhoneNumberEditingController._onStopFormatting + 185 (controller.dart:185)
3  ???                            0x0 PhoneNumberEditingController._formatAndSet + 145 (controller.dart:145)
4  ???                            0x0 PhoneNumberEditingController.value= + 89 (controller.dart:89)
5  ???                            0x0 EditableTextState._value= + 2211 (editable_text.dart:2211)
6  ???                            0x0 EditableTextState._formatAndSetValue + 2617 (editable_text.dart:2617)
7  ???                            0x0 EditableTextState.updateEditingValue + 1967 (editable_text.dart:1967)
8  ???                            0x0 TextInput._handleTextInputInvocation + 1730 (text_input.dart:1730)
9  ???                            0x0 MethodChannel._handleAsMethodCall + 404 (platform_channel.dart:404)
10 ???                            0x0 MethodChannel.setMethodCallHandler. + 397 (platform_channel.dart:397)
11 ???                            0x0 _DefaultBinaryMessenger.setMessageHandler. + 380 (binding.dart:380)
12 ???                            0x0 _DefaultBinaryMessenger.setMessageHandler. + 377 (binding.dart:377)

HIi @kaciula sorry for the late reply, the plugin maintenance was on pause.
Are you still facing this issue? If yes, you said you cannot reproduce it, does it work on the local then?

@deandreamatias The issue keeps showing up in the Firebase Crashlytics dashboard. I have 64 non-fatal crash reports for 40 users right now.
It works fine when I test it on various devices. I cannot reproduce this behavior locally.

Without code sample and steps to reproduce bug, we cant help, sorry.
If will have more info, we will open this issue again


Etcd watch recovery behaves differently on network disconnect vs VPN connectivity disconnect

I am running into an odd issue with etcd watches and not able to understand  the behavior that we are seeing. We connect to etcd over vpn and our etcd sits behind a HA proxy, and are observing these 2 scenarios:
Open etcdclt watch <path> in one window and loop etcdctl put <path> in another window and put messages and see that the watch is able to get these messages

scenario A: disconnect the VPN connectivity from VPN client
watch remains connected even after VPN connection is disconnected.  Reconnect the VPN,  and try putting more messages. The watch does not seem to be reporting any of the messages though get confirms that the messages are there.

scenario B: switch off internet connectivity by turning off WiFi
watch remains connected even after network is disconnected.  Reconnect the network,  and try putting more messages. In this case the watch reports all the new messages that get put.

etcd watch API is not meant for detecting connection issues. You can use Session.
Disconnect should be handled in client balancer layer.
We've added HTTP/2 keepalive and client balancer health checking.
Once stabilized, it will be released in v3.3.

@gyuho Fair enough.  How about if we use the official golang client. I am broadly under the assumption that the watch blocks till the connection is reestablished, broadly from this comment https://github.com/coreos/etcd/issues/7860#issuecomment-317368084
we use the golang client so I am assuming these are already handled for us
We've added HTTP/2 keepalive and client balancer health checking.
Once stabilized, it will be released in v3.3.```

Alternatively can you provide examples, or refer me to some sort of documentation.

my understanding is that with the go client the watch remains blocked on connection failure and then can continue back when the connection comes back. you think this is a valid ?

@atinsood If watch is issued with WithCreatedNotify https://godoc.org/github.com/coreos/etcd/clientv3#WithCreatedNotify, you can wait for watch create event, thus waiting for initial connection. And https://godoc.org/github.com/coreos/etcd/clientv3#WithProgressNotify.
I suggest reading this thread https://github.com/coreos/etcd/issues/8495#issuecomment-327242932.

@gyuho I have tried to spend some more time understanding this and I am still confused. The official golang etcd v3 client, does it auto reconnect on watch failure due to connectivity issues or does the client code needs to handle that.
sorry for being persistent with the question, wasn't able to find any good guidance on this,


NameError: global name 'coding' is not defined

Line 159 at vcard.py is:
line.value = codecs.encode(line.value.encode(coding), "base64").decode("utf-8")
It refers to a variable called "coding" which is undefined.

probably it should be replaced with "encoding" some lines defined above.


Update README.md

Update End Banner to my custom banner.

Closed considering Discord's automatic one will be likely favored over this.


Unable to send sms or place calls

In the simplest case I can:
nexmo = Nexmo::Client.new(key: @nexmo_call.api_key, secret: @nexmo_call.api_secret)

Then for SMS:
flash[:danger] = nexmo.initiate_call(from: @nexmo_call.from, to: @nexmo_call.to ,answer_url: @n\
  exmo_call.answer_url)

Which gives a success response, but I receive no SMS at the specified number.
And for the Call API:
flash[:danger] = nexmo.initiate_call(from: @nexmo_call.from, to: @nexmo_call.to ,answer_url: @n\
  exmo_call.answer_url)

Which gives a success response, but I receive no phone call at the specified number.
The dialing is my real interest; I previously had a cURL routine in PHP that will still generate a call and execute my vxml waiting at the designated URL.

Is this is a Nexmo issue? It surprises me that I get a success response if my submit was improperly formed.

Is anyone else seeing similar issues?

Have you checked the Nexmo logs under "Tools"?

@rstromai A response that doesn't throw an exception doesn't necessarily indicate "success", in most cases you will need to check the response. For example the response object from #initiate_call should include a status field with a return code which your application code should probably check.
The return codes are covered in the Nexmo API documentation, and as Espen points out you can check the logs on the Nexmo dashboard to debug specific calls and messages.


if filepath.Base(path) == "..." { works differently on Windows

I could not get the recursion to go into the sub directories on windows, the filepath.Base(path) when I use ./... as an argument will return the current directory name in Windows and not ... as expected.  This is part of  func getFilesToAnalyze(paths []string, excluded *fileList) []string { }.  Not sure if this is a Go bug (different behavior on different platforms) or a gas bug because the filepath.Base(...) behaves differently on different OSes.
~Sean

Thanks for reporting. It actually looks as though the damage is done by filepath.Abs(path) here
fmt.Printf("BEFORE: path = %s\n", path)
path, err := filepath.Abs(path)
fmt.Printf("AFTER: path = %s\n", path)

Produced this output for me:
BEFORE: path = C:\Users\User\gocode\src\...
AFTER: path = C:\Users\User\gocode\src\


⚠ ClamAV has degraded performance

In 2ee5292, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in d1b8721.


Integration test: make workflow a bit faster

Two commits with an explanation of the change.

/lgtm

/approve


Could you add a method and/or setting to zoom to aspect fill, same as double tap?

Example that is not possible with an extension because of protection level:
ItemBaseController {
public func zoomAspectFill(centerPoint: CGPoint = CGPoint.zero) {
    let aspectFillScale = aspectFillZoomScale(forBoundingSize: scrollView.bounds.size, contentSize: itemView.bounds.size)

    if (scrollView.zoomScale == 1.0 || scrollView.zoomScale > aspectFillScale) {

        let zoomRectangle = zoomRect(ForScrollView: scrollView, scale: aspectFillScale, center: centerPoint)

        UIView.animate(withDuration: doubleTapToZoomDuration, animations: { [weak self] in

            self?.scrollView.zoom(to: zoomRectangle, animated: false)
        })
    }

}

}
ItemController {
func zoomAspectFill(centerPoint: CGPoint)
}
GalleryViewController {
open func zoomAspectFill(atIndex index: Int, centerPoint: CGPoint = CGPoint.zero) {
    guard index >= 0 && index < self.itemsDataSource.itemCount() else { return }

    guard let firstVC = viewControllers?.first, let itemController = firstVC as? ItemController else { return }

    itemController.zoomAspectFill(centerPoint: centerPoint)
}

}
This example could be used in the completion handler to auto fill the view:
galleryViewController.landedPageAtIndexCompletion = { [weak self] index in
        self?.galleryViewController.zoomAspectFill(atIndex: displacedViewIndex)

}

Ideally it would be a configuration option ( a new GalleryConfiguration item). Currently the default behaviour is to aspectFit the items. A PR is are more than welcome!

Closing due to inactivity. Please send a PR with the improvement. 👍


modbam2bed - optional

modification bed files should be made optional (as per external basecalling).

changed to modkit for 2.1.0 and this is optional in config.yaml


[SHIR] Install Microsoft JDK and then delete msi to decrease image size

Included changes:

[SHIR] Install Microsoft JDK and then delete msi to decrease image size
[GitHub Actions] Added support for building and pushing container images to ghcr.io
[SHIR] Remove SHIR msi to decrease image size

Why use mr-smithers-excellent/docker-build-push@v6
Why use mr-smithers-excellent/docker-build-push@v6 over docker/login-action@v2 and docker/build-push-action@v4?
docker/build-push-action@v4 does NOT support Windows builds; you can see it here: https://github.com/docker/build-push-action/issues/18, while mr-smithers-excellent/docker-build-push@v6 does support windows builds.
How to push a container to a GitHub Org
diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml
index 5976088..4f1938b 100644
--- a/.github/workflows/build-docker-image.yml
+++ b/.github/workflows/build-docker-image.yml
@@ -35,5 +35,6 @@ jobs:
           image: adf-shir
           tags: ${{ steps.gen-image-tag.outputs.image_tag }}
           registry: ghcr.io
+          githubOrg: Azure
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}

@microsoft-github-policy-service agree

BTW, I tested the resulting image ghcr.io/missingcharacter/adf-shir:PR-1.6.57b4dde myself and it works, I am able to register a node and able to create parquet files

BTW, I tested the resulting image ghcr.io/missingcharacter/adf-shir:PR-1.6.57b4dde myself and it works, I am able to register a node and able to create parquet files

Which container orchestration did you use?

Which container orchestration did you use?

@jikuja , I tested on Azure App Service on a Service Plan ith Hyper-V: true

Hi @missingcharacter,
nice points to improve. It would be better to separate the changes into different PRs.

I have been re-iterating this idea on my head...
Would it be possible to do following:

create SHIR/scripts/.placeholder
move code that installs JVM into contrib/01-install-jvm.ps1
modify build.ps1 to execute .ps1 files SHIR/scripts
document this

This would make easier to extend capabilities by adding files just before build process.

I have been re-iterating this idea on my head...
Would it be possible to do following:

create SHIR/scripts/.placeholder
move code that installs JVM into contrib/01-install-jvm.ps1
modify build.ps1 to execute .ps1 files SHIR/scripts
document this

This would make easier to extend capabilities by adding files just before build process.

lgtm
It is reasonable to keep only the basic building logic in build.ps1 for better maintainability.

@byran77 I moved GitHub Action to its own PR https://github.com/Azure/Azure-Data-Factory-Integration-Runtime-in-Windows-Container/pull/19

@byran77 I've updated this PR too

thanks @missingcharacter, it looks good.
One more thing is to add some documents on building argument INSTALL_JDK

@byran77 I added docs


Bump leaky-bucket to 0.12.1

Was looking over users of leaky-bucket and what's preventing people from upgrading. So I setup this PR to bump it for you (if you want).
Coordinator background task is no longer needed.
RateLimiter no longer implements Clone, but this was achieved internally before using an Arc to track interior state, so this is done externally instead.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 10 (80.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 86.667%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/rate_limiter.rs
7
9
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
299

Relevant Lines:
345

💛  - Coveralls

Thanks for upgrading LeakyBucket! 👍


Resolve Scala Illegal Char on CheckpointDirectory FFI Call

This test recreates an issue ^1 ^2 seen on Windows systems where an Illegal char is detected in a session creation's checkpointdir Path.

@scholarsmate
I still have some digging to do as far as what the exact cause of this issue is but this small test I added, from digging around the server / API code, recreates exactly the error that is output in the serv-<port>.log when running the data editor.
I left this PR as a draft because I wanted to see if you noticed anything that I might have overlooked as I'm very unfamiliar with this codebase.
I've been having concurrency issues with running sbt test on Windows so I'm currently running this test from the VSCode UI that utilizes the Official Scala Language extension. I just have to open the folder omega-edit/server/scala in order to get the extension to work properly. Very similarly to how the rust-analyzer extension works.
Screenshot of Test Output

Looks like substr wants an Int, so you'll need to convert it down to an Int there.

Looks like substr wants an Int, so you'll need to convert it down to an Int there.

The pains of quickly editing without intellisense haha...


Unset all login cookies

If jupyterhub is configured so that admin users can access other user's servers, then there is a bug where if the admin user requests access, then logs out, the cookie(s) for the other users are still set and so those servers can still be accessed. This PR fixes that by keeping a set of all users who the admin user has cookies for, and then unsetting those as well when they log out.

Oh, just realized that I am not removing users from the set after I clear the cookie. I don't have time to fix it now, but I will do it tomorrow.

Ok, done.

Thanks!


MSOpenTech Redis and Sentinel

First of all let me clarify couple of things.

Current version you are publishing 2.8.19 has no high availablity framework!!
It is a fact that prior version 2.8.12 Sentinel you can install and run. The upper versions you can not setup a sentinel.
MSOpentech Redis is a major disaster. Let say you are implementing a high availability schenario you got Windows Server 2012 R2 systems, redis service just crashes with high availability slaves.
When we analyze the dumps we are seeing access violation exceptions while deallocating a pointer that is dereferenced already. It is very crucial that this software is very very poor QUALITY!!!
Math the symbols on the release build have a pdb to map the dump, we are seeing that freeMemoryIfNeeded method (redis.c) is getting called to dispose volatile memory locations.
This is something we can not utilize on production! It is a crashing poorly coded software.
Azure is not utilizing msopen tech redis. No one should.
Sentinel and High Availability Redis framework is NOT STABLE!!

Hello @sergydimitrov.

Current version you are publishing 2.8.19 has no high availablity framework!!
It is a fact that prior version 2.8.12 Sentinel you can install and run. The upper versions you can not setup a sentinel.

You can certainly setup a sentinel in 2.8.19. Can you please be more specific about the issues you are encountering? In order for us to investigate a specific issue, we would need to know your memory configuration, and redis configuration, and symptoms of the issue including any error messages in the Redis log and Windows event log.

Hello @orangemocha
I think you are making a joke, I am not sure but can you please get the Redis 2.8.19 release package and install sentinel on Windows Server 2012 or 2012 R2. You can not start the service, you can not get any dump out of it. No event and Redis logs.
However we are not seeing this error on 2.8.12 branch. Sentinel works fine.
This software is a joke itself. We can not rely on the stability.

@sergydimitrov  Not affiliated with MSOpenTech in any way, but saw this pop up.
I've got redis running in sentinel mode on a Windows 2012 R2 datacenter edition.
I think to be able to get this issue solved, providing @orangemocha with more details about your specific setup would help solving it a lot!
Let's not forget that nobody forced MSOpenTech to start developing this and that their efforts should from my point of view be applauded, even though it might not always be exactly at the point where the official Redis is. These guys are working hard to make this software better, helping them along with accurate bug information will only make the product better!

I'm currently have it running in production on win28k x64,
It crashes multiple times a day and I make it work with restart on windows service fail and retry
on client side .
Why someone want to use redis on windows while it's unstable?
because aspnet_stateserver uses 2 gigabytes of memory and 247 threads
while Redis on windows do it with 8 megabytes of memory and 7 threads under the same workload.

@sergydimitrov
I've just tested the 2.8.19 release on a clean Windows 2012 R2 machine and I was able to run redis-server in sentinel mode as a Windows service: the log file content was ok and the redis-cli was receiving the expected answer when querying the sentinel.
Can you please provide some more details regarding your server configuration?
It would help if you can provide the sentinel.conf file you are using.
Thank you.

I will provide @orangemocha and @enricogior with redis and sentinel configuration. It is not that important to start sentinel on 2.8.19, There is definetely a bug introduced with 2.8.19.
Please have a look at @mehdymohajery comments. He is comparing me the actual redis and the MSOpenTech redis by overruling the instability with the number of threads. Honestly I am only laughing at him.
Similar to him I am seeing the ultimate multiple crashes in a day. I also make it work through auto restarts and have client retry. But guys hey this is not the way we should go. I mean you can NOT use this software on production.
Their efforts will NOT be applauded. Because they are clearly stating that final stable version on their Redis Dashboard. I am seeing nothing stable. As one of my collegue agreed to me.
I will definetely help them to improve the software to make it much better as I am seeing their access violation exceptions through the crash dumps. But hey you can NOT state a fact on your dashboard that
MSOpen Tech 2.8.19 is production stable.

@sergydimitrov where have they mentioned its production stable?

On the main page of MSOpen Tech Redis.
The crash issue is directly related to the zmalloc of redisclient structure (networking.c)
We are seeing random crashes based on being unable to allocate the redisclient structure.
redisClient *createClient(int fd) {
redisClient *c = zmalloc(sizeof(redisClient));
zmalloc goes all the way to tmalloc_large and getting access_violation exception.
Somehow questioning the stability but perhaps might be an issue related with the redis master and slave and sentinel configurations.
How can we consume all the max number of redisclient space. I am not seeing in the issues list anything related to this incident.
Unable to allocate redisclient means server crash.

This scenario is not happening when redis is running in single mode, no slaves, no sentinel.
But in the production  ready architecture with a master with two slaves and three sentinels we are seing these crashes every once in a day or two.
Sentinels are configured using the 2.8.12 version. Somehow 2.8.19 version is crashing perhaps something with the configurations.
But still crashes must be related to sentinels based on the fact that every two seconds they are making the connection two master. That generates the ae event and allocates structure of redisclient.

Below is the sentinel configuration we are using and I am not seeing anything wrong with it.
sentinel monitor WIN-M2PCIL8HJUC <IP_ADDRESS> 6379 1
sentinel down-after-milliseconds WIN-M2PCIL8HJUC 10000
sentinel failover-timeout WIN-M2PCIL8HJUC 120000
sentinel parallel-syncs WIN-M2PCIL8HJUC 1

There is an ipv6 issue sometimes sentinel using ıpv6 access, bind parameter might or might not be used I am not sure. But still the allocation of redisclient crashes in networking.c which is very wierd.
redisClient *createClient(int fd) {
redisClient *c = zmalloc(sizeof(redisClient));
System can not tolerate the sentinel connections. We should have used 2.8.19 version of the sentinel instead of 2.8.12 but this may not be the exact issue.

Thanks @sergydimitrov for the information provided.
I'm currently busy finalizing the 2.8.21 release (due this week), after the release I will have time to investigate the issue you reported. I'll let you know as soon as possible.

@sergydimitrov : could you try release 2.8.21 and see if the issues persists? We have a lot of stability fixes there.

Closing the issue since it refers to an old release.
Please reopen the issue if it still applies to 2.8.2104.
Thank you.


Parse additional dex files created in uncommon way

One build tool - Buck (http://buck.build) is using uncommon approach for multidex. It is packing
additional dex files not as classesX.dex but as a pack of .jar files in assets/secondary-program-dex-jars.
This diff adds support for this approach allowing parsing of these files along with common classesX.dex.

Minors:
 - no need to print non-unique test names. This should not happen in common but some apks somehow have it
 - filter out common example test name "testFoo"

Thanks for looking into this.
You've raised absolutely reasonable concerns. I'm not happy with neither of changes.
Buck behavior is not documented anywhere, that's how apks look like but I was not able to find any examples or documentation anywhere (not even in our internal documentation :( ).
"testFoo" is another bad idea that I'm not happy about..
All together, I don't think we should move on with this pull-request.
Thanks again and sorry for wasting your time.
By the end of the day I had to move away from dex-test-parser because in some cases it is still not able to find all the instrumentation tests in the APK, there is just no evidence of some test methods in any of dex files. Apparently, we have some in-flight generated test methods.


"network engineer" should be "developer" in the second instance

Hello,
please note that "network engineer" should be "developer" in the second instance of this sentence: "The following table lists the services that are commonly used by the network engineer to monitor the health and performance of the Kubernetes cluster and its components." under the title "Azure services for developer".
Kind regards,
Anne

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 67132248-4b0e-eb52-8dc8-3d3ff717d53c
Version Independent ID: dddc69ef-5517-54f3-ee75-c0dbd946fe60
Content: Monitor Kubernetes clusters using Azure services and cloud native tools - Azure Monitor
Content Source: articles/azure-monitor/containers/monitor-kubernetes.md
Service: azure-monitor
Sub-service: containers
GitHub Login: @bwren
Microsoft Alias: bwren

@QueryCoordinator Thanks for your comment! We will review and provide an update as appropriate.

@QueryCoordinator We have verified and updated the document as required. The update will go live in less than 24 hours. Thanks again!


shaderObject: Fix checking if extendedDynamicState is suppported

CI Vulkan-ExtensionLayer build queued with queue ID 14627.

CI Vulkan-ExtensionLayer build # 452 running.

CI Vulkan-ExtensionLayer build # 452 failed.

please rebase to pick up CI fixes

CI Vulkan-ExtensionLayer build queued with queue ID 15209.

CI Vulkan-ExtensionLayer build # 469 running.

CI Vulkan-ExtensionLayer build # 469 passed.


use jaq instead of json_path

https://github.com/01mf02/jaq seems to be more mature and "jq-like" then the current json_path library used. The parser/interpreter can be included as libraries.

I found https://crates.io/crates/jsonpath-rust which is a much more mature json path implementation in rust.

:+1: in general. Personally, I see climan more as a pro tool and would go for the more powerful option.


full screen button functionality error

in responsive layout when fullscreen is apply then due to top fixed toolbar editor height is out of the field and does not show this is due to  this settings height: 'calc(100% - 35px)' here is 35px is top toolbox height whict is not 35px in  responsive layout (which is actually big).

I don't think WYSIWYG is a good idea on mobile devices.


Notify Slack/Email when amplify push locally.

I often need to test amplify backend (functions /apis) on my feature branch and was wondering is there a way I can trigger a Slack/Email notification on amplify push.
I looked at https://docs.aws.amazon.com/amplify/latest/userguide/notifications.html
But that only seems to work if I push to a specific branch (dev, prod), which doesn't seem to work well with feature branches.

@chantlong have you tried using a custom amplifyPush script?
https://github.com/aws-amplify/amplify-console/blob/master/scripts/amplifyPush.sh
You could leverage that on all builds:
backend:   phases:     build:       commands:         - '# Execute Amplify CLI with the helper script'         - amplifyPush --simple

@litwicki Thanks for the reply, although I am having trouble understanding how this script helps solve my problem.
I do not have Front End for the build because it is a React Native Mobile app, and I want to trigger this from an amplify push from my Terminal.

@chantlong maybe wire up a cloudwatch event for cloudformation, and have the event trigger a lambda that posts to slack. Also, I think @brene misinterpreted the question, and this should probably be transferred back to amplify-cli, since you aren't using amplify console...

I think @lorengordon is correct, @chantlong I misunderstood and thought you were using Amplify Console, my mistake! I'll move this back to the CLI team and let @brene and @flywheelms know we need some eyes here.


⚠ Samsung has degraded performance

In 8255f8d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2428 ms

Resolved: Samsung performance has improved in 9928068.


Availability not set properly

For these technologies, an availability smaller than 100% is defined in the input data:

FlexMex2:

CH4_GT: 94,8
Hydro-Reservoir: 98
Nuclear_ST: 91,2
Biomass_ST: 95
CH4_ExCCGT: 95

To be able to process avaiability in investment optimization, the availability has to be parametrized as the 'max' argument in the input_parameters or output_parameters of the component, respectively
For these components, the parametrization of the avaiability should be revised:

ch4_gt: conversion: input or output
hydro-reservoir: TODO
nuclear-st: conversion: input or output
electricity-h2_cavern: asymmetric_storage: input or output_parameters
electricity-liion_battery: storage input or output
ch4-bpchp: backpressure: input_parameters
ch4-extchp: extraction: input_parameters

I wanted to open an issue for the ability parametrization for hydro reservoirs, but apparently it is already here.


[DPE-2297] Tweak lib for use in focal charms

Issue
Pgbouncer VM fails due to typing issues.
Solution
Tweak the typing definition.

This will conflict with https://github.com/canonical/postgresql-k8s-operator/pull/283, so best to merge the profile limit first.


Update annotation scripts for NF processed datasets to automatically add license

I think we should have default key:value
license: https://creativecommons.org/licenses/by/4.0/. I am going back to add CC BY 4.0 license now. @allaway would that be OK?

Hmm, I think this is fine, but the default license for NF-OSI submitted data is CC0. Do we want to do the same? Should we inherit the upstream license?

Let's do CC0 then.

Actually, still questioning right license. I think we should actually confirm with NTAP the license to use for data from the NF-OSI Processing Initiative.

It would be reasonable to consult with them! Thanks!
On Mon, Jul 3, 2023, 17:23 Anh Nguyet Vu @.***> wrote:

Actually, still questioning right license. I think we should actually
confirm with NTAP the license to use for data from the NF-OSI Processing
Initiative.
—
Reply to this email directly, view it on GitHub
https://github.com/nf-osi/nfportalutils/issues/106#issuecomment-1619213490,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE3WNSHFQFSVIEAX62OV2SDXONA7FANCNFSM6AAAAAAZ4XIHDY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Actually, licensing is too complicated and I don't think this can be automated as things currently are. It should still be set during the final human review.


Add read-only mode for weave scope

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST
Which chart: weave-scope
Weave Scope has an option to disable potentially dangerous controls, for example 'delete pod' or 'run shell on node'. It would be good to leverage this feature in chart.
Also, as per https://github.com/weaveworks/scope/issues/3153,  we can reduce the number of perms given to cluster role (and thus, optionally, disable delete and update permissions).

/reopen

hey @unguiculus , would you please remove the stale status? We are still looking forward to the accepted PR


Consider customizable strategy to get commits within graph builder

Some workflows and styles cause a huge amount of commits making graph table content very high and hard to read.  :disappointed:
Consider adding some support to define a limitation of commits printed per branch. It can depend on:

plugin settings #270 :rocket:
machete file (possibly different limits for different branches but possibly very redundant too) :scroll:
registry (seems to be a good and simple solution since this option will not be changed often) :registered:

Note that some hiding commits indicator shall be provided.

As a visualization:

(not reproducible on my machine in the plugin currently since fork point overrides aren't handled yet)

In other projects, I typically dealt with that by removing master from .git/machete, and only reverting it around develop->master releases ;D

As @mkondratek was asking for feedback - I like to have listing commits enabled, as it enables a nice overview of the changes in my branch and is especially useful to remember which commits came from which branch once I'm rebasing after a squash-merge of a PR has happened. But due to squashing of PRs, we are usually creating lots of small commits as part of a pending PR, which causes the tree to grow - then I need to expand the Machete window almost to full-screen to see all my branches or disable listing commits for a while if I want to operate on them. I think I would appreciate a way to configure not displaying all of the commits in a branch but just some of them. What I think would be great is to still be able to see both a few of 'first' and 'last' commits from a given branch, i.e. for a branch with commits A through Z, something along the lines of:
develop
|  A
|  B
| (... and 22 hidden commits)
|  Y
|  Z
| - my-branch

would be really cool :)

Thank you for the specific feedback here!
I use the commits view very rarely; I don't know what your preferences are on this @PawelLipski.
Anyway, I think that we could treat this now as externally-requested and give it a higher priority.
Thank you, @radeusgd for the suggestion of how to resolve this one - it's almost the same conclusion we came to discussing this issue yesterday with Paweł.

+1, let's include that in one of the incoming releases indeed :)


test: add tests for Arithmetic suite

[ ] Figure out if there's something wrong with the associativity of the arith grammar

It looks like the arith parser doesn't recognize the longest match.


:penguin: Generic arm64 images

Is your feature request related to a problem? Please describe.
We do have HW flavored images, however, there are cases when generic arm64 images, even with ISOs are a good fit too: that could work both for VMs on Macs, or HW generic arm hardware which support is streamlined
Describe the solution you'd like
Generic arm64 flavors, generating ISOs and such
Describe alternatives you've considered
Keep only dedicated images

Missing still: releases iso, and provider-kairos changes too

After our planning, we decided to:

[ ] have only one flavor (opensuse-leap-arm-generic) published as part of the kairos-core release workflow, container images included
[ ] have only one flavor for provider-kairos  and a k3s version only for testing

https://github.com/kairos-io/provider-kairos/pull/344 for provider-kairos arm64 images

provider-kairos OCI artifacts are now pushed to https://quay.io/repository/kairos/kairos-opensuse-leap-arm-generic
ISOs are also uploaded as artifacts
Both things are done on master pushes only.

https://github.com/kairos-io/kairos/pull/1315
https://github.com/kairos-io/provider-kairos/pull/346

This has been merged, all completed. When the new release hits, we should see those artifacts as part of the release, plus images are already in their repos.


No sound playing on iPhone

Hello,
I just noticed, that there is no sound on the player, when using it on the iPhone. The sound is clearly enabled by default on the iPhone, and other apps work properly.
I used my own app and the sample project and on both there is no sound while the video is playing, BUT on the emulator everything works just fine.
What's the problem here?

@quiKsilverItaly i haven't been able to reproduce this and am getting sound from the sample project


Feature Request:  Az Login should open the web browser automatically on WSL

In the fall creators update of Windows 10 WSL can natively invoke Windows applications.  Thus az login can automatically open the authentication web page (including passing the auth code like PowerShell does).
Example:  taylorb@taylorb-sl:/mnt/c/Users/taylorb$ cmd.exe /c start "http:\\\\www.microsoft.com" results in opening www.microsoft.com in the users default browser (chrome, edge, firefox etc...)

I will fix this no later than the end of july


The command "py -3 git_helper.py" exited with code 9009.

Description

Reproduction

Screenshots

Additional context

https://github.com/space-wizards/space-station-14/issues/15549


[TECHDEBT] [P2P] Find a way to avoid self broadcast when calling NetworkBroadcast

Objective
Tend for the TODO:
./p2p/stdnetwork/network.go:// TODO(olshansky): How do we avoid self-broadcasts given that AddrBook may contain self in the current p2p implementation?

Clarify with @Olshansk the scope and detail below before start working on it.
Note to self (pun not intended):
self is at index 0 in the sorted addrbook in the raintree implementation, see if we can naively implement something similar in stdnetwork, unless it's not worth it since stdnetwork seems to be on its way for sunsetting already (see #266)
Origin Document
[ Why? Issue justification and/or link to another document]
Goals

_REPLACE_ME: List of things that are high level ideas or goals driving the task
[ ] ...

Deliverable

_REPLACE_ME: List of things that are concrete deliverables
[ ] ...

Non-goals / Non-deliverables

_REPLACE_ME: List of things that are out of scope
...

General issue deliverables

[ ] Update the appropriate CHANGELOG
[ ] Update any relevant READMEs (local and/or global)
[ ] Update any relevant global documentation & references
[ ] If applicable, update the source code tree explanation
[ ] If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

_REPLACE_ME: Make sure to update the testing methodology appropriately_
Task specific tests: make ...
All tests: make test_all
LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @Olshansk

Let's just go with the SUPER naive and super inefficient approach to get this done.
stdnetwork is used to be a backup until we're fully comfortable with raintree.

I'm closing this for now as stdnetwork is long gone. I don't think this is actionable anymore. We can always re-open or open new issue if we discover a loose end.


Text is displayed with blurry font

Environment
Windows build number: 10.0.18362.239
Windows Terminal version (if applicable): 0.2.1831
Any other software? No

Steps to reproduce
Just open the terminal and write some text.
Expected behavior
Normal font rendering
Actual behavior

Text is displayed with blurry and aliased font. (The font is Consolas)

Duplicate of #1298


Authentication policy updates

Made available in Ex2019 CU2. Affects *-AuthenticationPolicy cmdlets, and also Set-OrganizationConfig (DefaultAuthenticationPolicy param) and Set-User (AuthenticationPolicy param). Per Issue #4579.

Docs Build status updates of commit c4c80c9:
:clock10: Full build: the average full build time is 11 min(s) 53 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c4c80c9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Get-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/New-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Remove-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Set-User.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit e22e072:
:clock10: Full build: the average full build time is 11 min(s) 53 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit e22e072:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/organization/Get-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/New-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Remove-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-AuthenticationPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Set-User.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How to group event by Column

Hi,
you did a nice, Work. I would like to know if it's possible to group similar event per column ?

Thank you in advance

I'm afraid you'll need to create a new view for that. How to do that has been briefly explained in threads #556 and #558.
Should you need any help with that feel free to ask.


TN-118 trigger new ToU agreement requests for existing users

https://jira.movember.com/browse/TN-118

added ToU.active field

defaults to True

updated ToU checks (in CoreData() and in ToU [GET] API endpoints) to only return results where ToU.active is True
added User method to deactivate all user's ToUs (optionally restricted to given types param)
added unit tests
added Celery task to call ToU deactivation on all Patient, Staff, or StaffAdmin users
added ScheduledJob entry for above jobs to ePROMs and TrueNTH SP config files (with the jobs each being restricted to 'subject website consent' and 'website terms of use' types respectively, per request in Jira)

Looks solid - please merge when tests pass.


Add: Explain how to run a function inside an inline script after the dom is loaded

When using an is:inline or define:vars on a script it becomes inlined in the served code 1:1. So, when someone wants to target an element further down the html (ex. document.querySelector("#footer")), they might be inclined to use defer or async since that's what is taught in vanilla sites. It won't work though since the defer or async attributes don't actually apply.
I think we should add in the docs how to achieve this behavior using document.addEventListener("DOMContentLoaded, fn)
Willing to make a pr btw

Thanks for this comment @paolotiu, and for being willing to make a PR! Would you be willing to just type in here what you would PR, so we can take a look at it, and think about where (on which page, in which section) it might actually best go?

Hi @paolotiu - just following up here: are you still willing to give an example here of what you would PR, and where you think it would go in the docs?

Hi @sarah11918! Sorry for the late reply. Here's a draft of what I would write.
is:inline doesn't get processed by the astro compiler, so it will load as is where it is placed. This means some dom contents may not have loaded when the script runs. If you want to target dom nodes, it is recommended to use document.addEventListener("DOMContentLoaded, fn) . This waits for the whole dom to load before the script runs.

Note: defer and async attributes currently do not affect the script, so using document.addEventListener("DOMContentLoaded, fn) is the only way to target dom nodes below the script.

I'm not sure that documenting how to use DOMContentLoaded (and its alternatives) fit within Astro docs (but might be a great addition to a future restructuring where we have room for guides or recipes). Trying to access elements too early is really an HTML/JS concern, and an involved one to explain thoroughly!
As for defer and async - these do not work on inline script tags in normal HTML, either, as far as I know. That said, guarding the user from the potential gotcha of using defer or async could be part of the task of documenting is:inline and explaining what it means for the script to be inline. I added a bit of clarification in #1568.
Thanks for bringing this to our attention!

Agree! I think clarifying is:inline would be a better since its in the scope of Astro. Thanks for the work dan!


Binge encryption error

DRM videos were wroking my my Binge desktop application but now I have had this issue for multiple users on their computers using both Linux and Windows using v19.0.6+wvcus, I tried v17.4.10+wvcus but I get the same issue.
Unknown Encrypted Error
Sorry, an unidentified encrypted error has caused playback to fail. Please check your browser and try again.

InvalidStateError: Failed to execute 'update' on 'MediaKeySession': Rejected with system code (72)

UDID:
0a339a8e-d8fd-4322-9453-dce9eb367907

It is really difficult to tell for sure without more information about the implementation, but these kinds of errors is often triggered in the EME layer, e.g. due to not handling other errors correctly, a race condition, or breaking some rule of the system (the CDM can be quite sensitive at times). IIRC this error, 72, means that a parameter passed to the CDM is NULL, so there is likely some error with the input data to the update() call.

Oh okay I see, I wonder what the issue is exactly?
This started a week ago and I tested it on Edge at the time because my sister had to resort to it to watch The Walking Dead with me but I just tested it on my girlfriends laptop and on Google Chrome 103.0.5060.114 it's also having the same issue and when I check the components and check for updates it will say not updated but has Widevine 4.10.2449.0

The reason it says "not updated" is that 4.10.2449.0 is the latest version available, not that it failed to update. If you get an actual install error the message should be different.
ECS 16 and later use the exact same mechanism for installing CDM updates as Chrome/Chromium does, so you will have the same CDM installed. Since you are seeing the same issue in Chrome the error is almost definitely on the Binge web site (or with their DRM provider), not in ECS.

Hmm okay I see, I just tried Firefox and Edge on Linux and now even Edge is having the same issue so it must be a Binge related problem.

Oh my notebook it's still working, you sure it doesn't have anything to do with it managing or download widevine?

Folder with files

Folder missing files

I can't be completely sure of the cause since I can't reproduce the problem (I don't have a Binge account), but I'm very confident that the issue is not with ECS itself since you are seeing the same issue on Chrome.
About the CDM installation, the files you are missing are the files installed by ECS versions prior to 16, which are labeled wvvmp. These releases uses Lorry and instals the CDM directly in the WidevineCdm directory. The more recent releases, labeled wvcus, uses the Component Updater Service (CUS) and installs the CDMs in the versioned directories below WidevineCdm instead (if you dig deeper into those you should find a CDM binary in each version directory). So the "extra" files you are seeing on your laptop are residual files from prior a ECS installation. Btw, what does the log message from whenReady() where you log components.status() say? It should tell you which CDM version is in use and if it was updated.
I'm not sure why things stopped working when you removed/regenerated your Binge directory, but there could be a lot of state in there that is now missing or different. This includes cookies, which could have held state information that affects how the Binge site behaves.

Hmm alright
Here is the on ready log
components ready: {
  oimompecagnajdejgnnjijobebaeigek: {
    name: 'Widevine Content Decryption Module',
    status: 'new',
    version: '4.10.2449.0'
  }
}

Ok, that looks good then. I'm using the same CDM for my tests with other streaming sites and everything is working fine.

Yeah but not sure why it's no longer working for Binge

After reporting it the issue has been fixed.
Thanks for the replies 😊

Thats good news. I guess we can close this then, unless there are further complications?

Yeah I will close the issue. Thanks for the help.


Cannot read property 'timeout' of undefined and crash

What are the steps to reproduce?
Run Node Red on Portainer or Docker.
Add Mqtt Input node, some delay nodes and trigger nodes.
Inject some flow into it and deploy.

What happens?
NodeRed completely crashes after a while.
What do you expect to happen?
NodeRed to report an error to fix.
Please tell us about your environment:

[ ] Node-RED version: v1.0.3
[ ] Node.js version: v10.18.0
[ ] npm version: Edge Gateway NIOT-E-TPI51-EN-RE
[ ] Platform/OS:
[ ] Browser: Firefox

Docker Logs:
20 Feb 21:30:27 - [warn] Communication send error: Error: WebSocket is not open: readyState 3      (CLOSED)

20 Feb 22:00:09 - [red] Uncaught Exception:

20 Feb 22:00:09 - TypeError: Cannot read property 'timeout' of undefined

at completeSend (/usr/lib/node_modules/node-red/node_modules/@node-red/nodes/core/sequence/17-split.js:432:32)

at Timeout._onTimeout (/usr/lib/node_modules/node-red/node_modules/@node-red/nodes/core/sequence/17-split.js:624:29)

at ontimeout (timers.js:436:11)

at tryOnTimeout (timers.js:300:5)

at listOnTimeout (timers.js:263:5)

at Timer.processTimers (timers.js:223:10)

Fix:
In order to get NodeRed running again, I had to restart the docker container manually.

Can you provide the flow that caused this crash?

Sorry i can't provide the flow because the device is installed on my client network and there are sensitive data about his company inside. Sorry for my english by the way.

We need more details to understand what is happening. If you cannot provide the actual flow, can you provide a simplified flow that recreates it? Or maybe a better description of what nodes are involved, how they are configured and what the messages look like.
In particular, what messages are being passed to any Split node you have

Ok, i've recreated the flow without credentials
flows(5).zip

@VerardiA that flow has over 400 nodes in it - many of which I don't have installed locally. Please can you narrow it down to just the flow that is hitting the issue.
What we really need to know is:

how is the Split node configured?
what message(s) are you passing it?

Ideally, this would be just an Inject/Change node pair to create the message that is then passed to a Split node to recreate the issue.

After a more in-depth search maybe I found the problem.
There is a join node that combines 92 modbus messages from the plc, the "completeSend" error is generated by the join node and not the split node.
I tried to remove the join node timeout and replace it with a trigger node. If the problem persists I will let you know.
Thanks for pointing out that the join and split nodes come from the same file.

flow-join-crash-20200623.json.txt
This flow triggers the crash 3 second after start.
It's a timestamp inject, a function to create the msg.complete, and a join node with Mode "manual", key/value as Object. The only trigger is waiting for "After a message with the msg.complete property set".
This is the backtrace:
TypeError: Cannot read property 'timeout' of undefined
    at completeSend (/usr/local/node-red/nodes/core/logic/17-split.js:432:23)
    at JoinNode.<anonymous> (/usr/local/node-red/nodes/core/logic/17-split.js:542:29)
    at emitOne (events.js:116:13)
    at JoinNode.emit (events.js:211:7)
    at JoinNode.Node.receive (/usr/local/node-red/red/runtime/nodes/Node.js:215:14)
    at FunctionNode.Node.send (/usr/local/node-red/red/runtime/nodes/Node.js:202:14)
    at sendResults (/usr/local/node-red/nodes/core/core/80-function.js:52:18)
    at FunctionNode.<anonymous> (/usr/local/node-red/nodes/core/core/80-function.js:221:21)
    at emitOne (events.js:116:13)
    at FunctionNode.emit (events.js:211:7)
    at FunctionNode.Node.receive (/usr/local/node-red/red/runtime/nodes/Node.js:215:14)
    at InjectNode.Node.send (/usr/local/node-red/red/runtime/nodes/Node.js:137:22)
    at InjectNode.<anonymous> (/usr/local/node-red/nodes/core/core/20-inject.js:77:22)
    at emitOne (events.js:116:13)
    at InjectNode.emit (events.js:211:7)
    at Timeout._onTimeout (/usr/local/node-red/nodes/core/core/20-inject.js:46:20)

Versions:

Node-RED version: v0.18.7
Node.js  version: v8.11.3

The original line was: 17-split.js#L432
Current version of this line also not helps:
https://github.com/node-red/node-red/blob/708620f929199b392c5a30cae502b540f94546d0/packages/node_modules/%40node-red/nodes/core/sequence/17-split.js#L430
With this lines found, that "group" is undefined:
if (group !== undefined) {
    if (group.timeout !== undefined) {
        console.log("group.timeout is OK!");
    } else {
        console.log("group.timeout is UNDEFINED!");
    }
} else {
    console.log("group is UNDEFINED!");
}
console.log( 'group: ' + JSON.stringify(group) );
if (group.timeout) { clearTimeout(group.timeout); }

Output:

group is UNDEFINED!
group: undefined
TypeError: Cannot read property 'timeout' of undefined

Fixed in the dev branch for the 1.1.0 release.


Automatic Refresh and Rebuild for Nuxt with Schema Changes

Describe the feature
Hi, I use Elysia in combination with Nuxt. When I make changes to my API on the server, it would be nice if I could trigger a refresh after a certain number of minutes when my API changes, so that Nuxt can build the new TypeScript files. I'm not sure if this is possible at runtime, though. Thanks for the module!
Additional information

[X] Would you be willing to help implement this feature? ( i am thinking)

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

It is not possible in runtime unfortunately. Although this can be done, it is beyond the scope of this module.
I would use a client from Elysia itself - https://elysiajs.com/eden/overview.html#eden-treaty-recommended.


Filter Transaction return : Info There is no data with the filter below.Filter....

Prerequisites
Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

[ ] I have checked the FAQ, and issues and found no answer.
yes

What version of pinpoint are you using?
master/v1.7.3/v1.7.2 etc.
v1.8.2
Describe your problem**
A clear and concise description of what is not working.
pinpoint : Filter Transaction return : Info There is no data with the filter below.Filter....
What have you done?
Steps you have taken to trigger the problem, for example:

Launched '...' with agent
Tried tracing '...' (see agent log below)
Collector outputs trace log (see collector log below)
No trace shows up in the web UI (see web log below)

Screenshots
If applicable, add screenshots to help explain your problem.

Logs
If applicable, please attach agent/collector/web DEBUG log that includes the part where you have encountered the problem. In case of agents, including the start-up log may be of great help.
web server catalina.out log:
2019-04-26 12:32:20 INFO  Building application map
2019-04-26 12:32:20 WARN  agentInfo not found. application:log1-kwethicbta40036(SPRING_BOOT          :1210)
Additional context
Add any other context about the problem here, such as affected library for agents, how your collector/web/hbase is set up if applicable.
I compiled the pp source code with the web server and applied,then got error

catalina.out log:
2019-04-26 14:27:48 INFO  Handle Zookeeper Event(WatchedEvent state:SyncConnected type:NodeDataChange
d path:/pinpoint-cluster/collector/44671@kwethicbta56535) completed.
2019-04-26 14:29:57 DEBUG build filter from string. [{"fa":"USER","fst":"USER","ta":"log1-kwethicbta4
0036","tst":"SPRING_BOOT","ie":null}]
2019-04-26 14:29:57 DEBUG build filter hint from string. {}
2019-04-26 14:29:57 DEBUG filterHint:FilterHint{rpcHintList=[]}
2019-04-26 14:29:57 DEBUG FilterDescriptor=FilterDescriptor{fromApplicationName='USER', fromServiceTy
pe='USER', toApplicationName='log1-kwethicbta40036', toServiceType='SPRING_BOOT', fromResponseTime=null, toResponseTime='null', includeExcep
tion=null, url='null', fromAgentId='null', toAgentId='null'}
2019-04-26 14:29:57 DEBUG agentFilterFactory:AgentFilterFactory{fromAgent='null', toAgent='null'}
2019-04-26 14:29:57 INFO  filterType:USER_TO_WAS

Hi @xjpfox
We can't seem to replicate the issue.
Are the spans being stored correctly? ie can you see the requests in the scatter chart and when you drag them, does the call stack show up properly?
Also, could you post more of the pinpoint web log?


Why does the number of extension users seem to drop to ~0 in graphs 7 and 10

Y tho

It drop to 0.25m or 0.7m. Because of price sensitivity.