Reading Date values from cell

I tried the parsing with sharedStrings and the value of cells directly in case of numbers. Both work fine. But when there is a date in the cell field. It's not returned as String, which I thought it would be. But I get a rather random number 4328 something.

Hi @sourav13, thank you for reporting this. Would you be able to attach this file here or to send it to<EMAIL_ADDRESS>if you can't share the file publicly? This way it would be significantly easier to reproduce and fix the issue.

Dates.xlsx

Hello @MaxDesiatov So have you tested it with above file?

Hi @sourav13, these dates are stored in a special "OLE Automation Date" format:

An OLE Automation date is implemented as a floating-point number whose integral component is the number of days before or after midnight, 30 December 1899, and whose fractional component represents the time on that day divided by 24. For example, midnight, 31 December 1899 is represented by 1.0; 6 A.M., 1 January 1900 is represented by 2.25; midnight, 29 December 1899 is represented by -1.0; and 6 A.M., 29 December 1899 is represented by -1.25.

For now you can parse these dates by converting the string to a Double or Decimal value and then converting it to a date using an algorithm described above. CoreXLSX will be able to convert those dates for you automatically in a future version and I'll keep this issue open until then.

@MaxDesiatov  I tried parsing them as strings, If they would have been parsable as strings I would have tried converting them to the desired format but I can't read them as Strings from sharedStrings Model.

These cells don't have type "s" which would indicate their value is stored in sharedStrings, it can be accessed directly from the value property instead.

I apologize for the delay. There's a new dateValue property added on the Cell type in #102, hope this resolves the issue.


Unit tests for lambda node.js code

Mocha unit tests for all the code in site-builder/index.js
Using Istanbul to confirm 100% coverage of that file (except for a few spots that I've marked to be ignored for coverage)
Only formatting changes in site-builder/index.js (and some minor refactoring, that I only did after writing all the tests)
Travis config file so these tests can run on every commit in AWSPics from now on, see successful test build that I triggered at https://travis-ci.com/github/Jaza/AWSPics/builds/198224105

Would be nice to also write tests for the other lambda files resize/index.js and login/index.js , I have just done the site builder for now.
Why did I bother doing all this, you ask? Because I'd like to make a few enhancements to the site builder, and I want to be confident that those enhancements don't break any existing functionality. Best way to do that is to put in place a safety net of high test coverage for the existing code.

This is amazing, thank you so much! I'm a completely Javascript noob, so really appreciate the formatting and refactoring, and of course setting up unit tests. I've never heard of Mocha or Istanbul for example.
If you don't mind, I'll change the CI provider from Travis CI to GitHub Actions on this PR branch. I've generally been enjoying GitHub Actions for my other projects, especially in light of Travis CI's recent changes to its free tier.

Successful run here: https://github.com/jpsim/AWSPics/runs/1368040521
I think in the future, CI will run on PRs too, based on how I configured the action. Not sure why it didn't run here.

Thanks for building AWSPics @jpsim , I'm a Lambda / CloudFront / KMS noob, so I really appreciate that you got all that stuff working (plus the site builder, which was a solid little script already), and that you've shared it publicly.
I'm more a Python dev and a writer of Python tests myself, although I have worked with JavaScript a decent bit too - I've written Jest tests before, this was my first time using Mocha and Istanbul too.
No problem, re: switching from Travis CI to GitHub Actions. Last time I set up CI for a public GitHub project (already a few years ago), Travis CI was still the way to go, but I see that GitHub Actions has been freely available for about a year now, and yes, I see that Travis CI has become less open source friendly of late.


Ignore bower_components

Including this in the repository kind of defeats the purpose of bower doesn't it?

There is an ongoing debate about this. As long as you run a bower install when you first fork the repo, and you use the scripts in Gruntfile.js as described in the howto, there is no need to have the bower_components folder under source control. Some are of a different opinion. Anyway, I think you have a point, so I'll merge your pull request and unstage the bower_components folder from the repository. Thanks for the heads up :+1:


Fix for leaking socket connections

Hi,
I made a small fix for leaking connections. It doesn't solve the issue entirely, but it helps to significantly slow down growing number of opened socket connections.
Could you review my changes and apply them?
Thanks.

To debug opened connections you can use following code in terminal:
lsof -i -n -P | grep "yourProcessName" to list all connections
and
sof -i -n -P | grep "yourProcessName" | wc -l to get total number of connections

Hello @dmitry-ilin! Thanks for the pull request. I've tried this with real world apps and the requester-responder pair within the examples folder; creating, destroying, and recreating requesters and responders. I couldn't reproduce the scenario where sockets leak. Can you share a reproduction scenario? Which OS are you running on?
By the way, the obj parameter passed to the added event handler is just a discovery message; it doesn't contain a sock property.

I'm using OS X 10.11.2 and Ubuntu 15.10.
The issue happens after reconnection.
For example assume we have couple of instances running on 2 physical machines. When one of them goes to sleep/halt and comes back the library reconnects these instances. Each reconnection leads to increasing number of used files. After certain amount of reconnections, system limitations are reached.
Recreating requesters/responders frees system resources.
I haven't check obj parameter passed to added event handler, but obj parameter passed to removed event handler has a sock property in some cases.
I'll try to reproduce the issue with the examples and write my results.

Thanks for the explanation. I'll try that scenario and let you know!

I was able to reproduce the issue. For reference, the reproduction scenario is as follows:

Run examples/responder.js on a machine A.
Run examples/requester.js on a machine B.
Sleep/pause machine B.
Wait until machine A detects disconnection.
Resume machine B.
Observe a new port/connection open on machine A.

Hello @dmitry-ilin, I've investigated the issue thoroughly. obj.sock only exists for Subscribers and Responders; so it's enough to include those files. May I ask you to remove your additions from Publisher.js and Requester.js?
Additionally, you had mentioned that this doesn't solve the issue entirely. What scenarios are uncovered by this fix?

Hello @dashersw !
I've removed my additions from Requester.js and Publisher.js. At this moment I cannot reproduce any other socket leaking issue using examples. I believe it could be related to environment or my app. I will monitor network connections and, if I'll find any uncovered scenario, I'll create another issue (or pull request, if I'll be lucky to solve it).

Thanks a lot!


Use javascript_include_tag in vite_client_tag

Description 📖
In order to inherit all the features of the javascript_include_tag it should be used within vite_client_tag. Otherwise you won't get CSP support and all other built-in features.
Background 📜
You won't be able to work with vite_client_tag in a CSP environment without this change.
The Fix 🔨
Use javascript_include_tag instead of tag.script

Looks good, thanks!


Unable to export complete data from the new Query Builder

When exporting data from the new Query Builder
https://iatidatastore.iatistandard.org/querybuilder/results
nothing happens upon clicking on the "Download CSV" button.
When tried doing a regular GET request using the API directly, only 10 rows showed up!
Also when changing the &rows=100 it still showed only 10 rows!
Seems the API isn't working properly.
The earlier version of Query Builder never had such an issue. We were able to export the complete data in one go.
Can someone please check this on priority? Thanks.

We can not reproduce this.


Gift:Personal note is not visible in case of F&F.

Verified this issue on dev app v2.0.68(419)


New tab to Google

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9b8d23f-25b3-6871-1c9d-afb4d15864d9
Version Independent ID: 74185998-0136-f9e7-b156-19ef7017a59e
Content: Check for keyboard support by using the Tab and Enter keys - Microsoft Edge Development
Content Source: microsoft-edge/devtools-guide-chromium/accessibility/test-tab-enter-keys.md
Product: microsoft-edge
Technology: devtools
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Closing as incomplete.


Client dependency updates

no issue

minor version bumps for the majority of out-of-date client dependencies

Are we really doing a separate commit for each dependency now? That seems aggressive, especially for dev dependencies.

@jaswilli we've been doing that for quite a while, e.g. #6463

I saw that. Standardizing the format is great, but there's no need to arbitrarily separate each dependency into its own commit.
What if two dependencies depend on each other? Are we going to break the build to adhere to this rule?
IMO, they should be grouped together in small batches and only completely isolated if common sense dictates.

What if two dependencies depend on each other? Are we going to break the build to adhere to this rule?

When that's happened the dependencies have been updated together in a single commit, usually named with the primary dependency.
What exactly is the argument against a separate commit for each dependency other than "it seems aggressive"? The only argument I can see is that the commit history is a bit more verbose but is that really an issue?

It definitely adds noise to the commit history--and what's the justification for adding that noise? What benefit is there to isolating every single dependency update to its own commit? Wouldn't simply settling on standard phrasing for dependency update commits suffice?
For a project that's always preached squashing commits unless there's a clear reason not to, this is a really strange shift in behavior.

What exactly is the argument against a separate commit for each dependency

I just made it above. It's completely arbitrary and doesn't work in cases where changes depend on each other.

Here's the background convo: https://ghost.slack.com/archives/dev/p1444213666000208
I don't think it makes any sense to do a big bundle of unrelated version bumps in one commit. Chances are changes in difference dependencies all have different impacts. The main point is for clarity of what got updated when, and ability to revert. It does make sense to group related version bumps - that was also discussed.

What benefit is there to isolating every single dependency update to its own commit? Wouldn't simply settling on standard phrasing for dependency update commits suffice?

IMO:

easy dependency rollback (ok, marginally easier but it's happened already)
ability to provide a more detailed commit comment with each upgrade, highlighting what's changed and why any application-level changes were necessary
consistency - updates are usually made independently one at a time, multiple updates in a single PR such as this are the exception rather than the rule
at-a-glance view of what dependencies have changed directly from the commit history, there's no need to dig into the full commit comments to view which dependencies have changed that may be affecting your current work

I don't think it makes any sense to do a big bundle of unrelated version bumps in one commit.

No, it almost never makes sense to update 15 dependency in one commit. Just like it doesn't make sense to update 15 dev dependencies in isolated commits. It's pretty straightforward to come up with a small batch of updates in a single commit. Then you don't have to deal with some random "rule" and what to do when it clearly makes no sense to follow it.

at-a-glance view of what dependencies have changed

git log --grep='deps:' --no-merges
Anyway, this is not the hill I'm going to die on. Carry on.

Anyway, this is not the hill I'm going to die on. Carry on.

:joy:
The long term plan is that greenkeeper will fix their thing and then we'll use that and all of this PITA will go away. For now, I personally feel more comfortable with this style over the previous one. It's just seems vaguely a lesser evil IMO.


faster single product price optimization algorithm

The current brute force method is slow.
Can we do a faster version (even if it's not guaranteeing the absolute max -- the ballpark is fine)?
We know the curve is roughly concave.

I see you closed this ticket -- is there new code that solves this issue?


results on arcane_jinx. style

Hi! very interesting work! Thanks for providing the resource for playing. BTW, could u provide more details in training the jinx style ? since there is a little difference between the model trained with Colab (based on jinx only) and the pretrained  model, as shown below:

my setting is listed:
num_iter=2000
preserve_color: false
Thanks for help

Sorry for trouble. It turns out I messed up with the codes on Colab...The alpha setting was wrong. Everything is done after set to 1. Thanks!


Add unique, nullable, PK,  defaultValue, required conditions in mysql

Thanks, but you need to try this configuration, I had some problems with paying primary keys, and other unique attributes. And it seems that those mistakes are waterline.


MAINT: allow CI to run on non-master PRs

Codecov Report

Merging #96 into master will decrease coverage by 3.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##            master      #96      +/-   ##
===========================================
- Coverage   100.00%   96.93%   -3.07%
===========================================
  Files            3        2       -1
  Lines          526      522       -4
===========================================
- Hits           526      506      -20
- Misses           0       16      +16

Impacted Files
Coverage Δ

scikeras/_utils.py
96.35% <0.00%> (-3.65%)
:arrow_down:

scikeras/wrappers.py
97.14% <0.00%> (-2.86%)
:arrow_down:

scikeras/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bf42a...fa7226b. Read the comment docs.


[Ethereum] Support decoding contract data / abi

Fixes #1034.
Description
Supports Ethereum contract call decoding (types: uint256, address, string, bool, bytes) return readable json format. C interface also simplified.
A decoded swap call example:
{
    "function": "swapExactTokensForTokens(uint256,uint256,address[],address,uint256)",
    "inputs": [{
        "name": "amountIn",
        "type": "uint256",
        "value": "1000000000000000000"
    }, {
        "name": "amountOutMin",
        "type": "uint256",
        "value": "2494851601099271131"
    }, {
        "name": "path",
        "type": "address[]",
        "value": ["0x6b175474e89094c44da98b954eedeac495271d0f", "0x9f8f72aa9304c8b593d555f12ef6589cc3a579a2", "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2", "0xe41d2489571d322189246dafa5ebde1f4699f498"]
    }, {
        "name": "to",
        "type": "address",
        "value": "0x7d8bf18c7ce84b3e175b339c4ca93aed1dd166f1"
    }, {
        "name": "deadline",
        "type": "uint256",
        "value": "1594806384"
    }]
}

TODO:

[x] Swift test
[ ] Kotlin test
[ ] TW interface test

Testing instructions
Unit tests
Types of changes

Breaking change

@vikmeup https://github.com/trustwallet/wallet-core/tree/xt/contract-parsing/tests/Ethereum/Data what else should we support?

Diff coverage is 85.80% -- can it be improved?

@catenocrypt will add more C interface tests tmr


Split the "solver" page in the documentation to make it easier to see where to find what

Still to do:

[ ] Add more text to the individual pages to make things more understandable

Codecov Report

Merging #220 (3d20564) into main (2b79def) will decrease coverage by 0.02%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   95.67%   95.66%   -0.02%
==========================================
  Files          32       32
  Lines        1133     1130       -3
==========================================
- Hits         1084     1081       -3
  Misses         49       49

Impacted Files
Coverage Δ

src/initialization/common.jl
95.83% <0.00%> (-0.17%)
:arrow_down:

src/solution.jl
98.64% <0.00%> (-0.02%)
:arrow_down:

src/diffusions.jl
98.66% <0.00%> (-0.02%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore(txs): mempool optimization

Motivation
Improves some aspects of the mempool handling.
Description
Test Plan
Tests passing

TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed
[ ] Update changelog as needed

bors try

bors merge

bors cancel

bors merge

bors merge


Implement D4PG

Distributed Distributional Deterministic Policy Gradients
Reference implementation:

https://github.com/deepmind/acme

PyTorch implementation:

https://github.com/fabiopardo/tonic

is help still wanted on this? Its open but v stale and isn't listed on the critical path for v2.0

is help still wanted on this?

yes

Its open but v stale and isn't listed on the critical path for v2.0

what do you mean?
this is a nice to have feature yes.
2.0 is only about gymnasium support, and is already the SB3 master version.


Provider does not create a new user on first login

Describe the bug
When I add the Google provider and I try to login with an email that's not in the users collection yet I expected it to create a new user in the Payload application. However it redirects back to the /admin/login page with an error that the user is not found as a query parameter:
http://localhost:3000/admin/login?error=User%2520not%2520found
To Reproduce
dependencies:
    "@payloadcms/db-postgres": "latest",
    "@payloadcms/next": "latest",
    "@payloadcms/payload-cloud": "latest",
    "@payloadcms/richtext-lexical": "latest",
    "cross-env": "^7.0.3",
    "graphql": "^16.8.1",
    "next": "15.0.3",
    "payload": "latest",
    "payload-auth-plugin": "^0.3.2",

Add a GoogleAuthProvider to the adminAuthPlugin:
 adminAuthPlugin({
      providers: [
        GoogleAuthProvider({
          client_id: process.env.CLIENT_ID,
          client_secret: process.env.CLIENT_SECRET
        })
      ],
    }),

Add a login button
      <form
        action={async () => {
          'use server'
          signin('google')
        }}
        className="w-full"
      >
        <Button type="submit" className="w-full !my-0">
          Sign in with Google
        </Button>
      </form>

Try to login with Google and use an account that does not exist in the Payload users collection.
Expected behavior
I expected it to create a user in the users collection and be logged in.
Screenshots
Desktop (please complete the following information):

OS: MacOS Sequoia 15.1.1
Browser Chrome
Version: Latest

Yes that is expected response, because the plugin do not  handle the user creation. Admin should be able to add users to the collection, if we keep the admin dashboard open to all then chances are people with wrong intention can gain access with full control

EDIT: Ok, after some thinking I understand that you do not always want to create a new account when someone logs in with something like Google. But for corporates you might do. Maybe it could be a config setting, is that an idea?
Use case: I work at a company and we use Keycloak for our IAM. Everybody should be able to login and have rights to edit, we do not wan't to add all of the users to the users collection first. If there is a new colleague, we only want to add them to keycloak and not to all of our payload applications.

Yes that makes sense. I will release this as a feature next. Thanks btw

+1 for this
Another obvious usecase would be enabling OAuth not for admins but for normal platform users, e.g. we have one "adminUsers" collection and one "users" collection with no access to the admin panel
Love your plugin by the way! We're planning do do a video about it on our Youtube channel (all about payload)

Thanks @Sandro48 for this lovely gesture and appreciation. I will definitely work this out and make sure the implementation is flexible and consistent as much as possible

That would be great! Any estimation when you'd be able to look into this? (No stress, just for our planning :)

I will start doing some research and prototyping. I can see how this is a necessary feature but I also want to keep the existing logic intact.


Looking for roleplay

Issue
It should be possible to set your character as looking for roleplay.
Characters looking for roleplay should be marked out in the In Room and Awake list. In addition, a player should be able to add a description of the type of roleplay they are looking for.

Resolved in PR #243


Select component drag bug

When I set dragToSort to true and update disabled value from false to true at the same time, there is a problem with the Select component
bug demo: https://codesandbox.io/s/clever-mahavira-dxvrhv?file=/demo.js
screenshot：

Hi, did you save your demo code? It seems like this now.

Plz reopen it after providing a valid demo.


one-way-input-mask with custom mask does not work after upgrade

Hi,
following setup worked properly with ember-inputmask versions < 0.7
//mask-definition
import Inputmask from 'inputmask';

export function initialize(/* application */) {
  Inputmask.extendAliases({
    euro: {
      suffix: " €",
      groupSeparator: ".",
      radixPoint: ",",
      alias: "numeric",
      placeholder: "0",
      autoGroup: !0,
      digits: 2,
      digitsOptional: !1,
      clearMaskOnLostFocus: !1,
      autoUnmask: true,
      unmaskAsNumber: true
    }
  });
}

export default {
  initialize
};

{{one-way-input-mask value=12.58 mask="euro"}}

Since ember-inputmask > 0.7, the same output results in following output:

The given value (12.58) is multiplicated by 100. Why?
Can you help me?
thank you

It looks like this is an ongoing issue with Inputmask.js. See: https://github.com/RobinHerbots/Inputmask/issues/1655
However, it looks like a fix is coming 🤞 from https://github.com/RobinHerbots/Inputmask/commit/8177635957c0ad298e20e36277ed287608db5001
Best advice I can give right now is if you have data that already exists that you want to display, to format the numbers yourself so that the input will understand them. Then typing from there should work fine. This sucks, but hopefully in the 5.0 release of Inputmask.js it will work as expected
{{one-way-number-mask
  value='12,58'
  decimal=true
  options=(hash
    suffix=" €"
    groupSeparator='.'
    radixPoint=',')}}


Defining constructors as bound methods

First of all, I'm not entirely +1 on this, as it makes bound constructors inconsistent with other bound methods... that being said, maybe bound constructors could be bound the constructor function itself, so it can easily refer to ("static") properties of the constructor function?
I have a few classed that are purely "static", without any prototype properties, which also use the constructor to receive "messages" and delegate them to other methods (its really more of a function with some internal functions that it delegates to than it is a class, but classes are a much nicer way to organize that - its more readable as it stands out as a "special" block of code, it has a nicer syntax and I get a scope for private data). To write those, I'd like to be able to do:
class foo
  constructor: (req) =>
    if req.bar is 'baz'
      @qux req
    else
      @corge req
  @qux: -> ...
  @corge: -> ...

Which would compile @ into Foo inside the constructor function. Currently, I have the class name written explicitly all over the constructor function, which is somewhat annoying after getting used to CoffeeScript's @.
As I mentioned at the beginning, this is inconsistent with "regular" bound prototype methods, as they're bound to the instance. However, it is consistent with the behavior of regular (non-prototype) bound functions, which also compile this to the constructor function.
edit: After posting this, I realized that @constructor: -> might be more appropriate? The syntax is consistent with other static methods and shouldn't cause any confusion. However, It does already have a valid usage which'll break (which probably isn't common).

Interesting, but nope -- I think that the appropriate context for any constructor function is the instance you're constructing. In fact, that's 99% of the point of having a constructor in the first place. If you'd like to reference the class, just use the class' name.

the appropriate context for any constructor function is the instance you're constructing
But if I'm not constructing any instance (i.e. using the function without new), why not make it possible to give a meaningful value to this, instead of the global object (or null in strict mode)?

If you're not using new, then definitely don't use a constructor.


optimize: lock priority attempts to insert

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
锁重试大于1次&开启跳过锁检查/前镜像为空时首次注册跳过锁检查
当前pr 1rm 2tc redis mode 对同一件商品进行扣库存并发50 2000次下单请求

1.5.1测试结果

当没有锁重入,且事务基本上决议为提交时,redis模式下提升50%的平均rt表现
1.5.1 并发改为32 1000次扣库存 db模式

当前pr测试结果

总和测试结果无论是db还是redis都是有非常大的提升
Ⅱ. Does this pull request fix one issue?

fixes #4683
fixes #4872
fixes #5088
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #4681 (a6b755b) into develop (8f96afa) will increase coverage by 0.15%.
The diff coverage is 20.00%.

@@              Coverage Diff              @@
##             develop    #4681      +/-   ##
=============================================
+ Coverage      48.44%   48.59%   +0.15%
- Complexity      4035     4054      +19
=============================================
  Files            735      735
  Lines          25600    25606       +6
  Branches        3161     3163       +2
=============================================
+ Hits           12401    12443      +42
+ Misses         11860    11827      -33
+ Partials        1339     1336       -3

Impacted Files
Coverage Δ

...java/io/seata/rm/datasource/ConnectionContext.java
70.33% <0.00%> (-4.02%)
:arrow_down:

...a/server/storage/db/lock/LockStoreDataBaseDAO.java
50.24% <0.00%> (-0.75%)
:arrow_down:

...n/java/io/seata/rm/datasource/ConnectionProxy.java
25.50% <66.66%> (+0.33%)
:arrow_up:

...erver/storage/file/session/FileSessionManager.java
49.04% <0.00%> (-0.64%)
:arrow_down:

...rage/redis/store/RedisTransactionStoreManager.java
66.66% <0.00%> (+3.70%)
:arrow_up:

...java/io/seata/server/storage/SessionConverter.java
89.09% <0.00%> (+9.09%)
:arrow_up:

...va/io/seata/server/console/vo/GlobalSessionVO.java
55.88% <0.00%> (+33.82%)
:arrow_up:

@caohdgege  PTAL

When the version is 1.7.0, the problem is reproducible.
errMsg: TransactionException[branch register request failed. xid=, msg=Duplicate entry 'jdbc:mysql://<IP_ADDRESS>:3306/order^^^sys_order^^^3' for key 'lock_table.PRIMARY']


Subdue container labels to distinguish them from space views

What
As the title says ☝🏻. Note that the icon still reflects visibility.
Here, the tab widget is visible but not the vertical one:

Selection panel (which currently doesn't reflect visibility state https://github.com/rerun-io/rerun/issues/4854):

Relates to:

https://github.com/rerun-io/rerun/issues/4743

Note: this PR piles on debt to be paid off with:

https://github.com/rerun-io/rerun/issues/4802

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[ ] I have tested the web demo (if applicable):

Using newly built examples: app.rerun.io
Using examples from latest main build: app.rerun.io
Using full set of examples from nightly build: app.rerun.io

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

[PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
[Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)
[Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)
Recent benchmark results
Wasm size tracking

I don't think this design really worked. It's too hard to distinguish and greying out just the names didn't really communicate that there is something different about this kind of thing

I don't think this design really worked. It's too hard to distinguish and greying out just the names didn't really communicate that there is something different about this kind of thing

I agree. I'm not really sure how to go forward from this. Color? That's how macOS/windows deals with that: coloured, very strongly styled icons for containers.

Any icon sub-typing is very discreet:

@martenbjork help! 😅

Should we draft this?

Should we draft this?

We actually decided to discard it.


ima: Convert pcrval to bytes to increase efficiency

The pcrval in process_measurement_list originates from the IMA log and is
a hex number in string form. Convert it to its bytes representation once
rather than converting the running_hash every time we do a comparison.
Signed-off-by: Stefan Berger<EMAIL_ADDRESS>

LGTM. This PR passes successfully on our "private" end-to-end CI/CD.

Just pushed a slightly updated commit text that reflects that pcrval may not be set.


Incorrect URL behaviour on multisite setup

Similar issues:

Can’t get bedrock + multisite running properly on Apache
Redirect & permalink problems after moving multisite to a new server

The only way to get things works

Create new projectcomposer create-project roots/bedrock [dirname]

Create new database and setup database config on .env file accordingly. Also make sure WP_SITEURL is suffixed with /wp# db config here

WP_ENV=development
WP_HOME=http://roots.local
WP_SITEURL=${WP_HOME}/wp

Setup multisite constants on config/application.php file and since I'll need to use sub-domain, set SUBDOMAIN_INSTALL to true and PATH_CURRENT_SITE to /wp/$base = '/';
Config::define('WP_ALLOW_MULTISITE', true);
Config::define('MULTISITE', true);
Config::define('SUBDOMAIN_INSTALL', true);
Config::define('DOMAIN_CURRENT_SITE', 'roots.local');
Config::define('PATH_CURRENT_SITE', '/wp/');
Config::define('SITE_ID_CURRENT_SITE', 1);
Config::define('BLOG_ID_CURRENT_SITE', 1);

Generate new salts using wp-cli-dotenv-commandwp dotenv salts generate

Create public/.htaccess file based on this support documentationRewriteEngine On
RewriteBase /
RewriteRule ^index\.php$ - [L]

# add a trailing slash to /wp-admin
RewriteRule ^wp-admin$ wp-admin/ [R=301,L]

RewriteCond %{REQUEST_FILENAME} -f [OR]
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^ - [L]
RewriteRule ^(wp-(content|admin|includes).*) $1 [L]
RewriteRule ^(.*\.php)$ $1 [L]
RewriteRule . index.php [L]

Last but not least, install the wordpress core multisitewp core multisite-install --title="Local WordPress"<EMAIL_ADDRESS>

Everything's seems to work just fine BUT every time I create new site it will always be suffixed with /wp

Workaround
PATH_CURRENT_SITE
If I change the PATH_CURRENT_SITE to / and keep WP_SITEURL as is, then reinstall the site :
wp db reset --yes
wp core multisite-install --title="Local WordPress"<EMAIL_ADDRESS>
The Network Admin menu in the top Admin Bar will link to [domain]/wp-admin/network instead of [domain]/wp/wp-admin/network

WP_SITEURL
In the other hand, if I change WP_SITEURL to ${WP_HOME} (without suffix /wp) and bring PATH_CURRENT_SITE back to /wp/. Everything is ruined 😅

Might be related:

https://github.com/roots/bedrock/issues/325
https://github.com/roots/bedrock/issues/250
https://github.com/roots/multisite-url-fixer/issues/3
https://github.com/roots/multisite-url-fixer/issues/1

Hello all @feryardiant @creasi
I found a solution based on removing the vars definition from ENV and passing to the application file which is php and can get the domain.
The function is:
function siteURL(){
    $protocol = (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off' || $_SERVER['SERVER_PORT'] == 443) ? "https://" : "http://";
    $domainName = $_SERVER['HTTP_HOST'].'';
    return $protocol.$domainName;
}

and then:
/**
 * URLs
 */
Config::define('WP_HOME', siteURL());
Config::define('WP_SITEURL', siteURL() . '/wp');

and
Config::define('DOMAIN_CURRENT_SITE', str_replace("https://", "",siteURL()));
The unique problem is that this also changes the network admin url on the "non-main domains" but to update plugins and everything you can do it accessing from the main domain.
Not a huge issue.
Hope it helps to anyone :)
Bests!


[CMSIS-NN] Move CMSIS_5 from SHA to release based upgrade

This commit removes the SHA based checkouts for CMSIS core repo.
Consequently, this solves the problems of missing SHA archives.
CMSIS_5: release 5.9.0
CMSIS-NN: release v4.1.0
cc: @leandron @lhutton1 @NicolaLancellotti @neildhickey

This was dependent on https://github.com/apache/tvm/pull/15836, so re-trying now to see if CI works this time.

Thanks @ashutosh-arm @NicolaLancellotti @leandron @neildhickey


Is it has to be Uint64?

NextLong can return just long type since sql server don't support unsigned bigint type.

Is there an added value for the use for the data type uLong?
For the database I need a normal long. uLong can be converted to long, but will this be a problem in the future? It feels wrong to use the datatype uLong.

NextLong can return just long type since sql server don't support unsigned bigint type.

Maybe you can add mschuler as an assignees so he can get an email notification and answer your/our question.


Update Jenkinsfile

Running presubmits at https://istio-testing.appspot.com/job/manager/job/presubmit/277/ ...

manager/presubmit passed. Details at https://istio-testing.appspot.com/job/manager/job/presubmit/277/.

Running presubmits at https://istio-testing.appspot.com/job/manager/job/presubmit/278/ ...

manager/presubmit failed. Details at https://istio-testing.appspot.com/job/manager/job/presubmit/278/.

Any description would be very helpful. :)

Running presubmits at https://istio-testing.appspot.com/job/manager/job/presubmit/279/ ...

manager/presubmit passed. Details at https://istio-testing.appspot.com/job/manager/job/presubmit/279/.


Change help block margin to 4px

Description
Fixes DG-367

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Phi-Thien Hoang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #172 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #172   +/-   ##
========================================
  Coverage    91.13%   91.13%
========================================
  Files          126      126
  Lines         2098     2098
========================================
  Hits          1912     1912
  Misses         186      186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f9bfe...57f497e. Read the comment docs.


[fips][cli][rsa] Sign/verify something with a non-FIPS key should fail in FIPS mode

This was triggered by the tests in #12291 .
It is likely related (or a duplicate of) #12627 : this tracks the defect for RSA in particular, but like discussed in https://github.com/openssl/openssl/issues/12627#issuecomment-671863791 this is likely a more central problem in which we should be  stricter in several places.
20-test_cli_fips.t .. 3/?
../../util/wrap.pl ../../apps/openssl dgst -sha256 -sign RSA.nonfips.priv.pem -out RSA.nonfips.fail.sig ../../providers/fips.so => 0
    not ok 8 - RSA: Sign something with a non-FIPS key (should fail)
# ------------------------------------------------------------------------------
    #   Failed test 'RSA: Sign something with a non-FIPS key (should fail)'
    #   at ../../home/tuveri/repos/ossl_committer/test_cli_fips/test/recipes/20-test_cli_fips.t line 112.
Verified OK
../../util/wrap.pl ../../apps/openssl dgst -sha256 -verify RSA.nonfips.priv.pem -signature RSA.nonfips.sig ../../providers/fips.so => 0
    not ok 9 - RSA: Verify something with a non-FIPS key (should fail)
# ------------------------------------------------------------------------------
    #   Failed test 'RSA: Verify something with a non-FIPS key (should fail)'
    #   at ../../home/tuveri/repos/ossl_committer/test_cli_fips/test/recipes/20-test_cli_fips.t line 121.

Already addressed.. Securitycheck code was added. There are tests in evp_test also.


Kusto - AzureCore changes

Changes to show Azure Data Explorer clusters in the Azure Core widget

Coverage increased (+2.6%) to 40.397% when pulling a214ac3b380689c5bc180c2e40cf70daaaac6860 on PR/KustoAzureCoreExtension into 86fcd05eff0a4399530735e856a364287b3d083f on main.


PWM permission problem with new unrooted environment

debian@beaglebone:~$ ls -la /sys/devices/platform/ocp/48300000.epwmss/48300200.pwm/pwm/pwmchip0/pwm0/enable
-rw-r--r-- 1 root root 4096 Sep 27 19:53 /sys/devices/platform/ocp/48300000.epwmss/48300200.pwm/pwm/pwmchip0/pwm0/enable

I get Error: EACCES: permission denied, open '/sys/devices/platform/ocp/48300000.epwmss/48300200.pwm/pwm/pwmchip0/pwm0/enable' when trying to analogWrite so I've added rules
SUBSYSTEM=="pwm", ACTION=="add", PROGRAM="/bin/sh -c '/bin/chown -R root:pwm /sys/devices/platform/ocp/*.epwmss'"
# Change user permissions to ensure user and group have read/write permissions
SUBSYSTEM=="pwm", ACTION=="add", PROGRAM="/bin/sh -c '/bin/chmod -R ug+rw /sys/devices/platform/ocp/*.epwmss'

but it doesn't persist after reboot. How can I fix that permanently?

This patch:
https://github.com/RobertCNelson/bb-kernel/blob/am33x-v4.11/patches/drivers/pwm/0001-pwm-Create-device-class-for-pwm-channels.patch
or v4.11.x-bone+ kernel or later:
Regards,

@RobertCNelson can you tell me where can I find a usable kernel-bonescript pair, please?
I've installed "testing" kernel, 4.13.4-bone1, and apparently pwm paths are not compatible with this kernel.
As for the patch http://elinux.org/BeagleBoardLinuxKernel looks a bit complicated, I'd better go for an older version with root-env but the one that works. Debian 8.7 2017-03-19 4GB SD LXQT can you tell me please if this version is reliable?

@ulitiy and you see why i haven't backported that patch to v4.4.x/v4.9.x..
bonescript needs to be patched. (and also the adafruit library), you'll notice in the pwm patch it's only 3 more characters.  creating issue here:
https://github.com/jadonk/bonescript/issues/156
Regards,


Change private methods to protected

With everything set to private it's not possible to extend the class to include non-included methods while reusing the existing auth and curl methods already in this library. This change allows for extending the class so that missing methods can be extended into the class without having to PR and wait for a response.

Looks sensible 👍


Add links to the Pin API

since the pin API are spec'ed, we could add the links to the spec'ed API...

keep all of this reviews coming @enricomarino, they are super appreciated :)


content with highlighted texts

I am sorry to tell you that in the preview I still could make the spans overlap. Something seems not be correct with your "doSelectionsOverlap".

Oh And I accidentally deleted elements from your DB, the delete Icon looks like a speech bubble, you should condider using a trash bin here.

I am sorry to tell you that in the preview I still could make the spans overlap. Something seems not be correct with your "doSelectionsOverlap".

Hey Felix, thank you for another review and for detecting the bug. I could recreate the bug now and found out the cause. It happens when the new selection is made over the previous on loaded from the datenbank right? yeah i mistakenly didnt push the positions of the selections to the database :(

ah alright good that you found the issue. RN the deployment doesnt work, so you might have to look into that.

I was testing the overlapping alarm and found out that the offset values of a selection inside a paragraph are not relative to the paragraph itself but to any nearest tag showing up before the selection. Since I have no control over the content of the articles loaded, I cant run after those offset value :(. So for now I restricted the selecting options, so that one can only make one selection per paragraph. Users has to delete the previous one first if they wish to make another selection in the same paragraph

About the problem we were discussing yesterday: I was trying to replace the html string of the document (fullcontent part) with the inner content of the selection being deleted...But by assigning the new string to document innerHTML, the click events on other highlight spans were also removed, so that one can not delete the other selections anymore. I tried to put back the click event on all highlights inside useEffect with condition array being the updated content, but it didnt do. So for now I leave replaceWith there for deleting. It doesnt cause problem now anyway when the check of overlapping in a paragraph was already aborted

Nah you are doing so well! But this is something that will appear all the time as a web dev ^^


[Feature Request]: Linux distribution

What is your idea?
Hopefully this software can be ported to Linux

Thanks for your request!
This would require an almost complete rewrite of the application. I simply do not have the time for that and I want to use that time to improve the stability and add other (smaller but not small) features.  This does not mean that I will not reconsider this in the future, so I will keep this issue open.

Great, this project is really a great one, I like it, it has a very modern UI design, and it has convenient biometric authentication.


[libpq] Make sure it is possible to run configure.

Sets the execution mode of the "configure" file used for configuring the compilation of the "libpq" library.

What does your PR fix?

Fixes the compilation of the "libpq" library, which can not continue on Linux due to a permission denied error caused by the "configure" file having the wrong execution flag settings.

Which triplets are supported/not supported? Have you updated the CI baseline?

All triplets are supported, but the only triplets affected are the Linux related ones.

Does your PR follow the maintainer guide?

Yes, it follows the guidelines. Also, it is a trivial change.

A port file was updated [libpq] and the version was incremented, as necessary.
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Fixes the compilation of the "libpq" library, which can not continue on Linux due to a permission denied error caused by the "configure" file having the wrong execution flag settings.

Which version is broken, and on which Linux distribution?
Neither in CI, nor on my computers, I see a wrong permission.


better debugging

Is your feature request related to a problem? Please describe.
No but yes...
When debugging with console output its often like (not language specific)
log("1 + 2: " + ((1+2) as string))
log("i: " + (i as string))
log("i: " + (i as string) + "\t1+2: " + (3 as string) + "\ti+6(" + (i as string) + "+6: " + ((i+6) as string))

What would be great is a build in which does this automatically like:
debug(1 + 2)
debug(i)
debug(i, 1+2, i+6)

output:
"1 + 2": 3
"i": 4
"i": 4
"1 + 2": 3
"i + 6"(4 + 6): 10

Describe the solution you'd like
Give a calculation or variable into function, and the function prints what arguments are given plus the solution/calculation/value/etc.
Describe alternatives you've considered
idk
Additional context
debugging sucks

This is something i will consider, but I'm currently working on improvements for the code base and OOP. Improved debugging will be an upcoming feature, though.


Adding Custom OpenAi Base URL variable to the chat model node and the LLM node. [FEATURE]

Adding Custom OpenAi Base URL variable to the chat model node and the LLM node

You can find the Base Path from the node:


[SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

This is a backport of https://github.com/apache/spark/pull/28463 from Apache Spark master/3.0 to 2.4.
Minor adaptation include:

Retain the Spark 2.4-specific behavior of skipping the indylambda check when using Scala 2.11
Remove unnecessary LMF restrictions in ClosureCleaner tests
Address review comments in the original PR from @kiszk

Tested with the default Scala 2.11 build, and also tested ClosureCleaner-related tests in Scala 2.12 build as well:

repl: SingletonReplSuite
core: ClosureCleanerSuite and ClosureCleanerSuite2

What changes were proposed in this pull request?
This PR proposes to enhance Spark's ClosureCleaner to support "indylambda" style of Scala closures to the same level as the existing implementation for the old (inner class) style ones. The goal is to reach feature parity with the support of the old style Scala closures, with as close to bug-for-bug compatibility as possible.
Specifically, this PR addresses one lacking support for indylambda closures vs the inner class closures:

When a closure is declared in a Scala REPL and captures the enclosing REPL line object, such closure should be cleanable (unreferenced fields on the enclosing REPL line object should be cleaned)

This PR maintains the same limitations in the new indylambda closure support as the old inner class closures, in particular the following two:

Cleaning is only available for one level of REPL line object. If a closure captures state from a REPL line object further out from the immediate enclosing one, it won't be subject to cleaning. See example below.
"Sibling" closures are not handled yet. A "sibling" closure is defined here as a closure that is directly or indirectly referenced by the starting closure, but isn't lexically enclosing. e.g.{
  val siblingClosure = (x: Int) => x + this.fieldA   // captures `this`, references `fieldA` on `this`.
  val startingClosure = (y: Int) => y + this.fieldB + siblingClosure(y)  // captures `this` and `siblingClosure`, references `fieldB` on `this`.
}

The changes are intended to be minimal, with further code cleanups planned in separate PRs.
Jargons:

old, inner class style Scala closures, aka delambdafy:inline: default in Scala 2.11 and before
new, "indylambda" style Scala closures, aka delambdafy:method: default in Scala 2.12 and later

Why are the changes needed?
There had been previous effortsto extend Spark's ClosureCleaner to support "indylambda" Scala closures, which is necessary for proper Scala 2.12 support. Most notably the work done for SPARK-14540.
But the previous efforts had missed one import scenario: a Scala closure declared in a Scala REPL, and it captures the enclosing this -- a REPL line object. e.g. in a Spark Shell:
:pa
class NotSerializableClass(val x: Int)
val ns = new NotSerializableClass(42)
val topLevelValue = "someValue"
val func = (j: Int) => {
  (1 to j).flatMap { x =>
    (1 to x).map { y => y + topLevelValue }
  }
}
<Ctrl+D>
sc.parallelize(0 to 2).map(func).collect

In this example, func refers to a Scala closure that captures the enclosing this because it needs to access topLevelValue, which is in turn implemented as a field on the enclosing REPL line object.
The existing ClosureCleaner in Spark supports cleaning this case in Scala 2.11-, and this PR brings feature parity to Scala 2.12+.
Note that the existing cleaning logic only supported one level of REPL line object nesting. This PR does not go beyond that. When a closure references state declared a few commands earlier, the cleaning will fail in both Scala 2.11 and Scala 2.12. e.g.
scala> :pa
// Entering paste mode (ctrl-D to finish)

class NotSerializableClass1(val x: Int)
case class Foo(id: String)
val ns = new NotSerializableClass1(42)
val topLevelValue = "someValue"

// Exiting paste mode, now interpreting.

defined class NotSerializableClass1
defined class Foo
ns: NotSerializableClass1 = NotSerializableClass1@615b1baf
topLevelValue: String = someValue

scala> :pa
// Entering paste mode (ctrl-D to finish)

val closure2 = (j: Int) => {
  (1 to j).flatMap { x =>
    (1 to x).map { y => y + topLevelValue } // 2 levels
  }
}

// Exiting paste mode, now interpreting.

closure2: Int => scala.collection.immutable.IndexedSeq[String] = <function1>

scala> sc.parallelize(0 to 2).map(closure2).collect
org.apache.spark.SparkException: Task not serializable
...

in the Scala 2.11 / Spark 2.4.x case:
Caused by: java.io.NotSerializableException: NotSerializableClass1
Serialization stack:
	- object not serializable (class: NotSerializableClass1, value: NotSerializableClass1@615b1baf)
	- field (class: $iw, name: ns, type: class NotSerializableClass1)
	- object (class $iw, $iw@64df3f4b)
	- field (class: $iw, name: $iw, type: class $iw)
	- object (class $iw, $iw@66e6e5e9)
	- field (class: $line14.$read, name: $iw, type: class $iw)
	- object (class $line14.$read, $line14.$read@c310aa3)
	- field (class: $iw, name: $line14$read, type: class $line14.$read)
	- object (class $iw, $iw@79224636)
	- field (class: $iw, name: $outer, type: class $iw)
	- object (class $iw, $iw@636d4cdc)
	- field (class: $anonfun$1, name: $outer, type: class $iw)
	- object (class $anonfun$1, <function1>)

in the Scala 2.12 / Spark 2.4.x case after this PR:
Caused by: java.io.NotSerializableException: NotSerializableClass1
Serialization stack:
	- object not serializable (class: NotSerializableClass1, value: NotSerializableClass1@6f3b4c9a)
	- field (class: $iw, name: ns, type: class NotSerializableClass1)
	- object (class $iw, $iw@2945a3c1)
	- field (class: $iw, name: $iw, type: class $iw)
	- object (class $iw, $iw@152705d0)
	- field (class: $line14.$read, name: $iw, type: class $iw)
	- object (class $line14.$read, $line14.$read@7cf311eb)
	- field (class: $iw, name: $line14$read, type: class $line14.$read)
	- object (class $iw, $iw@d980dac)
	- field (class: $iw, name: $outer, type: class $iw)
	- object (class $iw, $iw@557d9532)
	- element of array (index: 0)
	- array (class [Ljava.lang.Object;, size 1)
	- field (class: java.lang.invoke.SerializedLambda, name: capturedArgs, type: class [Ljava.lang.Object;)
	- object (class java.lang.invoke.SerializedLambda, SerializedLambda[capturingClass=class $iw, functionalInterfaceMethod=scala/Function1.apply:(Ljava/lang/Object;)Ljava/lang/Object;, implementation=invokeStatic $anonfun$closure2$1$adapted:(L$iw;Ljava/lang/Object;)Lscala/collection/immutable/IndexedSeq;, instantiatedMethodType=(Ljava/lang/Object;)Lscala/collection/immutable/IndexedSeq;, numCaptured=1])
	- writeReplace data (class: java.lang.invoke.SerializedLambda)
	- object (class $Lambda$2103/815179920, $Lambda$2103/815179920@569b57c4)

For more background of the new and old ways Scala lowers closures to Java bytecode, please see A note on how NSC (New Scala Compiler) lowers lambdas.
For more background on how Spark's ClosureCleaner works and what's needed to make it support "indylambda" Scala closures, please refer to A Note on Apache Spark's ClosureCleaner.
tl;dr
The ClosureCleaner works like a mark-sweep algorithm on fields:

Finding (a chain of) outer objects referenced by the starting closure;
Scanning the starting closure and its inner closures and marking the fields on the outer objects accessed;
Cloning the outer objects, nulling out fields that are not accessed by any closure of concern.

Outer Objects
For the old, inner class style Scala closures, the "outer objects" is defined as the lexically enclosing closures of the starting closure, plus an optional enclosing REPL line object if these closures are defined in a Scala REPL. All of them are on a singly-linked $outer chain.
For the new, "indylambda" style Scala closures, the capturing implementation changed, so closures no longer refer to their enclosing closures via an $outer chain. However, a closure can still capture its enclosing REPL line object, much like the old style closures. The name of the field that captures this reference would be arg$1 (instead of $outer).
So what's missing in the ClosureCleaner for the "indylambda" support is find and potentially clone+clean the captured enclosing this REPL line object. That's what this PR implements.
Inner Closures
The old, inner class style of Scala closures are compiled into separate inner classes, one per lambda body. So in order to discover the implementation (bytecode) of the inner closures, one has to jump over multiple classes. The name of such a class would contain the marker substring $anonfun$.
The new, "indylambda" style Scala closures are compiled into static methods in the class where the lambdas were declared. So for lexically nested closures, their lambda bodies would all be compiled into static methods in the same class. This makes it much easier to discover the implementation (bytecode) of the nested lambda bodies. The name of such a static method would contain the marker substring $anonfun$.
Discovery of inner closures involves scanning bytecode for certain patterns that represent the creation of a closure object for the inner closure.

For inner class style: the closure object creation site is like new <InnerClassForTheClosure>(captured args)
For "indylambda" style: the closure object creation site would be compiled into an invokedynamic instruction, with its "bootstrap method" pointing to the same one used by Java 8 for its serializable lambdas, and with the bootstrap method arguments pointing to the implementation method.

Does this PR introduce any user-facing change?
Yes. Before this PR, Spark 2.4 / 3.0 / master on Scala 2.12 would not support Scala closures declared in a Scala REPL that captures anything from the REPL line objects. After this PR, such scenario is supported.
How was this patch tested?
Added new unit test case to org.apache.spark.repl.SingletonReplSuite. The new test case fails without the fix in this PR, and pases with the fix.
Closes #28463 from rednaxelafx/closure-cleaner-indylambda.
Authored-by: Kris Mok<EMAIL_ADDRESS>Signed-off-by: Wenchen Fan<EMAIL_ADDRESS>(cherry picked from commit dc01b7556f74e4a9873ceb1f78bc7df4e2ab4a8a)
Signed-off-by: Kris Mok<EMAIL_ADDRESS>

Test build #122831 has started for PR 28577 at commit 0b7bc9f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27477/
Test PASSed.

Hi @dongjoon-hyun and @dbtsai : could you please help review this backport PR? I did test the ClosureCleaner-related tests in both Scala 2.11 and Scala 2.12 builds locally before I sent out the PR, but it'd be nice to get some more Scala 2.12 testing.
cc reviewers of the original PR: @retronym @viirya @maropu @srowen @kiszk @cloud-fan @HyukjinKwon
Thanks!

Test build #122831 has finished for PR 28577 at commit 0b7bc9f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122831/
Test FAILed.

retest this please

Test build #122837 has started for PR 28577 at commit 0b7bc9f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/27483/
Test PASSed.

Test build #122837 has finished for PR 28577 at commit 0b7bc9f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122837/
Test PASSed.

Thank you, @rednaxelafx .
cc @holdenk since she is a release manager of Apache Spark 2.4.6.

Thank you for backporting this. I’m off today and tomorrow for health reasons, but if no one has time to review by Thursday I’ll take a look :)

@rednaxelafx We have internal Spark 2.4 builds supporting JDK11, JDK8, Scala 2.12, and Scala 2.11. I just cherry-picked this PR, and ran the full tests. I'll update the result here.

All the tests are passing in Scala 2.12 with JDK8 and JDK11 builds.
I also tested the code in the description, and it works as expected.

Scala 2.12 with JDK8

Welcome to
      ____              __
     / __/__  ___ _____/ /__
    _\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version <IP_ADDRESS>-apple-SNAPSHOT
      /_/

Using Scala version 2.12.10 (OpenJDK 64-Bit Server VM, Java 1.8.0_252)
Type in expressions to have them evaluated.
Type :help for more information.

scala> :paste
// Entering paste mode (ctrl-D to finish)

class NotSerializableClass(val x: Int)
val ns = new NotSerializableClass(42)
val topLevelValue = "someValue"
val func = (j: Int) => {
  (1 to j).flatMap { x =>
    (1 to x).map { y => y + topLevelValue }
  }
}

// Exiting paste mode, now interpreting.

defined class NotSerializableClass
ns: NotSerializableClass = NotSerializableClass@2769d577
topLevelValue: String = someValue
func: Int => scala.collection.immutable.IndexedSeq[String] = $Lambda$1751/481549862@25297d52

scala> sc.parallelize(0 to 2).map(func).collect
res0: Array[scala.collection.immutable.IndexedSeq[String]] = Array(Vector(), Vector(1someValue), Vector(1someValue, 1someValue, 2someValue))

Scala 2.12 with JDK11

Welcome to
      ____              __
     / __/__  ___ _____/ /__
    _\ \/ _ \/ _ `/ __/  '_/
   /___/ .__/\_,_/_/ /_/\_\   version <IP_ADDRESS>-jdk11-apple-SNAPSHOT
      /_/

Using Scala version 2.12.10 (OpenJDK 64-Bit Server VM, Java 11.0.7)
Type in expressions to have them evaluated.
Type :help for more information.

scala> :paste
// Entering paste mode (ctrl-D to finish)

class NotSerializableClass(val x: Int)
val ns = new NotSerializableClass(42)
val topLevelValue = "someValue"
val func = (j: Int) => {
  (1 to j).flatMap { x =>
    (1 to x).map { y => y + topLevelValue }
  }
}

// Exiting paste mode, now interpreting.

defined class NotSerializableClass
ns: NotSerializableClass = NotSerializableClass@199f2854
topLevelValue: String = someValue
func: Int => scala.collection.immutable.IndexedSeq[String] = $Lambda$1852/0x0000000800c2a040@5c9cbc69

scala> sc.parallelize(0 to 2).map(func).collect
res0: Array[scala.collection.immutable.IndexedSeq[String]] = Array(Vector(), Vector(1someValue), Vector(1someValue, 1someValue, 2someValue))

Thank you so much, @rednaxelafx and @dbtsai .

I was running tests on this patch in 2.11 and 2.12 and it looked good here too.

Thank you, @srowen !

late LGTM


Select a tool for creating the smart contract

We require a reliable tool or SDK to safely create and deploy our smart contract(s). I suggest reviewing and following this tutorial, and then discussing how we can integrate it with the UZH Fork

In my opinion we should use HardHat/VSCode or Truffle because this IDEs are compatible with Vanilla Ethereum forks

Some links to review (Safe is open source and allows custom networks). It is a lot work and research to be done, but it is possible.
We need a NFT (ERC-721) Contract and a Governor Contract deployed on the UZH Fork
We need to integrate this contracts to an interface or in its defect to implement a simple one (with a dashboard and a voting interface). We should review and discard all the other options before to implement something.
https://github.com/gnosis
https://safe.global/core


Pressing "popout chat" duplicates the streamer's window.

Happens on Linux/Firefox.

Is it something that is possible to fully fix? it seems like twitch has the same issue(though it hides chat on the page when you press pop out)

I doesn't happen on Twitch for me. What happens is when I press "Popout chat", the chat window opens and the streamer page duplicates. So there's;

The original streamer window
The duplicated streamer window
The popout chat window

Oh, this shouldn't happen! I'll look into it

Fixed!


Fix for the dark text

By adding the two lines the text color gets the required changes (both in body and in boxes)
and deleting the previous fix.
(cleaned up version of the previous PR)

implemented in:
3f11e24ff17654b912ba226d431962a03467a7e0


Kill mocked process after running make newman-mocked

After mock testing, platform_api and node are still running which leads to FATA[0000] listen tcp :8420: bind: address already in use

#1013


[consensus] simplify VoteReceptionResult enum

Changes:

Remove DuplicateVote, EquivocateVote, and OldQuorumCertificate.
Consolidate all non-new certificate results to VoteReceptionResult::VoteAdded.

Background:

The purpose of this change is to pull out PendingVotes from BlockTree.
In the future, adding votes will be handled by the EventProcessor, and obtaining the new certificate will be handled separately in PendingVotes.

Test:

cargo test -p consensus

Closes #1398

We'll take a look at this again in the future after future refactoring.


API: value_counts on a Categorical Series should have a CategoricalIndex

Thoughts on this?
In [8]: import pandas.util.testing as tm

In [9]: s = pd.Series(tm.makeCategoricalIndex(k=100))

In [10]: s.value_counts()
Out[10]:
vcKH    40
vXR9    31
Zn8J    29
dtype: int64

In [11]: s.value_counts().index
Out[11]: Index(['vcKH', 'vXR9', 'Zn8J'], dtype='object')

Now that we have CategoricalIndex (thanks Jeff), should that type be preserved so that Out[11] is a CategoricalIndex? My use-case (not shown in this example) is when the original categories are ordered, you get your value_counts and then want to sort the index.

I think that is the logical consequence of having a categorical type in series and having a CategorialIndex, so OK for me!
It is similar as how df.groupby('cat').count() now also preserves this categorical type. So in that regard, it would only be consistent that value_counts returns that as well.

There can of course be some incompatibilities, such as with plotting afterwards, but that is similar as eg the groupby case (we had some reports on that, eg #10140)

yes I would agree with that logic. go for it @TomAugspurger

Cool. I'll shot for next week.


Remove unused code

This code used to just show an message in case the error was
because of MCo and it is already fixed long time ago and we now
also exit from the script as soon as any command fails.

Looks good to me, I was slightly confused by the log message initially, you mention that 'we now
also exit from the script as soon as any command fails.', maybe also be explicit that this means we'll never trigger the if [ $? -ne 0 ]; then condition.


Build failing most of the time

Details

Project URL: http://glpi-user-documentation.readthedocs.io/
Build URL (if applicable): https://readthedocs.org/projects/glpi-user-documentation/builds/5899456/
Read the Docs username (if applicable): trasher

Expected Result
Doc get built ;)
Actual Result
Most of the time, the build fails with "An unexpected error occurred". It's just a rst/md doc with a customized template; nothing really special; no code, ...

The error here was a unicode error during setup. This will likely need some local debugging to pinpoint

Let me know if I can help... All that I can tell you actually is that the docs build locally; with sphinx 2.2.11

I think I've found the cause of the issue... This seems to bre related to the MD part of the doc. I've just disabled recommonmark.parser; and now, the docs builds fine.
After check, I can see a warning locally when it is enabled:
/usr/lib64/python2.7/urllib.py:1299: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  return ''.join(map(quoter, s))
/usr/lib/python2.7/site-packages/recommonmark/parser.py:55: UserWarning: Container node skipped: type=document
  warn("Container node skipped: type={0}".format(mdnode.t))

Our doc was previously in MD, I'm migrating to RST; disabling the module is not a big issue. Anyways, I'd expect rtfd not to fail without message :)
Hope that helps.

Finally... This does not solve the issue. The commit on which I've disabled the module has been built; but this is failing again now.

I have the same problem with two repositories. Here is an example from the Tiko'n repository:
https://readthedocs.org/projects/tikon/builds/5945523/
Interestingly, occasionaly the builds will work on a translation of the same project (but not replicably so-- a few days ago the "Urdu" translation (actually still in Spanish) was working, but now the Tamil translation is working instead):
Tamil version logs:
https://readthedocs.org/projects/tikon-ta/builds/
Urdu version logs:
https://readthedocs.org/projects/tikon-ur/builds/

Okay, I finally found the source of this. This was a bug with our celery builder where the locale was not being picked up correctly. The result was any use of os.walk threw an exception when encountering a utf8 codepoint on a filename. We used os.walk in a few places. I'm not entirely sure why this presented as non-deterministic however. A few folks noticed the builds randomly failing.
I just did a deploy of the fix today, and I successfully rebuilt your project @trasher.

Same for you @julienmalard -- builds for your project are getting past the initial failure.

Many thanks @agjohnson! It works now.

Yes, works for me as well!

Hello @agjohnson ;
Seems like this is fixed now; thank you very much!


prometheus-ingester is not known host

Installing Prometheus pump results in prometheus-ingester target down as defined at cmd/prometheuspump/prometheus.yml and as such no data loaded.
Error at Prometheus /targets:

Get http://prometheus-ingester:2112/metrics: dial tcp: lookup prometheus-ingester on <IP_ADDRESS>:53: server misbehaving

Prometheus pump container has alias prometheus-pump-withtestserver or prometheus-pump-standalone depending on test db being used or not.
prometheus-ingester does not seem to be defined anywhere.
Not sure what was intended, but one way to get around this is to add alias to prometheus-pump-standalone: &prometheus-pump at docker-compose-files/docker-compose.yml:
    networks:
      host-bridge-net:
        aliases:
          - prometheus-ingester

As long as both prometheus-pump-standalone, prometheus-pump-withtestserver are not running sharing the same alias this should be fine, but maybe there is better solution.

Hey @ajya - apologies, just doing some prioritization. Are you on the customer side or the Dell side?

Nvm, I'm guessing the Dell side since I can assign you to the ticket 😂
Are you using this Dell internal? We're trying to get a better feel for how the reference framework is being consumed so we can figure out what features are most in demand/in use. Feel free to hit me up internal if you like


feature request - force reset connection to relays

as you said the connection gets dropped from time to time and notifications don't show "until something resets it" ...
well, why not give us a button that resets it ?  if i am talking to somebody and i feel like they have probably replied but i'm not getting the reply it would be nice to have that button.
i have already seen it a few times when i am waiting for reply, it doesn't come, then i go to timeline and it's in my timeline - but it wasn't in the notifications ...
basically a manual hard reset of connection to relays option ...

In a way the browsers "reload page" button is a force reset. although I intend to fix this issue when I rebuilt the notifications view


irmin-pack: fix GC when target commit is in lower

After an existing store migrates to the lower layer, we want a GC that targets a commit in the lower layer to still run and create a sparse file (prefix + mapping) in the upper so that reads for new data do not need to go to the lower.
Before this PR, this kind of GC almost worked. The issue is that it would fail when attempting to swap the volume control file since a new temporary one was not created. This PR adds a test for this scenario and enables a previously written test that also failed with this bug.
Update: I just added a commit that now checks that a requested commit for GC is strictly newer than the previous GC commit. I reused an existing error (Gc_disallowed) by adding a string to keep from adding another error to our already long list of errors. It also finds an internal use for the latest_target_gc_offset field. :tada:
(@Firobe tagged you for review since you wrote the original test if you wanted to double-check my changes to enable it)

Codecov Report

Merging #2242 (98baa82) into main (4c38a4b) will increase coverage by 0.01%.
The diff coverage is 78.94%.

:exclamation: Current head 98baa82 differs from pull request most recent head 49f6161. Consider uploading reports for the commit 49f6161 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
+ Coverage   67.93%   67.94%   +0.01%
==========================================
  Files         136      136
  Lines       16603    16618      +15
==========================================
+ Hits        11279    11291      +12
- Misses       5324     5327       +3

Impacted Files
Coverage Δ

src/irmin-pack/unix/errors.ml
28.88% <ø> (ø)

src/irmin-pack/unix/io_errors.ml
58.33% <ø> (ø)

src/irmin-pack/unix/gc.ml
71.56% <63.63%> (-1.84%)
:arrow_down:

src/irmin-pack/unix/lower.ml
61.98% <100.00%> (+0.91%)
:arrow_up:

src/irmin-pack/unix/store.ml
65.78% <100.00%> (+0.34%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


added user_version param to ApplicationPackage constructor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@lesters Done! The only thing I'll do now is fixing the services_to_text text fomatting, because for some reason </config> is going out from indentation. But everything is already working! :smile:

Looks good, but there are test errors?

Other pull requests had that same problem on Screwdriver/7055/PR:unit-tests

Sorry for my mistake. It's done! @lesters


Support For The New Altar 1 Keyboard

The Altar 1 is a keyboard created by the Electronic Materials Office and the very first pre-orders are just being received, myself included! It's a ZMK keyboard with a github repo here -> https://github.com/electronicmaterialsoffice/zmk
I forked their repo, added my repo in your keymap editor, but I'm getting the "config directory not found" error. The Altar 1 repo is just a fork of the ZMK repo, and the configs are located under 'app/boards/arm' and their are two relevant files for both the U.K and U.S keyboard layouts - I myself need 'altar_i_us'. Can you please make this available for the keymap editor so new Altar 1 owners don't have to mess around in a ZMK config? :)

Hi @HumbleGrumble87, sorry I missed this.
The app expects that you'll have a zmk-config repo setup in which you have a config/ folder containing keymap and other such overrides, and referencing another repo for the ZMK app itself.
In this case I think you'll want to clone electronicmaterialsoffice/zmk-config and work from that. It contains separate keymaps for US and UK layouts with matching JSON files so I think you should be able to use that straight away.

Thanks @nickcoutsos! That worked! Apologies for the silly question - still getting used to stuff. Thanks!

No worries, just glad there was an easy solution. I remember speaking with them a while back about the editor, cool to see they've launched!


Clarified the scenario

This is can't be used to migrate SFB meetings to Teams. That functionality doesn't exist.  This wasn't clear to the documentation audience who may be looking for that function.

I also removed it from the Teams TOC.


Add command line argument for generating reason

Closes #95

Thank you for the exhaustive feedback, I completely forgot to update the new README.md.

Please don't resolve any conversations startred by the reviewer — it's for the reviewer to keep track of those conversations, and whether whatever issues are in them have been addressed. Otherwise, it can get hard for the reviewer to keep track of what has actually been "resolved" and what hasn't. In general, as a first approximation, the person who started the conversation decides if/when it is resolved.

Many thanks!


Opacity was dropping stuff on the floor.

Turns out we passed the wrong bounds to the PaintingContext constructor.
Fix, and assert that we don't do that again.

LGTM, but looks like Rect.isEmpty is busted.

yeah i'm on it.


Clarify domain of index systemQueryOption

The spec states:

11.4.11 Positional Inserts
Collections of entity, complex, or primitive types annotated with the Core.PositionalInsert term (see [OData-VocCore]) support inserting items at a specific location via POST requests to the collection URL using the $index system query option. The value of the $index system query option is the zero-based ordinal position where the item is to be inserted. The ordinal positions of items within the collection greater than or equal to the inserted position are increased by one. A negative ordinal number indexes from the end of the collection, with -1 representing an insert as the last item in the collection.

Which reads as assigning the domain of the whole numbers (including negative ones') to index (despite the mention of zero-based ordinal position which just mentions the mapping required to apply the value to actual collection "positions").
The grammar (ABNF) keeps index expression value within non-negative numbers (extract after percent decoding).
index  = ( "$index" / "index" ) EQ 1*DIGIT

EQ     = "="
DIGIT  = %x30-39

@sthagen Thanks for catching this, opened https://issues.oasis-open.org/browse/ODATA-1393 to track and repair it.

@sthagen Please review https://github.com/oasis-tcs/odata-abnf/pull/27/files

I switched to the oasis-tcs/odata-abnf variants of ABNF grammar and test cases (the test cases are not yet synchronized across formats)

Propose to close this issue. Thank you @ralfhandl for the fast upstream handling of the issue.

PR now uses [ "-" ].


Add ability to provide TagHelper delimited attribute values.

We currently have several TagHelpers that require some sort of delimited attribute value. Such as <environment names="a, b, c">, <a ... vary-by-route="a, b, c">, etc. This leads to a lot of duplicate code where we do attributeValue.Split(...).Select(v => v.Trim().Where(v => v.Length > 0). Not to mention doing all this results in several allocations that aren't very friendly to perf (especially when we could optimize it at compile time).

Note: We'd somehow have to limit this capability to only raw strings. Not ones returned via @value

Closing, we have no plans to do this.


Failed

Failed:

originally:

It states in the readme that this library, and especially the sample project, is not the navigation demo, but it's the code that the navigation demo is built on. Navigation demo does have some maps and navigation-related features, which we're currently adding to the library.


Parallel actor creation can deadlock or crash riker

While implementing one of the benchmarks from actor-framework/benchmarks, I found out that riker sometims deadlocks (hangs) or crashes with an access violation when multiple actors get created simultaneously.
I created a minimal example at my test repo.
The problem seems to be an atomic_load in dashmap, but I'm not sure if this is a bug in dashmap or just misuse on our side.

Tested on:

Windows 10 (stable-x86_64-pc-windows-msvc 1.44.1)
Ubuntu 20.04 LTS (stable-x86_64-unknown-linux-gnu 1.44.1)

Additional files:
stacktrace.txt

@xacrimon I wonder if you're able to provide some insight into this?

Known bug in rc5, updating to rc6 should solve the issue.

I think I tested with RC6 too. I will retry with an updated version of dashmap and report my findings.

This is interesting, it hasn't shown up in any of the intensive multicore tests I've done.

I locally changed the version to rc6 and the problem still persists:
build_and_run.txt

I will investigate this issue. Thanks

So I got the issue. I am currently doing a major refactor that will fix this but in the meantime switching to dashmap 3.11 should do the trick.

There are some incompatible changes between 4.0 and 3.11; Iter needs more type parameters in 3.11 and the replace method doesn't exist. I looked at replacements (e.g.: delete and insert) but the documented locking behaviour doesn't seem to be a good fit riker.


upgrade instructions for PR 2453

Reference Issues or PRs
This is a companion PR to https://github.com/nebari-dev/nebari/pull/2453.  B/c we don't yet know for sure the next version of Nebari will be 2024.5.2, I've added this PR to be corrected and merged shortly before the next release of Nebari.

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

@marcelovilla I'm fine with the updates!

@Adam-D-Lewis @marcelovilla any updates on this? can we commit these suggestion and re-test?

@viniciusdc I just commited the suggestions. I was hoping to use this PR to include the instructions for upgrading Grafana as well but we can split it in multiple PRs if it makes more sense. Anyway, this should be included in the official release but not necessarily on the RCs, right?

I'm merging this in order to release a candidate that includes the upgrade step for the GCP default nodes. Once https://github.com/nebari-dev/nebari/pull/2472 is merged, I'll open a PR updating the step with relevant information about the actions that need to be taken.


Update h5io to 0.2.4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.378%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
554

Relevant Lines:
587

💛  - Coveralls


Mysql Backup fail

when i run make mysql-backup i have this error :
Found Makefile directory: /home/vagrant/projects/drupal8
 * Starting MySQL backup...
mysqldump: Got error: 2002: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) when trying to connect
Makefile:41: recipe for target 'mysql-backup' failed
make: *** [mysql-backup] Error 2

  [CliTools\Exception\CommandExecutionException]
  Process make did not finished successfully

make

a solution to fix it, is to udpdate the bin/backup.sh to add user, host and password :
dockerExec  mysqldump -h mysql -u dev -pdev database --opt --single-transaction --events --routines --comments

or add my.cnf

I'm facing the same issue (with https://github.com/webdevops/TYPO3-docker-boilerplate/). But I think the source of the problem is the same:
There is a template file for the mysql config file 'my.cnf' which sets default values for connection, so that host/user/passwd can be omitted when using mysql client or mysqldump. But it seems that this file isn't provisioned at any time, so the default values are not set. This is why the connection without any parameters fails.
I'm sure this once worked well but may get lost somewhen (I saw some refactoring commits in october 2015..).

Problem is the same for mysql restore..

hi @tbal,
they are a PR #54 to fix it. Please, wait that it's merge by @mblaschke


Mixing No-Intro and TOSEC Dats - GetDuplicates not working

I did not check, if this is general or only these special files, that wont combine.
Not really a big problem, so lets check later.
#Sinclair ZX Spectrum - Applications - [$B] (TOSEC-v2011-09-24_CM).txt
#Sinclair - ZX Spectrum +3 (20161210-235900).txt

That are only some files. Most are working together without problems.

found a not working line with only crc
	<game name="Aliex (Europe) (Trojan Phazer Required)"> 		<description>Aliex (Europe) (Trojan Phazer Required)</description> 		<rom name="Aliex (Europe) (Trojan Phazer Required).ipf" size="1049612" crc="3DE810FB"/> 	</game>
working lines with crc, md5 and sha1
	<game name="Alpha Waves (Europe) (En,Fr,De,Es,It)"> 		<description>Alpha Waves (Europe) (En,Fr,De,Es,It)</description> 		<rom name="Alpha Waves (Europe) (En,Fr,De,Es,It).ipf" size="1049612" crc="CEB5E6A4" md5="03F8F12B19BCB860B81F78CAC008C30B" sha1="929380AD7F6C560A487E8302EE1A32F6AD464199"/> 	</game>