[analyzer] Not quite correct error message in case of constant eavluation and operator +

Now we have the following error
class C {
  final String value;
  const C(this.value);

  String operator+(String other) => value + other;
}

void main() {
  const c1 = "a" + "b";

  const c2 = C("a") + "b"; // Error. In constant expressions, operands of this operator must be of type 'num'.
}

In case of + operator the error message should be like In constant expressions, operands of this operator must be of type 'num' or 'String'.
Tested on Dart SDK version: 3.4.0-edge.89bd370e95c0695250a4f0111be3134b9936eadd (main) (Thu Jan 11 03:53:48 2024 +0000) on "linux_x64"

Right. One more thing, though: the receiver could also be an expression whose static type is an extension type that implements num, String, or a subtype thereof.
extension type const E(int it) implements int {
  String operator -(int other) => (it - 2*other).toString();
}

void main() {
  const int c1 = E(2) + 1; // OK.
  const String c2 = E(2) - 1; // Error, not an instance operator.
  String v = const E(2) - 1; // OK.
}

We should get an error for c2 because it will invoke the extension type operator E.- (and constant expression evaluation cannot invoke user-written code), but v is OK.
It might still be fine to talk about num (and String) because E is actually a subtype of num, but I'd recommend that the error message does mention the fact that E(2) - 1 will invoke an extension type instance operator, not an instance operator (that is, the kind that a class/mixin/etc declares, which is subject to late binding at run time).

@kallentu Just FYI

Good catch, @eernstg . Your issue(s) are resolved currently; I believe fixed with https://github.com/dart-lang/sdk/commit/7965219df26fec9cab4c79d0659a4a30f74b2f20. The main issue at top is still an issue.


:bug: add logger namechecker and empty headers to debug the issue

It is not working in prod and this PR is for debug purposes.

:tada: This PR is included in version 1.3.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Updates to config variable

Sharing a few things I had to change to make this example run without errors.
These are the errors I got initially:
Call stack:
File ".\mysql_intro.py", line 10, in <module>
'client_flags': [ClientFlag.SSL],
NameError: name 'ClientFlag' is not defined

--------------------
(After resolving line 10)
AttributeError: ssl_key and ssl_cert need to be both specified, or neither.
(This was resolved by renaming this attribute to ssl_ca)

@paladique : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @paladique for reporting this issue and proposing an edit. I have approved the change

#sign-off


Kubernetes docs don't describe how to work with services

File: docker-for-mac/kubernetes.md
From reading blog posts and digging around, it seems that LoadBalancer services are proxied to localhost, but this isn't documented here, and it's not working for me, so I'm not sure if I'm missing something.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


s3ql: 3.7.2 -> 3.7.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for s3ql is: "A full-featured file system for online data storage"
meta.homepage for s3ql is: "https://github.com/s3ql/s3ql/"
meta.changelog for s3ql is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/fsck.s3ql passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/mkfs.s3ql passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/mount.s3ql passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3ql_oauth_client passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3ql_verify passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3qladm passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3qlcp passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3qlctrl passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3qllock passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3qlrm passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/s3qlstat passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/umount.s3ql passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.fsck.s3ql-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.mkfs.s3ql-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.mount.s3ql-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3ql_oauth_client-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3ql_verify-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3qladm-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3qlcp-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3qlctrl-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3qllock-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3qlrm-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.s3qlstat-wrapped passed the binary check.

/nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin/.umount.s3ql-wrapped passed the binary check.

24 of 24 passed binary check by having a zero exit code.

24 of 24 passed binary check by having the new version present in output.

found 3.7.3 with grep in /nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3

found 3.7.3 in filename of file in /nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3

directory tree listing: https://gist.github.com/df5192a40d8a07197442e96d8ec335c3

du listing: https://gist.github.com/21355cd3e504e69fc3f5978a3f4f65a1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
s3ql

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A s3ql https://github.com/r-ryantm/nixpkgs/archive/7bec753807d1de28608e0274b0fb699910f74c75.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3
ls -la /nix/store/aw20njfa3s0333a5p4r6zsdbs2m4jq00-s3ql-3.7.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

s3ql

Maintainer pings
cc @rushmorem for testing.

Result of nixpkgs-review pr 134550 run on x86_64-linux 1

1 package built:

s3ql


How to display current-location to input text ?

hy allen, your library is amazing. but, How to display current-location to input text ? thanks.

It's out of scope. You can use callback
https://github.com/allenhwkim/angularjs-google-maps/blob/master/directives/map.js#L15


OCS UND 12 Year Hindcast

#Welcome to the IOOS Cloud-Sandbox!
Expected Behavior
Run the 12 year Hindcast for OCS
Possible Solution
[] Install Globus on headnode to populate input data onto shared disk
[] Catalog and obtain input data
[] Week long run for Benchmarking
[] Start run and periodic updates
Context
Primary Contact is Saeed Moghimi
Environment
NOAA Coastal Sandbox

For Globus Reference:
https://docs.globus.org/globus-connect-server/v5.4/

@ZacharyWills I just noticed that you mentioned installing Globus in this issue. I created another one specfically for that but maybe we can delete that one and keep the conversation as part of this issue. If so let me know and I'll try to remove the issue or close it.


Fill out DC region map, add Tokyo 2 IPv4 resolvers

Also fixes a couple Frankfurt typos. Still need the IPv6ns stuff in there.

Looks good, thanks for submitting this!

Coverage remained the same at 86.41% when pulling ba013f9a4bd5432b283f05153bd6c091e947435c on rmcintosh:patch-3 into cb895ca757f85f55192b0fcd8f5df6a519e3e3ea on linode:master.

Coverage remained the same at 86.41% when pulling ba013f9a4bd5432b283f05153bd6c091e947435c on rmcintosh:patch-3 into cb895ca757f85f55192b0fcd8f5df6a519e3e3ea on linode:master.


Clarification to "Can I open encrypted messages sent to another user's mailbox with Fullaccess?"

In the entry for "Can I open encrypted messages sent to another user's mailbox with Fullaccess?" it basically says that it should not be possible to open an encrypted mail with fullaccess permissions to the mailbox if the permission is assigned using a mail-enabled security group.
According to our tests this seems to not hold true if the access is through Outlook on the Web (or OWA in legacy terms). I think it would be a good idea to mention this in the FAQ entry. Probably after verifying my statement.
Cheers,
Christoph

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e2a02f3-0560-f5c7-9743-d7e65ad5d1a4
Version Independent ID: 0382d4b5-3fe2-f353-ce73-5d437d80b7bf
Content: Message Encryption FAQ
Content Source: microsoft-365/compliance/ome-faq.yml
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

@ccwb-102 Thank you for your feedback. I tested and it works in OWA, For outlook, you need the automapping to be turned ON. I have updated the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/5283
Thanks
Sri

@KCCross PR merge request pending. Thanks

@msbemba Thank you very much for the contribution and updating the documentation with PR. @ccwb-102 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


added support for jacoco code coverage in jenkins

this adds support for code coverage using jacoco in jenkins (and also refactors some of the common request handling into it's own function).
at this time, i don't know of any public jenkins installations that have a jacoco job, image is generated using the cobertura link but is listed as the jacoco link.

Hi, thanks for this contribution. There's quite a backlog of PRs we're working through. Sorry it's taken so long to respond.
Would you be willing to add tests for the affected badges, using the project's new testing framework?

If anyone would like to adopt this PR, please feel free to do so: grab the branch, add more commits addressing the comments, and open a new PR referencing this one.

it's highly irritating that i did this work, the PR languished, and then someone else came in and did work after this was submitted and was approved before this was even looked at.
what's to say that i don't take the time to do this over and then it sits again for however long?

I can tell you're frustrated. I'm confused, though. I read this back in April and left comments. If you'd like to address them, feel free. If you want to cut your losses, I understand. If this work was merged elsewhere I don't see it.

to clarify, someone else submitted a jenkins pr after me that was merged and threw this out of whack.
i realize you commented in april, unfortunately i haven’t had the time to revisit this but i’ll see about making some.


missing support for some filetypes

iam relly missing support for certain filetypes, like cshtml, aspx, ascx, and asp
Can you like force lets say .asp page to use html as formatter?
html dosent really work when your doing html-templates under  script-element

otherwise love the extension good work!

like this you can add any syntax in any formatter
https://github.com/akalongman/sublimetext-codeformatter/issues/43#issuecomment-194387767


Use narwhals to support Polars, cuDF, Modin, etc.

Checklist

[ ] Added a CHANGELOG.rst entry

I think this will raise an exception if neither pandas nor polars is installed (which is now a posibility): https://github.com/Quantco/tabmat/blob/e288b47bfbf04c92ce824008f0cf615d32bcbad7/src/tabmat/categorical_matrix.py#L249-L250
We could replace it with some numpy-based solution, which is probably not very efficient, but that's probably fine for now. E.g.,
    else:
        categories, indices = np.unique(cat_vec.to_numpy())

Same here, but the solution might be less straightforward for the non-pandas-or-polars case:
https://github.com/Quantco/tabmat/blob/e288b47bfbf04c92ce824008f0cf615d32bcbad7/src/tabmat/categorical_matrix.py#L391
Maybe we could say that the property is deprecated and is only there for backwards compatibility, so we are not implementing it for non-pandas (or polars) input?

I don't think we need this: anymore https://github.com/Quantco/tabmat/blob/e288b47bfbf04c92ce824008f0cf615d32bcbad7/src/tabmat/constructor.py#L21-L24

I made the following updates to fix the issues above:
Deconstructing the cat argument of CatagoricalMatrix.__init__:

When the constructor of CategoricalMatrix gets a pandas or polars input, it uses @lbittarello's solution
In any other case, it uses a pure numpy fallback. It is necessary as we cannot assume that pandas will be available. It is not super efficient when the input is already a (e.g. pyarrow) categorical, as we convert it into a string vector, then reconstruct the incdices/categories representation again. However, narwhals does not have a way to access the underlying representation of a categorical, and I'm not too keen on adding more custom cases besides pandas and polars.

The cat property

When the CategoricalMatrix was created based on a series that narwhals supports, use narwhals.new_series to create a categorical series of the same type. Special case pandas for performance reasons and differing behavior, as before.
When the CategoricalMatrix is created from a list, numpy array or similar, just return a dictionary with indices and categories. We cannot return a categorical as it is not guaranteed that any dataframe library is available.
As @lbittarello mentioned in the discussion of #370, cat is deprecated anyways, so it is just a temporary solution, and the extra complexity can be removed when we release the next major version.

@MarcAntoineSchmidtQC, if we don't want to add new functionality to the deprecated cat property then let me know and I'll remove that part. I think the more important addition is handling non-pandas-or-polars categoricals when constructing the CategoricalMatrix, which is an orthogonal issue.

Perhaps one final question: all three matrix types have an unpack method that returns the container storing the data. For CategoricalMatrix it used to be a pandas.Categorical, so it simply returned .cat(). We should probably either deprecate this function for the CategoricalMatrix class or show a FutureWarning and from the next breaking release return (indices, categories) instead.

Thanks so much for the review and the fantastic library @MarcoGorelli! 🙏 Using the v1 API is a great idea. The only thing I ran into is that there does not seem to be a narwhals.stable.v1.dtypes.NumericType counterpart to narwhals.dtypes.NumericType. Is there an easy way to refer to any numeric type under the v1 API?


Refinement and elaboration of V types

😎

[x] refinement rule for V type code
[ ] refinement rule for V type intro
[ ] refinement rule for V type elim
[x] elaboration of V type code
[ ] elaboration of V intro
[ ] elaboration of V elim

OMG this looks much more Immortal now!


Set Ansible host key checking to false by default in run_project.sh t…

…o avoid making deployments unexpectedly interactive
Signed-off-by: Daniel Chaffelson<EMAIL_ADDRESS>

@wmudge per our other discussion, I suggest we then use this quickstart.sh as the 'beginners entrypoint' and confer on how to create a 'power user entrypoint' with the discussed stronger security posture in some additional approach.

This has been put into cloudera-deploy which is sufficient until we rework the quickstart


Single-threaded recovery example fails

It fails to recover keys after ~300000. Not sure why.

Do you have a failing code snippet?

It is in the example code. During recovery.
https://github.com/Max-Meldrum/faster-rs/blob/master/example/src/main.rs
But should probably check that it can find all the inserted values directly after populate.

I've played around with this a lot today.

First I verified that values inserted properly after populate, which was fine.
Then I modified the test to be closer to what is being done in sum_store but still it didn't work
I tried debugging the C and found something interesting.

When I run Microsoft's implementation I get output like:
Thread 0 reports persistence until 10544640
Calling Checkpoint(), token = bfeb4546-953e-4035-851c-48d61b6890a4
Thread 0 reports persistence until 11593216
Calling Checkpoint(), token = c9f55bca-4337-4f31-a4ac-7f11319d2523
Thread 0 reports persistence until 12641792
Calling Checkpoint(), token = c05b3625-0d41-46ab-bcca-9167ed48e2e0
Thread 0 reports persistence until 13690368
Calling Checkpoint(), token = dd4195e8-aae8-4259-abc2-40c71ef659ea
Thread 0 reports persistence until 14738944
Calling Checkpoint(), token = d1e0a299-1d13-4c2f-a573-29aacf40a409
Thread 0 reports persistence until 15787520
Calling Checkpoint(), token = 580395e7-2236-4a5c-bd5e-c5e0e393bcf4
Thread 0 reports persistence until 16836096
Calling Checkpoint(), token = 0831a986-f63e-452f-b07d-2b63c9bf0115
Thread 0 reports persistence until 17884672
Calling Checkpoint(), token = 1ba5e10c-86bc-4ea0-bafc-1f9c3ccfbed0
Thread 0 reports persistence until 18933248
Calling Checkpoint(), token = 2f5ee46b-be64-45b1-a7fe-44fcaa0d1994
Thread 0 reports persistence until 19981824
Calling Checkpoint(), token = b73022e3-61f2-4004-9961-4363b785ffc1
Thread 0 reports persistence until 21030400
Calling Checkpoint(), token = d4fb9a67-9ee0-451d-8678-126df1dac749
Thread 0 reports persistence until 22078976
Calling Checkpoint(), token = 9025b1ae-ea5d-4f99-9597-d33305ce7db0
Thread 0 reports persistence until 23127552
Calling Checkpoint(), token = a25e6b69-5826-4c91-bfc3-c6584846de2c
Thread 0 reports persistence until 24176128
Calling Checkpoint(), token = 00055946-12f7-4c87-ab5c-2ce1e484755c
Thread 0 reports persistence until 25224704
Calling Checkpoint(), token = a7ac8ff1-7ac0-4035-8661-c8b346e8d59a
Thread 0 reports persistence until 26273280
Calling Checkpoint(), token = c1cb0ea0-f64b-4bbb-938b-bd0321f7379f
Thread 0 reports persistence until 27321856
Calling Checkpoint(), token = a004afae-5777-4727-93e2-ef404ef4db52
Thread 0 reports persistence until 28370432
Calling Checkpoint(), token = 0ee9aec8-4f18-416f-88ff-5c5d9ab63e5a
Thread 0 reports persistence until 29419008
Calling Checkpoint(), token = 9c0682ab-c3bf-413f-974c-0fe0e3e3df72
Thread 0 reports persistence until 30467584
Calling Checkpoint(), token = 012389ca-cbcb-4e21-b7a6-6b874eeaf474
Thread 0 reports persistence until 31516160
Calling Checkpoint(), token = ed83edef-1637-40d3-8026-1acf1d2c7f2d
Thread 0 reports persistence until 32564736

However when I add a printf() for the persistence callback here I get output like this:
Starting Session 39907f04-209b-4e4a-9a45-1b380ad1e744
Calling checkpoint with token c4797963-3b1c-4373-9524-535ab60bdea5
Persistence reported until 1
Calling checkpoint with token cf040160-ea80-488c-b04b-c4b87a45ba07
Persistence reported until 1
Calling checkpoint with token 4c43cf39-d8a5-43f6-914e-0673d98ab47f
Persistence reported until 1
Calling checkpoint with token f8d1e3ee-5090-43b4-9e2c-856b38b777e5
Persistence reported until 1
Calling checkpoint with token b09ab4f8-59f0-42f0-9701-836b6548dfee
Persistence reported until 1
Calling checkpoint with token d865b123-d32f-4da5-9f87-9f66c05d7764
Persistence reported until 1
Calling checkpoint with token 577e88d3-b047-46d8-814b-0fbe6c2f1b01

So clearly there's something going on which is preventing FASTER from advancing its epochs and assuring the thread that data is persisted to a certain point.

Good catch. I wonder if it is because threads are switching from Rust to C. If they actual do that, but seems like it according to https://doc.rust-lang.org/1.30.0/book/first-edition/ffi.html
"in the previously given examples the callbacks are invoked as a direct reaction to a function call to the external C library. The control over the current thread is switched from Rust to C to Rust for the execution of the callback, but in the end the callback is executed on the same thread that called the function which triggered the callback."

Hey, so I managed to get to the bottom of this and there are two PRs to solve this #10 and https://github.com/Max-Meldrum/FASTER/pull/6
The issue is basically with how FASTER works for Concurrent Prefix Recovery. Every operation requires a monotonic serial number for ordering the operation sequence and we were just always setting this number to 1. This is why it says "Persisted until 1" in the snippet above.
I thought long and hard about the best way to abstract this from the user but decided it's actually better to let the user be in control just as the authors of FASTER intended.

Nice! Yeah, I agree with the approach too.


Download files rather than zips

This change will cause the app to download the files directly, rather than downloading zip archives. I was experiencing a bug in api.gopro.com where video files were not included in the zip archive. For this reason, I decided it's better to just download each media file individually. The zip compression wasn't doing much for us anyway, as the files were already compressed.
I also added an option to upload the files to S3 as they are downloaded by using --action download-upload. There are additional environment variables needed for this, as documented in the README file.
These changes are based on what I found here.
This worked well for me to extract all my media from GoPro plus and upload it to BackBlaze. The GoPro api was flakey on downloading files. I used the --action list to produce a list of pages with each media file. When there was a failure, I would look at what page the media file was on at the time of failure and restart the process using --start-page <page>, passing in the appropriate start page.
This changes also sets the file created date to the captured date value from GoPro media metadata.
This closes #1

hey @robandpdx does this still work for you? I just came here to try this solution for the first time, but the AUTH_TOKEN doesn't work anymore, and I'm looking for a way to get all my files, with the right metadata, and haven't found anything that is currently working.

hey @robandpdx does this still work for you? I just came here to try this solution for the first time, but the AUTH_TOKEN doesn't work anymore, and I'm looking for a way to get all my files, with the right metadata, and haven't found anything that is currently working.

@micah I would recommend using my fork of this project here.


this is a test issue

As there is no work to be done regarding this issue I am closing it.  Thanks.


[RFC] build: run kernel checkpatch.pl on diff for bpf/ in precheck

Although there is no explicit coding style for the BPF code, several developers tend to follow the kernel coding style conventions. To try and maintain a consistent style all over the code, this commit adds kernel checkpatch.pl to the list of checks performed on the source as part as make precheck.
Some details on the check:

We only run checkpatch.pl on the bpf/ directory.

We make it part of make precheck, so it runs for all builds.

However we only run it on the latest changes, meaning the changes   returned by git diff HEAD. This means that checkpatch.pl will not receive any input if the user (or CI system) has made no change since last commit, in particular there will be no check if a user commit their changes before building. And there is no check enforced on the pull requests.

Hooking checkpatch.pl for all PRs could be done in the future, if there is sufficient interest in it.

The checkpatch.pl and spelling.txt files (both under GPLv2) are directly copied from the kernel repository, as per commit 4efc61c798cd ("scripts/spelling.txt: add "issus" typo"). File const_structs.checkpatch is not used in our case, but is created blank to avoid a warning message from checkpatch.pl. The script checkpatch.sh (bash script) launches checkpatch.pl with the relevant arguments and options.

test-me-please

test-me-please

The checkpatch.pl and spelling.txt files (both under GPLv2) are directly copied from the kernel repository, as per commit 4efc61c798cd ("scripts/spelling.txt: add "issus" typo").

Don't we also need to have a COPYING file to explicitly state the license (as in the bpf/ directory)? I don't think SPDX comments are enough.

Hooking checkpatch.pl for all PRs could be done in the future

Did you try that? How bad is it? :worried:

The checkpatch.pl and spelling.txt files (both under GPLv2) are directly copied from the kernel repository, as per commit 4efc61c798cd ("scripts/spelling.txt: add "issus" typo").

Don't we also need to have a COPYING file to explicitly state the license (as in the bpf/ directory)? I don't think SPDX comments are enough.

I don't know, but no harm in adding the file. Will do.

Hooking checkpatch.pl for all PRs could be done in the future

Did you try that? How bad is it? worried

For all new PRs I meant. For current code base:
find bpf -regex ".*.\(c\|h\)" -print0 | xargs -0 checkpatch.pl --no-tree --strict -f

ERROR: 315
WARNING: 4484
CHECK: 687

Have you also tried sparse and cppcheck and the like to integrate as precheck? Would be nice to have. :-)

Have you also tried sparse and cppcheck and the like to integrate as precheck? Would be nice to have. :-)

I have not (I didn't know how checkpatch would be received), but could do as a follow-up.
Which one do you have in mind for “the like”?

sparse
cppcheck
xmastree.py
... [feel free to edit]

test-me-please

Have you also tried sparse and cppcheck and the like to integrate as precheck? Would be nice to have. :-)

I have not (I didn't know how checkpatch would be received), but could do as a follow-up.
Which one do you have in mind for “the like”?

sparse
cppcheck
xmastree.py
... [feel free to edit]

I personally don't care too much about xmastree, but we once had discussed coccinelle tool which could then also run against all scripts in https://github.com/cilium/cilium/tree/master/contrib/coccinelle . Latter we can then extend over time with more useful things to catch for BPF code base. So I'd be happy for everything that would help us find potential bugs.

Coverage decreased (-0.02%) to 46.813% when pulling 271793e447098869331451b35f0349a27010aa9b on pr/qmonnet/checkpatch_bpf into 9fbd82092def7ced2d520408435f61d6f6408848 on master.

However we only run it on the latest changes, meaning the changes returned by git diff HEAD. This means that checkpatch.pl will not receive any input if the user (or CI system) has made no change since last commit, in particular there will be no check if a user commit their changes before building. And there is no check enforced on the pull requests.

I wonder if we could figure out a way to run these on commits in PRs as well. A bit trickier but the weakness of the current approach is it forces developers to perform these make checks before making their commits. If developers don't do this because their workflow doesn't involve such a step,  or because they hack up several intermediate commits before rebasing & cleaning up, then these checks would be missed entirely.
One potential way would be to define an env variable for the git object in the git diff HEAD command, with HEAD as the default. That way, I could export BPF_CHECK_GITREF=upstream/master and the checks would be run against the diff between my current tree and the remote branch master on the remote upstream. Maybe in CI we set this to origin/master and make sure the remote origin is in sync with the latest git branch so that this command is effective.

I had missed the make check in Makefile.bpf.
check:
	@$(ECHO_CHECK)/*.c
	$(QUIET) spatch --sp-file $(ROOT_DIR)/contrib/coccinelle/null.cocci --dir . --include-headers
	$(QUIET) sparse -Wsparse-all ${FLAGS} $(ROOT_DIR)/$(RELATIVE_DIR)/*.c
	$(QUIET) $(CLANG) ${CLANG_FLAGS} --analyze $(ROOT_DIR)/$(RELATIVE_DIR)/*.c
	$(QUIET) $(foreach SUBDIR,$(SUBDIRS), \

So we already have the “infra” to call sparse and cocci patches. I tried make check and it works well indeed. Sparse complains a lot, spatch does nearly nothing at the moment. We could either try to fix the sparse warnings, or count them and make sure we don't add new ones.
@joestringer because I had not seen the make check in bpf, I run checkpatch from make precheck in main Makefile. So developers might still miss it if they commit first, but it is called from the all target and should be run each time we call make. A majority of developers should compile their code before committing [citation needed].
But it's true, it would be nice to have checkpatch and make check run for each PR. I've seen checkpatch called from “pre-receive” git hooks before, but I think only Enterprise GitHub have these. We could indeed check against a configurable variable that would default to origin/master, and find something that works for the CI. I can change my PR to run against the remote branch, at least locally.
Questions:

Should we call make check from Makefile.bpf as a dependency to make precheck from main Makefile, or find a similar way to run the checks each time we build? Or do we prefer to run them explicitly?

If we call it for each PR and especially in the CI, what do we consider as blocking? Is a checkpatch error a reason to fail the tests? What about a sparse warning? Etc. We would likely need a way to bypass checks for false positives. Also one consideration is that sparce / spatch / cppcheck all require additional software to be installed on the system. Not a problem for us, but this might make it harder for new/occasional contributors if we make those tests blocking for a merge.

. So developers might still miss it if they commit first, but it is called from the all target and should be run each time we call make. A majority of developers should compile their code before committing [citation needed]

I frequently make a series of commits, then find issues and write fixup patches to amend the earlier commits in the series. My workflow tends to involve something like:
<edit>
$ make -C daemon
$ make reload
<test/validate>
$ git commit --fixup $old_commit_sha
$ git rebase -i upstream/master

or
<edit>
$ make microk8s
$ kubectl -n kube-system delete po -l k8s-app=cilium
<test>
$ git commit ...

This kind of workflow necessitates a separate later step to make to actually run the various checks regardless of what's currently uncommited. Indeed I'll often fix these up and commit in the same manner. The make at the end is also something super easy to miss, which I would hope is picked up early by CI so that it doesn't waste a bunch of time validating the changes when I'll have to fix up some minor things and resubmit anyway. (This is largely the case already today with the jenkins-precheck target).

Should we call make check from Makefile.bpf as a dependency to make precheck from main Makefile, or find a similar way to run the checks each time we build? Or do we prefer to run them explicitly?

I don't mind them being part of the main check as long as they're clean. I rarely run the checks under bpf/ and part of that is because the (eg sparse) targets have so many complaints; I don't know where to start and I don't know that my changes are related.

If we call it for each PR and especially in the CI, what do we consider as blocking? Is a checkpatch error a reason to fail the tests? What about a sparse warning? Etc. We would likely need a way to bypass checks for false positives. Also one consideration is that sparce / spatch / cppcheck all require additional software to be installed on the system. Not a problem for us, but this might make it harder for new/occasional contributors if we make those tests blocking for a merge.

All good points. My general stance is that if we don't make something blocking, then developers will ignore it. Exhibit A: sparse :-) That's why I tend to advocate all of the go vet, etc. stuff in the main make (check) target. These things do make setting up the dev env more complicated though. One way to mitigate this is to set up docker containers with all of the dev dependencies and using those containers to perform the build. Might be an option if we're worried about that. For docs we're already assuming docker (or another container runtime engine) is already available.


NPM Inject-Loader

Have you ever used inject-loader (https://www.npmjs.com/package/inject-loader) in your slingshot?  We are able to get the examples to work on inject-loaders page but running the same commands and code in Slingshot generates errors. I have asked for suggestions from the inject-loader project but the only feedback I have heard so far is that it may have something to do with webpack.  Thanks for any thoughts.
Node version: v7.7.4
npm version: v4.1.2
Operating system: Windows 10 Pro
Command line used: npm install --save-dev inject-loader
Steps to reproduce:
Within a spec.js file -
Error #1 -
const EnsureLoggedInInjector = require("inject-loader!EnsureLoggedIn"); // error returns cannot found module
Error #2 -
const EnsureLoggedInInjector = require("inject-loader!./../../src/containers/EnsureLoggedIn"); // this finds the module
let EnsureLoggedIn = EnsureLoggedInInjector({
"react-router": {
browserHistory: {
replace: browserStub
}
}
}).EnsureLoggedIn;  // but this generates an error that EnsureLoggedInInjector is not a function

@sgriffin916 I'm assuming you're using this to mock something in a unit test? Do you have a repository with react-slingshot and inject-loader on GitHub that we can look at? Also, react-slingshot uses jest now. Have you looked at the jest docs for mocking?

I ended up getting it to work using sinon.stub().  Thanks for getting back with me.

Np and glad you're all good to go.


sd_setImageWithURL - no Image

Issue Info
Platform Name           | ios
Platform Version        | 10.0
SDWebImage Version      | e.g. 3.8.1
Integration Method      | manually
Xcode Version           | e.g. Xcode 8.0
Repro rate              | all the time (100%)
Issue Description and Steps
Facing problem to set image from URL.  Everything works fine on older iOS versions (just iOS10).
// SDWebImage 3.8.2 - not working
//[cell.cover sd_setImageWithURL:[NSURL URLWithString:imageURLString] placeholderImage:[UIImage imageNamed:@"BookDefault"]];
// Test - works fine
dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^(void){
//Background Thread
[cell.cover setImage:[UIImage imageWithCIImage:[CIImage imageWithContentsOfURL:[NSURL URLWithString:imageURLString]]]];
dispatch_async(dispatch_get_main_queue(), ^(void){
//Run UI Updates
[cell.cover setNeedsDisplay];
});
});

can you replicate in the demo project?

Not tested with Demo project. Just tested with new clean project and random image url from web. Same results, everything works fine in iOS8 and iOS9, in iOS10 image not set, at least does not shows up in imageView.
p.s. getting same results with UIKit+AFNetworking setImageWithURL

Transport Security has blocked a cleartext HTTP (http://) resource load since it is insecure.

👍


Additional Pharmacogenes

Is there a way to add more pharmacogenes to this script if needed? Or is there a scientific limitation to what the script is able interpret?

Hi @labdyn,
You can certainly add new genes to PyPGx. See #39 as an example. Adding a new gene is mostly just updating the existing tables (e.g. allele-table.csv). Which gene(s) are you looking at? I'd be more than happy to assist you in this regard. Let me know.

Closed due to inactivity. Please feel free to re-open it if necessary.


[question] linq_aggregate API to avoid boxing?

Are you planning to add linq_aggregate API for primitive types?
    NSNumber* totalCount = [shoppingCart linq_aggregate: ^NSNumber*(id<MyCommodity> item, NSNumber* aggregate)
    {
        NSNumber* orderedItemsCount = [item numberOfOrders];
        NSUInteger newResult = [orderedItemsCount unsignedIntegerValue] + [aggregate unsignedIntegerValue];

        return @(newResult);
    }];

In this example there is a lot of boxing/unboxing (NSNumber ==> NSUInteger ==> NSNumber) which is a good thing to avoid.
P.S. I know that integers can be "safely" casted to id. But I strongly dislike this approach. Moreover, it does not work for [NSNumber floatValue].

Note : the code example above crashes since aggregate has an unexpected type.
        if (aggregate == nil) {
            aggregate = item;
        }

Why are you checking this condition and assigning a wrong object?
If linq_aggregate is supposed to produce an object or the same type as array elements, please document it explicitly.

NSArray* names = @[@"bill", @"bob", @"brian"];

id aggregate = [names linq_aggregate:^id(id item, id aggregate) {
    return [NSString stringWithFormat:@"%@, %@", aggregate, item];
}];

Eventually, the fix will break the code in the readme and the user will have to handle aggregate == nil situation properly.

@ColinEberhardt I've removed the mentioned check in a patch https://github.com/ColinEberhardt/LinqToObjectiveC/pull/13
Please let me know if you find a better approach for my use case.


goog.ui.LabelInput don't display label after reset form in IE browsers

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=520

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


Replace SetupTestInput methods with test suits

Looking at the Cosmos SDK codebase it looks like they've swapped all the SetupTestInput methods for easier-to-understand testify.Suite implementations.
I think we should adopt the same strategy, making the tests easier to setup and maintain.

I will take a look at it soon!

I will take a look at it soon!

Don't rush it, I would target it for v0.9.0, focusing on closing v0.8.0 first.


[dart2wasm] Provide an escape hatch to users to avoid implicit conversions.

Is this a language issue, or is it asking for a dart2wasm-specific API?

This should be working now, we skip conversions for subtypes of JS types, i.e. static interop objects.


Sticky: Poll: What do you want to see in Zenbot 3.6?

Greetings Zenbot users!
After a gazillion commits over the weekend Zenbot 3.5.x is fairly stable now. However there's much more Zenbot is capable of, and only so much time to implement it. I need help prioritizing!

[x] Auto-learn engine, to mutate trade params on the fly, simulate in parallel, and hot-reload better params into the runner?
[x] Simulation with date ranges?
[x] Generic default_trade.js usable with any exchange?
[x] Composable JSON configuration?
[x] More exchanges?
[x] Better support for EUR trading and other currencies
[x] Web UI for bot status or control?
[x] Email or text message on trade execution?
[x] New indicators such as MACD?
[x] Repair tool for backfilled data
[ ] Improve the ROI for BTC?
[ ] Improve the ROI for ETH?
[ ] More altcoins support?
[ ] Twitter integration?
[ ] Performance?
[ ] Documentation or guides?
[ ] How-to videos?
[ ] More "hint" or "help" notifications when executing commands?
[ ] man page?
[ ] Online docs for Zenbrain engine and API?
[ ] Online docs for writing plugins?
[ ] Example apps using Zenbrain for other purposes? (I have a web crawler and twitter bot built on earlier versions of Zenbrain)
[ ] Backup or maintenance scripts?
[ ] Additional commands? Utilities?
[ ] Dockerfile?

Please comment below with what features you'd like to see in the next release, 3.6.0.
Cheers,
Carlos

Exchange indipendent logic/strategy

Simulation with data ranges

Composable JSON configuration

Auto-learn engine, to mutate trade params on the fly, simulate in parallel, and hot-reload better params into the runner

If it works properly, this would be amazing to have.

Definitely this:
Auto-learn engine, to mutate trade params on the fly, simulate in parallel, and hot-reload better params into the runner?
I know this is a bit of specific request, but if I wanted to run this on multiple markets on the same exchange, I would set the trade amount to: default trade amount/number of markets. I.e. 3 markets, trade 0.3 of my total each time. This would be to make sure there is enough money in the bank for every market. But this would only work if there were no double buy/sell signals on any single market. This is something I think deserves looking into.
More markets, more trading opportunities, more potential profit?

More exchanges?
Especially support for EUR trades
Web UI for bot status or control?

New indicators such as MACD..

Email Text notifications

Generic default_trade.js usable with any exchange

This may be a 4.0 or beyond, but I'd like to see 'smart portfolio diversification' across various cryptocurrencies (say, the 5 or 10 with the highest market cap or trading volume) and to intelligently shift portions of --but not entire- allocations to currencies that are deemed more favorable at present, making zenbot more tactical. For example, maybe current portfolio is 55% BTC, 25% ETH, 10% LTC, 10% mix of others...then some news breaks and BTC is on the downtrend (either more risky than an alternative or less of an expected ROI) so zenbot shifts allocation to 30% BTC, 45% ETC, 20% LTC, 5% other.

@JeffUberman Zenbot is already capable of that, I am currently using Zenbot 3.5.13 to trade ETH-BTC-USD on GDAX which is similar to what you're describing. It will buy/sell ETH or BTC depending on which is trending at the moment.

Maybe a repair mode to find gaps in the data (missing data visible in the graph). I may be the only one to see this problem as I am running zenbot on an atom processor with 2gb of ram. The backfill seems ok but the reducer seems to skip some data.

A function for monitoring the top 5 or so highest 24 hour volume pairs on any given exchange would be nice :)
What @JeffUberman said is interesting. I haven't had a chance to test this yet so I will just ask, does zenbot currently trade multiple pairs and switch to another alt if for example you are running two scripts, ETH-BTC and LTC-BTC, the ETH-BTC pair is holding BTC and suddenly LTC trend triggers rs.op 'buy' will it will automatically switch to that pair (as in buy LTC)?
It would be awesome to have functionality that would predict pair profitability based on past performance and current trend data and switch to a more profitable currency while taking into account a 24 hour balance (and orderbooks?) to total user balance ratio. If the profitability margin is high enough maybe zenbot could even sell an asset where it stands and immediately buy into the more profitable opportunity. Also triangular arbitrage is fun.
In my opinion the more features/strategies/options parameters there are the less likely zenbot will suffer from "dilution syndrome" and lose it's profitability due to everyone using it although this may be more unlikely thanks to zenbrain.
Keep up the good work!

@JFD3D yes, in that scenario the bot would buy LTC, as long as the pairs are traded on the same exchange and share the same account balance.
I agree it would be awesome if Zenbot could analyze the entire crypto portfolio for the most profitable things to focus on, this is out of scope for Zenbot 3 though, perhaps in 4 :)

bittrex support ^_^

More exchanges: bitstamp, bitfinex, CEXio

More exchanges: btcc

bollinger bands please!

Have a option to prevent buy after buy or sell after sell.

no error
no bug
Programs that can be used

More exchanges :)

bump

Please add BTC-e.com exchange to zenbot.

@carlos8f Yes, pls Mila Kunis in 3.6 :P

Set the start balance by Asset or by Currency.
or
Set the first action of the Simulation (start with buy only).

an option to place limit orders instead or market orders to avoid fees.

"an option to place limit orders instead or market orders to avoid fees" this 100x over, i was really surprised having only worked with/on HFT bots that this was not an option. Market fees always seem to kill bots over time and this logic applied could save some money, and help increase trading volume more reasonably

Poloniex too please!

Alas, 3.6 never came, but Zenbot 4 is out, so I'm cleaning up 3.x issues. Please use and test 4, thanks!


Finish button broken in server step of new project wizard

If the server already exists and a new project is created, when reaching the last step where the server is to be configured, if the default choices are ok and nothing has to be modified on that screen, then the Finish button is disabled.
Work-around: change something and revert it, the Finish button can then be clicked.

This issue has been fixed in the Sling IDE Tooling project ( see SLING-5081:Unable to advance in the project creation wizard if the server is pre-selected ) and will be incorporated in the next AEM Developer Tools public release.
If you'd like to build a fix yourself, please follow the instructions from Sling IDE Tooling - building from source.


ENSURE DEPENDENT constraint is violated in the Malawi dataset

In the malawi examples in bdbcontrib/examples, writing DEPENDENT(whz, waz, muac, haz) initializes the states correctly, but after ~ 10 minutes of ANALYZE inspecting the dependence probability reveals that the pairwise dependencies is not equal to 1.
Thoughts: problem with implementation of ENSURE in CrossCat.

Hunting in progress ...


Upgrade to React 17

Currently, all backstage packages depend on React 16. React 17 has been stable for quite a while now, and provides better handling of multiple React versions running concurrently. Eventually using the new jsx factory would be great, but let this issue be only about bumping everything to 17.
Since this is a breaking change, it should be done in a breaking version bump.
I'm not 100% sure of what else will be needed for this, but at least react and react-dom need to be upgraded together.
On current master it's mostly 16.13.1, but a few other have sneaked in:
❯ rg --files -g package.json | xargs jq '.dependencies.react' | grep -v null | sort | uniq -c | sort -rn
  43 "^16.13.1"
   8 "^16.12.0"
   1 "^17.0.2"
   1 "^16.8.5"
   1 "^16.0.0"

When testing locally, I found that pinning react and react-dom to 17.0.2 and @hot-loader/react-dom to 17.0.1 works. Haven't done any thorough testing, but the UI loads and navigation works fine from what I can see.
Do we know of any other blocking issues before bumping?

<EMAIL_ADDRESS>should probably be bumped to 5 for React 17 compatibility (on paper anyway)

We have added the following to our root package.json resolutions block:
"@types/react": "^17.0.20",
"@types/react-dom": "^17.0.9",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-use": "^17.3.1"

@Rugvip suggested this in Discord. Since our user base is small right now, we're willing to be the sacrificial lamb to testing React 17. Our setup is not complex, but it should help give some insight on anything that might break from a simple setup.
So far we can confirm that the application builds and deploys successfully.

@Rugvip Quick update: @material-ui/* is going to the major battle here. React installs fine, but issues start popping up like crazy once you attempt to load the app. It all comes back to using v4 of those packages.
v5 was supposed to ship on September 1, 2021, but it does not appear that they are there, yet. It looks like it got bumped to September 15th here.
Once v5 is released, I could start a PR to work on this. However, I don't want to make any promises as I would have to do this in my spare time between work and kids. :(

@ellisio no pressure, any help is appreciated, and thank you for checking it out this far! 👍
So MUI v5 migration is another thing on the menu and we'll definitely want to be a bit late and careful with that one. Rolling that out in a smooth way will be a challenge. I'd say the best case there being that we can let people do it at their own pace as much as possible. Gonna create another issue for that one so we can keep this one focused on React v17

If these two issues are going to be closed, is there any tracking issue or a rough timeline (like 2022 or 2023) when these will be picked up?

I'd actually love to gather some more feedback on how React 17 works for people. Basically trying out the following resolutions added to the root package.json and seeing how well it works:
"resolutions": {
  "react": "^17",
  "react-dom": "^17",
  "@hot-loader/react-dom": "^17",
  "@types/react": "^17",
  "@types/react-dom": "^17",
}

If the types turn out to cause issues those two resolutions could be dropped.
With the above resolutions in place, how well do things work? Does the dev server work, production builds, hot reloads, type checking, and tests?
Tried it out in the main repo and it seems to work fine, but would like some more insight before we begin recommending migration.
When it comes to us moving our packages over to React 17, I imagine that might be more of a ^16 || ^17 thing

@Rugvip I haven't looked at this in a while now, work priorities are destroying my free time for cool things. However, when I did set resolutions like this I had many errors on the frontend with MUI.


(dropbox) Don't kill dropbox process, if it's running before install

Description
Before this, dropbox was being killed after the installation whether it was running before installation or not. Now installation script checks if dropbox is already running before start of the installation and if it is, then it will leave the dropbox's process alive after the installation (as installer always starts dropbox after it ends its work).
I also did some small code clean up - I removed helper function for retrieving registry key, as we now can just use Get-UninstallRegistryKey.
This fixes #1242
// on a side note, I know that RedBaron2 was also working on this in #1246, but I decided to send this PR anyway, because he has a different approach to this problem - he fully removed killing process part, which in my opinion isn't good, because it will make the (post-)installation not silent.
Motivation and Context
Before this PR, user could have been left with their data unsynced, if they're for example doing chocolatey upgrades in background - they may not notice that dropbox's process got killed.
How Has this Been Tested?
I used chocolatey-test-environment, I checked, if it can be installed and uninstalled and checked if dropbox will stay alive if it is running before installation (I also checked it during upgrade, as this is the main reason of this change)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[x] All files are up to date with the latest Contributing Guidelines
[x] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

@jack1142
Thanks for picking this up. I seem to have RL issues that are distracting me from doing this properly. Thanks 😃

@RedBaron2 I don't use Dropbox myself (OneDrive user here), but I can add a check if newer or same version isn't already installed.

Actually I will only check for equality, as it would prevent installing older versions (with --version parameter) on top of newer otherwise.

:white_check_mark: Package verification completed without issues. PR is now pending human review

:white_check_mark: Package verification completed without issues. PR is now pending human review

Would be great if you could rebase the PR as well.

@AdmiringWorm I'll fix those things today, but did you mean resolving conflicts by rebasing?

I'll fix those things today, but did you mean resolving conflicts by rebasing?

yes, the conflicts need to be resolved, and rebasing is the preferred way to do this as it keeps the repo history as clean as possible.

:white_check_mark: Package verification completed without issues. PR is now pending human review

@AdmiringWorm I made the changes you asked for


Moved urls redirects

Summary
Add redirects for any entries in moved_urls.yml
Reason
Any moved URLs need an entry in moved_urls.yml so that canonical URLs and the "latest version" links work. We can reuse that data to redirect any /latest/ URLs.
Testing
Visit /gateway/latest/install-and-run/rhel/ and it should redirect
Resolves DOCU-2483

should you point it to 3.0? or the navbar updates branch?

should you point it to 3.0? or the navbar updates branch?

I figured it out, this is supposed to point to 3.0


Show information on why cache is not used?

This is along the lines of https://github.com/JuliaDocs/DemoCards.jl/issues/137 and https://github.com/rikhuijzer/PlutoStaticHTML.jl/issues/161. Developers face issue to identify why the cache present is not used: if it was the input sha or julia version used. Showing this little information will help to debug the cache the functionality from CI.

Great suggestion! Why didn't I think of that. I'll do that soon. Probably later this week


docs: add 0.14 docs

Is it normal that it targets master?

yes, the docs job only runs on master & PRs or on a  release

Ok!


Resolve #12 and include a bonus schema change

This should resolve #12 by allowing undifferentiated organs to be serialized.

Thanks @asitang for the review! (Gotta be faster, @yuliujpl 😆)

Oh sorry, will beat Asitang to it next time :)


Rename Animation::track_remove_key_at_position to track_remove_key_at_time

As originally identified here, the method Animation::track_remove_key_at_position(int, float) actually removes the key at the time specified. This PR renames the method to reflect this.
Part of #16863.

Thanks!


Updates runTerraform to name the workspace folder after the cluster

Can you describe what this change is in more detail , what workspace ?


Feature request: counting flags

I've seen a lot of cli's where verbosity can be controlled by repeating a -v flag. So either -v -v -v or -vvv (though the latter seems less common).
I've been trying to emulate this using a converter but since the verbosity is defined as an int, the -v parameter seems to always expect a value.
A cherry on top would be the case where a single occurance of -v could optionally accept a value so the 2 options would be possible at the same time

I was hoping that something like the following would "just work":
from cyclopts import App, Parameter
from typing import Annotated

app = App()

@app.default
def main(
    *,
    verbose: Annotated[tuple[bool, ...], Parameter(name=("--verbose", "-v"))] = (),
):
    verbosity = sum(verbose)
    print(f"{verbosity=}")

if __name__ == "__main__":
    app()

However, it does not (and I consider that a bug on my part). So I'll try and fix this ASAP. Assuming that the above situation worked as intended, would that satisfy your need?

Cool, thanks!
I was trying to do something like argparse:
>>> parser = argparse.ArgumentParser()
>>> parser.add_argument('--verbose', '-v', action='count', default=0)
>>> parser.parse_args(['-vvv'])
Namespace(verbose=3)

Could Parameter also take an 'action' like that? perhaps in the form of a functor?

Cool ! Thanks a lot! 🙏


CASMREL-1489

Includes:

CASMINST-6306
CASMPET-6319
MTL-2113
MTL-2141
MTL-2151
VSHA-559

Rebuilding these assets to include CASMPET-6319 and MTL-2141.
NOTE CASMPET-6319's craycli RPM is coming via: https://github.com/Cray-HPE/csm/pull/2163

Do not merge this, images are rebuilding per above comment.

Images are ready.


Add support for getting baseline file from default path

If the the baseline file path is not specified by command line, checkmetrics tool will look for the baseline file in a system path by default. This baseline file will be shipped during installation step.

lgtm

From the diff it looks like git didn't pick up that the toml file was moved/renamed - but, that's not the end of the world. For reference, I suspect git mv might be the easiest way to ensure git has full knowledge.
lgtm


Replace option not working

With the latest npm version (0.4.0) the replace option with -r wasn't working. I noticed #55, where it was added and this was merged after the 0.4.0 released and updating to the latest master fxed the problem for me (using -i). Maybe it's time for a new release or why does the help text say the functionality was already in 0.4.0?

Let me update the dependencies via #119 to fix security vulnerabilities, then I'll publish a new release.

Published to 0.5.0.


File permissions issue with version 0.8.3

Hi,
I'm seeing the same file permissions issue (https://github.com/googleapis/gax-ruby/issues/54) that affected other versions happening with version 0.8.3.
This is not happening for version 0.8.2.
I've downloaded the gem and manually unpacked:
$ wget https://rubygems.org/downloads/google-gax-0.8.3.gem
--2017-06-21 16:16:17--  https://rubygems.org/downloads/google-gax-0.8.3.gem
Resolving rubygems.org... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to rubygems.org|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 33792 (33K) [application/octet-stream]
Saving to: ‘google-gax-0.8.3.gem’

google-gax-0.8.3.gem                                               100%[==============================================================================================================================================================>]  33.00K  --.-KB/s    in 0.02s

2017-06-21 16:16:17 (1.42 MB/s) - ‘google-gax-0.8.3.gem’ saved [33792/33792]

16:16:17- tmp $ gem unpack google-gax-0.8.3.gem
Unpacked gem: '/private/tmp/google-gax-0.8.3'
16:16:23- tmp $ cd google-gax-0.8.3
16:16:27- google-gax-0.8.3 $ find . -type f -perm 640 -print
./lib/google/gax/api_callable.rb
./lib/google/gax/bundling.rb
./lib/google/gax/constants.rb
./lib/google/gax/errors.rb
./lib/google/gax/grpc.rb
./lib/google/gax/operation.rb
./lib/google/gax/path_template.rb
./lib/google/gax/settings.rb
./lib/google/gax/version.rb
./lib/google/gax.rb
./lib/google/longrunning/operations_client.rb
./lib/google/longrunning/operations_client_config.json
./Rakefile
./README.md
./spec/google/gax/api_callable_spec.rb
./spec/google/gax/bundling_spec.rb
./spec/google/gax/operation_spec.rb
./spec/google/gax/path_template_spec.rb
./spec/google/gax/settings_spec.rb
./spec/spec_helper.rb

Closing since new release 0.8.4 fixed this issue.


Want add swagger-docs.

Hi @Rudge ,I want to write some annotation for auto generate swagger-ui page as a pull request but this need upgrade javalin version to lastest.
What do you think?

Hi @vn7n24fzkq, sorry my delay. Please you can do. Thanks for your collaboration.


getColors() seems to Block the Main Queue

I have it set up in a TableView to load the view next to an image view to have the background color to match the image. However it lags when you're loading a new Cell for the first time. This is seems to like something might be blocking the Main Queue even when it shouldn't.
I looked over your code and can't figure out why it would block it since you do the usual:
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)) { ... }

I would've user QOS_CLASS_BACKGROUND for it but that shouldn't change anything

I'll look into this, thanks 👍

Hey, @mathiasquintero I'm not able to reproduce this. Can I get a bit more detail on your situation?

@jathu I put a few in a tableview and during rendering the scrollview would lag...

Are you using getColor that doesn't scale down the images? I tried reproducing a table with ~20 images and I don't get any lag with getColor with image scale.

I'm closing this for now, if you continue to have this problem, please let me know.


1.14.1 Cherrypick

/label tide/merge-method-rebase

@tiffanny29631 FYI you'll need to cherry pick https://github.com/GoogleContainerTools/kpt-config-sync/pull/335

/lgtm


Extract init commands and build separate binaries

Instead of having a big init binary, we could create smaller binaries for each command and implement something in init to execute them.

I started this. Looks like it works so I'll file more specific issues in the future.


Contents on generated chm is not complete

On the left column, Room Editor and GUI Editor can be expanded. Other files can't be expanded. Either all files should be able to expand or neither.

I think this is built in behaviour for the format, as if I remove the index markers the result is the same. The original CHM manual does the same thing.

Ok, I found the problem but I don't have any ideas on the why. Apparently sphinx isn't generating a .hhc file! It should happen when sphinx says writing TOC file... . Looking the code, I have NO IDEA why this is happening.

This is fixed after the switch from sphinx to pandoc with lua build, so this can be closed!


Fix no sound on Linux

Should fix #54

Coverage remained the same at 100.0% when pulling ebc114a039fdf3c3c015f4ae921caea34b61a4aa on fix-no-sound into 2ceb89f9c63c84dee7dc4f2dae715c5e5e095fd6 on master.


Dynamic Provisioning of Management EC2 via CloudFormation

dynamic EC2 via vanilla AMI using CF (user data) to bootstrap
-- pass in JSON

Implemented: https://github.com/unity-sds/unity-on-demand-cloudformation/blob/develop/templates/unity_deployer_instance-act.yaml


Backmerge/release/september 2024 2024 09 24

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-azure-resource-manager
:x:@azure-tools/typespec-client-generator-core

Show changes

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


test: add test cases about imageToCriImage

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes part of #1756
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1769 into master will decrease coverage by 5.72%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1769      +/-   ##
=========================================
- Coverage   56.32%   50.6%   -5.73%
=========================================
  Files         200     200
  Lines       15657   15657
=========================================
- Hits         8819    7923     -896
- Misses       5742    6575     +833
- Partials     1096    1159      +63

Flag
Coverage Δ

#critest
33.53% <ø> (+0.05%)
:arrow_up:

#integrationtest
37.67% <ø> (-0.02%)
:arrow_down:

#unittest
23.71% <ø> (+3.38%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/multierror/def.go
15.38% <0%> (-84.62%)
:arrow_down:

daemon/logger/loggerutils/tag.go
0% <0%> (-81.82%)
:arrow_down:

pkg/utils/utils.go
25.64% <0%> (-64.53%)
:arrow_down:

pkg/bytefmt/bytefmt.go
28.81% <0%> (-64.41%)
:arrow_down:

daemon/mgr/container_envs.go
11.76% <0%> (-54.91%)
:arrow_down:

daemon/logger/info.go
0% <0%> (-53.66%)
:arrow_down:

daemon/logger/syslog/validate.go
0% <0%> (-52.64%)
:arrow_down:

pkg/utils/templates/templates.go
0% <0%> (-50%)
:arrow_down:

pkg/utils/filters/filter.go
22.5% <0%> (-50%)
:arrow_down:

pkg/net/interface.go
49.47% <0%> (-46.36%)
:arrow_down:

... and 30 more

gometalinter
gometalinter --config .gometalinter.json ./...
cri/v1alpha2/cri_utils_test.go:1::warning: file is not goimported (goimports)
Makefile:122: recipe for target 'gometalinter' failed
make: *** [gometalinter] Error 1
Exited with code 2


Invalid content for node doc: <>

Installed this lib with npm i and after I call useEditor hook I get this error:

Code looks like this:
import { EditorContent, extensions, useEditor } from 'rn-text-editor';
// ...
 const inputRef = React.useRef<TextInput>(null);
    const editor = useEditor({
        enableCoreExtensions: true,
        onUpdate(props) {
            console.log(props.editor.contentAsJson());
        }
    });

    return (
        <EditorContent
            editor={editor}
            placeholder="Write something..."
            inputRef={inputRef}
            autoFocus
        />
    );
// ...

Have any ideas about this error and how to fix it?

Hi @IslamRustam
Make sure you install the beta version
npm i<EMAIL_ADDRESS>
the docs: https://www.npmjs.com/package/rn-text-editor/v/0.2.0-beta.3
& It's not stable; there is a lot of work that needs to be done. Due this https://github.com/facebook/react-native/issues/29063#issuecomment-1925550545

Using beta version indeed fixed it, but editor itself does require some work. Hopefully you will manage to achieve what you plan to!


Quick upgrade

Nugets:

Elsa* <IP_ADDRESS> to v<IP_ADDRESS>9
netcoreapp3.0 to net5.0

Misc:

FontAwesome fas to fad
Usings sorted

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: DoomerDGR8 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[BUGFIX] Fix handling of duplicate special tokens in Vocabulary

Example use case in scripts/tests/test_dataprocessor.py where eos_token == padding_token. Prior to this fix, eos_token == padding_token lead to a
corrupted vocabulary index.
Example of the corrupted index:
> v = nlp.Vocab(...)
> v.idx_to_token
['<unk>', '<eos>', '<eos>', 'c', 'b', 'a']
> v.token_to_idx
{'<unk>': 0, '<eos>': 2, 'c': 3, 'b': 4, 'a': 5}

Checklist
Essentials

[X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[X] Changes are complete (i.e. I finished coding on this PR)
[X] All changes have test coverage
[X] Code is well-documented

Changes

[X] Fix handling of duplicate special tokens when creating a Vocabulary

Comments

This fix does not impact backward compatibility in that previously serialized
vocabularies will be restored exactly as serialized.
Newly created vocabularies may differ, if up until now their index was corrupt
The changes to the deserialization process in
https://github.com/dmlc/gluon-nlp/pull/732 and resulting execution of sanity
checks during deserialization would prevent deserialization of vocabularies
with a corrupt index. I added some backwards compatibility code for loading the corrupted serialized files in #732

Job PR-749/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-749/1/index.html

This does not affect deserialization in the current codebase.
If #732 is merged, deserialization would fail, however #732 also contains some backward compat code.
That code assures that deserialization works as it does currently and prints a warning.


electron*: mark older versions as EOL

Description of changes
https://www.electronjs.org/docs/latest/tutorial/electron-timelines#timeline
Some discussion in https://github.com/NixOS/nixpkgs/pull/318857#issuecomment-2161462390.
Heads up to maintainers of applications that should be updated to avoid using these versions:

[ ] feishin @onny @jlbribeiro
[ ] logseq (unmaintained)
[ ] ride @TomaSajt @markus1189
[ ] micropad @rhysmdnz
[ ] pocket-casts @WolfangAukang
[ ] webtorrent_desktop @bendlas
[ ] whalebird @WolfangAukang @uninsane @Weathercold
[ ] deltachat-desktop @dotlambda
[ ] mattermost-desktop @jokogr
[ ] bitwarden-desktop @amarshall @Kiwi
[ ] blockbench @ckiee @TomaSajt
[ ] lx-music-desktop @oo-infty
[ ] morgen @justanotherariel @WolfangAukang
[ ] obsidian @AtilaSaraiva @ConradMearns @zaninime @qbit @kashw2 @w-lfchen

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We need to wait for the next bitwarden-desktop release to contain https://github.com/bitwarden/clients/commit/a4dd1f45441084b6343b13acf0fb1935736eb48b or just bump to electron 28.

28 is also EOL now.

Added a upstream bug report for Feishin about updating Electron version https://github.com/jeffvli/feishin/issues/643

28 is also EOL now

That's an arbitrary decision we can also delay by a week or two with no hard drawbacks. It only becomes a problem if we delay it for a long time.
Having to compile electron is a hard drawback and most people cannot even do that or it becomes an unreasonable hard and unjustifiable burden just to have that EOL version up to date.
Also that build failure seems to be just a gcc warning being treated as error. We can ignore that.

Noise, they literally tagged a release 30 minutes ago https://github.com/bitwarden/clients/releases/tag/desktop-v2024.6.0

@SuperSandro2000 as I mentioned above, electron 27 and 28 also won't build now anymore (due to LLVM incompatibilities).

Don't we usually remove the EOL electron-source versions and mark the binary electron_*-bin version EOL? Not both?
See #295672 (c45702d and 1f9c426).

I opened #319415 for what I meant, including version conditional cleanups in both the underlying chromium derivation and electron-source.


Update Makefile for Pi2

Fix build failure on Pi2

@ukscone Thanks for the PR! I ended up just looking for arm in the uname string (see d4a90d4), since the includes will be the same for the RPI 1 & 2.

makes sense. I just bunged in the extra lines to solve an immediate problem with the build instead of thinking about the "correct" way to do it

@ukscone They're definitely both correct. I'm still on the lookout for a reliable way to detect the RPI and distinguish from other ARM platforms, so if you have any ideas, let me know!

grep the Hardware line in /proc/cpuinfo maybe?
grep  Hardware /proc/cpuinfo | awk '{print $3}'
on Pi B/B+/A/A+ it'd be BCM2708 (iirc as no powered B/B+ atm)
on Pi2 it'd be BCM2709

@ukscone Thanks for the ideas! Since platform detection could be more robust generally, I created a new issue (see #14).


Screen: search

Accessed from the appbar on any screen of the app.
Designs (WIP):

Resting state (before typing)
Results (after typing)

TODO

Autocomplete (non-MVP):

Updated to reflect it's about search now

Done, #120 merges the whole thing to develop


.snapTo error / crashing on iOS

React-native 0.63.3
Expo sdk 38
React-native-reanimated 1.7.0-v2

The issue is this.state.snapPoints[this.state.propsToNewIndices[index]] is undefined.

@karimcambridge The point should be an index from snapPoints array. For example snapPoints={[10, 50, 100]}, you just need to snapTo(0) for the first index and so on.

@karimcambridge The point should be an index from snapPoints array. For example snapPoints={[10, 50, 100]}, you just need to snapTo(0) for the first index and so on.

Yes, I know. Thank you.. I already submitted a pull request.

did you resolve it?

https://github.com/osdnk/react-native-reanimated-bottom-sheet/pull/286


Document Adoption Process

Motivation
With more and more integrations being baked into the community, can we please

Document the process requesting for adoption
Document the process of regesting a repository
Add a github issue type each of those to this repo

Feature

Alternatives

Additional context

Regarding the 3rd point, I can create custom GitHub template issues that merge/override the default ones we have (at the organization level).
We already did this for the falco-website repo (look here).
So my proposal is... 👇
Each template issue will automatically insert one of the following GitHub labels.
Thus we'll have 3 template issue.
adoption/sandbox request -> kind/adoption -> matches contrib/sandbox level: in a sub-directory of this repo
incubation request -> kind/incubation -> matches repository/incubating level: obtain a repository in the falcosecurity org
offical support request -> kind/officialsupport -> matches official support: the tool/artifact/etc. becomes an official support project of Falco (can remain in its own repo or be adopted into the Falco one depending on the nature of the thing).
WDYT?

I like the labels! I would just use kind/sandbox instead of kind/adoption so we will able to use those labels for all issues not just requesting ones.
Btw, If you want to document the process, please add that on top of https://github.com/falcosecurity/contrib/pull/24
There you can found the new README. Thanks


Languages for CodeShip

Dart, Elixir, Go, Java and JVM based languages, PHP, Python, Node.JS, Ruby

Thanks!

you welcome :+1:


[HOSTEDCP-1041] Accurately default latest release image using hypershift-operator supported versions

Previously, the hostedCluster.Spec.Release.Image was required and the hcp or hypershift cli defaulted that value client side. This posed several issues though.

The defaulting did not take into consideration what the max and min version the deployed hypershift operator supports, which will eventually lead to the client defaulting unsupported versions.
This logic was all client side, which meant that it couldn't be used in a gitops flow or reused by the console web UI.

The new logic performs defaulting  the release image on the backend. It takes into account the latest/min supported versions and picks the most recent version that falls within those constraints.

/hold
We're investigating the possibility of moving this defaulting to a webhook instead of the controller


Address issues arising when users run Independent Assessment (IA) task

Background
Every time Admins run the IA task on applicable exercises, the Digital team receive support requests from them, either:

wanting to extend the hard deadline, or
on behalf of candidates wanting to change their Assessors.

Addressing these issues is intended to eliminate these requests and free up developer time for new features etc.
User Story
As the Digital team, I would like to remove the hard deadline functionality and put in place functionality that allows Assessors to be changed after the IA task has been initiated so that the user issues mentioned above no longer arise.
Benefit(s) to user (if not already clear from User story)
Admins are able to change Assessors after IA task has been initiated without recourse to the Digital team.
Feature(s) Description

[ ] Remove hard deadline functionality without impacting processes, whilst retaining the means for Admins to specify IA contact and return dates in the exercise timeline (see image 1)
[ ] Build a solution that allows Admins to input new Assessor details on behalf of the candidates and request from them IAs via the platform after the IA task has already been initiated

Image 1:

Acceptance Criteria
It's done when:

Admins no longer need to request extensions to the hard deadline
Admins are able to input new Assessors details on behalf of the candidates and request from them IAs via the platform after the IA task has already been initiated

Definition of Done

[ ] User stories/acceptance criteria met
[ ] Internal reviews passed (feedback actioned)
[ ] User testing passed
[ ] Relevant technical documentation updated
[ ] User guidance updated
[ ] Deployed and merged without errors

User Testing Steps
Previously, Admins experienced issues when running the IA task with the hard deadline needing to be extended and candidates wanting to change their Assessors after the IA task had been initiated. This item is intended to address those issues.
Feature Champion
Rob Lynch

Hey team! Please add your planning poker estimate with Zenhub @drieJAC @HalcyonJAC @KoWeiJAC @tomlovesgithub @warrensearle

@tomlovesgithub Nice job, Tom. Happy for this to be merged and closed once internal reviews passed.


Debug Push Notifications

Bug

In 2020, the HiHomeViewController had an announcement button that all non-guest roles could press to see a log of sent push notifications. In this log, there was another button that was only accessible to admin so that admin could send announcements directly from the iOS app. The alternative way is for admin to use the admin portal and use the notifications dashboard. Both ways would send a post request to the notifications/publish/topic/topicid endpoint. Upon receiving the request, the HackIllinois API will interact with the AWS simple notification service (SNS) to publish the notification to all registered devices of the specified topic
iOS has a HiLocalNotificationsController that schedules local push notifications for favorited events. The schedule method calls are also in HiEventListiVewController.

Neither of these worked for last year's app.
Steps

Debug the second push notification.
Debug the first push notification

After a thorough analysis, I have discovered no issues in the iOS notification code. Everything seems to be functioning. I have also discovered that Push Notifications not working last year isn't iOS or Android's fault. I blame API.

No need to worry about this anymore. Custom sent push notifications won't be used for Hack 2022.


chore: change from example.org to tx.test

Description

Description

change from example.org to tx.test as test domain

Why
example.org is a reserved (2nd level) domain (for documentation purposes) and therefore it's not optimal for dns resolution.
This change may make the editing of the etc/hosts file less necessary: https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/main/charts/umbrella/README.md#network-setup

https://github.com/eclipse-tractusx/sig-release/issues/418
Pre-review checks

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

HI Eveline,
today we  tested again the helm chart depolyment. This deploment still works fine, but we no longer are able to change the domain names, what we could do before your change. Seems tx.test is now hardcoded. For the tutorial we need the option to use different domain names for the different instances on one system.
Thank  you


Migrate EtcdConfigStore to @configu/integrations

Suggestion
Migrate the EtcdConfigStore from its current setup to the new @configu/integrations module as part of the major restructuring. The goal is to move all third-party integrations, including stores, expressions, and libraries, to @configu/integrations.
Motivation
This migration is part of a larger effort to better organize and modularize the product. Moving the EtcdConfigStore will align with the new structure, making the system cleaner and more maintainable.
Context
You can refer to the already migrated stores for guidance:
Migrated stores in integrations.
Base stores implementations from @configu/ts can be found here:
Base stores in TS.
The old node-based stores were previously in @configu/node:
Node stores.
The old browser-based stores were previously in @configu/browser:
Browser stores.

Interested @rannn505.

All yours @su-shubham


Documentation for NSG rules for VMs in load-balanced pools is incorrect

This page. states:

Virtual machines in load-balanced pools: The source port and address range applied are from the originating computer, not the load balancer. The destination port and address range are for the destination computer, not the load balancer.

This is correct for inbound rules, but not for outbound rules.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e905802-0b08-4b3b-25ec-0f88c023bc32
Version Independent ID: f31325e5-49ea-b28c-336e-10f2a3fc12b4
Content: Azure security groups overview
Content Source: articles/virtual-network/security-overview.md
Service: virtual-network
GitHub Login: @malopMSFT
Microsoft Alias: malop

@jpduffield, Thanks for your feedback. We are looking into this query and will update you as soon as possible.

@jpduffield , Appreciate your patience. Even on inbound or outbound, the NSG has to whitelist only the target computer IP but not the load balancer IP as LB only does inbound natting where port forward traffic from a specific port of a specific frontend IP address to a specific port of a specific backend instance inside the virtual network. This is also accomplished by the same hash-based distribution as load balancing.
Even on outbound SNAT, the outbound connections are automatically translated to the public frontend IP address. There is no need of adding an outbound NSG rule for load balancer here as it does not act as a reverse proxy.

@SubhashVasarapu-MSFT. That's all fine in theory, but doesn't match what actually happens when I try to configure outbound rules in an NSG.  NAT is irrelevant here. I'm just load balancing over a backend pool.
Consider the following simplified example (This is a bit contrived, but demonstrates the issue with a minimal setup).:

One subnet (subnet_A) containing an internal load balancer, balancing traffic to a backend pool containing VMs in an ASG (ASG_A). There is no NAT here, the load balancer simply distributes traffic.
Another subnet (subnet_B) containing another pool of of VMs in an ASG (ASG_B) that make HTTP requests to the VMs in ASG_A via the load balancer.

There is one NSG attached to each subnet. As all the VMs in this example are in one vnet, you will need "deny all" rules in both NSGs to disable the default "AllowVnet" rules for inbound and outbound traffic.
If I trust the documentation, I then need to configure the following NSG rules:

The NSG attached to subnet_A needs an inbound rule allowing with a source of ASG_B and destination of ASG_A.
This is fine, and works as expected..
The NSG attached to subnet_B needs an outbound rule allowing traffic source of ASG_B and destination of ASG_A.
This does not work. Instead, I need an to set the destination to the IP address of the load balancer in subnet_A.

@jpduffield, Does the ASG_A includes ILB's IP?

@SubhashVasarapu-MSFT
No, the LB is not in the ASG, only the pooled VMs are in the ASG.

@jpduffield , I think that explains why it is not working. Your ASG is custom group and you need to explicitly add the ILB's IP in order to get this working.
In the Subnet A, you have blocked the inbound traffic from all sources and allowed traffic from ASG B to ASG A. If ASG A doesn't include ILB's IP, it will fail.
Moreover, this documentation speaks about the behavior of the packets when it reaches the NIC. Here you have attached the NSG to the subnet. When the packet flows from VM in Subnet B to ILB, until it reaches the NIC, the destination IP is LB. Once the packet reaches the NIC, you can take a packet capture to very the Source and destination IP. You will be seeing source as VM in Subnet B and the destination as private IP of the VM.
So your VM will respond directly to the VM in Subnet B. The translations are handled by the platform.
Let me know if you have any further questions.

@jpduffield , I will go ahead and close this issue. Please tag me if you have any further questions.

@msrini-MSFT Why has this been closed? The issue has not been resolved. The documentation is still wrong.

@msrini-MSFT wrote:

I think that explains why it is not working.

My setup is working. But the documentation explaining how I should configure things is wrong.

Your ASG is custom group and you need to explicitly add the ILB's IP in order to get this working.

In the Subnet A, you have blocked the inbound traffic from all sources and allowed traffic from ASG B to ASG A. If ASG A doesn't include ILB's IP, it will fail.

Huh? Did you even try this? This doesn't fail, it works as expected.
This is the bit that does work in accordance with the documentation. The ILB is not (and does not need to be) in the ASG because the inbound filtering is applied at the destination VM.
It's the outbound filtering where the documentation is misleading.
Adding the load balancer to an ASG doesn't make sense to me, and I wasn't aware that it was even possible . Please can you explain how I can do that via the portal (and also point me to some documentation explaining why I might want to).

@jpduffield , I understand what you are saying.
This documentation explains for the scenarios where you have a Public Load balancer, you need to explicitly allow your Client's public IP address in your VM's NIC NSG. We just wanted to make your readers understand that LB just forwards the packet and it will not be acting as a reverse proxy.
For a ILB, it will work anyways until you have a deny rule on top of default VNET allow rule.
Your scenario is a unique one where you are using ASG and you will not be able to add LB's IP to it.
I will tag author to get the doc more clarity with your scenario as well.
@malopMSFT , Can you take a look at this issue?


JUnit reporter must be careful when removing report dir contents

No matter what the report directory is specified as,
the test reporter ought not delete any files it did
not create itself.
Resolves #197 for HtmlReporter and JUnitReporter

@os97673 the "empty report directory" strategy this PR aims to fix for the JUnit reporter is in use for other reporters as well.
I'd be glad to make changes to address those instances as well.

Okay, I've made the same change to both: HtmlReporter and JUnitReporter. It looks like those were the only two reporters to be a little gung-ho on cleaning up after itself.
My thoughts witth this change:

only remove files that match the pattern used by the reporter
don't remove the directory. if the reporter is responsible for anything, it should only be to make sure the directory exists before trying to write to it.

@os97673 updated...

Great.  Just one more request: now we have two places in HtmlReporter where the output file name is constructed.  Could you please extract this code into a separate method to avoid code duplication.

Absolutely :)

How's that, @os97673?

Looks fine for me, just give me some time to merge and release a new version.

:+1: Greatly appreciated. Thank you.


terminal.integrated.accessibleViewPreserveCursorPosition should it be ON by default?

Testing #196124
We try to preserve cursor position whenever we can in our editor. So should terminal.integrated.accessibleViewPreserveCursorPosition be on by default? In fact, do we really need to make this configurable?

By default, we want to align w the behavior of the terminal - which always has the cursor on the last line.
In particular this makes sense because someone might have reviewed their output from a command, run a new one, and upon reopening, expect to inspect their last command's output. That is also JooYoung's opinion.
@Tyriar do you agree?

@isidorn the thinking here is that users will typically be reviewing the last run command:

Run a command
Ctrl+up to review last output
Run a command
Ctrl+up to review last output

@meganrogge can we retain the last position and reset the position when data is written to the terminal? Is that the best of both worlds?

The author of the issue specifically did not want the cursor position to be reset when a new command has been run. I think we're doing the right thing here.
Yes, the thinking is exactly what you said above @Tyriar , which is why that's the default behavior.

Thanks for chimming in and for providing details.

can we retain the last position and reset the position when data is written to the terminal? Is that the best of both worlds?

This sounds like a great approach to me.

@isidorn in the original linked issue, I asked the author if that would work for them and they said no.

That's good to know. But in general, we should not make decisions based on a sample of 1.
So ideally we check how other users are using it. Or we can add some telemetry to gain a better understanding into this.

I agree and think that getting some telemetry is a good idea.


Bootstrapping

We'd like to use this provider for managing our Dremio objects, but the documentation is sparse.
Can you elaborate on the DREMIO_URL expected for the provider, as well as the IDs needed to import existing objects into state?  (I can look through the code for these as well.)

Hi @adamdonahue ,
Great to hear from you that this could be useful! This was a solo effort that gave me the basis of what I needed to get started with Dremio. Yes, the docs are basically non-existent, sorry about that! Now that I know there's interest I'll take a look at improving them!
I've got my provider set up as:
provider "dremio" {   dremio_url = "https://mymachine.mycompany.com:9047"   username   = "admin"   password   = "mypassword" }
I haven't tried importing into state - I've just got it provisioning everything from scratch. The ids in general should match the ids you get from using the dremio api so hopefully that may work? Though if there's any additional import code required in the provider then that doesn't exist yet.
Like I said, if you are interested in using this then I'll certainly help fix/document/give examples.
Our current use case that we're running is setting up some sources, physical datasets, virtual datasets and reflections.

Thanks for the quick reply.
Importing isn't essential since we're deploying a fresh installation (Terraform reports import is not supported by the provider), but definitely eager to use and help improve it if possible.
Let me see if I can get a data resource loaded to verify it's accessing the API correctly, but the URL is helpful.  (I had a trailing / which caused an error, so that example helped.)
I'll let you know how it goes.
Adam

Hello @saltxwater
Would you have some examples, for example how to create a dataset from S3, etc... ?
Thanks !


Strategies challanges string or object?

I'm trying to figure out how challenges should be handled.
Looking through passport's authenticate middleware's fail handling I understand that the challenge a strategy should give to fail can either be a string or object with fields like type and message. Only string challenges are put into the WWW-Authenticate header, but challenges that are objects are way more usable in a callback. This kind of means the strategy needs to consider the API it's used in, which seems like an issue?
I for example like to use a bearer strategy for a json api and return possible authentication errors through json. But this strategy returns challenge strings.
The best docs I could find on Passport strategies mention challange should be string btw: https://github.com/jaredhanson/passport-strategy#strategyfailchallenge-status

From what I read on the source, it should always be a string.

The comments on the source code say it should be a string.
But I found actually it's an object or Error.


Update nightly package workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e9334b3) 100.00% compared to head (0e75b65) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          301       301
  Branches        60        60
=========================================
  Hits           301       301

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


listview和tab滑动卡顿

Listview and tab slide carton，maybe only 30 fps on oneplus 5T.

Hi @Ha2ryZhang
can you please provide your flutter doctor -v, a complete minimal code sample to reproduce and screen recording of this?


Add test for extracting a big expression with vecs

This PR adds a test so that we can benchmark extracting an expression with vecs in it. This was recently discovered as a performance bottleneck. Hopefully adding the benchmark should let us resolve the extraction issue.
EDIT: This also lets us disable saving/printing messages (for use cases like Python where you use the ExtractReport instead of the messages).

It looks like this test fails before it finishes, maybe due to resource constraints of the runner?
SIGTERM [  81.248s] egglog::files extract_vec_bench

I had a similar issue on my laptop. I believe this can be caused by quadratic blowup in TermDag::to_string. I made a fix - https://github.com/egraphs-good/egglog/pull/496

This is ready for review!


[KED-2954] Format experiment tracking timestamp

Description
We'd like to show a human-readable timestamp for experiment tracking runs. This PR implements that.
Development notes
I've used the .fromNow() method of the Day.js library, which is nice and small and does exactly what we need.
QA notes

Check out the branch and take a look at the dates.
Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

Legal notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

I've given this a thought - while we are waiting to align with the BE on the format of the timestamp, it would be worth for us to set up a small util function to format the timestamp from the BE to return a JS date object as this might happen again somewhere down the line.
I've just merged the latest feature branch into this branch locally to test this with my local experiment data - pasting it here for your reference.

Whoops. I already merged this in after speaking with Antony about the date format. I was tired of it still being in PR.
If you pull this branch down or also check out our main feature branch it should be working now. Let me know if it isn't.