Add more failing tests of rest element reassignment.

This is a pull request onto your pull request https://github.com/babel/babel/pull/3249. If you merge this PR, that PR should be automatically updated. Fingers crossed!
I expect the new tests to fail, because they contain additional examples of member expressions that can't be replaced with conditional expressions.

That's great @benjamn. Might be a bit easier to fix if could provide expected results for these tests (if you have an opinion about what it should look like of course, no pressure!).

This is just a guess, so you should probably prefer the real output if it looks reasonable:
function swap() {
  for (var _len9 = arguments.length, rest = Array(_len9), _key9 = 0; _key9 < _len9; _key9++) {
    rest[_key9] = arguments[_key9];
  }

  [rest[0], rest[1]] = [rest[1], rest[0]];
}

function x() {
  for (var _len10 = arguments.length, rest = Array(_len10), _key10 = 0; _key10 < _len10; _key10++) {
    rest[_key10] = arguments[_key10];
  }

  for (rest[0] in this) foo(rest[0]);
}

I'll update my PR.

Thanks!
I fixed swap (rest.js l.66, add         && !grandparentPath.isArrayExpression()), working on x(). I'll PR this repo when I'm done.

I think swap may be a specific instance of a more general problem: when the MemberExpression is used as an LVal (that is, something that gets updated), it can't be replaced with an arbitrary Expression. So I'm kind of hoping for a more general solution. I'll try to think of some more test cases.

Yep, that's what I noticed with the previous fix for ArrayExpressions. I first added another clause for ForInExpressions and noticed I could replace them with isLVal.
After l.66, add !grandparentPath.isLVal() instead.

Here are some even nastier cases:
function inc (...rest) {
  ++rest[0];
}

function dec (...rest) {
  --rest[0];
}

function method (...rest) {
  rest[0]();
}

I'll update the other PR to include these as well, but I think this bug deserves more discussion, because it's pretty tricky to tell when it's safe to replace a MemberExpression with an arbitrary Expression.

function method (...rest) {
  rest[0]();
}

is already safely transformed.
function inc (...rest) {
  ++rest[0];
}

function dec (...rest) {
  --rest[0];
}

These are just missing some parens around loadRest.

I have to disagree with both claims.
The method function is not safely transformed, because the this value in the method call will be undefined, when it should be the rest object:
(arguments.length <= 0 ? undefined : arguments[0])()

It's similar to the difference between obj.method(x) and (0,obj.method)(x), if you know that trick.
The newExp function that I added seems to be safely transformed, after all, but I think it's still worth keeping as a test.
The problem with the ++ and -- cases is more than just missing parentheses, because this code doesn't actually update anything when there are parentheses:
++(arguments.length <= 0 ? undefined : arguments[0])
--(arguments.length <= 0 ? undefined : arguments[0])

Again, I think the fundamental issue here is that the ternary ConditionalExpression is not an updatable/assignable LVal, whereas the rest[0] expression is. I wish I knew how to capture that check in a simple, general way.

Right, thanks for the clarification. :+1:

Thank you both @benjamn and @vhf for the effort on this!
Thanks @benjamn for identifying all of these failure cases, this is great! I think all of these, at least as represented in these fixtures, can be cured. Here is a rough draft WIP building on this PR: https://github.com/benjamn/babel/compare/rest-assign-el...jmm:more-rest-deopt. I still have to check out the isLVal() angle you two were discussing to see if that can collapse some of these more specific tests without clobbering legit optimizations.
@vhf if I end up duplicating work that you did that fixes some of these cases let's make sure your commit(s) for that stuff end up in here. Sounds like maybe you already had the array destructuring and for-in cases handled, and collapsed via LVal? In that case we can add what I've come up with for the other cases.
You mentioned ArrayExpression -- I might be trying to do this too quick, and haven't seen your actual code of course, but I'm thinking that's not the right solution? I think it might seem like it's fixing it because there are refs to the rest param in an ArrayExpression on the RHS in the fixture, but as you can see in my WIP I'm testing for ArrayPattern via isPattern(). But if you moved on to using isLVal  perhaps that takes care of it.
Do you have something you can push, even a rough draft?
Thanks!

That's great news @jmm :+1:
I will not have time to work on this before ~a week, so I quickly commited & pushed what I had last week: https://github.com/vhf/babel/commit/5a1144c3bf0e67f1c72e0d7ea7178cb19b3a3f11 , it's really not much but it does the trick (this commit comes with fixtures and passes the tests as far as I remember).
Please feel free to take what you like from it, don't worry about the commit it's all yours now!

@vhf Awesome, thanks! I'll take a look.

These are all ok with parens, right?:
(arguments.length <= 0 ? undefined : arguments[0]) in x;
for ((arguments.length <= 0 ? undefined : arguments[0]) in x);
for ((arguments.length <= 0 ? undefined : arguments[0]) of x);

This one is fine:
(arguments.length <= 0 ? undefined : arguments[0]) in x;

But these seem to be parse errors?
for ((arguments.length <= 0 ? undefined : arguments[0]) in x);
for ((arguments.length <= 0 ? undefined : arguments[0]) of x);

The left hand side of the for loop head needs to be an assignable LVal, I think. In my Node 4 shell I get ReferenceError: Invalid left-hand side in for-loop.

Oh, d'oh! Yeah, of course you're right. I was missing the forest for the trees here. I was trying to skim the grammar quick without thinking it through or checking the static semantics.

It is a Syntax Error if IsValidSimpleAssignmentTarget of LeftHandSideExpression is false.

Thanks @benjamn!

Again, thank you for this. This commit is now incorporated into https://github.com/babel/babel/pull/3375, so closing this.


Remove BuildTools dependency from source-build

I think this is reviewable.  My only expected change from here is code review and prebuilt baselines.
Major changes:

Upgraded Arcade scripts.
Removed 2.x bootstrap SDK.
Removed init-tools and associated cruft.
Some build tasks we use were never ported from BuildTools - for now, carrying these in our own tasks DLL.
We now use the stage1 ILDasm to disassemble references assembles and the stage1 ILAsm to re-assemble them.

Minor changes:

build.sh now calls into the Arcade scripts.
Cleaned up clean.sh.
Small patch in NuGet that removes a property that conflicts with Arcade.

@dagood - No worries if you're too busy, I just wanted to put you on this since you did a lot of this work to start with.


Layers_If_Then issue at STEP 2

When using If_Then, the Step1 Output folder looks exactly like the original If_Then folders (full of subfolders). For some reason STEP 2 requires the Output folders to be linier.
Pls see the image above. I received an error due to the missing "Body" Folder, which is hidden inside "Back" Folder
Error: ENOENT: no such file or directory, scandir 'C:\Users\Haris\Desktop\animated-art-engine-main\step1_layers_to_spritesheet\output/Body/'     at Object.readdirSync (node:fs:1442:3)     at getElements (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\src\main.js:156:6)     at C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\src\main.js:256:17     at Array.map (<anonymous>)     at layersSetup (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\src\main.js:249:30)     at startCreating (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\src\main.js:810:20)     at Command.<anonymous> (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\index.js:36:5)     at Command.listener [as _actionHandler] (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\node_modules\commander\lib\command.js:488:17)     at C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\node_modules\commander\lib\command.js:1227:65     at Command._chainOrCall (C:\Users\Haris\Desktop\animated-art-engine-main\step2_spritesheet_to_generative_sheet\node_modules\commander\lib\command.js:1144:12) {   errno: -4058,   syscall: 'scandir',   code: 'ENOENT',   path: 'C:\\Users\\Haris\\Desktop\\animated-art-engine-main\\step1_layers_to_spritesheet\\output/Body/' } make: *** [Makefile:9: step2] Error 1

Solved.
Inside config.js, We should only list the root layers. In my case, its only "Back".
const layerConfigurationsIfThen = [   {     growEditionSizeTo: totalSupply,     namePrefix: "", // Use to add a name to Metadata name:     layersOrder: [       { name: "Back" },     ],   }, ]

@jehuty27 glad you figured it out. I'll update the readme


Nodesettingstest - windows

I've removed the app/config symlinks from git index, instead I'm dynamically copying needed (default) configuration form the src/main/dist/config directory where it is needed (to app/config).
AFAIK, those symlinks' only purpose was to serve as default configuration for these NodeSettingsTests, so by copying them manually we achieve exactly the same goal, to have a "default" configuration for the tests.
Please let me know if this solution is OK for you guys or if you have a better one!
Thanks

Here the core build seems to be failed with following messag:

What went wrong:
Cannot expand ZIP '/home/travis/build/crate/crate/core/build/classes/shared' as it is not a file.

Also the :docs:itest failed!
Like mentioned in #1642, if you haven't done so already, please dedicate a wiki place or similar where we could keep track of those "flaky" tests and issues

Coverage decreased (-0.0%) to 81.47% when pulling 55c252db5c636281e4cf7b67c6fc9573ca992051 on senchi:nodesettingstest into 7acf5671e931422834919180b9d38726fd7b70fc on crate:master.

I think it would be okay to just copy crate.yml and logging.yml directly instead of the whole directory tree.

OK, I've changed the code now to copy those two files specifically.
Thanks

Closing this since it got outdated.


Add license field in package.json

This pull request get rid of the warning you get when running npm install.
npm WARN<EMAIL_ADDRESS>No license field.

This has been merged into dev (see 4adc1c6).


:memo: Add a complete example on TLS Store with Cert-Manager

What does this PR do?
Add a complete example on TLS Store with Cert-Manager
Motivation
Users still have hard time to configure it. Last seen here.

I have lose some hours with this issue: https://github.com/traefik/traefik-helm-chart/pull/601#issuecomment-1379608172
Maybe u can add a note about this for save others ^^
I have fix this with: kubectl label -n <traefik_namespace> tlsstores.traefik.containo.us default environment=production,method=traefik
environment=production,method=traefik is to be replaced by what u set in kubernetesCRD labelSelector in values.yaml


nitro spoof no longer starts on latest canary

title explains itself, im on both latest replugged and canary at the time of writing this

cannot reproduce on latest canary and latest replugged

can be related to discord update, try update replugged

seems like the latest replugged update fixed this problem? very strange


TS branch intial release

initial TS branch but perhaps on a different branch would be better ?

I gave this a bit more thought. I appreciate the work done here, but I want to properly manage the changes introduced as I release certain versions. The changes in this PR provide much more than the original changes requested in the "feat/modules" issue, such as linting preferences and dependencies used. Therefore, I just create a feat/ts branch here and I think it'd be more appropriate to submit the PR to there, instead of this branch.
My plan will be to take the small parts of this branch that allow the modules feature to work, test release that, and then in a following release cycle, consider the remaining changes provided in the feat/ts branch. This way, it's easier to manage changes.
Also, not sure if people know this but they can npm install from github, so if there are people who want to try the feat/ts stuff, they can simply do: npm i username/repo#branchName
(So, I'm closing this one with the hopes that the subsequent one is re-opened to feat/ts, which I'll approve because I like the changes)


go/doc: extracted example function doesn't work when package name shadows pre declared identifiers

What is the URL of the page with the issue?
https://pkg.go.dev/github.com/ocfl-archive/error/pkg/error#pkg-examples
What is your user agent?
Chrome
Screenshot

What did you do?
Created an example test for the package error.
What did you see happen?
Conflict in pkg.go.dev with the type error. Locally, the tests pass, and there's no conflict with the error type.
What did you expect to see?
Local and pkg.go.dev capabilities align, either with the error being caught locally in the go compiler, or the package running as expected in the go doc examples.

Naming a package that shadows a builtin type just seems like a bad idea?

Naming a package that shadows a builtin type just seems like a bad idea? it's essentially unusable in most go code without renaming the import.

Absolutely! We'll take a look at renaming it but we're using a compiled language and not an interpreted one. I don't think the solution is "don't do that". Code does compile, and tests do pass. Ideally it fails sooner, or continues to pass later.

NB. I haven't tried this @seankhliao but I assume this issue name could reflect the issue when shadowing any builtin type?

Your example defines a main package, but that main package doesn't import your package.  If you add the import, then I think your example will work.

Your example defines a main package, but that main package doesn't import your package. If you add the import, then I think your example will work.

I will give that a whirl Ian.
Do you agree though that the issue is more about the divergence between the promise of local testing of examples, and when they arrive in the go pkg docs? (either a website feature, or again, something that should be improved locally?)

I'm not sure I entirely understand, but I don't think I agree.  Your example as written doesn't quite make sense, because it doesn't import the package that it is testing.  Note that unlike other tests, examples, should not be in the same package as the code that they are showing examples for.

unlike other tests, examples, should not be in the same package as the code that they are showing examples for.

I used this blog as reference https://go.dev/blog/examples and followed examples to the sort package. What am I missing @ianlancetaylor? do you have any references or guides that support your assertion?

As I understand, go/doc would extract examples and mutate them into complete main programs when put into files without other examples (ref go/doc.playExample). As a working example, from go-json-experiment, the examples declared in package json_test are rendered as package main.
go/doc skips resolution of all predeclared identifiers here https://go.googlesource.com/go/+/caee788a48f19814bd778c1bd2422cb6f60ad810/src/go/doc/example.go#197
Personally, I don't think we should change anything, and discourage shadowing predeclared identifiers.

I don't think we should change anything, and discourage shadowing predeclared identifiers.

From a Ux perspective, removing run from the docs for non-compliant examples would at least be something, no?

discourage shadowing predeclared identifiers.

This doesn't feel like a sustainable strategy for a growing ecosystem and increasing number of learners. The idea of discouraging without tooling is quite folksy. Again, we're working in a compiled language here not one with duck-typing. Go.mod has a strategy to warn about ambiguities, could that be implemented for examples and docs?
Without more insight into the strategy of the go team, as an outsider, there's a workflow promise here, you can write your examples, they will test locally, and run in the docs. Again, it's more Ux than anything, but it should be clear as early as possible something won't work when pushed. And so, from an dev ergonomics perspective, I would anticipate early warning.

Thanks for the info on #9679

It should have been fairly obvious in any non trivial use of the package that it had an unsuitable name

I'm not here to beef @seankhliao. I think we can agree to disagree on this. I believe I've mentioned some fairly fundamental reasons, trivial or otherwise.

There has never been a promise that locally running examples will run in the docs

By promise, I mean it's the interface/de-facto functionality given by the language to the user, my prrimary reference: https://go.dev/blog/examples. If there are better sources folks are referring to, then I appreciate the links.
But again, I'm not here to beef. In fact, it already seems like there's clarity in this thread that can be brought to some part of the ecosystem in some way.

@ross-spencer Sometimes things that seem clear to the maintainers are less clear to people less familiar with the tooling.  Since examples should be usable, they should refer to names exported by the package as packagebeingtested.Name.  And that means that they should import that package.
Would you like to send a patch to the testing package, and perhaps the blog entry, to make this clearer?  Thanks.

Thanks @ianlancetaylor I can endeavor to take a look!

Is the fix to delete the code line pointed to in https://github.com/golang/go/issues/70611#issuecomment-2508942996 ?
That is, this for loop? https://go.googlesource.com/go/+/caee788a48f19814bd778c1bd2422cb6f60ad810/src/go/doc/example.go#196
I think that's what @ianlancetaylor is suggesting here: https://github.com/golang/go/issues/70630#issuecomment-2513491664

that loop needs to move after the loop that checks imports (line 252)

Retitled based on my cursory understanding. IIUC, we need clearer documentation of the requirements for runnable examples. If so, a contribution from someone with fresh eyes would be helpful here.

I felt https://github.com/golang/go/issues/70630#issuecomment-2513491664 was suggesting this was actually a bug and not a documentation thing.


Minor rework of stub_server_settings_with_locale to deal with strict partials

Currently the locale_resolver_spec.rb file has multiple failures when run with strict partial verification turned on. This is because of Settings.server which returns a Config::Options object, which is something that uses method_missing extensively behind the scenes.
What happens in practice is that because the locale method isn't predefined, it fails a respond_to? check, which in turn makes rspec unhappy. The solution is to simply define locale when Config::Options is instantiated, and modify the allow to return that object instead.

@miq-bot add_label test, refactoring, changelog/no, hammer/no

@miq-bot add_reviewer @kbrock

Note there are shared support for stubbing server settings, and this method should probably be replaced with that one. - https://github.com/ManageIQ/manageiq/blob/master/spec/support/settings_helper.rb

@Fryguy I'm not seeing how to use those here, you'll have to show me how it's done.

There are lots of examples if you git grep stub_settings spec, but offhand, you would change the callers from stub_server_settings_with_locale(locale) to stub_settings(:locale => locale)

@Fryguy Thanks, updated!


Service_HTTPS should not require ServerTLS to give an option for SSL Passthrough

ISSUE TYPE

Feature Idea

AS3 BUILD/ VERSION
All AS3 Versions

BIGIP VERSION
All Supported BIG-IP Versions

SUMMARY
Client request one service declaration for https service that creates http redirect without ssl offload just ssl passthrough

STEPS TO REPRODUCE
Try to use https offload template with service_https and the redirect80 but do not provide certificate, receive an error that certificate required.  Create template only using Service_https and receive error TLSServer required.  Use Service_http and there is no redirect80 option.

EXPECTED RESULTS
Use one declaration to create 443 virtual server and port 80 redirect virtual server without SSL profiles.

ACTUAL RESULTS
Have to create two declarations. One for port 80 virtual and attach redirect iRule.  Create second for 443 virtual without SSL profiles.

You do not need two declarations.  In a single Application of type=generic, place both the 443 service (without any TLSserver profile) and the 80 service to which you attach the /Common/_sys_redirect_https iRule.

So that is what we ended up looking into, however it appears that there is the ability of attaching an http profile to the generic_service template. Is this what the profileIPOther (Pointer_IP_Other_Profile), is used for?
https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/refguide/schema-reference.html#service-generic
From: markchart<EMAIL_ADDRESS>Reply-To: F5Networks/f5-appsvcs-extension<EMAIL_ADDRESS>Date: Thursday, October 17, 2019 at 3:17 PM
To: F5Networks/f5-appsvcs-extension<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [F5Networks/f5-appsvcs-extension] Service_HTTPS should not require ServerTLS to give an option for SSL Passthrough (#169)
You do not need two declarations. In a single Application of type=generic, place both the 443 service (without any TLSserver profile) and the 80 service to which you attach the /Common/_sys_redirect_https iRule.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

"declaration": {
  "class": "ADC",
  "schemaVersion": "3.0.0",
  "id": "urn:uuid:ca5fbd08-8205-044a-1159-9e8a19ed0077",
  "label": "redir_example",
  "remark": "TCP on 443 for passthru-HTTPS without TLS offload, redir on 80",
  "redir_example": {
    "class": "Tenant",
    "A1": {
      "class": "Application",
      "template": "tcp",
      "serviceMain": {
        "class": "Service_TCP",
        "virtualAddresses": [
          "<IP_ADDRESS>"
        ],
        "virtualPort": 443,
        "pool": "svc_pool"
      },
      "redirect80": {
        "class": "Service_HTTP",
        "virtualAddresses": [
          "<IP_ADDRESS>"
        ],
        "virtualPort": 80,
        "iRules": ["ir_redirect"]
      },
      "ir_redirect": {
        "class": "iRule",
        "iRule": {
          "bigip": "/Common/_sys_redirect_https"
        }
      },
      "svc_pool": {
        "class": "Pool",
        "members": [{
          "servicePort": 443,
          "serverAddresses": [
            "<IP_ADDRESS>",
            "<IP_ADDRESS>"
          ]
        }]
      }
    }
  }
}

Oh this is confusing here, why did you move away from generic to tcp? I agree this could work, curious on the why

I just grabbed an AS3 example to tweak a little for you, and the first suitable one I found used template tcp.  There's nothing more to it-- generic would work just as well.  I mentioned generic above just because I was thinking about how it doesn't presume a serviceMain of any type, so you wouldn't be forced to supply anything you didn't want as with https.

@jmcalalang Does the work-around provided by @markchart work for you? Can we close this issue?

Yeah, its what I already had, you can also use two service_http classes to make the same thing happen. The desire was to have less domain knowledge about how to set up all these workarounds, and a more straightforward mechanism to build a single service in AS3 that could reference the redirect irule attribute; like the service_https has inherently. We assume TLS in our systems is always offloading, so we alienated everyone that does SSL-passthrough with this class.
It almost seems like instead of having the service_https being the only option for the redirect, we also could use it in service_http
From: Daniel Stokes<EMAIL_ADDRESS>Reply-To: F5Networks/f5-appsvcs-extension<EMAIL_ADDRESS>Date: Tuesday, October 22, 2019 at 1:54 PM
To: F5Networks/f5-appsvcs-extension<EMAIL_ADDRESS>Cc: Jon Calalang<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [F5Networks/f5-appsvcs-extension] Service_HTTPS should not require ServerTLS to give an option for SSL Passthrough (#169)
@jmcalalang Does the work-around provided by @markchart work for you? Can we close this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Would be a bit of a design puzzle, since the desired TCP port 443 virtual server cannot have an HTTP profile unless it also has a TLS profile (since HTTP hudfilter doesn't grok encrypted data) so it wouldn't be a "Service_HTTP" and the average "Service_TCP" virtual server doesn't need or want an option to create a "redirect" virtual server on some other port with an HTTP profile and an iRule.
If there were a "no-TLS-offload" option for "Service_HTTPS" then it would have to disable HTTP as well as TLS (or attach an iRule to put every connection in pass-thru), at which point it isn't any kind of "Service_HTTPxxx" service really.  Hmmm.
There's also the question of what to do about HTTP/3 (QUIC).  Some future enhancement will have to deal with UDP+HTTP/3 (w/TLS1.3) and/or UDP-pass-thru as well as TCP+TLS+HTTP, TCP:80 redirect, and/or TCP-pass-thru.

Closing for inactivity. If you are still encountering issue, please reopen this ticket for a file a new one.


[BUG] Display correct message in sidebar view when there's only one project and it's deleted.

Describe the bug
In the sidebar if it's there only one project and it's deleted the view needs to be refreshed and display the initial welcome message that it's displayed when DDEV and Docker are running correctly but there are no projects. "DDEV is ready and running. Start by adding your first project."
This issue does not affect the functionality of the extension
To Reproduce
Have only one project In the sidebar and delete it.
Expected behavior
The welcome view should be displayed if there are no more projects.
System (please complete the following information):

OS: macOS Ventura
DDEV version: run in terminal ddev --version
Docker provider: Orbstack
VSCode version: v1.22.1
DDEV Manager version: 1.1.0

Fixed, will be included in the next update.


Controversial: Allow parameter values to be obtained along with query string

Issue #6482
var parameters = new Dictionary<string, object>();
var queryString = queryable.ToQueryString(parameters);

Not 100% convinced we should do this. Here's my thinking:

This can be useful for diagnostics/testing by providing the parameter values in a machine-readable, non string converted form. For example, imagine a profiling tool that can read the dictionary and make the parameter values available to run perf testing, get query plan, etc.
On the other hand, this could be used by people who want to use EF only to generate queries which are then executing somewhere else. This is not a goal of EF and the queries may not run in some other context, so it could give a false impression of what EF is designed to do.
But if we don't do this publicly, then I think the discussion on #6482 indicates that people are going to continue to hack EF into doing it. This could end up being more painful than just supporting the feature.

@roji It's more controversial because it makes it even easier for people to abuse the API and use it for SQL execution in an application.

Notes from design meeting:

We will keep this API public and call it ToQueryString

We also discussed calling it ToDebugString, but that's less specific and discoverable. Also, other ToDebugString methods are internal.

We will not make this relational-specific

Non-relational providers may also have reasonable strings for their queries

We will remove the parameters--i.e. this PR

Instead #19335 can be used to get the parameters for relational providers
This also allows all parameter facets to be obtained

We will change the format of comments based on the suggestion here: https://github.com/aspnet/EntityFrameworkCore/pull/19324#issuecomment-566964716

However, this is SQL Server specific, so the format only changes for SQL Server
We will still use comments since this isn't actually SQL that EF would normally generate.

Superseded by #19368


Remove OS titlebar on Android

Version: 0.6.0
Android version shows OS titlebar which is annoying on mobiles with not much screenspace available to waste
Can get rid of it:
https://docwiki.embarcadero.com/RADStudio/Alexandria/en/Creating_an_Android_App#Making_Your_Application_Run_in_Fullscreen_Mode
Not sure what the behaviour is in that case on ChromeOS or other OS that can run Android apps. Probably would show the app in fullscreen instead of windowed if it is configured to not show the titelbar (value of the theme key set to No TitleBar at Project > Options > Version Info in Delphi)

note that on iOS one has to set BorderStyle = None to their forms
https://docwiki.embarcadero.com/Libraries/Alexandria/en/FMX.Forms.TCommonCustomForm.BorderStyle

doesn't seem to work even though using NoTitleBar theme on Android (seems it has a NoTitleBar-FullScreen variation - at least when searching with GrepWin for TitleBar in the code - that could be wrong)


Fix a bug where targets with multiple dependencies was only passed one dependency

Bug/issue #, if applicable: #97
Summary
This fixes an issue where the plugin would only pass one --dependency value when building combined documentation.
@sofiaromorales and I worked together on the initial fix and made some additional API refinements to the way that the plugin works with command line arguments to make it ensure that an option always has the same behavior at every call site and that an option can't accidentally be used as a flag or vice-versa.
After what Sofía and I worked on,  I made some follow-up changes to use the Flag and Option types in more places, move the inverseNames into Flag, and use CommandLineArguments for the docc merge arguments to avoid that direct [String] manipulation.
Dependencies
None.
Testing
Build combined documentation for a Swift package where at least one of the targets has more than once source dependency. For example;
Modify IntegrationTests/Tests/Fixtures/TargetsWithDependencies to depend on the local version of the plugin:
- if FileManager.default.fileExists(atPath: "../swift-docc-plugin") {
      package.dependencies += [
-         .package(path: "../swift-docc-plugin"),
+         .package(path: "../../../.."),
      ]
- }

Then, run swift package generate-documentation --enable-experimental-combined-documentation --verbose and inspect the build log.
The docc convert call for the "Outer" target (which builds last because it depends on the other targets) should have two different --dependency flags passed to it;

The absolute path to .build/plugins/Swift-DocC/outputs/intermediates/InnerFirst.doccarchive
The absolute path to .build/plugins/Swift-DocC/outputs/intermediates/InnerSecond.doccarchive

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
~[ ] Updated documentation if necessary~ Not applicable

Because we don't have a Swift 5.7 CI yet, I manually tested this with the swift:5.7-focal Docker image:

Swift version 5.7.3 (swift-5.7.3-RELEASE)
Target: aarch64-unknown-linux-gnu

@swift-ci please test


DEFAULT support

Please check https://github.com/3YOURMIND/django-pyodbc-azure/commit/5f705ff6395f9ed1d8b82ccf16cc90292a19c024
And now I realize that we also need to override the reverse.

And please check this blogpost for why it would be needed: https://medium.com/3yourmind/keeping-django-database-migrations-backward-compatible-727820260dbb

@mes3yd If this ends up being brought into Django core, this will likely be considered. Thank you!


ARROW-17222: [Docs][Archery][Integration] Document the current Integration test cases covered by archery

Suggested by @nealrichardson, it makes sense to have a documented section of what test cases are covered by Archery's integration tests so we know what is actually covered or not for future development. This will make it easier to make changes to the format in the future if necessary as we'll know what (if any) additional testing will need to be done and added to Archery.

@assignUser Thanks for the suggestions!


Run test transformation pipeline against updated dataset

Why
Relevant ticket
We have a test dataset provided by EBI. I have modified it to remove most of the data files and get a representative test case for import. We need to run our dataflow check against this dataset and check it against a set of known good outputs.
This PR

Placed the "slimmed" dataset into our test storage bucket at gs://broad-dsp-monster-hca-dev-test-storage/integration/ebi_small
Placed the output of a dataflow run at gs://broad-dsp-monster-hca-dev-test-storage/integration/ebi_small/expected_output.
Adds a simple script to diff the output of a test dataflow run and the expected output dir. As we modify the transformation pipeline (i.e., to accommodate schema changes), I expect the flow to be something like:

Modify transformation pipeline and ensure unit tests run
Test in dataflow and get output
👁  the output and if good, put it in the ebi_small/expected_output directory

I have not modified the validate-pull-request.yaml action to keep the scope of this PR down and to let us test out this testing  mechanism before introducing it more broadly.

TODO

[x] Ticket the follow-on to introduce this test in the validate-pull-request.yaml action

For posterity, the ticket to implement this flow in the validate-pr action can be found here


Issue with placing order

Hello!
I met incorrect behavior, but can't understand the reason.
The server returns "10007: symbol not support api " while placing order with pretty correct symbol,  like UNIUSDT, LINKUSDT and so on. Here is the url of the request as example (from logs) https://api.mexc.com/api/v3/order?price=3&quantity=1&side=BUY&signature=15C31EED17EA63F2411DB84969216FE61DC61A19378432194E8144A4F2C98917&symbol=LINKUSDT&timestamp=1723218702117&type=LIMIT
To Reproduce
Provide valid API-key to the MexcRestClient and try to place.
Expected behavior
successful response + placed order
Debug logging
2024.08.09 18:51:41:743 | Trace | Mexc | [Req 3] Sending GET  request to https://api.mexc.com/api/v3/time with headers Accept=[application/json], X-MEXC-APIKEY=[mx0vglndxhTN9im0j1], source=[EASYT]
2024.08.09 18:51:42:083 | Debug | Mexc | [Req 3] 200 - Response received in 335ms: [Data only available when OutputOriginal = true]
2024.08.09 18:51:42:088 | Information | Mexc | Spot Api Time offset within limits, set offset to 0ms
2024.08.09 18:51:42:093 | Information | Mexc | [Req 1] Creating request for https://api.mexc.com/api/v3/order
2024.08.09 18:51:42:123 | Trace | Mexc | [Req 1] Sending POST signed request to https://api.mexc.com/api/v3/order?price=3&quantity=1&side=BUY&signature=15C31EED17EA63F2411DB84969216FE61DC61A19378432194E8144A4F2C98917&symbol=LINKUSDT&timestamp=1723218702117&type=LIMIT with headers Accept=[application/json], X-MEXC-APIKEY=[mx0vglndxhTN9im0j1], source=[EASYT]
2024.08.09 18:51:42:492 | Warning | Mexc | [Req 1] 400 - Error received in 346ms: [ServerError] 10007: symbol not support api

Hi, this is because sadly the API is pretty restricted in what symbol it allows to be traded on. You can use restClient.SpotApi.ExchangeData.GetApiSymbolsAsync(); to check which symbols are available. For example BTCUSDT is not available, but BTCUSDC is.

Hi! Thank you for the response. You are right. The problem is in API restrictions.
Thanks again!


update docs

Hi
Thank you for this package!
Here an update to the documentation for recent code changes as the replace type renamed to substitute  in AlignmentChunk
https://github.com/jitsi/jiwer/blob/cc6cfb3f733bac9c101d28222eae95aef34b41a5/jiwer/process.py#L72-L73

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.


rails g authentication user --pwned

Implement integration with pwned, basically just add gem 'pwned' and validates :password, not_pwned: true to User

https://github.com/lazaronixon/authentication-zero/releases/tag/v2.5.0


Send the hash to tendermint

description will be added soon

@sbellem  @vrde The tendermint docs here describe that the commit should return a byte array which would be included in the header of the next block. So, I guess we could send the merkle root of the transactions included in the previous block?

Sounds good to me. Should we also add in the hash the merkle root of the previous block?

@vrde yes, I think that is good idea. Do we store the hash of the previous block ourselves or query it from tendermint?

I guess we should add a new collection to store this information. We will need to store something like:
{
    "height": "<int>",
    "app_hash": "<string>"
}

This information should be exposed by the info method.


bug: IonHeader above Ion Tabs when slot is top

Bug Report
Ionic version:
4.11.0 React
Current behavior:
When using the generated tab layouts, then setting the slot to top (to have the tabs at the top), any addition of a IonHeader causes it to overlap the tabs
Expected behavior:
Somehow, it would be possible to have a header above the tabs when the IonTabs slot is set to top
Steps to reproduce:
Take the generated tab app and do the following
Related code:
 <IonApp>
      <IonPage>
        <IonHeader>
          <IonToolbar>
            <IonTitle>Title of App</IonTitle>
          </IonToolbar>
        </IonHeader>
        <IonReactRouter>
          <IonTabs>
...

Ionic info:
Ionic:
   Ionic CLI       : 5.4.2
   Ionic Framework : @ionic/react 4.11.1

Hi @mccabemj,
It seems like part of your code sample got cut off. Could you update it or send an example repo?

Going to close as we haven't heard back yet. If the problem persists please post here


[Docs] document who can add labels to PRs

From https://github.com/flutter/flutter/wiki/Tree-hygiene

Once everything is green and you have an LGTM from the owners of the code you are affecting (or someone to whom they have delegated), and an LGTM from any other contributor who left comments, add the "autosubmit" label. A bot will land the patch when it feels like it.

Unless I'm missing something, contributors without write access cannot add labels to PRs. I think that should be made more clear in this paragraph because as it stands it sounds like that's the next thing I should do but I can't. Also beneficial to mention would be who to ask to add the label and where (in the PR, on Discord ect.)

Fixed.


⚠ Thumbnails API Endpoint has degraded performance

In ec0b9cb, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5575 ms

Resolved: Thumbnails API Endpoint performance has improved in a0e27bb after 38 minutes.


Deployment Failed: Failure during content distribution.

Hello! Our deployments are suddenly failing with an unclear error message:

Only thing that changed was that there's now much more content than before, now about 350MB.
Any idea what could be causing this?

@tuube Did you figure this one out? I get the same msg

Yes we did, forgot to mention here 🤦.
The trick was to "sanitize" our created pages' paths.
Before we had paths with non-ascii characters like: "/koskâvuotâ/ohtsâškoodán-päikkikuávlu-mun-tiäđám",
which were changed to: "/koskavuota/ohtsaskoodan-paikkikuavlu-mun-tiadam".
After that the deploys started working

@tuube ok, thanks. Seems like there's been an Azure bug that has been fixed lately


[AKS] update list of supported VM sizes

Updates the list of VM sizes supported by the AKS service to match reality.
Closes Azure/azure-sdk-for-python#2150
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-node

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Automation for azure-libraries-for-java


Error "required" is displayed for the safe name when Add safe is opened

Description
Error "required" is displayed for the safe name when Add safe is opened
Environment

Browser: chrome
Wallet: MetaMask
Safe: any
Environment:

https://pr2535--safereact.review.gnosisdev.com/mainnet/app/#/load

Steps to reproduce

Go to https://pr2535--safereact.review.gnosisdev.com/mainnet/app/#
connect wallet and click load existed safe
Current result: Required error is displayed for the safe name field by default

Expected result
No error in the safe name field by default
Screenshots

Probably introduced in #2495.
Possibly this particular line (a new key prop).


Add reference to hybrid mmap extensions setting in k-NN

Fixes #2886
Checklist

[x ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski Could you please review this PR for technical accuracy? Also, which versions of the documentation does it make sense to backport this PR to? Thanks!

@martin-gaievski Which versions does this apply to? Thanks!

@martin-gaievski Which versions does this apply to? Thanks!

All versions starting from 2.5.0 and above.


williams_pp1 has indenting problems and fails pylint.

https://github.com/RsaCtfTool/RsaCtfTool/blob/81fd4acb9c78334a51e9638d24f4e3e5447241eb/attacks/single_key/williams_pp1.py#L22
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/matt/RsaCtfTool/attacks/single_key/williams_pp1.py", line 22
    if e == 0:
IndentationError: unexpected indent

Additionally partial_q.py @ 104 has an unreferenced "d" object on PublicKey

Hi, thanks for reporting, I'll be fixing this as soon as I can.

Have made a pull request now

fixed partial_q


Add Stateless

Let said we have a AppState that need an optional stateless Child (Store<Void, ChildAction>) , that will shown/hide using IfLetStore
struct AppState: Equatable {
  	var childState: Void?
}

We can't make that Void because Void is not Equatable.
So This PR is adding a helper Stateless struct that contains no property but it is Equatable
struct AppState: Equatable {
  	var childState: Stateless?
}

So you can do this now:
IfLetStore(
  store.scope(state: \.childState, action: AppAction.child).stateless,
  then: ChildView.init(store:),
  else: { Text("No Child") }
)

Open for any input 🙏🏻

Using a simple Bool for AppState wouldn't be a simpler option in this case?

Using a simple Bool for AppState wouldn't be a simpler option in this case?

Isn't ifLet differentiate only from nil and not-nil?

Yes, but you can use the Bool directly like
if viewStore.childState {
  ChildView(store: store.scope(state: { _ in () }, action: AppAction.child))
} else {
  Text("No Child")
}

Yes, but you can use the Bool directly like
if viewStore.childState {
  ChildView(store: store.scope(state: { _ in () }, action: AppAction.child))
} else {
  Text("No Child")
}

oops I forget we can do that in SwiftUI..
Thanks @tgrapperon
Actually, I create this helper for the UIKit world, because I need to listen every change of that state, that's why in UIKit I need the IfLet

Here is the simplified code of the usage.
class ParentVC: UIViewController {
	private var myChildView: ChildView?

	private let store: Store<AppState, AppAction

	init(store: Store<AppState, AppAction) {
		self.store = store
		setup()
	}

	func setup() {
		store.scope(
			state: \.childState,
			action: AppAction.child
		).ifLet(then: {
			// add ChildView
			self.myChildView = ChildView(store: $0.stateless)
			self.view.addSubview(self.myChildView)
		}, else: {
			// remove ChildView
			self?.myChildView = nil
			self?.setNeedsLayout()
		})
	}
}

class ChildView: UIView {
	private let store: Store<Void, ChildAction>

	init(store: Store<Void, ChildAction>) {
		self.store = store
		super.init()
	}
}

@jeffersonsetiawan Thanks for the discussion and sharing your idea! Given that you've solved it using @tgrapperon's suggestion I'm going to close this, but if you have more you'd like to share since first opening this PR, please feel free to start a GitHub discussion!


CU 4/21

Thanks for the submission! The current output reflected (already succeeded in merging into main repo) your submission is:
https://hopkinsidd.github.io/rsv-forecast-hub_website/


XMLHttpRequest cannot load

Chrome dev console:
XMLHttpRequest cannot load http://api.openweathermap.org/data/2.5/weather?q=groningen&units=metric&lang=en&mode=json&APPID=XXX. A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true. Origin 'http://localhost:8080' is therefore not allowed access. The credentials mode of an XMLHttpRequest is controlled by the withCredentials attribute.

Code (VueJS):
import Weather from 'openweather-apis'

Weather.setLang('en')
Weather.setUnits('metric')
Weather.setCity('Groningen')
Weather.setAPPID('XXX')

Weather.getTemperature(function (err, temp) {
    if (err) console.log(err)

    console.log(temp)
})

I did some testing and it looks like this can be fixed by adding withCredentials: false to the request options.


Add integration tests

See #22

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #25   +/-   ##
=======================================
  Coverage       100%   100%
  Complexity      114    114
=======================================
  Files            22     22
  Lines           289    289
=======================================
  Hits            289    289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b24d91...5309a39. Read the comment docs.


Make meta_data_key a kwarg

This allows for pandas formatting of other functions such as WTI

These fails seem to be to do with sorting the index, which would seem preferable. Unless there's a reason to not sort?

Good work, thanks a lot!


Test-ElevationRequirement - fixed continue

Type of Change

[x] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Pester test is included

Purpose

Fixes Test-ElevationRequirement not correctly calling continue as intended

Thank you, kind sir! 🍥


login screen: browser back breaks login

When logging in and using "browser back" (instead of the button) the frontend does not "go back". Instead the password screen is shown again. After inserting the password, another password screen is shown.

steps to reproduce:

to go login page
enter email
click next
on password enter screen, use browser back (you'll land on the password screen instead of the email screen)
enter password (and land on the password screen again)

we improved the login flow, added some back and cancel buttons where needed,
because we calculate login flow in the application you cant always go back. in this cases next logical step is rendered, (eg after mfa setup done, you cant go back to setup again, in this case you get to the verify otp step)


Accessibility issues in React Aria library

Provide your feedback here.
I have just taken a quick look at your React Aria release. The web dev industry is badly in need of a robust, fully accessible and WCAG-compliant React component library and, when I saw your offering, I hoped that you had done just that. Sadly, it does not look to me that you are achieving it yet, though with a little work you can make it so.
As an accessibility auditor and consultant, I am finding numerous accessibility issues in it. None that are too serious as to make things inoperable to disabled users (at least I've found none so far), but enough to stop me recommending this library to anyone. And ones which, accessibility audits are done of websites created by your customers using this tool, will cause accessibility consultants doing the audits to fail or at least call out various components. (That will require your customers to have to amend components themselves in situ, or enter in to tedious correspondence with your team to get you to resolve the issues. I.e. time wasted for all concerned.) And it will cause loss of confidence in your library.
For instance:

Your toggle Button is marked up in the HTML as a link, not a  element, a very common mistake made by developers and one which many accessibility auditors, including myself, will raise as an issue. This will cause screen readers to announce them as links instead of buttons, which will be confusing to many blind people.
Your table component uses ARIA roles, even though it already uses the correct HTML elements of table, th  and td. The first Rule of ARIA is, don’t use ARIA when you can use valid HTML, so you should follow that and remove this ARIA. It will alter the announcements that some screen readers make.
Your Calendar component has given the month/year text, shown to sighted users on the top row of the calendar, an aria-hidden=”true” attribute. This will hide it from screen reader users completely. Why would you want to hide displayed text from blind people – they want to hear the same information that sighted users are given. I appreciate the next line of HTML, a div with the role “application”, has that information in it; nevertheless there is no need to hide the displayed text. The “application” in this case is a calendar, not a particular month, so the ARIA label should say “Calendar” to tell blind people exactly what component they have found – a calendar with many months and years, not just a widget for a single month.
Also the next month and previous month arrow buttons in the Calendar have ARIA labels of just Next and Previous. Next what? – sighted users can see and immediately deduce what they are referring to, from their location on screen etc, but blind people need better context. Re-label these buttons “Next month” and “Previous month”.

These are just a few points that occur to me from just a very quick look, and I am sure there are others waiting to be found. I do suggest you tighten up on things like these to avoid your customers having your components failed or called out in professional accessibility audits. That will save them unwanted work, and avoid repeated queries to your team from your customers.
🔦 Context
This will affect disabled people trying to use websites created using your library. And I would like to see a robust, fully accessible and WCAG-compliant React component library, one that I can recommend to people in the accessibility industry, and to React developers generally.
💻 Code Sample
No response
Version
any
What browsers are you seeing the problem on?
Firefox
If other, please specify
No response
What operating system are you using?
MS Windows 10

Thanks for your feedback. I would recommend testing with real assistive technologies rather than simply looking at the DOM. Many of the things you cited were specifically done to work around issues found when testing on various devices or to improve the user experience with AT.

I'm not seeing the toggle button link issue you mention. It's a button element with aria-pressed, following the ARIA pattern. I did a quick test with VoiceOver and it announced as a toggle button.

The Table component is an interactive grid, not a simple table. It supports things like sorting, keyboard navigation, row selection, etc. This requires use of the grid role rather than a plain table which is defined as non-interactive.

The visible month text is aria-hidden because there is an additional visually hidden duplicate at the start of the calendar. This ensures that it is the first element in the calendar even if the next/previous buttons are visually first. That helps mobile screen readers such as VoiceOver on iOS which will not navigate or announce the aria label for the whole grid. This way users get the context immediately when swiping to the calendar. Our blog post includes more details about this including a video of the mobile screen reader experience.

Agreed this could be improved. The exact amount of dates that the next/previous buttons advance may also differ so it isn't always by month.

We certainly take testing pretty seriously and the components have also been included in audits as part of our products, but please let us know if you find other issues when testing with real AT!


add new layout option for A+C+S+R regardless of screen aspect ratio

This adds the ability to always see the A+C+S+R panels, but must disable time series, and colorbar rendering if we force the 3D view in the bottom left quadrant of the canvas
@neurolabusc, Can you handle implementing this? Similar to the view option already present in MRIcroGL

Upcoming PR will include boolean option multiplanarForceRender


cannot generate the model

Hello,
i'm trying to do make with default schema without success
Generating model based on schema schemas/ovn-nb.ovsschema
github.com/amorenoz/ovsdb-mon/model
model/model.go:14:33: undefined: model.ClientDBModel
model/model.go:15:15: undefined: model.NewClientDBModel
make: *** [Makefile:22: build] Error 1
go version go1.20.3 linux/amd64
Can you give me some help,
Regard,
Nicolas

Hi Nicolas, maybe you have installed a different version of modelgen via go install? Please try removing it rm $(which modelgen) and running make again.

Yes you're right.
I got the main branch of libovsdb
Thanks
Le lun. 10 avr. 2023 à 10:31, Adrián Moreno @.***> a
écrit :

Hi Nicolas, maybe you have installed a different version of modelgen via go
install? Please try removing it rm $(which modelgen) and running make
again.
—
Reply to this email directly, view it on GitHub
https://github.com/amorenoz/ovsdb-mon/issues/37#issuecomment-1501551654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMCNUBOW5SQCLAONQU2VZTXAPAMPANCNFSM6AAAAAAWXK3BPM
.
You are receiving this because you authored the thread.Message ID:
@.***>


remove platform from kustomize.go

kustomize.go should not make assumption of platforms

This change is

/approve


Update README.md

Improve README.md file

Assign this task to me

Assign this task to me

Sure i will assign you.You just have to comment on new same issue as this is not valid as this is created before 15 feb


PDF does not show version number.

The PDF version of the site does not show a version number; it just says "Release python".

it will once the versions (both language and common) get tagged after this round of documentation is done and we do the build-all build.


warehouse_ros: 0.9.5-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository warehouse_ros to 0.9.5-1:

upstream repository: https://github.com/ros-planning/warehouse_ros.git
release repository: https://github.com/ros-gbp/warehouse_ros-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.1
previous version for package: 0.9.4-1

warehouse_ros
* Drop compile option -std=c++11 (C++11 or later is default anyway) (#92 <https://github.com/ros-planning/warehouse_ros/issues/92>)
* Remove user-provided constructors and destructors (#51 <https://github.com/ros-planning/warehouse_ros/issues/51>)
  ``ResultIterator::metadata_only_`` is now non-const to allow moving and assigning
* Add virtual destructor to ``MessageCollectionHelper`` and ``ResultIteratorHelper`` (#50 <https://github.com/ros-planning/warehouse_ros/issues/50>)
* Contributors: Bjar Ne, Jochen Sprickerhof

Sure, will do.


Lazy Loading

Fixes #15
Fixes #21

This change is

Reviewed 15 of 16 files at r1.
Review status: 15 of 16 files reviewed at latest revision, 2 unresolved discussions.

iron-data-table.html, line 380 [r1] (raw file):
Docs missing.

iron-data-table.html, line 390 [r1] (raw file):
Docs missing.

Comments from the review on Reviewable.io

Review status: 14 of 16 files reviewed at latest revision, 2 unresolved discussions.

iron-data-table.html, line 380 [r1] (raw file):
Done.

iron-data-table.html, line 390 [r1] (raw file):
Done.

Comments from the review on Reviewable.io


Azure & embeddings : The embeddings operation does not work with the specified model

I use Azure OpenAI API like this in my project:
import { OpenAIEmbeddings } from "langchain/embeddings/openai";

const embeddings = new OpenAIEmbeddings({
   azureOpenAIApiKey: "YOUR-API-KEY", // In Node.js defaults to process.env.AZURE_OPENAI_API_KEY
   azureOpenAIApiInstanceName: "YOUR-INSTANCE-NAME", // In Node.js defaults to process.env.AZURE_OPENAI_API_INSTANCE_NAME
   azureOpenAIApiDeploymentName: "YOUR-DEPLOYMENT-NAME", // In Node.js defaults to process.env.AZURE_OPENAI_API_DEPLOYMENT_NAME
   azureOpenAIApiVersion: "YOUR-API-VERSION", // In Node.js defaults to process.env.AZURE_OPENAI_API_VERSION
});

This error will appear: The embeddings operation does not work with the specified model, gpt-35-turbo. Please choose different model and try again. You can learn more about which models can be used with each operation here: https://go .microsoft.com/fwlink/?linkid=2197993.

Can you global search for gpt-35-turbo in your code? There should be a dot between 3.5 and I don't see it anywhere in the OSS package.

Thank you for your reply, it should be because of the model set up by the Azure API.


Align master with release 5.0.1

Current prod' version is 5.0.1

Outdated, master is now at 6.1.2.


Updated data.json

This looks good, did you mean to close this?

This looks good, did you mean to close this?

This looks good, did you mean to close this?

Ya ya, it was not passing the Prettier check for some reason.

This looks good, did you mean to close this?

Ya ya, it was not passing the Prettier check for some reason.

Ok. Btw for future reference you can update PRs, but pushing commits to the same branch and GitHub will update the PR

Ok. Btw for future reference you can update PRs, but pushing commits to the same branch and GitHub will update the PR

Ok. Btw for future reference you can update PRs, but pushing commits to the same branch and GitHub will update the PR

Ohh, okay learnt that now. Thanks !

Ok. Btw for future reference you can update PRs, but pushing commits to the same branch and GitHub will update the PR

Ohh, okay learnt that now. Thanks !

no problem 🤓

no problem 🤓


Backup/Restore process has a java issue/exception but still completes.

When you backup a config, then deploy this docker image from scratch you can on first login to the web page choose restore.
If you do this, and restore, the docker stops after restoring but throws an error. If you then start it again then it functions correctly and has restored..
I believe the image should start itself up again automatically but is not doing so. Is this an error that Unifi has to fix?
Error:
https://upload.forums.unraid.net/live/monthly_2023_11/image.png.34a982977c9807987f2d00316da6fed7.png

Just want to confirm this is a unifi issue :)

Linux Server was using a automated task to handle it when it was running unfi made database similar to redis / mysql. the ubiquity group no longer wanted to support their own database and opted to follow the mongdb database as it handle the same request.
As such the previous automation with linux server and how the database was to be handled didn't have a export nor option to use the MongoDB database. That was Linux IO way to EOL the docker.
Its more on ubquity not wanting to manage and maintain the database and has licensed mondb with a lifetime suport on version 3.6
https://www.reddit.com/r/Ubiquiti/comments/16d6rpq/unifi_still_requiring_mongodb_36_is_again/
https://community.ui.com/questions/Supported-Mongodb-version-is-EOL/6a97712b-2a58-4d96-8733-14b18c3ca063
My understanding is that unifi support license expired, they tried to make a DB jump and failed. Then went back to mongodb
During this time unfi removed the built in mongdb from with in the unifi package. Hence, we now install mondb on the side and maintain it from mongdb release cycles.


$replace rules applied to HTML prevents document level exceptions

How to reproduce:
Add @@||forums.overclockers.ru^$document and open forums.overclockers.ru source.
$("body").html line is removed

$generichide and $elemhide exclusion also is not working in this case, forums.overclockers.ru##body still works.
AdGuard 6.2.437.2171

The problem is still present.

Use $document,important

replace rules and basic rules are now matching separately

They do


[BD-46] feat: refactoring design tokens folders structure

Description

Ensure the global, alias, and component tokens defined in ./tokens/src/core/ are not specific to a particular theme variant (i.e., light or dark).
Ensure the global, alias, and component tokens defined in ./tokens/src/themes/light/ are only related to style properties relevant to a light theme variant (most likely color tokens).

Issue: https://github.com/openedx/paragon/issues/2017
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[x] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @PKulkoRaccoonGang!
When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.

:tada: This PR is included in version 21.0.0-alpha.15 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 22.0.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Moved XMLHttpRequest calls to helper file

Cleaned up collaborative editing code

Pull Request Test Coverage Report for Build 1593

4 of 35 (11.43%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.001%) to 24.325%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/workspace/ControlBar.tsx
1
14
7.14%

src/components/workspace/collabEditing/helper.ts
3
21
14.29%

Files with Coverage Reduction
New Missed Lines
%

src/components/workspace/ControlBar.tsx
2
12.82%

Totals

Change from base Build 1592:
0.001%

Covered Lines:
1178

Relevant Lines:
4041

💛  - Coveralls


Notifications on actions

A global actionNotification = notification config entry is required to send notifications one time on any action taken.

I'd vote for default on.

Also, haven't tested this yet, but are automated actions excluded (i.e autoclosed by bosun)

Not sure I understand the config:
[kbrandt@grove: ~/src/bosun.org/cmd/bosun] go generate && go run main.go -c kdev.conf -dev -q -r -w -dev
2015/05/14 17:04:03 conf: kdev.conf:57:0: at <actionNotification =...>: notification not found: notification

I have actionNotification = notification on a line by itself in the config....

@kylebrandt it expects the name of a notification there. My fault for poorly wording that.

Yes, only actions through the web interface get notifications. Auto-close won't fire it.

@captncraig @gbrayut and I chatted some more. I suggested that we continue with the plan of notifying any notification that corresponds to warn/crit. However, we include a notification level directive that says "No Action emails". So if someone has a contact for say SMS, they can exclude those within the notification directive.

Minor changes. Otherwise LGTM.


how disable pan/zoom not using setMouseNavEnabled

story:
I must disable pan/zoom on canvas-press by some logic
And must enable pan/zoom after canvas-release
The only solution that I found is setMouseNavEnabled(but this turn off handle canvas-release).
To handle canvas-release:
MouseTracker.releaseHandler:
if (!this.viewer.isMouseNavEnabled()) {
    this.onCanvasRelease(evt);
}

and it works, but may be I can use native solution?

viewer.panHorizontal = false;
viewer.panVertical = false;
should do the trick in your case.

@sevaTechoPark
When version OpenSeadragon 3.0.0 is released you can do something like this:
    let disablePanZoom = false;

    viewer.addHandler('canvas-press', (event) => {
      disablePanZoom = true;
    });

    viewer.addHandler('canvas-release', (event) => {
      disablePanZoom = false;
    });

    viewer.addHandler('canvas-click', (event) => {
      event.preventDefaultAction = disablePanZoom;
    });

    viewer.addHandler('canvas-drag', (event) => {
      event.preventDefaultAction = disablePanZoom;
    });

    viewer.addHandler('canvas-scroll', (event) => {
      event.preventDefaultAction = disablePanZoom;
    });

    viewer.addHandler('canvas-pinch', (event) => {
      event.preventDefaultPanAction = disablePanZoom;
      event.preventDefaultZoomAction = disablePanZoom;
      event.preventDefaultRotateAction = disablePanZoom;
    });

You can try it now by building off the master branch here or there's test builds here


add CORS header to 419 error codes

@elipapa commented on Wed Sep 06 2017
the 419 response does not add 'alllow-cross-origin' headers at the moment.

@emepyc commented on Wed Sep 06 2017
I suppose this is also true for other error codes like 429 (too many requests), it would be nice to add the header to any response from the api

@elipapa commented on Wed Sep 06 2017
@apierleoni and I looked at the code and it seems that this applies to 419
only, since we create a specific exception for that. The others should
work.
Does 429 cause the same?
On Wed, Sep 6, 2017 at 4:06 PM, Miguel Pignatelli<EMAIL_ADDRESS>wrote:

I suppose this is also true for other error codes like 429 (too many
requests), it would be nice to add the header to any response from the api
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opentargets/rest_api/issues/98#issuecomment-327513606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG34sYicSowgDV8UEwzAhWmbbmJgXuvks5sfrUJgaJpZM4POhKt
.

@emepyc commented on Wed Sep 06 2017
Ah ok. No, I was assuming that all custom errors where lacking the CORS header.
Thanks for looking into it

@apierleoni commented on Wed Sep 06 2017
The problem is just for unhandled errors like 419 and 429 that flask does not understand

@elipapa commented on Tue Nov 07 2017
now that authentication is deprecated, we need to re-test this is still happening by making a branch of the webapp that requires authentication and has short expiration. @emepyc could you help?

@elipapa commented on Mon Nov 13 2017
this branch of the webapp has a token set to expire every 5s:
https://token--paratrooper-antelope-70721.netlify.com/target/ENSG00000171862/associations

@peatroot Has this been solved?

Closing as no recent reports.


The vertex index relationship between the 40K 3d face and the 3DMM face

Thank you for release the code. It's a remarkable work. I want to train my own model with 300W_LP dataset. But I don't have the vertex index relationship between the 40K 3d face and the 3DMM face. Can you release it? Thank you.

Hi, the vertices of 40K 3d face and 3DMM have no direct relations(although we can find the index with some re-sample error). In fact, the 40K 3d face is a re-sampling of 3DMM in the UV space.
Specifically, as described in section 3.1 in our paper, we used the UV coordinates of BFM from 3DMMasSTN (Thank the author again!) since 300W-LP is based on BFM.
Thus, if you want to train your own model:

generate the vertices from 300W_LP dataset, then modify it a little bit(As describe in section 3.1, make sure the x,y coordinates of generated vertices are corresponding to the 2d face, the min value of z coordinates is 0)
render the generated vertices with UV coordinates(re-sample).  Here, the generated vertices is used as a texture(replace r,g,b with x,y,z) .  I choose 256 as the size of UV space, thus we can get 256*256 = 65k vertices.
The rendered image is the UV position map, which you will use to train your own model.

About the 40K 3d faces, I discarded the vertices of neck region since they are often occluded by hairs, then only 40K vertices are reserved. You can see the mask in https://github.com/YadiraF/PRNet/blob/master/Data/uv-data/uv_face_mask.png, black for discarded region.

@YadiraF I will try it! Thank you so much!!

@YadiraF I would like to know how to resample the 65k vertices in step 2? Which tool did you use to finish this task? Thanks.


Japanese version

Hi!
I've translated the guide to Japanese.  My japanese version of the guide is https://github.com/objectx/git-style-guide

Thanks!


Cannot use ctrl+space in other software when using Peek

Microsoft PowerToys version
0.70.0
Installation method
Microsoft Store
Running as admin
None
Area(s) with issue?
Peek
Steps to reproduce
Enable Peek
✔ Expected Behavior
Able to preview file only when selected a file in File Explorer
❌ Actual Behavior
ctrl+space is disabled
Other Software
No response

This issue also took me by surprise. Ctrl+Space stopped working in Visual Studio (autocomplete) for me; I didn't even realize the Peek feature had been added or that that was its default shortcut, and I even tried disabling a few VS extensions before I found the culprit.
Is it possible for Peek to ignore the shortcut when an Explorer window doesn't have focus?

Oops, I guess a lot of users have reported this issue.
This looks like the main one:
https://github.com/microsoft/PowerToys/issues/26150

Ctrl + Space also overlaps the keyboard multi-select item short-keys in Explorer

/dup #26150


PHP closing tag

Hi! How about merge this pull request? https://github.com/nirvana-msu/yii2-infinite-scroll/pull/8

Thanks, merged.


Fix the sshd tests

@pjbreaux
Issues:
Fixes #587
Problem:
The sshd tests have been broken since the introduction (I think) of the
boolean reducing code.
Analysis:
This changes the tests to not use deepcopy and instead just select
two distinct resources from the bigip
Tests:
existing sshd functional tests

@pjbreaux the errors in this pr are related to the profiles thing that you're in the process of fixing

Yes, they will likely be taken care of by my PR. We can merge yours first.

But travis is failing as well.

Flake8: https://travis-ci.org/F5Networks/f5-common-python/jobs/148992664

fixes incoming

@pjbreaux ok travis is fixed. i think the remaining issues are the profiles thing you're handling

Does the above represent a run against 11.5.4 and 11.6.0?

11.5.4

the 11.5.4 is the first set run. if it fails then it doesnt make it to 11.6.0

Before we merge, can you rebase then revert the skip in test/functional/tm/sys/test_sshd.py. The change I made to skip was:
V11_SUPPORTED = ['11.6.0', '11.6.1']
Changed to...
V11_SUPPORTED = ['11.6.2', '11.6.1']

@caphrim007: also, we'll wait until we close PR #593 and PR #592

@pjbreaux does it not work in 11.6.0?

oh jeez, what did I do to my branch :-P

I saw the commits first, I typed out a comment, then I saw your comment.

@zancas @pjbreaux with skipping that module, these tests now pass. merge when ready


Source maps not working for error traces

Hi, I'm getting proper traces with non worker code. But with *.worker.js code I get raw trace on errors which are hard to read.
Is there someway to get worker-loader to play nicely with source-maps/devtools?
dependencies:
  "dependencies": {
    "babel-eslint": "^7.2.3",
    "date-fns": "^1.29.0",
    "dexie": "^2.0.1",
    "eslint": "^4.1.1",
    "eslint-config-react-app": "^2.0.1",
    "eslint-plugin-flowtype": "^2.34.1",
    "eslint-plugin-import": "^2.6.0",
    "eslint-plugin-jsx-a11y": "^5.1.1",
    "eslint-plugin-react": "^7.1.0",
    "lodash": "^4.17.4",
    "react": "^16.0.0",
    "react-app-rewired": "^1.3.3",
    "react-bootstrap-typeahead": "^2.0.0-alpha.6",
    "react-dom": "^16.0.0",
    "react-router-dom": "^4.2.2",
    "react-scripts": "1.0.14",
    "webpack": "3.0.0",
    "worker-loader": "^1.1.0"
  },

I'm using worker-load with non-ejected create-react-app, using this code.
Example of trace from chromium:

I hope that's enough information. If there's anything else you need let me know
update:
Forgot to say: all the links in the above trace are to the current url, not a js file.
If I disable the babel loader for *.worker.js files the trace works fine.
I've tried inline: true and inline: flase but to no avail.

I am also experiencing this issue

Close in favor https://github.com/webpack-contrib/worker-loader/issues/245


.env changes not affecting VW variables

Changing domain or AUTH_TOKEN in the .env file did not have any effect. I had to use the config.json to be able to access to admin page and make changes.

There is no AUTH_TOKEN in .env.template, do you mean ADMIN_TOKEN? Closing this as you're the only one with this issue, but will investigate if any others have this problem.


[Postponed] Optimize computing the value (as opposed to the gradient) of a function

Computing the value is currently some orders of magnitude faster than computing the gradient, so that's not the bottleneck and a priority, but there is still work to do, both low hanging fruit, probably, and hard work to slash the significant overhead compared to runtime of an analogous ordinary function. I don't think we should optimize for computing the value now, but speeding it up may require some big changes at some point.
It's also possible we'll get the speedup for free through a GHC plugin or TH once we implement a translation from the surface non-monadic language to our library combinators. Namely, the function can be optionally translated to ordinary Haskell and so run in ordinary time.

Speaking about low hanging fruit, we've just got ourselves 3 times speedup, courtesy of Richard: https://github.com/Mikolaj/horde-ad/issues/10#issuecomment-1045209923

I think we understand enough of the performance anomalies in #14 and #20 that this is no longer blocked. In fact, once this is implemented, the many-fold performance shifts in #14 should vanish, because they depend on fragile code that is slow unless aggressively optimized by GHC. The naive implementation of computing the value of an objective function by accumulating delta expressions and then discarding them is an example of such performance-wise fragile code. We are going to make the early discarding explicit and not dependent on GHC smarts.


How to add new value to prefilled list of checkboxes or radios

Hello @felixnielsen ! I wonder if there's a way of adding a user's text into the list of checkboxes or radio buttons. Here's an example: "I have a list of skills as checkboxes, the user types a skill that I don't have in my json". Can I add the user input to the list of values for that question? The user shouldn't skip to next question after he added the new skill, because he might want to add another skill. Anyone have an idea how to achieve this??

@shaolinjr I late reply but might still be of value to you. I would recommend achieving this by using flowStepCallback events and adding your tags using addTags() that would give you the option to control the next tags based on the users response.


How to focus keyboard after AwesomePlaceSearch open

How can I automatically open the keyboard when I open AwesomePlaceSearch, so that the user can immediately start typing and searching?
Note: I added (autoFocus = true) a line in custom_text_field.dart. It is working now but I have a doubt. Will it affect my plugin or app in future?

Thanks for the issue! We published a new version of the package, and now you can update it and set the autofocus property to true🚀


% operator behavior does not match documentation

The % operator's behavior doesn't match the documentation.
The docs give this example:
node =
   div#main %
      "Some text"
      strong % 1234
      a.large.red %
         href = "http://example.com"
         "stuff"

require: /html
html(node)

... which should result in this HTML:

  Some text
  1234
  stuff

Instead, it results in this HTML:

  Some text
  1234
  stuff

(Edited to add: Just to be clear, the chief problem here is that the % operator is fumbling div#main syntax. The blue/red difference is just a doc error, not a code error.)

Yeah, I know, I've been lazy about fixing this. In the meantime, it'll work if you do div[#main].


Live Demo available at crm.citvy.com (June 2020) - works

Here is the demo for you guys:
https://crm.citvy.com/
Credentials:
email<EMAIL_ADDRESS>password: q363602qwE
Feel free to explore user functionality. Admin is not available for you :) Sign in works, no signup though for now. We will add registration for you via https://citvy.com so signup is going to be working in several hours. 🤟

We are working on creating a general signup system for viewing live demo in case someone<EMAIL_ADDRESS>please do not change password👳🏿♂

Dear friends, to create your own account signup with Facebook on https://citvy.com/signup and then go to https://crm.citvy.com and use your Facebook email (email connected to your Facebook account) and the password: q363602qwE

Thanks!!!

@MindfulMe the link is not working.

Demo is available at bottlecrm.com


When to run SetupJoinTable

Your Question
When using customized join tables with the SetupJoinTable function, when should that function be run? Should it only be run when doing an AutoMigration, or should it be run on every new DB connection before that connection is used?
The document you expected this should be explained
https://gorm.io/docs/many_to_many.html#Customize-JoinTable
Expected answer
Details on when to run the SetupJoinTable function.

It should run when initialize the db, and run it once is enough.

Sorry, not quite following. When I initialize the DB every time I start the application, or when I initialize the DB to do an automigration?

"When I initialize the DB every time I start the application"
On Sat, Feb 27, 2021 at 1:04 AM Kyle Kotowick<EMAIL_ADDRESS>wrote:

Sorry, not quite following. When I initialize the DB every time I start
the application, or when I initialize the DB to do an automigration?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/go-gorm/gorm/issues/4124#issuecomment-786772010, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABVO2JJ6D2SHSXVU5JQH3TA7IDBANCNFSM4YHKJVPA
.

--
Best regards

Jinzhu
github.com/jinzhu

It should run when initialize the db, and run it once is enough.

how to use this in gen?


Create NPB disk image

And get these workloads running.

[x] Document what's needed to do this.

[x] Figure out kernel version from Pouya

[x] Create disk image

[x] A size

[ ] B size

[ ] C size

Did some tests with an NPB disk image for class S workloads with O3 cpu. The workloads execute for the most part, but crash at the end of the execution. Still looking into the problem

Can you show us the error?

This is an example of the error (for ep benchmark):
At line 273 of file ep.f (unit = 6, file = 'stdout')
Fortran runtime error: Unexpected element '('EP Benchmark Results:'//'CPU Time =',f10.4/'N = 2^',

That doesn't look like a gem5 bug.
It looks like a weird compiler + runtime issue.
The error is on this line: https://github.com/darchr/npb/blob/master/NPB3.3-OMP/EP/ep.f#L274.
This works fine when running in 100% KVM mode? That seems surprising to me.
I guess it's possible there's a weird memory bug in the simulator where the runtime is getting a value that it doesn't expect even though the correct value is in the program...

Yeah, this works fine when run in 100% KVM mode. Also, when I use Pouya's disk image with my kernel (4.19), this benchmark seems to work fine with O3

Wow. That's super weird!
The problem seems to be with printing something, so it could be a problem with the I/O drivers or devices.
Have you tried your disk image with Pouya's kernel? Or, I wonder if it works in Ruby? Could it be the problem with X86+classic caches.

What's the state of this issue?


Authndev

Coverage increased (+0.01%) to 51.235% when pulling ab82962bf2c00fc868c5d75ba82a6e79a2a9598b on authndev into cfc67e8409c782558dae07b6c94e036f7a693712 on pai-0.14.y.

Coverage increased (+0.01%) to 51.235% when pulling ab82962bf2c00fc868c5d75ba82a6e79a2a9598b on authndev into cfc67e8409c782558dae07b6c94e036f7a693712 on pai-0.14.y.


netty-tcnative-boringssl-static dependency has security vulnerability problem

Expected behavior
No security risks
Actual behavior
Have security problems, as CVE-2022-28331、CVE-2017-12613、CVE-2023-49582
Steps to reproduce
Security tool scanning
Minimal yet complete reproducer code (or URL to code)
Netty version
groupId: io.netty
artifactId: netty-tcnative-boringssl-static
version:2.0.66.Final
JVM version (e.g. java -version)
JDK1.8/JDK17
OS version (e.g. uname -a)

We don't use any of the vulnerable features.

So, we have no plans to fix this problem?
Enterprises strictly require components with security risks, is there any way to avoid this problem?
Thank you!


Fix warnings from atari gym.

Fix gymnasium/ALE warnings.

Codecov Report

Merging #3207 (37e350e) into main (3ec88c3) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
- Coverage   82.33%   82.31%   -0.02%
==========================================
  Files          54       54
  Lines        6063     6062       -1
==========================================
- Hits         4992     4990       -2
- Misses       1071     1072       +1

Impacted Files
Coverage Δ

flax/errors.py
86.48% <ø> (+0.52%)
:arrow_up:

flax/linen/normalization.py
96.83% <66.66%> (-0.61%)
:arrow_down:

... and 1 file with indirect coverage changes


Implement NumRef variant for cases like &T: Op<&T, Output = Self>

This is needed for cases where cloning is expensive and values are used inside loops (for ex, BigUint/BigInt).
From what I understand RefNum is what we are looking for. But I couldn't get it to work.

Check this from num-bigint trait.
Does num-trait have a triat that suffices for such implementation or would we have to implement our own trait?


load images and fonts from executing dir

Fixes #141 @bryphe hopefully this addresses the problem of loading fonts and images using esy x Bin (tested and does work) in the way you intended

This is awesome @Akin909 ! 🎉  Some related thoughts:

The esy.json file I think it's an artifact used by older versions of esy. In the most recent versions, it was replaced by an esy.lock folder
The addition of Sys.getcwd() probably will have some implications in projects targeting the browser through jsoo. js_of_ocaml doesn't support Sys that much, and from a quick test I did, it returns /static which doesn't make any sense in the folder structure of the test project I was using (there is no folder in that project called static). So maybe we have to create some abstraction over the different platform implementations like happened with fontkit or glsw. Maybe we could call it reason-system... or build it from rench (although, rench is more opinionated towards a Node.js-like API as far as I understand). I'd be happy to look into this as part of https://github.com/bryphe/revery/pull/116.
Probably out of scope 😄  but I'd love to play around ideas around handling compile-time known assets paths at build time. I'm still unsure how that would look like exactly, but my idea right now is to read these paths at compile time, maybe through a ppx, read the assets from the ppx binary, and convert the load expression into an assignment to a binding of the whole path binary data (maybe as a string? or as binary data?). Something like https://github.com/johnwhitington/ppx_blob.

Awesome work so far! This is a great first step towards shippable revery software.
@jchavarri If you're interested in compile time asset loading, that's some thing I was gonna try to make actually. I've thought of a few ways of doing it and once I settle on one I'll go ahead and write a PPX for it:

Automatically guessing which files are statically accessible (if the path given to whatever File.load is a string literal && the file exists)
Having a [@static] annotation that can be used when loading a file to inform the compiler that it's a static asset
We can output each file as a linkable object file (e.g. https://www.linuxjournal.com/content/embedding-file-executable-aka-hello-world-version-5967) and generate extern declarations
We could also make an array or hashtable of strings (binary or otherwise) that we load, basically the same as what ppx_blob would do
For each of these, we have to let File.load know that these files are already loaded. We can do this by using a hashtable/other data structure of cached files and then inserting that as an optional parameter/overriding an empty data structure when we've loaded files

@jchavarri good point re. Sys not working in all environments :+1:, you sound like you've given it way more thought than I did so for this PR I've just put a guard to only try the Sys call if the env is native, but an actual future solution that can do a similar thing per environment would be awesome.
Re. the esy.lock.json, it seems to have already been in the project, is it unnecessary now, seems to change whenever I run esy on a branch without necessarily changing dependencies.
The ppx idea sounds very cool (I'm pretty new to reason and ocaml so would be beyond me at this point :laughing: )

Just tried out this PR - I can now run esy x Bin.exe on Windows! 🎉  This makes it so much easier to run the demos (at least for me), and means #136 is unblocked now.


A question about your DataLoader for ImageNet-C

Hello
Thank you for your good work.
I have a question about your DataLoader for ImageNet-C.
When implementing PETAL for ImageNet-C, I found that your loader returns only 5,000 samples for each corruption, not all 50,000 samples.
In your configuration file, you specify # of examples for simulating test streams. However, the dataloader only serves the specified samples of the RobustBench library (robustbench/data/imagenet_test_image.ids.txt).
Is it intended?
I appreciate any help you can provide.

Thanks for pointing out this.
We only use 5,000 samples, following CoTTA.
The official CoTTA implementation updated this. (refer to their commit here: https://github.com/qinenergy/cotta/commit/4f6957155a560e7c4c115a3a744488235e09a72b)
We are also updating this in our codebase.


Update Dockerfile to work from inside a subfolder in the repo

This is just to fix the Dockerfile so the helm task test can use the same repo instead of an
external repo, it needs to come in a separate PR so the test can pull the repo as a github source and find the correct file

/lgtm


Changed all instances of Unprocesssable to Unprocessable

Changed all instances of Unprocesssable to Unprocessable, which is the correct spelling :-)

Thanks, I hadn't noticed the misspelling. :)


Test automation_attributes creation for vms, services, orch stacks

Since the addition of https://github.com/ManageIQ/manageiq/pull/18084/files, the attrs we pass to deliver_to_automate for retirement should be correct, and, better yet, ought to be tested.

@miq-bot add_reviewer @mkanoor

@miq-bot add_label cleanup
@miq-bot assign @gmcculloug
cause I know he wants more emails n stuff 🎉

@miq-bot add_label tests

@miq-bot add_reviewer @tinaafitz

ugh
@miq-bot add_label test

@bdunne can you please take another look?

@tinaafitz can you please 👀 for me?

Hammer backport details:
$ git log -1
commit 77db974d46f6275c5c2a4e1bc92793dd8b4ad7d4
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Fri Nov 2 11:47:49 2018 -0400

    Merge pull request #18085 from d-m-u/adding_tests_for_retire_tasks

    Test deliver_to_automate gets called in vms, services, orch stack retire tasks

    (cherry picked from commit 9822d52744420c753c05b664d0d3d7cefa33edf9)


fix: remove deprecated operator"" syntax usage

Clang warns about this.  Apparently GCC 4.9 may warn about the fixed syntax, though!
Spotted in the ADBC CI:
 /adbc/c/vendor/nanoarrow/nanoarrow.hpp:94:35: error: identifier '_asv' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
   94 | inline ArrowStringView operator"" _asv(const char* data, std::size_t size_bytes) {
      |                        ~~~~~~~~~~~^~~~
      |                        operator""_asv

Ah, bleh. I'll try with the ifdef in a bit


Add more headers to the access log

This adds header which give us more information about the request. This is
useful for debugging and monitoring.
It will give us the viewer's IP address, the CloudFront request ID, and the
trace ID from ALB if present.

amz and amzn are typos on my part. its almost as if different amazon teams dont talk to each other.


Em montage qc

Adding clone stack feature to clone input montage stacks if they are in LOADING state

closing this to submit after integration tests


Need to use a logo compatible with both light and dark modes

Currently, the extension is published to the marketplace with a logo compatible with a dark mode:
On the extension page of the marketplace:

In vscode's extensions view :

But it doesn't work in the publisher page, when displayed in a card:

It was proposed to replace the logo with a version compatible with a light mode:

That should work with the extension page on the marketplace and the publisher card, but not when viewed from within vscode, basically amounting to:

I think the best solution is to get logos with non-transparent cube edges:

white edges for dark cube,
black edges for white cube

cc @maxandersen

Maybe @insectengine can help ;-)

Hello @fbricon, I forwarded my original email I sent Max regarding this, but here is the content of the email I sent...
TLDR is we use the dark cubed version of the logo and a custom color for the background.

As per Max, the VSCode Marketplace uses a single image for the Card on the main page and the detail page.
Main marketplace: https://marketplace.visualstudio.com/search?term=quarkus&target=VSCode&category=All categories&sortBy=Relevance
Detail page: https://marketplace.visualstudio.com/items?itemName=redhat.vscode-quarkus
The issue is the card has a light background while the detail page has been set to a dark background. We’re currently using the logo designed for a dark background and parts are disappearing on the card view.
Looking at other pages, it seems we can control the background color of the detail page (so it’s not the default light grey).
Here are a couple examples of what other teams have done.
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-docker
https://marketplace.visualstudio.com/items?itemName=HookyQR.beautify
https://marketplace.visualstudio.com/items?itemName=ms-edgedevtools.vscode-edge-devtools
I propose this solution:
https://design.jboss.org/quarkus/vscodeicon/images/vscodemarketplace_quarkusmarkup.png

We use the default icon for the card and detail page:
https://design.jboss.org/quarkus/logo/final/PNG/quarkus_icon_rgb_128px_default.png
(It has the dark cube in the middle so you may not see it because of the transparent background in Chrome)

We then set the background color of the detail page to a light blue derived from our blue color (#d8ebff)

If possible, we change the hyperlink for the “quarkus” title to our Medium Blue (#5995e4)

@insectengine your plan only fixes the marketplace page, but not the extension page INSIDE vscode, as I described it, which will get way way more traffic than the red hat publisher page

@fbricon  - ah ok.. can you post a link to the page where it doesn't work so I can check it out?

you need to install vscode (dark theme should be enabled by default), open the extension page (4th icon with squares on the left). Type quarkus to look for the extensions on the marketplace :

If we used the logo you recommended, it'd be black square on dark background

@fbricon  - question for you.. they only allow one logo throughout all of this process? It seems odd that they would have an option for light and dark on their site and only dark inside vs code. If possible, we should use the reverse logo inside the dark environment and the default one with the dark cube for the other pages on the site itself. Is this possible?

Nope. Single icon for both the marketplace website and the extension view within VS Code.
As I said, the simplest solution would be to provide logos with colored edges. They'll work in both dark and light themes.

We don't want to create a new version of the logo... it would ultimately cause more problems down the line.
How does one using the light background look on VS Code?
https://marketplace.visualstudio.com/items?itemName=ms-vscode.csharp
or
https://marketplace.visualstudio.com/items?itemName=kirkslota.karate-runner

C#:

Karate Runner:

@fbricon  - I suggest we take a page from the karate runner usage. Let's put it on a background of the dark quarkus blue and have it mirror the logo's rounded corners.
So we have this icon (128x128):
https://design.jboss.org/quarkus/vscodeicon/images/quarkus_vscode_icon.png
It would look like this on the light card (the first one on the left):
https://design.jboss.org/quarkus/vscodeicon/images/vscodemarketplace_main_quarkusmarkup_v2.png
Then on the detail page:
https://design.jboss.org/quarkus/vscodeicon/images/vscodemarketplace_quarkusmarkup_v2.png
Finally inside VS code on their default dark:
https://design.jboss.org/quarkus/vscodeicon/images/vscode_interface_dark.png

@insectengine fine by me, however it'll take a few days before we publish a new release on the VS Code Marketplace

@xorye please update the icon to https://design.jboss.org/quarkus/vscodeicon/images/quarkus_vscode_icon.png, and in https://github.com/redhat-developer/vscode-quarkus/blob/master/package.json#L15, change the color to #d8ebff and the theme to light

Awesome... thanks @fbricon !


Add a note that the type checks in async-from-sync-iterator can be omitted in some engines

Via @caitp in #jslang.
In particular they are only necessary if you can get access to the functions via .caller, or similar nonstandard extensions. And for engines that implement built-ins as strict, they are already prohibited from .caller returning the functions.
Now that I state it this I'm not sure whether we should keep the type checks any more, since .caller is nonstandard, and we don't generally add type checks in places just in case someone implements a nonstandard feature that hits an unexpected spec code path. Hmm.
Opinions, @bterlson @allenwb?

Are you talking about these checks: If Type(O) is not Object, or if O does not have a [[SyncIterator]] internal slot, then ?
If so, I think they are necessary.  Otherwise, there would be unguarded accesses to O.[[SyncIterator]].
Implementations can always skip checks that they can prove will never fail (in their implementation).

Yep, those are the ones.

Otherwise, there would be unguarded accesses to O.[[SyncIterator]].

Well, the issue is that this class and its methods are only ever created/called by for-await-of syntax. Thus this whole class is somewhat similar to the Iterator object created by EnumerateObjectProperties.
However, unlike the EnumerateObjectProperties iterator, it has the added wrinkle that this inaccessible-class wraps a user-provided object, which means you could use .caller to get access to the class's methods. Thus the OP's confusion about what to do.

However, unlike the EnumerateObjectProperties iterator, it has the added wrinkle that this inaccessible-class wraps a user-provided object, which means you could use .caller to get access to the class's methods.

Which is why I'd say the guard is necessary.  Anywhere it is possible for an extension to invalidate type dataflow derived slot access soundness then there should be a guard.

Right, but the issue is that you can only access it when using nonstandard extensions. What if someone added a nonstandard extension (call it for.in) which gave you access to the Iterator created by EnumerateObjectProperties? Should we go edit the spec for that Iterator to add guards?
(To be clear, I pretty much agree the safe thing to do is leave the guards in, and probably will do that. I am just curious about the reasoning and trying to figure out a consistent principle we use here.)

I'm not sure why it's not feasible to just Assert: O is an Object with a [SyncIterator] internal slot, which is likely what implementations will do to ensure it's not exposed