Create a Learn page for p5.Framebuffer

Increasing Access
p5 is soon adding support for a new type of object, p5.Framebuffer: https://github.com/processing/p5.js/pull/6072 It isn't obvious to a non-expert when one should use it vs, for example, a p5.Graphics, and it's also worth showcasing some of its functionality that one might not know they want until they hear about it (e.g. floating point textures.) These topics are a little too big to put in the docs for its methods, so a dedicated learn page seems like the best place.
Most appropriate sub-area of p5.js?
Learn
Feature request details
Ideally this would go over:

How is a p5.Framebuffer different from p5.Graphics?

Why might you want to use floating point textures?
What kinds of things can you do when you have access to depth information?
How much faster is it to draw to a framebuffer instead of a p5.Graphics?
Using a framebuffer texture as data in a shader

How framebuffers relate to the canvas they're created on

When to use a framebuffer on a p5.Graphics
How do autosizing and fixed sizes work
How to use cameras with framebuffers

Some resources to maybe pull from:

This sketch uses 120 framebuffers to make a "rolling shutter" effect with the webcam, which is able to run quickly even on phones
This sketch uses the depth buffer to add focal blur
This sketch implements a particle system with the data stored in a texture

I'll work on this over this weekend.
@davepagurek other than the code in #6072, the readme of original p5.framebuffer library, and the examples you mentioned, would you like to suggest any other resources I could utilize for our learn page?

Thanks @ShivangMishra! If you want to have any interactive examples, the PR isn't merged yet but here's a build of p5 off of the PR that you can work with for now: https://gist.github.com/davepagurek/2a9118d03c4d81db86037ad37aa56639
openFrameworks, a library similar to Processing for C++, has these docs on its version of this, ofFbo: https://openframeworks.cc/documentation/gl/ofFbo/
I also linked some more examples in https://github.com/processing/p5.js-website/issues/1341 (I also just edited it now to add some more) that might be helpful if you're looking for things one can do with framebuffers.

@davepagurek , @aferriss ... so I've started working on the Learn page. Here's a rough outline - https://github.com/ShivangMishra/p5-fbo-learn-temp/blob/main/learn-framebuffer.md .
I've taken most of this text from the readme and comments of @davepagurek and @aferriss on the previous fbo libraries.
Please have a look and give suggestions, I'll work on it in my temporary repo until we have a final draft.
While you review it, I'm working on the code examples.
I need a little help on these points :
-When to use a framebuffer on a p5.Graphics
(How can we use framebuffer on a p5.Graphics ?)
-How to use cameras with framebuffers
(I found defaultCamera() and createCamera() functions relevant to this point, but not sure what else I should cover)
-How much faster is it to draw to a framebuffer instead of a p5.Graphics?
(Any suggestions on how I should compare the performances on some benchmark?)
Thanks!

Thanks for your work so far @ShivangMishra! I haven't had a chance to take a look just yet but I'll get back to you in the next few days 🙂

Thanks for your work so far @ShivangMishra! I haven't had a chance to take a look just yet but I'll get back to you in the next few days 🙂

Hi @davepagurek did you get some time to review my draft?
While waiting for your reply, I too got busy with some other projects.
Would you like me to continue working for making the Learn Page?

Oh I'm sorry, I didn't realize that I missed half of your question! Here are some notes:

Since we currently don't provide a way to access the stencil buffer, we can probably omit mentioning it for now. (Maybe later if we implement masking with this we can add it? https://github.com/processing/p5.js/issues/3998 :eyes:)
Maybe we should explain how drawing to a framebuffer is a bit different than drawing to a p5.Graphics? Maybe we could show two versions of some simple code to draw a sphere to a texture using framebuffers and using graphics. The difference would be:

With a p5.Graphics instance, let's say it's called g, all the calls to draw to it are done by prefixing them with g. (e.g. g.sphere())
With a framebuffer, all the calls are done on whatever context the framebuffer was made on, and you draw to the framebuffer by putting draw calls between begin() and end() calls (e.g. fbo.begin(); sphere(); fbo.end())

In the depth section, we'll probably need to explain a bit about the range of the depth values. I'm guessing we'll need to say:

Depth gets squished into the range of 0 to 1
0 is as close to the camera as the camera allows; 1 is as far away as the camera allows before it gets clipped
You can change what becomes 0 and what becomes 1 by editing the near and far params, respectively, in perspective()
Maybe a good example of this would be a sketch that draws a bunch of spheres or something and visualizes the depth, and some sliders to control the near/far parameters so you can see how they affect the depth numbers? (Let me know if I can help provide a sample sketch for something like this!)

Also if you feel like making a PR that has your .md file in it (you can mark it as a draft while we're still working on the text), I can add comments on different lines and be notified when you make changes 🙂

Hi again! We're going to start getting the ball rolling on a new p5 release soon. Would you be interested in continuing working on this in the near future? If not, that's totally fine too, we can update the website after the p5 release, so there's no rush! We probably want to have something available for when the new release comes out, so I could also make a small first version of a learn page for when we launch the new version, and then build on top of that after, if that's OK with you?


Reporting Vulnerability

Hello!
I hope you are doing well!
We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly.  GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.
Can you enable it, so that we can report it?
Thanks in advance!
PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

Is the vulnerability simply "you are using reflection and JNI"?

Hello!
I hope you are doing well!
We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly. GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.
Can you enable it, so that we can report it?
Thanks in advance!
PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

I already enabled the feature


[xs]: remove import_git to examples directory

Moved import_git.py to examples directory and added README
Removed gitpython from dependency list
Resolves: #86

Coverage remained the same at 93.734% when pulling 1c94e598b824fae65ff80fd17c815d938a4225d4 on subhankarb:master into 41d36309ca5857d26ec3d4752994c5c7c5b282fa on frictionlessdata:master.


AIMA4e implement Fig 11.8 Angelic-Search from AIMA3e branch

Sir, please give me a start for this.

https://github.com/aimacode/aima-pseudocode/blob/master/md/Angelic-Search.md
:)


get() and getIn() return type in flow definition is not correct

We use immutable and flow. Recently we had a bug because flow did not check that if getIn() has no notSetValue then the result could be undefined.
The current code :
// in immutable.js.flow
get<T>(searchKeyPath: ESIterable<any>): T;
getIn<T>(searchKeyPath: ESIterable<any>): T;

The right definition :
get<T>(searchKeyPath: ESIterable<any>): void|T; // or ?T
getIn<T>(searchKeyPath: ESIterable<any>): void|T; // or ?T

There is also an inconsistency between get(searchKeyPath, notSetValue) and getIn(searchKeyPath, notSetValue) that should be corrected :
getIn<V_>(searchKeyPath: ESIterable<any>, notSetValue: V_): V|V_; // or ?T

🐐

Thanks for this report.
Actually getIn isn't possible to correctly type check unfortunately since the key path may lead to a collection of a totally different type and Flow can't translate that, so I'll convert them to return any. However you're totally right that get could return void.


Could not find opencv_android_module-3.1.0-fix3.jar (com.github.eliasteeny:opencv_android_module:3.1.0-fix3).

I am also facing this issue after updating my flutter version
I resolved this by doing

Just use fluttter clean
then run your app flutter run


Crash in getArgument

I have a service that depends on a service that uses the HttpModule for external API communication. This caused a problem with this library.
The problem is that the repository detection is a bit naive. Currently it decides the dependency is a Repository if the it is a string, but other dependencies may be string at this point as well, like the HttpModule.
  private getArgument(param: string | ClassType, manager: EntityManager): any {
    let argument: Repository<any>;
    const id = typeof param === 'string' ? param : param.name;
    if (this.cache.has(id)) {
      return this.cache.get(id);
    }
    if (typeof param === 'string') {
      const repository: Repository<any> = this.moduleRef.get(param, { strict: false });

      const entity: any = repository.metadata.target; // crash! target is not a property of undefined

      argument = manager.getRepository(entity);
    } else {
      argument = this.findArgumentsForProvider(param as ClassType, manager);
    }
    this.cache.set(id, argument);
    return argument;
  }

I was able to fix this by adding a instanceof Repository check, to make sure that we have an actual TypeORM before we access it's metadata that might not be there.
   private getArgument(param: string | ClassType, manager: EntityManager): any {
    let argument: Repository<any>
    const id = typeof param === 'string' ? param : param.name

    if (this.cache.has(id)) {
      return this.cache.get(id)
    }

    if (typeof param === 'string') {
      // Fetch the depedency.
      const depedency: Repository<any> = this.moduleRef.get(param, { strict: false })

      if (depedency instanceof Repository) {
        // If the dependency is a repository, make a new repository with the desired transaction manager.
        const entity: any = depedency.metadata.target
        argument = manager.getRepository(entity)
      } else {
        // The dependency is not a repository, use it directly.
        argument = depedency
      }
    } else {
      argument = this.findArgumentsForProvider(param as ClassType, manager)
    }
    this.cache.set(id, argument)
    return argument
  }

And now I believe it seems to working as intended.
Thanks for this code. It's an elegant solution to a tricky problem and this has been super helpful!

Hello, @AlexJWayne! Thank you for this fix, I will add it on this week necessarily

Hello, @AlexJWayne! All is done! Version 1.0.3 contains your fix. Thank you!

Hello, @AlexJWayne! Version 1.0.3 had broked transaction logic (usual repos was created with the usual manager, not transaction), because of this I add some fixes and additional features. The actual version is 1.1.2, please use it.


Update v3.0.0alpha3

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

There are too few lines.  There should be one empty line at the end of the file.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Looks like 22 tests are failing and I'm not sure if the problem is related to our build system. Maybe we should ask upstream about it.

Looks like 22 tests are failing and I'm not sure if the problem is related to our build system. Maybe we should ask upstream about it.

What do you mean ask upstream?

Also, now the error (after adding libxslt) seems to be a topology error, similar to https://github.com/conda-forge/postgis-feedstock/pull/25

Closing this in favor of #25


What's the compile time threading modes of the native library?

As the document mention SQLite has 3 thread modes: Single-thread, Multi-thread and Serialized. So what's the compile-time thread mode of sqlite-jdbc and does sqlite-jdbc provide the capability the change it at runtime?

sqlite-jdbc is compiled with SQLITE_THREADSAFE=1 (multi-thread mode) https://www.sqlite.org/compile.html#threadsafe
This cannot be changed at runtime.

Thanks, xerial. It would be a good feature if the thread-mode can be changed at runtime.

Hi, xerial. I wonder why doesn't sqlite-jdbc choose SQLITE_THREADSAFE=2 as the default?

The thread model choices were discussed here:
https://github.com/xerial/sqlite-jdbc/issues/59
Basically,
SQLITE_THREADSAFE=0 is bad, because it's not thread-safe.
SQLITE_THREADSAFE=1 is the default behavior, and can be modified at runtime (when sqlite-jdbc supports it).
SQLITE_THREADSAFE=2 is bad, because it breaks existing apps.

OK thanks!

sqlite-jdbc is compiled with SQLITE_THREADSAFE=1 (multi-thread mode) https://www.sqlite.org/compile.html#threadsafe

I believe there's a typo in the above quote, as is stated in the link: SQLITE_THREADSAFE=1 sets the default threading mode to Serialized (NOT multi-threaded).

Just to confirm the expected behavior of xerial:

Xerial's sqlite is compiled with SQLITE_THREADSAFE=1. This sets the threading mode to Serialized. Multiple threads can access a SQLite database at the same time but each thread must obtain its own JDBC Connection.
The threading-model is serialized. This means, I think, that the threads won't actually proceed concurrently. A second thread won't be able to do anything until the first thread closes its Connection. The underlying SQLite db is threadsafe but only offers serialized concurrency level.
It is possible to change the sqlite concurrency level at runtime but Xerial does not offer a Java API. At least there's nothing in the SQLiteConfig class that can be used to change this.

Is this correct?


Feature request

Implement password reset for user.
User can change their password from settings after login.
additionally, 2FA will be a cool feature...

2 FA will not be considered, changing the password will be considered

@Kerwin1202 is it possible to make role based or user based or model based rate-limiting system?

@Kerwin1202 is it possible to make ROLE based or USER based or MODEL based rate-limiting system?

Is it similar to 10 times every 10 minutes? In what scenario is it needed?

@Kerwin1202 is it possible to make ROLE based or USER based or MODEL based rate-limiting system?

Is it similar to 10 times every 10 minutes? In what scenario is it needed?

For example, only 'Guest' role user can make 10 request per hour and 'Tester' can make 120 request per hour. rest of the role have default rate-limiting.
Another example is: If user have 'Premium' role only that user can make 120 request per hour and rest of the user will have a default rate-limiting which could be 30 request per hour.

@Kerwin1202 is it possible to make ROLE based or USER based or MODEL based rate-limiting system?

Is it similar to 10 times every 10 minutes? In what scenario is it needed?

For example, only 'Guest' role user can make 10 request per hour and 'Tester' can make 120 request per hour. rest of the role have default rate-limiting. Another example is: If user have 'Premium' role only that user can make 120 request per hour and rest of the user will have a default rate-limiting which could be 30 request per hour.
Like ChatGPT's GPT-4 have 25 message per three hour.

Will be considered


[Addition]: Self-witnessing Cluster in the US (6 HS)

Hotspot b58 Addresses
112rGsSqEY7QVRXLbynNdNdeQW1KAYc7da8UvFmBhQETX3cj7isn
115erQscGWPyms8ZfbNhTVBW9n1TUr6VsfigxHAQMLueHUv8Num
11kJF1bmiV18RiPyWQtNmj7EvFummtRGBQy8bx3snKARNzXQcfz
1122jrLuFMdMXdYVsmRXwhh3Zq2DcwFDExctfj3JsU9guWMi77Cg
1122cdvLCMKDJDqpH3eQUedrnYMZdUWCpibds8C69sFmH7aVF2qE
11dMomAvM2qh9hXHLx1pc999n9k39yTWiULULAnhYZfUUYSYjVk
Discord Handle
No response
Reason(s)
Abnormal RSSI/SNR

Never found such a bad project. When you bought the equipment, the seller and the project party did not supervise whether the sales were legal or not, and did not inform you of the existing risks, just as the police acquiesced in allowing qualified arms dealers to sell arms, but did not inform you that they must sell and use arms legally.  I believe that Helium will definitely declare bankruptcy. As it is said on the Internet, he is a fraud. Because now everyone is reporting. Even though the new 5G hot spot equipment is excellent, it is impossible for new miners to be deceived again.I hope everyone who sees this will forward it. Let everyone know that the project party is a fraud gang.


brontide: refactor peer to prepare channel ready fix

This PR extracts the first 5 commits from #7518 to provide a better view experience. In this PR, we focus on replacing normal maps with SyncMap, providing abstracted methods to determine a given channel's state(pending/active/loaded from disk), and adding a new method handleNewActiveChannel to handle new channels in a more structured manner.

This change is

Changed FindPreviousCheckpoint to check and return an error from findPreviousCheckpoint

It looks like it will run properly if our node previously restarted while the channel was pending (forcing a DB reload), but how often do we really avoid the bug today due to a lucky restart?

I'm confused - how does a node restart while pending avoid the bug?

I'm confused - how does a node restart while pending avoid the bug?

I had it slightly wrong, sorry.  It's not a restart of our node that may avoid the bug, but rather a reconnect to the peer.
The only place where a pending channel nil is added to activeChannels is loadActiveChannels, where pending channels are loaded from the DB.  loadActiveChannels is only called during Brontide.Start, which happens on peer reconnect.
So once the funding manager has added the pending channel to the DB, if a lucky disconnect/reconnect to the peer happens, the Brontide will load the pending channel from DB and isActiveChannel will return true for that pending channel.  So if we get an update_fee after that, isLinkUpdate will be true and this code will set up a message queue for the channel:
https://github.com/lightningnetwork/lnd/blob/5c5ce1f707c5c109e250fd01c4ddc36420ad2b36/peer/brontide.go#L1629-L1646
The update_fee will be queued until the link becomes active, avoiding the bug.


error fixed for if no argument passed

Dear Aniket
We inspected your report and found that there was a bug in it (error fixed for if no argument passed).Thank you so much for taking the time to report a bug. We are incredibly grateful for you and you are given the hall of fame from us. Our goal is to provide DorksNight with a completely bug free Tool (software). With your submission you have helped us reaching this goal.

Dear Aniket
We inspected your report and found that there was a bug in it (error if no argument passed).Thank you so much for taking the time to report a bug. We are incredibly grateful for you and you are given the hall of fame from us. Our goal is to provide DorksNight with a completely bug free Tool (software). With your submission you have helped us reaching this goal


Add AWS::EC2::CapacityReservation resource

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-capacityreservation.html

Fixes #1377

Nice! Thanks!


go: always report gapic version

Codecov Report

Merging #1083 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1083   +/-   ##
=========================================
  Coverage     85.18%   85.18%
  Complexity     3488     3488
=========================================
  Files           367      367
  Lines         13868    13868
  Branches       1579     1579
=========================================
  Hits          11814    11814
  Misses         1598     1598
  Partials        456      456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa8022...aad7aee. Read the comment docs.

@jba @bjwatson PTAL

LGTM, but @jba should sign off too.


LMOWFv1 with passwords > 14 chars

The MS-NLMP docs define the LMOWFv1 function as
 Define LMOWFv1(Passwd, User, UserDom) as
        ConcatenationOf( DES( UpperCase( Passwd)[0..6],"KGS!@#$%"),
                  DES( UpperCase( Passwd)[7..13],"KGS!@#$%"))

It also states that

Password of the user. If the password is longer than 14 characters, the LMOWF v1 cannot be computed.  For LMOWF v1, if the password is shorter than 14 characters, it is padded by appending zeroes.

While this is correct for LM hash authentication, this hash is still computed even if NTv1 hashes are used stopping longer passwords being used for NTv1. The check here will block the initiator from acquiring a credential even if they want to use just NTv1 and not LMv1 authentication.

The question is what to do in KXKEY is extended security is not negotiated, I am preparing a tentative patch for this case.

I have two options here:
https://github.com/simo5/gssntlmssp/tree/nolmkey1
and
https://github.com/simo5/gssntlmssp/tree/nolmkey2
I have a feeling #2 is the way to go as that what windows machines have at hand after local authentication (or in the DCs).
@jborean93 what do you think?

I think 2 makes more sense as well, if a user's password is greater than 14 characters then LM auth will never work even if the server is set to store the LM hash. It's also a less invasive change than option 1, I would only suggest having a comment saying why the LM hash is 0'd out.

done PTAL


Install and Configure Karma in existing Project

Hi,
@angular/cli: v7.0.6
I previously create new angular project using @angular/cli with this command
ng new --inline-style --minimal --skip-git --skip-tests
Hence test related packages are skipped. After my source code development completes, I wanted to install back the test packages (e.g karma, jasmine, karma-coverage-istanbul-reporter, etc) and the preconfigured  test configuration file(such as karma config file).  Possible to do this with angular cli command line? If not possible, would like to suggest to provide a new ng command option to  install and preconfigure the test packages to an existing angular project .

Hi, at the moment we don’t offer this functionality.

This is not a capability we are considering as a complete implementation with proper configuration would be non-trivial.
The minimal option is intended for use cases such as class exercises, quick experiments, demos, etc.
Creating a new project and reviewing the test related additions and then adding them to the existing project as well as an option setup within angular.json specific to the project would probably be the most efficient method currently.

ok. noted.


Issues with switched NPC( 'g' key)

while we press 'G' key and switch to the nearest NPC, I noticed following issues:
1- "E" activator keeps appearing over the npc, while we switch to it.
https://user-images.githubusercontent.com/35926530/181524059-7faf0dfe-f149-4e68-99da-e4274c3296b4.mp4
2-The jump animation of switched npc is too fast.
https://user-images.githubusercontent.com/35926530/181524248-56d890e5-38d9-41af-bcc1-7bd4f96796e7.mp4
3-While we press "E" on the switched NPC, it restricts the movement of npc inside a kind of loop around the avatar.
https://user-images.githubusercontent.com/35926530/181524680-aee55c9a-835a-4688-9b9b-28eb6f376b06.mp4
4-While we switch to npc from avatar, the avatar is left just in the state it was switched from.
https://user-images.githubusercontent.com/35926530/181525036-60f806e2-1289-4712-bde9-27ec00aab496.mp4

I think the bug is that avatar updates for swithced-to NPCs are run twice.

Problems

Local player isn't based on App ==> It's missing collider capsule.
When there's local player switch, it needs to disable collider because avatar's not interacting with himself.

When npc joins the party, it should be moved to avatar's app manager from scene app manager.
Physics tracker needs to track all app manager. Actually, manager for physics tracking is preferable ==> https://github.com/webaverse/app/issues/3614

Party System

https://github.com/webaverse/app/pull/3625

https://github.com/webaverse/totum/pull/130

Video: https://www.loom.com/share/262313dc551c4e84b44d6a8d3d0530cc


Graph Proposal

This is intended to be a pull request to organize and brainstorm about potential changes to SimpleGraph to enable more complex manipulations required for effective comparative genomics.
Please feel free to checkout this branch and make changes. At time of writing there are two significant changes from SimpleGraph detailed below.
1. Sequence data is moved to a new struct with a reference in the Node struct.
The primary benefit of this is that it allows multiple graphs to use the same underlying data. In this way we can readily create sub graphs that use the same underlying data, and can easily check for identity between subgraphs by checking the reference of the pointed to data. This functionality is particularly useful for identifying common nodes from a graph alignment block.
2. Edge probability has been moved to the Node struct.
This change is required to enable effective creation of subgraphs. Imagine a situation where Humans and Chimps both have Node X as a next node, but the probability for Human X != probability of Chimp X. With the old format this could be achieved by having multiple edges along the same path with some identifier to discriminate between the Human and Chimp edges, however this can be more effectively handled by delegating probability to the Node struct such that subgraphs may have their own set of edge probabilities. A core graph that covers all existing nodes could ignore these fields if desired.
These changes should enable effective creation of subgraphs and fix some of the problems with graph alignment blocks. Ideally the new Node struct will be very lightweight so data can be effectively shared between subgraphs.

I am thinking about #1 above.  I think the idea is that the memory location of Data will act as an indirect identifier of a sequence and alignment column combination.  Such that if two Data memory addresses are equal if, and only if, they have the same sequence and are in the same alignment column.
I think this can already be done (more efficiently) with the current structure that has a pointer to a struct containing the sequence.  I think the only difference is whether it is a pointer to a ThreeBit struct or a Data struct.  I worry that creating the Data struct may actually make things harder to reuse since it ties fields like Annotation to the sequence, which may be different between a human graph and a chimp graph (different linear references).
I also worry a little bit about memory location being used as an indirect identifier.  Does it make more sense to store an explicit alignment column id in each node?  This would allow us to quickly analyze aligned graphs as well as separate out SNPs from indels in a single graph

About your hesitancy to use the memory address as an identifier: Do you think identical nodes between different species should have the same underlying sequence in the node, or should the sequence be copied for each species?


IDocumentClient interface does not expose ReadDocumentAsync that DocumentClient class offers

The IDocumentClient interface does not currently expose the ReadDocumentAsync<T> methods that are offered by the DocumentClient class. These overloads would be useful and, AFAICT, far more efficient than having to use LINQ based querying API for reading single document instances into the exact type T that we need. The interface does expose the non-generic ReadDocumentAsync methods, so this just looks like an oversight.
I don't want to have to sacrifice using the IDocumentClient interface to get this functionality as I've found it extremely useful to be able to rely on the abstraction that the interface provides for the purposes of mocking while unit testing my repository layer.

I believe there are additional missing interface methods, such as CreateDatabaseIfNotExistsAsync. Seemingly at present, we to hack by downcasting the interface to access the method

+1  CreateDocumentCollectionIfNotExistsAsync too.

All of the IfNotExistsAsync methods are missing, would be great to have the full public API on DocumentClient added to IDocumentClient for easier mocking.

is there any ETA for this ?

CreateDocumentCollectionIfNotExistsAsync is also one of the missing action!

+1 would like to see ReadDocumentAsync in the interface if possible (also create if not exists).

Yeah its a little weird because we're supposed to create a singleton of the client accross your application, yet we can't effectively use the IDocumentClient provided without doing some hacky casting. Hopefully it is resolved soon.

Any news on this?

there is another issue: IDocumentQuery and IDocumentQuery<T> do not derive from IQueryable and IQueryable<T>, while their implementations do. This causes not only additional typecasting, but also makes unit testing much harder.

As per following this method is available:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.documents.client.documentclient.readdocumentasync?view=azure-dotnet#Applies_to
But still not found while i had installed latest  package Microsoft.Azure.DocumentDB 1.20.0

@AdrianSanguineti
Open source Microsoft's plan for DocumentDB Client .NET SDK is uncertain.
This feedback has no answer.
https://feedback.azure.com/forums/263030-azure-cosmos-db/suggestions/18902368-opensource-documentdb-net-sdk

OpenAsync() is another method not defined on the IDocumentClient interface, even in the 2.0.0-preview package.
The Performance Tips article recommends calling it to avoid startup latency: https://docs.microsoft.com/en-us/azure/cosmos-db/performance-tips

For ReadDocumentAsync<T>, might try this workaround:
var document = await _documentClient.ReadDocumentAsync(documentUri);
TResource res = (dynamic)document.Resource;


add a dirty workaround for poorly designed validation to fix #42

Changes Unknown when pulling 1b7f58d295e59f50e141b384bbcb523f27cd4dbe on fix/issue-42-invalid-field-names-in-validation-error-description into ** on master**.


Rounding of threshold can be a bit weird

Hi there,
I have just seen a weird situation, which probably goes down to rounding stuff up:
Epoch 20
pos

accuracy
precision
recall
support

all
0.9769
0.9287
0.9086
4147

unknown-tokens
0.9198
0.8135
0.8348
187

ambiguous-tokens
0.9376
0.9008
0.8695
930

<TaskScheduler patience="5" factor="0.5" threshold="0" min_weight="0">
    <Task name="pos" steps="0" patience="6" threshold="0.001" target="True"
            mode="max" weight="1.0" best="0.9769"/>
</TaskScheduler>
<LrScheduler lr="0.00056" lr_steps="0" lr_patience="2"/>

Epoch 22

accuracy
precision
recall
support

all
0.9776
0.929
0.9231
4147

unknown-tokens
0.9144
0.7081
0.7366
187

ambiguous-tokens
0.9409
0.9097
0.8829
930

<TaskScheduler patience="5" factor="0.5" threshold="0" min_weight="0">
    <Task name="pos" steps="2" patience="6" threshold="0.001" target="True" mode="max"
            weight="1.0" best="0.9769"/>
</TaskScheduler>
<LrScheduler lr="0.00042" lr_steps="2" lr_patience="2"/>

Bug ?
I post it here for later review, but I feel like if this rounds up, 0.9776 should still beat 0.9769 (978 vs 977) but who knows :)

Thanks ! I think you are right.


Logger implementation in profile_builder

Uses logger.info instead of prints and doesn't use tqdm if the user specifies a verbosity level above INFO.
Corresponding tests added.
Addresses #265

WIP until Jeremy and I come up with a more elegant way to handle TQDM with logging.

Will save more elegant TQDM solution for future PR


Changing TIWBSTabControl activepage by code

In a page of the iwbstabcontrol i have a label that has the onasyncclick event defined; it changes the activepage.
menu_tab.ActivePage:=5;
The first time this works but if i click again it has no effects.
thanks

Please check latest commit

it's ok now. thanks.


fix(@ngtools/webpack): implement getModifiedResourceFiles for Ivy AOT

This method enables the Ivy incremental compiler to track changes to resource files and their requisites.
Related https://github.com/angular/angular/pull/30954

To test this we should run our yarn test-large on Ivy, which we don't yet.


added docstring explanation for  bertenbeddings class in model.py in…

This change adds a docstring explanation for the class Bertembeddings inside of model.py inside of bert. This is my first open source commit and  I hope this helps!
Signed off by saul Ifshin<EMAIL_ADDRESS>

Thanks for the contribution. I'm going to close this though as I don't think the docstring is adding much here to help someone understand the purpose of that class (beyond the name itself), and it's somewhat inconsistent to just have one in that class and nowhere else.
If you would like to contribute some documenation or otherwise feel free to do so or open an issue / discussion if you are unsure of what to add.


Issue/2558 compliance check page

Description
closes #2558
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Pull request rejected by merge tool. Multiple change entry files found (changelogs/unreleased/2374-desired-state-compare-page.yml,changelogs/unreleased/2488-improve-environment-cards.yml,changelogs/unreleased/2496-fix-result-filter-boolean-key.yml,changelogs/unreleased/2544-add-bigint-support.yml,changelogs/unreleased/2558-compliance-check-page.yml,changelogs/unreleased/2607-fix-edit-form-embedded-entities.yml,changelogs/unreleased/2610-dependabot.yml,changelogs/unreleased/2616-dependabot.yml,changelogs/unreleased/2618-dependabot.yml,changelogs/unreleased/2621-dependabot.yml,changelogs/unreleased/2622-fix-file-fetcher.yml,changelogs/unreleased/2625-dependabot.yml,changelogs/unreleased/2628-config-tab-scrollable.yml,changelogs/unreleased/2650-recompile-button-fix.yml). This may happen when a change entry was removed from the remote repository due to a reverted change. In that case, make sure the latest changes from origin/master are merged into issue/2558-compliance-check-page before triggering merge bot.

Processing this pull request

Processing this pull request

Merged into branches master, iso5 in f3496540e72cfc67c59ae8ecd2e229d8d386db79


Maven plugin: malformed documentation page

The final part of page https://jeremylong.github.io/DependencyCheck/dependency-check-maven/configuration.html is malformed and hard to read.  The problem affects the description of the new nvdApiKey parameter.
BTW, since using the API key is "Highly Recommended" you could add a configuration example in the usage page at https://jeremylong.github.io/DependencyCheck/dependency-check-maven/

This will be fixed in the next release. See https://github.com/jeremylong/DependencyCheck/pull/6379


Option to use full population in TC

Reminder to self:

Look at difference between args.teammates_len and args.num_players

@avv-va on a separate note, can you please double check this section to make sure I'm requiring the correct number of population agents

Yes
On Thu, Nov 7, 2024 at 6:18 PM Joe Miceli @.***> wrote:

@.**** commented on this pull request.
In oai_agents/common/teammates_collection.py
https://github.com/HIRO-group/multiHRI/pull/43#discussion_r1833571848:

:param agents_perftag_score: The population of agents to select from represented as a list of tuples (agent, performance tag, score for this layout)
:param teamtypes: The list of TeamTypes to use to select teammates for each team
:param teammates_len: Total number of players on each team
:param unseen_teammates_len: For NXSP experiments, this is X, the number of unseen players that an SP agent is playing with
:param agent: The agent that the teammates will play with
:param use_entire_population: Flag inidicating if the entire population should be used, if False, this function will only generate one team for each teamtype
:returns: Dictionary of form {<TeamType> : [[team1], [team2], ... ] ...} and a list of all the agents that were selected for a team
'''

if use_entire_population:

   # If we want to use the entire population, we must check that the population is evenly divisible by the number of required agents

   required_population_size = 0

   for team_type in teamtypes:

       if team_type in TeamType.ALL_TYPES_BESIDES_SP:

           required_population_size += (teammates_len - 1)

@avv-va https://github.com/avv-va Follow up question on this... does it
make sense to you if I exclude SELF_PLAY_ADVERSARY from the consideration
since adversaries are added to the TC later on?
—
Reply to this email directly, view it on GitHub
https://github.com/HIRO-group/multiHRI/pull/43#discussion_r1833571848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKFWIHGYK7QNJIIRKRSA5Q3Z7QGNVAVCNFSM6AAAAABRDKUILWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRSGQ4TENJRGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

This mostly look good, just to confirm are you testing it this way? primary_train_types = [TeamType.SELF_PLAY_HIGH, TeamType.SELF_PLAY_MEDIUM, TeamType.SELF_PLAY_LOW] and not primary_train_types = [TeamType.SELF_PLAY_HIGH, TeamType.SELF_PLAY_HIGH, TeamType.SELF_PLAY_HIGH, TeamType.SELF_PLAY_HIGH, TeamType.SELF_PLAY_MEDIUM, TeamType.SELF_PLAY_MEDIUM, TeamType.SELF_PLAY_MEDIUM, TeamType.SELF_PLAY_MEDIUM, TeamType.SELF_PLAY_LOW, TeamType.SELF_PLAY_LOW, TeamType.SELF_PLAY_LOW, TeamType.SELF_PLAY_LOW,]  (which I think was the default on the main branch at some point)

Yes exactly. I'm changing the default in the main branch to use  primary_train_types = [TeamType.SELF_PLAY_HIGH, TeamType.SELF_PLAY_MEDIUM, TeamType.SELF_PLAY_LOW]

This looks good overall, good job! I added a few comments for readability purposes mostly. Besides that just make sure to do these tests before merging the code:
Run all these functions with args.teammates_len = 1 and 2:
SP(args=args)
FCP_traditional(args=args)
SPN_1ADV(args=args)
SPN_XSPCKP(args=args)

For this function: SPN_1ADV_XSPCKP(args=args) run it with primary_train_types = [H,M,L,ADV] and [H,M,ADV]

I have tested all of these configurations and they run successfully!

Everything looks good! After you address the last comment, merge it to main! Thank you!!


Hide "consider following" section on landing page of app

Maybe it would be ideal to have the option to customize the landing page, or choose which page is the default landing page. At least would like option to turn off friend suggestions.

Agreed, please!
Add and setting to Hide "Consider following..."  and
put a cool Keybase graphic instead
At least base the suggestions off of people you follow already.

Still no update on this?

I think this is a very important topic. "Consider following" is completely irrelevant as it is right now (Not based on interests or people already followed). I'm tired of looking at random pornographic profile pictures every time I start the app.


Customize Business App Tiles

With the move from home.dynamics.com to office.com/apps, the D365 model-driven apps appear as generic purple tiles. Where is the documentation for updating these tiles with custom images?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71a027bf-62d9-07f6-c15c-fc0e4d5b8686
Version Independent ID: f88d00be-be73-a187-c287-66f151073abb
Content: Quickly navigate apps with the Microsoft 365 app launcher - Power Platform
Content Source: power-platform/admin/quickly-navigate-office-365-app-launcher.md
Service: power-platform
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@crmpatrick
Thanks for your feedback. For product-related feedback, visit https://ideas.powerapps.com.


Code In push.on('notification', callback) Is Not Running When App Is Quit Out Of

Expected Behaviour
The app is closed (not in background and not in foreground). I send a push notification to the phone. Then it increases the badge number after 30 seconds if the person doesn't open the app.
Actual Behaviour
My on push.on('notification', callback) function doesn't get called if the app is closed. It seems to get called once I press on the push notification to open the app. But I want it to get called if the push notification is ignored.
My payload data has content-available set to 0 and it doesn't matter if I set it to 1 because content-available only applies when the app is in the background.
I looked at this diagram which was really helpful and it looks like what I want might not be possible with this plugin. I just want to confirm that this is true.

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
iPhone
iOS 9.2.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
haven't tried Android
Cordova CLI version and cordova platform version
cordova --version                                    # e.g. 6.0.0
cordova platform version android                     # e.g. 4.1.1

I'm leaving the rest of the details out because this might be expected behavior. If not, I'll open a new issue and include my code and other details.

@dmarcus1 if your app has been force closed there is no way to have the on('notification) event fire because the web view that would run that code is not in memory.

Wait, what is this about then?
IIRC this should work, with the proper "force-start": 1 key on the payload.

@fredgalvao user specified ios.

Oh right. I keep  forgetting that people don't fill the template correctly, and when I saw cordova platform version android at a glance I thought it was android.

I just re-read the docs and found that you can send a badge number in the payload.
"data": {
	"title": "Badge Test",
	"badge": 1
}

I quit out of the app on the iPhone. Then I sent it a push notification with badge in the payload and it updated the badge number even though the app was closed (not in foreground or background). That's what I need. Thanks for all of your help with this.

@dmarcus1 yeah, that is standard OS behaviour you get for free as long as you set the badge in the payload.

Does it only work with OS? I haven't tried sending that payload to android.

@dmarcus1 Android support is via shortcutbadger which is included by the plugin but it does not support all phones/launchers on Android.

Okay perfect. That's good enough if it works on all iOS and some Android.

Hello!
how can I increment the badge number icon with this plugin when the app is closed?
Thanks a lot

@MarinoRaul take a look at my previous comment. I got it to work by passing badge as a key in the data.


Failure in ServiceProvider initialization causes the main thread to die but the process is kept alive because of a non interrupted thread

I am working since days to put back on track the TcDbTests project and I've bumped into what I think could be a bug in core
For the context, the project hasn't been touched since 1 year ago... So it was working 1 year ago but in 2021 there has been so many changes in EE and Angela that the tests are now impacted when I use a new kit.
So here is the issue:
There are some security tests like this one: testNoPasswordInCredentialsSetup()
They are testing that some errors are expected to see in the logs when security is badly configured.
The problem is this line: tsa.startAll(); in the test never finishes because the TSA process is stuck.
The Security ServiceProvider initialisation is failing as we can see in the logs, but the server processes are kept alive, but in a sort of zombie state because the main thread  is gone. It is like the server was supposed to stop itself and exit, but it couldn't because of the SingleThreadedTimer that is maintaining a background thread has not been stopped.
dump.txt
stdout.txt

fixed with #1255


Doesn't work readFromDevice

I'm writing code where I need to pass a request and receive a response, but when I try to use the readFromDevice function it returns null.
I've already replicated this functionality in an app called "Serial Bluetooth Terminal" and it worked, which suggests that either the read isn't working or I'm doing something wrong. Can someone help me? please.
"react-native": "0.64.0"
"react-native-bluetooth-classic": "^1.60.0-rc.16"

How are you connecting to the device? What are you setting with regards to:

Encoding
Delimiter
Etc.

I'm guessing that you're not setting the same parameters during connection that you're using with Serial Bluetooth Terminal.   I use Serial Bluetooth Terminal to test Android to Android communication, so it should definitely work as long as you've setup your communication protocols the same.
For example:
Serial Bluetooth terminal defaults to \r while this defaults to \n - without this happening, chances are the buffer is building up.  I would suggest that you actually run #isAvailable() before attempting to read to ensure you actually have messages.
I would also suggest attempting to debug the Java code, it should be available to you.

I'm connecting in the standard way, via the RNBluetoothClassic.connectToDevice(id) . But I'm not setting any parameters in this connection... How could I do that?
Whenever I run the command RNBluetoothClassic.availableFromDevice(id) it returns 0.

I started a connection with the delimiter being \r, but the problem continues.

I'm not sure man, everything you're doing looks good; but I'm still fairly confident it's a data/configuration issue.  In order for me to help more I'm going to need you to provide a lot more debugging information:

Give me a little higher level of what you're actually doing?  Devices? Sample Messages? Etc.
Have you tried to debug the Java implementations of availableFromDevice to see if it's delimiting the messages properly?
Have you tired to debug the Java implementations of DelimitedStringDeviceConnectionImpl to determine what is being added to the buffer?
You're not actively listening for the READ event as well as manually requesting data?

Without, at a minimum this information, there isn't much I can do to help.
Maybe take a look through some of the closed issues with regards to reading from a device and see if any of them are similar to your issue?

I'm developing an application that will communicate with a Raspberry Pi 3, from which I send a string in JSON format to the Raspberry that will list the nearby wifis. I'm just calling a readFromDevice function, I'm not calling onDataReceived.
I don't know how to use Java, so unfortunately I can't answer the two Java-related questions.
Note: I found an issue similar to what I'm going through, but I couldn't solve it, even following the steps.
https://github.com/kenjdavidson/react-native-bluetooth-classic/issues/115
Ps: This image is how the code looks after the changes. Still returns 0

Unless you're willing to give me access to your project (and maybe I can find some way to simulate the data that you're sending) there isn't much I can do to help.
It could be time to start learning Java.

I managed to solve my problem through this issue https://github.com/kenjdavidson/react-native-bluetooth-classic/issues/120

Good to hear!
Curious why both of you using Pis have issues with /r and /n within the application though.  I'm personally using both of those based on the two types of microchip scanner that my company uses.

Hi, after a while with the same question I found out from the engineering team that the problem was actually in the python code that didn't have a delimiter defined.

I have the same issue, readFromDevice always returns null. Any help, please.

I have the same issue, readFromDevice always returns null. Any help, please.

I suggest opening a new ticket with substantially more information of you are having an issue.  Expecting help with one sentence and no details is essentially pointless.

Hi @kenjdavidson thanks for your response,
I changed my code from readFromDevice to onRecievedData now it's working!!
RNBluetoothClassic.connectToDevice(deviceId, { delimiter: ''})
const event = device.onDataReceived(data => console.log(data) // data recieved
If i removed delimiter from connectToDevice i got null
Thanks

If you have any extra questions please let me know.
Thanks

This looks like it's working as expected.  The default delimiter is '\n' and it looks like you've changed that to ''.
With the latest change it means that an empty delimiter will ALWAYS send data, ie. It will NOT use a delimiter.  I really don't know how I feel about a delimited connection ignoring delimitation, but it seems to be working for some of you guys.  so I'll leave it in there since it's easier than adding a whole new connection type.
If you remove the delimiter it's reverting back to '\n' and it would seem that you're not using \n as a delimiter.  So again, you need to:

Fully understand how you're sending data
Fully understand the API  with which you're reading
connect to the device using the appropriate delimiter

From what I can see, this is working as it's supposed to.


fix for XCode 11 / iOS 13 build errors with canSendWriteWithoutResponse

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Send Prometheus metrics to Grafana Cloud

Motivation
We're migrating our internal validators to send data to Grafana Cloud.
Proposal
Starting with the local setup. This was useful to test the required changes that we'll likely need for the actual internal validator setup. We probably won't want to send metrics to Grafana Cloud from local runs all the time (specially for cost reasons), so this is disabled by default.
Test Plan
Ran locally with linera net up --kubernetes, and saw the metrics in our Grafana Cloud instance:
Release Plan
If we want to start sending metrics to Grafana Cloud from our devnet/testnet, then:

These changes should be backported to the latest devnet branch
These changes should be backported to the latest testnet branch, then

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2994  👈 (View in Graphite)
#2986
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

The way I did it, either you do Grafana Cloud (writeToGrafanaCloud set to true), or you do the same existing setup we have right now. With Grafana Cloud, we don't need the Grafana pod, or the dashboards or any of that. So the idea is that for internal validators we run it with writeToGrafanaCloud set to true, and for external validators we run it with writeToGrafanaCloud set to false.
Ok, sure, I can do that. I thought it was fine since you need to be authenticated with gcloud for the secret to be successfully fetched 🤔


SearchPath does not work in connection string

My connection string
"ConnectionStringPostgreSqlProvider": "User ID=xxx;Password=xxx;Host=localhost;Port=5432;Database=myDb;SearchPath=idsvr4config,public;Pooling=true;",
but select in log is
 SELECT "u"."Id", "u"."AccessFailedCount",
 "u"."ConcurrencyStamp",
 "u"."Email",
 "u"."EmailConfirmed",
 "u"."LockoutEnabled",
 "u"."LockoutEnd",
 "u"."NormalizedEmail",
 "u"."NormalizedUserName",
 "u"."PasswordHash",
 "u"."PhoneNumber",
 "u"."PhoneNumberConfirmed",
 "u"."SecurityStamp",
 "u"."TwoFactorEnabled",
 "u"."UserName"
 FROM "AspNetUsers" AS "u"

why is not with schema prefix. This table is in schema idsvr4config

SchemaPath is a parameter to ADO.NET at the Npgsql level, and not at all to the EFCore provider. All it does is set PostgreSQL's search_path parameter when connecting - it's not supposed to make the EFCore provider change its queries.
I don't know exactly what you're doing, but if EFCore is generating the query then its EFCore's responsibility to know which schema the table is in. More information about your scenario may help understand.

Hi. I want to login and greb data for aspnetcore identity. And I thought that if I add search path, this will be used for prefix. So this is then problem if aspnetcore identity framework?

Are you selecting via EFCore, or writing your own SQL?

Everything is via EFCore. Is it possible somehow set default schema in connection string?

No, you cannot set a default schema in the connection string. You can set a default schema in EFCore by using the fluent API HasDefaultSchema() on your model.
But I don't understand... Did you use EFCore to create these tables? If so it's EFCore which created the tables in the idsvr4config schema, so it should also know to query from there. If you manually created the tables yourself (not sure why) then you may need to tell EFCore which schema the tables are in (via HasDefaultSchema() or a per-entity setting).
Disclaimer: I don't know anything about identity framework

In sqlserver2014 you do not have schemas. Everything is under dbo. In postgres I want to create own schema and not use public one. If i am using public schema then everything works.
Ok I will try with hasdefaultschema now. Thank you for hint.

Am closing as there doesn't seem to be any need for action. Feel free to continue posting here though.


cannot drag while in drawing mode

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.2.0
Leaflet Draw version I'm using: 0.4.12
Browser (with version) I'm using: chrome Version 61.0.3163.100 (Build officiel) (64 bits)
OS/Platform (with version) I'm using: win7

What behaviour I'm expecting and which behaviour I'm seeing
I expect the map to pan without drawing points everytime I click somewhere to drag the map
What I see is a new point drawn everytime I click to move the map
Minimal example reproducing the issue

click on polyline draw icon

click and drag the map

[x] this example is as simple as possible

[x] this example does not rely on any third party code

Using jsfiddle

I've tried 0.4.3, it's working:
https://jsfiddle.net/tgyeo8mm/
on 0.4.5 not working anymore

It seems to me like it's doing a _startPoint and an _endPoint with every _onTouch, which gets triggered every time a touchstart event happens. Is that not the touch equivalent of mousedown? So it's drawing a point as soon as the tap occurs. Should it not be making use of touchmove and touchend instead (in the same way mousemove and mouseup are used)?
I can start to take a shot at this today, as we're bumping up against this bug in our tests.

I don't have a PR, but I'll give an update on what I've found. I've got it working in iOS, but I've completely broken it in Android.
Given what Apple wrote here, it seems like iOS should "just work" with mouse events, and that seems to hold true when I change addHooks() like so:
map.off('touchstart', this._onTouch, this);
map.on('mousedown', this._onMouseDown, this);

But that completely breaks drawing on my Android device. My current guess is that Android doesn't do the same thing with mouse events that iOS does (my plan was to test this in a debugger but I haven't yet), and instead only responds to touch events (thus requiring something like what I said in my previous comment). The other possibility is there's a bug in the TouchExtend handler in Leaflet.draw, or a bug in the Tap handler in Leaflet.

I just wanted to add my vote to this issue being important. @mylen thanks for mentioning that 0.4.3 works. I must have missed that one and went back to 0.3.0, but only using the polyline routine from that version. I.e., I just import the polyline.draw.js from 0.3.0 directly into my app. This doesn't seem to be an issue for markers (at least I don't think so - I'm using in combo with leaflet.snap, and I may be cross-contaminating issues).
While I'm not going to do a PR (my understanding of events is limited), I hope that this can be resolved sometime. If I eventually get funding for my work, hopefully I can contribute to this, as leaflet draw is very nice.

Any news about this fix? Thanks!!!

is there any solution for leaflet 1+ version

@meteerogl I resigned using leaflet and drew back to openLayers

Solution:
(function() {
var originalOnTouch = L.Draw.Polyline.prototype._onTouch;
L.Draw.Polyline.prototype._onTouch = function( e ) {
if( e.originalEvent.pointerType != 'mouse' ) {
return originalOnTouch.call(this, e);
}
}
})();

Any news about this fix? Thanks!!!
(function() {
var originalOnTouch = L.Draw.Polyline.prototype._onTouch;
L.Draw.Polyline.prototype._onTouch = function( e ) {
if( e.originalEvent.pointerType != 'mouse' ) {
return originalOnTouch.call(this, e);
}
}
})();


Using @vite in a view that is rendered but a file response is sent back causes an exception

Laravel Version
11.22.0
PHP Version
8.2.23
Database Driver & Version
No response
Description
If you render a view in a request for building a file such as a pdf but return the pdf file you will trigger the following exception:
Call to undefined method Symfony\\Component\\HttpFoundation\\BinaryFileResponse::header() at /project/vendor/laravel/framework/src/Illuminate/Http/Middleware/AddLinkHeadersForPreloadedAssets.php:21)

The issue is that @vite compiles a list of urls to preload and the middleware will try to attach them to the response. It seems like the middleware should check what type of response it has before attempting to apply the header. I believe any of the ResponseFactory methods that return Symfony classes instead of Illuminate classes will also have this problem.
Steps To Reproduce

Use either jetstream/breeze to setup a new project (confirm for the inertia stacks)
Add a route to the web routes that renders a view containing @vite but returns a BinaryFileResponse
return response()->file(); or return response()->file();
Run npm run build (npm run hot does not compile the list of preloaded urls)
Try to download the file

One immediate work around is to use <link href="{{Vite::asset()}}"/> in the view instead of @vite()

Got a PR up to address this one. Will close this and we can follow along in the PR: https://github.com/laravel/framework/pull/52789


Port test_exceptions to Python 3.10 (GH-4042)

The test.support has been split into sub-modules. Adapt test_exceptions (originally coped from CPython) for these changes.
(cherry picked from commit 43cf17d4a4a68242d17e965e2aa4d10044d137a2)

I think this got merged into master with https://github.com/cython/cython/commit/0ec9be57f5770869cb2fbe36e00bbde405b3b855, so I'm not sure this PR is directly needed. But I could have confused myself here

I think this got merged into master with 0ec9be5, so I'm not sure this PR is directly needed. But I could have confused myself here

Perfect, thanks @scoder. I didn't know that you merged 0.29.x into master times to times.


Create a pull request template

Create a pull request template
an example can be found at https://github.com/americanexpress/one-app/blob/main/.github/pull_request_template.md
This tutorial can be followed
https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

Hi, I'd be happy to help you out with this. Could you assign me to this?

Awesome! assigned, reachout if you have any questions. You can use the above template and update the repository name

I would love to work on this issue. If this is still open Can I work on this @nellyk?


feat(COM): add more Core Audio interfaces

Description
Adds IAudioSessionControl2, IAudioSessionEnumerator, and IAudioSessionManager2 interfaces.
Related Issue
#936
Type of Change

[x] 🚀 feat – New feature (non-breaking change that adds functionality)
[ ] 🛠 fix – Bug fix (non-breaking change that fixes an issue)
[ ] ❌ ! – Breaking change (fix or feature that causes existing functionality to change)
[ ] ⚡ perf – Performance improvement
[ ] 🧹 refactor – Code refactor (no functionality change)
[ ] 📝 docs – Documentation update
[ ] 🎨 style – Code style changes (formatting, renaming, etc.)
[ ] 🧪 test – Test update or addition
[ ] 🔧 build – Build related changes
[ ] ✅ ci – CI related changes
[ ] 🗑 chore – Chore (maintenance, non-production code change)
[ ] ◀  revert – Revert a previous commit

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.18%. Comparing base (2f75003) to head (33e86fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   62.18%   62.18%
=======================================
  Files          34       34
  Lines        1145     1145
=======================================
  Hits          712      712
  Misses        433      433

Flag
Coverage Δ

win32
60.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Missing xconfig files when building app.

Describe the bug
When trying to build the app on XCode, the build fails. The only error is that 2 xconfig files are missing, namely: Pods-CardinalKit_Example.debug.xcconfig and Pods-CardinalKit_Example.release.xcconfig. Checking the cloned directories indicates that such a file doesn't exist in the project either.
To Reproduce
Unsure if this is specific to my install, but the process leading to the error was:

Configure the project
Connect device
Attempt to build the project.

Expected behavior
Build fails with the following two error messages:

The file “Pods-CardinalKit_Example.debug.xcconfig” couldn’t be opened because there is no such file. (/Users/parthav/Desktop/SWP/CardinalKit/CardinalKit-Example/Pods/Target Support Files/Pods-CardinalKit_Example/Pods-CardinalKit_Example.debug.xcconfig)
The file “Pods-CardinalKit_Example.release.xcconfig” couldn’t be opened because there is no such file. (/Users/parthav/Desktop/SWP/CardinalKit/CardinalKit-Example/Pods/Target Support Files/Pods-CardinalKit_Example/Pods-CardinalKit_Example.release.xcconfig)

Smartphone (please complete the following information):

Device: iPhone 13
OS: iOS 15.6.1

Hi @parthavshergill, have you run pod install to install dependencies via Cocoapods?

Yes, I have, but I'm still encountering the same error.

Are you opening the 'CardinalKit.xcodeproj' file or the 'CardinalKit.xcworkspace' in Xcode? Make sure you are opening the 'CardinalKit.xcworkspace' file only as the .xcodeproj file will not include the pods.

I'm opening the CardinalKit.xcworkspace file but it is still resulting in the same error.

Hey @parthavshergill the files you're missing are autogenerated by Cocoapods, so it's possible that something went wrong when installing the pods. I would recommend running pod deintegrate in the CardinalKit-Example folder and then running pod install again.
Do you have any other ideas @PSchmiedmayer?

@parthavshegill If you don’t mind me asking, when did you start using the
CardinalKit platform?
On Sat, Oct 22, 2022 at 7:57 PM Vishnu Ravi @.***>
wrote:

Hey @parthavshergill https://github.com/parthavshergill the files
you're missing are autogenerated by Cocoapods, so it's possible that
something went wrong when installing the pods. I would recommend running pod
deintegrate in the CardinalKit-Example folder and then running pod install
again.
Do you have any other ideas @PSchmiedmayer
https://github.com/PSchmiedmayer?
—
Reply to this email directly, view it on GitHub
https://github.com/CardinalKit/CardinalKit/issues/146#issuecomment-1287951684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATXFQM7VCQEMRNQIMEGE5NTWER5PZANCNFSM6AAAAAARLSW2ZY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Conner McCraw
MS | Appalachian State University
RCEP | American College of Sports Medicine

@vishnuravi Running pod deintegrate and then pod install resulted in a few different build errors:

CardinalKit/CardinalKit-Example/CardinalKit/Library/ResearchKitOnFHIR/FHIRToResearchKit/ORKNavigableOrderedTask+FHIR.swift:11:8: No such module 'ResearchKit'
Command CompileSwift failed with a nonzero exit code
Command EmitSwiftModule failed with a nonzero exit code

@parthavshergill we haven't been able to reproduce this issue yet, could you let us know what version of Xcode and Cocoapods you are using?

I'm using Xcode version 13.4.1 and Cocoapods version 1.11.3.

Hi @parthavshergill
Thank you for reporting the issue!
I have created a new PR that tries to make builds more reproducible and might also help with this issue.
Can you please ...

Close Xcode
Install the latest version of Xcode (Xcode 14.0.1 or even better 14.1 if you have access to the RC from the Apple Developer Portal)
Remove the derived data folder, e.g., following https://programmingwithswift.com/delete-derived-data-xcode/.
Do a new clone of the repo in its latest state (completely remove the current version of the cloned repo on your machine or move it somewhere else)
Navigate your terminal in the CardinalKit-Example folder and run pod install --repo-update.
Open the newly generated CardinalKit.xcworkspace
Try to build the application again.

Thanks @PSchmiedmayer. These steps resolved the problem - closing the issue now.


Support for behaviours at canvas level in v3

The v3 - Mixed behaviours fixture currently shows images as individuals rather than paged for the canvases that have paged at canvas level:
ThumbnailPanel

Ref #4


refactor: simplify app server creation

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #4261 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #4261      +/-   ##
==========================================
+ Coverage   92.34%   92.35%   +<.01%
==========================================
  Files          52       52
  Lines        1711     1700      -11
  Branches      445      440       -5
==========================================
- Hits         1580     1570      -10
+ Misses        125      124       -1
  Partials        6        6

Impacted Files
Coverage Δ

packages/server/src/server.js
100% <100%> (+1.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e0890...5a2a62b. Read the comment docs.

@clarkdo @galvez #4259 covers this improvement. I can cherry-pick goodies from here :)

https://github.com/nuxt/nuxt.js/pull/4259/files#diff-9a38d0846ebfd064bbe0e1a373d70c09R189

@clarkdo @galvez #4259 covers this improvement. I can cherry-pick goodies from here :)

Cool, you can close this one after cherry-pick 😸

@clarkdo Sure! Feel free changing anything if needed over there.


Docker occasionally re-pulls layers it already has

There are some cases where the Docker client will pull layers that it already has (as in the same hash is already part of one of its other images) again. It seems like it uses more than just the hash to determine whether a layer needs pulling (huh?), need to dig into this.

Docker downloads layers using the LayerDownloadManager, implemented in moby/distribution/xfer/download.go.
The logic in Download deals with skipping layers that already exist, but I'm still working my way through it.

This is probably due to https://github.com/moby/moby/issues/38446.
My theory is that this is a leftover in Docker from the era before content-addressable image layers, where the order actually mattered.

From what I remember, the docker engine (moby?) still doesn't store layers in the Registry v2 sense, but in the ordered v1 model, where each layer contains "the whole layer stack so far". CoW (via OverlayFS or whatever else) is set up per layer stack...

For a bit of perspective - if I remember correctly, the initial versions of Docker back in 2013 did store the layers separately, and used AUFS to merge all the layers (and add the read-write layer on top of it). Later (2015ish maybe?) when support for other storage drivers was added, this changed, because other union filesystems (like overlay and overlay2) don't support merging many layers like AUFS does. So when an image is pulled, it gets materialized into a single read-only layer.
My knowledge of Docker internals is out-of-date, so I don't know if the engine keeps the blobs that it downloads after having unpacked an image. If it does, this should be an easy fix; otherwise it might be more complicated because there might be some resistance given that this would increase disk usage :/

Hello there, I stumbled upon this and investigated a bit more. Nowadays Docker supports containerd as the underlying image store. That one does properly reuse layers regardless of their order 🎉!
Not sure if it's relevant to this project, but posting here just in case.


Unable to scale nodes on gcp

Unable to scaleup an existing setup on GCP. Need to add a few more nodes and keep running into this issue.
BUG REPORT
BUG REPORT INFO
Environment

Cloud provider:  GCP

OS details : RHEL 7.4

Version of Ansible : <IP_ADDRESS>

Version of Jinja :  2.7.2

The openstack-ansible-contrib version (commit) :  4382587

Copy of inventory files and custom variables used (please omit your secrets!):
Command used to invoke ansible:  ./ocp-on-gcp.sh --scaleup
Output of ansible run:
[WARNING]:  * Failed to parse /home/vikas_roonwal1/fresh_start/openshift-ansible-contrib/reference-
architecture/gcp/ansible/inventory/gce/hosts/secrets.py with ini plugin: /home/vikas_roonwal1/fresh_start
/openshift-ansible-contrib/reference-architecture/gcp/ansible/inventory/gce/hosts/secrets.py:1: Expected key=value
host variable assignment, got<EMAIL_ADDRESS>[WARNING]: Unable to parse /home/vikas_roonwal1/fresh_start/openshift-ansible-contrib/reference-
architecture/gcp/ansible/inventory/gce/hosts/secrets.py as an inventory source
[DEPRECATION WARNING]: 'include' for playbook includes. You should use 'import_playbook' instead. This feature
will be removed in version 2.8. Deprecation warnings can be disabled by setting deprecation_warnings=False in
ansible.cfg.
ERROR! conflicting action statements: shell, async
The error appears to have been in '/home/vikas_roonwal1/fresh_start/openshift-ansible-contrib/roles/atomic-update/tasks/main.yml': line 51, column 5, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:

name: Reboot when patched
^ here

The error appears to have been in '/home/vikas_roonwal1/fresh_start/openshift-ansible-contrib/roles/atomic-update/tasks/main.yml': line 51, column 5, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:

name: Reboot when patched
^ here

exception type: <class 'ansible.errors.AnsibleParserError'>
exception: conflicting action statements: shell, async
The error appears to have been in '/home/vikas_roonwal1/fresh_start/openshift-ansible-contrib/roles/atomic-update/tasks/main.yml': line 51, column 5, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:

name: Reboot when patched
^ here

Thanks

Please try to use Ansible 2.3. Ansible 2.4 is not fully supported yet.

Issue in ansible 2.4 preventing our code to run: https://github.com/ansible/ansible/issues/33177


Validating Hits

Thanks for the great repo! Only thing that I would suggest is being able to do hit validation to help with debugging.
https://developers.google.com/analytics/devguides/collection/protocol/v1/validating-hits

I wasn't aware of this new feature! Thanks for pointing it out.
I'll check later how to implement it into the library.

You can try this https://github.com/amit0rana/php-ga-measurement-protocol/tree/validating_hits_debug_mode
Checkout Use Case section in Readme

This feature was implemented in f9e8cef2ac89012bb9112a7130a9c0aa51a733e4
Update to the latest version (should be automatic in your deployment pipeline if you used "^2.0" in Composer)


PayPal sandox not responding?

I tried to use Django Paypal via Django by Example book. All went OK and example is same as examples over the net. But while in test mode, when redirected to Paypal sandbox, nothing happens. I get blank page and nothing more. Looks like wrong URL or calling? If i turn off testing and go live, payment works as expected.
Django: 1.11.2
Python: 3.5.2
Django-PayPal: 0.3.6

I get the same thing. As far as I can see, this is a PayPal issue - looks like they broke their sandbox. You should contact their support.
Another recent report of the same thing - https://stackoverflow.com/questions/44736319/sandbox-paypal-white-blank-screen-nothing-happen

Aha, thanks for info!


Https issue behind reverse proxy (traefik)

Hello,
anyone successfully put this behind reverse proxy ?
I'm puting it behind traefik, but as traefik entrypoint is HTTPS and gip is HTTP there is issues as the generated code call css in forced HTTP
Mixed Content: The page at '<URL>' was loaded over HTTPS, but requested an insecure stylesheet '<URL>'. This request has been blocked; the content must be served over HTTPS.

i tried to put the container in SSL, but then i have login issues (using LDAP)
is there something doable around that ?
I think the issue is in the code, calling files with a leading "/" instead of "//" or nothing even
<link rel="stylesheet" href="/css/bootstrap/bootstrap.min.css">
to
<link rel="stylesheet" href="css/bootstrap/bootstrap.min.css">

would work
Thanks

bump

bump

I solved this with following options in .env
USE_SSL="yes"
CONTAINER_PORT="443"
HOST_PORT="1443"
I generated self-signed certificates and mounted them as volumes with the following docker-compose
volumes:
- ./apache/certs:/etc/apache2/ssl/certs
- ./apache/keys:/etc/apache2/ssl/keys
in your reverse proxy, such as nginx and assuming its running on same host:
proxy_pass https://<IP_ADDRESS>:1443;

@vkhatuwala  Was this the only way you got it? I want to use reverse proxy with Nginx.

@cairoapcampos I am also using nginx reverse proxy as per my example.

@vkhatuwala  I did the same as you and I got the error: 400 bad request.  Did you set SERVER_NAME ?

@vkhatuwala I did the same as you and got the error: 401 Unauthorized. Did you set SERVER_NAME?

I found that when I disabled proxy_intercept_errors on in Nginx reverse proxy, the 401 error disappears. I can log in but the page doesn't load the menus correctly.

@xfouloux said:

anyone successfully put this behind reverse proxy ?
I'm puting it behind traefik, but as traefik entrypoint is HTTPS and gip is HTTP there is issues as the generated code call css in forced HTTP
Mixed Content: The page at '<URL>' was loaded over HTTPS, but requested an insecure stylesheet '<URL>'. This request has been blocked; the content must be served over HTTPS.

i tried to put the container in SSL, but then i have login issues (using LDAP)
is there something doable around that ?

Hiya!
We seem to have found a solution to the LDAP issue when "USE_SSL = 'Yes'", whether it's behind a reverse proxy or not.
(We are on NGINX at the time of this discovery and writing.)
We've put it into our internal documentation to copy-paste-run the following lines in the docker console for the container after it's deployed and running:
sed -i "s|AuthFormProvider file|AuthFormProvider file ldap|g" /etc/apache2/sites-available/gestioip.conf
sed -i "s|AuthUserFile /etc/apache2/users-gestioip|AuthUserFile /usr/share/gestioip/etc/apache/users-gestioip|g" /etc/apache2/sites-available/gestioip.conf
sed -i "s|ErrorDocument 401 /login/login.html|ErrorDocument 401 /gestioip/login/login.html|g" /etc/apache2/sites-available/gestioip.conf
sed -i "s|ErrorDocument 403 /errors/error403.html|ErrorDocument 403 /gestioip/errors/error403.html|g" /etc/apache2/sites-available/gestioip.conf
sed -i "s|ErrorDocument 404 /errors/error404.html|ErrorDocument 404 /gestioip/errors/error404.html|g" /etc/apache2/sites-available/gestioip.conf
sed -i "s|ErrorDocument 500 /errors/error500.html|ErrorDocument 500 /gestioip/errors/error500.html|g" /etc/apache2/sites-available/gestioip.conf
sed -i "s|AuthFormLogoutLocation /login/logout.cgi|AuthFormLogoutLocation /gestioip/login/logout.cgi|g" /etc/apache2/sites-available/gestioip.conf
service apache2 restart

This is basically updating the gestioip.conf file to more closely reflect its original self when USE_SSL was set to No before enabling it to Yes. There's a few other lines in the No version that we'd didn't pull over, like LimitRequestLine, TimeOut, and Require ip; but that hasn't seemed to have a negative effect on our setup (yet, teehee!).
I hope that can help someone else out there that's fighting with Docker + GestioIP + LDAP + SSL + Reverse Proxy.

If you are running this application behind a reverse proxy, that is also handling SSL, then you can just change the URL writing. For this to happen, just change the default variable called "server_proto" to "https" like in the example below. This configuration shouldn't have an impact on, the Apache Web server itself.
#/var/www/html/gestioip/modules/GestioIP.pm
sub get server proto {
        my $self = shift:
        my $server_proto="https";
        if ( SENV<HTTPS} ) {
               $server_ proto = "https" if $ENV{HTTPS} =~ /on/i;
        }
return $server proto
}


Refactor sending of responses

Remove the responses.py module and move the logic of sending responses to the connections.py module.
Reasoning:

connections.py module already has knowledge of the types of requests and responses that are expected.
It will allow for HTTP/2 Server Push and custom WebSocket Denial Responses to be easily added as the connections.py module can control this logic.

Limitations:

Cannot create a custom response for the connections.py module to send. Will implement the above such that fine control can be had over the responses that are sent.

Originally posted by @jonathanstaniforth in https://github.com/jonathanstaniforth/xiao-asgi/issues/11#issuecomment-968093941

Implemented in commit: fd28305ef0deb3f53ac571c14ab19364fc3ed011


Refactoring of tests

Once #19 is merged we could get rid of all fakeaudit/fakeResource.go files with one helper function in utils.go that just traverses the test folder and builds very thing it needs on the fly. What do you think about this @jinankjain

Sounds good 👍


Setup docker

As a developer
I want to build and store a docker image
So that I re-use a docker image for testing and deploying the application
AC:

[x] create DockerFile using cass-ciip as a template
[x] create github action workflow that builds and publishes the docker image to github packages
[x] ensure docker image is correctly built and published to github packages

@wenzowski I would like to get any input you have regarding building and storing and deploying a docker image.

CLOSED - Docker implemented


Update what-s-new-in-ssma-for-sybase-sybasetosql.md

#sign-off

@nilabjaball : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Merging exception per email


Adding support to create a context for webgl2.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for automatic discovery of TP-Link switches, bulbs and dimmers

Description:
This is a continuation of #15329 and adds support for automatic discovery of TP-Link bulbs, switches, and dimmers based on the new config flow. The integration needs to be enabled either in the integration configuration or alternatively by adding tplink component to the configuration file. As the devices are now configured on the component, this is a breaking change for light.tplink and switch.tplink.
Other changes:

Support for HS220 dimmers (these are internally switches which have a light-like interface)
Support for device info
Platforms are now embedded inside the component
Removal of enable_leds configuration. I doubt its usefulness as a static configuration variable, but if someone wants to really have that, supporting that feature should be done by introducing a service to change its value.
Fixes HSV setting for lights (hue was previously capped to 359 degrees)

Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7338
Example entry for configuration.yaml (if applicable):
tplink:
  discovery: true
  light:
    - host: 192.168.xx.xx
    - host: <IP_ADDRESS>
  switch:
    - host: 192.168.xx.xx

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

I will add documentation soon. @balloob what types of tests the configuration flow requires?

all steps of the config flow need to be tested to make sure the data comes in and out as expected.

Really looking forward to this PR ! 🎉 Cheap switches for everyone

The tests are still missing -- just to be sure that I understood it correctly, as there are no real steps in the flow, I would just need to add tests for async_setup_entry to test that the resulting lists under the DOMAIN are correctly filled for a given dummy configuration, or is there something more to do?

That's it.

@balloob sorry for the delay, I'll adapt based on commentary from Martin, however, I'm not exactly sure how to test this properly. The tests done for sonos are very basic (and they feel to test more or less the functionality of the data flows in general, not the sonos specific pieces. I'll nevertheless try to find time this week to figure that out and finish this PR.

Testing the data flows is exactly what we want. Adding TP-Link tests can be done in the future.

Rebased on top of the current dev, I'll add tests based on google cast tests (extending where necessary).

This might not be the place to ask this, but why the heck do you guys need to break stuff regulary? We had a nice easy way to use the tp link switches INCLUDING out of the box power readings.
Sorry, but i am really angry about this right now, as this happenes almost every release. Last time ZHA was broken completely and is useless, this time it will be the tplink switches. Whats next?
My current installation is not able to turn the lights on or turn any switches on. This basically makes hass obsolet as i have to do everything manually again.
rambling over

@speedmann Where is the thank you? How much did you pay exactly for this product? We are working on making Home Assistant more accessible to more users, easier to set up and easier to use. We will keep breaking all your stuff, again and again, until we get there.
If you don't have the technical knowledge to see how these changes are a big step up for this component and Home Assistant, don't comment. Definitely don't come here attacking us with some baseless accusations that make it sound like we break things for the sake of breaking things.

On top of that, this change should not have changed anything regarding to the power readings, so if that's the case a new issue should be opened for that. The only real breaking change this PR should have introduced is that the name of the device is not configurable via config file, but is read out from the device.


EC_K8S_NAMESPACE needs checks

This env variable decides which cluster namespace you are deploying to. If blank it deploys to local docker/podman.
The issue is that this happens silently and there is no check that you are doing the right thing.
Solution:

make beamline values.yaml contain a namespace value
verify that we are deploying to the namespace specified there
error if not (perhaps allow a forced overrride?)

Also suggested by other team members:

have an ec function that reports the current beamline config
set an environment variable for possible inclusion in your prompt

fixed in f4e0fc03bf197e43
we now have ec env and EC_K8S_NAMESPACE=local or = K8s namespace


Searching Patient by Identifier using only System returns InternalServerError

Describe the bug
Searching Patient by Identifier using only System returns InternalServerError when properly formatted.
{"resourceType":"OperationOutcome","issue":[{"severity":"error","diagnostics":"FormatException: Token query parameters should at least specify a value after the '|'"}]}

I've tested this with both HTTP GET and HTTP POST search APIs. Both return the same failure, shown above.
This affects attempts to find all patients with Identifiers within a given System. E.g., searching for all patients within a specific patient domain OID.
To Reproduce
Steps to reproduce the behavior:

Send a Patient search request to Spark reference server. Include a system, including the
trailing |, but exclude a value. Example: https://spark.incendi.no/fhir/Patient?identifier=urn%3Aoid%3A94461.90476.88752.74168.65258.97141.17793|

Expected behavior
A Bundle with matching search results should be returned.
Additional context
I can confirm that searching by a system and value ([parameter]=[system]|[code]) works. Additionally, if the trailing | is omitted then it successfully performs a search based upon value, matching the [parameter]=[code] pattern.
However, following the  documented [parameter]=[system]| pattern, the error shown above occurs.

Thanks for reporting this. Fixed on r4/master and stu3/master


Switching to multi-JDK image, enriching build manifest with desired JDK version

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Use new CI Docker images, enriching build manifest with desired JDK version. The build manifest has been enriched with new optional build property jdk:
build:
  name: OpenSearch
  version: 2.0.0
  jdk: "11"

This build manifest is being read in preparation to running Jenkins job and the its JDK version, if specified, is enforced (the defaults stay unchanged and use JDK-14).
Issues Resolved
Part of https://github.com/opensearch-project/opensearch-build/issues/732
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I would +1 following GHA idioms. But I am completely lost in Python, it goes way beyond my expertise, @peterzhuamazon could you give me a hand here? I can definitely implement the image support in manifest but will drown in dependencies + build environment manipulation.

I'd be happy to help. Try getting the image going and I can take care of dependences on top of that?

@dblock thank you, I was looking also into https://github.com/opensearch-project/OpenSearch/blob/main/Jenkinsfile and it seems like it uses predefined agents search-cloud-ec2-c518xlarge, which we have to rebuild out of new images, any hints / people who could help with that?

@peternied @peterzhuamazon ?

I would +1 following GHA idioms. But I am completely lost in Python, it goes way beyond my expertise, @peterzhuamazon could you give me a hand here? I can definitely implement the image support in manifest but will drown in dependencies + build environment manipulation.

I'd be happy to help. Try getting the image going and I can take care of dependences on top of that?

@dblock thank you, I was looking also into https://github.com/opensearch-project/OpenSearch/blob/main/Jenkinsfile and it seems like it uses predefined agents search-cloud-ec2-c518xlarge, which we have to rebuild out of new images, any hints / people who could help with that?

@peternied @peterzhuamazon ?

Are you trying to ask what change have I done to that Jenkins Agent?

Are you trying to ask what change have I done to that Jenkins Agent?

@peterzhuamazon more precisely, if this agents uses the same CI multi-jdk images you've published or is uses different ones?

They use the one you define in the Jenkinsfile.

@peterzhuamazon Sorry, I am not following, this is a complete Jenkinsfile (https://github.com/opensearch-project/OpenSearch/blob/main/Jenkinsfile), it uses labelled agents which have to be provided by Jenkins.
pipeline {
    agent { label 'search-cloud-ec2-c518xlarge' }

    stages {
        stage('Build') {
            steps {
                echo 'Building..'
                // Disable backward compability tasks
                sh './gradlew check --no-daemon --no-scan -Pbwc_tests_enabled=false'
            }
        }
        stage('Test') {
            steps {
                echo 'Testing..'
            }
        }
        stage('Deploy') {
            steps {
                echo 'Deploying..'
            }
        }
    }
}

The docker image will run in those agent you defined.
No need to change the agent as long as you define the docker image, they will for sure run in those Jenkins agent.
The Jenkins agent act as a Docker Host.
https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch-dashboards/Jenkinsfile#L27-L32


Running this tool regularly with npx is slow

What's the problem?
Our currently recommended usage of the @financial-times/github package is to run it with npx e.g.
npx @financial-times/github

This works great during development, or if the CLI tool is one that you only run very occasionally, however if it's a CLI tool that you run regularly (like this one), it can really slow down your workflow and become quite frustrating to use that tool. This is due to the fact that when npx runs a package from the npm registry or from GitHub, it pulls down that package's dependencies every time that you run it - npx cleans up all downloaded dependencies after every run of a package. This is an intentional behaviour on the part of npx, but it is ultimately what introduces the slowness a developer will experience when running a CLI tool regularly in this way.
Potential solutions

Change the recommended usage to installing this tool globally with npm (i.e. npm install -g @financial-times/github) and integrate a mechanism to notify users when an update is available
This is the best (and only) idea I have right now - suggestions very welcome!

Prior art for package update notifications
Like many developers working with Node.js, I have the npm CLI globally installed - I think does a pretty nice job of notifying you when there is an update available to install:

See the code that makes the magic happen
As you'll see from the code in the npm CLI, they're using update-notifier. I think it would be worth considering this library as a way for us to introduce update notifications into this package (@financial-times/github).

I really like this idea! 👍
I generally have the ebi code checked out and run from ./bin/ebi.js because of the startup time of npx.
npx is super great for people new to the repo or reviewing PRs on arbitrary branches, so people don't have to check out the code though, so I think it's still worth mentioning it somewhere in READMEs etc.

Note to self:,  update-notifier could possibly be a valuable feature for secret-squirrel

To run a global installation of this package, but fallback to downloading it and running it from npm if it's not available, we can use the following command:
npx @financial-times/github

Non-fallback way of running a global installation of this package:
github

I really like how npm's update notification includes a link to the release notes on GitHub, but I've avoided implementing that in this tool for now as it would require putting together a custom notification and adding another third-party dependency so that this notification can have nice colours. The default notification provided by update-notifier seems good for now.