Node doesn't start due to invalid time?

Hi,
I'm trying to use your package for a SLAM project, but I'm running into a weird issue when launching the localization node.
The drl_localization_node starts up but remains stuck in a loop, posting the message "Waiting for valid time...", which corresponds to this loop:

Have you ever run into this problem before? If so, could you be so kind as to provide some information in order to solve it?
Thanks!

Hello,
That happens when drl is waiting for valid time or waiting for a valid map / reference point cloud.
The reason for that part of the code was to allow the loading of the map / occupancy grid (in the message handler) while a rosbag is paused (and that way, allowing drl to be ready to process the sensor data when you start playing the rosbag).
If you did not set the parameter use_sim_time to true and do not have a rosbag paused, then drl is waiting for a valid map in the configured topics.
http://wiki.ros.org/Clock
You can provide the map in a .ply file:

https://github.com/carlosmccosta/dynamic_robot_localization/blob/noetic-devel/launch/dynamic_robot_localization_system.launch#L32

Or from an OccupancyGrid / PointCloud2 ros message:

https://github.com/carlosmccosta/dynamic_robot_localization/blob/noetic-devel/launch/dynamic_robot_localization_system.launch#L45
https://github.com/carlosmccosta/dynamic_robot_localization/blob/noetic-devel/launch/dynamic_robot_localization_system.launch#L47

For publishing a OccupancyGrid you can use map_server:
http://wiki.ros.org/map_server
For publishing PointCloud2 you can use point_cloud_io:
https://github.com/carlosmccosta/point_cloud_io#read
For avoiding confusion, I made the message clearer with the last commit:
https://github.com/carlosmccosta/dynamic_robot_localization/commit/72b1ba3f78cff6311f5ae51e83dca9597ddcb2b7
Have a nice day,


Array support

So far I've managed to fix all tests except one: Notation.Glob .normalize().
I've hit quite a dead end because after fixing this one Notation.Glob.union() breaks.
Anyway, I'll try to fix this last test as soon as possible.

Well, you're right. Right now in case of the simple object like { ['weird-property']: 0 } everything would be okay if notation would look like a.weird-property but if written in valid JS syntax a['weird-property'] utils.splitNotation would result in [ 'a', '[\'weird-notation\']'].
Simply removing outter brackets from non-numeric property strings should do the trick without any major changes.
I believe a['1'] would be recognized as object property right now. But still, brackets and quotemarks would be left intact which would break program.

See the new branch I've been playing with for the last 2 days:
https://github.com/onury/notation/blob/bracket-support/src/core/notation.js
Let me know what you think.
Notice how Notation.split() & Notation.join() is done now.
Also see utils.normalizeNote().
These validate the notation against 1) JS variable syntax 2) proper object bracket notation 3) proper array index notation.
Removed Jasmine in favour of Jest with test-coverage. This seems crucial. Notation is a complex library, so coverage is crucial. Fixed many bugs on the way.
Couldn't look inti Notation.Glob yet.

Also see this article https://mathiasbynens.be/notes/javascript-properties
Right now in bracket-support branch, a notation of a[123] will throw if a is not an array.

I've checked out bracket-support and tested it for a while.
I like changes to .split() and .join() functions. Also, bracket notation detection works great.
Of course some NotationGlob tests fails but I believe it is mostly because  of normalize and toRegExp methods.
So what is the plan now? Should I fork your bracket-support and help you with fixes or wait until you're done and apply changes I made on updated master?
If you want I can add comments to changes I commited to explain why specific change was needed with some example so it will be easier to understand.

Yes @marcinkumorek. For now it's better to wait a couple more days.
I made some more fundamental changes.
For instance, I'm not using regexp#test() any more to check whether globA matches/covers globB. Since the notes (either array index notation, object bracket notation or JS var syntax) are checked strictly, regexp A will never match a wildcard in globB (in .normalize() for example) with regexp.
.normalize() is improved and passes the tests now.
Let me fix .union() now, which is the only method left in NotationGlob.
Then we'll need the following:

since we don't depend on toRegExp() anymore, check/decide whether to remove it and also .regexp property.
test/revise Notation#filter() method
UMD module build is broken. Fix webpack config.
add a bit more tests maybe?

I will still mention you and your help with this in readme and changelog;  even if we don't merge branches. But if you're still willing to; I'd appreciate any help with these items. Yes you'd need to fork bracket-support branch. Also let me know whichever part you think, should go into bracket-support branch from your current, instead of the current.
A side-note:

Always PR for one specific thing. Otherwise it's really hard to follow (when made too many huge changes).
Never send PR from a master. Pls name your fork e.g. bracket-fix-webpack or something.

cheers.

Thanks for the tips. As for credits, I don't really care about them and you're the one that does most of the work here ;]
So, I'll try to look into your branch in a couple days if I find some free time.
As for code from my forked repo it's hard to tell which part of it should go to your branch since your code will use different methods now and some code may be completely redundant. After I'll check your branch I'll let you know.

Thank you.
Plus, discussions/ideas sometimes are better contributions than code. I really appreciate that.
Let you know when I'm done shortly.

Hello all.
Is it live?


Share Training Log

Hi HuguesTHOMAS! Thank you for your awesome work!
I followed readme.md and successfully test your pretrained model, but when I train your model, I found that the validation loss varied a lot during training process. For example, in epoch 400 I got mean IOU 68.6% on S3DIS validation data, but just after one epoch it changed to 60.8%.
Is this Ok? Could anyone share his/her training log?
Looking forward to your reply.

It could be normal, as the validation during training is performed on a small subset of the whole validation cloud. Depending on which part get picked, the score can be quite different. YOu should not refer to the printed message for evaluating your training performances.
Instead, you can use the plot_convergence.py script which plots both training metrics (time, loss), and then validation metrics. The validation metrics include the averaged score on the subsets picked at each epoch (the numbers you see printed), but also an overall score computed on the whole point cloud once in a while (only for epochs where a checkpoint is saved). This last score is the one that you should refer to for real performances.
Eventually, when your training is finished, you can use the test_models to have a final evaluation of the score with voting etc.

Thank you！！！！！！
I trained once and got 67.0% mIOU,  I think it is close enough to your paper (67.3%)!!!  There are so many works (even CVPR ICCV) can not perform well as they reported in their paper. Some of them do not have code!  KPConv worth the best paper!!!

Thank you！！！！！！
I trained once and got 67.0% mIOU, I think it is close enough to your paper (67.3%)!!! There are so many works (even CVPR ICCV) can not perform well as they reported in their paper. Some of them do not have code! KPConv worth "the best paper"!!!

Thank you!!! I got 67.0% mIOU, I think it is close enough!!


Lambda warmup is way too slow

Look into using something like this https://www.npmjs.com/package/serverless-plugin-warmup
Only real caveat here is that we have to worry about the subnets ids.

closed by #13


Access disposed canvas in VM causes segfault

This code causes a segfault currently:
test('use canvas after endRecording', () {
  final PictureRecorder recorder = PictureRecorder();
  final Canvas canvas = Canvas(recorder);
  final Picture picture = recorder.endRecording();
  canvas.restore();
});

The final call to canvas.restore should be an error but not a crash.
@c-h-i-a-m-a-k-a-2 fyi

I think this is a more general bug in the FFI dispatcher - we unconditionally call methods on receivers even if the receiver is nullptr.

This happens for any object with a dispose method on it, for example if you call dispose twice, e.g.:
final SceneBuilder builder = SceneBuilder();
final Scene scene = builder.build();
scene.dispose();
scene.dispose(); // segfault

@dcharkes - I'm not quite sure how to fix this without help from the Dart team, I think we'd want this to throw a Dart exception (e..g StateError('Object disposed')).

Relevant code
@pragma('vm:entry-point')
class Scene extends NativeFieldWrapperClass1 {
  /// This class is created by the engine, and should not be instantiated
  /// or extended directly.
  ///
  /// To create a Scene object, use a [SceneBuilder].
  @pragma('vm:entry-point')
  Scene._();

  // ..

  /// Releases the resources used by this scene.
  ///
  /// After calling this function, the scene is cannot be used further.
  ///
  /// This can't be a leaf call because the native function calls Dart API
  /// (Dart_SetNativeInstanceField).
  @FfiNative<Void Function(Pointer<Void>)>('Scene::dispose')
  external void dispose();
}

void Scene::dispose() {
  layer_tree_.reset();
  ClearDartWrapper();
}

calling a method on the receiver whether the receiver is nullptr or not

Easy fixes (that require fixes on every call site)

Make a top level C function that takes the "receiver" as first argument for nullptr and then calls the method if not nullptr. If the method is supposed to be idempotent, we're done.

Return a boolean, and check the boolean in Dart to throw if it was called a second time.

Check the native field in Dart for being a nullptr with _getNativeField.
Add a boolean to the Dart class that keeps track of being disposed.

If we have to guard all the callsites in Dart code that seems a bit error prone

I'll take a look at the design of the NativeFieldWrapperClasses and automatic unwrapping of native fields to Pointer<Void> if we can make a general solution. From a quick glance this stems from the fact that Dart is object oriented, C++ classes have a receiver as well, but that this automatic unwrapping is based on the C FFI which does not have a concept of receiver and null-pointer-exception. Having both Dart and C++ as OO languages and having the @FfiNatives on NativeFieldWrapperClass1 be direct mappings between Dart methods and C++ methods gives the illusion this would cover object-oriented behavior, but instead we get simple C behavior: e.g. you pass a nullptr.
For reference, the pattern with C (not C++) code and disposing methods:

Dart class implements Finalizable, has a Pointer<...> _nativeResource and a boolean _isDisposed.
dispose() sets _isDisposed to true, and frees the resource
All dart methods manually check _isDisposed and throw a StateError before accessing the _nativeResource.

And this pattern can be extend with a NativeFinalizer, which is cancelled on dispose() and cleans up the _nativeResource if the users forget to call dispose.
This suffers from the same issue that all callsites need to implement this pattern. But the pattern is very explicit in Dart code, which it is not with NativeFieldWrapperClass and automatic receiver unwrapping.

It seems to me that the natural way of using @FfiNative instance methods is with a C++ peer pointer that is the receiver for the C++ method invocation. As such, it would make most sense that the desugaring of @Ffinative not only check that the native field (aka peer) was initialized but also check whether it has been cleared again, see kernel_to_il.cc:kGetNativeField which isn't checking that the loaded integer is non-0.
For parameters we may not necessarily do that, since the peer (even if 0) will be passed to C++ which will then use it (or not) and the error should happen when "dereferencing" it.

I like @mkustermann's idea - I think if the VM threw a Dart exception of the native field is zero that would be fine.

@dnfield I landed a fix for https://github.com/dart-lang/sdk/issues/49620 last week. Could you double check this is the behavior you'd like?

@dcharkes this is definitely an improvement - we now get output like this instead of a segfault:
00:02 +0 -1: loading /Users/dnfield/tmp/t/test/widget_test.dart [E]
  Failed to load "/Users/dnfield/tmp/t/test/widget_test.dart": Bad state: Native field is nullptr.
  dart:ui                      Canvas.restore
  test/widget_test.dart 14:10  main

To run this test again: /Users/dnfield/src/flutter/flutter/bin/cache/dart-sdk/bin/dart test /Users/dnfield/tmp/t/test/widget_test.dart -p vm --plain-name 'loading /Users/dnfield/tmp/t/test/widget_test.dart'
00:02 +0 -1: Some tests failed.

That said, I think this may still be confusing for users. Is there some way that dart:ui could override this message, or alternatively a longer more actionable message could be presented?
For example, I think something like
Bad state: A Dart object attempted to access a native peer, but the native peer has been collected.

This is usually the result of calling methods on a native-backed object when it is in a disposed state.

@dcharkes Could we update the error message to something like @dnfield suggested?

Pre-emptively closing this as fixed by https://dart-review.googlesource.com/c/sdk/+/255680


GH-285 Add EditorDebugger Integration

Fixes #285

[x] Roll godot-cpp forward to Godot 4.3
[x] Depends on https://github.com/godotengine/godot/pull/86721

Applied to main (=2.1) for now.

Applied to branch 2.0.


Merge pull request #2564 from ROCm/bump_tf_rocm612

bump TF to rocm6.1.2

retest cpu-non-pip please

retest gpu-pycpp please


Add Harmonized Landsat Sentinel collection

Codecov Report
Base: 89.82% // Head: 89.83% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (8041eee) compared to base (89160e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 8041eee differs from pull request most recent head eece555. Consider uploading reports for the commit eece555 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #343   +/-   ##
========================================
  Coverage    89.82%   89.83%
========================================
  Files           46       46
  Lines         4385     4389    +4
========================================
+ Hits          3939     3943    +4
  Misses         446      446

Impacted Files
Coverage Δ

sentinelhub/data_collections.py
96.41% <100.00%> (+0.03%)
:arrow_up:

sentinelhub/data_collections_bands.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Data/engineering preparation including github repository

[x] Setting Github repo
[x] Data preparation in the local PC or AWS (S3 bucket)
[x] Setup feather instead of CSV
[x] Make test-set for gene expression data with random samples
[x] Establishing engineering strategy (IDE, Jupyter notebook)

Please ask IAM for bucket access for raw data

Added reviewNB for pull request of jupyter notebook

IDE: VS code
Main analysis: Jupyter Notebook, R studio(?)


Fix Linux binary to work with various Linux distros

When releasing Linux binary, use switch --target=x86_64-unknown-linux-musl in order to get the binary working with various Linux distros (including alpine and older debian distros). So not require strict glibc dependency. It was failing in the service pipelines using debian images with the older glibc.

I am not really qualified to review this, have you done any testing that suggests this will work ?

@saraiva132 yeah I built the image on the debian image and tried that it's working also on alpine and older debian images too. All this just locally.

Specifically on boster and stretch debian distros


Implement VariableSet.subtract

Also remove some unnecessary whitespaces in VariableSet.swift

Nice one! this looks good to me.

Thanks for taking a look!


ImageView: background & highlightOnTouch Conflict

The properties 'background' and 'highlightOnTouch' conflict with each other and the resulting object displays differently depending on the order in which the properties are defined.
new tabris.ImageView({
    width: 128,
    height: 128,
    centerX: 0,
    centerY: 0,
    cornerRadius: 65,
    elevation: 8,
    image: "src/images/icon.png",
    // -- background first, then highlightOnTouch second
    background: 'red',
    highlightOnTouch: true
    // --
}).appendTo(ui.contentView);

yields the image as shown in the screenshot below.

When the order is switched, as seen in the following code snippet...
new tabris.ImageView({
    width: 128,
    height: 128,
    centerX: 0,
    centerY: 0,
    cornerRadius: 65,
    elevation: 8,
    image: "src/images/icon.png",
    // -- highlightOnTouch FIRST, then background SECOND
    highlightOnTouch: true,
    background: 'red'
    // --
}).appendTo(ui.contentView);

The result looks like this:

I just migrated over to 3.0.0-beta1; this wasn't an issue in 2.x.x as far as I was aware.

Thanks for the info. This is of course not expected. What platform are you seeing this behavior on?

Platform is iOS 11.1.1

Thanks, we will check it soon.


More efficient resize implementation

Resizing on scrollback branch has some O(n) (with length of buffer) operations.

Removing this from scrollback project. The updated task is to remove extra allocations in certain storage resize scenarios.


Feature specs: Applications.Core/secretStores extended use cases

Here are the feature specs for extending the use cases of Applications.Core/secretStores

@willtsai looks like this got auto closed. Are there any pending updates or is this PR mainly pending approval at this point?


DRILL-6295: PartitionerDecorator may close partitioners while CustomRunnable are active during query cancellation

@ilooner Please review

+1 LGTM I do not see anymore race conditions

@parthchandra Please review

+1


Convert nodebacks to Task

Folktale should support converting Node-back style functions to Tasks.
A Nodeback function is a function that accepts a callback in Node-style, for example:
fs.readFile :: (pathname: String, callback: (Error or null, data: Buffer or String or null) => Void) => Void

A conversion function would take that readFile function and generate a new function that instead of taking a callback returns a Task object:
nodebackToTask(fs.readFile) :: (pathname: String) => Task Error (Buffer or String)

Where this goes?
In  the data/conversions module, as nodebackToTask.
In the data/task module, as fromNodeback.
Refer to existing data/conversions modules, and the from* functions in data/maybe and data/either to see more or less how this is done.

@robotlolita I've just stumbled across this, but is this the sort of thing you're looking for? I wrote a little lib the other day for converting functions with callbacks to Tasks to solve a simple problem and was considering expanding upon it. It's also short enough to include here:
'use strict'

const Task = require('data.task')

function taskFromFn(fn, ctx) {
  return function() {
    var args = [].slice.call(arguments)

    return new Task(function(reject, resolve) {
      fn.apply(ctx,
        args.concat(function(err, data) {
          err ? reject(err) : resolve(data)
        })
      )
    })
  }
}

module.exports = taskFromFn

If so, I'd consider learning more about this library and taking a crack at a pull request!

@rpearce pretty much, yep :)

Cool I'll take a stab next week at this!

On Apr 22, 2017, at 12:09, Quil<EMAIL_ADDRESS>wrote:
@rpearce pretty much, yep :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Plugin incompatible in Android: https://github.com/Wizcorp/phonegap-facebook-plugin.git

When the two plugins are added to the project in Android this error is shown (in iOS works perfectly):
exec] UNEXPECTED TOP-LEVEL EXCEPTION:
[exec] com.android.dex.DexException: Multiple dex files define Landroid/support/v4/accessibilityservice/AccessibilityServiceInfoCompat$AccessibilityServiceInfoVersionImpl;
[exec] at com.android.dx.merge.DexMerger.readSortableTypes(DexMerger.java:596)
[exec] at com.android.dx.merge.DexMerger.getSortedTypes(DexMerger.java:554)
[exec] at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerger.java:535)
[exec] at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.java:171)
[exec] at com.android.dx.merge.DexMerger.merge(DexMerger.java:189)
[exec] at com.android.dx.command.dexer.Main.mergeLibraryDexBuffers(Main.java:454)
[exec] at com.android.dx.command.dexer.Main.runMonoDex(Main.java:303)
[exec] at com.android.dx.command.dexer.Main.run(Main.java:246)
[exec] at com.android.dx.command.dexer.Main.main(Main.java:215)
[exec] at com.android.dx.command.Main.main(Main.java:106)
[exec]
[exec] :dexRelease FAILED
[exec]
[exec] BUILD FAILED
[exec]
[exec] Total time: 30.975 secs
[exec]
[exec] FAILURE: Build failed with an exception.
[exec]
[exec] * What went wrong:
[exec] Execution failed for task ':dexRelease'.
[exec] > com.android.ide.common.internal.LoggedErrorException: Failed to run command:
[exec] /Users/danicastanos/Library/Android/sdk/build-tools/22.0.1/dx --dex --output /Users/danicastanos/Documents/koala/app/platforms/android/build/intermediates/dex/release --input-list=/Users/danicastanos/Documents/koala/app/platforms/android/build/intermediates/tmp/dex/release/inputList.txt
[exec] Error Code:
[exec] 2
[exec] Output:
[exec]
[exec] UNEXPECTED TOP-LEVEL EXCEPTION:
[exec] com.android.dex.DexException: Multiple dex files define Landroid/support/v4/accessibilityservice/AccessibilityServiceInfoCompat$AccessibilityServiceInfoVersionImpl;
[exec] at com.android.dx.merge.DexMerger.readSortableTypes(DexMerger.java:596)
[exec] at com.android.dx.merge.DexMerger.getSortedTypes(DexMerger.java:554)
[exec] at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerger.java:535)
[exec] at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.java:171)
[exec] at com.android.dx.merge.DexMerger.merge(DexMerger.java:189)
[exec] at com.android.dx.command.dexer.Main.mergeLibraryDexBuffers(Main.java:454)
[exec] at com.android.dx.command.dexer.Main.runMonoDex(Main.java:303)
[exec] at com.android.dx.command.dexer.Main.run(Main.java:246)
[exec] at com.android.dx.command.dexer.Main.main(Main.java:215)
[exec] at com.android.dx.command.Main.main(Main.java:106)
[exec]
[exec]
[exec]
[exec] * Try:
[exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
[exec] ERROR building one of the platforms: Error: /Users/danicastanos/Documents/koala/app/platforms/android/cordova/build: Command failed with exit code 8
[exec] You may not have the required environment or OS to build this project
[exec]
[exec] /Users/danicastanos/Documents/koala/app/platforms/android/cordova/node_modules/q/q.js:126
[exec] throw e;
[exec] ^
[exec] Error code 1 for command: /Users/danicastanos/Documents/koala/app/platforms/android/gradlew with args: cdvBuildRelease,-b,/Users/danicastanos/Documents/koala/app/platforms/android/build.gradle,-Dorg.gradle.daemon=true
[exec] Error: /Users/danicastanos/Documents/koala/app/platforms/android/cordova/build: Command failed with exit code 8
[exec] at ChildProcess.whenDone (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/cordova/superspawn.js:131:23)
[exec] at ChildProcess.emit (events.js:98:17)
[exec] at maybeClose (child_process.js:766:16)
[exec] at Process.ChildProcess._handle.onexit (child_process.js:833:5)

We found the fix in this thread:
https://github.com/Wizcorp/phonegap-facebook-plugin/pull/1032
The issue is that two versions of the android-support library are being included.


Fixed broken link to "How to customize compute instance"

Previous version led to a 404.

Looks good; thanks, @lvovanms!


feat: add email to users

Description
Prepare #49

Add email field for users in database
Update existing endpoints
Update tests

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

You can proceed to update the auth too if you feel motivated.


Update postcss-selector-parser

If / when https://github.com/postcss/postcss-selector-parser/pull/38 is merged, please consider updating if the change results in a major version bump.

Released as 2.0.5. 😄

very nice! thank you!


Home task 06 completed

Home task 06 completed,
Project created with "create-react-app"
Backend Integration using Redux, React-Redux & Redux Thunk

Also i guess that filtering and sorting logic should be implemented with Redux, according to the task:
4 - Sorting by release date and rating is implemented as redux actions
5 - Filtering by genre is implemented as redux actions


Generated classes do not include some references

My project was targeting at the latest C# language level, after running the CLI tool within the project build, I noticed that some references were not included.
For example the System.InvalidOperationException were missing.

I had to explicitly declare the target C# level to 12.0 and added the following settings in my project file:
<ItemGroup>
	<Using Include="System" />
	<Using Include="[System.IO](http://system.io/)" />
	<Using Include="System.Collections.Generic" />
	<Using Include="System.Linq" />
</ItemGroup>

After that the missing references were included into the generated classes and build went ok.

@mwadams thanks for the support on this issue. 👍🏻

I have moved this to #337 to capture both documentation requirements at the same time as they are closely related.


Create npm-publish.yml

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

.github/workflows/npm-publish.yml

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:
The complete list of files we can't accept are:

.devcontainer/**
.github/**
data/reusables/rai/**
Dockerfile*
src/**
package*.json
content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:

[x]  I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x]  For content changes, I have completed the self-review checklist.

``


ChartData.add_series() displays number_format integer in PPT until data is accessed

Hey all,
First time posting so I apologize if I break any conventions. I am using Chart.replace_data to automatically update data on a chart shape in a powerpoint template and I think I may have found a bug. Below you will see my code.
slide=prs.slides[6].shapes
chart_data=ChartData()
chart_data.categories=["CAT1","CAT2","CAT3","CAT4"]
chart_data.add_series("Series Name",(val1,val2,val3,val4), 9)
chart=find_shape_by_name("Chart1").chart
chart.replace_data(chart_data)

For some reason once I save and open the powerpoint, the chart in question displays the number_format (in this case 9) for each category. But in powerpoint if you go to view the data in excel, it contains the correct numbers and will adjust the chart accordingly. I'd like to avoid this additional step as the rest of the powerpoint is being populated automatically.

Thanks for your help!

I'm not getting your question. Please describe step-by-step what you do, what you get at each step, and how that differs from what you're expecting.

I've observed the same bug with respect to Axis labels.
If I create a series by using the format string:
chart_data.add_series("Series Name",(val1,val2,val3,val4), '0%')
The axis labels appear like 10%, 20%, ... 90%, 100%
If instead I create the series by using the constant values defined in ExcelNumFormats enum (NB: this doesn't appear to be a part of pptx.enum.chart even though it's listed in the dox beneath that enum...), then the axis labels all appear like: 9, 9, ... 9, 9

As soon as I right-click the chart and "Edit Data" from PowerPoint, then the labels appear properly.

@DZemens That worked perfect. @scanny does @DZemens post help clear up what I was

Okay, looks like the documentation got ahead of the implementation. The numeric built-in number formats appear to not have gotten implemented and probably won't for a while.
I'll tag this ticket to update the documentation at least for the next release and to get those in there next time we're in the neighborhood.

Documentation was updated to remove indication of support for Excel built-in formats. All cell formats must be specified by string, e.g. "0.0%".


fix(dictionary): replaced owlbot with dictapi

fixes #143
Some important changes are:

changes to a few language keys for the command
"emoji" in the header is replaced with "example"
and the API that's used lol

Gonna push changes to this branch because in current state it's not quite right. Check back in later~


docker segfaults on fedora-35 and rockylinux-9

[x] Fix fedora-35
[x] Fix rockylinux-9

Unable to reproduce


Remove remaining BaseParameters references

Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@fa9r I just re-checked, and apart from examples and builtin bento, kserve, seldon and label_studio steps, these are all the occurences that we can easily remove for now. The rest needs to be kept for backwards compatibility.


Adding TraceLevelFilter operator

Supports users dynamically filtering streams by changing the trace
level.
Do we want a sample to go along with this? I can throw one together, it is just very simple so wasn't sure if it would be helpful. #39

Another thought since this is really a non-blocking switch, either you get all the stream or none of it, should it instead be in com.ibm.streamsx.plumbing.switches  and called TraceLevelSwitch?
http://ibmstreams.github.io/streamsx.plumbing/doc/spldoc/html/tk$com.ibm.streamsx.plumbing/ns$com.ibm.streamsx.plumbing.switches.html

I like the idea of just putting it in the switches directory. That makes sense. I will also try switching it to a Filter and adding the traceLevel option as a parameter.

I'll merge this in , but I want to see if there's a better name for the forceWrite parameter, since the operator does not actually perform any writing.


Add popper.js package to the white-listed dependencies

Popper.js is needed for the Bootstrap v4 type definition,
as Bootstrap now depends on Popper and jQuery.

@denisname Could you link to the PR that will use this?

Ok, I pushed my code: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24173. Tests obviously failed.
See: use of Popper.Offset, Popper.Boundary, Popper.Behavior.
For the documentation, see three last options in tooltip options table.


fixed error when json_parse fails

Fixes #17

Fixes #17

Hi bendavis78. Thanks for you PR, but i think not good idea hide error. I think have needed show more clearly error. In current time json_parse talked about not correct work polymer-service. I think you doesn't have node.js or node.js not registred.


MAPL_Profiler has has an initialize/finalize can cause name collisions if exposed

I tried to add the module "MAPL_Profiler" to MAPL.F90 so that the profiling library could be exposed via a simple "use MAPL" statement. However the MAPL_Profiler module itself defines a public initialize and finalize them so any other code that decides to use initialize or finalize locally as a procedure name will have a name collision. I found that a module used by ExtDataDriver.x defines a private initialize and finalize that adding the MAPL_profiler to MAPL.F90 results in a name collision.
This sounds so familiar. Should the initialize and finalize in MAPL_Profiler.F90 be renamed so something less generic to avoid name collosions?

The ideal solution to this is to use a Fortran generic interface around each specific procedure, ala:
interface initialize
   module procedure initialize_profiler
end interface

The problem is more perverse though, if they share interfaces.   E.g., if initialize() or finalize() do not take any arguments (or maybe just an optional return code), then this approach does not work.   In that case, one must either change the name in the code or use the Fortran rename mechanism ..., only:  a => b    And possibly break backward compatibility.
The problem is more general, as I would like an initialize procedure for most layers in MAPL to properly encapsulate the responsibilities invoked at the top level.   So an analysis of what arguments are needed (or could be artificially added to disambiguate) is the 1st step.

There is probably a good reason to have a true MAPL object that encapsulates at least the "generic" aspects of MAPL.   But that is not the way our interfaces currently look, and it is not friendly to ESMF componentization without making it global.  So some of the issue here is the Gordian knot of interfacing different frameworks.

@bena-nasa Any thought on which of these options is viable?  If we have to use the longer name, so be it.

@tclune, I just added this in MAPL.F90 for now
   use MAPL_Profiler, initialize_profiler =>initialize, finalize_profiler =>finalize

I want to say we fixed this at some point? @bena-nasa do you remember?


when body of email has a link then url_launcher removes second query parameter.

I am creating a mail using url_launcher. The body of the email has a link with multiple query parameters. The problem is that only first query param is there and all other query params are removed.

Example:-
mailto:?subject=wynk%20music&body=http://myLocalHost/posts/redirect/?post_id=id1&user_id=id2
But body which appear in mail body =http://myLocalHost/posts/redirect/?post_id=id1

You need to encode the entire body as a query parameter using the relevant Url API, so that special characters within it are escaped. As you have written the URL there, user_id is a query parameter of the mailto, fire to lack of competent encoding, which is presumably not what you want.

You need to encode the entire body as a query parameter using the relevant Url API, so that special characters within it are escaped. As you have written the URL there, user_id is a query parameter of the mailto, due to lack of competent encoding, which is presumably not what you want.

I did not get what you suggesting. Could you please give some example or something.

See https://github.com/flutter/flutter/issues/42279#issuecomment-544039320


Add JS - Identity - Tests to dashboard

Tracking issue to add missing recorded test pipeline for Identity JS - https://dev.azure.com/azure-sdk/internal/_dashboards/dashboard/d2224fd5-beee-47a0-90df-b24b73fdc8e7

I’m able to enable live tests for a specific subset of our possible live tests. There’s some tooling that we would need to align with .NET, but it gets weird to debug. Given that we’re time constrained this milestone, I’ve made a separate issue to track aligning the live tests with .NET: https://github.com/Azure/azure-sdk-for-js/issues/17782


Mobile safari blocks outbound links when using multiple absolute named views

While using mobile safari through the IOS simulator:
Links that redirect you outside the application will not work but only inside of a absolutely named view.
It appears that links attempt to connect but instantly, redirects to the base app url via otherwise('/') but thats kind of a guess.
.state('home', {
        url: '/',
        views: {
          '': {
            templateUrl: 'views/main.html',
            controller: 'MainCtrl'
          },
          'navigation@home': {
            templateUrl: 'views/partials/navigation.html',
            controller: 'NavigationCtrl'
          }
        }
      })

If I put an outbound link into main.html it works perfectly on IOS.
If I put an outbound link into navigation Ctrl it attempts to connect to outbound link then redirects to root.
go to here

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


Add column to office, tsp, and dps users so that they can be disabled

Description
This follows on to work done in https://github.com/transcom/mymove/pull/1806
This supports the removal of alumni members: https://github.com/transcom/mymove/pull/2260
When users are disabled they cannot get sessions and are instead given a hard 403 error instead of a 401.
Setup
make db_dev_run db_dev_migrate

Code Review Verification Steps

[x] Code follows the guidelines for Logging
[x] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[x] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #dp3-engineering

[x] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Request review from a member of a different team.

I'd like to deploy this to experimental but in the meantime I'd love a review.
Also, do we need a document on how to use these new tables?

@garrettqmartin8 was considering doing similar work, fwiw

I deployed this to experimental and it worked without incident.

Looks good to me.
In terms of if we should document this, it would be nice to add a "how to disable users" doc that describes that users need to be disabled in all tables. We can link to it from a template story in the bat team backlog.

@jim - would you like the doc in this PR or a separate PR?

@chrisgilmerproj No preference!

@chrisgilmerproj No preference!

I added a short doc to this PR.

Can we add the host, app, etc. to the log line:
Disabled user requesting authentication	{"git_branch": "cg_disable_office_tsp_dps", "git_commit": "8e77d7b9e9bc46d5e4253524b571bcb1da2a0b90", "email"<EMAIL_ADDRESS>


using another pre-trained BERT model

Hi
I would like to train a NER (EN) but with my own BERT model, where can I do this.
Thanks

and what about the data, can I use something like this
sulfate 100130 547 554 B-Chem S-Chem
Or the data must be exactly similar to conll?

If you want to use your own model, first you must make sure that the parameter format of the model is the same as that provided by BERT official, otherwise you will encounter some problems. In fact, I provided a url parameter in the LoadCheckpoint class to pass the model you have trained. This parameter needs to be a link, and the data is the same compression format as the official BERT file.
example: "https://storage.googleapis.com/bert_models/2018_11_03/chinese_L-12_H-768_A-12.zip"
or :"https://XXXXX/XXXXX/XXXXX.zip"
In order to facilitate the implementation of multiple tasks based on BERT under the framework, I have changed the input format to "sentence \t sequence_labels" format, which does not support the format you provide.
But if you want to use a custom format, you can customize the data load method without changing the model architecture.

@GhadaAlfattni
If you want to use your own model, first you must make sure that the parameter format of the model is the same as that provided by BERT official, otherwise you will encounter some problems. In fact, I provided a url parameter in the LoadCheckpoint class to pass the model you have trained. This parameter needs to be a link, and the data is the same compression format as the official BERT file.
example: "https://storage.googleapis.com/bert_models/2018_11_03/chinese_L-12_H-768_A-12.zip"
or :"https://XXXXX/XXXXX/XXXXX.zip"
In order to facilitate the implementation of multiple tasks based on BERT under the framework, I have changed the input format to "sentence \t sequence_labels" format, which does not support the format you provide.
But if you want to use a custom format, you can customize the data load method without changing the model architecture.

I'll check then
Thanks @kyzhouhzau


Auth: x509 on TLS 1.2 and TLS 1.3 is not supported by all browsers

Description
TLS 1.3 introduces post-handshake auth workflow. Currently, Chrome does not support post-handshake auth and switching the Apache of Rucio Auth Server and Rucio WebUI to TLSv1.2 makes the x509 auth workflow function as expected on Chrome.
However, if we use TLSv1.2 servers with Firefox, the browser blocks the requests in light of weaker security.
We need to detect the HTTP-Agent on the WebUI and make requests to different x509 endpoints on the rucio server, one which supports TLSv1.2(chrome, safari) and other with support for TLSv1.3 (firefox)
Steps to reproduce
No response
Rucio WebUI Version
35.0.0
Additional Information
No response

@MytsV please add the relevant discussion around the issue and the research here.

@MytsV please add the relevant discussion around the issue and the research here.

Testing has shown that modifying the TLS settings doesn't ensure proper authentication in both Chrome and Firefox. Thus, I tried modifying the Apache config (addressed in https://github.com/rucio/containers/issues/352) of the Rucio server to exclude client certificate verification. This has changed the source of the error and made it less cryptic.
Further research has shown that, by default, Firefox doesn't include credentials in preflight CORS requests. This can be modified through network.cors_preflight.allow_client_cert setting, which is not a desired outcome.
Fetch API provides a way to override default behaviour of browsers regarding credentials in CORS requests. Setting a credentials: include has made the requests fail with a similar error across all browsers.
The last error to overcome was related to the preflight response headers. The Access-Control-Allow-Headers was set to *, which when credentials are set to include is treated as a literal character, not a wildcart (source). Hence https://github.com/rucio/rucio/issues/7148 addresses setting proper values to this header in the response.


Finalize default rancher-resource-set

[x] Resources for catalog.cattle.io (check if we need only clusterrepos.catalog.cattle.io)

[x] eks-operator

[x] rancher-operator

[x] fleet

[x] Exclude helm secrets

Based on offline discussion, rancher's default resource-set for 2.5 should only have:

[x] Resources for catalog.cattle.io (check if we need only clusterrepos.catalog.cattle.io)

[x] eks-operator

[x] Exclude helm secrets

Reopening the issue because of this issue https://github.com/rancher/backup-restore-operator/issues/44#issuecomment-701144908

https://github.com/rancher/backup-restore-operator/issues/44#issuecomment-701188611

On master-head - commit id: 2ae933e08

Used helm 3.2.4 version to install Rancher HA setup.
Take backup b1
Restore to a new Rancher setup where helm version is 3.2.4
Install worked using rancher install instead.
Able to restore successfully and install rancher.
Take another backup b2 in the new rancher setup. Cluster and users from previous rancher are available. User is able to access/edit the cluster that the user is owner of.
Fleet and rancher-operator are NOT available in the resourceset.


new block listen thread

As we know a block header is hashed repeatedly by miners by altering the nonce value, the blockheader contains the previous block hash, so i've add  poor new block listen thread that checks for new block in network, if a new block is detected, the miner stops to hash the current block header and starts working into a new block header, also i add a logging method that stores events into a file called miner.log instead of printing them in terminal.
The pull request is just for reference.

Thank you @papacrouz for this pull request. It has beautifully extended this toy :)
Before Merging the code, I think you need to also catch a SIGINT or CTRL-C, to exit the Thread in between, if user tries it.
Also There is another suggestion, (if you want to) Since we are connected to ckpool for the blockheader and payload submission, it is also possible to be in consistent communication about the Job Work change whenever it appears from the ckpool itself (Ckpool Stratum Protocol Then we will not need any Api request for deciding the block change.

Hello @iceland2k14 . Yes handler must be added, i will push fix it. Regrading the ckpool stratum i will take a look into it. Also i have this https://gist.github.com/papacrouz/104204500e73772ece5459dd8f885074 has an acquired ExitedThread and some more info regarding the block, do you think i have to add something from it to this pull request ? or have to keep the code simple ?

Thankx @papacrouz. I looked at the gist, which seems ok, although i would prefer to keep it simple at the moment. (Maybe in future if more things are done, like multi cpu, we could adapt to it).

The idea at present is, This simple miner should allow sufficient flexibility for quick experimentation. I would try to use extranonce2 and nonce both field with different ideas of randomization, it's all luck and chance. Blockheader could be just a function with varying nonce and extranonce2.
The idea about fetching the updated jobs from ckpool was to avoid working on Stale Jobs, as we are moving from 10M check to continuous check now.
If you are ready to work on few things, i might assign you the collaborator access.
I think i have a bug, blockheader = version + prevhash + merkle_root + ntime  + nbits + nonce  this should be correct.
Think about it and let me know.

Hi @iceland2k14 . I'm looking into stratum proptocol. I'm a bit busy but i will try to find time to work on this.

Thank you. I sent you collaborator request. You may merge the commit as you progress.

Take a look at this patch, https://github.com/papacrouz/solominer/tree/patch-1 i use ckpool to catch new Job Work as you sugggested, also i will commit soon the multi cpu support and some other basic info

I agree. Nice.

@hadi19851364  When you are fetching the Mining Jobs from a pool, you don't need to worry about the individual transactions inside the job. It is the work of the pool to make it and provide the relevant info to the miner so that calculation can begin. If you are working on your own pool then you might have to do it all by hand. Here it's not the case.
At this moment yes the nonce number changes randomly instead of sequentially. In initial versions before the edits from @papacrouz it was only checking 1 time for 10 million hash. Now it makes more sense to modify and include some more creative way of handling it. (Maybe in future)
You can use / change whichever api or code you want. Have fun. :)


Add pure constraints

[ ] add pure state constraints (vs. mixed ones)

$$ c_l \leq c(t, x(t)) \leq c_u $$

[ ] update Goddard case accordingly

See also this issue

@jbcaillau
This is actually useful for the direct method too: if we want to enforce the state constraints c(x_f) while we don't necessarily have a corresponding control u_f, for instance if discretizing with an explicit Euler formula. Use case: goddard example with final mass constraint.

@ocots @PierreMartinon @joseph-gergaud closing this issue that is subsumed by sss #115


Automate fastlane version bumps

Show changelog
Ask for type of version bump
Increment the version number
Commit the changes
Push to GitHub
Submit PR
Add git label
Post a message to slack

Sample PR: https://github.com/fastlane/fastlane/pull/7288

This is sweet! 🍬
I like seeing the "Changes since release x.x.x" above the list of commits. Can we work that into the comment? 😄 🙏

Addressed feedback 👍


CDN link is still using version 0.6.4

could you update the version on: https://ssense.github.io/vue-carousel/js/vue-carousel.min.js
to 0.6.9

Hey, @kulaone! Will update when I roll to 0.7.0, should be in the next few days!


Fix/add loading spinner

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Currently we can show only the progress bar while loading the record.
What is the new behavior?
Now we can show the spinner instead of the progress bar if we set the spinnerIndicator to true while loading the record.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

instead of a hard-coded SVG, I think this should be an ng-content, similar to https://github.com/siemens/ngx-datatable/pull/7/files. This way it's completely customizable (and we can re-use our custom spinner)

@shahirabegam Yes, please follow the proposal from @dr-itz . On this level the table component is generic. We need to create the option to provide a spinner component on app level and if possible preconfigured on library level.

corrected in the recent commit.
can you check this @timowolf @dr-itz

https://github.com/siemens/ngx-datatable/pull/7/files is doing something similar.

Changed as per the suggestion.

Now I can set true or false to loadingIndicator as it was before.
In addition to that, I can set customLoadingIndicator to true if I don't want the default loader. By default customLoadingIndicator value is false, so this flag is an a optional one.

Updated as per the comments.
once this change get approved, I will add the sample in the further MR

Many thanks already. Looks good to me. I will align also with @fh1ch to have a common view here.

I have done the squashing of the commits and resolved the comments.
Thanks a lot for the review🙇♀ @timowolf @dr-itz @fh1ch

@shahirabegam maybe scope datatable from the commit message, as all is related to datatable.
Sorry, one last comment.

changed the commit message @timowolf


Install ext-swoole failed on PHP 8.3.0-dev

Describe the bug

Version

[ ] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems

github actions > Ubuntu 22.0
PHP versions

PHP 8.3.0-dev (1e66e6ae73c6d05db21cf0e11e926a8ecd789a39)
To Reproduce

name: tests

on:
  push:
  pull_request:

jobs:
  tests:
    name: Test on PHP ${{ matrix.php }} with Swoole ${{ matrix.swoole }}
    runs-on: "${{ matrix.os }}"
    strategy:
      matrix:
        os: [ubuntu-22.04]
        # php: ['8.0', '8.1', '8.2', '8.3']
        php: ['8.3']
        # swoole: ['4.8.13', '5.0.3', '5.1.0']
        swoole: ['5.1.0']
        exclude:
          - php: '8.2'
            swoole: '4.8.13'
          - php: '8.3'
            swoole: '4.8.13'
          - php: '8.3'
            swoole: '5.0.3'
      max-parallel: 20
      fail-fast: false
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Setup PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: ${{ matrix.php }}
          extensions: redis, pdo, pdo_mysql, bcmath, swoole-${{ matrix.swoole }}
          tools: phpize
          coverage: none
      - name: Show Imformations
        run: |
          php -v
          php --ini |grep ini
          php --ri swoole

Expected behavior

Screenshots/Logs

action link
/home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/../scripts/extensions/add_extensions.sh: line 9: 10453 Segmentation fault      (core dumped) php -m > "$extension_list"
/home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/../scripts/extensions/add_extensions.sh: line 79: 10460 Segmentation fault      (core dumped) php -d'error_reporting=0' "${src:?}"/scripts/extensions/extension_map.php /tmp/map"$version".orig > /dev/null 2>&1
PHP Warning:  Module "swoole" is already loaded in Unknown on line 0
PHP Warning:  Module "swoole" is already loaded in Unknown on line 0
✗ swoole Could not install swoole on PHP 8.3.0-dev

Additional context

Are you willing to submit a PR?

No

I have the same problem with ext-rdkafka on PHP 8.3.0

Swoole has officially fixed the problem.


Fedora 28: Unable to attach to CoreCLR

Environment data
dotnet --info output:
$ dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   2.1.403
 Commit:    04e15494b6

Runtime Environment:
 OS Name:     fedora
 OS Version:  28
 OS Platform: Linux
 RID:         fedora.28-x64
 Base Path:   /usr/share/dotnet/sdk/2.1.403/

Host (useful for support):
  Version: 2.1.5
  Commit:  290303f510

.NET Core SDKs installed:
  2.1.403 [/usr/share/dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.1.5 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

VS Code version:
Version: 1.25.1
Commit: 1dfc5e557209371715f655691b1235b6b26a06be
Date: 2018-07-11T15:40:20.190Z
Electron: 1.7.12
Chrome: 58.0.3029.110
Node.js: 7.9.0
V8: 5.8.283.38
Architecture: x64

C# Extension version:
1.15.2

Steps to reproduce
I follow this document to build a sample dotnet project: https://www.microsoft.com/net/learn/dotnet/hello-world-tutorial. Then I set a break point at Console.WriteLine("Hello World!");.
Expected  behavior
Debugging :)
Actual behavior
Error message:
-------------------------------------------------------------------
You may only use the Microsoft .NET Core Debugger (vsdbg) with
Visual Studio Code, Visual Studio or Visual Studio for Mac software
to help you develop and test your applications.
-------------------------------------------------------------------
Unable to attach to CoreCLR.

Help is appreciated.
Thank you.
/Henrik

@HenrikBach1 Try disabling razor! Take a look at this
Go to FIle/Preferences/Settings, search for razor and set Razor:Disabled.
Restart.
Voila!
Debugging :-)
ymmv but it works for me.

Hi,
Thank you for your suggestions. I'll look into them in a moment...
/Henrik

Hi,
Neither in user space settings, nor workspace settings is this "razor.disabled" property recognized.
And, Neither is it when searching for razor in: Try a preview of our >new settings editor<.
/Henrik

Debugging works for me with Razor 1.17.1 installed and without it being disabled.
But @HenrikBach1 In VSCode File/Preferences/Settings gets me here:

@HenrikBach1 Sorry, I don't know what else to say. On the menubar I click File, then Preferences, then settings (or just press Ctrl comma) and I get the panel shown in my screenshot above.
I only installed VSCode to be able to (try to) debug NBitcoin. I've never used DotNet or C# before, probably never will again once I've done the NBitcoin stuff I want to do.
I doubt it's relevant but I installed the following extensions:

@HenrikBach1 Razor was added in 1.17, therefore, you have no Razor in your installation (1.15.2)

@NTaylorMullen,
That explains a lot.
I'll try to bump up to version 1.17, then.
Thank you.
/Henrik


Integrating alp with iree-llvm-sandbox

This is the first integration for our project in alp/experimental. I tried to make the minimal number of changes outside of this folder, but:

I still wanted to integrate with mlir-proto-opt
I still want to be able to switch the  experimental/alp folder from the root CMakeLists.txt (although everything is disabled by default)
All of this is super-early stage and it is very buggy and not tested. However, I wanted to show earlier than later how we would like to integrate with this, and what were the main ideas. In particular:
I integrate at the c++ level (so mostly reusing mlir-proto-opt, but not reusing the Pyhton harness you have)
The major components are there (minimal python harness+autotuner+few simple passes). Once I have it cleaned up, I can add a README.md to explain how to use it.
If you have any early comment on anything, please feel free to add them or to open an issue

Thank you so much,
Giuseppe

I still wanted to integrate with mlir-proto-opt
I still want to be able to switch the experimental/alp folder from the root CMakeLists.txt (although everything is disabled by default)

SGTM, since everything is optional I don't see an issue.
We may want to restructure the CMake a bit so that the number of places touched by a future such addition is minimized
but this is fine for now and you don't need to shoulder this burden (I expect the next project will have some refactoring requests).
All of this is super-early stage and it is very buggy and not tested. However, I wanted to show earlier than later how we would like to integrate with this, and what were the main ideas. In particular:
I integrate at the c++ level (so mostly reusing mlir-proto-opt, but not reusing the Pyhton harness you have)

Sounds good for a first commit and to get started. I still think in the future the proper efforts should be made to either integrate with the harness or to come up with something better we can all reuse; I added comments where appropriate.
Note in particular the point about just reusing ScikitLearn/pandas/pytorch rather than having to reimplement a lot of functionality in C++ to just be able to do anything: composition is our friend, both in IR and with libraries.
The major components are there (minimal python harness+autotuner+few simple passes). Once I have it cleaned up, I can add a README.md to explain how to use it.
If you have any early comment on anything, please feel free to add them or to open an issue

I gave you review comments, no need to address everything now but please open the proper issues (prefixed with [ALP]) for the stuff you punt on.

Note I create and landed the alp subdir in an effort to try and give you rights on it specifically.
However it is not a default github mode and I have to parse through this:
https://stackoverflow.com/questions/40567468/give-permissions-on-project-folder-in-github?noredirect=1&lq=1
It will take me a little time as I have a bunch of stuff in my stack.

Thanks Nicolas for this first round of comments. I started to reply to some. Few overall replies:

Our main focus for now is performance. We need to show that, by using this framework we can compete with handwritten routines.  We have  proof of this for a very specific case, but now we are trying to get more general results.
Once we are happy with performance we will refactor everything to generalize to other operations. There are some features in the harness that I feel are missing, but we can try to add them

One question I didn't ask yet. Do you have any performance result for x86? Do they look promising?

Re. Our main focus for now is performance.
Re. Once we are happy with performance we will refactor everything
Yes understood, the objective here is to give you some broad feedback so you have a few directions for the future.
You should absolutely optimize for your velocity at this point.
Still, it looks like you have a string-stichy and inflexible bandaid that limits you in ways you may not realize (what you have is very close to what the sandbox started with, we invested into making the QoL better for these reasons). You have to decide
what is best for your current sprint, I can only share my experience 😄
Re x86, the various benchmarks run at a high fraction of peak on my AVX512 machine. I have previously dumped some perf results here:

matmul: https://gist.github.com/nicolasvasilache/9a526e6af1aae841a4f97d49f9b37db1
1-d conv: https://gist.github.com/nicolasvasilache/356c1be72370f8d82b0fa6cadd7676b2
1-d depthwise conv: https://gist.github.com/nicolasvasilache/570868fddf59c141a8647ec28de99aee

The matmul cases has mixes of divisible and non-divisble sizes; I get similar perf with ? everywhere.
The conv / depthwise conv cases are all divisible, the first objective was to ensure we can get the main kernel to high-perf.
I have not yet tried to plug padding for non-divisible cases with those.
I also plugged and ran the 2-d cases for conv and depthwise conv to similar high perf (note that depthwise 1-D is much less arithmetic intensive and it is prob limited by instruction issue / number of instructions).
Lastly, I did some moderate amount of manual searching to get to these perf points, scaling up search (esp. for the kernel) and rooting out the type of issue you mention re outlining will be important for us too.
Hope this helps!

could you please rebase/fix CI/land?

I tried to rebase and fix few things. Let's see if CI is happy.

Alright, CI is happy, but I am not authorized to merge


Is newInstance method deprecated ?

I have recently added this to my project using compile 'com.wdullaer:materialdatetimepicker:2.3.0'
} to my gradle file. On click Listener method where I want to open Calendar the DatePickerDialog.newInstance method is missing. Is it deprecated ?

Oh my bad. I was using DatePickerDialog of another library.


Fix type convert error in format_number scalar input

Fix https://github.com/NVIDIA/spark-rapids/issues/10899
In doColumnar(numRows: Int, lhs: GpuScalar, rhs: GpuScalar) of GpuFormatNumber we mistakenly created a GpuColumnVector with type String, so this function does not work at all because of type conversion error.
This pr fixes it and includes related Spark UT.
override def doColumnar(numRows: Int, lhs: GpuScalar, rhs: GpuScalar): ColumnVector = {
-    withResource(GpuColumnVector.from(lhs, numRows, dataType)) { col => // dataType was always StringType
+    withResource(GpuColumnVector.from(lhs, numRows, lhs.dataType)) { col =>
      doColumnar(col, rhs)
    }
  }

build


Fix error list unification

This fixes error list unification https://github.com/Microsoft/visualfsharp/issues/3047.
See discussion on https://github.com/dotnet/roslyn/pull/19561.  This even appears to work for multi-line error messages (which I had expected to be problematic)
The technique is to hack the old FSharp.ProjectSystem.Base to use the Roslyn error-reporting mechanism rather than the hard-wired one there.  Quite a lot of old project system code can be deleted as a result (we should probably keep deleting unused features from that code to help with the migration to http://github.com/dotnet/project-system)
This requires that Roslyn fix, so we have to see when that makes it in - hopefully soon!  It is important to note that we will require the Roslyn fix to be in place, if not Visual Studio will crash when it hits the call to FailFast mentioned in that Roslyn thread.
Separately this makes the Symbol API's EnclosingEntity return an option, I may factor that out into a separate PR
To consider (I don't think these are blocking)

[ ] manual stress testing with many errors etc (though the fix would always be with Roslyn, and we can probably assume that this is working ok)
[ ] consider re-enabling the automated tests in vsintegration/tests/unittests/Tests.TaskReporter.fs, which were effectively disabled (they were testing unused functionality) and are new fully disabled (since part of that functionality has now been replaced in ProjectSystem.Base), though this would effectively be re-testing Roslyn's logic in a somewhat unconvincing way.

I wanted to add @saul and @srivatsn as reviewers here but for some reason they aren't selectable - @KevinRansom  do we have to add them as project collaborators?

OK, all reviewed.  Now this just sits around until the Roslyn fix is available :)

An odd error in CI, seems unrelated
1) Failed : Tests.ProjectSystem.Project.RenameFile.BuildActionIsResetBasedOnFilenameExtension
no exception expected, but got System.InvalidOperationException: The service 'Microsoft.Internal.VisualStudio.Shell.Interop.SVsUIThreadInvokerPrivate' must be installed for this feature to work.  Ensure that this service is available. HRESULT = 0x8000FFFF
   at Microsoft.VisualStudio.Shell.ThreadHelper.GetInvoker()
   at Microsoft.VisualStudio.Shell.ThreadHelper.InvokeOnUIThread(InvokableBase invokable)
   at Microsoft.VisualStudio.Shell.ThreadHelper.Invoke(Action action)
   at Microsoft.VisualStudio.FSharp.ProjectSystem.FileNode.PromptYesNoWithYesSelected(String message, String title, OLEMSGICON icon, IVsUIShell uiShell) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\src\FSharp.ProjectSystem.Base\Project\FileNode.cs:line 351
   at Microsoft.VisualStudio.FSharp.ProjectSystem.FileNode.SetEditLabel(String label) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\src\FSharp.ProjectSystem.Base\Project\FileNode.cs:line 342
   at <StartupCode$VisualFSharp-Unittests>.$Tests.ProjectSystem.Project.RenameFile-BuildActionIsResetBasedOnFilenameExtension@802.Invoke(UnitTestingFSharpProjectNode project) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.ProjectSystem.Project.fs:line 812
at <StartupCode$VisualFSharp-Unittests>.$Tests.ProjectSystem.Project.RenameFile-BuildActionIsResetBasedOnFilenameExtension@802.Invoke(UnitTestingFSharpProjectNode project) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.ProjectSystem.Project.fs:line 814
at <StartupCode$VisualFSharp-Unittests>.$TestLib.ProjectSystem.MakeProjectAndDoWithProjectFileAndConfigChangeNotifierDispose@311.Invoke(String file) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\TestLib.ProjectSystem.fs:line 323
at UnitTests.TestLib.Utils.FilesystemHelpers.DoWithTempFile[a](String filename, FSharpFunc`2 f) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\TestLib.Utils.fs:line 73
at UnitTests.TestLib.ProjectSystem.TheTests.MakeProjectAndDoWithProjectFileAndConfigChangeNotifierDispose[d](Boolean dispose, FSharpList`1 compileItems, FSharpList`1 references, String other, String targetFramework, FSharpFunc`2 f) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\TestLib.ProjectSystem.fs:line 311
at UnitTests.TestLib.ProjectSystem.TheTests.MakeProjectAndDoWithProjectFile(FSharpList`1 compileItems, FSharpList`1 references, String other, String targetFramework, FSharpFunc`2 f) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\TestLib.ProjectSystem.fs:line 340
at UnitTests.TestLib.ProjectSystem.TheTests.MakeProjectAndDo(FSharpList`1 compileItems, FSharpList`1 references, String other, String targetFramework, FSharpFunc`2 f) in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\TestLib.ProjectSystem.fs:line 351
at Tests.ProjectSystem.Project.RenameFile.BuildActionIsResetBasedOnFilenameExtension() in D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\Tests.ProjectSystem.Project.fs:line 802

@dsyme any update on this? This should be available in Roslyn binaries

@saul I will get back to it. I've been away at a conference this week and I'll get back into engineering mode over the next few working days
If you would like to finish it off please send an additional PR based on Pilchie's option #2 here: https://github.com/Microsoft/visualfsharp/issues/3047#issuecomment-304050899

@saul I will leave it up to @brettfo as to whether we integrate in 15.3 branch or not.  I'd like to but only very few fixes are being taken in that branch right now
If it doesn't go into that branch then as soon as 15.3 is out we will update master to use the right 15.3 Roslyn binaries.  Then we can go ahead and pull this.

@dotnet-bot test Windows_NT Release_ci_part2 Build please

@saul and @dsyme: Due to changing APIs, master has to target Roslyn 2.0 until 15.3 ships (as RTW, not a preview), but vs2017-rtm is currently targeting 15.3.  Once 15.3 ships then vs2017-rtm will be merged back into master, so this PR can either be retargeted to vs2017-rtm and merged today-ish or we can wait until 15.3 ships (and vs2017-rtm merges back into master).
We try to not get into tight spots like this, but due to VS 15.0, 15.1, and 15.2 all reporting assembly versions of 15.0 and 15.3 reporting 15.3, we're in this mess.

@brettfo It depends on you (and if that means you need to take it to VS ship room to get permission).
Ideally this fix would go into 15.3 but the problem is that I can't validate the fix as I don't have a 15.3 on any machine (and I'm not sure getting 15.3.preview2 would help - I really need 15.3 preview 3)

This is ready once we can assume 15.3

If we get this into 15.3, we'll have to roll it up with changes to the language service as a high-priority bug fix.  Otherwise, this would have to go out via nightlies and later, 15.4.  @Pilchie your thoughts?

@cartermp   the bar for 15.3 is "astronomical", which I take to mean as I can't even imagine what would qualify :-)
But @Pilchie tells me that we can get this into 15.4 without too much of a tussle.

Now that 15.3 is out and master is using the fixed Roslyn binaries I've removed the WIP tag and I believe this is ready for commit
However we should re-check that it fixes the error list problem and that no new problems have been introduced

@dsyme I get this assertion when opening VisualFSharp.sln with your PR after a build vs:

This is for FSharp.Compiler.Interactive.Settings, as that was the only project which failed to load after ignoring assertions

That will be related to #3393 . What happens if you ignore the assert?

I see.  It's fine and the PR will build without that project.  I cannot reproduce #3047 with this PR.  I'm psuedo-randomly screwing around with code in Paket to see how it reacts.  Nice and clean!

@cartermp Thank you so much for doing that validation.
@KevinRansom This is good to merge now

Since @cartermp has validated this, I'm going to pull it.


Change Feed Processor public API name changes

Change Feed Processor public API name changes
Description
Based on feedback, we are renaming the builder methods for Change Feed processor and estimator and replacing Func with explicit delegates to avoid parameter confusion:
public delegate Task ChangesHandler<T>(
    IReadOnlyCollection<T> changes,
    CancellationToken cancellationToken);

public delegate Task ChangesEstimationHandler(
    long estimatedPendingChanges,
    CancellationToken cancellationToken);

public abstract ChangeFeedProcessorBuilder DefineChangeFeedProcessor<T>(
    string processorName,
    ChangesHandler<T> onChangesHandler);

public abstract ChangeFeedProcessorBuilder DefineChangeFeedEstimator(
    string processorName,
    ChangesEstimationHandler estimationHandler,
    TimeSpan? estimationPeriod = null);

Type of change

[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Closing issues
Closes #432

Is this in addition to the existing APIs ? Is having estimatedPendingChanges as a single long not too distilled? Backlogs are nuanced - i.e. one might want to infer the min/max and/or how many ranges are behind?


make global resources less complex

Now if you want to include the global X in resources you need:
place the file in:
/src/gbl/X.XML
and add the resource:

Ideally to have the option to describe globals as XML too, like:

because it's not clear why the resource is GBL and the file is XML.
or support the GBL extension.

The intended workflow around this needs better documentation.

Added example in documentation here:
https://github.com/intersystems/ipm/wiki/03.-IPM-Manifest-(Module.xml)#globals-resource-example


Fix couchdb_os_daemons tests dependency.

couchdb_os_daemons_tests.erl was failing in
setup if run on its own:
... apps=couch tests=os_daemons_test_

with an exception:
**exit:{{{badmatch,undefined},
  [{couch_log,notice,2,[{file,"src/couch_log.erl"},{line,44}]},
   {config,handle_call,3,[{file,"src/config.erl"},{line,211}]},

because it depends on couch_log. So add couch_log as a dependency
in setup.
After fix it should run 5 tests:
[done in 5.626 s]
=======================================================
  Failed: 0.  Skipped: 0.  Passed: 5.

COUCHDB-2830

Thanks :)
Just fyi: just added a tiny change in order to have a clean test teardown.


retrieve / enumerate super properties?

Hi Mixpanel,
This might relate to #35, but seems slightly different. I'd like to retrieve all the super properties that we have set for a user. I can use mixpanel.get_property, but then I need to know the name of the super property. I couldn't find a public method exposing it.
I saw that I could access mixpanel.persistence.props - but feels like reaching too deep into the internals(??). Would appreciate some pointers for the recommended way of doing this.
Cheers
Yoav

Hi @gingerlime, mixpanel.persistence.properties() is a function we expose for this purpose: https://github.com/mixpanel/mixpanel-js/blob/cb67b52984cff949fb38e7eecffe0d3861215a4d/mixpanel.js#L4640
Generally anything within https://github.com/mixpanel/mixpanel-js/blob/cb67b52984cff949fb38e7eecffe0d3861215a4d/mixpanel.js#L4618-L4655 that's not underscore-prefixed is going to be available as long as we're on version 2.x of the lib (i.e. not breaking backwards compatibility).
Hope this helps!

Hey @tdumitrescu. Sorry for the late reply, but it helps a lot. I really appreciate it.


m13v manual silero vad implementation & fix: windows compilation with new vad library (#289 and #301)

Combines:

#289
#301

@joegoldin thx a lot! bounty should have been received, lmk if not!


json-schema objects 'required' properties

Hi @bhch, thank you for the awesome lib. One thing I noticed, which is a bit of a problem at the moment. The 'required' properties of the json-schema objects are not considered during validation. Just a custom 'required: true' flag at the property level.
https://json-schema.org/understanding-json-schema/reference/object.html#required-properties
Was this done on purpose? Without that validation, it's a bit hard to use externally defined JSON Schemas (such as schemas generated with Pydantic), though it might be possible to customise the schema generator.

Hi, I'll try to include this in the next release.
In the meantime, if you're using the django app, you can write your custom validation logic: https://django-jsonform.readthedocs.io/en/latest/guide/validation.html#custom-validation

@gersmann I've released required properties in Django in v2.16.0. Please update.
Thank you for reporting this issue.


neon: Add rev32 with vrev32* intrinsics

With SIMDE_SHUFFLE_VECTOR_  this time ;-)
I shall add it to rev64 later.

LGTM, thanks!


build: define WIN32_LEAN_AND_MEAN on mingw

This commit partially reverts 60db5b5a1bb446e4b8a6d15ce277d5f7987bf07a by defining WIN32_LEAN_AND_MEAN on mingw. Fixes #820.

I think I'd rather do a full revert then, since thanks to MSYS2 the autoconf build should just work.

Changed to a full revert.

LGTM. I just tested on a MSYS2 / MinGW-w64 installation and works fine. Sorry everyone, my fault.

LGTM

CI: https://ci.nodejs.org/job/libuv-test-commit/26/

Thanks for the reviews. Landed in be8e237a8e462f8517392eccf0f94a30d16d7ef3.


Add Kubemark Benchmark Design Doc

What this PR does / why we need it:
This PR illustrates the Design Doc for kubemark Benchmark in Kube-Batch
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
https://github.com/kubernetes-sigs/kube-batch/issues/427
Special notes for your reviewer:
https://github.com/Rajadeepan/kube-batch/blob/doc/doc/design/Benchmark/kubemark/kubemark-benchmarking.md

@k82cn updated the document as per your review comment. Does this benchmarking strategy looks fine? can i go ahead and get the benchmarking results using this strategy?

/lgtm

/approve


[Audit medium severity] Potential Attestation Loss

The Unirep protocol allows attesters to assert that changes should be made to the owners of particular epoch keys. Over the course of the epoch, these changes are recorded the attester’s epochTree which is a re-usable incremental merkle tree. When epochs expire, users are expected to apply the changes recorded in the epochTree by performing a state transition. To do so, however, the epoch tree root must be saved along with the state tree root in the history tree. In the Unirep contract, this is done when transitioning to a new epoch but only if an update has been made to the stateTree. Therefore, if no state tree update has been made the attestations are discarded.

Location where the epochTree is reset
    function updateEpochIfNeeded(
        uint160 attesterId
    ) public returns (uint48 epoch) {
        ...

        if (attester.stateTree.numberOfLeaves > 0) {
            uint256 historyTreeLeaf = PoseidonT3.hash(
                [attester.stateTree.root, attester.epochTree.root]
            );
            uint256 root = IncrementalBinaryTree.insert(
                attester.historyTree,
                historyTreeLeaf
            );
            attester.historyTreeRoots[root] = true;

            ReusableMerkleTree.reset(attester.stateTree);

            attester.epochTreeRoots[fromEpoch] = attester.epochTree.root;

            emit HistoryTreeLeaf(attesterId, historyTreeLeaf);
        }

        ReusableMerkleTree.reset(attester.epochTree);

        emit EpochEnded(epoch - 1, attesterId);

        attester.currentEpoch = epoch;
    }

Impact
As the state tree is only changed when a user is added by the attester or when a user transitions state, it is possible for attestations to be lost. In particular, assuming no users are updated it is possible for current users of the protocol to collude to discard undesirable updates to the state (particularly if there are a small number of users). Since this epoch is essentially discarded and ignored, this users may then transition from the previous epoch to the next epoch (i.e. users may skip e to transition from e-1 to e+1).
Developer Response
It is expected that the attester will validate an epoch key before performing an attestation. As long as this is done properly, then the epoch tree will be empty if the state tree is empty.

I think we can add revert in attest
if there is no leaves in the current state tree, the contract reverts the attestation.

Yes we could, it would add a cold SLOAD (a few thousand gas). I think a warning is sufficient for this, attesters should be aware of the epoch keys they're attesting to (e.g. validate that the epoch key exists in the state tree).


refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails

refactored pip and py commands to a function and fixed the use of -E in the pip install command which fails

This is all now handled down in poise-python.


Support default managed slm modification

I am creating elastic search cloud deployment in dev and I want to disable backup in development environment from cost perspective. I contacted elastic search support and they've told that we can only modify the default SLM policy without deleting it.
Therefore I was trying to support the modification via terraform but wasn't able to get any information about that managed slm policy from the deployment resource or from data resources. The alternative I have is only to use elastic search API or to modify it manually.
Overview
I would like to configure the SLM managed default policy in the deployment resource:
https://registry.terraform.io/providers/elastic/ec/latest/docs/resources/deployment
for example configure cron expression.
There is API for updating slm policy:
https://www.elastic.co/guide/en/elasticsearch/reference/current/slm-api-put-policy.html

IIUC this should be possible now through the Elasticstack provider

but  I don't want to create SLM policy, I want to modify the managed SLM policy created by default


Write user guide

Documentation on the SDK API is already generated us the command, npm run sdkdoc. However, documentation on the how to use the SDK in practice in the context of developing an app is needed.

已收到~

This should be added to the Dev Docs. Very simple tutorials for each feature should be used so it can be easy to update outdated tutorials (hopefully).


Added Link to the youtube tutorial and gh-pages

First of all thanks for the awesome tutorial!
As many of the people are still visiting your tutorial to learn sass, I wanted to make the link to your gh-pages that you've published in your repo and your youtube tutorial link easily accessible to other people.
Thank You!

Thanks!

Thanks For The Tutorial!!! CodeStackr

Liked It


Would like a guide for How-To deploy Amundsen in production

Please add points on what you expect from such a guide in a comment below. I will then try to consolidate input and draft up an outline in this comment.
The guide can end up as /docs/deployment.md is /docs/owners_manual.md better?
Initial outline:

[ ] Basic install of services (in different environments)

[x] Docker-compose “vanilla”, but with Gunicorn (WIP #109) data in volumes etc.
[ ] AWS ECS. original PR: https://github.com/lyft/amundsenfrontendlibrary/pull/216 (or EC2): https://github.com/lyft/amundsenfrontendlibrary/issues/186
[x] Kubernetes helm chart install (convert from Compose using https://kompose.io?) (upcoming PR see https://github.com/lyft/amundsen/issues/53#issuecomment-538575978 below)

[ ] Setting up ingest (with or without Airflow, see https://github.com/lyft/amundsen/issues/53#issuecomment-617370073)

Figure out which parts of this belongs with Architecture.md and which in Databuilder repo?

[ ] Compared to Quickstart ingest (https://github.com/lyft/amundsen/issues/75)
[ ] Then mention source by source; Extractor(s), Model, Metadata
- Table Metadata:
- Users
- Table Usage: (How it works and why in https://github.com/lyft/amundsen/issues/381#issuecomment-613387814)
- ...

[ ] Configuration - custom build of frontend (to not have to maintain a fork we need to get https://github.com/lyft/amundsen/issues/408 transmogrified into proper documentation/tooling)

[x] Small tweaks to turn on/off features, adding logo etc. (mostly Done) https://github.com/lyft/amundsenfrontendlibrary/commit/c256115f7d64da121de4ea36ea9c55592c11f9d5 in PR https://github.com/lyft/amundsenfrontendlibrary/pull/255
[x] Config of email notification/feedback Done in PR https://github.com/lyft/amundsenfrontendlibrary/pull/291
[x] Data preview (integration to SuperSet) - https://github.com/lyft/amundsen/issues/27#issuecomment-517477074 has some draft contextual lead in and reasoning and a link to example setup. But ultimately  what ticks off the box for this is Taos Guide in https://github.com/lyft/amundsen/blob/master/docs/tutorials/data-preview-with-superset.md (or on the https://lyft.github.io/amundsen/ site, search for SuperSet!)

[ ] Security

[ ] Auth - passwords etc.
[ ] secure communication
[ ] production grade docker as per Production-ready Docker images (via https://www.youtube.com/watch?v=cDzFm68aMao)

[x] Backup - initial WiP in https://github.com/lyft/amundsen/issues/53#issuecomment-516159598 below ... current result in https://github.com/lyft/amundsen/issues/381#issuecomment-614534794 - and restore (on K8s) implemented in https://github.com/lyft/amundsen/pull/394

[ ] Monitoring (statsd etc.?)

[ ] Handling upgrades

[ ] ....

@ttannis we lost access to the useful content of former FE  issue https://github.com/lyft/amundsenfrontendlibrary/issues/186 referenced in the snippet shown below.
Can that content be salvaged somehow? E.g. will transferring  https://github.com/lyft/amundsenfrontendlibrary/issues/186 in a closed state to here do it?
Basic install of services (in different environments)
Docker-compose “vanilla”, but with Gunicorn, data in volumes etc.
AWS (ECS PR): lyft/amundsenfrontendlibrary#216 (or EC2): lyft/amundsenfrontendlibrary#186
Kubernetes (convert from Compose using https://kompose.io?)

Transferred that closed issue over: https://github.com/lyft/amundsen/issues/77

Thanks for the quick turnaround on this @ttannis - seems to work nicely!
Also please extend my thanks to other Lyft team members on the recent even higher systematic  focus on grooming PRs etc.  I think going forward that will really encourage more to hopefully contribute even more!

@jornh I have amundsen on aws eks + k8s + helm now; I will put up a PR next week with docs; I'm not sure if it will fully fulfill this story, or, if I should put up another one. wdyt?

Great @javamonkey79! I think it should definitely tick the Kubernetes box above (I edited a bit above).
Just push what you think is suitable to cover Kubernetes on it's own and we'll figure the rest out later, when there's some good pieces of content it's easy to shuffle around afterwards if needed.
Right now I'm thinking the list above should end up as just a jump list or "annotated ToC" for what the sys-admin would like/need to know. Haven't really figured out how much or little prose will be needed to glue it together... Thoughts are welcome! 😜

Ok @jornh I've got the PR up here; I've opted to not include the aws setup at this point, as it is tied to our org a bit. I might add it later, if there is enough interest. cc @markgrover @feng-tao

Great suggestions here! I'd like to emphasize the need for a more explicit documentation on how to set up Airflow to handle ingestions of ES after Neo4J editions. From an outsider perspective, it remains quite a mystery , although Airflow (or something filling this function) is clearly a 4th microservice indispensable for the other 3 to work.

@fBedecarrats Airflow has its own documentation. So we’ll probably just reference that.
But the gist of it is:

Setup Airflow depending on how “serious business” this is for you it ranges from:

just pip install it on a box where it can run, probably in a Python virtual environment of its own for good measure.
install it in a container based setup - including a separate postgres/other database - a popular/easy Docker image til now has been “puckel” (just google “Airflow puckel” and you see it). but just recently the Apache Airflow project itself are starting to make their own official image. Not even sure if it’s still “beta”.

pip install amundsendatabuilder and other required dependencies (database drivers) on top of your Airflow
add your DAGs (the databuilder PyPi package doesn’t include the examples folder from the repo
When you upgrade make sure to keep databuilder and your Amundsen services in sync regarding compatible versions.

@jornh Thanks a ton for putting those instructions together - I'm currently investigating how to implement Amundsen and backup / restore was high on the list.
Is there a good way to have ElasticSearch re-index data that was restored into Neo4j?  I'm getting search errors after a Neo4j database restore even though I see the expected data post-restore in the Neo4j console.
I found that I can re-run the amundsendatabuilder job on the same data source and the my restored data appears on the FE again, but that seems like a hackjob.

It’s merely a wishlist 🙁 (with links to “state of the union” - but luckily bit by bit I can tick boxes) glad to hear the list is useful to someone. So, thanks for your comment.
To answer your question: Elasticsearch and Amundsensearch doesn’t have a will of their own on what data to serve. So what you call a hack with re-ingesting reindexing through Databuilder is actually the way to update ES data. I think for a, hopefully rare, restore scenario that’s okay. Hope that clarifies...
Do you have ideas for a different way?

@jornh I have amundsen on aws eks + k8s + helm now; I will put up a PR next week with docs; I'm not sure if it will fully fulfill this story, or, if I should put up another one. wdyt?

I'd be interested in the helm chart.

@stewartbryson see https://lyft.github.io/amundsen/k8s_install/ + the Amundsen Slack also has a #kube-helm channel for discussion

Hi, we have been trying to stand up Amundsen on Kubernetes but can't get the pod for Neo4j to deploy... Did anyone else have this problem?

I'm going to pick this up. I think this will be a nontrivial project, mostly in the form of soliciting feedback from the community. Part of the appeal of Amundsen is its flexibility: there's no one right way to install it. However, for a guide to be broadly useful, I believe it needs to have concrete steps. As a result, we'll need to make some opinionated decisions in order for the guide to be useful.
Here's how I'm planning on structuring this project:

Create a skeleton of docs following @jornh's already-excellent outline. I will fill some of the "easier" details, and will leave anything nontrivial with as specific TODO as I can. I will solicit community feedback on this doc in a PR. I'd like to land it into a feature branch.
Based on feedback in (1), I will modify structure if needed. Additionally, I will fill in nearly all of the TODOs, including ready-to-run commands. I will open another PR and invite another round of community feedback (now that there is more substance to disagree with 😄 )
Once I address the feedback from (2), I will ask for one final round of feedback. In particular, I'd like to get at least one community member to run through all of the instructions command-by-command to ensure that it actually does what it says on the tin. At this point, I would like to merge it to mainline and promote the guide on the main readme. It will not replace installation.md (that guide is appropriate for someone who is just trying to get the thing working without source control or customizations), but instead will supplant it

If anyone has thoughts about this process, happy to hear.
There's some question as to which docs should be in the top repo vs service repos. My only strong feeling is that there be a single top-level doc that one can follow and find everything they need. Procedurally, it's much easier to make changes to the docs if they're all in one repo, rather than scattered between them. And given that the individual components aren't super useful when used independently, I default to just putting it into the larger repo. Open to feedback.

@dorianj that sounds like an awesome plan! I'll refrain from giving more feedback until you have passed step 1. 😉

hey -- we've packaged some of the learnings from this thread and other places into a recommended pathway  https://medium.com/stemma/amundsen-deployment-best-practices-740a1800518e -- would love anyone who's worked through this stuff to try it out and give feedback, we'd like to eventually get this upstreamed into main repo once it's better battle tested

Hi, we finally decided to start working with Apache Atlas. I guess we'll consider later adopting Amundsen as an alternative front-end.

Does anyone use Ansible roles for deploying and managing Amundsen ? I could share mine if that is of any interest (on-premise compose installation).

@dorianj , could you Guide me on the installation of Amundsen without Docker ? docker being paid for the commercial use or  require enterprise license would take the benefits of open source usage for the enterprises.
Any suggestions. Appreciate support here.

A year passed. Still even is not clear how to  make auth.


import-spacing: Convert to AbstractWalker

PR checklist

[ ] Addresses an existing issue: #0000
[ ] New feature, bugfix, or enhancement

[ ] Includes tests

[ ] Documentation update

Overview of change:
Just a refactor.

merge conflicts


update dependencies

Codecov Report

Merging #734 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   51.21%   51.21%
=======================================
  Files         196      196
  Lines       11765    11765
  Branches     1621     1615    -6
=======================================
  Hits         6026     6026
  Misses       5739     5739

Impacted Files
Coverage Δ

core/src/main/scala/spire/math/Algebraic.scala
66.05% <0%> (-0.82%)
:arrow_down:

extras/src/main/scala/spire/math/FixedPoint.scala
34.42% <0%> (-0.55%)
:arrow_down:

core/src/main/scala/spire/math/Rational.scala
95.52% <0%> (+0.23%)
:arrow_up:

core/src/main/scala/spire/math/Interval.scala
69.92% <0%> (+0.25%)
:arrow_up:

core/src/main/scala/spire/math/Natural.scala
65.15% <0%> (+0.6%)
:arrow_up:

...ore/src/main/scala/spire/math/interval/Bound.scala
47.24% <0%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee38b7...a96db19. Read the comment docs.