Should width, height be reversed?

I see here, that the pixel values that are forwarded through the Transformer encoder are assumed to be of shape (batch_size, num_channels, width, height). However, is it possible that height and width should be reversed (as, according to torchvision's documentation, a batch of PyTorch tensors is assumed to be of shape (B, C, H, W)?
Of course, if training on square images, height and width are equal, hence there's no impact.

Hello @NielsRogge
Sorry for the confusion, it is just that as a non-native english speaker I am consistently confused with height and width... And as you say it works regardless because we deal with square images.


Add dns-timeout support

I am trying to use DNS challenge with Route53 from cli run command.
But a great chance to failed with following error:
2016/05/25 02:32:58 [www.example.com] Could not obtain certificates
	Error presenting token: Failed to determine Route 53 hosted zone ID: read udp <IP_ADDRESS>:44956-><IP_ADDRESS>:53: i/o timeout
2016/05/25 02:32:58 [example.com] Could not obtain certificates
	Error presenting token: Failed to determine Route 53 hosted zone ID: read udp <IP_ADDRESS>:36664-><IP_ADDRESS>:53: i/o timeout

Because of network latency and the GFW reason, dns request is very slow and unstable.
So we need apply dns timeout support for dns-challenges.

Thank you for bringing this up and fixing it right away! I hope this improves things for other people as well.
Closed via #215


Keyshortcuts and Keymapping not working in Ubuntu 19.04 (Latest Snap Store version)

VSCode Version: 1.36-insiders
OS Version: Ubuntu 19.04

Steps to Reproduce:

Open code-insiders
Try to use arrow and delete keys

Both Keyshorcuts and Keymapping menu says
Cannot read property map of undefined

Does this issue occur when all extensions are disabled?: Yes/No
Yes

Added information to the issue.

Latest snap release same problem, even after doing a clean install
Commit: 09158c5b7aefa2de9e66f4905d67c6c4a54fbe6c
Date: 2019-06-14T05:15:41.984Z
If you need something else, let me know, thanks!

The problem was fixed with latest snap release, closing the issue.


Add Python client to PyPI

Hello
Please can you add your Python certificate transparency log client to PyPI (the Python Package Index)?
Then users could run, for example, pip install ct-client. This would then enable them to query public CT logs like your log client already supports, but with a really simple setup compared to cloning git repos and manually running lots of commands.
Thank you

This would help solve https://github.com/google/certificate-transparency/issues/1411


Remove question-level help buttons and replace with "collapse_template" button

T&P 73, 74-1, 74-2, 75
We only have a few stock questions that use the help button now.

Some further clarification from the T&P feedback on why the Help button isn't a great choice:


Task - resolve OTUs to taxon names

   when I open the task
       then I see a paginated list of OTUs that have taxon_name_id # nil   (similar to otus/list)
         and each name is wrapped in its own asynchronous form
           and a fuzzy name match for possible TaxonNames lists possible quick selections
           and a autocomplete is available to find names manually
           when I select a taxon name
                 and I click update
                     and there is success
                         then the row is removed
                              and the recent updates list below the paginated OTUs is updated
       then I see a list of recently updated OTUs at the bottom of the page

Cross reference and potential alternative approach- https://github.com/SpeciesFileGroup/otu_mapping_widget

Overtaken by external events.  @mjy observed an already complete example of this functionality at a conference and our experiment was abandoned.


collect vector logos

I need vector files for the following logos, ideally their horizontal versions. None of them make this available on their sites as far as I could see:

[ ] COALA
[ ] Human Data Commons Foundation
[x] Dyne.org
[x] unMonastery
[ ] SmartContract
[x] Tendermint
[x] CREATE-NET

@gmcmullen do you have a contact for all of them? If so, could you reach out to them please?
Either drop logos onto this issue as a comment or drop on the Trello card: https://trello.com/c/q0HGMPx0/54-build-ipdbio-website-for-developers-reconcile-developersipdbio

Sent request to all.

dyne.svg.zip

tendermint-logo.svg.zip

unmonastery-logo-ai.zip

FBK-Create-net_vet.eps.zip

Sent reminders to the outstanding groups.

HDC-svg.zip

Coala_Logo.pdf

Also need:

[ ] Global Consent
[ ] KICTANet

LOGO KICTANET.pdf


Project Feedback

Hi I really liked the idea of the book recommendation system and project that you have built so far. I also visited your project website. It looks really nice.
Some suggestion for improvement:

I notice that you have used a lot of carousels, well it looks good at first but it's difficult to use at least for me when I  was exploring your explore page and your home page genre session. I would like it more if new books are added as I scroll down on the explore page. For genre sessions I would recommend showing it all in grid view in your home page.
Color scheme can be improved. There are many website that you can use like coolors.co or colorhunt.co.
For some book cards where author name and book name are long they overlap the rate this button and more details button. You can tackle this by defining a fix size for author name and book name sessions for each bookcard and crop the rest of part if it does not fit in the defined size replacing it with ... .

Regards,
Sudhir

Hi @Sudhir-Pawar
Thank you for visiting the project and giving Feedback.
for  your suggestions:
1.We have lots of books to show in the Explore section that's why we made carousel for it. We will try but if it's giving the user a friendly way to operate the website.
2.This will be solved by issue #13 we are working on it.
3.Can you specify in which section this happens.
Also if you want to take any of this issue you are welcomed to contribute :smile:

For bookcard where bookname and authorname  are long overlap with ratethis and more details button happens in "Popular Among Us" section on Home page.

ok thanks @Sudhir-Pawar

#26 Fixes this

#26 Fixes this


Added support for UTF8 encoding

Hi Artem, I've created a pull request to add UTF8 support as the most widespread encoding nowadays. Not sure how to add proper tests to the solution, but tested locally.
Used "🚀" rocket as an example of 4-byte UTF8 char.
Used code samples:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/fromCodePoint
http://stackoverflow.com/questions/15181809/javascript-charcodeat0-stuck-at-55357
https://gist.github.com/volodymyr-mykhailyk/2923227
Additional info: https://en.wikipedia.org/wiki/UTF-8

Hi! Many thanks for your participation.
I've  reviewed your pull request and there are some issues.
As jsperf.com has been broken I have to create a small benchmark at jsfiddle.
I slightly modifed your string_to_utf8bytes to achieve at about x4 speedup and its performance becomes competitive w/ original string_to_bytes. So I'm considering to replace original string_to_bytes with UTF-8 capable one.
Unfortunately I'm out of spare time for now.
I'll let your pull request in ASAP.

Wow, it looks like function inlining makes the code much faster, which is obvious, but I didn't take the efficiency into consideration, which is a shame. :) Let me fix it then.

Following your lead I've got rid of redundant function calls in the second method as well and managed to boost its performance too! Check this out https://jsfiddle.net/kct18qn8/3/
I've updated the pull request with the tweaks.

Hmm...
String.fromCharCode.apply( String, strBuffer.subarray(0, j) );

Bad idea.
Guys from Google Closure already shoot their leg once and the solution seems well to me.

Ok, I'll break it into chunks. I wonder where did they take their magic number (8192) from...

I just couldn't resist the temptation to make batch size a little bigger :)


Bump aws-cdk-lib to 2.60.0 or newer in custom resources (v11.0.0)

Is this feature request related to a new or existing Amplify category?
No response
Is this related to another service?
Extensibility
Describe the feature you'd like to request
Version v11.0.0 released support for CDK v2 in the extensibility helper/category. However new custom resources generated with the latest version of the CLI bring a version of aws-cdk-lib that it's over 3 months old (~2.5.3).
Before v11.0.0 it was possible to manually override the CDK version in the custom resource, however now the @aws-amplify/cli-extensibility-helper sets<EMAIL_ADDRESS>as dependency, which prevents us from updating the version in the custom resource.
The main issue here is that this version of aws-cdk-lib is pretty old and notably it's missing the stable version of aws-cdk-lib/aws-appsync, which was released in 2.60.0.
Describe the solution you'd like
It'd be great if in the short term you could update the aws-cdk-lib version to at least 2.60.0, which is the version that promotes the aws-cdk-lib/aws-appsync package to stable.
In the medium/long term, it'd also be great if the custom resource could be more forgiving with the version allowing for overrides, but even just the point above in the next release of the CLI would be great.
Describe alternatives you've considered
None, the fact that @aws-amplify/cli-extensibility-helper also brings a specific version of aws-cdk-lib as direct dependency means we can't install another version in the custom resource as this will equal to have two different CDK versions which breaks stacks (see error below):

Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request

Would this feature include a breaking change?

[ ] ⚠ This feature might incur a breaking change

+1 having access to a more up-to-date CDK release would be very important to make it usable in my current project.

+1 having access to a more up-to-date CDK release would be very important to make it usable in my current project.

+1

+1

+1

+1

+1

Folks, if you can help it, don't just comment +1.
It doesn't further the conversation and it's not nice/respectful towards the maintainers. If you'd like to express support for the feature/issue, use reactions on the OP.

Thank you @sobolk and the rest of the team for addressing this.
I for one appreciate the work you're doing and the response to this issue.

Waiting fo this to be merged.


Method "TeamcityServiceMessages.publishArtifacts" doesn't work

teamcity/messages.py#63
Problem: Method "_single_value_message" has no argument "flowId"

Thanks, fixed


artifact detection

Closes #7077
I have added (temporally in the wrong place) a function script to mark suspicious channels of being bad,  a muscle artifact detection (in practice almost the same as if Fieltrip) and movement annotation and head position trans correction.
The muscle and movement might be crucial in some datasets when Maxfilter is not applied and currently mne-python does not provide these functions.

@AdoNunes can you your file plot_ and not demo_ so it gets executed thanks

@AdoNunes it needs to be in examples/preprocessing folder so it’s rendered by circle ci

@AdoNunes it needs to be in examples/preprocessing folder so it’s rendered by circle ci

sorry, I got it now....

Why I am getting the ci errors?
Like this:
generating gallery for auto_examples/preprocessing... [  5%] plot_artifact_detection.py
Killed
Makefile:49: recipe for target 'html_dev-pattern' failed
make: *** [html_dev-pattern] Error 137
Exited with code 2

I suspect it's a memory issue. Can you check using a memory profiler how much memory you consume?

To follow what @jasmainak said, you should try to keep examples below 1.5 GB memory consumption, otherwise you risk CircleCI failing. mprof run my_example.py then mprof plot will show you consumption. If you can get away with using 30 sec or 60 sec of data, do read_raw_ctf(fname).crop(None, 30).load_data() to save memory. It's why a lot of our examples start that way.

That it's tight! It peaks at 1.7Gb but then it goes down.

Try to see if you're making any redundant copies and get rid of them. You can also use preload=False to save memory.

Try to see if you're making any redundant copies and get rid of them. You can also use preload=False to save memory.

By shortening even more, changing the order and decimating first then notching it worked :)
I will fix the ::doc things and I will resubmit

I am getting an error and I don't know who is wrong.
When I crop de raw, say from (100, 300). The raw.times starts at 0, although, the raw.first_time is 100. Is that how it is supposed to be?
Because, then the function _calculate_head_pos_ctf  returns "quats", the quats[:, 0] is the time, and in chpi.py line 264 -> quats[:, 0] += raw._first_time. So the quats time has an offset that does not match the cropped raw.times and this gives me wrong annotation timings.
Any insights?

I don't know about quats but it looks like you just need to handle it correctly by adding raw.first_time in the right places. You might find this tutorial useful: https://mne.tools/stable/auto_tutorials/raw/plot_30_annotate_raw.html
Let's make it work so that CircleCI renders something with plots and then we can worry about these details later.

@AdoNunes I suggest spending some time to improve the readability of the code -> e.g., by adding docstrings and better variable names. It helps people to understand the code faster and review better.

Any comments about the functions @agramfort  @larsoner ?
I wanted to make a notebook tutorial instead of an example and explain each step more clearly, but first I guess I need to hear what do you think about the functions

These sound like reasonable functions to me that could live in the mne.preprocessing namespace. I have some ideas about the naming, parameters, and code:

detect_movement isn't a great name because it sounds like it might produce the same thing that calculate_chpi_positions does (since it also "detects movement" using the HPI coils). Maybe adjust_movement, adjust_dev_head_t, or so? Though it also marks some bad segments so I'm not sure. The key distinction compared to maxwell_filter, which can continuously adjust for movement, is that this function would adjust in a static way, so it would be nice if that's in the name somehow. Mostly just some food for thought.
I would have it take a raw instance.
I wonder if the algorithm iteratively marked segments as bad that deviated from info['dev_head_t'] and reestimated info['dev_head_t'], and unmarked the old marked-as-bad segments would work better (though maybe it's not necessary to make more than one pass). The convergence criterion could be marking >= 95% of segments as bad between one iteration and the next and having some sufficiently small angular and translational change in dev_head_t (or exceeding max_iter).
I have some functions for marking segments of data with excessive movement speed and rotational velocity as bad. This should probably be done before this adjust_dev_head_t function, since you never want to use those segments for anything (presumably).
detect_muscle has some unnecessary params like notch filtering. You should just tell people that they should do it to ensure the algorithm works properly, as it's a separable step. For example you can use mne.chpi.filter_chpi to do this, or raw.notch_filter with a variety of settings that might work better for some systems and recordings than others. So better not to fix doing so a single way for people.

thx @AdoNunes for looking into this. I agree that having some convenient functions to offer automatic annotation of artifacts would be really handy
I would suggest to start with movement artifact. Basically just do this in one PR.
Regarding naming of the functions as it outputs annotations I would call it annotate_head_motion or find_head_motion. I agree it should take a raw as input and just return annotations and some second parameter for inspection if requested.
does it sound doable? @larsoner can you share code snippets you have?

Hi @larsoner and @agramfort for your input. I will make a new PR with only the motion, most likely tomorrow.
OK, I could call them annotate_head_motion  and annotate_muscle.  in addition, annotate_head_motion gives a new info['dev_head_t'] reestimated with good segments only.

I wonder if the algorithm iteratively marked segments as bad that deviated from info['dev_head_t'] and reestimated info['dev_head_t'], and unmarked the old marked-as-bad segments would work better (though maybe it's not necessary to make more than one pass). The convergence criterion could be marking >= 95% of segments as bad between one iteration and the next and having some sufficiently small angular and translational change in dev_head_t (or exceeding max_iter).

What you are saying is to mark bad segments deviating Xmm from info['dev_head_t'], reestimate
info['dev_head_t'] taking the median head pos without the bad segments, and then look again on all the segments and mark those deviating from the new median. This is what I have done. You are saying to loop it again until converges or reaches max iter?

I agree it should take a raw as input and just return annotations and some second parameter for inspection if requested.

Currently, there is not a function in chpi that calls  _calculate_head_pos_ctf, so I can not use a generic chpi function that gives me the chpi head pos for ctf.

I have some functions for marking segments of data with excessive movement speed and rotational velocity as bad. This should probably be done before this adjust_dev_head_t function, since you never want to use those segments for anything (presumably).

I did not use it myself but @bloyl uses it.
That is his code:
# compute displacements
    hpi_disp = chpi_moving_head - np.tile(chpi_static_head, (len(time), 1, 1))
    hpi_disp = np.sqrt((hpi_disp**2).sum(axis=-1))
    # compute velocities
    hpi_velo = chpi_moving_head[1:, :, :] - chpi_moving_head[:-1, :, :]
    hpi_velo = np.sqrt((hpi_velo**2).sum(axis=-1))
    hpi_velo /= np.tile(time[1:] - time[:-1], (n_hpi, 1)).transpose()
    hpi_velo = np.concatenate((np.zeros((1, n_hpi)), hpi_velo), axis=0)

OK, I could call them annotate_head_motion and annotate_muscle. in addition, annotate_head_motion gives a new info['dev_head_t'] reestimated with good segments only.

I would make the API slightly different. I think the deviation-annotation and reestimation steps are separable and that there are advantages to separating them. It will for example make the iteration idea user-implementable and configurable without much effort. Concretely these are the functions I would add:

 annotate_head_pos_velocity(raw, pos, translational=0.1, angular=0.2)

adds BAD_HEAD_POS_VELOCITY_TRANSLATIONAL / _ANGULAR whenever translational velocity of 0.1 m/s or rotational velocity of 0.2 degrees/sec is exceeded (or whatever's reasonable for adults). You basically never want to use these segments with excessive velocities for anything -- even when maxwell_filter is being used -- because they are usually quite noisy.

 annotate_head_pos_distance(raw, pos, translation=0.01, angle=5)

adds BAD_HEAD_POS_DISTANCE_TRANSLATION / _ROTATION to raw.annotations based on deviations in pos from raw.info['dev_head_t'] in m or angle in degrees

 compute_average_dev_head_t(raw, pos)

computes the time-weighted average dev_head_t from raw, omitting segments that are BAD_* and returning a new Transform. So some people would do:
raw.info['dev_head_t'] = compute_average_dev_head_t(raw, pos)

But it's useful also when doing Maxwell filtering with continuous compensation because you can do:
destination = compute_average_dev_head_t(raw, pos)
raw_sss = maxwell_filter(raw, head_pos=pos, destination=destination)

This is actually useful in the continuous compensation context because it helps reduce noise amplification due to virtual sensor calculations. (I just noticed that it's not documented that you can pass a dev_head_t as destination, but you can!)
I have code for this time-weighted average estimation. Distance is easy but there is a trick for the quaternions due to non-uniqueness that is nicely solved using SVD.

@AdoNunes in this framework I think your pipeline would be:
annotate_head_pos_velocity(raw, pos)
annotate_head_pos_distance(raw, pos)
raw.info['dev_head_t'] = compute_average_dev_head_t(raw, pos)  # set new dev_head_t
# XXX few lines here to remove the old distance annotations
annotate_head_pos_distance(raw, pos)   # redo annotations based on that one

@AdoNunes WDYT? It seems more explicit about what's happening and tackle-able in separate steps, which might be nice.

You are saying to loop it again until converges or reaches max iter?

The iterative procedure I'm thinking of would be a simple variant of the above few lines, where you loop over the raw.info['dev_head_t'] setting, annotation removal, and redoing of annotate_head_pos_distance above until some satisfactory condition is reached.

Currently, there is not a function in chpi that calls _calculate_head_pos_ctf, so I can not use a generic chpi function that gives me the chpi head pos for ctf.

There is in master as of 30 minutes ago :)
https://github.com/mne-tools/mne-python/pull/7117

@AdoNunes WDYT? It seems more explicit about what's happening and tackle-able in separate steps, which might be nice.

Yes, what you propose is more efficient

Wouldn't it be more convenient for users to have a wrapping function that outputs the final annotations and the new head pos (inside it would call the 3 functions that you proposed)?

I was using a weighted median, so it is not affected by outlier head pos. Should I keep it or use a weighted mean?

The iterative procedure I'm thinking of would be a simple variant of the above few lines, where you loop over the raw.info['dev_head_t'] setting, annotation removal, and redoing of annotate_head_pos_distance above until some satisfactory condition is reached.

I thought it might be overkill, but initially, I was thinking that the best fit would be to iterate for each head pos and select the one that retains the most. Do you think that would be computationally too expensive?

Wouldn't it be more convenient for users to have a wrapping function that outputs the final annotations and the new head pos (inside it would call the 3 functions that you proposed)?

I would not add a new function wrapper to MNE just to do these three lines of code. It is not asking much of users to call these individually. Also, eventually each of these functions could have more and more options, and the wrapper would have to have them.
Also I don't think we ever need to "output annotations", I'm thinking these functions would directly modify raw.annotations by appending the new bad annotations. The only function above with a return value would be compute_average_dev_head_t.

I was using a weighted median, so it is not affected by outlier head pos. Should I keep it or use a weighted mean?

I'm thinking that the won't be any real outlier head positions after the annotate-based-on-distance/velocity steps.
One problem with median is that I'm not sure how to properly calculate the median of the quaternions (and it seems like the direction cosine matrix part of the transformation should be processed in the quaternion domain). One reason in favor of the average is that it might actually work better in principle, knowing there are no bad outliers. For example, if you had a recording where 50% of the time was spent in one position, 50% in another that's off by just a little bit, using the average would make both halves roughly the same (in)correctness / distance from the recomputed info['dev_head_t'], whereas using the median would make one of them correct and the other incorrect.

I thought it might be overkill, but initially, I was thinking that the best fit would be to iterate for each head pos and select the one that retains the most. Do you think that would be computationally too expensive?

I think it would probably be quite slow to optimize this, but we can see. Let's implement the simple, non-iterative / non-optimized version, and if it turns out it seems like iterating could actually be beneficial we can try these schemes.

OK, I am working on it.
@larsoner  after estimating the new  dev_head_t, how do I recalculate the new average head position from it?
Now compute_average_dev_head_t gets the annotations from raw, estimates the weighted mean head pos and finds the closest recorded pos that match the mean head pos. Then this new head post is used for computing dev_head_t with the function _quaternion_align. In the annotation function, how do I get the mean head pos using the dev_head_t?

after estimating the new dev_head_t, how do I recalculate the new average head position from it?

I am not sure what you mean. The average head position should always be calculated using the head_pos file, whatever is in dev_head_t does not really matter (except sometimes as a starting position if it's missing from head_pos). Here is the code I've been using to compute the time-weighted average dev_head_t:
https://github.com/LABSN/mnefun/blob/master/mnefun/_sss.py#L766-L825
And here is code for finding velocity deviations (ignore the code for coil distances for now, we can add that later if we want, it's also useful because it can indicate that the head pos estimation is unreliable):
https://github.com/LABSN/mnefun/blob/master/mnefun/_sss.py#L913-L1017

finds the closest recorded pos that match the mean head pos.

I don't think we need to do this -- no reason we can't create a dev_head_t that wasn't in head_pos / dev_head_t anywhere.

In the annotation function, how do I get the mean head pos using the dev_head_t?

The annotation function should not operate on / care about any mean head pos. It should just use whathever is in info['dev_head_t'] and then look for where head_pos positions/angles deviate from it. It's up to the user to set raw.info['dev_head_t'] to a mean head pos if they want to annotate deviations based on distances from that.

we try to avoid functions that modify inputs inplace.
I prefer to return annotations so I can check them without applying them
or making a copy() as input

I am not sure what you mean. The average head position should always be calculated using the head_pos file, whatever is in dev_head_t does not really matter (except sometimes as a starting position if it's missing from head_pos). Here is the code I've been using to compute the time-weighted average dev_head_t:
https://github.com/LABSN/mnefun/blob/master/mnefun/_sss.py#L766-L825

@larsoner  I tried to parse out the code and got lost after these_qs = hp[:, 1:4] . Quaternions are an obscure topic for me. Nonetheless, I can adapt the code and also the one for finding the velocity deviations.
Should I just take your code and ignore the function compute_average_dev_head_t that I wrote?

FYI @AdoNunes I just noticed we already have mne.transforms._average_quats that you can use

Why am I getting errors from trevis and circleci? It can not find the sample data? :,(
Besides that, @larsoner  are you happy with the annotate_movement and your compute_average_dev_head_t?
Do I make too many blank lines in the functions or it makes it more readable?

@AdoNunes can you trim down the PR to movement artifacts? I still see more things here.

CI error is unrelated...

@larsoner  I get an error with the new _average_quats. I get the following error because the quats are 4 dim:
File "", line 3, in _quat_real
assert quat.shape[-1] == 3
In compute_average_dev_head_t the quats are 4d:
    rot_qs = hp[:, 1:4]
    res = 1 - np.sum(rot_qs * rot_qs, axis=-1, keepdims=True)
    assert (res >= 0).all()
    rot_qs = np.concatenate((rot_qs, np.sqrt(res)), axis=-1)

What is your suggestion?

Do not pass the ones with the forth element concatenated. Remove the res and concatenate lines and pass the rot_qs that only have last dimension size 3.

The CI fail is not related to the PR

@AdoNunes I only added some remarks with respect to printing (that its better to use mne logger), but otherwise you'd have to wait for @larsoner comments. Bear in mind that you will need a test covering the usage of annotate_movement, but here also @larsoner will be more helpful.


Cluster lost if controller node fails ?

Hello all,
I deployed a cluster and noticed something. The etcd "cluster" is not a cluster, as etcd only runs on the controller node. Plus etcd data store is located on an ephemeral disk (if the instance terminates, the disk is destroyed and all the cluster configuration will be lost).
I see that a cluster deployed with Kubernetes' kupe-up command also as a single node etcd cluster, but etcd data store is on a disk that is not destroyed if instance terminates.
In my setup, I don't need the controller node to be highly available. If it dies, my application pods will keep running on my workers and my end users won't experience downtime. However, what happens if my master node dies ? It seems that I won't be able to restart it properly and my workers will be left without master forever ...

Hi @robinmonjo. What version and configuration did you use?
Note that in recent versions of kube-aws etcd is deployed as separate cluster - you can configure how many nodes to spin up, as well as the node type. In the new kube-aws repo we're also working on new functionality regarding etcd availability/backups.

Hi,
Sorry wrong repo ! This is the first result in google for kube-aws, not the first time I do the mistake :). I deployed using version 0.8.2 and following this guide: https://coreos.com/kubernetes/docs/latest/kubernetes-on-aws-render.html.
I didn't tweak the configuration much, just made the certificates last 10 years and deployed workers in 2 availability zones. Sorry for the noise, I'll close this issue and dig more into custom configuration.

No problem :)
I'm actually working on making it easier to integrate with externally managed etcd solutions so operators can decide themselves on how to manage cluster state. I personally like https://crewjam.com/etcd-aws/, which i utilize through https://github.com/pieterlange/kube-aws/tree/feature/external-etcd which should be merged relatively soon after i work out some minor bugs.

Perfect, thank you for this information. I'll will have a look once this is merged then.


Glossary.md Sync'd up on Greedy Matching Definition

#2933 is the larger goal
#3359 raises my case for why this specific doc update should be prioritized

Ah I should have paid more attention to the rest of the glossary links. I understand now.

Thanks!


fix bug of refresh cluster

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes https://github.com/seata/seata/issues/1160
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1222 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             develop   #1222      +/-   ##
============================================
+ Coverage       43.5%   43.5%   +<.01%
  Complexity      1428    1428
============================================
  Files            250     250
  Lines          10218   10206      -12
  Branches        1330    1318      -12
============================================
- Hits            4445    4440       -5
+ Misses          5188    5187       -1
+ Partials         585     579       -6

Impacted Files
Coverage Δ
Complexity Δ

...very/registry/zk/ZookeeperRegisterServiceImpl.java
63.77% <0%> (-0.79%)
24% <0%> (ø)

...in/java/io/seata/server/session/BranchSession.java
78.86% <0%> (-0.05%)
41% <0%> (ø)

...a/io/seata/core/rpc/netty/MessageCodecHandler.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...n/java/io/seata/rm/datasource/ConnectionProxy.java
9.63% <0%> (+0.11%)
4% <0%> (ø)
:arrow_down:

...server/store/file/FileTransactionStoreManager.java
47.03% <0%> (+0.34%)
19% <0%> (ø)
:arrow_down:

...in/java/io/seata/server/session/GlobalSession.java
80.78% <0%> (+1.46%)
58% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b9e03...6ff3a37. Read the comment docs.


Add CHAOSS as a resource or story to the Metrics guide

Looking through https://opensource.guide/metrics/, I was wondering whether we could find a way to reference the CHAOSS project. CHAOSS is an open source project under the Linux Foundation that is focused on defining, standardizing, and implementing metrics so that anyone can start their metrics journey. CHAOSS recently released a new version of metrics and provides a sophisticated tool GrimoireLab.
This might be too early, but I want to also mention it: Bitergia, the company behind GrimoireLab, is developing a SaaS metrics platform that is free to use for open source projects: Cauldron.io. Cauldron is in early alpha development and not stable to be recommended at the moment, but the people can use the tool as long as they know about the caveat.
Disclaimer: I am a cofounder and colead of the CHAOSS project and I now work for Bitergia. This means I have my bias but am also well positioned to help with this kind of content.
I opened this issue to ask, whether adding CHAOSS, GrimoireLab, or Cauldron.io as a resource would be interesting for the Metrics guide.

#1439

Hi @nilli54, What does it mean when you reference this issue within itself? I am not familiar with that practice. Thanks for helping me understand.

Hi @GeorgLink perhaps someone else not associated with the projects will suggest adding one of the things that you've mentioned when they are beyond early alpha.
That said if you've got any broader thoughts or critiques about the metrics guide, I'd be interested in reading them. That guide is certainly the least developed and shortest of the guides, perhaps rightly so, as best practices aren't well established for OSS project metrics, at least not relative to topics covered in other guides.

What does it mean when you reference this issue within itself?

It's pointless. I occasionally see new users do this, but I've no idea what leads them to do so, presumably they're just trying things out? 🤷♂

Closing this for now. We'd consider a PR from someone not associated with the project. Thanks!


Python Password Generator

[x] Proper documented
[x] Used Python
[x] No error in code
[x] For HacktoberFest

@shivangdubey Can you check why it's failing?

@shivangdubey Can you check why it's failing?

There are issues in the checker itself.
It's better to add something descriptive about the project rather checklist.

Okay, you can make a template for that maybe.


Fix PolicyRevision of endpoint bumped prematurely

Summary of changes: pkg/endpoint: set policy revision if there is no datapath changes
As cilium calls regeneratePolicy inside regenerateBPF, it could end up
setting up the policy revision before enforcing the changes in the
datapath.

This bug could be triggered by TriggerPolicyUpdates where the trace call
could be the following:

1 - endpoint.TriggerPolicyUpdates
  2 - endpoint.TriggerPolicyUpdatesLocked
    3 - endpoint.regeneratePolicy
       returns (true, nil)
     returns (true, nil)
  4 - endpoint.Regenerate
    5 - endpoint.regeneratePolicy
        6 - endpoint.setPolicyRevision(y) # -> WRONG!
    7 - endpoint.regenerateBPF
      8 - endpoint.setPolicyRevision(y) # -> 'y' was already wrongly set in step 6

Fixes: #4462
@tgraf does this need backport to 1.0? If yes, I need to create a new PR without 670c5e5a26408827abe5abf2d33d1c36db6ce63c

This change is

test-me-please

@aanm While understanding that 670c5e5 has an unfixed bug, are we sure that pre 670c5e5 is correct in terms of the timestamp that is put into the LastUpdated field?

@aanm While understanding that 670c5e5 has an unfixed bug, are we sure that pre 670c5e5 is correct in terms of the timestamp that is put into the LastUpdated field?

Yes, I was testing this against k8s, otherwise I would still see a similar bug that I've fixed in 9d267bc2276fac32e1580fa8711747dae88fe38d.
@tgraf Also I've been thinking about this, this is not a regression because it never worked as intended so no need to hold 1.1 because of this IMO

Not saying this is the wrong fix, but I am wondering under which circumstances the following logic does not capture that the endpoint needs to be regenerated:
if !policyChanged && !optsChanged {
    e.setPolicyRevision(revision)
}

Does this occur because there is a case where the following evaluates to true?
needToRegenerateBPF := optsChanged || policyChanged || e.nextPolicyRevision > e.policyRevision

but,  (!optsChanged && !policyChanged) == true? In other words, we actually need to regenerate BPF? In other words, e.nextPolicyRevision > e.PolicyRevision?
It would be helpful to outline a case where this can happen, i.e. what conditions in the agent can cause the failure that was observed. Also, if possible, if we can trigger the bug via a test against current master, then add it to the CI as well as part of this PR. I'm having a hard time understanding the logic around revision checking :(

@ianvernon please read the PR description and the comment I left in the code. There's nothing wrong with the needToRegenerateBPF logic.

test-me-please

test-me-please

Not saying this is the wrong fix, but I am wondering under which circumstances the following logic does not capture that the endpoint needs to be regenerated:

This was very confusing to me as well at first. We call endpoint.regeneratePolicy() twice

@aanm I somehow missed your reply :/

There's nothing wrong with the needToRegenerateBPF logic.

OK, got it, I was afraid that this was the case, I could not gleam that from the description / comment.

This was very confusing to me as well at first. We call endpoint.regeneratePolicy() twice

@tgraf is there a reason we need to call it twice? Why can't we call it outside of regenerateBPF i.e., in regenerate before calling regenerateBPF?


Nested stacks

For example, an outer stack using 'cube' with an inner stack using 'slide-horizontal'. The inner stack should be reactive to changes in its children routes, but the outer stack not.

This functionality should be supported via a key prop on your route component: https://github.com/Traviskn/react-router-native-stack#nested-routes
This assumes that you have a component structure where inner stack is being rendered by a route component in the outer stack

Thanks, I was missing that, but also it wasn't working for me in the first place when there were no matching child routes (because a series of errors when children or previousChildren were null). I'll send you a PR with the fix.

Thanks for your PR!


Forbid invalid Coordinates object

[x] Closes #8883
[x] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

Alternatively we might want to drop assert_valid_explicit_coords. This was probably a leftover from relaxing the nD dimension coordinate constraint in the xarray data model in #7989 (xref https://github.com/pydata/xarray/issues/8883#issuecomment-2024645815).

Oh! Well that's cool.
Closing in favour of #8886


Backport removal of flaky test marker to 1.12

High-level description
Backport removing flaky test marker for DCOS-41819
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-41819

Checklist for all PRs

[X] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: test change
[X] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: test change
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot label Ready for Review


update to @instana/collector broke our application

previously we are referencing instana-nodejs-sensor. After our CI / CD ran npm install yesterday it errored out saying the package is renamed to @instana/collector. I have updated our application to reference the new package and followed the instructions here. Unfortunately I'm getting errors after the agent is instantiated.
TypeError: Cannot read property 'timeBetweenHealthcheckCalls' of undefined
    at Object.exports.activate (/usr/src/app/node_modules/@instana/core/src/metrics/healthchecks.js:25:46)
    at /usr/src/app/node_modules/@instana/core/src/metrics/index.js:31:31
    at Array.forEach ()
    at Object.exports.activate (/usr/src/app/node_modules/@instana/core/src/metrics/index.js:29:24)
    at Object.exports.activate (/usr/src/app/node_modules/@instana/collector/src/metrics/index.js:15:21)
    at Object.enter (/usr/src/app/node_modules/@instana/collector/src/announceCycle/agentready.js:28:21)
    at Object.transitionTo (/usr/src/app/node_modules/@instana/collector/src/announceCycle/index.js:25:34)
    at /usr/src/app/node_modules/@instana/collector/src/announceCycle/announced.js:23:21
    at callbackWrappedForAtMostOneExecution (/usr/src/app/node_modules/@instana/core/src/util/atMostOnce.js:27:27)

I‘m sorry that this change caused issues. I‘ll look into this immediately. If you need an immediate workaround you could pin the dependency to version 1.64.0 by running npm install —save<EMAIL_ADDRESS>in your project.

A proper fix for this has been published with version 1.65.1 of @instana/collector, so the workaround I outlined above is no longer necessary. Again, sorry for the trouble this has caused.


docs: Add embedding explanation

Resolves: #2042
Signed-off-by: Vasek - Tom C<EMAIL_ADDRESS>

/cc @gerhard

Agree with the reformatting, hard to see what's changed.


[🐛] Hacking instructor: DevTools open detection is CPU and RAM heavy and never stops

:bug: Bug report
Description
When doing a challenge with Hacking Instructor which checks for the opening of the devtools (e.g. "view basket" challenge) I noticed that the devtools console was going crazy in a loop as my CPU 🤯

I understand that this comes from the code that waits for devtools:
https://github.com/bkimminich/juice-shop/blob/d29573a5d88209ecbe482b2b2140ded6f17d6b5b/frontend/src/hacking-instructor/helpers/helpers.ts#L128-L131
And this potential issue was mentioned: https://stackoverflow.com/questions/7798748/find-out-whether-chrome-console-is-open/48287643#comment110980766_48287643 🤔
Moreover, this never stops even after completing the challenge! We have to refresh the page to stop the loop.
Is this a regression?
No
:microscope: Minimal Reproduction

Go to scoreboard
Launch "view basket" challenge
Follow instructions until you are asked to open devtools
Open the devtools and go to the console tab
Notice the many "" elements being logged, which is normal as it's the way this hack works... (which is a nice trick anyway! 😅)
Follow the remaining instructions, clear the console, see how it continues to fill up

:fire: Exception or Error
N/A
:deciduous_tree: Your Environment
N/A
Running latest code from develop branch as of now
Additional Information
Some suggestions:

Sleep longer between each check. Currently: 100ms but I think 500ms or even 1s might be reactive enough while reducing the load
At least stop it when the condition (devtools opened) is reached. I don't have enough mastery of async to suggest something sorry...

Does this properly detect if your dev tools are opened?
The check should™ stop once the dev tools have been opened :)

If the DevTools detection is only possible in a "whacky" way, then we can also drop it entirely as it was before. The tutorial would still be fine, it just made it feel more smooth when waiting for the DevTool to open. But it's by no means essential.

https://github.com/sindresorhus/devtools-detect
Seems pretty stable and easy to use

The current solution works fine and detects when I open the devtools but I confirm that it continues in the background (but I cannot say why because of my limited understanding of its implementation with a promise...)
It's a very nice thing to have (and I was actually very curious to see how it detected it!) so it would be nice to keep it!
I've also found the devtools-detect that you mentioned @J12934, but I find its implementation to be more unreliable because it relies on checking the dimension of the display:
		const widthThreshold = window.outerWidth - window.innerWidth > threshold;
		const heightThreshold = window.outerHeight - window.innerHeight > threshold;

It also doesn't work if the devtools are opened in a second window...

Mh took another look,
For me, it's working correctly in chrome, meaning it properly detects open devtools and stops the logging immediately after the detection.
In Firefox it doesn't work at all, I have to click the Hacking Instructor to continue there. This also causes firefox to be really badly impacted by this check as it never stops.
It possible to really improve the performance costs by running console.clear() behind the console.dir call in the check. This ensures that the console never gets overwhelmed by printing all of those entires, as it always only prints the last one.

I re-checked and indeed I confused Firefox and Chrome (was using both at the moment...). And I agree with you @J12934:

For me, it's working correctly in chrome, meaning it properly detects open devtools and stops the logging immediately after the detection.
In Firefox it doesn't work at all, I have to click the Hacking Instructor to continue there. This also causes firefox to be really badly impacted by this check as it never stops.

I tried to add console.clear as you said and indeed it still does not work on Firefox, but it does not make it suffer too much anymore (CPU and memory are fine, but the loop continues though), and the detection still work properly on Chrome.

@J12934 @cnotin Do you guys think something needs to be done here still?

Did we update this?
Don't remember seeing / doing any changes to the actual code, aside from experimentations.

Yeah, me neither, but I wasn't entirely sure if your conclusion was to change anything or just leave it as it is... 😁

I think the co conclusion was that we can add a console.clear call to fix the performance problems on both chrome and Firefox, but the detection will still only work in chrome.
Only downside would be that this would clear all console history of the current tab. This should not really be an issue in my view.

Same conclusion here :)
Let's try with this, which is still a progress!


File  Download Problem on click

File is not able to download when we click on file however when we right  clink on file and download then file download but on left click file not download.

Version of Filemin?

Version 1.1.1

Can you provide reproduction scenario?

Please share your e-mail id so I wil provide you credential.

<EMAIL_ADDRESS>

LOL, I've done those handy things like opening editor on clicking on text files, opening preview on images etc, and forgot to set default behavior to download for all others. Will fix that.

I've created the fix that will come to 1.1.3 release. For now you'll have to stick with right click. Or if you want so you can grab unauthenticated folder from this repo and place inside your Filemin installation, /usr/share/webmin/filemin usually.


Poor Example

I appreciate the work that goes into this sample and I've found it helpful in other tutorials. However I think it poorly demonstrates Updating related data. You have only one example of updating one to many related data (CourseAssignments) which works by passing a string array parameter that you have to break down once it is brought into the function and updated separate from the primary model (instructor). It seems inefficient and more importantly it doesn't address real world examples where a related model may have more than 1 property.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 938b178b-5f78-e673-df41-0409ad4412e1
Version Independent ID: c06d8343-1407-aa05-de96-c1aca71ba232
Content: Tutorial: Update related data - ASP.NET MVC with EF Core
Content Source: aspnetcore/data/ef-mvc/update-related-data.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: tdykstra

@jwhitener6  thanks for your comment. This tutorial isn't meant to cover more advanced scenarios.


UAVCAN hardfault on "uavcan param list"

Describe the bug
After a few calls uavcan param <list/get/set>, I encounter a hardfault that leads to a reboot.
To Reproduce
Steps to reproduce the behavior:

Black Cube (px4_fmu-v3_default) running latest PX4 master branch
Power via USB
Attach a Here2 GPS to CAN1 (the "real" CAN1)
Connect to serial console via an FTDI adapter
Call uavcan status to ensure UAVCAN is running (this will produce a crap ton of node-spin and vehicle_air_data errors, these don't appear in v1.10...).  It doesn't matter if you set UAVCAN_ENABLE to 0 and manually start it after boot, or set UAVCAN_ENABLE to 1.
Do a command like uavcan param list <nodeid> a few times
Cube will hardfault after anywhere from 2-5 calls from a fresh boot

Log Files and Screenshots

uavcan status error messages:

The hardfault after some get and set commands:

Reproducing the hardfault with 3 calls to uavcan param list 3:

This is probably just the command line uavcan param helpers missing locking.

Working on a fix in https://github.com/PX4/Firmware/pull/14741.

Forgot to update here - the possible fix #14741 does not seem to work.  Still unclear what the root cause might be.  The suggested solution makes sense (race condition on resource access), but the location of the error has not yet been found.

Thanks for the update, I'll try to reproduce locally with a debugger attached.

Cool, that would make things much easier for sure.  It doesn't always throw a hardfault though; whatever memory corruption is occurring seems to happen in a few possible locations.

I experienced this too, I think this may have been a stack overflow, potentially fixed by #15864

Should be fixed by master, please re-open if that's not the case.


More llvm-external-projects/iree-compiler-api into the main part of the project

The sub-tree llvm-external-projects/iree-compiler-api is funny because it exposes C and Python APIs consistent with the rest of the LLVM derived projects and is fairly tightly coupled to the LLVM build system in a way that the "internal" parts of IREE are not. While this makes it "somewhat weird", I think that we can integrate it better into the main project vs it being this completely separate side thing.
I would like to move it into iree/compiler/api. It would still be special from a CMake and Bazel perspective, but I could make it a lot better integrated and uniform if put there and always included as part of IREE vs the state it is in now where it can either be top-level or a sub-project (recent fixes have made IREE itself a lot more well behaved to depend on, so the benefits of having a separate way in are obsolete). It would also open us up to be able to use the APIs from the main part of the project (i.e. for samples, tools, etc), which would be a layering improvement.

@benvanik @ScottTodd objections/thoughts?

recent fixes have made IREE itself a lot more well behaved to depend on, so the benefits of having a separate way in are obsolete

that's good to hear!
I haven't been following the details too closely with respect to how each repo/project interacts, so a primer on the current state of things and the ideal end state would help me there, especially seeing the ml_program proposal, PRs like https://github.com/google/iree/pull/8581 and https://github.com/google/iree/pull/8575, and continued work on "linalg.ext".
Some questions I have:

What code would remain in llvm-external-projects/?
Would all frontends live upstream and target IREE public dialects, or do we expect to still have IREE-specific importers? It looks like the TMTensor stuff is heading a similar direction to the TOSA/MHLO importers in iree/compiler/InputConversion/, while iree-jax is mostly upstream / in other repos with just MHLO/JAX bits in the IREE repo.

recent fixes have made IREE itself a lot more well behaved to depend on, so the benefits of having a separate way in are obsolete

that's good to hear!
I haven't been following the details too closely with respect to how each repo/project interacts, so a primer on the current state of things and the ideal end state would help me there, especially seeing the ml_program proposal, PRs like #8581 and #8575, and continued work on "linalg.ext".

There are a number of moving targets, but in general, and apart from iree-compiler-api, everything falls into either a) on an upstream (or internalize) in the 6-9 months timeframe, or b) may exist indefinitely in some form but benefit from being dependency isolated and usable standalone.

LinalgExt: Needs to go upstream, likely in the form of an accepted tiling interface and specific ops in the tensor dialect. Probably 3-6 months out.
iree_input: Will likely always exist for the special parts but we are trying to standardize the common bits upstream. Should be separate and able to depend on for the duration of it being useful.
iree_transform: There is an active RFC to upstream, but the full vision is quite involved and could easily take 6 months to resolve.
tm_tensor: This is developed "iree-dialects" style in torch-mlir for ops not representable otherwise. It currently contains scan/scatter, which may be obsoleted by linalg_ext going upstream. However, it will likely grow over time as it is torch-mlir's "overflow area" in the same way as iree-input is IREE's "overflow area" (but going the other way).

iree-compiler-api is weird because it is wholly owned by IREE, not designed to be used externally but is closely tied to the LLVM build system. That last part is non-optional and why we sorted it with the other things that also share that characteristic. But it would make more sense being an isolated part of the iree/compiler tree that just happens to be "weird" from a build integration perspective.

Some questions I have:

What code would remain in llvm-external-projects/?
Would all frontends live upstream and target IREE public dialects, or do we expect to still have IREE-specific importers? It looks like the TMTensor stuff is heading a similar direction to the TOSA/MHLO importers in iree/compiler/InputConversion/, while iree-jax is mostly upstream / in other repos with just MHLO/JAX bits in the IREE repo.

Hard to say. In the far future, I would like this inverted and for frontends to provide their own APIs and importers. We are quite far from that future in detail.


Remove Docker 1.10 Cli from Agent

per request of @ibuildthecloud and some feedback we received from docker, we need to stop abusing the docker 1.10 client binaries.

Works fine on master-head (66c31dd) and 2.5-head (e9c4413)
Docker is removed from linux agent container, windows containers still have it (as expected)
I am not creating separate ticket for 2.5-head since it will be probably reverted.


Added missing resources to readme

added missing information about xIisFeatureDelegation, xIisMimeTypeMapping and xWebAppPoolDefaults to readme.md

Hi @hahndorf, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

The build got hung, I re-built it and it should be fine since you only updated the readme.

The Appveyor build hung twice already, and now we are getting a error in a test I have not changed. I'm not sure what to do now. I don't use these tools often enough to fully understand them.

@hahndorf - Yes, I understand your frustration. I'll look into this issue. It looks like it might be have something to do with changes that were recently added to our common tests.

Rebuilding the PR, I think we found the issue.

Review status: 0 of 1 files reviewed at latest revision, 6 unresolved discussions.

README.md, line 145 at r3 (raw file):

        * **2**: The secure connection be made using the Centralized Certificate Store without requiring a Server Name Indication.
        * **3**: The secure connection be made using the Centralized Certificate Store while requiring Server Name Indication.
* **ApplicationPool**: The website�s application pool.

These quotes got messed up somehow when you were making your changes. Could you go in and manually change them back? Sometimes this happens depending on the text editor you're using.

README.md, line 168 at r3 (raw file):

* **Website**: Name of website with which the web application is associated.
* **Name**: The desired name of the web application.
* **WebAppPool**:  Web application�s application pool.

Same with this one.

README.md, line 202 at r3 (raw file):

### xIisFeatureDelegation
* **SectionName**: relative path of the section to delegate such as **security/authentication**

Relative

README.md, line 213 at r3 (raw file):

* **ApplyTo**: Required Key value, always **Machine**
* **ManagedRuntimeVersion**: CLR Version {v2.0|v4.0|} empty string for unmanaged.
* **ApplicationPoolIdentity**: {ApplicationPoolIdentity | LocalService |LocalSystem | NetworkService}

space between | and LocalSystem

README.md, line 567 at r3 (raw file):

### Create a new website

While setting up IIS and stopping the default website is interesting, it isn�t quite useful yet.

Another quote issue

README.md, line 662 at r3 (raw file):

### Creating the default website using configuration data

In this example, we�ve moved the parameters used to generate the website into a configuration data file.

another quote issue

Comments from Reviewable

Thanks for your help Mariah, in my initial commit I did noticed the incorrect quotes and fixed them, but then to trigger another appveyor build I made one small change in the wrong Markdown editor. I will fix them and try again.

No problem, the bug with the AppVeyor build was on our end, so I apologize for the difficulty in getting this change merged in. Thank you for your patience!

Review status: 0 of 1 files reviewed at latest revision, 6 unresolved discussions.

README.md, line 145 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> These quotes got messed up somehow when you were making your changes. Could you go in and manually change them back? Sometimes this happens depending on the text editor you're using.

OK

README.md, line 168 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Same with this one.

OK

README.md, line 567 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Another quote issue

OK

README.md, line 662 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> another quote issue

OK

Comments from Reviewable

Now I lost track, were the broken quotes messages from before or after my last commit? Do I have to do something?

Broken quotes are all fixed, now there's just 2 more minor style fixes needed.

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

README.md, line 202 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> Relative

OK

README.md, line 213 at r3 (raw file):
Previously, mbreakey3 (Mariah) wrote…
> space between | and LocalSystem

OK

Comments from Reviewable


Create Kubernetes specific validation functions to use all over

From @helgi on September 15, 2016 21:13
Create validation functions for the various Kubernetes requirements
Such as validation what is used to validate the various length and char requirements. Basically DNS validation.
Labels are 63 chars, adhere to DNS specs, etc etc
This would allow a few models to have more unified validation functions, especially the tags validation could do with it.
Question is if this lives inside of the scheduler or not? Problem with it living there is at the end it needs to raise ValidationError for the serializers and friends, but worth investigating
Copied from original issue: deis/controller#1070

From @helgi on October 11, 2016 19:53
Yeah, initial thought was to add those to the util part of scheduler to have a kubernetes-py like functionality - Probably is enough.

From @bacongobbler on October 11, 2016 19:52
perhaps this is a good segway to create a kubernetes-py client lib that encapsulates all this behaviour for us.


images (img tag) inside of element don't get rendered. YES, I tried allowTaint. Yes, using latest version and syntax

Trying to simply get the "toDataURL('image/png')" call to work, so I and pass it to save as pdf. If there is an image in the element or child, the result of "toDataURL" is simply "".
I saw similar questions related to this and they all appear to be closed without of solution or mentioning something that is not the solution or cause at all:

I am using the "allowTaint" parameter
I am using the latest syntax
I am not pointing to a "file://" url

I installed this package via npm yesterday, so I assume is the latest version. Running it on the latest version of chrome.
Here is my code:
HTML:

		Sample Text

JS:
    var data = document.getElementById('product');
    html2canvas(data, {allowTaint : true}).then(canvas => {
        //method below works perfectly if there are no images in the html, but only returns "" (empty) if
        //there are images
        const contentDataURL = canvas.toDataURL('image/png');

    });

If there is something wrong with my code, could you please let me know and provide the corrected syntax?
Thank you.

I have the same problem !
Hi buddy,  do you solve this ?

I have the same issue ! Can you help me？Thank you !

Hi @heitorb, great that you created an issue to figure out this problem, could you create a codepen or similar that shows this not working? That would help a lot of debugging.

Hi. I had to get this done in some way and couldn't wait for feedback. I ended up using a service called api2pdf.com. Cost is negligible and my client was fine with it. As far as creating a code pen, I am on vacation until middle of next week. I will put a sample up then if still needed. The other two user commenting have the same issue.

it is seems that the image is at your local, do you try to convert your image to base64 before you apply html2canvas?
it likes this:
 =>
sorry, my english is a bit bad.


Events cleared from storage and request fails when user is offline

Expected Behavior
In offline mode we expect the events queue to be saved and re-send retried after the user goes back online in browser.
Current Behavior
The events are correctly saved in the AMP_unsent_ queue in local storage, but they get cleared out after failed flush.
The flush is auto triggered after the default 1s interval.
The error that happens when event is sent over the network is: Amplitude Logger [Error]: Failed to fetch
After this error occurs, the local queue is set to [] and we lose all the events, no attempt happens to resend anything after user gets back online.
Possible Solution
Maybe when the error is handled in analytics-core/src/plugins/destination.ts:168 there needs to be a check as to why it happened, and not clear the local storage, or alternatively not even try to flush when the user is offline, I don't know the codebase enough to suggest a solution 😅
Steps to Reproduce

Make sure the browser is offline (devtools or disconnect internet source)
Trigger few events (either the default ones from amplitude or custom ones)
The events are not present in the AMP_unsent_ queue because they are cleared after flush() -> send() fails

Environment

JS SDK Version: 2.3.2
Installation Method: Yarn
Browser and Version: Chrome/Safari

Hi @spirkovskii, thank you for choosing Amplitude. Your observations are correct and the SDK does not handle offline mode. I will file this as a feature request internally.

Hi @spirkovskii, thank you for choosing Amplitude. Your observations are correct and the SDK does not handle offline mode. I will file this as a feature request internally.

Oh, my bad then, I assumed that it does 😅
Thanks for the support!


400 error using Hygieia API from local

We are currently experiencing a problem pushing test information from our local to Hygieia using the API in the Hygieia readme. The Hygieia plugin has been downloaded and fully configured and after running the Jenkins job that runs the test (and should then push the info to Hygieia), the output shows that it is finding the json on our local, but it is unable to push the information to Hygieia due to a 400 error (output is below).
We have also tried accessing the api from our browsers and are seeing errors there as well (tried from multiple computers).
1 scenario ([32m1 passed[0m) 3 steps ([32m3 passed[0m) 0m22.387s [CucumberReportPublisher] Compiling Cucumber Html Reports ... [CucumberReportPublisher] Copying all json files from: C:\tests to reports directory: C:\...\builds\6\cucumber-html-reports [CucumberReportPublisher] Found 1 json files. [CucumberReportPublisher] 1. Found a json file: cucumber_report.json [CucumberReportPublisher] Generating HTML reports Hygieia: Failed Publishing Build Complete Data. Response Code: 400.  Hygieia Test Result Publisher - Looking for file pattern '*.json' in directory C:\...\workspace Hygieia Test Publisher: Processing file: C:\Users\oay495\.jenkins\jobs\ND Test Job GIT\workspace\cucumber_report.json Hygieia: Failed Publishing Test Data. Response Code: 400.  Finished: SUCCESS

Please make sure that you test connection after configuring the Jenkins global config. It should say success.

When testing the connection we get a failure, but no other information is provided (i.e. no reason for failure). How can we troubleshoot that?

Wrong api url was provided in the global configuration.

we had an issue with api connectvity i tried everything as on the hygieia document , the hygieia dashboard is up but no api connectivity.. even when i commit gulp serve i had an errors,

could any one help with the issue please..
can check the attcahments


permissions of access to projects for Deployers

Access to projects can be separated. Not all members should have access to all projects.

I think this is a step in the right direction but doing it this way, users have the same access-rights to all the projects they are part of.
Wouldn't it be better to have different access-right for different projects as in:

admin on project_a
deployer on project_b and project_c
historian on project_d


Update index.html

commit 2

nothing

@ishaputhige  thnx for contributing, make sure that you Star and follow so that you don't miss updates on this repo and also contribute this year for Hacktoberfest 2020.
Also, keep an eye on new issues on this project to win some extra swags.


Fix for validation error on driveLetter

DriveLetter needs to be forced into a String, otherwise the script will Error: Cannot validate argument on parameter 'driveLetter'.

Hi @reddobowen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Toggle for all layers in a group

Hello.
Is there a way of toggling all the layers in a layer group at once?
Thanks!
R.

@kingrollo this feature is not implemented itself. Maybe you can do some hack in your code detecting the changes in the layers. But it is not directly in the tree.
You can implement a pull request to include that :)
Unfortunately I do not have time now :'(
If you want to enable many layers at once, of course you can make a group layer. However, you shouldn't include both in the tree, the group and the layer alone. It has estrange behaviors: there can be contradictions (i.e. the group is disabled, but one element is enabled. Which one rules?)

Some time ago I added a new functionality to select all the layers in a group. Maybe it is useful for you, @kingrollo


WV-287 convert methods with warning to @static method TEAM REVIEW

Removed self parameter for functions with warning and converted to @staticmethod.
Also fixed a PEP 8: W391 blank line at end of file

👍


tmt run execute -vvvddd is not equal to tmt run -vvvddd execute

$ tmt run --last plans --default execute -vvvddd -f --interactive --how tmt tests --name .
/var/tmp/tmt/rhel-9

/plans/default
    Clean up workdir '/var/tmp/tmt/rhel-9/plans/default/execute'.
    Read file '/var/tmp/tmt/rhel-9/plans/default/execute/step.yaml'.
    Step data not found.
    Read file '/var/tmp/tmt/rhel-9/plans/default/execute/results.yaml'.
    Test results not found.
    Using the 'ExecuteInternal' plugin for the 'tmt' method.
    status: todo
    Write file '/var/tmp/tmt/rhel-9/plans/default/execute/step.yaml'.
    Write file '/var/tmp/tmt/rhel-9/plans/default/execute/results.yaml'.
    execute
    workdir: /var/tmp/tmt/rhel-9/plans/default/execute
        how: tmt
        order: 50
        exit-first: False
        Write file '/var/tmp/tmt/rhel-9/plans/default/execute/data/Sanity/stdin-stdout-stderr-not-a-terminal/metadata.yaml'.
            test: if stdin/stdout/stderr is not a terminal SELinux should not interfere with sudo
        Execute '/Sanity/stdin-stdout-stderr-not-a-terminal' as a 'beakerlib' test.
        Use workdir '/var/tmp/tmt/rhel-9/plans/default/discover/default-0/tests/Sanity/stdin-stdout-stderr-not-a-terminal'.
Warning: Identity file None not accessible: No such file or directory.

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Setup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

$ tmt run -vvvddd --last plans --default execute -f --interactive --how tmt tests --name .
...

/plans/default
...
    execute
    workdir: /var/tmp/tmt/rhel-9/plans/default/execute
        how: tmt
        order: 50
        exit-first: False
        Write file '/var/tmp/tmt/rhel-9/plans/default/execute/data/Sanity/stdin-stdout-stderr-not-a-terminal/metadata.yaml'.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-abort' to '/usr/local/bin/tmt-abort' on the guest.
        Create the master ssh connection: ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -iNone -S/run/user/1000/tmt/tmpxtyf8u9t -MNnT<EMAIL_ADDRESS>m
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-abort root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/tmt-abort
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-abort' to '/usr/local/bin/rstrnt-abort' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-abort root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rstrnt-abort
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-abort' to '/usr/local/bin/rhts-abort' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-abort root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rhts-abort
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-file-submit' to '/usr/local/bin/tmt-file-submit' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-file-submit root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/tmt-file-submit
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-file-submit' to '/usr/local/bin/rstrnt-report-log' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-file-submit root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rstrnt-report-log
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-file-submit' to '/usr/local/bin/rhts-submit-log' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-file-submit root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rhts-submit-log
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-file-submit' to '/usr/local/bin/rhts_submit_log' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-file-submit root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rhts_submit_log
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-reboot' to '/usr/local/bin/tmt-reboot' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-reboot root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/tmt-reboot
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-reboot' to '/usr/local/bin/rstrnt-reboot' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-reboot root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rstrnt-reboot
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-reboot' to '/usr/local/bin/rhts-reboot' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-reboot root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rhts-reboot
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-report-result' to '/usr/local/bin/tmt-report-result' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-report-result root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/tmt-report-result
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-report-result' to '/usr/local/bin/rstrnt-report-result' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-report-result root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rstrnt-report-result
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Copy '/usr/lib/python3.10/site-packages/tmt/steps/execute/scripts/tmt-report-result' to '/usr/local/bin/rhts-report-result' on the guest.
        Run command: rsync -p --chmod=755 -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /usr/lib/python3.10/site-packages
/tmt/steps/execute/scripts/tmt-report-result root@sopos-rhel9-brq.usersys.redhat.com:/usr/local/bin/rhts-report-result
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
        Push workdir to guest 'sopos-rhel9-brq.usersys.redhat.com'.
        Run command: rsync -R -r -z --links --safe-links --delete -e 'ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -i'"'"''"'"' -S/run/user/1000/tmt/tmpxtyf8u9t' /var/tmp/
tmt/rhel-9/plans/default root@sopos-rhel9-brq.usersys.redhat.com:/
        err: Warning: Identity file -S/run/user/1000/tmt/tmpxtyf8u9t not accessible: No such file or directory.
        err: Warning: Permanently added 'sopos-rhel9-brq.usersys.redhat.com' (ED25519) to the list of known hosts.
            test: if stdin/stdout/stderr is not a terminal SELinux should not interfere with sudo
        Execute '/Sanity/stdin-stdout-stderr-not-a-terminal' as a 'beakerlib' test.
        Use workdir '/var/tmp/tmt/rhel-9/plans/default/discover/default-0/tests/Sanity/stdin-stdout-stderr-not-a-terminal'.
        Execute command './runtest.sh' on guest 'sopos-rhel9-brq.usersys.redhat.com'.
        Run command: ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oIdentitiesOnly=yes -iNone -S/run/user/1000/tmt/tmpxtyf8u9t -t<EMAIL_ADDRESS>'export TMT_PLAN_DATA=
/var/tmp/tmt/rhel-9/plans/default/data TMT_TREE=/var/tmp/tmt/rhel-9/plans/default/tree TMT_TEST_DATA=/var/tmp/tmt/rhel-9/plans/default/execute/data/Sanity/stdin-stdout-stderr-not-a-terminal/data TMT_REBOOT_REQUEST=/var/tmp/tm
t/rhel-9/plans/default/execute/data/Sanity/stdin-stdout-stderr-not-a-terminal/data/reboot-request TMT_REBOOT_COUNT=0 REBOOTCOUNT=0 RSTRNT_REBOOTCOUNT=0 BEAKERLIB_DIR=/var/tmp/tmt/rhel-9/plans/default/execute/data/Sanity/stdin
-stdout-stderr-not-a-terminal BEAKERLIB_COMMAND_SUBMIT_LOG='"'"'bash /usr/local/bin/tmt-file-submit'"'"'; cd /var/tmp/tmt/rhel-9/plans/default/discover/default-0/tests/Sanity/stdin-stdout-stderr-not-a-terminal; ./runtest.sh'
Warning: Identity file None not accessible: No such file or directory.

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Setup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

https://github.com/teemtee/tmt/issues/509

@sopos, according to #509 and PR https://github.com/teemtee/tmt/pull/616,  looks tmt run execute -vvvddd and tmt run -vvvddd execute should behave differently as expected, can we close this issue?

I do not agree with closing. The verbosity should be still propagated from the most global to local.
My understanding is that the global setting should be inherited unless a local is specified.
There is one little catch: how to disregard the verbosity for one step? Implementing -s|--silent might be a solution.
The same applies to the debug.

Hi @sopos,

tmt run execute -vvvddd, -vvvddd is local?
tmt run -vvvddd execute, -vvvddd is global?
And tmt -dddvvv run execute, -vvvddd is also global, right?

I would say so. That's my take when @psss explained it to me some time ago - the sub-commands should inherit these options in a cascade.

That's my take when @psss explained it to me some time ago - the sub-commands should inherit these options in a cascade.

Hi @psss,  would you help to explain what the differences among tmt run execute -vvvddd, tmt run -vvvddd execute and tmt -dddvvv run execute?  From my understanding, tmt -dddvvv run execute means -dddvvv is global, but I don't understand the expected behaviours of both tmt run -vvvddd execute and tmt run execute -vvvddd, would you please help to clarify? thanks!

@idorax It means that subcommand should user verbosity/debug level from main command unless it is specified explicitly.

command
tmt
run
discover
execute

tmt -vvvddd run discover execute
v=3 d=3
v=3 d=3
v=3 d=3
v=3 d=3

tmt run -vvvddd  discover execute
v=0 d=0
v=3 d=3
v=3 d=3
v=3 d=3

tmt run  discover -vvvddd execute
v=0 d=0
v=0 d=0
v=3 d=3
v=0 d=0

So for 'execute' step all three tmt run execute -vvvddd, tmt run -vvvddd execute and tmt -dddvvv run execute has same verbosity/debug values. What would differ are other steps (if they were run)
The reported issue shows that even though execute -vvvddd was used, output is less verbose than it should be.

Very helpful table! What is the expected outcome of the following, decreasing verbosity? tmt -vvvddd run -vvdd discover -vd execute

not really, execute should inherit from run

Very helpful table! What is the expected outcome of the following, decreasing verbosity? tmt -vvvddd run -vvdd discover -vd execute

As @sopos wrote: "steps" are siblings (not parent-child) so verbosity of discover doesn't affect execute thus the verbosity of the execute step should be inherited from it's parent which is run.

I'm afraid there's no such a way. Therefore I suggested to implement -s|--silent to be able to achieve that. But The priority is really low as one usually wants to debug more rather than less.


Removing fucked: cd.. as fixed: cd ..

fixing bugs...

Personal opinion: I prefer your original name for the option, "add_fuckup", over "ifuckedup". "add_fuckup" makes it clearer what it's for.

You make a good point. If @nvbn agrees, I'll change that.

I've changed the get_command() function in main.py to programmatically fetch the previous command using .bash_history . This eliminates the need for the current alias, though it requires lines in .bashrc to keep .bash_history up to date.
I believe this should work, but I'm having trouble adjusting the appropriate tests.

Does it work with zsh and fish?


A question about qos level

Does the QoS of messages sent to consumers not need to be downgraded?

it indeed need downgrade to Min<pub, sub> which is described by mqtt-v3.1.1:
"The QoS of Payload Messages sent in response to a Subscription MUST be the minimum of the QoS of the originally published message and the maximum QoS granted by the Server"

it indeed need downgrade to Min<pub, sub> which is described by mqtt-v3.1.1: "The QoS of Payload Messages sent in response to a Subscription MUST be the minimum of the QoS of the originally published message and the maximum QoS granted by the Server"

Currently server support QoS0、QoS1、QoS2


NodeJS 4.* support

Hi, @Koenkk
I do not know why, but in the published package (since version 5.0.0) there is a dependence by debug == 4.0.1
https://github.com/Koenkk/zigbee-shepherd-converters/blob/master/npm-shrinkwrap.json#L215
But unfortunately, in this release debug has stopped supporting NodeJS 4.*
https://github.com/visionmedia/debug/releases/tag/4.0.0
This is very sad for my code, which still continues to support it.
Can we try to reduce the dependency package debug?

Yes no problem, which debug version do you require? Can you update package.json?

for example like this https://github.com/Koenkk/zigbee-shepherd/blob/master/package.json#L37
but here no 'debug' in package.json :)

thank you. all works


Server Can't get state

I have 0 scripts in globalscripts.
Using Skungee latest
Java 8
Linux (ubuntu)
I have made sure that I did not copy and paste the configs and set up the servers and skungees correctly. However, the error still occurs, when sometimes the server cannot check the state of another server, and in my server selectors, they appear offline, and players cannot join any of the servers on my network. This is a huge bug and must be fixed asap. :(
Simmilar to https://github.com/Skungee/Skungee/issues/51
but could not find this error in my console.

Oops, same error...
`[Skungee] Thread: Thread[Craft Scheduler Thread - 0,5,main]

[Skungee] End of Error.

[Skungee] [Skungee] Severe Error:
[Skungee] Socket couldn't be accepted.

[Skungee] Something went wrong within Skungee.
[Skungee] Please report this error to the developers of Skungee so we can fix this from happening in the future.

[Skungee] Report this at https://github.com/TheLimeGlass/Skungee/issues
[Skungee] You can also message one of the Skungee developers this error.

[Skungee] Stack trace:
[Skungee] java.net.SocketException: Too many open files (Accept failed)
[Skungee]     at java.net.PlainSocketImpl.socketAccept(Native Method)
[Skungee]     at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
[Skungee]     at java.net.ServerSocket.implAccept(ServerSocket.java:545)
[Skungee]     at java.net.ServerSocket.accept(ServerSocket.java:513)
[Skungee]     at me.limeglass.skungee.spigot.sockets.Reciever$1.run(Reciever.java:44)
[Skungee]     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[Skungee]     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[Skungee]     at java.lang.Thread.run(Thread.java:748)

[Skungee] Information:
[Skungee]   Skungee: 1.0.9
[Skungee]   Bukkit: 1.8.8-R0.1-SNAPSHOT
[Skungee]   Minecraft: v1_8_R3.
[Skungee]   Java: 1.8.0_191 (Java HotSpot(TM) 64-Bit Server VM 25.191-b12)
[Skungee]   OS: Linux amd64 3.13.0-165-generic

[Skungee] Running CraftBukkit: false

[Skungee] Thread: Thread[Craft Scheduler Thread - 0,5,main]

[Skungee] End of Error.

`

Same as #51

Duplicate https://github.com/Skungee/Skungee/issues/51


DeleteDocumentAsync throws NullReferenceException

Hello,
If I try to delete a nonexisting item like below
public static Document DeleteItem(Guid Id)
        {
                Uri uri = UriFactory.CreateDocumentUri(DatabaseId, CollectionId, Id.ToString());
                return client.DeleteDocumentAsync(uri).Result;
            }

I get a NullReferenceException. but the documentation here https://msdn.microsoft.com/en-us/library/microsoft.azure.documents.client.documentclient.deletedocumentasync.aspx states that I should have received DocumentClientException. am I missing something?

What is the value of DatabaseId, CollectionId and Id?
Could you please include the stack trace, or post a gist with a repro.


Add last checkouts to tabcompletion

Hi, thanks for this great project!
I think this small feature will make it even better ;-)
I really like git @{-N} syntax to checkout last used branches. I thought that if posh-git could suggest this last used branches first we would have nice user experience. You could just Tab and Shift+Tab and quickly choose the recent branch you need to work on again.
It would be very useful when you work on a lot of branches that have long names and you don't remember the name correctly (for example because it has Jira key at beginning, and who remembers that ;-)).
It looks that git source code does something very similar to what I have done here to get last checkout commits.

I ended up with implementing seconds options as it seams "good enough" for me (for example for my repo I work on now I have reflog with over 600 entries and without --max-count=10 I get more that 130 entries back, so having --max-count and --grep-reflog seems like good approach).
BTW. I broke and fixed unit test that I wrote before, but I actually don't know why previous quoting broke unit test... When I executed both quote variants in terminal they run fine... 🤔


GetListing blocking with no timeout

FTP OS: ?? (https://www.drivehq.com/)
FTP Server: ?? (https://www.drivehq.com/)
Computer OS: Ubuntu 16.04 with Docker (Docker image: microsoft/dotnet:2.0-runtime) on Azure VM
My docker service randomly blocks on a GetListing call. There is no timeout, a restart of the service is required.
I did not change any default settings.
This has happened randomly several times within the last weeks.
Any possibility that some timeouts are not working as expected under .NET Core?
Logs :
Randomly the service blocks after sending the MLSD command and never receives the response.
sync_1           | 2018-01-04T18:27:20.556490347Z 17129314 [1] INFO FtpSyncProcess (null) - Listing CSV files
sync_1           | 2018-01-04T18:27:20.556493147Z
sync_1           | 2018-01-04T18:27:20.556495647Z # GetListing("/Data/Source_1", Auto)
sync_1           | 2018-01-04T18:27:20.556498447Z Command:  TYPE I
sync_1           | 2018-01-04T18:27:20.714983101Z Response: 200 Type set to I
sync_1           | 2018-01-04T18:27:20.715014201Z
sync_1           | 2018-01-04T18:27:20.715017301Z # OpenPassiveDataStream(AutoPassive, "MLSD /Data/Source_1", 0)
sync_1           | 2018-01-04T18:27:20.715020301Z Command:  EPSV
sync_1           | 2018-01-04T18:27:20.873663654Z Response: 501 Syntax error: Command not understood.
sync_1           | 2018-01-04T18:27:20.873687254Z
sync_1           | 2018-01-04T18:27:20.873689854Z # OpenPassiveDataStream(PASV, "MLSD /Data/Source_1", 0)
sync_1           | 2018-01-04T18:27:20.873692754Z Command:  PASV
sync_1           | 2018-01-04T18:27:21.031643009Z Response: 227 Entering Passive Mode (66,220,9,50,35,112).
sync_1           | 2018-01-04T18:27:21.031667409Z Status:   Connecting to <IP_ADDRESS>:9072
sync_1           | 2018-01-04T18:27:21.189184163Z Command:  MLSD /Data/Source_1

Normally a Response is received.
sync_1           | 2018-01-05T10:15:44.040386500Z Response: 227 Entering Passive Mode (66,220,9,50,16,213).
sync_1           | 2018-01-05T10:15:44.040412000Z Status:   Connecting to <IP_ADDRESS>:4309
sync_1           | 2018-01-05T10:15:44.197930265Z Command:  MLSD /Data/Source_1
sync_1           | 2018-01-05T10:15:44.363922522Z Response: 150 Connection accepted

@WolfspiritM Any ETA on this? it sounds interesting..

@robinrodricks I just commited some more changes including a "rewrite" to async for the hash algorithms: https://github.com/WolfspiritM/FluentFTP/commit/cf18f232ca6e2b97d0dbac31482a53d46d3e7a8f
I think I will open a pull request but it would be great if someone could give it a try before merging cause I didn't get much time to test it.

Yes it would be great if you can open a PR. Also, could you pull master into your branch and update it please?

Hi @WolfspiritM, any progress on this? it sounds like an interesting and useful improvement...

Hi @robinrodricks I'm currently merging and fixing conflicts between master and my branch and noticed that master is not building. I've opened a review where that error got introduced. #372

Hi, could you fix that please? I'll accept your PR which will contain the
fix.
On Thu, Feb 21, 2019, 6:25 PM Adrian<EMAIL_ADDRESS>wrote:

Hi @robinrodricks https://github.com/robinrodricks I'm currently
merging and fixing conflicts between master and my branch and noticed that
master is not building. I've opened a review where that error got
introduced. #372 https://github.com/robinrodricks/FluentFTP/pull/372
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/robinrodricks/FluentFTP/issues/262#issuecomment-465989391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGe6Kov7kf9Vbs4NE9Q-WXiyEnUf1EUKks5vPpc0gaJpZM4RUR2f
.

Hi @WolfspiritM Let me know when you make some progress with this... If you can do the proper async implementation for even one set of methods (ie UploadFile) I can repeat the same technique for the remaining...

@robinrodricks I made a pull request. I'm not sure if that is the "proper" way to do it but as far as I could find it's the only way...ReadAsync just ignores the CancellationToken 😒

Fixed by WolfSpiritM in release 23. Grab the nuget package here: FluentFTP 23