Cannot query for time only variables

Driver version or jar name
latest (6.3.5)
SQL Server version
SQL Server 14.0.3006
Client operating system
Windows
Java/JVM version
Example: java version "1.8.x", Oracle VM
Table schema
create table dateandtime (id integer not null,
 my_date date,
 my_time time,
 my_timestamp datetime2
 constraint pk_esimple primary key (id))

Problem description
A prepared statement with select * from dateandtime where my_time = ? and pstmt.setTime(1,...) fails with com.microsoft.sqlserver.jdbc.SQLServerException: The data types time and datetime are incompatible in the equal to operator.
Expected behavior and actual behavior
Query with Time should work
Repro code
See https://github.com/Microsoft/mssql-jdbc/pull/558

Hello @rPraml,
Since earlier versions of the SQL Server do not support time datatype, the driver by default sends the time datatype as datetime. In order to send value as time, you need to change the connection property of sendTimeAsDatetime  to false.
You can also read further regarding how time values are sent on msdn docs. Thank you.

Hello @v-afrafi
applying sendTimeAsDatetime=false will solve this issue, but I'm wondering, if there are still more options that are required, so that the (latest) driver works correctly with the latest SQL-Server.
(I understand that there may be options to enable backward compatiblility to servers <= 2005, but 2005 is how old now?)
I also read the msdn docs:

In SQL Server JDBC Driver 3.0, sendTimeAsDatetime is true by default.
In a future release, the sendTimeAsDatetime connection property may be set to false by default.

I would really appreciate if the default value would be changed to false NOW. (or at least soon)
My expection is, if I develop a new application with the latest driver and sql-server version, that everything works out of the box and does not require to apply a bunch of compatibility-parameters to the connection strings, that fixes issues that were related to SQL-Server 2005 (which extended support ended at April 12, 2016)
I also updated the Pull Request with additional tests to show, that the behaviour is a bit inconsistent: If I use TVP & TIME - everything works fine (also with sendTimeAsDatetime=true)
cheers
Roland

Hi @rPraml . That is correct, the property was added for backward compatibility of the driver, however, I agree with your point in changing the default value.
Will discuss this with the team and will update you further on this. Thanks.

With later compat levels (>120) it looks like the driver sends DATETIME2 even when the column is not of that time. That causes problems in our case. Is there a property for that type as well (or could the driver actually inspect the target types (and not require binding column types or altering database)?

Hi @ecki, can you create a separate issue and describe/provide repro for the scenario that's currently not working for you?


Spike: Plugin design/feasibility

What problem does your feature solve?
provide a design for separation of core network data model from other app related data models in the rpc, like Soroban.
What would you like to see?
A document with 2 or 3 high level designs as alternatives, each of which explains how application domains like Soroban can be implemented as a plugin, external to rpc, Rpc acts as API gateway to plugin for separate API paths. Present the document to team for consensus.
What alternatives are there?

Go Plugins should be included in the analysis for plugin designs.


Missing drivers

I have a Brother printer that I would like to use with this docker container.
What do you think would be the best way to add the drivers that I need to this container?
Should I create a dockerfile with FROM and reference yours and then add the needed drivers.
Thanks,

You can either create your own image, adding your drivers to your existing container or mounting your specific drivers to a volume to a new container


Adds twice the icon on journal page titles

Info:

OS: linux
Logseq ver: 0.8.8
Plugin ver: 1.9.4
[x] ⚠ Do i have issue with DISABLED my custom.css?

Description:
when visiting back and forth journal pages, the journal icon is added twice on page title
Screenshots

which them are you using?

default logseq light theme

check latest 1.9.5

updated straight to 1.9.7 and the problem is fixed. thank you!


Modify GitHub data generator to work with GitHub app credentials

This makes the GitHub data generator compatible with GitHub app creds, removing the need for FPATs as described in this issue
It could be nice to have the API and data generator share the same GitHub client, but that would require breaking changes to the config to move the authentication settings outside of the API and data generators section.

We are going to need to test this heavily but otherwise looks good


Docs: create new conventions

Add a tutorial about creating a new Naming Convention

Already done: https://jawira.github.io/case-converter/dev.html#creating-new-convention


feat(SelectMenu): Add pagination async search

The SelectMenu component has no pagination when using asynchronous search.
I did this feature quickly i think it's essential :)

Before
After

The "Load More" is not keyboard-selectable.

I'm sorry I have to close this as it's way too complicated to rebase. But anyway I think it should be handled as mentioned in #1167.


[Infra] Description has more than 350 characters and cannot be forked

Describe the bug
The description has more than 350 characters and cannot be forked.
To Reproduce
Steps to reproduce the behavior:

Fork the repo
See error

Expected behavior
the repo Recognizers-Text should be able to be forked.

Thanks for the feedback. Description updated.

thanks


Fix closed coord's reference in latLngsToCoords

Hi :wink:
I've noticed that "closed coord" in latLngsToCoords method is just a reference to the first coords. Sometimes it can make troubles, for example when we return GeoJSON by toGeoJSON method and then we mutate the coordinates directly.
An example is available here:

live - https://marlo22.github.io/leaflet-coords/
repo - https://github.com/marlo22/leaflet-coords/blob/main/index.html

I get a GeoJSON object by toGeoJSON method, then iterate through each coord and reverse all of them.
As you can see (in the browser's console) in the example above first and last coords aren't inverted correctly (they're inverted two times and as a result they have initial value).

You are using turf.coordEach to iterate over coordinates, and I suppose that is exact problem.
Otherwise please point to specs where we can find that geojson coords must not be closed.


feat: New Module avm/res/machine-learning-services/workspace

Description
New Module avm/res/machine-learning-services/workspace, migrated from CARML.
Adding a new module

[x] A proposal has been submitted and approved.
[ ] I have included "Closes #{module_proposal_issue_number}" in the PR description.
[ ] I have run brm validate locally to verify the module files.
[x] I have run deployment tests locally to ensure the module is deployable.

Pipeline references

Pipeline

@AlexanderSehr
I removed the parameter sharedPrivateLinkResources from the resource properties if it's empty to enable idempotency.
https://github.com/Azure/bicep-registry-modules/pull/1055/commits/0fe14d1bcf83d9721038a490784f1d37ff0be9f8
https://github.com/Azure/bicep-registry-modules/pull/1055/commits/dd1a523695459d4931181acd2cf450868162eb03


test failure: sound test with multiple users disconnecting and reconnecting

in mre testbed, using synchronization test unity scene, if sound test is running, and instance B disconnects and reconnects, and instance A disconnects and reconnects, the server seems to freeze and various game objects get lost

I have reproduced this in the lights test as well, with the testbed/VSCode.. It wasn't consistently reproducing, but running multiple tests and being inside a test when it happens may have increased likelihood of failure.
Observed: when rejoining, the main actors (light, cubes, monkey head) are not synchronizing, text above the test is green instead of yellow (as if the test has succeeded), and pause/resume buttons don't work. It's almost as if the text has been told it has succeeded, and started to clean up, but didn't finish
It may have to do with animation syncing, but I'm not sure.  There were multiple weird messages in the log, which may be related (and which we ought want to clean up):
[ERROR] ClientSync client f9fecf32 received unexpected reply message! payload: object-spawned, replyToId: 1ed2fa50-c3b5-4ab6-880a-3503a98de338
[ERROR] ClientSync client f9fecf32 has no handler for payload set-animation-state!
[ERROR] ClientSync client f9fecf32 has no handler for payload set-animation-state!
[ERROR] ClientSync client f9fecf32 received unexpected reply message! payload: object-spawned, replyToId: 863cbcf9-ad85-4732-9eaf-2c633fcb14ef
[ERROR] ClientSync client f9fecf32 has no handler for payload set-animation-state!
[ERROR] ClientSync client f9fecf32 has no handler for payload set-animation-state!
[ERROR] ClientSync client f9fecf32 has no handler for payload set-animation-state!
[

Thanks Soren. This and any other sync issues are my priority next week.

Fixed by removal of queued destroy actor command on Unity side.


Add txfees query for multi denom tx fees

Description
To be able to support multi denom tx fees in Keplr, we need a query to be able to query the needed information without extra queries or computations on pools.
This PR includes adding a query that would include by what amount of txfees is needed when requested a denom that is not the base denom.

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #1164 (24e56f6) into main (ed7e7fc) will decrease coverage by 0.00%.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
- Coverage   20.00%   20.00%   -0.01%
==========================================
  Files         199      199
  Lines       25432    25453      +21
==========================================
+ Hits         5088     5092       +4
- Misses      19414    19428      +14
- Partials      930      933       +3

Impacted Files
Coverage Δ

x/txfees/keeper/grpc_query.go
19.23% <0.00%> (-14.11%)
:arrow_down:

x/txfees/keeper/feetokens.go
67.10% <45.45%> (-4.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7e7fc...24e56f6. Read the comment docs.


Split the implementation of putchar from printf

The implementation of putchar may be various in different devices.
We use an platform-independent function platform_putchar to replace
the previous codes in print.cpp. So we can implement our own putchar
function in src/hw/<specific_device>/port.c instead of placing all
implementation in print.cpp.
In case that we need to initialize the device before using the platform
specific putchar, we also provide platform_putc_init function.

I have added several changes in this new commit:

Add a new interface SerialPrint:
I add a new structure to specify the interface of serial printer.
If one wants to replace the implementation from virt to another
one, the things to do are to create an init function and a putchar
function, and to create a register_serial to assign those two
functions to platform_serial object.

Create an option in CMakeLists.txt to control whether to add
virt_serial.c into kernel sources:
We can replace virt implementation by setting VIRT_DEVICE to OFF
and add the specific sources to kernel sources.

Replace the constructor of init_threads with init_kernel_struct:
In case we will add more such interface intialization in, I use
a new function init_kernel_struct to run initializations like
init_threads and register_serial.

OK, I have updated the commit.

I forgot to check that the commit message was updated, so I've just edited to summarise the changes as merged.


[Feature] Recursive operation

Hi,
Context
sometimes I do math manually and cause some large code ... We have n and n+1 state ...
Would be less painfull to make it via function rather have 10 variables use only for calculation.
More Data
https://en.wikipedia.org/wiki/Sequence
you have many case of useful sequence. like Fibonacci https://fr.wikipedia.org/wiki/Suite_de_Fibonacci
Thats one of beauty of "Math" ...
Expected
const n1 = new BigNumber(0)

UseCase desired
n1
.suite(times)
.arguWith(3)
.arguWith(10)
.calc((n1, arg1, arg2)=>{
    // make operation here  or other things like updated UserInterface !
}
})

Signature on return
interface{
    results:BigNumber[],
    result:BigNumber
}

Seems like your example could be straightforwardly done using regular JavaScript code:
function calc(n1, arg1, arg2) {
  return [n1.toString(), arg1, arg2];
}

const seed = BigNumber(0);
const times = 10;
const results = [];

for (let i = 0 ; i < times ; i++) {
  const n1 = BigNumber(seed);
  results.push(calc(n1, 3, 10));
}

console.log(results);

Or, if you really want that API:
class Suite {
  constructor(data) {
    this.data = data;
    this.iterations = 0;
    this.args = [];
  }

  suite(iterations) {
    this.iterations = iterations;
    return this;
  }

  arguWith(arg) {
    this.args.push(arg);
    return this;
  }

  calc(fn) {
    let result;
    const results = [];
    for (let i = 0; i < this.iterations; i++) {
      result = fn(this.data, ...this.args);
      results.push(result)
    }
    return { results, result };
  }
}

// Usage:

import BigNumber from "bignumber.js";

const n1 = BigNumber(0);

const output = new Suite(n1)
  .suite(10)
  .arguWith(3)
  .arguWith(10)
  .calc((n1, arg1, arg2) => {
    return [n1.toString(), arg1, arg2];
  });

console.log("output", output);

Ok thanks 👍 .
I should do internally then :)


Refactored Router to make routeToRegExp a static method

I'd like to be able to use routeToRegExp in node.js without having to create an instance of the Backbone.Route in order to be able to share the route definitions with the Express router (exported as regex).
This PR is mostly just refactoring to support this.

Pro tip: the method is exported as Router.prototype.routeToRegExp. No need to create a new instance.
It may at one point have made sense to put it on the class instead of the instance, but for backwards-compatibility reasons we shouldn't move this around.


Mutate the thing being folded?

I see that it works, but is it really allowed, or should I be using a different function?
let will_be_doubled = O.some(21);
const tripled = O.fold(
    () => 1,
    (value: number) => {
        //mutating here!
        will_be_doubled = O.some(value * 2);
      	return value * 3;
    }
)(will_be_doubled);

Of course I could just separate it into two calls - i.e. tripled = O.fold(...) and then will_be_doubled = O.fold(...) but I'd rather keep the logic of both of those together.
Kinda like how pattern matching in Rust allows: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=1436593744a2fb97168c91cb48d41686

option.fold can be thought of as a pattern match that's specific to Option.
Mutation in any form is unsafe, so I suppose it's more of a question of what you're trying to accomplish.
Note that fold doesn't need to evaluate to just one value. You can combine multiple values in a single tuple value for convenience:
import * as O from "fp-ts/lib/Option";

let op = O.some(21);
const [doubled, tripled] = O.fold(
  () => [1, 1],
  (value: number) => {
    return [value * 2, value * 3];
  }
)(op);

console.log(doubled, tripled);


Purify tooltip content with v-clean-tooltip directive

Summary
This replaces the use of the v-tooltip directive with a custom v-clean-tooltip directive that uses the DOMPurify library to sanitize HTML input before rendering. html usage is discouraged by v-tooltip^1, and should only be used on trusted content. Similar to #8466, we sanitize existing usages across the board throughout Rancher Dashboard.
Occurred changes and/or fixed issues

Adds new v-clean-tooltip directive that sanitizes tooltip content based on rules defined in shell/plugins/clean-html-directive.js
Replaces all existing instances of v-tooltip with v-clean-tooltip

Technical notes summary

In essence, we are monkey patching the bind method that v-tooltip utilizes to configure the directive. By taking this approach, we can ensure that we are able to sanitize tooltip content without altering the original behavior of the v-tooltip directive.
Areas or cases that should be tested

We need to investigate tooltips throughout Rancher Dashboard and ensure that there are no notable regressions after this change has been applied.

@jordojordo can you please do a quick validate of Kubewarden?

@aalves08 can you review and validate extensions?

@mantis-toboggan-md that's a good catch, thank you. Ready for another review.


Interpreted Experiments don't change inExperiment() return value

I was trying out the return false feature of the Planout language with the below script, and when I call inExperiment() on an interpreted experiment, it seems to always return the default value that the experiment is set at (false in Planout.js interpreter, but in the python version, it seems to be true. Haven't tried the python one to see if it exhibits the same behavior though /cc @eytan)
This is a simple example of allowing only people with language = "en" to be "inExperiment".
if (language != "en") {
  return false
}

welcome_text = uniformChoice(choices=["Welcome!", "Hello There"], unit=userid);

I made a table of my tests here:  https://docs.google.com/spreadsheets/d/1r11sICfvNcILDYkUxVFX4Qq4_BkIYm6biWB9Jbpn7bw/edit#gid=0
I couldn't really find docs on inExperiment, so I'm not sure if I'm using it correctly. However, the "native javascript api" works as expected, when I use this code:
var EnglishOnly = function(args) {
  var experiment = new planout.Experiment(args);
  experiment.setup = function() { this.setSalt("Exp1"); }
  experiment.setup();
  experiment.assign = function(params, args) {
	if (args.language != "en") {
		return false;
	}
    params.set('welcome_text', new planout.Ops.Random.UniformChoice({ 'choices': ["Welcome!", "Hello there"], 'unit': args.userid}));
  };
  experiment.getParamNames = function() { return this.getDefaultParamNames(); }
  experiment.configureLogger = function() { return; }
  experiment.log = function(stuff) { return; }
  experiment.previouslyLogged = function() { return; }
  return experiment;
};

var inExperiment = new EnglishOnly({userid: 123, language: 'en'});
console.log(inExperiment.getParams()(;
console.log('inExperiment, should be true', inExperiment.inExperiment());
var notInExperiment = new EnglishOnly({userid: 123, language: 'es'});
console.log(notInExperiment.getParams());
console.log('notInExperiment, should be false', notInExperiment.inExperiment());

This, however, always returns false for an interpreted experiment:
var json = {
	"op": "seq",
	"seq": [
		{
			"op": "cond",
			"cond": [
				{
					"if": {
						"op": "not",
						"value": {
							"op": "equals",
							"left": {
								"op": "get",
								"var": "language"
							},
							"right": "en"
						}
					},
					"then": {
						"op": "seq",
						"seq": [
							{
								"op": "return",
								"value": false
							}
						]
					}
				}
			]
		},
		{
			"op": "set",
			"var": "welcome_text",
			"value": {
				"choices": {
					"op": "array",
					"values": [
						"Welcome!",
						"Hello There"
					]
				},
				"unit": {
					"op": "get",
					"var": "userid"
				},
				"op": "uniformChoice"
			}
		}
	]
};

var inExperiment = new planout.Interpreter(json, 'salt', {userid: 123, language: 'en'});
console.log(inExperiment.getParams());
console.log('inExperiment, should be true', inExperiment.inExperiment()); // returns false
var notInExperiment = new planout.Interpreter(json, 'salt', {userid: 123, language: 'es'});
console.log(notInExperiment.getParams());
console.log('notInExperiment, should be false', notInExperiment.inExperiment());

Is there a bug in Planout.js? Or should I be extending the interpreter and creating a custom _inExperiment setter?

Here are some tests that I've written (one fails to show this bug) that can be added to testInterpreter.js

  describe('setting _inExperiment', function() {
    var script = {
      "op": "seq",
      "seq": [
        {
          "op": "cond",
          "cond": [
            {
              "if": {
                "op": "not",
                "value": {
                  "op": "equals",
                  "left": {
                    "op": "get",
                    "var": "language"
                  },
                  "right": "en"
                }
              },
              "then": {
                "op": "seq",
                "seq": [
                  {
                    "op": "return",
                    "value": false
                  }
                ]
              }
            }
          ]
        },
        {
          "op": "set",
          "var": "welcome_text",
          "value": {
            "choices": {
              "op": "array",
              "values": [
                "Welcome!",
                "Hello There"
              ]
            },
            "unit": {
              "op": "get",
              "var": "userid"
            },
            "op": "uniformChoice"
          }
        }
      ]
    };

    it('should allow inExperiment() to return true when a script returns true', function() {
      var proc = new Interpreter(script, 'exp0', { userid: 0, language: 'en'});
      expect(proc.inExperiment()).toBeTruthy();
    });

    it('should allow inExperiment() to return false when a script returns false', function() {
      var proc = new Interpreter(script, 'exp0', { userid: 0, language: 'es'});
      expect(proc.inExperiment()).toBeFalsy();
    });

  });

definitely seems like a problem, hopefully will have some time this weekend to investigate this further

I just dug a little bit more, and it seems like creating two interpreted experiments one after another causes the second one to misbehave:
Both (second one doesnt behave as expected):
	var inExperiment = new planout.Interpreter(json, 'salt', {userid: 123, language: 'en'});
	console.log(inExperiment.getParams());
	console.log('inExperiment, should be true', inExperiment.inExperiment());
	var notInExperiment = new planout.Interpreter(json, 'salt2', {userid: 123, language: 'es'});
	console.log(notInExperiment.getParams());
	console.log('notInExperiment, should be false', notInExperiment.inExperiment());

{ welcome_text: 'Hello There' }
inExperiment, should be true false
{ welcome_text: 'Hello There' }
notInExperiment, should be false false

Second one alone properly takes you out of the experiment:
var notInExperiment = new planout.Interpreter(json, 'salt2', {userid: 123, language: 'es'});
	console.log(notInExperiment.getParams());
	console.log('notInExperiment, should be false', notInExperiment.inExperiment());

Output:
{}
notInExperiment, should be false false

Hi @burin , first of all thank you very much for filing this issue and providing us with a detailed explanation of the problem and an example to reproduce with. 💯  🙌
I dug into this issue and determined that this behavior is absolutely caused by a bug in the interpreted experiment class. I put together a fix & wrote up a description of the problem over in #50
Apologies on my part for the delayed response to this issue. Let me know if you run into any more issues with your interpreted experiments!


Fields param is not working while fetching multipe entities

Fields filter does not work if you try to fetch multiple entities.
Schema:
export const schema = {
  version: '0.0.1',
  indexes: {
    primary: { hash: 'pk', sort: 'sk' },
  },
  models: {
    Company: {
      pk: { type: String, value: 'company:${companyId}' },
      sk: { type: String, value: 'profile' },
      companyId: { type: String, uuid: 'ulid', required: true },
      companyTitle: { type: String, required: true },
    },
    CompanyEmployee: {
      pk: { type: String, value: 'company:${company.companyId}' },
      sk: { type: String, value: 'employee:${companyEmployeeId}' },
      companyEmployeeId: { type: String, uuid: 'ulid', required: true },
      company: {
        required: true,
        type: Object,
        schema: {
          companyId: { type: String, uuid: 'ulid', required: true },
        },
      },
      firstName: { type: String, required: true },
      lastName: { type: String, required: true },
      email: { type: String, required: true }
    },
  }
};

Fetch Query:
await table.fetch(
  ['Company', 'CompanyEmployee'],
  {
    pk: `company:${companyId}`,
  },
  {
    fields: ['companyId', 'companyEmployeeId']
  },
)

The above fetch query returns this error:
      {
        level: 'error',
        message: "Cannot read property 'attribute' of undefined",
        stack: "TypeError: Cannot read property 'attribute' of undefined\n" +
          '    at Expression.prepare (node_modules/dynamodb-onetable/dist/cjs/Expression.js:110:68)\n' +
          '    at new Expression (node_modules/dynamodb-onetable/dist/cjs/Expression.js:15:14)\n' +
          '    at Model.<anonymous> (node_modules/dynamodb-onetable/dist/cjs/Model.js:765:30)\n' +
          '    at Generator.next (<anonymous>)\n' +
          '    at node_modules/dynamodb-onetable/dist/cjs/Model.js:8:71\n' +
          '    at new Promise (<anonymous>)\n' +
          '    at Object.<anonymous>.__awaiter (node_modules/dynamodb-onetable/dist/cjs/Model.js:4:12)\n' +
          '    at Model.queryItems (node_modules/dynamodb-onetable/dist/cjs/Model.js:762:16)\n' +
          '    at Model.<anonymous> (node_modules/dynamodb-onetable/dist/cjs/Model.js:815:36)\n' +
          '    at Generator.next (<anonymous>)\n' +
          '    at node_modules/dynamodb-onetable/dist/cjs/Model.js:8:71\n' +
          '    at new Promise (<anonymous>)\n' +
          '    at Object.<anonymous>.__awaiter (node_modules/dynamodb-onetable/dist/cjs/Model.js:4:12)\n' +
          '    at Model.fetch (node_modules/dynamodb-onetable/dist/cjs/Model.js:798:16)\n' +
          '    at Table.<anonymous> (node_modules/dynamodb-onetable/dist/cjs/Table.js:660:51)\n' +
          '    at Generator.next (<anonymous>)'
      }

It seems like since both entities have different attributes and they are not present on all the collections, which results in undefined.

I think the issue is companyEmployeeId is not a valid field for Company.

@mobsense that is correct, both entities fields are different. Is it still possible to specify the fields?

Can you check with 2.2.1 which should not create an exception.


fix: add rimraf as dev dependency

:tada: This PR is included in version 2.0.1-beta.123 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Javascript algorithms and data structures: "You should use const to declare a shifted variable."

Describe the Issue
Hi, there are a few occasions on the introductory JavaScript course where you have to declare a variable.  The instructions are:

Directly below your numbers array, declare a shifted variable and assign it the result of calling .shift() on the numbers array. On the next line, log the shifted variable to the console.

but if you use let or var you get the error:

You should use const to declare a shifted variable.

Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-introductory-javascript-by-building-a-pyramid-generator/step-108
Your code
const numbers = [1, 2, 3];
let shifted = numbers.shift()
console.log(shifted)

const unshifted = numbers.unshift(5);
console.log(unshifted);

Expected behavior

// running tests
// tests completed
// console output
1
3
[ 5, 2, 3 ]

Screenshots
No response
System

Device: Laptop
OS: Debian 12
Browser: Firefox
Version: 115.13.0esr

Additional context
No response

May I take this please?

May I take this please?

Have you started? Or I can take care of it

May I take this please?

Have you started? Or I can take care of it

You can take care of other issues. Thanks

Hey @Alforoan, @Lewis-00
This issue has not been triaged yet, and a solution has not been agreed upon. Once the issue is open for contribution, you are welcome to create pull request. We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.
Issues labelled with help wanted or first timers only are open for contributions.
Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.

Straight from MDN:

The const declaration declares block-scoped local variables. The value of a constant can't be changed through reassignment using the assignment operator, but if a constant is an object, its properties can be added, updated, or removed.

They may not be reassignable, but they are still variables. Nothing to fix here, IMHO.


Run a single plugin

Is there a way to be able to run a single plugin as needed from command line?  For example, as I am working through the daily report and fixing issues, I would like to run the plugin that reported that issue again to see if the changes were successful without 1.) running the entire report again which takes a considerable amount of time or 2.) running the Select-Plugins tool and unchecking everything and then rechecking when I am done.
I am envisioning something simple, like :  vcheck.ps1 -selectplugin

Thanks for the suggestion.  It was a valid workaround.


Check if Firebase Messaging is supported.

This adds a check to ensure Firebase Messaging is supported in the current environment before instantiating it.  It fixes an issue with Safari throwing an Environment Not Supported exception which breaks app loading.
Adding this check allows our apps to actually load and work when using Safari.
Closes #38

Merged and published on NPM in v2.0.1.


INDEX file has empty lines

So I configured Hexo and NexT theme, and after
hexo g

All the generated index.html (like index.html, about/index.html and archives/2016/09/index.html) have strange empty lines inside, which is not expected.

Visit this site to see the content of my index.html file, with a lot of strange empty lines in it.

I don't know whether it's Hexo or NexT theme that is responsible for this.
Thanks if you could help me!

@mCapricornus ,
About this question ,  The anthor need time to solution.
Thanks for your issues and support.
https://neveryu.github.io/guestbook/

多谢答主！


[en] Fix broken link apiserver-eventratelimit.v1alpha1

Updated Reference page.
broken link : kube-apiserver event rate limit (v1alpha1)
updated link : kube-apiserver event rate limit (v1alpha1)
/language en

I think this should target 'main' branch first and then merge into 'dev-1.25' in batch.

@tengqm Thanks and I've re-targeted the base branch to main

looks good to me :)
Thanks ! @bconfiden2

/lgtm
/approve


Clearing out my path when I open Java files

Hey mhinz,
This plugin is simply awesome but I'm sad to say that for some reason it clears out my path variable and makes commands like 'gf' unusable.

Hi,
sorry for the late response, but I was away from computers for a while.
I can't think of any way this plugin could clear the 'path' option, though. I don't think the issue is related to this plugin directly. Please provide provide minimal steps for reproducing it.
(Please reopen, if you still think it's a problem in the plugin itself.)


FIXfix index writer with add_array_values with first empty array for a batch

Proposed changes
if first is empty array in coming batch data
fieldDataArray.values would not be initialized in ThreadState.init method,
then next array which to be inverted index will not be reset in Field because of this condition.
so we have to create a field into _doc to make thread init fieldDataArray
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Add sgmse implementation

You can see the egs/sgmse/README.md. This task is for the final project for AIR6063: Spoken Language Processing. My name is 李思睿（lisirui） 223040027.
✨ Description
Add sgmse implementation
👨💻 Changes Proposed

[x] add sgmse implementation

🧑🤝🧑 Who Can Review?
@HeCheng0625 @Adorable-Qin
✅ Checklist

[ ]  Code has been reviewed
[ ]  Code complies with the project's code standards and best practices
[ ]  Code has passed all tests
[ ]  Code does not affect the normal use of existing features
[ ]  Code has been commented properly
[ ]  Documentation has been updated (if applicable)
[ ]  Demo/checkpoint has been attached (if applicable)

@Adorable-Qin , Hi Zihao, could you help review this pr about speech enhancement?

You can see the egs/sgmse/README.md.This task is for the final project for AIR6063: Spoken Language Processing.My name is 李思睿（lisirui） 223040027.

Hi Sirui, Thank you so much for your helpful contribution! Could you provide us with some samples and also checkpoints that could showcase the effectiveness of your model?

You can see the egs/sgmse/README.md.This task is for the final project for AIR6063: Spoken Language Processing.My name is 李思睿（lisirui） 223040027.

Hi Sirui, Thank you so much for your helpful contribution! Could you provide us with some samples and also checkpoints that could showcase the effectiveness of your model?

我的模型的checkpoint和源文件的模型相比只训练了一半，但是本人缺少计算资源（源文件用了八张卡）我只用了一张，已经训了五天了，但是已经证明可以训练，详细sample可以看一下链接https://yiufjt4rn74.feishu.cn/docx/FOK8dfW9mo7AhyxJMDecQiFen7O?from=from_copylink

You can see the egs/sgmse/README.md.This task is for the final project for AIR6063: Spoken Language Processing.My name is 李思睿（lisirui） 223040027.

Hi Sirui, Thank you so much for your helpful contribution! Could you provide us with some samples and also checkpoints that could showcase the effectiveness of your model?

My model's checkpoint has only been trained halfway compared to the model in the source file, but I lack computing resources (the source file used eight cards). I only used one card and have been training for five days, but it has been proven to be trainable. For detailed samples, please refer to the link
https://yiufjt4rn74.feishu.cn/docx/FOK8dfW9mo7AhyxJMDecQiFen7O?from=from_copylink

You can see the egs/sgmse/README.md.This task is for the final project for AIR6063: Spoken Language Processing.My name is 李思睿（lisirui） 223040027.

Hi Sirui, Thank you so much for your helpful contribution! Could you provide us with some samples and also checkpoints that could showcase the effectiveness of your model?

My model's checkpoint has only been trained halfway compared to the model in the source file（it needs 400000steps), but I lack computing resources (the source file used eight cards). I only used one card and have been training 200000steps for five days, but it has been proven to be trainable. For detailed samples, please refer to the link https://yiufjt4rn74.feishu.cn/docx/FOK8dfW9mo7AhyxJMDecQiFen7O?from=from_copylink

Hi Sirui, the access right to the Feishu docs is not configured appropriately, could you provide one link with public access rights so we can check the details on the samples?

To help us manage the PRs, I have attached a checklist on the first message. Feel free to add more specific information, like examples and changes to help us understand your contribution. Thanks!

You can see the egs/sgmse/README.md.This task is for the final project for AIR6063: Spoken Language Processing.My name is 李思睿（lisirui） 223040027.

Hi Sirui, Thank you so much for your helpful contribution! Could you provide us with some samples and also checkpoints that could showcase the effectiveness of your model?

My model's checkpoint has only been trained halfway compared to the model in the source file（it needs 400000steps), but I lack computing resources (the source file used eight cards). I only used one card and have been training 200000steps for five days, but it has been proven to be trainable. For detailed samples, please refer to the link https://yiufjt4rn74.feishu.cn/docx/FOK8dfW9mo7AhyxJMDecQiFen7O?from=from_copylink

Hi Sirui, the access right to the Feishu docs is not configured appropriately, could you provide one link with public access rights so we can check the details on the samples?

I have opened the access right,you can open the link again.

Hi @lithr1 !
Thank you for your efforts to improve Amphion.
However, the samples you attached do not sound as good as expected from the paper you are trying to reproduce. As what you said that your model may lack training or you need to scale up the dataset used during training, I recommend not to merge this PR until you can get a reasonable result. Then we could consider merging.

学长您好，我是李思睿223040027，我看到amphion不予merge的理由是因为我给的sample不好（但是我训了五天了一个人也缺乏计算资源，但是也证实了我整个代码可以跑通并且效果也逐渐逼近论文效果），而且我的代码是完全按照amphion的格式去写的，我看其它人提交的都不太是（花了我太多太多时间），所以如果让我的分数跟他们一样甚至还低实在是不是很合理，所以能否将我的分数视为已经merge的了？
---- 回复的原邮件 ----
发件人 Zihao @.> 日期 2024年05月08日 17:35 收件人 @.> 抄送至<EMAIL_ADDRESS>主题 Re: [open-mmlab/Amphion] Add sgmse implementation (PR #177)
你通常不会收到来自 @.*** 的电子邮件。了解这一点为什么很重要
Hi @lithr1 !
Thank you for your efforts to improve Amphion.
However, the samples you attached do not sound as good as expected from the paper you are trying to reproduce. As what you said that your model may lack training or you need to scale up the dataset used during training, I recommend not to merge this PR until you can get a reasonable result. Then we could consider merging.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Fix/ub 1099 add request id to all logs

This change is

Hi @olgashtivelman,
Before the review please do:

Resolve the "conflicts" (you will see a button "resolve conflicts" that will help u to do it)
Please add to the PR a description that explain the PR and also link to the k8s PR that related to it as well.
Please do the same on the https://github.com/IBM/ubiquity-k8s/pull/191 as well.
Thanks

the k8s review link.
https://github.com/IBM/ubiquity-k8s/pull/191/
this is the change to add reqeuest_id and go routine id to the ubiquity + flex + provisioner logs so that we can follow a single request through out the product. (and also be able to identify which logs belong to which request in a multi-threaded server like ubiquity.)

Coverage decreased (-0.3%) to 51.534% when pulling 8529d03f437759425967e57aedd52d379be183b3 on fix/UB-1099_add_request_id_to_all_logs into a9fe98db89ece7dd4dd634e6e31bcdc3b77753fb on dev.

Review status: 0 of 8 files reviewed at latest revision, all discussions resolved, some commit checks failed.

remote/client.go, line 181 at r2 (raw file):

	detachRemoteURL := utils.FormatURL(s.storageApiURL, "volumes", detachRequest.Name, "detach")
	detachRequest.CredentialInfo = s.config.CredentialInfo
	response, err := utils.HttpExecute(s.httpClient, "PUT", detachRemoteURL, detachRequest, detachRequest.Context)

Olga, it doesn't make sense to add detachRequest,Context as another param for httpexecute, because the whole detachRequest is already passed, so it sending the same param twice.
this note relevant for all the changes here.

utils/http_utils.go, line 96 at r2 (raw file):

func HttpExecute(httpClient *http.Client, requestType string, requestURL string, rawPayload interface{}, request_context resources.RequestContext) (*http.Response, error) {
	logger := logs.GetLogger()
	payload, err := json.MarshalIndent(rawPayload, "", " ")

This is strange
So you also marshal the request inside the post as well?
so we actually passing twice the same data. Lets consider how to tune it.

utils/http_utils.go, line 108 at r2 (raw file):

	//setting the headers for the request
	request.Header.Set("request-id", request_context.Id)

ok
here I would make it more generic, since request_context may additional keys in the future, then its better to add headers by on each key in the struct.  So it will be ready framework and not specifically for this ID.

utils/logs/go_logging_logger.go, line 54 at r2 (raw file):

	b := make([]byte, 64)
	b = b[:

what is this red dots? not sure

utils/logs/go_logging_logger.go, line 64 at r2 (raw file):

var GoIdToRequestIdMap = new(sync.Map)

func (l *goLoggingLogger) getGoIdAndContextString() string {

rename function name "getContextStringFromGoId"   so it will make more sense.

utils/logs/go_logging_logger.go, line 68 at r2 (raw file):

	context, exists := GoIdToRequestIdMap.Load(go_id)
	if !exists {
		context = resources.RequestContext{Id: "XXXXX"}

change it to "NA" (not applicable) instead of XXXX     or "-".
please mentioned it in the design wiki page.

utils/logs/go_logging_logger.go, line 72 at r2 (raw file):

		context = context.(resources.RequestContext)
	}
	return fmt.Sprintf("%d:%s", go_id, context.(resources.RequestContext).Id)

print first the requestConextID and then the go_id.
its more important and its like father of the goid, so it should be before.
as mentioned in the design wiki page.

utils/logs/go_logging_logger.go, line 105 at r2 (raw file):

	switch level {
	case DEBUG:
		l.logger.Debug(fmt.Sprintf("[%s] %s", goid_context_string, traceEnter), args)

you can prepare the string (fmt.Sprintf("[%s] %s", goid_context_string, traceEnter))  before th switch and just use it on every function below,
it will simplify the code here.

web_server/storage_api_handler.go, line 41 at r2 (raw file):

func getContextFromRequest(req *http.Request) resources.RequestContext {
	return resources.RequestContext{Id: req.Header.Get("request-id")}

I would do here also something generic that will  go on all the expected keys and not only request-id.
BTW consider what happened if its not there, you should consider to return empty string.

Comments from Reviewable

Review status: 0 of 8 files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

remote/client.go, line 181 at r2 (raw file):
Previously, shay-berman wrote…
Olga, it doesn't make sense to add detachRequest,Context as another param for httpexecute, because the whole detachRequest is already passed, so it sending the same param twice.
this note relevant for all the changes here.

yes you are right. meant to change it.

utils/http_utils.go, line 96 at r2 (raw file):
Previously, shay-berman wrote…
This is strange
So you also marshal the request inside the post as well?
so we actually passing twice the same data. Lets consider how to tune it.

this is not a new change from this review.
not sure why we are parsing twice? where?

utils/http_utils.go, line 108 at r2 (raw file):
Previously, shay-berman wrote…
ok
here I would make it more generic, since request_context may additional keys in the future, then its better to add headers by on each key in the struct.  So it will be ready framework and not specifically for this ID.

I think that per your comment above i will remove the context from the header and only use it in the request as it is sent there anyways.

utils/logs/go_logging_logger.go, line 54 at r2 (raw file):
Previously, shay-berman wrote…
what is this red dots? not sure

what red dots? (I don't see any dots in the reiview..)

utils/logs/go_logging_logger.go, line 64 at r2 (raw file):
Previously, shay-berman wrote…
rename function name "getContextStringFromGoId"   so it will make more sense.

Done.

utils/logs/go_logging_logger.go, line 68 at r2 (raw file):
Previously, shay-berman wrote…
change it to "NA" (not applicable) instead of XXXX     or "-".
please mentioned it in the design wiki page.

Done.

utils/logs/go_logging_logger.go, line 72 at r2 (raw file):
Previously, shay-berman wrote…
print first the requestConextID and then the go_id.
its more important and its like father of the goid, so it should be before.
as mentioned in the design wiki page.

in the design wiki page the go-id is first...
But I can change it in both.

utils/logs/go_logging_logger.go, line 105 at r2 (raw file):
Previously, shay-berman wrote…
you can prepare the string (fmt.Sprintf("[%s] %s", goid_context_string, traceEnter))  before th switch and just use it on every function below,
it will simplify the code here.

Done.

web_server/storage_api_handler.go, line 41 at r2 (raw file):
Previously, shay-berman wrote…
I would do here also something generic that will  go on all the expected keys and not only request-id.
BTW consider what happened if its not there, you should consider to return empty string.

as mentioned above I am adding a new commit with the change of not sending the request id also in the header as you mentioned we send it twice. so this is no  longer relevant.

Comments from Reviewable

Review status: 0 of 8 files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

remote/client.go, line 181 at r2 (raw file):
Previously, olgashtivelman wrote…
yes you are right. meant to change it.

Done.

utils/http_utils.go, line 108 at r2 (raw file):
Previously, olgashtivelman wrote…
I think that per your comment above i will remove the context from the header and only use it in the request as it is sent there anyways.

Done.

web_server/storage_api_handler.go, line 41 at r2 (raw file):
Previously, olgashtivelman wrote…
as mentioned above I am adding a new commit with the change of not sending the request id also in the header as you mentioned we send it twice. so this is no  longer relevant.

Done.

Comments from Reviewable

shay-berman
please review the code changes and the comments.

Review status: 0 of 9 files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

Comments from Reviewable

@shay-berman
please review the code changes and the comments.

Review status: 0 of 9 files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

Comments from Reviewable

Review status: 0 of 9 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

remote/client.go, line 181 at r2 (raw file):
Previously, olgashtivelman wrote…
Done.

but i don't see the fix?  i still see it twice (commit and put to the branch)

utils/http_utils.go, line 98 at r4 (raw file):

	payload, err := json.MarshalIndent(rawPayload, "", " ")

	logger.Info("Sending HTTPExecute request")

why its info?   i think it should be debug or maybe its not needed at all here.   if u want to keep it in debug then please move it few lines below to be close to the real newrequest function.

utils/logs/go_logging_logger.go, line 72 at r2 (raw file):
Previously, olgashtivelman wrote…
in the design wiki page the go-id is first...
But I can change it in both.

great
its better to see the reqID first

Comments from Reviewable

Review status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @shay-berman and @olgashtivelman)

utils/http_utils.go, line 98 at r4 (raw file):
Previously, shay-berman wrote…
why its info?   i think it should be debug or maybe its not needed at all here.   if u want to keep it in debug then please move it few lines below to be close to the real newrequest function.

I guess its here by mistake when I was trying to test something. i removed it.

remote/client.go, line 181 at r2 (raw file):
Previously, shay-berman wrote…
but i don't see the fix?  i still see it twice (commit and put to the branch)

now you can see it

Comments from Reviewable

Reviewed 1 of 8 files at r1, 3 of 6 files at r2, 1 of 3 files at r4, 4 of 4 files at r5.
Review status: all files reviewed, 1 unresolved discussion (waiting on @shay-berman)

utils/http_utils.go, line 98 at r4 (raw file):
Previously, olgashtivelman wrote…
I guess its here by mistake when I was trying to test something. i removed it.

great, this is why we do code review :-)  and you review mine

Comments from Reviewable


Ontask email action out function

This is a enhancement which allows users to send students the link to the surveys via email(instead of copy&paste link to lecture notes).

How far are you from sharing your proof-of-concept code Haomin?

Sending the URL to all students is something that can be already done with current tools. Do we want to expand OnTaks to do it as well? It won't be difficult given that we do have the infrastructure to configure and send emails, but I am just wondering if this something essential.

I'm tallying there'd be less mouse clicks for a user to be able to send a live survey hyperlink to learners via email within OnTask plus the added value of not having to use a different system to send these hyperlinks. I'd expect this to improve UX.

Sorry, I am not following this last comment. Sending a personalised email (albeit without personalisation) with the URL would be a few more clicks, agree, but the functionality to send the URL to the students would need an email template anyway (I don't see the platform having a default email communicating a URL), and this would be almost identical to creating the personalised text action.


When in 'flat' mode "clickoutFiresChange" fires even though it is set to false

When "flat" mode is set and "showButtons" is set to false, clickoutFiresChange is set to true, even though it is explicitely set to false during init.
Proposed change on line 242
Existing code:
clickoutFiresChange = !opts.showButtons || opts.clickoutFiresChange,
New code:
clickoutFiresChange = (!opts.showButtons && opts.clickoutFiresChange) ? true : opts.clickoutFiresChange,

Testing this on flat mode, I think "clickout" doesn't have much meaning in a flat picker since it is always opened.
In fact, I think I would always want flat pickers to fire change on clickout..  Otherwise clicking the document will cause the value to revert (which is a problem right now on http://bgrins.github.io/spectrum/#modes-flat if you change the value and then click anywhere else on the document).
So to me it looks like this should actually be:
 clickoutFiresChange = flat || !opts.showButtons || opts.clickoutFiresChange

Is there a use case when you want a clickout to revert your changes in a flat mode picker?

yeah, I have another object that allows for  background to be uploaded, and so when clicked it fires a picker click... which is not needed since a different element was clicked

Are you listening to the change event or the move event for the flat picker?  I think what we actually need to do for flat pickers is to not be binding to the clickout event at all since it doesn't really have any meaning.
In that case we could trigger a change on move instead, but then it confuses things with the 'choose' and 'cancel' buttons.  But those buttons don't really make that much sense either, so maybe those should be off by default for flat mode.

well, I have the palette and the picker open, so I am listening to both... change for the palette and dragstop for the picker

So if flat mode, we could:

Trigger a change event when a move happens
Set showButtons to false by default
Don't bind to the clickout event at all

I think that would solve the issue and make more sense for flat pickers than what currently happens.


Rename global_allocator module and change scope of global_allocator feature

The global_allocator module has been renamed to allocator, and is now available regardless of whether the global_allocator feature is enabled. The global_allocator feature now only controls whether allocator::Allocator is set as Rust's global allocator.
Checklist

[ ] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[ ] Update the changelog (if necessary)

@phip1611 re https://github.com/rust-osdev/uefi-rs/issues/563#issuecomment-1478664036, does this change meet your needs?

Love it, nice!


Add nystudio107/craft-seomatic - 2020-04-28-1

@fabpot The validator is saying Invalid branch name "v3"., but that’s the actual branch name (https://github.com/nystudio107/craft-seomatic/tree/v3) so not sure what to do about that.

Should be 3.x IIRC (in my phone right now)

Should be 3.x IIRC (in my phone right now)

Thanks, that’s passing locally. Not sure I understand why 3.x is acceptable but not v3, when v3 is the actual Git branch name. Would be good if the docs could clarify that a bit more.


UX Improvement: need a new behavior similar to the current workbench.editor.revealIfOpen behavior

When workbench.editor.revealIfOpen is set to true -- the behavior of the editor when 'opening' a link to a file is to reveal the file in its existing pane if its open already.
  Without the setting enabled I end up having waaay too many tabs open because basically every file becomes open in every pane over time.
A version of this feature that moved the editor for the file from a pane it's currently open in to the target pane that requested the file to be opened would be very nice ...   Would help me avoid having too many tabs due to duplicate files open across panes -- and would provide a better navigation experience as the editors would move to the place expected by the navigation operation ...

/duplicate https://github.com/microsoft/vscode/issues/102824


Emit from client

Is there any way to emit events to the socket io backend ?

You have access to the socket and thus socket.emit directly from the hook :)


wrap() never returns, causing timeout

This is a Bug Report
Description

What went wrong? Lambda handler using wrap() does not return, causing function to time out
What did you expect should have happened? handler should have returned
What was the config (if any) you used? None
What stacktrace or error message did you see? Request timed out

Similar or dependent issues:

N/A

Additional Data

Which powertool package are you using?: lambda-powertools-pattern-basic
Which version are you using?: 1.27.0
Middy engine version you're using: 1.4.0
Operating System: AWS Lambda / NodeJS
Stack Trace: N/A
Provider Error messages: N/A

Note that this only seems to happen in Lambdas using mysql2/promise

It's probably because you have something that is still up which doesn't end the event loop (e.g. database connection)
try to use https://www.npmjs.com/package/@middy/do-not-wait-for-empty-event-loop and set it to something like this:
const doNotWaitForEmptyEventLoop = require('@middy/do-not-wait-for-empty-event-loop');

exports.handler = wrap(serverless(app)).use(doNotWaitForEmptyEventLoop({
  runOnBefore: true,
  runOnAfter: true,
  runOnError: true,
}));

It's probably because you have something that is still up which doesn't end the event loop (e.g. database connection)
try to use https://www.npmjs.com/package/@middy/do-not-wait-for-empty-event-loop and set it to something like this:
const doNotWaitForEmptyEventLoop = require('@middy/do-not-wait-for-empty-event-loop');

exports.handler = wrap(serverless(app)).use(doNotWaitForEmptyEventLoop({
  runOnBefore: true,
  runOnAfter: true,
  runOnError: true,
}));

Thanks, I'll try that!
On Mon, Jan 11, 2021 at 10:09 PM Shawn Ma<EMAIL_ADDRESS>wrote:

It's probably because you have something that is still up which doesn't
end the event loop (e.g. database connection)
try to use
https://www.npmjs.com/package/@middy/do-not-wait-for-empty-event-loop
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.npmjs.com_package_-40middy_do-2Dnot-2Dwait-2Dfor-2Dempty-2Devent-2Dloop&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=lfPv-6yBDkcHt5izF4aF42U7hyOXDtg5LQN0tccc7nk&s=jEYWb7cv330LP3mB51Dj4Hool4pVZ0nMWnenVU3iPIw&e=
and set it to something like this:
const doNotWaitForEmptyEventLoop = require('@middy/do-not-wait-for-empty-event-loop');
exports.handler = wrap(serverless(app)).use(doNotWaitForEmptyEventLoop({
runOnBefore: true,
runOnAfter: true,
runOnError: true,
}));
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_getndazn_dazn-2Dlambda-2Dpowertools_issues_239-23issuecomment-2D758384035&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=lfPv-6yBDkcHt5izF4aF42U7hyOXDtg5LQN0tccc7nk&s=MH4mDvY2Mu1cGkHvLOW2i7POuAXdRYwVD9g63y_u5y8&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMOAKPVESUXJXSN7YQSMPK3SZPDOLANCNFSM4T2NBAFA&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=lfPv-6yBDkcHt5izF4aF42U7hyOXDtg5LQN0tccc7nk&s=J_3D0WoVH4l-U_8_o8henxWPyrUhaqxT6q6whPZNAmQ&e=
.

Thanks, I'll try that!
On Mon, Jan 11, 2021 at 10:09 PM Shawn Ma<EMAIL_ADDRESS>wrote:

It's probably because you have something that is still up which doesn't
end the event loop (e.g. database connection)
try to use
https://www.npmjs.com/package/@middy/do-not-wait-for-empty-event-loop
https://urldefense.proofpoint.com/v2/url?u=https-3A__www.npmjs.com_package_-40middy_do-2Dnot-2Dwait-2Dfor-2Dempty-2Devent-2Dloop&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=lfPv-6yBDkcHt5izF4aF42U7hyOXDtg5LQN0tccc7nk&s=jEYWb7cv330LP3mB51Dj4Hool4pVZ0nMWnenVU3iPIw&e=
and set it to something like this:
const doNotWaitForEmptyEventLoop = require('@middy/do-not-wait-for-empty-event-loop');
exports.handler = wrap(serverless(app)).use(doNotWaitForEmptyEventLoop({
runOnBefore: true,
runOnAfter: true,
runOnError: true,
}));
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_getndazn_dazn-2Dlambda-2Dpowertools_issues_239-23issuecomment-2D758384035&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=lfPv-6yBDkcHt5izF4aF42U7hyOXDtg5LQN0tccc7nk&s=MH4mDvY2Mu1cGkHvLOW2i7POuAXdRYwVD9g63y_u5y8&e=,
or unsubscribe
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AMOAKPVESUXJXSN7YQSMPK3SZPDOLANCNFSM4T2NBAFA&d=DwMCaQ&c=jGUuvAdBXp_VqQ6t0yah2g&r=TTXL98RIPQNjLdDSgeT8-yL45AVQu-9EyYWqGxjCNjqPZing27cmWboo1qWURfVf&m=lfPv-6yBDkcHt5izF4aF42U7hyOXDtg5LQN0tccc7nk&s=J_3D0WoVH4l-U_8_o8henxWPyrUhaqxT6q6whPZNAmQ&e=
.


Select component defaultValue prop doesn't work

Description
While passing the defaultValue prop to Select.Root doesn't work as expected and also result in a type error.
Property 'defaultValue' does not exist on type 'IntrinsicAttributes & SelectRootProps<{ value: string; label: string; }>'.

Link to Reproduction (or Detailed Explanation)
https://codesandbox.io/p/sandbox/solid-counter-forked-6prcnt?file=%2Findex.tsx%3A36%2C1
Steps to Reproduce
Use any example of Select component (Solid JS) given in the doc and try to use the defaultValue prop as suggested in the document.
Ark UI Version
2.2.0
Framework

[ ] React
[X] Solid
[ ] Vue

Browser
Google Chrome
Additional Information
No response

@shirshendubhowmick
Thanks for taking your time to report this issue. There was an issue with our scripts that parses the type docs.
Please note that Solid.js don't require a defaultValue. You simply can use the <Select value={["foo"]} />


Can't Open Vulkan

Godot version
Godot Engine v4.0.2.stable.mono.official.7a0977ce2
System information
PopOS (ubuntu22.04)
Issue description
(base) yingshaoxo@pop-os:~/CS/Godot/godot-4-3d-third-person-controller$ Godot_v4.0.2-stable_mono_linux.x86_64  --video-driver opengl

Godot Engine v4.0.2.stable.mono.official.7a0977ce2 - https://godotengine.org
xkbcommon: ERROR: failed to add default include path /home/yingshaoxo/anaconda3/share/X11/xkb
Vulkan API 1.3.224 - Forward+ - Using Vulkan Device #2: NVIDIA - NVIDIA GeForce RTX 3070 Laptop GPU
ERROR: Condition "err" is true. Returning: ERR_CANT_CREATE
   at: _initialize_queues (drivers/vulkan/vulkan_context.cpp:1561)
ERROR: Condition "err != OK" is true. Returning: ERR_CANT_CREATE
   at: _window_create (drivers/vulkan/vulkan_context.cpp:1689)
ERROR: Can't create a Vulkan window
   at: _create_window (platform/linuxbsd/x11/display_server_x11.cpp:5145)
/usr/bin/zenity: symbol lookup error: /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37: undefined symbol: gst_codec_utils_caps_get_mime_codec
ERROR: Unable to create DisplayServer, all display drivers failed.
   at: setup2 (main/main.cpp:2018)
ERROR: Pages in use exist at exit in PagedAllocator: N7Variant5Pools11BucketLargeE
   at: ~PagedAllocator (./core/templates/paged_allocator.h:140)
ERROR: Pages in use exist at exit in PagedAllocator: N7Variant5Pools12BucketMediumE
   at: ~PagedAllocator (./core/templates/paged_allocator.h:140)
ERROR: Pages in use exist at exit in PagedAllocator: N7Variant5Pools11BucketSmallE
   at: ~PagedAllocator (./core/templates/paged_allocator.h:140)
ERROR: BUG: Unreferenced static string to 0: interface_added
   at: unref (core/string/string_name.cpp:131)

Steps to reproduce
Godot_v4.0.2-stable_mono_linux.x86_64 --video-driver GLES2

Minimal reproduction project
https://github.com/gdquest-demos/godot-4-3d-third-person-controller

--video-driver GLES2

This CLI argument is ignored in Godot 4 and later.

Then how can I force Godot to use opengl?
On Thu, Jul 27, 2023, 6:37 PM Hugo Locurcio @.***>
wrote:

--video-driver GLES2
This CLI argument is ignored in Godot 4 and later.
—
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/79951#issuecomment-1653354108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEDE7LI3QDLGLAZT7KN7ZKDXSJAE3ANCNFSM6AAAAAA2Z34Z4U
.
You are receiving this because you authored the thread.Message ID:
@.***>

Then how can I force Godot to use opengl?

As I described in my edited comment, use --rendering-method gl_compatibility to force the use of OpenGL.


ci(deps): update terraform-ibm-modules/common-pipeline-assets action to v1.8.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/common-pipeline-assets
action
minor
v1.7.3 -> v1.8.0

Release Notes

terraform-ibm-modules/common-pipeline-assets
v1.8.0
Compare Source
Features

Remove NO_CONTAINER and add TF_VAR_ibmcloud_api_key_ext env vars (#410) (67555c2)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added _filter to graphql search params

{
  PatientList(_filter: "name eq simpson") {
    resourceType
    id
    name {
      given
      family
    }
  }
}

coverage: 94.271%. remained the same when pulling 0903b8499a03847a3e9c346679d7fe758035c51e on cody-graphql-filter-param into 2a1f5b0c24cdb91d16cc9b3385f07f878eee4b8a on main.


Update README.md

Fixed sample code. sensors3 can't be accessed as a dict key in the current version.

@arturandre Thank you!


[PROD] Different search results with and without accented letters (Türkiye and Côte d'Ivoire)

Issue
If I search for Turkiye (instead of Türkiye) or Cote d'Ivoire (instead of Côte d'Ivoire) because I might not know how to type those accented letters with my keyboard, the search doesn't return correct results.
Steps to reproduce
Type Turkiye or Cote d'Ivoire in the main search box or in the countries dropdown and make note of the different search results.

Expected behaviour
The search should return identical results regardless of the accents.
Impact
There are many search results for country names with and without accents, so users might not realise they're missing part of the search results with their search string. The impact is further exacerbated by legacy country names (Turkey, Turkiye, and Türkiye all return different results).
Severity
TBD.
Is there a workaround?
None identified.

With respect to country names and search results (not specific to accents) since the move to prefixing emergency pages with the country iso code now one can't find emergencies for that country - e.g. if I search for "Japan Earthquake" I only get old emergencies and not JPN: Noto Peninsula Earthquake 01-2024.  Worth looking at this at the same time as country variants (though it's separate to accents)

Came here to also report this issue - I'm trying to access Turkiye results in the Country search under All Emergencies:


Fix VssPhysicalLib to respect EOF offsets.

Solution proposed by @kornman00 in https://github.com/trevorr/vss2git/issues/47 for the problem 'Attempted read of {0} bytes with only {1} bytes remaining in buffer'.

Seems safe enough. Have you verified that it fixes the issue for you?

Yes, it solved the problem in my case.

When you change a comment of a checkin, VSS does not change the original comment record, but appends a new comment record to the physical file, updating the EOF offset. Therefore the proposed fix let Vss2Git fail to analyse any physical file with a such edited comment, because the iterator skips all the records between the one owning the new comment and the corresponding comment record, while building the changeset list.


new set of tags and keywords

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual.
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Regression tests have to complete successfully.
[ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test.
[ ] 6. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.

Fixed indentation issues and enforced camelback

merge to branch, changes are good.

@mandd FYI, I have merged your PR.


Fix for rhcos_versions.sh script.

The -u "unique" param for the sort command will eliminate the duplicated lines in the rhcos_version_map file, hence reducing both the file size and the frequency of the automatic PRs created to update that file.
~I've also uploaded the result file rhcos_version_map from running the script locally with this fix.~

Finally decided not to include any changes in the file rhcos_version_map and let the workflow to fix it (reduce the duplicated lines) next time it runs. I had to force-push because I did a couple of wrong "git merge main" until I got it right.


Testing of Index Implementer

...work in progress.

...shoot, only the last 3 commits are relevant to this PR, should have merged #17 first...


Fix duplicate route name

Issue number: Closes #924
Summary of the change:
Fixes duplicate route name

Thanks @ChristopherCarranza !


No SDK Method for generating refresh tokens

This isn't a critical issue, but it's one I've found a handful of times dating back at least a year online, so it seems to be something people want. I'm currently implementing the eSignature REST API into a webapp I'm working on. The main functionality involves generating and emailing invoices from job information created and stored on the app. I've been searching for about a week now for a way to use the node SDK to generate a refresh token, however there is only a method to generate the original authorization token. I can use axios to make a post request on my frontend to generate a new token when my endpoints hit a 400 error, however I'd prefer to keep authorization and refresh tokens away from my frontend for security purposes (especially since its every 8 hours). If you could just add a slightly modified generateAccessToken() method to the API which specifies a grant type of refresh_token as opposed to authorization_token I'd greatly appreciate it.

+1, So much to improve. so much to be done, they seems not actively working on this.

@Christofuu
Thanks for flagging this issue and sharing your workaround. We have noted the recurring nature of this problem and its importance for users like yourself.
Regarding the request for a modified generateAccessToken() method to handle refresh tokens securely, We are committed to addressing this in the near future. In the meantime, please continue with your workaround. Your patience and collaboration are appreciated as we work towards a solution.

+1, So much to improve. so much to be done, they seems not actively working on this.

We acknowledge the need for improvements and are actively addressing all raised concerns. Rest assured, we're working on implementing solutions to enhance the functionality and security of the SDK. Your feedback is invaluable, and we're committed to delivering improvements moving forward. Thank you for your patience and understanding.


Enhance UI of the FAQ section

Description
I would like to change the UI of the FAQ section of the website by adding some cool effects .
So,please assign this issue to me under gssoc'23.
Screenshots

Additional information
No response

Make it look like as in https://task-management-snowy-kappa.vercel.app/
use green themed color on hover.

use rubik font

Make it look like as in https://task-management-snowy-kappa.vercel.app/ use green themed color on hover.

okie


Vulkan crash on steam deck

Validation

[X] Game has been updated to the latest RE4HD release (v1.1: https://www.re4hd.com/?p=9552)
[X] Data has been validated with SFV (a guide to using QuickSFV is available at that link, use that with this 1.1 SFV: BIO4-HDProject1.1-SFV.zip)

Describe your issue here (drag+drop ZIP to attach it)
using the vulkan backend causes a crash on steam deck
vulkan as a renderer does work based on other things ive used
im not using steamos i am using windows
kinda disapointing cause steam deck could use the performance boost since it struggles to maintain 60fps with hd project

The Steam Deck already has the exact same thing we use to translate DX9 to Vulkan: DXVK. If you disable our Vulkan renderer in this case, the Steam Deck's one will be used automatically. Still, it shouldn't be crashing, but sadly I don't have a Deck myself. Can you upload a crash log here?

does that still apply if your using windows on the deck and not steamos? anyway heres the log
dinput8.log

That doesn't apply if you're using Windows, no. That said, you really shouldn't be using Windows on the Deck.
Anyway, please upload a CrashDump.

if the problem is crashing/loading related you can try creating a CrashDumps folder inside the Bin32 directory (next to bio4.exe/steam_api.dll/etc), then the next time game crashes hopefully some info about it will be written in there, please include that with any reports you make!

That doesn't apply if you're using Windows, no. That said, you really shouldn't be using Windows on the Deck.
Anyway, please upload a CrashDump.

if the problem is crashing/loading related you can try creating a CrashDumps folder inside the Bin32 directory (next to bio4.exe/steam_api.dll/etc), then the next time game crashes hopefully some info about it will be written in there, please include that with any reports you make!

there was too many drawbacks to using steam os for most of the stuff i do. ive vastly preffered my windows experience. so far re4 is the only game ive found with worse performance on windows. anyway yea didnt realize u needed
bio4.exe.20230323150228.zip
to extra things to get a crash dump


Consider supporting System.Transactions

Progress is being made on adding the ambient transaction functionality of System.Transactions in the .NET Core on the 1.2 timeframe, e.g. https://github.com/dotnet/corefx/issues/2949 is already fixed for 1.2 and https://github.com/dotnet/corefx/issues/12534, which will result in SqlClient supporting it in .NET Core.  In the meanwhile other ADO.NET providers that work with .NET Framework already have support.
I am creating this issue so that we can make an explicit decision for our SQLite provider. As far as I can see, there are several options we can choose from:

Nothing: ambient transactions will be ignored by our ADO.NET provider.
Throw: we could implement only enough to throw in the presence of ambient transactions so that customers are more aware that they are not supported.
Add support (not sure how complex it will be)

Marking for re-triage. Given the decision on #319, should this be closed as "wait for feedback" too?


Input type different & Memory usage during training

Thanks for this work!
When I train the model with python [EXP_PATH] --amp_backend native -b 8 --gpus 8,
[EXP_PATH] is bevdepth/exps/nuscenes/mv/bev_depth_lss_r50_256x704_128x128_20e_cbgs_2key_da_ema.py
I got the following error:
Input type (torch.cuda.HalfTensor) and weight type (torch.cuda.FloatTensor) should be the same
  File "BEVDepth/bevdepth/layers/backbones/base_lss_fpn.py", line 310, in forward
    x = self.reduce_conv(x)
  File "BEVDepth/bevdepth/layers/backbones/base_lss_fpn.py", line 402, in _forward_voxel_net
    self.depth_aggregation_net(img_feat_with_depth).view(
  File "BEVDepth/bevdepth/layers/backbones/base_lss_fpn.py", line 533, in _forward_single_sweep
    img_feat_with_depth = self._forward_voxel_net(img_feat_with_depth)
  File "BEVDepth/bevdepth/layers/backbones/base_lss_fpn.py", line 593, in forward
    key_frame_res = self._forward_single_sweep(
  File "BEVDepth/bevdepth/models/base_bev_depth.py", line 56, in forward
    x, depth_pred = self.backbone(x,
  File "BEVDepth/bevdepth/exps/nuscenes/base_exp.py", line 239, in forward
    return self.model(sweep_imgs, mats)
  File "BEVDepth/bevdepth/exps/nuscenes/base_exp.py", line 249, in training_step
    preds, depth_preds = self(sweep_imgs, mats)
  File "BEVDepth/bevdepth/exps/base_cli.py", line 78, in run_cli
    trainer.fit(model)
  File "BEVDepth/bevdepth/exps/nuscenes/mv/bev_depth_lss_r50_256x704_128x128_20e_cbgs_2key_da_ema.py", line 29, in <module>
    run_cli(BEVDepthLightningModel,
RuntimeError: Input type (torch.cuda.HalfTensor) and weight type (torch.cuda.FloatTensor) should be the same

So I try to add the code:
@autocast(False)
def forward(self, x):
    x = x.to(torch.float32)  # Add
    x = self.reduce_conv(x)
    x = self.conv(x) + x
    x = self.out_conv(x)
    x = x.to(torch.float16)  # Add
    return x

The above error disappeared, but the memory usage is very high. When I set batch_size=1, 22G memory is still used.

is this correct？

Met similar issue, I worked around it by using https://discuss.pytorch.org/t/runtimeerror-input-type-torch-cuda-floattensor-and-weight-type-torch-halftensor-should-be-the-same/104312/5
i.e. adding autocast like
from  torch.cuda.amp import autocast
with autocast():
    outputs = model.forward(tensor)

Met similar issue, I worked around it by using https://discuss.pytorch.org/t/runtimeerror-input-type-torch-cuda-floattensor-and-weight-type-torch-halftensor-should-be-the-same/104312/5
i.e. adding autocast like
from  torch.cuda.amp import autocast
with autocast():
    outputs = model.forward(tensor)

may I ask what is your GPU memory use? Is it still 22G when setting batch_size=1?


Fixing 32bit msvc

This fixes some compilation errors and integral conversion warnings for 32bit MSVC

Just tried this now. The fixes seem to work! :)
Thanks for the prompt fix @hkaiser


[Feature Request]: Add support for non-OpenAI embeddings in RagEvaluatorPack

Feature Description
Hi,
I'm trying to use RagEvaluatorPack to evaluate a pipeline that does NOT use any OpenAI models. Despite being able to set the judge_llm when instantiating RagEvaluatorPack:
rag_evaluator = RagEvaluatorPack(
    judge_llm=Settings.llm,
    query_engine=query_engine,  # built with the same source Documents as the rag_dataset
    rag_dataset=small_rag_eval_dataset,
    show_progress=True,

The process fails when trying to run the following block from https://github.com/run-llama/llama_index/blob/main/llama-index-packs/llama-index-packs-rag-evaluator/llama_index/packs/rag_evaluator/base.py (lines 106-108):
   judges["semantic_similarity"] = SemanticSimilarityEvaluator(
            embed_model=OpenAIEmbedding()
        )

This forces people to use OpenAI instead of being able to use another embedding model (BAAI's for instance). As I don't have an OpenAI account (we are trying to stick to open source), the process fails with:
APIConnectionError: Connection error.

Thanks!
Reason
The current implementation of RagEvaluatorPack forces people to use OpenAI instead of being able to use another embedding model (BAAI's for instance). As I don't have an OpenAI account (we are trying to stick to open source), the process fails with:
APIConnectionError: Connection error.

Value of Feature
People would be able to use RagEvaluatorPack without being OpenAI's hostage :). This is important for many regulated organizations unable to use OpenAI or other cloud-based LM services.

Yea it would be pretty easy to update the interface
But, you do know it's very easy to download the llamapack and edit the code? (They are kind of meant to be used that way)

Thanks @logan-markewich. For sure, however, I thought it'd be natural to assume that any llama-index-related packages would look at the default settings before hard-wiring models, for instance, if I do
# LLamaIndex embedding model
Settings.embed_model = HuggingFaceEmbedding(
    model_name="BAAI/bge-base-en-v1.5",
)

And llamapacks look for those general settings, then they would behave consistently with the rest of the llama-index code. I think (although I might be wrong).
Thanks again!

LlamaPacks are general examples of using llama-index, contributed by the community. The expectations for customizing or using models is a little relaxed compared to the things maintained in the core package


feat(core): add no-commit inputs

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5b415be) 96.79% compared to head (8821101) 96.45%.

Files
Patch %
Lines

src/main.js
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   96.79%   96.45%   -0.35%
==========================================
  Files           9        9
  Lines         281      282       +1
==========================================
  Hits          272      272
- Misses          9       10       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


installation guide

I'm sorry but do we have to close the agency lab repo to the original https://github.com/VRSEN/agency-swarm? because when I just clone it and run I get this: (base) saua@192 agency-swarm-lab % python agency.py
python: can't open file '/Users/saua/Documents/AI/SELF OPERATING/agency-swarm-lab/agency.py': [Errno 2] No such file or directory
(base) saua@192 agency-swarm-lab %
I only have WebDevCrafters. so if I run the agency.py form there I get this:
(base) saua@192 agency-swarm-lab % cd WebDevCrafters
(base) saua@192 WebDevCrafters % python agency.py
Traceback (most recent call last):
File "/Users/saua/Documents/AI/SELF OPERATING/agency-swarm-lab/WebDevCrafters/agency.py", line 1, in
from agency_swarm import Agency, set_openai_key
ModuleNotFoundError: No module named 'agency_swarm'
(base) saua@192 WebDevCrafters %
"Choose an Agency: Decide which agency you would like to run or explore. Each agency is contained in its own folder within the repository.
Install Agency-Specific Requirements: Navigate into the directory of the agency you've chosen. Each agency may have its own requirements.txt file, which specifies additional dependencies necessary for that particular agency."
When install the requirements there're no agency to run or explore..

Hey @newjxmaster, make sure you have the correct environment activated, where you installed the requirements. Alternatively you can run pip install agency-swarm. Then run the agency.py file from WebDevCrafters


Implements Transport using tokio::io::Framed

This is my suggestion for introducing and demoing tokio::io::Framed transport.
Unfortunately the code is designed right now so that only one of the two transport implementations can be commented it - so we will not notice if the other one breaks. The alternatives for this would be to

make the choice of which version of transport to use a compile time option. I think that would be nice, but I do not know how to do that and lack time to research it right now.
use an interface to make the code using transport agnostic of which one is used - I did not like this, because it made this codewalk more complex and hides Tokio's concept under a layer of concepts of this tutorial. I think the comment solution is easier to understand.

What do you think?

Looks good, maybe instead of calling it transport version 1 & 2, call it something like "raw" and "managed" (i'm not in love w/ those names, but just throwing some ideas out)

Rebased on master and rename version1 to LowLevelLineTransport and version2 to FramedLineTransport.

Thanks! Merged.


conda for infertrade

Added conda version of infertrade. I hope you will like it sir!

Thanks @SangamYadav1 .
Can we:

convert guide to use MarkDown, so that users can see the guide within GitHub?
give the Jupyter notebook file an informative name

@bi-kash - could you take a look and see if you have any suggestions?

Aside from the suggestions from @ta-oliver, here are the changes I suggest:

Making the instructions more formal and specific to infertrade instead of emphasizing the benefits of conda.
Adding a link to an external guide of how to install conda before step 1.
Shorten the example data csv, since we probably don't need 13,000 lines for a demo.
Give a short explanation of what a jupyter notebook is for anyone using one for the first time.

[ ] Making the instructions more formal and specific to InferTrade instead of emphasizing the benefits of conda.

@SangamYadav1 - the current wording looks like it is similar to a generic guide. If the wording is from an existing guide we need to link to that guide, not copy the wording as we do not have copyright permissions to just take wording.

[ ] Adding a link to an external guide of how to install Conda before step 1.
[ ] Link to a short explanation of what a jupyter notebook is for anyone using one for the first time.

@SangamYadav1 - adding links for generic parts, as @ctaptyem suggests, would be good.

@ta-oliver @ctaptyem I like the concept, I will make the changes straight away as you guys suggested.

@ta-oliver  @ctaptyem I like the idea.

@bi-kash - any thoughts or suggestions for the Conda installation documentation?

My suggestion:

It is better to use a markdown file for instructions. GitHub has issues with the rendering notebook files. Always asks for reloading.
It looks like plain text. Take advantage of markdown tools to write rich formatted content.  Refer to markdown files within this repo.

This is superceded by #148 , @SangamYadav1 ? Typically we amend PRs rather than creating new feature branches to keep the review discussion (and reviewers) associated.


Adjust path search and document requests dependency. Fixes #18 Fixes #8

I have added documentation for installing pip and requests for just the user running Ghidra so to contain where Python 2 packages are installed. This closes an issue and should prevent anyone else opening a new issue about ImportError: No module named requests. I have tested this on macOS and Ubuntu 22.04 LTS. I also adjusted the os name search process for Linux. The test used was returning False on this Ubuntu.

@utkonos Thanks for the PR!


make resolveOffset return an indicator when all messages of the batch are resolved

Is your feature request related to a problem? Please describe.
When processing a batch you can use resolveOffset to mark a message as done. I would like to know if the batch that contains the message has all its offsets resolved. Currently, I wrap the resolveOffset and reduce a set of offset and return the remaining offset count. I also know that one could use uncommitedOffsets, but since this does a lot of copying around and also returns uncommittedOffsets of all partitions, it is neither performant to be checked on each resolveOffset nor a nice DX.
Describe the solution you'd like
resolveOffset returns either a boolean that is true when all messages of the current batch are resolved, or it returns a number with how many messages are not yet resolved in the batch.

Could you elaborate a bit on your use-case? Perhaps showing some pseudo-code of what you want to achieve? I don't think I really understand what the problem you're trying to solve is.
Resolving an offset is literally just setting a single number value in a map. Essentially resolvedOffsets[partition] = offset. So it's just a pointer to where in the partition you are. There's no data structure that holds information about each individual offset, like:
resolvedOffsets = {
  [partition]: {
    '1': true,
    '2': true,
    '3': false,
    '4': false
  }
}

So finding out how many messages are remaining in a batch would be something like: batch.messages.filter(({ offset }) => offset > lastResolvedOffset).length. Of course if you're processing the messages in order, it's just the length of the batch minus the current message index:
for (let i = 0; i < batch.messages.length; i++) {
  const message = batch.messages[i];
  await processMessage(message);
  const remaining = batch.messages.length - i;
}

from your description i got the impression that resolveOffset can not deal with out of order processing, because if it happens to be that the last message in a batch was completely processed first then resolveOffset will basically mark the whole batch as resolved and there committable on the next auto commit cycle?

Yes, that's exactly right. Or if you first resolve offset 100 and then later resolve offset 50, you'd end up reprocessing any offset >50.
You can take a look at this method, which is how the eachMessage interface works, which is essentially just a straightforward implementation of eachBatch under the hood: https://github.com/tulios/kafkajs/blob/f8366f30d965214701393b31e1cc6eddae1fe9db/src/consumer/runner.js#L142-L172
In this case we're processing the offsets in order, which is why we can resolve each message offset after processing it. If you're processing several messages in the same batch in parallel, you'll need to keep track of the resolved offsets yourself and only actually resolve an offset if all the previous offsets have also been resolved.
Or you can wait until you've processed all messages in the batch and resolve batch.lastOffset() instead, but then if something goes wrong in the middle of a batch, you'll have to reprocess the whole batch instead of just the unresolved ones.

thank you for the explanations. i think using the example from above to track individual message processing and then completing the batch should be enough when using the eachBatchAutoResolve option. reprocessing a batch or parts of a batch is no big deal in our case, we just need "at least once" behavior.
i wonder if this is something that would be a candidate for an extension of kafkajs. if not just close this issue


Provide finer-grained (per-developer/per-deployment//dynamic) terraform cloud workspaces/access.

Describe the issue
Currently, we provide terraform workspaces on a per-environment and per-"service" basis/matrix.  Based on feedback from our initial tenants, we need to be considering how to provide finer grained/dynamic workspaces that would better support rapid-iteration, agile development practices.
Which Sprint Priority is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonomously with 'Sprint'.

The 'Milestone' overview/description (created in ZenHub) should clearly list Sprint Priorities/Goals. This section should indicate which of the priorities/goals this issue is related to.
Additional context
This could eventually be integrated into the command line tool suite being developed by NRM
Definition of done
A working mechanism for technical tenant team members (developers) to provision/access on-demand Terraform Cloud workspace(s)

No longer relevant


Multi Tenancy support with over lapping Subnet IP

Multi tenancy will be supported with docker 1.10 onwards
The changes contains the following:

Enabled overlapping subnets across tenants
tenant isolation
Policy support
Supported in routed and bridged vxlan , bridge vlan modes only.
Docker 1.10+ is required

LGTM


Use a fixed resource and instrumentation library

The existing code derived from SD has no batching by resource, which at the very least offers a form of compression for sending metric data. In fact the existing otlp/queue_manager.go does the opposite, prevents batching when a timeseries has the same hash in a single request. This is not a requirement for OTLP and can result in small request sizes.
Removing the shard[].seen map will improve performance by allowing larger requests.

Note that the existing batching support after removing shard.seen is still not fully tested, e.g., there is not test for the maximum number of timeseries per request, an existing configuration.

Since we have removed the targets cache, all resources are now identical. We should be able to re-use the resource and instrumentation library with a very small fix.

Resource and InstrumentationLibrary sections of the protocol are constant over the lifetime of the sidecar, but they are not treated as such today. It will be a minor optimization to re-use these two objects.


[SMALLFIX] Fix Mesos when root tarball directory is "alluxio"

Previously we assumed that Alluxio distribution tarballs have a root directory named alluxio-version. This change still works for that case, but now also works when the root directory is named just alluxio.

LGTM

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12102/
Test PASSed.


[Feature][test] Add MicroBench module to make it easier for developers to write JMH TEST

close #3995

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Please add the skywalking licenses, I think these code from skywaling

Done.

Please add the skywalking licenses, I think these code from skywaling↳

Done.
NOTICE file you have not updated

Please add the skywalking licenses, I think these code from skywaling↳

Done.
NOTICE file you have not updated

Done. PTAL thanks.


Implement AsyncClient::RewriteObject()

Still planning to do these, but maybe 2023-Q1 now.

Scheduled for 2023-Q3.

Still working on this.


added tools/cppcheck2github.py

added a custom tool to reformat cppcheck errors as github messages:
https://github.com/Algo-ryth-mix/cppcheck-github
Formats errors like this

instead of this

Note that this also changes the return type to always be 0, if wanted we can change this back in the script

what's the cppcheck syntax error?

that is the template thing we discovered a few days ago.
I've raised the issue here https://sourceforge.net/p/cppcheck/discussion/general/thread/91801de693/ but I am yet to receive an answer


How pass props to route?

Hi!
Can you provide example, where i can pass props, not query, to component?

Just use 'vue-router’ props option to provide mapping between query and the props you might need.


Deprecation Notice

To make it easier for the newcomers:
This library is deprecated since the release of the androidx library for the BiometricPrompt API.
If you want to combine the BiometricPrompt API with a symmetric key,
then you can have a look at this fully functional Kotlin implementation:
https://github.com/fkirc/secure-zip-notes/

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!


Added a blackhat 2016 presentation about

Added a blackhat 2016 presentation which describes a practical approach to hacking cars along with describing a toolset called YACHT also known as CANToolz.
Although I couldn't manage to find the talk, the presentation is informative enough to get a newcomer on the right foot.

Looks great! Thanks. :)


Typos in README & Wiki Troubleshooting Guide

In README file, section "Troubleshooting Guide", it says:

If you are experimenting issues with the new Manager, please check this guide

Maybe not "experimenting issues", but "experiencing issues"?
2. In Wiki Troubleshooting guide that it leads to, same typo at the end:

If after reading everything above you're still experimenting issues, you can open an issue here or on the X-Hax Discord Server through the Troubleshooting section.

Same typo as in README.

Good catch, should be fixed now


Move 'task' shortcut to a new TaskAccessor trait.

Add the 'task' convenience method to BaseTask (by way of use TaskAccessor), so that Tasks as well as commands (RoboFiles) will be able to use the $this->task('Foo', $a, $b); shortcut.
Makes the code easier to read, too.

Yep, that's good move.


update_python_requirements.bsh downloads to /tmp

There is no cleanup from downloads to /tmp, and this is overall messy.
This works create in a one use container, but any other use is not as clean.
I propose creating a new mktemp directory, using that, and removing it on exit, using a trap for exit, and Ctrl c breaks,

Fixed in #16


feat: Add URI to test application

Add a test mode where the user can paste URIs directly.
I was pretty conflicted on whether or not to add the the ability to load audio files directly via setting properties.
but in general I think developers being able to set the properties is a very useful feature to have. and is a good idea to somewhat showcase it.
as for the act of loading dedicated audio files with videos, this in general is a very useful feature to have.

Best of luck with exams!


Answers

[ ] Create with linked into Events
[ ] Find All
[ ] Injection Script from AppScript to trigger fetch into Create Answers Endpoint.


move rest-utils to ak configdefs

tagged ya'll since thats what github told me to do, and it will affect all of us.

@ewencp if people are 👍 here i will make prs for all downstream repos and then we can merge all at once 😰

@norwood any thoughts about just adding a MAP type on Apache ConfigDef?

yeah, i'd be down to move it. but i'd rather not gate this pr on moving something to AK 👀


Select id  native props

Hi,
In Input.tsx, you can give an 'id 'to the input by passing id in "nativeInputProps".
In Select.tsx you can't give an 'id' to the select even by putting it in "nativeSelectProps".
I suggest to look what is done in Input.tsx and do the same in Select.tsx
I can give more informations if you need.

Hey @Thorekt,
Thanks for reporting, it's fixed.
A new version is being deployed.

Hi,
The bug seems still here, i saw  your modification but it's override by the "selectId" comming after
`
    const id = useAnalyticsId({
        "defaultIdPrefix": "fr-select-group",
        "explicitlyProvidedId": id_props ?? nativeSelectProps.id
    });

    const selectId = `select-${useId()}`;

`
the select element use "selectId" :
`
<select
{...nativeSelectProps}
className={cx(fr.cx("fr-select"), nativeSelectProps.className)}
id={selectId}
aria-describedby={stateDescriptionId}
disabled={disabled}

{children}

`
I think the id in "nativeSelectProps" is overide by the id using "selectId"
Thanx for your reactivity


Remove Screen Space Quads at Poles

Remove code to fill the poles with screen space quads. We never execute this code. The terrain reaches the poles and the imagery is stretched.
/CC @kring @pjcozzi

Technically we still use that code if the terrain provider uses the Web Mercator projection, which is possible.  But admittedly I haven't tried actually doing that in a really long time and I wouldn't be surprised if it doesn't work anymore.

Should we keep this and add tests?

Ah OK. Do you know of any terrain provider that uses WebMercatorTilingScheme so I can test it? After doing a search that I thought was unrelated, I landed in this code and spotted something that looked broken.

ArcGisImageServerTerrainProvider can be configured to use Web Mercator, but that thing is totally broken.  We should really just get rid of it, and possibly replace it with a terrain provider that talks to the BIL support in newer versions of ArcGIS (World Wind uses BIL, which I think is why Esri added it).
EllipsoidTerrainProvider can also be configured to use Web Mercator.  I'd probably try that it test this code out.
scene.globe.terrainProvider = new EllipsoidTerrainProvider({
    tilingScheme: new WebMercatorTilingScheme()
});

But honestly, if it's broken (which is likely) and no one has complained, let's just get rid of it entirely for now.

We will need this if we add BIL, right?  Perhaps it is fine to remove this, and submit an issue for that including a reference to this issue if we need the code.

We will need this if we add BIL, right?

Maybe, I'm not sure.  For dynamic layers, ArcGIS can reproject to whatever we ask.  If a MapServer has a fused cache (AKA thing that makes it actually fast enough to use for terrain!), it's going to be one particular projection and that projection might be Web Mercator.  But probably not, because World Wind wouldn't want Web Mercator either.  Not worrying about it until we need it seems wise.

Sounds good.


enable code coverage

Related to https://github.com/knative-sandbox/.github/pull/20
/cc @mattmoor

Cool! I'll adjust ignore patterns in a new PR.
/assign @slinkydeveloper

I wonder if we can enable this for java too :thinking:

I see they support it in the languages, it requires a maven plugin https://docs.codecov.io/docs/supported-languages

We can do it ourselves later.

/lgtm
/approve