Lindalu fix build errors

Docs Build status updates of commit 385e5ad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/how-to-get-worksheet-information-from-a-package.md
:bulb:Suggestion

Details

docs/structure-of-a-presentationml-document.md
:bulb:Suggestion

Details

docs/how-to-get-worksheet-information-from-a-package.md

Line 41, Column 277: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.packaging.spreadsheetdocument.open?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 59, Column 80: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.sheets?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 59, Column 216: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.sheet?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 60, Column 21: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.workbook?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 61, Column 12: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.worksheet?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 73, Column 91: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.sheetdata?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 73, Column 280: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.row?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 73, Column 448: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.cell?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 73, Column 607: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.spreadsheet.cellvalue?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 114, Column 70: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.openxmlelement?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 114, Column 214: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.openxmlattribute?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.

docs/structure-of-a-presentationml-document.md

Line 28, Column 188: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 32, Column 78: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.presentation?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 33, Column 68: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.presentationproperties?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 34, Column 79: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.slidemaster?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 35, Column 79: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.slidelayout?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 36, Column 87: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.drawing.theme?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 37, Column 85: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.slide?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 38, Column 79: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.notesmaster?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 39, Column 80: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.notesslide?view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 40, Column 77: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.handoutmaster?redirectedfrom=MSDN&view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 41, Column 79: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.commentlist?redirectedfrom=MSDN&view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.
Line 42, Column 73: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/documentformat.openxml.presentation.commentauthorlist?redirectedfrom=MSDN&view=openxml-2.8.1&preserve-view=true' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add more elements for themes and create a new dark theme

Next step: manage custom themes :)

For color links, I didn't find a proper way to manage it yet. Any idea?

For color links I didn't realize to would be trickier than usual, just leave them for now. I'll think of something.


Link github or gitbucket for sample code

More sample on those web which can host the code.

⚠ Idea migrated from UserVoice
Created By: Richie
Created On: 2017/12/07 03:50:39 +0000
Votes at Migration: 1
Supporters at Migration: 1

We are currently working on exposing more sample code snippets and full sample projects.  I am working with the different content authors to get this readily available.

This is now available: https://docs.microsoft.com/samples


Tarsum insecurity

The current tarsum system is fatally flawed.
The goal of a cryptographic checksum is to help build a secure system that prevents messages from being tampered with. In order to build such a system, the message must not be processed in any way before the checksum is verified. Every line of code that does processing before a checksum is verified is dealing with entirely untrusted bits and is a huge target for exploitation.
Currently a massive amount of processing is done before verification of the checksum, namely image unpacking.
Recent Docker vulnerabilities demonstrate this point as CVE-2014-9356, CVE-2014-9357, and CVE-2014-6407 all occur during extraction and could have been triggered using a tampered image that had an invalid tarsum.
Even if unpacking did not happen before the tarsum is checked, the tarsum spec requires that the tar stream be decoded in order to verify the checksum, which is an unacceptable amount of processing to perform before verifying a cryptographic checksum.
I propose that instead, a simple checksum of the tarball is taken after it is packed up. That way image layers can be downloaded to a temporary location, the checksum (and hopefully signature) verified, and then after successful verification they can be unpacked.
On top of this, layer tarsums do not appear to be chained, possibly allowing layer swap attacks. Any checksum of a layer should include the checksum of its parent and so on. One option is to put the checksum in the layer manifest and then after downloading and verifying the signature of the leaf layer, use the parent checksums embedded in each layer manifest. I have not evaluated the current layer signing code as it appears to be not fully deployed.
From a usability perspective, tarsums are only calculated on push and are not exposed in any way locally via the API. This makes it really hard to build other programs that work with Docker images.

I've raised @kofalt's suggestion of suppressing the message for now as a new issue #10158.

#9784 was merged today making my pull request to remove the verified message obsolete. Is there a write-up somewhere of how the concerns were addressed? I'm still concerned that docker is doing a tarsum-like thing. Does that still mean that will happily invoke xz on the input for example?

Haven't seen any movement on this in a while. Any path toward a better solution here?

@mmdriley if you are interested in this topic much of the work is being done on the distribution end.  See https://github.com/docker/distribution/pull/62.  We have had some other recent difficulties with tarsum unrelated to security that is pushing us away from it as a distribution content address. We have also made incremental improvements in 1.5 for inclusion of tarsum verification as well as limiting the messaging to users for when we have fully verified the manifest, signing keys, and tarsums. The future likely won't be without tarsum since it is a very valuable tar comparison tool, but using the raw sha on blobs is just easier.

Could this have label project/security added?

Any news about these problems?

@gomex see the docker/distribution work. Progress is being made on image management which will no longer utilize tarsum.

Registry now uses SHA2 digests: https://github.com/docker/distribution/pull/238
Docker now verifies images using SHA2 digests before unpacking: https://github.com/docker/docker/pull/11271
I think it might be okay to close this issue. @titanous what do you think?

@jlhawn Is the digest of the raw bytes with no parsing of the tar?

@jlhawn we are not doing a hard enforce of the digest yet for 1.6 while we give early adopters of the v2 registry a chance to generate images not using tarsum. Images pushed with 1.6 will not be using tarsum.
@titanous verifying the sha256 digest does not involve parsing the tar file.  The digest is computed on the raw bytes as it is being streamed into a temp file.  The tar is extracted after the digest computation is complete.
I would be ok with defining this issue as resolved once we switch to hard enforce of the digest and no longer support tarsum as an allowed digest.  As long as tarsum is allowed, registries can cause a tarsum computation.

I would be ok with defining this issue as resolved once we switch to hard enforce of the digest and no longer support tarsum as an allowed digest. As long as tarsum is allowed, registries can cause a tarsum computation.

I agree, this issue should stay open until tarsum is removed or prints a warning when used.

This was a long discussion indeed.
Integrity checking of the downloaded image doesn't have to involve temporary storage.  The technique you want to utilize is called tree hashing, and is used in bittorrent and git for example.
Keccak (SHA-3) is particularly well suited to this.  It is completely safe, as you can read in http://sponge.noekeon.org/TreeHashing.pdf.  Most modern cryptographic hash functions are designed to support this mode.
Tree hashing simply means that the image hash is (recursively) a hash of other hashes, with hashes of chunks at the leaves.  Some padding around the hashes is required to make this safe (read the paper).
With tree hashing you only need to transfer a few extra hashes as meta-data in the image, and using these hashes you can always know that what you have received is a valid part of the final image.

I think this can be close now with the content addressable store and tarsum being removed from distribution as well  https://github.com/docker/distribution/pull/1271, but feel free to comment if I overlooked something

oh what a gem of a thread. I had completely forgotten about. Glad to have
been part of facilitating the content addressibility support. Thanks
Sebastian for following up on this.
On Thu, Apr 7, 2016 at 2:32 AM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

I think this can be close now with the content addressable store and
tarsum being removed from distribution as well docker/distribution#1271
https://github.com/docker/distribution/pull/1271, but feel free to
comment if I overlooked something
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/9719#issuecomment-206713776


should ensure issuer DID supports proof purpose

followup to #279

This has been implemented in #364 . Closing the issue.


Error in TS build

Thanks for providing this lib :-).
When I build my Project (typescript: 4.9.4) with a contactjs dependency, I receive the following error:
Error: node_modules/contactjs/dist/index.d.ts:18:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

18 enum PointerManagerState {
   ~~~~

Could you export or declare these?

Thanks for the quick response :)

Thanks for reporting the issue!


Non user pane: relevant information

Before working on #302 (fancy features), we need a landing page for non-redcall users letting them:

give their contact and availability information update
integrate RGPD

Every page (like phone update etc) should give as many details as possible on how that information will be used, how they will receive messages, and how they should answer, etc.

Began working on it during the last weekend:


DB: Add database and model skeleton

I added this part to have everything set up for when we will define the tables.
I think a good practice is to create a template for each table.
Closes #10
Closes #9
Signed-off-by: Federico Bruzzone<EMAIL_ADDRESS>

This code is only for sqflite and not for sqflite_ffi. I will change this part after this PR, maybe after we understand the table of the db.


Failed while: Wait for Condition: InitialRolesPopulated: True when creating a cluster with a Standard User

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Install Rancher 2.4 master-head (03/03/2020) commit id: 3623201ad
Login as admin, create an Standard User (standarduser1)
Logout and login as standarduser1
Start creating a cluster, I used a one/all roles node on DigitalOcean
Click Create

Result:
Failed while: Wait for Condition: InitialRolesPopulated: True

Other details that may be helpful:

This is not reproducible in Rancher v2.3.5
Clicking in Create again after getting the error succeeds in creating the cluster.

Environment information

Rancher version: 2.4 master-head (03/03/2020) commit id: 3623201ad
Installation option (single install/HA): single

Rancher version: 2.4 master-head (03/05/2020) commit id: f6872eb2c
Validated this is no longer happening when deploying a cluster with an Standard User.

I'm facing the same issue in Rancher 2.5.3 - saving it again does not succeed.. I'm an admin user.

..and for Rancher 2.6.3 as well. I'm trying to create a new cluster with the custom "hetzner driver"

...and for Rancher 2.5.8 as well.

Do we know why this is happening and any resolution to this? Not sure why this is Marked as closed.

Happening for me in 2.5.7. Would be nice to add a new cluster...

I was getting this error in cattle-system pods:
[rancher-7c7995df75-jwhq5] 2022/04/18 15:39:44 [ERROR] error syncing 'c-q89qh': handler mgmt-cluster-rbac-delete: Internal error occurred: failed calling webhook "rancherauth.cattle.io": Post "https://rancher-webhook.cattle-system.svc:443/v1/webhook/validation?timeout=10s": x509: certificate has expired or is not yet valid: current time 2022-04-18T15:39:44Z is after 2022-04-07T13:37:43Z, requeuing
This doc fixed me up:
https://rancher.com/docs/rancher/v2.6/en/troubleshooting/expired-webhook-certificates/

，，，and for 2.7.1 as well

happens in 2.7.5 as well


support a common variant of the json mime type

What does this PR do?
Supports a common variant of the json mime type.
Motivation
The agent is unable to accept payloads from many programming languages and frameworks without this fix.
Additional Notes
This fixes #3172

I don't have the time to look into why the milestone / release_note / team_label checkers are failing, I'm just going to workaround this by sending msgpack instead of JSON.


Added an event to  dispatch

In pallet_roles/set_manager dispatch, do not check that new and old manager are different accounts
Ads an event to the pallet_onboarding/change_status dispatch function

Motivation

Pallet roles

The sudo pallet_key cannot be attributed to more than one account
By Default, Alice has the sudo_key, but has no role.
The sudo key should have the authority to attribute a role to himself. the set_role dispatch will only work if no role is attributed yet. The check implemented previously only prevent the sudo key to get a role during the Genesis stage of the pallet

Pallet Onboarding
An event makes it easier to track the status change, and see clearly if the corresponding calls are executed or not.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d26f1b6). Click here to learn what that means.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage        ?   76.76%
=======================================
  Files           ?       49
  Lines           ?     4119
  Branches        ?        0
=======================================
  Hits            ?     3162
  Misses          ?      957
  Partials        ?        0

Impacted Files
Coverage Δ

pallets/roles/src/lib.rs
78.02% <ø> (ø)

pallets/onboarding/src/lib.rs
88.79% <83.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[gtk3] Runtime failure

Describe the bug
Compiling xournalpp with msvc results in a crash directly after startup.
The crash is located in gobject-2.0-0.dll it crashes with an access violation after a call to gtk_clipboard_request_contents.
Environment

OS: Windows
Compiler: MSVC 143

To Reproduce
Steps to reproduce the behavior:

./vcpkg install gtk3
clone xournalpp
clone portaudio and compile portaudiocpp, add it to path
cd */xournalpp && mkdir build && cd build
cmake -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake ..
cmake --build .
.\xournalpp.exe

Expected behavior
No crash with access violation in a 3rd party lib, fetched by vcpkg
Failure logs
-------------------------------------------------------------------
You may only use the C/C++ Extension for Visual Studio Code
with Visual Studio Code, Visual Studio or Visual Studio for Mac
software to help you develop and test your applications.
-------------------------------------------------------------------
Breakpoint warning: No executable code of the debugger’s target code type is associated with this line.
Possible causes include: conditional compilation, compiler optimizations, or the target architecture of this line is not supported by the current debugger code type. - c:\Users\Febbe\workspace\xournalpp\src\core\gui\toolbarMenubar\PluginToolButton.h:22
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\xournalpp.exe'. Symbols loaded.
Loaded 'C:\Windows\System32\ntdll.dll'.
Loaded 'C:\Windows\System32\kernel32.dll'.
Loaded 'C:\Windows\System32\KernelBase.dll'.
Loaded 'C:\Windows\System32\shell32.dll'.
Loaded 'C:\Windows\System32\msvcp_win.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\gdk-3-vs17.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\gtk-3-vs17.dll'.
Loaded 'C:\Windows\System32\ucrtbase.dll'.
Loaded 'C:\Windows\System32\advapi32.dll'.
Loaded 'C:\Windows\System32\user32.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\gdk_pixbuf-2.0-0.dll'.
Loaded 'C:\Windows\System32\msvcrt.dll'.
Loaded 'C:\Windows\System32\win32u.dll'.
Loaded 'C:\Windows\System32\sechost.dll'.
Loaded 'C:\Windows\System32\gdi32.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\gobject-2.0-0.dll'.
Loaded 'C:\Windows\System32\gdi32full.dll'.
Loaded 'C:\Windows\System32\rpcrt4.dll'.
Loaded 'C:\Windows\System32\imm32.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\glib-2.0-0.dll'.
Loaded 'C:\Windows\System32\ole32.dll'.
Loaded 'C:\Windows\System32\setupapi.dll'.
Loaded 'C:\Windows\System32\ws2_32.dll'.
Loaded 'C:\Windows\System32\combase.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\intl-8.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\cairo-2.dll'.
Loaded 'C:\Windows\System32\comdlg32.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\pango-1.0-0.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\cairo-gobject-2.dll'.
Loaded 'C:\Windows\System32\SHCore.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\epoxy-0.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\gio-2.0-0.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\pangocairo-1.0-0.dll'.

Loaded 'C:\Windows\System32\shlwapi.dll'.
Unloaded 'C:\Windows\System32\shlwapi.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\libpng16.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\jpeg62.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\tiff.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\gmodule-2.0-0.dll'.
Loaded 'C:\Windows\System32\vcruntime140.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\harfbuzz.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\fribidi-0.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\atk-1.0-0.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\pangowin32-1.0-0.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\libffi.dll'.
Loaded 'C:\Windows\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.22621.608_none_a9444ca7c10bb01d\comctl32.dll'.
Loaded 'C:\Windows\System32\winspool.drv'.
Loaded 'C:\Windows\System32\dwmapi.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\poppler-glib.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\zip.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\libxml2.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\portaudio.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\zlib1.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\sndfile.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\iconv-2.dll'.
Loaded 'C:\Windows\System32\msvcp140.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\pcre2-8.dll'.
Loaded 'C:\Windows\System32\vcruntime140_1.dll'.
Loaded 'C:\Windows\System32\winmm.dll'.
Loaded 'C:\Windows\System32\hid.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\fontconfig-1.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\freetype.dll'. Symbols loaded.
Loaded 'C:\Windows\System32\msimg32.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\pixman-1-0.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\pangoft2-1.0-0.dll'.
Loaded 'C:\Windows\System32\dnsapi.dll'.
Loaded 'C:\Windows\System32\IPHLPAPI.DLL'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\liblzma.dll'.
Loaded 'C:\Windows\System32\DWrite.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\bz2.dll'.
Loaded 'C:\Windows\System32\bcrypt.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\poppler.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\vorbisenc.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\FLAC.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\opus.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\mpg123.dll'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\libmp3lame.DLL'.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\vorbis.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\ogg.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\libexpat.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\brotlidec.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\openjp2.dll'. Symbols loaded.
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\brotlicommon.dll'. Symbols loaded.
Loaded 'C:\Windows\System32\nsi.dll'.
Loaded 'C:\Windows\System32\bcryptprimitives.dll'.
Loaded 'C:\Windows\System32\kernel.appcore.dll'.

(xournalpp.exe:20164): GLib-GIO-WARNING **: 01:08:35.395: win32 session dbus binary not found
Loaded 'C:\Windows\System32\KBDGR.DLL'.
Loaded 'C:\Windows\System32\devobj.dll'.
2
Loaded 'C:\Windows\System32\cfgmgr32.dll'.
Unloaded 'C:\Windows\System32\cfgmgr32.dll'.
Loaded 'C:\Windows\System32\cfgmgr32.dll'.
Unloaded 'C:\Windows\System32\cfgmgr32.dll'.
Loaded 'C:\Windows\System32\wintrust.dll'.
Loaded 'C:\Windows\System32\crypt32.dll'.
Loaded 'C:\Windows\System32\msasn1.dll'.
Loaded 'C:\Windows\System32\uxtheme.dll'.
Loaded 'C:\Windows\System32\clbcatq.dll'.
Loaded 'C:\Windows\System32\msctf.dll'.
Loaded 'C:\Windows\System32\windows.storage.dll'.
Loaded 'C:\Windows\System32\WinTypes.dll'.
Loaded 'C:\Windows\System32\profapi.dll'.
Loaded 'C:\Windows\System32\winhttp.dll'.
Loaded 'C:\Windows\System32\OnDemandConnRouteHelper.dll'.
Unloaded 'C:\Windows\System32\OnDemandConnRouteHelper.dll'.
** Message: 01:08:35.443: TEXTDOMAINDIR = (NULL), Platform-specific locale dir = C:\Users\Febbe\workspace\xournalpp\build\..\share\xournalpp\..\locale, chosen directory = C:\Users\Febbe\workspace\xournalpp\build\..\share\xournalpp\..\locale
Loaded 'C:\Windows\System32\winmmbase.dll'.
Loaded 'C:\Windows\System32\MMDevAPI.dll'.
Loaded 'C:\Windows\System32\wdmaud.drv'.
Loaded 'C:\Windows\System32\ksuser.dll'.
Loaded 'C:\Windows\System32\avrt.dll'.
Loaded 'C:\Windows\System32\AudioSes.dll'.
Loaded 'C:\Windows\System32\msacm32.drv'.
Loaded 'C:\Windows\System32\msacm32.dll'.
Loaded 'C:\Windows\System32\midimap.dll'.
Loaded 'C:\Windows\System32\ResourcePolicyClient.dll'.
Loaded 'C:\Windows\System32\dsound.dll'.
Loaded 'C:\Windows\System32\RESAMPLEDMO.DLL'.
2
Loaded 'C:\Windows\System32\powrprof.dll'.
Unloaded 'C:\Windows\System32\powrprof.dll'.
Loaded 'C:\Windows\System32\oleaut32.dll'.
Loaded 'C:\Windows\System32\msdmo.dll'.
Loaded 'C:\Windows\System32\umpdc.dll'.

(xournalpp.exe:20164): Gtk-WARNING **: 01:08:35.551: Could not load image 'pixmaps/com.github.xournalpp.xournalpp.svg': Couldn?t recognize the image file format for file ?C:\Users\Febbe\workspace\xournalpp\ui\pixmaps/com.github.xournalpp.xournalpp.svg?
Loaded 'C:\Windows\System32\shfolder.dll'.
Fontconfig error: Cannot load default config file: No such file: (null)
Loaded 'C:\Windows\System32\cryptbase.dll'.
Loaded 'C:\Windows\System32\IconCodecService.dll'.
Loaded 'C:\Windows\System32\WindowsCodecs.dll'.
Loaded 'C:\Windows\System32\xmllite.dll'.
Loaded 'C:\Windows\System32\AppXDeploymentClient.dll'.
Loaded 'C:\Windows\System32\Windows.ApplicationModel.dll'.
Loaded 'C:\Windows\System32\Windows.StateRepositoryPS.dll'.
Loaded 'C:\Windows\System32\Windows.StateRepositoryBroker.dll'.
Loaded 'C:\Windows\System32\MrmCoreR.dll'.
Loaded 'C:\Windows\System32\iertutil.dll'.
Loaded 'C:\Windows\System32\Windows.StateRepositoryCore.dll'.
Loaded 'C:\Windows\System32\Windows.UI.dll'.
Loaded 'C:\Windows\System32\BCP47mrm.dll'.
Loaded 'C:\Windows\System32\Windows.FileExplorer.Common.dll'.
Loaded 'C:\Windows\System32\propsys.dll'.
Loaded 'C:\Windows\System32\apphelp.dll'.
Loaded 'C:\Windows\System32\networkexplorer.dll'.
onecore\com\combase\objact\objact.cxx(4070)\combase.dll!00007FFCE4925905: (caller: 00007FFCE492D65A) ReturnHr(1) tid(4b68) 80040154 Klasse nicht registriert
Loaded 'C:\Windows\System32\mssprxy.dll'.
Loaded 'C:\Windows\System32\Windows.StateRepositoryClient.dll'.
onecore\com\combase\objact\objact.cxx(4070)\combase.dll!00007FFCE4925905: (caller: 00007FFCE492D65A) ReturnHr(2) tid(4b68) 80040154 Klasse nicht registriert
onecore\com\combase\objact\objact.cxx(4070)\combase.dll!00007FFCE4925905: (caller: 00007FFCE492D65A) ReturnHr(3) tid(4b68) 80040154 Klasse nicht registriert
onecore\com\combase\objact\objact.cxx(4070)\combase.dll!00007FFCE4925905: (caller: 00007FFCE492D65A) ReturnHr(4) tid(4b68) 80040154 Klasse nicht registriert
Exception thrown at 0x00007FFC855B2975 (gobject-2.0-0.dll) in xournalpp.exe: 0xC0000005: Access violation reading location 0xFFFFFFFFFFFFFFFF.
The program '[20164] xournalpp.exe' has exited with code 0 (0x0).

Additional context
Add any other context about the problem here.

@JonLiu1993 the problem is, that xournalpp depends on portaudiocpp, which is currently not part of vcpkg, therefore it must be compiled manually: I've just created a static library (release mode + /MD + MSVC STL) and added it to the PATH variable of the OS.
You must install it into C:\builds or you must change the prefix path in the "lib\pkgconfig\portaudiocpp.pc" file.

@JonLiu1993 the problem is, that xournalpp depends on portaudiocpp, which is currently not part of vcpkg, therefore it must be compiled manually: I've just created a static library (release mode + /MD + MSVC STL) and added it to the PATH variable of the OS. I've also added the pkg-config folderpath to the PKG_CONFIG_PATH environment variable.
If that's too much effort or too complicated, that's my compiled portaudio (release mode + /MD + MSVC STL + x86_64): portaudiocpp.zip You must install it into C:\builds or you must change the prefix path in the lib\pkgconfig\portaudiocpp.pc file.
Interestingly, linking against the UCRT64 libraries of MSYS (requires some work to make the pkg-config files compatible), does not result into a crash at runtime. But scrolling/zooming just don't work.

@Febbe, Sorry for reply you so late, could you elaborate on your steps to reproduce it? I couldn't reproduce your issue locally because I really didn't understand your steps to reproduce.

@JonLiu1993 the problem is, that xournalpp depends on portaudiocpp, which is currently not part of vcpkg, therefore it must be compiled manually: I've just created a static library (release mode + /MD + MSVC STL) and added it to the PATH variable of the OS. I've also added the pkg-config folderpath to the PKG_CONFIG_PATH environment variable.
If that's too much effort or too complicated, that's my compiled portaudio (release mode + /MD + MSVC STL + x86_64): portaudiocpp.zip You must install it into C:\builds or you must change the prefix path in the lib\pkgconfig\portaudiocpp.pc file.
Interestingly, linking against the UCRT64 libraries of MSYS (requires some work to make the pkg-config files compatible), does not result into a crash at runtime. But scrolling/zooming just don't work.

@Febbe, Sorry for reply you so late, could you elaborate on your steps to reproduce it? I couldn't reproduce your issue locally because I really didn't understand your steps to reproduce.

Which step you don't understand, or at which step do you fail?
Do you have a cmake log/trace? MAybe a specific package is missing.

./vcpkg install gtk3
clone xournalpp
clone portaudio and compile portaudiocpp, add it to path
cd */xournalpp && mkdir build && cd build
cmake -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake ..
cmake --build .
.\xournalpp.exe

We first need to install all dependencies of xournalpp:
glib-2.0
gtk+-3.0
poppler-glib
gthread-2.0
libxml-2.0
libzip
portaudiocpp
sndfile
librsvg-2.0
zlib
imagemagick

./vcpkg install gtk3:x64-windows glib:x64-windows poppler[glib]:x64-windows portaudio:x64-windows libzip:x64-windows zlib:x64-windows libxml2:x64-windows sndfile:x64-windows librsvg:x64-windows libsndfile:x64-windows
ImageMagick must be acquired from somewhere else. Also, the legacy tools are required to be installed and added to the PATH
Then we can choose any working directory and clone xournalpp.
Since Xournalpp requires portaudiocpp, which is currently not part of vcpkg, you must compile it yourself, or use my provided binary.
Now xournalpp should be buildable as described by step 4 and onwards.

ImageMagick must be acquired from somewhere else. Also, the legacy tools are required to be installed and added to the PATH

Wait, this will pull in non-vcpkg builds of graphic libraries and font libraries. It is no surprise that this gives runtime errors.
And of course one must not mix ucrt and legacy crt binaries.

ImageMagick must be acquired from somewhere else. Also, the legacy tools are required to be installed and added to the PATH

Wait, this will pull in non-vcpkg builds of graphic libraries and font libraries. It is no surprise that this gives runtime errors.
And of course one must not mix ucrt and legacy crt binaries.

Wouldn't the log show that there is a library loaded from such a location?
I can only find some from the system path and the build path. So that shouldn't be the issue here, right? I can rewrite the cmake build script through, that it requires the path in a cmake variable to imagemagic, instead of having it in the path variable.

Which DLLs come with your copy of imagemagick? (Are there any DLLs at all?)

"msvcp140_codecvt_ids.dll"
"vcomp140.dll"
"vcruntime140.dll"
"vcruntime140_1.dll"
"CORE_RL_bzlib_.dll"
"CORE_RL_cairo_.dll"
"CORE_RL_exr_.dll"
"CORE_RL_flif_.dll"
"CORE_RL_freetype_.dll"
"CORE_RL_fribidi_.dll"
"CORE_RL_glib_.dll"
"CORE_RL_harfbuzz_.dll"
"CORE_RL_heif_.dll"
"CORE_RL_jasper_.dll"
"CORE_RL_jpeg-turbo_.dll"
"CORE_RL_jpeg-xl_.dll"
"CORE_RL_lcms_.dll"
"CORE_RL_lqr_.dll"
"CORE_RL_lzma_.dll"
"CORE_RL_Magick++_.dll"
"CORE_RL_MagickCore_.dll"
"CORE_RL_MagickWand_.dll"
"CORE_RL_openjpeg_.dll"
"CORE_RL_pango_.dll"
"CORE_RL_png_.dll"
"CORE_RL_raw_.dll"
"CORE_RL_rsvg_.dll"
"CORE_RL_tiff_.dll"
"CORE_RL_webp_.dll"
"CORE_RL_xml_.dll"
"CORE_RL_zip_.dll"
"CORE_RL_zlib_.dll"
"mfc140u.dll"
"msvcp140.dll"
"msvcp140_1.dll"
"msvcp140_2.dll"
"msvcp140_atomic_wait.dll"

Ok, I found another issue: rsvg-convert.exe is not builded and installed with the librsvg target, so you musst download it from: here and put it into the path.
Also, pkg-connfig is not installed along with vcpkg, which also musst be aquired from somewhere, I took that: https://sourceforge.net/projects/pkgconfiglite/files/0.28-1/pkg-config-lite-0.28-1.tar.gz/download
Also, we musst create a pc file at C:\vcpkg\installed\x64-windows\lib\pkgconfig\librsvg-2.0.pc with the following content:
prefix=${pcfiledir}/../..
exec_prefix=${prefix}
bindir=${prefix}/bin
libdir=${prefix}/lib
includedir=${prefix}/include

Name: librsvg-2.0
Description: library for handling rsvg files
Version: 2.40.2
Requires: glib-2.0 gio-2.0 gdk-pixbuf-2.0 cairo
Libs:  "-L${libdir}" -lrsvg-2.40
Cflags: "-I${includedir}"

So I added stacktraces for windows builds and took care, that no foreign dll is in the path (possible from pkg-config and imagemagick). And I got another error now: It seems like gtk is missing the Adwaita theme:
-------------------------------------------------------------------
You may only use the C/C++ Extension for Visual Studio Code
with Visual Studio Code, Visual Studio or Visual Studio for Mac
software to help you develop and test your applications.
-------------------------------------------------------------------
Breakpoint warning: No executable code of the debugger’s target code type is associated with this line.
Possible causes include: conditional compilation, compiler optimizations, or the target architecture of this line is not supported by the current debugger code type. - c:\Users\Febbe\workspace\xournalpp\src\core\gui\toolbarMenubar\PluginToolButton.h:22
Breakpoint warning: No executable code of the debugger’s target code type is associated with this line.
Possible causes include: conditional compilation, compiler optimizations, or the target architecture of this line is not supported by the current debugger code type. - c:\Users\Febbe\workspace\xournalpp\src\util\Stacktrace.cpp:65
Breakpoint warning: No executable code of the debugger’s target code type is associated with this line.
Possible causes include: conditional compilation, compiler optimizations, or the target architecture of this line is not supported by the current debugger code type. - c:\Users\Febbe\workspace\xournalpp\build-clang\_deps\fbbe_stacktrace-src\itanium\include\fbbe\stacktrace.h:312
Breakpoint warning: No executable code of the debugger’s target code type is associated with this line.
Possible causes include: conditional compilation, compiler optimizations, or the target architecture of this line is not supported by the current debugger code type. - c:\Users\Febbe\workspace\xournalpp\build-clang\_deps\fbbe_stacktrace-src\itanium\include\fbbe\stacktrace.h:325
Breakpoint warning: No executable code of the debugger’s target code type is associated with this line.
Possible causes include: conditional compilation, compiler optimizations, or the target architecture of this line is not supported by the current debugger code type. - c:\Users\Febbe\workspace\xournalpp\src\core\pdf\base\XojPdfPage.h:22
Loaded 'C:\Users\Febbe\workspace\xournalpp\build\xournalpp.exe'. Symbols loaded.
Loaded 'C:\Windows\System32\ntdll.dll'.
Loaded 'C:\Windows\System32\kernel32.dll'.
Loaded 'C:\Windows\System32\KernelBase.dll'.
Loaded 'C:\Windows\System32\shell32.dll'.
Loaded 'C:\Windows\System32\msvcp_win.dll'.

You can build port pkgconf when you need a pkg-config implementation. (vcpkg uses msys2's pkg-config internally, but it is not exposed to users.)
Vcpkg focuses on libs, not tools. When do you need rsvg-convert now?
But this is build-time stuff. And unrelated to imagemagick. I don't see an imagemagick DLL, so I guess you use a static lib, with 3rd-party libs embedded into a "convenient" archive.

You can build port pkgconf when you need a pkg-config implementation. (vcpkg uses msys2's pkg-config internally, but it is not exposed to users.)
Vcpkg focuses on libs, not tools. When do you need rsvg-convert now?
But this is build-time stuff. And unrelated to imagemagick. I don't see an imagemagick DLL, so I guess you use a static lib, with 3rd-party libs embedded into a "convenient" archive.

rsvg-convert, imagemagick and pkg-config are all used at configure time, so I removed them from the path. Therefore none of their DLLs/libs should be pulled in.
I cleaned the path, so that it only contained cmake,ninja and LLVM. Then I cleaned the vcpkg installation and recompiled everything.
The only static lib I use intentionally is the self compiled portaudiocpp, which dynamically links to portaudio.
When a static lib is the reason, it should be one of the vcpkg libs.

I am not sure, but this looks like undefined behav. in the code of gtk3:
gdkselection-win32.c:1971
  info = g_slice_new (GdkWin32ClipboardQueueInfo);

  info->display = display;
  g_set_object (&info->requestor, requestor);
  info->selection = GDK_SELECTION_CLIPBOARD;
  info->target = target;
  info->idle_time = 0;
  info->time = time;
  info->action = action;

The debugger of windows initializes it with 0xbebebebe, when calling g_set_object(&info->requestor, requestor) it tries to unref 0xbebebebe, which is of course not an gobject.

Just checked this in https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-24/gdk/win32/gdkselection-win32.c and they fixed that. @JonLiu1993 this issue is fixed, when you update gtk3 to the newest version.


Add new GitHub action to test for bad OWL Restriction's

These seem to keep creeping back in, or else they were never corrected.  Trying to add a check to our GitHub Actions CI.

OK, this is ready to go. Should be squash-merged.  Note that it is on top of #122, so should be merged after that.
Note also that the tests fail on this because they should fail: we have two ill-formed OWL files in the repo.

Looks like there's still an issue with the script.

@bbartley Please have a look at this: it's ready to go now.

Manually merged this: wanted to squash merge, and have more control over the commit message than GitHub would give me. Closing.


Proposal / Setup a docker version

Hi,
I would like to help to create the docker version of it. As I don't have a medium blog, I have a question, do you have Medium export I could work with? If you don't I will create a dummy user then :)
Cheers!

Thanks! I tried to create a dummy user, but Medium makes you tie your account to a real Facebook or Google login so I wasn't able to make a second account. So unfortunately I don't have a sample export to share. But feel free to set up a docker version!

OK, I'll do it then. See ya!


Feature Request: Alt-K should reblur

Several users have requested the ability to reblur an image after selectively unblurring it. Alt-K should be redesigned to allow the user to both unblur & reblur a selective image. I have finished this feature, and am cleaning up documentation & testing it now before releasing iA.

Masha Allah. This feature will make the extension more complete.

Featured added, merged into master. #7


Update devDependencies and switch to Node.js 16/npm 7+

Since Node.js 16 is moving to active LTS, makes sense to switch to it.
BTW personally I'd move lint to a separate workflow so that it can be restarted separately.

Can we get a new release now?


Avoid prompting for DEBUG env var access

That's how it was before Deno decided to always prompt by default. This PQ restores the old behaviour.

Approved in https://t.me/grammyjs/44965


Tmux Copy/Paste/Scroll in Darwin

Describe the bug
I am failing to get copy-paste and scrolling mouse behaviors working under nix. Granted I am very fresh to nix, and attempting an install on my mac, but I have honestly been hacking away at this for 2 days.
To Reproduce
I have Alactritty installed using brew cask install alactritty.
Which I configure using home-manager to use tmux.
  xdg.configFile = {
    "alacritty/alacritty.yml".text = ''
      shell:
        # Use nix installed tmux.
        program: ${pkgs.tmux}/bin/tmux

      ${builtins.readFile ./alacritty.yml}
    '';
  };

I configure tmux with the tmux-yank plugin.
  programs.tmux = {
    enable = true;

    # Use vim keybinding in copy mode.
    keyMode = "vi";

    plugins = with pkgs.tmuxPlugins; [
      yank
    ];

    extraConfig = ''
      # Use zsh as the default shell without installing it in the user.
      set-option -g default-shell "${pkgs.zsh}/bin/zsh"
      set-option -g default-command "${pkgs.reattach-to-user-namespace}/bin/reattach-to-user-namespace -l ${pkgs.zsh}/bin/zsh"

      ${builtins.readFile ./tmux.conf}
    '';
  };

This is what can be found in tmux.conf
# Mouse mode on
set -g terminal-overrides 'xterm*:smcup@:rmcup@'
set -g mouse on

Install neovim with appropriate plugins for tmux integration.
  # Configure vim.
  programs.neovim = {
    plugins = with pkgs.vimPlugins; [
      # Tmux integration.
      vim-tmux-focus-events
      vim-tmux-navigator
      vim-tmux-clipboard
    ];
  }

Expected behavior

Mouse scroll up in at zsh prompt to enter tmux copy mode.
Highlight text to copy selection into system clipboard.
Mouse scroll up in command like man tree to scroll buffer.
Mouse scroll up in vim to move vim cursor.
Highlight text while in vim to copy selection into system clipboard.

Metadata
As a side note, I am getting the following error when running the suggested command for nix-info:
nix run nixpkgs.nix-info -c nix-info -m
Assertion failed: (size_ < capacity_), function push_back, file src/libexpr/attr-set.hh, line 54.

But jumping into a nix-shell -p nix-info, here is the meta:

system: "x86_64-darwin"
host os: Darwin 18.7.0, macOS 10.14.6
multi-user?: no
sandbox: no
version: nix-env (Nix) 2.3.1
channels(anthony): "home-manager, nixpkgs-20.03pre196811.7818f30cc4b"
nixpkgs: /Users/anthony/.nix-defexpr/channels/nixpkgs

Have you installed reattach-to-user-namespace?  Clipboard access does not work in shells in tmux under Mac OS without it.  It looks like the yank plugin will detect it in the path automatically, but I would recommend setting reattach-to-user-namespace -l my-shell as tmux's default-command.
If that's not it, what happens instead of the "Expected behavior"?

No copying occurs. I have tried setting the default-command to use reattach-to-user-namespace, both the one I installed using brew and nix.
Does anyone have a working example with nix+darwin+tmux(+alactritty)?

I just now opened tmux in Alacritty (installed from Nix a few weeks ago), manually ran set -g mouse on and was able to scroll my shell history with the trackpad in bash and select text.  I have no alacritty.yml at the moment, since I just switched from using it normally.  I have tmux next-3.1 from this override.
When I was using Alacritty day-to-day (up to about a week ago), I occasionally needed to copy from the terminal.  If the application in the tmux window "wanted" the mouse, Alacritty wouldn't let me select text with the trackpad.  This is Alacritty's copy mode, not tmux's.  (I use tmux copy mode from the keyboard normally.)
I don't have yank installed.  My tmux config is here.
My $TERM in Alacritty (the one tmux sees) is xterm-256color.
My $TERM inside tmux is tmux-256color, but is patched and manually installed for palette colors from the install.sh and tic files here, though I think this script is broken because the two versions of ncurses on my system compete in weird ways that I might have sorted out manually.
I hope this helps.

closing since not a nix issue.


No firebase module?

Hello,
On the youtube tutorial and when you run this it looks for firebase.js ... this does not seem to exist?

Hi, I took it out as it had my details in there, but all you have to do is create the file and drop your details in there and it should work.

Thanks for getting back to me - makes sense.
I got this setup and it works perfectly it's a great tutorial and resource so thank you for creating this and the YouTube code along.


⚠ Bofrost.at has degraded performance

In e9ca025, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3218 ms

Resolved: Bofrost.at performance has improved in 80779a6 after 13 minutes.


ci(.github): add helm chart smoketest workflow

Describe your changes
Adds initial helm chart test automation using a KinD cluster.
Ref https://github.com/spinkube/runtime-class-manager/issues/48
Issue ticket number and link
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
I tested the changes with the following distributions:

[ ] Kind
[ ] MiniKube
[ ] MicroK8s
[ ] Rancher RKE2
[ ] Azure AKS
[ ] GCP GKE (Ubuntu nodes)
[ ] AWS EKS (AmazonLinux2 nodes)
[ ] AWS EKS (Ubuntu nodes)
[ ] Digital Ocean Kubernetes

Hmmm, I'm wondering why the main CI workflow (where the new chart test is added, along with preexisting unit and lint jobs) isn't running for my PR 🤔

Seeing a failure where the shim isn't installed or can't be located, etc.  I'm guessing this isn't the test automation; I'll test the usual helm chart install off of main onto KinD to compare notes/debug...

I'm guessing this isn't the test automation

Lol well it mostly was.  Needed to update the shim binary arch to match the GH runner's arch (amd64/x86_64).
Ready for review now!

Really nice to have some chart testing! Also the PR looks pretty good to me.
Nevertheless a point for discussion: while I personally also mainly use kind for developing and testing locally, the spin-operator seems to use k3d for all pipeline-based tests. Should we align ourselves here?
From a technical PoV I'm not 100% sure how much of a technical difference this is... wdyt?

Nevertheless a point for discussion: while I personally also mainly use kind for developing and testing locally, the spin-operator seems to use k3d for all pipeline-based tests. Should we align ourselves here?

Thanks @voigt, that's a great question.  I should have mentioned my thoughts on that in this PR.  Spin Operator indeed uses the k3d image shipped by the spinkube/containerd-shim-spin project both in its test automation and quick start due to efficiency: the spin shim is already baked in to the image and so will exist on all nodes based on the image.  Since installing and configuring the shim is part of this project's duties and therefore functionality we'd like to test, I was thinking a blank-slate cluster like KinD might be a good first start.
All that being said, as laid out in https://github.com/spinkube/runtime-class-manager/issues/48, the ultimate vision is to have test coverage for all supported distros and k3d (either with shim pre-installed or stock) does seem like a good next one to add, as well as other free/easy options like minikube, etc.  So let's definitely think about our preferred approach for supporting the full matrix of distros.  I think we'll still maybe want one quick/easy 'smoke test' for the helm install, ideally on a lightweight distro like kind, to automatically run on PRs... and then maybe the full suite for merges to main?
For "preferred approach for supporting the full matrix of distros", do we see GH workflow yaml(s) the right spot to orchestrate?  Or something higher-level/custom eg a go binary, etc?  (This could be good discussion to also have back in #48)

So let's definitely think about our preferred approach for supporting the full matrix of distros. I think we'll still maybe want one quick/easy 'smoke test' for the helm install, ideally on a lightweight distro like kind, to automatically run on PRs... and then maybe the full suite for merges to main?

I fully agree.

For "preferred approach for supporting the full matrix of distros", do we see GH workflow yaml(s) the right spot to orchestrate? Or something higher-level/custom eg a go binary, etc? (This could be good discussion to also have back in https://github.com/spinkube/runtime-class-manager/issues/48)

I don't have a good answer yet. In any case, this question probably exceeds the scope of this PR; let's take it to one of the next SpinKube community meetings.


Move constants to a constants package

...as that's more specific than a general helpers package.

/lgtm

/approve

/lgtm


Create codeql.yml with Security Extended Queries

Modified the default CodeQL yml to add queries: security-extended,security-and-quality
Testing done
Default and Extended CodeQL had been run and no security issues were detected
### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


lengthUnits can be set to lapse

The <lengthUnits> element can be set to lapse. This used to be a general element used for the poolLength and lengthAsDistance, but this has been changed. It is now only used for the pool length. The poolLength, cannot be lapse.  It has to be removed. This means that the Python also has to change.

I removed the lapse option. The Python code and the XSLT will need to be updated.

Tested and okay.


[PlayState] New included hotkey

Extension name
PlayState
Feature Description
Just a reminder to add an extra default shortcut for 'Win + Alt + PrtScn'.
Screenshots
No response

Done in https://github.com/darklinkpower/PlayniteExtensionsCollection/commit/5b70ddd4c8f0ad08d896ad587a69bfba707564aa


Adjust Transaction Number for Document References Responses

Section Number
https://profiles.ihe.net/ITI/MHD/StructureDefinition-IHE.MHD.FindDocumentReferencesComprehensiveResponseMessage.html
https://profiles.ihe.net/ITI/MHD/StructureDefinition-IHE.MHD.FindDocumentReferencesResponseMessage.html
Issue
Should be ITI-67 instead of ITI-68
Proposed Change *
PR
Priority:

Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

thanks


STOR-1850: Rebase to upstream v1.14.0 for OCP 4.17

Diff to upstream v1.14.0:
https://github.com/kubernetes-csi/csi-driver-smb/compare/v1.14.0...dfajmon:rebase-1.14.0
Changes between 1.14.0 (OCP 4.17) and 1.14.0:

https://github.com/kubernetes-csi/csi-driver-smb/pull/692
https://github.com/kubernetes-csi/csi-driver-smb/pull/700
https://github.com/kubernetes-csi/csi-driver-smb/pull/709
https://github.com/kubernetes-csi/csi-driver-smb/pull/722

Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.14.0
@openshift/storage

@dfajmon Please correct the diff link, it should be: https://github.com/kubernetes-csi/csi-driver-smb/compare/v1.14.0...dfajmon:rebase-1.14.0
Also I think this repo is missing the .snyk file... @mpatlasov should we add it or is that intentional?

Also I think this repo is missing the .snyk file... @mpatlasov should we add it or is that intentional?

It was not intentional. Let's add .snyk to be uniform with other repos.

@dfajmon , we forked openshift/csi-driver-smb from upstream at 6c12ee768 (Jan 25) after it was tagged with v1.14.0 (7f74465a on Jan 16). This means that all upstream commits between 7f74465a and 6c12ee768 (which are currently present in our repo) will be lost if we merge this rebase PR. This may bring regressions :(
We can either cherry-pick all those commits from upstream and drop them on the next rebase, or we can simply wait for new tag in upstream (v1.15.0 ?). I'd prefer the latter because this rebase (PR#11) won't give us any new upstream fixes or improvements anyway.

/hold
(per https://github.com/openshift/csi-driver-smb/pull/11#issuecomment-2195583109 )

@dfajmon Based on the discussion above - when changing this rebase PR to v1.15.0 please also add the .snyk file and amend to UPSTREAM: <carry>: Add OpenShift files commit. Just copy it from some other repo - there should be an exclude rule for vendor and tests dir.

@mpatlasov newly rebased with the tag 1.15.0
/unhold

/docs-approved
/px-approved

/lgtm
/approve
/label docs-approved
/label px-approved
Great job, thank you!

/label qe-approved
Pre merge test passed with manually build driver image with the PR:
$ oc rsh -c csi-driver smb-csi-driver-controller-5bb444444c-9zggf
sh-5.1# /bin/smbplugin --ver
Build Date: "2024-08-05T07:30:37Z"
Compiler: gc
Driver Name: smb.csi.k8s.io
Driver Version: v1.15.0
Git Commit: 8e26a1e4b731fab822f45a9d2766c34c02f17eb8
Go Version: go1.22.5 (Red Hat 1.22.5-1.el9) X:strictfipsruntime
Platform: linux/amd64

# E2E Regression tests all looks good
$ go test -v -timeout=0 ./test/e2e
Ran 12 of 13 Specs in 323.231 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 1 Skipped


Use global teardown to delete e2e test  namespaces

Description
This removes the deleteNamespace from individual tests (and the afterEach hook respectively), and instead deletes all namespaces created during the test run in a global teardown method.
Since deleting namespaces is expensive, postponing it until all tests have finished should improve the speed / stability of the tests.
The first jobs still had flaky tests (mainly concerned with the workflow editor and diagram?), but seemed to be a bit faster than previous jobs.
I'll leave this on "draft" for now until I have time to compare it to other test runs, and maybe retrigger it a few times to get a better impression of how it affects the tests.

Closing this, mainly for two reasons:

the concept seems valid but deleting namespaces in global teardown seems less reliable (so there is a risk for many left-over namespaces)
tests currently work well so the potential performance gain doesn't seem to be too big an issue

Closing this, mainly for two reasons:

the concept seems valid but deleting namespaces in global teardown seems less reliable (so there is a risk for many left-over namespaces)
tests currently work well so the potential performance gain doesn't seem to be too big an issue


Is support for the OpenAI REST API in your roadmap?

We are using OpenAI REST API with vLLM. Will inferflow support OpenAI REST api later? So we can migrate to inferflow easier if inferflow is more performance than vLLM.
By the way, have yo do some performance comparison with vLLM or other LLM Inference Engine?

"When will support for the OpenAI API be available?"
Thanks!

"When will support for the OpenAI API be available?" Thanks!

We expect to add support for the OpenAI REST API in mid-March. Thank you for your patience.

加油！

We already support the OpenAI API format

Thanks!


Level and LevelFilter can now be deserialized from byte slices

This is required by some deserializers which deserialize identifiers using their binary representation. An example of one such serializer is Ron.
This implementation should be equivalent to what serde derive would implement for enum variants.

This seems reasonable to me. Agree @dtolnay?


Minor: Some html fixes in Streams DSL documentation

duplicate id
duplicate opening  element
surplus closing  tag

Built website and checked working links for duplicate id.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mimaison - as you reviewed my last website related PR - maybe you are the right person for this as well? :)

Thanks @soenkeliebau for the PR! I'm not a Streams pro but as far as I can tell, we're only fixing the layout here so I'll take a look.

Thanks @mimaison !
You are indeed correct, I split out the content change during which I noticed these minor things into a separate PR to make reviewing easier.


Support auth

For better management, we need to have auth. We can put password/auth info in config file, instead of using the native auth in redis itself.

closed via #52


DB-first generation leads to incorrect DeleteBehavior mapping

All my relations have ON DELETE set to RESTRICT.
When generating code with a DB-first approach using:
dotnet ef dbcontext scaffold "<connstring>" Npgsql.EntityFrameworkCore.PostgreSQL
in Context.cs I get:
entity.HasOne(d => d.ContactPerson)                       .WithMany(p => p.Registrations)                       .HasForeignKey(d => d.ContactPersonId)                       .OnDelete(DeleteBehavior.ClientSetNull)                       .HasConstraintName("contact_persons_fkey");

Which version of Npgsql.EntityFrameworkCore.PostgreSQL are you using?

Latest from NuGet

This behavior actually comes from EF Core rather than Npgsql. I admit I'm not sure what the reasoning is, I opened https://github.com/aspnet/EntityFrameworkCore/issues/12661 for clarifications.

Keeping open in backlog to track possible modifications which need to be done on our side after aspnet/EntityFrameworkCore#12661 is done.


[BugFix] fix #6605: thread safety of workgroup queue

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #6605
Problem Summary(Required) ：

DriverQueueWithWorkGroup::size could be accessed from two thread: executor thread and metric thread, but without a lock, which is not safe.

@Mergifyio backport branch-2.2

should be also add a lock for QuerySharedDriverQueue ?

should be also add a lock for QuerySharedDriverQueue ?

Good idea.


for specs, ensure is_appliance is not cached

in MiqEnvironment, we cache some of the environment answers
this change uncaches those answers to get the loggers specs running
fixes issue introduced in #21724 that only fails when running tests on a mac
rspec --seed 19491 spec/lib/vmdb/loggers_spec.rb

  1) Vmdb::Loggers.create_logger in an appliance environment sets the log file owner and permissions
     Failure/Error: raise "Not yet supported platform: #{Sys::Platform::IMPL}"

     RuntimeError:
       Not yet supported platform: macosx

rspec ./spec/lib/vmdb/loggers_spec.rb:181 # Vmdb::Loggers.create_logger in an appliance environment sets the log file owner and permissions

push:

removed custom environment variable unsetter and merged into EvmSpecHelper.clear_caches

@kbrock Which spec are you seeing fail?  miq_environment_spec runs fine for me on Mac:
$ be rspec spec/lib/miq_environment_spec.rb
** Using session_store: ActionDispatch::Session::MemoryStore
** ManageIQ master, codename: Oparin

Randomized with seed 58352
....................

Finished in 0.29444 seconds (files took 6.98 seconds to load)
20 examples, 0 failures

Randomized with seed 58352

If it's sporadic do you have a failing seed?

Maybe it is only the which change that actually fixed the issue.
I'll undo the variable definition and go from there.
It looks like we do not use defined? and tend to use .nil? for @cache_variables

Maybe it is only the which change that actually fixed the issue.

Yeah this is my guess also

What I don't understand is that, locally, the which change doesn't change anything for me...I can even delete the entire which method and the specs still pass, which is why I was asking:

Which spec are you seeing fail? miq_environment_spec runs fine for me on Mac:

I see you updated the OP, and I can confirm that vmdb_loggers_spec also fails for me on the Mac:
$ be rspec --seed 19491 spec/lib/vmdb/loggers_spec.rb
** Using session_store: ActionDispatch::Session::MemoryStore
** ManageIQ master, codename: Oparin

Randomized with seed 19491
..................................F..................

Failures:

  1) Vmdb::Loggers.create_logger in an appliance environment sets the log file owner and permissions
     Failure/Error: raise "Not yet supported platform: #{Sys::Platform::IMPL}"

     RuntimeError:
       Not yet supported platform: macosx
     # ./lib/miq_environment.rb:126:in `which'
     # ./lib/miq_environment.rb:113:in `supports_command?'
     # ./lib/miq_environment.rb:51:in `supports_systemd?'
     # ./lib/vmdb/loggers.rb:88:in `create_journald_logger'
     # ./lib/vmdb/loggers.rb:77:in `create_broadcast_logger'
     # ./lib/vmdb/loggers.rb:39:in `block in create_logger'
     # ./lib/vmdb/loggers.rb:36:in `tap'
     # ./lib/vmdb/loggers.rb:36:in `create_logger'
     # ./spec/lib/vmdb/loggers_spec.rb:188:in `block (4 levels) in <main>'
     # ./spec/lib/vmdb/loggers_spec.rb:15:in `in_appliance_env'
     # ./spec/lib/vmdb/loggers_spec.rb:179:in `block (4 levels) in <main>'
     # /Users/jfrey/.gem/ruby/2.7.4/gems/webmock-3.14.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <main>'

Gah I merged it but didn't look at the commit message which makes no sense now...oh well


[stable/drone] Add support for Drone License Key

Currently adding a Drone License Key requires either patching it in or
manually creating the license key secret and creating the necessary
environment varibles and volumes after a helm deploy. By adding this in
a non-intrusive way, users of the CE edition of Drone should not be
affected by this change while allowing enterprise users the ability to
add thier license keys during a deploy or by secret reference easily
Signed-off-by: Danny Grove<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/retest

/retest

/retest


Minimize to SystemTray not working

From ED Forums:
_Hi. On Options/Settings window, I click "Minimize To System Tray", but it won't do that.
I deleted AppData folders. I re-saved my commandkeys etc. etc., but everytime I check Settings, "Minimize" option seems unchecked (or not saved)._
https://forums.eagle.ru/topic/115280-dcsflightpanels-dcsfp-thread-saitek-pro-flight-panels-amp-dcs/?do=findComment&comment=4629649
Tested on my end too. with same results. Checkbox not saved. (not in user or admin mode)

Check https://github.com/DCSFlightpanels/DCSFlightpanels/releases/tag/4.2.30

works again. Thank you!


Percent of total dimension table

Add percent of total in dimension table.
Follow up to https://github.com/rilldata/rill/pull/2751 -- recommend merging that before this, and then reviewing this, since this builds off changes in that PR it will make the review much simpler.
remember that per the spec, you will need to add valid_percent_of_total: true to any measures for which you want to see the percent of total
PRD: https://www.notion.so/rilldata/Display-percent-of-total-metrics-in-dashboards-3764999f8d0d41c7832484d452aef56a

@djbarnwal , the idea of the dimension table that we discussed during design reviews is that all columns would be shown, regardless of toggle status on the leaderboard view. The toggle is only for the leaderboards because there's only one context column and they can choose what they want to populate it with.
I agree that the tooltip wording is not super clear, do you have an alternate proposal that might make more sense to the user? Would it make sense to direct them to change the dashboard yaml and add valid_percent_of_total: true?


[funimation] establish session before logging in

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[x] Bug fix
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Added an initial HTTP GET request with the login URL before attempting
to log in. This allows Funimation to set any session cookies it
requires. This request is necessary for Funimation to render the login
page or to accept login requests.
Fixes #10639
Fixes #10629

Current code from master works fine for me at the moment. Can you try?

Current release build 2016.09.15 works fine for my referenced issue, but can't double check with the old version right now.

2016.09.15 has no funimation changes.

And yet I'm currently downloading the video that didn't work for me before with that version. So, a regression on Funis part?

I'm just going to guess Funimation undid whatever it did before?

Just verified on my computer as well. This should no longer be needed.


Add EventBridge Archive CRUD endpoints

I also added CloudFormation functionality and hope I did right, first time for me 😄
I also added a comment regarding nested dict matching for event patterns, which I didn't add yet. I think the PR is already big enough.

Re-opening this to restart our new CI

Re-opening this to restart our new CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@38124ab). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3617   +/-   ##
=========================================
  Coverage          ?   94.36%
=========================================
  Files             ?      420
  Lines             ?    46066
  Branches          ?        0
=========================================
  Hits              ?    43469
  Misses            ?     2597
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38124ab...98ab733. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@38124ab). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3617   +/-   ##
=========================================
  Coverage          ?   94.36%
=========================================
  Files             ?      420
  Lines             ?    46066
  Branches          ?        0
=========================================
  Hits              ?    43469
  Misses            ?     2597
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38124ab...98ab733. Read the comment docs.

This is now part of moto >= 1.3.17.dev225

This is now part of moto >= 1.3.17.dev225


Move the Killercoda Demo to Keptn Repo

As discussed in today's community meeting have to move the Killercoda demo to the Keptn repo.
Original Repo: https://github.com/afzal442/keptn-pg-killerway
Meeting minutes: https://docs.google.com/document/d/1y7a6uaN8fwFJ7IRnvtxSfgz-OGFq6u7bKN6F7NDxKPg/edit#
cc- @DavidPHirsch @agardnerIT @bradmccoydev

Fantastic. Thanks for creating this. You beat me to it!
Also linking this issue I before I saw this: https://github.com/keptn/community/issues/226

Since Keptn V1 has reached EOL on December 22nd, 2023, this issue has been closed.


Please provide documentation of busboy with using promises

Please provide documentation of busboy with using promises

busboy does not utilize Promises, much less callbacks. It's pretty much all events, which Promises don't handle well because they're not meant to be resolved multiple times and any event could be triggered at any time.


lidar_euclidean_cluster_detect output topics are not transformed properly.

/label ~bug

Required information:

Operating system and version: Ubuntu 18.04
Autoware installation type: Source
Autoware version or commit hash OAP7
ROS distribution and version: Ros melodic
ROS installation type: APT
Package or library, if applicable: lidar_euclidean_cluster_detect

Description of the bug

lidar_euclidean_cluster_detect output topics are not fully transformed.
CloudCluster in /detection/lidar_detector/cloud_clusters
Transformed properly :

min_point
max_point
avg_point
centroid_point

Not transformed :

convex_hull
bounding_box

Because this message is not TFed properly the messages published in /detection/lidar_detector/objects are also wrong :
DetectedObject in /detection/lidar_detector/objects
Transformed properly :

None

Not transformed :

pose
convex_hull

Steps to reproduce the bug

Configure lidar_euclidean_cluster_detect output frame different from the input frame.
Publish pointclouds to the /points_raw topic.
Open rqt and notice that some data is not tfed.

Screenshots

The points are still in Lidar frame and not map frame, even if the header says so ! It really looks like a bug.
Additional information

I have corrected the bug.
One question though, what is the best way to TF a Point32 ? Because the TF listener has no transformPoint32 function.
Thanks !

@MaxandreOgeret geometry_msgs/Point is recommended over geometry_msgs/Point32 due to the increased precision. To that end, tf2_geometry_msgs supports conversion of geometry_msgs/Point and geometry_msgs/PointStamped to/from tf2 types and can then have transforms applied easily.


[Scope Change Request] - DocExchServiceAuth.Page - GetAuthCode

We would like to have the scope changed for the following procedure:
Object: DocExchServiceAuth.Page
Procedure: GetAuthCode
Reason: In extensions that uses the universal code, it should be possible to use the default OAuth logic. For that, the "OnPrem" flag must  be removed from the following procedure.
[Scope('OnPrem')]
[NonDebuggable]
procedure GetAuthCode(): Text
begin
    exit(AuthCode);
end;

Sorry in understand your argument, but for security issues this is both marked as [Scope('OnPrem')] and
[NonDebuggable]


customization of django-admin panel (server-side)

Add 2077 Collective brand assets (Name & Logo)
Customize the panel to align with 2077 Collective's theme

Great job @S13G . Thank you for your contribution.


ObsoleteAttribute on method parameters

Hi,
using the Apple Store Connect API I found out that Kiota generates ObsoleteAttribute on methor parameters. That is, unfortunately, invalid code see ObsoleteAttribute.
This PR should fix it

The integration test uses a snippet from the Apple API I used for testing. It's OK for me to remove it

The integration test uses a snippet from the Apple API I used for testing. It's OK for me to remove it

I'd like @andrueastman opinion on this one, but as it is, I think we should remove it.

Done

There was a merge conflict in the CHANGELOG.md


Tooltip fix

Fix for #141

Is there a plan when the change will be integrated into the Pro version?


feat: export numG and qSize

This permit to create a group without using WithContext.
As cancel is nil, errgroup will not send a context close at first error.

@guilhem Apologies for the egregious delay in responding to you. Thank you for the PR.
One of the reasons that numG and qSize are unexported is because we don't want those field values to change during the lifetime of the Group... or at a minimum, updating those fields should be done atomically.

As cancel is nil, errgroup will not send a context close at first error.

Is this not desirable?

This permit to create a group without using WithContext.

Can you elaborate some more on the issue you're facing that this PR resolves? Thank you.


Expand/collapse all node options

Adds buttons in the Database Projects viewlet to expand all nodes and collapse all nodes. "Expand All" expands all nodes to one level. "Collapse All" does not preserve the state of what was open when collapsing.
When a project is opened, opens with only one level expanded. (Previously, all levels of the project were initially expanded.)

This PR fixes #10979

Coverage increased (+2.5%) to 40.421% when pulling 4a336d4cba7d289be75ba2926bed6e17ab8a25da on dev/t-anjaga/expand-collapse-nodes into 858c1e826d5d0a56707b98b3bcd744c4bb152402 on main.


Produce HTML code for xdai bridge

Following your original design (on the right):
Bridge-DAI-to-xDAI-Storyboard.pdf
Can't wait to have this working inside the wallet!

https://github.com/AlphaWallet/TokenScript/pull/140


mismatched v4 variant data between downloaded file and web-displayed info

16
2089662

For concerns about data, check the frequently asked questions
(https://gnomad.broadinstitute.org/help#frequently-asked-questions) or
send an email to<EMAIL_ADDRESS>
-->
What you did:

What you expected to see after you did that:

What you actually saw after you did that:

https://gnomad.broadinstitute.org/variant/16-2089662-G-A?dataset=gnomad_r4
data does not match what is found when downloading variants for an entire gene

gnomAD_v4.0.0_ENSG00000008710_2023_11_17_10_34_57.csv

Chromosome
Position
rsIDs
Reference
Alternate
Source
Filters - exomes
Filters - genomes
Transcript
HGVS Consequence
Protein Consequence
Transcript Consequence
VEP Annotation
ClinVar Clinical Significance
ClinVar Variation ID
Flags
Allele Count
Allele Number
Allele Frequency
Homozygote Count
Hemizygote Count
Allele Count Remaining
Allele Number Remaining
Homozygote Count Remaining
Hemizygote Count Remaining
Allele Count Admixed American
Allele Number Admixed American
Homozygote Count Admixed American
Hemizygote Count Admixed American
Allele Count European (Finnish)
Allele Number European (Finnish)
Homozygote Count European   (Finnish)
Hemizygote Count European   (Finnish)
Allele Count Middle Eastern
Allele Number Middle Eastern
Homozygote Count Middle Eastern
Hemizygote Count Middle Eastern
Allele Count European   (non-Finnish)
Allele Number European   (non-Finnish)
Homozygote Count European   (non-Finnish)
Hemizygote Count European   (non-Finnish)
Allele Count South Asian
Allele Number South Asian
Homozygote Count South Asian
Hemizygote Count South Asian
Allele Count Ashkenazi Jewish
Allele Number Ashkenazi Jewish
Homozygote Count Ashkenazi Jewish
Hemizygote Count Ashkenazi Jewish
Allele Count East Asian
Allele Number East Asian
Homozygote Count East Asian
Hemizygote Count East Asian
Allele Count African/African   American
Allele Number African/African   American
Homozygote Count African/African   American
Hemizygote Count African/African   American

16
2089662
rs557909051
G
A
gnomAD Exomes,gnomAD Genomes
PASS
PASS
ENST00000262304.9
c.*65C>T

c.*65C>T
3_prime_UTR_variant

389
1533642
0.000254
0
0
21
59270
0
0
0
50866
0
0
8
57582
0
0
0
4962
0
0
302
1072110
0
0
14
79038
0
0
3
29870
0
0
10
39018
0
0
17
72884
0
0

Apologies, I thought i typed this up when i first opened the issue but it disappeared.  I have found yesteday and today that when you download a file of variant data for an entire gene, the data in that file for specific values does not match the data shown on the web page for the same variant.  specifically the East asian, south asian, middle eastern, european non-finnish allele count and or allele number do not match for any given variant between the download and the website, although the total AC and AN do match and the remaining, african, and admixed american and finnish do match. this has been seen in 3 different genes, myh7, pkd1 and cep290.

Adding link to Slack thread to keep info in one place: https://atgu.slack.com/archives/CNL7NA6H2/p1700496608050559

Thanks for filing this issue @glennm51, sorry for the confusion. I will start to look into this tomorrow.
Also, thanks so much for the detailed description -- it's much appreciated.


[FEATURE] Offer Windows specific executable setup package

This issue is created following suggestion from @ZaLiTHkA in #175 to have a dedicated issue on Windows specific executable setup package (standalone .exe installer) available for Sourcegit.
The main point, although already mentioned in related issue referenced above, is referenced again here as follows:

In addition, some actions that help with user experience can also be achieved using an installer, such as the ability to create a desktop shortcut as well as add a new start menu entry when installation completes, so that the user can have multiple ways to launch the program out of the box.

With some insights from @ZaLiTHkA:

in my opinion, since this issue is technically resolved (by making SourceGit available through Winget), perhaps a separate issue could be opened for a Windows-specific executable setup package? there are numerous systems that can do this, some of which are OSS, and some of which can even be done through GitHub Actions..

https://github.com/sourcegit-scm/sourcegit/issues/312#issuecomment-2268709698 @aikawayataro

Here is a closed PR https://github.com/sourcegit-scm/sourcegit/pull/202 which you can check.

It's not recommanded to use a standalone installer without self-update feature.


Also, Still Work In Progress?

I would like more info on what this app does too. Are you still working on it?

@RogueMaster I've added proper README for the repo. Thank you for the issue and making me doing it :D


ENH: add new representations for Sakurai and Mikota matrices and move them to public API

Is your feature request related to a problem? Please describe.
Sakurai and Mikota matrices are being used in scipy for benchmarking and testing:
https://github.com/scipy/scipy/blob/c8069d94d5b2eb33193977b3744ed36105cc4cf7/benchmarks/benchmarks/sparse_linalg_lobpcg.py#L32
https://github.com/scipy/scipy/blob/c8069d94d5b2eb33193977b3744ed36105cc4cf7/scipy/sparse/linalg/_eigen/lobpcg/tests/test_lobpcg.py#L54
https://github.com/scipy/scipy/blob/c8069d94d5b2eb33193977b3744ed36105cc4cf7/benchmarks/benchmarks/sparse_linalg_lobpcg.py#L14
and for lecture notes, e.g., https://github.com/glemaitre/scipy-lecture-notes/blob/60baf1b669842637b9494674cd84c2a00522e4b1/advanced/scipy_sparse/examples/lobpcg_sakurai.py#L2

Every time their definition is being repeated rather than called from a single public source.
Their current definitions only construct matrices in one format, thus limiting their use.

Describe the solution you'd like.

Define Sakurai and Mikota matrices with public API, e.g., in  https://github.com/scipy/scipy/blob/c8069d94d5b2eb33193977b3744ed36105cc4cf7/scipy/linalg/_special_matrices.py
Add various matrix formats - sparse, banded, and as matrix-free callable objects that perform the dot-product of the matrix by an input matrix without constructing the matrix explicitly.
Use these new matrix formats for benchmarking and testing.

Describe alternatives you've considered.
No response
Additional context (e.g. screenshots, GIFs)
See also [gh-18940]

Some context from #18954 for why we don't want to do the "public API" part of this issue:

@rkern: Laplacians have real applications in addition to testing and benchmarking, so I'm happy enough to keep it in the public API. The matrices from Mikota and Sakurai do not, AFAICT.
I am -1 on putting them in the public API. It's great for each to have one common implementation that we use in both tests and benchmarks rather than repeating the implementation, so it's fine that it exists inside of scipy itself, but they are not the kind of thing that we want to support in the public API. That's just a project policy choice. I'm glad your MATLAB implementations are popular in their own right, but that's not the kind of functionality that scipy exists to provide. We focus on other things.

This was the summary after some discussion where my opinion was also a -1 on putting things in the public API, if there isn't a strong motivating use case (beyond just benchmarking the code we have).


[Bug] Fix InstallPluginCommand to use proper key signatures

The public key has changed since the initial release. This PR fixes the public key and uses the .sig files that are published to the artifacts site.
closes #996

start gradle check

Surprise.... more jenkins flakiness...
Gradle_Check/search/distribution/bwc/minor/build/bwc/checkout-1.x/distribution/archives/linux-tar/build/install/opensearch-1.1.0-SNAPSHOT, -Dopensearch.path.conf=/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/qa/rolling-upgrade/build/testclusters/v1.1.0-0/config, -Dopensearch.distribution.type=tar, -Dopensearch.bundled_jdk=true]
» [2021-09-09T21:42:25,447][INFO ][o.o.i.r.ReindexPlugin    ] [v1.1.0-0] ReindexPlugin reloadSPI called
» [2021-09-09T21:42:25,486][INFO ][o.o.i.r.ReindexPlugin    ] [v1.1.0-0] Unable to find any implementation for RemoteReindexExtension

restarting

start gradle check

Are we going to backport this to both 1.x and 1.0 branches?

yes. I'll open backport PRs.


The line in the middle of the editor shouldnt be default

That big ugly line in the middle of the editor shouldnt be on by default, it should be OFF.

Thanks for the feedback. We disagree and we'll be leaving the default the way it is.
Thank you for contributing!
We require the issue template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests. Please open a new issue and fill out the template for us.
Thanks for understanding and meeting us half way :grinning:


Far package not portable

The Far package doesn't persist user configuration which means that after an upgrade the configuration is lost. The files in question are Far.exe.ini and FarMenu.ini.

ScoopInstaller/Main#1050


Dev practices

This PR adds support for additional code validators. One such validator prevents people from using std::cout and printf. Instead, they should only use the LOG_INFO and similar methods.


Block probe-side scan until build-side dynamic filtering is ready

By default, we wait up to 1s for the build-side filters to be ready, to allow more efficient probe-side scan.
If the filters are not ready, we fallback to the previous behaviour (use current filters without blocking probe-side).
This feature can be configured using:
SET SESSION dynamic_filtering_probe_side_blocking_timeout='10s';

To disable, use:
SET SESSION dynamic_filtering_probe_side_blocking_timeout='0s';

Using this feature, we can add (more) deterministic integration tests for dynamic filtering, e.g.:
https://github.com/prestosql/presto/blob/cb6ca89eca386cffb7c84933df5b22a786a03ee2/presto-memory/src/test/java/io/prestosql/plugin/memory/TestMemorySmoke.java#L95-L108

To be landed after: https://github.com/prestosql/presto/pull/1072

However, I'm thinking that it should be the connector that decides whether to wait for dynamic filter and for how long.

SGTM - I wasn't sure about adding a new connector API, so I've tried to add the minimal changes to the engine required by this feature.
I would be happy to adapt the PR to allow the connector to decide when to block and for how long.

I would be happy to adapt the PR to allow the connector to decide when to block and for how long

This requires making DynamicFilter part of an SPI. We can still fallback to the old method with Supplier dynamic filter.

Rebased over latest master - to resolve a merge conflict.

Rebased over latest master to resolve a merge conflict.

Other connectors might have fixed and small amount of splits (e.g JDBC connectors) so it's preferred to wait for dynamic filter even much longer than 1 second global default. It could be huge difference if JDBC connector issues query with or without dynamic filter.

I was not following, so this could have been answered already, please forgive me question in that case.
JDBC connectors to not consume the dynamic filter in any way. They just provide RecordCursor and let the engine handle the heavy lifting.
How would DF help a JDBC connector?
Second, are we positive this will not impact low latency queries? Ultimately, sleeping 1s seems to be heuristic and there seems to be a potential of a regression?

Updated the PR to use DynamicFilter in ConnectorPageSourceProvider.
Please re-review :)

Many thanks for the review, will fix the issues and update the PR.

Updated the PR to ae4a9e6 - please re-review :)

Ping :)

Many thanks for the review, will fix soon.

Cherry-picked the commits from https://github.com/prestosql/presto/pull/4946, fixed the comments above and rebased.

there is a conflict. Please rebase. I will merge tomorrow then

Rebased over latest master to resolve the conflict - many thanks!

Thanks!
Fixed the comments and force-pushed d5bb8c84c7.

merged, thanks!

Much appreciated :)


keystore: paralellize key generation

This got to my attention when @parithosh was generating a lot of keys for testnet purposes. It was taking him a long time.
This change will benefit from all your CPUs and paralellize the creation of the keystores.
Sample timings on my local machine (4 cores with hyperthreading) when creating 1000 keys from a mnemonic:
$ time eth2-val-tools-old keystores --source-mnemonic="$MNEMONIC" --source-min=0 --source-max=1000 --prysm-pass lol --out-loc test1
# 285.51s user 1.52s system 101% cpu 4:43.79 total

$ time ./eth2-val-tools keystores --source-mnemonic="$MNEMONIC" --source-min=0 --source-max=1000 --prysm-pass lol --out-loc test2
# 620.00s user 1.00s system 752% cpu 1:22.48 total

As you can see, before it took 4min 43sec and on this branch it took 1min 22sec.

@protolambda I've noticed that you've added the --insecure flag which make it even go faster, that's cool! I've updated the PR with your new changes and solved the code conflicts. I ran the following test locally on my machine:
time ./eth2-val-tools      keystores --source-mnemonic="$MNEMONIC" --source-min=0 --source-max=100000 --prysm-pass Publ1cS3cret --out-loc test_new --insecure
# 666.36s user 42.88s system 715% cpu 1:39.15 total
time ./eth2-val-tools-prev keystores --source-mnemonic="$MNEMONIC" --source-min=0 --source-max=100000 --prysm-pass Publ1cS3cret --out-loc test_old --insecure
# 390.66s user 16.93s system 126% cpu 5:21.41 total

# verfiy pub keys are ordered the same
diff test_old/pubkeys.json test_new/pubkeys.json
# returns nothing, so we're good

Generating 100.000 insecure keys took 1min 39sec compared to previously 5min 21sec


refactor: use signals in tabs component

Uses signals in tabs component. Both for @Input and to replace internal state variables. Much cleaner implementation overall!
The final magic has been using afterRenderEffect in order to run an effect after rendering, so scrolling into selected tab happens after everything is set.

#890  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


mergeCommonModels function doesn`t merge required field

Describe the bug
mergeCommonModels doesn`t merge required field
How to Reproduce
use allOf with objects with required properties
Expected behavior
mergeCommonModels does merge required fields

add
        if(mergeFrom.required instanceof Array) {
            mergeTo.required = [...(mergeTo.required || []), ...mergeFrom.required];
        }

to line 154 in CommonModel

Good catch @czlowiek488! Do you want to add a PR fixing this? 🙂

Sorry, I don`t have time now and in nearest future. I must finish my generator ASAP.

@czlowiek488 I provided a fix for this bug, feel free to review it if you have the time of course!

@all-contributors please add @czlowiek488 for bug


Creating new API fails with "API not found"

If I try to create new API I get an error message: API "MyAPI" not found.
The API is actually created but the page is not refreshed and the error message is shown. I need to either create another API or refresh the browser to see the new API in the list.
I remember this worked correctly in 1.0.0. It seems to be a regression in 1.0.1.

I am having the same problem, how solve this problem? http://puu.sh/fRfXv/1ffd365516.png :(

Hello,
i had the same issue when i use php version 5.4.36-0+deb7u3.
After update php I can normal create DB-Adapter and APIs
and i try to use HipHop VM 3.5.0. It works too.

I created a new API yesterday worked with it all day..left to go home for the evening.. this morning.. saw the following notification:
SECURITY UPDATES (2.3.6)
ZF2015-03 Zend\Validator\Csrf..recommend upgrading immediately.
I updated.. and then 'API NOT FOUND'
Ran update dependencies..

Removing zendframework/zendframework (2.3.6)
Installing zendframework/zendframework (2.3.7)

Now works like a charm! APIs all good to go..
Just sharing :)

I've just done an update and getting the same annoying mesage API "gcmag" not found. I tried updating the framework to "2.3.7" and still getting the same error. Was there ever a final fix for this? my composer file is a per below. Did i mention i'm a newbie with "apigility" :-)
Any help is much appreciated.
{
"name" : "zfcampus/zf-apigility-skeleton",
"description" : "Skeleton Application for Apigility",
"require" : {
"php" : ">=5.3.23",
"zendframework/zendframework" : ">=2.3.7,<3.0.0",
"zfcampus/zf-apigility" : "~1.0",
"zfcampus/zf-apigility-documentation" : "~1.0",
"zfcampus/zf-development-mode" : "~2.0",
"zfcampus/zf-rest": "~1.0-dev",
"zfr/zfr-cors" : "1.*",
"sunra/php-simple-html-dom-parser": "v1.5.0"
},
"require-dev" : {
"zendframework/zftool" : "dev-master",
"zendframework/zend-developer-tools" : "dev-master",
"zfcampus/zf-apigility-admin" : "~1.0",
"zfcampus/zf-apigility-welcome" : "~1.0",
"zfcampus/zf-deploy" : "~1.0",
"zfcampus/zf-rest": "~1.0-dev",
"zfr/zfr-cors" : "~1.0",
"zend/zend-studio-development-mode" : "~1.0"
},
"support" : {
"email"<EMAIL_ADDRESS>"irc" : "irc://irc.freenode.net/apigility",
"source" : "https://github.com/zfcampus/zf-apigility-skeleton",
"issues" : "https://github.com/zfcampus/zf-apigility-skeleton/issues"
},
"keywords" : [ "api", "apigility", "framework", "zf2" ],
"extra" : {
"branch-alias" : {
"dev-master" : "1.0-dev",
"dev-develop" : "1.1-dev"
}
},
"config" : {
"process-timeout" : 5000
},
"license" : "BSD-3-Clause",
"type" : "library",
"homepage" : "http://apigility.org/"
}

Depending on the hardware you're using, it's indeed the same annoying issue related to hard drives being slow to write the generated files.
This will no longer happen with the upcoming version 1.1 of Apigility. Stay tuned :)
Julien.

Le 15 avr. 2015 à 08:40, rrubio<EMAIL_ADDRESS>a écrit :
I've just done an update and getting the same annoying mesage API "gcmag" not found. I tried updating the framework to "2.3.7" and still getting the same error. Was there ever a final fix for this? my composer file is a per below. Did i mention i'm a newbie with "apigility" :-)
Any help is much appreciated.
{
"name" : "zfcampus/zf-apigility-skeleton",
"description" : "Skeleton Application for Apigility",
"require" : {
"php" : ">=5.3.23",
"zendframework/zendframework" : ">=2.3.7,<3.0.0",
"zfcampus/zf-apigility" : "~1.0",
"zfcampus/zf-apigility-documentation" : "~1.0",
"zfcampus/zf-development-mode" : "~2.0",
"zfcampus/zf-rest": "~1.0-dev",
"zfr/zfr-cors" : "1.*",
"sunra/php-simple-html-dom-parser": "v1.5.0"
},
"require-dev" : {
"zendframework/zftool" : "dev-master",
"zendframework/zend-developer-tools" : "dev-master",
"zfcampus/zf-apigility-admin" : "~1.0",
"zfcampus/zf-apigility-welcome" : "~1.0",
"zfcampus/zf-deploy" : "~1.0",
"zfcampus/zf-rest": "~1.0-dev",
"zfr/zfr-cors" : "~1.0",
"zend/zend-studio-development-mode" : "~1.0"
},
"support" : {
"email"<EMAIL_ADDRESS>"irc" : "irc://irc.freenode.net/apigility",
"source" : "https://github.com/zfcampus/zf-apigility-skeleton",
"issues" : "https://github.com/zfcampus/zf-apigility-skeleton/issues"
},
"keywords" : [ "api", "apigility", "framework", "zf2" ],
"extra" : {
"branch-alias" : {
"dev-master" : "1.0-dev",
"dev-develop" : "1.1-dev"
}
},
"config" : {
"process-timeout" : 5000
},
"license" : "BSD-3-Clause",
"type" : "library",
"homepage" : "http://apigility.org/"
}
—
Reply to this email directly or view it on GitHub.

Hi Julien,
Thanks for getting back, really appreciate it and looking forward to the new version ;-)
In the meantime though? is there a work around? you are right.. I am on SSD Mac. So the problem is on my side.


Country code serialization strings values are lower case

Hi,
The Country Code serialization strings values that are defined on the library are of lower case.
https://github.com/BitzArt/OCPI.Net/blob/80f189a3727fdc64187fb6749e78d0134e55266e/src/OCPI.Net.Core/Enums/!General/CountryCode.cs#L5
From what I see on the OCPI protocol (version 2.2.1), the Country Code values should be formatted according to the ISO-3166 alpha-2 protocol:

https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes
Meaning, Country Codes values should of upper case.
WDYT?
Did other clients of the library also raised this issue?
Currently, it's a problem for us to use the library OCPI modules objects, since the OCPI parties we are interacting with don't accept the lower case Country Codes.
Would be happy to hear your feedback regarding this.
Thanks,
Lior

@LiorBenAri This is true. Fixed in a new version 0.14.2. Pls let me know if this resolves the issue.

issue resolved, thank you @YuriyDurov!


Write a Python program to find largest number in an array

Description
Write a Python program to find largest number in an array
Input  : [1, 2, 3, 4, 5]
Output : 5

How to contribute

Save the solution in program/find-largest-number-in-an-array.py file
Add find-largest-number-in-an-array.py file in find-largest-number-in-an-array folder

!assign


Color logging

I can create this file:
from absl import logging
logging._warn_preinit_stderr = 0
logging.warning('Worrying Stuff')

but it outputs in black and white. Is color an option?

We're have no plans to detecting terminals and adding ansi color codes to terminal based log output ourselves, sorry.
Perhaps look into whether https://pypi.org/project/coloredlogs/ or something similar would do what you desire.

@gpshead thanks that is a good one - also these seem to do the job

https://github.com/metachris/logzero
https://github.com/borntyping/python-colorlog


MINOR: fix the soft link created by ducktape when running system test…

If we run system tests by container, the soft link created by ducktape references to path inside container. This PR adds a tiny function to correct soft link.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma Could you take a look at this PR? Fixing the broken soft link can help jenkins archive the reports (My jenkins run system tests by docker daily)


osx_private_sdk: reduce output size and remove it from runtime closures

reduces osx_private_sdk output size from 350MB to 0.5MB
gets rid of it completely in runtime

This is awesome, thanks!! This isn't a mass rebuild, right?

It'd guess it's 100-500 rebuilds, but let's wait on @grahamc bot :-)

Estimating rebuild amount by counting changed Hydra jobs.
   2011 x86_64-darwin

Do we need a larger bucket than 500+?
On Thu, Nov 2, 2017 at 09:56 Daiderd Jordan<EMAIL_ADDRESS>wrote:

Estimating rebuild amount by counting changed Hydra jobs.
2011 x86_64-darwin
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/31086#issuecomment-341356396, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAErrCg-U3MMZ854vUblVtyT6bEANvgyks5syYPFgaJpZM4QOLGv
.

why doesn't bot just comment the exact numbers? It would be as annoying as mention bot and people can add it to ignore list

@grahamc maybe bot could publish a gist for status check :) but you probably already have it planned :)

@grahamc I just didn't notice the bot added the labels before posting. Don't know if another label would be useful, but 500-20k is a pretty big gap 😄

Anyway, it might make sense to send this to staging, especially with Hydra acting up as it has been recently. Otherwise it looks great!

Thanks!