Enhancement: Add plugin for grafana loki

Summary
Grafana Loki is a compact log aggregator. Logs of different sources (files, streams, etc.) are ingested by a client (e.g., Grafana Promtail) and pushed to the Loki API. The logs are indexed by labels, not content. Loki stores the data as chunks on the local file system or an S3 bucket. The stored data can be visualized via Grafana or pulled from the Loki API for use in a different application.
I played around with this as a weekend project to look for a simpler alternative to the ELK stack. There are already multiple agent solutions to ingest logs from k8s pods or docker compose services but I wanted to learn more about how the API works and how I can use it for custom logging of timeseries data.
My question is whether this would be desirable to add it to the litestar library as a contrib package. Since the client would not add any new dependencies it would be just another "nice to have".
Basic Example
I wrote a Loki client that can manage a queue to send messages concurrently to the main workflow (to not block the route handler). It also offers a method to send a message immediately instead of queueing it. I wrote a minimal litestar demo that showcases its use. I also appended my docker compose file that I used to set up a Grafana and Grafana loki instance.
Note: I use loguru here for convenvience, it is not essential to the client.
Loki Client
import asyncio
import copy
from datetime import datetime
import time
import threading
from dataclasses import dataclass, field, InitVar
from contextlib import asynccontextmanager

import httpx
from loguru import logger
from litestar import Litestar
from litestar.config.app import AppConfig
from litestar.di import Provide
from litestar.plugins import InitPluginProtocol

@dataclass
class LokiValue:
    """Container for a timestamped log line."""
    time_value: InitVar[int | datetime]
    line: str
    time_ns: str = field(init=False)

    def __post_init__(self, time_value: int | datetime):
        if isinstance(time_value, int):
            self.time_ns = str(time_value)
        else:
            self.time_ns = str(time_value.timestamp() * 1e9)

    def loki_format(self) -> list[str]:
        data = [self.time_ns, self.line]
        return data

    @classmethod
    def timestamped_line(cls, line: str):
        return cls(
            time_value=time.time_ns(),
            line=line,
        )

@dataclass
class LokiMessage:
    """Container for a full Loki message including labels and one or more values"""
    labels: dict[str, str]
    values: list[LokiValue]

    def as_payload(self):
        data = {
            "streams": [{
                "stream": self.labels,
                "values": [v.loki_format() for v in self.values]
            }]
        }
        return data

@dataclass
class LokiMessageTemplate:
    """Convenience class to pre-define a set of labels and use it to create Loki messages ad-hoc
    without needing to set the labels again and again.
    """
    labels: dict[str, str]

    def to_message(self, values: list[LokiValue]) -> LokiMessage:
        return LokiMessage(
            labels=self.labels,
            values=values
        )

    def timestamped_message(self, line: str, extra_labels: dict[str, str] = None):
        value = LokiValue.timestamped_line(line)
        if extra_labels:
            labels = copy.copy(self.labels)
            labels.update(extra_labels)
            return LokiMessage(
                labels=labels,
                values=[value]
            )
        else:
            return self.to_message([value])

class LokiQueueHandler:
    def __init__(
            self,
            address: str = "http://localhost:3100",
            *,
            extra_labels: dict | None = None,
    ):
        """Async loki client that pushes messages from a queue or sends a message immediately on request."""
        self._address = address
        self._endpoint = "/loki/api/v1/push"
        self._full_address = self._address + self._endpoint
        self._headers = {'Content-type': 'application/json'}
        self._extra_labels = extra_labels
        self._queue: asyncio.Queue[LokiMessage] = asyncio.Queue()
        self._queue_run = threading.Event()
        self._queue_run.set()

    def put_nowait(self, msg: LokiMessage):
        """Place a message in the message queue that will be sent in the near future."""
        self._queue.put_nowait(msg)
        logger.debug("Message put in queue")

    async def write(self, msg: LokiMessage):
        """Send a message immediately."""
        await self._send_message(msg)

    async def _send_message(self, msg: LokiMessage):
        """Send a message to the loki endpoint. Bypasses the queue."""
        async with httpx.AsyncClient(base_url=self._address, headers=self._headers) as client:
            r = await client.post(url=self._endpoint, json=msg.as_payload())
            logger.info(f"message sent. {r}. {r.text}")

    async def handle_queue(self):
        """While event is set, fetch items from the queue and then them to the Loki endpoint."""
        logger.info("Queue started")
        while self._queue_run.wait(0):
            try:
                msg = self._queue.get_nowait()
            except asyncio.QueueEmpty:
                await asyncio.sleep(1)
            else:
                logger.info("Received message from queue")
                await self._send_message(msg)
        logger.info("Queue ended.")

class LokiQueuePlugin(LokiQueueHandler, InitPluginProtocol):
    """Registers a lifespan that runs the Loki queue. Adds a dependency to the app so that any route handler
    can send messages to loki or put them in the queue."""

    @asynccontextmanager
    async def lifespan(self, _: Litestar):
        task = asyncio.create_task(self.handle_queue())
        yield
        self._queue_run.clear()
        try:
            await task
        except Exception:
            pass

    def get_handle(self):
        return self

    def on_app_init(self, app_config: AppConfig) -> AppConfig:
        app_config.dependencies["loki"] = Provide(self.get_handle, sync_to_thread=True)
        app_config.lifespan.append(self.lifespan)
        return app_config

Litestar App
from litestar import Litestar, get

from loki_queue import LokiQueuePlugin, LokiMessageTemplate

loki_plugin = LokiQueuePlugin()
template = LokiMessageTemplate(
    {"app": "litestar_demo"}
)

@get("/")
async def home(loki: LokiQueuePlugin) -> str:
    message = template.timestamped_message("Hello World")
    loki.put_nowait(message)
    return "Loki message triggered."

@get("/user/{user:str}")
async def home_user(user: str, loki: LokiQueuePlugin) -> str:
    message = template.timestamped_message(f"Hello {user}", extra_labels={"user": user})
    loki.put_nowait(message)
    return f"Loki message triggered by user {user}."

app = Litestar(
    route_handlers=[
        home,
        home_user
    ],
    plugins=[loki_plugin]
)

docker-compose.yml
version: "2"
services:
  grafana:
    image: grafana/grafana
    container_name: grafana
    restart: unless-stopped
    ports:
      - '3000:3000'
    volumes:
      - grafana-storage:/var/lib/grafana
    environment:
      - GF_PATHS_PROVISIONING=/etc/grafana/provisioning
      - GF_AUTH_ANONYMOUS_ENABLED=true
      - GF_AUTH_ANONYMOUS_ORG_ROLE=Admin

  loki:
    image: grafana/loki
    container_name: loki
    restart: unless-stopped
    volumes:
      - ./config/loki_config.yaml:/etc/loki/local-config.yaml
      - loki-storage:/loki
    ports:
      - '3100:3100'
    command: -config.file=/etc/loki/local-config.yaml

volumes:
  grafana-storage: {}
  loki-storage: {}

Drawbacks and Impact
I just started learning about Grafana Loki, so I'm not 100% sure if this is the best use of it. Maybe it's better just to log and ingest everything. On the other hand, while it seems easy to get a basic setup running, even with one of the other agents, it might take longer to understand all the different configuration details and options.
Using this plugin as a starter seems way simpler to me, since it's more "what you see is what you get".
Unresolved questions
The example provided is my first iteration and can use some improvement. E.g., it's probably better to use Pydantic instead of dataclass for input validation. Loki is quite strict on the formatting, so passing a timestamp as an integer insted of a string will not fly.

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Hey thanks for this! How have you found the experience of working with the plugin system? Anything you'd like to see added or any pain points?
I'd encourage you to publish this as your own plugin library and we can promote it in our Discord showcase and add it to https://github.com/litestar-org/awesome-litestar. If over time there proves to be enough interest - we can consider to move the project into the org if necessary in order to assist with maintenance, but lets get there first.
Let us know either here or in discord if you stand up a repository for the plugin. Cheers!

Reopened as I just saw the discord discussion suggesting to open this issue - take the above comment as my opinion on the matter :)

Hey thanks for this! How have you found the experience of working with the plugin system? Anything you'd like to see added or any pain points?
I'd encourage you to publish this as your own plugin library and we can promote it in our Discord showcase and add it to https://github.com/litestar-org/awesome-litestar. If over time there proves to be enough interest - we can consider to move the project into the org if necessary in order to assist with maintenance, but lets get there first.
Let us know either here or in discord if you stand up a repository for the plugin. Cheers!

Hi @peterschutt, after playing around with litestar for a while now, I found it very easy and straightforward to set up a plugin like this. So, no complaints so far ;)
When I have time, I'll set up a seaparate repo for this plugin to make it easily available to others. Is it okay to name it something like litestar-plugin-loki or is there a certain naming schema you'd like people to follow?

I'll close this, but let us know once you have the repo up!


Loosen linalg_ext.scatter requirements for partial update

mhlo.scatter has implicit 0 index for the update and allows a partial update for along the destination axis.

Do we have a numerical end-to-end test for this one too? (not blocking)

Nope so I added one.

I was OOO, so just saw this. I am not sure whats happening here (its checked in, so thats fine), but something here tells me we might be pushing the boundaries of scatter than we should. Could you summarize the change (I cant follow from the PR)


Issue 173 grid view

Description
As per request 173, grid view is added to dataset, folder and search.
The views are as followed:

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the CHANGELOG.md.
[x] I have signed the CLA
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Can you take a quick look at the marking files system? During testing, on grid view when I would select a file inside a dataset it would set Marked (2) instead of Marked (1). The list view still seemed to add 1 correctly, but there seems to be some weird behavior there. Can you try to recreate? This is used for bulk file operations.

A lot of the changes are looking good overall!

@bodom0015 can you help review this? Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Hoang Nguyen:x: hoangnguyen177Hoang Nguyen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[LOC]Fixed inappropriate japanese "レポポ"→"リポジトリ" (ja-jp)

ja-jp:"https://docs.microsoft.com/ja-jp/azure/devops/pipelines/packages/nuget-restore?view=azure-devops"

en-us:"https://docs.microsoft.com/en-us/azure/devops/pipelines/packages/nuget-restore?view=azure-devops"

#PingMSFTDocs
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c78a9f20-b8d2-4aa7-c52d-a968ab87315d
Version Independent ID: 3880a787-8f70-8c13-176e-c732b619fb06
Content: Restore NuGet packages in Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/packages/nuget-restore.md
Product: devops
Technology: devops-cicd-packages
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn

The term "repository" is used elsewhere in the article. I'll change the one instance of "repo" to "repository".


Throw up a warning whenever a project that contains MRTK is built without being properly configured

Does this affect the legacy HoloToolkit (master) or the Mixed Reality Toolkit (mrtk_release)?
I experience the problem in HoloToolkit, but I would be fine if the feature request just landed in Mixed Reality Toolkit
Is your feature request related to a problem? Please describe.
I regularly help people debug the most obscure MRTK problems, missing using directives, bad cameras, failed DLLs.  These problems are really obscure and hard to track down on their own (and invariably it seems like they fixed one or two of the perquisites by hand in order to get themselves into an all new and unique brokeness state.)
Describe the solution you'd like
I'd really like it if MRTK popped a warning message any time it built/ran without having first been configured. And like... don't let them turn it off.

I'll also add for reference that both the Oculus and SteamVR SDKs have either pop-up windows or force enable the options (while printing debug logs).
They do not allow the user to forget those certain steps easily which likely removes large sections of odd bug cases that would occur otherwise.

In the new MRTK you won't have this issue, bc things are setup automatically on import.

What does the Configure option do?

It only creates the Mixed Reality Manager and puts it in your scene. From there everything is already setup from the initialization of the manager.

Rad!


Change "NUMBER_VERIFICATION.INVALID_TOKEN_CONTEXT" to "INVALID_TOKEN_CONTEXT"

Problem description
While reviewing 1.1 for ICM I noticed that we still  "NUMBER_VERIFICATION.INVALID_TOKEN_CONTEXT" in the yaml file once.
https://github.com/camaraproject/IdentityAndConsentManagement/issues/189#issuecomment-2314746067
We changed that to "INVALID_TOKEN_CONTEXT" some lines lower.
Why did we not change it in this line?
https://github.com/camaraproject/NumberVerification/blob/r1.1/code/API_definitions/number_verification.yaml#L271
Expected behavior
Change "NUMBER_VERIFICATION.INVALID_TOKEN_CONTEXT" to "INVALID_TOKEN_CONTEXT"

This is a valid point
The fix has been done by @fernandopradocabrillo last week and it appears on the yaml.
But I do not understand why this change is not reflected on the PR39 - files changed part.

Fixed in r1.2.


Remove a magic number

Closes #3837

Coverage remained the same at 100.0% when pulling 32aaa87bfbe4c7d0bc9f7c6b2bf5b65974822a60 on issue_3837 into 7f72eedc2d4fc196d389f5aa0b2659f70dabe278 on develop.


ffmpeg camera integration stopped working from 0.95

I am running version 0.95.1 (issue introduced from 0.95) on HassOS 2.12
I have 2 Swann NVW-470 cameras integrated with home assistant using ffmpeg platform on camera component.
I have been successfully using these for months with automations linked to a doorbell and a smart cylinder lock (when doorbell is pressed or key inserted a snapshot is taken off camera and stored in local snapshot folder, then image is sent as ios notification) I also have these showing as picture-glance cards in Home Assistant front end.
Since upgrading to 0.95 I get the following errors in the HA log (not sure if all of this is relevant), the picture-glance cards just show up as blank, snapshots are captured but windows can't recognise/open them...:
019-06-29 05:40:43 ERROR (MainThread) [aiohttp.server] Unhandled exception Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 447, in start     await resp.prepare(request)   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_response.py", line 353, in prepare     return await self._start(request)   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_response.py", line 667, in _start     return await super()._start(request)   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_response.py", line 410, in _start     await writer.write_headers(status_line, headers)   File "/usr/local/lib/python3.7/site-packages/aiohttp/http_writer.py", line 112, in write_headers     self._write(buf)   File "/usr/local/lib/python3.7/site-packages/aiohttp/http_writer.py", line 67, in _write     raise ConnectionResetError('Cannot write to closing transport') ConnectionResetError: Cannot write to closing transport 2019-06-29 05:40:43 ERROR (MainThread) [aiohttp.server] Unhandled exception Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_protocol.py", line 447, in start     await resp.prepare(request)   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_response.py", line 353, in prepare     return await self._start(request)   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_response.py", line 667, in _start     return await super()._start(request)   File "/usr/local/lib/python3.7/site-packages/aiohttp/web_response.py", line 410, in _start     await writer.write_headers(status_line, headers)   File "/usr/local/lib/python3.7/site-packages/aiohttp/http_writer.py", line 112, in write_headers     self._write(buf)   File "/usr/local/lib/python3.7/site-packages/aiohttp/http_writer.py", line 67, in _write     raise ConnectionResetError('Cannot write to closing transport') ConnectionResetError: Cannot write to closing transport 2019-06-29 05:40:46 WARNING (MainThread) [haffmpeg.tools] Timeout reading image. 2019-06-29 05:40:46 WARNING (MainThread) [haffmpeg.tools] Timeout reading image. 2019-06-29 05:40:58 WARNING (MainThread) [haffmpeg.tools] Timeout reading image. 2019-06-29 05:40:58 WARNING (MainThread) [haffmpeg.tools] Timeout reading image. 2019-06-29 05:41:52 WARNING (MainThread) [haffmpeg.tools] Timeout reading image. 2019-06-29 05:41:52 WARNING (MainThread) [haffmpeg.tools] Timeout reading image.
Nothing else has changed to this set up, everything had been working perfectly
Here is my config:
`camera:

platform: ffmpeg
name: Drive
input<EMAIL_ADDRESS>platform: ffmpeg
name: Backdoor
input<EMAIL_ADDRESS>

Resolved by hard reboot of cameras


Fix link in README

Corrected branch name and line number for link to ParsedDID.

thanks for your review 😄


Add support for multiple eventhub for eventhub diagnostics destinations

Merged and available in 5.4.0.


Update ActorProxy.xml

remove duplicate wording

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

xml/Microsoft.ServiceFabric.Actors.Client/ActorProxy.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Annotation Checker panel

This panel doesn't appear when selected from the View menu.

This works for me. Maybe try trashing files at ~/Library/Application Support/Phenex/component_prefs


Update user logos to link to corresponding user stories

The user logos are currently in a single image:

We'd like to break up this image into separate icons.  The icons that link to a user story should route to the correct page.  Logos that don't have an associated user story shouldn't link anywhere.
For example, the Scribd logo should link to this page.
We should save the images in some directory that allows us to easily change the order.  There should be an intelligent filenaming convention.  e.g. scribd.png should link to user-stories/scribd.

Please also add the Kubit logo (no user story yet but we should add them)


Added school, Caledonia-Mumford Central School District

School website here

@Mqcaw First stage of verification passed, official domain for ** Caledonia-Mumford Central School District** is students.cal-mum.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Mqcaw Thank you for your patience while waiting for a review and processing your request. Pull request merged.


fix(expect-utils): Fix equality of ImmutableJS Record

Summary
Fixes #13051
Test plan
I added an iterableEquality test for two Record that have the same contents, but were not considered equal before this change. This PR follows the changes made in #12977 for a similar issue.

https://github.com/facebook/jest/releases/tag/v29.0.0-alpha.1

https://github.com/facebook/jest/releases/tag/v29.0.0


Cannot disable spellchecking on <input>

Partial search terms are marked as spelling mistakes and I’ve not found a way to prevent this using standard methods.
Reproduction Link
https://jsfiddle.net/cn8o4s03/
Steps to reproduce
Add [spellcheck="off"]
Optimistically Expected behaviour
Pass attribute to input.
Actual behaviour
Nothing.

This sounds like a great PR candidate. Would love to merge this. :)

Added spellcheck as a prop, but I didn't really get how to update the example & docs properly.

Removed the spellcheck from the search field.

Hi @shentao!
Could you please bring the version with this fix to NPM?
It seems to be rather critical for mobile devices.
Thanks a lot in advance!

I want to work on this issue, please assign me.

is this till open ? @shentao

I wanted to work on this please assign me

Hi @shentao, @LadyMashiro, this is still an issue, please make a props to control input behavior

I think that this issue you're facing is due to the browser's default behavior of spell checking from fields including searching inputs.
try to add spellcheck="off" attribute to the parent element, like a div or form containing the search input:

/assign


FailedStatus only gives top level error information

The Failed status class only gives basic top level information on an error e.g.  rather than details of the underling cause
Expected Behavior
Detail of the underlying error cause should be reported - e.g. in the case where this was noted, the underlying cause was an attribute error on the staus object due to an incorrect property reference (seq1 in stead of seq[1] on a PandA object).
Current Behavior
This was apparent by making the code print the status object (which displayed " 'PandA' object has no attribute 'seq1' " ), but was not visible on the FailedStatus, which just reported
### Tasks

From discussion, this may have gone away in #1664, so this issue is now for writing a confirming test


Existing groups

What happens to existing groups when you enable this policy and the groups already have expired? Will they instantly be soft-deleted?
For example: I created a group on 1 January 2017 and I have an expiration policy set for 365 days. I activate this policy today. What happens? Will they be instantly soft-deleted?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d4773fc-df89-4d7c-6819-9ed94c66e1a3
Version Independent ID: 9a0ce458-fd6b-5f12-0b6e-98f9b38ad13c
Content: Office 365 Group Expiration Policy
Content Source: Office365-Admin/create-groups/office-365-groups-expiration-policy.md
Service: o365-administration
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@Dutchman1993 - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome, let me know if it is something that can be called out in the docs.
If you don't mind please keep us posted here on the resolution and I really want to get this information you are discovering back into the docs.

Seems there is more information in this link: https://docs.microsoft.com/en-us/azure/active-directory/users-groups-roles/groups-lifecycle
"When you first set up expiration, any groups that are older than the expiration interval are set to 30 days until expiration unless the owner renews it. The first renewal notification email is sent out within a day."

@Dutchman1993 - We're glad to know that you found the information you were looking for.
Please feel free to open a new issue if there is a specific area of the docs that we can improve or make better. Thank you.


Raft snapshots: storing minimal instance

Raft snapshots don't write down entire Instance contents. Reason: too much content, which is likely outdated after restart. Instead, they just give minimal context for orchestrator to pick up.
The instances context is relevant when the orchestrator node starting up has lost its data.
Up till now, the only context would be the instance key. orchestrator would then discover the instances, each by its key, and repopulate its backend.
However, this is a problem when an instance is out for the moment. It cannot be discovered (which is legit, things happen); but orchestrator also lost the identity of its master. Not good, because orchestrator needs the replication graph to better analyze errors.
This PR adds the MasterKey to the snapshot data. Instances could still be missing, but orchestrator is able to still maintain the correct graph.

we also add CluterName


External Providers / Multiple Azure AD Tenants

I am trying to work out how we can support multiple external providers of authentication using IdentityServer4.  I will illustrate my thinking with some pictures.  We currently have a set of applications, some of which use Identity Server and some which use their own built in login process.  The authentication relationships would look like Figure 1:

The seperate apps with their own built in authentication are seperate by customer, we provide a whole new instance to each customer.  We now have a requirement where the customers are implementing Azure AD and Office 365 and they want to have automatic sign-in on those seperate apps utilizing their Azure AD service.  We therefore anticipate having multiple Azure AD tentants as external providers as well as adding the usuals like facebook and google.  What we were thinking was would it be sensible to put IdentityServer 4 in the middle of all authentication where it could provide authentication from either its own user tables or otherwise forward on the request to the relevant external provider as shown in Figure 2:

Problems with this approach would seem to be that how would IdentityServer4 know which external provider to check for single sign on and is sensible to configure all those external providers into the IdentityServer4 startup.
Perhaps another way would be to configure the seperate apps to authenticate directly with Azure AD via OpenIDConnect and then to have an additional OpenIDConnect authentication available against the IdentityServer4 for users like our admins to access the seperate app.  Something like in Figure 3.

Is it possible to have multiple Authentication providers for an app and is there an order of preference for which they are tried.  How could the users that should authenticate via Azure AD be directed there while the users that should be authenticated via IdentityServer4 be directed to it.

I guess figure2 is better. But both are ok. In my case, the solution should support existing openid solution, integrate it with default identity architecture template provides and support any other social logins in the long run. sure, It's possible to have multiple Authentication provider for an app. In my solution, the last provider will take priority.

If I was to try and implement Figure 2 I could possibly configure the web app as client and then give it a hint as to which AzureAD tenant to attempt to use.  Of course it wouldn't necessarily always be that external provider who did the authentication so I would need some way of checking to see if the user was already signed in on that AzureAD domain and if there were they could be logged in, otherwise they would need to be shown the Identity Server login screen with the ability to choose an external provider.  This however could be ugly if there are going to be 50 or more Azure AD domains to possibly authenticate against.
In that case perhaps the Figure 3 where Identity Server doesn't need to be aware of all these Azure AD tenants might be a better solution, and then I need to figure out how to secure the app against 2 authentications providers.
What I would want is for the app to first try the AzureAD to see if the user is logged onto that domain, failing that I would want it to try Identity Server to see if the user is logged on there, and finally if neither were already logged in the app would have to show a screen for the user to choose which one they wanted to authenticate off.  Does anyone have any samples of how this could be configured using OpenIDConnect?

This seems to be a general question about IdentityServer - not a bug report or an issue.
Please use StackOverflow for that. This has the advantage that questions and answers can be easily found by search engines, and that there are more people answering questions than just us.
For IdentityServer3
https://stackoverflow.com/questions/tagged/?tagnames=identityserver3&sort=newest
For IdentityServer4
https://stackoverflow.com/questions/tagged/?tagnames=identityserver4&sort=newest
For commercial support
https://identityserver.io/


Implement portal

I am going to implement the Portal feature for this cool library.
Can we discuss whether my implementation method is reasonable?

Sounds interesting! Can you please elaborate on this? How would the API look like and how to use it?
Maybe use the same kind of interface as react-three-fiber? https://gracious-keller-98ef35.netlify.app/docs/recipes/re-parenting/

Sounds interesting! Can you please elaborate on this? How would the API look like and how to use it?
Maybe use the same kind of interface as react-three-fiber? https://gracious-keller-98ef35.netlify.app/docs/recipes/re-parenting/

Ok, I'll find a fixed time to get this done.

Great! Then I’ll close this issue.. please let me know if we need to reopen it


add contributor Daniel Chiang

@generalyi0057, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Greeting! :)
First of all, because my native language is Chinese, I apologize if there is any grammar error or weird wording.
I have been using Git since I get my first job, and maybe because I was a newbie,  in the product development, I seldom create branch for adding features or debugging… etc. However, recently I started to learn how to use branch and found out that this feature helps a lot not only in code review but in managing project.
After I went through the tutorial,  it came out my mind that I should form the habit of using branch to manage my code. Some Git branch introduction documents show excellent concepts of version controlling. For example like treating master as formal version, create branch “dev” for development, create other branches like features, fixes, refactors or whatever for each task, send pull request to do code review…ect. I believe this habit can bring me convenience when dealing with my coding problems.

Roshan Jossey<EMAIL_ADDRESS>於 2017年10月23日 下午3:45 寫道：
@generalyi0057 https://github.com/generalyi0057, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
> We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
> Also, check out projects with easy issues while you’re there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roshanjossey/first-contributions/pull/1187#issuecomment-338574452, or mute the thread https://github.com/notifications/unsubscribe-auth/AXQJc2bLEDhf_9zym-iPGu-hXTAcT0T6ks5svEQVgaJpZM4QCQM4.

@generalyi0057, Your English is perfect. I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com
There are two main philosophies of collaborating with git, trunk based development and branch based development. https://stackoverflow.com/questions/42135533/what-are-the-pros-and-cons-of-using-a-trunk-based-vs-feature-based-workflow-in-g


fix: enable failing dependencies to be optimised by pre-processing them with esbuild

Description
Some packages such as Gatsby ship with JSX which is expected to be compiled by the library users' bundler.
While there are workarounds to force Vite to interpret .js files as JSX (see discussion), these are not sufficient when the JSX is inside node_modules/. In particular, es-module-lexer doesn't support JSX (this was considered infeasible as per https://github.com/guybedford/es-module-lexer/issues/47). This means that the parse() call at: https://github.com/vitejs/vite/blob/887c247984abc0f80d8b19a1d681855944f6d01a/packages/vite/src/node/optimizer/index.ts#L245 fails when it encounters JSX.
While the best approach is certainly to ensure that packages don't ship as JSX, it's possible to improve the situation by adding a fallback mechanism which transforms the code with esbuild prior to re-trying.
This fix enables Gatsby to work when passing Vite the following options:
        esbuild: {
          loader: "jsx",
        },
        optimizeDeps: {
          esbuildOptions: {
            loader: {
              ".js": "jsx",
            },
          },
        },

Since it's only a fallback mechanism, it shouldn't affect performance adversely.
Additional context
This was originally surfaced as a bug report for the Viteshot project, see https://github.com/zenclabs/viteshot/issues/53.
Example project: https://github.com/fwouts/vite-gatsby-sample-app

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

A git repo that reproduces the issue would be super handy. :)

A git repo that reproduces the issue would be super handy. :)

You're right, I should have thought about that! Here you go: https://github.com/fwouts/vite-gatsby-sample-app

I faced the same problem.
When I use storybook as a vite bandler,
I couldn't handle the jsx files with Gatsby js extension correctly.

I think we should discuss this PR with Evan before merging it, as it introduced special handling for JSX. It would be useful for that discussion to know what is preventing this fallback to be added as a userland plugin (or as a more generic feature that could enable the userland plugin)

I think we should discuss this PR with Evan before merging it, as it introduced special handling for JSX. It would be useful for that discussion to know what is preventing this fallback to be added as a userland plugin (or as a more generic feature that could enable the userland plugin)

That's a great point. If special handling of JSX isn't desired, perhaps a good alternative would be to enable plugins to somehow be able to override the handling in this part of the code.

Using try-catch to fallback to jsx parsing for every js file in order to fix this niche case is not ideal to me. To me, at least on their side they'd better to ship with .jsx instead of .js in their dist.
I will add this to this week's meeting with Evan.

Hey @antfu, I was just wondering what was the outcome of the meeting? :)

Hey @antfu, I was just wondering what was the outcome of the meeting? :)

The meeting was rescheduled to today


Multi Sweep Waymo Models

Is it possible to operate on multi sweep data from Waymo?

Sure, but you need to re-generate the dataset info to save sweep information as nuscenes dataset

As I understand, I need to run;
python -m pcdet.datasets.waymo.waymo_dataset --func create_waymo_infos \     --cfg_file tools/cfgs/dataset_configs/waymo_multi_sweep_dataset.yaml
After creating a waymo_multi_sweep_dataset.yaml
DATASET: 'WaymoDataset'
DATA_PATH: '../data/waymo'
PROCESSED_DATA_TAG: 'waymo_processed_data_v0_5_0'
MAX_SWEEPS: 10 ## MODIFIED THIS FROM ORIGINAL waymo_dataset.yaml
POINT_CLOUD_RANGE: [-75.2, -75.2, -2, 75.2, 75.2, 4]

DATA_SPLIT: {
    'train': train,
    'test': val
}

SAMPLED_INTERVAL: {
    'train': 5,
    'test': 1
}

FILTER_EMPTY_BOXES_FOR_TRAIN: True
DISABLE_NLZ_FLAG_ON_POINTS: True

USE_SHARED_MEMORY: False  # it will load the data to shared memory to speed up (DO NOT USE IT IF YOU DO NOT FULLY UNDERSTAND WHAT WILL HAPPEN)
SHARED_MEMORY_FILE_LIMIT: 35000  # set it based on the size of your shared memory

DATA_AUGMENTOR:
    DISABLE_AUG_LIST: ['placeholder']
    AUG_CONFIG_LIST:
        - NAME: gt_sampling
          USE_ROAD_PLANE: False
          DB_INFO_PATH:
              - waymo_processed_data_v0_5_0_waymo_dbinfos_train_sampled_1_msweep.pkl

          USE_SHARED_MEMORY: False  # set it to True to speed up (it costs about 15GB shared memory)
          DB_DATA_PATH:
              - waymo_processed_data_v0_5_0_gt_database_train_sampled_1_global_msweep.npy

          PREPARE: {
             filter_by_min_points: ['Vehicle:5', 'Pedestrian:5', 'Cyclist:5'],
             filter_by_difficulty: [-1],
          }

          SAMPLE_GROUPS: ['Vehicle:15', 'Pedestrian:10', 'Cyclist:10']
          NUM_POINT_FEATURES: 5
          REMOVE_EXTRA_WIDTH: [0.0, 0.0, 0.0]
          LIMIT_WHOLE_SCENE: True

        - NAME: random_world_flip
          ALONG_AXIS_LIST: ['x', 'y']

        - NAME: random_world_rotation
          WORLD_ROT_ANGLE: [-0.78539816, 0.78539816]

        - NAME: random_world_scaling
          WORLD_SCALE_RANGE: [0.95, 1.05]

POINT_FEATURE_ENCODING: {
    encoding_type: absolute_coordinates_encoding,
    used_feature_list: ['x', 'y', 'z', 'intensity', 'timestamp'],  ## MODIFIED THIS FROM ORIGINAL waymo_dataset.yaml
    src_feature_list: ['x', 'y', 'z', 'intensity', 'elongation'],
}

DATA_PROCESSOR:
    - NAME: mask_points_and_boxes_outside_range
      REMOVE_OUTSIDE_BOXES: True

    - NAME: shuffle_points
      SHUFFLE_ENABLED: {
        'train': True,
        'test': True
      }

    - NAME: transform_points_to_voxels
      VOXEL_SIZE: [0.1, 0.1, 0.15]
      MAX_POINTS_PER_VOXEL: 5
      MAX_NUMBER_OF_VOXELS: {
        'train': 150000,
        'test': 150000
      }

However, I haven't find the place to load multiple sweeps in waymo_dataset. I will ask @sshaoshuai to reply this issue later.

You do not need to re-generate the data, since the generated infos of OpenPCDet (v0.5) already contains the needed pose matrix for multi-sweep alignment:
https://github.com/open-mmlab/OpenPCDet/blob/master/pcdet/datasets/waymo/waymo_utils.py#L226-L227
However, you still need to wriite codes in the __getitem__ to align the multi-sweep LiDAR point clouds (remove the ego-motion by using the above pose matrix) as the input points for multi-sweep training and testing.

Thank you. Would you accept a PR in case i implement this?

@OrcunCanDeniz Sure.

If you would like to submit a PR related to this, it is preferred to also provide some multi-sweep results.
We will denifitely accept such a PR with more elegent implementation or better results, given the context that we also have an internal implementation of multi-sweep Waymo codes (still not released yet since we do not have many results for multi-sweep training/testing).

@sshaoshuai  @jihanyang  @OrcunCanDeniz  Hi, are there any documents to guide multi-sweeps on waymo? I am a beginner and try to learn from nuscene, but these two are quite different...

Another question is, do we have to change SAMPLED_INTERVAL and generate new datasets when using different proportions?


Add a constructor to TextureLoader that accept a callback when succeed.

Now the TextureLoader act the same as MeshLoader.

Looking good, thanks!


Give overview of total hits rendered by certain search

A very helpful addition to the explorer would be if we display the amount of hits on the browse page. We do this on the smell source page, but it would be great to have this on the Browse page as well. That way you can see how much you are narrowing down the hits your search by selecting different options.

We already largely discussed this. We have to disable counting on the Browse pages because it is too expensive computationally. I'm closing this issue as this is also a duplicate of #100


fix: bring badges inline with standard github badges

What
fix: bring badges inline with standard github badges

Codecov Report

Merging #3388 (cc9dac7) into develop (e01600c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3388   +/-   ##
========================================
  Coverage    10.33%   10.33%
========================================
  Files          260      260
  Lines        12588    12588
========================================
  Hits          1301     1301
  Misses       11287    11287

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Resume training ?

Hi,
How can I resume training on colab TrainingV2_NoUI.ipynb ? I know it is possible on some other RVC colabs but I'm not sure about  this one.

I'm not implementing it yet on this one

I see, thank you for your answer, would be a nice feature in the future :)


Add angular 9.x universal support

After update to angular 9.x universal I've this issue
/ng-app/dist/server/main.js:201150
                 this.userAgent = window.navigator.userAgent;
                                  ^

 ReferenceError: window is not defined
     at new DeviceDetectorService (/ng-app/dist/server/main.js:201150:34)

at the first looks it seems an angular 9.x issue but this can be avoided adding a conditional in the package asking for isPlatformBrowser when window is used.
Can you add that feature to avoid this kind of issues? will be appreciated.
Thanks

Can you add some extra validation for universal?
typeof window !== 'undefined

Fixed by https://github.com/KoderLabs/ngx-device-detector/pull/143

@BruneXX a new release has been published to npm. Here's the tag.
https://github.com/KoderLabs/ngx-device-detector/releases/tag/1.4.1

Hi @AhsanAyaz Thank you so much! I've installed new version and works very well! :+1:


this is a big bug

why it comes another "<",I hope you can deal with it ,thx

I'm a freshman ,thx

sorry ,it is my mistake , I can work out it


Is it possible to customize tcp and udp Dial?

Is it possible to customize tcp and udp Dial?

You got it :)
On Mon, Jan 8, 2024 at 10:55 AM UallenQbit @.***> wrote:

Closed #18 https://github.com/txthinking/socks5/issues/18 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/txthinking/socks5/issues/18#event-11412793807, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJPFT66XQ6ISMTAGUG3YITYNNNYZAVCNFSM6AAAAABBQXYI22VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQYTENZZGM4DANY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Review ad interaction recording, make sure it is working

Firebase seems to be recording the ad interactions as intended.
After last meeting, I wanted to review the "confidence levels". There are currently only two categories of reasoning related to an ad interaction.

"navigation via ad network and linked from subframe"
"linked from iFrame"
Reasoning 1 is more thorough. Reasoning 2 is looser and allows interactions to be recorded that involve ad networks that may not be known to the disconnect list. As implied all interactions flagged by reasoning 1 would also fall under reasoning 2.

Previously interactions flagged with reasoning 1 were noted as "highest confidence", but this seems a bit misleading as there are only two categories of reasoning...
In the paper I can explain why this methodology is used to flag ad interactions. i.e. iframes are used to place ads (however of course not all frames are ads)...if a user clicks on an iframe and it opens a pop up window, it is possibly an ad...it is even more likely an ad if the pop up window was opened by an ad network...

I will put explanation of reasoning in readme and paper.

I will put explanation of reasoning in readme and paper.

Great!
FYI. Under known issues we currently have the following. So, you may need to adapt the text there as well depending on what you write in your explanation.

Incorrect recording or missing of a user clicking on an ad: Because of the ambiguity of Ad Interactions, our method of recording them is not fool-proof. While a vast majority of Ad Interaction data is correct, the extension may in individual cases incorrectly record or miss a user clicking on an ad. Ad Interaction is also based on a heuristic, especially, a click event occurring in a subframe, that may not always correctly identify an ad.


[AST] NFC: Add reentrancy check to associated type anchor walk

This makes compiler crasher 28870 crash faster and reliably instead of recursing off the end of the stack.
This reverts: 614cb48b63f29325e5b7aee267602c2c27f1a3c6

@swift-ci please smoke test

Hi @DougGregor and @slavapestov  – I just tried adding an assert to GenericSignatureBuilder::addInheritedRequirements() to ensure that a protocol's inheritance is known acyclic, but that blows up because the inheritance of a protocol can be used before the protocol has been type checked.
I'd like to keep the assert or something like it. Can we do protocol type checking earlier? Or does it need to be phased? In other words, validate that inheritances are acyclic "early" somehow?

I'd prefer if we could fix this crash by ensuring that the request-evaluator is detecting and coping with the cycle, rather than updating that early cycle checking (which we can't rely on in general). Maybe it's because of the dodgy hack I implemented in https://github.com/apple/swift/blob/master/lib/AST/Decl.cpp#L3229-L3236 for performance reasons, or maybe it's something different, but doing cycle checking outside of the request-evaluator is a game of whack-a-mole that I'd hoped we could avoid doing more of.

Maybe the "dodgy hack" is the problem then? Compiler crash 28870 recurses off the end of the stack via two cyclicly recursive protocols that try to call getOverriddenDecls() on each other.

@DougGregor and @slavapestov – I've reworked AssociatedTypeDecl::getAssociatedTypeAnchor() to not crash when circular (and erroneous) protocols exist.
@swift-ci please smoke test

Ping? I'd like to merge this because compiler crasher 28870 times out semi-regularly these days on my Linux box, which impacts my automated testing. Thanks.

Sorry for not replying sooner. I think this function would be clearer if it was non-recursive. Other than that it looks like a good fix for now.


Run in Docker

It would be nice if you can provide a docker image to run this project.
I have tried to make my own image and it was not easy at all... a lot of version missmatches  i had to resolve, missing sudo in ubuntu images, i had to compile solc from source which is a pain on it's own, etc
also make fails with this ending lines:
time="2020-06-15T05:20:15Z" level=error msg="GET     <-- !Failed: Get \"%20%20%20\": unsupported protocol scheme \"\""
time="2020-06-15T05:20:15Z" level=error msg="HDWallet request failed: Error querying HDWallet"
time="2020-06-15T05:20:15Z" level=info msg="Sending error reply. Status=400 Err=HDWallet signing failed"
FAIL
coverage: 98.2% of statements
FAIL  github.com/kaleido-io/ethconnect/internal/kldtx  2.153s
ok    github.com/kaleido-io/ethconnect/internal/kldutils 0.221s coverage: 98.6% of statements
?     github.com/kaleido-io/ethconnect/pkg/kldplugins  [no test files]
FAIL
Makefile:14: recipe for target 'coverage.txt' failed
make: *** [coverage.txt] Error 1
make: *** Deleting file 'coverage.txt'

my attempt to make functional Dockerfile:
FROM ubuntu:18.04

# install golang
WORKDIR /usr/local
RUN apt-get update
RUN apt --yes install curl
RUN curl -O https://dl.google.com/go/go1.14.4.linux-amd64.tar.gz
RUN tar -xvf go1.14.4.linux-amd64.tar.gz
RUN rm -rf go1.14.4.linux-amd64.tar.gz
RUN chown -R root:root ./go

# ethconnect requires version of solc <0.6, so we have to
# install SOLC from sources
RUN apt --yes install git
RUN git clone --recursive https://github.com/ethereum/solidity.git
WORKDIR /usr/local/solidity
RUN git checkout v0.5.17
# RUN ./scripts/install_deps.sh
# script above does not work, so installing solc dependencies manually
RUN apt-get -y install build-essential cmake git libboost-all-dev libz3-dev sudo
RUN ./scripts/build.sh

# RUN apt-get update
# RUN apt-get --yes install software-properties-common
# RUN add-apt-repository --yes ppa:ethereum/ethereum
# RUN apt-get --yes install solc build-essential curl inetutils-ping

# compile ethconnect
WORKDIR /app
COPY ./ethconnect .
RUN ls -la
# RUN cd src && make
# make command fails on tests, so have to build manually :(
RUN cd src && export GOPATH=$HOME/go && export PATH=$PATH:/usr/local/go/bin:$GOPATH/bin && make deps
RUN cd src && export GOPATH=$HOME/go && export PATH=$PATH:/usr/local/go/bin:$GOPATH/bin && make build-linux

it's working, but very ugly :) it would be nice if you can simplify this process :))

There's a new Dockerfile in the repo now, as part of transitioning this repo to the FireFly project. If you're still having trouble please feel free to re-open this issue or open another one.


Link is broken

Describe the bug
https://arrow.apache.org/datafusion-comet

Steps to reproduce
No response
Expected behavior
No response
Additional context
No response

Thanks for the report. We have not published the documentation to the Apache site yet but we will get to this soon.

Thanks for the report. We have not published the documentation to the Apache site yet but we will get to this soon.

We will likely wait until the DataFusion project (and its subprojects, including Comet) moves to a top level Apache project in the next few weeks.

Documentation will be published once https://github.com/apache/datafusion-comet/pull/314 is merged


Added Playstr's brand colour.

http://www.playstr.link

Would you mind adding them to our readme.MD, and index.html?
Or you could look at https://github.com/reimertz/brand-colors/issues/16 ;D

Done :)

Dope, thanks!


Add callback for button click

This allows to call a custom callback function when users click on the expand/collapse button.
To keep the library naming convention, I renamed the original function onButtonClick to clickButton.

This would be great to have.
How about calling the function onExpandOrCollapse because onButtonClick seems very generic.

@ryansukale thanks for your suggestion. The function is renamed now.

This code will be integrated into new v3 version


Not working on Windows 10 and Atom Beta 1.7

Hi
The package is not working on W10 and the new Beta. Any tip how to fix?

Update new Remote-FTP 1.0.0 version!


Text-to-speech endpoint: https://speech.platform.bing.com/synthesize does not work

I tried the endpoint https://speech.platform.bing.com/synthesize with a valid access token, but got no response. I switched to https://westus.tts.speech.microsoft.com/cognitiveservices/v1, then got back an audio.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 425f2bb0-a8af-b4b4-6e20-3a5b999b64b2
Version Independent ID: 3cdc4ec4-9a24-bdac-b432-950b3600a65f
Content: Text to Speech API of Microsoft Speech Service
Content Source: articles/cognitive-services/Speech/API-Reference-REST/BingVoiceOutput.md
Service: cognitive-services
GitHub Login: @priyaravi20
Microsoft Alias: priyar

@jjwangpi Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@priyaravi20 Hi, this is a document issue, can you please check it and update the document as necessary? Thanks a lot!
@jjwangpi Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@cjgronlund Hi, the author of this document can not be assigned in Git, can you please add the author to our Microsoft-doc category?  Thanks a lot!

My production application has been broken for days because of this lousy service. Not happy.

@BuffMcBigHuge - Can you tell us about the issue you're encountering?

@erhopf My problem has been solved after I modified the endpoints to include the region. I also had to add the language url parameter. It was confusing as the location of my resource group is different than the location of the service. It wasn't very intuitive, and frustrating that it broke so suddenly.

@BuffMcBigHuge - Thanks for your candid feedback. I'm glad that you're unblocked, but you shouldn't have had this much trouble to start with. We're creating a backlog item to investigate this further.

#please-close


fn defer_drop() requires the object's type be 'static

On the one hand, it is necessary: we don't know exactly when the object will be dropped.  On the other hand, it may be a little bit restrictive: e.g. rsdb defer_drop()s non-'static types (https://github.com/spacejam/rsdb/blob/1f4e97fc8a3c8218af85b265761454c87f3591a0/src/stack.rs#L158).
This problem is well summarized in https://github.com/crossbeam-rs/crossbeam/pull/57#issuecomment-197055562.

Actually, it was rsdb's bug: it is not fixed and it no longer defer_drops non-'static types.  cf: https://github.com/spacejam/rsdb/issues/107
Now I fully agree that the object type should be 'static.  Maybe we can relax it for a custom EBR realm (https://github.com/crossbeam-rs/rfcs/pull/10), but for now, it seems we can do nothing.
I am closing this issue.  If anyone has more thought, please reopen.


[BUG] Node Not Found

Describe the bug
When attempting to create a column chart it creates a node with no visuals and spits out multiple node not found errors.
To Reproduce
Steps to reproduce the behavior:

Install addon from latest code in repository
Enable addon
Add ColumnChart node in Control nodes

Expected behavior
Create a column chart.
Screenshots

Desktop (please complete the following information):

OS: Windows
Godot Engine Version: v3.3.3.stable.official.b973f997f
Plugin Version: Latest at time of writing

Update: tried with v1.5.7 on version 3.2 of Godot but I receive this error:
 Attempt to call function 'get_children' in base 'null instance' on a null instance.

I'm having the same problem..

@sairam4123 @RenFinkle I've started refactoring the plugin, this issue should be ocmpletely solved


Missing License Information

This seems to be a great example of an Azure Data Studio extension (found it via the Azure blog)
However, it seems that there is currently no LICENSE file, or license thats declared otherwise.
Is this repository available under an open-source license? Thanks!

Thanks for the heads up, missed this in the reorganization and I've been traveling of late. It's been added (MIT)


Is there a way to disable DEBUG logs that get printed at the start?

When I run ktlint 0.44.0 on a file, the first lines of output look to be debug logs.
For example:
❯ ktlint myFile.kt
11:13:05.636 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "baseline" id.
11:13:05.637 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "checkstyle" id.
11:13:05.637 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "json" id.
11:13:05.637 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "html" id.
11:13:05.637 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "plain" id.
11:13:05.637 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "sarif" id.
11:13:05.638 [main] DEBUG com.pinterest.ktlint.Main - Initializing "plain" reporter with {verbose=false, color=false, color_name=DARK_GRAY}
myFile.kt:1:1: File must end with a newline (\n)
11:13:06.422 [main] DEBUG com.pinterest.ktlint.Main - 1007ms / 1 file(s) / 1 error(s)

Is there a way to disable printing these logs?
As you can see from the invocation of ktlint, I'm not passing in the --debug flag nor the --verbose flag.
Since I'm not passing these flags in, I'd expect the invocation of ktlint to just produce something like
❯ ktlint myFile.kt
myFile.kt:1:1: File must end with a newline (\n)

I've implemented ktlint as a precommit hook for our team, and I'd like to make sure the output is as easy to read and act on as possible so that my teammates are less likely to get annoyed and more likely to believe that having a linter is a good idea.
If I do a search for some of those log lines, I can see that others experience this same thing.

Looking at the implementation that likely produces these log lines, it appears they're created by a call to logger.debug, which I'd expect would only actually print something if the --debug flag was passed in.

Thanks Paul!


Manual Download and Install Package

Hi, I would like to install it manually as I am having problems installing it via package manager.
Zipping and renaming it to .sublime-package does nothing, but it works on other github hosted sublime packages so far.
It would be nice to provide releases as manual download.

It looks like tags are automatically zipped.

Thanks @michaelblyons I got it working now by packaging the Support folder only.


Lykhoyda/update settings page

Closes #336

Update UI of the Settings page (Watched account and Wallet connect)
Watched accounts moved from components to the Settings page folder (as used now only in one place)
Feature to expand accordion using hashtags #watched-acccounts and #wallet-connect

!
There is no Wallet connect design yet

This looks great!! I've a couple small changes that I'll push, like for the WalletConnect icon. I'll do it later today.
The links to setting > watched account need to be modified in the home page (and maybe some other places?) with the #panel-watched-accounts. This should make the Cypress test pass, or get us closer to.

We need to add click on accordion for cypress test as before the inputs appeared right away.

@asnaith @Tbaut please take a look again. I fixed the comments, let me know if i missed something

@asnaith @Tbaut please take a look again. I fixed the comments, let me know if i missed something

@Lykhoyda Those updates for the labels look good 👍

We need to add click on accordion for cypress test as before the inputs appeared right away.

If you can update the link for the button below to use settings#watched-acccounts then it's going to be expanded when arriving on that screen and will be better for users and also no need to update the test

I pushed some change to

change a pit the logic to force open only the watched-account section if needed.
optimize the WC SVG that took a while to load
make the tests pass. Please check it out. We won't merge any PR that doesn't pass the test, unless it's due to flakiness (not the case here).

There are still a couple comments above that weren't taken into account yet, but it should be quick.


[FLINK-24822][table-planner]Improve CatalogTableSpecBase and its subclass related method parameter

What is the purpose of the change
Currently, CatalogTableSpecBase and its subclass related method use PlannerBase as parameter, we can improve it use FlinkContext enough.
Brief change log
Currently, CatalogTableSpecBase and its subclass related method use PlannerBase as parameter, we can improve it use FlinkContext enough.
Verifying this change
(Please pick either of the following options)
This change is already covered by existing tests, such as DynamicTableSinkSpecSerdeTest, DynamicTableSourceSpecSerdeTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: ( no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (n not documented)

cc @godfreyhe


feature request: stylus support

syntastic is awesome!
Would be great to have stylus support too

From a quick look, I think stylus would make an awkward syntastic checker at best.  Syntax checking seems to be almost an afterthought for stylus, error reporting is less than great (for various reasons), and simulating a parse-only mode would be problematic (again, for various reasons).  I'd say handling included files is likely to be problematic too. shrug
That said however, working pull requests are welcome.  There's also a guide for doing it.

Does this make it easier?
https://github.com/rossPatton/stylint

@faceleg Much better, yes.  Please see edde4c5.

PHEW! I was hoping you'd twiddle your fingers with some of your Syntastic magic, otherwise I was going to have to hack and slash a solution together...


Return all route hints in tagsObject

Previously routing_info in tagsObject only had 1 route hint, while this could be multiple regarding to the bolt11 spec.
I changed the routing_info to be an array inside the tagsObject.
I am aware of this being a breaking change, but I got quite confused that this was not an array before so I hope this change gives a more accurate representation of how route hints are being using in lightning invoices.

I don’t think this is a good idea.
This is a signed data structure. Messing around with order is never a good idea.


Merge dev into master

Let's merge dev into master, and once that's done, let's delete dev altogether.

Any existing PRs can be retargeted from the Github UI into master so it's not an issue

CI finally passed. Merging...

great! I think all PRs are pointing to master and I noticed you already updated it to be the default branch - at this point dev should be safe to delete


Update docker-ee.md

Make change to allow for the ability to install even if you have the Pscx Modules installed
Proposed changes
Change the command that is used for Expand-Archive.  There is an issue if you have the Pscx (Powershell Community Extensions) installed on a server then it will use that modules version of the Expand-Archive.  The change is just to isolate the Expand-Archive to use the Microsoft.PowerShell.Archive version of Expand-Archive
Related issues (optional)
Fixes #8927

Deploy preview for docsdocker ready!
Built with commit 88b3fb175d535e14217cba4a6547673335521b5d
https://deploy-preview-8929--docsdocker.netlify.com

@stevenfollis Could you PTAL? Thanks.

Thanks Brian for your contribution!
After reviewing, I would strongly prefer to not move away from Expand-Archive as it is the default, 1st-party command from MSFT that works out of the box with Windows Server 2016.
I reproduced the issue on a fresh box just now and can confirm the conflict, but it looks like this collision has been identified some time ago within the Pscx project. To even install Pscx required forcing a collision via the -AllowClobber flag.
It would be preferable either for the Pscx project to remove the collision, or for users to use the Import-Module -Prefix workaround mentioned in the thread to avoid collisions.
I did confirm that the -Prefix workaround works, and if the issue comes up regularly in the future perhaps we pipe that into a KB article. However at this time I'd recommend that we keep the instructions as-is to align most closely with the default Windows behavior.

@stefanfoulis Thanks for the follow up.  I am fine with closing out this issue.  Thanks for taking a look

Thank you both. Closing this PR.


Schema validation fails

Describe the bug
Designer throws a schema validation failed error
To Reproduce
Steps to reproduce the behavior:

Go to form details
change title
save
designer server throws error

Expected behavior
Business as usual!

P2

I believe that the issue here is that:

when no feedback form is set, FormDetails.tsx sets the url to ""
schema.ts defines url as joi.string().optional() for non-feedback forms, which allows undefined or a populated string, but not ""

So the solution is either:

Edit the schema to allow the empty string
Edit FormDetails.tsx to set url to undefined instead of ""

I'm happy to PR either of these depending on which is preferable.

@jenbutongit about to raise a PR for this - I've gone with editing the schema but it should be pretty straightforward to change to the other option if you think that's better.

hey @DavidBiddle, sorry, totally missed the first comment! Yep, that was exactly what I was planning but never got round to. Thanks for sorting! ❤


[Feature Request] set the activity locale from the facebook user's profile

I need to localize messages to Facebook user , but Activity.Locale is not set as expected.
The work around i seen on #1056 work but i think the framework should do it alone.

@maxpert this https://github.com/Microsoft/BotBuilder/issues/1056 work would be done server-side for the Facebook channel.

@picatextra are you using C# or Node SDK for BotBuilder?

I'm using both  C# and NodeJs SDK for BotBuilder (different projects)


ImportError: cannot import name 'PTBTokenizer' from 'evaluation'

Did you solve this problem?

Have you solved this problem？

I have the same problem


Create an experiment branch to assess using Cucumber for integration/unit test

Create an exeperiment/cucumber branch
Install https://cucumber.io/ and try to create some basic resolvers

initial Idea for resolvers in the integration test space:
Given a swap contract between "Alice" and "Bob" for "20 tokenA" for "40 tokenB"
When I submit contract I get TxId
When I wait for confirmation
Then the tx is confirmed

Progress

[x] Start a discussion

Using Cucumber for automated testing

[ ] Install cucumber
[ ] Make unknown unknowns known


VS2022 CMake编译失败 Failed to run MSBuild command

环境： win10，VS2022，CMake3.21
运行build脚本编译失败
PS D:\program\Pilot> .\build_windows.bat
-- Building for: Visual Studio 17 2022
-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19044.
CMake Error at CMakeLists.txt:3 (project):
  Failed to run MSBuild command:

    C:/Program Files/Microsoft Visual Studio/2022/Community/MSBuild/Current/Bin/amd64/MSBuild.exe

  to get the value of VCTargetsPath:

    鐢ㄤ簬 .NET Framework 鐨?

请问如何解决呢？

Have you built the project before?
It may be caused by the CMake cache or the missing path of MSBuild.exe.
Could you try to delete the build directory and run the build_windows.bat again?
Maybe this stackflow link can help.

I have tried to delete cache and build again, it still doesn't work neither using cmd or CMake GUI.

Yep, the simple solution is install an additional MSBuild of VS2019. I will choose this way if there is no solution for VS2022 only.
Thank you for your help!

This issue will be closed, please reopen or create a new ticket if still exists.

I find it's the error of CMake 3.21, although 3.21 declared support for VS2022, it runs failed.  CMake 3.23 is ok totally.


Ability to redirect stderr to next process.

Or just manipulate stderr more easily for general purposes.

It's already possible with a custom process setup (using __lua).
A built-in abstraction could be nice, but I don't know how frequent and useful the feature is, and the general solution is not too hard.
-- process (with stderr -> stdout)
local function pr(self, name, ...)
  local args = {...}
  return self:__lua(function()
    assert(unistd.dup2(unistd.STDOUT_FILENO, unistd.STDERR_FILENO))
    assert(unistd.execp(name, args))
  end)
end

sh:__(pr, "echo", "test")()


Kudos on your README 🥇 👏

Expected behavior
A cluttered, unfocused README.
Actual behavior
A perfect README with exactly the info I needed!  🥇
Information about the Issue
Steps to reproduce the behavior

go the homepage of this repo.
be amazed 😮 🤩

I'm glad you find this README useful, thank you @kris-luminar. ❤


Moving grunt-it to c2fo org

Hey Nick, we were planning on making some tweaks to grunt-it. Would it be possible to move this repo to the c2fo org and also get npm publishing rights?

Yeah, definitely! What npm user should I add as owner?

Awesome, you can add me and I will transfer it.

Yeah, I can't transfer to the c2fo org because I don't have admin access there. I added you as a collaborator on Github, and also added aheuermann as owner on npm.

If that doesn't work on Github, I can transfer it to you, and then you can add it to c2fo

ahh, make sense. Yeah, I can't transfer it unless I'm owner it looks like. Could you transfer to me?

requested.

Looks like it's good to go. You should be owner on npm too. Let me know if you need anything else. Thanks!

Thanks for your help!


extra_body parameter support

Confirm this is a feature request for the Node library and not the underlying OpenAI API.

[X] This is a feature request for the Node library

Describe the feature or improvement you're requesting
I can't find the extra_body parameter in openai typescript SDK. Is it possible to support this parameter in typescript?
Additional context
No response

Hi @YunhaoLiu1228, we have no plans to add an extra_body argument, you can send undocumented params like so: https://github.com/openai/openai-node#undocumented-request-params


Fix/using new icons

This PR is meant to remove the old SystemIcon with the new product design icons, it impacts a little bit the appearance of some icons and a little bit the api of some interfaces, please verify

Currently checking why the /faucet is not rendering the side navigation

These icons stay with these colors?

The icons should have the following tokens assigned based on the feature/functionality.
Default Icons / Fallback
kda.foundation.color.icon.base.default
Brand Icons
kda.foundation.color.icon.brand.primary.default
kda.foundation.color.icon.brand.secondary.default
Semantic Icons
kda.foundation.color.icon.semantic.positive.default
kda.foundation.color.icon.semantic.negative.default
kda.foundation.color.icon.semantic.warning.default
kda.foundation.color.icon.semantic.info.default

@KristinaSpasevska does this ⬆ help?


PSR-4 autoloading convention

Describe the bug
Encountered the bug on EasyApiToken due to the filenames are not the same with there corresponding classname.
To Reproduce
I include the the package to the project and it displays a EasyApiTokenDecoderInterface does not exist
Expected behavior
File must be autoload properly by the composer
Additional context

PR merged, thank you for your help.


Failed to retrieve item: status 408: sync did not complete within timeout, please retry the request

Your environment

Operator Version: 1.6.0

Connect Server Version: 1.5.7

Kubernetes Version: v1.27.11+k3s1
What happened?
Tried to get test creds via following yaml
apiVersion: onepassword.com/v1 kind: OnePasswordItem metadata:   name: test spec:   itemPath: "vaults/Systems/items/bi-ha"
What did you expect to happen?
Get secrets as they are present in 1passord on the above path
Steps to reproduce

install via helm and apply the yaml

Notes & Logs
1.7107159215368934e+09  INFO    controller_onepassworditem      Reconciling OnePasswordItem     {"Request.Namespace": "default", "Request.Name": "test"}
1.7107159315644588e+09  ERROR   Reconciler error        {"controller": "onepassworditem", "controllerGroup": "onepassword.com", "controllerKind": "OnePasswordItem", "OnePasswordItem": {"name":"test","namespace":"default"}, "namespace": "default", "name": "test", "reconcileID": "e13a0d04-cff1-4b60-a00a-641f53ac5ea5", "error": "Failed to retrieve item: status 408: sync did not complete within timeout, please retry the request"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:326
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234

Tried lot of different combinations
Diff versions of K3s -- same issue
Diff OS (ubuntu-22.04/debian-12) -- same issue
Disabled app armour -- same issue
single node/multi node k3s -- same issue
Tried rancher desktop -- works
Install k3s on any os using curl -sfL https://get.k3s.io | K3S_TOKEN={{ k3s_token }} sh -
install the operator helm with OP creds and try and retrieve any secrets.

https://github.com/1Password/connect-helm-charts/issues/124


test failure on powerpc64le-unknown-linux-gnu

I'm working on packaging zlib-rs for Fedora Linux as a dependency of rustls and flate2.
I'm getting a test failure on powerpc64le-unknown-linux-gnu:
failures:
---- deflate::hash_calc::tests::crc32_hash_calc stdout ----
thread 'deflate::hash_calc::tests::crc32_hash_calc' panicked at src/deflate/hash_calc.rs:157:9:
not implemented: there is no hardware support on this platform
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    deflate::hash_calc::tests::crc32_hash_calc
test result: FAILED. 74 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.14s
error: test failed, to rerun pass `--lib`

It looks like this test should be gated to #[cfg(not(target_arch = "powerpc64")] or something like that? Or is the failure indicative of an actual problem?

Awesome, thanks for the quick fix!


Sitemap generation fails for subfolder installs

If a site is installed in a subfolder, e. g. example.com/my-site, the generation of the sitemap will fail because the XSLT path is hardcoded to /sitemap.xsl which resolves to example.com/sitemap.xsl instead of example.com/my-site/sitemap.xsl. See:
https://github.com/tobimori/kirby-seo/blob/1175d79fedfc7d4dc43a1d43bb28e5ea187e5ed8/classes/Sitemap/Sitemap.php#L69

Duplicate of #88


Meta tags not reset on navigate

I'm hoping to use this plugin to set specific meta data (title, keywords, og: tags etc) on certain pages, but I want it to fallback to the defaults when you navigate to any page that does NOT specify tag data.
The problem is, it doesn't appear to reset the tags if a user moves to a page that has no overrides.
For example, in my main file I have this:
<!DOCTYPE html>
<html lang="en">
  <head>
    <title>My Test App</title>

    <meta name="keywords" content="standard keywords, more keywords" id="keywords" />
    .... etc ....

I have a view "tagged-view" that has this within it:
head: {
    title: { inner: 'My Special Page' },
        meta: [
            { name: 'keywords', content: 'special keywords, different words', id: 'keywords' }
        ]
    },

Note that I'm using the id attribute to do replacement of the tag, and that's working.
If I go to "/" I see the default title ("My Test App") and default keywords ("standard keywords, more keywords").
Then if I click a router link to go to /tagged-view, I can see the title is now "My Special Page | My Test App", and the keywords have changed to "special keywords, different words".
However, if I then click a router link to go back to "/" I see that title has changed back to the default ("My Test App") but the keywords are still showing the customised version ("special keywords, different words'").  It only resets back to the defaults if I do a full page refresh.
So it seems as though the only way to have a deafult is to actually physically set the keywords etc (for ALL my meta tags) on every single page.
Is this a known/intended behaviour, or is there some config I can set to ensure it resets on every navigation?
Thanks :)

Hello @bronthulke
Thanks for your feedback.
Could you reproduce this example online?

Hey @ktquez, sorry for the delay but I have it up on a live site now where you can see it.
If you got to http://<IP_ADDRESS>:8089/ the default keywords (which are set in my index.html) are shown - that's the keywords ending in "tennis tournament app".  For that home view (home.vue) I do have a set of meta in the vue file and the words are the SAME in there as in the index.html default file.
If you then navigate using the menus to get to Features > League Management, you will see that the keywords meta is updated to be a set ending with "tennis courts near me".
Then if you navigate to Contact Us, you'll see that the keywords stay the same (ending in "tennis courts near me") rather than resetting to the defaults that end in "tennis tournament app".
You'll also see that it's not picking up my default title and appending it to the end, instead it's appending "Vue App".  I do have a default title set ("Str8 Sets Tennis | For Clubs, Players, Competitions") and that was working in my dev build but isn't working as expected in this production build.
I hope this is clear, it's hard to describe it succinctly :)
Thanks!

Just an update on this, the title thing turned out to be our issue (something was going wrong in the build), so it's only the default meta fallback issue that I still have :)

Hey @bronthulke, sorry for the delay. I managed to see the error.
I will do some tests, and soon as done I give you feedback here with the solution or a new fixed version.

@bronthulke
I missed this issue, did you get it?

Hey @ktquez, it's still an issue and unfortunately I haven't even had a chance to dig in any deeper myself.

Having the same issue here, is anyone actively maintaining this? If yes, I'll try to fix this.

@ktquez I fixed this on my side, any tags that have been substituted will get reset on navigate. Open to discuss, whether this could be an intended feature.

Hey @ktquez I'm good. How are you? Just opened #104, do have a look, would love to get feedback.
 How do I go about doing this?


Total rewrite of the codebase

What this PR aims to achieve is a total rewrite of all of Thaumic Boot's code, making it more modular, making it more readable, just making it better.
Likewise, within this we also succeeded in making the toggle systems for the jump and speed boosts, and likewise, at the request of @Alexdoru we set their default keybind to "0" (no key)

I mean at this point, wouldn't it be more sensible to just merge this mod into another thaumic addon? We have so many already and this never got into stable so we have the opportunity to do it without needing to transition items. Especially if you want to make it a hard dep anyway.

I agree with Colen.

Look, that's not happening

Making other mods hard dep on this is also not happening

Making other mods hard dep on this is also not happening

That's fine? It would just solve EMT's issues and allow for other mods to toggle

Making other mods hard dep on this is also not happening

That's fine? It would just solve EMT's issues and allow for other mods to toggle

Optional deps would work IMHO.

Also i didn't get why you chose "serverfiles" for the server side stuff. Like "server" would have been enough.

Also i didn't get why you chose "serverfiles" for the server side stuff. Like "server" would have been enough.

No specific reason, just the mod I was basing it on to set this up did the same thing. It can be changed, it doesn't really matter

Also i didn't get why you chose "serverfiles" for the server side stuff. Like "server" would have been enough.

No specific reason, just the mod I was basing it on to set this up did the same thing. It can be changed, it doesn't really matter

Usually such a package is called net / network / similar

Also i didn't get why you chose "serverfiles" for the server side stuff. Like "server" would have been enough.

No specific reason, just the mod I was basing it on to set this up did the same thing. It can be changed, it doesn't really matter

Usually such a package is called net / network / similar

approved

why close the PR?

Not going to be finished for awhile now

that's why there is a draft mode

Personally I would love to have this implemented.

This mod just caused a crash for me in a modified Polychromatic World modpack (various mods updated):
https://pastebin.com/3h09BL3C
After falling while wearing (unrelated) boots, it crashes, apparently because it can't find ItemElectricCometBoots. Maybe the issue occurs due to IC2/gregtech not being in PW?

This mod just caused a crash for me in a modified Polychromatic World modpack (various mods updated):
https://pastebin.com/3h09BL3C
After falling while wearing (unrelated) boots, it crashes, apparently because it can't find ItemElectricCometBoots. Maybe the issue occurs due to IC2/gregtech not being in PW?

Lmfao hilarious, wrong place to post this though

This repo doesn't have an issue tab, so I wasn't sure where it should go. On further search, it appears to be a duplicate of this...

This repo doesn't have an issue tab, so I wasn't sure where it should go. On further search, it appears to be a duplicate of this...

Lmfao yeah it's supported outside of the pack by me so it's on my repo


Use the Azure portal to collect logs from Azure Storage

Does we have any ARM template to make these changes instead portal

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 054ac0e1-adad-ddb3-5c60-be8aec7ba4f6
Version Independent ID: fcf19224-3f8e-a511-aed7-3479046fd971
Content: Use blob storage for IIS and table storage for events in Azure Log Analytics
Content Source: articles/log-analytics/log-analytics-azure-storage-iis-table.md
Service: log-analytics
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@pawankt
Thanks for the feedback! We are currently investigating and will update you shortly.

@pawankt - Yes, check out this ARM template created by a member of our Azure CAT team - https://azure.microsoft.com/en-us/resources/templates/oms-existing-storage-account/.  Let me know if that doesn't help and in the meantime, I'll add a task to update this article to reference that template and anything else relevant I can include such as using POSH.

This is awesome, let me try

ARM template looks good, but it expecting to create new workspace, although i passed as existingomsname as parameter. Error reporting ad The workspace name xxx is not unique

#in-process

#please-close as I've got this filed and will attempt to address this in our next sprint.


Photo Spheres/360 Image Extension

I was thinking a photo sphere extension would be cool, being able to drag around a 360 image around you and click stuff in the image would be great for games or stuff like virtual tours. You could even add 360 videos using the videos extension. Would this be doable?

This seems like something that you would code into a scratch project yourself, and less of an extenion. I am inexperienced with 3d graphics however, and maybe it could be done.

I've tried before, you can't do it on scratch. The most you can do is drag around the image on screen with no 3d effect.

with the addition of Simple3D i think you can do this yourself without the need for an extension with the sole purpose of making 360 images


Restrict idents as other servers do

Resolves #333 by restricting us to only having ASCII chars in usernames. Applies similar restrictions as Insp and Chary, which is a decent bar I think. This is mostly due to the weirdness of having Unicode names of this fashion, which would likely also stuff us up with regards to having to introduce skeletoning and all down the line in some ways. Just bypass all that junk and have it restricted as put here~

Legit! Couple questions:

Should we also perform this validation for actual ident protocol responses (which do not use SetNames, but assign to client.username directly)?
Do we want an upper limit on length? (Do we already have one in practice due to some other restriction?)

...Yis, we definitely should have something similar, with a fallback if we end up not being able to use it. Stop things like https://github.com/inspircd/inspircd/issues/1033 from happening to us because of dodgy responses.
We should most certainly add something like that (and silently truncate on longer ones, or whatever different behaviour other servers do). I'll take a look and add this, thanks for the shout.


Changed the railtie to use the before_configuration callback so we ca…

What
Changed the Configs Railtie to use the before_configuration callback.
Why
In the current form the Railtie would load after our environment initialization files causing an exception if we tried to call Configs in our environment initialization files. ie. config/environments/development.rb. Using the before_configuration callback allows us to use Configs in our environment initialization files.

cc @cainlevy

Awesome! I've always wanted to use this from environment configuration files.

nice!

@cainlevy or @tiegz want to give this one another look over. I had to make a couple of changes in the testing structure so it would pass on the different versions of minitest and active support under Travis CI.

:+1:


Valid date being marked invalid

The following date results in invalid status:
2022-05-25T16:03:12.2085

when using this:
dateParser.fromAny("2022-05-25T16:03:12.2085");

will return this:
{invalid: 'Unable to parse 2022-05-25T16:03:12.2085'}invalid: "Unable to parse 2022-05-25T16:03:12.2085"[[Prototype]]: Object

but a normal date constructor works fine:

Same thing happens today on Windows, Chrome and iPhone's Safari. Macbook's Chrome parsing ok.

@kolmakova Given that you didn't have some locales installed, can you clarify what is the current behavior and desired behavior?


Revert "Verify the token belongs to the proper user."

Reverts microsoft/azuredatastudio#11593
This reverts the change that introduced https://github.com/microsoft/azuredatastudio/issues/13303

Pull Request Test Coverage Report for Build 354894166

0 of 5 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 40.251%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/azurecore/src/account-provider/auths/azureAuth.ts
0
5
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/azurecore/src/account-provider/auths/azureAuth.ts
4
32.36%

Totals

Change from base Build 354738837:
-0.05%

Covered Lines:
21145

Relevant Lines:
48255

💛  - Coveralls


[BUG]: karavi-observability helm chart: there is no reference to a branching strategy or helm chart changes

Describe the bug
The branching strategy for Karavi Observability is linked to from here: https://github.com/dell/helm-charts/blob/main/charts/karavi-observability/VERSIONING.md.  This link does not point to the correct section in the CONTRIBUTING.md file at the root of the helm-charts repository.  Instead, it should point here: https://github.com/dell/helm-charts/blob/main/docs/CONTRIBUTING.md#branching-strategy.
In addition to this, the branching strategy listed in https://github.com/dell/helm-charts/blob/main/docs/CONTRIBUTING.md#branching-strategy is not correct.  It needs to be clearly stated that merges to the main branch will create a new release/version of the helm chart.  So if changes are being done as part of a feature, the feature should be completed in its entirety on a feature branch before being merged to main.
To Reproduce
N/A
Expected behavior
See above
Screenshots
N/A
Logs
N/A
System Information (please complete the following information):
N/A
Additional context
Documentation change to the karavi-observability helm chart in github.com/dell/helm-charts

/sync

link: 2405

Issues has been fixed


How can I show it for all I have the group Owner and my default group is Spieler and I have many Groups?

How can I show it for all I have the group Owner and my default group is Spieler and I have many more Groups?

In the default config.yml there is an example that uses the word Global and Default. By global we mean that it doesn't matter in which world you are and by default we mean that it doesn't matter which rank you are.
So if you want a specific board for your rank Owner you create a new board and instead of using default you use the name Owner (OR the name of your group).
If you want to display a scoreboard in a certain world you create a new board and change the word Global to the world you want to show it in.


[V3] ios login errors from loginWithEmailAndPassword coming back as undefined

Hi so I'm using the latest v3 branch like this:
export const loginWithEmail = ({ email, password }) =>
((dispatch: Dispatch) => {
  console.log(email, password);
  dispatch({ type: BEGIN_EMAIL_LOGIN });
  firestack.auth()
  .signInWithEmailAndPassword(email, password)
  .then((user) => {
    console.log('firebase sign in succesful: ', user)
    dispatch({
      type: FIREBASE_LOGIN_SUCCESFUL,
    });
  })
  .catch(err => console.log('error logging into firebase ', err));
});

which works if I provide the right email and password, but any error I get back is just coming back as an object with code of "" and message of undefined:

once I have some error messages to go off I'm finally going to get around to making that error code nromalising module Ive been promising forever, but I need an error code haha

@SamMatthewsIsACommonName , I have created a pull request to resolve this precise issue : https://github.com/fullstackreact/react-native-firestack/pull/304 seems to be due to a variable name mismatch.

Hey @jsbranco thanks that's interesting and as you say does work. The error codes are all new yet again haha (possibly the 5th format of error codes we've had so far) We've been working on this kind of on an alternative branch and it was noted that a problem was arising as a result of the  '/auth' extension in the lib/modules/auth/index.js file, as referenced here: https://github.com/Salakar/react-native-firestack/pull/18 . You'll see there I also made a kind of quick and dirty switch module for standardising a message output and if you look there you'll see all the different 'error codes' I've gotten up to this point. It is all kind of a mystery to me haha!

@SamMatthewIsACommonName I see, so in V3 it shouldnt be using auth/? Or simply the auth/ format was changed but the ios files were not updated as per the latest :)?
I am just asking to check if my change is correct as that fix was honestly from debugging and trying to trace the issue

I'm honestly not sure haha... I mean both kind of work but in different ways (ie they produce completely different error codes)

May I vote for https://github.com/fullstackreact/react-native-firestack/pull/304 to be merged into this fork?

@designorant my personal vote would be for you solution of removing the '/auth' as that produces error codes which are at least documented in some places... i.e the error in the example would be 'code: 17007, message: 'The email....'
The error codes produced by this solution scare me a bit as I can't find mention of them anywhere, whereas there's an exhaustive list available of the '17000' type codes

@jsbranco are you able to try with your solution as well as removing the '/auth', and see what codes you get?

So I just tried to remove "auth/" as such :
   return promisify('signInWithEmail', FirestackAuth)(email, password);
And my error code is different,  is now as:

Object {code: "272115", message: "The email address is already in use by another account."}

Thanks so that's no change right? Would you be able to keep the '/auth' removed and revert your solution back to how it was and see if you get an error code of 17007? I'm just trying to establish that there is actually some level of consistency

Sorry @SamMatthewsIsACommonName  I just checked.. it was still running the code with auth/ so after fresh restart, the error object has an additional attribute after removing "auth/" although error code is still the same:
Object {error: "createUserWithEmailError", message: "The email address is already in use by another account.", code: "272115"}

Without my changes and without auth/ the result is the following:

Object {error: "createUserWithEmailError", name: 17007, description: "The email address is already in use by another account."}

OK great thanks so much for testing that out. Well that all being the case my vote would still be for the one that produces the 17007 purely because there are resources such as this one documenting all the codes:
http://stackoverflow.com/questions/27420176/list-of-authorisation-errors-with-firebase-login
However the flip side is with that solution the android codes go from being the nice and well documented 'auth/email-in-use' type to 'ERROR_EMAIL_IN_USE' type which are harder to find documentation of.

Oh, sorry, I only now realised that we're getting totally different code numbers there.
Since it seems to be related to #252, it would be great to see whether @Salakar and @chrisbianca have any thoughts on what's going on here.

@SamMatthewsIsACommonName  thats right, 17007 is coming as name rather than code. If I assign it as code it will trigger a lowerCase function not applicable in javascript. Because the code is suppose to be a string ( I believe).
The interesting thing is if I debug the error object in Objective C I do see the code as 17007, but I am doing a casting
                                   @"code":  [NSString stringWithFormat:@"%d", @([error code])]
Which for some reason is giving that 27... code which is not suppose to. As I mentioned earlier,  I am not too familiar with Objective-C I just looked into casting in Objective-C and applied it.

Can you try NSString stringWithFormat:@"%i" as if you were beginning with an integer?

@SamMatthewsIsACommonName  I just did this :
                                   @"code":  [NSString stringWithFormat:@"%d", [error code]] and it give sthe 17007 now. I will try to add back auth/ and see what comes up

@SamMatthewsIsACommonName  without auth/ and with the fix of casting the result looks better:

Object {code: "17007", message: "The email address is already in use by another account."}

Yeah that looks good! Currently without '/auth' I'm getting the code as a number so will be much more consistent to have it as a string

I shall update my PR with the casting change

@SamMathewIsACommonName just wanted to check if there is anything else I need to do in the PR to get it approved? Since it is my first commit in this repo thought its best to double check :)

@SamMathewIsACommonName I just updated my PR since I  was also having the following issue when using signWithEmailAndPassword :

The commit follows the same changes I did for create a user with email / password :
https://github.com/fullstackreact/react-native-firestack/pull/304/files/3e7490883c8d9b4f0443a8f58f58a91dd097012e..948b882231c1d30cd8b502e2f3ba08b8602aff55

Awesome! I think @auser is responsible for committing pull requests on this branch. Looks good though!

@auser  is there anything else required from my side (update docs or other step) as this  my first PR on this library.
Kind Regards
Junio

+1


float128 -> longdouble

Background: Not all Python/numpy builds have np.float128 (cough Windows/Mac?):

https://github.com/winpython/winpython/issues/613
https://github.com/numpy/numpy/issues/10288

Prevents errors of the form:
Traceback (most recent call last):
  File "/Users/mdiener/Work/emirge_lazy/meshmode/test/test_visualization.py", line 180, in test_visualizers
    vis.write_xdmf_file(f"{basename}.xmf", names_and_fields, overwrite=True)
  File "/Users/mdiener/Work/emirge_lazy/meshmode/meshmode/discretization/visualization.py", line 958, in write_xdmf_file
    gnodes = DataArray.from_dataset(dset)
  File "/Users/mdiener/Work/emirge_lazy/miniforge3/envs/ceesd_lazy/lib/python3.8/site-packages/pyvisfile/xdmf/__init__.py", line 981, in from_dataset
    item = _data_item_from_numpy(dset,
  File "/Users/mdiener/Work/emirge_lazy/miniforge3/envs/ceesd_lazy/lib/python3.8/site-packages/pyvisfile/xdmf/__init__.py", line 474, in _data_item_from_numpy
    ntype=DataItemNumberType.from_dtype(ary.dtype),
  File "/Users/mdiener/Work/emirge_lazy/miniforge3/envs/ceesd_lazy/lib/python3.8/site-packages/pyvisfile/xdmf/__init__.py", line 313, in from_dtype
    elif dtype.type in (np.float16, np.float32, np.float64, np.float128):
  File "/Users/mdiener/Work/emirge_lazy/miniforge3/envs/ceesd_lazy/lib/python3.8/site-packages/numpy/__init__.py", line 303, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'float128'

cc: @alexfikl

Sorry @inducer , I think you have to approve each CI run :-/