(experimental) re-export cpython items

This is an experimental change that will addresses https://github.com/ilianaw/rust-crowbar/issues/45. If this checks out users of rust crowbar will no longer have to declare cpython as a dependency in their Cargo.toml of lib.rs files.

I'm going to do a bit more integration testing but I wanted to iterate early to show what this could look like

@ilianaw, I feel less rushed with this change knowing that 0.3 was just published. I got antsy because I saw 0.4 milestone items were closing out and it looked like there was some release prep for that. I'd be able to do a bit more testing on this but let me know what you think.

The crowbar 0.3.0 milestone is still open, it's cpython-json 0.3.0 that was published :)
In my experience reexporting crates back when I first developed this was difficult.
This feels like a hack (anything involving #[doc(hidden)] feels like one to me) but I think the developer experience is worth it. I'm going to give it some more thought after a bit but I expect I'll merge this as-is. More testing would be much appreciated though :)

I'll try testing more cases. I'm open to alternate approaches. Coming from the jvm world of transitive dependencies re-exporting in rust does feel a bit off. I can see where it makes sense through when considering macros. Macros are just code that generates code. If the crowbar macro generates code that expands to another crates macros then it's understandable to need to add the other macro use. It's just an odd ux for users because that's just an impl detail that bleeds through. Reexportingbis a tactic for making that detail #[hidden] :)

I'm definitely fine with requiring Rust 1.30 for 0.3.0 for macro re-exports :)

I'm going to experiment with this a bit. So far not having much luck. After moving to #[macro_export(local_inner_macros)] I see
---- src/lib.rs -  (line 25) stdout ----
error[E0433]: failed to resolve. Could not find `py_module_initializer` in `$crate`
 --> src/lib.rs:29:1
  |
5 | / lambda!(|event, context| {
6 | |     println!("hi cloudwatch logs, this is {}", context.function_name());
7 | |     // return the event without doing anything with it
8 | |     Ok(event)
9 | | });
  | |___^ Could not find `py_module_initializer` in `$crate`

I've got some direction from these to be published docs https://github.com/rust-lang-nursery/edition-guide/pull/117/files#diff-4e57182b623c416bc83329f6a7307ec9R177. The foreign macros crowbar uses needed the cpython:: path prefix. I'm going to experiment with this a bit more and report back.

Oof! that worked but using the lambda macro then requires the user to import all of the helper macros that cpython uses inside its macros. I'm going to see if I can't reach out to the cpython crates author about making this a bit more convenient for its users.
I added the following one by one until I got crowbars doc tests to work
use cpython::{
  py_argparse_parse_plist,
  py_argparse_parse_plist_impl,
  py_fn_impl, py_method_def,
  py_argparse_raw,
   py_argparse_impl,
   py_argparse_extract,
   py_replace_expr,
  py_argparse_param_description
};

wanted to leave an update on this as I'm still keeping an eye on the cpython issue. still no progress towards using the 1.30.0 stable form of $crate::/local_inner_macros as an alternative to re-exporting. I'm not sure how active that project is so I'm not sure how long to sit on the upstream solution. I could maybe circle back and see if there's an alternative way.

In terms of upstream, see #19 and... some possibly exciting news: https://github.com/PyO3/pyo3/issues/210 — looks like PyO3 is willing to part with specialization for now in order to build on stable.

Nice. That may end out being a safer bet. I'm getting the impression cpython crate is not very actively maintained. That makes it harder for crates like this to evolve :/ Have you started experimenting with pyo3 yet?

Have you started experimenting with pyo3 yet?

Not at all :(

nod
Enjoy your vacation :)

Dropping the 0.3.0 milestone while we figure out a path forward here.


Add support for outlined buttons

Thanks for the PR. Outlined buttons were actually renamed from stroked, so this PR should replace any instances of stroked with outlined. Currently both exist in this PR.
See #57.
cc @moog16 since he entered all of the tasks necessary for upgrading to MDC Web 0.35.

Related screenshot tests PR: https://github.com/material-components/material-components-web-react/pull/78.
@patrick91 could you please sign it?

@patrick91 https://github.com/material-components/material-components-web-react/pull/78 tests are passing! Will merge :)


Bug: Unable to extract data from the last LinkedIn post published by Jérémy Ravenel

The system failed to retrieve post interactions from the LinkedIn profile URL: https://www.linkedin.com/in/jeremyravenel/. Please investigate the issue with the LinkedIn integration or the data extraction process. Steps to reproduce:

Attempt to extract data from the last LinkedIn post published by Jérémy Ravenel using the LinkedIn integration.
Observe the failure in retrieving post interactions.
Verify the LinkedIn profile URL is correct and accessible.
Check the LinkedIn integration and data extraction process for any errors or misconfigurations.

Fixed


Run arbitrary gulp commands

Instead of showing each available task, prompt the user with a text input to run a task (or flag) with gulp

Done on version-5/run-arbitraty-commands


An issue

I installed the pservercms and it is working but there is a problem with zend-mvc, it gives me an error says deprecated. Could you please update the zend-mvc files>

it is in progress

Ok, good. When will it be fixed?

hope next week, check my commits i done that for the most modules, but not done
and yeah i read your issue at zend-mvc^^

Cool ^^ could you please check the solution which weierphonie gave me? It should work. He gave me a lot of solutions but I can't do any of them because I',m not really good in CMS or php.
 I tried it already, I made git pull, php composer.phar update and self update but this didn't hide the problem

no the problem comes with zend-mvc 2.7, they set the old workflow on deprrcated so it must be changed now everything to the factory system or the lacy_service systen and in that i work atm, but its a lot of work

take your time, I disabled error log temporarily until you fix it ^^ it works well now.
Uebrigens, ich kann ein bisschen Deutsch sprechen und schreiben. Du kannst mir alles auf Deutsch erklaeren und ich werde verstehen xD

enable the debug-system
maybe problems with mssql connect or a extension missing

Ok, I will try to fix it. The last questions I have are:
1- How to change the sliders? What is their path?
2- How to change the web title?
3- How to change the background colour?
Thank you for your help and being kind :)

you have to change the layout check https://github.com/kokspflanze/pserverCMSFull#how-to-change-the-layout

This made me only able to change the title. However, after searching for a long time, I found a way to change the sliders. Now I would like to change the background color to black. Could you please tell me how? The custom layout doesn't contain something like this

add in your custome layout a new css file and change it there.

should be fixed with https://github.com/kokspflanze/PServerCore/releases/tag/0.4


Improved remote file explorer features

When deleting large or many files in a remote session, VS Code is very slow. It takes much longer to delete than removing the file(s) via the terminal (i.e. with rm). It also seems to block use of the file explorer until the files are removed. The program often hangs at this point and I have to restart. It would be nice if the files could be deleted as quickly as removing thru an integrated terminal session.
Also, when being alerted that a file is too large to open, there are only two options: Configure memory limit or restart VS Code. It would be useful to dismiss this and not open the file.

\duplicate https://github.com/microsoft/vscode/issues/134653


mockImplementation and throwing errors

Describe the bug
When porting a Jest test suite to vitest, I stumbled on a behavior difference.
Consider the following code to test (main.ts):
import { useUtils } from "./utils";

export function main() {
  try {
    useUtils().something();
    console.log("something called");
  } catch (e) {
    console.log("something threw");
  }
}

A Jest test to test if the console log properly the success and error could look like:
import { main } from "./main";

const utils = {
  something: jest.fn(),
};

jest.mock("./utils", () => ({ useUtils: () => utils }));
const log = jest.spyOn(console, "log");

describe("main", () => {
  test("should call", () => {
    main();
    expect(utils.something).toHaveBeenCalled();
    expect(log).toHaveBeenCalledWith("something called");
  });

  test("should throw", () => {
    utils.something.mockImplementation(() => {
      throw new Error("oh no");
    });
    main();
    expect(utils.something).toHaveBeenCalled();
    expect(log).toHaveBeenCalledWith("something threw");
  });
});

Note that the second test replaces the implementation of the something function to throw an error.
When porting this test to Vitest, the second test fails:
import { describe, expect, test, vi } from "vitest";
import { main } from "./main";

const utils = {
  something: vi.fn(),
};

vi.mock("./utils", () => ({ useUtils: () => utils }));
const log = vi.spyOn(console, "log");

describe("main", () => {
  test("should call", () => {
    main();
    expect(utils.something).toHaveBeenCalled();
    expect(log).toHaveBeenCalledWith("something called");
  });

  test("should throw", () => {
    utils.something.mockImplementation(() => {
      throw new Error("oh no");
    });
    main();
    expect(utils.something).toHaveBeenCalled();
    expect(log).toHaveBeenCalledWith("something threw");
  });
});

Reproduction
https://github.com/cexbrayat/vitest-catch
The repro is a vanilla-ts vite project, with both the Jest and Vitest tests (main.jest.spec.ts and main.vitest.spec.ts).
Use yarn jest and yarn vitest to launch the tests.
yarn vitest fails with:
$ vitest src/main.vitest.spec.ts

 WATCH  /Users/ced-pro/Code/test/cli-tests/vitest-catch

stdout | src/main.vitest.spec.ts > main > should call
something called

stdout | src/main.vitest.spec.ts > main > should throw
something called

 ❯ src/main.vitest.spec.ts (2)
   ❯ main (2)
     √ should call
     × should throw

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/main.vitest.spec.ts > main > should throw
AssertionError: expected "log" to be called with arguments: [ 'something threw' ]
 ❯ src/main.vitest.spec.ts:24:16
     22|     main();
     23|     expect(utils.something).toHaveBeenCalled();
     24|     expect(log).toHaveBeenCalledWith("something threw");
       |                ^
     25|   });
     26| });

  - Expected  -0
  + Received  +0

    Array [
  -   "something threw",
  +   Array [
  +     "something called",
  +   ],
  +   Array [
  +     "something called",
  +   ],
    ]

System Info
System:
    OS: macOS 12.0.1
    CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
    Memory: 70.41 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.1 - ~/.volta/tools/image/node/16.13.1/bin/node
    Yarn: 1.22.10 - ~/.volta/tools/image/yarn/1.22.10/bin/yarn
    npm: 6.14.15 - ~/.volta/tools/image/npm/6.14.15/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Firefox: 95.0.2
    Safari: 15.1
  npmPackages:
    vite: ^2.7.2 => 2.7.10
    vitest: 0.0.135 => 0.0.135

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi @sheremet-va, I'm still get this error with my senior @juacompe.
Reproduction
https://github.com/poorprogrammer/cfo/commit/0a726fcc93a578cfd10d44c6201f4c50c5e2a9bf#diff-c6d94278ab82b9448cd838edb7697c8349a8c27e8f5c24daf896c50a95b72824R18
This part of code from Vue 3 + Vite + Vitest project, porting from Vue 2 + Jest.

presenters/__tests__/Login.spec.js

import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import { LoginPresenter } from "@/presenters/Login";

class MockView {
  goTo() { }
}

describe("Login Presenter", () => {
  let p = new LoginPresenter(new MockView());

  const jsdomAlert = window.alert;
  beforeEach(() => {
    window.alert = vi.fn();
  });
  afterEach(() => {
    window.alert = jsdomAlert;
  });

  /* ...... */

  it("should redirect to home page after login success", async () => {
    givenLoginSuccess();
    await p.login();
    expectToRedirectToHomePage(p.view);
  });
  /* ...... */

  function expectToRedirectToHomePage(view) {
    expect(view.goTo).toHaveBeenCalledWith({ name: "home" });
    // expect(view.goTo).toHaveBeenCalled();
  }
});

presenters/Login.js

import API from "@/services/login";
export default class {
  constructor(view) {
    this.view = view;
    this.API = new API();
  }
  login() {
    this.API.login(this.username, this.password)
      .then((token) => {
        localStorage.setItem("token", token)
        this.view.goTo({name: 'home'})
      }, (error) => {
        this.showError(error);
      });
  }
  showError(error) {
    alert(error)
  }
}

When run test with npm run test, get error like this:
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/presenters/__tests__/Login.spec.js > Login Presenter > should redirect to home page after login success
AssertionError: expected "goTo" to be called with arguments: [ { name: 'home' } ]
 ❯ expectToRedirectToHomePage src/presenters/__tests__/Login.spec.js:50:23
     48|   }
     49|   function expectToRedirectToHomePage(view) {
     50|     expect(view.goTo).toHaveBeenCalledWith({ name: "home" });
       |                       ^
     51|     // expect(view.goTo).toHaveBeenCalled();
     52|   }
 ❯ src/presenters/__tests__/Login.spec.js:29:5

  - Expected  - 3
  + Received  + 5

    Array [
  -   Object {
  -     "name": "home",
  -   },
  +   Array [
  +     Object {
  +       "name": "home",
  +     },
  +   ],
    ]

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

Test Files  1 failed (1)
     Tests  1 failed | 3 skipped (4)
      Time  2.86s (in thread 3ms, 85531.79%)

System Info
"vite": "^2.8.4"
"vitest": "^0.5.4"

If you have any feedback or suggestions to resolve this error, please let us know.
Thank you

Please open a new issue


Giving another go to AOT fixes

Codecov Report

Merging #369 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   64.37%   64.37%
=======================================
  Files          13       13
  Lines       29491    29491
  Branches      139      139
=======================================
  Hits        18985    18985
  Misses      10431    10431
  Partials       75       75

Impacted Files
Coverage Δ

modules/ng2-tag-input.module.ts
50% <ø> (ø)
:arrow_up:

spec-bundle.js
64.18% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fcc76...125f594. Read the comment docs.


PLAT-1840 Meridiem is not displaying in time picker when the Locale i…

…s set to Use Default
Enyo-DCO-1.1-Signed-off-by: Art Dahm<EMAIL_ADDRESS>

Will not fix.


local.yml docker build fails

What happened?
Tried doing docker-compose up  on local.yml.  It threw out the following error
ERROR: mpfr3-3.1.5-r1: Protocol error
(10/16) Installing mpc1 (1.0.3-r1)
(11/16) Installing libstdc++ (6.4.0-r5)
ERROR: libstdc++-6.4.0-r5: Protocol error
(12/16) Installing gcc (6.4.0-r5)
(13/16) Installing python3 (3.6.3-r9)
(14/16) Installing python3-dev (3.6.3-r9)
(15/16) Installing musl-dev (1.1.18-r3)
(16/16) Installing build-deps (0)
Executing busybox-1.27.2-r11.trigger
2 errors; 173 MiB in 47 packages
ERROR: Service 'django' failed to build: The command '/bin/sh -c apk update   && apk add --virtual build-deps gcc python3-dev musl-dev   && apk add postgresql-dev   && apk add jpeg-dev zlib-dev freetype-dev lcms2-dev openjpeg-dev tiff-dev tk-dev tcl-dev   && apk add libffi-dev py-cffi   && apk add gettext   && apk add postgresql-client' returned a non-zero code: 2

This happened on Macbook pro

I have the same problem, olso on a Mac OS

ERROR: unsatisfiable constraints:
openssl-dev-1.0.2o-r2:
conflicts:
libressl-dev-2.7.4-r0[pc:libcrypto=1.0.2o]
libressl-dev-2.7.4-r0[pc:libssl=1.0.2o]
libressl-dev-2.7.4-r0[pc:openssl=1.0.2o]
satisfies: world[openssl-dev]
libressl-dev-2.7.4-r0:
conflicts:
openssl-dev-1.0.2o-r2[pc:libcrypto=2.7.4]
openssl-dev-1.0.2o-r2[pc:libssl=2.7.4]
openssl-dev-1.0.2o-r2[pc:openssl=2.7.4]
satisfies:
postgresql-dev-10.4-r0[libressl-dev]
ERROR: Service 'django' failed to build: The command '/bin/sh -c apk update   && apk add --virtual build-deps gcc python3-dev musl-dev   && apk add postgresql-dev   && apk add jpeg-dev zlib-dev freetype-dev lcms2-dev openjpeg-dev tiff-dev tk-dev tcl-dev   && apk add libffi-dev openssl-dev py-cffi   && apk add gettext   && apk add postgresql-client' returned a non-zero code: 3

This seems to work on my end. Is it still a problem or was it a temporary issue? Can you try with verbose output?
# Rebuild only the django image
docker-compose -f local.yml build django
# Rebuild with verbose output
docker-compose --verbose -f local.yml build django

Can you confirm which version of the project you used as the base, please?

Closing due to lack of activity. Let us know if this is still an issue.


userProfile method is protected even though it's an easy way to access user info

Describe the bug
I would love to be able to access the userProfile method in my remix app to identify the currently logged in user.
Auth0-js has this functionality built in the client and i think we should expose it here unless i'm missing something
Your Example Website or App
https://stackblitz.com/none
Steps to Reproduce the Bug or Issue

Expected behavior
I would love to have an easy way to get the use info from the auth0 strategy/authenticator
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

You get that information when the verify callback you pass to the strategy is called
There you can do whatever you want with the data, including returning it so it’s going to be accessible when calling isAuthenticated


extend users and roles capabilities

Implement a bunch of things proposed in #8516

Option to force a user to change their password on their next logon.
Prevent reuse of recent N passwords.
Task to suspend inactive users.

Providers to prevent user suspension based on a flag or on specific roles.

Action allowing a user to resend their confirmation email.

Rate limiting on this would require discussion because there are several possible "conditions" to limit rate (e.g. send max N emails in a given time; wait at least a given timespan before sending further email...).

Flag to "protect" a user from having to change their expired password.

I'm creating the PR so that we can discuss the way @HermesSbicego-Laser and I implemented this. @sebastienros please review this and involve whoever you feel is necessary for the discussion.

to be fair, this should be merged after #8521 and #7944


Multiple scroll bars in process explorer

Issue Type: Bug
open process exporer will reproduce it.
VS Code version: Code 1.62.3 (ccbaa2d27e38e5afa3e5c21c1c7bef4657064247, 2021-11-17T08:11:14.551Z)
OS version: Windows_NT x64 10.0.18362
Restricted Mode: No
Remote OS version: Linux x64 5.11.0-38-generic

Let's track this in https://github.com/microsoft/vscode/issues/83571 which is also related to the scroll bars.


[WIP] Improve error reporting with 'failure' crate

Attempts to tackle #163
As the title suggests, this is very much a work in progress.

Tarpaulin uses a develop branch for general development and keeps master just for releases and any readme updates that people need to see. So if you could move this to branch off the develop branch and also update the tests to use the new interface.
I do like how the code has changed in terms of the error enum and the launch_tarpaulin function though. Failure definitely makes things look nicer :+1:

Tarpaulin uses a develop branch for general development and keeps master just for releases and any readme updates that people need to see.

Oh, oops, right.

So if you could move this to branch off the develop branch and also update the tests to use the new interface.

Will do once I'm done :)

Okay so I went over all the println! statements in src/statemachine.rs to categorise them and here is a list. I've put the line number based on the latest commit on your branch and also a brief description of the message just in case they've moved around.
src/statemachine.rs

Line 89 timeout error - error!
Line 102 timeout error - error!
Line 124 existing printout error! capture the type and print it out in a debug!
Line 178 unexpected signal warn!
Line 182 error starting test error!
Line 191 failed to trace child threads error!
Line 201-204 PIE error error!
Line 210 address clash warn!
Line 214 failed to instrument error!
Line 319 error during run coverage maybe wrong warn!
Line 320 error message in e error!
Line 384 385 disabling hit count stuff warn!

Another thing, if log level debug is set I think it should override the verbose config option to true.
I'll be running this on a few different things and seeing what it's like to see if I have any other comments but good work :+1:. Once my current comments are addressed the minimum after that is to update the README mentioning how to change the log level and also updating the example tarpaulin output in the command line section

Another thing, if log level debug is set I think it should override the verbose config option to true.

Uh? We set log level to debug only if verbose is set

src/statemachine.rs ...

I suppose we should handle the errorengis Result then instead of error!

So does the RUST_LOG environment variable not potentially affect the behaviour as shown in the env_logger readme? I'm happy to just use the additional flags instead of RUST_LOG I'm just conscious that if it has an effect on the output people may start to rely on it

I'm just conscious that if it has an effect on the output people may start to rely on it

Doing it the way I'm currently doing it makes it impossible to do stuff like:
RUST_LOG=cargo_tarpaulin=info,someothercrate=debug
I suppose we could probe for the RUST_LOG env variable and only apply the log filter if it isn't set.

Nah how it is currently looks fine to me, I hadn't checked the changes in src/main.rs yet. I'll give it a proper look either today or tomorrow :+1:

I suppose we should handle the errorengis Result then instead of error!

I meant to ask about this, but what did you mean by this?
Also I'm not 100% on this stylistically
[INFO  cargo_tarpaulin] Coverage Results:
[INFO  cargo_tarpaulin] Uncovered Lines:
[INFO  cargo_tarpaulin] src/lib.rs: 6
[INFO  cargo_tarpaulin] src/unused.rs: 4-6
[INFO  cargo_tarpaulin] Tested/Total Lines:
[INFO  cargo_tarpaulin] src/lib.rs: 5/6
[INFO  cargo_tarpaulin] src/unused.rs: 0/3

I think I'd prefer something like below for readability.
[INFO  cargo_tarpaulin] Coverage Results:
Uncovered Lines:
src/lib.rs: 6
src/unused.rs: 4-6
Tested/Total Lines:
src/lib.rs: 5/6
src/unused.rs: 0/3

Also, don't want to be annoying but is it possible to change it to print the log level and tarpaulin instead of cargo_tarpaulin?
So yeah comments in this and the changes to src/statemachine.rs. Plus the README still needs to be updated to show how tarpaulin's output has changed if you run it on the simple project and then I think I'll be happy merging this :smile:

Also I'm not 100% on this stylistically
...
I think I'd prefer something like below for readability.

Ah, I agree, that does look better.

Also, don't want to be annoying

Do not worry about that, "annoy" me as much as you like, that way we get the best result :)

is it possible to change it to print the log level and tarpaulin instead of cargo_tarpaulin?

Ah, so something like [INFO tarpaulin] log_message?

I meant to ask about this, but what did you mean by this?

Oops, did some fairly big typos in my comment there :)
Instead of doing error! we should use result and do return Err(RunError::SomeError(ErrorMessage)); - unless we can recover from the error in the function itself? Haven't looked at it yet.

Ah, so something like [INFO tarpaulin] log_message?

That's exactly it

Instead of doing error! we should use result and do return Err(RunError::SomeError(ErrorMessage)); - unless we can recover from the error in the function itself? Haven't looked at it yet.

Well some like a test timing out means you may not have the full results or even any from that test but the other tests tarpaulin runs might be fine. Whereas ones like the PIE error means everything is going to be messed up. So it's kind of some but bad results versus completely useless. In reality I don't think any of them are recoverable but for some you might want to carry on doing the update loop until the test has exited just so you don't leak resources.

In reality I don't think any of them are recoverable but for some you might want to carry on doing the update loop until the test has exited just so you don't leak resources.

Alright. Shouldn't the calls to data.cleanup() do that though? I'll think of something nice to call that when we get a StateMachine error.

@Cogitri are you going to have time to work on this, this week or next?

Will work on this this evening and tomorrow :)

I'll go ahead and do one-change-per-commit commits so it's easier for you to comment on them. I guess you can squash them once this is good to go.

Alright, tarpaulin works again, but error handling is a little broken right now due to me being unsure what can be recovered from and what not. Will have to pour more work into this tomorrow.

Yeah I was going to go for 0.7.0 but don't bother changing the version number in Cargo.toml, I'm going to try and slide a few more things in before a release

@Cogitri how's it going? You'll have to do a rebase because I updated some dependencies in the Cargo.toml.

Ah, sorry. I have to write a paper until Friday, will work on it over the weekend

That's alright, it's getting near the Christmas holidays anyway so I don't expect it anytime soon.

Alright. Note that does work in theory, but I have to figure out why tarpaulin sometimes errors out when it shouldn't - I guess sometimes TestState::Timeout/Abort have been handling gracefully where they aren't now.

Hm, how can I properly debug tarpaulin? When I run tarpaulin from ./target/debug/cargo-tarpaulin tarpaulin it seems as if it can't get the path to the cargo executable :/

Have you had a look at the wiki? I've got some developer guidance on there to try and make tarpaulin understandable to newcomers.
If I have time later I'll clone your branch and see if I can see what's wrong.

Ah, thanks. I've been kind of sparse on time for Rust the last few days.


UNR-3633 - Clarify options for number of workers launched

Release note
Clarify the name of the manually entered number of server-worker to be launched in the editor option.

Katharine approved the change on Slack, I'll merge as soon as the build passed


[Idea] Replacement for AndroidX Preferences

Compose is missing a replacement for androidx.preference.
I think this might be a good place to provide a replacement.
There is an incomplete alternative at https://github.com/Sh4dowSoul/ComposePreferences
This seems similar to the other features of this repository. Thank you for your consideration.

We have no plans to work on this in Accompanist at the moment. As there are already a few external libraries which support this, I'm going to close this.

OK. Can you tell me which ones you found? I only found the one I listed above which I had to modify pretty heavily to work for my purposes.

https://github.com/alorma/Compose-Settings and https://github.com/Sh4dowSoul/ComposePreferences are the two that I'm aware of. I haven't looked deeply at either implementations though so don't take this as a recommendation.

Thanks. Hopefully one of them eventually provides an adequate replacement.

@chrisbanes still no plans to support this?


[5.8] Fix exception handling on transaction commit in DB::transaction()

When an exception occurs during commit (which can happen due to serialization failures, dropped connection, etc), DB::transaction() tries to roll back the current transaction. This results in another exception being thrown on rollback because there is no active transaction; the original exception is lost.
This PR modifies DB::transaction() to handle exceptions during commit properly, without trying to roll back. Additionally, it retries the transaction if the commit error was caused by a serialization failure.
This does not modify the existing retry logic, but simply pulls the commit operation out so that errors there can be handled separately. The tests covering the existing logic pass with no modifications.

Can you provide a simple example that demonstrates this issue?

@staudenmeir so it turns out there are two distinct situations where Laravel doesn't handle serialization failures correctly. This PR originally fixed the second one I will describe below. The first one is fixed by abaff32.
Note that the examples use PostgreSQL. They could be modified to work with other DBMSes.
Case 1: Serialization failure occurs on update (fixed: abaff32)
Setup:
CREATE TABLE IF NOT EXISTS pr_29067_table (
	id SERIAL,
	value INT NOT NULL
);

INSERT INTO pr_29067_table ( value ) VALUES ( 2 );

Then run two instances of this code side by side in Tinker:
DB::transaction( function () {
        DB::statement( 'SET TRANSACTION ISOLATION LEVEL SERIALIZABLE' );

        DB::table( 'pr_29067_table' )->where( 'id', '=', 1 )->update( [ 'value' => \DB::raw( 'value + 1' ) ] );
        // This line makes sure that the transactions are actually concurrent.
        readline( 'Start another instance of this snippet and then press Enter>' );
    }, 3 );

Expected result (what you get if you run with this PR):
One of the instances immediately ends after pressing Enter. The other automatically runs a second try, which succeeds.
Actual result (what you get if you run with the current release of Laravel):
One of the instances immediately ends after pressing Enter. The other fails with this (or similar) exception:
Illuminate/Database/QueryException with message 'SQLSTATE[40001]: Serialization failure: 7 ERROR:  could not serialize access due to concurrent update (SQL: update "pr_29067_table" set "value" = 3 where "id" = 1)'

Case 2: Serialization failure occurs on commit (fixed: b78bf2d)
This scenario is adapted from https://wiki.postgresql.org/wiki/SSI#Black_and_White
Setup:
create table pr_29067_table2
  (
    id int not null primary key,
    color text not null
  );
insert into pr_29067_table2
  with x(id) as (select generate_series(1,10))
  select id, case when id % 2 = 1 then 'black'
    else 'white' end from x;

Run this code in Tinker:
    DB::transaction( function () {
        DB::statement( 'SET TRANSACTION ISOLATION LEVEL SERIALIZABLE' );

        DB::table( 'pr_29067_table2' )->where( 'color', '=', 'black' )->update( [ 'color' => 'white' ] );
        // This line makes sure that the transactions are actually concurrent.
        readline( 'Start another instance of this snippet and then press Enter>' );
    }, 3 );

Before pressing Enter, run this opposite code in another instance of Tinker:
    DB::transaction( function () {
        DB::statement( 'SET TRANSACTION ISOLATION LEVEL SERIALIZABLE' );

        DB::table( 'pr_29067_table2' )->where( 'color', '=', 'white' )->update( [ 'color' => 'black' ] );
        // This line makes sure that the transactions are actually concurrent.
        readline( 'Start another instance of this snippet and then press Enter>' );
    }, 3 );

The updates initially succeed; however, PostgreSQL identifies a serialization error when the second transaction tries to commit.
Expected result (what you get if you run with this PR):
One of the instances immediately ends after pressing Enter. The other automatically runs a second try, which succeeds.
Actual result (what you get if you run with the current release of Laravel):
One of the instances immediately ends after pressing Enter. The other fails with this (or similar) exception:
PDOException with message 'There is no active transaction'

Note that this is not the real exception! The real exception was a serialization failure very similar to the one in Case 1. However, because the exception occurred on commit, the transaction was automatically rolled back, leading to the exception of There is no active transaction.

Technically, this may now amount to a breaking change. Let me know if I need to split this into two PRs: I could make one targeting 5.8 to fix the rollback bug, and one targeting 5.9 to handle serialization failures in addition to deadlocks.

@jansennerd10 I've retargeted this to the master branch because of the breaking changes.

@driesvints your review is still marked "changes requested," but all your comments are resolved. Do you have additional issues you'd like me to address?

@jansennerd10 sorry, forgot to dismiss it.

I know you guys have a lot to deal with, but my team is waiting on the outcome of this PR to fix issues we're having in our Laravel app. Any idea when there might be an update? Thank you!

@jansennerd10 even if this PR gets merged soon, the next major release is only coming out in September the earliest.

@driesvints true, but if we know that this issue is going to be fixed in that release we can plan accordingly and use the master branch in our development versions until 5.9 is released. If it won't be fixed then we will have to implement our own workaround.

@jansennerd10 I wouldn't recommend that. master will be unstable until its final release. Running anything in production with it would be a risk.


The WSL 2 ext4.vhdx file keeps growing for no good reason

Windows Version
Microsoft Windows [Version 10.0.22621.1992]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps
Download MySQL Cluster binary tarball or RonDB binary tarball
Run the MTR command:
./mtr --suite=ndb,ndbcluster,ndb_opt,ndb_ddl,ndb_binlog,ndb_rpl,rpl_ndb,gcol_ndb --parallel=8 --force
This will run an extensive test suite that runs for about 1 hour
The test suite starts and stops new DB clusters continuously at a high pace, this means a lot of file creations and
deletions.
The size of the Linux file system doesn't grow very much due to this, it could grow a few GBs.
However the ext4.vhdx grows a lot more. This grew 28 GB instead. After running a couple such test runs, even
my C drive of 637 GB gets full. At this point WSL 2 simply exits without any error messages, the windows simply
disappear and without giving any indication of what happened.
The tool okibcn/wslcompact was helpful in getting back the lost disk space. It decreased the vhdx file from
436GB to 43GB such that I could continue working.
Other than that I am very happy with WSL 2, very nice tool in particular combined with Microsoft Remote Desktop
(Microsoft Remote Desktop ensures that I am not bothered by Windows stopping long-running jobs due to
power savings).
Expected Behavior
vhdx grows at same pace as Linux FS.
Actual Behavior
See above in Repro steps
Diagnostic Logs
No response

Comment seem reasonable, in that case I think that this should be an improvement on the documentation of WSL 2. Haven't seen this documented anywhere. Also it seems that something similar to the wslcompact tool I mentioned above should be part of the wsl.exe. E.g. a simple wsl.exe --compact Ubuntu-22.04.

/dupe #4699


Tree: EditableTree refactoring

This PR refactors the EditableTree and its tests. It is based on top of #12902.
The main cause of this is to prepare the code base for the upcoming implementation of "simple assignments" and hence to make the latter smaller i.e. better for a review.
Main changes in the productive code:

getPrimaryField is exposed to let users handle corresponding cases (e.g. arrays)
getFieldSchema is wrapped within the EditableTree proxy - this has no use currently, but will be needed in "simple assignments"

Changes in tests are mainly caused by improving the mock data. Those improvements are the result of the "Property Inspector" PoC demoed for various user groups, introducing among others the type Bool and a schema (and type) for the "array of array" usecase.

rebased on main https://github.com/microsoft/FluidFramework/pull/13271


vxworks osapi.c utility task doesn't exit

The vxworks osapi.c has an optional task that is started in OS_API_Init():
{{{
/*---------------------------------------------------------------------------

Name:    UtilityTask
Purpose: If turned on, this task will print out the messages from

     the OS_printf buffer at a low priority. This will mean

     that the functions calling OS_printf will not block due to

     writing data to the UART

----------------------------------------------------------------------------*/
#ifdef OS_UTILITY_TASK_ON
void UtilityTask()
...
}}}
However, this utility task implementation has a while(TRUE) loop with no exit logic.  For a "load and forever run it" scenario this may work, but for any other scenario where an orderly shutdown is desired by the user this means the task is never killed.  One can get kernel crashes if the vxworks module is unloaded while that thread is still writing to output.  The forever loop thread also makes line coverage difficult.
We need a robust method to always end this thread and to ensure the parent thread doesn't return to OS control while this thread is still hanging out there.

Imported from trac issue 97.  Created by abrown4 on 2015-08-31T14:30:11, last modified: 2019-08-14T14:11:46

Trac comment by abrown4 on 2015-11-25 17:11:19:
See also #33, which adds an OS_ApplicationShutdown() and may run into the same issue when/if those changes are ported over to VxWorks.


feat(schema4): update ontology_term_label function in ontology_labels.py to appropriately handle multi-value strings

It appears with schema 4, we now want to be able to support a comma-delimited list of strings for self_reported_ethnicity. We'll have to update ontology_term_label to support a comma-delimited string. For example, if we receive "HANCESTRO:0005,HANCESTRO:0014" as the ontology_term_id, we should map this to "European, Hispanic or Latin American"
If there's a feature flag for this field update in schema 4, we should gate the change behind the flag.

Closing this PR because in a code review with @joyceyan @atarashansky on 10/30/2023, it was decided that we are filtering out comma-delimited ethnicity term IDs from grouping and filtering if they are done by self_reported_ethnicity_ontology_term_id.
This filtering work is the subject of this ticket: https://github.com/chanzuckerberg/single-cell/issues/596
Thus no translation of term ID to term label is needed for comma-delimited term IDs for self_reported_ethnicity_ontology_term_id


Feature Request: MONO button

Having different volume levels per tab is highly valuable - but for us headphone users we frequentlyt have the problem of a podcast where either one channel is ommitted or has 2 speakers with separate mics that are panned way to hard. A mono button or stereo width dial would be super useful here.

A mono button will be available in the 1.1.0 update after it gets reviewed :)

That's excellent news!! :)

Does the mono button essentially mix everything into one mono output stream? Asking because I'm deaf in one ear and that would make this a very useful add-on for me

Nice one - I didn't even know this was updated. At the moment I am using Pedalboard2 through a couple of VST plugins, a chain which has Ozone 9 Advanced in it just before hitting ARC3 room correction; Ozone has a number of listening modes including R-L swap and MONO. I know that's overkill for average users but essential when producing music and listening to references from browser or Spotify.

@JobLeonard yes! (what else would it do? :D) It sets destination.channelCount = 1.


Dynamically add number of OR'ed statements to query

I'm trying to dynamically add a series of OR'd conditions to my query, and I have no idea how. I hope the (non-working) code below illustrates what I want to achieve (somewhat explained below):
let mut results = items::table
    .inner_join(sources::table)
    .select((items::name, items::price, items::weight, sources::name))
    .into_boxed();

let item_types = // A Vec<String> which is dynamically constructed

let mut filters = Vec<something something>;

if item_types.contains(&String::from("Weapons"))
{
    filters.push(items::id.eq_any(weapons::table.select(weapons::item_id))));
}

if item_types.contains(&String::from("Armor"))
{
    filters.push(items::slot.eq(Slot::Armor));
}

//
// Additional conditions pushed onto the filters vector based on the item_types vector...
//

let maybe_filter = filters.iter().fold_first(|acc, e| {
    acc.or(e)
});

if let Some(final_filter) = maybe_filter
{
    results.filter(final_filter)
}

Basically, I have a number of conditions that I might have to check - if any of the conditions hold, I want the row to be selected, hence I need them all OR'ed together. Problem is, I don't know which conditions might have to be checked (it could be none, it could be all of them).
I can't get the type checker to be happy with anything I've tried. Is there some other way to do this? Is something like this even possible?  Any help greatly appreciated.

I think the easiest way is to just apply each filter via .or_filter to your boxed query instead of storing them into a vector and applying them later.  So your code could look like:
let mut results = items::table
    .inner_join(sources::table)
    .select((items::name, items::price, items::weight, sources::name))
    .into_boxed();

let item_types = // A Vec<String> which is dynamically constructed

if item_types.contains(&String::from("Weapons"))
{
    results = results.or_filter(items::id.eq_any(weapons::table.select(weapons::item_id)));
}

if item_types.contains(&String::from("Armor"))
{
    results = results.or_filter(items::slot.eq(Slot::Armor));
}

/// Handle additional filters exactly the same way

Otherwise you may want to look at the documentation of BoxableExpression for an unified expression type.
Closed as this is not a bug or feature request. Please use our gitter channel or our forum for future questions.

Thank a lot! I somehow missed or_filter in the docs... doh!


Decoupling gatsby-source-shopify

Hey Trevor 👋🏼 we chatted at Gatsby Days in LA.  This is everything I've wanted - so thank you.
I'm running a custom gatsby-source-shopify.  i wonder if makes sense to decouple your library from the source.  It's cool you proxy the settings down to it, but it seems to be in the name of not adding 2 libraries.
Curious to hear your thoughts on it.

Hey man! So you can actually prevent it from including the source plugin by passing shouldIncludeSourcePlugin: false in the options. Would what you’re describing not be accomplished with that setting?
Docs link: https://gatsbythemeshopifymanager.com/#shouldincludesourceplugin

Cool!  I must have glazed right past that.  Yes that's exactly what I want - continue as you were
thanks

Not sure if this is related but I'm getting an error on deploy once i did that
3:57:43 PM: npm
3:57:43 PM: ERR! code ELIFECYCLE
3:57:43 PM: Failed during stage 'building site': Build script returned non-zero exit code: 1
3:57:43 PM: npm
3:57:43 PM: ERR! errno 1
3:57:43 PM: npm
3:57:43 PM:  ERR<EMAIL_ADDRESS>build: `babel src --out-dir . --ignore "**/__tests__"`
3:57:43 PM: npm ERR! Exit status 1
3:57:43 PM: npm ERR!
3:57:43 PM: npm ERR! Failed at the<EMAIL_ADDRESS>build script.
3:57:43 PM: npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
3:57:43 PM: npm ERR! A complete log of this run can be found in:

In my lockfile I see both:
"gatsby-source-shopify@https://github.com/beamercola/gatsby-source-shopify.git":
  version "3.2.0"

<EMAIL_ADDRESS>  version "3.2.8"

Am I doing something wrong here?

Ah now I understand. You're using a forked version of gatsby-source-shopify. Gatsby-theme-shopify-manager still installs its own version of gatsby-source-shopify even if you pass shouldIncludeSourcePlugin–that plugin only omits the config object in the gatsby-config file. I wonder if this needs to be refactored to not install the source plugin for you.

Do you know if you can conditionally require/import/install node packages in a package.json? I assume you can't, but maybe you know better than I do

can you set it in optionalDependencies?  Not sure of the ramifications of that.
Is there an easy way to fork this and comment something out for a quick fix?  Or is it more embedded in there

Also, i know i'm a bit of an edge case.  A little backstory: https://github.com/gatsbyjs/gatsby/pull/23840#issuecomment-629852784

Yeah, I remember you reaching out about the images challenge that you were facing, and so I figured that you had a forked version for that reason. And even if it's an edge case, I think that it makes sense to consider (the whole reason why the options even exist are for edge cases, haha).
I think the steps we need to take are this:

remove gatsby-source-shopify from the list of dependencies
change the option name from shouldIncludeSourcePlugin to shouldConfigureSourcePlugin to be more clear
change the documentation to show that you need to install both gatsby-source-shopify and gatsby-theme-shopify-manager
general docs update to make this more clear overall

Would this be something you would be able to help with? Fork the repo, make the changes, and open a PR?

aye aye cap'n - on it

#57

@beamercola did you see my changes request on your PR?

@beamercola thanks for your contribution! With the merging of https://github.com/thetrevorharmon/gatsby-theme-shopify-manager/pull/77, the source plugin is now decoupled.


Bootstrap-ify

Apply bootstrap on the site.

css was improve with #31 , but issues still persist with the menu and submit button when at phone width


automated annotation of features

Hello, thanks for this great tool. I have been using a lot of different vector editors, but am very pleased with OVE.
Is there a way to annotate sequences based on sequence matches from a library? I would love to annotate new vectors automatically with basic info such as antibiotic resistance, promoters and standard primer binding sites.
Cheers
Jochen

Hey @Joemoe134 , glad you're liking OVE-electron :)
That functionality exists in the app my company works on (teselagen.com), but not yet as a standalone feature of ove-electron. I could imagine adding a simple tool to do auto-annotation to this repo sometime in the future but it isn't currently a high priority for me. Of course I'd be happy to accept a PR adding it.
Cheers,
Thomas

hi
please find attached a few screenshots of a great software that does it (Ape https://jorgensen.biology.utah.edu/wayned/ape/) in two flavors :  "features" that are within the sequence file, or "feature library" that are features that can be recorder in a library (text file with Name, sequence, tyoe of sequence, forward colour, reverse colour tab separated that can be called from the menu) and used to automatically annotate any new sequence.
If something close to that could be achieved, that would be extremely useful.
Thanks
ApeFeatures.pdf

@IbanezP @Joemoe134 I'm starting to develop a simple auto annotate addon specifically for OVE electron. Would it be enough to have it read in an ApE feature library file and use that to auto annotate? Does it also need to have the ability to edit that file or add to it?
Just wondering what I can get away with as a first pass. Obviously the functionality within our main teselagen app is much more fully fledged (with editable annotation groups and the like). I just don't yet have the time to make that happen for ove-electron.
Thanks!
Thomas

Hi Thomas and thanks for all your efforts!
For me, the simplest annotation addon would do, ie even a .csv kind of file
that could identify the sequences of interest, highlight it ans name it
would be more than enough. Adding and editing could be done directly in the
.csv file : it might actually be easier in cases like primers that can
already be in a .csv/.ods/.xcl for bulk ordering, or for constricts that
can be designed using concatenation : in fact, that could be the entrance
door to some kind of dna construct design tool (golden gate assembly,
gibson, restriction ligation, pcr, ...) that would generate a dna map at
the end of the process (my dream).
Could you please send me a link to your teselagen app so that I can have a
look?
I hope it helps
Thanks
Pablo
Le ven. 21 mai 2021 à 20:07, Thomas Rich @.***> a
écrit :

@IbanezP https://github.com/IbanezP @Joemoe134
https://github.com/Joemoe134 I'm starting to develop a simple auto
annotate addon specifically for OVE electron. Would it be enough to have it
read in an ApE feature library file and use that to auto annotate? Does it
also need to have the ability to edit that file or add to it?
Just wondering what I can get away with as a first pass. Obviously the
functionality within our main teselagen app is much more fully fledged
(with editable annotation groups and the like). I just don't yet have the
time to make that happen for ove-electron.
Thanks!
Thomas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tnrich/ove-electron/issues/17#issuecomment-846142647,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVJV7OPVHQGC4RL6K6RLZLTO2OPDANCNFSM4XKRWOPQ
.

--
--
Pablo M. IBÁÑEZ CRUCEYRA, PhD
Postdoctoral Researcher
Andrew D. GRIFFITHS Lab

+--------------------------+
| ESPCI ParisTech          |
+==========================+
| Laboratoire de Biochimie |
+--------------------------+
bâtiment B
2ème étage
porte B229
+------------------+
| 10 rue Vauquelin |
+==================+
| 75005 Paris      |
+------------------+
| France           |
+------------------+
Office: +33 (0) 1 40 79 45 87NEW Mobile: +33 (0) 7 78 70 57 17Email:
@.***NEW Jitsi:
https://meet.jit.si/PabloIbanezCruceyra________
École supérieure de physique et de chimie industrielles
de la Ville de Paris
10, rue Vauquelin | 75231 Paris Cedex 05 | France

33 1 40 79 44 00https://www.espci.psl.eu/en/
--

@IbanezP cool thanks for the response! I'll let you know when the feature is released.
In the meantime, maybe @mfero and @ccwilson can get you hooked up with a new "Academic Edition" of our full fledged app.

Hey @IbanezP this should soon exist as a feature in ove-electron. It will look like so:

You can try it out already at http://teselagen.github.io/openVectorEditor/#/Editor?searchInput=

@IbanezP here's the latest release: https://github.com/tnrich/ove-electron/releases/tag/v1.2.1


Editing path geometry in the map

With #4, we temporarily removed the ability to edit the location information inside our app. Right now, the only way to get location/path info into a track is to use the OSM XML import. That's great to get started, but is annoying for small adjustments or fixes, e.g. if the OSM export contained the wrong track/platform in a station.
Let's add back the ability to edit the path right in our app. We might need a mode switching between editing timing points and editing path points.
I think it's worth trying out an existing editing plugin for Leaflet instead of handcrafting this one. See the plugin list as a starting point.

After trying out the Leaflet plugins Leaflet.DraggableLines and geoman (free), I decided that Leaflet.DraggableLines fits our use case better for now.
A first version is implemented as of 2c580c7e280891d3f9fc61767853c3ea69b4741a, though this definitely can be improved in terms of performance.


Allow shallow renderings with icons and without warnings

Currently, warning show up based on iconPath not being present to tell upgrading folks that they need icons served externally via HTTP now. These warnings still happen in shallow rendering (such as Enzyme's ShallowWrapper), since child context is not available in shallow rendering.
We could remove the warning in 0.8.x releases. (in a "I hope you've fixed your icons" thing). I'm unable to find a flag to know if a component is shallow rendered.

You can disable the warning with process.env.NODE_ENV = 'test' due to
https://github.com/salesforce/design-system-react/blob/master/utilities/warning/url-exists.js#L22


Using data with tied event times

Hi Jared,
In your current package you only support datasets with the assumption that there are no tied event times. What do you recommend doing for datasets that have tied event times (say, because time is in discrete intervals). How difficult would it be to implement breslow's method, for example, to handle these tied event times? Or what about jittering the event time so tied events are made unique (if event happened at 300 minutes, and there are duplicates of 300 minutes, then make subseuent event times 300.01, 300.02, etc).
Let's also assume that we need to have all events and cannot just drop the event times that are tied.
Thanks!

see the paper by Luck et al. (https://arxiv.org/abs/1705.10245) who implement Efron's method for handling ties. Shouldn't be too big a modification.


Outdated Tower screenshots

[ ] slide "Schedule Jobs"
[ ] https://github.com/ansible/lightbulb/tree/master/guides/ansible_tower/3-create#step-5-1
[ ] also, some pictures in guides are missing from the repo completely

Thanks for reporting this @webknjaz. Can you be more specific to which images are missing entirely in your third point?

https://github.com/ansible/lightbulb/blob/master/guides/ansible_tower/README.md - tower logo
https://github.com/ansible/lightbulb/tree/master/guides/ansible_tower/2-config#step-5 - submit button, add button, create an inventory

will take a look at this tomorrow and into next week. apologies on being late

@webknjaz, thanks for pointing those out, great work! I think I've fixed most of them :)
But I don't find the first one actually:

slide "Schedule Jobs"

Do you mean the one in the decks? That looks right to me, what do you think is wrong with that one?

I guess. Honestly, I don't remember now, but looks like it.
As I recall, it looked differently from what I saw in my installation of Tower.

@webknjaz Thanks for the quick answer. I checked, and it mostly looks like my local installation, so I suggest we will keep it for now.
The rest should be closed by PR #309 , so I'd say we can close this issue.


Update Reason's syntax path

Coverage remained the same at 26.699% when pulling 4a469af8db7f75b324837743bf209ee15b4cd082 on jeremejevs:patch-1 into 6d64e31fed6a008473ed3f692c85cb94e45be17e on tomv564:master.


Elementor is not running as root

Whenever I run elementor, I get the following error:

"Please start Google Chrome as a normal user. If you need to run as root for development, rerun with the --no-sandbox flag."
Andres, (or anyone else), have you seen this error and do you know how to resolve it? I don't want to run Elementor as root (at least I don't think I do), but it seems to default me to trying to run as root. And then I get this error.
Any help would be MUCH appreciated!

It seems you have started webdriver-manager with sudo. Try to start it without sudo.


Removes the ability to add notebook headers from the conf.py file.

This removes the ability to add header blocks to every produced notebook which were defined in the conf.py file. This was initially used to add some code such as to switch autosave off for every produced notebook.
This will be replaced with the ability to specify a header rst which can be used to add in RST and/or code to the top of every produced notebook. This is currently called welcome_message but this should be renamed as header_rst.

this implements the additions from #30


Flex app merge

After looking at how how we use these samples in our docs, I think our vision of having the single app must not burden users who just want to see the single servlet Flex sample demonstrating a particular functionality. It should also not burden the contributors.
Let me know if this current approach makes sense. the samples-builder under flexible/java-runtime/samples creates the bundled app on the fly from all or a subset of the samples.
The only part I'm having trouble with is ensuring this works with the auto-updates for dependencies  by dpebot.

Merge issues with master, will recreate pull request after i fix


Add API for use by other plugins

This adds a globally accessible object which exposes the internal verse fetching/rendering functionality for use by other plugins.
I should mention, I don't feel strongly about the names of anything here, please feel free to critique and I'm happy to adapt!

It is allow worth noting, there is a current work around to accomplish this same task, however, it doesn't allow mutating the configuration (i.e. you can't pick an alternative version)
(await window.app.plugins.plugins["obsidian-bible-reference"].verseLookUpModal.getSuggestions("John 3:16"))[0]?.allFormattedContent)

Thanks

@all-contributors please add @jonathanvanschenck  for code


Add motion controller simulation to input simulation documentation

Overview
This PR updates the input simulation documentation to reflect the change of introducing motion controller simulation.

/azp run mrtk_docs

/azp run mrtk_docs

I think we might want to reassess how we communicate the idea of controllers to the user. In my mind, a controller feels like it's specifically tied to a physical device with buttons, so seeing the articulated hands/our general input mechanisms all colloquially referred to as controllers feels odd. Since ultimately the user sees the hard graphics show up in the scene, I'd suggest keeping our terminology with hands but clear up that the simulation modes are different (ie, articulated hands are for when the device actually tracks the hand joints, gestures are for hololens 1 implementations, and motion controllers are for simulating the physical controllers for VR devices).

I think you have a valid concern here. This conversation actually happened when the feature was being planned/implemented between @wiwei @keveleigh and me. The conclusion was that since there were some commonalities between a motion controller and a hand we chose to use the word "controller" to as an umbrella term for both cases. The VR controller is called motion controller and hand is either articulated hand or hand gestures. I understand that this may not be the most natural way for people to understand, but it aligns with the names we used in the code base.


Orchestrator old signatures replay

Add valsets/Data commitment orchestrator signature replay.
Closes: https://github.com/celestiaorg/celestia-app/issues/337 https://github.com/celestiaorg/celestia-app/issues/336

This one is ready for review also

Codecov Report

:exclamation: No coverage uploaded for pull request base (qgb-integration@4fe09dc). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             qgb-integration     #351   +/-   ##
==================================================
  Coverage                   ?   11.82%
==================================================
  Files                      ?       55
  Lines                      ?    11073
  Branches                   ?        0
==================================================
  Hits                       ?     1309
  Misses                     ?     9674
  Partials                   ?       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe09dc...d35ac96. Read the comment docs.


Update semanticdb-scalac to 4.4.33

Updates org.scalameta:semanticdb-scalac from 4.4.29 to 4.4.33.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "semanticdb-scalac" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #275.


Design, Develop, Test CompoundV3 Adaptors

Core changes:
This PR encompasses the integration of CompoundV3 into Sommelier. It revolves around the development and testing of an adaptor (or adaptors) that includes features such as:

Supply BaseAssets to different Compound V3 lending markets.
Adding Collateral to the calling Cellar's Compound V3 account.
Borrowing and paying back BaseAssets to different Compound V3 lending markets.
Claiming Rewards from Compound V3 lending positions.

The design may be split into two or more different adaptors. It is TBD as this PR develops.

Currently, this PR is in the discussion and design phase.

Current Design / TODOs

CompoundV3CollateralAdaptor.sol handles supplying 'Collateral` to a Cellar's lending market account / position.

[x] Review CompoundV3 Docs and Codebase
[x] Write out function architecture for smart contracts w/ pseudo code
[x] PR Review concepts before writing implementation code
[x] Write Implementation Code
[ ] Write tests
[ ] Peer Review
[ ] Resolve PR CRs
[ ] Final PR Review
[ ] Audit

CompoundV3DebtAdaptor.sol handles borrowing BaseAsset (has to be coordinated with a CompoundV3CollateralAdaptor position with collateral provided.

[x] Review CompoundV3 Docs and Codebase
[ ] Write out function architecture for smart contracts w/ pseudo code
[ ] PR Review concepts before writing implementation code
[ ] Write Implementation Code
[ ] Write tests
[ ] Peer Review
[ ] Resolve PR CRs
[ ] Final PR Review
[ ] Audit

CompoundLendingAdaptor.sol handles lending BaseAsset to a respective CompoundMarket.

[x] Review CompoundV3 Docs and Codebase
[ ] Write out function architecture for smart contracts w/ pseudo code
[ ] PR Review concepts before writing implementation code
[ ] Write Implementation Code
[ ] Write tests
[ ] Peer Review
[ ] Resolve PR CRs
[ ] Final PR Review
[ ] Audit

There may be a HealthFactorLogic.sol type file providing helpers in calculating updated health factors.

References

CompoundV3 Docs
CompoundV3 Announcement

@crispymangoes -CompoundV3CollateralAdaptor.sol is roughly written so far. It is ready for your first review though. The big questions right now are:

Are we implementing a minimumHealthFactor that is 'safer' than the checks within the CompoundV3 contracts? If so, we'll need that logic within the contracts to make sure mutative functions don't cause unsafe positions.
Are we combining the functionality of supplying Collateral and supplying BaseAssets into one Adaptor or separating that functionality?

@crispymangoes - Roughly wrote the remaining adaptors (Supply and Debt adaptors). Next step is to go over the key complication areas such as the following (some discussed):

Use of 'base' CompoundV3Adaptor contracts instead of having three standalone contracts since there could be repetitive functionality between some of them.
The Health Factor logic, whether or not we can simply query it from the CompoundV3 lending market contracts or we have to carry out internal helper logic that mirrors CompoundV3 calculation methods.
a. Once the second point here is sorted then we can clean up the Debt adaptor and other adaptors too. The DebtAdaptor won't need to validate both market and asset then, since the specific CollateralAsset could somehow not be affiliated to the health factor calcs. Not convinced on this theory though.
Map out tests that are needed to hash out extraneous situations (whether or not CompoundV3 does full liquidations or only partial liquidations, etc.).
Is it fair to have reward claiming possible on all adaptors (via inheritance of ExtraLogic adaptor)? I need to dig into it more but it seems that CompoundV3 could incentivize any actor within the protocol (Suppliers, Collateral Providers, Borrowers).
Need to get to the bottom of how to calculate the truly liquid supplied baseAsset when Cellar may want to withdraw baseAsset that is supplies in a position. It could be partially used, and if so, then the remaining amount of liquid baseAsset would have to come from the rest of the protocol (other accounts' supply positions or the reserves).

Worked through all major discussion points brought up through development so far. Now working through compilation troubleshooting. Once that is done, if there is time we will move on to writing unit tests for the supply adaptors, but this may be postponed as outlined in the CompoundV3AdaptorsREADME.md.

I am closing this branch as it has been continued and completed in PR #176