Dates not formatted correctly in Select Box Link

Depending on the field's setting, dates are formatted with or without time on publish page, publish index and association drawer. For Select Box Link values, this setting has been ignored and dates were always formatted with time.
By the way, dates are also formatted even more differently when used as dynamic values for a normal Select Box field (not covered by this change).

LGTM

ty!


BUG: Fix an error in generating the approximation name for wavelet.

Fixes #398
cc @Radiomics/developers

👍 I tried, but could not find this!


Added a search functionality

Thanks for the wonderful tool! I've been having trouble looking for my country in this graph. I have added a search functionality to make it easier.

OK done with your suggested changes!

Thanks @arjo129! Working on this now.

Nice work @arjo129!

@all-contributors add @arjo129 for code


Sample crashes when offering contract to a DLC node

The sample code which illustrates how various parts of the library comes together is failing when offering a contract to Alice.
Conditions to reproduce the issue: Running the sample as illustrated in the repo
Environment: Ubuntu 22.04 LTS
Error on Bob's instance after offering contract:
Checking for messages
SUCCESS: connected to peer 02ba27499250af5f64f8aeeafffba905799ffda165bd8de335e182c4fc7c6ef6d9
thread 'tokio-runtime-worker' panicked at sample/src/cli.rs:202:38:
Error sending offer: OracleError("error decoding response body: missing field `announcementSignature` at line 1 column 233")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at sample/src/cli.rs:215:22:
called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(17), ...)

@MusigMaestro I just ran the sample on the latest master branch and did not encounter any issue. Did you make any modification to the code or the configs that might lead to this issue?

@MusigMaestro as I can't reproduce your issue I'll close this. If you have more details to provide on how to reproduce it feel free to re-open it.


[Edit Projects][Database]

Break update project down into multiple stored procedures based on wizard cards. E.g. one update for committed funding, one update for sponsor info etc.

Done in dev db.  Committed Funding sps should be the same as before.  Let me know otherwise.


Context contract composition error.

Parent story can't define an argument if a child's story already defined variable with the same name.

Superseded by #627


add support for urls with query, clippy fixes

Hello, i need to add my own query parameters to urls but this library always assumes url has no query and uses ?.
Here is what botocore does: https://github.com/boto/botocore/blob/2cf64649cc020c2edcf28e22e6384750b5d8edb0/botocore/signers.py#L413
I copied that behavior, added new test and did a couple small clippy fixes

made the bot happy

Thanks @Fogapod for your contribution!


GH-551 Avoid duplicating return nodes on rename

Fixes #551

Applied to main (=2.1) and branch 2.0.


Add clusterctl support for BYOH Provider

BYOH provider has to be added to the list of providers that clusterctl currently supports.
$ clusterctl config repositories
NAME           TYPE                     URL                                                                                FILE
cluster-api    CoreProvider             https://github.com/kubernetes-sigs/cluster-api/releases/latest/                              core-components.yaml
aws-eks        BootstrapProvider        https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/latest/                 eks-bootstrap-components.yaml
kubeadm        BootstrapProvider        https://github.com/kubernetes-sigs/cluster-api/releases/latest/                              bootstrap-components.yaml
talos          BootstrapProvider        https://github.com/talos-systems/cluster-api-bootstrap-provider-talos/releases/latest/       bootstrap-components.yaml
aws-eks        ControlPlaneProvider     https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/latest/                 eks-controlplane-components.yaml
kubeadm        ControlPlaneProvider     https://github.com/kubernetes-sigs/cluster-api/releases/latest/                              control-plane-components.yaml
nested         ControlPlaneProvider     https://github.com/kubernetes-sigs/cluster-api-provider-nested/releases/latest/              control-plane-components.yaml
talos          ControlPlaneProvider     https://github.com/talos-systems/cluster-api-control-plane-provider-talos/releases/latest/   control-plane-components.yaml
aws            InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-aws/releases/latest/                 infrastructure-components.yaml
azure          InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-azure/releases/latest/               infrastructure-components.yaml
digitalocean   InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-digitalocean/releases/latest/        infrastructure-components.yaml
docker         InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api/releases/latest/                              infrastructure-components-development.yaml
gcp            InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-gcp/releases/latest/                 infrastructure-components.yaml
maas           InfrastructureProvider   https://github.com/spectrocloud/cluster-api-provider-maas/releases/latest/                   infrastructure-components.yaml
metal3         InfrastructureProvider   https://github.com/metal3-io/cluster-api-provider-metal3/releases/latest/                    infrastructure-components.yaml
nested         InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-nested/releases/latest/              infrastructure-components.yaml
openstack      InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases/latest/           infrastructure-components.yaml
packet         InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-packet/releases/latest/              infrastructure-components.yaml
sidero         InfrastructureProvider   https://github.com/talos-systems/sidero/releases/latest/                                     infrastructure-components.yaml
vsphere        InfrastructureProvider   https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/releases/latest/             infrastructure-components.yaml

This will allow us to use clusterctl and its features out of the box. At the moment, we are manually adding BYOH provider to clusterctl.yaml for clusterctl support. Check out the getting started guide - Configuring clusterctl for BYOH support
To understand what changes are needed, refer to https://github.com/kubernetes-sigs/cluster-api/pull/5189

@anusha94 Please assign it to me :)


test error

My test results are all . What's wrong with my project or model? Is there something getting wrong when I train my own model?

My test results are all [pad]. What's wrong with my project or model? Is there something getting wrong when I train my own model?


SAK-30426 Further changes to favorites and the user dropdown

While the "More sites" drawer modal is up, don't allow the page behind it to scroll

Reposition the arrow on the user dropdown to point at the user's name

Allow the user to click anywhere on the page to dismiss the user dropdown

LGTM


adjust content to fit inside the PDF

I'm receiving a HTML for an API, I cannot change its content, but I can add styles. I created a NodeJS/Express backend to transform this HTML to a PDF. However, it is not formatted inside the PDF.
The example below shows the issue:
`const pdf = require('html-pdf');
let form =

                     AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

let options = {
format: 'Letter'
};
pdf.create(form, options).toBuffer(function(err, buffer){
res.writeHead(200, {
'Content-Type': 'application/pdf',
'Content-Length': buffer.length
});
return res.end(buffer);
});`
The response is a PDF with the content outside the PDF file (image below). Is there a way to adjust the html-pdf to fix the content?

We are also seeing this problem. Help is appreciated!

need help


To improve Readme file of Twitter Clone

Description of  the change
to improve the readme file of twitter clone , it's a good project to be a part of the frontend projects , so it should have a proper readme file as well.
Domain of Docs

[] Readme
[] Solidity , Html, Css , JavaScript , Web3.js / Ether.js
[] Solidity , ReactJs /NextJs , Web3.js /Ether.js
[] Solidity , Python3 , Web3.py
[] Other , feel free to mention below

Are you contributing under any open-source program ?
please assign me this issue under hacktoberfest label @Vikash-8090-Yadav

@Vikash-8090-Yadav Can u please add the hacktoberfest label


Extreme sluggishness when drawing slowly in collaboration mode

I think https://github.com/excalidraw/excalidraw/discussions/3150 may be describing a similar issue.
To minimize potential latency differences, I tested it by opening two Chrome browser windows on the same computer and putting them in the same excalidraw.com live collaboration session. (Tested with both Chrome and Chrome Canary.)
Using the Draw tool, if I move my cursor quickly, there isn't much perceived latency or slowness in the other browser window. This is the case whether I quickly draw a straight line, or quickly move my mouse in circles to scribble with all sorts of shapes with different kinds of twists and turns. It seems to be about what you'd expect from the network round trip. The faster it is, the less sluggishness is noticed.
However, if I move my cursor more slowly to draw, there's an extreme amount of awkward sluggishness and latency in the other window. It's proportionally much more than I'd expect when just accounting for the fact that the drawing is happening more slowly due to moving my mouse more slowly.
Once it fully catches up to the very last bit of slow movement, if I move my cursor more quickly again, the sluggishness issue instantly goes away and everything seems smooth again.
To be clear, I understand that things will obviously appear more slowly if I draw more slowly. The degree of sluggishness just seems to be much more than should be occurring when accounting for that fact.
I don't know anything about the codebase, but just to describe how I perceive the behavior, to me it almost seems like it might be undershooting what the actual average drawing velocity should be, with it undershooting more severely the slower the drawing is.

The trouble is we're getting too much traffic and will need to either buy more CPUs or more machines, but both will require also setting up a Redis proxy to allow for socketIO to work with multiple nodes.
We should get around to it soon(ish).
It can of course also be a case of the client not being able to handle all the incoming messages, which could be alleviated by support backpressure. But the fact you're not experiencing a severe lag with mouse events doesn't necessarily indicate a backpressure issue (mouse events are cheaper).


[feat] Database Option

Feature requested in the #1467. I added a new option in print_settings.py to show the current database. But we need to approve and merge the #1553 PR, because I made some refactoring in this file through this PR

Coverage increased (+0.09%) to 71.528% when pulling a54fa42902aa331766db5aea9e27672e14f3a8f7 on luchiago:feat/database-option into d747e09885e90d4c5f702f0bb4f0ea42e63f4eb0 on django-extensions:master.

Coverage increased (+0.09%) to 71.528% when pulling a54fa42902aa331766db5aea9e27672e14f3a8f7 on luchiago:feat/database-option into d747e09885e90d4c5f702f0bb4f0ea42e63f4eb0 on django-extensions:master.

I guess I don't understand what purpose this PR serves... DATABASES is already included on the output of print_settings ?

I guess I don't understand what purpose this PR serves... DATABASES is already included on the output of print_settings ?

@trbs As I said on #1467, I misunderstand the purpose. Let's close this PR and I can do the right one.


Use two PostgreSQLs in tests

Description
Closes #{issue_number}.

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[ ] I ensured that PR title is good enough for the changelog.
[ ] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.

Ok, at least now we know it... Anyway, it was an excellent idea to try.


Points plotted outside scale min and max on line chart

Expected Behavior
Points outside of scale min and max should not be plotted
Current Behavior
Points are showing up below the scale
Possible Solution
We could have the scale return NaN in getPixelForValue for numbers outside its range. Probably the best way to do this is add a check in getPixelForDecimal to ensure the value is in the range 0-1. The line controller would then skip those points
Another option would be to have the line controller check the point relative to the scale bounds and not attempt to update the element. I'm not sure if I like that option as much because we'd have to be sure to update every individual controller for each chart type.
Steps to Reproduce (for bugs)
https://codepen.io/benmccann/pen/QWLPdrv
Context
Causes zoom plugin not to work with line charts
Environment

Chart.js version: 2.8.0

Looks like it's more complicated especially for the bar chart
The bar chart has calculateBarValuePixels doing:
var start = value.start === undefined ? 0 : value.max >= 0 && value.min >= 0 ? value.min : value.max;
...
base = scale.getPixelForValue(start);

So it assumes the bar starts at 0, but 0 might be outside the min and max range

#6642 fixed this, right?

Seems like it might have. I'm on mobile right now so can't update the codepen to use the latest version of Chart.js to test. Maybe this weekend I can try

Yes, it looks fixed. https://codepen.io/benmccann/pen/KKwyZjP


Is running a standalone Thread from Liberty Servlet the right approach?

Hi there -- I've been looking at the Liberty sample that shows hows how to dequeue messages from MessageHub.
It looks very similar to the JSE sample, but wrapped up into a Servlet.
I was surprised to see the Servlet create a new Thread inside the initi() method, is there no better way of doing this?
E.g.
http://stackoverflow.com/questions/4691132/how-to-run-a-background-task-in-a-servlet-based-web-application
For example, if there was a JMS Resource Adapter for MessageHub then JEE applications could integrate via an MDB.
Any plans to offer a RAR/MDB style approach?

Hi, you're right but the sample was not meant to show how to use J2EE infrastructure.
It was simply meant to show how the SASL credentials retrieved from VCAP_SERVICES can be injected into server.xml.


Refactor config with constant instead of strings

This is a refactoring of the way we interact with the config file.
Fixes #336
We can now access the configuration with constant instead of writing the string by hand each time.

@kauffj Change has been made


1.0.x dev

[x] upgrade dependencies
[ ] upgrade dev dependencies
[ ] upgrade code to php 8.2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (065ea4e) 100.00% compared to head (a26d58d) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              master        #5   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        52        52
===========================================
  Files             15        15
  Lines            175       151   -24
===========================================
- Hits             175       151   -24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for ingestion job to write to Snowflake target

Support writing the output of an ingestion job to Snowflake (in addition to the data lake).
I propose adding a new target={'type:'', 'connection_name':''} property in the config block. If the property is not included the model will default to a target of DATALAKE.
The following targets will be supported:
target = {'type':'SNOWFLAKE', 'connection_name':'some_conn_name'}
target = {'type':'DATALAKE', 'connection_name':'default_glue_catalog'}
Also support the following new required job properties for SNOWFLAKE targets only:
COLUMN_TRANSFORMATIONS = (<column> = <expression>, ...)
DEDUPLICATE_WITH = ( {COLUMNS = (<col>, ...)  | COLUMN = <col>}, WINDOW = INT <time unit>)
EXCLUDE_COLUMNS = ({<column_name> | <glob_pattern>}, ...)
CREATE_TABLE_IF_MISSING = True | False
WRITE_INTERVAL = INT <time unit>

Example: ingest_to_sf.sql
{{ config(
            materialized='incremental',
            sync = True,
            source = 'KAFKA',
            target = {'type':'SNOWFLAKE', 'connection_name':'sf_conn_name'},
            schema = 'ROYON'.  -- dbt override
            options = {
               'topic' = 'user_info',
               'EXCLUDE_COLUMNS': ['password', 'username'],
               'DEDUPLICATE_WITH': {
                    'COLUMNS' : ['first_name'],
                    'WINDOW': '1 HOURS'
                },
               'COLUMN_TRANSFORMATIONS' = [ { 'credit_card': 'MD5(credit_card)' } ],
               'WRITE_INTERVAL': '1 MINUTES',
               'CREATE_TABLE_IF_MISSING': True,
               'COMPUTE_CLUSTER': 'SQLake',
               'START_FROM': 'NOW'
            },
            partition_by=[{...}],
            primary_key=[{...}]
        )
}}

SELECT * FROM {{ ref('source_kafka_conn') }}

This ingest_to_sf.sql model will compile to the following SQL.
CREATE SYNC JOB "ingest_to_sf"
    COMPUTE_CLUSTER = SQLake
    CREATE_TABLE_IF_MISSING = true
    START_FROM = NOW
    EXCLUDE_COLUMNS = ('password', 'username')
    DEDUPLICATE_WITH = (COLUMNS = (first_name) WINDOW = 1 HOURS)
    COLUMN_TRANSFORMATIONS = (credit_card = MD5(credit_card))
    WRITE_INTERVAL = 1 MINUTES
AS COPY FROM KAFKA source_kafka_conn TOPIC = 'user_info'
INTO SNOWFLAKE sf_conn_name.ROYON.INGEST_TO_SF;

Implementations notes:

SNOWFLAKE keyword is added to the INTO statement when target is of type SNOWFLAKE
A DATALAKE keyword is NOT added to the INTO statement when the target type is DATALAKE
The TARGET.CONNECTION_NAME property value is inserted before the schema name in the INTO statement
If CREATE_TABLE_IF_MISSING = True Upsolver will automatically create the target table in Snowflake, which the job will load data into.  If CREATE_TABLE_IF_MISSING = False the table is expected to already be present in the target Snowflake system. If not the job will fail to load data.
The target database name and schema name can be configured in the dbt_project.yml or via the config properties database and schema. Docs for schema and database. It may be useful to override these if you want to output to multiple targets.

@jasonf20 please review and provide feedback on this proposal.

Seems fine, I think we should  split the target option into two options:
TARGET_TYPE
TARGET_CONNECTION

As we should already have the CONNECTION property from before since when loading to Upsolver you should have been able to configure that. That way you don't have to configure the TYPE if you just want to change the connection.
Also, IMO, I think our target should be called Upsolver not Datalake. Alternatively, it can be called Glue but that has the feeling that it's a native glue table that we don't manage beyond the DBT RUN. Datalake seems like an abstract thing and not a concrete target. It might be fine since it's within the context of the Upsolver connector, but seems odd still.
Another point to consider:
Do you want to have full COLUMN_TRANSFORMATIONS or just a HASH list? The first is more powerful of course, but we elected to only expose the simpler HASH list in our wizards.

I agree with connection options and will update.
Regarding the output table of data lake, I'm hesitant to call it Upsolver because it feels proprietary when in fact we create a standard data lake table, although with a MOR view.  Datalake is commonly used to represent queryable objects in S3 so I think the name conveys the purpose. It doesn't however convey the fact that we manage it.  What about DATALAKE_MOR ?
Regarding COLUMN_TRANSFORMATIONS I think we should keep this and not use only HASH, because we will add more functions in the future so we should have foundation ready.

Well, I guess it goes back to the discussion if the GLUE catalog in Upsolver is supposed to be called glue or something like Upsolver Catalog. I think Datalake is abstract while SNOWFLAKE is concrete so they don't really match, but I don't have a strong opinion on this one.


Typos (probably) and pictures should be added

[x] Typos
[ ] Pictures (if needed)

#3 has fixed Typos


Bug with contact export

Hi there :)
First I would like to thanks, CentCTL is great, just discovered it a week ago.
But I have an issue with it.
When I try to export a contact, and import it in an oher centreon platform, some notifications parameters has not been imported.
When I look in the .csv which contains my exported contact, it seems that some lines are missing. I only got theese ones:
add,contact,"test_un",test1,test1@mondomaine.fr,sqLe$Jrltv,
modify,contact,test1,pager,
modify,contact,test1,access,1
modify,contact,test1,admin,1
modify,contact,test1,activate,1
Nothing about Notifications enabled, Host and Services notifications, etc...
Here is a screenshot of my test contact in the web interface before export:

I expected something like this https://github.com/YPSI-SAS/centctl/blob/master/exemple/importContact.csv
What I exactly did:
./centctl --server=centreon-centos export contact -r test -f contacts.csv
./centctl --server=centreon-rocky import contact -f contacts.csv
I run Centreon 20.10 on CentOS 7 (VMware)
Centreon 21.10 on Rocky Linux 8.4 (VMware)
Thank you for your help 👍

Hello,
We are pleased to learn that the tool is useful to you.
For the export of contacts, it is not yet possible to export all the information related to a contact. The Rest API v1 of centreon does not have the getParam function for contacts and the API v2 does not handle contacts.
As soon as the API allows the retrieval of all information of a contact, the export function for contact will be enriched.
Thank you for your contribution 😉

Ok thank you for your time !


Improve slot tests and HPyDef_SLOT

The goal of this branch is to simplify writing new tests for custom types, and write tests for each slot.
At the moment the new tests are still being written, but reviews are already welcome for the first commits, which introduce the new ExtensionTemplate logic to remove some boilerplate.

Contrarily to the branch name, this PR does NOT introduce any new test about slots. Instead:

refactor the existing slot tests to make it easier to write new ones
change HPyDef_SLOT, now it no longer requires to manually specify the signature of the slot
autogen the HPySlot_Slot and the boilerplate needed to implement (2)


Fix no-unnamed-scenarios rule not working for scenario outlines

Fixes #155

Pull Request Test Coverage Report for Build 455

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 97.458%

Totals

Change from base Build 453:
-0.005%

Covered Lines:
622

Relevant Lines:
631

💛  - Coveralls


Add ServerStatusService in the core module

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

Add ServerStatusService in the core module to provide a new way to expose the booting status to other modules. This helps on #10051

If I follow what you are asking, do you mean other modules should react based on the telemetry module's data? That is not correct from my understanding.

If I follow what you are asking, do you mean other modules should react based on the telemetry module's data? That is not correct from my understanding.

I don't mean that. Let's say in another way, if you insist we should add the new service in core module, I hope finally we can rewrite the telemetry module to reuse the server status logics in core module, that should make sense right?

I don't mean that. Let's say in another way, if you insist we should add the new service in core module, I hope finally we can rewrite the telemetry module to reuse the server status logics in core module, that should make sense right?

I am afraid I can from tech perspective. The Telemetry is the leaf of the module dependencies. That is why I am adding a layer in the core as a delegation.
https://github.com/apache/skywalking/blob/18008aa6b24ada6602d9c73e1a9d19b6105d8b59/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java#L401-L407


Reauthorize Auth Key

The service should poll at a set time before a reservation is supposed to be made to check and view if the Auth key for that user is Authorized to make a reservation. If not the service will delete the old auth key, send a email notification to the user and request that the user we authorize the service

There's no way to actually test this besides running it in production and hoping nothing breaks. Some variables have been changed but nothing that prevents true functionality


Generate dataplane code

DRAFT
Changes
Generate dataplane code
Pending

Cleanup and rename
Merge https://github.com/databricks/universe/pull/546894 and regenerate SDK from master
Integration test

Tests

[X] make test passing
[X] make fmt applied
[X] relevant integration tests applied

Codecov Report
Attention: Patch coverage is 26.31579% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 18.09%. Comparing base (34e415c) to head (e8b0d3c).

Files
Patch %
Lines

openapi/code/service.go
15.90%
36 Missing and 1 partial :warning:

service/catalog/api.go
0.00%
16 Missing :warning:

openapi/code/method.go
0.00%
14 Missing :warning:

httpclient/request.go
0.00%
8 Missing :warning:

httpclient/oauth_token.go
0.00%
6 Missing :warning:

experimental/mocks/mock_workspace_client.go
16.66%
5 Missing :warning:

client/client.go
0.00%
4 Missing :warning:

service/catalog/impl.go
0.00%
4 Missing :warning:

openapi/code/package.go
0.00%
1 Missing and 1 partial :warning:

service/compute/model.go
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #931       +/-   ##
==========================================
+ Coverage   7.13%   18.09%   +10.95%
==========================================
  Files        281      128      -153
  Lines      64583    21122    -43461
==========================================
- Hits        4609     3822      -787
+ Misses     59666    17027    -42639
+ Partials     308      273       -35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[PDI-14825] Adding the accessor method to get CTabFolder so it can be

called from Rest EE plugin to add new ui element
PDI-14825 Made the CTabFolder protected
Made some more UI controls protected so it can be used in EE plugin

Added new method for adding SSL keystore file/password
PDI-14825 Change to be protected method: getSslContextWithTrustStoreFile()
Remove static modifier from method getSslContextWithTrustStoreFile()
PDI-14825 Updated the name of the ui method that adds the sslkeystore group
pdi-14825 Added method that can be overridden in EE plugin for handling the saving of data in ktr
Checkstyle issue fixes
Rename override method name to be shorter

:white_check_mark: Build finished in 5m 43s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/rest/core

:ok_hand: All tests passed!
Tests run: 34, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 6m 10s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/rest/core

:ok_hand: All tests passed!
Tests run: 34, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 4m 30s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/rest/core

:ok_hand: All tests passed!
Tests run: 34, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


move helper functions

inside the main export so they use the right window object

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #71   +/-   ##
======================================
  Coverage    97.5%   97.5%
======================================
  Files           1       1
  Lines         802     802
======================================
  Hits          782     782
  Misses         20      20

Impacted Files
Coverage Δ

rtcpeerconnection.js
97.5% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db60f7...f38eb56. Read the comment docs.


Support agent registration.

Related issue: https://issues.redhat.com/browse/ACM-2252?focusedId=22684351&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-22684351
Related PR: https://github.com/stolostron/managedcluster-import-controller/pull/265

/hold
Hold util the https://github.com/stolostron/managedcluster-import-controller/pull/265 get tagged. We need 2 PRs checked in at the same time.

/assign @JakobGray

/unhold

/assign @dislbenn

/lgtm


Delete move

Implement delete button. Removes user move item from display and resets the Move model in the entities file.

Fix the jquery thing and :ship: :rocket: :santa:


How to set up Teeny on Jetson TX1

Dear Tobias,
I wonder how you could install Teensy on Jetson TX1. I am trying to do the same, however, Teensy 3.2 does not support AARCH 64 architecture yet..
Thanks!!

I think you install Teensy software on the Teensy then both the gpu and the teensy communicate using Serial tx/rx

Good point. Thank you @VisualMacro! I will look into this option.
I previously set up Teensy communicate via a USB port

Hey Dat,
A while back I could never get the Arduino IDE to work on the Jetson TX1, so I decided to upload the .ino files from the host computer instead.

Thanks Tobias. I wrote my Teensy code on a Window machine, too.
However, my issue is that the Jetson TX1 does not recognize Teensy as /dev/ttyACM* or /dev/ttyUSB*  when I plug it in.
Did you install any extra packages or drivers for Teensy to work on TX1

I see,
I don't think I install anything else to get it to work, maybe try this on the TX1
https://www.arduino.cc/en/Guide/Linux#toc6
Try attaching a regular Arduino to see if can recognize it.
It also might be a USB hub issue I am not sure what you are using.
I am assuming you can see the board on your host computer which is windows based from your post above, but have you tried it on a version of Ubuntu on your host to see if it can read the port?

Finally, it worked!
The issue is because someone disabled CONFIG_USB_ACM kernel module on the NVIDIA Jetson( I actually used NVIDA Jetson TX2, Ubuntu 16.04, kernel-4-4.15)
Steps to resolve the issue:

Follow this tutorial: http://www.jetsonhacks.com/2017/03/25/build-kernel-and-modules-nvidia-jetson-tx2/
Before actually make kernel.  Run this command

sudo sed -i 's/.*CONFIG_USB_ACM.*/# CONFIG_USB_ACM=y/' /usr/src/kernel/kernel-4.4/.config

Follow the rest of the tutorial

At the end dmesg should show this when plugging in the Teensy
[  125.602321] usb 1-2.4: USB disconnect, device number 5
[  166.518422] usb 1-2.2: new full-speed USB device number 6 using xhci-tegra
[  166.627754] usb 1-2.2: New USB device found, idVendor=16c0, idProduct=0483
[  166.634715] usb 1-2.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  166.642213] usb 1-2.2: Product: USB Serial
[  166.646492] usb 1-2.2: Manufacturer: Teensyduino
[  166.651192] usb 1-2.2: SerialNumber: 2481500
**[  166.657388] cdc_acm 1-2.2:1.0: ttyACM0: USB ACM device**


Authentication on self-hosting-101

Auth will be done using oauth with github as the provider.
We will need

a new table to store user data
a configuration file for keeping oauth secrets (client key, client secret)
a way to extend the existing Flask app exposed by core.app.wsgi

Table
This raises one more question: should the schema for this be merged along with the core schema? or should this be kept separate and applied to the same database?
I think that for now we should keep a separate schema file for this so that we can re-use the core part for other projects without any changes to the schema. It would be good to have user tables in core to track progress, so we can add that once we have a good idea of what a generic-enough schema would be.
Schema should be like this:
CREATE TABLE user {
    id integer primary key,
    username text,
    ip_address text
};

ip_address should ideally be separate from the user table, but I don't want to make any changes to the app table provided by the core where IP address isn't generic enough to be included. Moreover, the ip-address won't be of much use once we set the DNS entry to link it to a hostname.
Configuration
We shouldn't use the config key in tasks.yml because we will be pushing it to version control. We should instead use environment variables that can be set in Hamr's config.
Extending Flask app to add endpoints
This should be simple enough.
We can do something like:
# in wsgi.py

from selfhosting import app as tm  # tm for treadmill

app = tm.wsgi  # as per hamr convention of wsgi:app

@app.route("/auth/github/initiate")
def initiate_oauth():
    ...

Extending Templates
We would need to do this to add a "Connected! You can close this and go back to your droplet now" page or later for landing-page.
I think a good idea would be to have another templates folder outside core (in top-level) where this overrides would reside.
We should cut up the templates in core into appropriate blocks so that they would make sense on their own and help with extension.

A couple of suggestions:

Make GitHub auth as part of core
Use environment variables instead of config file

On Wed, Oct 19, 2022, 11:47 PM Kaustubh Maske Patil <
@.***> wrote:

Auth will be done using oauth with github as the provider.
We will need

a new table to store user data
a configuration file for keeping oauth secrets (client key, client
secret)
a way to extend the existing Flask app exposed by core.app.wsgi

Table
This raises one more question: should the schema for this be merged along
with the core schema? or should this be kept separate and applied to the
same database?
I think that for now we should keep a separate schema file for this so
that we can re-use the core part for other projects without any changes to
the schema. It would be good to have user tables in core to track progress,
so we can add that once we have a good idea of what a generic-enough schema
would be.
Schema should be like this:
CREATE TABLE user {
id integer primary key,
username text,
ip_address text
};
ip_address should ideally be separate from the user table, but I don't
want to make any changes to the app table provided by the core where IP
address isn't generic enough to be included. Moreover, the ip-address won't
be of much use once we set the DNS entry to link it to a hostname.
Configuration
We shouldn't use the config key in tasks.yml because we will be pushing
it to version control. We should instead use environment variables that can
be set in Hamr's config.
Extending Flask app to add endpoints
This should be simple enough.
We can do something like:
in wsgi.py
from selfhosting import app as tm  # tm for treadmill
app = tm.wsgi  # as per hamr convention of wsgi:app
@app.route("/auth/github/initiate")def initiate_oauth():
...
Extending Templates
We would need to do this to add a "Connected! You can close this and go
back to your droplet now" page or later for landing-page.
I think a good idea would be to have another templates folder outside core
(in top-level) where this overrides would reside.
We should cut up the templates in core into appropriate blocks so that
they would make sense on their own and help with extension.
—
Reply to this email directly, view it on GitHub
https://github.com/pipalacademy/self-hosting-101/issues/6, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAB3ELPJDZCGTLDNY62Y4TWEA3NBANCNFSM6AAAAAARJMIVXI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Backend for authentication has been added.
These are the endpoints

/auth/github/initiate - redirect to github oauth
/auth/github/callback - return URL from github
/auth/me - return a JSON response with the current user's username and node's IP-address
/auth/logout - logout

These configuration parameters need to be set in the environment:
GITHUB_CLIENT_ID
GITHUB_CLIENT_SECRET
SECRET_KEY  # for session-cookies. once authenticated with github, user's username is kept in session
SERVER_NAME  # for redirect URI from github

Sessions are also to be used to store the IP address when it is received at http://self-hosting-101.pipal.in/connect

In Hamr, the config.yml can be set to:
flask_secret_key: abcd123
flask_server_name: self-hosting-101.pipal.in
flask_preferred_url_scheme: https  # defaults to localhost

github_client_id: abcd123
github_client_secret: xyzw321

A similar config is being used for self-hosting-101.pipal.in with this OAuth app: https://github.com/organizations/pipalacademy/settings/applications/2022026
Another OAuth app is created with redirect URL as http://localhost:5000 for local testing

Next steps:

[ ] Add Login button
[ ] Add Logout button

Further UI changes such as a link to user's own app or making it the default should be another issue.


vscode-snippet (No longer working)

Something about the cert is expired or something?

https://github.com/chubin/cheat.sh/issues/310


Add env var ASPNET_ContentRoot

Will add more information here. Triggering builds for now.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] If applicable, the PR references the bug/issue that it fixes in the description.
[ ] New Unit tests were added for the changes made and CI is passing.

@VpOfEngineering - please wait for this PR to be merged before starting release

@CooperLink - please update the PR description before merging.


Filtering not working when using ServerData instead of Items to populate DataGrid

Bug type
Component
Component name
MudDatagrid
What happened?
I cannot use FilterDefinitions when using ServerData to populate a MudDataGid.
The ServerReload method never gets called when using the filter so no filtering can be done.
Expected behavior
ServerReload method to get called
Reproduction link
https://try.mudblazor.com/snippet/QaQQuiFZzDcLEAgd
Reproduction steps

Use a MudDataGrid with ServerData="@(new Func<GridState, Task>(ServerReload))"

   private async Task<GridData<T>> ServerReload(GridState<T> state)
   {
   var repository = _myDbContext.Set<T>().AsQueryable();

     foreach (var filterDefinition in state.FilterDefinitions)
     {
         repository = repository.Where(filterDefinition.GenerateFilterExpression());
     }

     var total = await repository.CountAsync();

     return new GridData<T>() {
     TotalItems = total, Items = await repository.Skip(state.Page* state.PageSize).Take(state.PageSize).ToArrayAsync() };

}

ServerReload never gets called
...

Relevant log output
No response
Version (bug)
6.0.14
Version (working)
No response
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @illuzi0n  see #5126 and #5137


The title of a Web page not identifying the contents

Page: https://micro-acquisition.alpha.canada.ca/en/index.html (and FR?)
Page Title: Calling all coders!
WCAG guideline reference: 2.4.2 Page Titled

OK, bit more details that explains what they mean:
On the home page, the title (H1) is "Calling all coders!". The that h1 element should represent the content of page, which is the Micro-Acquisition Pilot.
We used the h1/title element to bring people's attention to it.
Would thus need to have the title be Micro-Acquisition Pilot, then use CSS to bring people's attention to the Calling all Coders!


Multiple index.html Pages with vite

I am using vite + your plugin to create Google Apps Scripts (AddOns for Google Sheets).
All JS and CSS have to be inlined, so that works perfectly.
The issue that i have is, that i need multiple view alá index.html files.
How can i achieve this?
My current approach is this:
vite.config.js
export default defineConfig({
  plugins: [viteSingleFile()],
  build: {
    minify: true,
    outDir: resolve(__dirname, 'dist/ui'),
    rollupOptions: {
        input: {
            shareOfVoice: resolve(__dirname, './html/shareOfVoice/index.html'),
            metaDataSERPcheck: resolve(__dirname, './html/metaDataSERPcheck/index.html'),
        },
    },
  }
});

but i get this error:
Invalid value for option "output.inlineDynamicImports" - multiple inputs are not supported when "output.inlineDynamicImports" is true.
Thank you for your support!

I'm trying a very similar setup. I am able to get some stuff working by using the useRecommendedBuildConfig: false and adding the default config from this plugin into the build option for rollup. But I can't get the JS to inline. I'm not sure why
import { resolve } from 'path';

import { fileURLToPath, URL } from 'node:url'

import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import { viteSingleFile } from "vite-plugin-singlefile"

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [
    vue(),
    viteSingleFile({
      useRecommendedBuildConfig: false,
      inlinePattern: [],
    }),
  ],
  resolve: {
    alias: {
      '@': fileURLToPath(new URL('./src', import.meta.url))
    }
  },
  build: {
    rollupOptions: {
      input: {
        sidebar: resolve(__dirname, "./index.html"),
        dialog: resolve(__dirname, "./index_dialog.html"),
      }
    },
    assetsInlineLimit: 100000000,
    chunkSizeWarningLimit: 100000000,
    cssCodeSplit: false,
  }
})

After a lot of testing I have some progress but I'm getting to a point that I don't know enough about Vite to fix it.
I don't know why (but I'm sure it makes sense) when we use rollupOptions.input the javascript is referenced as a <link> in the bundled html instead of a <script> so the regex in this plugin code can't find it
This small patch to plugin.ts will do the trick
export function replaceScript(html: string, scriptFilename: string, scriptCode: string, removeViteModuleLoader = false): string {
    const reScript = new RegExp(`<script([^>]*?) src="[./]*${scriptFilename}"([^>]*)></script>`)
    const reScript2 = new RegExp(`<link([^>]*?) href="[./]*${scriptFilename}"([^>]*)>`)
	// we can't use String.prototype.replaceAll since it isn't supported in Node.JS 14
	const preloadMarker = /"__VITE_PRELOAD__"/g
	const newCode = scriptCode.replace(preloadMarker, "void 0")

    // console.log(scriptFilename, reScript2,html.match(reScript2))
	let inlined = html.replace(reScript, (_, beforeSrc, afterSrc) => `<script${beforeSrc}${afterSrc}>\n${newCode}\n</script>`)
    inlined = inlined.replace(reScript2, (_, beforeSrc, afterSrc) => `<script${beforeSrc}${afterSrc}>\n${newCode}\n</script>`)
	return removeViteModuleLoader ? _removeViteModuleLoader(inlined) : inlined
}

However this is not enough. Since the assets generated now look like modules they have exports, and they aren't instantiated. And that's where I'm stuck. I'm sure I'm just a couple tests away from getting this to work. But it feels like there should be a vite option for the scripts not to be bundled as modules so that the simple regex that this script is built around continues working without further modifications

On further inspection I'm pretty sure this is failing because it's trying to do dynamic imports and according to this rollup link inlining dynamic imports is not possible with multiple inputs. I'm trying to figure out if it's possible not use dynamic imports
https://rollupjs.org/configuration-options/#output-inlinedynamicimports

With the patch that I shared yesterday and this configuration it sort of works. I'm seeing all of my console logs printing, but I'm not seeing my UI loading. It's confusing but I'm on the right path, I think.
Note that import { viteSingleFile } from "./plugin" is my local patch for this plugin
import { resolve } from 'path';

import { fileURLToPath, URL } from 'node:url'

import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
// import { viteSingleFile } from "vite-plugin-singlefile"

import { viteSingleFile } from "./plugin"

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [
    vue(),
    viteSingleFile({
      useRecommendedBuildConfig: false,
      inlinePattern: [],
    }),
  ],
  resolve: {
    alias: {
      '@': fileURLToPath(new URL('./src', import.meta.url))
    }
  },
  build: {
    rollupOptions: {
      input: {
        sidebar: resolve(__dirname, "./index.html"),
        dialog: resolve(__dirname, "./index_dialog.html"),
      },
      output: {
          manualChunks: () => '',
      },
    },
    assetsInlineLimit: 100000000,
    chunkSizeWarningLimit: 100000000,
    cssCodeSplit: false,
  }
})

For the time being I'm falling back into using multiple vite.config.ts files 🤷🏽♀

Wow thank you @Darkade for all your testing and support. I think you are on the right way, to solve this issue!

Are there any other solutions to this problem @richardtallent ?

Hi @Adioz01 . As I've mentioned many times before when this has come up, the purpose of this plugin is simply to bundle a web site into a single file. Not multiple files. Not multiple pages with their own connected dependencies. Just one file. I made it because I had a need to be able to ship demo mini-apps to clients via email and to launch mini cross-platform tools from the file system with no installation.
If someone can get it working with multiple entry pages, awesome! If they can send a PR to add tests so we don't accidentally break that in the future, great! But it's not a use case I have any time to invest in myself, so it would need to be community-driven.

Closing this, since this plugin is for single files, not multiple files.

@Darkade It's been a little while, but did you just end up figuring anything else out?

@Darkade @am-maneaters the following build.ts script, executed with tsx, will run vite multiple times and achieve the individually isolated output files.  For example, I'm using this for external web component embeds.
build.ts
import path from 'node:path'
import { fileURLToPath } from 'node:url'
import { build } from 'vite'
import * as glob from 'glob'

const __dirname = fileURLToPath(new URL('.', import.meta.url))

const entries = glob.sync(path.resolve(__dirname, 'src', '*', '*.html'))

for (const entry of entries) {
  const componentName = path.basename(path.dirname(entry))
  console.log('entry', componentName)
  await build({
    root: path.resolve(__dirname, './src'),
    build: {
      outDir: '../dist', // build to dist directory at root (omitting the src dir)
      assetsDir: componentName,
      rollupOptions: {
        input: path.resolve(__dirname, `./src/${componentName}/index.html`),
        output: {
          entryFileNames: `${componentName}/element.js`,
        },
      },
    },
  })
}

and sample execution: rm -rf dist; yarn tsx ./build.ts
This accomplishes:

a single file output per entry html
a stable filename for inclusion (omit the entryFileNames if this is not a requirement)


Dashboard qualifier navigation

Continuing from #186, this adds navigation to the dashboard.
I know you mentioned a Pug formatting issue, if you want to let me know I can fix it in both spots for this PR since this will likely have the same issue. 🙂

Thanks :) In the previous PR you've just missed indentation before :to property. It looks fine here :)

I added the spaces, but I noticed my IDE must use 2 spaces where the project tends to use 4.
Would you like me to clean that up as well?

Well, nevermind, I'll just format it later. Pug formatting is a little messy in this project due to lack of  pug-plugin in prettier.

Okay, sounds good. Any idea what happened with the docker check? Clicking "details" takes me to a 404. 😕

Okay, now I'm done pushing. 😬


Bug | Rescinded button throws an error under certain statuses |2|

https://trello.com/c/8w4GaO3W/704-bug-rescinded-button-throws-an-error-under-certain-statuses-2
The Rescind action is throwing an error under certain circumstances

 Bug | Rescinded button throws an error under certain statuses |2|


Unable to equip Steel Shoes correctly

Hey! I was trying to equip the Steel armor set, and I noticed I couldn't equip the entire set at once. I'm able to equip the shoes, however they seem to be tagged as pants because they only work in that category. Everything else seemed fine though! :)

Thanks for bringing this to my attention! This issue should be fixed in the version 1.1.1 update.


Implementation of 'grev' instruction

This instruction provides a single hardware instruction that can implement all of byte-order swap, bitwise reversal, short-order swap, word-order-swap (RV64), nibble-order swap, bitwise reversal in a byte, etc, all from a single hardware instruction.
The Generalized Reverse (GREV) operation iteratively checks each i in the 2nd argument from i = 0 to log_2(XLEN) - 1 and if the corresponding bit is set, swaps each adjacent pair of 2^i bits.

func7
rs2
rs1
f3
rd
opcode

0110100
rs2
rs1
101
rd
0110011

Please resolve merge conflict.


Add resource requests/limits

Please, let me know if you don't think these limits are reasonable.

Can one of the admins verify this patch?

@aslakknutsen Please review

@aslakknutsen Checked in prod, there are still no limits, could we open the discussion again?


Test on Windows and Linux

As far as I remember, there were some serialization issues on some Windows machines, like the intrinsic order of nodes (based on node IDs) were in reverse.

Tested with Windows 10:

build fails because of tests (#20 will address this)
use of PosixFilePermission in Java doesn't work (already fixed by https://github.com/fbiville/cypher-workshop-generator/commit/7e54b4254bdb47f22c5347d730ef030a21cb99e0)

If I skip the tests:

Git Bash: almost perfectly works (only Unicode chars are not displayed)
CMD: works fine, just no colors
Powershell: works fine, just no colors


MRG: Fix sklearn

This should fix the failing tests in master.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@27413cb). Click here to learn what that means.
The diff coverage is 8.82%.

@@            Coverage Diff            @@
##             master    #4485   +/-   ##
=========================================
  Coverage          ?   45.26%
=========================================
  Files             ?      349
  Lines             ?    64862
  Branches          ?    10029
=========================================
  Hits              ?    29359
  Misses            ?    32982
  Partials          ?     2521

I'm going to merge to get master green again, @agramfort feel free to look when you eventually have time and I'll make another PR to clean up if necessary


Context and Structure > Key Documents - File names on the lists are not equal to the pdf title (e.g. AR_UnitedKingdom_2009.pdf when opened, the file name is Anual Report UnitedKingdom 2009.pdf)

@udaynwa this seems like special case.

@tovari , this seems to be a special case. Currently, we are showing the document title that we get from the external data source. Once we download it, it shows a different file name. What are your thoughts on this?
cc @k9845 @samshara

@udaynwa, strangely, I don't see these documents anymore on the UK country page. Where can I find Key Documents on the admin page?

@tovari thanks for flagging this. We will verify this once we deploy the regular cronjobs work related to #1170
cc @samshara


Mimalloc v2.0.6 conflicts with Nvidia Nsight

Hello!
I found an issue while using mimalloc v2.0.6 and Nvidia Nsight.
Here are the steps:

You need an application with mimalloc integrated (D:/app.exe for example)
Run it using Nvidia Nsight:

In the debug configuration we get an assert:

Here is the mimalloc output:

It looks like the problem is that Nvidia Nsight conflicts with mimalloc. Both are injected into the DLL load order to intercept the messages they need, and in this case Nsight is loaded first and prevents mimalloc from properly intercepting malloc/free calls.
Any thoughts on how this can be fixed?

Can you provide source code for mimalloc-redirect.dll so I can try to find some workaround or some good fix?

Ah I see. I cannot check this but if it is indeed the case that the insight dll is injected earlier than mimalloc, then you should try to move the mimalloc-redirect.dll earlier in the import table of the application. This can be done manually on the exe using tools like CFF explorer.  However, if you get a recent version of dev-slice the bin directory contains the minject program that you can run on you executable to do this automatically. (run minject --help for options).  This may fix the problem

Ah I see. I cannot check this but if it is indeed the case that the insight dll is injected earlier than mimalloc, then you should try to move the mimalloc-redirect.dll earlier in the import table of the application. This can be done manually on the exe using tools like CFF explorer. However, if you get a recent version of dev-slice the bin directory contains the minject program that you can run on you executable to do this automatically. (run minject --help for options). This may fix the problem

I already tried this and it didn't help :(


Redesign Newsletter UI

The newsletter UI can be redesigned and can be made look much better than now. Currently it is looking like this.

No proper padding
Not approaching on basis of design

Please assign this issue to me!

@ArchanRD assigning this issue to you.
Make sure to complete this.
and don't disturb the other things.
And one more information this project won't be active from october 28th and me also.


test with django 1.10

closes #13

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   72.37%   72.37%
=======================================
  Files           8        8
  Lines         496      496
  Branches       74       74
=======================================
  Hits          359      359
  Misses        124      124
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9842c9...ed43649. Read the comment docs.

not working yet :/

django dropped 1.9 support, so we can too I think? https://www.djangoproject.com/download/

yup let's!

up for review!
(there are no code changes though)


Prompts twice for location access

Maybe the app should not ask me twice for location access? I assume once for the list and once for the map.

Can you provide some more details. I just tested and I'm only prompted once on my device.

If I immediately click on the all location access as soon as the page loads (when you see the blue status bar moving from left to right) but before the map initializes, once the map starts to load it will ask me again. If I let it go and wait for the map to load it doesn't prompt me a second time. I thought it did it all the time, but I guess I was too quick to hit the allow button.
Not a big deal really

Is this on a specific device, browser?

It does it in FF, harder to replicate in Chrome because it loads faster. I did not use Edge.

Ok, I can see this in FF. I think this is more of a browser issue. Not something we can really work around when it comes to permissions like that. FF should recognize the host domain, but maybe it's looking at the full URL. Tough to tell.


[BUG] tgn.predict_link_score returning values greater than 1

I tried runing the notebook  amazon_network_analysis.ipynb. The predicted scores returned by the function tgn.predict_link_score were greater than 1. In the offical tgn implemantation, they used a sigmoid after the mlp layer.

Hi @gefend, thanks for reporting this 🚀  , we will look into this.


Ensure blank project files can be deleted by github runner

Changes

chmod blank project folder to fix host permission errors

Related Issues

https://github.com/game-ci/unity-builder/issues/598

Checklist

[x] Read the contribution guide and accept the
code of conduct
[x] Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
in the documentation repo)
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

@AndrewKahr One edge-case tho, since the chmod is done after the build, a job that is canceled will break the next one

Good catch! I've gone ahead and reworked the Linux scripts to allow running the container as the same user on the host so we don't get these root permission errors anymore on self-hosted.


support instantiating money from float

This is mainly in response to https://github.com/moneyphp/money/issues/408
Any thoughts?

@frederikbosch there are two tests, one from a float, and one from scientific notation. (and i was just testing the maximum float representable by php fyi).
btw, why is there MoneySpec and MoneyTest? There seems to be some overlap.

Well I am simply against accepting one more type in the constructor. Use a named public static constructor it.

@frederikbosch sorry, i missed what you were objecting to, hence my non nonsense reply.

I second @frederikbosch 's opinion. Would Money::fromNumber(Number::fromFloat(3.5)) work for you @bendavies ?

@sagikazarmark hey! that doesn't add anything to me over my current solution which is:new Money(Number::fromFloat(3.5), new Currency('USD');
The point of this PR was to provide a constructor that can take a string, int or float, so I don't have to do any checking up front.
I'm not particularly attached to the idea though, so no problem if you guys don't like it!

Hm, I see. I'll leave this decision to @frederikbosch

@bendavies I get your point, but I stick to my main point: I do not want to have a constructor that becomes a bag of mixed types.
What could be the solution that fits both viewpoints.
Money::fromFloat(3.5);

public static function fromFloat($amount)
{
  if (!is_float($amount)) {
    throw new \InvalidArgumentException();
  }

  return new self((string)Number::fromFloat($amount));
}

This issue has too many problems. If there is a float, say 3.5, should that become 3 or 4? Or should we use a rounding mode? But since the method will be static, we have to change more. And since I am totally against making the constructor a bag mixed types, I am going to close it. This is possible, but requires a more comprehensive solution than the current proposition.


Remove required story prop which isn't used

Fixes issue: https://github.com/gvaldambrini/storybook-router/issues/43

Thanks
cc @joshuadiablito


When crawling whole sites, is there a way to start crawling the latest news rather than old ones?

Mandatory

[ x] I read the documentation (readme and wiki).
[ x] I searched other issues (including closed issues) and could not find any to be related. If you find related issues post them below or directly add your issue to the most related one.

Describe your question
When I scrape wholes sites, the crawler starts few years back. Does the crawler have a more intelligent way to crawling info and starting with more recent news? I already filter out by date, but it can take ages to get all the news, since the crawler always starts with articles posted a few years ago.
Intent (optional; we'll use this info to prioritize upcoming tasks to work on)

[x ] personal
[ ] academic
[ ] business
[ ] other
Some information on your project:

Which crawler did you use? Currently, there seems to be no easy (=quick) and reliable way to determine from when a news article is without fully parsing it.

I ran into this issue. I was working with some RSS feeds that had so many links that the script would run over a day, just on one source.
It's not a perfect solution, but I am now using the CLOSESPIDER_PAGECOUNT scrapy setting in my config file to cap the number of articles that can be processed per source.
It's not a perfect solution, because it will miss over some potentially relevant entries. But it's quick and worked for my purposes and with most of my sources.


Pass through dynamic DB vars

Description
Use external managed postgres instance. Pass through new variables from environment variables. Still TODO is to migrate the password to a K8s secret (temporarily made it a regular env var to get it working).
Other changes
Add env vars for new region: West Europe
Tested
Staging deployment

stale


[bug]  Dogecoin Blockchain fail to Sync 100% on new installation in 1.14.9

Bug Report
Receiving multiple reports at least from 2 diferent shibes that after upgrading to latest 1.14.9 it fails to sync in ~69%
Current behavior:
Stuck on ~69%
Expected behavior
Sync completely to 100%
Steps to reproduce:
New install of 1.14.9 and let it sync
Screenshots
2024-12-15 07:00:50 receive version message: /Shibetoshi:1.14.99/: version 70015, blocks=5500643, us=xxx.xxx.xxx:37088, peer=41
2024-12-15 07:02:07 receive version message: /Shibetoshi:1.14.9/: version 70015, blocks=5503476, us=1xxx.xxx.xxx:49208, peer=42
2024-12-15 07:11:07 connect() to xxx.xxx.xxx:22556 failed after select(): Connection refused (111)
2024-12-15 07:12:56 connect() to xxx.xxx.xxx:22556 failed after select(): Connection refused (111)
2024-12-15 07:19:35 connect() to xxx.xxx.xxx:22556 failed after select(): No route to host (113)
2024-12-15 07:24:00 connect() to xxx.xxx.xxx:22556 failed after select(): Connection refused (111)
2024-12-15 07:52:21 connect() to xxx.xxx.xxx:22556 failed after select(): Connection refused (111)
2024-12-15 07:59:14 connect() to xxx.xxx.xxx:22556 failed after select(): Connection refused (111)
2024-12-15 08:12:53 connect() to [xxxx:xxxx:xxxx:xxxx:xxxx]:22556 failed after select(): No route to host (113)
2024-12-15 08:15:09 connect() to xxx.xxx.xxx.209:22556 failed after select(): No route to host (113)

(omitted IP's for security reasons)
Dogecoin Core version
1.14.9
Machine specs

OS: Ubuntu linux x86

Extra information
2 shibes reached me with the same issue since lastest update and cant sync 100% even removing everything and installing it again from scratch
(I personaly did not tested yet from scrach to confirm it, but maybe there is more people with the same problem)

Patrick, maybe I should close this issue as invalid and I will try to figure it out outside Github because it seems my issue offended some people on some private chats.
I was being honest and actually trying to be useful somehow on CORE.
I like you @patricklodder , and was really nice to talk with you in person 2 months ago and only wen we talk face to face we can judge a person IMO, not in Chats that often we say things that we ear others saying.
If I did something wrong, I did not saw it and I feel demotivated to help in anyway CORE
That type of bad judgment I think it pushes people away on actually helping the little they can.
Hope for the best for CORE and all devs that helps here , but I see I'm not welcome anymore here on CORE or anything I do on my own projects for Dogecoin CORE. <3

@qlpqlp I'm going to try to reproduce this, but I think the problem is that: issues really shouldn't be raised on anecdotes or "i heard from someone". If you have personally experienced and reproduced a bug then by all means raise it, but this isn't the place for action on rumors or things you've been told.
Social media spaces may thrive on that - but this is not that, and that culture shouldn't permeate here.
However we'll do due diligence and try to reproduce it. But understand it may be a chase without a conclusion.

One of the persons that flag the issue, also spoke with Patrick for my knowledge a few hours ago and I think the person that asked me if I knew anything is not the type of person that don't know what he is doing.
in total 3 person's reached me with the exact same issue and I also was not able to reproduce because I don't have for now 200GB available to make new Syncs.
My first approach was to ask the person to uninstall and remove the data and install it again, but after that the issue persisted, even on new hardware.
Someone just mentioned to me just now maybe it's because Doginals spam crap, because its a huge chunk of data, it can take hours to sync and it seams it's stuck, but like I said, I did not tested myself to reproduce the same problem.
If there is no issue, simple, just answer that I was wrong and close the issue, I don't see why the fuzz and drama about it, there is always false positives, and can be the case thats why I submitted, but I will not do it in the future anymore
Because I never noticed any problems on my end on all my nodes, I posted here because it's here that we should talk about wen it's  a coincidence that there are several people complaining the same for no aparent reason, right? or I'm somewhat wrong?
Or better yet.
Were anyone in the community can reach wen someone finds any issues even if not certain?
Sorry my sarcasm but it seams closed chat groups that some people still DM me informing what happened after I submitted the possible bug, is demotivating, for me at least.

Inev, we have no control or insight into who's messaging you... and this is all public viewable. The best I can say on unwanted outside commentary you're getting is that I guess you'd have to talk to GitHub administration about that.

I don't know what happens outside of what is here so if people bother you, I'm sorry they do. If you have an issue, file it.
Let's not close this issue unless it's resolved or found to be not valid. Ignore private messages that tell you to do that.
If anyone else has this issue, please let us know:

output of dogecoin-cli getbestblockhash
an excerpt of debug.log around the last mention of that hash... say, 100 lines before and after, so we can try to reproduce.

It could be that this is a hardware issue (we've seen this before) but can't rule out something else.

Only now seeing this wen I was organising everything, sorry the late reply.
Im now also testing to see if somehow I can reproduce, but on one machine it using NIXOS, is sync 100% without any issue and I will try to test it on Ubuntu also tomorrow. Probably can be some huge blocks that take some time to download.
Thanks @patricklodder and @michilumin , and sorry about me sometimes being frustrated <3


Removed dependency of emulator to run unit tests locally

Packages impacted by this PR
@azure/cosmos
Describe the problem that is addressed by this PR
Through this PR we are trying to remove the dependency of running the emulator to run unit tests locally.

API change check
API changes are not detected in this pull request.


Added Markdown Support for Custom Profile Fields - Frontend

Purpose:
This is an extension upon issue #10131 where the frontend for the web client has been added for this feature. Also, the custom profile field data is now pushed with the initial state.
Testing Plan:
I've done both manual and automated testing for this PR for both the frontend and backend. For automated tests, I've made sure that the new code conforms to pass them, else if needed I modified the old tests. For the frontend aspect no new tests have been created.
GIFs or Screenshots:

So I'm made all of the basic refractory changes in one updated commit. Once I resolve the "not sending rendered_value(s) when not required" discussion, I'll update the commit once more.

Current Status
So what we currently have in this PR is 3 commits which may be squashed as necessary.
e44b734 - This is a prep commit where an if-else block in popovers.js was replaced with a switch statement.
ba26cb2 - This is the commit that we have been discussing and contains the main feature.
306b664 - In this commit, the rendered_value is sent only if the field has a renderable value. Basically, if the field has a rendered value, the data is sent as {"value": value, "rendered_value": rendered_value} and if it doesn't then the data is send as {"value": value}
Please Note:
in commit 306b664, one thing that I would like to mention is that there were a few parts of the tests that I had to modify and I'm not entirely sure if they are proper modifications. These modifications are:

lines 3109 and 3127 in the updated version test_events.py
any changes made in test_home.py

@timabbott, I would like to hear your thoughts and comments on these recent changes.

@Hypro999 I agree with this structure: Basically, if the field has a rendered value, the data is sent as {"value": value, "rendered_value": rendered_value} and if it doesn't then the data is send as {"value": value}.
The changes in tests to dramatically change expected query counts are wrong; those huge increases in query counts reflect a bug in your code where you're doing one new database query per user.  I'm pretty sure the bug is that profile_field.field.is_renderable() ends up fetching the CustomProfileField from the database.  Try doing this:
custom_profile_field_values = CustomProfileFieldValue.objects.filter(user_profile__realm_id=realm_id)
->
custom_profile_field_values = CustomProfileFieldValue.objects.select_related("field__field_type").filter(user_profile__realm_id=realm_id)
and see if that fixes it.

those huge increases in query counts reflect a bug in your code where you're doing one new database query per user.

Ah, that explains it. I double checked my code and as you've pointed out the bug was indeed due to profile_field.field.is_renderable() so I made the suggested change (except used select_related("field")) and the numbers went back to what they should be. Problem solved.

Are we now ready to merge this? Or is there anything else that might need to be added or modified?

I merged the first commit, renamed the schema checkers to be more clear in test_events, and pushed back to this PR.  @Hypro999 there's one thing I'm suspicious of here, which is why you removed the JSON.parse() in the settings_account.js code -- can you explain why you did that?
Additionally, I think this would be cleaner if split into two commits: First one that just makes makes the API change to send a dictionary with .value, and second one that actually adds the new feature.
This will be good practice in writing clearly split out commits for you.

That explanation isn't super satisfying -- what I want to know is what other change made it the case that we don't need to do JSON parsing for user format fields.  Well, wouldn't it need to be values.value = JSON.parse(values.value)?
I think after you migrate this changeset to a series of coherent transformations, it'll be a lot more clear what's going on here.
@YJDave may have some insight into why we had the user field type in the first place.

Additionally, I think this would be cleaner if split into two commits: First one that just makes makes the API change to send a dictionary with .value, and second one that actually adds the new feature.
This will be good practice in writing clearly split out commits for you.

Done. :slightly_smiling_face:
Now I'm going to take a closer look at how justified it was to remove that line with JSON.parse() and I'll report what I find out.

@timabbott, I've pushed a "squashable" commit which should re-introduce JSON.parse() into the append_custom_profile_fields() method. I believe that the issue was that now since we are passing around JS objects and not JS strings, the result of people.get_custom_profile_data(user_id, field.id) was a reference to the JS object as opposed to a copy of that data. Which could explain why doing JSON.parse() in one method would affect other methods when they tried to do the same.
Could you please give this another look?

So I figured out what's going on with that JSON.parse logic -- it's actually irrelevant.  We don't use the field_value.value in that template render for user type fields -- another function does the rendering.

Merged as the series of commits ending with e3aed0f7bc8dab49bb2431b2cd352248f79fc89e, thanks @Hypro999!  Thanks for doing this -- it was a significant new feature :).
In terms of next steps, I think reviewing and helping finish some of @YJDave's open custom profile fields PRs (especially the one adding an admin UI, which mostly just needs one bug tracked down) would be great, and then tackling adding markdown to stream descriptions should come next.


Series sorting filtering

Because additional series results are now returned due to #143 the series selection window can with a large number of results that are not usually sorted in a useful way.
I've created 3 settings that can help finding the corect series quickly

use the publisher black list - can be toggled from the series selction screen, as well as a setting for is default behaviour
a setting mak the result initally sortted by start year insead of the default no of issues
a setting to initially put exact and near matches at the top of the list

Also binaries built using pyinstaller are uploaded for macos and windows if you look under the checks

@thFrgttn If you squash your commits I will merge this pull request


CmdAdd and CmdEnv now respect Dockerfile-set ENV variables

Fixes #1136
Notes:
This changes the type of environment variable options.
Building and running the following dockerfile will produce the functionality of the output that follows it.
#Dockerfile. Directory also has a directory named 'testdir' which contains a file named 'myfile'.
FROM ubuntu:12.10
ENV DESTPATH /foobar
ENV ORIGPATH ./testdir
ENV FOOPATH $ORIGPATH/dir${DESTPATH}/dir
ADD $ORIGPATH $DESTPATH/$ORIGPATH
RUN echo $FOOPATH
#docker logs outputs './testdir/dir/foobar/dir'

#docker run -i -t image /bin/bash
$ ls / | grep foobar
foobar
$ cd /foobar && ls
testdir
$ cd testdir && ls
myfile

I'd would like to make clear -- in ENV line to read an env variable works at docker build time, right?


Added FilesToCopyProperties for embedded-postgres

Added configuration to copy files from classpath or system path. Please consider that this feature can also be applied to others as well.

Codecov Report

Merging #52 into develop will increase coverage by 8.49%.
The diff coverage is 75%.

@@              Coverage Diff              @@
##             develop      #52      +/-   ##
=============================================
+ Coverage      74.53%   83.03%   +8.49%
- Complexity        85      280     +195
=============================================
  Files             17       75      +58
  Lines            271      943     +672
  Branches          10       16       +6
=============================================
+ Hits             202      783     +581
- Misses            64      150      +86
- Partials           5       10       +5

Impacted Files
Coverage Δ
Complexity Δ

...laytika/test/postgresql/FilesToCopyProperties.java
60% <60%> (ø)
1 <1> (?)

...esql/EmbeddedPostgreSQLBootstrapConfiguration.java
97.36% <85.71%> (ø)
7 <2> (?)

...mbeddedAerospikeDependenciesAutoConfiguration.java
100% <0%> (ø)
2% <0%> (?)

...est/redis/EmbeddedRedisBootstrapConfiguration.java
90% <0%> (ø)
4% <0%> (?)

...playtika/test/aerospike/AerospikeWaitStrategy.java
70% <0%> (ø)
4% <0%> (?)

...pike/AerospikeTestOperationsAutoConfiguration.java
100% <0%> (ø)
6% <0%> (?)

...java/com/playtika/test/neo4j/Neo4jStatusCheck.java
100% <0%> (ø)
3% <0%> (?)

...ika/test/aerospike/AerospikeTimeTravelService.java
9.09% <0%> (ø)
1% <0%> (?)

.../com/playtika/test/mariadb/MariaDBStatusCheck.java
100% <0%> (ø)
3% <0%> (?)

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d7561...9630b8e. Read the comment docs.

squash commits into single one

Please ignore this commit, wrongly squashed.

Closing this pull request, better to clean up the fork and create another pull.


allow for premium users to install with minimal changes

adds +prem to vault_version var if vault_enterprise_premium=True
also, add handler to restart vault servers if listener config changes

found a copy pasta error. closing, will reopen


Mapping array of objects to one object

Hello,
API I'am forced to use got a little bit rusty data model (and I'm not able to change it). So we've got something like below.
{
  groups=({
    key="VALUE_1";parameters={

    };version=0;
  },
  {
    key="VALUE_2"parameters={

    };version=0;
  },
  {
    key="VALUE_3";parameters={

    };version=0;
  });
version=0;
}

Yes - there is LITERALLY key.
What I was trying to do is to ignore fact that groups is an NSArray and treat it like 3 objects of same class.
So I've got objects like
MainObject
@property (nonatomic, retain) GroupObject *groups;
GroupObject
@property (nonatomic, retain) Group *value_1;
@property (nonatomic, retain) Group *value_2;
@property (nonatomic, retain) Group *value_3;

My GroupObject got
- (instancetype)initWithDictionary:(NSDictionary *)dict error:(NSError *__autoreleasing *)err {
    if ((self = [super init])) {
        for (NSDictionary *element in dict) {
            if ([[element valueForKey:@"key"] isEqualToString:@"VALUE_1"]) {
                self.value_1 = [[Group alloc] initWithDictionary:element error:nil];
            } else if ([[element valueForKey:@"key"] isEqualToString:@"VALUE_2"]) {
                self.value_2 = [[Group alloc] initWithDictionary:element  error:nil];
            } else if ([[element valueForKey:@"key"] isEqualToString:@"VALUE_3"]) {
                self.value_3 = [[Group alloc] initWithDictionary:element error:nil];
            }
        }
    }

    return self;
}

The GroupObject in return self; is initialized correctly. Then we're moving to JSONModel.m to __importDictionary method and in line 387
                if (![value isEqual:[self valueForKey:property.name]]) {
                    [self setValue:value forKey: property.name];
                }

after If I've got
self	MainObject *	@"0 objects"	0x79fde270
value is correct object of GroupObject, property.name is equal to "groups" and it's not settings the value for property name.
Where is the problem?

Please provide the original JSON. What you have shown above is not JSON.
JSONModel can parse arrays fine. It will be up to you to map from the array to an object with 3 items.

I am not able to provide original JSON (cause of NDA ;) ) but this is the original scheme with changed data/names.
x, y and VALUE_ is just mock data, rest are the original keys.
{
  "groups": [
    {
      "parameters": {
        "x": "y",
      },
      "key": "VALUE_1",
      "version": 0
    },
    {
      "parameters": {
        "x": "y",
      },
      "key": "VALUE_2",
      "version": 0
    },
    {
      "parameters": {
        "x": "y",
      },
      "key": "VALUE_3",
      "version": 0
    }
  ],
  "version": 0
}

Ok I found the problem. It was well known Xcode Derived Data issue - it was not making correct instance of object because of wrong compilation. Not JSONModel isseue. Sorry for taking your time. Thank you for your help.

No problem. 😄  Let us know if you need anything else.


sys-core: accounts

Now we start the real system and start at the login and users.
sys-core/server

starts the genji badger DB, and so all modules automatically get access to it.
Can call the DB "sys-core", and genjo will create a folder at runtime for it.
Any Tables sys-core controls shoudl start with "sys-core ...." prefix.

same with anything else.
Is this way all modules can use the genji Badger DB and control their Tables.

sys-core/accounts

Needed because all modules need access to the accounts data in order to do Auth / Authz
Also mod.admin will need it.
SO essentially we need to take mod-accounts and now call it sys-core/accounts

Will have a client and server
client stuff can be widgets and pages that we reused by Modules ( see below ...)

mod-admin:

Is used for an Admin to see and edit the users, roles and permissions.
So It will use many of the client and server code from sys-core/accounts

After:

add the domain model for auth and authz
DB and logic: https://docs.google.com/document/d/1LGkCEzh2CwwW6VYTYxXsDW14gYrzly0gwZtfrkbTG9Y/edit#heading=h.kfxtpktt4sc3

Test Data

CLI can load in JSON Via GRPC.
code gen the CLI  using: https://github.com/fiorix/protoc-gen-cobra
Code gen the test data: ?? ) joe to FIND !!!!

Starting


Extending qrgen.py to allow multiple QR Code files

I made a mess of the merge in PR #297, so have run a clean branch with the new changes on top.
This is a remix on qrgen.py, pulling in features from image.py that would allow for multiple qr code files that could be cycled through. I don't know if you'd rather keep the qrgen.py example "clean", but I'm using this personally on my badger2040 so thought others might like to as well.
On first start, it creates a qrcodes directory, then adds the example file in there instead, the acts just like the image example where it draws dots on the right hand side and allows you to cycle through with the up and down buttons.
Signed-off-by: James Sutton<EMAIL_ADDRESS>

Thank you! And, sorry, a minor change to qrgen has conflicted this. Don't worry- I can sort it if there are no other changes needed.

Rebased, updated to the new API and raised as #333


⚠ Bofrost.nl has degraded performance

In d4f6b8b, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1333 ms

Resolved: Bofrost.nl performance has improved in 31eb6be.


Tooltip with file path stay after closing pane

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description
A tooltip with a file path stay on the screen after closing a pane if the contextual menu is brought by clicking on a actual file tab.

Steps to Reproduce

Open a file
Split the pane (any direction)
Close a pane with the cursor on a file tab

Expected behavior:
The pane is closed and no tooltip with the file path is shown
Actual behavior:
The pane is closed but an unremovable tooltip with the file path stays on screen.
The tooltip will finally disappear if the window is resized.
Versions
Both versions: Atom 1.9.9 and Atom beta 1.10.0-beta6 on OS X 10.11.6

https://github.com/atom/tabs/issues/362

Thanks.


HTTP SystemTask vs. Worker task

Is there any recommendation/experience w.r.t. using the HTTP system task vs. implementing a worker to execute tasks?  I didn't see anything in the docs besides the mechanics.
Are there any advantages or disadvantages to consider when choosing between the task types?

Having the same question...
My read from the doc is that System tasks are run in the same JVM as the conductor.  If your API is hosted in a separate container (which it should for scalability and performance tuning), they should be called through the worker task.  The system task is the "control language" that manage the flow, conditions, folks, joints, etc.  However, I got confused by the following in the System task:
DYNAMIC - A worker task which is derived based on the input  expression to the task, rather than being statically defined as part of  the blueprint.
So, looking for guidance as well...

Tagging along for the ride for this answer. Are there any examples of what constitutes as a worker task? The only thing I could pick up from the docs was "encoding a file" as an example, which made sense in the context. But, when deciding between a HTTP task and a worker task for making a request to an endpoint, which is recommended over the other?

@nakulm95 Using an HTTP task you'll define the URL where you make the call out to the service.  So, the service URL is part of your workflow.  But, with a task that polls, that polling worker can come and go and be on different machines and fulfill the request w/out changes to your WF if the URL changes


Create Table Query Not Connecting to Lineage Graph

In an example DAG, the create table query and possibly drop table query are not being added to the lineage graph containing the rest of the DAG, despite clearly referencing the same table. See screenshots below:
Create query and single lineage node:

The rest of the lineage graph (insert query, check queries, dataset) all come up fine together:

This is also an issue with INSERT statements and DROP statements.


Duplicated oplog entries with MongoDB 2.4 breaks mongo-connector

I tried to use mongo-connector with MongoDB 2.4 and have found a problem with duplicated entries in the oplog. Basically $unset is written to the oplog even if the field being unset doesn't exist.
Example:
PRIMARY> db.version()
2.4.14
PRIMARY> use test;
switched to db test
PRIMARY> db.test.insert({"a":"1","b":"2"});
PRIMARY> db.test.find();
{ "_id" : ObjectId("586a4f39656f449ce6b62c25"), "a" : "1", "b" : "2" }
PRIMARY> db.test.update({"_id" : ObjectId("586a4f39656f449ce6b62c25")},{$unset:{"a":"1"}});
PRIMARY> db.test.find()
{ "_id" : ObjectId("586a4f39656f449ce6b62c25"), "b" : "2" }
PRIMARY> db.test.update({"_id" : ObjectId("586a4f39656f449ce6b62c25")},{$unset:{"a":"1"}});
PRIMARY> db.test.find()
{ "_id" : ObjectId("586a4f39656f449ce6b62c25"), "b" : "2" }
PRIMARY> use local
switched to db local
PRIMARY> db.oplog.rs.find();
{ "ts" : Timestamp(1483362083, 1), "h" : NumberLong(0), "v" : 2, "op" : "n", "ns" : "", "o" : { "msg" : "initiating set" } }
{ "ts" : Timestamp(1483362106, 1), "h" : NumberLong("-2373604974530658287"), "v" : 2, "op" : "i", "ns" : "test.test", "o" : { "_id" : ObjectId("586a4f39656f449ce6b62c25"), "a" : "1", "b" : "2" } }
{ "ts" : Timestamp(1483362127, 1), "h" : NumberLong("5823667433637975028"), "v" : 2, "op" : "u", "ns" : "test.test", "o2" : { "_id" : ObjectId("586a4f39656f449ce6b62c25") }, "o" : { "$unset" : { "a" : 1 } } }
{ "ts" : Timestamp(1483362141, 1), "h" : NumberLong("-1127311525069515859"), "v" : 2, "op" : "u", "ns" : "test.test", "o2" : { "_id" : ObjectId("586a4f39656f449ce6b62c25") }, "o" : { "$unset" : { "a" : 1 } } }

This causes a problem since the apply_update method throws a KeyError if the field doesn't exist.
Relevant code is here: https://github.com/mongodb-labs/mongo-connector/blob/d6ef8b265b4e3b77e2d5e6b93d8abc12e8569989/mongo_connector/doc_managers/doc_manager_base.py#L79-L85
MongoDB 2.6 and later seems to have removed these duplicated entries (only tested 2.6 so far).
Since 2.4 reached End of Life in March 2016 it might not make any sense fixing this issue and mongo-connector could just drop support for 2.4.

I cannot reproduce this with MongoDB 2.4 and mongo-connector 2.5.0. Can you post the traceback you are seeing?

I'm using mongo-connector 2.5.0 with elastic2-doc-manager 0.3.0.
The problem only seems to happen when a document currently being cached for a bulk update gets an $unset on a non existing field. Without bulk updates it seems to work fine.
I have made a small patch which fixes the problem for us by ignoring KeyError if its an $unset.
If you want I can clean up my patch an make an PR.

I'm able to reproduce this error using your example above. My environment must have been off in some way the last time I tested it. The error when mongo-connector attempts to process the second $unset:
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/threading.py", line 532, in __bootstrap_inner
    self.run()
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/elastic2_doc_manager.py", line 150, in run
    self._docman.send_buffered_operations()
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/elastic2_doc_manager.py", line 482, in send_buffered_operations
    action_buffer = self.BulkBuffer.get_buffer()
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/elastic2_doc_manager.py", line 693, in get_buffer
    self.update_sources()
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/util.py", line 33, in wrapped
    return f(*args, **kwargs)
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/elastic2_doc_manager.py", line 648, in update_sources
    updated = self.docman.apply_update(source, update_spec)
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/elastic2_doc_manager.py", line 224, in apply_update
    return super(DocManager, self).apply_update(doc, update_spec)
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/doc_manager_base.py", line 90, in apply_update
    exc_tb)
  File "/Users/shane/venv-mc-local/lib/python2.6/site-packages/mongo_connector/doc_managers/doc_manager_base.py", line 85, in apply_update
    doc.pop(to_unset)
UpdateDoesNotApply: Cannot apply update {u'$unset': {u'a': 1}} to {u'b': u'2'}

I think simply ignoring KeyError in this case may be the best approach. We could also catch the UpdateDoesNotApply and ignore the update but that would require changes to the DocManagers.

Fixed by https://github.com/mongodb-labs/mongo-connector/commit/f5f3cda5c27b2f74fe43d5697f5ff8825c3db5db and https://github.com/mongodb-labs/mongo-connector/commit/53200e100f14a1820ec0c6cca6f2b72740979b44.


Add linux_test build tags

This work is in effort to support Windows tests. In the future we will be able to add a windows_test build tag to separate tests that are windows specific from tests that are linux specific. This will also let us share tests that are os agnostic by adding both build tags.

/assign @bkatyl


CheckBox performance is very bad

Describe the bug
Compared to the built-in WPF checkbox style, the rendering performance is really bad. Perhaps due to the massive amount of attached properties?
I saw some PRs that added fallback values, and have tried that but it didn't help with rendering speed. Only thing that works is removing the checkboxes or going back to WPF's own style.
Steps to reproduce
A description of how to trigger this bug.

Add a listbox with am item template with a checkbox and some other stuff, such as some of the MahApps icons 🙂
Add several hundred items.
Virtualization can be enabled or disabled, it doesn't matter.
Scroll, and see how laggy it is.

Expected behavior
It should not lag.
Actual behavior
It lags.
Environment
MahApps.Metro version: v2.4.9
Windows build number: Win10 22H1
Visual Studio: 2022
Target Framework: .NET v4.7.2, also .NET 6.0.

@Nuklon Can you create an app where you can show this problem? Because I tested it at the demo app and the current source and have no problems. Thx!

Yeah, can do, will try to do this weekend.

Haven't managed to create a sample yet, but it seems it's due to dynamic resources usage. If I change dynamic resource to static it's OK. This seems related: https://github.com/MahApps/MahApps.Metro/issues/4100

I've created a sample here: https://github.com/Montago/MahAppsCheckboxSample
When using standard WPF it takes 50ms to render Tab 2
When MahApps is added it takes 470ms !!!
I've supplied 2 Profile sessions where you can see the major difference.

@Montago Thx for the sample. If I use the virtualized ListView then I can improve the performance significant.
<ListView ItemsSource="{Binding Elements}" Style="{StaticResource MahApps.Styles.ListView.Virtualized}" ScrollViewer.IsDeferredScrollingEnabled="False">
</ListView>

hi - thanks for the tip !
yea - its now 123ms instead of 470 .. still about 2-3x slower than native WPF (50ms)
I'll try adding this to all my ListViews and see how much faster my app gets.
Sadly i suspect that MahApps Metro gives my apps a significant performance penalty besides this case with a simple ListView.
I'm working on 2 big inhouse projects which contains 1000s of checkboxes and tons of usercontrols - and eventhough very simple in nature - these apps are HEAVY and one of them seems to have memory leaks :(
Reading up on this issue i found that MahApps which use DynamicRessource contains such memory leak:
http://blog.lexique-du-net.com/index.php?post/2011/03/27/What-Dynamic-resources-creates-Memory-leaks-in-WPF-3.5-(SP1)
I'm wondering if i should completely remove MahApps and see if it makes a major difference ..

@Montago MahApps uses standard WPF like attached properties and DynamicResource, so if it's slow in that case, then it could also still a bug in WPF itself. The DynamicResource in our case is needed because of the Theme system that we have. If we try to replace this with StaticResource then it would be a massive change with other challanges. That's maybe also a reason why Microsoft creates new technique liek UWP, WinUI or MAUI.
And yes, it would be cool if someone find a way to help here for the performance.

I'm working on 2 big inhouse projects which contains 1000s of checkboxes and tons of usercontrols - and eventhough very >simple in nature - these apps are HEAVY and one of them seems to have memory leaks :(
Reading up on this issue i found that MahApps which use DynamicRessource contains such memory leak:
http://blog.lexique-du-net.com/index.php?post/2011/03/27/What-Dynamic-resources-creates-Memory-leaks-in-WPF-3.5->%28SP1%29

Yeah, but that is not related to MahApps itself and you can do a workaround. https://github.com/MahApps/MahApps.Metro/issues/4100#issuecomment-832755345
So if you don't want or don't can use MahApps then it's ok, try another lib, but I think there are similar issues then.

I just noticed - the MemoryLeak was present in WPF 3.5 and the article is from 2011 ..
Since im working in Framework 4.7 im using WPF 4.5+ (probably 4.7)
Like i said - i'm only interested into figuring out why there are performance issues and one thing i could try would just be to disable MahApps and see how big an impact it is...
I like the style, so maybe i could cherrypick the style setters...

@Montago @Nuklon Also the latest source has some performance improvements, just tested it out and it renders faster then 2.4.9

My sample is based on latest source (just replace these files in Caliburn.Demo folder) and I don't really notice any difference with the latest official version. See below. On my main PC the performance is OKish (not great, not terrible), but on slower machines it's very noticeable when you replace the MahApps style with x:Null (which then uses WPF style).
MahApps.Metro.Caliburn.Demo.zip
The CheckBox is by far the slowest component, the other controls are mostly OK. They're a bit slower here and there but it's acceptable. With large item collections and several checkboxes, it becomes very very slow.
The style from ModernWpf (https://github.com/Kinnara/ModernWpf/blob/master/ModernWpf/Styles/CheckBox.xaml) is very fast and also supports dynamic theme switching. I think this is largely because it doesn't try to dynamically load all brushes etc at once but rather as a trigger. Perhaps MahApps can adopt a similar structure? You'd loose the ability to define it with a helper, but I'm not sure how useful that is when you can just override it with a style. Basically replace helper with a style, so you can override that instead of with the helper. Hope you understand what I mean here 🙂

With large item collections and several checkboxes, it becomes very very slow.

would you say that 180 checkboxes are a large collection ?

Thinking out loud:
Why is it that WPF with a bit of styling becomes so agonizing slow ?

With HTML you could easily create something similar and it would run with 400 fps on a toaster...
/rant off
@punker76  thanks - but i'll wait for an official nuget package update (release version)

I've created a style that's the same as the current one, but doesn't use attached properties, and instead just dynamic resources on trigger (see previous comment) and it's not as fast as built-in style but much, much faster. My app goes from pretty much unusable to OK.
@punker76 What do you think about removing most attached properties from MahApps? I really don't see a use for most of these as you can simply restyle it.

@Nuklon I‘ll remove all attached properties which related to Brushes and which can be done by overriding Xaml keyed stuff. I’ll this change after my holiday.

Great, have a nice holiday 🥂

@Nuklon FYI https://github.com/dotnet/wpf/issues/4468

@Nuklon FYI dotnet/wpf#4468

Mainly using .NET Framework though :)

The same performance issue is present in Framework, due to general perf improvements in Core it should be even worse in Framework.
Just wanted to point out that it's not all MahApps fault.

Right :) But it can be considerable better though as written above. I know it's a workaround for a problem with .NET itself, but it'd be appreciated nonetheless :)


Integration Test - Release - 2022/04/27 03:40:11

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#please-close

#unassign PRMergerTest1

#unassign NonAllowedUser