Start-Process doesn't pass arguments with embedded whitespace and double quotes correctly

Updated later to include the problem with embedded double quotes.
Steps to reproduce
Embedded whitespace:
'"Hi!"' > './t 1.ps1'; Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-file', './t 1.ps1'

Embedded double quotes:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-command', '"Hi!"'

Expected behavior
In both cases:
Hi!

That is, script file ./t 1.ps1 should execute, and double-quoted string literal "Hi!" should print.
Actual behavior
Embedded whitespace:
Invocation fails, because the ./t 1.ps1 is passed as two arguments:
The argument './t' is not recognized as the name of a script file. Check the spelling of the name, or if a path was included, verify that the path is
correct and try again.

The only way to make this currently work is to embed (potentially escaped) double quotes: '"./t 1.ps1"' or "`"./t 1.ps1`""; e.g.:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-file', "`"./t 1.ps1`""

Update: Overall, the best workaround is to pass a single string containing all arguments to -ArgumentList and use embedded quoting and escaping as necessary:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile -file "./t 1.ps1"'

Embedded double quotes:
The embedded double quotes are unexpectedly removed.
The only way to make this currently work is to \-escape the embedded double quotes:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-command', '\"Hi!\"'

Update: Again, the best workaround is to use a single string:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile -command \"Hi!\"'

Environment data
PowerShell Core v6.0.0-rc (v6.0.0-rc) on Microsoft Windows 7 Enterprise  (64-bit; v6.1.7601)
Windows PowerShell v5.1.14409.1012 on Microsoft Windows 7 Enterprise  (64-bit; v6.1.7601)

I think it just executes {filename} {ArgumentList.join(' ')}
try this code
Start-Process -Wait -NoNewWindow pwsh.exe -ArgumentList '-noprofile', '-file', '"./t 1.ps1"'
Start-Process -Wait -NoNewWindow pwsh.exe -ArgumentList '-noprofile', '-file', '"', './t 1.ps1', '"'

The code where it deconstructs -Argumentlist to the Argument string for ProcessStartInfo.Arguments here and it simply joins the arguments by separating it with a space character. Therefore it sees ./t and 1.ps1 as 2 separate arguments. As pointed out by @ZSkycat one has to correctly quote the file. Therefore I would not qualify this as a bug but rather as by design. WDYT @SteveL-MSFT

I see the feature is documented:

Arguments are parsed and interpreted by the target application, so must align with the expectations of that application. For.NET applications as demonstrated in the Examples below, spaces are interpreted as a separator between multiple arguments. A single argument that includes spaces must be surrounded by quotation marks, but those quotation marks are not carried through to the target application. In include quotation marks in the final parsed argument, triple-escape each mark.

I don't understand how we can fix this for all platforms and for an indefinite number of applications. If there is no standard to which we should follow I would rather expect a common way of passing arguments so that they reach the goal application in exactly the user specified form.

Well, I guess we can only improve it (see my PR 5703) or maybe the better solution is to add an -Arguments parameter that is just a string to reduce complexity and leave the -ArgumentList parameter there only for legacy reasons.

@bergmeister: Thanks for taking this on in your PR, but there are additional edge cases to consider, such as tokens ending in \ - see https://github.com/PowerShell/PowerShell/issues/1995#issuecomment-330675421
Ultimately, the single string passed to ProcessStartInfo.Arguments should be constructed the same way that a direct call to an external program is handled, namely based on inverse of the MSVC++ command-line parsing rules, as discussed in @TSlivede's RFC proposal.
Longer-term, once https://github.com/dotnet/corefx/issues/23592 is implemented in CoreFx, PowerShell will simply be able to pass the array through. The linked issue also points to a utility method in the CoreFx code where the kind of array-to-command-line transformation that would be needed here is used internally.
And, yes, this will break things, inevitably and in multiple scenarios, but I think if PowerShell wants to be taken seriously as a multi-platform shell, there's no way around that.
While we may consider adding a new -Arguments parameter for someone who wants to pass a single-string, pre-escaped command line (directly assignable to ProcessStartInfo.Arguments - which, notably, still needs to be split back into an array before creating a process on Unix), it is -ArgumentList that must be fixed - which breaks things.

@mklement0  As far as I understand the shortest way to get this is to implement https://github.com/dotnet/corefx/issues/23592, isn't it?

@iSazonov: Yes, with said proposal implemented, PowerShell could just use the new ProcessStartInfo.ArgumentList property directly and, on Windows, let CoreFX translate that into a single command line string with appropriate quoting.

Ok. Shall I close the PR then?

I think it is not critical and not a secure hole so we can wait and it is better to direct our efforts to other areas or contribute directly in CoreFX now.

On a related note, it seems to truncate at the > character too:
PS> Start-Process -Wait -NoNewWindow node -ArgumentList '-e', 'process.argv.slice(1).forEach((x) => console.log(x))'
[eval]:1
process.argv.slice(1).forEach((x)
                                ^
SyntaxError: missing ) after argument list

(Windows PS 7.0.0-preview3)

@Artoria2e5: The problem isn't >, the problem is that process.argv.slice(1).forEach((x) => console.log(x)) isn't passed through as a single argument, it is broken into 3 arguments by whitespace.
That is, your node command is effectively executed as follows, which explains the symptom:
node -e 'process.argv.slice(1).forEach((x)' '=>' 'console.log(x))'

ho boy...

This is very annoying when wrapping Linux command line tools. Could this be considered for PowerShell 7? It seems like the fix would be simple (just use ProcessStartInfo.ArgumentList). Using System.Diagnostics.Process in PowerShell directly works as expected, but is incredibly cumbersome.

It seems like the fix would be simple (just use ProcessStartInfo.ArgumentList

Having used ProcessStartInfo.Arguments recently (had to support netstandard2.0), it's a very hard API to use.
I'd second the recommendation to switch to ArgumentList if we can.

I have a PR to fix this, just need to add tests.
In the second example:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-command', '"Hi!"'

This becomes: pwsh -noprofile -command "Hi!" so it should only print out Hi! without the quotes.  The quotes are needed to tell PowerShell this is a string and not a command.  After this fix, you still need to have nested double quotes if you want quotes:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-command', '"""Hi!"""'

Glad to see that this is getting tackled.

This becomes: pwsh -noprofile -command "Hi!" so it should only print out Hi! without the quotes.

As a shell command, pwsh -noprofile -command "Hi!",  fails, because the the closing " are removed during argument parsing, causing PowerShell to attempt to execute Hi!.
What Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-command', '"Hi!"' should translate to is:
On Windows:
pwsh -noprofile -command "\"Hi!\""

On Unix, the array of verbatim tokens needs to be:
pwsh, -noprofile, -command, "Hi!"
The collection-based ProcessStartInfo.ArgumentList - not the single-string ProcessStartInfo.Arguments - should do all that for us.

Unfortunately, some bad news.  Use of ArgumentList makes this a breaking change.  Previously, you could do something like:
start-process ping -argumentlist "-n 2 localhost"

But this becomes:
ping "-n 2 localhost"

This means I can't rely on ArgumentList and will have to quote things correctly in the code as a string...
On the topic of:
Start-Process -Wait -NoNewWindow pwsh -ArgumentList '-noprofile', '-command', '"Hi!"'

Again, this becomes:
pwsh -noprofile -command "Hi!"

We could double escape the quotes to get the desired behavior, but then you can't get the result above.

From a pure UX perspective, I think it would be much better to have -ArgumentList be strictly an actual list of arguments (so, it would map directly to ArgumentList in the code), and then introduce an additional parameter that mimics legacy behaviour.
Yes, it would break something, but given the difficulty of using the current behaviour correctly... I think we're rather better off breaking it here. 😕

Although I wish the parameter behaviour was better, I agree with Steve, that we cannot make a breaking change in such an important cmdlet because it is the foundation of a lot of code and use cases are quite often very generic. A classic example is the software of CI agents that needs to spawn processes, this software usually delegates some of its work from .net/java/C++ to something simpler like node/python/powershell for doing that. Because this piece of software is implicitly used by other users, it is not known how users will call into it and implicitly break peoples build or release pipelines.
The change will need to be in a non-breaking way or at least have some way to opt back into legacy behaviour.

It's way too likely people are doing:
start-process ping -argumentlist "-n",2,"localhost"
start-process ping -argumentlist "-n 2","localhost"
start-process ping -argumentlist "-n 2 localhost"

where all 3 have the same behavior today since it's a simple concatenation with whitespace in between.  This is apparent to me looking at the test failures in my attempt to use ProcessStartInfo.ArgumentList that our tests do this.  Maybe -LiteralArgumentList is ok.

Good points, @SteveL-MSFT  and @bergmeister, as much as I wish we could go with @vexx32's suggestion.
It does seem like a new parameter is the only non-breaking solution, but, to better reflect the distinction, I propose the following names

-IndividualArguments
alias -iArgs

Additionally, we could consider renaming -ArgumentList to -Arguments, making the former an alias of the latter, and highlighting the latter in the help topic (the -Args alias luckily already has the better name).

It's also not just Start-Process, argument splatting is also affected. I recently had this problem where I was calling a utility on macOS like foo @bar. One would expect this to call foo with exactly the array $bar as arguments, instead it joins the array into a string, then splits the string by spaces and passes that array as arguments. This broke the tool whenever I wanted to pass a string as first parameter that contained a space.
A different parameter for Start-Process would not solve this usage, and it would be really annoying if we basically have to tell macOS and Linux users they cannot rely on calling commands directly and always need to use Start-Process.

@felixfbecker that's a different issue than this one, can you open a new issue or see if there is an existing one for that?

That seems like the same problem with #1995 (or at least the same possible fix, anyway).

I agree that splatting is incidental to the issue and that it comes down to #1995:
Assume a de.exe executable that prints the full command line with which it is invoked:
PS> de.exe '"hi there"'
"c:\path\to\de.exe" "hi there"   # broken: embedded " weren't preserved

# Ditto with splatting  (or direct passing of $a)
PS> $a = , '"hi there"'; de.exe @a
"c:\path\to\de.exe" "hi there"

Yes, passing arguments with embedded double quotes is fundamentally broken, and always has been - because of existing workarounds, it's a problem to fix it now without breaking lots of code.
@felixfbecker, please start reading at https://github.com/PowerShell/PowerShell/issues/1995#issuecomment-552223508 for the current state of the debate.

Since #1995 is still a big question, we definitely need to resolve the issue with Start-Process in the 7.1 milestone.
I believe we can add a new -Arguments parameter. Internally, it will use ProcessStartInfo.ArgumentList, but this internal implementation is invisible to users and should not confuse them.

I think it is better to avoid unneeded complicity - best is the enemy of good.

We also need to think about a short parameter alias that parallels -Args - what would that be for -Arguments?

With IntelliSense and tab-completion it is minor.

While PowerShell in general needn't mirror the underlying .NET APIs, I find it problematic that the semantics in this case would be the exact opposite of the underlying .NET API's

Yes, PowerShell users do not see and don't think about  underlying .NET API's. For developers we add docs and comments too.
If we blog post and enhance PSSA to recommend the new parameter I believe user adaptation will be easy.

/cc @SteveL-MSFT @daxian-dbw for PowerShell Committee review.

@iSazonov

better to avoid unneeded complicity

What unneeded complexity? If you're referring to re-typing -ArgumentList to string, there is minor implementation complexity and no added complexity to end users - on the contrary, it makes things clearer for them.

With IntelliSense and tab-completion it is minor.

We want go give power users an official short alias, irrespective of tab-completion, just like we do with -Args for -ArgumentList.

add docs and comments too.

Docs, blog posts, and comments are only part of the puzzle: the parameter names themselves shouldn't be counterintuitive:
We can't fix the -ArgumentList / -Args name anymore (except to de-emphasize -ArgumentList in favor of -ArgumentString), but we can be more descriptive in the new parameter's name:
-Arguments is ambiguous, -IndividualArguments is not.

With tab completion Arguments is more discoverable and more easy for adoption. Everything else does not make sense until the user reads the parameter description.

If your concern is that -IndividualArguments doesn't start with the word "Argument", here's another option:
-ArgumentArray / -Arga
Note that the s in the existing -Args can then be interpreted as referring to the "String" part of the renamed -ArgumentString
Here's a quick proof of concept:
Add-Type @'
    using System;
    using System.Management.Automation;

    [Cmdlet("Start", "Process", DefaultParameterSetName = "ArgString")]
    public class StartProcessCommand : PSCmdlet {

        [Parameter(Position = 0)]
        public string FilePath { get; set; }

        [Parameter(ParameterSetName = "ArgArray", Position = 1)]
        [Alias("Arga")]
        public string[] ArgumentArray { get; set; }

        [Parameter(ParameterSetName = "ArgString", Position = 1)]
        [Alias("Args", "ArgumentList")]
        public string ArgumentString { get; set; }

        protected override void ProcessRecord() {
          WriteObject(ParameterSetName);
        }
    }
'@ -PassThru | % Assembly | Import-Module

Typing Start-Process foo -a<tab> then cycles through the parameters in the following order:
-ArgumentArray, -Arga, -ArgumentString, -Args,  and  -ArgumentList

@PowerShell/powershell-committee need to review a new proposed parameter to accept an array of args passed as an array of args

@PowerShell/powershell-committee reviewed this, we would prefer to have a switch rather than a new parameter that changes the behavior to -ArgumentList rather than cause confusion to users between -ArgumentList vs -ArgumentArray.  However, we couldn't come up with a good switch name to describe the behavior to the user without being overly verbose so open to any suggestions.

New behavior is a preferred behavior so the new switch looks like an extra parameter in scripts.
How are we going to get rid of it after the transition period? Maybe revert the switch logic? For backward compatibility users could add the switch.
Although I would just prefer the new parameter ArgumentArray. I don't think that it will confuse users if we explicitly say in helps that user should use ArgumentArray instead of ArgumentList.

The path through a new parameter rather than a switch seems clearer to me:

Add a new parameter ArgumentArray (or Arguments, or whatever) with a separate parameter set
Positional binding continues to be the old parameter
In a later PowerShell version we make the breaking change to make the positional argument refer to the new parameter

I also think that a new switch is the wrong way to go.
Note that the feared name confusion could be minimized based on the above proposal: rename -ArgumentList to -ArgumentString and make -ArgumentList an alias for it, for programmatic backward compatibility.
With the renamed parameter, the syntax diagram would then only show -ArgumentString, which can be documented as such.

The new parameter thing sounda good to me. Adding it to my PR to reduce the scope of that experimental switch.

I do not think that many scripts will break, since if it does not work, nobody would do it. If you where fixing it 3 years ago, now nobody would care about it, since Window 10 probably would by default use this version.

There are ways:

use a environment variable to opt out the new behavior
add workaround by checking first or in whole string that 2 characters are "  then use old behavior

Anyway I am for a break. If this break where already 3 years in past, probably nobody would complain now.
Thanks for you tip, but I need to elevate the process.

The underlying issue here has been improved somewhat in Powershell 7.2 by the experimental PSNativeCommandArgumentPassing feature, which makes the & command preserve quoting.
Unfortunately it does not affect Start-Process, which retains its -ArgumentList string-splatting.
It's a real shame that Start-Process was not updated along with & to respect $PSNativeCommandArgumentPassing. Example:
#!pwsh
#Requires -Version 7.0.0
Set-StrictMode -version 3
$ErrorActionPreference = "Stop"
$VerbosePreference = "Continue"

# Make sure sane command passing is available, force shell restart if not
if (-Not (Get-ExperimentalFeature -Name PSNativeCommandArgumentPassing).Enabled) {
        Write-Error "run `"Enable-ExperimentalFeature -Name PSNativeCommandArgumentPassing`" and retry"
        exit 1
}

# Make "&" preserve quoting (but not unfortunately StartProcess -ArgumentList)
$PSNativeCommandArgumentPassing = "Standard"

# Works but we have to enable an experimental feature first, and it doesn't
# seem to be possible to enable it within the same shell that uses it...
Write-Output "& with PSNativeCommandArgumentPassing=Standard"
&"printf" "%s\n" "arg1" "arg2 with spaces" "arg3 `"with quotes`" in it" "arg4 `${metachars:?shellexec} embedded"

# Still doesn't work. Sigh.
Write-Output "`nStart-Process -ArgumentList"
Start-Process -FilePath "printf" -ArgumentList @("%s\n", "arg1", "arg2 with spaces", "arg3 `"with quotes`" in it", "arg4 `${metachars:?shellexec} embedded") -Wait -Passthru

confirmed I tried 20 variations of this
start-process powershell -ArgumentList "`"C:\Users\jredfox\Desktop\script s.ps1`""

also calling it straight from java with powershell.exe /c needing to specify which exe to process the command the rest works in the powershell UI but not from java. if you were able to get the same characters from cmd you could also reproduce. powershell is broken for the start-process and maybe in general
		ProcessBuilder pb = new ProcessBuilder(new String[]
				{
						"powershell",
						"/c",
						"start-process",
						"powershell",
						"-ArgumentList",
						"'-File',",
						"'\"C:/Users/jredfox/Desktop/spacing test.ps1\"',",
						"'-ExecutionPolicy',",
						"'Bypass'",
						"-NoNewWindow"
				}).inheritIO();
		Process p = pb.start();
		while(p.isAlive());
		for(String s : pb.command())
			System.out.print(s + " ");
			```

@jredfox The backstory here is that Windows itself has absolutely insane command-line handling. See this classic 2011 blog, which still describes the state of the art for the Win32 API: https://docs.microsoft.com/en-us/archive/blogs/twistylittlepassagesallalike/everyone-quotes-command-line-arguments-the-wrong-way
This makes it very hard for Powershell to do the right thing in a general purpose way, so they just punted on the problem entirely, like the underlying .NET process creation calls did.
The pwsh 7.2 experimental feature I linked to above improves this for "bare" command invocation and for the "&" operator, but has no effect on Start-Process, so you cannot benefit from it in places where you want the control offered by Start-Process.

Late to the party but the presented workarounds didn't work for me, so here's mine.
I wanted to execute a ps1 with spaces in its name as an administrator. What ultimately worked was to

write the argument list as a single string with all parameters
wrap the script name with double quotes
wrap the parameter string with single quotes and parantheses

Start-Process -Verb runAs pwsh -ArgumentList ('-NoExit "path/to/my script with spaces.ps1"')

Needless to say it is very unsatisfying that after many years and major versions this issue has not been solved.

@igorakkerman I agree. I understand that Powershell cannot handle every insane command-line argument parsing implementation that Windows programs may concoct, but there are only three argument parsing models that really matter:

MSVC runtime CommandLineToArgV parsing or compatible implementations from other C runtimes - this will cover 99% of cases on Windows since almost every C, C++, or .NET (C# etc) program uses this; and
cmd.exe's wacky command parsing with %-- and similar magic; this matters since one shell invoking another is going to be important for powershell users; and
Every non-windows OS, in which Powershell can just execv() the process for perfectly reliable, straight-forward argument vector processing that works perfectly for every kind of process

So long as Powershell retains a way to compose a CreateProcessEx raw argument string for weird corner cases like commands with their own custom argument parsers, it can meet all requirements. If it had some kind of -ArgumentQuotingStyle PlatformDefault option that'd cover 99% of uses with absolutely no fuss.
Handwaving it away with the argument that argument quoting and escaping is too hard is ... unfortunate. Python's shlex and subprocess modules handle it just fine. It's inconvenient and annoying but not fundamentally a hard problem, and the fact that PowerShell leaves this up to its individual users to work around made me give up on it completely for my automation needs.

@PowerShell/wg-powershell-cmdlets discussed this issue and have decided to take a look at this problem more generally on how to have vNext versions of cmdlets that addresses known issues without breaking existing usage or continuing to add unnecessary complexity to the cmdlet syntax to bridge both worlds.  We discussed the PSResourceGet case where it was a renamed module with renamed cmdlets so that it works side-by-side and considering if that is the pattern we should apply generally as a way to get to a more ideal case.

I created https://github.com/orgs/PowerShell/discussions/21089 to discuss this broader topic


Why is the database on a public subnet?

According to the diagram in the readme the database is exposed on a public subnet, why is this? Wouldn't it be better to have it on a private network?

My understanding is that it has been always the case, and being addressed by the Virtual Network Service Endpoints. It wasn't available on the region I wanted with Azure SQL when I needed earlier, but it seems like at least Azure SQL is available as preview for this feature in all regions. Not sure when MySQL & Postgres will be supported.

OK, so it's a "feature" not a "bug" I'll change the labels and drop to P1 as it seems we can't do anything about it right now.

Still, I think the template should be enhanced so that the database endpoint IP is not exposed to world (<IP_ADDRESS>-<IP_ADDRESS>), which is the current DB firewall setting. I'm not sure, though, how easy it would be to pass the obtained public IP of the load balancer to the firewall rule.

This was closed due to a commit message that said it "partially fixes", so re-opening.
@hosung having "fixes #issue_number" in a commit message will close the issue, so if it is a partial fix you need a different note (e.g. "applies to #" or something similar)

OK, so it's not a "partial fix"? I only re-opened because of the word "partial". Happy to close again.

I said it's "partial" in that the issue statement is "Why the database is on a public subnet?" and this fix doesn't move the DB to the private vnet using the Azure vnet service endpoints feature (which is not available for Azure MySQL/PostgreSQL for now). It still configures the DB on an Azure public IP (we really don't have a separate public subnet in our deployment), but all access to the DB is rejected except for our 2 public IP addresses (from the VMSS load balancer and the controller VM).

VNET Service endpoints for MySQL and PostgreSQL are now in preview - https://azure.microsoft.com/en-us/blog/vnet-service-endpoints-for-azure-database-services-for-mysql-and-postgresql-in-preview/
Should we reopen this issue? Think it might be a good one for the community to address.

@hosungsmsft  Just an FYI - VNet Service endpoints are now GA in case this work is still planned. Currently there is no open issue for this in case we want to reopen this.


Bug: Annotations for nested types are ignored

Description
When a pydantic model contains a simple annotated attribute, the restrictions from the annotation are used for generating the value.
Example:
Dimension = Annotated[int, Field(gt=1000, lt=2000)]

class Item(BaseModel):
    x: Dimension

class ItemFactory(ModelFactory):
    __model__ = Item

print(ItemFactory.build())

>>> x=1456

However, if I change the Item model to
class Item(BaseModel):
    dimensions: list[Dimension]

I get the following error saying that polyfactory generated the value 8569
>>>
pydantic_core._pydantic_core.ValidationError: 1 validation error for Item
dimensions.0
  Input should be less than 2000 [type=less_than, input_value=8569, input_type=int]
    For further information visit https://errors.pydantic.dev/2.4/v/less_than

URL to code causing the issue
No response
MCVE
from polyfactory.factories.pydantic_factory import ModelFactory
from typing import Annotated
from pydantic import BaseModel, Field

Dimension = Annotated[int, Field(gt=1000, lt=2000)]

class Item(BaseModel):
    dimensions: list[Dimension]

class ItemFactory(ModelFactory):
    __model__ = Item

print(ItemFactory.build())

Steps to reproduce
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots
"In the format of: ![SCREENSHOT_DESCRIPTION](SCREENSHOT_LINK.png)"
Logs
No response
Release Version
2.11.0
Platform

[X] Linux
[ ] Mac
[ ] Windows
[ ] Other (Please specify in the description above)

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh Litestar dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

@kabell thanks for reporting this :)
I am able to reproduce this but haven't gotten a chance to look into it in detail yet.


#1007 v0.8.9_12: ‘Constant’ option is truncated in landscape view new

I have quicker solution. Please, check it and choose better solution for you)))

closer, but need to be generic, not only in small profile. see 9c2194c7907a3b13a927fcc94c7b999f59a476ae


Show full domain to add TXT for in handle update modal

When setting a custom domain handle, the ”well-known” method tab updates with the domain name you enter which makes the instructions very clear. But for the DNS method tab, it just says to add a TXT for ”_atproto” regardless of what you typed in the handle field. I think it would be more user-friendly and clear to display the full domain name in the instructions. It would reduce confusion especially when setting a subdomain handle. Essentially, it’s probably clearer to say add this TXT record for ”_atproto.my.domain.com” than just ”_atproto”.

@alimony That is originally what we did but people would frequently copy the value as given into their settings panel, leading them to register _atproto.bob.com.bob.com instead of _atproto.bob.com. I've received far fewer support requests since making this change.

Interesting piece of real-world data! Maybe updating the paragraph above it to be more explicit could help:

Maybe also add a link in there somewhere to the documentation on custom handles, which also someone said isn't super clear on subdomains.

Proposing this in a PR, we'll see if it passes review:


Adding redis setup docs for running marqo locally

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
updated readme with redis setup

What is the current behavior? (You can also link to an open issue here)
no current explanation for setting up redis baremetal

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)

unit tests passed: https://github.com/marqo-ai/marqo/actions/runs/4321253053

trying unit tests: https://github.com/marqo-ai/marqo/actions/runs/4446323440/jobs/7806539562#step:8:5071

passed unit tests: https://github.com/marqo-ai/marqo/actions/runs/4446952956
ready for merge


[FEATURE]  Add support for CSGO (Skinport) API connection

Is your feature request related to a problem? Please describe.
I find it difficult to efficiently access and utilize CSGO skin and case data from the Skinport API when using this library. This limitation hinders the development of applications that involve CSGO skins and cases, such as marketplaces, inventory management tools, or case opening simulators.
Describe the solution you'd like
I would like to see a dedicated module in this library that facilitates easy connection to the CSGO Skinport API and allows retrieval of various types of data, such as skin details, case contents, and market prices. This would streamline the process of building applications that rely on this data and save developers considerable time and effort.
Describe alternatives you've considered
An alternative solution would be to develop a separate package specifically designed for handling CSGO Skinport API connections and integrating with this library. This would enable developers to leverage the existing functionality of the library while also benefiting from the additional features provided by the new package.
Additional context
CSGO skins and cases are an integral part of the game's economy and have a massive player-driven market. By supporting the CSGO Skinport API connection, this library could significantly expand its potential audience and use cases, catering to the needs of developers working on applications related to CSGO skins and cases.

Not needed anymore. If someone would like to have such feature, feel free to open that issue again.


conversion from 'SQLite::Column' to 'const short unsigned int' is ambiguous

Actually every unsigned integral except unsigned int when one tres to do uintXX_t result = statement.getColumn(0), but the solution that works is just being explicit - uintXX_t result = statement.getColumn(0).getInt().

Implemented with #179 a few hours ago :)


Solver not using new crafting abilities.

The solver isn't using the new crafting abilties of
Immaculate Mend - Restores all item durability for 112cp
Trained Perfection - Reduces durability loss of next action to 0. Once per synthesis for 0cp
Refined Touch - Increases quality 100% efficiency 100% success. combo action basic touch. Increases Inner Quiet stack by one for 24cp
I don't know if these are or are not programmed in but here they are if they are not.

I haven't put them into the solvers yet because it's still early and I want to see where people go with their usages. They will come in time.


Where do I safely store the New Relic License Key when connecting a DAPR sidecar to New Relic?

The documentation shows to embed the Key in the URL.  But the Key is a secret and I'd prefer not to put it in the configuration file.
Is there any way to do this?

Can I reference a secret store and embed a secret in the URL?
Can I add a header name and value under zipkin and reference a secret store?

New Relic accepts the querystring parameters as headers

What the documentation shows (for reference):
apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
  name: appconfig
  namespace: default
spec:
  tracing:
    samplingRate: "1"
    zipkin:
      endpointAddress: "https://trace-api.newrelic.com/trace/v1?Api-Key=<NR-INSIGHTS-INSERT-API-KEY>&Data-Format=zipkin&Data-Format-Version=2"

What I would suggest - since New Relic accepts the querystring parameters as headers:
apiVersion: dapr.io/v1alpha1
kind: Configuration
metadata:
  name: appconfig
  namespace: default
spec:
  tracing:
    samplingRate: "1"
    zipkin:
      endpointAddress: "https://trace-api.newrelic.com/trace/v1"
      headers:
      - name: Data-Format
        value: zipkin
      - name: Data-Format-Version
        value: 2
      - name: Api-Key
        secretKeyRef:
          name: NEW_RELIC_LICENSE_KEY
          key: NEW_RELIC_LICENSE_KEY
auth:
  secretStore: app-secrets

Sorry.  Posted to the wrong repo.


Rename "list" -> "show"; single selection shows more information.

However, ls is such a nice alias :)
Could keep it as an alias to show, I suppose...

Having both show and list does feel quite ambiguous.
Suggest renaming list -> show, adding aliases list, and ls and if a single series id is specified as argument show detailed information about that series (like overview, cast, director/writer etc).

Showing details implemented in 01afed150c21733499683e025ab1182722cb680e


[twitch:vod] youtube-dl doesn't show "source" in the format list. It's important for 720/30 recorded videos.

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Description of your issue, suggested solution and other information
I've included two outputs below. The first url is a video recorded in 720p at 30 frames. The second url is 900p at 60 frames. Both don't include the "source" label in the format list. In the second url, you know that the source is 900p because twitch doesn't re-encode to that resolution. The problem for me is the first url because I can't know what is the source, 720p-0 or 720p-1. I've seen other urls with both formats within the range of 2200-2300k/s (and avc1.4D401F), so even the bitrate is not really helping to know what is the source.
For both videos, the twitch web shows the source in the list of format. So, my request is to include a "source" label in the format list, like you're doing for live streams.
$ youtube-dl -v -F 'https://www.twitch.tv/videos/378760727'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.twitch.tv/videos/378760727']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.02.08
[debug] Python version 3.7.2 (CPython) - Linux-4.19.20
[debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[twitch:vod] 378760727: Downloading vod info JSON
[twitch:vod] 378760727: Downloading vod access token
[twitch:vod] 378760727: Downloading m3u8 information
[info] Available formats for v378760727:
format code  extension  resolution note
Audio_Only   mp4        audio only  203k , mp4a.40.2
160p         mp4        284x160     284k , avc1.4D400C, mp4a.40.2
360p         mp4        640x360     700k , avc1.4D401E, mp4a.40.2
480p         mp4        852x480    1418k , avc1.4D401E, mp4a.40.2
720p-0       mp4        1280x720   2213k , avc1.4D401F, mp4a.40.2
720p-1       mp4        1280x720   2778k , avc1.64001F, mp4a.40.2 (best)
$ youtube-dl -v -F 'https://www.twitch.tv/videos/378524093'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-F', 'https://www.twitch.tv/videos/378524093']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.02.08
[debug] Python version 3.7.2 (CPython) - Linux-4.19.20
[debug] exe versions: ffmpeg 4.1.1, ffprobe 4.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[twitch:vod] 378524093: Downloading vod info JSON
[twitch:vod] 378524093: Downloading vod access token
[twitch:vod] 378524093: Downloading m3u8 information
[info] Available formats for v378524093:
format code  extension  resolution note
Audio_Only   mp4        audio only  215k , mp4a.40.2
160p         mp4        284x160     284k , avc1.4D400C, mp4a.40.2
360p         mp4        640x360     693k , avc1.4D401E, mp4a.40.2
480p         mp4        852x480    1406k , avc1.4D401E, mp4a.40.2
720p         mp4        1280x720   2204k , avc1.4D401F, mp4a.40.2
720p60       mp4        1280x720   3099k , avc1.4D401F, mp4a.40.2
900p60       mp4        1600x900   7426k , avc1.64002A, mp4a.40.2 (best)

@dstftw Many thanks for the quick fix. Wouldn't it better to use the format id for the "source" label, instead of the note field?. Mostly, for consistency with the live streams. This is the output from a live stream:
$ youtube-dl -F 'https://www.twitch.tv/ryux'
[twitch:stream] ryux: Downloading stream JSON
[twitch:stream] ryux: Downloading channel access token
[twitch:stream] ryux: Downloading m3u8 information
[info] Available formats for<PHONE_NUMBER>6:
format code      extension  resolution note
audio_only       mp4        audio only   13k , mp4a.40.2
160p             mp4        284x160     230k , avc1.4D401F, mp4a.40.2
360p             mp4        640x360     630k , avc1.4D401F, mp4a.40.2
480p             mp4        852x480    1274k , avc1.4D401F, mp4a.40.2
720p             mp4        1280x720   2219k , avc1.4D401F, mp4a.40.2
720p60           mp4        1280x720   3269k , avc1.4D401F, mp4a.40.2
720p60__source_  mp4        1280x720   6555k , avc1.4D4020, mp4a.40.2 (best)


Logger and unused variable

Two simple changes

Can one of the admins please verify this patch?

Thanks @otradovec ! Merging and adding you to the game credits :-)

THX from Czech Republic :)


Remove todo from script

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/derekbekoe/azure-cli-extensions.git@remove-todo#subdirectory=src/$EXT&egg=$EXT"


Getting Lat, and Long

Hi @vskosp, Thank for the great plugin.
However I have a small problem with accessing the lat, long of the autofill place.
HTML

     Address
     <input vs-google-autocomplete
         ng-model="hotelAddress.Address"
         vs-place="hotelAddress.Place"
         vs-latitude="hotelAddress.components.location.lat"
         vs-longitude="hotelAddress.components.location.long"

         type="text"
         class="form-control input-sm"
         name="address"
         id="address"
         placeholder="address">

JS
$scope.addLocation = function (hoteladdress) {
    $scope.Obj = {
        Name              : hoteladdress.Name,
        Address           : hoteladdress.Address,
        Zones_id          : hoteladdress.Zone.id,
        City_id           : hoteladdress.City.id,
        LocationsType_id  : hoteladdress.LocationType.id,
        Latitude          : hoteladdress.Place.geometry,
      };
      console.log($scope.Obj);
}

So as you can see I lat and lng are undefined and give me a function (). Do you have idea why is not working? Thank you in advance

Maybe related to https://github.com/wpalahnuk/ngAutocomplete/issues/62

Hi @Hirbod
Thanks for your comment.
The link actually worked.
Here is a before and after of my Object
Before
$scope.Obj = {
  #####
  Latitude          : hoteladdress.Place.geometry.location.lat,
  Longitude          : hoteladdress.Place.geometry.location.lng,
};

After
$scope.Obj = {
    ####
    Latitude          : hoteladdress.Place.geometry.location.lat(),
    Longitude          : hoteladdress.Place.geometry.location.lng(),
};

The main diff is that lat and lng is invoked as a mothonds lat() / lng() rather that a properties :boom:


Encoding Device

Hi, thanks for sharing your work and the great resource!
When I was encoding samples I found that regardless of whether I explicitly set device to "cuda" or not, when calling encode(...), the output embeddings would be on "cpu". I believe this line causes this, since it will always return embeddings on "cpu" rather than the given/default device we would expect.

Hi @sramshetty,
Thank you for your interest in our work. This is done intentionally as for large datasets, incrementally storing embedding on GPU can cause OOM problems. Does your use case require the embeddings to be on GPU?

I see, that makes sense and I was able to work around it to get embeddings on the GPU. Thanks!


current-bench backend

This PR aims to be an MVP of current-bench backend.
It's goal is to be used to be a main workhorse of make bench command.
Example make bench implementation (a benchmark "script" that will be run by current-bench infra):

Checkout specific repository for which merlin will be benchmarked (e.g. Irmin)
Run merl-an bench on selected files from this repository.
Example command: merl-an benchmark -p irmin-repo-path1/some_file.ml,irmin-repo-path2/another_file.ml --data=test-data-dir
will run merlin benchmark in files irmin-repo-path1/some_file.ml and irmin/repoh-path2/another_file.ml and save results in test-data-dir directory. It will consists of bench.json file and some log files.
bench.json is already formatted according to current-bench schema, so we need to print it to stdout and we're done :)

It seems that macOS CI build fails with
@@ -1,25 +1,22 @@
   $ merl-an -r 1 -s 1 -p perf.ml --data=test-data
+  bind: File exists
+  merlin path: /Users/runner/work/merl-an/merl-an/_opam/bin/ocamlmerlin-server
+  socket path: /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/build_c5aa22_dune/ocamlmerlin_501_16777220_12896532392.socket
+  merl-an: internal error, uncaught exception:
+           Failure("exception while running [ocamlmerlin server -version]: End_of_file\n")
+
+  [125]


20.5

Docs Build status updates of commit 48142bb:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 48142bbf018957a373143ff9a695d4d4ae3f8e3b in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5846409:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit<PHONE_NUMBER>4ffa18e0edfc8244135d924b38b77b in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cf73698:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit cf7369872da183f06cb754ea2e0f430956cf8a4f in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 18b6b26:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 18b6b26a4c2f511b19ac46ca983870613fb1a2a8 in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 657276e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 657276ee22b762e71743759568a98f59a9aa9eda in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit b3034e7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit b3034e7ff79764373dc5e560dcdd61168af1a4ca in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2f77fa3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 2f77fa3e4c98ac3477e9946a2dafcec258a37f3a in branch main of repository https://github.com/a-emniel/dynamics365smb-devitpro-pb into branch main (commit 664096e20f4d9357da16e17dcb0ecf85b398817c). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Fixing this on the internal pipeline.


fix(Dropdown): fix compatibility with IE

Fixes #1315.

Codecov Report

Merging #1667 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   99.75%   99.75%   +<.01%
==========================================
  Files         141      141
  Lines        2408     2410       +2
==========================================
+ Hits         2402     2404       +2
  Misses          6        6

Impacted Files
Coverage Δ

src/modules/Dropdown/Dropdown.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e8870...0e5191f. Read the comment docs.

@cattermo does this PR resolve your issue?

It works!
Sorry for the delay, I thought I could npm install the branch from github directly but couldn't get it to work (corporate firewall...). Ended up copypasting the new code right into node_modules which proved working fine for testing purpuse.

Thanks for the testing and report @cattermo.

Released in<EMAIL_ADDRESS>


Is Mortar-architect need RE-inflate view when screen go back?

@lukaspili I know Mortar-architect offer a "Navigator" to solve the problem, "recreate scope everytime when screen changed".
But Is view RE-inflate when screen go back?
If that so:
when my app have a "heavy"-main screen,  it will be a unnessary re-inflate progress.
So my question is "Is there any way to make view stackable?"

Not in the 0.x version, but it's something I'm currently investigating for the architect 1.0 release. It will be either as an extension module or as a separated library independent from Architect.
Give me 1 week and I'll have more to say on the matter :)

Great! I look forward to hearing from you.

Is it possible to know that a view has been Re-inflated from a back press?


Creating common storage for provision and web_ui containers

@Shubhangi-dell your commits are missing the DCO signoff (https://github.com/dellhpc/omnia/pull/146/checks?check_run_id=1389956721)
Please be sure you signoff all commits by using the --signoff
You can fix the current PR by following the instructions at the link above.


Metadata in instructions is for DA-100 instead of PL-300

The metadata is in the beginning of the lab Markdown and is used by some ALHs to present the Markdown to the students.
Example from the last lab:

This is actually Module 12 in PL-300.

This issue has been addressed.


Create iescamas.txt

@fernandopal Pull request merged. Thank you!

Shouldnt it work now? or it takes a bit of time/i need to do something more

@philipto

Shouldnt it work now? or it takes a bit of time/i need to do something more

Please wait a little bit, it usually takes about an hour to propagate all the changes. Thank you!

On 6. May 2021, at 23.36, fernandopal @.***> wrote:

@philipto
Shouldnt it work now? or it takes a bit of time/i need to do something more
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


New version: jendrikseipp.RedNotebook version 2.34

Pull request has been created with WinGet Updater :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:
(Automated response - build 895.)


adding syslog processor

Hey, @Jeffail , I have a little something for benthos.
I used github.com/influxdata/go-syslog  to parse a message and I decided to implement just rfc5424  support. Shouldn't be a real problem to include another rfc under processor's wing but it is quite good for a starter. I am diabolically sad that rfc3164 (one of the popular) can't be parsed because the library hasn't implemented it yet, but then again I can't hold a grudge for longer than a few minutes, so..
I think, there is no need to provide functionality via config letting users not to create some of final JSON structure (not all of us need those field and those might be better off in the metadata), but every use case is unique and it's not fair to throw everyone in the same barrel, especially if it's limited space inside. So, overall, it should be easy to unset some of those JSON fields afterwards.
I also used bestEffort option which implies processor won't crash during the parsing if there would be some problem in an original message as long as it is bound, in a certain degree, to rfc.

Hey @DpoBoceka, I'm not opposed to adding this in but have you tried using grok for this same purpose? Would be good to get a performance comparison, unless there's a significant gain from using this I'd rather strengthen the docs around grok than add another processor.

I haven't tried grok, I dislike it for some reason. Isn't it going to be a bit painful to describe in grok every case out there (some fields can be omitted, timestamp can be formed differently, etc)? I'm really not sure if I can manage to write all these groks. Well, I guess that PR is going to hold on for some time

However, how would you in general describe a proper benchmark in that case?

Wow yeah, I spent a bit of time trying to get this working with grok and regret it. I'm going to think this one over for a few days as it'd be nice to make this processor a little more generic.

Thank god, I've spent an hour and a half to gather some evidence to prove that it's better not to use grok in that case. And it wasn't delightful.
As for making it more generic, I, then, would love to remake it in such a way as long as I find some time and my limited skills won't go in a way.

Let's have a check list with things that need to be done in order to merge it. After all, syslog is a cornerstone transport for some use cases and we should cover that, I think

Let's add this as a generic parser, steps should be:

Come up with a good name (convert_log, parse_log, process_log)
Create general processor with name

Has an output codec field (default json for now)
Has a format field (syslog)

I think it's reasonable for now to have a static output format based on the chosen input format, if the fields aren't what the user wants they can choose to mutate it however they like. We can always revisit later on with new fields.

so current xml processor should be covered with that new processor, shouldn't it?

Potentially, but let's leave xml where it is for now. There's always the possibility of expanding it in the future to support some of the same operations as json.

Just noticed that I need to remove some tails of old "syslog processor"  from config/env/* files, I'll make another commit for it

Ace, thanks @DpoBoceka!


[RFC] Add Debugging Support

How do you envision this feature/change to look/work like?

Unified Debugging Interface
Introduce a unified debugging interface within the browser extension development framework, providing developers with a single entry point for accessing debugging features across different components of the extension (e.g., background scripts, content scripts, popup windows).

Debugging Tools Integration
Integrate popular debugging tools (e.g., Chrome DevTools, Firefox Developer Tools) directly into the development framework, allowing developers to leverage familiar debugging capabilities seamlessly.

Remote Debugging Support
Enable remote debugging for browser extensions, allowing developers to debug extensions running on remote devices or instances of the browser. This feature is particularly useful for testing and debugging extensions across different environments and devices.

Real-time Logging and Inspection
Implement real-time logging and inspection capabilities within the development framework, enabling developers to monitor extension behavior, inspect variables, and track the flow of execution in real-time.

Error Reporting and Analysis
Enhance error reporting and analysis features, providing developers with actionable insights into runtime errors, exceptions, and warnings encountered during extension execution. This includes detailed error messages, stack traces, and contextual information to aid in debugging.

Cross-Browser Compatibility
Ensure compatibility with major web browsers (e.g., Chrome, Firefox, Edge) to support cross-browser extension development. Debugging features should be consistent and accessible across different browser environments.

What is the purpose of this change/feature? Why?
Debugging is a critical aspect of software development, allowing developers to identify and resolve issues efficiently. However, debugging browser extensions can be challenging due to the distributed nature of their execution environment. This RFC proposes enhancements to the browser extension development framework to streamline the debugging process, enabling developers to more effectively diagnose and fix issues in their extensions.
(OPTIONAL) Example implementations
No response
(OPTIONAL) Contribution

[X] I would like to contribute to this RFC via a PR

Verify canary release

[X] I verified that the issue exists in plasmo canary release

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

+1


Read thread ID inside a test

Clear and concise description of the problem
Our tests rely on a shared database connection, with --no-isolate and --no-threads as they may have side effects.
To speed it up, we want to run them in parallel, setting up multiple databases, one for each vitest thread.
Suggested solution
A field inside ctx.task that identifies the thread ID, so we can choose a different database.
Alternative
Run tests with --shard and use an environment variable for each shard.
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

There are already two variables:
https://vitest.dev/guide/migration.html#envs

VITEST_WORKER_ID is incremented for every new worker spawned
VITEST_POOL_ID is the number of worker (>= minWorkers && <=maxWorkers)


[Feature Request] repo issue view filter by author

on a repo issue view add option to sort by author

What's the meaning to sort by author?

filter by author

@lunny filter by author

pull is here  - but need some more work ...


Issue 37: Read warnings data from BoM

This PR addresses requests to support BoM warnings (see Issue #37).
Data is collected from the BoM warnings API.
This data may be made available through an additional warnings sensor which can be used in scripts and automations. New or updated lovelace cards would be required to display this data.
The state of the sensor is the number of warnings and the warnings data is stored as a list in the "warnings" attribute of the sensor.
sensor.melbourne_forecast_warnings:
- state: 1
- Attributes:
      response_timestamp: 2022-05-16T13:03:47Z
      copyright: This Application Programming Interface (API) is owned by the Bureau of Meteorology (Bureau).
          You must not use, copy or share this API without express permission from the Bureau. Please contact us for more
          information. Follow this link http://www.bom.gov.au/inside/contacts.shtml to view our contact details.
      attribution: Data provided by the Australian Bureau of Meteorology
      warnings:
      - id: VIC_MW005_IDV20600
        type: marine_wind_warning
        title: Marine Wind Warning for Victoria
        short_title: Marine Wind Warning
        state: VIC
        warning_group_type: minor
        issue_time: '2022-05-16T12:00:00Z'
        expiry_time: '2022-05-16T19:00:00Z'
        phase: cancelled
      friendly_name: Melbourne Forecast Warnings

Can someone tell me pls how to add this optional warning sensor?

Can someone tell me pls how to add this optional warning sensor?

There is an example of a template sensor by StormyKnight17 on the Issues page, which is where most of the useful dicussion happened: https://github.com/bremor/bureau_of_meteorology/issues/37#issuecomment-1129490916.

There is an example of a template sensor by StormyKnight17 on the Issues page, which is where most of the useful dicussion happened

Thanks, this seems to be used once I see this sensor but I simply don't have it. I bet I need to enable it but was unable to figure out how. All the rest works since ages ago.

Reaching into my memory here...I believe you need to enable the warning sensor in the integration config.

Sounds good but where is this config?

You can either temove the integration and re add it or you can reconfigure it. Its got a menu on the integrations page for it


Improved Validations in Resource-Deployment

This PR fixes #

needed this to be a draft PR

@ranasaria FYI you can convert existing PRs into draft PRs and vice versa :


NGINX errors in docker - unable to access GUI

Sorry, it's I again.  A new update was pulled down.  No longer able to access the new HDHomeRun WebGUI any longer since the new update and I am seeing these errors in the docker container logs:
2022-08-01 14:33:42,751 INFO exited: nginx (exit status 1; not expected)
2022-08-01 14:33:45,757 INFO spawned: 'nginx' with pid 54
2022/08/01 14:33:45 [emerg] 54#54: getpwnam("dvr") failed in /etc/nginx/nginx.conf:4
nginx: [emerg] getpwnam("dvr") failed in /etc/nginx/nginx.conf:4
2022-08-01 14:33:45,787 INFO exited: nginx (exit status 1; not expected)
2022-08-01 14:33:46,789 INFO gave up: nginx entered FATAL state, too many start retries too quickly

I'm not sure if this is an "UnRaid specific" issue as it was the last time with the Port:80 issue.  Just wanted to make you aware.

I suspect this is from an update
try removing all but dvr.conf in your /dvrdata volume
I think you need to clear out the old http/php folders in particular so we can rebuild them

Ok. I'll be away a few days. I'll attempt this when I return and let you
know.
On Tue, Aug 2, 2022, 11:26 Rik Dunphy @.***> wrote:

I suspect this is from an update
try removing all but dvr.conf in your /dvrdata volume
I think you need to clear out the old http/php folders in particular so we
can rebuild them
—
Reply to this email directly, view it on GitHub
https://github.com/demonrik/HDHR-DVR-docker/issues/3#issuecomment-1202821320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENXKGCQNWZ4OLP6MSUBFXTVXE437ANCNFSM55LR3HWQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Wow.    ;)
Deleting all the folders (minus the TV show recordings) and all the extra log files after stopping the container worked like a charm.  I'm able to access the WebGUI again and no errors in the log.
Another issue you can now close

I suspect this is from an update try removing all but dvr.conf in your /dvrdata volume I think you need to clear out the old http/php folders in particular so we can rebuild them

Glad it fixed your issues.
Yeah - I have to apologize over the permissions and conf files thing.. I went one way, then reversed course which resulted in this pain. Should be stable going forward (fingers crossed)

Don't worry, if something else goes wrong I'll be sure to point it out.  ;)


Minimap interferes with Word Wrap

Issue Type: Bug
When both Miniimap & Word Wrap are enabled, there's a horizontal scroll bar that shouldn't be there. Typing enough at the end of a line to cause wrapping first results in scrolling to the right, and when the line does wrap and indent, the scroll does not return completely to the left.

Also is this issue reproducible in insiders build https://code.visualstudio.com/insiders/?

@af4jm Please try "editor.wrappingStrategy": "advanced". Our default wrapping algorithm assumes that all characters are equal in width, while this "advanced" one uses real DOM measurements. This will be slower, but should be more accurate.

so ran with that setting today & only noticed the horizontal scroll once, and it was less than 1 character width instead of the normal 2 characters, which is much better...
BUT switching wrappingStrategy from simple to advanced also forced wrappingIndent to behave as if it's set to same, ignoring whatever it's actually set to

Yes, that is a limitation unfortunately caused by the advanced implementation. The advanced implementation delegates wrapping computation to the browser. It does so by rendering all lines with the editor width and then uses binary search to locate where the DOM has introduced wrapping points.
Unfortunately, the browser has no equivalent CSS styling to our "wrappingIndent": "indent" or "deepIndent" so it is not possible to ask the browser to wrap with those settings.


Basic Elements of Falco Rules

Hi,
I have an issue with this documentation section:
https://falco.org/docs/rules/basic-elements/#conditions
Under the example code there is this following paragraph:
"The first clause checks that the event happened in a container (where container.id is equal to "host" if the event happened on a regular host). The second clause checks that the process name is bash."
The problem is that container.id is NOT equal to "host" in the example code.
Regards,
Hamza Masood

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten


Guild compare saving to csv file throws error

In the newest release 0.6.6, the command guild compare --csv > RUNS.csv from the docs throws the error guild: --csv option requires an argument.
Changing the command to guild compare --csv RUNS.csv and thereby providing the filename to the option returns the error TypeError: a bytes-like object is required, not 'str'.
For reproducing this error, I used the code from the Quick Start. Guild has been installed via pip on python 3.7.
Note: After checking the changes between 0.6.5 and 0.6.6, I tried executing guild compare --csv - > RUNS.csv. This works like a charm! :)
Thank you for the amazing work you did by developing this package!

Thank you! We'll get this one fixed for the next release (0.7).

Hi, I just stumbled across the same problem.
Will
guild compare --csv - > RUNS.csv be the suggested workaround or will you go for the guild compare --csv RUNS.csv option?

To generate the CSV file, I suggest running:
guild compare --csv RUNS.csv

The other form does the same thing but takes longer to type :)
Btw I suggest running the pre-release of 0.7 - you can install it by running pip install guildai --upgrade --pre.

Fix is available in 0.7.0. Thanks again!


UX review comments

Re: https://www.figma.com/file/w9HsmcQattO4slk9fLWjnh/Operating-system-v1?type=design&node-id=42-479&mode=design&t=jr1Omn0CFhtTCPhQ-0

Overall: looks great. really clean.

overall, looks great. really clean.

Issues

Selection is indicated by full white and a drop shadow -- does this work well on mobile -- esp. in a constrained single column?
The right-sidebar doesn't feel distinct enough from the background.


Update chart version and add new configurations

The chart version has been updated from 0.6.5 to 0.6.6 and the app version has switched to "3.0.0". New configurations for Dev mode, DSU fabric enclave type, and encryption key have been added. Instructions for "ssoSecretsEncryptionKey" and "enclaveType" values have been implemented and the maintainers detail has been removed from README.

Overwrite PR merge for pre-release candidate version 3.0.0-rc28


OCPCLOUD-2191: Update to Kube 1.28

Also update the build image to use golang 1.20

The import linting is not happy 🤔

Yeah, I let GoLand do it which doesn't match OpenShift's ordering.
I've fixed that, still debugging the termination handler failing

/retest-required


add missing connect method

solves #1

Only problem is that this only supports RBXScriptSignals, whereas it would be nice to support more generic signals, including things like my custom one (beacon), which uses camelCase methods.

I have implemented it as described in the docs. However, I do agree that supporting beacon is a good idea.


Feat/read la 11 create user account

**JIRA: https://champlainsaintlambert.atlassian.net/browse/LA-11
Context:
User can now create an account with the following form

Don't forget to make another PR for your backend tests


Add support for mappr's module dependencies

Suppose we have shared Dto which describes common data like
class CommonDto {
  final String id;
  final String name;
  ...
}

This Dto can be used acrros different dtos.  For each mappr's module where we define concrete mappings for Dtos from such module.
Expectation is that mapping "CommonDto -> CommonObject" which is defined in main mapper should be available.
There should be way to concrete "AutoMappr" either mark as "Only as module" type thus some mappr's checks will be removed OR somehow tell AutoMappr that there is "globally" available mapping.
Concrete example:
Mapping between CommonDto -> CommonObject should be defined "globally"
@AutoMappr([
 MapType<CommonDto, CommonObject>()
], modules: [
  ModuleAMappr()
])
class Mappr extends $Mappr {}

In ModuleA we have defined mapping between UserDto -> User which has dependency on CommonDto (CommonObject)
class UserDto {
  final int id;
  final CommonDto roleKey;
}

Ideally we could defined ModuleA mappr like
@AutoMappr([
 MapType<UserDto , User>()
])
class ModuleAMappr extends $ModuleAMappr {}

How to extend it ?

First - just mark it as "module"

@AutoMappr([
 MapType<UserDto , User>()
], isModule: true)
class ModuleAMappr extends $ModuleAMappr {}

This could disable some checks, etc., but not sure if it can be done this way. Needs more investegation.

Second - define "ancestors" / "dependencies"

@AutoMappr([
 MapType<UserDto , User>()
], dependsOn: [
   CommonMappr //Type, not instance of CommonMappr
])
class ModuleAMappr extends $ModuleAMappr {}

where CommonMappr should be defined as standalone mappr
@AutoMappr([
 MapType<CommonDto, CommonObject>()
])
class ComnonMappr extends $CommonMappr {}

Final global main mappr could be just
@AutoMappr([
], modules: [
  CommonMappr(),
  ModuleAMappr()
])
class Mappr extends $Mappr {}

With this approach, each automappr could proably read @AutoMappr annotation from its dependencies and check if there is existing mapping etc.
Version info

Package version : 1.4.0

I agree that having the option to use/include other auto-mapper modules can be helpful.

Implemented, will be part of v2.


[Bug]: The unlatch action should be available also when the lock is locked

Requirements

[X] I have updated Mushroom to the latest available version
[X] I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior
The Lock Card should show the Open button (unlatch action) based on the supported_features attribute of the lock, but since I migrated to Mushroom, I don't always see the second button on the card, it appears only when the lock is unlocked.
I'll show 2 screenshots where you can see the card with only 1 button and with the 2nd (I updated the template in one of them but the Lock Card is the same), the lock device is the same (Nuki). You can also see the attribute of the lock: supported_features: 1.

Expected Behavior
No response
Steps To Reproduce
No response
Context

Environment
- Browser: Chrome
- Home Assistant 2022.11.4 / Frontend 20221108.0
- Mushroom: v2.4.1

Anything else?
No response

Ok, now I understood the logic: when the door is locked, you only see the unlock button, not the unlatch one. When it's closed and unlocked, you see both action buttons.
I think this logic is not the best, because unlatch implies unlock, so you should be able to unlatch also when the door is locked. That's how it works at the API level with Nuki locks for example: you can unlatch in both unlocked/locked states.
So I don't know if this was intentional or not (if it is, this is not a bug), but I would ask if this kind of behavior could be configured via an option of the Lock Card. I also saw in another issue that someone would like the unlatch button to be optionally off.
Thanks.

Oh you can open when it's locked ? You don't have to unlock before open?

Oh you can open when it's locked ?

There are two possible actions: unlock and unlatch.
Basically the difference between unlock and unlatch actions is that the latter does a half turn more to open the door. :)

What integration do you use ?

I use a Nuki lock.

When using e.g the Nuki Opener with the nukihub integration, the lock entity uses the lock/unlock mechanism to configure ring to open. The lock.open service can always be used to really open the door, so its quite unhandy that the open action is hidden.
Could it be an option to add an attribute, to change the behavior? Right now I need to activate ring to open to open the front door (which is technically not required).

its quite unhandy that the open action is hidden

That is also true for HA default behaviour when exposing the lock entity in lovelace, the lock.open service is not exposed in the UI, only lock.lock and lock.unlock are.
Problem is that many think that if the lock is locked, the only possible action is lock.unlock but that's not true, you can do lock.open when the state is locked.
I hope at least with mushroom this can be corrected.

I also think there should be option for the unlatch button to not show up when the door is unlocked, or at least a way to get a confirmation message.
For security reasons I have my card setted up in such a way that if I tap on the card it call service lock.open but with a confirmation message, even with this I'm still always a bit afraid of misclicking the unlatch button when i'm out.
This is my card code:
type: custom:mushroom-lock-card entity: lock.nuki layout: vertical fill_container: true name: Puerta tap_action:   action: call-service   service: lock.open   target:     device_id: b460a03dacba9254c4d9189feffe8219   data: {}   confirmation:     text: ¿Abrir la puerta?

@piitaya Paul, will this be corrected?

Any upgrade on this matter?
I'm facing the same problem when using Nuki.
Since the open/unlatch button only shows when the door is unlocked, I need to:

press the unlock button
wait a couple of seconds until nuki/hass sync the state
wait for the refresh of the card to show the Lock and Open buttons
click into Open.

I pretty sure we have to options:

always show the open/latch button (when supported)
have an property on the configuration to always show the button

I really like the suggestion from  @thor9898 to ask for a confirmation before open it, it avoids the mistake to wide open it when im not at home

Probably a bit too simple (no config entry and no confirmation before opening) but here is a one-line change to always shop open even when locked (for the nes who can't wait for a proper change):
https://github.com/fjfricke/lovelace-mushroom

Probably a bit too simple

Did you submit a PR? :)


gitattributes: Checkout ScanCode samples with Unix line endings

Otherwise the ScanCodeTest can fail on Windows, because the calculated
package verification code depnds on the line endings.

depnds on the line endings

"depends"
Besides the fact that I (and neither AppVeyor) ever had a problem with this test on Windows, this change made me wonder how changing the line ending of the ScanCode native result file has an influence on the package verification code of the files being scanned.
IMO ScanCodeTest is simply calling generateSummary() with the wrong argument: Instead of passing the directory being scanned, it passes the path to the expected ScanCode result file, which it totally wrong, or?

"depends"

Done.

Besides the fact that I (and neither AppVeyor) ever had a problem with this test on Windows, this change made me wonder how changing the line ending of the ScanCode native result file has an influence on the package verification code of the files being scanned.
IMO ScanCodeTest is simply calling generateSummary() with the wrong argument: Instead of passing the directory being scanned, it passes the path to the expected ScanCode result file, which it totally wrong, or?

It's semantically wrong, but we need to pass something and the scanned files are not available, so passing the result file is a simple workaround for the test.
I don't know why this behaves differently on Azure than on AppVeyor or your machine, but this fixes the issue. Maybe some difference in the global Git configuration.

It's semantically wrong

Which we should definitely highlight with a code comment!

but we need to pass something and the scanned files are not available, so passing the result file is a simple workaround for the test.

Actually, we don't need the scanned files, just their SHA1s, and these are available in the native scan result. With these SHA1 we could easily calculate the correct package verification code for the scanner files via this overload of calculatePackageVerificationCode(). The expected package verification code could be calculated using this script.
I can make that change if you do not currently want to spend time on it.

I don't know why this behaves differently on Azure than on AppVeyor or your machine, but this fixes the issue. Maybe some difference in the global Git configuration.

I have no doubts that this change make the issue you see on Azure go away, but like you say, what we do in the first place is semantically wrong, and this change makes it even more wrong.

Actually, we don't need the scanned files, just their SHA1s, and these are available in the native scan result. With these SHA1 we could easily calculate the correct package verification code for the scanned files via this overload of calculatePackageVerificationCode(). The expected package verification code could be calculated using this script.

The SHA1s of the scanned files are not sufficient, we had this discussion before:
https://github.com/oss-review-toolkit/ort/pull/1903#discussion_r338413577
For the purpose of the test the current implementation is sufficient, it just needs to verify that the generated verification file matches the passed file, not that the passed file matches the scanned files, because that is not the responsibility of generateSummary. This would belong to a test testing the code calling generateSummary, namely scanPathInternal(). A code comment explaining that would be helpful, of course.

I have no doubts that this change make the issue you see on Azure go away, but like you say, what we do in the first place is semantically wrong, and this change makes it even more wrong.

It's semantically wrong, but the semantics are irrelevant for the test. It's a test of an internal function after all, not of public API.

For the purpose of the test the current implementation is sufficient, it just needs to verify that the generated verification file matches the passed file

If the only thing you want to verify here is that the packageVerificationCode matches the SHA1 of the SHA1 of the passed file, can we then please take some other arbitrary binary file, or a file that already has eol=lf in .gitattributes, like e.g. gradlew or gradle/wrapper/gradle-wrapper.jar, instead of the really confusing re-use of resultFile? Plus some code comment that we are just using some arbitrary file here?
Like said, I offer to do that change myself.

Like said, I offer to do that change myself.

I'll prepare a PR.


Training hangs

Training will hang indefinitely on the first backprop command:
print('backpropping a step')
_, loss, summary = sess.run([train_op, model.loss, train_summary],
                                    feed_dict={is_training_pl: True})
print('finished backpropping a step')

second print statement doesn't occur, even after a long time.
When I examined further, in fact simply running:
loss = sess.run([model.loss], feed_dict={is_training_pl: True})
will also hang. Any idea of why this could be happening?  I set batch size to 1, and checking the GPUs, they are not being used.
I am also getting the following error in the error log:
pyarrow.lib.ArrowIOError: Expected to be able to read 196608 bytes for message body, got 196576,
but the script continues after this error is given, so I'm not sure it is relevant.

The lmdb files in the Google drive were created with an older version of pyarrow, which seems to be incompatible with the newer version. I have updated those files. If you download the new training and validation files this issue should be resolved.


ValueError: could not convert string to float

I've tried changing line 905 price.replace to add \ but that doesn't work. Any ideas?

[06:39:30 PM] Autobidder started
[06:40:06 PM] Filters successfully entered
[06:40:06 PM] Fetching futbin prices (new version)...
Exception in thread Thread-4:
Traceback (most recent call last):
File "C:\Users\veloc\AppData\Local\Programs\Python\Python39\lib\threading.py", line 973, in _bootstrap_inner
self.run()
File "F:\FUT_TRAD\Fifa-Autobidder-main\src\gui.py", line 409, in run
autobidder_obj.run()
File "F:\FUT_TRAD\Fifa-Autobidder-main\src\autobidder.py", line 121, in run
self.getFutbinList(
File "F:\FUT_TRAD\Fifa-Autobidder-main\src\autobidder.py", line 996, in getFutbinList
self.fetch_player_data()
File "F:\FUT_TRAD\Fifa-Autobidder-main\src\autobidder.py", line 906, in fetch_player_data
price = float(price)
ValueError: could not convert string to float: '2 3  \  57 36 53 56 84 81

same here, is  there a fix?


Revert gcc pinning

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Closes #43

@conda-forge-admin, please rerender

Great, thanks John! 🙏


Document LogicalCounts

Hi all! I noticed the expected keys for LogicalCounts https://github.com/microsoft/qsharp/blob/fc6ec5bccac1e74dbffe5be6d78a00394b177dd8/pip/qsharp/estimator/_estimator.py#L1026 are not actually documented https://learn.microsoft.com/en-us/python/qsharp/qsharp.estimator.logicalcounts?view=qsharp-py
It would be nice to have a reference doc that lists the expected keys (i.e. what we're expected to count).

Ooops. Yeah, looks like the auto-generated Python API docs are pretty poor, and we didn't cover logical counts in our more general docs at https://learn.microsoft.com/en-us/azure/quantum/intro-to-resource-estimation.
I'll look into getting these improved. For now, hopefully the source can help. See the LogicalCounts code at https://github.com/microsoft/qsharp/blob/main/pip/qsharp/estimator/_estimator.py#L1026 and some of the tests at https://github.com/microsoft/qsharp/blob/main/pip/tests/test_re.py#L158 and let me know if you've any questions still.


feat: Add new default dashboard

SUMMARY

This PR adds a new dashboard showing sales of vehicles. It uses the new import/export framework for examples (see https://github.com/apache/incubator-superset/pull/12026), and required adding more types for the data import, as well as quarterly time grain to the Sqlite engine spec.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Installed Superset from scratch, dashboard is imported correctly (see screenshots) together with all assets (charts, dataset and data).
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

I must say this looks super elegent

I must say this looks super elegent

Props to @srinify for that! :)

Codecov Report

Merging #12044 (f9cd829) into ch3883 (d270a25) will decrease coverage by 15.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           ch3883   #12044       +/-   ##
===========================================
- Coverage   67.78%   52.72%   -15.06%
===========================================
  Files         953      435      -518
  Lines       46983    15671    -31312
  Branches     4659     4051      -608
===========================================
- Hits        31846     8263    -23583
+ Misses      15019     7408     -7611
+ Partials      118        0      -118

Flag
Coverage Δ

cypress
52.72% <ø> (-0.57%)
:arrow_down:

javascript
?

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...dashboard/components/resizable/ResizableHandle.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

...ontend/src/dashboard/util/getDashboardFilterKey.ts
14.28% <0.00%> (-85.72%)
:arrow_down:

...end/src/SqlLab/components/ExploreResultsButton.jsx
8.00% <0.00%> (-84.00%)
:arrow_down:

...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx
14.70% <0.00%> (-82.97%)
:arrow_down:

... and 802 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d270a25...f9cd829. Read the comment docs.


Font Subsetting - how do I do in pure js version of pdfkit

Font Subsetting - how do I do in pure js version of pdfkit.Is it possible , if yes how can it be done?

What is commandText and onMade?


Current API for ResourceMapper.extract() is confusing

Based on my experimentation, I believe there are two starting points for a developer wanting to provide a mapping for StructureMap-based extraction.
Option 1: Mapping is encoded in FHIR Mapping Language. This is the style reflected in this test case. The following code snippet shows how a developer would use the API in this case.
val mappingStr = "map ..."
lifecycle.coroutineScope.launch {
    val bundle =
        ResourceMapper.extract(
            myQuestionnaire,
            myQuestionnaireResponse,
            StructureMapExtractionContext(context = applicationContext) { _, worker ->
                StructureMapUtilities(worker).parse(mappingStr, "")
            },
        )
}

Option 2: Mapping is encoded in a StructureMap resource. In this case I found that I could make a trivial implementation for StructureMapExtractionContext, first deserializing to create a StructureMap instance myself if necessary.
val structureMapJson = "{...}"
val structureMap = jsonParser.parseResource(mappingJson) as StructureMap
lifecycle.coroutineScope.launch {
    val bundle =
        ResourceMapper.extract(
            myQuestionnaire,
            myQuestionnaireResponse,
            StructureMapExtractionContext(context = applicationContext) { _, _ -> structureMap
                )
            },
        )
}

Some points of confusion:

It is unclear what the purpose is for the String parameter of StructureMapExtractionContext.structureMapProvider. There is no documentation in the code, and it is not used in the test case.
The IWorkerContext parameter is also not used if you already have a StructureMap resource. And its purpose appears to be to pass to StructureMapUtilities to parse content in FHIR Mapping Language.

Speaking with @jingtang10 it might be good to revisit the API design for this. One option might be to leave it to the developer to convert their starting content to a HAPI FHIR StructureMap and change extract() to:
extract(
    questionnaire: Questionnaire,
    questionnaireResponse: QuestionnaireResponse,
    structureMap: StructureMap? = null
  )

I'm not sure how else StructueMapExtractionContext may be expected to be used though; for example it looks like a developer could optionally set their own StructureMapExtractionContext.transformSupportServices but again there is no documentation or test case.

@jingtang10 @aditya-07 , could you please discuss this and advise on the way forward?

@ekigamba fyi

there's actually another option, we could remove the implementation in the data capture lib. and provide code snippets in our documentation for developers to do it themselves. this is because the implementatino itself is actually fairly simple, we use hapi's transform lib for that. this removes all the complexity in the code, and gives developers a lot of flexibility.
this is a drastic change, but i think it might be the right call. @aditya-07 @williamito @kevinmost @stevenckngaa fyi

thanks @williamito for the excellent write-up!

Seeing this @jingtang10. We can have a follow-up call on this

@williamito could you please lead the conversation for this issue?


Check if a file exist in template.

Hi
same as if a template exist now I have problem into template. I need to include a file js if exist.
example check if a i18n file of a plugin exist in selected language or fallback default language
but same can be a photo photo or placeholder anyway

header.html.twig

{%if app.url('/assets/plugin/js/i18n/'~ session.lang ~'.js') %}
<script src="{{ app.url('/assets/plugin/js/i18n/'~ session.lang ~'.js') }}"></script>
{% else %}
<script src="{{ app.url('/assets/plugin/js/i18n/'~ session.fallback_lang ~'.js') }}"></script>
{% endif %}

this if statement doesn't work if session.lang.js doesn't exist brb a 404 code.
I was thinking to use a $app->getTemplateManager()->addFilter function with file_exist and in template return the file but seems a strange way :)
Thanks.

Unfortunately, this is not as easy as it has been with the template files.
While the template files must simply exist on your local file system, the URLs generated by App#url and (on request) handled by the web server pass through routing. The response may either be a file on the local file system (in the public folder) or a route processed by your PHP application.
So there’s much more complexity here already.
If you wanted to check if the URL you’re generating with App#url resulted in a 404 status, you would have to send an HTTP request (that stays on the local host) for every single check. Generating and handling HTTP requests for simple checks that may be used often is not really efficient.
If you wanted to avoid sending those HTTP requests while still being able to know if any URL actually exists (e.g. with a 200 status), you’d have to simulate those requests, at least, passing through your routing.
All this is probably something one wants to avoid. So what remains is the possibility to check for (static) files that exist in the public directory, where your JS files are usually stored, too.
From the perspective of app/index.php, the URL expressed by
app.url('/assets/plugin/js/i18n/' ~ session.lang ~ '.js')

is in
__DIR__ . '/../public/assets/plugin/js/i18n/' . $session->lang . '.js'

so why not try to write a simple function (passed to Twig) which does this, just as you suggested?
Again, make sure to implement this safely, not allowing for arbitrary path traversals. Your language code can probably be [A-Za-z_-]+ only.

Wow tis path traversal I didn't think but shouldn't... I hope :) anyway my thinking was this I didn't try but should work if $app->url($toPath) return true or false... should.
app/index.php
$app->getTemplateManager()->addFilter('ifFileExist', function ($file) {
    return $app->url($file);
});

header.html.twig
{% set file = '/assets/plugin/js/i18n/' ~ session.lang ~ '.js' %}

{% if file ifFileExist %}
<script src="{{ app.url(file) }}"></script>
{% else %}
<script src="{{ app.url('/assets/plugin/js/i18n/'~ session.fallback_lang ~'.js') }}"></script>
{% endif %}

I am out or ... ? :)
Thanks.

Well, with something like this, which only checks for a file’s existence, a directory traversal attack will not have that much of an impact. But if you implement something where the user can actually include files, you should really check if they are allowed to access or include that file.
Regarding your implementation here, App#url does not return true or false. It always returns a URL for the input you have specified, no matter if that URL “exists” or not. That’s exactly how you have used it in the templates as well. Why do you expect it to behave differently in the application code? So, again, the return value
return $app->url($file);

won’t help you and doesn’t make much sense.
As suggested earlier, it would have to be something like this:
return file_exists(__DIR__ . '/../public/' . ltrim($file, '/'));

But this has not been tested, and you must use it securely, as explained earlier. User inputs must never be fed into this function. If they are, you have to ensure the user did not specify something like /../../../../../some/secret/file/that/the/user/must/not/know/exists, etc.