Format tool fails when backslash is used

$ crystal -v
Crystal 0.23.1 (2017-09-18) LLVM 4.0.1

$ cat test.cr
def test
  print "hello", \
    "world"
end

test()

$ crystal run test.cr
helloworld%

$ crystal tool format --check test.cr
Error:, couldn't format 'test.cr', please report a bug including the contents of it:
https://github.com/crystal-lang/crystal/issues

https://play.crystal-lang.org/#/r/2z2d
Not tested on current master only with the latest stable version, 0.23.1 on macOS and Ubuntu respectively.
Here is the piece of code alone for reference;
def test
  print "hello", \
    "world"
end

test()

I could find a related issue https://github.com/crystal-lang/crystal/issues/3383 but current one is a bug since it's failing without an error which probably introduced while taking care #3383
It would be better to add --verbose option to formatter as well since there is no way to see where it's failing now, at least exception can be printed out to the output with --verbose option in such cases https://github.com/crystal-lang/crystal/blob/master/src/compiler/crystal/command/format.cr#L178-L184

You don't need a backslash here.
This is totally fine:
def test
  print "hello",
    "world"
end

test()

But of course, the compiler should either accept it or provide a meaningful error message.

#4631

I repeat: printing a stack trace will help us fix the bug. It won't help a user at all.

@asterite Isn't true that printing backtrace will help user help us to fix the bug? ;)

Not much. In this case they can just submit the code and we can see where it fails. In other compiler bugs we have to try to understand what's wrong, here it's just syntax.


Migrate kie-tools/daily_dev_publish.yml GH workflow to Apache Jenkins

The PR is ready for review: https://github.com/apache/incubator-kie-tools-temporary-rnd-do-not-use/pull/10

As previously discussed all PR related to GH Actions -> Jenkins (as this one) opened to https://github.com/apache/incubator-kie-tools-temporary-rnd-do-not-use are GOOD to be integrated as it is a temporary repository.
Track at #704


Support reading from BytesIO/StringIO

I'm trying to write a GIF to memory and use panel to read from memory rather than storage.
ValueError: GIF pane does not support objects of type 'BytesIO'
from io import BytesIO
import imageio

memory = BytesIO()

save_fps = [..]

with imageio.get_writer(memory, mode='I', format='gif', fps=8) as writer:
    for fp in save_fps:
        image = imageio.imread(fp)
        writer.append_data(image)

memory.seek(0)
pn.pane.GIF(memory)

Extending it to support a file-like object should be reasonable; sure.  I think you'd need to add a case for that in panel.pane.image.ImageBase:_img(); it currently accepts a string that it interprets as a file path or as a URL.


polymorphism? 2. action bubbling?

Hello,
I'm using Redux(+React) to make operate on hierarchical structures and I have two questions:

how to implement polymorphism in Redux?
how to make "action bubbling"

My questions expressed more precisely:

I'm making structural code editor in React, using Redux. By structural editor I mean that I have tree structure with nodes in it and my app is supposed to operate on AST rather than plain text.

These nodes can have various types (because it's editor for editing CSS files, these types are for example: "rule", "declaration", "property", "value", but it's more important that they do have some type at all). So there are objects in JS which have property type and its type determines its... type ;)
So assume that I have node like this:
{type: 'property', id: 4, rule: '.content > ul > li', children: [...blah blah......]}
And I would like to be able write something like that:
store.dispatch({type: 'click', nodeId: 4})
for click. But I would expect that clicking on node of type rule would have other effect than clicking on node of type property. Polymorphism (but I would like to have ONE react component <Node /> to prevent code duplication).
I know I can achieve that either by switch/case or making my own sub-functions (I mean to delegate action to functions), but I don't want reinvent the the wheel. I think that support of polymorphism would be useful to many applications, not only mine.
So - how to achieve polymorphism in Redux?
2., Second question about action bubbling. Because I got tree structure for example such like this one:
{
    type: 'rule',
    rule: 'body div',
    id: 1,
    children: [
         {
              type: 'declaration',
              id: 2,
              children: [
                    {type: 'property', name: 'display', id: 3},
                    {type: 'value', value: 'block', id: 4},
              ]
         }
    ]
}

And I have appropriate React components that render that structure (I have dumb function-based stateless React 0.14 components, so I don't think components' code is very important right now). Anyway I got <Node/> component that represents single AST node.
I would like that user could click on for example on node at id=3 (  {type: 'property', name: 'display', id: 3},) and action would automatically "bubble" to node's parents (in this case to declaration node at id=2  and to rule node at id=1).
As far I know there is no "action bubbling" in Redux. Maybe it should be? Or maybe what I would like to achieve could be made by other means? (by "action bubbling" I mean something similar to "event bubbling" in JavaScript events in browser, only I would like redux actions to bubble and I do NOT want DOM events to bubble (this is completely other thing). I would like to redux action to bubble. When I wrote "bubbling" I ment overall design pattern rather than implementation.
And these were my two questions :)

Hi, please ask this on StackOverflow instead. It is likely you'll get a much better answer there because this is really a usage question, not API question or issue.

Actually I thought it would be nice to have support for these two features (polymorphism and action bubbling) in Redux or React-Redux itself (if it's possible).
But okay, I wrote question on Action Overflow:
http://stackoverflow.com/questions/33169415/polymorphism-and-action-bubbling-in-redux

To be honest I don't understand neither what you mean by polymorphism nor what you mean by bubbling. :-(
Maybe if you can provide a specific runnable example and show where Redux doesn't currently satisfies it, I can help you more.

TL;DR:

I solved my problem (using higher-order components and higher-order functions in general). I done this on the React level (this turned out to be not Redux specific)
I'm gonna probably make mini-library from my solution and put this on github
But I'll write below what I meant previously, just to be clear.

To be honest I don't understand neither what you mean by polymorphism
I'm just trying to apply standard OOP patterns to functional and data oriented programming.
So. I have some hierarchical tree like data structure (like in my first post but instead of CSS AST imagine maybe that I build something more normal like Forum Engine with subforums, threads and posts). And I render this tree in React:
const Node = ({node})  => (

      //  render some arbitrary view inside the node based on node.type
      //   every node of the tree should look and behave according to its "type" property.
       //
      // ......

      // visit children

      {node.children.map(
          item =>
<Node node={item}/>

       )}

)

Nothing weird here, just implementing tree structure and visiting children, and recursive rendering subtrees.
The problem was with this part

      // .... (render some arbitrary view inside the node based on node.type )
      // ......

I didn't want end up with big switch like this:
switch (node.type) {
   case 'subforum': { node.name }  { node.newestThread.name }; break;
   case 'thread': {node.name} ; break;
   case 'post':

{node.author} - {node.date}
{ node.content }

}

I never really wanted to use switch/case, but just to illustrate. I just knew that I had to pack all this cases in some separate functions. And this is why I used word polymorphism.  Finally I made some simple higher level components for resolve my problems :)
It turned out also that second thing - i.e. what I wanted achieve by "bubbling" can be achieved in passing handlers to components (like it's in Redux-React itself but previously I just didn't like the idea. Maybe I was just wrong in this case)


Options "iconClass" and "iconClassMobile" are incorrect!

Please update the documentation, these properties seems to be renamed by "iconTemplate" and "iconTemplateMobile".

Also, it would be better to specify that the acceptable values for the 'clockType' options are '12h' and '24h'. I initially tried with '24' and it didn't work :(

It's fixed in 2.3.0 version.


CA no seat heating function

Hyundai / Kia Connect version: 1.45.6
Python version: 3.9
Operating System: HAOS

Description
I was trying to get the seat heating work for the start_climate function.
What I Did
I changed the KiaUvoApiCA.py file line number 495 to the following and it worked. (Non EV)
Steeling wheel heating: On
Front and back defrost: On
Driver Seat: HI heat, All other off.
Was using burp to capture the API call.
payload = {
            "setting": {
                "airCtrl": int(climate),
                "defrost": defrost,
                "heating1": 4,
                "igniOnDuration": duration,
                "ims": 0,
                "airTemp": {"value": set_temp, "unit": 0, "hvacTempType": 1},
                "seatHeaterVentCMD":{"drvSeatOptCmd":8, "astSeatOptCmd":2, "rlSeatOptCmd":2, "rrSeatOptCmd":2},
            },
            "pin": self.pin,
        }

Any chance it could be added to the API? I usually just change the KiaUvoApiCA.py each time when this pip package get updates.
Thanks!

Looks like you have an EV so it is separate from my cars logic today as start is different for reach. Can you test the latest release and let me know if it works for seats?
As a note the values are explained in https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/blob/master/hyundai_kia_connect_api/const.py

Hi cdnninjia,
No mine is ICE, 2021 Hyundai Elantra, I will test it and let you know, thanks!

Interesting!   This whole time I thought when "setting" was used it was an EV in the payload as an EV won't start with my payload of a 2019 sorento ICE.  This logic can be seen here: https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/blob/f943c17b0fa971e59fb8b22251fd714e788bc5bb/hyundai_kia_connect_api/KiaUvoApiCA.py#L488-L514
Now since I assume your elantra starts with the current code it means your car takes both the old and new format without issue.
So two things I need to do to narrow that down.

could you enable debug logs for the package and see what "get vehicle response" I think it has an API or generation item in that.  genType is a value of it that maybe tells us which we should be using.
I will test using the "settings" version of the payload on my ICE 2019 and see if it works or not.  If it does we can just go back to a single payload approach.

Hi cdnninja,
Here is the get vehicles response:
{
  "responseHeader": {
    "responseCode": 0,
    "responseDesc": "Success"
  },
  "result": {
    "vehicles": [
      {
        "vehicleId": "****",
        "nickName": "ELANTRA",
        "modelCode": "EL74MF20A100",
        "modelName": "ELANTRA ICE",
        "modelYear": "2021",
        "fuelKindCode": "G",
        "trim": "Ultimate Tech (Melan",
        "engine": "",
        "exteriorColor": "YP5",
        "dtcCount": 0,
        "subscriptionStatus": "A",
        "subscriptionEndDate": "****",
        "mileageForNextService": ****,
        "daysForNextService": "****",
        "overviewMessage": "",
        "defaultVehicle": true,
        "enrollmentStatus": "4",
        "genType": "G1",
        "photoUrl": "****",
        "valetParkingModeOn": 1,
        "vin": "****"
      }
    ]
  }
}

The seat heating is working now! But the side window defrost and heated steeling wheel still not work. I attached the captured settings from web request (myhyundai.ca) below. When compare with the debug log, only two parts are different: heating1 and hvacTempType.
From the debug log: heating1 is 3 and hvacTempType is 0
From the web request: heating1 is 4 and hvacTempType is 1.

{
  "setting": {
    "airCtrl": 1,
    "defrost": true,
    "airTemp": {
      "value": "13H",
      "unit": 0,
      "hvacTempType": 1
    },
    "heating1": 4,
    "igniOnDuration": 8,
    "seatHeaterVentCMD": {
      "drvSeatOptCmd": 8,
      "astSeatOptCmd": 2,
      "rlSeatOptCmd": 2,
      "rrSeatOptCmd": 2
    },
    "ims": 0,
    "defaultFavorite": false
  },
  "pin": "****"
}

Thank you for your great work!

Well I was clearly confused.  EVs use havinfo so my code change only works on ICE cars.  Did you try pass a 4 for heating in climate when you called it?  I haven't seen a 4 so haven't defined as a enum but it should pass through.   What are your option in the app?
Here is the options I am aware of but 4 sounds new:
https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/blob/a5e5d1ddea75732a0fd7875972ddcfec97d2a48f/hyundai_kia_connect_api/const.py#L35-L41


⚠ explorers: markdown → html

In #1422, we only looked at descriptions using HTML in ETL. However, there are still some charts and explorers using HTML: Those from manual configs in explorers, datasets that were manually imported in the past, and datasets imported via importers.
This issue tries to address this for Explorers. I've included the list of explorers below; could you check these as those are fixed?
Guidelines
There are different types of explorers, and reviewing these might be different.

Indicator-based: We should go back to the snapshot in ETL, which is the source for the indicator. Example: animal-welfare
Chart-based: We should investigate where the dataset powering the used charts comes from. If from ETL, check ETL. Other sources could be importers or manual imports. Example: democracy
Manual config: The explorer configuration is written in the admin explorer configm. We need to edit this. Example: coronavirus-data-explorer
Templating: The explorer configuration was generated automatically using owid-content. Example: population-and-demography

List of explorers to review
(only public ones)

[x] coronavirus-data-explorer
[x] animal-welfare
[x] democracy
[x] incomes-across-distribution-comparison: https://github.com/owid/owid-content/pull/31
[x] inequality-comparison: https://github.com/owid/owid-content/pull/31
[x] inequality: https://github.com/owid/owid-content/pull/31
[x] lis-expanded-poverty: https://github.com/owid/owid-content/pull/31: https://github.com/owid/owid-content/pull/31
[x] lis-incomes-across-distribution: https://github.com/owid/owid-content/pull/31
[x] lis-inequality: https://github.com/owid/owid-content/pull/31
[x] poverty-comparison: https://github.com/owid/owid-content/pull/31
[x] wid-incomes-across-distribution
[x] wid-inequality
[x] food-footprints
[x] climate-change
[x] incomes-across-distribution-ppp2017: https://github.com/owid/owid-content/pull/31
[x] pip-inequality-explorer: https://github.com/owid/owid-content/pull/31
[x] poverty-explorer-2011-vs-2017-ppp: https://github.com/owid/owid-content/pull/31
[x] poverty-explorer-expanded: https://github.com/owid/owid-content/pull/31
[x] poverty-explorer: https://github.com/owid/owid-content/pull/31
[x] migration
[x] population-and-demography: https://github.com/owid/owid-content/pull/31
[x] water-and-sanitation
[x] global-food
[x] crop-yields
[x] co2
[x] ipcc-scenarios
[x] influenza
[x] global-health
[x] fertilizers
[x] air-pollution
[x] fish-stocks
[x] habitat-loss
[x] impacts-of-energy-sources
[x] migration-flows
[x] monkeypox
[x] natural-disasters
[x] natural-resources
[x] plastic-pollution
[x] ukraine-russia-food
[x] us-covid-data-explorer
[x] energy
[x] food-prices

some work for explorers based on templating done here: : https://github.com/owid/owid-content/pull/31

@lucasrodes, after merging https://github.com/owid/owid-content/pull/33 all explorers in the list should be cleared of HTML tags. Shall we close the issue?

Thanks for your work, @pabloarosado @paarriagadap
Closing this!


Remove metal dependency

It's surprisingly used in the public API, and functionally only called with this:

MetalDevice::all().into_iter().filter(|device| device.is_low_power())

Sine metal updates more often than surfman, it would be preferred to not depend on metal. In this case, just exposing cocoa::id in public API and issuing objc messages for that function should be enough.

@jdm Do you think this would be a good idea as well? If so, should I  change the return type to Strings?

I agree with kvar's assessment. We should replace MetalDevice in this code with a cocoa::id value instead, and we can copy this code and this code to replace the calls in this code.

Looking at the Metal code, it appears that they use both a Device and DeviceRef struct. htis solves the problem of the msg_send! not working with the device, but needing a reference. How much of the DeviceRef struct should I emulate, and should I make a NativeDevice consist of a Cocoa Id and a DeviceRef?

https://github.com/servo/surfman/blob/master/surfman/src/lib.rs

I remember taking a look back in December and deciding that the code we would need to duplicate didn't feel like a good tradeoff. I don't think this is worth pursuing.


Restore broken functionality and simplify the implementation in src/display/text_layer.js

Please refer to the individual commit messages for additional information.

/botio test

I wonder if the limit will help with https://bugzilla.mozilla.org/show_bug.cgi?id=1890537 and/or https://bugzilla.mozilla.org/show_bug.cgi?id=1838865.

I wonder if the limit will help with https://bugzilla.mozilla.org/show_bug.cgi?id=1890537

I don't think so, since the number of textLayer elements are quite low there with < 400 per page.

or https://bugzilla.mozilla.org/show_bug.cgi?id=1838865.

The PDF link in the bug seems dead, but a version of the file is available through the Internet Archive. Even in that case we're below the limit, with approximately 28000 respectively 66000 textLayer elements for the two pages.

/botio test


failOnStderr: true

Use this pr to uprev

Codecov Report

Merging #44 (2b1af4f) into main (6c9bb90) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #44   +/-   ##
=====================================
  Coverage   8.25%   8.25%
=====================================
  Files         43      43
  Lines       5219    5219
=====================================
  Hits         431     431
  Misses      4788    4788

Flag
Coverage Δ

oasysgh
1.09% <ø> (ø)

unitnumber
7.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[FEATURE] Add support for Firebase Storage

https://firebase.google.com/docs/storage

Hi, why have this been abandonned ? I also need this feature.

Hello,
I'm also interested in the status update of this feature. Is it going to be added or there is some other limitation that makes it impossible to make?
I see that the issue was marked as completed.


proposal: use vmtest as go test runner

I'd like to be able to do the following:
$ go test -exec vmtest ./... -vm.image /path/to/vmlinux -vm.env SOME_ENV -other-flag

Behind the scenes:

Compile the tests into a binary in /tmp (?)
Execute vmtest with the following args: "/tmp/path/to/test" "-vm.image" "/path/to/vmlinux" "-vm.env" "SOME_ENV" "-other-flag"
vmtest would make the appropriate 9pfs mounts to make the go test runner happy: https://github.com/cilium/ebpf/blob/master/run-tests.sh#L27-L78
vmtest would execute the test with /tmp/path/to/test -other-flag, with PWD being the directory vmtest is invoked in on the host

P.S. The weird vm. prefix on flags is needed due to how go tests behave when unknown flags are present. Behind the scenes vmtest should strip the prefix.
It would also be nice to be able to specify certain "global settings" in vmtest.toml, like memory or number of CPUs.
My goal would be to replace most of run-tests.sh with vmtest.

Assuming we add the one-liner interface to vmtest (which I am much in favor of), wouldn’t it be possible to pass flags to vmtest like this? Passing unknown flags to go test seems a bit odd.
$ go test -exec “vmtest —kernel /path/to/vmlinux”

My test shows:
$ go test -exec "./wrapper/a.out --wrapper-flag"
argv[0] = ./wrapper/a.out
argv[1] = --wrapper-flag
argv[2] = /tmp/go-build2128986016/b001/test.test
argv[3] = -test.paniconexit0
argv[4] = -test.timeout=10m0s
ok      example.com/test        0.001s

wrapper/main.c: https://pastes.dxuuu.xyz/l9knkt
It seems the same technique could be used for rust: https://github.com/libbpf/libbpf-rs/blob/4574a7825f1c088726c3d3eefd3d0d8f9ddd116e/libbpf-rs/.cargo/config#L2

It would also be nice to be able to specify certain "global settings" in vmtest.toml, like memory or number of CPUs.

That seems reasonable to me. The only thing I’m not sure about is what happens if you ask QEMU for more resources than is available on the current machine. For example, if you ask for 4 cpus on a 2 core machine. Should we clamp down to 2 or return an error? It’s more of a instance property than a config file property, so maybe it should go on cmd line?

It’s more of a instance property than a config file property, so maybe it should go on cmd line?

Good point, not sure there is a good answer. For my use case I have some tests which require > 1 cpu IIRC.

Ok, I'll give supporting the go-style flags a shot. Hopefully it's possible to use clap's custom parser support to extend. Would be unfortunate to throw clap out.


Xcode 7 beta 5 incompatibility (swift2)

.../Core/Mapper.swift:76:15: error: 'dropFirst' is unavailable: Use the dropFirst() method instead.
.../Core/ToJSON.swift:12:33: error: 'split(_:maxSplit:allowEmptySlices:isSeparator:)' is unavailable: Use the split() method instead.
.../Core/ToJSON.swift:31:14: error: 'dropFirst' is unavailable: Use the dropFirst() method instead.

I've already submitted a pull request #170.

@ikesyo cool, but anybody merging it?

I just merged it.

Thanks!


Announcement of Open Sustainable Technology joined LF Energy.

The projects was accepted as member of LF Energy in the incubation stage. :partying_face:
To announce that publicly we can use existing text blogs from the LF Energy application document and the grant documents:
https://hackmd.io/@YhPkDVi5RJK7NY7ttj2HZQ/B13EBTaTn/edit
https://hackmd.io/@YhPkDVi5RJK7NY7ttj2HZQ/SyGHj1j0n/edit
https://hackmd.io/@YhPkDVi5RJK7NY7ttj2HZQ/HkI-Cxgx6/edit
The blog post can be released on OpenSustain.tech and the LF Energy Website. The blog post should reflect our long-term goals and perhaps include a small roadmap.
The blog post can also been used to make a community call to get more members excited about the project. What do you think about this?
@dbrownlf @andrew @joshhopkins @jmertic
The same blog post could also been used to announce the collaboration with Ecosyste.ms. But I think it makes sense to publish this in another blog post. Otherwise it will be just too much for one article.

@dbrownlf I filled everything out. The only thing that we need to clarify is the license of the website since it is not a OSI Approved Licenses.

Thanks @Ly0n! Looks good on my end. I've sent the logo details to design so they can get started on it. I saw the note in Slack about the license and will let John weigh in there.


Add unwrap_used lint warning to all workspaces

From https://github.com/ethereum/trin/pull/681#discussion_r1173387002 it appears like we're not linting for naked unwraps in all workspaces.
How to fix it?
Add #![warn(clippy::unwrap_used)] to lib.rs for any workspace that doesn't already contain this lint. Example: https://github.com/ethereum/trin/blob/master/trin-history/src/lib.rs. And handle any unwraps that might be lurking

I would like to contribute.

@njgheorghita  Hi ,I would like to contribute

You are free to contribute, don't ask for permission :smile_cat: .


Database logic cleanup (part 3)

jenkins: test this please

jenkins: test this please

jenkins: test this please

jenkins: test this please

Testsuite passed

jenkins: test this please

jenkins: test this please

jenkins: test this please

Testsuite passed

jenkins: test this please

jenkins: test this please

jenkins: test this please

Testsuite passed

jenkins: test this please

Testsuite passed


GEOMESA-607 enabling caching by default

Also updating deprecated synchronization in metadata

I've read through and this looks reasonable. (Only picky comments.)

I'm going to close this - caching can cause OOM errors with large layers, so it probably shouldn't be enabled by default.


working with telegram payments

Hi, I enabled my bots to accept payments ,is this something that is supported with this gem?

Not yet, @ivanovaleksey is working on implementing new functionality.

I see, thanks for the update.  Didn't see the new methods implemented.

@angelacode please see #118 for the updates.


AnimatedNavHost transitions can be easily broken.

Not sure if this qualifies as library bug but it's quite easy to break the whole navigation if there are transitions involved.
It can be easily noticed in your BottomNavigation Demo. Just start spamming between any of 2 screens and you end up with navigation unresponsive.
Could it be that any ongoing transitions are not being cancelled prior to navigation action?

@michaldrabik Hi. This is an issue in the library. Thanks for reporting, I've fixed it. You can use the snapshot with the fix:
repositories {
    maven(url = "https://s01.oss.sonatype.org/content/repositories/snapshots/")
}

implementation("dev.olshevski.navigation:reimagined:1.3.2-20230223.191530-1")

The expected behaviour: every transition should be queued and played one-by-one sequentially, even when the queue gets long due to action spamming. Any previous transition is not cancelled as it may result in an unpleasing/glitchy visuals.

Thank you for swift response. We will test it out.
We also noticed similar behaviour with Modal navigation. When we open and close the sheet rapidly (by tapping background which triggers dismiss callback) it's also possible that the sheet will stay visible and navController no longer reacts.
Perhaps this is related and could be double checked as well?

@michaldrabik I cannot reproduce it for BottomSheetNavHost in the version 1.3.1. I'm opening and closing the bottom sheet in the demo app as fast as I can, but it doesn't break. Maybe there are other precondition needed for reproducing it.
Can you please check if the fix resolves the issue with bottom sheets on your side? It seems to me that that it may have been caused by the same bug.

Yeah, unfortunately it can't be reproduced in the demo sample. The snapshot version does not seem to fix the issue for us too.  Unfortunately I can't post code samples or even video due to policies.
But the bottom navigation issue originally reported is fixed although It feels kind of weird that after quickly switching between 2 destinations you need to wait until scheduled transitions will finish : )

@michaldrabik

Yeah, unfortunately it can't be reproduced in the demo sample. The snapshot version does not seem to fix the issue for us too. Unfortunately I can't post code samples or even video due to policies.

Can you maybe make a simple app showing this issue which I can use to reproduce it?

@michaldrabik Can you please also tell what version of Compose are you using in the app? BOM or versions of each used artifact will do.

@olshevski
    compose_version = "1.4.0-beta01"
    compose_compiler_version = "1.4.2"
    material_version = "1.8.0" (com.google.android.material:material)

@michaldrabik Nope, still cannot reproduce it. I've played around with different sheet sizes, layouts, times between clicks (even automated it a bit). Tested on different compose versions.
It must be something else that might cause this issue, not sure what it could be. Is there any chance that you can show how BottomSheetNavHost is set up in your code (just the barebones, without any sensitive information)? Maybe it is some parameters that affect the behaviour, or the parent composable.

@olshevski Basically it's like MainActivity with setContent :
        setContent {
// ...
                        MainNavEntryPoint()
                        ModalNavEntryPoint()
        }

where
    @Composable
    @OptIn(ExperimentalAnimationApi::class)
    private fun MainNavEntryPoint() {
        val navController = rememberNavController<NavDestination>(MainDestination.Main)

        NavBackHandler(navController)

        AnimatedNavHost(
            controller = navController,
            transitionSpec = { action, _, _ ->
                navEnterTransition(action) with navExitTransition(action)
            }
        ) {
            if (it is MainDestination.Main) {
                MainScreen(screenProviders = screenProviders)
            } else {
                screenProviders.ScreenContent(destination = it)
            }
        }
    }

    @Composable
    @OptIn(ExperimentalMaterialApi::class)
    private fun ModalNavEntryPoint() {
        val navController = rememberNavController<NavDestination>(emptyList())

        BottomSheetNavHost(
            controller = navController,
            scrimColor = Color.Black.copy(alpha = 0.60f),
            sheetBackgroundColor = SomeTheme.colors.primaryBackgroundColor,
            sheetShape = RoundedCornerShape(topStart = 10.dp, topEnd = 10.dp),
            sheetPropertiesSpec = {
                BottomSheetProperties(
                    isSkipHalfExpanded = true
                )
            },
            onDismissRequest = { navController.pop() }
        ) {
            screenProviders.ScreenContent(destination = it)
        }
    }

@olshevski Actually, yes. The issue seems to be non-existent in that snapshot 🥇

@michaldrabik Great!
I've also worked on a new alternative queueing strategy that may be more suitable for some cases (as for BottomNavigation). There is another new snapshot (another day another snapshot heh):
implementation("dev.olshevski.navigation:reimagined:1.4.0-20230302.163310-2")

This snapshot adds a new parameter to AnimatedNavHost. You can specify transitionQueueing = NavTransitionQueueing.Conflate and it will skip as many pending transitions as possible. This way there wouldn't be this ridiculous queue of animations if a user spams buttons.
You may check it out as well if you want.

@olshevski Thanks, do you expect a non-snapshot release anytime soon?

@olshevski Got it. Thanks.
We're very happy with migrating from Voyager to Reimagined anyway as it appears to have none of lifecycle problems Voyager has (and still not fixed - seems abandoned), so great job anyway. Kind of hesitant with using snapshots in our releases so will just wait until proper one. Kind regards.

@michaldrabik Sorry for the long wait. I've finally release a new version today. It includes all the discussed fixes.
Please note that there is a breaking change in BottomSheetNavHost - couldn't come up with a reasonable backward-compatibility for it: you need to specify a Surface inside BottomSheetNavHost manually now, like this:
BottomSheetNavHost(
    controller = sheetController,
    onDismissRequest = { sheetController.pop() }
) { destination ->
    Surface(
        elevation = ModalBottomSheetDefaults.Elevation
    ) {
        when (destination) {
            /* ... */
        }
    }
}

There is also no need for specifyingtransitionQueueing = NavTransitionQueueing.Conflate for AnimatedNavHost (as in the bottom navigation case). I decided that there is no need to have the transition queueing by default. But it may be enabled if anyone needs it.

Graet. Thanks for all your work.


Handle recursion error for head tails.

This is addressing #92.

In [10]: values = np.array([1 + 2**-52, 1, 1])

In [11]: mapclassify.HeadTailBreaks(values)
/Users/serge/Dropbox/p/pysal/src/subpackages/mapclassify/mapclassify/classifiers.py:1147:
UserWarning: Floating point issues with head-tails. Reverting to
quantiles.
  Reverting to quintiles.")
  /Users/serge/Dropbox/p/pysal/src/subpackages/mapclassify/mapclassify/classifiers.py:236:
  UserWarning: Warning: Not enough unique values in array to form k
  classes
    "Warning: Not enough unique values in array to form k classes",
    UserWarning
    /Users/serge/Dropbox/p/pysal/src/subpackages/mapclassify/mapclassify/classifiers.py:238:
    UserWarning: Warning: setting k to 2
      Warn("Warning: setting k to %d" % k_q, UserWarning)
      Out[11]:
      HeadTailBreaks

        Interval     Count
        --------------------
        [1.00, 1.00] |     2
        (1.00, 1.00] |     1

Isn't the error actually better than fall back to quantiles? This is a bit unexpected behaviour. I'd say we should capture RecursionError here https://github.com/pysal/mapclassify/blob/e9772ef84495d9a92e75d8f9d16879f8ce5a510d/mapclassify/classifiers.py#L176-L185
and stop the iteration at that point. That way you should get proper head tail breaks even with this floating issue on the very tail of it.

Isn't the error actually better than fall back to quantiles? This is a bit unexpected behaviour. I'd say we should capture RecursionError here
https://github.com/pysal/mapclassify/blob/e9772ef84495d9a92e75d8f9d16879f8ce5a510d/mapclassify/classifiers.py#L176-L185
and stop the iteration at that point. That way you should get proper head tail breaks even with this floating issue on the very tail of it.

It is tricky though, as when the RecursionError is raised, cuts has length 2970 for this example. Knowing where to trim back to is not clear to me. How do we distinguish between a cut that is due to this floating-point issue (i.e., erroneous) and one that is a valid break for a long-tailed distribution?

Codecov Report

Merging #95 (2adec7b) into master (c9bb671) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master     #95   +/-   ##
======================================
  Coverage    86.3%   86.3%
======================================
  Files          10      10
  Lines        1553    1558    +5
======================================
+ Hits         1340    1345    +5
  Misses        213     213

Impacted Files
Coverage Δ

mapclassify/classifiers.py
79.1% <100.0%> (-<0.1%)
:arrow_down:

mapclassify/tests/test_mapclassify.py
99.6% <100.0%> (+<0.1%)
:arrow_up:

Codecov Report

Merging #95 (2adec7b) into master (c9bb671) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master     #95   +/-   ##
======================================
  Coverage    86.3%   86.3%
======================================
  Files          10      10
  Lines        1553    1558    +5
======================================
+ Hits         1340    1345    +5
  Misses        213     213

Impacted Files
Coverage Δ

mapclassify/classifiers.py
79.1% <100.0%> (-<0.1%)
:arrow_down:

mapclassify/tests/test_mapclassify.py
99.6% <100.0%> (+<0.1%)
:arrow_up:

There's some issue with CI but I think we can merge.

There's some issue with CI but I think we can merge.

For some reason the env solver takes a long time on a few of the ubuntu jobs. I think bumping up the timeout might fix it. If it doesn't, we can always exclude those. I agree, that the pr is good to go, but I want to wait on this last job to see if the timeout works. WIll merge afterwards.


Better Table config validation

As mentioned in #5915 and #5899 we need a better way to validate table config. This includes following checks (not exhaustive):

Validate column names : should match the ones in schema
Time column check: name and type should be consistent with schema
Table name sanity check (no space)

Indexing config validation

Ensure that Inverted Index columns are not present in no dictionary columns
Ensure that Bloom filter columns are not present in no dictionary columns

Retention and pushType

Currently retention does not work if pushType is null (for real-time table). Check for a case where pushType is null and retention is configured for a table.

Tenant validation

Ensure valid tenants are configured for server and broker

Validation end point

We need a controller API for validating table and schema config.

One more: https://github.com/apache/incubator-pinot/issues/5730

https://github.com/apache/incubator-pinot/issues/5900

One more check: Currently retention does not work if pushType is null (for real-time table). Check for a case where pushType is null and retention is configured for a table.

With all the changes proposed/added, it will be useful if a utility is also provided to validate an existing tableconfig. Many of them are tightening the (lax) rules from before, and are valid. It will be unfortunate if an existing installation suddenly stopped working because code elsewhere (not just in the table addition path) starts assuming things about the tableconfig.

+1 to a utility to validate, we can add a validate endpoint in the controller

Updated ticket description with all the suggestions.

Another use case: Validate that the bloomFilterColumns aren't BYTES type since that's not supported at this point.

Another use case: Validate that the bloomFilterColumns aren't BYTES type since that's not supported at this point.
cc @kishoreg @icefury71

Looks like this should be supported, skipping validation for this particular thing

Another use case: Validate that the bloomFilterColumns aren't BYTES type since that's not supported at this point.
cc @kishoreg @icefury71

Looks like this should be supported, skipping validation for this particular thing

@icefury71 Do you mean bloomFilterColumns supports BYTES columns? From which version/

What I meant is - technically it should be supported (it's not today and we
should probably fix that).
On Tue, Sep 29, 2020 at 12:31 AM Buchi Reddy Busi Reddy <
<EMAIL_ADDRESS>wrote:

Another use case: Validate that the bloomFilterColumns aren't BYTES type
since that's not supported at this point.
cc @kishoreg https://github.com/kishoreg @icefury71
https://github.com/icefury71
Looks like this should be supported, skipping validation for this
particular thing
@icefury71 https://github.com/icefury71 Do you mean bloomFilterColumns
supports BYTES columns? From which version/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700507663,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFRXV5JMUFTZ7U66D3KOFTSIGEN7ANCNFSM4QOTJTBA
.

--
Thanks and regards
Chinmay Soman

+1 to a utility to validate, we can add a validate endpoint in the controller

@kishoreg @mcvsubbu Seems like we already have a /tables/validate end-point in the Table API. This should be sufficient ?

yes, that works as long as the same validations are performed. thanks

yes, that works as long as the same validations are performed. thanks

Yes, its calling the same validation function underneath.

We can also add checks on partition config where the table can be partitioned on at most one column

+1
Another use case is the upcoming upsert. There are several expectations for upsert table like primary key in schema, replica group setup, routing by replicas group, partition config, ingestion via LLC etc


added testing for download_file() function

Added one test to see if the download_file() functions correctly

Would like to see more tests before this is merged. Also, I have some opinions on the name scheming, but not ready to change them yet.


Added reference to ANSIBLE_REMOTE_USER

I was struggling for a while to figure out how to set the username Ansible should use to connect. Rather than modifying the inventory / ansible.cfg as suggested in (here)[https://github.com/philpep/testinfra/issues/53], I thought it would make more sense to use one of Ansible's many configurable environment variables.
I updated your backends doc to reflect that there is an environment variable one can use to control the remote user.
Any feedback / suggestions are gratefully accepted :).

Hi,
Testinfra use ansible API, so all environment variables and configurations that affect ansible behavior applies to testinfra as well. I'd be better to explain this in the docs and add reference to relevant ansible docs.
Thanks !

You're right, that makes more sense.


chore: cleanup globals in pkg/cgroup

cleanup globals in pkg/cgroup

Double check if we need to introduce locking

@sthaha @sunya-ch can you take a look? thanks

requesting changes to consider

use of init
remove ensureCacheInitialised
let cache handle when Mutex should be locked / unlocked

Hi @sthaha
I incorporated the suggested changes. Please let me know if there's anything else.
Thanks
Maryam

@sthaha sorry to poke again, can you have a look at the updates?
Thanks again

@sthaha sorry to poke again, can you have a look at the updates?
Thanks again

Sorry, this completely slipped my radar :( ..


Modify the schema config path to be based on cwd

The PR fixed problem of relative path by reading up the schema.json path based on the current working directory:
{
  "scripts": {},
  "graphql": {
    "file": "../schema.json"      => Based on cwd
  }
}

Awesome! Thanks also for adding the test case!

I've just published a new version.

Perfect! 👍


Bug: MicrophoneProcess Showing number, not service name

Please make sure that the issue you're planning to report is not already registered :)

Describe the bug
So instead of showing the process, I just get a number.

To Reproduce
Steps to reproduce the behavior:
Run the microphone and then look in the sensors config
Expected behavior
There used to be the process name in the last known value
Screenshots
If applicable, add screenshots to help explain your problem.
Above
Misc info (please complete the following information):

Windows build (ideally screenshot/info of winver.exe output):

Windows' UI language:
ENG
HASS.Agent version:

Please check what's applicable (multiple answers possible):

[x] Installed via installer
[ ] Installed manually
[x] Problem occurs in HASS.Agent
[ ] Problem occurs in Satellite Service

Additional context
Add any other context about the problem here.
Logs
If possible, please provide the logs of HASS.Agent and - if applicable - the Satellite Service. You can find HASS.Agent's logs by going to the main window, then Configuration -> Logging -> open logs folder. The Satellite Service's logs are in the same window, but the Satellite Service tab -> open service logs folder.

Hello,
Have you checked the attributes? The specific process names are there, example:


CLIENTS:  OpenAI Initialization

Closes #66

Closing this - we will circle back to discuss this issue first.


Jacoco report exclude 122

Summary of change
Attempt to Narrowing the Focus of sonarqube code coverage regarding the files/paths mentioned in the issue.
Related issue
Closes #122
Pull request checklist
Please keep this checklist in & ensure you have done the following:

[x] Read, understood and adhered to our contributing document.

[x] Ensure that you were first assigned to a relevant issue before creating this pull request
[x] Ensure code changes pass all tests

[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.

[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request

[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123

[x] Set this pull request to 'draft' if you are still working on it

[x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

@Wildschut Apologies for the late reply. Thanks for the recap!
This looks good to me, so I'll merge this in. If it doesn't change the code coverage, I'll edit the exclusions manually in SonarCloud.
Thanks for your help with this!

@Wildschut Apologies for the late reply. Thanks for the recap!
This looks good to me, so I'll merge this in. If it doesn't change the code coverage, I'll edit the exclusions manually in SonarCloud.
Thanks for your help with this!


Nmahendru/autoversion digest update

The intent here is to add digests for all the autoversioned package versions.
As per the current usage patterns, that's how the manifest files are updated and so we want that the digest values also get autoupdated when autoversioning is applied.
Some tests and some utility functions have been refactored/moved around to avoid circular dependency problems. Open to suggestions if there is a cleaner approach.

So I actually played around with this a bit recently and unfortunately it's not usable as-is :( When it rewrites the HCL file it deserialises it into a Go struct (which makes sense), but when it is re-serialised it loses all of the comments, and reorders the file. It will have to be modified to use the HCL AST, like auto-versioning does.

Superseded by #332 - I folded some of the code from this PR into that one.


Multi-series line chart tooltip line disappears when hover inside

When I have a multi-series line chart and I hover inside the grouped tooltip, the lines and bulbs go away. We should maintain those until focus is left.

This has been fixed.


Add more filter categories/options to get more precise results

More filters needed for exact and accurate results

@sahitya-chandra Specifically, you only need to add more categories on the filter

@dotslashbit So i need to add more option to this accordian only.

Yes

and can you tell me where can i find my github api key so that i can set it up locally

can you tell me specifically what more categories should i add

@sahitya-chandra sure I can help you with that.
Here's where you can get your API key --> https://github.com/settings/tokens
Create the classic token

We are fetching the categories from the tags

You can add categories like data visualization, data analytics, operating system, browser, etc.
Just do one thing, after adding each category, always check if the category is working correctly or not. First check if issues are being fetched or not, then click on some of the issues to check if the tag is available on those repos or not
If you need any help just let me know.
I appreciate your contributions


table pointer is NULL

After creating a hashmap the hb->table pointer is null. Any operation will produce memory errors due to this. calling hashmap_reserve will result in a memory error due to the null pointer.
hashmap_rehash() will produce a memory error because of applying an offset to the null pointer.

Make sure to call hashmap_init() prior to using the hashmap.

Yes, I do. hashmap_base_init() will clear the struct but the table pointer is never allocated. It's just null.

The data structure doesn't allocate any memory until you put or reserve. This is by design. If you are referring to this code in rehash() https://github.com/DavidLeeds/hashmap/blob/dcf30be31b811e73bd22a6a4a40a6bead56d82b4/src/hashmap.c#L187, the operation on the null pointer is not an issue, because we are never accessing memory at that location. It is just calculating an offset.
What compiler are you using? This code has been tested on GCC and Clang, but I suppose it is possible that it could run into an issue with another compiler. This project has been fairly widely used, including in several products in at least two companies, so I hesitate to suspect there is a fundamental issue with the code.

Yes that is the code in question. Compiler is clang and the error comes from the memory debugging I have turned on (in Xcode) so it's not a compiler or building problem. With no diagnostics enabled it would run just fine. Personally I prefer 'clean' code in that regard so it would be nice if a null pointer was handled differently here. I changed it to return early if the pointer is null without doing the comparison.

I would argue that there is nothing unclean about &old_table[old_size], since it is identical to &(*(old_table + old_size)). Nothing actually attempts to access the memory at old_table + old_size = 0 + 0 = 0.
That said, we could certainly change this to avoid triggering static analysis tools that aren't aware of this.
for (entry = old_table; entry < old_table + old_size; ++entry) {

Yeah I don't really claim the code is unclean, just that the memory diagnostic is warning about it when running the code and I like to avoid that even though it's something that would be turned off in a release build. Same as I prefer to get any compiler warnings fixed when building.
Overall I like the hashmap so far. I was looking for something that is simple, I can provide the key, hash and compare functions and does not depend on lots of STL stuff.
The simple fix that works is to return right before the for-loop if old_table is NULL. That is the end result even if the for-loop comparison is done.
	if (old_table == NULL) return 0;

The data structure doesn't allocate any memory until you put or reserve. This is by design. If you are referring to this code in rehash()
https://github.com/DavidLeeds/hashmap/blob/dcf30be31b811e73bd22a6a4a40a6bead56d82b4/src/hashmap.c#L187
, the operation on the null pointer is not an issue, because we are never accessing memory at that location. It is just calculating an offset.
What compiler are you using? This code has been tested on GCC and Clang, but I suppose it is possible that it could run into an issue with another compiler. This project has been fairly widely used, including in several products in at least two companies, so I hesitate to suspect there is a fundamental issue with the code.

UBSan detect that bit of code as undefined behaviour and should been changed

This project has been fairly widely used, including in several products in at least two companies, so I hesitate to suspect there is a fundamental issue with the code.
You can add my company, PercayAI .  We use it extensively in both our academic and commercial bioinformatics tool backends.


Incorrect link to CODE_OF_CONUCT.md corrected

The incorrect link to CODE_OF_CONUCT.md is corrected.

Thanks for catching that!


cache-read-only=true for scheduled workflows on main branch

The default expression for cache-read-only value is:
${{ github.ref_name != github.event.repository.default_branch }}

But github.event.repository.default_branch is not set by GA on scheduled (cron) workflow runs.
Hence cache-read-only is resolved to true not writing to cache during scheduled runs on the main branch.
For CI configrations where workflows on main line are run via scheduling exclusively (no manual workflow runs happening) cache will never be written to.
I believe this behavior is worth documenting.
Unless there's a solid replacement to github.event.repository.default_branch for obtaining the default branch name (didnt find one in ga contexts).

@kkolman you are right - that's why I changed value of cache-read-only to:
${{ github.ref != 'refs/heads/develop' }}
And now scheduled runs at least try to write cache. The problem is they are failing with following error:
Save Gradle User Home failed in 'beforeSave': Error: ENOENT: no such file or directory, lstat '/Users/runner/.gradle/caches/7.4.2/kotlin-dsl/scripts/290aeeb3033fad5386fbca5f7db24fe3'
I think it may be related to scheduled workflow runs because when I tested action triggered by PR cache was written successfully.

Thanks for the reports. I think we should be able to detect when we are running with a scheduled trigger and avoid setting cache-read-only in this case.
However, I'm having trouble getting a scheduled workflow to execute: I added a ci-schedule.yml workflow and can run it manually via workflow_dispatch, but it never seems to run via the cron trigger. https://github.com/gradle/gradle-build-action/actions/workflows/ci-schedule.yml
Any ideas?

@bigdaz I see now it is being scheduled :).  However, my error with Save Gradle User Home failed in 'beforeSave': Error: ENOENT: no such file or directory, lstat '/Users/runner/.gradle/caches/7.4.2/kotlin-dsl/scripts/290aeeb3033fad5386fbca5f7db24fe3 is not related with scheduled runs. I tested it again and now I have this error everytime cache-read-only is false.

@AndrzejPw Can you please raise a separate issue for your problem, since it appears unrelated to this reported issue? If you can provide a link to a failing build that would be great, otherwise the full stack trace would help.

Thank you - it does not appear anymore (maybe sth was wrong with github environment). If it happens again I will report it.

@AndrzejPw FYI there was another report of the ENOENT: no such file or directory from an internal project that allowed me to reproduce, diagnose and fix this issue: #408


fix: translation of server errors for actor certs

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (897bbad) 9.95% compared to head (928fb1a) 16.51%.

Files
Patch %
Lines

...Api/Controllers/MarketParticipantControllerBase.cs
0.00%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##            main    #2344      +/-   ##
=========================================
+ Coverage   9.95%   16.51%   +6.56%
=========================================
  Files         89      106      +17
  Lines       4281     4662     +381
  Branches     795        0     -795
=========================================
+ Hits         426      770     +344
- Misses      3845     3876      +31
- Partials      10       16       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Investigate ways to better handle nuget related failures

I recently stumbled into some weird behavior of the current nuget support in dotnet interactive that could likely be improved.

When there is a request made using #r "nuget:xxx" to load a package and the package is not found (misspell/whatever else), executing that cell will error out on that package even if you correct the #r line or completely remove it.
It would be useful if packages that failed to install as opposed to packages that failed to load were dropped from the list.
In that case fixing the line will work without restarting the kernel. Also I don't see any risk here because no assemblies of the package should be loaded at this point.
Another thing is an issue where such failed packages actually show up even if you execute a cell where you don't request them.
As in, if you #r "nuget:aaa" in one cell and execute it, then #r "nuget:bbb" in another cell and execute it,
it will try to install the aaa nuget in cell1 and both aaa and bbb nugets in cell2, even though aaa was not requested in cell2.
Maybe there are also other improvements that could be made regarding handling of failed package installs/loads/whatever.

It is generally not intuitive that you have to restart the kernel in such failure cases when the kernel state was not inreversibly modified.

Related: #319


Docs: add some documentation about ActiveQuery class

When using gii to create a model, it asks to the user to create or not an ActiveQuery class paired with the model just being created.
I'm looking at official guide, at http://www.yiiframework.com/doc-2.0/guide-db-active-record.html. In this page, of course, there is nothing about ActiveQuery. It's right, but in all the section about "Working with databases" there is no info about this class.
What is its goal? When to create, when not? Some real-world examples of when it could be usefull. Etc..
Thanks for this marvellious framework, I'd thank you every day I use it.

Just a postfix: I found what I was looking for at this url: http://www.yiiframework.com/doc-2.0/guide-db-active-record.html#customizing-query-classes
Probably, a brief note about this topic in the Active Record guide could be enough. The important is that information is available and more easily findable.

ActiveQuery is mentioned 46 times around the docs.
At http://www.yiiframework.com/doc-2.0/guide-db-active-record.html it is mentioned 38 times.
There is a specific topic related to it:
http://www.yiiframework.com/doc-2.0/guide-db-active-record.html#customizing-query-classes
I can't see what else can be improved here.


fix: Module '"@wagmi/core"' has no exported member 'Chain

Bug Report
Swaplace version

Current behavior
We are importing Chain from @wagmi/core to add Kakarot to the lists of chains, and therefore establish a way to communicate with the network through wagmi, but we are getting the error Module '"@wagmi/core"' has no exported member 'Chain'
Expected behavior
The Chain should be imported with no errors with the @wagmi/core ^2
Steps to reproduce

git clone this repository (develop branch)
run the command npm i  --legacy-peer-deps
check the file wagmi-custom-chains.ts

Related code
wagmi-custom-chains.ts
Other information

As we can see here, the import in Swaplace is the exactly same way as the documentation.

Versions
"@wagmi/core": "^2.6.9",
"viem": "^1.19.11",
What have we tried

Updated both wagmi and viem to be a version higher than 2, but still it didn't work.

Closed by #330


The Runtime category ? is missing

Trying to run IntelliTest can result in things like "Need help to find Types" that comes up in the warnings as "runtime warning", not as a "domain" warning.
I'm not sure if the program is wrongly displaying the warning type or this document is incorrect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 426d7e5f-94c3-2947-fe82-c62136032bff
Version Independent ID: b6e7abd7-168f-37cd-a548-13c581862e88
Content: Warnings and errors - Visual Studio
Content Source: docs/test/intellitest-manual/warnings-and-errors.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @jillre
Microsoft Alias: jillfra

@StingyJack Thank you for the feedback, assigning this to the author for review.
Type runtime is not listed as a category.  Please attach additional details and/or a screenshot so we can further investigate.

@msebolt - here is an image that shows the Runtime Warnings

I deleted the intellitest created project I had with the specific "Need help to find Type", but can probably find it in my autoshelves if the above is not satisfactory to show the Runtime category

Checking on this...

Updating doc, per product unit feedback

@TedA-M I'm not clear on what was fixed or done here. Is there a PR or commit link somewhere that I'm missing?

@StingyJack I'm not sure why it said I closed this. I made a couple pencil edits to fix blocking issues in this PR https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/6107, and merged that PR..

@StingyJack We often include special comments that auto-close associated issues when the PR gets merged into master. It should be live around 5 PM tonight. The PM suggested I change the Domain category to "Domain or Runtime".


Update generated protobuf files

Regenerate protobuf stubs using newer protobuf because old stubs are not compatible with new protobuf versions.
Pin protobuf dependency to use the same version in runtime for which we generated these stubs.
Simplify instructions how to generate them. It only uses dependencies installed by poetry, so should be reproducible on different systems.

I tested that it works correctly with ha-google-home integration.
Fixes #257

Awesome stuff! I wonder if we should just make it a github action that we can manually trigger, or even better on a periodic schedule, like once a month of smth, @KapJI :)

We can create manually triggered action to regenerate stubs and create a PR but they still need to be tested manually before merging. And I'm not sure yet what the strategy should be for updating protobuf. Another thing which is probably more useful is keeping deps in sync with pinned versions in HA. And it should be easier to implement. Maybe one day I have an inspiration for that :)


[Bug]: Predators depsawn

Mod Version
0.0.8
Mod Loader
Fabric
Mod Loader Version
Fabric Loader 1.21.1
Describe the bug
pheonix says preds despawn and he isnt sure about queens
To Reproduce
1.spawn
2.depsawn

even with nametags they despawn which shouldnt be the case


No module named 'crowd_nav.configs'

File "test.py", line 172, in
main()
File "test.py", line 56, in main
from crowd_nav.configs.config import Config
ModuleNotFoundError: No module named 'crowd_nav.configs'
Hi, can you provide the configs? thanks!!!

Nice catch! I just added them in the most recent commit, please git pull again.

Nice catch! I just added them in the most recent commit, please git pull again.

Thanks, I have run the code successfully!!!


issues about versin based on pytorch 1.0.0 and python 3.6

hi! thanks for this awesome work! and i got some problems when i try to use the branch which pytorch=1.0.0, python=3.6. the first one is that i can't download the project by run"git clone git@github.com:HKUST-Aerial-Robotics/Stereo-RCNN.git"  it hints me that"Permission denied (publickey). fatal: Could not read from remote repository."
and then, i downloaded it by the github bottum, however, more problems appeared, such as: error: invalid command 'develop' , when i run the command "python setup.py build develop",
could you please help me to run this branch correctly?
thanks in advance

that problem is done, because i didn't add ssh key in the github setting,   thanks for reading anyway!

Hi. I am experiencing the same problem, but never heard of ssh keys before. How can I find the ssh key to add and how do I add it?


Acknowledge tag info in .DS_Store file

What's the Problem?
Mac store tag information in a .DS_Store. When copy files from Mac to Windows, I don't want the tag information be lost.
Solution/Idea
Files app parse the  .DS_Store file in the folder, extract the tag info, and store to FIles's own database. Probably add a button, if there is a .DS_Store file, user can click the button to load tag info, otherwise the button is disabled.
It's OK that only support Mac's default tag.
Alternatives
Provide a script that  extract the tag info from .DS_Store, and store to FIles's own database.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
No response
Windows Version
No response
Comments
No response

Hi, are you sure the ds_store contains the tag? I'm aware of it containing only stuff like folder icon and layout.
Could you post a sample of a ds_store file?

Sorry my bad. I tried to verify, it turns out adding/removing a tag will not change ds_store, which means the tag info is stored somewhere else.
Close this.

No problem, tags on Mac os are stored within the files themselves as extended attributes. Moving files to a different filesystem e.g Windows drive or even FAT32 USB key will loose tag info.


package: implemented load and parsing of elm packages and dependencies

Now FsLoader takes a Package, which knows how to resolve module names
and transform them into proper absolute file paths taking into account
all package source directories and resolving files from dependencies
as well.

Codecov Report

Merging #13 into master will increase coverage by 0.2%.
The diff coverage is 78.29%.

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
+ Coverage   75.86%   76.07%   +0.2%
=========================================
  Files          15       17      +2
  Lines        1761     1889    +128
=========================================
+ Hits         1336     1437    +101
- Misses        358      371     +13
- Partials       67       81     +14

Impacted Files
Coverage Δ

parser/parse.go
6.15% <0%> (-0.3%)
:arrow_down:

package/version.go
100% <100%> (ø)

package/package.go
76.69% <76.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50565a...73d4db9. Read the comment docs.


WIP - MTS Notification extended regression pack scenarios

Don't forget to add any new Step Definitions to the docs:
/Users/karl.beckett/MOTDEV/mot-automated-testsuite/docs/step-definitions.md

Also think about added unit tests to the new methods in
mot-automated-testsuite/src/test/java/uk/gov/dvsa/mot/framework/WebDriverWrapperTest.java


Don't fail when adding a service to an environment with no pipelines.

What type of PR is this?

/kind bug

What does this PR do / why we need it:
Don't fail when you provide a service with an image to an environment with no pipelines
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
#102
How to test changes / Special notes to the reviewer:

/lgtm
/approve

/lgtm cancel
/approve cancel

@sbose78 Are you ok to go ahead with this?

@sbose78 Are you ok to go ahead with this?

/lgtm
/approve

/lgtm
/approve


feat: lake: run_io` execute IO at term elab time

Workaround for #2631 to avoid defining elaborators in a configuration file for the common case of running IO.

@semorrison As our primary community ambassador, do you think run_io is good name for this elaborator?

I think #2631 is not the issue you intended to link to, or otherwise I don't understand the connection.

@semorrison

I think #2631 is not the issue you intended to link to, or otherwise I don't understand the connection.

Oops, yeah, typo: it was suppose to be #2632 (I updated the description).


[Problem] Setting multiple permissions based on different roles for the same application can result in login failure

I have set up two roles for the same organization in the role, one for HR and one for admin

And two policies have been configured in the permissions: hr has read permission, and admin has all permissions

When both permissions are enabled, the login of both users with configured permissions displays unauthorized operations

Only when one permission is closed can another account operate. Is it just the design or a bug?

@qq1176914912 tested with no issue. Make sure the application is correct. You can debug CheckLoginPermission function


Drone with suspended rope?

Hi,
I am interested in creating an environment where there is a rope attached to the drone and it is potentially carrying a payload. Similar to what is described in this research paper.
Do you have an idea of how to realize this with PyBullet? I have not found any established solutions on google yet.
Thanks

That seems like a fun problem! If you are willing to add this to the repo, it would be a great addition.
To answer your question, you can probably define the rope as a series of links. I would define a URDF file for the rope and weight together. Then when you spawn in the drone, you can use PyBullet's set constraint to attach the rope to the drone.
I will post some boilerplate example code here later in the day.

@defrag-bambino It took a whille before I had the time to do this, but here is an example:
ball_and_string.urdf
<?xml version="1.0"?>
<robot name="ball_and_string">

  <!-- Base link (fixed in space) -->
  <link name="base_link">
    <visual>
      <geometry>
        <box size="0.01 0.01 0.01"/>
      </geometry>
    </visual>
    <collision>
      <geometry>
        <box size="0.01 0.01 0.01"/>
      </geometry>
    </collision>
    <inertial>
      <mass value="0.05"/>
      <inertia ixx="0.001" ixy="0.0" ixz="0.0" iyy="0.001" iyz="0.0" izz="0.001"/>
    </inertial>
  </link>

  <!-- Link 1 -->
  <link name="link_1">
    <visual>
      <geometry>
        <cylinder length="0.05" radius="0.01"/>
      </geometry>
    </visual>
    <collision>
      <geometry>
        <cylinder length="0.05" radius="0.01"/>
      </geometry>
    </collision>
    <inertial>
      <mass value="0.01"/>
      <inertia ixx="0.00001" ixy="0.0" ixz="0.0" iyy="0.00001" iyz="0.0" izz="0.00001"/>
    </inertial>
  </link>
  <joint name="joint_base_link_1" type="continuous">
    <parent link="base_link"/>
    <child link="link_1"/>
    <origin xyz="0 0 -0.05" rpy="0 0 0"/>
    <axis xyz="1 0 0"/>
    <dynamics damping="0.000001" friction="0.000001"/>
  </joint>

  <!-- Link 2 -->
  <link name="link_2">
    <visual>
      <geometry>
        <cylinder length="0.05" radius="0.01"/>
      </geometry>
    </visual>
    <collision>
      <geometry>
        <cylinder length="0.05" radius="0.01"/>
      </geometry>
    </collision>
    <inertial>
      <mass value="0.01"/>
      <inertia ixx="0.00001" ixy="0.0" ixz="0.0" iyy="0.00001" iyz="0.0" izz="0.00001"/>
    </inertial>
  </link>
  <joint name="joint_link_1_link_2" type="continuous">
    <parent link="link_1"/>
    <child link="link_2"/>
    <origin xyz="0 0 -0.1" rpy="0 0 0"/>
    <axis xyz="0 1 0"/>
    <dynamics damping="0.000001" friction="0.000001"/>
  </joint>

  <!-- Ball link -->
  <link name="ball">
    <visual>
      <geometry>
        <sphere radius="0.05"/>
      </geometry>
      <material name="black">
        <color rgba="0.0 0.0 0.0 1.0"/>
      </material>
    </visual>
    <collision>
      <geometry>
        <sphere radius="0.05"/>
      </geometry>
    </collision>
    <inertial>
      <mass value="0.1"/>
      <inertia ixx="0.0001" ixy="0.0" ixz="0.0" iyy="0.0001" iyz="0.0" izz="0.0001"/>
    </inertial>
  </link>
  <joint name="joint_link_last_ball" type="continuous">
    <parent link="link_2"/> <!-- Change to the last link name if more links are added -->
    <child link="ball"/>
    <origin xyz="0 0 -0.1" rpy="0 0 0"/>
    <axis xyz="1 0 0"/>
    <dynamics damping="0.000001" friction="0.000001"/>
  </joint>

</robot>

main.py
import numpy as np

from PyFlyt.core import Aviary

# the starting position and orientations
start_pos = np.array([[0.0, 0.0, 3.0]])
start_orn = np.array([[0.0, 0.0, 0.0]])

# environment setup
env = Aviary(
    start_pos=start_pos,
    start_orn=start_orn,
    render=True,
    drone_type="quadx",
    drone_options=dict(
        drone_model="primitive_drone",
        use_camera=True,
        camera_fps=30,
    ),
)

# spawn in the pendulum
pendulum_id = env.loadURDF(
    "./ball_and_string.urdf",
    basePosition=np.array([0.0, 0.0, 2.9]),
    useFixedBase=False,
    globalScaling=1.0,
)

# register all new bodies with Aviary
env.register_all_new_bodies()

# create a constraint between the base of the pendulum object and the drone
env.createConstraint(
    env.drones[0].Id,
    -1,
    pendulum_id,
    -1,
    env.JOINT_POINT2POINT,
    np.array([0.0, 0.0, 0.0]),
    np.array([0.0, 0.0, 0.0]),
    np.array([0.0, 0.0, 0.1]),
)

# simulate
env.set_mode(7)
env.set_setpoint(0, np.array([0.0, 0.0, 0.0, 5.0]))
for i in range(5000):
    env.step()

Thanks!
Right now, the rope seems kind of stiff. Even when allowing the X and Z axes of the joint to rotate aswell (<axis xyz="1 1 1"/>).
I've found this forum post of someone achieving a more rope-like behavior, but they have issues with the stability of it.
What do you think?

I would argue for using the URDF file since it's a better configuration method, the same things can be achieved.
I also wouldn't do axis=(1,1,1). This actually makes it rotate around an offset axis with a vector of x=1 y=1 z=1. Instead, you'll want to make very short links and alternate between (1,0,0), (0,1,0) and (0,0,1). Perhaps it it stiff because of the damping parameter, I will play with it between today and tomorrow and see how I can get the links to move freely.
You'll have to define the many links manually yourself in the URDF tho, I'm too lazy to fopy and paste it and shift coordinates at this time 🫢.

Another alternative to have true ball joints is maybe use an SDF file.

@defrag-bambino After messing around with it for a bit, this seems to work. Essentially, I approximate the string as a 0 mass, 0 collision entity, with a maximum extension length. This allows us to approximate the string as a prismatic joint, but careful attention must be made to ensure that the anchor and the ball both have negligible moments of inertia. Here's what worked for me:
ball_and_string.urdf
<?xml version="1.0"?>
<robot name="ball_and_string">

  <!-- Ball link -->
  <link name="ball">
    <visual>
      <geometry>
        <sphere radius="0.1"/>
      </geometry>
      <material name="black">
        <color rgba="0.0 0.0 0.0 1.0"/>
      </material>
    </visual>
    <collision>
      <geometry>
        <sphere radius="0.1"/>
      </geometry>
    </collision>
    <inertial>
      <mass value="0.1"/>
      <inertia ixx="0.000001" ixy="0.0" ixz="0.0" iyy="0.000001" iyz="0.0" izz="0.000001"/>
    </inertial>
  </link>

  <!-- Anchor link -->
  <link name="anchor">
    <visual>
      <geometry>
        <box size="0.03 0.03 0.03"/>
      </geometry>
      <material name="blue">
        <color rgba="0.0 0.0 1.0 1.0"/>
      </material>
    </visual>
    <inertial>
      <mass value="0.001"/>
      <inertia ixx="0.000001" ixy="0.0" ixz="0.0" iyy="0.000001" iyz="0.0" izz="0.000001"/>
    </inertial>
  </link>

  <!-- Sliding joint -->
  <joint name="ball_to_base" type="prismatic">
    <parent link="ball"/>
    <child link="anchor"/>
    <origin xyz="0 0 0.5" rpy="0 0 0"/>
    <limit lower="0.0" upper="1.0" effort="0.0"/>
    <axis xyz="0 0 1"/>
  </joint>

</robot>

main.py
import numpy as np

from PyFlyt.core import Aviary

# the starting position and orientations
start_pos = np.array([[0.0, 0.0, 1.5]])
start_orn = np.array([[0.0, 0.0, 0.0]])

# environment setup
env = Aviary(
    start_pos=start_pos,
    start_orn=start_orn,
    render=True,
    drone_type="quadx",
    drone_options=dict(
        drone_model="primitive_drone",
        use_camera=True,
        camera_fps=30,
    ),
)

# spawn in the pendulum
pendulum_id = env.loadURDF(
    "./ball_and_string.urdf",
    basePosition=np.array([0.0, 0.0, 1.0]), # start drone pos - start string length
    useFixedBase=False,
    globalScaling=1.0,
)

# register all new bodies with Aviary
env.register_all_new_bodies()

# create a constraint between the base of the pendulum object and the drone
env.createConstraint(
    env.drones[0].Id,
    -1,
    pendulum_id,
    0,
    env.JOINT_POINT2POINT,
    np.array([0.0, 0.0, 0.0]),
    np.array([0.0, 0.0, 0.0]),
    np.array([0.0, 0.0, 0.0]),
)

# disable motor on the prismatic joint
env.setJointMotorControl2(
    pendulum_id,
    0,
    env.VELOCITY_CONTROL,
    force=0,
)

# simulate
env.set_mode(7)
env.set_setpoint(0, np.array([0.0, 0.0, 0.0, 3.0]))
for i in range(5000):
    env.step()

Thanks!
I've made this into a gym env. Here's my fork: https://github.com/defrag-bambino/PyFlyt-BallInCup.
I guess the reward function is subject to change, as it probably is not optimal yet. Until now I've only managed to train an agent that swings the ball around itself to gather reward. I am not sure if the "rope" is even capable of properly reducing its length, i.e. allowing the ball to land exactly on top of the drone.

There is this Deepmind Control Suite env 2D "ball in cup", which uses tendons as the joint. But it seems like URDF does not support this. However, the MJCF format does and it seems PyBullet can load this aswell?

Ok, I've updated the reward function. It manages to swing the ball onto the drone's top. However, it seems to collide with something invisible there? Maybe I'll have to add a "catch area" of sorts.

This looks really good, if you could make a PR when it's ready, I could pick it up, clean it up, and make it official.

Could you upload a video here of:

Working swing up
Collision with the invisible thing

Here's one with a smaller ball
Screencast from 16.08.2024 10:08:32.webm

@defrag-bambino could you make a PR of your branch to the ball_in_cup branch? I'd like to test run your environment using my learning stack


Added option to disable runtime exceptions

This pull request adds the option disable_visit_errors, which disables the raising of errors during runtime. Parse errors will still be raised, but all exceptions during Node.visit(object) are disabled and nil is returned instead.
We process very large amounts of data and sometimes objects do not have quite the right properties. So we have to catch InvalidArityError and InvalidTypeError since there is no way to preemptively check for these errors. This has quite a large overhead, especially in JRuby.
I did some benchmarks with objects that always result in an exception, and this branch had a 40% speed increase in MRI, and a 500% increase in JRuby.
When not raising errors, there's no measurable difference between this branch and master, and also no difference between disable_visit_errors being off or on.

Sorry for the slow turn-around on this. I had a change to update the jmespath gem to the latest compliance tests, add support for the new features and I took the opportunity to test this and merge it in. Thanks for the contribution. This should go out with a new release shortly.


CompilerGLSL should flip texture coordinate Y

Metal compiler has the flip_frag_y, probably should apply the same to GLSL one, otherwise vulkan shader translated to GLSL appears with UV flipped.

I am not the right one to answer for why Metal has the flip_frag_y flag, but flipping UV does not make sense for GL. The only difference between GL and Vulkan is the origin for the final backbuffer.

The strange stuff is when I render in 3D space the texture UV's are flipped while orthographic sprite rendering works well without UV flipping.

Vulkan has different clip-space conventions than GL, which could be what you're seeing, but still, shaders are not the best place to apply any flipping, if any place, it should be gl_Position in vertex, not UVs.

You mean -1..1 space for gl and 0..1 for Vulkan?

Y = -1 is logically top in Vulkan, and bottom for GL. However, this only matters when rendering to the swapchain, not anywhere else. The clip -> window transform is essentially the same in Vulkan and GL (sans the depth range, but that's not relevant here).

Issue was from my side, I was flipping for some reasons the 3D cube UV's, closing now.
Thank you


Refactor number-formatter to use integers

Make it print precise numbers if they are small enough.

Closes #1567.

This change is

The log disappeared because it shouldn't had sneaked in :)
AFAIK we are already limited to u64 in other places, and f64 could not be used to represent the exact number > max of u64, so the test didn't make much sense anyway (I think). We might use u128, but to my knowledge u64 is a lot and still enough.
As for the TODO test, it is complicated. We might just ignore that, or stop using from logarithms and float number altogether. I put the test here as as reminder.

Reviewable is down at the time of writing :)

For what I've seen in the API part, we are using Django's IntegerField which is i32. It becomes f64 because JS only supports f64.

For what I've seen in the API part, we are using Django's IntegerField which is i32. It becomes f64 because JS only supports f64 (and max integer 2^53 - 1).

Keep in mind that within the next week we will be using influx to get these numbers.

because JS only supports f64 (and max integer 2^53 - 1).

We are not restricted to JS here, but Rust instead since this ultimately is compiled to WebAssembly.

Keep in mind that within the next week we will be using influx to get these numbers.

Still u64 is two times more than enough (i64) :)

because JS only supports f64 (and max integer 2^53 - 1).

We are not restricted to JS here, but Rust instead since this ultimately is compiled to WebAssembly.

I was trying to say that so far  we were limited by JS and were not actually using large enough numbers, or somewhere there were incorrect appearance.


MAX RETRIES configurable

Break out the MAX RETRIES to a parameter in the cdk_app.yml to allow the user to choose how long to wait.  In larger AWS accounts this could be important.
https://github.com/duo-labs/cloudmapper/blob/1e60e1fb0bf5ad71d8514c2f5a3a2696b130f4cc/commands/collect.py#L19

This PR added a command-line parameter to bump the retry count: https://github.com/duo-labs/cloudmapper/pull/614/files#diff-f6fe91e3358619090b886027361d2b1eR498
I'm not sure when one of those retries happens versus the other, so I don't know what which would be best to make configurable from the CDK, but I think the command-line parameter from that PR would be easiest.

I'd probably just break this out to a setting in the cdk yaml configuration.  For my accounts 10 seemed to be the sweet spot.


Add [Illumina_NovaSeq_6000] to [platform]

List the new value
Value: Illumina_NovaSeq_6000
Provide definition and source for the new value
Definition:
Source url: https://www.illumina.com/systems/sequencing-platforms/novaseq.html
Are there similar but not-quite-right values?
Please list if applicable.
Additional comments

Closed by #78


File Not Found

code-server version: server/1.32.0-310 linux-x64 node-v8.15.0
OS Version: Ubuntu 18.04

Description
Hi, I added a new task for a build using the type "Other". I edit tasks.json, and that appears to go fine. However, when I go back to edit it by click "Tasks->Configure Task" and the name of my task, a dialog in the bottom right says:
Unable to open '.vscode\tasks.json': File not found (file:///home/cburdick/.vscode\tasks.json).
This is a Linux server, so I'm not sure why it's using a windows path delimiter on the last portion.
Steps to Reproduce

Create a new task
Try to edit that task

Interesting. Are you using a windows client? That could likely cause the \ in the pathname. If thats the case, we'll definitely fix!

Hi @kylecarbs, I'm using Chrome in windows. Is that what you mean?

Yup! We'll fix this.

Appears to have been resolved in the latest pre-release.


do submit test for  full patient details

we should probably close this. I did it several times in the days leading up to May visit, and then the testers did it many times more.

Fine with me! Submit tests have been a side-effect of user testing anyways.


Reorganize scripts folder to prepare for packaging JS scripts

Some projects are going to start using our JS scripts soon. To help us with packaging the scripts, this PR bundles all of the JS into scripts/js whereas before it was spread out over scripts/commands and scripts/lib.
Beyond packaging the scripts, I think this is a cleaner organization anyways to differentiate between our three scripts projects:

js
nb-tester
pr-previews (renamed from pr_previews)

(In a follow up, we might want to centralize all of our config into scripts/config)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 8 committers have signed the CLA.:white_check_mark: Eric-Arellano:white_check_mark: 1ucian0:white_check_mark: abbycross:white_check_mark: frankharkins:white_check_mark: born-2learn:white_check_mark: beckykd:white_check_mark: Gopal-Dahale:x: miamicoYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix possible Badged name scope bug

This PR fixes a nasty possible bug if a Badged control is inside a TabItem (or other non loaded control) found at this issue at MahApps https://github.com/MahApps/MahApps.Metro/issues/2885
"Exception = 'BadgeScaleTransform' name cannot be found in the name scope of 'System.Windows.Controls.ControlTemplate'."
This PR adds a new dependency property too where you can change the Storyboard (if you want).

@punker76 nice of you to fix this! I just experienced it myself today when trying to put a counter badge on a tab item header. Perhaps it would be nice to have a BadgeAssist/BadgeHelper to enable "native" support for badges in tab item headers without the need to restyle.

Thanks!  Sorry for delay...been busy elsewhere lately...

@ButchersBoy All fine my friend


Deploy the (limited) documentation we have to RTD

Feature request type

[ ] Suppress false positives from existing pylint warnings
[ ] Add new pytest-specific warning
[x] Other

https://github.com/sphinx-doc/sphinx/blob/master/Makefile#L59-L63

Also https://docs.readthedocs.io/en/stable/guides/pull-requests.html?


chore: x/oracle: clean up keys

Description
For some reason the x/oracle module's keys were given two different sets of variable names, so we're just taking out the set referenced by the keys.go file

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added appropriate labels to the PR
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #377 (5ba456b) into main (2ebe3ec) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   36.98%   36.98%
=======================================
  Files          78       78
  Lines       11021    11021
=======================================
  Hits         4076     4076
  Misses       6637     6637
  Partials      308      308

Impacted Files
Coverage Δ

x/oracle/types/keys.go
0.00% <0.00%> (ø)


Send json via ESP32

Query/Question
I would like to send a json with the Azure Hub ESP32 SDK, but I can't find the right solution to modifiying the getTelemetry method.
Why is this not a Bug or a feature Request?
No new feature and otherwise the sdk works
Setup (please complete the following information if applicable):

OS: Windows
IDE: Arduino 1.8
Version of the Library used 1.1.4

Information Checklist
Please make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
the data gets send to the hub but when I track it with the Device Explorer Twin i dont get a json but this:

My method looks like this:

temperature, moisture and uv are gloabl float variables

[ ] Query Added
[ ] Setup information Added

Telemetry data is not twin data. You can view telemetry data in the IoT explorer on the telemetry tab.

Hi so I got it to send the json correctly, but now I have the issue that i want to send seperate messages, so for each sensor I need a seperate getTelemtryPayload. How can I integrate taht with sendTelemetry? And do I need seperate arrays for the telemtry payload?

Hello @kmw0044! You could create multiple methods, like getTemperatureTelemetryPayload and getHumidityTelemetryPayload, and then have multiple get_publish_topics and publishes
if (az_result_failed(az_iot_hub_client_telemetry_get_publish_topic(
          &client, NULL, telemetry_topic, sizeof(telemetry_topic), NULL)))
  {
    Serial.println("Failed az_iot_hub_client_telemetry_get_publish_topic");
    return;
  }
mqtt_client.publish(telemetry_topic, getTelemetryPayload(), false);

within sendTelemetry to send them as separate messages (or you could break that into multiple methods as well if you don't necessarily want them sending at the same time)
Let me know if this helps, or if you have further questions

Hi, already got it figured out, but thank you for your suggestions :)
On Tue, Jun 27, 2023 at 5:21 PM github-actions[bot] <
@.***> wrote:

Hi @kmw0044 https://github.com/kmw0044. Thank you for opening this
issue and giving us the opportunity to assist. To help our team better
understand your issue and the details of your scenario please provide a
response to the question asked above or the information requested above.
This will help us more accurately address your issue.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-c/issues/2582#issuecomment-1609735470,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7XRIKACDLTUP2IFKQZHED3XNL3BFANCNFSM6AAAAAAYYQ3A4E
.
You are receiving this because you were mentioned.Message ID:
@.***>


a11y: triggering element cannot contain interactive elements

Please verify the version of auro-dropdown you have installed
@latest
Please describe the bug
See code
https://github.com/AlaskaAirlines/auro-dropdown/blob/57c991b5bd63aa9ae98f9f3190bd7188d89f4e42/src/auro-dropdown.js#L473-L491
In the current implementation of the dropdown UI, the div container has [role="button"] effectively redefining the div to be a <button> element. This is problematic because the content in the trigger slot can be any HTML, including interactive elements like input, button, or select. See the DOM output of the auro-combobox element.

In any scenario where there is an interactive element placed within the scope of any element *[role="button"] is similar to adding interactive content within a <button> element and would be considered non-compliant.

Both <button> and <input> are interactive elements with distinct behaviors
A <button> is not intended to contain focusable, interactive elements like <input>. Nesting breaks the semantic meaning of the <button>, confusing assistive technologies and users.
Screen readers may announce the <button> as "button," but they won't know how to handle the nested <input>.

Reproducing the error
This issue is reproducible on the Auro docsite
Recommendation
The root cause of the issue lies in the fact that auro-dropdown, appropriately so, attempts to manage the accessibility state of the popup content. However, in a scenario where the triggering element of the UI is interactive, the responsibility for managing this state should be delegated to the child element. In this instance, auro-input.
An update to auro-dropdown would be to consider the following:

Update the element so that role="button" is optional allowing the consumer some control over the interactive state of the trigger element.
Move all accessibility attributes, including role="button" to the name="trigger" slot element (see example)

Moving the accessibility attributes like aria-expanded to the <slot name="trigger"> where the <input> resides, and making role="button" optional, would simplify the structure and improve semantic clarity. Removing role="button" is only applicable provided that the <input> (or the slotted content) becomes the actual trigger element.
Example

      <slot name="label"></slot>

      <slot
        name="trigger"
        aria-labelledby="triggerLabel"
        aria-controls="popover"
        aria-expanded="${this.expanded ? 'true' : 'false'}"
        @slotchange="${this.handleTriggerTabIndex()}">
      </slot>

What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge
Additional context
This issue is related to an accessibility finding: https://alaskaair.hub.essentia11y.com/projects/6759ec2bc0afd4c33f103b81/tasks/6765ecf582f50344673fac0a?linkedPropertyData=652813da6eec28e13de119c4|652813da6eec28ef1ee119bd
Exit criteria
This issue can be closed one the updated auro-dropdown ensures proper accessibility and semantic integrity by dynamically delegating responsibility for interactive behaviors and accessibility states to the appropriate element. It should:

Avoid conflicts or non-compliance by preventing interactive elements from being nested within elements with role="button".
Allow the trigger slot content to manage its own accessibility states when it is an inherently interactive element (e.g., <input> or <button>).
Maintain full keyboard and screen reader compatibility, ensuring all interactions are intuitive and accessible across various scenarios.
Provide a flexible implementation that adapts to different use cases while offering clear guidance for consumers.
Be validated through thorough testing and updated documentation to confirm compliance and usability.

Please include @blackfalcon in the code review process to evaluate the accessibility fix.

The severity of the issue was updated to CRITICAL due to an active complaint from the DOT regarding accessibility in UIs supported by this element.
See ADO story for additional details https://itsals.visualstudio.com/E_Sell_Shop/_workitems/edit/1144649


chore(rust): Update ic-cdk to a non-yanked version

Motivation
ic-cdk version 0.13 has been yanked.  This causes problems for users of verifiable-credentials trying to pass a security audit.
Changes

Update the version of ic-cdk to 0.15.

Tests
See CI
Todos

[x] Add entry to changelog (if necessary).
Needed?

The Cargo.lock isn't updated because it is not committed.
The recommendation used to be: Commit the Cargo.lock for binaries, not for libraries.
As of 2023 the picture is more nuanced, as it can sometimes make sense to commit the Cargo.lock for libraries.  See: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html


Use all embedding fields

Previously, we only searched the embedding vector for the document title. Now, searching all 3 vector fields, if they exist, and they've been selected to be searched.
Also parameterized the API version in the .configs file, which allows us to be backward compatible.

Code looks good, and functionality appears to be the same as for currently deployed AI search.


dino: 0.4.1 -> 0.4.2

https://github.com/dino/dino/releases/tag/v0.4.2
Fixes CVE-2023-28686: https://dino.im/security/cve-2023-28686/
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Would you be interested in doing a PR for 0.3.1 -> 0.3.2 against release-22.11 as well?


BUG:

Issue Description
np.int is deprecated since numpy 1.20 and should be replaced with python int or np.int64/np.int32 for compatibility with newer numpy versions.
In my case resulting in error in
shap/explainers/_tree.py", line 1511, in __init__     self.leaf_child_cnt.append(np.zeros(self.num_nodes[i], dtype=np.int))
--> AttributeError: module 'numpy' has no attribute 'int'.
np.int was a deprecated alias for the builtin int. To avoid this error in existing code, use int by itself. Doing this will not modify any behavior and is safe. When replacing np.int, you may wish to use e.g. np.int64 or np.int32 to specify the precision. If you wish to review your current use, check the release note link for additional information.
The aliases was originally deprecated in NumPy 1.20;
Minimal Reproducible Example
from sklearn.datasets import fetch_california_housing
import xgboost as xgb
import shap

X, y = fetch_california_housing(return_X_y=True)
xgb_model = xgb.XGBRegressor(n_jobs=1)
xgb_model.fit(X, y)
shap.TreeExplainer(xgb_model, feature_perturbation="tree_path_dependent")

Expected Behavior
No error for newer numpy versions, since there is no version dependency numpy < 1.20 defined.
Bug report checklist

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest release of shap.
[ ] I have confirmed this bug exists on the master branch of shap.
[ ] I'd be interested in making a PR to fix this bug

Installed Versions
numpy     1.24.3
shap         0.41.0
xgboost   1.7.3

Perfect thanks, great to hear!


Note maintainers shared from fluxcd/flux2

The GitOps toolkit controllers usually adopt the maintainers of the
"central" Flux v2 git repo, fluxcd/flux2. For convenience of keeping
track, it is easier to refer to the MAINTAINERS file there.
NB this expands the maintainers of this repo, but only to those who
were effectively considered maintainers anyway (i.e., it reflects the
established practice.)
See https://github.com/fluxcd/flux2/discussions/515 for the proposal.

I think we could remove all maintainers and just reference the flux2 file.

I think we could remove all maintainers and just reference the flux2 file.

That would not work for controller projects that have maintainers that have a sole interest in just maintaining that project.
I also think there is a difference in being mentioned in the fluxcd/flux2 maintainers list or in the list of a domain specific project, the latter implies a closer relationship and better expertise.

I think we could remove all maintainers and just reference the flux2 file.

That would not work for controller projects that have maintainers that have a sole interest [...]

For example, I'm not a fluxcd/flux2 maintainer, so that would remove me as a maintainer here :-/

@relu Since you are also a flux2 maintainer about to (implicitly) become a maintainer here, we'll need your stamp too.