bower install should override linked dependencies (?)

bower install should override linked dependencies, or at least provide an option to override linked dependencies. Currently it silently fails. The former is the behaviour of npm (just as a reference).

I would like to have a bower list --linked command or something like that to get a fast review of what dependencies are linked, but I don't think that bower install would have to replace the linked deps.
Most of the times I'm working with linked dependencies I want to update/install other deps without replacing the once I'm linking from my local repos.
Also a good approach would be to add a --clean-linked or --override-linked to the update/install commands if someone needs that behaviour.

Bower is now deprecated and in maintenance mode which means we won't be making breaking changes or breaking features


[SR-15167] Weird newline with optional chaining

Previous ID
SR-15167

Radar
None

Original Reporter
@karwa

Type
Bug

Environment
swift-format 0.50300.0

Additional Detail from JIRA

Votes
0

Component/s
swift-format

Labels
Bug

Assignee
None

Priority
Medium

md5: 2f04a8858227c6ebd6c94f80e9e6a07e

Issue Description:
Given this input:
func test() {
  let result = newValue.withContiguousStorageIfAvailable {
    setNewValue($0)
  } ?? setNewValue(newValue)
}

For some reason, swift-format decides it would be better with a newline and if everything was indented:
func test() {
  let result =
    newValue.withContiguousStorageIfAvailable {
      setNewValue($0)
    } ?? setNewValue(newValue)
}

But I think this looks quite a lot worse. The actual body, involving wCSIA and the optional chaining, seems to be kept intact... it's just a bit lower and to the side. I'm not sure how that helps anything.
I'm not sure which rule is causing this or how to disable it, but I'd really like if swift-format could stop doing it. It's not a line-length issue: my max length is set at 120 and the original doesn't get anywhere near that.

Tracked in Apple’s issue tracker as rdar://126948211


Support setting namespaces in RunInference

What needs to happen?
Right now, the name for namespaces in RunInference is hardcoded to RunInference for base.py and sklearn_inference.py and RunInferencePytorch for pytorch_inference.py in the get_metrics_namespace function. However, users may want more control over how the namespaces. For example, one could have two classification models that use the same model loader, and want different namespaces to distinguish between the two. This would also help with metrics tracking in our community dashboard. With the old solution, there isn't a way to do this. If we can allow passing in a parameter like metrics_namespace into the RunInference transform, then users would be able to set their own namespace.
example:
RunInference(model_loader, metrics_namespace=”my_custom_namespace”)
Issue Priority
Priority: 2
Issue Component
Component: sdk-py-core
Subtask of issue https://github.com/apache/beam/issues/21435

@ryanthompson591 @AnandInguva

Can we make get_metrics_namespace static?

you mean with a @staticmethod decorator? or static as in hard coded?

Yep. @staticmethod decorator. Because in the benchmark tests, If I need to filter the metrics using namespace, I can just get the namespace by calling PytorchRunInference.get_name_space()

.take-issue

Just an idea --- How about making the default_namespace static? That way you can get it, but if the user specifies something separate then they can.

@yeandy @ryanthompson591
Do we want the namespace to be defined on ModelHandler or RunInference transform?
Question :

On ModelHandler, user can define a namespace while creating the ModelHandler object and can pass this ModelHandler object to the RunInference transform.
What happens when there are two RunInference transforms that use the same ModelHandler and the two transforms need different namespaces?

To solve this, we can move the methods related to namespaces into the RunInference base class.

cc @damccorm

It makes the most sense to me to put the namespace on the base model handler.  This puts the user in full control.
Some outstanding questions would be what would happen with wrapper model handlers - like KeyedModelHandler.'
I think the obvious thing would be to make some sort of default behavior that wrappers should do.  Something like passing the namespace overrides/prefixes to the wrapped model handlers.
I'm not sure if the base model handler should prefix name spaces or not.  Something like:
handler = MyModelHandler(name_space_override='my_defined_namespace')
-> namespace is set to my_defined_namespace
or
handler = SklearnModelHandler(name_space_prefix='some_prefix_')
-> namespace is set to some_prefix_sklearn_namespace
Anand, I think there are a few options how to do this. What do you think about outlining them in a short doc, and then we can pick one?

I think my personal lean would be:

Leave the metrics namespace definition in the ModelHandler classes. These have the advantage of being model specific; for example, the PytorchModelHandlerTensor has a metrics namespace RunInferencePytorch. Getting that level of model-specificity is harder to do elsewhere.
Add a method (or probably just a class parameter) to override the namespace on the RunInference base class. This gives users full control. I'd actually also lean towards making this a postfix to the default metrics namespace instead of a full override since this makes usage tracking easier for runners that can do that (probably just dataflow at this point). It also guarantees that similar metrics are grouped together alphabetically. It does remove some user control though and I could be convinced this is a bad idea.

Anand, I think there are a few options how to do this. What do you think about outlining them in a short doc, and then we can pick one?

Agreed - so far we've collectively proposed 3 different options :) it would be good to call out pros/cons side by side.

Sure. I will create a doc. I agree with Danny and actually worked up on PR[1] based on that.
[1] https://github.com/apache/beam/pull/23182


useIncognitoPages doesn't rotate fingerprints

Which package is this bug report for? If unsure which one to select, leave blank
None
Issue description
If you run the code with incognito pages, you will always get the same browser. If you comment incognito pages and uncomment one page per browser, you will get different user agents.
Code sample
import { Actor } from "apify";
import { PlaywrightCrawler } from 'crawlee';

const proxyConfiguration = await Actor.createProxyConfiguration();

const crawler = new PlaywrightCrawler({
    proxyConfiguration,
    browserPoolOptions: {
        useFingerprints: true,
        // maxOpenPagesPerBrowser: 1,
    },
    launchContext: {
        useIncognitoPages: true,
    },
    preNavigationHooks: [
        async ({ page }) => {
            page.once('request', async (req) => {
                try {
                    const headers = await req.allHeaders()
                    console.dir(headers);
                } catch (e) {
                    console.log('req inspection failed')
                }
            })
        }
    ],
    requestHandler: async ({ request, page, log}) => {
        const text = await page.innerText('pre');
        log.info(text);
    },
});

await crawler.run([
    'https://api.ipify.org?format=json&a',
    'https://api.ipify.org?format=json&b',
    'https://api.ipify.org?format=json&c',
    'https://api.ipify.org?format=json&d',
    'https://api.ipify.org?format=json&e',
    'https://api.ipify.org?format=json&f',
]);

Package version
3.7.2
Node.js version
18
Operating system
MacOS
Apify platform

[ ] Tick me if you encountered this issue on the Apify platform

I have tested this on the next release
No response
Other context
No response

Seems like a sign of a much larger underlying issue:
New sessions / fingerprints / proxyUrls are generated only on a browser launch.
The following snippet doesn't rotate the fingerprints correctly - all requests are done with one session only. This is because the useIncognitoPages was written with Playwright contexts in mind - we relied on the "newPage() creates a separate environment" invariant, so all the pages/contexts are launched in one browser.
sessionPoolOptions: {
    sessionOptions: {
        maxUsageCount: 1,
    },
},
launchContext: {
   useIncognitoPages: true,
},

The following snippet rotates the fingerprints correctly:
sessionPoolOptions: {
    sessionOptions: {
        maxUsageCount: 1,
    },
},
launchContext: {
   useIncognitoPages: false,
},

This works well because an "expired" session throws away the whole browser instance, causing the new pages to launch a whole new browser (see the parallel with the maxOpenPagesPerBrowser, which does the same thing). This is crazy expensive though, while launching and closing a context 100 times in one browser takes ~3.9 seconds, launching and closing a browser 100 times takes 40 seconds.
The entire browser-pool and session rotation logic is quite convoluted and worth a total rewrite.


ClientCommands.java:52: Enable debug mode for log4j2.

The puzzle 7-f745248e from #7 has to be resolved:
https://github.com/portlek/synergy/blob/f3adebba8693d0bef56cb7af12e43b421e1085f7/client/src/main/java/io/github/portlek/synergy/client/commands/ClientCommands.java#L52-L52
The puzzle was created by @portlek on 01-Apr-21.
Estimate: 5 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 7-f745248e has disappeared from the source code, that's why I closed this issue.


Cross publish native

An attempt to cross publish munit-native & rest to Scala 3.
Needs Scala 3.1.1 to be released, otherwise macro mixing in MacroCompat2 won't work. It fails with the Experimental erased may only be used with a nightly or snapshot version of the compiler - see https://github.com/lampepfl/dotty/pull/13795 for more details.

@sideeffffect @gabro I'll answer to https://github.com/scalameta/munit/pull/488 here. There's a problem with scalacheck - there is no scalacheck published for Scala 3 & Native 0.4.x, see maven. I tried various tricks with CrossVersion.for3Use2_13 and etc. but without any results.
When running ++3.1.1 testsNative/test I always ended with munit depending on 0.4_3 and munitScalacheck depending on the 0.4_2.13 which unfortunately doesn't work.
@sideeffffect if you want you can play with it to get ++3.1.1 testsNative/test passing. I'm not a multiversion multiplatform expert, maybe you can get it done ;)
There is a PR to support scala-native Scala 3 in scalacheck repo https://github.com/typelevel/scalacheck/pull/868. Unfortunately, it's waiting for maintainers to look at it.

I see 3 options:

find a workaround for scalacheck scala3 & Native 0.4.x and made ++3.1.1 testsNative/test passing. Can give it another try but it won't be in this week :/
wait for typelevel/scalacheck#868
extract scalacheck related tests to separate module, then munit can be released without any hassle and munit-scalacheck will wait for typelevel/scalacheck#868

@gabro Are you in favor of any option?

Well if we have a viable workaround, sure, but it really depends on whether you or someone else can find it.
Reaching out to Typelevel about the status of Scalacheck and getting that PR merged upstream would be the preferable option for sure, while I'm not really keen on the idea of releasing MUnit without full Scalacheck support.

I tried various tricks with CrossVersion.for3Use2_13 and etc. but without any results.
When running ++3.1.1 testsNative/test I always ended with munit depending on 0.4_3 and munitScalacheck depending on the 0.4_2.13 which unfortunately doesn't work.

I think I've also hit this issue
[error] Modules were resolved with conflicting cross-version suffixes in ProjectRef(uri("file:/home/ondra/Projects/sbt-locales/"), "apiNative"):
[error]    org.scala-native:windowslib_native0.4 _3, _2.13
...

Please read more here:
https://github.com/portable-scala/portable-scala-reflect/issues/23#issuecomment-1021617780

Note, their is also a problem with scala-native itself you would need to workaround: https://github.com/scala-native/scala-native/issues/2543

For a workaround to the
[error] Modules were resolved with conflicting cross-version suffixes in ProjectRef(uri("file:/home/ondra/Projects/sbt-locales/"), "apiNative"):
[error]    org.scala-native:windowslib_native0.4 _3, _2.13

issue, see https://github.com/cquiroz/sbt-locales/pull/190

Using an inline conditional to work around issue scala-native/scala-native#2543 would be possible:
diff --git a/munit/native/src/main/scala/munit/internal/PlatformCompat.scala b/munit/native/src/main/scala/munit/internal/PlatformCompat.scala
index c08636e..e625d88 100644
--- a/munit/native/src/main/scala/munit/internal/PlatformCompat.scala
+++ b/munit/native/src/main/scala/munit/internal/PlatformCompat.scala
@@ -38,7 +38,7 @@ object PlatformCompat {

   def isJVM: Boolean = false
   def isJS: Boolean = false
-  def isNative: Boolean = true
+  inline val isNative = true // Scala 3 syntax

   def newRunner(
       taskDef: TaskDef,
diff --git a/munit/shared/src/main/scala-3/munit/internal/Compat.scala b/munit/shared/src/main/scala-3/munit/internal/Compat.scala
index 7e489e2..92b507d 100644
--- a/munit/shared/src/main/scala-3/munit/internal/Compat.scala
+++ b/munit/shared/src/main/scala-3/munit/internal/Compat.scala
@@ -7,7 +7,10 @@ object Compat {
   val LazyList = scala.LazyList
   def productElementNames(p: Product): Iterator[String] =
     p.productElementNames
-  def collectionClassName(i: Iterable[_]): String = {
-    i.asInstanceOf[{ def collectionClassName: String }].collectionClassName
+  inline def collectionClassName(i: Iterable[_]): String = {
+    if PlatformCompat.isNative then
+        i.getClass.getName // or just "iterable" ?
+    else
+        i.asInstanceOf[{ def collectionClassName: String }].collectionClassName
   }
 }

I spoke with Wojciech and there should be the Scala Native release at the end of this week. That release will contain fixes for problems spotted here, so I'll wait for it.

That release will contain fixes for problems spotted here, so I'll wait for it.

Do you mean for CrossVersion.for3Use2_13? I must strongly recommend against using this technique.
When a widely-used library (such as scalacheck) is depended on with CrossVersion.for3Use2_13 by another widely-used library (such as munit) this creates a binary-breaking division in the ecosystem: even after scalacheck is properly published for Native/Scala 3, this artifact is incompatible with the Native/2.13 artifact that munit is using, and thus the ecosystem will be split on this dependency.
For an example of how this plays out, I strongly recommend you read this thread.

https://github.com/scala-js/scala-js-dom/issues/451

tl;dr scala-js-dom and all its downstream users (very nearly the entire Scala.js ecosystem) had to do a breaking version jump.
Further reading:

https://gist.github.com/djspiewak/b8f2b4547951442102488964bc351cf9#5-dont-rely-on-withdottycompat
Note that withDottyCompat became for3Use2_13

@armanbilge thanks for this information. Just to confirm, the preferable solution is waiting until scalacheck is published properly for scala-native/scala3? In every other approach, munit ends up depending on the _2.13 artifact.

I just merged some PRs in the ScalaCheck repo that may help get things moving again.

@kpodsiad how does would munit feel about scalacheck bumping to 3.1 on all platforms? See discussion in https://github.com/typelevel/scalacheck/pull/868#issuecomment-1067995736.

@armanbilge I'm afraid that I'm not the right person to ask.
@olafurpg @gabro could you share your opinion as creators and maintainers?

IIUC this would only affect MUnit + Scalacheck on Scala Native.
If that's the case then I think it's fine (I'm assuming we can keep using the current version of Scalacheck for jvm/js targets in order to preserve compatibility with 3.1)
The only drawback is that downstream libraries targeting e.g. jvm and native would need to do the same (either depend on different versions of MUnit or break compatibility with 3.0)
I'll let @olafurpg call the shots, but it would be a terrible thing in my opinion

No objections from me to drop 3.0 support

I'm assuming we can keep using the current version of Scalacheck for jvm/js targets in order to preserve compatibility with 3.0

one would assume so (I did too), but the assumption was called into question by @armanbilge at https://github.com/typelevel/scalacheck/pull/868#issuecomment-1067989391 , where he wrote:

these sorts of hacks seem to cause problems see e.g. https://github.com/portable-scala/sbt-crossproject/issues/130

how strong an objection that is, I'm not sure — if we run into trouble, would it be minor trouble we could work around, or really serious trouble?

Hmm, there seems to be some confusion (at least on my end :)
I was commenting on the potential difficulty of hacking a build.sbt so that some platforms publish on 3.0 and others on 3.1.
My understanding of @gabro's comment was that munit could continue to use the current version of Scalacheck 1.15.4 on JVM/JS so that munit doesn't have to bump.

it's difficult to speak precisely about this and difficult to be sure if understandings are shared
I guess I'll just say that I hope a simple-to-understand, simple-to-communicate-to-downstream-users solution turns out to be feasible here

I agree. The other feasible solution seems to be waiting for the -Yscala-release flag (which now has a new name) and its sbt integration. But it's unclear to me whether/how this will work with Scala Native and what build hacks will be needed to accomplish that. Everyone moving to 3.1 is clean and easy.

Given that we're early stage and we're all figuring this out, I sympathize with Seth's comment in the Scalacheck issue: it's probably for the best to just drop 3.0 and pretend it never happened

perhaps @romanowski would like to try to talk us down from that radical position :-)

No one's talked me down, so let's escalate 😉

https://github.com/typelevel/scalacheck/pull/879

Scalacheck has now published a snapshot with Scala 3 / native support! I expect a stable release is imminent.
https://s01.oss.sonatype.org/content/repositories/snapshots/org/scalacheck/scalacheck_native0.4_3/1.16-0ac8005-SNAPSHOT/

Your move! 😁
https://repo1.maven.org/maven2/org/scalacheck/scalacheck_native0.4_3/

@armanbilge Could you help me with JS tests? They suddenly started failing after I bumped scala-js to the 1.9.0. Although there is a clue what to do, I don't why it's needed at all and that's why I would appreciate help from someone with any scala.js experience ;)

You're running into the fixes with compatibility concerns about regular expressions in Scala.js 1.7.0. There are suggested strategies on how to avoid MULTILINE in the regular expressions doc page of Scala.js.
This is not my repo, but I would humbly suggest upgrading Scala.js in a separate PR to be able to address these changes independently of the larger changes in this PR.

It seems that the problematic regular expressions is at
https://github.com/scalameta/munit/blob/36aeb753b2f9b72636e33331a6825d7bcedb87a8/tests/shared/src/test/scala/munit/BaseFrameworkSuite.scala#L85-L86
This regexp doesn't even use ^ nor $, and is only used with replaceAll (so not any anchored situation). The MULTILINE flag has no effect in that case, so it can safely be removed without any other change.

@kpodsiad does Seb's suggestion fix it (thank you!)? Otherwise I'll try and looking into it a bit later, I would really like to unblock this :)

@armanbilge I'll try to look at this tomorrow or, more probably, next week.
Because of with Scala.js 1.8+ in
Scalacheck 1.16.0 is binary compatible with the 1.15.x and 1.14.x series. It is published for Scala 2.12, 2.13, and 3.1+ with Scala.js 1.8+ and Scala Native 0.4. This release is the first to support Scala 3 on the Native platform.
it seems like I need to either:

leave the old version of scalacheck for JS and use the newly published 1.16.0 for Native and JVM.
just add the linkerConfig for tests (scalaJSLinkerConfig ~= { _.withESFeatures(_.withESVersion(ESVersion.ES2018)) }) because it's needed only in tests and it won't affect library users I think.

Hum, if I understand https://github.com/scalameta/munit/pull/477#issuecomment-1092707746 correctly you just need to remove that MULTILINE and it should work.
Ok, I'll give it a try.

Woops, I also see that this PR is targeting main instead of a series/0.7 branch. If these changes are released as a 1.0 milestone, then most of the ecosystem won't be able to upgrade.

Ok, put up a PR at:

https://github.com/scalameta/munit/pull/511

Hum, the multiline flag is needed. The suggestion to bump the ES version for tests-only would work without affecting downstreams, but it would prevent your tests from being able to catch uses of ES2018 features in the published code. Which is not so great.
scalaJSLinkerConfig ~= { _.withESFeatures(_.withESVersion(ESVersion.ES2018)) }

@olafurpg approval will be gladly welcomed to fulfill formalities ;)

Woops, fyi we've got conflicts now.

Sorry, merge conflicts are my fault. I'll resolve those and then merge once CI passes.


New icon theme

Create a color theme (including logo that matches original idea) that ought to work for both dark and light themes.  Original vector artwork included.

👍
Thank you for your contribution! These look really nice. A big improvement over what came before! Yeah, I'd like to get them in.
Few things...

The home page icons are smaller than the originals. Originals were actually 100x100 despite the misleading name
Not a fan of the yellow color. The site uses Indigo from the Bootstrap Color Palette. Ideally we should try something from that first, maybe perhaps $indigo-200 or $indigo-300? Certainly the site icon should be something from Indigo palette. For the home page icons, we could try looking for a good complementary color at Coolors.
For the home page, what do you think about just integrating them as SVGs directly?
The highlight in the upper left looks great on the home page. For the site icons, though, simpler is better, because it still has to read at very small sizes. Would be better to stick with more of a flat treatment on the site icon.
Could we have a bit more margin between the outside of the circle and the inside of the image? Old icons largely lived within a 75-pixel-diameter circle inside a 100-pixel-diameter outer edge, so 25% margin. New ones look more like 15% margin.
Apple touch icon needs much more margin. Please refer to https://www.apple.com/apple-touch-icon.png

You can go ahead and remove the now-extraneous "Homepage-only content" block in _Layout.cshtml. It lives on in the history if we ever need it!
                        @if (ishome)
                        {
                            // Homepage-only content
                        }

Finally, just because we are good stewards of intellectual property around here... These are icons you created yourself, and you are good with contributing them for distribution with the MIT license, yes?
Thanks so much!!

I will revise based on your feedback.  Thanks!  Yeah, I went by the name (and I didn't look at the size).  I will incorporate SVG with the PNG fallback.

@RecursiveGeek Looks great thanks for this!! I'll want to move the files from '_working' somewhere more meaningful. I was thinking 'YoFi.AspNet/Media'. Any concerns with that?


UX: Improve voting options & horizontal scroll

Background
Voting options are currently located on the far right side of the pending requests table, making them difficult to find and decreasing voting ease. It is also difficult for users to know that they have a horizontal bar to scroll left and right within table.

UX Need
Need to update the Pending Requests table with a more prominent and clearly visible voting option. This will make it easier for users with voting permissions to take immediate action. Also need to make it easier for users to know that they can scroll left and right in the horizontal table.
Acceptance Criteria

[ ] Create a mockup showing what the updated table should look like (e.g. moving approve/reject buttons to the left?)
[ ] Update the development ticket (https://github.com/NEAR-DevHub/neardevhub-treasury-dashboard/issues/74) with the solution and move from Blocked Status to Backlog

Open table settings -> Hover selected option -> Click Pin icont to pin
https://github.com/user-attachments/assets/d61640ea-052f-408a-ad3f-00024bebcde0

Solution

Open table settings
Hover selected option
Click Pin icont to pin> Lets pin voting column by default

We make an option to pin any column from left or rite side of the table
Treasury.Pin.column.flow.mp4

Hey @FREZZZBE – I like this direction for sure. A couple of quick reactions:

Right now the pin button doesn't seem visible unless you hover over the table. Could we always show it but make it light/transparent ish similar to the eye button when not selected?
Are we only making the option to pin votes? Or any other columns? If the latter, can you show that would look when you select multiple random ones? Will they always show on the right?

Hey @FREZZZBE – I like this direction for sure. A couple of quick reactions:

Right now the pin button doesn't seem visible unless you hover over the table. Could we always show it but make it light/transparent ish similar to the eye button when not selected?
Are we only making the option to pin votes? Or any other columns? If the latter, can you show that would look when you select multiple random ones? Will they always show on the right?

Hey @ori-near

Yes we can.Just trying to make it more clean but it doesn't cost this risk you right.
I think we can make it only for votes for now. or we can make it for all but it probably will be 5x more complex for dev.

We can make this logich: if you pin smthing from red zone - it will stick to left. From yellow to right.
We can limit pined colums by viewport size or by specific amount e.g. 5 in total

@FREZZZBE – agree that we don't need to overcomplicate. Let's get input from @Megha-Dev-19 and the other devs to see what would be the easiest path.

@ori-near are we ready to mark as done?

hey, sorry I missed my mention, I like the pinned solution, but it will be pretty complicated to add it for all columns, so maybe we can only do it for votes now, and I think it's better if it's enabled by default, since first time voters should definitely see their vote option, and they can turn it off if needed.

hey, sorry I missed my mention, I like the pinned solution, but it will be pretty complicated to add it for all columns, so maybe we can only do it for votes now, and I think it's better if it's enabled by default, since first time voters should definitely see their vote option, and they can turn it off if needed.

Agree with this solution. @ori-near could you update following task if you are agree with this too?

Hi @FREZZZBE @Megha-Dev-19 – thank you for you feedback. I went ahead and updated the development ticket for the voting column and removed the dependency on this ticket: https://github.com/NEAR-DevHub/neardevhub-treasury-dashboard/issues/74
A couple of follow ups:

@Megha-Dev-19 I think we named the "Votes" column "Actions" – because actions might vary based on the user. But should we relabel them "Votes"? OR will that cause an issue?
@FREZZZBE Can you please work on the second part of this ticket (horizontal scroll)? I updated the AC.

Can you please work on the second part of this ticket (horizontal scroll)? I updated the AC.

@ori-near fill like it's overrated problem. A lot of tools have tables and when it's too wide it's use common horisontal scroll. I would like to test it with just pined vots. Pined votes must more visual indicate that.


Error after adding ArcGIS Pro Python 3.6 environment

The error below started occurring after adding Esri's ArcGIS Pro (version 2.5.0) Python 3.6 environment, using Visual Studio 2019 on Windows 10. ArcGIS Pro may or may not be a red herring, but here is the link to it.
[Window Title]
devenv.exe
[Main Instruction]
An unexpected error occurred
[Content]
Please press Ctrl+C to copy the contents of this dialog and report this error to our issue tracker.
[^] Hide details  [Close]
[Expanded Information]
Build: 16.4.19310.1

System.AggregateException: One or more errors occurred. ---> System.ArgumentNullException: Value cannot be null.
Parameter name: first
   at System.Linq.Enumerable.Union[TSource](IEnumerable`1 first, IEnumerable`1 second)
   at Microsoft.PythonTools.Interpreter.CondaPackageManager.<GetEnvironmentVariables>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.PythonTools.Interpreter.CondaPackageManager.<CacheInstalledPackagesAsync>d__59.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Interpreter.CondaPackageManager.<GetInstalledPackagesAsync>d__64.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Project.InterpretersNode.<RefreshPackagesAsync>d__25.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
   --- End of inner exception stack trace ---
   at System.AggregateException.Handle(Func`2 predicate)
   at Microsoft.PythonTools.Infrastructure.TaskExtensions.<>c__9`1.<SilenceException>b__9_0(Task t)
   at System.Threading.Tasks.ContinuationTaskFromTask.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Infrastructure.VSTaskExtensions.<HandleAllExceptions>d__5.MoveNext()
---> (Inner Exception #0) System.ArgumentNullException: Value cannot be null.
Parameter name: first
   at System.Linq.Enumerable.Union[TSource](IEnumerable`1 first, IEnumerable`1 second)
   at Microsoft.PythonTools.Interpreter.CondaPackageManager.<GetEnvironmentVariables>d__23.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
   at Microsoft.PythonTools.Interpreter.CondaPackageManager.<CacheInstalledPackagesAsync>d__59.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Interpreter.CondaPackageManager.<GetInstalledPackagesAsync>d__64.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Project.InterpretersNode.<RefreshPackagesAsync>d__25.

Thanks. This is a duplicate https://github.com/microsoft/PTVS/issues/5935. The fix will be in 16.5, which will be released soon.


Remove false-positive errors if there is an assertion

I would like to finally remove false-positive errors if i am doing an assertion using console.assert().

As we can see here, we have an assertion that will ensure that Jukebox.getEncryption() isn't null, and if it is, an error will be thrown; Then in the next line of code i am getting an error: "Object is possibly null" because Jukebox.getEncryption() is of type Encryption | null, enforcing the instance of Encryption with "!" (es: Jukebox.getEncryption()!.myFunc()), or doing an extra if to ensure it isn't null looks really ambiguos, so that's why i am doing that feature request. Thanks in advice!

console.assert(). has no effect on next statements.
let a;
console.assert(a!==undefined, 'incorrect a value');
console.log('Still executed and throws', a.toUpperCase());

I guess you mean that you are using assert module (and it's recent version that has proper typing).
You should use constant const encryption = Jukebox.getEncryption();, perform assertion on constant and use it.
It is unsafe to assume that getEncryption can't change state of object like Array.prototype.pop.
Also see https://github.com/microsoft/TypeScript/issues/9998 and issues related to narrowing and CFA.

Thanks so much for the support, I should actually have used the assert library instead of the console one. Thank you very much for the advice too, I'll take a look at it right away


CdkTree example stackblitz not working

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When I click the example stackblitz links in https://material.angular.io/cdk/tree/overview I expect them to work.
What is the current behavior?
The stackblitzes are broken because of a missing
import { CdkTreeModule } from '@angular/cdk/tree';

in main.ts.

Verified that this is broken, this should be fixed ASAP


Added Rule: deepslateGenerator

Not sure if we should go until y16 like https://github.com/gnembon/fabric-carpet/pull/914 or just keep it like this and have it be useful with 1.18

Didn't even know that carpet had that rule

While I'm at it, want me to rename it to renewableDeepslate?
I was thinking of leaving it like this although I really don't care

While I'm at it, want me to rename it to renewableDeepslate?
Yeah, I guess that fits better into the established naming scheme

There you go

I guess we could have it change the value so in 1.18 it uses 0?
I would say that it good for now


Feature Request: If in a git repo, check if file has changes

Feature Requested
I like the idea of this plug in! But in my workflow I think the relevant files are the ones that I actually edited (even when saved). In this case the git status would be quite helpful. What do you think?
Relevant Screenshot
No response
Checklist

[X] The feature would be useful to more users than just me.

Actually, there is already a different plugin for that :)
https://github.com/axkirillov/hbac.nvim
(closing, since it would be duplicate work to implement that here as well)


Improve Tencent.WeChat <IP_ADDRESS> URLs

Related to [New Feature]: Replace dldir1.qq.com with dldir1v6.qq.com for Improved IPv6 Support #116525

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116655&drop=dogfoodAlpha

/AzurePipelines run

@wingetbot waivers Add Validation-Domain


Adds ForbiddenObjectResult

Summary of the changes (Less than 80 chars)

ForbidResult does not satisfy the need for adding a Forbid message which is crucial for how we implement our APIs

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ClaudiuSocaci sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[MM-24957] Adding circle ci configuration and build scripts.

Summary
This PR adds:

Circle CI configuration for builds and testing
Build scripts to build app and create docker image

Ticket Link
https://mattermost.atlassian.net/browse/MM-24957
Release Note
NONE

/kind cleanup

/kind cleanup

/check-cla


Feature Request: Use other options

Thanks for the plugin. Please add other options. Example: is24Hour, theme

I tried to make changes to create a PR, but there are problems with the appearance.
is24Hour: true


[2201.4.2 - Stage] Fix invalid error when the error type reference in the error constructor is loaded via the BIR.

Purpose

Fix invalid error when the error type reference in the error constructor is loaded via the BIR.

Fixes #38346
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Merged in master in https://github.com/ballerina-platform/ballerina-lang/pull/38698


update main and requested staging branch before backporting in git-node backport

Currently, if my main branch is behind upstream one I will create a bad backport PR
so we should ask:

Do you want to sync main with upstream
Do you want to sync the staging branch with upstream

(only if any of those are behind)

Why would you care about main for a backport PR? How can you know if it's behind without fetching the latest?

actually main is not that important

(working on this)


Enhance determination of assembly

Recognize assembly of newer 23andMe files

Generically, consider using dbSNP / RefSNP API

Try to identify minor revision of assembly / build

Use SNPs that vary in location between minor revisions

What SNPs?

Do any APIs provide this information?

Validate by attempting to recognize assemblies of openSNP files.

Use SNPs with discrepant positions as a starting point for determining minor variations between assemblies.


Fix utils

Utility function are being written in conflicting manners, without any prior checking.

the nbimporter library seems a promising approach.


PR: move and combine upgrade docs

This PR attempts to move the qhub upgrade docs over to nebari.  It also combines the doc for regular upgrading and the doc for breaking changes upgrading.  I am not sure if this is still an issue, but this is my attempt to include both in one.
Fixes #17

Reference Issues or PRs

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist
Text styling

[ ] The content is written with plain language (where relevant).
[ ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[ ] All links describe where they link to (for example, check the Nebari website).
[ ] This content adheres to the Nebari style guides.

Non-text content

[ ] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[ ] If there are emojis, there are not more than three in a row.
[ ] Don't use flashing GIFs or videos.
[ ] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@ppwadhwa can you check the pre-commit failure?

I think we are still close enough to the 0.3.0 series that we need to continue to maintain these docs. It'll be easy to drop them in the future if the team decides to deprecate the upgrade function. Since deprecating upgrade would be an RFD, I'd say let's move forward with this PR.

Hey @ppwadhwa and @kcpevey, someone recently asked me if we had docs on how to perform a basic Nebari upgrade (say from 2022.11.1 to 2023.1.1) and I realize we don't have this in our old or new docs. I think that would be a great addition to this PR if you're up for it.
Essentially, I see two main headers for this # Upgrading Nebari doc:

Regular Upgrade (regular maintenance, no breaking changes)

simple instructions to upgrade from one CalVer version to the next would include

pip or conda install latest Nebari version
update nebari_version: xxx in the nebari-config.yaml to this latest version
(run nebari validate -c nebari-config.yaml) optional but best-practice
run nebari render -c nebari-config.yaml to rerender all the files
finally ru nebari deploy -c nebari-config.yaml

if deploying via GitOps, you would just open a PR on the deployment repo and merge once the linter passes.

Upgrade Nebari from pre-0.4.0 to 0.4.0

these would be the docs you included above, no changes needed.

@iameskild I think that's a great suggestion. I've suggested the change to make this PR be the addition of upgrading from pre-0.4.0 to 0.4.0. Then I'd say lets open a separate issue and pr for the "Upgrading minor versions" (to be included in this same document.


Error setting logLevel

I tried coordinator.activate(LogLevel.Info) as the docs suggest and got:
coordinator.js?7643:81 Uncaught TypeError: Cannot create property 'logLevel' on number '3'
    at Coordinator.activate (coordinator.js?7643:81)

It could be fixed by changing the line to coordinator.activate({logLevel: LogLevel.Info}).

Thanks for pointing this out. I've fixed this in the guides: https://github.com/orbitjs/orbitjs-site/commit/691ed591771fc90dd2bc4a32c9fd7107e06d9028


Break out of infinite loop while connected but unavailable

I wasn't able to resume program execution on your examples without this; were you?
Thanks
Joe

I tried your tip but it doesn't work as expected.
Then, I wrap the "client.available()" inside a "do while".
Something like this :
unsigned long previous;
unsigned int timeout;
timeout=5000;
previous = millis();
while (client.connected()) {
do {
if ( client.available()) {
....
}
}
while((millis() - previous) < timeout);
}
I don't know if it's the best way (newbie I'm) but seems to work...


Confusing staff and drawing cards

If you pick up a card from the hand and hold onto it before the hand has finished being drawn, the Confusing Staff will not alter its cost. I believe this is because the card is no longer parented to the hand.

Hey, thanks for pointing this out. I fixed this in multiple stacks (you can check the commit):

card_ui is disabled by default
there is a new method called enable_hand() which enables all cards in hand (note that it doesn't affect the playable property which is related to having enough mana)
changed the draw_cards() method in the PlayerHandler, so we can re-enable after drawing a bunch of cards.

However, this introduces a new bug:
The card doesn't pick up the mouse_entered until it's not enabled. So if I position the mouse where a card ends up after the drawing process in won't appear as hovered. You would need to slightly move the mouse. To avoid this I changed card_ui.gd and hand.gd:

we check if the card is hovered with a rect and get_local_mouse_position()


PROBLEM WITH ULTIMATE HOMES PERMISSION

To be more specific, UltimateHomes have this permission to define how many houses a player is allowed to set(ultimatehomes.sethome.max.), for the default group is set to 3, and works. For the mods grop is set to unlimited (ultimatehomes.sethomes.unlimited), but now I'm creating a "VIP" group with a higher number of homes (ultimatehomes.sethome.max.4) but they are still only able to use 3 as much. (the default group is parent for the VIP group).
Any idea about what could I do? I've already given the permission directly to the users but still doesn't work, they are stuck in 3 homes just like the default's one.

Set the 3 permission to false.

Not sure how UltimateHomes is doing this, but I'd imagine it should be checking for the 4 permission first, might be to do with config ordering?
The LP verbose command will probably help to work out what's going wrong.
https://github.com/lucko/LuckPerms/wiki/Verbose


Ceres: Add detailed documentation

Based on existing documentation, some parts from whisper.rst where similarities crossed.  And some general experience.
What's immediately missing are:

[ ] Configure carbon / graphite to write to and read from ceres. I can do a short section on this later.
[ ] Differences between Ceres and Whisper, performance, disk space efficiency, etc.  It would be great if someone can chime in on this, as I've never really used Whisper.  But I could guess from existing documentation on Whisper vs. RRD.

Initially putting this here so a proper review can be done, spelling, etc.

Of course, and if anything is not clear, put a big red flag on it.  I wrote many parts very quickly.

Current coverage is 65.59% (diff: 45.45%)

Merging #1719 into master will decrease coverage by 0.04%

@@             master      #1719   diff @@
==========================================
  Files            54         54
  Lines          6125       6135    +10
  Methods           0          0
  Messages          0          0
  Branches       1210       1211     +1
==========================================
+ Hits           4020       4024     +4
- Misses         1892       1897     +5
- Partials        213        214     +1

Powered by Codecov. Last update e76a8d6...c0eb83f

@iain-buclaw-sociomantic Went ahead and merged this in so we have at least something in there. It would be great to add those missing sections as your time permits.

@obfuscurity - Hi, OK, no problem.
I've just managed to get round to looking at this again, and got graphite-web set-up with some test ceres data.

Configure carbon / graphite to write to and read from ceres. I can do a short section on this later.

Only thing I had to change on the configuration side in local_settings.py was:
STORAGE_FINDERS = (
    'graphite.finders.ceres.CeresFinder',
)

That's pretty much about it on the user side!  This configuration is already documented from the alternative storage finders page, so can check that off the list.


Service Worker support

Hi
I am using Google's Read Through Service worker example, although it works fine without Service Worker's code, offline.js doesn't detect when the connection is lost and SW code kicks in.
Please find the code files attached in this google's github repository link

Hi.
I'm experiencing the same issue with service worker.
It works fine when I load it in online mode, but if I go offline and reload the URL, the first status in "on".
@staminna, did you found a work around?

Hi
No. I’m not into using a project when they take months to reply or don’t help at all.
I have probably used some other solution.
Sorry

On 23 Jun 2018, at 16:10, dupenna<EMAIL_ADDRESS>wrote:
Hi.
I'm experiencing the same issue with service worker.
It works fine when I load it in online mode, but if I go offline and reload the URL, the first status in "on".
@staminna https://github.com/staminna, did you found a work around?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/HubSpot/offline/issues/239#issuecomment-399680957, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfcbOUCOnkiilUnihE9I0qThxOpf_FHks5t_kxCgaJpZM4LoRAB.

Obviously, you should filter in Service Worker fetch to the URL, which you're hitting with Offline, otherwise, SW will return cached reply and Offline will think that everything is ok.


clarify hidden option in readme

Coverage increased (+2.5%) to 100.0% when pulling 4f3fb308bf0d45a8c75e0eefe8af19272aa9d991 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 4f3fb308bf0d45a8c75e0eefe8af19272aa9d991 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 4f3fb308bf0d45a8c75e0eefe8af19272aa9d991 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 4f3fb308bf0d45a8c75e0eefe8af19272aa9d991 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 7951cb5d2a5b24bdf2fb9e5fd54a8f48e0fc4b86 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 7951cb5d2a5b24bdf2fb9e5fd54a8f48e0fc4b86 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Hey @LeFnord I couldn't get the existing example to work, but as requested I added it back. The readme now has both.

Coverage increased (+2.5%) to 100.0% when pulling 79a739962a76726150d2c79f7776bdde18e9fa35 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 79a739962a76726150d2c79f7776bdde18e9fa35 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

Coverage increased (+2.5%) to 100.0% when pulling 79a739962a76726150d2c79f7776bdde18e9fa35 on itransact:clarify-hidden-option into 3b8cb130de0aa54e6052691b54923ebcdc36796f on ruby-grape:master.

thanks @thogg4 … yeah the example … what I mean is this version to hide an endpoint:
desc 'put specific foo', hidden: true
put ':id' do
  # your code goes here
end

and your version of it – this is new to me 😉
patch ':id', hidden:true do
  # your code goes here
end


Request duplication issue

Making a request with the ferry client, repeats identical requests that were made in the past on that client. It doesn't seem to matter if it's a mutation or a query, running an identical request more than once where the request has the exact same data makes it start duplicating itself. In my case:
-I have a ferry client that's instantiated once in my class
-I have a button that calls a function which tells that client to run my request and listen for the response
-First time I push the button it works as expected, I wait for the response, get a single response with the data I wanted
-Afterwards I push the button again which asks that same client to do the same thing
-The function is called once, but the request is executed twice for some reason and I get 2 response.
-If I push the button again, the function is called once, but the request is executed 3 times and I get 3 responses
-This goes on and on, always executing as many times as I've made that request in the past on the client
late Client client;

@override
void onInit() {
  super.onInit();
  var link = HttpLink(
    "https://rickandmortyapi.com/graphql",
  );
  client = Client(link: link);
}

void getRickAndMortyCharacters(){
  print('Fetch');
  var charactersRequest = GCharactersReq(
        (b) => b
  );
  graphqlClient.request(charactersRequest).listen((event) {
    print('Got a fetch reply');
    if(event.hasErrors){
      event.printError();
      event.operationRequest.printError();
      print(event.linkException.toString());
      // print(event.printError());
    }
    else {
      print('It was successful');
      print(event.data.toString());
    }
  });
}

I am also seeing this issue when firing a mutation in my project, almost verbatim to what you are describing. Any luck with a workaround or solution?

@rae-yoder I did find a workaround, you just need to add a unique request ID each time you fire off the request so that they never look the exact same as each other. Kind of annoying to have to add the extra boiler plate to each request just to stop this duplicate request repetition behavior but it works for now. Hopefully this will get fix though. Here's an example where I use the https://pub.dev/packages/uuid package to generate a UUID for each request:
var userRequest =  GUserReq(
(b) => b
..vars.first = 10
..vars.offset = 0
..requestId = Uuid().v1(),
);

I am still observing this exact same issue! Sometimes requests are done twice, even tree times. It seems quite random. Using the ..requestId = Uuid().v1() on my requests does not fix anything.

I tried to reproduce this, but could not.
This was my setup, in the ferry_test_graphql package:

import 'dart:async';

import 'package:ferry/ferry.dart';
import 'package:ferry_test_graphql/queries/__generated__/reviews.data.gql.dart';
import 'package:ferry_test_graphql/queries/__generated__/reviews.req.gql.dart';
import 'package:gql_exec/src/request.dart';
import 'package:gql_exec/src/response.dart';
import 'package:rxdart/rxdart.dart';
import 'package:test/test.dart';

void main() {
  test('request duplication test', () async {
    final client = Client(link: FakeTerminatingLink());

    final completers = [Completer(), Completer(), Completer()];

    late StreamSubscription sub;

    sub= client.request(GReviewsReq((b) => b..fetchPolicy = FetchPolicy.NetworkOnly)).listen((event) {
      print("event 1 ${event.data} ${event.linkException}");
      completers[0].complete();
      sub.cancel();
    });

    await completers[0].future;

    client.request(GReviewsReq((b) => b..fetchPolicy = FetchPolicy.NetworkOnly)).listen((event) {
      print("event 2 ${event.data} ${event.linkException}");
      completers[1].complete();
    });

    client.request(GReviewsReq((b) => b..fetchPolicy = FetchPolicy.NetworkOnly)).listen((event) {
      print("event 3 ${event.data} ${event.linkException}");

      completers[2].complete();
    });

    await Future.wait(completers.map((e) => e.future));

    await client.dispose();
  });
}

class FakeTerminatingLink extends Link {

  int count = 0;

  @override
  Stream<Response> request(Request request, [NextLink? forward]) {
    print("request $count!");
count++;
    return Stream.value(Response(
        data: GReviewsData((b) => b
          ..reviews.add(GReviewsData_reviews((b) => b
            ..id = '1'
            ..stars = 1))).toJson(),
        response: {})).delay(Duration(milliseconds: 100));
  }
}

If someone could provide a reproducible example or describe their setup, I would be grateful.

@knaeckeKami Great! Thanks for coming back!
It seems this issue is hard to reproduce reliably in a test because it happens seemingly randomly. It also seems to be dependent on what is happening in the event loop (maybe both microtask and regular event loop).
The following is based on the pokemom example in the ferry project but run purely in dart:
import 'package:ferry/ferry.dart';
import 'package:gql_http_link/gql_http_link.dart';
import 'package:pokemon_explorer/src/graphql/__generated__/all_pokemon.req.gql.dart';

void main() async {
  final link = HttpLink("https://pokeapi.dev");

  final client = Client(
    link: link,
    defaultFetchPolicies: {
      OperationType.query: FetchPolicy.NoCache,
    },
  );
  while (true) {
    await Future.delayed(Duration(seconds: 3));

    print('do');

    var response = await client
        .request(GAllPokemonReq(
          (b) => b
            ..vars.limit = 50
            ..vars.offset = 0,
        ))
        .first;
    response = await client
        .request(GAllPokemonReq(
          (b) => b
            ..vars.limit = 50
            ..vars.offset = 0,
        ))
        .first;
  }
}

Running this just using dart yields some interesting results using the dart devtools to see actual network requests. The behaviour with duplicate requests sometimes happens sometimes not.
Screenshot from devtools;

Look at the POST timestamps. There should only appear 2 requests side-by-side but sometimes 3 appear and even 4 in some cases. Something strange is happening.

Are you sure that this is not a bug in the devtool? If these were real requests, it would be very unlikely that they start in the same millisecond and take exactly the same time.
https://github.com/flutter/devtools/issues/3607

Couldn't say! I agree with your assessment though!
I guess I'll have to use tcpdump or something else to actually confirm this.
I'm actually looking into this based on some logging from a GraphQL server which showed duplicate requests. Maybe this is completely unrelated. Quite unfortunate if the devtool has this apparent bug.

I tried running your example with this Link:
class LogHttpLink extends Link {
  final String url;

  final HttpLink realLink;

  int reqCount = 0;

  LogHttpLink(this.url) : realLink = HttpLink(url);

  @override
  Stream<Response> request(Request request, [NextLink? forward]) {
    print("DO REQUEST ${request.operation.operationName} ${reqCount++} ");

    return realLink.request(request).map((event) {
      return event;
    });
  }
}

And could not find any duplicated requests (Theoretically it would be possible that HttpLink is the culprit here, but the implementation is pretty straight forward so I think this is highly unlikely).
So if there is a bug in ferry, it seems to be hard to trigger or we are missing the condition that triggers it.

@knaeckeKami Just wanted to update you! There is not issue with Ferry; this is a bug in the dart devtools unfortunately! This issue can be closed in my opinion.


Add option to disable inventory rotation and show 2D sprites instead

This is already implemented: if there is a .png file with the same name as the interactive item, it will be used as its icon. Otherwise, GOAT will generate a Viewport texture with a rotating 3D model (using interactive item's scene).


Use uv workspaces instead of pip

Summary
I don't know what I'm doing and this doesn't work.

The lock file looks okay?
I can't run any scripts because the dependencies don't seem to get installed
I'm probably doing something very wrong

Test Plan
See contributing.md. I didn't get passed uv sync

I'm not sure what you're running exactly but we need to mark Ruff as unmanaged. We don't want to be building Ruff to run scripts.

I try to run uv run --verbose scripts/generate_mkdocs.py. Overall, I try to get the workflow documented in the contributing.md to work.

It's because the workspace members aren't declared as dependencies of the project.

uv run --package ruff-docs --verbose scripts/generate_mkdocs.py does the right thing, but fails because ./docs isn't a valid Python package (it needs src/ruff_docs/__init__.py).

If you add this to docs/pyproject.toml, then uv run --package ruff-docs -- scripts/generate_mkdocs.py  works:
[tool.hatch.build.targets.wheel]
packages = ["src/ruff_docs"]

I think we should re-add that to uv init, it got dropped during code review.

Okay, I don't understand why I would have to declare ruff_docs as a package just so that the generate script can resolve mdformat :confused:

Can you expand on your question?

It's more of an observation. I understand that the packages setting makes the listed package available to other packages. But the generate_mkdocs script doesn't depend on the ruff_docs package. It depends on some of its transitive dependencies.
That's why I think it odd that I have to add ruff_docs to packages just to make the script work. I could understand if I have to move the script into the ruff_docs directory to make it work (so that uv knows that it should run the script with additional third party dependencies).

@MichaReiser - I think part of the problem is that ruff_docs isn't really a package... An alternative is to make these all dev dependencies in the workspace root. Do you find that more intuitive?
diff --git a/pyproject.toml b/pyproject.toml
index eeba1c160..1ab117188 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -8,7 +8,7 @@ version = "0.5.6"
 description = "An extremely fast Python linter and code formatter, written in Rust."
 authors = [{ name = "Astral Software Inc.", email =<EMAIL_ADDRESS>}]
 readme = "README.md"
-requires-python = ">=3.7"
+requires-python = ">=3.8"
 license = { file = "LICENSE" }
 keywords = [
   "automation",
@@ -44,7 +44,18 @@ Documentation = "https://docs.astral.sh/ruff/"
 Changelog = "https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md"

 [tool.uv.workspace]
-members = ["docs", "python/ruff-ecosystem"]
+members = ["python/ruff-ecosystem"]
+
+[tool.uv]
+dev-dependencies = [
+  "PyYAML>=6.0.1",
+  "mkdocs>=1.5.0",
+  "mdformat>=0.7.17",
+  "mdformat-mkdocs>=2.0.4",
+  "mdformat-admon>=2.0.3",
+  "mkdocs-material>=9.1.18",
+  "mkdocs-redirects>=1.2.1",
+]

 [tool.maturin]
 bindings = "bin"

Then uv run -- scripts/generate_mkdocs.py works.

Can I work on this?

@charliermarsh I see. But let's pretend that ruff_docs is a package. What's the recommended way to run generate_mkdocs.py without having to redeclare the dependencies?
@T-256 sure! Feel free to open a new PR. I then close this one

@MichaReiser -- Genuinely trying to follow but I'm a little confused. For (2), you can add a pyproject.toml to ruff_docs, declare the dependencies in that pyproject.toml, and then run uv run --package ruff-docs ./scripts/generate_mkdocs.py. Isn't that the current state of this PR?

Isn't that the current state of this PR?

Not what's described in the CONTRIBUTING.md. So no. I wasn't aware that this is a possibility.
I think where the behavior of uv run differs from what I expected is that I expected uv run ruff_docs/generate_mkdocs to have the same behavior as uv run -p ruff_docs ruff_docs/generate_mkdocs

Oh I see, that running a script in the ruff_docs directory would behave equivalently to running a script from the ruff_docs directory.


Add more irregular verbs

refs https://github.com/rossmeissl/verbs/issues/39

@nerixim any idea why the tests are failing?

@rossmeissl
It must be for the same reason as https://github.com/rossmeissl/verbs/pull/45/files#r544793197


vdk-impala: draft on impala templates

what: Added impala templates for:
Slowly Changing Dimension Type 1
Slowly Changing Dimension Type 2 (subtypes)
Snapshot Accumulating Fact Table
why: Users requested templates similar to the ones in the
vdk-trino plugin. This is the implementation.
testing: currently testing has to be done manually by configuring
an impala instance to connect to by changing the default values
in the impala_configuration.py file. We are unable to use the
test docker instance in the impala plugin as it is too outdated.
Not all tests pass yet. This is still a WIP.
Signed-off-by: mrMoZ1<EMAIL_ADDRESS>

Let's try to follow https://github.com/vmware/versatile-data-kit/wiki/How-to-prepare-a-new-PR#break-your-code-commits-into--small-self-contained-units
Split each template into separate PR is a good way to do that in this concrete case

haven't yet looked at the content of jobs/ in tests/ dir;
lets first enable those jobs run with pytest?

Is it ready for review?


Gateway Error

When I run the exe file, it starts up normally, then gets stuck on 'Waiting for Internet Gateway' and then shows a Gateway Error saying that my router doesn't support UPnP or that it is disabled. My router does have UPnP and it has always been on.

What could I do to resolve this issue?
Thanks.

Frankly, I can only see a hand full of options here. Only two of which you may be able to really do something about:
Windows Firewall
You may have cancelled or incorrectly confirmed the Windows firewall dialog without permitting access to your network (I noticed recently that Windows will sometimes display the dialog with the wrong settings checked leading to applications not getting the access since users do not understand the difference between the private / public / domain network check boxes).
You can check whether the application has access within the control panel (there's a part dedicated to the Firewall in the Security center thingy).
Gateway Control is disabled
Some routers have an additional toggle for internet gateway profile functionality (e.g. viewing the external address, NAT rules, etc) since they also include support for stuff like media servers. If this is the case, NAT control needs to be enabled at the very least for Beacon to detect the router as such and register routes (assuming the profile is implemented correctly; more on that below).
Slow Router
Potentially your router is incredibly slow in replying to UPnP announcements. This is pretty unlikely (yet may occur on cheap ISP models) due to the high timeout I've set on UPnP communication (at least for this particular startup step).
Non-Standard Network Topology
Sometimes home networks are configured differently from the typical modem (or modem router combi) <-> computer setup and this may lead to issues if there's additional routers or repeaters involved. You can only really fix this one by going for a more direct approach or finding a pair of routers that do not interfere here (in my tests this seems to work just fine with most non ISP routers).
Unsupported Router
While it may identify in the UI that it supports UPnP it may not properly implement the internet gateway profile (or not at all). In that case, there's not really anything to be done about this. While I could implement support for some uncompliant scenarios, I'm personally lacking access to an infinite warehouse of shitty routers so the compliance requirement will probably stick until I personally encounter a specimen in the wild.

Thanks for the tips. I'll try to look into some of the things you mentioned and see which ones are causing my problem.


required text

Support for required text in FormTextField.
This PR appends an asterisk to the label, and shows "Required" in red in the helper text after focus is gained and the character count of a required field reaches zero. THe text remains after focus is lost.
This deviates from the spec in one minor way: the required text appears while focused if the char count reaches 0, while it shouldn't be shown until after focus is lost when the char count is 0.

thanks @kaushikrw ! merging.


parameter for the html fotmatter to not clobber the cssfile

(Original issue 396 created by adsworth on 2009-03-02T20:42:00+00:00)
The attached patch adds a new option to the HTML lexer to not clobber the cssfile if it is present. This allowed me to use a user specified cssfile with the full option.
I didn't find a way todo this with the current options.

(Original issue was assigned to gbrandl)
(Original issue 396 last updated on 2009-03-05T10:08:31+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2009-03-05T10:08:31+00:00)
Committed in [d10869c589ff].


New issue after reinstall.

Hi!
Having trouble to make the auto-completion to work for ansible.
I can see that the ansibleServer is started but when i'm coding the tab "auto-completion" won't appear.
When i open a .yaml file the filetype is "yaml.ansible"
I have noticed though that i have two dirs:
/plugged/coc.nvim
/plugged/coc-ansible
added into init.vim:
Plug⋅'yaegassy/coc-ansible',⋅{'do':⋅'yarn⋅install⋅--frozen-lockfile'}
i have also added the neoclide/coc.nvim - works fine with terraform

let g:coc_filetype_map = {
  \ 'yaml.ansible': 'ansible',
  \ }

au BufNewFile,BufRead *.yaml :setl ft=yaml.ansible
au BufNewFile,BufRead *.yml :setl ft=yaml.ansible

CocInfo:
vim version: NVIM v0.9.0
node version: v18.16.0
coc.nvim version: 0.0.82-e51a7cd 2023-05-24 18:08:04 +0900
coc.nvim directory: /home/mr/.config/nvim/plugged/coc.nvim
term: xterm-256color
platform: linux

## Log of coc.nvim

2023-05-30T00:52:21.167 INFO (pid:700933) [extension:coc-git] - Looking for git in: git
2023-05-30T00:52:21.227 WARN (pid:700933) [workspace] - Extension "coc-lists" registered synchronized autocmd "VimLeavePre", which could be slow.
2023-05-30T00:52:21.497 INFO (pid:700933) [plugin] - coc.nvim initialized with node: v18.16.0 after 460
2023-05-30T00:52:21.497 INFO (pid:700933) [services] - LanguageClient YAML Support state change: stopped => starting
2023-05-30T00:52:21.499 INFO (pid:700933) [attach] - receive notification: highlight []
2023-05-30T00:52:21.517 INFO (pid:700933) [language-client-index] - Language server "yaml" started with 700953
2023-05-30T00:52:21.694 INFO (pid:700933) [services] - LanguageClient YAML Support state change: starting => running
2023-05-30T00:52:21.698 INFO (pid:700933) [services] - service yaml started
2023-05-30T00:52:22.136 INFO (pid:700933) [language-client-index] - **Language server "ansibleServer" started with 700970**
2023-05-30T00:52:23.092 INFO (pid:700933) [attach] - Request action: runCommand [ 'ufo.foldingRange', 1 ]
2023-05-30T00:52:23.598 ERROR (pid:700933) [attach] - Request error: runCommand [ 'ufo.foldingRange', 1 ] UfoFallbackException
2023-05-30T00:52:24.457 INFO (pid:700933) [attach] - Request action: doKeymap [ 'i-PGJzPg==' ]
2023-05-30T00:52:24.745 INFO (pid:700933) [attach] - Request action: runCommand [ 'ufo.foldingRange', 1 ]
2023-05-30T00:52:24.848 INFO (pid:700933) [attach] - receive notification: highlight []
2023-05-30T00:52:25.246 ERROR (pid:700933) [attach] - Request error: runCommand [ 'ufo.foldingRange', 1 ] UfoFallbackException
2023-05-30T00:52:28.909 INFO (pid:700933) [attach] - receive notification: showInfo []

Hi, I haven't performed any update tasks on coc-ansible that could potentially be the cause of your issue. I believe the issue lies within your environment, but I'm not sure of the cause.
Could you please follow the steps below and check if there are any logs indicating a possible cause?

Execute :CocCommand workspace.showOutput.
Select ansibleServer and press Enter. Or Select ansible-client and press Enter

Hi!
There are no selection for either ansibleServer or ansible-client in the list.
I can see git/Prettier/vimlsp/snippets/watchman
Thanks for your support!

Thanks for the adjustments. As I believe the issue has been resolved and is now working, I will close this issue.

Hi i don't get it to work. Not sure what i'm doing wrong

It could be related to the version of Ansible you are using. Could you try creating a Python virtual environment and testing it there?
e.g.:
mkdir -p $HOME/ansible-check
cd $HOME/ansible-check
python3 -m venv venv
source venv/bin/activate
pip install ansible ansible-lint

touch site.yml
nvim site.yml

I tried the following steps with docker's fedora:latest. It worked fine in my environment. Unfortunately, I couldn't reproduce your issue.
Prepare:
docker run -it --rm fedora:latest bash

dnf upgrade -y && dnf install vim-enhanced git -y
dnf install nodejs -y
npm i -g yarn

curl -fLo ~/.vim/autoload/plug.vim --create-dirs \
    https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim

cat <<EOF > ~/.vimrc
syntax on
filetype plugin indent on
call plug#begin('~/.vim/plugged')
Plug 'neoclide/coc.nvim', {'branch': 'master', 'do': 'yarn install --frozen-lockfile'}
Plug 'yaegassy/coc-ansible', {'do': 'yarn install --frozen-lockfile'}
Plug 'pearofducks/ansible-vim'
call plug#end()

let g:coc_filetype_map = {
  \ 'yaml.ansible': 'ansible',
  \ }
EOF

mkdir -p $HOME/check
cd $HOME/check
python3 -m venv venv
source venv/bin/activate
pip install ansible ansible-lint

Plugin Install and Check:

Open vim by navigating to $HOME/check and execute the command :PlugInstall.
Once the plugin installation is complete, close any unnecessary windows and execute :e playbook.yml.

Screen shot:

np. but thanks anyway :)


Update toman.php

PAYMENT_GATEWAY should change to TOMAN_GATEWAY in the environment file as instructed in the docs

Thank you for identifying the issue and the PR. The docs are updated, we don't need to change the actual API since it'll introduce breaking change. There is no need to change to the composer.json file too.


Einstein For developers suggesting System.assert instead of Assert class

Summary
When generating test classes Einstein for developers is using system.assert instead of the Assert class that was made available in October 2022,
Is einstein for developers not being trained on latest Apex methods & classes, is there a way to know how old data it has been trained on

Thanks for reporting this issue! We’re aware of this issue and we’ll be working closely with our AI Research team to ensure that responses are following most recent best practices.


[Bug]: Review how useful the Backup and restore Safety test is

Is there an existing issue already for this bug?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[X] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[X] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
No response
Version
1.22.1
What version of Kubernetes are you using?
1.28
What is your Kubernetes environment?
Self-managed: kind (evaluation)
How did you install the operator?
YAML manifest
What happened?
This test was created a couple of years ago and we we should refactor and make some order and how this test works and what we actually want to test since after so many changes is not clear anymore.
This test show it cannot be re-order due to a lack of comments to understand the meaning, since if you only run part of it it works and if you run all of them some times fails randomly
Cluster resource
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This was already removed from the code


[SPARK-5793][SQL] Add explode to Column

Add explode function to Column.

Test build #27426 has started for   PR 4585 at commit 5011ccb.

This patch merges cleanly.

Test build #27426 has finished for   PR 4585 at commit 5011ccb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27426/
Test PASSed.

Test build #27474 has started for   PR 4585 at commit 72d053c.

This patch merges cleanly.

Test build #27474 has finished for   PR 4585 at commit 72d053c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27474/
Test PASSed.

Test build #27489 has started for   PR 4585 at commit b99ad8a.

This patch merges cleanly.

Test build #27489 has finished for   PR 4585 at commit b99ad8a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27489/
Test FAILed.

Test build #27490 has started for   PR 4585 at commit a3d822c.

This patch merges cleanly.

Test build #27490 has finished for   PR 4585 at commit a3d822c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27490/
Test PASSed.

Test build #27512 has started for   PR 4585 at commit 757c5a7.

This patch merges cleanly.

Test build #27512 has finished for   PR 4585 at commit 757c5a7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27512/
Test PASSed.

@rxin any more suggestions?

@rxin is this pr ready to go?

Hey, sorry this didn't make it in for Spark 1.3.  Assuming @rxin thinks this API is reasonable, would you mind updating to master?

Sure.

@marmbrus @rxin Updated to master. Please review it when you have time. Thanks!

Test build #28717 has started for   PR 4585 at commit fa419d5.

This patch merges cleanly.

Test build #28717 has finished for   PR 4585 at commit fa419d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28717/
Test PASSed.

@marmbrus @rxin Can you review this to see if it is okay?

I thought about this more -- I'm not sure how much this brings over the explode function in a DataFrame. On the other hand, I think it would be great to add to the expression functions an explode function that actually explodes arrays or structs.

To elaborate.  If we add this we can't have a very simple method that just explodes repeated fields without any transformation because of overloading and we think that would be more useful.

Agree. If I want to try to add the explode function, add it in this pr or close this and do it in new pr, which is better?

Might be best to just close this one and submit a new pr. Thanks.

okay. Thanks.


Fix positioning of 'Delete draft' link after 2i

https://trello.com/c/rGjDviSL/848-adapt-scheduling-implementation-for-iterated-workflow

Can you provide a screenshot with frontend changes like this? Saves me booting the app up and checking myself! (I'm lazy I know 😆)

@1pretz1 sure - here it is snuggly on the left.


Include of font-awesome font files not resolved at compile-time

The demo throws a HTTP 404 for:
~font-awesome/fonts/fontawesome-webfont.woff2?v=4.7.0

<EMAIL_ADDRESS>is released which doesn't depend on font-awesome.


[RESTEASY-2229] Cs wrapped exception

When CompletionStage completes exceptionally its exceptions are not wrapped, but when they complete exceptionally due to an exception throw in one of its pipeline callbacks (in thenApply() for example) then, CompletionStage wraps the exception before passing it to us. We should unwrap it, otherwise our exception mappers will never match and we get internal errors instead of the expected answers.

Thanks!


Authorization issue at CI step

Following the get started doc, I set up my project as a devops project. However, it fails at CI training step.
There was a resource authorization issue: "The pipeline is not valid. Job Model_CI_Pipeline: Step AzureCLI input connectedServiceNameARM references service connection aml-workspace-connection which could not be found. The service connection does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz.,Job Get_Pipeline_ID: Step getpipelineid input connectedServiceNameARM references service connection aml-workspace-connection which could not be found. The service connection does not exist or has not been authorized for use. For authorization details, refer to https://aka.ms/yamlauthz."

Can someone please guide what I am missing here? I am just trying to follow the doc as it is.

@j-so  I see two service connections created on my devops project namely: 1) azure-resource-connection, 2) WORKSPACE_SVC_CONNECTION. On the variable group, it have variable named WORKSPACE_SVC_CONNECTION with value aml-workspace-connection.
Error seems to be related to authorization. Is it like certain permission elements missing from AAD app level?

The name of your seconds service connection should be "aml-workspace-connection", instead of "WORKSPACE_SVC_CONNECTION".
The service connection should be all you need (you can find it in your workspace as an Owner role). The script expects it to be named "aml-workspace-connection".

Please reopen if you are still having this issue.


Getting a project: required field is not set error

Hi
I'm setting the terraform variables on the plan and apply, but getting the following error message. Using default settings on the example repo using the hard coded US based regions and zone works but setting the location variables europe-west2 seems to be causing issues:
`Error applying plan:
4 error(s) occurred:

google_storage_bucket.vault: 1 error(s) occurred:

google_storage_bucket.vault: project: required field is not set

google_service_account.vault-admin: 1 error(s) occurred:

google_service_account.vault-admin: project: required field is not set

google_storage_bucket.vault-assets: 1 error(s) occurred:

google_storage_bucket.vault-assets: project: required field is not set

module.vault-server.google_compute_firewall.default-ssh: 1 error(s) occurred:

google_compute_firewall.default-ssh: project: required field is not set`

@tazy7 are you running terraform from the module directory or from the example-vault-on-gce directory from the examples repository?
Try following the example here and set these vars before running terraform:
export TF_VAR_region=europe-west2
export TF_VAR_zone=europe-west2-a

@danisla Thanks for coming back to me. I'm running terraform from the root of the terraform-google-vault repo. Tried the export variables and still getting the same issue.

@tazy7 don't run it from the root of terraform-google-vault repo and instead, run it from the example directory.

I had forgotten to recreate the tfvars file. With running from the correct directory and with the export variables I am now getting the following errors:
3 error(s) occurred:

module.vault.google_storage_bucket_object.vault-ca-cert: 1 error(s) occurred:

google_storage_bucket_object.vault-ca-cert: Error, either "content" or "string" must be specified

module.vault.google_storage_bucket_object.vault-tls-key: 1 error(s) occurred:

google_storage_bucket_object.vault-tls-key: Error, either "content" or "string" must be specified

module.vault.google_storage_bucket_object.vault-tls-cert: 1 error(s) occurred:

google_storage_bucket_object.vault-tls-cert: Error, either "content" or "string" must be specified

Have a look at the guide in the README.md for the example, it walks through setting up the KMS keyring for the example:
https://github.com/GoogleCloudPlatform/terraform-google-vault/blob/master/examples/vault-on-gce/README.md

There was an issue with the keyring I was trying to reuse


Missing dependency - alt.data_transformers

The line alt.data_transformers.enable("data_server") in tab1.py causes an error when I try to run it with the current environment file. I'm not sure what the dependency is called, but it needs to be added to the yaml file if we keep that line in.

Error I am getting:
File "tab1.py", line 10, in
alt.data_transformers.enable("data_server")
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/altair/utils/plugin_registry.py", line 177, in enable
return PluginEnabler(self, name, **options)
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/altair/utils/plugin_registry.py", line 27, in init
self.registry._enable(name, **options)
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/altair/utils/plugin_registry.py", line 142, in _enable
ep = entrypoints.get_single(self.entry_point_group, name)
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/entrypoints.py", line 217, in get_single
raise NoSuchEntryPoint(group, name)
entrypoints.NoSuchEntryPoint: No 'data_server' entry point found in group 'altair.vegalite.v4.data_transformer'

Error I am getting:
File "tab1.py", line 10, in
alt.data_transformers.enable("data_server")
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/altair/utils/plugin_registry.py", line 177, in enable
return PluginEnabler(self, name, **options)
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/altair/utils/plugin_registry.py", line 27, in init
self.registry._enable(name, **options)
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/altair/utils/plugin_registry.py", line 142, in _enable
ep = entrypoints.get_single(self.entry_point_group, name)
File "/opt/miniconda3/envs/group22env/lib/python3.8/site-packages/entrypoints.py", line 217, in get_single
raise NoSuchEntryPoint(group, name)
entrypoints.NoSuchEntryPoint: No 'data_server' entry point found in group 'altair.vegalite.v4.data_transformer'

Added altair_data_server to the yaml and it seems to have fixed it.

Added altair_data_server to the yaml and it seems to have fixed it.


Bugfix/1261 empty helptext

Description
Change to how an empty string is handled by the "optional" question help text.
Checklist

[x] Created tests which fail without the change (if possible)

Issue(s)
Fixes #1261

This is not ready to merge. There's a strange interaction with deleting the "optional" question help text.


Contributing file

Create a contributing file for how to contribute to the project to include Fork / Code / Test / Pull Request / Engagement.

PR #170 is open adding this functionality.


error at python -m errbot.cli vith RC 6.1

RC 6.1
Errbot 4.3.4
Python 3.5
At first step I have checked traffic beetwen server but 0 packets was sent from errbot server to RC.

18:09:46 ERROR    aoikrocketchaterrbot      # ----- serve_once failed with error -----
Traceback (most recent call last):
File "/root/errbot-rocketchat/src/aoikrocketchaterrbot/backends/aoikrocketchaterrbot.py", line 621, in serve_forever
self.serve_once()
File "/root/errbot-rocketchat/src/aoikrocketchaterrbot/backends/aoikrocketchaterrbot.py", line 701, in serve_once
self._meteor_client.on('connected', self._meteor_connected_callback)
File "/usr/lib/python3.5/site-packages/pyee-5.0.0-py3.5.egg/pyee/init.py", line 120, in on
return _on(f)
File "/usr/lib/python3.5/site-packages/pyee-5.0.0-py3.5.egg/pyee/init.py", line 114, in _on
self._add_event_handler(event, f, f)
File "/usr/lib/python3.5/site-packages/pyee-5.0.0-py3.5.egg/pyee/init.py", line 130, in _add_event_handler
self._events[event][k] = v
TypeError: unhashable type: 'AoikRocketChatErrbot'

Thanks @przemika
I'll take a look as soon as I can. Let me know if you discover anything.

It's the same on windows server 2016 with python 3.6 and errbot 5.1.3. At first scenerio I used Centos.
I'm not sure I'm doing everything correct.

trying also to get it working, i faced the same issue. It seems that the backend class (AoikRocketChatErrbot) should contain something like
    def __hash__(self):
        return 0  # this is a singleton anyway

It suppress me the error, but still not able to connect ... will keep you updated in case i'm succeeding

Thank you!! @kstevenard
I don't have much time lately to maintain this repository, so if you are able to find a solution and the problem is in this project's code, please send a PR. 👍

i will spend a bit more time in coming days to also support richer message formatting

Opened #5 which fixes the backend for us. 👍


Use AbstractReferenceCounted to clean up the codes for codec-memcache

Motivation:
Some duplicated methods in message types of codec-memcache can be cleaned using AbstractReferenceCounted.
Modifications:
Use AbstractReferenceCounted to avoid duplicated methods.
Result:
Duplicated methods are cleaned.

This one replaced #4784

Cherry-picked into 4.1 as 17df8171b3ad5a0b51aec2d5a54e8f1d220a1892.
@windie thanks!


[MI-2432] Fix testcases for circle CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a9e3faa). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage          ?   58.52%
=========================================
  Files             ?       15
  Lines             ?     1883
  Branches          ?        0
=========================================
  Hits              ?     1102
  Misses            ?      698
  Partials          ?       83

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[TS migration] Migrate 'PushNotification.js' lib to TypeScript

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/24862
Tests

On native Android and iOS:

Remove the app
Freshly install the app
Log-in
Check if there is a prompt asking you to enable notifications

On web and desktop:
Open new dot app, and check if there are no new errors in console

[x] Verify that no errors appear in the JS console

Offline tests
Same as above

QA Steps
Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/91068263/4ed69319-e993-4699-ab1f-40ec2e8f5aef

Android: mWeb Chrome
https://github.com/Expensify/App/assets/91068263/1c9a824e-f19c-41fe-be07-533081f9a74b

iOS: Native
https://github.com/Expensify/App/assets/91068263/a0ae4145-b6af-47dd-aba7-da6e124c661c

iOS: mWeb Safari

https://github.com/Expensify/App/assets/91068263/2c2f6e58-96d7-4a20-bd4f-e964d80153dc

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/91068263/503aab89-2d94-476e-a31c-4592d348abe7

MacOS: Desktop
https://github.com/Expensify/App/assets/91068263/99d0c72b-c71c-4117-a0b6-4aa96623a57a

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[BUG] [MDS] No available datasources or illegal datasource crashes the plugin

What is the bug?
When no datasources available, or illegal option passed in via URL the plugin crashes
How can one reproduce the bug?

enable MDS
navigate to the security dashboards plugin
Pass in either non-existent datasource, or no datasources connected

What is the expected behavior?

What is your host/environment?

OS: [e.g. iOS]
Version [e.g. 22]
Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

[Triage] Hi @derek-ho thanks for filing this issue. The follow-up design you provided seems like a good way to handle this scenario and looks like you have a good start on this. Going to mark triaged.

A way to reproduce this issue:

Log in as admin and create a user with security_rest_api_access role mapped to it (To be able to access the Security tab in left navigation pane)
Create a dataSource connection to another cluster, say 9202.
Now set 9202 as default dataSource.
Log out as admin and login as the newly created user.
Navigate to Security tab and you should see the following screen:

A BIG QUESTION here is if the user doesn't have access to default data-source then Switch to default data-source button is of no use since it will always bring you back to the same screen.

@DarshitChanpura @derek-ho do we have the ability to fetch a list of accessible datasources based on permissions? For instance, can we know that User A definitely has access to Datasource 1?
If so, we may be able to redirect to default if is accessible by the user and otherwise the last accessed datasource they have permission for?
If not, I suggest we enforce access for a disconnected landing page all users can hit. Similar to the login screen where they are not yet auth'd we can kick them back to a landing page regardless of their permissions and then have deterministic behavior in the case where the datasource is not permitted.

do we have the ability to fetch a list of accessible datasources based on permissions? For instance, can we know that User A definitely has access to Datasource 1?

No we do not. DataSources information is stored as saved object inside the kibana and tenant index. When aggregation view is enabled, the user will require read permissions to the tenant which contains that particular datasource.

If not, I suggest we enforce access for a disconnected landing page all users can hit. Similar to the login screen where they are not yet auth'd we can kick them back to a landing page regardless of their permissions and then have deterministic behavior in the case where the datasource is not permitted.

There is no way to enforce that right now, so instead we bring them to a page which allows them to switch to local cluster. This scenario will only be required when aggregation view is enabled. When it is disabled, the page auto-reloads with default datasource.

Corresponding PR closed. No plan to fix.