Problems building the Common image due to something wrong with submodule for protobuf

During building it is unable to pull down the lib/protobufsubmodule.
Step 12/13 : RUN cd ~ && pwd &&   git clone https://github.com/hioa-cs/IncludeOS.git &&   cd IncludeOS &&   git checkout $TAG &&   git submodule update --init --recursive &&   git fetch --tags
 ---> Running in 30d74dc14381
/home/ubuntu
Cloning into 'IncludeOS'...
Note: checking out 'v0.12.0-rc.2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at e2efe3f... Merge pull request #1642 from hioa-cs/dev
Submodule 'NaCl' (https://github.com/includeos/NaCl.git) registered for path 'NaCl'
Submodule 'examples/SQlite/libsl3' (https://github.com/fwsGonzo/libsl3.git) registered for path 'examples/SQlite/libsl3'
Submodule 'examples/SQlite/sqlite3_amalgamation' (https://github.com/fwsGonzo/sqlite3_amalgamation.git) registered for path 'examples/SQlite/sqlite3_amalgamation'
Submodule 'lib/protobuf' (https://github.com/RicoAntonioFelix/protobuf.git) registered for path 'lib/protobuf'
Submodule 'mod/GSL' (https://github.com/Microsoft/GSL.git) registered for path 'mod/GSL'
Submodule 'mod/http-parser' (https://github.com/nodejs/http-parser.git) registered for path 'mod/http-parser'
Submodule 'mod/rapidjson' (https://github.com/miloyip/rapidjson.git) registered for path 'mod/rapidjson'
Submodule 'mod/uzlib' (https://github.com/AnnikaH/uzlib.git) registered for path 'mod/uzlib'
Submodule 'test/lest' (https://github.com/martinmoene/lest.git) registered for path 'test/lest'
Cloning into 'NaCl'...
Submodule path 'NaCl': checked out 'b89312d07abb4cf4986b799e564417be0dfd2484'
Cloning into 'examples/SQlite/libsl3'...
Submodule path 'examples/SQlite/libsl3': checked out '82571daf7f57e85aeaac3e0a6bc22b71cf635fda'
Cloning into 'examples/SQlite/sqlite3_amalgamation'...
Submodule path 'examples/SQlite/sqlite3_amalgamation': checked out '3a804caec5c6ee0a093163175beea5555012e745'
Cloning into 'lib/protobuf'...
fatal: reference is not a tree: 858eef5d12f0932ccbaa244a36dfd7c01a7d909f
Cloning into 'mod/GSL'...
Submodule path 'mod/GSL': checked out '9d13cb14c3cf6b59bd16071929f25ac5516a4d24'
Submodule 'tests/unittest-cpp' (https://github.com/Microsoft/unittest-cpp.git) registered for path 'tests/unittest-cpp'
Cloning into 'tests/unittest-cpp'...
Submodule path 'mod/GSL/tests/unittest-cpp': checked out 'dc6b90838014ab985bf3cd74ac17ad9d00e1fbcb'
Submodule 'docs' (https://github.com/unittest-cpp/unittest-cpp.wiki.git) registered for path 'docs'
Cloning into 'docs'...
Submodule path 'mod/GSL/tests/unittest-cpp/docs': checked out '0aa16abcb2d2516de4ca09c0c5d397243522e7c0'
Cloning into 'mod/http-parser'...
Submodule path 'mod/http-parser': checked out '335850f6b868d3411968cbf5a4d59fe619dee36f'
Cloning into 'mod/rapidjson'...
Submodule path 'mod/rapidjson': checked out 'b596f4e99013dcc2d15f3c71124f15e4330beb3a'
Submodule 'thirdparty/gtest' (https://github.com/google/googletest.git) registered for path 'thirdparty/gtest'
Cloning into 'thirdparty/gtest'...
Submodule path 'mod/rapidjson/thirdparty/gtest': checked out '0a439623f75c029912728d80cb7f1b8b48739ca4'
Cloning into 'mod/uzlib'...
Submodule path 'mod/uzlib': checked out '732e506a57fba99e3862fec0158beb1c9932e70c'
Cloning into 'test/lest'...
Submodule path 'test/lest': checked out 'bea252eec4bc4e0e9fbfd3d4533251d998517cb8'
Unable to checkout '858eef5d12f0932ccbaa244a36dfd7c01a7d909f' in submodule path 'lib/protobuf'
The command '/bin/sh -c cd ~ && pwd &&   git clone https://github.com/hioa-cs/IncludeOS.git &&   cd IncludeOS &&   git checkout $TAG &&   git submodule update --init --recursive &&   git fetch --tags' returned a non-zero code: 1

Hi. The problem with this building is as you say due to protobuf. We have recently moved the protobuf repository and the tag that you are attempting to build from does not contain this update.
Please build the docker container again with: --build-arg TAG=v0.12.0-rc.2 and you should be good to go.
Let me know if there are still any issues after that.

Excellent.. Thanks - that works.


Avoid pushing zero sized function arguments.

This change is

decided to avoid pushing zero_sized vars in push_values.


What's the purpose of this plugin?

I was under the impression that just adding required annotation processor to the compileOnly configuration (or just into classpath for an Ant build) is enough for javac to find it.  Could you please clarify what does this plugin do other than pass annotation processor into classpath for the javac call?

Thanks for the reply!
So a use case would be for example JPA Annotations to generate some helping classes? That then can be used elsewehere in the code? (the projects I see use some Hibernate processing, other than that I don't know what could go on)

That would probably be the metamodel generator then, yes: http://in.relation.to/2009/11/09/hibernate-static-metamodel-generator-annotation-processor/ & http://hibernate.org/orm/tooling/ & http://docs.jboss.org/hibernate/orm/5.3/topical/html_single/metamodelgen/MetamodelGenerator.html

Ahhh I see. Thanks!


Issue on Sony Devices with FabToolbar

Having an issue with Sony devices in particular (Z3 & Z3 Compact) where the icon of the fab is not disappearing from the background when expanded. It doesn't happen on a Galaxy Nexus running JellyBean or Nexus 5 running Marshmallow. The video below demonstrates the issue...
http://clients.intohand.com/demo/XperiaProblem.mov

Ok, I seem to have solved this issue. It was simple really - just needed to give the fabtoolbar_toolbar element a background color. I can only assume it stems from the variable nature of android.support.design.widget.FloatingActionButton. There isn't one in the ReadMe example, and it works just fine on Marshmallow without it, so i didn't think it was needed. But I've added it and it's all fine now, thanks for your attention!

I am so sorry I didn't reply to your message earlier, but I was a bit busy and couldn't really get my hands on Z3. I tried to reproduce the issue on Z2 and Z4 without success so I was waiting to try it on Z3.
I'm happy you found the solution on your own though, thanks!

Thanks for getting back to me. It is better than it was but still is not "fixed". It seems the fab is expanding but the share icon is being treated as part of the background rather than disappearing first. With the fix i mentioned it at least doesn't stay in place once the movement has finished, but you can still see it.

I still can't get my hands on Z3 and fail to reproduce the problem. If you encountered it on any other device/sdk configuration please let me know. The best way would be to see it happen inside the emulator, but that's rather unlikely.
It's like the Transition Drawable does not work for some reason, or the empty drawable is not loaded. Do you get any exceptions in the logcat while starting the activity and/or expanding and collapsing toolbar?
Alternatively I can provide a callback method for start/end of animation and a way to disable the animation (just hide the drawable instead). You can then disable the animation altogether or just disable it based on specific vendor/device. But still, that's more like a workaround for now.


Update getting-started.md

Provided NPM instructions do not persist to a package.json.
Added an important step to initialise the npm package.json before installing prescribed modules.

This is superfluous. If you run npm i -D typescript, a package.json file will be generated.


Fix import error on cfn-signal

Fix #3

thanks for the fix @gianrubio

Can we merge this into master as well @colhom ? :+1:


Controls are too "right hand focussed"

Let me start by saying thank you for your work on this!  I've definitely spent 5+ hrs on this, I keep a stopwatch and track my own high score list. It helps me stay alert if drowsy sometimes while working, a good coffee break. I've been using this since April 2023.
While I admire your homage to Nethack with the hjkl movement, I think an additional key alternative ought to be there on the left side of the keyboard mainly for . open tile. hjkl coupled with . seem too hard on the one's right hand and I feel I might get RSI XD. I think I played long enough to know it might be too stressful on it. Thankfully, f to flag is on the left side and I feel an alternative to open tile nearby, say either of asd, will ease that strain on players a lot.

Hey, thanks for playing the game! I absolutely agree, these things should be customizable, and I should probably put the controls in a config file some day.
If you want to try compiling it yourself, you can easily change the controls here. For example, take a look at the example for opening a tile:
case ',':

If you want to add an extra button (say 'a') for opening tiles, you can just add another case. For example:
case ',':
case 'a':

This is equivalent to the toggle flag case above which has both 'g' and 'f'.
Let me know if you need help compiling! But in essence, you just download this project and put in in a folder, cd to that folder in your terminal, and run make.

Thanks for your detailed instructions for compiling! When I take a stab at this, I'll be sure to let you know if I stumble across anything.

I followed your instructions and I got it to work instantly! Thanks. Voila!
As you said then, we can leave this open as a feature request for customisable controls.

Excellent! Glad it worked out. Yeah, I'll leave this open for otheres 😃 (and sorry for the slow response time)

Hey @joelekstrom, I've really enjoyed playing terminal-mines in my free time and wanted to contribute. I made a pull request to add a rudimentary method of changing controls (#12) if you wanted to give that a look.


BackHandler Composable

Lets hook up something like Compose UI’s BackHandler.
@Composable
fun BackHandler(enabled: Boolean = true, onBack: () -> Unit) {
}

interface FrameContext : ZiplineService {
  var backHandler: BackHandler?
}

interface BackHandler : ZiplineService {
  fun onBack()
}

In Compose:
BackHandler(true /* or state derived */) {
  // must handle
}

I've since come around to this being supported at the Redwood layer because it relies on things like #1116 which previously did not exist.


M3-5537: Table row height too high in Safari

Description
The inline menu actions on the LinodeLanding page were too short. Removing this unnecessary div allows the button to fill the height of the row.
How to test

Open manager in Safari.
Navigate to the LinodesLanding page.
Ensure the Power Off, Reboot, and kabob menu should fill the row vertically when hovered over.
Repeat steps 1 through 3 in Chrome and Firefox.

I've seen the same issue on all ActionMenu's as @tiffwong said. The same issue you fixed for LinodeLanding, appears on other places such as Images Landing and  Volumes Landing but pages such as NodeBalancers, Firewalls, and Kubernetes look fine.

I've seen the same issue on all ActionMenu's as @tiffwong said. The same issue you fixed for LinodeLanding, appears on other places such as Images Landing and Volumes Landing but pages such as NodeBalancers, Firewalls, and Kubernetes look fine.

This seems to be a different issue. I am going to make a different ticket to address these issues.


Reworked the script to work better

Hey!
I took your script and made some changes:

It now checks if the file already exists and does not redownload it if it already exists.
Files are checked against their md5sums now
Installer now does some checks if it did things correctly and exits if it detects an error
Added more verbose output and color coding
Removed two unnecessary dependencies: wget and zenity
Use variables for simpler replacement of urls or file paths
Fix the redist path with the latest allredist.tar.xz
Move camera raw installation to the end of the script
Move deletion of stuff to the end of the script

Hello,
Thanks for your contribution,
I just tested it and sadly it crashes :
installer.sh: 50: Syntax error: "(" unexpected
If you can fix it well great job ^^
Anyway thanks for contribution to this project

Sadly, I can't reproduce this issue. I am using arch linux and tried it with bash, zsh and sh.
The error tells it should be the following two lines:
if ! md5sum --status -c <(echo -e $ALLREDIST_MD5 $ALLREDIST_FILE); then
if ! md5sum --status -c <(echo -e $PHOTOSHOP_MD5 $PHOTOSHOP_FILE); then

Could you please add a space between the < and the ( and try again? If that's the fix then i will update my code.


Set ETag to version of drive after file is added (not before)

Currently, the ETag header is set to drive.version (or entry.seq) of the drive before the file is added to the hyperdrive. Would it make more sense to set the ETag header to the version of the hyperdrive after the file is added?
That way, if example.txt was last modified at version 50, HEAD hyper://PUBLIC-KEY/example.txt would give ETag 50.
This would mean that getting the version of a drive before the file was modified would require subtracting 1 from the Etag.

I would like to stick to information that's in the hyperdrive API as much as possible if that's okay with you.
If you need to get the drive at the current version, you should do a GET on the root, and having the sequence number in the ETag for a file means that you can scroll through the version history by putting the sequence number into the version path without extra math.

Sticking to the hyperdrive API is a good idea. I suppose it's just a bit confusing that entry.seq refers to the version of the hyperdrive before the entry was modified. According to MDN, "Typically, the ETag value is a hash of the content, a hash of the last modification timestamp, or just a revision number." In our case, wouldn't we expect the revision number to be the hyperdrive version after the entry was modified?

having the sequence number in the ETag for a file means that you can scroll through the version history by putting the sequence number into the version path without extra math.

This does simplify history traversal, but it also means that a UI for file metadata should probably increment entry.seq by 1 before displaying the "file version number." Users should be able to load a file at the displayed "file version number" by loading hyper://PUBLIC-KEY/$/version/VERSION-NUMBER/example.txt, and if we don't increment the ETag value, that URL will instead load the file at the prior version. WDYT?

Since the HTTP ETag header traditionally is supposed to provide information about the current state of the returned file, could we just rename the ETag header to something like X-Hyperdrive-Last-Version, while leaving the value what it is now?  That way the label would be more descriptive and accurate, which would make writing clients easier, but it wouldn't require any extra work on the part of hypercore-fetch or hyperdrive.

I'm convinced and will make the changes monday. Principle of least surprise and all that

Oh sorry didnt see the lastest comment yet. Literally woke up for a bit to post 🤣

Great! Thank you :) Either solution works for the hyperdrive.el  I think.

Resolved in 140cc1f.


Error on compiling

Coq 8.18, OCaml 4.10.2
when running make -C proofs
COQC List.v
File "./List.v", line 163, characters 0-374:
Error:
Unable to satisfy the following constraints:
In environment:
merge : forall A : Type, (A -> A -> Z) -> list A -> list A -> list A
A : Type
cmp : A -> A -> Z
l1, l3 : list A
merge_aux : list A -> list A
l2, l, l0 : list A
h1 : A
t1 : list A
h2 : A
t2 : list A

?H : "StrictOrder ?R"

?H0 : "OrderDec ?H"

It seems Z_le_dec works in place of Stdlib.le in the merge function in proofs/List.v

OK thanks for the report! I am able to reproduce the bug, looking for a fix.

The issue should now be fixed on the main branch thanks to https://github.com/formal-land/coq-of-ocaml/pull/230 !


cannot find module vite-plugin-solid-svg types in vite.config.ts

cannot find module vite-plugin-solid-svg types in vite.config.ts

hi @xieccc!
which moduleResolution are you using in your tsconfig?. Should be different from node/node10.

Hi @jfgodoy
I found that the value for moduleResolution in my project tsconfig file is node, and I change it to bundler.
Now it can be run normally.
Thank you.

Hi, after I change to bundler it's still error in my VSCode, but still running perfectly. Maybe because I use NX monorepo?
`import { defineConfig } from "vite";
import solidPlugin from "vite-plugin-solid";
import { nxViteTsPaths } from<EMAIL_ADDRESS>import solidSVG from "vite-plugin-solid-svg";
export default defineConfig({
root: __dirname,
cacheDir: "../../node_modules/.vite/libs/design-system",
server: {
port: 4200,
host: "localhost"
},
preview: {
port: 4300,
host: "localhost"
},
plugins: [solidPlugin(), solidSVG({ defaultAsComponent: true }), nxViteTsPaths()],
// Uncomment this if you are using workers.
// worker: {
//  plugins: [ nxViteTsPaths() ],
// },
build: {
outDir: "../../dist/libs/design-system",
reportCompressedSize: true,
commonjsOptions: {
transformMixedEsModules: true
}
}
});
`

hi @syirilrakhulh, I'm not familiarized with Nx Monorepo, but if you provide a minimal repo I could figure out what's going on


left menu is covering the content

left menu should automatically hide, or open on a button tap
left menu is covering the content
Steps to reproduce:
Open the site in a mobile browser
Screenshots (if applicable):

OS and Browser:
iOS & Safari

Also happens in Chrome DevTools emulation on Windows 10. I don't see any media queries that change how it looks at different breakpoints.

To fix this, need some kind of button to hide the menu like @cybernet says, I'll be watching this issue today, just finish to install all dependencies to run the project.

can i work on this?

@yasirunilan you can work on this, but please ping @jglovier on any UI changes you make here.

@yasirunilan are you still interested in this issue? If not, I'll move it back to Help Wanted.


Make todo-comments snippets with mini.comment

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.comment
Description
Hi @echasnovski I'm wondering if you can convert the following using mini.comment coz I'd prefer using your plugin to Comment.nvim
https://github.com/L3MON4D3/LuaSnip/wiki/Cool-Snippets#all---todo-commentsnvim-snippets

I believe that the only piece of code depending on Comment.nvim here is the get_cstring() function? If yes, does the following snippet work for you?
local get_cstring = function()
  local left, right = unpack(vim.fn.split(vim.bo.commentstring, '%s'))
  return { left or '', right or '' }
end

The 'mini.comment' module works only with whole line commenting, so no need to do anything with block comments.

@echasnovski I'm not sure if it is expected behavior,

It says that get_cstring() doesn't expect arguments, which is true, because it works only for line commenting. No need for opts.ctype.

Also this doesn't seem to work with treesitter commentstring, ex, I set nix ft comment to "# %s", but Luasnip automatically insert /* %s*/. Hope you might have better solution.

It uses vim.bo.commentstring to compute parts. Make sure it is set to an appropriate one.
If you use 'JoosepAlviste/nvim-ts-context-commentstring', then make sure to execute require("ts_context_commentstring.internal").update_commentstring({}) prior. Maybe something like this:
local get_cstring = function()
  require("ts_context_commentstring.internal").update_commentstring({})
  local left, right = unpack(vim.fn.split(vim.bo.commentstring, '%s'))
  return { left or '', right or '' }
end

I will reopen the issue, but feel free to close it if you think it's not worth it. Many thanks for your time and effort!

Yes, I think I am going to close this, as it really has nothing to do with 'mini.comment'.


fix: missing JAVA_HOME value when run cyclondbx build

use the same way in the platform specific script to add change for solaris
in ansible we point installed java to /usr/bin/java so it is safe to use /usr as JAVA_HOME on solaris
move the set JAVA_HOME into a function call and add some debug info when it fails

some detail info:
17:21:51  Exception in thread "main" java.lang.UnsupportedClassVersionError: org/apache/tools/ant/launch/Launcher : Unsupported major.minor version 52.0 17:21:51  	at java.lang.ClassLoader.defineClass1(Native Method) 17:21:51  	at java.lang.ClassLoader.defineClass(ClassLoader.java:800) 17:21:51  	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) 17:21:51  	at java.net.URLClassLoader.defineClass(URLClassLoader.java:449) 17:21:51  	at java.net.URLClassLoader.access$100(URLClassLoader.java:71) 17:21:51  	at java.net.URLClassLoader$1.run(URLClassLoader.java:361) 17:21:51  	at java.net.URLClassLoader$1.run(URLClassLoader.java:355) 17:21:51  	at java.security.AccessController.doPrivileged(Native Method) 17:21:51  	at java.net.URLClassLoader.findClass(URLClassLoader.java:354) 17:21:51  	at java.lang.ClassLoader.loadClass(ClassLoader.java:425) 17:21:51  	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) 17:21:51  	at java.lang.ClassLoader.loadClass(ClassLoader.java:358) 17:21:51  	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:482)
https://ant.apache.org/:
The Apache Ant team currently maintains two lines of development. The 1.9.x releases require Java5 at runtime and 1.10.x requires Java8 at runtime. Both lines are based off of Ant 1.9.7 and the 1.9.x releases are mostly bug fix releases while additional new features are developed for 1.10.x. We recommend using 1.10.x unless you are required to use versions of Java prior to Java8 during the build process.
so for jdk8, we cannot use boot jdk,(which is jdk7) because ant we installed is 1.10.5 which need jdk8+

but by test on build-siteox-solaris10u11-sparcv9-1 i
06:35:32  JDK8_BOOT_DIR: /opt/csw/java/jdk1.8.0_181
06:35:32  /opt/csw/java/jdk1.8.0_181: No such file or directory

so this is something related to the jenkins agent which does not have jdk8 installed?

cleanup code to branch "fix/JAVAHOMESolaris"


Feature: ImageRoleAuthorization + ClusterImageRoleAuthorization resources

[x]  Introduce ImageRoleAuthorization and ClusterImageRoleAuthorization CRDs in the [admin.acorn.io](http://admin.acorn.io) API-Group
[x]  Introduce a feature flag which enables “deny-by-default” for all permissions (unless allowed by one of the above)

How to Test

Install acorn with acorn install --features image-role-authorizations=true
Have an Acorn ready that requests some permissions (you have to know them)
Run the Acorn
Ensure that the Acorn won't start properly and show an permissions denied error in the status output
Create an IRA that covers the image and references a role that covers the permissions - if you don't have a role like that, you can create it as well
Run the Acorn again
Verify that it now starts successfully

Here are some example files:
Acornfile:
containers: web: {
    image: "nginx"
    permissions: {
		// These are permissions that will only be granted for this container in its namespace.
		rules: [
      	  {
            verbs: ["*"],
        	apiGroups: ["foo.bar.com"],
            resources: ["*"]
     	   },
         ]
}

Role + IRA that just allow everything:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: acorn:system:cluster-admin
rules:
- apiGroups:
  - '*'
  resources:
  - '*'
  verbs: ["*"]
---
apiVersion: admin.acorn.io/v1
kind: ImageRoleAuthorization
metadata:
  name: image-role-authz-superadmintest
  namespace: acorn
spec:
  imageSelector:
    namePatterns:
      - "**"
  roles:
    scopes:
      - cluster
    roleRefs:
      - name: acorn:system:cluster-admin
        kind: ClusterRole

Tested with acorn version - v0.9.0-rc1-20-g1fc37ec2+1fc37ec2
This feature is available and the workflow mentioned in the issue works as expected.
Following are the issues found when testing this feature:
https://github.com/acorn-io/runtime/issues/2233
https://github.com/acorn-io/runtime/issues/2234


Make possible to hide the header row

Added the possibility to hide the arrows row:

[ ] Add the hideHeaderRow bool parameter on the package
[ ] Edit the header.dart file to allow the row to respond to the parameter
[ ] Fix the above error when the row doesn't exist:

This was a request from an user of the package, upvote if it's usefull to you.
Gonna try to find some time to add the feature, but in the case someone wants to try, the steps are on the first comment of the issue

Released in 1.3.0


Exception thrown when deleting a key through the Import option

Every time I try to delete a key by importing a file the import endpoint fails with an exception. In our current system we have 196 keys and I used the following json to create a new one:
[
  {
    "id": 197,
    "resourceKey": "Test.NewKey",
    "modificationDate": "2023-02-10T10:50:17.9666667Z",
    "author": "type-scanner",
    "fromCode": true,
    "isModified": false,
    "isHidden": false,
    "translations": [
      {
        "id": 394,
        "resourceId": 196,
        "language": "es-mx",
        "value": "Nueva llave",
        "modificationDate": "2023-02-10T10:50:17.9766667Z"
      }
    ]
  }
]

This works fine and creates the key and the label in the correct places. However, uploading a file without this key (pls change the extension to JSON as it was not supported by Github):
localization-resources-20230406_ESMX.txt
Shows me the correct prompt

But clicking import results in a 500 error:

This is the request payload:
[
   {
      "changeType": 3,
      "selected": true,
      "importingResource": {
         "id": 0,
         "resourceKey": "Test.NewKey",
         "modificationDate": "0001-01-01T00:00:00",
         "author": null,
         "fromCode": false,
         "isModified": null,
         "isHidden": null,
         "notes": null,
         "translations": []
      },
      "existingResource": {
         "id": 208,
         "resourceKey": "Test.NewKey",
         "modificationDate": "2023-05-11T09:43:02.87",
         "author": "import",
         "fromCode": true,
         "isModified": true,
         "isHidden": false,
         "notes": null,
         "translations": [
            {
               "id": 1242,
               "resourceId": 208,
               "language": "",
               "value": "Nueva llave",
               "modificationDate": "2023-05-11T09:43:02.86"
            },
            {
               "id": 1243,
               "resourceId": 208,
               "language": "es-MX",
               "value": "Nueva llave",
               "modificationDate": "2023-05-11T09:43:02.87"
            }
         ]
      },
      "changedLanguages": []
   }
]

The response contains the following stack trace:

System.ArgumentNullException: Value cannot be null. (Parameter 'source')
at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
at System.Linq.Enumerable.Where[TSource](IEnumerable1 source, Func2 predicate)
at DbLocalizationProvider.AdminUI.AspNetCore.ServiceController.ImportFile(List`1 changes)
at lambda_method6195(Closure , Object , Object[] )
at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.SyncActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync()
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
at Microsoft.AspNetCore.Routing.EndpointMiddleware.g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
at Microsoft.AspNetCore.Authorization.Policy.AuthorizationMiddlewareResultHandler.HandleAsync(RequestDelegate next, HttpContext context, AuthorizationPolicy policy, PolicyAuthorizationResult authorizeResult)
at Weir.Global.CMS.Web.Infrastructure.AccessDeniedAuthorizationMiddlewareResultHandler.HandleAsync(RequestDelegate next, HttpContext context, AuthorizationPolicy policy, PolicyAuthorizationResult authorizeResult) in C:\Projects\weir\DXP-CMS\src\Weir.Global.CMS.Web\Infrastructure\AccessDeniedAuthorizationMiddlewareResultHandler.cs:line 25
at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Session.SessionMiddleware.Invoke(HttpContext context)
at React.AspNet.BabelFileMiddleware.Invoke(HttpContext context)
at Weir.Global.CMS.Web.Infrastructure.ImageProcessor.Invoke(HttpContext httpContext, Boolean retry) in C:\Projects\weir\DXP-CMS\src\Weir.Global.CMS.Web\Infrastructure\ImageProcessor.cs:line 37
at Geta.NotFoundHandler.Infrastructure.Initialization.NotFoundHandlerMiddleware.InvokeAsync(HttpContext context, RequestHandler requestHandler)
at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

I did a bit of investigation and it seems the issue is on line 115 of the ServiceController. My bet is on the Json model that is being used to parse the request, but I will leave the rest to you now.
Expected behaviour:
The whole label key gets deleted from the database and does not show up on the Localization table

Hi,
Sorry for super late reply here. It's been a bit hetic lately. But I'm picking up this one..
Seems like issue is from the fact that resource has been imported with "fromCode": false attribute which prevents it from deleting it.
I'll see around - maybe these rules should be ignored when importing resources via files...


[SPARK-46766][SQL][AVRO] ZSTD Buffer Pool Support For AVRO datasource

What changes were proposed in this pull request?

This PR adds ZSTD Buffer Pool Support For AVRO datasource writing with zstd compression codec
Why are the changes needed?

Enable a tuning technique for users
Does this PR introduce any user-facing change?

yes, add a new configuration
How was this patch tested?

passing existing ci shall be sufficient
Was this patch authored or co-authored using generative AI tooling?

no

Hi @dongjoon-hyun I've not found any benchmark for this part in arvo repo or website.
I think we can have one of our own

https://issues.apache.org/jira/browse/SPARK-46772 is created to do the benchmark thing
Thanks @dongjoon-hyun , merged this to master

Thank you, @yaooqinn !


optparse-applicative 0.12

optparse-applicative-<IP_ADDRESS> depended on by:

cabal-debian-4.31.6 (==0.11.*). David Fox<EMAIL_ADDRESS>@ddssff. @ddssff
diagrams-cairo-<IP_ADDRESS> (>=0.10 && < 0.12). FP Complete<EMAIL_ADDRESS>@snoyberg. @bergey @byorgey @fryguybob @jeffreyrosenbluth
diagrams-html5-<IP_ADDRESS> (>=0.10 && < 0.12). Jeffrey Rosenbluth<EMAIL_ADDRESS>@bergey @byorgey @fryguybob @jeffreyrosenbluth
diagrams-lib-<IP_ADDRESS> (==0.11.*). Brent Yorgey<EMAIL_ADDRESS>@bergey @byorgey @fryguybob @jeffreyrosenbluth
diagrams-rasterific-<IP_ADDRESS> (>=0.10 && < 0.12). Jeffrey Rosenbluth<EMAIL_ADDRESS>@bergey @byorgey @fryguybob @jeffreyrosenbluth
diagrams-svg-<IP_ADDRESS> (>=0.10 && < 0.12). Brent Yorgey<EMAIL_ADDRESS>@bergey @byorgey @fryguybob @jeffreyrosenbluth
fay-<IP_ADDRESS> (==0.11.*). Adam Bergmark<EMAIL_ADDRESS>@bergmark
morte-1.3.0 (< 0.12). Gabriel Gonzalez<EMAIL_ADDRESS>@Gabriel439
rasterific-svg-<IP_ADDRESS> (==0.11.*). Vincent Berthoux<EMAIL_ADDRESS>@Twinside
turtle-1.2.1 (==0.11.*). Gabriel Gonzalez<EMAIL_ADDRESS>@Gabriel439
wai-middleware-crowd-<IP_ADDRESS> (==0.11.*). FP Complete<EMAIL_ADDRESS>@snoyberg. @snoyberg

Due to the large number of package maintainers, no need to notify when changes have been made

Looks like stack is the only one that depends on the old optparse-applicative now!
optparse-applicative-<IP_ADDRESS> depended on by:

stack-<IP_ADDRESS> (>=<IP_ADDRESS> && < 0.12). FP Complete<EMAIL_ADDRESS>@snoyberg. @commercialhaskell

However, only the new diagrams-lib supports this version of optparse-applicative, so it will also be blocked on #832.

I've bumped stack's upper bound for optparse-applicative on Hackage.  Sorry about the delay; I wasn't being pinged so I wasn't aware (I've now made myself the maintainer, so in the future I should be pinged).

Only one package remaining, it would be great if we can close this before LTS 4 (probably the coming sunday)

lentil-<IP_ADDRESS> (==0.11.*). Lazlo Grun<EMAIL_ADDRESS>@lazlo28>.

Ah I found a mistake in your "user string" @lazlo28 so that's why you weren't notified before.
I've disabled lentil for now, LTS 4 will ship after new years so if you update lentil before then it will be included. Please open a pull request for that.


unset EDITOR env var crashes navi snippets for "Edit local cheatsheets / config file"

Describe the bug
When the EDITOR environment variable is not set, the "Edit main local cheatsheets" and "Edit config file" snippets crash when running $EDITOR "$f".
The full "Edit main local cheatsheets" snippet is:
f="$(navi info cheats-path)/main.cheat"
[ -f "$f" ] || navi info cheats-example > "$f"
$EDITOR "$f"

When I run this snippet, I get the following error:
bash: line 2: /Users/mgriesen/Library/Application Support/navi/cheats/main.cheat: Permission denied

This is because $EDITOR is not set, meaning it tries to run main.cheat as an executable, which it lacks permissions for.
To Reproduce
Steps to reproduce the behavior:

Run unset EDITOR
Run the "Edit main local cheatsheets" Navi snippet

this command will do so:navi --query "Edit main local cheatsheets" --best-match fn welcome

or run navi fn welcome and select this cheatsheet

Observe above "Permission denied" error

Expected behavior
In these two "Edit" snippets, Navi should identify that the EDITOR env variable is unset, and either:

warn the user and pick a sensible default (e.g. nano, vim, emacs)
crash the snippet and request the user export their choice of EDITOR

Screenshots
Demonstration:

Versions:

Navi: navi 2.20.1

OS: macOS Monterey v12.4 (MacBook Pro 16-inch 2021. Chip: Apple M1 Pro)

Shell Version (sh --version):
 GNU bash, version 3.2.57(1)-release (arm64-apple-darwin21)
 Copyright (C) 2007 Free Software Foundation, Inc.

Shell Version (the one I normally use, zsh --version):
 zsh 5.8.1 (x86_64-apple-darwin21.0)

Additional context
Going forward I'm just going to set my $EDITOR var, but I thought it'd be nice to be aware of this.
Here's a suggestion for Expected Behavior#1 (my preferred, but not sure how portable it is):
f="$(navi info cheats-path)/main.cheat"
[ -f "$f" ] || navi info cheats-example > "$f"

# if $EDITOR is unset, warn the user and pick a default editor
 if [ -z "$EDITOR" ]; then
  echo "(navi) WARNING: Your \$EDITOR environment variable is unset. Using default: /usr/bin/nano"
  EDITOR=/usr/bin/nano
fi

$EDITOR "$f"

Nice catch! I guess I'll make navi fallback to nano, then (in general vim users can use nano but the other way around is uncommon)

Yep, as a vim user I fully agree with your logic there.

That's slick; I need to remember that shell feature for myself.


7486 reduce tooltip over group

Details

My changes consists of:

Setting max boundaries with maxWidth and numberOfLines props.
Get the text width based on how it is wrapped on max boundaries.
Set the blackbox width according to text width on componentDidMount.
Move measureTooltip function, tooltipWidth and tooltipHeight states from Tooltip/index.js  to TooltipRenderedOnPageBody component.

Fixed Issues

$ https://github.com/Expensify/App/issues/7486
Tests

Create a new group on chats side bar.

Add enough users to the group so the amount of emails' texts could make a large text.

Hover over MultipleAvatars icon of your recently created group on Chats side bar.

A multilined tooltip not wider than variables.sideBarWidth should appear with no extra white space on right side of emails.

If the emails are long enough to fit more than 3 lines then no more lines should show and elipsis (...) appear at the end of the text.

Also check this setting on the following:

a. Chat title end elipsis (...).

b. On Report Header title end elipsis

c. chat title end elipsis on Search Page.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[x] If a new CSS style is added I verified that:

[x] A similar style doesn’t already exist
[x] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[] I verified the correct issue is linked in the ### Fixed Issues section above
[] I verified testing steps are clear and they cover the changes made in this PR

[] I verified the steps for local testing are in the Tests section
[] I verified the steps for Staging and/or Production testing are in the QA steps section
[] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

The steps are the same of Tests section.

[x] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

N/A
Desktop

iOS

N/A
Android

N/A

Also, this tooltip settings needs to be applied a few more locations.

LHN chat title end. on ...
same on SearchPage.
And all the other pages where we showing this tooltip.
Report Header. Title of the report page.

Also, this tooltip settings needs to be applied a few more locations.

LHN chat title end. on ...
same on SearchPage.
And all the other pages where we showing this tooltip.
Report Header. Title of the report page.

Apply Tooltip settings on DisplayNames.js, it seems it cover all. I checked the app fairly well and I didn't find more tooltps that need this setting but if you find one let me know.

Is this ready for review?

There are a few more tooltips that need this style. So I am suggesting that you move these
numberOfLines={CONST.TOOLTIP_MAX_LINES}
                                maxWidth={variables.sideBarWidth}

as the default value to the props so it will be applied automatically to all the places and then we can explicitly change it where needed.
What do you think?

Sounds good! actually I thought this was the idea until I asked for default values. Making changes.

Is this ready for review?

Sorry, forgot to notify.

PR updated, ready to review.

@LucioChavezFuentes Could you please show me the screenshots for the screens where you were facing whitespace? Can't find the old ones you shared.

Could you please show me the screenshots for the screens where you were facing whitespace?

Sure, here is one.

The tooltip width is very narrow on the previous screenshot. There is enough room and shouldn't it expand to the maxWidth.

Let me check, do you happen to resize the window after hovering the tooltip?

No. Check the tooltip on report title.

The tooltip width is very narrow on the previous screenshot. There is enough room and shouldn't it expand to the maxWidth.

I'm still investigating about this matter. It looks like it doesn't happen all the time and it fixes when you reload page. I'll post when I have something more clear.

Thank you. Looking forward to it.

The tooltip width is very narrow on the previous screenshot. There is enough room and shouldn't it expand to the maxWidth.

Fixed, I changed to width CSS prop instead of max-width. max-width cause to measureTooltip fire multiple times and setting tooltip styles wich in turn cause to give me unaccurate text.offsetWidth.
@parasharrajat PR updated and ready to reviewed!

Made a simplification, now is truly ready to be reviewed.

@LucioChavezFuentes Please merge main.

PR updated and ready to reviewed.
Now here comes some explanations:
Why not 'tooltipWidth'?

I feel like we can get this value from the this.state.tooltipWidth.
tooltipTextWidth = this.state.tooltipWidth - (spacing.ph2.paddingHorizontal * 2);

To remove the whitespace, we are setting the wrapper width based on tooltip innertext width, not the width of the tooltip itself.
Why 'width' instead of 'max-width' ?

When text is not expanding to MaxWidth which means it is taking lesser space than the MaxWidth allowed, why are we setting the width at all. let it be automatic as it was.

This bug was caused because we get an inaccurate tooltip innertext width and that happened because measureTooltip was called multiple times even after componentDidMount (which sets the tooltip innertext width) is called.
measureTooltip is called by React Native's onLayout, this event is executed every time the style of that component (our wrapper) changes.
max-width makes extra style calculations that triggers the onLayout event even after the component is mounted, so it becomes a race condition between componentDidMount and onLayout event. This doesn't happen all the time (it was hard for me to reproduce the bug) but it happens more commonly to tooltips close to the edge of the screen because there are extra style calculations to position them properly.
If we use width, the browser does not make extra calculations, it just sets the size of our tooltip, prevents more onLayout calls than needed, and then we update it with our tooltip innertext width.

Sure, no problem, I'm staying tuned for any update.

I just made a minor change, forgot to remove a line.

I moved the max-width condition and explained why we can't use onLayout of the Text or measure here.

Thanks @parasharrajat, I updated the comment and change offsetWidth to measure function (to be on sync with the react native way).

PR updated and ready to be reviewed.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Thank you @parasharrajat  and @Beamanator for sticking with me. I know it's been a long thread and I really appreciate your time on many reviews on this pull request.

🚀 Deployed to staging by @Beamanator in version: 1.1.58-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


update file header @link and @license URLs to match the new GitHub URL Attempt #2

Revised/new PR that does not include some whitespace removal.

Thank you for doing this.

Welcome, thanks for accepting it :)


Cool thing! Just want to say congrats on making this

This issue is fixed by reading it ;)

Thank you so much 🤗


Mapping is currently broken

So mapping is currently megabroken.

Doing addmap or loadbp while a client is loaded into the server crashes everything.
savebp 4 foo.yml saved the map for me, but it was just the default map again basically wasting an hour of progress for me.
The mapping documentation is the shittiest.

Sometimes when you're going in and out of aghost, your character will get stuck and be unable to move until you respawn him, which in my case also reset the map wasting progress.
Going into aghost breaks FOV a bit.

Crashing was fixed by https://github.com/space-wizards/RobustToolbox/compare/2bb9105ed938...640deaa8e643

Closing this issue for now as the mapping has been fixed. (I think)


multiclass Y

Thank you for this package @smazzanti .I would like to ask about multi target how it works, same as a single label? I noticed this in the introduction, but it doesn't seem to be in the code.Thanks.

Hi @hoonber, I am not sure: do you mean multilabel or multiclass?
Multiclass (I mean when y has more than 2 possible values, for instance: y = pd.Series([0, 0, 0, 1, 1, 1, 2, 2, 2, 3])) is supported and works seamlessly.
Multilabel (when y is a DataFrame, with more than one column) is not supported yet.

Thank you for your reply.It should be multilabel what I mean.

Same question for Multilabel, and multifeatures.
I tried
# create some polars data
import polars
# data = [(1.0, 1.0, 1.0, 7.0, 1.5, -2.3),
#         (2.0, None, 2.0, 7.0, 8.5, 6.7),
#         (2.0, None, 3.0, 7.0, -2.3, 4.4),
#         (3.0, 4.0, 3.0, 7.0, 0.0, 0.0),
#         (4.0, 5.0, 4.0, 7.0, 12.1, -5.2)]

data = [([1.0, 1.0, 1.0], [1.0, 1.1, 1.2], [1.0, 1.1, 0.9], [7.0, 6.9, 7.2], [1.5], [-2.3, -2.3, -2.3]),
        ([2.0, 2.0, 2.0], [None, None, None], [2.0, 1.9, 1.8], [7.0, 7.1, 6.9], [8.5], [6.7, 6.8, 6.5]),
        ([2.0, 2.0, 2.0], [None, None, None], [3.0, 2.9, 2.8], [6.9, 7.0, 7.1], [-2.3], [4.4, 4.3, 4.2]),
        ([3.0, 3.0, 3.0], [4.0, 3.9, 4.1], [3.0, 3.1, 2.9], [6.9, 7.0, 7.1], [0.0], [0.0, 0.1, 0.2]),
        ([4.0, 4.0, 4.0], [5.0, 4.9, 5.1], [4.0, 3.9, 3.8], [7.0, 7.1, 6.9], [12.1], [-5.2, -5.1, -5.0])]

columns = ["target", "some_null", "feature", "constant", "other_feature", "another_feature"]
df_polars = polars.DataFrame(data=data, schema=columns)

# select top 2 features using mRMR
import mrmr
selected_features = mrmr.polars.mrmr_regression(df=df_polars, target_column="target", K=2, return_scores=True)
print('\nselected_features: ', selected_features)

but got
selected_features:  ([], Series([], dtype: float64), Empty DataFrame
Columns: []
Index: [])

@smazzanti


1983 remove unused scans

See PR #1996.

Closing this PR as work needs to go into defining what the standard for applicable scans needs to be.


Fix Warnings from the Web UI Tests

Add a config to vitest that allows for using after / before / afterAll / beforeAll hooks (and thus silences this warning)
Add a width and height to the e-charts container so that it doesn't output any warning either
Fix warnings that recommends using act when a component re-renders
The tests also reveled that addSpaceToChartsBetweenTests was using payload[0], which isn't correct. This is changed to a simple empty value

Nice!


Update exports from 'has' module

Changed export from has.ts  from { cache, add, default } to { default} and added export * from 'dojo-core/has'.
Addresses issue #38

Not sure how I missed that, there, of course, is no reason for this line to be added. I've removed it now.


Added Queue Creation Animation.

Simply a couple of changes to have the queues added a bit more nicely.
Added the animation that allows for Queues to appear bottom-top when being loaded

The functionality looks good, I was just wondering if there's a simpler/more efficient way of implementing the queue creation animation? This link introduces some standard ways of implementing object movement, maybe check out the section on VECTOR3.MOVETOWARDS?

I agree with @phillip-tian that Vector3.Movetowards seems like a cleaner way of achieving exactly what your code does

there's a merge conflict

I know. This is not done.

@lukasotocerny @phillip-tian see #60


S3 Support for Single File Download

Description

The pull request adds AWS S3 Support for single file download in the dragonfly-client-backend trait through the use of Apache OpenDAL which provides an interface to interact with the s3 storage system.
Related Issue
https://github.com/dragonflyoss/client/issues/495

Motivation and Context
Currently, Dragonfly rust client does not support back-to-source downloading in AWS S3 protocol. Thus, this implementation based on backend trait aims to add such functionality to the system.

Referenced projects:

https://github.com/risingwavelabs/risingwave
https://github.com/apache/opendal

Please refer to conventional commits and change the commit messages. @Zyyeric


feat: allow using arrays as directive argument

Like in the example below, it is now possible to define a directive argument using an array:
https://github.com/accesimpot/graphql-gene/blob/377e03543d520f90ece83a841725741da70a9c5a/packages/dev-playground/src/models/ProductVariant/ProductVariant.model.ts#L51-L53
Also fix the test coverage for @graphql-gene/sequelize-plugin that was not captured. The integration tests are now using the source files which fixed the coverage and allowed me to significantly increase the thresholds in vitest.config.ts:
https://github.com/accesimpot/graphql-gene/blob/377e03543d520f90ece83a841725741da70a9c5a/vitest.config.ts#L35-L40
One step closer to 100% coverage.

:tada: This PR is included in version graphql-gene-v1.3.0-beta.6 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Issue with Nuxt 3 and even Demo Page has issue.

Theres this issue with the plugin.
v.addBinding is not a function

The code seems to be fine but the issue is that the NPM release is referencing an old dependancy
 "tweakpane": "^3.1.0"
If you download the git repo, build it. and then link to the built version, it works as expected.
@vinayakkulkarni  I might be wrong but having read everything, I think You need to bump the package.json version and re-publish

https://stackblitz.com/edit/v-tweakpane?file=src/App.vue
Updated example dir as well as stackblitz with latest version!


Cryptic prepared statement errors

Steps to reproduce
Unknown (error is sporadic)
Expected result
???
Actual result
Randomly, I'm seeing cryptic errors like this:
|  Error: DB error: ERROR: prepared statement "s996" does not exist

Caused by:
    ERROR: prepared statement "s996" does not exist
   NeonDbError: db error: ERROR: prepared statement "s996" does not exist

Then if I reload our app, it runs just fine (with no code changes).
Environment
Node.js 18.x, Lambda, SST, working locally (SST dev mode)

I'm also experiencing these errors.
I'm wondering if it's because I'm using a pooled connection string.

@davidchalifoux I was advised not to use the pooled connection (for now), and to use neonConfig to set this:
import { neon, neonConfig } from '@neondatabase/serverless';

neonConfig.fetchConnectionCache = true;

@conradludgate Am I right in thinking that the latest pgbouncer is now rolled out in production, and is expected to stop this happening?

I believe that deployment of the latest pgbouncer some time ago should have fixed this. Please reopen if that's not the case.


Posted x ago section in comments is incorrect for new comments

If new comment is created, it will say it was posted 59 minutes ago, when it's actually not true, and tooltip shows actual post time (in GMT)

on local servers it's even more wonky, on my local test it says 3 hours. i think it's because on the database side the date is stored as whatever timezone the server's in, but on the local side it reads it as UTC or something

on local servers it's even more wonky, on my local test it says 3 hours. i think it's because on the database side the date is stored as whatever timezone the server's in, but on the local side it reads it as UTC or something

But the thing is even like that, the time will be incorrect if we count difference between timezones

hm right i gotcha, hmm, gotta think abot that some more

Why not implement it in JavaScript

it is https://github.com/Osekai/osekai/blob/main/global/js/comment_system.js#L143
the issue i think at this point is the server is sending a time in UTC+1, but then the code is interpreting it as simply UTC so it thinks it's posted an hour in the future. shouldn't be too impossible to fix

If the server always sending a time in UTC+1, you can use the setHouts function in JavaScript to set it to UTC like this

the better way to do it is to just store dates in UTC instead.

ic😅

this is fixed... temporarily...
in a few months, the timezone will change again, and the dates will go back to being horribly wrong...
maybe, i don't know with the new server at this point...
we will see...


Fix stoke color and non-stroke color in PDFGraphicState

Dear Pdfminer maintainers.
I ran into this issue finding that the color coding for the curve is not saved.
This is traced down to a potential bug.
.color is not an attribute of graphicstate, while scolor and ncolor are.
I think this was a typo from before, and the issue was fixed in do_G and do_g but not in do_RG.

I think you are right.
In e6ad15af79a26c31f4e384d8427b375c93b03533 (in PR #37 by @begnini) the .scolor (stroking color) and .ncolor (non-stroking color) where introduced. However, only .do_SCN used these attributes. Six other functions (.do_G(), .do_g(), .do_RG(), .do_rg(), .do_K(), .do_k()) use the .color attribute, which I find very perculiar.
In 2231f0892e0dd0a9af0d69ed73dc4bc8b2823245 (in PR #129 by @pquentin) 2 methods where fixed: .do_G() and .do_g(), the others remained the same.

Can anyone change the build for pdfminer.six in PyPI with the above changes.

This should be merged before releasing

All PR's should be branched out of "develop" and merged into develop if possible.


An hourly VSI is created instead of a Monthly server instance

An hourly VSI is created instead of a Monthly server instance with the following configuration:
knife softlayer server create --from-file configuration.json -E ??? -N ???
********* configuration.json **************
{
"hostname": "myhostname",
"domain": "???",
"fqdn": "???",
"datacenter": "dal06",
"ram": "32768",
"cores": "4",
"block-storage": "0:100,3:300",
"os-code": "CENTOS_6_64",
"run-list": "???",
"private-network-only": "true",
"network-interface-speed": "1000",
"bill-monthly": "true"
}
********* configuration.json **************

Seems that this line is ignored:
softlayer_server_create
knife softlayer server create --hostname test --domain softlayer.com --bill-monthly --datacenter seo01 --ram 1 --cores 1 --os-code CENTOS_LATEST --block-storage=0:100
It's not possible to create monthly servers


completed issue #16

Fixed #16

Takes user input before hosting the server
Scans the port if it is already in use. If the port is open it throws an error and closes the app
If it is not in use it starts the server

Please make the changes on the client side as the port is hardcoded as well, merging this will break the application.

Also, the port no should be greater than 1025. Ports from 1 to 1025 are reserved by the system, you can read more about this.

Also, can you create a function which has all the logic of port validation and server creation? You can create a separate file to store this function and import it into server.js file. Functional programming is a very standard practice in software development and as a rule of thumb, we don't exceed the number of lines more than 100 in a single file. As server.js is our main file for hosting the server it will be good to write functions and import them already as it is easy to read and maintain. You can take inspiration from the client folder. Also, try to add some comments so that it's easier to onboard others. Thanks!

Also, can you create a function which has all the logic of port validation and server creation? You can create a separate file to store this function and import it into server.js file. Functional programming is a very standard practice in software development and as a rule of thumb, we don't exceed the number of lines more than 100 in a single file. As server.js is our main file for hosting the server it will be good to write functions and import them already as it is easy to read and maintain. You can take inspiration from the client folder. Also, try to add some comments so that it's easier to onboard others. Thanks!

Sure, I'll create a separate function

Added separate file with functions for getting user input and validating the port on the host side
Program asks the client to enter the port number for connecting to the host server

The code looks good to me, have you tried to run this locally? Was it working as expected?

The code looks good to me, have you tried to run this locally? Was it working as expected?

Yes, everything works as expected. I tested and then committed the code


Add Printable

Printable is a new type that changes how printing of Chisel types is represented
It uses an ordered collection rather than a format string and specifiers
Main Features:

Custom String Interpolator for Scala-like printf
String-like manipulation of "hardware strings" for custom pretty-printing
Default pretty-printing for Chisel data types

A few notes and questions:

This does not remove the old printf functionality
This partially resolves @ccelio's need for hardware strings, it allows for strings to be constructed naturally although it will emit the full string for each printf that results
There is a bit of an inconsistency between the new naming API and this which uses FullName and Name. FullName corresponds to instanceName, and Name is just the local name of a field (eg. within a bundle)
Should this actually be a part of Chisel? Here are the reasons it's not currently a library

want the ability to put names of Chisel things in resulting printfs (useful for logging)
want default pretty-printing of Chisel types (Vec prints like Scala Seq, Bundle prints like Scala map)

It is a bit cumbersome to type p"blah blah Decimal(myWire) blah blah" so I suggest that if this is merged we come up with shorthand. Decimal, Hexadecimal, Binary, and Character are just the underlying case class names, we could create other ways to create those Printables

One really powerful feature of all of this is the ability to give a custom pretty printing for custom Bundles.
First, consider the default printing of custom types:
class MyPacket extends Bundle {
  val valid = Bool()
  val addr = UInt(width = 32)
  val data = UInt(width = 64)
  override def cloneType = (new MyPacket).asInstanceOf[this.type]
}
class MyTester extends BasicTester {
  val (count, done) = Counter(Bool(true), 2)
  val myBun = Wire(new MyPacket)
  myBun.addr := UInt(100)
  myBun.data := UInt(1000)
  when (count === UInt(0)) {
    myBun.valid := Bool(false)
  } .otherwise {
    myBun.valid := Bool(true)
  }
  printf(p"@$count: $myBun\n")
  when (done) { stop() }
}

This will print
@0: Bundle(valid -> 0, addr ->        100, data ->                 1000)
@1: Bundle(valid -> 1, addr ->        100, data ->                 1000)

We can change it up a little by adding a custom .toPrintable to our custom Bundle, and even do some basic "hardware string" manipulation
class MyPacket extends Bundle {
  val valid = Bool()
  val addr = UInt(width = 32)
  val data = UInt(width = 64)
  override def cloneType = (new MyPacket).asInstanceOf[this.type]
  override def toPrintable = {
    p"(${this.getClass.getSimpleName}) ${FullName(this)}: " +
    p"[0x${Hexadecimal(addr)}]: $data"
  }
}
class MyTester extends BasicTester {
  val (count, done) = Counter(Bool(true), 2)
  val myBun = Wire(new MyPacket)
  myBun.addr := UInt(100)
  myBun.data := UInt(1000)
  when (count === UInt(0)) {
    myBun.valid := Bool(false)
  } .otherwise {
    myBun.valid := Bool(true)
  }
  val prefix = p"@$count: "
  when (myBun.valid) {
    printf(prefix + p"$myBun\n")
  } .otherwise {
    printf(prefix + p"INVALID\n")
  }
  when (done) { stop() }
}

This prints the following
@0: INVALID
@1: (MyPacket) myBun: [0x00000064]:                 1000

I think this is pretty neat. Unfortunately it does lack the ability to do this conditional "hardware string" manipulation in functions (you can't put whens in the toPrintable method), but eventually we can probably add that feature eventually.

This is cool, but I agree we'd want to sort out the shorthand API.

This is great!  It's been on my Chisel wishlist for years: ucb-bar/chisel#178

Unfortunately, this seems to break chisel-testers and firrtl-interpreter. Details to come.


add architecture diagram to design doc

added to design doc (without scanner)
https://docs.google.com/document/d/1Rz1bkZKZSLVMjC_w8WLASPDUjfU80tjV-XWUXZ8vq3I/edit#heading=h.668byfpymebj


Feature/add missing packageproject options

Fix typos with codespell too

Thanks a lot for updating the options and the spell-check! Just a small request before merging this.

It was right formated?


Log strong earnings when commit objects are garbage collected

Commit objects expose an interface for cleaning the Raft log. When either close() or clean() is called on a commit, the commit is released back to an internal commit pool.  Catalog should log strong earnings to ensure developers properly clean the commit log.

warnings are now logged for garbage collected commits. This feature has already identified some bugs in Atomix.


🚀  Navbar does not automatically close when clicking outside of it (GSSOC'23)

Description of the enhancement. ✍🏻
Issue:
When interacting with the website's navbar, there is an issue where it does not automatically close when clicking on a blank area of the screen outside of the navbar's boundaries.
Expected Behavior:
Clicking on a blank area of the screen outside of the navbar's boundaries should trigger an event that closes the navbar, hiding it from view.
Please assign this issue to me under GSSOC'23 so that I can resolve it.
Describe briefly how you would implement this enhancement.
After Identifying the "blank" area outside the navbar where clicking should trigger the navbar to close, I'll follow the following steps.

1. Attach a click event listener to that area.
2. In the event handler function:
   - Check if the navbar is open.
   - If it is, close the navbar.
Clicked target should not be part of the navbar itself.
3. Optionally, CSS styles or animation transitions for a smooth closing effect.
4. Test thoroughly to ensure the navbar closes when clicking outside and remains open when clicking inside the navbar.
5. Debug any issues that arise during testing.

Screenshots Example (if applicable)
https://github.com/CatsInTech/GitHub-ReadMe/assets/95736430/3f129393-4698-46ec-a8a2-d3d6e3c59995
Additional information
No response
Contributor terms

[X] I agree to follow the Contributing Instructions

Hello @Shakeelkhuhro! Thank you for raising this issue.
Please make sure to follow our Contributing Guidelines. 💪🏻 Don't forget to ⭐ our GitHub-ReadMe. 📃
Our review team will carefully assess the issue and reach out to you soon! 😇 We appreciate your patience! 😀

plz assign this issue to me


Report line and column numbers of the error as (line,column) instead of [line, column]

Bug Report

TSLint version: 5.8.0
TypeScript version: 2.6.1
Running TSLint via: CLI

Actual behavior
TSLint prints lint error in the console as:
ERROR: /Users/Ali/workspace/x/y/z/Test.ts[172, 14]: Parentheses are prohibited around the parameter in this single parameter arrow function

After running TSLint, I'd like to copy the error path, go to the IDE (VSCode), and then directly go to the error positions. There are two problems with the way line and column numbers are printed:

there is a space between comma and the column number and macOS terminal fails to select the full path.
VScode does not recognize square brackets, e.g, [172,14] as a line and column numbers. TypeScript compiler uses () for reporting line and columns and that works fine with VSCode.

Expected behavior
I'd like to see the error message as:
ERROR: /Users/Ali/workspace/x/y/z/Test.ts(172,14): Parentheses are prohibited around the parameter in this single parameter arrow function

I can also create a Pull Request for this isse if this is something you think more people may find useful.

I'm unable to verify for lack of a Mac, but in VSCode on Linux and Windows you can (ctrl+click) the error's file path and it will bring up the offending line/char in the editor pane. This suggests that is also possible on Mac. That said, I have no problem with the error message you're proposing. Hope this helps!

@afroozeh Does the --formatter msbuild option help?

@aervin Thanks! --format msbuild produces the output exactly the way I wanted.


chore: removed value from actionExecutionRequestParamsValueMap

Description

This PR removes the value data from the actionExecutionRequestParamsValueMap field as it contains user data. It also adds the actionExecutionRequestParamsValueMap now for all types of users since the private data is not captured.
Fixes #35904

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10620985550
Commit: 92640e13cd5f3486131ea34754ce5634ca5b8fc0
Cypress dashboard.
Tags: @tag.Sanity
Spec:
Thu, 29 Aug 2024 19:17:16 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit

New Features

Enhanced data privacy by consistently redacting sensitive user-submitted data in analytics events.

Bug Fixes

Removed conditional logic that previously limited parameter inclusion based on hosting environment, ensuring all necessary data is sent without sensitive information.

@NilanshBansal Should we consider updating an existing test case or adding a new one?
Your insights would be appreciated.

@sagar-qa007 this is a chore type change for mixpanel logging. We do not need a test for such changes.


Toggle prevalence manual data entry with a checkbox.

when toggling data entry mode, keep country/state/county information
but mark it as disabled

previously, the button would jump away from user's cursor position,
causing some confusion. Now it stays still.
previously, hitting the manual data entry button would clear
existing location data. This isn't ideal for someone exploring the
interface by clicking on everything.

Omg I love this. So much cleaner. Thank you! 🙏
We just gotta get that failing test to pass. I'm actually not sure at first glance what's causing it. @beshaya ?

Omg I love this. So much cleaner. Thank you! 🙏
We just gotta get that failing test to pass. I'm actually not sure at first glance what's causing it. @beshaya ?

Would like some coding feedback on that DONOTSUBMIT, which works around a type error I don't understand.
Also on the name useManualEntry for the new query param.
Would like some usability/testing feedback overall, too.

Would like some coding feedback on that DONOTSUBMIT, which works around a type error I don't understand.
Also on the name useManualEntry for the new query param.
Would like some usability/testing feedback overall, too.

Oh, this is a bug. I didn't mean for prevalenceDataDate to be saved. Could
you remove it before storing in Calculator.tsx line 114? This could inflate
the prevalence calculated from % positive.
It makes sense that it becomes a string, since the code for persisting it
is JSON.stringify(...)
On Tue, Jan 26, 2021 at 10:09 PM Jenny<EMAIL_ADDRESS>wrote:

Would like some coding feedback on that DONOTSUBMIT, which works around a
type error I don't understand.
Also on the name useManualEntry for the new query param.
Would like some usability/testing feedback overall, too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/pull/685#issuecomment-768056846,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABM25LN2VUJ6JWY4SSN6MR3S36UYZANCNFSM4WTCD7UQ
.

Oh, this is a bug. I didn't mean for prevalenceDataDate to be saved. Could
you remove it before storing in Calculator.tsx line 114? This could inflate
the prevalence calculated from % positive.
It makes sense that it becomes a string, since the code for persisting it
is JSON.stringify(...)
On Tue, Jan 26, 2021 at 10:09 PM Jenny<EMAIL_ADDRESS>wrote:

Would like some coding feedback on that DONOTSUBMIT, which works around a
type error I don't understand.
Also on the name useManualEntry for the new query param.
Would like some usability/testing feedback overall, too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/pull/685#issuecomment-768056846,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABM25LN2VUJ6JWY4SSN6MR3S36UYZANCNFSM4WTCD7UQ
.

I'm excited for this to launch whenever it's ready!

I'm excited for this to launch whenever it's ready!

I think @beshaya would be the best person to review this since I think he might have some advice on some of the coding patterns.
Functionally, it looks great!

I think @beshaya would be the best person to review this since I think he might have some advice on some of the coding patterns.
Functionally, it looks great!

hey Ben, could you explain the refactor request in more detail (or point me to a comment about a refactor that I missed?)

Is this good to go? Or should we have @beshaya give it another review?

Oh I guess @beshaya approved it with his last review. So I say merge away! Thanks for doing this!


"error: cannot find value __f in this scope" within macro body

Describe the bug
The following snippet fails to compile:
use derivative::Derivative;

macro_rules! gen {
    ($name:ident) => {
        #[derive(derivative::Derivative)]
        #[derivative(Debug)]
        pub struct $name {
            a: i32
        }
    };
}

gen!(Test);

fn main() {
    println!("Hello, world!");
}

See error below.
To Reproduce
See snippet above.
Expected behavior
The snippet should compile and derivative should generate a debug impl for every invocation of gen.
Errors
error[E0425]: cannot find value `__f` in this scope
 --> src\main.rs:5:18
  |
5 |         #[derive(derivative::Derivative)]
  |                  ^ not found in this scope

Version (please complete the following information):
rustup 1.19.0 (2af131cf9 2019-09-08)
cargo 1.39.0-nightly (3596cb86b 2019-09-19)
rustc 1.39.0-nightly (97e58c0d3 2019-09-20)
derivative 1.0.3
Additional context
The error seems to appear only when the struct name is a macro parameter.

Same issue on stable (stable-x86_64-pc-windows-msvc - rustc 1.38.0 (625451e37 2019-09-23))
This is a simplified version of a larger piece of code. It used to compile without any issues a few months ago before I updated rust, maybe something changed in rustc in the meantime?

Fixed in https://github.com/mcarton/rust-derivative/pull/60 and released as v2.0.1.


1.27.5: test suite is failing with latest glib

glib 2.65.2.
+ cd libqmi-1.26.2
+ /usr/bin/make -O -j48 V=1 VERBOSE=1 check
Making check in .
Making check in data
Making check in .
make[2]: Nothing to be done for 'check-am'.
Making check in pkg-config
make[2]: Nothing to be done for 'check'.
Making check in build-aux
Making check in templates
make[2]: Nothing to be done for 'check'.
Making check in qmi-codegen
make[2]: Nothing to be done for 'check'.
Making check in .
make[2]: Nothing to be done for 'check-am'.
Making check in src
Making check in libqrtr-glib
make[2]: Nothing to be done for 'check'.
Making check in libqmi-glib
Making check in generated
/usr/bin/make  check-am
make[4]: Nothing to be done for 'check-am'.
Making check in .
make[3]: Nothing to be done for 'check-am'.
Making check in test
/usr/bin/make  check-local
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/libqmi-1.26.2/src/libqmi-glib/test'

** (gtester:961993): WARNING **: 22:35:16.495: Deprecated: Since GLib 2.62, gtester and gtester-report are deprecated. Port to TAP.
TEST: test-utils... (pid=0)

** (gtester:961993): ERROR **: 22:35:16.496: Failed to execute test binary: test-utils: Failed to execute child process ?test-utils? (No such file or directory)
make[4]: *** [Makefile:751: test-nonrecursive] Trace/breakpoint trap (core dumped)
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/libqmi-1.26.2/src/libqmi-glib/test'
make[3]: *** [Makefile:606: check-am] Error 2
make[2]: *** [Makefile:937: check-recursive] Error 1
make[1]: *** [Makefile:400: check-recursive] Error 1
make: *** [Makefile:456: check-recursive] Error 1

ops sorry wron repo :)


Plumb parsed graph id through to graphlib's graph label

This is useful when invoking readMany(), as each graph then has a label that matches that in the dotfile.

This won't work as is because graph labels have to be an object with the graph attributes, for compatibility with graphviz. We could add an id attribute to the graph's attribute set, though (e.g. graph.setGraph({ id: id }).

Like this?

oops - will fix tests and reupload

One test still failing but this fails in a clean checkout too. Do you think this is OK to merge now?

ping @cpettitt

@cpettitt are you interested in merging this patch? The functionality (extracting multiple graphs by name) is something we need.

Published in v0.6.2. Thanks for the patch!


[vcpkg] fix find_library suffix/prefix definitions for iOS

For example, when building dynamic iOS libs for mp3lame, the generated mp3lame-config.cmake would be erroneously looking for libmp3lame.a instead of libmp3lame.dylib.

The change is okay IMO. But do you expect this to fix an immediate problem? Sane ports shouldn't depend on this anyways. (It is for portfile script mode. Project mode gets a regular CMake toolchain setup, and so mp3lame-config.cmake will work as expected.)

Project mode

The issue I saw was due to a app I have using a vcpkg manifest dependency on mp3lame, which was fetched via setting the CMake toolchain to use the vcpkg toolchain (<vcpkg-root>/scripts/buildsystems/vcpkg.cmake) - presumably this is then done in script mode before project mode kicks in to build the app?
https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide

While portfile.cmake's and CMakeLists.txt's share a common syntax and core CMake language constructs (aka "Scripting Commands"), portfiles run in "Script Mode"


Fix changelog for removal of dnb_match app

Description of change
This was put in the wrong directory and never made it to the changelog.
Checklist

[ ] Has a new newsfragment been created? Check changelog/README.md for instructions
[ ] Do any added or updated endpoints appear in the API documentation? See docs/Maintaining the API documentation.md for more details
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

@alixedi Could you have a look at the noise in the CHANGELOG.md diff?


Shin Megami Tensei Devil Survivor Overclocked (USA)

Game Name (and version if necessary)
Shin Megami Tensei Devil Survivor Overclocked
Hardware Specs (If necessary)
No response
Operating System
Windows 11 23H2
Game State
Playable without Audio
Screenshots
No response
Additional information
No response

I've already tested the NTSC-U version.

no it s unimplemented and without audio

yes i've changed it

and without audio

no its not

optional

yes

if i mean to you [notprogramminggames] for not implementing audio to panda3ds

what you will guess to you and me

How is it playable for you? Screenshots? Isn't audio unimplemented? Also i've already tested the NTSC-U version so you just need to put the form in a comment under mine.

You can get audio by tweaking config but only if you use the LLE DSP interpreter which is slow and not recommended

how do i config panda3ds

Thats interesting, what build are you using?

qt build

not the windows build

Shouldn't this be closed and moved over to #107 ?

yes


Added the functionalities for creating, opening and closing a wallet via RPC

Modified a bit to add functionalities for:

Creating a wallet via RPC - when launching the RPC with the argument '--wallet-dir', you are able to create a wallet with the function "create_wallet(filename, password='')" of the class Wallet in wallet.py. However, this function requires the class to be initialized with the argument 'wallet_open' set to value False, which prevents Wallet.refresh() from being invoked.

Example:
w = Wallet(wallet_open=False)
w.create_wallet(filename, password (Optional))

Opening a wallet via RPC - This also requires the same argument as the first one - '--wallet-dir.' You can open a wallet within the same directory you specified in the argument with the function "Wallet(wallet_open=False).open_wallet(filename, password='')"

Closing a wallet via RPC - The function to close the wallet is "close_wallet()." This works with or without '--wallet-dir', since all it needs is a wallet being open in RPC. If, however, one needs to access another wallet file after closing the current wallet, you have to launch the RPC with the '--wallet-dir' argument to access different wallets in the directory.

I just wanted to be able to access multiple wallets within the same directory without relaunching the RPC, which was kind of inconvenience.

I'm quite skeptical about it. This is a very backend-specific solution which gets promoted to the higher level API. Personally I have bad experience with working on wallet dirs. The switch and resync were extremely slow an prone to errors. Perhaps that has changed. What's your experience there?
I'll do a code review as well, as I have some doubts regarding the tests.

Here is the bash command I ran the RPC wallet with:
./monero-wallet-rpc --daemon-address uwillrunanodesoon.moneroworld.com:18089 --disable-rpc-login --wallet-dir . --rpc-bind-port 18088
I tested it with two different remote nodes since I couldn't download the entire blockchain due to a lack of space. The first node I tested with was "node.moneroworld.com:18089," which turned out to be pretty frustrating, with HTTP requests seemingly unable to reach the wallet on a constant basis. Wasn't able to consistently switch between wallets nor create a new wallet.
"requests.exceptions.ReadTimeout: HTTPConnectionPool(host='<IP_ADDRESS>', port=18088): Read timed out. (read timeout=30)"
So this time, I decided to give it another try with another one, which was "uwillrunanodesoon.moneroworld.com:18089." Fortunately, it was surprisingly smooth with no connections to the RPC wallet seeming to drop. Was able to switch between wallets without the timeout error.
Maybe, it has something to do with the connection to the node which might be a factor when it comes to performance of the RPC wallet? I have yet to try with my own local node.

This adds some pretty big binary files under tests/data as well.

I used the "tests/data" directory for the argument "--wallet-dir," which resulted in the creation of new wallet files. I can delete them if you guys find it redundant.

Are those tests able to be run offline? Or they require a prepared environment?
I see no mocking there, so I guess both monero-wallet-rpc and some local or remote daemon should be running to make the test pass. Besides that, the results of the tests wouldn't depend on Python code only and would reflect the setup, network and monero project condition as well. Quite broad spectrum of possible error sources.
From my own experience, without a local daemon any attempt to work with wallet dirs is going to fail. Remote daemons are too... remote. When they're busy, everything goes down. But even with local one nothing seemed stable enough to run a business on top of it.
Monero project is very permissive with accepting new features and some of them aren't maintained further on. I think the wallet dir idea is one of neglected paths in the development. Nobody pushed to make it work well but also nobody volunteered to cut that branch off.
What I'm concerned the most about, is a situation when we include it in the project and make someone depend on it. We could have been bombarded with bug reports and requests we wouldn't be able to properly respond to.

Correct. It requires the wallet daemon to be run in order to make it pass the test, so the result of it largely depends on the connection to a node, which can be sporadic at times. Wish it was less buggy on the node part. I guess I am closing this since the feature seems pretty unstable for the most part.


Blank Screen without any elements

How to Fix ?
This issue happens due to Incorrect Naming
Try to fix it by reading the instruction carefully.
If the issue still persists, create an issue with the following details included.

Error Message "Element with the name: IMAGE cannot be parsed. Would be displayed as Black Rectangle"
Link to the Figma File : https://www.figma.com/file/AjmZ4gxs7JVXeIDaEu3vju/bg?node-id=0%3A1

I would be grateful for any help in this regard.

@Devanshu-17 i might be able to help you out if I can a look at the figma file. I need access for it.


fix: fixed ssh_auth_sock when it's not set

Make sure aztec-run handles SSH_AUTH_SOCK correctly

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,787
1,563
712 (+1%)
742 (+1%)
771

proof_construction_time_sha256_30_ms
11,911
3,186
1,410
1,444
1,477

proof_construction_time_sha256_100_ms
44,255
12,563
5,732
5,597 (+1%)
5,522 (-1%)

proof_construction_time_poseidon_hash_ms
79.0 (+1%)
34.0
34.0
57.0 (-3%)
87.0 (-1%)

proof_construction_time_poseidon_hash_30_ms
1,536
421
201
225 (-4%)
267 (-1%)

proof_construction_time_poseidon_hash_100_ms
5,676
1,535
678
727 (-2%)
750

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,692
6,710
6,716

l1_rollup_execution_gas
611,959
612,128
612,285

l2_block_processing_time_in_ms
248 (-2%)
445 (+1%)
798

l2_block_building_time_in_ms
9,553
18,738 (-1%)
37,245

l2_block_rollup_simulation_time_in_ms
9,552
18,737 (-1%)
37,245

l2_block_public_tx_process_time_in_ms
7,954
16,896 (-1%)
35,344

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
2,763 (+1%)
3,679

node_database_size_in_bytes
12,771,408 (+1%)
16,912,464

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

FeeJuice:_increase_public_balance
94.5
8,139

FeeJuice:set_portal
10.3 (+4%)
2,362

Token:constructor
132 (-1%)
31,107

FPC:constructor
94.5 (+3%)
22,380

FeeJuice:mint_public
79.4 (-2%)
6,150

Token:mint_public
99.9 (+7%)
11,720

Token:assert_minter_and_mint
80.7 (-1%)
8,028

AuthRegistry:set_authorized
9.33 (-19%)
4,537

FPC:prepare_fee
291 (+2%)
8,812

Token:transfer_public
34.6 (+13%)
47,374

FPC:pay_refund
61.7 (+1%)
12,114

Benchmarking:increment_balance
1,015 (-1%)
7,450

Token:_increase_public_balance
21.4 (-1%)
8,960

FPC:pay_refund_with_shielded_rebate
126 (+1%)
12,663

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.154 (+1%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
2.16 (+1%)
3.94
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.112 (+1%)
0.112
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
11.6 (-2%)
17.6 (+1%)
30.6 (+1%)
58.9
112

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.111 (-3%)
0.102
0.0998
0.102
0.100

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
14.3 (+1%)
25.4 (-1%)
42.7 (-1%)
82.7 (+1%)
159 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.109 (+1%)
0.102 (-1%)
0.104 (-1%)
0.102 (+1%)
0.102

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
16.4
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
132
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.105
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
64,756
668,997

Transaction size based on fee payment method
| Metric |  |
| - |  |


Add csv file render support defaultly

will partial fix #4104
Before:

After:

Codecov Report

Merging #4105 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4105   +/-   ##
=======================================
  Coverage   19.97%   19.97%
=======================================
  Files         153      153
  Lines       30494    30494
=======================================
  Hits         6091     6091
  Misses      23489    23489
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb1daad...c13d31e. Read the comment docs.

blocked this until v1.5.0 branched.

wait until fixed what @jvoisin said.

Unfortunately, you can only check that a particular XSS vector is working, not that your application isn't vulnerable.

@jvoisin @lafriks done.


Sub-bullets remove root bullet

Describe the bug
When patching the changelog (using JetBrains/intellij-platform-plugin-template next branch) the sub-bullets replace the root bullet.
To Reproduce
Create a changelog with sub bullets (actual example from my repo)
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Add way to customize vendor path.
  - Also fixed the bug from this PR where it crashed if you didn't configure anything.
- Add ANSI mode parsing (instead of regex-replace-guessing in the output window)

When patched, the new changelog looks like this:
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [2.5.0]
### Added
- - Also fixed the bug from this PR where it crashed if you didn't configure anything.
- Add ANSI mode parsing (instead of regex-replace-guessing in the output window)

Expected behavior
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [2.5.0]
### Added
- Add way to customize vendor path.
  - Also fixed the bug from this PR where it crashed if you didn't configure anything.
- Add ANSI mode parsing (instead of regex-replace-guessing in the output window)

Environment:

OS: Gitlab Runner (Ubuntu)
Gradle Changelog Plugin Version 2.0.0
Gradle Version 7.5.1

I can confirm that bug.
The (valid) markdown is being rendered just fine in the preview:

However, the plugin is rendering this:

https://github.com/YannCebron/m68kplugin/commit/52cf846b4384439723d89fc0ed198dd989b4e97e
since it affected "old" versions I caught it only by accident

I noticed this issue is not specific to (sub-)bullets. The plugin generally seems to skip/remove all but the last paragraph for each bullet. For example,
- AA
- BB

  CC

  DD
- EE

becomes
- AA
- DD
- EE


Don't show DAV\Version::VERSION if DAV\Server::$exposeVersion = false

The version was hidden in the browser plugin since 1.6.2. Since 2.2.0-alpha1 (commit 9a8fe641f5f2c9e9e22a00f780afc26d88defb04) it is visible again accidentally.

Makes sense, thanks!


Reboot host after unlocking instead of boot/kexec

This change reboots the host after successful unlocking instead of
using u-root boot, as the latter cause the boot to fail on some systems.

Added conditional check to only utilize reboot for systems with known issues


Completed Introduction to Node.js

Description 📜
Added documentation that gives an introduction to Node.js #1049

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] MERN

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Please change to File name to 1.1_What_is_node.md
Please keep in mind the serial number

Please change to File name to 1.1_What_is_node.md
Please keep in mind the serial number

Done


chore: bdd-spring-1578704177 to 0.0.1

chore: Promote bdd-spring-1578704177 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment