Replacing a task is in Gradle 4.8 is non deterministic

Reproduction repo
https://github.com/atorok/gradle48_jdk11_replace_task
Expected Behavior
I am aware that replacing tasks has some quirks, but with Gradle 4.8 it just became non deterministic.
Replacing a task in Gradle should work (snippet from the repo above):
Task oldTestTask = project.tasks.findByPath('test')
    project.tasks.remove(oldTestTask)
    RandomizedTestingTask newTestTask = project.tasks.create(name: 'test', type: RandomizedTestingTask)
    newTestTask.dependsOn(oldTestTask.dependsOn)
    newTestTask.dependsOn('testClasses')
    Task checkTask = tasks.findByPath('check')
    checkTask.dependsOn.remove(oldTestTask)
    checkTask.dependsOn.add(newTestTask)
    println "test task is now ${project.tasks.findByPath('test').class}"

Current Behavior
With Gradle 4.8 only, this doesn't sometime work.
Note the output below, running against the sample repo with no changes in-between.
[:~/work/elastic/gradle48_jdk11_replace_task] master(+122/-0,2) ± ./gradlew clean check -s

> Configure project :
test task is now class RandomizedTestingTask_Decorated
Gradle 4.8
10.0.1 (Oracle Corporation 10.0.1+10)
Found the following `test` tasks
:test -> class org.gradle.api.tasks.testing.Test_Decorated

> Task :clean
> Task :compileJava
> Task :processResources NO-SOURCE
> Task :classes
> Task :compileTestJava
> Task :processTestResources NO-SOURCE
> Task :testClasses
> Task :test
> Task :check

BUILD SUCCESSFUL in 0s
4 actionable tasks: 4 executed
[:~/work/elastic/gradle48_jdk11_replace_task] master(+122/-0,2) ± ./gradlew clean check

> Configure project :
test task is now class RandomizedTestingTask_Decorated
Gradle 4.8
10.0.1 (Oracle Corporation 10.0.1+10)
Found the following `test` tasks
:test -> class RandomizedTestingTask_Decorated

> Task :clean
> Task :compileJava
> Task :processResources NO-SOURCE
> Task :classes
> Task :compileTestJava
> Task :processTestResources NO-SOURCE
> Task :testClasses

> Task :test
Running tests
random action

> Task :check

BUILD SUCCESSFUL in 0s
4 actionable tasks: 4 executed

It seems that JDK 11 makes this more reproducible.
Context
The Elasticsearch build replaces the test task so tests are ran with:  http://labs.carrotsearch.com/randomizedtesting.html. Some of our test task configuration is also lost in the process resulting in elastic/elasticsearch#31324.
Steps to Reproduce (for bugs)
Check out the repo and run ./gradlew clean check multiple times.
 Gradle 4.7 uses tasks.create whereas 4.8 uses tasks.createLater

Replacing a task in this way is not reliable as it depends on the order tasks get created in.
Have you tried using overwrite or tasks.replace()?
Alternatively, have you considered simply disabling the default test task, registering your task under a different name and making check depend on it? That might be clearer to users of your build.

I did try tasks.replace with similar results.
I also found #710 to be relevant to this discussion.

@lacasseio Is there a reliable way to replace a lazily created task from a buildscript?

Thank @atorok for the issue and for taking the time to create a wonderful reproducible example. While working on the upcoming lazy task configuration, we opened a big can of worm around what task removal and replacement should really be. At the moment, we are heavily leaning toward deprecating some scenario around task removal and would suggest a different approach.
Debugging the code you provided, I see the issue is related to exactly why task replacement is somehow flawed with the current design. Thanks to the lazy task configuration work, we now add a dependency to a TaskProvider of Test to the check task. The code that removes the test task from the dependsOn of the check task won't remove the TaskProvider and will add a dependency to the new test task. The check task now depends on 2 tasks named test. Since the dependsOn is maintained as a Set and that Gradle assumes only one task of each name should exist, we get a flaky behavior. Since dependsOn can be any type of object, it is wrong to assume we can always remove the task instance itself.
There are two ways to support this use case that I can think of:

Create a distinct task with a different name and disable the test task using test.enabled = false
Get a TaskProvider of the test task using tasks.named('test'). Then you can remove the provider from the dependsOn. This solution is only for completeness as it is sensitive to one of the biggest flaw of task replacement which is registering a task action that assumes the type for a specific task name.

I will validate what we intend to do with such breakage as code like this depends on the internal implementation of the java plugin which is usually unsupported. However, there may be a strong case around the fact that this behavior has been around for a long time and could be considered as essentially public.

@lacasseio thanks for the detailed answer!
We are going to create a task with a different name (elastic/elasticsearch#31324 is tracking this).
We used to replace the task with an implementation that has different fields, so we were breaking comparability not only for task actions, but task configuration as well.
I think that enforcing type safety around task replacement is a good idea, but like you said it might break a lot of builds.
To give some context: the elasticsearch ant build back in the day used a test runner that was developed for Lucene then split of into it's own project (http://labs.carrotsearch.com/randomizedtesting.html). When we migrated to Gradle, we kept this runner. Today Gradle still invokes it trough ant. We have a long term goal to use the default test task for this, however we currently get into a deadlock when we do (I'll submit an issue for that shortly). Other than that, there's some features that I think are we can't replicate easily in the Test task, like randomizing class order. I was thinking maybe we could implement like useTestNG() for our own useRandomizedTesting() to get any missing features, but I don't think there's an extensions mechanism for that, we would have to contribute it and it would have to be accepted. Randomized testing is not that popular but we found it to be extremely valuable. Sorry for going a bit off topic.

I'm happy the diagnostic was helpful for you. The lazy task configuration is aimed to be announced as incubating in the next release. Some names were are factored in the meantime.
It's nice to see the context around the Randomized Testing. I wouldn't suggest extending the Test task to support useRandomizedTesting() as we may move to specialized test task for each test framework. We haven't pushed the discussion too far with regards to JVM testing, however, for the native domain, we will be using a different test task type for each testing framework. I feel you should request for a public API to reuse the internal testing infrastructure so you can use it with Randomized Testing. However, I wouldn't wait for this feature to migrate and use a distinct task. The main benefit of using the internal testing infrastructure is you get support for forking, report generation and build scan support.

Support for forking is a big one for us. Randomized testing does have support for forking, even balancing the tests based on previous run-times, but  we have a multi project build and would benefit significantly from --parallel, having a test runner that doesn't know about Gradles --max-workers and parallelism makes this difficult as we can easily get into the situation of running too many forks.
We would like to move to the Gradle runner, but the single most important missing feature for us is pseudo-randomizing test case order based on a controllable seed. I see there's already a precedent in the Gradle code for changing the test case execution order. @lacasseio would you consider a contribution for that to the Gradle Test task ? We are able to do this  since most of the functionality of randomizedtesting is  implemented in a junit runner so we can still @RunWith, even if the tests are ran by Gradle.

In the general sense, if the feature can be implemented via the already provided public API, we are less likely to make it part of the Gradle core implementation. However, this change when the feature is used/required by a large audience. Think of it as a pattern that everyone uses or should be using. That been said, the best is to open a feature request and discuss this with the other engineers. I know it's not a clear answer because it's often a case-by-case analysis.

Thanks! I opened  #5760.


Partitioning problem occurs when there are letters in partition key.

Questions?

Check the Troubleshooting / FAQ ?
Search the issues ?

Bug Report
Environment

Node version: 8.x
Kafka-node version: 2.2.3

During development I've found an issue with partition key on message sending. I'm trying to send a message with partition key equals to uuid, but getting an error:
{ BrokerNotAvailableError
at new BrokerNotAvailableError (~/devicehive-ws-kafka-proxy/node_modules/kafka-node/lib/errors/BrokerNotAvailableError.js:11:9)
at refreshMetadata.error (~/devicehive-ws-kafka-proxy/node_modules/kafka-node/lib/kafkaClient.js:735:16)
at ~/devicehive-ws-kafka-proxy/node_modules/kafka-node/lib/client.js:508:9
at KafkaClient.wrappedFn (~/devicehive-ws-kafka-proxy/node_modules/kafka-node/lib/kafkaClient.js:374:14)
at KafkaClient.Client.handleReceivedData (~/devicehive-ws-kafka-proxy/node_modules/kafka-node/lib/client.js:764:60)
at Socket. (~/devicehive-ws-kafka-proxy/node_modules/kafka-node/lib/kafkaClient.js:523:10)
at emitOne (events.js:115:13)
at Socket.emit (events.js:210:7)
at addChunk (_stream_readable.js:266:12)
at readableAddChunk (_stream_readable.js:253:11) message: 'Could not find the leader' }

I've also tried to test it a bit and looks like this problem occurs when partition key has letters inside.
I know that native Kafka supports this.
Could you check what the problem is?

Is this still happening? We have tests that cover this so it shouldn't be broken.


Bug during using Select in Modal

Issue type
I'm submitting a ...

[X] bug report
[ ] feature request

Issue description
Current behavior:
When I change value in Select component inside opened modal window, then something weird happened with modal.
Please check this video:
https://streamable.com/lfmxo
It's happening with RN component also.
Expected behavior:
Modal should behave normally
Steps to reproduce:
Add Select component into Modal window
Related code:
I prepared App.js with included modal and select component.
https://pastebin.com/ttfsRbty
Other information:
OS, device, package version
Pixel 2 Emulator, Android 7.0 API 24
UI Kitten: 4.2.0-beta.2

Hi @DonWasyl ! Thanks for the issue, very interesting. I will check and let you know if there are any results. Keep posted.

@DonWasyl, by the way I've already found the bug. The fix will be in the next stable version. Thank you!


make sure typescript demo is plug and play in Atom too

this (temporary) tweak hooks up intellisense and automatic recompile via atom-typescript too.

reference:
https://github.com/TypeStrong/atom-typescript/blob/master/docs/faq.md#declaration-packages-types-are-not-loaded.

LGTM


Added support of custom fade view for transition

First of all, thank you for a great photo viewer library!
In my case there is a need to change background color of viewer. I successfully did it with AXPhotosViewController, but AXPhotosTransitionController is internal of framework, and I had no access to it.
The changes in this pull request does not change protection level of AXPhotosTransitionController, but adds an ability to customize FadeView through AXTransitionInfo.
Also I think there is an option to rewrite fadeView property using lazy. What do u think?

Hey @ashitikov, sorry for the late response!
I think you're right in that there is room for customization with the fadeView. I like the idea of having  a closure that will serve as an initializer. Maybe something like this:
/// The fading backdrop that is displayed while the photo viewer is presenting/dismissing.
@objc public var fadingBackdropView: (() -> UIView) = {
    let view = UIView()
    view.backgroundColor = .black
    return view
}

This way, the fade view is entirely customizable if the developer wants to do something fun like add a UIVisualEffectView as a backdrop.


Cannot download source package

While trying to download packages using the provided link http://s3.cavaliercoder.com/zabbix-contrib/release/zabbix-module-systemd-1.2.0.tar.gz I see the following error page:
<Error>
  AccessDenied
  <Message>Access Denied</Message>
  <RequestId>54D7F9ECB02117F3</RequestId>
  <HostId>
    KelepDF0sW89FQXR/twBE1q7blfHMyTZ+8lKY3/zKsr9/Y8AR4JWAnrZvGOL1MxJNe85o0h/PYo=
  </HostId>
</Error>

Thanks for reporting this. I've fixed the incorrect URLs. Please try again now :)


Add support for dynamically filtered GET

As in https://github.com/codebulb/crudlet/issues/7.

Fixed.


How to handle navigation in flutter

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Proposed title of article
Your title should be descriptive of the article/tutorial. Be Specific. Use keyword research to gain your article higher ranking.
Introduction paragraph (2-3 paragraphs):
One of the core concepts in all mobile applications is navigation, it allows a user to move between different pages. Navigating to different pages defines the workflow in any mobile application. This article will explain the flutter navigation and routing system.
Key takeaways:
At the end of this article, the reader will:
-Understand What navigation is generally in mobile development
-Understand the navigation and routing system in flutter
-Know how to handle navigation in flutter
References:
https://flutter.dev/docs/development/ui/navigation
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

sounds like a cool topic - approved @wobin1

@wobin1 just wanted to follow up on this topic as I'm clearing up the queue where possible? Can be re-opened when needed.
Of perhaps I missed the PR this is attached to?


Rocksdb rpc support

Change Description

Credit: All the coding in the PR was done by Brian Johnson; thanks!
This PR adds RPC support over RocksDb backing store. I have tested with various cleos commands get scope, get account, get currency, get table, create account, issue tokens, and transfer tokens. They all worked,
The goal is to get this into develop so we can fix remaining issues using smaller PRs.
Known issue: system listproducers does not work on RocksDb but works on Chainbase,
Change Type
Select ONE

[ ] Documentation

[ ] Stability bug fix

[x] Other

[ ] Other - special case

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

I think it would be cleaner to just have get_primary_key_value take a std::string and then you could move it into the lambda.

I first tried that and then found out I had to change signatures of several unrelated methods.
I also tried just changing to capture by value and keeping string_view as the type of the parameter. It worked on CentOS 7 container, MacOs and Ubuntu 20. But I was worried about string_view passed to the lambda. Do you think this way is better?

I think it would be cleaner to just have get_primary_key_value take a std::string and then you could move it into the lambda.

I first tried that and then found out I had to change signatures of several unrelated methods.
I also tried just changing to capture by value and keeping string_view as the type of the parameter. It worked on CentOS 7 container, MacOs and Ubuntu 20. But I was worried about string_view passed to the lambda. Do you think this way is better?

All of these methods should be fixed. Returning a lambda with captured references is just asking for trouble.

I think it would be cleaner to just have get_primary_key_value take a std::string and then you could move it into the lambda.

I first tried that and then found out I had to change signatures of several unrelated methods.
I also tried just changing to capture by value and keeping string_view as the type of the parameter. It worked on CentOS 7 container, MacOs and Ubuntu 20. But I was worried about string_view passed to the lambda. Do you think this way is better?

All of these methods should be fixed. Returning a lambda with captured references is just asking for trouble.

Will do. Thanks.

Should be explicit

Sorry, I missed this one. Added.

Financial  help
Please  help out
On Wed, Nov 25, 2020, 23:18 Victor Camacho<EMAIL_ADDRESS>wrote:

@victorj8 commented on this pull request.
In libraries/chain_kv/unit_tests/shared_bytes_tests.cpp
https://github.com/EOSIO/eos/pull/9685#discussion_r530622146:

static constexpr auto* a_value  = "a";

static constexpr auto* a_next_expected = "b";
auto a = shared_bytes(a_value, 1);
BOOST_REQUIRE(memcmp(a.next().data(), reinterpret_cast<const int8_t*>(a_next_expected), 1) == 0);
BOOST_REQUIRE(a.next().size() == 1);

static constexpr auto* aa_value  = "aa";
static constexpr auto* aa_next_expected = "ab";
auto aa = shared_bytes(aa_value, 2);
BOOST_REQUIRE(memcmp(aa.next().data(), reinterpret_cast<const int8_t*>(aa_next_expected), 2) == 0);
BOOST_REQUIRE(aa.next().size() == 2);

static constexpr auto* empty_value  = "";
auto empty = shared_bytes(empty_value, 0);
BOOST_CHECK_THROW(empty.next().size(), eosio::chain::chain_exception);

Done
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EOSIO/eos/pull/9685#discussion_r530622146, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJD44LTU4QNO5PQSGM4AZWLSRVRCHANCNFSM4TZLLFSA
.


Get codemirror up and running in new embed UI

Ideally this should reuse as much code from the existing Playground as possible.

Addressed by @domesticmouse in #938 and #958.


add release notes for 2.6 query workbench

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.6@6a5aee3). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@          Coverage Diff           @@
##             2.6      #48   +/-   ##
======================================
  Coverage       ?   62.76%
======================================
  Files          ?       10
  Lines          ?      658
  Branches       ?      119
======================================
  Hits           ?      413
  Misses         ?      192
  Partials       ?       53

Flag
Coverage Δ

dashboards-query-workbench
62.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@derek-ho can you please check the test failure.

Not sure if related to the failure. There seems a new PR merged this morning: https://github.com/opensearch-project/dashboards-query-workbench/pull/46

I dont think this PR touches an dependencies, shouldn't cause what I'm seeing on the CI. Restarted the build but will check a few more things

I dont think this PR touches any dependencies, shouldn't cause what I'm seeing on the CI. Restarted the build but will check a few more things

okay. then should I include it in the release notes?


For globals that are set to constants, set their value in the .data section

Instead of
_gl : dq 0
...
mov [_gl], 123

just do
_gl: dq 123

This is feasible if we just consider the first setting as the place to remove.

Actually this isn't worth it.


nixos/tachidesk-server: init at 0.7.0

Description of changes
https://github.com/Suwayomi/Tachidesk-Server
A free and open source manga reader server that runs extensions built for Tachiyomi.
Tested the program with different configurations on an headless server.
Added a nixos module and a package called in the module.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I think you'll have to reorder your commits, so you add yourself to the maintainer list before initializing the package

Indeed, I've just reordered them, thanks !

Cool stuff! Just a bit of nits here and there.
I think it would be nice to have a small nixos test to verify that the module runs with a minimal config, but I'm not planning to block the PR if you don't wanna deal with that.

I added a minimal nixos test to check if the port is open !

Cool. Feel free to mark the relevant comments as resolved. I'll have another look through it soon!

I think nixos/tachidesk-server: change password option to passwordFile should probably be merged into nixos/tachidesk-server: init at 0.7.0

I'm having some trouble running the test.
[nix-shell:~/.cache/nixpkgs-review/pr-257733/nixpkgs]$ nix-build -A nixosTests.tachidesk-server
error: attribute 'dataDir' missing

       at /home/h7x4/.cache/nixpkgs-review/pr-257733/nixpkgs/nixos/modules/services/web-apps/tachidesk-server.nix:97:21:

           96|           type = types.path;
           97|           default = cfg.config.dataDir;
             |                     ^
           98|           defaultText = lib.literalExpression "config.dataDir";
(use '--show-trace' to show detailed location information)

Yeah I'm sorry, I force pushed several times so I think you do not have the latest version of my branch : i added a defaultText to fix this

I am sorry to ask but since 23.11 is near its release, do I have to change something on this PR ?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3175

Result of nixpkgs-review pr 257733 run on x86_64-linux 1

2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

1 package built:

tachidesk-server

Module
Reviewed points

[x] module path fits the guidelines
[x] module tests succeed on ARCHITECTURE
[x] options have appropriate types
[ ] options have default -> not all
[ ] options have example
[x] options have descriptions
[x] No unneeded package is added to environment.systemPackages
[x] meta.maintainers is set
[x] module documentation is declared in meta.doc

Possible improvements

Add missing defaults to options (null if no default makes sense)
Add examples to options

Comments

Since it's a new module, there should probably be
an entry in the release notes.

Package
Reviewed points

[x] package name fits guidelines
[x] package version fits guidelines
[x] package builds on x86_64-linux
[x] executables tested on x86_64-linux
[x] all depending packages build

Comments
I ran the executable and got this error:
java.lang.UnsatisfiedLinkError: Can't load library: /nix/store/iym0anb6r2r3iqflwvmsr75a4yk40sv6-openjdk-headless-17.0.7+7/lib/openjdk/lib/libawt_xawt.so
        at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2393)
        at java.base/java.lang.Runtime.load0(Runtime.java:755)

# rest of the stack trace omitted for brevity

Somehow, my previous comment appears to have been deleted. So here's a new one based on it (with some updates)
Module
Reviewed points
* [x]  module path fits the guidelines

* [x]  options have appropriate types

* [ ]  options have default _-> not all of them_

* [ ]  options have example

* [x]  options have descriptions

* [x]  No unneeded package is added to `environment.systemPackages`

* [x]  `meta.maintainers` is set

* [x]  module documentation is declared in `meta.doc`

Possible improvements
* Add missing defaults to options (null if no default makes sense)

* Add examples to options

Comments
* Since it's a new module, there should probably be
  an entry in the release notes.

Package
Reviewed points
* [x]  package name fits guidelines

* [x]  package version fits guidelines

* [x]  package builds on x86_64-linux

* [x]  executables tested on x86_64-linux

* [x]  all depending packages build

Comments
I ran the executable and got this error:
java.lang.UnsatisfiedLinkError: Can't load library: /nix/store/iym0anb6r2r3iqflwvmsr75a4yk40sv6-openjdk-headless-17.0.7+7/lib/openjdk/lib/libawt_xawt.so
        at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2393)
        at java.base/java.lang.Runtime.load0(Runtime.java:755)

# rest of the stack trace omitted for brevity

Oh I don't have this issue on my server (with the module enabled), I try to figure out where this come from.

Could you send me the commands you ran to obtain this result ? With the following commands:
$ nix-build -A tachidesk-server

$ ./result/bin/tachidesk-server

I don't get any error

/result/bin/tachidesk-server

Yup, that's exactly what I ran.

Here's the full log

> nix-build -A tachidesk-server
> ./result/bin/tachidesk-server

23:46:41.600 [main] INFO  suwayomi.tachidesk.server.ServerSetup - Running Tachidesk v0.7.0 revision r1197
23:46:41.799 [main] INFO  suwayomi.tachidesk.server.util.AppMutex - Mutex status is clear, Resuming startup.
23:46:42.018 [main] INFO  suwayomi.tachidesk.server.database.DBManager - Using h2 database version 1.4
23:46:42.153 [main] INFO  de.neonew.exposed.migrations.RunMigrations - Running migrations on database jdbc:h2:/home/mrcjk/.local/share/Tachidesk/database
23:46:42.423 [main] INFO  de.neonew.exposed.migrations.RunMigrations - Database version before migrations: 25
23:46:42.424 [main] INFO  de.neonew.exposed.migrations.RunMigrations - Migrations finished successfully
java.lang.ExceptionInInitializerError
        at dorkbox.jna.linux.GtkEventDispatch.startGui(GtkEventDispatch.java:80)
        at dorkbox.systemTray.SystemTray.get(SystemTray.java:651)
        at suwayomi.tachidesk.server.util.SystemTray.systemTray(SystemTray.kt:31)
        at suwayomi.tachidesk.server.ServerSetupKt$systemTrayInstance$2.invoke(ServerSetup.kt:54)
        at suwayomi.tachidesk.server.ServerSetupKt$systemTrayInstance$2.invoke(ServerSetup.kt:54)
        at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
        at suwayomi.tachidesk.server.ServerSetupKt.getSystemTrayInstance(ServerSetup.kt:54)
        at suwayomi.tachidesk.server.ServerSetupKt.applicationSetup(ServerSetup.kt:145)
        at suwayomi.tachidesk.MainKt.main(Main.kt:14)
        at suwayomi.tachidesk.MainKt.main(Main.kt)
Caused by: java.lang.RuntimeException: We apologize for this, but we are unable to determine the GTK library is in use, or even if it is in use... Please create an issue for this and include your OS type and configuration.
        at dorkbox.jna.linux.GtkLoader.<clinit>(GtkLoader.java:260)
        ... 10 more
23:46:42.696 [main] INFO  suwayomi.tachidesk.server.util.WebInterfaceManager - WebUI Static files exists and is the correct revision
23:46:42.697 [main] INFO  suwayomi.tachidesk.server.util.WebInterfaceManager - Verifying WebUI Static files...
23:46:42.721 [main] INFO  suwayomi.tachidesk.server.util.WebInterfaceManager - md5: 1af53126be02cba56e539444603b1a09
23:46:42.721 [main] INFO  suwayomi.tachidesk.server.JavalinSetup - Serving web static files for WebUI
23:46:42.744 [main] WARN  io.javalin.Javalin - JDK15 and Kotlin 1.5 break reflection in different ways - the OpenAPI plugin will not work properly. Please visit https://github.com/tipsy/javalin/issues/1193 if you want to help fix this issue.
23:46:42.744 [main] WARN  io.javalin.Javalin - You can disable this warning by doing `OpenApiVersionUtil.logWarnings = false`
23:46:42.753 [main] INFO  io.javalin.Javalin -
       __                      __ _            __ __
      / /____ _ _   __ ____ _ / /(_)____      / // /
 __  / // __ `/| | / // __ `// // // __ \    / // /_
/ /_/ // /_/ / | |/ // /_/ // // // / / /   /__  __/
\____/ \__,_/  |___/ \__,_//_//_//_/ /_/      /_/

          https://javalin.io/documentation

23:46:42.753 [main] INFO  io.javalin.Javalin - Starting Javalin ...
23:46:42.760 [main] INFO  io.javalin.Javalin - You are running Javalin 4.6.6 (released October 2, 2022. Your Javalin version is 454 days old. Consider checking for a newer version.).
23:46:42.823 [main] INFO  io.javalin.Javalin - Static file handler added: StaticFileConfig(hostedPath=/, directory=/home/mrcjk/.local/share/Tachidesk/webUI, location=EXTERNAL, precompress=false, aliasCheck=null, headers={Cache-Control=max-age=0}). File system location: '/home/mrcjk/.local/share/Tachidesk/webUI'
23:46:42.823 [main] INFO  io.javalin.Javalin - Static file handler added: StaticFileConfig(hostedPath=/, directory=META-INF/resources/webjars, location=CLASSPATH, precompress=false, aliasCheck=null, headers={Cache-Control=max-age=31622400}). File system location: 'jar:file:/nix/store/n1y01rrhx2s3jdnk8x2c806rsw1jsprl-Tachidesk-Server-v0.7.0-r1197.jar!/META-INF/resources/webjars'
23:46:42.823 [main] INFO  io.javalin.Javalin - Listening on http://<IP_ADDRESS>:4567/
23:46:42.823 [main] INFO  io.javalin.Javalin - Javalin started in 70ms \o/
java.lang.UnsatisfiedLinkError: Can't load library: /nix/store/y33fifmr59gzsswsvradpkskzz62xczx-openjdk-headless-17.0.7+7/lib/openjdk/lib/libawt_xawt.so
        at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2393)
        at java.base/java.lang.Runtime.load0(Runtime.java:755)
        at java.base/java.lang.System.load(System.java:1953)
        at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
        at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:388)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:232)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:174)
        at java.base/jdk.internal.loader.NativeLibraries.findFromPaths(NativeLibraries.java:315)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:285)
        at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2398)
        at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:818)
        at java.base/java.lang.System.loadLibrary(System.java:1989)
        at java.desktop/java.awt.Toolkit$2.run(Toolkit.java:1388)
        at java.desktop/java.awt.Toolkit$2.run(Toolkit.java:1386)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
        at java.desktop/java.awt.Toolkit.loadLibraries(Toolkit.java:1385)
        at java.desktop/java.awt.Toolkit.initStatic(Toolkit.java:1423)
        at java.desktop/java.awt.Toolkit.<clinit>(Toolkit.java:1397)
        at java.desktop/java.awt.Desktop.isDesktopSupported(Desktop.java:329)
        at dorkbox.desktop.Desktop.awtSupported(Desktop.java:297)
        at dorkbox.desktop.Desktop.browseURL(Desktop.java:146)
        at dorkbox.desktop.Desktop.browseURL(Desktop.java:122)
        at suwayomi.tachidesk.server.util.Browser.openInBrowser(Browser.kt:30)
        at suwayomi.tachidesk.server.JavalinSetup.javalinSetup$lambda$3$lambda$2(JavalinSetup.kt:75)
        at io.javalin.core.event.EventManager.fireEvent(EventManager.kt:18)
        at io.javalin.Javalin.start(Javalin.java:176)
        at io.javalin.Javalin.start(Javalin.java:148)
        at io.javalin.Javalin.start(Javalin.java:134)
        at suwayomi.tachidesk.server.JavalinSetup.javalinSetup(JavalinSetup.kt:78)
        at suwayomi.tachidesk.MainKt.main(Main.kt:15)
        at suwayomi.tachidesk.MainKt.main(Main.kt)
^[^C23:46:48.317 [Thread-14] INFO  io.javalin.Javalin - Stopping Javalin ...
23:46:48.322 [Thread-14] INFO  io.javalin.Javalin - Javalin has stopped

I just tried replacing jdk17_headless with jdk17, and it runs fine - but it opens a browser window.

:thinking: I was able to fix it by adding a -Dsuwayomi.tachidesk.config.server.initialOpenInBrowserEnabled=false flag to the wrapper:
  buildCommand = ''
    makeWrapper ${jdk}/bin/java $out/bin/tachidesk-server --add-flags "-Dsuwayomi.tachidesk.config.server.initialOpenInBrowserEnabled=false -jar $src"
  '';

Thanks! I also found a fix by adding -Djava.awt.headless=true to the JVM args. What do you think better suited ?

Thanks! I also found a fix by adding -Djava.awt.headless=true to the JVM args. What do you think better suited ?

I tried that, and it got rid of the linker error, but it still tried to open a browser window.

Okay! I'll work on those changes as soon as possible

I fixed the small issues I found after testing, and I didn't manage to make the package run with the non-headless jdk17. I got a SIGSEGV because of GTK. As the program is intended to run in the browser and can run without issue with the jdk17_headless, I think it is not a big issue if initialOpenInBrowserEnabled is always set to false.
Moreover, I added an option enableSystemTray which is recommended by the wiki for headless servers.

I think I resolved everything that was asked and I tested all the changes on my server

I think I resolved everything that was asked and I tested all the changes on my server

On my end, these two points are still open:

[ ] Add a the new module to the 24.05 release notes.
[ ] Add example attributes to the module options.

I think I resolved everything that was asked and I tested all the changes on my server

On my end, these two points are still open:
* [ ]  Add a the new module to the [24.05 release notes](https://github.com/NixOS/nixpkgs/blob/3cb442f49442e3dc76ecc661fbe236362396da8e/nixos/doc/manual/release-notes/rl-2405.section.md).

* [ ]  Add `example` attributes to the module options.

Oh I'm sorry I was talking about the points of the other review. I forgot to do this, I'll do it now: should I add example to all module options? And I will search how to include this module in the release notes

should I add example to all module options?

Tbh, I don't know if it's a hard requirement. I don't think it's necessary for trivial (e.g. boolean) options, but otherwise I would say it's a good idea.

Okay I added examples where it seems needed, and I added the release note.

@SuperSandro2000 sorry to ping you: is it okay for you as well or should I make final changes ? ^^

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1379

Cool stuff! Just a bit of nits here and there.
I think it would be nice to have a small nixos test to verify that the module runs with a minimal config, but I'm not planning to block the PR if you don't wanna deal with that.

A minimal test have been added in the module so that it checks that the given port is listening after the start.

I have a final few comments, hope you don't mind :)

No problem ^^ I'm happy this MR is not forgotten x).
I will solve this tomorrow!

Also, would you mind moving most of the review stuff from the release notes commit to the nixos/tachidesk-server commit?

Also, would you mind moving most of the review stuff from the release notes commit to the nixos/tachidesk-server commit?

Indeed it is more coherent ^^', I just fix a liitle problem on my tests and I do this.

Okay I did three things :

I chaged buildCommand to buildPhase as you suggested
I put the changes in the correct commits
I put users.users.tachidesk.home = cfg.dataDir back because the program tachidesk-server looks at ~/.local/Tachidesk to write its setup. I let a comment not to forget what it's for

the program tachidesk-server looks at ~/.local/Tachidesk to write its setup. I let a comment not to forget what it's for

Whoah, okay. Cool

I put the changes in the correct commits

It's still a bit of a mess though. If you inspect https://github.com/NixOS/nixpkgs/commit/f41a3de4bdbeb5e2f0cd3fc3d4b60c815316c32d and 1b8aa9e, you'll see that they have a bunch of non-test and non-release-note related changes. There's also a small weirdness with introducing nixosTests and removing it again in the first two commits, but it's not as critical.

the program tachidesk-server looks at ~/.local/Tachidesk to write its setup. I let a comment not to forget what it's for

Whoah, okay. Cool

I put the changes in the correct commits

It's still a bit of a mess though. If you inspect f41a3de and 1b8aa9e, you'll see that they have a bunch of non-test and non-release-note related changes. There's also a small weirdness with introducing nixosTests and removing it again in the first two commits, but it's not as critical.

Oh I'm sorry I'm not still really used to it  ^^', I try to fix this

Okay I hope it's now correct

Should I change something else or does everything is fine for you ?

Hello again. I've been working on some changes that I thought would be painful to do through the review system. I think Sandros earlier comment about freeform was meant to hint at making the module in accordance with RFC-42. This means including all settings that go into the config file into a settings attribute, and making that one freeform so that any non-declared settings also can be used with the module.
I've also added another test, just to verify that the program even runs when we do all the basicAuthPassword stuff.
Here's the patchset, hope you could take a look at it and maybe merge it into the commits: https://gist.github.com/h7x4/94185296658e58d3e5b93117aa9bc9a0. Feel free to ask questions if anything is unclear :grin:

Okay I understand better the freeform type now. I read all the changes and everything looks fine. I didn't know recursiveUpdate but it looks very usefull. I will merge this in my commits as soon as possible!

I'm sorry I think I did something I shouldn't have during a rebase...

Please open a new PR :)


Calendar doesn't include repeating events from Google Calendar

For example, the Build Guild calendar has a repeating event on 2015/01/20, but it doesn't show up in June.

I started working on this. The npm module we're using doesn't support RRULE, so I'm looking at the ical module. There was a bug with the recurrences, but I've got a patch out to them.


HTTP/2 example upgrade refcnt bug

Motivation:
Http2ServerInitializer uses a SimpleChannelHandler in an attempt to ease putting an HttpObjectAggregator in the pipeline when no upgrade is attempted. However the message is double released because it is fired up the pipeline (which will be released) and also released by SimpleChannelHandler in a finally block.
Modifications:

Retain the message if we fire it up the pipeline

Result:
HTTP/2 examples don't encounter a reference count error if no upgrade was attempted.

@normanmaurer - PTAL

@normanmaurer - comment resolved. PTAL

@Scottmitch ship it

4.1 (e3fbfe5)


Minimum sum partition problem in JAVA, C++, Python and C

Minimum sum partition problem
Given a set of integers, the task is to divide it into two sets S1 and S2 such that the absolute difference between their sums is minimum.
If there is a set S with n elements, then if we assume Subset1 has m elements, Subset2 must have n-m elements and the value of abs(sum(Subset1) – sum(Subset2)) should be minimum.

Example
Input:  arr[] = {1, 6, 11, 5}
Output: 1
Explanation:
Subset1 = {1, 5, 6}, sum of Subset1 = 12
Subset2 = {11}, sum of Subset2 = 11

Solution
Will provide the solution for Minimum sum partition problem in Java, Python, C and C++ will proper comments and documentation.
I would like to work on this issue.
Could you please assign this issue to me under SSoC ' 23.

I would like to work on this issue, kindly assign this to me.


Design System > Elements > All components error message alignment issue.

Describe the bug
All components error message alignment issue.
Steps to reproduce bug

Go to 'https://stage-react.raaghu.ai/'
Navigate to 'Design System > Elements '

Actual result-
All components error message alignment issue.
Screenshots

Expected result-
All components error message alignment should be proper.
Desktop (please complete the following information):
-OS: [Windows 10 Enterprise]
-Browser [ edge]
-Version [ 125.0.2535.92]

Fixed on


Condition for text input state

I'd like to map ctrl+h/j/k/l to arrow keys, but I don't want it to override the macOS emacs-ish keybindings (ctrl+h for forward-delete, ctrl+k for kill to end of line). So I would want to be able to check whether we're in a text input state. text_input_if and text_input_unless.
I imagine there must be an OS hook for that. Rocket app, for one, must be using something like that to determine when typing : launches it.
I imagine it would be incredibly useful for many key-mappings.
Related: https://github.com/tekezo/Karabiner-Elements/issues/1226

As nobody so far has answered your request, I'd like to suggest two workarounds to you , in that firstly you "put" your "emac-ish" key bindings onto a "to_if_held_down" event definition.
If this does not work for you (holding down arrow keys is used widely to get somewhere) you might add a second modifier to "Ctrl-h/k" to achieve forward-delete or end-of-line, like e.g. "Ctrl-Shift-h/k" as (at lest on my keyboard) Ctrl and Shift are easily reached together.
These should be placed in front of your more general "Ctrl-h/j/k/l" bindings to be recognised.


Trouble uploading code to heroku

Whenever I try to upload this code to heroku I get this error
Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
I solved this problem by changing this line of code from BootBot.js  (line 25)
this.app.set('port', port || 5000)
to this
this.app.set('port', process.env.PORT || 5000)
then it work like magic, because now heroku will be able to bind to it

Is this a question or are you just sharing an experience you had with heroku?
If the latter, you could add a small section on heroku deployment to the readme.
This is just how heroku works as they need to set a dynamic port for each Dyno deployment. And they consider env vars the most flexible way to do this.

It's an experience. I think your idea of adding the small section on deployment to heroku would work

It's an experience. I think your idea of adding the small section on deployment to heroku would work


"IN" as an equality match gets converted to SQL "IN"

Node version: 12.18.3
Sails version (sails): 1.4.3
ORM hook version (sails-hook-orm): 3.0.2
Sockets hook version (sails-hook-sockets): 2.0.0
Organics hook version (sails-hook-organics): N/A
Grunt hook version (sails-hook-grunt): N/A
Uploads hook version (sails-hook-uploads): N/A
DB adapter & version (e.g. sails-mysql@5.55.5<EMAIL_ADDRESS>Skipper adapter & version (e.g. skipper-s3@5.55.5<EMAIL_ADDRESS>
The following query fails because IN (Indiana state) is treated as an in clause instead of a literal value:
await Address.find({       street: "123 Main Street",       city:  "Indianapolis",       state: "IN",       zip: "46278",       countryCode: "USA",     })
The error:
Unexpected error from database adapter: Undefined binding(s) detected when compiling SELECT query: select "createdAt", "updatedAt", "id", "company", "primary", "street", "city", "state", "zip", "countryCode" from "public"."address" where "company" = ? and "street" = ? and "city" = ? and "state" in (?) and "zip" = ? and "countryCode" = ? limit ? {"cause":{"name":"AdapterError","adapterMethodName":"find","modelIdentity":"address","raw":{}},"isOperational":true,"adapterMethodName":"find","modelIdentity":"address","raw":{}}
Notice that the part of the predicate that is: "state" in (?)

Hi @akhor93,
This issue has been brought up before (#6977), and was fixed in<EMAIL_ADDRESS>Can you upgrade your adapter and let us know if you're still having this issue?

Thanks for the help. Upgrading versions does fix my issue with "IN".


A bit of padding for code snippets

Hello,
thank you very much for this nice and modern style!
I've started to use it for cmocka (https://api.cmocka.org/) and libssh.org will follow soon. I think it would be nice if the code snippets box would get a little bit of padding of the dark grey box around the text.
Maybe worth a try :-)

Hi,
thanks, glad to hear that :smiley:
You have a good point. I tried that a while ago but it doesn't play nice with line numbers so I didn't put it in. But I just pushed a change that adds a little padding around code snippets and removes the extra background colour for line numbers. Hope this looks better!

That looks better, thanks. https://api.libssh.org/ also uses that_style now!

Love to help!


[Building package fmt:x86-windows] build failure

install-x64-windows-static-dbg-out.log
Host Environment

OS: Windows
Compiler: abreast of the times

To Reproduce
Steps to reproduce the behavior:
./vcpkg install spdlog
Failure logs
Computing installation plan...
The following packages will be built and installed:

fmt[core]:x86-windows -> 8.1.1
spdlog[core]:x86-windows -> 1.9.2
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x86-windows...
Restored 0 packages from C:\Users\HP\AppData\Local\vcpkg\archives in 154.7 us. Use --debug to see more details.
Starting package 1/2: fmt:x86-windows
Building package fmt[core]:x86-windows...
-- Using cached fmtlib-fmt-8.1.1.tar.gz.
-- Cleaning sources at D:/dev/vcpkg/buildtrees/fmt/src/8.1.1-75ee4647fd.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/dev/vcpkg/downloads/fmtlib-fmt-8.1.1.tar.gz
-- Applying patch fix-write-batch.patch
-- Using source at D:/dev/vcpkg/buildtrees/fmt/src/8.1.1-75ee4647fd.clean
-- Configuring x86-windows
-- Building x86-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v -j17
Working Directory: D:/dev/vcpkg/buildtrees/fmt/x86-windows-dbg
See logs for more information:
D:\dev\vcpkg\buildtrees\fmt\install-x86-windows-dbg-out.log

Call Stack (most recent call first):
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:111 (vcpkg_execute_build_process)
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
ports/fmt/portfile.cmake:19 (vcpkg_cmake_install)
scripts/ports.cmake:145 (include)
Error: Building package fmt:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with git pull and .\vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+fmt
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[fmt]+Build+error
including:
package: fmt[core]:x86-windows -> 8.1.1
vcpkg-tool version: 2022-02-03-457b0309cefb58fae0dcb2e4c06de9bd7582967f
vcpkg-scripts version: c7ab9d311 2020-04-20 (1 year, 10 months ago)
Additionally, attach any relevant sections from the log files above.
Additional context
I have confirmed that git pull is the latest, and vspkg update also indicates that there is no update available。
Prompt that the file you want to view has been added to the attachment.

Thanks for posting this issue. Which version of Visual Studio you use?

Thanks for posting this issue. Which version of Visual Studio you use?

VS2019

There are error in your log:
[1/4] C:\LLongwillDevelopProducts\VS2013\VC\bin\amd64\cl.exe   /TP -DFMT_LOCALE -ID:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\include /nologo /DWIN32 /D_WINDOWS /W3  /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\fmt.dir\src\os.cc.obj /FdCMakeFiles\fmt.dir\fmt.pdb /FS -c D:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\src\os.cc
FAILED: CMakeFiles/fmt.dir/src/os.cc.obj
C:\LLongwillDevelopProducts\VS2013\VC\bin\amd64\cl.exe   /TP -DFMT_LOCALE -ID:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\include /nologo /DWIN32 /D_WINDOWS /W3  /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\fmt.dir\src\os.cc.obj /FdCMakeFiles\fmt.dir\fmt.pdb /FS -c D:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.cle

I saw the vcpkg use cl.exe of Visual Studio 2013.

There are error in your log:
[1/4] C:\LLongwillDevelopProducts\VS2013\VC\bin\amd64\cl.exe   /TP -DFMT_LOCALE -ID:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\include /nologo /DWIN32 /D_WINDOWS /W3  /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\fmt.dir\src\os.cc.obj /FdCMakeFiles\fmt.dir\fmt.pdb /FS -c D:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\src\os.cc
FAILED: CMakeFiles/fmt.dir/src/os.cc.obj
C:\LLongwillDevelopProducts\VS2013\VC\bin\amd64\cl.exe   /TP -DFMT_LOCALE -ID:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\include /nologo /DWIN32 /D_WINDOWS /W3  /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\fmt.dir\src\os.cc.obj /FdCMakeFiles\fmt.dir\fmt.pdb /FS -c D:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.cle

I saw the vcpkg use cl.exe of Visual Studio 2013.

Do I need to modify the cl.exe program of vcpkg to 2019? I now use both vs2013 and vs2019

There are error in your log:
[1/4] C:\LLongwillDevelopProducts\VS2013\VC\bin\amd64\cl.exe   /TP -DFMT_LOCALE -ID:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\include /nologo /DWIN32 /D_WINDOWS /W3  /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\fmt.dir\src\os.cc.obj /FdCMakeFiles\fmt.dir\fmt.pdb /FS -c D:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\src\os.cc
FAILED: CMakeFiles/fmt.dir/src/os.cc.obj
C:\LLongwillDevelopProducts\VS2013\VC\bin\amd64\cl.exe   /TP -DFMT_LOCALE -ID:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.clean\include /nologo /DWIN32 /D_WINDOWS /W3  /GR /EHsc /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1  -MTd /showIncludes /FoCMakeFiles\fmt.dir\src\os.cc.obj /FdCMakeFiles\fmt.dir\fmt.pdb /FS -c D:\dev\vcpkg\buildtrees\fmt\src\8.1.1-75ee4647fd.cle

I saw the vcpkg use cl.exe of Visual Studio 2013.

Do I need to modify the cl.exe program of vcpkg to 2019? I now use both vs2013 and vs2019

What should I do?

You can set VCPKG_PLATFORM_TOOLSET in VCPKG_ROOT/triplets/Use_triplet.cmake like below. V141 is VIsual Studio 2017, V142 is VIsual Studio 2019, V143 is VIsual Studio 2022.
x64-windows.cmake
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_PLATFORM_TOOLSET v142)

Ping @qazmx5741 for response. Does this issue still exist?

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.

This solves my problem, though I don't know if it works for qazmx5741. Thanks.


Track all deposits

The FT/NFT deposit tracking feature should track deposits into all accounts that receive the configured FT/NFTs, not just the accounts controlled by the API.

@psiemens @tehranifar Could either of you elaborate on this a bit?
I assume we are not talking about storing every transfer on the chain in the services database but I fail to interpret this in any other way.


[Port] Fix checkbox change event not firing on enter press (#12703)

Fix checkbox change event not firing

cherry-picked from https://github.com/microsoft/azuredatastudio/commit/8bf1859d3615866afc578dea3000bf2278d244c4

Pull Request Test Coverage Report for Build 289929636

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.008%) to 38.885%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/base/browser/ui/checkbox/checkbox.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/sql/base/browser/ui/checkbox/checkbox.ts
1
61.9%

Totals

Change from base Build 285049508:
0.008%

Covered Lines:
19242

Relevant Lines:
45153

💛  - Coveralls

@Charles-Gagnon, what concrete scenario does this fix?

@chlafreniere If you press enter on a ModelView checkbox then the extension doesn't get the updated value - so for example I found this by noticing that when using enter to select the "Remember Password" checkbox on the Arc controller login dialog it wouldn't actually remember the password since the default was left as unchecked.


[WIP DO NOT MERGE] - GitSourceControl

Summary

Filled the stubs in SourceControl for GitSourceControl except
Marked with Comments to see logic flow (Please let me know if something's unclear)

I have some doubts on the attachSttackAttackCommits function, basically I'm asking what it's purpose is. A little confused on that. Can't we just do that in the other functions?

All Resolved! 💯
Should I merge this then?


Cert Issuer Docs Update and additional docs for AzureDNS docs

Signed-off-by: Damien Retzinger<EMAIL_ADDRESS>What this PR does / why we need it:
The docs for Azure were removed. This adds them back and makes the DNS01 challenge doc significantly more approachable.
Which issue this PR fixes
fixes #588
fixes #591
touches: #671
revisits: #246
revisits: #428
Special notes for your reviewer:
N/A
Release note:
Revised Cert Issuer Docs for DNS01 challenge and added a doc for AzureDNS

/ok-to-test

In order to save you having to rebase, I'm going to get this merged in now.
Regarding the hostedZoneID, if you could have a look into this and potentially create another PR to clarify the 'multi-zone' mode of operation, that'd be great. It may involve some extra changes to the IAM rules for the user that cert-manager 'uses' (excuse my lack of properly terminology for azure!)
/lgtm
/approve


[SMALLFIX]Add javadoc for the functions in class JobConfInfo

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13163/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.client.RemoteBlockInStreamIntegrationTest.completeFileReadTriggersRecache[0]
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13164/
Test PASSed.

Merged build finished. Test PASSed.


Constant 'keepAliveTime' should be a constructor parameter.

Resource: server-core/src/main/java/org/astivetoolkit/server/monitor/FastAgiConnectionMonitor.java
Location: line 73

This is a duplicate. See issue #30


Update travis.yml

Remove mail notifications
Add filter for branches

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage     62.96%   62.96%
  Complexity      328      328
=========================================
  Files            76       76
  Lines          1604     1604
  Branches        113      113
=========================================
  Hits           1010     1010
  Misses          503      503
  Partials         91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bd75a...d362a27. Read the comment docs.


[#4989] - cast str privilege code to an int and update exception message

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4990


Change DI startup from CreateDefaultBuilder to CreateApplicationBuilder

I will do that after the open pull-request were merged.


Replace guava immutable collections with Java ones in tests

Now that Java has {List,Set,Map}.of and friends, we don't need to use so much
guava.
This commit only touches tests.

Looks good - although we could also go the extra mile and get rid of Maps.newHashMap() too...

Extra miles are what future PRs are for :)


Add ItemIdentification to Seed Box, Looting Bag, and Miscellania collection screen

Closes #9028

Added Miscellania collection screen


How to post these values

The pell works great but in my project i'm still working with ordinary post method. How to capture the pell div content?

This is my save file,  I hope it helps.  The main too instructions to look at are:
const list = document.getElementsByClassName("pell-content");
console.log(list[0].textContent)
function saveFile() { 	console.log("finding the text..."); 	const list = document.getElementsByClassName("pell-content"); 	console.log(list[0].textContent) 	//  .. the save file routine.  	SaveAsFile(list[0].textContent,"filename.txt","text/plain;charset=utf-8"); 	console.log("over"); 	return;

it isn't to export to a certain file, just basic form with (prepopulated field) and a post button. This script looks like to export to filename.txt?

it seems

See onChange in README


Tkn 361 ux enhancement enable end user to cancel authentication step

┆Issue is synchronized with this Jira Task by Unito

@BankiLouis - could you include some unit tests to the new updates then we can merge.

@BankiLouis - can you add unit tests that cover the changes you've made.


Foundation fails on Heroku with Rails 3.2.1

Using zurb-foundation version <IP_ADDRESS>
All else equal, deploying a Rails app (updated from 3.1.2 to 3.2.1) to Heroku fails with the following error:
ActionView::Template::Error (couldn't find file 'foundation'
2012-01-27T15:38:11+00:00 app[web.1]:     16:
2012-01-27T15:38:11+00:00 app[web.1]:     17: 	<meta name="apple-mobile-web-app-status-bar-style" content="black">
2012-01-27T15:38:11+00:00 app[web.1]:     18:
2012-01-27T15:38:11+00:00 app[web.1]:     19: 	<%= stylesheet_link_tag    "application" %>
2012-01-27T15:38:11+00:00 app[web.1]:     20: 	<%= javascript_include_tag "application" %>
2012-01-27T15:38:11+00:00 app[web.1]:     21: 	<%= csrf_meta_tags %>
2012-01-27T15:38:11+00:00 app[web.1]:   (in /app/app/assets/stylesheets/application.css:6)):

It works without a problem in development mode on my machine. Perhaps there's an issue with stylesheets being compiled?  In my application.css file I've tried both  *= require "foundation" and  *= require foundation. Everything worked fine before the update to Rails 3.2.1. Note: Heroku also throws the following (possibly unrelated) error:
2012-01-27T15:37:51+00:00 app[web.1]: DEPRECATION WARNING: You have Rails 2.3-style plugins in vendor/plugins! Support for these plugins will be removed in Rails 4.0. Move them out and bundle them in your Gemfile, or fold them in to your app as lib/myplugin/* and config/initializers/myplugin.rb. See the release notes for more on this: http://weblog.rubyonrails.org/2012/01/04/rails-3-2-0-rc2-has-been-released. (called from <top (required)> at /app/config/environment.rb:5)

I have nothing in my vendor/plugins folder.

Strange, I'm not able to reproduce this issue using Rails 3.2.1 on Heroku.  Can you verify that you're using the Heroku cedar stack?
Here's the test application I put together that's currently running on the Heroku cedar stack:
https://github.com/mhayes/awesomeapp
Let me know if this helps you out, cheers!

Forgot to mention, that deprecation error appears to be unrelated to the zurb-foundation gem.

I actually received the same error.  Also, I am using the cedar stack.
Completed 500 Internal Server Error in 283ms
2012-02-03T01:31:18+00:00 app[web.1]:
2012-02-03T01:31:18+00:00 app[web.1]: ActionView::Template::Error (couldn't find file 'foundation'
2012-02-03T01:31:18+00:00 app[web.1]:   (in /app/app/assets/stylesheets/application.css:12)):
2012-02-03T01:31:18+00:00 app[web.1]:     2:
2012-02-03T01:31:18+00:00 app[web.1]:     4:   TfcTk2
2012-02-03T01:31:18+00:00 app[web.1]:     3:
2012-02-03T01:31:18+00:00 app[web.1]:     5:   <%= stylesheet_link_tag    "application", :media => "all" %>
2012-02-03T01:31:18+00:00 app[web.1]:     7:   <%= csrf_meta_tags %>
2012-02-03T01:31:18+00:00 app[web.1]:     6:   <%= javascript_include_tag "application" %>
2012-02-03T01:31:18+00:00 app[web.1]:     8:

Ok, here's what was going on. Heroku wasn't updating to the specified version of the zurb-foundation gem because it was listed as such in the Gemfile:
...

group :assets do
  gem 'sass-rails', "~> 3.2.3"
  gem 'coffee-rails', "~> 3.2.1"
  gem 'uglifier', ">= 1.0.3"
  gem 'zurb-foundation', "<IP_ADDRESS>"
end

...

I removed it from the :assets group, Heroku installed the specified version, and the problem went away. Gemfile now has:
...

gem 'zurb-foundation', "<IP_ADDRESS>"

group :assets do
  gem 'sass-rails', "~> 3.2.3"
  gem 'coffee-rails', "~> 3.2.1"
  gem 'uglifier', ">= 1.0.3"
end

...

Thanks for looking into the problem. This likely only is an issue for people who used an older version of the gem on Heroku. Now, if I can figure out the pesky depreciation warning...


Remove user-friendly formatting from CSV export

The CSV export currently formats values in "Received Quantity" and "Sent Quantity" in human-friendly/display format (example: a value of 1337.00 is formatted as 1,337.00. The human-friendly delimiter makes it hard to process the number in external tools.
Note: the "Fee Amount" column does not have this problem. A fee of 35000 DC is displayed as 35000, as expected.

We'll be retiring csv export in explorer v2 and directing users to community created tools.


Add testing for AccessControl events

Partially Fixes #591
PR Checklist

[x] Tests
[ ] Tried the feature on a public network
[ ] Documentation

I merged the test-ownable-events branch into this one because is easier to follow the changes this way. This PR will be smaller after merging Ownable. The flow I have in mind is merging that one before reviewing this one again.

@ericnordelo ownable got merged


Let Xvfb choose the next free display (fixes #47)

Oops. I first accidentally pushed this to master which closed #47. I reverted the push to master...
@Modelmat Please review this if you have the time. After, I'll bump to 0.0.12 and make a new release.
P.S. I hope your exams went well?

My exams went okay, thanks :)
Did you force push to master? I can't see the revert commit & Github shows the commit which closed #47 as not existing on any branch. If so, please try not to in future - it can create issues when pulling changes.

My exams went okay, thanks :)

Glad to hear that! 👍

Did you force push to master? I can't see the revert commit & Github shows the commit which closed #47 as not existing on any branch. If so, please try not to in future - it can create issues when pulling changes.

Yes, I force pushed just a couple of minutes after I accidentally pushed the PR commit, so the chance of someone already having pulled the new commit was very small.
You can deny force pushes to master in the repository's settings, if you wish.


Add clustering function - RCFSummarize

Description
Adding RCFSummarize clustering algo into ml-commons
Issue Link here: https://github.com/opensearch-project/ml-commons/issues/356
Issues Resolved
[List any issues this PR will resolve]
Check List

[* ] New functionality includes testing.

[* ] All tests pass

[* ] New functionality has been documented.

[* ] New functionality has javadoc added

[* ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DCO check failed, you can add --signoff when commit change


[SPARK-7305][Streaming][WebUI] Make BatchPage show friendly information when jobs are dropped by SparkListener

If jobs are dropped by SparkListener, at least we can show the job ids in BatchPage. Screenshot:

cc @tdas

Merged build triggered.

Merged build started.

Test build #31580 has started for   PR 5840 at commit 83dec11.

Test build #31580 has finished for   PR 5840 at commit 83dec11.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
final class Binarizer extends Transformer with HasInputCol with HasOutputCol

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31580/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #31999 has started for   PR 5840 at commit 8073b03.

Test build #31999 has finished for   PR 5840 at commit 8073b03.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31999/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #32008 has started for   PR 5840 at commit 8073b03.

Test build #32008 has finished for   PR 5840 at commit 8073b03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32008/
Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #32020 has started for   PR 5840 at commit 8073b03.

Test build #32020 has finished for   PR 5840 at commit 8073b03.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32020/
Test FAILed.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #32044 has started for   PR 5840 at commit 8073b03.

Test build #32044 has finished for   PR 5840 at commit 8073b03.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32044/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #32134 has started for   PR 5840 at commit 718765e.

Test build #32134 has finished for   PR 5840 at commit 718765e.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32134/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32137 has started for   PR 5840 at commit aca0ba6.

LGTM. Will merge when tests pass.

Test build #32137 has finished for   PR 5840 at commit aca0ba6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32137/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #32148 has started for   PR 5840 at commit aca0ba6.

Test build #32148 has finished for   PR 5840 at commit aca0ba6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32148/
Test PASSed.

Merged build finished. Test PASSed.


Prepare preview release

Now that many rules are implemented, tested, and enabled by default, we should start considering the release process for preview releases. We should also consider installing the analyzer in this project so it gets some active use during the preview process.

I think so too. I think it would be really usefull to have a (nightly) nuget package so we can use it as much as possible. Sometimes when you try to find the most hidden edge case where it could break you oversee the obvios.
It might be a good idea to set up a CI system for that.
What do you want to get done before starting a preview?

I went ahead and released a first preview in order to verify that the build and publish process is working correctly.
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases/1.0.0-alpha001


Maybe fix quiet output

Looks like it works :shrug:

Doesn't work, you can't see the progress bar until all checks are finished


Resolves #17

resolves #17

Is there a specific way to check for admin session vs just a normal session user?


Make Remove-TestResource invoke custom script prior to deletion of the resource group

Since there are certain actions that might need to be taken prior to deletion of test resources, we will invoke custom scripts in the service directory named : remove-test-resources-pre.ps1

Closing the PR. Wrong repo


Originally posted by @KingAmo in https://github.com/facebook/react-native/issues/32070#issuecomment-903677554

No need to have a new issue open for this, can continue in #32070


Get file from storage account with MSI?

In the ARM template settings/protected settings is there a way to specify to authenticate to a storage account using MSI instead of providing an access key?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec45418f-2503-415d-12c1-3165be164c69
Version Independent ID: fc84467e-16a7-33ab-1511-7df7fa48a512
Content: Run custom scripts on Linux VMs in Azure
Content Source: articles/virtual-machines/extensions/custom-script-linuxOstc.md
Service: virtual-machines-linux
GitHub Login: @danielsollondon
Microsoft Alias: danis

Thanks for the question! We are investigating and will update you shortly.

@mmarkzon You can configure managed identities for Azure resources on an Azure VM using a template.
Here is the doc with the steps to do that. Thanks.

Thank you, but I don't think that answers my question.  My question was
specific to the Linux Custom Script Extension.  This page shows how to
setup RBAC for the VM to have access to a storage account:
https://docs.microsoft.com/en-us/azure/storage/common/storage-auth-aad-rbac
Once I set that up (through the portal or ARM), will the Custom Script
Extension just work without providing a storage account key?
On Fri, Oct 5, 2018 at 4:29 PM, Karishma Tiwari - MSFT <
<EMAIL_ADDRESS>wrote:

@mmarkzon https://github.com/mmarkzon You can configure managed
identities for Azure resources on an Azure VM using a template.
Here
https://docs.microsoft.com/en-us/azure/active-directory/managed-identities-azure-resources/qs-configure-template-windows-vm
is the doc with the steps to do that. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/16235#issuecomment-427504012,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQQvqqTD0xgDmBKdm-luxe0YkRLbVbOMks5uh88rgaJpZM4XI2yN
.

@mmarkzon can you tell us more about the end goal? Are you trying to run this Custom Script Extension that will then authenticate to the storage account and download a specific file to the VM? How often are you looking to do this? Just once?
Also, this article is for V1 of Custom script. We suggest you use V2 for any deployments.
https://docs.microsoft.com/en-us/azure/virtual-machines/extensions/custom-script-linux
It has similar variables though

@mmarkzon Any update? We need your help in understanding the issue. Please provide details as asked above. Thanks.

I have been using V2.  Yes, I am using the custom script extension post provisioning to download a script from a storage account and execute it on the VM.  Yes it is a one time thing.  I have it working with an access key but if there is a way to use the extension with MSI or RBAC I would prefer that.

We have Managed Service Identity for Virtual Machines in preview in the portal. Try the following:

Go to the Virtual Machine in the Portal
Select Identity (Preview)

Enable System Assigned

Go to the storage account that has the script you want to download
Select Access Control
Select Add
Select the VM you want to add

I am not 100% sure on the role type that will be needed... but give this a go and see if it helps.

@mmarkzon Did the above solution help?

@mmarkzon Any update?


install 6.3.2 GM seed issue

$ xcode-install list
6.0.1
6.1
6.1.1
6.2
6.3
6.3.1
6.3.2 GM seed
6.4 beta 2

then
$ xcode-install install "6.3.2 GM seed"
######################################################################## 100.0%
hdiutil: mount failed - image not recognized
Please authenticate for Xcode installation...
No `Xcode.app` found in DMG.

I guess this issue occurs because "6.3.2 GM seed" has been removed from Dev Center. Solution would be to check the download before mounting, print an appropriate error and suggest using xcode-install update to refresh the cached Dev Center content.


 How can I change the regex to fix that?

The filter allows you to modify which words you want to add / remove. I suggest starting your own custom list of what you want to permit / deny and populate those during instantiation of the filter. I'm open to a PR against https://github.com/web-mech/badwords-list if you want.


Better styling for router related components

Made a few changes to IntoAttribute to make it usable as Box<dyn IntoAttribute> to support styling similar to native tags.
Before the  tag took a MaybeSignal<String> so you needed to do:
view!{cx,

}

Now you can do:
view!{cx,

}

And it also works for Form, ActionForm and MultiActionForm
I tried really hard to implement this using generics, but it does not seem possible. The type of the generic parameter needs to be inferred even if its value is None because it needs to know what Option::<T>::None it is.

Oh I like this a lot. I should probably do the same thing for class, properties, and views.
I think we should export a type alias for this to make it easier to use. Something like AttributeValue? Do you have thoughts on naming?

AttributeValue sounds good to me. Where should we I put the alias? In leptos/src/lib.rs to the children type aliases?

You have to love Rust for this conversion trait magic 🪄
I implemented IntoAttribute for (Scope, Option<AttributeValue>) and (Scope, AttributeValue) so they can work directly in the view Macro.
This works now:
#[component]
pub fn MyHeading(
  cx: Scope,
  text: String,
  #[prop(optional, into)]
  class: Option<AttributeValue>
) -> impl IntoView {
  view!{
    cx,

{text}

  }
}

Btw is it intended that I have to say class=class and can't just say class in the attributes?
If i do

 the macro will resolve to .attr("class",(cx, "") instead of .attr("class", (cx, class)).

On this particular point, this is just to maintain compatibility with the way Boolean attributes work in HTML.
<button disabled> in HTML is the same as <button disabled="">
I may add a shorthand syntax in the view macro like <button {disabled}> to expand to <button disabled=disabled> in the future, but not sure if that's a good idea yet.

AttributeValue sounds good to me. Where should we I put the alias? In leptos/src/lib.rs to the children type aliases?

Yeah that's what I was thinking.

On this particular point, this is just to maintain compatibility with the way Boolean attributes work in HTML.

Ah I see that makes sense.

I may add a shorthand syntax in the view macro like <button {disabled}> to expand to <button disabled=disabled> in the future, but not sure if that's a good idea yet.

Yeah thats debatable. I was just a bit confused as I expected it to work because the syntax works for custom components.

Should I change anything or is this ready to merge?

Nope looks good! Merging now.


Code box is too small

I think the way code is displayed should be changed a bit. Right now it's only about 45 characters wide. Ideally it should be 80.

I am not sure how easy this is to fix using the importcodeblock plugin (or whatever it is called); however, if you click the button on the upper left, it will expand out the view to the rest of the page.

That's better than nothing ^^

There must be a way to do this with the plug-in. I'll look into it soon. Thanks!

Ok, I just looked at our files and the theme-api documentation. The split-view option is the default and I also enabled it in the book.json for no logical reasons... So I created a PR fixing that. https://github.com/leios/algorithm-archive/pull/42

Thank you @jiegillet for pointing that out :)

Pull request merged. I think the issue is resolved for now.

default split is back from one of the recent commits!

Ah, I think I know which one. I'll fix it.

I think split isn't back. I just checked with a guest session on chrome and the code took up the full width. Can you maybe check the AAA with another browser that has no cookies or anything stored? @jiegillet

My bad, sorry! I checked with 2 browsers, but then cleared cache on one and you're right.

@jiegillet no problem :)

It was also because of the cache, that I thought for a long time, that split-view is disabled by default (when it wasn't). You pointed it out then. :)


ZTE-SH-CN-debug-stateful-set

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.8 Features: set Milestone to 1.8 and Base Branch to release-1.8
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

https://kubernetes.io/docs/tasks/debug-application-cluster/debug-stateful-set/

This change is

cc @zhangxiaoyu-zidif

cc @tengqm
Could you help me to review the Chinese translation?thanks

PTAL @zhangxiaoyu-zidif

@tengqm
LGTM to me, how about you?

@tengqm
I will add LGTM label after you approved. wait for you=)


Update docs with links to ProvisionQL Quick Look plugin

Checklist

[x] changes only applied to docs, no testing or code stability verification required

Motivation and Context
Recently while reading docs on fastlane I've spotted recommendation of Provisioning Quick Look plugin.
While it's awesome project for it's time, it's not maintained for a long time and haven't accepted any PRs for last 4 years.
I've made some changes merged to original project, but decided to create and maintain separate fork to have more control and flexibility, here it is - ProvisionQL. I've shipped significant release this week and decided to give a shout about replacing Provisioning in context of fastlane docs.
Let me know your thoughts and of course - issues and PRs are welcome in ProvisionQL repo!
Description

changed links in cert, sigh, gym docs to point on ProvisionQL
updated .mobileprovision Quick Look screenshot in sigh, added same in cert
added .ipa Quick Look screenshot in gym
removed tip about Quick Look from pem docs because both Provisioning and ProvisionQL are unrelated to .pem, .cer, and .p12.

I signed it!

This looks great @ealeksandrov. One question, why did you delete the .pem change? Does your fork drop support for .pem files?

@getaaron .pem support is included in macOS by default and completely unrelated to Provisioning or ProvisionQL.
Here is array of supported file types in original Provisioning - https://github.com/chockenberry/Provisioning/blob/master/Provisioning/Provisioning-Info.plist#L7-L49
No .pem UTI there, it should be "public.x509-certificate".


cmd/compile: fix line number during yyerror in pragcgo

Merged position changes from dev.inline into master.
The only part I wasn't sure about was how to translate this one line added to master since the dev.inline branched forked off. I commented it with TODO(gri) instead:
case strings.HasPrefix(text, "go:cgo_"):
	// TODO(gri): lineno = p.baseline + int32(line) - 1 // pragcgo may call yyerror
	p.pragcgobuf += pragcgo(text)
	fallthrough // because of //go:cgo_unsafe_args

@rsc  I had mentioned in https://github.com/golang/go/issues/18459#issuecomment-269566840, that I had encountered this and perhaps we can fix it like I did here https://go-review.googlesource.com/c/34562
p.error(syntax.Error{Pos: pos, Line: line, Msg: err.Error()})

We didn't include the suggested change because it was very late in the Go1.8 cycle and my
suggestion was a lot larger than the two liner change @griesemer made in
https://go-review.googlesource.com/c/34721/

@odeke-em While your change is maybe the right approach long-term, it's too large for the (small) issue, and doesn't fit the current error handling model (which is going to change anyway, down the road).
It appears that the test I added with https://go-review.googlesource.com/c/34721/ is passing, so we may not have an issue here, but I will investigate.

@odeke-em It turns out your fix is actually the correct one - my initial approach won't work anymore due to the concurrency we have now (pragcgo is called concurrently since files are parsed concurrently). Working on a correct solution...

Cool, glad to know it worked 🍻


Parameter Box integration with InternalClimaParams

This PR:

Uses the new CLIMAParameters interface
Drops support for Julia 1.4, since it doesn't allow some NamedTuple syntax ( I think, e.g., nt = (; a))

@odunbar, I've rebased this an I think that the PR is about ready. My only remaining concern is that maybe we should reconsider the name param_struct (nearly everything is a struct, so it's not really informative). Maybe we should use param_dict? We should probably update CLIMAParameters test / example to use this terminology, too.

Hmm, there’s a pretty significant memory alloc hit for the p-theta-a constructor.. it doesn’t seem to exist with the other constructors, we should probably look into this..

I've also made a few more compactifying changes:
for fn in fieldnames(ThermodynamicsParameters)
    @eval $(fn)(param_set::ATP) = param_set.$(fn)
end

now replaces all the manual definitions. In addition, derived keywords expressions are written in the struct, and we instead compute aliases by:
    derived_params = [
        "R_d",
        "molmass_ratio",
        "R_v",
        "LH_f0",
        "e_int_v0",
        "e_int_i0",
        "cp_d",
        "cv_d",
        "cv_v",
        "cv_l",
        "cv_i",
    ]
    aliases =
        setdiff(string.(fieldnames(ThermodynamicsParameters)), derived_params)

I think that this may be a better pattern since there will (I think) be generally fewer derived quantities than non-derived ones. So specifying this list is a bit more compact.
Perhaps we can define a method in CLIMAParameters,required_kwargs that returns the symbols of all kwargs without defaults.

bors r+

bors r+

bors r-

bors r+


loads doesnt support boolean

Description

json.loads doesn't support boolean types. The values would "true" and "false" if they existed
Related Issue

[ ] Closes #
[ ] Related to #

Checklist

[ ] Checked that the pre-commit linting/style checks pass
[ ] Included tests that prove the fix is effective or that the new feature works
[ ] Added necessary documentation (docstrings and/or example notebooks)
[ ] If you are a pro: each commit corresponds to a relevant logical change

Modules affected

[ ] MMM
[ ] CLV

Type of change

[ ] New feature / enhancement
[ ] Bug fix
[ ] Documentation
[ ] Maintenance
[ ] Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--881.org.readthedocs.build/en/881/

Do you want to add a unit-test? (why was it not failing before?)

Do you want to add a unit-test? (why was it not failing before?)

Yes! Wasn't failing because we don't have any tests for backwards compat of the attrs in the MMM load

This should be good to go. Also found bug on the adstock and saturation and made the fix. However, those will change with #882


Add method to create a document in Stream

At the moment, it is not possible to set the Stream into which the document will be saved. This is convenient when we do not want to save the file locally, but only generate it in memory.

Wasn't it added already?

https://github.com/EvotecIT/OfficeIMO/pull/43

You're asking to add, or willing to add yourself ? :-)

We actually fixed this in https://github.com/EvotecIT/OfficeIMO/pull/16 as far as I remember. We had same issue, but so far the original document after load should not be changed?


⚠ Bofrost.lu has degraded performance

In 2126385, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1780 ms

Resolved: Bofrost.lu performance has improved in a8500ae after 23 minutes.


Allow aliasing .ps1 scripts in manifest

Description of the new feature / enhancement
Right now packages aliasing .ps1 scripts are not allowed https://github.com/microsoft/winget-pkgs/pull/133524#issuecomment-1885335347
There are small fraction packages like winsetview that need to have .ps1 script that should be available in PATH.
Proposed technical implementation details
No response

@denelon I see that this is closed as fixed, is aliasing .ps1 scripts allowed now?


transactions lost on connection timeout

If I submit 300 transactions (reproducible with simple ZIL transfers) to the prototestnet API, I get a ConnectionTimeoutError. Interestingly, all transactions but one arrive in the mempool of our nodes, but become queued since the nonce of that one transaction is missing.
Here's an example. My nonce at the beginning of the test was 100. I submitted 300 times the same transaction. The first 3 of them got included in the following blocks:

2 ZIL transfers in block 13071
1 ZIL transfer in block 13072

The first transaction that went lost had the nonce 103. The mempool of all prototestnet nodes contained 173 queued transactions of mine with nonces in the range 104-288, so besides the transaction with the nonce 103 further 12 transactions with higher nonces must have gone lost:
http://zq2-prototestnet-node-api-0-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-1-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-2-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-3-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-4-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-5-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-6-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-7-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-8-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-api-9-ce5b.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-bootstrap-0-30da.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-validator-0-def0.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-validator-1-def0.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}
http://zq2-prototestnet-node-validator-2-def0.zq2.dev:4201 pending: {}, queued: { 0x15fc323dfe5d5dcfbeedc25cecbf57f676634d77: 104-288}

The is not not bug. The annoying behavior is because of submitting transactions with precomputed incremental nonces simultaneously, but they arrive in random order. If the connection times out and a transaction with a lower nonce doesn't get delivered, the missing nonce prevents all transactions with higher nonces from being processed.


Delete from array in "to String.vim" is missing an index input

The delete from array in the "1D arrays of everything else" case of "lib_Approval Tests.lvlib:to String.vim" should have a 0 wired into the index input:

Currently it is removing the last element instead of the first and so the array in the log string is in the incorrect order.

Good catch.

See if this fixes your problem. If so, let me know and I'll release it on VIPM. If you give me your VIPM Id, I'll tag you as a contributor.
Approvals 2.2.2.zip

Yes that fixes the issue.  Thanks for the fast turnaround.  My VIPM Id is miles_vipm

fixed in 2.2.2


Graph not showing up in Ionic when using code from Plunker demo

Ok, so this is probably going to be difficult to diagnose as I can't really show the code (copyrights and all), but I'm trying to use the NVD3 module for an Ionic app.  Right now I'm simply trying to use the Plunker Ionic demo to shove a temporary graph in my app.  At the moment, Inspecting the actual NVD3 tag in chrome just shows  (NVD3 0px x 0px).
I have console.log's in the different controllers and sections, and the functions from the demo both get called, the setup gets called, but it still doesn't show.  I have manually screwed with the CSS to force a 100px x 100px size with a HUGE z-index, and nothing.
I have no idea what I am doing wrong.  Can anyone help?

Little more info:
I completely copied your code over from plunker and it does not work on current Ionic 1.7.7/1.7.8.  I get the same result as I stated above.
Guess I'm off to do this the old angular way.

current ionic version is 1.1.1, check it please.

$ ionic -version
1.7.7
Maybe that's the CLI?  Is it different?

yes it's cli...
is there any errors in console?
try to refresh chart after creation:
<nvd3 options="options" data="data" api="api"></nvd3>

$scope.options = ...;
$scope.data = ...;
$timeout(function(){
    $scope.api.refresh();
},500)

I'm getting an error on the refresh potion of your code.  My HTML looks like this:
<nvd3 options="options"  data="data"  config="config"  events="events"  api="api"></nvd3>

And the error is coming through in the screenshot:

I don't have an "api" section defined at the moment, I was just running the basics off your plunker demo:
http://plnkr.co/edit/e3HZQN?p=preview
I'm sure this is both my inexperience with D3 and a bit with Angular as well.  But I really appreciate your help!

Here's the entire controller:
.controller('graphCtrl', function($scope, $timeout) {
	console.log("in graphCtrl");
	/* Graph Options */
	$scope.options = {
		chart: {
			type: 'discreteBarChart',
			height: 450,
			margin : {
				top: 20,
				right: 20,
				bottom: 60,
				left: 55
			},
			x: function(d){ return d.label; },
			y: function(d){ return d.value; },
			showValues: true,
			valueFormat: function(d){
				return d3.format(',.4f')(d);
			},
			transitionDuration: 500,
			xAxis: {
				axisLabel: 'X Axis'
			},
			yAxis: {
				axisLabel: 'Y Axis',
				axisLabelDistance: 30
			}
		}
	};

	/* Graph Data */
	$scope.data = [{
		key: "Cumulative Return",
		values: [
			{ "label" : "A" , "value" : -29.765957771107 },
			{ "label" : "B" , "value" : 0 },
			{ "label" : "C" , "value" : 32.807804682612 },
			{ "label" : "D" , "value" :<PHONE_NUMBER>9256 },
			{ "label" : "E" , "value" : 0.19434030906893 },
			{ "label" : "F" , "value" : -98.079782601442 },
			{ "label" : "G" , "value" : -13.925743130903 },
			{ "label" : "H" , "value" : -5.1387322875705 }
	    ]
	}];

	$timeout(function(){
    		$scope.api.refresh();
	},500);

	$scope.config = {
	    visible: true, // default: true
	    extended: false, // default: false
	    disabled: false, // default: false
	    autorefresh: true, // default: true
	    refreshDataOnly: true, // default: true
	    deepWatchOptions: true, // default: true
	    deepWatchData: false, // default: false
	    deepWatchConfig: true, // default: true
	    debounce: 10 // default: 10
	};
})

and the entire HTML block:

            <nvd3 options="options"  data="data"  config="config"  events="events"  api="api"></nvd3>

And the references in index.html:
    <link href="css/ionic.app.css" rel="stylesheet">
    <link href="lib/nvd3/build/nv.d3.min.css" rel="stylesheet">

It seems like you are trying to define ng-controller twice. Try to remove

    <nvd3 options="options"  data="data"  config="config"  events="events"  api="api"></nvd3>

it's like there are no any definitions for options and data in the controller you trying to use...

Yeah, that didn't seem to fix it...
So basically here's what's going on.  This started as a standard Ionic demo app (identical to the Plunker Demo), but I added a few sections to the tabs control.  Basically the tabs template now also has a div in it that sticks to the top while the tabs themselves are hidden and then there's a 3rd div set at the bottom that is an actual navigation.  Here's the file (template/tabs.html):

            <nvd3 options="options"  data="data"  config="config"  events="events"  api="api"></nvd3>

128°

128°

<ion-tabs class="tabs-icon-only tabs-positive">

    <ion-tab icon="ion-home" href="#/tab/home">
        <ion-nav-view name="home-tab"></ion-nav-view>
    </ion-tab>

    <ion-tab icon="ion-ios-information" href="" ng-click="openModal()">
        <ion-nav-view name="ingredients-tab"></ion-nav-view>
    </ion-tab>

    <ion-tab icon="ion-home" href="#/tab/recipe_view">
        <ion-nav-view name="recipe_view-tab"></ion-nav-view>
    </ion-tab>

    <ion-tab icon="ion-home" href="#/tab/recipe_step">
        <ion-nav-view name="recipe_step-tab"></ion-nav-view>
    </ion-tab>

</ion-tabs>

The top div is a "shade" that can be pulled down by selecting the control.  This section contains the graph and a temperature reading.
The second portion is the ion-tabs-class which is perpetually hidden as we don't want ALL the pages shown in the nav.
The 3rd portion is a replacement nav.
The Nav's are showing correctly as we needed, but the graph above is where the issue lies.
I moved all of the data and options code to the MasterTabCtrl and removed the call to the controller like you had specified and still have the same result.
(index.js - Controller for tabs)
.controller('MasterTabCtrl', function($scope, $ionicModal, Scopes) {
  	console.log('MasterTabCtrl');
  	Scopes.store('MasterTabCtrl', $scope);
  	$scope.showGraph = true;
  	var navHidden;
  	$scope.hideNav = function() {
  		console.log("Hiding Main Nav...");
  		navHidden = true;
  	};
  	$scope.showNav = function() {
  		console.log("Showing Main Nav...");
  		navHidden = false;
  	};
  	$scope.navState = function() {
  		return navHidden;
  	};

  	/* Graph Options */
	$scope.options = {
		chart: {
			type: 'discreteBarChart',
			height: 450,
			margin : {
				top: 20,
				right: 20,
				bottom: 60,
				left: 55
			},
			x: function(d){ return d.label; },
			y: function(d){ return d.value; },
			showValues: true,
			valueFormat: function(d){
				return d3.format(',.4f')(d);
			},
			transitionDuration: 500,
			xAxis: {
				axisLabel: 'X Axis'
			},
			yAxis: {
				axisLabel: 'Y Axis',
				axisLabelDistance: 30
			}
		}
	};

	/* Graph Data */
	$scope.data = [{
		key: "Cumulative Return",
		values: [
			{ "label" : "A" , "value" : -29.765957771107 },
			{ "label" : "B" , "value" : 0 },
			{ "label" : "C" , "value" : 32.807804682612 },
			{ "label" : "D" , "value" :<PHONE_NUMBER>9256 },
			{ "label" : "E" , "value" : 0.19434030906893 },
			{ "label" : "F" , "value" : -98.079782601442 },
			{ "label" : "G" , "value" : -13.925743130903 },
			{ "label" : "H" , "value" : -5.1387322875705 }
	    ]
	}];

	$scope.config = {
	    visible: true, // default: true
	    extended: false, // default: false
	    disabled: false, // default: false
	    autorefresh: true, // default: true
	    refreshDataOnly: true, // default: true
	    deepWatchOptions: true, // default: true
	    deepWatchData: false, // default: false
	    deepWatchConfig: true, // default: true
	    debounce: 10 // default: 10
	};
})

Also as I stated previously, the exact same thing happens when I try to load your demo by hand. Here's a zip of the Ionic Demo app you have in Plunker if you care to give it a shot.
https://www.dropbox.com/s/eb6m9umkttyzzvw/d3-ionic-test.zip?dl=0

Oh and here's the state call for the tabs controller:

  $stateProvider
    .state('tabs', {
      url: "/tab",
      abstract: true,
      templateUrl: "templates/tabs.html",
      controller: 'MasterTabCtrl'
    })

As a side note, I'd be happy to pay you for your help if you would like to help me dig through the actual app, I just can't post the code here for privacy reasons, though it's not like it's anything terribly special right now.  Drop me a message with your email address if you like and I will figure out how to get you the code.

  I had moved the code from another branch and forgot to include the nvd3 in the app creation.  I'm dumb.  Sorry for the trouble.