Do we want to release on tags too?

          I assume we'll still want to run the release workflow on tag as well?

Originally posted by @rlankfo in https://github.com/grafana/opentelemetry-collector-components/pull/49#discussion_r1098944709

Not sure -- tags are just annotations on existing commits. If we don't plan on tagging commits that exist only on specific branches, we should be fine. If we want to have tags, and if we want a special build for that, we can trigger it manually after pushing the tag. git describe should then return the proper version based on the tag.

I'm fine if we don't do this (and we can still push the tags), but w/o it I don't think we'll ever end up with a "blessed" version (e.g. v0.0.1 vs v0.0.1-SNAPSHOT-) unless we run the workflow on the tag manually as you suggested.


Function: window_ Funnel model: 4, same event type, calculation error

data set

Query statement

SELECT uid,
window_funnel(1800,
event_time,
4,
[event_type='点击', event_type='点击', event_type='点击']) as LEVEL
FROM
action_test t
GROUP BY  uid;

result

The event type is the same, but the time is different. Model: 4 statistics error
I think the level should be 3. Is this a bug?
Create Table Statement

CREATE TABLE action_test (
event_time datetime NOT NULL COMMENT "datetime of event",
event_type varchar(65533) NOT NULL COMMENT "type of event",
uid int(11) NULL COMMENT "id of user"
) ENGINE=OLAP
DUPLICATE KEY(event_time, event_type)
COMMENT "OLAP"
DISTRIBUTED BY HASH(uid) BUCKETS 8
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "DEFAULT",
"enable_persistent_index" = "false",
"compression" = "LZ4"
);

Data insertion statement

insert into action_test (event_time,event_type,uid) values(STR_TO_DATE('2020-01-02 11:40:00', '%Y-%m-%d %H:%i:%s'),'点击',4);
insert into action_test (event_time,event_type,uid) values(STR_TO_DATE('2020-01-02 11:50:00', '%Y-%m-%d %H:%i:%s'),'点击',4);
insert into action_test (event_time,event_type,uid) values(STR_TO_DATE('2020-01-02 12:00:00', '%Y-%m-%d %H:%i:%s'),'点击',4);

version : 2.5.3

You choose the mode 4 which means "the filtered events must have strictly increasing timestamps. Duplicate timestamp disrupts the event chain. ".
If you no need the strictly increasing  for the filtered events, you can try other modes:


yed: wrap With wrapGAppsHook - fixes #101135

Use preFixup to setup the wrapper properly, without double wrapping.

Motivation for this change
Fix https://github.com/NixOS/nixpkgs/issues/101135 (cc @bluescreen303 ).
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I tested this to fix the issue myself, and the maintainer of yed and the OP of https://github.com/NixOS/nixpkgs/issues/101135 won't respond / object, so I'm merging.


Set appropriate Cache-Control header for Whitehall assets when user is signed in

It looks as if Whitehall attachments are currently being served with a Cache-Control header of no-cache if the user is signed in. I assume this is meant to be used to ensure that editors see the most up-to-date version of an attachment.
I have a feeling this behaviour might've been present for non-attachments in Whitehall in the old PublicUploadsController. It would be worth checking in order to inform the decision of how/whether to implement equivalent behaviour in Asset Manager.
It's not immediately obvious to me whether we should do something similar in Asset Manager, because I'm not entirely sure the fact that the current_user is set in Asset Manager is semantically equivalent to current_user in Whitehall.

@chrislo and I have opened https://github.com/alphagov/asset-manager/pull/517 to update the caching behaviour in Asset Manager.

I'm going to test that this is working as expected.

I've tested this in production by requesting the same image from assets-origin and from draft-assets:

https://assets-origin.publishing.service.gov.uk/media/55bb8be1ed915d1565000016/large-goods-vehicle-markings.jpg
https://draft-assets.publishing.service.gov.uk/media/55bb8be1ed915d1565000016/large-goods-vehicle-markings.jpg

I used the Chrome Developer tools to inspect the Response headers and have confirmed that the Cache-Control header is set to max-age=86400, public when requested from assets-origin and is set to no-cache when requested from draft-assets.
I'm happy that this is working as expected so I'm closing this issue.


unable to install ludwig due to gmpy

Describe the bug
I can't install ludwig in win10 due to gmpy installation go wrong.
To Reproduce
Steps to reproduce the behavior:
1.download gmpy-master.zip from github and unzip it.
2.in terminal window, input command "python setup.py install"
3.minuters later, see error.

Environment (please complete the following information):

OS: win10 professional
Version: i don't know
Python version: 3.7.4
Ludwig version: ludwig-master

Additional context
Add any other context about the problem here.

Yep, having the exact same problem here, with python version of 3.7.4 and trying to install with pip

Duplicate of #452
Install from master repo and it will be ok - gmpy prerequisite has been removed.


Feat: Validate boolean conditions in safeParams for Encryption

What
Currently we don't do any validation for boolean access control conditions. Therefore any invalid boolean condition causes the node to panic on decryption. We need to do this validation on the client-side as the Identity base encryption happens on the client without interacting with the nodes. Otherwise, the users will get to know about the incorrect access control conditions only when they decrypt which isn't a good user experience.
Note: Ensure to validate nested boolean conditions as well.
How
Function validateBooleanExpression(expression) validates whether the input access control conditions are valid boolean expression. It does it using a State Machine.
It's called inside safeParams for all sort of encryption functions: encryptString, encryptFile, etc.
Tests
I have written a test suite containing several scenarios of boolean access control conditions which is tested against validateBooleanExpression. This includes testing nested conditions as well.
Errors
The SDK throws INVALID_BOOLEAN_EXCEPTION when validateBooleanExpression encounters an invalid boolean condition.
Rust Node
I've added similar validation on the nodes as well: https://github.com/LIT-Protocol/lit-assets/pull/501

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Jack bakend does not use event-based callbacks

It's currently spinning its own thread and sleeping, which is not optimal and provokes xruns.
It should be more like this: https://github.com/jackaudio/example-clients/blob/master/simple_client.c.

Addressed in #108

Closing due to #108 thanks to @zamaudio


Too many (duplicate) search results in API docs

Go to https://mne.tools/dev/index.html
Click the Search icon in the top bar, enter e.g. "read_raw_edf" in the search box, and hit enter
The first three results are (almost identical):
mne.io.read_raw_edf
mne.io.read_raw_edf (Python function, in mne.io.read_raw_edf)
mne.io.read_raw_edf

Specifically, the link to

https://mne.tools/dev/generated/mne.io.read_raw_edf.html#mne-io-read-raw-edf
https://mne.tools/dev/generated/mne.io.read_raw_edf.html#mne.io.read_raw_edf
https://mne.tools/dev/generated/mne.io.read_raw_edf.html

I think there should be only one search result pointing to the documentation of that function (the third one). The other two contain anchors, where the first one doesn't have any effect, and the second one scrolls down one line so that the heading is not visible (not useful IMO).

This bugs me too but I haven't had time to investigate the cause. Probably related to autodoc?

the first result (the one where the anchor is all - separated, no .) is the permalink for that heading. generally I think we do want permalinks for headings in our docs, but I wonder if there's a way to disable generating them for the main h1 tag on an API page?  It's written by docutils so not sure if it's configurable. The second result (where the anchor has a mix of . and - separators) I'm not sure where that comes from, and I suspect it's actually a bug --- searching for mne.io.read-raw-edf in the generated page source gets no hits so it's not even a valid anchor. My guess is that the latter (invalid) form is "original" and it gets sanitized to the all-dash version by either Sphinx or by the theme, but that sanitization process doesn't remove the old anchor from Sphinx's search index or something.


Expose more warnings.

Warn on ALL the things!
Well, maybe not all, but more than before.
Signed-off-by: Dan Cross<EMAIL_ADDRESS>

That's why I turned that one back off.
On Sat, Apr 22, 2017 at 5:19 AM, Álvaro Jurado<EMAIL_ADDRESS>wrote:

@elbing commented on this pull request.
Frame address suppression will break build due to getcallerpc builtin.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Harvey-OS/harvey/pull/542#pullrequestreview-34153814,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABhLAP3c17DfsQVMCEh1dcIFwNpGXMx2ks5rycY5gaJpZM4NExgX
.


Added Two Inspectors

Inspect-OAUTHUserConsent:
Checks whether the default user has permissions associated with the ability to consent to OAUTH apps.
Learn Article: https://learn.microsoft.com/en-us/entra/identity/enterprise-apps/configure-user-consent?pivots=portal
It appears that the inspector ThirdPartyIntegratedAppPermission is similar, however it only checks if the admin workflow is enabled and if users care able to create apps. This is a separate check that addresses the permission that is assigned to users that allows them to consent at all.
Inspect-CAPolicies_legacyauth:
This inspector checks if there is a CAP that blocks legacy authentication. This is a separate check from if SharePoint allows legacy authentication.
Code and findings file is copied and refactored from the other CAPolicy-xxx inspectors.
Learn Article: https://learn.microsoft.com/en-us/entra/identity/conditional-access/howto-conditional-access-policy-block-legacy

Thank you for your submission!
We will review this shortly.


211/snapshot to disk

Features interval disk snapshotting of the following storages:

balances mirror
nonce mirror
oderbook mirror

Partially solves #211
closes #173

Please squash merge this as soon as it have been manually verified

Please squash merge this as soon as it have been manually verified

Interval loop is working (manually verified the loop entering the write to disk function). I was not able to test it yet with data within the mirrors (due to issue #236), but the writing to disk storage was tested with unit tests.


Gateway 3 not work with RPi 5

I tried to upgrade my  RPi4 to RPi5, after full restore, GW 3 showed (not loaded), can't delete it from Devices. Remove it from HACS but still can't delete it from Devices.
Deleted GW3 at RPi4 and created backup. After restored to RPi5 and redownload GW3, it still showed (not loaded) in Devices.
Below is the log file:
Logger: homeassistant.util.loop
Source: util/loop.py:77
First occurred: 9:27:53 AM (1 occurrences)
Last logged: 9:27:53 AM

Detected blocking call to import_module with args ('custom_components.xiaomi_gateway3 backuo',) in /usr/src/homeassistant/homeassistant/loader.py, line 1067: ComponentProtocol, importlib.import_module(self.pkg_path) inside the event loop; This is causing stability issues. Please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue For developers, please see https://developers.home-assistant.io/docs/asyncio_blocking_operations/#import_module Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module> sys.exit(main()) File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main exit_code = runner.run(runtime_conf) File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run return loop.run_until_complete(setup_and_run_hass(runtime_config)) File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete self.run_forever() File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever self._run_once() File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once handle._run() File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run self._context.run(self._callback, *self._args) File "/usr/src/homeassistant/homeassistant/setup.py", line 165, in async_setup_component result = await _async_setup_component(hass, domain, config) File "/usr/src/homeassistant/homeassistant/setup.py", line 334, in _async_setup_component component = await integration.async_get_component() File "/usr/src/homeassistant/homeassistant/loader.py", line 1019, in async_get_component comp = self._get_component() File "/usr/src/homeassistant/homeassistant/loader.py", line 1067, in _get_component ComponentProtocol, importlib.import_module(self.pkg_path)

I don't know what this means 'custom_components.xiaomi_gateway3 backuo'. Some space and word backuo... You installation broken. Only you can find out why.


Introduced keep alive monitor mechanism in the binary port. Introduce…

…d two new config properties for the binary port: keepalive_check_interval, keepalive_no_activity_timeout. From now on if a binary port connection is not used for a configured period of time it will be closed on the node side. Introduced a binary request variant BinaryRequest::KeepAliveRequest so that clients that want to keep the connection alive can use this low-overhead way to do that.

bors r+

bors r+

bors r+


Update tm for VS Code to show function/variables of a package separator ":"

Description:
It would be good if we can have a separator scope(color) for the ":" (colon character).

import ballerina/config;
config:getAsString("FOO");

Outdated


WIP Add machines to cluster config

The flow:

Machine gets added, and provisioned by machine-controller
Cluster-controller watches for machine events and:

on add/update, adds or updates corresponding node in Cluster.RancherKubernetesEngineConfig.Nodes
on remove, removes the node from Cluster.RancherKubernetesEngineConfig.Nodes
Machine to node lookup is done by node.machineName == machine.Name
As the result, cluster object gets updated

ClusterProvisioner controller will get cluster.update event, and call kontainer-engine to update the rke config.

WIP will be removed once kontainer-engine/rke are updated to the latest types (there are some conflicts currently)
@ibuildthecloud @StrongMonkey
https://github.com/rancher/machine-controller/pull/6

Closing in favor of https://github.com/rancher/cluster-controller/pull/35


shared library libjvm.dylib does not contain the JNI_CreateJavaVM symbol.

Just installed dbeaver-community on my mac using Cask.
$ cask info dbeaver-community
dbeaver-community: 3.5.6
DBeaver Community Edition
http://dbeaver.jkiss.org/
/opt/homebrew-cask/Caskroom/dbeaver-community/3.5.6 (294 files, 35M)
https://github.com/caskroom/homebrew-versions/blob/master/Casks/dbeaver-community.rb
==> Contents
  Dbeaver.app (app)

Install seemed to go ok, but when I launch the app I get the following error:

$ java -version
java version "1.8.0_66"
Java(TM) SE Runtime Environment (build 1.8.0_66-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode)

That could happen in case of broken (or not good enough) Java installation.
Try this workaround: http://stackoverflow.com/a/25486012/1912589

Fixed after installing Java from https://support.apple.com/kb/DL1572?viewlocale=en_US&locale=en_US


add ssl support for legacy fyre.conv.load

#review

Hold off on merging this, need to make a couple more changes.

@soldnermike - tempted to get rid of conditionals by hard coding all refs to //cdn.livefyre.com/libs/fyre.conv.load.js, I don't believe t402 is ever used. Thoughts?


Deprecate stacks & samples past 1 year since last update

Which area/kind this issue is related to?

/area registry
Issue Description

Number of stacks and samples in the devfile registry should be state changed to deprecated to follow our stack lifecycle.
Acceptance Criteria
Change state to deprecated for all stacks/samples which have not seen updates for > 1 year:

[ ] .NET 5.0
[ ] .NET Core 3.1
[ ] Open Liberty Gradle
[ ] Open Liberty Maven
[ ] WebSphere Liberty Gradle
[ ] WebSphere Liberty Maven
[ ] Basic Spring Boot
[ ] Laravel

Laravel will remain as acceptance criteria until #1460 is resolved.

After looking into this issue the following stacks have been updated recently:

Open Liberty Gradle
Open Liberty Maven
WebSphere Liberty Gradle
Websphere Liberty Maven

It is important to note however these stacks went without any response from the owner for the changes and I believe we should be looking at deprecating them if it happens again.
Laravel 2.0.1 was updated recently however 2.0.0 and 1.0.1 were not and I will move forward with deprecating those 2 versions as Team Devfile is the stack owner.


Support influxdb-ruby gem 0.2.x

The influxdb ruby gem changed its API in the 0.2.x versions.  It looks like gem version <= 0.1.9 work with influxdb 0.8.x, but >= 0.2.0 supports only influxdb >= 0.9.0.

It seems to me that influxdb 0.9.x is not likely to be compatible with 0.8.x, and this cookbook seems to want support for both version.
I'd very much like to see 0.9.x support coming.
Do you plan to have a 0.8.x branch to maintain 0.8.x support and move to a 3.x.y cookbook version for the 0.9.x support?

Note that merging this will break compatibility with version 0.8 of influxdb, because influxdb gem version 0.2.x only support version 0.9 of influxdb. Choices will have to be made since version 0.2.x (which supports only version 0.9 of influxdb) and version 0.1.9 of the gem (which supports only version 0.8 of influxdb) have incompatible APIs.

In that case, the best move I think will be to do a major version bump, make a note in the CHANGELOG, and hope people upgrade safely. This PR looks good to me! Thanks @cmjosh!

Ah, maybe when merging this we should remove the attribute to flip which version of the gem you get too, since this will break compatibility anyway. I can take care of that.

Okay, hope I did it right ;) think it's okay but we'll see I guess.


Deployment: add nginx

Look here: https://github.com/clowzed/sero/blob/master/nginx-templates/default.conf.template
sero is very similar in stack: Axum, SeaORM, Postgres. They use nginx for deployment, which is something we could use as well.
The deployment should create

nginx conf file file (look at what sero does)
any local configuration tweaks that we need in order to work behind an nginx proxy (edit YAML for production, change it, write it back)
try to do it all with our generator + code injections framework

+1

Hey guys can I get this issue?

Hey @arferreira, sure, go for it.


[Bug]: managedPolicyArn array for Role broken in provider-aws-iam

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)
iam.aws.upbound.io/v1beta1 - Role
Resource MRs required to reproduce the bug
apiVersion: iam.aws.upbound.io/v1beta1
kind: Role
metadata:
  annotations:
    meta.upbound.io/example-id: iam/v1beta1/role
  labels:
    testing.upbound.io/example-name: role
  name: role-with-inline-policy-new
spec:
  forProvider:
    description: test description
    forceDetachPolicies: true
    assumeRolePolicy: |
      {
        "Version": "2012-10-17",
        "Statement": [
          {
            "Effect": "Allow",
            "Principal": {
              "Service": "eks.amazonaws.com"
            },
            "Action": "sts:AssumeRole"
          }
        ]
      }
    managedPolicyArns: [] ## reconciliation doesn't work
    # managedPolicyArns: ["arn:aws:iam::aws:policy/AdministratorAccess"] ## now reconciliation works
    inlinePolicy:
      - name: my_inline_policy
        policy: |
          {
            "Version": "2012-10-17",
            "Statement": [
              {
                "Effect": "Allow",
                "Resource": "*",
                "Action": "ec2:*"
              }
            ]
          }

Steps to Reproduce

kubectl -f apply the manifest above
Add any managed policy to the role
Confirm after poll internal that managed policy was not detached from role

What happened?
In order for the managedPolicyArns array to work, there needs to be at least 1 policy included.  If at least one policy exists in the array, Crossplane will successfully reconcile and remove any additional managed policies that get attached to the role.  However, if the array is empty, reconciliation fails when managed policies are attached.
Relevant Error Output Snippet
No response
Crossplane Version
1.16.0
Provider Version
1.4.0
Kubernetes Version
No response
Kubernetes Distribution
No response
Additional Info
No response

Nevermind, it looks as though you just need to include an empty string in the empty array for managedPolicyArns to work.
[""] works but [] doesn't.  Documentation just needs to be updated.

@trevoredshelf can you try 1.5.0? I could not reproduce this issue.


Use Criterion for benchmarks

This PR changes the benchmarks for the crate to use Criterion instead of the default benchmark harness, as well as added a few more common operations to ensure it covers more of the common operations for the crate.

CI is failing because criterion cannot compile on 1.39 due to a dependency using the 2021 edition. This is resolvable by:

Bumping the MSRV to 1.56 when the 2021 edition was introduced.
Moving the benchmarks into it's own crate so that criterion isn't in the dev-dependencies.

I'm favoring the second choice here since this seems like an arbitrary reason to bump the user facing MSRV. Though that said, 1.56 is also when they added the rust-version Cargo.toml field, which lets us enforce the MSRV in a salient user-facing way.


Accent color and dark mode platform settings

What does the pull request do?
This PR implements new low-level API for next features:

Get current dark theme preference and accent color(s).
Listen for changes of these color values
Possibility to apply theme to the OS window/view, if it was changed by the app and not the system

New low-level API:
(Higher level API will come later in 11.0, at least for dark theme, see https://github.com/AvaloniaUI/Avalonia/pull/8166, where this API will be actively used)
public enum PlatformThemeVariant
{
    Light,
    Dark
}
public enum ColorContrastPreference
{
    NoPreference,
    High
}
public record PlatformColorValues
{
    public PlatformThemeVariant ThemeVariant { get; init; }
    public ColorContrastPreference ContrastPreference { get; init; }
    public Color AccentColor1 { get; init; }
    public Color AccentColor2 { get; init; }
    public Color AccentColor3 { get; init; }
}
public interface IPlatformSettings
{
// ...
    PlatformColorValues GetColorValues();
    event EventHandler<PlatformColorValues>? ColorValuesChanged;
// ...
}

public interface ITopLevelImpl
{
// ...
    void SetFrameThemeVariant(PlatformThemeVariant themeVariant);
// ...
}

Platform details

Windows
Straightforward implementation. But only Win10 supported for reasons of maintability.
https://user-images.githubusercontent.com/3163374/210953077-fe50fd0a-0d31-4d05-b84b-34afecfaf42f.mp4

macOS
Also, a straightforward implementation. But a bit painful with all of these Obj C.
Note, this video is recorded from another branch (ThemeDictionary one), but it uses the same low level implementation as here.
https://user-images.githubusercontent.com/3163374/210953633-5e5894cf-df52-4c8b-ad56-05d9dc9f5409.mp4

Linux (FreeDesktop)
Only works if distro implements newest (~2021) standard of FreeDesktop. GTK and others specific settings are ignored.
Accent colors are not supported, and frame theme isn't changeable from the app (not sure if it's possible, if anybody wants to help - please do).
No high contrast support.
https://user-images.githubusercontent.com/3163374/210953445-ccbf0903-ddfd-468d-921f-70e6f98f9c43.mp4

Browser
Only preferred dark mode changes API is implemented. There is no readable accent colors API in the web standard.
https://user-images.githubusercontent.com/3163374/210953817-19914fa2-eb13-42c1-8733-e6077b1dfbf8.mp4

Android
Dark mode, accent colors (up to three different accent colors) are supported.
Status bar color changes are not there, as we don't have ready API for the status bar anyway.
https://user-images.githubusercontent.com/3163374/210954003-b5fb44ba-2ba3-4892-b469-09f0f70a1b86.mp4

iOS
Status bar status is the same as with android.
There is no video, "just trust me, it works".

Fixed issues
Fixes #4026
Fixes #9560
Fixes #3695

You can test this PR using the following package version. 11.0.999-cibuild0028282-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

For better accessibility, how about adding a HighContrast value to PlatformThemeVariant

You can test this PR using the following package version. 11.0.999-cibuild0028348-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0028434-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0028684-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

@maxkatz6  It seems ColorValuesChanged event failed to fire when dark mode settings changed. Using the latest Avalonia nightly build with Windows 11 22H2.

@laolarou726 can you debug if WM_SETTINGCHANGE in Win32Platform.WndProc is raised for you?
It works perfectly fine for me on 22H2 (22621.1105).

Instead of WM_SETTINGCHANGE we can handle WinRT UISettings.ColorValuesChanged COM event. But writing a com wrapper for that will be more time-consuming comparing to WM_SETTINGCHANGE which also should just work.

Instead of WM_SETTINGCHANGE we can handle WinRT UISettings.ColorValuesChanged COM event. But writing a com wrapper for that will be more time-consuming comparing to WM_SETTINGCHANGE which also should just work.

I'm also using the same system version, the event will fire when accent color changed. But not when dark mode settings changed? How should I capture WM_SETTINGCHANGE message?

Instead of WM_SETTINGCHANGE we can handle WinRT UISettings.ColorValuesChanged COM event.  The event is perfectly fine. Sorry about that.


Instruction to install husky, lint-staged and prettier in devDependencies

The ideal is to install these dependencies in devDependencies
https://prettier.io/docs/en/install.html
https://github.com/typicode/husky#install
https://github.com/okonet/lint-staged#installation-and-setup

This is intentional. There are many similar closed PRs and issues. Take a look at them if you want to know why. There's also an open issue to document the reasoning behind this: #5805


Can't create VMSS in South Africa West

This is autogenerated. Please review and update as needed.
Describe the bug
VMSS and VNets are indicated as generally available:

https://azure.microsoft.com/en-us/global-infrastructure/services/?products=virtual-machine-scale-sets,virtual-network
However any attempt to create a vnet or VMSS with location = southafricawest fails. I am also not able to select South Africa West in the azure portal.
Command Name
az vmss create
Errors:
Azure Error: LocationNotAvailableForResourceType
Message: The provided location 'southafricawest' is not available for resource type 'Microsoft.Network/virtualNetworks'. List of available regions for the resource type is 'westus,eastus,northeurope,westeurope,eastasia,southeastasia,northcentralus,southcentralus,centralus,eastus2,japaneast,japanwest,brazilsouth,australiaeast,australiasoutheast,centralindia,southindia,westindia,canadacentral,canadaeast,westcentralus,westus2,ukwest,uksouth,koreacentral,koreasouth,francecentral,australiacentral,southafricanorth,uaenorth,switzerlandnorth,germanywestcentral,norwayeast'.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az vmss create --resource-group {} --name {} --public-ip-per-vm --image {} --instance-count {} --vm-sku {} --lb {} --nsg {} --computer-name-prefix {} --admin-username {} --location southafricawest --vnet-name {}

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.6
Installer:

azure-cli 2.7.0 *

Additional Context

hi @biltongza from the description, service doesn't support VMSS in region South Africa West. Since you cannot do it either in azure cli or Potal. Involve service team to help on this. thanks.

Let me follow up on the availability of VMSS in this region.

@biltongza For region access related issues and requests, you can open a support request with our Support team. This document has helpful instructions for this: https://docs.microsoft.com/en-us/troubleshoot/azure/general/region-access-request-process

@biltongza I hope the document was helpful for your region access question. I'll close this issue, but please feel free to reopen if you need any further information on this topic here.


abi analyzer

For now, just the proposed db schema changes for what parsed data we'll store after parsing transactions, tx errors, and events using the abi. Event data will be stored in the existing evm_* fields in the chain.runtime_events table. The new fields for parsing transactions and transaction errors are described in 22_runtime_abi.up.sql
Part of https://app.clickup.com/t/866ad5hg1

:+1:


Propagate error code in ViT tests

@terrykong the CI shows that the ViT error codes are accurately reflected in the test-vit / publish-test / publish summary table


Labeler Crash with Mercator or Orthographic projection

When using a map projection of Mercator or Orthographic (possibly others as well) and labeling features there is a small bug that I have been trying to squash all weekend. I believe it is because when the reprojection of the polygons occurs there are some inherent values of NaN for x or y or both. When the labeler tries to determine the centroid of the said features it results in an exception.
Fixes #1199
Checklist

[x] I have included examples or tests
[x] I have updated the change log
[x] I am listed in the CONTRIBUTORS file
[ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

Centroid of feature with NaN coordinates is skipped so that an exception is not thrown,.

Closed this PR in lieu of: https://github.com/DotSpatial/DotSpatial/pull/1463


migration doesn end with rb

the migraton file when generating a devise model doesnt end with rb so it doesnt get migrated.

Duplicate of #3272. If not, please provide more information about your app, which Devise version you are using and a repository that reproduces the error.


The default namespace should also be shown as a kernel without a namespace.

For example suppose the default namespace is default.
default/datascience should be the same as datascience this is consistent. This may be controvertial and is up for discussion main motivation is notebooks that have the environment set to datascience have to be manually fixed to point to default/datascience

@costrouc I don't understand this issue. Is it still valid and if so, can you provide more information?

I do  not think this would be useful from a user experience POV:

Environments only exist within a namespace - removing the namespace intentionally (even if at the representation level only) from the default environment might cause mental model issues/confusion with the users.
On a regular JupyterLab workflow, users are expected to select the correct kernel for a given notebook (there are exceptions, though). Users are already familiar with this workflow, so this is not adding more friction.
Tangential to 1. but if a user has multiple environments with the same name across various namespaces, hiding/removing the namespace name within the default context can lead to confusion from the user POV.

Closing since there has not been a follow up and there does not seem to be a need for this


Enable mixer on ingress and egress

Question: if we can derive the source and destination attributes dynamically , can we invoke the mixer on outbound path for calls to external services from sidecar ?

We can, but mixer would panic since it expects "target.service". For outbound calls to external services, there is no cluster target service.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
547e210a3d02921a283f1f6c1826c172b1f911f6
link
@istio-testing smoke test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
ece97c11fa8f459efd76c319fbfbf896fadbc98e
link
@istio-testing smoke test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/retest

@istio-testing smoke test this

/test all

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
ece97c11fa8f459efd76c319fbfbf896fadbc98e
link
@istio-testing smoke test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
625a49e15a710ebfc976e55a3ad43d3e26a5b803
link
@istio-testing smoke test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
625a49e15a710ebfc976e55a3ad43d3e26a5b803
link
@istio-testing smoke test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
625a49e15a710ebfc976e55a3ad43d3e26a5b803
link
@istio-testing smoke test this

prow/pilot-presubmit.sh
aa3682510cec67d5a4cb574e30959fc39e79a26b
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing smoke test this

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
c4d88903a2639a257062822e41b8533e1897f465
link
@istio-testing smoke test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing smoke test this

Test passed locally. Force merging with @douglas-reid 's blessing.


Add - new snippet: undefined

Here is a new snippet. Hope you like it :)

Wow, can we contribute this directly to the angular repo?


Error detected while processing function ToggleSign

This error has been coming up for me sporadically.  It happens when I try to set a mark which is already set in some other place.
I don't know how to capture the error messages as it closes the window whenever I click on it.  I captured them as an image:

I hope the issue is resolved. If not, please feel free to reopen it.


use go for calculating the solution

it is so performant that it made it is x266 quicker on getting a solution

这个算法会少一些结果  还有很多重复项
目前算法还够用（


BIDS derived datasets file naming

Disclaimer
This is a discussion issue based on my understanding of the BIDS specification for derivatives and on some of ivadomed’s pipelines, it may not be entirely accurate, hence the design_discussion and help wanted labels. Don't hesitate to correct me. I also don't have a lot of time available to look further into this at the moment but I thought it was worth starting a discussion.
Context
Some of our pipelines in ivadomed use data that is not the original “raw data” but data that has been pre-processed in some way (e.g. extracting the mid slice for vertebral labelling (#707), averaging and motion correction on spine generic (https://github.com/spine-generic/spine-generic/pull/249))
Other similar situations are arising with small microscopy datasets where we want to split/crop a raw image in several parts, some of which would go to the training set, and others to the validation set. Therefore, each of those image “parts” would be considered “pre-processed” and would need to have a name and structure BIDS-compliant.
What we have done so far
For MRI data, we started to use the entity rec- (reconstruction) to identify such pre-processed data.
awesome-data/sub-bob/anat/sub-bob_T1w.nii.gz                     --> goes into the pre-processing pipeline
awesome-data-processed/sub-bob/anat/sub-bob_rec-XX_T1w.nii.gz    --> goes into training

But, we have encountered some issues with this. ~Ex: rec- is not an admissible entity for dwi (#824) and won't be indexed by pybids without an exception.~ EDIT: This is no longer an issue, pybids now correctly index dwi files containing the rec- entity. We were also not planning on using it in the Microscopy BEP.
Moreover, the more I read about this, the more I think we may be using it wrong, i.e. the rec- entity is part of the “raw data” specification, therefore should be used on raw data only. The example provided in the spec here is a motion correction reconstruction algorithm, which from my understanding is not apply “after” the acquisition, but “during” the acquisition of the "raw data".
Possible solution
I read a little bit more in the BIDS spec and found that there is a concept of a “derived dataset” (see here in the example 2). This is a “stand-alone” derived dataset independent from the source BIDS dataset.
Then in the BIDS Derivatives part of the spec, they explain how to name files in a derived dataset. It seems that different key/value pairs can be add to the filename that are specific to derivatives.
For example, the key desc- (description) that is used to distinguish files that would otherwise have the same name or to prevent the file from having the same name as the original (example here)
This seems to be exactly what we would need to replace the rec- entity and have a BIDS-compliant derived dataset.
awesome-data/sub-bob/anat/sub-bob_T1w.nii.gz                      --> goes into the pre-processing pipeline
awesome-data-processed/sub-bob/anat/sub-bob_desc-XX_T1w.nii.gz    --> goes into training

Other “derivatives-specific” entities from this part of the spec may also be useful for us.
Potential issues
I can foresee two issues with moving on with this possible solution:

We would have to make sure that the derived dataset entities (ex: desc-) are indexed correctly by pybids in our ivadomed pipelines.
We may have to rename several files in already existing BIDS dataset, which may break compatibility with previous experiment.

Additional note
There is also a DatasetType key in dataset_description.json that should be used to identified “raw” vs. “derivative” datasets here.

@mariehbourget thank you for raising this much needed discussion and for describing the context and possible options in a very clear manner. I totally agree with that plan. So, IIUC, it would also be possible to have a "desc" file inside an existing BIDS dataset. Example:
awesome-data/sub-bob/anat/sub-bob_desc-upsampled_T1w.nii.gz

I can think of a few situations where this would be useful.
Regarding the issues you raised, they seem manageable.

So, IIUC, it would also be possible to have a "desc" file inside an existing BIDS dataset.

No, that's the twist. Some entities like desc-, res- (which we use in the Microscopy BEP) and a few others are only admissible for "derived datasets". See desc- here.
I think it would be a good idea to move forward in that direction but we have to make sure to understand correctly how the "derived dataset" concept is supposed to be used. It would help to have a second pair of eyes on this to review the fine details.

So, quickly looking at the BIDS website "desc-" is applicable to "derivative data", which to my understanding is not another BIDS dataset (as exemplified with "awesome-data-processed"), but in the same BIDS dataset under the folder "derivatives/", which is supposed to include processed data (eg with FSL, SCT, etc.) and manual labels (eg: here).

From my understanding, the derivatives can be either:

in the derivatives folder of the awesome_data dataset
in a derived awesome-data-processed dataset as main subjects-folders (not in derivatives)

Both cases are explained here. For our use, I think case 2 is more suited.
Example case 1:
awesome-data/sub-bob/anat/sub-bob_T1w.nii.gz --> "raw data" not preprocessed
awesome-data/derivatives/awesome-software/sub-bob/anat/sub-bob_desc-XX_T1w.nii.gz --> pre-processed data with awesome software
awesome-data/derivatives/awesome-software/derivatives/labels/sub-bob/anat/sub-bob_desc-XX_T1w_seg-manual.nii.gz --> segmentation label of pre-processed data

I don't know if the third line (derivatives in derivatives) is allowed in BIDS
In ivadomed, the bids_path would then be awesome-data/derivatives/awesome-software and not awesome-data, this would have to be tested.

Example case 2:
awesome-data/sub-bob/anat/sub-bob_T1w.nii.gz --> "raw data" not preprocessed
awesome-data-prepocess/sub-bob/anat/sub-bob_desc-XX_T1w.nii.gz --> pre-processed data as main subjects-folder in derived dataset
awesome-data-prepocess/derivatives/labels/sub-bob/anat/sub-bob_desc-XX_T1w_seg-manual.nii.gz --> segmentation label of pre-processed data

In ivadomed, the bids_path would then be awesome-data-prepocess, and the file indexation would have to be tested with the new entity desc-.

You're absolutely right, thank you for the clarification

For confirmation, the desc- entity does get recognized by ivadomed when loading the dataset. Also, I didn't even have to specify that the dataset was a derived dataset (in dataset_description.json, "DatasetType" key was ommitted).

For confirmation, the desc- entity does get recognized by ivadomed when loading the dataset

Great, thank you @hermancollin for the test. Just to confirm, there is a column "description" in the bids_dataframe.csv with the right info?
We should do a similar test with MRI anat data as well to make sure everything is fine (microscopy files are forced indexed because they are not part of BIDs yet whereas anat data has to go through the BIDS-validator)

Just to confirm, there is a column "description" in the bids_dataframe.csv with the right info?
Ah! Sorry forgot to look inside that file. Unfortunately there is not "description" column. The input files did load properly but apart from the path/filename fields, they are indistinguishable in the bids_dataframe.csv file...

Maybe the problem is that the desc- field is not in present in the bids config I used (default one):
https://github.com/ivadomed/ivadomed/blob/master/ivadomed/config/config_bids.json

Maybe the problem is that the desc- field is missing from the default bids_config.json file

This "custom" config file is used to override the default config file from pybids (again, because microscopy is not BIDS yet)
In pybids here, are:

the default config file (bids.json), this is the config used when we run ivadomed with MRI anat data (no bids_config parameter required in the ivadomed config file for that)
the derivatives config file (derivatives.json), which includes the "derivatives-only" entities.

So the indexing relies entirely on pybids for the derivatives (I think!)
We should test:

the same microscopy dataset with the addition of the "DatasetType" key in dataset_description.json
a small MRI anat test dataset with desc- and with the "DatasetType" key

So the indexing relies entirely on pybids for the derivatives (I think!)
We should test:

the same microscopy dataset with the addition of the "DatasetType" key in dataset_description.json

Moreover we might want to add the _desc- entity in the custom config_bids.json file. It is described in the derivative.json file from the pybids link you provided:
{
    "name": "desc",
    "pattern": "desc-([a-zA-Z0-9]+)"
}

Moreover we might want to add the _desc- entity in the custom config_bids.json file. It is described in the derivative.json file from the pybids link you provided:

Yeah maybe, but my understanding is that the derivatives.json should already do the job without having to specify it, but it's just a supposition at this point based on:

ivadomed uses pybids to index
desc- is not in the default bids.json from pybids
pybids uses bids.json + derivatives.json + BIDS-validator for BIDS-compliant modalities (ex: MRI anat)

we have to confirm this with a test on anat data with desc- field.

pybids uses our custom config_bids.json and skip the BIDS-validator for non BIDS-compliant modalities (ex: microscopy)

the question is: what happens with derivatives.json in that case?

Just tried with the "DatasetType" field set to "derivative" and unfortunately the desc field is not added into the bids_dataframe.csv file. Maybe this indicates that the derivative.json file isn't used as config file even when inputting a derived dataset into ivadomed but further investigation is needed.

Thank you for the detailed description of this issue @mariehbourget! I totally agree with how you have presented the 2nd method of storing the "derived" datasets. I do have some questions in general, which are described below:

Am I correct in understanding that when we want to shift from using rec- to desc-, in addition to renaming the files, we also have to reorganize how the folders are stored? In particular, currently in ivadomed, the idea of the 2nd method of storing preprocessed (derived) datasets (see link above) is not implemented, rather, it is all inside a single BIDS compliant structure that has a derivatives folder that contains all the preprocessed data. This has to be changed (and tested), right?
As for the current state of things, tests by @hermancollin confirm that the custom bids config file being used for microscopy data works with the desc- file name modification. However, it has to be tested for MRI anat data to be absolutely sure this works because of the third point in this comment. Is this correct?

If point 1 makes sense, then one way to check whether this works with ivadomed is to create a small MRI dataset with separate raw and derivatives datasets like shown in the example code for the 2nd method here and change all the occurrences of rec- to desc-. What do you think @mariehbourget ? Does it make sense? Lmk if you have any other suggestions.
I also agree with your hunch that we do not have to tweak pybids's  bids.json file by adding the desc- key because the derivatives.json includes it (as you already said). So, as far as I can understand, reorganizing the folder structure and renaming files should do it for the MRI test.

Thank you @naga-karthik for looking into this.

Am I correct in understanding that when we want to shift from using rec- to desc-, in addition to renaming the files, we also have to reorganize how the folders are stored? In particular, currently in ivadomed, the idea of the 2nd method of storing preprocessed (derived) datasets (see link above) is not implemented, rather, it is all inside a single BIDS compliant structure that has a derivatives folder that contains all the preprocessed data. This has to be changed (and tested), right?

Right now in ivadomed, we work with 2 dataset structures:

the "raw data" in sub-XX folders at the root of the dataset and "labels" in the derivatives folder.
the "preprocessed data" in sub-XX folders at the root of the dataset, with rec- in the filenames and "labels" in the derivatives folder.

We would like to do the exact same thing as the second one but with desc- in the filename instead of rec- (to be more BIDS compliant).
So for the 2nd method of storing derived dataset (the stand-alone independent version, example 2 in the link), we would not need to re-arrange the structure. We would have two things:

awesome-data-preprocess/sub-bob/anat/sub-bob_desc-XX_T1w.nii.gz  (same structure as what we have now but with desc- in the filename)
awesome-data-preprocess/derivatives/labels/sub-bob/anat/sub-bob_desc-XX_T1w_seg-manual.nii.gz : for our segmentation labels.

What is ambiguous here is that the awesome-data-preprocess dataset is already a "derivative" dataset (because it is not the "raw data" in BIDS terms), but we also have the labels in the derivatives folder (which are like a derivatives of derivatives).

As for the current state of things, tests by @hermancollin confirm that the custom bids config file being used for microscopy data works with the desc- file name modification. However, it has to be tested for MRI anat data to be absolutely sure this works because of the third point in this comment. Is this correct?

You are right, currently the desc- entity is working for indexing microscopy files. However, the "description" column does not appear in the bids_dataframe.csv, which we think it should. We would like to test with MRI data because MRI is an official BIDS modality and will go through the real pybids indexation, without the custom config_bids.json file and without files being forced indexed by ivadomed like for microscopy at the moment.

If point 1 makes sense, then one way to check whether this works with ivadomed is to create a small MRI dataset with separate raw and derivatives datasets like shown in the example code for the 2nd method here and change all the occurrences of rec- to desc-. What do you think @mariehbourget ? Does it make sense? Lmk if you have any other suggestions.

Yes, we would need a small "preprocessed" MRI "stand-alone" dataset. Either use a dataset with the rec- entity and changing it to desc-, or we could take our spinegeneric_example_dataset, and add desc- to the name of a few files and derivatives.
We may also need to add the "DatasetType" key with derivative value in the dataset_description.json file of the dataset.
We would first need to check:

Are the files indexed in the bids_dataframe.csv
Is the column "description" (or maybe "desc") is present in the dataframe?

Let me know if you have questions or if I misunderstood something, thank you!

What is ambiguous here is that the awesome-data-preprocess dataset is already a "derivative" dataset (because it is not the "raw data" in BIDS terms), but we also have the labels in the derivatives folder

Yeah exactly! Thanks for mentioning this. I was wondering the same thing about how the approach ivadomed has taken is a bit confusing in terms of using the folder name "derivatives". But, I understand now, we just have to rename rec- to desc- for the purpose of this issue.

However, the "description" column does not appear in the bids_dataframe.csv, which we think it should.

Sorry but where can I find this csv file? I couldn't read about it on BIDS' documentation. Is it something exclusive to ivadomed?

we could take our spinegeneric_example_dataset, and add desc- to the name of a few files and derivatives

I think we can go ahead with this approach as it seems simpler.
At this point, I am only limited by my knowledge on the bids_dataframe.csv file. I can get back with some more suggestions/actions after I read about it some more.

Sorry but where can I find this csv file? I couldn't read about it on BIDS' documentation. Is it something exclusive to ivadomed?

Yes, this is in ivadomed, in the path_output folder, the loader writes a bids_dataframe.csv with all the files and metadata indexed and used from the path_data for a given training/testing, it came from https://github.com/ivadomed/ivadomed/blob/7a595ae39e94085837582f7176b8ec59bd9a2bc9/ivadomed/main.py#L351 in the main.

Based on some experiments and suggestions thanks to @mariehbourget, here is my latest finding:

I created a copy of the data_example_spinegeneric available from this tutorial and kept the names of three files as it is and renamed all the remaining files according to the following:

awesome-data-preprocess/sub-bob/anat/sub-bob_desc-XX_T1w.nii.gz for the input training data
awesome-data-preprocess/derivatives/labels/sub-bob/anat/sub-bob_desc-XX_T1w_seg-manual.nii.gz for the ground truth labels.
The DatasetType, specifically, "DatasetType": "derivative" was also added to both the dataset_description.json files in the respective root and derivatives folders.
The dataset's folder structure was kept unchanged. Only filenames were modified to include desc-.

Observation: The desc- entity was not indexed because the bids_dataframe.csv file contained only the names of those files in which the filename was NOT changed (i.e. the entity desc-, wasn't added). Ivadomed training progresses without any error by conveniently discarding the desc- entity files.
Conclusion (Preliminary): This approach of only adding the desc- entity (and the DatasetType key) without modifying the folder structure (to appropriately reflect the 2nd example mentioned in the discussion above) does not help because the modified files are unable to be indexed.
TODO: Think of a different approach, this time possibly with a re-organization of the folder structure. I believe this can help because currently ivadomed is not able to locate these derivative files (i.e. the ones with the desc- entity) so placing these derivatives in the correct folder structure should solve this indexing issue.

TODO: Think of a different approach, this time possibly with a re-organization of the folder structure. I believe this can help because currently ivadomed is not able to locate these derivative files (i.e. the ones with the desc- entity) so placing these derivatives in the correct folder structure should solve this indexing issue.

Thank you @naga-karthik for the tests and detailed report.
I agree that re-organizing the structure would help indexing the files because pybids index everything that is in the derivatives folder regardless of the naming. Unfortunately, pybids doesn't parsed the filenames of derivatives and the columns of the bids_dataframe associated with these files would be empty (as far as I  know).
Moreover, ivadomed needs "primary" sub-XX folders at the root of the dataset in its current implementation. Pointing to awesome-data/derivatives/preprocessing-pipeline as path_data would alleviate that but we would end up with the same indexing issue as before.
My guess is either:

We don't understand how to properly create a derived stand-alone dataset
pybids does not index those files in any cases when the validator is on.

From here in pybids, it uses only the bids.json file by default and not the derivatives.json file. So the suggestion from @hermancollin to add desc- to our custom config_bids.json file was right. Another option would be to pass both the bids.json and derivatives.json as a list in the bids_config parameter in the ivadomed config file. Unfortunately, I think these approaches would require we turn off the validator as well.

Update:
A while ago, we were wondering if having a derivatives folder inside a derivatives folder (Example case 1 in this comment) was allowed by BIDS.
The answer is YES, as described in the third example (Example of a pipeline with nested derivative directories:) in the spec here.

I'm starting to work on this issue again to better understand the file indexing of "derivatives folder" and of "stand-alone derived datasets" by pybids.
I will document my findings here as I go but it may be a bit difficult to follow/see the big picture, so I will make a recapitulative comment when my investigations are finished.

Clarify the indexation of "derived dataset" with desc- entity
Previous investigations (https://github.com/ivadomed/ivadomed/issues/860#issuecomment-880229411, https://github.com/ivadomed/ivadomed/issues/860#issuecomment-885987369) have shown that pybids was not indexing files with the desc- entity and/or adding its column/value to the dataframe, even when the DatasetType was set to derivative in dataset_description.json.
I suspect that there was an update in pybids since, because with the latest version pybids==0.15.4, it works.
I tested 2 cases:

A derived dataset where all files have the desc- entity in the filename.
A dataset where SOME files have the desc- entity and other files have a normal raw data naming (this is not supposed to happen in BIDS and is not compliant but was helpful for investigations).

In both cases, all files in subject folders (at the root of the dataset) were indexed properly by pybids provided that the 2 following fields were present in the root dataset_description.json file:

"DatasetType": "derivative",
"GeneratedBy": [{"Name": "Test pipeline"}],

This is true for both anat and micr datatypes.
Furthermore, a desc column appears in the dataframe with the correct values.
JSON metadata fields are included in the dataframe as expected (same as with "raw data").
Note: micr files are force indexed on master branch at the moment of testing (commit 487df8a).
So I tested also without the force indexing (not required since pybids update to include microscopy) on branch mhb/update-force-index-micr-ct of PR #1203 (commit b3c7a8ca).

Can we have a derivatives folder in a derived dataset?
1. With the ivadomed naming convention for derivatives (ex: _seg-manual) --> YES, the indexing and pairing of files is working as usual.
For example with:
* filename at the sub-level of the derived dataset: sub-XX_desc-YY_T2w.nii.gz
* filename at the derivatives level: sub-XX_desc-YY_T2w_seg-manual.nii.gz
2. With the BIDS derivatives naming convention --> NO, we will encounter some incompatibility if we already use the desc- entity in the sub-level filenames because the "mask" derivatives :
* MAY contain the desc- entity as well but we cannot have 2 desc- entities in the same filename.
* the original source entities MUST be before the label- entity but the desc- entity MUST come after the label- entity (ref: <source_entities>[_space-<space>][_res-<label>][_den-<label>][_label-<label>][_desc-<label>]_mask.nii.gz, here)
For example with:
* filename at the sub-level of the derived dataset: sub-XX_desc-YY_T2w.nii.gz
* filename at the derivatives level: sub-XX_desc-YY_label-seg_mask.nii.gz or sub-XX_desc-YY_label-seg_desc-T2w_mask.nii.gz are not BIDS compliant.
We may need to reach out to the BIDS community to better understand how to deal with "derivatives chains" as per the example in point 2.

Can we have a derivatives folder in a derivatives folder?
A derivatives folder in a derivatives folder is compliant with BIDS as per: https://bids-specification.readthedocs.io/en/stable/02-common-principles.html#storage-of-derived-datasets
Example
awesome-dataset/derivatives/awesome-dataset-processed/sub-bob/anat/sub-bob_desc-XX_T1w_seg-manual.nii.gz
awesome-dataset/derivatives/awesome-dataset-processed/derivatives/labels/sub-bob/anat/sub-bob_desc-XX_T1w_seg-manual.nii.gz

(I'm ignoring the file naming issues from the previous comment with the BIDS derivatives convention and using the ivadomed convention for simplicity)
In ivadomed, it causes 2 minor issues:

The bids_dataframe filtering is based on the word "derivatives" being in the path or not. Having 2 "derivatives" string in the path is breaking here, so we would need to update the filtering to avoid this.
In order to ivadomed to work, we would need to set the path_data to the awesome-dataset-processed  folder (in the first derivatives folder), and we would need to copy the participants.tsv and samples.tsv there. I don't know if that would be considered BIDS compliant as I did not find clear restrictions to do so in the Common principles or Modality agnostic files sections.

Again, we may need to reach out to the BIDS community to know if modality agnostic files are allowed in derivatives pipeline folders. For reference, it doesn't raise errors in the validator 1.9.9.

Clarify the indexation of "derivatives folder" (are files recognized and indexed? (YES) are the filename entities of derivatives included in the dataframe? (NO), how to make this happen?).
Are JSON metadata in derivatives folder indexed in the dataframe?

Currently, we use the pybids.BIDSLayout to index the root folder of the dataset with derivatives=True. In that case, derivatives files are indexed in the dataframe but only their path. The filename entities are not parsed and derivative JSON metadata (if present) is not indexed.
Example with 2 T2w subjects and seg-manual label:

path
data type
extension
subject
suffix
some TSV metadata
raw data JSON metadata
derivative JSON metadata

dataset_path/sub-cardiff03_T2w.nii.gz
anat
.nii.gz
cardiff03
T2w
AA
XX

dataset_path/sub-hamburg01_T2w.nii.gz
anat
.nii.gz
hamburg01
T2w
AA
XX

derivatives_path/sub-cardiff03_T2w_seg-manual.nii.gz

derivatives_path/sub-hamburg01_T2w_seg-manual.nii.gz

A possible workaround for this would be to use the pybids.BIDSLayout to index the root folder and the derivative folder separately with derivatives=False then combined the 2 dataframes together.
In addition to parsing ALL entities and JSON in the dataframe, it could also simplify the code for the bids_dataframe filtering here and we could also assigned TSV metadata to derivatives.
Example with 2 T2w subjects and seg-manual label:

path
data type
extension
subject
suffix
some TSV metadata
raw data JSON metadata
derivative JSON metadata

dataset_path/sub-cardiff03_T2w.nii.gz
anat
.nii.gz
cardiff03
T2w
AA
XX

dataset_path/sub-hamburg01_T2w.nii.gz
anat
.nii.gz
hamburg01
T2w
AA
XX

derivatives_path/sub-cardiff03_T2w_seg-manual.nii.gz
anat
.nii.gz
cardiff03
manual
AA

YY

derivatives_path/sub-hamburg01_T2w_seg-manual.nii.gz
anat
.nii.gz
hamburg01
manual
AA

YY

Note: in pybids the suffix column for derivatives is based on the last underscore (_) in the filenames, so with the ivadomed naming convention for labels, we end up with manual in that column.

How is this related to the current issue?

If we choose to use the concept of "derived dataset" for our file naming with for example the desc- entity, the same cnocept applied as in this previous comment which is: both the derived dataset root folder and the derivatives/labels folder need to have a dataset_description.json file with the following fields in them:

"DatasetType": "derivative",
"GeneratedBy": [{"Name": "Test pipeline"}],

In addition, our current implementation ask for a dataset_description.json file in the derivatives folder  OR in derivatives/labels here. If we want to index both the root folder and the labels folder separately, the dataset_description.json MUST be in derivatives/labels.

Are there additional JSON files/fields that are REQUIRED with the usage of desc-?
The usage of desc-, as intended in the initial post of this issue is the case of:

Preprocess or cleaned data and spedified that "All REQUIRED metadata fields coming from a derivative file’s source file(s) MUST be propagated to the JSON description of the derivative unless the processing makes them invalid".

OR in the case of:

Preprocessed, coregistered and/or resampled volumes, where the only field required is SkullStripped, true of false.

Summary
Context
This issue was initially open to explore the possibility of using the BIDS concept of "derived dataset" for our "preprocessed" datasets. We currently use the BIDS "raw data" naming scheme instead of the "derivatives" naming scheme for such datasets.
Please see initial comment for complete context.
Aside from the original questions, this investigation led to various questions regarding the indexing of derivatives files with pybids. More than perfect BIDS compliance, the pybids behavior is ultimately the important part for us as we are using it in ivadomed to index our datasets.
In parallel, we started looking into using the "derivatives" naming scheme for our "labels" instead of our own ivadomed convention in #1202. While this is not exactly the same issue, a lot of the investigations done here could be useful for the implementation in #1202.
As a reference, the newest batch of investigation starts here, where 6 topics related to derived dataset are covered.
Recommendations

I would not recommend using the "derivatives" naming scheme for our preprocessed dataset until we hear back from the BIDS community regarding proper naming (re: https://github.com/ivadomed/ivadomed/issues/860#issuecomment-1309078451)
Similarly, the future project of using the "derivatives" naming scheme for our label in #1202 may influence decisions here and should be treated in parallel.
As for indexing derivatives in general, this part of the investigation could be implemented separately and improve the current bids_dataframe indexation.


Cannot read property offset

Hi ,
We have been using no-kafka since 6 months in production . We run multiple instances of no-kafka code running as consumer.  We have been observing that sometimes the consumer code will start logging this error . The error logs seems to be as if code is stuck for a specific message and it runs in a loop trying for the same message .
Also as this happens the Kafka Bytes out JMX Metrics  slowly ramps up in MBs whereas Bytes in is still in KBs . Attached the screenshot .

{"log":"[at apply (/home/addison/node_modules/no-kafka/node_modules/lodash/lodash.js:484:17)]\n","stream":"stderr","time":"2017-09-29T22:51:00.471242722Z"}
{"log":"2017-09-29T22:51:00.491Z WARN no-kafka-client Handler for entmonTxn_Entmon_hpit-cld-ptmonitor:0 failed with TypeError: Cannot read property 'offset' of undefined\n","stream":"stdout","time":"2017-09-29T22:51:00.492837884Z"}
{"log":"    at /home/addison/src/plugin/msg-sys.js:276:28\n","stream":"stdout","time":"2017-09-29T22:51:00.492915616Z"}
{"log":"    at Array.forEach (native)\n","stream":"stdout","time":"2017-09-29T22:51:00.492927214Z"}
{"log":"    at Object.dataHandler (/home/addison/src/plugin/msg-sys.js:272:20)\n","stream":"stdout","time":"2017-09-29T22:51:00.492935456Z"}
{"log":"    at Object.tryCatcher (/home/addison/node_modules/bluebird/js/release/util.js:16:23)\n","stream":"stdout","time":"2017-09-29T22:51:00.492944657Z"}
{"log":"    at Object.handler (/home/addison/node_modules/bluebird/js/release/method.js:15:34)\n","stream":"stdout","time":"2017-09-29T22:51:00.492953261Z"}
{"log":"    at self.client.fetchRequest.map.concurrency (/home/addison/node_modules/no-kafka/lib/base_consumer.js:66:26)\n","stream":"stdout","time":"2017-09-29T22:51:00.492960986Z"}
{"log":"    at bound (domain.js:280:14)\n","stream":"stdout","time":"2017-09-29T22:51:00.493104566Z"}
{"log":"    at runBound (domain.js:293:12)\n","stream":"stdout","time":"2017-09-29T22:51:00.494278963Z"}
{"log":"    at tryCatcher (/home/addison/node_modules/bluebird/js/release/util.js:16:23)\n","stream":"stdout","time":"2017-09-29T22:51:00.494317597Z"}
{"log":"    at MappingPromiseArray._promiseFulfilled (/home/addison/node_modules/bluebird/js/release/map.js:61:38)\n","stream":"stdout","time":"2017-09-29T22:51:00.494346361Z"}
{"log":"    at MappingPromiseArray.PromiseArray._iterate (/home/addison/node_modules/bluebird/js/release/promise_array.js:114:31)\n","stream":"stdout","time":"2017-09-29T22:51:00.494377258Z"}
{"log":"    at MappingPromiseArray.init (/home/addison/node_modules/bluebird/js/release/promise_array.js:78:10)\n","stream":"stdout","time":"2017-09-29T22:51:00.494403345Z"}
{"log":"    at bound (domain.js:280:14)\n","stream":"stdout","time":"2017-09-29T22:51:00.494425892Z"}
{"log":"    at MappingPromiseArray.runBound (domain.js:293:12)\n","stream":"stdout","time":"2017-09-29T22:51:00.494451468Z"}
{"log":"    at Promise._settlePromise (/home/addison/node_modules/bluebird/js/release/promise.js:566:21)\n","stream":"stdout","time":"2017-09-29T22:51:00.494479628Z"}
{"log":"    at Promise._settlePromise0 (/home/addison/node_modules/bluebird/js/release/promise.js:614:10)\n","stream":"stdout","time":"2017-09-29T22:51:00.494501482Z"}

I think the error is being thrown in your handler, not in no-kafka:

Handler for entmonTxn_Entmon_hpit-cld-ptmonitor:0 failed with TypeError

Please refer to #214 on the actual root cause when we see this error

I don't think wrong producer payload can be the reason for consumer handler error. If the produced payload can't be deserialised by Kafka server then it won't be sent to the consumers in the first place. So #214 definitely has no relation to this issue.

Hi ,
Based on what we saw when trying to consume these messages - attached the observation .
  From: Oleksiy Kryvoshey<EMAIL_ADDRESS>
To: oleksiyk/kafka<EMAIL_ADDRESS>Cc: kroyhpe<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Monday, November 13, 2017 11:11 PM
Subject: Re: [oleksiyk/kafka] Cannot read property offset (#207)
I don't think wrong producer payload can be the reason for consumer handler error. If the produced payload can't be deserialised by Kafka server then it won't be sent to the consumers in the first place. So #214 definitely has no relation to this issue.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[HTTP Header] Cross-Origin-Opener-Policy

The Cross-Origin-Opener-Policy (COOP) header prevents third-parties from opening/controlling a window.
Explainers:
https://docs.google.com/document/d/1eQEdjHDaJHJ5SFyRKjcqohS7x8XSpF8xmajXimAKcHc
https://docs.google.com/document/d/1Ey3MXcLzwR1T7aarkpBXEwP7jKdd2NvQdgYvF8_8scI
Initial definition:
https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e
Google I/O 2019 explainer video:
https://www.youtube.com/watch?v=DDtM9caQ97I&t=2264
Chrome status:
https://www.chromestatus.com/feature/5432089535053824

Edit:
This header was implemented in Safari 12 and renamed from Cross-Origin-Options to Cross-Origin-Window-Policy but support was dropped in release note 67.
This header was also at some point proposed as Cross-Origin-Isolate.
I mention name changes mainly because we should preferably include those as keywords so developers can find the latest version of the header if they stumble upon old documentation.

Safari actually dropped support for this header in the same release note where they mentioned renaming Cross-Origin-Options to Cross-Origin-Window-Policy.
I'm keeping this issue open, monitoring eventual resolution in https://github.com/whatwg/html/issues/3740.

https://bugzilla.mozilla.org/show_bug.cgi?id=1521808

https://bugs.chromium.org/p/chromium/issues/detail?id=922191

The Cross-Origin-Opener-Policy header is now implemented in Firefox 67.

Available at https://caniuse.com/mdn-http_headers_cross-origin-opener-policy.


Can't compile Godot with asan, lsan, ubsan and disabled vorbis

Godot version:
3.2.dev.custom_build 7126654ea
OS/device including version:
Ubuntu 18.04 GCC 7.4, clang 6.0
Issue description:
Commands
scons p=x11 -j6 use_llvm use_lsan=yes use_asan=yes use_ubsan=yes module_vorbis_enabled=no

Errors
Ranlib Library         ==> core/libcore.x11.tools.64s.a
[Initial build] Linking Program        ==> bin/godot.x11.tools.64s
/usr/bin/ld: modules/libmodules.x11.tools.64s.a(video_stream_theora.x11.tools.64s.o): undefined reference to symbol 'vorbis_block_clear'
//usr/lib/x86_64-linux-gnu/libvorbis.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
scons: *** [bin/godot.x11.tools.64s] Error 1
scons: building terminated because of errors.

anlib Library         ==> core/libcore.x11.tools.64.llvms.a
[100%] Linking Program        ==> bin/godot.x11.tools.64.llvms
[100%] /usr/bin/ld: modules/libmodules.x11.tools.64.llvms.a(video_stream_theora.x11.tools.64.llvms.o): undefined reference to symbol 'vorbis_block_clear'
//usr/lib/x86_64-linux-gnu/libvorbis.so.0: error adding symbols: DSO missing from command line
clang: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [bin/godot.x11.tools.64.llvms] Error 1
scons: building terminated because of errors.

I tried scons -j3 use_llvm=yes use_lsan=yes use_asan=yes use_ubsan=yes module_vorbis_enabled=no on Windows 10 and there were no errors. So, this issue if it still exists, could be Linux specific.

That is Linux(and probably also macOS) specific, because sanitizers aren't available in this form in Windows


Unified API for Browser and Native ?

Wondering if this is designed to provide an unified API for both Browser and Native ( mobile and desktop).
I am attempting to use this with gioui.org.
https://github.com/gioui
I got some basic code working for Browser, but struggled to get it also working for Native.

Hey gedw99! 👋 Yes, hackpadfs is definitely intended to be a unified API.
The implementations could be platform-specific, depending on which system APIs are present. For example, indexeddb.FS is supported anywhere an IndexedDB API exists, e.g. browsers. The os.FS provides the same abstraction and uses the standard library os package instead.

and Native ( mobile and desktop)

I'm open to supporting a new FS for native. Did you mean React Native here? I haven't tried them together before, though.
React Native's docs recommend https://reactnative.dev/docs/security#async-storage Async Storage or a platform-specific secure storage option. I found an IndexedDBShim with an open issue https://github.com/indexeddbshim/IndexedDBShim/issues/313 to support React Native, but it's not exactly simple.
Async Storage appears to support some kind of batching https://react-native-async-storage.github.io/async-storage/docs/api#multiget, possibly as transactions? It might even be a good candidate for a keyvalue.TransactionStore.

On Oct 5, 2021, at 10:52 PM, ged @.***> wrote:
@JohnStarich https://github.com/JohnStarich ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hack-pad/hackpadfs/issues/6#issuecomment-935381540, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHWOIIIAMAJTKP66L7IZADUFPBYTANCNFSM5FMS6TXA.

Got it, no worries. I think it should work natively on several of the gio supported platforms. Linux, macOS, and Windows for sure with the os.FS. WebAssembly in a browser with indexeddb.FS. I’m less sure about today’s support for the others, but maybe they could be supported too.
I think iOS, tvOS, and Android might work today. Go could theoretically target those platforms via CGO, just not sure what their os package support looks like.

Ok thanks. I think this is viable.
In relation to CGO, GIOUI has some fragmented support for Reading and Writing to the File System when selecting a File to Open or Save : https://github.com/gioui/gio-x/blob/main/explorer/README.md
No IOS of MAC support yet, the the others are done: https://github.com/gioui/gio-x/blob/main/explorer/explorer_unsupported.go
i sarted to make a GIO based example using Hack-pad. I got WASM working easily. But got stuck on Native ( Desktop and Mobile ). The reason i got stuck was that i found it hard to see how to do it in the API.
Is there any chance you could make a repo called "TestHarness" in Hack-pad that loads the required instance objects of the FS for WASM and Non Mobile, so i can get past this. THen i have a basis to keep working on getting things working with GIO.
My aim it to make a fully working example that combines the GIO Explorer, and a FS. This would provide a pretty stable basis for how devs can integrate FS aspects into their Apps.

Hey @JohnStarich
thanks for the docs. it's clear how to do it.
But the docs looks pretty good. It's pretty much what i ended up doing in my code to kick the tires.
The interfaces are clean and its obvious. Just a matter of trying it out from GIO and see what things are hit.
I am adding @Inkeliz and @whereswaldon as i think both may be interested to a degree in this, but can say for sure.
Also I have to take a break on coding for a while, as i pulled a back muscle when fixing my kids roof, so need to chill for a while.
https://github.com/Inkeliz/giostorage/issues/1

@gedw99 Also, hope you'll feel better soon ❤ We'll be here when you're well again, too 🙂


⚠ Bofrost.at has degraded performance

In 7d43858, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1429 ms

Resolved: Bofrost.at performance has improved in 0f388a2.


Factorials should go down to 0!

It should be explicit as to if the factorial definition in problem #2 stops at 0! or 1!

Definition of "generator iterator" problem sais that factorial should start from 1. If I understood correctly.


Using git diff for autocomplete results in completions including diff lines and -/+ prefixes

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: macOS
- Continue version: v0.9.?
- IDE version:
- Model: Qwen2.5-Coder-7B-Instruct
- config.json:

  "tabAutocompleteModel": {
    "title": "Qwen2.5-Coder-7B-Instruct",
    "provider": "openai",
    "model": "Qwen2.5-Coder-7B-Instruct",
    "apiBase": "http://localhost:8081/"
  },
  "tabAutocompleteOptions": {
    // "maxDiffPercentage": 0, // <- setting to 0 disables git diff
    "maxPromptTokens": 2048,
    "template": "<|fim_prefix|>{{{ prefix }}}<|fim_suffix|>{{{ suffix }}}<|fim_middle|>"
  },

Description
While I think using the git diff to provide additional context is useful (https://github.com/continuedev/continue/pull/2999), sometimes it results in the LLM returning completions that include the diff preambles and line prefixes -/+.
ie suggestions include:
diff --git a/internal/a/a..go b/internal/a/a.go

- change 1
+ change 2

I can disable it by setting tabAutocompleteOptions.maxDiffPercentage to 0 but longer term it would be nice to have that additional context in the prompt.
I think competitors include the additional context in a comment block in the prefix. I assume the main difficulty in that is determining how to wrap multiline comments for whatever programming language is in use.
To reproduce
No response
Log output
No response

I think competitors include the additional context in a comment block in the prefix. I assume the main difficulty in that is determining how to wrap multiline comments for whatever programming language is in use.

@tienshiao we actually have that commenting feature, it's not currently enabled for git diff: https://github.com/continuedev/continue/blob/main/core/autocomplete/templating/formatting.ts#L91
We honestly need to test it a bit more and consider all edge cases. It works well with Codestral, which seems to have a very good grasp of how to work with git diff but I've also seen qwen give incorrect completions.
I'll test it locally to see if wrapping the diff in a comment would help or if we might need to do something else. For example, we could designate diff --git as a stop token for certain models.

Yeah, I had also tried injecting \ndiff --git, \n-, and \n+ as stop tokens and that seemed to work as well.
I suspect a point of confusion for the completion is that the prefix starts with the diff preamble, potentially contains multiple diffs, and then the actual code prefix for the file being edited but the only boundary between the diffs and the code is a comment with the filename // dir/a.go.
Qwen has additional tokens like <|file_sep|>: https://github.com/QwenLM/Qwen2.5-Coder?tab=readme-ov-file#4-repository-level-code-completion
But I'm not sure if it works with FIM or would be appropriate here with diffs.

Qwen has additional tokens like <|file_sep|>: https://github.com/QwenLM/Qwen2.5-Coder?tab=readme-ov-file#4-repository-level-code-completion

I checked out the docs and we definitely should be doing this. We already do something similar for Codestral with the +++++ separator: https://github.com/continuedev/continue/blob/main/core/autocomplete/templating/AutocompleteTemplate.ts#L84
I'll keep this at the back of my head, unless you feel like experimenting and creating a Qwen template similar to the one we use for Codestral.
In the meantime, I commented out the diff and it seems to fix the issue with git artifact as completions, at least based on my testing so far: https://github.com/continuedev/continue/pull/3111


Missing dist/ directory in demo/realtime-txt2img/frontend

I got the error RuntimeError: Directory './frontend/dist' does not exist when running file in demo/realtime-txt2img/ main.py. Look lile ./frontend/dist is specified as static/ directory for app.mount() on line 90 in main.py but that directory is not available in the frontend/ directory.

Replacing ./frontend/dist to ./view/build fixed it


Any reason you implement List and Array, why not implement just IList?

Array and List both derive from Ilist interface, any reason you don't use IList instead?

I believe there would be a performance hit in some, if not all cases.  If you think not, I can do some quick benchmarks to experiment to confirm or deny.

Yeah, comparing Sum using array vs IList:

BenchmarkDotNet=v<IP_ADDRESS>, OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i7-6700 CPU 3.40GHz, ProcessorCount=8
Frequency=3328126 Hz, Resolution=300.4694 ns, Timer=TSC
  [Host]    : Clr 4.0.30319.42000, 64bit RyuJIT-v4.7.2600.0
  RyuJitX64 : Clr 4.0.30319.42000, 64bit RyuJIT-v4.7.2600.0

Job=RyuJitX64  Jit=RyuJit  Platform=X64

Method
TEST_SIZE
Mean
StdDev
Allocated

Sum
100000
45.2131 us
0.1464 us
0 B

SumIList
100000
546.2191 us
2.7519 us
0 B


Bad format for VP vote?

While parsing the voting records for the 115th congress, my script broke on s54. Upon examining the script, I realized that there is a "VP" string value in the ['votes']['Yea'] array:
"Yea": [       "VP",        {         "display_name": "Alexander (R-TN)",          "first_name": "Lamar",          "id": "S289",          "last_name": "Alexander",          "party": "R",          "state": "TN"       },
I assume this means that the vice president voted on the issue, but is this an appropriate way to represent the data? Everyone else is represented by bioguide/lis identifier keys in an array. If you wanted to look up voting records of years past, you'd have to go out of your way to figure out who the VP was at that time.

I'd be great if you could help by filling in our documentation on the votes output so that we cover this case.

I'm not clear on what you want. Just to make a section about VP? What are your thoughts on including bioguide?

Pence has a Bioguide ID, I think all VPs get them, for this reason: http://bioguide.congress.gov/scripts/biodisplay.pl?index=P000587
We shouldn't be mixing in the string "VP" in an array that is otherwise made of dicts. @GoldenJoe A fix here would be awesome if you're up for making it.

Please no. People are using these files (possibly/hopefully) through GovTrack's bulk data, so I am committed to the data format, until I discontinue the bulk data in the summer.

OK, not my intent to interfere in a working pipeline, though it's a pretty reasonable thing to point out -- would this be reasonable as a TODO once the bulk data is retired?

Sure.
On March 18, 2017 7:55:50 PM EDT, Eric Mill<EMAIL_ADDRESS>wrote:

OK, not my intent to interfere in a working pipeline, though it's a
pretty reasonable thing to point out -- would this be reasonable as a
TODO once the bulk data is retired?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/unitedstates/congress/issues/204#issuecomment-287583824

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


ToSchema on an enum with  docstring-prefaced tuple variant containing an Option as the first element of the tuple does not produce a description

Creating an enum with a tuple variant that contains an Option as the first element does not produce a description for that variant despite being prefaced with a docstring and deriving from ToSchema.
Here are 2 examples and their corresponding openapi json output to reproduce the issue:
/// top level doc for My enum
#[derive(ToSchema)]
pub enum MyEnum {
            /// doc for tuple variant with Option as first element - I do not produce a description
            TupleVariantWithOptionFirst(Option<String>),

            /// doc for tuple variant without Option as first element - I produce a description
            TupleVariantWithNoOption(String),
}

produces:
      "MyEnum": {
        "oneOf": [
          {
            "type": "object",
            "required": [
              "TupleVariantWithOptionFirst"
            ],
            "properties": {
              "TupleVariantWithOptionFirst": {
                "type": "string",
                "nullable": true
              }
            }
          },
          {
            "type": "object",
            "required": [
              "TupleVariantWithNoOption"
            ],
            "properties": {
              "TupleVariantWithNoOption": {
                "type": "string",
                "description": "doc for tuple variant without Option as first element - I produce a description"
              }
            }
          }
        ],
        "description": "top level doc for My enum"
      },

/// top level doc for My enum
#[derive(ToSchema)]
pub enum MyEnum {
            /// doc for tuple variant with Option as first element - I do not produce a description
            TupleVariantWithOptionFirst(Option<String>, String),

            /// doc for tuple variant without Option as first element - I produce a description
            TupleVariantWithOptionSecond(String, Option<String>),
}

produces:
      "MyEnum": {
        "oneOf": [
          {
            "type": "object",
            "required": [
              "TupleVariantWithOptionFirst"
            ],
            "properties": {
              "TupleVariantWithOptionFirst": {
                "type": "array",
                "items": {
                  "type": "object"
                },
                "maxItems": 2,
                "minItems": 2
              }
            }
          },
          {
            "type": "object",
            "required": [
              "TupleVariantWithOptionSecond"
            ],
            "properties": {
              "TupleVariantWithOptionSecond": {
                "type": "array",
                "items": {
                  "type": "object",
                  "description": "doc for tuple variant without Option as first element - I produce a description"
                },
                "maxItems": 2,
                "minItems": 2
              }
            }
          }
        ],
        "description": "top level doc for My enum"
      },

Most probalby related to the previous one #679. The enums are quite complex in general which is one factor for the missing functionality.

@lithiumFlower I assume that this is also closed due to merge.

Yes!


MINOR: migrate ListConsumerGroupTest to use ClusterTestExtensions

By using ClusterTestExtensions, ListConsumerGroupTest get get away from KafkaServerTestHarness dependency.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Rely on https://github.com/apache/kafka/pull/15766.

Hi @chia7712, I rebase latest trunk branch, so we have ConsumerGroupCommandTestUtils now. The only remaining part is SimpleConsumerGroupExecutor. This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I think we can create a new class SimpleConsumerGroupExecutorTestUtils for it. WDYT? Thank you.
https://github.com/apache/kafka/blob/21bf715622e9d05984fa8a2a1f9f12d54b76ce41/tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTest.java#L327-L335

This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I think we can create a new class SimpleConsumerGroupExecutorTestUtils for it. WDYT? Thank you.

That is addressed already. see
https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java#L92

This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I think we can create a new class SimpleConsumerGroupExecutorTestUtils for it. WDYT? Thank you.

That is addressed already. see https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java#L92

Thanks. The SimpleConsumerGroupExecutor  subscribe topic partitions. I have updated ConsumerGroupCommandTestUtils to support it.
https://github.com/apache/kafka/blob/f4fdaa702a2e718bdb44b9c5fec254f32a33f0d8/tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTest.java#L274-L287

@FrankYang0529 please rebase code to include https://github.com/apache/kafka/commit/334d5d58bb73ca04d04be90dec8c4e49000577ec

The CI is finished and failed test cases are not related to this PR.
MirrorConnectorsIntegrationSSLTest.testReplicateSourceDefault: https://issues.apache.org/jira/browse/KAFKA-15927
ReplicationQuotasTest.shouldThrottleOldSegments: https://issues.apache.org/jira/browse/KAFKA-16635
ConsumerBounceTest.testConsumptionWithBrokerFailures: https://issues.apache.org/jira/browse/KAFKA-15146
DelegationTokenEndToEndAuthorizationWithOwnerTest: https://issues.apache.org/jira/browse/KAFKA-15411
QuorumControllerMetricsIntegrationTest.testTimeoutMetrics: https://issues.apache.org/jira/browse/KAFKA-16173

@FrankYang0529 Could you please merge ListConsumerGroupUnitTest into ListConsumerGroupTest? Multi classes in single class file is not common in code base


<EMAIL_ADDRESS>detects code as React

Bug: storybook/vue uses React code
I am using<EMAIL_ADDRESS>with<EMAIL_ADDRESS>and although the Storybooks compile fine, the error seems to be for React code
Uncaught TypeError: Cannot set property 'textContent' of null
    at showErrorDisplay (start.js:89)
    at showException (start.js:109)
    at renderUI (start.js:216)
    at Object.dispatch (redux.js:221)
    at ConfigApi._renderError (config_api.js:101)
    at render (config_api.js:48)
    at ConfigApi.configure (config_api.js:67)
    at Module.<anonymous> (config.js:16)
    at Module.J6/m (preview.bundle.js:907)
    at __webpack_require__ (bootstrap:779)
invariant.js:42 Uncaught Error: Target container is not a DOM element.
    at invariant (invariant.js:42)
    at legacyRenderSubtreeIntoContainer (react-dom.development.js:17238)
    at Object.render (react-dom.development.js:17317)
    at push.xduG.exports.default (routes.js:41)
    at App.init (app.js:119)
    at push.dVls.exports.default (index.js:41)
    at Object.B9hg (index.js:16)
    at __webpack_require__ (bootstrap:779)
    at fn (bootstrap:147)
    at Object.4 (bootstrap:855)

Steps to reproduce

Use<EMAIL_ADDRESS>with<EMAIL_ADDRESS>Create a simple storybook with contents below

storybook/config.js
import { configure } from '@storybook/vue'

import Vue from 'vue'
import VueMaterial from 'vue-material'

import Login from '@/components/Login'

Vue.use(VueMaterial)
Vue.component('login', Login)

function loadStories() {
  // You can require as many stories as you need.
  require('../src/stories');
}

configure(loadStories, module);

.storybook/index.js
import Vue from 'vue'
import VueMaterial from 'vue-material'

import { storiesOf } from '@storybook/vue'
import { linkTo } from '../../.storybook/addons'

import 'vue-material/dist/vue-material.min.css'
import 'vue-material/dist/theme/default.css'
import<EMAIL_ADDRESS>import App from '@/App'
import Login from '@/components/Login'
import Welcome from './Welcome'
// import MainScreen from '../MainScreen'

Vue.use(VueMaterial)

storiesOf('Welcome', module).add('to Storybook', () => ({
  components: { App, Welcome },
  template: '<welcome :showApp="action" />',
  methods: { action: linkTo('Login') },
}))
storiesOf('Login', module)
  .add('story as a template', () => '<login>Login as a function template</login>')
  .add('story as a component', () => ({
    components: { App, Login },
    template: '<login>Login stuff here</login>',
  }))

All the relevant files have been uploaded to https://gist.github.com/hanxue/6647a4c1fa8e30998df2b9cead4e63d4
Affected platforms
OS: MacOS 10.10.5
Browser: Chrome 69.0.3451.0
Storybook<EMAIL_ADDRESS>

I'm running into the same issue with React. The expected dom elements from the error overlay are missing in the dom.

@marvinhagemeister what version of storybook are you using?


Error Running App

Hello,
My GamkersGPT app is not running. It saying Error Running App. So please fix this problem.
Thank You.

We are pleased to inform you that the issue has been resolved. You can now continue to use our application as usual. Thank you for bringing this to our attention