Add proper timezone suport

When some pages have dates without timezones, and some with timezones, the page ordering looks incorrect. The pages with only dates, or dates+times get interpreted as UTC times. This can cause a page with date = "2016-02-18T20:00:00-05:00" to appear as a later post than a page with date = "2016-02-19".
If you understand what's happening under the hood, you can see why, but for a non-developer, or even one that doesn't understand this specific implementation quirk, that posts to inexplicably appear in an incorrect order. Intuitively, 2016-02-19 would refer to a date, not specifically midnight on that date in England.
The library that hugo uses to parse dates (spf13/cast) will parse these date formats that don't include a timezone:

2006-01-02T15:04:05
Mon Jan _2 15:04:05 2006
2006-01-02 (This one is what a user would get if they manually cut off the time portion of the date. That's how I stumbled on this issue.)
02 Jan 2006

There are probably a few ways to make the behavior more friendly. I don't have an opinion on these, I'm just throwing out suggestions:

When parsing pages, detect date values that did not include a timezone and explicitly put them into the local timezone of the user, maybe with a user-configurable site-wide default timezone.
When parsing pages, if there are only two timezones across all pages: UTC + a non-UTC timezone, convert all the UTC dates to that other timezone. Possibly include a config setting to disable this behavior.
Throw an error if a timezone is not explicitly stated in a date value.
When a page is created with the hugo tool, insert a date without a timezone, so that it will also end up in UTC, like a date entered manually by the user without a timezone. (This would be a half-measure, since any pages created with an older version of hugo would have timezones, as well as any dates manually entered with timezones by the user. Although, for going forward, it would mitigate the quirks that might results from the other solutions.)

When parsing pages, detect date values that did not include a timezone and explicitly put them into the local timezone of the user, maybe with a user-configurable site-wide default timezone.

I think this is the best solution to this.

I'm not sure where this needs to happen (spf13/cast?), but we can use time.ParseInLocation.  It respects timezone info if it's in the string, but you can pass in a default.  We can use time.Local as the default.
http://play.golang.org/p/nIHv0ilLwS

@moorereason we need to have a specified timezone in config (and maybe also as overriden in the page front matter). Once we have this we can say:

If timzeone set in the datetime string: fine, use that
If timezone set in config (or in page frontmatter), use that
Else use UTC (or maybe the timezone used in Norway :-))

We should probably extend cast with another method to solve this, but the current method is a little bit of a convenience method.

That's what I was thinking, too, but I'm more concerned with how we customize the unmarshaler.  BurntSushi/toml can do that, but I don't know about YAML, and JSON.

I had started a change for this in spf13/cast, but I haven't had time to wrap it up & submit a PR. I'll try to get that done Sunday or Monday. There are a few issues with using time.ParseInLocation. I'll bring those up in that PR, plus tests to validate correct behavior.
On the hugo side, @bep, 1 & 2 in your sequence sound reasonable. What do you think of using local timezone in step 3, though? I wonder what portion of Hugo users explicitly want times for their blog posts to be UTC, and of that small group of people, how many of them aren't already listing date values with timezones.
Another benefit of defaulting to local (when no explicit timezone), is that the hugo tool generates pages with local times. So if a user overrides just one of those pages to a a time without a zone, then hugo defaulting to local timezone would keep that page's time consistent with all the other ones.

So if a user overrides just one of those pages to a a time without a zone, then hugo defaulting to local timezone would keep that page's time consistent with all the other ones.

Yes, that makes sense.

This issue has been automatically marked as stale because it has not been commented on for at least four months.
The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still valuable, please open a proposal at https://discuss.gohugo.io/.
This issue will automatically be closed in four months if no further activity occurs. Thank you for all your contributions.

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.
If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

So, we have https://github.com/spf13/cast/pull/80 which I have tested and that makes sense to me. But when I started to implement this in Hugo I figured out I have no idea how.

For dates as strings it works fine
But for dates that are detected as time.Time I'm clueless
All decoders support some variation of TextUnmarshaler interfaces etc., but I have no idea how to do that with a dynamic map schema. Even if we had fixed structs for all, there is a problem with where to store the location.

If anyone smarter than me could come up with something that works, I would be happy camper.

Hey @bep. Wondering if it would be possible to include this functionality? I noticed there were a few small template sample mockups on the forums.
Need capability to show a specific RFC timestamp in a specific timezone. So effectively --> toTimezone().

@virgofx,
The scope of this issue is larger than what I think you're asking for.  It sounds like you are interested in additional template functions under the time namespace (godocs).  If so, I'd recommend opening a separate issue.

You're right. Proper TZ support likely includes a lot more. I'd love additional output formatting options. I'll open up another PR.

@heewa The latest PR which added Timezone/Location support to the time function should resolve your issue in the next release. I realize it's not "full timezone" support but I think it would help. Full Timezone support could be a very very large task and I'm thinking that if the latest merged PR fixes your issue and mine ... it would suffice for this project and we could close this.
Thoughts?

it would suffice for this project and we could close this.

This is still needed.

My local timezone is CET (one hour ahead of Greenwich). I noticed a page I'm writing stopped generating after I updated some metadata. After some troubleshooting, I noticed it was because I updated the date parameter.
https://github.com/gohugoio/hugo/blob/04b89857e104ac7dcbf9fc65d8d4f1a1178123e6/hugolib/site.go#L1836-L1848
I was trying to come up with a fix and found this task.
What I had in mind involved making sure that when Date, PublishDate, and ExpiryDate are parsed, they are parsed in the local time. Alternatively, changing time.Now() to a new time created in UTC and truncating to 24 * time.Hour might do it, but now it seems wrong to me.
I'm also not sure whether dates are supposed to contain times too or whether we could check if the lower bits (hour, minutes, seconds...) are 0s.
Any thoughts?

This was addressed with https://github.com/gohugoio/hugo/commit/efa5760db5ef39ae084bfccb5b8f756c7b117a2a by adding a timeZone option to site configuration and an optional TIMEZONE argument to the time.AsTime template function.


Skip typecasting for date-related types in driver config

This resolves #58 by configuring Postgres/MySQL drivers to skip converting date/time values to js date times because that conversion can cause confusion. This kind of coercion may be convenient for applications, but for a db frontend such information extrapolation is undesirable.
The SQLite driver doesn't seem to be performing a coercion by default. I can not test for MSSQL so haven't touched that.

Just tested this and it works great. Merging as-is. Thank you!


Visual Studio Code Insiders Not updating hence some extensions not working optimally.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  14
OS Version:  Windows 11 insiders

Steps to Reproduce:

Have a user-type installation of VS Code

Check for updates

See (1) badge on gearwheel

Use its "Install Update... (1)" option.

Receive a UAC dialog and approve it.

See a VS Code notification.

Click "Update Now"

VS Code Insiders closes and an error messagebox appears:

Maybe https://github.com/microsoft/vscode/issues/220999

I got a solution to fix this.


Are we confusing bed files and target files?

There seem to be some areas of the code that use BED files (e.g. NormalizeSomaticReadCounts) and others that do not ...  Is this being consistent across the tools?

Currently the only place we are really force to use a BED is when we need to use as an interval file -L in GATKtools, otherwise I think the tab-table format with headers is preferable and we should move to use that all the time.
I think at some point I discussed with @droazen that it would be nice to be able to use any feature/locatable containing file a as interval file but I don't think it was considered priority at the time and I guess is not there yet.

This is mostly addressed, with the exception of AnnotateTargets (see #645).


Different settings for posts and pages?

Would there be a possibility to have separate settings for post and pages? E.g. for posts I'd like to publish excerpt, but pages don't have one, so I need to publish full content.

@YuriGal the plugin auto-generates an excerpt for posts if you use that setting.

I would avoid different settings for the moment, because it adds lot's of complexity and there are still a lot of loose ends. But that does not mean that it will never be possible.

besides of that, it is a duplicate to #270


Remove .i18nrc.json as OSD do not bundle it anymore

Description
Remove .i18nrc.json as OSD do not bundle it anymore
Issues Resolved
Closes https://github.com/opensearch-project/opensearch-build/issues/5099
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Processing files: opensearch-dashboards-2.18.0-1.x86_64
Provides: opensearch-dashboards = 2.18.0-1 opensearch-dashboards(x86-64) = 2.18.0-1
Requires(interp): /bin/sh /bin/sh /bin/sh
Requires(rpmlib): rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1
Requires(pre): /bin/sh
Requires(post): /bin/sh
Requires(preun): /bin/sh
Checking for unpackaged file(s): /usr/lib/rpm/check-files /tmp/tmp_n0m0s7y/BUILDROOT/opensearch-dashboards-2.18.0-1.x86_64
Wrote: /tmp/tmp_n0m0s7y/RPMS/x86_64/opensearch-dashboards-2.18.0-1.x86_64.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.XSf6ai
+ umask 022
+ cd /tmp/tmp_n0m0s7y/BUILD
+ /usr/bin/rm -rf /tmp/tmp_n0m0s7y/BUILDROOT/opensearch-dashboards-2.18.0-1.x86_64
+ exit 0
2024-10-16 19:01:39 INFO     Published /local/home/zhujiaxi/opensearch-build-peterzhuamazon/rpm/dist/opensearch-dashboards/opensearch-dashboards-2.18.0-linux-x64.rpm.
2024-10-16 19:01:39 INFO     Removing /tmp/tmp_n0m0s7y
2024-10-16 19:01:42 INFO     Done.

Hi @gaiksaya are we good to approve this PR?
Thanks.


No entities shown in integration information

Followed the guideline but after adding the integration it stays "empty" and shows no entities:

As you can see the car was identified correctly so I assume that there was some initial communication with the servers.
[EDITED COMMENT]

I have the same issue no entities after adding intergration

@rchiileea
I just checked it again and the entities are in HA

They are just not shown under Tronity integration.

@hanno-tronity
I will give you an example and explain the confusion from above.
Therefore I sample selected another integration and will try to mirror it to the Tronity one:

Underlined in red you see one (or more) device(s). For Tronity this would probably be the vehicle id ...
Underlined in yellow you see the entities associated to the device(s). For Tronity this would be the entities like odometer, battery level and so on.
Should possibly also be aligned with https://github.com/tronity/homeassistant/issues/4

yes unique Ids are quite important as it will allow enduser to customise things in the ui (like km to mi, or feet, or yards etc)

I have added unique IDs to all sensors in the repository which will now allow you to change settings for each sensor in the UI as per your preference. Additionally, you can now find all the sensors listed in the entity tab.


Issue with hmac token validator

hello,
I have identified an issue with the current base code of pac4j-oicd.
The provider i am currently trying to interface with (france connect) only support HS256 for token signing.
So we have this code in OidcProfileCreator which check the metadata config and intends to instanciate an idTokenValidator accordingly :
else if (CommonHelper.isNotBlank(configuration.getSecret()) && (jwsAlgorithm == JWSAlgorithm.HS256 || jwsAlgorithm == JWSAlgorithm.HS384 || jwsAlgorithm == JWSAlgorithm.HS512)) {
this.idTokenValidator = createHMACTokenValidator(jwsAlgorithm, _clientID, _secret);
}
The problem here is that the test jwsAlgorithm == JWSAlgorithm.HS256 fails as the instance of JWSAlgorithm doesn't match the static one, and so we end with an invalid idTokenValidator.
Indeed the jwsAlgorithm is instanciated in nimbus as new JWSAlgorithm("HS256").
see com.nimbusds.openid.connect.sdk.op.OICDProviderMetadata>>parse().
I will open an issue on this library as i don't know why the helper JWSAlgorithm.parse() is not used in this case. Of course if it was used instead the above test would be successful.
The alternative would be of course to implements the check in a different way, aka comparing the name field.
André

The guys from Nimbus are fairly reactive. So contact them and ask for a fix, they should be able to provide a release very soon. If they don't, we'll fix it on our side.
Keep us posted.

Yes, that's what i did. For the record, here is the link to the bug report i opened today regarding this subject : https://bitbucket.org/andre_doherty/oauth-2.0-sdk-with-openid-connect-extensions/issues/1/oidcprovidermetadata-doesnt-make-use-of

Great! Thanks

Hello,
They are indeed very reactive.
The issue has been fixed and is embedded in version 5.24.2
With mention :

The recommended comparison is with .equals

OK. Would you mind submitting a PR to upgrade the version and use equals? Thanks

Sure no pb


WIP Control show widget

Note that this needs updated version of SDK, and is currently opened just for testing

Hey @izri16 ! Could we get in touch over discord? Would be nice if we discuss about this update. My username is sourabh.


Add some additional asserts in utils::from_plan

Which issue does this PR close?
Re: https://github.com/apache/arrow-datafusion/issues/917
Rationale for this change
https://github.com/apache/arrow-datafusion/issues/917 was due to mishandling a newly added LogicalPlan node in utils::from_plan
What changes are included in this PR?

Make it harder to introduce such bugs in the future by adding asserts

Are there any user-facing changes?
no

fyi @Dandandan

👍


Add "Acceptance Tests - MTA" to branch protection checks

This pull request includes a small change to the org/branchprotection.yml file. The change adds a new test to the branch protection rules.

org/branchprotection.yml: Added "Acceptance Tests - MTA" to the list of required status checks

@Gerg @stephanme : Could you please approve and merge this? Thank you!


Icon Request: timeline

Icon name
timeline
Use cases
timeline icon could represent this use cases:
list of generic events chronologically organized or not:

list of organized steps / actions
list of article entries
list of shows of an event
chronological historical events

Design ideas
Material Example:

Font Awesome Example:

Checklist

[X] I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
[X] I have searched existing icons to make sure it does not already exist and I didn't find any.
[X] I am not requesting a brand logo and the art is not protected by copyright.
[X] I am not requesting an icon that includes religious, political imagery or hate symbols.
[X] I have provided appropriate use cases for the icon(s) requested.

We have square-chart-gantt which is quite similar to the suggested icon Material View Timeline.


Flashing with user provided firmware

Was it ever considered to allow the user to provide a firmware binary instead of the application providing a manifest with fixed binaries? Similar to how the user can provide a custom firmware on https://web.esphome.io
That would make the esp-web-tools button more useful for more generic use-cases in addition to installing specific firmware binaries.
Context: I am building a web interface for interacting and controlling generic ESPHome devices using the web_server API. I'd love to add the ability to flash firmware and provision WIFI to that interface, too. Obviously I could just use esp-tool and improv-wifi-sdk directly, but why reinvent the whole wheel, just because one spoke I'd like to have is missing?
Is this something that the project was willing to take a pull request on?

That's not something we would consider.
I would consider a contribution that allows to specify manifest contents directly on the button. That way you could generate a manifest on the fly that references a selected firmware.

Thanks for the response. That's obviously not, what I was hoping for :-/
Let me think about your proposal a little. To make sure I understood correctly what your are suggesting: when you say a generated manifest could reference a selected firmware, then how should I think about this? is the following flow roughly what you imagined in this case?

User selects a firmware using an application provided <input type="file" /> dialog.
A object URL for the selected file is generated using URL.createObjectURL
A manifest is generated using the firmwares generated object URL in it's builds element's path.
The generated manifest is assigned to <esp-web-install-button />
The <esp-web-install-button /> is triggered offering the firmware for installation.

The main difference here -- at least from a user flow perspective -- would be that the firmware file would have to be selected prior to initiating the <esp-web-install-button /> flow, rather than as part of it.
Did I get this correctly?

Yeah, that was along the lines that I was thinking.

I spent some more time about this some more. I'm not convinced this will allow me to fully implement what I am hoping to do. The user story outlined above would work and be reasonable. However, I would also like to provide the user the ability to provision Wi-Fi on any MCU already supporting Improv Serial. And I think this solution would still not reasonably allow this. Let me explain.
If I was going to provide Wi-Fi provisioning through ESP Web Tools using the same flow as above, then the user would have to select a firmware binary file in the first step. Given the user story of provisioning Wi-Fi they may not have a firmware binary and they probably have no intention to actually flash it anyway.
In theory at least one could provide a dummy firmware binary when the user opts the provision Wi-Fi flow from the application (e.g. URL.createObjectURL(new Blob([]))). However, then we'd run into problems when the user chooses the "Install firmware' option in the ESP Web Tools dialog. It would now proceed to flash an empty or some other dummy firmware onto the MCU, which is almost certainly not what the user intended.
Given that this user story is critical for my use-case I'm not sure if the dynamic manifest solution will work for me. Do you have any more ideas or thoughts on this?
I'd also like to better understand what your specific objections are to expanding the ESP Web Tools install button by an option to provide a user supplied firmware binary. Maybe I can think of a way to solve for your specific objections while still supporting the user stories I am imagining.
I'll also outline in some more detail how I was imagining the flow to work within ESP Web Tools, both from the users perspective, as well as from a technical perspective. Just to make sure there are no misunderstandings.
User story:

User connects an unflashed MCU via USB
User clicks ESP Web Tools install button
"Connecting" dialog shows
"Device dashboard" dialog shows with options "Install firmware" and "Logs & Console"
User clicks "Install firmware", which triggers a file selection dialog.
User selects a firmware binary to flash that implements Improv Serial
"Confirm Installation" dialog shows
User selects "Install"
"Installing" dialog shows and flashes the user provided binary file to the connected MCU
"Installation complete" dialog shows
User selects "Next"
"Configure Wi-Fi" dialog shows
User inputs their Wi-Fi credentials and clicks "Connect"
"Device connected" dialog shows, offering the user to "Visit Device" or "Skip"
User selects "Skip"
"Device dashboard" dialog shows, this time with the options "Install firmware", "Visit Device", "Change Wi-Fi" and "Logs & Console".
User clicks the "x" to close the Device dashboard

From a technical perspective it could work as follows:

The user provided firmware binary is an option that needs to be explicitly opted into by the application and is exclusive to the manifest provided binaries (i.e. you can't have both). A dedicated attribute on the button (e.g. usefiledialog="true") might be a good way for the application to express this opt-in.
All the current fields in the manifest become superfluous for this flow and no manifest needs to be provided by the application with the ESP Web Tools install button in this mode.
Internally, just a couple of changes seem to be necessary:
3.1. With the file dialog opt-in enabled, a dummy manifest is generated internally. It sets reasonable defaults, like "name" to "firmware" and "version" to an empty string. Since ESP Web Tools won't be able to determine if firmware without Improv Serial support is already installed on the device or if a supplied firmware binary is the same or updated version of the one running on the device it is probably advisable to set "new_install_prompt_erase" to true. The "builds" array remains empty. No other fields are set.
3.2. With the field dialog opt-in enabled, checkFirmwareSame is not called. ESP-Web-Tools would assume the firmware to always not be the same.
3.3 During flashing, if the build array is empty, instead a of sending a request to a part URL to generate a blob entry in the file array, a <input type="file" /> dialog is generated and a Promise for it's result added to the file array instead. If a file gets selected by the user, the Promise is resolved. If the dialog gets closed without a file selected the Promise gets rejected.

It seems like these three changes are the only ones necessary to support this flow. Note that this specific implementation is just a suggestion. I care more about the user story than the technical details. A couple of additional points about the technical details that are worth mentioning:

I've chosen the technical implementation requiring the generally least amount of changes in the code base rather than the one that is the most explicit. E.g. instead of generating a dummy Manifest, it might make sense to be more explicit about this alternative flow within the code.
In theory it's possible to have the application provide the dummy manifest with an empty builds list instead of an explicit opt-in, keeping the API surface smaller. It seemed to me that on the API level this opt-in should be more explicit though.
If the file dialog gets cancelled and no file selected, the resulting error screen will talk about a failed firmware download. This is probably confusing for the user. Also see my next point.
It is probably advisable to trigger the file dialog more directly from the click on "Install firmware" instead of from within the flash process and provide the resulting Blob/File to the flashing process instead. While this will require some more changes in more locations, it would avoid the above failed download problem and would allow one to simply not start the flashing process at all if the user cancels out of the file selection process.

Thanks! I appreciate the thought and time you are putting into this.

Any more or additional thoughts on this?
It's something I need for my project and it appears it might be useful for other projects, too. I'd love to provide an upstream patch that enables this workflow cleanly rather than having to fork, cobble together some wonky workaround or rebuild large parts of esp-web-tools-install button functionality from scratch.
But if none of my arguments have been convincing or helpful, let me know and I'll move on.

I don't think we should adopt this in ESP Web Tools. It's really made for ready-made firmware. Once you want to allow selecting different firmwares, it becomes a different focus. Just like we did for ESPHome Web, I suggest that you create your own application using esptool-js.

That's fair. Thank you!

@DanielBaulig I made a fork of esp-web-tools for project Tasmota. One reason was to provide flashing of user provided firmware (needs to be one file "factory image")
You find the fork here
Running in action https://tasmota.github.io/install/

@Jason2866 Thank you! I'll check it out.
I have started building out my own implementation based on Improv Serial SDK and esptool for now. Being able to roll a completely custom UI does come with some useful benefits.


The filter 'block' doesn't filter the events on the 'Event'/'Home' page

Date Time
29-11-2020 16:36
Priority
High
Description
By the requirements when the radio button "Blocked" is selected only events that have been blocked and marked in yellow are displayed.
When the radio button "Blocked" is selected in the filter on the 'Home'/'Event/ page the error message is displayed.
Pre-conditions
Steps to be fulfilled before test:
Move to https://eventsexpress-test.azurewebsites.net/home/events?page=1&status=active
Login like an admin user
Steps to Reproduce
Steps to reproduce the behavior:

Select the "Blocked" button and click on the 'Serch' button

Expected result
Only events that have been blocked and marked in yellow are displayed
Actual result
the error message appears '403!-Forbidden'
Screenshots

Environment:
windows 10 corporate (64 bit)
Google Chrome
87.0.4280.66 (64 bit)
Additional context
Test https://github.com/EventsExpress-SoftServe/EventsExpress/issues/264

@ElenaMelnyk , I couldn't reproduce this one. Could you check one more time is it still occurce for you?


Convert to PDF

Any plans on being able to clone the repo and building a PDF out of it?

Possibly in the future, but in the current state it's not really ready to be "publishable" and I don't foresee myself having time in the near future to get it to that state.

Does this means that the resourses need to be made as a pdf with good design but with the content provided??


Remove Scope OnPrem codeunit 12173 "Vendor Bill List - Post"

In order to be able to change target to cloud, please remove the scope OnPrem from the following functions:
[Scope('OnPrem')]
procedure PostTax(VendorBillHeader: Record "Vendor Bill Header"; VendorBillLine: Record "Vendor Bill Line"; VendorBillWithholdingTax: Record "Vendor Bill Withholding Tax"; VendLedgEntry: Record "Vendor Ledger Entry"; Bill: Record Bill; Tax: Option " ",Withhold,"Free Lance",Company)
codeunit 12173 "Vendor Bill List - Post"

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10836.


ConfigurationSets are null when I retrive the Azure VM password via Management Library API

I try to use Azure Management Library API to read Virtual Machine information, the following is my code.
var vmClient = CloudContext.Clients.CreateComputeManagementClient(cer);
var mymachine=    vmClient.VirtualMachines.Get("javmtest", "javmtest", "javmtest");
We can find AdminPassword in ConfigurationSets: https://msdn.microsoft.com/en-us/library/microsoft.windowsazure.management.compute.models.configurationset_members(v=azure.11).aspx, However the AdminPassword and AdminUserName in ConfigurationSets are always null, I couldn't get this infoformation, Can we get the Azure VM AdminPassword via Management Library API?

Admin password is not returned from the platform


When real rsamples is smaller than 10K, does the metric still produce a reliable score?

Hi, thanks for sharing the great work!
I would like to use this metric to evaluate the results in the image-to-image translation task. However, in I2I datasets, the number of real samples are always less than 10K, and most of them are around 1k. In this case, does the metric still produce a reliable score? Can I directly use this metric?
Looking forward to your reply, thanks a lot!

Thank you for your interest in our work 👍
We did a bit of analysis around this for real==fake case, when the D&C metrics should give values close to 1.0.

Coverage is very stable against #samples. The problem is Density's sensitivity to #samples. However, even for Density, I would say 1k samples already give stable result (low variance around the mean 1.0).
So my answer to your question is a reserved yes. Please go ahead with 1k samples, but keep in mind that the metrics are based on samples and are therefore not completely free from the sample variance.

Thanks for your quick response and it helps me a lot!

Hi, I use this metric and P&R to compare several generative models. I find:

Although FID_A < FID_B, however, the coverage and density of B is better than A.
Also, I find the tendency of P&R and C&D is not consistent. For example, recall is smaller. However, the coverage score is larger.(This is not the outlier case that the paper reported)
when I choose different K. The tendency of coverage and density among these models will change. For example, when I choose K=3, C_A is much better than other methods. However, K=5, C_A is the worst. Moreover, in the conditional setting, not only P&R and C&D seem not very consistent with FID. Namely, there are always many cases that FID is good. However, C&D is worse.
Do you have some experience about that?

Yes, we also have experienced certain inconsistencies in the model rankings for different metrics, and I personally do understand your pain. Unfortunately, there is no quick solution to the problems you are having - I should say they are deeply rooted in the difficulty of evaluating generative models.
Maybe you have already thought about this, but let's probably think a bit about how to judge whether an evaluation metric is doing the right job. It's not so easy ;) I believe there are two ways.

The metric is by definition what we want. For example, the accuracy metric is defined as the proportion of the correct predictions among all predictions made. This metric, by definition, is the exact representation of what humans generally want from a model. However, it is not always easy to build such a fully "interpretable" evaluation metric - e.g. building an evaluation metric for generative models. How do you algorithmically quantify the fidelity and diversity? There is no easy way. Thus, we and previous researchers have come up with proxies like CNN embeddings and KDE-like density estimators. But among many proxy metrics, how do we judge if metric A is better than metric B? This question leads to the second way of "evaluating an evaluation metric".

Build a few test cases where you know how the metrics should behave & see if the metrics pass this test. This is the method we adopted in our paper - with a handful of test cases where FID and P&R fail while D&C thrive. We cannot say that we have covered all meaningful test cases for evaluating generative models, but we did our best to cover them all, seeking advice from researchers who have been working with generative models for years. And yet, it is very much likely that D&C still fails in certain cases - we hope future researchers will find them out and propose improved metrics.

In this context, we can only say D&C are remedying key shortcomings of FID and P&R, rather than saying that D&C are the evaluation metrics to be used.
For your problem cases 1 and 2, we can't say if D&C are failing because they may be rectifying the wrong evaluation results given by FID or P&R. They are not the "test cases" as in point 2 above where the desired metric values or rankings are present. They are intriguing inconsistencies but are inconclusive of which metrics are doing the right job.
For problem case 3, the ranking's dependence on K is definitely a shortcoming for D&C. It is unfortunate, but partly expected because there is no guarantee that D&C are perfect metrics.
Sorry that my answers do not really solve any of your issues. But I can tell you that we have the same kind of issues, and they are deeply rooted in the inherent difficulty of evaluating generative models.

Thanks for your detailed reply :)
Yes, you are right. It is really suffered when I try to use all the metrics to evaluate the models and find inconsistency results since I cannot draw any conclusions from the results.
But just as you say, evaluating the generative models is indeed a difficulty without any GT to evaluate the metric itself.
Thanks again for the discussions 👍


Dataset.from_generator doesn't support strings

I have hit the same problem described in https://stackoverflow.com/questions/47705684/tesnorflow-dataset-generator-does-not-work-with-strings
I think it is a missing feature instead of a bug?

This bug was fixed in https://github.com/tensorflow/tensorflow/commit/17ba3a69f4c3509711a3da5eff3cb6be99e0936d but hasn't yet made its way into a release. I posted a workaround on the Stack Overflow question.


image: Make image encoding methods consistent across JPG, GIF, and PNG

Greetings.
As far as I can tell, Go currently supports encoding an image.Image into 3 image file formats; JPEG, GIF and PNG.
Each format has its own encode method. Both jpeg.Encode and gif.Encode are fairly similar but with different Options structs (jpeg.Options, gif.Options). However png.Encode does not have an Options requirement in its method signature. png.Encode actually uses a separate struct, png.Encoder, which has an Encode method on it, so png.Encode is really just calling png.Encoder.Encode.
Problem
There is no uniform way to encode an image.Image. Also encoding is done in the various sub-packages (image/jpeg, image/gif, image/png) while decoding is done in the image package, so two inverse functions don't exist on the same package levels.
Proposal
I propose that the GIF and JPEG packages be done the same way as PNG, and that an interface be created; image.FormatEncoder, which would wrap all of the _.Encoder.Encode methods. Then an image.Encode(w io.Writer, m Image, enc FormatEncoder) error function be added. See below for my suggested changes to the image packages.
//package "image/jpeg"
type Encoder struct {
    Quality int
}

func (enc *Encoder) Encode(w io.Writer, m Image) error {
    //Do encoding
}

//package "image/gif"
type Encoder struct {
    NumColors int
    Quantizer draw.Quantizer
    Drawer draw.Drawer
}

func (enc *Encoder) Encode(w io.Writer, m Image) error {
    //Do encoding
}

//package "image"
type FormatEncoder interface {
    Encode(io.Writer, Image) error
}

func Encode(w io.Writer, m Image, enc *FormatEncoder) error {
    return enc.Encode(w, m)
}

Notes
If you look at the _.Encoder structs for gif and jpeg, they have the same properties as the old _.Options structs used by the old Encode functions.
Consequences
png.Encode, gif.Encode, gif.Options, jpeg.Encode, and jpep.Options would become deprecated in favor of using image.Encode and passing in the relevant encoder struct.
Any explicit encoding would need to invoke the relevant Encoder struct to call the Encode method on it (it's not a single function call anymore).
Next Steps
I have most of these changes already finished. I need to write a few tests to verify things work as expected, and wanted to get sign off before proceeding further.

CC @nigeltao

Note that we can't deprecate the existing APIs. They're protected by our compatibility promise. So these new APIs would need to be introduced alongside the existing ones.

There is no uniform way to encode an image.Image.

To me this doesn't seem like sufficient justification for adding more API surface here (which could be more confusing than anything else). People that want and image encoding interface can write the few lines of code to provide one. But I'd be interested to hear what @nigeltao thinks.

I can certainly see the appeal, and I'm not ruling it out, but I'm not overly excited about uniform ways to encode.
The image package (not the image/foo packages) has a Decode function, and the RegisterFormat mechanism, because it's common to want to a decode an image, whether a file on disk or downloaded from the network, without knowing what exact format it is beforehand.
But for encoding, in my experience, you usually know exactly what format to encode in, because there's usually only one. Or if you really need to encode multiple formats, it's not hard to write this in your package main:
if encodePNG {
png.Encode(etc)
} else {
jpeg.Encode(etc)
}
Also, as adg said, if you really want a FormatEncoder interface, it's very easy to do so in your own code, outside of the image packages.
Sure, in hindsight, it might have been nice if the image/* packages' encoding APIs were made consistent before we froze for Go 1.0, but at this point, I don't think there's much net benefit in explicitly deprecating something now.
If we were to introduce a new type, I'd call it image.Encoder instead of image.FormatEncoder, but there's also a related idea of introducing an image.Decoder type or an image.DecodeImage(io.Reader, *image.DecodeImageOptions) function to add options to the decoding process, such as specifying a destination buffer, or a maximum decoded size. There is more discussion on issue #5050. Perhaps there's a larger problem to be solved.
BTW, if you're not already aware of them, there's also BMP, WEBP and TIFF codecs under golang.org/x/image.

Hmm the compatibility promise says "It is intended that programs written to the Go 1 specification will continue to compile and run correctly, unchanged, over the lifetime of that specification." It makes no mention of deprecating functionality, which would still maintain backwards compatibility and thus the promise. PHP is a good example of similar behavior, granted they do remove deprecated functionality after awhile (read several years). I'd assume the same would happen when the Go 2 spec arrives, whenever that is :P
It seems the larger issue to be solved is how do you work with a frozen specification if you're not willing to deprecate things. I'm not sure how to answer that and until it gets sorted out I guess this change is a non-starter.
@nigeltao I was aware of those additional codecs but chose not to address them since they aren't part of core. I suspect it wouldn't be hard to make them match the interface I defined though.

I'm not saying that we can't deprecate the old functions. I'm just saying that, I can appreciate the motivation, but I think that the benefit is marginal.

Alright


Update bundle, cloudwatch, sdk-core, ses, sns, ... to 2.25.16

About this PR
📦 Updates

software.amazon.awssdk:bundle
software.amazon.awssdk:cloudwatch
software.amazon.awssdk:sdk-core
software.amazon.awssdk:ses
software.amazon.awssdk:sns
software.amazon.awssdk:sqs
software.amazon.awssdk:ssm

from 2.25.15 to 2.25.16
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #3145.


Cant find feasible solution with net electric constraint on. (icc =16)

In GitLab by @mn3981 on May 13, 2022, 14:10
There is situations where the net electric constraint icc=16 will cause PROCESS to not be able to find a solution for a given net electric output even though it can find a solution with the same net electric output with icc=16 turned off.
There is also situations where solutions can be found with the constraint on but past the f-value designated by the input (ixc = 25).

I suspect the particular convergence problem identified here was due to failing to use the right iteration variable and also the error (now fixed) in constraint 81, so I will close.


output of logstash metrics filter  does not add up

I am trying to understand the output of the logstash metrics filter . I have provided my config below
input {
  beats {    port => 5044  }
}

filter {
   metrics {
       meter => "documents"
       add_tag => "metric"
        flush_interval => 60
   }
}

output {
        if "metric" in [tags] {
                stdout {
                        codec => line { format => "1m rate| %{@timestamp} | %{[documents][rate_1m]} 5m rate: %{[documents][rate_5m]} ( %{[documents][count]} ) "}
                }
        }
        else
        {
                kafka {
                        topic_id => "topbeat-stage"
                        acks => "all"
                }
        }
}

I am generating a meter event every minute. The output from this config looks like this
1m rate| 2016-01-30T03:04:27.086Z | 94.13383390520174 5m rate:<PHONE_NUMBER>326618 ( 17940 )
1m rate| 2016-01-30T03:05:27.087Z | 88.24968300053821 5m rate:<PHONE_NUMBER>1339105 ( 22269 )
1m rate| 2016-01-30T03:06:27.086Z | 92.38037875508913 5m rate:<PHONE_NUMBER>572322 ( 26665 )
1m rate| 2016-01-30T03:07:27.086Z | 92.34605776997418 5m rate:<PHONE_NUMBER>559306 ( 31230 )

If I take the last row (1m rate| 2016-01-30T03:07:27.086Z | 92.34605776997418 5m rate:<PHONE_NUMBER>559306 ( 31230 ) ), what does it signify.

Does it mean, logstash filter plugin is processing ~92 events in the last minute and 129*5 events in the last 5 min
Is 31230 the total number of events it has processed so far ?
The difference between the doc count for this row(31230) and the doc count for the previous row(26665) is around ~5k . That does not match either the 1 min rate or the 5 min rate. Am i misinterpreting something ?
The problem is that if i try to match these numbers to the number of events added in elastic per minute , they do not add up at all.

This issue was originally posted in elastic discuss channel

Thanks for posting this, and apologies for the delay @biswajit86 . I actually didn't see this myself in one test, but I'll be taking a second look at it soon.

@biswajit86 I'm just starting to look at this plugin for a few things. Glad I came across this as my metrics might be wrong.
My notes from your post

The count is never reset unless specified. There is a clear_interval setting.
The rate is per seconds. Is my calculation wrong? (22269-17940)/60 = 72.15.

To my knowledge, it's a per second rate.. So it's taking an average rate of events per second

1m is taking the number of events in the last minute then dividing by 60

5m is taking the number of events in the last 5 minutes then dividing by 300


README - link to waitlist & getting started guide

expanded opening paragraph to include more gpt info and link to waitlist, set out initial steps for getting started guide 0 2 hero (to be expanded),  cleaned up sections at bottom of doc to avoid redundant info

Looks good - thank you so much!

no problem looking forward to more collaboration on Kaguya in future!


[1.9] Failure to startup due to an absent Optional when loading player data.

Here's the error log,
http://pastebin.com/yCdzEdy1
It appears to not be able to find the world provider for dimension 0, probably due to some changes in the new MultiWorld 1.9 system.

@Zidane Did you say you had this fixed?


[url_launcher] Content-Disposition and Content-Type header link failed.

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...

url ="https://test/index.php"

                              if (await canLaunch(url)) {
                                await launch(
                                    url,
                                );
                              } else {
                                throw 'Could not launch $url';
                              }

in index.php
    header('Content-Length: ' . $filesize);
// header("Content-Type: application/vnd.android.package-archive");
    header("Content-disposition: attachment;filename={$filename}");

    readfile($filename);

Expected results:
Download on Chrome Android without the Content-Type header throw error. so with the Content-Type it work just fine.
But when  i reput the Content-Type chrome display a message like "Be aware the file can damage your phone...".
When in Flutter App i click to open the URL with Content-Type header in place (and with another tabs open), the page do not appear. but when i remove Content-Type header it go to the page but the dowload throw an error.
Actual results:

Logs

\Hi @louia
Can you please provide your flutter doctor -v your flutter run --verbose
Thank you

[√] Flutter (Channel stable, v1.17.3, on Microsoft Windows [version 10.0.18363.778], locale fr-FR)
    • Flutter version 1.17.3 at C:\src\flutter
    • Framework revision b041144f83 (13 days ago), 2020-06-04 09:26:11 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\chovaneck\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.46.0)
    • VS Code at C:\Users\chovaneck\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.11.0

[√] Proxy Configuration
    • HTTP_PROXY is set
    • NO_PROXY is localhost,<IP_ADDRESS>
    • NO_PROXY contains <IP_ADDRESS>
    • NO_PROXY contains localhost

[√] Connected device (1 available)
    • SM G950F • ce09171964933c0903 • android-arm64 • Android 9 (API 28)

Steps to Reproduce

Run flutter create bug.
Update the files as follows: ...

url ="https://test/index.php"

                              if (await canLaunch(url)) {
                                await launch(
                                    url,
                                );
                              } else {
                                throw 'Could not launch $url';
                              }

in index.php
    header('Content-Length: ' . $filesize);
// header("Content-Type: application/vnd.android.package-archive");
    header("Content-disposition: attachment;filename={$filename}");

    readfile($filename);

Expected results:
Download on Chrome Android without the Content-Type header throw error. so with the Content-Type it work just fine.
But when i reput the Content-Type chrome display a message like "Be aware the file can damage your phone...".
When in Flutter App i click to open the URL with Content-Type header in place (and with another tabs open), the page do not appear. but when i remove Content-Type header it go to the page but the dowload throw an error.
Actual results:
Logs

On server side, I added Content-Type: application/octet-stream to bypass this bug, as from MDN https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#applicationoctet-stream, browser will treat http body as attachment.

Your sample code is only code fragments, do it's not clear what the repro steps are here. Can you provide a full working example?
Also, is this platform-specific?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Merge current into next

Whoops, a branch merge like this should not have been committed as squashed. :-(

Any way to fix it now?

Any way to fix it now?

We can either "rewrite history", by reverting the next branch to before that change and then properly merging in current, and repeating the changes done afterwards, or we can leave the mistake be and just follow it up with a proper merge.

@aleokdev Alright, the next branch now contains a proper merge roughly at the same time you did it, and then I've re-applied the commits for #170 and #161. Now, we can try merging current into next again for change 672b5cab6934b4d7159a729d1c4ad9d6e6acaf2c. It has some conflicts in object.rs.

@aleokdev Sorry, I forgot about the LayerType::TileLayer rename, so I've adjusted the merge again and re-applied the other changes again. Should be all good this time!


Crash occurs when using PlatformView and EngineGroup simultaneously

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
1.Start an engine using EngineGroup and open a page containing a PlatformView, then remove the PlatformView from the page.
2.Use the same EngineGroup to create a new engine to render a new page containing a PlatformView, which will trigger a crash.
https://github.com/flutter/flutter/assets/42142356/f6e3d0d6-0a5c-4395-b986-0bfd4414bec9
Expected results
PlatformView should display properly when using EngineGroup.
Actual results
A crash occurred.
Code sample
Code sample
[Paste your code here]
https://github.com/tianrp/flutter_blank_demo

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]
[VERBOSE-3:shared_thread_merger.cc(59)] Check failed: lease_term_ref > 0. lease_term should always be positive when merged, lease_term=0
2023-10-20 14:44:03.206019+0800 Runner[44679:2472818]
 [VERBOSE-2:profiler_metrics_ios.mm(203)] Error retrieving thread information: (os/kern) invalid argument

Flutter Doctor output
Doctor output
[Paste your output here]
[!] Flutter (Channel [user-branch], 3.13.8-0.0.pre.4, on macOS 13.3.1 22E772610a darwin-arm64, locale zh-Hans-CN)
    ! Flutter version 3.13.8-0.0.pre.4 on channel [user-branch] at
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/docs/get-started/install.
    ! Upstream repository  is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL"  to dismiss this error.
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2020.2.4)
[✓] IntelliJ IDEA Community Edition (version 2021.3.3)
[✓] VS Code (version 1.82.2)
[✓] Connected device (4 available)
[✓] Network resources

Thanks for the report @tianrp
I tried running the repo on iOS but getting below error in Xcode:

Can you provide steps to replicate / run the app ?
Also, can you check if the crash occurs with and without Impeller ?

感谢您的报告@tianrp 我尝试在 iOS 上运行存储库，但在 Xcode 中出现以下错误：

您能提供复制/运行应用程序的步骤吗？ 另外，你能检查一下有叶轮还是没有叶轮时是否会发生碰撞吗？

感谢您的报告@tianrp 我尝试在 iOS 上运行存储库，但在 Xcode 中出现以下错误：

您能提供复制/运行应用程序的步骤吗？ 另外，你能检查一下有叶轮还是没有叶轮时是否会发生碰撞吗？

@darshankawar Please open the project using Android Studio

Thanks for the report @tianrp I tried running the repo on iOS but getting below error in Xcode:

Can you provide steps to replicate / run the app ? Also, can you check if the crash occurs with and without Impeller ?

@darshankawar Please open the project using Android Studio

@tianrp
Ran it using latest master and stable versions, but didn't observe the crash. Please see below video:
https://github.com/flutter/flutter/assets/67046386/3fb4271d-9cd9-42cc-a89f-c9305b9cfa1d


Add legend hide options to timeseries panel

Hi there,
Firstly, really appreciate all the work you've done on this fork 🙌
I'm interested in adding the hideZero property to the legend object for Time Series Panels, similar to the Graph Panel, and I am currently using Grafana v9.2
I attempted to create a new branch in order to submit a PR, but I don't have permissions. So I am opening a ticket with a suggested diff:
     legendMode='list',
     legendPlacement='bottom',
     legendValues=[],
+    legendHideEmpty=null,
+    legendHideZero=null,
     lineInterpolation='linear',
     lineStyle='solid',
     lineDashSegments=null,
@@ -181,6 +183,8 @@
         calcs: legendValues,
         displayMode: legendMode,
         placement: legendPlacement,
+        [if legendHideEmpty != null then 'hideEmpty']: legendHideEmpty,
+        [if legendHideZero != null then 'hideZero']: legendHideZero,
       },
       tooltip: {

Thank you!

Hey, glad you think so. It looks like this feature isn't present in the timeseries panel - see this post and linked discussion threads: https://community.grafana.com/t/how-to-hide-zero-or-null-values-in-legend-in-grafana-8/54369/8
however it looks like you'll be able to do this with a transformer in 9.4.0: https://github.com/grafana/grafana/pull/57657
As for creating a branch, you should be able to fork the repository into your own github account and create as many branches as you like there. If you make changes in your fork and would like them to be incorporated in this fork you can raise a pull request.
How does all that sound?

Ahhh I see, I appreciate the forum link! I'll give that alternative approach a whirl. And will keep an eye out for the new transformer implementation for this once I update to 9.4. Thank you!
Closing this issue.


Remove undefined

Updates

Data sent to addMessage controller is now processed before creating SQL query to not include undefined properties

Changes incorporated into alternate branch


Empty tag in jUnit report

Hi
Little update in junit_reporter.js
Use XML empty tag syntax for empty "testcase" tags. It seems to me that this looks better.

 This will land in 2.0.6, which I should be releasing later tonight.
Thanks for the patch.


Unable to open comic through link

Steps to reproduce
To be precise, the issue(1116) has reappeared once again.
Expected behavior
null
Actual behavior
null
Crash logs
No response
TachiyomiSY version
Preview r574 (26cfb4811, 2024/11/8 11:25)
Android version
Android 15
Device
redmi k70 pro
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.11.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Addressed by https://github.com/jobobby04/TachiyomiSY/commit/c2df6ee54ab417dd78d60873c0a83b5cf91b6424


runtime: include panic/throw logs in core dumps

When a Go program crashes with GOTRACEBACK=crash, the OS creates a core dump. I'd like that core dump to include the human-readable "panic" or "fatal error" messages and stack traces—or at least the first N kB of them.
This could be done by writing the first ~64kB of errors and stack traces to a pre-allocated global slice in the runtime package in addition to writing to stderr.
No user code would be involved, so this is distinct from e.g. #16340. I'm particularly interested in being able to reliably collect not only "panic" crashes (from runtime.gopanic), but also "fatal error" crashes (from runtime.throw).
There are more tools being built around core dumps (#16410), so it would be good to collect all information relevant to crashes in that one place (https://github.com/golang/go/issues/16410#issuecomment-236983468)
Alternatives include:

Adding an API that allows user code to set the fd that's used for panic/throw logs (https://github.com/golang/go/issues/16340#issuecomment-232376520). This could end being a small change, though it would not catch problems with init functions in all packages.
Consult a new environment variable (like GORACE's log_path option) which would provide a prefix for the name of a file where the runtime would write out the crash report. The cost of adding a new environment variable is high, and it looks like this problem can be resolved without it.

Seems fine to me. Anyone want to take a stab at implementing it?

I've made an attempt at this which I'll mail momentarily. I can't say it's a good solution, but it's at least a starting point for discussion.

What else is there to do this for this issue now that https://golang.org/cl/32013 has been committed?

Core dumps will now include text-formatted runtime messages from immediately before a crash; they don't include any text-formatted messages on the crashes themselves. We discussed in the CL how that could be recreated from the runtime package's datastructures in the core dump.
If that can become a requirement of the work for #16410, then this issue is ready to be closed since there won't be any more runtime changes required. Where should that request be tracked?
Thanks @ianlancetaylor

Closing in favor of #16410.  Thanks.


Zld 1.3.3

Motivation for this change
zld is a faster linker than Apple's linker.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks a lot!

@GrahamcOfBorg eval

@GrahamcOfBorg eval

I briefly tested this on arm and got some errors. absolutely no worries though.
also, there was an interesting article on linkers, rust and nixos recently.
https://matklad.github.io/2022/03/14/rpath-or-why-lld-doesnt-work-on-nixos.html
you might need to do stuff with the rpath as well, just putting it for your information.

@happysalada that's interesting. I tried using lld and it doesn't work while zld did (for a Cargo project). This was running from an M1 machine. Also, I don't fully understand the conclusion on that article, it says you're supposed to use llvmPackages.lld and not lld, but in all-packages there's lld pointing to llvmPackages.lld.

it looks like there are two things.
there is llvm.lld and there is llvm.bintools.lld
the bintools one has an additional wrapper around it (can be found in bintools-wrapper/ld-wrapper.sh
here is the issue tracking it https://github.com/nixOS/nixpkgs/issues/24744
it's incredibly confusing, but yeah, llvm.bintools.lld seems to be the right one.

What error did you get when running sod on arm?

I get exactly rpath problems.
So to be sure I've got
export RUSTFLAGS="-Clink-arg=-fuse-ld=${pkgs.zld}/bin/zld
then I get an error Library no loaded: @rpath/libLTO.dylib
Referenced from nix_zld_path/bin/zld
Reason tried nix_zld_path/bin/libLTO.dylib (no such file)
just replace nix_zld_path with the nix zld path.
So it's either missing something in the output derivation, or it's a matter of setting the rpath correctly.
Perhaps it needs a wrapper just like ld-wrapper


Define scheme for themes and clean-up

Currently the URI in the scheme field for themes is pointing to the local themes.json, but I think the themes.json (and variables.json and eo-missions.json) should likely be removed. Where should we point to?

For now I'm pointing to the corresponding headers in the README. That's not ideal, but I don't have a better source of truth now.

For the variables the source of truth seems to be https://space.oscar.wmo.int/variables/ ?! This could be our scheme.

Reverted from themes to osc:themes.


_apis/Settings/Entries/globalme "401 unauthorized"

Scope required: "vso.settings".
Scope description of "vso.settings" and "vso.settings_write" is missing from this page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8b703fe-8982-4284-6db0-ef33abac08a4
Version Independent ID: 0fc84d11-1c32-0a49-04ec-641b68f44886
Content: Extension Manifest Reference - Azure DevOps
Content Source: docs/extend/develop/manifest.md
Product: devops
Technology: devops-ecosystem
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @VAllens, Thanks for this. I have the update in a PR to be published sometime today. Thanks again!


Calendar events don't work unless you change the Metadata inside the Calendar Note

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports and didn't find any similar reports.

Expected Behavior
When I right click and select "Turn into task" it should turn into a task
When I right click and select "Remove checkbox" it should turn it into an event
When I click the checkbox it should check off the task

Current behaviour
When I create a new event/task, right click and press "Turn into task" or "Remove checkbox" it doesn't work
Clicking on the checkbox doesn't work either

JavaScript console output
No response
Steps to reproduce

Create a new event
Give it any name
(Optional, click "Task Event")
Click "Save Event"

In order to make the event work

Go to the event note
Change "completed:" to true and then to false
Return to the Calendar and the buttons work again

Calendar information

Which Operating Systems are you using?

[X] macOS
[ ] Windows
[ ] Linux
[ ] Android
[ ] iOS

Obsidian Version
1.1.16
Full Calendar Plugin Version
0.10.7
Checks

[X] I have tried it with all other plugins disabled and the error still occurs.

Possible solution
No response
Comments
No response

Can confirm, same issue here.

Ok, I've sucessfully boiled the error + solution down to: You have to reload the app (Ctrl + P -> Reload app without saving) after adding the plugin to your vault, otherwise the task logic in the calendar view won't work.


NIFI-5718: Implemented LineDemarcator and removed NLKBufferedReader i…

…n order to improve performance
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@markap14, I agree that the class would be useful. Can you include a unit test that references it? As long as some piece of the PR legitimately references the class then I'm completely happy keeping it in and merging it, even with the @Ignore attribute, now that it's been explained to me.

@patricker done. On a 3-year-old Macbook Pro, looks like the LineDemarcator is able to demarcate 10 MM lines in about 350 millis. Just as a point of reference :)

+1 LGTM Ran all of the unit tests, looks good. Built it and ran it locally, had no issues. I also ran a unit test that never got put in from the ticket that started this whole journey, https://issues.apache.org/jira/browse/NIFI-5689?focusedCommentId=16652020&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16652020, no issues.


Add missing required protocol methods

Required method controllerWillPerformFetch and controllerDidPerformFetch are added in 7940731cf120f8eae80252a905d078ca093ccfbf , but those were not implemented in Swift version. That caused build error.
Fixes #93

👍  thanks for fixing this


LibWeb/CSS: Check for matching custom properties on parent elements

Previously, we were only checking the current element and not the parents in ResolvedCSSStyleDeclaration::custom_property() which wasn't correct.

Our LibJS per-file test results page now displays the colors.
Before:

After:


VSCode tooltips do not show default values of pydantic classes.

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
In VSCode, the tooltip does not show default values:

I would have expected a similar Tooltip as for regular classes:

I'm not sure where the source of the problem is located (pydantic or VSCode or something else) or even if you consider it a bug at all.
Example Code
import pydantic

class Test(pydantic.BaseModel):
    text: str = "hello world"

Test()

class TestWithoutPydantic:
    def __init__(self, text: str = "hello world")
        self.text = text

TestWithoutPydantic()

Python, Pydantic & OS Version
pydantic version: 2.8.2
        pydantic-core version: 2.20.1
          pydantic-core build: profile=release pgo=true
                 install path: /stackable/.local/lib/python3.11/site-packages/pydantic
               python version: 3.11.5 (main, Sep 22 2023, 15:34:29) [GCC 8.5.0 20210514 (Red Hat 8.5.0-20)]
                     platform: Linux-5.15.0-118-generic-x86_64-with-glibc2.28
             related packages: mypy-1.11.1 typing_extensions-4.12.2 pydantic-settings-2.4.0
                       commit: unknown

This is a regression in pyright 1.1.372, which was addressed in 1.1.377. The related issue can be found here: https://github.com/microsoft/pyright/issues/8781.
You'll have to wait for Pylance to ship a new version, or switch to the latest pre release.

Thank you!


Add light and dark style to select widget styles

Not going to do this. Instead I'm going to add Link buttons, which are essentially like the TLabel style except with shift relief.


Access request for  to test-azure-win2019-x64-1

NOTE: THIS ISSUE SHOULD NOT BE CLOSED BY THE ORIGINATOR IF ACCESS IS GRANTED.
When the access is no longer needed please add a comment and a member
of the infrastructure team will revoke it and close the issue.
Required access level (Delete as appropriate). Note that you should only
request the minimum level that is required to solve your problem

[ ] Non-privileged
[ ] jenkins user
[x] root/Administrative
[ ] other (Please specify):

System for which access is needed: https://ci.adoptium.net/computer/test-azure-win2019-x64-1/
Grinder run for windows reproduciable comparing hit the issue can not delete workspace https://ci.adoptium.net/view/Test_grinder/job/Grinder/9863/console,
Same run on https://ci.adoptium.net/computer/build-azure-win2022-x64-2/ didn't get the issue https://ci.adoptium.net/view/Test_grinder/job/Grinder/9876/
Need to clean workspace to investigate.
Please explain why you need this access including whether it is a temporary or permanent request:

@steelhead31 Can you take a look at this please since I know you've lookd at other permissions related issues on Windows in recent months? I logged into the machine but the keyboard layout is a bit messed up (It was initially showing that it was set to Welsh but it's worse than that - both as the admin and jenkins users - and switching it back didn't seem to help) - would be good to know if that happens for you too.
It does look like the permissions on the mentioned directory are messed up though so that it can't be written to by the jenkins user - have any changes occurred recently on this machine?

@sxa I'll take a look, nothing has changed as far as Im aware, though I have noticed all of the windows test machines switching to a welsh keyboard layout... haven't noticed it on a build machine though. The permissions issue hints of the same thing occurring on the ibmcloud machine...

Just investigating, the welsh keyboard layout is unusual, in that windows doesn't recognise it as an installed language... so I've added it, and then removed it to ensure that only the default, US layout is available... I'll run a set of tests, to see if something in the test suite, is causing it to be installed / enabled.

The permissions issue is slightly more unusual..

And this..

Top level directory has correct security descriptors, problem is only visible in anything below C:\Users\jenkins\workspace\Grinder\aqa-tests

Interestingly the TKG directory cant be deleted by Administrator, as its owned by jenkins.. and jenkins cant delete it because it doesn't have administrator permissions.

I guess this is most likely something caused by the reproducible build job in Grinder, since that is the last one that managed to create anything under aqa-tests, although I can't imagine why that would have caused something like this 🤔

I wonder if we've got a chmod somewhere in the process somewhere that's affecting things. I guess the test will be to try a re-run of the original job to see if it recurs on that machine.

In progress, running parallel jobs on 2022-2 and 2019-1 to see what the end result is.. :)

Permissions issue hasnt occured on either machine :man_shrugging:

@sophia-guo I've fixed the issue, and Im unable to replicate ( I've run two consecutive grinders ), is that sufficient for you to continue, or do you still require access ?

Thanks @steelhead31 . Trying to see if it's good https://ci.adoptium.net/view/Test_grinder/job/Grinder/9886/

Looks good. Will close this one.


⚠ SolarOscp has degraded performance

In 5cda929, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 336 ms

Resolved: SolarOscp performance has improved in 3f80542 after 10 minutes.


Reduce flow control stalls in unconstrained environments to zero

Relevant benchmark: bm_fullstack_trickle.cc BM_PumpStreamServerToClient_Trickle
At writing, for a 128MB message: 0 transport stalls, 2.333 stream stalls
Target: 0 transport stalls, 0 stream stalls

This goal was achieved a while back


Is this repo in maintenance mode or deprecated?

I do not see a lot of activity.
The change log is untouched since February.
The README encourage to contribute with pull requests but there are 19 open and some of them have no feedback.
I see a few pull requests that seems pretty safe to merge:

#77
#64
#61
#59
#57
#54
#48
#43
#42

One that seem particularly important for me is that the client cannot be used in node 0.12 or 4.x  because the ws module does not compile. It seems that upgrading ws as specified in #47 will fix the problem.
There is also #56 that rebased #22 so it could be merged but because it was not merged promptly, now it needs again some work to be merged.
#66 seems also a good candidate to be merged
On active repositories, PR are either rejected with an explanation or merged. So, is this an obsolete repo? Is a new version of the slack node client about to be released?

Thanks for bumping this.  I reviewed the PRs I created and rebased the ones that need it.  They are good to go:
#47 - Bump WS to latest
#48 - Remove a no-op
#54 - Handle team migration started
#61 - Basic pass through of error code and message
#66 - Fix reconnect / pong issues

Hi there,
Sorry about the delayed response.
We're actively working on improving our support for the opensource clients for the Slack API - we've recently added some really great folks to our DevRel and platform teams who are going to help push these forwards.
For node-slack there's a couple things going on:

I've refactored the existing client to bring it up to a point where it's easier to use, easier to maintain and easier to contribute to. You can see that work in my own repo here: https://github.com/l12s/node-slack-client. I'll be posting a note to this repo in the next couple days inviting folks to beta test the new client. It has major breaking changes, so it'll be released as a 2.0.0 release and under a new package name. My post to this repo's README will cover the reasoning behind that in more detail
I'm going to take a look at @vanm PRs above later today and see which of them I can quickly incorporate to spin a 1.5.0 release out to get you some short-term improvements while the 2.0.0 version is in beta

We know that the current progress on our open source clients isn't where it should be and really appreciate everyone who's using them to build cool apps and integrations. Thanks for your patience while we get organized around supporting them better and figuring out how to push them forwards faster and with fuller community involvement.
Leah

:+1: thanks, Leah.  Excited to beta test the new client when it's ready.

Ok, I've merged in #47, #48, #54 and #61
I'm going to update the changelog later today and update the package to a 1.5.0 version and push that to npm. My intention is that we then pause work on this version of the client while I wrap up the last couple of event handlers for the 2.0.0 version and get eyes on that code + some sample implementations written  for it to root out some of the bugs.

Ok, 1.5.0 update is prepped and should be on npm shortly.

Hey @l12s ! How is the evolution to the 1.5.0 going? Curious to start using it!

Ok, first off, I apologize for how long it's taken us to resolve this issue.
I just pushed the 2.0.0 release for this library, which is a ground up refactor with the aim of building a lib that both Slack and our external contributors can easily work with and improve.


ci: new preview script takes care of waiting for applications

Related to https://github.com/redhat-appstudio/infra-deployments/pull/518

/lgtm
/approve


Where should plugins put data?

I'm trying to create a plugin that uses Unicode data. It provides offline access to all your unicode (and emoji) copy-pasting needs, but i'm struggling where to put the actual data.
Any guidelines for this?

@igalic This is not specific to fisherman or fin plugins, but any application.
The correct place to put your program's configuration is in XDG_CONFIG_HOME, by default ~/.config/your_program.
If your program uses a cache, then that should go into XDG_CACHE_HOME, by default ~/.cache/your_program.
Related: XDG Base Directory support

@igalic Feel ready to close?


Support for --entrypoint and --env in docker.compose.run()

This library is great, thank you for creating it! I found out that --entrypoint and --env is currently not supported for docker.compose.run(), which I desperately need. I just finished adding these options as well as tests on my fork but then I saw that each commit corresponds to some issue, so I'm opening one. If I'm not following the intended process, please let me know.

We don't have a formal process. Feel free to open a pull request. If possible, prefer to open one pull request per feature added as it's easier to merge and rollback if needed :) thank you for your interest in making this project better!

Noted! The current PR is in test, so I'm waiting until the tests are finished. After that I will close the MR and split it into two, one for each option.

I create a separate issue for --env.


add quick search to hexdocs.pm

Change-Id: Ifd888136b0c7cd9936bf02612bd87fdcce639ba7
this pr is a hover enhancement.
before

and after this pr

we can click this hyperlink to hexdocs.pm search page, like this: https://hexdocs.pm/elixir/search.html?q=File.write

Hi! Thanks for this. I think this is a very interesting idea but there a few issues that need to be resolved:

This generates a link to https://hexdocs.pm/elixir/search.html?q= for every function, even functions from the user's project and their dependencies

This is the primary issue

I think we should generate a direct link to the function documentation

e.g. https://hexdocs.pm/elixir/File.html#write/3 instead of https://hexdocs.pm/elixir/search.html?q=File.write

The link should be labeled more like view on hexdocs instead of changing the function name into a link

Thanks for your reply.
according to you suggestions, I made some optimizations.
for issue1, only elixir std modules will be add hexdocs link. for example:
std module:

other module:

and for issue2, now can jump to function location.

@mpanarin thanks for your review.
I have made some changes according to your suggestion, now it can jump to both third party dependences and elixir std modules.
eg.

@zhenfeng-zhu please add some tests (for builtin, external, umbrella, erlang modules)

Now we need some tests and IMO it's good to go

Now we need some tests and IMO it's good to go

yeah,   I am doing. Thanks for your help.

Now we need some tests and IMO it's good to go

@lukaszsamson I have add some tests for hover.But I don’t think it’s perfect yet. Could you give more advice on writing tests？

@mpanarin any update?

@lukaszsamson @mpanarin @axelson  Hope you anyone could review it

I asked for tests of erlang module and function (e.g. :ets :ets.init should link to erlang docs, but :telemetry should link to hexdocs).
I also need a test of umbrella app to see if project dir is correctly handled.

I asked for tests of erlang module and function (e.g. :ets :ets.init should link to erlang docs, but :telemetry should link to hexdocs).
I also need a test of umbrella app to see if project dir is correctly handled.

thanks, i'm trying to do it!

I asked for tests of erlang module and function (e.g. :ets :ets.init should link to erlang docs, but :telemetry should link to hexdocs).

For this issue, I have a question:
I find that both of :ets and : telemetry are erlang modules.  Why :ets go to erlang docs , but :telemetry should go to hexdocs?
That make me confused, what is the standard of judgment?

You should ask OTP team why they don’t publish docs to hexdocs 😉

You should ask OTP team why they don’t publish docs to hexdocs 😉

Haha, maybe in this pr, I can just not support erlang modlue link to hexdocs.
And by the way, in my test file:
def fake_dir() do
    Path.join(__DIR__, "../../../..") |> Path.expand() |> maybe_convert_path_separators()
end

I use fake_dir() as a argument as project_dir.
the fake_dir is "/Users/lucas/Documents/demos/elixirs/vscode-elixir-ls/elixir-ls",  it's a umbrella app.  so I guess the work is done

@lud please open a bug report

Hi sorry I had to leave my home station quickly. Happy to see that is already solved.
Thanks !


Corber support for Android 9 API level 28

When Android 9.0 will be supported?
Starting August 1, 2019, Google Play requires that new apps target at least Android 9.0 (API level 28), and that app updates target Android 9.0 from November 1, 2019.

An update for this would be nice as otherwise it is looking that from November we might me screwed!

Resolved as of 1.13.12 - will be out later today.


Ability to expose if dependencies are direct or indirect

Is it possible to also expose if dependencies are direct or indirect, we are trying to build up the graph of dependencies and encode the structure within GUAC

The information is already there in the GetDependencies response. If the edges list contains an entry with fromNode 0, then its toNode points to a direct dependency in the nodes list.
Does that make sense? Perhaps we should provide an example and/or call this out directly in the docs.

@adg Could you provide an example to better explain this?

@pxp928 sure. For example, the npm package react has three transitive dependencies:
$ curl -s https://api.deps.dev/v3alpha/systems/npm/packages/react/versions/17.0.0:dependencies | jq
{
  "nodes": [
    {
      "versionKey": {
        "system": "NPM",
        "name": "react",
        "version": "17.0.0"
      },
      "bundled": false,
      "errors": []
    },
    {
      "versionKey": {
        "system": "NPM",
        "name": "js-tokens",
        "version": "4.0.0"
      },
      "bundled": false,
      "errors": []
    },
    {
      "versionKey": {
        "system": "NPM",
        "name": "loose-envify",
        "version": "1.4.0"
      },
      "bundled": false,
      "errors": []
    },
    {
      "versionKey": {
        "system": "NPM",
        "name": "object-assign",
        "version": "4.1.1"
      },
      "bundled": false,
      "errors": []
    }
  ],
  "edges": [
    {
      "fromNode": 0,
      "toNode": 2,
      "requirement": "^1.1.0"
    },
    {
      "fromNode": 0,
      "toNode": 3,
      "requirement": "^4.1.1"
    },
    {
      "fromNode": 2,
      "toNode": 1,
      "requirement": "^3.0.0 || ^4.0.0"
    }
  ],
  "error": ""
}

In the edges list, the fromNode is the index in nodes of the package that declared the dependency, and the toNode is the index in nodes of the dependent package. Since the first entry in nodes is always the root package, any edge with a fromNode of 0 is a direct dependency.
Here's an example that uses jq to print the from/to edges as package names, and whether the dependency is direct or indirect:
$ curl -s https://api.deps.dev/v3alpha/systems/npm/packages/react/versions/17.0.0:dependencies | jq -j '
        # Gather the names of each node.
        [.nodes[].versionKey.name] as $names |

        # For each edge, print the names of the from/to nodes, and whether the
        # "to" node depends on the root (it is a "direct" dependency).
        .edges[] | (
                $names[.fromNode], " -> ", $names[.toNode], " ",
                if .fromNode == 0 then
                        "(direct)"
                else
                        "(indirect)"
                end, "\n"
        )
'
react -> loose-envify (direct)
react -> object-assign (direct)
loose-envify -> js-tokens (indirect)

Let me know if this is helpful to you. (I can understand if the jq stuff is confusing - it is a bit of an esoteric language).
We'll also look at adding an example Go program to this repo that demonstrates better how to work with GetDependencies responses, and consider whether there should be a different dependencies API endpoint if the current one is too cumbersome.

The requirement on the edge is declared by the "from" node.
As for the original question about marking direct/indirect dependencies, what @adg says is exactly right: a client can determine this by looking for all the edges from node 0. With that said, it seems like a simple and worthwhile improvement to make this explicit in the API. I'll work on that.

Nodes in dependency graphs now have a relation field marking them as direct or indirect dependencies (or "self" for the node representing the package version that the dependency graph is for).
As an example, here's what the nodes in the dependency graph for react 18.1.0 look like in the HTTP API:
$ curl -s 'https://api.deps.dev/v3alpha/systems/npm/packages/react/versions/18.1.0:dependencies' | jq '.nodes'
[
  {
    "versionKey": {
      "system": "NPM",
      "name": "react",
      "version": "18.1.0"
    },
    "bundled": false,
    "relation": "SELF",
    "errors": []
  },
  {
    "versionKey": {
      "system": "NPM",
      "name": "js-tokens",
      "version": "4.0.0"
    },
    "bundled": false,
    "relation": "INDIRECT",
    "errors": []
  },
  {
    "versionKey": {
      "system": "NPM",
      "name": "loose-envify",
      "version": "1.4.0"
    },
    "bundled": false,
    "relation": "DIRECT",
    "errors": []
  }
]

Note to self for this thread, the assumption on "So if i have 0->1->2, would querying the API for the package for "1" or "2" result in more information?", the answer is "yes", since a different tree is returned based on the root node provided (based on discussions). Just documenting here to correct myself in the issue.


Add 'testing' feature to casper-node to expose test-only functionality on block and deploy types

This PR exposes some constructors of Block and Deploy behind a new feature testing.  The constructors allow for creation of random instances and are useful for projects such as the sidecar process to be able to leverage in their test suites.

bors merge


Failing to start

Seeing this lately and I see the OnStarJS recently updated. Is it possible the homebridge plug-in also needs a code update?
[3/10/2021, 18:05:44] [Malibu] start: Requested
[3/10/2021, 18:05:45] [Malibu] start: Error: Request Failed with status 400 - Bad Request

Oh, looks like I never published a new version the last time OnStarJS was updated. I just did now, thanks for the heads up. Should help with those, but let me know.

Thank you that did the trick!


refactor: Change the control/data plane fields to property func

Change Analysis class's apps_data_plane & apps_control_plane fields to property functions for more extensibility.

This is being worked on and reviewed over at #518, so I think we can close this @jneo8

Merging in #518


feature: Local OpenQASM Simulator example notebook

Issue #, if available:
Description of changes:
Update OpenQASM example notebook to reference LocalSimulator.
Create example notebook for OpenQASM LocalSimulator
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I think we should also add the open_qasm notebooks in the sub-folder since we have other files along with it i.e. adder.qasm.

Do we want to explain that the measure instruction is redundant and optional (or is that already covered in the other OpenQASM notebook)?

Do we want to explain that the measure instruction is redundant and optional (or is that already covered in the other OpenQASM notebook)?

I think the examples demonstrate you can get the measurement counts and/or result types without specifying any measurements, also the device properties show that all qubits are always measured. If you think it would be helpful, I could add something


Python Upgrade to 3.10 Causes Error in Colab Notebook Execution

What happened?
In Colab notebook "Text classification with TFLite and IREE", The installation of tflite_runtime failed due to the upgrade of Python to version 3.10 in Colab. As a result, the subsequent code that depends on this package cannot run properly.
The current installation method for tflite_runtime in this Colab notebook is as follows:
!pip3 install --extra-index-url https://google-coral.github.io/py-repo/ tflite_runtime
However, the corresponding version of tflite_runtime for Python3.10 is not available in py-repo. Therefore, the script needs to be modified to install tflite_runtime in a different way to make sure the notebook can run properly.
Steps to reproduce your issue
Run this Colab notebook "Text classification with TFLite and IREE".
What component(s) does this issue relate to?
Other
Version information
Execution is on current Colab platform.
Additional context
No response

Thanks for the report! Looks like our CI caught another issue with the notebook too: https://github.com/openxla/iree/actions/workflows/samples.yml
https://github.com/openxla/iree/actions/runs/4933042806/jobs/8816641408#step:3:314
----- stdout -----
/bin/sh: 1: /work/.notebook.venv/lib/python3.8/site-packages/iree/tools/tflite/iree-import-tflite: not found

This code should just run iree-import-tflite without going through get_tool:
# Convert TFLite model to TOSA MLIR (bytecode) with IREE's import tool.
IREE_TFLITE_TOOL = iree_tflite.get_tool('iree-import-tflite')
tosa_mlirbc_file = ARTIFACTS_DIR.joinpath("text_classification.mlirbc")
!{IREE_TFLITE_TOOL} {ARTIFACTS_DIR}/text_classification.tflite --o={tosa_mlirbc_file}

https://pypi.org/project/tflite-runtime-nightly/ might work for tflite_runtime (that does have Python 3.10 wheels)

https://github.com/openxla/iree/tree/main/samples/colab#working-with-github instructions for updating the checked in notebooks, if someone else wants to fix this before I get the chance :)


ID-7 – first steps adding saved card metadata

This is almost certainly redundant now and I've closed the linked Jira issue.
Just wanted to push this somewhere in case we change plans before I delete the
file locally!
Making a draft PR to keep track of this and remember to delete the branch later, assuming we don't hit snags with the new approach.

It looks 99% likely the other approach will work, so closing / deleting this PR / branch.


Remove CI/CD Pipeline section in content/uk/docs/tutorials/_index.md

Part of #23167 for UK

/kind cleanup

Thank you @habibrosyad !
/lgtm
/approve


Save last used settings

Sorry for writing again, but I really like the tool and would like to help improve it 😉
Today I was creating a confetti effect for a background. As I was using different shapes I had to do the same thing multiple times. Would be nice if Looper saves the last used settings, so that I just can apply the same action to different shapes.
Would be also very handy if you are playing arround and just want to tweak some settings but keep the same look.

Thanks for the suggestion Alexander, thats a really cool idea! If I know how to store variables per session in sketch plugins, I can implement this, honestly I not sure how to implement it :) do you happen to know how to do this?

@sureskumar Honestly not really. I just know that you can use NSUserDefaults for such settings in "normal" applications. Maybe there is a way to use this as well in Sketch plug-ins?

@sureskumar Today I came across the API reference you probably need! There is an official way to safe settings persisted, even after closing Sketch. But I guess in this case it would be enough to use the Settings.setSessionVariable('myVar', 0.1) - see here: https://developer.sketchapp.com/reference/api/#set-a-plugin-setting-1


[BUG] cpu memory usage of zero-stage3

Describe the bug
The cpu memory usage stays same if I use 1,2,4 gpus, however, if I use 8 gpus, the cpu memory usage increases a lot and makes host out of memory.
To Reproduce
Brief code like this:
import random
import argparse
from transformers import AutoTokenizer, AutoModel, BloomConfig, BloomForCausalLM, BloomForSequenceClassification, BloomForTokenClassification, BloomForQuestionAnswering
from accelerate import infer_auto_device_map
import torch
import deepspeed

parser = argparse.ArgumentParser()
parser.add_argument('--local_rank', type=int, default=-1)
parser = deepspeed.add_config_arguments(parser)
args = parser.parse_args()

device = torch.device('cuda', args.local_rank)
torch.cuda.set_device(args.local_rank)
org = 'Paris York and company company New is based Paris based in HuggingFace a HuggingFace is Paris New based based in and based is in '
org = org.split(' ')
texts = [' '.join([random.choice(org) for _ in range(3000)]) for _ in range(10)]

model_name = 'bigscience/bloomz-7b1-mt'
tokenizer = AutoTokenizer.from_pretrained(model_name)
model = BloomForCausalLM.from_pretrained(model_name)
model.to(device)
optim = torch.optim.AdamW(model.parameters(), lr=1e-3,
        weight_decay=0.02, betas=(0.9, 0.999))

model_engine, optim, train_loader, _ = deepspeed.initialize(
        args=args, model=model, model_parameters=model.parameters()
        )

for i in range(20):
    ind = i % len(texts)
    inputs = tokenizer(texts[ind:ind+1], add_special_tokens=False,
                       return_tensors="pt", padding=True,
                       truncation=True, max_length=512).to(device)

    outputs = model_engine(**inputs, labels=inputs["input_ids"])
    model_engine.backward(outputs.loss)
    model_engine.step()

The config file is like this:
{
"train_micro_batch_size_per_gpu": 1,
"train_batch_size": 8,
"optimizer": {
    "type": "AdamW",
    "params": {
      "lr": 0.001,
      "betas": [
        0.9,
        0.999
      ],
      "eps": 1e-8,
      "weight_decay": 1e-2
    }
  },
"fp16": {
    "enabled": true,
    "auto_cast": false,
    "loss_scale": 0,
    "initial_scale_power": 16,
    "loss_scale_window": 1000,
    "hysteresis": 2,
    "min_loss_scale": 1
},
"zero_optimization": {
    "stage": 3,
    "allgather_partitions": true,
    "allgather_bucket_size": 5e8,
    "overlap_comm": false,
    "reduce_scatter": false,
    "reduce_bucket_size": 5e8,
    "contiguous_gradients" : false,
    "offload_param": {
        "device": "cpu",
        "pin_memory": true
    },
    "offload_optimizer": {
        "device": "cpu",
        "pin_memory": true
    },
    "stage3_max_live_parameters" : 1e9,
    "stage3_max_reuse_distance" : 1e9,
    "stage3_prefetch_bucket_size" : 5e8,
    "stage3_param_persistence_threshold" : 1e6,
    "sub_group_size" : 1e12,
    "stage3_gather_16bit_weights_on_model_save": true,
    "ignore_unused_parameters": true,
    "round_robin_gradients": true
}
}

I use this command to launch:
deepspeed --num_gpus 8 train_ds.py --deepspeed --deepspeed_config ds_config.json

My platform has 8 v100 gpus, with cuda 11.3 and driver version of  515.65.01. My host memory is 256G.
deepspeed version is 0.8.0, and transformers version is 4.26.0.
I am using ubuntu 18.04 docker version. python version is 3.8.12.
Expected behavior
If I use 4 gpus rather than 8, the result is normal, but if I use 8 gpus, the host memory would be run out. I hope the memory usage would be same.

@CoinCheung, can you please share stack trace and log? Thanks!

@CoinCheung Did you find a solution? I met the same issue when loading Llama 65B on 8 A100

Hi, I do not have such problem after updating into newest version. Maybe your model is too big even for 8 A100.


Gradle aggregrateJavadocJar hangs indefinitely.

As discussed on #gtfs-validators, the command ./gradlew aggregateJavadocJar hangs indefinitely for me and seemingly for others as well.  This task is executed automatically as part of a ./gradlew build call.
Interestingly, aggregateJavadoc runs successfully for me and it's only the jar phase that hangs.  When run the jar step specifically, I see that gtfs-validator-4.1.1-SNAPSHOT-javadoc.jar is being generated... and it's gigantic.  Multiple GBs and it will keep on growing if you let the command continue to run.  So looks like the task is stuck in some sort of loop where it's attempting to create a never-ending jar file.
This looks similar to this issue: https://github.com/freefair/gradle-plugins/issues/640 which unfortunately has no responses.
This is on the master branch with MacOS and openjdk 11.0.19 2023-04-18 LTS.

I tried upgrading the io.freefair.aggregate-javadoc-jar plugin to 8.0.1 but this did not fix the issue.

Interestingly, the io.freefair.aggregate-javadoc-jar plugin was added by me (!) per discussion in https://github.com/MobilityData/gtfs-validator/pull/1125#issuecomment-1116568232 to work around an issue with the old aggregation plugin we were using.
Critically, I can't find any indication that anyone actually cares about the Javadoc jar  file (does anyone care about the Javadoc at all?).  In fact, we only execute aggregateJavadoc in test_pack_doc.yml, not aggregateJavadocJar.  And it turns out freefair provides a version of the plugin that doesn't export the jar command.  So I think we can just switch to that and be fine?  I've confirmed that build runs successfully when I make this change locally.

does anyone care about the Javadoc at all

Yes, I do. I'd like to create an aggregated javadoc .jar and aggregated javadocs as html, unfortunately I got the same issue. https://github.com/freefair/gradle-plugins/issues/798  Has anyone yet found a fix for this?

Maybe this fixes your issue, it did work for me: https://github.com/freefair/gradle-plugins/issues/798#issuecomment-1565452423


Dev #670 - Remove Staging environment from Google Analytics

Remove Staging environment from Google Analytics
Description
Currently, Google Analytics data includes both the Staging and Production environments.
The Staging environment should be removed from GA, so that GA data is for the Production environment only.
Execution
No screenshots available, in the staging environment the Google Analytics cookies will not be set and the Google Analytics javascript will not be included.
Use the browser's Developer Console to verify.

Thanks @cacquani. Difficult to test this one but I've checked the code and it looks fine.