Extremely slow reconcilliation of Managed Resource

What happened?
We're seeing very long reconcilliation times with an MR that depends on other MRs in the same composition.
In this case the composition is built from an IAMRole, IAMPolicy and IAMRolePolicyAttachment. The IAMRole and Policy MRs reconcile in a matter of seconds as expected, but the IAMRolePolicyAttachment can take 45 minutes to reconcile.
The IAMRolePolicyAttachment uses the attributes of the IAMRole and IAMPolicy for it's configuration:
        forProvider:
          policyArnSelector:
            matchControllerRef: true
          roleNameSelector:
            matchControllerRef: true

After making a claim, we notice that it doesn't reach a Ready state after several minutes and so we check the events on the IAMRolePolicyAttachment and we see this:
Warning  CannotResolveResourceReferences  6m2s (x2 over 6m2s)  managed/iamrolepolicyattachment.identity.aws.crossplane.io  cannot resolve references: spec.forProvider.policyArn: referenced field was empty (referenced resource may not yet be ready)

That seems to imply that no further attempts to reconcille have taken place for over six minutes!
We then wait, and wait, and eventually it reconciles and we see the following events:
  Warning  CannotResolveResourceReferences  38m (x2 over 38m)  managed/iamrolepolicyattachment.identity.aws.crossplane.io  cannot resolve references: spec.forProvider.policyArn: referenced field was empty (referenced resource may not yet be ready)
  Normal   CreatedExternalResource          1m36s              managed/iamrolepolicyattachment.identity.aws.crossplane.io  Successfully requested creation of external resource

These event messages imply that Crossplane wasn't even attempting to reconcille for some 38 minutes!? Not good.
I enabled debug mode via the ControllerConfig, but this just corroborates the events above. I see a log message starting:
Cannot resolve managed resource references
Then there is nothing for several minutes regarding that iamrolepolicyattachment until eventually this:
Reconciling {"controller": "managed/iamrolepolicyattachment.identity.aws.crossplane.io"
immediately followed by
Successfully requested creation of external resource {"controller": managed/iamrolepolicyattachment.identity.aws.crossplane.io"
Further, the issue seems to go away when we don't set the crossplane.io/external-name annotation on the XRC. Then the XRC and all the MRs are reconcilled successfully in a matter of seconds.
Here's the config we're using:

xrc
apiVersion: crossplane.example/v1alpha1
kind: IRSA
metadata:
  name: datasync
  labels:
    foo: bar
  annotations:
    crossplane.io/external-name: datasync
spec:
  parameters:
    description: "Data Sandbox S3 Sync"
    policyname: datasync
    policydoc: |
      {
        "Version": "2012-10-17",
        "Statement": [
          {
            "Effect": "Allow",
            "Action": [
              "s3:GetBucket"
            ],
            "Resource": "*"
          }
        ]
      }
  writeConnectionSecretToRef:
    name: datasync-irsa

xrd
apiVersion: apiextensions.crossplane.io/v1
kind: CompositeResourceDefinition
metadata:
  name: irsacomposites.crossplane.example
spec:
  claimNames:
    kind: IRSA
    plural: irsas
  connectionSecretKeys:
  - roleArn
  defaultCompositionRef:
    name: irsacomposite
  group: crossplane.example
  names:
    kind: IRSAComposite
    plural: irsacomposites
  versions:
  - name: v1alpha1
    referenceable: true
    schema:
      openAPIV3Schema:
        properties:
          spec:
            properties:
              parameters:
                properties:
                  description:
                    description: Description to attach to IAM Resources
                    type: string
                  policydoc:
                    description: Policy Document
                    type: string
                  policyname:
                    description: IAM Policy Name
                    type: string
                  tags:
                    description: AWS resource tags
                    items:
                      properties:
                        key:
                          type: string
                        value:
                          type: string
                      type: object
                    type: array
                required:
                - policydoc
                - policyname
                - description
                type: object
            required:
            - parameters
            type: object
        type: object
    served: true

composition
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
  name: irsacomposite
spec:
  compositeTypeRef:
    apiVersion: crossplane.example/v1alpha1
    kind: IRSAComposite
  patchSets:
  - name: Metadata
    patches:
    - fromFieldPath: metadata.labels
      type: FromCompositeFieldPath
    - fromFieldPath: metadata.annotations
      type: FromCompositeFieldPath
  resources:
  - base:
      apiVersion: identity.aws.crossplane.io/v1beta1
      kind: IAMRole
      spec:
        deletionPolicy: Delete
        forProvider:
          tags:
          - key: managed_by
            value: crossplane
        providerConfigRef:
          name: crossplane-provider-aws
        writeConnectionSecretToRef:
          namespace: crossplane
    connectionDetails:
    - fromFieldPath: status.atProvider.arn
      name: roleArn
      type: FromFieldPath
    patches:
    - patchSetName: Metadata
      type: PatchSet
    - fromFieldPath: spec.parameters.description
      toFieldPath: spec.forProvider.description
      type: FromCompositeFieldPath
    - fromFieldPath: spec.parameters.tags
      toFieldPath: spec.forProvider.tags
      type: FromCompositeFieldPath
    - fromFieldPath: metadata.uid
      toFieldPath: spec.writeConnectionSecretToRef.name
      type: FromCompositeFieldPath
    - fromFieldPath: spec.claimRef.namespace
      policy:
        fromFieldPath: Required
      toFieldPath: spec.forProvider.assumeRolePolicyDocument
      transforms:
      - string:
          fmt: |
            {
              "Version": "2012-10-17",
              "Statement": [
                {
                  "Sid": "",
                  "Effect": "Allow",
                  "Principal": {
                    "Federated": "arn:aws:iam::123456789:oidc-provider/oidc.eks.eu-west-1.amazonaws.com/id/XXX"
                  },
                  "Action": "sts:AssumeRoleWithWebIdentity",
                  "Condition": {
                  "StringLike": {
                    "oidc.eks.eu-west-1.amazonaws.com/id/XXX:sub": "system:serviceaccount:%s:*"
                  }
                  }
                }
              ]
            }
        type: string
      type: FromCompositeFieldPath
  - base:
      apiVersion: identity.aws.crossplane.io/v1alpha1
      kind: IAMPolicy
      spec:
        deletionPolicy: Delete
        forProvider: {}
        providerConfigRef:
          name: crossplane-provider-aws
        writeConnectionSecretToRef:
          namespace: crossplane
    patches:
    - fromFieldPath: spec.parameters.description
      toFieldPath: spec.forProvider.description
      type: FromCompositeFieldPath
    - fromFieldPath: spec.parameters.policydoc
      toFieldPath: spec.forProvider.document
      type: FromCompositeFieldPath
    - fromFieldPath: spec.parameters.policyname
      toFieldPath: spec.forProvider.name
      type: FromCompositeFieldPath
    - fromFieldPath: metadata.uid
      toFieldPath: spec.writeConnectionSecretToRef.name
      transforms:
      - string:
          fmt: '%s-iampolicy'
        type: string
      type: FromCompositeFieldPath
  - base:
      apiVersion: identity.aws.crossplane.io/v1beta1
      kind: IAMRolePolicyAttachment
      spec:
        deletionPolicy: Delete
        forProvider:
          policyArnSelector:
            matchControllerRef: true
          roleNameSelector:
            matchControllerRef: true
        providerConfigRef:
          name: crossplane-provider-aws
        writeConnectionSecretToRef:
          namespace: crossplane
    patches:
    - patchSetName: Metadata
      type: PatchSet
    - fromFieldPath: metadata.uid
      toFieldPath: spec.writeConnectionSecretToRef.name
      transforms:
      - string:
          fmt: '%s-iamattach'
        type: string
      type: FromCompositeFieldPath
  writeConnectionSecretsToNamespace: crossplane

Crossplane: 1.1.0
AWS Provider: 0.18
Kubernetes: 1.19 (EKS)

Related, I already opened this issue against crossplane core, but it does appear to be a provider issue so have raised here instead.
https://github.com/crossplane/crossplane/issues/2303

we hit the same issue (and I believe @benagricola as well)

I'm looking into this - it might be the assume role policy comparison going wrong, I have a local fix for this and with crossplane 1.3 rc  + provider-aws 0.18 w/ this patch I don't have any issue. Related to #704 - if you have comments on package structure there it would be awesome :)

We had a very similar issue. We use the simple resources without the Compositing mediation.
We have a IAM user, a IAM policy and a IAM policy attachment: IAM user and IAM policy take about 4 seconds to be ready and synced, the IAM policy attachment resource tries 2/3 times to create itself on AWS in the first second and after this the process hangs for about 20 minutes. Of course this amount of time is too much and using helm release standard wait time causes a failed deployment.
This behaviour is not always reproducible, and sometimes it happens for one release and not for the immediately subsequent one.

that's blocking me as well. one can test with:
apiVersion: identity.aws.crossplane.io/v1beta1
kind: IAMRole
metadata:
  name: cnp-example-4746m
spec:
  deletionPolicy: Delete
  forProvider:
    assumeRolePolicyDocument: |
      {
        "Version": "2012-10-17",
        "Statement": [
          {
            "Effect": "Allow",
            "Principal": {
              "Federated": "arn:aws:iam::1234567890:oidc-provider/oidc.eks.eu-central-1.amazonaws.com/id/F62ABAD7D90D310485955C799BD64CE4"
            },
            "Action": "sts:AssumeRoleWithWebIdentity",
            "Condition": {
              "StringEqualsIfExists": {
                "oidc.eks.eu-central-1.amazonaws.com/id/F62ABAD7D90D310485955C799BD64CE4:sub": "system:serviceaccount:cnp-example:cnp-example"
              }
            }
          }
        ]
      }
    description: '[CROSSPLANE] [DYNAMODB] cnp-example-4746m'
    maxSessionDuration: 3600
    path: /cnp/cnp-example/
    tags:
    - key: CostReference
      value: F-330951-51-05
  providerConfigRef:
    name: iat-1234567890
---
apiVersion: identity.aws.crossplane.io/v1alpha1
kind: IAMPolicy
metadata:
  name: cnp-example-4746m
spec:
  deletionPolicy: Delete
  forProvider:
    description: '[CROSSPLANE] [DYNAMODB] cnp-example-4746m'
    document: |
      {
          "Version": "2012-10-17",
          "Statement": [
              {
                  "Sid": "ListAndDescribe",
                  "Effect": "Allow",
                  "Action": [
                      "dynamodb:List*",
                      "dynamodb:DescribeReservedCapacity*",
                      "dynamodb:DescribeLimits",
                      "dynamodb:DescribeTimeToLive"
                  ],
                  "Resource": "*"
              },
              {
                  "Sid": "SpecificTable",
                  "Effect": "Allow",
                  "Action": [
                      "dynamodb:BatchGet*",
                      "dynamodb:DescribeStream",
                      "dynamodb:DescribeTable",
                      "dynamodb:Get*",
                      "dynamodb:Query",
                      "dynamodb:Scan",
                      "dynamodb:BatchWrite*",
                      "dynamodb:CreateTable",
                      "dynamodb:Delete*",
                      "dynamodb:Update*",
                      "dynamodb:PutItem"
                  ],
                  "Resource": "arn:aws:dynamodb:eu-central-1:1234567890:table/cnp-example-4746m"
              }
          ]
      }
    name: cnp-example-4746m
  providerConfigRef:
    name: iat-1234567890
---
apiVersion: identity.aws.crossplane.io/v1beta1
kind: IAMRolePolicyAttachment
metadata:
  name: cnp-example-4746m
spec:
  deletionPolicy: Delete
  forProvider:
    policyArnRef:
      name: cnp-example-4746m
    roleNameRef:
      name: cnp-example-4746m
  providerConfigRef:
    name: iat-1234567890

last 3 tests took in my case: 46min, 30min, 41min
workaround: combining the policyARN from other strings

we are facing the same issue when we try to create mounttargets for a filesystem. had to wait almost 50 mins before the mounttargets were provisioned. is there a chance that this issue will be fixed soon?

Hey @mf-lit, I tried to reproduce the issue with a slightly modified version of your files. But all three resources became ready in less than a minute.
NAME                                              READY   SYNCED   AGE
role.iam.aws.crossplane.io/datasync-tg8zp-tv8hb   True    True     34s

NAME                                                              READY   SYNCED   ROLENAME   POLICYARN                                   AGE
rolepolicyattachment.iam.aws.crossplane.io/datasync-tg8zp-k7f7g   True    True     datasync   arn:aws:iam::609897127049:policy/datasync   34s

NAME                                                ARN                                         READY   SYNCED   AGE
policy.iam.aws.crossplane.io/datasync-tg8zp-m8jnx   arn:aws:iam::609897127049:policy/datasync   True    True     34s

I needed to update apiVersion and kind fields to match the latest CRDs. Here is the composition.yaml file I used:
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
  name: irsacomposite
spec:
  compositeTypeRef:
    apiVersion: crossplane.example/v1alpha1
    kind: IRSAComposite
  patchSets:
  - name: Metadata
    patches:
    - fromFieldPath: metadata.labels
      type: FromCompositeFieldPath
    - fromFieldPath: metadata.annotations
      type: FromCompositeFieldPath
  resources:
  - base:
      apiVersion: iam.aws.crossplane.io/v1beta1
      kind: Role
      spec:
        deletionPolicy: Delete
        forProvider:
          tags:
          - key: managed_by
            value: crossplane
        writeConnectionSecretToRef:
          namespace: crossplane
    connectionDetails:
    - fromFieldPath: status.atProvider.arn
      name: roleArn
      type: FromFieldPath
    patches:
    - patchSetName: Metadata
      type: PatchSet
    - fromFieldPath: spec.parameters.description
      toFieldPath: spec.forProvider.description
      type: FromCompositeFieldPath
    - fromFieldPath: spec.parameters.tags
      toFieldPath: spec.forProvider.tags
      type: FromCompositeFieldPath
    - fromFieldPath: metadata.uid
      toFieldPath: spec.writeConnectionSecretToRef.name
      transforms:
      - string:
          fmt: '%s-iamrole'
        type: string
      type: FromCompositeFieldPath
    - fromFieldPath: spec.claimRef.namespace
      policy:
        fromFieldPath: Required
      toFieldPath: spec.forProvider.assumeRolePolicyDocument
      transforms:
      - string:
          fmt: |
            {
              "Version": "2012-10-17",
              "Statement": [
                {
                  "Sid": "",
                  "Effect": "Allow",
                  "Principal": {
                    "Federated": "arn:aws:iam::123456789:oidc-provider/oidc.eks.eu-west-1.amazonaws.com/id/XXX"
                  },
                  "Action": "sts:AssumeRoleWithWebIdentity",
                  "Condition": {
                  "StringLike": {
                    "oidc.eks.eu-west-1.amazonaws.com/id/XXX:sub": "system:serviceaccount:%s:*"
                  }
                  }
                }
              ]
            }
        type: string
      type: FromCompositeFieldPath
  - base:
      apiVersion: iam.aws.crossplane.io/v1beta1
      kind: Policy
      spec:
        deletionPolicy: Delete
        forProvider: {}
        writeConnectionSecretToRef:
          namespace: crossplane
    patches:
    - fromFieldPath: spec.parameters.description
      toFieldPath: spec.forProvider.description
      type: FromCompositeFieldPath
    - fromFieldPath: spec.parameters.policydoc
      toFieldPath: spec.forProvider.document
      type: FromCompositeFieldPath
    - fromFieldPath: spec.parameters.policyname
      toFieldPath: spec.forProvider.name
      type: FromCompositeFieldPath
    - fromFieldPath: metadata.uid
      toFieldPath: spec.writeConnectionSecretToRef.name
      transforms:
      - string:
          fmt: '%s-iampolicy'
        type: string
      type: FromCompositeFieldPath
  - base:
      apiVersion: iam.aws.crossplane.io/v1beta1
      kind: RolePolicyAttachment
      spec:
        deletionPolicy: Delete
        forProvider:
          policyArnSelector:
            matchControllerRef: true
          roleNameSelector:
            matchControllerRef: true
        writeConnectionSecretToRef:
          namespace: crossplane
    patches:
    - patchSetName: Metadata
      type: PatchSet
    - fromFieldPath: metadata.uid
      toFieldPath: spec.writeConnectionSecretToRef.name
      transforms:
      - string:
          fmt: '%s-iamattach'
        type: string
      type: FromCompositeFieldPath
  writeConnectionSecretsToNamespace: crossplane

If anyone else has a recent example, I'm more than happy to try :)

Thanks for trying to reproduce this @ezgidemirel and sharing your results!
@mithie, if you have specific examples/yamls that you can share to help us reproduce this issue, that would be appreciated as well! :)


Adapted to latest changes in VL.Stride

This seems to compile fine and the renamings are in.
Also, VL.Stride is referenced as nuget in the project.
see: https://github.com/vvvv/VL.Stride/issues/356

Thanks for changes I will look into it


Front page search doesn't return results for "Precursors of human CD4 cytotoxic T lymphocytes identified by single-cell transcriptome analysis"

Front page search doesn't return results for "Precursors of human CD4 cytotoxic T lymphocytes identified by single-cell transcriptome analysis"

Software version - https://data.humancellatlas.org/ on 2020-06-03

The project https://data.humancellatlas.org/explore/projects/90bd6933-40c0-48d4-8d76-778c103bf545 with the title "Precursors of human CD4 cytotoxic T lymphocytes identified by single-cell transcriptome analysis" is offered as an autocomplete title on the front page and when selected should return the project selected on the main explore tab
e.g

But when you go to

You then get

You should be able to reproduce this by typing cytotoxic or cd4 into the front page search box
This is the URL which produced this behaviour
https://data.humancellatlas.org/explore/projects?filter=[{"facetName"%3A"projectTitle"%2C"terms"%3A["Precursors+of+human+CD4++cytotoxic+T+lymphocytes+identified+by+single-cell+transcriptome+analysis"]}]

Hi @lauraclarke,
I can see the Portal is not encoding the + correctly in the URL when it creates a link to the Browser.
I will let you know when we have fixed this issue.

Hi @lauraclarke looks like we forgot to tell you this is fixed. You can now to to the portal search and type in "cyto" and select a project or publication and the project will be found. This was an error encoding the "+" in the project name on in the URL on the portal.

Verified.


SyntaxError: Invalid or unexpected token

Trying the example in the readme and https://github.com/ebkalderon/tower-lsp/blob/master/examples/stdio.rs I get the following in VSCode with what I think is a minimal extension:
/home/tec/Desktop/TEC/Projects/available/test-lsp/target/debug/lspserver:1
ELF
^

SyntaxError: Invalid or unexpected token
    at Module._compile (internal/modules/cjs/loader.js:942:18)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1051:10)
    at Module.load (internal/modules/cjs/loader.js:862:32)
    at Module._load (internal/modules/cjs/loader.js:774:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1103:10)
    at internal/main/run_main_module.js:17:11
[Error - 1:22:17] Connection to server got closed. Server will not be restarted.

This is an excerpt from my my Cargo.toml
[dependencies]
env_logger = "0.8.2"
serde_json = "1.0.60"
tokio = { version = "0.2", features = ["full"] }
tower-lsp = "^0.13"

[[bin]]
name = "lspserver"
path = "src/server/main.rs"

Thanks for reporting this issue, @tecosaur! Unfortunately, I can't really replicate the problem on my side, since I don't know the VSCode language client you are using. The example stdio server seems to work perfectly fine under Neovim with coc.nvim as the language client. Could you possibly provide more details?
Also, that text output reminds me a bit of an ELF executable header, e.g. 7f 45 4c 46 02 01 01, or ELF in ASCII, almost as if the executable file is being piped in as raw bytes rather than being executed. Are you sure the client is set up correctly on your end?

The VSCode extension side looked a bit like this (I've since deleted my test of the example, this is for the minimal LSP server I was trying to make):
import * as path from 'path';
import { workspace, ExtensionContext } from 'vscode';

import { LanguageClient, LanguageClientOptions, ServerOptions, TransportKind } from "vscode-languageclient/lib/node/main";

let client: LanguageClient;

export function activate(context: ExtensionContext) {
  let serverModule = context.asAbsolutePath(path.join('server', 'orgserver'));
  // The debug options for the server
  let debugOptions = { execArgv: [] };

  // If the extension is launched in debug mode then the debug server options are used
  // Otherwise the run options are used
  let serverOptions: ServerOptions = {
    run: { module: serverModule, transport: TransportKind.stdio },
    debug: {
      module: serverModule,
      transport: TransportKind.stdio,
      options: debugOptions
    }
  };

  // Options to control the language client
  let clientOptions: LanguageClientOptions = {
    // Register the server for plain text documents
    documentSelector: [{ scheme: 'file', language: 'org' }],
    synchronize: {
      // Notify the server about file changes to '.clientrc files contained in the workspace
      fileEvents: workspace.createFileSystemWatcher('*.org')
    }
  };

  // Create the language client and start the client.
  client = new LanguageClient(
    'orgLanguageServer',
    'Org Language Server',
    serverOptions,
    clientOptions
  );

  // Start the client. This will also launch the server
  client.start();
}

export function deactivate(): Thenable<void> | undefined {
  if (!client) {
    return undefined;
  }
  return client.stop();
}

Hmm, it seems you were using vscode-languageclient incorrectly. I can get the stdio example to start fine in VSCode by making a few small changes to the code snippet above.
First, the initialization of the server is incorrect. It is being initialized as a NodeModule instead of a native Executable (see microsoft/vscode-languageserver-node source). The correct initialization should look like this instead:
let serverCommand = context.asAbsolutePath(path.join('server', 'stdio'));
let debugOptions = { env: { RUST_LOG: "trace" } };

// If the extension is launched in debug mode then the debug server options are used
// Otherwise the run options are used
let serverOptions: ServerOptions = {
  run: { command: serverCommand },
  debug: {
    command: serverCommand,
    args: [],
    options: debugOptions
  }
};

This explains the �ELF��� seen in the error message you originally posted. As I suspected, the Node runtime was indeed attempting to parse the native Rust executable as though it was a piece of JavaScript, failing with a SyntaxError due to the invalid characters.
By initializing the server as an external command instead, the example stdio server starts up normally. While I was at it, I also chose to define RUST_LOG=trace in the debugOptions in order to get full verbose tower-lsp logs in the VSCode output console, which helped me debug this next issue I ran into.
Second, I wasn't able to successfully trigger the server for org files. I think this is because I needed to register the file association for the org language identifier (docs) with the extension, but since I was feeling lazy, I changed the client initialization to trigger on plaintext instead:
// Options to control the language client
let clientOptions: LanguageClientOptions = {
  // Register the server for plain text documents
  documentSelector: [{ scheme: 'file', language: 'plaintext' }],
  synchronize: {
    // Notify the server about file changes to '.clientrc files contained in the workspace
    fileEvents: workspace.createFileSystemWatcher('*.clientrc')
  }
};

After making these changes, I created a dummy VSCode language client project by following this official guide and pasting the corrected code into lsp-sample/client/src/extension.ts. I opened the lsp-sample directory in VSCode, hit Ctrl+Shift+B to build the project, and started the "Launch Client" debug profile.
After opening up a new file and starting to type, I confirmed that the tower-lsp example server works as expected, as per the screenshot below.

Ultimately, it seems like the root cause of the problem was with the language client, not with tower-lsp. Let me know if you can reproduce this, @tecosaur! If there are no other outstanding issues, then we can safely close this ticket.

Ah! Now I feel a little silly :sweat_smile:. Thank you very much for your help on this! I'm a bit frantic at the moment but I'll give this a test as soon as I get a chance (may be a bit) and let you know if everything works :)

No worries! Whenever you happen to have a spare moment would be great. Feel free to ping me if there are any issues reproducing on your end or if something broke on the tower-lsp side in the process. :blush:

This thread hasn't seen any activity in nearly a year, and I'm pretty sure the issue is not caused by tower-lsp itself. I'm closing this ticket for now, but please feel free to leave a reply and we can reopen it if something's amiss. Hope you managed to resolve the issue on your end! :heart:

Thanks for the well wishes. I actually haven't got around to trying this again yet (I spread myself faaar to thin), but I'll let you know if anything goes wrong 🙂

Hmm, it seems you were using vscode-languageclient incorrectly. I can get the stdio example to start fine in VSCode by making a few small changes to the code snippet above.
First, the initialization of the server is incorrect. It is being initialized as a NodeModule instead of a native Executable (see microsoft/vscode-languageserver-node source). The correct initialization should look like this instead:
let serverCommand = context.asAbsolutePath(path.join('server', 'stdio'));
let debugOptions = { env: { RUST_LOG: "trace" } };

// If the extension is launched in debug mode then the debug server options are used
// Otherwise the run options are used
let serverOptions: ServerOptions = {
  run: { command: serverCommand },
  debug: {
    command: serverCommand,
    args: [],
    options: debugOptions
  }
};

This explains the �ELF��� seen in the error message you originally posted. As I suspected, the Node runtime was indeed attempting to parse the native Rust executable as though it was a piece of JavaScript, failing with a SyntaxError due to the invalid characters.
By initializing the server as an external command instead, the example stdio server starts up normally. While I was at it, I also chose to define RUST_LOG=trace in the debugOptions in order to get full verbose tower-lsp logs in the VSCode output console, which helped me debug this next issue I ran into.
Second, I wasn't able to successfully trigger the server for org files. I think this is because I needed to register the file association for the org language identifier (docs) with the extension, but since I was feeling lazy, I changed the client initialization to trigger on plaintext instead:
// Options to control the language client
let clientOptions: LanguageClientOptions = {
  // Register the server for plain text documents
  documentSelector: [{ scheme: 'file', language: 'plaintext' }],
  synchronize: {
    // Notify the server about file changes to '.clientrc files contained in the workspace
    fileEvents: workspace.createFileSystemWatcher('*.clientrc')
  }
};

After making these changes, I created a dummy VSCode language client project by following this official guide and pasting the corrected code into lsp-sample/client/src/extension.ts. I opened the lsp-sample directory in VSCode, hit Ctrl+Shift+B to build the project, and started the "Launch Client" debug profile.
After opening up a new file and starting to type, I confirmed that the tower-lsp example server works as expected, as per the screenshot below.

Fully fixed src/extension.ts

Thanks a lot. this saved ma so much times.


[feature req] Allow to open tab in side bar, using SHIFT+CLICK

Hi
Having a dual view of main view and sidebar view in logseq is great;
It would be nice to have this logic also applicable using the TAB list.
For instance : I have a sticky tab. If I want to open it in the main page I click on it (as today). If I wish to open it on the sidebar, I'd SHIFT+CLICK on it (new feature)

I would love to have this feature as well :)


Remove quote requirement for TagHelper directives.

@addTagHelper, @removeTagHelper and @tagHelperPrefix values are all written without quotes now.
Updated the ChunkGenerators to be in-line with other ChunkGenerators in the system now that they don't have vastly different values than what their corresponding Spans have.
Split AddOrRemoveTagHelperChunkGenerator into two smaller ChunkGenerators to stay consistent with other generators.
Created a unified TagHelperDirectiveChunkGenerator so we can unify parsing logic when dealing with TagHelperDirectives. A prime example of this is the work done in TagHelperDirectiveSpanVisitor.
Removed error cases introduced by having quotes around directives.
Updated code generation logic to not generate line pragmas (they should never have been generated to start with) and more specifically only map to the inner string that's generated. Without this change directive mappings would be offeset by a generated quote.

Update tests to not require quotes for TH directives.

Updated .cshtml files to not provide quotes for the various TagHelper directives.
Updated TagHelper directive parsing tests. This also involved removing several tests that expected errors which no longer occur since we don't have to ensure quotes are balanced.
Updated line mappings which significantly changed due to us no longer generating line pragmas at design time for TagHelper directives.

Note: I did not document the public API surface for core Razor bits. We decided /// documentation was not important for core Razor due to its lack of direct usage by users.
#561

/cc @dougbu @ajaybhargavb @pranavkm
I'd recommend initially looking at the src based commit to avoid the masssses of test changes :smile:

:watch:

:up: :date:

:watch: mostly for a couple of open questions.

:up::date: And answered comments

:shipit: once reaction work is done -- in MVC, MusicStore, and probably Entropy.


Query Key set, like store.keySet()

Is there a function or a property to retrain the entire key set?
Maybe the method could be store.keySet()

No such method yet, contributions are welcome!


Swift Package Manager support?

Lots of projects are deprecating CocoaPods.  Swift Package Manager in addition to Carthage would be most welcome.

I would like to bump this up since SPM support for all Apple platforms has been announced and the time is right to start using it if not done before.

Looking forward to seeing that feature as well.

+1

PR https://github.com/iziz/libPhoneNumber-iOS/pull/288 should solve this


[BUG] ">>" - Syntax error that isn't an error

struct ModelUniform {
    model: array<mat4x4<f32>>,
};

It outputs WGSLTokenType.GREATER_THAN expected, got '>>' at the >>
Inserting a space in-between the 2 > characters, the error disappears.

I'll take a look and see what I can come up with.

This is turning out to be a nasty one to fix. The lexer is treating the >> as a single token, but when I I take out the token and replace it with two > tokens in the grammar this makes other syntax behave a bit oddly. I am still looking into it.

This should be fixed in the next release. I will hopefully be finalizing the fix some time today, and then it will probably take a couple of days for Jetbrains to approve the update

I have submitted a new release to the Jetbrains store. It should become available soon. Let me know if this solves your issue.

This should be available in the Jetbrains marketplace now. Let me know if this works for you

This should be available in the Jetbrains marketplace now. Let me know if this works for you

It works. Thank you so much.

Excellent. It was a tricky one.


misses caps lock keypresses on sierra

hi
my system is sierra 10.12.5 installed on dell precision 7710 laptop
keyboard works fine, but when i start karabiner, caps lock stops to work normally
it misses near 70% of keypresses (i've tried karabiner-eventviewer).
other keys works without a problem.
if i quit karabiner-elements - caps lock works normally.

after updating to latest voodoops2controller now i have many keydown events on single remapped caps lock click.


no_dns_just_forward_to_parent not work for Hit-Stale update.

With no_dns_just_forward_to_parent enabled, the HandleCacheOpenReadHitFreshness is always try to update the Hit-Stale objects by OSDNSLookup.
By comparing with the HandleCacheOpenReadMiss, it will call the find_server_and_update_current_info to update the server info and send the request via parent proxy.

This looks to be a duplicate for: #2376


Add recovery task assignment service

Adds the recovery task assigner service

This will be slightly changed after #150 is merged, closing for now.


Update enable-support-tls-environment.md

@przlplx : Thanks for your contribution! The author(s) have been notified to review your proposed change.


MF-928 - Change CoAP lib

What does this do?
This pull request changes the lib used for CoAP protocol
Which issue(s) does this PR fix/relate to?
This pull request resolves #928 and partially #1144.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
No, tests will be added in a separate pull request.
Did you document any new/modified functionality?
Yes.
Notes
The authorization option is changed to auth to be shorter.

Codecov Report

Merging #1233 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   76.18%   76.18%
=======================================
  Files         106      106
  Lines        6983     6983
=======================================
  Hits         5320     5320
  Misses       1278     1278
  Partials      385      385

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18f2c1...80d32fe. Read the comment docs.


Test phpcs

PHP Syntax Errors Found
Scan performed on the code at commit bdb87eb2399f4517e61204d49f8e855d2213d579 (view code).

Error: syntax error, unexpected }
https://github.com/PureStorage-OpenConnect/pso-explorer-container/blob/bdb87eb2399f4517e61204d49f8e855d2213d579/app/Pso.php#L2077


Removed log handler and fixed yocto build.

Codecov Report

Merging #24 into master will increase coverage by 1.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   90.61%   92.08%   +1.46%
==========================================
  Files           4        3       -1
  Lines        1759     1731      -28
  Branches      169      163       -6
==========================================
  Hits         1594     1594
+ Misses         69       41      -28
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931b7a5...d946986. Read the comment docs.


[stable/traefik] Enable the dashboard without ingress

When enabling the dashboard in the Traefik chart (setting dashboard.enabled to True), an ingress rule is always created to allow the dashboard to be available externally. As we access the dashboard via Kubernetes port forwards, I would like the creation of this rule to be skipped if we set a value like dashboard.create_ingress to False. The default values.yaml would set this to true to match the existing behaviour.

Did this end up being applied? I find myself in the same situation

No it hasn't made it through yet unfortunately.


govc command mentioned in document https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/kubernetes-volumes.html is not working

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

govc command mentioned in https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/kubernetes-volumes.html is throwing error:
https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/kubernetes-volumes.html has two  procedure to create vmdk
where in first one works (vmkfstools -c 2G /vmfs/volumes/datastore1/volumes/myDisk.vmdk)
govc datastore.disk.create -ds datastore1 -size 2G volumes/myDisk.vmdk is not working
details
GOVC_URL="vcsaesplabs.apac.avaya.com"
export GOVC_USERNAME="username"
export GOVC_PASSWORD="Password"
export GOVC_INSECURE="1"
if i list the datastore with bellow command I get the proper datastore
govc ls /Pune_Shared/datastore
/Pune_Shared/datastore/SharedVol_Nimble_Kube
/Pune_Shared/datastore/Pune_Shared_Cluster1_Storage
govc datastore.disk.create -ds Pune_Shared_Cluster1_Storage -size 2G volumes/myDisk.vmdk
govc: default datacenter resolves to multiple instances, please specify
govc datastore.disk.create -ds SharedVol_Nimble_Kube -size 2G volumes/myDisk.vmdk
govc: default datacenter resolves to multiple instances, please specify
Should be able to create vmdk file using govc:
**execute govc command mentioned in document **:
Anything else we need to know?:
Environment:

Kubernetes version (Kubernetes version Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-09T18:02:47Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-09T17:53:03Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
Cloud provider or hardware configuration: vmware
OS "Red Hat Enterprise Linux Server"
VERSION="7.4 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VARIANT="Server"
VARIANT_ID="server"
VERSION_ID="7.4"
PRETTY_NAME="Red Hat Enterprise Linux Server 7.4 (Maipo)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.4:GA:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
Kernel Linux flexmaster191 3.10.0-693.el7.x86_64 #1 SMP Thu Jul 6 19:56:57 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux
Install tools:
Others:

@GajaHebbar
You can resolve above issue with specifying data-center.
export GOVC_DATACENTER=dc-name

@divyenpatel  👍 Thank you
I could create
govc datastore.disk.create -ds barndesxi11_datastor02_VM -size 2G volume/myDisk.vmdk
[19-09-18 11:48:29] Creating [barndesxi11_datastor02_VM] volume/myDisk.vmdk...OK
I am facing
Warning  FailedAttachVolume     1s (x3 over 11s)  attachdetach-controller                AttachVolume.Attach failed for volume "pv0001" : Failed to add disk 'scsi0:1'.
when I used the vmdk created by above command.
This is the same setup, where we have created dynamic provisioning.
PV
apiVersion: v1
kind: PersistentVolume
metadata:
name: pv0001
spec:
capacity:
storage: 2Gi
accessModes:
- ReadWriteOnce
persistentVolumeReclaimPolicy: Retain
vsphereVolume:
volumePath: "[barndesxi11_datastor02_VM] volume/myDisk.vmdk"
fsType: ext4
PVC
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: pvc0007
spec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 2Gi
pod
apiVersion: v1
kind: Pod
metadata:
name: pvpodd
spec:
containers:

name: test-container
image: wardviaene/k8s-demo
ports:

name: nodejs-port
containerPort: 3000
volumeMounts:
name: test-volume
mountPath: /testing
volumes:

name: test-volume
persistentVolumeClaim:
claimName: pvc0007

@divyenpatel  retied again, and worked.
IS there any tag to specify fsType when using govc?
govc datastore.disk.create -ds barndesxi11_datastor02_VM -size 2G volume/newdisk.vmdk
above line creates only ext4 type.

file system types can be specified in the storage class. You can not specify file system type while creating VMDK.
When this VMDK is attached to the node VM, kubelet running in worker nodes, checks file system on the device, if not present, specified file system will be created after mounting device.

So if i don't have a default storage class and use
apiVersion: v1
kind: PersistentVolume
metadata:
name: pv0001
spec:
capacity:
storage: 2Gi
accessModes:

ReadWriteOnce
persistentVolumeReclaimPolicy: Retain
vsphereVolume:
volumePath: "[barndesxi11_datastor02_VM] volume/myDisk.vmdk"
fsType: ext3

I should be getting ext3, am i right?

If file system is not specified then default is ext4
https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/vsphere_volume/vsphere_volume.go#L364


Smiting ghost with chessboard produces odd results

Description
Smiting ghost with chessboard produces odd results. I dunno. You still can follow mobs on Warp list and random entities in your view. Your view will not use grid's angle. You cannot move, only teleport with Follow/Warp. If you reconnect, you get correct angle, but still cannot move and movement attempt will be mispredicted.
Reproduction

Annoy(?) Pancake by orbiting their ghost
Be chessboard smited, as observer ghost
Witness odd things

Screenshots

Additional context
Probably should introduce feature for admins to make self completely intangible, when I follow admins as observer, I do it to watch the funny.

This is a smite, it breaks the game to some extent and it's an administrative issue that they applied it to a ghost.


Nested  (with "first-reference-note-number" in it) ignored in 'zeitschrift-fur-kunstgeschichte.csl'

After https://github.com/jgm/pandoc-citeproc/commit/c0c4f0665a65ff1561c3f7dc1fe98c6bac302c4f, to my knowledge there remains only one difference in the output of two would-be-identical docx documents generated by pandoc & pandoc-citeproc and LibreOffice writer & Zotero:
After the first (and full) citation of a given work, on subsequent occasions the style prints a short citation form with authors' names and year (unless it's an 'ibid'). In addition to that, it points, in parentheses, to the footnote where the cited work was cited for the first time in the document.
Such a citation footnote would look like
Knuth 1986 (as note 1).
In the CSL style's code, this should be achieved in lines 151-154:
<group delimiter=" " prefix="(" suffix=")">
  <text term="note"/>
  <text variable="first-reference-note-number"/>
</group>

In pandoc-generated document, none of the elements listed in this group appear, and the footnote from above will be
Knuth 1986.,
which means that the other elements in the <group> one level further up above are being printed. So I suppose it is the inner group as a whole that poses a problem?
(I myself do not want to use this specific feature, and in my use case I would edit the style and take it out if it worked correctly. But since it appears to be a bug, I thought documenting it here couldn't hurt.)

This is a duplicate of #31 - first-reference-number isn't yet supported.

Should now be fixed...


Fuzzing pal_MemFree symbol not found: Examples fuzzing?

Hello!
I am trying to reproduce some of the paper fuzzing results. Unfortunately I have not much luck with getting any fuzzing to work.
AFL++ version v3.13C
Running FirmWire inside Docker container.
Using the following command:
AFL_DEBUG=1 afl-fuzz -i in -o out -U -- ./firmwire.py --fuzz gsm_cc --fuzz-input @@ ShannonFirmware/modem_files/CP_G973FXXU9FUCD_CP18513696_CL21324211_QB39036441_REV01_user_low_ship.tar.md5.lz4
I get:
[ERROR] firmwire.vendor.shannon.machine: Unable to resolve requested dynamic modkit symbol pal_MemFree [ERROR] firmwire.vendor.shannon.machine: Failed to inject task into OS
When checking, it indeed seems like the firmware itself is missing these symbols.  I got the firmware from https://github.com/grant-h/ShannonFirmware.
Removing the registration in shanon.h works, but breaks the emulation. (Setting AFL_FORKSRV_INIT_TMOUT very high does not help, it hangs at [INFO] firmwire.hw.peripheral.ShannonSOCPeripheral.SOC: CHIP_ID read: 50000000)
What are the commands used in the paper? Any help would be appreciated.
Thank you very much!

Hi,
Thanks for reporting. The modem files themselves don't have any symbols, we use patternDB to reconstruct them.
pal_memFree was added after the initial release, together with some changes in the injected tasks. I just pushed 2d9f4c503d1caa5f021be167273e354b1071bab1, which should fix this.
Locally, when I run python3 -u ./firmwire.py ./modem_files/CP_G973FXXU9FUCD_CP18513696_CL21324211_QB39036441_REV01_user_low_ship.tar.md5.lz4 --fuzz-triage gsm_cc --fuzz-input /tmp/a the fuzzing input is taken and executed as expected.
Regarding the commands in the paper: Unfortunately, we still need to hold back from publishing the experiment code, which is not by our choice. However, the command line we used for fuzzing was:
$ AFL_NO_UI=1 AFL_FORKSRV_INIT_TMOUT=100000 \
  timeout 86400 "$EXPERIMENT_ROOT/AFLplusplus/afl-fuzz" \
  -i in  -o out -t 10000 -m none -M "main" -U -- ./firmwire.py --fuzz gsm_cc --fuzz-input @@  --consecutive-ports [port_base] --restore-snapshot [snapshot] [image]

it seems afl-fuzz works only when --fuzz-triage is used, weirdly, but with --fuzz it remans stuck for mor than the TMOUT=100000 and dies

Did you start fuzzing from a snapshot, as in my CLI example above, or just trying to run it from the very beginning?
In fuzz mode, we disconnect most of the avatar orchestration, which can result into problems during the bootup of some images.

Similar Issue was in #19, with the following solution: https://github.com/FirmWire/FirmWire/issues/19#issuecomment-1297414972
Hence, closing this issue for now. If the problem still exists after following the instructions above, feel free to reopen/post below.


Add extra parameters to HTML tag and convert data tags for bootstrap_…

…button and bootstrap_label
Implements #376
I made a possibly controversial decision when I implemented this - parameters that start with "data_" get their underscores converted to hyphens. This is because data attribute names must start with the string "data-", but anything that fits that is not a valid identifier and can't be passed from Django templates.
On the other hand, blind conversion might be a bad idea? It would, however, be more consistent.
In any case, making it consistent is a matter of simplifying the code, so I'm just going to leave it that way, and am open to changing it.

Coverage increased (+0.2%) to 85.146% when pulling 8ed9bf892f49dfa5da602f4505fe4c001966c432 on ralokt:master into e80c73933f8e29d633424328ec6fae4fc5e637fc on dyve:master.

Thanks. This would be a precedent for other functions, and I think it's too big to do in the final release(s) / stage(s) of this package.


[Bug]-last not returning the last restored file correctly

Environmental information

#### PowerShell version:

Name                           Value
----                           -----
PSVersion                      5.1.14393.3471
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3471
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

#### dbatools Module version:

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.101\dbatools.psd1
Version : 1.0.101

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.51\dbatools.psd1
Version : 1.0.51

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.34\dbatools.psd1
Version : 1.0.34

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\0.9.803\dbatools.psd1
Version : 0.9.803

Name    : dbatools
Path    : C:\Program Files\WindowsPowerShell\Modules\dbatools\0.9.753\dbatools.psd1
Version : 0.9.753

# Replace with output of Get-Culture

SQL Server:

Microsoft SQL Server 2014 (SP3-CU4) (KB4500181) - 12.0.6329.1 (X64)
	Jul 20 2019 21:42:29
	Copyright (c) Microsoft Corporation
	Standard Edition (64-bit) on Windows NT 6.3 <X64> (Build 9600: ) (Hypervisor)

/* REPLACE WITH output of @@LANGUAGE */

Report

Host used

[X] powershell.exe
[X] ISE
[ ] VS Code
[ ] Other (please specify)

If anything other than powershell.exe was used, please confirm that you can duplicate the issue with powershell.exe

[ ] Still buggy in powershell.exe

Errors Received

Steps to Reproduce
All the code is shown below, It appears there's something with the internals of how the table being used is populated meaning that the differential backup can have a later id even though it was restored earlier...most odd.
Restore a full
Restore a diff
Restore a number of logs
check last restore info, for some dbs it will be incorrect.
Expected Behavior
I expected the last restored file to be shown but instead the last restored differential was shown.
Actual Behavior
Get-DbaDbRestoreHistory -SqlInstance $SqlInstance -Database $Database -last
Returns
BackupFinishDate : 03/03/2020 07:01:45
ComputerName :
Database :
Date : 03/03/2020 12:52:37
From : \SQLBackups\Diff_DIFF_20200303_070123.bak
InstanceName : MSSQLSERVER
RestoreType : Differential
...
Get-DbaDbRestoreHistory -SqlInstance $SqlInstance -Database $Database -since (Get-Date).AddDays(-1)
...
Username : username
BackupFinishDate : 03/03/2020 07:21:01
ComputerName : computer
Database : db
Date : 03/03/2020 13:22:03
From : B:\SQLBackups\inst\db\LOG\db_20200303072101.trn
InstanceName : MSSQLSERVER
RestoreType : Log
SqlInstance : computer
To : D:\SQLLogs\db_Primary.ldf
Username : username
BackupFinishDate : 03/03/2020 07:22:02
ComputerName : computer
Database : db
Date : 03/03/2020 13:22:11
From : B:\SQLBackups\inst\db\LOG\db_20200303072201.trn
InstanceName : MSSQLSERVER
RestoreType : Log
SqlInstance : computer
To : D:\SQLLogs\db_Primary.ldf
Username : username
but to spin it a bit more, if we look at the last 7 days then the diff comes out last in the list, which is odd as it was restored today :D
Get-DbaDbRestoreHistory -SqlInstance $SqlInstance -Database $Database -since (Get-Date).AddDays(-7)
...
SqlInstance : inst
To : D:\SQLLogs\db_Primary.ldf
Username : user
BackupFinishDate : 03/03/2020 07:22:02
ComputerName : inst
Database : db
Date : 03/03/2020 13:22:11
From : B:\SQLBackups\isnt\db\LOG\db_20200303072201.trn
InstanceName : MSSQLSERVER
RestoreType : Log
SqlInstance : inst
To : D:\SQLLogs\db_Primary.ldf
Username : user
BackupFinishDate : 03/03/2020 07:01:45
ComputerName : inst
Database : db
Date : 03/03/2020 12:52:37
From : \inst\SQLBackups\isnt\db\Diff\isnt_db_DIFF_20200303_070123.bak
InstanceName : MSSQLSERVER
RestoreType : Differential
SqlInstance : inst
To : D:\SQLData\db_Primary.mdf, D:\SQLData\db2.ndf, D:\SQLLogs\db_Primary.ldf
Username : user
for now, to get the latest, I'm using:
Get-DbaDbRestoreHistory -SqlInstance $SqlInstance -Database $Database -since (Get-Date).AddDays(-7) | Sort-Object Date | Select -Last 1 #-Last
which gives me the correct results :)
I'm looking into the function and playing around with different methods of getting the correct result so I'll update shortly.
(https://github.com/sqlcollaborative/dbatools/issues/4688)

Please add a title.

I noticed you have lots of older versions of the module installed. Is there a particular reason you are keeping the older versions? If not, please see dbatools.io/cleanup.


Sysl openapi importer created sysl files do not work with codegen afterwards

There are a couple of issues that realated to openApi importer:

return seems not working properly.
Code snippet as follow:

        "responses": {
          "200": {
            "description": "Output type",
            "headers": {},
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "SENSITIVE INFO OMMMITED"
                }
              }
            }
          },
          "204": {
            "description": "No Content"
          },
          "4XX": {
            "description": "Client-Side Error"
          },
          "5XX": {
            "description": "Server-Side Error"
          }
        },

The above in the old sysl created:
# sysl file
    /case/{CaseId<:string}:
        GET ?LegalEntityId=string&FormId=string&Editable=bool?:
            return ok <: LegalEntityResultDetail

# serviceinterface.go
type GetBffLegalentityClient struct {
	GetLegalentity func(ctx context.Context, req *fenergo.GetLegalentityRequest) (*fenergo.LegalEntityResultDetail, error)
}

the master brunch compiled version got the following created:
# sysl file
    /case/{CaseId<:string}:
        GET ?LegalEntityId=string&FormId=string&Editable=bool?:
            return error
            return ok
            return ok <: LegalEntityResultDetail

# serviceinterface.go
type GetBffLegalentityClient struct {
	GetLegalentity func(ctx context.Context, req *fenergo.GetLegalentityRequest) (*fenergo.LegalEntityResultDetail, *fenergo.Ok, error)
}

unkown binanry format

gosysl import --format openapi -i model/xxx.json -a xxx -p xxx -o model/xxx.sysl
ERRO[0000] unknown format 'binary' being used, ignoring...

the above error output is from:
      "DocumentUploadFormValues": {
        "title": "DocumentUploadFormValues",
        "type": "object",
        "properties": {
          "documentPurpose": {
            "type": "string"
          },
          "documentCategory": {
            "type": "string"
          },
          "documentType": {
            "type": "string"
          },
          "documentName": {
            "type": "string"
          },
          "document": {
            "type": "string",
            "format": "binary"
          }
        }
      },

thanks for the detailed report, looking into it now

@suipinglu I don't think either of those points are issues,

Looks like its just added the second success condition (the 204), this is correct (even if not named very nicely)

is that error stoping the field getting added to the generated code?

Ping said it could be closed.


fix for propertyPane Action for run keyword

Description
Property Pane goes into bad state, when adding anything with run into other text fields, this refines the checks for the specific intended case
Fixes #6095
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
UI verification
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/6095_propertyPane_showMessage

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
51.5 (-0.01)
33.45 (-0.03)
29.3 (-0.01)
52.12 (-0.01)

:red_circle:
app/client/src/components/editorComponents/ActionCreator/index.tsx
49.62 (0)
10 (-0.81)
56.52 (0)
48.84 (0)

:red_circle:
app/client/src/utils/helpers.tsx
53.05 (-1.83)
26.03 (-4.11)
21.43 (-3.57)
46.51 (-1.55)

/ok-to-test sha=e80e44b

/ok-to-test sha=c30239c

@rahulramesha Working fine on deploy preview.


contour label does not work well in geographic projections

Description
I wanted to plot a contour map in a geographic projection, and the plotting went just fine. However, when I tried to add labels to contours, the results were quite confusing.
Steps to reproduce
A "Minimal, Complete and Verifiable Example" will make it much easier for maintainers to help you.
# your code here
# we should be able to copy-paste this into python and exactly reproduce your bug

import proplot as pplt
import pandas as pd
import numpy as np

state = np.random.RandomState(51423)
data = state.rand(6, 6)
data = pd.DataFrame(data, index=pd.Index(['a', 'b', 'c', 'd', 'e', 'f']))

lat = np.linspace(40, 5, 6)
lon = np.linspace(90, 135, 6)

fig = pplt.figure(
    refwidth = 4.5,
    )
ax = fig.subplots(
    proj = 'cyl',
    )
ax.contour(
    lon,
    lat,
    data,
    labels = True,
    )
ax.format(
    lonlim = (90, 135),
    latlim = (5, 40),
    lonlines = 15,
    latlines = 10,
    lonlabels = 'b',
    latlabels = 'l',
    )

This typically happens when the axes limits change after clabel is called

This typically happens when the axes limits change after clabel is called

Thank you for your tip.
Based on your tip, I set format before displaying, and problem solved, thank you !

Figured it out -- this is related to proplot's default use of a global map extent, compared to cartopy's default use of map extents that conform to plotted content.
To get the right label spacing while still setting longitude/latitude extents after calling clabel, you can revert to cartopy's default behavior using pplt.rc['geo.extent'] = 'auto' or by passing fig.subplots(..., extent='auto') in the "dev" version (note this was pplt.rc['cartopy.autoextent'] = True and fig.subplots(..., autoextent=True) in v0.9.X, but has been changed -- the old setting/keyword raise a warning).
Here's with initial global extent:
import matplotlib.pyplot as pet
import proplot as pplt
import numpy as np
state = np.random.RandomState(51423)
data = state.rand(6, 6)
lat = np.linspace(40, 5, 6)
lon = np.linspace(90, 135, 6)
fig = pplt.figure(width=5)
ax = fig.subplots(proj='cyl', extent='globe', land=True)
m = ax.contour(lon, lat, data)
ax.clabel(m, inline_spacing=0)
ax.set_extent([90, 135, 5, 40])

And here's with "auto" extent:
import matplotlib.pyplot as pet
import proplot as pplt
import numpy as np
state = np.random.RandomState(51423)
data = state.rand(6, 6)
lat = np.linspace(40, 5, 6)
lon = np.linspace(90, 135, 6)
fig = pplt.figure(width=5)
ax = fig.subplots(proj='cyl', extent='auto', land=True)
m = ax.contour(lon, lat, data)
ax.clabel(m, inline_spacing=0)
ax.set_extent([90, 135, 5, 40])

I think a workaround might be to delay this call to set_global() until the figure gets drawn, and then only call it if the user has not explicitly updated the longitude/latitude limits:
https://github.com/proplot-dev/proplot/blob/0e18babf43193a44f038928f008e873ad95f271c/proplot/axes/geo.py#L944-L952


Devspace  not visible even after successful login

i have a dev space which can be seen when logged in browser but not visible in vscode extension

Hi @aravindmuthyala, which browser do you have set as default? I have brave, and I have the same issue, but when I set chrome as the OS default browser it works, this is an old issue that for some reason does not get fixed.

Hi,
I did the same changed my browser to chrome after couple of tries it worked.
Thanks,
Aravind
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Firas Jelassi @.>
Sent: Friday, October 25, 2024 8:24:40 PM
To: SAP/app-studio-toolkit @.>
Cc: Aravind Muthyala @.>; Mention @.>
Subject: Re: [SAP/app-studio-toolkit] Devspace not visible even after successful login (Issue #342)
Hi @aravindmuthyalahttps://github.com/aravindmuthyala, which browser do you have set as default? I have brave, and I have the same issue, but when I set chrome as the OS default browser it works, this is an old issue that for some reason does not get fixed.
—
Reply to this email directly, view it on GitHubhttps://github.com/SAP/app-studio-toolkit/issues/342#issuecomment-2438040515, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXHLJEUVAAG6UVJTRWDXOS3Z5JLTBAVCNFSM6AAAAABQMFAZ3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGA2DANJRGU.
You are receiving this because you were mentioned.Message ID: @.***>


chore: bdd-spring-1573225529 to 0.0.1

chore: Promote bdd-spring-1573225529 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[JA NumberWithUnit] Japanese Dimension Support

All test cases pass.

Modified BaseCJKNumberParser to support parsing of numbers in the form "一九九九" (1999).
Modified NumberWithUnitParser to support parsing of split units like "秒速100メートル" ('speed per second 100 meters' = 100m/s).

Modified test cases:

"キロ" (kilo) was used in various test cases to indicate either "kilometer" or "kilogram". It has been replaced with the unambiguous expressions "キロメートル" (kilometer) and "キロメートル" (kilogram).

Is the interpretation for "キロ" by itself usually one or the other? Or somewhat equally frequent?

Is the interpretation for "キロ" by itself usually one or the other? Or somewhat equally frequent?

Equally frequent, it can be both and disambiguated by context ("I bought 2 kilos of oranges" (kg), "Next exit is in 2 kilos" (km)).

Is the interpretation for "キロ" by itself usually one or the other? Or somewhat equally frequent?

Equally frequent, it can be both and disambiguated by context ("I bought 2 kilos of oranges" (kg), "Next exit is in 2 kilos" (km)).

In this case, please add the ambiguous cases as currently NotSupported. Later, once DateTime has progressed, let's try to add support by checking some word in the immediate context of the mention for kilo, ok?

Is the interpretation for "キロ" by itself usually one or the other? Or somewhat equally frequent?

Equally frequent, it can be both and disambiguated by context ("I bought 2 kilos of oranges" (kg), "Next exit is in 2 kilos" (km)).

In this case, please add the ambiguous cases as currently NotSupported. Later, once DateTime has progressed, let's try to add support by checking some word in the immediate context of the mention for kilo, ok?

ok, re-added original test cases.


Origin of ${docker.host}

Quick question: When I run the plugin in debug mode, I see this:
<dockerHost>${docker.host}</dockerHost>
I have not configured anything for {docker.host}, so can you tell me what the value is that gets passed in here by default? It wasn't clear to me from the documentation or the source. This is running on a Windows 10 machine.
Thanks.

@neilchaudhuri : Plugin tries to detect unit socket or windows pipe as you can see here: https://github.com/fabric8io/docker-maven-plugin/blob/master/src/main/java/io/fabric8/maven/docker/access/DockerConnectionDetector.java#L123
Bdw, you're on wrong repository. Maybe you were looking for https://github.com/fabric8io/docker-maven-plugin . This is Kubernetes Maven Plugin(it includes docker maven plugin though).

Thanks so much for pointing me to the code, and apologies for posting to the incorrect repo.


For @types installing quickfix, only activate for implicit-any module

Should fix the immediate issue in #19378. @mjbvz was getting an error since "lodash" wasn't resolving at all since he had classic module resolution set. Now we would not provide the codefix in that case (although we would still provide the refactoring).

This is the opposite of my proposal on #19378. I believe install @types is a quick fix. It addresses a problem in your code even if there is no actually error currently. Refactoring to me suggests code motion
Instead, I propose we remove this action from refactorings and for now leave the quick fix implementation to only work when there is a diagnostic  error in the code

@mhegazy Should we just disable the refactoring in release-2.6?

This is the opposite of my proposal on #19378. I believe install @types is a quick fix. It addresses a problem in your code even if there is no actually error currently. Refactoring to me suggests code motion

I am not sure i understand this statement..
the way it is wired today, a quick fix is attached to a diagnostic message, and refactoring is one that is not attached to a diagnostic message.
our design should make it such that the quick fix is only shown if there an error, and the refactoring should be shown otherwise. I am not sure i understand the problem in https://github.com/Microsoft/TypeScript/issues/19378 to be able to comment on either proposed solutions.

I can understand this distinction on implementation side of things but I'm coming at the problem from a ux/client perspective.
Right now, VS Code presents both refactorings and quick fixes using the same lightbulb/code actions UI. However this may not always be the case. We have talked of creating a separate refactoring menu for example, and have also talked about changing the semantics of when refactorings are shown in the lightbulb menu.
I believe TypeScript's concept of refactorings and quick fixes should correspond with what a user would understand these to be in their editor: a refactoring is a code action that changes your code's structure while a quick fix is a code action that addresses some sort of problem with the code. Classifying install @types as a refactoring breaks this model. It is a quick fix because it addresses a problem in your code, and should grouped as such

let's get this into release-2.6 as well.


StepwisePlanner -- Action regex doesn't support actions that have braces in the string values

@lemillermicrosoft  : can you update target dates for this issue, dates are in the past.


bindings(Python): Finally decide on package name for PyPI publishing

As the Python bindings are planned to be published to PyPI, the name of the package has to be finalized. Currently, this is set to imap-codec (which seems to still be available).

@duesee If you are fine with imap-codec for the name, feel free to push a imap-codec-python/v0.1.0-dev1 tag to trigger the first CI publish. Then, we know that the release flow works as intended and claim the package name.


Add helm patch to allow push to insecure OCI registry

Issue #, if available: https://github.com/helm/helm/issues/6324
Description of changes:
Adding commits from this upstream PR: https://github.com/helm/helm/pull/10408/commits
Tested locally and helm pull/push works as expected
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/helm-tooling-presubmit

/test helm-tooling-presubmit


disableSorting doesn't work

Hello,
It seems like disableSorting is not working. I'm following the example code and when setting disableSorting={true} nothing changes. The only way I've found for disabling the sorting is to remove {...this.props.sortHandlers} from the row component. I've only tried this on Android.
Any ideas? Thanks in advance!

hi,
I have same problem.

@gsavvid, @SmallMouth , can you try with the latest version? If it still doesn't work, could you please submit some example code demonstrating the problem? I've added a button for disabling and enabling sorting to the Sortable example app in this branch.
Works for me.

It does not work for me either.  I can't share a code sample right this minute, but I'm going to take a look at the source code when I get a chance.  I'm in iOS, and I'm not spreading the entire sortHandler out in the row component's touchable highlight.

@chetstone
on this issue , I use version 0.1.1 and it does not work. now I update to version 0.2.2, it can work!!!
my example code :

v0.1.1
 fail
v0.2.2
 pass

Cool! Thanks for reporting!


Fantastic game!

Hi!
I would like to run the game first on local after on a hosted server :)
I use MAMP on Os. With terminal I started the process

npm i
npm run start

and this start to run. After they display some error and like go in "pause".
Can you help me?
Thanks and sorry for my english 👍
MacBook-Pro-di-Valley:htdocs valley$ npm i
npm run start
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>No repository field.
MacBook-Pro-di-Valley:htdocs valley$ npm run start

><EMAIL_ADDRESS>start /Applications/MAMP/htdocs
> npm run dev-server

><EMAIL_ADDRESS>dev-server /Applications/MAMP/htdocs
> DEV_SERVER=true webpack-dev-server --hot --inline --progress

 10% building modules 1/1 modules 0 active                                    x Project is running at http://localhost:4999/
webpack output is served from /static/
Content not from webpack is served from ./build
404s will fallback to /static/
 10% building modules 3/7 modules 4 active ...s/node_modules/webpack/hot/emitter.jsts-loader: Using<EMAIL_ADDRESS>and /Applications/MAMP/htdocs/tsconfig.json
Hash: a03d97d3f5ae574bbbea                                                    / Version: webpack 2.5.1
Time: 24652ms
      Asset       Size  Chunks                    Chunk Names
  bundle.js    3.79 MB       0  [emitted]  [big]  main
favicon.png    3.29 kB          [emitted]
 index.html  445 bytes          [emitted]
chunk    {0} bundle.js (main) 1.44 MB [entry] [rendered]
    [7] ./~/react/react.js 56 bytes {0} [built]
   [26] ./src/ui/utils/style.ts 726 bytes {0} [built]
  [153] (webpack)/hot/emitter.js 77 bytes {0} [built]
  [154] ./src/index.tsx 283 bytes {0} [built]
  [155] (webpack)-dev-server/client?http://localhost:4999 5.68 kB {0} [built]
  [156] (webpack)/hot/dev-server.js 1.57 kB {0} [built]
  [185] ./~/html-entities/index.js 231 bytes {0} [built]
  [241] ./~/react-dom/index.js 59 bytes {0} [built]
  [365] ./~/strip-ansi/index.js 161 bytes {0} [built]
  [400] ./src/ui/app.tsx 1.93 kB {0} [built]
  [420] ./~/url/url.js 23.3 kB {0} [built]
  [422] (webpack)-dev-server/client/overlay.js 3.73 kB {0} [built]
  [423] (webpack)-dev-server/client/socket.js 897 bytes {0} [built]
  [425] (webpack)/hot/log-apply-result.js 1.02 kB {0} [built]
  [426] multi (webpack)-dev-server/client?http://localhost:4999 webpack/hot/dev-server ./src/index.tsx 52 bytes {0} [built]
     + 412 hidden modules

ERROR in ./src/ui/stageView/TileOverlay.tsx
(10,42): error TS2314: Generic type 'SVGProps<T>' requires 1 type argument(s).

ERROR in /Applications/MAMP/htdocs/src/ui/stageView/tileOverlay.tsx
(10,42): error TS2314: Generic type 'SVGProps<T>' requires 1 type argument(s).

ERROR in ./src/ui/components/withStyle.tsx
(29,11): error TS6133: 'className' is declared but never used.

ERROR in ./src/ui/components/withStyle.tsx
(30,15): error TS2698: Spread types may only be created from object types.

ERROR in ./src/ui/components/withStyle.tsx
(51,11): error TS6133: 'classes' is declared but never used.

ERROR in ./src/ui/components/withStyle.tsx
(52,15): error TS2698: Spread types may only be created from object types.

ERROR in ./src/ui/components/icon.tsx
(9,7): error TS6133: 'TRANSLATE_TO_CENTER' is declared but never used.

ERROR in ./src/ui/components/icon.tsx
(24,49): error TS2314: Generic type 'SVGProps<T>' requires 1 type argument(s).

ERROR in ./src/ui/components/icon.tsx
(32,12): error TS6133: 'background' is declared but never used.

ERROR in ./src/ui/components/icon.tsx
(32,27): error TS6133: 'elements' is declared but never used.

ERROR in ./src/ui/components/icon.tsx
(33,11): error TS6133: 'className' is declared but never used.

ERROR in ./src/ui/components/bar.tsx
(4,42): error TS2314: Generic type 'SVGProps<T>' requires 1 type argument(s).
Child html-webpack-plugin for "index.html":
    chunk    {0} index.html 541 kB [entry] [rendered]
        [0] ./~/lodash/lodash.js 540 kB {0} [built]
        [1] ./~/html-webpack-plugin/lib/loader.js!./src/assets/index.html 702 bytes {0} [built]
        [2] (webpack)/buildin/global.js 509 bytes {0} [built]
        [3] (webpack)/buildin/module.js 517 bytes {0} [built]

hey @ValleyInforge, try pulling the latest master, should be fixed. The problem was that the typescript version was updated and broke some of the types. I also froze the deps with yarn, so instead of doing npm i it's probably better to do yarn. Enjoy!

Yes! Now in local it work! Fantastic! For do in an host I need to make the html page and use:

Where i can find the bundle.js file? Or is private for not duplicate the project?

not sure I understand your question. when you run npm run build you'll see all the output files in the build folder. you might slightly have to change the paths in the index.html depending on how you are storing the files

I can't find the build folder :/ Where I can find it?

first you need to run npm run build

Oh, yes. Sorry. Work! Thanks a lot! Congratulation for the project!
p.s. I'm italian 💃

anche io 🇮🇹

Lo so, ti ho scritto su facebook ahahah. Solo che qui non sapevo se si poteva in italiano 🐰
Comunque per fare le modifiche ai settaggi, prima modifico i file .ts e poi faccio la build giusto?
Per cambiare le immagini invece con altre NON svg ma .gif o .png?

better stick to english on gh ;) also, if you have other question, just open different issues so we can better keep track of them


Client submits payment requests

[x] Push payment requests to Firebase
[x] Display result

Implemented by #13


Exported classes do not add referenced SharedPools in the declaration

When exporting a class that uses a SharedPool, the referenced SharedPool is not exported in the .class file.

In addition, the pools CwConstants and TonelTextConstants in the class TonelTools were lost and need to be re-added.


pre-commit hooks are really slow

for some reason running the pre-commit hooks is really slow; it should be instant; for an example how it can be done properly see cachix/pre-commit-hooks.nix

imho we should just use those, btw, they also have a flake module, integrating them should be trivial, we can offload the entire work to them, no maintenance burden on us whatsoever; they integrate with all the tools that we use company wide; we could inherit their flake module and mkDefault the tools we normally use.


Support for .net6

Hi there thanks for this library its great. Any plans to upgrade the project to support .net6 ?

it doesnt work in .net6 ios and android?

It seems to be working for net6.0-android but not net6.0-ios I'm getting a null ref when image cropping which I wasn't before  on .net standard. However, I'll do some more investigating a pinpoint the exact issue. Ill report back.

OK it's the  Current in ImageCropper.Current which is null on  net6.0-ios.

If it helps I've upgraded the underlying iOS library you use  in this project "TOCropViewController"  here  https://github.com/spinspin/TimOliver.TOCropViewController.Xamarin
this is now working with net7.0-ios and  I'm using it successfully

implemented support for .net 7


feat: send bitcoin back navigation

separate send-bitcoin flow into separate screens, so that it can navigate back during the flow and facilitate deeplinking

This Pr addresses issues #549 #558 #536 #557


[Question]: Can I past a list of query strings to query_engine.query() or query_engine.retrieve() i.e., batch query/retrieve?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
It's not entirely clear to me if a RetrieverQueryEngine() supports batch queries. I'm not using an LLM and just want to retrieve semantically similar results.
My query engine for my chromdb index is defined as follows:
index = VectorStoreIndex.from_vector_store(vector_store=vector_store,storage_context=storage_context,  service_context=service_context,)
retriever = VectorIndexRetriever(     index=index,     similarity_top_k=cfg.semantic_search.query.similarity_top_k,     vector_store_query_mode="text_search", )
response_synthesizer = get_response_synthesizer(   response_mode="no_text", service_context=service_context )
rerank = SentenceTransformerRerank(     model=cfg.semantic_search.query.rerank.cross_encoder.model_name,     top_n=cfg.semantic_search.query.rerank.cross_encoder.top_n, )
query_engine = RetrieverQueryEngine(     retriever=retriever,     response_synthesizer=response_synthesizer,     node_postprocessors=[DummyNodePostprocessor(), rerank], )
My hope was that I could pass a list of query strings as follows:
 results_q = query_engine.query(queries)
OR
results_r = query_engine.retriev(queries)
Do async methods apply at all?

The bot is correct :) Just need to be careful about rate limits then when running so many queries

Wow, that was a great bot response. Appreciate it and your confirmation.
I'm actually just using it for semantic search retrieval, so no calls to llm.

@logan-markewich  Is there a Query engine designed for batch queries?

@Data-drone nah, and I don't think there's one planned
Your best bet is async with aquery() and aretrieve()
Would welcome PR for it though


Fix compile errors on Mac

Need to link dependencies for shared library.

@greensky00 shall we do the same for static_lib? I use:
target_link_libraries(mephisto PRIVATE static_lib)

But when linking, it fails with SSL symbols not found.
Also, ${LIBRARIES} var is not usable in this scope.


Inconsistency in check/pylint

Description of the issue
PR #3698 hit the following pylint errors:
************* Module cirq.study.sweepable
cirq/study/sweepable.py:17:0: W0611: Unused Dict imported from typing (unused-import)
************* Module cirq.optimizers.align_right
cirq/optimizers/align_right.py:17:0: W0611: Unused ops imported from cirq (unused-import)
************* Module cirq.optimizers.align_left
cirq/optimizers/align_left.py:17:0: W0611: Unused ops imported from cirq (unused-import)

These files were not modified in this PR; as far as I can tell, the issues above were introduced in #3643 and #3644. Strangely, those PRs did not get flagged by the pylint checker.
I have confirmed that all three PRs listed here used pylint-2.6.0 in their checks.
How to reproduce the issue
Unclear. It seems like check/pylint behaves inconsistently in PR tests; we should double-check that it's set up correctly.
Cirq version
v0.10.0-dev

I was not able to reproduce this locally on branch 95-martin-orion:cirq-expects-values, despite both issues being present on inspection.

I was not able to reproduce this locally on branch 95-martin-orion:cirq-expects-values, despite both issues being present on inspection.

On My Mac, I see only the Unused Dict imported from typing (unused-import) error, the other too doesn't show up. It's odd that pylint is inconsistent between environments.

On My Mac, I see only the Unused Dict imported from typing (unused-import) error, the other too doesn't show up. It's odd that pylint is inconsistent between environments.

I can find some issues locally. I'm using ubuntu and it happens to be an ec2 instance, so I could share access with someone if they want to repro (or run some commands to help track things).

Marking resolved since I can't remember seeing this since the two PRs above.


Google OAuth Redirect Uri Missmatch error, but urls seem to be configured correctly

On my frontend (ReactJs) I'm login using Google and getting the "code" using the Auth Code Flow which looks something like this:

{
    "code": "4/0AfteXvtM-2XB5q-cTe-l-oYTkkRg-3QZf8V44cEvrRvCpPR9gSXhn76dF-oU2SPxDNvSpw",
    "scope": "email profile openid https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email",
    "authuser": "0",
    "prompt": "consent"
}

Then I'm sending this in the body of a POST request to my DRF API which lands on this view:

class GoogleLogin(SocialLoginView):
    adapter_class = GoogleOAuth2Adapter
    client_class = OAuth2Client
    callback_url = 'http://localhost:8000/accounts/google/login/callback/'

In my Google Console I have the same callback URL setup under OAuth 2.0 Client IDs:

But I keep getting the same error:

Error retrieving access token: {
    "error": "redirect_uri_mismatch",
    "error_description": "Bad Request"
}

Having the same issue, did you find the cause?

No, I ended up using Implicit flow instead since I only needed to get user information on login.
class GoogleLoginView(SocialLoginView):
    adapter_class = GoogleOAuth2Adapter

I'm leaving the solution that helped me. I've lost so many hours maybe this can help someone else save some time.
The trick was to set the callback_url to postmessage
class GoogleLoginView(SocialLoginView):
    adapter_class = GoogleOAuth2Adapter
    callback_url = 'postmessage'
    client_class = OAuth2Client


Fix for broken passwords

single quoting the echo 'password' fixes the truncation/substitution issues.

@amfriesz would you have a quick look and merge if it's in line with your edits?


Feat: Support for Question Papers (including Blueprint creation/progress measurement)

Add Blueprint, Add Tags to Exam Questions against Blueprint, View Blueprint, View Progress Against Blueprint

Check Comments. Looks good otherwise.

@venkateshwarans This is ready to be merged since Friday - any updates?

@bharatkashyap Can you please add unit test cases for the code you have written.

@bharatkashyap Can you please add unit test cases for the code you have written.

Hi @pallakartheekreddy - got it! Do you have any specific changes in mind that need additional test cases to be added?

@bharatkashyap Can you please add unit test cases for the code you have written.

The latest commit addresses this @pallakartheekreddy

@bharatkashyap I have merged the PR. Please do one round of test from you and release the tickets to QA team and next time on words please add JIRA ID's also in the PR.

@bharatkashyap I have merged the PR. Please do one round of test from you and release the tickets to QA team and next time on words please add JIRA ID's also in the PR.

Noted @pallakartheekreddy - will make sure JIRA IDs are present next time, and will update this one with the JIRA IDs as well.


Sp4 336 spike language configuration

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bundle sourcemaps

index.js and yaml.worker.js both have references to their sourcemaps in comments at the end of the files, but because the sourcemaps aren't included in the package, this results in noisy Webpack warnings like
WARNING in ./node_modules/monaco-yaml/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from './node_modules/monaco-yaml/index.js.map' file: Error: ENOENT: no such file or directory, open './node_modules/monaco-yaml/index.js.map'

I think it's useful to have the sourcemaps, so rather than turning them off, this PR includes them in the package.

Awesome! Thanks!


response length != content length

Bug Report
Description
GET request to http://files.minecraftforge.net/maven/net/minecraftforge/forge/json
only return a string containing the first ~8k bytes, the content length is reported as ``
To Reproduce
Steps to reproduce the behavior:
val (_, response, result) = "http://files.minecraftforge.net/maven/net/minecraftforge/forge/json".httpGet()
    .responseString()

when(result) {
    is Result.Success -> {
        println(response.contentLength)
        println(result.value.toByteArray().size)
        assertEquals(response.contentLength, result.value.toByteArray().size)
    }
    is Result.Failure -> fail(result.error.message)
}

Expected behavior
receiving the complete response content
Environment
Development Machine
Complete the following information if applicable

Fuel version: master
Kotlin version: 1.3.0

Additional context
this also causes errors with fuel-kotlinx-serialization and causes JsonParseExceptions randomly

I expect http://files.minecraftforge.net to be at fault here.

Expected for Gzip.

there is no gzip involved, just a unreliable server
and Fuel does not catch when the connection was prematurely interrupted
even though in this case it could because Content-Length exists

since we figured out it was the server being unreliable.. this is now more a bug about Fuel not catching that unreliability, should i open a new bug or rename this one ?

You can't really catch this. Content-Length is, although implemented as
such, not authorities when it comes to the RFC.
On Fri, 2 Nov 2018, 20:46 NikkyAI<EMAIL_ADDRESS>wrote:

since we figured out it was the server being unreliable.. this is now more
a bug about Fuel not catching that unreliability, should i open a new bug
or rename this one ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kittinunf/Fuel/issues/498#issuecomment-435474128, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB35WEyis9eiC92eZZAHoS4vi6YuVTX7ks5urKEagaJpZM4YL0J4
.

Don't depend on the Content-Length at all because it is always unreliable.


太容易陷入死循环了

向通用对话v2和代码助手各提了一个问题，然后就出不来了。。。

@rak-bn We have noticed that repetition and verbosity in model outputs seem to be annoying issues, and we are currently working on resolving them.


How to use with reactive forms?

I have a complex form where i want to use ng2-auto-complete at three different places. Currently i am using simple html select to display the list. I am using angular 2 model driven forms to handle the form. I want to replace the select list with ng2-auto-complete using model driven approach. Is it possible to do so or do i have to change the whole form into template driven approach?

this module can handle model-drive form well except with formGroup.

Closing. there is example on README.md using FormGroup.
Please re-open this if the issue is still not resolved.


Add opencl headers as package

If you open up a hunter_packages/OpenCL_Headers repo, I will put in a PR and update this PR to the appropriate release. Planing to also add another package "opencl" that includes the ICD (library) compile which is the reason I called this one opencl_headers.

Packages OpenCL_Headers and opencl have common files? Why there are two packages?

No common files, they are in 2 separate repos, the headers can be used without the lib as long as you link with the lib on your platform. The OpenCL package will include the ICD which is a stand in for the native platform lib that will find the native one at runtime. It depends on the headers so I am setting up the package to use hunter to fetch the OpenCL_Header package.

the headers can be used without the lib as long as you link with the lib on your platform

You mean system library that is not controlled by Hunter?

yes or you can include the next package (OpenCL) I am going to add that includes the ICD which will be a hunter controlled library that will also use the OpenCL_Header package as a dependency.

yes

In this case it conflicts with the Hunter approach, see this page:

https://docs.hunter.sh/en/latest/faq/interaction-with-other-package-managers.html

you can include the next package (OpenCL) I am going to add that includes the ICD which will be a hunter controlled library that will also use the OpenCL_Header package as a dependency

There should be introduced new feature that allow to have different packages to implement same "interface" (like different implementation of MPI), but in all such approaches the headers will not be used separately from the different implementation of sources. Note that headers and API are not the same.
API, library should provide method boost A::a() to user:
struct A {
  bool a();
};

Real header for implementation-1:
struct A {
  bool a() { return true; }
};

Real header for implementation-2:
struct A {
  bool a() { return false; }
};


Revert "add: reshape enum case conventions"

Reverts iiian/prisma-case-format#6
Sorry @wlsdud2194 think I merged this one too early. Aren't we missing the @@map addition in the enum output?
For instance, I think the output enum in your unit test should look like:
enum PostType {
  Note
  Question

  @@map("post_type")
}

@iiian
Oh, I see.
I'll create a new PR that fixed this issue later.

Hey so it looks like I was wrong about the need for @@map("post_type").
However, I did find one thing missing from the unit tests: if we change type to my_post_type on the posts model, there should be  a corresponding @map() annotation on the model (not the enum) as such:
model Posts {
    id          Int           @id @default(autoincrement())
    content     String?       @db.VarChar
    myPostType  PostType     <----- missing a @map("my_post_type") in the output

    @@map("posts")
}

Hey so it looks like I was wrong about the need for @@map("post_type").
However, I did find one thing missing from the unit tests: if we change type to my_post_type on the posts model, there should be a corresponding @map() annotation on the model (not the enum) as such:
model Posts {
    id          Int           @id @default(autoincrement())
    content     String?       @db.VarChar
    myPostType  PostType     <----- missing a @map("my_post_type") in the output

    @@map("posts")
}

I exactly understand about this issue.
How about this solution?

Reshape the enum before the model
When reshape models, add @map to the columns, If the column type is not primitive type and is included in reshaped enum names.

I think this solution should restructure the flow of case convention, so I'll write the code asap and show it to you.


fix(nexus): don't persist if child faults during nexus create

When nexus is being created with a single child, and that child goes into retire path before nexus is open, then the child gets persisted as unhealthy. This will cause volume to never be able to attach later on.

bors try

bors merge


(1.18) pehkui scaling options dont work and are outdated

Pehkui scaling options no longer work. In addition, newer scaling options have been introduced

Some scaling settings have to be enabled in the server, use the cpm command https://github.com/tom5454/CustomPlayerModels/wiki/The--cpm-command#scaling

Actually I came here to ask the same thing.
I assume that it's on a per-world basis, and if so, is there a way to make it set it to "true" automatically?

Default server configs were added in 0.4.0a, and a scaling enable all command. You have to re-log after entering the command to work.


Fix wrong URL for API documentation in README.md

The URL for the API documentation seems wrong, could the server hosting the docs not setup correctly to have to api subdomain pointing to the correct page here https://tourmaline.dev/api_reference/Tourmaline/?

Ahh thanks for this. Forgot to update it.

Ahh thanks for this. Forgot to update it.


Improve documentation on OAuth configuration

In the documentation under oauthConfig, the config values should be entered using strings, for example 'PASSWORD_CREDENTIALS_GRANT' for grant type. Expected from the lib are not strings but constants, like PASSWORD_CREDENTIALS_GRANT = 'password'. So in order to enter a working configuration, the constant have to be entered, or a 'password' string. There should be a description on how to import and use the constants.

Addition to the documentation topic in general: evaluate http://typedoc.org/

@jans510 could you provide a PR for this?


Update README.md

add ppa install instructions

@fromgilbert thanks a lot for this, I will create a separate page with installation instructions for the different OS'es that we support now. I think this was long due so I appreciate you taking the first steps.

Added, thanks again!


Spring Security Angular "request from origin ... blocked by CORS policy"

I am looking at the Spring Security Angular module provided and from everything I read and tried, it does not make sense as it does not mentions CORS at all.

The HttpSecurity configuration is missing it,
There is no CorsConfigurationSource anywhere
And the default Spring provided /login is overriden by a login controller which usually is not needed

Would you be able to provide more details on CORS as all I get is error like:
Access to XMLHttpRequest at 'http://localhost:8080/myapi/v1/auth' from origin 'http://localhost:4200'/ has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
, when trying to login.

Added CORS configuration

Is this tutorial for AngularJS or for Angular?

Also, this tutorial is using very obscured sentencing I find.  It looks like it is building spring boot AND angular as one single application.  This paragraph is not clear but it looks so:
Add an Angular App
The core of a single page application in Angular (or any modern front-end framework) these days is going to be a Node.js build. Angular has some tools for setting this up quickly, so lets use those, and also keep the option of building with Maven, like any other Spring Boot application. The details of how to set up the Angular app are covered elsewhere, or you can just checkout the code for this tutorial from github.
And then the provided URL https://github.com/dsyer/spring-boot-angular has even more difficult steps to follow.  Very unclear from the beginning whether we are building 2 applications (Spring Boot and Angular) or single application being both Spring Boot and Angular.
I have never heard of Angular app being added into Spring Boot project but the description seems to be doing exactly that.  Why would you tie these together?
Mind clarifying that?  Thanks

@dbnex14 we are going through your comments

Hi @dbnex14

The CORS issue your mentioned in the original request is now fixed
We could not find the URL mentioned ("../myapi/v2/.."), but we can ensure that the login is working
For the new request in your  last comment, could you please open a new github issue?


MB 2476 update prime api endpoint paths

Description
Removing parent IDs from endpoint paths in favor of passing them through the body. This strategy is consistent with the other endpoints in the Prime & Support APIs and with ADR-0045.
The affected endpoints are:

Create MTO Shipment

changing /move-task-orders/{:moveTaskOrderID}/mto-shipments to /mto-shipments

Create MTO Service Item

changing /move-task-orders/{:moveTaskOrderID}/mto-shipments/{:mtoShipmentID}/mto-service-items to /mto-service-items

It was also necessary to edit the Prime API Client command for Create MTO Service Items so that it was functional with the new JSON format (e.g. {"body":{ //params in here }}).
The Create MTO Shipment endpoint did not have a command for the PAC, and I felt that the work to add that would be best to put in a new ticket.
Setup
The Create MTO Service Item endpoint may be tested with either Postman or the Prime API Client. The Create MTO Shipments endpoint must be tested with Postman because it has not yet been added to the CLI. Instructions to set up both may be found here: https://github.com/transcom/prime_api_deliverable/wiki/API-Endpoints.
Both endpoints still require the parent IDs in question, but they must be passed through in parameters in the body.
Examples
Successful Body for Create MTO Service Item
{
  "reServiceCode": "DOSHUT",
  "modelType": "MTOServiceItemShuttle",
  "moveTaskOrderID": "da3f34cc-fb94-4e0b-1c90-ba3333cb7791",
  "mtoShipmentID": "15d360aa-c80a-4fca-9502-8540fd28b139",
  "reServiceName": "Test Create Service",
  "description": "testing shuttle",
  "reason": "for moving"
}

Successful Body for Create MTO Shipment
{
  "moveTaskOrderID": "5d4b25bb-eb04-4c03-9a81-ee0398cb779e",
  "shipmentType": "HHG",
  "requestedPickupDate": "2020-04-25",
  "customerRemarks": "very fragile",
  "pickupAddress": {
    "city": "Beverly Hills",
    "country": "US",
    "postalCode": "90210",
    "state": "CA",
    "streetAddress1": "123 Any Street",
    "streetAddress2": "P.O. Box 12345",
    "streetAddress3": "c/o Test Pickup"
  },
  "destinationAddress": {
    "city": "Fairfield",
    "country": "US",
    "postalCode": "94535",
    "state": "CA",
    "streetAddress1": "987 Any Avenue",
    "streetAddress2": "P.O. Box 9876",
    "streetAddress3": "c/o Test Destination"
  }
}

References

Jira story for this change

Warnings

:warning:

Please include the Jira ID at the start of the title with the format MB-123 or [MB-123]

  Generated by :no_entry_sign: dangerJS against fa2cc29484de44ee94819b1f31fd84abb954cb06


Add a storage provider for Tencent Cloud COS (aka Object Storage)

See: https://cloud.tencent.com/product/cos
Add it to: https://github.com/casbin/casdoor/tree/master/storage

Done by: https://github.com/casbin/casdoor/commit/d2565e03c80aeec3aca75a8f7c3ef01e02509be0