How to create a DragSource without a Context?

I have a component which adds dynamically created pieces to a separate component. Before I can even attach the component, I get the error: "Uncaught Error: Invariant Violation: Could not find the drag and drop manager in the context of Window. Make sure to wrap the top-level component of your app with DragDropContext. Read more: http://gaearon.github.io/react-dnd/docs-troubleshooting.html#could-not-find-the-drag-and-drop-manager-in-the-context" Is there no way to accomplish what I want?

Can you please show the relevant code?

It looks like the following:
var Container = React.createClass({
addItem: function(item){
var items = this.states.items.slice();
items.push(item);
this.setState({items:items});
},
render: function(){
    return
{this.state.items}
;
}

});
module.exports = DropTarget(types, spec, collect)(Container);
var App = React.createClass({
render: function(){
return ;
}
});
module.exports = DragDropContext(HTML5Backend)(App);
var SomeItem = Rect.createClass({
onClick: function(){
Dispatcher.addItemToContainer();
},
render: function(){
    return
...contents...
;
}

});
module.exports = DragSource(type, spec, collect)(SomeItem);
That is the general layout, I've left out how the dispatcher dispatches the request, but that is a common React pattern that I think you're familiar with. As you can see here, since SomeItem creates another SomeItem and passes it outward to be added, it is out of the DragDropContext and thus throws the error. This SomeItem implementation is simple, but I have multiple components which all create other random DragSources. Thoughts?

That is the general layout, I've left out how the dispatcher dispatches the request, but that is a common React pattern that I think you're familiar with

To be honest I'm a little confused. If you mean Flux architecture, I haven't seen people passing React elements as part of action payload, and this kind of imperative code contradicts the React flow.
Why not store the data instead and let SomeItem follow the normal React top-down flow? Seems like that would solve your problem since it would have the app's context too.

I've been trying to think about how to restructure the data flow like you're describing, but I cant figure out how to do it. Think of a drawing application where you instead of just pictures, you add components. Each component can then itself add more components (possibly with subcomponents themselves). Furthermore, it would feel wrong to make the canvas try to be aware of all the components that can be drawn. Does that make sense, or have I confused you further?

Yeah that makes sense. Give each component a unique string ID (e.g. 'button': Button, 'checkbox': CheckBox, 'awesome_item': AwesomeItem). Now you can store your data as a tree without actually referencing React components: { type: 'button', props: { something: 42, children: { type: 'awesome_item', ... } } }. Operate on that data.
In <Canvas> (or whatever root component you have), render <Node {...this.props.node} />. The Node might look like this:
import Button from './Button';
import AwesomeItem from './AwesomeItem';
// ...

const COMPONENTS_BY_TYPE = {
  'button': Button,
  'awesome_item': AwesomeItem,
  // ...
};

class Node extends Component {
  render() {
    let NodeComponent = COMPONENTS_BY_TYPE[this.props.type];
    let { children = [], ...rest } = this.props.props;
    return (
      <NodeComponent {...rest}>
        {children.map((child, i) => <Node node={child} key={i} />}
      </NodeComponent>
    );
  }
}

This should work recursively.

I see, you're basically wrapping React in a typed object system which can render itself..

Yes, the type of the immediate children of any Node will always Node. However it's a good React practice to not call instance methods, except some rare exceptions. Node can provide an instanceRef prop in case a direct child access is required.

will that automatically proxy instance methods or will the component have to assume that all of its children are node objects?

will the component have to assume that all of its children are node objects?

This. Another option is to avoid component recursion at all and have Node build a recursive ReactElement tree and render it at once. This may be closer to what you wanted.

I see, ok thanks!

But out of curiosity, if I really wanted to do it by having the container store react elements, is there any way to do that?

But out of curiosity, if I really wanted to do it by having the container store react elements, is there any way to do that?

React DnD uses context, and React elements created outside the render tree traversal won't receive React context, so no.
In React 0.14, however, it should work due to changes in how context works.


Precision about the supported versions of Magento

Hi,
I am working on an old Magento version (1.10EE) and I realized that the localstorage of my browser was never reset (not good security-wise).
https://github.com/Adyen/adyen-magento/blob/be88e18bb0d4ed1b93beff0a0dd93945fcb16836/js/adyen/adminhtml/sales.js#L19
Apparently, the trigger "dataLoaded" was introduced in the version <IP_ADDRESS>CE (1.12EE).
I think it should be important to precise that the minimum requirements are Magento 1.7CE/1.12EE.

Hi @xaviermarchegay,
The plugin support 1.8 and higher. This means enterprise 1.13 and higher. I strongly advise you to upgrade your magento version.
Regards,
Rik
Adyen

I know that. However, it is not said anywhere in the README.

This is the Adyen Payment plugin for Magento 1.x. The plugin supports the Magento Community and Enterprise edition.

should be changed to

This is the Adyen Payment plugin for Magento 1.8.x and higher. The plugin supports the Magento Community and Enterprise edition.

Hi @xaviermarchegay,
Agreed we will update our documentation and github readme.
Regards,
Rik
Adyen

This is now added into our documentation and github.
Regards,
Rik
Adyen


Audio stops playing and sometimes doesn't play

I've forked this repo and setup as explained. It appear to work fine and I can change the audio files and content as desired. However, I experience that the audio player stops playing after a few seconds on some devices and browser, but not always. Also it can sometimes play through the file but then will not let me play it again.
I have tried different devices and browsers and the audio files are 128kbps 44.1khz MP3.
Any idea why this is happening?

I tried at first to have a local dev version and hosted it using jekyll serve --host=<IP_ADDRESS> parameter to reach it from other devices. I then tried to deploy the _site content instead to a nginx server under an official domain name, which seem to work better and the audio plays consistently.
Is there a preferred way to deploy the static files?

I no longer work at ACMI so can't really offer too much in way of support, but: after running jekyll build you can pop the static files on virtually any web host. Easy to get started ones include Github Pages and Netlify, and both of them also support building the Jekyll site for you, which simplifies things a bit. But serving via nginx is a fine alternative, too, or even an S3 bucket.
I'd avoid trying to use jekyll serve for connecting other devices, I believe it's only really intended for local development, so probably doesn't handle multiple simultaneous requests very well. If audio is dropping out, it's possibly one of the following causes:

When you start playing the file, the browser will perform HTTP range requests to get the rest of the file.

Browsers can be pretty aggressive about caching media files, so if the filename hasn't changed but you've changed the audio file, then the browser might have cached the first part of an older version of the file, but do the range request grabbing a section of the new file from the server, leading to a corrupt file in memory. If you're iterating on the audio files, rename them as you go.
If you're not serving from a "real" web server (e.g. if you're using jekyll serve instead of nginx or a web host) then these subsequent HTTP range requests are likely to fail unexpectedly leading to dropouts.

If you find you're getting dropouts in real world situations, like over patchy WiFi, another approach can be to optimise your MP3 files, by making them mono 64kbps (roughly the same quality as a stereo 128kbps file, but a smaller file).
Finally, the included JS libraries in this repo are pretty out of date by now. If you're using this project in production, you might want to take a look at swapping these out for the latest CDN versions or bundling and minifying your own.
Hope that helps!

Thanks for the thorough answer @andrewserong. I won't serve the static direcoty with jekyll serve, but perhaps a local webserver, so i think it will be fine. Also, thanks for the tips on what to avoid.
Thanks,
Ørjan


autocomplete

im not going to implement autocomplete yet. but i will (hopefully!) track places where it might be useful, in here

[ ] create bracket
[ ] report race
[ ] generate pairings

note that improving the UI for admin features is quite low priority, although it would be nice to do eventually. currently adding autocomplete to a field is a bit cumbersome, which makes me not want to bother with this


Implement $in support

{ "find" : { "filter" : { "field" : { "$in" : [1,2] } } } } finds all documents where field is either 1 or 2. Think a "OR" for $eq.
It looks like Mongoose's populate() function uses $in under the hood, so we'll need this to support populate.

Updating from a chat today,. $in when used with a single field is (roughly speaking) a compact way to send multiple single field lookups; is something important from populate() in mongoose; and is often used for _id lookups which means we can make them go faster by using the CQL table primary key.
i.e. { "find" : { "filter" : { "_id" : { "$in" : [1,2] } } } } is asking for the documents with _id 1 and 2. The most efficient way to service this request would be to send multiple async primary key lookups to C*.

From chat this morning:

We are going to do 1 A below first, then add B as a backlog
Create a task to do investigation into 2 and 3

Our target use case is how Mongoose populate uses $IN
Decisions - complexity

support for _id only thing in filter - PRIVATE PREVIEW
{ "filter" : { "_id" : { "$in" : [1,2] } } }

support for _id and other things in filter  - Possible, investigate if we want / need this feature in API these queries can get harder to run
{ "filter" : { "_id" : { "$in" : [1,2] } }, "eyes" : "red" }

support for all fields - Possible, add later as needed, polymorphic fields makes it harder
{ "filter" : { "eyes" : { "$in" : ["red", "green"] } }}

Guardrails - when you have _id in the filter
a) set limit of say 20 - and use CQL IN - DO FIRST, quick release for the populate() Mongoose feature
select * from shred where key IN (1,2);
b) set limit of to prevent abuse - and use multiple statements - Put in backlog, we want to do this, do before GA
select * from shred where key = 1;
select * from shred where key = 2;

Guardrail B and Complexity 1 and 2 implemented as part of #348

Complexity 3 will be implemented when core DB is done to support in.

resolved
https://github.com/stargate/stargate/pull/2778
https://github.com/stargate/jsonapi/pull/535


Create h3 index for query in PostGIS instead

If the H3 extension is installed in PostGIS, we could add the H3 hex ids to the PostGIS table, or use the H3 hex ids if found ready in the table. This would make querying even faster.
Still, retain the capability to calculate the hex ids if they are not found in the table.
The relevant lines are https://github.com/GispoCoding/ipygis/blob/main/ipygis/gis_utils.py#L291-L295 , perhaps do this before to_gdf if the H3 extension is found in PostGIS, and check if the hex indexes exist already.

H3 extension: https://github.com/dlr-eoc/pgh3/blob/master/doc/pgh3.md


empty cgroups left behind

Description

Steps to reproduce the issue:
I don't have specific steps to reproduce, but we have a kubernetes cluster of around 20 nodes, and the nodes have been running for 1-3 months. Most of the nodes are exhibiting the problem.
Describe the results you received:
There are cgroups created by docker that contain 0 processes. The cgroups look like /sys/fs/cgroup/devices/system.slice/docker-122fb452a2062d6305e6c18fe9e2996ca96082f25fbd24304d4c5387ed1e1611.scope, and the file cgroup.procs inside them is empty.
Describe the results you expected:
Cgroups that are no longer in use are deleted.
Additional information you deem important (e.g. issue happens only occasionally):
We are running Kubernetes 1.3.8 on CoreOS v899 nodes. We are also hitting the problem described in https://github.com/docker/docker/issues/5618.
Output of docker version:
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   4419fdb-dirty
 Built:        Fri Dec 18 00:01:03 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   4419fdb-dirty
 Built:        Fri Dec 18 00:01:03 UTC 2015
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 382
Images: 1736
Server Version: 1.9.1
Storage Driver: overlay
 Backing Filesystem: extfs
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.3.3-coreos
Operating System: CoreOS 899.1.0
CPUs: 16
Total Memory: 62.91 GiB
Name: ip-10-20-8-66.us-west-2.compute.internal
ID: MX3R:IWX4:7JRC:JKR6:JBNV:CWAV:5AVU:233B:5AJ7:REFQ:GUBM:E6EN

Additional environment details (AWS, VirtualBox, physical, etc.):
AWS

Can you report this issue with CoreOS? This version of Docker is built by them, and contains code changes that are not in our code base, so we cannot help with that.
I'll close this issue here, but feel free to comment after


compile err

xcode version is 13.4.1   pod version is 1.11.3.
I need help

Please check your ParticleNetworkBase version in Podfile.lock, the latest version is 0.3.3.

Thank you ! I got it.


As a user I want to select 2 10-25 datasources for synchronization

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of the CDP4-COMET-HERMES
[x] I have searched open and closed issues to ensure it has not already been reported

Description
The user shall select a source a target data source upon which the data from both is loaded

the source can be a zip archive, in case this is selected the archive needs to be uploaded, and a server
the target can only be a server (not a zip archive)

System Configuration

[x] CDP4-COMET-HERMES version: 0.0.1

@samatrhea Looking into this and trying to see if I fully understood the request:
The goal is to have the ability to upload multiple data sources (in this scenario, multiple zip archives) and to provide the ability to select, from a list of possibilities, a target server to upload to.
Couple of questions:

Is the target server applied to all data sources or is the target server selected on a 1-by-1 scenario? This has UX implications, hence the question.
Where do we get the list of available servers from?

If this is not yet considered, is there a server to test this from? Otherwise I'll just setup a local HTTP/FTP server.

Is user authentication to be considered for this ticket? As of right now, from what I could see on the project, it's very barebones. I assume this might come from the library "CDP4ServicesDal-CE" but I have no knowledge about it (yet).
Should there be a file size limit? If yes, should this limit be applied on a per file basis or total? What amount?

No more questions for now - I'm asking these just to prepare the terrain for when I do pick this up (maybe tomorrow?).

The purpose is to connect to 2 COMET servers and show differences between data to the user, so the user can copy data from one server to the next. We use the term data-source because COMET also supports a zip archive that contains 10-25 data. So, we should also support the zip archive mode,. The latter does indeed imply that the user needs to upload the data source prior to being abler to open it. A zip archive is read-only, so can only be used as source, never as target.
I hope this clarifies a bit the request

I believe this should be solved by #15


Read up on possible tests that can be done on the Database

US: Scenario for Database
PREREQUISITES:
DOCS:

Research possible testing strategies and types that relate to the Database domain of an application
Create a brief report with links to resources

BOUNDARIES:
What this task handles is to create a report about testing strategies and types for the Database
What this tasks does not handle is writing any scenario content
OUTCOMES:
The report is created and available

https://docs.google.com/document/d/14K8YUAhzp-GYfvAYce_6YY6qaeF2MDHSb2cLJUzsT64/edit

Moved to unified docs file with other reports


[IOTDB-244]fix bug when querying with duplicated columns

JIRA https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-244?filter=allopenissues

In the original code, the client side IoTDBQueryResultSet assumes that the server returns deduplicated query results. However, in the original code, the sever returns query results without the step of deduplication. That's the cause of the bug IOTDB-244.
So, I fix this bug by adding the deduplication step in the server side and uses the same deduplication or map strategy as the client.


SharpDevelop

SharpDevelop needs .NET SDK to compile projects.
Maybe find a way to automatically configure SharpDevelop to usw Mono.
Or find a way to deploy .NET SDK in a portable fashion.


Compile warning

I am porting in raspbian.
I got the following warning during compilation:
lvgl/lv_misc/lv_mem.h:37:20: warning: "ppc64" is not defined [-Wundef] # if x86_64 || ppc64
How can I solve the above problem?

Hi,
Changing that line to # if defined(__x86_64__) || defined(__ppc64__) solves the issue?

Yes, I've solved the above issue. Thank you.


arxiv5 additions

missing entries from arxiv5 list

@FrankMittelbach  I think the missing arxiv10 ones are
amsgen
epsf
etex
everyshi
ifpdf
infwarerr
ltxcmds
pdftexcmds
pgf
pgffor
pgfkeys
pgfmath
pgfrcs

I have these
amsgen.sty
amsbsy.sty
iftex.sty
ltxcmds.sty
kvsetkeys.sty
kvoptions.sty
pdftexcmds.sty
infwarerr.sty
refcount.sty
intcalc.sty
kvdefinekeys.sty
bitset.sty
bigintcalc.sty
ifpdf.sty
revsymb.sty
ifxetex.sty
epsfig.sty
pgf.sty
ifvtex.sty
epsf.sty
etex.sty
xkeyval.sty
revtex4.cls

some are probably already in the yaml (haven't crosschecked)


performance improvements

This PR includes the following changes:

Favor rest parameters over the use arguments
Remove the use of hasOwnProperty for slight performance improvement
Replace the for...of by a forEach as it does not transpile well to ES5
Bump up node minimum version to 5
Bump up version of ava to remove low security warning
A slight performance improvement (~15% for 1M elements) can be observed

Hello Arnaud!
Thank you very much!
Is there any evidence that this indeed improves performance?
On Fri, 21 Feb 2020 at 23:11, Arnaud<EMAIL_ADDRESS>wrote:

This PR includes the following changes:

Favor rest parameters over the use arguments
Remove the use of hasOwnProperty for slight performance improvement
Replace the for...of by a forEach as it does not transpile well to
ES5
Bump up node minimum version to 5
Bump up version of ava to remove low security warning

You can view, comment on, or merge this pull request online at:
https://github.com/ZitRos/array-merge-by-key/pull/3
Commit Summary

performance improvements

File Changes

M index.js
https://github.com/ZitRos/array-merge-by-key/pull/3/files#diff-0
(27)
A package-lock.json
https://github.com/ZitRos/array-merge-by-key/pull/3/files#diff-1
(2850)
M package.json
https://github.com/ZitRos/array-merge-by-key/pull/3/files#diff-2
(15)

Patch Links:

https://github.com/ZitRos/array-merge-by-key/pull/3.patch
https://github.com/ZitRos/array-merge-by-key/pull/3.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ZitRos/array-merge-by-key/pull/3?email_source=notifications&email_token=ABGCCSAX36MRLG7JHSBU4ATREBGRPA5CNFSM4KZLJID2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPNOZ3Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGCCSEUE6R7FT3SRSPVHBTREBGRPANCNFSM4KZLJIDQ
.

Thanks for getting back to me! It's really minimal, mostly due (I suspect) to how node processes the code now compared to how it was written then. I'm going to write a small benchmark to corroborate/debunk my claim, I hope to have it in the next day or two. Have a great weekend!

Thank you! That would be really great.
Personally, I would avoid dropping older node versions if there are no
significant changes in performance.
On Sun, Feb 23, 2020 at 9:53 PM Arnaud<EMAIL_ADDRESS>wrote:

Thanks for getting back to me! It's really minimal, mostly due (I suspect)
to how node processes the code now compared to how it was written then. I'm
going to write a small benchmark to corroborate/debunk my claim, I hope to
have it in the next day or two. Have a great weekend!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ZitRos/array-merge-by-key/pull/3?email_source=notifications&email_token=ABGCCSBSL2HZZYLXJFWERXTRELH3ZA5CNFSM4KZLJID2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWFRLQ#issuecomment-590108846,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGCCSAR4HX3XJYYAGEX5M3RELH3ZANCNFSM4KZLJIDQ
.

I wrote a benchmark (https://github.com/arnaudNYC/array-merge-by-key/tree/benchmark) and ran it, and the two solutions were equivalent. I then restored the check using hasOwnProperty to remain identical to the original intent, and your original solution was faster 10 out of 10 times! So thanks for keeping me honest here.
I was also mistaken about the claim on for...of not transpiling well to ES5, I had it mixed up with generators (https://github.com/airbnb/javascript#generators--nope), so that's fine too.
The arguments replacement is because of this lint rule: https://eslint.org/docs/rules/prefer-rest-params, but it really doesn't change anything.
The last change that has some (relative) value is the upgrade of ava. Should you want to resolve that warning, the changes in this PR will work.
Well done on writing time resistant code!
Best,
Arnaud

Thank you @arnaudNYC! Glad you've tested it. A little story behind at least arguments - some code decisions here were made intentionally for performance reasons and that's why I was wondering :) If you would like to make a PR updating dependencies like Ava you are very welcome! But anyway they are dev dependencies and does not affect package users anyhow.


Package behaving differently when loaded with straight-use-package

What's wrong
When the gpt4emacs package is loaded using the load function, the Emacs built-in url-retrieve function behaves as expected. However, when said gpt4emacs package is loaded using use-package and straight, the API responds by asking for credentials, even though the same API key is provided.
Additionally, I don't seem to figure out how to tell Straight (or Quelpa, read on) to not build the package, on the off-chance that this would work around the problem.
EDIT When I byte-compile and load-library the file, everything works.
EDIT2 I tried Quelpa (always with blank init file) and the problem is the same :disappointed:
Directions to reproduce

Start with an empty init file.
Add the bootstrap snippet for straight.el to your init file:

(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 6))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

Add the following code to your init file to install and configure use-package and gpt4emacs:

    (setq straight-use-package-by-default t)
    (straight-use-package 'use-package)

    (use-package gpt4emacs
      :straight (gpt4emacs
                 :type git
                 :repo "https://framagit.org/yphil/gpt4emacs.git"))

Start Emacs.

Use M-x customize-variable RET gpt-api-key-file to point to a file with only your API key.

Observe that the API responds by asking for a "Username" when url-retrieve is calling it.

instead of the straight / use-package declarations, simply load the module like this:

(load "~/src/lisp/gpt4emacs/gpt4emacs.el")

or even the straight repo package
(load "~/.config/emacs/straight/repos/gpt4emacs/gpt4emacs.el")

The url-retrieve fct behaves normally.
If I then try to load the straight-built package like this:
(load "~/.config/emacs/straight/build/gpt4emacs/gpt4emacs.elc")

Then the url-retrieve behave differently, and the API asks for credentials :frowning:
:arrow_forward:  It also works fine when visiting gpt4emacs.el in a buffer and eval-buffer'ing it, which seem to be in contradiction with the straight documentation..?
I'm messaging the API key right before the url-retrieve, and in both cases it it properly set.
Version information

Emacs version: GNU Emacs 28.2 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0)
Operating system: GNU/Linux Ubuntu 22.04.2 LTS

This sounds like an upstream issue with the package.
It looks like  you are the package author as well.
The help-gnu-emacs mailing list, reddit.com/r/emacs/, the #emacs IRC channel, or the Emacs stack exchange site are good resources to ask questions about authoring elisp packages.


Extended range support

In Haskell you can do:
> [10, 12.5..30]
[10.0,12.5,15.0,17.5,20.0,22.5,25.0,27.5,30.0]

> [10,8..2]
[10,8,6,4,2]

> [10,8..3]
[10,8,6,4]

You provide two values which will tell the compiler the increment value and then a end value and it will know how to fill the gaps in the array.
I feel it's very powerful, neat functionality that could be implemented in CoffeeScript easily.

Nope, it couldn't be implemented in CoffeeScript easily:
[10, a..b]


Unit tests

Adds unit tests for add_optimised_filtering.py, panels.py and vcf.py
Removes CSQ string as an input and instead obtains the CSQ fields to split with bcftools +split-vep directly from the VCF header
Now performs checks of the panel string given to ensure only one panel (or one panel plus HGNC IDs, or HGNCs alone) is provided and only searches for MOI information for the panel within the panel string
Adds the INFO MOI field as 'NONE' for a variant if that gene is not in the dictionary we've made for our panel or the gene has no MOI info from PanelApp
Fixes README so the gnomAD part of the bcftools filter string example is correct
Removes read_in_csv() function in file_utils.py which is no longer used

This change is

Hello @rklocke! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file resources/tests/__init__.py:

Line 3:63: W292 no newline at end of file

In the file resources/tests/test_add_optimised_filtering.py:

Line 9:1: E402 module level import not at top of file
Line 41:80: E501 line too long (91 > 79 characters)
Line 42:80: E501 line too long (107 > 79 characters)
Line 43:80: E501 line too long (91 > 79 characters)
Line 44:80: E501 line too long (107 > 79 characters)
Line 45:80: E501 line too long (91 > 79 characters)
Line 46:80: E501 line too long (107 > 79 characters)
Line 47:80: E501 line too long (101 > 79 characters)
Line 48:80: E501 line too long (107 > 79 characters)
Line 49:80: E501 line too long (101 > 79 characters)
Line 50:80: E501 line too long (107 > 79 characters)
Line 51:80: E501 line too long (101 > 79 characters)
Line 52:80: E501 line too long (106 > 79 characters)

In the file resources/tests/test_panels.py:

Line 12:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 25:80: E501 line too long (80 > 79 characters)
Line 35:80: E501 line too long (99 > 79 characters)
Line 36:80: E501 line too long (83 > 79 characters)
Line 40:5: E303 too many blank lines (2)
Line 85:80: E501 line too long (97 > 79 characters)
Line 156:80: E501 line too long (85 > 79 characters)
Line 175:80: E501 line too long (85 > 79 characters)
Line 195:80: E501 line too long (85 > 79 characters)
Line 218:80: E501 line too long (85 > 79 characters)
Line 235:80: E501 line too long (80 > 79 characters)
Line 245:80: E501 line too long (85 > 79 characters)
Line 260:5: E303 too many blank lines (2)
Line 353:1: E302 expected 2 blank lines, found 1
Line 393:9: E122 continuation line missing indentation or outdented
Line 408:80: E501 line too long (105 > 79 characters)
Line 411:80: E501 line too long (81 > 79 characters)
Line 447:80: E501 line too long (81 > 79 characters)
Line 455:80: E501 line too long (109 > 79 characters)
Line 489:80: E501 line too long (94 > 79 characters)
Line 493:80: E501 line too long (105 > 79 characters)
Line 497:80: E501 line too long (129 > 79 characters)
Line 501:80: E501 line too long (129 > 79 characters)
Line 509:80: E501 line too long (157 > 79 characters)
Line 513:80: E501 line too long (98 > 79 characters)
Line 525:80: E501 line too long (84 > 79 characters)
Line 529:80: E501 line too long (84 > 79 characters)
Line 533:80: E501 line too long (83 > 79 characters)
Line 541:80: E501 line too long (108 > 79 characters)
Line 545:80: E501 line too long (173 > 79 characters)
Line 562:9: E122 continuation line missing indentation or outdented
Line 563:9: E122 continuation line missing indentation or outdented
Line 563:46: E231 missing whitespace after ','
Line 564:9: E122 continuation line missing indentation or outdented
Line 564:46: E231 missing whitespace after ','
Line 565:9: E122 continuation line missing indentation or outdented
Line 566:9: E122 continuation line missing indentation or outdented
Line 567:9: E122 continuation line missing indentation or outdented
Line 568:9: E122 continuation line missing indentation or outdented
Line 569:9: E122 continuation line missing indentation or outdented
Line 570:9: E122 continuation line missing indentation or outdented
Line 571:9: E122 continuation line missing indentation or outdented
Line 572:9: E122 continuation line missing indentation or outdented
Line 573:9: E122 continuation line missing indentation or outdented
Line 574:9: E122 continuation line missing indentation or outdented
Line 575:9: E122 continuation line missing indentation or outdented
Line 576:9: E122 continuation line missing indentation or outdented
Line 577:9: E122 continuation line missing indentation or outdented
Line 578:9: E122 continuation line missing indentation or outdented
Line 579:5: E122 continuation line missing indentation or outdented
Line 582:5: E303 too many blank lines (2)
Line 586:80: E501 line too long (100 > 79 characters)

In the file resources/tests/test_vcf.py:

Line 12:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 25:1: E302 expected 2 blank lines, found 1
Line 30:5: E301 expected 1 blank line, found 0
Line 36:13: E128 continuation line under-indented for visual indent
Line 37:13: E128 continuation line under-indented for visual indent
Line 38:9: E124 closing bracket does not match visual indentation
Line 64:5: E301 expected 1 blank line, found 0
Line 119:80: E501 line too long (80 > 79 characters)
Line 180:22: E222 multiple spaces after operator
Line 219:22: E222 multiple spaces after operator

In the file resources/utils/panels.py:

Line 49:23: E231 missing whitespace after ':'
Line 139:80: E501 line too long (109 > 79 characters)
Line 163:80: E501 line too long (113 > 79 characters)
Line 257:33: E225 missing whitespace around operator

In the file resources/utils/vcf.py:

Line 291:80: E501 line too long (80 > 79 characters)


Can't use alt+n for ~

I'm using a German keyboard. In all other apps, I can use alt+n to insert ~. (This works in the default Terminal and iTerm2 as well).
However, in hyperterm, alt+n does nothing. Is there a way I can fix this or does this need to be implemented in hyperterm itself?

Duplicate of #66


Minor website bugs

Too much shitespace at top of blog posts.
Code blocks have weird side indents (They should level with text left and right)
Blog: Readtime shall not wrap
Blog: Shadow vanishes too early

https://hotchocolategraphql.slack.com/archives/CD9TNKT8T/p1611675984358400

https://hotchocolategraphql.slack.com/archives/CD9TNKT8T/p1611675984358400


Add pgbench -S (select-only) workload to performance test suite

Something like the test in https://github.com/zenithdb/zenith/pull/485#issuecomment-908697106. We can add it as an extra step and measurement in the existing test_perf_pgbench.py test.

We've been running a test like this and collecting results for a while now, in test_runner/performance/test_perf_pgbench.py. Closing.


Account for null version constraint on selector

This is the case for project selectors.

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.


StaticRoute nodeSelector does not properly select on multi-subnet cluster

Given a Kubernetes cluster with nodes that span multiple subnets, if a StaticRoute CR is created targeting the nodes in one subnet to install a static route, the nodes in the other subnet, rather than simply ignoring the CR, will log errors stating that the Given gateway IP is not directly routable, cannot setup the route. This scenario is unavoidable in a multi-subnet cluster, in fact the gateway IP will most likely be directly routable only from one of the subnets.
I think this issue is caused by the controller performing the gateway check before performing the nodeSelector check on the current node. This behavior has another consequence, which is that once this error is logged by the nodes in the other subnet and added to the status of the CR, it will be impossible to delete the CR since those nodes will never try to remove themselves from the CR status, since they will continue to get stuck on the gateway check.
I swapped the logic to check the nodeSelector first and then check the gateway only if the node is indeed part of the selected nodes. This seems to have solved the issue and the behavior is now as expected.
If desirable, I can open a PR with my changes so that it can be reviewed to ensure it doesn't break any other functionality.

@mihivagyok any updates on this issue?

hi @tommasopozzetti . Sorry for the late response, could you please raise a pull request from your proposed changes?

this issue has been resolved by #104, so closing.


Add Sommelier to asset list

Thanks @hannydevelop!  Can you also add a PR to the https://github.com/cosmos/chain-registry/ repo as well

Thanks @hannydevelop! Can you also add a PR to the https://github.com/cosmos/chain-registry/ repo as well

Great, I'll make a PR now

double-check value for display:  , might be a typo

Thanks, corrected :)


Stoneholm villages are being affected by Hostile Villages

Forge 1.16.5. Basically I want the Hostile Villages mod to only affect normal surface villages, but instead it is also affecting underground villages. Isn't there any way to avoid this happening

No. Giving a glance at Hostile Villages it is "All Rights Reserved". It's as far as I am concerned a black box in how it works. You'd have to speak with them.
1.16.5 is also not a version I support. Haven't released an update for it since 1.17 released.


Update README.md

remove: examples/vault/demo.get-cluster-info.sh

change the help for helm installation to do bootstrapping


rework missing import mechanism?

Currently we deal with ImportErrors like this:
try:
    from .lance import ann
except ImportError:
    msg = "Missing ann extras: `pip install functime[ann]`"
    ann = ImportError(msg)

try:
    from .automl import auto_lightgbm
    from .lightgbm import flaml_lightgbm, lightgbm
except ImportError:
    msg = "Missing lightgbm extras: `pip install functime[lgb]`"
    auto_lightgbm = ImportError(msg)
    flaml_lightgbm = ImportError(msg)
    lightgbm = ImportError(msg)

try:
    from .catboost import catboost
except ImportError:
    catboost = ImportError("Missing catboost extras: `pip install functime[cat]`")

try:
    from .xgboost import xgboost
except ImportError:
    xgboost = ImportError("Missing xgboost extras: `pip install functime[xgb]`")

This is clever but means that the issue is raised "lazily" and can lead to issues such as #190 . I think we should revert this.

In scikit-lego we have a little more sophisticated version of such error which can help to point at which version to install (proof).
In general there is a tradeoff between:

what the user has immediately available
the number of packages required to be installed

Personally, as the base/core dependencies of the functime are already quite broad, I would not add them all 😇 my two cents

+1 on that. I would actually like to remove as many dependencies as I can (I am looking at you, cloudpickle). I need to improve on the lazy imports though. Polars does too.


ASA-4900: Fix for the IRX_MINOR_CACHE_HOME flag

Fix for IRX_MINOR_CACHE_HOME not being honored via the mvn command line. This flag is now set in the appscan-config.xml during every scan (if specified) and will be used by CLI to determine the user-specified irx cache location.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Improve error messages resulting from errors returned from RPC nodes

[x] Log them #2559, #2571, #2576, #2625, #2636, #2640
[x] Analyse them
[x] Tomek prepare user-friendly messages + (if necessary: FAQ page)
[x] Display user-friendly messages instead, as well as link to FAQ page if available

List of messages:
Some of the messages returned by RPC nodes aren't consistent across chains.

Usually not enough native crypto to pay for gas (but xDai returns this when gas price specified is too low too): "insufficient funds for gas * price + value" (xDai returns a slightly different message)
Gas price is too low: "transaction underpriced"

@colourfreak I have build a list here https://github.com/AlphaWallet/alpha-wallet-ios/issues/2557#issuecomment-785693226
I'll update again if we collect more. But I think those are the main ones.

I will go one by one, as it requires special attention.

Insufficient funds

We should avoid Alerts/Popups at any cost
Instead, let's prevent users from making errors and prevent them just at a right time.
If you are sending ETH or ERC20 and you don't have enough Ether to pay for the fees, the green button becomes gray (inactive). It prevents users from attempting to send which will end up with an alert. But what we are missing is the feedback in human-readable language that describes a problem and quick fixes to that issue (they work better than instructions).
on tap on the gray button, the modal slides in from the bottom.
Buy Now takes you to Ramp.network for ETH purchase
Learn more takes you here: https://alphawallet.com/faq/what-do-insufficient-funds-for-gas-price-mean/

execution reverted: (sometimes technical reason given here)
revert
What can I do to recall this alert? What should I do?

execution reverted: (sometimes technical reason given here)
revert
What can I do to recall this alert? What should I do?

If you mean how to trigger it, it happens when the smart contract runs and the logic returns an error, e.g trying to vote outside the voting period. There's nothing general we can do in the app to trigger it. It depends on the contract/token and context around it.
Example, this is from Uniswap (I don't know how to trigger this, maybe trying to swap when there's not enough liquity for the target token?)

revert: UniswapV2Router: INSUFFICIENT_B_AMOUNT

Another example:

revert: You did not register for yesterday's period Or already claimed

So, we'll have to assume the error messages might or not not make sense, but it is probably specific to the contract. (note that the error message is not provided sometimes. Just "revert" or "execution reverted")

Buy Now takes you to Ramp.network for ETH purchase

Do we have an alternative for when Ramp is not available for that native token, or if it's testnet?

Buy Now takes you to Ramp.network for ETH purchase

Do we have an alternative screen for when Ramp is not available for that native token, or if it's testnet?

If a Ramp is not available, take them to https://alphawallet.com/browser-item-category/buy-crypto/ in a Browser

Nonce is low
Nonce is too low

@hboon I need your help. What can we enter as a text. First sentence should describe what nonce is, second what exactly to change. Then, if you hit "Correct Nonce" it will take you back to Setting custom speed with an error marked in that input field.
So I need this text + What to suggest under the input field?

Something like:

The nonce is the total number of transactions which has been sent from this wallet so far, and is included for security purposes.

Regarding the red text under the textbox "We recommend xxxx...", maybe we should have something like "Leave the nonce empty and we'll fill it in for you".
The rational behind this is if the user fills it in, it's likely that they know (or think they know) what they are doing, eg. they want to manually speed up a transaction (for some reason, not using our yet-to-be-available functionality, maybe they want more control, like change the amount of eth sent, etc).
I think we could hit this too after speedup/cancel is available, but with a twist [1]. But let's just ignore that for now. We just handle it directly in the speedup/cancel flow instead.
[1] When the user hits Confirm for the replacement transaction and the previous transaction has already been processed

Buy Now takes you to Ramp.network for ETH purchase

Do we have an alternative screen for when Ramp is not available for that native token, or if it's testnet?

If a Ramp is not available, take them to https://alphawallet.com/browser-item-category/buy-crypto/ in a Browser

If it's testnet, do you want to link to a different page?

Buy Now takes you to Ramp.network for ETH purchase

Do we have an alternative screen for when Ramp is not available for that native token, or if it's testnet?

If a Ramp is not available, take them to https://alphawallet.com/browser-item-category/buy-crypto/ in a Browser

If it's testnet, do you want to link to a different page?

https://alphawallet.com/browser-item-category/utilities/ - where you can get ETH from faucets

I don't have a better idea for a copy or where to link buttons in the screenshot below:

How about we display the message verbatim for these and point to a page that list possible explanations? Especially for execution reverted which can be very long and specific to each dapps/smart contract?

@colourfreak are these available on Zeplin?

https://zpl.io/aRnDQPv
But we are still missing: Invalid Sender, Revert, Execution Reverted.

Invalid sender would be something like (likely this is initiated from a dapp or WalletConnect and it's configured wrongly):

You might be sending this transaction on the wrong chain.

Revert, and Execution Reverted are for same error messages so we can treat them the same way.
If we don't have FAQ pages to link them to for now, shall we skip them for now and fill them in later? It's still better than the current state.

 I can't write FAQ about something I don't understand.

https://alphawallet.com/faq/what-does-nonce-too-low-means/
I can make templates like this one, but I am unable to come up with anything better, because lack of my knowledge in that subject.

Done. There'll be more


Normalize.css version

This is not really an issue, I was just wondering if it would be okay to bump the version being installed from normalize.css v2.0.1 to normalize.css v4.1.1. Or is there a specific thought to be using v2.0.1?

Sounds great. You can make a PR here: https://github.com/middleman/middleman-templates-default

Made a PR, therefor closing here.
middleman/middleman-templates-default#6


SynGO2LEGO models regenerated through @dosumis' code; issue #55

Just ran file SynGO_export_test.json for examples.

Clarifying that only nine models changed?

@kltm Yep, only nine. I only ran it on a few annotations for examples.
If you'd like, I can run the full JSON source file containing 2179 models and submit a new PR? Thanks!

Yes, I think we should try on all the SynGO models, now that they are using ORCIDs.  @kltm is there anything else we need to resolve first?

@dustine32 @thomaspd
I'm happy to take any number onto dev, but all of them would naturally make looking for additional issues easier.

@kltm @thomaspd Cool, I'll get all of the models converted then. So the first issue that popped up when running the whole list was an out-of-date ontology file "go-simple.ofn". This file's from late Aug 2017 and the new annotations use terms added after that. Ex. GO:0099170
@dosumis Do you know where I can get an updated ofn file?
In the meantime I'll try to fish out other issues in the model list.

@kltm @thomaspd Cool, I'll get all of the models converted then. So the first issue that popped up when running the whole list was an out-of-date ontology file "go-simple.ofn". This file's from late Aug 2017 and the new annotations use terms added after that. Ex. GO:0099170

@dosumis Do you know where I can get an updated ofn file?

Just grab the latest GO file.  http://purl.obolibrary.org/obo/go.owl should be fine.

Awesome @dosumis thanks! Now it looks like it made it through most models before one to an obsolete term erred it out again.
I can probably skip SynGO annotations to obsolete terms, right @thomaspd ? Specifically, UniProtKB:P70569 annotated GO:0099090 (model SYNGO:1805).


Fix layout and allow hosting on github pages

I fixed the layout and also added a comment about omitted code, to be super clear.

Hi, @hterkelsen I finally got around to removing the conflicts.
Let me know if you'll be merging this, and whether you have some uncommitted changes. I'm still planning to convert the bootstrap-based UI to AngularDart Components, but I don't want to build on an outdated version of the app.

Sorry it took me so long to get to this!


chore(deps): update terraform-module to v1.9.1

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-cbr
module
minor
v1.7.0 -> v1.9.1

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.7.0 -> 1.9.1

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (github.com/terraform-ibm-modules/terraform-ibm-cbr)
v1.9.1
Compare Source
Bug Fixes

update module references in README (#284) (321229b)

v1.9.0
Compare Source
Features

add regionality support in fscloud submodule (#271) (66374b9)

v1.8.2
Compare Source
Bug Fixes

update required ibm provider version to >= 1.56.1 (#277) (e2dd42f)

v1.8.1
Compare Source
Bug Fixes

added instance id support to the target_service_details variable in the fscloud profile (#275) (8b84293)

v1.8.0
Compare Source
Features

update required ibm provider version to >= 1.56.1 (#276) (71bd929)

v1.7.1
Compare Source
Bug Fixes

fix link in README.md (#274) (80245e1)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

:tada: This PR is included in version 1.4.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


tvos support

Do you think to add support for this new platform? It should working without changing anything, but we have to use iCloud key-value storage

It's been added as part of #10

I'm closing this for now but please let me know if there's any issues with it


Make 'environment' key configurable in SDKs

👍🏻

@dsinghvi this should probably go in the spec? same override for all SDKs

+1


fix: locateDLLFromFilesystem fallback in case of no exact match found

Closes #1046

Check out developer manual for a commit hook that autoformats code, avoids the pylint issue to begin with.
But this should not help, because ctypes won't resolve it, you said it's None, and therefore no name is known, i.e. you do not enter this code, or is there more changes coming?

I guess, in case of "None" from the find_library in locateDLL you could use "lib" + name as the dll_name and that would make it working. It however looks strange to me, why that DLL is not found. Is there a tool this find_library uses on your OS, and that is not installed or something?

@kayhayen Thank you for your questions. Answer - https://github.com/Nuitka/Nuitka/issues/1046#issuecomment-808749618


Update links on https://substrate.dev/who/runtime-developer/

See https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/issues/474

These "who" pages, like the tutorial page, are inherently troublesome because they are not versioned along with the docs that they link to. That means on each new version we will have to manually update the "who" links. Further, @thisisvilla is building an entirely new site that, as I understand, will be made public when Substrate 2.0 is launched (maybe a month from now?).
Thus, I recommend just removing the "who" pages entirely. I would be willing to do that work.

Fixed in #479


API-based-web-app

https://github.com/iAmWaris97/API-based-web-app/projects/1

To perform this capstone project we are working in a group of two students. (Waris and Gustavo).
We have made the kanban card and assigned the tasks to each student equally.

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


2 types of component keep blinking

Hi,
I'm trying to use virtual scroller with 2 different types of compnents.
I mean, I need to present 1 virtual list combined with 2 types of items.
The code looks like this:
`
<virtual-scroll [items]="buffer" (update)="scrollItems = $event"
(change)="onListChange($event)">

type 1

type 2

`
as a result the scroller keep blinking and nothing being displayed.
any way to do it?

Found a solution

Glad you shared your solution.

@Liork1 how did you fixed? I'm facing a similar problem.
Thank you!

If each array index will display both item types next to each other, you
could try wrapping them in a parent tag.
If only 1 child per array index, but the child type is different for each
index, you could try the the enableUnequalChildrenSizes flag.
If only 1 child per array index and all indexes are the same child type,
you could create 2 separate virtual-scoll, 1 for each child type & put the
*ngIf on the virtual-scroll instead of the children.
On Tue, Jul 24, 2018, 11:35 AM Paulo Cézar Santana<EMAIL_ADDRESS>wrote:

@Liork1 https://github.com/Liork1 how did you fixed? I'm facing a
similar problem.
Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rintoj/angular2-virtual-scroll/issues/196#issuecomment-407489538,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB6MbkR4eZpA2V7bSv09OluIsOpkGfWKks5uJ1rdgaJpZM4UBI0l
.

Thank you @speige !
Actually I was making a mistake.
I had a condition to not show a custom div if it is the first item. So I put:

    ...
    </div

But I realized that it´s recycled and always the view in the top is index == 0, so the scroll jumps when that view recycled.
Removing the i != 0 solved my problem.
Anyway, thank you for the suport.


Write CRUD services to the Stargate database

add http client
typescript interfaces for data
authentication
service to manage CRUD

dependent on #76

dependent on #67

not 76 :)

Oops you are right, thanks @nhcarrigan 👍


Unable to request new cert and replace it into S3 when the cert is going to expire.

https://github.com/ocelotconsulting/node-letsencrypt-lambda/blob/master/src/acme/certify/getCertificate.js#L14
Hi, I have a question regarding this line of code. Seems I only able to create a new cert if the ${domain}.json not exist in the S3. So, how can I able to request a new cert if the old cert is gonna expire?
Thanks!

Hi @wooiliang ... actually if you look at this line, there is code prior to the flow that will check to see if a certificate is expired or within 30 days of expiration, and if so it will re-generate.
In fact, that is the main use case for this project. On a periodic basis (likely daily), the check is performed to see if a certificate is expired (or close), and then renew the certificate. There are other projects in our org that can be used to renew the cert in an ELB or in IAM.
Let me know if you still have issues.

Hi @larryboymi , yes the isExpired.js does the checking if the "Date" today is lesser than "notBefore" or greater than "notAfter" or lesser than 30 days of expiration, then it will return true.
After returning true, the script will regenerate the cert. ( Of cause if false, then going back to bed :) )
However, when come to this point, I cannot create a new cert because the ${domain}.json is already exist inside the S3 bucket.
What I expect is when regenerating the new cert, the new cert (${domain}.json) will actually replace the old cert (${domain}.json) in S3.
Please let me know if it is expected or I misunderstand the codes somewhere. Thanks.

Thanks for spotting that @wooiliang ... check 5b9428d for the fix... specifically this. Let me know if that addresses your issue, and I'll close this.

Hi @larryboymi , thanks for the fix, it did solve the issue. You may proceed to close the issue. Thanks again! :smile:

No problem! Hope this project helps you..


UninitializedParameter

🚀 Feature
Detect UninitializedParameter and run one batch/sample before fitting.
Motivation
Pytorch now accepts 'lazy' layers with UninitializedParameter.
However, this seems to cause a memory error in PL at when we start the trainer because it attempt to estimate the memory usage:
RuntimeError: Can't access the shape of an uninitialized parameter. This error usually happens in `load_state_dict` when trying to load an uninitialized parameter into an initialized one. Call `forward` to initialize the parameters before accessing their attributes.

Pitch
Currently I am solving this issue by manually calling the data / system before fitting the trainer:
data.setup()
batch = next(iter(data.train_dataloader()))
system.train()
system.forward(batch)
trainer.fit(system, data)

I think this may be also fixable with a Hook, but I think there must be a cleaner solution.

I believe this is because we have this strange way of computing the "model size":
https://github.com/PyTorchLightning/pytorch-lightning/blob/233f252bb427c930be8e7ca56fe115b637278b8d/pytorch_lightning/core/memory.py#L235
We probably have to filter the parameters there based on the type.

Are you interested in sending a PR?

I'm new to PL, so that would probably be unreasonable, sorry :/

no pressure! totally fine

I believe this is because we have this strange way of computing the "model size":
https://github.com/PyTorchLightning/pytorch-lightning/blob/233f252bb427c930be8e7ca56fe115b637278b8d/pytorch_lightning/core/memory.py#L235
We probably have to filter the parameters there based on the type.
Are you interested in sending a PR?

Hi @awaelchli I am also new to PL but I am hoping to contribute. Can I pick this up?

Would be great! The help is very much appreciated!

Thanks. How are we planning to approach this? I mean should we just set the lazy layer parameters to zero or something? I have also written a very basic test that captures this should I begin a pull request?

@vatch123 yes, please send that PR :)

Hey @kingjr,
Would you mind providing the full trace and a reproducible example with the BoringModel ?
I am getting a slightly different error, so I think there might be 2 issues with this new UninitializedParameter.
import torch
from torch.nn.parameter import UninitializedParameter

class Model(torch.nn.Module):

    def __init__(self):
        super().__init__()
        self.model = UninitializedParameter()

model = Model()
print([p.numel() for p in model.parameters()])
*** ValueError: Attempted to use an uninitialized parameter in <method 'numel' of 'torch._C._TensorBase' objects>. This error happens when you are using a `LazyModule` or explicitly manipulating `torch.nn.parameter.UninitializedParameter` objects. When using LazyModules Call `forward` with a dummy batch to initialize the parameters before calling torch functions

Best,
T.C

Hey @vatch123,
By using print([0 if isinstance(p, UninitializedParameter) else p.numel()  for p in model.parameters()]) there: https://github.com/PyTorchLightning/pytorch-lightning/blob/233f252bb427c930be8e7ca56fe115b637278b8d/pytorch_lightning/core/memory.py#L226, we should have a hacky fix for now.
@awaelchli Should we move summary after the first batch call, as parameters are actually generated properly ?
Best,
T.C

Hey @tchaton,
Thanks for the help. But I guess the trainable_parameters property will also break this. I guess we need to look for a different solution or there would be multiple positions where we would need to apply this hack.
https://github.com/PyTorchLightning/pytorch-lightning/blob/233f252bb427c930be8e7ca56fe115b637278b8d/pytorch_lightning/core/memory.py#L226-L232

The uninitalized parameter is a new feature in torch. The older version of torch running in CI fails to recognize uninitialized variables. How to get around that if anyone has any ideas?

@awaelchli @tchaton instead of running it after the first batch, what if we:

Removed model summary from the core trainer and made it a callback
Ran the callback on train end of the beginning to ensure all the initialization is correct

IMO we should strive to make the model summarization an independent component which we can re-integrate with the training framework. It's not far from that, except this could take an nn.Module instead of a LightningModule: https://github.com/PyTorchLightning/pytorch-lightning/blob/04dcb1786d0ea41dfdb1e73493b214169e365c6c/pytorch_lightning/core/memory.py#L185-L192


A4 Page Size leaving white edge when printed to PDF

Renderer
v3
Browser
Chrome
Operating System
MacOS
What happened?
When using the A4 Page Size snippet, and printing to PDF (setting the print dialog page size to A4), the resulting PDF has a ~1px white edge along the bottom and right sides.  It also adds a partially transparent black border along the edge of the background image.  I'm pretty sure that edge isn't part of the background image itself.
Increasing the page size, such as height, in the brew snippet does not help.  In the following image, you can see that the brew's "page size" was increased and thus overflowed to the next page when sent to PDF---yet the white edge remains:

This doesn't seem to be an issue with the US Letter page size.  I have the issue on my Mac (using Chrome and Preview), and @G-Ambatte has confirmed as well, I'm pretty sure on Windows.  Original report on reddit was also on Windows 11.
Just some quick scanning of Chromium Monorail:

Bug 914817 - Print with "Save as PDF" adds the white line on the page bottom - Opened 2018
Bug 1323671 - Page.printToPDF generates file with the white borders - Opened 2022

I suppose it might be worth checking how other page sizes turn out?
Code
No response

Correct: Windows 10 x64, on Chrome(s) 110.0.5481.178, 113.0.5634.1, and 113.0.5635.0

The only work around that I have found for this is to not use the Chrome Print process, instead using the Print using System Dialog option. Experimentally, this did not leave a visible line around the edge.

also not woking in Ubuntu with Chrome. Print using System Dialog doeesn't help.  This is a really basic issue - please provide a fix.

This is a really basic issue

As noted in the initial report, this is a Chrome/Chromium issue.  And it doesn't look like it a priority for the Chromium team.  You can open those links above and star the issues, but that is about as much as can be done.

But it's not working in Firefox either.
On Fri, 21 Jul 2023, 06:52 Gazook89, @.***> wrote:

This is a really basic issue
As noted in the initial report, this is a Chrome/Chromium issue. And it
doesn't look like it a priority for the Chromium team. You can open those
links above and star the issues, but that is about as much as can be done.
—
Reply to this email directly, view it on GitHub
https://github.com/naturalcrit/homebrewery/issues/2716#issuecomment-1644978350,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA3DIG576WCCJC4QZJ7JOLXRIDIBANCNFSM6AAAAAAVR3NQYQ
.
You are receiving this because you commented.Message ID:
@.***>

But it's not working in Firefox either.

Ah, that is news to me. Unfortunately I can’t get to computer for a few hours to check it out.
To be sure, the issue you have is a single pixel width line at the bottom of your page?  If it’s any thicker (like an inch), it’s likely the brew is set as a US Letter page size (the default) but the page size when sending to print (to pdf or paper) is set to A4 which is typically the default page size outside of the US. Just mentioning this possibility as that is a quick fix. Otherwise I’ll get online later and check out Firefox.

I'm on Ubuntu, so may be an edge case.  Chromium and Firefox no good.
I'll retest and update you as well with more specifics.
On Fri, 21 Jul 2023, 17:22 Gazook89, @.***> wrote:

But it's not working in Firefox either.
Ah, that is news to me. Unfortunately I can’t get to computer for a few
hours to check it out.
To be sure, the issue you have is a single pixel width line at the bottom
of your page? If it’s any thicker (like an inch), it’s likely the brew is
set as a US Letter page size (the default) but the page size when sending
to print (to pdf or paper) is set to A4 which is typically the default page
size outside of the US. Just mentioning this possibility as that is a quick
fix. Otherwise I’ll get online later and check out Firefox.
—
Reply to this email directly, view it on GitHub
https://github.com/naturalcrit/homebrewery/issues/2716#issuecomment-1645755420,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA3DIGNM2A4CX2U3ERB2EDXRKNCZANCNFSM6AAAAAAVR3NQYQ
.
You are receiving this because you commented.Message ID:
@.***>

Firefox is doing the same
Ubuntu 22.04
firefox 115.0.2 (64-bit
Regards
Jonathan Els
On Fri, 21 Jul 2023 at 17:33, Jonathan Els @.***> wrote:

I'm on Ubuntu, so may be an edge case.  Chromium and Firefox no good.
I'll retest and update you as well with more specifics.
On Fri, 21 Jul 2023, 17:22 Gazook89, @.***> wrote:

But it's not working in Firefox either.
Ah, that is news to me. Unfortunately I can’t get to computer for a few
hours to check it out.
To be sure, the issue you have is a single pixel width line at the bottom
of your page? If it’s any thicker (like an inch), it’s likely the brew is
set as a US Letter page size (the default) but the page size when sending
to print (to pdf or paper) is set to A4 which is typically the default page
size outside of the US. Just mentioning this possibility as that is a quick
fix. Otherwise I’ll get online later and check out Firefox.
—
Reply to this email directly, view it on GitHub
https://github.com/naturalcrit/homebrewery/issues/2716#issuecomment-1645755420,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA3DIGNM2A4CX2U3ERB2EDXRKNCZANCNFSM6AAAAAAVR3NQYQ
.
You are receiving this because you commented.Message ID:
@.***>

A Discord user has reported that setting a -1px margin may fix this issue.
margin:-0px -1px -1px -0px; /*seems for some reason there is a 1px line showing up on print, hard to spot */
I haven't yet had time to investigate this personally, but I'm recording it here so that it doesn't get lost in the churn.


Cannot install or remove extensions

Steps to reproduce

Install flarum
install your bazar extension
try to install another extension

Expected behaviour
The other extension should be installed via bazar backend management.
Actual behaviour
I get an oops something went wrong error
Configuration
Operating system:  Debian 8
Version of Bazaar: latest
Version of Flarum: latest
Other extensions:
Flarum core 0.1.0-beta.7
PHP 7.1.12-2+0~20171207160754.12+jessie~1.gbp5c91f3
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, session, standard, mysqlnd, PDO, xml, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, json, exif, mcrypt, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, soap, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Zend OPcache
EXT flagrow-analytics 0.6.0
EXT flarum-approval v0.1.0-beta.7
EXT flarum-bbcode v0.1.0-beta.5
EXT wiwatsrt-best-answer v0.1.0-beta.11
EXT davis-customfooter v0.1.0-beta4
EXT cbmainz-de 0.7.1
EXT flarum-emoji v0.1.0-beta.6
EXT flarum-english v0.1.0-beta.7
EXT flarum-auth-facebook v0.1.0-beta.6
EXT flagrow-bazaar 0.2.4
EXT flagrow-upload 0.6.0
EXT flarum-flags v0.1.0-beta.7
EXT avatar4eg-geotags 0.2.0
EXT sijad-recaptcha 0.0.2
EXT flagrow-guardian 0.1.2
EXT flarum-likes v0.1.0-beta.6
EXT sijad-links 0.1.0-beta.6
EXT flarum-lock v0.1.0-beta.7
EXT flarum-markdown v0.1.0-beta.5
EXT s9e-mediaembed 0.3.2
EXT flarum-mentions v0.1.0-beta.7
EXT manelizzard-notify 0.2.1
EXT sijad-pages 0.1.0-beta.3
EXT avatar4eg-share-social 0.2.3
EXT xengine-signature 0.1.2
EXT terabin-sitemap v1.0.2-beta.2
EXT flarum-sticky v0.1.0-beta.7
EXT flarum-subscriptions v0.1.0-beta.6
EXT jordanjay29-summaries 0.2.0
EXT flarum-suspend v0.1.0-beta.7
EXT flarum-tags v0.1.0-beta.8
Base URL: https://astronomie.community
Installation path: /var/kunden/flarum/httpdocs
**Logs**:
POST https://astronomie.community/api/bazaar/extensions
{
"errors": [
{
"code": 500,
"title": "Internal server error",
"detail": "Flagrow\Bazaar\Exceptions\ComposerException: Your requirements could not be resolved to an installable set of packages. in /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Composer/Utils/ComposerIO.php:17\nStack trace:\n#0 /var/kunden/flarum/httpdocs/vendor/composer/composer/src/Composer/Installer.php(474): Flagrow\Bazaar\Composer\Utils\ComposerIO->writeError('Your req...', true, 1)\n#1 /var/kunden/flarum/httpdocs/vendor/composer/composer/src/Composer/Installer.php(226): Composer\Installer->doInstall(Object(Composer\Repository\InstalledFilesystemRepository), Object(Composer\Repository\CompositeRepository), Object(Composer\Repository\PlatformRepository), Array)\n#2 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Composer/Commands/BaseCommand.php(113): Composer\Installer->run()\n#3 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Composer/ComposerCommand.php(31): Flagrow\Bazaar\Composer\Commands\BaseCommand->run(Array)\n#4 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Jobs/RequirePackage.php(15): Flagrow\Bazaar\Composer\ComposerCommand->requires('datitisev/flaru...')\n#5 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Jobs/ComposerJob.php(62): Flagrow\Bazaar\Jobs\RequirePackage->handleComposer(Object(Flagrow\Bazaar\Composer\ComposerCommand), Object(Flagrow\Bazaar\Models\Task))\n#6 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Jobs/ComposerJob.php(100): Flagrow\Bazaar\Jobs\ComposerJob->handle(Object(Flagrow\Bazaar\Composer\ComposerEnvironment), Object(Monolog\Logger))\n#7 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Extensions/PackageManager.php(51): Flagrow\Bazaar\Jobs\ComposerJob::launchJob(Object(Flagrow\Bazaar\Models\Task))\n#8 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Repositories/ExtensionRepository.php(202): Flagrow\Bazaar\Extensions\PackageManager->requirePackage('datitisev/flaru...')\n#9 /var/kunden/flarum/httpdocs/vendor/flagrow/bazaar/src/Api/Controllers/InstallExtensionController.php(49): Flagrow\Bazaar\Repositories\ExtensionRepository->installExtension('datitisev/flaru...')\n#10 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Api/Controller/AbstractSerializeController.php(97): Flagrow\Bazaar\Api\Controllers\InstallExtensionController->data(Object(Zend\Stratigility\Http\Request), Object(Tobscure\JsonApi\Document))\n#11 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Api/Controller/AbstractCreateController.php(23): Flarum\Api\Controller\AbstractSerializeController->handle(Object(Zend\Stratigility\Http\Request))\n#12 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Handler/ControllerRouteHandler.php(53): Flarum\Api\Controller\AbstractCreateController->handle(Object(Zend\Stratigility\Http\Request))\n#13 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/DispatchRoute.php(69): Flarum\Http\Handler\ControllerRouteHandler->__invoke(Object(Zend\Stratigility\Http\Request), Array)\n#14 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\DispatchRoute->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#15 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\DispatchRoute), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#16 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#17 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/SetLocale.php(51): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#18 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\SetLocale->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#19 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\SetLocale), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#20 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#21 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/AuthenticateWithHeader.php(58): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#22 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\AuthenticateWithHeader->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#23 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\AuthenticateWithHeader), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#24 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#25 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/AuthenticateWithSession.php(36): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#26 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\AuthenticateWithSession->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#27 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\AuthenticateWithSession), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#28 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#29 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/RememberFromCookie.php(39): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#30 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\RememberFromCookie->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#31 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\RememberFromCookie), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#32 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#33 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/StartSession.php(48): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#34 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\StartSession->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#35 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\StartSession), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#36 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#37 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Api/Middleware/FakeHttpMethods.php(33): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#38 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Api\Middleware\FakeHttpMethods->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#39 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Api\Middleware\FakeHttpMethods), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#40 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#41 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/Middleware/ParseJsonBody.php(31): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#42 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Http\Middleware\ParseJsonBody->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#43 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Http\Middleware\ParseJsonBody), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#44 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#45 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Api/Middleware/HandleErrors.php(45): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#46 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(212): Flarum\Api\Middleware\HandleErrors->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#47 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Dispatch.php(88): Zend\Stratigility\Dispatch->dispatchCallableMiddleware(Object(Flarum\Api\Middleware\HandleErrors), Object(Zend\Stratigility\Next), Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), NULL)\n#48 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/Next.php(160): Zend\Stratigility\Dispatch->__invoke(Object(Zend\Stratigility\Route), NULL, Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\Next))\n#49 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-stratigility/src/MiddlewarePipe.php(111): Zend\Stratigility\Next->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response))\n#50 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/AbstractServer.php(55): Zend\Stratigility\MiddlewarePipe->__invoke(Object(Zend\Stratigility\Http\Request), Object(Zend\Stratigility\Http\Response), Object(Zend\Stratigility\NoopFinalHandler))\n#51 /var/kunden/flarum/httpdocs/vendor/zendframework/zend-diactoros/src/Server.php(157): Flarum\Http\AbstractServer->__invoke(Object(Zend\Diactoros\ServerRequest), Object(Zend\Diactoros\Response), Object(Zend\Stratigility\NoopFinalHandler))\n#52 /var/kunden/flarum/httpdocs/vendor/flarum/core/src/Http/AbstractServer.php(36): Zend\Diactoros\Server->listen(Object(Zend\Stratigility\NoopFinalHandler))\n#53 /var/kunden/flarum/httpdocs/api.php(16): Flarum\Http\AbstractServer->listen()\n#54 {main}"
}
]
}

Okay so the php flarum info output shows you have many other extensions installed, how did you install these? The issue you see is related to a requirement of one extension, which one depends on the extensions you have installed and the extension you tried installing. Could you be more specific on how to reproduce this state?

Hi,
I´ve installed the the extensions by using command line: sudo -u flarum composer require...
All files are owned by flarum. How can I give you further debugging infos?
Currently I can´t use the bazaar app anymore because I get a 504 error. Php memory has 1G.

Okay so you explain that to reproduce I can install Flarum, then Bazaar and then any extension via Bazaar. But your php flarum info output lists these installed extensions, eg:

EXT jordanjay29-summaries 0.2.0
EXT sijad-pages 0.1.0-beta.3
EXT manelizzard-notify 0.2.1

and many more non-core extensions. My question is:

How did you install these if you can't use Bazaar?
Which extension did you install after which your Flarum install went broken?

Also please post your composer.lock file, please upload it as a file.

I´ve installed flarum a while ago. Two days ago I configured it for the first time and installed different extension only via command line. After I had installed different extensions by command line I found your app for managing extensions. After I raised the php memory your extension worked for the first time, but installation or removing failed with the error code above.
To reproduce my problem:

Install flarum
Install different apps on command line
activate the apps (on activation failure: set flarum to debug mode true)
install bazaar, activate bazaar
try to install or remove apps via bazaar.

Github doesn´t support this file type. You can download my file at https://cloud.speibox.de/s/Vq8g6vt6wQmZTPy

Could you also share your composer.json, seems the lock by itself isn't enough 😞

Of course: https://cloud.speibox.de/s/SAHSpgbHbJoDIJt

What specific extension did you try to install with Bazaar. Because currently I can easily install your dependencies.

I tried Dashboard. I don´t really know, what is / was causing the problem. For now it´s working again. Perhaps it´s a cache issue or could it be that your bazaar api key is limited for use of different site parallel? Could your api key have a time-out?

When I get a 504 error (sometime when I load the bazaar admin page) I see at chrome developer console the following error:
admin-266f5493.js:17326 Uncaught TypeError: originalConfig.apply is not a function
at Object.vdom.attrs.config (admin-266f5493.js:17326)
at admin-266f5493.js:1167
at admin-266f5493.js:2052
at forEach (admin-266f5493.js:911)
at Function.m.render (admin-266f5493.js:2052)
at admin-266f5493.js:2254
at forEach (admin-266f5493.js:911)
at redraw (admin-266f5493.js:2250)

I've been thinking about this issue and concluded the following;

You have been able to access bazaar, while installing an extension it throws (correctly) a 500 explaining that your server requirements aren't met. This indicates that the installation halted halfway and nothing was installed, as such nothing happened that can break your forum.
With the above being true you explain you have installed extensions previously and Flarum is now showing an error.

Could you perhaps install a clean version with only Bazaar and see if that works? If so, we can exclude Bazaar as the culprit in your issue.

I´ve installed a fresh flarum and installed your app by command line (composer require...)
On the first visit of bazaar I got an javascript error:
TypeError: originalConfig.apply is not a function [Weitere Informationen] admin-2ea8ea7e.js:1930:81 render/vdom.attrs.config http://test.astronomie.community/assets/admin-2ea8ea7e.js:1930:81 scheduleConfigsToBeCalled/< http://test.astronomie.community/assets/admin-2ea8ea7e.js:163:32 m.render/< http://test.astronomie.community/assets/admin-2ea8ea7e.js:327:34 forEach http://test.astronomie.community/assets/admin-2ea8ea7e.js:94:54 m.render http://test.astronomie.community/assets/admin-2ea8ea7e.js:327:1 redraw/< http://test.astronomie.community/assets/admin-2ea8ea7e.js:399:1 forEach http://test.astronomie.community/assets/admin-2ea8ea7e.js:94:54 redraw http://test.astronomie.community/assets/admin-2ea8ea7e.js:397:1
After reloading the page I could access bazaar. First I tried to install the Deutsch app. This failed with the same javascript error. Nginx log says: connection timed out.
I use php 7.1 and my php settings are:
php_admin_value[open_basedir] = /var/kunden/flarum:/usr/share/php:/tmp:/var/ngx_pagespeed_cache:/var/run/nginx/cache php_admin_value[disable_functions] = dl,passthru,shell_exec,system,proc_open,popen,show_source php_admin_value[memory_limit] = 1G php_admin_value[max_execution_time] = 360
Nginx pagespeed is off, there is no opcache or fastcgi_cache.

You should try using cronjob processing.
Update your bazaar constraint in your composer.json to match dev-master then run composer update --prefer-dist --no-dev -o. After that follow the instructions for cronjob processing, which will offload the request to nginx:
https://github.com/flagrow/bazaar/wiki/Cron-task-processing

I'm closing this as it's been some time since the last activity.
Let us know if you experience this again :wink:

Please note the suggestion to use dev-master is no longer valid as that branch has been readied up for Flarum beta 8.


MVP

Initial goal:

php_http.client => alias to something providing Http\Adapter\HttpAdapter (note that the adapter and client interfaces are supposed to be merged
php_http.message_factory => alias to something providing Http\Message\MessageFactory
php_http.uri_factory => alias to something providing Http\Message\UriFactory

If no configuration is given, this bundle provides services using the ::find as factory methods. This is the zero-config scenario. those could be named php_http.client.default and so on. the default service could be used with a service decorator when several clients are needed.
Alternatively, the user can specify the client (adapter) class / factory class in which case a service instantiating that class directly is created. This would replace the factory service definition and be php_http.client.default as well.
A third option is to specify the service explicitly, allowing to configure clients with custom initialization. In that case, the php_http.client.default can still exist (e.g. as a base for service decorator) but the explicit service is aliased.

Sounds like a good plan. I really like the fallback possibilities.

Great initiative!

done in #6


Un-delete still documented X509_STORE_CTX_set_verify

It should not have been removed.

And the name doesn't want to change to set1?

Why set1?

(closing this PR, as it has been merged into master)


Duplicate releases in tabs and more-dropdown.

https://github.com/sindresorhus/refined-github/issues/new?assignees=&labels=change+request&template=change_request.md

Is this intended, why?

Thanks for the bug report! The bug disappears when you resize the window back and forth, so it's probably a new calculation issue on load

I can't recreate this. Is this still an issue?

I'm on an x230, HD screen as well. I might have a sidebar open as well, reducing the width.

I have this all the time on my small laptop screen


[ci] remove conda from R CI jobs

On https://github.com/microsoft/LightGBM/pull/3405#issuecomment-728353296, I see the Windows CI jobs on GitHub Actions failing with this output
==> WARNING: A newer version of conda exists. <==
  current version: 4.8.3
  latest version: 4.9.2

Please update conda by running

    $ conda update -n base -c defaults conda

#
# To activate this environment, use
#
#     $ conda activate test
#
# To deactivate an active environment, use
#
#     $ conda deactivate

I'm worried that this is another case where programs writing to stderr in GitHub Actions Windows jobs causes those jobs to fail. I don't know if this recently started failing because of software updates in GitHub Actions images (https://github.com/actions/virtual-environments/commits/main) or something else.
This PR proposes just updating conda to the latest version every time, to hopefully avoid this warning.

UPDATE I see the same failures on the Windows jobs in #3515 too:https://github.com/microsoft/LightGBM/pull/3515/checks?check_run_id=1408108173
But not on builds from last night. https://github.com/microsoft/LightGBM/actions/runs/365273180
So whatever changed, I think it was in the last 24 hours.

Ok, that did not work. https://github.com/microsoft/LightGBM/pull/3573/checks?check_run_id=1409528379
Trying to upgrade to the action to 2.0 next.

Seems like the combination of always updating conda + using v2 of this action fixes it

@StrikerRUS let's move https://github.com/microsoft/LightGBM/pull/3405#issuecomment-728642475 here, since #3405 already has a lot of comments.
That's a good point! There is actually an r-lib/setup-pandoc  action we could try: https://github.com/r-lib/actions/tree/master/setup-pandoc
Let me try on my fork tonight. If that works, I'll just change this PR.

Seems ok on my fork!
https://github.com/jameslamb/LightGBM/pull/38/checks?check_run_id=1409970898
I just pushed some changes that remove conda completely for R jobs

I've requested a new approval, @StrikerRUS , since I totally changed this PR since the last time you reviewed and approved


Going to Babble admin panel shows low-level error message when Babble is disabled

When Babble is disabled, going to yourforum.example.com/admin/chats shows Discourse error page (a page with a big frowning smiley :( that says: error loading /babble/topics.json).
Visiting yourforum.example.com/babble/topics.json gives:
{
errors: [
"ApplicationController::PluginDisabled"
]
}

(We are using the forum in Finnish, for what it's worth.)

I've fixed this in the latest :+1:

Thanks :)


x/mobile/cmd/gomobile: bind failure

What version of Go are you using (go version)?

$ go version
1.14.3

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

What did you do?

gomobile bind -target=ios xxx
What did you expect to see?
command-line-arguments failed: exit status 1
no exported names in the package "command-line-arguments"
no exported names in the package "command-line-arguments"
no exported names in the package "command-line-arguments"
no exported names in the package "command-line-arguments"
What did you see instead?
success

@bianzhifeng Thanks for the report. Can you please provide the following information:

go env output
what package did you run it on

/cc @hyangah @hajimehoshi


No file such as "labelProbs.pkl"

I am trying to run the continuous variables part of the repository. There is no such file as "labelProbs.pkl". This is not generated by any of the other files. Am I missing something?
labelProbs = pickle.load(open('./discretized_data/labelProbs.pkl', 'rb'))

My apologies for that. Those are supposed to be generated before training, I have just added the relevant code

Thank you very much! Weirdly, I was still able to generate the results without the labelProbs.pkl file. On another note, could you please help me understand the structure of the generated results file?

I have multiple dictionaries containing the keys 'visits' and 'labels'. How can I differentiate the visit on a subject-level basis?

The 'visit' key contains a list of ascending numbers such as [702, 715, 1224, 1595, 1748, 2997, 3061, 3070, 3714, 3881, 3950, 4091] and so on. I am guessing these are timestamps but am unsure if they are hours or days?

Also, the next few lists contain diagnosis codes (e.g., 10200) and lab test names and values, but I am unsure how to map the tests to the values since the length of consecutive lists don't match.

Thank you in advance!

Yeah I think it is not actually used because for the experiments we just create an unconditioned copy of the training dataset (so loading the probabilities was just an artifact of other exploration that I forgot to remove). As for your other questions, each dictionary consisting of a labels vector and visits list is a single subject. The labels are static information (so not sequential meant to mirror the visits) such as patient phenotypes, demographic info, etc. The visits (depending if you’ve already discretized or not) are then a list of separate visit time steps each of which is a tuple. The tuple should have 4 elements: a list of variable indices (which correspond to diagnosis codes), a mask of the present labs conducted, the value indices of those labs (because the model operates over discretized labs which are converted into binary variables), and finally an index for the time span since the previous visit (which again is binarized). After running discretized convert the structure will change slightly with all the distressed variables being sampled from. Hopefully this helps, but if you have any further questions feel free to copy a dictionary example into your follow up comment so that I can see exactly which stage it’s at and then point directly to the different structures.

Thank you for the explanation!  The visits is a list of tuples where each tuple is a time step. Those numbers [263, 702, 852, ... 10200] are medical codes (the indexToCode mapping can extract the true numerical codes). Next the two empty lists are a lack of labs (because the overall structure is generally initial step with diagnoses and then lab time series for the rest of their stay). 24.35 is the age at admission.
The next tuple then has not codes but a blood pressure of 76, glucose of 118, etc. and those labs occur 0.3 hours after the first visit. It continues like this for the rest of the visits.

Perfect -- thank you for the clear explanation!

Sorry about the back-to-back questions. I was able to make sense of all the labels in visits, but I wasn't able to find a file that maps the static labels to their corresponding information. Could you please let me know which mapping file I can use to make sense of the labels?

Sorry about the back-to-back questions. When I convert the medication labels using the indexToLabel mapping, there are still some codes remaining that do not have a corresponding label. Would you happen to know what these represent? Here is an example, I'd like to know what the codes '5070', '4019', etc., represent. Thanks in advance!
['5070', '4019', '82133', '82300', '82021', 'E8190', '9973', '7815', '7905', '7936', '7965', '7865', '3891', '8622', '9904', '966', '3324', '8314', '8659', '7935', '7906', '7867', '9672', 'Acetaminophen', 'Potassium Chloride (Powder)', 'Potassium Chloride', '5% Dextrose', 'AcetaZOLamide Sodium', 'Milk of Magnesia', 'D5W', 'Ursodiol', 'Magnesium Sulfate', '0.9% Sodium Chloride', 'FoLIC Acid', 'Morphine Sulfate', 'Aspirin', 'Albuterol 0.083% Neb Soln', 'Bisacodyl', 'Fentanyl Citrate', 'Propofol', 'Docusate Sodium (Liquid)', 'Gentamicin', '5% Dextrose', 'Furosemide', 'Atenolol', 'Docusate Sodium', 'Meperidine', 'Pantoprazole Sodium', 'Acetaminophen', 'Ipratropium Bromide Neb', 'Cefazolin', '0.9% Sodium Chloride', 'Metoprolol Tartrate', 'Lansoprazole Oral Suspension', 'Metoclopramide', 'Phenylephrine', 'Ferrous Sulfate', 'Bisacodyl', 'Levofloxacin', 'Acetaminophen', 'Lactated Ringers', 'Fentanyl Citrate', 'Albuterol', 'Furosemide', 'Atenolol', 'Calcium Gluconate', 'Ferrous Sulfate', 'Lorazepam', 'Metoprolol Tartrate', 'Potassium Chloride', 'Levofloxacin', 'Enoxaparin Sodium']

Hello, no worries please ask as many questions as you'd like. Assuming you mean the static, top-level labels, not every code corresponds to a label phenotype (they are just a handful of conditions which do not cover all codes or patients). If you mean indexToCode then every index should map to something, but the numbers you're referring to are likely diagnosis codes (which are numerical rather than word descriptions). You can google ICD9 diagnosis codes or there should be a MIMIC table with the description information. The mapping could also contain modality information (diagnoses, medications, etc.) and the descriptions which would be helpful, but the code for these experiments didn't. Finally, you're right that most of these are in the first visit only. This is just from how we structured the data in our experiments where to capture the lab time series (going to the hospital a patient has a bunch of top-level diagnosis and medication information and then a series of labs during the course of their stay) we have a single top-level diagnoses/medications visit and then a series of lab visits. If a patient has a second hospital stay the pattern will repeat and there will be another medication visit further along. Note this is not a requirement just how we chose to represent the patient (you could aggregate the lab information to include in the single top-level visit or you could have separate models for top-level visits and then lab time series conditioned off of the top-level information.

This is really helpful! Thank you again. Additionally, I wrote some code to convert the synthetic data (after running it through the discretized_convert.py file) to a complete .csv file containing one row per visit for each subject, separate procedure, diagnosis and medication names and every other metric present in the training data. Would you be interested in having this code as part of your repository? If yes, I can send a pull request. :)

Sure that would be great, feel free to send a pull request!

Done!

How is the hcup_ccs_2015_definitions.yaml file created? I understand that it groups different diagnoses into a wider class, but is there an official tool to help with this, so that this can be replicated for custom data?


fix incorrect SourcePacketExtension parse

…tExtension (and was missing the rid attribute)

i was about to add asserts in the catch blocks but i think it works better to just have the test method throw.

@ibauersachs this look alright now?

Just the curly braces position in the setup() method.

alright hopefully that is all of it.  please squash when you merge.