Detection results darknet vs. trt engine

Hi jkjung,
first of all thank you very much for your awesome work. With this repo I can achieve approx. 2 FPS with custom yolov4-608 weights. That said, I am experiencing quite a view detection differences when running with tensorRT compared native darknet. In darknet, all objects even with low confidence threshold of 0.3 are detected. In TensorRT and the trt_yolo.py script, I am getting a lot of "bulked" False positives at confidence up to 0.6. This leads me to setting the confidence thresold in the trt_yolo script to 0.65, in order to only get the right detections. The downside unfortunatelly is, that True Positives at confidence around 0.3 are filtered out. Is there any parameter in the conversion scripts I have to tune in order to filter out bulked false positives in the trt engine?
Thank you in advance!

One possible cause of such a discrepancy is the use of FP16 optimization.  And it's easy to verify if that's the case.  You could try to build a FP32 TensorRT engine by setting builder.fp16_mode to False in the code.
https://github.com/jkjung-avt/tensorrt_demos/blob/82dbbacc86cf558b1f70fca938f0e13130b281f2/yolo/onnx_to_tensorrt.py#L74

Thanks for the quick answer, will try and give feedback!

I tried with FP32 model but unfortunately, false positives still remain and dominate below a threshold of 0.66. Any other suggestions to solve this? Thank you in advance!

I have just reviewed my own code (yolo_layer cuda kernel and postprocessing).  I think it's doing the exact same computation as what AlexeyAB's darknet does.  So I don't quite have an idea right now...
Maybe you could double check whether you do the same image preprocessing for training and inferencing, especially on the "aspect ratio" of the images.

Thanks for reporting this issue.
Please try modifying this line of code: https://github.com/jkjung-avt/tensorrt_demos/blob/1b274b874b59c0c7ed05f5efb2d89c0089fa3a15/utils/yolo_with_plugins.py#L56
with the following:
    box_confidences = detections[:, 4] * detections[:, 6]

Let me know if that makes a difference for you.

Thanks jkjung, will definetly try and let you know, if it worked!

Hi jkjung, I tried but unfortunatelly, results are still the same! Any other ideas? Thank you!

Sorry, I'm out of ideas for now.  If I think of something later on, I will let you know.

Hello,@mosch91-syn .You need add a lot of negative sample data to train so that the model can reduce mis-recognition.

Hello,@mosch91-syn .You need add a lot of negative sample data to train so that the model can reduce mis-recognition.

I'm closing this issue and will continue to track it here: https://github.com/jkjung-avt/tensorrt_demos/issues/315


Exclude<keyof this , ... > not working

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms:keyof this Exclude
Code
class B{
    b: string;
}
class A extends B{
    a: keyof this = 'b';// work;
    c: Exclude<keyof this, keyof B> = 'a';// not work;
    d: Exclude<'a'|'b'|'c'|'d', keyof B> = 'a';// work;
}

Expected behavior:Exclude<keyof this, keyof B> === Exclude<'a'|'b'|'c'|'d', keyof B>
Actual behavior:i don't know what type is that

It appears to work outside of the class:
class B {
	public b?: string;
}
class A extends B {
	public a: keyof this = "b"; // work;
	public c: keyof this = "a";
	public d: Exclude<"a" | "b" | "c" | "d", keyof B> = "a"; // work;
}
// "a" | "c" | "d" | "b"
type a = keyof A;
// "b"
type b = keyof B;
// "c" | "a" | "d" | "b"
type c = A["c"];

// a is identical to c
type d = c extends a ? (a extends c ? true : false) : false;

// "a" | "c" | "d";
type e = Exclude<c, b>;
type f = Exclude<a, b>;

keyof this can't go "through" a conditional type because it can't be expanded into a union because it needs to be lazily evaluated. It can be validated through direct assignments, which is why a: keyof this = 'b'; works.
The only reason we (as humans) know what should happen is that we understand the full intent of Exclude, but Exclude is not a language primitive.


Normalize audio with loudnorm instead of volumedetect.

The current volumedetect approach measures the loudest part of the file and increases the gain until it's just shy of clipping. This is a good first approach, but a bit naive for actually targeting a certain loudness. More dynamic tracks will still seem much quieter than tracks continually pushing the loudness ceiling.
loudnorm takes more time to process audio than volumedetect, but in return will properly normalize to a target loudness using the EBU R128 loudness standard. See: http://k.ylo.ph/2016/04/04/loudnorm.html

Oh yeah, I coded that and it was really bad. I was just upset with the random jumps in loudness and so I wanted to push low volume music up and push high volume music down.
I can test that this still works later tomorrow since just reading it, it seems fine unless someone else wants to trial it and attest to its function


Add JDK 21 to CI

Self explanatory

looks like src/sbt-test/sbt-osgi/test-10-multi-project-dependsOn-includePackage-versions/build.sbt:    scalaVersion := "2.12.6" needs a version bump

looks like src/sbt-test/sbt-osgi/test-10-multi-project-dependsOn-includePackage-versions/build.sbt:    scalaVersion := "2.12.6" needs a version bump

Thanks! I'll do this now

@SethTisue Thanks for the pickup, this is now fixed


feat: Updated the summary page

Please note that there are a lot of moving elements that are not final in this PR, specifically:

The group ordering or the attributes inside groups will change on the server
Attribute titles will change from the server
Attribute icons are still not final, and will change, currently we have 3 shades of colors that will most likely change to 5, instead of emojis we will most likely use icons.
The red panel on top of the card is currently static, it will be modified based on a new field from backend.
the styling of the Divider will change
None of the UI elements are currently final, (padding, text style, colors etc).

Please also note that this PR has a side-effect of changing the background color of the app's theme to material-light-blue from material-blue. This is in sync with the current mocks.
Example summary card:

[ ]    info • Specify type annotations • packages/smooth_app/lib/pages/product/new_product_page.dart:40:45 • always_specify_types
[ ]    info • Specify type annotations • packages/smooth_app/lib/pages/product/new_product_page.dart:239:39 • always_specify_types
[ ]    info • Avoid method calls or property accesses on a "dynamic" target • packages/smooth_app/lib/pages/product/new_product_page.dart:340:32 • avoid_dynamic_calls
[ ]   error • The method 'isAttributeImportant' isn't defined for the type 'ProductPreferences' • packages/smooth_app/lib/pages/product/new_product_page.dart:340:32 • undefined_method
[ ]    info • Avoid method calls or property accesses on a "dynamic" target • packages/smooth_app/lib/pages/product/new_product_page.dart:367:28 • avoid_dynamic_calls
[ ]   error • The method 'isAttributeImportant' isn't defined for the type 'ProductPreferences' • packages/smooth_app/lib/pages/product/new_product_page.dart:367:28 • undefined_method


SwissQRBill.PDF options Request

Hi,
with PDFKit you can set a option called autoFirstPage to false.
Would be wonderful, if you could add this option, because i'm not able to change the page margin on the first page
Best,
Sascha

SwissQRBill requires a fixed page margin to be conformant with the specifications. But I agree that it should be more flexible and this should only apply to the page on which the payment part is rendered.
This requires some internal refactorings, but I will look into it.

With SwissQRBill v4, it is now possible to create the PDF document independently from the QR bill.
This allows you to change the margin and use any other PDFKit features.
To conform the specifications, the page the QR bill gets attached will still use the margin required by the specifications.
Example:
import { createWriteStream } from "node:fs";

import PDFDocument from "pdfkit";
import { SwissQRBill } from "swissqrbill/pdf";

const data = {
  amount: 1994.75,
  creditor: {
    account: "CH44 3199 9123 0008 8901 2",
    address: "Musterstrasse",
    buildingNumber: 7,
    city: "Musterstadt",
    country: "CH",
    name: "SwissQRBill",
    zip: 1234
  },
  currency: "CHF",
  debtor: {
    address: "Musterstrasse",
    buildingNumber: 1,
    city: "Musterstadt",
    country: "CH",
    name: "Peter Muster",
    zip: 1234
  },
  reference: "21 00000 00003 13947 14300 09017"
};

const stream = createWriteStream("zero-margin.pdf");

const pdf = new PDFDocument({ margin: 0 });
const qrBill = new SwissQRBill(data);

pdf.text("This page has zero margin!");
pdf.pipe(stream);

qrBill.attachTo(pdf);

pdf.end();


Explain std::bad_alloc message (MLDB-1355)

More friendly error messages when out of memory:
--------------------------[Exception thrown]---------------------------
time:   2016-04-28T21:11:04Z
type:   std::bad_alloc
pid:    66164; tid: 66165
what:   std::bad_alloc

2016-04-28 17:11:04.096 javascript {
   "details" : {
      "context" : {
         "error" : "Out of memory.  A memory allocation failed when performing the operation.  Consider retrying with a smaller amount of data or running on a machine with more memory.  (std::bad_alloc)"
      },
      "functionArgs" : [],
      "functionName" : "_fail_memory_allocation"
   },
   "error" : "Executing builtin function _fail_memory_allocation: Out of memory (std::bad_alloc)",
   "httpCode" : 400
}

+1 (you can of course ignore the double spaces in the message :-)


azcopy fails to copy file with metadata more than 1000 characters

Which version of the AzCopy was used?
10.11.0 and 10.4.3
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Linux Centos 7
What command did you run?
azcopy_v10 copy '/mnt/resource/repsxssbt_data/partitions//test/system_test/Z-14-JA-A-APISystem-4835-2021-07-01.tar' 'https://xyz.blob.core.windows.net/649f887b-181d-41fb-8ee6-c93f3a15cbd6/system/transformation/Z-14-JA-A-APISystem-4835-2021-07-01-05-01_.tar?sig=gashgashg' --overwrite=true --metadata='name=Z-14-JA-A-APISystem-4835-2021-07-01-05-01_execution-7755-2021-07-01-42-43_afdhgsafdhf.tar;description=;userDescription=hsxjahs data corresponding to the Output ID: 47beera9d-2c3f-422e-b27a-feadb217de27;catalogueId=3d1wqwb9f-c96c-431c-bcd7-f74122c4813d;typeName=pams_file;location=https://lal-es-wev.lower-abclebv.abcglb.com/api/dal/v1/fileaccess/download/649rdf87b-181d-41fb-8ee6-c93f3a15cbd6/raw/apiclient_zjaaapisystem_271879d41003/transformation/Z-14-JA-A-APISystem-4835-2021-07-01-05-01_execution-7755-2021-07-01-42-43_gkbl-ghardmdS.tar;correlationId=34e933c3-2377-480a-a85e-cf3a5026d21b;classifications={"ownership_type": "client", "xjajsxjhsxvhv": "xasbxsasx", "sxsxssxs": "Full"};territory=asxsax xasxs;registrationSourceSystem=oph;clientDisplayName=soph_testing;sxasxsaxas=USD;sxsaxsaxsaxsas=sxsx xsaxas;testfnadeYearEnd=2017-12-31 00:00:00.000000;testfnadeYearStart=2017-01-01 00:00:00.000000;generalkjdfadSystem=GENERIC-MYSQL;sxasxsxvfvv=4692;minimumghardmdValue=10.0;numberFormat=XXX,XXX.XX;parentEntityName=APIClient_3173_2021-07-01-04-58;periodviewedEnd=2018-12-31 00:00:00.000000;periodviewedStart=2018-01-01 00:00:00.000000;uuid=47b5ee9d-2d3f-429e-b27a-feedb217de27;responses=[{"method": "PUT", "type": "portal", "url": "https://portal-oph-ue-dev.abcinternal.com//api/Integration/ghardmds-execution/88998152-6516-4d73-9be1-9a310c81883a/61381957-9fda-eb11-a7ad-0050f26b281d"}];ophSystemId=271879d4-1003-4820-b2d3-8f9e38aaa87f;ophSystemName=warrsdgaggs|hhgahsgja|jsa;runId=23e2ccf7-22a2-4baf-86bc-8bcc1218c970'
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
metadata length cannot be more than 1000 characters
panic: metadata string is too large:
How can we reproduce the problem in the simplest way?
keeping metadata more than 1000 characters
Have you found a mitigation/solution?
No

Hey @suvirgupta
Thanks for reaching out!
It's because of this code
MetadataMaxBytes     = 1000
...

type JobPartPlanDstBlob struct {
...
Metadata       [MetadataMaxBytes]byte
...
}

Hi @suvirgupta We limit the size of metadata (and other properties) by design to limit the size of the job plan file. Are you able to use any other workaround to limit your metadata size?


Add ci for mono linker project

@mmitche

Is this a Microsoft associated project? I'm guessing so?

Yup!


A strange flutter ERROR I can not resolve

It's been a long time I can not resolve my problem. The full project is uploaded here: https://github.com/goodmanworld/flutter_test
I know the backend works correctly and wherever I try to print the response from the backend side, it shows what I want. Also backend works properly with the Postman. BTW, I can upload the backend part also if needed.
This is the error I do get:
type 'Null' is not a subtype of type 'String'
PS: Please don't close this topic. I posted my question on Stackoverflow and other websites but couldn't get any help!

Closing as a duplicate of https://github.com/flutter/flutter/issues/92727

PS: Please don't close this topic. I posted my question on Stackoverflow and other websites but couldn't get any help!

The issue tracker is for bug reports in Flutter itself; it is not a support forum for individual projects. Not receiving a response in other forums doesn't change the fact that this is off-topic here.
In the future, please don't open duplicates of issues just because you don't like the resolution.

I see that this is also a duplicate of https://github.com/flutter/flutter/issues/92774, where I clearly told you that this was off-topic here and pointed you to relevant resources.
If this pattern of ignoring our feedback that this is off-topic continues, it will be considered abuse of our system.


Theme for GeSHi

Issue type: feature
Related issues: #38 #56

Description
GeSHi is a popular syntax highlighter for native highlighting in a PHP server. It is essentially a statically configured highlighter that's more like Highlight.js than Pygments, but similar to both.
I'd like to transfer of my Nord styling package nord-geshi to the arcticicestudio organisation. The support is as extensive as the GeSHi syntax grammars will allow - some grammars have keywords and functions bunched together and need separation upstream.
Example
CSS

Java

XML

Hi @lmn8 :wave:, thanks for your contribution :+1:
That's a detailed and well documented port, looks like you've already invested a lot of time into it. This is more than just a “rough blueprint“ for an official port and I would be happy to add it to the list of official ports, but it will be a while before I can actually start to work on new ports again. There are 50+ other port requests in the backlog and there are still many other important tasks that need to be done to help to reduce the current maintenance overhead.
Anyway, since your port is almost ready and could be used right away it shouldn't take too long to migrate it. Only needs the integration into Nords website and documentations as well as requires me to familiarize myself a bit with GeSHi  to provide support for problems.
I'm still writing on a large post about the current state as well as the future plans & roadmap of Nord in order to clarify often upcoming questions and make sure everyone understands why Nord is currently not being extended and developed as fast as it used to be. This will maybe also contain some thought about setting up a polling and feedback system like Fider to allow users to vote for most popular ports, but my hope is that the GitHub Discussions is available as open beta like already for some hand-picked projects.
I'll also like to use this post to inform about required tasks and steps for new ports that are not always visible for users as well as the way how community created ports will be migrated to the official ports (i.e. handling granting/managing permissions for original author(s), unifying docs/tools with other ports etc.)


SoC target refactoring

This changeset splits CoreSightTarget in two:

SoCTarget is an architecture-independent representation of the SoC. It replaces CoreSightTarget under pyocd.core.
CoreSightTarget moves to pyocd.coresight (where it should have been in the first place) and adds the Arm specifics to the SoC representation.

A few other changes:

Moved the vendor and part number related attributes from Target to SoCTarget.
The part number and part families will be set to PART_NUMBER and PART_FAMILIES class attributes if they exist.
Added a cache.read_code_from_elf option to control whether the ElfReaderContext gets added to the target context stack when an ELF file is set on the target (mostly affecting the gdbserver).

And some target-related cleanup:

Corrected names of the target constructor parameters for built-in targets. (Nothing was broken, just misleading.)
Changed to PEP8-compliant name MEMORY_MAP for the built-in target class-attribute memory maps.

/morph test

/morph test


[vscode-X] Fix "Open in integrated terminal"

In the file explorer, when right-clicking on a file then "Open in integrated terminal", the terminal still opens at path /home/onyxia/work
Probably due to:
# .bashrc#L112
cd /home/onyxia/work

Tested on vscode-r

Hi @cdugeai, indeed I can reproduce the bug and you correctly identified the cause. That being said, I'm probably enclined to leave as is because the whole point of forcing this configuration for the working directory is that we mount persistent volumes at /home/onyxia/work, and so we want to enforce this directory for users to work in. If we leave the default instead, the terminal will open at /home/onyxia/ and so if the container crashes, the whole working data of the user will be lost. So even if this rule has undesired consequences like you point out, I think the pro outweighs the con.
Note that their could be specific configuration in the VSCode API that enables to properly configure this, something to keep in mind for possible evolutions @ihiverlet

I think this behaviour is not incompatible with what you want. Because the explorer default folder is work, all the files and folders in the explorer panel are inside of the work directory. So if we click on any visible folder and Open in Integrated Terminal, the terminal would open in a subdirectory of work.
For instance here, if I right click dir2.1  -> Open in Integrated Terminal, it should open in /home/onyxia/work/dir2/dir2.1 that is still in the persistent volume:


Client checks for entitlements before channel posts

The final step of react-reply "backend" support - the client self-filters invalid messages based on whether or not it has entitlements to post to the channel.

closes hnt-7728


Extended assembly support for execute

Details
Hello,
while writing a new csx for husky exec I tried to use System.Linq and failed to do so.
This results propably from the static assembly list here:
https://github.com/alirezanet/Husky.Net/blob/07f36179c589c825595b97116fa6fe82ab5514ab/src/Husky/Cli/ExecCommand.cs#L37-L39
How about we create a mechanism like the following in a csx file:
// cs_reference System.Linq;
using System.Linq;

Which hints the execution to include that particular assembly.
Greetings
Xemrox

Hi,
We already have this feature I'm not sure why you have a problem with LINQ but for example, in this repository, I am using using System.Text.RegularExpressions; in commit-lint.csx file.
using System.Text.RegularExpressions;

private var pattern = @"^(?=.{1,90}$)(?:build|feat|ci|chore|docs|fix|perf|refactor|revert|style|test)(?:\(.+\))*(?::).{4,}(?:#\d+)*(?<![\.\s])$";
private var msg = File.ReadAllLines(Args[0])[0];

if (Regex.IsMatch(msg, pattern))
   return 0;

Console.ForegroundColor = ConsoleColor.Red;
Console.WriteLine("Invalid commit message");
Console.ResetColor();
Console.WriteLine("e.g: 'feat(scope): subject' or 'fix: subject'");
Console.ForegroundColor = ConsoleColor.Gray;
Console.WriteLine("more info: https://www.conventionalcommits.org/en/v1.0.0/");

return 1;

I wan't aware of the #r and #load within csscript.
Here is a broken example which can be fixed by adding a #r "System.Linq"
using System.Linq;

private var test = new [] {"a", "b", "c"};
private var test2 = test.First();


update standard ERC721 contracts to include metadata

update L1/L2StandardERC721 to include baseURI
by allowing baseURI to be specified when deployed the standard contract. This doesn't have clear support to update the string after deployment. Another option could have been to make the contracts ownable - which increases flexibility however also increases trust

This standard should cater to all general nfts with off-chain metadata. can be treated as a transitory step - support for on-chain nfts will be added by further updating the standard or introducing a new one

Codecov Report

Merging #475 (865f7e6) into develop (b281d60) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #475   +/-   ##
========================================
  Coverage    72.10%   72.10%
========================================
  Files           59       59
  Lines         1828     1828
  Branches       281      281
========================================
  Hits          1318     1318
  Misses         510      510

Flag
Coverage Δ

contracts
86.72% <ø> (ø)

core-utils
53.79% <ø> (ø)

data-transport-layer
29.25% <ø> (ø)

message-relayer
83.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b281d60...865f7e6. Read the comment docs.


SDMEXT-546 (Setup PR merge with cf push)

Jira: SDMEXT-546
The workflow will be triggered whenever a pull request is merged into the develop branch.
Tested the workflow on one of the local space : https://github.com/cap-java/sdm/actions/runs/12233005419

Hi @vibhutikumar07 : Looks fine, are we also planning to add integration test run with this PR?

Hi @vibhutikumar07 : Looks fine, are we also planning to add integration test run with this PR?

Hi @ashishjain14 : As of now, the integration job has not been completed. Once it is finalized, we will proceed with the integration.


Feature | Add a NullAuthenticator to overwrite defaultAuth

This PR adds a NullAuthenticator class that allows a user to use the null object pattern, and provides a way to remove an authenticator that has already been set.
This has been addressed in #402 and #385.
This PR only adds a new file, so it should not have any backwards compatibility issues.

Ah, thanks @patrickcarlohickman! I've been meaning to submit a similar PR for a few weeks now. Good stuff :)


[feature request] qwen model's query logn-scaling attn

Qwen use qwen-style dynamic ntk  and logn-scaling to generate better text in case of long context text input.
The trtllm implementation of qwen does not support logn-scaling right now, which result in low quality outputs.
I would like to provide a implementation. However, its a little diffcult for me to understand the gpt_attention.
My vanilla thought is multiplying q tensor with logn tensor before call gpt_attention. But every seq_len_idx value of q tensor is needed for caculating logseq_len_trained(seq_len_idx). I don't know how to get seq_len_idx value, especially in packed tensor mode.
Would you please give some help on this？Is there a convenient way to achieve this(even in a dirty hard-code way)?

like this, I finished it. commit link
c++ Implement the code: link

like this, I finished it. commit link
c++ Implement the code: link

@Tlntin Hi, thank you for reply
I am using trtllm release v0.7.0 and qwen 1.0, I added another RotaryScalingType type and modified update_rotary_base_n_scale func directly to support qwen-stype dynamic ntk. After saw the code in main branch, I am not sure my modification is right or not, there are some other places invoking update_rotary_base_n_scale. = =
Nevertheless, what you post looks like only about rope base update. logn attn is still missing, I have tested and find that removing logn-scaling will hurt the performance of qwen agent
I find some commented code about logn scaling in your repository, but it looks like not functional in case of packed tensor mode. When enable paged attention, the qkv tensor's shape is [1, num_tokens, qkv_dim], is that right？

it seems your C++ code may work better, more similar to raw pytorch code!
About logn_scale, I think you may need do C++ implementation as same!
you need to change plugin code.
TensorRT-LLM/cpp/tensorrt_llm/plugins/gptAttentionPlugin/gptAttentionPlugin.cpp at 6cc5e177ff2fb60b1aab3b03fa0534b5181cf0f1 · NVIDIA/TensorRT-LLM (github.com)
there has two function
enqueueContext/enqueueGeneration
TensorRT-LLM/cpp/tensorrt_llm/plugins/gptAttentionCommon/gptAttentionCommon.cpp at 6cc5e177ff2fb60b1aab3b03fa0534b5181cf0f1 · NVIDIA/TensorRT-LLM (github.com)
TensorRT-LLM/cpp/tensorrt_llm/plugins/gptAttentionCommon/gptAttentionCommon.cpp at 6cc5e177ff2fb60b1aab3b03fa0534b5181cf0f1 · NVIDIA/TensorRT-LLM (github.com)
I think logn scale implementation may has some difficulty.
my code  logn_scaling can only use without gpt attention plugin, but seems it work not well, so I commented it!

The trtllm implementation of qwen does not support logn-scaling right now, which result in different infer result.
@handoku I have same question,do you hace any update? thanks

The trtllm implementation of qwen does not support logn-scaling right now, which result in different infer result.
@handoku I have same question,do you hace any update? thanks

sry, no pregress yet. Maybe make the trtllm team more aware of this painful problem and help to solve it could save us.

@Tlntin have you ever tested TRT-LLM Qwen1 on long input? I found it is empty output for inputs as long as 6K (smaller than 8K,the training length).

@Tlntin have you ever tested TRT-LLM Qwen1 on long input? I found it is empty output for inputs as long as 6K (smaller than 8K,the training length).

i tested,  it work well, you need to same change like above.

@Tlntin have you ever tested TRT-LLM Qwen1 on long input? I found it is empty output for inputs as long as 6K (smaller than 8K,the training length).

i tested, it work well, you need to same change like above.

Did you mean use changes in your commit

Did you mean use changes in your commit

yes

It is supported on Today's update

https://github.com/NVIDIA/TensorRT-LLM/pull/2562


Update gpu.go with additional RocmLinuxGlob

Add additional RocmLinuxGlob for e.g Fedora
This leads to a correctly discovered GPU library in the log.
However something else needs to be fixed as a cpu_avx2 server is loaded.

Outdated.


LibFileSystem: Port to Windows

This PR requires #1918.
This PR is ready for review, but must be rebased before merging. First 3 commits belong to #1918. Update: rebased.
Ported only functions that are actually used. Note: TempFile is not used anywhere.

Any thoughts on defining realpath to _fullpath? or just using _fullpath on windows?

I took the path of implementing path functions myself in LexicalPath, and I don't want to mix this up with _fullpath or Win32 APIs.


website of identicon is down identicon-php.org

identicon-php.org don't want to response...

I do not maintain the website anymore due to the amount of daily server requests.
If you were using the website for generating Identicon please use the library instead from your server side.


feat: PluginHandle

New PluginHandle API for Plugins to interact with the app by e.g emitting platform events.

TODO: Use gilrs effect system for better mouse movement. https://gitlab.com/gilrs-project/gilrs/-/blob/master/gilrs/examples/ff_pos.rs?ref_type=heads


[TESTING ONLY]

Codecov Report

Merging #2650 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
+ Coverage   86.27%   86.27%   +<.01%
==========================================
  Files         320      320
  Lines       65858    65857       -1
  Branches     7325     7325
==========================================
+ Hits        56817    56819       +2
+ Misses       7859     7856       -3
  Partials     1182     1182


enh(sqf) support the latest version 2.02 of Arma 3.

Changes

Updated sqf.js language file to support the latest commands introduced with version 2.02 of Arma 3.
Updated CHANGES.md

Checklist

[ ] Added markup tests, or they don't apply here because...
[x] Updated the changelog at CHANGES.md

Also, what is your involvement with SQF?

Also, what is your involvement with SQF?

R3vo is community member. I'm Arma developer, I will review later today but I don't expect any problems here

Please follow PR template and update CHANGES.md also.

Please follow PR template and update CHANGES.md also.

Done, although I have no clue about markup tests so I left it unchecked.

Looks good for me.
But might aswell do 2.04 directly https://community.bistudio.com/wiki/Category:Arma_3_Development_Branch:_New_Scripting_Commands
2.04 will be out before Discord updated their highlightjs :D

Looks good for me.
But might aswell do 2.04 directly https://community.bistudio.com/wiki/Category:Arma_3_Development_Branch:_New_Scripting_Commands
2.04 will be out before Discord updated their highlightjs :D

True, should we also update the list with new preprocessor instructions?

@R3voA3 Thanks so much!


[18.09] cluster: set bigger grpc limit for array requests

backport:

https://github.com/moby/moby/pull/38103 cluster: set bigger grpc limit for array requests

to address:

https://github.com/moby/moby/issues/37997 docker service ls | Error response from daemon: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5097134 vs. 4194304)

git cherry-pick https://github.com/moby/moby/pull/38103/commits/489b8eda6674523df8b82a210399b7d2954427d0
$ git cherry-pick -s -x 489b8eda6674523df8b82a210399b7d2954427d0
[grpc 6ca0546f25] cluster: set bigger grpc limit for array requests
 Author: Tonis Tiigi<EMAIL_ADDRESS> Date: Mon Oct 29 17:44:11 2018 -0700
 3 files changed, 13 insertions(+), 5 deletions(-)

no conflicts

@andrewhsu the upstream PR was updated (only the commit message); can you cherry-pick the new commit?h ttps://github.com/moby/moby/pull/38103/commits/f1f50eddae5e15c0f5fd3b7f16fa7fef253f869c f1f50eddae5e15c0f5fd3b7f16fa7fef253f869c

dockerd[2888]: time="2019-03-27T02:27:29.990822362+03:00" level=error msg="agent: session failed" backoff=100ms error="rpc error: code = ResourceExhausted desc = grpc: received message larger than max (4270560 vs. 4194304)" module=node/agent node.id=7wittan6h0xbkva01kuy1empm
Server Version: 18.09.3
Kernel Version: 4.19.0-0.bpo.2-cloud-amd64
Operating System: Debian GNU/Linux 9 (stretch)
Architecture: x86_64
docker service list | wc -l 667

Is this fix part of 18.09.09? also i see that @rnz  got an error on 18.09.3. So i have a around 600 services also. Will i get the same error


Clarifying displayed name

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/6274

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MikePlumleyMSFT PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


RouterFS Documentation & Logs

Things to think of while documenting RouterFS:

Documenting RouterFS under its use case may work better than documenting it under its name. That is, as a user the title "using lakeFS and s3 without changing spark application code" means something to me, while "Route FileSystem" does not.
Document the LakeFSFS client version that'll work with RouterFS (it should include the solution that we will come up with in https://github.com/treeverse/hadoop-router-fs/issues/11)
non-lakeFS users should be able to understand how to use RouterFS for their use cases (e.g. accessing s3 and gcs from the same Spark application)

Definition of done
Docs are available at https://docs.lakefs.io/ and as part of a client README

@Jonathan-Rosenberg we are good to close this issue right?

definitly


Upgrade caniuse-lite version

@soul-wish final touch for tests to pass.

@yuriyalekseyev I hope in this case yarn.lock file should be also updated. What do you think?

@soul-wish forgot about it, done.


Week 3: Adding comments to portfolio site

Should we begin to implement testing at this stage?

I'm a little worried that my deleting methodology (doPost() in DeleteDataServlet.java) might be overly expensive when applied to a lot of data, say 10000 comments, but I can't find a better way to do it

I tried several times to write a JUnit/Mockito test for DataServlet and have run into errors every time--the current DataTest is the least problematic test, but it doesn't run properly yet let alone pass and I'm not sure why...

Testing commit reverted for stashing, requesting final review before merging this pull request

looks good overall; please fix failing format checks.

Fixed the checking error--sorry it took three commits! Will start making PRs for one feature at a time and squashing all commits.


link not working

hi, the LRPD link does not work : https://github.com/IDRnD/lrpd-paper-code/blob/main

Thanks for noticing. Updated link, please try again


Email notifications?

Hey,
love what you did! I'm not using it yet but plan on doing it very soon. One thing that is missing IMHO is the ability to subscribe via email to the status updates. I know this is hosted on GitHub pages, so this is a bit tricky. Here is an idea I had. It's a bit hacky, I must admit, and totally incomplete.

Have an RSS feed of the incidents
Have a MailChimp account, or something similar, and integrate it with statuspage
Have something that sends email for new RSS entries

I looked at the MailChimp "RSS to email" feature, but it's not fast enough, it would be a day late, that's useless. It doesn't look like it's possible with IFTTT or Zapier, but I might have missed something.
It would be easy to host a service doing that, but I would prefer not to have to host an app to do that, but have something easy.
Maybe there is nothing that fits the vision you have, but I thought I would share my thoughts and maybe someone can complete those and we can come up with a decent solution :)
Cheers

It would be easy to host a service doing that, but I would prefer not to have to host an app to do that, but have something easy.

That's exactly what I'm thinking. The main idea behind this project is to make it super easy to set up and maintain a status page.
If someone comes up with a clever idea to set up a notification system I'm all ears for it.

Yeah, same. I actually started to write thinking that MailChimp would work, but before sending it, I double checked, and the fact it is not in near real-time is a killer, and totally agree this should be mad simple to setup and use. Feel free to close in the meantime.


png-afl fuzzer is broken

The afl fuzzer target in ./png-afl currently exits with SIGABRT as soon as any decoding errors occurs, causing AFL to think for example "CRC mismatch" is a crashing input file.

I'm currently running the fuzzer for 1 hour straight, this might be a setup issue?

Maybe I'm not expressing myself clearly :)
The fuzzer is running. Its just i find 50 crashes in 1 minute according to afl, but looking at them none are actual crashers.

Seems to me the png-afl\src\main.rs exits with SIGABORT when an error is returned from png decoding.
for file in png-afl/out/crashes/*; do cargo run --example show "$file"; done

The default memory limit of png is 64MB while the default for afl is 50MB, I think you would need to run  the fuzzer with:
cargo afl fuzz -m 100 ./target/release/png-afl
instead.

The afl fuzzer should run without any crc code enabled, I don't know if this is the case or not. Otherwise, the fuzzer will mostly get stuck on reproducing valid checksums instead of producing interesting file contents.

You're right, raising memory limit is solving the issue I was seeing! 100m not enough for me though, but 200 seems to do it!

Glad I opened this issue, or I would be stuck forever.
The following line disables crc check on decoding https://github.com/image-rs/image-png/blob/master/src/decoder/stream.rs#L245
assuming afl is invoked with env RUSTFLAGS='--cfg fuzzing' set

That should probably both be explain in a readme in the png-afl directory. Otherwise it's hard to reproduce the setup.

Yea, I'm working on sth, PR inc soon. This is what I have now

## Build fuzzer binary

RUSTFLAGS='-C codegen-units=1' cargo afl build

NOTE: the RUSTFLAGS is only needed on Linux (and not if using gold linker), see https://github.com/rust-lang/rust/issues/53945

## Run fuzzer

    RUSTFLAGS='--cfg fuzzing' cargo afl fuzz -m 200 -i fuzzing_seeds -o out target/debug/png-afl

### More info

https://rust-fuzz.github.io/book/afl/tutorial.html

Also not sure this is the correct way to use cfg!().. reading up on it now

Shouldn't --cfg fuzzing also be provide during built time? if cfg!(fuzzing) gets compiled and not dynamically configured afaik.

We could also provide an explicit feature in Cargo.toml for this.

It should yes.
Yea, setting the feature in Cargo.toml sounds good to me, less moving parts for the user.


Bad rendering when a variable value changes from server side rendering to client side rendering

Environment

Operating System: Windows_NT
Node Version:     v16.17.0
Nuxt Version:     3.6.2
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, colorMode, runtimeConfig
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://codesandbox.io/p/sandbox/keen-sea-66ccg7
Describe the bug
We have a useDimensions composable which returns the dimension of the window.
We also have a simple vue file:

    {{ dimensions.width }}

 1200" class="red">
      Who let the dogs out

Wof Wof

which based on the useDimensions composable returns either DIV1 or DIV2.

The webpage renders on server side using a default preset value (390x900) which will render DIV2 (in production this should only happen the first time you access the website).
When the onmounted event happens we update the resolution using the actual resolution (let's say 1920x1080).
The content of the two divs update accordingly, however the classes on the div remain the same: https://ibb.co/ZWFxyHk

The update happens in the onmounted event, at first the website should have been rendered using the initial resolution 390x900 and then it should have been updated to the 1920x1080 dimensions.
Additional context
As a workaround we use CSS to render different elements on different dimensions, however sometimes it makes more sense to render some elements based on JS logic (like the number of elements of a carousel).
v-show should fix this issue as both divs are printed and the updated, however in some cases you might not want to use it (you don't want to print 1000 elements).
Logs
No response

This is called a hydration error. It's an additional constraint that exists when you are rendering an app on server + client - the initial state of both apps (namely, whatever renders the html) needs to match.


False "PHP switched" message

$ switch-php 7.2
PHP switched ✔

You are now using PHP 5.4.45
$ which php
/usr/local/bin/php
$ php --version
PHP 5.4.45 (cli) (built: Nov  9 2017 14:09:48)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies

I assume it's because my PHP is not installed via brew. It'd be nice if the tool can show error instead of saying it was successful

I assume it's because my PHP is not installed via brew.

If this means you're not using Homebrew at all, or you're not using it to install PHP, then switch-php is not the tool for you. switch-php is not an independent tool for downloading and installing the PHP version you want (e.g. it's not like n for node.js), rather, it piggybacks off of Homebrew to do all the downloading/installing/switching/linking etc.
However, I'm pretty sure that it will throw an error of some sort if you don't have brew installed (haven't tested this but would be the expected behavior). switch-php actually verifies that the php version you request is already installed, and so if it's not installed (or I'd imagine if you haven't installed brew), it's going to let you know that said php version needs to brew installed before you can switch to it.
So I'd love to hear more about your setup... If you could let me know more about how you've installed php, as well as maybe the output of brew list and brew services list, that would be awesome!

so I already installed php7.2 via brew while waiting for response but I can still repro issue with php7.1
 switch-php 7.1
PHP switched ✔

You are now using PHP 7.2.16

Here is output of commands you provided:
brew list
ack			cairo			gettext			jemalloc		libtool			php54			telnet
ansible			cask			giflossy		jpeg			libvpx			php71			terraform
ant			colordiff		glib			kubernetes-cli		libxml2<EMAIL_ADDRESS>	texi2html
apr			coreutils		gmp			lame			libyaml<EMAIL_ADDRESS>	tidy-html5
apr-util		curl-openssl		go			libcroco		libzip			pixman			unfs3
arcanist		delve			go-swagger		libev			mercurial		pkg-config		unixodbc
argon2			dep<EMAIL_ADDRESS>	libevent		nghttp2			postgresql		watch
aspell			dinghy			gobject-introspection	libffi			node			python			watchman
autoconf		emacs			graphite2		libidn			openldap		rbenv			webp
autoenv			ffmpeg			graphviz		libmetalink		openssh			readline		x264
awscli			fontconfig		harfbuzz		libpng			openssl			rtmpdump		xvid
bash-completion		freetds			httpd			libpq<EMAIL_ADDRESS>ruby			xz
bat			freetype		hub			librsvg			pandoc			ruby-build		yarn
boost			gd			icu4c			libsodium		pango			slackcat		yasm
brotli			gdbm			imagemagick		libssh2			parallel		spdylay			zsh
c-ares			gdk-pixbuf		jansson			libtiff			pcre			sqlite			zsh-completions
> brew services list
Name       Status  User   Plist
emacs      stopped
httpd      stopped
<EMAIL_ADDRESS>  started myusername<EMAIL_ADDRESS><EMAIL_ADDRESS>  stopped
postgresql stopped

Looks like my path might be messed up? I installed php7.2 via brew but then I needed to add path to brew's php via export PATH="$(brew --prefix php72)/bin:$PATH"

Aha, yep I bet it's the PATH that's causing the issues...
So when you install any PHP version via Homebrew, you'll see something akin to the following message:
If you need to have<EMAIL_ADDRESS>first in your PATH run:
  echo 'export PATH="/usr/local/opt/php@7.2/bin:$PATH"' >> ~/.zshrc
  echo 'export PATH="/usr/local/opt/php@7.2/sbin:$PATH"' >> ~/.zshrc

This is an optional step, but a lot of people end up running it. The problem is that once you've done this, the only way to switch between PHP versions is to remove/edit that line in your bashrc/zshrc file.
Brew has a handy link command (which switch-php makes use of) that manages your versions via symlinks instead of manipulating the PATH. Basically, there's a symlink at /usr/local/bin/php that just points to whatever version of PHP you want; you would update it for example via brew unlink<EMAIL_ADDRESS>&& brew link<EMAIL_ADDRESS>This is how switch-php does the switching, so if you're manually defining the version you want in your bashrc/zshrc file, then that's going to override whatever switch-php tries to do.
To solve, you'll want to remove any lines in your bashrc/zshrc file where you are manually adding a PHP version to the PATH and instead make sure /usr/local/bin and /usr/local/sbin are in your PATH. Btw, if you want to learn more about PATH and how it works, I wrote an article on the topic 😉

thanks for help!

My pleasure 🙌

I'm running into a similar issue, but because PHP 5.6 was deprecated I had to install it a different way. I used:
brew tap exolnet/homebrew-deprecated
brew install<EMAIL_ADDRESS>
However, when I do a switch then version it still says 7.3:
$ switch-php 5.6 -v
 👀  Verifying that Valet is installed...
 🔍  Checking which PHP versions are installed...
 🔀  Switching to<EMAIL_ADDRESS> ==>  Stopping<EMAIL_ADDRESS> ==>  Unlinking<EMAIL_ADDRESS> ==>  Stopping<EMAIL_ADDRESS> ==>  Unlinking<EMAIL_ADDRESS> ==>  Linking<EMAIL_ADDRESS> ==>  Starting<EMAIL_ADDRESS> ✅  PHP switched

You are now using PHP 5.6.40
$ php --version
PHP 7.3.9 (cli) (built: Sep 10 2019 17:45:01) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.9, Copyright (c) 1998-2018 Zend Technologies

Here is my brew list | grep php:
php
php-cs-fixer
<EMAIL_ADDRESS>
And my brew services list:
Name    Status  User    Plist
php     stopped
<EMAIL_ADDRESS>started <username><EMAIL_ADDRESS>
I am on macOS Catalina, version 10.15.1.
Any thoughts? Could this be related?

@jalendport Quick bump

Hey @kwkevinlin, can you run echo $PATH in your Terminal and post the output in here?

Ah I wonder if that is it since this is a newly formatted computer. Here's the command and output:
$ echo $PATH
/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin

@jalendport In case the previous tag didn't go through


Missing vendor_compliance

Under id depau there is no vendor_compliance section

same under id pgcnf

Thanks for raising this @itamar-marom
Actually the vendor_compliance field is not meant to be compulsory. It is meant to be a clarification for vendor submissions if the name, type and description fields would not make it too obvious how vendors should submit their values.
For the cases you describe, I believe the field is not needed, specially being both types boolean and very clearly cut (IMO).
Do you believe they require further clarification? If so, would you mind suggesting a wording for it, ideally as a PR?

I didn't understand this, but now it logically make sense 😅
I'll close this since it's not relevant.


Microsoft.Web/sites/extensions ZipDeploy not supported

Bicep version
run bicep --version via the Bicep CLI, az bicep version via the AZ CLI or via VS code by navigating to the extensions tab and searching for Bicep
0.12.40
Describe the bug

"The property "name" expected a value of type "'MSDeploy' | 'onedeploy'" but the provided value is of type "'ZipDeploy'". Did you mean "'MSDeploy'"?bicep(BCP088)"
ZipDeploy is a supported way to deploy to Azure with Arm Templates. You can "force" Bicep to create the proper Arm Template with ZipDeploy as by using any('ZipDeploy').
resource deploy 'extensions@2022-03-01' = {
    name: any('ZipDeploy')
    properties: {
      packageUri: servicePackageLink
    }
  }

Resulting successful deployment.

The fact that resulted in an error is tracked with #9024 and the Web RP team needs to fix their swagger spec.

Confirmed to be a swagger issue. API functionality is still there. cc @naveedaz / @seligj95

Is there an issue tracking the fixes for the swagger definitions? @alex-frankel @naveedaz @seligj95


Enable credhub instance group (only for user apps)

Description
This enables credhub, but only as a thing for user applications: internal CF components do not attempt to use credhub (as the BOSH link is disabled).
Motivation and Context
Fixes #202
How Has This Been Tested?
Ran acceptance-tests-brain; requires the fixes in https://github.com/SUSE/brain-tests-release/pull/5
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code has security implications.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Closing this in favour of https://github.com/SUSE/kubecf/pull/281.


WIP: Initial HPA Support

Initial HorizontalPodAutoscaler support for RunnerSet via custom.metrics.k8s.io. The implementation is by exposing RunnerSet state metric called octorun_runnerset_runner_active_ratio collected by Prometheus and then converted by prometheus-adapter into Kubernetes metric series.
The example RunnerSet with HPA
apiVersion: octorun.github.io/v1alpha1
kind: RunnerSet
metadata:
  name: runnerset-sample
  labels:
    octorun.github.io/runnerset: myrunnerset
spec:
  runners: 3
  selector:
    matchLabels:
      octorun.github.io/runnerset: myrunnerset
  template:
    metadata:
      labels:
        octorun.github.io/runnerset: myrunnerset
    spec:
      url: https://github.com/octorun/test-repo
      image:
        name: ghcr.io/octorun/runner:v2.288.1
---
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
  name: runnerset-sample-autoscaler
  labels:
    octorun.github.io/runnerset: myrunnerset
spec:
  scaleTargetRef:
    apiVersion: octorun.github.io/v1alpha1
    kind: RunnerSet
    name: runnerset-sample
  minReplicas: 1
  maxReplicas: 10
  metrics:
  - type: Object
    object:
      metric:
        name: octorun_runnerset_runner_active_ratio
      describedObject:
        apiVersion: octorun.github.io/v1alpha1
        kind: RunnerSet
        name: runnerset-sample
      target:
        type: Value
        value: 600m

Sample HPA details
$ kubectl describe horizontalpodautoscaler.autoscaling/runnerset-sample-autoscaler
Name:                                                                                runnerset-sample-autoscaler
Namespace:                                                                               default
Labels:                                                                                octorun.github.io/runnerset=myrunnerset
Annotations:                                                                             <none>
CreationTimestamp:                                                                       Sat, 19 Mar 2022 03:47:18 +0700
Reference:                                                                               RunnerSet/runnerset-sample
Metrics:                                                                                ( current / target )
  "octorun_runnerset_runner_active_ratio" on RunnerSet/runnerset-sample (target value):  500m / 600m
Min replicas:                                                                            1
Max replicas:                                                                            10
RunnerSet pods:                                                                          2 current / 2 desired
Conditions:
  Type            Status  Reason              Message
  ----            ------  ------              -------
  AbleToScale     True    ReadyForNewScale    recommended size matches current size
  ScalingActive   True    ValidMetricFound    the HPA was able to successfully calculate a replica count from RunnerSet metric octorun_runnerset_runner_active_ratio
  ScalingLimited  False   DesiredWithinRange  the desired count is within the acceptable range
Events:
  Type    Reason             Age   From                       Message
  ----    ------             ----  ----                       -------
  Normal  SuccessfulRescale  33m   horizontal-pod-autoscaler  New size: 4; reason: RunnerSet metric octorun_runnerset_runner_active_ratio above target
  Normal  SuccessfulRescale  32m   horizontal-pod-autoscaler  New size: 5; reason: RunnerSet metric octorun_runnerset_runner_active_ratio above target
  Normal  SuccessfulRescale  27m   horizontal-pod-autoscaler  New size: 4; reason: RunnerSet metric octorun_runnerset_runner_active_ratio below target
  Normal  SuccessfulRescale  20m   horizontal-pod-autoscaler  New size: 3; reason: RunnerSet metric octorun_runnerset_runner_active_ratio below target
  Normal  SuccessfulRescale  19m   horizontal-pod-autoscaler  New size: 1; reason: RunnerSet metric octorun_runnerset_runner_active_ratio below target
  Normal  SuccessfulRescale  34s   horizontal-pod-autoscaler  New size: 2; reason: RunnerSet metric octorun_runnerset_runner_active_ratio above target


Syntax highlighting for JavaScript in HTML file breaks when "if" is on the same line as closing tag

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.0
OS Version: Linux x64 6.2.2-arch1-1c

Specifically when there's two (or more) <script> tags
Steps to Reproduce:

Open VSCode, whether with extensions, without via code --disable-extensions, "Reload with extensions disabled", or using https://vscode.dev/
Write some HTML with <script> tags inside
Close the tag on the same line as an if block ending (e.g. oneliners)
Look at the <script> tags after the one described above
No syntax highlighting (variable jumping/etc works though so it probably parses fine, but did not check much)

Example code:
<!DOCTYPE html>
<html>
  <head>
    <script>if (true) { console.log("semicolon and it's fine") };</script>
    <script>
      function $initHighlight(block, cls) {
        try {
          if (cls.search(/\bno\-highlight\b/) != -1)
            return process(block, true, 0x0f) + ` class="${cls}"`;
        } catch (e) {
          /* handle exception */
        }
        for (var i = 0 / 2; i < classes.length; i++) {
          if (checkCondition(classes[i]) === undefined)
            console.log("undefined");
        }

        return ( { test: 123 } );
      }
    </script>
    <script>if (true) { console.log("if without a semicolon on the same line as closing tag") }</script>
    <title>Syntax highlighting should be broken now</title>
    <script>
      function $initHighlight(block, cls) {
        try {
          if (cls.search(/\bno\-highlight\b/) != -1)
            return process(block, true, 0x0f) + ` class="${cls}"`;
        } catch (e) {
          /* handle exception */
        }
        for (var i = 0 / 2; i < classes.length; i++) {
          if (checkCondition(classes[i]) === undefined)
            console.log("undefined");
        }

        return ( { test: 123 } );
      }
    </script>
  </head>
</html>

Screenshot of the issue

Recreated on the latest version (1.77.0)


ciao-down run command

ciao-down should support a run command to allow the user to run a command via ssh on the instance.  This makes things easier for people who are building scripts around ciao-down as they don't need to determine the ssh details.

Moved to https://github.com/intel/ccloudvm/issues/4


Updated core editor setup classes.

Overview

Added ignore to settings dialog popup.
Customized message for each setting that will be changes.
Added preference item to disable ignore if needed.
Changed icons to blue and disabled icon updater.

Changes

Related to, but does not fix #3118

@SimonDarksideJ I did like the steam vr sdk settings window, but I didn't want to steal it, lol.


All EPGs broken?

Guide
https://iptv-org.github.io/epg/guides/en/bein.com.xml
Description
I just randomly open a few of the xml links on my browsers, all programs seem to stay at Feb 13 and Feb 14.  No updates since then.
Seems the entire EPG refresh process is broken for all guides.
The '.xml' link I included here is just one of many many examples (in fact all of them are like this it seems)

#2017


Localized content/bn/docs/tasks/tools/included/kubectl-convert-overview.md

Signed-off-by: Noor E Jannat Nafia<EMAIL_ADDRESS>Localizes content/bn/docs/tasks/tools/included/kubectl-convert-overview.md  to Bengali
This is an initial PR as may need some improvements!
Tracking issue: #31677

/label tide/merge-method-squash


updated clavin instructions

Clavin setup instructions were inside graph property worker/plugin directory. Also they were outdated. Trying to promote these under docs.

I updated the document following your suggestions. Please review and pull them into master.

Fixed the URL text with actual url. Please pull this.


0ad: add meta.mainProgram

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Could you remove with lib; too and use lib. explicitly while you are at it?

with lib in meta is fine to use, just over entire files and big sections is really discouraged.


Scaling Enterprise SKUs

How do you scale / control cluster size of enterprise SKUs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52d13e5b-f054-f271-3b74-844385dd5ed0
Version Independent ID: cd2b75c7-c1f1-0a82-1fa3-8d13fd0618af
Content: Scale an Azure Cache for Redis instance
Content Source: articles/azure-cache-for-redis/cache-how-to-scale.md
Service: cache
GitHub Login: @flang-msft
Microsoft Alias: franlanglois

@danielgerlag  Thanks for the question! We are investigating and will update you shortly.

@danielgerlag Thanks for reaching out. Unfortunately, enterprise SKU does not support scaling after creation. Cluster size can only be changed during creation.

Are there any plans on your roadmap to

Enable cluster resizing in the future?
Enable migrating to a larger enterprise SKU?

Yes, these features are on the roadmap, but we do not have any timelines yet.

@danielgerlag Thank you for your Question. If there are no further questions. I will go ahead and close this Git Issue.

@danielgerlag I will go ahead and close this case since there are no further action.


Use json for entire config and validate the configuration

Also:

rename identityProvider, loginProvider, accessProvider, etc to identityManager,
loginManager, accessManager, etc
Move keymasterIdentityProvider service chain and keymasterAccessIssuer service
chain to keymaster (common) code.
Add Binders to dynamically bind to upstream or identity or access or login
service on the fly.
Modify ServiceIdentifier to include loginManager and hosts.
Modify ServiceMatchers to match subdomain first and then match the
serviceIdentifier path or loginManager paths.

Current coverage is 95.18%

Merging #82 into master will not affect coverage as of e3034e7

@@            master     #82   diff @@
======================================
  Files           25      26     +1
  Stmts          332     353    +21
  Branches        13      11     -2
  Methods          0       0
======================================
+ Hit            316     336    +20
  Partial          0       0
- Missed          16      17     +1

Review entire Coverage Diff as of e3034e7

Powered by Codecov. Updated on successful CI builds.

@PeterFCaswell Please take a look at this code review.

@trane @PeterFCaswell I will push this as soon as all the checks pass. We can open a new issue, in case some of your concerns are not addressed


Write a C# program to convert string to dotcase

Description
Write a C# program to convert string to dotcase
Dotcase is a style of writing in which all letters are lowercase and spaces are replaced with periods.
Input  : "hello world"
Output : "hello.world"

How to contribute

Save the solution in program/ConvertStringToDotcase.cs file
Add ConvertStringToDotcase.cs file in convert-string-to-dotcase folder

!assign


Regarding SSL support

Hi team ,
Does Kundera support SSL for cassandra?

Hi @mayankqait,
Currently (version 3.12), Kundera does not support SSL for Cassandra. Can you tell us more about your use case?

Thanks for confirming. We are evaluating kundera and other JPA compliant datastores to be used in our application. Currently there is no use case for SSL but for a long term, we may need to support it.

@mayankqait we are not planning to add SSL support in this release for Kundera-Cassandra. But we can add in upcoming releases.
If any community member wants to add support for this feature, we are happy to help him/her.


PEP-8 and template cleanup

Went through most files looking for linter and obvious errors
Several big indentation change in templates
Resolves #88

All looks good. It looks like there was only one .py file with linter errors, is that correct or more to commit?

That's all I caught on this pass. Feel free to browse all files with linter on - more eyeballs can't hurt (I don't have template linter so there I was just inspecting visually).

Checked through .py files and templates again. All looks good. Going to merge in.


Gas tanks cannot be inserted into radiation collectors

How to reproduce:

Hold a gas tank in your hand, such as the plasma tank that spawns next to the radiation collectors on PackedStation
Click on a radiation collector

Radiation collectors are supposed to require the insertion of plasma tanks in order to generate power, but this is not currently possible. As a result, radiation collectors are currently unable to generate power.

Radiation collectors do generate power when hit with radiation. You can get power if the radiation storm hits a collector. It seems the singularity isn't generating radiation.

Referenced this issue in 6240 as generators in general don't take any fuel and should also take plasma tanks and produce power in proportion to the plasma used plus external factor such as radiation absorbed or time passage.


improvement(v2): customizable code snippet copy button

🚀 Feature
Currently, the background color of the code snippet copy button is not customizable.
Have you read the Contributing Guidelines on issues?
Yes.
Motivation
Some prism-react-renderer themes use a darker background, on which the copy button is barely visible.

It looks like that #2526 has fixed this problem. However, it'd be great to make other aspects customizable (e.g. uppercased letters for "COPY").

(e.g. uppercased letters for "COPY").

For these purposes, you need to swizzle the CodeBlock component, these are very special cases to make them customizable.


Update leafletgeopackage.md

Geopackage-js for Leaflet has moved to its own repo, as noted in https://github.com/ngageoint/geopackage-js/commit/4f76e1a4900249e89cf99995062ee0e98af7fa34

Thanks for your contribution @kgjenkins!


Zaupshop /buy is not working!

When updated to the latest rocket, command not working.

I'll look into it.


example of javascrip?

Is there an example of javascript constructing ar tracking?
I hope it can be combined with Babylonjs engine

Unfortunately, MindAR is deeply connected with three.js at the moment. So it cannot be used in Babylonjs unless something is done in a deeper layer.


Mass update

Hello,
Do you know about option to execute D2 mass update from third party application?
tnx

There is this part of the API for D2FS.  I got this from D2FS SDK Javadoc from OT site (v 16.4).
com.emc.d2fs.models.massupdateinformations
Class MassUpdateInformations
java.lang.Object
com.emc.d2fs.models.massupdateinformations.MassUpdateInformations
Since a mass update is just an update query (?) couldn't a person right a DFC Java class that connects, runs IDfQuery interface and updates the proper objects? Just an idea...and this would be "third party".


Anonymous functions with type parameters and function signature on left hand side sometimes don't type check when they should

See short example at https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVBjOA7AzgFzCjAF4iBXbDfASxwB4BBAPgAoAPALjEYEpvGYAN5gATgFN85UdjDsA3GAC+8zDgJgA5t1bZyAWwBG40b1LMweoydIUqtHBzMiJUmXMUq1eQgAtuTGx85jy2UJTUdNhOwmKS0rIKyqpYPmA0ASyswSQWAG5wNAAmYREO0ezOcW6ylEXiUDTY4kWeqkA
I'd expect h to work just like f, g and i.

now all of them type check


displayName property is not found in React HoC

When building React higher-order components, it's useful to set a displayName like this:
WrapperComponent.displayName = `Wrapped(${Component.displayName})`;

However Flow 0.53.1 complains that displayName is not found.
Test case:
https://flow.org/try/#0JYWwDg9gTgLgBAKjgQwM5wEoFNkGN4BmUEIcA5FDvmQNwBQdBArgHb7AQtwDuUyYAHgAKxMKgBccAN4BfAHwAKOnDgBhEpBZYWMSdjwwAdOvCdtMACoBPMFmGjUcgDR0AlHqpGTm89dv2IMTlpZThmNhgOLgB1PjBbKG8zHQUwB0kRQNRXEJUVShgmKC4BJK0daUMqtKyZOAB6OXoVGWa4WP4EsvNDABNgVDAAG2QrADlkECw4AF44AAMO+KxehQASKW6dPoHh0YmpmVd5toKimLiujWSYehkGXBHUdABZKy34LAAPGG1e9H0+GM13KMAEsmCsjo9XqcAsAAsBjxgEMhnAWBBCMAvnAYPDplgoMQoNDYW8PjtBiNxpNpnMyOSQeZaA9OKh4G8AKIseHINgrD6zHhxBSM0yg1z0Lk8vm4AVM7b9Kn7Wk0IA

I think this was resolved by this recent commit: https://github.com/facebook/flow/commit/de37062ea21cb4055d3f1b01bdbaa76461140fc8 which added displayName to the StatelessFunctionalComponent type, which is what this function is inferred as.

This works as of Flow 0.54.0


Use OOlama ans inference system for OpenAIAPI LLMAgent

There is testing related to this one (tool testing)

@maeste Giving this back to you since I'm not familiar with this part


Connection names and navigation text changes

Step 3c - Dynamics 365 for Fin & Ops appears to be Fin & Ops Apps (Dynamics
365)
Step 3c - Dynamics 365 connection is deprecated. Doesn't mean it can't be used, but with the documentation only being 4 months old, it's a sign of how quickly things move :)
Step 4a - navigation link (at least in my environment: don't know if localisation/translation may affect this?) is Data integration, not Data integrator

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b2c80b9-3567-7464-dee3-2f09423892b8
Version Independent ID: 21a8cf2f-a2e5-e688-b256-48c0a544dfb6
Content: Create a data integrator project (preview) - Finance | Dynamics 365
Content Source: articles/finance/finance-insights/create-data-integrate-project.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @ShivamPandey-msft
Microsoft Alias: shpandey

@rrhkpmg, this is helpful feedback. @ShivamPandeyMSFT  , please review.

Bug 603471 logged to track this issue.

@tonyafehr, FYI, you assigned the issue to wrong Shivam Pandey. Please correct it.

This topic has been updated to reflect these changes.


feat: support setting maxConcurrentChunks for Generic OpenAI embedder

Pull Request Type

[ x] ✨ feat
[ ] 🐛 fix
[ ] ♻ refactor
[ ] 💄 style
[ ] 🔨 chore
[ ] 📝 docs

Relevant Issues

resolves #2654
What is in this change?

Adds an advanced settings collapsible menu to the Generic OpenAI embedder configuration with input to optionally set max concurrent chunks. If no input is provided, the maxConcurrentChunks variable is defaulted to 500.

Additional Information

Developer Validations

[x ] I ran yarn lint from the root of the repo & committed changes
[x ] Relevant documentation has been updated
[x ] I have tested my code functionality
[x ] Docker build succeeds locally

Excellent work, just made a minor update to make the maxEmbeddingChunks a class getter so make sure the value in the ENV is parsed to number and always something we can work with.
Also updated field UI to the new UI so it looks right.


Is it possible, when you double click on a variable to include the dollar sign?

Hi everyone,
Is it possible, when you double click on a variable or when you CTRL + SHIFT + (left or right arrow) to select it, to include the dollar sign? I often do it to copy paste variables, and it would be usefull to copy paste the dollar sign too.
If it is already possible, can you tell me what I am doing wrong?
Thanks in advance.

That functionality is provided by vscode afaik, please file an issue there


Redundant classes in synthetic data

Hey, thanks so much for releasing the ImageNet-G-1K datasets (both base-generated and finetuned-generated), this is very useful!
While going through the synthetic dataset, I noticed one anomaly which I thought might be worth flagging. There are two redundant sets of class-names "Sunglasses" and "Missile". These also occur in the original class-names used by the OpenAI folks: https://github.com/openai/CLIP/blob/main/notebooks/Prompt_Engineering_for_ImageNet.ipynb
However, I think the right class-names to synset mappings to use would be sunglasses: n04356056, sunglass: n04355933, missile: n03773504 and projectile: n04008634 (for the full synset-classname mapping, you could check this).
This might therefore lead to some redundancy (although debatable how much of a difference this would make for sunglass vs sunglasses) in both the train and val sets that are generated. It might be worth regenerating the data for the two classes, and see if this improves performance slightly (my hunch is it wouldn't matter too much).

Hi @vishaal27 ,
thanks for reaching out and pointing out this anomaly. I will work on fixing this, however, sometime later since I am busy with some other work. I suggest using the scripts/colab on the GitHub to generate images for the anomalous classes.


Convert readthedocs link for their .org -> .io migration for hosted projects

As per their blog post of the 27th April ‘Securing subdomains’:

Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.

The link on the Github repo description also needs updating.

Thank you! Updated.

You should put HTTPS on the repo link ;)

💯

🔒


Run jobs against multiple python versions

let's try this

Can't be bothered to figure it out atm. It's a one liner in Travis-ci 😞


Suppress ObjectPropertyName should work as well

Use Case
@Suppress("ObjectPropertyName")
private lateinit var _modifiableState: ModifiableState
var modifiableState: ModifiableState
    get() = _modifiableState
    private set(value) {
        _modifiableState = value
    }

Expected Behavior
Detekt ignores it as well
Current Behavior
Detekt does not ignore it since it expects @Suppress("ObjectPropertyNaming")
Steps to Reproduce (for bugs)
See use case above
Your Environment

Version used: 1.0.0.RC8
Link to your project: https://github.com/loewenfels/dep-graph-releaser/blob/master/dep-graph-releaser-gui/src/main/kotlin/ch.loewenfels.depgraph/gui/components/Menu.kt#L541

Detekt currently looks for @Suppress annotations with the given Rule name. Which in this case is ObjectPropertyNaming. We could allow for aliases for certain rules.

Not sure if you are waiting for my feedback (or what the label means in this project). I am aware of the behaviour of detekt, its just ugly if you see:
@Suppress("ObjectPropertyName", "ObjectPropertyNaming")

I added the label to wait for some input from others what they think about
giving rules aliases to allow for possibly nicer suppress annotations.
On Wed, Oct 10, 2018, 08:05 Robert Stoll<EMAIL_ADDRESS>wrote:

Not sure if you are waiting for my feedback (or what the label means in
this project). I am aware of the behaviour of detekt, its just ugly if you
see:
@Suppress("ObjectPropertyName", "ObjectPropertyNaming")
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/arturbosch/detekt/issues/1215#issuecomment-428448957,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF4k0S53YPVh0niNDnyfabUtzWrReZ_Tks5ujY48gaJpZM4XTb4H
.

Merging #1228 into this issue as they're very similar.
IntelliJ reporting unused parameters can be suppressed with @Suppress("UNUSED_PARAMETER"). To suppress them in detekt one would use @Suppress("UnusedPrivateMember").
To suppress both rules at once the @Suppress annotation would take both names as parameters. By having aliases to suppress detekt rules this could be reduced to one parameter in the annotation if the UnusedPrivateMember rule would also be suppressible with UNUSED_PARAMETER.

I don't see any issue with suppressing twice - it's expected that detekt will be run alongside different code quality tools and that different tools may check for same/similar issues. While it's a bit nicer only having to suppress a rule once instead of twice, it's probably better to just try and fix the code to avoid the code being flagged in the first place ;)

I agree that detekt does not have to support suppression of other analysis tools. I see IntelliJ as an exception though. Because, and that's only a guess, most people work with IntelliJ. So you end up with the following use case:

IntelliJ flags something as being smelly
you decide that it is fine and use the suppression suggested by IntelliJ
IntelliJ is happy and does o longer show it as being smelly
You run detekt and here you get again the same error, which means you lose time on a subject you have already made up your mind.

I see that there is demand for aliases - already discussed in other issues.
Our way now is to get informed by aliases for our rules and add them per to the rule itself on demand.
I think every rule should be allowed to have aliases based on an aliases property in the configuration.
I will provide a POC and we can discuss this.

Is this still WIP or is this done?

Its done and merged :)


Deprecate PaperTrail.serialized_attributes?

This is a follow-up to https://github.com/airblade/paper_trail/pull/667
"Use Active Record's type system from 4.2 onwards."

Test failed because of #672

:+1:


Solax Sensor Error

I've add the sensor but receive this error:
Log Details (ERROR)
Error while setting up platform solax
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 150, in _async_setup_platform
    await asyncio.wait_for(asyncio.shield(task), SLOW_SETUP_MAX_WAIT)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
    return fut.result()
  File "/usr/src/homeassistant/homeassistant/components/solax/sensor.py", line 29, in async_setup_platform
    resp = await api.get_data()
  File "/usr/local/lib/python3.7/site-packages/solax/__init__.py", line 140, in get_data
    3)
  File "/usr/local/lib/python3.7/site-packages/solax/__init__.py", line 107, in async_solax_real_time_request
    raise SolaxRequestError
solax.SolaxRequestError

{'method': 'uploadsn', 'version': 'Solax_SI_CH_2nd_20151029_DE01', 'type': 'AL_SE', 'SN': '43745B6D', 'Data': [5.7, 5.7, 293.8, 320.2, 14.5, 237.2, 3384, 36, 19.2, 22389.5, 2882, 1674, 1825, 53.28, -0.01, -1, 49, 0.0, 0.0, 4771.1, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 50.01, 0.0, 0.0, 0.0, 0.0, 0, 0.0, 0], 'Status': '2'}
Connection lost. Reconnecting…

**Received unexpected JSON from Solax API endpoint: length of value must be at least 68 for dictionary value @ data['Data']**
Connection lost. Reconnecting…

Can you tell me the exact model of inverter you have please?

The model is: SK-SU5000E

On 14 Sep 2019, at 09:37, Robin Wohlers-Reichel<EMAIL_ADDRESS>wrote:
Can you tell me the exact model of inverter you have please?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/26626?email_source=notifications&email_token=ANFZCDZ5EARZMG6CHVMWN7LQJSIDDA5CNFSM4IWP2M5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WWRKQ#issuecomment-531458218, or mute the thread https://github.com/notifications/unsubscribe-auth/ANFZCD5DR5K776R7EDMCGADQJSIDDANCNFSM4IWP2M5A.

Interesting. I noticed that your version field ends with 20151029_DE01 while we have only tested with 20160912_DE02 so far. Could you please visit http://<your inverter api>/api/realTimeData.htm and paste the response in a reply to this issue?

this is the answer:
{"method":"uploadsn","version":"Solax_SI_CH_2nd_20151029_DE01","type":"AL_SE","SN":"43745B6D","Data":[7.0,6.8,279.4,316.3,17.2,237.8,4022,37,6.0,22431.8,3673,1955,2150,53.42,0.30,15,51,,0.0,4780.6,,,,,,,,,,,,,,,,,,,,,,0.00,0.00,,,,,,,,49.98,,,0.0,0.0,0,0.00,0],"Status":"2"}
the serial numer is: 43745B6D

This should be fixed by https://github.com/squishykid/solax/pull/12

thanks, I don't have much HA experience, I can't force library update, can you tell me how?

I'm fixing it in #26705

After update to 0.99 i receive the same error..

@aroverelli the code is not added in 0.99.
Now that the PR has been merged you should be able to test with the development version: https://www.home-assistant.io/docs/installation/updating/#run-the-development-version


It's broken

Please read the reviews on the Mozilla Extensions page because your fantastic extension is broken and we would really like it fixed if possible please: https://addons.mozilla.org/en-GB/firefox/addon/video-background-play-fix/reviews/

Found a possible Firefox issue, which would explain it at least for playlists:
https://bugzilla.mozilla.org/show_bug.cgi?id=1878115
Does that (i.e. playing back lots of smaller tracks in background, not one single long video) fit your observations?

Found a possible Firefox issue, which would explain it at least for playlists: https://bugzilla.mozilla.org/show_bug.cgi?id=1878115
Does that (i.e. playing back lots of smaller tracks in background, not one single long video) fit your observations?

I don't watch/listen to playlists though. I am on Youtube.com (usually the mobile version) and it happens with single videos. It also happens on other websites with videos. I just want to have podcasts playing in the background or conversational videos with the screen off (to save battery) while I cook and do chores.

Hm. The problem is that it's somewhat hard to disambiguate between some change on Youtube's side which is only gradually rolling out and which I might not be seeing yet [1], a bug in Firefox and/or some Android manufacturers being over-eager in killing background apps.
How willing/able/comfortable would you be with trying to use ADB for attempting to figure out what is going on? I can try providing some guidance as far as possible.
[1] Yesterday I've been able to playback a 25 min video in background without problems – the aforementioned Firefox bug only seems to happen after switching to a new video while in background, whether through playlists, or presumably also letting Youtube automatically play the next video after the first one.

Hm. The problem is that it's somewhat hard to disambiguate between some change on Youtube's side which is only gradually rolling out and which I might not be seeing yet [1], a bug in Firefox and/or some Android manufacturers being over-eager in killing background apps.
How willing/able/comfortable would you be with trying to use ADB for attempting to figure out what is going on? I can try providing some guidance as far as possible.
[1] Yesterday I've been able to playback a 25 min video in background without problems – the aforementioned Firefox bug only seems to happen after switching to a new video while in background, whether through playlists, or presumably also letting Youtube automatically play the next video after the first one.

Sorry I have no idea what ADB is but this problem is not just affecting me alone, if you read the reviews on the extension on Mozilla site there are many having the same issue. Heres my workflow to reproduce the error:

Open Firefox and go to the mobile version of Youtube, I believe it's m.youtube.com
Open and play any video
Turn screen off
Video continues to play for around 5 minutes then abruptly stops
Turn screen back on
Watch Firefox page automatically reload on it's own and the video seek bar resets to 0:00 (the start)

You can swap step 3 with "minimise Firefox and do something else on the phone like play a game or read Facebook/X/Telegram posts on their individual apps. The video playback will stop on it's own after around 5 minutes.

Does that happen even with Firefox Nightly?

Does that happen even with Firefox Nightly?

I don't use Firefox Nightly but I've update Firefox whenever there is an update and there has been a few over the last couple of weeks.

I've tested it with both a current Nightly as well as the current release (version 122), and the only thing I can reproduce is the issue I linked to above – if I use a playlist or autoplay to play back multiple videos, then at some point after the second video has started, Firefox gets killed by Android.
However the first video always works fine, even if it's a half-hour episode of some radio comedy or whatever.
So if what people are seeing is really happening with a single video and no autoplay involved, then like I said: Either Youtube is gradually rolling out/testing a behaviour change that I'm not yet seeing, or else it's some sort of Firefox and/or Android issue which doesn't happen on my own phone. (Out of curiosity, what phone and Android version are you on?) Without any logs, unfortunately I can't say more than that…

I've tested it with both a current Nightly as well as the current release (version 122), and the only thing I can reproduce is the issue I linked to above – if I use a playlist or autoplay to play back multiple videos, then at some point after the second video has started, Firefox gets killed by Android.
However the first video always works fine, even if it's a half-hour episode of some radio comedy or whatever.
So if what people are seeing is really happening with a single video and no autoplay involved, then like I said: Either Youtube is gradually rolling out/testing a behaviour change that I'm not yet seeing, or else it's some sort of Firefox and/or Android issue which doesn't happen on my own phone. (Out of curiosity, what phone and Android version are you on?) Without any logs, unfortunately I can't say more than that…

It's not a situation unique to Youtube. As I said, other video platforms it also happens as well such as X (Twitter) in the Firefox browser and Rumble. This is not an issue unique to me, others on the review comments have stated the same.
I am on Android version 12 on a Samsung Galaxy Note 10+ 5G. I have preordered a Samsung Galaxy S24 Ultra which is due to arrive in the next week and a half so I will certainly try on the new phone.

I dont think the app developers for this receive and sort of financial compensation  to build and maintain this program. Report the issue accurately and if they are able to fix great, if not dont be dramatic or act like they are supposed to or even need to do anything. Everyone willing to preorder this app for 2 or 3 dollars and im sure the be more then happy to spend time with updates.  Sorry for rant but i see this all over and just seems funny how unaware of how much time it can take to fix even minor issues.  Apologies for the rant 👽

Happening on my new phone now just FYI.

I dont think the app developers for this receive and sort of financial compensation to build and maintain this program. Report the issue accurately and if they are able to fix great, if not dont be dramatic or act like they are supposed to or even need to do anything. Everyone willing to preorder this app for 2 or 3 dollars and im sure the be more then happy to spend time with updates. Sorry for rant but i see this all over and just seems funny how unaware of how much time it can take to fix even minor issues. Apologies for the rant 👽

I mean why even bother for any developer to create anything for anyone? This is a very useful extension loved by lots. The developer(s) obviously want to share their work with other people so if it no longer is working for some, I would expect they would be keen to try and fix it because the extension is their creation and they want to continue sharing it.

Same issue on my Xiaomi 12 (Android 13, MIUI 14)

I've re-tested, but I'm afraid I still can't reproduce the issue. Without any logs I can't say anything further about what might be happening.

I've re-tested, but I'm afraid I still can't reproduce the issue. Without any logs I can't say anything further about what might be happening.

 If your device is not stopping and the page is not reloading then I would love to know why. Both my Samsung android phones do this. I hope one day we can find out the cause as it's very annoying. For now, I have disabled the extension. Thanks for your efforts.

https://dontkillmyapp.com/ ?

This add-on doesn't even do anything on Rumble, and I still think it's most likely some combination of Android and/or Firefox issues. If somebody wants to do some more investigating and knows how to use ADB:
After you've started playback, look at about:processes and note down the ID of both the main process ("Firefox") or whatever, and the "Shared Web Process" that is hosting the background playback, i.e. which has Youtube or whatever loaded. Then,
a) periodically check the output of adb shell dumpsys meminfo. Look at the end where it lists "Total PSS by OOM adjustment:" and check in which category (Foreground/Visible/Perceptible/…/Cached) the respective Firefox Processes are listed. If either of the two processes you've noted down above ends up as "Cached", that's a clear sign that something is going wrong.
b) Run adb logcat and filter for the process IDs you've noted down above. If/when playback suddenly stops, check if there are any messages about a Firefox process having been killed.
And file a Firefox bug with the above info.

doesn't even do anything on Rumble

Because it only works on YT and Vimeo.

https://dontkillmyapp.com/ ?

Oh this looks very interesting! I will check it out. Thank you!

I don't know if it's the app itself or the advice given by the app/website regarding battery saving features but I turned off everything I could find about battery and power saving for Firefox and now I am able to turn off my screen (with this plugin enabled) and the audio continues to play and it does not stop and reload the page by itself. So problem solved! thanks very much for that post. It looks like the extension is working fine and it's to do with Android power saving features!


Update debugging for comment triggered workflow

Fix up user permissions debugging
Add logging to PR details

/test-force-approval

/test-force-approve


Unable to install

The chrome extension never brings in manifest.json files, is it because Manifest V2 needs to upgrade Manifest V3

Same here. And even if the manifest.json file is upgraded to v3, it's still not working because Chrome complains about some JavaScript code.
@fransr - is there a plan to upgrade this extension to work with the latest Chrome? Thanks.

Hi @dueduegfpup @beichenh, I'm using the latest version of Chrome. It does log a warning about manifest v2, but it still seems to all work ok


Create pull_request_template.md (SE-39) callum

Context
Implement a PR template into ./docs/ folder that allows all the team to have the same outline for all future PRs and will allow everyone testing to know what they are working with and have clear instructions. Standardize the PR process so that everyone knows what is expected of them and so everyone who is reviewing a PR knows what they need to review.
Fixes SE-(39)
Description

Implement a PR template into github for all future PRs

Type of change
Please select options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Can This Be Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and any other tests you think may be worth running (help out the tester pretty please would be appreciated)

[ ] Open a test PR and make sure that the template shows up and is usable
[ ] Check over with the teammates at a team meeting to make sure everyone agrees with the template

Notes:
n/a
Checklist:

[ ] My code follows the style guidelines of this project (n/a)
[ ] I have commented my code, particularly in hard-to-understand areas (n/a)
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings (n/a)
[ ] I have given testing instructions for the reviewer
[ ] New and existing unit tests pass locally with my changes (n/a)
[ ] Any dependent changes have been merged and published in downstream modules (n/a)
[ ] Jira ticket number in PR title

checked on Woozles branch. same here.


Open a modal from another modal

I'm trying to open a modal from another modal with no luck.
Modal 1 opened has a link to modal 2.
User clicks link to modal 2.
Expected: Modal 1 is closed and modal 2 is opened.
What happens is modal 1 is closed, modal 2 is opened for some miliseconds and then closed.
That's my code.
$( '.modal-open-another' ).on 'click', (e) ->
    e.preventDefault()
    modalToOpen = this.getAttribute 'href'
    modal.open(modalToOpen)

Well, I've seen that the easiest way is the correct way. By using the built-in rel='modal:open'. Closing it.


List External Secrets providers with a good free tier

Check the list of providers here:
https://external-secrets.io/latest/provider/aws-secrets-manager/
And create a new list containing only the ones that have a free tier. This will be added to the wiki.

Feedback Document Link Regarding the Issue:
https://docs.google.com/document/d/1XzbIZoKgmXOULFbnItSIBMMbZbwvC5s0gCMvyYQnO74/edit?usp=sharing


feat(amplify-category-auth): use usernameAttributes by default, FF for aliasAttributes

Description of changes

https://github.com/aws-amplify/amplify-cli/pull/7461 updated the Cognito auth configuration created during amplify add auth to forgo Cognito's usernameAttributes in favor of always relying on aliasAttributes, which were previously unsupported.
This PR reverts the default behavior to use usernameAttributes since there were some unexpected DX issues with how developers need to use the amplify libraries to be compatible with aliasAttributes.
Developers that have already created applications that depend on aliasAttributes will see the following warning message when they call amplify update auth:
context.print.warning(
  `You have previously created Cognito auth resources using 'aliasAttributes' (probably by creating auth from a previous version of the CLI). This is no longer supported by default in the current version of the CLI. If you'd like to continue using 'aliasAttributes' in your configuration, please abort this update process and update your ${pathManager.getCLIJSONFilePath()} file to set the 'auth.forcealiasattributes' key to 'true'. For more info, check out https://docs.amplify.aws/cli/migration/cli-auth-signup-changes`,
);

It's worth reiterating from the console message that a new feature flag is added in this PR that allows continuing to use aliasAttributes for users who prefer that.
The linked docs page has yet to be written and can be updated here
Description of how you validated changes
I've added unit tests to verify the configuration changed based on different feature flag values. I've also manually tested this by creating two amplify apps, one where the feature flag was set to true, and the other where the flag was set to false. Both behaved as I anticipated - when the flag is left as false usernameAttributes are used, otherwise aliasAttributes are used.
Here is an app created with the new default settings. Note that during signup it is perfectly possible to set an email-address formatted username.
And here is an app created with the forceAliasAttribute flag set to true. Note that during signup it does not allow an email-address formatted username, because it's already an alias.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8188 (3d16df1) into master (f5a92e3) will increase coverage by 0.00%.
The diff coverage is 65.45%.

@@           Coverage Diff           @@
##           master    #8188   +/-   ##
=======================================
  Coverage   54.42%   54.43%
=======================================
  Files         663      663
  Lines       37834    37857   +23
  Branches     7772     7782   +10
=======================================
+ Hits        20590    20606   +16
- Misses      16404    16408    +4
- Partials      840      843    +3

Impacted Files
Coverage Δ

...amplify-cli-core/src/feature-flags/featureFlags.ts
83.55% <ø> (ø)

...auth/src/provider-utils/awscloudformation/index.js
3.35% <16.66%> (ø)

packages/amplify-category-auth/src/index.js
13.04% <30.00%> (+0.09%)
:arrow_up:

...ls/awscloudformation/handlers/resource-handlers.ts
21.05% <33.33%> (ø)

...udformation/utils/attach-prev-params-to-context.ts
50.00% <50.00%> (ø)

...wscloudformation/utils/auth-sms-workflow-helper.ts
52.17% <50.00%> (ø)

.../amplify-category-auth/src/commands/auth/update.js
63.93% <66.66%> (-0.22%)
:arrow_down:

.../amplify-category-auth/src/commands/auth/enable.js
87.50% <100.00%> (+0.83%)
:arrow_up:

...s/awscloudformation/utils/auth-request-adaptors.ts
45.80% <100.00%> (+1.70%)
:arrow_up:

...gory-auth/src/provider-utils/supported-services.ts
100.00% <100.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eeb994...3d16df1. Read the comment docs.

Here is a diff of the default parameters from 5.1.0 vs this PR: https://quickdiff.net/?unique_id=B64905CD-3723-1E0D-9CED-766D1F463E84
Here is a diff of the default cloudformation from 5.1.0 vs this PR: https://quickdiff.net/?unique_id=F832FA1B-D464-921D-DE3F-1A7425032E1C

Here is a diff of the default cloudformation from 5.2.0 vs this PR with forceAliasAttributes true:  https://quickdiff.net/?unique_id=34343375-5F11-2403-05C9-D0B4C1B9E990
Here is a diff of the default cloudformation from 5.2.0 vs this PR with forceAliasAttributes true: https://quickdiff.net/?unique_id=77134D3D-F7DB-8B01-9FF5-9FCD9354AE48


Add market place support to contextual menus

Is your feature request related to a problem? Please describe.
With https://github.com/camunda/web-modeler/issues/6066 we have introduced a new icon, to open the marketplace browse dialog, to the following contextual menus:
bpmn-create, bpmn-replace, bpmn-append, and element-template-chooser.
We did it by registering an extension provider for each of them: https://github.com/camunda/web-modeler/blob/da75c66b3009763a84f7978d0c624c3f6488cba0/webapp/src/App/Pages/Diagram/BpmnJSExtensions/browseMarketplaceExtension/BrowseMarketplaceExtension.js#L29-L32
We have also added a new call to action when there are no search results, and we did it by listening for mutations on the DOM node: https://github.com/camunda/web-modeler/blob/da75c66b3009763a84f7978d0c624c3f6488cba0/webapp/src/App/Pages/Diagram/BpmnJSExtensions/browseMarketplaceExtension/BrowseMarketplaceExtension.js#L74C3-L91C4
The second approach, looks error-prone and hard to maintain (e.g. what if selectors change in the core libraries?); but at that time it was the only viable solution to achieve the requirement.
Describe the solution you'd like
Do we have, or might implement, something better to add the marketplace icon?
Would it be possible to expose something (e.g. a rendering function) to customize or extend the search results?
Additional context
PR with changes: https://github.com/camunda/web-modeler/pull/6154/files#
What does it look like:

Moving to ready to un-park this item.

@marcellobarile Via https://github.com/bpmn-io/diagram-js/pull/847 you'll be able to create a popup menu provider that contributes a custom empty state. This way you shall be able to implement your use-case.

great news @nikku ! I'll prepare an issue on our end to embrace the change! :)

Will be released with<EMAIL_ADDRESS>


Onnx1.9

Move onnx to 1.9.
The operators is not changed to upset 14 for 1.9 yet.  There is no interface change.
onnx 1.9 has an important fix for version converter. The patch will allow we to invoke converter to handle the old models.

Jenkins Linux ppc64le Build #297 [push] Onnx1.9 (#717)  * update... started at 13:27

Jenkins Linux s390x Build #1149 [push] Onnx1.9 (#717)  * update... started at 13:25

Jenkins Linux amd64 Build #1151 [push] Onnx1.9 (#717)  * update... started at 12:25

Jenkins Linux ppc64le Build #297 [push] Onnx1.9 (#717)  * update... failed after 27 min

Jenkins Linux s390x Build #1149 [push] Onnx1.9 (#717)  * update... passed after 38 min

Jenkins Linux amd64 Build #1151 [push] Onnx1.9 (#717)  * update... passed after 48 min