Allow to disable selected providers

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1437549
This is #13204 updated. Going with steps outlined by @durandom here: https://github.com/ManageIQ/manageiq/pull/13204#pullrequestreview-13513352
This covers:

migration and toggling of disable flag
dont start disabled workers

we can go towards orchestrated destroy if this is ok.
@moolitayer @cben Please review

@LoicAvenel @simon3z Contrary to #13204 , this doesnt add anything to the UI yet. Right now im building towards the orchestrated destroy that will stop workers before deleting the provider. We can discuss if and how we should allow the user to disable a provider as we go.

Otherwise LGTM :+1:

Line 8, Col 27 - Rails/SkipsModelValidations - Avoid using update_all because it skips validations.

Is this one ok?

LGTM.

dont start disabled workers

Just to be clear, this PR will also actively stop/start workers at some point (sync_workers) after flag is disabled/enabled, right?

Just to be clear, this PR will also actively stop/start workers at some point (sync_workers) after flag is disabled/enabled, right?

Yes, it will take the flag into consideration at the next sync_workers, reacting the same way as when the authentication is invalid. Though "when is the next sync_workers" is a difficult question.

Just to be clear, this PR will also actively stop/start workers at some point (sync_workers) after flag is disabled/enabled, right?
Yes, it will take the flag into consideration at the next sync_workers, reacting the same way as when the authentication is invalid. Though "when is the next sync_workers" is a difficult question.

@jrafanie maybe you can give some pointers how to ask all workers for an ems to shutdown? This could be done immediately after disabling and ems.
And if we enable a disabled ems, when will the workers come up again?

@zeari I like this but does this solve the original BZ where it appears like the refresh is replacing the provider that was just deleted?  Does this mean instead of deleting a provider, they're just disable it instead?  Is that satisfactory?

@zeari I like this but does this solve the original BZ where it appears like the refresh is replacing the provider that was just deleted? Does this mean instead of deleting a provider, they're just disable it instead? Is that satisfactory?

@jrafanie
Thats not exactly the issue. The provider is deleted but all the associated entities remain. Its looks like theres a race condition between the refresh job and the delete job. Like the provider was deleted, meanwhile the refresh worker that has credentials and details cached somewhere fills the DB with the inventory.
Since disabling a provider is also a feature we might want to enable for users, adding it and orchestrating a destroy thatll stop workers before deleting the provider seems like the way to go.

Doesn't solve the BZ but is the first step towards it.
Next step would be change deletion to disable, wait for workers to stop,
only then delete.  (how exactly to wait might be tricky ;-)

@jrafanie, going to reassign to you...please merge when you are good.

@zeari very nice addition 👏  hope we have the full featured disabling of providers in the next release
@bronaghs @blomquisg this will help us for implementing https://bugzilla.redhat.com/show_bug.cgi?id=1343328 ( discover amazon ems and add them disabled )

@zeari - This is a nice enhancement. Has any UI work been done on it yet?

@bronaghs I have some code ready but we need a provider type thats ok with being disabled. We might not want to expose this feature for providers that would 'miss' metrics when disabled -creating some gap or incomplete history.

@zeari - is this backportable to Euwe?

@bronaghs This has a DB migration so i dont think so.


Add patient class and features

IGNORE THIS, ACCIDENTALLY MERGE MASTER INTO THIS BRANCH. REDOING ANOTHER BRANCH.


Breach Depressions (not fast)

Is there an updated function to do the breach depressions (the not "fast") version?

@kamosuela I just wanted to let you know that I am just now testing a port of this breaching algorithm to WhiteboxTools. I have called this tool LeastCostBreachDepressions and hope to submit it to the repo within the next few days and it will be part of the v1.0.3 release. I will close this issue at that time.

That's wonderful! Looking forward to running it

@kamosuela The new version (v1.1.0) now contains the BreachDepressionLeastCost tool, which is a modified port of the Whitebox GAT (Lindsay and Dhun, 2015) algorithm. You should find that this tool is blazing fast and provides really low-impact results for most DEMs. Please let me know what your experience is in using it. Feedback is always welcome on this type of experimental tool.


Support Laravel 9

This is not really maintained anymore! Check spatie's package for google storage.


How to have a sentencepiece tokenizer that already has the extra 100 ids

I see that the mt5 tokenizer comes by default with the extra 100 ids that are needed by the T5 models.
I've trained my own version of tokenizer following the official sentencepiece documentations.
But i was unable to understand how to make those extra 100 ids part of my .model and .vocab , similar to how the mc4 mt5 tokenizer has here gs://t5-data/vocabs/mc4.250000.100extra/sentencepiece.model
Following could someone please also share the sentencepiece training args used in the actual mT5 tokenizer training.
Should I use the --byte_fallback args ?

closing #24


Add jmods into -dev variant.

New Image Pull Request Template
Add jmods into -dev variant. Before this, if you tried to use jlink, you would get the following error message:
this runtime image does not contain jmods directory.

As part of a Chainguard effort to reduce code duplication and provide higher quality images, we have stopped accepting pull requests for changes to images in this repository. Due to this, we are closing all pull requests today in order to start fresh.
If you think this pull request was closed in error, please feel free to re-open this pull request or open an issue and we will try to help you out. Thank you!


Contributor Component on the Landing Page

Description
Create a contributor component at the bottom of the landing page to celebrate open source contributions from all the contributors and give them a shoutout.

https://iiitdplaybook.web.app/homepage  (Scroll to the bottom)

Use the chip components from mui

Domain
Front-End (Styling/Markup)
Code of Conduct

[X] I follow Contributing Guidelines of this project.

/assign

Does this issue come under GSSOC'22...If yes, could you please assign a level tag for it?? Thanks :)


Clock view for time

Would it be possible to integrate a "clock picker" (similar to android's clock) to select the time?
Something similar to:
https://github.com/weareoutman/clockpicker
It would be great if that was possible, since I believe this design is a bit more mobile friendly.
It would be interesting to have the ability to swap between the current design and the clock, but that might be a bit too complicated to handle though.

It would indeed improve the datetimepicker's UX by reducing the number of click/touch required to set a full date :+1:
@cimtico Have you already used this clockpicker? If so, is it reliable?
I can't find any good competitor to this one on github, do you know one?

Sorry I didn't answer earlier. I haven't used it in a project, so I'm not sure as to how "good" it is. I did some searches looking for clock options, and that was the closest I could find to what I was aiming for in UX terms.

closing this since it's already in the works and in the v5 planning issue

Is this still planned for development?


X11: Guess initial DPI factor

Addresses #581 on X11 (Windows coming soon!)

This also adds a dependency on log, so going forward, contributors are encouraged to log stuff!

I can confirm this makes windows start at the right size on single-monitor gnome. Thanks!


Rebase of master,

Added World.GetDistance
Added Ped.GetDistanceTo
Added Vehicle.GetDistanceTo
Added Entity.GetDistanceTo
Added Game.PlayMusic
Added Game.StopMusic

Did you remove the veh.dist, and the rest, or did something mess up again!
If you did remove them, how come? To put them as a position member?

I did remove them, since the same is implemented with World.GetDistance, so those are superflous.

Hmmm... I thought it would be useful as you could just use the current object as the origin position. I looked at what Tim did for IV, and he added one for each  with a position property.
So it would be like:
player.character.position.getDistanceTo(myveh.position)
Myped.position.getDistanceTo(myObj.position)

Fair enough. But you don't need to add them to Entity, Ped and Vehicle. Just add it to Entity. Ped and Vehicle inherit from Entity and thus have that method automatically too.

I knew there was a fancy way. :) I had a feeling because peds and veh are as you say; entity's.


Unexpected behaviour when using End: true inside a Map iterator

Hi, I have the following ASL:
StartAt: Map
States:
  Map:
    End: true
    ItemsPath: "$.Ids"
    Iterator:
      StartAt: SyncItem
      States:
        SyncItem:
          Retry:
          - ErrorEquals:
            - States.ALL
            IntervalSeconds: 1
            BackoffRate: 2
            MaxAttempts: 3
          Catch:
          - ErrorEquals:
            - States.ALL
            Next: LogError
          End: true
          OutputPath: "$.Payload"
          Parameters:
            FunctionName.$: "$.FunctionName"
            Payload:
              ItemId.$: "$.ItemId"
          Resource: arn:aws:states:::lambda:invoke
          Type: Task
        LogError:
          Type: Pass
          End: true
    MaxConcurrency: 20
    Parameters:
      FunctionName.$: "$.FunctionName"
      ItemId.$: "$$.Map.Item.Value"
    Type: Map

Note that successful runs of SyncItem exits (End: true). Same goes for LogError
I'm expecting the diagram to point them to End, but it looks like this:

Thanks for another fast fix 🙏

Thanks for another fast fix 🙏

No problem, pushed the new version
There was a problem with this case, indeed. Thanks!
Should look like this now:

No problem, pushed the new version
There was a problem with this case, indeed. Thanks!
Should look like this now:


Can we add PSSessionOptions to the PowerShellJob.ps1 / Invoke-PsOnRemote

Hi there,
Please do not that this is a duplication request that was to a closed ticket #1394.
However I don't need the arguments listed by the topic starter, but need a different one.
To be specific: -IncludePortInSPN
(Example: $sessionOptions = New-PSSessionOption -IncludePortInSPN)
I need these as we use a CRM environment with host specific SPN's. These SPN's are registered under a IIS AppPool user (different to the deployment user, used by TFS)  as we are using multiple front-ends. As we are using multiple front-ends, I'm unable to remove the existing SPN's.
I added a new port-specific SPN, and can connect with PowerShell with above snippet.
However in order to be using these within TFS Build, I need that parameter added to the PowerShell jobs.
See community question of me regarding this: https://social.msdn.microsoft.com/Forums/vstudio/en-US/7e9e7a6c-fd0e-45c9-bec1-08322183c2d6/powershell-on-target-machines-failes-due-to-crms-spn-records?forum=tfsbuild
As I said, this ticket is a duplication. I still created this to show the need for it (multiple people requiring it apparently).
Hopefully you can help me out!
With kind regards,
Mike van Engelen

We have this on our backlog, however it will be a while before we can get to this based on current priorities (5-6 months).

Hi.
We are facing exactly the same issue. We have Dynamics CRM deployment and were going to utilize TFS release management for deploying. It is quite frustrating that MS core products can't work together.

Hi Sergey,
I do have a workaround available;

First create specific SPN's for the portnumbers of the WinRM service (elevated PowerShell)
SetSPN.exe -s HTTP/$($env:COMPUTERNAME):5985 $env:COMPUTERNAME
SetSPN.exe -s HTTP/$($env:COMPUTERNAME).$($env:USERDNSDOMAIN):5985 $env:COMPUTERNAME

Make the user used for the deployments part of the "Administrators" group (you could login by Local Security Profile)

For SQL server, make the user sysdba (perhaps less rights are required, but this is how we have it currently setup)

Use a "forward" script, so this script you call from TFS with some arguments, and then execute the specifc script on the remote machine. Script is such as:
`$ServerName = "$($args[0])"
Generic session options for PSSession
$sessionOptions = New-PSSessionOption -IncludePortInSPN
Create custom remote connection to include the SPN
$session = New-PSSession -Computername $($ServerName) -SessionOption $sessionOptions
Invoke-Command -Session $session -filepath "\\nameofscript.ps1" -argumentlist
Remove-PSSession -Session $session`

@tagwise-eu thank you for complete solution.
I'm currently also checking something more sophisticated for deployment such as PSDeploy  or PSCI.


"Random Pages" listing needs translation strings

Quite badly. This will involve a number of new strings (and maybe reusing existing ones for "Fandom" and "Official").

This is done as of 3d218700701a42d2b43714ddc63620ee308f354e (part of #160).


Improve Compliance With JDBC Specifications

Should fix #515 and #546

Connection.setTransactionIsolation - promote isolation levels READ_COMMITTED and REPEATABLE_READ, which are not natively supported by SQLite, to SERIALIZABLE. The driver should accept all four values as long as it can substitute a higher isolation level than the one requested.
Statement.setFetchDirection - while SQLite does not act on the fetch direction hint, it should accept the call so long as the argument is valid.

In both of these cases, spec-compliance makes it easier to write driver-agnostic user code.
ResultSet.setFetchDirection was not changed, because the current impl is actually correct. It is correct because SQLite only allows FORWARD_ONLY ResultSets.

Thanks! Merged

Thanks! Merged


proposal: receive notifications when someone comments on or upvotes your item

I'm curious about how this could be achieved using Fresh. Are there any available resources for accomplishing this?

Completed in #321.


Support Angle in c#

The hololens branch of https://github.com/Microsoft/angle works.
We hope there is effort to make that works in c#
The UrhoSharp is starting to support Hololens in c#

@JimSEOW thanks a ton for bringing the Angle branch for HoloLens to light! I didn't know that was in progress, pretty cool!
This probably isn't the right forum to request a C# interface - maybe bring up the issue at the Angle Github?

@jwittner  We will soon have a C# interface, thanks to someone from Xamarin.
I think this forum should also consider allowing emerging C# (non-Unity3D) Hololens developers using either UrhoSharp.Hololens.dll or Hololens Angle to take advantage of the HoloToolkit managed libraries.
Our feedback and participation would help bring new use case to hololens ecosystem. (e.g. Xamarin means more than UWP, but iOS and Android C# devleopers)

I think that's a great idea! Is there anything stopping the developers in question from linking to the HoloToolkit libraries right now?

@jwittner  HoloToolkit4Unity exist because it is more than just linking to the HoloToolkit libraries.  Likewise, for the two other C# approaches (1)UrhoSharp.Hololens, and (2)WebGL4HoloLens, we eventually will also need similar dedicated githubs (e.g. HoloToolkit4WebGL), more than just samples showing how to do the linking.
Why this is critical? Without spatial mapping and other important functionalities of this library, we could not apply AI contextual awareness to windows store apps developed using UrhoSharp and WebGL.
WebGL4Hololens depends on AngleHoloLens C# interface and ChakraCore's OpenGL Engine  and ChakraBridge
Many of the exciting scientific 3D visualization is currently available in WebGL.js. WebGL4Hololens [c#] will speed up the creation of new Hololens high impact business use cases (e.g. precision medicine and digital health revolution)
I hope there is a greater cross-functional interactions among the different Microsoft teams to make this happen.


Material Stepper currentStep is not scrolled into view

Steps to Reproduce:

Create very long vertical Stepper that exceed screen size and it needs to scroll to view the last element.
Use the continue button until you reach the last element

When you reach the last visible element on the screen and you hit continue the next step is expanded but screen is not scrolled to this step and you are not able to see it. You need to scroll manually.
Code to reproduce:
import 'package:flutter/material.dart';

class GameScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: TestWidget()
    );
  }
}

class TestWidget extends StatefulWidget {

  @override
  TestState createState() =>
      new TestState();
}

class TestState extends State<TestWidget> {
  int currentStep = 0;

  List<Step> __buildSteps() {
    List<Step> steps = new List();
    for (int i = 0; i < 20; i++) {

      steps.add(Step(
          title: Text('test'),
          subtitle: Text('test'),
          content: Text('test'),
          isActive: true));
    }

    return steps;
  }

  @override
  Widget build(BuildContext context) {
    List<Step> steps = __buildSteps();

    return Stepper(
      currentStep: currentStep,
      steps: steps,
      type: StepperType.vertical,
      onStepTapped: (step) {
        setState(() {
          currentStep = step;
        });
      },
      onStepCancel: () {
        setState(() {
          if (currentStep > 0) {
            currentStep = currentStep - 1;
          } else {
            currentStep = 0;
          }
        });
      },
      onStepContinue: () {
        setState(() {
          if (currentStep < steps.length - 1) {
            currentStep = currentStep + 1;
          } else {
            currentStep = 0;
          }
        });
      },
      controlsBuilder: (BuildContext context,
          {VoidCallback onStepContinue, VoidCallback onStepCancel}) {
        return Padding(
          padding: const EdgeInsets.only(top: 8.0),
          child: Row(
            children: <Widget>[
              FlatButton.icon(
                icon: Icon(Icons.navigate_next),
                onPressed: () => onStepContinue(),
                label: Text('NEXT STEP'),
                color: Theme.of(context).primaryColorLight,
              ),
              FlatButton(
                child: Text('PREVIOUS STEP'),
                onPressed: onStepCancel,
              )
            ],
          ),
        );
      },
    );
  }
}

Screenshots:
How it is:

How it should be:

Expected behaviour.
After you click continue button the current step must be scrolled on top (or bottom) of the screen/widget.  In my opinion if you keep every step scrolled to the top it will be more convenient because you will get the title of the current step on the same spot everytime. This way you will get better user experience because you will see whats next ( better than looking what you have already passed a.k.a using the screenshots above when you are on step 1 and click continue  step 1 should go away and 9 should appear at the bottom while 2 is active at the top)
P.S  If you make it configurable where to keep the active step (at top or at the bottom) it will be awesome !
Beside that you builded greate tool
I love it
thanks :)

I'm also facing something similar.
My situation:
Stepper (Long list) wrapped in CustomScrollView and when I've scrolled to the bottom and click on one of the step and it will scroll to the top.

I'm experiencing the same problem. I don't even see a point in using a Stepper for longer Step lists without having this feature. Sure I can create my own scroll implementation but then what is the point of having Stepper at all?

https://stackoverflow.com/a/55381863

There seems to be a number of scrolling problems with the stepper widget (altough they might all be linked to the same root problem). I use the stepper widget wrapped in a NestedScrollView(SingleChildScrollView(Column())) combination and see the following issues:

On selecting the first step, the title of the first step gets scrolled out of view on top (i.e. behind the header consisting of a SliverAppBar()).
On selecting the last step, the lower part of its content is not visible but gets scrolled out of view on the bottom.
If the whole construct is wrapped inside another Scaffold, selecting a Step scrolls all the way to the top of the page.

(Same behaviour is observed with ClampingScrollPhysics and with NeverScrollPhysics in the stepper itself and in the containing SingleChildScrollView)

This issue still exist

flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0-8.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-8.0.pre at /Users/taha/Code/flutter_dev
    • Framework revision e0c63cd35e (6 days ago), 2020-04-23 22:29:01 -0400
    • Engine revision d2ec21221e
    • Dart version 2.9.0 (build 2.9.0-3.0.dev b0d35855d8)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.9.1
[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.4.1
    • macOS         • macOS                     • darwin-x64     • Mac OS X
      10.15.4 19E287
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      81.0.4044.129
• No issues found!

without field content:
you have to add a column
Ex:
Column (
          children:  [
          Text ('Test'),],),

With flutter version 1.17.2, I now observe the following behaviour:
On selecting any step, the stepper is scrolled such that the first title is on top of the page.
This means roughly the first 5 steps are perceived to be scrolled correctly, afterwards the user wonders why the selected step always disappears at the bottom.

In case anyone is looking for a temporary solution, ive been using a scroll controller to force the scroll everytime the onStepContinue is called.
ScrollController _scrollController = new ScrollController();
...
void onNext() {
    ...onStepContinue logic...
    _scrollController.jumpTo(_scrollController.position.maxScrollExtent);
 }

In case anyone is looking for a temporary solution, ive been using a scroll controller to force the scroll everytime the onStepContinue is called.
ScrollController _scrollController = new ScrollController();
...
void onNext() {
    ...onStepContinue logic...
    _scrollController.jumpTo(_scrollController.position.maxScrollExtent);
 }

I managed unwanted jumping while the stepper expansion by using _scrollController.position.minScrollExtent in ListView controller

flutter doctor -v

  ╔════════════════════════════════════════════════════════════════════════════╗
  ║                 Welcome to Flutter! - https://flutter.dev                  ║
  ║                                                                            ║
  ║ The Flutter tool uses Google Analytics to anonymously report feature usage ║
  ║ statistics and basic crash reports. This data is used to help improve      ║
  ║ Flutter tools over time.                                                   ║
  ║                                                                            ║
  ║ Flutter tool analytics are not sent on the very first run. To disable      ║
  ║ reporting, type 'flutter config --no-analytics'. To display the current    ║
  ║ setting, type 'flutter config'. If you opt out of analytics, an opt-out    ║
  ║ event will be sent, and then no further information will be sent by the    ║
  ║ Flutter tool.                                                              ║
  ║                                                                            ║
  ║ By downloading the Flutter SDK, you agree to the Google Terms of Service.  ║
  ║ Note: The Google Privacy Policy describes how data is handled in this      ║
  ║ service.                                                                   ║
  ║                                                                            ║
  ║ Moreover, Flutter includes the Dart SDK, which may send usage metrics and  ║
  ║ crash reports to Google.                                                   ║
  ║                                                                            ║
  ║ Read about data we send with crash reports:                                ║
  ║ https://flutter.dev/docs/reference/crash-reporting                         ║
  ║                                                                            ║
  ║ See Google's privacy policy:                                               ║
  ║ https://policies.google.com/privacy                                        ║
  ╚════════════════════════════════════════════════════════════════════════════╝

[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.22.5 at /Users/dhs/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (6 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • AOSP on IA Emulator (mobile) • emulator-5554                        • android-x86 • Android 9 (API 28) (emulator)
    • iPhone 12 Pro Max (mobile)   • A5473606-0213-4FD8-BA16-553433949729 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.117, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.26.0-13.0.pre.117 at /Users/dhs/Code/flutter_master
    • Framework revision 1f07fde45d (8 hours ago), 2021-01-21 19:15:35 -0800
    • Engine revision 90641fa923
    • Dart version 2.12.0 (build 2.12.0-248.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • AOSP on IA Emulator (mobile) • emulator-5554                        • android-x86    • Android 9 (API 28) (emulator)
    • iPhone 12 Pro Max (mobile)   • A5473606-0213-4FD8-BA16-553433949729 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)              • macos                                • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)                 • chrome                               • web-javascript • Google Chrome 87.0.4280.141

! Doctor found issues in 1 category.

flutter doctor -v

  ╔════════════════════════════════════════════════════════════════════════════╗
  ║                 Welcome to Flutter! - https://flutter.dev                  ║
  ║                                                                            ║
  ║ The Flutter tool uses Google Analytics to anonymously report feature usage ║
  ║ statistics and basic crash reports. This data is used to help improve      ║
  ║ Flutter tools over time.                                                   ║
  ║                                                                            ║
  ║ Flutter tool analytics are not sent on the very first run. To disable      ║
  ║ reporting, type 'flutter config --no-analytics'. To display the current    ║
  ║ setting, type 'flutter config'. If you opt out of analytics, an opt-out    ║
  ║ event will be sent, and then no further information will be sent by the    ║
  ║ Flutter tool.                                                              ║
  ║                                                                            ║
  ║ By downloading the Flutter SDK, you agree to the Google Terms of Service.  ║
  ║ Note: The Google Privacy Policy describes how data is handled in this      ║
  ║ service.                                                                   ║
  ║                                                                            ║
  ║ Moreover, Flutter includes the Dart SDK, which may send usage metrics and  ║
  ║ crash reports to Google.                                                   ║
  ║                                                                            ║
  ║ Read about data we send with crash reports:                                ║
  ║ https://flutter.dev/docs/reference/crash-reporting                         ║
  ║                                                                            ║
  ║ See Google's privacy policy:                                               ║
  ║ https://policies.google.com/privacy                                        ║
  ╚════════════════════════════════════════════════════════════════════════════╝

[✓] Flutter (Channel stable, 1.22.5, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.22.5 at /Users/dhs/Code/flutter_stable
    • Framework revision<PHONE_NUMBER> (6 weeks ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • AOSP on IA Emulator (mobile) • emulator-5554                        • android-x86 • Android 9 (API 28) (emulator)
    • iPhone 12 Pro Max (mobile)   • A5473606-0213-4FD8-BA16-553433949729 • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 1.26.0-13.0.pre.117, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
    • Flutter version 1.26.0-13.0.pre.117 at /Users/dhs/Code/flutter_master
    • Framework revision 1f07fde45d (8 hours ago), 2021-01-21 19:15:35 -0800
    • Engine revision 90641fa923
    • Dart version 2.12.0 (build 2.12.0-248.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • AOSP on IA Emulator (mobile) • emulator-5554                        • android-x86    • Android 9 (API 28) (emulator)
    • iPhone 12 Pro Max (mobile)   • A5473606-0213-4FD8-BA16-553433949729 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)              • macos                                • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)                 • chrome                               • web-javascript • Google Chrome 87.0.4280.141

! Doctor found issues in 1 category.

where do you set _scrollController?

In case anyone is looking for a temporary solution, ive been using a scroll controller to force the scroll everytime the onStepContinue is called.
ScrollController _scrollController = new ScrollController();
...
void onNext() {
    ...onStepContinue logic...
    _scrollController.jumpTo(_scrollController.position.maxScrollExtent);
 }

I managed unwanted jumping while the stepper expansion by using _scrollController.position.minScrollExtent in ListView controller

@devidasm may I know how ? better some code snippets . thank you!

after I upgrade flutter to 2.8.1 ,it works ,

physics: ClampingScrollPhysics(), this work for me
Stepper(
physics: ClampingScrollPhysics(),

I think this issue can be resolved, I haven't had the problems mentioned above for a while now.

As per the above comments, closing as fixed.


in Base already ?

https://docs.julialang.org/en/latest/stdlib/math/#Base.Math.@evalpoly

I think you're in the wrong place. This is a Common Lisp repository.

doh!


We have a holistic benchmark test suite that runs a handful of TraceQL queries over a block.
Bench results:
name                                             old time/op    new time/op    delta
BackendBlockTraceQL/spanAttValNoMatch-8            8.90ms ± 0%   28.06ms ± 1%  +215.32%  (p=0.008 n=5+5)
BackendBlockTraceQL/spanAttIntrinsicNoMatch-8      8.46ms ± 0%   28.20ms ± 0%  +233.27%  (p=0.008 n=5+5)
BackendBlockTraceQL/resourceAttValNoMatch-8        8.29ms ± 1%    8.35ms ± 2%      ~     (p=0.421 n=5+5)
BackendBlockTraceQL/resourceAttIntrinsicMatch-8    22.2ms ± 1%    22.3ms ± 1%      ~     (p=0.548 n=5+5)
BackendBlockTraceQL/mixedValNoMatch-8               252ms ± 1%     278ms ± 3%   +10.19%  (p=0.008 n=5+5)
BackendBlockTraceQL/mixedValMixedMatchAnd-8        8.33ms ± 0%    8.36ms ± 1%      ~     (p=0.690 n=5+5)
BackendBlockTraceQL/mixedValMixedMatchOr-8          265ms ± 1%     269ms ± 2%      ~     (p=0.056 n=5+5)
BackendBlockTraceQL/count-8                         472ms ±13%     495ms ± 9%      ~     (p=0.222 n=5+5)
BackendBlockTraceQL/struct-8                        776ms ± 2%     774ms ± 2%      ~     (p=0.690 n=5+5)
BackendBlockTraceQL/||-8                            153ms ± 1%     154ms ± 2%      ~     (p=0.548 n=5+5)
BackendBlockTraceQL/mixed-8                        28.7ms ± 1%    29.0ms ± 1%      ~     (p=0.056 n=5+5)

Profiles:
profiles.tar.gz

I took a look at your profiles, it seems like the code is actually spending a lot less time in parquet-go:
go tool pprof -http :4040 -base profiles/cpu-before-lazy-load.out profiles/cpu-after-lazy-load.out

Maybe the regression comes from an interaction with a different part of the code?

Yup, good call out.
The issue was here:
https://github.com/grafana/tempo/blob/dd0992a4b7a6146a59e25ceeb2879992258ddde0/pkg/parquetquery/predicates.go#L51-L70
We were checking the column index first and dictionary second. The column index started returning values so it ignored the dictionary index which is much more performant.
When I changed the order:
name                                             old time/op    new time/op    delta
BackendBlockTraceQL/spanAttValNoMatch-8            8.94ms ± 0%    8.95ms ± 1%    ~     (p=0.421 n=5+5)
BackendBlockTraceQL/spanAttIntrinsicNoMatch-8      8.47ms ± 2%    8.44ms ± 1%    ~     (p=0.690 n=5+5)
BackendBlockTraceQL/resourceAttValNoMatch-8        8.27ms ± 1%    8.26ms ± 0%    ~     (p=0.690 n=5+5)
BackendBlockTraceQL/resourceAttIntrinsicMatch-8    22.6ms ± 1%    22.3ms ± 0%  -1.48%  (p=0.016 n=5+5)
BackendBlockTraceQL/mixedValNoMatch-8               263ms ± 3%     255ms ± 2%  -2.99%  (p=0.032 n=5+5)
BackendBlockTraceQL/mixedValMixedMatchAnd-8        8.32ms ± 1%    8.31ms ± 1%    ~     (p=0.690 n=5+5)
BackendBlockTraceQL/mixedValMixedMatchOr-8          275ms ± 3%     269ms ± 3%    ~     (p=0.095 n=5+5)
BackendBlockTraceQL/count-8                         484ms ± 9%     488ms ±16%    ~     (p=0.841 n=5+5)
BackendBlockTraceQL/struct-8                        789ms ± 1%     774ms ± 2%  -1.91%  (p=0.032 n=5+5)
BackendBlockTraceQL/||-8                            159ms ± 1%     155ms ± 1%  -2.25%  (p=0.008 n=5+5)
BackendBlockTraceQL/mixed-8                        29.4ms ± 1%    29.0ms ± 1%  -1.37%  (p=0.032 n=5+5)


backport:[1.9] - Run CORS handler first for /api routes (#7967)

Signed-off-by: Tamal Saha<EMAIL_ADDRESS>

@lafriks , sorry I did not see your comment sooner. I have opened this pr to backport this change.
xref: https://github.com/go-gitea/gitea/pull/7967#issuecomment-524832005


Implement modular subpackages

I would like to propose a fairly substantial change to the project which I believe will help facilitate component reuse and allow a wider range of developers to benefit from scaffold-eth.
TL;DR - currently scaffold-eth is a pizza with everything on it. I would like to compose my own pizza using toppings provided by scaffold-eth.
scaffold-eth is massively beneficial to the ecosystem. When I first tried my hand at Solidity development getting the environment set up took more time than learning the syntax. It is difficult to overstate how effective projects like this are for onboarding new developers into the web3 world.
I recently started a couple of projects without scaffold-eth  When discussing them with Austin he asked why I was implementing e.g. Wallet Connect myself instead of using the built-in features of scaffold-eth. I have been reflecting on why I chose not to use scaffold-eth for this project and (aside from NIH Syndrome) it ultimately came down to overhead.
IMO scaffold-eth is most useful for new web3 developers. Someone new to web3 can have a working playground up and running in minutes, and begin experimenting with NFTs, crowdsales, and all sorts of other cool stuff. This is the pizza with all of the toppings.
Once a developer has more familiarity with web3 and wants to take their app to production, some of these toppings add unnecessary overhead. If I am deploying an NFT marketplace I do not want to include the code for crowdsales.
I always like to start my projects from as clean a slate as possible. If I start a project by forking scaffold-eth my package.json contains scripts for deploying a graph. This is useful when prototyping, but if I am going to production without a graph it is an unnecessary line in my package.json which adds cognitive overhead. Also, I have been bitten in the past when using a framework which was bundled with features A, B, and C. Although I only needed feature A, I needed to include the entire dependency tree for B and C. This bloats the output bundle (tree shaking notwithstanding), causes false alarms in Dependabot, and increases build times.
In an ideal world I would like to be able to pick and choose which pieces of scaffold-eth I include in my project, keeping dependencies to a minimum. Instead of cloning the entire repo I would do yarn install @scaffold-eth/hooks @scaffold-eth/ui, adding whichever components I need.
I believe adopting a more modular structure would facilitate this without sacrificing the "up and running in minutes" experience currently offered to developers. It would allow us to establish a library of reusable units of functionality, prevent developers from reinventing wheels, and allow existing projects to make use of scaffold-eth. I see there is already work in this direction in #294 . I propose taking this a step further, moving more functionality to subpackages and publishing them to NPM.
This would have some nice side effects:

examples can be moved from branches to packages (@scaffold-eth/demo-simple-nft). Each demo package would be a self-contained starter kit which would simplify #238
each package (be it a UI library, a TypeScript library, or an end-user demo) becomes a unit of testable functionality
it simplifies the use of CODEOWNERS.txt, allowing responsibility of package updates to be delegated
existing projects could gradually adopt functionality from scaffold-eth
each package can be separately documented
code can be converted to TypeScript as part of the migration process

In practice this would mean setting up the tooling/automation for testing/publishing subpackages, and gradually migrating the code base to the new structure. If there is interest in moving in this direction I would be happy to volunteer to set it up and help migrate code.

I suggest making a new repo for this. The purpose of having everything built in is for the learning part of it and was intended to be that way originally. Now that more and more people want to build production dapps on top of it we can definitely think about what your proposing @mikery

@codenamejason sorry what was the status on this? Is there another project for this?
trying to fork the main repo legitimately takes me more than 30 minutes right now, and it's kind of getting unfeasible with more and more getting added


logEvent - Catch HTTP status of the request as a promise

Hello,
Thanks for providing a node SDK for developers.
I have been working with it lately, but it was very hard to debug the request because I didn't manage to catch the status of the HTTP request made during logEvent.
Is there any way to return a promise from the logEvent function so we can do debug better when we integrate with Amplitude ?
Thanks for your help 🙂

@axelvaindal Glad to hear that you're using our Node SDK. Are you trying to know if an event was successfully submitted to our sever?

@haoliu-amp Indeed, this is what I'm trying to do. More specifically, I would like to get the success status if it's okay or the error message to help me debug the current logEvent request if it's not.

We're thinking changing current design. Instead of triggering a network call whenever submitting one event. We wanna buffer events and then create a batch request instead over all these events.
So when you log an event, there won't be any errors since it's just putting it to a buffer.
However, when batch request happens, we can expose a promise that time, and you can listen to that. Do you think that will help?

When exactly will the buffer be executed ?
Are you thinking about providing something like that:
client.logEvent(); // this push inside an internal buffer
client.logEvent(); // this push inside an internal buffer
await client.sendEvent(); // This send the batch request with all the events

Or do you think the batch send will be handled automatically based on a specific trigger ?
Considering there may be multiple events in that batch, I assume you could expose a single Promise, which either return a success status if the batch request went well, or the array of errors description for each event that went wrong 🤔

buffer execution time will be decided by the threshold you set, like every 30 sec etc.

Batch will be automatic and it can be forced to flush too

Yes, single promise.

Alright, things are clear thanks.
Not sure if I will ever need to batch event sending, but if you feel this is needed to avoid spamming your service with single calls, it's fine for me.
In our current usage, we simply log a single event when something occurs in our server, so the call will never contain multiple events, but perhaps there may be some cases when someone would like to log multiple times in the same server side process.

Firstly, thanks for the new SDK for Node :)
I was about to open a new issue, but I guess this issue is exactly the problem we have. We want to log some events on Amplitude by executing a cloud function (google cloud function) written in node. The thing is: when the cloud function is invoked, one instance of it is created, executed and, when it finishes, the instance is destructed by GCP and we won't be able to check if the request was successful or not. I believe having a Promise as the return from the logEvent method would help to prevent loss of events by resending them or logging the error when it happens.
Is there any way of returning a Promise from logEvent method?!
I've seen your team already have an idea of a new architecture solution that would be great for sending lots of events in one roll, but I'd suggest having also the possibility of sending only one event ( that would be very useful for simple log events using node on server-side).
Thanks in advance.

@BeatrizFerreira Thanks for your feedback! We will definitely consider to keep that API with returning a Promise!
cc: @kelvin-lu

@haoliu-amp that is great! Looking forward to the new version with this change!

@BeatrizFerreira @axelvaindal this is now available in 1.0.3 - see the response type  to see what logEvent and flush return


Footer JS face-palming

Understand why this JS needs to be invoked at the document end, however I added it to my CMS and like a fool I failed to realize that it was loading at the document head and then I burned 30 minutes debugging.
Maybe a stronger note about this needing to be in the footer would help others? Or adding a debug line to the non-minified version?
Ala @line336:
  if (gridElements.length == 0) {
    console.log('Salvattore fail. Are you sure you defined the JS at the end of your document and added "data-columns" to the parent element?');
  }

:+1:

I would also say that, sometimes, I'd prefer the script at head tag, because I don't want that my customer see the content without the columns... does anybody else think the same? :P


Different Sets of Literals, Control and Escape Sequences in Java

Introduction
A literal is the source code representation of a value of a primitive, non-primitive, and null type. There are different instances of literals like integer, floating-point, character, and so on and this is quite different from data types.
Also, the control and escape sequences are both used as their name implies to escape any set of characters following the backslash.  A character with a backslash () just before it is an escape sequence or escape character
Key Takeaways
In this article, readers would have maximum knowledge of the following areas of discussion:

Meaning and different types of literals in Java,
Meaning, why they exist and sets of escape characters usage,
What are control sequences and how have they been used.

Reference
https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-StringLiteral

Thank you @Kayere, I will make sure I explain the concepts in detail and do away from plagiarism.


Migrate data_api stack to fargate

📒 📶

I’ve cancelled the remaining build tasks to get back some Travis time, but this passed the format task so is 👍 to merge.

For some reason the snapshot generator is unhappy so not ok to merge yet


investigate using a bot-detection prevention browser and measures

https://github.com/wkeeling/selenium-wire#bot-detection
we can add an action chain user actions randomizer, flip user agents, proxy, changing user agent and other things to reduce bot-detection rates.

Also instead of directly iterating through the videos one by one we could use random sampling from the all uploads object.
Moreover, if we stopped downloading a channel videos midway we will go through the channel videos one by one and skip the ones the we already downloaded, this is not the most efficient way since the videos are downloaded in order (*should), maybe i can use a binary search, and pop the videos I verified and then at the end the videos I didn't verify I can do a full like scan on the videos that the binary serach skipped in case a download failed.


⚠ ClamAV has degraded performance

In fbe9ddd, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 197 ms

Resolved: ClamAV performance has improved in edc264e.


pip upgrade failed for 0.4.0

While attempting to update to 0.4.0 via the command below, I ran into an error.
$ pip install -U --no-cache-dir ogbujipt
The error was:
Requirement already satisfied: ogbujipt in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (0.3.2)
Collecting ogbujipt
  Downloading ogbujipt-0.4.0.tar.gz (47 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 47.6/47.6 kB 491.6 kB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [20 lines of output]
      Traceback (most recent call last):
        File "/home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
          whl_basename = backend.build_wheel(metadata_directory, config_settings)
        File "/tmp/pip-build-env-kmye2n0e/overlay/lib/python3.10/site-packages/hatchling/build.py", line 56, in build_wheel
          return os.path.basename(next(builder.build(wheel_directory, ['standard'])))
        File "/tmp/pip-build-env-kmye2n0e/overlay/lib/python3.10/site-packages/hatchling/builders/plugin/interface.py", line 93, in build
          self.metadata.validate_fields()
        File "/tmp/pip-build-env-kmye2n0e/overlay/lib/python3.10/site-packages/hatchling/metadata/core.py", line 243, in validate_fields
          _ = self.version
        File "/tmp/pip-build-env-kmye2n0e/overlay/lib/python3.10/site-packages/hatchling/metadata/core.py", line 128, in version
          self._version = self._get_version()
        File "/tmp/pip-build-env-kmye2n0e/overlay/lib/python3.10/site-packages/hatchling/metadata/core.py", line 226, in _get_version
          version = self.hatch.version.cached
        File "/tmp/pip-build-env-kmye2n0e/overlay/lib/python3.10/site-packages/hatchling/metadata/core.py", line 1415, in cached
          raise type(e)(message) from None
      OSError: Error getting the version from source `regex`: file does not exist: pylib/__about__.py
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

However, I was able to successfully install it from the latest in Git main:
$ pip install -U  --no-cache-dir .
Processing /home/chimezie/Projects/Oori/OgbujiPT
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: openai in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from OgbujiPT==0.4.0) (0.27.8)
Requirement already satisfied: python-dotenv in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from OgbujiPT==0.4.0) (1.0.0)
Collecting tomli (from OgbujiPT==0.4.0)
  Downloading tomli-2.0.1-py3-none-any.whl (12 kB)
Requirement already satisfied: requests>=2.20 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from openai->OgbujiPT==0.4.0) (2.31.0)
Requirement already satisfied: tqdm in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from openai->OgbujiPT==0.4.0) (4.66.0)
Requirement already satisfied: aiohttp in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from openai->OgbujiPT==0.4.0) (3.8.5)
Requirement already satisfied: charset-normalizer<4,>=2 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from requests>=2.20->openai->OgbujiPT==0.4.0) (3.2.0)
Requirement already satisfied: idna<4,>=2.5 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from requests>=2.20->openai->OgbujiPT==0.4.0) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from requests>=2.20->openai->OgbujiPT==0.4.0) (1.26.16)
Requirement already satisfied: certifi>=2017.4.17 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from requests>=2.20->openai->OgbujiPT==0.4.0) (2023.7.22)
Requirement already satisfied: attrs>=17.3.0 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from aiohttp->openai->OgbujiPT==0.4.0) (23.1.0)
Requirement already satisfied: multidict<7.0,>=4.5 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from aiohttp->openai->OgbujiPT==0.4.0) (6.0.4)
Requirement already satisfied: async-timeout<5.0,>=4.0.0a3 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from aiohttp->openai->OgbujiPT==0.4.0) (4.0.3)
Requirement already satisfied: yarl<2.0,>=1.0 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from aiohttp->openai->OgbujiPT==0.4.0) (1.9.2)
Requirement already satisfied: frozenlist>=1.1.1 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from aiohttp->openai->OgbujiPT==0.4.0) (1.4.0)
Requirement already satisfied: aiosignal>=1.1.2 in /home/chimezie/miniconda3/envs/OgbujiPT-py-3.10/lib/python3.10/site-packages (from aiohttp->openai->OgbujiPT==0.4.0) (1.3.1)
Building wheels for collected packages: OgbujiPT
  Building wheel for OgbujiPT (pyproject.toml) ... done
  Created wheel for OgbujiPT: filename=ogbujipt-0.4.0-py3-none-any.whl size=24497 sha256=f3a385f291744e3aea447032a8868bca1a55ab6df82e250e6803dc5e4aab9c40
  Stored in directory: /tmp/pip-ephem-wheel-cache-1bmvl7_8/wheels/fe/6a/c9/ecdc9de6abff39026de41acd703b5561c92a0d3ffc64ac8b92
Successfully built OgbujiPT
Installing collected packages: tomli, OgbujiPT
  Attempting uninstall: OgbujiPT
    Found existing installation: OgbujiPT 0.3.2
    Uninstalling OgbujiPT-0.3.2:
      Successfully uninstalled OgbujiPT-0.3.2
Successfully installed OgbujiPT-0.4.0 tomli-2.0.1

So this looks like using miniconda? I don't think we really test with that @kaischuygon do I remember you use it, too?

I wonder if there's something wrong with how I packaged for pypi, this is my first release there. I thought I followed the guidelines here

Seems to have been fixed by building a wheel before uploading to PyPI


chore: release 2.3.1

:robot: I have created a release *beep* *boop*
2.3.1 (2024-05-30)
Bug Fixes

build, buildah: add default registry for mirrors docker.io (a974a1d)
build, buildah: prefix registries mirrors with https (6113528)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v2.3.1 :sunflower:


Doesn’t play well with -Ywarn-unused-import.

We use -Ywarn-unused-import (and -Xfatal-warnings), and get
Unused import
import acyclic.file

on any file I add it to.
I don’t know of any way to silence an unused import warning (e.g., using @SuppressWarnings), but I’d happily do that if possible.

@sellout maybe this plugin can help? https://github.com/ghik/silencer

One solution would be to make the acyclic plugin remove that import when it sees it. If anyone wants to send a PR doing so, I'll gladly merge this

Or you could use -P:acyclic:force which would remove the need for those imports in the first place, assuming your entire codebase is already compliant

Yeah, our codebase is far from compliant. We’ll need to add the import one file at a time.

If the acyclic imports defined some def workaroundUnusedImportWarning: Unit = () then would that solve the problem? File level imports could then
import acyclic.file

object MyClass {
  file.ignoreUnusedImport

Adding -P:acyclic:force doesn't help if you want to prevent package level cycles (an awesome feature by the way).
Silencer is fine for handling this, but I'm curious for why you didn't use annotations instead of an import? That feels like it would read better and be less surprising.

If anyone still needs this, you can silence these warnings with the newish Wconf compiler option:
-Wconf:cat=unused-imports&origin=acyclic\.skipped:s


gf gen dao 生成的 dao/internal 下的 dao 文件 第 73行 有误

1. What version of Go and system type/arch are you using?

2. What version of GoFrame are you using?

3. Can this issue be re-produced with the latest release?
4. What did you do?

执行 命令 gf gen dao 生成 dao 层
5. What did you expect to see?
生成的模板文件有问题，这里需要的是一个 指针类型，但是生成的模板是一个普通类型

6. What did you see instead?

gf v2.3.0 异常 升级 gf v2.3.1 后恢复正常


Validation failing - node xxxxx does not have credentials defined

Attempting to add a new node with the winrm template (as outlined), but the job fails with the subject error message.  How is one to define the Adminstrator credentials for a node that does not exist yet?  Excerpt of full message text from the log follows:
2023/06/29 00:41:31 ERROR #26    VLD29004131402 Node {host_name_omitted} does not have credentials defined. For releases 10.11 and above, use ADMINISTRATOR or custom credentials alias having secure non-default password. For older releases, use DEFAULT_ADMINISTRATOR or custom credentials alias.
Any guidance on how to get this working would be appreciated.  I'm currently testing with 10.15.
Thanks,
Dave

Hi David,
You are right, this template will not work with the validations we added in 10.15. We will fix the readme.
You can setup SSH on Windows and use https://github.com/SoftwareAG/sagdevops-templates/tree/master/templates/sag-spm-boot-ssh.
Here is a snippet from the documentation.
Ensure that the UNIX or Windows operating system on the target machine has a Secure Shell (SSH) server running and the system is configured for remote access with the user account for the Software AG products. You must use Cygwin to configure OpenSSH on Windows operating systems. For information about how to install Cygwin, go to https://cygwin.com/install.html or follow the instructions in the Using Cygwin to Configure OpenSSH When Installing Platform Manager on a Remote Windows Machine article located on the TECHcommunity.


[Serve] Unify logger and add user facing events

Why are these changes needed?
The PR unified the two logger used in the rayservice controller, and adds user facing events, looking like the following
Events:
  Type    Reason                    Age                    From                   Message
  ----    ------                    ----                   ----                   -------
  Normal  WaitForDashboard          2m33s (x2 over 2m33s)  rayservice-controller  Service "rayservice-sample-raycluster-97tzg-dashboard-svc" not found
  Normal  FailedServeDeploy         2m29s                  rayservice-controller  Put "http://rayservice-sample-raycluster-97tzg-dashboard-svc.default.svc.cluster.local:52365/api/serve/deployments/": dial tcp <IP_ADDRESS>:52365: i/o timeout (Client.Timeout exceeded while awaiting headers)
  Normal  FailedServeDeploy         2m21s (x4 over 2m31s)  rayservice-controller  Put "http://rayservice-sample-raycluster-97tzg-dashboard-svc.default.svc.cluster.local:52365/api/serve/deployments/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  Normal  SubmittedServeDeployment  2m17s (x8 over 2m20s)  rayservice-controller  Controller sent API request to update Serve deployments on cluster rayservice-sample-raycluster-97tzg
  Normal  Running                   2m (x10 over 2m2s)     rayservice-controller  The Serve applicaton is now running and healthy.

Related issue number

Checks

[x] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

The events are pretty helpful. great


Synapse - Service Objective

Msg 104385, Level 16, State 1, Line 1
Catalog view 'database_service_objectives' is not supported in this version.
Completion time: 2020-04-08T22:45:42.6399267-04:00

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 228c33b8-2005-40e1-584a-77c32b0433f8
Version Independent ID: 96b3d88c-7343-48a5-37bb-854a94471be1
Content: sys.database_service_objectives - Azure SQL Database
Content Source: docs/relational-databases/system-catalog-views/sys-database-service-objectives-azure-sql-database.md
Service: sql-database
GitHub Login: @stevestein
Microsoft Alias: sstein

@stevej-arbela -- thank you for your feedback.  Which version are you using?

Closing this now, please comment below if there are further issues.


Unsaved files should be preserved on quit

Mac OSX 10.10.5 Yosemite, VS Code 0.10.1
Modern apps have a convention of not losing changes when the application quits and files haven't been explicitly saved. Sublime Text is particularly nice in this regard, where newly created or unsaved files are silently preserved on quit and restored when it is launched again. This would be nice for VS Code to support as well.
To Reproduce

Make changes to a file, or create a brand new unsaved file
Quit VS Code

Desired Behavior
VS Code immediately quits with no prompt. After relaunching the changed file is restored with changes intact and an unsaved indicator.
Actual Behavior
VS Code prompts you to save the file or discard your changes.

Not a big fan of this at all. This should be an option if any and not enabled by default. I find it very confusing that you quit an editor and don't get prompted to save dirty files. You might expect all changes are written to disk when in fact they are not.

FYI : I'm become a big fan of this after computer suddenly hangup/lost power/cats hit shutdown button/etc and everything get restore after reopen.
That's why I'm not uninstall Sublime yet tho.

+1 I occasionally need to exit my editor quickly and like not having to think about saving when I do.

In the VS Code team we all run with auto save enabled (File | Auto Save) so we are past these issues it seems :)

Would love to have this too. Very useful for scratch buffers and crash recovery.

+1 would love to have this feature too - for the same reasons elad mentioned. Actually not having this feature makes me using Sublime again.

I want this feature. End of discussion.  The same is about tabs https://github.com/Microsoft/vscode/issues/224. You are trying to convince us that your solution is better.  We all do stuff differently and nobody cares what you think. I'm using vscode just becasue great support of typescript and angular2.  Sublime text rocks

 From  Sublime Text, Preferences

 // Exiting the application with hot_exit enabled will cause it to close
  // immediately without prompting. Unsaved modifications and open files will
  // be preserved and restored when next starting.
  //
  // Closing a window with an associated project will also close the window
  // without prompting, preserving unsaved changes in the workspace file
  // alongside the project.
  "hot_exit": true,

Quite frankly the hot_exit feature of SublimeText is so important to me
That I won't even consider another editor that doesn't have the feature.
One reason this is the case, is my machine sometimes doesn't come out of sleep
so I just do a forced reboot - no problem as all of my changes will be preserved.
Also note: that the hot_exit feature also preserves the undo stack for each file
this is quite valuable.

Guys please implement this feature this is the only reason why I'm not even consider using VS Code on a regular basis. My laptop shuts down unexpectedly at times so if I'm using Sublime I will be having no issues

@jithurjacob stick with Sublime. Neither Atom nor Code are getting close anytime soon. I tried and failed to switch.

Same here, hot_exit is mandatory to try something else than sublime... would like to try, but can't imagine working again with editor that can't give me this security feelings that sublime is giving to me.
I often switch between 2 or 3 projects, that hot_exit let me do that with abslolutly no pain. Have to check code in another project, 3 new files in the current, no problem, project switch in the same window, copy past what i need, i come back to the working project, all is there ... even new file, undo etc ...
other situation, machin crash, need of restarting windows etc ... is osblolutly painless, as each project keep all files saved or not, open, i get back my tab in each project, can'l leave without this ,D

I really need this feature before I switch to VS code. It's very handy, easy to quit the editor. Many times, I intentionally leave some of my temporary work unsaved in Sublime for many days.

what's the status of this feature now? I just moved from windows to mac and found that sublime doesn't have the feature anymore!!!

ref https://github.com/Microsoft/vscode/issues/906

I have deleted my initial comments on this feature request because it was my personal opinion and not the VS Code opinion. We think this is a perfectly valid feature request.

@bpasero I'm glad to hear that and I'm sure others are, too. I can testify that as far as Sublime replacements go, Atom doesn't look too good because it feels very slow and laggy, and I would love to have the option to switch to VS Code. That said, losing data is something that in 2016 should be off the table. I want my tabs restored when I reopen the browser and I want my unsaved/untitled buffers restored when I reopen my editor. :)

Quoting my comment on the similar Atom issue referenced just above my comment:

In Sublime I can just keep having drafts, kill it any time I'm presenting or having a sole-use of my laptop, and open it later with all drafts intact. The same even if my laptop crashed while Sublime was opened.

I'd love to see this happen with Code now that I'm using it way more often.

With the move to daily builds in Code (https://code.visualstudio.com/blogs/2016/05/23/evolution-of-insiders), I think this feature is even more important.
If I have to restart my text editor every day, and I'm using it as a scratchpad, I don't want to have to save each and every scratch pad once a day, when it's just temporary note files.
It would be great if we can just restart for an update, and have it exactly where we left off.
Browsers remember last saved tabs, so it would be cool if Code can also remember your open buffers as well =).

Installed Code today and the first thing I tested was tabs, the next thing I tested was hot_exit, disappointed on both counts. Will not be making the switch or recommending Code to anyone soon because of this. Guess I'll be sticking to Sublime Text for now.

1
Would be very useful for my surface book and its dead sleep :)

+1 - I would absolutely love this feature!

What is the current status of this feature? When we can see this feature in action?

+1 I've been using Sublime Text for a while and I really miss this feature in Code.

+1. I can't remove sublime only because of that.

+1

@ashwinimohan Under Review since March? https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/7756146-auto-save-temporary-files

This has been "fixed" with a setting that allows you set the interval for saving your doc. But it's not the normal default that OS X has now for when any doc is closed that the system has already been saving every keystroke the whole time, and the entire state of the app has been preserved. I think Windows generally does the same thing. Not sure why this app can't hand over that functionality to the OS...

after developing in VSCode and publishing extensions in VSCode , i still have to use notepad++ to have auto save untitled files and open when opens next time..
Please do it urgent
its very important features that is not implemented yet that stopped me to use VSCode for my dirty notes

still under review since March.

I think we need to create an extension for this

@shanalikhan Actually I am trying to. But since VSCode doesn't provide API like onEditorExit, it's not easy to implement such extension in standard way.

@fyears maybe save after every edit, with timer to prevent overload?

@k00lagin @fyears yes. Using an "onEditorExit" hook won't save work after crashes. For every open editor window, keep a buffer with the text + path to backing store (if there was any). After every edit, but not too frequently, update the buffer text.

@k00lagin @elad Actually VSCode has provided the setting "files.autoSave": "off" for the titled (saved) files in the way as you state. But while using this feature, the editor just ignore the untitled ones while closing editor...
I would say, well, the existing feature is kind of IDE-like, but definitely not SublimeText-like and I could not use VSCode as the "sketchpad".
Moreover, even the extension is implemented in this way, to ensure things going well, we still need the last check with onEditorExit. (And actually SublimeText is not friendly with crashes, which makes me guess it only invokes saving on exit.)

I agree with everyone else, a "hot exit" feature is one of the few killer features that keeps me on Sublime

Having this would make it much less of an issue to restart vscode to install/update extensions. If it's an option on exit it could even be turned on temporarily for all window reloads.

This feature "Unsaved files should be preserved on quit" still not yet implement in VSCode version 1.4 !
It's really needed feature.

Just wanted to vote for this. Can't believe it's been open for almost nine months - VSCode is not a Sublime killer without hot exit.

@amosharper, Why you mention some specific Shareware program name.
Here is freeware Notepad++,
Notepad++ have great feature about this,
See this...

https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/10441491-remembering-last-session-and-auto-saving-untitled

Why you mention some specific shareware program name.

Given how popular that specific shareware program is, it's not unusual that many of us could have been using it for quite a while before Visual Studio Code, and have been using this feature in it way more than the specific freeware program you mentioned.
@lovebdsobuj Please kindly do not spend too much time on this in the thread because that would be thread hijacking. Hopefully you'd agree that this is a mere detail anyway, but please, let's keep it at this either way. Thanks.

Actually,

Asking to save on exit time, it's a old model.
Exit time need to keep all opened tab as well.
Asking to save file when user try to close opened tab. It's a new modern model.

I just tried VS Code for the first time and discovered the lack of "hot exit".  I've decided to stick with Sublime until this is remedied.  Forcing me to save forces me to name the file, determine where to put it, and then manage it's lifespan going-forward...a huge burden for something I intentionally want to be temporarily-lived.

I've had VS Code crash on me a few times, and lost content...sigh.
Is this something that's on the roadmap?

really hope this feature in upcoming versions.

Can I also request that a unsaved file should not prompt to be saved when an editor window closes?
concerns listed here https://github.com/Microsoft/vscode/issues/9304

+1 for:

Restore unsaved changes to files (not auto-saving, just keep the changes in the editor) on re-launch.
Restore changes to untitled tabs.
Optional prompt on exit (I'd default to false).

Thanks!

I guess I'm in the minority on this one. Restore on crash is one thing, and is crucial feature I use in PowerShell ISE, but when I explicitly close an app, I want it to close all documents. As long as it is an option to turn off, I'm good.

+1 this is someting i miss in this editor it would be a huge help if the editor also reopened previous files without having to open a folder.

Atom's Behavior
Based on my testing of Atom v1.10.2, it seems to only care about the single editor case. When a second editor is closed with changes there is no dialog and there is seemingly no way to restore the files.
Sublime Text's Behavior
Based on my testing of Sublime Text 3 build 3114, Sublime only enables hot exit when only a single editor is opened. When attempting to close an editor with dirty files when 2+ editors are opened, Sublime will always show the save dialog.
If a single editor has dirty files and is closed and then Sublime is launched with a different folder via subl <path>, 2 instances of Sublime will be created:

One at the path specified in the command line args
One with the same folders opened in the "hot exit workspace" with all the dirty files open

Proposed VS Code Behavior
I was initially keen on having some clever logic where the files being restored are bound to the open project folder so there could be multiple sets of folders. While this certainly does have its benefits, it's also quite a complex model for users to understand. The major downside being that there's the very real potential to lose work by losing track of backups. For example, if 2 folders with dirty changes are closed and a different folder is opened, using that model the files would not be restored until the original folders were opened again.
I propose behavior very similar to Sublime's, where hot exit is only triggered when the last instance of VS Code is being closed. And if a different folder is opened after a hot exit backup then a second instance appears on next launch with the unsaved changes.
Separate backups on a per-instance basis may happen behind the scenes regardless in order to implement crash protection (#12327) and to reduce the critical path time when closing down VS Code.

@Tyriar you had me at "very similar to Sublime's." Just please don't lose my data. It's 2016, use all the disk space you want. ;)

@Tyriar if it were me, I'd try to avoid the unfriendly prompts when any non-last editor is closed. I think I'd keep VS Code launching to a blank screen by introducing a new sidebar tab that lists closed files that weren't saved at time of closure (including those on disk but with unsaved changes).
If a user opens a file for which an unsaved version exists in the list, I guess I'd either offer them a diff and ask them which version they want to load, or just load the unsaved version (the latter avoids problems if a user opens a folder with multiple unsaved files, where they'd be bombarded with messages about which version to open).
I'd also put a message at the top (as you do with available updated, etc) to indicate that the version that had been opened was the unsaved version.
That said, what you've proposed will still be a great improvement over what we've got at the moment.

It could be me, but I feel a bit of ambiguity has crept into the latest discussion since https://github.com/Microsoft/vscode/issues/101#issuecomment-248537077. The original issue description seems to describe and conflate two important but (IMO) subtly different use cases:

The behavior when exiting with open views of existing files on disk
The behavior when exiting with open views of new unsaved buffers

The usable prompting behavior to handle (1) does seem nuanced, and @Tyriar's assessment makes sense. However, I'm not seeing any explicit solution proposed to handle case (2).
For me, one of the features of Sublime which I "take for granted" and which is explicitly called out in the original issue description is the ability to create unsaved "scratch" buffers and have absolute confidence that they will persist across editor restarts without prompting me to save them.
Is there agreement that (2) is a separate use case? My opinion is that for (2), prompts have no place in the solution. Unsaved new buffers should simply exist in perpetuity until closed between editor restarts without user intervention until they are explicitly saved to a user-provided filename, at which point prompting comes into play per https://github.com/Microsoft/vscode/issues/101#issuecomment-248537077.
Thoughts?

No matter how many instances are opened it saves all untitled files.
When editor opens with empty workspace or not folder it should pop up to open all the untitled files in tabs or all instances or open it layer on. when user select folder to open and close editor
It shouldn't delete the files even then let it be configurable  to remove all or keep it but when user says to keep it it should always either ask or open the untitled files directly this can be made configurable too

@ironcladlou unsaved new files behave the same as dirty existing files in Sublime so that's the behavior we're going for, at least initially. So hot exit will only be available when closing the last instance and it will backup and restore both unsaved new files and dirty existing files.

Agree with @maxlk. Prompting on the non-last window removes a significant amount of the benefit of this change, since a user cannot reliably (for example) shut down their machine and be sure that all files will meet them on startup.

@maxlk improvements beyond what I've specified would likely have to be made after the September release as it's getting close to endgame already. I created #12436 to track this.

This won't make it into the September release unfortunately,. Hopefully it will land in Insiders after v1.6 comes out so it can get a decent amount of testing before shipping to stable.

I was starting to like VSCode until I realised it didn't have this feature (the first time I was required to reboot my machine, a rare thing - normally only on patch Tuesday).
No session persistence at all?! Not autosaving unsaved changes to a session is one thing, but it doesn't even restore which files you had opened (unless you open a folder, which I never do).
I use NP++ as my primary text editor, I can have split views with dozens of files open in each, when I close and reopen the editor its like I never closed it. All the views and open files are persisted, unsaved changes are persisted, all the caret positions persist, all my jump points (bookmarks) persist, etc.
VS Code offers NONE of the above :( .Visual Studio at least persists open files and views, why wouldn't VSCode do this? I saw a feature request for this from 11 months ago, but it was never implemented or had any comment from MS even though it had 300+ votes.

@thedarkfalcon VS code does have auto save (setting "files.autoSave": "afterDelay"), it also restores sessions, the default is to restore the files in a single editor but you can change this to cover multiple editors ("window.reopenFolders": "all").
But anyways, hot exit was planned for the upcoming release but didn't make it in time so it should land in v1.6 which will come to the stable channel in just over a month.

@Tyriar - I'm sure that's helpful but it only works if a folder is open. Personally, I use VS Code often without opening folders (as it's a great editor for single files as well) and it would be nice to have an option restore that editor state as well.
The setting might be revised to something like:
"window.reopenEditors": {"all", "all-folders", "one-folder", "none"}
Conveniently, if you open a folder in vscode, you can then open files outside that folder and their state is restored as well when the editor is reopened, so that's a nice workaround. It definitely suggests the ability to do it without a folder is already there, just needs to be enabled.

@Tyriar thanks for the response, but as I had mentioned in my post I don't think session restore should limited to only work with folders. I am often working with files spanning many directories (many times spanning many different machines even), so in this case the limited session functionality that VSC has doesn't help me.
Further, the autosave feature actually saves to the file, this isn't what I want. Most of the time my unsaved changes are because the file is in an incomplete state, I wouldn't want to save (or autosave) it how it is, hence why I want the session to be saved, not the actual file.
Scenario: Have multiple files open spanning several completely different directories, several of these files have unsaved changes. Close VSC, reopen it.
Desired Behaviour 1: All previously opened files are reopened with the same view/caret position.
Desired Behaviour 2: All files are in the same state the were before VSC was closed (i.e. any unsaved changes are still shown).
Actual Behaviour: VSC is blank when opened 😥

@thedarkfalcon under the default setup you're supposed to get desired behavior 1 automatically so I'm not sure what's going on there, create another issue if you think something is wrong on our end.
Desired behavior 2 is this feature request which is in progress.

@Tyriar okay thanks.

you're supposed to get desired behaviour 1

Just checking before I open another issue, if you open VSC, then open files from different locations (not using the "open folder" function) by either dragging them into the editor or using Open File, you expect these files to reopen after closing and opening VSC? Because that is definitely not what I am getting in v1.5.3.

@thedarkfalcon you're right this doesn't seem to work when you don't have a folder open. I'm not sure if a feature request exists for that yet but it would make sense to have.

👍 This is a killer feature in sublime, this is really needed in vs code

+1 for this...I do use this feature in SublimeText more than I realized.  Really missing it with VSCode.

Just want to stress the point made by @thedarkfalcon about the files.autoSave preference set to afterDelay causing files to be saved in-place, which doesn't work in common web-development situations where you run a watcher that would rebuild incomplete code on-the-fly.
I elaborated more on this in a prior post for #906.

I actually hate Sublime Text's hotexit feature. Atom implemented it - with no way to turn it off! That was actually the main reason for me to switch to VS Code: When I close an unsaved file it asks me two save it.
So please make this an option. I also hope that you don't make hotexit the default with an update, as this is quite a major change which most people won't expect. A prompt if unsaved changes should be saved is actually quite common (e. g. Visual Studio).

@jhasse there will always be an option to toggle it on or off. My plan is for it to be disabled by default for the first version it ships and switch over to the default on the following version. This would be a team decision though. I'm of the opinion more people would like the feature than not and it would be easier to turn it off if you're so inclined then to assume it's implemented and go seek it out in settings.

+1 for this! It's the one crucial feature that VS Code is missing!

+1 This is a crucial feature for me to use this as my daily editor.

+1 for this feature and being implemented to be configurable.

Stop +1, guys. The feature is tracked and should be delivered this month.
If you want to +1 add a 👍  to the first comment.

Hi all, here's an update on this feature. The plan was to push it in for v1,7 in an incomplete state (working for Linux and Windows when closing single windows only) but the implementation is still going through some heavy changes and I don't think it's stable enough to be included for the October release after being in the insiders build for 1.5 days.
Here is the current PR which includes all the hot exit related changed https://github.com/Microsoft/vscode/pull/14115, also issues associated with the PR are now being tracked in GItHub issues under the hot-exit label since it was a real headache trying to track everything only within the PR.
I've broken the feature down into 4 parts that will be worked on in order:

[ ] #14200 Closing a single window that has a folder open and restoring it on next open (Windows/Linux)
[ ] #13733 Closing a single window that does not have a folder open and restoring it on next open (Windows/Linux)
[ ] #13305 Closing all windows and restoring them on next open. Due to the way that the application is still alive after exiting on Mac, this is the only way to use hot exit on Mac (cmd+q) (Windows/Linux/Mac)
[ ] #12327 Restoring backups after a crash (Windows/Linux/Mac), this is a stretch goal for November

+1

@Tyriar I can't seem to see how to enable this (I'm using insiders build).
Only slightly related options I can see is the previously existing  "window.reopenFolders", and "files.autoSave"...
Or has it been pulled from insiders?

@thedarkfalcon it's been pulled, it will probably come back to Insiders in 1-2 weeks.

What is the status for this feature will we see this in upcoming stable build ?

The initial PR got merged on Friday and it will be in the Insiders build within the next 24 hours. Provided there are no major issues it will stay this time 😃. Once it's in, you will need to enable hot exit by adding the following to your settings.json:
"files.hotExit": true

See https://github.com/Microsoft/vscode/issues/101#issuecomment-255513440 for a checklist the major remaining user-facing parts of the feature. The list of current hot exit bugs can be viewed here, if you find something that's not on the list please create a new issue.

Is it just me or is it not working? I have the the current Insiders running on a Macbook Air with the setting enabled. But no matter what I do it always asks to save the changes.

Code - Insiders
Version 1.8.0-insider (1.8.0-insider)
3408691c13470346a119141e57aa74b302464a4a
2016-11-14T07:03:06.956Z

Not sure if it's a difference in OS, but on Windows I think it's only
working if you have a folder open. Without a folder open I am prompted each
time as well. You can see the four parts they are working on here:
https://github.com/Microsoft/vscode/issues/101#issuecomment-255513440
On Tue, Nov 15, 2016 at 2:41 PM, devployment<EMAIL_ADDRESS>wrote:

Is it just me or is it not working? I have the the current Insiders
running on a Macbook Air with the setting enabled. But no matter what I do
it always asks to save the changes.
Code - Insiders
Version 1.8.0-insider (1.8.0-insider)
3408691
https://github.com/Microsoft/vscode/commit/3408691c13470346a119141e57aa74b302464a4a
2016-11-14T07:03:06.956Z
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/101#issuecomment-260744707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAH0gx_TRuwf8Z-h1btrpWFpoQ6gLZPwks5q-grhgaJpZM4GlCMA
.

@devployment currently only cmd+q will trigger hot exit on Mac (https://github.com/Microsoft/vscode/issues/13305). Enabling hot exit all the time for a particular folder is being discussed in https://github.com/Microsoft/vscode/issues/15467.
@seanwcom support for empty (no folder) workspaces is not yet implemented, see https://github.com/Microsoft/vscode/issues/13733

Ok. Totally missed those. Thanks for the pointers. Will check the linked tickets. Keep up the great work!

"Hot exit save" copies the entire content to second file if you're just switching from first file to second file without saving first file.  Very dangerous cause totally corrupts the second file with content of first, if you are unaware of what happens and you close second file with out "undo".

@bpj101 each backup file is saved to a path based on the original file's path, so something like that shouldn't happen. Do you have repro steps showing the problem?

In app.js file,  notice content
[image: Inline image 1]
In app2.js notice content
[image: Inline image 2]
Back in app.js file. Just add black lines to top of code. Notice indicates
1 file to be saved.
Now, without saving app.js, I click on tab to go to app2.js
[image: Inline image 3]
Now notice the content from app.js has been copied to replace content in
app2.js, without changes made to app.js
[image: Inline image 4]
I hope this makes sense.
Thanks
On Wed, Nov 16, 2016 at 10:02 AM, Daniel Imms<EMAIL_ADDRESS>wrote:

@bpj101 https://github.com/bpj101 each backup file is saved to a path
based on the original file's path, so something like that shouldn't happen.
Do you have repro steps showing the problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/101#issuecomment-261022454,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADxkgZHrcIrXqmB1sw45MAxa54p7liBYks5q-0VDgaJpZM4GlCMA
.

Thanks @bpj101, the images don't seem to make it through when commenting via email though :frowning_face:

Sorry. I hoe the written comments in the email helps.
On Nov 16, 2016 11:47 AM, "Daniel Imms"<EMAIL_ADDRESS>wrote:

Thanks @bpj101 https://github.com/bpj101, the images don't seem to make
it through when commenting via email though ☹
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/101#issuecomment-261051349,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADxkgXdN7b_sXX_XWezLBrJgz4GH763Yks5q-13egaJpZM4GlCMA
.

50+ people get notifications when a comment is made on this issue.

Sir @bpj101, If you just edit your previous comment with images, It will better.

I just pushed empty workspaces which also closes off the crash recovery story so I'm closing this off :sparkles: Empty workspaces should come in the next Insiders build.

Has this been released, or is going to be released soon? There are a ton of comments to try and figure out if the original story was rejected, fixed, or if something else but similar was put in place.

@g5codyswartz to be released soon (tomorrow), you can always check the milestone the issue is assigned for when it's expected to hit the stable release.

@g5codyswartz
preemptive tl;dr: Should be released in, like, 24 hours, with the 1.8 release.
@Tyriar's comment farther up shows that he broke this issue into a few different sub-issues to better track the relevant parts that needed to be implemented, in case you hadn't seen those.
Also, you can always check the iteration plan for an upcoming release and see if a feature/bugfix/etc. made it onto the list, as well as check it's completion state!
Hope that helps!
Also, thanks so much for the hard work on this @Tyriar and @bpasero.
All of us Sublime Text transplants couldn't be happier!

My apologies for commenting on a closed issue, but this seems to be the best place to ask.
Hot exit seems to be working great on any unsaved files, but should saved files also be restoring? Perhaps I'm missing a setting somewhere, but I've looked through and didn't see a way to set that. My expectation is that dirty or not, the full session would restore. Right now if I have 2 dirty files, 1 untitled (dirty) file, and one saved file then the first three are restored, but the saved file is not brought back.
I'll be happy to open a new issue if needed, but thought I would check here first in case I'm just missing a setting. Thanks for everyone's effort on this!

@seanwcom we do this as long as you have a folder opened, but not in "empty" workspaces (see #207)

I need this for "Untitled" files. Everytime I close VSCode manually, it is prompting me to save untitled files. If I don't save it, then its not restored. I don't want to save those untitled files, I just use those as scratch notes. If I ctrl+alt+del to force exit then it works, but i prefer not to ctrl+alt+del it.

@Noitidart it should behave exactly as you expect right now.
I checked my user settings and the only setting that might affect this is:
"window.restoreWindows": "all"

although based on the description I'm not sure that's right either.
All I know is that on Windows 10 x64 and the last many VS Code releases, I can have one or more untitled, unsaved buffers open and modified and they restore just fine through closing and opening, regardless of how I seem to close it.

Oh thanks @joshsleeper will try now! Mine was set to "one"

Oh thanks @joshsleeper will try now! Mine was set to "one"
Edit:
If my untitled file has unsaved chnges, it is still prompting :( even after pref change.
https://screenshots.firefoxusercontent.com/images/c80f3433-b728-4f38-a7a4-c3775f10fac8.png

@Noitidart drat!
Just to be sure, you are using the correct setting, right?
The name has changed over time.
It used to be window.reopenFolders, then window.reopenWindows and now it's window.restoreWindows
Just grasping at straws, because as of #28580 it should totally be working properly and certainly does for me.
Make doubly sure you don't have any invalid user settings maybe?

@joshsleeper found it! Thanks so much for your help! There was a setting called:
"files.hotExit": "onExitAndWindowClose"

Mine was set to "onExit" I changed it to "onExitAndWindowClose" and it's perfect! VSCode rocks!!


Android compiling errors

Expected Behavior

The goal is to find the face landmarks in native code for an android application.
Current Behavior

Android studio reports that in shape_predictor.h, line 227:
feature_pixel_values[i] = get_pixel_intensity(img[p.y()][p.x()]);
img is not an array; plus opening generic_image.h a lot of errors get reported.
I believe these are not the only cases Android studio discovers in the entire dlib code.
Steps to Reproduce

I can share my code but I simply integrated (and I know it's correct) dlib into an android project.

Version:  19.17
Where did you get dlib:  github repo
Platform:  Android
Compiler:  Gradle 3.3.2

where the source code you built for android? I used it before in face recognition/face detection/ face shape prediction and working correctly it android.


Play well with Ractive

Is there anyway to make the <select> work inside Ractive template? https://jsfiddle.net/z6kef166/1/

Edited to prove that Ractive is working: https://jsfiddle.net/ceremcem/y3m44t8y/1/

@caseyjhol can be closed as a working solution was provided.


Shadow samplers;

This was a bit rushed, going to look over it later.

I think I'm supposed to reverse the compare mode (currently doing this for stencil test).


Encourage best practice by always forwarding available cancellation token to awaitable calls

Proposed Changes
Make samples more complete by always passing down available cancellation tokens to any awaitable calls.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: chivandikwa sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@gabog @johnataylor merge conflicts not withstanding, do you want to pick this up?  this PR isn't complete, as .NET Templates, and VSIX Templates would need to be modified in addition to the files in this PR.


Settings, music, splash screen

Added functional settings page
Added splash screen
Changed music due to licencing issues

partially implements #31