TorchAudio FFmpeg migration

Overview
We propose the following end state for TorchAudio’s I/O functions info, load, save:

FFmpeg is the primary backend for TorchAudio’s I/O functions info, load, save.
FFmpeg-, SoX-, and soundfile-based backends are user-selectable from said I/O functions and are no longer determined by global state.
All of FFmpeg, SoX, and soundfile are optional dependencies.
I/O functions no longer support TorchScript.

Context
TorchAudio’s functions info, load, and save currently rely on two third-party libraries: SoX and soundfile. Whereas SoX is used in the Linux and Mac distributions, soundfile is used in the Windows distribution.
Through the years, we’ve encountered several issues with SoX:

Its handling of in-memory decoding is buggy and requires a local patch to fix.
It accesses the internal structure of FILE* object. As a result, 14.4.42 does not compile on Windows with MSVC newer than 2013. This precludes us from using SoX across platforms.
It attempts to rewind stdin.
It has not been actively developed/maintained since 2015, which doesn’t lend confidence that the aforementioned issues will be addressed.
It has caused other user-facing problems:

https://github.com/pytorch/audio/issues/2870
https://github.com/pytorch/audio/issues/2356

Separately, our work around streaming I/O introduced FFmpeg as a dependency. FFmpeg's advantages over SoX include the following:

It’s battle tested. It’s been developed for over 20 years now and is widely used in industry.
The library code is portable across Linux, Mac, and Windows.
It supports a wide variety of codecs, from basic to advanced, for both audio and video.
It supports GPU acceleration in decoding and encoding.
The C API offers a high degree of customizability.

It abstracts away many things like codecs, file formats, and devices.
It allows for implementing custom I/O such as in-memory decoding/encoding with file-like object protocol.

It’s being actively developed, with the latest version (5.1) having been released in July 2022.

End state
To address the issues above, we propose the following end state:

FFmpeg is the primary backend for TorchAudio’s I/O functions info, load, save.
FFmpeg-, SoX-, and soundfile-based backends are user-selectable from said I/O functions and are no longer determined by global state.
All of FFmpeg, SoX, and soundfile are optional dependencies.
I/O functions no longer support TorchScript.

We anticipate this end state bringing greater cross-platform consistency, simplifying our codebase, and delivering an improved user experience.
Plan
Release 0.14

Introduce option to {info, load, save} that allows users to choose any of FFmpeg, SoX, and soundfile as the I/O backend for both file paths and file objects, while preserving the existing behavior, i.e. Linux and Mac distributions default to relying on SoX, Windows distributions default to relying on soundfile.

Doing so naturally removes TorchScript support in {info, load, save}.

Add deprecation warnings that convey that release 0.15 will make FFmpeg the default backend for files and file objects for {info, load, save} and encourage users to switch over to FFmpeg.

Release 0.15

Make FFmpeg the default backend for files and file objects for {info, load, save} across all platforms.
Make SoX an optional dependency that is dynamically linked if available. Linking enables the SoX backend and torchaudio.sox_effects.
Remove file-like object handling for the SoX backend.
Remove dependence of backend selection on global state.

Related: https://github.com/pytorch/pytorch/issues/81102

Hi @vadimkantorov — thanks for flagging. Somewhat independently of this particular issue, we are indeed considering consolidating media I/O in a separate package. We'll post updates on the outcomes of our discussions here.


JsonSyntaxException MalformedJsonException from AutoConfigManager.load

What you were trying to do
Start the game.
What actually happened
Before getting to the main menu, the game crashes with
[main] ERROR o.t.engine.core.TerasologyEngine - Failed to initialise Terasology
com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 1 column 4 path $
        at com.google.gson.Gson.assertFullConsumption(Gson.java:908)
        at com.google.gson.Gson.fromJson(Gson.java:871)
        at org.terasology.engine.persistence.typeHandling.gson.GsonPersistedDataReader.read(GsonPersistedDataReader.java:33)
        at org.terasology.engine.persistence.typeHandling.gson.GsonPersistedDataReader.read(GsonPersistedDataReader.java:16)
        at org.terasology.persistence.serializers.Serializer.deserialize(Serializer.java:84)
        at org.terasology.engine.config.flexible.AutoConfigManager.loadSettingsFromDisk(AutoConfigManager.java:81)

there may be other errors shown adjacent to this as things crash.
There's a config file that contains
{}debugEnabled":true}

which looks like something probably opened an existing file without truncating it and wrote the empty object {}.
Log details and game version
running develop sometime after 4.3.0

this is a thing that should get improved error reporting (which file had the syntax error?) as well as a fix.

 Write up issue for JSON issue


Dinamic graph

I've drawn a graph with pulse shape from a csv file, the csv has at least 1000 data point to draw but I  send only 250 to the data float[] that shows on the sparkview adapter.
Now I need this graph to became dynamic, so it has to shift rightward showing new data and hiding the old data (showed at beggining on the left side), but containing the same data amount showed (250 x points).
Does any of your methods work in this way?
Thanks in advance.

We don't have anything built in for this type of animation. You can pretty easily get this effect by using two SparkViews on top of each other in a FrameLayout, though. Load your first set of data into SparkView 1, which is shown to the user. Set SparkView 2's translationX so that it's all the way to the left of SparkView 1. Now load the next set of data into SparkView 2, and animate the translationX of both SparkViews to the right until SparkView 1 is offscreen, and SparkView 2 is in SparkView 1's original spot.
Hope that helps!


added popInitialNotification function

This function allows you to access the "payload" sent with your notification.

Thanks!
One questions.
Why don't you put popInitialNotification in public Map<String, Object> getConstants() rather than here
I think putting it in getConstants will be more like official react native implementation

@oney I didnt realize that could be done. I think that will be a better approach since then we dont need to use an event listener. Also I was thinking that we need to clear that notification after it has been "popped".

Currently, this module uses https://github.com/Neson/react-native-system-notification to create notification in 0.1.7. You can get payload of clicked notification in DeviceEventEmitter.addListener('sysNotificationClick' listener. Please see whether it meets your requirements.
I still more like use popInitialNotification way to get payload, but I prefer to handle creating notification in  react-native-system-notification rather than react-native-gcm-android.

DeviceEventEmitter.addListener('sysNotificationClick'  doesnt work when the app is not already open.

Yeah DeviceEventEmitter.addListener('sysNotificationClick'... only works when the app is open. popInitialNotification would be ideal.

@RGBz absolutely agree with you. I will remind the author of react-native-system-notification this issue, and wait him to fix it.

Thinking about it a bit more, a callback-based approach like this implementation of popInitialNotification or DeviceEventEmitter.addListener('sysNotificationClick'... is not what you'd want to handle opening the app via notification because it means the app will:

Open up and start rendering a screen (like an apps home screen)
Process the DeviceEventEmitter.addListener('sysNotificationClick'... callback
Render the screen you'd want to show for the notification

The PushNotificationIOS.popInitialNotification API returns its value inline which instead of using a callback. This would allow for you to open the app right up to the screen you'd want on the first render pass.
@oney What are your thoughts? If you agree I can look into making a popInitialNotification that returns its value inline as well.

My opinion is same as you, directly get payload from popInitialNotification like PushNotificationIOS.popInitialNotification, not from or on a callback. I have mentioned here.
Because the notification is created from react-native-system-notification module, the better way of this implementation is making PR in that module instead of here.

I agree, I'll hop over there. Thanks!

I agree a more inline approach would have been suitable. Wasn't sure how to make that work.


Consider rename and Transfer ownership?

@Cotswoldsmaker if this is going to be the prototype/POC for the "web front end" to generate and manage standard DCB0129 templates, it possibly needs renaming to something more specific to that.
I would suggest possibly:

dcsa-clinical-safety-platform
digital-clinical-safety-platform

or something like that
And then maybe it would be worth transferring the repo to the DCSA organisation?
thoughts?

@pacharanero I like "digital-clinical-safety-platform". I will finish what I am working on, merge two branches and transfer ownership to DCSA


Fix Qual Match Title on Team Page for Final Division

If no Finals in the Event do not show qualification matches title bar for the event.  This is only seen on the team page.

close in commit 54e9f8b


Setting the default file chooser

Summary
When using the Slack desktop app and wanting to upload a file, it insists on using ranger even when that is not installed.
Also it does not work properly when installed.
Do you know how to change it?

Hm, I can say for sure that it isn't ranger for me. Perhaps that can help us track down how to change it for you? I assumed, that it should be enough to have the inode/directory "file type" set to pacman? For me, there is inode/directory=pcmanfm.desktop in the system wide mime types in /usr/share/applications/mimeapps.list. Is there probably an override in  .config/mimeapps.list containing ranger?
Ref.: https://wiki.archlinux.org/title/XDG_MIME_Applications#mimeapps.list

Hm it was overridden to dolphin locally, which I uninstalled at some point, I will experiment a bit...

This now also occurred in Signal, smells like some update

I don't have ranger installed, so probably a ranger update broke it?

but I do not have it installed either :joy:

This still hasn't happened to me, I fear I don't know which package updates your mime settings...

works fine for now


Softmax fix

Softmax layer in eval mode added;
model.train(), model.eval() in train.py placed for better performance

Fixes from issue #51

hello，I can probably understand what you mean and follow your code to repeat it, but when calculating the loss, I wonder whether the following error occurred because my real label had 20 classes（the value of y_batch is 0, 1, ..., 19, shape of y_batch is [batch_size, 256, 256]）
Error reported as follows:
Traceback (most recent call last):   File "train.py", line 141, in <module>     loss.backward()   File "D:\software\anaconda\lib\site-packages\torch\_tensor.py", line 489, in backward     self, gradient, retain_graph, create_graph, inputs=inputs   File "D:\software\anaconda\lib\site-packages\torch\autograd\__init__.py", line 199, in backward     allow_unreachable=True, accumulate_grad=True)  # Calls into the C++ engine to run the backward pass RuntimeError: Unable to find a valid cuDNN algorithm to run convolution


TN-692 Extend event mechanism to include upload-user-docs

Sorry about the noise of a refactor, but client was getting way too big, and auth is huge.
I have tested the events using my demo-intervention - looks to be working.

Rolling out as is to get it to MUSIC this morning.  Will address comments later, thank you @ivan-c .


docs: add zookeeper docs

Codecov Report

Merging #54 (a73279e) into main (e7cf1fe) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   62.73%   62.55%   -0.18%
==========================================
  Files          16       16
  Lines        1127     1127
==========================================
- Hits          707      705       -2
- Misses        356      357       +1
- Partials       64       65       +1

Impacted Files
Coverage Δ

internal/core/storer/etcd.go
66.07% <0.00%> (-1.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7cf1fe...a73279e. Read the comment docs.


Document Python 3.7 support in setup configuration

This is tested on Travis, so would be good to get into the official package details.

Great, thanks!


fix(material/tabs): ensure the ink bar realigns when the tab header i…

…tems have changed in dimensions

Does this fix #4648?

Yes.
On Tue, May 17, 2022, 5:06 PM Jeremy E. @.***> wrote:

Does this fix #4648 https://github.com/angular/components/issues/4648?
—
Reply to this email directly, view it on GitHub
https://github.com/angular/components/pull/24932#issuecomment-1129317684,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIHPJZGRE2VBUZXNQ5TB6TVKQC6JANCNFSM5WGFYIYQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

https://github.com/angular/components/pull/24885 is the full version of this. Closing this one.


output & exit are Undefined!

my php version is php 7.0
[root@vultr license]# zephir build
zephir_parser extension not loaded, compiling it
Parser statistics: 127 terminals, 99 nonterminals, 459 rules
947 states, 0 parser table entries, 0 conflicts
PHP Notice:  Undefined variable: output in /zephir/Library/Compiler.php on line 237
PHP Notice:  Undefined variable: exit in /zephir/Library/Compiler.php on line 237
PHP Warning:  exec() has been disabled for security reasons in /zephir/Library/Compiler.php on line 237
Preparing for parser compilation...
PHP Notice:  Undefined variable: output in /zephir/Library/Compiler.php on line 239
PHP Notice:  Undefined variable: exit in /zephir/Library/Compiler.php on line 239
PHP Warning:  exec() has been disabled for security reasons in /zephir/Library/Compiler.php on line 239
PHP Warning:  exec() has been disabled for security reasons in /zephir/Library/Compiler.php on line 241
Compiling the parser...
PHP Notice:  Undefined variable: output in /zephir/Library/Compiler.php on line 246
PHP Notice:  Undefined variable: exit in /zephir/Library/Compiler.php on line 248
PHP Warning:  exec() has been disabled for security reasons in /zephir/Library/Compiler.php on line 248
PHP Warning:  file_get_contents(compile-errors.log): failed to open stream: No such file or directory in /zephir/Library/Compiler.php on line 249
PHP Warning:  file_get_contents(compile.log): failed to open stream: No such file or directory in /zephir/Library/Compiler.php on line 250
PHP Warning:  copy(modules/zephir_parser.so): failed to open stream: No such file or directory in /zephir/Library/Compiler.php on line 251
Zephir\Exception: The zephir parser extension could not be found or compiled!

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29205513-output-exit-are-undefined?utm_campaign=plugin&utm_content=tracker%2F280146&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F280146&utm_medium=issues&utm_source=github).

Not a zephir bug.
Zephir tries to execute shell commands,
which results in the output variables not being
set due to your php security settings.
Adjust them and it will work. (If you dont know how, google the warning about exec being disabled)


AnySigner.plan Estimating Zero Fee for Small Transactions

I'm encountering an issue where users trying to send 0.0001 BTC are getting a zero fee estimate using AnySigner.plan with a fee rate of 100 Sat/vB. This seems to be related to the dust filter settings.
Here's the relevant code snippet:
I'm facing issues when users try to send 0.0001 BTC, as it return 0 estimating fee usign AnySigner.plan with 100Sat/vb.
                    val input = Bitcoin.SigningInput.newBuilder().apply {
                        this.amount = amount       //1962973
                        if (maxAmount) {
                            this.useMaxAmount = true //auto-sweep
                        }
                        this.hashType = BitcoinSigHashType.ALL.value()
                        this.toAddress = addressToTss //Receiver ADDRESS (TO) MUST BE TSS
                        this.changeAddress = changeAddressLeftOver.ifEmpty { addressFrom } //LEFT OVER
                        this.byteFee = feePervByte.byteFee.toLong()
                        this.coinType = CoinType.BITCOIN.value()
                    }

Questions:
1 : When AnySigner.plan returns zero for all, does this indicate that the value is below the dust limit?
2 : How can I calculate the dust limit to inform users before calling AnySigner.plan.?
3 : Do you think it's valid to use disableDustFilter = true? I tested this configuration with AnySigner.plan and managed to get the estimated fee, as well as successfully send the transaction. I'm considering keeping disableDustFilter enabled and adding a manual minimum limit, like 0.00001 BTC, following Trust Wallet. What do you think of this approach?
Additional Context:
Amount to send: 0.0001 BTC
Fee Rate: 100 Sat/vB
Total Balance: tBTC: 0.016012

Hi @ronaldoguedess, dust filter was improved at https://github.com/trustwallet/wallet-core/pull/3675
So first of all, you should set a proper SigningInput.dust_policy to fixed_dust_threshold = 1000 or fixed_dust_threshold = 546 (in case of P2PKH, P2WPKH transfers). Otherwise, we use a legacy high dust threshold.
More info on dust thresholds at https://bitcoin.stackexchange.com/questions/10986/what-is-meant-by-bitcoin-dust
Regarding disableDustFilter, I don't recommend to use it.
Please let me know if it solves the issue

Hi @satoshiotomakan
I removed disableDustFilter, thanks.
Can I use like this? Will this set up the dust limit to 0.00001 BTC?
val input = Bitcoin.SigningInput.newBuilder().apply {
    this.amount = amount
    if (maxAmount) {
        this.useMaxAmount = true //auto-sweep
    }
    this.hashType = BitcoinSigHashType.ALL.value()
    this.toAddress = addressTo //receiver
    this.changeAddress = changeAddressLeftOver.ifEmpty { addressFrom } //LEFT OVER
    this.byteFee = feePervByte.byteFee.toLong()
    this.coinType = CoinType.BITCOIN.value()
    this.dustPolicyCase //do i need to set it?
    this.fixedDustThreshold = 1000 // or 546 for P2PKH, P2WPKH transfers

}```

@ronaldoguedess yes


⚠ Bofrost.lu has degraded performance

In 2f7217f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1299 ms

Resolved: Bofrost.lu performance has improved in 42ad86e after 7 minutes.


Fixing multiple issues in merged/HPMT pipeline

Description
This PR fixes:

#88: we remove all types of non-domestic installations now (commercial, non domestic and unspecified when not mapped to an EPC record)
#95: moved this to after EPC and MCS are concatenated, as doing it before was leading to duplicated records
#89: as requested by Luca
#92: in asf_core_data/pipeline/data_joining/install_date_computation.py when we were getting the UPRN mapping, multiple installations where mapped to the same UPRN. This might be happening because a home gets multiple HPs over time (possible but unlikely at this point) or because multiple homes with installations in similar addresses (likely in same building) are being mapped to the same UPRN. For those we now remove the mapping with EPC and treat them as if they're not in EPC (as we can't be sure which one is the correct mapping)
#93 : we were getting duplicates because of the way we were merging to epc/mcs to installers data. This is now fixed;
#94 : installers postcode was being renamed to POSTCODE which is the installation postcode. This is now fixed.

closes #95
closes #94
closes #93
closes #92
closes #89
closes #88
Instructions for Reviewer(s)
Review
Hey @Jack-Vines and @sqr00t , thanks for reviewing these scripts. Could one of you please double check if the logic looks okay for the changes in:

asf_core_data/pipeline/data_joining/merge_proc_dataset.py
asf_core_data/pipeline/data_joining/install_date_computation.py

Setup
In case you want to run the pipeline to make sure it works:

clone this repo: git clone git@github.com:nestauk/asf_core_data.git
checkout to the correct branch: git checkout 88_remove_non_domestic_installations
Run make install;
Run direnv allow;
Activate the conda enviroment: conda activate asf_core_data;
Set your API credentials as environment variable, i.e run export COMPANIES_HOUSE_API_KEY="ADD_YOUR_API_KEY_HERE" in the command line and replace ADD_YOUR_API_KEY_HERE with your API key credentials.
Run python asf_core_data/pipeline/data_joining/merge_proc_dataset.py

Lgtm too! Thanks @sofiapinto

Thanks a lot for taking a look at the PR @sqr00t & @Jack-Vines :D most up to date version of HPMT is now on asf-core-data's S3 bucket.


API routes

What problem does this feature solve?
Automatically populate pages/api/**/*.vue as API routes so that:

Custom server becomes unnecessary
Better DX, you don't need to start a nodemon process for API
The possibility to optimize your API routes for serverless environment

What does the proposed changes look like?
Reference implementation: https://nextjs.org/docs/api-routes/introduction

I think we can now close this issue as it is implemented in Nuxt 3: https://nuxt.com/docs/guide/directory-structure/server.


Fix: Update link in Docs to Union page [currently 404]

Description
This PR fixes a typo in the link to the Union page which currently leads to a 404.

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[X] Documentation

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)


Bad sample code in documentation

There are several syntax errors in the sample code in the Repeater Options documentation, seen here:

http://getfuelux.com/extensions.html#bundled-extensions-list-options

Source code here:

https://github.com/ExactTarget/fuelux/blob/gh-pages/_includes/extensions/repeater-list.html#L217

fixed.


feat: Add yaml header to various trestle author docs in a safe manner.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary

Adds an extra flag to ensure that the yaml header passed is non destructive
This is required to cater to scenarios where a control is 'added' in a workflow.
Also includes fixes to remove yaml reordering.

Key links:

Sonar coverage

More work required.


avoid unused function warnings when building on Solaris

When building mimalloc on Solaris, we are seeing unused function warnings:
/.../cpython-main/Objects/mimalloc/prim/unix/prim.c: At top level:
/.../cpython-main/Objects/mimalloc/prim/unix/prim.c:90:12: warning: 'mi_prim_access' defined but not used [-Wunused-function]
   90 | static int mi_prim_access(const char *fpath, int mode) {
      |            ^~~~~~~~~~~~~~
/.../cpython-main/Objects/mimalloc/prim/unix/prim.c:87:12: warning: 'mi_prim_close' defined but not used [-Wunused-function]
   87 | static int mi_prim_close(int fd) {
      |            ^~~~~~~~~~~~~
/.../cpython-main/Objects/mimalloc/prim/unix/prim.c:84:16: warning: 'mi_prim_read' defined but not used [-Wunused-function]
   84 | static ssize_t mi_prim_read(int fd, void* buf, size_t bufsize) {
      |                ^~~~~~~~~~~~
/.../cpython-main/Objects/mimalloc/prim/unix/prim.c:81:12: warning: 'mi_prim_open' defined but not used [-Wunused-function]
   81 | static int mi_prim_open(const char* fpath, int open_flags) {
      |            ^~~~~~~~~~~~

This was noticed when building latest Python main; here is the downstream report:
https://github.com/python/cpython/issues/112806

Thanks so much -- I merged manually into dev (and dev-slice soon) as the PR was based on master.


Add markdown max version for mkdocs-material.

Can't wait for that advanced pip version resolution! :smile:
Our nox docs session is now failing because of a version conflict.  It installs the latest Markdown version (3.2), which then conflicts with mkdocs-material which has a requirement Markdown<3.2.
This PR has a workaround to force install of Markdown<3.2 until mkdocs-material will accept the latest Markdown version.

https://github.com/squidfunk/mkdocs-material/issues/1450

Can't wait for that advanced pip version resolution!

I think pip-tools already does this with pip-compile. I see some projects make a dev_requirements.txt to install in their test suite, which would have avoided this issue.


Define writing style guide for Indonesian translated docs

This is a Feature Request
What would you like to be added
Translate https://kubernetes.io/docs/contribute/style/style-guide/ and define our own writing style guide
Why is this needed
Writing Indonesian docs for technical stuffs is not an easy task, because of the nature of the language and the way we import various English words. We need to standardize the way Indonesian translated docs are written (personas, standardized glossary) with our own opinion.
Comments
This will help onboarding more and more contributors from Indonesian community.
/language id

/remove-lifecycle stale

@girikuncoro how about this issue?

This should be owned by @qbl along with the glossary thing. Let's keep on
tracking it.
On Fri, Jul 26, 2019, 10:29 Irvi Aini<EMAIL_ADDRESS>wrote:

@girikuncoro https://github.com/girikuncoro how about this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/issues/13860?email_source=notifications&email_token=AAYLMG5V6MGIYMU2EWJVFJTQBJHQ3A5CNFSM4HGUDSWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23HIOQ#issuecomment-515273786,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYLMGY6KYWYXTU6KMEAT4DQBJHQ3ANCNFSM4HGUDSWA
.

/kind feature
/priority backlog


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Hi Jad,
I am very much impressed with your project and wanted to redevelop my existing project on your this current version. I wanted to use Laravel 5.3 & progressive web app functionality that you are covering in this version but looks like its not stable yet.
It would be great help if you can give me some reference of idea where I can begin with. My current project is already in Laravel 5.0 & Angular 1.3.

HI @aarticianpc
Yeah 5.3 is not ready yet
Well I guess you can start with version 3.2 if you don't want to wait
You can follow the tutorial on the screencasts to see how we write components in Angular 1.5
Let me know if you have any questions 😄


Can it run doom?

Did you try running doom on it yet?

This is the de facto standard for teating custom systems

It has a screen! -> Let's make it play Bad Apple!
It is a CPU! -> Let's make a C-to-EXCEL-ASM16 compiler? Or should we get a bf compiler as well?
The possibilities are endless...

If you can get around the 3Hz limitation by getting Excel to do the iterated calculations quicker ....... then this might get closer to doable.

doom is 32-bit and this is a 16-bit, you can probably run snes doom in this or mod doom to be 16-bit, but vanilla doom? nah

doom is 32-bit and this is a 16-bit cpu, you can probably run snes doom in this or mod doom to be 16-bit, but vanilla doom? nah

wait what,wasn't doom a 16-bit program running on MS-DOS?

doom is 32-bit and this is a 16-bit cpu, you can probably run snes doom in this or mod doom to be 16-bit, but vanilla doom? nah

wait what,wasn't doom a 16-bit program running on MS-DOS?

Yesn't.

The earliest version of Doom and Doom II which was for DOS, which itself is a 16-bit operating system, used an internal utility called DOS/4GW which allowed entertainment software with 32-bit quality gameplay to run on a 16-bit operating system. This was all thanks to the minimum requirement for an Intel 386 processor which was the first 32-bit x86 processor. When Doom, Doom II and Final Doom were released onto Windows 95, Windows 95 itself was a hybrid 32-bit/16-bit operating system, though Doom95 itself was a Win32 application, and Windows 95 required a 32-bit x86 processor.

thats what i was wondering


Local variables are not expandable - cannot drill into the members

Repo:
RC2 empty web application
set break point within app.Run
try to inspect context
C# Extension: 1.0.3-rc2

Thanks for reporting this. How did you create the 'empty' web application? Is it just the 'context' variable or all local variables?

David Fowler ran into this too. It is mostly the same problem as in #173, though I also found #178 while poking around.


feat: added binding std::fs::canonicalize

Could you also add a test at the bottom for this binding as well? Its not necessary but it does ensure that whenever cargo test runs, it will show it working as it should.


Disable creating new tag by pressing enter

Because example does not support custom tag, creating new tag by pressing enter should be disabled.
(with custom tag, the field value may look like [1,2,'A Tag']).

Thanks :)


Translation of Accounts

In the account view I can see a language selection.
But it only shows english, although I have multiple languages defined in the config.yaml.

Same issue here...


Receiving 404 error

I tried to test the package both on macOS and Windows, but I am receiving 404, used the instructions from the help page, and read the FAQ.
I tried simple code, I made sure to copy the proper cookie value, I tried using cookies both from brave and chrome browsers.
from bardapi import Bard
import os
os.environ['_BARD_API_KEY']="xxxx"
Bard().get_answer("나와 내 동년배들이 좋아하는 뉴진스에 대해서 알려줘")['content']
python3 ./bard.py
Traceback (most recent call last):
File "/Users/neopsyon/Desktop/./bard.py", line 5, in
Bard().get_answer("나와 내 동년배들이 좋아하는 뉴진스에 대해서 알려줘")['content']
^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/bardapi/core.py", line 78, in init
self.SNlM0e = self._get_snim0e()
^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/bardapi/core.py", line 149, in _get_snim0e
raise Exception(
Exception: Response status code is not 200. Response Status is 404

OS: Mac Ventura 13.4.1
Python: 3.9.6
Bard API: 0.1.38

This software works correctly on Mac, Linux (including Google Colab), and Windows. However, if you repeatedly reconnect sessions, the cookies may get refreshed. Please avoid creating the object multiple times.
When cookies are refreshed, you should:

Log out.
Completely close your browser and restart it.
Log in again to input the new cookie values. Depending on your location, you may need three or more cookies, and you can use a Multi-cookie bard object if necessary.

For more details, refer to the readme, FAQ, and existing issues.
If you can reproduce the error mentioned above, please provide detailed information and create an issue. It's recommended to test this on Google Colab if possible.
Thank you. The error seems to be non-reproducible, and it's not a package code issue, as I verified it directly on Mac OS.
Usually, a 404 error occurs in situations where the server was found, but it couldn't retrieve the requested page. Here are 5 ways to resolve 404 errors:

Restart your browser.
Clear cache and browsing data.
Double-check for any mistyped characters in the URL.
Try accessing the website from another device.
Use the Incognito window or private browsing mode.


Improved error handling and added type hinting in Experiment

Description

Improved error handling by raising TypeError when a str is passed to Experiment instead of list of strings
Added type hinting for better readability.

Fixes #3623
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Hi @agriyakhetarpal I have updated the docstrings. Do you have any other suggestions?

Looks good to me, no other suggestions!

@all-contributors please add @AbhishekChaudharii for code and docs


Scripted policies for handle envs

Also will saying the v1 policy is 100% accurate be an issue with Travis later on?


Fix Operation.swift Operation addDependency bug

In this commit, I only fixed the addDependency bug.  However, there is a critical bug https://bugs.swift.org/browse/SR-11333, exists from swift5.0 (I didn't check swift version < 5.0).
I created a test case for OperationQueue and Operation which testing the dependency.

I really hope some guys could fix the Operation & OperationQueue dependency bug. Everything works fine on the Darwin platform. As the Operation.swift changes so much between swift-5.0 and the current master branch. I guess the Foundation team may have a new design for Operation&OperationQueue and everything is in progress.

@millenomi The test case failed as I only fixed the addDependency. For the dependency login in OperationQueue there is still a bug here which I haven't fixed. You can take a look at SR-11333.

@swift-ci please test

@millenomi I updated the test case to only handle the addDependency method. According to [SR-11333] (https://bugs.swift.org/browse/SR-11333), is that properly I could work and fix that? However, I am not sure if the foundation team there has already got a plan and overall design for Operation & OperationQueue. Looking forward to get how do you think this.


Extra header files for non-compulsory data

The current proposed structure contains file header.yaml alongside compulsory files offsets.uint64 and positions.3.float16.
Whenever additional data are generated and added to the dataset (e.g. let's use the mean FA along each streamline: dps/mean_fa.float32). One may wish to store additional information related to how that image was generated, what FA image was used, etc.. I think that in such cases, optionally storing an additional file dps/mean_fa.yaml makes most sense, i.e.. changing the file extension only, as is done with JSON files in BIDS. It's worth having this explained and demonstrated in the specification.

Oh I like this idea. But now, we will likely need a list of reserved tag for this too 😅
Do you have use case in mind for this?
I can think of "unit", "scaling", "lookup_table"

But now, we will likely need a list of reserved tags for this too

Very much so. This is precisely the sort of thing that we need to do for the introduction of DWI models into BIDS Derivatives (here, though I've neglected it for quite some time...), and that logic was always going to need to be extended to tractography data, it just looks like that's more likely to happen here rather than in the BIDS space. Though I would probably nevertheless advocate for a BIDS style, i.e. CamelCase variable names, as I would for the primary header file as well.

However, out of pure curiosity: Do you think that in mrtrix (for example) you would try to 'conserve' this information in the file?
For example, if you subsample a TRX from 1M streamlines to 100k, would the output file keep these?

Things start to get very "fun" in the implementation here, especially with MRtrix3's multi-threaded piping construction. Not looking forward to coding it...
Ideally you'd want any header fields that remain relevant to remain in place, and anything invalidated by the operation to be wiped or invalidated. There's a few places where I pull various gymnastics about what header fields should or should not be retained following any particular operation, but it's a lot of effort to automate and get right every time.

Personally, the metadata dpv/dps/dpg is very important to keep and follow along in the processing, but this is a bit too optional and could add complexity to reader/writer. I know this has nothing to do with specifications and would be an implementation decision. But I am curious about how you would personally handle such information.

Will probably create a new MRtrix3 issue (separate to MRtrix3/mrtrix3#411) specifically to discuss how to deal with the prospects of this format within our code, as it'll likely be quite different to others. But it's nevertheless worthwhile going through these use cases; e.g. "subsampling a TRX from 1M to 100k streamlines" would be more efficiently handled by defining either a streamline group or a bitwise DPS to define that selection and interface with that, rather than producing a new TRX. In the latter case though, yes, ideally you would want all associated DPV / DPS data to be correspondingly selected and written to output, which requires internal handling of such; this already happens with SIFT2 weights using dedicated code, but TRX necessitates something more general.


Syntax for environment variable in link target

I have been trying to use an environment variable in a link target for a while now and I can't figure it out:
From the README:

Environment variables in paths are automatically expanded.

Is it only true for the path extended configuration parameter?
If not how do I make this work:
# install.conf.yaml

- link:
    $ZSH_CUSTOM/aliases.zsh:
      path: zsh/aliases
      force: true

$ZSH_CUSTOM is set, but it appears it is not resolved:
Linking failed ($ZSH_CUSTOM/aliases.zsh) -> /home/usr/projects/dotfiles/zsh/aliases

The environment variable is expanded in both the source and destination.
Maybe something else is wrong? Have you exported $ZSH_CUSTOM?

I can't reproduce my issue anymore so I guess it was not related to the project. I don't know what I did wrong.
Sorry for taking your time.


Reuse some temporaries

AFAIK we only need an additional V, H and Q. Better just put them in a struct as well.

Closed via #81


bump dcos-net for fix for docker services in bridge/container mode

High-level description
In case of docker containerizer if the backend to a VIP is the
actual container ip then the application running in the container
cannot access its own VIP. The only way to make it work is to go
through port mapping. This patch fixes the port mapping such that
the backend is the host IP:port intead of container ip:port
jira: DCOS-45115
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_45115 COPS-4087: Docker container unable to curl its own VIP

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): https://github.com/dcos/dcos-net/compare/ed7e4e5d7c29fa74eb72ed52f685e31c2756dac9...221c50e1e27f1dc5ddbcc1e08bc57f0a29fcd22e
[x] Test Results: https://circleci.com/gh/dcos/dcos-net/767
[x] Code Coverage https://codecov.io/gh/dcos/dcos-net/pull/103

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot bump-ee

@GoelDeepak could you please rebase and resolve the conflicts?

I resolved the merge conflict in readme. and let's merge this.

@mesosphere-mergebot bump-ee


Wpackagist support?

Hi,
At the moment we use satis to create private packagist. we also grab a lot of packages from wpackagist.org (wordpress plugins / themes).
Is there a way to add these wordpress packages to repman?

Not yet, but this idea is already on our backlog. Thanks for your feedback, more submissions like this will put this task higher on the priority list :wink:

Not yet, but this idea is already on our backlog. Thanks for your feedback, more submissions like this will put this task higher on the priority list :wink:

I would also like to add a sumission for this feature.
It is good to be able to use repman to contain some packages from packagist and wpackagist to use often.

I would like to have this feature too!


adds size to aggregations query

Codecov Report

Merging #28 into master will increase coverage by 0.68%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   60.82%   61.51%   +0.68%
==========================================
  Files          34       34
  Lines         531      543      +12
  Branches       46       47       +1
==========================================
+ Hits          323      334      +11
  Misses        201      201
- Partials        7        8       +1

Impacted Files
Coverage Δ

...lasticsearch-app/src/config/collections/harvard.ts
100% <ø> (ø)
:arrow_up:

...y-elasticsearch-app/src/config/collections/hsp2.ts
100% <ø> (ø)
:arrow_up:

...ery-elasticsearch-app/src/config/collections/ox.ts
100% <ø> (ø)
:arrow_up:

...-elasticsearch-app/src/components/DiscoveryApp.tsx
93.33% <ø> (ø)
:arrow_up:

...y-elasticsearch-app/src/components/ListFilters.tsx
94.28% <93.33%> (-1.37%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c962d12...bc786ff. Read the comment docs.


Update query options docs

Add more sample code for combined query options

Docs Build status updates of commit 8f7d181:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/client/v6/query-options.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


list-detail issue.

i made list.
if i clicked item then detail view was showed.
i was clicked back button on android.
the list shows always first item.
how can i?

Greetings!
My sensors indicate a reply was requested over 30 days ago.
Since we have not received a reply, the issue is being closed. If you are still experiencing this issue,
please feel free to reopen it and include any information that may have been requested.
Thank you!


fix: only update changed column

What kind of change does this PR introduce?
Bugfix, feature, docs update, ...
Fixes https://github.com/supabase/supabase/issues/5718
What is the current behavior?
Updating a cell also updates the whole row which causes an error when updating a row containing generated values that can't be manually updated.

cc @phamhieu

Can you review this, please @phamhiem. Let me know if it needs changes.

Thank you  @phamhieu.


API enhancement : upload a new document in a workspace

Hello everyone,
This issue follows a discussion in the community forum : https://community.getgrist.com/t/new-api-feature-request-post-grist-file/3042/2
At now the Grist API allows to download a document in its grist format (sqlite) : GET /{docId}/download
We would also like to be able to POST a new grist document in a workspace.
Our use case : we have a template file (with specific views, access rules etc) that we want to use as a base file when we create a new document.
As suggested by @paulfitz, a trail that may be followed could be the completion of the POST /api/docs endpoint to allow a workspaceId as parameter to create a regular document, as described in the TODO comment.
https://github.com/gristlabs/grist-core/blob/1774d0314fd33d8a97151f428249398878a17c0e/app/server/lib/DocApi.ts#L1170-L1192

Do this small changes would be enough ?
+      let workspaceId: number|null;
       let parameters: {[key: string]: any};
       if (req.is('multipart/form-data')) {
         const formResult = await handleOptionalUpload(req, res);
@@ -1199,18 +1200,19 @@ export class DocWorkerApi {
       } else {
         parameters = req.body;
       }
-      if (parameters.workspaceId) { throw new Error('workspaceId not supported'); }
+      workspaceId = parameters.workspaceId || null;
       const browserSettings: BrowserSettings = {};
       if (parameters.timezone) { browserSettings.timezone = parameters.timezone; }
       browserSettings.locale = localeFromRequest(req);
       if (uploadId !== undefined) {
-        const result = await this._docManager.importDocToWorkspace(userId, uploadId, null,
+        const result = await this._docManager.importDocToWorkspace(userId, uploadId, workspaceId,
                                                                    browserSettings);
       }

@xadorfr a fleshed-out version of this change landed in https://github.com/gristlabs/grist-core/pull/655 and should now be in the latest docker image.

That's very good news ! Thanks a lot for this quick improvement, this is very appreciated !


Implemented, documented, and tested remaining min. domination sets

Description
I added documentation for undocumented domination methods, fixed two incorrectly implemented methods (locating and paired), and added testing for four untested methods.
As of now, compute(     ::Type{MinimumLocatingDominatingSet},     g::SimpleGraph{T};     optimizer=HiGHS.Optimizer ) where T <: Integer uses a brute force implementation. My MIP formulation does not seem scalable; although there is probably a better formulation.
Note: In domination_numbers.jl I maintained the choice of output of the previously implemented methods---Instead of returning an AbstractOptimalCardinality the methods simply return an integer.
Documentation and Style

[X] I have added docstrings to any new functions or types, as applicable.
[X] My code follows the project's coding style and guidelines.
[X] If you have added a new algorithm or function, you have also included corresponding unit tests.
[X] I confirm that any code added is my own work and is not copied from other sources.
[X] I have requested a review from at least one other contributor.

Developer's Declaration:
By submitting this Pull Request, I confirm the following:

[X] The code I am submitting is my own work and I have the rights to use and distribute it.
[X] I confirm that the code I have added is not copied from other sources and that I have appropriately cited or acknowledged any external code or references used.
[X] I understand that my code will be reviewed and any changes requested must be addressed.

PR Type
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[X] Documentation content changes
[X] Unit Testing
[ ] Other... Please describe:

Any updates on the error?

I haven't been able to figure this one out @RandyRDavila


Just FYI regarding requestbodyvar

There's already a module that does that: https://caddyserver.com/docs/modules/http.handlers.json_parse
There may be some differences though.

@francislavoie Thank you for the useful information! I wouldn't have implemented requestbodyvar if I had known this module.
That being said, I think https://github.com/tidwall/gjson (used by requestbodyvar) is more powerful ;)

@francislavoie Thank you for the useful information! I wouldn't have implemented requestbodyvar if I had known this module.
That being said, I think https://github.com/tidwall/gjson (used by requestbodyvar) is more powerful ;)


feat(ic-asset): configurable dot-directories and -files inclusion

Description
Closes https://dfinity.atlassian.net/browse/SDK-592.
include all hidden files
[
    { "match": ".*", "ignore": false }
]

include all non-dotfiles from .well-known directory
[
    { "match": ".well-known", "ignore": false }
]

include all non-dotfiles from .well-known directory + a specific dotfile from that dir
/.ic-assets.json
[
    { "match": ".well-known", "ignore": false }
]

/.well-known/.ic-assets.json
[
    { "match": ".dotfile", "ignore": false }
]

How Has This Been Tested?
Unit tested sync::gather_asset_descriptors, see: https://github.com/dfinity/agent-rs/blob/f8515d1d0825b47c8048f5528ac3b65018065779/ic-asset/src/sync.rs#L145
Checklist:

[x] The title of this PR complies with Conventional Commits.
[x] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation.

please advise on this Windows-specific error:

error - https://github.com/dfinity/agent-rs/runs/7322654802?check_suite_focus=true
source - https://github.com/dfinity/agent-rs/blob/SDK-592-configurable-hidden-directories-files-inclusion-when-uploading-assets/ic-asset/src/sync.rs#L372

do you think it's ok to put it behind #[cfg(target_family = "unix")]?


docs: audits and updates the KEYS command doc

Resolves issue https://github.com/DiceDB/dice/issues/843
Audits and Changes:

[x] Change the CLI prompt to <IP_ADDRESS>:7379>
[x] Markdown table for "parameters" and "return" values.
[x] Run and check if the examples are working as expected.
[x] Run and check if the examples give same output in redis.
[x] Remove the conclusion in the end.

Other issues found during auditing:

https://github.com/DiceDB/dice/issues/851

@JyotinderSingh @arpitbbhayani  Can you allow approval for the CI workflows?

@apoorvyadav1111 Let me know what else do you wish me to add.

I have addressed the issues. Please take a look at it again.


Poll: refactor to use template strings

This refactors chat-plugins/poll.js to use template strings as opposed to string concatenation to construct the data it sends to a room.

Looks good! Thanks!


[Minor] Optimize ShuffleServerInfo#hashCode

What changes were proposed in this pull request?

Optimize ShuffleServerInfo#hashCode
Why are the changes needed?

For better performence.
Does this PR introduce any user-facing change?

No
How was this patch tested?

No need

Codecov Report

Merging #538 (fabd253) into master (ebbe2db) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #538      +/-   ##
============================================
- Coverage     60.21%   59.81%   -0.40%
+ Complexity     1784     1564     -220
============================================
  Files           205      183      -22
  Lines         11557     9725    -1832
  Branches       1042      883     -159
============================================
- Hits           6959     5817    -1142
+ Misses         4190     3543     -647
+ Partials        408      365      -43

Impacted Files
Coverage Δ

...a/org/apache/uniffle/common/ShuffleServerInfo.java
75.00% <100.00%> (ø)

.../java/org/apache/uniffle/server/ShuffleServer.java
60.95% <0.00%> (-3.43%)
:arrow_down:

...storage/handler/impl/DataSkippableReadHandler.java
83.78% <0.00%> (-2.71%)
:arrow_down:

.../apache/uniffle/coordinator/ClientConfManager.java
91.54% <0.00%> (-1.41%)
:arrow_down:

...y/kubernetes/operator/pkg/webhook/inspector/rss.go
47.70% <0.00%> (ø)

...inator/access/checker/AccessCandidatesChecker.java
85.50% <0.00%> (ø)

.../hadoop/mapreduce/task/reduce/RssEventFetcher.java

...org/apache/spark/shuffle/writer/AddBlockEvent.java

...preduce/task/reduce/RssRemoteMergeManagerImpl.java

...mapreduce/task/reduce/RssInMemoryRemoteMerger.java

... and 19 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Support for React 0.72

Hello, React Native 0.72 now uses Gradle 8.0, which changed classifier with archiveClassifier. I can't build my App anymore with the package.
https://github.com/mpiannucci/react-native-context-menu-view/pull/87

Merged. Will test more fromally with my existing stuff soon

Is there an alpha release or something to test it? Thanks in advance <3

Pushlied now in version 1.10.0


[SPARK-26887][SQL][PYTHON] Create datetime.date directly instead of creating datetime64[ns] as intermediate data.

What changes were proposed in this pull request?
Currently DataFrame.toPandas() with arrow enabled or ArrowStreamPandasSerializer for pandas UDF with pyarrow<0.12 creates datetime64[ns] type series as intermediate data and then convert to datetime.date series, but the intermediate datetime64[ns] might cause an overflow even if the date is valid.
>>> import datetime
>>>
>>> t = [datetime.date(2262, 4, 12), datetime.date(2263, 4, 12)]
>>>
>>> df = spark.createDataFrame(t, 'date')
>>> df.show()
+----------+
|     value|
+----------+
|2262-04-12|
|2263-04-12|
+----------+

>>>
>>> spark.conf.set("spark.sql.execution.arrow.enabled", "true")
>>>
>>> df.toPandas()
        value
0  1677-09-21
1  1678-09-21

We should avoid creating such intermediate data and create datetime.date series directly instead.
How was this patch tested?
Modified some tests to include the date which overflow caused by the intermediate conversion.
Run tests with pyarrow 0.8, 0.10, 0.11, 0.12 in my local environment.

cc @BryanCutler @HyukjinKwon @gatorsmile @sadikovi

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7969/
Test PASSed.

Test build #102383 has started for PR 23795 at commit 8ac7925.

Test build #102383 has finished for PR 23795 at commit 8ac7925.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102383/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8020/
Test PASSed.

Test build #102441 has started for PR 23795 at commit b93b500.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8021/
Test PASSed.

Test build #102442 has started for PR 23795 at commit cca2634.

I'm merging this. Last commits were just about fixing comments. PEP8 check is already passed.

Merged to master.

Test build #102441 has finished for PR 23795 at commit b93b500.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102441/
Test PASSed.

Test build #102442 has finished for PR 23795 at commit cca2634.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102442/
Test PASSed.


fix(deps): update gomod

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/vpc-go-sdk
require
minor
v0.46.0 -> v0.47.0

github.com/hashicorp/terraform-json
require
minor
v0.18.0 -> v0.20.0

golang.org/x/crypto
require
minor
v0.16.0 -> v0.17.0

Release Notes

IBM/vpc-go-sdk (github.com/IBM/vpc-go-sdk)
v0.47.0
Compare Source
NEW FEATURES

Support for virtual network interface in select regions and accounts
Support for Advertise in RoutePrototype, CreateVPCRoutingTableRouteOptions,
Support for AdvertiseRoutesTo in RoutingTable, DefaultRoutingTable,
Support for Subnet in FloatingIPTarget
Support for crn in FloatingIPTargetPrototype, FloatingIPTargetPatch
Support for PrimaryIP, Subnet in FlowLogCollectorTarget

BREAKING CHANGES

Introduction of BareMetalServerPrototype in CreateBareMetalServerOptions
Removal of Datapath from CreateLoadBalancerOptions
Required ConnectionLimit on LoadBalancerListener

CHANGES

api version 2023-12-19

BUG FIXES

None

hashicorp/terraform-json (github.com/hashicorp/terraform-json)
v0.20.0
Compare Source
ENHANCEMENTS:

Add ReplacePaths to Change struct by @sebasslash in https://github.com/hashicorp/terraform-json/pull/117

Full Changelog: https://github.com/hashicorp/terraform-json/compare/v0.19.0...v0.20.0
v0.19.0
Compare Source
ENHANCEMENTS:

Add UseJSONNumber field and UseJSONNumber() method to Plan to allow use of json.Number for numerical values by @bendbennett in https://github.com/hashicorp/terraform-json/pull/113

INTERNAL:

github: Disable dependabot for GHA by @radeksimko in https://github.com/hashicorp/terraform-json/pull/114
build(deps): Bump workflows to latest trusted versions by @hashicorp-tsccr in https://github.com/hashicorp/terraform-json/pull/115
build(deps): Bump workflows to latest trusted versions by @hashicorp-tsccr in https://github.com/hashicorp/terraform-json/pull/116

New Contributors

@bendbennett made their first contribution in https://github.com/hashicorp/terraform-json/pull/113

Full Changelog: https://github.com/hashicorp/terraform-json/compare/v0.18.0...v0.19.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.26.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Drawing Inconsistencies in DirectMode / Render Manager

Problem:
Lighting is inconsistent, fails, or drawing fails in Direct Mode
Package - Replicated in both Unity 5.3.5f1 and Unity 5.3.4f1, using the sample packges
OS Name	 - Microsoft Windows 10 Pro
Processor - AMD FX(tm)-9370 Eight-Core Processor, 4400 Mhz, 4 Core(s), 8 Logical Processor(s)
Video Card - AMD Radeon (TM) R9 380 Series
Steps to Reproduce:
Create a scene.  Add a skybox, some primitives, some lighting.
Problem 1
Lighting is inconsistent in all scenes

In extended view, your HDK will see exactly what you see on the screen.
In direct mode, your HDK sees a very different image in terms of lighting, artifacts, shadows, reflections and where lighting comes in from the scene.

Problem 2
In some cases (the same project) the shadows and darks fail to render properly in Direct Mode, and are created using what seems to be 256 colours instead of the full spectrum.  This problem is not reproducible in Extended Mode.
Notes
I've split the HDM rendering black issue to https://github.com/OSVR/OSVR-Unity/issues/165
Happy to test anything, anytime.
Thank you

I see two issues now that I've looked closer!  Going to split the second one off to a new issue and upload a sample project :)

Can you share what lighting/quality settings you use? I'm not seeing differences in a basic scene or palace with varying quality/lighting settings, but I may be missing something. @russell-taylor any idea on color differences between extended and direct mode?

Could be sRGB vs. not in the two rendering paths.

Tried again to reproduce but no luck. @RedIronLabs the difference between our setup is that I am on an NVIDIA card and Intel i-7. Not sure if that could be the issue here. Do you have a rig with NVIDIA? I don't have access to an AMD machine with direct mode support.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

We only have the one machine that is compatible with direct mode. Our Razer rep reported the same issue back when this was opened during their testing for E3 though (and he would have been using nvidia I imagine).
I was able to replicate the issues using just the demo scenes.
We have to stop actively building with OSVR due to the lighting issues (the black screen issue, and this issue) and at the recommendation on gitter not to use OSVR for Vive, Rift or Leap Motion. We will be building with it again (to see if it's stabilized) when we are ready for release.
I'll take a look at this again prior to release (just not sure when). Thank you for trying and looking at it.

@RedIronLabs which HDK were you seeing this with? Did Razer see both of these problems? I see problem#2 with dark colors on the HDK2, which could be what Razer was seeing during E3 testing. This issue is not present on HDK 1.x.
Also, can you clarify what you mean by "extended mode"? This could mean using RenderManager with directModeEnabled=false, or not using RenderManager at all.
Still not able to reproduce Problem#1 in either case, thinking it may be an AMD thing and that Razer was only seeing Problem #2 on HDK2.


docs(caching) : Update broken links

Updated 3 broken links with hash routes that were not pointing on the right section of the page

[X] Read and sign the CLA. PRs that haven't signed it won't be accepted.
[X] Make sure your PR complies with the writer's guide.
[X] Review the diff carefully as sometimes this can reveal issues.

@EugeneHlushko You think this is needed for other pages?

@melbarch please sign the CLA.

I'm not sure what is the problem, I have already signed the CLA the moment i created the PR!
the cla page says : You have signed the CLA for webpack/webpack.js.org
Is there another step to take on my side? or another way to redo it?

Thanks!


Change color of point cloud

References #25

[ ] Read in color value from color picker widget
[ ] Change point cloud to match selected color
[ ] Manually test functionality
[ ] Add automated testing to the extent possible

Changing transfer function colors is not natively supported by the ipyvolume API, so I researched potential solutions, and implemented a comparable functionality of changing the graph background color.
[t:135]


Publish datapoint operation

Close #16

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 39 (0.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.1%) to 32.171%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/commands.rs
0
1
0.0%

core/src/main.rs
0
1
0.0%

core/src/oracle_state.rs
0
2
0.0%

core/src/state.rs
0
2
0.0%

core/src/actions.rs
0
4
0.0%

core/src/commands/publish_data_point.rs
0
29
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-1.1%

Covered Lines:
369

Relevant Lines:
1147

💛  - Coveralls

I think I've covered all the requirements for this. A summary of what I've done:

Implement publish datapoint which makes a call to external script, scraping datapoint from stdout.
Use clap library for handling args
Remove connectors/ directory and POST API for oracle-core

I've addressed your comments.

Looking good! Great job! Oracle pool has quite complex logic, I spent a lot of time wrapping my head around it. Please check my comments.

Yeah I'm learning a lot here. It's cool to see how the rust code connects with the contracts.


luci-app-olsr: port to js

This is a request to have luci-app-olsr ported to javascript.  The status pages, in particular, would benefit greatly from client-side rendering.

https://github.com/Freifunk-Spalter/packages/issues/12

Is anyone working on it? Because I have just started.


Dockerfile (s)

Dockerfile you may wish to change the ports on (80:*)); listens on <IP_ADDRESS>
env variable to supress openBrowser
"start:production:docker" as launch task, to allow differentiation
Added a few lines to README.md

@jmsherry Why need a duplicated server.js?

@wellyshen I've never done a pull req before, so sorry if I've done something wrong!
The diff between your server.js and mine is that I put an if statement around the openBrowser, because you don't want to open a browser inside a container.

@jmsherry Your server.js path is ./server.js, why don't leverage the ./src/server.js?

Yeah, I've done something wrong with the PR. I did use your ./src/server.js.  I've not created a new file... I'll try and figure out how to do it. :(

@jmsherry
OK, I see.
If the docker part can be tested by travis CI? I want to ensure it works fine if I upgrade dependencies or do some code refinement in the future.
BTW, free feel to close this PR and send me a new PR when you adjust the location of the server.js file.

Sure. I'm working on a crazy project atm, so I'll get to it as soon as I can...
Docker doesn't work like that. Docker is basically a shell level daemon. It's like a VM. With Travis you can build container; launch it and then SSH into it to run tests, but you don't test it itself.
I'll close the PR and try and make another one ASAP.

@all-contributors please add @jmsherry  for infra


Refactoring UpdateScope, VersionDetails and related classes

The goal of this exercise is to simply VersionDetails and related classes. I've noticed that a lot of logic related to version management is spread across multiple classes. In particular, UpdateScope which is supposed to be a simple enum-like class and a container for the segment, has grown to some utility class with code duplication. Cleaned that up.
The ultimate goal is to replace version management helpers with JSR330 components, also to split VersionComparator classes from their utility part (segment manipulation) -- but that's for another PR. I want to keep the scope small so that it doesn't become another gargantuan PR to review :laughing:
Please note: until #701 is merged in, there are two commits, then I'll merge and squash.

somehow i cant make my ide checkout the pr, i think it will be easier for both of us if you can merge your PR first, then i'll have a nice branch to checkout and merge on my side. would it be ok for you ?


Feature interfaces

Hi, I added a new function that takes []*interface{} as input and extracts the string from it with fmt.Sprint() function.
I added val *interface{} to match struct, it returns nil if you are searching for a string, but on the other hand, if you are searching for *interface{} it will return the actual value.

@sahilm I don't know why CI has failed but I tested and all tests passed.

Thanks for the pull request.
I'm not clear why this is needed? The provided Source interface https://github.com/sahilm/fuzzy/blob/eaa29a3062e4b58bead472d25ca4b558e2d53d45/fuzzy.go#L47-L51 should allow you to match anything.
Can you explain the use case for this?

Thanks for the review @sahilm It was too late when I was implementing this and I totally missed the Index value of the Match struct, which is more than enough for my needs. It all started when I wanted to return actual Value from Match.
// Match represents a matched string.
type Match struct {
	// The matched string.
	Str string
	// The index of the matched string in the supplied slice.
	Index int
	// The indexes of matched characters. Useful for highlighting matches.
	MatchedIndexes []int
	// Score used to rank matches
	Score int
}

This PR would allow anyone to use Find method without implementing the Source interface. Today with a fresh mind I can clearly see that it is not required.
Sorry to bother you. 👍


transpile ansatz and pauli-lists separately in VQE

Summary
A parameterized circuit of ansatz is transpiled once in VQE
Details and comments
A parameterized circuit of ansatz is copied to multiple circuits in OpFlow and they are transpiled though they share the same ansatz.
This PR transpiles ansatz and puli-lists separately and generates multiple circuits by combining them.

[x] transpile ansatz
[x] extract qubit-mapping from transpiled ansatz
[x] transpile pauli-lists with extracted qubit-mapping
[x] merge transpled ansatz and pauli-lists

This issue will resolve a part of #6432.

Couldn't we just solve this issue by transpiling the circuit before calling expectation.convert in the VQE?

Couldn't we just solve this issue by transpiling the circuit before calling expectation.convert in the VQE (and then maybe skipping the transpilation in the circuit sampler)?

f4aec15 does so. But it is not correct if coupling_map is specified and the final mapping is different in transpile.

What if we pre-transpile but then still transpile again in the circuit sampler? Since we already did most the optimizations that should be pretty fast, no?
I'm not sure the steps you outlined above are the right approach. This scenario of ansatz + Pauli expectations is very common and we should improve the transpilation in general, not only within the VQE. What about making PauliExpectation.convert return a special type of ListOp where the CircuitSampler knows how to efficiently transpile it?

I guess going forwards this can be related to #6451
In the short term, the transpile is a one time thing right for all the circuits. For each eval they are then set with parameters and executed. So this is really speeding up their creation. And of course with include_custom things work faster as there is just the one ansatz circuit for the expectation.

Thanks for checking the runtimes @hhorii! I agree this is quite a strong speedup and we should definitely allow to only transpile once. To keep the old behavior available, should we add a flag that allows to keep the old behavior (e.g. if you run on real HW you might want to transpile twice)?

@Cryoris Thanks. This approach is to compile ansatz circuit only once, instead of N times when N Pauli are given.

How do you know the common circuit is the right-hand side state in the composed op? What if you have multiple composed ops?

In terms of OpFlow's design, ansatz is contained in StateFn on the right side, and information about observables is contained in MeasurementFn (=~StateFn) on the left side. Also, it is not possible to create or evaluate a ComposedOp with more than three StateFn.

Couldn't we just transpile the circuit in VQE and not transpile it again in the circuit sampler? Then we wouldn't have to change a lot (or maybe nothing at all) in the Circuit Sampler.

It is my understanding that the CircuitSampler should be responsible for transpiling quantum circuits, not the VQE.
It might be a good idea to create a class that is responsible for transpiling, such as CircuitTranspiler as a Opflow Converter.

Is this PR mergeable?
I've made both, and personally it's better to have the transpile closed in CircuitSampler. But this is a performance issue that needs to be included in the next release (0.18.0). So if committers really wants to transpile on the VQE side, I will complete #6602 asap.

@Qiskit/terra-core  Is this PR mergeable?
I've made both, and personally it's better to have the transpile closed in CircuitSampler. But this is a performance issue that needs to be included in the next release (0.18.0). So if committers really wants to transpile on the VQE side, I will complete #6602 asap.

@Cryoris you had comments against this approach to start with - can you respond to the above please.

I think this solution is nice because it is common and not specific to VQE, but it points to a deficiency in the software architecture. This code has to reverse-engineer a circuit to figure out what the ansatz is, transpile that, and then glue it back.
I think we should refactor the code a bit to make this nicer. In particular, I think the common task we want to perform here is to calculate expectation values of a circuit with respect to some operator(s). We should have a canonical way of doing this in Qiskit, which we can then optimize to be fast at transpiling etc. The algorithms (VQE, QAOA, etc.) should be refactored to use this expval interface.
I think @Cryoris has some ideas on how to implement this, so let's hold off on merging this until the new expval architecture emerges.

@ajavadia Thank you so much.
This assumption (what is ansatz, what is measurement) is natural in the opflow, for example:
https://github.com/Qiskit/qiskit-terra/blob/main/qiskit/opflow/expectations/pauli_expectation.py#L97-L98
So I thought this is enough.
However, I agree we need more refactoring here. CircuitSampler (especially cache structure) is too complicated. I think many caches should be in the operator itself (e.g. reduce()), and we should split translation and sampling like CircuitTranspiler (https://github.com/Qiskit/qiskit-terra/pull/6454#issuecomment-861922524). I thought this performance improvement is priority and I had to include it in this release, so I tried to force it in with minimal changes, but it's obviously better to refactor it in the long run. At that time, I hope that we will be able to easily take the final layout.
Then there's the unnecessary calculation of taking sqrt and squaring it in the current method. I think this unnecessary calculation should be removed. Also, we need an API that can take variance or standard error. With the existing CircuitSampler, I cannot create a method to use the SaveExpectationValueVariance to calculate variance https://github.com/Qiskit/qiskit-terra/issues/5743. I have tried to fix this by experiment class but I cannot do it in the current architecture.
Finally in my opinion, I thought it would be a better idea to make a major revision when the expectation value experiment class come in the future.

@ikkoham thanks these are all great points. Let's gather these requirements under #6451 and then design the interfaces.
What do you mean by the "expectation value experiment class"?
The issue with final_layout: is it related to https://github.com/Qiskit/qiskit-terra/issues/5350 and https://github.com/Qiskit/qiskit-terra/pull/5280?

@hhorii I think this can be closed right, given primitives will deal with aspects like this going forwards and VQE will be refactored to run using primitives.

Yes, this is the logic already applied on the qiskit-ibm-runtime side (precisely, server side), so we can close it. Thank you for pointing out.


Remove type casting that removed quantization information as part of …

…the TOSA legalizations

@rsuderman for review


Add CRD AuthorizationPolicy for authorization v2 API

This would eventually deprecate the current ServiceRoleBinding.
See more: https://docs.google.com/document/d/1diwa9oYVwmLtarXb-kfWPq-Ul3O2Ic3b8Y21Z3R8DzQ/edit#heading=h.x9snb54sjlu9

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: ayj, nmittler, sdake
If they are not already assigned, you can assign the PR to them by writing /assign @ayj @nmittler @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS
install/OWNERS
pilot/OWNERS
pkg/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
95190db0389e97d16381d5e578469c1d88d5d155
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This PR is ready for review, @rshriram @ozevren Could you review the change to Pilot and Galley. Thanks!

/lgtm
Galley changes lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ozevren, yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: nmittler, sdake
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren]
install/OWNERS
pilot/OWNERS
pkg/OWNERS [ozevren]
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren, rshriram, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ozevren,rshriram]
install/OWNERS [rshriram]
pilot/OWNERS [rshriram]
pkg/OWNERS [ozevren,rshriram]
tests/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-integ-k8s-tests

prow/e2e-simpleTests-cni.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test e2e-simpleTests-cni

prow/istio-pilot-multicluster-e2e.sh
c63f66dd586e3239b565b99779a82eb8e6f95066
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

For #12394


feat(restructure): Split up libraries

This should match better the standards they implement

:tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


deletion: true "crosses"?

I imagine that you intended a typical [x] icon to pop up when moused over (or normally) as a short cut to delete by clicking.  But I don't see any "crosses" in the GUI in Fx & Chrome Win7.

I do not see any crosses either.

4.3.1

Fixed; cheers!


The Parse of divide is incorrect ？

console.log(require('mathml-to-latex').convert(`<math><mi>x</mi><mo>=</mo><mn>4</mn><mrow><mo>/</mo></mrow><mn>5</mn></math>`))

got x=4//5

Yes, the divider operator was being converted to double bar as you described.
Thanks for the report.
Now fixed on PR #2.

Yes, the divider operator was being converted to double bar as you described.
Thanks for the report.
Now fixed on PR #2.


Add detached ElementAspect processing

Changes:

Add detached ElementAspect exporting.
Extract ElementAspect exporting from IModelExporter.
Add elementAspectExportStrategy option for IModelTransformer for choosing which ElementExporting strategy should be used during the transformation.
Add BigMap usage to aspect remap table to remove ~17 million ElementAspect limit in iModels.
Add ECSqlReaderAsyncIteratorAdapter for iTwinJs 3.x versions

Forgot to put as my review summary comment, there are some really great refactors in here! Thank you for working on this! Overall really good, but I have several nits and some small changes we can discuss.


fix: don't lose examples on properties

Fixes #714

@apupier #724 is the one for bean property

How conflicts again? Github, you're kidding me!


"Back" link should not require two clicks

Open a node that has children. Try to click the "<-- Previous Page" link at the top. It takes two clicks for the link click to trigger, but it should work with a single click.

This was fixed in PR 288: https://github.com/treehousedev/treehouse/pull/288


⚠ ClamAV has degraded performance

In 239dac1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 225 ms

Resolved: ClamAV performance has improved in 029f95f after 1 hour, 49 minutes.


Investigate Office Fabric controls

We did this. The office fabric controls are missing styling APIs that we would want to make them look and feel like current storage explorer.


[RFC] Add prisma script to package.json

Should we add prisma as a script to the package.json? On the one hand, this lets people easily use keystone-next prisma via yarn prisma, which makes it consistent with the other script. It also provides a safety net to ensure that the Prisma schema matches the keystone schema. One the other hand, this may cause unexpected behaviour for users who expect yarn prisma to run Prisma directly.
This PR also reorders the scripts to match what's written at https://next.keystonejs.com/guides/cli

I don't think we should add this script, because it blurs the line between explicit understanding of "I am running prisma through keystone" vs "I am running prisma directly" (which people generally should not, in Keystone projects, except in really advanced use cases)
The foot gun here is that you'd get that different behaviour based on the presence or absence of a script in package.json which is super undiscoverable
Add to that, you don't need to run the Prisma CLI at all really until you turn migrations on, which we're not doing for the base getting started use-case (this is a separate conversation we should have)
My last point: I'd be in favour of maybe a helper script like yarn deploy-migrations which ran something more specific like yarn keystone-next prisma migrations deploy but again migrations aren't on yet. Turning them on is a bit of a steep ramp right now but putting that in ahead of config is misleading for newcomers.


WIP: Add BPF NodePort CI tests

This change is

test-me-please

Coverage increased (+0.02%) to 43.983% when pulling 0eab9c0f87c2a6e117e68436cb8970160658b514 on pr/brb/node-port-test into 81dfcb918a8d41a5ad6a3f46c770a666a3e475cc on master.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please


Set version to 4.0.1 in all poms

The version tag in pom.xml is still not changed and makes no sense. So set it as the right version.

Fixes #97 .


Add Inventory Shield as easy

Added entry for Inventory Shield.
They don't have a direct link to the in-app account settings (yet), so this support article will have to do. I added notes that essentially mimic what the article says. Once logged in, the path to get to account deletion is very short.
Easy difficulty, since all users (with very few exceptions) are free to delete their account at will.

Thanks for your contribution!