git extensions: Improve gpg signing failure handling

Testing #153366
Repro:

Try commit something when gpg signing is setup on Windows
Cancel gpg signing dialog

Result:

The log shows:
[2022-06-28T14:49:14.708Z] > git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file - [4775ms]
[2022-06-28T14:49:14.708Z]
> husky - npm run -s precommit
> husky - node v16.15.1

npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
Reading git index versions...

gpg: signing failed: Operation cancelled
gpg: signing failed: Operation cancelled
error: gpg failed to sign the data
fatal: failed to write commit object

Can we detect the gpg related failure messages and provide a nicer message?

We sure can: https://github.com/microsoft/vscode/blob/5ab9f868e3fa3d573b0e44456afd34695af56978/extensions/git/src/git.ts#L1476-L1501

Merging into https://github.com/microsoft/vscode/issues/64409


"Add to Xcode" does not work when not installed as /Applications/Xcode.app

Add to Xcode not work when xcode version not directly download from AppStore，for example
xcode-select -p
/Applications/Xcode-14.0.0-Beta.4.app/Contents/Developer

Create a symbolic link for /Applications/Xcode.app
This should solve it. Please try

Thanks for your advice.But It not work

Ahh, might it be that you don't have a ~/Library/Developer/Xcode/UserData/CodeSnippets/ folder? I just noticed that CodeSnippets folder does not exist unless you created a user-defined code snippet once in the past. I don't create the folder but expect that the folder already exists....

thanks, now it's OK！
As you said, There is no such directory！

Thanks for conforming. I'll check if I can push a patch to create that directory when necessary.


implement Deserialize for Regex?

This is somewhat related to https://github.com/rust-lang/regex/issues/258
I am thinking about the following usecase: When I have a application where I can define regexes in a config file and the app reads the config on boot, I cannot use serde_derive with Regex:
#[derive(Deserialize)]
struct Config {
    something: Regex,
}

But it would be nice to have that possibility. What do you think? Or is there a boilerplate-free way around this I do not see right now?

@BurntSushi Oh thank you, finally someone did it and I don't have to reimplement wrapper each time myself :) (was being too lazy)

Using serde_regex might actually not be a great idea. A serialize-deserialize roundtrip will drop flags, as reported here: https://github.com/tailhook/serde-regex/issues/14. Which means after deserialization you can end up with a Regex that's semantically different from what you had before, which depending on your use case might cause all kinds of correctness bugs.
Skimming the API of the Regex type it doesn't seem to provide a way to retrieve the flags used to compile it, so there is not much serde_regex can do about this.


EACHEN WiFi Smart Touch Switch-L-RF-US is working

I want to confirm that the EACHEN WiFi Smart Touch Switch-L-RF-US (No neutral wire required) is supported.
https://ewelink.eachen.cc/product/eachen-single-live-wall-switch-us-ac-l123ewelink-app/

Please share it to my account<EMAIL_ADDRESS>

@tonyp740613 sorry, at first I thought you were asking for support. No need to share the device if it works :)

What version of firmware?

3.3.0
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Alex X<EMAIL_ADDRESS>Sent: Thursday, May 14, 2020 3:56:07 PM
To: AlexxIT/SonoffLAN<EMAIL_ADDRESS>Cc: tonyp740613<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [AlexxIT/SonoffLAN] EACHEN WiFi Smart Touch Switch-L-RF-US is working (#102)
What version of firmware?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/AlexxIT/SonoffLAN/issues/102#issuecomment-628653245, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APBNBVHZHIIB3PTJV6RFILLRRPZ7PANCNFSM4NAWAL2A.

So it has local connection?
Or you use latest stable release 1.10.4, which work only in local mode?

I am still running 1.10.3 of your software.  I checked in the ewelink app on android and the Eachen switches have the LAN control toggle so I assume it is using a local connection.
Can I check if it is using local mode by checking the .sonoff.json file?  Or must I update to 1.10.4?
From: Alex<EMAIL_ADDRESS>Sent: Thursday, 14 May 2020 4:13 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [AlexxIT/SonoffLAN] EACHEN WiFi Smart Touch Switch-L-RF-US is working (#102)
So it has local connection?
Or you use latest stable release 1.10.4, which work only in local mode?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/AlexxIT/SonoffLAN/issues/102#issuecomment-628664196, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APBNBVDJQISGV2RTURMUPZLRRP4CJANCNFSM4NAWAL2A.

Thanks. If you running 1.10 - it's local connection.


increase PI bitw from 4 to 5

The phase interpolation bit-width in the MDLL is increased from 4 to 5.
The jtag register and mdll_pkg parameter values are updated accordingly.

@bclim Thanks for this PR.  Would you mind merging in the latest changes from the master branch?

@sgherbst
I'll do it after the review.

@sjkim85 yet see the issue ?


Update deps in the daemon after CI

The task is to make an automated PR in the daemon repo to update deps.txt if the columnar commit passes tests. Exactly like it's done in the Buddy repo.

Here is the pull request: https://github.com/manticoresoftware/columnar/pull/33
Updated deps in manticoresearch: https://github.com/manticoresoftware/manticoresearch/pull/1449


Fix missing axis labels for categorized scatter with gruff

The block was not being passed down to plot_with_category method, therefore modifications to plot ( such as adding axis labels) were not showing for scatter with category when using gruff.

I added a test covering the change, sorry it took me so long..


sync amazon s3 bucket

Purpose
currently the amazon s3 command line tool is being used to sync the local directory with amazon s3 bucket. While this is very nice as it uses a prebuilt command line tool, it requires 2 applications to run. Consolidate syncing into some kind of awsSyncService inside of spreadsheet-updater. Perhaps it could even be a wrapper around the s3 process?
May be OBE
If #9 is realized, the s3 command line tool will be the only tooling needed on congregational computers.

OBE - congregations will be responsible for uploading their mp3 files to amazon S3. Once there they will get picked up.


core: Command queue optimization for read-only workloads

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwdV1sM5KEK2L14K/recRoc1FYLw7XFAIG
PRs: None yet

@tschottdorf, we may want to include details about this in conceptual documentation, so once the work is done, please assign the ready label and add relevant PR links.

@jseldess This is pretty low-level. I don't think there is any documentation work to be done here.

OK, thanks, @petermattis.


chore(master): release 0.12.0

:robot: I have created a release beep boop
0.12.0 (2024-06-03)
Features

updating from newer svd2rust (#85) (77dafc2)

Bug Fixes

deps: reverting cortex-m-rt to 0.7.3 due to yanking (e32b494)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/xmc-rs/xmc4300/releases/tag/v0.12.0 :sunflower:


[zh] Add basic cron syntax in documentation

sync from https://github.com/kubernetes/website/pull/25078

/lgtm
/approve


Updates map.js to pass along the options hash to addMarker

This PR depends on my PR to map-canvas, found here

Thanks @bryanashley!
I have written you the details in the other thread. For everyone reference you can now do this:
 map.addMarker({"lon" : "37.5000", "lat" : "-79.0000", color: "red", char: "X" })

Awesome, thanks for this!


Add Spark security note to README

Description of changes:
Explains how the solution addresses CVE-2018-17190
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @dscpinheiro for your input and contribution.


ign -> gz Header Migration : gz-sensors

See https://github.com/ignition-tooling/release-tools/issues/711

@osrf-jenkins run tests please!

@osrf-jenkins run tests please!

@osrf-jenkins run tests please!

@osrf-jenkins run tests please!

@osrf-jenkins run tests please!

@osrf-jenkins run tests please!


Modified motion file resulting in world.env.check_valid_episode() returning False at each update

I was trying to run some experiments of my own. I took two motion files - humanoid3d_kick.txt and humanoid3d_punch.txt and concatenated them for a quick test. I ran the resulting mocap clip, and it ran as expected (initial kick action followed by punch action). No particular issues that I could identify.
I then tried to train using this new motion file (made sure had a corresponding file in args). But I got only an infinite loop of -

Agent 0
Samples: 0

That corresponds to the _train() function in rl_agent.py, right before -
if (self._total_sample_count >= self.init_samples):
So, the above if condition doesn't turn True at any point. After some digging, it seems like the  world.env.check_valid_episode() call in the update_world function in DeepMimic.py is returning False for every substep.
And I am currently unsure why that would be, because the valid episode check leads to DeepMimicCore which is a bit beyond my current understanding.
Any insights on why such an approach might not be working? Or is there anything else I need to modify for a custom motion file like the one I mentioned above to work?

The invalid episode flag is raised whenever the simulation blows up. Your concatenation of multiple reference motions might be causing the simulation to blow it when it's initialized to the transition between the two motions. Since there is probably a sudden change in the pose between the two motions, which can result in a large velocity that could cause the sim to blow up. But this should only happen when initializing the character to the timestep between the two motions, which should be quite rare. So it's strange that it will be returning valid episode at every transition. You probably need to dig into the code a bit more to see what causes the invalid episode.

This is helpful. Thanks!
I will first try to create a smoother blend of the two motions or try out different combinations as well which might allow for that sudden change. Will start digging through the code based on that. I tried to trace the issue but then reached the C++ code and that was a bit beyond my current level of understanding.
Will update if I find something. Thanks again.

Most likely found the problem source based on your reply.
As per the mocap data format, the first value for each frame is the duration of frame in seconds (1D)
At the end of each motion, the duration of the frame is set to 0.000000. A simple, direct concatenation causes that to appear twice, because of each motion.
Removing that particular frame for the first motion seems to be resulting in the training moving forward as expected. I will close this for now since the original issue is resolved.

Good catch, glad you figured it out!


Add Runme button to demonstrate the latest version of application

This PR adds Runme button-label  (clickable) to run the project from latest commit with one click.
How it works:

Runme clones the repository and builds a docker image for latest commit or use already built docker image;
deploys the docker image to k8s cluster;
creates domain with SSL certificate;
shows web application;
destroys app instance after 10 minutes.

You can find detailed information how this works here. The small demo you can find here.
Why do you need this?

Runme is perfect solution to demonstrate current state of code/repository, anybody can just click the button and see the state;
Runme totally free, we love open source projects and want to support them;
Runme can be used as a tool for preparation docker images with a developer's version of code

Screenshots
build

result

Hey @velp,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: d6bed640-a0e4-11ea-8dbc-21d9b9d6c42b

@velp runme sounds cool! Great work on building the platform.
But I wonder what difference does it make for debugging. If you're building from latest commit, production and runme instance will be exactly similar right?
It does allow me to pull image from Docker and get hold on to an online deployed image - that's awesome.
@AndrewBastin what are your thoughts?

Yeah, the spooling up a docker image and stuff is all pretty cool and all, but I don't get what is the point of this integration in the context of our application. I mean, there is no issue with this, but I don't see any point in having this either.

@velp closing this PR for now. Hopefully will reopen in times of need.


Attempt to add support for 9-slice

Hello! I'm trying to add support for nuklear's 9-slice rendering to love-nuklear. If you aren't familiar, it's a way to specify a texture for use as a button / window / whatever in a manner that avoids scaling artifacts at the corners and edges.
I've done a (quick-and-dirty for now) modification of nk_love_style_push_item to additionally accept 9-slice args ({image, quad, top, left, bottom, right}) in addition to its current support for colors and images. Mechanically things are working, but it renders very oddly (see below). There are enough unknowns that I'm having a hard time debugging:

The lua API is fairly new to me (but I think I have this right)
nuklear itself is new to me and the docs aren't great, although after studying the source and the 9-slice PR in its repo I think I have the arguments correct (see the comment in skin.lua)
I could be misusing some of nuklear-love's abstractions

I've modified the "skin" example as a test -- I'm trying to render the normal button using a 9-slice. What I get is below; note the odd tiling effect in the button rendering.
Anywhoo, I'm going to continue to debug but I thought I'd throw this up in case more experienced eyes can see the thing that I'm doing wrong.

Ah, the issue seems to be that when drawing a sub-image love-nuklear does not use the sub-rectangle fields inside nk_image and instead calls getViewport on the source image. That's why it's always drawing the entire texture for each of the patches -- it does not know to draw a sub-sub image. I'm sure there's a simple solution that I'll stumble on eventually.


Release functionality is broken

https://github.com/agilepathway/label-checker/actions/runs/9384254234/job/25839646043

Fixed by #461


On web-based Codespaces, git.enableCommitSigning should be ignored

VSCode Version: GitHub Codespaces
OS Version: Browser (Edge 86 on macOS)

Describe the bug
My VS Code settings include "git.enableCommitSigning": true to enable signing commits with a GPG key. These settings are synchronized to Codespaces too.
Because of that, making a commit in Codespaces on the browser fails every time, as browser-based apps can't access the GPG socket. In the git output view, the error message is:
> git commit --quiet --allow-empty-message --file - -S
error: gpg failed to sign the data

To Reproduce
Steps to reproduce the behavior:

Use browser-based Codespaces
Enable git.enableCommitSigning
Try to make a Git commit
Commits always fail

Expected behavior
Because it's not possible for a browser-based app to communicate with a GPG agent, git.enableCommitSigning should be ignored when using Codespaces in the browser.

Actually, I don't think this is right. I expect to still be able to sign in Codespaces. Please file an issue to Codespaces itself.


Add /about page

See Figma for content

hmm, seems like this content is exactly the same for the FAQ.

Launched in PR #53


Added Ghent University

These are the three official ways to write the name of Ghent University (https://www.ugent.be/)

Coverage remained the same at 97.874% when pulling 09345882e4d74dfc7e65dd47453244b2114b4dfa on galgalesh:patch-1 into 8e9d17cf95dab85a38df12644eed7499b175f71a on Jason3S:master.

Coverage remained the same at 97.874% when pulling 09345882e4d74dfc7e65dd47453244b2114b4dfa on galgalesh:patch-1 into 8e9d17cf95dab85a38df12644eed7499b175f71a on Jason3S:master.

I don't think a university counts as a company (except those weird for profit ones :wink: )

Maybe I should have called the file institutions.txt :-)
I am happy to have Universities and other well known organization in the list.
But, companies.txt was moved to cspell-dicts/packages/companies at master · Jason3S/cspell-dicts.
Please open a pull request there.
Thank you.

@galgalesh how about in software terms?


feat: Configure Content Security Policy with CspHtmlWebpackPlugin

Set up CSP using CspHtmlWebpackPlugin to enhance security by restricting sources for scripts, styles, images, fonts, and connections.

Blocked by https://github.com/slackhq/csp-html-webpack-plugin/issues/126


Add ghc-bin

Description of package
GHC - The Glourious Glasgow Haskell Compilation System
This is the official binary release for x86_64 Alpine Lunix which uses musl libc
Installed manifest of package
Too large for pr, pastebin
New package

[x] Latest upstream version.
[x] I agree to maintain this package.
[x] I agree to notify @dylanaraps if I can no longer maintain this package.

It shows the commits from my previous PR in the commit history for some reason, but the only new addition here is ghc-bin

I just noticed files not ready for installing, I will attempt to fix the package and then reopen. Apologies.

The Makefile doesn't support DESTDIR and I don't have the energy to rewrite it / reverse engineer it now so this will probably remain closed.

I'm looking into it, this will be handy to have in Community.

It is worth mentioning that the first approach of simply copying the files in bin, lib, and include worked, just that it copied a large amount of unecessary files as well.
There is also of course the provided makefile, but as I said, setting DESTDIR doesn't seem to work (even though it is set in one of the makefile config files).
The easiest way would probably be creating a custom Makefile or copying the files manually.
I'll do a find / before and after installing without kiss and diff the results to see if I can figure out what files are needed.

After investigating, it seems that the Makefile actually does exactly what my install script did, I just thought is seemed off. The number of installed files is exactly the same and after examining parts of the content it seems to match.
Also the reason that ghci is provided as a file is that otherwise it isn't recognised by kiss manifest and therefore wouldn't be removed upon package removal. Otherwise it's just the script provided by ghc but fixed to pass shellcheck.
Since everything seems to be working I will reopen the pr.

Nice. Just one thing:
# These are provided by libffi.
rm -f "$1/usr/lib/libffi.so" \
      "$1/usr/include/ffitarget.h" \
      "$1/usr/include/ffi.h"

This will prevent GHC from providing a duplicate libffi.

Done!

It also seems to link to GMP from /lib?
        libgmp.so.10 => /lib/libgmp.so.10 (0x7f47f4c94000)

Also, it links to ncurses so it should probably be added as a dependency.

ncurses is a dependency already, but I'll add gmp since it links to it. Weird that it would link to it even though their page said it wasn't a dependency though.

Yeah. It is odd.

No problem! I'll message the upstream about gmp and see what they have to say about it.


boards: arc: Convert boards to use device tree for LEDs & Buttons

Convert over arc based boards to use device tree instead of board.h to
describe buttons & LEDs.  There are a few boards that the button gpio
flags need validation.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

@ruuddw can you re-review.


Binary Archive v4 format and schema

Following up from v3 (see #4) time to start v4 proposals
SCHEMA

Array of build dependencies

Including min/max range

Array of runtime dependencies

Including min/max range

Array of recent changes

New or renamed components
Removed components
Split components

RELATED

Detached GPG signature per manifest
git repo of releases

subscribe to XML/atom feed

[ ] For libraries, a list of supported architectures. Specifically, the list of architectures, for which ptx code is included in the binaries, as would be reported by cuobjdump


token-js: created calculateFees function

Problem :
The rust side provides a nifty way to calculate a transfer fee using calculate_fee , but wallet for JS Clients cannot use it.
Solution:
Added calculateFee function for JS Client.

Just a couple more comments, but this looking very close!

yeah, i'm sorry I am new to the open source so i sometimes make mistakes.


Public OST faucet for goerli with rate limit

Devops has taken care this ticket from load balancer with IP based rate limit.


Does not work on macOS starting with OBS 29

Just wanting to note that this still doesn't work on the macOS OBS. You can try adding the plugin file to the two recommended locations below, but they both do nothing and LiveSplit One doesn't appear in the Sources list.
Applications > OBS > Contents > Plugins
Library > Application Support > obs-studio > Plugins
I'm really hoping to ask if a fix for this could be prioritized. I have a charity speedrunning event to run for in about 10 days, and this not working is a big wrench in the works.

I am having the same issue

From what I can tell, OBS now expects a .plugin bundle for plugins on macOS. I think this commit, part of version 28, made the change.
I can tinker with updating the macOS part of the build script to be in line with the plugin template OBS publishes when I get a chance

@CryZe Can I ask if you need any specific details from us? We're not the devs so all we can really report is that it stopped working when the change to 28.0's plugin requirements came into play.
I dunno if OBS logs could help? Could always upload those if needed too. I just don't know what else I can provide.

Good evening @CryZe @teusday. Looking at obs-plugintemplate it seems like the Cmake build system is tightly integrating with Xcode to build the new plugin format. My guess is that you would need to wrap the Rust macOS native library with a sort of C shim that depends on the Rust macOS native code built. It would require exposing the C functions that are exposed in Rust again through the shim.
Unfortunately, I don't have the experience to deal with C -> Rust integration, otherwise I would take a crack at it since I am trying to use my M2 MacBook Pro to do some streaming with my daughter. If there is a Rusty way to look at this problem, I would like to help, but Rust is pretty low on the list of my familiarity (only some minor work with my previous job).

Hello everyone, I recently decided to take a look at how to make obs-livesplit-one work on MacOS and i actually figured it out pretty easily (although since I don't have a Mac myself it makes testing quite difficult).
So, OBS now expects the plugins to have a specific directory structure, that's it, the plugin compilation does not have to change at all, in fact, any release in the releases that have a MacOS .so file will work with this.
This is the structure that OBS is looking for

These are all folders except for the .so file, you just have to create that structure, put the .so file and copy the .plugin folder to your plugins folder and OBS should load the plugin correctly.

So yeah there you go, I suppose we'll look into packaging the MacOS builds with that format with the next releases but in the meantime, you can manually make it work by following these steps, have a nice day.

I am glad that you had a second to test it. I am surprised it is that easy @Refragg. I have a Mac for its longlitivity, but I find its structure to be obtuse at best why things are how they are.... I am looking at you rpath.

I tried the steps suggested by @Refragg, but I still couldn't get it to work on MacOS (ARM64). It seems to me that the other plugins don't have a .so file in their Contents/MacOS folder.

What version of OBS are you on? I wonder if they changed some other thing again between OBS 28 and 29

If you're on 29, can you please try it out on 28 just like the screenshot i posted?

Maybe it's a difference between x86_64 and Aarch64 macOS?

It does work on OBS 28 with @Refragg 's procedure.

Thanks!! Then maybe let's re-open the issue?

So the problem would just be that it isn't locating the libobs library? That would be interesting, is libobs.0.dylib not in any of these mentioned folders? Is there a one with a similar name perhaps?

So I looked a bit more into this and it is best to put it into the OBS plugins directory under /Applications/OBS.app/Contents/Plugins so that OBS will try to load it without having any issues. The issue seems to be that libobs doesn't exist with the name libobs.0.dylib or anything like that. Version 29 seems to have a libobs located under /Applications/OBS.app/Contents/Frameworks/libobs.framework/Versions/A/libobs. There is a symlink that can be followed from /Applications/OBS.app/Contents/Frameworks/libobs.framework/libobs.
Looking at the https://github.com/obsproject/obs-plugintemplate/blob/master/cmake/macos/buildspec.cmake, it seems to refer to the same Frameworks directory as a base directory. Same for https://github.com/obsproject/obs-plugintemplate/blob/master/cmake/macos/defaults.cmake setting rpath to the executable's Framework directory.

Thank you for your researches on this. I unfortunately just don't have the knowledge / ressources to solve this problem. Maybe @CryZe has a solution now with the details we've gathered? I don't know what else we could do to be honest.

So maybe in the ffi.rs file, try running the link macro as a framework instead of dylib, which works for the other two OS types.  So, something like this https://users.rust-lang.org/t/link-against-framework-macos/3786 would allow running it if the configuration is for macOS with a build.rs something like https://github.com/bennetthardwick/rust-obs-plugins/blob/master/obs-sys/build_mac.rs to allow finding the OBS framework that needs to be built against.

OKAY, after several hours of trying to get this to work, with your researches on the framework stuff, it seems like I succeeded! @AlexKnauth was able to run this build of obs-livesplit-one on OBS 29! I'll need to do some cleanup before merging this but there's a good chance it works now at least!

For posterity, this is also the failure mode when you are running an x86 OBS.app on a silicon mac via Rosetta (I guess when I got this laptop I used migration assistant to copy apps from my previous intel mac).
Look for (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')) in your OBS logs (Help -> Log Files -> View Current Log).
Fix is to just reinstall the proper Apple Silicon release of OBS. Or I guess install the x86 version of this plugin and run that via Rosetta too, although I didn't try that.


PLNSRVCE-522 : Containers - Clair - Vulnerability Scanner

Added the image (Dockerfile + script) for future consumption in Pipeline Runs.
For now, created a Github Action to use the same script to fetch the results to check for vulnerabilities in our images on quay.
Have also setup Authorization token via Github secrets.

@fgiloux @Roming22 I have processed all the comments. PTAL.

@fgiloux Please merge when you/re ready to approve the PR.


fix just display track expense of selfDM is loaded

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40257
PROPOSAL: https://github.com/Expensify/App/issues/40257#issuecomment-2057934941
Tests

Create a new account
Track Expense
After entering an amount, click 'Next'
You should see a final confirmation page, instead of seeing a participant selector page

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a new account
Track Expense
After entering an amount, click 'Next'
You should see a final confirmation page, instead of seeing a participant selector page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/161821005/db9e5fa0-1499-48f3-8ef8-d540d006bf80

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/f5920a78-c854-4cb8-a2ab-e755a8337815

iOS: Native

https://github.com/Expensify/App/assets/161821005/f60655f5-c931-4eaf-b754-767af7ebe461

iOS: mWeb Safari

https://github.com/Expensify/App/assets/161821005/4f26117c-0b3d-48d2-91ec-f46455b2a32c

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/0150984b-442a-4a6d-a203-e9d05bdd1b41

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/43f3170e-3cb8-491a-8fd8-910ce97ec598

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/16502320/d90a9a37-c19a-4997-b571-c4de25056c4c

Android: mWeb Chrome

https://github.com/Expensify/App/assets/16502320/6d750bd4-b0f5-4423-90c7-dad786639210

iOS: Native

https://github.com/Expensify/App/assets/16502320/0c4b214d-d8ab-4e78-9d89-8fd5ba7c0152

iOS: mWeb Safari

https://github.com/Expensify/App/assets/16502320/4ca8c6d5-18f7-48d8-bbe2-12848c29e070

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16502320/66f1421c-2304-4148-8e91-993545ff0902

MacOS: Desktop

https://github.com/Expensify/App/assets/16502320/0cbd6280-21b9-436d-8bbe-7cf63bb8e8d2

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Expanding is not working with manualPagination and with truthy paginateExpandedRows

Describe the bug
Hi! In the current project, we have two types of tables: controlled and independent. Both of them have the default options for pagination and for expanding:
const defaultOptions = {
  // We don't want to slice expanded rows
  paginateExpandedRows: false,
  getPaginationRowModel: getPaginationRowModel(),
  getExpandedRowModel: getExpandedRowModel(),
}

The controlled table can be customized by a developer, especially pagination (he can set manualPagination in true) if he doesn't want to use internal pagination. The other type of table might not be customizable and pagination is fully controlled by logic around the current library. So, in the first case, expanding functionality becomes broken when we are trying to use external pagination params and setting manualPagination in true. I've found that the course of the problem is here:
https://github.com/TanStack/table/blob/main/packages/table-core/src/utils/getExpandedRowModel.ts#L22
After that, I tried to fix it and just added a simple check to getExpandedRowModel:
function getCustomExpandedRowModel<TData extends RowData>(): (
  table: Table<TData>
) => () => RowModel<TData> {
  return table =>
    memo(
      () => [
        table.getState().expanded,
        table.getPreExpandedRowModel(),
        table.options.paginateExpandedRows,
        table.options.manualPagination,
      ],
      (expanded, rowModel, paginateExpandedRows, manualPagination) => {
        if (
          !rowModel.rows.length ||
          (expanded !== true && !Object.keys(expanded ?? {}).length)
        ) {
          return rowModel
        }

        // Here is the fix
        if (!paginateExpandedRows && !manualPagination) {
          // Only expand rows at this point if they are being paginated
          return rowModel
        }

        return expandRows(rowModel)
      },
      {
        key: 'getExpandedRowModel',
        debug: () => table.options.debugAll ?? table.options.debugTable,
      }
    )
}

It's also presented in an example. But for now, we have other options to avoid this problem:

Don't use paginateExpandedRows in false with manualPagination
Create a custom getExpandedRowModel and copy the internal logic from the repo
Update somehow getExpandedRowModel and don't use paginateExpandedRows inside

I think, the first choice is the easiest one, but it must be documented (because it's very unclear). In other case, if the fix in the example is looking good for you, I can make a PR with tests)
Your minimal, reproducible example
https://codesandbox.io/p/sandbox/dreamy-euler-fjgltr
Steps to reproduce

Open an example
Try to expand any row

Expected behavior
A row must be expanded
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Any
react-table version
v8.10.3
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

i think you meant falsy paginateExpandedRows, I am having the same issue

i think you meant falsy paginateExpandedRows, in your example it's set to false, I am having the same issue

Yeah, thx for the correction)


Error after input user at installation step

I found some errors tonight
I have repeat and repeat reinstall again.
My environment using php version 8.1.5 Windows 10 using Laragon.
After i input email, name, username and password the terminal said ERROR with this information :
[Error]
Call to undefined function CodeIgniter\Shield\Authorization\Traits\setting()
at VENDORPATH\codeigniter4\shield\src\Authorization\Traits\Authorizable.php:397
I don't know what is it? Is that bug or i have missed something?
I have re-setup 4times at different environment, Win10, Ubuntu 22.04, and Win11 still the same.
Need some help
Thank you.

BF2 uses the Shield develop branch, so you need to follow the instructions below:
https://github.com/codeigniter4/shield/blob/develop/UPGRADING.md
If you can send a PR for the fix.


feat: expose ports for user defined containers

Expose containerPort for user defined containers so that it can be used for prometheus metrics scraping configuration.

This needs to go to the patch release of v1.3


U - Fix CSS linter errors: data.interactive_example? errors

The linter will check that CSS pages correctly include this ingredient.
Acceptance criteria

[x] There are zero errors reported by the linter for the "data.interactive_example?" ingredient, when run against https://developer.mozilla.org/en-US/docs/Web/CSS

The (very few) errors here have all been fixed.


Mermaid statediagram not rendered

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Entering the mermaid syntax for a state diagram, for example as shown below, does nothing.
"
stateDiagram
s1 --> s2
"
To Reproduce
Steps to reproduce the behavior:

Go to 'Arranged'->'Insert'->Advanced
Click on '.Mermaid..'
Enter the text shown above
No diagram generated.

Expected behavior
Simple state diagram as shown in https://mermaid-js.github.io/mermaid/#/stateDiagram.
draw.io version (In the Help->About menu of the draw.io editor):

draw.io version [13.1.2]

Desktop (please complete the following information):

iOS
Browser (chrome)

Additional context
Same behavior if I first generate another type of diagram (figure is rendered) and then change the Mermaid text to state diagram (it disappears).

Fixed


23SepDemo: New Field - caseType to be added

a new field called caseType needs to be added to CourtCase entity. For now this will be only added to this entity and will not be added to search criteria.
Logic

on e-filing (draft or submit) - caseType = null.
On case registry when CMP number is generated, caseType = CMP
On case admission when ST number is generated, caseType = ST

Master Table Definition
Columns - ID | caseType | description | priority | isActive
Master Table Values
1 | CMP | Criminal Miscellaneous Petition | 15 | true
1 | ST | Summary Trial | 10 | true
1 | CC | Calendar Case | 5 | true
CauseList Sorting Logic

Get hearings for the day for a court
Group by hearing type
Sort by hearing type as per the list (check with Mehul / Devraj)
within each hearing type sort by caseType (lowest priority first - priority as defined in master table)
within each caseType sort by oldest case first (earliest registration date)

@subhashini-egov @suresh12 @Taherabharmal

@manimaarans both pretty much point to the same, but yes, we case use courtID. (edited in the ticket details)

I would think using JudgeID is better @manimaarans

Hi @atulgupta2024  the logic is updated in UAT please verify and confirm


Refactor AttributePart to only have a single value

This PR removes the SinglePart/MultiPart distinction. AttributeParts now only have a single value, but are associated with an AttributeCommitter that commits multiple values to an attribute.
This PR is based on #398.
The attribute handling code is a bit simpler in this factoring, though the "fast" path for attribute with a single value isn't implemented here, but it is implemented for PropertyCommitter. Not sure if this matters much.

@sorvell this is ready for review now. I like the shape of the API now, with the small exception of PartCallback returning an array of Parts. I didn't yet explore returning multiple TemplateParts for attributes. I can look into that or not... I don't think there will be that many PartCallback implementations our there.
core.ts gets a tiny bit smaller with this factoring, by about ~40 bytes.

@sorvell added PropertyPart. PTAL


Become on non existing user

Fix bug where become return invalid session if the pointer to user
doesn't exist

We may wanna destroy the session instead no? @drew-gross what do you think?

Destroying session for deleted user seems to make sense, yes. Have you checked what Parse.com does? Also I recall some issue where the SDKs would start failing when their session was destroyed, so maybe that's why we didn't destroy it.

If user is deleted, session token should be invalidated at least. @flessard can you check the current behavior on parse.com or you want me to check it out?
Other thing to check is to see when calling include on a key and the included object don't exist. Should the pointer getting soft-deleted from the response? I would tend to say so.

@flovilmart Yes if you can check it out, i would appreciate it.
I agree whit you @flovilmart, if the pointer getting don't exist, Should soft-deleted from the response.

@flessard so I can confirm that missing includes are resolved to undefined, and that the pointer object is not forwarded to the client.

Superseded by #777


Search-bar looks bad in small Edge window

The search-bar is typeahead widget? Can you show us your template?

Lol opened issue on wrong repo


i got this error

Traceback (most recent call last):
File "main.py", line 5, in
transcript_list = YouTubeTranscriptApi.get_transcript(video_id)
File "/home/runner/transcriptapitest/venv/lib/python3.10/site-packages/youtube_transcript_api/_api.py", line 132, in get_transcript
return cls.list_transcripts(video_id, proxies, cookies).find_transcript(languages).fetch()
File "/home/runner/transcriptapitest/venv/lib/python3.10/site-packages/youtube_transcript_api/_api.py", line 71, in list_transcripts
return TranscriptListFetcher(http_client).fetch(video_id)
File "/home/runner/transcriptapitest/venv/lib/python3.10/site-packages/youtube_transcript_api/_transcripts.py", line 47, in fetch
self._extract_captions_json(self._fetch_video_html(video_id), video_id)
File "/home/runner/transcriptapitest/venv/lib/python3.10/site-packages/youtube_transcript_api/_transcripts.py", line 59, in _extract_captions_json
raise TranscriptsDisabled(video_id)
youtube_transcript_api._errors.TranscriptsDisabled:
Could not retrieve a transcript for the video https://www.youtube.com/watch?v=https://www.youtube.com/watch?v=aJHt-BXNYh0! This is most likely caused by:
Subtitles are disabled for this video
If you are sure that the described cause is not responsible for this error and that a transcript should be retrievable, please create an issue at https://github.com/jdepoix/youtube-transcript-api/issues. Please add which version of youtube_transcript_api you are using and provide the information needed to replicate the error. Also make sure that there are no open issues which already describe your problem!


As you didn't provide any code I don't know what you are executing, but looking at the error message it looks like you have passed the whole video URL into get_transcript instead of only the video id.


Commanding anything else that wheel velocities

I'm aware of the velocity interface expose as /cmd_vel. Is there any way to command e.g. motor currents or voltage/PWM? This would be nice as it would allow users to create their own motor controller. Not that this would improve performance, but it would open up the platform for controls experiments/education. We are happily using the create for a robotics class, but would like to extend the usage to controls courses.
As an example application, the robot could traverse from area with hard floor to a carpet area, and this change would need to be deal with by the control.

No, this is currently not possible.
We may consider it as a feature for a future release.


find-repeats use only snvphyl-tools env

Galaxy Wrapper for find-repeats.xml should collapse to a single conda requirement instead of having mummer separately. However, when just using snvphyl-tools, get following error.
Can't locate Foundation.pm in @INC (you may need to install the Foundation module) (@INC contains:....)
Time to update the bioconda recipe!

Issue is that there are now multiple version of perl being installed for snvphyl and mummer. Hence, when a package is installed, it may or may not go into the correct perl version library path.

Closing this issue. We are sticking with 2 conda requirements for the update.


Add a workflow to publish nightly releases

Add a workflow to publish a nightly prerelease every day from the latest content
Tested on this repo:
https://github.com/Noggog/SpriggitWorkflowTests
I tried to get some short circuit logic where it wouldn't just blindly re-release every night, but I couldn't combine the schedule trigger /w paths filtering.   If someone figures that out, let me know!

I tried to get some short circuit logic where it wouldn't just blindly re-release every night, but I couldn't combine the schedule trigger /w paths filtering. If someone figures that out, let me know!

I did some tests with this! The lines marked below are the important rows.
https://github.com/FlayaN/SF_Testmod/blob/main/.github/workflows/nightly.yml#L8-L22
Basically adds a jobs that runs before the normal job that both checks if there were any changes the last 24 hours and the changes were done on src/plugin/.* (wildcard syntax for grep)
It sets a output that is then used if it should run the "normal" job or not

I did some tests with this!

God among men.  How did you test the 24hr bits?  Set the time to a lower amount or somesuch?
I really want to get these solidified as dedicated actions once they work here.  Stuff like the modified in the last 24hrs I'd love to use everywhere else in my other projects, too, haha

How did you test the 24hr bits? Set the time to a lower amount or somesuch?

I basically used git bash locally on a random git repo with the git log --since="1 days ago" --name-only and didn't see any rows being outputted, then changed the "1 days ago" to something like "3 days ago" and then some files showed up.

Action was run on my fork last night successfully:
https://github.com/Noggog/Starfield-Community-Patch/actions
Gonna wait until tonight to see it short circuit, and then merge this in

Action was run on my fork last night successfully: https://github.com/Noggog/Starfield-Community-Patch/actions
Gonna wait until tonight to see it short circuit, and then merge this in

My version will run in 3 hours, so you can check there as well if my version short circuits.
https://github.com/FlayaN/SF_Testmod/actions/workflows/nightly.yml

My version short-circuited, want me to create pr onto your branch with mentioned fixes above? I can do it tmrw if you want it

My version short-circuited, want me to create pr onto your branch with mentioned fixes above? I can do it tmrw if you want it

Im just dumb and applied the short circuiting logic to my other test repo instead of this, haha.  I see yours worked, though

So this run here I would've expected a short circuit
https://github.com/Noggog/Starfield-Community-Patch/actions/runs/6220478520
I ran one manually just now, and that short circuited fine
https://github.com/Noggog/Starfield-Community-Patch/actions/runs/6230085559
So not sure why the first one saw changes.   Gonna see if tonights works out


[ExpansionTile] adds collapsedBackgroundColor property

Description
Adds a new collapsedBackgroundColor property to apply a background color to tile when the sublist is collapsed.
Related Issues
Fixes #52213
Tests
I added the following tests:

Adds test for collapsedBackgroundColor

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

is this done?
there seems no such property in documentation https://api.flutter.dev/flutter/material/ExpansionTile-class.html
Please comment.

I've just updated to Flutter 1.26.0-17.6.pre • channel beta, property is available there.


cap deploy freezes at "Updating parameters"

By trying to deploy my project, the Deployment freezes at "Updating parameters".
Do you have any idea, where the problem could be?

Same problem here!

I also wrote a question at stackoverflow and the answer helped me.
Have a look: http://stackoverflow.com/questions/27709896/cap-deploy-freezes-at-updating-parameters-capifony

Don't know why your question got downvoted @Worstkaes but I neutralized that vote. ;)
My error is gone since I made some changes to my deployment setup.
Did you solve your issue and can you close this one? Thanks.


Fix test expectation for notebooks/Shared/examples/abfss-in-abfss-out-oauth

There's a misspelling on the source notebook 🙄

Fixed with #107 and #109


fix(logger): restore previous --logFileDailyRotate behavior

Motivation
https://github.com/ChainSafe/lodestar/pull/5490#discussion_r1209337604
Description
Restores previous --logFileDailyRotate behavior

lodestar --logFileDailyRotate -> enable daily rotate with default value (same as omitting the flag)
lodestar --logFileDailyRotate 10 -> set daily rotate to custom value 10
lodestar --logFileDailyRotate 0 -> disable daily rotate and accumulate in same file

This logic was previously handled by the CLI package
https://github.com/ChainSafe/lodestar/blob/a4b29cfe38de109c44992977074869a8c01cfc83/packages/cli/src/util/logger.ts#L72-L82

:tada: This PR is included in v1.9.0 :tada:


Fixes Empty Space on Settings Preference

Description (required)
Fixes #3573
What changes did you make and why?
I set the visibility of iconFrame to View.GONE for all preferences.
Tests performed (required)
I tested it on my device Vivo V11 Pro, Android 9.
Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

I'm not sure if its worth doing what's typically a layout change in the corresponding fragment code. Can you see if you this could be achieved via a change to the XML? The comments in the related issue (#3573) are a good starting point.

Hi @sivaraam! Thanks for reviewing. According to the docs, setting iconSpaceReserverd=false should work. But I tried this in the XML file as well as in the java class. Moreover, I found that in the source code for Preference, it sets the visibility of iconFrame to gone according to the value of iconSpaceReserved:
iconFrame.setVisibility(iconSpaceReserved ? View.INVISIBLE : View:GONE)
But, I guess maybe this part of the code is reached before we change the value of iconSpaceReserved

Regarding to the discussion in issue page, even if I also don't like the solution is achieved programmatically, I think we need to rely on this hacky solution. Thus merging it. Thanks @SaumiaSinghal :)


localization and inference details

Team,
i would like to know this model can be inference on video?
thanks
Chethan

Hello Chethan,
Indeed, it is possible to use facetorch for video processing, given that videos are essentially sequences of images. However, please note that you'll need to first extract the frames from your video file, as FaceAnalyzer currently lacks built-in support for direct video file processing.
To provide more specific guidance, it would be helpful if you could share additional information. In particular, could you clarify which model you are intending to use? Furthermore, are you considering real-time video processing, or is this for pre-recorded video files?
Understanding these details will allow me to give you more targeted advice. Please feel free to reach out if you need further assistance or clarification.

thanks for details, i am doing processing on prerecorded videos. i have done the inference and stich back the images.
i would like to do instead if  class it i would like to change to class name. am working on how best i can do with this.

i am using facetorch to get emotion details

i would like to do instead if class it i would like to change to class name. am working on how best i can do with this.

Your question is a bit unclear to me, but if I'm understanding you correctly, you'd like to use class names instead of class identifiers in your processing. If that's the case, the FaceAnalyzer should return class names as part of its response, which you should be able to utilize in your application. If this isn't what you were asking or you need further clarification, please provide a bit more context or detail so I can assist you better.


Output name print doesnt work with origin type string

gh_md_to_html.main(md_as_string, origin_type='string', output_name='print')
the problem is that html_rendered is returned only if output_pdf is set.

Thanks for pointing that out; seems like I messed up the indentation there! It should be fixed now (Prints no matter whether output_pdf is set or not). The new version on PyPi (1.3.3) should behave as expected.


LavaPlayer doesn't work when i build the project (2020 pls note that)

i have the latest LavaPlayer and JDA version but it doesn't work.
[JDA [0 / 1] AudioConnection Guild:<PHONE_NUMBER>04187148 Sending Thread] ERROR AudioConnection - There was an error while getting next audio packet
java.lang.UnsupportedOperationException
        at com.sedmelluq.discord.lavaplayer.track.playback.TerminatorAudioFrame.getVolume(TerminatorAudioFrame.java:18)
        at com.sedmelluq.discord.lavaplayer.track.playback.AllocatingAudioFrameBuffer.filterFrame(AllocatingAudioFrameBuffer.java:194)
        at com.sedmelluq.discord.lavaplayer.track.playback.AllocatingAudioFrameBuffer.provide(AllocatingAudioFrameBuffer.java:61)
        at com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor.provide(LocalAudioTrackExecutor.java:398)
        at com.sedmelluq.discord.lavaplayer.track.BaseAudioTrack.provide(BaseAudioTrack.java:92)
        at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayer.provide(DefaultAudioPlayer.java:189)
        at com.sedmelluq.discord.lavaplayer.track.playback.AudioFrameProviderTools.delegateToTimedProvide(AudioFrameProviderTools.java:18)
        at com.sedmelluq.discord.lavaplayer.player.DefaultAudioPlayer.provide(DefaultAudioPlayer.java:175)
        at me.KFPL.music.AudioPlayerSendHandler.canProvide(AudioPlayerSendHandler.java:21)
        at net.dv8tion.jda.internal.audio.AudioConnection$PacketProvider.getNextPacketRaw(AudioConnection.java:675)
        at net.dv8tion.jda.internal.audio.AudioConnection$PacketProvider.getNextPacket(AudioConnection.java:665)
        at net.dv8tion.jda.api.audio.factory.DefaultSendSystem.lambda$start$0(DefaultSendSystem.java:69)
        at java.base/java.lang.Thread.run(Unknown Source)

Lavaplayer exceptions are not a JDA issue. If you want to report a JDA bug please use the bug issue template instead. To report bugs with lavaplayer open an issue at https://github.com/sedmelluq/lavaplayer/issues/new and please include your code as well.


Separate integration tests from unit tests

sbt test should not require any other services to be running.
In this PR, move any tests that require Cassandra to be running into the src/it directory.

Half of the tests in EntityMapperSpec are unit tests. We should keep them in the test directory.

LGTM


TFLite conversion coredumps

System information : Ubuntu18.04, CUDA 10

Have I written custom code (as opposed to using a stock
example script provided in TensorFlow): No. Problem exists even when using tflite_convert OR writing custom code as described in documentation
OS Platform and Distribution (e.g.,
Linux Ubuntu 16.04): Ubuntu18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if
the issue happens on mobile device:
TensorFlow installed from (source or
binary): - TensorFlow version (use command below): Binary/Tensorflow: 2.0.1
Python version: - Bazel
version (if compiling from source):
GCC/Compiler version (if compiling from
source):
CUDA/cuDNN version: - GPU model and memory: Cuda 10/GTX1070Ti, 8G

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
Tensorflow lite conversion dumps core both for 8 bit and 16 bit quantizations and no tflite file is generated when using the from_saved_model converter. The model shape (as can be seen from saved_model_cli) is below. The model is a SSD-mobilenetv2 transfer learned by using tensorflow detection API on Tensorflow 1.14
signature_def['serving_default']:
The given SavedModel SignatureDef contains the following input(s):
inputs['inputs'] tensor_info:
dtype: DT_UINT8
shape: (-1, 300, 300, 3)
name: image_tensor:0
The given SavedModel SignatureDef contains the following output(s):
outputs['detection_boxes'] tensor_info:
dtype: DT_FLOAT
shape: (-1, 30, 4)
name: detection_boxes:0
outputs['detection_classes'] tensor_info:
dtype: DT_FLOAT
shape: (-1, 30)
name: detection_classes:0
outputs['detection_multiclass_scores'] tensor_info:
dtype: DT_FLOAT
shape: (-1, 30, 5)
name: detection_multiclass_scores:0
outputs['detection_scores'] tensor_info:
dtype: DT_FLOAT
shape: (-1, 30)
name: detection_scores:0
outputs['num_detections'] tensor_info:
dtype: DT_FLOAT
shape: (-1)
name: num_detections:0
outputs['raw_detection_boxes'] tensor_info:
dtype: DT_FLOAT
shape: (-1, -1, 4)
name: raw_detection_boxes:0
outputs['raw_detection_scores'] tensor_info:
dtype: DT_FLOAT
shape: (-1, -1, 5)
name: raw_detection_scores:0
Method name is: tensorflow/serving/predict
Describe the expected behavior
I expect the tflite file to be generated by following the public documentation on Tensorflow site and don't expect core dumps.
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
2020-03-31 06:46:09.156599: I tensorflow/core/grappler/devices.cc:55] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 1
2020-03-31 06:46:09.156683: I tensorflow/core/grappler/clusters/single_machine.cc:356] Starting new session
2020-03-31 06:46:09.157414: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1618] Found device 0 with properties:
name: GeForce GTX 1070 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.683
pciBusID: 0000:07:00.0
2020-03-31 06:46:09.157448: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudart.so.10.0
2020-03-31 06:46:09.157459: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcublas.so.10.0
2020-03-31 06:46:09.157469: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcufft.so.10.0
2020-03-31 06:46:09.157478: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcurand.so.10.0
2020-03-31 06:46:09.157487: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcusolver.so.10.0
2020-03-31 06:46:09.157496: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcusparse.so.10.0
2020-03-31 06:46:09.157505: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudnn.so.7
2020-03-31 06:46:09.157937: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1746] Adding visible gpu devices: 0
2020-03-31 06:46:09.157973: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1159] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-03-31 06:46:09.157980: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1165]      0
2020-03-31 06:46:09.157986: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1178] 0:   N
2020-03-31 06:46:09.158409: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1304] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 6624 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1070 Ti, pci bus id: 0000:07:00.0, compute capability: 6.1)
2020-03-31 06:46:09.471641: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:716] Optimization results for grappler item: graph_to_optimize
2020-03-31 06:46:09.471673: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   constant folding: Graph size after: 1765 nodes (-1299), 2239 edges (-1452), time = 191.291ms.
2020-03-31 06:46:09.471681: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   constant folding: Graph size after: 1765 nodes (0), 2239 edges (0), time = 51.045ms.

Fatal Python error: Aborted
Current thread 0x00007fbd58971740 (most recent call first):
File "/home/vk1z/.virtualenvs/tensorflow-lite-convert/lib/python3.6/site-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 52 in execute
File "/home/vk1z/.virtualenvs/tensorflow-lite-convert/lib/python3.6/site-packages/absl/app.py", line 250 in _run_main
File "/home/vk1z/.virtualenvs/tensorflow-lite-convert/lib/python3.6/site-packages/absl/app.py", line 299 in run
File "/home/vk1z/.virtualenvs/tensorflow-lite-convert/lib/python3.6/site-packages/tensorflow_core/python/platform/app.py", line 40 in run
File "/home/vk1z/.virtualenvs/tensorflow-lite-convert/lib/python3.6/site-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 89 in main
File "/home/vk1z/.virtualenvs/tensorflow-lite-convert/bin/toco_from_protos", line 8 in
Aborted (core dumped)
==
Yes, I am aware of 35376 but I don't think that a coredump is an expected output of any conversion process.

Sorry about the unexpected capitalization above.

Follow up; The exact same behavior is observed when trying to convert the SSD Mobilenet model from the tensorflow detection Zoo - specifically: ssd_mobilenet_v2_coco_2018_03_29.
The model there was also converted to have input shape (None, 300, 300, 3) (since tflite conversions from (None, None, None, 3) fail). Consequently I believe that should be an easy bug to repro and hopefully fix since this makes the export of tensorflow lite models unusable on Tensorflow 2.0.1.

@vk1z
Can you please share colab link or simple standalone code with supporting files to reproduce the issue in our environment.It helps us in localizing the issue faster.Thanks!

Will do so today.

@vk1z
Any update on this issue please. Thanks!

Will do on the weeend. Apologies.

@vk1z
Any update on this issue please. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Adding Poolsana Heat Pump

Adding Poolsana Heat Pump to supported devices: https://www.poolsana.de/pool-full-inverter-waermepumpe-poolsana-inverpower-next-11

This adds the heat pump as a climate entity and also different dp sensors for current temperature, target temperature, effluent temperature and fault value.

Sorry for the "problems", this is my first commit and first time I write a device yaml file :-(


Resource Type inheritance of other resource types do not properly work

When a resource type inherits from another resource type, the "child" resource type does not correctly overwrite the inherited properties.
Current behavior:
#%RAML 0.8
---
title: Example API
baseUri: http://example.com
version: v1
resourceTypes:
  - base:
      description: a base resource type for other resource types to inherit from
      get:
        description: This description should be overwritten
        queryParameters:
          inheritedParam:
            description: query parameter that should be inherited
  - inheritFromBase:
      description: this resource type inherits from `base`
      type: base
      get:
        description: overwrites base description
        queryParameters:
          aNewParam:
            description: another parameter added from base type
            example: a new param
/inherit-resource-type:
  type: inheritsBase
  description: resource type inherits resource type
  get:
    displayName: get resource type

When parsed:
>>> api = parse(RAML_FILE)
>>> res = api.resources[0]
>>> r
ResourceNode(method='get', path='/inherit-resource-type')
>>> r.description.raw   # this is expected
'overwrites base description'
>>> r.query_params  # this is not - does not inherit query params
 [QueryParameter(name='aNewParam')]

I would expect r.query_params  to actually have two QueryParameter objects.

Potential fix with #73

Addressed completely (hopefully) with #76


remove references to zappa.io

Description
Given up on waiting for zappa.io to reappear in the net.
GitHub Issues
Resolves #1976
Resolves #1838
Resolves #311

Coverage remained the same at 72.967% when pulling 7b3907a9a2601499670a09a5782c72f71c0e8b94 on bugfix/remove-zappa-io-references into 818f7de2aee18fb2f85e074207e034240dc9e242 on master.

The blog entries are all on a separate repo: https://github.com/Miserlou/zappa-blog, maybe we could just move those into a docs folder or something within the project and link to them there

I've also suggested the same, as well as updating the headline, but @jneves just pushed on master... https://github.com/Miserlou/Zappa/commit/818f7de2aee18fb2f85e074207e034240dc9e242

@MRigal sorry, that had been by mistake - I'm fine with someone cleaning up the blog posts and adding to the docs, but I don't have the time to keep the blog going and nobody else has volunteered for it yet.

Can someone please remove this link from the repo?

It is not maintained within git. Only @Miserlou has access to it. I've requested that it be removed but haven't heard back.


Unable to update redcap 14.4.x -> 14.5.x

When I recently tried updating redcap from 14.4.1 to 14.5.0 / 14.5.1, deployment was successfully completed but white page was appeared and unable access to my redcap. Could you provide guidance on how to resolve this issue? Any troubleshooting steps or known issues with this version update would be greatly appreciated.

Most likely you are missing the last step to run upgrade.php.
4. Run REDCap upgrade function
Before executing this command, it is recommended to do a database snapshot or get familiar with Aurora backtrack window feature in case of failure.
Once deployment is complete, REDCap's database is updated/migrated by accessing https://<your_domain>/upgrade.php?auto=1.
Alternatively, you can access in your browser to https://<your_domain>/upgrade.php and click on Option A --> Upgrade to upgrade the database tables.

Oops!
I forgot accessing https://<your_domain>/upgrade.php?auto=1 BEFORE accessing redcap home page.
The update successfully done. Thank you!
p.s. I also report that I could run ver. 1.0.7. successfully.


Add ability to save and restore port positions

When resizing a block in an IBD diagram the location of the associated ports are changed, requiring manual work to fix them.
As I used I would like to be able to resize the block so that at the end of the operation the ports remain at their original place.

A way to solve this problem could be the following:

Add a button to store the location of the ports
Do the resize
Press a button to restore the locations

This is also true for BDD diagrams:

Done in 1.1


Expose retries with trace tags and extra response info/logs

Issue Template
Title: Is there a way to know retries have occurred in an egress HTTP request?
Description:

We are using a LUA script to generate custom trace reports for each ingress/egress HTTP requests and it would be very beneficial to capture the retry events in requests and put them in report. Does envoy already provide some features for this, such as a response header to indicate retry counts?

The following stats on the cluster that you are trying to hit should help you
upstream_rq_retry:
upstream_rq_retry_overflow:
upstream_rq_retry_success:

IIRC each retry would be shown in the upstream access logs, but I don't think we explicitly indicate that it is a retry today (though that would be useful).

Stats or logs won't be able to tie the retry indication to a request. We are trying to show retry activities in distributed tracing. The ideal case would be an entry in response header that says the request has been tried.

@charliezgc I agree and have thought about this also. I think that we should indicate retries both as tracing tags (including the retry number) as well as possibly in the extra response info work that @junr03 is working on. Will move this over to enhancement.

This was fixed. There are now retry trace tags.


Move example sketch to appropriately named folder

The Arduino IDE requires the sketch folder name to match the filename of the primary sketch file. This change causes the example sketch to be accessible via the Arduino IDE's File > Examples > LIBRARYNAME menu after the library is installed.
Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#library-examples

You are perfectly right, it has been done.


The navigation bar will "pinch" when you click on the tabs

When clicking on the tabs in the navigation bar, the bar itself will pinch in, decreasing in height and then expanding. Present in all browsers

This issue is fixed in this PR https://github.com/openforge/OPENFORGE.IO/pull/81


Add CUDA 11.2 build images

Add CUDA 11.2 build images to the builder tool.

https://github.com/open-ce/open-ce/issues/422


Remove card component

Let's remove the card component, it's been deprecated for 9 months.

We can take a look at this as part of updating the ML extension at some point.


Allow discover

Rename file to tests/test_xkcdpass.py
Allow the usage of discover -> python3 -m unittest discover
Address deprecation warning

Thanks for this, will be in the next released version!


x11 is missing

I've followed the guide for installing imglab. I am on OS X 10.11.4.
When I run cmake --build . --config Release I get:
...
[ 92%] Building CXX object CMakeFiles/imglab.dir/src/main.cpp.o
In file included from /Users/christinazou/Downloads/dlib-master/tools/imglab/src/main.cpp:4:
In file included from /Users/christinazou/Downloads/dlib-master/tools/imglab/src/metadata_editor.h:6:
In file included from /Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_widgets.h:13:
In file included from /Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_widgets/widgets.h:16:
In file included from /Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_widgets/drawable.h:10:
In file included from /Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_widgets/../gui_core.h:14:
In file included from /Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_core/xlib.h:4:
/Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_core/gui_core_kernel_2.h:11:2: error: "DLIB_NO_GUI_SUPPORT is defined so you can't use the GUI code.  Turn DLIB_NO_GUI_SUPPORT off if you want to use it."
#error "DLIB_NO_GUI_SUPPORT is defined so you can't use the GUI code.  Turn DLIB_NO_GUI_SUPPORT off if you want to use it."
 ^
/Users/christinazou/Downloads/dlib-master/dlib/../dlib/gui_core/gui_core_kernel_2.h:12:2: error: "Also make sure you have libx11-dev installed on your system"
#error "Also make sure you have libx11-dev installed on your system"
 ^
2 errors generated.
make[2]: *** [CMakeFiles/imglab.dir/src/main.cpp.o] Error 1
make[1]: *** [CMakeFiles/imglab.dir/all] Error 2
make: *** [all] Error 2

I already tried to install x11 by doing:
brew cask install xquartz
But still get this error. What do I do?

Just realized I had not installed xquartz properly (had to do it off of the xquartz website), then had to delete my build and start over to get it to work. You might want to add those instructions to the README. OSX versions after 10.6 do not come with x11.

Where else would you get it other than the website?

Hi Davis,
You can install through homebrew on Macs now using Cask (in short, Cask is a brew tap that extends homebrew to install in /Applications/ folder, e.g., it also has google-chrome, amongst many other apps)… at this point though it never made sense to me why not just to download from website directly (brew cask requires sudo rights + doesn’t install in brew Cellar (i.e. /Cellar/, which is where brew installs)— but in some cases it is handy and or the only option (say for like an application that typically is only on windows might be offered by brew cask)
Anyways, seems I am always asking you questions— so figured might as well give an answer for a change lol :)
Cheers,
Joe

On Jun 2, 2017, at 6:58 PM, Davis E. King<EMAIL_ADDRESS>wrote:
Where else would you get it other than the website?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/davisking/dlib/issues/624#issuecomment-305927473, or mute the thread https://github.com/notifications/unsubscribe-auth/AEBm5Q_kQLGGQU9md5BNp3glnk-UXgODks5sAJOGgaJpZM4Nu3I8.

Ah, darn.  brew seems to include a lot of broken packages.  Pretty regularly people will contact me about something like this and really their problem is that brew's package maintainers have broken something.  I guess X11 is now on that list of "things brew is messing up" :(
Thanks for the heads up though :)  If you or anyone encounters this again it would be cool if someone could figure out a way to catch this bad version of X11 inside cmake and avoid it or at least give a useful diagnostic message.

I actually had an issue with this as well (just recently when I got a new MacBook )— maybe even worth noting on under website FAQs or something for us Mac users  :)
I mean, the problem was a trivial fix once realized— I couldn’t compile anything with involving GUI headers or using flag -X11… took me only a minute to realize the problem, but perhaps this was because it was not too long before that I used cask to install xquartz, at which point I changed to version directly from website.

On Jun 4, 2017, at 3:11 PM, Davis E. King<EMAIL_ADDRESS>wrote:
Ah, darn. brew seems to include a lot of broken packages. Pretty regularly people will contact me about something like this and really their problem is that brew's package maintainers have broken something. I guess X11 is now on that list of "things brew is messing up" :(
Thanks for the heads up though :) If you or anyone encounters this again it would be cool if someone could figure out a way to catch this bad version of X11 inside cmake and avoid it or at least give a useful diagnostic message.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/davisking/dlib/issues/624#issuecomment-306060502, or mute the thread https://github.com/notifications/unsubscribe-auth/AEBm5VSaKcVCRdLYG-DTxDLOKwrnHTHGks5sAwF4gaJpZM4Nu3I8.

Yeah, well, turns out most people don't read documentation.  And the more documentation you add the less likely they are to read it.  It's way better if cmake can detect this and then print out a big error message that tells them what to do.  Although, pretty often I get people posting questions where they copy and paste the error message that tells them exactly what to do to solve their problem.  I then have to literally copy and paste the error back to them and they go "finally, I couldn't find that information anywhere!".  Except they literally posted that themselves.  It's crazy.  That's how bad a lot of people are at reading documentation.
Anyway, if you could figure out what is going on with cask and update the cmake scripts so they print a message about this I would be forever grateful :)

Very true/ good point… And yeah, for sure, I will look incorporating this into cmake sometime this week.

On Jun 4, 2017, at 3:40 PM, Davis E. King<EMAIL_ADDRESS>wrote:
Yeah, well, turns out most people don't read documentation. And the more documentation you add the less likely they are to read it. It's way better if cmake can detect this and then print out a big error message that tells them what to do. Although, pretty often I get people posting questions where they copy and paste the error message that tells them exactly what to do to solve their problem. I then have to literally copy and paste the error back to them and they go "finally, I couldn't find that information anywhere!". Except they literally posted that themselves. It's crazy. That's how bad a lot of people are at reading documentation.
Anyway, if you could figure out what is going on with cask and update the cmake scripts so they print a message about this I would be forever grateful :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/davisking/dlib/issues/624#issuecomment-306062211, or mute the thread https://github.com/notifications/unsubscribe-auth/AEBm5TtG1dGY9-NpZE0c8faBDLpCr2xIks5sAwhGgaJpZM4Nu3I8.

riding the same boat here


Not Starting Apps | only realignment Apps from Workspaces

Description of the new feature / enhancement
It woud be nice, if shortcuts for Workspace on start not open the programs new, but already opened programs in the workspace are positioned accordingly.
Scenario when this would be used?
The background is that there are different work situations with different requirements (number of monitors) and you don't want to constantly restart programs via the workspace shortcuts
Supporting information
No response

/dup #34571


jẹ́kí should not be use with increments

Since jẹ́kí is use for creating variables it makes no sense using it to increment for example fún ( jẹ́kí i = 0 ; i < 5 ; jẹ́kí i = i + 1 ;)   {},  jẹ́kí i = i + 1 should be i = i + 1 since variable i as been created, no point creating it again and I don’t see any reason why we should use a keyword to assign values to variables

Thank you for your input. The purpose of yorlang is to allow beginners to interact with programming concepts and syntax in their native tongue.
So the idea of jeki in yorlang is that it should be used whenever you are initializing and re-assigning a variable so that what is going on is clear to a beginner.
More or less we are allowing the beginner to let i be 0 and later when he is incrementing it, the beginner is still aware syntatically that he is simply letting a be 1.
It's the same reason why i++ and i-- are not supported. I'm only trying to make things as clear as possible.
We should also remember that yorlang is not a commercial language. It just a stepping stone to helping them get familiar with programming concept and syntax in the language they understand.
They must still learn the commercial languages that you and I know

Another thing to note, using jeki when re-assigning a variable does not recreate the variable, it simply updates its value in memory.
Following my php analogy, $a = 1; changing it to $a = 2; will not recreate the variable $a. It will simply update its value and the same applies in yorlang


Currency - Visually display the difference between $0.00 and NULL

Would like to support currency values of  $0, NULL (no value) and valid amounts and have it displayed so the user can tell the difference between a value of $0.00 and NULL (no value).
Ideally, when a null is stored the control should be blank when the focus leaves the control (its OK if the mask shows $0.00 on focus/hover).
When a $0 is stored the control should show $0.00 (even when not hovered or focused) - as it does with a valid amount ($1.00).
http://jsfiddle.net/a4uhkh5p/1/

@MS37 ,
I totally agree, but the current implementation of the numeric alias does not allow it.  Once I can remove the postFormat fn from the numeric alias, I will implement it.

Sounds good. Thanks!

Hi,
I don't know if it is bad posting this here, but i have the same question and tough opening a new issue would be a bit double. I saw there was great progress on milestone 3.2 any thoughts on when this will be possible or maby a temporarily workaround?
Thanks,
Ricardo

Hi
Sorry to spam this issue but as with silent kill am after a workaround. I've tried extending the onUnmask call locally to my use of the currency alias and this works some of the time but unfortunately falls over as soon as you use back space to clear the value in the input.
any ideas would be gratefully received.
cheers

Sorry i also tried extending and ran into more problems, unfortunately i didnt had any time to look in to it any further.
I have my mask setup like this although not 100% what i want:
mask: '9{0,*}[.99{0,5}]',
greedy: false,
autoGroup: true,
digitsOptional: false,

@MS37 , @sillentkil , @electroholic ,
Can you have a try with the current implementation.  Visually it is the same, but the behavior is different and also a 0 input is submitted on postback.

What about the non-visual part? The backend needs to know whether the user entered 0.00 or NULL (no-value). Tested it in current dev and it's still always getting "0.00" instead of "".

Tested the update. Works beautifully.

Tested the update in d558785.
After entering 0.00, I was not able to enter NULL (no value) anymore.
My settings:
    $('#field').inputmask('decimal', {
        integerDigits: 7,
        digits: 2,
        radixPoint: ',',
        rightAlign: false,
        digitsOptional: false,
        placeholder: '0',
        allowMinus: false,
        allowPlus: false
    });

Thansks,
Mauricio


Support for Vitest

Just signed up for Buildkite because I think we're starting to hit the limits of GitHub Actions, and the first thing I went to do was configure our tests, which use vitest. Many folks have moved from jest to vitest for performance and to match increasingly vite-based stacks.

Hi @tmcw 👋🏽, thanks for reaching us with your request. We don't have a capacity to support vitest at the moment due to other priorities. At the moment, you can use vitest's built-in JUnit Reporter and upload the XML file to Test Analytics. Alternatively, you can write your own custom reporter to upload your test results as a JSON file to Test Analytics.
You are also welcome to open a PR to add vitest support to this collector 😊


Fix latest folder in releases

Changes
The gcs-upload task by default uses "gsutil cp -r" to copy the local folder with release files to the latest folder.
That works well if "latest" does not exists, otherwise it creates a "" folder into "latest", which is not the desired behaviour.
The "deleteExtraFiles" flag in the task means that "gsutil rsync -r" is used instead, which achieves the correct behaviour in all cases ("latest" exists or not.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/kind misc

/easycla


Hold Conversation with OGC

The project team will be meeting with Josh C. from the OGC on June 14.
Acceptance Criteria:

[x] Hold conversation
[x] Save recording in Teams channel
[x] Document findings in Teams channel

@jaimiebutton - let's close this one off :)

@jaimiebutton - do you remember off hand what sprint this was completed in?

@LindsayMacfarlane Yes! It was July 11.


Add Google Analytics

Codecov Report

Merging #26 (15271e6) into master (5125fd9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines           40        40
  Branches         2         2
=========================================
  Hits            40        40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5125fd9...15271e6. Read the comment docs.


Additional Discord channel post

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Additional options for discord to post when awards are assigned, pilot promotions, monthly profits/loss, news, touring event, and perhaps new pilot joins?
Regards,
Nelis Coetzee
COO - African Virtual Airline Association

News and new pilot signup is already a part of v7 discord notifications.


Implement part of the SMA numpy operator

In addition to this partial implementation,  I've tried some changes in the code organization & style (https://docs.google.com/document/d/1cgh_1lawKu2xD_QIZVv7JM9h3cIBkyFhO-EIIfR-IO8/edit#heading=h.yikhuc3t00vk).

One this pr is approved, I can continue working the SMA.

Thanks


Typo "NuGet.config files"→"NuGet.Config files"

https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-nuget-update-source
#PingMSFTDocs
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

According to the reference docs from NuGet, the config file is either NuGet.Config or NuGet.config. See nuget.config reference. I do not think this PR is necessary.


Choice the default bundler (snowpack, vite, webpack or wmr)

We want to choose a standard bundler for release 1.2 @leanup/stack and clarify the functional coverage in this ticket.

feature
snowpack
vite
webpack (default)
wmr

start (open browser)
✔
✔
✔
⌛

serve
✔
✔
✔
⌛

build(bundle)
⌛
✔
✔
⌛

preview
❌
✔
❌
⌛

proxy
❌
✔
✔
⌛

replace
✔
✔
✔
⌛

postcss
✔
✔
✔
⌛

esbuild
✔
✔
✔
⌛

minify
✔
✔
✔
⌛

less
✔
✔
✔
⌛

sass
✔
✔
✔
⌛

image
⌛
✔
✔
⌛

pwa
⌛
⌛
✔
⌛

angular
✔
⌛
✔
⌛

angularjs(babeljs)
⌛
⌛
✔
⌛

aurelia
⌛
⌛
❌
⌛

lit-element
✔
✔
✔
⌛

preact
✔
✔
✔
⌛

inferno(babeljs)
⌛
⌛
✔
⌛

react
✔
✔
✔
⌛

vanilla
✔
✔
✔
⌛

vue
⌛
✔
✔
⌛

vue3
⌛
✔
✔
⌛

svelte
✔
✔
✔
⌛

Preview: https://github.modevel.de/poc/next/

symbol
meaning

✔
ready

⌛
open

❌
missing

The decision fell on webpack because of its power and stability.  Alternatively, we will continue to pursue vite for the time being.

https://github.com/leanupjs/leanup/issues/3897