Remove println statements accompanying errors

This replaces println(ex); throw(str) with an error type, so that if macro expansion fails within a try-catch block, nothing is printed.
Closes https://github.com/mcabbott/Tullio.jl/issues/26
Example of new behaviour:
julia> try
       macroexpand(Main, quote
       @avx for i = 𝒶𝓍i
           if i ∈ (axes)(var"𝛥≪rand(10)≫", 1)
               var"𝛥≪rand(10)≫"[i] = var"𝛥≪rand(10)≫"[i] + 𝛥ℛ[i]
           else
               (zero)((eltype)(var"𝛥≪rand(10)≫"))
           end
       end
       end)
       catch err
       end  # silence!

julia> @macroexpand @avx for i = 𝒶𝓍i
           if i ∈ (axes)(var"𝛥≪rand(10)≫", 1)
               var"𝛥≪rand(10)≫"[i] = var"𝛥≪rand(10)≫"[i] + 𝛥ℛ[i]
           else
               (zero)((eltype)(var"𝛥≪rand(10)≫"))
           end
       end  # similar output to before:
ERROR: LoadError: Don't know how to handle expression.
if i ∈ axes(var"𝛥≪rand(10)≫", 1)
    #= REPL[10]:3 =#
    var"𝛥≪rand(10)≫"[i] = var"𝛥≪rand(10)≫"[i] + 𝛥ℛ[i]
else
    #= REPL[10]:5 =#
    zero(eltype(var"𝛥≪rand(10)≫"))
end
Stacktrace:
 [1] push!(ls::LoopVectorization.LoopSet, ex::Expr, elementbytes::Int64, position::Int64)
   @ LoopVectorization ~/.julia/dev/LoopVectorization/src/graphs.jl:754
 [2] add_block!
...

Great, done!

Codecov Report

Merging #172 (1deb12b) into master (b156769) will increase coverage by 0.66%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   92.75%   93.42%   +0.66%
==========================================
  Files          32       32
  Lines        4516     4195     -321
==========================================
- Hits         4189     3919     -270
+ Misses        327      276      -51

Impacted Files
Coverage Δ

src/graphs.jl
86.95% <14.28%> (-0.06%)
:arrow_down:

src/costs.jl
83.33% <0.00%> (-2.39%)
:arrow_down:

src/broadcast.jl
84.90% <0.00%> (-2.00%)
:arrow_down:

src/lower_constant.jl
83.15% <0.00%> (-2.00%)
:arrow_down:

src/mapreduce.jl
85.71% <0.00%> (-1.13%)
:arrow_down:

src/vectorizationbase_compat/contract_pass.jl
81.03% <0.00%> (-0.79%)
:arrow_down:

src/lower_store.jl
92.53% <0.00%> (-0.47%)
:arrow_down:

src/filter.jl
88.88% <0.00%> (-0.40%)
:arrow_down:

src/operations.jl
90.00% <0.00%> (-0.36%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b156769...8efd26b. Read the comment docs.

I'll merge and issue another release once tests pass.

Perhaps add a
@test_throws LoadError @macroexpand @avx for i = 𝒶𝓍i
    if i ∈ (axes)(var"𝛥≪rand(10)≫", 1)
        var"𝛥≪rand(10)≫"[i] = var"𝛥≪rand(10)≫"[i] + 𝛥ℛ[i]
    else
        (zero)((eltype)(var"𝛥≪rand(10)≫"))
    end
end

?

Done. Assuming that this kind of if-else is something unlikely to ever work, I guess. It was just the first one I happened to pick up for quick tests locally.
By the way, there isn't an AVX-friendly way of doing that, is there? I mean of testing some index & returning zero (or some other padding) out of bounds? Something like ifelse(i in axes(ys,1), ys[i], 0.0) will actually read out of bounds

Yeah, maybe it's better to have a wonkier example now, but I figured it wouldn't be that bad to change it later.

By the way, there isn't an AVX-friendly way of doing that, is there? I mean of testing some index & returning zero (or some other padding) out of bounds? Something like ifelse(i in axes(ys,1), ys[i], 0.0) will actually read out of bounds

There is, see here for an example.
If you use ? instead of ifelse, LoopVectorization will convert that into a masked load.
So you'd want to do something similar to the linked line.
Instead of
xim = i > ifirst ? x[Ipre, i-1, Ipost] : xi

you'd want
((i >= first(axes(ys,1))) & (i <= last(axes(ys,1)))) ? ys[i] : 0.0

and that should work.
AVX has a masked move instruction:
https://www.felixcloutier.com/x86/vmaskmov
While with AVX512, it of course uses a regular move but applies a mask.

That looks great, thanks! Will try this out.


Lint/ShadowedException fails for rescue nil

Test code
begin
  # something
rescue nil
end

Actual behavior
An error occurred while Lint/ShadowedException cop was inspecting /test.rb
Scanning /test.rb
An error occurred while Lint/ShadowedException cop was inspecting /vagrant/sellery/app/test.rb.
undefined method `<' for nil:NilClass
/home/vagrant/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/rubocop-0.41.1/lib/rubocop/cop/lint/shadowed_exception.rb:63:in `block (2 levels) in contains_multiple_levels_of_exceptions?'

RuboCop version
$ rubocop -V
0.41.1 (using Parser <IP_ADDRESS>, running on ruby 2.3.0 x86_64-linux)

I can update the code to safeguard against this, but when I try out an example for rescuing nil, it does not appear to be valid Ruby. @bbatsov and @jonas054 what are your thoughts on this?
[2] pry(main)> begin
[2] pry(main)*   1/0
[2] pry(main)* rescue nil
[2] pry(main)*   puts 'rescued'
[2] pry(main)* end
TypeError: class or module required for rescue clause

What version of ruby are you using?
Have you tried putting that code into a *.rb file instead of pry?

The example that I posted was run against Ruby 2.3.0. I tried it in a .rb file and had the same result. I repeated the same test for multiple versions of Ruby. It appears that rescue nil is valid in Ruby 1.9.3.
# test.rb
begin
  1/0
rescue nil
  puts 'rescued'
end

rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ rbenv local 1.9.3-p484
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ ruby test.rb
test.rb:2:in `/': divided by 0 (ZeroDivisionError)
        from test.rb:2:in `<main>'
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ rbenv local 2.0.0-p598
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ ruby test.rb
test.rb:3:in `rescue in <main>': class or module required for rescue clause (TypeError)
        from test.rb:1:in `<main>'
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ rbenv local 2.1.6
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ ruby test.rb
test.rb:3:in `rescue in <main>': class or module required for rescue clause (TypeError)
        from test.rb:1:in `<main>'
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ rbenv local 2.2.4
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ ruby test.rb
test.rb:3:in `rescue in <main>': class or module required for rescue clause (TypeError)
        from test.rb:1:in `<main>'
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ rbenv local 2.3.0
rrosenblum@C02NV0KSG3QN:~/work/rubocop (master u=)$ ruby test.rb
test.rb:3:in `rescue in <main>': class or module required for rescue clause (TypeError)
        from test.rb:1:in `<main>'

According to the output of rubocop -V that you posted, it looks like you are running Ruby 2.3.0. Can you verify what version you are running against?
I can update this cop to account for rescue nil. Looking at the output running of against Ruby 1.9.3, it appears that rescue nil does not actually rescue anything. I would like to do a bit more research on this, and it seems like we should have a cop that recommends against rescue nil. This may prove to be a bit tricky because rescue nil is valid in the modifier form.

Sorry, I think I misunderstood what you meant by

it does not appear to be valid Ruby.

To clarify, writing
begin
  1/0
rescue nil
  puts 'rescued'
end

is perfectly correct from a syntax perspective.
However, it does raise a TypeError, when the rescue clause is called.
So you are probably right, it is an edge-case. We just ran into this because of a code-smell. Essentially we had something like
begin
  puts('This never fails')
  puts('Thus we never run into the TypeError`)
rescue nil
  puts('rescued')
end

in our code. So we never ran into the TypeError and I only noticed this, when running your Cop against our codebase. So maybe we should just have a cop to guard against rescue nil here. Not sure if something like this is in scope for rubocop.

Thank you for the clarification, I believe that we are on the same page now. Since this does not produce a TypeError in Ruby 1.9.3, we will need to add a safeguard to this cop.
RuboCop can check for rescue nil and recommend against using it. We will need to do some cleanup around how we check for a rescue modifier in cops other than Style/RescueModifier.


streamline textual output of X509 certs and CRLs: remove empty lines, add/remove tag, correct indentation

This makes X.509 printing slightly more consistent.
When viewing textual certificate output, e.g., of the x509 app, I was often wondering why there is an empty line between the output of "X509v3 Authority Key Identifier:" and "X509v3 Basic Constraints:".
Moreover, the value printed for "X509v3 Authority Key Identifier:" is prepended by the tag keyid", which is not the case for "X509v3 Subject Key Identifier:", such that the output in particular for self-signed certs looks a bit odd, for instance:
            X509v3 Subject Key Identifier:
                11:49:46:19:2A:4E:4D:D1:C8:FB:79:55:3D:81:99:22:EE:34:4F:22
            X509v3 Authority Key Identifier:
                keyid:11:49:46:19:2A:4E:4D:D1:C8:FB:79:55:3D:81:99:22:EE:34:4F:22

            X509v3 Basic Constraints:
                CA:TRUE

This PR streamlines such output to, in the above example,
            X509v3 Subject Key Identifier:
                11:49:46:19:2A:4E:4D:D1:C8:FB:79:55:3D:81:99:22:EE:34:4F:22
            X509v3 Authority Key Identifier:
                11:49:46:19:2A:4E:4D:D1:C8:FB:79:55:3D:81:99:22:EE:34:4F:22
            X509v3 Basic Constraints:
                CA:TRUE

The tag keyid: is left out only if the X509v3 Authority Key Identifier, as usual, does not also include an issuer or serial sub-field.
Also other (less common) occurrences of empty lines are eliminated. This was more effort than expected because the handling of newlines is implicit and spread across many places. I did not recognize a consistent design behind it.
I also found that the output of signature values at the end of certs and CRLs is slightly inconsistent because there no tag is given for the signatureValue and the indentation of the actual value is 9 rather than 8 (= 2 * 4). This is also corrected, such that, for instance,
    Signature Algorithm: sha256WithRSAEncryption
         04:8f:c3:77:48:06:29:c0:8d:66:2e:6b:48:a3:b3:e0:dd:5b:
         0a:e7:a4:0b:7e:72:91:fc:37:29:7f:81:1e:60:66:7b:ba:94:

becomes
    Signature Algorithm: sha256WithRSAEncryption
    Signature Value:
        04:8f:c3:77:48:06:29:c0:8d:66:2e:6b:48:a3:b3:e0:dd:5b:
        0a:e7:a4:0b:7e:72:91:fc:37:29:7f:81:1e:60:66:7b:ba:94:

The overall effect of this PR on printing certs can be seen, at the example of one of the test certs at https://github.com/openssl/openssl/compare/master...siemens:X509V3_EXT_val_prn-multiline-fix?expand=1#diff-da7c216b91096b818848e5b53012606c

[x] tests are added or updated

I had overlooked handling one minor change request, which I just have done.
I've also rebased this PR (the CI builds went through except for two cases with some unrelated package issue with Travis CI).
@mattcaswell, is there anything more to do?

Travis failures are not relevant. Needs second review.

Thanks @levitte for the second review&approval.
I've meanwhile rebased the PR again and the (unrelated) Travis CI issue is gone.
Yet this time AppVeyor got stuck (while it worked fine last time).

Appveyor failure is unrelated to this PR though.

Pushed - thanks. I squashed the last commit.

This fixed https://github.com/openssl/openssl/issues/7284.

I've just discovered this change as a result of changing the Oracle ZFS Storage Appliance code that manages certificates over from 1.0.2 to 3.0.10. The area of code that was impacted for us is turning the certificate into our XMLRPC/JSON format for display in the UI, for the authorityKeyIdentity. We generate an array of name/value pairs because you need to know what the value represents, eg keyid, issuer, serial etc.
It seems that the original intent was to change the output of the openssl(1) command and rightly so there was concern raised about breaking applications.  I agree that nothing should be attempting to parse the human readable output of openssl(1). As such I would have expected this change should have been implemented in openssl(1), instead of deep inside the x509 code in libcrypto.
The way this change has been implemented it actually breaks the API callers.  While I understand and appreciated there was no expectation of API/ABI stability between 1.0.x and 3.0.x this change is very subtle and was very difficult to track down.
It seems wrong to me that the API was changed to no longer report that the name of value is 'keyid' and just return the value with a name of NULL if it is the only authorityKeyIdentity present.  So unless I'm missing something, what happens now is that the 'keyid' valuename is only added if either or both of issuer/serial are also present.  So the caller now needs to determine if the valuename was NULL and know that means the value is a 'keyid' otherwise look at the name to determine if the value is a serial or issuer based on the non-NULL valuename.  Is that correct ?

Yes, it is correct.
Unfortunately it would be basically impossible to make the change in openssl(1) only. On the other hand it is true that the conditional removal of the keyid: prefix makes this really hard to parse.

Sorry to hear that this change of 4+ years ago caused some trouble.
In retrospect, it should have been mentioned in CHANGES.md
(though I'm not sure if you had a look at it when tracking down the issue).
Correct that the change affects the libcrypto API, not only the apps. Yet as I wrote in https://github.com/openssl/openssl/pull/6226#issuecomment-458246971
also the output of those API functions is meant for human consumption, not for machine parsing.
Unfortunately, X509_print() and friends are still undocumented,
but from their names it should be clear that one better should not base a cert (format) conversion function on them.


Pay for opening a new keep

When creating a new deposit payment should be forwarded to keep factory for opening a new keep.
Currently on deposit creation payment is stored in the deposit contract as a funder bond. This solution should remain, but we should add transferring some part of the payment to the keep as payment for opening a new keep.

Closed by #436


Automated build creation needs UI to select a repo from a github org

User user in both docker hub and github organization org wishes to create an automated build from github.com/org/repo, but the page at https://registry.hub.docker.com/builds/github/select/ only presents repo list from github.com/user, even though user has full access to github.com/org.
It is possible to hack this by selecting e.g. github.com/user/repo and then changing the page url https://registry.hub.docker.com/builds/github/user/repo/ to https://registry.hub.docker.com/builds/github/org/repo/.
It would seem more reasonable for the initial build page to show all orgs and repo of which user is a member.

Hello @rlister, since this is a feature request for the Docker Hub, could you create a feature request via http://support.docker.com or sending an email to<EMAIL_ADDRESS>Issues with Docker Hub are not handled through this issue tracker.
Thank you!

Emailed support, thanks.


How can I use VirtualBox, Vagrant, Nginx together in Windows10 v1903?

I'm watching a course on learning Nginx. This course demands that I should have all 3 (VB, Vagrant, Nginx) running on my machine. I've Win10-64bit-v1903 machine. Which has Bash (version 4.4.20(1)-release (x86_64-pc-linux-gnu). And inside bash, I've Ubuntu 18.04.3 .
Now my problem is that most of the commands demand that I be under Linux/Ubuntu. But inside Ubuntu, VB (and perhaps Vagrant also) isn't working/behaving well. And outside bash, (inside Windows), Nginx doesn't behave/work well.
In Bash Ubuntu, VB installs very well without errors, but when running, gives this error:
WARNING: The character device /dev/vboxdrv does not exist.
         Please install the virtualbox-dkms package and the appropriate
         headers, most likely linux-headers-Microsoft.

         You will not be able to start VMs until this problem is fixed.
5.2.32_Ubuntur132056

And, although my attention is yet on running VB only, but Vagrant also seems to be throwing some errors inside bash ubuntu. Aren't they supposed to run inside bash?
Is there some work around to my problem (I only have 1 machines, running win10 on it).

Simple: It's not possible to do that with 1903.
TLDR:
Due WSL 1 shipped with 1903 does not have a "real" kernel, it's not possible to load kernel driver.
And maybe (i have never tested, just guess) you can get this work in WSL 2 which using Hyper-V technology, but you can't get best performance with nested virtualization.
Since you are using Vagrant VM to writing code or running application, host environment doesn't affect things inside VM, so you can try to install VirtualBox and Vagrant on you Windows, install nginx in WSL.
All disk partition in Windows already mounted in /mnt, and localhost port listen was connected between WSL and Windows.
BTW: Files in WSL can be access on Windows with run explorer.exe . in bash, or type "\wsl$" in explorer's address bar.

Oracle VM VirtualBox can be used on a Windows host where Hyper-V is running. This is an experimental feature.
No configuration is required. Oracle VM VirtualBox detects Hyper-V automatically and uses Hyper-V as the virtualization engine for the host system. The CPU icon in the VM window status bar indicates that Hyper-V is being used.
Oracle said vb can auto detect hyper-v and run with it,but i always stuck.

@zyazhb WSL 1 didn't use Hyper-V

Oracle VM VirtualBox can be used on a Windows host where Hyper-V is running. This is an experimental feature.

Windows QEMU too in recently (for some value of recent). I had tried it when WSL2 came out last spring.
These are third-party products; you can get more information from their respective purveyors.


Upgrade to 3.0 API

When I first tried I got "Invalid API key" and it seems my newly created account is only valid for the newer 3.0 API. After changing 2.5 to 3.0 in the $url in WeatherClient everything works fine. I guess maybe this should be a config option?

Thank you for the suggestion. I will work on it.

Hi @DanielMalmgren , I have released v1.8.0 with version compatibility. Please update package.


XIB

I want to implement XLPagerTabStrip in viewcontroller. But I don't use storyboards. All my view controllers made by XIB. So When I am using BaseButtonBarPagerTabStripViewController it gives me error.
Can you give a example working with XIB files

Have the same problem 😅It won't let us connect the existing outlets (buttonBarView for ex.)

@shakhzodurinboev @shemchavez have you tried to right click on the view (UIScrollView for ex.) then connect the outlet from "New Referencing Outlet"  then drag into File's Owner ?
it's working fine with XIB for me

@edityomurti  Thank's it a
lso worked for me.


Create Predictable Streaming Measurement example and write automated tests

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Created a new example called Sample Streaming Measurement (Py) that returns a predictable stream of data based on the inputs. Wrote automated tests against this new example measurement.
Why should this Pull Request be merged?
We wanted to write some automated tests against a v2 measurement that streams data. The current example that does this, UI Progress Updates, returns random data, which won't allow us to write very thorough automated tests. By adding an example that returns predictable responses, we can now have automated tests.
What testing has been done?
This PR adds new automated tests to ensure v2 measurements that stream multiple responses works in Python.

Could you post a screenshot of the UI?

Is it the same as the C# version?

Could you post a screenshot of the UI?

I've seen the C# UI so no need unless it's different.

Could you post a screenshot of the UI?

@DelpireNI I've seen the C# UI so no need unless it's different.

I posted a screenshot anyway.


JIT: Autotune matmul tiling 2d unroll

Loop unrolling was always activated in tiling 2d, which had severe performance deterioration on some devices (metal, namely)
It's now autotuned.

No change on nvidia, as expected: https://burn.dev/benchmarks/community-benchmarks/?version1=07a61a1cec8207256ecd6214e2ab9612647097d9&versionLabel1=Main&version2=2c22e70090cdc54385c742bf3e11ceaa3cfb62fb&versionLabel2=Fix&backend=All&device=All&name=All&os=Pop!_OS+22.4.0+(jammy)+[64-bit]&sysHardware=Any&user=SharpPrecision&search=true


Add new SVGS

Added logos for:

#71
#85
Peerlist
Product Hunt
Cursor AI
Warp Terminal
Calendly
Patreon

Thanks 🚀🚀✨


Advanced Tab - Extra Settings

This field is the Json that describes the options to call Lock with. It'll override any other option set here. See all the posible options here (For example: {"disableResetAction": true })

Typo:  possible
Question: "It'll override any other option set here." Does it refer to the Advanced Tab only?

No, also the appearance ones


Adapt client usage in integration tests

How to categorize this PR?

/area testing
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR adapts the usage of kubernetes clients in the integration test framework and all integration tests to the changes made in #2449.
Basically it just replaces all occurences of kubernetes.Interface.Client() with kubernetes.Interface.DirectClient(). This way, the integration tests explicitly do not rely on cached clients and always use direct clients when talking to clusters. This is done because the effort of implementing a clean and proper way of using cached clients in our integration tests seems to be huge and also not worth it, as we wouldn't profit too much from cached clients there.
/invite @gardener/test-infra-maintainers
Which issue(s) this PR fixes:
Part of #2414
Special notes for your reviewer:
✅ Depends on #2449, will rebase and drop the commits from #2449 once it is merged.
Please select the last commit to review the changes of this PR.
Release note:

NONE

/assign @schrodit @dguendisch
/invite @schrodit @dguendisch

/ready


[Add-ins] Link to preview reqt. set page

Fixes https://github.com/OfficeDev/outlook-dev-docs/issues/709

Docs Build status updates of commit c1d7116:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/add-and-remove-attachments-to-an-item-in-a-compose-form.md
:white_check_mark:Succeeded

docs/add-ins/get-or-set-the-location-of-an-appointment.md
:white_check_mark:Succeeded

docs/add-ins/outlook-on-send-addins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Allow disabling AutoThrottle bypassing

The downloader middleware of scrapy-zyte-api was created to prevent AutoThrottle to affect requests driven through Zyte API, and instead let Zyte API itself control throttling on the server side, sending HTTP 429 responses when a spider is hitting a website too hard.
Relying on Zyte API to handle per-website throttling should most often be the best solution, since Zyte API can have a better picture of the traffic that a website can support and having central throttling control allows running multiple spiders against the same domain in parallel without increasing the overall concurrency to the upstream website.
However, some users might want to let AutoThrottle do its thing anyway. We could implement a setting to let them do just that.

Currently as a workaround users can use CONCURRENT_REQUESTS_... options; it should give similar results (see https://docs.scrapy.org/en/latest/topics/autothrottle.html#how-it-works), but not exactly the same.

Do we still want this? I am not so sure anymore, however trivial it may be to implement.

is there any update on this one?
I see the attached scrapy PR where it's allowing to disable autothrottle per request / spider by setting download_slot and throttle to false
Will there be a follow-up PR to fix zyte-API to make it respect auto_throttle?
think this would be a useful feature as zyte-api is visiting the site at a rapid rate (close to 180 requests per minute) for a very long time without slowing down
I am told to use the CONCURRENT_REQUESTS_PER_DOMAIN and CONCURRENT_REQUESTS_but as @kmike  suggested its not the best way to handle it


Assert minimum version of bwrap on host

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on Feb 24, 2018, 10:45
We check for ostree and other dependencies, right now we will just fail horribly if we encounter a version of bwrap which does not support a CLI option we use.
We need to assert that the installed version of bwrap supports the CLI options we use.

In GitLab by [Gitlab user @tristanvb] on Feb 24, 2018, 10:47
mentioned in merge request !288

In GitLab by [Gitlab user @milloni] on Apr 1, 2018, 18:23
assigned to [Gitlab user @milloni]

In GitLab by [Gitlab user @milloni] on Apr 1, 2018, 19:43
mentioned in merge request !350

In GitLab by [Gitlab user @milloni] on Apr 11, 2018, 08:11
mentioned in merge request !379

In GitLab by [Gitlab user @tristanvb] on Apr 26, 2018, 06:22
This was fixed by manual merge of !379.

In GitLab by [Gitlab user @tristanvb] on Apr 26, 2018, 06:22
closed


feat: Page navigation using keyboard, active current page on dropdown

User can Go to the Next or Prev Page using the Keyboard's Left or Right Button
Using the / Key user can toggle the Jump To Button
Showing Current active Menu Item based on the current page

Demo - https://jmp.sh/JkSgDriW

can u get rid of the merge conflicts?

I think forward and back keys are already in
Seeing a few merge conf in this one, can u add the / logic in a new one?


"Embedded binary is not signed with the same certificate as the parent app" error when building

Disclaimer: I'm 99.99% sure this issue has nothing to do with this repo, and it's just an(other) Xcode bug, I just figured I'd open this to see if other people run into the same thing.
I was super excited to use this extension, but I'm getting the following error:

I do have the same team in both targets:

But of course Xcode is doing something wrong... or maybe I am? I hadn't used automatic signing yet, so maybe I'm doing something wrong.
Note: I'm on Xcode 8.0

See the resolution in the linked issue. I've reverted the Copy Files phase, which should resolve this.


Improve error handling

Need to improve the error handling so that OneView errors are displayed nicely and not as large JSON strings.  Might need some UX here to determine which fields on the OV error should be shown.

This is going to expose my lack on JSON knowledge. @danielreed, what does the JSON string look like? Ideally, we present errors in the same way as we do in OneView.

@gregfuruiye -- Depends on the error.  Here's an error when trying to connect to a bad IP:
{
"name": "RequestError",
"message": "Error: connect EHOSTUNREACH <IP_ADDRESS>:55550",
"cause": {
"code": "EHOSTUNREACH",
"errno": "EHOSTUNREACH",
"syscall": "connect",
"address": "<IP_ADDRESS>",
"port": 55550
},
"error": {
"code": "EHOSTUNREACH",
"errno": "EHOSTUNREACH",
"syscall": "connect",
"address": "<IP_ADDRESS>",
"port": 55550
},
"options": {
"method": "GET",
"uri": "http://<IP_ADDRESS>:55550/inventory",
"json": true,
"headers": {
"Accept": "application/json",
"Content-Type": "application/json"
},
"resolveWithFullResponse": true,
"simple": true,
"transform2xxOnly": false
}
}

I think at the very least we should inspect the OV error response body to determine what we want to show the user.  We don't have a lot of space to display all of the error information, but maybe we should display:
statusCode, errorCode, message, and recommendedActions
This is what the response body looks like from OV:
"response": {
"statusCode": 404,
"body": {
"details": "",
"errorSource": null,
"nestedErrors": [],
"recommendedActions": [
"Verify that the profile exists and try again."
],
"errorCode": "ProfileNotFoundException",
"data": {},
"message": "The requested profile cannot be retrieved  [id=fdb4be1d]."
}
}


Where to get .bin file to update firmware?

Hi, I have just built the programming shield, and can access the armsid tester software via puTTY, etc.  However I can't find the .bin file to update my ARMSID to the latest version?  (mine says FW VERSION:2.9)
I also do not see as many options as in the screenshots when using the armsid tester software -- I only see options for 6/7/8,P,E,R,Q.  It says version 3.13.  Is this normal?
Thanks,

The screenshots are from ARM2SID, not ARMSID, so there are more options there. ARMSID firmware version is 2.XX, while ARM2SID version numbers are 3.XX. We try to keep the feature set the same, so XX is real version number ;-)
I have sent you the binary updater firmware to your gmail. Just unzip it and use asid213.bin to update your ARMSID to fw2.13. It is encrypted, so you must use the updater and integrated bootloader. Do not try to flash the firmware with any ST tools, otherwise you will delete the ARMSID integrated bootloader and brick you ARMSID.

Thank you, all updated and running well!  Also, it seemed that I get more options in the tester (ie ADSR bug fix menu) after I updated the firmware :).


CCC Output tables major groupings

Major groupings for industries and assets would be helpful since the names themselves are sometimes not that descriptive without such groupings.
The idea would be to have the name of the major grouping offset - so it is left aligned and the more detailed industries/assets under that are indented.

To add to this further, the current alphabetical ordering of industries or assets makes the tables difficult to read.  Industries should be ordered in accordance with NAICS code ordering, since people are familiar with that.  Major asset groups should be ordered: Equipment, Structures, IP, Land, Inventories.
When adding major groupings, we should change output tables from B-Tax to include average rates for the major groupings.
In addition, it'd be helpful to have an overall rate, across all assets/industries.

@PeterDSteinberg can you comment here on ideas for how this grouping would be accomplished? I'm thinking in terms of the JSON key-value pairs we get back for rendering. Perhaps we could have some kind formatting value included with every row - a string that indicates the grouping for row? then we could organize the rows by group. What do you think?

@Jason Do you have a screenshot of an analogous tables like what we'd want for B-Tax output?

@brendancol Here's an example of industry groupings:

What you can take from this is that I think it's nice to have the major grouping left aligned (and perhaps in bold font) and then the group members indented.
The output tables do not currently include the major groupings.  Let me know how  you'd like those tables formatted (e.g. major group identified in separate column or with some notation in the industry name) and I can do that.
I think we should have similarly formatted tables for "by asset", but there just have five groups: equipment, structures, intellectual property, inventories, and land.
Also, I have a particular ordering in mind for the industries and assets.  So let me know what needs to be done to the B-Tax output tables to ensure that we can order them in the web app.

@brendancol Something to think about - if we could make the tables expandable - e.g. just showing the major grouping and then the user clicks a "+" button to expand to the sub-industries, that'd be cool, but certainly not necessary.

@Jason, great thanks. I'm going to come up with a proposal which retains use of DataTables.  Keeping DataTables will significantly reduce the level of effort.

@jdebacker yeah go ahead and add any fields which would help with groupby.

@brendancol Ok - I'll update B-Tax output tables to have an additional column, "major_grouping", which will be a text field with the name of the major industry/asset grouping.
I'm also going to include values for averages across the group.  In this case, "major_grouping" will equal the industry or asset name.

@jdebacker sounds good.  Will major_grouping included aggregated values for all corporate/non-corporate categories?

@brendancol, yes, this is what I'm referring to in the last two sentences above.
as an example:
major_grouping	asset	mettr_c	mettr_nc
equipment	equipment	0.33	0.27
equipment	computers	0.25	0.23
equipment	furniture	0.34	0.31

@jdebacker is major_grouping the only groupby, or will there also be a minor_grouping?

@brendancol If you can handle it, I'd like to have a minor grouping for industry (but not asset).  e.g se the manufacturing breakout above (but most major groupings will only have one minor group).
I also would like a line for the overall averages for the variables (i.e., across all assets/industries).  For this, I thought it'd be put in the table as follows:
major_grouping  asset   mettr_c mettr_nc
overall     overall     0.35    0.33
equipment   equipment   0.33    0.27
equipment   computers   0.25    0.23
equipment   furniture   0.34    0.31

@jdebacker will there be a mettr_c_reform, mettr_c_baseline etc.?

@brendancol All the columns of output will remain the same - just adding new columns for the major groupings.  Should have been clear - example was simple to just quickly show how the major groupings would work with the asset/industry names.

@jdebacker @PeterDSteinberg @talumbau
At the moment, the btax/results.html now supports items which have a major_grouping property which would be a sibling to label and cells in each of the objects.

closed via #377


chore(*): vitest v2

Overview

Let's go to vitest v2
PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.23%. Comparing base (7eb9e9b) to head (43b3e99).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1075   +/-   ##
=======================================
  Coverage   84.23%   84.23%
=======================================
  Files          54       54
  Lines         552      552
  Branches      117      117
=======================================
  Hits          465      465
  Misses         82       82
  Partials        5        5

Components
Coverage Δ

@suspensive/react
97.05% <ø> (ø)

@suspensive/react-query
75.28% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/jotai
0.00% <ø> (ø)

@suspensive/promise
100.00% <ø> (ø)

@suspensive/react-await
100.00% <ø> (ø)

@suspensive/react-image
80.39% <ø> (ø)


Card: GT - Sunday Best

Adding file for Sunday Best

Marking Sunday Best

Did not merge this one because the build is failing.

So what was with the apostrophe-change anyway?

This seems to just be made of fail. And I apparently forgot the boot cost. I think it's back to the drawing board.

So what was with the apostrophe-change anyway?

with the normal apostrophes (' or "), everything in between them is considered a regular text.
but if you use `, you can do a variable substitution by using ${variable} in the text.


[libbacktrace] new port

Describe the pull request

What does your PR fix?
Fixes #15774

Which triplets are supported/not supported? Have you updated the CI baseline?
Only gcc and clang are supported

Does your PR follow the maintainer guide?
Yes (there are no guidelines for handling licenses, I have copied from other ports)

Thanks!


fix: correct translation string usage and JSX formatting in Popup confirm

What type of PR is this?
/kind bug

What this PR does / why we need it:
The translation and string concatenation in the Popconfirm component to ensure proper rendering of the confirmation message and handling of translations.
Which issue(s) this PR fixes:
Fixes # N/A
Special notes for your reviewer: N/A
Does this PR introduce a user-facing change?:
N/A

Signed-off-by: axif<EMAIL_ADDRESS>

Thanks for your translation, it's useful, but now we're developing a i18n cli tools for automatically translating, but now the cli in the status of WIP cc @chouchongYHMing, it will works in the mode of hybird including manual mode and auto mode, some of your translation is useful, but some are not we expected, like

we expected this kind of translation like ${i18nInstance.t('xxx', r.objectMeta.name)} and the map for xxx will be like 集群%1删除成功 for cn and Cluster%1delete successfully for en.
I think we can pend this pr, and renew it when the i18n-cli has any update

/assign

@axif0 The conflicts should be resolved before moving forward.

@axif0 can you rebase the code, it seems that we can move forward

@axif0 There are some conflict with the main branch, can you resolve the conflict, and recheck the PR ?

Hello, as this pr a bit too old for target branch. And I see we already fixed i18n tools. Should I close the PR?


Fix Javadoc error

For #6874.
This only fixes the linting error, not the broader fact that the PR workflow doesn't test javadoc generation and the snapshot release pipeline relies on it working.

Merging to fix the snapshot releases


code-split-component deprecated in favor of react-async-component

Looks like it has some added flexibility

Ah, I see this is covered in 'next'


add contributor

Add Nadirabbas as a contributor

@all-contributors please add @nadirabbas for test, doc, bug and code


rewrite secrets.yaml encryption/editing part

Changes the doc towards using sops with age instead of gpg.
Closes #282 #279
@michaelsauter should this be mentioned in the changelog?

Good question re:changelog. Not entirely sure. I would probably vote for yes. The changelog could call out that we change the approach from PGP to Age and that users may wish to change (or keep the current setup).

Oh, and do you want to open a PR against sops to correct the path to the keys.txt file in their docs? ;)

Oh, and do you want to open a PR against sops to correct the path to the keys.txt file in their docs? ;)

There was already an issue where I stated that it does not work for linux as well: https://github.com/mozilla/sops/issues/914#issuecomment-974139893


Address View - UAT Changes

Show a message when the user presses Map and their are no people selected
Add a name filter option
Add a note indicating that people without addresses will not show up?

Saving the name filter options for a later time


Can't validate array of files size wise nor mimetype wise

Hello. Thanks for creating this library.
A while ago, I had an issue where files sent as an array weren't appropriately received on the server and to fix this I used this hack from another issue that was opened about this: https://github.com/dmitriy-nz/nestjs-form-data/issues/47#issuecomment-1710264360
Now, when using version 1.9.1 I can't send an array of files, the validation always fails for the size and type of the files. It would only work if I send one file. Please how can I solve this? I have used the code from the readme even to see if it would work but it still doesn't work.
DTO:
export class ImagePostDto extends BasePostDto {
  @IsFiles({ each: true })
  @MaxFileSize(1e7, { each: true, message: 'The maximum size for a file is 10mb' })
  @HasMimeType(types, {
    each: true,
    message: (e) => {
      return `Error message`;
    },
  })
  files: FileSystemStoredFile[];
}

And I tried to send both via Postman and via my code, neither would work:
Code:

   const formData = new FormData();
   // files is just an array of files
    for (const file of files) {
      formData.append('files[]', file);
    }

   axios.post(url, formData);

PostMan:

And this is the error I get:

{"message":["Error message","The maximum size for a file is 10mb","Field \"files\" does not contain file"],"error":"Bad Request","statusCode":400}

Here are the images that I'm sending from the request body log:

body: {
      files: [
        {
          originalName: '3e132..png',
          encoding: '7bit',
          busBoyMimeType: 'image/png',
          path: '/tmp/nestjs-tmp-storage/3e132.-79988c.png',
          size: 6368,
          fileType: { ext: 'webp', mime: 'image/webp' }
        },
        {
          originalName: '512818_IGDB-272x380.jpg',
          encoding: '7bit',
          busBoyMimeType: 'image/jpeg',
          path: '/tmp/nestjs-tmp-storage/512818_IGDB-272x380-9988c5.jpg',
          size: 33564,
          fileType: { ext: 'jpg', mime: 'image/jpeg' }
        }
      ]
    }

Thanks in advance. I appreciate any further guidance on those to properly use your library

This is still broken, I degraded the library to 1.9.0 and used this solution : https://github.com/dmitriy-nz/nestjs-form-data/issues/47#issuecomment-1710264360
This is the only thing that works

@Yuniac Hi, I am trying to reproduce your issue but it is not reproducible.
Automatic tests will not allow you to certify a version with obvious behavioral errors.
Please provide more details about your environment, nest version, nodejs, controller.
Or create a small repository where the issue is reproduced.
Here is my environment where I tried:
package.json
  "dependencies": {
    "@nestjs/common": "^9.0.0",
    "@nestjs/core": "^9.0.0",
    "@nestjs/platform-express": "^9.0.0",
    "class-transformer": "^0.5.1",
    "class-validator": "^0.13.2",
    "nestjs-form-data": "^1.9.1",
    "reflect-metadata": "^0.1.13",
    "rimraf": "^3.0.2",
    "rxjs": "^7.2.0"
  },

app.controller.ts
import {
  Body,
  Controller,
  HttpCode,
  HttpStatus,
  Post,
  UsePipes,
  ValidationPipe,
} from '@nestjs/common';
import { ImagePostDto } from './ImagePostDto';
import { FileSystemStoredFile, FormDataRequest } from 'nestjs-form-data';

@Controller()
export class AppController {
  @Post('files')
  @UsePipes(new ValidationPipe({ transform: true }))
  @FormDataRequest({ storage: FileSystemStoredFile })
  @HttpCode(HttpStatus.OK)
  getHello(@Body() body: ImagePostDto): any {
    console.log(body);
    return body;
  }
}

ImagePostDto.ts
import {
  FileSystemStoredFile,
  HasMimeType,
  IsFiles,
  MaxFileSize,
} from 'nestjs-form-data';

export class ImagePostDto {
  @IsFiles({ each: true })
  @MaxFileSize(1e7, {
    each: true,
    message: 'The maximum size for a file is 10mb',
  })
  @HasMimeType(['image/png', 'image/jpeg'], {
    each: true,
    message: (e) => {
      return `Error message`;
    },
  })
  files: FileSystemStoredFile[];
}

Request & response:

Hi everyone, thanks for your feedback
This issue should be also fixed in the version 1.9.9, please try it out
https://github.com/dmitriy-nz/nestjs-form-data/issues/60#issuecomment-2184924859


(ExoPlayer 2.19.1) RTSP does not correctly fall back to TCP

Version
ExoPlayer 2.19.1
More version details
No response
Devices that reproduce the issue
Android devices
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
Set up an instance of https://github.com/bluenviron/mediamtx with RTSP protocols set to [tcp] (i.e. only supporting TCP).
Configure any test source, and attempt to connect to its RTSP path using ExoPlayer.
Exoplayer sends RTSP SETUP with no lower transport (i.e. UDP)
Transport: RTP/AVP;unicast;...
Expected result
Upon receiving a 461 Unsupported Transport error, it does not retry with TCP.
So playback fails.
Actual result
Upon receiving a 461 Unsupported Transport error, it should retry with TCP.
Exoplayer should retry, sending RTSP SETUP with TCP lower transport
Transport: RTP/AVP/TCP;unicast;...
Playback will then succeed.
Media
Any test source for https://github.com/bluenviron/mediamtx
Bug Report

[ ] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

Hello @machenmusik,
Thank you for reporting your issue! This is a bit surprising as fallback to TCP due to a 461 Unsupported Transport error in the RTSP SETUP Response was added to ExoPlayer 2.19.0 in this commit, https://github.com/google/ExoPlayer/commit/bbd45c8e4c838005846659dfa87c959804a042ed. Are you able to reproduce this in the demo app? If you were to add the RTSP url to media.exolist.json and try playing it?
Also in reproducing the issue, if you could share a bug reports then that would be helpful! If you are not able to send it publicly, please send them to<EMAIL_ADDRESS>with the subject Issue #586. Please also update this issue to indicate you've done this.

Agreed it was surprising, as I had upgraded to 2.19.1 to try this specifically.  Maybe other changes obsoleted that commit?
I can't share a bugreport (sorry).
Is there a pre-built demo APK for 2.19.1 that I can try?  That would help rule out any build issues here.

Hi @machenmusik,
Sorry there is not a pre-built demo APK and for non-technical reasons that is not something that we do.
It would also require you to provide me the exact rtsp URI and have me build the APK for you with that.
If this helps, here is some documentation about how to use and deploy the demo app https://developer.android.com/guide/topics/media/exoplayer/demo-application

Thanks.  Will see if I can find time to get to this, but may not be able to... current workaround is to use the force RTP TCP option.

Hi, what would the disk-space requirements for this? hopefully I can build and run the test in an emulator for less than 100GB
As a possibly off topic note, VRChat's Quest 2 build claims to be ExoPlayerLib/2.19.0 in user agent and also exhibits this bug.

current workaround is to use the force RTP TCP option.

So you are saying that I can provide a "rtsp://" URL and ExoPlayer will immediately try TCP mode?
How to do that? Where is that setting?

@microkatz By the way, I have a possible theory why the automatic TCP fallback didn't work for the original reporter.
I assume that you (Katz) have already tested with a MediaMTX server where UDP is disabled (see original reporter's first post), and verified that the UDP to TCP fallback works?
If so, the reported issue may be outside of ExoPlayer:
The reporter used the VRChat video player.
I have seen discussions on Reddit saying that ExoPlayer takes a very long time to fall back to TCP when UDP fails (8+ seconds) and that this often hits the 10 second timeout of the VRChat video player and it then automatically aborts playback.
So it is possible that the ExoPlayer automatic TCP fallback was working but taking too long.
Here is an example discussion about it:
https://www.reddit.com/r/VRchat/comments/1gfhgdv/comment/lui2w6e/
And here is a whole thread where VRChat users are trying to solve all these streaming issues:
https://feedback.vrchat.com/feature-requests/p/support-rtspt-protocol-streams-on-quest
Do you think that might be the issue? If you have already verified that MediaMTX with UDP disabled is working with ExoPlayer in your own tests, then my only conclusion is that this external issue is the reason.

@Arcitec
Foremost, we are not responding to issues on the old ExoPlayer project in general. If you would like to submit a question or issue to the androidx/media project, https://github.com/androidx/media, then we would be happy to help!
However just to note an answer to the question about forcing TCP. The API is in `RtspMediaSource.Factory' and is setForceUseRtpTcp. Here is a link to the code, https://github.com/androidx/media/blob/release/libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaSource.java#L95. Hope that helps!

@microkatz

Foremost, we are not responding to issues on the old ExoPlayer project in general. If you would like to submit a question or issue to the androidx/media project, https://github.com/androidx/media, then we would be happy to help!

Oh, sorry, I didn't realize that this repo is abandoned. But I am really confused, the URL you just gave me is to the repo I just commented on.

However just to note an answer to the question about forcing TCP. The API is in `RtspMediaSource.Factory' and is setForceUseRtpTcp.

Thank you so much, that helped me find it! :heart:


Unable to train on very simple criteo like data

Please refer to the FAQ in doc and search for the related issues before you ask the question.
Describe the question(问题描述)
I would like to ask why any model from DeepCTR is unable to train on my criteo like data?
I am using the same code from your example with simple change in the number of cols in sparse and dense features. The data has only one sparse and one dense column. Dense column is always the same for simplicity. Each odd number in I1 gives label 1, even number in I1 gives label 0. C1 could be anything
label, I1, C1
0, 0, a
1, 1, a
0, 2, a
1, 3, a
0, 4, a
...

output is:
Epoch 94/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7032 - val_binary_crossentropy: 0.7032
Epoch 95/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7032 - val_binary_crossentropy: 0.7032
Epoch 96/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7033 - val_binary_crossentropy: 0.7033
Epoch 97/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7033 - val_binary_crossentropy: 0.7033
Epoch 98/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7034 - val_binary_crossentropy: 0.7034
Epoch 99/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7035 - val_binary_crossentropy: 0.7035
Epoch 100/100
80/80 - 0s - loss: 0.6885 - binary_crossentropy: 0.6885 - val_loss: 0.7035 - val_binary_crossentropy: 0.7035
test LogLoss 0.7187
test AUC 0.3938
Additional context
I have chosen those data to model user behavior in time. For example the rule could be... user click on the ad on Monday, Wednesday, Friday, etc.
Operating environment(运行环境):

python version [e.g. 3.6]
Python 3.7
tensorflow version [e.g. 1.4.0,]
TF version 2.1.0
deepctr version [e.g. 0.7.1,]
latest

The toydata you have provided is not suitable, each colum means a different field, it's meaningless when every element of I1 is unique.

You can try this code i have test.
`
data_dict = dict(label=[0, 1]*5000, i1=list(range(10000)), c1=[0.5]*10000)
data = pd.DataFrame(data_dict)
sparse_features = ['i1']
dense_features = ['c1']

target = ['label']

# 1.Label Encoding for sparse features,and do simple Transformation for dense features
for feat in sparse_features:
    lbe = LabelEncoder()
    data[feat] = lbe.fit_transform(data[feat])
mms = MinMaxScaler(feature_range=(0, 1))
data[dense_features] = mms.fit_transform(data[dense_features])

# 2.count #unique features for each sparse field,and record dense feature field name

fixlen_feature_columns = [SparseFeat(feat, vocabulary_size=data[feat].nunique(),embedding_dim=4)
                       for i,feat in enumerate(sparse_features)] + [DenseFeat(feat, 1,)
                      for feat in dense_features]

dnn_feature_columns = fixlen_feature_columns
linear_feature_columns = fixlen_feature_columns

feature_names = get_feature_names(linear_feature_columns + dnn_feature_columns)

# 3.generate input data for model

train, test = train_test_split(data, test_size=0.2)
train_model_input = {name:train[name] for name in feature_names}
test_model_input = {name:test[name] for name in feature_names}

# 4.Define Model,train,predict and evaluate
model = DeepFM(linear_feature_columns, dnn_feature_columns, task='binary')
model.compile("adam", "binary_crossentropy",
              metrics=['binary_crossentropy'], )

history = model.fit(train_model_input, train[target].values,
                    batch_size=256, epochs=10, verbose=2, validation_split=0.2, )
pred_ans = model.predict(test_model_input, batch_size=256)
print("test LogLoss", round(log_loss(test[target].values, pred_ans), 4))
print("test AUC", round(roc_auc_score(test[target].values, pred_ans), 4))

`

Thanks for the answer. Your code snippet was helpful with little upgrade ... repetition
    def modulo(n):
        # each odd week is click
        return n%4

    items = int(1e+3)
    data_dict = dict(label=[0, 1] * int(items/2), I1=list(map(modulo, list(range(items)))), C1=[0.5] * items)

Hi, batrlatom, your code works well in my env : python 3.7.6 tf 2.1 , deepctr 0.7.4.
You can upgrade your env and try again.


Environment Variables/Command Line Arguments

This was brought to my attention by @aafrey on Gitter.
This is already kind of possible by using kernel command line arguments (--append and __SYSCALL.getCommandLine()), but it's neither officially supported nor elegant.
Why?

Well, servers need a way to use hidden variables, especially with open source server code
Also, it allows to quickly change a value when starting up a VM, instead of digging in to the code

How to pass them in?

Maybe another argument for runtime-cli
...or maybe this could be another use for runtime.json

Problems with each implementation:

As an argument: there's no way to make it persistent (unless you script the running)
As a property in runtime.json: if you .gitignore it so that you don't accidentally leak the variables, you're also gitignoring a file that might contain settings you do want to commit (e.g. v8.flags)

Possible solution:
Implement both? That way, you can make unimportant variables persistent by adding them to runtime.json, while keeping ultimately secret variables as arguments.
How to get them?
Well, process.env!

Yeah, great idea!
I think passing env variables through command line is the best option. So the same initrd bundle can be used in different environments (development/production etc). runtime.js should probably not expose raw command line to the app, and we can remove --append option as well.
Running something like this:
runtime start -ENODE_ENV=production -ESECURE_KEY=abc

can internally do this:
runtime start --append={"env":{"NODE_ENV":"production","SECURE_KEY":"abc"}}


Bug in About us page

Describe the bug
Bug in About us page it working fine in local server but not in vercel.
Expected behavior
All images in about us page should work properly.
@MAVRICK-1  can you please assign this to me.

@MAVRICK-1 can you please add labels and assign this issue to me. Thank you

@MAVRICK-1 I had created the PR can you please check it.


Error when project path contains ".js"

Version
nuxt-i18n: 6.21.0
nuxt: all versions
Steps to reproduce
When the project directory path contains ".js" the bundler crashes with the following error:
Dependency not found "~i18n-klona"
The problem is in this line:
https://github.com/nuxt-community/i18n-module/blob/c6580240190e754496c3a6a25a52a46dc1c86c59/src/index.js#L88
The .replace(".js", ".mjs") should replace only the ".js" extension, but instead it replaces the first ".js" it encounters.

Thanks. Fixed in https://github.com/nuxt-community/i18n-module/releases/tag/v6.21.1

Wow, that was fast! Thank you for the quick fix.


fix(app): do not accept an empty anonymous user id

The gateway defaults to anonymous user id set to "" when one is not found in the cookie for a users session. But having a token set to "" results in improper k8s resource names. I.e. the sessions are named like f"{user-id}-some-other-snippet". And when the anonymous user id is blank the resources in k8s are named starting with - and k8s does not allow this.
Also because of k8s naming restrictions and how the id is used in naming resources the anonymous id must start with an alphanumeric character. I added a check for this too.
/deploy (just to be sure)

You can access the deployment of this PR at https://renku-ci-nb-845.dev.renku.ch


Delete challenge with no attachments fails

Probably will fix once attachments can be many:many.

*with attachments


Old-style provider map is breaking with two cookbooks that both use Chef::Platform.set

I ran across a problem on Friday where two dependencies, of a cookbook I'm working on, both had a file libraries/z_provider_mapping.rb that contained calls to Chef::Set.platform. One was mysql2_chef_gem and the other was automatic_updates.
While I know the method used by the cookbooks isn't preferred in Chef 12.4.x, there's a lot of cookbooks attempting to maintain compatibility with Chef 11.x by doing things this way. However, when two cookbooks both use this method, I was seeing that automatic_updates was breaking the provider map entries from mysql2_chef_gem. This led to many instances of wrong number of arguments (2 for 0) because Chef would fall through to matching providers by class name, and mysql2_chef_gem has an abstract class at the same name and level of the class hierarchy (so the class selected by name was invalid). I believe this is happening to many other folks using mysql2_chef_gem, e.g. https://github.com/sinfomicien/mysql2_chef_gem/issues/6, https://github.com/sinfomicien/mysql2_chef_gem/issues/5, https://github.com/sinfomicien/mysql2_chef_gem/issues/4.
While I know that the 'correct' thing to do is update cookbooks to use Chef 12-style provides:, I think something is still broken in Chef 12.4.1 when it comes to maintaining compatibility of the platform map behavior. I've created an example cookbook to demonstrate this problem.
In that example, check out the following libraries/z_provider_map.rb (I've pasted the output back into the source, when run on chef 12.4.1):
pp "Chef::Platform.send(:platforms) = #{Chef::Platform.send(:platforms)}"
# Output: "Chef::Platform.send(:platforms) = {:default=>{}}"

pp "Setting platform mapping for :foo"
Chef::Platform.set platform: :centos, version: '< 7.0', resource: :foo, provider: Chef::Provider::Foo::Beta
Chef::Platform.set platform: :centos, version: '>= 7.0', resource: :foo, provider: Chef::Provider::Foo::Alpha
Chef::Platform.set platform: :ubuntu, resource: :foo, provider: Chef::Provider::Foo::Beta
pp "Chef::Platform.send(:platforms) = #{Chef::Platform.send(:platforms)}"
# Output:
# Chef::Platform.send(:platforms) = {
  # :default=>{},
  # :centos=>{\"< 7.0\"=>{:foo=>Chef::Provider::Foo::Beta}, \">= 7.0\"=>{:foo=>Chef::Provider::Foo::Alpha}},
  # :ubuntu=>{:default=>{:foo=>Chef::Provider::Foo::Beta}}
# }

pp "Setting platform mapping for :bar"
Chef::Platform.set platform: :centos, resource: :bar, provider: Chef::Provider::Bar
Chef::Platform.set platform: :ubuntu, resource: :bar, provider: Chef::Provider::Bar
pp "Chef::Platform.send(:platforms) = #{Chef::Platform.send(:platforms)}"
# Output
# Chef::Platform.send(:platforms) = {
  # :default=>{},
  # :centos=>{:default=>{:bar=>Chef::Provider::Bar}},
  # :ubuntu=>{:default=>{:foo=>Chef::Provider::Foo::Beta, :bar=>Chef::Provider::Bar}}
# }

It seems like the second set of Chef::Platform#set calls are wiping out map entries created by the first set of calls. I suspect that either the cookbooks I referenced above are 'doing it wrong' for Chef 11.x compatibility, or there is a subtle bug in the (https://github.com/chef/chef/blob/12.4-stable/lib/chef/platform/provider_mapping.rb#L109)[set method] of platform/provider_mapping.rb.
It's pretty clear that lines like this one will wipe out any existing map entries when called. Is this a mistake in usage where cookbooks from the Chef-11 era shouldn't be using Chef::Platform.set for backwards compatibility in Chef 12? Or is this a case where the z_provider_mapping.rb pattern is okay, but the methods that manipulate the platform map are not supposed to be deleting previous entries?
If you read down this far, thank you!
/CC some of my colleagues, @jarosser06
/CC some interested parties that are relevant for the commits on this code, @lamont-granquist @jkeiser @danielsdeleo @coderanger

I think there is a bug.  Figuring it out definitely isn't very high on my list since the ultimately right thing to do is the "workaround" of correctly using Chef 12 provides syntax (the mysql cookbook is currently the best reference for the most complicated things you can do and be portable across Chef-11/Chef-12.0/Chef-12.4).

Guys, as someone new to chef who is trying to install the current chef and opscode-manage, hearing that a solution to this blocker is 'isn't very high' on the current priority list does not give warm and fuzzies.  Can we please get a work-around, patch, and ETA on a solution?

Hi @bluejaguar -- I'm the original bug reporter. This bug affects chef-client versions < 12.x, so it shouldn't be affecting anyone on the 12.x.x versions (released almost a full 12 months ago). I reported it as I'm having to maintain some cookbooks that require Chef 11.x compatibility. I'm not sure you're going to be affected based on your versions.
The community-contributed nginx cookbook issue you referenced doesn't appear related to me.
Hope this helps!

Martin

Hi Martin, so where should I send in a bug report for this (Linux 17.2)

opscode-manage reconfigure

[2015-09-17T12:49:39-04:00] INFO: Started chef-zero at chefzero://localhost:8889 with repository at /opt/opscode-manage/embedded
...
[2015-09-17T12:49:39-04:00] INFO: *** Chef 12.4.1 ***
...
[2015-09-17T12:49:46-04:00] WARN: Class Chef::Provider::ComponentRunitSupervisor does not declare 'resource_name :component_runit_supervisor'.
[2015-09-17T12:49:46-04:00] WARN: This will no longer work in Chef 13: you must use 'resource_name' to provide DSL.

================================================================================
Error executing action create on resource 'component_runit_supervisor[opscode-manage]'
================================================================================
ArgumentError
-------------
wrong number of arguments (2 for 0)
Resource Declaration:
---------------------
In /opt/opscode-manage/embedded/cookbooks/cache/cookbooks/enterprise/recipes/runit.rb

 28: component_runit_supervisor node['enterprise']['name'] do
 29:   ctl_name node[node['enterprise']['name']]['ctl_name'] ||
 30:     "#{node['enterprise']['name']}-ctl"
 31:   sysvinit_id node[node['enterprise']['name']]['sysvinit_id']
 32:   install_path node[node['enterprise']['name']]['install_path']
 33: end

Compiled Resource:
------------------
Declared in /opt/opscode-manage/embedded/cookbooks/cache/cookbooks/enterprise/recipes/runit.rb:28:in `from_file'

component_runit_supervisor("opscode-manage") do
  action [:create]
  retries 0
  retry_delay 2
  default_guard_interpreter :default
  declared_type :component_runit_supervisor
  cookbook_name "enterprise"
  recipe_name "runit"
  ctl_name "opscode-manage-ctl"
  sysvinit_id "CM"
  install_path "/opt/opscode-manage"
end

[2015-09-17T12:49:46-04:00] INFO: Running queued delayed notifications before re-raising exception
[2015-09-17T12:49:46-04:00] ERROR: Running exception handlers
[2015-09-17T12:49:46-04:00] ERROR: Exception handlers complete
[2015-09-17T12:49:46-04:00] FATAL: Stacktrace dumped to /opt/opscode-manage/embedded/cookbooks/cache/chef-stacktrace.out
[2015-09-17T12:49:46-04:00] ERROR: component_runit_supervisor[opscode-manage] (enterprise::runit line 28) had an error: ArgumentError: wrong number of arguments (2 for 0)
[2015-09-17T12:49:47-04:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

@bluejaguar Issues with Chef Server belong over on https://github.com/chef/chef-server. But I can tell you now that Mint is not a supported OS for Chef Server so the answer from the team might be WORKSFORME.

@martinb3 re:
"because Chef would fall through to matching providers by class name, and mysql2_chef_gem has an abstract class at the same name and level of the class hierarchy ."
That reminds me of yak shaving I did when I cleaned up the mysql cookbook for Chef-11/12.0/12.4 compatibility.
https://github.com/chef-cookbooks/mysql/commit/2e438b25b6e6408decfa1a6c7295ace301e2b320#diff-3252c3ce1094cb10b371a5b57c233aa1L3
Patches like that where I renamed Chef::Provider::MysqlService::Smf to Chef::Provider::MysqlServiceSmf were done deliberately to avoid Chef 12.4.0 from wiring up that to smf in the DSL automagically (instead it wires up mysql_service_smf which nobody should be using).
I don't think Chef::Platform.set is in any way broken, but it is lowest-priority (by design, since 12.0) and its being overridden by some of the new wiring in 12.4.0 that is at a higher level.
Don't know how I feel about this since cookbook code can always follow the pattern set in the mysql cookbook.  At the same time what I ran into there was mildly awful, and I think goes against having magic in the DSL wired up to the class names.
I know that @jkeiser has an opinion that the current behavior is good and saves typing, however, cases like this show that people aren't necessarily going to be thinking about their class names getting wired up automatically to the DSL -- and class names that seem to make sense may stomp on other things in the DSL.

[ and that might be a bad example, but it was the first one i picked -- i can't recall exactly which class name trolled me hard in the mysql cookbook and made me flatten the namespace and rename all of them -- it may also have been a resource class getting auto-wired-up that was the real issue ]

I don't think Chef::Platform.set is in any way broken, but it is lowest-priority (by design, since 12.0) and its being overridden by some of the new wiring in 12.4.0 that is at a higher level.

@lamont-granquist I can definitely fix the cookbooks that are affected, so that's not really a problem.
It seemed like there's probably still a bug in there, though, for anyone using older versions. In my testing, I noticed that the map is being partially wiped out when Chef::Platform.set is called; see my original bug description's code block -- after setting the provider for :bar on specific platforms, the provider mapping on centos for :foo has been lost.

I don't see where Chef::Platform has been changed that much recently and where it would show up like that.  Certainly not an obvious bug.  Most of the complicated logic hasn't been touched since Dan split the concerns up.


compiler: Fix issue #2235

Opening for some first review

Also, potentially related, thos tests (and opertor)
https://github.com/devitocodes/devito/blob/b6f73081fd19ee4b5f0d7cd4ee0ff1cdbfa36135/tests/test_gpu_common.py#L563
Should be valid for time_M=nt-1 but errors due to "OOB"

I tried to rebase this, but it failed on a gradient test. WIll check again

I had honestly forgotten about this, please re-review when available

I am having a problem rebasing this due to:
    def test_function_coefficients_xderiv(self):
        p = Dimension('p')

        nstc = 8

        grid = Grid(shape=(51, 51, 51))
        x, y, z = grid.dimensions

        f = Function(name='f', grid=grid, space_order=(2*nstc, 0, 0),
                     coefficients='symbolic')
        g = Function(name='g', grid=grid, space_order=(2*nstc, 0, 0))
        ax = Function(name='DD2x', space_order=0, shape=(2*nstc + 1,),
                      dimensions=(p,))
        ay = Function(name='DD2y', space_order=0, shape=(2*nstc + 1,),
                      dimensions=(p,))
        stencil_coeffs_x_p1 = Coefficient(1, f, x, ax)
        stencil_coeffs_y_p1 = Coefficient(1, f, y, ay)
        stencil_coeffs = Substitutions(stencil_coeffs_x_p1, stencil_coeffs_y_p1)

        eqn = Eq(g, f.dxdy, coefficients=stencil_coeffs)

        op = Operator(eqn)
        op()

where domain should not be relaxed here...


[test] Adapt IOR checks to build systems

Fixes #497

@jenkins-cscs retry dom

There was no maintenance tag, there was the ops one.

@teojgo No, there should be a maintenance tag:

On master:

./bin/reframe -C config/cscs.py -c cscs-checks/system/io/ior_check.py -t maintenance -l

List of matched checks
======================
  * ior_read_check_users (found in /users/karakasv/Devel/reframe/cscs-checks/system/io/ior_check.py)
        descr: IOR check (/users)
        tags: {/users,read,ops,maintenance}, maintainers: ['SO', 'MP']
  * ior_write_check_users (found in /users/karakasv/Devel/reframe/cscs-checks/system/io/ior_check.py)
        descr: IOR check (/users)
        tags: {/users,write,ops,maintenance}, maintainers: ['SO', 'MP']
Found 2 check(s).

On your branch

List of matched checks
======================
Found 0 check(s).

Codecov Report

Merging #505 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   91.41%   91.39%   -0.03%
==========================================
  Files          72       72
  Lines        8737     8737
==========================================
- Hits         7987     7985       -2
- Misses        750      752       +2

Impacted Files
Coverage Δ

reframe/core/config.py
82.6% <0%> (-1.74%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17466c...686ca78. Read the comment docs.


gitignore .cache/

Ignore py.test-generated .cache/

I'd rather separate these commits into separate PRs, yet I realized they would be put together too late...


Add Nouliv System from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of rXenoq12, to add Nouliv System to CKAN.
Mod details:
name = /mod/1761/Nouliv%20System
author = rXenoq12
abstract = A Kopernicus mod which adds a new gas giant system into the default Kerbol System.
license = MIT
Homepage = https://github.com/rXenoq12/Noulvi
description = A Kopernicus mod which adds a new gas giant system into the default Kerbol System.
This mod requires Kopernicus, it will not function without it!
Current features of this mod:
*Features in italized are not available yet but are planned.*

Available

Nouliv (Gas Giant)

Planned

Sulvi (Moon)

Cani (Moon)

Fuln (Comet)

Please direct questions about this pull request to rXenoq12.

Deleted from SpaceDock and GitHub.


Fix lifecyclehook error handling

Failure of lifecyclehook script now fails the rebase.
Cleaned up some logging where logging.exception() was being passed exception as argument. This result in duplicate exception printing.
Lifecyclehook used class variables instead of object variables.
Temporary hook scripts were created in wrong directory because of missing delimiter
Added test for script failure

/lgtm


Closes: #1

Updated validations.py python script.
Fixed the behaviour of validate_user function in validations.py.

@googlebot I signed it!


Docs

This PR adds a lot of reference links in the comments to the API pages on the brewerydb website. Once merged, you can see the links in godoc.
About a third of all methods have had links added.
This makes some progress on #11.

Excellent! One very minor nitpick. Could you change "golang" to "Go" in the README in the first commit? The Go team can be a bit pedantic about that, and I agree. You could make it a link to the Go website: [Go](http://golang.org). TY @MovingtoMars

Ok, done.

:beer:


Cannot View Pull Request Description after a few days.

Using GitHub Pull Request and Issues Extension v0.63.2023042009 (or v0.62)
Using Github Enterprise 3.2.20.
I'm having an issue where I can't load the description page of open pull requests after a day or two. Clicking on "Description" beneath the expanded view of the pull request has no effect, nor does clicking on the smaller "Open Pull Request Description to the Side" button.

When I look at the output of GitHub Pull Request in vscode, I find an error that appears:
[error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Field 'subjectType' doesn't exist on type 'PullRequestReviewThread'

This seems similar to an older closed issue, https://github.com/microsoft/vscode-pull-request-github/issues/2772.
Rebooting vscode, or the computer, doesn't address the issue.
It never happens when I first view a pull request, or newly create one myself.
It always happens eventually, after a few days.
I've had it happen with a dozen or so pull requests so far over last two months.

I have discovered an important piece related to this issue.
Specifying a default web browser and rebooting vscode has resolved the issue, at least temporarily.
Does github pull request depend upon there being a default web browser specified on the machine?
Would it be possible to specify a browser to use with a local setting instead of relying on the global windows setting?
My windows 10 image is slightly faulty and forgets the default web-browser after every reboot.

@dreens do your git remotes use ssh? If so, not being able to open the description could be https://github.com/microsoft/vscode-pull-request-github/issues/4768

[error] PullRequestModel> Failed to get pull request review comments: Error: GraphQL error: Field 'subjectType' doesn't exist on type 'PullRequestReviewThread'

I will likely need to make a fix for this.

Hi @alexr00 thanks for your reply. No, I am not using SSH. I can confirm that specifying a default web browser in my windows 10 settings resolves this issue.
Perhaps I should close the issue? It would be nice, though, if some appropriate error message were registered relating to the lack of a default web browser, rather than the nearly silent failure at present.

It would be nice, though, if some appropriate error message were registered relating to the lack of a default web browser, rather than the nearly silent failure at present.

I don't see why specifying a default web browser should make a difference.
The PR description is displayed using a webview. Next time you see this issue with the PR description can you open another webview (such as the release notes by running the command to show the release notes) and see if that webview shows properly?


[discussion] deterministic execution in turns

notes:

during the loading process, we might have clusters of dependencies that are ready to be executed.
order is important for deterministic reasons.
running in multiple turns seems to be ok (if the order is deterministic).
top level await should be taken into consideration.

Indeed. We had to figure this out for HTML Imports. In realistic network condition, waiting until everything loads is unlikely to result acceptable performance characteristics.

For modules I don't think we have a choice. You simply cannot execute a module before its dependencies have been executed. So you cannot execute any part of the module tree before all its children have been executed.

@domenic this discussion is not really about the "imported" module, it is about parts of the dependency tree that can be executed in turns. E.g.:
while doing import A:
A -> B -> C, while B -> D and C -> E
If B and D are in "link" stage, and the pipeline is just waiting for C, and E to be fetched, we could, theoretically, evaluate B and C, get them to "ready" stage, without any observable difference in the runtime while maintaining the deterministic aspect of the module graph since this is equivalent to:
import B, then import A;
Today, this is not the case since we need to get every module in the graph in link stage before proceeding to the evaluation phase.
Note: -> means "depends on".

Ah, I see. The execution model for https://github.com/whatwg/html/pull/443 does not have that problem; it executes everything as soon as its dependencies are ready.

that is correct!

It's a bit more complicated than my above comment implied sadly. See https://github.com/whatwg/html/pull/443#issuecomment-169147982. Basically my above comment is correct about the current whatwg/html#443 PR, but that state of affairs is actually due to a bug that gives us semantics that are something like "defer except execution order is not preserved".
If you preserve execution order (per normal defer semantics) than you get a problem similar to the one described in this bug where large/slow trees that are earlier in the source order can block small/fast trees later in the source order.
If you want the kind of incremental as-soon-as-it-loads tree execution style then you want something more like async.
Anyway, more discussion over there, I just wanted to update this thread since my above comment was incorrect.

I don't think this is related to whatwg/html#443. We will be able to introduce execution in turn for any dependency of a top level module imported via script tags without changing the way you interact with the loader (from what I can read in whatwg/html#443). It is really all about the loader, and when it invokes evaluation in certain module records.


Show used icons to not mix all types of icons

Clear and concise description of the problem
While using unplugin icons it's great since we can use a lot of different icons for differents usecase.
But with this benefit come with a price of risking to use too much different icons / set of icon and affect the overall experience.
For exemple arrow or lock could be used in our app and there is like 100 variant that we can use.
It's realy hard to found what we already used in our app.
Suggested solution
I was thinking of 2 solutions:

Add a tab in vscode to have the project USED icons
New tab on vite (vue) devtool that show as well used icons

Alternative
search in the whole code base with ctrl + shift + f what icons are used, but it can be hard since for exemple i have a lot of keyword in the app with lock (233 for exemple ^^')
Additional context
We are rebuilding an app to vue and there is like 1/3 that is done and i have like 500 imported icons where there should be a lot of icons that are not the same.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

IIRC we don't have VSCode extension, maybe you can try installing Iconify IntelliSense (not sure if it will work).
Integrating a viewer for used icons in vue dev tools looks a good idea to me, I'll try to find some free time and play with it (I don't promise anything, too busy).
You can use UnoCSS Preset Icons instead this package (will move all the icons to your css): Iconify IntelliSense works.
You can use icones  to browse collections and icons:

or iconify icon-set:

import everything in one file
place similar icons next to each other
look at them with https://marketplace.visualstudio.com/items?itemName=antfu.iconify
create a page where all the icons will be displayed with a description of where, when and how to use them


Add types for connection config of mysql2 driver

This pull request adds types for connection config of mysql2 driver.

Thanks!

@kibertoad Thank you!


teensy typo

"cold" not "code"

@swanderz : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@swanderz - thanks for catching that!


Implement is_some_and() operator for Undefinable

Reopened by https://github.com/option-t/option-t/pull/2398

This operator is replacable with isNotNull(bar) && predicate(bar). In contrast to is_ok_and for plain_result, it does not do unwrapping a contained value. Thus it does not have a strong benefit, I think.


Replace div-spoiler hack with simpler code

This comes from a comment in GH issue #1027. Andy wrote the code,
Rich made the PR.
Fixes #1027

Only for master, or does it apply to the release branches as well (how far back?)?

It's a performance gain, so only master.  If you argue for 1.1.0 I'll be okay with that.

I'd argue for 1.1.0.  I see nothing wrong with performance enhancements in release branches as long as the ABI is maintained...  which seems to be the case here.

okay, 1.1.0 as well.

It's a performance gain

No, it's rather constant-time thing, i.e. security hardening of specific kind. Either way, as even commit message suggests, it's replacement for div_spoiler, so that some code, naturally one calculating div_spoiler, has to be even removed...

div_spoiler is used in the calculation for rotate_offset which is used.  So I don't know what code can/should be removed.

div_spoiler is used in the calculation for rotate_offset which is used.

No, that result is effectively discarded in rotate_offset = 0. Optimizing compiler would actually (or at least have all chances to) omit all the code referring div_spoiler as dead. But we don't want to take the chance and should explicitly do it, i.e. remove all calculations involving div_spoiler include declaration itself.

SMH, I missed that zero assignment.  Updated commit pushed.

+1

in 1.1.0 rotate_offset isn't zero'd so the cherry-pick doesn't apply cleanly.  not going to risk breaking.  someone ( @dot-asm? ) want to propose/provide a 1.1.0 variation of this?
will leave open with this comment hanging for now.
8f77fab on master.

#2277, it's exactly same modulo size_t vs. unsigned [int].


Copying all digits are replaced into emoji

Test text :   Button_22wawae
I insert an emoji
Result : Button_😗wawae😗

Same problem here

Are you using the NuGet package or a more recent version from GitHub?

@samhocevar Could you update the NuGet package please? That would be really nice

Hi! I believe this is finally fixed in emoji.wpf 0.3.4, available on NuGet. Can you please confirm?

Thanks for notifying!


chore(photon): add cloudpickle version check

Found this when updating imgpilot with @vthinkxie

See also https://github.com/leptonai/leptonai/pull/120


[app] Improve instrumentation middleware

We unified the exported function name across the httpmetrics, httplog
and httptracer middleware. They all export a Handler function which can
be used in the router.
The logging and tracing middleware also catchs panics now to write a log
line / create a span.
Besides that we also fixed a small bug caused by the notification
drawer, introduced in #389. Because of the notification drawer the
drawer in the PageSectionContent component wasn't using it's full height
anymore, which caused problems for the select boxes in the toolbar and
the pages showing graphs via cytoscape. This should be fixed now.

[x] I added a CHANGELOG entry for this change.
[ ] I adjusted the corresponding documentation for this change.
[ ] I adjusted the values.yaml file and the documentation for all values.

Codecov Report

Merging #390 (6d54578) into main (8edfb2f) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   45.37%   45.20%   -0.18%
==========================================
  Files         134      134
  Lines       10338    10377      +39
==========================================
  Hits         4691     4691
- Misses       5569     5608      +39
  Partials       78       78

Impacted Files
Coverage Δ

pkg/hub/hub.go
0.00% <0.00%> (ø)

pkg/middleware/httplog/httplog.go
0.00% <0.00%> (ø)

pkg/middleware/httpmetrics/httpmetrics.go
0.00% <0.00%> (ø)

pkg/middleware/httptracer/httptracer.go
0.00% <0.00%> (ø)

pkg/satellite/satellite.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edfb2f...6d54578. Read the comment docs.


Enhancements related to the share verify and re-apply feature

Is your idea related to a problem? Please describe.
In my testing for feature: https://github.com/data-dot-all/dataall/pull/1062/files I found an enhancement that can be made to the backend. We can do this as a part of 2.4 if we so choose.
Here are 2 issues:

I replaced consumer role directly in the bucket policy with new consumer role. When I re-apply share, the older consumer role I had removed is re-added, but the new consumer role is not removed. The new role was added manually and should have been removed.
For example:
Earlier bucket policy after successful share was:

{
            "Sid": "DataAll-Bucket-ReadOnly",
            "Effect": "Allow",
            "Principal": {
                "AWS": [
                    "arn:aws:iam::1234567:role/dataall-test-consumer-env",
                ]
            },
            "Action": [
                "s3:List*",
                "s3:GetObject"
            ],
            "Resource": [
                "arn:aws:s3:::test-anushka-imported",
                "arn:aws:s3:::test-anushka-imported/*"
            ]
        },

I manually replaced the Principal with  "arn:aws:iam::1234567:role/dataall-test-consumer-env1", in the bucket policy. This role exists, but permission was granted manually. Data.all does not detect this.
Now, I verified status of the share, which became unhealthy. And then when I hit re-apply share, this is the new bucket policy:
{
            "Sid": "DataAll-Bucket-ReadOnly",
            "Effect": "Allow",
            "Principal": {
                "AWS": [
                    "arn:aws:iam::1234567:role/dataall-test-consumer-env",
                    "arn:aws:iam::1234567:role/dataall-test-consumer-env1"
                ]
            },
            "Action": [
                "s3:List*",
                "s3:GetObject"
            ],
            "Resource": [
                "arn:aws:s3:::test-anushka-imported",
                "arn:aws:s3:::test-anushka-imported/*"
            ]
        },

I would expect dataall to be self-cleaning and to remove this extra manually created principal. However, it did not do so.
We should have guardrails around people erroneously editing the bucket or kms policies and messing up data all permissions. Dataall should remove stuff it does not recognize, but that is not the case..

I completely wiped out bucket policy. Then checked health status. Health status for table and bucket both was unhealthy. Then I revoked access to both items.
Table went to revoke_succeeded, but bucket went to revoke_failed.

I think, we should not allow revoke actions when shares are in broken state.
Maybe we should tell them to first re-apply share and then try revoking. We can print the same message on the UI as we do when states try to go from a state to an invalid state. Like approved to deleted.
P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

I see the point of the issue. Thanks @anushka-singh. It is true that we only check that the objects of the share are present. If there are extra permissions we do not clean them up. There are 2 main challenges/downsides of verifying non-extra statements in share:

First a challenge: whenever we re-apply shares we do not focus on a single shares but on all shares on an object. If a bucket has been shared with X principals we need to consider all those in our sharing process
And also a downside: removing extra statements disallows users to manage permissions outside of data.all. Which might be what we want for some cases, but on certain cases it might be an issue (e.g. you are adding additional bucket policy statements for other applications, additional LF permissions for column-level security...)

I would like to hear the opinion of others on this one. @noah-paige @petrkalos @SofiaSazonova


Update CONTRIBUTING.md

Pull Request Template
Type of PR

[ ] Feature - Platform
[ ] Feature - Game
[ ] Fix - Bug
[x] docs

Description of PR

create rules and support file for contributors.

Checklist

[ ] Prepared for code review (Assignees set, Labels applied, etc.)
[ ] Checked that changes do not negatively affect existing features
[x] Documentation completed for new features
[ ] All unit tests passed
[ ] Testing in the test environment completed
[ ] Linked this PR in the related issue
[x] Communicated sufficiently with the relevant team or person before submitting PR

good job man


file_regression check method don't accept Pathlib.Path

I wanted to use the pytest-regressions lib to check GEE generated .pkl files but it seems the check method only accept str. As pathlib.Path offers lots of flexibility and cross-platform solution to file management issues, I'm using it systematically and I thing it an acceptable input for a file checking method.
Is it a wanted feature ?

Hi @12rambau,
Yes definitely, this is something we have adopted in general but probably missed that when developing this plugin (probably because it is relatively old code).
Would love to review/merge a PR which fixed this. 👍

wait let me check with you, I was working a PR and I think I realized I was not using the method properly. The content parameter should be the byte or str content of the file not the file path right ?
If it's the case then I should close this issue as there is no issue here, just a misunderstanding.


Put DelegateMethodILEmitter in a namespace

Forgot to put it in the Internal.IL.Stubs namespace. Ooops.

👍


Mac issue

Looks like there is mac java issue again with install-jdk fixed the mac issue. Placeholder so it wont' be forgotten.

Looks like it's the environmental issue. Can't reproduce. https://github.com/sophia-guo/run-aqa/runs/667150744?check_suite_focus=true


pull request for e2e test at 01/03/2017 10:56:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bump concurrently version to fix windows 10 builds

Signed-off-by: mellow<EMAIL_ADDRESS>

@Nokel81 can you please help @Mellow993 to get this in. We should ensure windows builds are working fine.

@Mellow993 are you fine if I push to your fork?

@Mellow993 are you fine if I push to your fork?

yes go ahead


Detekt plugin not able to download from Maven central

I am working with Kotlin and want to do static analysis using Detekt plugin. My problem is, when I want to download it from Maven central repository, it is giving me below error. But when I use company's repository (Nexus), it does not give me any error and downloads it smoothly. I don't understand this.
Can someone tell me why this is happening? I want to use this plugin and have not found out any other alternative.
Error :
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (detekt) on project agathe: Execution detekt of goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run failed: Plugin org.apache.maven.plugins:maven-antrun-plugin:1.8 or one of its dependencies could not be resolved: Could not find artifact com.beust:jcommander:jar:1.74 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

    ..
    ${project.build.directory}/detekt.xml
    ..

    <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-antrun-plugin</artifactId>
        <version>1.8</version>
        <executions>
            <execution>
                <!-- This can be run separately with mvn antrun:run@detekt -->
                <id>detekt</id>
                <phase>verify</phase>
                <configuration>
                    <target name="detekt">
                        <java taskname="detekt" dir="${basedir}"
                              fork="true"
                              failonerror="false"
                              classname="io.gitlab.arturbosch.detekt.cli.Main"
                              classpathref="maven.plugin.classpath">
                            <arg value="--input"/>
                            <arg value="${basedir}/src"/>
                            <arg value="--filters"/>
                            <arg value=".*/target/.*,.*/resources/.*"/>
                            <arg value="--report"/>
                            <arg value="xml:${project.build.directory}/detekt.xml"/>
                        </java>
                    </target>
                </configuration>
                <goals>
                    <goal>run</goal>
                </goals>
            </execution>
        </executions>
        <dependencies>
            <dependency>
                <groupId>io.gitlab.arturbosch.detekt</groupId>
                <artifactId>detekt-cli</artifactId>
                <version>1.0.0-RC14</version>
            </dependency>
        </dependencies>
    </plugin>

Hey take a look what @schalkms mentioned here https://github.com/arturbosch/detekt/issues/1805.
Unfortunately the newer jcommander versions are not published to maven central anymore.
You will have to add jcenter as an additional repository to run detekt.
Maybe you will have more luck with https://github.com/Ozsie/detekt-maven-plugin which may have bundled everything together to maven central.

@arturbosch Thanks for the reply and suggestion. I used https://github.com/Ozsie/detekt-maven-plugin but it is also giving me below error:
[ERROR] Failed to execute goal com.github.ozsie:detekt-maven-plugin:1.0.0-RC16:check (default) on project agathe: Execution default of goal com.github.ozsie:detekt-maven-plugin:1.0.0-RC16:check failed: Build failed with 55 weighted issues (threshold defined was 10). -> [Help 1]
I am quite new to Maven and all this plugin thing and trying to figure out how to resolve this error.

I have answered this in https://github.com/Ozsie/detekt-maven-plugin/issues/25


feat(share): Shwap Bitwap composition

Implements Bitswap composition based on CIP-19 by introducing three Block types for every Shwap container(Row, Sample, RowNamespaceData). Besides, this PR brings Block interfaces that generalize over those new blocks. This interface enables a slightly convoluted general-purpose Fetch function to get any Block type over Bitswap, abstracting all the complexities. Besides, the current architecture provides a horizontally scalable framework for the new blocks that makes it super easy to add new Shwap containers to our protocol, like for future Range and Blob containers.
This is like the ~5th~ ~6th~ 7th iteration of the composition design and the most straightforward one @walldiss and I could come up with the requirements we had.
Respective changes in the spec: https://github.com/celestiaorg/CIPs/pull/159

There are two more things:

[ ] Fetch should optionally be able to store Blocks in the Bookstore
We could do that outside but that would require going through Block conventions and Marshalling again
[ ] The reason we have to limit fetch to 1024 blocks is partially because of this issue

Reading through it, I realized that the current Fetch is inefficient. It fetches batches of blocks synchronously, one after another. Instead, we should be streaming new block requests as old ones are fulfilled


Cannot display blob on page with temporary record; cannot assign blob fields

Not sure if this is actually one or two issues:
I want to insert some pictures into an app. Not wanting to have to think about where to obtain pictures and get them in the db I lazily went to get the base64 signature and hardcoded it as text into the setup wizard rountine we need anyway.
Now I see two strange things not working:

When I stream my text into TempBlob and then to Company Information (to test if it arrived how and  where it should) all seems well and I can see my picture displayed there. Now when I do the very same to my temporary records and display those as a list the pictures do not show. I debugged a bit and to me it seems the blob goes into the temp record as I expect. So maybe there is an issue here? In our On Prem solution a similar approach works fine.

When I assign the blob to records I have to use cumbersome Instream/Outstream/CopyStream because when I simply assign a blob field the code compiles but throws an error at runtime. This happens regardless if the target table is temporary or not. This also works fine in OnPrem Nav using C/SIDE.

I'm working on a bugfix where assigning to a blob field was failing at runtime. The fix should be available in the next update. Could you possibly be so kind to provide me with a small verifiable example which is failing so that I can check if I have you fix?

@DominikDitoIvosevic please find attached:
SimpleBLOBAssign.zip
On the Company Information try these Actions:

@RafaelKoch So I have identified and fixed the problem with assigning to a blob field but I'm having problems identifying why the list doesn't show the picture. I'm still working on that one


Add ProtectedBranches pre-push hook

This hook guards against destructive updates to branches specified in the config.

Merged in 256fe2a, thanks!


Component overflows when used inside a bootstrap column

I see that in the css the width is set to 300px. This has a result the component to overflows when is used inside a bootstrap column as in the following image

Is this a choice or I miss something?

not a deliberate choice, will fix it in the next patch

Hey @furqanZafar, are you still planning on removing the hardcoded width on the root node?

yep, open to PR though, actually planning a rewrite in babel ES6 & adopting BEM for css

I would happily open a pull request but as I mentioned in #69 I am not familiar with LiveScript at all

Until it is resolved, you can overwrite this property with 'width: auto'. That worked for me.