Vqe setup

Added a README to the Z2-VQE directory to help document where the code that implements certain functions can be found. I listed out the main components we will need for the full VQE experiment and tried to reference where the relevant functions are currently living. (Can iterate on this and update it later if we restructure the code).
Also added a function to resource.py for measuring O_{n,n'} but waiting on fully implementing it until its been debugged. The debugging and testing can be found in Z2LGT_BQ_VQE.ipynb.
Side note: how would you (@tjstavenger-pnnl and @EllaCrane) prefer code to be merged into main? Should I continue making PRs from my personal fork? Additionally, if I am only touching code in tutorials/Z2-lattice-gauge-theory perhaps it might make sense to split the VQE project into its own repo? Happy to hear your thoughts.

My answer will be a bit vague, but I think the choice of PR into c2qa-qiskit vs maintaining your own repo/fork comes to if you think others in the community would make use of your work. If it should be shared independent of your work, then I say put it in c2qa-qiskit. If it is dependent on your work and not likely usable outside of what you are doing, then your own repo or fork may be best.
Right now I'd lean towards using the PR you've submitted and merging it into c2qa-qiskit. We don't have a large community yet and the library is still pretty small, so any additions can help us along.
Maybe if your work seems separate from the Z2 lattice surgery effort it may be better in its own Python notebook?

Thanks for the helpful comments @tjstavenger-pnnl, I think for this code the most important thing is that it's in a shared place for @EllaCrane and I. Happy to contribute the c2qa-qiskit if that's the easiest route.
Would you prefer that I merge these PRs myself, or wait till you've had a look and confirm the merge?

I fixed the (another?) resource.py compile error this morning in the main branch that was causing a build error here: https://github.com/C2QA/c2qa-qiskit/runs/6408017686?check_suite_focus=true
It looks like we have merge conflicts though (not from the resource.py).

Closing this since all of its changes were merged in #38


Psi/Frontend: add FSharpScriptFileImpl

it is necessary to distinguish standard files from scripts

it is necessary to distinguish standard files from scripts

Is checking the containing node type much better than checking the file type? I'm not agains this approach, just wondering :)

I fixed it in the tests, so now the main logic looks more obvious


Crash - [FlurryAd openSKAppstore:]

Flurry SDK 7.9.2
com.9gag.ios.mobile_issue_79963_crash_a92dc8994a5146988b6305acc22d7ff2_8c0e11eea34611e78e9e56847afe9799_0_v2.txt

Are you using the Cocoapod or directly embedding the Flurry SDK?
If the latter case, are you including StoreKit.framework?

Closing for lack of response.


MB-14969 factory.BuildContractor added as new version of testdatagen.MakeContractor

Jira ticket for this change
Summary
This ticket adds a factory package with function BuildContractor intended to be an eventual replacement for testdatagen.MakeContractor

Created BuildContractor/FetchOrBuildDefaultContractor and shared functions
Created tests for all of those.
Replaces instances in code where MakeContractor exists with BuildContracor and FetchOrBuildDefaultContractor

Setup to Run Your Code
make server_test should be enough.
Frontend

No frontend changes

Backend

[x] Code follows the guidelines for Logging
[x] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

No schema changes

Messages

:book:
:link: MB-14969

  Generated by :no_entry_sign: dangerJS against 9167b67a0eb84167783980519986f4f0d2d62d5c


Add soft pre-training to mchflurry-train-class1-allele-specific-models.py

Currently only exists in the experiments subdirectory. API should be at least the following flags:
--imputation-algorithm <none, mice, knn, softimpute, svd>
--imputation-use-biscaling

Added --imputation-method but not going to add BiScaler for now since I don't remember it helping anything other than SVD and SoftImpute but not sure if the extra


Update to support latest toml-rb 1.0.0 gem

Update 4.4.1 version to support 'toml-rb' 1.0.0 which was released on June, 14
Thank you for your response!

👍  thanks!

https://supermarket.chef.io/cookbooks/influxdb/versions/4.4.2
enjoy!


[MARKETS-64]: update yarn

Update Yarn to berry

is the yarn/releases/yarn-3.2.1.cjs supposed to be in the repo?
we can also look into deprecating this depo and just making it a shared module

Yeah, that’s the recommended way.
Going forward we could have it distributed via nix and symlinked into .yarn/releases by nix shell / direnv.


download when archive already exists in dir

As per https://github.com/datproject/dat/issues/535, we probably want to download instead of throwing a warning when a dat already exists in a directory.
index.js:104 already has this marked as a TODO:
    if (archive.key && !archive.owner) {
      // TODO: allow this but change to download
      return cb('Dat previously downloaded. Run dat ' + encoding.encode(archive.key) + ' to resume')
    }

Thanks!

this will get fixed in dat library as dat-js exposes more low level things


nan of loss during training

Hello, when i  use my own training data with 11500 pictures, batch size =12 and scale = 2, a problem occurred
[Epoch 1]	Learning rate: 1.00e-4
[1200/10500]	[L1: 11.2929] 	21.0+60.3s
[2400/10500]	[L1: 8.8598] 	20.0+63.7s
[3600/10500]	[L1: 7.7807] 	20.0+69.5s
[4800/10500]	[L1: 7.1179] 	20.0+74.0s
[6000/10500]	[L1: 6.6776] 	20.1+69.4s
[7200/10500]	[L1: 6.3562] 	20.1+75.5s
[8400/10500]	[L1: 6.0822] 	20.0+75.2s
[9600/10500]	[L1: 5.8959] 	19.9+75.0s
Evaluation:
[Sequence x2]	PSNR: 37.031 (Best: 37.031 from epoch 1)
Time: 415.90s
[Epoch 2]	Learning rate: 1.00e-4
[1200/10500]	[L1: nan] 	20.2+46.7s
[2400/10500]	[L1: nan] 	20.1+48.3s
[3600/10500]	[L1: nan] 	20.1+54.2s
[4800/10500]	[L1: nan] 	20.1+60.7s
[6000/10500]	[L1: nan] 	20.2+62.0s
[7200/10500]	[L1: nan] 	20.1+63.0s
[8400/10500]	[L1: nan] 	20.1+68.9s
[9600/10500]	[L1: nan] 	20.1+68.6s
Evaluation:
[Sequence x2]	PSNR: 37.779 (Best: 37.779 from epoch 2)
Time: 403.14s
...
...
...
[Epoch 43]	Learning rate: 1.00e-4
[1200/10500]	[L1: nan] 	19.2+43.1s
[2400/10500]	[L1: nan] 	19.1+42.1s
[3600/10500]	[L1: nan] 	19.1+41.9s
[4800/10500]	[L1: nan] 	19.1+41.7s
[6000/10500]	[L1: nan] 	19.0+45.8s
[7200/10500]	[L1: nan] 	19.1+48.2s
[8400/10500]	[L1: nan] 	19.3+73.3s
[9600/10500]	[L1: nan] 	19.1+62.8s
Evaluation:
[Sequence x2]	PSNR: 39.445 (Best: 39.445 from epoch 43)
Time: 396.57s

Hello.
Although you got 'nan' error, PSNR increases as your training proceeds.
I cannot find exact answer, but I recommend you to print the loss value more frequently, to find when 'nan' starts to appear.
You can use --print_every argument for this task.
Thank you.


Assume yes improvements

Codecov Report

Merging #98 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #98      +/-   ##
=========================================
+ Coverage   90.78%   90.8%   +0.01%
=========================================
  Files          80      80
  Lines        1009    1011       +2
  Branches      154     158       +4
=========================================
+ Hits          916     918       +2
  Misses         77      77
  Partials       16      16

Impacted Files
Coverage Δ

packages/warriorjs-cli/src/parseArgs.js
100% <ø> (ø)
:arrow_up:

packages/warriorjs-cli/src/Game.js
53.2% <100%> (+0.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5bce5...f211678. Read the comment docs.


Replacing NSStringFromClass() with String()

Swaps out NSStringFromClass() for String()

I don't think these are equivalent. NSStringFromClass is guaranteed to round-trip with NSClassFromString; String.init isn't. At the very least it should probably be String.init(reflecting:).


Cannot finish release....

@imagejan @nicokiaru @ctrueden
I don't manage to consistently get rid of this error:
[main 7de1efd] Bump to next development cycle
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 release.properties
error: Your local changes to the following files would be overwritten by checkout:
        release.properties
Please commit your changes or stash them before you switch branches.
Aborting

Sometimes deleting the release.properties file helped, but now it doesn't....
Any ideas? Thanks a lot!

I tried to rerun: ../scijava-scripts/github-actionify.sh -f
I think it did something, but then in the end it gave:fatal: pathspec '.travis.yml' did not match any files
Which seems a bit weird because I don't see any .travis.yml file...
Anyway, it did not help regarding the above error.

I found that now there is only one script: build.yml, while there used to be two in older versions of github-actionify.sh?
Anyway, also this did not fix the issue:
error: Your local changes to the following files would be overwritten by checkout:
        release.properties

Probably something simple and stupid, but I cannot figure it out right now...

Currently you have test errors in your build:
	  java.lang.NoClassDefFoundError: Could not initialize class org.janelia.saalfeldlab.n5.blosc.BloscCompression
  	at dataformats.ngff.v01.YXNgffV01Test.<init>(YXNgffV01Test.java:40)

But you're speaking of a different issue ?

@tischi The release.properties file should not be committed to source control on the main/master branch. If you accidentally committed it, do another commit that deletes it before trying to do a release.

I added logic to release-version.sh to clean up release.properties and pom.xml.releaseBackup so they are less likely to get committed to the main repository branch.

@NicoKiaru Thanks for spotting this, we need sudo apt-get install -y libblosc1 in the setup.sh script. I added this back.
@ctrueden Thank you, but it still is not working. I always delete release.properties and commit the delete before running ../scijava-scripts/release-version.sh --skip-version-check
[main 1f7ddfb] Bump to next development cycle
 3 files changed, 239 insertions(+), 1 deletion(-)
 create mode 100644 pom.xml.releaseBackup
 create mode 100644 release.properties
error: Your local changes to the following files would be overwritten by checkout:
        release.properties
Please commit your changes or stash them before you switch branches.
Aborting
tischer@mac-almf13 mobie-io (main) $ ls -la
total 56
drwxr-xr-x   13 tischer  staff   416B Sep 26 16:27 ./
drwx------+ 300 tischer  staff   9.4K Sep 23 10:47 ../
drwxr-xr-x   15 tischer  staff   480B Sep 26 16:27 .git/
drwxr-xr-x    5 tischer  staff   160B Sep 26 16:22 .github/
-rw-r--r--    1 tischer  staff   158B Aug  3  2021 .gitignore
drwxr-xr-x    9 tischer  staff   288B Sep 26 16:22 .idea/
-rw-r--r--    1 tischer  staff   1.3K Sep 26 16:25 LICENSE.txt
-rw-r--r--    1 tischer  staff   1.3K Sep 26 11:13 README.md
-rw-r--r--    1 tischer  staff   1.3K Sep 23 14:02 genereate_ngff_version_tests.py
-rw-r--r--    1 tischer  staff    67B Sep 23 14:02 log4j.properties
-rw-r--r--    1 tischer  staff   7.5K Sep 26 16:27 pom.xml
drwxr-xr-x    4 tischer  staff   128B Aug  3  2021 src/
drwxr-xr-x   16 tischer  staff   512B Sep 26 16:27 target/

Any more ideas?

Could it be that this log4j.properties file is the culprit?

No, removing that does not fix it.

@tischi Weird, it looks like your autogenerated "Bump to next development cycle" commits are readding the release.properties and pom.xml.releaseBackup for some reason. Investigating now. (It takes me awhile to test, because this repo's unit tests are very slow, and I also have to work around not having push access.)

../scijava-scripts/release-version.sh --skip-version-check

Why are you passing --skip-version-check? This check is important, and should only be skipped as needed. E.g. when a new pom-scijava is freshly released, the index is out of date, and the check detects the wrong version as newest, so you can skip it in that situation, but in general, you want to be updating your parent POM version to the latest pom-scijava whenever one is available. You also want to check that you are performing a valid version bump according to SemVer.

@tischi:

Thank you, but it still is not working. I always delete release.properties and commit the delete before running ../scijava-scripts/release-version.sh --skip-version-check

Are you sure that deleting release.properties has worked (also in git)?
Because  error: Your local changes to the following files would be overwritten by checkout: release.properties
only makes sense if this file is still somehow in git.
Can you paste the output of git status here?

The only thing I can think of, which is a long-shot, is that you have something in your .gitconfig to automatically add untracked files when doing git commit?

@ctrueden you nailed it :rocket:! Turns out my IntelliJ was doing exactly that. Switching that off fixed it! Thank you so much for taking the time to dig into this :heart:


HADOOP-18948. S3A. Add option fs.s3a.directory.operations.purge.uploads to do that on rename/delete

Delete and rename get to optionally purge in-flight uploads.
no test; just a fix for those itests which failed once the production code adds the rule that the path to delete must always end in a / That's needed to avoid deleting uploads in adjacent directories.
How was this patch tested?
s3 london; fixed some s3guard tests which were trying to purge uploads on a path, not a dir.
I do plan to write a new test
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 40s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 12s

trunk passed

+1 :green_heart:
shadedclient
33m 17s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

-1 :x:
javadoc
0m 26s
/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
34m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 59s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

130m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6218

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a72aebdc7eff 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7b4efd32d298118c6171c73fefec1663a4d31e35

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/1/testReport/

Max. process+thread count
722 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 36s

trunk passed

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
1m 11s

trunk passed

+1 :green_heart:
shadedclient
34m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 20s
/patch-mvninstall-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-tools_hadoop-aws-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-aws in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 20s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
0m 20s
/patch-compile-hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-aws in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

-1 :x:
mvnsite
0m 21s
/patch-mvnsite-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
0m 22s
/patch-spotbugs-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
shadedclient
35m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 26s
/patch-unit-hadoop-tools_hadoop-aws.txt
hadoop-aws in the patch failed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

128m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6218

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 84947e004ca4 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 066da370021a6f078d3fcf5d522b9d794fb1a171

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/2/testReport/

Max. process+thread count
738 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
33m 10s

trunk passed

+1 :green_heart:
compile
17m 12s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m  5s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 29s

trunk passed

+1 :green_heart:
mvnsite
2m 49s

trunk passed

+1 :green_heart:
javadoc
2m  8s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m  4s

trunk passed

+1 :green_heart:
shadedclient
34m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
15m 58s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
15m 58s

the patch passed

+1 :green_heart:
compile
16m 11s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 11s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
4m 21s
/results-checkstyle-root.txt
root: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 20s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 18s

the patch passed

+1 :green_heart:
shadedclient
35m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 10s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  2s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

249m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6218

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux a4b86a0d14f1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ba65cf76e59aa6113740d7b6a55609d8f26c1fd9

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/3/testReport/

Max. process+thread count
2159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 36s

Maven dependency ordering for branch

-1 :x:
mvninstall
35m  4s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
19m  9s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 54s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 30s

trunk passed

+1 :green_heart:
mvnsite
2m 54s

trunk passed

+1 :green_heart:
javadoc
2m  8s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 56s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m  1s

trunk passed

+1 :green_heart:
shadedclient
34m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 29s

the patch passed

+1 :green_heart:
compile
16m 24s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 24s

the patch passed

+1 :green_heart:
compile
15m 46s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 46s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 21s

the patch passed

+1 :green_heart:
mvnsite
2m 44s

the patch passed

+1 :green_heart:
javadoc
1m 49s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 21s

the patch passed

+1 :green_heart:
shadedclient
37m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 58s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  1s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

256m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6218

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux c423fd29aec2 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 01c33bbe4ccf8e519cebaf1b99320ac07e4f3dd6

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/4/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 44s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m 45s

trunk passed

+1 :green_heart:
compile
18m 14s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m 31s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 28s

trunk passed

+1 :green_heart:
mvnsite
2m 51s

trunk passed

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 55s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m  0s

trunk passed

+1 :green_heart:
shadedclient
34m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
16m  0s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m  0s

the patch passed

+1 :green_heart:
compile
15m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 23s

the patch passed

+1 :green_heart:
mvnsite
2m 48s

the patch passed

+1 :green_heart:
javadoc
2m  3s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 54s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
4m 19s

the patch passed

+1 :green_heart:
shadedclient
35m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 16s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 10s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
1m 10s

The patch does not generate ASF License warnings.

249m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6218

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint

uname
Linux 3b04d877bd24 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d227ce52c97df493444d406cb669d112978c55bd

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/5/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6218/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


[Question] Can I leverage this for simple OAuth2.0 Client credential grant auth flow on proxy?

@zandbelt I see you have other interesting repo's, I made an issue in your lua oidc repo just the other day that you helped me out with. This should be my last question for a bit. I am playing with an Apache httpd server and was hoping this awesome plugin can meet my needs.
I need to call a gateway and get back an OAuth2.0 token from the gateways token url, cache that token for the time its valid and add it to a header when I  proxy, leveraging the proxy_module + proxy_http_module. Also needs to generate a new token when time is up or 401 unauthorized cause stale token occurs.
I feel like this plugin can achieve that but based on documentation I can't find a basic config i need anywhere exactly. Documentation led me to these potential fields probably:
OIDCRedirectURI https:///redirect_uri
(What point would this  have in my design/what should I set it to???, I don't want to redirect since not true OIDC, more OAuth2.0 client credential grant flow.)
OIDCProviderTokenEndpoint https:gateway.com/my/token/url
(makes sense, no metadata endpoint for me, so configure directly to my OAuth2.0 token call endpoint)
OIDCClientID my_oauth2_clientid
OIDCClientSecret my_oauth2_secret
OIDCProviderTokenEndpointAuth client_secret_post ?
OIDCCryptoPassphrase password (I can add this, guess it is like a salt or something of that nature as it lives in the cache?)
Bold is where my largest confusion is, also wondering if I will need anything else or a config that tells your plugin to add the token as Authorization: Bearer  in headers automagically ?
If manual, maybe in the rewrites.conf file can I just do
RequestHeader set Authorization "Bearer "${OIDC_access_token}
or something you expose that is accessible? Like I said, not super familiar with apache webserver 😆
Thanks in advance if you have seen this case in the past.

as indicated in the text that you deleted from the issue template: please don't use the issue tracker for questions; having said that you probably want to take a look at https://github.com/zmartzone/mod_sts and use that in combination with mod_auth_openidc

Sorry man, you would be correct I was in a hurry this evening didn't read the template. Thanks for your assistance anyways, will review the mod_sts as well.

@jeremyjpj0916  were you able to achieve this. I am looking to setup a proxy at apache for doing the oauth client credential flow


Added Czech translation

I hope I can contribute by adding this Czech translation.

Thank you @vojtasaf ! We will ask someone who can read Czech from the community to review it. In the meantime, you can join our Slack and exchange ideas on personal data policy. You don't have to become a MyData Global member to join the Slack. 😄


brave wallet connection

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
^0.8.1
wagmi Version
^0.10.11
Current Behavior
I added the bravewallet exported from @rainbow-me/rainbowkit/wallets but it does not show up on the modal
Expected Behavior
braveWallet should show up in the connection modal
Steps To Reproduce
No response
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?

@Faraday26 Brave will appear as an option only when using the Brave browser, but it seems like there is actually an issue with a recent release of Brave. Upon testing, window.ethereum is not being set by the browser's injector. Is Brave working for you across any other dApps right now?

@Faraday26 @DanielSinclair Not sure if related to this exact issue, but Brave also has some restrictions for providers: https://wallet-docs.brave.com/provider-availability/

@NakedFool Are you bumping into this too? What extensions and wallets do you have active? MacOS/Windows/Linux? It appears like Brave shipped a buggy v1.49.120 (Mar 9, 2023) release.

Yes, one of our users reported that brave wallet does not function properly so I went ahead and installed both brave wallet and metamask on brave browser, I'm using Windows OS.

@NakedFool Unclear what changed here, but noticed a few things:

Brave's Web3 > Wallet > Default Ethereum wallet setting now has different options between macOS and Windows. On Windows, you have the previous Brave Wallet (prefer extensions) default and on macOS you have Brave Wallet and Extensions, defaulting to Brave Wallet.
Users can only see Brave when Brave Wallet is selected, and Brave Wallet (prefer extensions) or Extensions are selected but no extension is active. If Extensions is selected, users should still be able to interface with MetaMask.
You'll get a console error when Brave Wallet is selected and MetaMask is active, because Brave (now?) blocks MetaMask window.ethereum overrides

    at s (inpage.js:1:50542)
    at r.initializeProvider (inpage.js:1:50942)
    at Object.<anonymous> (inpage.js:1:1104)
    at Object.<anonymous> (inpage.js:1:1165)
    at 1.../../shared/modules/provider-injection (inpage.js:1:1178)
    at i (inpage.js:1:254)
    at e (inpage.js:1:414)
    at inpage.js:1:431

Neither MetaMask or Brave Wallet support the window.ethereum.providers standard, so there's no happy path to use these wallets simultaneously and users will have to switch that setting

Bumping on this as well. Still unable to connect my Metamask even after changing defaults.

@gakonst Double checking this. Are you seeing any console errors from the injector? That seems to be the common pattern when Brave interferes

nope, no error, not even detected

Experiencing the same issue on brave as above. Only see the QR code. Also have Brave Wallet setting as "Extensions" by default.
I have had no problem using the bare Metamask Connector from Wagmi. Now switching to rainbowkit, and it doesn't work.

@gakonst @DanielSinclair Looks like upgrading my Brave Browser has fixed the issue.

Tested against macOS Brave Version 1.50.121 Chromium: 112.0.5615.138 (Official Build) (arm64) and the detection appears to be working as expected again. Will close this issue!


typescript const enum + lodash + webpack

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Uncaught ReferenceError: someEnumName is not defined
If the current behavior is a bug, please provide the steps to reproduce.
if typescript enum is const, and use _.values(someEnumName) webpack crashed.
if enum isn't const everything is okay

Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Chromium 65.0.3325.181 Built on Ubuntu , running on Ubuntu 16.04
node v9.4.0 (npm v5.6.0)

Please provide a minimal reproducible example, thanks

ok this is file.ts
does'not work
import _ from 'lodash';

export const enum someEnumName {
   someEnumField1 = 'SOME_ENUM_FIELD_1,
   someEnumField1 = 'SOME_ENUM_FIELD_2',
   someEnumField3 = 'SOME_ENUM_FIELD_3',
}

export const SOME_VARIANTS = _.values(someEnumName);

work
import _ from 'lodash';

export enum someEnumName {
   someEnumField1 = 'SOME_ENUM_FIELD_1,
   someEnumField1 = 'SOME_ENUM_FIELD_2',
   someEnumField3 = 'SOME_ENUM_FIELD_3',
}

export const SOME_VARIANTS = _.values(someEnumName);

Thanks for your report. It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

Okey i will try do it later

This is not a webpack issue. It's maybe a typescript issue, but I guess it's not an issue at all since someEnumName is a type and _.values doesn't take type. It depends on the error message you get (which you didn't provided).


Error when running render

I just found the module and was trying it, I recorded something and played it, it played fine but when trying to render this error occured
Error:
  Error: [12447:0531/224929.782254:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process.

I am on Linux Mint XFCE

Duplicate issue sorry, closing.


Use reply feature or a different prefix to avoid conflict with Discord markdown feature in #incidents

# is used to provide additional context to an incident report without creating a new ticket. However, due to the new Discord markdown feature,  the messages starting with # turns into heading text
and the messages end up looking huge.
We could use a different prefix or, as suggested  by @import-pandas-as-numpy (sudorem on discord), use the message reply feature.
I personally prefer replacing # prefix with message replies.

I don't mind implementing this change myself, ty.

The message reply idea sounds good to me.
I would also say that it's good to keep this [line] (https://github.com/python-discord/bot/blob/main/bot/exts/moderation/incidents.py#L136) up until people get used to using the new way.
It should be as simple as checking whether the message has a resolved attribute or not IIRC.


New example: Kurtosis portfolio optimization

Description
This pull request adds a new example that shows how to optimize the kurtosis of an investment portfolio using DCP rules as shown in Cajas (2022).
Type of change

[ x] Other (Example)

Looks good! My only request is that the matrix M3 be assembled with bmat instead of in pieces with multiple vstacks. Otherwise looks great!

Hi @SteveDiamond, I made the change using bmat instead of vstack and hstack.

Great, thanks!


Is there a way to preserve child ids when cloning ?

Hello ACE.SVG Fellows :-)
I'm currently writing a script to duplicate and arrange an SVG group according the size of my grafana dataset. This script was initially written (and this part was working fine) for marcuscalidus-svg-panel and I'm porting it to ace-svg-react (for better dataset handling).
When I clone (clone then addto) an existing SVG group, all childs ids are messed up like "SvgjsG<random_number>" instead of their original id. Is there a way to prevent this ?

I think that is the behavior of svg.js. The raw SVG code is available in the options object, you could potentially parse it as vanilla DOM code and then generate an SVG.js object for each child node you want, does that make sense? However if you create an ID conflict, things are likely not going to work well for you. On the other hand, classes should be preserved over clones, so you could potentially add classes, then access them with each cloned DOM fragment handle.

Closing due to no follow up.


pd-client: share the connection when GetStoreMinResolvedTS from PD

Hi,
currently, we try to GetStoreMinResolvedTS for all stores from PD every 2 seconds
https://github.com/tikv/client-go/blob/719e6456f7d5d59d45b70b77a36b450b6ce41c86/tikv/kv.go#L602-L607
Here we use http request and do not share the connections.
https://github.com/tikv/client-go/blob/719e6456f7d5d59d45b70b77a36b450b6ce41c86/util/pd.go#L89-L94
This will be a problem (too many connection handshakes on PD) when there are a large number of tikv and tidb instances. For example when we have 100 tikvs and 100 tidbs, then the connections for pd/api/v1/min-resolved-ts to PD would be 100*100/2=5000 in 1 seconds. this will be a great pressure for PD. Meanwhile, From the above code on L92, it is possible that the first address is not the PD leader, and then it will cause the increasement of PD followers connections/CPU too.
Here comes the suggestion: Use GRPC(pd-client) to GetStoreMinResolvedTS instead of http-client, which will share the connections and check the pd's leader regularly

@HuSharp Please take a look, thanks!

related issue https://github.com/pingcap/tidb/pull/43737

When enabling TLS, it would waste so much time on TLS handshake

@AndreMouche @Connor1996 This is the reason why we need http api https://github.com/tikv/pd/issues/6386
I think it's not a better way just to remove it

For example when we have 100 tikvs and 100 tidbs, then the connections for pd/api/v1/min-resolved-ts to PD would be 100*100/2=5000 in 1 seconds.

To focus on this issue, I tried to extend the api to get the stores together, which reduces it to 1 * 100 / 2 = 50
Do you think this is a solution?
PTAL, thx!
pd: https://github.com/tikv/pd/pull/6880
client-go: https://github.com/tikv/client-go/pull/921

@HuSharp Why not provide a gRPC API?

@HuSharp Why not provide a gRPC API?

Oh, I misunderstood you, I'll provide the grpc that got all the store's ts later.

/severity major


The included agent AI gets stuck when trying to leave a shop

When running the AI, the game currently gets stuck for me when the agent has completed shopping and is trying to leave a merchant store.
Manually leaving the store allows the agent to continue and it can complete the other parts of the run.

From running the AI some more, it looks the problem is in CommunicationMod not performing the leave/cancel correctly, and it looks like the problem does not trigger when some actions are made instant by SuperFastMode.
So this might e.g. be a race condition where the cancel command is sent and attempted to be triggered by CommunicationMod before the game actually accepts it.

I haven't been able to reproduce this behavior with Communication Mod, unfortunately. I believe someone else also reported the same issue to me a few months ago, but neither of us were able to figure it out then, either.
Likely, Communication Mod has received the command to leave the shop and attempted to execute it. However, somehow leaving the shop did not work, so because the game state has not changed, no message is ever sent back to the AI, and it waits patiently. The problem would be on the end of Communication Mod here. It may be sensible to make commands "time out" in case they do not produce a state change for whatever reason.

I believe this is now fixed in Communication Mod 1.0.1.


Add myetherẉalletṭ.com blacklist

It's a clone site. The most interessant is that letter ẉ and ṭ is from vietnam alphabet. https://myetherẉalletṭ.com/

Looks like you don't have the updated master - so I've committed it myself. Thanks for the report!
https://github.com/409H/EtherAddressLookup/commit/dbd6af736b1beb1b89cc405667effe073ba05ece


Add nixpkgs module (fix #74)

Although I like the sort of elegance of such a short solution, I don't think we should be making the module list of perSystem strict in a Nixpkgs input.
For instance, when a flake exports an overlay with easyOverlay, pkgs will be set to the overlay final parameter, and it would be bad to have to fetch an unused Nixpkgs just to load its entrypoint module, and then find out that the only effect of that module is going to be overridden anyway.
So architecturally, it should look more like #137, except perhaps a simpler implementation.


Using Bot name

Bot isn't responding /mirror cmd if COMMANDS_USE_BOT_NAME: is kept true. If it's kept for false it will not respond of other cmd default by telegram.. So its better to make /mirror too not to have username after the command.. Thank you.. hope you got it!

The only function of COMMANDS_USE_BOT_NAME  is to make you address the bot by its username. Setting it to false will let you use /mirror. If you want to use commands from Telegram's suggestions, you have to set it to true. As most of the commands take parameters anyway, what you suggest is counterintuitive.
This is intended behavior.
Long pressing the Telegram suggestion on the mobile client will fill out the /mirror@botname for you. That doesn't work in the desktop client, though.


chore: upgrade underscore to patch CVE-2021-23358

Published: +<EMAIL_ADDRESS>@crgwbr @yokuze @jimjenkins5


merge Land class with water and cloud segmentation

[x] Merge Land Class
[ ] Merge Water Segmentation
[ ] Merge Cloud Segmentation


Cross proxy

This provides support for proxying mesos request through node js server so we can reuse same code base while keeping both approaches either deploying this app via marathon or running it as the default mesos ui

Can we update the readme as well, with how the different Dockerfiles work


Don't filter values when selecting fields with wildcards

Wildcards may yield 0..* instances, each with a different path, so we may want to skip the filtering which was originally built for #331.
Fixes #531
Fixes #458

Coverage remained the same at 100.0% when pulling 89124c6d7c76bdd37884c0eb22458249a2216ca9 on 531-wildcards-undefined into 3ecc0080d04a1e35cc20805ad8b88c65a9b2498d on master.


merge latest

This PR addresses GitHub issue: #
Briefly describe the changes proposed in this PR:

...
...
...

Make sure you've followed the Contributor Guidelines. In particular (please tick to indicate you've taken care of it):

[ ] RDF4J code formatting has been applied
[ ] tests are included
[ ] all tests succeed

….0.x

Ignore, wrong direction.


Update with cqm-models QDM::Date Basetype

Pass-through PR to get cqm-models into Bonnie.
Pull requests into cqm-execution require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[x] This pull request describes why these changes were made.
[x] Internal ticket for this PR: https://jira.mitre.org/browse/BONNIE-2076
[x] Internal ticket links to this PR
[x] Code diff has been done and been reviewed
[x] Tests are included and test edge cases
[x] Tests have been run locally and pass

Reviewer 1:
Name: @hossenlopp

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #63 into 2019-standards-update will not change coverage.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           2019-standards-update      #63   +/-   ##
======================================================
  Coverage                  87.09%   87.09%
======================================================
  Files                          6        6
  Lines                        705      705
  Branches                     212      212
======================================================
  Hits                         614      614
  Misses                        91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df75e31...dc477c9. Read the comment docs.

Just needs the cqm-models PR to get in, then I'll approve.


Remove Connect screen

@markmhx I moved this to app, which is where the relevant change would be made. I think we may have lost Zenhub metadata, please re-add if necessary.

@hstove @aulneau could one of you tackle this one today since @kyranjamie is going offline soon?

Yes, I'll take it.

Hey @timstackblock , can you QA this?
The change is that we removed the final sign up screen where you re-enter your secret key. Now, when you click "I've saved it", you should finish authentication.
I just updated Banter to use this - it should be deployed in ~5 minutes.

this is working as expected on Banter


Provides temporary solution for API output of translatable fields.

Solution 1 for #4922:
Temporary fix for translatable fields.
If no specific language requested, attempt return English value first.

Sweet :+1:


Color picker plugin

https://discordjs.guide/popular-topics/canvas.html#getting-started
Use Canvas to send an image of just the target color

fixed by #412


Init Trunk and fix ESLint issues

Hi there, I opened a PR for you to try Trunk Code Quality.
Code Quality will do these things:

Lint on files changed each commit
Hermetically install each linter and manage them (so they run the same on every environment and don't pollute dependencies)
Fixed existing ESLint issues.
When introducing new linters, they will by default, only run on new issues on the files you change, so this allows progressive enhancement.

Somethings we could do further with Code Quality

Run in your GitHub actions
Annotate PRs for files with formatting and linting issues
Enable Trivy and OSVscanner that require network access, but scans for dependency issues
Customize ignore and linters.
Install Trunk VSCode plugin for LSP annotations.

I enabled the following linters, automatically suggested by Code Quality to cover more of your code.

General-purpose linters:

<EMAIL_ADDRESS>(Code formatter for multiple languages)

Language-specific linters:

<EMAIL_ADDRESS>(JavaScript/TypeScript)
<EMAIL_ADDRESS>(Markdown)
<EMAIL_ADDRESS>(YAML)

Security and vulnerability scanners:

<EMAIL_ADDRESS>(Infrastructure as Code security)
<EMAIL_ADDRESS>(Open Source Vulnerability scanner)
<EMAIL_ADDRESS>(Container and filesystem vulnerability scanner)
<EMAIL_ADDRESS>(Secrets scanner)

Docker-specific linter:

<EMAIL_ADDRESS>(Dockerfile linter)

Git-related tools:

git-diff-check (Git diff checker)

CI/CD specific linters:

<EMAIL_ADDRESS>(GitHub Actions workflow linter)

New commands

npm lint lint but don't fix
npm lint:fix lint and prompt to fix
npm fmt run formatted
lint-old the old command for reference.

Lmk if you have questions!

@gewenyu99 Thanks for the PR


Implement Bitrate Information

Is it possible to Show the Bitrate of the current Stream?

@fethica please implement bitrate information

@fethica yes this would be a great supplement to this fantastic player, please implement. :)


💅 (LLD): Firmware update banner rework

✅ Checklist

[x] npx changeset was attached.
[x] Covered by automatic tests.
[x] Impact of the changes:

Firmware update banner on LLD

📝 Description
Updated the Firmware update banner for Ledger Live Desktop

Before
After

❓ Context

JIRA or GitHub link: LIVE-13042

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

/generate-screenshots


Null pointer panic in deletion_controller

GCP is currently having some issues with networking in one of my regions. This seems to have caused Ark to panic. Here's the stack trace:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1d0 pc=0x10cac15]

goroutine 2724 [running]:
github.com/heptio/ark/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/go/src/github.com/heptio/ark/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:58 +0x111 panic(0x182f800, 0x27a5570)
	/usr/local/go/src/runtime/panic.go:491 +0x283
github.com/heptio/ark/pkg/controller.(*backupDeletionController).processRequest(0xc420098790, 0xc4210cc3c0, 0xc4210cc280, 0xc4210cc280)
	/go/src/github.com/heptio/ark/pkg/controller/backup_deletion_controller.go:220 +0x545

Thanks for reporting this. We’ll investigate tomorrow.
On Wed, May 16, 2018 at 10:45 PM Robert Terhaar<EMAIL_ADDRESS>wrote:

GCP is currently having some issues with networking in one of my regions.
This seems to have caused Ark to panic. Here's the stack trace:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x1d0 pc=0x10cac15]
goroutine 2724 [running]:github.com/heptio/ark/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
/go/src/github.com/heptio/ark/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:58 +0x111 panic(0x182f800, 0x27a5570)
/usr/local/go/src/runtime/panic.go:491 +0x283github.com/heptio/ark/pkg/controller.(*backupDeletionController).processRequest(0xc420098790, 0xc4210cc3c0, 0xc4210cc280, 0xc4210cc280)
/go/src/github.com/heptio/ark/pkg/controller/backup_deletion_controller.go:220 +0x545
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/heptio/ark/issues/497, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAABYl48PbFiKFWA1lDWYWs6eEpKin-Gks5tzOQsgaJpZM4UCU5Z
.

I see what the problem is. We're checking for an error but not returning early when we encounter one: https://github.com/heptio/ark/blob/5d74a92cf1ddd4288ef4de49ac16649669636adc/pkg/controller/backup_deletion_controller.go#L212-L214.
And then when we proceed past that error:
https://github.com/heptio/ark/blob/5d74a92cf1ddd4288ef4de49ac16649669636adc/pkg/controller/backup_deletion_controller.go#L220
backup is nil.
We'll get a fix in for this. I'm also curious why the patch failed - do you have the ark pod logs from that time?


404 Search "See all results for ..."

Describe the bug
Using the search-Field and clicking "See all results ..."
To Reproduce
Steps to reproduce the behavior:

Go to 'https://www.freecodecamp.org/'
Click on 'Search Field' and enter s.th. I did "Flutter" and then I clicked "See all results for Flutter"
See error: "404 Page not found"

I think the error is easy to fix:
The automatic created result link after clicking has double "news"-part:  https://www.freecodecamp.org/news/news/search/?query=Flutter
if I manually remove one "news" as https://www.freecodecamp.org/news/search/?query=Flutter
the result would be the correct one.

@uwsd Thanks for the report!
It seems it's a problem with redirection.

https://freecodecamp.org/ redirects to
https://www.freecodecamp.org/news

and the link is to

https://freecodecamp.org/news/search/?query=flutter which redirects to
https://www.freecodecamp.org/news/news/search/?query=flutter

cc: @raisedadead

Thank you for reporting this @uwsd. This was also a problem on /news. I deployed a quick fix and am working on PRs now.
I noticed that we could change the URLs in the search related files from https://freecodecamp.org/news/search/?query=flutter to https://www.freecodecamp.org/news/search/?query=flutter. This seems to get around the problematic redirect, at least for search results. Still an issue we need to investigate further for other use cases.

@scissorsneedfoodtoo search is still broken? I can't get anything to load for generic searches.


Package manager could warn user when uninstall didn't remove all files

If you install ffbase, load it, then try to uninstall, uninstall will not be able to delete ffbase/libs/x64/ffbase.dll.  You have to reset the REPL, then you can manually delete the leftover file.
The user experience is that after uninstall, ffbase still shows up in the list of installed packages, which can be confusing.
After uninstall is done, we could check if the folder still exist and warn the user that some files could not be deleted and will have to be removed manually.  Right now there are no warning/errors being displayed in REPL.
We could also fix up the result of installed.packages to remove packages that don't have a NAMESPACE file, so it doesn't show up in the UI anymore. Though if we do that, we open ourselves up for another error later on, if they try to re-install ffbase after they've installed, loaded, uninstalled it.  It fill fail to re-install:
Warning: cannot remove prior installation of package ffbase

100% same effect as RS. R unloads R part of the package but it is unable to unload native dlls.

Here is what you get in RS though if you
a. install and load ffbase
b. uninstall ffbase
c. try installing it again


[stdlib] Immediate reconfiguration

Motivation
Previously reconfiguration happens in a two step protocol:

Association submits a transaction to declare changing of a validator info.
The real change is going to be calculated and applied in the block prologue.

This is a bit redundant as such change should happen not so frequently, emitting a reconfiguration immediately at step 1 is a much cleaner approach. This PR will change the reconfiguration protocol to a one phase protocol: The moment a validator info gets changed we will emit a reconfiguration event within the same transaction.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Modified existing test cases.

:umbrella: The latest upstream changes (presumably 95ffa7240864df2c201950f41db78ca253503001) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably 9ffd93b6ece1857973cec3bf0ca1b71457358ce4) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=sblackshear

:pushpin: Commit c5bc123 has been approved by sblackshear

:hourglass: Testing commit c5bc123d84a530f2f96fc82aa9b98dab1563ab50 with merge 24b010a0ba658cbd22321527ab4911478475038e...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing 24b010a0ba658cbd22321527ab4911478475038e to master...


Speed improvements && wNAF && constant-time multiplication

Hello. Subj. Last commit changes API of ProjectivePoint/PointG1/PointG2 for allowing batched pairings, which cannot be used with verify/sign, so feel free to revert it.
New benchmarks:
getPublicKey(small) x 120 ops/sec @ 8ms/op
getPublicKey(big) x 118 ops/sec @ 8ms/op
sign x 7 ops/sec @ 134ms/op
aggregateSignatures x 157 ops/sec @ 6ms/op
verify x 12 ops/sec @ 78ms/op
pairing (batch) x 51 ops/sec @ 19ms/op
pairing (single) x 45 ops/sec @ 21ms/op

AWESOME! Please fix indentation in pairing.test.ts, it uses tabs right now.


Allow to pass in editor options to vscode.open command

Enables https://github.com/Microsoft/vscode/issues/30674

Well, there is this 		export function showTextDocument(document: TextDocument, options?: TextDocumentShowOptions): Thenable<TextEditor>;  which makes me believe we don't need this

@jrieken that is true, however my feeling is that many extensions (including even the Git one from @joaomoreno) simply use vscode.open as convenience to open a file without having to do the openTextDocument+showTextDocument dance.
This change aligns vscode.diff and vscode.open commands with regards to the editor options that you can set.

simply use vscode.open as convenience to open a file without having to do the openTextDocument+showTextDocument dance.

We can make an easy fix for that and allow to pass an Uri in addition to a document. Having all the commands for frequent use isn't good API, it's untyped, hard to discover. If something is a common scenario it should be come real API

@jrieken yeah that sounds like a good approach. However, I would argue if we have such API we should maybe think about deprecating vscode.open for text resources and only allow to use it for opening links and maybe binary files. What I am trying to get at is that the current extra argument for ViewColumn does not make sense when passing in a HTTP URL. So this command is already a bit weird.

Continues via https://github.com/Microsoft/vscode/pull/30829


Underscore in file name of ps1 to be analyzed generates an error

Underscore in file name of ps1 to be analyzed generates an error
Error Message:
Invoke-ScriptAnalyzer .\download_ignite.ps1
Invoke-ScriptAnalyzer : Illegal characters in path.

FYI for the PSScriptAnalyzer team, this bug is fixed in my PSv3 compatible pull request, along with some other path issues (support for PowerShell paths).  If you're going to fix it before merging my pull request, I recommend you do so using the same changes I applied to my pull request.

We will take a look at the problem and let you know when we have the fix ready. Thanks!

Thanks Kirk for being on the ball !!

Thanks @bigoals365  and @KirkMunro. This bug should be fixed in #221


Feature sensor configuration

added sensor configuration options for ColorSensor and TouchSensor

available ColorSensor positions are:

front (default)
back
left
right

available ColorSensor alignments are:

down (default)
horizontal

available TouchSensor positions are:

front (default)
back

Sorry, I forgot to create a new branch for this. Please make this pull request to merge into the newly created branch feature/simulation and I will merge it asap. Thank you!


[gigasecond] Add a test to check that input is not mutated

Adds a test to the gigasecond exercise make sure the input is not mutated, since there are some solutions which will pass the current test suite that will mutate the input, which is undesirable. I've now encountered at least twice while mentoring solutions that appear to be correct, but mutate the input, so it makes sense to include this case in the test suite.
Added directly here instead of the problem specifications repository, because unfortunately it's a test case that cannot be defined generically.

Mutating the input and then going back to the initial value will make the test to pass (but I've still made a mutation):
  inputDate.setDate(15); // random mutation
  inputDate.setDate(4); // going back to the original value

So using toBe() instead of toEqual() might be a better idea since it tests if it's still the same object, not just the same value.

Interesting point @ovidiu141! However, I'm not aware of any way to actually change the input argument to be a different object (if you assign to an identifier with the same name you'll just be creating a shadow local variable with the same name). So the most that can be done is internal mutation of the argument object and therefore I think we can only check if the object has the same value coming out as it did going in. Please correct me if I'm wrong.

@paparomeo I agree. I am also not aware of any way to change the reference of an input argument, so toBe() seems to not be the answer here. I was wrong.
In this case I think it's impossible to have a test witch really tests if the object is not mutated at all. Your test is good enough, but does not cover the case I mentioned above.
Example showing how your test passes, even if mutation is made:
const gigasecond = date => {
    date.setDate(15); // Actual mutation
    date.setDate(4); // Another mutation, but going back to the original value
};

test('does not mutate the input', () => {
    let input = new Date(Date.UTC(2020, 0, 4, 20, 28, 30));
    gigasecond(input);
    expect(input).toEqual(new Date(Date.UTC(2020, 0, 4, 20, 28, 30)));
});

I dug a little deeper into this one, thinking that if Date instance could be frozen we could approach the test from that angle, but unfortunately it seems they aren't, so I think this is the best we'll achieve. I think it's good enough, since the main goal is to prevent students from incorrect using date.setUTCSeconds to solve the exercise.

Hi there!
I've thought about this for a bit. In order to accept this change, I want to add a few lines to the README.md, via a HINTS file. It has to state that the input must stay unaltered. Otherwise we are testing for implementation without guiding the student in the original description that it shouldn't change.
Follow these instructions to add a hint file and regenerate the README. Once that is done, please also create an issue in the javascript-analyzer repository so we can automatically test for this (we already do !!, but then it can be ensured as opposed to suggested).

@SleeplessByte: .meta/hints.md file added with hint about mutation and README.md regenerated. exercism/javascript-analyzer#62 created.


[SMALLFIX] Do not log warning when promoting a block that does not exisit

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15437/
Test PASSed.

See https://github.com/Alluxio/alluxio/pull/5469


Is it possible to collect some segmented data sets as new modules of the project?

First of all, thank you for sorting out all the excellent projects about segmentation. Could you please provide some segmented datasets as the new modules(Contents) of this project

Thanks for your suggestion!
I added some popular datasets that are widely used in VOS as a new content.
Any further suggestions are always welcomed :)

Thanks for your suggestion! I added some popular datasets that are widely used in VOS as a new content. Any further suggestions are always welcomed :)

Thank you

Thanks for your suggestion! I added some popular datasets that are widely used in VOS as a new content. Any further suggestions are always welcomed :)

I want to know the label list for the ID，Where I can get？
https://youtube-vos.org/dataset/vis/      about  annotations.json   category_id   and  label list   like：  category_id ： 26  is person   label

In VOS, IDs have nothing to do with certain categories.
Each object is annotated by different color just for distinction with other objects.


[1Pt] Authentication

The user logs in to the website, only by typing the username

User login/sign-up using only username


New Asset Metadata App with Brand Fetching Features

[X] Applied new UI
[X] Update the colours as per the brand's primary and secondary colours -
[X] Update the in-app logo per the brand logo fetched -
[X] Tracks/capture errors using Sentry
[X] Added Signal Ready.
[X] Added Theme option selection setting -
[X] Support Standard Screen Sizes - As per [Supported Screen Resolutions] (https://github.com/Screenly/Playground/blob/master/docs/resolutions.md) -

ToDo

[ ] QA is done by at least two or more members

From my perspective, this code overuses the ?: operator. As for me, it's fine to have ?: for something short, though.
@iamplugged @rusko124, what do you think?


feat: Add feature gates to manifest

This provides an easy way to configure the feature gates when installing the provider.

Very neat, thanks @avorima!


Keyword arguments for IO.new

This code is a mess, I don't think I've ever written so many nested if-statements without a deadline. And it's only partially because the Ruby code has to keep backwards compatibility in the options and provides like 4 different ways to set the encoding, which may clash, or might just overwrite things.
Another issue is that we extract the keyword arguments in the bindings, which results in 8 extra arguments to initialize, and we'll have to repeat that for every other method that uses these keyword arguments. This should be refactored to pass along the complete keywords arguments structure. Next, the interpretation of these keyword arguments should be extracted or combined with fileutil::flags_obj_to_flags, so we can reuse this code.

So, this works, I think the code is of acceptable quality, and it's relatively easy to reuse for other IO keyword entries (I added IO.read as an example of the next rewrite.
Next up should probably be adding keyword arguments to File.new, but I kind of want to take a break from IO now.

@seven1m  I merged this change, and added an issue to do that refactoring whenever I can stand to look at this file again :wink:


Adding tests to CI

Note:

unittest != pytest (and you shouldn't add unittest, and expect pytest to find it)
pytest has a convention on test discovery using file name - so should name file like test_*.py


AverageImages Laplacian sharpening reference

We have a manuscript in revision where we used ANTs to generate a multivariate template for an atlas. We went with the AverageImages normalization flag = True in the template construction script, so the final templates are mean normalized and Laplacian edge enhanced. We'll need to justify going with this normalization in the manuscript.
Intuitively, it makes sense to edge enhance the template in order to emphasize boundaries in the optimization, but I'm having trouble finding any references to cite on this. Did the ANTs team ever publish this approach? Also, do you know the weight for the Laplacian filtered image used by ITK (sharpened image = original image + weight * Laplacian filtered image)?
Great fan of ANTs BTW! Using it almost exclusively for mid-space and group template generation.

this is the method
http://www.ncbi.nlm.nih.gov/pubmed/19818860
it's not exactly what's in nick's script but the basic idea is there .... i do not believe there is any laplacian filtering going on.

maybe you are referring to our approach to "inverting" the averaging process ... as you can see in the reference above, we attempt to re-estimate a shape and appearance average image, iteratively.  this involves both (short time/approximate) inversion of the average diffeomorphism and also inversion of the blurring induced by intensity averaging (soft sharpening).  these two steps together producer a sharper template.

Thanks for the quick response and the citation!
Both antsMultivariateTemplateConstruction.sh and antsMultivariateTemplateConstruction2.sh seem to default to using the mean of normalized intensities to generate intermediate and final templates from the warped image sets (eg https://github.com/stnava/ANTs/blob/master/Scripts/antsMultivariateTemplateConstruction2.sh#L94).
So normalizei is true in AverageImages.cxx and the final mean image is Laplacian sharpened at https://github.com/stnava/ANTs/blob/master/Examples/AverageImages.cxx#L155.
Is the Laplacian filtering/sharpening just a practical implementation of the the blurring inversion (soft sharpening) in the reference?

interesting ... see:
https://github.com/stnava/ANTs/blob/master/Examples/AverageImages.cxx#L150
which is commented out ... anyway, the only difference is that the laplacian filter moves too aggressively towards the next step so it's a minor difference, probably.
but yes it is a practical implementation of what we were doing in that paper.

Thanks for clarifying - this all makes a lot more sense, particularly with the background from the hippocampus paper, which we'll definitely be citing in the revision. Thanks again for the quick responses!


Create global test environment

Create global test environment.
Add contributors sections to readme.
Create separate test file.
Update packages.

package-lock.json

https://acdcjunior.github.io/npm-package-locks_npm_notice_created_a_lockfile_as_package-lock-json_you_should_commit_this_file.html
Should I commit it?
Yes.

package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates.

We don't need package-lock.json in this repo. Npm needs it, and automatically creates when it is absent.

https://github.com/ilhan-mstf/jest-puppeteer-test-automation/pull/1#issuecomment-544924803
package-lock.json removed


[Create New Issue]: Why .NET

Description
Advantages of .NET over other frameworks, uses of .NET and so and so on.
Domain
Backend Dev (.NET)
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assing

/assign

Documentation merged. Closing issue.


fix: remove unused imports from BetaAnalyticsDataBaseClient and Alpha…

…AnalyticsDataGapicClient

These classes are autogenerated, so this PR would just get overwritten.
You already made a PR like this and we closed it: https://github.com/googleapis/google-cloud-php/pull/6511


fix: getAttestationsForBlock performance issue

Motivation
Get aggregated attestations for block production may take up to >1s, this PR improve it
Description

Was able to reproduce the issue, it took ~1s in the benchmark, after all it takes ~100ms in the worse case
Some improvements:

Group attestations not just by attestation data but by slot & index so that we can get committee once and we run the participation function way less. This is possible thanks to the attestation validation against the state
The participation function was changed from seenAttestingIndices to notSeenAttestingIndices which makes the logic simpler
The attestation validation function is cached by beaconBlockRoot + targetEpoch
Ignore attestation data if the max possible score is even less than the lowest score for included attestations

Closes #6334

bringing back finalizedSync.test.ts from #4759 to make sure vc publishing good block with qualified attestations and the chain can finalize, without it I'm not confident to get this work in considering our failed sim test.
Even when sim tests is green, I think it's still good to have this e2e test:

it's basic functionality to make sure validators publish good block and the chain can finalize
it's different to sim test where it contains lodestar nodes only
it's easier to debug when there is an issue
in the past we made the timeout so big (10 minutes) that's the the reason we moved to sim test, however now it takes only <1.5 minute

cc @nazarhussain @wemeetagain

holesky_produced_block_884610.json.zip
produced this block in holesky using curl http://localhost:9596/eth/v3/validator/blocks/884610?randao_reveal=0xa84817d056d083544cb187e6fedf8865dda4a6a477b32b1e2ee7c3caaa67f2a141a92121cc75ee4d93efac5a2d20d76a137168115dbc01d48f5fc97355f9c541d09016c5ff80a27d9e073493a2a604c044c78722b852843c1a286f8d7925dee2 -o block.json
it looks good with 128 attestations, most of them are for previous block slot

:tada: This PR is included in v1.16.0 :tada:


OpenIdConnect Middleware doesn't send the code_verifier in params for getting access token

Hello,
I have tried to use PKCE with OpenIdConnect middleware - something like this:
Startup:
.AddOpenIdConnect("oidc", options =>
{
...
options.Events = new OpenIdConnectEvents()
{
OnRedirectToIdentityProvider = OnRedirectToIdentityProvider,
OnAuthorizationCodeReceived = OnAuthorizationCodeReceived
 };
}

Events:
 private async Task OnAuthorizationCodeReceived(AuthorizationCodeReceivedContext authorizationCodeReceivedContext)
        {
            var authenticateResult = await authorizationCodeReceivedContext.HttpContext.AuthenticateAsync("TempStateCodeVerifier");
            var codeVerifier = authenticateResult.Principal.FindFirst("code_verifier").Value;

            authorizationCodeReceivedContext.ProtocolMessage.Parameters.Add("code_verifier", codeVerifier);
        }

        private async Task OnRedirectToIdentityProvider(RedirectContext redirectContext)
        {
            var verifier = CryptoRandom.CreateRandomKeyString(64);
            var challenge = verifier.ToCodeChallenge();

            var tempId = new ClaimsIdentity("TempStateCodeVerifier");
            tempId.AddClaim(new Claim("code_verifier", verifier));

            var claimsPrincipal = new ClaimsPrincipal(tempId);
            await redirectContext.HttpContext.SignInAsync("TempStateCodeVerifier", claimsPrincipal);

            redirectContext.ProtocolMessage.Parameters.Add("code_challenge", challenge);
            redirectContext.ProtocolMessage.Parameters.Add("code_challenge_method", "S256");
        }

In method OnAuthorizationCodeReceived I have tried add the code_verifier but in POST request doesn't contain this parameter.
It get an error:

OpenIdConnectProtocolException: Message contains error: 'invalid_grant', error_description: 'error_description is null', error_uri: 'error_uri is null'.

An authorization request contains - code_challenge and code_challenge_method correctly but request for getting access token - doesn't contain in request body code_verifier.
The POST request - on /signin-oidc - contains only: code, id_token, scope, state, session_state
This issue is connected with this: https://github.com/aspnet/Security/issues/1476
How can I solve this problem?
Thank you.

How can I solve this problem?

You add your code_verifier to the wrong OpenIdConnectMessage instance. Use authorizationCodeReceivedContext.TokenEndpointRequest instead of authorizationCodeReceivedContext.ProtocolMessage and it should work.

@PinpointTownes You are awesome - works perfectly!
Thank you for your reply. :)

Glad I coud help! :call_me_hand:

@PinpointTownes I am still wondering about if it is correct solution store the code_verifier in temp cookie like above - what do you think about it? Thank you.

I am still wondering about if it is correct solution store the code_verifier in temp cookie like above - what do you think about it?

You don't have many options.
You could store the code verifier in the authentication properties (that are later encrypted and are serialized in the state parameter), but this would almost defeat the whole purpose of using PKCE... because if an attacker managed to steal the code, changes would be very high he'd also be able to steal the state (containing the correct code verifier) and use it on his own machine.
Other options might include manually storing the verifier in a database, or using sessions + a distributed cache like Redis. Not sure they'd be better, tho'.

@PinpointTownes Thank you for your ideas. :) I appreciate that. For now I stay in the cookie and maybe later I'll try implement another solution as you mentioned.


tmt tests import -> traceback for missing RunFor

I was missing RunFor in the Makefile and I got traceback.
Please make it nicer message instead and make sure all expectated values from Makefile are in try/except because they will be missing for someone :)
Traceback (most recent call last):
  File "/home/lzachar/.virtualenvs/tmt/bin/tmt", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/home/lzachar/_important_/Gits/tmt/bin/tmt", line 11, in <module>
    tmt.cli.main()
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/lzachar/.virtualenvs/tmt/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/lzachar/_important_/Gits/tmt/tmt/cli.py", line 497, in import_
    path, makefile, nitrate, purpose, disabled)
  File "/home/lzachar/_important_/Gits/tmt/tmt/convert.py", line 135, in read
    r'^RunFor:\s*(.*)', testinfo, re.M).group(1).split()
AttributeError: 'NoneType' object has no attribute 'group'

@hegerj, would like to take this one?

@psss sure


[question] Changing the number of envs for LSTM policies

BaseRLModel implies it's not currently possible to change the number of environments for LSTM-based policies.
"Error: the environment passed must have the same number of environments as the model was trained on." \
"This is due to the Lstm policy not being capable of changing the number of environments."

I'm really only interested in the test case - once the model has been trained using X workers, I'd like to test using a single worker.
Why is it not possible to change the number of environments? From what I can tell, rollouts are passed sequentially from each worker to the policy for updates. From my vague understanding, the policy networks shouldn't be able to tell how many workers there are.
Anyways, I have a few questions:

Are there any workarounds that would allow me to test on a single environment, using weights generated from multiple environments?
If not, are you aware of why there is a restriction on the env size? Is this something I can easily fix, or is there some deeper underlying issue?

@araffin Is probably going to link bunch of related issues on this (I could not find them), but I will quickly give solution to 1): Pad your observations with zeros until they match the number of envs. This padding won't change the results of the actions for that one environment, as the batch elements are handled independently.

Hello,

Are there any workarounds that would allow me to test on a single environment, using weights generated from multiple environments?

As predicted by @Miffyli , the answer is here ;) :
https://github.com/hill-a/stable-baselines/issues/166#issuecomment-502350843

If not, are you aware of why there is a restriction on the env size?

I couldn't find the issue where that was discussed... but this is a deeper underlying using due to static graph. Also, as mentioned in numerous issues (a quick search in the github issues will give you some examples), LSTM code is one of the most complex thing of stable-baselines and we did not really have the time to dive into it.

Perfect, that example in #166 looks to be exactly what I need. Thanks!


Error handling is inconsistent

The internal getch function has completely different error-handling behavior depending on platform:

The BSD code ignores the potential error (a -1 return) from the read() call, so if it fails, it returns an undefined value, since it reads stack memory.
The *nix code panics (not ideal)
I'm not a Windows expert, but it looks like it ignores the errors completely. I'm imagining the return value is zero since Go zeroes the value?

My proposed fix is to make the functions in this package return an error.  I know this is a breaking API change.  To maintain compatibility, you could phase this in by adding new functions with the proper behavior and adding a deprecation notice to the docs of the existing functions.  Might I recommend Read for the function name, since then callers will use gopass.Read instead of gopass.GetPasswd (as per Effective Go)?

Hi - this is a welcome change, but I just wanted to let you know it did obviously break the API and broke some code I had that relied on it. It was easily fixed of course, so no real problem, but you might want to consider a way to avoid this in future. I've seen some other projects using different branches for different major versions - I'm not much of an expert on this though, maybe I should be importing it differently?
Hope this doesn't sound too whiny - I just thought I'd let you know in case you weren't aware of the problem :)


Create in-depth acceptance tests

As the library is getting bigger we need acceptance tests to verify all the cases we are handling.
Playing around with permissions in UI tests is usually a bad idea but this project is probably the best to do it anyways.
Do some research to run one test at a time (probably with Spoon) and reset device permissions before the execution of each test.

Closed due to impracticality of the task, running acceptance tests with spoon, one at a time is too slow, having the Android behaviour simulated in a mock should be good enough for our needs.

Can we use a similar approach to the one shown in this screencast?  Instead of execute the command from a gradle task executing the command from the test code. Thoughts?


[React] Support quick syncing to AEM

If I want to test my app in AEM, currently I have to run Maven at the top folder which completes in about 2 minutes.
As a Frontend developer, I want to be able to quickly synchronize the app into AEM without having to go through Maven. The workflow is going to be as simple as:

"npm run sync" - This will run a listener which will watch the aem folder for changes
"npm run build" - In order to build the app. This takes time but still much faster than running Maven.

Pull request coming shortly.

@ittaibaratz while not exactly the same, there is the option of proxying the JSON from AEM and using the webpack dev server...

@ittaibaratz while not exactly the same, there is the option of proxying the JSON from AEM and using the webpack dev server...

That's what I am doing, however I keep running into areas where the app renders differently inside the aem author and that ends up consuming a lot of my time. I already put a PR to show how this can be done very easily.

understood @ittaibaratz. Curious to know what areas of the app renders differently inside AEM author as that hurts the value prop of the feature and would be good for customers to watch out for.

Closing this issue, as it's already fixed and the PR merged


Can't make an axe with the sticks and stones.

I do as the manual says and place a stick on the ground then click on it with a rock, nothing happens. Next I try two sticks still, nothing then a whole stack of sticks still nothing. Am I doing something wrong? if so please tell me.

Same problem here. This is the base of my whole modpack, so new players can't even start anymore
1.11.2
<IP_ADDRESS>63
immcraft-1.1x-1.3.6.jar
compatlayer-1.11.2-0.3.1.jar

Have both of you enabled this option?
B:allowMakingStoneAxe=false

It is false by default

Is this option "new" ?
I designed my pack 10 months ago and in the early days it was definitly working. Did not expect such a config option to appear.
Well, good to know. So I can simply activate it.


Need target shim/stub container for firecracker

Eventually, we want to directly spawn firecracker via the minijail process trait. However, I don't know to get all the mounts set up for that, so I would propose that as an intermediate step, north would launch a shim (or stub) container that would reference the target container as a resource. In addition, the FC resource container would be available in this shim.
The shim would be a 'normal' container , with the target container specified as a resource, along with the FC resource container.
The reason for doing it this way is to get something up; yes this is probably throw-away code, but it will provide experience with launching Northcracker VMs.

Not needed.


Revert "re-factory Tensile to support all Matrix Instruction"

Reverting PR #972. requires code refactor ..

Can this be merged or closed?

Closed for now.  Can re-open as needed.  Thanks.


Datepicker size broken when displaying months, years or decades.

Will be there in the next version.


Make Scanner and/or MigrationResolver extensible

I am using Flyway v4.0.3 and would like to be able to resolve migration files using the ServletContext instead of the Classpath and/or the Filesystem. However, it is not possible to, or at least not obvious how to, customize the Scanner since it is directly instantiated within Flyway method calls.

Use Flyway.setResolvers(...)to pass in your own resolver.


Upgrade test credentials to use RSA 2048-bit keys

Current keys are 1024-bit RSA keys and caused test flakey.
The test credentials are located at src/core/tsi/test_creds/

@jtattermusch @yihuazhang @ZhenLian

https://source.cloud.google.com/results/invocations/94f921a9-f2c7-40a5-9a93-10cdd2958b00/targets/github%2Fgrpc%2Frun_tests%2Fc_linux_dbg_native_x64_gcc8.3/tests

the problem might only be in support code: test_server.py
https://github.com/grpc/grpc/blob/61a0212539214d2b40d1c2deea0a7c2eb9313b85/test/core/http/test_server.py#L61

I will change all test credentials to 2048 in any way. Stay tuned

@jiangtaoli2016 Thank you for your effort and can you close this if all necessary changes got merged already?

I suspect this was done.


Removing the android:name=${applicationName} line works for me.

Removing the android:name=${applicationName} line works for me.
Originally posted by @FaKenKoala in https://github.com/flutter/flutter/issues/98316#issuecomment-1038763462

@ArtyPrince-01
I am not sure what exactly the issue are you reporting here. Please don't use issue comments to open new issue.
When opening an issue, please try to provide all or some of the information indicated in the template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


'White Magic' filter.

Add an option where 'b/w' and 'white paper adjustments' options combines. So it becomes easier for new users to experience the app better.
Or
Add an adjuster tool for photo to be seen clearly.

@NripPrajapat Not sure i understand what you want. You want a black and white version of the whitepaper filter?

I mean to say, there is a filter named 'Bw' in filter options.
And there is an improvement option in 'magic bar', named 'whitepaper' - improvement for white paper type documents.
I just a direct option to apply both in just one click.

@NripPrajapat it is not planned as may users could want many variations of this. What you can do however is from camera settings set default filter to bw and whitepaper mode on. That way on any camera picture those will be applied automatically