Merge parent component options with field-layout opts

This is related to options in custom layout components (https://github.com/agentejo/LayoutComponents/pull/4)
and is another take on https://github.com/agentejo/cockpit/pull/1091 but without adding the options to the item (instance) data.
What this does is to merge the options in the parent component into the field-layout that is rendered to contain children. This allows to create addons to use the 'field.layout.components' event together with options created on a custom layout component.
The https://github.com/pauloamgomes/Cockpit-CustomComponents addon already uses this event and works as expected on the root field-layout but does not work on components with children since they do not receive opts from from either the layout definition or from component options.

Thank you for the contribution and sorry for the late answer! I'll test it as soon as possible.

Thanks!


limit exceeded - memory usage for large excel files

Hello,
I'm trying to upload a 60MB xlsx file with something like 610 000 rows but i have this error
java.lang.OutOfMemoryError: GC overhead limit exceeded
I saw that there is already a ticket on similar issues so i tried this
java -jar -Xmx4G  excelastic-1.2.7.jar as suggered but still the same issue.
And before i get this error in my terminal i can see this warning
PM io.vertx.core.impl.BlockedThreadChecker WARNING: Thread Thread[vert.x-eventloop-thread-0,5,main] has been blocked for 3086 ms, time limit is 2000
Do you know how i can fix this issues please ?
Thanks in advance

Hello,
either split the excel file into smaller parts or assign even more memory. I can't say how much you will need. the issue is caused by the way apache POI works. It attempts to load the entire excel workbook into memory at once. While the file is only 60MB the memory requirements in-memory is increased by a large factor.
Would converting the excel file into CSV work for you? We are currently adding support for importing CSV files, which would support streaming from disk - this would eliminate memory issues altogether.
Otherwise we would need to consider alternatives to POI in the future.
Here is some information on "GC overhead limit exceeded" error.
https://www.baeldung.com/java-gc-overhead-limit-exceeded
best regards,

Maybe we could change the excel parser to use this instead:
https://svn.apache.org/repos/asf/poi/trunk/src/examples/src/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java
This would convert one row at a time from the excel sheet into CSV.
Maybe this can be used instead of the Workbooks in POI. Needs to support both HSSF and XSSF.
See https://poi.apache.org/components/spreadsheet/limitations.html

Not changing the excel parser anytime soon, to import very large files use csv instead - as it uses memory mapping it supports file sizes beyond RAM limits. If files cannot be converted, please investigate if investing in more RAM would solve the issue.
Alternatively submit a PR with a more efficient excel parser.
Closing this for now.


Armchair alert doesn't show up

Hi,
I set Armchair this way:
            Armchair.appID("1044050208")
            Armchair.significantEventsUntilPrompt(0)
            Armchair.daysUntilPrompt(0)
            Armchair.usesUntilPrompt(3)

And expected Armchair will show up on the third sessions, but nothing happened.

Did you step through the code to see why?

@coneybeare which object should I debug?

I would place your breakpoint either in showPrompt or ratingConditionsHaveBeenMet

same here, seems both of your mentioned functions are never called....

incrementUseCount is never called directly by the user, but is called before a call to showPrompt in incrementAndRate. Can you reproduce what you are seeing in the example project with a basic setup?

Actually, I see why this might be happening. Sorry it took me some time to reacquaint myself with the code.
The application lifecycle notification callback methods only call incrementUseCount and not incrementAndRate. This is fine and by design so that the user is not bombarded with a review prompt immediately after opening the app, where chances of a review are lower. The library was really designed to keep significant events as the primary trigger for a review, when the user satisfaction is highest. A user is more likely to review if you do so at a point where it does not interrupt their flow. They came to your app for a reason, and now once they are in, you are asking them to stop doing that reason while they help you out by writing a review. Let them finish that reason (beat a level, do a thing, open stuff, check this or that) then ask them upon completion of said significant event.
But, if you want to keep significant events at 0, you should manually add showPromptIfNecessary wherever it makes sense in your app. But I would recommend using significant events to trigger instead as you will get better clickthrough rates to the App Store.
This presents a problem for me because the default for this value is 0 (has to be) so I may add a condition to the lifecycle callbacks that checks whether or not this value is 0 and perhaps call for a prompt. I have to think about it because it could cause unintended prompts for others. My gut tells me no and that the solution is for you to add the showPromptIfNecessary call to your setup. Either way I decide, you have a solution now.

yes thats the point. if you only want to have the use count (as odedharth describes) there is no call of showPromt. Your class is incrementing the useCount value but then never tries to fire the showPromt.
Other cases have this call: if someone calls userDidSignificantEvent, the function itself calls incrementSiginificantEventAndRate, which calls showPromt.
so do we have to call showPrompt(ifNecessary.... explicid?
best
stefan

Yes, that is the solution (for now) as I detailed in length above. If you are using significant events at 0 (highly unadvised) then you will have to call showPromptIfNecessary() from wherever it makes sense in your app. Fixing the lifecycle callbacks so that it automatically shows on app open or launch would introduce unwanted behavior for just about everybody who is using significant events > 0.


Sample wanted for cbeust/klaxon

About the library

Description:  A JSON parser for Kotlin
GitHub: https://github.com/cbeust/klaxon

What the sample could do
See sample Moshi and KotlinxSerialization
Wants to contribute the sample?

Say so in a comment here
Follow instructions in CONTRIBUTING.md
Submit your pull request!

@jmfayard please assign this issue to me

@oppongjr done Isaac :)
Sorry for the other issue

@jmfayard No problem! I just have to be faster with this one lol.


docs: Automated Changelog Update for v5.0.0-beta5.63

copilot:all
Automated changes by create-pull-request GitHub action

🤖 Generated by lychee action
Summary

Status
Count

🔍 Total
2165

✅ Successful
489

⏳ Timeouts
0

🔀 Redirected
0

👻 Excluded
1669

❓ Unknown
0

🚫 Errors
5

Errors per input
Errors in docs/4.0/i18n/zh-Hans/self-hosting/lifecycle-management/operations/run-cluster/template-apply-cluster.md

[ERR] https://helm.sh/ | Cached: Error (cached)

Errors in docs/4.0/docs/self-hosting/lifecycle-management/operations/run-cluster/template-apply-cluster.md

[ERR] https://helm.sh/ | Failed: Network error: Connection reset by peer (os error 104)

Errors in docs/5.0/i18n/zh-Hans/developer-guide/lifecycle-management/operations/run-cluster/template-apply-cluster.md

[ERR] https://helm.sh/ | Cached: Error (cached)

Errors in docs/5.0/docs/developer-guide/lifecycle-management/operations/run-cluster/template-apply-cluster.md

[ERR] https://helm.sh/ | Cached: Error (cached)

Errors in helm/sealos/charts/common/README.md

[ERR] https://helm.sh/ | Cached: Error (cached)

Full action output
Full Github Actions output


added opcua source and server timestamp

This PR adds SourceTimestamp and ServerTimestamp to the metadata of the Benthos message. Having these timestamps is very useful in situations where the data passes through multiple PLC's before reaching Benthos.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Nice and Thank you! Can you sign the CLA so we can accept your PR?

Nice and Thank you! Can you sign the CLA so we can accept your PR?

Sorry for the delay, I just need to work this out with my employer. I will let you know when it has been resolved.

@JeremyTheocharis The CLA was approved and I have now signed it


Errors encountered while loading schema files are silently ignored

Is your feature request related to a problem? Please describe.
Sorry if this duplicates another issue - I couldn't find something which matched this particular problem that was still open.
My team is using graphql-codegen to generate types from our node service. As part of generating types we are transpiling our typescript code using ts-node/register.
If there is any compilation issue / or an issue actually running the code the code generation command fails without actually showing the error. Instead it shows the following:
$ graphql-codegen
  ✔ Parse configuration
  ❯ Generate outputs
    ❯ Generate ./src/types.d.ts
      ✖ Load GraphQL schemas
        → All found files for glob expression "./src/schema.ts" are not valid or empty, please check it and try again!
        Load GraphQL documents
        Generate

 Found 1 error

  ✖ ./src/types.d.ts
    Error: All found files for glob expression "./src/schema.ts" are not valid or empty, please check it and try again!

Something went wrong

Describe the solution you'd like
If an error is encountered when trying to load the schema it'd be great if it was displayed.
Describe alternatives you've considered
We have considered running tsc with no emit turned on as part of our command to actually run the codegen command. This is much slower as it means we are effectively compiling everything twice.
Additional context
Our config is:
overwrite: true
schema: ./src/schema.ts
require:
  - ts-node/register/transpile-only
generates:
  ./src/types.d.ts:
    plugins:
      - add: '/* tslint:disable */'
      - typescript
      - typescript-resolvers
...

Hi @Myrannas !
We are using graphql-toolkit to load schemas and operations easily. It currently supports code files as schema and loads it using require (and not as ast). It means that your schema.ts file must export default or export an object with schema field (GraphQLSchema object).
Can you please share your schema.ts file?  it will make it easier to resolve this issue.

I can't share our GraphQL schema - but I will try and create an example in a separate repository.

Thank you @Myrannas ! Waiting for it.

I have this same issue with the same config file.  It appears that going through multiple import/export files causes the problem, but I am not 100% sure on that yet.  My schemas are split into directories roughly related to the models. For example: there is a User directory with a schema.ts file in there.  Each directory has an index.ts file that just consolidates and re-exports everything that is needed in the directory.
Then my root schema.ts imports all those pieces and stitches them together, via imports from those index files.
If I instead bypass the index files and directly import each schema file, the code generation works.  But, my root schema.ts is a little messier.

Yep, I think you are correct @bopfer.
I have created a minimal example of this issue in https://github.com/Myrannas/graphql-codegen-error.
Instructions to reproduce are in the readme, but in short, any errors in imported files are hidden. Errors in the root file are correctly reported.
This is particularly problematic when using libraries like the graphql-modules library - as you are generally importing a lot of code even if it isn't being used.

I managed to reproduce the issue in graphql-toolkit. Working on a fix now.
Thanks @Myrannas @bopfer !

Fixed in: https://github.com/ardatan/graphql-toolkit/pull/102
Now the complete JS/TS error is being displayed (as-is, without changing it):

Fixed it: https://github.com/dotansimha/graphql-code-generator/pull/1880

Awesome! Thanks for looking at that @dotansimha - the fix looks great.

Fixed in 1.2.0.


crash on OrangePi zero

I try to start on Orange Pi zero but it crash at pin configuration.
OS : Armbian_20.02.1_Orangepizero_buster_current_5.4.20
pip install pi-mqtt-gpio  -> OK
apt-get install python-dev  -> OK
pip install OrangePi.GPIO  -> OK
pip install OPi.GPIO -> OK
Content of pi-mqtt-gpio.yml :
mqtt:
host: <IP_ADDRESS>
port: 1883
user: ""
password: ""
topic_prefix: pimqttopz1/kitchen
gpio_modules:

name: orangepi
module: orangepi
board: zero
mode: board

digital_outputs:

name: lights
module: orangepi
pin: 7
on_payload: "ON"
off_payload: "OFF"
initial: low
retain: yes

python -m pi_mqtt_gpio.server pi-mqtt-gpio.yml
2020-05-13 22:00:20,382 mqtt_gpio (INFO): Startup
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/lib/python2.7/dist-packages/pi_mqtt_gpio/server.py", line 887, in
main(args)
File "/usr/local/lib/python2.7/dist-packages/pi_mqtt_gpio/server.py", line 759, in main
GPIO_MODULES[gpio_config["name"]] = configure_gpio_module(gpio_config)
File "/usr/local/lib/python2.7/dist-packages/pi_mqtt_gpio/server.py", line 427, in configure_gpio_module
gpio_module = import_module("pi_mqtt_gpio.modules.%s" % gpio_config["module"])
File "/usr/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/usr/local/lib/python2.7/dist-packages/pi_mqtt_gpio/modules/orangepi.py", line 66
raise IOError("channel %d setup failed" % pin) from e
^

Ok find the problem.
First remove package OPi.GPIO because is in interaction with OrangePi.GPIO.
Second : in pi_mqtt_gpio/modules/orangepi.py
replace line 66 :
raise IOError("channel %d setup failed" % pin) from e
by line :
raise IOError("channel %d setup failed" % pin)
And it is working.

Hmm, that raise from should be valid code. Could you let me know what version of python you're running please?

Python 2.7.16

Error was :
File "/home/llevet/ve/lib/python2.7/site-packages/pi_mqtt_gpio/modules/orangepi.py", line 66
raise IOError("channel %d setup failed" % pin) from e
^
SyntaxError: invalid syntax

the ^ is on "from"

Ah yes, it's python 3 syntax. Best to remove that for now then while we're still supporting it. I recommend changing to python 3 though if you can. 2.x is no longer supported in general now.

Yes i agree with you for all.
Good choice to remove it at this time because the default Raspbian Buster for Pi and for OrangePi at this yime is deliver by default with python 2.7.16
Maybe a note in Readme file to inform that is beter to use python 3 and adapte all syntax with it.
ex: pip install pi-mqtt-gpio -> pip3 install pi-mqtt-gpio ...


Consolidated run button context menu renders behind cell output

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.57.0-insider 1e446dfadf588ec28b3fdba7ac083bfa1d45df3c
OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

Execute a cell to produce some cell output
Click on consolidated run button chevron
🐛 Run action context menu renders behind cell output:

We need the help of God of z-index.

I don't see this...

Definitely still seeing this on Windows and Insiders a62df5d6c53e844bfdc50694f943c3f34b6ff50e. Interestingly I can't repro this on macOS. @roblourens what's your setup?

Output renderer is the built-in one:


[SF] Get rid of custom exception types

Service Fabric integration heavily relies on custom exception type which can be an anti-pattern. We need to review it and get rid of them where it's appropriate.

Pre-triage: A consistent exception handling is a nice to have feature, but it's not crucial. Moving to backlog.

This affects public API so I want to bring it up in triage. Clearing the milestone.
ConfigException and ServiceFabricIntegrationException are unneeded public surface area that should be removed before 1.0.

Triage: Has to happen, before we ship Service Fabric package. Which is likely going to be post 1.0.


enable prefer-const in tslint as well

while reviewing i noticed that we have this enabled for eslint, but not for
tslint. i personally like that rule a lot because it reduces the mental overhead
necessary for me to understand code.
don't know if a public poll is necessary as somewhen it was already decided to use that for .js-files.

:tada: This PR is included in version 2.141.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement application whitelists

With messaging allowed between windows, implement a method to whitelist specific drives as applications. This allows endpoints to deny apps not on the whitelist to get any information from the endpoint.

Application whitelists have been set up and the endpoint can save/load its configuration to local storage. However UI in the configuration is not implemented yet, and the whitelisted applications have been hard-coded into the program.


Update DRAGMAP image to use 1.3.0

Until 1.3.0 bioconda build is broken https://github.com/bioconda/bioconda-recipes/pull/34744, working around conda DRAGMAP. Combining WARP image https://github.com/broadinstitute/warp/blob/master/dockers/broad/dragmap/Dockerfile and our micromamba image to get DRAGMAP installed from source, and all other tools from bioconda.

images/dragmap:1.3.0 is build.
Thanks Leo and Vivian!


release 1.4 of cmake tools

i need a bug fix that andreas wrote it will be in 1.4 release.
"CMake-Tools does not (re)configure on CMakeLists.txt change/save #634"
when this release will be available.
Thanks
and have a nice day

The plan is to release this week after cpptools releases.
Take care!


Fix local cache identifier

What changes are proposed in this pull request?
Fix local cache identifier
Why are the changes needed?
If not including modification time, it may have consistency issues.
Does this PR introduce any user facing changes?
NO

cc @beinan

https://github.com/prestodb/presto/pull/19746

Would you like to update the tiltle of this PR to make it easy to show the purpose of this change.

Updated. Thanks for the advice.

@huanghua78 Would you like to take a look at this PR, I think this is a most cheap way to implement the consistent between LocalCacheFileSystem and under fileSystem.

alluxio-bot, merge this please

alluxio-bot, merge this please


Decide on whether we're deprecating did:ion

[!WARNING]
hold off on implementing any additional functionality related to did:ion until a decision is made

[!NOTE]
Hoping to land a decision here by EOD 11/14/2023 US

both web5-kt and web5-js have did:ion implementations.  We need to decide whether we want to deprecate did:ion and when.
I imagine we'll likely want to wait until we have did:dht implemented in at least both sdks. If we intend to continue maintaining did:key we need to produce test vectors.

cc: @csuwildcat

cc: @emilycc @michaelneale

The did:dht method is so much simpler for SDKs, client apps, and node implementers/operators that I think this is the right call.

To future proof us, I would suggest we at least use did:key (did:jwk might work, but I need to check) with Ed25519 keys, because we can basically upgrade did:key DIDs to have the capabilities of DID DHT and resolvable endpoints, while gracefully degrading back to being ordinary did:key IDs

The DIF interop profile specifies did:web did:jwk and did:ion right now. https://identity.foundation/jwt-vc-presentation-profile/ so that choice would need some work as well. (of course we can create another profile :))

Should be able to make did:jwk work, we would just need to use Ed25519 keys. The Mainline DHT that backs BitTorrent uses Ed25519 keys for its k/v pairs, so any method that represents an Ed25519 key is theoretically in play for us to be able to gracefully upgrade from a neutered DID method to a fully fledged one.

One thing worth noting is that neither AWS nor GCP KMS support Ed25519 yet, which is relevant since we know at least some interested partners plan to use AWS KMS for secure key management.
Here are a couple of relevant issue trackers for GCP:
https://issuetracker.google.com/issues/232422224
https://issuetracker.google.com/issues/231334600
Worth noting this comment from a Google representative:

Our Cloud KMS and Cloud HSM services run strictly in FIPS mode and since the EDDSA set of curves are not currently NIST approved, we are unable to support ED25519 or ED448 at the moment.  However, we'll keep your request in our system and will let you know if any changes in the future.

With the addition of Ed25519 in FIPS 186-5, published Feb. 3, 2023, this might prompt HSM manufacturers and the upstream hosted KMS providers like AWS and GCP to add support.

@frankhinek but if we have PFIs and companies using did:web, they can use whatever keys they want. This is more for individuals, who don't need KMS support.

the method is implemented in go, ts, and kotlin (after this PR).
we have a server that's deployed at diddht.tbddev.org. the server needs ongoing development, but is usable for non prod use cases today.
To @mahoekst's point -- I wouldn't take the interop profile too seriously yet. The profile is a bit stale. It's more important that we have our own profile (and our own sense of certainty) about what we're supporting.
To @frankhinek's point -- It is frustrating there's no KMS support for Ed25519. Practically, when HSMs/KMSs are required, we should recommend did:web or did:jwk as a last resort.
I am thinking
jwk - mostly used for testing or ephemeral use cases
dht - used for individual DIDs and organizations without HSM/KMS requirements
web - organizations

what are the reasons to keep did:ion? (the theoretical discovery aspect with types right now is one) - I assume is some good ones.

We can do discovery just as well with DID DHT, so as that comes online as
our flagship, there's little reason to keep ION around.
On Thu, Nov 9, 2023, 7:53 PM Michael Neale @.***> wrote:

what are the reasons to keep did:ion? (the theoretical discovery aspect
with types right now is one) - I assume is some good ones.
—
Reply to this email directly, view it on GitHub
https://github.com/TBD54566975/sdk-development/issues/14#issuecomment-1804953748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABAFSX3R4DD3FZRYNC4XV3YDWCITAVCNFSM6AAAAAA7EAXSGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUHE2TGNZUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

ION is deprecated.


Physics2D / default_gravity displaying value when unchecked

When left unchecked, the value of 98.000000 is displayed in the debug console (the one that lives in its own window in OS Windows).
This is the setting found in Project Settings -> Physics2D -> default_gravity

Can confirm, both on Windows and web export.
It's unrelated to being checked or unchecked, if I set it to a non-default value it's still displayed.

Only happens with 2D kinematic bodies (both kinematic body and rigid body in kinematic mode), which will print the value once; and rigid bodies in rigid or character mode, which will print the value repeatedly.

I think this is fixed
If anyone still experiences this on builds after 8fb7014, please comment


Adding support for realm

Is there any plan to add support for realm database in expo so that we can use it with create-react-native-app without ejecting? If not, I would request you to add this feature.
https://realm.io/news/introducing-realm-react-native/

Hi! We're definitely considering adding Realm support at some point. In the meantime, there should be a release soon with support for SQLite.

Hi,
How is process of adding support for Realm to Expo?

is there any progress on this feature?


How to move a map between different Classeurs?

Hi all,
I might have missed this one but how can I move a map (collection of files) from one Classeur to another?
Thankfully,
~Robert

Hi Robert,
In the coming release, orphan files (not in any folder) will always be in the default Classeur. For folder files, you will have to move the folder from one Classeur to another, or drag and drop files into the new Classeur folder.
I hope that makes sense.

Dear @benweet,
Let me try it out then!
Thanks,
~Robert


fix out of range issue

Merely commenting out those lines is not going to cut it... I’ll consider something that interacts with np.errstate so that the end user has control over it.

Sure I encourage you to find a better solution, but I need this to work on datasets I am working on now, so made my own version of katpoint.

You are encouraged to make your own custom branches (that’s the beauty of git) but it doesn’t need a pull request (or even pushing) to work. Closing in anticipation of a better solution.

I made the pull request to prod you into making the fix, rather than as a way to make my own version. Should I make a Jira ticket for this then instead, or will you take this forward on your own?
Of course you must be aware that even though some target_x,y values are erroneous (due to out of range), the valid ones are not being computed either.

Make a ticket 😀
Yes, I’m aware - that’s the nature of exceptions. I’m also not aware of
other datasets besides yours that hit this snag regularly. 😁
L
On Thu, 22 Nov 2018 at 11:58, Mattieu de Villiers<EMAIL_ADDRESS>wrote:

I made the pull request to prod you into making the fix, rather than as a
way to make my own version. Should I make a Jira ticket for this then
instead, or will you take this forward on your own?
Of course you must be aware that even though some target_x,y values are
erroneous (due to out of range), the valid ones are not being computed
either.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ska-sa/katpoint/pull/45#issuecomment-440975924, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAX70ELYRN02PPp815YFeKpjyy5VYDGdks5uxnVAgaJpZM4YutGm
.


Make the colon optional; exclude .svn folder

The .svn folder scanning results in duplicate todos. Making the colon optional results in better matching against code not specifically written against this project ('#TODO save password securely' or whatever)

I'm going to keep the default for the pattern the way it is. Removing the colon will result in anything containing todo in your code being matched. For example, if I removed the colon and ran it across this project, there would be a lot of false matches.
Additionally, I tired to keep the default exclusions extremely lean as each additional glob results in ~1 second in a project with 1k files. I would prefer to not add SVN as it pretty uncommon versus git.
You can, of course, change the setting yourself in your local config to fit your needs, I just don't think these two settings are much use when it comes to defaults.


MRG: Clean-up and add comparison/all implementations for feature extraction

Hey! @jacobf18 @adam2392 @anandsaini024
Seeing all the good progress made, I wanted to finalize the first big step of this project: a completely tested and similar port of the network and features in Python. In this PR:

I replaced ALL the test files with small tests files that were generated from the EEGLAB sample dataset. I also added the MATLAB scripts to generate those files and replicate all the results.
Since we now know that the network has been perfectly ported, I focus on the feature extractions. I intend to go over all 3 and their implementations, in the coming couple of days (finally got some free time to work on this!).
And a bit of clean-up / re-structuring

Progress:

[x] Topo
[x] PSD
[x] Autocorr

For each, I replicated as close as possible the MATLAB outputs and added the corresponding tests to compare the data arrays. Contrary to your code @jacobf18 that I used, I did not change the shapes and instead matched the shapes from MATLAB to simplify testing and comparison.
And finally, the ICLabel feature extraction function differs depending on:

raw or epoch
If raw, how long? (3 behaviors for [0, 1] seconds for [1, 5] seconds and for above 5 seconds)

So I added test files for each scenario:

-epo for epochs
-raw for raws (above 5 secs)
-short-raw for raws (1 to 5 secs)
-very-short-raw for raws (0 to 1 sec)

Side note:

it is possible to match the random number generator between numpy and MATLAB in most cases. So we should be able to get good tests also for the PSD feature.
trials represents epochs: 1 -> Raw; above 1 -> Epochs

Autocorr is done, it now matches at 100%.

Test files have been re-created on the Windows on which I work for now, sha1 checksum has been removed. I will recreate them on my macOS later.

I still have to look into the topoplot, probably tomorrow. I just checked the coordinates/montage (works as intended) and a quick test case with @jacobf18 function ica_features.py:topoplot that did not match.

Topo does match :)
I'll clean up tomorrow, fix feature formatting and add test for the entire pipeline.

All the individual steps and feature extraction works well and reproduce exactly the output from MATLAB.
But now, we enter into the 'weird' territory. The feature extraction starts by re-referencing to a common average, for both the data and ICA matrix.
ICA_feature_extractor.m:L14:17
% assuming chanlocs are correct
if ~strcmp(EEG.ref, 'averef')
    [~, EEG] = evalc('pop_reref(EEG, [], ''exclude'', setdiff(1:EEG.nbchan, EEG.icachansind));');
end

This step is problematic. If I save a dataset after re-referencing and reload it in EEGLAB.. the icawinv re-loaded is not the same! It looks like a bug in EEGLAB, ref. issue: https://github.com/sccn/eeglab/issues/462
I have to think a bit about this re-referencing and its impact. If you have any suggestion, please comment :)

Codecov Report

Merging #18 (f4573d8) into main (6bad7f1) will decrease coverage by 7.75%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   97.05%   89.30%   -7.76%
==========================================
  Files           5        4       -1
  Lines         306      374      +68
==========================================
+ Hits          297      334      +37
- Misses          9       40      +31

Impacted Files
Coverage Δ

mne_icalabel/__init__.py
100.00% <ø> (ø)

mne_icalabel/network.py
86.95% <0.00%> (ø)

mne_icalabel/features.py
89.00% <89.00%> (ø)

mne_icalabel/utils.py
92.22% <96.87%> (+3.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bad7f1...f4573d8. Read the comment docs.

Whoot! Nice @mscheltienne if it matches, that's exciting news. This is a large diff, so I'll take some time soon to do an in-depth review.
@jacobf18 and @anandsaini024 should sanity check as well.

I have to think a bit about this re-referencing and its impact. If you have any suggestion, please comment :)

Hmm so my opinion is that if it's happening in EEGLab, it's a "bug" but solely on their end. We simply want to match the EEGLab's first pipeline run (before saving the data to disc). Basically, I think it's fine.
A quick question, so if we re-reference to average multiple times it shouldn't change right? Perhaps misunderstanding, but why does icawinv change then?

For the MANIFEST.in, we can fix it in a follow-up. It needs more clean-up than just this .txt, and also do we include the data for the test files or not?

I am getting an error with make black following the last commit. I am not familiar with it and the traceback is.. lacking. Any idea?

I am getting an error with make black following the last commit. I am not familiar with it and the traceback is.. lacking. Any idea?

Sorry the make recipe only "checks" for formatting errors.
You'll need to run "black ."
I think I can fix that in another PR to make the dev exp easier.

Sorry... just noticed that. I've previously set it up to just format it.

@jacobf18 and @anandsaini024 skim the changes to see if you spot any issues. Meanwhile ill merge this.


Install failed due to tsc

I did a git clone followed by npm install as a user (not root) on Ubuntu 16.04 LTS using the distro-installed version of npm and got the following:
$ npm install

> undefined install /home/kmaxwell/src/Eve
> tsc

/usr/bin/env: ‘node’: No such file or directory

npm ERR! Linux 4.4.0-45-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! undefined install: `tsc`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the undefined install script 'tsc'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/kmaxwell/src/Eve/npm-debug.log

Unfortunately it seems ubuntu still calls the node binary nodejs. I have it symlink post-install in my dotfiles and forgot about it. If you symlink nodejs to node it should just work.
This is a bit of a tough nut because other distros have only node instead of nodejs, so I'll need to add platform detection into the build scripts, which itself needs to be cross platform compatible. :(
We'll keep this issue open to track that until I figure out a reasonable fix.

Thanks, sudo ln -s /usr/bin/nodejs /usr/bin/node did the trick!

I have the same problem on Arch Linux (which only has node binary). I even tried sudo ln -s /usr/bin/node /usr/bin/nodejs, but it didn't help.
$ npm install

> undefined install /home/xaxes/Code/Eve
> tsc

src/renderer.ts(372,44): error TS1005: ':' expected.
src/renderer.ts(378,31): error TS1005: ':' expected.

npm ERR! Linux 4.8.4-1-ARCH
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v7.0.0
npm ERR! npm  v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! undefined install: `tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the undefined install script 'tsc'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/xaxes/Code/Eve/npm-debug.log

sudo npm install -g typescript fixed it for me

We now use a local install of typescript so users don't need to install it manually. Unfortunately we don't have a great solution to the ubuntu node situation short of adding a shell script to warn users. As unpleasant as it is, most node projects expect the binary to be named node, so we're not going to rock the boat at this time by trying to fix it. If a user install eve via sudo npm i -g witheve the resulting eve binary should just work, which is the best compromise I have to offer at the moment.
As ever, if anybody has a better solution to fix this during development time as well, I'd be more than happy to accept a PR.


[$500] Pay button appears for the approved report

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705978407170839
Action Performed:

submit a expense report to approver
Approve the expense report

Expected Result:
"pay" button should disappear
Actual Result:
"pay" button still appears
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01649969eb5b52cb20
Upwork Job ID:<PHONE_NUMBER>366476288
Last Price Increase: 2024-01-24

Still seeing this daily

Proposal
Please re-state the problem that we are trying to solve in this issue.
Pay option is still appears after approving the expense.
What is the root cause of that problem?
It's simply because we don't hide the pay button when the expense is approved.
https://github.com/Expensify/App/blob/0d0b0a8c9b073c30a9b54de15066789d17f7c718/src/components/MoneyReportHeader.tsx#L68-L71
What changes do you think we should make in order to solve the problem?

Hide the button when the expense is approved by adding !isApproved condition to shouldShowPayButton.
(we need to do this in ReportPreview too)
but how will the expense get paid if the pay button is hidden and it's not automatically reimbursed?

Thanks for the proposal @bernhardoj, but this GH will be internal since it will require BE changes.

Working on it

PRs up

https://github.com/Expensify/Web-Expensify/pull/40709
https://github.com/Expensify/App/pull/35347

Starting leave so re-assigning!

Updated the App PR from latest main and mark it ready for review

Is it? What do we need to do here?

Seems there's an edge case for indirect reimbursement, discussing here

Coming from this convo, we'd need to update the Pay button logic based   on the reimbursement settings:
None - No pay button at all. The final report destination is either closed or approved based on “Submit & Close” or “Submit & Approve” mode.
Direct - Pay using Expensify shown to the admin that is configured for payment in the workspace (i.e the “assigned reimburser”)
Indirect - Pay elsewhere show to all admins

@c3024 want to handle this as well please?

Yes @twisterdotcom . Thanks

Also coming from the same convo, we want to simplify this condition in favor of the group policies (we will remove the free plan soon) cc @c3024

Also we'd need to update this condition for the report preview.

@marcochavezf you're working on a PR for this, correct?

Hi @c3024, I was wondering if you've had a chance to work on this? If not, no worries at all, I'm more than happy to take care of the pending changes by creating a PR today.

My bad, I misunderstood that I'd take this as C+. 😄  I will make the PR right away.
Could you confirm these?
REIMBURSEMENT_YES: 'reimburseYes', = Direct
            REIMBURSEMENT_NO: 'reimburseNo', = None
            REIMBURSEMENT_MANUAL: 'reimburseManual', = Indirect

Also coming from the same convo, we want to simplify this condition in favor of the group policies (we will remove the free plan soon).

This means isPaidGroupPolicy is always true henceforth, right?
@marcochavezf

Thanks @c3024, yeah the meaning of the reimbursement values is correct and also yes, the isPaidGroupPolicy will be always true

I think we are going to wait for the follow up PR. @c3024 can you share your Upwork profile link for me?

Yup, it was an edge case that required more discussion and was reverted to unblock the deployment at that moment

Hmm okay, so we'll just do one payment of $500, because this is a fix for something that required reverting. The original solution didn't consider the edge cases.

Waiting for this PR to be merged.


Successfully installed but failed when cleaning up temp files?

 Remove-Item: D:\a\_temp\79760d0f-a2ca-46fa-8a22-5a02d37125a5.ps1:140
Line |
 140 |          Remove-Item (Join-Path $mingw_lib 'libpthread.dll.a')
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path
     | 'C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a' because it
     | does not exist.

Error: Process completed with exit code 1.

It looked like the action was executing just fine and had installed MingW64, until this line. It caused the whole job to fail.

Chocolatey upgraded 1/1 packages.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Remove-Item: D:\a\_temp\21ebaa0f-aa0b-4baa-9fa8-7835ea66c045.ps1:140
Line |
 140 |          Remove-Item (Join-Path $mingw_lib 'libpthread.dll.a')
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path
     | 'C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a' because it
     | does not exist.

Error: Process completed with exit code 1.

I have the same problem

have the same problem

See https://github.com/egor-tensin/setup-mingw/issues/17#issuecomment-1890253793
See also https://github.com/egor-tensin/setup-mingw/issues/17#issuecomment-1959628289


ConnectionKey issue

I want to show a chart in diaglog like the sample "ChartInDialog", but it is an error when I write [ConnectionKey(typeof(IctDataCollectRow))], it's need do some anthing for this?

Upgrade to latest Serenity if you want to use typeof in ConnectionKey, otherwise use a string conneciton key.


clean: moved Category OptionListUtils over to CategoryOptionListUtils

Explanation of Change

While working on performance fixes for the search over at this PR I touched the OptionListUtils a lot, specifically the getOptions and filterOptions functions.
It occurs to me that the getOptions function became a god-function that serves a lot of different use-cases, has a lot of responsibilities and is quite coupled with a lot of other places in the code. The whole OptionListUtils is over 2.5k lines long and hard to understand.
Right in the beginning of the getOptions function there are a few early return statements for certain cases. My plan is to refactor all those use-cases out into their own functions, as there is no use in adding a includeXYC parameter to getOptions just to do:
getOptions(...) {
  if (includeXYC) {
    return computeResultsForXYC()
  }
}

The first use case I tackled is moving the category option list into its own utility.
Fixed Issues

$ https://github.com/Expensify/App/pull/51954
PROPOSAL: https://github.com/Expensify/App/pull/51954#issuecomment-2464282215
Tests

Verify that all unit tests are passing
Verify that the category search is still working:

Open the settings of a workspace you're admin of
Click on Categories
Select a category
Search in the children of that category

Offline tests

Same as testing
QA Steps

Same as testing
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/514b5e44-58a2-4bf4-9ea0-8c8926d9cb3f

Android: mWeb Chrome

https://github.com/user-attachments/assets/514b5e44-58a2-4bf4-9ea0-8c8926d9cb3f

iOS: Native

https://github.com/user-attachments/assets/514b5e44-58a2-4bf4-9ea0-8c8926d9cb3f

iOS: mWeb Safari

https://github.com/user-attachments/assets/514b5e44-58a2-4bf4-9ea0-8c8926d9cb3f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/514b5e44-58a2-4bf4-9ea0-8c8926d9cb3f

MacOS: Desktop

https://github.com/user-attachments/assets/514b5e44-58a2-4bf4-9ea0-8c8926d9cb3f

Assigning @ahmedGaber93 from the issue

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/c48c4a03-ae72-483c-9acc-fdfdbab25d28

Android: mWeb Chrome
https://github.com/user-attachments/assets/7c39fea5-7f73-43c1-b252-1f53ea70377e

iOS: Native
https://github.com/user-attachments/assets/533a6c2c-6a58-4d91-85a0-02b93dc4fd96

iOS: mWeb Safari
https://github.com/user-attachments/assets/1a4d712b-e0b5-478a-a82d-bce5b3aa0ac8

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/bef42ca6-7e64-422d-a166-11d473a3255a
https://github.com/user-attachments/assets/41fa4744-b52d-43b6-a8cc-02491b8684f8

MacOS: Desktop
https://github.com/user-attachments/assets/026ebc68-e9ef-4902-9fe5-ad38c20a6a88

I think we need to rename file tests/unit/CategoryOptionListUtils.ts to tests/unit/CategoryOptionListUtilsTest.ts

All yours. @grgia


nixos/emacs: start emacs service with the graphical-session

If emacs starts before the graphical session is initialised, clients won't be able to open new frames in the session. Start emacs with the graphical session to avoid this issue.
Fixes https://github.com/NixOS/nixpkgs/issues/224512
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This seems to be racy. It just didn't work on my (much slower) laptop with this patch applied.

I've been running it for a while and it seems stable. If nobody objects, I'd like to merge this in the coming week.

I've been running it for a while and it seems stable. If nobody objects, I'd like to merge this in the coming week.

FWIW: I don't particularly agree with this change so I'm not going to press merge on it  but I'm also not going to block it. Feel free to merge.

I must say that I'm not a great fan of this change either. It feels to me like this is an upstream bug? I can't be bothered to fix that however, so workaround time it is.

Unsure whether this should be/needs to be backported. I can imagine the bug exists in stable too (could someone test?) but this is potentially breaking for people with weird setups.

exists in stable too

Only for emacs29 (which is default since 23.11): it suddenly started requiring the daemon to be started in the same graphical environment as the client. Unless they haven't planned that and it is a bug, the workaround might be enough


Incompatible with 4.20.0

noraj a commenté le 2018-12-26 15:27
evdi 1.5.1 is not building for 4.20.0 (manjaro) ...

mwawrzyniak a commenté le 2018-12-26 19:21
I uploaded a new release to fix building in 4.20 kernels. The error in make.log related to something removed in 4.20 (https://github.com/torvalds/linux/commit/04cfcc7ab358e331b32cabde1e853a125f3f8735#diff-43768cc89c01c730cb119634b42dfa81).
The functionality wasn't apparently stable enough to be worthwhile. Removing it should have no effect on kernels < 4.20 either.

See the patch here https://aur.archlinux.org/cgit/aur.git/commit/?h=evdi&id=432d29bbfafebcf62be0d5930c6f87c16ac6fa12

@displaylink-dkurek when exactly will the fix (that you apparently are still holding back) be released to GitHub?

Sorry for no response - we have a bit of a slip. We are aiming for beginning of the next week.

Slips happen.  Is it still looking like this week though, @displaylink-dkurek ?

So, finally its there :)
evdi repository has been updated with quite some number of changes.
We are shifting towards 'atomic modeset', which means we are dropping
support for kernels older than 4.2.
With this change we did bump-up the evdi/libevdi versions, so for compatibility
please install new DisplayLinkManager, which can be downloaded from here:
https://www.displaylink.com/downloads/ubuntu
Hope you will like it ;)


set omp num threads to 1 when running proton

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
It seems that the java container uses open mp for something (not sure what). This tries setting the number of threads to 1 for proton only.
@arnej27959 please review and merge
@aressem @toregge @lesters FYI

This should have been added in the config model instead. There we build the command to be executed and we do stuff like that already.

here you go; https://github.com/vespa-engine/vespa/pull/14372


Add tests for VM to EmitC conversions

Add tests for list ops
Add tests for list i64 ops
Add tests for comparison ops
Add tests for control flow ops

Thanks, and sorry for the delay! I'm back from vacation now.
I hope this doesn't need a rebase and new test runs before merging, we can revert if there are new failures.


How to match AxisId?

I'm having trouble matching the AxisId struct, in order to process DeviceEvents. Is there something I'm missing here, or are these tuple-structs impossible to check for equality?
error: numeric fields in struct patterns are unstable (see issue #35626)
  --> src/main.rs:68:40
   |
68 |                         glutin::AxisId{0: 0} => app.yaw(value),
   |                                        ^^^^

error[E0532]: expected tuple struct/variant, found struct `glutin::AxisId`
  --> src/main.rs:68:25
   |
68 |                         glutin::AxisId(0) => app.yaw(value),
   |                         ^^^^^^^^^^^^^^ did you mean `glutin::AxisId { /* fields */ }`?

See #211

Closing since #211 was merged--AxisId is now an alias for u32 and can be matched as such.


Don't use pyinotify (#56)

Some text editors will save files as "move-original, create-new, delete-original" instead of "modify-original". This causes Inotify to loose track of the source file and stop reloading. Use a watcher that runs a background task to monitor the source file instead.

Thanks, @corani!

Sorry, seems I've broken it by a mistake during testing. Standby...

Fix in https://github.com/aumayr/beancount-web/pull/81


Update nest.asciidoc

Minor spelling mistake fix in nest.asciidoc

Sorry for leaving this for so long @robshakespeare, releasing 2.0 got the best of I suppose :smile:
We are working on updated docs that are powered by actual code (under Tests) so this will become obsolete rather fast.
Pulling it in nonetheless though :+1:

No problem.  Sorry for the very long reply.
Using the actual code/tests to generate the docs is a superb idea.  Keep up the great work.


Question about Riverpod Provider and List

Hi!
I read the official Todo example and I see for edit a Todo text you need to update the state and consequently rebuild the whole list.
Is there a way to update only the interested Todo?

I'd suggest trying the todo example. It does only rebuild the changed todo, thanks to const


[DO NOT MERGE] - add metamask with walletConnect on ConnectEmbed

this is only for generating a temporary dev build - do not merge this

/release-pr


add logging of commands

@Emilgardis Would you be OK with closing this PR until you have time to resume work on it (if ever :)?
I like when the PR inbox is empty :D


x509:gen_rsa_key(4096) failes generating key

maybe luaossl needs more seed.

was fixed in https://github.com/wahern/luaossl/commit/f7bd2dec109730b20073ce82d976b026b6e84474


Rewrite RoundRobinPacking class to fix bugs

Current RoundRobinPacking can not calculate the ram for each instance correctly,
when the container_ram_request is specified. Also, it lacks necessary unit tests to prove its
correctness.
This pull request rewrites the RoundRobinPacking and adds unit tests to make sure
it behaves as expected.

👍


Port/ml fixes

This PR fixes #12446 and #12444 - both approved and merged to main.

Pull Request Test Coverage Report for Build 261965837

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 38.899%

Totals

Change from base Build 261636869:
0.003%

Covered Lines:
19208

Relevant Lines:
45061

💛  - Coveralls

Merging since the original PRs and bugs are aprroved.


Unity Collider and Animator in entitas

Hi,
I have a collider named AttackTrigger as a child gameobject of my actor, I wanna add it as a TriggerComponent the I can use Pysics2D to let my actor attack.
Can anyone give me some advice?
Cheers

dont let the triggerComponent have a direct reference to the unity trigger, but let it store data like a boolean to know it is triggered. Then, have a monobehaviour view that holds the collider AttackTrigger, and when it is triggered using the Mono methods (Ex. OnTriggerEnter). Then have the view create an input Entity or have it change the trigger data in your TriggerComponent and do your logic in your systems, then update your view again using EventListeners

thanks@fayte0618

@fayte0618 thanks.

@fayte0618 thank you.


⚠ Bofrost.lu has degraded performance

In 654e10b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1126 ms

Resolved: Bofrost.lu performance has improved in cfb5798 after 11 minutes.


Fixed a small bug where -p is used for the port and the password.

Fixed a small bug where -p is used for the port and the password at the global command line options.
The behaviour was that only the password was filled in the argument of the cli function.

Thanks a lot for the contribution @drivard! That indeed should be fixed. I am wondering if instead we just remove the -p option from password. I think -p is very standard for port on a cli but its not overly common to specify the password that way. What do you think?

We can remove the -p or I can try -P for port if it is case insensitive.

Tested it using the vscode debugger. -P is case sensitive, therefore if we use it for let say password assignment it would set the proper value.

The debbuging command line used was:
"configurations": [
        {
            "name": "Python: Dremio Client",
            "type": "python",
            "request": "launch",
            "cwd": "${workspaceFolder}",
            "module": "dremio_client.cli",
            "args": [
                "-h",
                "dremio.example.com",
                "-p",
                "443",
                "-u",
                "admin",
                "-P",
                "P4ssW0rd",
                "--ssl",
                "sql",
                "select * from sys.options",
            ]
        }
    ]

I have adjusted the PR with -p for the port and -P for the password.

I will cut a new release soon and add you to the CONTRIBUTORS list. Thanks @drivard


Decrease log output on non verbose mode?

Would it be possible to decrease the log output in non verbose mode? Otherwise after some time the log is pretty cluttered with output with Current volume and Is on/Is off lines.
If one like this output there is still the verbose true config option. I think there would be no need for a second verbosity variable. What do you think on this?

Will be in the next npm release #1.4.0


libvirt-like MAC address

Hello,
does the check validate the good health of the created VM on libvirt?
I gave a try yesterday on a fresh Install of Terraform.
Deployment was OK but VMs didn't start becasue of this error:

Boot failed: could not read the boot disk
No bootable device.

I suspect libvirt but I didn't find anything relevant in /var/log/libvirt.
Tomorrow, I'll maybe have the time to test it on a fresh KVM install.

Hello,
does the check validate the good health of the created VM on libvirt?
I gave a try yesterday on a fresh Install of Terraform.
Deployment was OK but VMs didn't start becasue of this error:

Boot failed: could not read the boot disk
No bootable device.

I suspect libvirt but I didn't find anything relevant in /var/log/libvirt.
Tomorrow, I'll maybe have the time to test it on a fresh KVM install.

We know there has been a regression since 0.5.1 that leads to that error. Not related to this PR though...

This PR is not ok. See issue #795 .


Update Issue Templates to Auto-Apply Type Labels (Bug, Improvement, NewFeature, Test, Docs)

This PR updates the issue templates with the following labels:
Type/Bug
Type/Improvement
Type/NewFeature
Type/Test
Type/Docs
Each issue template has been updated in the .md files to ensure that the appropriate label is automatically applied when issues are created.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


InvalidArgumentError: Cannot assign a device for operation embedding_1

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

I have written custom code (as opposed to using a stock example script provided in TensorFlow):
OS version: Fedora <IP_ADDRESS> (also tested Ubuntu 18.10)
TensorFlow installed from (source or binary): tensorflow/tensorflow:latest-gpu-py3-jupyter
TensorFlow version (use command below): 1.14.0
Python version: 3.6.8
CUDA/cuDNN version: 10.0.130
GPU model and memory: GeForce RTX 2080 ti, 11 Gb

Describe the current behavior
I'm using keras. I try to to fit model that contains Embedding layer. When I call model.fit_generator(...) I get an error:
InvalidArgumentError: Cannot assign a device for operation embedding/embeddings/Initializer/random_uniform/sub: Could not satisfy explicit device specification '' because the node {{colocation_node embedding/embeddings/Initializer/random_uniform/sub}} was colocated with a group of nodes that required incompatible device '/job:localhost/replica:0/task:0/device:GPU:0'. All available devices [/job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_GPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0, /job:localhost/replica:0/task:0/device:GPU:0].

After getting this error I cannot fit new (simplified) model, because I get this error again. I get this error even I run tensorflow.keras.backend.get_value(model.optimizer.lr)
Describe the expected behavior
Model fits without any problems, like the same model without Embedding layer (no dest_input).
Code to reproduce the issue
lstm_input = Input(shape=(30, 5,))
steady_input = Input(shape=(3,),
                    name='steady_float') #тут None в shape не нужен?
dest_input = Input(shape=(1,), name='steady_dest')
ns_input = Input(shape=(1,))

x1 = layers.Bidirectional(layers.LSTM(512, activation='relu', return_sequences=True))(lstm_input)
x1 = layers.Bidirectional(layers.LSTM(256, activation='relu'))(x1)
x1 = Model(inputs=lstm_input, outputs=x1)

x2 = layers.Dense(512, activation="relu")(steady_input)
x2 = Model(inputs=steady_input, outputs=x2)

x3 = layers.Embedding(12, 3)(dest_input)
x3 = layers.Flatten()(x3)
x3 = layers.Dense(512, activation="relu")(x3)
x3 = Model(inputs=dest_input, outputs=x3)

x = layers.concatenate([x1.output, x2.output, x3.output])
x = layers.Dense(128, activation='relu')(x)

y1_output_tensor = layers.Dense(5, name='y1')(x)
y2_output_tensor = layers.Dense(5, name='y2')(x)
model = Model(inputs=[x1.input, x2.input, x3.input],
                         outputs=[y1_output_tensor, y2_output_tensor])

ep_n = 200
learning_rate = 0.001
decay_rate = learning_rate / ep_n
momentum = 0.7
model.compile(optimizer=RMSprop(lr=learning_rate, momentum=momentum, decay=decay_rate), loss=['mae', 'mae'])

#train_gen and test_get - simple generatora with shuffle
batch_size = 128
history = model.fit_generator(train_gen,
                              steps_per_epoch=1000,
                              epochs=ep_n,
                              validation_data=test_gen,
                              validation_steps=X_test.shape[0]//batch_size)

Other info / logs
Some times I get this error on simplified model:
# define two sets of inputs
inputA = Input(shape=(1,))
inputB = Input(shape=(128,))

# the first branch operates on the first input
x = Embedding(1000, 3)(inputA)
x = layers.Flatten()(x)
x = layers.Dense(4096, activation="relu")(x)
x = layers.Dense(2048, activation="relu")(x)
x = layers.Dense(1024, activation="relu")(x)
x = layers.Dense(512, activation="relu")(x)
x = layers.Dense(256, activation="relu")(x)
x = Dense(128, activation="relu")(x)
x = Dense(64, activation="relu")(x)
x = Model(inputs=inputA, outputs=x)

# the second branch opreates on the second input
y = Dense(1024, activation="relu")(inputB)
y = Dense(512, activation="relu")(y)
y = Dense(256, activation="relu")(y)
y = Dense(128, activation="relu")(y)
y = Dense(64, activation="relu")(y)
y = Model(inputs=inputB, outputs=y)

# combine the output of the two branches
combined = layers.concatenate([x.output, y.output])

# apply a FC layer and then a regression prediction on the
# combined outputs
z = Dense(2, activation="relu")(combined)
z = Dense(1, activation="linear")(z)

# our model will accept the inputs of the two branches and
# then output a single value
model = Model(inputs=[x.input, y.input], outputs=z)

ep_n = 10
learning_rate = 0.001
decay_rate = learning_rate / ep_n
momentum = 0.7
model.compile(optimizer=RMSprop(lr=learning_rate, momentum=momentum, decay=decay_rate

input_array_a = np.random.randint(1000, size=(500000, 1))
input_array_b = np.random.randint(32, size=(500000, 128))
output_array = np.random.randint(9, size=(500000, 1))

def generator_shuffle(x_a, x_b, y, batch_size=1024):
    max_index = len(x_a) - 1
    while 1:
        rows = np.random.randint(0, max_index, batch_size)
        yield [x_a[rows], x_b[rows]], y[rows]

tr_gen = generator_shuffle(input_array_a,
                           input_array_b,
                           output_array)

history = model.fit_generator(tr_gen, steps_per_epoch=3, epochs=10)

Probably, the issue occuring depends on CPU usage.
I'm attaching full log.
gpu_error.txt

I tried yo use
sess = tf.Session(config=tf.ConfigProto(allow_soft_placement=True,  log_device_placement=True))
KB.set_session(sess)

and got new error:
NotFoundError                             Traceback (most recent call last)
 in
3                               epochs=ep_n,
4                               validation_data=test_gen,
----> 5                               validation_steps=X_test.shape[0]//batch_size)
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training.py in fit_generator(self, generator, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch)
1431         shuffle=shuffle,
1432         initial_epoch=initial_epoch,
-> 1433         steps_name='steps_per_epoch')
1434
1435   def evaluate_generator(self,
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training_generator.py in model_iteration(model, data, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch, mode, batch_size, steps_name, **kwargs)
262
263       is_deferred = not model._is_compiled
--> 264       batch_outs = batch_function(*batch_data)
265       if not isinstance(batch_outs, list):
266         batch_outs = [batch_outs]
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training.py in train_on_batch(self, x, y, sample_weight, class_weight, reset_metrics)
1173       self._update_sample_weight_modes(sample_weights=sample_weights)
1174       self._make_train_function()
-> 1175       outputs = self.train_function(ins)  # pylint: disable=not-callable
1176
1177     if reset_metrics:
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/backend.py in call(self, inputs)
3290
3291     fetched = self._callable_fn(*array_vals,
-> 3292                                 run_metadata=self.run_metadata)
3293     self._call_fetch_callbacks(fetched[-len(self._fetches):])
3294     output_structure = nest.pack_sequence_as(
/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py in call(self, *args, **kwargs)
1456         ret = tf_session.TF_SessionRunCallable(self._session._session,
1457                                                self._handle, args,
-> 1458                                                run_metadata_ptr)
1459         if run_metadata:
1460           proto_data = tf_session.TF_GetBuffer(run_metadata_ptr)
NotFoundError: 2 root error(s) found.
(0) Not found: Resource localhost/embedding_1/embeddings/N10tensorflow3VarE does not exist.
[[{{node embedding_1/embedding_lookup}}]]
(1) Not found: Resource localhost/embedding_1/embeddings/N10tensorflow3VarE does not exist.
[[{{node embedding_1/embedding_lookup}}]]
[[RMSprop_1/RMSprop/update_embedding_1/embeddings/ResourceSparseApplyRMSProp/_184]]
0 successful operations.
0 derived errors ignored.

Probably, the same issue: https://github.com/fizyr/keras-maskrcnn/issues/39

Finaly, I solved my problem. I remove the definition of decay and momentum for RMSProp.
Previous run (with error):
ep_n = 200
learning_rate = 0.001
decay_rate = learning_rate / ep_n
momentum = 0.7
model.compile(optimizer=RMSprop(lr=learning_rate, momentum=momentum, decay=decay_rate), loss=['mae', 'mae'])

Current run:
model.compile(optimizer=RMSprop(), loss=['mae', 'mae'])
KB.get_value(model.optimizer.lr)

So the problem is in decay, momentum.

@AlinaYablokova Looks like you found workaround. Are you happy to close the issue. Thanks!

@gadagashwini , yes, I have found workaround and I can continue my work now. But in my opinion, there are still a number of problems:

It's impossible to use Embedding layer and RMSProp with non-zero momentum together.
First workaround

sess = tf.Session(config=tf.ConfigProto(allow_soft_placement=True,  log_device_placement=True))
KB.set_session(sess)

did not work:
_"NotFoundError: 2 root error(s) found.
(0) Not found: Resource localhost/embedding_1/embeddings/N10tensorflow3VarE does not exist.
[[{{node embedding_1/embedding_lookup}}]]
(1) Not found: Resource localhost/embedding_1/embeddings/N10tensorflow3VarE does not exist.
[[{{node embedding_1/embedding_lookup}}]]
[[RMSprop_1/RMSprop/update_embedding_1/embeddings/ResourceSparseApplyRMSProp/184]]
0 successful operations.
0 derived errors ignored."

@AlinaYablokova Could you please provide the complete code to reproduce the reported issue. Thanks!

import numpy as np

import tensorflow as tf
from tensorflow.keras import backend as KB
from tensorflow.keras import layers
from tensorflow.keras import Input
from tensorflow.keras.models import Model
from tensorflow.keras.optimizers import RMSprop

inputA = Input(shape=(1,))
inputB = Input(shape=(128,3,))

x = layers.Embedding(1000, 3)(inputA)
x = layers.Flatten()(x)
x = layers.Dense(256, activation="relu")(x)
x = layers.Dense(128, activation="relu")(x)
x = layers.Dense(64, activation="relu")(x)
x = Model(inputs=inputA, outputs=x)

y = layers.Bidirectional(layers.LSTM(128, activation='relu', return_sequences=True))(inputB)
y = layers.Bidirectional(layers.LSTM(64, activation='relu'))(y)
y = Model(inputs=inputB, outputs=y)

combined = layers.concatenate([x.output, y.output])

z = layers.Dense(2, activation="relu")(combined)
z = layers.Dense(1, activation="linear")(z)

t = layers.Dense(2, activation="relu")(combined)
t = layers.Dense(1, activation="linear")(t)

model = Model(inputs=[x.input, y.input], outputs=[z, t])
model.compile(RMSprop(lr=0.001, decay=0.05, momentum=0.7), ['mse', 'mse'])
#model.compile(RMSprop(lr=0.001, decay=0.05, momentum=0.0), ['mse', 'mse']) OK

input_array_a = np.random.randint(1000, size=(500000, 1))
input_array_b = np.random.randint(32, size=(500000, 128, 3))
output_array1 = np.random.randint(9, size=(500000, 1))
output_array2 = np.random.randint(9, size=(500000, 1))

def generator_shuffle(x_a, x_b, y1, y2, batch_size=128):
    max_index = len(x_a) - 1
    while 1:
        rows = np.random.randint(0, max_index, batch_size)
        yield [x_a[rows], x_b[rows]], [y1[rows], y2[rows]]

tr_gen = generator_shuffle(input_array_a,
                           input_array_b,
                           output_array1, output_array2)

history = model.fit_generator(tr_gen, steps_per_epoch=3, epochs=10)

I am able to reproduce the issue on Colab with Tensorflow 1.14.0. Please take a look at colab gist. Thanks!

This is fixed with tf-nightly version '2.2.0-dev20200303'. Thanks!

I tried yo use
sess = tf.Session(config=tf.ConfigProto(allow_soft_placement=True,  log_device_placement=True))
KB.set_session(sess)

and got new error:
NotFoundError Traceback (most recent call last)
in
3 epochs=ep_n,
4 validation_data=test_gen,
----> 5 validation_steps=X_test.shape[0]//batch_size)
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training.py in fit_generator(self, generator, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch)
1431 shuffle=shuffle,
1432 initial_epoch=initial_epoch,
-> 1433 steps_name='steps_per_epoch')
1434
1435 def evaluate_generator(self,
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training_generator.py in model_iteration(model, data, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, validation_freq, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch, mode, batch_size, steps_name, **kwargs)
262
263 is_deferred = not model._is_compiled
--> 264 batch_outs = batch_function(*batch_data)
265 if not isinstance(batch_outs, list):
266 batch_outs = [batch_outs]
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/engine/training.py in train_on_batch(self, x, y, sample_weight, class_weight, reset_metrics)
1173 self._update_sample_weight_modes(sample_weights=sample_weights)
1174 self._make_train_function()
-> 1175 outputs = self.train_function(ins) # pylint: disable=not-callable
1176
1177 if reset_metrics:
/usr/local/lib/python3.6/dist-packages/tensorflow/python/keras/backend.py in call(self, inputs)
3290
3291 fetched = self._callable_fn(*array_vals,
-> 3292 run_metadata=self.run_metadata)
3293 self._call_fetch_callbacks(fetched[-len(self._fetches):])
3294 output_structure = nest.pack_sequence_as(
/usr/local/lib/python3.6/dist-packages/tensorflow/python/client/session.py in call(self, *args, **kwargs)
1456 ret = tf_session.TF_SessionRunCallable(self._session._session,
1457 self._handle, args,
-> 1458 run_metadata_ptr)
1459 if run_metadata:
1460 proto_data = tf_session.TF_GetBuffer(run_metadata_ptr)
NotFoundError: 2 root error(s) found.
(0) Not found: Resource localhost/embedding_1/embeddings/N10tensorflow3VarE does not exist.
[[{{node embedding_1/embedding_lookup}}]]
(1) Not found: Resource localhost/embedding_1/embeddings/N10tensorflow3VarE does not exist.
[[{{node embedding_1/embedding_lookup}}]]
[[RMSprop_1/RMSprop/update_embedding_1/embeddings/ResourceSparseApplyRMSProp/_184]]
0 successful operations.
0 derived errors ignored.

InvalidArgumentError: Cannot assign a device for operation conv2d_1/kernel/IsInitialized/VarIsInitializedOp: node conv2d_1/kernel/IsInitialized/VarIsInitializedOp (defined at /usr/local/lib/python3.6/dist-packages/tensorflow_core/python/framework/ops.py:1748)  was explicitly assigned to /job:worker/replica:0/task:0/device:TPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0 ]. Make sure the device specification refers to a valid device.
[[conv2d_1/kernel/IsInitialized/VarIsInitializedOp]]

@AlinaYablokova Could you please provide the complete code to reproduce the reported issue. Thanks!
help-me

InvalidArgumentError: Cannot assign a device for operation conv2d_1/kernel/IsInitialized/VarIsInitializedOp: node conv2d_1/kernel/IsInitialized/VarIsInitializedOp (defined at /usr/local/lib/python3.6/dist-packages/tensorflow_core/python/framework/ops.py:1748)  was explicitly assigned to /job:worker/replica:0/task:0/device:TPU:0 but available devices are [ /job:localhost/replica:0/task:0/device:CPU:0, /job:localhost/replica:0/task:0/device:XLA_CPU:0 ]. Make sure the device specification refers to a valid device.
[[conv2d_1/kernel/IsInitialized/VarIsInitializedOp]]

I was facing the same issue.
I did following changes in my code

import os
os.environ["TF_FORCE_GPU_ALLOW_GROWTH"]="true"
Changed optimizer from RMRprop tp Adagrad
Reduced the dimention from 6181 to 3750.

and the problem was resolved.

Interestingly, the error appeared when trying to use the optimizer
tensorflow.keras.optimizers.Adam(), using SGD worked fine.
On Apple M1 uninstalling and installing tensorflow-macos, tensorflow-metal and tensorflow did the trick for me.


uart: expanded common line controls command

add LINE_CTRL_{PARITY, STOPBIT, DATABITS} commands
Signed-off-by: qianfan Zhao<EMAIL_ADDRESS>

Codecov Report

Merging #8307 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8307   +/-   ##
=======================================
  Coverage   64.53%   64.53%
=======================================
  Files         420      420
  Lines       40122    40122
  Branches     6763     6763
=======================================
  Hits        25892    25892
  Misses      11110    11110
  Partials     3120     3120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e89206...7bf796a. Read the comment docs.

@erwango could you please check this pr?

closed, #10820 provide the same functions


ENH: Update xses holidays, adds 2021

References:
https://www.sgx.com/securities/trading#Trading Hours & Opening/Closing Routine
https://www.mom.gov.sg/employment-practices/public-holidays
@gerrymanoim, sorry, I've pushed this on top of PR #29. If you want to merge this but not #29 let me know and I'll endeavour to get this on a separate branch.

The calendar changes look fine to me, will merge once we finish #29 .

Incorporated to #29.


Product Version appears to not get set in SCD build while it does for FDD build

Issue Title
Product Version appears to not get set in SCD build while it does for FDD build
General
.net core 2.0, Windows 7 64 bit
dotnet build
will produce a dll with the correct project version in the Product Version attribute of the .dll file.  However when we do a SCD build as in
dotnet publish -f netcoreapp2.0 -c Release -r win-x64
The dotnet.exe that has been renamed to the project at the end of the publish command is missing the Product Version that matches the project, and other expected fields, like Title, Company, Authors, etc.

Issue moved to dotnet/cli #9637 via ZenHub


Memory leak in ebpfcore (CICD failure)

https://github.com/microsoft/ebpf-for-windows/actions/runs/3942620259/jobs/6746800024
Driver Verification List
------------------------

nt!_VF_TARGET_DRIVER 0xffffcb8438730e10: ebpfcore.sys (Loaded and Unloaded)

    Pool Allocation Statistics: ( NonPagedPool / PagedPool )

      Current Pool Allocations: ( 0x00000001 / 0x00000000 )
      Current Pool Bytes:       ( 0x00000004 / 0x00000000 )
      Peak Pool Allocations:    ( 0x0000006f / 0x00000001 )
      Peak Pool Bytes:          ( 0x0000be59 / 0x0000003e )
      Contiguous Memory Bytes:       0x00000000
      Peak Contiguous Memory Bytes:  0x00000000

    Pool Allocations:

      Address             Length      Tag   Caller Address
      ------------------  ----------  ----  ------------------
      0xffffcb843b87aff0  0x00000004  ebpf  0xfffff803569c53e1  ebpfcore!ebpf_allocate+0x21

this was found in one of the PR runs, and no repro again. I think we can close this and file a new issue if this reproduces. The current dump is not actionable, as it uses only one pool tag. Now that multiple pool tags have been added in the code, it should be easier to debug the leak in future.


Errors

Pivotal story: 97112610
This does not complete that story, but does complete every error page linked from the overview page.
More to come.

Looks great to me.


backend/cmd: integrate gin-swagger to backend server

gin-swagger is api documentation tool, setup to backend server through swag init (CLI)
Signed-off-by: abraarsyed<EMAIL_ADDRESS>[Title: describe the change in one sentence]
Add Gin-Swagger to backend Go server
[ describe the change in 1 - 3 paragraphs ]
Gin Swagger is an API documentation tool, this commit integrates this tool with the existing backend server. The docs folder has been generated using Swag CLI (swag init command), post which the docs are linked to the server.
How to use
[ describe what reviewers need to do in order to validate this PR ]

Download the following:

go get -u github.com/swaggo/swag/cmd/swag
go get -u github.com/swaggo/gin-swagger
go get -u github.com/swaggo/files

Run the server:

make run-backend

Visit following link in the browser:

http://localhost:8000/swagger/swagger.index.html
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
I have done manual testing for it, please guide me if there is any specific test to be written for this or if I have missed out anything

Few Nitpicks, Looks good otherwise. Can you add the swag init command to the make file? It will make it easy for other developers.
Example:
.PHONY: backend/tools/swagger
backend/tools/swagger:
	go get -u github.com/swaggo/swag/cmd/swag;

.PHONY: swagger
codegen: backend/tools/swagger
	swag init --output backend/api;

Done! 665d7c493aace08884c60a88199fa1a968de7a66

Few other nits, otherwise LGTM.

Few other nits, otherwise LGTM.

Thank you @yolossn, I have fixed the nitpicks mentioned. Can you help me merge this PR if the final code looks good to you?

Thank you @abraarsyed, Will merge it after getting approval from @joaquimrocha.


Support for Azure OpenAI API

Could you make the website also support Azure OpenAI API?

+1

same here, would be great to support azure openai service

Yes please add Azure OpenAI support

For any one want to use Azure OpenAI. You can create a proxy similar to this repo https://github.com/haibbo/cf-openai-azure-proxy. It's working for me until now


jackson serialization for javaslang.control.Either broken in 2.0.5

Jackson serialization for javaslang.control.Either is broken in 2.0.5. It works fine in 2.0.4. No exception is thrown, but my instance field of type Either is not present in output json.

Hi @bartosz-bilicki
Could you provide a minimal test case to show this?


have _example/main.go work as expected

Fixes: https://github.com/dolthub/go-mysql-server/issues/911

Change looks good; just one question about whether we could add a test that would have caught this case for us before a customer had to tell us.


tic80: init at 1.0.2164

Description of changes
Created TIC-80 package, as requested by #200260.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Found issues that need to be resolved, as well as further SDL build options etc. for static builds


PMM-10502 fixed FB tests

Test run from jenkins?

https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-ui-tests/detail/pmm2-ui-tests/23113/pipeline/

https://pmm.cd.percona.com/blue/organizations/jenkins/pmm2-ui-tests/detail/pmm2-ui-tests/23650/pipeline/