[full-ci] [tests-only] Added api test for edit user using graph API

Description
This PR adds an acceptance API test for user delete using graph API.
Scenarios Added:

  Scenario: the admin user can edit another user email
Scenario: the admin user can override an existing user email of another user
Scenario: the admin user cannot clear an existing user email
Scenario Outline: a normal user should not be able to change their email address
Scenario Outline: a normal user should not be able to edit another user's email
Scenario: the admin user can edit another user display name
Scenario: the admin user cannot clear another user display name
Scenario Outline: a normal user should not be able to change their display name
Scenario Outline: a normal user should not be able to edit another user's display name

Related Issue

Part of https://github.com/owncloud/ocis/issues/4937

How Has This Been Tested?

Locally
:robot:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[x] Acceptance tests added
[ ] Documentation ticket raised:

I would suggest to implement case where admin change userPassword - the most likely case in the real life of the product. And if you also check that the user is logged in with a new password, that would be great.

user1 forgets his password
admin changes password
user1 logs in using new password


Entity class naming

Adding the generate alias and generate name classes as requested.

Given the work of the awesome previous reviewers, I'll remove myself :)

/gcbrun

/gcbrun

/gcbrun


Expose serde_json::value::ser::Serializer as a public API

Hey all! I'm working on a little project where I thought it would be useful/possible to use serde_transcode to intercept deserialization of some data, and I wanted to do that by transcoding the data (with its arbitrary deserializer) into a serde_json::Value, where I could then reason about it, and then finish the process by deserializing from the serde_json::Value into the original type being deserialized. In the process I discovered that the ser module of serde_json::value is private/not exposed. It looks like serde_json::value::ser is not documented, and contains some types that are marked pub but look like they don't particularly want to be exposed as public API. Still, is it a feasible idea to document (trivially? I assume?) and then expose the serde_json::value::ser::Serializer through a pub use in serde::json::value? Value already implements Deserializer so it feels a bit asymmetric to have it going one way but not the other.

I went ahead and made a PR for this: #621


Revert "add configuration for poem"

Reverts bankrate/red-rover#21

Summary by RedRover

Revert: Removed the poem generation feature from the review process. This change affects the .github/workflows/redrover_review.yml, action.yml, src/main.ts, and src/prompts.ts files. The update simplifies the review process by eliminating unnecessary steps, improving efficiency and user experience.

:dog: RedRover

Currently reviewing new changes in this PR...

Commits
Files that changed from the base of the PR and between 45ed032a0dd91815263defbee4b0c653649d1617 and d872bfaa34098095f4d7babfba26608cc187cfd2 commits.

Files selected (4)

.github/workflows/redrover_review.yml (1)
action.yml (2)
src/main.ts (1)
src/prompts.ts (3)

:dog: RedRover

Currently reviewing new changes in this PR...

Commits
Files that changed from the base of the PR and between f8f35e516dd7a6ff375935f06e2c903419f698b8 and d872bfaa34098095f4d7babfba26608cc187cfd2 commits.

Files selected (4)

.github/workflows/redrover_review.yml (1)
action.yml (2)
src/main.ts (1)
src/prompts.ts (3)


I can't check my Play integrity

EEverytime I try to check this error pop ups.

No idea why this happens. Does it happen every time?

+1

No idea why this happens. Does it happen every time?

Yes. I've never been able to check my safety net/play integrity. I actually don't know if I passed the test or not.

+1 happens every time

Same here

Same issue for me.

same here.

+1

Same here.

Same here.

It's working again now.

"The calling app..." just means that the daily request limit for the API key exceeded. That's basically everything. Wait a day and it'll be fine.

"The calling app..." just means that the daily request limit for the API key exceeded. That's basically everything. Wait a day and it'll be fine.

My error is different from the other here.
It says "There was a transient error in the clients service."

"The calling app..." just means that the daily request limit for the API key exceeded. That's basically everything. Wait a day and it'll be fine.

My error is different from the other here.
It says "There was a transient error in the clients service."

Im sorry, my reply was directed to @h1dd3n3y3 (See this answer)


Fixes TS7010 on tsConfigs with no implicit any

node_modules/@sendgrid/helpers/classes/email-address.d.ts(11,3): error TS7010: 'fromData', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/@sendgrid/helpers/classes/email-address.d.ts(16,3): error TS7010: 'setName', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/@sendgrid/helpers/classes/email-address.d.ts(21,3): error TS7010: 'setEmail', which lacks return-type annotation, implicitly has an 'any' return type.

This just updates the typings to fully declare what the function returns. When typescript is configured with noImplicitAny set to true, the errors above are triggered.

Fixes
Checklist

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the [Contribution Guide] and my PR follows them.
[ ] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


float16 support for Polaris/Baffin ?

Is the Baffin GPU capable of single-rate float16?
I don't see either the AMD "half" extension or float16=true in VK_KHR_float16_int8 in the AMDVLK driver.

float16 is supported only on GFX9 (or above) product, such as Vega. Baffin is GFX8 product, so the extension support is unavailable.

Single-rate fp16 is supported by GCN3+, no?
This is supported by the nearly equivalent AMD_gpu_shader_half_float extension on many GCN3+ GPUs.

Yes, we could support single-rate fp16 on GFX8+. But we believe it is meaningless to performance. Thus, we discourage the use of it and expose the extension on GFX9+ which have better performance with double-rate fp16.

Use of fp16 may cut register pressure in half
If there were spills caused by use of fp32 then this would improve performance.
You can store twice as many fp16 values in the same register footprint
More processing can be performed on-die, thus reducing off-multiprocessor memory traffic

Both impact performance.
I have plenty of compute shaders that benefit from fp16.
If support for single-rate fp16 is being dropped then performance will be reduced on AMD devices.

@Anteru Matthaeus is involved. Maybe he could comment on this.
We do plan to loosen restrictions and expose more fp16 properities to let developer choose whether to use it or not. Currently,  just using extension string is too coarse. This is under discussion but is not finalized.

we have a panel option OnlyEnableFP16ForGfx9Plus = false to force enable fp16 on gfx8. it can work in most case, but I am not sure whether it can pass CTS. I hope it can help you.

Setting OnlyEnableFP16ForGfx9Plus,false in the file ~/.config/amdPalSettings.cfg results in the VK_AMD_gpu_shader_half_float extension reappearing.
FWIW, the VK_KHR_shader_float16_int8 extension still reports .shaderFloat16=false.
I'll see how my shaders perform with and without this option.
Thanks!!!

The only way you can get improvements through FP16 on GFX <9 is by increasing occupancy of highly occupancy constrained shaders. This is unfortunately very different from normal usage of FP16 code, which tries to exploit FP16 arithmetic, which does perform actually worse on hardware without double-rate FP16 -- and hence FP16 is limited by default to ASICs which provide the full benefits.
I'd be curious to see how the shaders you have look like btw :) Are there available online somewhere?

I don't fully understand the above comment though... are you saying fp16 throughput on GFX <9 is less than 1:1?
If fp16 throughput is less than fp32 I would definitely consider not using it on GFX <9.
For AMD GCN, my compute shader has a big slab of registers that represent 44 channels of color+alpha per lane in a 64-wide subgroup.
If each channel is an fp32, then that's at least 44 32-bit registers plus a number of other registers.  That may push the shader into using more than 64 32-bit registers per lane.
If each channel is an fp16, then that's 22 32-bit registers leaving plenty of room for the rest of the shader.
I've benchmarked the shader with fp32 and it's very fast but using fp16 would likely significantly reduce register pressure.
The shader in question is forthcoming... I'll have to regenerate it for a GFX 9+ device as I only have an RX 560 in my workstation right now.

On GFX9, it is at most 1:1, but you end up spending more time packing/unpacking/converting that your effective ALU rate will be lower than running FP32 all the time. Certainly so if you're coming from code written for GFX9 which uses mixed precision math etc.
If your shader is fully occupancy bound then you may see benefits, but it's very rare in practice.

Ah, I see.  Note that all math operations in the shader should remain in fp16.  It's mostly fma, add/sub, min/max ops.
I was assuming that there was no overhead in packing/unpacking the single-rate fp16 on GFX<9.
I'll get you fp32 and fp16 shader variants as soon as I can.

close it since it's an old ticket


Add binary exercise

This is a cherry-pick of @ebengt's work in #29 (with modified import statement to work with the old test runner)

Nice :+1:


sharing

Type: Performance Issue
The sharing isn't working. The person joining the live share is not able to get access to it. They are told that the session is 'no longer active' despite having opened the link they were sent by the host who is inside the document.
VS Code version: Code 1.74.0 (Universal) (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:43:37.594Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: No

Please file an issue in the Live Share extension's repository. Thank you!


Run etcd on localhost for all providers.

#5011

Oh, sure, make me responsible! ;)

Thank you!
Sent from my iPhone

On Apr 3, 2015, at 3:18 PM, Zach Loafman<EMAIL_ADDRESS>wrote:
Merged #6422.
—
Reply to this email directly or view it on GitHub.

Great, thanks for the change.


How do I set the name of the foreign key on queryInterface.addColumn()?

I'm trying to add new columns to multiple tables called "projectId", which as you may have guessed, refers back to the id column in the Project table.   The first table that I alter with addColumn() works fine, but the second table's addColumn() seems to fail because the FK name is not unique.
Here' s the code I'm running:
queryInterface.addColumn(
    { tableName: "CriticalProcessParameters" },

    "ProjectId",
    {
        type: DataTypes.INTEGER,
        references: {
            model: "Projects",
            key: 'id'
        },
    }
);

and here's the error I get:
Executing (default): ALTER TABLE `CriticalProcessParameters` ADD `ProjectId` INTEGER, ADD CONSTRAINT `ProjectId_foreign_idx` FOREIGN KEY (`ProjectId`) REFERENCES `Projects` (`id`);   Unhandled rejection SequelizeDatabaseError: ER_DUP_KEY: Can't write; duplicate key in table '#sql-1d44_502'
    at Query.formatError (C:\projects\cherrycircle\node_modules\sequelize\lib\dialects\mysql\query.js:175:14)
    at Query._callback (C:\projects\cherrycircle\node_modules\sequelize\lib\dialects\mysql\query.js:49:21)
    at Query.Sequence.end (C:\projects\cherrycircle\node_modules\mysql\lib\protocol\sequences\Sequence.js:86:24)
    at Query.ErrorPacket (C:\projects\cherrycircle\node_modules\mysql\lib\protocol\sequences\Query.js:94:8)
    at Protocol._parsePacket (C:\projects\cherrycircle\node_modules\mysql\lib\protocol\Protocol.js:280:23)
    at Parser.write (C:\projects\cherrycircle\node_modules\mysql\lib\protocol\Parser.js:74:12)
    at Protocol.write (C:\projects\cherrycircle\node_modules\mysql\lib\protocol\Protocol.js:39:16)
    at Socket.<anonymous> (C:\projects\cherrycircle\node_modules\mysql\lib\Connection.js:109:28)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:153:18)
    at Socket.Readable.push (_stream_readable.js:111:10)
    at TCP.onread (net.js:536:20)

How do I set name of the foreign key to be something other than 'ProjectId'?

Also, I tried passing in a foreignKey in for the options, but that didn't help.  The code makes it look like that might be possible but it didn't work.  For example:
queryInterface.addColumn(
    { tableName: "CriticalMaterialAttributes" },

    "ProjectId",
    {
        type: DataTypes.INTEGER,
        references: {
            model: "Projects",
            key: 'id'
        },
        foreignKey: "CriticalMaterialAttribute_ProjectId",
    },
    { foreignKey: "CriticalMaterialAttribute_ProjectId"}
);

Well, it seems to be restriction of MySQL that you can't have multiple foreign keys with the same name in the same DB. I think you are trying to fix it correctly by specifying foreign key name exactly.
There are still one solution what we can do better: ensure that every foreign key (or indexes) have an unique name. But it is an issue of Sequelize not Umzug. Moving.

This issue was moved to sequelize/sequelize#7549


Option to configure buffer length

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: windows 10 version 1803
Hyper.app version: 2.0.0 stable
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/crostine/2d3e78e22261b232cc703b26b16bf312
Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
The issue is reproducible in vanilla Hyper.app: yes

Issue

I noticed after updating to 2.0.0 stable that the maximum number of lines in a terminal window changed from something rather large to 999 which is fairly short.
Is there a workaround for this?
Could the number of lines be changed to an option in the config file?

Please see #280 and PR #3056

#3038 that implements an option to configure scollback has been merged.
Please try the new options with the latest Hyper Canary.

👍


Add similar projects to README

https://github.com/spyder-ide/qtpy/tree/master/qtpy
https://github.com/jupyter/qtconsole/blob/master/qtconsole/qt_loaders.py

This could have been a pull request.

Sorry, yes. I made that as a mental note for later... as I was in the middle of https://github.com/mottosso/Qt.py/pull/41 ... but I'm adding it now.


How to get the js instance of the gallery or carousel?

Hello,
How can I get the js instance of the gallery? I want to run Blueimp API commands...
I tried:
var gallery = $('#blueimp-gallery').data('gallery');

As shown at the official Blueimp Gallery docs, but that always returns undefined...
The problem:
I have an Youtube video slideshow inside a modal.  When I hide the modal before pausing the video, I keep listening the audio..
I would like to stop the video when hiding the modal.
Thanks!

@almirb you need to check the id of the widget at the resulting web page. I highly recommend you to configure the widget's id so is not randomly created by Yii. That way you could then get the instance:
<?= dosamigos\gallery\Gallery::widget(['id' => 'my-gallery', 'items' => $items]);?>

var gallery = $('#my-gallery').data('gallery');

let me know if it works. br


Valid footer template produces unexpected results

My footer template:

   /

My resulting footer:

As you can see, the font is not exactly what I expected.

Make sure the system indeed has the Latin Modern Roman font, which might be under a different name. Additionally, you can first use a commonly used font to test whether the code snippet is effective. Example for:

 /

The actual font name:


Use the apt postgres server packages from postgres

install: Pin the postgres version to the OS default
We would prefer to use the postgres packages from Postgres themselves, if available.  However, this requires ensures that, for existing installs, we preserve the same version of postgres as their base distribution installed.
Move the version-determination logic from being computed at puppet interpolation time, to being computed at install time and pinned into zulip.conf.
install: Use the apt postgres server packages from postgres.
This allows Debian and Ubuntu administrators to reasonably seamlessly swap over to more recent version of postgres than ships with their distribution.

Testing Plan: Installed a new server.

We probably will also need to refactor docs/production/upgrade-or-modify to discuss the new world where postgres version updates are independent of server version updates.
(Most of the actual work for server version upgrades in our docs is really about postgres).

This looks great to me, merged, thanks @alexmv!
There's a few follow-ups for this of varying priority:

We need to extend the section of docs/production/upgrade-or-modify on upgrading the OS to explain how to upgrade the postgres release without changing the OS.  This is a release blocker.
We should probably figure out somewhere in docs/production to say that Zulip uses postgres 12 on systems that were not upgraded.  This is a release blocker.
I just had the thought that we should perhaps use crudini for all the work on zulip.conf in scripts/lib/install; that might be a lot cleaner...

Opened https://github.com/zulip/zulip/issues/15415 for that documentation work.  @arpit551 FYI since you were working on testing the OS upgrade and postgres documentation process and ran into bugs there.


feat(Dockerfile): Run apline images as nonroot user

Updating alpine Dockerfile to run as nonroot user. Following the same uid/name/group as distroless images (see https://github.com/GoogleContainerTools/distroless/blob/0d757ece34cdc83a2148cea6c697e262c333cb84/base/base.bzl#L8)

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixed formatting inconsistency in issue-template

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #39017

Nice work @UnevenCoder! Congratulations on submitting your first Pull Request!

Nice work @UnevenCoder! Congratulations on submitting your first Pull Request!

thanks a lot , looking for to do more and learn along the way !!

Thanks for the quick fix!


untabified, applied editorconfig rules

no code changes, just aligning formatting
untabified, selected region and applied editor config rules
removed trailing spaces
Signed-off-by: Ilan Pillemer<EMAIL_ADDRESS>

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Setting Links inside a page using the WYSIWYG Editor at design time is brokn

Describe the bug
When you edit a page and want to set links to different heading of that page the "Insert/Edit Link"-functionality of the editor offers you the headings available on the page. These links don't work after saving.
Steps To Reproduce
Steps to reproduce the behavior:

Create a new page
Add content and heading
Mark a word and press on Insert/Edit Link
Click in the URL text field and choose a heading

5 . Klick ok and save the page
6. After clicking on the link on the page nothing happens. The anchor set for the text doesn't exist

Expected behavior
The link should link to the correct heading.
Your Configuration (please complete the following information):

Exact BookStack Version (Found in settings): 0.30
Hosting Method (Nginx/Apache/Docker): docker (Linuxserver.io)

Hi @cdrfun,
Thanks for reporting.
This is one of the WYSWYG editor features that I didn't really know existed.
You'll find that this will work for headers that were part of previous page saves, just not fresh ones due to the way we re-assign ids ourselves.

Changes made in 465d405926c7e22173fe650bf2d417d4633d7990 will now mean links are updated when the ids are changed which should solve this, Therefore I'm going to close this off.
These changes will be part of the v0.30.2 patch release.

Just wanted to confirm: The bug is resolved. Thank you!


Remedy errant spacing in ImageMagic compose cmd building.

CoffeeScript trims leading/trailing spaces from multi-line strings,
so we ended up with filenames and flags occasionally jammed against the
geometry portion.

Looking back through old PRs... Looks like this bug still happens if you enable downsampling. It'll build an invalid (crashing) command line.


[yasm] Repaired the PDB file that was overwritten due to having the same name

Due to the name of tool yasm is same with lib yasm, so the matched pdb file of yasm.dll was overwritten by tool yasm, rename the tool yasm to fix this issue. And restore the tool name after the function vcpkg_copy_tools.
The related build warning of yasm:
CMake Warning at scripts/cmake/vcpkg_copy_pdbs.cmake:44 (message):
  Could not find a matching pdb file for:

      F:/vcpkg/packages/yasm_x64-windows/bin/yasm.dll
      F:/vcpkg/packages/yasm_x64-windows/debug/bin/yasm.dll

Call Stack (most recent call first):
  ports/yasm/portfile.cmake:43 (vcpkg_copy_pdbs)
  scripts/ports.cmake:196 (include)

[x] Changes comply with the maintainer guide.
[ ] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

DO NOT RENAME BINARIES.
Use https://cmake.org/cmake/help/latest/prop_tgt/PDB_NAME.html


VSCode launch config for debugging tests written using node-tap

Hi,
I used the following VSCode launch config to debug tests written using node-tap:
{
    "type": "node",
    "request": "launch",
    "name": "Run test (current)",
    "program": "${workspaceFolder}/node_modules/.bin/tap",
    "args": [
        "${workspaceFolder}/${relativeFile}"
    ],
    "cwd": "${workspaceFolder}"
}

However, the debugger is not stopping at the breakpoint in test files
I've created minimal repo node-tap-vscode-launch-config to reproduce the issue.
Do I need to add some additional arg or some other config so that debugger stops at breakpoints while running tests using node-tap?
Regards,
Trivikram

this is my launch.json
        {
            "type": "node",
            "request": "launch",
            "name": "test all",
            "runtimeExecutable": "${workspaceFolder}/node_modules/.bin/tap",
            "runtimeArgs": [
                "--node-arg=--inspect-brk=12345",
                "${workspaceFolder}/test/*.test.js"
            ],
            "port": 12345,
            "restart": true,
            "timeout": 3000,
            "autoAttachChildProcesses": true
        }
``

The solution is surprisingly simple - add ${relativeFile}  to the program without calling tap
{
    "type": "node",
    "request": "launch",
    "name": "Run test (current)",
    "program": "${workspaceFolder}/${relativeFile}",
    "cwd": "${workspaceFolder}"
}

Closing


trailingSlash: true does not work if there are query params

I'm having many issues with router5 when I use URLs with "query" parameters (not real URL query params, but those params after "?" after the URL fragment "#").
My routes:
{
  name : "foo",
  path  : "/:companyId"
}

Router options:
{
  trailingSlash : true,
  strictQueryParams : false
}

Then let's open the web app directly with the following URLs:
https://localhost/#/microsoft

It matches the foo route.

https://localhost/#/microsoft/

It matches the foo route and rewrites the URL to https://localhost/#/microsoft.

https://localhost/#/microsoft?qwe=123

It matches the foo route.

https://localhost/#/microsoft/?qwe=123

It does NOT match the foo route.

I've also tried adding "/" to the path in the foo route and also trailingSlash:false. Nothing works.
Do I miss something? or is it just that router5 does not properly behave when there are "extra query params" in the initial URL?

Things are even worse if useHash: false in the browser plugin. If the initial URL has real query params (?foo=bar) no route is matched at all, no matter which the value of trailingSlash, useTrailingSlash or strictQueryParams are.
May I know please whether this is supposed to work or not? I just wouldn't like to spend more time on this if this is not even supposed to work. Thanks.

OK, now I'm pretty sure that strictQueryParams: true is ignored for the original URL of the web page.
I've added some query params to the route (path: '/:company?foo') and then opened the web with those exact query params. It matches the route. But if I add any extra query param (/google?foo=bar&baz=123`) then the route IS NOT matched.
However, if later I run router.matchPath('/google?foo=bar&baz=123') then it matches the route.

@troch any comment, please?

I'm going to have a look.

Humm, something may have changed. I'm trying adding the final slash to the routes' path:
routes:
[
  {
    name     : 'join',
    path     : '/:organizationId/:roomId/' // NOTE the final "/"
  }
]

options:
trailingSlash     : true,
useTrailingSlash  : true,
strictQueryParams : false

// in browserPlugin:
useHash : false

Then if I directly open these URLs this happens:
https://localhost/Microsoft/Test

The "join" route is matched.
Location is rewritten to https://localhost/Microsoft/Test/.
OK

https://localhost/Microsoft/Test/

The "join" route is matched.
OK

https://localhost/Microsoft/Test?qwe=123

The "join" route is matched.
Location is rewritten to https://localhost/Microsoft/Test/?qwe=123.
Route params include qwe: 123.
OK

https://localhost/Microsoft/Test/?qwe=123

The "join" route is matched.
Route params include qwe: 123.
OK

So it seems it works fine.
HOWEVER: If I remove the final slash from routes' path (and set trailingSlash and useTrailingSlash to false) the above URLs do NOT work. If the initial URL contains query params the "join" route is NOT matched.

So I'm not sure what's wrong, but you should avoid adding adding a trailing slash to path definitions. If you want to enforce trailing slashes, you simply need to set useTrailingSlash to true. trailingSlash option is set to true as a result (and you shouldn't change it to false).

Avoid defining paths

Hi, I do know that I shouldn't add slashes in the path and I know how trailingSlash and useTrailingSlash work. The problem (as explained above) is that router5 fails to process the initial URL of the web app.
In similar reported issues (such as #114) I see that you test the behavior via router.matchPath() API, and it works that way. Yes, it works that way. Again, the problem is that router5 does not behave the same way when it comes to process the initial URL that started the web application.
I will try to provide a simple code snippet that reproduces the problem so you can see the problem.

I hope this clearly shows the problem:
https://github.com/ibc/router5-url-issue

Hi @troch, can you please confirm whether you will be able to check my demo project demonstrating the issue? I'm just living with many ugly hacks for now (such as adding or removing final slash before the query params in the original URL before starting router5) but I hope I'll no longer need them in the future.

I've not had the time to have a look, but thank you for sending the link!

Just wondering if router5 5.8.3 or it's updated dependency route-node 5.0.3 is related to this issue :)

Thanks, do not worry and also enjoy your holiday ;)

I'm trying to test router5 v6. However it's not being easy. I cannot just use a Git URL in package.json pointing to the "v6" branch because router5 does not have a preinstall script in its package.json, so the building stuff must be done separately.
Entering into myapp/node_modules/router5 and running npm install && npm run bootstrap does work, but npm run build fails:
~/tmp/router5-url-issue/node_modules/router5 git:router5-v6▲ $ npm run build

> router5@ build /Users/ibc/tmp/router5-url-issue/node_modules/router5
> node scripts/build && npm run build:umd

Building router5
packages/router5/modules doesn't exist
child_process.js:644
    throw err;
    ^

Error: Command failed: babel packages/router5/modules --out-dir packages/router5/
packages/router5/modules doesn't exist

    at checkExecSyncError (child_process.js:601:13)
    at execSync (child_process.js:641:13)
    at packages.forEach.pkg (/Users/ibc/tmp/router5-url-issue/node_modules/router5/scripts/build.js:23:5)
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/Users/ibc/tmp/router5-url-issue/node_modules/router5/scripts/build.js:16:10)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)

This may be due to NPM placing and sharing dependencies on the parent node_modules folder and so on, so I did a fresh git clone of the v6 branch. Now npm run build (after previous npm commands) fails with:
> router5@ build:umd /Users/ibc/tmp/router5
> rollup -c rollup.config.js

🚨   Error: 'default' is not exported by packages/router5-transition-path/dist/es/index.js
https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module
packages/redux-router5/modules/lib/routeNodeSelector.js (1:7)
1: import transitionPath from 'router5-transition-path';
          ^
2:
3: function routeNodeSelector(routeNode) {

v6 finally out, thanks for your patience

Hi, I've updated my router5-url-issue project with router5 6.0.0 and updated the route options to be:
trailingSlashMode : 'default',
queryParamsMode   : 'loose'

I've also tried with other values for trailingSlashMode. The issue still exists. You can check it by cloning https://github.com/ibc/router5-url-issue and running gulp live.

Hi, the issue still exists in 6.1.3


Generate bindings [WIP]

Hello!
Do you have notes or a script recording how you generated the bindings the first time around?
As SDL and Clang.jl develop, it might be useful to regenerate the bindings occasionally, but I couldn't find a script to do that. So I've written one. I've tried to reproduce the results you got originally, but there are a few differences, even excluding the ones I know are manual edits.
I've made some notes on the differences I've found so far, if you have some idea about why they're there, that would be helpful to me :)
Some of these are manual changes, some will be due to Clang.jl changes. Some might be
deliberate configuration differences.

Differences in SDL.jl
    They manually changed a bunch of types from Cint to more specific things.
    I don't know whether that was required to get things to run or whether they
    just wanted the documentation.
       Mostly resolved now, just needed to compile with better system includes

    They have type annotations in the functions signature most of the time and I don't

    There are a few more SDL functions in mine (perhaps they didn't really run it on
    2.0.5? or old Clang.jl couldn't find them?)

    There are a load of _mm_* functions in theirs

    Some functions in mine take and return no arguments when they definitely should
    (iconv, writeu8, utf8strlcpy)
       Resolved now, just needed to compile with better system includes

    They have some definitions for varargs funcs that I don't. OTOH, I don't think these
    are supported by ccall yet.

Differences in SDL_h.jl
    Mine uses @cenum, and that makes the diff a huge mess. I'll work on it another time.

Hi, thanks for doing this, it would be nice indeed to have a script that allow to easily re-generate the bindings.
This is what I used at the time (I also have another one that loops on headers, but here I was doing the bingings for plugins):

using Clang
import Clang, Clang.cindex

extension(f::String) = splitext(f)[2]
filename(f::String) = splitext(f)[1]

include_path = "/Users/bieler/Downloads/SDL2-2.0.5/include/"
include_path = "/Users/bieler/Desktop/tmp/SDL2-2.0.8/include"

#headers = readdir(include_path)
#headers = filter(f->extension(f)==".h",headers)

cd("/Users/bieler/.julia/v0.6/SDL/gen")
mkpath("out")

##

    header = "SDL_ttf.h"
    header = "SDL_image.h"

    context = wrap_c.init(;
        output_file = joinpath("out", string(filename(header),".jl")),
        header_library = x -> filename(header),
        common_file = joinpath("out", string(filename(header),"_h.jl")),
        clang_diagnostics=true
    )
    context.options.wrap_structs = true
    wrap_c.wrap_c_headers(context, [joinpath(include_path,header)] )

But as I remember I had to do a lot of manual edits to get things to work, I'm not an expert in C so I might have messed up sometimes. I commented all the mm function so if they are gone that's good, they seem like some internals we don't really need.

Thanks!
I updated my notes as I went, btw:
https://github.com/jonathanBieler/SimpleDirectMediaLayer.jl/blob/7c595be8ad3ec33a24cbe15fb6333d072775d1eb/gen/generate_bindings.jl#L1
The final commit above shows all the manual changes I had to make, too (and those manual changes can be done better, too, I just hacked it till it worked, initially)

I moved my experimentation to a new repo, but could still merge into this one at some point if there is interest.
https://github.com/cmcaine/LibSDL2
From the readme:
This library differs from SimpleDirectMediaLayer.jl in that:

Most functions and structures have docstrings (extracted from the C source)
This includes functions up to v2.0.12 instead of v2.0.5
The functions are not typed, so you can rely on Julia's native cconvert to do the more tedious conversions
Fewer irrelevant functions (used a newer Clang)
Many constants are wrapped in CEnums (used a newer Clang)
This should be easier to update with new versions of SDL

This and SimpleDirectMediaLayer.jl might merge, idk. This is an experiment.

It looks great, specially the docstrings. I'm find with merging, given that the tests pass, and we would do a major release in case it breaks something. I can even give you access to the repo if you want.

Thanks, it's been fun learning how it all works :)
I was considering a bigger API change by following Clang.jl and CSFML.jl in having an internal LibSDL module with the fully prefixed names and an outer module (SDL or SimpleDirectMediaLayer) that has a nicer Julia wrapper.
The outer module might also export all the SDL_ names, maybe some of the constants that aren't prefixed, too (e.g. AUDIO_U8)?
That would be very breaking, but I don't think that it's easy to provide a nice Julia wrapper in the same module as the C bindings.
A possibly better alternative is to have a package for just the bindings, with prefix removed as they are now for compatibility, and a separate module for the nicer wrapper?


Not able to copy anything outside Excalidraw when embedded

This has been fixed via https://github.com/excalidraw/excalidraw/pull/3275


The products data in the cart are loaded again from the database on every request which is made in the shop

1. Why is this change necessary?
The products data in the cart are loaded again from the database on every request which is made in the shop (e.g. search, open a simple shop page, open a product page, ...)
2. What does this change do, exactly?
Optimisation of the function isComplete in the file src/core/Content/Product/Cart/ProductCartProcessor.php and some other things which have to be done according to this.
3. Describe each step to reproduce the issue or behaviour.
The problem is mainly due to the function isComplete in src/core/Content/Product/Cart/ProductCartProcessor.php.
There it asks whether the description of a product line item is null. However, this is ALWAYS zero, as it is never set for a product line item!
This has the consequence that Shopware reloads all products of the shopping basket in the line $products = $this->productGateway->get($ids, $context); in the method collect in the file mentioned above with EVERY request (i.e. also with the search, in the account area, every shop page, etc.).
This is exactly the opposite of what the new shopping cart was actually built for. An improvement brings a performance boost to every request made.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-13250
5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-13267
Please use this issue to track the state of your pull request.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-13267
Please use this issue to track the state of your pull request.

Hey @acris-cp, yould you please take a look at the failing test and the csfixer and add some tests.

Hey @acris-cp, yould you please take a look at the failing test and the csfixer and add some tests.

Hello, we're closing this pull request due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline.

Hello, we're closing this pull request due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://docs.shopware.com/en/shopware-platform-dev-en/contribution/contribution-guideline.


Always charge car during the night when below target charge level

The Optimizer can result in not having the car charged in the morning when there was not enough sugar power available to charge the car. I would not like to solve this with my own scripting, it works be nice to manage this in the solar Optimizer
I'd like to see a parameter activate device time to enable a forced start (charging car, starting dishwasher,..). Typically this is during night time in my case
Describe alternatives you've considered
Using the manual control option to accomplish this wich I expect will work
Thanks for your great efforts!

Yes, I have in mind for doing that one day. I keep it.
Please be patient, I have really no time for doing that quickly.

I made an automation for this particular case, in order to keep the battery level of my car at a minimum. I understand that you'd like the addon to handle this part as well, but in any case I think it could help you or someone else.
Pre-requisite :

This work on my tesla, with the HA integration you can find on Hacs. I don't know about other vehicles.
The car is scheduled to charge at night using the tesla app.

What the automation does : Based on the charge plan defined using an input_select, the charge limit of the car is adjusted before the scheduled charging begins. The optimizer is turned off if needed and turned back on in the morning. Minimum battery level is set to 50%.
`alias: 🌞 Solar Optimizer - Titine
description: ""
trigger:

alias: At 06:00 AM
platform: time
at: "06:00:00"
id: morning
alias: At 10:00 PM
platform: time
at: "22:00:00"
id: night
condition:
condition: state
entity_id: device_tracker.titine_location_tracker
state: home
alias: Titine is at home
action:
alias: Depending on the time of day
choose:

conditions:

condition: trigger
id:

morning
alias: When triggered in the morning
sequence:

alias: >-
Adjust battery level based on Titine's charging plan
choose:

conditions:

condition: state
entity_id: input_select.titine_charge_plan
state: Solar
alias: Charging plan is set to solar
sequence:
alias: Set battery charge limit to 100%
service: number.set_value
metadata: {}
data:
value: "100"
target:
entity_id: number.titine_charge_limit
service: switch.turn_on
target:
entity_id: switch.enable_solar_optimizer_titine
data: {}
alias: Enable solar optimization for Titine
alias: Charging plan is set to solar and battery level is below 50%

conditions:

condition: state
entity_id: input_select.titine_charge_plan
state: Off-peak hours
alias: "Charging plan: Off-peak hours"
sequence:
alias: Set battery charge limit to 75%
service: number.set_value
metadata: {}
data:
value: "75"
target:
entity_id: number.titine_charge_limit
service: switch.turn_off
target:
entity_id: switch.enable_solar_optimizer_titine
data: {}
alias: Disable solar optimization for Titine
alias: Charging plan is set to off-peak hours
alias: In the morning

conditions:

condition: trigger
id:

night
alias: When triggered in the evening
sequence:

alias: >-
Adjust battery level based on Titine's charging plan
choose:

conditions:

condition: state
entity_id: input_select.titine_charge_plan
state: Solar
alias: Charging plan is set to solar
sequence:
alias: Set battery charge limit to 50%
service: number.set_value
metadata: {}
data:
value: "50"
target:
entity_id: number.titine_charge_limit
if:

condition: numeric_state
entity_id: sensor.titine_battery
below: 50
alias: If battery level is below 50%
then:
service: switch.turn_off
target:
entity_id: switch.enable_solar_optimizer_titine
data: {}
alias: Disable solar optimization for Titine
alias: If battery level is below 50%, disable solar optimization.
alias: Charging plan is set to solar

conditions:

condition: state
entity_id: input_select.titine_charge_plan
state: Off-peak hours
alias: "Charging plan: Off-peak hours"
sequence:
if:

alias: >-
Battery charge limit is below 75%
condition: numeric_state
entity_id: number.titine_charge_limit
below: 75
then:
alias: Set battery charge limit to 75%
service: number.set_value
metadata: {}
data:
value: "75"
target:
entity_id: number.titine_charge_limit
alias: If battery charge limit is below 75%, set it to 75%

service: switch.turn_off
target:
entity_id: switch.enable_solar_optimizer_titine
data: {}
alias: Disable solar optimization for Titine
alias: Charging plan is set to off-peak hours
alias: In the evening
mode: single
`

I should turn this into a blueprint but I'm lazy

I will intégrate this directly in the integration. It is very interesting for many people (and I).

Hi
I'm using this to charge my car:
https://github.com/jonasbkarlsson/ev_smart_charging/
And my plan is to use it in parallel with Solar Optimizer:

use as much as possible of Solar energy in daytime
and EV Smart Charging for nights or periods with cheaper energy

Same logic in both: Turn a switch on or off for a certain period and optionally adjust the load.
And automations can handle that they are not interfering with each other (one app turns devices on and another off)

Similar issue: https://github.com/jmcollin78/solar_optimizer/issues/47

Hello,
this is now implemented with release 2.1. Please have a look.
https://github.com/jmcollin78/solar_optimizer/releases/tag/2.1.1


Use a quantized LM or something smaller to make it easier to run the demo

https://github.com/apple/ml-mdm/pull/60


Add OapOrcUtils to fix #935

What changes were proposed in this pull request?
Add OapOrcUtils  instead of  importing UTF8String.java from spark2.3.
Fix #935
How was this patch tested?
unit tests, integration tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@zhixingheyi-tian on the other hand, may we can only introduce ColumnVector.java to Sprark-2.1 & Spark-2.2 do a few simple changes and remove all class under vectorized.oap.orc

Thx @zhixingheyi-tian fix this problem.

This patch need back port to branch-0.5


Allow usage with Cryptography 44.0.0

This required increasing the minimum Python version for PySETO from 3.9.0 to 3.9.2, to match the minimum version set by Cryptography, otherwise Poetry wouldn't allow the latest version to be installed.

This required increasing the minimum Python version for PySETO from 3.9.0 to 3.9.2, to match the minimum version set by Cryptography, otherwise Poetry wouldn't allow the latest version to be installed.

No problem. Thanks for the PR.


[SPARK-42059][BUILD] Update ORC to 1.8.2

What changes were proposed in this pull request?
This PR aims to update ORC to 1.8.2.
Why are the changes needed?
This will bring the latest bug fixes and changes including an SBOM.

https://github.com/apache/orc/releases/tag/v1.8.2

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

cc: @dongjoon-hyun

+1 Thanks @williamhyun

Merged to master for Apache Spark 3.4. Thank you, @williamhyun and @huaxingao .


[Improvement] RegExp template support under template expressions

Description:
$subject
Describe your problem(s)

Support
re `value`

The requested changes are completed. therefore closing the issue


Carousel and Hero H1 H2 title positioning

This has been worked upon via https://github.com/hlxsites/ororafresh/pull/75.
Changed the position & responsiveness of H1 & H2 text within the carousel. Its a lot better now. Please check & validate -
https://hero-carousel-17--ororafresh--hlxsites.hlx.page/Drafts/Meet/
Many Thanks

Also noticed that https://ororafresh.com/ - There carousel on Hero is automatically switching the images after 10 seconds, hence implemented a logic.
Please check & validate - https://hero-carousel-17--ororafresh--hlxsites.hlx.page/Drafts/Meet/


runtime error

hello when i run the code, i encounter this problem, cuda9.0 pytorch0.4.1
RuntimeError: cuda runtime error (11) : invalid argument at /opt/conda/conda-bld/pytorch_1535491974311/work/aten/src/THC/THCGeneral.cpp:663
could you give me some suggestions? thanks

hellow ， i encounter the same problem，and i have the cuda9.0 pytorch0.4.1    .
Have you solved this problem?


[IAM] Adding user the same IAM group twice causes the group to become "sticky"

Hi team.
Discovered an interesting behavior of mock_s3: if I add an IAM user to an IAM group and then remove the user from the group, everything works as expected, i.e. as a result the user is not a member of any group. However, if I add the user to the same group twice and then remove the user them from the group, the group membership is still retained. So it looks like adding a user to a group is not idempotent operation.
from moto import mock_iam
import boto3

@mock_iam
def test_moto():
    iam = boto3.client("iam")

    def get_iam_user_groups(user_name: str) -> "list[str]":
        """List names of groups the given IAM user is member of"""
        paginator = iam.get_paginator("list_groups_for_user")
        return [
            group["GroupName"]
            for page in paginator.paginate(UserName=user_name)
            for group in page["Groups"]
        ]

    iam.create_group(Path="test", GroupName="test1")
    iam.create_user(UserName="test")

    iam.add_user_to_group(GroupName="test1", UserName="test")
    # the test works without this line and breaks with it whilst it should not affect
    iam.add_user_to_group(GroupName="test1", UserName="test")

    iam.remove_user_from_group(GroupName="test1", UserName="test")
    assert get_iam_user_groups("test") == []

Running this test case with pytest causes it to fail on the last line with the following error:
>       assert get_iam_user_groups("test") == []
E       AssertionError: assert ['test1'] == []
E         Left contains one more item: 'test1'
E         Use -v to get the full diff

mtest.py:26: AssertionError

If I uncomment the third line from the bottom (iam.add_user_to_group(GroupName="test1", UserName="test")) which is duplicate of the one above it, the test passes.
$ pip list | grep [bm]oto
aiobotocore                  2.3.4
boto3                        1.20.34
botocore                     1.23.34
moto                         4.1.1
$ python --version
Python 3.8.14

Ran pytest as pytest -s  mtest.py. Installed moto with pip install moto[iam].

Thanks for raising this @demosito! Looks like we're indeed always appending users to a group, and we don't check for duplicates. Marking it as a bug.
https://github.com/getmoto/moto/blob/c1d85a005d4a258dba98a98f875301d1a6da2d83/moto/iam/models.py#L2473

Fantastic! Thank you for the lightning-fast response!


How does it work with viewpager?

It doesn't at this time. I'll look into it and see if it should / can be done.
It seems that this is not meant to be an indicator for ViewPager though:

Using swipe gestures on the content area does not navigate between views.

Bottom Navigation specs

I won't make this a ViewPager indicator for now.
What you want can easily be implemented by adding OnPageChangeListener to your ViewPager and selecting tabs manually:
ViewPager.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
    @Override
    public void onPageSelected(int position) {
        // select a new tab and animate the selection.
        bottomBar.selectTabAtPosition(position, true);
    }
});

Avoid recursion by adding condition check.
mViewer.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
@Override
public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {
        }

        @Override
        public void onPageSelected(int position) {
            // select a new tab and animate the selection.
             if(position != mBottomBar.getCurrentTabPosition())
            mBottomBar.selectTabAtPosition(position, true);
        }

        @Override
        public void onPageScrollStateChanged(int state) {

        }
    });


chore(typings): best practices for new TS things

removes / ignores generated code from repo, generated as a
pre-publish step.
refactors index.ts to be slightly more idiomatic module style (meh)
removes extraneous TSD things
adds typings field to package.json

Trying to concurrence @valorkin here ? :D
I'll check that out tonight if I have the time :)

@ocombe  concurrence - no, help - yes
@robwormald really appreciate your help :)

Ok that works ! Just added typescript as a dependency, and changed prepublish to postinstall script in npm package :)
I still get a warning in the typescript compiler, but it works nonetheless and I get correct auto completion with webstorm.
Kuddos guys, I think that we have a good dev process here.

Had to adjust a few things with the new version of angular 2 alpha 42 that integrates typings, it works now (again).

Or not.
This is driving me nuts :D

set prepublish back, it works
it is something wrong with windows tsc or npm
and in general it works :)

Yes, I did that. Rob explained to me how prepublish really works, the description on the npm website is just so confusing... :)


The ValueError: Attempted relative import in non-package problem

I have found an error the when t run the "rosrun ggcnn_kinova_grasping kinova_closed_loop_grasp.py  " the terminal pop up the "The ValueError: Attempted relative import in non-package problem" on "from .helpers.transforms import current_robot_pose, publish_tf_quaterion_as_transform, convert_pose, publish_pose_as_transform", I search on the internet if change this to "from helpers.transforms import current_robot_pose, publish_tf_quaterion_as_transform, convert_pose, publish_pose_as_transform", maybe the Relative and absolute import problem. I want to make sure i'm correct.

Hello,
I'm not sure I understand.  The line you reference (https://github.com/dougsm/ggcnn_kinova_grasping/blob/004139fedd5ad304f36de76b43466b4474b2081b/ggcnn_kinova_grasping/scripts/kinova_closed_loop_grasp.py#L13) is already in the form from helpers.transforms import ...

@dougsm
Thanks for your prompt answer, I guess I downloaded the previous version of this code. I will close this issue


Corporate Console - Email is sent to Initial CLA Manager and REQUEST ACCESS status is displayed for the project When joined CLA Manager signs the CLA for the project

Background

Launch Corporate Console
Login as nirupamavmentee214
Create Company RequestAccessTest
Login to corporate console as clamanager2
Click Get Started
Search and Select company RequestAccessTest
Click JOIN COMPANY
Login to corporate console as nirupamavclamanager101
Click Get Started
Search and Select company RequestAccessTest
Click JOIN COMPANY
Login to corporate console as Initial CLA Manager nirupamavmentee214
Click on the Company RequestAccessTest
ACCEPT the Pending CLA Manager request for nirupamavclamanager101
16, Login to corporate console as nirupamavclamanager101
Click on the Company RequestAccessTest
Click SIGN NEW CLA
Search and Select project ProjMay062020
Click SUBMIT
Click YES
Click OPEN CLA
Complete the Docusign process
Observed that in Docusign by default  nirupamavmentee214 is displayed for SIGN details but other details are related to nirupamavclamanager101. Also email is sent to only initial CLA Manager nirupamavmentee214 and not to nirupamavclamanager101.

Login to corporate console as Initial CLA Manager nirupamavmentee214
Click on the Company RequestAccessTest
Observed that REQUEST ACCESS is displayed for the project for CLA Manager nirupamavmentee214 who created the company/ who is the initial CLA Manager

@amolsontakke3576 was this resolved?

@dealako DocuSign part is pending regarding email.

@nirupamav I have verified this ticket with the company name *Adidas Corporation Pune * which is created by @amolsontakke3576 and he is the initial cla-manager then I tried joined company flow as per the step mention above but seems like flow is working as expected also attached the screen-shot.

@nirupamav  Can you provide me more details so I can debug further?

User nirupamav created the company
User v1cla1 joined the company and signed CLA for the project. As expected docusing has details of v1cla1 and v1cla is initial CLA Manager and Singatory
As expected user nirupamav as the status Request Access for the project
v1cla1

nirupamav


Add some more introduction text to datamap and datafragments part

Just added some more introductory text and Viola interaction. Hope it's not too much text

Data fragment selectors part

Datamap part

Great


Add dmm to database.json

A new deno module manager tool

ci /web build failed with the following error when running yarn test:
FAIL util/registries/npm.test.ts
  ● directory listing

    Got an error (500) while querying unpkg:

    <meta http-equiv="content-type" content="text/html;charset=utf-8">
    <title>500 Server Error</title>

Error: Server Error

The server encountered an error and could not complete your request.
Please try again in 30 seconds.

This isn't related to work i've done surely? Guessing a re-run will fix it with the blip on unpkg's endpoint?

Added another module


Launch screen mistakenly displayed in Italian

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.800
Where did you get the app from?
Google Play
Android version
12
Device model
Motorola Edge+ (2020)
Steps to reproduce

Assuming that this issue only occurs with my specific configuration; set your device language to "English (Canada)" in first priority and "French (Canada)" as second.
Install the app from Google Play. If it is already installed, clear the app data from Android settings (equivalent of a reset) or reinstall it from scratch.
Open the app. The launch screen will be shown.

Expected behavior
Show the launch screen in the default language set in Android settings, which in my case, is English.
Actual behavior
The launch screen was displayed in Italian.

The following screens were correctly displayed in English.
Logs
k9mail-logs.txt

The en_GB translation was broken. This has been fixed and will be included in K-9 Mail 6.801.


[Question] The performance for Hopper-v3 doesn't get converged for PPO

❓ Question
Hi there,
I ran into such an issue when I trained an agent using PPO in Hopper-v3. Here is the performance for 5 seeds by running: python3 scripts/all_plots.py -a ppo --env Hopper-v3 -f logs/downloaded

The commands are like: python train.py --algo ppo --env Hopper-v3 --seed 500X;
The seeds are from 5000 to 5004 and the default hyper-parameters are used. It always converges to 1K quickly, dramatically decreases to under 100, and then converges to 1K, ... .
I only encountered such an issue for Hopper-v3 (A2C suffers as well). It works well for other environments.
Is there anything I did wrong? Any help is appreciated!
Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the SB3 documentation
[X] I have read the RL Zoo documentation
[X] If code there is, it is minimal and working
[X] If code there is, it is formatted using the markdown code blocks for both code and stack traces.

Sorry, what more information is needed?

This is a fairly common result of ppo, here's a thread about many others that discusses it:
https://www.reddit.com/r/reinforcementlearning/comments/bqh01v/having_trouble_with_ppo_rewards_crashing/
You can try to decrease the cliping parameter and early stopping the experiment.

Thank you for your suggestions. I will try them.
Based on the experiment results I got, there are another two spot points:

PPO works well for Walker2d-v3 and HalfCheetah-v3 (by working well I mean I can generate comparable performance as the benchmark with the default hyper-parameters)
A2C also fails in Hopper-v3 as below:

In this case, can I regard it as an issue in dealing with Hopper-v3 instead of an issue in PPO?

Sorry, what more information is needed?

The hyperparameters used and your system/lib information (os, gym version, mujoco version, sb3 version, ...)


meltano discover only lists custom plugins

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2199
Originally created by @DouweM on 2020-07-26 16:51:51

View 1 previous comment from the original issue on GitLab


Add extension icon

I modified icon base on simple idea of :

Official Robot Framework icon https://en.wikipedia.org/wiki/Robot_Framework#/media/File:Robot-framework-logo.png (license CC BY-SA 4.0)
Blue color (#007acc) of vscode logo

I like it! Thank you for your contribution!

Also feel free to add yourself to the list of contributors if you feel like it.


QPaysTaxes: Watch pcworldtech.com

QPaysTaxes requests the watch of the watch_keyword pcworldtech.com. See the Metasmoke search here

!!/approve

On Oct 18, 2017, at 3:41 PM, SmokeDetector<EMAIL_ADDRESS>wrote:
QPaysTaxes requests the watch of the watch_keyword pcworldtech.com. See the Metasmoke search here
You can view, comment on, or merge this pull request online at:
https://github.com/Charcoal-SE/SmokeDetector/pull/1160
Commit Summary
Auto watch of pcworldtech.com by QPaysTaxes --autopull
File Changes
M watched_keywords.txt (1)
Patch Links:
https://github.com/Charcoal-SE/SmokeDetector/pull/1160.patch
https://github.com/Charcoal-SE/SmokeDetector/pull/1160.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Update README.md

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #39   +/-   ##
====================================
  Coverage      68%   68%
====================================
  Files          16    16
  Lines         400   400
  Branches       68    68
====================================
  Hits          272   272
  Misses        103   103
  Partials       25    25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eadb76...d058b9a. Read the comment docs.


[TASK] Fix integration test for ARM64

The current integration test results in quite a few errors:
~https://ci.longhorn.io/job/public/job/longhorn-tests-arm64/12/~
New CI URI: https://ci.longhorn.io/job/public/job/ubuntu/job/arm64/job/longhorn-tests-ubuntu-arm64/

Probably also needs a specific test to create a PV bigger than 2GB to prove #1847 can be closed...

I've commented on #1847. I think it should due to ARMv7(32 bits) rather than ARM. We will verify it in ARM64.

@meldafrawi is this still valid? I thought the daily auto regression on ARM64 is quite stable.

This is done. The latest test result shows 22 test failures out of 232 tests. https://ci.longhorn.io/job/public/job/ubuntu/job/arm64/job/longhorn-tests-ubuntu-arm64/197/
Will track other test failures separately.


Add phpstan command.

The Issue
Adds support for phpstan command to more closely mimic GitLab CI configuration/runs.
How This PR Solves The Issue

Adds the phpstan command.
Updates README documentation to include command.

Manual Testing Instructions

Run ddev phpstan
PHPStan should run as expected.

Automated Testing Overview
N/A
Related Issue Link(s)
Closes https://github.com/ddev/ddev-drupal-contrib/issues/13
Release/Deployment Notes
N/A

I am currently getting the following error when I attempt to run the command. 🤔
RuntimeException thrown in /var/www/html/vendor/mglaman/phpstan-drupal/src/Drupal/DrupalAutoloader.php on line 68 while loading bootstrap file /var/www/html/vendor/mglaman/phpstan-drupal/drupal-autoloader.php: Unable to detect Drupal at
Failed to run phpstan : exit status 1

It might be because drupalfinder can't find Drupal. Drush no longer uses drupalfinder as it has not had a release in like 5 years. Composer can now find Drupal root. I'll talk to mgalalm

You can work around this by setting up the config.extra  key in composer.json as usual.
"installer-paths": {
            "web/core": [
                "type:drupal-core"
            ],
            "web/libraries/{$name}": [
                "type:drupal-library"
            ],
            "web/modules/contrib/{$name}": [
                "type:drupal-module"
            ],
            "web/profiles/contrib/{$name}": [
                "type:drupal-profile"
            ],
            "web/themes/contrib/{$name}": [
                "type:drupal-theme"
            ],
            "drush/contrib/{$name}": [
                "type:drupal-drush"
            ]
        }

Will be fixed by https://github.com/webflo/drupal-finder/pull/64 if that gets merged

🚀  would love to see this get in

Would be also nice to add an example in README how to create a PHPStan baseline file for your contrib module via this DDEV phpstan command to help module maintainers and contributors with it :)

From above on this issue:

Will be fixed by webflo/drupal-finder#64 if that gets merged

That got merged 2 weeks ago, but I'm still seeing issues with the current PR as it is coded.
But there is good news.
While looking into this, I stumbled across issue #42 opened by @gardon that was closed as a dupe of this one that has the key information:

Not sure about the implication, but running ddev expand-composer-json allows me to run PHPStan

Originally posted by @gardon in https://github.com/ddev/ddev-drupal-contrib/issues/42#issuecomment-2098618209
If I copy the first two lines from .ddev/commands/web/poser into .ddev/commands/web/phpstan, it works!
These lines:
export COMPOSER=composer.contrib.json
.ddev/commands/web/expand-composer-json "$DDEV_PROJECT_NAME"

The full contents of .ddev/commands/web/phpstan:
#!/bin/bash

#ddev-generated
## Command provided by https://github.com/ddev/ddev-drupal-contrib
## Description: Run phpstan inside the web container
## Usage: phpstan [flags] [args]
## Example: "ddev phpstan" or "ddev phpstan -n"
## ProjectTypes: drupal,drupal8,drupal9,drupal10
## ExecRaw: true

if ! command -v phpstan >/dev/null; then
  echo "phpstan is not available. You may need to 'ddev composer install'"
  exit 1
fi
export COMPOSER=composer.contrib.json
.ddev/commands/web/expand-composer-json "$DDEV_PROJECT_NAME"
phpstan analyse $DDEV_DOCROOT/modules/custom "$@"

I guess I don't have permission to update a PR from someone else.  (I miss the "Get Push Access" we have on Drupal MRs here).

So ddev phpstan is turning up different results than Drupal's GitLabCI.
Fixed by pulling in phpstan.neon file from gitlab_templates project:
Updated working command:
#!/bin/bash

#ddev-generated
## Command provided by https://github.com/ddev/ddev-drupal-contrib
## Description: Run phpstan inside the web container
## Usage: phpstan [flags] [args]
## Example: "ddev phpstan" or "ddev phpstan -n"
## ProjectTypes: drupal,drupal8,drupal9,drupal10
## ExecRaw: true

if ! command -v phpstan >/dev/null; then
  echo "phpstan is not available. You may need to 'ddev composer install'"
  exit 1
fi
test -e phpstan.neon || curl -OL https://git.drupalcode.org/project/gitlab_templates/-/raw/default-ref/assets/phpstan.neon
export COMPOSER=composer.contrib.json
.ddev/commands/web/expand-composer-json "$DDEV_PROJECT_NAME"
phpstan analyse $DDEV_DOCROOT/modules/custom "$@"

I created a new PR #53 building on the work here, fixed merge conflicts, and added separate commits for the different pieces I've mentioned above.

Closing then, thanks.

@rfay https://github.com/webflo/drupal-finder/pull/64 was blocking this but doesn't replace it (AFAIK), unless you are closing it to go with #53?

OK then :)

If you want to continue with it, please rebase and solve the conflicts.

Rebased main and improvements from PR #53.

With the current state of the PR I'm getting:
$ ddev phpstan
...
Note: Using configuration file /var/www/html/phpstan.neon.
File '/var/www/html/phpstan-baseline.neon' is missing or is not readable.

The problem is here https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes/include.drupalci.main.yml#L516
I've created https://github.com/markdorison/ddev-drupal-contrib/pull/1 to improve the current PR


Footer overlaps content on mobile

✅  This is fine:

🔴  This is not:

Problem is due to my footer icons being split on multiple lines when screen is too small. I can't just cross fingers 🤞 and specify a fixed footer height. Flex box can solve this, but isn't it too fancy for old browsers? caniuse flexbox

I wish I used a flexbox for this, but a few <br \> did the trick.


node-gyp rebuild Error when running 'npm install -g pokemon-go-iv'

C:\Users\Russet\Documents\GitHub> npm install -g pokemon-go-iv
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
C:\Users\Russet\AppData\Roaming\npm\pokemon-go-iv -> C:\Users\Russet\AppData\Roaming\npm\node_modules\pokemon-go-iv\bin
app.js

<EMAIL_ADDRESS>install C:\Users\Russet\AppData\Roaming\npm\node_modules\pokemon-go-iv\node_modules\s2geometry-n
ode
node-gyp rebuild

C:\Users\Russet\AppData\Roaming\npm\node_modules\pokemon-go-iv\node_modules\s2geometry-node>if not defined npm_config_no
de_gyp (node "C:\Users\Russet\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\....\node_modules\node-gyp\bin\nod
e-gyp.js" rebuild )  else (node "" rebuild )
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
gyp ERR! stack     at failNoPython (C:\Users\Russet\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\confi
gure.js:449:14)
gyp ERR! stack     at C:\Users\Russet\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\configure.js:404:11
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:82:15)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Users\Russet\AppData\Roaming\npm\node_modules\npm\nod
e_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Russet\AppData\Roaming\npm\node_modules\pokemon-go-iv\node_modules\s2geometry-node
gyp ERR! node -v v4.4.7
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
C:\Users\Russet\AppData\Roaming\npm
`-- (empty)
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\Russet\AppData\Roaming\npm\node_modules\npm\bin\n
pm-cli.js" "install" "-g" "pokemon-go-iv"
npm ERR! node v4.4.7
npm ERR! npm  v3.10.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the s2geometry-node package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs s2geometry-node
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls s2geometry-node
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Russet\Documents\GitHub\npm-debug.log
npm ERR! code 1

I need help too man

I get the same errors, only my node and npm versions are higher:
gyp ERR! node -v v6.3.1
gyp ERR! node-gyp -v v3.3.1
npm ERR! npm  v3.10.3

to solve my issue i tryed as described here:
https://github.com/nodejs/node-gyp#installation
...
On Windows:
Option 1: Install all the required tools and configurations using Microsoft's windows-build-tools using npm install --global --production windows-build-tools from an elevated PowerShell or CMD.exe (run as Administrator).
what I did:
npm install --global --production windows-build-tools
npm install -g node-gyp
npm install node-gyp@latest
but the issue is still not solved on windows
after windows-build-tools there was some progress, a lot of yellow warnings, but finally a red error:
win_delay_load_hook.c
C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373: '__pfnDliNot
ifyHook2': redefinition; different type modifiers [C:\Users\Germo\AppData\Roaming\npm\node_modules\pokemon-go-iv\node_m
odules\s2geometry-node\build\NativeExtension.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134): note: see declaration of '__pfnDliNot
ifyHook2'
gyp ERR! build error
gyp ERR! stack Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Windows_NT 10.0.10586
gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Germo\AppData\Roaming\npm\node_modules\pokemon-go-iv\node_modules\s2geometry-node
gyp ERR! node -v v6.3.1
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
C:\Users\Germo\AppData\Roaming\npm
`-- (empty)
npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "-g" "pokemon-go-iv"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the s2geometry-node package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs s2geometry-node
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls s2geometry-node
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     D:\Git_Repositories\pokemon-journal\npm-debug.log
npm ERR! code 1
D:\Git_Repositories\pokemon-journal>

The idea was also to update node-gyp, I tried
npm uninstall node-gyp
npm install -g node-gyp@latest

after installing it is showing
`--<EMAIL_ADDRESS>but when I run
npm uninstall pokemon-go-iv
npm install -g pokemon-go-iv

the error is showing that an older version of node-gyp is used:

gyp ERR! command "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\bin\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Germo\AppData\Roaming\npm\node_modules\pokemon-go-iv\node_modules\s2geometry-node
gyp ERR! node -v v6.3.1
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok

How can I force to use the node-gyp 3.4.0?

After installing the latest node-gyp
npm install -g node-gyp@latest
I replaced the content of
C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp
containing node-gyp -v v3.3.1
by
C:\Users\Germo\AppData\Roaming\npm\node_modules\node-gyp
containing node-gyp -v v3.4.0
Why there are different npm\node_modules on my system? Isn't there a different way? I don't know, but after this replacement I was able to install
npm install -g pokemon-go-iv
I got a lot of yellow warnings, but finaly it is here:
C:\Users\Germo\AppData\Roaming\npm\node_modules\pokemon-go-iv
Now I can run the pokemon-go-iv
It dosn't work, but this is another issue

Not sure of windows directories, but -g means to install globally, so one of those directories is the global one. It looks like you have it working, but you could just wipe all node_modules directories, go to a new directory somewhere, npm install pokemon-go-iv and it'll install the package in<current dir>\node_modules\pokemon-go-iv and you can run it via `node .\node_modules\pokemon-go-iv\bin\app'


Changes needed for TAC/TOB data

In order to get monthly means calculated with the pollution removed, we need the following things to happen:

Peter Salameh syncs the TAC MD and the TOB ECD to hubibti
Ray Wang calculates pollution flags for TAC MD, TOB ECD and TAC LGR

At the moment the TAC LGR is synced, so Peter creates the .nc files with a pollution flag field, but there are no pollution flags calculated. This is why we get the following errors at the moment:
error_log_individual.txt
TAC n2o: ValueError in stack: run (line 251) / io (line 1026). No data retained for n2o TAC lgr after applying release schedule end dates. Check dates in release schedule or omit this instrument.
TAC co: ValueError in stack: run (line 251) / io (line 1026). No data retained for co TAC lgr after applying release schedule end dates. Check dates in release schedule or omit this instrument.

error_log_combined.txt
TAC n2o: ValueError in stack: run (line 437) / io (line 1026). No data retained for n2o TAC  after applying release schedule end dates. Check dates in release schedule or omit this instrument.
TAC co: ValueError in stack: run (line 437) / io (line 1026). No data retained for co TAC  after applying release schedule end dates. Check dates in release schedule or omit this instrument.

Do we need the baseline for this site? Perhaps I should change the run script to exclude baselines for selected sites?

Hmmm not sure, although we have baselines for TAC/TOB for the other species, so it might make sense to get them for these species too?

Ray Wang has added the LGR flags. Let's discuss the TAC MD and TOB ECD at the December AGAGE meeting

Will push these files to Peter once he has his new hubibti data transfer regime set up


How use image

Hi,
How to use image in this package, because the image not load. I'm  use vuejs.
can you put image in gotron's example?

To use a image it must be included in the directory given to gotron.New("webapp") and referenced using a relative path to webapp.

Using vuecli3 when I put in my components in src/views/Home.vue  I can't call the images using this annotations
 don't work
 don't work
But if i put the image in src/app.vue  using this form import  its work
 work
  work

I'm not too familiar with vue. Guess this related to the way you build your project? Are other components in Home.vue displayed correctly?
Can provide a complete example?

Sorry, @puengel  you need click in home for where is the wrong image.

Hey @rafaelgfirmino , I found the cause of your problem.
https://github.com/rafaelgfirmino/gotron-vue/blob/master/src/router.js line 8:
mode: 'home',
should not be used in electron apps. If you remove this line your code works just fine.

Closing this issue as it is not a gotron issue.

Thanks man !


Proposal for new writer callback

I am trying to write a new writer callback.

It uses queues to store the tiles
It uses semaphores to not get too many queue
It should be generic for a writer as long as there is a consume

Completed.


SVG tags

What do you think about adding support for SVG tags?
The issue was raised in a question on stack overflow
SVG is listed in the html5 spec as valid, and includes these tags

I've  been trying  to do that  some time ago though  I USED SVG specification to generate code from its IDL. There were a lot of bugs in its IDL that prevented me from doing this.
I guess the time has come to do another round 😄

I'll actually rebase my branch with SVG spec work and show it later.

Recently created SVG2 specification makes IDL compliant to WebIDL so we can now properly parse it. However, there are still a lot of falsy/missed things, so it will take some time to make it properly work.


Better wikitext

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[x] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Addresses #1257 and #1191.
Changelog

Use wikitext document level dataset from Hugging Face, which is cleaner and uses whole articles as samples instead of lines - more sensible for text completion datasets
Expose split_across_pack for text completion datasets
Update text completion dataset builder to use column="text" as default
Enforce long int tokens in batch collater

Test plan
tune run --nproc_per_node 8 full_finetune_distributed --config llama3/8B_full dataset.max_seq_len=4096 dataset=torchtune.datasets.wikitext_dataset max_steps_per_epoch=200 epochs=1 runs successfully without previously seen errors

Just one question: I believe that exposing "split_across_pack" is only relevant to text_completion. But are there any others that would be worth updating too, for consistency?

let me take a look, I think the other datasets for SFT instead of CPT should keep split across pack as False, but I don't have any hard evidence suggesting that SFT should never split across pack


Signing and unsigning.

I was doing some experimentation in developing an application that used the public ethereum blockchain, and accessing with web3.js. I poked around in this repository, looking for some specific web3.js functions, like "sign" and "ecrecover", but I didn't see them. I do see a "sign" method associated with transactions, however. I want to be able to sign a user generated string/data, and then later recover the signer from a signature. I was using web3.eth.personal.sign and web3.eth.personal.ecRecover. Are similar functions available in this package? Thanks.

Hello @gkd720
All functions you mentioned are used under the hood, but most likely not exposed as a part of public API. I'll expose them in the next minor version, thank you for spotting this problem.
Sincerely, Alex

Implemented and released in 0.5.2. Please have a look and reopen if necessary.
Sincerely, Alex


Can not create migration file

Hi,I tried to work with generate:migration but it failed.
It works when typing "php artisan migrate:make create_users_table".
The error message was as following,
[root@www laravel-test]# php artisan generate:migration create_posts_table
[ErrorException]
file_put_contents(/root/laravel-test/database/migrations/2014_09_02_072627_create_posts_table.php): faile
d to open stream: No such file or directory
Any setting I missing?Please help! Many thanks.

same error here pliz assist


Adding nightly dogfooding devcontainer

Description
Adds a dogfooding devcontainer that can be used to setup an environment where people can test the latest version of aspire pushed to our nightly feeds. After this one goes in, we can also build one that uses live-built bits.
cc: @mitchdenny
Checklist

Is this feature complete?

[x] Yes. Ready to ship.
[ ] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[x] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[x] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[x] No

Does the change require an update in our Aspire docs?

[ ] Yes

Is this introducing a breaking change?

[ ] Yes

Link to aspire-docs issue (please use this breaking-change template):

[ ] No

Link to aspire-docs issue (please use this doc-idea template):

[x] No

Microsoft Reviewers: Open in CodeFlow

Thanks folks!


How to set context variable on render within a component

Description:
Is there way to set a context variable without having a context object from an event beforehand? For example, how can we set the .key values in this example?
Rationale
I need to set values within a component on user interaction which has no way to trigger a ractive event on at that time (it uses a jQuery stuff under the hood).

...like in this workaround, without using the curr="{{.}}" attribute...

Your best bet would probably be to map in the whole test object or map in the key too and set the key from there. If you don't mind some tight coupling and happen to have an element handy in the component template, you can get a little whacky by jumping contexts. You have to tell getParent that you want to ascend through the component boundary in order to land in the surrounding context.

You can also read the mapping with readLink, adjust the keypath, and use this.parent.set as seen here. Again... very tight coupling.

This seems not tightly coupled, is working (replaced getContext('button') with getContext('*')) and does what I wanted.
How can we use that ctx later?


MultiTerm Aggregations should support missing property

Elastic.Clients.Elasticsearch version:
8.0.3
Elasticsearch version:
8.5.2
.NET runtime version:
$ dotnet --version
7.0.100

Operating system version:
macOS Ventura 13.0.1 (22A400)
Description of the problem including expected versus actual behavior:
Consider the following:
GET /some_index/_search
{
  "query": {
    ... (doesn't matter)
  },
  "size": 0,
  "aggs": {
    "some_name": {
      "multi_terms": {
        "terms": [
          {
            "field": "some_field"
          },
          {
            "field": "another_field", "missing": "-"
          }
        ]
      }
    }
  }
}

It is possible, and desirable, to supply a value when the field is missing its value, so it can be included in the aggregation as very wisely the folks of the engine have provided (see docs)
It is not obvious to me how we can specify this using the 8.x client and using MultiTermLookup/MultiTermLookupDescriptor. It appears to only support Field.
Expected behavior
There should be a way to supply a missing property for each term, e.g. by adding a Missing property on MultiTermLookup.
I suspect there will be a challenge with the type of said Missing property (or it could be infered from the type of the Field). In my opinion, this is a challenge for strongly typed clients anyway since the bucket response looks like this:
{
  "key": [
    "life",
    42
  ],
  "key_as_string": "life|42",
  "doc_count": xx
},

I am not trying to get into how it should be implemented, but personally, I find multi_terms extremely useful so I will take anything as a stop-gap solution rather than not being able to it at all.

Thanks for highlighting this, @kleanthis. This is missing from the specification and therefore not generated. I have submitted a PR to address this and we'll be able to include it in a future release of the client.


[tab-panel] Add description to to block coents

I have no idea what I meant with this....

I totes remembered!

Do you recall what you meant in this issue? Is it anything that we already have docs for at https://developers.google.com/web/fundamentals/web-components ?

Yeah this can be closed now as we are not launching an independent site anymore.


Broadcast Addresses details

Within Commands.md some details about Broadcast Address creation and mean have been added just after the Type + Sub Type section

There's 16 broadcast addresses.
Those are only specific to Velux

There's 16 broadcast addresses.
Those are only specific to only 2W ON/OFF devices, like things with a little motor with returned Infos.
Good catch

I can't understand what you mean.
My analysis has been done on 1W Velux controllers and devices and, after implementing the 1W controller in sw, tested in real world and that's it.
For devices other than Velux, I cannot say anything.

As @Pascal66 said: The commands.md needs to be split cause there is way too much information in it.
My plan would be to keep the commands.md only really for the commands ids and copy information about parsing into another document including links between the two.

There's 16 broadcast addresses.
Those are only specific to only 2W ON/OFF devices, like things with a little motor with returned Infos.
Good catch

I can't understand what you mean. My analysis has been done on 1W Velux controllers and devices and, after implementing the 1W controller in sw, tested in real world and that's it. For devices other than Velux, I cannot say anything.

1W/2W is not only different in regards to the used encryption/auth method but also in the handling of the protocol itself:
As per iohc documentation every device has to have at least a basic stock of commands it needs to understand. Those correlate directly to RTS commands and is the reason you can use a simple Velux 1W remote (like KLI31x) with Somfy blinds. Same goes for 2W but it is always tied to a ManufacturerID which defines additional commands/data.


API conversion interface for LSTM, SimpleRNN

@fchollet Done

Can't seem to fix the conflict, should I start a fresh PR ?


Version 0.1.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/58610
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 49dbdd16b14e2fd1fbdf0a70d970ab61bddcb5ec
git push origin v0.1.0


Unnest fix regression with table and column not found

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

This is expected behavior with JOIN and CROSS JOIN having more precedence over COMMA JOIN. The tests will be rewritten to use CROSS JOIN instead of COMMA for unnest
-- non working (expected)
select * from
foo t1, unnest(mv_to_array(t1.dim3)) as u1(c1) CROSS JOIN foo t2

-- working with cross join
select * from
foo t1 CROSS JOIN  unnest(mv_to_array(t1.dim3)) as u1(c1) CROSS JOIN foo t2

-- working with ()
select * from
(select * from foo t1, unnest(mv_to_array(dim3)) as u1(c1))  CROSS JOIN foo t2


Provide more ways to interaction with Instant

Would be great to have the following to better integrate into code

Conversion to std::time::Instant
Conversion to tokio::time::Instant
Derefs?

async_time_mock_core::Instant
Do you mean you want to convert async_time_mock_core::Instant into std::time::Instant or tokio::time::Instant? https://github.com/communityvi/async-time-mock/blob/3f389d8f2b7db1bfad38effef1f2ba800829ff80/async-time-mock-core/src/instant.rs#L4-L8
If so, this is not possible because a mock instant is completely different from a real instant. You can't convert it from one to the other because the rate at which real time passes is decoupled from the rate that the test time passes.
What you can do is to take the duration between two instants and apply that to a real instant though.
async_time_mock_tokio::Instant
Or do you mean to get the instant out of something like async_time_mock_tokio::Instant?
https://github.com/communityvi/async-time-mock/blob/3f389d8f2b7db1bfad38effef1f2ba800829ff80/async-time-mock-tokio/src/instant.rs#L5-L10
You can match on it like so:
match my_instant {
    Real(instant) => Some(instant),
    _ => None,
}

But you obviously aren't guaranteed to get a real instant, because you can only get one if it is not mocked.
Implementing Deref is not possible for the same reason Option<T> doesn't implement Deref<T>: There may or may not be valid content, so you can't unconditionally provide a reference to it.
What I could do though is something like the following:
pub fn real(&self) -> Option<tokio::time::Instant> {
    match self {
        Real(instant) => Some(instant),
        _ => None,
    }
}

Then you could do something like:
if let Some(real_instant) = my_instant {
  // do something with it that only happens when time is not mocked
}

That's not too much different from doing the match manually as described above though.
Whether having code that behaves differently with real and mocked time is a good idea is a different question.

thanks for the detailed answer, managed to work around this actually. The one thing I was still missing is Instant::elapsed() which is a nice helper I often use, which I think should be possible.

The one thing I was still missing is Instant::elapsed() which is a nice helper I often use, which I think should be possible.

There's two ways elapsed could be implemented:

Storing a reference to the TimerRegistry in the instant. This doesn't sound like a good idea because that would make it impossible to derive Copy on it (so you would need .clone() everywhere, which makes it much harder to use)
Require a MockableClock parameter like fn elapsed(&self, &MockableClock) -> Duration

1 could be worked around by storing all timer registries in some kind of global registry, and refer to them by index, but I'd rather not do that.
2 is certainly feasible!

I will add elapsed once I find the time (which I'm not sure yet when that will be).

Instant::elapsed is now released in 0.1.0

thanks!


more details about every "DropReasons"

[Enter feedback here]
There are different type of DropReasons, would you please help to elaborate more for the listed reasons below?
"The keys include Protocol violation invalid TCP. syn Protocol violation invalid TCP, Protocol violation invalid UDP, UDP reflection, TCP rate limit exceeded, UDP rate limit exceeded, Destination limit exceeded, Other packet flood Rate limit exceeded, and Packet was forwarded to service. Protocol violation invalid drop reasons refer to malformed packets."
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0273ec84-6ca3-3b94-c1c9-fcf890047c7e
Version Independent ID: 26c56818-f119-727f-1690-f6c402f71503
Content: View Azure DDoS Protection logs in Log Analytics workspace
Content Source: articles/ddos-protection/ddos-view-diagnostic-logs.md
Service: ddos-protection
GitHub Login: @AbdullahBell
Microsoft Alias: abell

@GavinJin88
Thanks for your feedback! We have assigned the issue to author who will provide further updates.

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


cmake: do not enable TLS without threads

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d937c2e) 64.25% compared to head (b7c4ab5) 64.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   64.25%   64.23%   -0.03%
==========================================
  Files          17       17
  Lines        3321     3319       -2
  Branches     1123     1123
==========================================
- Hits         2134     2132       -2
  Misses        760      760
  Partials      427      427

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


update wording

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/5406

@Dansimp PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[AIRFLOW-2847] Remove legacy imports support for plugins for 2.0 deprecation.

[AIRFLOW-2847] Remove legacy imports support for plugins
This is a WIP since the tests on master aren't passing locally on my machine (5 out of 8 for ./run_unit_tests.sh  ./tests/plugins_manager.py pass), I'll drop the WIP if this passes CI.
Jira

[ X ] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ X ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Existing unit tests for plugins.

Commits

[ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ X ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@holdenk, we have been relying somewhat heavily on setting up Travis CI on our own forks to run the tests. I have not been able to run the tests locally in a while (but they require a decent amount of setup.)

Cool, I'm happy to know it's not just me or my env, I'll take a look at that docker JIRA later for tests. Going to rebase this on master since the 2.7 mysql failure in travis seemed unrelated since I didn't touch apt-geting krb

Codecov Report

Merging #3692 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
+ Coverage   77.56%   77.66%   +0.09%
==========================================
  Files         204      204
  Lines       15766    15737      -29
==========================================
- Hits        12229    12222       -7
+ Misses       3537     3515      -22

Impacted Files
Coverage Δ

airflow/hooks/__init__.py
100% <ø> (+41.17%)
:arrow_up:

airflow/operators/__init__.py
83.33% <ø> (+22.22%)
:arrow_up:

airflow/macros/__init__.py
100% <ø> (+18.51%)
:arrow_up:

airflow/sensors/__init__.py
81.81% <ø> (+22.99%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc64649...7031e25. Read the comment docs.

cc @tfeng if you have time to review?

cc @feng-tao  / @artwr / @yrqls21 or @aoen y'all seem to have worked on the related files recently if any of you have a chance to review I'd appreciate it :)

LGTM, thanks.

LGTM @holdenk , thanks for the fix. Could you close your jira once the pr is merged?


convert IError interface to methods

Mmh, the merge was a bit premature. Because the PR on the main repository is not finished.

My bad. 🥲

To prevent this type of thing in the future, it's best to add "Do not merge until  has been merged" comment.