grpc stubs missing types for metadata, compression, etc

Just trying out the grpc stub generation, as per #46.
It seems like the gRPC stubs don't have the native gRPC methods added.
For example from grpc .pyi:
def GetSomething(self,
    request: global___GetSomethingRequest,
) -> global___GetSomethingResponse: ...

However, the grpc .py:
@staticmethod
def GetSomething(request,
        target,
        options=(),
        channel_credentials=None,
        call_credentials=None,
        insecure=False,
        compression=None,
        wait_for_ready=None,
        timeout=None,
        metadata=None):

Not totally certain if I'm using it correctly, but when using the grpc.pyi files I am getting mypy errors like this, on code where it was definitely working:
Unexpected keyword argument "metadata" for "GetSomething" of "GetSomethingStub"

Would appreciate any insights you can offer.
Thank you!

Yep - sounds like a shortcoming.
grpc stubs were only added last month - w/ only the most basic usage to start.
@Evgenus worked on it and perhaps could comment. I'm not super duper familiar w/ the GRPC generated output.
We'd be happy to take a PR that adds appropriate typing for these extra kwargs w/ unit test showing that such kwargs are accepted at runtime.

@gitpushdashf @nipunn1313 I'll take a look.

Thank you! I appreciate it.

FWIW: https://github.com/dropbox/mypy-protobuf/pull/210

@gitpushdashf Hi. Finally, I found some time to investigate. Sorry for the delay.
You are mixing things a bit.
def GetSomething(self,
    request: global___GetSomethingRequest,
) -> global___GetSomethingResponse: ...

this one was for <ServiceName>Stub. Which is the interface of the client. And now/soon (in master) it looks like this:
    def __init__(self, channel):

        self.GetSomething = channel.unary_unary(
                '/<module>.<ServiceName>/GetSomething',
                request_serializer=<module>.GetSomethingRequest.SerializeToString,
                response_deserializer=<module>.GetSomethingResponse.FromString,
                )

The other part you've mentioned is the implementation of different API.
@staticmethod
def GetSomething(request,
        target,
        options=(),
        channel_credentials=None,
        call_credentials=None,
        insecure=False,
        compression=None,
        wait_for_ready=None,
        timeout=None,
        metadata=None):

Take a look at generated *_grpc.py file. You have inside 3 classes: client API - *Stub, server API - *Servicer, and some other API marked as experimental. Indeed the last one is not yet supported. My question, are you really using it? Is it still experimental or mature enough for production?

Thank you for looking into this! I think I mistakenly forgot to note that GetSomething is part of the service stub.
This is how we've been doing things in production, although about to merge the latest mypy-protobuf updates where we had to # type: ignore those lines.
You can see here that UnaryUnaryMultiCallable has request, timeout, metadata, etc: https://grpc.github.io/grpc/python/grpc.html#grpc.UnaryUnaryMultiCallable
While request seems to be handled in the .pyi, metadata is not.
I hope this makes sense. I am definitely not a gRPC expert.

@gitpushdashf What you are asking for is already in master, just not in a release yet. As @Evgenus said, the gRPC stub methods are now annotated with the MultiCallable interface in master, due to the PR I linked above. You should be able to verify that you can get rid of your # type: ignore comments if you install the latest master.
@Evgenuswhen do you know when we would be likely to see a 2.4.1 or 2.5 cut? I'm not sure on your release cadence or process, just would like to use this soon 😄

Ah, I understand. Thank you!

I'll do a release at some point in the next couple of weeks! Just gotta do some additional testing.
In the meantime, you can install unreleased version (instructions are available in the README on the main page)

Hi all and thanks for a great plugin.
I'm not sure if this is related or not. But I don't get the typings for request and context in the server API  (*Servicer). although it looks right in *_grpc.pyi
class RouteGuideServicer(metaclass=abc.ABCMeta):
    @abc.abstractmethod
    def GetFeature(self,
        request: global___Point,
        context: grpc.ServicerContext,
    ) -> global___Feature: ...

I might be mistaken but shouldn't I get code completion for e.g. request when implementing RouteGuideServicer.GetFeature? I use vscode btw. (pylance). Mypy passes....

I'm not familiar with vscode/pylance/pyright with regard to this grpc plugin - you're welcome to debug further and report back with any findings.

Fair! I'm not really sure where to get started but I'll try.
But maybe you can answer a more general question; is it possible to get code completion / suggestions for request etc.?

Sounds like you want some kind of code autocompletion?
Unfortunately, don't really have context on that. mypy-protobuf provides type stubs - autocompletion is a separate system entirely. I know that the pyright maintainer has perused through here in the past - but perhaps if you are using pyright you can follow up over there.

https://stackoverflow.com/questions/53578365/does-vscode-support-python-pyi-files-for-intellisense
I think you can start with that.
I, personally, stopped using VSC in favor of PyCharm. But I remember that I was not happy with auto-completion as well.

I looked through this.
Generated stubs for DummyService are here
https://github.com/dropbox/mypy-protobuf/blob/master/test/generated/testproto/grpc/dummy_pb2_grpc.pyi.expected
It contains DummyServiceStub, and DummyServiceServicer, but not DummyService
DummyService is generated like this:
 # This class is part of an EXPERIMENTAL API.
class DummyService(object):

As @Evgenus mentioned, it's not mentioned in the docs
https://grpc.io/docs/languages/python/generated-code/
For now, I'm going to close this. I'm open to typing undocumented things - but only if we're working with someone with some inside roadmap knowledge of GRPC. For now, I will close this.


Font FOUC

Text should not display until the font file is loaded. Also, cache it with the offline plugin.

Will be resolve with #5


Fixed spelling mistake in LineNumberRemoved

which -> with

But please merge it with the lastest verison

I think that should've done it


Tweak profiles

improve whitespace consistency
handle a bunch of rough edges

duplicate session config to the target namespace (if different from release namespace)
change debug logging to off by default
ensure launcher / target namespace is passed properly to the launcher (when different)
fix profiles / overrides handling of defaults (i.e. mount session configmap by default)
add rbac that is needed for the sidecar container (when launching sessions into a different namespace)
change default value for session-callback-address (and set programmatically)
remove the launcher service - it does not work with a single set of pods because readiness probes cannot support multiple services (probably by design). So we will remove it for now

@jonyoder RSW can work without the launcher, but I am talking about the "Kubernetes Service." It's not exactly usable (per message on slack), so I am of the opinion that we should remove it and just route to the launcher over loopback


For the xlab sampler latent input cant we use the VAE Encode ?

when using it I get the following error
got prompt
!!! Exception during processing !!!  Error while processing rearrange-reduction pattern "b c (h ph) (w pw) -> b (h w) (c ph pw)".
 Input tensor shape: torch.Size([1, 16, 183, 122]). Additional info: {'ph': 2, 'pw': 2}.
 Shape mismatch, can't divide axis of length 183 in chunks of 2
Traceback (most recent call last):
  File "/home/usr_9110799_ulta_com/.pyenv/versions/3.10.6/envs/venv/lib/python3.10/site-packages/einops/einops.py", line 523, in reduce
    return _apply_recipe(
  File "/home/usr_9110799_ulta_com/.pyenv/versions/3.10.6/envs/venv/lib/python3.10/site-packages/einops/einops.py", line 234, in _apply_recipe
    init_shapes, axes_reordering, reduced_axes, added_axes, final_shapes, n_axes_w_added = _reconstruct_from_shape(
  File "/home/usr_9110799_ulta_com/.pyenv/versions/3.10.6/envs/venv/lib/python3.10/site-packages/einops/einops.py", line 187, in _reconstruct_from_shape_uncached
    raise EinopsError(f"Shape mismatch, can't divide axis of length {length} in chunks of {known_product}")
einops.EinopsError: Shape mismatch, can't divide axis of length 183 in chunks of 2

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/usr_9110799_ulta_com/ComfyUI/execution.py", line 316, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
  File "/home/usr_9110799_ulta_com/ComfyUI/execution.py", line 191, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
  File "/home/usr_9110799_ulta_com/ComfyUI/execution.py", line 168, in _map_node_over_list
    process_inputs(input_dict, i)
  File "/home/usr_9110799_ulta_com/ComfyUI/execution.py", line 157, in process_inputs
    results.append(getattr(obj, func)(**inputs))
  File "/home/usr_9110799_ulta_com/ComfyUI/custom_nodes/x-flux-comfyui/nodes.py", line 368, in sampling
    x = denoise_controlnet(
  File "/home/usr_9110799_ulta_com/ComfyUI/custom_nodes/x-flux-comfyui/sampling.py", line 250, in denoise_controlnet
    orig_image = rearrange(orig_image, "b c (h ph) (w pw) -> b (h w) (c ph pw)", ph=2, pw=2).to(img.device, dtype = img.dtype)
  File "/home/usr_9110799_ulta_com/.pyenv/versions/3.10.6/envs/venv/lib/python3.10/site-packages/einops/einops.py", line 591, in rearrange
    return reduce(tensor, pattern, reduction="rearrange", **axes_lengths)
  File "/home/usr_9110799_ulta_com/.pyenv/versions/3.10.6/envs/venv/lib/python3.10/site-packages/einops/einops.py", line 533, in reduce
    raise EinopsError(message + "\n {}".format(e))
einops.EinopsError:  Error while processing rearrange-reduction pattern "b c (h ph) (w pw) -> b (h w) (c ph pw)".
 Input tensor shape: torch.Size([1, 16, 183, 122]). Additional info: {'ph': 2, 'pw': 2}.
 Shape mismatch, can't divide axis of length 183 in chunks of 2

I was using a different resolution, need to use 1024x1024


esm upgrade trial

Hi,
I tried to upgrade the package to ESM compatible version. The code is still buggy. Maybe you can clean it

See comments in the issue that corresponds to this PR.


Move Conan package to conan-center

Hello.
Thank you for your library and for Conan package.
But user should add your repo to remotes. Can you move the package to conan-center repo?

Adding packages to conan-center requires a review process before a package is accepted:
http://docs.conan.io/en/latest/packaging/bintray/conan_center_guide.html
It's probably a good idea to wait until the library is more mature before submitting, considering currently it's very new.

added to conan-center:
https://conan.io/center/deco
https://github.com/conan-io/conan-center-index/pull/9818


Formatting check in CI is broken

The bin/check-formatting.sh currently expects a path relative to bin (or absolute), but it's called in CI with paths relative to the repo root. So no checks are run. Since currently not finding a file doesn't cause a non-zero exit code, the checks still pass.

A fix for the issue is here: https://github.com/exercism/cpp/pull/835

However, there's another issue in the check of all files never happens. It is supposed to be run for each commit on main. However, since the if in the workflow checks for a branch named master, this never becomes true (it's called main). Fixing that is trivial of course, but we should probably also re-format all files in the same PR.
I can certainly do that. Just let me know. There will be a few hundred files that need reformatting.

I can certainly do that. Just let me know. There will be a few hundred files that need reformatting.

Please go forward, this is very good for the code base.
Do you know if we could easily check the correct formatting for the code blocks in the .md files?

I can certainly do that. Just let me know. There will be a few hundred files that need reformatting.

Please go forward, this is very good for the code base.

Alright, I can do that. However, that should come after the check is in place. So could you have a look at #835 please? That fixes the script and will make sure that future PRs are properly formatted.
Fixing the check that runs for each commit on main and reformatting existing files I would do in a follow-up PR.

Do you know if we could easily check the correct formatting for the code blocks in the .md files?

I haven't done this yet, but clang-format-docs looks promising. I have just run it on a random concepts/headers/introduction.md and it looks like it's working properly. Running the formatting on .md files and putting a CI check in place I would also do in a follow-up PR then.
Instead of extending the existing script or adding another custom script to do this, would you be open to use pre-commit for this? I have had quite positive experiences with this in other projects. Although it was meant to be run as a Git hook originally, you don't have to use it like that. The current workflow can stay in place, but instead of a custom script, you would run pre-commit run locally to run the reformatting tool(s).

Pre commits only work, if all people who make a PR actually use them, right? I am not against this, but I would argue that we have to have correct files even if the PR is from someone who does not check with a pre-commit hook before they send it in.

Pre commits only work, if all people who make a PR actually use them, right? I am not against this, but I would argue that we have to have correct files even if the PR is from someone who does not check with a pre-commit hook before they send it in.

No, you don't have to use it as a Git hook. That's how it started out and hence the name. But I personally don't use it like that in any project. Instead, I trigger it manually by running pre-commit run. That then runs whatever is configured. To replicate the current configuration of this project, we would only have clang-format. But clang-format-docs could be easily added and would then run as well. pre-commit run returns a non-zero exit code in case it made any changes. That is what would be used in CI, so that all configured checks are also part of a CI run. So no matter what people use locally to create PRs, we would have all checks in place. The big upside is that pre-commit is a widely used project, so the probability of things not really working (as has happened now with the custom script) is really low.
You know what, let me put together a PR today or tomorrow to show you how it would look like.

Alright, so I put it up for my fork and it seems to be working fine. The commit messages would need some cleanup, but everything is there to get the idea.
The PR is here. pre-commit is configured via .pre-commit-config.yaml. In addition to the clang-format check, there are a few standard checks. Those are not mandatory, but don't hurt either, so I kept them in. So this config plus the pre-commit command is all you need. Install pre-commit locally and you're good to go. My typical workflow is running pre-commit run --all locally. Without the --all it only looks at the current commit, so that's what would be used in a Git hook (via pre-commit install you can locally create the hook, but that's optional).
For the CI setup I created an extra workflow. That just uses the pre-commit action. I noticed in the meantime that it always runs with --all, so that special handling of PR vs main is not necessary and should be removed. If you want to see a CI run where the check fails, here is an example.


Implement class gui::views::View (cpp)

Views are the base core for every GUI item that is displayed in a frame.

Completed; Compiles; Still t obe tested.


Fix tables and lists in reference items

I was looking into making a custom build of the site to show shader hooks docs on for people testing out the feature before it's merged and deployed.
I noticed a few little styling issues in reference pages:

Lists don't have numbers or bullets
Table cells aren't aligned to the top

This addresses those issues:

Thanks @davepagurek!


Consider removing the docker command and it's subcommnads

Polytracker's docker command adds the external dependencies, maintenance weight and arguably adds very little utility compared to using bare docker CLI commands. Maybe we should get rid of the polytracker docker command. Opinions welcome!

Another alternative is to create a separate repository (e.g. polytracker-utils) for helper and convenience commands we don't really want to commit to maintain to the same degree as the core ones.


orientation and ordering in get_fragment

The get_fragment() fn has been working nicely for fractal fragment filtering for a while. It has two issues:

(a) the returned mol always has real frags first, followed by ghosted frags. so if enough things match, get_fragment(1, 0) and be the same mol (down to atom ordering) as get_fragment(0, 1). this will surprise users of psi4.Molecule.extract_subsets() who expect fragment ordering to be preserved. The latter behavior is being implemented in #74.

(b) the current fn comes with an orient=False default. But that's not getting passed through to anywhere, so probably default False is imposed. Easy to pass this flag along but probably should be careful of downstream.

(a) is now fixed by #74
(b) two days after opening issue when reexamined without fever, I couldn't see the problem. as that wasn't the only mistake I made that day, was probably just muddled.


cmake(bugfix):fix ymodem cmake typo error and sotest build error

Summary

fix ymodem typo
implement cmake sotest when kernel build does not support yet

Impact
CMake: ymodem and sotest fixes.
Testing
CI test

[Experimental Bot, please feedback here]
No.  The PR description lacks crucial details required by the NuttX guidelines.
Here's why:

Summary: While it mentions a typo fix and CMake implementation, it doesn't explain what the typo was or how the CMake implementation works.  It needs more context. What part of ymodem had a typo?  What exactly does "when kernel build does not support yet" mean? Which kernels are affected?
Impact:  Simply saying "No" is insufficient.  Each impact item (user, build, hardware, documentation, security, compatibility) needs to be addressed individually with "NO" or "YES" followed by an explanation if "YES." Even if there's no impact, explicitly stating "NO" for each item demonstrates that the contributor considered the potential impacts.
Testing:  "CI test" is too vague.  The guidelines require specific details about the build host and target environment(s) used for testing.  Additionally, providing "before" and "after" logs, even if they seem trivial for a typo fix, is essential for demonstrating the change's effect.  Which CI test?  What platform is it running on?

In short, the PR author needs to provide substantially more information to meet the NuttX requirements.

Hmm
====================================================================================
Configuration/Tool: omnibusf4/nsh,CONFIG_ARM_TOOLCHAIN_CLANG
2024-11-02 18:32:08
------------------------------------------------------------------------------------
  Cleaning...
  Configuring...
  Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
  Enabling CONFIG_ARM_TOOLCHAIN_CLANG
  Building NuttX...
Error: mtd/sector512.c:554:19: error: incomplete definition of type 'struct partition_info_s'
  554 |               info->numsectors  = priv->neblocks * priv->stdperblock;
      |               ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
  550 |           FAR struct partition_info_s *info =
      |                      ^
Error: mtd/sector512.c:555:19: error: incomplete definition of type 'struct partition_info_s'
  555 |               info->sectorsize  = SECTOR_512;
      |               ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
  550 |           FAR struct partition_info_s *info =
      |                      ^
Error: mtd/sector512.c:556:19: error: incomplete definition of type 'struct partition_info_s'
  556 |               info->startsector = 0;
      |               ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
  550 |           FAR struct partition_info_s *info =
      |                      ^
Error: mtd/sector512.c:557:19: error: incomplete definition of type 'struct partition_info_s'
  557 |               info->parent[0]   = '\0';
      |               ~~~~^
mtd/sector512.c:550:22: note: forward declaration of 'struct partition_info_s'
  550 |           FAR struct partition_info_s *info =
      |                      ^
4 errors generated.
make[1]: *** [Makefile:107: sector512.o] Error 1
Error: video/max7456.c:772:7: error: call to undeclared function 'up_udelay'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  772 |       up_udelay(100);
      |       ^
Error: video/max7456.c:805:7: error: call to undeclared function 'up_udelay'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  805 |       up_udelay(10);
      |       ^
2 errors generated.
make[1]: *** [Makefile:107: max7456.o] Error 1
make[1]: Target 'libdrivers.a' not remade because of errors.
make: *** [tools/LibTargets.mk:107: drivers/libdrivers.a] Error 2
Warning: chip/stm32_gpio.c:41:11: warning: CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py [-W#pragma-messages]
   41 | #  pragma message "CONFIG_STM32_USE_LEGACY_PINMAP will be deprecated migrate board.h see tools/stm32_pinmap_tool.py"
      |           ^
1 warning generated.
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
  Normalize omnibusf4/nsh
====================================================================================

Fix here: https://github.com/apache/nuttx/pull/14609


Update Zoloto to 0.6.0

As Zoloto 0.5.2 also includes inline type stubs :tada:, we can remove our stubs at last!
However, we need to install Zoloto in CI, and Zoloto does not support Python 3.8.
This is heavily related to https://github.com/j5api/j5/issues/402

PR made upstream https://github.com/RealOrangeOne/zoloto/pull/163

@RealOrangeOne Do we have a timescale for adding 3.8 support upstream? It feels quite out of scope for this issue to keep implementing the changes needed to support new major versions of Zoloto. Also gets annoying as it diverges further from j5 master.

@trickeydan undefined, but I might get a chance to look into it further over the weekend. The main blocker is the CV update

Closing for now to remove branch on main repo. See #571


Go not running on i386 hardware without SSE

Here's my original bug report for OpenBSD: https://marc.info/?l=openbsd-ports&m=157376594916571&w=2
In a later post, I was able to get more debugging info, which suggests that Go is refusing to run due to lack of an SSE(?) instruction on my processor: https://marc.info/?l=openbsd-ports&m=157384045312953&w=2.
It looks like the devs set GO386=387 on the build machines, but I think this might only be to disable SSE2 (the new package is still failing to run on my hardware)? https://marc.info/?l=openbsd-ports&m=157411444311030&w=2
Does anyone have any insight into what I can do to debug further or assist?

GO386=387 is required to run on 386 machines without SSE. Otherwise, the compiler will use SSE instructions.
See https://github.com/golang/go/wiki/MinimumRequirements#386

I'm still seeing the same behavior when GO386=387.

This is what is happening (even when using GO386=387):
Dump of assembler code for function runtime.check:
0x0807fbc0 <+0>:     mov    %gs:0xfffffffc,%ecx
0x0807fbc7 <+7>:     cmp    0x8(%ecx),%esp
0x0807fbca <+10>:    jbe    0x807ff3b <runtime.check+891>
0x0807fbd0 <+16>:    sub    $0x2c,%esp
0x0807fbd3 <+19>:    movl   $0x0,0x20(%esp)
=> 0x0807fbdb <+27>:    xorps  %xmm0,%xmm0

The error you're seeing is from the go binary. The distribution itself needs to be built with GO386=387. We don't provide such a distribution on our website.
Probably the easiest way to do get such a special distribution is to download the Go source distribution to a normal (SSE-capable, 32 or 64-bit) machine, then do
   cd go/src
   GOARCH=386 GO386=387 ./make.bash

Then copy the distribution directory to the SSE-crippled machine. Then build the binaries you want also with GOARCH=386 GO386=387.
Or you could just cross-compile every binary you want from a SSE-capable machine, using the standard distribution.

We are currently building with GO386=387. From the documentation, it appears that this only disables SSE2, and not SSE instructions. The documentation is a little unclear, but would setting GO386=386 disable SSE? The processor is an AMD Geode LX, which is fairly recent in terms of the embedded world.

There is no GO386=386. 387 and sse2 are the only options.
The function runtime.check is generated by the compiler. The compiler should not use any sse instructions if GO386=387.
When I build with those flags, I get code that looks 387-correct.
$ GOARCH=386 GO386=387 go build hello.go
$ objdump -d hello | grep -A20 'runtime.check>:'
08082210 <runtime.check>:
 8082210:	65 8b 0d 00 00 00 00 	mov    %gs:0x0,%ecx
 8082217:	8b 89 fc ff ff ff    	mov    -0x4(%ecx),%ecx
 808221d:	3b 61 08             	cmp    0x8(%ecx),%esp
 8082220:	0f 86 84 03 00 00    	jbe    80825aa <runtime.check+0x39a>
 8082226:	83 ec 34             	sub    $0x34,%esp
 8082229:	c7 44 24 20 00 00 00 	movl   $0x0,0x20(%esp)
 8082230:	00
 8082231:	d9 ee                	fldz
 8082233:	d9 c0                	fld    %st(0)
 8082235:	d9 5c 24 1c          	fstps  0x1c(%esp)
 8082239:	d9 ee                	fldz
 808223b:	dd d9                	fstp   %st(1)
 808223d:	d9 c0                	fld    %st(0)
 808223f:	dd 5c 24 24          	fstpl  0x24(%esp)
 8082243:	c7 44 24 18 00 00 00 	movl   $0x0,0x18(%esp)
 808224a:	00
 808224b:	c7 04 24 31 ce 57 4b 	movl   $0x4b57ce31,(%esp)
 8082252:	c7 44 24 04 3a 0b 00 	movl   $0xb3a,0x4(%esp)
 8082259:	00
 808225a:	c7 44 24 08 00 ca 9a 	movl   $0x3b9aca00,0x8(%esp)

Thank you - I'll pass this along to the ports maintainers. They had informed me that the latest packages were built with GO386=387.
I appreciate your time looking at this for me!

@ianlancetaylor I'm not sure I understand -- the latest i386 release of golang still appears to require SSE instructions, so I don't understand how this issue is closed.
There seemed to be an indication that this was going to be fixed:

Thank you - I'll pass this along to the ports maintainers. They had informed me that the latest packages were built with GO386=387.

I was asking for an update to see if that had been done.
Thanks!

@cellularmitosis The "ports maintainers" from the comment above are the OpenBSD port maintainers.  I don't know what they have done.
The Go project does not provide any 386 binary releases.

@ianlancetaylor Thanks, sorry for my confusion.


Erroring out upon encounter of malformed local folder for browser

OperaGXError.txt
This error pertains to OperaGX specifically, but there is no reason this could not occur elsewhere. When the logic checks to see if the browser exists, it appears to implicitly act as though the Extensions folder exists. Better error handling needs to be implemented to prevent hard crashes here

This should be fixed


[Feature Request] Split and truncate trajectories

Motivation
For sequence models/recurrent RL, we often want a long sequence to be split and padded into equal-sized segments of shape (batch, segment_length). split_trajectories handles the padding, but does not account for splitting long sequences (i.e. sequence length > segment length should be split into multiple segments). I propose that I add such a method to tensordict.
Solution
We can do something like
# Note this is untested and likely incorrect, but you get the idea
def truncate_trajectories(td, segment_length, mask_key=('collector', 'mask'), traj_id_key=('collector', 'traj_ids')):
    if traj_id_key is not None:
        del td[traj_id_key]
    lengths = td[mask_key].sum(dim=1)
    truncated_lengths = lengths % segment_length
    num_segments = torch.sum(lengths // segment_length)
    batch_index = torch.repeat_interleave(torch.arange(num_segments), truncated_lengths)
    time_index = torch.arange(segment_length).repeat(num_segments)
    indices = torch.stack([batch_index, time_index], dim=0)

    for k, v in list(tensordict.items()):
        td[k] = torch.zeros_like(v, shape=(num_segments, segment_length, *v.shape[2:])).scatter_(
            dim=0, index=indices, src=v,
        )

    return td

The usage would be something like
td = split_trajectories(td)
td = truncate_trajectories(td)

Alternatives
We could also add a max_segment_length arguments to split_trajectories and do this sort of logic within split_trajectories.
Additional context
Add any other context or screenshots about the feature request here.
Checklist

[x] I have checked that there is no similar issue in the repo (required)

We have a transform for that I think
https://pytorch.org/rl/reference/generated/torchrl.envs.transforms.RandomCropTensorDict.html#torchrl.envs.transforms.RandomCropTensorDict
Is what you want different?

If I am understanding this correctly, RandomCropTensorDict would just discard anything outside of the window, right? Instead of discarding, I would like the remainder of a sequence to occupy a new row in a B x T matrix.


Auto-GTAP doesn't run when cloned onto new computer

I'm trying to run Auto-GTAP on my computer, specifically the productivity-increase-simple example, but can't get it to work. Following the instructions in the readme, I:

cloned the current version of the project (latest commit is 6d7ba90)
set the python interpreter to use Python 3.6
installed PyYAML 4.2b4
set source root to src as shown in #10
set working directory to examples\productivity-increase-simple
ran Main.py

The script raises an error upon running:
Traceback (most recent call last):
  File "C:/Users/robir/PycharmProjects/Auto-GTAP/Main.py", line 5, in <module>
    config = Ag.CreateConfig("config.yaml")
  File "C:\Users\robir\PycharmProjects\Auto-GTAP\src\AutoGTAP\CreateConfig\CreateConfig.py", line 14, in __init__
    with open(yaml_file_location, 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'config.yaml'

Process finished with exit code 1

(I see there is a file called config.yaml in examples\productivity-increase-simple; not sure if this is the config file that is not being found?)

I will take a look. See https://barbelabs.atlassian.net/jira/software/projects/PG/boards/1

That is indeed the config file that should be found. Line 14 of "CreateConfig.py" is trying to open that file as read. It's not finding it on your system for some reason.
Why don't you take a look at some of the values of variables like "yaml_file_location" and see what might be the problem? If the working directory is what you say, then it should be able to load then the "open" function should be able to find config.yaml in that directory.


python310Packages.zha-quirks: 0.0.97 -> 0.0.98

Diff: https://github.com/zigpy/zha-device-handlers/compare/refs/tags/0.0.97...0.0.98
Changelog: https://github.com/zigpy/zha-device-handlers/releases/tag/0.0.98
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 228666 run on x86_64-linux 1

10 packages built:

home-assistant-component-tests.hassio
home-assistant-component-tests.homeassistant_hardware
home-assistant-component-tests.homeassistant_sky_connect
home-assistant-component-tests.homeassistant_yellow
home-assistant-component-tests.otbr
home-assistant-component-tests.zha
python310Packages.zha-quirks
python310Packages.zha-quirks.dist
python311Packages.zha-quirks
python311Packages.zha-quirks.dist


Can not found key on Windows

The extension can not get the gpg key on Windows. The debug output is following:
Active GPG Indicator extension ...
Setting: sync status interval: 30
Create key status manager
Update folder information
Change folder to /e:/workspace/cpp/HitagiEngine
Got one update function
Can not found key for folder: /e:/workspace/cpp/HitagiEngine

Note that there is a slash / at the beginning of the workspace path. When using this format, the function exec may throw an exception because URI.path is not a valid file path format on Windows.
A solution might be to change uri.path to uri.fsPath.
uri.paht   --->  /e:/workspace/cpp/HitagiEngine
uri.fsPath --->  e:\\workspace\\cpp\\HitagiEngine

https://github.com/wdhongtw/vscode-gpg-indicator/blob/b051dd8c32da4a81fc6315dba6fe3126bcdb1ae5/src/extension.ts#L15-L17
https://github.com/wdhongtw/vscode-gpg-indicator/blob/b051dd8c32da4a81fc6315dba6fe3126bcdb1ae5/src/indicator/git.ts#L28-L33

Hi @L-Sun, although it only requires one line modification, feel free to submit MR if you want some credit. :D
I guess I'll release new version next weekend.


Clarify what is meant by 'full legal name'

"Full legal name" doesn’t seem to have a clear and unambiguous meaning (for instance it implies that everyone has a single legal name, when they may use both a married and maiden name in different contexts).  Instead it may be better to refer to a name matching that used on government issued documents such as passports and driving licences.
It is also possibly to have an additional name noted on a passport in the observations page.
See:

Change your name by deed poll
Recording Changes of Forename(s) and Surname(s) in Scotland

Annex A: use of names in passports

You can preview this change here:
Built with commit c6a9950109a10d0772dea627be875b29079d5eaf
https://deploy-preview-805--govuk-design-system-preview.netlify.com

👏


Qt5/0.8.0: debian dependencies / QT5LIBDIR

add missing debian dependencies for

libqt5x11extras5-dev
qttools5-dev-tools

make use of QT5LIBDIR in all qmake files (I was assuming lrelease4 is for Qt4 on OpenBSD, but I'm not sure).

Looks good, thanks!


add continuity check for tile removement

check if all town tiles are still connected, when current tile is removed

idea: for each neighbor of removedtile: copy town tile map and remove removedtile as well as neigbor tile, then check if neighbor tile can be placed


Rails 5.2.0 support

@doliveirakn any feedback? Tests are passing with both rails versions, 4.2 and 5.2.

@fernandoluizao Sorry this fell of my plate. No this looks good. I will merge it and bump the gem.


Chart.js with Firebase

Hello everyone,
I'm currently trying to turn my =Firebase  into a chart with chart.js, and it works! but I only have a few complications and questions.
first one is is that when the data updates in the Firebase it does the whole animation from zero to the new value and not from the current value to the new value, is there a way to fix this?
And I also have a few questions about the layout, is there a way I could remove the whole Y and X-axis _(also the information numbers on the side and bottom) _
CodePen
I hope someone could help me. Thanks in advance!

Please ask questions on StackOverflow: https://stackoverflow.com/questions/tagged/chart.js


Investigate alternative docs publishing solutions

Pasting original discussion in https://github.com/reduxjs/redux/issues/3161:

I'm still not terribly happy with Gitbook as the solution for publishing our docs.

The good news is that the hosted version of Gitbook at least auto-publishes whenever we push to master, which is a vast improvement over the old docs publishing command we used to have to run manually.

However, there are several problems that still bother me:

There's no preview for docs changes in PRs
Even though the docs should basically be static pages, Gitbook has to do some page loading and shows a bunch of skeleton states
The nice "short anchor" links I'd manually added to the FAQ pages got broken in the switch to the new version of Gitbook, and we've never been able to fix them properly
Embedding live CodeSandbox examples doesn't seem to work right

I would like someone to investigate switching our docs to be built with some other static site generation solution, such as Docusaurus, Gatsby, or React-Static.  I have no particular preference myself, although it would be nice on general principle if the solution was something React-based or similar.

The one thing that the hosted version of Gitbook seems to give us that's neat is the "did this help?" rating at the bottom of each page, but to be honest I don't think we've ever made any actual use of that information.

The content itself is also hosted/published on Gitbook's infrastructure, but there's obviously plenty of other options out there (Netlify being the biggest one, and I think that's the main React docs at https://github.com/reactjs/reactjs.org use - someone confirm?).

Our content is all Markdown already, so I would think it wouldn't be too hard to set up some alternative static site generator tool and start using the docs as the source.

Also, it would be beneficial if there was a good way to publish versioned docs, since we would likely want to use the same solution for React-Redux as well.  In fact, perhaps React-Redux would make a better test case, since we don't even have its docs as a published site yet.

One other thought: when we do revamp the main Redux docs content, I would want to start moving around a bunch of our pages - recategorizing existing pages, as well as merging/changing others.  It would be really beneficial if there's a good redirect solution as part of this.  For example, if "Immutable Update Patterns" got moved from /structuring-reducers/immutableupdatepatterns to, say, /reducers/immutable-update-patterns, then I'd want to have a redirect in place so that external links don't break.

Thoughts? Volunteers?

Since I'm suggesting we start with React-Redux, here's a separate issue to track that.
I'm in the process of trying to get the react-redux.js.org domain name, which I'd like to point to Netlify.  I've set up an initial Netlify hosting at https://react-redux-docs.netlify.com (looks like react-redux.netlify.com is already taken with a broken app of some kind).
I guess the first step is to get some kind of actual published content up so that I can justify the .js.org domain name request.

I guess we need some sort of logo for react-redux aswell?

Eh, logos can be handled separately :)
I just hand-published the "Getting Started" docs page, which is now viewable at https://react-redux-docs.netlify.com/ .  I've gone ahead and made the PR requesting https://react-redux.js.org based on that.

And we've got the initial Docusaurus setup merged in #1031 , and I've updated the Netlify settings to build and deploy that.  We are LIVE at https://react-redux-docs.netlify.com !
Meanwhile, still waiting on the domain name PR to get merged .

Aaaand the DNS request just got merged!
https://react-redux.js.org/

Okay, I think we're going to go with Docusaurus at this point unless someone A) throws together a Gatsby (or other) example, and B) shows it works better.
I'd like to see some experimentation with CodeSandbox embeds next.

Also, I've turned on both Netlify deploy previews for PRs, and (hopefully) a bot that will add the preview link in a comment for visibility.


vnvc

add vnvc.edu.vn

@hotrantien First stage of verification passed, official domain is vnvc.edu.vn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@hotrantien Please provide us with an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course. Thank you.

@hotrantien You might miss my previous comment. Please react.

@hotrantien I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


How can I use config to change the variable start and end string

Not so clear, I have not read the source code but from doco and vscode completeion there seems none.
Basically in the below, I can customise the config, but how I set it in the template ?
If it is impossible then the config should be marked as private.
I also tried v1.5.3 while I can produce compile code but when run it does not take effect.
// v2 code
func main() {
	cfg := config.Config{
		VariableStartString: "{$",
		VariableEndString:   "$}",
	}

	tpl, err := gonja.FromString("Hello, {{ name }}!")
	if err != nil {
		panic(err)
	}
	data := exec.NewContext(map[string]interface{}{"name": "World"})

	output, err := tpl.ExecuteToString(data)
	if err != nil {
		panic(err)
	}
	fmt.Println(output)
}

v1 code below but it does not work
func main() {
	cfg := config.Config{
		Debug:               true,
		VariableStartString: "{$",
		VariableEndString:   "$}",
	}

	env := gonja.NewEnvironment(&cfg, gonja.DefaultLoader)

	tpl, err := env.FromString("Hello, {$ name $}!")
	if err != nil {
		panic(err)
	}
	context := map[string]interface{}{"name": "World"}
	output, err := tpl.Execute(context)
	if err != nil {
		panic(err)
	}
	fmt.Println(output)
}

pls help.
cheers

Also it would be good to give examples of how to create custom filter for example.

Further reading I tried code like this but then the lexer does nto like it
package main

import (
	"bytes"
	"crypto/sha256"
	"fmt"
	"os"

	"github.com/nikolalohinski/gonja/v2"
	"github.com/nikolalohinski/gonja/v2/config"
	"github.com/nikolalohinski/gonja/v2/exec"
	"github.com/nikolalohinski/gonja/v2/loaders"
)

func FromBytesWithConfig(source []byte, config *config.Config) (*exec.Template, error) {
	rootID := fmt.Sprintf("root-%s", string(sha256.New().Sum(source)))

	loader, err := loaders.NewFileSystemLoader("")
	if err != nil {
		return nil, err
	}
	shiftedLoader, err := loaders.NewShiftedLoader(rootID, bytes.NewReader(source), loader)
	if err != nil {
		return nil, err
	}
	return exec.NewTemplate(rootID, config, shiftedLoader, gonja.DefaultEnvironment)
}

func FromStringWithConfig(source string, config *config.Config) (*exec.Template, error) {
	return FromBytesWithConfig([]byte(source), config)
}

func main() {
	cfg := config.Config{
		VariableStartString: "{$",
		VariableEndString:   "$}",
	}

	tpl, err := FromStringWithConfig("Hello, {$ name $}!", &cfg)
	if err != nil {
		panic(err)
	}
	context := exec.NewContext(map[string]interface{}{"name": "World"})
	err = tpl.Execute(os.Stdout, context)
	if err != nil {
		panic(err)
	}
}

panic: runtime error: index out of range [-1]
goroutine 18 [running]:
github.com/nikolalohinski/gonja/v2/tokens.(*Lexer).lexComment(0xc000104e70)
/home/stevek/go/pkg/mod/github.com/nikolalohinski/gonja/v2@v2.2.3/tokens/lexer.go:275 +0x1e5
github.com/nikolalohinski/gonja/v2/tokens.(*Lexer).Run(...)
/home/stevek/go/pkg/mod/github.com/nikolalohinski/gonja/v2@v2.2.3/tokens/lexer.go:104
created by github.com/nikolalohinski/gonja/v2/tokens.Lex in goroutine 1
/home/stevek/go/pkg/mod/github.com/nikolalohinski/gonja/v2@v2.2.3/tokens/lexer.go:71 +0x59
exit status 2

Yeah just realize that I have to fill all of the Config and it works fine
I am thiking a better way to use it for end user ...

Hi @sunshine69 and than you for opening the issue.
First of all, as decribed in the general README (see this), I am not supporting the v1 of the library ; please use the migration notes if you need to switch frm v1 to v2.
Now , regarding your issues : I 100% agree with you that the docs could be made a bit clearer. Feel free to submit a PR to fix things and I'd be happy to review/merge it.
The TL;DR is that you can either:

rely on the defaults (obviously not what you want :wink: )
override the global config variable
redefine everything yourself

Here's an example of full config redefining https://github.com/NikolaLohinski/terraform-provider-jinja/blob/main/lib/render.go#L137
As of this writing, there's no helper function such as FromString or FromFile that allows using a custom configuration, but if you feel like there's a need for it, I'd be super happy to take a PR for it. Something like FromFileWithConfig as you suggested in your example would work perfectly.
Hope it helps and LMK if not,
Cheers

I implement something currently on my local lib, will try to find a proper place to put it. I also add regex_search (well it standard jinja2 so not sure if u are interested) - regex_replace and to_yaml, to_json filters.
If these filter are of valuable pls let me know I will create a PR. But I need to look more into how to add these unit tests required by you, currently it is just implementation.
Ta

Hi @sunshine69
Regarding custom filter, I would like to stick with regular filters available in native Python jinja.
The goal of this library is to provide a 1 to 1 mapping between go and Python for Jinja templates and adding extra logic in the filters would break that purpose.
If you need additional filters, you can easily import all of the custom filters and functions from the the terraform-provider-jinja/lib. There's quite a few including those you mentioned.
Hope it helps,
Cheers


Lots of errors on sane up and browsing localhost:4200 gives blank page

I setup a brand new Ubuntu 14.04 64 bit environment to try this out.  When I try to browse localhost:4200 I just see a blank screen.
A capture of the errors I get when I try to sane up is in: https://gist.github.com/stevenchanin/48f1a204bb27e715e6d5

yes, this is because the project was developed for a while and then I added the linter and the errors haven't yet been cleared. I also use es7 which confuses linters. It's non breaking.

Unfortunately, something is breaking for me. After doing the sane up if I try to hit localhost:4200 the page is totally blank.
The server isn't showing any logging in response to my GET against 4200. The page I see in my browser looks like:
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <title>Client</title>
    <meta name="description" content="">
    <meta name="viewport" content="width=device-width, initial-scale=1">

    <base href="/" />
<meta name="client/config/environment" content="%7B%22modulePrefix%22%3A%22client%22%2C%22podModulePrefix%22%3A%22client/pods%22%2C%22environment%22%3A%22development%22%2C%22baseURL%22%3A%22/%22%2C%22locationType%22%3A%22auto%22%2C%22EmberENV%22%3A%7B%22FEATURES%22%3A%7B%7D%7D%2C%22APP%22%3A%7B%22LOG_ACTIVE_GENERATION%22%3Atrue%2C%22LOG_VIEW_LOOKUPS%22%3Atrue%2C%22name%22%3A%22client%22%2C%22version%22%3A%220.0.0.cb763417%22%7D%2C%22contentSecurityPolicy%22%3A%7B%22default-src%22%3A%22%27self%27%20https%3A//maps.googleapis.com%22%2C%22font-src%22%3A%22*%22%2C%22connect-src%22%3A%22%27self%27%20https%3A//maps.googleapis.com%22%2C%22img-src%22%3A%22*%22%2C%22style-src%22%3A%22*%20%27unsafe-inline%27%22%2C%22frame-src%22%3A%22*%22%2C%22script-src%22%3A%22%27self%27%20%27unsafe-eval%27%20*.googleapis.com%20*.gstatic.com%22%2C%22media-src%22%3A%22%27self%27%22%7D%2C%22simple-auth%22%3A%7B%22authorizer%22%3A%22simple-auth-authorizer%3Aoauth2-bearer%22%7D%2C%22simple-auth-oauth2%22%3A%7B%22refreshAccessTokens%22%3Atrue%2C%22serverTokenEndpoint%22%3A%22/api/v1/auths/login%22%7D%2C%22contentSecurityPolicyHeader%22%3A%22Content-Security-Policy-Report-Only%22%2C%22flashMessageDefaults%22%3A%7B%22timeout%22%3A3000%2C%22priority%22%3A100%2C%22sticky%22%3Afalse%2C%22showProgress%22%3Afalse%2C%22type%22%3A%22info%22%2C%22types%22%3A%5B%22success%22%2C%22info%22%2C%22warning%22%2C%22danger%22%2C%22alert%22%2C%22secondary%22%5D%2C%22injectionFactories%22%3A%5B%22route%22%2C%22controller%22%2C%22view%22%2C%22component%22%5D%7D%2C%22exportApplicationGlobal%22%3Atrue%7D" />
<script src="/ember-cli-live-reload.js" type="text/javascript"></script>

    <link rel="stylesheet" href="assets/vendor.css">
    <link rel="stylesheet" href="assets/client.css">
    <script type="text/javascript" src="https://maps.googleapis.com/maps/api/js?v=3.exp&libraries=places"></script>

  </head>

  <body>

    <script type="text/javascript" charset="utf-8" src="runtime.js"> </script>
    <script src="assets/vendor.js"></script>
    <script src="assets/client.js"></script>

  </body>
</html>

The breaking changes should now be addressed.  If you're still having problems, please reopen.

It's still not working, but I get further now.
It went back in and did the following:
git pull
cd client
bower install
npm install
cd ../server
npm install
cd ..
sane up

now when I go to localhost:4200, I see the login page. If I client register, I see the registration page. However, trying to POST to either of these pages does not seem to do anything. After I submit, I'm left on the same page and no error is reported.
See https://gist.github.com/stevenchanin/c8402286e8d3b652b578/edit where I've copied what I see in the terminal and what I see in the browser console.

This is a new issue, will track it in https://github.com/mgenev/how-to-sane/issues/91.


Scrolling lag when scroll is commited

There is an issue that causes the scrolling effect to almost stop when another scroll is done.

I'm having the same issue on http://domstapleton.co.uk. The plugin works fine when you scroll the mousewheel once, but when you scroll it more than once, the previous scroll is interrupted.
The scrolling also becomes very slow when you get to the top of the page, as the steps seem to decrease exponentially.
Can someone help?

Still not fixed, I have no clue what could be causing it.

Oddly, it seems to be working perfectly on this page:
http://www.templatemonster.com/demo/53430.html
Must be something interfering with it.
On Wednesday, 3 June 2015, Bram Korsten<EMAIL_ADDRESS>wrote:

Still not fixed, I have no clue what could be causing it.
—
Reply to this email directly or view it on GitHub
https://github.com/simov/simplr-smoothscroll/issues/10#issuecomment-108520888
.

thats very weard indeed, can I ask you what other plugins or codes you are using, then I can check with my pages for simularities

Sure:

jQuery 2.1.4
jQuery UI
jQuery Viewport Checker 1.8.0
Lazy Load 1.9.5
fancyBox 2.1.5
autogrow

my website is only using jquery and jquery ui, so the other ones should not
be it.
Op 3 jun. 2015 23:47 schreef "Dom Stapleton"<EMAIL_ADDRESS>
Sure:

jQuery 2.1.4
jQuery UI
jQuery Viewport Checker 1.8.0
Lazy Load 1.9.5
fancyBox 2.1.5
autogrow

—
Reply to this email directly or view it on GitHub
https://github.com/simov/simplr-smoothscroll/issues/10#issuecomment-108625258
.

Scrolling with mouse lags and scrolling with touchpad is ultra sensitive.

For my site setting viewport = 0 rather then container.height() fixed the scroll exponentially slower at the end issue. I'm having touchpad issues, I suspect because "Stop" is not triggering, working on that now.


Fix documentation for every_n_epochs parameter of ModelCheckpoint

What does this PR do?
Fixes documentation on the every_n_epochs parameter in ModelCheckpoint. This incorrectly states that leaving the value as the default of None means that checkpoints are not saved.
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Do I need to do anything to get this merged? Looks like it's blocked on some test failures that look unrelated to this change, plus not having a linked issue, although from the PR template this shouldn't be required for a docs change.


[Feature][MasterServer] add cache for workGroup and schedule #6987

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #7161 (6745e02) into dev (ba2b2a6) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #7161      +/-   ##
============================================
- Coverage     40.30%   40.26%   -0.04%
- Complexity     3655     3656       +1
============================================
  Files           653      653
  Lines         26917    26942      +25
  Branches       3005     3010       +5
============================================
+ Hits          10848    10849       +1
- Misses        15044    15069      +25
+ Partials       1025     1024       -1

Impacted Files
Coverage Δ

.../dolphinscheduler/api/aspect/CacheEvictAspect.java
3.33% <0.00%> (-0.12%)
:arrow_down:

...pache/dolphinscheduler/common/enums/CacheType.java
0.00% <0.00%> (ø)

...eduler/server/master/processor/CacheProcessor.java
17.00% <0.00%> (-4.52%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
83.33% <0.00%> (+5.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2b2a6...6745e02. Read the comment docs.

relative issue: #6987


Extend Background on Multi-line Input

The lighter grey that serves as the background for your command-line input should have multi-line functionality:

Probably a related issue but putting in multiple multi-line inputs causes an overwrite of the next line:

True Story - OSX 10.11 Beta ( Not that this is going to be OS specific )

Fixed.


failed to fetch types after require

input require("os") and then press ., the plugin will output some error messages
[Error - 5:03:20 PM] Request textDocument/completion failed.
  Message: Request textDocument/completion failed with message: Cannot read property '0' of undefined
  Code: -32603

The crash should be fixed in https://github.com/teal-language/vscode-teal/commit/9154e2ba9b9b7ee713996ca5cc4b5603a0e6332f. With that said, the plugin still cannot resolve the type in this scenario... I think tl types needs to be modified to support this use-case.


Need to handle the case where a sync call is made on the channel's I/O thread

Because connecting returns a future, a common pattern you might try to use is to add a future listener waiting for the successful connect, and in that listener make a thrift call.
However, if you make a blocking thrift call, you will deadlock the netty I/O thread.
We should check this before starting blocking thrift calls, and throw an exception in this case.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.


Feature/861/131 fix sample 043

What this PR changes/adds

Fixed sample 04.3 that was broken (env variables should now be in UPPER_CASE; issue with ports/API Key configuration)
Used jdk-logger-monitor in the sample so that monitor logs are exported to java.util.logging, and from there captured by the App Insights agent if used
Fixed instructions for using Application Insights with the sample

Why it does that

Sample was broken
Need sample for App Insights

Further notes
See sample transaction at https://ms.portal.azure.com/#blade/AppInsightsExtension/DetailsV2Blade/ComponentId/{"SubscriptionId"%3A"9d236f09-93d9-4f41-88a6-20201a6a1abc"%2C"ResourceGroup"%3A"algattik-appinsights"%2C"Name"%3A"algattik-appinsights"%2C"LinkedApplicationType"%3A0%2C"ResourceId"%3A"%252Fsubscriptions%252F9d236f09-93d9-4f41-88a6-20201a6a1abc%252Fresourcegroups%252Falgattik-appinsights%252Fproviders%252Fmicrosoft.insights%252Fcomponents%252Falgattik-appinsights"%2C"ResourceType"%3A"microsoft.insights%252Fcomponents"%2C"IsAzureFirst"%3Afalse}/DataModel/{"eventId"%3A"3e6c4536-a53e-11ec-a999-00155da5c821"%2C"timestamp"%3A"2022-03-16T15%3A31%3A51.140Z"%2C"cacheId"%3A"3123244d-83e3-4b02-9fbf-62eb9034eefd"%2C"eventTable"%3A"traces"%2C"timeContext"%3A{"durationMs"%3A14400000%2C"endTime"%3A"2022-03-16T17%3A30%3A32.988Z"}}
Linked Issue(s)
Relates to #131
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Replaced with #167


New build system not working with local dependency when angular cache is enabled

Which @angular/* package(s) are the source of the bug?
compiler
Is this a regression?
No
Description
Hello,
We are trying to migrate our app to the new build system but cannot because of the following error.
We are using a local typescript library in our angular project, declared as follows in our package.json :
"custom-services": "file:../our-custom-services"
At the root of "our-custom-services" we have "custom-services" directory as well as an index.ts with the following content :
export * from "./custom-services";
When running ng serve we encounter this error :
✘ [ERROR] Could not resolve "./custom-services"

    node_modules/custom-services/index.ts:1:14:
      1 │ export * from "./custom-services";
        ╵               ~~~~~~~~~~~~~~~~~~~~~

What's weird is that the error disappears when disabling angular cache in the angular.json, with :
  "cache": {
    "enabled": false
  }

Is there any way we can fix this ?
Thank you
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 18.2.6
Node: 18.20.4
Package Manager: npm 10.8.2
OS: linux x64

Angular: 18.2.6
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, material, platform-browser
... platform-browser-dynamic, router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1802.6
@angular-devkit/build-angular   18.2.6
@angular-devkit/core            18.2.6
@angular-devkit/schematics      18.2.6
@schematics/angular             18.2.6
rxjs                            7.8.1
typescript                      5.5.4
zone.js                         0.14.10

Anything else?
No response

Hi @jopelle1, can you setup a minimal repro please?
A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

Hi @alan-agius4 ,
Sorry, here is a minimal repro :
https://github.com/jopelle1/repro-angular-28538

For your case you can exclude custom-services the from prebundling.
"serve": {
  "builder": "@angular-devkit/build-angular:dev-server",
  "options": {
    "buildTarget": "ng:build",
    "prebundle": {
      "exclude": ["custom-services"]
    }
  },

That worked, thank you !


Update Cake addin to Cake 0.26.0

Cake 0.26.0 introduced breaking changes in the API. The Cake addin should be built against Cake 0.26.0 to be compatible with current version

@sergeyzwezdin I just wanted to follow up with this issue.  Are you in a position to update the Cake Addin for MagicChunks?  It would be great to have this updated.  Thanks!

Any ETA on this being addressed?

@sergeyzwezdin Would it be an option for you to split the core Magic Chunks and the Cake addin into separate repositories, with the Cake addin being part of the Cake-Contrib organization and more people having write access, so that the community can help to keep the Cake addin up to date?

I've updated the VSTS _build.ps1 code to fix the automated build for the https://github.com/sergeyzwezdin/magic-chunks/pull/65 to help improve compatibility with the newer editions of Cake.build.


[request]The plugin is sending sampler data even after Transaction controller with Generate Parent sample is used

@mderevyankoaqa I'm using Http sampler in a transaction controller with Generate Parent sample option set.However in Grafana dashboard I can see both Transaction Controller and sampler data in result calculation.And if any sampler is failing in Transaction controller, the error response of the sampler should be stitched as Transaction Controller response.However I can see null in the response message.

@suryaveepuri57 hello,
Thank you for the request, but why you decided that behavior are you requesting is correct? :)
JMeter is not working like you want "the error response of the sampler should be stitched as Transaction Controller response".
Lets modulate your scenario:

So in one transaction controller - > Main Transaction Controller we have two requests:

Request OK - set as successful
Request Force to Fail - will be always failed

The  "Main Transaction Controller" has Generate Parent sample option set to true. It means that we want to see only 'Main Transaction Controller" in the JMeter results. The inner requests "Request OK" and "Request Force to Fail" will not be included in Aggregate report.
Even more JMeter does not  stitch the failed inner (sub) sample as Transaction Controller response.
Lets run and see first of all what we have in the JMeter

We see "Main Transaction Controller" only - like expected.
Lets check what we have in View Results Tree

"Main Transaction Controller"  has failed since "Request Force to Fail" has failed. Important note as you can see Transaction Controller has more then one sample. Its main idea is to use this one when you have more then one inner sampler and you want to have the aggregation.
Lets see what the error message we have for "Main Transaction Controller".

All tabs I selected in red are empty -> this is expected JMeter behavior.
If you want to see what happened - you need to go to the failed request and see the message, right?

Nice, lets go to Grafana, you can see the following:

What we see? We see all thing are in place, but we are expecting to see "Main Transaction Controller", right?
Hm.. let's check the plugin documentation.

It means that we can allow JMeter to save sub results even you made the some settings in  "Main Transaction Controller" has Generate Parent sample option set to true.
OK, lets set option "recordSubSamples" to false.

And run test again. You will see

So we have only "Main Transaction Controller" in results. Perfect, we have no any useless sub simples. It completely works like expected. Why we have no error messages and we see "null" for the responses and error message? Since Transaction Controller is aggregator of the metrics, this object in JMeter Java code has no any relations with sub samplers.
Maybe we can add to results the failed sub sampler, even when recordSubSamples is false - just to see the errors.  Hm .. but from another point of view we need to exclude this from other results and place only message. This logic is too complicated.
So now you know the behavior and you can decide what you want to see in the report.  Once again  JMeter does not  stitch the failed inner (sub) sample as Transaction Controller response.
PS.
Please do not hesitate to type here if you have any further questions.
BR,
Mike

@mderevyankoaqa Thanks a lot for the reply.You have explained it well.
If we are able to stitch the error sampler response as TC response ,it will be very helpful as most of the HTTP samplers will be wrapped inside TC during web performance testing.
I've seen a plugin in Influxdb 1.8 which stitches the TC response using JSR223 Listener before writing to db.
I thought this feature will add more flexibility to Plugin.
Thanks
Surya Veepuri

@suryaveepuri57 , the feature looks good from the analysis perspective. In that case we need to also indicate what error inner (sub) sampler has failed.
The problem as I can see, we can have a lot of details have to do with the one message it may lead for the issues to store such message in Flux. Let's see maybe in next release will add such functionality. Thanks.
BR,
Mike


Feature: Support Tallies

MontePy needs to support tally objects.
I think there needs to be a tally object centered around "F" cards. This will then consume other describing data cards to create the hierarchy and description for the tally. This must be linked back to the cells and surfaces in the tallies. @bascandr has requested the ability in the cell object to tell what tallies that cell already has.
I'm a bit hesitant to implement doubly-linking pointers (i.e., tally -> cell, and cell -> tally) due to the complexity updating those links. Perhaps at the problem level the equivalent of a SQL view can be made to support this without the pointers being non-normalized (in Relational database sense), and avoiding delete and update anomalies.

This no longer seems to be a good first issue!

... RIP. Yeah I think I need funding to be able to put together a good implementation.


[cider/flat] Instantiate the beginning flat environment

Some stuff from the last week which creates the basic environment (all ports are zero and all ref cells/ports are None). Includes sanity checks that the local offset based definitions match the instantiated global offset from the appropriate offset base.
Reworked the SparseMap to iterate in insertion order and got a little clever with index ranges to avoid keeping a list of every key in order.

Heck yes, seems awesome! And adding an "insertion order" vector to the HashMap seems like a perfectly practical way to get deterministic ordering without too much trouble…


Getting an error during installation and initial setup  - Bug:

First time installing on this machine. I have verified that the file it is complaining about does exist at
..\AppData\Roaming\grocy-desktop\runtime-dependencies\<IP_ADDRESS>\cef\x86
i have tried running the app as admin, I have tried to repair the installation. No joy. Please advise.

This is not really something I can help with.
The mentioned DLL is shipped with the installer, most probably it gets blocked by your anti malware software or something.
When searching for it, that's a not so uncommon problem with CefSharp (the web browser component used).
Please double check that.
Should be located at (after the first start of grocy) at C:\Users\<USERNAME>\AppData\Roaming\grocy-desktop\runtime-dependencies\<IP_ADDRESS>\cef\x86.
Maybe try to restart by deleting the whole C:\Users\<USERNAME>\AppData\Roaming\grocy-desktop\runtime-dependencies folder.
Exactly the same "problem" as #23.

ok, thanks for the response, I will check and circle back

Please do not close this until it is solved

Please do not close this until it is solved

This is definitely not a bug, this is the issue tracker - we have the /r/grocy subreddit for general help requests.

I just checked the AV (Windows Defender software, nothing being blocked.  I removed the dependencies folder as you suggested and tried to re-run, same issue. I completely removed the folder from the appdata folder.  Same result after downloading and reinstalling

Whatever, the file is shipped, the file exists (like you said you've also verified), it works here and for many others - so what do you expect I should do? Magic tricks are not yet part of my portfolio...


i18n + partials

Expected behavior and actual behavior
I want to use the i18n to implement the customization of the title in the template file.
example:
/locales/en.yml
en:
    borrow_banner_tit: "title words"

/source/localizable/page.html.erb
---
title: t(:borrow_banner_tit)
description: "description words balabala"
---

    <section class="imagebg pb-52" style="background: url(<%= image_path "hero-apartment-preview.jpg" %>);">
        <div class="lazy-image-holder" data-src="<%= image_path<EMAIL_ADDRESS>%>">

                    <%= t(:borrow_banner_tit)%>

Expected behavior:

<title>title words</title>

Actual behavior:
<title>t(:borrow_banner_tit) </title>

Steps to reproduce the problem (from a clean middleman installation)

create layouts and use partials
create locales contents

Additional information
files
.
├── Gemfile
├── Gemfile.lock
├── README.md
├── config.rb
├── gulpfile.js
├── locales
│   ├── cn.yml
│   └── en.yml
├── middleman-gulp
│   ├── Gemfile
│   ├── Rakefile
│   ├── features
│   ├── lib
│   └── middleman-gulp.gemspec
├── package.json
├── scripts
│   ├── s3_website_config.json
│   └── set_s3_redirects.sh
└── source
├── fonts
├── images
├── javascripts
├── layouts
├── localizable
├── news
├── static
└── stylesheets

Ruby version: 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin18]
Middleman version: 4.2
OS version: Mac 10.14.6

That seems completely reasonable, but isn't currently how the front matter works. It isn't processed so it cannot contain variables or method calls.
For now, I think the yield_content and content_for helpers will get you close: https://middlemanapp.com/basics/helper-methods/#output-helpers
I think we could begin processing front matter as Erb, which would allow variables. Let me think on it.

Thanks


Caching images

This includes enabling caching feature for resources like icon & banner. These resources would be downloaded parallel & asynchronously.

I see in general a very complex solution to a very simple problem, delivering 5 classes for resource download is quite a complex solution.
I could agree having a downloader class, but the fact is that the entire download process is being done with a single line BitmapFactory.decodeStream(url.openConnection().getInputStream());
In fact there should be a lot of checks over the url to be done and corner cases that should be handled and are not handled there (like closing the connection).
@RagnarR WDYT?

I think - yes, this solution looks complicated. For my thoughts better create one class which will be preload all resources in memory for example. By the way, google has a good example how to implement LruCache for bitmaps here - https://developer.android.com/training/displaying-bitmaps/cache-bitmap.html

It looks a little bit complex but while implementing it I kept future scope in mind. As of now we are having only two resources it may increase in future.
I have used executor service to download the resources in parallel and once all of the task has been completed a callback would be invoked and only then we are serving ad. Here we don't need to bother that how many resources has been downloaded, and also to maintain the count and all.

If we really planning to add more resources in the Future, than yes - it makes sense. Not sure about will we or not.  Maybe @cerberillo could clarify it. Or I can talk with Amir about it directly.

ok, merge it 👍

👍
We would want to use it for other assets as well. i.e the standard banner if possible and also for video in the future.


[feat] Adding multiple modules to --with flag on uvx startup

Hello!
I love uv and very much appreciate all the work the team is doing for python development!
I am proposing a minor change to the uvx --with API to allow for multiple arguments.
Current API (uv==0.4.18)
uvx --with numpy --with polars --with matplotlib ipython

Desired API
uvx --with numpy,polars,matplotlib ipython

Closed by https://github.com/astral-sh/uv/pull/7909. Thanks!


Model is disposed!

Issue Id: ee4a0c54-3c69-def6-7024-bd08594c0996Versions - 1.10.2Stack Error: Model is disposed!/vs/editor/common/model/textModel.ts#L70:9/vs/editor/common/model/textModel.ts#L185:7 (_assertNotDisposed)/vs/workbench/api/node/mainThreadEditorsTracker.ts#L352:18 (getVersionId)/vs/workbench/api/node/mainThreadEditors.ts#L297:46 (applyEdits)/vs/workbench/services/thread/common/abstractThreadService.ts#L34:16 (apply)/vs/platform/extensions/common/ipcRemoteCom.ts#L275:39 (handle)/vs/platform/extensions/common/ipcRemoteCom.ts#L231:25 (invokeHandler)    at _combinedTickCallback (internal/process/next_tick.js:67:7)     at process._tickCallback (internal/process/next_tick.js:98:9)

@jrieken Perhaps you can check if this is a recent regression...

closing because this was still with the old code that had potential for invalid state


android: re-run perf analysis

We re-ran the performance analysis of iOS and updated the documentation accordingly in https://github.com/lyft/envoy-mobile/pull/740. We should do the same for Android now that Envoy Mobile is no longer utilized as a proxy (and is instead consumed as a library).

Fixed by https://github.com/lyft/envoy-mobile/pull/852


feat: aliases of IsSelfAdjoint.of_nonneg for dot notation

It bothered me that it takes so many characters to prove star x = x from 0 ≤ x in a StarOrderedRing.

Alright, thanks!
bors r+


Support @Nullable annoations marked with @Target({TYPE_USE})

Java support for annotation metadata has evolved, and projects providing
implementations of @Nullable has been adopting those new features. This
has had the side effect of some commonly used @Nullable annotations not
working as expected with Guice. This change uses reflection to extract
new style @Nullable annotations as well as old style ones. Addresses
the issue described in https://github.com/google/guice/issues/1193

@googlebot I signed it!

https://github.com/google/guice/commit/1a410a8bef1ec721e16f9f16a447235f09951f05 has done some work for type annotations. That may be sufficient for your needs (though I don't believe there's been a release yet).

https://github.com/google/guice/commit/1a410a8bef1ec721e16f9f16a447235f09951f05 has done some work for type annotations. That may be sufficient for your needs (though I don't believe there's been a release yet).

Indeed that commit already fixed this.


Turbo sometimes not scrolling to top of new pages after local navigation

This issue seems similar to #689 but I thought it would be nicer to open a new issue as the concrete cases are different and I didn't want to muddy any investigations.
We have a simple static site and I thought it would be neat to speed it up with some turbo, but some internal link clicks do not scroll the page to the top after loading the content.
There is a single scroll listener on the page that hides or shows the header, but nothing else interacts with scrolling.
You can preview the entire site with turbolinks and see the changes made to try and make it work in a PR.
Concretely from either the frontpage or e.g. Nyeste mærker, clicking on one of the linking boxes while scrolled down leads to the page, but doesn't scroll up to the top.
I've honestly found this very sporadic and hard to trace. For some subpages it seems to work, but for most it doesn't, and I haven't been able to find a pattern to explain that difference.

I'm observing the same behaviour.
I'm reasonably sure this is caused by html { scroll-behavior: smooth; }  and - to my knowledge - only happens in Firefox.
I guess the scrolling animation just stops when Turbo replaces the body and the scrollbar is stuck at whatever position it currently is.
That also explains the sporadic behaviour, the problem depends on how far down the scroll bar was on the previous page and perhaps also on internal timings of the document and/or Firefox.

I'm having the same issue, only with Firefox.

Was seeing this on iOS Chrome as well... nice catch on scroll-behaviour @daniel-rikowski

Same issue on Firefox and Chrome. Scroll randomly works or remains in the same position when scroll-behaviour is smooth.

Same issue on Firefox (all others: not tested).


Fix MessageEvent and ProgressEvent constructors

Fix #4295

:+1:

Please note this needs to be checked in branch release-1.6 and ported to master.


Need to disable send emails from staging

to avoid sending emails to real followers while testing functionality on staging and locally. For now, I just deleted all follows form the staging db

This is easy. Move the SMTP setting from /config/environment.rb to /config/environments/production.rb and then add this line in /config/environments/staging.rb:
config.action_mailer.delivery_method = :test

This is in production


Add "Catch in 2018" to Table j and Table 31

Trevor's first issue in #434 is "Figure k looks very odd: probabilities are all substantially
higher for the second last and lower for the last catch level."
As discussed during management talk yesterday, the risks for rows e and g are different in spite of similar 2019 catch because the 2018 catches are different.
One suggested way to help understand this pattern would to add a "Catch in 2018" prior to the "Catch in 2019" column in Table j and Table 31.
I have no idea how hard or easy this would be, so we can certainly just put this down for the "2019 assessment" milestone.

Just going to close (and then re-open next week) some '2019 assessment' issues to tidy up the Issues list!

In trying to fix this, I found the following:
columnames of the variable "risk" if the argument index = 1 are
"ForeCatch_2019" "SSB_2020<SSB_2019" "Bratio_2020<0.40"  "Bratio_2020<0.25" "Bratio_2020<0.10"
"SPRratio_2019>1.00" "ForeCatch_2020<ForeCatch_2019"
which don't actually match the 3-5 column of table i and table j which are

Should we be using something other than B_year for the "Bratio" column?
Also, for table j, do we want to append catch in 2019 to the table as the first row? I am part way done, but I can abandon it.

We use $B_year$ for SSB_year and Bratio_year in the second and third columns.

I think it's:
Bratio_2020 = B_2020 / B0
So P(B_2020 < B_40%)  = P(B_2020 < 0.4  B_0) = P(Bratio_2020 < 0.4)
So they're equivalent.
It's about this stage everywhere I wish we had full equations and notation for everything ;)

Ahh yes, math. It is good to do math, or arithmetic according to Andre, every once in a while. Thanks.

I am a bit squished. Any ideas?

If there are no grandiose ideas I will leave the code that includes the additional column as an extra but set the default to not include it.

In #434 it says 'Figure k issue got addressed in the meeting - graph is correct, and looks funny because the 2018 catch is so high for catch option g.'. I think that's related.
Yes, Table gets squished. Prob leave as is for now (but great to have a switch to include it if we need to).

The table is fixed in f898bcaf980bfe9053b80b14da3c8658a72aaa69, just need to use type = 2, which is not the default and nothing will be changed in the current document. Could be useful for presentations though.


⚠ AZ-Launcher has degraded performance

In 7ea829b, AZ-Launcher (https://az-launcher.nz/) experienced degraded performance:

HTTP code: 200
Response time: 1885 ms

Resolved: AZ-Launcher performance has improved in 4da7778 after 1 hour, 48 minutes.


see where gdb is pausing

I'm debugging an elf file via the new debugger mode.
I wonder, how do I see the line the debugger is pausing on?
I get an address in the object window, but once I click "display methods"(in the right click menu), nothing happens.
I would like to see the specific line in the listing window (where all the assembly is in).
Thanks!

Hey Eran,
Unfortunately, the "display methods" don't do what you think they do - I can see why you'd expect them to, but....  The "display methods" in the Objects view display any selected sub-tree as a new tree, table, graph, etc. and won't solve your current problem.
Highlighting the current line in the listing window should happen automatically if everything else is working correctly, but admittedly that's a pretty big "if".  To troubleshoot, we may need a little more info, but let me try to give you the big picture.
First, only the Objects view and the Interpreter view are in some sense "on" by default.  The other windows are active only when there is a valid trace being collected.  This is controlled by a setting in the Objects provider and should be set by default, but, if the Objects view is not open to at least the process level, it may not trigger.  I don't think this is your problem, because you've mentioned right-clicking on an address, which makes me think you've opened the tree down to the registers node within a thread.
If the trace is on, the other windows should be populated.  In particular, the dynamic listing window should have valid bytes and be tracking the current instruction pointer.  If this is not the case, it probably means you're working with a target (or version of gdb) for which "info proc mappings" is not defined.  If so, you'll have to define it yourself.  There are a number of postings regarding this, but happy to walk you through it if that's the issue.
If you do have values in the dynamic listing and the other windows besides the Objects and Interpreter windows, then the issue I assume you're having is that the static listing is not tracking the instruction pointer even thought the dynamic listing is.  If so, the likely culprit is that the debugger can't figure out how to map the static view to the current address.  This means either you are missing the module listing (i.e. the Modules window is empty) or the current program in the static view has a different name than the one in the module listing.  In the former case, you'll need to define a different command (one of the "maint" commands - am forgetting which one).  In the latter, you need to right-click on the correct module in the modules listing and manually map it to the program you're looking at.
Apologies for this being such a hassle - we're definitely still working the kinks out of this bit - but let us know which problem you think you're having and we can help you get around it.
Best,
D

The Debugger's cursor does move around a bit in the decompiler view...but the line doesn't get highlighted the way the assembly listing does, which is confusing.


Improve discoverability of OAuth 2 support

The previous summary gave the impression that requests-oauthlib only supports
OAuth 1.
This updates makes it clear that it also supports OAuth 2, and links directly to the
use case specific authentication flow guides.

I'm currently working on adding OpenID Connect support to a pre-existing web application (https://github.com/fedora-infra/anitya/issues/329) and found it very hard to find good documentation on writing a full semi-automated integration test where the only manual step is the user authorising a temporary access token.
Part of the problem was hitting this page in the docs and thinking that requests didn't have native OAuth 2 support - it was only after clicking through to the full requests-oauthlib documentation that I realised that that initial impression was wrong.

Thanks for having the code available to find!
You may be amused by the horrible hack I wrote to automate obtaining a refresh token for Anitya's Fedora Account System integration tests: https://github.com/ncoghlan/anitya/blob/authenticated-api/request_oidc_credentials.py :)

permalink for above broken link:
https://github.com/release-monitoring/anitya/blob/c369715f5ae7873066ca92b7ae3c412f01711e16/request_oidc_credentials.py


Subgraph endpoint update required

Hey team,
We've noticed that you're referencing a subgraph deployed on The Graph's hosted service in this repository. Just a heads-up: after June 12th, hosted service subgraph endpoints will no longer be available as the offering is being deprecated.
If you are the subgraph owner or maintainer, it's time to upgrade your subgraph to the network. This ensures everything keeps running smoothly and you get access to all the latest features and improvements. Here is a quick guide with all the upgrade steps.
If you're not the subgraph owner or maintainer, check Graph Explorer to see if the subgraph development team has already upgraded to the network. If you don’t find an upgraded subgraph, a friendly nudge to the subgraph development team would be greatly appreciated—it's a quick process that benefits everyone. Here's the upgrade guide with all the necessary steps for the subgraph development team.
Once the subgraph is upgraded to the network, you can create an API key and updated query URL in Subgraph Studio then update this repository to query from the new endpoint, https://api.studio.thegraph.com/query/<ID>/<SUBGRAPH_NAME>/<VERSION>
Need more support or have more questions? Feel free to reach out to<EMAIL_ADDRESS>We're here to help!
Cheers,
Paka

Files requiring an update: https://github.com/search?q=repo%3Agraphprotocol%2Fallocation-optimizer api.thegraph.com%2Fsubgraphs%2Fname&type=code

@alex-pakalniskis does this mean I have to create my own endpoint to query with allocation optimizer, or will a new endpoint be provided eventually? If I need to create my own endpoint I would appreciate a guide specific for allocation-optimizer, so I can continue reallocating.

I think I have it figured out, I set
network_subgraph_endpoint = "https://gateway-arbitrum.network.thegraph.com/api/{API_KEY}/subgraphs/id/{GRAPH_NETWORK_ARBITRUM_SUBGRAPH_ID}" and the AllocateOpt at least didn't crash :)
The subgraph I used is DZz4kDTdmzWLWsV373w2bSmoar3umKKH9y82SUKr5qmp I hope it's correct

Yes that looks good to me. Glad it worked (I expected it to be plug-and-play replace old url with new one including API key). Let us know if you run into any issues (we'll update the docs for this repo).

@alex-pakalniskis actually I ran into additional issues trying to reallocate. I have the following settings for the indexer-agent:
arbitrumNetwork: arbitrum-one
arbitrumGateway: "https://gateway-arbitrum.network.thegraph.com"
arbitrumSubgraphEndpoint: "https://api.thegraph.com/subgraphs/name/graphprotocol/graph-network-arbitrum"
arbitrumEpochEndpoint: "https://api.thegraph.com/subgraphs/name/graphprotocol/arbitrum-epoch-block-oracle"

Do any of these need to be also updated? When trying to close allocations today I ran into https://github.com/graphprotocol/indexer/blob/main/docs/errors.md#ie069 for all of them


2.0.x broken transition between screens on Android

After upgrading to v2 seems that the animation used when going between screens had changed. v1 had a kind of vertical shift combined with a fade whereas v2 does a full screen scroll of the new screen over the old one.
The transition into a screen is working fine but the actual problem I have with this is that navigating back seems a bit broken. The view "scrolls" away down to the bottom but not all the way and the visible part at the bottom just disappears after a while. So it is not very smooth.
Is there no way to have the v1 kind of transition without doing custom animations?
Screen record of v2:
screenrec.mp4.zip
Using

react-navigation-stack 2.0.12
@react-native-community/masked-view 0.1.5
react-native 0.61.5
react-native-safe-area-context 0.6.2

Looks like the glitch happens because the height of the screen is changing mid-animation because of hiding the tab bar. It's recommended put tab inside stack instead of the other way around to avoid this https://reactnavigation.org/docs/en/navigation-options-resolution.html#a-tab-navigator-contains-a-stack-and-you-want-to-hide-the-tab-bar-on-specific-screens
If you want the old animation, you can use ...TransitionPresets.FadeFromBottomAndroid in defaultNavigationOptions.


Make internal links HTTPS ready

Internal links should go over the protocol the website is currently surfed with.
Before merging, all of minetest.net subdomains should support https. That is:

{forum,wiki,dev,www}.minetest.net hosted by celeron55
minetest.net hosted by celeron55
servers.minetest.net hosted by sfan5 (does now)
inchra-stats.minetest.net hosted by ShadowNinja

Otherwise it could lead to issues if minetest.net supports https, and other sites don't.
Currently, there is only dependency on inchra-stats.minetest.net. This PR doesn't make the dependency more serious.
Also, the link in the README.md got changed to https.
Fixes #47.

The forum uses HSTS and redirects HTTP to HTTPS, so the forum links can be left as https to avoid a possible extra redirect.
The others seem file as long as TLS support is added to those sites.
Why link explicitly to the secure version of the main site though?  There's no login or anything like that, so it doesn't really need the security, and unencrypted communication saves a few CPU cycles.

Okay, updated.

We're hosting on GH pages, which doesn't allow HTTPS (unless you use a proxy/load balance, which just gives the illusion of security) :-1: from me

Yes, we do host on GH pages, but it all goes through a proxy hosted by celeron55. He can easily enable https for www.minetest.net. (and also fix dev.minetest.net and wiki.minetest.net, they currently use self signed certs...)
Well either way, I'm gone from development, so I don't want to give care to this PR. Closing.


Fix the implementation of the flag on keyword hash nodes

The previous implementation in #2046 was incorrect since it was just checking for all keys in assoc nodes to be static literals but the actual check is that all keys in assoc nodes must be symbol nodes (Ref: https://github.com/ruby/ruby/blob/2f1d6da8c45590bf3461ed4bf051a4e1009eaf85/compile.c#L4577-L4578).
This commit fixes that implementation, and, also, aliases the flag to PM_KEYWORD_HASH_NODE_FLAGS_SYMBOL_KEYS so that ruby/ruby can start using the new flag name.
I intend to later change the real flag name to PM_KEYWORD_HASH_NODE_FLAGS_SYMBOL_KEYS and remove the alias.

@kddnewton good question.
I checked with these changes on ruby/ruby with this code:
def a(foo:) = p foo

a(:foo => 1)

and the output from the current and Prism compiler for this are:
== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(1,12)>
0000 definemethod                           :a, a
0003 putself                                                          (   1)[Li]
0004 putobject                              1
0006 send                                   <calldata!mid:a, argc:1, kw:[foo], FCALL|KWARG>, nil
0009 leave

== disasm: #<ISeq:a@<compiled>:0 (0,0)-(0,19)>
local table (size: 2, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: 1@1, kwrest: -1])
[ 2] foo@0      [ 1] ?@1
0000 putself                                [Ca]
0001 getlocal                               foo@0, 0
0004 send                                   <calldata!mid:p, argc:1, FCALL|ARGS_SIMPLE>, nil
0007 leave                                  [Re]

== disasm: #<ISeq:<compiled>@<compiled>:0 (0,0)-(1,12)>
0000 definemethod                           :a, a
0003 putself                                                          (   1)[Li]
0004 putobject                              1
0006 send                                   <calldata!mid:a, argc:1, kw:[foo], FCALL|KWARG>, nil
0009 leave

== disasm: #<ISeq:a@<compiled>:0 (0,0)-(0,19)>
local table (size: 2, argc: 0 [opts: 0, rest: -1, post: 0, block: -1, kw: 1@1, kwrest: -1])
[ 2] foo@0      [ 1] ?@1
0000 putself
0001 getlocal                               foo@0, 0
0004 send                                   <calldata!mid:p, argc:1, FCALL|ARGS_SIMPLE>, nil
0007 leave

and they eval to the same result of 1.
I guess this is doing the right thing, right?


replace incorrect license

I think I found a solution: https://stackoverflow.com/questions/18038060/automake-ignore-missing-news-authors-copying-etc-standard-files


Don't expose class names such as "hidden"

Bootstrap should just expose namespaced or prefixed class names. The fact that it declares a global CSS class named "hidden" produces conflicts when CSS styles other than just Bootstrap is used in any website.
This becomes even more problematic when a 3rd party widget is inserted into a website made with Bootstrap. The widget may define it's own "hidden" class but just for elements within a specific namespace or CSS selector, something such as:
.3rdPartyWidget .hidden {
  // something here
}

Unfortunately Bootstrap exposes a global hidden class that includes display: none !important and much more stuff like that.
Bootstrap shouldn't be "God" but a component within a website or web application.

This was changed in v4; we no longer have straight .hidden classes anymore with our work on v4.

Nice to know. Thanks a lot.


flist and flist-plus documentation

Do I understand correctly, that the flist command outputs a whitespace-separated filelist (as could be used e.g. in Makefile prerequisites) and the flist-plus command now outputs what flist previously did as described in the README?
If so, I would open a PR to update the README accordingly.

Great, thanks :) Will open a PR to update the README.


Removing old Database2 converters

What is the change?
Removing references to versions of the database prior to Database3:

armi.bookkeeping.db.convertDatabase()
armi.cli.database.ConvertDB

Why is the change being made?
This version of the ARMI Database was introduced more than 4.5 years ago, and these tools were introduced to help people make the transition. The transition is over.

Checklist

[X] This PR has only one purpose or idea.
[X] Tests have been added/updated to verify any new/changed code.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes have been updated if necessary.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in pyproject.toml.

@drewj-usnctech I wanted to check that this change won't affect you.  I can't imagine it will, but just to be sure.


Created and updated docs for 1.22-25

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


pem files

where is apn looking for the cert and key pem files to be located? Should we import them with require('../path/to/cert.pem')? or should they be in the same directory?

https://github.com/argon/node-apn/blob/master/doc/connection.markdown

let connection = apn.Connection({
    cert: "../path/to/cert.pem",
    key: "../path/to/key.pem"
});

perfect thank you


can't login?

Traceback (most recent call last):
File "PixivBrowserFactory.pyc", line 319, in login
TypeError: 'NoneType' object is not subscriptable
Error at login(): (<class 'TypeError'>, TypeError("'NoneType' object is not subscriptable"), <traceback object at 0x076AD0A8>)
Error at doLogin(): (<class 'TypeError'>, TypeError("'NoneType' object is not subscriptable"), <traceback object at 0x073DDE28>)
Cannot Login!
how to fix it?

Q3. I cannot login to Pixiv!
- Check your password.
- Try to login to the Pixiv Website.
- Try to use the config.ini on the [Authentication] section.
- Check your date and time setting (e.g.: https://www.timeanddate.com/)
- Disable Daylight Saving Time and try again.
- Copy your session values from browser:
1. Open Firefox.
2. Go to Pixiv website and login, remember to enable [Remember Me]
check box.
3. Right click the page and select View Page Info.
4. Click the Security tab.
5. Click the View Cookies button.
6. Look for Cookie named = PHPSESSID.
7. Copy the content value.
8. Open config.ini, go to [Authentication] section, paste the value
to cookie, set keepsignedin = 1.

also, use the latest releases https://github.com/Nandaka/PixivUtil2/releases


Project artifact coordinates accessed via dependency resolution shouldn't be flagged as violations

Via IDEA-341827:

Artifact coordinates resolution for dependency that references another project.
GradleConfigurationModelBuilder.java

FTR: IDEA-341827 is no longer blocked on this as we agreed IDEA should make model requests for the project coordinates.

Workaround is to use the "long notation" (related #25629)
    // testImplementation(testFixtures(project(":other-project")))
    testImplementation(project(":other-project")) {
        capabilities { requireCapability("other.projects.group:other-project-test-fixtures") }
    }

I wonder if the capability resolution mechanism could be tweaked to work with the project name alone (without the group) if it knows that we are looking at local projects. Then you could allow a notation that omits the group if it is the same as the components group: requireCapability(":other-project-test-fixtures"). Then #25629 could also be implemented I presume.