Provide an option to disable "SDK LOAD Failure errors"

Please provide a feature that lets me opt-out of logging "SDK LOAD Failure: ..." errors as browser exceptions. This error frequently happens due to ad blockers and other conditions outside of my control, and I would rather not see the noise along side actual problems.
Describe the solution you'd like
I would like to see an option to disable SDK load failures in the javascript snippet.
Describe alternatives you've considered
As a workaround, I have removed this code from the snippet, but that's error prone and (for obvious reasons) not supportable by azure.

To my understanding you dont want the snippet to send these failures to Application Insights whenever the SDK failed to load.  Is my understanding correct? We can provide a config to opt-out of logging the exceptions.  But IMHO you might want to know when the SDK failure happened.

That's correct.
In my scenario, this failure has always been caused by ad blockers, or other methods that users are leveraging to block trackers. The end result is an error that I am unable to resolve as it's not a bug, leaving me with only one option, which is to tolerate it. For this reason, I'd like the option to disable this error from making it into the telemetry.


Annotation for requiring/forbidding the use of specific functions

Instructors should be able to write annotations for asserting the use or non-use of specific functions.
This change is somewhat complicated, as it will involve editing the trace function to track information that it is not currently tracking (which function is being traced and to what package it belongs, namely).

This one may be relevant:
https://docs.python.org/3/library/trace.html

I think we decided to resolve this issue by instead tracking function calls and letting the instructor use some post-grading process to assert conditions on this information.
#92 implements this feature by updating the tracing function and exposes the list of calls as (filename, function name) tuples in StudentImplementation.calls.


How to eval on MiDaS?

Hi, is there any evaluation code for MiDaS?
MiDaS can predict a robust inverse-depth of a single image, but how can I eval on datasets with ground truth depth like KITTI? Should I convert predict disparity to depth and evaluate in the depth space, or convert ground truth depth to disparity and evaluate in the disparity space?
I downloaded the ofﬁcial validation set of KITTI, and convert gt_depth to gt_disparity with:
gt_disparity = 1 / (gt_depth + 1e-8)
gt_disparity[gt_depth==0]=0

after performing alignment in disparity space and evaluating on midas_v3.0_dpt-large on KITTI, I got the performance:
KITTI AbsRel : 10.0
KITTI delta > 1.25 : 10.1

It seems that my evaluation code is not so accurate. Could you please provide your evaluation code for MiDas? Thank you so much.

@guangkaixu To evaluate MiDaS v3.0 (DPT-Hybrid) on NYU and Kitti depth datasets using Eigen-Split, use this manual and this repository: https://github.com/isl-org/DPT/blob/main/EVALUATION.md

@AlexeyAB Thank you for your reply.
The evaluation code of DPT is only suitable for metric depth prediction, but MiDaS can predict monocular disparity without scale and shift. What's more, the disparity can't recover scale and shift with datasets with gt_depth like KITTI directly, so we would like to know that how can disparity prediction recover scale and shift with gt_depth:

Convert pred_disp to pred_depth.

pred_depth = 1 / (pred_disp + 1e-8)
pred_depth[pred_disp <= 0] = 0
pred_depth_metric = recover_scale_shift(pred_depth, gt_depth)
error = evaluate_error(pred_depth_metric, gt_depth)

Convert gt_depth to gt_disp.

gt_disp = 1 / (gt_depth + 1e-8)
gt_disp[gt_depth <= 0] = 0
pred_disp_metirc = recover_scale_shift(pred_disp, gt_disp)
error = evaluate_error(pred_disp_metirc, gt_disp)

Other evaluation methods...

The gists linked in the section "General-Purpose models" in https://github.com/isl-org/DPT/blob/main/EVALUATION.md show how this evaluation is done.

Oh I see, thanks a lot!

Oh I see, thanks a lot!

你好，大佬问下，最后模型的输出要怎么转换才能变成米制单位的？？模型最后的输出范围太大了。

Oh I see, thanks a lot!

你好，大佬问下，最后模型的输出要怎么转换才能变成米制单位的？？模型最后的输出范围太大了。

The MiDaS can only predict affine-invariant disparity, which contains an unknown scale and an unknown shift value in the disparity area. You can align scale-shift values with np.polyfit(pred_disp, gt_disp), where gt_disp = 1 / gt_depth. Remember mask the invalid gt_depth :)

@guangkaixu
Hello, have you verified whether this code  https://github.com/isl-org/DPT/blob/main/EVALUATION.md can obtain the correct affine-invariant depth evaluation results? Is it okay if I use it on other models for relative depth evaluation, such as depthing anything v2?

@guangkaixu Hello, have you verified whether this code https://github.com/isl-org/DPT/blob/main/EVALUATION.md can obtain the correct affine-invariant depth evaluation results? Is it okay if I use it on other models for relative depth evaluation, such as depthing anything v2?

I just forget whether this code can evaluate it correctly. You can have a try. For depth anything v2, it predicts affine-invariant disparity, and can be evaluated similarly to this code.


python312Packages.accelerate: disable test_dynamo_extract_model

Description of changes

Disables another test which requires Dynamo support.
ZHF: #309482
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 314709 run on aarch64-darwin 1

6 packages marked as broken and skipped:

python312Packages.argos-translate-files
python312Packages.argos-translate-files.dist
python312Packages.argostranslate
python312Packages.argostranslate.dist
python312Packages.translatehtml
python312Packages.translatehtml.dist

16 packages built:

python312Packages.accelerate
python312Packages.accelerate.dist
python312Packages.diffusers
python312Packages.diffusers.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.peft
python312Packages.peft.dist
python312Packages.stanza
python312Packages.stanza.dist

Result of nixpkgs-review pr 314709 run on x86_64-darwin 1

6 packages marked as broken and skipped:

python312Packages.argos-translate-files
python312Packages.argos-translate-files.dist
python312Packages.argostranslate
python312Packages.argostranslate.dist
python312Packages.translatehtml
python312Packages.translatehtml.dist

16 packages built:

python312Packages.accelerate
python312Packages.accelerate.dist
python312Packages.diffusers
python312Packages.diffusers.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.peft
python312Packages.peft.dist
python312Packages.stanza
python312Packages.stanza.dist

No CUDA aarch64-linux.
nix run .#nixpkgs-review -- pr 314709 \
  --system aarch64-linux \
  --no-shell \
  --build-graph nix \
  --print-result

Result of nixpkgs-review pr 314709 run on aarch64-linux 1

6 packages marked as broken and skipped:

python312Packages.argos-translate-files
python312Packages.argos-translate-files.dist
python312Packages.argostranslate
python312Packages.argostranslate.dist
python312Packages.translatehtml
python312Packages.translatehtml.dist

8 packages built:

python312Packages.accelerate
python312Packages.accelerate.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.peft
python312Packages.peft.dist
python312Packages.stanza
python312Packages.stanza.dist

Result of nixpkgs-review pr 314709 run on x86_64-linux 1

6 packages marked as broken and skipped:

python312Packages.argos-translate-files
python312Packages.argos-translate-files.dist
python312Packages.argostranslate
python312Packages.argostranslate.dist
python312Packages.translatehtml
python312Packages.translatehtml.dist

16 packages built:

python312Packages.accelerate
python312Packages.accelerate.dist
python312Packages.diffusers
python312Packages.diffusers.dist
python312Packages.gradio
python312Packages.gradio-client
python312Packages.gradio-client.dist
python312Packages.gradio-pdf
python312Packages.gradio-pdf.dist
python312Packages.gradio.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.peft
python312Packages.peft.dist
python312Packages.stanza
python312Packages.stanza.dist

Merging as ofborg has been stuck for 16h waiting to build it on aarch64-darwin, which I covered with nixpkgs-review.


Auto-populate Classes, IDs in linked CSS

Suppose I've a HTML / JSX fragment which is linked to a CSS File, now when i start writing the CSS Code, I've to look back and forth between HTML / JSX to fetch the class name I specified on HTML element there and then copy the same and put it in CSS File and then start writing the CSS Styles.
Better strategy would be to have a setting in the editor to auto-populate the Class, IDs and other attributes by just typing the . for class and create the fragment e.g.
I've a html file named as index.html with following  content:

Price Tiers

Personal

Custom domains
Sleeps after 30 mins of inactivity

Free
Sign up

and I've a CSS file with name as app.css as linked above, now when i've to style div with class as pricing, i should be able to simply type in CSS following:
.p (immediately after I type p i should be able to see all connected classes in the dropdown and i need to just tab on it to select)
moment i press tab on pricing-table it will create a fragment in CSS like this:
.pricing-table {
}
ADVANCED:
To make it even more advance allow Emmet style in CSS itself and connect that with the list of auto-populated items.
Let me know if you need any help, I am reachable over: rachitrastogi777 at gmail dot com

We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the VS Code Marketplace. Just in case, in a few simple steps you can get started writing your own extension. See also our issue reporting guidelines.
Happy Coding!


How to disable SDK's push handler?

Hi,
Also I have an other issue with notifications. My application does not contains only chat feature. I have my own receiver for push notifications which extends FirebaseMessagingService. When  i receive message from other user Push messages doubles in notification bar.  How can i overcome this?
Thanks

@KAPLANDROID The best way to do this is to customize the Chat SDK push handling. I would recommend looking at the source code for the chat-sdk-firebase-push module - it's not very long. Specifically the DefaultBroadcastReceiver.
If you registered your own broadcast receiver you could copy paste the Chat SDK push handling code into your onReceive method. Then set config.inboundPushHandlingEnabled = false during the Chat SDK setup. That would mean that only your push handling code would be used. To use this option you will need to update to version 4.1.23 of the Chat SDK.

@KAPLANDROID i cant find config.inboundPushHandlingEnabled = false in new version!

@ominfowave the correct method is:
config.setInboundPushHandlingEnabled(false);

@bensmiley we have implemented our own notification handler which is working fine when app is running but if app is in background and notification comes which is also fine but same notification appears again when we launch the app next time.

I am experiencing the same difficulties as @KAPLANDROID and @ominfowave. @bensmiley , I think it is going to help checking the line @KAPLANDROID references to have a better grasp of the issue.

@bensmiley I did also make like mentioned but still getting the notifications, I even unimplemented FirebasePushModule but still getting them, worth to mention that I'm getting them only if the app is in bg or closed

@MuhammedRefaat are you using the Firebase Cloud Functions script? If you are, push notifications will be being sent. You could disable that script to stop them.

@bensmiley Actually I'm not using any Firebase Cloud Functions, on the other hand that's how I'm setting the configuration regarding the notification disable:
       builder.setShowLocalNotifications(false);
       builder.locationMessagesEnabled(false);
        builder.setClientPushEnabled(false);
        builder.setInboundPushHandlingEnabled(false);

And yet, I'm receiving the push notification when the app is in bg or closed, by displaying the app main logo along with the sender name and message.


feat: Command Description

Pull Request
Title
Implement command description for commands just like how command preview works
Type of Change

[x] New feature

Description
Add command description be using D key just like how command preview works

Testing
Works as expected.
Impact
When new scripts are added a description must be added in the toml for command description to work
Issue related to PR

Resolves #244

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no errors/warnings/merge conflicts.

Not sure why the keybind is "a" when "d" is the first letter of "description"

Not sure why the keybind is "a" when "d" is the first letter of "description"

It was initially thought to the function name as about page and the key A for about but command description suited it better so I refactored the function names to description with D as keybind

yeah thanks

Now this is PERFECT! Thank you @jeevithakannan2 exactly what I was thinking.


HV-1178 Using a specific ValidationProviderResolver is no longer needed

for OSGi when using the external class loader

https://hibernate.atlassian.net/browse/HV-1178

Jenkins, retest this please

Rebased and applied. Thanks, @gsmet!


If defaultFilter is disabled, psgeo crashes

Corrected.
undefined replaced by { "op": "true" } just before applying.


Use exec in start script

Ensures the CouchPotato process is PID 1 for correct signal handling
Fixes #5

Thanks merged


request:  support of proxy domain for web

Hi Clevertap Team,
I wanted to confirm if web SDK supports a way to provide an option for a proxy domain on web SDK, similar to ios SDK's
I was not able to find the option on docs , so wanted if there is a way to achieve this.

Hi @abhu-A-J . We have a support for Proxy Domain. You can read about it more over here under Basic Initialisation Section- https://github.com/CleverTap/clevertap-web-sdk#readme

Hi @abhu-A-J . We have a support for Proxy Domain. You can read about it more over here under Basic Initialisation Section- https://github.com/CleverTap/clevertap-web-sdk#readme

Hello @sinhaayush7 we use inline scripts directly over web-sdk, could you recommend the solution to that. The above link suggests only for web SDK. Thank you for the response.

hey @abhu-A-J this looks right.

hey @abhu-A-J this looks right. Does this solve your issue?

Hey @sinhaayush7 , thanks!!!
I can see some warning/information by turning on logger sessionStorage['WZRK_D']='' which shows these messages and no requests are being made. Any idea on what can be causing these????

@sinhaayush7  this is resolved per v1.3.5.
Thanks for the help, I will be marking the issues as resolved, and if in future the problem occurs again, I will open up the discussion again.
Thanks for the support.


fix: remove one topic in dart_frog_auth

Description
According to https://dart.dev/tools/pub/pubspec#topics, only 5 topics are allowed.
dart_frog_auth is using 6 topics currently.
This will run into checks from pub.dev as soon as you run dart pub lish.

Hey @jxstxn1 thanks so much for opening the issue and offering to submit a PR, But we ended up addressing that in the past release.


[BUG] instructions provided by WebUI to add a new node are incorrect

Describe the bug
When adding a new node via WebUI the instructions are provided are not correct.
If you use STEP 1 as is, you'll have to prepend ./ to STEP 2 (./gravity [...]) to have the process work.
But even that won't work, cause the gravity binary will lack the executable permission, quickly fixed by chmod u+x gravity though that's not mentioned.
I guess those commands are meant to be used verbatim with no other action from the user, thus they probably need to be fixed.
To Reproduce
Try to add a new node via WebUI by going to NODES and press the ADD button at the top right corner of the central section.
Environment (please complete the following information):

Gravity [e.g. 5.5.4]: verified on Gravity 5.5.x, 6.1.x and 7.0.x

@benarent could you provide an updated set of instructions?


Fix package vulnerabilities

quicktype v15 had some high and moderate vulnerabilities related to old versions of node-fetch and yargs-parser. This PR bumps quicktype to v20 to fix those vulnerabilities

will need to e2e this on some projects - last i remember, we couldnt update quicktype for some reason (maybe breaking changes)

We do have e2e testing on this project @p-mcgowan: IIRC we gen the files with the code and compare the new output to the expected output.
@acrontum-jrodrigues if the unit tests pass it should be all good - might wanna double check the tests compare the interface files too as this is where quicktype is used the most

Summary of all failing tests
 FAIL  src/__tests__/openapi_serverClient.ts
  ● Test suite failed to run

    Cannot find module 'quicktype/dist/quicktype-core' from 'src/lib/generate/generateTypeScriptInterfaceText.ts'

    Require stack:
      src/lib/generate/generateTypeScriptInterfaceText.ts
      src/lib/openapi/OpenAPIInjectInterfaceNaming.ts
      src/lib/openapi/OpenAPIBundler.ts
      src/generateIt.ts
      src/__tests__/openapi_serverClient.ts

      at Resolver._throwModNotFoundError (node_modules/jest-resolve/build/resolver.js:427:11)
      at Object.<anonymous> (src/lib/generate/generateTypeScriptInterfaceText.ts:1013:27)
      at Object.<anonymous> (src/lib/openapi/OpenAPIInjectInterfaceNaming.ts:5129:50)
      at Object.<anonymous> (src/lib/openapi/OpenAPIBundler.ts:3025:51)
      at Object.<anonymous> (src/generateIt.ts:711:51)
      at Object.<anonymous> (src/__tests__/openapi_serverClient.ts:6:46)

I just tried this and got errors as above @acrontum-jrodrigues

Look like a few bits have been moved around in the latest version - this would need reflecting in the implementation over in src/lib/generate/generateTypeScriptInterfaceText.ts
https://github.com/glideapps/quicktype?tab=readme-ov-file#calling-quicktype-from-javascript


Update Timeline “2022-06-16t15-40-38-831z-campaign”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
da5cf07c0256ae7ce290205a54638035d3f7b7aa

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/62ab54b9e1b3070008ec0ef4


Spring Upgrade 2.0.0 for Custom Authentication Provider

I am trying to implement Custom Authentication Provider with example folder. I am able to run the code in Spring Boot 1.5.7 successfully, however, I have a project with version 2.0.0.RELEASE and I could not login from the inMemoryAuthentication configuration.
@EnableWebSecurity
public class MultipleAuthProvidersSecurityConfig extends WebSecurityConfigurerAdapter {
    @Autowired
    CustomAuthenticationProvider customAuthProvider;

    @Override
    public void configure(AuthenticationManagerBuilder auth)
            throws Exception {

        auth.authenticationProvider(customAuthProvider);
        auth.inMemoryAuthentication()
                .withUser("memuser")
                .password("pass")
                .roles("USER");
    }

    @Override
    protected void configure(HttpSecurity http) throws Exception {
        http.httpBasic()
                .and()
                .authorizeRequests()
                .antMatchers("/api/**")
                .authenticated();
    }
}

Hey @ashishtam The upgrade to Boot2 requires an explicitly defined passwordEncoder bean. Have a look at the updated article: http://www.baeldung.com/spring-security-multiple-auth-providers
Cheers.

Thank you. Works fine! :)


Leave channel function?

We already have join_channels, why not have leave_channels?

I second this. I need people to be able to remove my bot from their channel.

As a workaround, you can use the following. I am having the bot listen for !join and !part messages within its own chat to allow a streamer to request the bot join and part their channel from there. Obviously it needs some proper error checking before joining and parting, but this was just a quick and dirty way to get something functional.
if message.content.lower() == "!join":
        await self.join_channels([message.author.name])
elif message.content.lower() == "!part":
        await self._connection.send(f"PART #{message.author.name}\r\n")
#end if

Give me a day and I'll have something done. The reason this was put on the backburner was because it requires editing the cache, which unfortunately in its current state is quite poorly written.
I'm going to tag this is a 3.0 issue as well as it will need to be implemented there.
Thanks

 JOIN and PART channel methods and appropriate cache handling.


Added ArchLinux support.

I assume it works the same way for pacman ? Correct me if I'm wrong.

When just using -S, pacman will only install specified packages, and won't update dependencies, unless a more recent version is needed by one of the specified packages.
To sum up, pacman will just do what's needed to have the dependencies fulfilled.
The problem is, we can't just do -S because if another version is out, the old one won't be available in the repositories and the install will fail.

The -y is a good idea, though.

Yes this is the solution to this problem, but it is highly discouraged to do -Sy, as of what I just explained. Archlinux is meant to kept up to date, packages have to be updated all the same time. Things may break even if the dependencies are still fulfilled.

Thus, I don't think that adding -u to the pacman command is needed.

So, even if I agree with you, it's a little bit intrusive, but Arch is meant that way.

You confirm that lines 51 to 62 this add a functionnal rc.local, and therefore resolving #1 ?

Absolutely.

You're right : https://wiki.archlinux.org/index.php/Pacman#Installing_packages

Warning: When installing packages in Arch, avoid refreshing the package list without upgrading the system (for example, when a package is no longer found in the official repositories). In practice, do not run pacman -Sy package_name instead of pacman -Syu package_name, as this could lead to dependency issues.

I can't argue with the Arch Documentation 🙄

So as for me, the installation works fine, and I can ping <IP_ADDRESS>.
However, it seems to be an issue with the firewall, the server does not forward the traffic, so I can't access anyting outside the server.

It worked fine for me. Can you check the actual iptables rules ?
Openvpn log may be interesting too.

There is no iptables rules, that's the problem.
The OpenVPN logs don't say anything about this as it's not related to OpenVPN

Oh, I see.
I suppose iptables was installed by the script, and as it does not start nor enable it, it's not working. I'm writing a fix now.
Can you confirm this is the problem by running systemctl status iptables?

iptables is already present on my installation, but it is indeed not started. I'm not sure it's the problem though, because I just reinstalled the server and the installer shows me this at the end :
sed: can't read /etc/sysctl.conf: No such file or directory
grep: /etc/sysctl.conf: No such file or directory
iptables v1.6.0: can't initialize iptables table `nat': Table does not exist (do you need to insmod?)
Perhaps iptables or your kernel needs to be upgraded.

However OpenVPN is sucsessfully installed

Okay so
iptables v1.6.0: can't initialize iptables table `nat': Table does not exist (do you need to insmod?)
Perhaps iptables or your kernel needs to be upgraded.

is on me, I had to reinstall Linux from the Arch repo, which was not the case (thanks Online...)

So this is working now?
However the fix I just done was necessary as if iptables was not started, the changes done would have had no effect

It works, but the traffic is not forwarded after a reboot. The iptables rule is not set

Can you show the contents of the file /etc/rc.local and the output of systemctl status rc-local please?

[root@server ~]# cat /etc/rc.local
[root@server ~]# systemctl status rc-local
* rc-local.service - /etc/rc.local compatibility
   Loaded: loaded (/etc/systemd/system/rc-local.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Wed 2016-11-23 20:18:51 CET; 1h 55min ago
  Process: 318 ExecStart=/etc/rc.local (code=exited, status=203/EXEC)
 Main PID: 318 (code=exited, status=203/EXEC)

Nov 23 20:18:51 sd-80765 systemd[1]: Starting /etc/rc.local compatibility...
Nov 23 20:18:51 sd-80765 systemd[1]: rc-local.service: Main process exited, code=exited, status=203/EXEC
Nov 23 20:18:51 sd-80765 systemd[1]: Failed to start /etc/rc.local compatibility.
Nov 23 20:18:51 sd-80765 systemd[1]: rc-local.service: Unit entered failed state.
Nov 23 20:18:51 sd-80765 systemd[1]: rc-local.service: Failed with result 'exit-code'.
[root@sd-80765 stan]#

New fix, working on my server even after a reboot now.

Does not work for me, but to be sure I'm gonna reinstall the server from scratch.
I checked the use of sysctl for Arch and it seems that the file is not located in the right folder : https://wiki.archlinux.org/index.php/Sysctl (does not affect the current issue tough)
Also, I think the script should add the rc.local file after it ask them if they want to continue. If the user cancel the installation, the script should not have touched anything on the system

My bad, it was working on my server beaucause of an old weird thing I've done to support this path..
Fixing this now, with the suggestion you have juste done.

Still working for me, starting from scratch, with these new changes.

Ok I'll test asap

Same problem after a reboot.
[root@server ~]# iptables -t nat -L
Chain PREROUTING (policy ACCEPT)
target     prot opt source               destination

Chain INPUT (policy ACCEPT)
target     prot opt source               destination

Chain OUTPUT (policy ACCEPT)
target     prot opt source               destination

Chain POSTROUTING (policy ACCEPT)
target     prot opt source               destination

rc-local is not working :
[root@server ~]# systemctl status rc-local.service -l
* rc-local.service - /etc/rc.local compatibility
   Loaded: loaded (/etc/systemd/system/rc-local.service; enabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Fri 2016-11-25 16:37:06 CET; 10s ago
  Process: 484 ExecStart=/etc/rc.local (code=exited, status=203/EXEC)
 Main PID: 484 (code=exited, status=203/EXEC)

Nov 25 16:37:06 sd-80765 systemd[1]: Starting /etc/rc.local compatibility...
Nov 25 16:37:06 sd-80765 systemd[1]: rc-local.service: Main process exited, code=exited, status=203/EXEC
Nov 25 16:37:06 sd-80765 systemd[1]: Failed to start /etc/rc.local compatibility.
Nov 25 16:37:06 sd-80765 systemd[1]: rc-local.service: Unit entered failed state.
Nov 25 16:37:06 sd-80765 systemd[1]: rc-local.service: Failed with result 'exit-code'.

What's inside rc.local file and systemd unit file?

[root@server ~]# cat /etc/rc.local
#!/bin/bash
iptables -t nat -A POSTROUTING -s <IP_ADDRESS>/24 -j SNAT --to <IP_ADDRESS>

[root@server ~]# cat /etc/systemd/system/rc-local.service
[Unit]
Description=/etc/rc.local compatibility

[Service]
Type=oneshot
ExecStart=/etc/rc.local
RemainAfterExit=yes

[Install]
WantedBy=multi-user.target

This is an old version of the script, not fixed.
Either remove it and start from scratch the install, or just replace ExecStart=/etc/rc.local by ExecStart=/bin/bash /etc/rc.local

It's the actual version : https://github.com/Angristan/OpenVPN-install/pull/2/files#diff-cda9722285f1718b319bb88e134e9efeR302

Fixed...
Avoid starting from stratch by executing chmod +x /etc/rc.local if you want.

Works too thanks.
I'll make some more tests, and then I'll fix the conflicts for the merge

Thanks 🤗


Enabled Istio tracing

Need to check if Istio ingress appears in Zipkin. May require further changes.
Signed-off-by: Dmitrii Ustiugov<EMAIL_ADDRESS>

@MBaczun can you please check?


[BUG]

To Reproduce
Commands you ran

Observed Behavior
Include error output here

Expected behavior
A clear description of what you expected to happen instead.
Is this specific to Cloud Shell?
Please verify if the same issue can be reproduced by running the same tool outside Cloud Shell - for example,
by installing it on your own computer. If so, it is likely to be a bug in that tool or in the Azure service it communicates with,
not in Cloud Shell. Please file the issue with the appropriate project.
Interface information
How are you accessing Cloud Shell - https://shell.azure.com, https://portal.azure.com, via Windows Terminal, or some other method?
If a browser, which Operating System and browser are you using? (ex. Edge on Windows 10)
Additional context
Add any other context about the problem here.

@Karelweb, please open an issue that answers the above bug reporting structure.  We cannot resolve the issue if no details are provided.


periodic.WindUpContext: Add function

WindUpContext wraps a context.Context with a wind-up timeout, allowing to be extended multiple times. This extends the possibilities of context.WithTimeout with a timeout to be reset multiple times.
This function was implemented to be used in Icinga DB's HA logic.

Closed as no longer needed :smiling_face_with_tear:


Sonoff zigbee button SNZB-01 issue

Hello, I have two zigbee SNZB-01, one is in LAN, connected to Home Assistant directly (with a CC2531) and it works just fine, I control 3 different devices with single click, double click and long lasting click.
Another SNZB-01 is connected on the cloud, trough a sonoff bridge, and HA considers it not a device, just a binary_sensor... so I cant use double click or long lasting click, It's just "on" and "off"... and it takes ages (sometimes 3-4 minutes) since the click to change state.
I see the proble is not the button, when it goes directly on LAN without the bridge/cloud, it works as the first button.

@mabusdogma
I know that this does not have room for the post to ask this question but, I take this opportunity because I am just looking for how to do the programming of zigbee smart switch.
"it works just fine, I control 3 different devices with single click, double click and long lasting click."
thank you

What do you want to do?
I mean, explain a bit what you have (Home assistant, bridge or CC2531) and
what do you want to happen when you press the button.
El mié., 12 ago. 2020 4:24 a. m., Tykwondo1<EMAIL_ADDRESS>escribió:

@mabusdogma https://github.com/mabusdogma
I know that this does not have room for the post to ask this question but,
I take this opportunity because I am just looking for how to do the
programming of zigbee smart switch.
"it works just fine, I control 3 different devices with single click,
double click and long lasting click."
thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AlexxIT/SonoffLAN/issues/216#issuecomment-672472434,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AESCMAXAAXXFVEDEBW26MRTSAH4OVANCNFSM4P3NUFFA
.

https://community.home-assistant.io/t/sonoff-zigbee-button-snzb-01-issue-only-in-cloud-mode/217906
I transferred the question to the HA forum, so as not to pollute the Alexx page. thank you and sorry Alexx

Proper recognition of the Zigbee button is in the latest release of this custom component. It now supports single, double, long press.

'single', 'double', 'hold' for SNZB-01 fixed in latest release


Implementing RLHF trainer ?

Not yet

Is there a road map of future implementation ?

@R3xpook , we have a plan for adding RLHF trainer, but currenlty not have a schedule.


Remove OwnershipMixin from ServiceMixin

ServiceMixin is included only in   Service and ServiceTemplate models
➜  manageiq git:(remove_ownership_mixin_from_ServiceMixin) ✗ ag 'include ServiceMixin'
app/models/service_template.rb
41:  include ServiceMixin

app/models/service.rb
74:  include ServiceMixin

and there is OwnershipMixin already included in those models.
and I think it is more clear that when OwnershipMixin is included in models than hidden in somewhere in other mixin to I am removing it from ServiceMixin
@miq-bot add_label technical debt

thanks for reading my mind


Remove the isArrayBuffer helper function

This old helper function can now be replaced with ArrayBuffer.isView() and/or instanceof ArrayBuffer checks, as needed depending on the situation.

/botio test


How to use multiple cores to speed up the inference time?

Hello. Let me first thank you for your tutorial.
I could successfully run the model on a video and see the detections. BUT, when I do htop, I can see that only one core is used! How can I force the TensorFlow to use the other cores too?

I don't know! Maybe someone else can suggest a method.

Did you experience the same issue?

@zanazakaryaie , can you share more information on which pi are you running your model on? Any screenshots to share(if possible)?

Maybe you could try this pre-buillt binary of tflite which supports multi-thread
https://github.com/PINTO0309/TensorflowLite-bin


Introduce a setting to automatically burn secrets after a specified number of unsuccessful attempts.

Current behavior
We are restricted to five attempts per machine. This means that on my personal device, I am prevented from making further password attempts after five errors, even if I try using incognito mode across multiple browsers. However, I am able to retry on another machine connected to the same Wi-Fi network, such as my smartphone.
Desired behavior
If the number of unsuccessful attempts exceeds a predetermined threshold, regardless of the originating machine, the secret will be automatically burned if the "BurnAfterXAttempts" setting is configured with a value greater than zero.

Yeah that's a great idea. I've added this to our redesign project and we'll follow-up as part of that work.


Polynomial Addition in C

🚀 Feature
To implement addition of 2 polynomials in C .
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


optimize web accessbility

optimize web accessbility by adding aria-label and role attributes to nodes where needed

@linx4200 @xiaokaike review please, thank you ~


Tree visualization

The example driver is not finished yet but I'd like feedback on the changes in the tree traversal header.

Codecov Report

Merging #535 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   96.22%   96.22%   +<.01%
==========================================
  Files         128      128
  Lines        9303     9304       +1
==========================================
+ Hits         8952     8953       +1
  Misses        351      351

Impacted Files
Coverage Δ

...ages/Search/examples/point_clouds/point_clouds.hpp
18.84% <ø> (ø)
:arrow_up:

...es/Search/src/details/DTK_DetailsTreeTraversal.hpp
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2f264...6f9197c. Read the comment docs.


Bigquery tests against prod timeout

GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/ee2e8585-e64c-4599-aee4-23b8393268a4;tab=detail?project=cloud-cpp-testing-resources
Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/60354fb11924fe04a58719b573ec9ddc51767030/fedora-35-quickstart-production/log-ee2e8585-e64c-4599-aee4-23b8393268a4.txt

85/85 Test #133: bigquery_quickstart ................***Failed  300.11 sec
CMake Error at /workspace/cmake/quickstart-runner.cmake:90 (message):
  Non-zero exit status (Process terminated due to timeout) running
  /workspace/cmake-out/google/cloud/bigquery/bigquery_quickstart

The test itself timed out. The service might be having some problems.

Other tests are timing out too.
https://console.cloud.google.com/cloud-build/builds;region=us-east1/85b23c6b-3819-47bf-b78e-c6b4a0abab23;tab=detail?project=cloud-cpp-testing-resources
https://console.cloud.google.com/cloud-build/builds;region=us-east1/6bfab7ce-c73c-4757-a860-8114370efe99;tab=detail?project=cloud-cpp-testing-resources

We think these failures were the result of an isolated server-side incident. Googlers can see omg/55671 for more details.


Added "get.tech"

Hello @meeeeeeeeeow
This repo has been abandoned for years. We keep an active version of it here https://github.com/jdm-contrib/jdm , feel free to contribute there!

Hello @meeeeeeeeeow
This repo has been abandoned for years. We keep an active version of it here https://github.com/jdm-contrib/jdm , feel free to contribute there!

Got it. Thanks!


moved constants.js up to the app/ directory

so it can be shared across the application, updated require path to new location in files that use it, removed require in cases where it is not used.
This is part of code reorganization work towards "separate functionality into main and renderer" #88

LGTM :shipit:


[Bug]  how to load dicom-segment data

Describe the Bug

the img is from OHIF Viewer。 how can i use cornerstone3D to load the dicom-segment。 or like the export demo can i load the exported file?
Steps to Reproduce
like above
The current behavior
like above
The expected behavior
like above
OS
window11
Node version
18
Browser
chrome

Segmentation Volume #664 Segmentation Stack #1059
The link you provided doesn't seem to fully solve the issue. I couldn't understand the code in OHIF-VIEWER, it's too complex. Are there any simpler examples?

Import Segmentation Volume
const { viewport } = libCornerstone.getEnabledElement(element);

await libCornerstone.imageLoader.loadAndCacheImages(imageIds);

const volume = await libCornerstone.volumeLoader.createAndCacheVolume(volumeId, {
    imageIds: imageIds
});

volume.load();

await viewport.setVolumes([{ volumeId }]);

viewport.render();

// "arrayBuffer" is file segmentation dicom
const result = libCornerstone.adapters.segmentation.generateToolState(viewport.imageIds, arrayBuffer);

const derivedVolume = await libCornerstone.volumeLoader.createAndCacheDerivedVolume(volume.volumeId, {
    volumeId: segmentationId
});
const derivedVolumeScalarData = derivedVolume.getScalarData();
derivedVolumeScalarData.set(new Uint8Array(result.labelmapBufferArray[0]));

libCornerstoneTools.segmentation.addSegmentation(segmentationId);
await libCornerstoneTools.segmentation.addSegmentationRepresentation(toolGroupId, segmentationId);

Import Segmentation Volume
const { viewport } = libCornerstone.getEnabledElement(element);

await libCornerstone.imageLoader.loadAndCacheImages(imageIds);

const volume = await libCornerstone.volumeLoader.createAndCacheVolume(volumeId, {
    imageIds: imageIds
});

volume.load();

await viewport.setVolumes([{ volumeId }]);

viewport.render();

// "arrayBuffer" is file segmentation dicom
const result = libCornerstone.adapters.segmentation.generateToolState(viewport.imageIds, arrayBuffer);

const derivedVolume = await libCornerstone.volumeLoader.createAndCacheDerivedVolume(volume.volumeId, {
    volumeId: segmentationId
});
const derivedVolumeScalarData = derivedVolume.getScalarData();
derivedVolumeScalarData.set(new Uint8Array(result.labelmapBufferArray[0]));

libCornerstoneTools.segmentation.addSegmentation(segmentationId);
await libCornerstoneTools.segmentation.addSegmentationRepresentation(toolGroupId, segmentationId);

how to get segmentationId?

how to get segmentationId?

// It is to create or generate id in segmentation
const uid = cornerstone.utilities.uuidv4();
const segmentationId = 'segmentation-image-volume:' + uid;

let me answer the question。demo is base vue 、 offical demo  and the data source is i got from ohif-view demo

<template>

</template>

the addSegmentationsToState function is get the segment data and set to display。

@l5769389
take a look https://github.com/cornerstonejs/cornerstone3D/issues/664#issuecomment-2023006706

When I use the official data of ohif-view and run the code listed above, I encounter some mismatched images. I think there might be an issue with the implementation in addSegmentationsToState(). Can anyone help me resolve this?

@jlopes90  i want to modify the segment render color。 but i dont know how to do. can you show me ?   it looks like use the  api:    i got the segment data like this:
const arrayBuffer = await retrieveDicomData(segParams)
  const result = await adaptersSEG.Cornerstone3D.Segmentation.generateToolState(imageIds, arrayBuffer, metaData)
  const segmentationVolume = await volumeLoader.createAndCacheDerivedSegmentationVolume(volumeId, {
    volumeId: segmentationId
  })

@l5769389 https://www.cornerstonejs.org/live-examples/labelmapsegmentcolorchange

**@jlopes90  here is the way i get segment arraybuffer from PACS System ,am i right?  the segment data need be accurate to sopInstanceUID ？
async function retrieveSegData({ studyInstanceUID, seriesInstanceUID, sopInstanceUID, wadoRsRoot }) {
  const client = new api.DICOMwebClient({
    url: wadoRsRoot as string,
  })
  const options = {
    studyInstanceUID,
    seriesInstanceUID,
    sopInstanceUID
  }
  return await client.retrieveInstance(options)
}
```**

@l5769389 I don't know, I've never tried pacs

@jlopes90， Sorry to bother you again, but I've been using your segmentation loading demo. I've found a bug when retrieving DICOM data from a remote PACS (Orthanc) via API (similar to the demoDicom() function) and then reading segmentation data locally. In Figure 1, DICOM data is fetched from Orthanc via an API, while segmentation data is read locally using an  tag. In Figure 2, both DICOM and segmentation data are read locally using  tags. It's evident that there's a bug in Figure 1. Could you please help me resolve this?   all use your demo。 i only change the StudyInstanceUID and SeriesInstanceUID from your demo . I believe there might be some flaws in your example.

https://deploy-preview-1177--cornerstone-3d-docs.netlify.app/live-examples/segmentationvolume  the demo link

@l5769389 https://deploy-preview-1201--cornerstone-3d-docs.netlify.app/live-examples/segmentationVolume.html
Try editing exConfig, run Load DICOM and Load SEG
exConfig = {
    "fetchDicom": {
        "StudyInstanceUID": "<IP_ADDRESS>.4.1.145<IP_ADDRESS>.256467663913010332776401703474716742458",
        "SeriesInstanceUID": "<IP_ADDRESS>.4.1.145<IP_ADDRESS>.40445112212390159711541259681923198035",
        "wadoRsRoot": "https://d33do7qe4w26qo.cloudfront.net/dicomweb"
    },
    "fetchSegmentation": {
        "StudyInstanceUID": "<IP_ADDRESS>.4.1.145<IP_ADDRESS>.256467663913010332776401703474716742458",
        "SeriesInstanceUID": "1.2.276.0.7230<IP_ADDRESS>.481034752.2667.1663086918.611582",
        "SOPInstanceUID": "1.2.276.0.7230<IP_ADDRESS>.481034752.2667.1663086918.611583",
        "wadoRsRoot": "https://d33do7qe4w26qo.cloudfront.net/dicomweb"
    }
}

i tried your demo, Still no effect, just causing the display to flip.
in console set window.exConfig  not effect in the link.

this is ohif-viewer's config:

const exConfig = {
  fetchDicom: {
    StudyInstanceUID: '<IP_ADDRESS>.1<IP_ADDRESS>.35162.30000015050317233592200000046',
    SeriesInstanceUID: '<IP_ADDRESS>.1<IP_ADDRESS>.35162.19991231121912388973179<IP_ADDRESS>',
    wadoRsRoot: 'https://d33do7qe4w26qo.cloudfront.net/dicomweb'
  },
  fetchSegmentation: {
    StudyInstanceUID: '<IP_ADDRESS>.1<IP_ADDRESS>.35162.30000015050317233592200000046',
    SeriesInstanceUID: '1.2.276.0.7230<IP_ADDRESS>.296485376.8.1542816659.201008',
    SOPInstanceUID: '1.2.276.0.7230<IP_ADDRESS>.296485376.8.1542816659.201009',
    wadoRsRoot: 'https://d33do7qe4w26qo.cloudfront.net/dicomweb'
  }
}

Oops, sorry. This is the code I've already tested.
exConfig.fetchDicom = {
    StudyInstanceUID: '<IP_ADDRESS>.1<IP_ADDRESS>.35162.30000015050317233592200000046',
    SeriesInstanceUID: '<IP_ADDRESS>.1<IP_ADDRESS>.35162.19991231121912388973179<IP_ADDRESS>',
    wadoRsRoot: 'https://d33do7qe4w26qo.cloudfront.net/dicomweb'
};

exConfig.fetchSegmentation = {
    StudyInstanceUID: '<IP_ADDRESS>.1<IP_ADDRESS>.35162.30000015050317233592200000046',
    SeriesInstanceUID: '1.2.276.0.7230<IP_ADDRESS>.296485376.8.1542816659.201008',
    SOPInstanceUID: '1.2.276.0.7230<IP_ADDRESS>.296485376.8.1542816659.201009',
    wadoRsRoot: 'https://d33do7qe4w26qo.cloudfront.net/dicomweb'
};

@jlopes90  i copy your demo and tried it  again .  result seems still error . use the url like above。 you can scroll sag viewer to see the error, it may appear in about index 10/128 or index 118/128 。

In the volume view, you can see the errors more clearly. Figure 1 mpr is correct, while Figure 2 shows the error that occurred using Cornerstone. they are same source。

@l5769389 did you ever resolve your issue with segmentations displaying misaligned? I am having something similar.
@jlopes90 I have implemented your volume segmentation example (thank you - it's an excellent demo!) - The issue is occurring when I swap from loading in a dicom file from my machine to fetching from Orthanc.
When loading the base images from a local dicom, and request segments from Orthanc (or a local file), everything works as expected.
When I swap to obtaining base images from Orthanc, whether segments are local or from Orthanc, the segments are misaligned as below.
I believe something is wrong or lacking when using createImageIdsAndCacheMetaData for the base images.
Is there another way I can get those base images loaded in that would more closely replicate using a file, like retrieveInstance which works well for segmentations?

@steph603 I didn't find a solution。 Wait for the author to solve this problem

@steph603 I didn't find a solution。 Wait for the author to solve this problem

my co-worker now find the solution 。you can test:  @steph603 ,but it seems still error in 3d。

Update: We found a solution!
I'm aware of this PR that reversed the image IDs and that did seem to partially help, however, there was still something causing our segmentations to display incorrectly when base images were coming from Orthanc - like so:

We discovered that the order of the image ids was being scrambled when retrieving from Orthanc, and while the base images were displaying correctly, segmentations were not aligning.
The solution is to sort the image ids based on the Instance Number (0020,0013)
 const sortedInstances = Object.values(instances).sort((a,b) => b['00200013'].Value[0] - a['00200013'].Value[0])
in createImageIdsAndCacheMetaData like this:

Now our segments are displaying as expected:

I guess i'm gonna close this now that the issue is resolved


ESP32 example lighting-app with chip-tool

Problem
Cannot switch on LED using lighting-app on ESP32-DevKitC

I am using ESP32-DevKitC connected together with Linux Ubuntu 20.04LTS chip-tool or Android app chip-tool

chip-tool command with Randevouse BLE -> log cannot established bluetooth connection using USB dongle ASUS USB-BT500 on PC.
I am using USB bluetooth dongle because my laptop has older in-built bluetooth.
pairing with qrcode chip-tool text file
network search on MatterTest Wifi: notebook and ESP32 on same site

chip-tool command with Randevouse Wifi -> log is ok I got IPv4 and IPv6 address but now I don't know how to control LED ...
which command I need to use. ESP32 Node Id is 0x20.

Huawei P20 lite Android app chip-tool and ESP32-DevKitC
BLE connection i established and turning ON OFF Toggle is working.

ligthing app log with wifi parameters
line 255 I (18870) chip[DIS]: Advertise operational node B2A71D38322AD529-0000000000000020
so my Node ID is 0x20 hex 32 dec, my IPv4 is <IP_ADDRESS>:5540 I can see clusters and endpoints in the log.
I also searched some examples. But is no working for me. Bluetooth fail.
Announcing Matter on ESP32
Announcing Matter on ESP32 my log
Maybe I found one problem. I needed to install manually: pip install deprecation
This example also not works. Command ./out/debug/chip-tool pairing bypass not exist.
Getting Started with Connected Home over IP (CHIP](https://codelabs.developers.google.com/codelabs/chip-get-started#6)
So I have question. How can I control my LED only trough wifi connection? Which command form chip-tool on PC side I have to use? I am using TE8/rc3 tag and esp-idf v4.4. Thank you.

I'm also trying to use the lighting app with esp32 but when I try to connect to it fails:

These error messages were when trying to "Commission with IP address" through the device address.
I was successful with google codelabs, but I'm not able to demo with the latest version.
@joskra joskra did you solve it?


Change starthunt separator to |.

This frees "," to be used in hunt questions.

The period at the end of the commit comment made me think that |. was the delimiter...

Is that necessary? You don't need to use commas as grammar doesn't really matter in this. I'd rather keep it as it is because this is the standard for commands.

I figure it's not that much necessary now that https://xfix.github.io/scavengers/ exists (it's a huge, huge, hack however). Weebl (member of GP team as well, so this may have something to do with it) proposed this change in Scavengers room staff PM, and it was agreed on by the staff, because not being to use comma sometimes is an annoyance requiring rewritting an entire question.
Consistency is important, I agree, but here the enforcal of consistency makes things more annoying. I'm aware that Showdown commands are using colons. The difference however is that /starthunt (and /startofficialhunt) unlike literally every other command accepts plain text as non-last argument.

Looking at change gave me an idea. How about keep , as the default (meaning in help and such) but give priority to |. That way if there is a rare question with a comma, the staff can use the pipe.
So you just need to change one line, line 37, to var targets = (target.indexOf('|') > -1) ? target.split('|') : target.split(',');

@TheImmortal I don't see why not, done.


[Feature Request] Allow k8s to discover ingress resources

Similar to how dynamic targets can be discovered from pods, endpoints and services, it'd be nice to have RDS discover ingress resources as well. The result would be an FQDN with optional set of IP (if resolved by the RDS server).

Just for the record, ingress's status object is same as service's status object. We can probably just reuse most of the code after some refactoring.
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#ingress-v1beta1-networking-k8s-io

Yes, in fact, this status is copied from an underlying LB service by the ingress controller (e.g. [1]).
However, I think we still need to know (and pass to the client) the spec.rules[*].host to build the correct HTTP host header.
[1] https://github.com/kubernetes/ingress-nginx/blob/3eafaa35a171e2d91d75690461ef45e721411aec/internal/ingress/status/status.go#L237

However, I think we still need to know (and pass to the client) the spec.rules[*].host to build the correct HTTP host header.

That's an interesting detail. Thanks @networkop.
There are two interesting problems:

We need to have a way to transfer the host information from ingress definition to the HTTP probe. We can probably use an internal/private label to achieve that, say something like _cloudprober_http_host.

How to handle multiple hosts in ingress definition. Is it common to have multiple hosts in an ingress definition?

We can probably use an internal/private label to achieve that, say something like _cloudprober_http_host.

Yeah, I think something like that should work and it's fairly easy to add.

How to handle multiple hosts in ingress definition. Is it common to have multiple hosts in an ingress definition?

This may not be common but it's definitely possible and even mentioned in the offical k8s ingress docs.
Another questions is how to do DNS resolution for these hosts. The most straigh-forward way is to do it locally on the client, based on information provided in Resource.IP as collected from Ingress.status.LoadBalancer. However, this may result in false negatives in certain situations. If a user relies on external DNS integration and this integration fails for some reason (e.g. IAM permissions changed), then Ingress will not be accessible but cloudprober will continue reporting it as healthy.

This will be really good if cloudprober can discover ingress and then provide the golden signals from those ingress.This will be one of the killer feature of cloudprober if can be implemented

@infa-kparida thanks for the input. Yes, we are planning to add support for the "ingress" resource type.
I've not yet figured out how to name targets for multiple host rules within an ingress, for example, we can do:
<ingress_name>_<host_fqdn> or just <host_fqdn>
I guess second option is cleaner, though I think we should provide a way to identify which ingress that particular host belongs to.
Let me know if you have any opinions on that.
Also, we recently added special handling for the target's 'fqdn' label; if present, it becomes the HTTP host header for the probe:
https://github.com/google/cloudprober/blob/4bdceab3d43a5e22d1dc19649700f12d65cc5652/probes/http/request.go#L62
We can use this feature and automatically add 'fqdn' label to ingress targets if not present already.

We can probably use an internal/private label to achieve that, say something like _cloudprober_http_host.

Yeah, I think something like that should work and it's fairly easy to add.

How to handle multiple hosts in ingress definition. Is it common to have multiple hosts in an ingress definition?

This may not be common but it's definitely possible and even mentioned in the offical k8s ingress docs.
Another questions is how to do DNS resolution for these hosts. The most straigh-forward way is to do it locally on the client, based on information provided in Resource.IP as collected from Ingress.status.LoadBalancer. However, this may result in false negatives in certain situations. If a user relies on external DNS integration and this integration fails for some reason (e.g. IAM permissions changed), then Ingress will not be accessible but cloudprober will continue reporting it as healthy.

I think for DNS resolution we don't have to depend on the IP provided in the resource; we can let system resolve the IP address. There is a config option for that (though probably not that clear): resolve_first. If resolve_first is not configured, we use system's DNS resolver.

I think <ingress_name>_<host_fqdn> or <ingress_name>_<index> would do, as you can have multiple unique targets defined in a single ingress resource.
Also @manugarg , I was thinking about implementing this locally but then I noticed you've added it to the next milestone. I'm happy to help with the implementation or testing to help speed things up, so please let me know if you need any help.

Thanks @networkop. I had started a change some time back. I'll try to finish it in a couple of days (it will mostly get submitted around Sep 08 though). I'll let you know how it goes.

Thanks @networkop. I had started a change some time back. I'll try to finish it in a couple of days (it will mostly get submitted around Sep 08 though). I'll let you know how it goes.

I was over-optimistic to think that I'll get it done over the long weekend :) I've the change out for review (internally) now. It will take a few more days I think.

Alright, #469 adds support for ingress resources.
Following example in the test shows how resources end up getting named and can be filtered using labels:
https://github.com/google/cloudprober/blob/928d3def650642b3fcf1ef845ffd19316a241d7d/rds/kubernetes/ingresses_test.go#L88
Ingress resources get the following two labels:
"fqdn"         : is set to the "host" in the ingress rule.
"relative_url" : is set to the "path" in the ingress rule.

@networkop and @infa-kparida, please let me know if you have any thoughts on it.

Great, thanks @manugarg , I'll give it a spin in the next few days and let you know.

Hi @manugarg , here are a few issues I've picked up so far:

RDS now needs and updated set of RBAC rules:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  annotations:
    rbac.authorization.kubernetes.io/autoupdate: "true"
  labels:
  name: rds-reader
rules:
- apiGroups: [""]
  resources: ["*"]
  verbs: ["get", "list"]
- apiGroups:
  - extensions
  - "networking.k8s.io" # k8s 1.14+
  resources:
  - ingresses
  - ingresses/status
  verbs: ["get", "list"]

URL is malformed when the client uses custom surfacer.prometheus_surfacer.metrics_prefix. For example if the prefix is set to cloudprober_, the URL becomes: http://cloudprober_google.com

HTTP path gets appended to the URL incorrectly. E.g. if I have an ingress with path /download, the URL becomes: http://google.com__download

another issue is that the URL that gets built and the client tries to resolve is in the format ingressName_ingressHostname, e.g. my-ingress_google.com

seems like the above DNS resolution issues are fixed with http_proxy.resolve_first: true

Thanks a lot for checking @networkop.

RDS now needs and updated set of RBAC rules:

Yeah, this is expected. I'll update the document.

URL is malformed when the client uses custom surfacer.prometheus_surfacer.metrics_prefix. For example if the prefix is set to cloudprober_, the URL becomes: http://cloudprober_google.com

I didn't get this one. This prefix is added to the metric names. Which URL is this?

HTTP path gets appended to the URL incorrectly. E.g. if I have an ingress with path /download, the URL becomes: http://google.com__download

another issue is that the URL that gets built and the client tries to resolve is in the format ingressName_ingressHostname, e.g. my-ingress_google.com

So both of these issues were supposed to be resolved by target labels. HTTP probe should use "fqdn" and "relative_url" labels, which are added by RDS automatically ("fqdn" label is used for URL host as well as host header).
https://github.com/google/cloudprober/blob/928d3def650642b3fcf1ef845ffd19316a241d7d/probes/http/request.go#L71
Just to confirm, you tried with cloudprober head, right? Not just the ingress change.
I'll investigate more. Thanks a lot for giving it a try. That's very helpful.

@networkop I tried running an HTTP probe like this:
probe {
  name: "pod-to-ingress"
  type: HTTP

  targets {
    rds_targets {
      resource_path: "k8s://ingresses"
      filter {
        key: "namespace"
        value: "default"
      }
    }
  }

  additional_label {
    key: "fqdn"
    value: "@target.label.fqdn@"
  }

  additional_label {
    key: "probeurl"
    value: "@target.label.relative_url@"
  }

  http_probe {}
}

Where ingress is:
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: rds-ingress
spec:
  rules:
  - host: foo.bar.com
    http:
      paths:
      - path: /health
        backend:
          serviceName: cloudprober-test
          servicePort: 9313
  - host: prometheus.bar.com
    http:
      paths:
      - path: /
        backend:
          serviceName: cloudprober-test
          servicePort: 9313

With this I get  logs like this:
2020-09-16 12:17:31.005 PDT
Target:foo.bar.com, URL:http://foo.bar.com/health, http.doHTTPRequest: Get "http://foo.bar.com/health": dial tcp: lookup foo.bar.com on <IP_ADDRESS>:53: no such host
Expand all | Collapse all{
 insertId: "1sxfsuig1rbeq6l"
 logName: "projects/google.com:bbmc-stackdriver/logs/cloudprober.pod-to-ingress"
 receiveTimestamp: "2020-09-16T19:17:41.024229028Z"
 resource: {…}
 severity: "WARNING"
 textPayload: "Target:foo.bar.com, URL:http://foo.bar.com/health, http.doHTTPRequest: Get "http://foo.bar.com/health": dial tcp: lookup foo.bar.com on <IP_ADDRESS>:53: no such host"
 timestamp: "2020-09-16T19:17:31.005359502Z"
}

Notice that the URL is correct here.
And metrics look like this (notice additional labels here):
total{ptype="http",probe="pod-to-ingress",dst="rds-ingress_foo.bar.com__health",fqdn="foo.bar.com",probeurl="/health"} 25<PHONE_NUMBER>212
total{ptype="http",probe="pod-to-ingress",dst="rds-ingress_prometheus.bar.com",fqdn="prometheus.bar.com",probeurl="/"} 25<PHONE_NUMBER>212
success{ptype="http",probe="pod-to-ingress",dst="rds-ingress_foo.bar.com__health",fqdn="foo.bar.com",probeurl="/health"} 0<PHONE_NUMBER>212
success{ptype="http",probe="pod-to-ingress",dst="rds-ingress_prometheus.bar.com",fqdn="prometheus.bar.com",probeurl="/"} 0<PHONE_NUMBER>212
latency{ptype="http",probe="pod-to-ingress",dst="rds-ingress_foo.bar.com__health",fqdn="foo.bar.com",probeurl="/health"} 0.000<PHONE_NUMBER>212
latency{ptype="http",probe="pod-to-ingress",dst="rds-ingress_prometheus.bar.com",fqdn="prometheus.bar.com",probeurl="/"} 0.000<PHONE_NUMBER>212
timeouts{ptype="http",probe="pod-to-ingress",dst="rds-ingress_foo.bar.com__health",fqdn="foo.bar.com",probeurl="/health"} 0<PHONE_NUMBER>212
timeouts{ptype="http",probe="pod-to-ingress",dst="rds-ingress_prometheus.bar.com",fqdn="prometheus.bar.com",probeurl="/"} 0<PHONE_NUMBER>212

hm.. maybe they were false positives. Let me retest tomorrow and report back.

it looks like it was false positives. I may have had DNS not fully functioning at one point and I looked at dst and assumed that's what was getting resolved. So far I've reverted back all of the workarounds I put in place, including the metrics_prefix and everything seems to be working fine.

Thanks so much for confirming @networkop.
I'll go ahead mark this issue closed. We can re-open this or file another one if we find a problem with the ingress resources discovery.


Supports CreatedTime and UpdatedTime in Record.

Supports CreatedTime and UpdatedTime in Record.
This commit mainly aims to provide timestamp support when creating and updating a Record:

Adds CreatedTime and UpdatedTime in

proto definition
sql schema
gorm model definition

Modifies ToAPI and ToStorage to get the two timestamps work.

tests if the two fields can be properly transformed.

Updates the two fields when CreateRecord.

tests if the two fields are updated after the creation.

Updates the UpdateTime field when UpdateRecord.

tests if the UpdateTime field is updated after updating.

In addition, there are three minor changes:

To make the code structure more tidy, move TestMain from results_test.go to server_test.go
Solves a bug when comparing Error Code in UpdateRecord
Adjusts the indent in resources.proto

/hold
reviewable, waiting for #25

/hold cancel

/hold cancel

Unit tests failed because the newly merged PR  #34, therefore I ignored the updated_time and created_time field when testing watcher's behavior.

Unit tests failed because the newly merged PR  #34, therefore I ignored the updated_time and created_time field when testing watcher's behavior.


Add attending count

 Issue by artfuldev
Thursday Aug 18, 2016 at 15:55 GMT
Originally opened as https://github.com/artfuldev/devday/issues/45

From meetups API

 Comment by artfuldev
Thursday Aug 18, 2016 at 18:17 GMT

CORS is preventing the request for meetups

 Comment by artfuldev
Thursday Aug 18, 2016 at 18:32 GMT

http://www.meetup.com/meetup_api/docs/#cors

 Comment by artfuldev
Sunday Aug 21, 2016 at 17:17 GMT

Might not be able to do this by Monday

@artfuldev  this is almost done in the attendance_count branch.
One issue remaining is that the attendance count is coming only for one event although the network request is fired and the response comes for both the events that are live.


public pages: update navigation and footer

CR @javierarce

/cc @saleiva @carlostallon

<3

👍  Looks neat, but have a look to the hound warnings.

retest this, please

Hey guys, we were testing a new Jenkins Slave and we had to cancel your PR testing (#7077). So sorry about the inconveniences (you'll probably have to launch tests again)


[orc] add apache orc library

There is issue with my previous PR. https://github.com/Microsoft/vcpkg/pull/4226
I move from my master to a branch (there issue to create new PR for other bug)
I had a fix since new version of protobuf remove protobug-lite

LGTM, thanks for the PR!


Feature: Display basic preview in Details pane

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #12564...

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[x] Did you implement any design changes to an existing feature?

[x] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Select Office file
Display details pane
Confirm basic thumbnail is shown
Switch to preview pane
Confirm the full preview is displayed

Screenshots (optional)
Add screenshots here.

Hey, it's been a while, hope all is well. I just wanted to say this is a great idea, will significantly improve loading times when a user wants a simple overview. It might be worth adding a shortcut to switch between the two, though, to make it easier for powerusers to switch without using the mouse. Maybe a shortcut like Alt+shift+p to access preview directly.


Add Body Style Setting Props

[x] I'm sure this does not appear in the issue list of the repository

Basic Info
What are the similar cases of this feature
Ant Design - Modal - bodyStyle
What problem does this feature solve?
custom body style of modal component

🚀

support #1303


5.2

@taylorotwell  Base AMI's with php7 throw an error without a fully qualified namespace.

Thanks, but we won't be accepting any changes to this repo because it's read only. Also, Laravel 5.2 does not get bug fixes anymore anyway. We're likely to accept your change to 5.1 though, and then we'll merge it up into 5.3 and master automatically.
Please close this. :)

Thank you for the update Graham.


Arrow shafts

Arrow shafts can be bought in the Ranging Guild so it would be appropriate if they get added to /buy

Arrow shafts can be bought in the Ranging Guild so it would be appropriate if they get added to /buy

I see your point. but then we'd have to add every item from every guild to </buy:0> and that would take the point of skilling out of the bot.

Correct, a LOT more items need to be added to buy, most notably high level runes. The fact that so many items are missing is no argument to avoid making a start to fixing it

Refer to Magna's comment on this pr : https://github.com/oldschoolgg/oldschoolbot/pull/3177
Short discussion about a similar thing in Devs:
https://discord.com/channels/342983479501389826/648196527294251020/1087520937978642522
Tldr: Magna would want purchase limits imposed on items and some items maybe considered clutter (although not directly related to this issue)


An error occurred in the linux

var gulp=require('gulp');
var miniCss = require('gulp-cssnano');
var clean = require('gulp-clean');

gulp.task('clean', function() {
    return gulp.src('dist', {
            read: false
        })
        .pipe(clean());
});

in the linux error occurred ,but windows have no the problem
[15:50:37] Using gulpfile /jenkins/workspace/Dev_WEB/gulpfile.js
[15:50:37] Starting 'build'...
[15:50:37] Starting 'clean'...
[15:50:37] 'clean' errored after 4.8 ms
[15:50:37] TypeError: Cannot read property 'length' of undefined
    at flattenGlob (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-stream/node_module                   s/glob2base/index.js:9:25)
    at setToBase (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-stream/node_modules/                   glob2base/index.js:48:12)
    at module.exports (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-stream/node_mod                   ules/glob2base/index.js:56:19)
    at Object.gs.createStream (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-stream/                   index.js:34:42)
    at Object.gs.create (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-stream/index.                   js:68:42)
    at Gulp.src (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/vinyl-fs/lib/src/index.js:33:23)
    at Gulp.<anonymous> (/jenkins/workspace/Dev_WEB/gulpfile.js:490:17)
    at module.exports (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/jenkins/workspace/Dev_WEB/node_modules/gulp/node_modules/orchestrator/index.js:214:10)

We're having the same issue here:
https://github.com/jhipster/generator-jhipster/issues/4016
Broke everything, for a lot of people :-(
Why don't use fixed dependencies? That was bound to happen.

Same problem. Steps to reproduce with clean setup:
# new user

sudo adduser --disabled-password --gecos "" username
sudo su - nanotest

# node

git clone https://github.com/basherpm/basher.git ~/.basher
echo 'export PATH="$HOME/.basher/bin:$PATH"' >> ~/.bash_profile
echo 'eval "$(basher init -)"' >> ~/.bash_profile

. ~/.bash_profile

basher install isaacs/nave

nave use stable

npm install --global npm
npm install --global gulp-cli

# project

cd
mkdir tmp
cd tmp
mkdir project
cd project
mkdir src css
echo "h1 { font-weight: bold }" > src/style.css

cat << EOF > package.json
{
  "name": "project",
  "version": "1.0.0",
  "description": "Test gulp-cssnano",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "gulp": "^3.9.1",
    "gulp-cssnano": "^2.1.2"
  }
}
EOF

npm install

cat << EOF > gulpfile.js
var gulp = require('gulp');
var cssnano = require('cssnano');

gulp.task('default', function() {
  return gulp.src('src/*.css');
});
EOF

# run

gulp

Output:
nanotest@layoone ~/tmp/project $ gulp
(node:18193) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[12:43:19] Using gulpfile ~/tmp/project/gulpfile.js
[12:43:19] Starting 'default'...
[12:43:19] 'default' errored after 4.61 ms
[12:43:19] TypeError: Cannot read property 'length' of undefined
    at flattenGlob (/home/nanotest/tmp/project/node_modules/glob2base/index.js:9:25)
    at setToBase (/home/nanotest/tmp/project/node_modules/glob2base/index.js:48:12)
    at module.exports (/home/nanotest/tmp/project/node_modules/glob2base/index.js:56:19)
    at Object.gs.createStream (/home/nanotest/tmp/project/node_modules/glob-stream/index.js:34:42)
    at Object.gs.create (/home/nanotest/tmp/project/node_modules/glob-stream/index.js:68:42)
    at Gulp.src (/home/nanotest/tmp/project/node_modules/vinyl-fs/lib/src/index.js:33:23)
    at Gulp.<anonymous> (/home/nanotest/tmp/project/gulpfile.js:5:15)
    at module.exports (/home/nanotest/tmp/project/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/home/nanotest/tmp/project/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/home/nanotest/tmp/project/node_modules/orchestrator/index.js:214:10)

The same problem.

The problem seems to come from reduce-css-calc which is indirectly used, see here:
https://github.com/MoOx/reduce-css-calc/issues/13

Check it https://github.com/gulpjs/gulp/issues/1768

This has been fixed upstream, delete node_modules and reinstall should work now

Why don't use fixed dependencies? That was bound to happen.

So that we can benefit from features and bug fixes that our dependencies have. Indeed, it's unfortunate that sometimes this can lead to unexpected breaks, but a critical security issue was patched in cssnano by virtue of the semver promise. Just happy that this was resolved quickly by all parties involved. 🎉

Yeah. In this case, a critical security fix in one of the postcss-calc libraries introduced a major bug, and the developer decided to wait for his upstream to fix the bug as he deemed the security issue to be more severe.


feature: update example app to use 'discoveryFeatureLoader'

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Shall we start by documenting this as an experimental feature in the docs?
It could also be a breaking change if adopters are conditionally enabling some plugins under certain conditions.


KYLIN-4998 Remove partition dimension dynamically in cuboid routing to accelerate query

… query
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] If this change need a document change, I will prepare another pr against the document branch
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

:exclamation: No coverage uploaded for pull request base (kylin-on-parquet-v2@2edeaea). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1658   +/-   ##
======================================================
  Coverage                       ?   23.80%
  Complexity                     ?     4649
======================================================
  Files                          ?     1158
  Lines                          ?    66935
  Branches                       ?     9870
======================================================
  Hits                           ?    15935
  Misses                         ?    49319
  Partials                       ?     1681

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edeaea...f0cb8cf. Read the comment docs.


expectOne: Spec has no expectations

When testing data service using createHTTPFactory I see errors in the console saying that the test has no expectations. Looks like expectOne is not connected to jasmine.
Simple fix would be to add expect(true).toBe(true); to expectOne but I am not sure if it's the correct one.
Tried with spectator 3.3.0 but it behaved same with the older version.

We fixed that by monkey patching console.error and exclude this type of error.

https://github.com/dfederm/karma-jasmine-html-reporter/issues/20

ehhhh, monkeypatching console.error doesn't look like a good solution either :-(
What do you think about adding expect(true).toBe(true) to this place? https://github.com/NetanelBasal/spectator/blob/7ae901860704ce50f26f7753b6d6101e83761b2b/projects/spectator/src/lib/http.ts#L52
Using expectOne is like running expect so ⤴ could workaround the issue.

Sounds like a good idea.


Bqrttdev

Add Bigquery table into the GCP inventory, which enables the model to get expiration Time data that would be used in the Bigquery retention.

Please rename the PR name.


Fix #60 - use ignoreBlur flag to avoid hiding suggests when clicking one

Just implemented the ignoreBlur flag as done in react-autocomplete, but added onMouseOut to restore the ignoreBlur flag.
The only piece this misses is if a user starts a mousedown on a suggestion, and releases the mouse outside of geosuggest. I think it'd be appropriate to use a one-time mouseup listener on document.body and respond based on it's target, but can see how that'd be debatable. Regardless, I think this is a worthwhile patch -- especially if you don't use the css transition when hiding the suggestions. May also be able to remove the 100ms timeout in hideSuggests.
Sidenote: I wanted to use this fork in my app, but since .gitignore ignores module and .npmignore ignores src, couldn't see how it could be done (other than perhaps npm install <relative/path>?), so I made a master-pkg branch and removed module from .gitignore -- is there something I'm missing?
Thanks for the library!

Thanks for the PR! Seems to make a lot of sense. :)
Ignoring the build files (module) in the git repo is on purpose. Ignoring the src when installing with npm was also on purpose as I couldn’t think of a reason to put it in there, when the entry point is the module folder. Using the path could be a solution for that case. But as it is not the “normal” use case, I would like to keep it as it is now. Is that okay?

Released in 1.16.0.

Awesome!
Definitely makes sense to ignore those files for those purposes, I just couldn't figure out a way to install my fork in my app without publishing it to npm. I usually just install from github until a PR gets merged (npm install git://github.com/mponizil/react-geosuggest). Not an issue after the release, but still would like to know for the future -- is there another way I could have done this or something I'm missing?

@mponizil What I do is just create a new branch in my fork (ex: "build" branch) with the built files checked in and then reference this branch in my package.json (you can do this by setting the version with a # in it, like username/repo#branch).
Ex:
"dependencies": {
  "react-geosuggest": "mponizil/react-geosuggest#build"
}

This is better than having @ro-ka keep built files checked into master :smile:

@idolize ok cool that's what I ended up doing, just wasn't sure if I was missing something obvious.


Default video resolution

Is there anyway to tell the telegram to upload a video with its original resolution?

When I use this code to send  a video, the video quality on telegram is so low and awkward.

If you do not want the quality of the video to change, you must send the video as a document.

If you do not want the quality of the video to change, you must send the video as a document.

Videos aren't comressed server-side for now. If you are using inputMessageVideo then the file is sent in the exactly original form.
Are you using the latest TDLib version?

Videos aren't comressed server-side for now. If you are using inputMessageVideo then the file is sent in the exactly original form.
Are you using the latest TDLib version?

But what If I want to send it as a video and specify the width and video but still low resolution?

But what If I want to send it as a video and specify the width and video but still low resolution?

When I send a video I never specify the resolution and on the client side the video is displayed as in the original. Do you use mp4?

When I send a video I never specify the resolution and on the client side the video is displayed as in the original. Do you use mp4?

Probably related to https://github.com/tdlib/td/issues/1379

Probably related to https://github.com/tdlib/td/issues/1379

@zevlg Animations sent via inputMessageAnimation are compressed by the server, but videos sent via inputMessageVideo are never altered. This shouldn't be related.

@zevlg Animations sent via inputMessageAnimation are compressed by the server, but videos sent via inputMessageVideo are never altered. This shouldn't be related.

@zyadomer999 Which TDLib version are you using?

@zyadomer999 Which TDLib version are you using?

Dears, the problem was due to I used a format different from MP4, thank you for your help.
But could you please tell me what type and codec the video should exactly be for the telegram to create automatic thumbnail and support streaming?

Dears, the problem was due to I used a format different from MP4, thank you for your help.
But could you please tell me what type and codec the video should exactly be for the telegram to create automatic thumbnail and support streaming?

Thumbnails are generated only for videos less than 10 megabytes. Most codecs, which can be found on mobile devices, are supported.
Streaming support is not about codec, it is about data layout within the file. Video channel must be intermixed with audio channel for better streaming and moov atom must be at the beginning or at the end of the file.

Thumbnails are generated only for videos less than 10 megabytes. Most codecs, which can be found on mobile devices, are supported.
Streaming support is not about codec, it is about data layout within the file. Video channel must be intermixed with audio channel for better streaming and moov atom must be at the beginning or at the end of the file.

Thumbnails are generated only for videos less than 10 megabytes. Most codecs, which can be found on mobile devices, are supported.
Streaming support is not about codec, it is about data layout within the file. Video channel must be intermixed with audio channel for better streaming and moov atom must be at the beginning or at the end of the file.

For my info, does Telegram server supports fragmented mp4 with moof atoms(instead of moov at the beginning), so data can be streamed before video capturing is finished?

Thumbnails are generated only for videos less than 10 megabytes. Most codecs, which can be found on mobile devices, are supported.
Streaming support is not about codec, it is about data layout within the file. Video channel must be intermixed with audio channel for better streaming and moov atom must be at the beginning or at the end of the file.

For my info, does Telegram server supports fragmented mp4 with moof atoms(instead of moov at the beginning), so data can be streamed before video capturing is finished?

@zevlg Streaming is entirely a client-side feature. Cideo can't be sent in a message until it is fully uploaded. Some clients can support streaming of moof videos.

@zevlg Streaming is entirely a client-side feature. Cideo can't be sent in a message until it is fully uploaded. Some clients can support streaming of moof videos.

Dear with the streaming I meant that some videos can be played without downloading them while other you have to download the entire video before you can play it. Is there any relation between the type of the video and this feature?

Dear with the streaming I meant that some videos can be played without downloading them while other you have to download the entire video before you can play it. Is there any relation between the type of the video and this feature?

And I answered that

Streaming support is not about codec, it is about data layout within the file. Video channel must be intermixed with audio channel for better streaming and moov atom must be at the beginning or at the end of the file.

So this is about the way video data is placed in the container.
Apps also use video,supports_streaming flag set by video sender as a hint, whether video needs to be tried to play without full downloading.

And I answered that

Streaming support is not about codec, it is about data layout within the file. Video channel must be intermixed with audio channel for better streaming and moov atom must be at the beginning or at the end of the file.

So this is about the way video data is placed in the container.
Apps also use video,supports_streaming flag set by video sender as a hint, whether video needs to be tried to play without full downloading.

Thanks I got your point

Thanks I got your point


Rework makefile

I still have to merge your latest changes into the PR.

@stweil you just cherrypicked a single commit from the above. This makes keeping this PR up much harder for me. Please consider merging the whole thing.

BTW, looking at the current problems with pillow (where some modules already moved to >=6.2 whereas others still hold at ==5.4.1) and tensorflow (where some modules will want to use tensorflow-gpu which is mutually exclusive with tensorflow): I don't think we can ever have piece of mind if we try to stuff everything into a single venv. But it sure helps at least trying!
I also added a clean target. I think one way to go would be modifying the generated venv for particular workflows and storing the results under different venvs.

Oh, and one more thing: would you mind adding my workflow makefilization? I can think of a good way to incorporate this...

The old code did not work on MacOS.

Could you please post the output of the failure?

Why is that more portable? The find syntax used in printf is perfectly POSIX.

Maybe, but BSD find which is provided on MacOS does not support it. See the manual.

The old code did not work on MacOS.

Could you please post the output of the failure?

The old code used find -printf which is unsupported by BSD find.

On the contrary: I specifically avoided xargs because submodules very likely will have too many files to fit on one command line (due to the usual Unix kernel limit). This simply does not work. Besides, it is also slower: the files have to be stated twice to sort them.

The current submodules don't have too many files to cause a too long command line.
Yes, the new code is slower, but I don't think that it is time critical. It takes less than 4 seconds to touch all submodules.

Why is that more portable? The find syntax used in printf is perfectly POSIX.

Maybe, but BSD find which is provided on MacOS does not support it. See the manual.

The old code did not work on MacOS.

Could you please post the output of the failure?

The old code used find -printf which is unsupported by BSD find.

I see. This is really bad news.

On the contrary: I specifically avoided xargs because submodules very likely will have too many files to fit on one command line (due to the usual Unix kernel limit). This simply does not work. Besides, it is also slower: the files have to be stated twice to sort them.

The current submodules don't have too many files to cause a too long command line.

You bet! On my Ubuntu system, the limit (getconf ARG_MAX) is 8388608 bytes, but it can be as low as 131072 bytes. We already have ocrd_olena with filename entries totaling 1893996 bytes.

Yes, the new code is slower, but I don't think that it is time critical. It takes less than 4 seconds to touch all submodules

Granted. But we need an approach that does not just fail any day anywhere.
I will come up with something based on bash arrays. MacOS/BSD does have bash?

Maybe touch -r $$(find $@ -type f -newer $@) would already suffice? We only need to ensure that the update will trigger (and it's unlikely files in the module directory will have been updated at multiple different times all newer than the module directory itself, given that we makefile-manage them like that).

MacOS/BSD does have bash?

The latest MacOS update switched from bash (5.0.11) to zsh, but bash is still there.

Maybe touch -r $$(find $@ -type f -newer $@) would already suffice?

That's a good idea. But it must be extended a little bit to find at least one file or directory.

MacOS/BSD does have bash?

The latest MacOS update switched from bash (5.0.11) to zsh, but bash is still there.

That reminds me that we forgot to set SHELL = /bin/bash since we are already using $(...) for command substitution. Or rather keep POSIX and use backticks?

Maybe touch -r $$(find $@ -type f -newer $@) would already suffice?

That's a good idea. But it must be extended a little bit to find at least one file or directory.

True. Exactly one.

Feel free to rebase this PR on my latest Git master, remove or squash commits as needed and force-push it again.

Or rather keep POSIX and use backticks?

No. Shell code checkers suggest to replace all backtick shell code.

Feel free to rebase this PR on my latest Git master, remove or squash commits as needed and force-push it again.

I decided to force-push here (to have a linear PR) but then merge. IMO this PR is ready for adoption.


[Bug]: Failed: /home/runner/work/vllm/vllm/csrc/custom_all_reduce.cuh:310 'invalid argument'

Your current environment
The output of `python collect_env.py`

Collecting environment information...
PyTorch version: 2.2.1+cu118
Is debug build: False
CUDA used to build PyTorch: 11.8
ROCM used to build PyTorch: N/A
OS: EulerOS 2.0 (SP2) (x86_64)
GCC version: (GCC) 8.2.0
Clang version: Could not collect
CMake version: version <IP_ADDRESS>
Libc version: glibc-2.17
Python version: 3.8.18 (default, Jun 13 2024, 08:22:35)  [GCC 8.2.0] (64-bit runtime)
Python platform: Linux-4.18.0-<IP_ADDRESS>.h1136.eulerosv2r9.x86_64-x86_64-with-glibc2.17
Is CUDA available: True
CUDA runtime version: 11.8.89
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: Tesla V100-SXM2-32GB
GPU 1: Tesla V100-SXM2-32GB
GPU 2: Tesla V100-SXM2-32GB
GPU 3: Tesla V100-SXM2-32GB
Nvidia driver version: 470.57.02
cuDNN version: /usr/local/cuda-10.1/targets/x86_64-linux/lib/libcudnn.so.7.6.5
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                72
On-line CPU(s) list:   0-71
Thread(s) per core:    2
Core(s) per socket:    18
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 85
Model name:            Intel(R) Xeon(R) Gold 6151 CPU @ 3.00GHz
Stepping:              4
CPU MHz:               3200.000
BogoMIPS:              6007.32
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              1024K
L3 cache:              25344K
NUMA node0 CPU(s):     0-17,36-53
NUMA node1 CPU(s):     18-35,54-71
Versions of relevant libraries:
[pip3] numpy==1.24.4
[pip3] nvidia-nccl-cu11==2.19.3
[pip3] pytorch-crf==0.7.2
[pip3] torch==2.2.1+cu118
[pip3] transformers==4.41.2
[pip3] triton==2.2.0
[pip3] vllm_nccl_cu11==<IP_ADDRESS>.4.0
[conda] Could not collect
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.1
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	GPU1	GPU2	GPU3	mlx5_0	CPU Affinity	NUMA Affinity
GPU0	 X 	SYS	NV1	SYS	NODE	0-17,36-53	0
GPU1	SYS	 X 	NV2	NV2	SYS	18-35,54-71	1
GPU2	NV1	NV2	 X 	NV1	SYS	18-35,54-71	1
GPU3	SYS	NV2	NV1	 X 	SYS	18-35,54-71	1
mlx5_0	NODE	SYS	SYS	SYS	 X
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
🐛 Describe the bug
When I try to setup the api using vllm:
CUDA_VISIBLE_DEVICES=0,1 python -m vllm.entrypoints.openai.api_server --model="/opt/huawei/dataset/data_dir/model/checkpoints/llms/Qwen_Qwen1.5-72B-Chat-GPTQ-Int4" --tensor-parallel-size=2 --max-model-len=4000 --port=5001
I am having the error below:
INFO 06-18 06:28:40 model_runner.py:980] CUDA graphs can take additional 1~3 GiB memory per GPU. If you are running out of memory, consider decreasing gpu_memory_utilization or enforcing eager mode. You can also reduce the max_num_seqs as needed to decrease memory usage.
INFO 06-18 06:28:58 custom_all_reduce.py:246] Registering 5635 cuda graph addresses
Failed: Cuda error /home/runner/work/vllm/vllm/csrc/custom_all_reduce.cuh:310 'invalid argument'
I also tried to uninstall vllm_nccl_cu11 as i saw a post saying that i might need to remove one if it exists two nccl, but it's helpful for my issue.

Nvidia driver version: 470.57.02
OS: EulerOS 2.0 (SP2) (x86_64)

You have a very old driver, and an OS that I don't know.

Nvidia driver version: 470.57.02
OS: EulerOS 2.0 (SP2) (x86_64)

You have a very old driver, and an OS that I don't know.

@youkaichao Thank you for your reply. Sadly, i am not able to change the driver and the OS. Is it possible that there are other reasons that caused the problem?

470.57.02 is a too old driver that I can answer nothing about. please talk with your admin about the machine.

Nvidia driver version: 470.57.02
OS: EulerOS 2.0 (SP2) (x86_64)

You have a very old driver, and an OS that I don't know.

@youkaichao Thank you for your reply. Sadly, i am not able to change the driver and the OS. Is it possible that there are other reasons that caused the problem?

Try use cuda-compat to soft "upgrade" your driver version so you can run CUDA 12 on driver version 470.


APP-1140: Reports Coverage percentage on github repo

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@10ec7db). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev      #34   +/-   ##
======================================
  Coverage       ?   89.49%
======================================
  Files          ?       39
  Lines          ?      514
  Branches       ?       32
======================================
  Hits           ?      460
  Misses         ?       42
  Partials       ?       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ec7db...69d1e3c. Read the comment docs.


Example in the README: 'Functional' object has no attribute '_layers'

Hello
I simply run the example in the [Readme]('Functional' object has no attribute '_layers') in the Google Colab, but I get the following error:
AttributeError                            Traceback (most recent call last)
<ipython-input-13-5a0e4925fe5b> in <module>()
      3 keract_inputs = x_train[10:11]
      4 keract_targets = y_train[10:11]
----> 5 activations = get_activations(model, keract_inputs)
      6 all_layers=activations.keys()
      7

1 frames
/usr/local/lib/python3.7/dist-packages/keract/keract.py in _get_nodes(module, nodes, output_format, nested, layer_names, depth)

AttributeError: 'Sequential' object has no attribute '_layers'

I think it's because of the last update of Keras. Would you fix it?
I Also checked keract-nightly but I got the same error.

https://github.com/philipperemy/keract/commit/773e1a683067c626daf879e5353915e31cdcd7d7 fixed in this commit.

Pushed to 4.5.0


ENH: Missing test for Stairs.logical_xor for Stairs over float domain

Describe the solution you'd like
Belongs here:
https://github.com/staircase-dev/staircase/blob/00da1209eec21d3ea11f0f18f538637d2bae5ecf/tests/test_floats/test_floats_logical.py
Docs:
https://www.staircase.dev/en/latest/reference/api/staircase.Stairs.logical_xor.html
Is tested with a Stairs and scalar operands but needs to be tested with two Stairs operands.

take


[Feature Request] Ability to query the workflow after its completed

Is your feature request related to a problem? Please describe.
It's nice to have workflow states that you can query after the workflow is done.  For example, there are internal values that I track in the workflow.  After each activity completes, I want set those values to indicate if state is passed around or the status of each activity.  It would be nice after the workflow is complete, that i'm able to query for those custom fields.
Describe the solution you'd like
After the workflow is complete, it would be nice to be able to query the final state of the query parameters.

I would also love to have this feature implemented at some point