How to acquire Android purchase data and data signature from InAppBillingPurchase for verification?

I'm definitely missing something here.  I don't see these properties available in the Purchase object.
Seems like maybe the overloading of PurchaseAsync to include the IInAppBillingVerifyPurchase implementation is the only flow?

See: https://jamesmontemagno.github.io/InAppBillingPlugin/SecuringPurchases.html

Hooked up to the overloaded function then. Thanks.


AKS offer: not able to select Node Size in WestUS

Description: Not able to select Node size from Azure Portal when selecting region WestUS.
Offer: WLS on AKS
Reproduce steps:

Open https://portal.azure.com/#create/oracle.20210620-wls-on-aks20210620-wls-on-aks from Azure portal.
Input resource group name and select region WestUS in Basics blade
Open AKS blade, the node size selection control is gray and not able to select size. See the screenshot.

Expected result: Node size should be able to select in WestUS.

Error observed in browser developer tools:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'zones')
    at BRszf-QjJduq.js:189:3328
    at Array.filter (<anonymous>)
    at BRszf-QjJduq.js:189:3172

Asked in https://stackoverflow.microsoft.com/questions/386260

Root cause: the recommendedSize "Standard_DS2_v2" is not available in West US.

WestUS is a region where no zones are defined for any of the disk/virtualmachine resources, this is the reason why the control is "disabled". The current scenario should result in an error state.
UI team has fixed the issue in Pull request 9467718: Size Selector BugFix - Repos (visualstudio.com).
The fix is live, close this issue.


fix logger.c snprintf compile error on centos 6.8

add #include <stdio.h> to fix error: implicit declaration of function ‘snprintf’

thanks! Would you mind telling me what platform/compiler/versions/etc you saw this on?

This is pushed into the 'next' branch. going to leave this open until release to prevent dupes.

Centos 6.8 and gcc


undefined symbol: __floatuntitf

struct table field defined:
long double sell() const {
if(direction == ORDER_SELL){
return (long double)0;
}else{
auto m = (uint128_t)pair << 64 | (uint64_t)price.amount;
return static_cast(m);
}
}
cmake compiled errors:
/usr/local/Cellar/eosio.cdt/1.6.1/opt/eosio.cdt/bin/wasm-ld: error: CMakeFiles/***.wasm.dir/src/dex.cpp.o: undefined symbol: __floatuntitf

what was the solution????

solution is easy.
you are should be check smartcontract for store types.
like in table uint128_t but you in code try put uint64_t
before put need prepare like uint128_t(value_64t_sample)


How to use custom PyTorch SuperResolution model in examples/SuperResolution.java

Description
Like the tensorflow example you gave, how can I use the pytorch model to complete this example？
References

https://github.com/deepjavalibrary/djl/blob/master/examples/src/main/java/ai/djl/examples/inference/sr/SuperResolution.java

@frankfliu Wait for you to answer this question...

@Lornatang
DJL support jit traced model. You can trace and save your custom model. See: https://docs.djl.ai/docs/pytorch/how_to_convert_your_model_to_torchscript.html
You can use DJL to load the saved torchscript model, change the example code: https://github.com/deepjavalibrary/djl/blob/master/examples/src/main/java/ai/djl/examples/inference/sr/SuperResolution.java#L115-L124
to
        Criteria<Image, Image> criteria =
                Criteria.builder()
                        .optApplication(Application.CV.IMAGE_ENHANCEMENT)
                        .setTypes(Image.class, Image.class)
                        .optModelPath(YOUR_MODEL_DIRECTOR)
                        .optModelName("YOUR_MODEL_NAME")
                        .optTranslator(new SuperResolutionTranslator())
                        .optProgress(new ProgressBar())
                        .build();


Fix crash with tf.image.resize if size is large

This PR tries to address the issue raised in 46914 where
tf.image.resize will crash if size is large, (implicitly
causes tf.keras.layers.UpSampling2D to crash).
This PR adds necessary shape overflow check to prevent
crash.
This PR fixes 46914.


[csgoserver] new executable not working

I just updated the csgoserver executable. Now it does not work anymore.

gs_csgo_ar@X:~$ ./csgoserver
fetching functions/core_functions.sh...OK
fetching functions/core_messages.sh...OK
gs_csgo_ar@X:~$ ./csgoserver start
gs_csgo_ar@X:~$ ./csgoserver stop
gs_csgo_ar@X:~$ ./csgoserver details

i also tried to remove all old function files. this also did not help

Will test now. Odd as I tested this not long ago

https://github.com/dgibbs64/linuxgsm/commit/b293da2bb75ead5da3d2316004a0ccd6d62b696f

Try now. should be fixed. For some reason core_getopt.sh was missing

issue related to #571

works like a charm! thanks a lot!

awesome closing this


Google Play Store crashes instantly

Running Android 12 and Using Version 2.01. Cleared storage for the Play Store and it still crashes every time. When I uninstalled Pixelify it started to work again. Reinstalling essentially disabled it again though I am able to install apps on my desktop through the Google Play website

Factory reset and reinstalled. I had the module install the pixel launcher vs Installing it myself and everything seems to work fine now.

Had to reinstall Magisk because I lost root for some odd reason. Reinstalled Pixelify and the Pixel Launcher through it and the Play Store is now refusing to work again. YASNAC says the device passes the Safteynet Attestation, when uninstalling Pixelify the Google Play Store launches without any issues

I am working to fix, hopefully it will be fixed on next version

This is fixed, if still facing some issues feel free to reopen this issue


Enable es6 for plopfile logic without transpilation

I wanted to use plop with es6 but i couldn't,
Liftoff is exactly what you need for this project.

Liftoff looks interesting... But it's not necessary. I just use the babel-register require hook and all my stuff can be in ES6

actually, I just looked into this a bit, and I believe it's as simple as adding --harmony to the top of the main node package. So this will be coming very soon! Thanks for raising this @EladBezalel. I'll also be looking into Liftoff and whether that would be beneficial.

Np happy to help :+1:

I also use babel-register, but it's just a polyfill, using liftoff will enable any compiler usage.

(Accidentally closed :sweat_smile: )

@kentcdodds I was looking more into the babel-register require hook. Do you see any downside to just adding this to the codebase itself? I like that it uses babel, which is a little more of a known entity than the --harmony flag. any thoughts on the matter?

I think that the best solution would be to do what gulp and webpack do. Not sure how they accomplish it, but if you have a webpack.config.babel.js file rather than webpack.config.js it'll transpile your config with babel. So you could first look for a plopfile.babel.js and if it's there, require the require('babel-register') hook perhaps?

Gulp uses liftoff :smile:

ok, so, time to go back and look at the liftoff examples again. @EladBezalel care to submit a pull request? ;-)

Ill do my best to assemble a proper PR as soon as i can :smile:


Blank error screen after logging in

After logging in to my umami instance, i just see a blank error screen.
Downloaded the latest version from fdroid

Hello, what is the Umami instance version?

v1.38.0

I did a test on your Umami version and the problem is that in version 1.39 Umami did some breaking API changes. Since HalfDot targets only the most recent API, older instances may not work anymore; in this case, v1.38 isn't compatible.
At the moment you can solve it by upgrading your Umami instance.
In the future it would be nice if HalfDot had backward compatibility. It may be time-consuming/hard to maintain, because Umami doesn't version their API, so some manual mapping needs to be done.


[86byg9kju] Fix/widget empty docs

Motivation and Context

There were too many similar examples of the NoData component, differing only in the illustration.
There were a number of errors throughout the WidgetEmpy doc.
Examples were outdated in some parts (old Card code, old list of locales).

How has this been tested?
Manually.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[x] Nice improve.

Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly or it's not required.
[ ] Unit tests are not broken.
[ ] I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
[ ] I have added new unit tests on added of fixed functionality.

Is this an up-to-date way to reference this package?


PhantomJS Announcement, and TagUI v2.0 ideas

Headless Chrome is coming - https://www.chromestatus.com/features/5678767817097216
(https://news.ycombinator.com/item?id=14101233)
I think people will switch to it, eventually. Chrome is faster and more stable than PhantomJS. And it doesn't eat memory like crazy.
I don't see any future in developing PhantomJS.
Even with recently released 2.5 Beta version with new and shiny QtWebKit, I can't physically support all 3 platforms at once (I even bought the Mac for that!). We have no support.
From now, I am stepping down as maintainer. If someone wants to continue - feel free to reach me.
Source :  https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE

Hi @LeMoussel thanks for sharing the fresh news. Its sad news that Vitaly is stepping down from maintaining PhantomJS, but understandably so. Not sure if Ariya (PhantomJS creator) has other plans.
For TA.Gui, in the event there is no longer active development of PhantomJS, eventually over a long period of time standard web interfaces might deviate from it to the point that it becomes harder to automate interactions that might work on other headless variants. It also depends on whether CasperJS (now maintained by Jef) will consider adding support for another active headless browser. Hope the baton is passed on smoothly following Vitaly's call.
There's probably no change to current pipeline for TA.Gui, as CasperJS integration with SlimerJS/Firefox can be run headlessly using Xvfb. I'm also considering adding WebdriverIO as another target because it can basically run on any browser through Selenium and it has active developers community.
But it's too early to work on WebdriverIO for now. Am now exploring a few ideas for TA.Gui v2.0 - running automation flow by specifying a URL to the file, live debugging, integration with SikuliX for visual web automation in addition to using XPath/CSS-based selectors, integration with some form of online JSON datastore for example Kinto, removing friction for integrations such as H2O (for deep learning) and Arduino (real world interactivity) etc. Some will make it to v2.0 some won't, will only know as roadblocks appear along the way. But at the minimum, I think adding visual web automation will have the largest impact / benefits and I will experiment with some potential workflows through SikuliX's interactive mode.
Leaving this thread open for the time being for anyone's inputs on the PhantomJS's news, or TA Gui v2.0 ideas ;)

Closing issue for now as there are no new inputs and v2.0 pipeline is more or less firmed up.

Adding a note that CasperJS Team (Jef) would try to continue maintain CasperJS with future headless browsers such as Google Chrome. Yay! 😃 Details and status at this thread https://github.com/casperjs/casperjs/issues/1825
Also added below section to TagUI pipeline -
What about TagUI v3.0? There are many changes lately in the web automation space. Chrome is coming up with an headless version, same for Firefox. PhantomJS's maintainer is stepping down. Depending on how these events pan out and CasperJS's response, TagUI may have to add new endpoints to its web automation framework in v3.0. Possible new endpoints include WebdriverIO (Selenium to various browsers) and Chrome Debugging Protocol (headless Chrome).

Going to try integrate headless Chrome directly with TagUI, raised an issue to track - https://github.com/tebelorg/TagUI/issues/24

Hi Ken
Executing the sample file 1_google.tag used to work fine but after some updates on Fedora:
tagui /home/theuns/TagUI_Linux/tagui/flows/samples/1_google.tag
This application failed to start because it could not find or load the Qt platform plugin "xcb".
Available platform plugins are: phantom.
Reinstalling the application may fix this problem.
PhantomJS has crashed. Please read the bug reporting guide at
http://phantomjs.org/bug-reporting.html and file a bug report.
PhantonJS crashes on Fedora:
Operating System: Fedora 33 (Workstation Edition)
CPE OS Name: cpe:/o:fedoraproject:fedora:33
Kernel: Linux 5.10.22-200.fc33.x86_64
Architecture: x86-64
Any workarounds?


Remove the binary-size-log workflow.

Fixes #1684
BUG=http://b/279058393

@mergifyio refresh

@mergifyio refresh


Typo on www.prisma.io/planetscale page

I just wanted to inform you about a small typo on the https://www.prisma.io/planetscale page. In the paragraph regarding "Prisma & PlanetScale best practices" there is written "fefining indices" instead of "defining indices".
I didn't find that page as part of the docs or any other public repo, so I couldn't make a pull request myself and posted it here.

Thanks for the report, that is a currently private repo - and I quickly fixed that. Should be live in a few minutes.


Fix consul service name

There cannot be spaces in consul service names. The service was incorrectly registered with its health check name instead of its service name.

Make sure we are using simple names in our checks.
CC: @siddharthist, @noahjl, @LeeLammert

We are soon going have a whole bunch of distributive checks for all sorts of services, which means we need to figure out how to add some specificity to the names. @eirslett Is there documentation that covers what characters are allowed? I can't seem to find it.

I suppose registering distributive in consul only makes sense if you want consul to know whether the distributive daemon runs or not? And in which case, find out where distributive is running, so you know how to contact it?

How complicated is it to check that distributive is running on a server? Can't you just run "service distributive status" or something like that?

@eirslett So this service actually runs a health check on the node via distributive - which has a bunch of functionality baked in. Distributive doesn't run a daemon, it only runs when Consul asks it to (via this service). Instead of checking Distributive's health, this service checks the health of the Consul service on that node.

Isn't that a chicken-egg-setup? Consul uses distributive to check the health of consul?

@eirslett So Distributive not only checks that the process is running - we could simply do that with Consul. It ensures that all of the configuration that we set up in the installation happened correctly. Check this checklist out.

Aah. I get a feeling that this is not consul was intended to be used... @armon?

@eirslett the goal is to have the cluster test its own configuration and propagate the results into consul.
A node will be marked as warning if there is a configuration problem.
This will allow us to do automated testing and deployments to multiple clouds on every checking. It will also allow operators to see if there has been any configuration drift on their cluster nodes.

To me, that sounds like a task one should to with sensu. That means having another moving part in the platform, but I guess people want to have sensu monitoring in there anyways. (And, as I understand it, distributive is quite well integrated with it?)

@eirslett It is a task that both Consul and Sensu are both well-suited to. Once we get more modularity in our install, we might add Sensu as an option as well!

Mind that this will lead to haproxy being configured to exposing http://distributive.service.consul as well. (That might not be a big problem though.)
Anyways, I believe any name that you can put into a host name is a valid service name in consul, so a-z, -, _ and so on.

Awesome, thanks for the info! That's very helpful.

@eirslett I'm with you with having issues on registering checks via a consul 'service' definition, because the checks will be registered in DNS.
Consul also supports a 'check' definition which applies to the node itself and doesn't register the service, which is what I would like to use for these checks.
We've looked at Sensu, and while it is very nice we don't want to complicate the infrastructure with dependencies like redis, rabbitmq, and the rest of the installation components.

Aah! I didn't realise consul had node checks as well. I totally agree then, that is the best choice. So renaming the check might not be necessary, but rather registering it as a check, not a service?

An added bonus of distributive, is while we're calling it from Consul, there's no reason a monitoring agent couldn't leverage it locally on a system to gather data via CLI. The output is in a sane format for most log collectors, enabling historical data collection as well.

For 0.3.2 we will make the definitions checks instead of services. Great catch, both @stevendborrelli and @eirslett. Just FYI, I requested some documentation from the Consul team, and they added it here.

Based on testing in the feature/distributive branch I suggest for v0.3.2 we do the following:

Comment out registration task in roles/consol/tasks/distributive.yml
Update roles/common/tasks/main.yml to install distributive v0.1.2

This will resolve this issue, and make distributive available for early adopters/testing until we have all roles' health checks mapped in the deployment.

That works for me. We are having a pretty intractable issue related to registering Distributive health checks as such in Consul, rather than services, and I think we need more time to figure out what exactly is going on.

I'm closing this PR, as we are making changes that obsolete it. It has opened some deeper issues, as outlined in the above issue, #535.


#5364 enable PR scanning in azure pipelines for sonarcloud

Signed-off-by: Nigel Jones<EMAIL_ADDRESS>
Disables batching, so all merges run to completion (helps identify the delta from a particular PR, and we no longer have the resource constraint of this being a bottleneck on our main build)
enables a run of the sonar check from a PR trigger

Opened issue with IT team - see https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-22242

Will close this PR and defer to the LF team.
Secrets are not available to the PRs as standard -- LF team looking at options.


support azure devops webhook

User description

add support for azuredevops server webhook, for new pr + comment witth command
add docker image for server
small edge case fix for llm output
relevant docs and configs

Type
enhancement, documentation

Description

Implemented Azure DevOps Server webhook server to handle "Pull request created" and "Pull request commented on" events.
Added functionality to truncate PR descriptions exceeding 4000 characters for Azure DevOps.
Enhanced YAML loading functionality in the utility module.
Documented the setup and security configuration for Azure DevOps webhooks, including basic authentication.
Updated the secrets template to include Azure DevOps Server webhook credentials.

Changes walkthrough
Relevant filesEnhancement

utils.pyEnhance YAML Loading Functionality

pr_agent/algo/utils.py
Adjusted YAML loading to strip trailing colon and newline characters.

+1/-1

azuredevops_provider.pyTruncate Azure DevOps PR Descriptions Exceeding Character Limit

pr_agent/git_providers/azuredevops_provider.py
Added a check to truncate PR descriptions exceeding 4000 characters for Azure DevOps.  Included logging for when PR description length exceeds the limit.

+6/-0

azuredevops_server_webhook.pyImplement Azure DevOps Server Webhook Server

pr_agent/servers/azuredevops_server_webhook.py
Introduced Azure DevOps Server webhook server implementation.  Added support for "Pull request created" and "Pull request commented on" events.  Implemented basic authentication validation for incoming webhook requests.

+110/-0

Documentation

Usage.mdDocument Azure DevOps Webhook Setup and Security

Usage.md
Documented how to set up Azure DevOps webhooks for triggering reviews and handling commands.  Added instructions for configuring webhook security using basic authentication.

+13/-0

Configuration changes

.secrets_template.tomlAdd Azure DevOps Server Webhook Credentials to Secrets Template

pr_agent/settings/.secrets_template.toml
Added template entries for Azure DevOps Server webhook username and password.

+6/-0

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Inline File Walkthrough 💎
For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
true: A collapsable file comment with changes title and a changes summary for each file in the PR.
false (default): File changes walkthrough will be added only to the "Conversation" tab.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

relevant comments fixed

thanks @yochail
Thats a very nice PR, for important content.
It will take us ~2-3 days to review and QA it

Hi @yochail
i gave some notes, but my main issue is that I tried and couldn't run this webhook, since I am continually getting
 "POST / HTTP/1.1" 401 Unauthorized"
once I change the line
@router.post("/", dependencies=[Depends(authorize)])
to
@router.post("/")
I am able to catch the webhook
what enables you to do authorization ? there are not a lot of options in the webhook menu.
the README just says:
"For webhook security, configure the webhook username and password on both the server and Azure DevOps webhook."

@mrT23 the idea is to configure use the same username/password pair on the ADO webhook and in the webhook server config. ill try to make the docs more clear about that

on ADO webhook trigger history you can make sure the header was sent

Yeah, ngrock worked better for me

so, the action items for this PR are:

revise the truncation mechanism
use the better parsing mechanism, similar to github_app.py

@yochail
if you feel these tasks are overwhelming for you, I can take them. But it's a must for merging this.

the truncation mechanism is unrelated to this pr, so ill remove it and create it later in other PR, i'll handle the other one in this PR

/config

@mrT23 I looked at github_app.py and the webhook structere and availabvle event are different, so i'm not sure what additional
logic you want to add here. currently the logic here is:
in case of PR creation event: run auto commands
in case of PR comment event: check if the comment is a command, if it is run it

Hi @yochail
please review https://github.com/Codium-ai/pr-agent/pull/667
i started from your PR, and added the following things:

proper treatment of auto commands, similar to github_app
https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools
proper clipping of the 'describe' command (its a must, since just the usage-guide is above 4000 tokens)
added edit_command,  so the waitbar is properly removed
fixed diff_files bug

it brings ADO to a state where the three major commands work well, and the webhook system is viable.
Some minor issues remain (the +- lines are not calculated correctly), but I will leave it for a future PR.
please review https://github.com/Codium-ai/pr-agent/pull/667. You can merge it to your PR, and I will merge yours to main.
If you prefer not to, I will merge https://github.com/Codium-ai/pr-agent/pull/667 directly
thanks for. the effort. i think its a tremendous progress towards full ADO support in PR-Agent

you can merge it directly, thanks :)

Preparing review...

PR Review

 ⏱ Estimated effort to review [1-5]
4, because the PR involves multiple enhancements including webhook support, security configurations, and docker setup. The complexity of integrating with an external service like Azure DevOps and ensuring security measures are correctly implemented requires a thorough review. Additionally, the changes span across several files and functionalities, including sensitive areas like authentication and event handling.

 🧪 Relevant tests
No

 🔍 Possible issues

Security concern: The use of basic authentication for the webhook could expose credentials if not transmitted over HTTPS. While the documentation warns about this, the code itself does not enforce or check for HTTPS, leaving room for misconfiguration.

Bug: The load_yaml function in utils.py now strips trailing colon and newline characters. This could potentially alter the intended YAML structure, leading to parsing errors or incorrect data handling.

Performance issue: The webhook handler performs several operations that could be optimized. For instance, regex compilation in azuredevops_server_webhook.py is done within the request handling path, which could be moved to a module level to avoid re-compilation on each request.
 🔒 Security concerns
Basic authentication usage: The PR introduces basic authentication for the Azure DevOps webhook. While it mentions the necessity of HTTPS, there's no programmatic enforcement or validation to ensure that the webhook communication is indeed over HTTPS, which could lead to credential exposure.

 Code feedback:
relevant filepr_agent/algo/utils.py
suggestion

Consider validating the YAML structure after stripping characters to ensure no unintended modifications occur. This can be done by adding a check after yaml.safe_load to verify that the loaded data meets expected structural criteria. [important]

relevant lineresponse_text = response_text.removeprefix('```yaml').rstrip('`').rstrip(':\n')
relevant filepr_agent/servers/azuredevops_server_webhook.py
suggestion

Move the regex compilation for available_commands_rgx to the module level outside of the request handling function. This will improve performance by compiling the regex only once at module load time. [important]

relevant lineavailable_commands_rgx = re.compile(r"^\/(" + "|".join(command2class.keys()) + r")\s*")
relevant filepr_agent/servers/azuredevops_server_webhook.py
suggestion

Implement a check to ensure that requests are received over HTTPS before processing them. This could be a simple check on the request's scheme and could significantly enhance security by enforcing the use of HTTPS. [important]

relevant linedef authorize(credentials: HTTPBasicCredentials = Depends(security)):
relevant filepr_agent/servers/azuredevops_server_webhook.py
suggestion

For better error handling and debugging, consider logging the specific exception details when catching exceptions in the handle_webhook function. This will aid in diagnosing issues during webhook processing. [medium]

relevant lineexcept Exception as e:

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/b402bd55912e292023bbf6a5593f1d628f647993


Update troubleshoot-security-config-mgt.md

Due to costumers requests, 2 rows were added to the troubleshooting table, for enrollment statuses 2 and 4

Moved this pull request to our private repo, here: https://github.com/MicrosoftDocs/defender-docs-pr/pull/675


[Dev][CI] pre-commit may be blocked

Describe the enhancement requested
https://github.com/apache/arrow/actions/runs/8412061637/job/23032443383
 Release Audit Tool.......................................................Passed
Error: The operation was canceled.

Component(s)
Continuous Integration, Developer Tools

Issue resolved by pull request 40794
https://github.com/apache/arrow/pull/40794


Disable CRON job for forks

This job is bound to fail - as it should - when run from a fork (since
the fork does not have permission to push to the dockerhub repo).
It is a bit verbose, and the workflow is still running (i.e. a worker VM
is created) which consummes some compute resources, but I believe the
Github team is working on improving this.
This is the best way I found to do this. I believe Github is working on
a better way to skip workflows.

See https://github.community/t5/GitHub-Actions/Skip-running-workflows/td-p/37404

@tnqn this should take care of the issue you observed on your fork

I had to do the same thing for the job that builds the Antrea Docker image and pushes it to Dockerhub, every time the master branch is updated.

/skip-e2e


Preserve comments when feedback window minimized & line break fix

https://github.com/nycJSorg/angular-presentation/issues/317


Unable to debug test with a chain of dependencies in IDEA

I'm using TestNG dependsOnMethods annotation to run my tests in intellij IDEA:
@Test(priority = 1)
public void test1(){
    Utils.line("test 1");
}

@Test(dependsOnMethods = {"test1"})
public void test2(){
    Utils.line("test 2");
}

@Test(dependsOnMethods = {"test2"})
public void test3(){
    Utils.line("test 3");
}

Test3 depends on Test2 and Test2 depends on Test1
All of them pass okay but a strange behavior occurs when I'm trying to debug the Test3 (Right click on method -> debug). I get an TestNG error:

TestClass1.test2() is depending on method public void TestClass1.test1(), which is not annotated with @Test or not included.

However, when I debug Test2 in the same way, it runs okay. When I set Test3 depends on Test1 its also okay.
It seems like TestNG doesn't see a chain of dependencies in debug mode, or I'm doing something wrong?

Does this work fine from the shell? If yes, it might be a bug in the IDEA TestNG plug-in (which you should report on their tracker).

Reproduced and reported to IDEA: https://youtrack.jetbrains.com/issue/IDEA-148334

Sorry for the delay with answer. Yes, it must be an IDEA 15 issue because it is ok for me in 14 version.

Closing this issue because its an IntelliJ issue.

This issue has resurfaced.
`import org.testng.annotations.Test;
public class testTestng {
@Test
public void test1() {
System.out.println("test1");
}
@Test (dependsOnMethods = {"test1"})
public void test2() {
System.out.println("test2");
}
@Test (dependsOnMethods = {"test2"})
public void test3() {
System.out.println("test3");
}
@Test (dependsOnMethods = {"test3"})
public void test4() {
System.out.println("test4");
}
}
 com.myorg.features.mytest.testTestng.test3() is depending on method public void com.myorg.features.mytest.testTestng.test2(), which is not annotated with @Test or not included.
at org.testng.internal.MethodHelper.findDependedUponMethods(MethodHelper.java:123)
at org.testng.internal.MethodHelper.topologicalSort(MethodHelper.java:266)
at org.testng.internal.MethodHelper.sortMethods(MethodHelper.java:376)
at org.testng.internal.MethodHelper.collectAndOrderMethods(MethodHelper.java:65)
at org.testng.TestRunner.initMethods(TestRunner.java:438)
at org.testng.TestRunner.init(TestRunner.java:271)
at org.testng.TestRunner.init(TestRunner.java:241)
at org.testng.TestRunner.(TestRunner.java:167)
`

@pkpattabhiraman - There's nothing that can be done if this is an intellij bug. You should report it on their bug tracker.

I'm using TestNG dependsOnMethods annotation to run my tests in eclipse IDE:

All test methods depends on each other
After creating a TestNG.XML for the same i m get error msg "NavigatetoMyInfo(), which is not annotated with @Test or not included."

However, i tried with simple program with same code it works fine but above one throws error.

@Banshs23 verifyInfo depends on NavigatetoMyInfo but is not included in ParameterTest test. The error is expected.


libmicroros.a', needed by 'int32_publisher.elf', missing and no known rule to make it

int32_publisher example not building

Hardware description: I was trying to build it for esp32
Installation type: ROS2 foxy with micro_ros_espidf_component
Version or commit hash: microros foxy

Steps to reproduce the issue
I have Ros Foxy installed on my PC. In order to use microros with esp32, I first cloned esp_idf and then I cloned micro_ros_espidf_component repo.
These are the commands i followed

. $IDF_PATH/export.sh
cd examples/int32_publisher
idf.py set-target esp32
idf.py build

Expected behavior
I was expecting it to build successfully.
Actual behavior
But Actually it was giving me error shown below

Additional information

I'm getting the same error

Me too,but  on humble branch.

Please someone solve this.
I also tried this using docker, but the error stays the same

I was getting this error then I run
cd ~/esp/esp-idf
source ./export.sh
pip3 install catkin_pkg lark-parser empy colcon-common-extensions

then I clean build and it worked, seems like the source before pip3 install didn't work when I did it first time.

I have also solved it with the solution provided by @glmnet :smile:


IDEA: How to increase proper citation of GBIF data use for non-download users

From communicating with data users who struggle with citing GBIF, I have an idea that I'd like some feedback on. The issue is citing GBIF when no download is necessary.

Use the phrase "cite" in addition to "download", e.g.

Anyone who's just done a very simply search, and has obtained the information they needed by simply looking at their screens will probably not be likely to start downloading the data (why would they?). If, instead, we shifted focus to "citing" data use, we might be able to get users to trigger downloads and thus DOI generation, even if they don't need the download.
We might also add some very simple to understand language on WHY you are required to register/log in if all you're trying to do is get a proper citation (which is also relevant for "real" downloads).

Allow for a simpler "cite data without downloading" option

Now, if we do convince some of these users to register and log in, we need them to also trigger the download/DOI generation, and not run away because "I don't need to download the data". Instead, I prose introducing a third option:

Technically speaking, this button could do exactly the same as the download buttons - or we could make a simple version of the download page that just presented them with the citation, e.g. https://www.gbif.org/occurrence/download/0001361-171020152545675?citation_only=true, and downplayed the fact that a download was actually being prepared. Anyone else visiting the page in the future wouldn't know the difference.

Finally, explore a way of adding a "cite this" button to the map of occurrences shown on species pages - clicking the button would simply lead to https://www.gbif.org/occurrence/download?taxon_key=<taxon key>

Interesting. I wonder if browsing and searching or capturing screenshots for meaningful results = use in GBIF sense, which, in the narrow sense, is data access and analytical use. Tradition of citing web is younger than bibliographic citations, but older than citing data, right? Citing web texts is a different story from citing web maps and web images, isn't it? Here is something you might like to explore http://www.citationmachine.net/mla/cite-a-website.

Allow me to provide a recent and typical example:
Marshall (2017). Insect Visitors of Cirsium pitcheri, a Threatened and Endemic Dune Species, in Relation to Annual Weather Variation. The Great Lakes Entomologist,  Vol. 50, No. 2 [2017], Art. 6. https://scholar.valpo.edu/cgi/viewcontent.cgi?article=2321&context=tgle#page=43
This paper reads:

The range for C. pitcheri includes dunes along Lakes Huron, Michigan, and Superior, in Indiana, Michigan, Wisconsin, USA, and Ontario, Canada (Voss 1996, Higman and Penskar 1999, Indiana
Department of Natural Resources 2007, Wisconsin Department of Natural Resources
2015, Global Biodiversity Information Facility 2016).

And the reference:

Global Biodiversity Information Facility. 2016. Cirsium pitcheri (Torr. ex Eaton) Torr. & A. Gray. GBIF Backbone Taxonomy. Available from http://www.gbif.org/species/3113668 (accessed 6 Oct 2017).

Clearly, this should be citing the occurrences of C. pitcheri, not the backbone taxonomy.


On load

While using this, there are many times that the load time is pretty long and people might X out of it because they think something is broken. Is there any way to have a "onLoad" parameter that takes in an object so that we can communicate that it is loading in the meanwhile?

Unfortunately this capability does not exist at the moment, but we are gearing up to release HelloSign Embedded v2 within the next month. This will have the capability to hook into the initialize event, which is triggered when the HelloSign Signer app has loaded and the JavaScript has initialized (essentially "ready").
const client = new HelloSign({ clientId );

client.on(HelloSign.events.INITIALIZE, () => {
  hideLoading();
});

client.open(signUrl);

showLoading();

I actually like the idea of calling this event ready instead of initialize, and it may end up changing in the final release.

New events did not help.
When the ready event fires, your loading continues to be displayed

Hi @kodermax,
Thank you for reaching out, and sorry for the inconvenience caused.
Would mind filing a ticket to<EMAIL_ADDRESS>with your code snippet and exact steps to reproduce so we can dig deeper on our end and assist you further.
The more detail you can provide, the easier this should be to figure out.


Documentation on PRISMA_MANAGEMENT_API_SECRET ENV var when Docker

I had issue where my local Docker will not work until I set my PRISMA_MANAGEMENT_API_SECRET env variable. If this is indeed needed, it is currently missing from the doc every where I looked.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @ShunnyBunny, we're currently cleaning up our PRs. Apologies for not having looked at it in detail earlier, unfortunately it is outdated by now (since the tutorials now live here) so I'll close it. Please keep opening PRs in the future if you see any issues with our docs 🙏


Invite backup3

critical change - use of useParams() - see my notes in the slack channel for examples - but ill pull it


Bug : changing viewsDirectory misses errors folder when exception occures

name: Bug report
about: changing viewsDirectory does not affect the errors folder when exceptions are occurred, because of the include is taking default value APPPATH.'Views/' instead of the new supplied path

Direction
Describe the bug

CodeIgniter 4 version
I believe in all, In my case is pre-alpha5
Expected behavior, and steps to reproduce if appropriate
it have to use viewsDirectory
Context

OS: win7
Web server 2.3.4
PHP version 7.2.9

You can control the folder that exceptions views are located at in Config\Exceptions, with the $errorViewPath location:
/*
	|--------------------------------------------------------------------------
	| Error Views Path
	|--------------------------------------------------------------------------
	| This is the path to the directory that contains the 'cli' and 'html'
	| directories that hold the views used to generate errors.
	|
	| Default: APPPATH.'Views/errors'
	*/
	public $errorViewPath = APPPATH . 'Views/errors';

It doesn't use the current viewsDirectory as set in Config\Paths on purpose. You might have several folders with themes, or whatever, but only one place where exceptions should be stored.


Efficient and simple API

From the proposal https://github.com/planetis-m/jsonecs/issues/8

The API on top should encourage efficient operations (don't use random access, iterate over the tree instead).

Luckily a proposed standard is already out for us to draw inspiration from https://datatracker.ietf.org/doc/html/rfc6901 and https://datatracker.ietf.org/doc/html/rfc6902

its value MUST be one of "add", "remove", "replace", "move", "copy", or "test"

So be it. API and example usage:
type
  JsonPtr* = distinct string

proc add*(x: var JsonTree; path: JsonPtr; value: sink JsonTree)
proc remove*(x: var JsonTree; path: JsonPtr)
proc replace*(x: var JsonTree; path: JsonPtr, value: sink JsonTree)
proc copy*(x: var JsonTree; `from`, path: JsonPtr)
proc move*(x: var JsonTree; `from`, path: JsonPtr)
proc test*(x: JsonTree; path: JsonPtr, value: JsonTree): bool

var x = %*{
  "a": [1, 2, 3],
  "b": 4,
  "c": [5, 6],
  "d": {"e": [7, 8], "f": 9}
}

add x, JsonPtr"/a/-", %*[5,6]
# """{"a":[1,2,3,[5,6]],"b":4,"c":[5,6],"d":{"e":[7,8],"f":9}}"""

remove x, JsonPtr"/d/e/1"
# """{"a":[1,2,3,[5,6]],"b":4,"c":[5,6],"d":{"e":[7],"f":9}}"""

replace x, JsonPtr"/b", %*"foo"
# """{"a":[1,2,3,[5,6]],"b":"foo","c":[5,6],"d":{"e":[7],"f":9}}"""

copy x, JsonPtr"/b", JsonPtr"/d/f"
# """{"a":[1,2,3,[5,6]],"b":"foo","c":[5,6],"d":{"e":[7],"f":"foo"}}"""

move x, JsonPtr"/c", JsonPtr"/b"
# """{"a":[1,2,3,[5,6]],"b":[5,6],"d":{"e":[7],"f":"foo"}}"""

assert test(x, JsonPtr"/d", %*{"e": [7], "f": "foo"})

Shorter explanation and available libraries at http://jsonpatch.com/

Does this mean they are 4 stacks? This should be done in 4 separate steps.

traverse x, (JString, "contact" / "phone"): # direct match
  discard

traverse x, (Jstring, "emp_data" * "employee" / "name": # * matches all
  discard

# More refined pattern:
traverse x, (JArray, "emp_data") * (JObject, "employee") / (JString, "name"):
  discard

# With array indices
traverse x, (JArray, "contact") / 0: # contact array, first index
  discard

macro traverse(x: JsonTree, pattern: untyped, body: untyped): untyped

Do we need to disambiguate between key and index?

also missing, how do we refer to our match?

As a forStmt macro:
const JLeaf = {JNull..JString}

for i in traverse(x, (JLeaf, "contact"/"phone")):
  i
for i in traverse(x, /"contact"/"phone"):
  i
for i in traverse x, (JArray, "contact") / [0]):
  i

with pattern: typed we can get type information for each node in the pattern.

forStmt macros don't support typed...

Does it have to be a macro? Seems generating custom code for each pattern more difficult than a seq of commands

Interesting reads: http://jsonpatch.com/ https://www.sqlite.org/json1.html

ts value MUST be one of "add", "remove", "replace", "move", "copy", or "test"

So be it. API:
proc op(x: var JsonTree; path: string, value: string)
proc op(x: var JsonTree; path: string, value: JsonTree)

Might still be needed:
proc len*(x: JsonTree; path: JsonPtr): int
proc kind*(x: JsonTree; path: JsonPtr): JsonNodeKind
proc extract*(x: JsonTree; path: JsonPtr): JsonTree

assert len(x, JsonPtr"/b") == 2
assert kind(x, JsonPtr"/d/e") == JArray
assert $extract(x, JsonPtr"/d") == """{"e":[7],"f":"foo"}"""

Instead of this bloat:
proc getStr*(x: JsonTree, path: JsonPtr, default: string = ""): string
proc getInt*(x: JsonTree, path: JsonPtr, default: int = 0): int
proc getBiggestInt*(x: JsonTree, path: JsonPtr, default: BiggestInt = 0): BiggestInt
proc getFloat*(x: JsonTree, path: JsonPtr, default: float = 0.0): float
proc getBool*(x: JsonTree, path: JsonPtr, default: bool = false): bool
iterator items*(x: JsonTree; path: JsonPtr): JsonTree
iterator pairs*(x: JsonTree; path: JsonPtr): (lent string, JsonTree)

...which might still need to expose JsonNode in order to make operations faster. Replace them with just the to macro:
proc fromJson*[T](x: JsonTree, t: typedesc[T]): T
proc toJson*[T](x: T): JsonTree

@Araq what do you think?

Syntaxes tried:

/"a"/1/_ needs to be inside a macro context, _ doesn't compile.
/"a"/"1"/"-" with a declaration like:

proc `/`*(a: JsonPtr, b: string): JsonPtr = JsonPtr(a.string & "/" & escapeJsonPtr(b))
proc `/`*(a: string): JsonPtr = JsonPtr("/" & escapeJsonPtr(a))
proc `/`*(a: JsonPtr, b: int): JsonPtr = JsonPtr(a.string & "/" & $b)
proc `/`*(a: int): JsonPtr = JsonPtr("/" & $a)

Seems OK. We take advantage of the fact there is no unary / in std/os and avoid naming collisions.
3. A simple template does the trick. template `$*`*(s: string): JsonPtr = JsonPtr(s) Usage: $*"/a/-"

JSON pointer implementations that seem not to use a seq[string]:
https://github.com/karekoho/json-pointer/blob/main/src/json_pointer/json_pointer.h
https://github.com/hitodama/libjsonp/blob/master/src/libjsonp.c

JSON Pointer have been implemented. However splitting them in runtime doesn't come cheap, so a macro solution should be considered.

Done.


[18.03] openjpeg: adding patch for CVE-2018-7648

Motivation for this change
Part of #38994
Backport of #49542
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: openjpeg
Partial log (click to expand)
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dihspgmifyl2aswazlzddlm9ksdmr2bj-openjpeg-2.3.0/lib  /nix/store/dihspgmifyl2aswazlzddlm9ksdmr2bj-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/dihspgmifyl2aswazlzddlm9ksdmr2bj-openjpeg-2.3.0
checking for references to /build in /nix/store/dihspgmifyl2aswazlzddlm9ksdmr2bj-openjpeg-2.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/5m30pm3fq6gwix0mzpf0qric65xdk2gv-openjpeg-2.3.0-dev
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5m30pm3fq6gwix0mzpf0qric65xdk2gv-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/5m30pm3fq6gwix0mzpf0qric65xdk2gv-openjpeg-2.3.0-dev
checking for references to /build in /nix/store/5m30pm3fq6gwix0mzpf0qric65xdk2gv-openjpeg-2.3.0-dev...
/nix/store/dihspgmifyl2aswazlzddlm9ksdmr2bj-openjpeg-2.3.0

Success on x86_64-linux (full log)
Attempted: openjpeg
Partial log (click to expand)
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/cd3wk801a1p9vd91xvzkspa41x4gr80w-openjpeg-2.3.0/lib  /nix/store/cd3wk801a1p9vd91xvzkspa41x4gr80w-openjpeg-2.3.0/bin
patching script interpreter paths in /nix/store/cd3wk801a1p9vd91xvzkspa41x4gr80w-openjpeg-2.3.0
checking for references to /build in /nix/store/cd3wk801a1p9vd91xvzkspa41x4gr80w-openjpeg-2.3.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/yy0x610v82x50d0wxisj5jsbk9wh4c20-openjpeg-2.3.0-dev
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yy0x610v82x50d0wxisj5jsbk9wh4c20-openjpeg-2.3.0-dev/lib
patching script interpreter paths in /nix/store/yy0x610v82x50d0wxisj5jsbk9wh4c20-openjpeg-2.3.0-dev
checking for references to /build in /nix/store/yy0x610v82x50d0wxisj5jsbk9wh4c20-openjpeg-2.3.0-dev...
/nix/store/cd3wk801a1p9vd91xvzkspa41x4gr80w-openjpeg-2.3.0


legal nitpick: Test example file not licenced for use in nuclear facilities

(Disclaimer/full disclosure: I am not a lawyer. I do work at Red Hat.)
A Java test example file has this in its licence blob:
https://github.com/pygments/pygments/blob/3e9fe3a99ae3f4250e1d3788f5f3b4cc0c21e6ac/tests/examplefiles/java/Intro.java#L31-L33
What does this mean? Imagine corporate lawyers raising eyebrows.
Technically, this might break the Open Source definition (No Discrimination Against Fields of Endeavor), making Pygments hard to test in the more careful distros.
Could this this file be, ehm, nuked?
It would be nice to replace it with a more clearly licensed file; is there anything such a replacement should feature?

Yes, that looks ... not right. You don't have a suitable replacement file by any chance you'd be willing to contribute?

I just looked at the file and there's not much interesting coverage in there. Nuked!

Thank you!


TTLs not working in DynamoDB state store

The Dynamo DB state store supports TTLs (as documented). However, the TTL test was not enabled in the conformance tests.
When that is enabled, the TTL tests fail: https://github.com/dapr/components-contrib/actions/runs/5536918955/jobs/10105198258#step:25:31

@JoshVanL  is this something you could look into please?

DynamoDB needs to be explicitly provisioned with the TTL setting enabled and the ttlAttribute matching the name used in the test, it might be that those two conditions aren't satisfied.

DynamoDB needs to be explicitly provisioned with the TTL setting enabled and the ttlAttribute matching the name used in the test, it might be that those two conditions aren't satisfied.

Thanks for the explanation. Looks like this was the issue and by enabling TTLs in the Terraform #2987 works


feat: svg react

Details
Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I checked the current PR for duplication.

Can you add a description of what this does and why we need it?

Can you add a description of what this does and why we need it?

I think we can use the issue linked on the sidebar: #360


App Service Global Vnet Peering

Is there a plan to enhance App Service VNet integration to utilise global vnet peering?
So that app services can access SQL Databases via private endpoints in different regions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7499b146-3340-d7d1-6c5f-3ed508b773cb
Version Independent ID: 61b10612-1136-3840-c7c1-804e63b23410
Content: Web app private connectivity to Azure SQL database - Azure Example Scenarios
Content Source: docs/example-scenario/private-web-app/private-web-app.md
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @jelledruyts
Microsoft Alias: jelled

@kmkelly2015 yes global peering support is planned, but even without it you can connect to a SQL Database (or other dependency) in another region by publishing the private endpoint of the database in one region into the VNet of the other region where the app is deployed. You have to take care of properly setting up DNS for that to work correctly, but definitely possible.

@jelledruyts thanks for the tip, I have got that working.


Publish Hub updates and add TOC entry for Publish page

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 5f29dc6d4dfdcaf1ba78e403095f876fd3cc4710
https://deploy-preview-8908--docsdocker.netlify.com


write saveplaylist tests

https://github.com/finesden33/Songwarp/pull/53#issue-2010854761 Issue is completed


Validation of array fields

I have a field with list of phones. User can add them, remove and edit. There two possible types of errors here:

Errors in array itself. For example: "You should provide at least one phone".
Errors in one particular element: "Invalid phone".
If I need first type of errors, I should define form fields like this ['phones'] and from my validation function I should return {phones: "You should provide at least one phone"}
If I need second type of errors, I should define fields like ['phones[]'] and should return

{
  phones: [
    undefined, // first phone is OK
    "Invalid phone" //second phone is bad
  ]
}

from my validation function.
The problem is that it is impossible to use both types of errors on the same fields. But it is quite common use case.
Any ideas how to solves this?

You have correctly identified the situation.
It's a little hacky, but you could put the "Need at least one phone" error in the form-wide _error key.
No obvious solution is coming to me... :thought_balloon:

If you like it I think I can implement this

@trashgenerator @erikras  I like this proposition as well :+1:
That could be applied both to arrays and deep objects in the same way.
What could be even better is that, if a validation (including submitValidation and asyncValidation) returns only a string where the form expects an object or array (e.g. errors.phones = "You should provide at least one phone"), this error would also automatically be added to errors.phones._error attribute.
That would make integration with APIs that return global errors for arrays or objects much easier.

Any update on this one? If think @trashgenerator solution in the best deal here...

Also interested in a solution for this one. I'd be interested if you have ideas on how to clear the errors from the array object.
We have a similar example to above where we have an array of weights. Each weight must be numeric and at least one must be 100.
var errors ={}
errors.weights: [
    undefined, // first weight is OK
    "Must be numeric" //second weight is bad
  ]
errors.weights._error = "At least one weight must be 100"

So I'm assuming that when your component get's the weights array field, the array field will have an error property alongside the standard array properties like addField etc.
If the issue was that the array was empty you could potentially clear the array error when an array field method like addField is called.  But not so clear if the issue is that no error fields meet a particular rule like, at least one must be 100.  I guess you could chain up the onChange handlers or something and always clear the array error when any child changes?

I started having a go at implementing something for this.  But ran into some confusion with the way that setErrors.js works currently.  I tried adding in an
errors.weights.error = "at least one weight must be 100"

error and handling that in some of the array error handling logic but the error property I set seemed to get cut out at some point.  Much debugging and I really just could not grok how setErrors is supposed to work.  I was testing setting a simple error on a fairly simple form structure and it seemed like the line that set the [destKey] error property got called about four times. I found it a bit confusing how there are multiple iterations going in in the clear and main part of the function.
So I decided to have a go at rewriting setErrors so maybe I could understand it better.
My first thought was that it should be possible to set and clear errors in a single iteration of the errors/state object structure. Started off simple, but once I added in all the different array handling it started to look a lot less simple but to my 'procedural' brain I still find it easier to understand than the current implementation...(most likely 'cos I wrote this version!), and it generally only does a single pass through the data rather than the weird multiple passes I was seeing with the current implementation.
I also find some of the inconsistent handling of array/object errors (usually picks the first array error whereas an object as error is OK?) a bit confusing but I think I remember seeing another issue discussing that (https://github.com/erikras/redux-form/issues/639).
Anyway, not sure what the point of this post is but just thought I'd share what I spent some of my weekend on...
https://gist.github.com/mdgbayly/2090df04cc6062759860
Maybe now that I have a version of setErrors that I understand I could have a go at adding validation of array fields and then maybe retrofit to the current setErrors implementation...

@erikras can you give some hints where one has to start fixing this in redux-form? We currently hacked around it by implementing a custom component, which gets a separate error property and handles the touched state itself.
If I have time and the code is not too complex I would try providing a pull request.

Good news! Array validation errors in v6.0.0-alpha-7.


error occurred renewing keyring

error occurred renewing keyring when select "REFRESH PACMAN MIRRORS"

Old iso is old, please continue with offline installer. Also online installer will be removed in the next release as well, please download anything you want after the installation


StronglyTypedIdValueConverterSelector should be Singleton

Thank you for your work!
I think StronglyTypedIdValueConverterSelector should be registered as a singleton.
builder.RegisterType<StronglyTypedIdValueConverterSelector>()
                .As<IValueConverterSelector>()
                .InstancePerLifetimeScope();

Captured from EF internals.
[EntityFrameworkInternal]
public static readonly IDictionary<Type, ServiceCharacteristics> CoreServices
	= new Dictionary<Type, ServiceCharacteristics>
	{
		(...)
		{ typeof(IValueConverterSelector), new ServiceCharacteristics(ServiceLifetime.Singleton) },
		(...)

Agreed, lifetime changed, thank you.


RTL Language Support for Specific Article

Expected behavior
First of all, thank you so much for your theme, I really like it.
I want to write some posts, articles by the right to left languages, such as Arabic, Uyghur, etc. And I have found some solutions, like this Hexo Theme Icarus Arabic Test (you could find the source code below), Hebrew Post.
I tried to use this solution in Next theme by myself, but the theme files are .swig, not .ejs, I couldn't find a way to change it. So I really hope that you could help me this out.
I even put CSS code in single post, but this affects all the articles. T_T
It would be great if I can specify the language setting in front-matter, for example
title: اختبار اللغة العربية date: 2016-01-30 10:15:01 ... language-direction: rtl
Also, I want to set a different font size and font family for RTL languages. I think this part would be easy, just specify it in CSS file for RTL LANGUAGE {direction:rtl; font-size: 16px; font-family: ...;}
Steps to reproduce the behavior
Link to demo site with this issue:
http://blog.zhangruipeng.me/hexo-theme-icarus/2016/01/30/Arabic-Test/
Link to source code to generate this site:
https://github.com/ppoffice/hexo-theme-icarus/issues/234
https://github.com/ppoffice/hexo-theme-icarus/commit/d961446f3fa2990a4924e6df0e767a65159f6ab8
NexT Information
NexT Version:
[ ] Master
[x] Latest Release
[ ] Old version -

NexT Scheme:
[x] All schemes
[ ] Muse
[ ] Mist
[ ] Pisces

I think this part would be easy, just specify it in CSS file for RTL LANGUAGE {direction:rtl; font-size: 16px; font-family: ...;}

 So, u need just to add in next/source/css/_custom/custom.styl any u want. In this state, this  must be:
p { direction:rtl; font-size: 16px; }

But u right, need to think about add option for this. Thank's.

@shohret ok, i add this option. See PART 4 in #1697.
And if solved, close it.

Hey, great, thank you!
And I saw your test demo and CSS modification.
.post-body {   font-family: $font-family-posts;   +mobile() {     word-break: break-word;   }   &.rtl p { direction: rtl; } }
Just additionaly, it is better to add h1, h2, h3, h4, and li tags rtl as well, since in RTL language these all should start from right to left.
If I want to change rtl articles/pages font-size and font-family I can just add CSS code in post.styl like this right?
.post-body {   font-family: $font-family-posts;   +mobile() {     word-break: break-word;   }   &.rtl p { direction: rtl;                font-size: 16px;                font-family: blablabla; } }

@shohret

If u want to add h1-h6, li or any additional tags, u can change &.rtl p to &.rtl p, h1, h2, li, etc..
If u want to add all tags, not only selected, u may just change &.rtl p to &.rtl - this will like wildcard (*).
U no need to modify original repositories files. If u do it, in future your update from master branch will by hard. If u want to add your own custom styles, as i say before, u can add any custom styles in _custom.styl and this styles will rewrite basic styles? e.g.:
Add to next/source/css/_custom/custom.styl

.post-body {
  &.rtl p {
    direction: rtl;
    font-size: 16px;
    font-family: blablabla;
   ...
  }

And this styles will rewrite all basic styles. No need to add mobile style if u don't wan't rewrite they. If want, u can add something like:
.post-body {
  +mobile() {
    word-break: initial;
    bla bla bla;
  }
  &.rtl p {
    direction: rtl;
    font-size: 16px;
    font-family: blablabla;

Next use scss and style can directly support variables, wich u can find in next/source/css/_variables. Also, there is custom.styl` too, so, u may rewrite basic variables too. That's why Next is so good theme, but no all know it.

I modified the code as you said, but it is not working well.
First, the categories page is aligned to right side, I want to make it normal, not RTL. I only want the lists to be RTL only in RTL language posts, not other pages.
Second, the English article's header tag is aligned to the right side as well, I want to make it normal, not RTL.
These are the CSS code I added in post.styl
.post-body {

  +mobile() {
    word-break: initial;
  }
  &.rtl p, h1, h2, h3, h4, h5, h6, li, ol, ul {
  direction: rtl;
  font-family: UKIJ Ekran;
}
  &.rtl p {
  font-size: 16px;
}
}

and in custom.styl
@font-face {
  font-family: UKIJ Ekran;
  src: url("fonts/ukij-ekran.ttf");
}

Thank you

I realized my code in post.styl generated this CSS code below
.post-body.rtl p,
.post-body h1,
.post-body h2,
.post-body h3,
.post-body h4,
.post-body h5,
.post-body h6,
.post-body li,
.post-body ul,
.post-body ol {
  direction: rtl;
  font-family: UKIJ Ekran;
}
.post-body.rtl p {
  font-size: 16px;
}

Apparently, except p tag, all other tags are just .post-body, not .post-body.rtl. How should I write in post.styl to make it correct? Should I write each tag one by one? I am sure there is a convenient way tho.

&.rtl p, h1, h2, h3, h4, h5, h6, li, ol, ul

Sorry, i mistake. Need to do like that:

&.rtl p, .rtl a, .rtl h1...

Or like that:
 &.rtl
  & p, a, h1...

Try to write 'UKIJ Ekran' or "UKIJ Ekran". Also, font option was buggy, as i remember.

The font UKIJ Ekran is working perfectly for post body, for the title, post-title.rtl selector is not working.

Live demo?

Sorry, forgot in the last comment.
Here is the webpage: https://shohret.github.io/

post-title.rtl

Don't understand, where is this selector? This:
.post-title.rtl a, h1 {
    direction: rtl;
    font-family: UKIJ Ekran;
}

As i see, font working. What u want can u explain?

The font in the title is not UKIJ Ekran, I want to make that RTL language post's title to be UKIJ Ekran, just like body text.

See above.

I tried that code, it will affect that Hello World post's title. I want to keep left to right language posts normal. Only RTL post title to be in UKIJ Ekran

@shohret ok, then u need to modify like above post-title.styl. There are 2 sections - for expanded post and for homepage.

@shohret a can make separated post-rtl.styl for this.  I find why this not work. Take a moment, need to fix this.

@shohret check for this: 9673657.

Yeah, I think if we have post-rtl, it is easier to control. Then we don't have to change post-title-rtl, post-body-rtl separately.
For RTL language post, text should be direction: rtl, but programming code in any post should be always normal.

check for this: 9673657.

Thank you, this is gonna work. Haha, that is why I was saying post-title.rtl isn't working.

@shohret yep, .rtl class was added in post-body only. So, i add it in post-title and if need, you also can add it to anyway (for sidebar, for example).
Ok, i will make post-rtl.styl. Need a test this from you. Wait for response.

Sure, thank you!

@shohret ok, check last 3 commits in #1697 PART 4.

It is working great, demo, thank you a lot!

 But there is some problem: readmore button caption have rtl direction too. Or this is fine? how u think?

I don't think this is a big problem, it is fine~~~ ^_^

Good.


UI - "Failed to load tool" error seen when creating an assistant.

Create an assistant.

This issue shows up when the edit page is launched

On clicking on restart this error goes away.
I almost always see this error happen when creating assistants from dev builds.
I have not seen this issue happen even once when testing from prod builds.

This issue is not seen any more when testing with latest builds


Floating-Point Control and Status Register (FCSR) not mentioned

The  Floating-Point Control and Status Register (FCSR) contains reserved bits, the rounding mode (frm) and the accrued exception flags (fflags).
The frm are probably a system-wide setting.
What about the fflags? Are they supposed to be preserved across function calls?

fflags are basically a global variable, so they don't need to be saved or restored on calls/returns.  This follows the C11 fenv convention.

Ok, so from C11 fenv it follows that this is a thread-local variable?

In glibc, fesetexceptflags, feclearexcept, fetestexcept etc all access fflags directly.  It is the job of the kernel to ensure that each process has its own copy of fcsr, which is why this is part of the process context in the linux kernel.  It would be the job of the thread package to save/restore fflags if not using processes.  The glibc makecontext, swapcontext, etc calls also save/restore fcsr which would solve that problem.  glibc has lots of math tests, some of which use threads, and they work on linux, so the linux/glibc support for this appears to be good.  RTEMS can probably do something similar.

Thanks for the clarification. I created a pull request to somehow add this information to the psABI document.
https://github.com/riscv/riscv-elf-psabi-doc/pull/73


[BEAM-13615] Bumping up FnApi environment version to 9 in Java, Python SDK

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @chamikaramj

CC: @robertwb @tvalentyn

Thanks.
Can you also run a Google code import and make sure nothing fails ?
cc: @aaltay @lukecwik

What about Go?

What about Go?

Go SDK is not tested enough with the new artifact service.  For instance, Go SDK creates beam:artifact:type:go_worker_binary:v1 artifact type but the new artifact service doesn't support it yet. I think we need to test and update the new artifact service first before increasing FnApi environment version for Go SDK.

Go SDK is not tested enough with the new artifact service. For instance, Go SDK creates beam:artifact:type:go_worker_binary:v1 artifact type but the new artifact service doesn't support it yet. I think we need to test and update the new artifact service first before increasing FnApi environment version for Go SDK.

That means that if someone needs to increase api major version for similar purposes for other efforts, they wouldn't be able to do so in Go until this is addressed. At minimum, there should be a TODO in front of the major version number in Go codebase and Jira should explain that further increase requires artifact service support.

looks like it's already behind the Java and Python versions:
https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go#L163
I will put the comment that version 9 requires the new artifact service compatibility.

And I think we also needed some Dataflow service changes before getting this in ?

(to enable the new major version)

And I think we also needed some Dataflow service changes before getting this in ?

Yeah, I've got "incompatible environment version" error message while testing this PR on google3. We also need to update Dataflow config files somewhere.

Do we have a link to a doc that defines the differences in these last few FnAPI versions? It's hard to see if things work and how to fix them without API Documentation. Putting it into the JIRA (https://issues.apache.org/jira/browse/BEAM-13647) is fine.

Also, should this be in 3.6?
On Wed, Jan 12, 2022 at 5:43 PM Robert Burke @.***>
wrote:

Do we have a link to a doc that defines the differences in these last few
FnAPI versions? It's hard to see if things work and how to fix them without
API Documentation. Putting it into the JIRA (
https://issues.apache.org/jira/browse/BEAM-13647) is fine.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/16461#issuecomment-1011650869, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADWVAMRLE3ZWFLRUGNOOLDUVYU4ZANCNFSM5LQBBDTQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

What is the next step on this PR?

BEAM-13615 is a 2.37.0 release blocker right now, is that correct?


NIFI-7891 Default types in avro schemas when inferring schema

Initial attempt at adding default types for inferred avro schemas.
Adds dynamic properties to AvroRecordSetWriter prefixed with 'default.type' to specify default as desired
If you supply a value that can't convert in to the specific type .e.g (long and "hello") it will fail with
"Could not determine the Avro Schema to use for writing the content"
Seems like a valid error msg, but I suppose we could check the type conversion at the property validation point instead and fail earlier?
Welcome your feedback

Used the wrong JIRA id...will resub...


expression: add like support (fix #99)

Added in a my-SQL way. If the type is not a string, the LIKE behavior is the same as Equals.

Current coverage is 61.21% (diff: 67.74%)

Merging #102 into master will increase coverage by 0.19%

@@             master       #102   diff @@
==========================================
  Files            40         40
  Lines          1652       1681    +29
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1008       1029    +21
- Misses          585        593     +8
  Partials         59         59

Powered by Codecov. Last update b66aa93...46296f2


How to reproduce Textvqa(val) score- 68.1

Hi, I am currently facing some challenges in achieving the reported outcomes of TextVQA.
Here are the details of my current setup:
Model Checkpoint: cogvlm-chat
Prompt Template: 'Question: {} Answer:'
And I use the model.chat to generate answers
Despite following the specified settings, I am unable to replicate the results for TextVQA as mentioned in the paper. Could you please provide some guidance on what might be missing or any additional steps that need to be taken to successfully reproduce the results?
Thank you very much for your time and assistance.

The chat model is trained on a substantial amount of instructional data. Models trained on multi VQA and caption data will be released soon.

are you testing zero-shot performance? The reported result is a fine-tuned one.

Yes, I initially thought that cogvlm-490-base was the one, but it turns out it did not achieve the performance expected.

are you testing zero-shot performance? The reported result is a fine-tuned one.
Oh！ I thought cogvlm-490-base was the fine-tuned version mentioned in the paper. So you haven't released this model yet?

are you testing zero-shot performance? The reported result is a fine-tuned one.

Oh！ I thought cogvlm-490-base was the fine-tuned version mentioned in the paper. So you haven't released this model yet?

we have updated the vqa model.

Hi @mactavish91 ,
Congratulations on your awesome work.
I am also wondering the zero-shot performance of Table 2 & 3. Do you have a plan to provide it?
Please let me know if I missed something.
Thanks very much.

Hi @mactavish91 ,
Congratulations on your awesome work.
I am also wondering the zero-shot performance of Table 2 & 3. Do you have a plan to provide it? Please let me know if I missed something.
Thanks very much.

We may not provide the results of these datasets, as we have found that the evaluation of them uses strict matching, and the model's language style greatly influences the results. However, we do provide the zero-shot results of three datasets: MMVET, POPE, and Touchstone, which you may refer to.


How I configure for blocking mode rules

All commercial rules detections are Warning and no blocking.
How,but the free rules are working properly.
How I configure for blocking mode rules on  ModSecurity 2.9.0 (Debian 7) ?
In my configuration file, I have:
SecRuleEngine On
SecDefaultAction "phase:1,deny,log"

The commercial rules use 'block' in the same way as the CRS rules, please also set a phase:2 block.


Add NodeInternalIP for Node's Addresses when cloud provider is nil

When running a Kubernetes without any cloud providers, there's no NodeInternalIP for Node, this can cause heapster cann't get correct NodeInternalIP.
Issue#445.

LGTM. Adding @vishh for a second pair of eyes

ok to test

LGTM.


pre-work/required reading

Define Pre-Work: WTF is DevOps, K8S, multipass, CLI
Define prerequisite courses, link to LinkedIn Learning
Link to Resources (Books, Courses, ...) e.g.
https://www.linkedin.com/learning/learning-kubernetes/what-is-kubernetes?u=2056764
https://www.linkedin.com/learning/cloud-native-development-with-node-js-docker-and-kubernetes/introduction-to-opentracing?u=2056764"

I think we can close this one now as the footnotes help and also the work Chris is doing on the resources section? Thoughts?


⚠ Bofrost.de has degraded performance

In 14f7294, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1417 ms

Resolved: Bofrost.de performance has improved in d3b115c.


Installing gems without version after the ones with version for tests

rake < 2 should be installed before artifice.
On ruby 1.8.7 it fails randomly because of no specific order of hash traversal.
https://travis-ci.org/bundler/bundler/builds/141867428

@homu r+
Thanks!

:pushpin: Commit 8b5c73f has been approved by segiddins

:zap: Test exempted - status


Unenchanting any items in grindstone causes a duplication

What the title says. The grindstone will keep the enchanted item where you put it but will also give you an unenchanted version. Link to video can be found here.

Whoops sorry - fat fingered this one. Meant to report an issue on a fork of this.


Fix missing kana in TweetDeck

https://twitter.com/museumnews_jp/status/1590543937928065024

@soruly Could you provide reproduction steps?

I just visit https://tweetdeck.twitter.com/ and add a column
Not sure why you can't reproduce it.
Windows 10 Pro 21H2 Build 19044.2251
Google Chrome 107.0.5304.107
mirigana is the only extension I've enabled
using Builtin API, not Mrigana Online API


Bug on xgboost(classification) -> plot _feature_importance

(1) System Environment:

System version: macOS Catalina version 10.15.7
Python version: 3.9.7

(2) Problem:
When I wanna draw the feature importance graph of xgboost, the error occurs.
(3) Log:
-----* Feature Importance *-----
Traceback (most recent call last):
  File "/Users/can/Documents/github/work/geo_ml/geochemistrypy/geochemistrypy/client/main.py", line 233, in <module>
    main()
  File "/Users/can/Documents/github/work/geo_ml/geochemistrypy/geochemistrypy/client/main.py", line 223, in main
    run.activate(X, y)
  File "/Users/can/Documents/github/work/geo_ml/geochemistrypy/geochemistrypy/client/../process/classify.py", line 36, in activate
    self.clf_workflow.special_components()
  File "/Users/can/Documents/github/work/geo_ml/geochemistrypy/geochemistrypy/client/../model/classification.py", line 557, in special_components
    self._feature_importance()
  File "/Users/can/Documents/github/work/geo_ml/geochemistrypy/geochemistrypy/client/../model/classification.py", line 527, in _feature_importance
    for feature_name, score in zip(list(columns_name), self.model.feature_importances_):
  File "/usr/local/lib/python3.9/site-packages/xgboost/sklearn.py", line 746, in feature_importances_
    score = b.get_score(importance_type=self.importance_type)
  File "/usr/local/lib/python3.9/site-packages/xgboost/core.py", line 1879, in get_score
    raise ValueError(msg.format(importance_type))
ValueError: importance_type mismatch, got 'None', expected one of ['weight', 'gain', 'cover', 'total_gain', 'total_cover']

(4) Idea:

def init(...............,  importance_type: Optional[str] = 'weight',.............)


Renaming hostname to customer_strategy_ref

Renaming hostname to customer_strategy_ref, which makes intent more explicit.

I'm not sure this is an improvement as currently everywhere I see code like self.customer_strategy_ref = config.hostname I know more or less exactly what it means. Whereas with self.customer_strategy_ref = config.customer_strategy_ref I will (in the future when I have forgotten) I will have to go and check what initialized config.customer_strategy_ref.
Or to put it another way, the new code adds an unnecessary layer of possible obfuscation. Looking at = config.hostname vs = config.customer_strategy_ref I think the former is much clearer.

But config.hostname is just being used as the default value for customer_strategy_ref. If someone wants to use a different value, then it's a bit incorrect to call it config.hostname.

Aha... "If someone wants to use a different value"... yes in that case you are correct.

@ThomasAJ05 that was my reasoning to start with but as @jsphon pointed out it is now only used for this variable so calling it hostname is a bit confusing (regular question on the slack)


[ISSUE #428]Fix Chinese annotation

Translate the Chinese to English on the common module.
Only the Chinese part of the notes has been translated, and the Chinese in the code has not changed.

Codecov Report

Merging #431 (fad0381) into develop (d8ac875) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             develop    #431   +/-   ##
=========================================
  Coverage       8.49%   8.49%
  Complexity       256     256
=========================================
  Files            228     228
  Lines          10783   10783
  Branches         918     918
=========================================
  Hits             916     916
  Misses          9793    9793
  Partials          74      74

Impacted Files
Coverage Δ

...g/apache/eventmesh/common/command/HttpCommand.java
67.56% <ø> (ø)

...otocol/http/body/client/HeartbeatResponseBody.java
0.00% <ø> (ø)

...ol/http/body/message/ReplyMessageResponseBody.java
0.00% <ø> (ø)

...ttp/body/message/SendMessageBatchResponseBody.java
0.00% <ø> (ø)

...p/body/message/SendMessageBatchV2ResponseBody.java
0.00% <ø> (ø)

...esh/common/protocol/http/common/ClientRetCode.java
0.00% <ø> (ø)

...tmesh/common/protocol/http/common/ProtocolKey.java
0.00% <ø> (ø)

...col/http/header/client/HeartbeatRequestHeader.java
66.66% <ø> (ø)

...protocol/http/header/client/RegResponseHeader.java
65.78% <ø> (ø)

...rotocol/http/header/client/UnRegRequestHeader.java
66.66% <ø> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ac875...fad0381. Read the comment docs.