Use shellcheck for better compatibility in mde_installer.sh

I would suggest to use https://www.shellcheck.net/, to verify that the script works in more environments and also to have some sort of static code analysis.
Here is the current output of shellcheck.
In mde_installer.sh line 64:
    msg="${@:3}"
        ^------^ SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

In mde_installer.sh line 101:
    if [ -n $DEBUG ]; then
            ^----^ SC2070: -n doesn't work with unquoted arguments. Quote or use [[ ]].

In mde_installer.sh line 117:
	    exit $2
                 ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
	    exit "$2"

In mde_installer.sh line 122:
   if which python3 &> /dev/null; then
      ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.

In mde_installer.sh line 124:
   elif which python2 &> /dev/null; then
        ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.

In mde_installer.sh line 133:
   cat <<EOF | /usr/bin/env $(get_python)
                            ^-----------^ SC2046: Quote this to prevent word splitting.

In mde_installer.sh line 172:
    echo $proxy_params
         ^-----------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    echo "$proxy_params"

In mde_installer.sh line 177:
    if [ -z $(which mdatp) ]; then
            ^------------^ SC2046: Quote this to prevent word splitting.
              ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.

In mde_installer.sh line 200:
    local out=$(eval $1 2>&1; echo "$?")
          ^-^ SC2155: Declare and assign separately to avoid masking return values.
                     ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    local out=$(eval "$1" 2>&1; echo "$?")

In mde_installer.sh line 201:
    local exit_code=$(echo "$out" | tail -n1)
          ^-------^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 208:
        if [ -n $DEBUG ]; then
                ^----^ SC2070: -n doesn't work with unquoted arguments. Quote or use [[ ]].

In mde_installer.sh line 215:
            log_error $2
                      ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
            log_error "$2"

In mde_installer.sh line 221:
    return $exit_code
           ^--------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    return "$exit_code"

In mde_installer.sh line 237:
    while [ $retries -gt 0 ]
            ^------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    while [ "$retries" -gt 0 ]

In mde_installer.sh line 249:
            log_info "[r] $(($1-$retries))/$1"
                                ^------^ SC2004: $/${} is unnecessary on arithmetic variables.

In mde_installer.sh line 266:
        . /etc/os-release
          ^-------------^ SC1091: Not following: /etc/os-release was not specified as input (see shellcheck -x).

In mde_installer.sh line 273:
        elif [[ $(grep -o -i "Red\ Hat" /etc/redhat-release) ]]; then
                ^-- SC2143: Use grep -q instead of comparing output with [ -n .. ].

In mde_installer.sh line 275:
        elif [[ $(grep -o -i "Centos" /etc/redhat-release) ]]; then
                ^-- SC2143: Use grep -q instead of comparing output with [ -n .. ].

In mde_installer.sh line 309:
    if which wget; then
       ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.

In mde_installer.sh line 311:
    elif which curl; then
         ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.

In mde_installer.sh line 353:
    if [ $(id -u) -ne 0 ]; then
         ^------^ SC2046: Quote this to prevent word splitting.

In mde_installer.sh line 362:
    local cores=$(nproc --all)
          ^---^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 363:
    if [ $cores -lt $MIN_CORES ]; then
         ^----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    if [ "$cores" -lt $MIN_CORES ]; then

In mde_installer.sh line 367:
    local mem_mb=$(free -m | grep Mem | awk '{print $2}')
          ^----^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 368:
    if [ $mem_mb -lt $MIN_MEM_MB ]; then
         ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    if [ "$mem_mb" -lt $MIN_MEM_MB ]; then

In mde_installer.sh line 372:
    local disk_space_mb=$(df -m . | tail -1 | awk '{print $4}')
          ^-----------^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 373:
    if [ $disk_space_mb -lt $MIN_DISK_SPACE_MB ]; then
         ^------------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    if [ "$disk_space_mb" -lt $MIN_DISK_SPACE_MB ]; then

In mde_installer.sh line 386:
	lines=$(systemctl status $1 2>&1 | grep "Active: active" | wc -l)
                                 ^-- SC2086: Double quote to prevent globbing and word splitting.
                                           ^-------------------^ SC2126: Consider using grep -c instead of grep|wc -l.

Did you mean:
	lines=$(systemctl status "$1" 2>&1 | grep "Active: active" | wc -l)

In mde_installer.sh line 388:
    if [ $lines -eq 0 ]; then
         ^----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    if [ "$lines" -eq 0 ]; then

In mde_installer.sh line 400:
    local conflicting_apps=$(timeout 5m find /proc/*/fdinfo/ -type f -print0 2>/dev/null | xargs -r0 grep -Fl "fanotify mnt_id" 2>/dev/null | xargs -I {} -r sh -c 'cat "$(dirname {})/../cmdline"')
          ^--------------^ SC2155: Declare and assign separately to avoid masking return values.
                                                                                ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that.

In mde_installer.sh line 402:
    if [ ! -z $conflicting_apps ]; then
         ^-- SC2236: Use -n instead of ! -z.
              ^---------------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    if [ ! -z "$conflicting_apps" ]; then

In mde_installer.sh line 417:
        set -- $t
               ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
        set -- "$t"

In mde_installer.sh line 419:
        if find_service $1; then
                        ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
        if find_service "$1"; then

In mde_installer.sh line 458:
        dpkg -s $1 2> /dev/null | grep Status | grep "install ok installed" 1> /dev/null
                ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
        dpkg -s "$1" 2> /dev/null | grep Status | grep "install ok installed" 1> /dev/null

In mde_installer.sh line 460:
        rpm --quiet --query $(get_rpm_proxy_params) $1
                            ^---------------------^ SC2046: Quote this to prevent word splitting.
                                                    ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
        rpm --quiet --query $(get_rpm_proxy_params) "$1"

In mde_installer.sh line 483:
    if [ ! -z "$pkgs_to_be_installed" ]; then
         ^-- SC2236: Use -n instead of ! -z.

In mde_installer.sh line 498:
        lines=$(ps axo pid,comm | grep "$PKG_MGR" | grep -v grep -c)
                ^-- SC2009: Consider using pgrep instead of grepping ps output.

In mde_installer.sh line 512:
    local packages=
          ^------^ SC2178: Variable was used as an array but is now assigned a string.

In mde_installer.sh line 514:
    local success=
          ^-----^ SC2034: success appears unused. Verify use (or export if used externally).

In mde_installer.sh line 524:
    install_required_pkgs ${packages[@]}
                          ^------------^ SC2068: Double quote array expansions to avoid re-splitting elements.

In mde_installer.sh line 553:
    local packages=
          ^------^ SC2178: Variable was used as an array but is now assigned a string.

In mde_installer.sh line 564:
    repo=packages-microsoft-com
         ^--------------------^ SC2100: Use $((..)) for arithmetics, e.g. i=$((i - 2))

In mde_installer.sh line 568:
        packages=($packages deltarpm)
                  ^-------^ SC2128: Expanding an array without an index only gives the first element.
                  ^-------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.

In mde_installer.sh line 571:
    install_required_pkgs ${packages[@]}
                          ^------------^ SC2068: Double quote array expansions to avoid re-splitting elements.

In mde_installer.sh line 575:
        repo=packages-microsoft-com-prod
             ^-------------------------^ SC2100: Use $((..)) for arithmetics, e.g. i=$((i - 2))

In mde_installer.sh line 601:
    local packages=
          ^------^ SC2178: Variable was used as an array but is now assigned a string.

In mde_installer.sh line 611:
    repo=packages-microsoft-com
         ^--------------------^ SC2100: Use $((..)) for arithmetics, e.g. i=$((i - 2))

In mde_installer.sh line 614:
    install_required_pkgs ${packages[@]}
                          ^------------^ SC2068: Double quote array expansions to avoid re-splitting elements.

In mde_installer.sh line 620:
    lines=$($PKG_MGR_INVOKER lr | grep "packages-microsoft-com-$CHANNEL" | wc -l)
                                  ^-- SC2126: Consider using grep -c instead of grep|wc -l.

In mde_installer.sh line 622:
    if [ $lines -eq 0 ]; then
         ^----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
    if [ "$lines" -eq 0 ]; then

In mde_installer.sh line 648:
    local packages=
          ^------^ SC2178: Variable was used as an array but is now assigned a string.

In mde_installer.sh line 659:
    install_required_pkgs ${packages[@]}
                          ^------------^ SC2068: Double quote array expansions to avoid re-splitting elements.

In mde_installer.sh line 685:
            repo=packages-microsoft-com-prod
                 ^-------------------------^ SC2100: Use $((..)) for arithmetics, e.g. i=$((i - 2))

In mde_installer.sh line 731:
    for version in ${SUPPORTED_RHEL6_VERSIONS[@]}; do
                   ^----------------------------^ SC2068: Double quote array expansions to avoid re-splitting elements.

In mde_installer.sh line 744:
            if rhel6_supported_version $VERSION; then # support versions 6.7+
                                       ^------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
            if rhel6_supported_version "$VERSION"; then # support versions 6.7+

In mde_installer.sh line 792:
        PYTHON=$(which python || which python3)
                 ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.
                                 ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.

In mde_installer.sh line 794:
        if [ -z $PYTHON ]; then
                ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
        if [ -z "$PYTHON" ]; then

In mde_installer.sh line 824:
    if [ $(mdatp health --field passive_mode_enabled | tail -1) == "false" ]; then
         ^-- SC2046: Quote this to prevent word splitting.

In mde_installer.sh line 838:
        set -- $t
               ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
        set -- "$t"

In mde_installer.sh line 840:
            local set_tags=$(mdatp health --field edr_device_tags)
                  ^------^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 843:
            local result=$(echo "$set_tags" | grep -q "\"key\":\"$1\""; echo "$?")
                  ^----^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 844:
            if [ $result -eq 0 ]; then
                 ^-----^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
            if [ "$result" -eq 0 ]; then

In mde_installer.sh line 845:
                local value=$(echo "$set_tags" | grep -o "\"key\":\"$1\".*\"" | cut -d '"' -f 8)
                      ^---^ SC2155: Declare and assign separately to avoid masking return values.

In mde_installer.sh line 854:
                local tag_value="\"${@:2}\""
                                ^----------^ SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

In mde_installer.sh line 1076:
if [ ! -z $PASSIVE_MODE ]; then
     ^-- SC2236: Use -n instead of ! -z.

In mde_installer.sh line 1080:
if [ ! -z $ONBOARDING_SCRIPT ]; then
     ^-- SC2236: Use -n instead of ! -z.
          ^----------------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
if [ ! -z "$ONBOARDING_SCRIPT" ]; then

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC2070 -- -n doesn't work with unquoted arg...
  https://www.shellcheck.net/wiki/SC2034 -- success appears unused. Verify us...

I would also suggest addressing these warnings and errors.

@SvenMarquardt5772, is this issue still open? can I start working on this?

@SvenMarquardt5772, is this issue still open? can I start working on this?

Yes, this is still an issue, This should be part of the pipeline.

@SvenMarquardt5772, which pipeline you are referring to?

The one you are using for Continuous Integration. I suppose if you don't have one here on GitHub you have one internally where your tests are running after commits on main. Or whatever QA process you have.


Line chart: option to remove padding at the origin

I could not seem to find a way to remove the padding at the origin of line charts. It would be a nice addition to be able to tune that, up to potentially remove it altogether.
This is the setup of my chart:
self.lineChart.backgroundColor = UIColor.clearColor()
self.lineChart.showCoordinateAxis = true
self.lineChart.xLabels = ["J", "F", "M", "A", "M", "J", "J", "A", "S", "O", "N", "D"]
self.lineChart.yLabelFormat = "$%1.f"

and this is how I insert each dataSet:
let chartLine1Data: [CGFloat] = [200, 250, 550, 580, 630, 600, 750, 700, 680, 700, 820, 1080]
let chartLine1 = PNLineChartData()
chartLine1.itemCount = UInt(chartLine1Data.count)
chartLine1.lineWidth = 2.5
chartLine1.getData = { index in
    return PNLineChartDataItem(y: chartLine1Data[Int(index)])
}
...
self.lineChart.chartData = [chartLine1, ... ]

This is the result:

I tried fiddling with the chartCavanHeight and chartCavanWidth (assuming cavan is "canvas"), along with the number of Y labels but I could not achieve a decent result. Am I missing something or there's no way of eliminating the padding at the origin?

padding needs to be modified in source code.

@kevinzhow I'm sorry, are you suggesting to manually hack the library source code? Since I imagine this might be interesting for other library users as well, is it possible for you to consider adding this functionality properly (e.g. with a configurable property)? If you are willing to include this functionality I can do a pull request.
Of course hacking the library for me is not a solution, as I don't want to maintain a fork of my own.


figure out public-facing API

queries, samples, etc.

I'll send you the notes @ericmjonas sent me on this.

:+1: Got it


Adding a note on default redis pubsub redelivery

https://github.com/dapr/dapr/issues/3481
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description

Issue reference

@tstojecki can you please move this note to the Redis component ref for pub/sub as per my comment?
https://docs.dapr.io/reference/components-reference/supported-pubsub/setup-redis-pubsub/


Error Log Reader Stopped on first init. and also catch adb version not match 40 to match this client 41

My Log First Run
➜  latihan flutter run
Using hardware rendering with device sdk gphone arm64. If you notice graphics
artifacts, consider enabling software rendering with
"--enable-software-rendering".
Launching lib/main.dart on sdk gphone arm64 in debug mode...
Failed to extract the most recent timestamp from the Android log:
ProcessException: Process exited abnormally:
adb server version (40) doesn't match this client (41); killing...
* daemon started successfully
adb: device offline
  Command: /Users/fahmiaffan/Library/Android/sdk/platform-tools/adb -s
  emulator-5554 shell -x logcat -v time -t 1.
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Running Gradle task 'assembleDebug'...                             30.7s
✓  Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app.apk...                 3.3s
Error waiting for a debug connection: The log reader stopped unexpectedly
Error launching application on sdk gphone arm64.

And Also My Flutter Doctor -v
[✓] Flutter (Channel stable, 2.10.1, on macOS 12.2 21D49 darwin-arm, locale en-ID)
    • Flutter version 2.10.1 at /opt/homebrew/Caskroom/flutter/2.8.1/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db747aa133 (2 days ago), 2022-02-09 13:57:35 -0600
    • Engine revision ab46186b24
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/fahmiaffan/Library/Android/sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✗] Xcode - develop for iOS and macOS
    ✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
      Download at: https://developer.apple.com/xcode/download/
      Or install Xcode via the App Store.
      Once installed, run:
        sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
        sudo xcodebuild -runFirstLaunch
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] VS Code (version 1.64.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (2 available)
    • sdk gphone arm64 (mobile) • emulator-5554 • android-arm64  • Android 11 (API 30) (emulator)
    • Chrome (web)              • chrome        • web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

I use macbook air M1 for this running apps

Please give a suggestion. i've many tried any blog for this issues. i already reinstalling android studio. adb driver and disable EasyTetherUSBEthernet.kext From This Blog

@Faisal282
Check this similar issue and underlying comments and see if they help.
Closing from here as this doesn't seem to be a Flutter issue.


Can interact with the same APC from both sides of a wall

this is in chem, I was able to see and interact with the same APC in both the hallway and inside the room

Yeah we really need a proper wallmount system.

Could close this in favour of #1238 as it's related.

Closing in favor of #1238.


Update README.md: Add build dependency installation guide for Debian

Hello. It took me a few minutes to find out I have to install libasound2-dev. And to reach this goal, I had to find that the software I am trying to build uses alsa-sys, find the repo, look into the .h file, see that it requires a header file, and finally with apt-file find this header file belongs to which package.
Hopefully, this PR will save time for the next person, especially if they haven't got prior experience with compiling stuff.

Thanks!


allow yaml configuration for pure commands and pure filenames

Currently Timmy supports "cmds" and "files" where content is filenames containing data.
We should also support pure data inside yaml, so that a user could define shell code to be executed or specific files to download right inside yaml.
Smth like this:
cmds:
    - 'ps -ef | grep nova'
files:
    - '/var/log/nova*'

Implemented in:
https://github.com/adobdin/timmy/commit/e865055ca85cad11214ec7b3a7683544df0302c5
https://github.com/adobdin/timmy/commit/d9c2acbe3345c0b29632375f07287be1adb6c231
waiting to be merged to master


Fixing translations for malayalam language (ml)

I did the changes within translations.py & translations_v2.py. I couldn't find the words - morning, noon, evening, night and the days and month. Where do I find this?

Thanks a lot! I've merged it. Please test and please add your name to the translators list (share/translation.txt)


'RNGoogleSignin.h' file not found still exist

I follow carefully the setup guide till i reached adding #import <RNGoogleSignin/RNGoogleSignin.h> or #import "RNGoogleSignin.h" but neither of them working
"react-native": "0.57.1"
"react": "16.5.0",
"react-native-google-signin": "^1.0.0-rc8"

please make sure the path to react-native-google-signin is in the header search paths in build settings of your target

closing since there was no response and no repro, hope it has worked


missing files in cells/ ?

https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/tree/main/cells currently only seem to contains klayout and xschem pcells.
In comparison the sky130 repo has a lot more:
https://github.com/google/skywater-pdk-libs-sky130_fd_pr/tree/main/cells
🍉 find skywater-pdk-libs-sky130_fd_pr/cells/ -type f | xargs -n1 basename | cut -f 2- -d '.'  | sort | uniq -c
     23 bins.csv
    270 cdl
    261 corner.spice
    261 data
    289 gds
    346 json
    289 magic.lef
     99 model.spice
    270 netlist.tsv
      1 out
     88 pm3.spice
    637 spice
    802 svg

should we have the equivalent for gf180mcu?

@atorkmabrains

@QuantamHD We didn't split the model files. We kept it as is. It's better for the simulator. Not sure what is the request here.

@atorkmabrains - We should prioritize humans and maintenance not software.

@mithro Do you want us to split the files?


Test support for Mac OS

@reyammer This should be doable using githuh workflows. I can send a Pull Request

Thanks! Is there a way to test the actual magika package that people install from pip, rather than just running the tests in a macos environment? my current gh workflow does the latter, but we may want to improve.

Much appreciated, @gaby!
Ideally, we'd like to build some decent CI for all sort of platforms. So, bonus points if your PR can be used to start something like that.

IIRC you can specify something like this in gh action: os: [ubuntu-22.04, macos-latest, windows-latest]. Is this the direction, @gaby?
But independently from this, the current CI does "poetry install + pytests tests"... which is a good starting point, but not THE tests I would also like to have... ideally we should test for "what people install with pip install magika". Created #158 to track this additional aspect.

@reyammer Correct, that will run the tests in that enviroment.
I was thinking that you could have a workflow that does the pip install and runs against the tests_data/ directory to verify it can run on that platform

I have Python 3.12 installed via MacPorts on macOS 14.3.1. on a MacBookPro 13inch M2
When I try to install magika with pip312 I get the following error message:
pip-3.12 install magika
Defaulting to user installation because normal site-packages is not writeable
ERROR: Ignored the following yanked versions: 0.1.0
ERROR: Ignored the following versions that require a different python version: 0.5.0 Requires-Python >=3.8,<3.12
ERROR: Could not find a version that satisfies the requirement magika (from versions: none)
ERROR: No matching distribution found for magika

I haven't tried the pip3 which comes with the latest XCode. It might work as python3 --version gives me 3.9.6

@ehjmx Probably needs to be installed in a venv. The dependencies are conflicting with the ones from the OS

I'm updating the workflows to run on multiple platforms/python version. I can confirm that the tests only pass on linux and macos. When using windows a significant amount of tests are failing.


TE-1.2: My Station MAC

@dplore ,
@yashikakn would like to sign up TE-1.2. Can you assign this test case to her ?
Thanks,
Joann

@xw-g can you confirm if this test is ready for implementation?

Yes, the test case is ready.

@yashikakn can you give us an estimated date for completion of the implementation for this test case?

Hi Darren,
I shall target for 1/17.
Thanks


jenkins-plugin: properly handle cancelled jobs

Bug 1357752
Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1357752
Detailed explanation
The pipeline plugin needed to throw InterruptedExceptions instead of
swallowing them in order to properly handle cancelled jobs

Also note - I've updated the PR tester job with @jupierce 's new PR testing changes ... so vetting that piece with this PR as well.

Note - manual testing based on bugzilla scenario looks good, including the cancel of the app build per suggestion from @bparees
Jenkins job output:
Starting the "Trigger OpenShift Build" step with build config "nodejs-mongodb-example" from the project "myproject".
  Started build "nodejs-mongodb-example-1" and waiting for build completion ...
Operation will timeout after 900000 milliseconds
Aborted by anonymous

Starting the "Cancel OpenShift Builds" step with build config "nodejs-mongodb-example" from the project "myproject".
Aborted by anonymous
  Cancelled build "nodejs-mongodb-example-1".

Exiting "Cancel OpenShift Builds" successfully with 1 builds cancelled.
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Aborted by anonymous
Aborted by anonymous

Output from oc get builds:
gmontero ~/go/src/github.com/openshift/origin  (master)$ oc get builds
NAME                       TYPE              FROM          STATUS      STARTED              DURATION
nodejs-mongodb-example-1   Source            Git           Cancelled   20 seconds ago       6s
sample-pipeline-1          JenkinsPipeline                 Cancelled   About a minute ago   51s

Regression testing of the freestyle sample job also passed.
Lastly, the update to the PR test job looks good.  We are calling @jupierce 's new script and passing the new env var to the extended test invocation and things got invoked correctly.  Some of the known issues with the extended test are still out there waiting to get their fixes merged (https://github.com/openshift/origin/pull/11711)
Unless we have more real fixes required, I'll do a test PR to verify everything is in order once all the origin side dependencies have merged.
Will push updates momentarily, allow some time for review before merging and cutting next level for QE to verify.

additional cancels pushed

lgtm


ReadFileNoStat causes issues collecting mountinfo with high number of mounts

We have some unique hosts that have very high numbers of NFS mounts (1000+), which causes some issues with the 512kb limit imposed by ReadFileNoStat.
On some of the hosts, I have noticed errors like this cropping up, where the error shows a truncated mountinfo line.
couldn't find enough fields in mount string: 32184 30884 0:619 / /x ro,relatime shar

Inspecting /proc/self/mountinfo for this mount shows no error and the line looks fine and has 11 space separated elements.
Looking at the size of the mountinfo file in the proc structure, the server is sitting above the 512kb limit.
$ wc -c /proc/self/mountinfo
557896 /proc/self/mountinfo

It looks like mountinfo was changed from using os.Open to util.ReadFileNoStat in this merge request.
https://github.com/prometheus/procfs/pull/228/files
Would the correct approach here be to revert back to opening /proc/self/mountinfo with os.Open?

That is a lot of mounts.

Go back to using a scanner.
Make  ReadFileNoStat function have a configurable buffer size.
Increase the default size to 1MiB.

Increasing the default max buffer size to 1MiB is probably the easiest thing to do.


save option while installing Office JavaScript SDK

Category

[x] Content fix

What's in this Pull Request?
Included --save option to enable NPM to include the packages to dependencies section of the package.json file.
Guidance
Included --save option to enable NPM to include the packages to dependencies section of the package.json file.

@nanddeepn  - I installed @types/office-js without save, it is automatically added into package.json.
As per NPM install docs (https://docs.npmjs.com/cli/install), by default, npm install will install all modules listed as dependencies in package.json.
This seems to be the case since npm 5 release according to this official blog post (https://blog.npmjs.org/post/161081169345/v500) dated May 2017.
@VesaJuvonen - Could you please confirm on this?

--save is when you want something added to the dependencies group (and it's also the default on modern NPM so it's not really needed). --save-dev puts it in devDependencies. More here https://docs.npmjs.com/cli/install
Type declaration packages are never used in production, so they shouldn't be saved to dependencies. They are only during development as they are used to annotate JavaScript libraries that don't define their own type declarations.

Thanks for your clarification @andrewconnell


Visual Studio Code Insiders Crashes on Clicking Ribbon Menu in Version 1.95.0

Type: Bug

VS Code Version: 1.95.0_insider+1728048601-1
OS Version: Arch Linux

Steps to Reproduce:

Open Visual Studio Code Insiders.
Click on the ribbon at the top where "File" is located.
The application crashes immediately.

Expected Behavior:
The "File" menu should open without causing the application to crash.
Actual Behavior:
Clicking on the ribbon causes the application to crash.
Additional Context:

This issue occurs consistently after upgrading to version 1.95.0.
Downgrading to version 1.94.0_insider+1727701314-1 resolved the issue, indicating a possible regression in the latest release.
Using "Extension Bisect" did not help identify the cause of the issue.

Error Logs:
[716052:1005/134916.942791:FATAL:check.cc(376)] Check failed: false. NOTREACHED log messages are omitted in official builds. Sorry!
[1005/134916.951322:ERROR:elf_dynamic_array_reader.h(64)] tag not found
[1005/134916.952469:ERROR:elf_dynamic_array_reader.h(64)] tag not found
[1005/134916.961740:ERROR:directory_reader_posix.cc(43)] opendir /home/ryandward/.config/Code - Insiders/Crashpad/attachments/ad3e9791-0dff-41dc-9bee-e58033518366: No such file or directory (2)

Steps Taken to Resolve:

Downgraded: Downgraded to version 1.94.0, which worked without crashes.
Attempted Workarounds:

Ran code-insiders --disable-extensions, but the issue persisted.
Deleted configuration files and reinstalled, but the issue remained.
Attempted --disable-gpu, which also did not resolve the problem.

 Reverting to b7894e64 aka 1.94.0 fix the issue.

The c33745f66ce1cd626c3282112671e2a66471ce4f snap (rev 1756) is working properly.

Clicking the file menu crashes on Ubuntu 22.04 with the latest two versions:

code-insiders_1.95.0-1728049707_amd64.deb
code-insiders_1.95.0-1728281106_amd64.deb

Same issue here (attempting to open or navigate to the File menu causes a core dump crash, any other menus seem ok) on Ubuntu 20.04, 1.95.0-1728281106, updated with apt from the official vscode repo this morning.
Reverting to 1.95.0-1728049707 doesn't help, but downgrading to 1.95.0-1728022095 does - the File menu no longer crashes with<PHONE_NUMBER> (c33745f).

Hi there,
same issue on Ubuntu 24.04.

Hi! Same issue here on Linux Mint.

Also on Fedora latest

Today's update 1.95.0-1728367601 still crashes the same way on Ubuntu.

Same here with Debian, still crashing on clicking FILE menu.  Would really appreciate a fix for this -- I can work around not having access to the FILE menu, short-term, but it's definitely a significant pain point.
I'd switch to stable, but another problem prevents me from doing that, so lacking an easy means to download and reinstall an older (working) Insiders build, I'm kind of stuck.  Issues like this actually make a very solid case for keeping prior versions of Insiders builds available, IMO (if they are, short of building from source from some tag I cannot find, I cannot figure out how to do so).

I have the same issue in Ubuntu 22.04.5 LTS after the latest update. Also the FILE menu specifically
Version: 1.95.0-insider
Commit: a016ec9b66ffdd3ff0f831768b8e75be008a54e4
Date: 2024-10-09T05:04:08.601Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.5.0-26-generic

This morning update on the Ubuntu repo (1.95.0-1728454020) still hasn't fixed this.
@gwiede if you're using the official apt repo you might be able to downgrade to the previous 1.95 insiders build that doesn't have this silly UI bug -- this works for me in Ubuntu 20:
apt install code-insiders=1.95.0-1728022095

This morning update for the ubuntu apt repo (1.95.0-1728454020) still hasn't fixed this.
@gwiede if you're using the official apt repo...

Nope, IT restrictions.  It's okay, I'm coping, just hope they fix it soon, it's kind of ridiculous it slipped through testing.

Hi there. The last Update has not fixed the problem

Update on this crash, it is triggered by the menu item File > New File... (command: welcome.showNewFileEntries) which has accelerator https://github.com/microsoft/vscode/blob/e62dc67d6252105edfffa9b5222546b67538b40a/src/vs/workbench/contrib/welcomeViews/common/newFile.contribution.ts#L34. The runtime on Linux cannot handle Win or Super keys for accelerator shortcut and they always end up reaching this block https://source.chromium.org/chromium/chromium/src/+/main:ui/base/accelerators/accelerator.cc;l=413 which has not been a fatal call in chromium up until a recent runtime update (despite its name it only logs in release builds and in debug builds it will crash). Chromium has changed its implication in release builds starting with Electron 32 to crash as intended.
For long term, we should guard against these accelerator registrations in Electron to avoid such crashes, I will follow-up on this.
I am discussion with @bpasero to get a short term fix in vscode. In the meantime, users can workaround this issue by overwriting the shortcut via Preferences: Open Keyboard Shortcuts and update the shortcut for welcome.showNewFileEntries to exclude the super key.

Thank you @deepak1556 for the explanation. Indeed, changing that particular shortcut to Ctrl+Shift+Alt+N solves the issue for me and I can use the latest build.
Fortunately I do not have that Windows/Super/meta key assigned to any other shortcuts displayed in the menus. I tested that if I assigned the "meta" key to any other shortcuts exposed in the menus, that is then crashing vscode when THAT menu is to be displayed, as predicted by your explanation.
But this must be one of the silliest UI display bugs I've seen -- just displaying the "Super" text next to a menu item crashing a whole app?!
Especially considering that displaying that same shortcut text in the Keyboard Shortcut dialogs (though the key is also shown as "meta" while the key combo is being recorded), has no such issues on that part of the UI:

Same issue. Selecting "File" menu with and without "--disable-extensions".
Resolution
Steps to workaround as per above

Open VS Code (I happen to have the Insiders edition)
Press <ctrl> + <k> then <ctrl> + <s>
in search box add "@source:system welcome.showNewFileEntries"

Press  to select field shown.
In the dialogue box I submitted <ctrl> + <shift> + <atl> + <n>

"File" menu works.

Version: 1.95.0-insider
Commit: 4b4bf8f594077c3dc53ef70518531f64ed566194
Date: 2024-10-11T18:44:53.770Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.11.0-8-generic

Same issue. Selecting "File" menu with and without "--disable-extensions".
Resolution
Steps to workaround [as per above] (#230604 (comment)) from deepak1556

Open VS Code (I happen to have the Insiders edition)
Press <ctrl> + <k> then <ctrl> + <s>
in search box add "@source:system welcome.showNewFileEntries"

Press  to select field shown.
In the dialogue box I submitted <ctrl> + <shift> + <atl> + <n>

"File" menu works.
Version: 1.95.0-insider
Commit: 4b4bf8f594077c3dc53ef70518531f64ed566194
Date: 2024-10-11T18:44:53.770Z
Electron: 32.1.2
ElectronBuildId: 10323173
Chromium: 128.0.6613.162
Node.js: 20.17.0
V8: 12.8.374.33-electron.0
OS: Linux x64 6.11.0-8-generic

Thank you, really appreciate you shared your approach to this issue with us. Have a nice sunday

the same issue for me but the crash occur when mouse hover on "file" button

This problem got resolved for me today, see my comment https://github.com/microsoft/vscode/issues/213906#issuecomment-2432740394

Same here, Arch Linux.
Version: 1.95.0
Commit: 912bb683695358a54ae0c670461738984cbb5b95
Date: 2024-10-30T10:28:58.606Z
Electron: 32.2.2
ElectronBuildId: undefined
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Linux x64 6.11.5-zen1-1-zen

Issue is still occurring for me.
Version: 1.95.0
Commit: 912bb683695358a54ae0c670461738984cbb5b95
Date: 2024-10-30T10:28:58.606Z
Electron: 32.2.2
ElectronBuildId: undefined
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Linux x64 6.11.5-zen1-1-zen

@mbc3 @rocketguedes ElectronBuildId: undefined indicates you are using an unofficial package, please follow https://github.com/microsoft/vscode/issues/232723 which will help get fixes into those packages eventually.

@mbc3 @rocketguedes ElectronBuildId: undefined indicates you are using an unofficial package, please follow #232723 which will help get fixes into those packages eventually.

thank you, I will wait for the next build of OSS and in the meantime, use the workaround mentioned here to set "window.titleBarStyle" to "custom": https://github.com/microsoft/vscode/issues/232723#issuecomment-2449582575

Same here Arch Linux

Same here Arch Linux

I also have Arch, and it happened for me.
Reverting to 1.94.0 fixed it.
yay -S downgrade
sudo downgrade code
...then choose 1.94.0

Encountered the same issue on both KDE Plama 6 running on Xorg and Wayland, definitely an applicative bug.
System info:

OS: Arch Linux (installed 2024/11/10)
Kernel: 6.11.6-arch1
Architecture: x86_64
WM/DE: kwin / Plasma 6.2.3
GPU: nvidia unfree driver / Nvidia GTX 970
vscode version : 1.95.1, d3e5cb6, x64

Same here.
OS: Arch Linux x86_64
Kernel: 6.11.6-arch1-1
DE: Hyprland
CPU: Intel i7-2760QM (8) @ 3.500GHz
GPU: nvidia-470xx-dkms driver / NVIDIA Quadro 2000M
vscode version: codium-git / <IP_ADDRESS>07.r5
#230604 fixed it for me as well

I too am experiencing this.
OS: Arch Linux x86_64
Kernel: 6.6.60-1-lts
DE: Plasma 6.2.3/Wayland
CPU: AMD Ryzen 9 5950X
GPU:  NVIDIA GeForce RTX 3060, driver 565.57.01
version info:
Version: 1.95.1
Commit: 65edc4939843c90c34d61f4ce11704f09d3e5cb6
Date: 2024-11-01T17:20:55.708Z
Electron: 32.2.3
ElectronBuildId: undefined
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Linux x64 6.6.60-1-lts

trace.txt

Can confirm that clearing keyboard shortcuts to showNewFileEntries does fix the issue for me in Arch, version 1.95.1-1. Downgrading to 1.94.0-1 also works.

Also confirmed in Ubuntu 22.x/23.x/24.x 👍

Same happens on Gentoo based MocaccinoOS

Note for anyone building vscodium or code-oss, I back-ported the Electron update that fixes this to 1.95.3 here


DAS needs if-case/switch pattern support for MakeFinal

Follow-up from: https://github.com/dart-lang/sdk/issues/51863
(Will require a linter in DEPS that includes https://github.com/dart-lang/linter/pull/4225.)

https://dart-review.googlesource.com/c/sdk/+/292400


Add GitHub notifications via Steward to the flow of onboarding a new team member

In the flow for onboarding a new team member, we should add the GitHub Steward notification feature (the one that sends you a PM whenever you are mentioned in a GitHub notification).
This will allow the new team member to only have to remember to check one place, IRC, not two (IRC & GitHub).
Thoughts @zachlatta?

What if we created a new heading called Managing GitHub Notifications and
mentioned Steward and email filters without saying they should do one or
another?
On Wed, Aug 26, 2015 at 5:59 PM, Jonathan Leung<EMAIL_ADDRESS>wrote:

In the flow for onboarding a new team member, we should add the GitHub
Steward notification feature (the one that sends you a PM whenever you are
mentioned in a GitHub notification).
This will allow the new team member to only have to remember to check one
place, IRC, not two (IRC & GitHub).
Thoughts @zachlatta https://github.com/zachlatta?
—
Reply to this email directly or view it on GitHub
https://github.com/hackedu/meta/issues/114.

--
Zach Latta
hackEDU |<EMAIL_ADDRESS>

@zachlatta sounds good to me!

Cool, let's do this. This should be in onboarding_protocol.md.

Can directors get this too?

@paked Yep! Check out https://github.com/hackedu/meta/pull/139/files


I am getting:  TypeError: u.result is undefined.

I am getting this error, did probably the api from deepl change from 'result' to 'text' ?

The translation works, it seems that the wrong key is read from the response. Or am i missing something?

Okay after installing it via composer instead of using the zip it works! Thank you for this! :)


Dropdown issue with assistive technology

When I reach combobox screenreaders tell me that I'm in this kind of element. But when I enter the element and try to row down with arrow keys the list that select2 provide me don't alert any change on foccus elements.

I've noticed a similar problem. Specifically when there is a filter box in the dropdown. The focus of the screenreader seems to go into that box instead of to the dropdown. By navigating to the combobox again you can kinda trick the system. But it would be nice if this would be fixed.

i have this problem too! do you know why it is generated as a  with  elements?
the first paragraph here says that it should be a  with
https://select2.org/options


Implicit locale in file name doesn't work anymore

Steps to reproduce

Create a template file with i18n specified in the name, e.g. imprint_component.de.html.erb This worked with view_component < 3.15. I guess it broke with the format support.
Expected behavior

The template is found and rendered.
https://guides.rubyonrails.org/i18n.html#localized-views
Actual behavior

NameError thrown
Backtrace:
NameError:
  undefined local variable or method `call_de' for class Common::Pdf::SpecialPages::ImprintComponent
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/inline_template.rb:10:in `method_missing'
# ./app/components/common/pdf/special_pages/imprint_component.de.html.haml:in `compile_to_component'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/template.rb:48:in `class_eval'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/template.rb:48:in `compile_to_component'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/compiler.rb:59:in `block (2 levels) in define_render_template_for'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/compiler.rb:58:in `synchronize'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/compiler.rb:58:in `block in define_render_template_for'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/compiler.rb:57:in `each'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/compiler.rb:57:in `define_render_template_for'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/compiler.rb:40:in `compile'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/base.rb:569:in `compile'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/engine.rb:84:in `each'
# ./vendor/bundle/ruby/3.3.0/gems/view_component-3.15.1/lib/view_component/engine.rb:84:in `block (2 levels) in <class:Engine>'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:99:in `instance_eval'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:99:in `block in execute_hook'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:87:in `with_execution_control'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:92:in `execute_hook'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:78:in `block in run_load_hooks'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:77:in `each'
# ./vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/lazy_load_hooks.rb:77:in `run_load_hooks'
# ./vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/application/finisher.rb:93:in `block in <module:Finisher>'
# ./vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/initializable.rb:32:in `instance_exec'
# ./vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/initializable.rb:32:in `run'
# ./vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/initializable.rb:61:in `block in run_initializers'
# ./vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/initializable.rb:60:in `run_initializers'
# ./vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/application.rb:426:in `initialize!'
# ./config/environment.rb:7:in `<top (required)>'
# ./spec/rails_helper.rb:6:in `<top (required)>'
No examples found.

System configuration
Rails version:
7.1.4
Ruby version:
3.3.5
Gem version:
3.15.1

@harm-matthias-harms thanks for the report- looks like we are missing a test case in our suite. Would you be willing to open a PR with a failing test for this case?

@joelhawksley I stumbled upon this today too, and it's because of the refactor to @call_method_name. For localised files, it's trying to define call_de instead of call because it now uses the format from the compiler.
For localised files, the format is <locale>html instead of html only.
One very easy way to see the error is to add a component.de.html.erb file in test/sandbox/app/components and to run the test suite, as it'll quickly crash with the above error.
I have such a file on a fork if you like, I can open a PR if needed.

Closed by https://github.com/ViewComponent/view_component/pull/2118/


add a --no-parse option to fio collect

This is working but needs some review.
It should work with --record-buffered and --no-record-buffered, and with line-delimited and rs-delimited sequences.
if we're not parsing the json, we can't transform it so the --src-crs option isn't compatible with --no-parse and raises a click usage error.
I'm not thrilled at adding lots of if statements everywhere; there might be an entirely different way to structure this logic that doesn't result in so many nested conditionals.
resolves #306

Yeah, at the very least get the ifs out of the for loops. It strikes me that the only thing done to features coming from the generator is serialization and writing... maybe there's a function that loads and transforms and dumps and yields GeoJSON text when --parse vs one that just yields the GeoJSON when --no-parse?

So I took a stab at this but am not crazy about round 2 - basically I am stuck repeating all the rs delimiting logic in the parse vs no-parse variants of the function. Still, it improves the readability a bit so I'm pushing it.

@perrygeo this ready? I like it.

Functionality wise, ready to go.
There is a cleaner way to organize the flow. Having 4 definitions of feature_text_gen is a bit strange. But we can refactor later.


Report hand tracking aiming gesture state

XrHandTrackingAimStateFB can be used to report the aiming gesture state (e.g: pinch level for each finger).
While adding support for this is straightforward, we need to figure out (and document) the proper mechanism to dispatch pinch events to the Godot game logic.

@BastiaanOlij Any suggestions for how to dispatch pinch events?
One option would be to leverage InputEventAction with predetermined action strings for each finger pinch events.

I've already gone down the rabbit hole of trying to use Godots action system but it's really centered around Godot determining which user defined actions to trigger based on received inputs.
This is why for Godot 4 I eventually abandoned that idea and actually implemented the OpenXR action system as is and naming inputs.
My understanding of OpenXR is that the approach should be that an extension is created that defines a new interaction profile with the required input paths. So there would be a /input/pinch_index/value and /input/pinch_middle/value or something like that for the pinch values, and a /input/aim/pose as per usual. You can then map that to your own action. That would also mean that switching between holding a touch controller and full hand tracking would result in the interaction profile changing between /interaction_profiles/oculus/touch_controller and /interaction_profiles/oculus/hand (or whatever it would be called) which also means we know that there won't be any normal button inputs. Anyway I am ranting as usual on how I think things should be, not on how they are :P (though feel free to advocate this if you agree this solution matches the spirit of OpenXR much better then Metas current approach to this)
In this case I'm not sure if these inputs warrant events though, as they are values it's not a switch between on and off and would result in a constant stream of events.
My gut feeling says that we should expose these as separate controllers, it's a shame I'm not finished yet with the HTC tracker implementation (was waiting on a fix by Valve which is now in beta) as I'm making changes to the input map that would help out greatly here as it will be possible to register more devices that can be tracked.
We're now using slot 1 and 2 for the left controller and right controller, we could use slot 3 and 4 for the left hand and right hand. If the FB extension is active and if the hands are tracking we use the the aim pose as its position, and we use the pinch values to set the 4 axis.
Seeing we're still piggy backing on the joystick API you could use Godots input map to trigger events if you really want to but here you run into the fundamental limitation that there is no guaranteed order to the joystick entries, whichever controller is switched on first becomes the first entry.

Leveraging the controller api was a thought, but I'm worried this will introduce confusion for the users. If you look at the current hand tracking documentation (that you wrote :p), there's no mentions of controllers; hand tracking is a separate system with its own logic.
I think the controller approach may work if we condense the current set of classes to support hand tracking (OpenXRHand, OpenXRPose, OpenXRSkeleton) into a single HandController like extension of ARVRController.
From the Godot end user point of view, this may be a win; right now there's inherently complexity in setting up hand tracking, what if we just offered the option to switch between a regular ARVRController and HandController instance to add basic hand tracking support.

I don't think they can be combined into a single implementation seeing the Skeleton class applies specifically to the skeleton node containing the bones. Though seeing the way things are in Godot 4 now, that solution may not be possible anymore anyhow so there are some ideas I have about having a hand controller node where you set a nodepath to the skeleton it needs to update.
I very much like the idea of the hand controller node, it communicates much better that the controller and the hand are individually tracked, for SteamVR we will always have an active controller node tracking the controller, and an active hand node tracking the hand and offering the skeleton functionality.
On Oculus runtimes either the controller will be active, or the hand tracking will be active.
Something we can think about is whether we want to detect the situation where we have an active controller but no active hand, and create a fallback and animate bones ourselves using controller inputs (similar to what xr-tools does right now).
Similarly, if the FB extension isn't available we can determine the pinch strengths ourselves (well they would actually just be exposing trigger and grip values as approximations I guess).
This would allow us to create as much portability between platforms (though I suggest leaving some of this compatibility work for Godot 4)
Lastly, for the skeleton we now have mode where we update the positions of child nodes, a mode where we update the pose of a skeleton, we need a third one where we introduce a new component for the animation tree. This will allow you to use the animation tree to override the inputs and morph the hands into a predetermined position. Say when a player grabs an object, you want to make sure fingers are placed in predefined positions instead of their physical orientation.

Implemented by https://github.com/GodotVR/godot_openxr/pull/197


Articles don't get loaded if there is already one with the same title

Newsboat version (copy the output of newsboat -v or the first line of git show):
newsboat 2.18.0 - https://newsboat.org/
Copyright (C) 2006-2015 Andreas Krennmair
Copyright (C) 2015-2019 Alexander Batischev
Copyright (C) 2006-2017 Newsbeuter contributors
Copyright (C) 2017-2019 Newsboat contributors

newsboat ist Freie Software und steht unter der MIT-Lizenz. („newsboat -vv“ zeigt den vollständigen Lizenztext an.)
Es wird die unter der MIT-Lizenz stehende Bibliothek JSON für Modernes C++ verwendet: https://github.com/nlohmann/json

newsboat 2.18.0
System: Linux 5.4.17-30-tkg-pds (x86_64)
Compiler: g++ 9.2.0
ncurses: ncurses 6.1.20180127 (compiled with 6.1)
libcurl: libcurl/7.68.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh2/1.9.0 nghttp2/1.39.2 (compiled with 7.67.0)
SQLite: 3.31.1 (compiled with 3.30.1)
libxml2: compiled with 2.9.10

I just noticed that one Article(probably more than one in the last couple of days) today didn't get loaded because there was already an Article with the exact same title(within the same feed, but with a different timestamp). I assume that newsboat only checks if there is an Article with the same title & same feed url in the database, but without checking if the timestamp is the same.

Hi!

I assume that newsboat only checks if there is an Article with the same title

Normally it doesn't, because standards require each item to have a unique identifier. However, some feeds break the standard, so Newsboat tries to generate the ID from whatever is available, including the title. If you can show the URL of the feed in question, I can take a look to see if there's IDs in there.

It happened with this URL: https://www.mindfactory.de/xml/rss/mindstar_artikel.xml
Basically it's a feed with special deals from an online shop. It looks like there is a guid set, but it's just the link to the product, so if the same product is on sale in the future, it won't add a new "Article" because the guid is the same...

Yup, looks like you're right. The feed is conformant to the spec, but is practically broken.
Id' email the site owner and explain the situation, if that's possible. They might not care, though, and might decide to take the feed down instead of fixing it.
What you can do is: write a script that reads RSS on standard input, adjusts the <guid> field (e.g. adding a date in there, and setting isPermalink to false), then prints out the modified RSS onto standard output. Then use it with filter: in the urls file.

Thanks for the suggestion! I'll try writing the script to do that.


Manually select Youtube video for a given Spotify song

What is the purpose of your issue?

[ ] Bug
[x ] Feature Request
[ ] Question
[ ] Other

Description

The song matching works great most of the time but when it comes to more niche songs / remixes, I've noticed that it will incorrectly match the songs, even when using -m, none of the results are a match.
Would you be able to add a feature where we can specify a Youtube video as the match for a Spotify song link so that the song file would have the correct metadata and audio?
Thanks!
Log

You mean advanced-usage#apply-metadata-from-a-different-track?

That's exactly it. Thanks.


[KYUUBI #3735] Support extracting lineage from CACHE table context

close #3735
Why are the changes needed?

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #3736 (52891e5) into master (f21ad83) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3736      +/-   ##
============================================
+ Coverage     52.56%   52.59%   +0.02%
  Complexity       13       13
============================================
  Files           492      492
  Lines         27705    27706       +1
  Branches       3830     3830
============================================
+ Hits          14564    14571       +7
+ Misses        11753    11749       -4
+ Partials       1388     1386       -2

Impacted Files
Coverage Δ

.../SparkOperationLineageQueryExecutionListener.scala
71.42% <100.00%> (+4.76%)
:arrow_up:

...ache/kyuubi/operation/KyuubiOperationManager.scala
79.45% <0.00%> (-2.74%)
:arrow_down:

...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala
89.27% <0.00%> (-0.70%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
80.74% <0.00%> (-0.63%)
:arrow_down:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
74.64% <0.00%> (ø)

...a/org/apache/kyuubi/service/TFrontendService.scala
91.47% <0.00%> (+0.29%)
:arrow_up:

...he/kyuubi/ha/client/etcd/EtcdDiscoveryClient.scala
68.23% <0.00%> (+0.58%)
:arrow_up:

...ache/kyuubi/server/mysql/MySQLGenericPackets.scala
78.72% <0.00%> (+2.12%)
:arrow_up:

...ache/kyuubi/server/mysql/MySQLCommandHandler.scala
79.54% <0.00%> (+4.54%)
:arrow_up:

.../kyuubi/server/mysql/constant/MySQLErrorCode.scala
20.00% <0.00%> (+6.15%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wForget can you help me review it again

cc @ulysses-you

thanks, merging to master


fix: enable clickhouse console logging

Description
This PR sets the clickhouse log level to console.

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@bmtcril updated

@Ian2012 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


[nfs-client-provisioner] PV stuck in pending state

Hi,
currently i'm trying to get the nfs-client-provisioner running on a Raspberry Pi Kubernetes cluster. I could already sucessfully deploy the provisioner in an ARM compatible docker container (see https://gitlab.com/rpikube/nfs-provisioner-arm32v7 for details). During claiming a PV with the nfs-client-provisioner i encountered 2 issues.

The name of the PV has to be ${pvName} instead of ${namespace}-${pvcName}-${pvName} because otherwise i get stucked in an endless loop because it tries to provision the PV again and again (because it tries to find a PV with the name ${pvName} instead of ${namespace}-${pvcName}-${pvName} in controller.go). I could solve this issue by modifing the pvName from
pvName := strings.Join([]string{pvcNamespace, pvcName, options.PVName}, "-") to pvName := options.PVName

The second problem is that the PV and PVC stucks in pending state without any errors. I enabled verbose logging as well but there seems to be nothing wrong (see nfs-client-provisioner.txt). The directory gets sucessfully created on the NFS server with permissions 777 owned by nobody:nogroup

I also attach the deployment.txt which contains everything to setup the nfs client provisioner including rbac authorization and psp.
Any help would be appreciated.
Thanks

Kubernetes v1.6.4 (installed with kubeadm)
nfs-client-provisioner built from master

is indeed an error although it's kind of harmless, nice catch I will fix it.
We need to check the kubernetes controller-manager logs to see why the PV and PVC are not getting bound. They look correct to me, they should get bound

{
  "kind": "PersistentVolume",
  "apiVersion": "v1",
  "metadata": {
    "name": "pvc-d5dcab66-5437-11e7-bfac-b827eba95799",
    "selfLink": "/api/v1/persistentvolumespvc-d5dcab66-5437-11e7-bfac-b827eba95799",
    "uid": "d629e1ed-5437-11e7-bfac-b827eba95799",
    "resourceVersion": "119028",
    "creationTimestamp": "2017-06-18T15:07:25Z",
    "annotations": {
      "pv.kubernetes.io/provisioned-by": "rpikube/nfs"
    }
  },
  "spec": {
    "capacity": {
      "storage": "1Mi"
    },
    "nfs": {
      "server": "<IP_ADDRESS>",
      "path": "/mnt/ssd/pvc-d5dcab66-5437-11e7-bfac-b827eba95799"
    },
    "accessModes": [
      "ReadWriteMany"
    ],
    "claimRef": {
      "kind": "PersistentVolumeClaim",
      "namespace": "default",
      "name": "test-claim",
      "uid": "d5dcab66-5437-11e7-bfac-b827eba95799",
      "apiVersion": "v1",
      "resourceVersion": "119023"
    },
    "persistentVolumeReclaimPolicy": "Delete",
    "storageClassName": "nfs-client-provisioner"
  },
  "status": {
    "phase": "Pending"
  }
}

{
  "kind": "PersistentVolumeClaim",
  "apiVersion": "v1",
  "metadata": {
    "name": "test-claim",
    "namespace": "default",
    "selfLink": "/api/v1/namespaces/default/persistentvolumeclaims/test-claim",
    "uid": "d5dcab66-5437-11e7-bfac-b827eba95799",
    "resourceVersion": "119321",
    "creationTimestamp": "2017-06-18T15:07:24Z",
    "annotations": {
      "control-plane.alpha.kubernetes.io/leader": "{\"holderIdentity\":\"c2451b1c-5437-11e7-8392-32bb363c78cf\",\"leaseDurationSeconds\":15,\"acquireTime\":\"2017-06-18T15:07:24Z\",\"renewTime\":\"2017-06-18T15:09:23Z\",\"leaderTransitions\":0}",
      "volume.beta.kubernetes.io/storage-class": "nfs-client-provisioner"
    }
  },
  "spec": {
    "accessModes": [
      "ReadWriteMany"
    ],
    "resources": {
      "requests": {
        "storage": "1Mi"
      }
    }
  },
  "status": {
    "phase": "Pending"
  }
}

Hi,
thanks for the answer. Please see the log
kube-controller-manager.txt.
I guess the problem is that the persistent volume binder is not enabled:
{"log":"W0620 08:34:15.749212       1 controllermanager.go:546] \"persistentvolume-binder\" is disabled\n","stream":"stderr","time":"2017-06-20T08:34:17.025253666Z"}

Maybe it's related to https://github.com/kubernetes/kubernetes/issues/46770

Check your arguments to kube-controller-manager, specifically --controllers. It must have "-persistentvolume-binder" in it, which should be removed
https://kubernetes.io/docs/admin/kube-controller-manager/
--controllers stringSlice                                           A list of controllers to enable.  '' enables all on-by-default controllers, 'foo' enables the controller named 'foo', '-foo' disables the controller named 'foo'.
All controllers: attachdetach, bootstrapsigner, certificatesigningrequests, cronjob, daemonset, deployment, disruption, endpoint, garbagecollector, horizontalpodautoscaling, job, namespace, node, persistentvolume-binder, podgc, replicaset, replicationcontroller, resourcequota, route, service, serviceaccount, serviceaccount-token, statefuleset, tokencleaner, ttl
Disabled-by-default controllers: bootstrapsigner, tokencleaner (default [])

Thanks alot for your support. After removing "-persistentvolume-binder" everything works as expected!


add quotes to pip install 'opendp[polars]'

With just
pip install opendp[polars]

the shell tries to parse the square brackets, and fails:
zsh: no matches found: opendp[polars]

We should make sure it any extra installs are quoted in the docs:
pip install 'opendp[polars]'
Requirement already satisfied: opendp[polars] in ./.venv/lib/python3.12/site-packages (0.11.1)

Hi there, I'd love to help on this issue!

@devfernandoa -- Sure: probably just search for opendp[ across the docs and submit a PR.


Parameterize

Not just a hardcoded scenario any more!

+1; starts to look very interesting, would this already be able to drop-in replace our _stack in the current state?

Re: replacement, I think so.


Why not link to the KotlinConf talk covering Plaid?

Florina Muntenescu did a talk at this years KotlinConf covering the project to update Plaid to the new A.A.C. Could be worth linking to it in the ReadMe.md file.
https://www.youtube.com/watch?v=Sy6ZdgqrQp0
I hope this project becomes one of the standard Android/ A.A.C example projects, it's shaping up to be one of the better ones.

Thank you! Feel free to create a PR for this.


[Spotify Beta] How to dismiss Raycast on return key

Extension
https://www.raycast.com/mattisssa/spotify-beta
Description
When I do a search for song/artist like so:

I would like to on return to dismiss Raycast. So it starts playing the song/artist and I don't have to activate Raycast via hotkey again or esc 2+ times which is annoying.
Can I do this or this should be programmed into the extension?
Thank you.
Expected Behaviour
I want to quickly search for the song I want to play and quickly play it without having to manually dismissing Raycast. ♥

Okay apparently I can do this.

Glad you found it!


Mobile page menu

Sign in:

Not signed in:

Implementation is pretty minimal and slightly messy, but it's an improvement.
The reason I did this now is that I wanted to start on #2279 but didn't want to make things worse on mobile (for "My Groups" dropdown on the header subtask).

I don't see any issues with the code.

Thanks!
I think the decomposition into DesktopMenu / MobileMenu / UserControlsMenu is a tightly coupled, and desktop/mobile + signed in / not signed in states don't help, but it can be improved later, and I'll probably find a better way to structure it when I add "my groups" part.


Sidepanel example

Hello, I was using the template and needed to use it with the browser sidepanel, but there was no doc and no build step for the sidepanel, so i`ve made the necessary changes in this fork
I did not test it in Firefox due to an issue where it says that I can`t upload due to the ext being MV3.
Are the firefox builds currently working ?
I can open a PR with the changes if you see that it has any value for the project

Looks good!
I assume Sidepanel will slowly replace extension popups.

Love to see a PR! Thanks

Open ! sorry for the delay, was away for a couple of days.

One confusing thing about the sidepanel is how it is triggered. We've modified @FlavioZanoni code to remove the manifest's default_panel and default_popup actions as they trigger always either the sidepanel or the popup. Instead we used the following script in the background/main.js:
chrome.action.onClicked.addListener((tab) => {
  chrome.tabs.query({ active: true, currentWindow: true }, async (tabs) => {
    const currentTab = tabs[0]
    if (CONDITION) {
      chrome.action.setPopup({ tabId: currentTab.id, popup: "" })
      chrome.sidePanel.setOptions({ tabId: currentTab.id, path: "./dist/sidepanel/index.html" })
      chrome.sidePanel.open({ tabId: currentTab.id })
    } else {
      chrome.action.setPopup({ tabId: currentTab.id, popup: "./dist/popup/index.html" })
      chrome.action.openPopup()
    }
  })
})


Update copyright in LICENSE

Requested Update
This is more of a note that the LICENSE still attributes copyright to Dollar Shave Club as of 2017 and you might want to update it with a new line indicating the ownership lineage.
Why Is This Update Needed?
Generally ideal to keep the license and copyright up to date.
Are There Examples Of This Requested Update Elsewhere?
https://github.com/orgs/community/discussions/47161

@merrywhether sorry for the slow reply. What LICENSE do you feel? MIT

License type doesn't need to change, just adding a line showing new ownership. Made a quick PR for you.


[WIP] fix stddev and variance using creating 2 kernels

For some reason, when we chain both (in any order) or any .var() and .std() after .mean(), it fuses the kernel.
So a solution without adding a new Op or using a complex solution like Welford's algorithm as suggested by Fleetwood in Discord, would be making var chains mean by default. Hence this will make stddev to also have only one kernel.

Fixing the failing tests.

That's right, hence the nan value.
I'll take a couple more days on this, if there's still nothing, I'll just report some findings with the methods I've tried.

Yea this is just wrong


Fastnlight: Watch marketing.i3.com.ua

Fastnlight requests the watch of the watch_keyword marketing\.i3\.com\.ua. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

marketing\.i3\.com\.ua has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


install fails on lockfile>=0.9 not found

On a git clone, running python setup.py develop or python setup.py install fails with this:
Reading http://code.google.com/p/pylockfile/
No local packages or download links found for lockfile>=0.9
error: Could not find suitable distribution for Requirement.parse('lockfile>=0.9')

celerymon no longer depends on python-daemon!


Revert "CI: TEMP COMMIT: reduce the tests matrix"

Reverts valkey-io/valkey-glide#1881

Another approach was announceed in #1961. A fix for that will supersede this PR.


Promote methods that accept StyleBuilderApplicable instances to StyleSetter

Which ones? I could only find my applyFallbackStyle thingy which can't be promoted to StyleSetter as it needs to get the existing style first, and all other uses are static, except for its original usage in Style.Builder::apply, which maybe could be promoted to MutableStyleSetter or something? but idk if that's what you want


Changes related to clowder db integration.

@msvinaykumar also I think the requirement was that this needs to be over a volume mount rather than packaged inside the docker image

@msvinaykumar also I think the requirement was that this needs to be over a volume mount rather than packaged inside the docker image

@dinogun please check now I removed config.json pacaking under docker image. now everything is one single yaml file with support of volumemount and it supports community too.


Filter Names

Please mention filter names.
Thanks

Filters are named as "one", "two" and so on up to "sixteen",


How to handle stylelint's plugins

This is a rough one.
In order for stylelint to fully take advantage of this module, stylelint needs to be able to interpret plugins values in extended configs relative to the file that references them. This means that if Config A extends Config B, and Config B includes plugins, we can't resolve the plugins relative to Config A once everything has been merged: we have to resolve Config B's plugins as they load.
This seems like a special case ... but we really do need to enable stylelint or other modules that want similar plugin syntax to do what they want.
I see two options:

Build in special support for plugins, such that plugin resolution is done within cosmiconfig, and the resultant configuration object somehow exposes absolute paths to all plugins referenced.
Expose configuration objects to transforms as they load, which I imagine would have to be done with some event-style API, e.g.

.on('load', function(result) {
  result.config = transformConfig(result.config);
});

Any ideas welcome.
Right now I'm kind of leaning towards option 1, because I think this feature might only be required for plugins, so why build in more flexibility than necessary.

That seems to be related to extends which seems specific to stylelint so I am not even sure this should be in this module (I am saying that without all I need to understand, so I may say shit).
event/callback looks to be good solution to me.
But if you think a built-in solution is good, go ahead :)
ps: nice name for this module ^^

@MoOx Yeah, I think I'm going to try taking your advice and cutting out extends from this module, just putting it in stylelint. cosmiconfig could still do the important work of finding and parsing the configuration files that need to be found and parsed.

Removed extends. Leaving this to stylelint.


[MM23361] Focus remains in the RHS text box

Summary

This test ensures that the replies to a conversation focuses on the "Add a comment" textbox by default.
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/14081
Related Pull Requests

Has server changes - N/A
Has redux changes - N/A
Has mobile changes - N/A

Screenshots

Here is the screenshot at the end of the test:

/update-branch

Hello @clarmso, sorry for the delay. I was stuck with Cypress issues and totally missed this PR.  Will review this soon.

@prapti Ready for review

This PR still had the dev review label somehow and fell out out my radar. Very sorry about that. Reviewing it now.

/update-branch

Error trying to update the PR.
Please do it manually.

@clarmso There seems to be some conflicts in the test file that needs to be resolved. Would you mind resolving? I can then merge it :)

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

Oh no! I made a mess on this branch. (Something happened on the rebase...:( ) It'd be easier for me to open up a new branch to include my work.

I've recreated the PR here: https://github.com/mattermost/mattermost-webapp/pull/5722

No worries and thanks @clarmso!


[feature] rename all symbols between camelCase and snake_case

for python there is camel-snake-pep8
for javascript there is eslint/camelcase and eslint/snakecase
for typescript there is eslint/naming-convention
some languages will require different casings for different types
for example PascalCase for class names

convert can do that already

aah! also Use transform in Rewrite. but the docs have no full example
i just cant get this working... this should rename some_var to someVar
ast-grep always shows the interactive screen, but it should just patch input.py
cat >input.py <<'EOF'
some_var = 1
print(some_var)
EOF

cat >rules.yaml <<'EOF'
id: fix-case
language: python
rule:
  pattern: $X
  kind: identifier
transform:
  X2:
    convert:
      toCase: camelCase
      source: $X
EOF

ast-grep scan -U -r rules.yaml input.py

You also need a fix field to apply the fix.
id: fix-case
language: python
rule:
  pattern: $X
  kind: identifier
transform:
  X2:
    convert:
      toCase: camelCase
      source: $X
fix: $X2

aah ^^ thanks : )


chore: package name fix

Current dependencies on/for this PR:

master

PR #7   👈

This comment was auto-generated by Graphite.


fix: allow any assertion keys

this PR removes the condition to require keys to be "type".
some unrelated tests were previously passing, and are correctly failing now, others are passing which previously failed.
before:
Summary:
 ✔ 31 valid programs parsed without error
 ✔ 7 invalid programs produced a parsing error
 ✔ 4 invalid programs did not produce a parsing error (and allowed by the whitelist file)
 ✔ 127 valid programs produced a parsing error (and allowed by the whitelist file)
 ✔ 80495 programs were skipped

after:
Summary:
 ✔ 45 valid programs parsed without error
 ✔ 1 invalid programs produced a parsing error
 ✔ 10 invalid programs did not produce a parsing error (and allowed by the whitelist file)
 ✔ 113 valid programs produced a parsing error (and allowed by the whitelist file)
 ✔ 80495 programs were skipped

Published in<EMAIL_ADDRESS>


Added missing order fields

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #82   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          16     16
  Lines         482    482
=====================================
  Hits          482    482

Impacted Files
Coverage Δ

order.go
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd37f8...5632184. Read the comment docs.


Add Romanian translation

Changes

This PR will add translation for the Romanian language

Thank you for the PR 💜.


Request to add duration property to ExpansionTile widget.

Use case
I am currently using the ExpansionTile widget in my Flutter application and would like to have more control over the expansion and collapse animation duration. The current implementation has a hardcoded duration, and I believe it would be beneficial to expose this duration as a property for customization.
The hardcoded duration for the expansion and collapse animation is limiting for my use case. I would like to provide a custom duration for a more fluid and responsive user experience.
Proposal
I propose adding a duration property to the ExpansionTile widget that allows developers to customize the expansion and collapse animation duration. This would provide more flexibility and control over the user interface.
ExpansionTile(
  title: Text(directoryModel.directories[index].name),
  maintainState: true,
  leading: const Icon(Icons.folder),
  duration: Duration(milliseconds: 500), // custom duration
)

I think this is a duplicate of #138047 and has therefore already been implemented in #139664. 🥳

Thank you for pointing that out! I appreciate the information. I'm glad to hear that this feature has already been implemented in issue #139664. Looking forward to seeing it in action! 🎉

If you need it right now, it's available in the beta channel.

Thanks for linking the fix @fischerscode


sudo apt-cache policy docker-engine issue on Ubuntu Xenial

Hi, How did you deal with this issue ?
mastodon@xxxxxxxx:~$ sudo apt-cache policy docker-engine
N: Unable to locate package docker-engine

It is a known issue that has not been solved yet (from what I understand)
see https://forums.docker.com/t/problem-installing-docker-on-ubuntu-xenial-16-04/9273 and https://github.com/docker/docker/pull/21461#issuecomment-205303292

Hmm, I'm unable to reproduce the issue and I believe that Docker issue was closed... Can you try re-running all of the commands in the "Install Docker" section again, as the root user?

Closing as no response, please re-open an issue if you can reproduce this.


Link error

Hi
Thank you for your nice cargo.
I tried to use x11-rs in my cargo project.
However, I got errors below
   Compiling libc v0.2.13
   Compiling pkg-config v0.3.8
   Compiling x11 v2.6.1
   Compiling sample_x11 v0.1.0 (file:///home/mopp/Workspace/repo/sample_x11)
error: linking with `cc` failed: exit code: 1
note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/mopp/Workspace/repo/sample_x11/target/debug/sample_x11.0.o" "-o" "/home/mopp/Workspace/repo/sample_x11/target/debug/sample_x11" "-Wl,--gc-sections" "-pie" "-nodefaultlibs" "-L" "/home/mopp/Workspace/repo/sample_x11/target/debug" "-L" "/home/mopp/Workspace/repo/sample_x11/target/debug/deps" "-L" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "-Wl,-Bdynamic" "/home/mopp/Workspace/repo/sample_x11/target/debug/deps/libx11-0c02163178e7e983.rlib" "/home/mopp/Workspace/repo/sample_x11/target/debug/deps/liblibc-30d46fdd62f8c2eb.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcollections-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustc_unicode-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/librand-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-fe3cdf61.rlib" "/usr/local/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-fe3cdf61.rlib" "-l" "util" "-l" "dl" "-l" "pthread" "-l" "gcc_s" "-l" "pthread" "-l" "c" "-l" "m" "-l" "rt" "-l" "util" "-l" "compiler-rt"
note: /home/mopp/Workspace/repo/sample_x11/target/debug/sample_x11.0.o: In function `sample_x11::main':
/home/mopp/Workspace/repo/sample_x11/src/main.rs:11: undefined reference to `XOpenDisplay'
collect2: error: ld returned 1 exit status

error: aborting due to previous error
error: Could not compile `sample_x11`.

It could not find xlib.
But, libX11 is installed already, and I can build and run your examples in the repo.
Maybe, I made some mistakes in my environment (Arch Linux).
How can I solve this problem ?
Thanks

Thanks for your advice !
I made a stupid mistake
[package]
name = "sample_x11"
version = "0.1.0"
authors = ["mopp<EMAIL_ADDRESS>
[dependencies]
libc = "0.2.13"
x11 = "2.6.1"

[x11]
features = ["xlib"]

My Cargo.toml was wrong.
[package]
name = "sample_x11"
version = "0.1.0"
authors = ["mopp<EMAIL_ADDRESS>
[dependencies]
libc = "0.2.13"

[dependencies.x11]
version = "2.6.1"
features = ["xlib"]

I fixed it and it works.
Thanks :)


DBZ-4961 Update Pulsar client version used by Debezium Server to 2.9.2

Bump the Pulsar client version used by Debezium Server from 2.5.2 to 2.9.2

Closed in favour of https://github.com/debezium/debezium/pull/3379


Loadtest release 2.6.0

Codecov Report

Merging #776 into release-2.6.5 will decrease coverage by 0.26%.
The diff coverage is 0%.

@@                 Coverage Diff                 @@
##             release-2.6.5     #776      +/-   ##
===================================================
- Coverage            38.59%   38.33%   -0.27%
  Complexity             979      979
===================================================
  Files                  149      149
  Lines                10084    10137      +53
  Branches              1120     1124       +4
===================================================
- Hits                  3892     3886       -6
- Misses                5783     5845      +62
+ Partials               409      406       -3

Impacted Files
Coverage Δ
Complexity Δ

...rd/common/util/KeycloakRequiredActionLinkUtil.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...sunbird/services/sso/impl/KeyCloakServiceImpl.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...ication/sms/providerimpl/Msg91SmsProviderImpl.java
64.92% <0%> (-2.24%)
39% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2d585...4c3510e. Read the comment docs.


Add error.js to typescript types

add #616
Nice to meet you
This is to export error classes from error.js

I don't know why it fails

@uc4w6c I will take a look, it might just be a flaky test. I can re-run the group that is failing. Should I re-open the PR?

@tulios
Really?
Thank you by all means.

Sorry that it took some time to get to this.

@Nevon
I'm happy!!
Special thanks!


implementation for listApd and getApdInfo

tests added for getApdInfo and listApd

Can one of the admins verify this patch?

retest this please

retest this please

retest this please


User accounts

Implementation of User Accounts into the Dorset Framework. Simple CsvFileUserService added to components as an initial example of a UserService.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: cabishop:x: BishopBishop seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.


Free Cartesian Category

Implement the free cartesian category and its eliminator. WIP on https://github.com/maxsnew/multi-poly-cats/pull/57

implemented by #94, see https://github.com/maxsnew/cubical-categorical-logic/pull/57#issuecomment-2192896788


Local Weather Data Collection

As an Analyst, I need to collect or identify where I can get local weather data to compare to incident date, time, city, and state so that I can ensure accurate weather reported in the dataset.
Note
The Federal Railroad Administration (FRA) incident report forms include weather data at the time/location of the incident. However, these reports are often filled out long after an incident and weather information may not be precise. Also, as part of the latter project would be to see extreme temperature fluctuations, so the weather the day before or after an incident, information that isn't included in the FRA report.
References
National Oceanic and Atmospheric Administration
Weather Underground
OpenWeather (API)
Key Variables are:
Temperature
Visibility
Weather Conditions
State
County

OpenWeather.com is a site that provides a free account and access to APIs to query historical data. @NRSchaaf created an account, obtained an API and configured code to pull historical weather data based on GPS coordinates and date range. Reference RR_Accident_Weather.ipynb file.


Add PropTypes to React-Table

What version of React-Table are you using?
6.6.0
What bug are you experiencing, or what feature are you proposing?
I want to propose adding the prop-types library to React-Table. Since there are a significant amount potential props, this would help give developers useful feedback as they are developing.
It shouldn't be too difficult to track down all the needed definitions as there is already a file containing all the defaultProps.

@frankolson I think you have sent through a few other PRs so I don't see anyone complaining if you do this.  It may get tricky when you get to some of the nested (i.e. the column) props.

Yah, if we create a small jest suite we might be able to test the compatibility.

This should be addressed in V 6.7.4


changes to setEnvironmentVariables.js to not lanch code or new command

changes to setEnvironmentVariables.js to print environment variables that need to be set without invoking lanch vscode or a new command-shell.
These change adds a new command line option ENV that when provided to setEnvironmentVariables.js skips launching VSCode or a new command shell.

Abandoning this review as we do not want to print out commands to console that need to be pasted by user later for security reasons.


Mosaic fastify

This PR replaces the Express web framework that powers the serve feature of the Mosaic CLI with fastify
Why?

It's a good bit faster --> https://fastify.dev/benchmarks
It has a very nice plugin architecture --> https://fastify.dev/docs/latest/Reference/Plugins/#plugins
Better TypeScript support
It can be configured to support Express middleware (but we only use CORS middleware so not a big deal for us) --> https://github.com/fastify/fastify-express

Serve Refactor
The serve function is basically now the place where we register the Mosaic fastify plugins and start listening for requests.  Routes and instantiating Mosaic are done in fastify plugins.
mosaicFastifyPlugin
This plugin instantiates Mosaic and adds a mosaic property to the fastify instance.  This allows plugins to access mosaic core, the scoped filesystem and the mosaic config file.
It also sets up the catch-all route used for retrieving pages from the mosaic filesystem.
mosaicAdminPlugin
This plugin depends on the mosaicFastifyPlugin and sets up route handlers for all mosaic Admin APIs.
mosaicWorkflowsPlugin
This plugin depends on the mosaicFastifyPlugin and sets up route handler for Mosaic workflows.

Tests ... ? 🥇

Added a bunch of tests for the admin APIs


Updated ERC1155 Discount Validator

In this version of the ERC1155 discount validator, we accept an array of uints upon initialization, setting the valid token Ids for the token collection.
Upon calling the isValidDiscountRegistration, an integrator should pack the token Ids to check. For example, to check for token ids 0, 1 and 2, an integrator would set validationData using abi.encode([0,1,2]).
The token Ids are decoded into an uint[] ids object and each is checked for validator approval AND a nonzero balance.

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Review Error for abdulla-cb @ 2024-11-04 23:14:04 UTC
User cannot review their own commit

Review Error for cb-elileers @ 2024-11-04 23:40:11 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-mssql-database
Module Details
AVM Resource Module for MSSQL Database
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

@thejrayasam is this request for child resource of https://github.com/Azure/Azure-Verified-Modules/issues/442 ?
tagging @mbilalamjad for visibility.

@prjelesi If this module is still looking for an owner, then I can take it up. @thejrayasam & me are collaborating on this.

Hey @sujaypillai & @thejrayasam, would there be a scenario where a module for azurerm_mssql_database would be needed independent of azurerm_mssql_server? if not then I would recommend we leverage the module proposed for azurerm_mssql_server and your contribution to that module would be appreciated.

Closing the issue as there is no requirement to create an independent module azurerm_mssql_database for now, and it can be part of azurerm_mssql_server.


[?] apiVersions Should Be Recent - The apiVersion 2019-06-01 was not found for the resource type:  Microsoft.Storage/storageAccounts/blobServices/containers

When I execute the tests of my arm template, I'm getting this as a result

If I go to this /arm-ttk-master/arm-ttk/arm-ttk/cache directory in my local from the clone of the arm-ttk repository
in this file AllAzureResources.cache.json, the type "Microsoft.Storage/storageAccounts/blobServices/containers" does not exists

I think this is by design... if we don't find the apiVersion (i.e. not returned by the /providers api) then we throw a warning.  This will be benign in the case where something is simply undocumented but an error in the case if the code is actually wrong.
LMK if that doesn't sound right...


Wrap local React components

Currently the guide only shows how to wrap components from npm. We should also show how to wrap custom local React components (and add anything to the library to enable that if necessary).

+1 for this. The same issue was open on the original pynecone and there wasn't any movement on it. Would love to see this!

completed via https://github.com/reflex-dev/reflex-web/pull/168

@masenf How do we use npm packages in these local components? For example if I want to use react-datepicker in the above-mentioned Welcome component, how do I install and use it?
CC @picklelo


Exclude "kube-public" namespace in HNC

"kube-public" is a namespace that is currently used to make "cluster-info" configmap readable to all users (see details in https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md#new-kube-public-namespace). HNC shouldn't reconcile objects in "kube-public" namespace.

/assign @adrianludwin
/assign @yiqigao217


GitLab package uploads don't seem to be working

Releases to GitLab Package Registry, when configured with a "Project Access Token" (api, write_repository, write_registry), do not seem to be occuring. The Release in GitLab is updated, but no changes appear in the Package Registry
Repo: https://gitlab.com/tanna.dev/dmd-go-semver
{
  "plugins": {
    "commit-analyzer": {
      "name"<EMAIL_ADDRESS>    },
    "ci-condition": {
      "name": "default"
    },
    "changelog-generator": {
      "name": "default",
      "options": {
        "emojis": "true"
      }
    },
    "provider": {
      "name": "gitlab",
      "options": {
        "gitlab_projectid": "44435308"
      }
    }
  }
}

Goreleaser config:
# ...
gitlab_urls:
  use_package_registry: true

Example build that isn't publishing: https://gitlab.com/tanna.dev/dmd-go-semver/-/jobs/3960632267

Hmm, I am not sure what is causing this. Here is a working example of go-semantic-release on GitLab: https://gitlab.com/go-semantic-release/example-go-application
Maybe this helps ☺

Sorry, just coming back to this - do you know how the GITLAB_TOKEN for :point_up: was defined? Is it a https://docs.gitlab.com/ee/user/project/settings/project_access_tokens.html or a per-user Personal Access Token?

Interestingly, with https://gitlab.com/tanna.dev/dmd-go-semver/-/releases/v1.3.2 (no longer setting use_package_registry) I still don't see artifacts uploaded :thinking:

I created a Personal Access Token for this project with the api scope.

Interesting. I've just tried https://gitlab.com/tanna.dev/dmd-go-semver/-/releases/v1.3.3 (using a Personal Access Token with api and a few other scopes) and that has not uploaded anything to the release :thinking:

OK, yep, this looks like complete user error, on the side of my .goreleaser.yaml config being a bit suspicious!


fix: remove URLs in pydantic error messages

Fixes #509
Pydantic includes error URLs in ValidationErrors which means extra tokens used in LLM calls.
Pydantic relies on an environment variable to control this setting and is on by default. https://github.com/pydantic/pydantic-core/blob/e1fc99dd3207157aad77defc20ab6873fd268b5b/python/pydantic_core/_pydantic_core.pyi#L818
This change sets the environment variable dynamically when the package is invoked.

:rocket: This description was created by Ellipsis for commit 5c2a35961c141c39afd1c83286195548dbf86b24

Summary:
This PR sets an environment variable to remove URLs from Pydantic error messages and includes a test to verify the change.
Key points:

Set PYDANTIC_ERRORS_INCLUDE_URL to 0 in set_env_variable in /instructor/utils.py
Call set_env_variable in /instructor/__init__.py
Add test in /tests/test_function_calls.py to verify URLs are not in Pydantic error messages

Generated with :heart: by ellipsis.dev

I would prefer this to be a piece of the documentation rather than something that we force users to use.

This does sound like a sane default to me, especially when retries come into the picture. Would be cumbersome to have to set this env variable each time. But maybe something like a config file makes more sense instead?

I have been waiting for this fix since March-2024.
I am with @ssonal
Who wants a useless url in the error message?  (+noise, +tokens, no benefit)
Just document how to enable if someone ever wants and move on.

see #757