ignore sharing before signup for metadata

Fixes an issue @patrickxb found
@keybase/react-hackers

The commits 973da137e216...2727bb36a9e4 introduce visual changes on linux. :mag_right: 10 new, 19 changed

Added: Chat_Side_Panel-Normal

Added: Chat_Side_Panel-Empty

Added: Chat_List-Normal

Added: Chat_List-Empty

Added: Chat_Input-Normal

Added: Chat_Input-Empty

Added: Chat_Header-Normal

Added: Chat_Header-Empty (view)
Added: Chat_Conversations_List-Normal (view)
Added: Chat_Conversations_List-Empty (view)
Changed: Search-Chat_enabled (before) (after) (diff)
Changed: Profile-Your_Profile_Proof_Menu (before) (after) (diff)
Changed: Profile-Your_Profile_Pending_Proof_Menu_HN (before) (after) (diff)
Changed: Profile-Your_Profile_Pending_Proof_Menu_DNS (before) (after) (diff)
Changed: Profile-Your_Profile_Pending_Proof_Menu (before) (after) (diff)
Changed: Profile-Your_Profile_No_Proofs (before) (after) (diff)
Changed: Profile-Your_Profile_Empty (before) (after) (diff)
Changed: Profile-Your_Profile_Broken_Proof_Menu (before) (after) (diff)
Changed: Profile-Your_Profile_Broken (before) (after) (diff)
Changed: Profile-Your_Profile (before) (after) (diff)
Changed: Profile-Unfollowed_Scrolled (before) (after) (diff)
Changed: Profile-Unfollowed_Profile_page (before) (after) (diff)
Changed: Profile-Unfollowed_Folders_Expanded (before) (after) (diff)
Changed: Profile-Unfollowed_Few_Folders (before) (after) (diff)
Changed: Profile-Unfollowed (before) (after) (diff)
Changed: Profile-Followed (before) (after) (diff)
Changed: Profile-Changed_Scrolled (before) (after) (diff)
Changed: Profile-Changed (before) (after) (diff)
Changed: Folders_Clear_History_Confirmation-Long_Name_Public (before) (after) (diff)

The commits 4022693e454e...e89d225f45a4 introduce visual changes on linux. :mag_right: 2 new, 5 changed

Added: Chat_Side_Panel-Normal

Added: Chat_Side_Panel-Empty

Changed: Chat_Input-Normal (before) (after)

Changed: Chat_Input-Empty (before) (after)

Changed: Chat_Header-Normal (before) (after)

Changed: Chat_Header-Empty (before) (after)

Changed: Chat_Conversations_List-Normal (before) (after)

The commits 4022693e454e...e89d225f45a4 introduce visual changes on linux. :mag_right: 2 new, 5 changed

Added: Chat_Side_Panel-Normal

Added: Chat_Side_Panel-Empty

Changed: Chat_Input-Normal (before) (after)

Changed: Chat_Input-Empty (before) (after)

Changed: Chat_Header-Normal (before) (after)

Changed: Chat_Header-Empty (before) (after)

Changed: Chat_Conversations_List-Normal (before) (after)

The server could ignore it?

Spoke to Coyne at length about this option and concluded this is the
easiest fix
On Mon, Nov 21, 2016 at 6:05 PM Gabriel Handford<EMAIL_ADDRESS>wrote:

The server could ignore it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/4919#issuecomment-262096106, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfhU0aIqK0Qd1m5FcPCcRUAZcLfGzLuks5rAiO0gaJpZM4K4hgn
.

Basically he API server does broad validation of all inputs so if we had it
return nulls they'd have to give us a new endpoint. Other option was to
make sep. calls for each username but this should work fine also.
On Mon, Nov 21, 2016 at 7:05 PM Gabriel Handford<EMAIL_ADDRESS>wrote:

@gabriel approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/pull/4919#pullrequestreview-9571105,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfhUya-CD_hMNnFYi_ZfFvy3VtY5crQks5rAjGogaJpZM4K4hgn
.


Use query params with useEntityListProvider

Hey, I just made a Pull Request!
Closes #6110

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Canonical thing to do is [queryParameters.X].flat()[0] then, right? :) To transparently handle the array-or-not-array duality.

Array.isArray([]) returns true, so I wonder if the queryParameter.X[0] code happens to work only because queryParameters is well-behaved. Maybe it's not possible to have an empty array in query params 🤔 -- could you do something like /page?type=&type=?

/page?type=&type= seems possible based off my testing but either way, empty arrays are handled appropriately in the pickers like so since we take into account that the value could be undefined (either due to the query param not being defined or indexing an empty array):
const [selectedKind] = useState(
    [queryParameters.kind].flat()[0] ?? initialFilter,
  );

also, updated to use @freben suggestion for the handling array-not-array (Thanks!) , really like the nice and clean statement :)


Method auto-complete randomly doesn't work (jumps between three different behaviors)

https://user-images.githubusercontent.com/21220820/106952730-c882b600-6731-11eb-9c85-7f6c14c2f138.mp4
As you can see in the video, when typing the first few characters of a method, three different things may happen, seemingly without no pattern:

rust-analyzer's nice method list pops up
VSCode's built-in autocomplete pops up
Nothing pops up

Through experimentation, I could identify what triggers each of the behaviors:

type all characters normally
type the first 2-3 characters rapidly
type the last 2-3 characters rapidly

This issue seems easy to reproduce, but here is a copy-and-pastable code just in case (I tested it in a blank project, it behaves the same)
fn trim_multiline(string: &str) -> &str {
    while string./*type "ends" here, in varying speeds*/
}

Versions:

VSCode: 1.52.1
rust-analyzer: v0.2.473
OS: KDE Linux

If there is anything else I can provide to make the issue more clear, I'm happy to provide it

Thank you for finding the time to record a video and experiment with it.
Most probably it's the same case as discussed in https://github.com/rust-analyzer/rust-analyzer/issues/7542
When zero completion input is done after . symbol, we might get slow when finding traits appropriate for importing.
I have a few ideas in the same issue on how to improve the situation, we also have an issue for benchmarks.


Move jenkins home backup to another repo

Due to the fact that credentials archive in cloud storage needs to be the same as the commit on the branch it forces us to push to the branch directly which might me difficult when multiple contributors are working on istio-testing. We should move backup to another repo and move backup and create pd scripts there was well.

This is not required anymore. Updated the way this works. Check #120 for details.


'none' new token doesn't work as expected

Hello,
From my understanding the "none" statement ("none" keyword https://github.com/VirusTotal/yara/pull/1559/files ) doesn't work as I expect ;). Indeed even if a string appear in a scanned file the expression using "none" will report a true condition.
I have leveraged different version yara-v4.2.1-1934-win64 / yara-master-1798-win64 / yara-4.2.0 with the same issue.
Test done via official precompiled binaries (only x64 version tested) and executed under Windows environement (W10).
BTW you haven't included in your testing rules tests (tests/test-rules.c) which should have highlighted this issue.

Something like:
assert_false_rule(
"rule test { strings: $a = "dummy1" $b = "dummy2" $c = "ssi" "
"condition: none of them }",
TEXT_1024_BYTES "mississippi");
assert_false_rule(
"rule test { strings: $a1 = "dummy1" $b1 = "dummy2" $b2 = "ssi""
"condition: none of ($a*, $b*) }",
TEXT_1024_BYTES "mississippi");
Hope it's help.
Originally posted by @lupiotte in https://github.com/VirusTotal/yara/issues/1559#issuecomment-1111992280

I think you're right about this. I should have a fix up very soon.

At least in my defense this has nothing to do with the none keyword. You can get the same behavior with 0 of them as a condition. ;)
I think this is actually a long standing bug, but either way a fix is incoming!


RTSP Client with swiftUI

hello bro. could this repo work with swifUI
please guide how to use thank

Hello,
Actually, this library is not totally developed so swiftUI is not supported.
Anyway, If you can change this class to make it work with swiftUI. You should be able to use it:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-swift/blob/master/encoder/input/video/CameraManager.swift

Hello bro @pedroSG94
my skill is limit to implement this :)
anyway thank for your reply :D


notebook container div still differs from "classical" Notebook experience

1. Problem
Even though both UIs are currently very close, I still feel frustration when using RetroLab, mostly because of CSS discrepancies.
With the classical Notebook interface, the notebook <div id="notebook-container"> kept left and right margin on small width windows, and increased in height as cells count grew.
It appears it is not the case with RetroLab latest version.
2. Proposed Solution
I would like to see the exact same UI on this notebook-container div, which is probably the most important of the whole document ; especially knowing that RetroLab will be used as the next major version of the Notebook.
Unfortunately, my front-end engineering skills are very poor, so I won't be able to propose a PR myself :confused:
3. Screen shots to illustrate the difference
Both screenshots are made with the same (small) window width.
3.1 "Good ol' Notebook" has margins that makes the experience neater

3.2 Retro Lab has no margins on small width screens

Thanks @edthrn for opening this issue :+1:
Indeed the styling of the Notebook component in RetroLab can still be improved.
Currently the "documented oriented feel" is implemented in CSS here:
https://github.com/jupyterlab/retrolab/blob/7fed46857663bb3f9e7ead599aaa85eefddf6c4e/packages/notebook-extension/style/base.css#L9-L46
Probably this could be tweaked to still keep some margins on smaller viewports.

Thanks for your reply :+1:
Indeed, side margins on smaller viewports should be tweaked, but even more important is adjustable bottom margin for any width: it's a visually pleasant feature of the old notebook style.

Some improvements towards this were done in https://github.com/jupyter/notebook/pull/6376, and are available in notebook>=7.0.0a3.


Devel

Changed to get number of required parameters as well, to be able to call methods with optional arguments
Changed code in json-rpc.php
$method_object = new ReflectionMethod($class, $method);
$num_got = count($params);
$num_min = $method_object->getNumberOfRequiredParameters();
$num_max = $method_object->getNumberOfParameters();
if ($num_got < $num_min  || $num_got > $num_max) {
    $msg = "Wrong number of parameters. Got $num_got expected between $num_min and $num_max";
    throw new JsonRpcExeption(105, $msg);
} else {
    //throw new Exception('x -> ' . json_encode($params));
    $result = call_user_func_array(array($object, $method), $params);
    echo response($result, $id, null);
}

WORKING EXAMPLE BELOW
Example PHP method in rpc.php
public function optional($token, $required, $optional = 'null'){
    return 'Required: ' . $required . ', Optional: ' . $optional;
}

Test before changes
> optional someValue
[RPC] Wrong number of parameters. Got 2 expect 3

Test after changes
> optional
[RPC] Wrong number of parameters. Got 1 expected between 2 and 3

> optional someValue
Required: someValue, Optional: null

> optional someValue anotherValue
Required: someValue, Optional: anotherValue

> optional someValue anotherValue aThirdValue
[RPC] Wrong number of parameters. Got 4 expected between 2 and 3

Although if checkArity is TRUE, it still will throw an error
> optional someValue
[Arity] Wrong number of arguments. Function 'optional' expects 3 got 2!

This will probably need some modifications in the JS file

Thanks for the PR but this file is actually copy (and old also one) from this repo https://github.com/jcubic/json-rpc can you check if that works for you? It use getNumberOfRequiredParameters. Maybe I should create submodule with this file instead of copy.
I'm not sure why tests failed if you modified php file, it's not used by tests that are written in NodeJS.

Thanks for the PR but this file is actually copy (and old also one) from this repo https://github.com/jcubic/json-rpc can you check if that works for you? It use getNumberOfRequiredParameters. Maybe I should create submodule with this file instead of copy.
I'm not sure why tests failed if you modified php file, it's not used by tests that are written in NodeJS.

Hi,
@jcubic thanks for your response.
I see the updated file, but it can still do some improvements,
(i.e. as is, it only works with either the number of required or the number of all, but in a scenario that a function has multiple optional parameters, it won't work if let's say with one optional parameter)
So I will create a new Pull Request  on this https://github.com/jcubic/json-rpc repo.
BTW the example in my previous comment is not in NodeJs, it's in js (frontend).
Regards

Hi,
@jcubic thanks for your response.
I see the updated file, but it can still do some improvements,
(i.e. as is, it only works with either the number of required or the number of all, but in a scenario that a function has multiple optional parameters, it won't work if let's say with one optional parameter)
So I will create a new Pull Request  on this https://github.com/jcubic/json-rpc repo.
BTW the example in my previous comment is not in NodeJs, it's in js (frontend).
Regards


0.9-9-SNAPSHOT

Closed by CI build #5

tag 0.7-7-SNAPSHOT test  failed!

Closed by CI build #6

see the report:

Code quality (test)
Code style
Readme
Test coverage

Closed by CI build #7

see the report:

Readme


Edit button

Would really like to be able to edit a prompt and resend it

This is currently possibly by using Right click, but your design proposal is perhaps nicer.

Added in new release


NuGet Package for 0.13.1

Please update the NuGet Package also to version 0.13.1

@pascalberger https://github.com/angular-ui/bootstrap-bower

The NuGet package has been updated to v0.13.1

Thanks!


GenericUSBXHCI should not be used on AMD Desktops

GenericUSBXHCI, only applies to AMD laptops, it doesn't effect (and can ruin EFIs) on AMD Desktops. AMD Desktops only need ReleaseUSBOwnership

GenericUSBXHCI kext is only added based on confirmed PCI ID issues. It is not applied based on whether the system is a laptop or desktop. For more details, you can check here: https://github.com/lzhoang2801/OpCore-Simplify/blob/main/Scripts/kext_maestro.py#L234C1-L239C60

My bad - you clearly know what you're doing!


Rename 'count' field to 'clicks'

This makes it consistent with the use of the term 'clicks' in the user interface, which is a bit more clear than 'count' when describing the number of times a link has been used.

Coverage remained the same at 98.058% when pulling e4a3737913bc94c03e77cff718b90c88b05ec258 on count-to-clicks into 6be4b0a32ef059491a1657da58548e53f5cdb5e9 on master.

Coverage remained the same at 98.058% when pulling e4a3737913bc94c03e77cff718b90c88b05ec258 on count-to-clicks into 6be4b0a32ef059491a1657da58548e53f5cdb5e9 on master.


feat: server-admin: Link to GitHub repo somewhere on the page.

We already have a link to the server in Github. Very few people would benefit from another link.
Why do you think it would be needed?

Sorry, I'm totally blind. Perhaps I was expecting a little octocat logo. Maybe I'll add the logo in the footer at some point.


 This may cause a duplicate middleware to be inserted if the application manually inserts Rack::Timeout already.
Since we don't actually want a new middleware to be inserted and just want to patch the internals of rack-timeout, we can just call require 'rack/timeout/base' instead.
Relates to https://gitlab.com/gitlab-org/gitlab-development-kit/-/issues/1913

Awesome catch! Thanks for the fix @stanhu!


fix: spin the running icon

There were the following issues with your Pull Request

Commit: 0ea6030d5bd257cf35d27003110ba6f900a984e3
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com


Fix external extensions not loading initially

fixes https://github.com/lensapp/lens/issues/7139

Will recreate this PR simpler to fix just the issue (but not via Runnables) because the necessary work to fix the tests is huge


[Runtime Bug]: Alpha sorting on Particles Blending Creates Bery Noticeable Visual Artifacts

Describe the bug
When particles in motion are on screen, a large percentage of the time they simply aren't visible, but when they are, they create odd draw order distortions that appear as motion blur like flickering.
Stochastic blending does nothing in this situation.
How do you reproduce the bug?
Load up VTMB with remix and use the console:
map sm_hub_1
Wait for the rain particles to start.
What is the expected behavior?
Better handling of particles in general, as well as multiple blending of different depths of transparency especially in motion.
Version
remix-main+f80a3a26
Logs
No response
Crash dumps
No response
Media
https://github.com/user-attachments/assets/b09d29e8-d3a9-4741-bc70-2fce5633071a

Thanks for reaching out! We've opened REMIX-3698 for internal investigation. As part of repro instructions, could you also please provide us with mod files and .conf files? Thanks!

Thanks for reaching out! We've opened REMIX-3698 for internal investigation. As part of repro instructions, could you also please provide us with mod files and .conf files? Thanks!

Sure! Where do I send that? Is there an email or something? feels odd to put the mod files in a git comment so I'm guessing there's a more official place to send it?

Hey @Safemilk - we don't have an email box to use, but a link to an online storage location (like a Google Drive or Dropbox folder) would work. Sometimes users upload their mod files in a Discord message and link that here, too.

@NV-LL
I actually have an alpha release of the mod, which contains all project files that can be downloaded here:
https://www.moddb.com/mods/vampire-the-masquerade-bloodlines-rtx-remaster/downloads
Does that work? Or do you need the working files for the Remix Editor project as well?


add docker compose for easy dev setup

👍

@shahidhk It would be awesome if you can add nginx into the mix and set up reverse proxy along with a self signed certificate. For reference https://github.com/IEEEKeralaSection/rescuekerala/pull/298

Setting HTTPS locally is not easy. But a new tool is around: https://github.com/FiloSottile/mkcert
Let me give it a try.

https://certbot.eff.org/
You can easily set up https with a signed certificate

You cannot set up certificate using Letsencrypt without a public IP.
mkCert is the best bet to get HTTPS without hosting the application on a
box with a public ip
On Fri 17 Aug, 2018, 12:58 maheshnayer<EMAIL_ADDRESS>wrote:

https://certbot.eff.org/
You can easily set up https with a signed certificate
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IEEEKeralaSection/rescuekerala/pull/37#issuecomment-413782013,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD7wPY1UriOzpWYBbLpFZS_YR2gk3KV4ks5uRnC5gaJpZM4V_T2H
.

@shahidhk @r3dsm0k3 Tested your PR and everything looks fine. Only trouble was with the redis dependency which is not documented in the README file as well.

Redis could have been added later. Will update
On Sat 18 Aug, 2018, 02:41 karthikpanicker<EMAIL_ADDRESS>wrote:

@shahidhk https://github.com/shahidhk @r3dsm0k3
https://github.com/r3dsm0k3 Tested your PR and everything looks fine.
Only trouble was with the redis dependency which is not documented in the
README file as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/IEEEKeralaSection/rescuekerala/pull/37#issuecomment-413989437,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD7wPV2VEzRnc9dqfxiaqz63TUJHGTqiks5uRzGBgaJpZM4V_T2H
.

@shahidhk I've done that already and it is merged to master. Lets tackle something else now mate.


some k8s components report unhealthy status after cluster bootsrap

curl  <IP_ADDRESS>:8080/api/v1/componentstatuses
{
  "kind": "ComponentStatusList",
  "apiVersion": "v1",
  "metadata": {
    "selfLink": "/api/v1/componentstatuses"
  },
  "items": [
    {
      "metadata": {
        "name": "scheduler",
        "selfLink": "/api/v1/componentstatuses/scheduler",
        "creationTimestamp": null
      },
      "conditions": [
        {
          "type": "Healthy",
          "status": "False",
          "message": "Get http://<IP_ADDRESS>:10251/healthz: dial tcp <IP_ADDRESS>:10251: getsockopt: connection refused"
        }
      ]
    },
    {
      "metadata": {
        "name": "controller-manager",
        "selfLink": "/api/v1/componentstatuses/controller-manager",
        "creationTimestamp": null
      },
      "conditions": [
        {
          "type": "Healthy",
          "status": "False",
          "message": "Get http://<IP_ADDRESS>:10252/healthz: dial tcp <IP_ADDRESS>:10252: getsockopt: connection refused"
        }
      ]
    },
    {
      "metadata": {
        "name": "etcd-0",
        "selfLink": "/api/v1/componentstatuses/etcd-0",
        "creationTimestamp": null
      },
      "conditions": [
        {
          "type": "Healthy",
          "status": "True",
          "message": "{\"health\": \"true\"}"
        }
      ]
    }
  ]

This is specific to bootkube/self-hosted I believe.

Looks like it's hard-coded to expect scheduler + controller-manager are on the same host as api-server: https://github.com/kubernetes/kubernetes/blob/04ce042ff9cfb32b2c776f755cc7abc886b8a441/pkg/master/master.go#L620-L623
We do not adhere to this assumption because schedule + controller manager are deployments which could be on different hosts (and do not use host-networking).
@sym3tri would you be able to inspect this information from another api-endpoint? Maybe inspecting pods in kube-system, or a specific set of pods via label query?
It seems like this componentstatus endpoint is somewhat contentious as it stands:
https://github.com/kubernetes/kubernetes/issues/18610
https://github.com/kubernetes/kubernetes/issues/19570
https://github.com/kubernetes/kubernetes/pull/13216

I have no love for the current componentstatuses endpoint.
I don't remember whether it was all captured in the proposal, but I think we iterated towards a consensus on Karl's component registration proposal, which you cited:
https://github.com/kubernetes/kubernetes/pull/13216
Someone would need to work on it.

I skimmed the proposal & I more or less agree that it's not exactly a pressing issue to have a single /componentstatuses api-endpoint.
I like the idea of fronting healthcheck endpoints with a service (e.g. "scheduler-health.kube-system.cluster.local"). Then if we wanted to drill down into how many of those pods are healthy, it's just a matter of querying the service itself.
@sym3tri is this still blocking you for any reason? Would the health-check service endpoint be a reasonable end-goal? Or is directly querying the pods sufficient?

@aaronlevy Directly querying the pods puts a lot of burden on the caller. If we can have a fronting service that would be ideal.
Directly querying the pods is an ok workaround for the time-being but not a good long-term solution. We'd just be shifting the hardcoded services to our code, and there is no other way to query etcd health via the API.

Opened https://github.com/coreos/bootkube/issues/85 to track that feature specifically.


Add doc builds to each PR

What does this PR do?

Adds support to view the optimum-intel docs with each PR + acts as a test that the docs always build.
Needs https://github.com/huggingface/moon-landing/pull/3521 to be merged in order to view the doc build
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


This code caused EXC_BAD_ACCESS when refactoring the project to use ARC.

Bug fixed using Objective-C style array.

Fixes this bug: https://github.com/domesticcatsoftware/DCRoundSwitch/issues/10

Ignore


feat: add aliyun theme

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

https://preview-6165-ng-zorro-antd.surge.sh/components/auto-complete/zh#components-auto-complete-demo-uncertain-category
样式有点问题


Get setup with CI

Added unittests for python 3.8, 3.9, 3.10
Added testing for Mac OS, Windows, Ubuntu


ci: use java-shared-dependencies in google-cloud-java repository for downstream test

To reflect recent migration of java-shared-dependencies repository to google-cloud-java.
To fix the problem found in https://github.com/googleapis/gapic-generator-java/pull/1290#issuecomment-1412695859
Kokoro downstream tests to use java-shared-dependencies in google-cloud-java repository.

All checks passed.


[5.6] Allow different collection classes to be returned

Just an idea -- this PR would allow different collection classes to be returned by setting a property instead of the newCollection method.

Would rather people just override the method.


Drop files from Explorer to CustomEditor (webview) doesn't work

Type: Bug
Hi guys, thanks a lot for your amazing work! Unfortunately after searching existing issues and documentation, I still experience an issue. I developed a tiny extension to showcase the bug https://github.com/maxbublik/vscode-customeditor-drop
The extension offers a CustomEditor for *.drops.json files. When such a file is opened via the given custom editor, you can drag-n-drop (presumably anything) onto the webview and the drop event information is appended to the underlying json file.
Drop a file from Explorer tree view: ❌ does not work
Drop an item with dataTransfer.setData('text/uri-list', value); manually set in another webview: ✅ OK
Drop a file from OS: ✅ OK
https://github.com/microsoft/vscode/assets/620034/a85f8743-adcc-4c46-af55-17e63f4ec641
VS Code version: Code - Insiders 1.79.0-insider (2575777b9d3cdb865d61f9f1dfaac1fea9e1bde6, 2023-05-12T05:24:44.544Z)
OS version: Darwin arm64 21.4.0
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.09GB free)

Process Argv
--crash-reporter-id 47e2bfbb-a348-459d-8975-8945e0235016

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
pylantcb52:30590116
pyind779:30611226
pythonsymbol12:30651887
showlangstatbar:30737417
azdwalk:30721579
pythonms35:30671666
f08j5886:30680471
24365598:30687740
pythonfmttext:30716741
pythoncmvfstr:30726892
fixshowwlkth:30724385
hidesbindicator:30724476
pythongtdpath:30726887

Thank you for the great repo!
The root cause is:
https://github.com/microsoft/vscode/blob/273b73d71371eaa8eb772e91e1fbc5f6c2640084/src/vs/workbench/contrib/webview/browser/webviewElement.ts#L688
This code surpasses pointer events on the webview element when any element in VS Code editor dom is being dragged. This  is what lets you drag and drop over a webview to open the file
Here's the behavior we want:

If the user drags a file over a webview without holding shift, they see the editor drop overlay. Dropping the file opens in the that editor group
Once the user presses shift while dragging, they instead start dropping  the content into the webview. The drop overlay should now go away
Once the user releases shift, the drop overlay shows again

Coordinating the drag events across the different iframes involved here gets a little tricky. We may need to capture the events inside the webview iframes and re-broadcast them up  to VS Code, similar to what we already for for keypresses

Looks like D&D not working for any file like .py when trying put from win11 explorer to edit.
Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:39:26.248Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

Hi, Matt, thanks a lot for your message!
What I do observe: when the user drags a file over a webview with holding shift and the drop overlay is absent, the webview still does not receive neither dragover nor drop events.
This is a bug, right? Or did I miss some configuration?
I assume the whole drag-n-drop machinery (getting tricky recently) is evolving around a core VSCode pattern: dropping a file onto an editor group should open that file in that editor group. What if webview providers could explicitly announce dropTypes (the same way as native VSCode trees). Therefore, certain webviews could skip the pattern and handle dragover and drop events on their own if the original drag event contains one of the announces dataTransfer.types. The video demonstrates this at timecode 0:12-0:17. Does it break the UX significantly?

What if webview providers could explicitly announce dropTypes

I don't think that  helps. If the users is dragging a file or url-list, we want the behavior I described above: first we show the drop overlay and then when the user presses shift, we allow dropping into the webview
My current understanding is that  requires coordinating the drag events across different iframes and that's what gets tricky

Hi Matt, @mjbvz, do you have a rough estimation of the fix to arrive?

Hey, I have the same issue. Can we simply do it like this?
windowDidDragStart(): void {
    if( !shiftIsDown )
	this._startBlockingIframeDragEvents();
}

Wonder if this will work? I do notice when holding shift I can't drag from file explorer.
windowDidDragStart(): void {
    if( !shiftIsDown)
		this._startBlockingIframeDragEvents();
}

This issue was a blocker for an extension I wanted to build so I figured I'd give it a shot.
I basically added a new listener on the WebviewWindowDragMonitor that should re-enable the customWebView pointer events allowing us to drag and drop files as expected.

Once the user releases shift, the drop overlay shows again

I recognized that if a user presses shift while dragging and dropping a file on to any editor then the full drag and drop is cancelled. Are we sure we want to show the drop overlay again if the user stops pressing shift?

@mjbvz on Windows, dropping a file from the explorer or from the drops view into the editor ends up opening the file or link. With the extension sample above, I dropped in a spreadsheet from the explorer, and Excel opened. Is that expected behaviour?

@mjbvz on Windows, dropping a file from the explorer or from the drops view into the editor ends up opening the file or link. With the extension sample above, I dropped in a spreadsheet from the explorer, and Excel opened. Is that expected behaviour?
Edit: verified that that behaviour also occurs in Stable.

This is likely due to the fact that default drop events are  not prevented.
I can look into resolving this.

The title is wrong described. The move any file as D&D to VSC not opening a editor with new tab.
And it's not related with security issue or maybe it is.. as "workspace" and "namespace" around dir, where outside dir of project files can't be opened, but need ctr+shift+N as new instance VSC in case intuition want suggest it should be easy opened to change something or run test script.

@rzhao271 Because this issue is closed I created a new issue to track the bug you reported here: https://github.com/microsoft/vscode/issues/218626. I think I know how to fix it so you can assign it to me if you want
@ManPython I honestly don't know what you are trying to say. Can you clarify?

@mjbvz  can this issue be re-opened since my PR was reverted? I'll open another PR "soonTM" I just figured it should point at this issue.


Failing anchor build

I am trying to build a simple counter program using WSL2 Ubuntu. I have successfully installed rust solana-cli and anchor. But when trying to run any command mainly anchor build on the build I am getting the following error

Anchor: anchor-cli 0.24.2
Solana cli: solana-cli 1.11.10 (src:843e018c; feat:4253057308)
Rust: rustc 1.63.0 (4b91a6ea7 2022-08-08)
Cargo: cargo 1.63.0 (fd9c4297c 2022-07-01)

Looks like a rust issue / solana cli issue maybe?

Well there are other projects that are working using the same environment, cli and rust. And that's why I'm q bit confused

Did you fix this? It looks like you might need to try reinstalling the CLI since it's not found on the path. There might be another issue at play here but I don't think the github issues for anchor is the right place for that. Maybe the solana stackexchange


Set @every(minutes=24 * 60)  if the task can not finish in one day?

Like the title said, if the task can not finish in one day,  it will restart the work next day or just continue the task ?

Do you mean a project not finished in one day? A task (one single page) is not possible to run for days.
@every effect the decorated function, it have no relation with any task, and will be call every day regardless the status of any tasks.

I have many pages will be scheduled in on_start.The fetcher can not finish crawling them in one day. So the next day the scheduler will schedule all pages again, the scheduler queue will be bigger and bigger ?

same task will discard.

OK thanks again


Team metadata should support “color”

Colors are auto-generated based on the owner’s name (string). This is nice because it’s lightweight, but we should allow overriding the default via the team config object.

de3a0c3


Fix README

Second author key should be twitter in README.

@maartenbrakkee Thank you! Much appreciated! :)


Remove deferred compute architecture

Changes add()/compute() design of managers to be compute() only. The computed insights will still be saved to the managers for get() and list() to work as previously designed.

@gregorybchris I thought we weren't going to do this for the initial release?  Didn't we want to discuss this more with PM, or do we have agreement on this revised API now?  Even if we have agreement, shouldn't we wait until we finish the end to end notebook, and then we can plan/discuss the next steps?

@gregorybchris I thought we weren't going to do this for the initial release? Didn't we want to discuss this more with PM, or do we have agreement on this revised API now? Even if we have agreement, shouldn't we wait until we finish the end to end notebook, and then we can plan/discuss the next steps?

I got PM approval on the design doc (both of them) and it seemed from the chat like your concerns had been addressed. I'm open to holding off, but not sure I totally understand your concern.

@gregorybchris I guess my concern is we are making this API change too quickly, and there are a lot of moving parts already.  We want to hit the tight deadline and this is adding extra work that might cause it to slip.

@gregorybchris we discussed and it seems like this is an important change to get in sooner rather than later

@gregorybchris I guess my concern is we are making this API change too quickly, and there are a lot of moving parts already. We want to hit the tight deadline and this is adding extra work that might cause it to slip.

This is a major change. I fear that other managers may not align by June 30th. This change even though approved by PMs should have been made earlier.


some Z champs come before the whole list

Config and file locations:
- Log: C:/Users/YOURNAME/AppData/Roaming/Championify/championify.log.txt
- Config: C:/Users/YOURNAME/AppData/Roaming/Championify/prefs.json
__What operating system: W10 1803
__What version of Championify: 2.1.5
__What distribution of the league client are you using (NA, EUW, KR, Garena, ect)?: OCE
Please explain the issue you're encountering:
Screenshots: https://gyazo.com/eca4bc6c745a764e0c575fec1510913e
Logs: {"level":"info","message":"Version: 2.1.5","timestamp":"2018-06-09T04:04:33.445Z"}
{"level":"info","message":"Checking for updates","timestamp":"2018-06-09T04:04:34.875Z"}
{"level":"info","message":"No updates found","timestamp":"2018-06-09T04:04:35.196Z"}
{"level":"info","message":"Locale: en","timestamp":"2018-06-09T04:07:20.333Z"}
{"level":"info","message":"Saved preference file to C:\Users\USER\AppData\Roaming\Championify\prefs.json","timestamp":"2018-06-09T04:07:20.343Z"}
{"level":"info","message":"Getting LoL Version","timestamp":"2018-06-09T04:07:20.555Z"}
{"level":"info","message":"Downloading Champs from Riot","timestamp":"2018-06-09T04:07:20.701Z"}
{"level":"info","message":"Processing Champion.gg: Zyra","timestamp":"2018-06-09T04:07:22.486Z"}
{"level":"info","message":"Processing Champion.gg: Zoe","timestamp":"2018-06-09T04:07:22.496Z"}
{"level":"info","message":"Processing Champion.gg: Zilean","timestamp":"2018-06-09T04:07:22.499Z"}
{"level":"info","message":"Processing Champion.gg: Aatrox","timestamp":"2018-06-09T04:07:24.111Z"}
{"level":"info","message":"koreanbuilds: Getting Roles","timestamp":"2018-06-09T04:07:24.168Z"}
{"level":"info","message":"Processing Champion.gg: Ahri","timestamp":"2018-06-09T04:07:25.740Z"}
{"level":"info","message":"Processing Champion.gg: Akali","timestamp":"2018-06-09T04:07:25.972Z"}
{"level":"info","message":"Processing Champion.gg: Alistar","timestamp":"2018-06-09T04:07:27.491Z"}
{"level":"info","message":"Processing Champion.gg: Amumu","timestamp":"2018-06-09T04:07:27.531Z"}
{"level":"info","message":"Processing Champion.gg: Anivia","timestamp":"2018-06-09T04:07:29.159Z"}
{"level":"info","message":"Processing Champion.gg: Annie","timestamp":"2018-06-09T04:07:29.202Z"}
{"level":"info","message":"Processing Champion.gg: Ashe","timestamp":"2018-06-09T04:07:29.685Z"}
{"level":"info","message":"Processing Champion.gg: Aurelion Sol","timestamp":"2018-06-09T04:07:30.824Z"}
{"level":"info","message":"Processing Champion.gg: Azir","timestamp":"2018-06-09T04:07:31.399Z"}
{"level":"info","message":"Processing Champion.gg: Bard","timestamp":"2018-06-09T04:07:32.478Z"}
{"level":"info","message":"Processing Champion.gg: Blitzcrank","timestamp":"2018-06-09T04:07:32.657Z"}
{"level":"info","message":"Processing Champion.gg: Brand","timestamp":"2018-06-09T04:07:33.125Z"}
{"level":"info","message":"Processing Champion.gg: Braum","timestamp":"2018-06-09T04:07:34.227Z"}
{"level":"info","message":"Processing Champion.gg: Caitlyn","timestamp":"2018-06-09T04:07:34.801Z"}
{"level":"info","message":"Processing Champion.gg: Camille","timestamp":"2018-06-09T04:07:36.456Z"}
{"level":"info","message":"Processing Champion.gg: Cassiopeia","timestamp":"2018-06-09T04:07:36.553Z"}
{"level":"info","message":"Processing Champion.gg: Cho'Gath","timestamp":"2018-06-09T04:07:36.610Z"}
{"level":"info","message":"Processing Champion.gg: Corki","timestamp":"2018-06-09T04:07:38.226Z"}
{"level":"info","message":"Processing Champion.gg: Darius","timestamp":"2018-06-09T04:07:39.923Z"}
{"level":"info","message":"Processing Champion.gg: Diana","timestamp":"2018-06-09T04:07:40.474Z"}
{"level":"info","message":"Processing Champion.gg: Dr. Mundo","timestamp":"2018-06-09T04:07:41.420Z"}
{"level":"info","message":"Processing Champion.gg: Draven","timestamp":"2018-06-09T04:07:41.714Z"}
{"level":"info","message":"Processing Champion.gg: Ekko","timestamp":"2018-06-09T04:07:43.513Z"}
{"level":"info","message":"Processing Champion.gg: Elise","timestamp":"2018-06-09T04:07:43.882Z"}
{"level":"info","message":"Processing Champion.gg: Evelynn","timestamp":"2018-06-09T04:07:44.873Z"}
{"level":"info","message":"Processing Champion.gg: Ezreal","timestamp":"2018-06-09T04:07:45.278Z"}
{"level":"info","message":"Processing Champion.gg: Fiddlesticks","timestamp":"2018-06-09T04:07:45.624Z"}
{"level":"info","message":"Processing Champion.gg: Fiora","timestamp":"2018-06-09T04:07:46.587Z"}
{"level":"info","message":"Processing Champion.gg: Fizz","timestamp":"2018-06-09T04:07:47.000Z"}
{"level":"info","message":"Processing Champion.gg: Galio","timestamp":"2018-06-09T04:07:48.342Z"}
{"level":"info","message":"Processing Champion.gg: Gangplank","timestamp":"2018-06-09T04:07:48.754Z"}
{"level":"info","message":"Processing Champion.gg: Garen","timestamp":"2018-06-09T04:07:49.340Z"}
{"level":"info","message":"Processing Champion.gg: Gnar","timestamp":"2018-06-09T04:07:50.440Z"}
{"level":"info","message":"Processing Champion.gg: Gragas","timestamp":"2018-06-09T04:07:51.047Z"}
{"level":"info","message":"Processing Champion.gg: Graves","timestamp":"2018-06-09T04:07:52.147Z"}
{"level":"info","message":"Processing Champion.gg: Hecarim","timestamp":"2018-06-09T04:07:53.720Z"}
{"level":"info","message":"Processing Champion.gg: Heimerdinger","timestamp":"2018-06-09T04:07:53.837Z"}
{"level":"info","message":"Processing Champion.gg: Illaoi","timestamp":"2018-06-09T04:07:54.528Z"}
{"level":"info","message":"Processing Champion.gg: Irelia","timestamp":"2018-06-09T04:07:55.438Z"}
{"level":"info","message":"Processing Champion.gg: Ivern","timestamp":"2018-06-09T04:07:56.253Z"}
{"level":"info","message":"Processing Champion.gg: Janna","timestamp":"2018-06-09T04:07:57.274Z"}
{"level":"info","message":"Processing Champion.gg: Jarvan IV","timestamp":"2018-06-09T04:07:57.913Z"}
{"level":"info","message":"Processing Champion.gg: Jax","timestamp":"2018-06-09T04:07:58.897Z"}
{"level":"info","message":"Processing Champion.gg: Jayce","timestamp":"2018-06-09T04:07:59.437Z"}
{"level":"info","message":"Processing Champion.gg: Jhin","timestamp":"2018-06-09T04:07:59.752Z"}
{"level":"info","message":"Processing Champion.gg: Jinx","timestamp":"2018-06-09T04:08:01.443Z"}
{"level":"info","message":"Processing Champion.gg: Kai'Sa","timestamp":"2018-06-09T04:08:02.805Z"}
{"level":"info","message":"Processing Champion.gg: Kalista","timestamp":"2018-06-09T04:08:03.178Z"}
{"level":"info","message":"Processing Champion.gg: Karma","timestamp":"2018-06-09T04:08:03.217Z"}
{"level":"info","message":"Processing Champion.gg: Karthus","timestamp":"2018-06-09T04:08:04.568Z"}
{"level":"info","message":"Processing Champion.gg: Kassadin","timestamp":"2018-06-09T04:08:04.926Z"}
{"level":"info","message":"Processing Champion.gg: Katarina","timestamp":"2018-06-09T04:08:06.672Z"}
{"level":"info","message":"Processing Champion.gg: Kayle","timestamp":"2018-06-09T04:08:06.705Z"}
{"level":"info","message":"Processing Champion.gg: Kayn","timestamp":"2018-06-09T04:08:07.898Z"}
{"level":"info","message":"Processing Champion.gg: Kennen","timestamp":"2018-06-09T04:08:09.572Z"}
{"level":"info","message":"Processing Champion.gg: Kha'Zix","timestamp":"2018-06-09T04:08:10.150Z"}
{"level":"info","message":"Processing Champion.gg: Kindred","timestamp":"2018-06-09T04:08:11.880Z"}
{"level":"info","message":"Processing Champion.gg: Kled","timestamp":"2018-06-09T04:08:11.947Z"}
{"level":"info","message":"Processing Champion.gg: Kog'Maw","timestamp":"2018-06-09T04:08:13.642Z"}
{"level":"info","message":"Processing Champion.gg: LeBlanc","timestamp":"2018-06-09T04:08:13.671Z"}
{"level":"info","message":"Processing Champion.gg: Lee Sin","timestamp":"2018-06-09T04:08:14.703Z"}
{"level":"info","message":"Processing Champion.gg: Leona","timestamp":"2018-06-09T04:08:15.392Z"}
{"level":"info","message":"Processing Champion.gg: Lissandra","timestamp":"2018-06-09T04:08:16.372Z"}
{"level":"info","message":"Processing Champion.gg: Lucian","timestamp":"2018-06-09T04:08:17.057Z"}
{"level":"info","message":"Processing Champion.gg: Lulu","timestamp":"2018-06-09T04:08:17.597Z"}
{"level":"info","message":"Processing Champion.gg: Lux","timestamp":"2018-06-09T04:08:18.762Z"}
{"level":"info","message":"Processing Champion.gg: Malphite","timestamp":"2018-06-09T04:08:19.762Z"}
{"level":"info","message":"Processing Champion.gg: Malzahar","timestamp":"2018-06-09T04:08:19.823Z"}
{"level":"info","message":"Processing Champion.gg: Maokai","timestamp":"2018-06-09T04:08:21.991Z"}
{"level":"info","message":"Processing Champion.gg: Master Yi","timestamp":"2018-06-09T04:08:22.173Z"}
{"level":"info","message":"Processing Champion.gg: Miss Fortune","timestamp":"2018-06-09T04:08:23.771Z"}
{"level":"info","message":"Processing Champion.gg: Mordekaiser","timestamp":"2018-06-09T04:08:23.926Z"}
{"level":"info","message":"Processing Champion.gg: Morgana","timestamp":"2018-06-09T04:08:27.066Z"}
{"level":"info","message":"Processing Champion.gg: Nami","timestamp":"2018-06-09T04:08:27.227Z"}
{"message":"Cannot read property 'winPercent' of undefined","stack":"TypeError: Cannot read property 'winPercent' of undefined\n    at processChamp (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\js\sources\championgg.js:177:55)\n    at then.body (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\js\sources\championgg.js:302:12)\n    at tryCatcher (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\util.js:16:23)\n    at Promise._settlePromiseFromHandler (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:510:31)\n    at Promise._settlePromise (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:567:18)\n    at Promise._settlePromise0 (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:612:10)\n    at Promise._settlePromises (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:691:18)\n    at Async._drainQueue (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:138:16)\n    at Async._drainQueues (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:148:10)\n    at Async.drainQueues (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:17:14)\n    at process._tickCallback (internal/process/next_tick.js:103:7)","level":"warn","timestamp":"2018-06-09T04:08:27.329Z"}
{"level":"info","message":"Processing Champion.gg: Nasus","timestamp":"2018-06-09T04:08:28.832Z"}
{"level":"info","message":"Processing Champion.gg: Nautilus","timestamp":"2018-06-09T04:08:28.949Z"}
{"message":"Cannot read property 'winPercent' of undefined","stack":"TypeError: Cannot read property 'winPercent' of undefined\n    at processChamp (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\js\sources\championgg.js:177:55)\n    at then.body (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\js\sources\championgg.js:302:12)\n    at tryCatcher (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\util.js:16:23)\n    at Promise._settlePromiseFromHandler (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:510:31)\n    at Promise._settlePromise (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:567:18)\n    at Promise._settlePromise0 (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:612:10)\n    at Promise._settlePromises (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:691:18)\n    at Async._drainQueue (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:138:16)\n    at Async._drainQueues (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:148:10)\n    at Async.drainQueues (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:17:14)\n    at process._tickCallback (internal/process/next_tick.js:103:7)","level":"warn","timestamp":"2018-06-09T04:08:29.044Z"}
{"level":"info","message":"Processing Champion.gg: Nidalee","timestamp":"2018-06-09T04:08:30.507Z"}
{"message":"Cannot read property 'winPercent' of undefined","stack":"TypeError: Cannot read property 'winPercent' of undefined\n    at processChamp (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\js\sources\championgg.js:177:55)\n    at then.body (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\js\sources\championgg.js:302:12)\n    at tryCatcher (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\util.js:16:23)\n    at Promise._settlePromiseFromHandler (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:510:31)\n    at Promise._settlePromise (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:567:18)\n    at Promise._settlePromise0 (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:612:10)\n    at Promise._settlePromises (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\promise.js:691:18)\n    at Async._drainQueue (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:138:16)\n    at Async._drainQueues (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:148:10)\n    at Async.drainQueues (C:\Users\USER\AppData\Local\Championify\app-2.1.5\resources\app.asar\node_modules\bluebird\js\release\async.js:17:14)\n    at process._tickCallback (internal/process/next_tick.js:103:7)","level":"warn","timestamp":"2018-06-09T04:08:31.140Z"}
{"level":"info","message":"Processing Champion.gg: Nocturne","timestamp":"2018-06-09T04:08:31.140Z"}
{"level":"info","message":"Processing Champion.gg: Nunu","timestamp":"2018-06-09T04:08:32.770Z"}
{"level":"info","message":"Processing Champion.gg: Olaf","timestamp":"2018-06-09T04:08:32.898Z"}
{"level":"info","message":"Processing Champion.gg: Orianna","timestamp":"2018-06-09T04:08:32.958Z"}
{"level":"info","message":"Processing Champion.gg: Ornn","timestamp":"2018-06-09T04:08:34.710Z"}
{"level":"info","message":"Processing Champion.gg: Pantheon","timestamp":"2018-06-09T04:08:34.897Z"}
{"level":"info","message":"Processing Champion.gg: Poppy","timestamp":"2018-06-09T04:08:36.368Z"}
{"level":"info","message":"Processing Champion.gg: Pyke","timestamp":"2018-06-09T04:08:38.380Z"}
{"level":"info","message":"Processing Champion.gg: Quinn","timestamp":"2018-06-09T04:08:39.411Z"}
{"level":"info","message":"Processing Koreanbuilds: Zyra","timestamp":"2018-06-09T04:08:41.089Z"}
{"level":"info","message":"Processing Koreanbuilds: Zoe","timestamp":"2018-06-09T04:08:41.094Z"}
{"level":"info","message":"Processing Koreanbuilds: Zilean","timestamp":"2018-06-09T04:08:41.096Z"}
{"level":"info","message":"Processing Koreanbuilds: Aatrox","timestamp":"2018-06-09T04:08:41.100Z"}
{"level":"info","message":"Processing Champion.gg: Rakan","timestamp":"2018-06-09T04:08:41.456Z"}
{"level":"info","message":"Processing Champion.gg: Rammus","timestamp":"2018-06-09T04:08:42.289Z"}
{"level":"info","message":"Processing Champion.gg: Rek'Sai","timestamp":"2018-06-09T04:08:42.849Z"}
{"level":"info","message":"Processing Koreanbuilds: Ahri","timestamp":"2018-06-09T04:08:43.072Z"}
{"level":"info","message":"Processing Koreanbuilds: Akali","timestamp":"2018-06-09T04:08:43.164Z"}
{"level":"info","message":"Processing Koreanbuilds: Alistar","timestamp":"2018-06-09T04:08:43.173Z"}
{"level":"info","message":"Processing Champion.gg: Renekton","timestamp":"2018-06-09T04:08:43.209Z"}
{"level":"info","message":"Processing Champion.gg: Rengar","timestamp":"2018-06-09T04:08:44.017Z"}
{"level":"info","message":"Processing Champion.gg: Riven","timestamp":"2018-06-09T04:08:44.575Z"}
{"level":"info","message":"Processing Champion.gg: Rumble","timestamp":"2018-06-09T04:08:44.913Z"}
{"level":"info","message":"Processing Koreanbuilds: Amumu","timestamp":"2018-06-09T04:08:45.076Z"}
{"level":"info","message":"Processing Koreanbuilds: Anivia","timestamp":"2018-06-09T04:08:45.080Z"}
{"level":"info","message":"Processing Koreanbuilds: Annie","timestamp":"2018-06-09T04:08:45.092Z"}
{"level":"info","message":"Processing Koreanbuilds: Ashe","timestamp":"2018-06-09T04:08:45.210Z"}
{"level":"info","message":"Processing Koreanbuilds: Aurelion Sol","timestamp":"2018-06-09T04:08:45.234Z"}
{"level":"info","message":"Processing Champion.gg: Ryze","timestamp":"2018-06-09T04:08:46.633Z"}
{"level":"info","message":"Processing Koreanbuilds: Azir","timestamp":"2018-06-09T04:08:47.071Z"}
{"level":"info","message":"Processing Koreanbuilds: Bard","timestamp":"2018-06-09T04:08:47.074Z"}
{"level":"info","message":"Processing Koreanbuilds: Blitzcrank","timestamp":"2018-06-09T04:08:47.172Z"}
{"level":"info","message":"Processing Koreanbuilds: Brand","timestamp":"2018-06-09T04:08:47.247Z"}
{"level":"info","message":"Processing Champion.gg: Sejuani","timestamp":"2018-06-09T04:08:47.523Z"}
{"level":"info","message":"Processing Champion.gg: Shaco","timestamp":"2018-06-09T04:08:48.057Z"}
{"level":"info","message":"Processing Koreanbuilds: Braum","timestamp":"2018-06-09T04:08:49.067Z"}
{"level":"info","message":"Processing Koreanbuilds: Caitlyn","timestamp":"2018-06-09T04:08:49.113Z"}
{"level":"info","message":"Processing Champion.gg: Shen","timestamp":"2018-06-09T04:08:49.226Z"}
{"level":"info","message":"Processing Koreanbuilds: Camille","timestamp":"2018-06-09T04:08:49.258Z"}
{"level":"info","message":"Processing Champion.gg: Shyvana","timestamp":"2018-06-09T04:08:49.790Z"}
{"level":"info","message":"Processing Champion.gg: Singed","timestamp":"2018-06-09T04:08:50.040Z"}
{"level":"info","message":"Processing Koreanbuilds: Cassiopeia","timestamp":"2018-06-09T04:08:51.065Z"}
{"level":"info","message":"Processing Koreanbuilds: Cho'Gath","timestamp":"2018-06-09T04:08:51.154Z"}
{"level":"info","message":"Processing Koreanbuilds: Corki","timestamp":"2018-06-09T04:08:51.283Z"}
{"level":"info","message":"Processing Koreanbuilds: Darius","timestamp":"2018-06-09T04:08:51.285Z"}
{"level":"info","message":"Processing Champion.gg: Sion","timestamp":"2018-06-09T04:08:51.512Z"}
{"level":"info","message":"Processing Koreanbuilds: Diana","timestamp":"2018-06-09T04:08:53.025Z"}
{"level":"info","message":"Processing Koreanbuilds: Dr. Mundo","timestamp":"2018-06-09T04:08:53.029Z"}
{"level":"info","message":"Processing Koreanbuilds: Draven","timestamp":"2018-06-09T04:08:53.155Z"}
{"level":"info","message":"Processing Champion.gg: Sivir","timestamp":"2018-06-09T04:08:53.253Z"}
{"level":"info","message":"Processing Koreanbuilds: Ekko","timestamp":"2018-06-09T04:08:53.280Z"}
{"level":"info","message":"Processing Champion.gg: Skarner","timestamp":"2018-06-09T04:08:53.810Z"}
{"level":"info","message":"Processing Champion.gg: Sona","timestamp":"2018-06-09T04:08:55.005Z"}
{"level":"info","message":"Processing Koreanbuilds: Elise","timestamp":"2018-06-09T04:08:55.020Z"}
{"level":"info","message":"Processing Koreanbuilds: Evelynn","timestamp":"2018-06-09T04:08:55.138Z"}
{"level":"info","message":"Processing Koreanbuilds: Ezreal","timestamp":"2018-06-09T04:08:55.288Z"}
{"level":"info","message":"Processing Champion.gg: Soraka","timestamp":"2018-06-09T04:08:55.528Z"}
{"level":"info","message":"Processing Champion.gg: Swain","timestamp":"2018-06-09T04:08:55.820Z"}
{"level":"info","message":"Processing Champion.gg: Syndra","timestamp":"2018-06-09T04:08:56.743Z"}
{"level":"info","message":"Processing Koreanbuilds: Fiddlesticks","timestamp":"2018-06-09T04:08:56.986Z"}
{"level":"info","message":"Processing Koreanbuilds: Fiora","timestamp":"2018-06-09T04:08:57.100Z"}
{"level":"info","message":"Processing Koreanbuilds: Fizz","timestamp":"2018-06-09T04:08:57.285Z"}
{"level":"info","message":"Processing Champion.gg: Tahm Kench","timestamp":"2018-06-09T04:08:57.803Z"}
{"level":"info","message":"Processing Champion.gg: Taliyah","timestamp":"2018-06-09T04:08:58.500Z"}
{"level":"info","message":"Processing Koreanbuilds: Galio","timestamp":"2018-06-09T04:08:59.010Z"}
{"level":"info","message":"Processing Koreanbuilds: Gangplank","timestamp":"2018-06-09T04:08:59.071Z"}
{"level":"info","message":"Processing Koreanbuilds: Garen","timestamp":"2018-06-09T04:08:59.303Z"}
{"level":"info","message":"Processing Koreanbuilds: Gnar","timestamp":"2018-06-09T04:08:59.305Z"}
{"level":"info","message":"Processing Koreanbuilds: Gragas","timestamp":"2018-06-09T04:08:59.307Z"}
{"level":"info","message":"Processing Champion.gg: Talon","timestamp":"2018-06-09T04:09:00.934Z"}
{"level":"info","message":"Processing Koreanbuilds: Graves","timestamp":"2018-06-09T04:09:00.991Z"}
{"level":"info","message":"Processing Koreanbuilds: Hecarim","timestamp":"2018-06-09T04:09:01.102Z"}
{"level":"info","message":"Processing Koreanbuilds: Heimerdinger","timestamp":"2018-06-09T04:09:01.104Z"}
{"level":"info","message":"Processing Champion.gg: Taric","timestamp":"2018-06-09T04:09:01.992Z"}
{"level":"info","message":"Processing Champion.gg: Teemo","timestamp":"2018-06-09T04:09:02.122Z"}
{"level":"info","message":"Processing Champion.gg: Thresh","timestamp":"2018-06-09T04:09:02.657Z"}
{"level":"info","message":"Processing Koreanbuilds: Illaoi","timestamp":"2018-06-09T04:09:03.004Z"}
{"level":"info","message":"Processing Koreanbuilds: Irelia","timestamp":"2018-06-09T04:09:03.211Z"}
{"level":"info","message":"Processing Koreanbuilds: Ivern","timestamp":"2018-06-09T04:09:03.252Z"}
{"level":"info","message":"Processing Champion.gg: Tristana","timestamp":"2018-06-09T04:09:03.765Z"}
{"level":"info","message":"Processing Champion.gg: Trundle","timestamp":"2018-06-09T04:09:04.809Z"}
{"level":"info","message":"Processing Koreanbuilds: Janna","timestamp":"2018-06-09T04:09:04.975Z"}
{"level":"info","message":"Processing Koreanbuilds: Jarvan IV","timestamp":"2018-06-09T04:09:05.249Z"}
{"level":"info","message":"Processing Koreanbuilds: Jax","timestamp":"2018-06-09T04:09:05.257Z"}
{"level":"info","message":"Processing Champion.gg: Tryndamere","timestamp":"2018-06-09T04:09:05.508Z"}
{"level":"info","message":"Processing Champion.gg: Twisted Fate","timestamp":"2018-06-09T04:09:05.603Z"}
{"level":"info","message":"Processing Koreanbuilds: Jayce","timestamp":"2018-06-09T04:09:06.969Z"}
{"level":"info","message":"Processing Koreanbuilds: Jhin","timestamp":"2018-06-09T04:09:07.269Z"}
{"level":"info","message":"Processing Koreanbuilds: Jinx","timestamp":"2018-06-09T04:09:07.300Z"}
{"level":"info","message":"Processing Champion.gg: Twitch","timestamp":"2018-06-09T04:09:07.772Z"}
{"level":"info","message":"Processing Champion.gg: Udyr","timestamp":"2018-06-09T04:09:08.764Z"}
{"level":"info","message":"Processing Koreanbuilds: Kai'Sa","timestamp":"2018-06-09T04:09:09.000Z"}
{"level":"info","message":"Processing Koreanbuilds: Kalista","timestamp":"2018-06-09T04:09:09.281Z"}
{"level":"info","message":"Processing Koreanbuilds: Karma","timestamp":"2018-06-09T04:09:09.291Z"}
{"level":"info","message":"Processing Champion.gg: Urgot","timestamp":"2018-06-09T04:09:09.542Z"}
{"level":"info","message":"Processing Champion.gg: Varus","timestamp":"2018-06-09T04:09:10.551Z"}
{"level":"info","message":"Processing Koreanbuilds: Karthus","timestamp":"2018-06-09T04:09:11.026Z"}
{"level":"info","message":"Processing Champion.gg: Vayne","timestamp":"2018-06-09T04:09:11.265Z"}
{"level":"info","message":"Processing Champion.gg: Veigar","timestamp":"2018-06-09T04:09:11.301Z"}
{"level":"info","message":"Processing Koreanbuilds: Kassadin","timestamp":"2018-06-09T04:09:11.309Z"}
{"level":"info","message":"Processing Koreanbuilds: Katarina","timestamp":"2018-06-09T04:09:11.333Z"}
{"level":"info","message":"Processing Champion.gg: Vel'Koz","timestamp":"2018-06-09T04:09:12.254Z"}
{"level":"info","message":"Processing Champion.gg: Vi","timestamp":"2018-06-09T04:09:13.120Z"}
{"level":"info","message":"Processing Koreanbuilds: Kayle","timestamp":"2018-06-09T04:09:13.289Z"}
{"level":"info","message":"Processing Koreanbuilds: Kayn","timestamp":"2018-06-09T04:09:13.292Z"}
{"level":"info","message":"Processing Koreanbuilds: Kennen","timestamp":"2018-06-09T04:09:13.293Z"}
{"level":"info","message":"Processing Koreanbuilds: Kha'Zix","timestamp":"2018-06-09T04:09:13.303Z"}
{"level":"info","message":"Processing Koreanbuilds: Kindred","timestamp":"2018-06-09T04:09:13.337Z"}
{"level":"info","message":"Processing Champion.gg: Viktor","timestamp":"2018-06-09T04:09:14.889Z"}
{"level":"info","message":"Processing Koreanbuilds: Kled","timestamp":"2018-06-09T04:09:15.322Z"}
{"level":"info","message":"Processing Koreanbuilds: Kog'Maw","timestamp":"2018-06-09T04:09:15.332Z"}
{"level":"info","message":"Processing Champion.gg: Vladimir","timestamp":"2018-06-09T04:09:15.376Z"}
{"level":"info","message":"Processing Koreanbuilds: LeBlanc","timestamp":"2018-06-09T04:09:15.385Z"}
{"level":"info","message":"Processing Champion.gg: Volibear","timestamp":"2018-06-09T04:09:15.722Z"}
{"level":"info","message":"Processing Champion.gg: Warwick","timestamp":"2018-06-09T04:09:16.667Z"}
{"level":"info","message":"Processing Koreanbuilds: Lee Sin","timestamp":"2018-06-09T04:09:17.356Z"}
{"level":"info","message":"Processing Koreanbuilds: Leona","timestamp":"2018-06-09T04:09:17.369Z"}
{"level":"info","message":"Processing Koreanbuilds: Lissandra","timestamp":"2018-06-09T04:09:17.403Z"}
{"level":"info","message":"Processing Champion.gg: Wukong","timestamp":"2018-06-09T04:09:18.402Z"}
{"level":"info","message":"Processing Champion.gg: Xayah","timestamp":"2018-06-09T04:09:18.809Z"}
{"level":"info","message":"Processing Champion.gg: Xerath","timestamp":"2018-06-09T04:09:19.104Z"}
{"level":"info","message":"Processing Koreanbuilds: Lucian","timestamp":"2018-06-09T04:09:19.349Z"}
{"level":"info","message":"Processing Koreanbuilds: Lulu","timestamp":"2018-06-09T04:09:19.362Z"}
{"level":"info","message":"Processing Koreanbuilds: Lux","timestamp":"2018-06-09T04:09:19.434Z"}
{"level":"info","message":"Processing Koreanbuilds: Malphite","timestamp":"2018-06-09T04:09:19.436Z"}
{"level":"info","message":"Processing Champion.gg: Xin Zhao","timestamp":"2018-06-09T04:09:20.589Z"}
{"level":"info","message":"Processing Koreanbuilds: Malzahar","timestamp":"2018-06-09T04:09:21.364Z"}
{"level":"info","message":"Processing Champion.gg: Yasuo","timestamp":"2018-06-09T04:09:21.867Z"}
{"level":"info","message":"Processing Champion.gg: Yorick","timestamp":"2018-06-09T04:09:22.374Z"}
{"level":"info","message":"Processing Champion.gg: Zac","timestamp":"2018-06-09T04:09:22.512Z"}
{"level":"info","message":"Processing Koreanbuilds: Maokai","timestamp":"2018-06-09T04:09:23.273Z"}
{"level":"info","message":"Processing Koreanbuilds: Master Yi","timestamp":"2018-06-09T04:09:23.275Z"}
{"level":"info","message":"Processing Koreanbuilds: Miss Fortune","timestamp":"2018-06-09T04:09:23.298Z"}
{"level":"info","message":"Processing Koreanbuilds: Mordekaiser","timestamp":"2018-06-09T04:09:23.376Z"}
{"level":"info","message":"Processing Champion.gg: Zed","timestamp":"2018-06-09T04:09:24.242Z"}
{"level":"info","message":"Processing Champion.gg: Ziggs","timestamp":"2018-06-09T04:09:24.633Z"}
{"level":"info","message":"Processing Koreanbuilds: Morgana","timestamp":"2018-06-09T04:09:25.268Z"}
{"level":"info","message":"Processing Koreanbuilds: Nami","timestamp":"2018-06-09T04:09:25.337Z"}
{"level":"info","message":"Processing Koreanbuilds: Nasus","timestamp":"2018-06-09T04:09:25.386Z"}
{"level":"info","message":"Processing Koreanbuilds: Nautilus","timestamp":"2018-06-09T04:09:27.267Z"}
{"level":"info","message":"Processing Koreanbuilds: Nidalee","timestamp":"2018-06-09T04:09:27.299Z"}
{"level":"info","message":"Processing Koreanbuilds: Nocturne","timestamp":"2018-06-09T04:09:27.354Z"}
{"level":"info","message":"Processing Koreanbuilds: Nunu","timestamp":"2018-06-09T04:09:29.275Z"}
{"level":"info","message":"Processing Koreanbuilds: Olaf","timestamp":"2018-06-09T04:09:29.301Z"}
{"level":"info","message":"Processing Koreanbuilds: Orianna","timestamp":"2018-06-09T04:09:29.354Z"}
{"level":"info","message":"Processing Koreanbuilds: Ornn","timestamp":"2018-06-09T04:09:31.299Z"}
{"level":"info","message":"Processing Koreanbuilds: Pantheon","timestamp":"2018-06-09T04:09:31.346Z"}
{"level":"info","message":"Processing Koreanbuilds: Poppy","timestamp":"2018-06-09T04:09:31.359Z"}
{"level":"info","message":"Processing Koreanbuilds: Pyke","timestamp":"2018-06-09T04:09:33.328Z"}
{"level":"info","message":"Processing Koreanbuilds: Quinn","timestamp":"2018-06-09T04:09:33.374Z"}
{"level":"info","message":"Processing Koreanbuilds: Rakan","timestamp":"2018-06-09T04:09:33.387Z"}
{"level":"info","message":"Processing Koreanbuilds: Rammus","timestamp":"2018-06-09T04:09:35.381Z"}
{"level":"info","message":"Processing Koreanbuilds: Rek'Sai","timestamp":"2018-06-09T04:09:37.251Z"}
{"level":"info","message":"Processing Koreanbuilds: Renekton","timestamp":"2018-06-09T04:09:37.322Z"}
{"level":"info","message":"Processing Koreanbuilds: Rengar","timestamp":"2018-06-09T04:09:37.337Z"}
{"level":"info","message":"Processing Koreanbuilds: Riven","timestamp":"2018-06-09T04:09:39.319Z"}
{"level":"info","message":"Processing Koreanbuilds: Rumble","timestamp":"2018-06-09T04:09:39.323Z"}
{"level":"info","message":"Processing Koreanbuilds: Ryze","timestamp":"2018-06-09T04:09:39.354Z"}
{"level":"info","message":"Processing Koreanbuilds: Sejuani","timestamp":"2018-06-09T04:09:39.376Z"}
{"level":"info","message":"Processing Koreanbuilds: Shaco","timestamp":"2018-06-09T04:09:41.326Z"}
{"level":"info","message":"Processing Koreanbuilds: Shen","timestamp":"2018-06-09T04:09:41.351Z"}
{"level":"info","message":"Processing Koreanbuilds: Shyvana","timestamp":"2018-06-09T04:09:41.375Z"}
{"level":"info","message":"Processing Koreanbuilds: Singed","timestamp":"2018-06-09T04:09:41.378Z"}
{"level":"info","message":"Processing Koreanbuilds: Sion","timestamp":"2018-06-09T04:09:43.306Z"}
{"level":"info","message":"Processing Koreanbuilds: Sivir","timestamp":"2018-06-09T04:09:43.333Z"}
{"level":"info","message":"Processing Koreanbuilds: Skarner","timestamp":"2018-06-09T04:09:43.369Z"}
{"level":"info","message":"Processing Koreanbuilds: Sona","timestamp":"2018-06-09T04:09:45.289Z"}
{"level":"info","message":"Processing Koreanbuilds: Soraka","timestamp":"2018-06-09T04:09:45.292Z"}
{"level":"info","message":"Processing Koreanbuilds: Swain","timestamp":"2018-06-09T04:09:45.337Z"}
{"level":"info","message":"Processing Koreanbuilds: Syndra","timestamp":"2018-06-09T04:09:45.406Z"}
{"level":"info","message":"Processing Koreanbuilds: Tahm Kench","timestamp":"2018-06-09T04:09:47.340Z"}
{"level":"info","message":"Processing Koreanbuilds: Taliyah","timestamp":"2018-06-09T04:09:47.355Z"}
{"level":"info","message":"Processing Koreanbuilds: Talon","timestamp":"2018-06-09T04:09:47.373Z"}
{"level":"info","message":"Processing Koreanbuilds: Taric","timestamp":"2018-06-09T04:09:49.437Z"}
{"level":"info","message":"Processing Koreanbuilds: Teemo","timestamp":"2018-06-09T04:09:49.451Z"}
{"level":"info","message":"Processing Koreanbuilds: Thresh","timestamp":"2018-06-09T04:09:49.452Z"}
{"level":"info","message":"Processing Koreanbuilds: Tristana","timestamp":"2018-06-09T04:09:51.425Z"}
{"level":"info","message":"Processing Koreanbuilds: Trundle","timestamp":"2018-06-09T04:09:51.440Z"}
{"level":"info","message":"Processing Koreanbuilds: Tryndamere","timestamp":"2018-06-09T04:09:51.466Z"}
{"level":"info","message":"Processing Koreanbuilds: Twisted Fate","timestamp":"2018-06-09T04:09:53.456Z"}
{"level":"info","message":"Processing Koreanbuilds: Twitch","timestamp":"2018-06-09T04:09:53.481Z"}
{"level":"info","message":"Processing Koreanbuilds: Udyr","timestamp":"2018-06-09T04:09:53.483Z"}
{"level":"info","message":"Processing Koreanbuilds: Urgot","timestamp":"2018-06-09T04:09:53.486Z"}
{"level":"info","message":"Processing Koreanbuilds: Varus","timestamp":"2018-06-09T04:09:55.363Z"}
{"level":"info","message":"Processing Koreanbuilds: Vayne","timestamp":"2018-06-09T04:09:55.485Z"}
{"level":"info","message":"Processing Koreanbuilds: Veigar","timestamp":"2018-06-09T04:09:55.508Z"}
{"level":"info","message":"Processing Koreanbuilds: Vel'Koz","timestamp":"2018-06-09T04:09:55.511Z"}
{"level":"info","message":"Processing Koreanbuilds: Vi","timestamp":"2018-06-09T04:09:57.349Z"}
{"level":"info","message":"Processing Koreanbuilds: Viktor","timestamp":"2018-06-09T04:09:57.351Z"}
{"level":"info","message":"Processing Koreanbuilds: Vladimir","timestamp":"2018-06-09T04:09:57.353Z"}
{"level":"info","message":"Processing Koreanbuilds: Volibear","timestamp":"2018-06-09T04:09:57.493Z"}
{"level":"info","message":"Processing Koreanbuilds: Warwick","timestamp":"2018-06-09T04:09:57.508Z"}
{"level":"info","message":"Processing Koreanbuilds: Wukong","timestamp":"2018-06-09T04:09:57.511Z"}
{"level":"info","message":"Processing Koreanbuilds: Xayah","timestamp":"2018-06-09T04:09:57.514Z"}
{"level":"info","message":"Processing Koreanbuilds: Xerath","timestamp":"2018-06-09T04:09:59.359Z"}
{"level":"info","message":"Processing Koreanbuilds: Xin Zhao","timestamp":"2018-06-09T04:09:59.361Z"}
{"level":"info","message":"Processing Koreanbuilds: Yasuo","timestamp":"2018-06-09T04:09:59.487Z"}
{"level":"info","message":"Processing Koreanbuilds: Yorick","timestamp":"2018-06-09T04:09:59.505Z"}
{"level":"info","message":"Processing Koreanbuilds: Zac","timestamp":"2018-06-09T04:09:59.507Z"}
{"level":"info","message":"Processing Koreanbuilds: Zed","timestamp":"2018-06-09T04:10:01.341Z"}
{"level":"info","message":"Processing Koreanbuilds: Ziggs","timestamp":"2018-06-09T04:10:01.508Z"}
{"level":"info","message":"Saved preference file to C:\Users\USER\AppData\Roaming\Championify\prefs.json","timestamp":"2018-06-09T04:10:06.066Z"}
Config: {
"prefs_version": "2.1.5",
"locale": "en",
"install_path": "C:\Riot Games\League of Legends",
"champ_path": "Config/Champions/",
"local_is_version": "8.11",
"options": {
"splititems": false,
"skillsformat": true,
"consumables": true,
"consumables_position": "end",
"trinkets": true,
"trinkets_position": "end",
"locksr": false,
"sr_source": [
"championgg",
"koreanbuilds"
],
"dontdeleteold": true,
"aram": false
}
}

Not really a bug, just how Bluebird handles arrays for whatever odd reason. I'll keep this here either way.


Desktop icon is re-added after every update

It seems like this issue is still occurring in the latest version.  While this is only a minor annoyance, as someone who likes to keep their desktop pristine, it is still an annoyance.  Perhaps it's worth reopening?

Can confirm it still happens (Windows 10)

Still happens (commenting so stale bot won't close it)

I will add that this still happens, and it's quite the nuisance for someone like me who cares greatly what appears on my desktop. Would really appreciate a fix to this!

I have one icon on my desktop, with an invisible name and a transparent icon, so it's quite noticeable. Every time I open Insomnia there seems to have been an update, so as soon as I see the toast I press Win+D and delete the new shortcut. As I'm sure you can imagine, this has a great toll on my weekly productivity! 😉

Still happens (commenting again so stale bot won't close it)

Is this fixed now?
No new shortcut on desktop after updating to v5.16.6, but found no mention in the changelog.

This hasn't been explicitly fixed but it's possible that a dependency was updated that stopped it from happening?
Can someone confirm (I'm not a Windows user)?

A shortcut was created again when updating from 5.16.6 to 6.0.2. 🤷♂

A shortcut was created for me a week or two ago. Can a setting not be added to disable the shortcut creation? Is it handled by the Electon updater?

activity

Still happens...

still happens


Show subway stations starting at zoom 12

Start showing all subway stations at zoom 12 in the tile data. The style then uses a cut-off based on the kind_tile_rank to choose which are visible.
Note that this PR includes a bunch of commits related to adding rental to the parameters of mz_calculate_poi_level, which should have been done as part of #432, but looks like it was missed out from that. This also needs a migration.
Connects to #369.
@rmarianski could you review, please?

:+1:


Update or replace django-elasticsearch-dsl-drf

We use the package django-elasticsearch-dsl-drf in edx/course-discovery, edx/edx-notes-api. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

@jmbowman, django-elasticsearch-dsl-drf already supports Django 3.2 with the master branch and I have created an issue to make a new release of the package.

@jmbowman, 0.22.2 is out for django-elasticsearch-dsl-drf which is tested against Django 3.2

@jramnai Great, thanks for following up on that!


[FEATURE] Support for multiple datasets within Zip Uploads

Is your feature request related to a problem? If so, Please describe.
The first implementation of zip uploads only works with a single flat dataset.  This would allow  folders to be inside of the zip file and each folder would be created into it's own dataset.  This would enable bulk uploading of multiple datasets without complicating the upload tool further.
Describe the solution you'd like

Using the existing task in the zip upload the zip file would extract to the temporary location and 'validate_files' would be run on every sub folder.
If the sub folder was determined to be valid it would create a new dataset folder in the root folder and upload the files there.
Once complete it would run /postprocess on the root folder to move the zip file into a source folder and then would run /postprocess on all of the validated sub folders.
Documentation for zip files would also need to be updated to reflect the capability of multiple folders being uploaded

Additional context
This would be related to PR #1062 and would be done after the initial version is merged for a single file.

I'd like to make sure we don't try to do too much in the course of solving this issue. Some kind of behavioral spec before you jump in would be useful, to constrain what we offer here. Put another way, I don't think we should attempt to cover every corner case, etc. We should keep a bit of the ol' UNIX philosophy in our back pocket, for example, and bail out if a byzantine problem begins to develop with a given zip file.

Isn't this done by #1062 @BryonLewis ?

Yes, thanks to the update you made to that PR, it was implemented on web.  This can be marked as closed.


Version 1.3.1 very old

The Version is very old (Oct 24, 2017). Therefore 1.3.1 is the newest version in the linux distros. With this version, the examples won't build. I just built the newest version for fedora and everything works.
So please release a new version having a version number ;-)

v1.3.2 released! Thanks for poking me on this.

Just for a comment for Fedora Distributors: there where some unecessary patches which are no longer requiered. For the Specfile, see: https://github.com/dl1chb/rf-tools/blob/master/liquid-dsp.spec


How to remove "mlstars.custom.timeseries_preprocessing.time_segments_aggregate" from pipeline for custom data

Orion version: 0.6
Python version:3.11
Operating System:Windows

Description
Can I remove times_segments_aggregate since my data is already equi-spaced with a weekly frequency.
Here is the data
timestamp,signal,anomaly
1357171200,406.5,0
1357776000,417.0,0
1358380800,421.0,0
1358985600,429.0,0

Due to it I think the anomalies in my data are wrong.
What I Did
Here is the hyperparameters what I set.
hyperparameters = {
    "mlstars.custom.timeseries_preprocessing.time_segments_aggregate#1": {
        "time_column": "timestamp",
        "interval": 604800
    },
   'orion.primitives.aer.AER#1': {
        'epochs': 5,
        'verbose': True
    }
}

The anomaly interval is nothing close to what is should be. Please guide me through.

Hi @aloner-pro, thank you for using Orion!
If your data is already equi-spaced, then the primitive time_segments_aggregate will not change your data. In other words, what you did was correct to set the interval parameter to the actual space of your time series.
As for what you expect the anomaly interval to be, can you elaborate more on that? Was the ground truth anomaly enclosed within the detected anomalies?
There are certain parameters that need to be adjusted based on what you expect. For example, if you find that the detected anomalous range is too big, you can reduce the padding size. Here is an example:
hyperparameters = {
    "orion.primitives.timeseries_anomalies.find_anomalies#1": {
        "anomaly_padding": 1,
    }
}

More on the postprocessing primitives can be found in our documentation.


sql: provide table comments for virtual tables

PR: https://github.com/cockroachdb/cockroach/pull/34764
From release notes:

CockroachDB now provides usable comments with optional documentation URLs for the virtual tables in pg_catalog, information_schema, and crdb_internal. Use SHOW TABLES [FROM ...] WITH COMMENT to read. Note that crdb_internal tables remain an experimental feature subject to change without notice. [#34764][#34764] {% comment %}doc{% endcomment %}

@knz, is this something we want to feature in our documentation?

I recommend pushing this doc to 19.2, when our support for comments and introspection will be more mature.

OK. Thanks, @knz. Delaying to 19.2.

@knz, I can't figure out how to get comments on virtual tables to return. The straightforward show tables from information_schema with comments (like we do for user-create tables) doesn't work. And I don't think there's a select for this. Any tips?

it's with comment.

Ah, I see. Thanks, @knz.

@rmloveland, I'll take this one.


Implement safe persistence of logs in ES

Added two commands to disco_elasticsearch.py:

archive: Archive the indices that are older than yesterday's date to S3. It also has a --groom flag, which would delete enough indices from the cluster to bring down disk usage to the archive threshold.
restore: Restore the indices within a date range from S3 to any cluster

Associated story: https://amplify-litco.atlassian.net/browse/AS-184
TODO:

[x] Write unit tests
[x] Update readme

+1

build

+1


Add JustList: {JustList name}

Checklist

[ ] I understand that this is not the place to request a token listing.
[ ] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[ ] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL: https://raw.githubusercontent.com/uuiiqqbbs/list/main/besttronalliance.json
JustList Name: WSBCToken
Link to the official homepage of the JustList manager:https://github.com/uuiiqqbbs

Sorry, your issue will be closed as you did not submit your information in the correct format.


Reproducing Translation results

Hi,
Thank you for releasing the model and this repository!
I am trying to reproduce the Java->C# translation results from the paper using CodeT5-base.
I ran it according to the instructions,
and in the 15th epoch I got dev results of:
[15] Best bleu+em: 150.38 (bleu: 82.18, em: 68.20)

The model early-stopped itself and evaluated on the test set, and these are the results on the test set:
[best-bleu] bleu-4: 83.83, em: 63.7000, codebleu: 0.0000

However, the results reported in the paper are bleu: 84.03 and EM: 65.90.
The BLEU results are sufficiently close to the reported results, but EM is 2.2% from the paper numbers.
Do you have an idea whether the reported settings are different from the settings in the paper, or is it just training randomness?
These are the settings from my logs:
03/10/2022 15:22:47 - INFO - __main__ -   Namespace(task='translate', sub_task='java-cs', lang='c_sharp', eval_task='', model_type='codet5', add_lang_ids=False, data_num=-1, start_epoch=0, num_train_epochs=100, patience=5, cache_path='saved_models/translate/java-cs/codet5_base_all_lr5_bs25_src320_trg256_pat5_e100/cache_data', summary_dir='tensorboard', data_dir='/projects/tir4/users/urialon/CodeT5/data', res_dir='saved_models/translate/java-cs/codet5_base_all_lr5_bs25_src320_trg256_pat5_e100/prediction', res_fn='results/translate_codet5_base.txt', add_task_prefix=False, save_last_checkpoints=True, always_save_model=True, do_eval_bleu=True, model_name_or_path='Salesforce/codet5-base', output_dir='saved_models/translate/java-cs/codet5_base_all_lr5_bs25_src320_trg256_pat5_e100', load_model_path=None, train_filename=None, dev_filename=None, test_filename=None, config_name='', tokenizer_name='Salesforce/codet5-base', max_source_length=320, max_target_length=256, do_train=True, do_eval=True, do_test=True, do_lower_case=False, no_cuda=False, train_batch_size=25, eval_batch_size=25, gradient_accumulation_steps=1, learning_rate=5e-05, beam_size=10, weight_decay=0.0, adam_epsilon=1e-08, max_grad_norm=1.0, save_steps=-1, log_steps=-1, max_steps=-1, eval_steps=-1, train_steps=-1, warmup_steps=1000, local_rank=-1, seed=1234)
03/10/2022 15:22:47 - WARNING - configs -   Process rank: -1, device: cuda, n_gpu: 1, distributed training: False, cpu count: 32
03/10/2022 15:22:52 - INFO - models -   Finish loading model [223M] from Salesforce/codet5-base
03/10/2022 15:23:14 - INFO - utils -   Read 10300 examples, avg src len: 13, avg trg len: 15, max src len: 136, max trg len: 118
03/10/2022 15:23:14 - INFO - utils -   [TOKENIZE] avg src len: 45, avg trg len: 56, max src len: 391, max trg len: 404
03/10/2022 15:23:14 - INFO - utils -   Load cache data from saved_models/translate/java-cs/codet5_base_all_lr5_bs25_src320_trg256_pat5_e100/cache_data/train_all.pt
/home/ualon/.conda/envs/3090/lib/python3.9/site-packages/transformers/optimization.py:306: FutureWarning: This implementation of AdamW is deprecated and will be removed in a future version. Use thePyTorch implementation torch.optim.AdamW instead, or set `no_deprecation_warning=True` to disable this warning
  warnings.warn(
03/10/2022 15:23:14 - INFO - __main__ -   ***** Running training *****
03/10/2022 15:23:14 - INFO - __main__ -     Num examples = 10300
03/10/2022 15:23:14 - INFO - __main__ -     Batch size = 25
03/10/2022 15:23:14 - INFO - __main__ -     Batch num = 412
03/10/2022 15:23:14 - INFO - __main__ -     Num epoch = 100

Thanks!
Uri

Hi Uri,
Thanks for your interest in our work. It seems this is due to some training randomness. I've rerun another experiment and find the model early stopped at epoch 28 and reproduce a similar result of  bleu-4: 84.30, em: 65.50.
Besides, for this code translation task, one empirical finding is that the more overfitted checkpoints often work better than checkpoints selected by dev bleu score. I would also suggest you to further tune some hyper-parameters such as early stop patience.

Thank you!
On Sat, Mar 12, 2022 at 03:17 WANG Yue @.***> wrote:

Hi Uri,
Thanks for your interest in our work. It seems this is due to some
training randomness. I've rerun another experiment and find the model early
stopped at epoch 28 and reproduce a similar result of bleu-4: 84.30, em:
65.50.
Besides, for this code translation task, one empirical finding is that the
more overfitted checkpoints often work better than checkpoints selected by
dev bleu score. I would also suggest you to further tune some
hyper-parameters such as early stop patience.
—
Reply to this email directly, view it on GitHub
https://github.com/salesforce/CodeT5/issues/35#issuecomment-1065839331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADSOXMDQPC2QJG5GJSJNERTU7RHI3ANCNFSM5QPZMKUQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


CUDA Error: Unknown Error

Hello,
I'm trying to run stable-dreamfusion on windows via Docker using WSL2, runnin on a RTX 3070Ti 8Gb.
The issue is, using any kind of script without the "--test" flag, I always get to a "RuntimeError: CUDA error: unknown error".
Here's the output of nvidia-smi:
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 520.56.05    Driver Version: 522.25       CUDA Version: 11.8     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  On   | 00000000:01:00.0  On |                  N/A |
| 30%   42C    P5    26W / 310W |    658MiB /  8192MiB |     22%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

This is the command I used to test:
CUDA_LAUNCH_BLOCKING=1 python3 main.py --text "a hamburger" --workspace trial --fp16 --save_mesh
And here's the output:
Namespace(H=800, O=False, O2=False, W=800, albedo_iters=1000, angle_front=60, angle_overhead=30, backbone='grid', bg_radius=1.4, bound=1, ckpt='latest', cuda_ray=False, density_thresh=10, dir_text=False, dt_gamma=0, eval_interval=10, fovy=60, fovy_range=[40, 70], fp16=True, gui=False, guidance='stable-diffusion', h=64, iters=10000, jitter_pose=False, lambda_entropy=0.0001, lambda_opacity=0, lambda_orient=0.01, lambda_smooth=0, light_phi=0, light_theta=60, lr=0.001, max_ray_batch=4096, max_spp=1, max_steps=1024, min_near=0.1, negative='', negative_dir_text=False, num_steps=64, radius=3, radius_range=[1.0, 1.5], save_mesh=True, seed=0, test=False, text='a hamburger', update_extra_interval=16, upsample_steps=64, w=64, workspace='trial')
NeRFNetwork(
  (encoder): GridEncoder: input_dim=3 num_levels=16 level_dim=2 resolution=16 -> 2048 per_level_scale=1.3819 params=(903480, 2) gridtype=tiled align_corners=False
  (sigma_net): MLP(
    (net): ModuleList(
      (0): Linear(in_features=32, out_features=64, bias=True)
      (1): Linear(in_features=64, out_features=64, bias=True)
      (2): Linear(in_features=64, out_features=4, bias=True)
    )
  )
  (encoder_bg): FreqEncoder: input_dim=3 degree=6 output_dim=39
  (bg_net): MLP(
    (net): ModuleList(
      (0): Linear(in_features=39, out_features=64, bias=True)
      (1): Linear(in_features=64, out_features=3, bias=True)
    )
  )
)
[INFO] loaded hugging face access token from ./TOKEN!
[INFO] loading stable diffusion...
[INFO] loaded stable diffusion!
[INFO] Trainer: df | 2022-11-02_14-40-19 | cuda | fp16 | trial
[INFO] #parameters: 1816247
[INFO] Loading latest checkpoint ...
[WARN] No checkpoint found, model randomly initialized.
==> Start Training trial Epoch 1, lr=0.010000 ...
  0% 0/100 [00:00<?, ?it/s]Traceback (most recent call last):
  File "main.py", line 157, in <module>
    trainer.train(train_loader, valid_loader, max_epoch)
  File "/home/folder/nerf/utils.py", line 486, in train
    self.train_one_epoch(train_loader)
  File "/home/folder/nerf/utils.py", line 706, in train_one_epoch
    pred_rgbs, pred_ws, loss = self.train_step(data)
  File "/home/folder/nerf/utils.py", line 379, in train_step
    loss = self.guidance.train_step(text_z, pred_rgb)
  File "/home/folder/nerf/sd.py", line 98, in train_step
    noise_pred = self.unet(latent_model_input, t, encoder_hidden_states=text_embeddings).sample
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/models/unet_2d_condition.py", line 296, in forward
    sample, res_samples = downsample_block(
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/models/unet_blocks.py", line 563, in forward
    hidden_states = attn(hidden_states, context=encoder_hidden_states)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/models/attention.py", line 162, in forward
    hidden_states = block(hidden_states, context=context)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/models/attention.py", line 211, in forward
    hidden_states = self.attn1(self.norm1(hidden_states)) + hidden_states
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1190, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/models/attention.py", line 283, in forward
    hidden_states = self._attention(query, key, value)
  File "/usr/local/lib/python3.8/dist-packages/diffusers/models/attention.py", line 291, in _attention
    attention_scores = torch.matmul(query, key.transpose(-1, -2)) * self.scale
RuntimeError: CUDA error: unknown error
  0% 0/100 [00:01<?, ?it/s]

I've read around that I need 12Gb of VRAM to use this but wanted to try it anyway. The error doesn't seem to explicitly say that I need more VRAM so I'm asking here to have a double check by more expert eyes than mine.

I ran out of memory running it on Colab Nvidia Tensor T4's after about 7 epochs -- so switching to A100's with high memory to see if that works.

It seems that in WSL the error message is not always explicit (most probably OOM in your case). But you can check the GPU memory usage in task manager.


VVV rule needs to compare text to text

This rule is typically used for comparing designators or other non-numerical values.
Therefore, it is probably necessary to add "as" and "other-than" in the list of operators for CompareValues.
If "equal-to" is used, then the "number comparison" is applied
If "as" is used, then the "string comparison" is applied.

done.


IPFS Icon Request

Type
Icon request
Info
hi could you please add ipfs icon too, thanks!
Icon(s)
No response

All issues are temporarily on hold. Please refer to #316 for more info.

Hey, this icon has been added in the new-standards branch and will be merged once it is done!
https://github.com/walkxcode/dashboard-icons/blob/new-standards/png/ipfs.png
https://github.com/walkxcode/dashboard-icons/blob/new-standards/png/ipfs.svg


URL wrong for releases in README

Tiny problem:
On the README you tell people to get releases from https://github.com/jvns/dnspeep/releases.
Should be https://github.com/jvns/dnspeep (I think).
Thanks for making this!

https://github.com/jvns/dnspeep/releases works for me!

OK, that's weird. Yesterday, the link in the README was 404ing for me; today it's not.  ¯_(ツ)_/¯.
Will close; apologies for the misdirection.


Dark-Mode compatibility broken in 1.19.0-beta.1 web/react

Describe the bug; what happened?
dark mode no longer activates using the same code:
       <FluentThemeProvider
          fluentTheme={darkTheme}
        >
            <CallComposite
              locale={compositeLocale}
              adapter={callAdapter}
              callInvitationUrl={`${origin}${router.asPath}`}
              options={{
                callControls: {
                  displayType: "compact",
                  holdButton: false,
                  onFetchCustomButtonProps: customButtonsForInjection,
                },
              }}
            />
        </FluentThemeProvider>

What are the steps to reproduce the issue?
update the library to the latest 1.19.0-beta.1 package for react
What behavior did you expect?
dark mode to work as expected
In what environment did you see the issue?

"@azure/communication-calling": "1.28.1-beta.3",

"@azure/communication-calling-effects": "^1.0.1",

"@azure/communication-chat": "1.3.2",

"@azure/communication-common": "^2.3.0",

"@azure/communication-identity": "^1.2.0",

"@azure/communication-react": "^1.19.0-beta.1",

"@azure/communication-rooms": "1.1.0-beta.1",

"@fluentui/react": "^8.120.6"

OS & Device: dev environment is macos web, but also tested on windows

Browser: Chrome

Is there any additional information?
downgrading the UI library version to 1.11.0-beta.1 works as expected with dark-mode and light-mode, I have also tried other versions and the dark theme is broken from 1.12.0 version onwards.
versions where dark-theme is not working:

1.11.1-alpha-202401100012
1.11.1-alpha-202401110013
...
1.19.0-beta.1

Hi @realjesset ,
For our composites, we require that themes be passed in as a prop directly into the CallComposite JSX.element.
For example:
...
import { darkTheme } from '@azure/communication-react';
...
  <CallComposite
    fluentTheme={darkTheme}
    adapter={callAdapter}
    ...
  />


SN-38 (CHEBI:8988)

Please add PDBechem link + 3D structure
https://www.ebi.ac.uk/pdbe-srv/pdbechem/PDBEntry/list/RS4
Literature reference PMID: 32385283

now added. thanks


[BUG] Creating two instances of DefaultAzureCredential causes requests using the credential to never complete

Library name and version
Azure.Identity 1.11.0
Describe the bug
Calls to clients that accept TokenCredential as authentication will hang indefinitely, like SecretClient.GetSecretAsync. This only happens when creating multiple instances of DefaultAzureCredential the exact same way, using the same constructor and same parameters but passing each one to separate clients that accept TokenCredential.
Expected behavior
Using multiple identical instances of DefaultAzureCredential will work the same with any client that accepts a TokenCredential parameter for authentication regardless of call order/where the credentials are created.
Actual behavior
Creating multiple identical instances of DefaultAzureCredential and passing them to multiple clients that accept TokenCredential for authentication will result in only the first client being able to resolve requests successfully.
Reproduction Steps
            var cred1 = new DefaultAzureCredential();

            var client1 = new SecretClient(new Uri("https://vaultname.vault.azure.net/"), cred1);
            KeyVaultSecret secret = await client1.GetSecretAsync("message").ConfigureAwait(false);

            var cred2 = new DefaultAzureCredential();

            var client2 = new SecretClient(new Uri("https://vaultname.vault.azure.net/"), cred2);
            secret = await client2.GetSecretAsync("message").ConfigureAwait(false);

The last line never completes. However, by changing either one of the credentials to pass in new DefaultAzureCredentialOptions(), the last line will now resolve successfully.
            var cred1 = new DefaultAzureCredential();

            var client1 = new SecretClient(new Uri("https://vaultname.vault.azure.net/"), cred1);
            KeyVaultSecret secret = await client1.GetSecretAsync("message").ConfigureAwait(false);

            var cred2 = new DefaultAzureCredential(new DefaultAzureCredentialOptions());

            var client2 = new SecretClient(new Uri("https://vaultname.vault.azure.net/"), cred2);
            secret = await client2.GetSecretAsync("message").ConfigureAwait(false);

This also happens even if different clients are used, like if the first client that's passed a TokenCredential is ConfigurationClient and the second is SecretClient.
Environment
.NET SDK:
Version:           8.0.204
Commit:            c338c7548c
Workload version:  8.0.200-manifests.7d36c14f
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22621
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.204\

Hi @amerjusupovic
The second call does return, however it is spending longer attempting to retry the attempts to detect whether the IMDS managed identity endpoint is available. This behavior is a regression from a recent change we made to improve the retry delays of the first attempt to select the credential from the DefaultAzureCredential chain.
We will publish a fix soon. However, even after this is fixed it is a best practice to use a singleton credential instance if there are no differences between how they are configured.

Thanks for the explanation! I had only tested it with a timeout of 100 seconds so I suppose it would've just taken longer. We'll make sure to recommend using a single credential instance for the app config provider.