[stable/jenkins] Update Readme to work with Helm 3

Helm 3 requires release name and is of the format
helm install [NAME] [CHART] [flags]

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@bharathkkb can you add an entry in Changelog.md?

@torstenwalter done :)

@bharathkkb Thank you for the contribution.


Exception Handling in ApplyMap

Hi,
It seems like it is impossible to catch exceptions using ApplyMap. I am trying to convert elements to floats and return None if it is not possible. I have:
def float_apply(x):
    try:
        val = float(x)
    except ValueError:
        val = None

    return val

I then try:
datall = datall.applymap(float_apply)
However the exception is not caught.

Can you provide a reproducible example? I suspect that the error raised on the call to float isn't a ValueError in that case (perhaps a TypeError?). There's nothing special about applymap here, normal python exception handling applies.

Remember that dask.dataframe is lazy, so your function will not be run until you call compute.

https://stackoverflow.com/questions/45866644/exception-handling-in-dask-float-conversion

Ah, I see, this is repeated.  Closing.


highlight pdf

why am I not able to highlight pdf even after allowing permission for file URLs?

sorry but the highlighter doesn't work on PDFs. That would require a completely different architecture and is VERY difficult.


K8SPXC-935 fix trafficPolicy issue for replica services

Test name
Status

haproxy
passed

upgrade-haproxy
passed

cross-site
passed

big-data
passed

scaling
passed

recreate
passed

storage
passed

scheduled-backup
failed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

security-context
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

upgrade-proxysql
passed

limits
passed

demand-backup
passed

monitoring-2-0
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

smart-update
passed

affinity
passed

one-pod
passed

auto-tuning
passed

pitr
passed

proxysql-sidecar-res-limits
passed

users
passed

upgrade-consistency
failed

demand-backup-encrypted-with-tls
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
failed

validation-hook
passed

proxy-protocol
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1146/commits/213da3eff8b852f0fb80a77556c7d12ea7959d80
image: perconalab/percona-xtradb-cluster-operator:PR-1146-213da3ef

Test name
Status

haproxy
passed

recreate
passed

init-deploy
passed

restore-to-encrypted-cluster
passed

limits
passed

demand-backup
passed

cross-site
passed

upgrade-haproxy
passed

monitoring-2-0
passed

pitr
passed

storage
passed

scaling
passed

big-data
passed

scheduled-backup
passed

affinity
passed

demand-backup-encrypted-with-tls
passed

self-healing
passed

scaling-proxysql
passed

one-pod
passed

security-context
passed

self-healing-chaos
passed

auto-tuning
passed

self-healing-advanced
passed

proxysql-sidecar-res-limits
passed

self-healing-advanced-chaos
passed

users
passed

operator-self-healing
passed

tls-issue-self
passed

operator-self-healing-chaos
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

upgrade-proxysql
passed

validation-hook
passed

proxy-protocol
passed

smart-update
passed

upgrade-consistency
failed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1146/commits/213da3eff8b852f0fb80a77556c7d12ea7959d80
image: perconalab/percona-xtradb-cluster-operator:PR-1146-213da3ef


remote: Repository not found (only on VSCode)

Steps to Reproduce:

Create a private repository on Github
Clone it
Commit any change and push it
I always get this error message:
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/begueradj/my_repository/'

Note:
This happens ONLY through VScode, i.e. I do not face this problem through the Ubuntu Terminal tool, for example
Environment:
Version: 1.62.2
Commit: 3a6960b964327f0e3882ce18fcebd07ed191b316
Date: 2021-11-11T20:51:30.084Z
Electron: 13.5.2
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.4.0-90-generic snap

Confirming I have the same issue. Also on Ubuntu.

Also having a similar issue, on Manjaro

I'm having the same issue. I had to start using Github Desktop to Push/Pull.

@begueradj can you share the following:

a screen shot of the error
the log output from "GitHub Pull Request"
the log output from "Git"
the log output from "GitHub Authentication"

I am also facing this issue on Windows 10 with vscode

i am facing the same issue in Linux mint.It only happens on vs code

On my machine the error is close to this, where it also shows no remotes configured
One error that I was able to find in the log but did not know what to do with it is No response from host https://ssh.github.com/REDACTED/REDACTED: request to https://ssh.github.com/api/v3/rate_limit failed, reason: Client network socket disconnected before secure TLS connection was established
Github log (redact repository and org name)
[Info] Registering git provider
[Info] Looking for git repository
[Info] Found 1 repositories during activation
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] GitHubServer> No response from host https://ssh.github.com/REDACTED/REDACTED: request to https://ssh.github.com/api/v3/rate_limit failed, reason: Client network socket disconnected before secure TLS connection was established
[Info] No remote with name 'origin' found.
[Info] No remote with name 'upstream' found.
[Info] No GitHub remotes found
[Info] Review> no matching pull request metadata found for current branch development
[Info] Review> no matching pull request metadata found on GitHub for current branch development
[Info] Review> Queuing additional validate state
[Info] Review> Validating state...
[Info] No remote with name 'origin' found.
[Info] No remote with name 'upstream' found.
[Info] No GitHub remotes found
[Info] Review> no matching pull request metadata found for current branch development
[Info] Review> no matching pull request metadata found on GitHub for current branch development

Git log
Validating found git in: /usr/local/bin/git
Using git 2.34.0 from /usr/local/bin/git
> git rev-parse --git-dir
Open repository: /Users/REDACTED/REDACTED/REDACTED-REDACTED
> git fetch
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/development refs/remotes/development
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git check-ignore -v -z --stdin
> git config --get commit.template
> git config --global user.email
> git config --global user.name
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/development refs/remotes/development
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
> git show -s --format=%an <%ae> [%ai] c8ad8107a293d0e0ad56d4874c491335c3b948dc
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z c8ad8107a293d0e0ad56d4874c491335c3b948dc
> git show -s --format=%an <%ae> [%ai] 82ca97e2f2d6d5a669f29010b10c712498eaa728
> git show -s --format=%an <%ae> [%ai] 7e1d16c22a29152bcef6b04c08f892b59f8015d4
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 82ca97e2f2d6d5a669f29010b10c712498eaa728
> git show -s --format=%an <%ae> [%ai] 37b5bd1782a3ccf4528611237bbedf9477c0913b
> git show -s --format=%an <%ae> [%ai] 3d5a4f90055dbd1a6d52af1ac15f85ae0a77755e
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 7e1d16c22a29152bcef6b04c08f892b59f8015d4
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 37b5bd1782a3ccf4528611237bbedf9477c0913b
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 3d5a4f90055dbd1a6d52af1ac15f85ae0a77755e
> git show -s --format=%an <%ae> [%ai] 95b037f1f2550315796650b378c97a911061efdf
> git show -s --format=%an <%ae> [%ai] 8ce38e191bbcf187ea6f211ebb1c5fb107b536dc
> git show -s --format=%an <%ae> [%ai] 8b3fe94f8835f3c24773acc952b8f8b17b222c3f
> git show -s --format=%an <%ae> [%ai] 34acf369deac5aef91bb231300c370e873c13954
> git show -s --format=%an <%ae> [%ai] e0404c5b3ea5be29b2d565baf121c72a88312773
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 8ce38e191bbcf187ea6f211ebb1c5fb107b536dc
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 8b3fe94f8835f3c24773acc952b8f8b17b222c3f
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 95b037f1f2550315796650b378c97a911061efdf
> git show -s --format=%an <%ae> [%ai] 7f37374cd05a33c565e2458ae381cf5e6024a109
> git show -s --format=%an <%ae> [%ai] d7b98883301e585c18ef5464bb7d5fdf666da7ce
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z e0404c5b3ea5be29b2d565baf121c72a88312773
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 7f37374cd05a33c565e2458ae381cf5e6024a109
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 34acf369deac5aef91bb231300c370e873c13954
> git show -s --format=%an <%ae> [%ai] 88ee204ed0da40be30ac2b8a9b4dbaeea14bcc40
> git show -s --format=%an <%ae> [%ai] d86fa66b1ebd17651495b4f3a9d2f539e66e9998
> git show -s --format=%an <%ae> [%ai] f6817d131728d4ce9954e52551b15a279c387318
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z d7b98883301e585c18ef5464bb7d5fdf666da7ce
> git show -s --format=%an <%ae> [%ai] 34acf369deac5aef91bb231300c370e873c13954
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z d86fa66b1ebd17651495b4f3a9d2f539e66e9998
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z f6817d131728d4ce9954e52551b15a279c387318
> git show -s --format=%an <%ae> [%ai] 5592d73738f9f4ce138f88ebab0d99a2e60364ec
> git show -s --format=%an <%ae> [%ai] ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 88ee204ed0da40be30ac2b8a9b4dbaeea14bcc40
> git show -s --format=%an <%ae> [%ai] 3922eb125b04c3af31e407058bea35a40cf55f09
> git show -s --format=%an <%ae> [%ai] 265e4c9393cf6790dcd7871fcf6cb13700e04c66
> git show -s --format=%an <%ae> [%ai] ee4257a5a3dacdec89633653ddc4654fcf4b4cdd
> git show -s --format=%an <%ae> [%ai] a77ea67dcd828939c252e6b36148d389902848da
> git show -s --format=%an <%ae> [%ai] 88ee204ed0da40be30ac2b8a9b4dbaeea14bcc40
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 5592d73738f9f4ce138f88ebab0d99a2e60364ec
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 34acf369deac5aef91bb231300c370e873c13954
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z ee4257a5a3dacdec89633653ddc4654fcf4b4cdd
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 265e4c9393cf6790dcd7871fcf6cb13700e04c66
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 3922eb125b04c3af31e407058bea35a40cf55f09
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z a77ea67dcd828939c252e6b36148d389902848da
> git show -s --format=%an <%ae> [%ai] c6155e104a8526c0526930b7631b216ffbc9ada5
> git show -s --format=%an <%ae> [%ai] 7e1daf019c3d1febf400e98189d6584fa36d3a3c
> git show -s --format=%an <%ae> [%ai] ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%an <%ae> [%ai] ad1ecd4c97fc3ceb80f3d81d0265c5b4295d2de9
> git show -s --format=%an <%ae> [%ai] 16db38c90e1f0a81de4f2c66680ede44181724e8
> git show -s --format=%an <%ae> [%ai] 18cbc37a3823ad95ab68668f83500d5b7a9e5f39
> git show -s --format=%an <%ae> [%ai] ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%an <%ae> [%ai] f2a46292e6b8db20b2196c0718ef6dcb7fbed4bb
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 88ee204ed0da40be30ac2b8a9b4dbaeea14bcc40
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z c6155e104a8526c0526930b7631b216ffbc9ada5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 7e1daf019c3d1febf400e98189d6584fa36d3a3c
> git show -s --format=%an <%ae> [%ai] 512dd99cdde64bd79cb83acb6f895bcb3efcf0ee
> git show -s --format=%an <%ae> [%ai] 45e0018d81e726b451aef62765accd14b70ae3ff
> git show -s --format=%an <%ae> [%ai] 5592d73738f9f4ce138f88ebab0d99a2e60364ec
> git show -s --format=%an <%ae> [%ai] ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%an <%ae> [%ai] a6d8e746030d7baf94621b01af5e81a69906ed99
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 18cbc37a3823ad95ab68668f83500d5b7a9e5f39
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 16db38c90e1f0a81de4f2c66680ede44181724e8
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z ad1ecd4c97fc3ceb80f3d81d0265c5b4295d2de9
> git show -s --format=%an <%ae> [%ai] 40a3bbfd0a6210ba794ef7936399f08d49eb4d3b
> git show -s --format=%an <%ae> [%ai] f4eddd89aed7e8af511a57db6f91493b36f47bdc
> git show -s --format=%an <%ae> [%ai] 8565722f54d34518caccf5e960ec482478830824
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z f2a46292e6b8db20b2196c0718ef6dcb7fbed4bb
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z ff983fae69b33ee752c932083cc5a3f907ea51d5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 512dd99cdde64bd79cb83acb6f895bcb3efcf0ee
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 45e0018d81e726b451aef62765accd14b70ae3ff
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z a6d8e746030d7baf94621b01af5e81a69906ed99
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 5592d73738f9f4ce138f88ebab0d99a2e60364ec
> git show -s --format=%an <%ae> [%ai] c6155e104a8526c0526930b7631b216ffbc9ada5
> git show -s --format=%an <%ae> [%ai] 7e1daf019c3d1febf400e98189d6584fa36d3a3c
> git show -s --format=%an <%ae> [%ai] 512dd99cdde64bd79cb83acb6f895bcb3efcf0ee
> git show -s --format=%an <%ae> [%ai] 45e0018d81e726b451aef62765accd14b70ae3ff
> git show -s --format=%an <%ae> [%ai]<PHONE_NUMBER>f57d303e2e6ed98b968b2f8020c6c4
> git show -s --format=%an <%ae> [%ai] 30601eb7a88d2a3be529b7d97f24491c68a6968c
> git show -s --format=%an <%ae> [%ai] 69cbf4f47dda08358aebdfd2d08c318fe420308d
> git show -s --format=%an <%ae> [%ai] 05f8378fe58eab37ff2c1ecd77ebd398af3f0ead
> git show -s --format=%an <%ae> [%ai] 193b02603757f4550ce8945cbb8102f292c5ac49
> git show -s --format=%an <%ae> [%ai] 512dd99cdde64bd79cb83acb6f895bcb3efcf0ee
> git show -s --format=%an <%ae> [%ai] 45e0018d81e726b451aef62765accd14b70ae3ff
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 8565722f54d34518caccf5e960ec482478830824
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z f4eddd89aed7e8af511a57db6f91493b36f47bdc
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 40a3bbfd0a6210ba794ef7936399f08d49eb4d3b
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z<PHONE_NUMBER>f57d303e2e6ed98b968b2f8020c6c4
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z c6155e104a8526c0526930b7631b216ffbc9ada5
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 7e1daf019c3d1febf400e98189d6584fa36d3a3c
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 193b02603757f4550ce8945cbb8102f292c5ac49
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 05f8378fe58eab37ff2c1ecd77ebd398af3f0ead
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 512dd99cdde64bd79cb83acb6f895bcb3efcf0ee
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 30601eb7a88d2a3be529b7d97f24491c68a6968c
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 45e0018d81e726b451aef62765accd14b70ae3ff
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 69cbf4f47dda08358aebdfd2d08c318fe420308d
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 512dd99cdde64bd79cb83acb6f895bcb3efcf0ee
> git show -s --format=%H%n%aN%n%aE%n%at%n%ct%n%P%n%B -z 45e0018d81e726b451aef62765accd14b70ae3ff
> git config --local branch.development.github-pr-owner-number
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/development refs/remotes/development
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/development refs/remotes/development
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
> git show --textconv :app/models/tableless.rb
> git ls-files --stage -- /Users/REDACTED/REDACTED/REDACTED-REDACTED/REDACTED/REDACTED/tableless.rb
> git check-ignore -v -z --stdin
> git cat-file -s cc19faf6f88ec03f1cab5f89654c5157ad287ea0
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/development refs/remotes/development
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
> git fetch
From github.com:REDACTED/REDACTED
 - [deleted]                 (none)     -> origin/chore/REDACTED-45
   de5579686fd..616211d02a8  development -> origin/development
> git status -z -u
> git symbolic-ref --short HEAD
> git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track) refs/heads/development refs/remotes/development
> git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname)
> git remote --verbose
> git config --get commit.template
> git config --local branch.development.github-pr-owner-number

Github authentication log
[Info  - 03:21:09.764] Reading sessions from keychain...
[Info  - 03:21:09.941] Getting sessions for all scopes...
[Info  - 03:21:09.941] Getting sessions for all scopes...
[Trace  - 03:21:09.941] Token acquired from secret storage.
[Info  - 03:21:09.941] Got stored sessions!
[Trace  - 03:21:09.941] Read the following session from the keychain with the following scopes: user:email
[Trace  - 03:21:09.941] Read the following session from the keychain with the following scopes: repo
[Trace  - 03:21:09.941] Read the following session from the keychain with the following scopes: read:user,user:email,repo
[Trace  - 03:21:09.941] Read the following session from the keychain with the following scopes: read:user,user:email
[Trace  - 03:21:09.941] Read the following session from the keychain with the following scopes: repo,workflow
[Info  - 03:21:09.943] Got 5 verified sessions.
[Info  - 03:21:09.943] Got 5 sessions for all scopes...
[Info  - 03:21:09.943] Got 5 sessions for all scopes...
[Info  - 03:21:10.458] Getting sessions for read:user,user:email,repo...
[Info  - 03:21:10.458] Got 1 sessions for read:user,repo,user:email...
[Info  - 03:21:10.465] Getting sessions for read:user,user:email,repo...
[Info  - 03:21:10.465] Got 1 sessions for read:user,repo,user:email...
[Info  - 03:21:10.720] Getting sessions for read:user,user:email...
[Info  - 03:21:10.720] Got 1 sessions for read:user,user:email...
[Info  - 03:21:11.59] Getting sessions for repo...
[Info  - 03:21:11.65] Got 1 sessions for repo...

@luong-komorebi what were you doing when you saw the error notification? What was the exact text of the error notification?

@alexr00 thanks for the prompt response. I was clicking on the github icon. My intention was to review pull requests

The exact error message is no remotes match the current setting. Not sure if it falls under this issue or I should create a new one.

@luong-komorebi this is a different issue; however, it looks like you might just need to add your remotes to githubPullRequests.remotes.

Same issue, anyone got any solutions?

Hi everyone got the same problem and solved it out,

First you have to create a personal access token (settings > developper settings > personal access token)
Then you have to update the url of your local config to put your token :

cd /path/to/your/repo
nano .git/config

then you'll have an url under the origin section (looks like this)
[remote "origin"]
	url = https://github.com/username/repo.git

here just change the url by :
[remote "origin"]
	url =<EMAIL_ADDRESS>
Then it should work :) hope it helped
NB: make sure to use https

@sylar123abc  Thanks you so much! This solved the issue :+1:

works for me without :
[remote "origin"]
url =<EMAIL_ADDRESS>

<EMAIL_ADDRESS>
Thank this was usefull solved my problem before was working fine but just random stop following this method worked.

works for me without <username> in the beginning:
[remote "origin"]
	url =<EMAIL_ADDRESS>

This works well on a repo per repo basis, but if your organisation has loads of repos it can get quite tiresome.
If you install Github CLI, run gh auth login and sign in via the browser, you should be able to access all your repos 👍

the trick worked. But what has changed? My VSC worked perfectly previously, but why suddenly we need to manually change the config file for it to work? Can we fix it at the extension/VSC level so that we don't need to update every repo config?

I installed GH CLI and still authenticated from a terminal on Windows. Restarted VS Code and tried to push and received the same error. Next I tried running GH CLI on PS & CMD terminal in VS Code and it just says gh: The term 'gh' is not recognized as a name of a cmdlet.... eventually I changed the .git/config as suggested above and that solved the error and now it works.

Version: 1.75.1 (system setup)
Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
Date: 2023-02-08T21:32:34.589Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
I am here, because after a few VS Code updates, the The GitHub repo that I cloned with VS Code and updated several times started to fail with this same error today. It has been a few months since I updated this repo. I regularly update VS Code, so I do not have the version number that worked.
I used https, not ssh. Therefore, I did not have to deal with PAT.

I cloned the repo using VS Code. Why would I need to manually change the remote origin url?
If the remote origin url was wrong to begin with, how did VS code authenticate and pull my repo in the first place?
I am able to create a pull request and an issue via the GitHub extension, so my GitHub credentials are recognized.
GitHub Desktop works. If I open side by side VS Code and GitHub Desktop, I can work in VS Code, and then manage the repo in GitHub Desktop - sub-par experience, isn't it?
I also have CoPilot, using it with the same GitHub account inside VS Code. That started to take too long to log me in and offer "another way" to log in.
Can you please fix this VS Code bug?

works for me without <username> in the beginning:
[remote "origin"]
	url =<EMAIL_ADDRESS>

This works well on a repo per repo basis, but if your organisation has loads of repos it can get quite tiresome.
If you install Github CLI, run gh auth login and sign in via the browser, you should be able to access all your repos 👍

That works for me as well. So, is GitHub CLI (gh) a requirement to use GitHub repos with VS Code now?

@durayakar GitHub CLI is not a requirement!
I would guess that your auth token has lost some permissions in the time since you last opened the repo. Could you share the output from "GitHub Pull Request". And then, can you try signing out of VS Code with your GitHub account then signing in again?

works for me without <username> in the beginning:
[remote "origin"]
	url =<EMAIL_ADDRESS>

This works well on a repo per repo basis, but if your organisation has loads of repos it can get quite tiresome.
If you install Github CLI, run gh auth login and sign in via the browser, you should be able to access all your repos +1

That works for me as well. So, is GitHub CLI (gh) a requirement to use GitHub repos with VS Code now?

thanks

@samleemc Thanks it's really helpful

same issue

just to make it clear, the config looks like this:
[remote "origin"]
url =<EMAIL_ADDRESS>

I can confirm that the trick with PAT in the config file works, but I found that the config file is world readable in Ubuntu 20.04 and WSL2. This is a issue with the PAT since it could be quite powerful and access most things in your Github repo. The solution is simple: use chmod to restrict access
chmod 0600 config
It seems to work in both VS Code as well as bash prompt.

2024 update:
install the GitHub CLI from https://cli.github.com/ , reboot, and then open VS Code.
Run this in the terminal in VS Code
gh auth login
then follow the default prompts
You should be then good to go @maruarcus

using Github cli in vscode, worked for me

Hi everyone got the same problem and solved it out,

First you have to create a personal access token (settings > developper settings > personal access token)
Then you have to update the url of your local config to put your token :

cd /path/to/your/repo
nano .git/config

then you'll have an url under the origin section (looks like this)
[remote "origin"]
	url = https://github.com/username/repo.git

here just change the url by :
[remote "origin"]
	url =<EMAIL_ADDRESS>
Then it should work :) hope it helped
NB: make sure to use https

how do i do that.

Hi everyone got the same problem and solved it out,

First you have to create a personal access token (settings > developper settings > personal access token)
Then you have to update the url of your local config to put your token :

cd /path/to/your/repo
nano .git/config

then you'll have an url under the origin section (looks like this)
[remote "origin"]
	url = https://github.com/username/repo.git

here just change the url by :
[remote "origin"]
	url =<EMAIL_ADDRESS>
Then it should work :) hope it helped
NB: make sure to use https

how do i do that. how do i make a personal access token

nevermind

Hi everyone got the same problem and solved it out,

First you have to create a personal access token (settings > developper settings > personal access token)
Then you have to update the url of your local config to put your token :

cd /path/to/your/repo
nano .git/config

then you'll have an url under the origin section (looks like this)
[remote "origin"]
	url = https://github.com/username/repo.git

here just change the url by :
[remote "origin"]
	url =<EMAIL_ADDRESS>
Then it should work :) hope it helped
NB: make sure to use https

For those still struggling despite this detailed solution, please note that if you are trying to sync a repository from an organization you own, fine-grained tokens might not work.
In my case, I solved it by creating a classic token assigning it to the organization then replacing the <username> and <personalToken> as mentioned and the last part of the link (@github.com/username/repo.git) must be the link to the repo from your organization.
I hope this helps


-r <req-file> breaks editable install

For configuration:
# pyproject.toml
[build-system]
requires = [
    "setuptools>=42",
    "wheel",
    "setuptools-declarative-requirements",
]
build-backend = "setuptools.build_meta"

[tool.setuptools.packages.find]
where = ["src"]

[tool.setuptools.package-data]
"*" = [
    "requirements.txt",
    "requirements-dev.txt",
    "src/<path>/requirements.txt",
]

; setup.cfg
[requirements-files]
install_requires = requirements.txt
tests_require = requirements-dev.txt
extras_require =
  docs = requirements-dev.txt
  dev = requirements-dev.txt
  ci = requirements-dev.txt

and
networkx

-r src/r<path>/requirements.txt

I am getting:
$ pip install -e .[dev]
Obtaining file://<proj>
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error

  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [50 lines of output]
      /tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/config/pyprojecttoml.py:108: _BetaConfiguration: Support for `[tool.setuptools]` in `pyproject.toml` is still *beta*.
        warnings.warn(msg, _BetaConfiguration)
      Traceback (most recent call last):
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/pkg_resources/_vendor/packaging/requirements.py", line 102, in __init__
          req = REQUIREMENT.parseString(requirement_string)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/pkg_resources/_vendor/pyparsing/core.py", line 1141, in parse_string
          raise exc.with_traceback(None)
      pkg_resources._vendor.pyparsing.exceptions.ParseException: Expected W:(0-9A-Za-z), found '-'  (at char 0), (line:1, col:1)

      During handling of the above exception, another exception occurred:

      Traceback (most recent call last):
        File "<proj>/.venv/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
          main()
        File "<proj>/.venv/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "<proj>/.venv/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 144, in get_requires_for_build_editable
          return hook(config_settings)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 445, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 338, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 320, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/build_meta.py", line 335, in run_setup
          exec(code, locals())
        File "<string>", line 1, in <module>
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/__init__.py", line 87, in setup
          return distutils.core.setup(**attrs)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 159, in setup
          dist.parse_config_files()
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/declarative_requirements/integration.py", line 39, in wrapper
          func(*args, **kwargs)
        File "<proj>/.venv/lib/python3.9/site-packages/_virtualenv.py", line 21, in parse_config_files
          result = old_parse_config_files(self, *args, **kwargs)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/dist.py", line 868, in parse_config_files
          pyprojecttoml.apply_configuration(self, filename, ignore_option_errors)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/config/pyprojecttoml.py", line 63, in apply_configuration
          return _apply(dist, config, filepath)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/config/_apply_pyprojecttoml.py", line 50, in apply
          dist._finalize_requires()
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/dist.py", line 577, in _finalize_requires
          self._move_install_requirements_markers()
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/setuptools/dist.py", line 617, in _move_install_requirements_markers
          inst_reqs = list(_reqs.parse(spec_inst_reqs))
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/pkg_resources/__init__.py", line 3102, in __init__
          super(Requirement, self).__init__(requirement_string)
        File "/tmp/pip-build-env-aqguga2x/overlay/lib/python3.9/site-packages/pkg_resources/_vendor/packaging/requirements.py", line 104, in __init__
          raise InvalidRequirement(
      pkg_resources.extern.packaging.requirements.InvalidRequirement: Parse error at "'-r src/r'": Expected W:(0-9A-Za-z)
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

The funny thing is, both requirements-dev.txt also has -r lines; "but those are okay" (ignored or parsed - idk)
PS: Could you provide some insight why, instead of recursively opening the -r <file> and dumping its contents, parsing -r is a problem?

... or rather, the problem might be:
# requirements.txt
networkx

-r src/r<path>/requirements.txt

and
# requirements-dev.txt
-r requirements.txt

...

i.e. recursion


Can this tool support HTTP/2 style diagrams?

In the priorities draft, we decided to use the HTTP/2 style of diagram because the text is oriented to H2 and H3 users. Using HTTP/1.1 style would be weird.
If I change our examples from example to http-message then the linter throws up these problems
Input
~~~ http-message
:method = GET
:scheme = https
:authority = example.net
:path = /menu.png
priority = u=5, i
~~~

and the origin responds with

~~~ http-message
:status = 200
content-type = image/png
priority = u=1
~~~

Output
  skipping section example
  skipping section example
  skipping section abnf
  skipping section drawing
  skipping section drawing
  draft-ietf-httpbis-priority-08.xml:582: validating request line :method = GET
  ERROR at draft-ietf-httpbis-priority-08.xml:582: Method ':method' not recognised
  ERROR at draft-ietf-httpbis-priority-08.xml:582: Request line ':method = GET' doesn't end with 'HTTP/1.1'
  ERROR at draft-ietf-httpbis-priority-08.xml:582: Non-field line 'priority = u=5, i' in content
  draft-ietf-httpbis-priority-08.xml:588: validating request line :status = 200
  ERROR at draft-ietf-httpbis-priority-08.xml:588: Method ':status' not recognised
  ERROR at draft-ietf-httpbis-priority-08.xml:588: Request line ':status = 200' doesn't end with 'HTTP/1.1'
  ERROR at draft-ietf-httpbis-priority-08.xml:588: Non-field line 'content-type = image/png' in content

It could, with an appropriate PR :)

Ack, sounds like my hackathon week has begun


Test commit for test PR

Test changes for running workflows on PR.

That appears to have worked, so this can be closed now.


v0.2.3+1.20.1 not compatible with most recent QKL

Particule Core v0.2.3 for 1.20.1 release on Apr 27 require at least 1.10.18+Kotlin 1.9.22 which is not available for mc 1.20.1

Download and use fabric language kotlin in that case. It works the exact same (QKL has no quilt specific function to my knowledge)


data path availability: any slight dip creates outage

Please provide us with the following information:

This issue is a: (mark with an x)

[X ] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
Container apps are periodically unable to reach network resources, e.g. azure cache for redis, azure sql, via private link. Failures coincide with a dip in the Data Path Availability metric on the kubernetes or kubernetes-internal load balancer. Since the load balancer is in the MC_ resource group, visibility and troubleshooting are limited. This issue occurs periodically even when all container apps in the environment are scaled to 0.
Steps to reproduce

Create a container apps environment of type Consumption Only. This issue may be present in other types but I have not tested.
Deploy a container app.
Wait for some indeterminate period of time.

Expected behavior [What you expected to happen.]
slight dips in data path availability may impact performance but should not cause the container apps to fail entirely.
Actual behavior [What actually happened.]
Any drop below 100% availability causes every container app in the environment to fail to connect to any network resource.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Ex. Did this issue occur in the CLI or the Portal?

change analysis old value.json
change analysis new value.json
change analysis shows the nsg in the MC_ resource group being applied to a vmss nic in the userpool at the time these failures occur. This is consistent. across many MANY observed failures.


[SPARK-9925] [SQL] [TESTS] Set SQLConf.SHUFFLE_PARTITIONS.key correctly for tests

https://issues.apache.org/jira/browse/SPARK-9925

Merged build triggered.

Merged build started.

Test build #40704 has started for   PR 8155 at commit a19f84f.

Merged build triggered.

Merged build started.

Test build #40707 has started for   PR 8155 at commit fd9da93.

Test build #40704 has finished for   PR 8155 at commit a19f84f.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #1526 has started for   PR 8155 at commit 8b2e4a7.

Test build #40707 has finished for   PR 8155 at commit fd9da93.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test build #1526 timed out     for PR 8155 at commit 8b2e4a7     after a configured wait of 175m.

Test build #1537 has started for   PR 8155 at commit 8b2e4a7.

Merged build triggered.

Merged build started.

Test build #40743 has started for   PR 8155 at commit d09b603.

Here's another place where this configuration is changed https://github.com/apache/spark/blob/84a27916a62980c8fcb0977c3a7fdb73c0bd5812/sql/core/src/test/scala/org/apache/spark/sql/SQLConfSuite.scala#L77

Test build #40743 timed out     for PR 8155 at commit d09b603     after a configured wait of 175m.

Merged build finished. Test FAILed.

Test build #1550 has started for   PR 8155 at commit d09b603.

Merged build triggered.

Merged build started.

Test build #40769 has started for   PR 8155 at commit c6f5abe.

Test build #1550 has finished for   PR 8155 at commit d09b603.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait Identifiable
class VectorUDT extends UserDefinedType[Vector]

Test build #1557 has started for   PR 8155 at commit c6f5abe.

Test build #40769 has finished for   PR 8155 at commit c6f5abe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #1561 has started for   PR 8155 at commit c6f5abe.

Test build #1562 has started for   PR 8155 at commit c6f5abe.

Test build #1563 has started for   PR 8155 at commit c6f5abe.

Test build #1557 timed out     for PR 8155 at commit c6f5abe     after a configured wait of 175m.

Test build #1561 timed out     for PR 8155 at commit c6f5abe     after a configured wait of 175m.

Test build #1562 timed out     for PR 8155 at commit c6f5abe     after a configured wait of 175m.

Test build #1563 has finished for   PR 8155 at commit c6f5abe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build triggered.

Merged build started.

Test build #1572 has started for   PR 8155 at commit c6f5abe.

Merged build finished. Test FAILed.

Test build #1581 has started for   PR 8155 at commit 4e548f5.

Test build #1587 has started for   PR 8155 at commit 4e548f5.

Test build #1572 timed out     for PR 8155 at commit c6f5abe     after a configured wait of 175m.

Test build #1590 has started for   PR 8155 at commit 4e548f5.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1591 has started for   PR 8155 at commit 4d6fcf8.

Test build #1581 timed out     for PR 8155 at commit 4e548f5     after a configured wait of 175m.

Test build #1587 timed out     for PR 8155 at commit 4e548f5     after a configured wait of 175m.

Test build #1592 has started for   PR 8155 at commit 4d6fcf8.

Test build #1591 has finished for   PR 8155 at commit 4d6fcf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

Test build #1590 has finished for   PR 8155 at commit 4e548f5.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #1592 has finished for   PR 8155 at commit 4d6fcf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 implicit class StringToColumn(val sc: StringContext)

cc @andrewor14 can you review this?

Discussed with @yhuai offline. The current approach will not work if the test does a conf.clear. Instead we'll override the default value in the SQLConf.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

@andrewor14 Just updated the pr. For TestSQLContext and TestHiveContext, we define a map of overrideConfs, which will be set when we construct the SQLConf as well as when we call conf.clear().

Test build #41028 has started for   PR 8155 at commit 75aeab7.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41027/
Test FAILed.

Test build #41028 has finished for   PR 8155 at commit 75aeab7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41028/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #41033 has started for   PR 8155 at commit 75aeab7.

Test build #41033 has finished for   PR 8155 at commit 75aeab7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41033/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #41041 has started for   PR 8155 at commit 75aeab7.

Merged build triggered.

Merged build started.

Test build #41044 has started for   PR 8155 at commit bc4b8e0.

Test build #41041 has finished for   PR 8155 at commit 75aeab7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41041/
Test FAILed.

Test build #41044 has finished for   PR 8155 at commit bc4b8e0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41044/
Test FAILed.

looks like there is a legitimate failure.

@yhuai do you have time to update this?

Will do it tomorrow.

Since @yhuai is busy with others, I will take over this one.

OK, sounds good

Thanks! I am closing this PR.


Supporting different schemas around getting child nodes

Problem
In #16 we converted our hardcoded { node, property, index } parent pointer structure to a more flexible { node, path[] } schema. However, we did not change our internals much to really support arbitrary paths. We still assume children are found by:

If no getChildProperties() is specified, we follow all properties on a node, and call isNode() on them to see if they are child nodes. This only goes 1-2 levels deep: values that are obtained by following one property, or array values if that one property is an array.
If getChildProperties() is specified, we follow these properties and do not call isNode(), we just filter by existence.

Currently, this assumes a specific structure that may be overfit to Treecle’s AST beginnings.
I suspect in the wild there are two common ways to represent tree data structures:

Follow specific properties that always point to children (the AST case)
Follow a property that always points to children (children for Mavo Nodes, childNodes for DOM Nodes)

Currently, the API only supports providing a function that takes a node and returns a list of properties. As an example, this is how this setting is specified in vastly:
export const properties = {
	CallExpression: ["arguments", "callee"],
	BinaryExpression: ["left", "right"],
	UnaryExpression: ["argument"],
	ArrayExpression: ["elements"],
	ConditionalExpression: ["test", "consequent", "alternate"],
	MemberExpression: ["object", "property"],
	Compound: ["body"],
};

defaults.getChildProperties = (node) => {
	return properties[node.type] ?? [];
};

This appears to be overfit to 1. Yet, I suspect 2 may even be more common.
How do we allow both to be specified without making either more complicated due to the existence of the other?
Ideas
getChildProperties() to getChildPaths(), handle both string[][] and string[]?
We don't want to complicate 1 to cater to 2, but what if we could do both? If the function returns an array of strings, they are single properties. If it returns an array of arrays, they are paths.
The problem is, we don’t necessarily have specific child properties in 2, often once you get from the node to its children, everything in that data structure is a child.
Wildcards? JSON Paths?
Basically, we want a way to say children/* for these cases. What if we handle / and * in properties specially?
But then we’re basically creating a path microsyntax, and restricting the potential syntax of actual real properties accordingly.
OTOH, that's basically JSON Path syntax, which is quite well established.
The advantage of something like this is that we can still handle properties like Vastly’s in exactly the same way.

Not a huge fan of any of these ideas, so I’ll continue brainstorming.

Could also be a variant of option 1 where we accept a generic flattened array, e.g. ["left", "right"], or a nested array, e.g. [["children", "key1"], ["children", "key2"]], or we could also allow the wildcard key to signal check all properties in this object, for example, [["children", "*"]] would mean all subproperties of children are children

Could also be a variant of option 1 where we accept a generic flattened array, e.g. ["left", "right"], or a nested array, e.g. [["children", "key1"], ["children", "key2"]], or we could also allow the wildcard key to signal check all properties in this object, for example, [["children", "*"]] would mean all subproperties of children are children

Yeah, the more I think about it, the more I like this idea.
For convenience, we should also support arrays as the value, not just functions.
E.g. the Mavo.Node use case would be:
childPaths: [["children", "*"]]

the DOM Node use case would be:
childPaths: [["childNodes", "*"]]

While having a nested array with a single element is a bit unwieldy, it's very explicit, and in most cases there's only one.

Btw I think the function that applies such a path to an object and returns the result is really useful and we should expose it as one of our helpers rather than having it as an internal util.

Btw I think the function that applies such a path to an object and returns the result is really useful and we should expose it as one of our helpers rather than having it as an internal util.

Yeah I was planning on adding that along with a find path function


ENABLE_UTC config

I am very interested in this project and have tried it out.
there is no configuration for django "USE_TZ". I have tried to improve this by adding the "ENABLE_UTC" configuration.

The expires_at is set with utc here. The value taken for comparison from model at here is also utc. I think Django in this it is storing utc and comparing with utc. So it should be ok even with a tz set other than utc.  No need to change in my opinion.

@chen866 as mentioned it does not change with time zone on the test and in an application using this package.  Closing this pr.

ok. I'm very sorry for forgetting to reply.


Install extlibs on iOS if needed

Audio extlibs specifically.
I also removed a seemingly superfluous check for SFML_OS_IOS as it's already in a block which checks that

CMakeLists.txt was changed, thus it created a conflict. Would be great if you could resolve it.

Merged in 66369645b545d5ace07b7d58b65ca97b3f43a740


Loading large T5 Models > 2GB efficiently

I have a model I've converted to onnx format that is > 2GB. This results in a number of model.onnx files. I'm grappling the an efficient approach to loading the model.
For other models I will:
pub static ENCODER_MODEL: Lazy<Vec<u8>> = Lazy::new(|| {
    let model_path = PathBuf::from(&*GLOBAL_AI_INCLUDE_ROOT).join("encoder/model/model.onnx");
    let mut file = File::open(model_path).unwrap();
    let mut buffer = Vec::new();
    file.read_to_end(&mut buffer).unwrap();
    buffer
});

and then do something like:
pub struct SentenceEncoder<'s> {
    session: InMemorySession<'s>,
}

impl SentenceEncoder<'_> {
    pub fn new() -> SystemSyncResult<Self> {
        let session = SessionBuilder::new(&ENVIRONMENT)?
            .with_optimization_level(GraphOptimizationLevel::Level1)?
            .with_model_from_memory(&*ENCODER_MODEL)?;

        Ok(Self { session })
    }

    //more code....

}

I then have a dedicated threadpool that loads a specified number of threads and reuses the sessions across calls to ensure we can run inference in parallel. Callers can issue calls over a crossbeam channel to a watcher that prioritizes the incoming calls and dispatches them to a processing thread. The thread pics it up and based on the inference request type elects the appropriate session to run.
With most models the above strategy works great, and all session share the ENCODER_MODEL memory. This  particular T5 model(it's a t5-large grammar synthesis pretrained model), when I convert it to onnx format, I end up with a bunch of files(model.onnx, onnx__MatMul_XXXXm shared.weights) due to Googles Protocol Buffers serialization format and size limitations. So the actual model.onnx file is very small and the rest of the model contents are located in the rest of the files.
Is there a way I can pass the model into ort from memory similar to how I'm doing with other models? Additionally, is there something I'm overlooking here(I'm new to using this crate)? Does the Microsoft runtime efficiently share the model representation in memory internally for sessions loaded with the same model file, so multiple calls to with_model_from_file() won't result in unnecessary memory allocation? Am I misunderstanding something here?
Any help on this would be appreciated. Admittedly I haven't finished the implementation of this T5 model in rust yet, so I'm a bit preemptive in my questions.
Thanks again for the work on this crate!

Is there a way I can pass the model into ort from memory similar to how I'm doing with other models?

Not that I'm aware of with models using the external data format. External data referenced in ONNX graphs can only point to a file.

Does the Microsoft runtime efficiently share the model representation in memory internally for sessions ran against the same model file, so multiple calls to with_model_from_file() won't result in unnecessary memory allocation?

No, each call will re-load the entire model and its (external) weights.

Thanks for the quick reply, that's a bummer and seems like an area of improvement for the onnxruntime. In any case, I'll have to handle that particular model differently than.
Have a wonderful evening.


Missing samples in the dumbbell plots for timepoints

What analysis module should be updated and why?
This is related to PR https://github.com/d3b-center/pbta-tumor-evolution/pull/26
What changes need to be made? Please provide enough detail for another participant to make the update.
Some time points are not showing in the dumbbell plots, even though there are values in there (as shown in stacked barplots and barplots for each sample). This issue was also coming up when trying side-by-side barplots. It couldn't resolve for log2(n) either. We can either drop this type of plot and/or try heatmaps.
What input data should be used? Which data were used in the version being updated?
When do you expect the revised analysis will be completed?
Who will complete the updated analysis?

This issue seemed to be linked to cases showing multiple diagnoses, i.e., different diagnosis in each timepoint. This has be solved by identifying those cases and summarizing them. See a8246437ad03dc4e98e99185c31d1d9c7d187572 and fb911aeb6bdad1ec25325ac81c45d8cc9ee28acb. So, I will go ahead and close this. @jharenza

This issue seemed to be linked to cases showing multiple diagnoses, i.e., different diagnosis in each timepoint. This has be solved by identifying those cases and summarizing them. See https://github.com/d3b-center/pbta-tumor-evolution/commit/a8246437ad03dc4e98e99185c31d1d9c7d187572 and https://github.com/d3b-center/pbta-tumor-evolution/commit/fb911aeb6bdad1ec25325ac81c45d8cc9ee28acb. So, I will go ahead and close this. @jharenza


feat: need to add download button for received pictures (Issue #124)

Issue: https://github.com/epam/ai-dial-chat/issues/124

/deploy-review

/deploy-review


Add optional "bbox" member to feature and geometries

The GeoJSON spec defines an optional  bbox property that can be present in any GeoJSON object (both geometries and feature).
This is sometimes very useful, e.g. geojson-vt internal representation calculates bboxes to speed up clipping. I think we should add it to geometry.hpp too.
cc @artemp @jfirebaugh

@mourner - Cool, I was planning to add this issue as well :) My angle not so much GeoJSON but more generally boiler-plate code sharing across projects.  Pretty much every project concerned with some geometries has custom bounding_box implementation + operations.
Here is tested approach as a starting point : https://github.com/mapnik/mapnik/blob/master/include/mapnik/box2d.hpp
/cc @jfirebaugh @springmeyer

Related: #25.


Supported browsers?

I'm interested in this lightweight framework, but I found soon the website and the documentation site are completely broken for me.

I think this is caused because I'm using the browser that is a little old (due to the EOL OS version).
Compatibility is the important thing for production environment, so now my question is which browsers and versions are (or will be support in future)supported by camome-ui?

Not yet decided what exact versions and browsers to support, but I don't think Camome will support versions older than the current latest releases.

ok thanks for your fast reply.


Auto-migrating null panic - can't retrieve sql.Columns when table is empty.

GORM Playground Link
https://github.com/go-gorm/playground/pull/1
Description
Context/Pre-investigation
When creating a new table, clickhouse fills in a few system columns.
The field of importance is character_octet_length

(Nullable(UInt64)) — Maximum length in bytes for binary data, character data, or text data and images. In ClickHouse makes sense only for FixedString data type. Otherwise, the NULL value is returned.

Now, in most cases, when not using fixed strings and having DontSupportColumnPrecision  in the dialector set to the default (false), all my columns should have NULL set in the system table.
Now, when migrating to this table, some issues arise. In go-gorm/clickhouse/migrator.go, there is a check to see if the scanned lengthValue (character_octet_length) is nil. Because of the previously stated conditions, it will be nil, as a result this field, lengthValue, will remain zero and invalid.
this causes issues down the line in gorm/migrator/migrator.go when calling AutoMigrate, which calls MigrateColumn. In this function, there is a check on the columns length value, which is the same as the aforementioned clickhouse system's chatacter_octet_length field (recall this is nil for every field in this case). This calls a check in gorm/migrator/column_type.go, which because LengthValue is invalid, the function will return ct.SQLColumnType.Length(). This calls go/sql.go which will have null pointer panic. This brings me to my next issue.
The Issue
Throughout the entire flow above, SQLColumnType in ColumnType is null. This is what causes the null pointer panic in sql.go. This value is set in go-gorm/clickhouse/migrator.go, in a for loop where the variable rawColumnTypes is iterated through. unfortunately, while stepping through this, it seems that rawColumnTypes is always empty, meaning that the contents in this for loop, which sets SQLColumnType, is never reached (resulting in the null panic).
It seems that this query
rows, err := m.DB.Session(&gorm.Session{}).Table(stmt.Table).Limit(1).Rows() in go-gorm/clickhouse/migrator.go returns a *sql.Rows type that has no columns. This affects the following query for the row's columns where an empty array is returned instead of the row's queries - resulting in the behavior mentioned above.
My table is empty, but exists. I am connecting to clickhouse through port 8443 (not the native port) due to hosting constraints. Is this the intended behavior? Are there any workarounds?
some related issues:

someone with the same issue
pgx/pgconn empty columns

fixed by using native tcp port, potential workaround if stuck with http is to use DB().Query here.


jspm bundle and jspm build doesn't seem to work when I use this plugin.

Whenever I used this plugin to import sass text from into a typescript file like so
import styleText from './app.component.scss!';

jspm build just gives me empty output and doesn't generate a .js file. If I comment out the import, the build works fine.

Strange, i have a working demo using it that is using JSPM build. If you have some same work i would be happy to see if i can spot the difference for you.
Looking into it, I was able to replicate the error you experienced if i created some invalid scss, which does make me thing i need better error reporting in the very least.  Does it convert okay in this online checker? http://www.sassmeister.com/

I've patched the plugin so you can install it again
jspm install scss -f
Its a quick output but i've not worked out how to get that to throw the error during the build/bundle phase. However at runtime, you should see errors from the plugin if there are any in your scss code.
Let me know how you get on.

So i've hot-fixed onto v0.2.5 a solution i'm happy enough with for now.
What you were seeing (as best i can tell)
A silent 'failed bundle' , the process was dying somewhere inside jspm's builder during the 'translate' hook. During a normal runtime test, this was ok, the promises rejection bubbled up to the console on the browser. However on bundle and build (within the terminal) it did not (i don't have an answer to why on that one).
So what does it do now
Sass errors are pushed to the terminal and browser console in a similar way. You will no longer think its worked when it has not.
I'm going away for a week, i won't be able to respond after tomorrow evening. Hopefully this helps you.

Oops wrong button - apologies, won't close until you've found your issue.

The update prints out the error.
     Creating the single-file build for glotpod-web...
 [plugin-scss]  Stacklite :: github:KevCJones/plugin-scss/sass-inject-build.js -> npm:sass.js
 [plugin-scss]  Error: File to import not found or unreadable: jspm:styles/palette
       Parent style sheet: stdin
        on line 1 of stdin
>> @import 'jspm:styles/palette';
   ^

I was using the import syntax described in #1 to import one of my own scss files:
@import 'jspm:styles/palette';

I also have this set in my jspm.browser.js:
SystemJS.config({
  paths: {
    "github:*": "/jspm_packages/github/*",
    "npm:*": "/jspm_packages/npm/*",
    "styles*": "src/styles*",
  }
});

This appears to work in the browser, as angular loads the styles for the component just fine. I have no idea how jspm works internally, but the name of the config file hints that it probably doesn't get loaded at build/bundle time so that's probably my problem right there.
Thanks for your help!

Its hard to say from that snippet, but i can suggest a couple of things, and assure you it works for me. So i think that its possible a base folder thing but the fact it works ok for your runtime but not for your build.
I'll describe the touch points JSPM/SystemJS. Firstly i prefer NOT to run my server from the root folder so you will have to adjust the below to match your needs.
inside my package.json
...
"jspm": {
    "directories": {
      "baseURL": "www"
    },

inside my config.js
paths: {
    "npm:*": "jspm_packages/npm/*",
    "github:*": "jspm_packages/github/*",
    "styles*": "src/styles*"
  },

In fact looking at yours i can see you have a leading slash (indicating root path) for the defaults but have opted for a relative path for the styles path. I imagine this is where you might be having issues, perhaps between those two things you  have enough to see the issue?
One test might be to remove the jspm:styles and try an explicit relative path first. If you get the working you'll see what configuration you need to convert the path of styles correctly.
Cheers and thanks for the issue, it spurned an addition thats already improved my own usage.


MINIFICPP-2411 Extend NiFi Python API to support source processors

https://issues.apache.org/jira/browse/MINIFICPP-2411

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

LGTM. Is the same API supported by NiFi 2?

Yes, this implements the same FlowFileSource API as NiFi 2

We need to copy the new processorbase.py and flowfilesource.py files into the Windows installer in WixWin.wsi.in, as well.

Good catch, added the files to WiX in 6d44c1f9e36be7b05e48b878eb5c1a53f8f004af


release-19.2: IMPORT CSV option fixes

PR: https://github.com/cockroachdb/cockroach/pull/41656
From release notes:

Added new skip and nullif options for IMPORT ... DELIMITED DATA, which ignore the specified number of lines at the beginning of the file and force all empty string fields to be inserted as NULL in the imported table, respectively. [#41656][#41656] {% comment %}doc{% endcomment %}

@lhirata, hope it's ok to pass this to you? I didn't get it done.


Websocket origin is not allowed behind apache reverse proxy

I'm trying rancher 2 and my setup contains apache reverse ssl proxy.
I can log in, but wss connection gives me 403 in a browser and next lines in container log:
019/03/12 04:05:38 [ERROR] Error during subscribe websocket: origin not allowed
2019/03/12 04:05:38 [ERROR] Unknown error: websocket: origin not allowed

My startup command:
 docker run -d --restart=unless-stopped -v /opt/rancher:/var/lib/rancher
 \ -p <IP_ADDRESS>:8880:80 -p <IP_ADDRESS>:8843:443 --name rancher rancher/rancher:stable

Apache config:
<IfModule mod_ssl.c>
<VirtualHost *:443>
    ServerName rancher.DOMAIN.XXX
    ServerAdmin<EMAIL_ADDRESS>    ErrorLog ${APACHE_LOG_DIR}/error.log
    CustomLog ${APACHE_LOG_DIR}/access.log combined

    ProxyRequests Off

    SSLProxyEngine on
    SSLProxyVerify none
    SSLProxyCheckPeerCN off
    SSLProxyCheckPeerName off
    SSLProxyCheckPeerExpire off

    <Proxy *>
            Order deny,allow
            Allow from all
    </Proxy>

    RewriteEngine On
    RewriteCond %{HTTP:Connection} Upgrade [NC]
    RewriteCond %{HTTP:Upgrade} websocket [NC]
    RewriteRule /(.*) wss://<IP_ADDRESS>:8843/$1 [P,L]
    RequestHeader set X-Forwarded-Proto "https"
    RequestHeader set X-Forwarded-Port "443"

    ProxyPass / https://<IP_ADDRESS>:8843/
    ProxyPassReverse / https://<IP_ADDRESS>:8843/

    <Location />
            Order allow,deny
            Allow from all
    </Location>

    SSLCertificateFile /etc/letsencrypt/live/rancher.DOMAIN.XXX/fullchain.pem
    SSLCertificateKeyFile /etc/letsencrypt/live/rancher.DOMAIN.XXX/privkey.pem
    Include /etc/letsencrypt/options-ssl-apache.conf
 </VirtualHost>
</IfModule>

I can successfully login via https://rancher.DOMAIN.XXX but websocket connection from browser fails.
P.S.: Apache enabled modues:
access_compat alias auth_basic authn_core authn_file authz_core authz_host authz_user autoindex
deflate dir env filter headers mime mpm_event negotiation proxy proxy_http proxy_wstunnel
reqtimeout rewrite setenvif socache_shmcb ssl status

Useful
Info

Versions
Rancher v2.1.7 UI: v2.1.21  Docker-ce: 18.09.3, Ubuntu: 18.04

My fault. Fixed by adding ProxyPreserveHost On to virtualhost.

My fault. Fixed by adding ProxyPreserveHost On to virtualhost.

yes, exactly! It's also solved my issue! Thank you! 💯


move return-from-block machinery into the VM itself

Motivation

Investigation into #4502 revealed that GCC 9.3.0 on Ubuntu Focal sets -fcf-protection by default.  This setting changes the values that get stored in the jmpbuf data structure (there's no actual typedef for this, it's just a array of 5 void* pointers) used by __builtin_{set,long}jmp.  Without that flag, GCC would store {%rbp, %rip, %rsp} into the jmpbuf.  With the flag, GCC stores {%rbp, %rip, %ssp, %rsp}, where %ssp is the shadow stack pointer used by Intel's Control-flow Enforcement Technology.
You may notice that the two different jmpbuf layouts are different depending on the value of -fcf-protection.  You might think that this would be a problem, and you would be right.  What is less obvious, but still equally a problem, is that clang, while compatible with GCC's default layout of jmpbuf when -fcf-protection is turned off (for both compilers), is incompatible with GCC's layout when -fcf-protection is turned on for GCC, regardless of how you compile things with clang.  That is:

GCC (no flag) + clang (no flag): interoperates
GCC (no flag) + clang (flag): does not interoperate (listed only for completeness here)
GCC (flag) + clang (no flag): does not interoperate
GCC (flag) + clang (flag): does not interoperate

(clang will store {%rbp, %rip, %rsp, %ssp} with -fcf-protection; note that the positions of %rsp and %ssp differ between GCC and clang.  You can check out https://gcc.godbolt.org/z/89cvGYYM7 for a live demo of this.)
Which means that if you have a Ruby compiled with GCC using -fcf-protection, a clang-compiled caller that uses (clang's) __builtin_setjmp (note that it doesn't matter what compiler settings clang uses), and code that eventually wants to execute, inside Ruby, (gcc's) __builtin_longjmp on a buffer filled by clang's __builtin_setjmp, you're gonna have a bad time.
All of this means that, for the Sorbet compiler, all uses of __builtin_setjmp and __builtin_longjmp should be confined inside the Ruby VM itself so that they are consistently built with the same compiler and interoperability concerns go away.  Which implies that the return-from-block implementation needs to live inside the VM.  (There are alternatives involving gnarly uses of inline asm and bazel build flags, but we're opting not to go down that pathway right now.  Maybe later.)
That was the motivation behind e98b8c9: instead of recognizing that we have a return X statement inside a block and inserting some machinery to catch a thrown TAG_RETURN in the function itself, what we can do instead is codegen as normal (including the thrown TAG_RETURN).  But once the function is complete, we need to check whether there was a return X statement inside a block somewhere inside the function.  If so, we clone our codegenned function, clear out the original function, and make our original function call into a wrapper function in the VM.  This wrapper function receives the cloned function (which actually implements all the logic of the original Ruby method), and handles setting up the appropriate tag machinery to catch a TAG_RETURN destined for our frame before calling the cloned function.
That approach worked much better than expected, except for one wrinkle: we had a test that checked that returned values from blocks were typechecked with the return type of the method.  This checking had gone away with the approach above, because we had expected values to be typechecked at the point of catching the TAG_RETURN while still inside the function, instead of at the actual return X in the block.  Now there was no catch of the TAG_RETURN inside the function: the catch of the TAG_RETURN had been moved into the runtime, where there couldn't be a typecheck.
Discussion indicated that we could plausibly move the typecheck to the point of the return X (i.e. the point at which we called sorbet_throwReturn).  So, to fix one test, there are another ten commits or so on top of a single patch.  Classic.
To move that typecheck, we decided that we need to refactor some things.
de08864 through 548a5ba could plausibly have been split out into their own PR, but they make a lot more sense in the context of this PR, I think.  Part of the strategy for implementing return-from-block was:

generate a boolean flag for every block, initialized to false
for return X inside a block, we'd set that flag to true for that particular block before codegen'ing the actual "return this value"
the machinery handling codegen'ing the actual "return this value" at the LLVM level would consult that (runtime!) variable to determine whether to call sorbet_throwReturn or emit an LLVM ret instruction.

This setup is more complicated than it needs to be, because we will only ever set the boolean flag to true when we're returning from a block, which we know we're doing statically.  So we might as well, for an explicit return X from a block, statically generate sorbet_throwReturn (d690194 and f6a9437), which means that we can delete all the boolean flag bits (548a5ba).
Once we have that, making sure that we do the typechecking at the point of return rather than at the point of catching TAG_RETURN is relatively simple: we need to split out a function to do the actual typechecking, if necessary, of the return value (8f26c75), move it to a place that it's visible from the function we're calling to generate return-from-block (b0dc064), and then actually call that function prior to throw (c14f65a).
I also belatedly realized that we no longer need a bunch of state in IREmitterContext for return-from-block: we can just have a simple boolean flag indicating that said construct is present (27eea8b).
Test plan

See included automated tests.

Possible wrinkle:
# frozen_string_literal: true
# typed: true
# compiled: true

extend T::Sig

class A
  extend T::Sig

  attr_reader :proc

  def initialize(p)
    @proc = p
  end
end

sig {returns A}
def a
  A.new(lambda {return T.unsafe(5)})
end

sig {params(a: A).returns(Integer)}
def b(a)
  a.proc.call
end

p b(a())

works before this change and fails after, because the return value of the lambda is type-checked against A, rather than waiting until its point of call to be type-checked as an Integer.  This doesn't seem like an unreasonable use-case. :(
Perhaps we could pass a small validation function into sorbet_vm_return_from_block wrapper for checking the type of any thrown values, and then just throw unchecked values.

Perhaps we could pass a small validation function into sorbet_vm_return_from_block wrapper for checking the type of any thrown values, and then just throw unchecked values.

A better solution was implemented in 57d9d23: we can know on the way out of the function whether our return value is coming from return-from-block and typecheck the value there.  This is a minor amount of code bloat, but I don't expect that return from block is super common.  I also added the testcase from the comment above and an explicit testcase for return-from-block with a function returning void.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_K5qfxaOLAbywne
→ https://go/builds/bui_K5qfjgx0Gb8OGd


Revert keyboard shortcuts in toolbar

Why
We introduced a regression with pulling Tools and out of substance core, keyboard shortcuts are no longer shown in toolbar.
What
This PR is an attempt to bring back keyboard shortcuts in toolbar labels. To do it I did introduce a method getKeyboardShortcutsByCommandName in configurator.

Codecov Report

Merging #717 into master will increase coverage by 0.02%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   66.56%   66.58%   +0.02%
==========================================
  Files         280      280
  Lines        7198     7218      +20
==========================================
+ Hits         4791     4806      +15
- Misses       2407     2412       +5

Impacted Files
Coverage Δ

src/kit/ui/MenuItem.js
91.3% <100%> (+1.3%)
:arrow_up:

src/kit/ui/ToggleTool.js
84% <100%> (+5.73%)
:arrow_up:

src/article/ArticleConfigurator.js
76.31% <60%> (-10.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da5d3c...269c1f5. Read the comment docs.


feat: add ability to sort by created_at date as an additional option to the default orderBy('updated_at','desc').

If you want to go back to update a card with tags, text, or even the link, the default sort is by updated_at time.
This is quickly growing confusing as we have more important updates to show but older cards are coming up and appearing as newer because they only highlight the last update time.
I will create a PR for this, but I want to allow the users the option to select which filter they want with 2 current options, updated_at and created_at.
Additionally, the subtitles of the cards when displayed should show information based on this filter. Currently, it should last update time from the current time, but if you selected created_at it will show the time since it was created.
Where it is currently set to sort by
Where card subtitle is set

I can go ahead and create a PR for this over the next week or so!


Add support for arrow keys and more

This pull request slightly changes the UI behavior and the API, but I still wanted to share it:

Show suggestion as soon as any character is entered, not waiting for an "@" sign and the first character of the domain
Use up and down arrows (cursor keys) to browse through all matches
Don't autocomplete on focus leave, only on tab, right arrow, click
Only handle right arrow as autocomplete at end of input. This enables users to edit the text left of the "@" character without accidentally triggering autocomplete
Allow user to replace the list of domains, not just extend it (API change)

@fjl5 Thanks for your input, I'll have a look :)


504 gateway timeout is not a timeout

let response = gen_504_response();
let response = response.error_for_status().map_err(|e| e.is_timeout())
assert_eq!(response, Result::Err(true));

this currently panics, i would expect a gateway timeout to be a timeout.

Hm, that's an interesting idea. I'd never thought about it. So far, is_timeout() means one of the ClientBuilder::*_timeout() options was the cause of the failure.

then maybe it should be renamed to is_client_timeout, and/or the conversion of status to error should be removed? maybe thats too drastic.
one semi-related thing: its a bit of a footgun that requests return Response instead of some kind of Result, or at least (status, response). makes it very easy to accidentally ignore errors, or rather the api does not guide you through the semantics like it usually does in rust.


Question about what is sent to to openai endpoint?

Hello @RobinPicard, question about the promptMessage sent in the request to openai:

I do not see in the code any indication that the table schema information is sent to openai. So how does openai know what columns are available to include in the query? To me it seems that the only way openai will include a property in the response query is if it was specified in the initial query, otherwise it will be unaware of the other columns. Is this correct?

Thank you, you've done wonderful work here.

Hi @porteron!

Hi @porteron!
Yes, this is correct. I initially thought it's not really an issue because my use case was to help some colleagues (mainly PMs and ops people) who know the data schema and know some SQL (so they write their own queries) but are sometimes blocked when trying to do something a bit more advanced. In that case, they would typically already have a query that does something related but a little tweak was missing.
Later I realized that I would need to provide this schema information to Openai to broaden the use of this extension but I could not figure out how to do it. My problem is that the end users do not have the required permissions to query the pg_ tables of their db so I don't know where I would find the schema information. Maybe there's a solution I'm missing though. Do you have an idea of how we could get the schema information?

Without access to the pg_ tables I do not think there is a way. I guess you could have them do a select * from <table> limit 1 then have them copy that into prompt that is included in the postMessage. Probably will also need to update the prompt in the code to explain what that indicates. I'm fortunate enough to have access to the schema info so I can probably do something similar by copy/pasting the schema info.

Hi @porteron. I thought more about it and actually it's possible as the Metabase frontend does have access to this information to fill out the "learn about your data" panel. By doing api requests similar to those that happen when clicking on the little icons on the right of the screen we get the all the information we need. I used sentence embeddings afterward to try to include relevant context info regarding the database in the prompt sent to chatgpt. I'm really not an expert in AI topics though. Tell me what you think about it if you have some time to take a look!
I've created a draft PR with what I've been trying out: https://github.com/RobinPicard/metabase-chatgpt/pull/9
My first tests with the db Metabase provides have been quite encouraging:
https://github.com/RobinPicard/metabase-chatgpt/assets/83579270/3d2beab1-1f3d-474d-a2c0-b9c136852384

I finished writing the PR mentioned for this new feature. The result looks pretty nice imo:
https://github.com/RobinPicard/metabase-chatgpt/assets/83579270/b929b397-d27c-4cc6-9fd2-2c95040313f3
Would you mind testing it on Metabase Cloud if you have access to it @porteron? I changed job since I first worked on the extension so now I can only run Metabase locally. I would just like that to make sure that the requests to the Metabase API go through

Looks great, you added a lot of code in PR #9. I need to review it further before I can run against my instance of Metabase.
The new prompts you added look better too. The results in your video are great!

Thanks a lot for taking the time to look at it! I think there are still 3 issues (although maybe they can be dealt with in a further PR if at all):

retrieving data about the database structure through API calls can take a long time as it's one request per table
the creation of the embeddings makes the browser laggy (but at least it's not frozen thanks to doing it in batch)
including context about only 3 tables is not enough for databases with many tables + we may reach maximum token limits if there are tables with a very high number of columns with descriptions (maybe we could have the number of tables included in the context depend on the character length of the sentences describing each of them?)

I merged the PR as I got the chance to test it on a larger database and everything went alright. Thanks again for the suggestion


Fix VersionSpec to make versions optional

VersionSpec is used to control which Turbonomic instance versions the library is allowed to interact with.  "versions" specifies which versions are required and throws an error if the version is different.  "required" specifies whether or not a check for versions should be made.  This PR response an issue where "required" is set to False but vmtconnect throws a invalid format error because versions was not specified.  Since the versions are irrelevant when "required" is False, this is a bug and versions should be optional.

Will move to release branch.


404 Error during installation

Hello,
The script is running into a 404 error. The script is trying to download https://github.com/thesofproject/avs-topology-xml/releases/download/v2024.02/avs-topology_2024.02.tar.gz which does not exist anymore. Therefore the script fails.

Same problem here. They either deleted the files or moved them.

Installing topology
Traceback (most recent call last):
File "/home/apo/chromebook-linux-audio/./setup-audio", line 319, in
match_platform(board)
File "/home/apo/chromebook-linux-audio/./setup-audio", line 95, in match_platform
avs_audio()
File "/home/apo/chromebook-linux-audio/./setup-audio", line 151, in avs_audio
urlretrieve(url=avs_tplg_url, filename="/tmp/avs_tplg/avs-tplg.tar.gz")
File "/usr/lib/python3.11/urllib/request.py", line 241, in urlretrieve
with contextlib.closing(urlopen(url, data)) as fp:
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 216, in urlopen
return opener.open(url, data, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 525, in open
response = meth(req, response)
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 634, in http_response
response = self.parent.error(
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 563, in error
return self._call_chain(*args)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 496, in _call_chain
result = func(*args)
^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 643, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

I have the same issue as above, on Fedora 40.

Hopefully the original "built" avs-topology_2024.02.tar.gz gets re-uploaded, but I got mine working the hard way...
you need to build avstplg to build avs-topology, and avstplg is from avsdk
download avsdk:
git clone https://github.com/thesofproject/avsdk.git
cd avstplg
make
#if you have problems building it, you likely need to install dotnet sdk
#sudo apt install dotnet-sdk-6.0 dotnet-host dotnet-hostfxt-6.0
build avs-topology (tag: v2024.02) using avstplg:
git clone --branch v2024.02 https://github.com/thesofproject/avs-topology-xml.git
run make pointing to where avstplg binary is
PATH=$PATH:$HOME/avsdk/avstplg/build/bin/Debug/net6.0/publish make
to create the lib and final release tar.gz
make dist
install avs-topology.tar.gz to dir for setup-audio script:
sudo mkdir -p /tmp/avs_tplg
sudo tar -xvf avs-topology.tar.gz -C /tmp/avs_tplg/
#modify setup-audio to avoid downloading/installing missing file:
vi setup-audio
comment out lines 152 and 153 (urlretrieve and tar xv)
run setup-audio
sudo ./setup-audio

As a workaround* (not involving building the topology files from source) you can try manually installing topology files from linux-firmware repository, as the binaries were recently moved there: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/intel/avs

you would still need to comment out this part of the script: https://github.com/WeirdTreeThing/chromebook-linux-audio/blob/main/setup-audio#L151-L154

Hopefully the original "built" avs-topology_2024.02.tar.gz gets re-uploaded, but I got mine working the hard way...
you need to build avstplg to build avs-topology, and avstplg is from avsdk
download avsdk: git clone https://github.com/thesofproject/avsdk.git cd avstplg make if you have problems building it, you likely need to install dotnet sdk sudo apt install dotnet-sdk-6.0 dotnet-host dotnet-hostfxt-6.0
build avs-topology (tag: v2024.02) using avstplg: git clone --branch v2024.02 https://github.com/thesofproject/avs-topology-xml.git run make pointing to where avstplg binary is PATH=$PATH:$HOME/avsdk/avstplg/build/bin/Debug/net6.0/publish make to create the lib and final release tar.gz make dist
install avs-topology.tar.gz to dir for setup-audio script: sudo mkdir -p /tmp/avs_tplg sudo tar -xvf avs-topology.tar.gz -C /tmp/avs_tplg/
modify setup-audio to avoid downloading/installing missing file: vi setup-audio comment out lines 152 and 153 (urlretrieve and tar xv) run setup-audio sudo ./setup-audio

Many thanks for this explanation. I got my audio working.

Hopefully the original "built" avs-topology_2024.02.tar.gz gets re-uploaded, but I got mine working the hard way...
you need to build avstplg to build avs-topology, and avstplg is from avsdk
download avsdk: git clone https://github.com/thesofproject/avsdk.git cd avstplg make if you have problems building it, you likely need to install dotnet sdk sudo apt install dotnet-sdk-6.0 dotnet-host dotnet-hostfxt-6.0
build avs-topology (tag: v2024.02) using avstplg: git clone --branch v2024.02 https://github.com/thesofproject/avs-topology-xml.git run make pointing to where avstplg binary is PATH=$PATH:$HOME/avsdk/avstplg/build/bin/Debug/net6.0/publish make to create the lib and final release tar.gz make dist
install avs-topology.tar.gz to dir for setup-audio script: sudo mkdir -p /tmp/avs_tplg sudo tar -xvf avs-topology.tar.gz -C /tmp/avs_tplg/
modify setup-audio to avoid downloading/installing missing file: vi setup-audio comment out lines 152 and 153 (urlretrieve and tar xv) run setup-audio sudo ./setup-audio

I'm having trouble getting this working. When I get to

run make pointing to where avstplg binary is `PATH=$PATH:$HOME/avsdk/avstplg/build/bin/Debug/net6.0/publish

I encounter the following
`You must install or update .NET to run this application.
App: /home/user/avsdk/avstplg/build/bin/Debug/net6.0/publish/avstplg
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: /usr/lib/dotnet
The following frameworks were found:
8.0.8 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&arch=x64&rid=ubuntu.24.04-x64&os=linuxmint.22
`
But the package for dotnet-runtime-6.0 is no longer available.

The AVS firmware is now shipping with Fedora 40. Update your system to get the latest kernel  (sudo dnf update). Then comment out lines 151 through 154 in the audio script, and then run the script. It should install without issues.

Same for me on OpenSUSE tumbleweed (after system update): I only had to comment lines 151-154 and the AVS firmware was already available.

The AVS firmware is now shipping with Fedora 40. Update your system to get the latest kernel (sudo dnf update). Then comment out lines 151 through 154 in the audio script, and then run the script. It should install without issues.

Thank you > therealkuking   -Worked perfectly on Fedora 40.

The AVS firmware is now shipping with Fedora 40. Update your system to get the latest kernel (sudo dnf update). Then comment out lines 151 through 154 in the audio script, and then run the script. It should install without issues.

Doesn't seem to work with Fedora on kernel 6.10.7

Doesn't seem to work with Fedora on kernel 6.10.7

My device is Pixelbook Go.I found out with Fedora on kernel 6.10.7 the tplg file is somehow missing, maybe the kernel update deleting them.
But you can just downlod the tplg files from this repo conf/avs/tplg and put them in the /lib/firmware/intel/avs (see: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/intel/avs).

Doesn't seem to work with Fedora on kernel 6.10.7

My device is Pixelbook Go.I found out with Fedora on kernel 6.10.7 the tplg file is somehow missing, maybe the kernel update deleting them. You can find the missing tplg error in demsg.
Just downlod the tplg files from this repo conf/avs/tplg and put them in the /lib/firmware/intel/avs (see: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/intel/avs).

My Case Chromebook Pro, Files from this URL did not help. But the files from 6.10.6 under /lib/firmware/intel/avs work fine for me.

I also had this experience.  in fedora 6.10.6 files ended tplg.bin.xz: however these files worked fine for me in debian where the files end in tplg.bin

I am just using files inside this folder.


Error: Cannot read properties of undefined (reading 'typedMessage'). retrying in 120 seconds

Status       : Error: Cannot read properties of undefined (reading 'typedMessage'). retrying in 120 seconds
Waiting      : 0h 1m 38s
Game Status  :

plinko     : pending (-)
singlewheel: pending (-)
mines      : pending (-)

update the code, and re-run

The code was updated, the error did not go away. The code was completely copied from Github - the error is there =(

I went through the browser, played one game and launched the script, there is no error, everything works


Enhancement tools

References

/fixes https://github.com/4Science/DSpace/issues/357
\fixes https://github.com/4Science/DSpace/issues/357

Description

new new enhancer
two improved item-enhancer scripts extending the current implementation

Instructions for Reviewers
List of changes in this PR:
Enhancers:

NameEnhancer

to fill Person dc.title from previous dspace 5.10 crisrp.preferredName / crisrp.fullName fields in the order of their occurences
set some default if no fields exist
Use case: different names of person are priotized in the display of search results and choice lookup

MapConverterValueEnhancer

fill a target metadatafield from the result of a mapConverter result of the source metadatafield (e.g. dc.type (dspace) to dc.type (coar)
Use case:

Enhancer Scripts:

ItemEnhancerEntityType
database-based approach
restrict enhancement to all Items of a collection

restrict enhancement to all Items of a given type
only enhance a maximum number of items (e.g. test result or effect on new enhancer)
use some limit after which some commit is made (avoid long time processes and one single commit on all entities)
Use case: apply new enhancers on some fractial of the repositories content saving time.

ItemEnhancerByDate

solr-based approach
restrict enhancement to all Items of a collection
restrict enhancement to all Items of a given type
only enhance a maximum number of items (e.g. test result or effect on new enhancer)
use some limit after which some commit is made (avoid long time processes and one single commit on all entities)
apply some solr daterange filter on the lastModified date (enhance all items modified between x and y || enhance all items modified before date z)
apply some general solr-filter (e.g. enhance all items matching some criteria, e.g. not enhanced by some cris.virtual.* field or some other criteria yet)
Use case: reapply enhancers on some run where some enhancement was suddenly broken.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

still a draft, no tests provided.

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[ ] My PR passes Checkstyle validation based on the Code Style Guide.
[ ] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[ ] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[ ] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

alignment to 2023.02.02 Release


APPS-1282 fix optional source input merging

When using "linkMerge": "merge_flattened":
https://www.commonwl.org/v1.2/Workflow.html#Merging_multiple_inbound_data_links

Source parameters which are arrays are concatenated. Source parameters which are single element types are appended as single elements.

This PR is to fix the merging implementation when the source value is an optional array.

LGTM, thanks! I think the conformance tests don't need to be rerun for the last commit.

Hm, I did delete the label


Fix newsfeed holes left behind by hidden events

Fixes #475.
Some simple alerts have been hidden on CSS, however the empty space still there.
I inspect many whitespaces and for me, the only case what I could see was when someone creates a branch.
I also have added 'package-lock.json'. I saw that We do not have this yet. However, if necessary I can remove, just ping me and I push back without them.

Any way to do this with only CSS?

I also have added 'package-lock.json'. I saw that We do not have this yet. However, if necessary I can remove, just ping me and I push back without them.

Yeah, remove it. I don't want a lockfile here.

In this moment no. We don't have a parent selector that fill our necessity.
Microsoft are thinking on that. https://developer.microsoft.com/en-us/microsoft-edge/platform/status/cssrelationalpseudoclasshas/

Add npm and yarn lock files to gitignore

This PR needs a more descriptive title.

This was indirectly fixed by https://github.com/sindresorhus/refined-github/pull/599.


[FIX]: Fixed navbar overlap on code playground and enhance UI of playground.

fix 1=> fixed navbar overlapping on code playground
fix 2=> Enhance the UI of the code playground and make it responsive
#158   #162
https://github.com/thecuriousteam/PyLibLog/assets/94177847/dc939017-3260-4f60-9c99-0fd0bf2bc1ad

@Chetan-Jalandharia can you add headings where we are the code and where we get the output
Naming Convention

Write Your Code Here
Reflect Output Here

or any suggestions for above
is it possible to have those buttons inside the code editors to run and clear the output?
Thank You
Instructions

Yes you can start working on it by taking latest pull from main branch
Don't Forget to join onboarding group for knowledge flow and direct conversation and support from other developers link  Curious Developers Community - Hacktoberfest
Please attach the screenshots and video of the development work once it is done
Contributions more than 3 will be awarded a certificate of appreciation from curious ecosystem please mail to<EMAIL_ADDRESS>for claiming certificate and please attach your issue number
Respect Co Developers And Please Reachout to admins if any issues

As of now we are merging the code so please rise the new pull request for the above @Chetan-Jalandharia


[Feature Request]: Change SignIn error.type value from CANCELED to ABORTED

From the 1.0.0-rc1 release notes: https://github.com/react-native-community/react-native-google-signin/releases/tag/1.0.0-rc1

signIn: resolves to user info or rejects with error. In case use cancels the login flow, the rejection error object contains a code property with value CANCELED see readme

Can we please change CANCELED to ABORTED or something similar. "canceled" and "cancelled" are both accepted spellings of the word. We can help to eliminate some likely frustration on the part of package consumers by avoiding the unnecessary spelling ambiguity.

hi @thomasw I agree the api interface is not ideal. I created a RFC where we can discuss some breaking changes that I think would be nice to get into the next RC. Please add your comments here https://github.com/react-native-community/react-native-google-signin/issues/450.

@thomasw I'll close this issue but please feel free to add opinion to Vonovak's issue #450