Toeventmodel addmd

this is more behind the scenes. allow the event stream simulator to_event_model to also add in metadata. For ex:
    # simulate the data
    from shed.utils import to_event_model
    Ndata = 2
    width = 10
    height = 10
    data = np.random.random((Ndata, width, height))
    output_info = (('data', {'dtype' : 'array'}),)
    # some metadata
    md = {'sample_name' : "AgBH"}
    stream = to_event_model(data, output_info=output_info, md=md)

where the change is now the last two lines, where md may be added.

You might look at this https://github.com/xpdAcq/SHED/pull/75/files#diff-7beea5feb18dea439c7d297ec796c0fa

Codecov Report

Merging #85 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #85      +/-   ##
=========================================
+ Coverage   97.59%   97.6%   +<.01%
=========================================
  Files           6       6
  Lines        1955    1959       +4
  Branches      442     443       +1
=========================================
+ Hits         1908    1912       +4
  Misses         21      21
  Partials       26      26

Impacted Files
Coverage Δ

shed/tests/test_utils.py
100% <100%> (ø)
:arrow_up:

shed/tests/utils.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819dd2b...b4aa405. Read the comment docs.

@ordirules is this ok?

looks good; just asked one question about default behaviour


some packages are abandoned

Package fzaninotto/faker is abandoned, you should avoid using it. No replacement was suggested.
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.

The last three packages are not handled directly by us, is a dependency of one of our dependencies. The faker package will be replaced once things establish regarding the faker fork.

Hope next version will solve it.

@rennokki Is there any update on the faker fork?

@rennokki Is there any update on the faker fork?

https://github.com/FakerPHP/Faker

https://github.com/FakerPHP/Faker

@avenCN @rifRocket This CLI output is non-critical.

@avenCN @rifRocket This CLI output is non-critical.


CB-21065 Create hints for Multi AZ nodes placement

Context: Datalakes templates will have "hints" for multi-az node placement. This PR creates this property in the database, data model, and converters.
Part 2: https://github.com/hortonworks/cloudbreak/pull/14655
Test:
Created a datalake with a custom template and different hints. Checked database if the set of hints was converted to the right format in the database.

Closing the PR, please re-open if it's still relevant.


Make navigation sticky

What do you want to do?

[x] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Currently, the side navigation of documentation on the left-pane of opensearch.org doesn't scroll down with the user when the body length is longer than the length of the Navigation pane. Let's make the side Navigation sticky while scrolling down, or add a sticky "Back to top" button.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
For an example of this behavior, see Square's documentation

@nateynateynate: Any ideas on this one? Figure we could add a new element.

Implemented in #2043


Feature request: moustache delimiter config

The moustache delimiters can conflict with other framework like for example Hugo. Although I can change the delimiters in template.js, I suggest that moon makes the delimiters configurable as a setting.

I'll add this in v0.9.0


added lngLat pointInfo

Coverage remained the same at 26.194% when pulling 2dcb37cdeadc534a229c96d8a7a94d18a2c9acaf on pointInfo_lngLat into 9092a7c2063a947bd9eda0bc356580f0bb3a605d on master.


Auto generation of markdown doc files and update the wiki.

Description
Auto generation of markdown doc files and update the wiki.
Type of Change

[ ] Bug fix
[x] New feature
[ ] Documentation update required
[ ] Code quality improvement
[ ] Other (describe):

@derdanu it looks like there is an error when pushing the wiki docs.
https://github.com/Azure/azure-storage-azcopy/actions/runs/11741062750/job/32708932390#step:7:39

These steps  can help with the permissions issue


treewide/nixos: remove with lib; part 3

Description of changes
part of #208242
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@philiptaron how should we continue here? do we consider my script as too bad?

@philiptaron how should we continue here? do we consider my script as too bad?

The fallout has made me pretty reticent to continue. It takes me about an hour to review these, and I'm provably fallible with the defects that have slipped through. I also have to switch over to $work$ for a bit, so I'm a bit slower than I was before.

AFAIK this is done by some automation: #335603 (comment)
Given that this has always caused a notable fallout that maintainers had to fix afterwards, did you fix the script or are we expecting a different result this time?

yes exactly the same script. Automation is not changed.
I was expecting 2 reviewers is enough to detect the problems. Definitely not a fault of the reviewers!

@Ma27 I have implemented a new approach:
using nix-build nixos/release.nix -A manual.x86_64-linux to build and parse the output of it with a custom python script. So i am only correcting the reported errors. (based on line-, character-index reports.)
I am doing this until the build succeeds. Yes it is slow, but it surprisingly works:
python-script
#!/usr/bin/env python3
import subprocess
import re
import sys

def get_option_string():
    result = subprocess.run(
        [
            "nix",
            "eval",
            "--impure",
            "--expr",
            'with import <nixpkgs> {}; builtins.attrNames (builtins.removeAttrs lib ["__unfix__" "removeAttrs" "map" "licenses" "fix" "and" "or" "kernel" "options" "meta" "path"])',
        ],
        stdout=subprocess.PIPE,
        stderr=subprocess.PIPE,
        text=True,
    )
    return result.stdout.replace('" "', " ").replace('" ]', "").replace('[ "', "")

def main():
    print("start post-patch")
    optionstring = get_option_string()
    available_lib_options = set(optionstring.split())
    NIX_BUILD_CMD = "nix-build nixos/release.nix -A manual.x86_64-linux"

    for file_path in sys.argv[1:]:
        while True:
            result = subprocess.run(
                NIX_BUILD_CMD.split(),
                stdout=subprocess.PIPE,
                stderr=subprocess.PIPE,
                text=True,
            )
            error_output = result.stderr
            reversed_error = error_output.splitlines()[::-1]
            error_variable_match = re.search(
                r"undefined variable '(\w+)'", error_output
            )
            # print(error_output, error_variable_match)
            if error_variable_match:
                error_variable = error_variable_match.group(1)
                line_info = next(
                    (line for line in reversed_error if "  at " in line), None
                )
                if line_info and error_variable in available_lib_options:
                    print(f"loc: {line_info.strip()}")
                    line_number = (
                        int(re.search(r":([0-9]+):[0-9]+:", line_info).group(1)) - 1
                    )
                    char_number = (
                        int(re.search(r":[0-9]+:([0-9]+):", line_info).group(1)) - 1
                    )
                    with open(file_path, "r") as file:
                        lines = file.readlines()
                    error_line = lines[line_number]
                    print(f"old: {error_line.strip()}")
                    modified_line = (
                        error_line[:char_number] + "lib." + error_line[char_number:]
                    )
                    print(f"new: {modified_line.strip()}")
                    lines[line_number] = modified_line
                    with open(file_path, "w") as file:
                        file.writelines(lines)
            else:
                break

if __name__ == "__main__":
    main()

is this a better approach? are you fine with it?

is this a better approach? are you fine with it?

I think it's a better approach than what we had before.
Another idea: evaluate relevant VM tests (if any): this approach covers option declarations and stuff around those, but I think e.g. code that puts systemd untis together isn't affected?
It may also help to do <module>.enable = true;, evaluate and check if something happens that isn't a ("X is used but not defined")?
That being said, my main concern was that seemingly there didn't happen much QA during the past iterations and we somehow expected different results on followups, hence my first comment.
But, after going through the options, I don't really have a good answer on how to test these kinds of changes.
@Infinisil or @roberth you perhaps?

@Ma27 should we split each commit into a separate MR? this way it would take longer, but the separation is better.

I'm going to give it a human review and see the error rate that I can find.

Let's ship it and see what shakes out.

2 days later and no error reports, just a rebase ping. Way to go Felix!


Assemblies

[@gavinking] We've often discussed the need for assemblies. The spec mentions this as a TODO, but we don't plan for it to be a part of 1.0, so we have not really defined what it is exactly.
An  assembly:

is a packaged artefact
containing one or more modules (and perhaps native libraries)
with metadata describing how the assembly should be executed
with the granularity of an "application"

I imagine that we would define an assembly using a descriptor, assembly.ceylon, that specifies the modules it includes (which may live within or inside or outside the namespace of the assembly), and then a ceylon assemble command that produces the artefact. The artefact itself is probably just an archived module repo.
[Migrated from ceylon/ceylon-spec#667]

Superseded by #5955 and #6712.


Review support for type, actions, and content in accessRequest per RAR's authorization_details object.

Closing as answered by https://github.com/darrelmiller/api-manifest/issues/9#issuecomment-1720160124.


feat: adding information_schema.views table

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
https://github.com/GreptimeTeam/greptimedb/issues/4339
What's changed and what's your intention?
adding information_schema.views table to display views.
Please explain IN DETAIL what the changes are in this PR and why they are needed:

Summarize your change (mandatory)
This content is generated by iterate table information from catalog manager and with filter table_type = VIEW, and retrieve view definition from table id. A very simple sqlness test is added as well.
How does this PR work? Need a brief introduction for the changed logic (optional)
Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)

Checklist

[x] I have written the necessary rustdoc comments.
[x] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

Summary by CodeRabbit

New Features

Introduced support for VIEWS in the information schema, allowing users to manage and query views within the database.
Added ability to create, query, and drop views using SQL statements.

Enhancements

Expanded SHOW queries to include the views table and relevant metadata.
Updated information schema tables with new columns to support view-related metadata.

Tests

Added new test scenarios to validate the creation, querying, and dropping of views.

@fengjiachun @sunng87 Please take a look.

@lyang24 Thank you!


[bugfix] Invalidate IP in ARP Poller

Resolves https://github.com/RackHD/RackHD/issues/226
@RackHD/corecommitters @zyoung51 @uppalk1 @tannoa2 @keedya

+1

👍


Add G2_whyRecordInEntity and G2_whyRecordInEntity_V2

See https://github.com/Senzing/g2-sdk-go/issues/111

Added via https://github.com/senzing-garage/serve-grpc/pull/270


[WIP] [POC] Flight SQL

9368

 Quality gate: Failed
12 Issues

 10 Code issues
 2 Anti-patterns

Details


clean up libusb_config when compiling python bindings

No need to configure libusb when we build Python...
Tracked on [LRS-937]

I'm closing this because of other issues with libusb, and I don't want to make too many changes while you're working on it. Will reopen another PR, unrelated to libusb.

Ok, Noted. Thank you.


net: arp: Do not access NULL network packet

The code was accessing network pkt before the value of the pkt
was checked.
Coverity-CID: 185394
Signed-off-by: Jukka Rissanen<EMAIL_ADDRESS>

Codecov Report

Merging #7241 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7241      +/-   ##
==========================================
- Coverage   55.03%   55.03%   -0.01%
==========================================
  Files         477      477
  Lines       51743    51743
  Branches     9948     9948
==========================================
- Hits        28476    28475       -1
- Misses      19304    19305       +1
  Partials     3963     3963

Impacted Files
Coverage Δ

subsys/net/ip/l2/ethernet/arp.c
62.75% <100%> (ø)
:arrow_up:

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27d968...1cca9c8. Read the comment docs.


Merge latest from Sufia

@projecthydra-labs/hyrax-code-reviewers

@jcoyne last travis build running. This is ready for review (in case I messed up the merge).

@jcoyne Fixed. Re-review?


(HOLD - DO NOT MERGE)Add addon v0.21.2 for flannel and address a fix to its script to generate the new versions

What this PR does / why we need it:
To fix the automated generation of the flannel addon to ensure that the flannel image used will be the same version of its release. And to add the new version v0.21.2.
Which issue(s) this PR fixes:
Fixes # [sc-51232]
Closes: https://github.com/replicatedhq/kURL/pull/4102/files
Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?
Adds [Flannel add-on](https://kurl.sh/docs/add-ons/flannel) version 0.21.2.

Does this PR require documentation?
NONE

Hi @emosbaugh,

what about the Manifest?

What do you mean with? This implementation works in this way:

We get the resources (yaml) from the docs
We read all images from the resources (yaml) and then we generated the Manifests

What we are doing here is before we generate the manifest ensure that the flannel images tag version will be the same version used for the tag release. In this way, the manifest file contains the image and versions accordingly. Is that make sense?

Hi @emosbaugh,

what about the Manifest?

What do you mean with? This implementation works in this way:

We get the resources (yaml) from the docs
We read all images from the resources (yaml) and then we generated the Manifests

What we are doing here is before we generate the manifest ensure that the flannel images tag version will be the same version used for the tag release. In this way, the manifest file contains the image and versions accordingly. Is that make sense?

Thanks I missed that


[V1.1] Remark Feature

Coverage decreased (-0.01%) to 92.525% when pulling 3a7e6edeeb4a654a2237820277823c0fa9be65bd on deep4k:feature/remark into c3c1530b0e3b547fe73036c6cfd1aaa9861c5d29 on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.4%) to 92.144% when pulling 4f4eda8ee75cda66366666cfd926fd0584d2a086 on deep4k:feature/remark into c3c1530b0e3b547fe73036c6cfd1aaa9861c5d29 on CS2103AUG2017-T15-B4:master.

Coverage decreased (-0.4%) to 92.144% when pulling fb397195396fb959602ea72b1ec935412515ab24 on deep4k:feature/remark into c3c1530b0e3b547fe73036c6cfd1aaa9861c5d29 on CS2103AUG2017-T15-B4:master.


Shift left sidebar correctly when following a link to an inactive stream

Reproducer: Click on an inactive stream in the left sidebar.
Expected: The stream should be centered in the left sidebar.
Actual: First the sidebar jumps to the stream, and next the stream move to the "Active" section (because the user just clicked on it). As a result, the stream may end up outside of the left sidebar view altogether.
Tips for reproducing the bug:

Have a lot of streams (./manage.py populate_db --extra-streams=100)
Use Slow 3G network throttling.

We should change the order of events, so that the view jumps to the stream only after it has been moved to the "Active" section.

@zulipbot claim

@akarsh-jain-790 thanks for your interest in this issue. I have taken over this issue since the bug is release critical. Feel free to open a PR if you already have a solution.

@alya  I am not completely sure I understand the issue, is the below outcome is what expected to be done to solve the issue?
"When the user clicks on the inactive stream, the stream should not move to the active stream section unless it is manually moved."

@Deekshith-S-Shetty thanks for your interest in this issue, this is not an easy one to fix apparently, hence removing the "good first issue" tag.

See https://chat.zulip.org/#narrow/stream/6-frontend/topic/Changing.20definition.20of.20inactive.20stream/near/1609070, but I think the current thinking is not to change the left sidebar logic at all, but instead to change the data powering the "inactive stream" state to not make the stream effectively become active when clicked on (due to that putting messages from the stream in cache).

Closing as a duplicate of #27009.


Rename Commit to Commit and Push

On desktop, committing and pushing are separate operations. In RemoteHub they are an atomic operation. We should make the remoteHub.commit command name and tooltip reflect this, so that users aren't left wondering how to push after committing like in https://github.com/microsoft/vscode-remote-repositories-github/issues/148. @KartikM123 suggested changing the tooltip to read 'Commit and Push' instead of 'Commit'.

Hm, I'm still seeing this with v0.26.0 of the GitHub Repositories extension. Does a new extension version need to be published?

insiders.vscode.dev should have v0.27.2022032303 🤔

Ok on GitHub.dev with insiders I still get 0.26
I confirmed it on vscode.dev insiders though

Yeah GitHub.dev does not bundle pre-releases of builtin extensions based on VS Code quality, so that is expected behavior. Thanks for checking!


Add support for local symf context

Fixes https://github.com/sourcegraph/jetbrains/issues/259
Test plan
Manual testing using full QA guide.
Other than that:

Enable context

Ask repo-specific question

Check if response is based on the understanding of the local context

Disable context

Ask repo-specific question

Check if response is lacking previous insight

Click on refresh button and check if reindexing is in progress

Click on help button and check if it opens proper documentation page

I've spotted some bug: if you click refresh while a response is still being generated, an error java.util.concurrent.CancellationException occurs. After this error, there are different problems with the chat.


Move apps to github.inl.gov

May need recipe changes

Job VTB Documentation on 8eec590 wanted to post the following:
View the site here
This comment will be updated on new commits.

@GiudGiud this is good to go. I setup redirects on github.inl.gov for idaholab/app -> ncrc/app so that the old versions of apps will work


constant number in mask

Hey @candreoliveira, thanks for the plugin!
I want to have this kind of mask for phone number: +1 (999) 999-99-99. Here number 1 should be constant 1, just like plus sign.
Is it possible to set constant number in the mask? I haven't found an example of it.

Not yet. But I'm rewriting the mask to improve quality and I'll cover it. Thanks!

+1 i need it

+1 really need it for phone input

+1 need it for counry code for phone number ( for example +7 (999) 999-99-99 )
also it would be nice if i can set regexp for some part of mask, for example i need complex check of first part of number - only 910 and 920 ( +7 (910) XXX-XX-XX or +7 (920) XXX-XX-XX )

As workaround I'm used bootstraps input group addon like this:

  +7
  <input type="text" class="form-control" placeholder="(___) ___ __ __"  ng-model="maskModel" mask="(999) 999 99 99">

i think, we need not only constant,  it can be list like a:
+(7,)
+(7,8)
+(2,7,8)
etc...
may be result of @candreoliveira rewriting proccess rewriting process is replaced current mask syntax with "all known" regex syntax?

@candreoliveira hi, is there any progress on this? Maybe someone else should implement this?

Any progress on this?
@candreoliveira

any progress? @candreoliveira


Fix typo

[skip ci]

I'm mostly curious what's the point of this packages, since there are faster packages available, and with more "bells and whistles".
(@v1.6) pkg> add https://github.com/kescobo/ArgParseLite.jl
julia> @time using ArgParseLite
0.001742 seconds (2.50 k allocations: 229.547 KiB)
julia> @time using QuickArgParse
0.002049 seconds (2.65 k allocations: 258.039 KiB)
julia> @time using DocOpt
0.003732 seconds (4.73 k allocations: 394.562 KiB)
julia> @time using ArgParse
0.004584 seconds (8.02 k allocations: 743.281 KiB)
Note it got faster in version 1.1.2: https://github.com/carlobaldassi/ArgParse.jl/pull/104

I will admit I haven't kept up with the newer versions of ArgParse, and I certainly understand the concern about having too many packages trying to do the same thing.
I've ended up using QuickArgParse as a dependency for other a number of other things (both PlasmaCNA and ichorCNA_U use it), so registering it would make installing those easier. This is the first package I've tried to register and I'm not familiar with the requirements for novelty, so if you think it's redundant and don't want to add to the package namespace that's fine.
The PlasmaCNA error is very odd. There is a Base.get_preferences apparently (last comment in https://github.com/JuliaLang/julia/issues/41295), but I don't use it in PlasmaCNA, and I don't see a variable "get_preferences" anywhere in the source code. I will look into it more, thanks for the heads up.

redundant and don't want to add to the package namespace that's fine.

It's not really my say, and I don't know the rules. I was mainly thinking, if you actually didn't know of the alternatives. I didn't check your code to see if much (or full) overlap with others. Just found it likely.


[libSyntax] Fix SwiftSyntax CodeBlockItemList test

The test had multiple issues that happened to cancel each other out:

The declared struct had no name
The visitor did not call super for CodeBlockItemLists
The total number of CodeBlockItems in nested-blocks.swift is 4 (struct Foo, print("hello"), func bar, and print("goodbye")

@swift-ci Please smoke test

The test had multiple issues that happened to cancel each other out

I’ve never personally identified with a test case before.
Thanks for fixing this!


Add Python script

Adding a script which take as input a file path and return the average accuracy on 20 runs.
Each run samples randomly (uniforme distribution) 3/4 of the data for the training, and the rest for the test.

Thanks!


Add feature flag for cw20 support in dao-core.

This puts cw20 support in the dao-core contract behind a feature flag. The feature is not enabled by default, so for DAOs that want to use cw20s this is a no-op.
As part of this change I have also added lints and tests to CI which run with no default features enabled so we will detect regressions if a future change depends on cw20 support, but does not properly gate itself behind the feature flag.

Codecov Report
Base: 95.06% // Head: 95.06% // No change to project coverage :thumbsup:

Coverage data is based on head (31b4134) compared to base (74bd388).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   95.06%   95.06%
=======================================
  Files          42       42
  Lines        3808     3808
=======================================
  Hits         3620     3620
  Misses        188      188

Impacted Files
Coverage Δ

contracts/dao-core/src/contract.rs
97.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support for parsing config file at start

Signed-off-by: Harkishen-Singh<EMAIL_ADDRESS>Fixes: #7322

/cc @codesome

@codesome updated.

@brian-brazil @roidelapluie  any views?


About the stanford dog dataset.

Hi, @Robert-JunWang . Thanks for the great job. I was wondering if you can share the stanford dog dataset with more samples. Or can you share the impelement details about how to create it?

You have to download the whole ImageNet dataset and create a soft link or copy images to another folder according to the synset id used in the original Stanford dogs dataset.  I can upload the id list to this repository later if you need.  You can follow the instruction of the following link to create ImageNet dataset. https://github.com/pytorch/examples/tree/master/imagenet

Thanks for you advice. I will download the ImageNet dataset. Looking forward to  the id list.

n02085620
n02085782
n02085936
n02086079
n02086240
n02086646
n02086910
n02087046
n02087394
n02088094
n02088238
n02088364
n02088466
n02088632
n02089078
n02089867
n02089973
n02090379
n02090622
n02090721
n02091032
n02091134
n02091244
n02091467
n02091635
n02091831
n02092002
n02092339
n02093256
n02093428
n02093647
n02093754
n02093859
n02093991
n02094114
n02094258
n02094433
n02095314
n02095570
n02095889
n02096051
n02096177
n02096294
n02096437
n02096585
n02097047
n02097130
n02097209
n02097298
n02097474
n02097658
n02098105
n02098286
n02098413
n02099267
n02099429
n02099601
n02099712
n02099849
n02100236
n02100583
n02100735
n02100877
n02101006
n02101388
n02101556
n02102040
n02102177
n02102318
n02102480
n02102973
n02104029
n02104365
n02105056
n02105162
n02105251
n02105412
n02105505
n02105641
n02105855
n02106030
n02106166
n02106382
n02106550
n02106662
n02107142
n02107312
n02107574
n02107683
n02107908
n02108000
n02108089
n02108422
n02108551
n02108915
n02109047
n02109525
n02109961
n02110063
n02110185
n02110627
n02110806
n02110958
n02111129
n02111277
n02111500
n02111889
n02112018
n02112137
n02112350
n02112706
n02113023
n02113186
n02113624
n02113712
n02113799
n02113978
n02115641
n02115913
n02116738


One-lined another link

Realised that the adventuregems link still didn't one-line. There's also another link that didn't one-line so I fixed that one as well for cleanliness.

Excellent! LGTM


git commit range not resepcted - pull all issues and takes forever

jira-changelog --range e9f569df..e9f569df - should do nothing as it's an empty range but pulls all isues
jira-changelog --range e9f569df~1..e9f569df - should do exactly one, pulls everything
jira-changelog --range  e9f569df..cd1f7cd6 - again pulls everything
Each of these take about 2 minutes and then dump the whole jira.
Am I doing something wrong?

I've had the same issue and found the tool parses triple-dot ranges only. This is because of https://github.com/jgillick/jira-changelog/blob/v1%2C6.3/src/cli.js#L144 and is against what is documented in the readme file. Try jira-changelog --range e9f569df...cd1f7cd6.

Thank you for reporting this. The range parsing should not be fixed in version v2.0.0 (fix commit: https://github.com/jgillick/jira-changelog/commit/22dfbdbee35cfb5f955a6f7d764616c4ae6f3941). Please let me know if this works for you.


[XXX] Add NCTLOrganisation model

Context
The nctl_organisation table contains NCTL ids associated with particular organisations.
These are useful for linking Find organisations to other DfE services because. The Support app already displays this information.
Changes proposed in this pull request
Add the model and spec for it.
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

fyi @duncanjbrown those urn you was asking about...


Toolbar hides bottom of ScrollView

Example: The bottom button in fragment_compare_art.xml (land) is hidden unless the toolbar is hidden.

This is due in part to the Toolbar at the top of the screen. The toolbar must be hidden for the bottom button to scroll up into view. I am not entirely sure if this is something that could, or should, be accounted for.


Export Marshal and Unmarshal from ICECandidate

This is needed by toJSON for pion/webrtc
Relates to pion/webrtc#762
Co-authored-by: Hugo Arregui<EMAIL_ADDRESS>

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   64.83%   64.83%
=======================================
  Files          11       11
  Lines        1038     1038
=======================================
  Hits          673      673
  Misses        276      276
  Partials       89       89

Impacted Files
Coverage Δ

common_description.go
82.6% <0%> (ø)
:arrow_up:

jsep.go
0% <0%> (ø)
:arrow_up:

ice.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07d6a4...490ab52. Read the comment docs.


Room Store

closes #215
This PR is a working implementation of a Store that can use a RoomPersister.  While not in its final form I wanted to open the pr to get feedback.  I'll annotate the important parts.

LGTM besides the nitpicks :)

Added prelimanary tests, marked RoomStore as Experimental and added tests, bump rev up to 3.1.0
Pr is ready to merge IMO.
Follow up from me will be a blog post, more tests and a cleanup of the example that is currently living in SampleApp
@tiwiz wake up and review my code :-D

example usage:

@Entity
data class User(
        @PrimaryKey(autoGenerate = true)
        var uid: Int = 0,
        val name: String)

@Dao
interface UserDao {
    @Query("SELECT name FROM user")
    fun loadAll(): Flowable<List<String>>

    @Insert
    fun insertAll(vararg users: User)

}

@Database(entities = arrayOf(User::class), version = 1)
abstract class AppDatabase : RoomDatabase() {
    abstract fun userDao(): UserDao
}

val db = Room.databaseBuilder(SampleApp.appContext!!, AppDatabase::class.java, "db").build()

val store = RoomInternalStore(
        Fetcher<User, String> { Single.just(User(name = "Mike")) },
        object : RoomPersister<User, List<String>, String> {

            override fun read(key: String): Observable<List<String>> {
                return db.userDao().loadAll().toObservable()
            }

            override fun write(key: String, user: User) {
                db.userDao().insertAll(user)
            }
        })


fix(Get-AzureConstants.py): remove the date string from the header

add test to circle config
add make target to run test in test.mk
add script that executes the test

dont merge this yet! I have it intentionally failing right now so I could show you how it works


Include only maps component of Google Play Services library

This was originally implemented in https://github.com/googlemaps/android-maps-utils/commit/85258dec6c217c5189b453478f691375f2a14db1 and https://github.com/googlemaps/android-maps-utils/commit/68609ef0c734b5971c9829fe11978ecd24816324, but seems to have been mistakenly reverted in the GeoJSON commit https://github.com/googlemaps/android-maps-utils/commit/46a4e20b034880c659689ff106931827ccaf2510.  As far as I can tell the other Google Play Services components aren't needed for GeoJSON.

CLA checked manually.


"... within 500 metres" - should this be < or <= 500?

(not urgent - but good to be clear when we write papers)
Currently, the codes appear to implement as
access = (distance < 500)
e.g. when I run these queries, the maximum distance is 499 (after I have cast it as Int64):
>>> np.nanmax(gdf_nodes_poi_dist.sp_nearest_node_supermarket_dist)
499
>>> np.nanmax(gdf_nodes_poi_dist.sp_nearest_node_pt_dist)
499
>>> np.nanmax(gdf_nodes_poi_dist.sp_nearest_node_convenience_dist)
499

I think there are some arguments for being slightly more lenient and evaluating access where the distance is 500 metres or less:
access = (distance <= 500)
Its slightly more lenient (and given likelihood of some error, I think its fair to give benefit of doubt), and the one clear explanation of the PostGIS function ST_Dwithin  I found states that returns "... true if geometry A is radius distance or less from geometry B".
That we all are aware and agree on what the threshold is, and how its implemented in case someone asks is the main thing.

Okay --- the above is resolved, from my perspective; the Pandanas implementation is indeed seeking up to 500m, but I overlooked that in my casting from float to int that depending on how you do that impacts on whether 499.99999 is counted as '500' or '499'
# if you don't round first, it goes to 499
>>> max(gdf_poi_dist2.sp_nearest_node_pos_dist.astype(int))
499
# if you do, it goes to 500
>>> max(round(gdf_poi_dist2.sp_nearest_node_pos_dist,1).astype(int))
500

And if you look at the distances returned from Pandanas calls, you see they go up to 500 in a continuous sense, and that's probably fair enough

>>> gdf_poi_dist2
            sp_nearest_node_pos_dist
id
5862588417                104.358002
5862588419                140.417999
5862588420                  0.000000
5862588421                178.524994
5862588422                181.186996
...                              ...
5915017210               -999.000000
5862588411                447.138000
5862588412                493.363007
5862588413                331.852997
5862588414                379.183990

[347904 rows x 1 columns]
>>> max(gdf_poi_dist2)
'sp_nearest_node_pos_dist'
>>> max(gdf_poi_dist2.sp_nearest_node_pos_dist)
499.9880065917969

Apologies for posting a confusing issue --- but at least now we are sure
access = distance < 500, where distance is a float
I'll mark this as resolved.


[Feature] Revamp version management

Search before asking

[X] I searched the issues and found no similar issues.

Component
Other
Feature
We would like to allow transforms to manage their micro version numbers independently of the core libraries.  With this in mind, we have the following:
Guiding principals/goals

github "releases" will be published to a new minor (not micro) version number.  For example, 0.3.0
when there is a github release, we will publish pypi wheels and images
transforms can increment the micro version independently of the core library version and formal github release
We will (for now) keep the dev suffix, until we decide we can live w/o it.
It is ok and expected to republish a transform at a new minor version  that may be the same functionally as the previous version (i.e 0.3.0 and 0.2.9)
Transforms can define dependencies on DPK in pypi or in the repo source (choice is already supported today via USE_REPO_LIB_SRC in .make.defaults)

TODOs:

Transform version numbers need to be pushed down from .make.versions to a transform-specific location (i.e. transforms/noop/version)
make set-versions neeeds to still work through the repo to reset to a new minor version (i.e. 0.3.0) (and be extended to work on transform's version file)
Update release-branch.sh script to bump minor version numbers instead of micro.
Update RELEASE.md to capture these goals and changes.

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Closing as duplicate of #639


Missing buildpack support for latest postgres release v7.0.1

Hi,
seems that the buildpack's compile script  does not support latest version v7.0.1 of postgrest precompiled binary since previous build relases used __ubuntu.tar.xz  file suffix,
whereas the latest relelase states the following : "From this version onwards, the release page will include a single Linux static executable that can be run on any Linux distribution"  (___linux-x64-static.tar.xz)
Setting  postgrest version 7.0.1 on heroku yelds therefore to the following error:
-----> Could not find prebuilt  postgrest-7.0.1

Same as : #29


w2ui gird mergeChanges() when grid.recid set to different field

Short description
mergeChanges function fails when grid.recid set to different field in w2ui 2.0.x (nightly)(4/21/2021)
What is current behavior
calling "mergeChanges" after onChange event in grid with inline editing and with recid set to different field ('id' in this case)
get errors:
ERROR: Cannot merge.  Cannot set property 'id' of null TypeError: Cannot set property 'id' of null
at w2grid.mergeChanges (w2ui.js:6348)
at :1:17
w2ui.js:6353 Uncaught TypeError: Cannot read property 'w2ui' of null
at w2grid.mergeChanges (w2ui.js:6353)
at :1:17
seems to be due to change in "getChanges" causing "mergeChanges" to not find record based on recid field...?
v1.5: getChanges:line 5874-6:
if (rec.w2ui.changes != null) {
changes.push($.extend(true, { recid: rec.recid }, rec.w2ui.changes));
}
v2.0: getChanges: line 6322:
if (rec.w2ui.changes != null) {
var obj = {}
obj[this.recid || 'recid'] = rec.recid
changes.push($.extend(true, obj, rec.w2ui.changes));
}
v2.0:mergeChanges: line 6340                var record = this.get(changes[c].recid);
What is desired behaviour
mergeChange() updates grid recordset.
it works when I changed line :
// changed
//                var record = this.get(changes[c].recid);
var record = this.get(changes[c][this.recid || 'recid']);
...
Steps to reproduce or sample

grid.recid:"id"
inline editing
call grid.mergeChanges()

...

I just realized this is duplicate of issue #1965

Fixed in both branches master and w2ui-1.5. Good Catch. Eventually, there will be 1.5.4 but before that you can compiled version from 1.5 branch on your own.


TitleDB access MUST use a User-Agent header.

Please make sure that all access you're directing toward api.titledb.com has an HTTP User-Agent header set. It needs to contain at a minimum the application name and version number that is making the request, something like
User-Agent: Homebr3w/1.0.0
Or more thoroughly, since you may be redirected to a host that won't return results unless it thinks you're a web browser:
User-Agent: Mozilla/5.0 (Nintendo 3DS; Mobile; rv:10.0) Gecko/20100101 Homebr3w/1.0.0
If you don't set a User-Agent header, you're going to be blocked out of access to the API backend until it is added. Right now I'm still allowing unidentified clients since FBI wasn't set up correctly, but the next version has already been patched, and I'll begin blocking unknown clients sometime shortly after it's public release.

Alright, so I see that lpp-3ds just doesn't have header support, or disables ssl verify support, or the ability to follow URLredirection, or handle chunked encoding (uh... does this do anything network related correctly?)

That's the reason why I proxy through my PHP script right now. I thought I had the User-Agent properly set up but it seems I forgot to add the User-Agent:  in include.php. The PHP script is mostly fixed in 7256cea78647aeaadb1dc01cfb68f1bfa2534fce but I am still having a bit of trouble with getcia.php.
For some reason, using file_get_contents() on your proxy/titleid endpoint returns the .cia as expected, using the http_req() function that I defined in include.php on the other hand fails and only returns [] as file content. Do you have an idea?

Maybe not including the proper path? I see this request come through... There's no API version number in it... (also, you can GET the /v0/proxy/ results... only the main API requires POST)
[12/Jul/2016:11:02:34 -0700] "POST /proxy/0004000000130800 HTTP/1.1" 200 3350 "-" "Mozilla/5.0 (Nintendo 3DS; Mobile; rv:10.0) Gecko/20100101 Homebr3w/1.0.0 Homebr3w-Proxy/1.0.0"

That was when I was playing around with settings right now when I was testing locally on my xampp server. None of the changes I made did work though, it always ended up with a 3 byte sized file containing []

0004000000130800.zip
These are both files I got with the 2 different methods.

Can you fire off a test both ways using this API url instead of the production one, so I can more easily see what is going on in the logs...
https://3ds.intherack.com/titledb-dev/v0/

Done. Sent 2 requests, the first one was with get_file_contents and the 2nd one was http_req

<IP_ADDRESS> - - [12/Jul/2016:11:30:23 -0700] "GET /titledb-dev/v0/proxy/0004000000130800 HTTP/1.0" 302 4049 "-" "-"

<IP_ADDRESS> - - [12/Jul/2016:11:31:01 -0700] "POST /titledb-dev/v0/proxy/0004000000130800 HTTP/1.1" 200 3350 "-" "Homebr3w/1.0.0 Homebr3w-Proxy/1.0.1"

So, you need to make sure you GET instead of POST with http_req when using the proxy or redirect actions... a GET of /v0/proxy/0004000000130800 is actually taken internally as a POST of /v0/ with JSON data {"action":"proxy","titleid","0004000000130800"}, But keep in mind you can't provide this as JSON externally as the command validator will discard it currently. It really MUST be a GET action right now.

Reopening actually, since I have to figure out a method of redirection follow that actually works on my current webserver.

For some reason, on my production server it doesn't follow the redirect, only printing out the 302 FOUND message. Works fine on my XAMPP dev server though. Ideas?

Maybe it doesn't follow redirects by default? If so, you can capture any 30x return code, pull the "Loacation: http://newurl.com/goes/here" header out, and parse it manually.... but there's probably some kind of option to make curl just follow redirects itself.

It doesn't follow redirects by default, no curl does. You have to set CURLOPT_FOLLOWLOCATION to true. Which I did, see

It's weird that it works fine on my dev server but as soon as I put it on my production server it fails to follow the redirection.

Files that get proxy extracted seem to get sent through properly at least

Well, it probably doesn't matter too much, as lpp-3ds will be able to handle all this pretty soon...
If you'd like to test a new LPP that has been modded to allow headers/POST, there's a compiled test build at http://home.intherack.com/lpp-test.zip
downloadFile has been extended to take up to 5 options, instead of just 2, and the downloadString varient takes 1 to 4....
The extra three in order for each are 'headers', Which is a newline delimited string of all headers that should be in the request... so something like:
"User-Agent: NewUserAgent/v1.0.0\nX-Extra-Header: Value for the extra header" would define both User-Agent and X-Extra-Header
then method, which defaults to "GET" but can also be POST or HEAD (all caps, case sensitive)
and finally the data string to be posted, so { "action":"list" } or whatever
It may segfault and die instantly, I don't have any way to check things yet and I don't really know jack about Lua in general....

I'll definitely give it a try later/tomorrow. The PHP proxying really isn't ideal and I wanted to get that done away as soon as possible. Does this check SSL certificates?

It disables the SSL cert check, yeah... no URL redirection handling or Chunked encoding support yet though, and it's probably not entirely stable...

If redirection is still a problem that means my getcia.php still needs to remain for now but I'll see about rewriting the other information fetches

Redirection is entirely fixable...  I just need to figure out how to replace the existing URL in the lua string pointer so I can re-call the lookup to the new URL, I just need to figure out how some of these internal functions like luaL_checkstring() and lua_pushlstring() are used to mangle the one lua_State *L pointer that everything gets passed back and forth with. That, and I'm still at work at the moment, so I haven't been able to look through the Lua code very much yet.

 No request came in on my server so it looks like the HTTP request is not even executing.

Alright, I've got some idea of what might be causing problems, and I'm finally home from work, so I'm going to try to figure out how to set up some kind of debug environment to test and finish this

Thanks man, appreciate your help on this a lot

Okay... So parsing headers is kind of hanging me up at the moment, but http://home.intherack.com/lpp-test.zip has been updated to my current testing version now... Usage is like:
    Network.downloadFile("https://api.titledb.com/v0/","/Downloaded.txt","User-Agent: LuaShit/1.0.0","POST",'{"action":"list"}')

This supports 301 through 308 URL redirection, file length unlimited by system ram (so things like Haxxagon with BGM that's 100+MB can be installed now) doesn't care about a missing Content-Length: header anymore... basically, everything but headers works now, but only for downloadFile... I need to patch up the downloadString still, and fix header parsing so they set correctly. It's more than enough to give you something to write code against that will actually work though.

It doesn't freeze anymore, so that's good. Instead I am getting Error: [string "?"]:<LINE>: error opening url. Code is Network.downloadFile("http://homebr3w.wolvan.at/geticon.php", "/test.png", "User-Agent: Homebr3w/"..APP_VERSION, "GET", json.encode({action = "list"}))

That's actually the error kicked out when the server came back with something other than 200 (though it should be anything other than 200/204/206/304 ... Can you check the webserver logs to see what was actually sent back?

I've updated http://home.intherack.com/lpp-test.zip with the requestString method patched to match downloadFile... I no longer get any buffer overflow/crashing with either of them, but I can't do any real testing until after work... You can give it a quick run-through and see if you can identify where the problems are, go for it... if it's something simple i can fix it and recompile, otherwise I'll get back to it after around 6PM PDT

Server still doesn't get a request. Found the problem of me having reversed path and downloadURL.
Unfortunately, requestString still tells me error opening URL and downloadFIle doesn't seem to fire a request at all anymore. No error but the file doesn't end up on the SD card. Also my apache log doesn't show any new hits either. (It does show hits when I browse to it in chrome, so the webserver is working)
Something else I noticed is that when I go back to HBL, the Network icon shows disconnected but starting the app doesn't trigger the checkWifi error.

Strange... What does it do if you use this for the index.lua script?
`
-- Check if WiFi is enabled
if Network.isWifiEnabled() then
    -- Download a file
    local remoteData = Network.requestString("https://api.titledb.com/v0/","User-Agent: LuaShit/1.0.0\nX-Extra-Header: Extra Data","POST",'{ "action":"list"}')
    print(remoteData)

end
    Network.downloadFile("https://api.titledb.com/v0/","/Download.txt","User-Agent: LuaShit/1.0.0\nX-Extra-Header: Extra Data","POST",'{ "action":"list"}')

-- Return HBL
System.exit()
`

Now download happening and printing doesn't work on 3ds anyways. It just jumps to system.exit

So, the download call seems like it works fine, I'm not 100% on the requestString method or how to utilize it properly though... Can you figure out how to make a test case that shows what it's actually returning and if it works as expected?

Sure! One moment, I'll report back to you

https://gist.github.com/Wolvan/5e6a941d30bdea498c6967ea17fc9d68
Have this, still getting the Error opening URL on line 21

Commenting out the Network.requestString makes the app run to System.exit() but no file gets downloaded at all

What gets appended to /aaa-outfile.txt on the SD card when it does that?

File gets created but stays empty

Strange... To be created but stay empty it would have to die during httpc context creation... That shouldn't happen unless the OS thinks networking isn't up or something.

Are you testing as .cia or as .3dsx? 3dsx may not crash quite the same way

I am using the .3dsx build. Want me to try .cia?

Just to see if it's different for you, sure, give it a shot and see what happens.

I just tried your test script dropped in place of the main file in a clone of this repo to build as a cia (I don't have HBL and it's far less convenient anyway) and I got four .json files and Download.txt, and everything looks like it worked just fine for me.

Alright, Lua Player has been patched, the finished build is at http://home.intherack.com/lpp-test.zip again. Pull request with docs for the changes on it is at https://github.com/Rinnegatamante/lpp-3ds/pull/36 so it should be in mainline shortly.

Yes! It works perfectly for the .cia build! Unfortunately, for some reason the .3dsx version seems to be screwy, sometimes returning nil for getJSON instead of a table. I guess I should drop 3dsx support?

I'm not entirely convinced that the stack isn't entirely hosed by the point it's doing the download loop for the string mode... The reason I think so is that this should be a u32 however, when it is, the whole thing segfaults (or similar, I don't have a debugger for the 3DS) here in line 285 which is just basic integer addition. I don't have an explanation for why this would be the case, but maybe the default stack is too small (its 32K, iirc) and when built as a .cia, it gets a 256K stack set from cia_workaround.rsf
If you want to try a build with a 256K stack explicitly set, I've recompiled http://home.intherack.com/lpp-test.zip ... The previous good as a .cia version is http://home.intherack.com/lpp-stable.zip in case you need it back for some reason.

For now I decided to drop 3dsx support, you can't install CIAs with it anyways so it hasn't much use apart from being no inconvenience to support. .cia and .3ds work fine so those are the ones I'll push in a moment, I just have a few more small things I have to add/fix before doing so.
tl;dr: Dropped .3dsx, gonna push a new release later.

Awesome... No rush on it. The guys on #3dsdev just reminded me that I can turn my console into a dev unit using the luma-dev fork(?) and might be able to get at least a stack trace out of LPP with that. So I may be able to to fix things properly this evening anyway...

Alright, that's good to know. I'm done with what I wanted to add for this version, I'll have my beta testers try it out anyways before making a release out of it, so take your time.

Did you take a look at the .3dsx already? Fine if not, just curious

Sorry man, I haven't had any free time to dig into it yet. Hopefully I'll have some time to look at it this evening. How is beta testing the new version going, any other problems?

That's cool. Both my beta testers gave me an OK on the current feature set and haven't noticed any bugs, so I'd be ready to push a new release on my end.

I'm unable to reproduce the crash, so you may as well release without a
3dsx. It may take a while to get it fixed.
On Sat, Jul 16, 2016 at 10:50 AM Wolvan<EMAIL_ADDRESS>wrote:

That's cool. Both my beta testers gave me an OK on the current feature set
and haven't noticed any bugs, so I'd be ready to push a new release on my
end.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Wolvan/Homebr3w/issues/1#issuecomment-233142494, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AECriPvHzSPG7rqjHn5R-0LZ4BTB_lhrks5qWRntgaJpZM4JKlhr
.

That's alright. Still, thank you a ton for making this possible in the first place, you rock!

Closing this with the release of https://github.com/Wolvan/Homebr3w/releases/tag/v1.1.0, if you're alright with that. Thanks a lot for your help, couldn't have done that without you.

No problem at all. It all looks damn good from the server side, nice work yourself!

I'll keep the proxy scripts on for a while longer so 1.0.0 still works. Most of the requests should have a proper header set except the getcia, I hope you don't mind.

It's no problem at all. I'm still waiting for an FBI release with headers,
then I'll have to wait for everyone to upgrade off that as well before I
can start rejecting headerless connections. Really, I just need to be able
to tell what is what on the server side when there's problems, and your
proxy stuff all comes from one IP so it's pretty easy to tell what it is.
On Sat, Jul 16, 2016 at 3:26 PM Wolvan<EMAIL_ADDRESS>wrote:

I'll keep the proxy scripts on for a while longer so 1.0.0 still works.
Most of the requests should have a proper header set except the getcia, I
hope you don't mind.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Wolvan/Homebr3w/issues/1#issuecomment-233154247, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AECriOMrPriXOOJ2ShQFkokqP8Ue5RuZks5qWVqvgaJpZM4JKlhr
.

Fair enough, thanks for understanding. It was a pleasure being able to work with you!

Yeah, the same goes for working with you. I've still got some plans to fix keep-alive connections in ctrulib, so I'll get the changes added to lpp and let you know when I do. Pulling all those images will be way faster if the 3ds doesn't build and break down a tcp connection to do each of them. So you haven't heard the last of me quite yet. ;)

I shall await this day then.


fix(ios)!: unique id per device and not per ios account (keychain)

Description
Fixes #1526
The unique id is persisted in the keychain using kSecAttrAccessibleAfterFirstUnlock.
This causes unexpected behaviors sometimes when using the same ios account in different devices.
The keychain syncs these variables and the device id is no longer unique.
To mitigate this, the breaking change is required to store the unique id per device only using the config variable
kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly instead.
Compatibility

OS
Implemented

iOS
✅

Android
❌

Windows
❌

Checklist

[X] I have tested this on a device/simulator for each compatible OS
[X] I added the documentation in README.md
[ ] I updated the typings files (privateTypes.ts, types.ts)
[ ] I added a sample use of the API (example/App.js)

I thought about adding support for cross-install device id, just using an isShared variable
but that kinda complicates the docs and not sure you'd want that.
Also while developing,
I found few changes that could be implemented, let me know if you'd like prs for those

Convert all objc modules to swift for easier maintenance
Support new node js for example app
Convert example app from class based to functional based

@mikehardy your thoughts?

related #1646

@humaidk2 hi there 👋
you had some other questions:

Convert all objc modules to swift for easier maintenance

This would be great!

Support new node js for example app
Convert example app from class based to functional based

Spending time on the example app is difficult for me, I typically consider them both really important and also a waste of time (since the upgrade cost between react-native versions is something paid over and over in lots of repos)
So what I want to see for the example is either a PR with 2 commits, one of which is nothing but changes to https://github.com/react-native-device-info/react-native-device-info/blob/master/refresh-example.sh and the second one which is just the commit of the result of running the changes
I cannot accept a PR that just directly modifies the example app, because that commits us to a future course where we have to continue hand-modifying it
...or a switch to https://github.com/microsoft/react-native-test-app so that we no longer have to maintain anything.
I prefer using react-native-test-app these days but I'm not sure if it is feasible in this repo with all the different platforms supported

I don't think this issue is fixed on iOS. Due to the fallback on [DeviceUID uid], the value in the keychain is not restored, but NSUserDefaults is still backed up. As a result, a new device will get the UID of the previous device from NSUserDefaults: https://github.com/humaidk2/react-native-device-info/blob/209b0a2fa3da223ca2dd328427e0818461a46956/ios/RNDeviceInfo/DeviceUID.m#L51
Therefore, the device UID is not unique across multiple devices.

@Aure77 all reasonable PRs accepted, with bonus points for either backwards compatibility or really really really good commentary to include in the CHANGELOG for all us overworked devs that just need to know if it affects them, and what to do if so.
This isn't a use case of mine so with apologies, I have no time to donate for it. But I do merge PRs and release...

Is it correct that after migrating to this library version and pushing out a new app version to my users, their current device IDs will be inevitably reset / regenerated after updating the app?
I did some tests and it looks like this is the case. For apps where the device ID is used for user authentication and similar, this would mean users will lose their data after the app update.
I think it might make sense to offer a flag that could be set to just keep the old mechanism without having to use react-native-keychain. What do you guys think?

What do you guys think?

I'm the only current maintainer that does any work here at all and I have no interest in implementing it.
My previous comment stands

all reasonable PRs accepted, with bonus points for either backwards compatibility or really really really good commentary to include in the CHANGELOG for all us overworked devs that just need to know if it affects them, and what to do if so.
This isn't a use case of mine so with apologies, I have no time to donate for it. But I do merge PRs and release...


Add freeze() method

Codecov Report

Merging #41 into master will increase coverage by 0.12%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   86.02%   86.14%   +0.12%
==========================================
  Files          62       62
  Lines        1116     1133      +17
  Branches      248      251       +3
==========================================
+ Hits          960      976      +16
  Misses         75       75
- Partials       81       82       +1

Impacted Files
Coverage Δ

packages/rawmodel-core/src/core/props.ts
84.9% <100%> (+0.4%)
:arrow_up:

packages/rawmodel-core/src/core/models.ts
85.65% <75%> (+0.32%)
:arrow_up:


Possible race when connecting with Kafka/ZK (while Kafka/ZK are booting)

If I have a docker-compose configuration that has 3 containers I can reproduce a connection issue where nokafkaclient can't subscribe to anything:
services:
  zookeeper:
    image: "zookeeper:latest"
    ports:
      - "2181:2181"
  kafka:
    image: "kafka:latest"
    depends_on:
      - "zookeeper"
    ports:
      - "9092:9092"
  nokafkaclient:
    depends_on:
      - "zookeeper"
      - "kafka"

(the "depends_on" feature of docker-compose doesn't introduce delays or "waits", all it does is control order)
If docker-compose up nokafkaclient is run, the simple consumer's init's promise returns successfully, yet calling subscribe promise returns an error:

This request is for a topic or partition that does not exist on this broker.

despite the existence of that topic
and even with the logLevel at 5, there's no debug output at all
no amount of time passing auto resolves the issue

restarting the nokafkaclient will resolve it.
If using the simple consumer, should the metadata be manually refreshed at certain times, events or errors?

no-kafka does reload metadata on runtime errors when needed. In this case however I'm not sure that it should reload metadata or retry subscription.
I think the best solution is to start Kafka first and then start all application code that relies on it.
If you need to refresh the metadata manually you can do this with consumer.client.updateMetadata() call.

should reload metadata or retry subscription.

retrying subscription continues to fail, I'll try reloading metadata to prove the hypothesis.
Since there's no debug output and since no-kafka isn't reloading metadata on this error, I wonder if the error is being thrown somewhere outside of the expected flow.

https://github.com/oleksiyk/kafka/blob/b53f8f26380c019a4a5c55ac9916c3efdbd7b687/lib/client.js#L202
If the metadata is refreshed there on line 202, the bug is resolved.

Can you please try https://github.com/oleksiyk/kafka/commit/e9465eabb5363a05fe4732457ffffd911e2baa3e ?
If its OK I will the publish new npm version.

@oleksiyk https://github.com/oleksiyk/kafka/commit/e9465eabb5363a05fe4732457ffffd911e2baa3e indeed fixes the issue. Thank you very much for such quick turnaround.
I'd also gently ask you to rebase the https://github.com/oleksiyk/kafka/tree/3.0 branch with master (our team is using it for the round robin producer strategy) - or we can just fork.


design unit tests

Makes the core design tests actual unit tests.

Codecov Report

Merging #499 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #499   +/-   ##
=======================================
  Coverage   74.24%   74.24%
=======================================
  Files          55       55
  Lines        3980     3980
=======================================
  Hits         2955     2955
  Misses       1025     1025

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104af13...02cad2b. Read the comment docs.

This all looks good, but are you sure you actually ran these? you need these lines:
if __name__ == '__main__':
  absltest.main()

at the end of the file to get these tests to run.

Actually if you use pytest you don't need that (It doesn't load modules as 'main'. But you're right it will not run the test now if you run just python [test].py so I'll add those

Ah you're right, I think there's some other test-runner that I used that actually runs things as main that bit me once a long while ago. ;)

Actually it does turn out the files have to end with _test to be found by pytest. I fixed that now. The annoying things is pytest doesn't complain when you pass a file explicitly but doesn't find the file when you pass a directory.


It's no use just saying 'run this command...'

[Enter feedback here]
Wouldn't it be nice if, just for once, the instructions stated exactly how to run the powershell commands. If I follow the instructions as they read currently, I just get the red text 'this isn't recognised as a powershell command'. It's all very well assuming that we're all  assimilated into the powershell collective, but we're not.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddd7dc27-98e4-d56e-1ac5-a59aab428b57
Version Independent ID: 4c1e580a-e1a8-f3c6-6b52-65665e8c16e4
Content: Azure AD Connect sync: Prevent accidental deletes - Microsoft Entra
Content Source: articles/active-directory/hybrid/how-to-connect-sync-feature-prevent-accidental-deletes.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@alanbmhs
Thanks for your feedback! We will investigate and update as appropriate.

Thank you for submitting this issue.  Unfortunately, due to high volumes I was unable to respond to this in a timely manner.  At this point, I am going to close this due to it's age and the possibility that it may have been addressed.  If this is still a problem, please consider submitting a new issue.  Thank you.
#please-close


Implement the snapshot cache

This PR makes the final tweaks to implement and migrate to the snapshot cache. A few notes on how this is accomplished:

The wokerpool is further simplified to just take a single function, while the logging is moved to the scheduleUpdate method. Doing this helped keep some of the tests that previously expected us to be able to "send" a response, but with the new cache we don't directly send responses.
Server readiness variable removed, since it is only ever set to true by the time the server turns on.
Proxy version is no longer stored on the proxy, neither are "subscribed resources", since we always recalculate the whole set.
Switch the http_connection_manager name back to the wellknown name due to https://github.com/envoyproxy/go-control-plane/pull/589
All of the request objects are no longer passed into the NewResponse methods, so no need to deal with those edge cases. That allows us to remove a lot of code, and a the test cases for that code.
The node ID for the sidecar is changed from the XDS cert to the UUID, which is considered more stable due to the ability to rotate trust domains.

Codecov Report

Merging #5056 (8e6a498) into main (ab69461) will increase coverage by 0.99%.
The diff coverage is 56.52%.

:exclamation: Current head 8e6a498 differs from pull request most recent head 24ee2f6. Consider uploading reports for the commit 24ee2f6 to get more accurate results

@@            Coverage Diff             @@
##             main    #5056      +/-   ##
==========================================
+ Coverage   68.83%   69.82%   +0.99%
==========================================
  Files         214      211       -3
  Lines       16025    15588     -437
==========================================
- Hits        11031    10885     -146
+ Misses       4934     4646     -288
+ Partials       60       57       -3

Flag
Coverage Δ

unittests
69.82% <56.52%> (+0.99%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/envoy/ads/grpc.go
74.57% <ø> (+10.80%)
:arrow_up:

pkg/envoy/proxy.go
87.69% <ø> (+2.50%)
:arrow_up:

pkg/envoy/types.go
33.33% <ø> (ø)

pkg/envoy/ads/cache_callbacks.go
5.94% <23.07%> (+5.94%)
:arrow_up:

pkg/envoy/ads/cache_stream.go
44.56% <44.82%> (+44.56%)
:arrow_up:

pkg/envoy/ads/server.go
66.66% <50.00%> (+10.14%)
:arrow_up:

pkg/envoy/ads/health.go
100.00% <100.00%> (ø)

pkg/envoy/cds/response.go
90.74% <100.00%> (ø)

pkg/envoy/eds/response.go
100.00% <100.00%> (+24.52%)
:arrow_up:

pkg/envoy/lds/response.go
63.15% <100.00%> (ø)

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


RuntimeError: size of dimension does not match previous size, operand 1, dim 0.

I don't konw how to solve this problem,><,谢谢大家了
Traceback (most recent call last):
File "train.py", line 177, in
main()
File "train.py", line 88, in main
metrics = engine.train(trainx, trainy[:,0,:,:])
File "/home/mist/Graph-WaveNet-master/engine.py", line 17, in train
output = self.model(input)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/mist/Graph-WaveNet-master/model.py", line 192, in forward
x = self.gconv[i](x, new_supports)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/mist/Graph-WaveNet-master/model.py", line 36, in forward
x1 = self.nconv(x,a)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 727, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/mist/Graph-WaveNet-master/model.py", line 13, in forward
x = torch.einsum('ncvl,vw->ncwl',(x,A))
File "/usr/local/lib/python3.6/dist-packages/torch/functional.py", line 342, in einsum
return einsum(equation, *_operands)
File "/usr/local/lib/python3.6/dist-packages/torch/functional.py", line 344, in einsum
return _VF.einsum(equation, operands)  # type: ignore
RuntimeError: size of dimension does not match previous size, operand 1, dim 0

Were you able to figure out this issue?


[BUG] Spaced Repetition Plugin, Deck Dropdown not visible

Describe the bug
When using the Theme, the Dropdown button for Subdecks is not visible/clickable. Thus preventing me from expanding a Deck to it's subdecks.
To Reproduce
Steps to reproduce the behavior (this is an example):

Install the Spaced Repetition Plugin (https://github.com/st3v3nmw/obsidian-spaced-repetition)
Create a few flashcards, using nested Tags as Deck structure
Open the Flashcard Review (Per clicking on the icon on the left or per command "Review flashcards from all notes")
Only base Tag is shown without the option to expand

Expected behavior
The expand button is visible and clickable.
Screenshots
In Snactum:

In Obsidian Standard Theme:

Expanded:

Version [Desktop or Mobile]: Desktop
Additional context
Using the latest Insider build (0.13.5).

Hi! I have a suspicion about what might be doing that, and should be out next update. Either way, it's been added to the Roadmap!

Thank you!

Please confirm if the issue has been fixed! :)

Yes, it works perfectly now, thank you!


Uncaught SyntaxError: Unexpected token { in JSON at position 1   at http://localhost:9876/context.html:1

I am getting this weird error, and I cannot figure out what the source of the error is:
$ karma start
Chrome 60.0.3112 (Mac OS X 10.12.6) ERROR
  Uncaught SyntaxError: Unexpected token { in JSON at position 1
  at http://localhost:9876/context.html:1

Chrome 60.0.3112 (Mac OS X 10.12.6): Executed 0 of 0 ERROR (0.248 secs / 0 secs)

If anyone has any ideas please help! thx

I looked into this, and this appears to be the context.html file which gets rendered:
<!DOCTYPE html>
<!--
This is the execution context.
Loaded within the iframe.
Reloaded before every execution run.
-->
<html>
<head>
  <title></title>
  <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no" />
</head>
<body>
  <!-- The scripts need to be in the body DOM element, as some test running frameworks need the body
       to have already been created so they can insert their magic into it. For example, if loaded
       before body, Angular Scenario test framework fails to find the body and crashes and burns in
       an epic manner. -->
  <script src="context.js"></script>
  <script type="text/javascript">
    // Configure our Karma and set up bindings
    %CLIENT_CONFIG%
    window.__karma__.setupContext(window);

    // All served files with the latest timestamps
    %MAPPINGS%
  </script>
  <!-- Dynamically replaced with <script> tags -->
  %SCRIPTS%
  <script type="text/javascript">
    window.__karma__.loaded();
  </script>
</body>
</html>

it looks like it's being rendered improperly by Karma itself, but I have no idea how

this was my bad, my front-end code was causing the error, not sure if there is anything Karma can do to tell the user that the error is their fault.


TODO: Bump AWX Operator version to 2.6.0

Issues for backup: https://github.com/ansible/awx-operator/issues/1570, https://github.com/ansible/awx-operator/issues/1572


SHAP Values Sum Values Shape Doesn't Match Data Shape

Hi there, I am a bit confused about the shape for values and data attributes after using the .sum() method. As shown in the figure below, when I sum up SHAP values across different samples, I got 729 different values but only 77 items. But when I use the bar plot, the number of features match the number of values (729). I want to perform some sorting to get the top important features, but in this case if the shapes mismatch I don't know how to do it. Could anyone explain to me why they are different, and how can I get the shapes aligned so that I can perform the sorting? Thanks a lot!

NVM I found that  the .feature_names attribute aligns with the .data attribute and that's what I want.


Extract AbstractTrackingListener for Blameable, IpTraceble and Timestampable listeners

In this PR i've extracted AbstractTrackingListener for Blameable, IpTraceble and Timestamaple listeners.

can you rebase it?

@l3pp4rd Done

thanks ;)


Docker method deprecated

As said in #459 updating the docs and deleting the docker files.

Nice one!
It’s ok for now, but your commit message is slightly wrong (see CONTRIBUTING.md, the message would be more like build: deprecate docker development support

Also, you can use Closes, close, fix, fixes before an issue number to close the issue automatically when the PR gets merged in:
Closes #459.


Inline attachments are included in forwarded messages

Resolves #2490
I can reproduce the issue by forwarding the following mail:
To<EMAIL_ADDRESS>From<EMAIL_ADDRESS>Subject: inline attachment
Message-ID: <XXX>
Date: XXX
User-Agent: XXX
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="------------6DA55383243B64A886F2E3C6"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6DA55383243B64A886F2E3C6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

text with image 1x1 test

--------------6DA55383243B64A886F2E3C6
Content-Type: multipart/related;
 boundary="------------84EA168083F5E842FCF139D3"

--------------84EA168083F5E842FCF139D3
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

    <meta http-equiv="content-type" content="text/html; charset=UTF-8">

text with image  test

--------------84EA168083F5E842FCF139D3
Content-Type: image/png;
 name="1x1.png"
Content-Transfer-Encoding: base64
Content-ID: <part1.09AEA62C.20716EEE>
Content-Disposition: inline;
 filename="1x1.png"

iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAIAAACQd1PeAAAADElEQVQI12P4//8/AAX+Av7c
zFnnAAAAAElFTkSuQmCC
--------------84EA168083F5E842FCF139D3--

--------------6DA55383243B64A886F2E3C6--

Thanks for the pull request :+1:
I currently don't have the bandwidth to review your changes. I'm hoping I'll get to it next week.

:+1:, no problem :-)


Fix typo in filename of /tmp/autosens-completed

Fix a typo that would cause completed_recently in oref0-autosens-loop.sh to always be false. This effectively disabled a feature that was supposed to make autosens recalculation happen less frequently when under high load.

Thanks.  Merged, and cherry-picked to dev as well.


Use error message as exception error

As discussed with @weppos we should use the actual error message instead of the code as the Exception message.

@weppos not sure how you have handled this in other clients but I don't think all exceptions will have an error message (or a JSON format for that matter). What have you done for unexpected exceptions there (if anything)?

What have you done for unexpected exceptions there (if anything)?

Do you have any specific examples?

@weppos any crash like the one that was happening the other day due Librato on Sandbox. I mean unhandled exceptions that come through because the API is crashing. I would like those errors not to also crash the client.
I think the client will crash for those cases because the body won't be JSON.

@weppos any crash like the one that was happening the other day due Librato on Sandbox.

I wish we'd have captured the error. In theory, we should always return a JSON message. In case of 500, I believe we do. There are however a very few circumstances where we don't (e.g. 502 Timeouts at Nginx level) where the response won't be JSON (as you pointed out).
I honestly din't cover these cases in the other clients, but it's a fair point.
In theory, all the 4xx errors should be safe. 5xx are a little bit tricky, and perhaps we need to check the content type before attempting to deserialize it (I'm speaking out of loud while thinking...).
Ideally, I'd like to avoid the need for developers to access the underlying HTTP response to extract common data (and an error message falls into this category).

Ideally, I'd like to avoid the need for developers to access the underlying HTTP response to extract common data (and an error message falls into this category).

This makes total sense to me. In fact we should do something about this to be able to extract validation errors when 4xx occur because those are not part of the message (I think we are not handling this yet).

I've checked what nginx is returning:

I think we can use the response content-type to decide to use the code as the message (as we were doing prior to this PR) or the JSON message.

@weppos updated the PR. Let me know what you think.

:+1:


can not package electron app

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Packager Version:

Electron Packager 14.2.1
Node v13.8.0
Host Operating system: win32 10.0.18363 (x64)

Electron Version:

9.0.3

Operating System:

Windows 10 (18363)

Last Known Working Electron Packager version::

no

Expected Behavior
package the app to exe application
Actual Behavior
package error
the cmd code:
electron-packager ./
the error message:
Packaging app for platform win32 x64 using electron v9.0.3
ENOENT: no such file or directory, rename 'C:\Users\ADMINI~1\AppData\Local\Temp\electron-packager\win32-x64\electrion-test-win32-x64\electron.exe'  ->
'C:\Users\ADMINI~1\AppData\Local\Temp\electron-packager\win32-x64\electrion-test-win32-x64\electrion-test.exe'
just run the project is ok with the cmd: npm run start
To Reproduce

Additional Information

Thanks for filing an issue! In order to help you with your problem, we're going to need more information about it. In particular:

Console output when you run electron-packager with the environment variable DEBUG=electron-packager (instructions for Windows and non-Windows). Please include the stack trace if one exists.

Please provide either a failing minimal testcase (with code) or detailed steps to reproduce your
problem. Using electron-quick-start is a good starting point.


split parser.py into individual tld files

since the file is nearly 3000 lines long.
also allows for easier new tld/patch submissions.

good idea - feel free to submit a PR for this

why was this issue closed? doesn't seem to be completed yet

feel free to submit a PR for this. I don't keep PR's for feature requests open because a lot of people have ideas but few are willing to implement them.

FYI, I have a fork that dynamically loads the modules from a package directory using importlib. This avoids the need to:

Have hundreds of imports, one for each tld-specific WhoisEntry class
Have a gigantic if ... elif ... elif ... elif ... block

To avoid the if ... elif ... elif ..., I added a property to the WhoisEntry classes to specify the domain- e.g.
class WhoisCom(WhoisEntry):
    """Whois parser for .com domains
    """
    TLD = '.com'
    not_found = 'No match for "'
    regex = { ... }
    ...

When the main package is loaded, a mapping is created of TLD -> (domain-specific) WhoisEntry class. This way rather than the conditional block, it just tries to pull from the mapping, and if not found, returns a fallback WhoisEntry class. In the end it's functionally equivalent to the way it works now
I considered submitting this as a PR but it's relatively invasive and I haven't had the time to properly test it (I use it for thousands of TLDs and gTLDs regularly, but this doesn't really suffice for proper testing)
@richardpenman do you have the appetite for changes of this magnitude or is that something you'd like to avoid at the moment? I realize you're probably managing this project entirely on your own with little or no sponsorship (and that's appreciated, by the way)
I figure one of the three are the options:

Submit as PR to master
Submit as PR to some alpha/development branch
Maintain a public fork, adhering to the license and credit requirements (and maybe eventually merging upstream at some point)

@mzpqnxow yes I would be happy with a PR for this using pgkutil!


portfolio issue

try to understand the portfolio section! yay! @elauervose
original: http://demo.codepark.co/floyd/

started a branch about this but got stuck on some tricky positioning. Have a hacky work-around but it's really not responsive :frowning:


Updates to getPosition typings - Issue #623

PR to address the typing issue with the getPostion method identified as part of #623.
Have changed the type and updated the associated test case.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f8a073c) to head (58a3250).
Report is 72 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##              main      #624    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           11        11
  Lines          393       511   +118
  Branches        21        25     +4
==========================================
+ Hits           393       511   +118

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

src/dealing/DealingAPI.ts
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


dummy2 won't work in windows 10 1903

when call nt!IoCreateDriver, the target page is uncommitted. can you fix it?

Call 1-800-ORACLE for help. Seriously wtf.


Add the cache, tool, and misc API endpoints

This adds all the cache, tool, and misc API endpoints, except for the /tasks endpoint.

Thanks! I think these are all of them.


Difference size of rgb and origins lead to Index out of error

shuffled_inds between 0 to 120*68*11=89760
but x has range only from 0 to 71*40*3*11=31240
I don't know how to reduce the size of rgb data or the other

It seems like your cameras do not match your images for some reason. They are quite small so it might be a rounding issue.

@FavorMylikes @keunhong I've found that this error comes when I put train_dataset as video of Mac(no error at this point) or iPhone(error). Maybe resize issue?


ProviderRepository::loadManifest assumes services.json is not empty

When server disk space fills up it is possible for an empty services.json to be written to disk. Subsequent requests will fail because ProviderRepository::loadManifest assumes that services.json is never empty.  The error in the log file will vary, but it usually looks something like this:

[17-May-2016 19:57:12 UTC] PHP Fatal error:  Call to undefined method Illuminate\Support\Facades\Auth::user() in /app/laravel/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php on line 207

That is not the real error though, because that error is caused by some application-level error handling code that expects Auth::user() to be defined.  It is not defined because laravel's bootstrap process fails before services can be registered.  The services aren't registered because of the actual error, which is contained in the inner exception:

[message:protected] => array_merge(): Argument #2 is not an array
[string:Exception:private] =>
[code:protected] => 0
[file:protected] => /app/laravel/vendor/laravel/framework/src/Illuminate/Foundation/ProviderRepository.php
[line:protected] => 174

This is the loadManifest() method around line 174 of ProviderRepository.php:
    public function loadManifest()
    {
        // The service manifest is a file containing a JSON representation of every
        // service provided by the application and whether its provider is using
        // deferred loading or should be eagerly loaded on each request to us.
        if ($this->files->exists($this->manifestPath)) {
            $manifest = json_decode($this->files->get($this->manifestPath), true);

            return array_merge(['when' => []], $manifest);
        }
    }

$manifest, which is passed as argument 2 to array_merge, is not an array because ProviderRepository::loadManifest() doesn't check the return value of json_decode(), which is null when services.json is empty.
To fix this, I changed this code in Illuminate/Foundation/ProviderRepository::loadManifest()
            return array_merge(['when' => []], $manifest);

to:
            if ($manifest) {
                    return array_merge(['when' => []], $manifest);
            }

Thanks for the report. I'll fix this shortly. ;)

Please confirm https://github.com/laravel/framework/pull/14030 works for you. ;)

I don't think that fix will work because I tried something similar previously.  The problem with that fix is that if loadManifest() returns an array then ProviderRepository::load() will store the array in $manifest and pass it to ProviderRepository::shouldRecomple().  Inside that function, if $manifest is not null then shouldRecompile() attempts to access $manifest['providers']. That will fail because $manifest doesn't have an array key called "providers".  It only has a single array key called "when".
I think the proper fix is to make sure loadManifest returns null when json_decode returns null.  That will guarantee that shouldRecompile returns true by short-circuiting the || condition before it tries to access an array key that doesn't exist in $manifest.

Ah, ok. Thanks. I'll modify my PR. ;)

Looks good now.  Thank you!

Thanks for reporting. :)

I'm getting a similar error, which seems to happen randomly, when using https://github.com/brianium/paratest
The issue is that, for some unclear reason, $manifest might not be an array, so it fails to merge.
Not sure if anyone else could be facing the same issue, but this might be a better check:
if (is_array($manifest)) {
instead of
if ($manifest) {

Same with fastest https://github.com/liuggio/fastest
$this->manifestPath = /var/app/current/src/vendor/orchestra/testbench-core/src/Traits/../../laravel/bootstrap/cache/services.php
$manifest = 1


File decorations in PR treeview are not colorized in web

Extension version: latest prerelease
VSCode Version: 1.68-insider
OS: Windows 11

Steps to Reproduce:

Open a PR in insiders.vscode.dev
Open the treeview
:bug: the Modified file decoration is not colored:

On desktop it looks like this:

Remote Repos had an issue with this at one point that turned out to be a core bug where contributed color token names with more than one . weren't correctly parsed, but that has been fixed and I'm unsure if this is related.

This is happening because GHPRI relies on the git extension colors (ex. gitDecoration.modifiedResourceForeground) existing to color file decorations.
When the git extension isn't installed we need to rely on the equivalent Remote Repositories colors.


Extend trusted fact support to function testing

Add support for testing with trusted facts within functions.

@DavidS Sorry I didn't have this included on the first go-around for #400 . It didn't originally occur to me that custom functions would be tested in a different context than classes. Based on what I see in lib/rspec-puppet/example I believe that functions were the only gap. Thanks!

Coverage increased (+0.05%) to 91.982% when pulling 64d03312bee0f1e01c0ada9c1899218502fe6ffc on seanmil:trusted_facts_functions into 8fa3c28b57aa07e008af0d70235acb83464546a8 on rodjek:master.

Don't feel guilty about it. I could have remembered too.
It's fixed now, so no harm done.


bad markdown link on https://www.kubeflow.org/docs/guides/upgrade/

It shows
Use the script (upgrade_ks_app.py)[https://github.com/kubeflow/kubeflow/tree/master/scripts) to update your ksonnet app with the current version for the Kubeflow packages

and should be
Use the script (upgrade_ks_app.py)[https://github.com/kubeflow/kubeflow/tree/master/scripts] to update your ksonnet app with the current version for the Kubeflow packages

note that the link is missing ] and instead has )

The square and round brackets need to be swapped around too, like this:
[upgrade_ks_app.py](https://github.com/kubeflow/kubeflow/tree/master/scripts)

/help
/good-first-issue
/area docs

/assign


Add filter plugin

Added filter plugin.
Please note that this change does not use v0.14 new API yet, but works with v0.14 using its compat layer.

@glidenote Could you add me to gem owner so that I can release a gem?
You can add me like:
gem owner fluent-plugin-tai64n_parser -a<EMAIL_ADDRESS>

@sonots I added you. https://rubygems.org/gems/fluent-plugin-tai64n_parser
And Thank you for maintain this plugin. 😂

@glidenote Thanks! 0.2.0 is released!


Use an HTTP/1.1-only client for exec

Fixes #1396

Codecov Report

Merging #1464 (b6148c5) into main (6aa8893) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1464      +/-   ##
========================================
- Coverage   9.06%   9.05%   -0.01%
========================================
  Files         79      79
  Lines       7581    7585       +4
========================================
  Hits         687     687
- Misses      6849    6853       +4
  Partials      45      45

Flag
Coverage Δ

unittests
9.05% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/api/v1/application/exec.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa8893...b6148c5. Read the comment docs.

Tested successfully on Digital Ocean ✅
Steps used to test the fix:

Create a cluster on DO
Clone the branch 1396-fix-exec
Install cert-manager, traefik
Create DNS in route53
Deploy epinio with custom DNS and letsencrypt
Build and patch epinio to use the fix
Deploy an app and check app exec feature

🕞  Creating application resources
✔  App is online.
Name: sample
Namespace: workspace
Builder Image:
Routes:
1: https://sample.julien-do.aws.howdoi.website/
vagrant@k3s-opensusetw:~/epinio/assets> epinio app list

🚢  Listing applications
Namespace: workspace

✔  Epinio Applications:
|  NAME  | STATUS |               ROUTES                | CONFIGURATIONS | STATUS DETAILS |
|--------|--------|-------------------------------------|----------------|----------------|
| sample | 1/1    | sample.julien-do.aws.howdoi.website |                |                |
vagrant@k3s-opensusetw:~/epinio/assets> epinio app exec sample

🚢  Executing a shell
Namespace: workspace
Application: sample
cnb@rsample-8151325dcdbae9e0ff95f9f9658432dbedfdb209-67c456b8888d6c:/$
cnb@rsample-8151325dcdbae9e0ff95f9f9658432dbedfdb209-67c456b8888d6c:/$


update to schema v2.0.7 in preparation for 2021.06 submission

Pull Request Test Coverage Report for Build 863459222

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.415%

Totals

Change from base Build 863379577:
0.0%

Covered Lines:
834

Relevant Lines:
1136

💛  - Coveralls


Add aksctl

https://github.com/nicholasdille/packages/blob/master/packages/a/aksctl/package.yaml

See #5232


Question: Automatic WS reconnection on network interrupts

First of all, thank you for this library! I'm using it with WebSockets to power a Vue-based info dashboard.
I'm now wondering how to handle network interrupts with u8-mqtt. mqttClient.on_reconnect = (m) => console.log("Reconn") shows me in the console that apparently it notices no longer being connected, but I don't see any attempts to reestablish a WS connection in the network tab.
Is this intentional (should I take care of it myself?) or am I missing something else?

Thanks for your question!
From reviewing my code, the on_reconnect() callback is triggered upon connection close (in with_websock() close handler in code/core.jsy), stream end (in with_async_iter() of code/core.jsy), or a call to mqttClient.disconnect().
So yes, your user code is responsible what you want to do for reconnection, if anything. The initial use case I started the project for did not require long-lived connections, so I did not need this functionality at the time. I welcome your suggestions on what you might like to see happen for a new revision of the client.
I believe the MQTT spec allows reconnecting with the same client ID and the server will resume existing subscriptions for that ID if the connection was interrupted. However, an explicit disconnect mqtt packet sent directs the server to clear out the state for that Client Id.

Really appreciate your detailed answer.
For my small (hobbyist level) dashboard project, automatic connection recovery is a bit of a must to always display the latest data. I don't know if I would be able to implement this feature myself properly, so I would actually be happy to see it in one of the next versions of the client.

Just saw the commit implementing this feature. Incredible, thank you so much!
I tested it in my project and it seems to be working.
I hope it's okay if I ask a few (un)related questions here.

Is there an event/a way to be notified in case of disconnects?
Without overwriting on_live, starting from 0.2.0-0, the WS connection appears to close itself immediately. Overwriting on_live fixes this. All of my app logic still lives outside this function, e.g. subscribe_topic and on_topic. I suspect that's not exactly the way it is intended to be used, or is it?

Thanks for testing the new version directly from git!
On question 1, on_reconnect was the correct answer. I realized I didn't like the event name and wanted to pass an additional parameter. I've introduced on_disconnect(client, intentional) to provide more information. Additionally, with_autoreconnect() provides a default implementation of on_reconnect, which is now called by the default implementation of on_disconnect.
On question 2, multiple calls to client.connect() cause MQTT servers to hang up the connection due to a protocol error. I've moved the default reconnection implementation case into on_disconnect in the case the user doesn't provide an on_live handler.
Please keep the testing and questions coming. They are very much appreciated!

With pleasure! I was so happy to see the commit that I had to test it right away :)
So assuming I don't want to touch/override the internal reconnect logic at all, but just want to know when the client is (re)connected (or disconnected), I was expecting it could work like that, but it appears to be too intrusive and fails.
mqttClient = mqtt_client().with_websock(MQTT_ADDR).with_autoreconnect()
mqttClient.on_live = (c) => console.log("Connected")
// mqttClient.on_reconnect = (c) => console.log("Reconnected")
mqttClient.on_disconnected = (c, intentional) => console.log("Disconnected")
mqttClient.connect()

You are correct, adding on_live, on_reconnect, or on_disconnect indicates your client wants to override the default behavior.
To that end, I've reduced the amount of logic each of those hook defaults are doing and I've added a log_conn(evt, arg, err_arg) hook specifically for visibility into connection changes for you.
mqtt_client({
  log_conn(evt, arg, err_arg) {
    console.info('[[u8-mqtt log: %s]]', evt, arg, err_arg)
  },
})

The with_autoreconnect() method installs a default on_reconnect implementation to reconnect after a delay. The default implementations for on_live, on_ready, and on_disconnect hooks:
mqtt_client({
  on_live(client, has_connected) {
    if (has_connected)
      return client.connect()
  },
  on_ready(client) {
  },
  on_disconnect(client, intentional) {
    if (! intentional && client.on_reconnect)
      return client.on_reconnect()
  },
})

I'll add this to the documentation when this iteration stabilizes and I publish v0.2.0.

Excellent, log_conn is exactly what I was looking for, thank you for implementing it for me specifically!
Out of curiosity: Why did you decide not to use the camelCase naming convention?

Thanks for using this library and providing feedback!
Regarding my naming conventions, it has been more of stylistic habit than an explicit decision. Culturally, I've written a lot of Python and C/C++ that tend to prefer naming with underscores. I hadn't noticed how consistently builtin JavaScript APIs use camelCase.

It's rare to find in the JS world, but then again, snake_case appears to be the more readable one of the two. I'm using Python quite often as well, so I'm clearly leaning towards that convention, but for the sake of consistency, I'm forcing myself to apply both of them in my projects according to the respective environment. In the end, of course, it does not matter much, does it.

Published in v0.3.0


Handle contrib apps

And apps with dots in their app_label.
Currently:
'django.contrib.comments.Comment' -> ('django', 'contrib', 'comments', 'Comment')
With this change:
'django.contrib.comments.Comment' -> ('django.contrib.comments', 'Comment')

@sheppard I, too, would be very grateful if you would approve this pull request. I was about to make an identical fix but happily, blag beat be to it.
Until this issue is fixed, we are also unable to specify a model in a subpackage or submodule such as myapp.models.Model.

Sorry, this slipped off my radar.  Merged and released as 1.1.0.

No worries, thanks!