Error when deploying using Cloudformation templates

We have pipeline deploying All dashboards deploying through cloudformation.
we're getting this error in Cloudformation .
Received response status [FAILED] from custom resource. Message returned: Error: An error occurred (AccessDeniedException) when calling the DescribeTemplate operation: User: arn:aws:sts::<Account-Number>:assumed-role/CidExecRole/CidCustomResourceDashboard is not authorized to perform: quicksight:DescribeTemplate on resource: arn:aws:quicksight:us-east-1:223485597511:template/ta-organizational-view with an explicit deny in a service control policy - Cannot find ta-organizational-view in account<PHONE_NUMBER>11. See more: https://ap-southeast-2.console.aws.amazon.com/cloudwatch/home?region=ap-southeast-2#logEvent:group=/aws/lambda/CidCustomResourceDashboard;stream=2024/06/21/[$LATEST]2b6acd66594a403a91078ec60d74bcaf (RequestId: 045b07fb-c81c-427c-b23c-5c0eff7f0341)

Cloudwatch link has log from Lambda which also have the same error.
94d00ba5-dd81-42bd-aca0-5e55c2b6fb39	An error occurred (AccessDeniedException) when calling the DescribeTemplate operation: User: arn:aws:sts::<Account-Number>:assumed-role/CidExecRole/CidCustomResourceDashboard is not authorized to perform: quicksight:DescribeTemplate on resource: arn:aws:quicksight:us-east-1:223485597511:template/compute_optimizer with an explicit deny in a service control policy
Traceback (most recent call last):
  File "/opt/python/cid/helpers/quicksight/__init__.py", line 1039, in describe_template
    result = client.describe_template(**parameters)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/botocore/client.py", line 565, in _api_call
    return self._make_api_call(operation_name, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/botocore/client.py", line 1021, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.AccessDeniedException: An error occurred (AccessDeniedException) when calling the DescribeTemplate operation: User: arn:aws:sts::<Account-Number>:assumed-role/CidExecRole/CidCustomResourceDashboard is not authorized to perform: quicksight:DescribeTemplate on resource: arn:aws:quicksight:us-east-1:223485597511:template/compute_optimizer with an explicit deny in a service control policy
[DEBUG] 2024-06-21T05:38:26.647Z 94d00ba5-dd81-42bd-aca0-5e55c2b6fb39 An error occurred (AccessDeniedException) when calling the DescribeTemplate operation: User: arn:aws:sts::<Account-Number>:assumed-role/CidExecRole/CidCustomResourceDashboard is not authorized to perform: quicksight:DescribeTemplate on resource: arn:aws:quicksight:us-east-1:223485597511:template/compute_optimizer with an explicit deny in a service control policy Traceback (most recent call last): File "/opt/python/cid/helpers/quicksight/__init__.py", line 1039, in describe_template result = client.describe_template(**parameters) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/python/botocore/client.py", line 565, in _api_call return self._make_api_call(operation_name, kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/python/botocore/client.py", line 1021, in _make_api_call raise error_class(parsed_response, operation_name) botocore.errorfactory.AccessDeniedException: An error occurred (AccessDeniedException) when calling the DescribeTemplate operation: User: arn:aws:sts::<Account-Number>:assumed-role/CidExecRole/CidCustomResourceDashboard is not authorized to perform: quicksight:DescribeTemplate on resource: arn:aws:quicksight:us-east-1:223485597511:template/compute_optimizer with an explicit deny in a service control policy

223485597511 account doesn't belong in our org.
Deployment command
	aws cloudformation deploy --stack-name Cloud-Intelligence-Dashboards \
		--template-file aws-cudos-framework-deployment/cfn-templates/cid-cfn.yml \
		--s3-bucket some-bucket-<Account-Number> \
		--s3-prefix cloudformation/packages/cid-data-collection \
		--parameter-overrides CURBucketPath="s3://cid-<<Account-Number>>-shared/cur/" \
		DeployTAODashboard=yes \
		DeployComputeOptimizerDashboard=yes \
		DeployCostIntelligenceDashboard=yes \
		DeployCUDOSDashboard=no \
		DeployCUDOSv5=yes \
		DeployKPIDashboard=yes \
		LakeFormationEnabled=no \
		GlueDataCatalog=AwsDataCatalog \
		LambdaLayerBucketPrefix=aws-managed-cost-intelligence-dashboards \
		OptimizationDataCollectionBucketPath=s3://cf-cid-data<Account-Number>/ \
		PrerequisitesQuickSight=yes \
		PrerequisitesQuickSightPermissions=yes \
		PrimaryTagName=owner \
		QuickSightDataSourceRoleName=CidQuickSightDataSourceRole \
		QuickSightUser=OrganizationAccountAccessRole/<someuser> \
		RolePath=/ \
		SecondaryTagName=environment \
		--capabilities CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND

Please check that this action is not prohibited with scp in your org.
I confirm cid needs access to quicksight templates in this account and us-east-1 region to deploy foundation dashboards. This is a documented requirement.

Thanks alot for quick response @iakov-aws ,
Is there a list of actions that we need to allow in us-east-1 region? or does this require quicksight:*.

Just DescribeTemplate

Thanks alot @iakov-aws


Allow CRS (Common Reference String) to be pre-downloaded and pointed to through setting

Problem
As a user of the backend (package in case of Nargo CLI)
I would like to be able to point the backend to a directory where CRS data already exists
so that I can pre-download CRS data upfront to support caching and no network access scenario.
Proposed solution
Enable env variable setting to support reading CRS data from file
Alternatives considered
No response
Additional context
No response
Submission Checklist

[X] Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.

I believe this conflicts with https://github.com/noir-lang/noir/issues/1302

Won't do since acvm-backend-barretenberg will be decomissioned.


Support cwd of current package inside monorepo

I am using this plugin in a monorepo with several modules. In my case, I have configured jestrunner.jestCommand to be yarn test (which in my case executes vitest instead of jest).
By default, vscode-jest-runner executes the command on the root level of my monorepo. I would like it to execute on the root level of the individual NPM package instead, for several reasons:

I don't have jest (or in my case vitest) installed on the root level
The implementation of my yarn test command might be different for each module

Since #156, the project path is automatically detected based on where a package.json file and a node_modules/.bin/jest file is present. In case of a monorepo, this will only result in my desired behaviour if the modules have different versions of jest installed. If they all have the same version, node_modules/.bin/jest will be available on the root level of the repo.
As a workaround, I currently have jestrunner.changeDirectoryToWorkspaceRoot set to false and manually cd into the appropriate directory in the jest terminal before running the tests.
One way this could be achieved would be to add a config option (such as jestrunner.changeDirectoryToPackageRoot) that cds to the nearest ancestor directory containing a package.json file before running a test.
On the other hand, I'm wondering whether this behaviour shouldn't be the default. The location detection for the eslint executable would stay the same as today, but the detection of the cwd would become independent of that and use the closest ancestor directory containing a package.json. Are there any setups that this would break?

similar issue here with monorepo, its cwd is down in the root.  An option to specify the directory through a configuration option so I can use something like a vscode variable reference would help.

you are right, this is a missing feature, some people try to implement it, but this lead to a breaking change for other project.
i think i was this PR: https://github.com/firsttris/vscode-jest-runner/issues/220
Still waiting for someone contribute this option.
Most people use NX for Monorepo, NX installs this extension as recommended extension.
NX has single version policy and all dependencies are in root.
best regards
Tristan

From jestRunnerConfig.ts when it resolves cwd(), it looks for the nearest package, but only if the package has node_modules/jest:
https://github.com/firsttris/vscode-jest-runner/blob/81b797c77eb23fbc5c07a8a953a57b15edf0685a/src/jestRunnerConfig.ts#L64-L74
So the current fallback logic for jestrunner.changeDirectoryToWorkspaceRoot is:

jestrunner.projectPath
(code snippet above) the nearest package.json with jest in it's node_modules folder
${workspaceFolder}

Would it make sense to change (2) to find packages with either jest or vitest in it's node_modules?

Adding support for vitest might be nice, but it does not solve the problem that I describe here.
The problem described here is that dependency hoisting causes jest/vitest to be installed in a different location than where it should be used. For example, the directory layout might look like this:
/
/package.json
/node_modules/.bin/jest
/module1/package.json
/module2/package.json

jest is only listed as a dependency in /module1/package.json and /module2/package.json and test scripts are defined in those files. In /package.json, jest is not defined as a dependency and there is no test script. But vscode-jest-runner would run the tests in /.
If module1 and module2 would for some reason depend on different versions of jest, the directory layout would change into this:
/
/package.json
/module1/package.json
/module1/node_modules/.bin/jest
/module2/package.json
/module2/node_modules/.bin/jest

So vscode-jest-runner would now run the tests inside the respective module folders.
Personally I don't see a use case where in the first case (both modules using the same jest version) the tests should run on the root level of the project. So my recommendation would be to simply remove the check for node_modules/.bin/jest altogether and simply run the tests in the nearest directory that contains a package.json. But maybe there is some use case that I'm not aware of.

This is my exact issue as well. Also, agree that it seems like this would work as the default. But would be happy with an option.


Add Coalesce

This PR adds the Coalesce transformation. The Coalesce(default) transformation replaces all missing values with a default value.

Codecov Report

Merging #40 (a6aac3a) into master (ab30ce9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   92.57%   92.67%   +0.10%
==========================================
  Files          16       17       +1
  Lines         431      437       +6
==========================================
+ Hits          399      405       +6
  Misses         32       32

Impacted Files
Coverage Δ

src/transforms.jl
97.82% <ø> (ø)

src/transforms/coalesce.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab30ce9...a6aac3a. Read the comment docs.

This PR is ready for a final review @juliohm!

Great, feel free to merge after the tests pass. 💯


fix: require<EMAIL_ADDRESS>& handle old Electron versions

Since node-gyp >= 8.4.0, building modules for old versions of Electron requires passing --force-process-config due to them lacking a valid config.gypi in their headers.
See also https://github.com/nodejs/node-gyp/pull/2497.

Codecov Report

Merging #907 (594afc4) into master (c17ee57) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   76.13%   76.09%   -0.05%
==========================================
  Files          19       19
  Lines         683      686       +3
  Branches      130      131       +1
==========================================
+ Hits          520      522       +2
  Misses        118      118
- Partials       45       46       +1

Impacted Files
Coverage Δ

src/module-type/node-gyp.ts
83.33% <66.66%> (-0.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17ee57...594afc4. Read the comment docs.

I have updated the code to add tests.


how to do causal intervention

Hi, it is a great work! But I'm a little confused about your code. As you mentioned in your paper, you have done a causal intervention by using average segmentation masks of different objects. However, I have checked out all your codes, I didn't found any code which is used to introduce average segmentation masks to do a causal intervention. And there is also no code for loading average segmentation masks. Could you please point out where you deal with this? It will be very appreciated that you answer this question!

@JohnDreamer   Thanks for your attention and sorry for the confusion. Intervention is performed in a new round classification. Before this, you should do two things: 1) creating a confounder set via the segmentation mask; 2) calculating  m_{t+1} for each training image via Eq.(3)

@dongzhang89 I think these two things is the main contribution of your paper. I hope you can release all these code, thanks.


modify '竞量' to '尽量' in basic.md

only modify master branch. you should rebuild in service.

非常感谢...


refactor(remote ext): use jsonrpsee

I switched to hyper as HTTP backend  because it's already used in substrate and it's faster but it brings in openssl as a dependency from tokio-tls.
Not sure if you want that.

Waht's the prospect of this?

Waht's the prospect of this?

After https://github.com/paritytech/jsonrpsee/pull/215, I plan to publish an alpha release for the clients

bot merge

bot merge


Federation Server farm limit is 5 or 30?

on this page I see a limit of 5 federation servers per Farm using WID
https://learn.microsoft.com/en-us/windows-server/identity/ad-fs/design/federation-server-farm-using-wid-2012
here you talk about 30 federation servers per Farm using WID. Which is the correct number?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

 We value your feedback.
We recently updated our AD FS documentation to reflect the limit of 30 for WID farms.

https://learn.microsoft.com/en-us/windows-server/identity/ad-fs/design/federation-server-farm-using-wid-2012
https://learn.microsoft.com/en-us/windows-server/identity/ad-fs/design/AD-FS-Deployment-Topology-Considerations
https://learn.microsoft.com/en-us/windows-server/identity/ad-fs/design/federation-server-farm-using-wid

Changes are live. We will now be closing this thread.
Thank you and have a most pleasant day. #please-close


Add support for two-handed items and wielding.

Fire axes, claymores, big dakka etc.

am working on this


Look at passing -o to go test -c.

You might want to consider using -o so that we can control what the binary is named:

-o file
Compile the test binary to the named file.
The test still runs (unless -c or -i is specified).
If file ends in a slash or names an existing directory,
the test is written to pkg.test in that directory.

I already did this, I don't know why I didn't find it originally


@[defaultInstance 1] not working as documented

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
This example from type_classes.md doesn't work:
structure Rational where
  num : Int
  den : Nat

@[defaultInstance 1]
instance : OfNat Rational n where
  ofNat := { num := n, den := 1 }

instance : ToString Rational where
  toString r := s!"{r.num}/{r.den}"

#check 2 -- Rational

Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expect to happen]
Output type Rational
Actual behavior: [What actually happens]
Outputs type Nat
Reproduces how often: [What percentage of the time does it reproduce?]
Versions
You can get this information from copy and pasting the output of lean --version,
please include the OS and what version of the OS you're running.
Lean (version 4.0.0-nightly-2021-11-10, commit 8df2b07209d0, Release)
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

I assume this example has never worked correctly since 1 is the lowest priority. The priority is also unnecessary now because the Nat instance's priority has been lowered since. The example might have to be reworked or replaced with a different one. It, or the text, should probably also introduce the priority shorthands low and high.

Not transferring since the same example is found in doc/typeclass.md.


Parse Universal Analytics Enhanced Ecommerce

Sean,
what do you need for that ?
example hits here:
https://enhancedecommerce.appspot.com/
https://ga-dev-tools.appspot.com/enhanced-ecommerce/


Match incoming FPS and aspect ratio

What does this pull request do? Explain your changes. (required)

We need to be able to match incoming stream fps to an existing profile in VIDEO_PROFILES in packages/sdk/src/index.js
We should be able to derive aspect ratio from incoming stream height and width.

Specific updates (required)

As a temporary solution, add 25fps profiles to VIDEO_PROFILES, mirroring profiles that exist in go-livepeer: https://github.com/livepeer/go-livepeer/pull/1148 (see comments in link for more long-term solutions).
Add sourceInfo object to the request body coming from livepeer-wowza, to be accessed as such:  req.body.wowza.sourceInfo, with the following fields:

"sourceInfo": {
   "width": 1920,
   "height": 1920,
   "fps": 25
}

In addition to using height / width, also use incoming sourceInfo.fps to select correct present.
When width or height in transcoderTemplateAppConfig template comes back as zero, use aspect ratio to fill in correct missing number.

How did you test each of these updates (required)
Test file
Does this pull request close any open issues?
https://github.com/livepeer/livepeerjs/issues/497
Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

@angyangie I just pushed a tiny change to master to ignore this field so that it doesn't break the version of LivepeerWowza I'm releasing just now. https://github.com/livepeer/livepeerjs/commit/dee9a37fda2e1a9bb522de2291bdbb635179deb5
Let me know when this is ready and I'll switch over to the actual logic :+1:


Update to latest version of LambdaHack

How is it going? When recently updating Allure of the Stars wrt LH changes, I've just started over from LH content, added Allure-specific content at the end of files and then reviewed and removed all the LH content that I didn't want or modified it (but not the Haskell names of the content, so that I could keep diffs small). If you post a branch with current progress, I bet I could drop you some hints.

I haven't yet started, so it's not progressing :) Trying to set aside some time this weekend, so I can at least start, if not finish this during the weekend. Thanks for the tip.

Having some issues with dependencies (commit cf5b850):
tuukka@azrael:~/programming/space-privateers$ cabal install
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: SpacePrivateers-<IP_ADDRESS> (user goal)
trying: text-<IP_ADDRESS> (dependency of SpacePrivateers-<IP_ADDRESS>)
trying: binary-<IP_ADDRESS>/installed-f86... (dependency of text-<IP_ADDRESS>)
next goal: LambdaHack (dependency of SpacePrivateers-<IP_ADDRESS>)
rejecting: LambdaHack-<IP_ADDRESS> (conflict: binary==<IP_ADDRESS>/installed-f86...,
LambdaHack => binary>=0.8)
rejecting: LambdaHack-<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>,
<IP_ADDRESS>, 0.2.14, 0.2.12, <IP_ADDRESS>, <IP_ADDRESS>, 0.2.10, 0.2.8, <IP_ADDRESS>, 0.2.6,
0.2.1, 0.2.0, 0.1.20110918, 0.1.20110117, 0.1.20090606, 0.1.20080413,
0.1.20080412 (conflict: SpacePrivateers => LambdaHack>=<IP_ADDRESS> && <<IP_ADDRESS>)
Dependency tree exhaustively searched.

Note: when using a sandbox, all packages are required to have consistent
dependencies. Try reinstalling/unregistering the offending packages or
recreating the sandbox.
tuukka@azrael:~/programming/space-privateers$

Probably have to set upper bounds too.

It says conflict: binary==<IP_ADDRESS>/installed-f86...,LambdaHack => binary>=0.8, which means you have binary <IP_ADDRESS> in your sandbox. I guess, the easiest course of action is to wipe out the sandbox (not the repo) and create a new one.

Hm.. it's not even in the sandbox, but in opt directory:
tuukka@azrael:~/programming/space-privateers$ ghc-pkg list
/opt/ghc/7.8.4/lib/ghc-7.8.4/package.conf.d
...
   binary-<IP_ADDRESS>
...

I wonder why, since I should be using sandbox created with cabal sandbox init.

Oh, I see. I rarely use sandboxes and I have zero globally installed packages ever, I just boostrap from GHC and cabal executable in my home directory, so I'm no sure what to do in this case. Perhaps manually install the new version?

I'll look into bootstrapping in same manner as you do later in the evening as the ghc that I have installed is fairly old.

True. Just download and install https://www.haskell.org/ghc/download_ghc_8_0_2.html, copy over the cabal exe from your old location to somewhere where you can execute it, wipe all old stuff out, including ~/.ghc and ~/.cabal, do 'cabal install cabal-install' and you are set. :)

That was the problem. I installed latest GHC and could then cabal install --dependencies-only without problems. Now I can continue with the original task, updating to the latest LambdaHack version.


carousel component should accept CarouselLibConfig as input and not all parameters, to be consistent with changes made in 8.0.0

In 8.0.0, Carousel is the only component that is still receiving many inputs instead of LibConfig

Implemented, but tests need to be upgraded


Support for other browser vendors

Hi,
Thank you for creating an excellent library.
                 (typeof(File)!=='undefined')
                 &&
                 (typeof(Blob)!=='undefined')
                 &&
                 (typeof(FileList)!=='undefined')

Results from caniuse.com tells us that Opera 12.1 and IE >= 10.. have you done any testing in regards to this?

The main bit in the feature check is:
(!!Blob.prototype.webkitSlice||!!Blob.prototype.mozSlice||Blob.prototype.slice||false)

From what I can see, recent versions of Opera should support Resumble.js. I haven't tested it though. I'm more dubious about Internet Explorer, since the relevant documentation does not mention .slice() at all. Has anyone tested?


Changed the priority list

Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
We already removed these options from the code that's why we shouldn't doc this
Fixes #Issue_Number (if necessary)
https://github.com/MicrosoftDocs/SCCMdocs/issues/908
@Article_Author please review (look at the author metadata tag)

@kerimhanif : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

Thanks @kerimhanif 😄
#sign-off
Once merged, this should be live with the next daily publishing process. Right now that should be tomorrow (Tuesday, 9 October) around 11:00 Pacific time. No further action needed from you.


Building lxd-p2c for i386 fails

Required information

Distribution: Ubuntu
Distribution version: 18.04 amd64
go 1.10.4
LXD git current as of date

Issue description
I am trying to containerise an i386 install of 14.04 under 16.04 amd64 (that is possible, right?) hence I need to cross-compile an i386 binary of lxd-p2c but I get the following errors:
$ env GOOS=linux GOARCH=386 go get github.com/lxc/lxd/lxd-p2c
# github.com/lxc/lxd/lxc/utils
../go/src/github.com/lxc/lxd/lxc/utils/progress.go:28:19: undefined: termios.GetSize
../go/src/github.com/lxc/lxd/lxc/utils/progress.go:108:7: undefined: termios.IsTerminal

I can successfully build lxd-p2c for linux/amd64 on the same machine.

That's because your cross compiling in a way that turns off cgo support.
lxd-p2c builds perfectly well on i386 directly.

The above command now works to cross compile for i386


Feature request/question: MSI support

Are there any plans to include automatic detection and usage of Managed Service Identity on Azure VMs and App Service the way that the Microsoft.Azure.Services.AppAuthentication .NET package does, particularly for the Key Vault starter? This tutorial covers how it works.
MSI makes Key Vault much more compelling.

It looks like usage of MSI credentials is already implemented here. This seems like it would be great to integrate into the starter.

+1

+1
for KeyVault and DataSource

Candidate implementation in https://github.com/Microsoft/azure-spring-boot/pull/407.

AFAIK, #407 seems to only include MSI on App services - not VMs? Would be really good to include support for VMs as well!


Delegated authentication should happen only once

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oops! It seems I'm out of sync with master, will re-sync...

Synced. Waiting for the build to pass...

Out-of-sync again. Waiting for the build to pass (again)...


EVENT TEAM

Recently, we have been handled a survey, and one of the topics we were asked about was: Events.
Events are very important to keep people active, because we know, as soon as a player cap stats is a matter of time before they become inactive while expecting major updates.
I am very aware of how much work requires to run events and I understand the importance of other updates people have been looking forward to,
However, I still think events should be present to keep players active and motivated while LSM is working on the “big things”.
I first suggested creating an Event panel, which would allow forming an Event Team, but that also requires LSM to work actively on it which I'm not sure he has the time for.
So I decided to come up with an alternative proposal.  An event team of 2 persons: one should be skilled at writing stories and the other can just translate those stories into code. It can also be just one person but that is a hell of work for a single guy.  Events could be delivered to LSM and submitted in the premade template.
The template could look something like this:
template
Obviously, the template can be modified to suit LSM’s requirements, to simplify his job as much as possible.
Here is an example of a very basic event (I know it’s a silly one it’s just an example), don’t mind the code as it’s TNR code:
example
I hope this can be taken into consideration.

I love this idea


Prefixed macros

Implemented what I mentioned in #13
Once again, I'll wait with a merge til' later.

Force merged


UX: don't offset the whole script editor when search just opens

Godot 3.0 master
When I use Ctrl+F to use incremental search, it makes this panel appear on top:

But this offsets all lines down, and sometimes also searches first occurrence immediately, which I didn't expect:
https://www.youtube.com/watch?v=mTwckJRsin0&feature=youtu.be
(all I do in this video is pressing Ctrl+F)
Would it be possible to keep lines where they are when this opens, treat this panel like an "overlay"?
Also start the search only when the Enter key is pressed? It would be a good UX improvement.

the panel is in a vBoxContainer WITH the code_editor... So hiding it and showing it resizes both of them. It would be possible to overlay... BUT than it would be impossible to scroll to the top.
maybe it could scroll up by the height of that panel (taking EDSCALE into account)

For reference, here is how it looks like in other editors. None of them scroll until Enter is pressed:
QtCreator:

Notepad++:

Sublime Text:

Visual Studio:

Visual Studio Code:

Putting it at the bottom would be the simplest solution i think!
Top right would not fit with the overall godot design IMO.


WFCORE-5471 Broken links in README

Issue: https://issues.redhat.com/browse/WFCORE-5471

@RanabirChakraborty thanks!


App crashes when image is caching

On Xamarin.Forms app, when the app is first starting up and the images are being loaded for caching, the app crashes. This happens on the prelease of the latest app.
Later tonight, I'll see if I can get the exact exception but I think it was a null reference.

StackTrace would be great. I tried to reproduce it with:
ImageService.Instance.LoadCompiledResource("loading.png").Preload();
ImageService.Instance.LoadUrl("http://loremflickr.com/600/600/nature?filename=simple.jpg").DownloadOnly();

but didn't get any exceptions.

Found the issue. Just call ImageService.Instance.Initialize() before using FFImageLoading.
I'll fix this.

It's fixed, just download 2.2.0-pre-171 package. The exception was thrown when no custom logger was provided. Sorry for that.


[Proposal] support for SR OS variants

Hi @plajjan,
as we briefly discussed, I wanted to propose some breaking changes to the way SR OS nodes are handled by vrnetlab.
Variants
The main change is the introduction of SR OS variants. Variants are the pre-packaged combinations of chassis+card+mda+mode which are defined in the code as a dictionary:
https://github.com/plajjan/vrnetlab/compare/master...hellt:sros-enhancements?expand=1#diff-16ffd7ab032bcc253040c3ca48b688dccbc93adf38ef9e49e47b8c6f3e3375e1R31-R39
Variants bring determination in a way that a user knows which chassis, mda, card will be provisioned by vrnetlab. Variants will also come documented in the Readme, so it will be clear which variant to choose based on the users requirements.
The idea is to have a collection of variants which are most popular nowadays; so far only sr1 variant was added, as it is the de-facto standard vsim variant.
ToDo

[x] expose gNMI port 57400 (added in fd7f737)
[ ] allow users to pass full config that will act as a startup-config via bind mounting

/cc @wdesmedt

gNMI forwarding:

gNMI forwarding:

the changes outgrew the initial proposal. The SR OS users can go check out this fork where I focus on SR OS - https://github.com/hellt/vrnetlab/tree/master/sros


Why ?

[WARN] main.go func1:200 unable to analyze: problem validating data: sensor data cannot be empty
[INFO] main.go func1:186 scanning with wlan0

me too


chore: latest dm-job, dm-cli, dmss in example

[ ] Latest DMSS tag
[ ] Latest dm-job tag
[ ] Latest dm-cli tag

closed by https://github.com/equinor/dm-core-packages/pull/1198


remove header

Pull Request Test Coverage Report for Build 152

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 147:
0.0%

Covered Lines:
88

Relevant Lines:
88

💛  - Coveralls


Expose geographical data associated with images in API

Possible use case: searching for images of a specific disaster

We closed the equivalent ticket for the frontend. This isn't something we're going to prioritize in the near future. If we come back to it we'll start fresh.


added 'alias'

added optional key 'alias' to author schema
updated the docs accordingly
fixes #93

Furthermore,

made family-names not required
made given-names not required
updated the readme accordingly.

This last change basically gives CFF writers more freedom and a bit more responsibility to strive for good data, but the benefit is that people can now write valid files when:

an author is known only by an alias
an author is known only by their family name

tests fail because travis checks against old schema that has required keys family-names and given-names
I validated using the same procedure as https://github.com/citation-file-format/citation-file-format/pull/95#issuecomment-552468217 instead.

Thanks for reviewing!


Update core dependency to release 1.1.3rc1

Update of core to be deferred until we release gyro 1.1.3


fix(codeaction preview) update internal _items list with resolve results

Fixes #1007 but in a non-JDTLS-specific way. In fact, by updating _items this removes unnecessary codeAction/resolve calls from being made if toggling the previewer, scrolling past and back to a preview result, and then within the nvim internal on_code_action_results implementation. This could potentially have some speedup, but more importantly, fixes the bug for JDTLS since JDTLS was returning different results between codeAction/resolve calls (but the first is correct).
In my testing this fixes the javaDoc/import codeActions for java (and any more I wasn't aware of with the same issue).

If there are any stylistic/naming changes I'll gladly revise. I am actually pretty new to lua (debugging this issue myself was pretty painful :) )and don't know the conventions.

I see another room for improvement, if the call to resolve succeeded but the result isn't an edit the next time we preview the item there will be another call made to resolve, I'll fix that as well when merging.

I think this might need a different approach, overriding the _items isn't future-safe, neovim can change the way it resolves code actions or the callback for ui.select at which point our call to on_choice will fail.
That said, if we don't override the item tuple this might not solve #1007, I'll have to do some more testing.

EDIT: was the JDTLS bug happening only on consequent calls?
Yes, in my debugging I found that the first codeAction/resolve was correct from JDTLS. The second call would reply something that seemed to try to overwrite its old document My best guess of the root cause relationship to https://github.com/eclipse-jdtls/eclipse.jdt.ls/issues/376 is that JDTLS assumes the edit has been made? Or maybe this is some other bug within JDTLS with repeated resolve calls.

I see another room for improvement, if the call to resolve succeeded but the result isn't an edit the next time we preview the item there will be another call made to resolve, I'll fix that as well when merging.

I'm not sure about this, since I think this is the contract of the codeAction/resolve method. Would you be expecting something else, like action.command?

I think this might need a different approach, overriding the _items isn't future-safe, neovim can change the way it resolves code actions or the callback for ui.select at which point our call to on_choice will fail.

True, but I'm not sure how likely this is. I guess the best solution would be neovim providing a hook into their own codeAction/resolve caller and they provide this memoization for us. However,

True, but I'm not sure how likely this is. I guess the best solution would be neovim providing a hook into their own codeAction/resolve caller and they provide this memoization for us. Ideally they should be providing a hook/function callback parameter instead of this vim.ui.select hack.

The issue is already prevalent in the code, in neovim 0.10.0 the ui.select items changed from { client_id, action } to { ctx = ..., action = ... },  hence these lines ( the code already fails with neovim nightly because of this change):
https://github.com/ibhagwan/fzf-lua/blob/b697e269475b07c191afcb89fc8d4708d9b9f8a4/lua/fzf-lua/previewer/codeaction.lua#L146-L150
I have a solution for all of this including a "hack" that overwrites the resolved action only for jdtls, testing now and will merge soon.

Due to all the reasons mentioned above I manually merged your commit (https://github.com/ibhagwan/fzf-lua/commit/2cbe90ddbc66c4caeb8919d50867ff312c9e3847) and improved on it with https://github.com/ibhagwan/fzf-lua/commit/903a4ae4e838170e4f44fb4ce1ca647a3c9cf828.
The latest also fixes an issue where actions wouldn't be resolved on the nightly as the test for the resolving capability changed and is now:
https://github.com/ibhagwan/fzf-lua/blob/903a4ae4e838170e4f44fb4ce1ca647a3c9cf828/lua/fzf-lua/previewer/codeaction.lua#L163-L175
The jdtls "hack" was also updated to work on both 0.9 and the nightly:
https://github.com/ibhagwan/fzf-lua/blob/903a4ae4e838170e4f44fb4ce1ca647a3c9cf828/lua/fzf-lua/previewer/codeaction.lua#L188-L194

I like your solution! Excellent response time too!
Any reason why the jdtls hack is done specifically for jdtls? I guess to reduce blast radius to just jdtls if code_actions ui_select input changes? Otherwise I think it reduces latency of the code action when applied since you skip the LSP call.

Any reason why the jdtls hack is done specifically for jdtls? I guess to reduce blast radius to just jdtls if code_actions ui_select input changes? Otherwise I think it reduces latency of the code action when applied since you skip the LSP call.

Exactly that, I would like to avoid modifying neovim internal structures, it doesn’t make any sense to have the items modified when running the previewer and unmodified if running with previewer=false, although unlikely, if this part of the runtime changes in the future I can already see the mess this kind of change would create.
As for the latency, perhaps it’s a nice to have benefit but I feel we shouldn’t try to optimize here at the expense of modifying internal LSP code.


IncludeFilter complicates SQL query

I'm just trying out EFP for the purpose of using IncludeFilter and am reviewing the generated SQL queries. I started with a simple filter and a nested include and the resulting query made me go cross-eyed so I reduced it down to just using a simple include that does not do any filtering. It just includes all records from a related table/navigation property. Using Include, it joins my two tables into "Project1" and then selects from that. Using IncludeFilter, it joins my tables into "Project1" and then joins that on the base table again ON 1=1 which results in a Cartesian product.
Example:
IQueryable<Facility> dbQuery = DBContext.Set<Facility>();
Expression<Func<Facility, object>> navProp = f => f.People;

var where = FilterDeleted(where);
dbQuery = dbQuery.IncludeFilter(f => f.People);

if (where != null)
    dbQuery = dbQuery.Where(where);

 return dbQuery;

SELECT
    [Extent1].[pk_FacilityID] AS [pk_FacilityID],
    [Extent1].[CreatedDate] AS [CreatedDate],
    [Extent1].[LastModifiedDate] AS [LastModifiedDate],
    [Extent1].[fk_CultureID] AS [fk_CultureID],
    [Project1].[C2] AS [C1],
    [Project1].[pk_FacilityID] AS [pk_FacilityID1],
    [Project1].[C1] AS [C2],
    [Project1].[pk_PersonID] AS [pk_PersonID],
    [Project1].[FirstName] AS [FirstName],
    [Project1].[LastName] AS [LastName],
    [Project1].[CreatedDate] AS [CreatedDate1],
    [Project1].[LastModifiedDate] AS [LastModifiedDate1],
    [Project1].[IsDeleted] AS [IsDeleted]
    FROM  [dbo].[Facilities] AS [Extent1]
    LEFT OUTER JOIN  (SELECT
        [Extent2].[pk_FacilityID] AS [pk_FacilityID],
        [Extent3].[pk_PersonID] AS [pk_PersonID],
        [Extent3].[FirstName] AS [FirstName],
        [Extent3].[LastName] AS [LastName],
        [Extent3].[fk_FacilityID] AS [fk_FacilityID],
        [Extent3].[CreatedDate] AS [CreatedDate],
        [Extent3].[LastModifiedDate] AS [LastModifiedDate],
        [Extent3].[IsDeleted] AS [IsDeleted],
        CASE WHEN ([Extent3].[pk_PersonID] IS NULL) THEN CAST(NULL AS int) ELSE 1 END AS [C1],
        1 AS [C2]
        FROM  [dbo].[Facilities] AS [Extent2]
        LEFT OUTER JOIN [dbo].[People] AS [Extent3] ON [Extent2].[pk_FacilityID] = [Extent3].[fk_FacilityID] ) AS [Project1] ON 1 = 1
    ORDER BY [Extent1].[pk_FacilityID] ASC, [Project1].[C2] ASC, [Project1].[pk_FacilityID] ASC, [Project1].[C1] ASC

In reality this code is in a generic class where Facility is a type parameter and an array of navigation property expressions is passed in as a parameter. The resulting C# Facility objects have the correct # of people each so it seems to be sorting it all out in code, but for two facilities with 10,000 people, this query gives a result set of 20,000 records. That doesn't seem like it's going to be scalable. Is this the expected result or am I using it in an unsupported way?

Hello @xr280xr ,
You use exactly IncludeFilter as you do with Include.
The benefit to IncludeFilter is to allow filtering such as:
dbQuery = dbQuery.IncludeFilter(f => f.People.Where(x => x.IsActif));

If you want to have some performance benefit, try to use IncludeFilterOptimized instead. It allows also to filter but in a more optimized ways (may be slower in very very complex scenario).
Let me know if that successfully answer to your question.
Best Regards,
Jonathan

Help us to support this library: Donate

Thanks for your reply, Jonathan. So is selecting the Cartesian product the expected result? It looks like maybe that is the outcome of the projection that IncludeFilter uses behind the scenes? The problem is, using my example above, if I'm querying 100 facilities each with 1000 people, it would select a result set of 10,000,000 million rows in order to retrieve only 100,100 records (100,000 people and 100 facilities). So should IncludeFilter not be used against a query that returns a collection but only against a query that returns a single row (e.g. only if I'm querying one facility)?

Hello @xr280xr ,
This is not a cartesian product. In your scenario, you will more likely return 100,000 records. The facilities will be duplicated multiple time.
That's how Include work in EF6.
In EF Core, it works like our features IncludeOptimized. It will return all facilities and all peoples. So it's faster since facilities are not duplicated in multiple rows.
I recommend trying IncludeOptimized instead to see the SQL output and performance.
Best Regards,
Jonathan

Help us to support this library: Donate

Hello @xr280xr  ,
We are currently making some issue cleanup.
Feel free to reopen if you believe we closed it by mistake
Best Regards,
Jonathan


Overlaying StackNavigator header.

Dear all,
I'm currently working on an application using StackNavigator. As user is navigation deeper into the stack, one of the screens that added has to, at a certain moment, be overlayed with a full-screen view.
Q : Is it possible to overlay the header of StackNavigator from within one of the pushed components?
My current approach (described below) fails miserably. The blue view should be overlaying the entire screen.
overlayView: {
    height: Dimensions.get('window').height,
    width: Dimensions.get('window').width,
    position: 'absolute',
    backgroundColor:'blue',
    zIndex:1000,
 },

You can set header: null on navigationOptions, then the header will be hidden.

I have the same problem and hiding the header isn't going to work for me because Im trying to display a full screen semi-transparent loading overlay and having the header disappear all of a sudden wouldn't be cool.

I was able to solve this issue by doing:
static navigationOptions = ({navigation}) => ({
  headerStyle: {
    position: 'absolute',
    top: 0,
    left: 0,
  },
  ...
});

i've found react-native Modal components to be a good solution for me (in my experience they overlay on top of anything). try just changing your View to Modal with animations and other modal-y things turned off

Pinging OP @nazywamsiepawel since this issue is quite old and related to an old version of the lib. If no answer I'll close in 7 days.
Moreover @jaredramirez solution is a good approach.

Hi there @nazywamsiepawel ,
In an effort to cleanup this project and prioritize a bit, since this issue had no follow up since my last comment I'm going to close it.
If you are still having the issue (especially if it's a bug report) please check the current open issues, and if you can't find a duplicate, open a new one that uses the new Issue Template to provide some more details to help us solve it.

Hi @kelset
I am facing same issue. How can I fix it ?

@jaredramirez Not work for me

hi! if you care about this please create a new issue and fill out the issue template and i'll be happy to look into it!


China censorship copypasta and variants

thinks like
tank man
six four
6 4
1989
Tiananmen Square
animal farm
Winnie-the-Pooh
陆肆
六四
自由花
终身
不要脸
不同意

As much as we want to keep copypasta out of our server, let's not be welcoming the Chinese overlords in lol.

isn't this censorship, so we'd be the Chinese government?

plus it'd piss off the history nerds if they tried to bring it up in a meme in #history-memes and they learned it was censored

yeah, i'm saying to combat people who are trying to ban any user thats somehow in china

lmao that's funny, rip users in china

Today (well, yesterday in china) was "Chinese internet maintenance day" aka the anniversary of the Tiananmen Square massacre that happened on 6/4/1989.


Draft: feat: use force_revocable tokens in 7.50.3+

This enables setting the force_revocable flag and set and expires_in to MaxTLL

Fixes #40

Fixed spelling on revocable ... how do we get from "revoke" to "revocable" (inflammable means flammable, what a country) ;)

Sorry, I just noticed my "Makefile" fix for TOKEN_USERNAME on the local test artifactory snuck in while I was fixing the spelling. That only affects a local test environment, so I am going to leave it there unless there are objections.

@alexhung While doing the UserTemplate stuff, I think I might have made an error around the TTL. I assume that the role maxTTL was the number to use, but now I see there is more TTL related logic in the func (b *backend) pathTokenCreatePerform function. I am going to have to re-work this. I am not sure which way I will move the logic yet. I am leaning towards passing the expires_in as an argument (optional argument) to the createToken function.

UPDATE: Rebased (one commit) and pulled out the magic version stuff... as I found it it fails after a reload. I need to sort out initialize, which I will do as part of a separate MR


Question: add network device

There is also the SLZB-06M (zigbee2lan, EFR32MG2 ) available which will soon get matter and multipan support (https://smlight.tech/product/slzb-06/)
Will I also be able to add a network device under "DEVICE"?

I do not provide any support for the software running in this container.

🤷


Recognize function declarations

Currently, the :expr pattern matches function declarations as well as
function statements. Although I thought the fix would be simple, the underlying
bug is more far-reaching than I anticipated. I'd very much like to contribute
to this project, but I could really use a pointer or two in order to proceed.
Would anyone mind looking this over and offering suggestions?

Yeah this is a bit trickier than it might first appear.
Since FunctionDeclaration and FunctionExpression can look the same when they are both named you have to use the parsing/enforestation context to tell them apart. The standard way that say esprima does this is by writing a normal recursive descent parser with a function per grammar production.
A bit of a refactor but probably what we should do.

Handled by #485


Error when launching the compiled .exe

Hey, so I tried to build the .exe with pyinstaller. It compiled successfully but when I run it, it gives me this error:
Traceback (most recent call last):
  File "PyInstaller\hooks\rthooks\pyi_rth_win32api.py", line 32, in <module>
  File "PyInstaller\loader\pyimod02_importers.py", line 499, in exec_module
  File "pywintypes.py", line 128, in <module>
  File "pywintypes.py", line 44, in __import_pywin32_system_module__
ImportError: Module 'pywintypes' isn't in frozen sys.path ['C:\\Users\\wooxh\\AppData\\Local\\Temp\\_MEI16282\\base_library.zip', 'C:\\Users\\wooxh\\AppData\\Local\\Temp\\_MEI16282\\lib-dynload', 'C:\\Users\\wooxh\\AppData\\Local\\Temp\\_MEI16282']

I searched up the error and it looks like pyinstaller error. Can someone confirm it? Thanks

Hello o/
This looks like a missing dependency. Have you followed the Advanced Usage section of the README?:

yes I did

Assuming you've done everything from it correctly then, there's one thing you can try:

Command:
\env\Scripts\pywin32_postinstall.py -install

Note you have to run this from an activated venv too.

I've just pushed out https://github.com/DevilXD/TwitchDropsMiner/commit/44fc3122e0d8faa902587b62371578ae639f30c9, so you can try running the new setup script. It gives you an option to either install PyInstaller or not for you automatically.

I have the same problem.
(env) PS D:\User\TwitchDropsMiner> pip list
Package                   Version
------------------------- ---------
aiohttp                   3.8.3
aiosignal                 1.2.0
altgraph                  0.17.2
async-timeout             4.0.2
attrs                     22.1.0
charset-normalizer        2.1.1
frozenlist                1.3.1
future                    0.18.2
idna                      3.4
multidict                 6.0.2
pefile                    2022.5.30
Pillow                    9.2.0
pip                       21.1.1
pyinstaller               5.4.1
pyinstaller-hooks-contrib 2022.10
pystray                   0.19.4
pywin32                   304
pywin32-ctypes            0.2.0
setuptools                56.0.0
six                       1.16.0
wheel                     0.37.1
yarl                      1.8.1
WARNING: You are using pip version 21.1.1; however, version 22.2.2 is available.
You should consider upgrading via the 'd:\user\twitchdropsminer\env\scripts\python.exe -m pip install --upgrade pip' command.

But I tried to build using github actions, Artifacts can be opened, but there are problems using it.
I opened the program, logged into my account and set up the program, restarted the program and got an error.
Fatal error encountered:

Traceback (most recent call last):
  File "main.py", line 169, in <module>
  File "asyncio\base_events.py", line 616, in run_until_complete
  File "twitch.py", line 418, in run
  File "twitch.py", line 438, in _run
  File "twitch.py", line 981, in get_auth
  File "twitch.py", line 198, in validate
  File "twitch.py", line 279, in _validate
exceptions.MinerException: Twitch considers this miner as a "Bad Bot". Try deleting the cookie file and try again.

my actions artifacts link

@Huiaei If you've managed to launch and log into the program, then you are not having the same issue then. The traceback you've got is related to #40 instead, not this issue.
As far as Github Actions, or as I saw another person do in a fork, any kind of CI or even Heroku deployment (which this app was never designed for): these are not really recommended from my side. I never designed this project with CI in mind - if you can make it work, so be it. If not, I have no real plans on "enabling" CI specifically, as everything required to build the application is already provided as-is in the repository.
By the way, your artifacts build says at the end of the build phase:

30879 INFO: Building EXE from EXE-00.toc completed successfully.

..., which is exactly what I get every time I build the application, so it should be working already, minus the #40 issue that is currently crippling this project of course.

@Huiaei If you've managed to launch and log into the program, then you are not having the same issue then. The traceback you've got is related to #40 instead, not this issue.
As far as Github Actions, or as I saw another person do in a fork, any kind of CI or even Heroku deployment (which this app was never designed for): these are not really recommended from my side. I never designed this project with CI in mind - if you can make it work, so be it. If not, I have no real plans on "enabling" CI specifically, as everything required to build the application is already provided as-is in the repository.
By the way, your artifacts build says at the end of the build phase:

30879 INFO: Building EXE from EXE-00.toc completed successfully.

..., which is exactly what I get every time I build the application, so it should be working already, minus the #40 issue that is currently crippling this project of course.

Thank you for your reply. I also found issue #40 when I finished replying to this thread. i will also turn my attention to issue #40 and look forward to the subsequent fix.

These issues should be fixed by the v13 release: https://github.com/DevilXD/TwitchDropsMiner/releases


Add EC xrefs to DNA 5'-3' DNA exonuclease activity terms

EC has these four main DNA exonuclease terms:
EC:<IP_ADDRESS>
Exonucleolytic cleavage in the 3'- to 5'-direction to yield nucleoside 5'-phosphates. Preference for single-stranded DNA.
EC:<IP_ADDRESS>
Exonucleolytic cleavage in the 3'- to 5'-direction to yield nucleoside 5'-phosphates. Preference for double-stranded DNA.
EC:<IP_ADDRESS>
Exonucleolytic cleavage in the 5'- to 3'-direction to yield nucleoside 5'-phosphates. Preference for double-stranded DNA.
EC:<IP_ADDRESS>
Exonucleolytic cleavage in the 5'- to 3'-direction to yield nucleoside 5'-phosphates. Preference for single-stranded DNA.

[ ] I think EC:<IP_ADDRESS> should be added as xref to GO:0051908
[ ] GO:0051908 also needs its name updating to match sister terms, ie 'double-stranded DNA 5'-3' DNA exonuclease activity'

id: GO:0051908
name: double-stranded DNA 5'-3' exodeoxyribonuclease activity
namespace: molecular_function
def: "Catalysis of the sequential cleavage of mononucleotides from a free 5' terminus of a double-stranded DNA molecule." [GOC:ai]
synonym: "double-stranded DNA specific 5'-3' exodeoxyribonuclease activity" RELATED []
is_a: GO:0008309 ! double-stranded DNA exodeoxyribonuclease activity
is_a: GO:0035312 ! 5'-3' DNA exonuclease activity

[ ] And EC:<IP_ADDRESS> should be added as xref to GO:0045145:

id: GO:0045145
name: single-stranded DNA 5'-3' DNA exonuclease activity
def: "Catalysis of the sequential cleavage of nucleotides (such as mononucleotides or dinucleotides) from a free 5' terminus of a single-stranded DNA molecule." [GOC:ai, GOC:elh, PMID:20086101]
synonym: "single-stranded DNA specific 5'-3' exodeoxyribonuclease activity" RELATED []
synonym: "ssDNA-specific 5'-3' exodeoxyribonuclease activity" RELATED [GOC:mah]
is_a: GO:0008297 ! single-stranded DNA exodeoxyribonuclease activity
is_a: GO:0035312 ! 5'-3' DNA exonuclease activity
Consistent with above, EC:<IP_ADDRESS> and EC:<IP_ADDRESS> are already xrefs on the following two GO terms:
id: GO:0008310
name: single-stranded DNA 3'-5' DNA exonuclease activity
def: "Catalysis of the sequential cleavage of mononucleotides from a free 3' terminus of a single-stranded DNA molecule." [GOC:mah, PMID:22562358]
synonym: "exonuclease I activity" NARROW []
synonym: "single-stranded DNA 3'-5' exodeoxyribonuclease activity" EXACT []
synonym: "single-stranded DNA specific 3'-5' exodeoxyribonuclease activity" RELATED []
synonym: "ssDNA-specific 3'-5' exodeoxyribonuclease activity" RELATED [GOC:mah]
xref: EC:<IP_ADDRESS>
xref: MetaCyc:<IP_ADDRESS>-RXN
is_a: GO:0008296 ! 3'-5'-DNA exonuclease activity
is_a: GO:0008297 ! single-stranded DNA exodeoxyribonuclease activity
property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/24408" xsd:anyURI
id: GO:0008311
name: double-stranded DNA 3'-5' DNA exonuclease activity
def: "Catalysis of the sequential cleavage of mononucleotides from a free 3' terminus of a double-stranded DNA molecule." [GOC:mah, PMID:22562358]
synonym: "double-stranded DNA 3'-5' exodeoxyribonuclease activity" EXACT []
synonym: "double-stranded DNA specific 3'-5' exodeoxyribonuclease activity" RELATED []
synonym: "exonuclease III activity" NARROW []
synonym: "exoribonuclease III activity" NARROW []
xref: EC:<IP_ADDRESS>
xref: MetaCyc:<IP_ADDRESS>-RXN
is_a: GO:0008296 ! 3'-5'-DNA exonuclease activity
is_a: GO:0008309 ! double-stranded DNA exodeoxyribonuclease activity
property_value: term_tracker_item "https://github.com/geneontology/go-ontology/issues/24408" xsd:anyURI
Sound OK to you @pgaudet ?

Yes, this seems fine, thanks !


How to disable user interaction during progress.show()

It will be great to have a sort of BackgroundStyles.transparent
Is it possible ?

No it is.
However, I will add a transparent background style at the next update.

Hi
Added "transparent" to the BackgroundStyle setting. -> Ver.3.6.0
public var backgroundStyle: BackgroundStyles = .transparent

In this setting, the background is transparent and user interaction is disabled.


default-border-color: from black to gray

Gray border color looks better than black in both light and dark themes. It really blends well.

Catpuccin Mocha

Lapce Dark

Lapce Light

I personally prefer darker borders compared to the background color. In fact, I don't think I would like the light theme to change. Even though I don't actually use it, I think it looks pretty good as it is currently.
This might be a touchy subject :)

@schwrzstrbn I did not want you to close the PR, I simply expressed my opinion which can often be wrong. It's very much possible that others like lighter borders better and that there is sufficient interest in this to change the default, especially considering that for example, GitHub's dark theme also uses lighter borders.

@schwrzstrbn I did not want you to close the PR, I simply expressed my opinion which can often be wrong. It's very much possible that others like lighter borders better and that there is sufficient interest in this to change the default, especially considering that for example, GitHub's dark theme also uses lighter borders.

It comes down to preference, I guess. The reason why I closed the pr is that, I realized that maybe it was too soon to suggest a change to the default without experimenting first.

Should I keep it open, just in case?


Tabs feedback

[x] The tab indicator is meant to feel a bit less static. Polymer's tab component does a decent job of illustrating it: https://elements.polymer-project.org/elements/paper-tabs?view=demo:demo/index.html&active=paper-tabs. Basically, the head of the indicator gets "pulled" to the new position, and the tail lags behind a little
[x] Tab titles should be all caps

It looks like this continues in https://github.com/flutter/flutter/issues/2653.

Fixed with https://github.com/flutter/flutter/commit/ca8dbe902a5cc659f8304ad88c408d7fa6a40e3e


Is it possible to output cost volume?

Hi,
It is amazing how good the disp map is even tested on challenging unseen image pairs.
I was wondering if anyone could also output the cost volume beside the disp map.
I checked the costVolumePlugin provided in lib, but didn't really understand how it works.
Thanks!

That's an interesting question! In theory you should be able to get the output of the cost volume plugin by either modifying the TensorRT model generation script (like this one) which produces TRT C++ model files or directly auto-generated files themselves (like this one).
The idea is to make cost volume layer (cost_vol) an output layer by calling network->markOutput with appropriate parameters. Then you need to change the binding code in the sample app like here and other places where assumption are made about output layer.
Note that the cost volume values that you'll get will be in feature space, not pixel space. Also, in case of 3D model each value will actually be a vector as the output of cost volume plugin will be 5D tensor (see our paper for details).


Compiler throwing error "Cannot assign to 'calendarFormat' because it is a read-only property"

Describe the bug
While setting the moment.calendarFormat function, typescript compiler throwing "error TS2540: Cannot assign to 'calendarFormat' because it is a read-only property."
Code used
moment.calendarFormat = function(myMoment) {       const diff = myMoment.diff(moment(Date()), 'minutes', true) * -1;       const retVal =         diff < 30           ? 'now'           : diff < 1440           ? 'sameDay'           : diff < 2880           ? 'lastDay'           : 'sameElse';       return retVal;     };
Expected behavior
The compiler should not throw any error while assigning the function
Environment
typescript: 3.5.3
moment: 2.24.0
*Locale used
en-gb
Tue Jan 14 2020 20:37:32 GMT+0530 (India Standard Time)
1/14/2020, 8:37:53 PM
-330
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36

@HARIKSREEE See issue #5444 . You can try the following code.
import * as moment from 'moment';
moment.default.calendarFormat = function (myMoment: any, now: any): string {
   return ''
}

or
import moment from 'moment';
moment.calendarFormat = function (myMoment: any, now: any): string {
   return ''
}

Please re-open if you still have issues.


[3.3] Fix PhysicalBone gizmo not showing

The new CollisionObject gizmo used for custom shapes was used with higher priority due to alphabetical order and was preventing physical bones from being displayed in the editor.
Fixes #47188 (regression from #46397)
3.x backport of #47263

Thanks!


Max Number of Measures

Hello,
i tried to change the max number of measures in the Transpose table from 35 to 70 but it doesn't work.
there is another thing i should change in the js in order to allow more than 35 measure?
Thank you

it works now...


Catch exception when path parameters not in message.

Raise an exception when any of the path parameters is not present in the
input message of the endpoint.
Example :
@endpoints.method(message_types.VoidMessage, message_types.VoidMessage, path='/{parameter}')
def sample_endpoint(self, request):
    return VoidMessage()

I signed it!

@volnt: I'm not sure I understand this change - is "path parameters not in message" an illegal thing for applications to do, and this change simply improves the quality of the exception that is raised, or is it a legal thing to do, and the use of a custom error class is warranted because KeyError indicates a programming defect but InvalidMessageError indicates... something else? How about test coverage for this change - I think that that would help me see legitimate use cases in which the exception is raised.
@tmatsuo, do you want to look at this since it is discovery-related?

@nathanielmanistaatgoogle This change improves the quality of the exception that is raised.
When you use the endpoint example I wrote above, the discovery module just throws "KeyError: u'parameter'". This exception doesn't indicate anything about why the exception is raised.

I will look into making a test to cover this change.

@nathanielmanistaatgoogle It is in the discovery.py, but the change is actually in the generated method. I'll take a look anyways.
@volnt I think it's when you try to use your endpoint API from the client side. Maybe you can add a samplle code for such wrong usage?

A sample code would be :
@endpoints.method(message_types.VoidMessage, message_types.VoidMessage, path='/{parameter}', name='sample_endpoint')
def sample_endpoint(self, request):
    return VoidMessage()

>>> service = apiclient.discovery.build(sample_api, sample_version, discoveryServiceUrl=sample_discovery_url)
>>> service.sample().sample_endpoint(parameter="sample_parameter").execute()
Traceback (most recent call last):
 ...
 ...
KeyError: u'parameter'

With my change it outputs :
Traceback (most recent call last):
 ...
 ...
TypeError: Missing path parameter "parameter" in input message

Now that this has settled a bit: why isn't ValueError the appropriate exception to use? According to its spec, ValueError indicates that a programming mistake has been made by passing particular values of arguments to a function. Isn't that the case here? If what we want is a more helpful message communicated to the user, can't we do that without having to define a new exception type?

@nathanielmanistaatgoogle Good catch. I agree.
@volnt I think your sample has parameter argument, which is not intended maybe?
JFYI this is a good talk: http://pyvideo.org/video/880/stop-writing-classes

@tmatsuo Thanks for the video!  Jack did a similar talk at our Seattle Python meetup this summer, but it was more geared at names and namespaces, which he touched on here.

@volnt I'm closing this PR due to inactivity. If you're still interested in getting this merged please let us know and we'll be happy to re-open it.


Reduce calls to FileSystem.match and API calls in FileSystem._list

Resolves one aspect of #20137

Reuse concat_source in FileBasedSource.estimate_size

Create list_files to replace list_prefix to conduct lazy listing files in GcsIO, S3IO, BlobStorageIO
While FIleSystem.match, match_files, _list are generator based and in principle support lazy evaluation, GcsIO.list_prefix (and other list_prefix) method makes API calls to fetch all file names of a path, then return a dict. When there are a lots of (millions) files to list, it takes hours even though the call is FileSystem.match(..., limit=1) - asks to return one file.

Please add a meaningful description for your change here
This resolves duplicate API calls to list files for ReadFromText transform. When there are lots of files, it should make 1/2 of the API calls than before (and 1/3 of when validate option is set to True).
Listing files is still not multi threading though, so leave this issue open.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

HadoopFileSystem implementation is based on generator already and file listing is propagated lazily. So no need to change it.

deferring to @ahmedabu98

Run Python PreCommit

The two "pending" tests actually already passed but not report to GitHub UI somehow


Raise Planetshine version to 1.1.2 if not 1.1.99.

Hello,
As per this post and reports of the mod working on KSP 1.1.2, I think the metadata should be upped to 1.1.2 or 1.1.99 for this mod if possible.

Thanks. I hadn't seen that post from Valerian before.


New photo-headers for some sections

We are currently using the same ones in many sections, but we could have a few new ones.

Can design team help and come up with new photos?

cc @georgically


Instant crash when starting client

What happens:
The game crash when forge contruct mods
What you expected to happen:
I want to start the game
Steps to reproduce:

Download EnderIO And Endercore
Add to the custom launcher
Start
...

Affected Versions (Do not use "latest"):

EnderIO: 5.2.59
EnderCore: 0.5.76
Minecraft: 1.12.2
Forge: <IP_ADDRESS>47
SpongeForge? no
Optifine? yes
Single Player and/or Server? Single Player (Client)

Your most recent log file where the issue was present:
https://pastebin.com/5VNfSyNW

You have a mod installed that contains a partial Applied Energistics API.

Wich mod ? I don't install this kind of mods


Clean up default log printing to prevent clutter

This will be the default output:

Instead of:

Let me encode the gif, and then merge.


Fixed minor issues

Description
Fixed minor issues
Type of change

Bug fix (non-breaking change which fixes an issue)
Refactor (refactoring code, removing useless files)

Testing steps
N/A
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report

Merging #145 (d2d6080) into master (b29ef71) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   18.45%   18.45%
=======================================
  Files           3        3
  Lines         439      439
=======================================
  Hits           81       81
  Misses        347      347
  Partials       11       11

Impacted Files
Coverage Δ

cleaner.go
0.00% <0.00%> (ø)

storage.go
20.09% <50.00%> (ø)

config.go
68.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29ef71...d2d6080. Read the comment docs.


Adding span with Url throws assertion in RichText

In RichText when we add span with Url it throws this assertion.

Steps to Reproduce
getParsedMessage() {
    if (message.body == null || message.body.isEmpty) return Container();
    List<TextSpan> spans = [];
    var urlPattern =
        r"(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9]\.[^\s]{2,})";

    String tmp = message.body;
    Iterable<Match> matches = RegExp(urlPattern).allMatches(message.body);
    matches.forEach((m) {
      String match = m.group(0);
      int index = tmp.indexOf(match);

      if (index > 0) {
        spans.add(
            TextSpan(text: tmp.substring(0, index), style: normal14blackish));
      }
      spans.add(TextSpan(
          text: match,
          style: normal14blackish.copyWith(color: Colors.blue),
          recognizer: MultiTapGestureRecognizer()
            ..onTap = (int) async {
              if (await canLaunch(match)) launch(match);
            }));
      tmp = tmp.substring(index).replaceFirst(match, '');
    });
    spans.add(TextSpan(text: tmp, style: normal14blackish));

    return RichText(text: TextSpan(children: spans));
  }

Logs
Found in 1.17.0-3.4.pre.

CC @GaryQian

Thanks @timsneath for creating issue from my report. Here I am adding the status of Flutter doctor -v

@dhuma1981 Can you confirm whether this is a regression from previous versions? That's really important for us to know.

via email, @dhuma1981 reports: "And I am quite sure that the code was working properly and the issue was not there earlier but not sure about 1.12."

It looks like the text is explicitly designed to only accept a TapGestureRecognizer or a LongPressGestureRecognizer and assert(false) for all other recognizer types.
You code can easily be made to comply by changing MultiTapGestureRecognizer with TapGestureRecognizer.
I will look into why we do not support MultiTapGestureRecognizer, but for now, it seems like you should probably use TapGestureRecognizer if you only want to capture the simple tap gesture.

Thanks for the update. Is this a breaking change, Gary? Or has it always been this way?

It has always been this way since we added recognizer support in https://github.com/flutter/flutter/commit/44cdb049d8362467eae6af0ba357e50ad5c20d9e#diff-ce21420c077db1c16098c4197bf8d34dR520
cc @jonahwilliams Is there any reason we do not support other types of recognizers, and why do we assert(false). Is there a need to be so strict? It seems a warning that we are not using the recognizer would be enough?

I made a quick PR to improve that error message: https://github.com/flutter/flutter/pull/56328
We should decide if we want to support other recognizers.


Pysat rc2

Basic implementation of MaxSAT PySAT RC2 solver.

Looks great.
Only the      def _post_clauses(self, clauses):         self.pysat_solver.append_formula(clauses)
funciton seems overkill, only used in 1 (with inheritance 2) places, for a oneliner....
Did you run it with the full test-suite? If that is relevant/possible, check with Ignace, he documented it better recently.
Should that be fine (or not applicable) then do merge!

Needs further testing for constraints and also for solution printing.


enableProposedApi is not respected

Setting "enableProposedApi": true in package.json has no effect (outside of debug), but using --enable-proposed-api works.

VSCode Version: ~1.22.1~ 1.23.0 insiders
OS Version: Windows 10

Steps to Reproduce:

Create brand-new typescript extension.
Add "enableProposedApi": true to package.json as described here
Use new webview api in extension.ts:

let webview = vscode.window.createWebview('my-id', 'Hello', vscode.ViewColumn.Two, { });
webview.html = "Hello";

~Hit F5 to open up extension host.~ In insiders build "enableProposedApi": true in package.json truly allows proposed api usage for the debug session.
Compile and copy the extension to %USERPROFILE%\.vscode-insiders\extensions
Call command HelloWorld, you'll see error in the console:

Extension 'my.extension.id cannot use PROPOSED API (must started out of dev or enabled via --enable-proposed-api)

Running vscode with --enable-proposed-api=my.extension.id allows to run the extension.

Expected:
"enableProposedApi": true in package.json should allow running the extension.

I also uploaded the sample project:
https://github.com/OrkhanAlikhanov/vscode-enable-proposed-api-bug

Updated the issue for 1.23.0 insiders build.

@jrieken Should enabledProposedApi also be respected if you are debugging an extension using vscode?

@mjbvz Actually, it's respected when I hit F5 to start debugging, but when I install the extension enabledProposedApi has no effect. I have to enable it with --enable-proposed-api=extension.id

This is correct behavior then. We intentionally do not let installed extensions use proposed apis because vscode updates will break them

I see now. Why then we have enabledProposedApi at all? It doesn't make sense to me. I guess proposed api access, by default, needs to be granted to the development extension when I hit F5. What do yo think @mjbvz?

So that extensions have to be very intentional about consuming proposed apis and to prevent devs from publishing extensions that use them

Well, we can't explicitly use them without adding vscode.proposed.d.ts to the project, at least for typescript extension. Also note that a warning about use of proposed api is logged, which devs will see.


where are the source files?

where are the source files for librte_ans.a?

static lib are shared,
source code aren't shared now.


Display talks in the same slot

UI idea: https://www.uplabs.com/posts/personal-tracking-app

Done.
@704a8bb941e5804e5f6b31d58b97fdfa5277387f


Add RHEL 7.8 OS support

Closing this PR. It's already fixed in https://github.com/mulesoft/docs-runtime-fabric/pull/229


merge from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**/*.mjs' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(package): add main from template
docs(package): remove keyword null
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/*-test.mjs' as in template
chore(package): set $.ava.extensions='mjs' as in template
chore(package): remove unknown value for main ({{main}})

Coverage remained the same at 36.185% when pulling 482a8574cb0c400df0deeb03f6724d013b65af8a on npm-template-sync/1 into 68c64b8622821c2145f01335122444e588513dd9 on master.


CNS supports both mainnet and rinkeby from network-config.json file

@merenkoff Please have a look and let's discuss how ENS AND ZNS need to be updated

Congratulations! :tada: This was released as part of Release 1.1.5 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 1.1.5 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.1.7 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.1.7 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.2.0 :rocket:Generated by GitBuddy

Congratulations! :tada: This was released as part of Release 0.2.0 :rocket:Generated by GitBuddy


feat: editor toolbar

Resolves #10
Instead of copying individual items from the lexical-vue playground, I copied over the entire playground code and attempted to make it work with the lexical-vue package on NPM. Turns out, some of the functions/components the playground depends on aren't published to NPM for some reason. So, I copied over the lexical-vue code as well, resulting in the monorepo you see in this PR.

@jgonz3 sounds good to me. :)


middleware: add first version of GetBaseInfo RPC

The GetBaseInfo RPC provides information about the Base, which is displayed in the app's 'Base management' section. The RPCs GetHostname and GetBaseVersion are included in GetBaseInfo.
This PR includes placeholder values for:

the current Base system status
the Middleware's hidden service tor port

This PR does not include a unit test for GetBaseInfo, because a Prometheus mock is needed first.
I'll keep track of both, the placeholders (https://github.com/shiftdevices/bitbox-base-internal/issues/292) and unit tests (https://github.com/shiftdevices/bitbox-base-internal/issues/274) in a separate issues.

Rebased on top of master and moved the Redis keys to redis/keys.go as commented in https://github.com/digitalbitbox/bitbox-base/pull/218#discussion_r330447544.

Decided to add a commit that does a bit of the log awaited Prometheus refactoring. Otherwise addressed feedback from Tom and Marko.

Addressed feedback and tested interoperability with  https://github.com/digitalbitbox/bitbox-wallet-app/pull/588

Rebased onto master.


BUG in esp_http_client when using HTTPS and receiving error ESP_ERR_HTTP_FETCH_HEADER (IDFGH-449)

Environment
Own product pcb using:

Module or chip used:  ESP32-WROVER
IDF version 3.1.1
Build System:         [Make]
Compiler version:  xtensa-esp32-elf-gcc.exe (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a5) 5.2.0
Operating System:     [Windows]
Power Supply:         [USB and/or Battery]

Problem Description
I think I found an important bug in esp_http_client. It only happens when using HTTPS.
I do several https requests in the same session, if one of them fails with error ESP_ERR_HTTP_FETCH_HEADER, client buffer seems to break and next https requests receive the incorrect response with the events.
It's like the one failing is still buffered but not processed, and its response is given with the next request performed.
I find it quite hard to explain, I went crazy trying to find this because I believed it was in my code.
Please check following log picture and code sample to reproduce it.
I found a workaround, puting esp_http_client_close(client); every time the http perform returns an error. But I think this forces to redo the SSL handshake in the next request, wasting CPU time.
Other minor things I found:
The http_error event is never fired even if there is an error while performing the request.
Sometimes if one request fails (when touching with finger as described next), it makes the following ones to fail, maybe the next 2 or 3, but they shouldnt fail because finger is already removed... this only happens sometimes, but once with real error (no finger) it provoked following 10 minutes of request failing, until at some point the http client disconnected and reconnected again and everything went fine from there.
Please let me know if you need any more details. 😃
Expected Behavior
When https request fails with any error, I expect this does not affect next requests.
Actual Behavior
As you can see in the following picture, or check with sample code, I do 2 requests, 1 POST and 1 GET. Before error POST always receives answer of 404 bytes, GET receives answer of 289 bytes. That is correct.
After the error you can see that the answers are switched, when I do GET I am getting the POST answer and viceversa.
You can also check the date header received, which is wrong and repeated the same.
Sometimes if you leave finger touching (described next) during 2-3 requests that fail, then the following requests all receive the same date header for 2-3 times.
Not only the headers are switched, the answer itself is also switched with the previous request.

Steps to reproduce
This issue needs the https request to fail and timeout, which happens more or less twice a day in my environment.
But I discovered a way to force it happen.
While code is runing, touch with your finger the Wrover module in the pad 1 GND corner, touching at the same time the pcb antenna, the shield, and the GND pad or its decoupling capacitor.
It takes some trial and error but at some point https requests fail while you have the finger touching, so you have to keep touching until the request times out and the error appears.
If you touch for too long, error shows several times but at some point the http client launches a disconnect event and this fixes the error (that's how I based my workaround).
I found that sometimes the finger trick does not work anymore and I needed to restart ESP32 (without touching at the same time) in order for it to work again.

Code to reproduce this issue
Code is based on esp_http_client example, just removing what is not needed and with minor modifications. Default sdkconfig for this example, just changed serial port and wifi credentials.
#include <string.h>
#include <stdlib.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "esp_log.h"
#include "esp_system.h"
#include "nvs_flash.h"
#include "app_wifi.h"

#include "esp_http_client.h"

#define MAX_HTTP_RECV_BUFFER 512
static const char *TAG = "HTTP_CLIENT";

extern const char howsmyssl_com_root_cert_pem_start[] asm("_binary_howsmyssl_com_root_cert_pem_start");
extern const char howsmyssl_com_root_cert_pem_end[]   asm("_binary_howsmyssl_com_root_cert_pem_end");

esp_err_t _http_event_handler(esp_http_client_event_t *evt)
{
    switch(evt->event_id) {
        case HTTP_EVENT_ERROR:
            ESP_LOGI(TAG, "HTTP_EVENT_ERROR");
            break;
        case HTTP_EVENT_ON_CONNECTED:
            ESP_LOGI(TAG, "HTTP_EVENT_ON_CONNECTED");
            break;
        case HTTP_EVENT_HEADER_SENT:
            ESP_LOGI(TAG, "HTTP_EVENT_HEADER_SENT");
            break;
        case HTTP_EVENT_ON_HEADER:
            ESP_LOGI(TAG, "HTTP_EVENT_ON_HEADER, key=%s, value=%s", evt->header_key, evt->header_value);
            break;
        case HTTP_EVENT_ON_DATA:
            ESP_LOGI(TAG, "HTTP_EVENT_ON_DATA, len=%d", evt->data_len);
            if (!esp_http_client_is_chunked_response(evt->client)) {
                // Write out data
                // printf("%.*s", evt->data_len, (char*)evt->data);
            }

            break;
        case HTTP_EVENT_ON_FINISH:
            ESP_LOGI(TAG, "HTTP_EVENT_ON_FINISH");
            break;
        case HTTP_EVENT_DISCONNECTED:
            ESP_LOGI(TAG, "HTTP_EVENT_DISCONNECTED");
            break;
    }
    return ESP_OK;
}

static void http_rest()
{
    esp_http_client_config_t config = {
        .url = "https://httpbin.org/get",
        .event_handler = _http_event_handler,
		.cert_pem = howsmyssl_com_root_cert_pem_start,
    };
    esp_http_client_handle_t client = esp_http_client_init(&config);

	while(1)
	{
		// GET
		esp_http_client_set_url(client, "https://httpbin.org/get");
		esp_http_client_set_method(client, HTTP_METHOD_GET);
		esp_err_t err = esp_http_client_perform(client);
		if (err == ESP_OK) {
			ESP_LOGI(TAG, "HTTP GET Status = %d, content_length = %d\n",
					esp_http_client_get_status_code(client),
					esp_http_client_get_content_length(client));
		} else {
			ESP_LOGE(TAG, "HTTP GET request failed: %s", esp_err_to_name(err));
		}

		vTaskDelay(1000 / portTICK_PERIOD_MS);

		// POST
		const char *post_data = "field1=value1&field2=value2";
		esp_http_client_set_url(client, "https://httpbin.org/post");
		esp_http_client_set_method(client, HTTP_METHOD_POST);
		esp_http_client_set_post_field(client, post_data, strlen(post_data));
		err = esp_http_client_perform(client);
		if (err == ESP_OK) {
			ESP_LOGI(TAG, "HTTP POST Status = %d, content_length = %d\n",
					esp_http_client_get_status_code(client),
					esp_http_client_get_content_length(client));
		} else {
			ESP_LOGE(TAG, "HTTP POST request failed: %s", esp_err_to_name(err));
		}

		vTaskDelay(1000 / portTICK_PERIOD_MS);
	}
}

static void http_test_task(void *pvParameters)
{
    app_wifi_wait_connected();
    ESP_LOGI(TAG, "Connected to AP, begin http example");
    http_rest();
}

void app_main()
{
    esp_err_t ret = nvs_flash_init();
    if (ret == ESP_ERR_NVS_NO_FREE_PAGES || ret == ESP_ERR_NVS_NEW_VERSION_FOUND) {
      ESP_ERROR_CHECK(nvs_flash_erase());
      ret = nvs_flash_init();
    }
    ESP_ERROR_CHECK(ret);
    app_wifi_initialise();

    xTaskCreate(&http_test_task, "http_test_task", 8192, NULL, 5, NULL);
}

Hi @lrodenasSistel, I am including a text file(change the extension to .patch), which contains patch of workaround for this issue.
Apply the patch, and let us know if that works.
client_workaround_patch.txt

How do I apply the patch? Where should I put this file after changing the extension?

Instead of attaching patch, I am sending you modified esp_http_client_perform() API in the text file.
So can you replace the existing esp_http_client_perform() API in components/esp_http_client.c with the one given in the text file?
Let us know if this works. I am finding it a little difficult to reproduce the issue. So, if this works then we can raise an MR to fix the bug.
new_esp_http_perform_api.txt

I get compilation errors just replacing that function. I am using IDF3.1.1.
Did you manage to reproduce the issue at least once?
I can reproduce it at will with the sample code I posted and touching the wrover module antena.
Running make app-flash...
CC build/esp_http_client/esp_http_client.o
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c: In function 'esp_http_client_perform':
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:779:28: error: implicit declaration of function 'esp_http_client_connect' [-Werror=implicit-function-declaration]
                 if ((err = esp_http_client_connect(client)) != ESP_OK) {
                            ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:780:31: error: 'struct esp_http_client' has no member named 'is_async'
                     if (client->is_async && err == ESP_ERR_HTTP_CONNECTING) {
                               ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:780:52: error: 'ESP_ERR_HTTP_CONNECTING' undeclared (first use in this function)
                     if (client->is_async && err == ESP_ERR_HTTP_CONNECTING) {
                                                    ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:780:52: note: each undeclared identifier is reported only once for each function it appears in
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:781:32: error: 'ESP_ERR_HTTP_EAGAIN' undeclared (first use in this function)
                         return ESP_ERR_HTTP_EAGAIN;
                                ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:787:28: error: implicit declaration of function 'esp_http_client_request_send' [-Werror=implicit-function-declaration]
                 if ((err = esp_http_client_request_send(client)) != ESP_OK) {
                            ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:788:31: error: 'struct esp_http_client' has no member named 'is_async'
                     if (client->is_async && errno == EAGAIN) {
                               ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:788:45: error: 'errno' undeclared (first use in this function)
                     if (client->is_async && errno == EAGAIN) {
                                             ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:788:54: error: 'EAGAIN' undeclared (first use in this function)
                     if (client->is_async && errno == EAGAIN) {
                                                      ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:795:28: error: implicit declaration of function 'esp_http_client_send_post_data' [-Werror=implicit-function-declaration]
                 if ((err = esp_http_client_send_post_data(client)) != ESP_OK) {
                            ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:796:31: error: 'struct esp_http_client' has no member named 'is_async'
                     if (client->is_async && errno == EAGAIN) {
                               ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:805:31: error: 'struct esp_http_client' has no member named 'is_async'
                     if (client->is_async && errno == EAGAIN) {
                               ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:820:35: error: 'struct esp_http_client' has no member named 'is_async'
                         if (client->is_async && errno == EAGAIN) {
                                   ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:829:35: error: 'struct esp_http_client' has no member named 'is_async'
                         if (client->is_async && errno == EAGAIN) {
                                   ^
C:/DESARROLLO/ESP32/esp-idf/components/esp_http_client/esp_http_client.c:844:31: error: 'struct esp_http_client' has no member named 'first_line_prepared'
                         client->first_line_prepared = false;
                               ^
cc1.exe: some warnings being treated as errors
make[2]: *** [/c/DESARROLLO/ESP32/esp-idf/make/component_wrapper.mk:286: esp_http_client.o] Error 1
make[1]: *** [/c/DESARROLLO/ESP32/esp-idf/make/project.mk:468: component-esp_http_client-build] Error 2

--- Build failed
--- Press Ctrl+] to exit monitor.
--- Press Ctrl+F to build & flash project.
--- Press Ctrl+A to build & flash app.
--- Press any other key to resume monitor (resets target).

@lrodenasSistel Oops! I didn't take a notice of your IDF version. My bad. I thought the problem is due to the latest changes on master branch. We'll get back to you.

@lrodenasSistel Can we close this issue?

Is the "asynchronous mode of esp_http_client_perform" already part of stable release so we can test it? From what version?
Is this statement "we think if a esp_http_client_perform fails in synchronous mode then it is expected to call esp_http_client_close() API" still valid? If so, is it written on documentation anywhere for future users?
Thank you

@lrodenasSistel

Is the "asynchronous mode of esp_http_client_perform" already part of stable release so we can test it? From what version?

It is a part of stable release v3.2 and so on. You can use it the way it is shown here

Is this statement "we think if a esp_http_client_perform fails in synchronous mode then it is expected to call esp_http_client_close() API" still valid? If so, is it written on documentation anywhere for future users?

Sorry, I don't think it is mentioned in the document. I'll try to add it to the documentation of esp_http_client_perform() API . Thanks!!

@lrodenasSistel Do you have any updates on this issue?

This issue still exists in v4.1-dev-1931-g68be5f6ca, and calling esp_http_client_close fixes the problem. I also couldn't find this anywhere in the documentation.
Do we need to call esp_http_client_close on any error returned from esp_http_client_perform?

@RoderickJDunn, I was not able to reproduce the issue. Please check logs attached below:
I (10574) HTTP_CLIENT: HTTP GET Status = 200, content_length = 270
E (11084) HTTP_CLIENT: HTTP POST request failed: ESP_ERR_HTTP_FETCH_HEADER
I (11394) HTTP_CLIENT: HTTP PUT Status = 200, content_length = 444
I (11804) HTTP_CLIENT: HTTP PATCH Status = 200, content_length = 335
I (12214) HTTP_CLIENT: HTTP DELETE Status = 200, content_length = 336
I (12624) HTTP_CLIENT: HTTP HEAD Status = 200, content_length = 270
I (12624) HTTP_CLIENT: HTTP_EVENT_DISCONNECTED

Can you share steps to reproduce the issue? Also, can you share logs when issue occurs?

I got the same issue in release/v3.3, but closing connection didnt solve my problem. I found that adding this code before perform solved it, so i think it may be some timing issue or something:
esp_http_client_open(client, 0);
Thats correct, open connection with 0 length payload. Now i dont get ESP_ERR_HTTP_FETCH_HEADER anymore and all connections seems to be successful on first try.

I also observed the ESP_ERR_HTTP_FETCH_HEADER in v4.3-dev-771-gc77c4ccf6c43.
The esp_http_client_fetch_headers -> esp_transport_read returns -1.
(It happens on both http and https)

I can confirm this problem affects v4.1 as well, exactly like @AxelLin described.

Hi @AxelLin @KaeLL, Can you please provide sample code with sdkconfig to reproduce this issue? Currently I'm not able to reproduce the issue.

does anyone have the solution to this problem?

Hi @AxelLin @KaeLL, Can you please provide sample code with sdkconfig to reproduce this issue? Currently I'm not able to reproduce the issue.

Unfortunately no. I don't know exactly what's causing esp_transport_read returns to return -1, and currently I'm a little to busy to dedicate time to find out.

Hi @AxelLin @KaeLL, Can you please provide sample code with sdkconfig to reproduce this issue? Currently I'm not able to reproduce the issue.

I was able to reproduce this issue by waiting around 60-70 seconds between requests using the same client.

@AxelLin @KaeLL @weizhen1883 @dakriy Sorry for long delay.
I was able to reproduce this issue by waiting around 60-70 seconds between requests(when httpbin.org is used as server) however ESP_ERR_HTTP_FETCH_HEADER error occurs within 10 seconds when using AWS S3 as server.
This happens because idle time is set for each server, after which inactive/idle connection with will be closed. ESP_ERR_HTTP_FETCH_HEADER error occurs as server has closed the connection.
You can check enabling Socket debug messages in menuconfig (under Component Config > LWIP > Debug) and setting LWIP_DEBUG to LWIP_DBG_ON (in lwipopts.h).
Following debug messages are printed:
lwip_select(55, 0x3ffc9288, 0x0, 0x3ffc9290, tvsec=5 tvusec=0)
lwip_selscan: fd=54 ready for reading
lwip_select: nready=1
lwip_recvfrom(54, 0x3ffc9fe8, 5, 0x0, ..)
lwip_recv_tcp: top while sock->lastdata=0x0
lwip_recv_tcp: netconn_recv err=-15, pbuf=0x0
lwip_recv_tcp: p == NULL, error is "Connection closed."!
lwip_recvfrom(54):  addr=<IP_ADDRESS> port=443 len=0
E (17265) HTTP_CLIENT: Error perform http request ESP_ERR_HTTP_FETCH_HEADER

These messages show Connection closed error.
Idle time will vary from server to server. Hence, it is not recommended to keep connection open for a long time and reuse the same.
(CC: @mahavirj)

Thanks for reporting, feel free to reopen.

Jitin,
If esp_http_client_perform() fails with an error of ESP_ERR_HTTP_CONNECT (0x7002), does esp_http_client_close() need to be called? Could you please put it in the documentation and protocol_examples_common/connect.c? It is causing many people problems.

@WilliamRoyle,
esp_http_client_close() de-initialises underling transport created by esp_http_client_init(). Hence, esp_http_client_close() must be called even if connect fails.

Could you please put it in the documentation and protocol_examples_common/connect.c?

We will to add this in documentation. I didn't understand your point related to protocol_examples_common/connect.c, this source file is handles WiFi connection.

this problem still there on idf V4.5


Update publications page with all publications by HIM

All of @pfaendtner's publications should be added to publications.html. I'm going to write a python script to parse publications from Jim's CV, and add them to the HTML template established for 2018 publications in the final commit of #5.
Hopefully this will be as easy as we made it sound in group meeting...

Addressed by #17


Fix README.md Experiment example.

Fixing a couple of errors in the example to make it run just by copy-pasting it. Seems like my editor (Atom) have removed some unnecessary white spaces as well.
Errors:
Error: Cannot find module 'PlanOut'

SyntaxError: planout.js: Unexpected character '‘' (77:81)

Thanks for removing those weird characters.
What context are you trying to run this in where this issue occurred?

start.js:
require("babel-core/register");
require('./planout');

with planout.js containing the code from the readme (first example under Usage), then:
node start.js
Node 5.5.0, babel 6.4.5.
It complains because the module is called planout and not PlanOut, and about the ‘-chars surrounding unit as they are illegal in JavaScript.
Just wanted to update the README so other people could copy/paste the example experiment and run it without fixing errors :smile:

The module is actually defined as PlanOut, not planout (https://github.com/HubSpot/PlanOut.js/blob/master/gruntfile.js#L16) so I'm not sure why this would be the case. Perhaps it is due to the fact that the npm module is called planout but that seems unlikely to me..
I haven't been able to replicate this on my machine with the same versions (it works for me whether I use PlanOut or planout) but after some brief googling it appears as though on some filesystems node modules are case-sensitive whereas on others they aren't. Given that this doesn't work for you, I'll merge this in however I'm curious what OS you're currently using.

Yeah, it hit me as well that this might be an OS issue. I'm on Linux (Xubuntu) which is case-sensitive. I see that PlanOut is installed as planout in node_modules, so I'm guessing that's the issue then.
I also tried to create a small script with ‘:
var test = ‘test‘;
console.log(test);

This throws an SyntaxError on my machine.


Is there no crates for Weld?

Is it possible to use Weld from rust as a crate dependency? If so, what is the name of the crate?

Not yet -- you'll have to build it yourself for now but we do want to publish a crate soon.

I look forward to it.

Weld now has a crate: https://crates.io/crates/weld
Thanks to @deepakn94 for doing this!


Moves to zipkin 1.0

zipkin 1.0 is a stable release with semantic version guarantees. This
means we can depend on it directly and not need to shade it.
By not shading it, we have the advantage of other integrations working
without classpath confusion. For example, someone can make a span
collector that writes to zipkin storage directly.

So where will the release party be?

@eirslett it will be eventually consistent

:shipit: :cocktail: :fireworks: :bowtie: :clap:

:+1: :tada:

judging by the positive emojis, merging :)