Couldn't open a raw socket. Error: Operation not permitted (1)

I moved to podman from docker.
When I run something like this:
podman docker run -t ullaakut/cameradar -t <IP_ADDRESS>
I get this error:
Loading credentials...ok
Loading routes...ok
Scanning the network...ko
  > [Nmap Warning] Couldn't open a raw socket. Error: Operation not permitted (1)
✖ error while scanning network: Couldn't open a raw socket. Error: Operation not permitted (1)

Hi, this looks like an error in your Docker configuration, either because of your OS or because of how the Docker capabilities are configured. A google search with the terms "Docker Couldn't open a raw socket. Error: Operation not permitted" seems to give relevant clues as to what the issue is. Let me know if you find a solution for your problem


legacy privacy groups are created with duplicate members

This might be an issue with Besu, or with Orion,
Running the web3js-eea/concurrentPrivateTransactions - a privacy group is created with "one" member but they are in there twice - privateFrom = privateFor
// options used to create a privacy group with only one member
const privacyOptions = {
  privateFrom: orion.node1.publicKey,
  privateFor: [orion.node1.publicKey],
  privateKey: besu.node1.privateKey
};

as in, if I run it with Besu/Orion, and then do
{
    "jsonrpc": "2.0",
    "method": "priv_findPrivacyGroup",
    "params": [
        [
            "GGilEkXLaQ9yhhtbpBT03Me9iYa7U/mWXxrJhnbl1XY="
        ]
    ],
    "id": 1
}

the result is a privacy group with the same member in there twice
{
    "jsonrpc": "2.0",
    "id": 1,
    "result": [
        {
            "privacyGroupId": "MC4aHjApHsGb0j5glU2iAj5KcR5LId52S0BU9mtdeuY=",
            "name": "legacy",
            "description": "Privacy groups to support the creation of groups by privateFor and privateFrom",
            "type": "LEGACY",
            "members": [
                "GGilEkXLaQ9yhhtbpBT03Me9iYa7U/mWXxrJhnbl1XY=",
                "GGilEkXLaQ9yhhtbpBT03Me9iYa7U/mWXxrJhnbl1XY="
            ]
        }
    ]
}

Orion accepts these privacy groups but Tessera rejecting in migration (PK violation)
2021-03-25 13:53:05.790+10:00 | vert.x-worker-thread-13 | ERROR | DefaultPrivacyController | Failed to store private transaction in enclave
org.hyperledger.besu.enclave.EnclaveClientException: Unique index or primary key violation: "PUBLIC.PRIMARY_KEY_6 ON PUBLIC.PRIVACY_GROUP(ID) VALUES 4"; SQL statement:
INSERT INTO PRIVACY_GROUP (ID, DATA, LOOKUP_ID, TIMESTAMP) VALUES (?, ?, ?, ?) [23505-200]
	at org.hyperledger.besu.enclave.Enclave.parseResponse(Enclave.java:173)
	at org.hyperledger.besu.enclave.Enclave.handleJsonResponse(Enclave.java:162)
	at org.hyperledger.besu.enclave.Enclave.lambda$send$0(Enclave.java:66)
	at org.hyperledger.besu.enclave.VertxRequestTransmitter.lambda$handleResponse$2(VertxRequestTransmitter.java:100)

If this issue only occurs in the Besu<>Orion mode I think we should wait to revisit if it causes a problem

@macfarla is this still an issue on latest and with Tessera?

closing. it's only an issue w Orion which is long deprecated


Exception cause deeplearning model to fail when calling fit with TimeSeriesPredictor

Warning: Exception caused DeepAR to fail during training... Skipping this model.
you tried to log -1 which is currently not supported. Try a dict or a scalar/tensor.

gluonts == 0.13.7
autogluon.timeseries == 0.8.1

Can you please check the versions of pytorch_lightning and lightning in your environment (if present)?
I wasn't able to reproduce this behavior with a fresh install using pip install autogluon==0.8.1. I suspect that you have pytorch_lightning >= 2.0, which is incompatible with autogluon==0.8.* (this AutoGluon version expects pytorch_lightning < 2.0).

I have pytorch_lightning 1.9.5

pip doesn't signal any compatibility problem

I'm on a virtual machine with linux

Ok I solved the problem !
I think I had the bug because I did:
pip install autogluon.timeseries ==0.8.1
instead of pip install autogluon ==0.8.1
Do you think it's possible to have acces to the DL model with autogluon.timeseries ?

If by "access to the model" you mean getting the model object, you can do that with
# load model as autogluon.timeseries.models.AbstractTimeSeriesModel
model = predictor._trainer.load_model("DeepAR").most_recent_model
# Get GluonTS predictor
gts_predictor = model.gts_predictor

I'm not 100% sure about the second question, I recommend just trying and seeing if anything breaks.

Sorry for a delayed response.
I was able to reproduce this problem locally:

There is a bug in tensorboard=2.5.0 that causes this issue.
An older version of tensorboard was present in the Python environment prior to installation of autogluon.timeseries, which causes this problem.
When a full version of autogluon is installed via pip install autogluon, tensorboard is updated to >=2.9 (thanks to requirements from autogluon.multimodal) and this problem is resolved.

I guess we should add a version cap on tensorboard to autogluon.timeseries to make sure that GPU training works in this setting.
Thanks a lot for reporting the problem @BrunoPinos!

Resolved by #3755


⚠ Bofrost.lu has degraded performance

In e1f069b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1800 ms

Resolved: Bofrost.lu performance has improved in a7b066b after 23 minutes.


Add HTTPS support to setRequestUrl

This is working for me. Now if a web server decides to strip out the double slash from an archived https URL, the resource will still be served as is done for http. For example, the following URL should now serve correctly instead of giving a Resource Not in Archive (notice the single slash after https:/): http://localhost:8080/wayback/20190411203428/https:/example.com/ . I am including an update to the release notes and a relevant URL in ReplayRequestParserTest. This will close #398 . Thanks for contributing this @peveikko !


Readded Doctrine binaries in the ZIP file and fixed them for the TGZ file

When using the Symfony installer, the Doctrine binaries were missing in the ZIP file and were broken in the TGZ file. This simple change brings those binaries back for both versions:

This fixes https://github.com/symfony/symfony-installer/issues/107

Thank you @javiereguiluz.

it seems that there is anotherbin missing: vendor/doctrine/dbal/bin/*


API Review of v1alpha1

As this project progresses, several outdated/obsolete aspects of the Build APIs have been uncovered. This will serve as a master tracking issue of API fields that should be removed in v1alpha1. We will consider this issue "done" when we have reviewed the current API and agreed that all removals from our initial implementation are complete. This does not necessarily mean that we consider Shipwright's API stable enough for a beta version.
The description of this field will be updated with accepted API changes.

[x] #674 Deprecate BuildRun status.succeeded and status.reason.
[x] #609 Rename build.dev -> shipwright.io
[x] #683 Remove unused fields from GitSource
[x] #687 Unify Go struct field names with YAML/JSON field names

👍

As discussed today in the Slack, we might also want to take this opportunity to audit the permissions assigned to the controller's Service Account.
When we did this in Tekton, we discovered some permissions we didn't actually need, and some which we only needed in Tekton's own namespace, instead of cluster-wide.

I´m adding an initial list of API changes from a brief recollection of issues. This is categorized by Breaking, Addition or Removal API changes. Looking forward for more contributions.
This is a living table, changes are expected to happen

API field
Resource
Change Type
Backwards Compatible
Description

CRD Scheme Group
All CRDs
Breaking
No. We can only have one single gvk per Golang struct. Existing CRDs will not longer work.
Move the scheme group from build.dev to shipwright.io, more info in issue 563

CRD Scheme Version
All CRDs
Breaking
TBD. Tekton Community should have done this before, e.g. migration approach
Move the scheme version from v1alpha1 to v1beta1

spec.sources
Build
Breaking
Yes. We will keep the spec.source as a deprecated field for a while. Users can continue using the deprecated one until the new one is adopted.
This comes as part of the implementation of EP remote artifacts

status.conditions
BuildRun
Addition
Yes. We kept the old Status.Reason and Status.Succeeded for a while as deprecated fields. Workflows relying on the deprecated fields should adopt the new Condition.
This was already done as part of adopting Conditions in BuildRun.

status.XYZ
BuildRun
Addition
N/A
There are new fields we can inherit from TaskRuns to report more data of the state of a build container image. Similar to issue 618

spec.parameters
Build
Addition
N/A
Based on issue 184, will this make it to the API?.. tbd.

spec.output.tag
Build
Addition
N/A
Based on issue 171, will this make it to the API?.. tbd.

spec.env
Build
Addition
N/A
Based on issue 224, will this make it to the API?.. tbd.

On going from alpha to beta, I'll put a cookie crumb link to https://kubernetes.slack.com/archives/C019ZRGUEJC/p1614018974009600 in slack around some of the pain upstream tekton has run into wrt supporting alpha clients once their API went beta and more fields were added.
As we discussed in the Mar 1 2021 community meeting today, we should review the k8s conventions / requirements around that scenario when deciding to move from alpha to beta.

I noticed that BuildStrategy's .spec.buildSteps specifies a type that wraps the K8s core v1.Container. This means that BuildStrategy authors can't take advantage of Tekton's script support. This might be fine; it also means the Shipwright API isn't tied too closely to Tekton's.
Aside from exposing script, it might be useful to fully specify the BuildStep type in Shipwright code, instead of relying on fields in v1.Container -- I wish Tekton had done this, and might try to make it happen some time before Tekton's v1.
The reason you'd want to specify the fields yourself is twofold:

Not all fields in v1.Container make sense in a BuildStrategy -- things like livenessCheck or stdin, or even things that Tekton itself blocks like terminationMessagePath.
If v1.Container adds a new field in a future release, it would become part of the Shipwright API at the next release. Whether or not that field is useful in Shipwright, it's nice to make that decision ourselves.

I also noticed that a number of fields in the API have a different name in the Go struct than in the JSON/YAML, such as:
type BuildSpec struct {
	Source        GitSource   `json:"source"`
	StrategyRef  *StrategyRef `json:"strategy"`
	BuilderImage *Image       `json:"builder,omitempty"`
...
}

(ref)
In this case, it can be hard to read the Go struct and understand what the corresponding YAML should look like. Is it image: or builderImage: or builder:? source: or gitSource:? strategy: or strategyRef:?
This can become painful when you're trying to write Go code against the API, since you have to keep both names in mind all the time. Maybe your IDE helps you, but we shouldn't require an IDE to have a good time.
This could be aligned in a backward-compatible* change, by renaming the Go fields/structs to align with the JSON/YAML struct tags. This could be a good-first-issue even on the pre-beta timeline.

Tekton has defined backward compatibility to mean "YAML that used to work still works"

it might be useful to fully specify the BuildStep type in Shipwright code

+1
Yes, there's an open ticket somewhere on this.

+1
Yes, there's an open ticket somewhere on this.

Possibly https://github.com/shipwright-io/build/issues/224 ?

In this case, it can be hard to read the Go struct and understand what the corresponding YAML should look like. Is it image: or builderImage: or builder:? source: or gitSource:? strategy: or strategyRef:?

We were going back and forth on this in the initial days. Fixing this sounds like a good thing to do.

This could be aligned in a backward-compatible* change, by renaming the Go fields/structs to align with the JSON/YAML struct tags. This could be a good-first-issue even on the pre-beta timeline.
*Tekton has defined backward compatibility to mean "YAML/JSON that used to work still works", not necessarily that Go code still compiles.

Agreed.
Yeah, I wouldn't bother about go code compatibility here. Our project is too young to make that promise.

Possibly #224 ?

Actually a different one :(
@gabemontero had brought this up and there was great agreement on this.

@adambkaplan wondering if this one should not belong to the v0.4.0 milestone, it feels like this is a "living" issue that should continue open for more weeks?

@adambkaplan wondering if this one should not belong to the v0.4.0 milestone, it feels like this is a "living" issue that should continue open for more weeks?

I agree @qu1queee .  I'm moving it out while Adam is on PTO.  If he feels strongly about it when he gets back, we can go from there.

@gabemontero also points out that ObjectReference is discouraged
// ObjectReference contains enough information to let you inspect or modify the referred object.
// ---
// New uses of this type are discouraged because of difficulty describing its usage when embedded in APIs.
//  1. Ignored fields.  It includes many fields which are not generally honored.  For instance, ResourceVersion and FieldPath are both very rarely valid in actual usage.
//  2. Invalid usage help.  It is impossible to add specific help for individual usage.  In most embedded usages, there are particular
//     restrictions like, "must refer only to types A and B" or "UID not honored" or "name must be restricted".
//     Those cannot be well described when embedded.
//  3. Inconsistent validation.  Because the usages are different, the validation rules are different by usage, which makes it hard for users to predict what will happen.
//  4. The fields are both imprecise and overly precise.  Kind is not a precise mapping to a URL. This can produce ambiguity
//     during interpretation and require a REST mapping.  In most cases, the dependency is on the group,resource tuple
//     and the version of the actual struct is irrelevant.
//  5. We cannot easily change it.  Because this type is embedded in many locations, updates to this type
//     will affect numerous schemas.  Don't make new APIs embed an underspecified API type they do not control.
// Instead of using this type, create a locally provided and used type that is well-focused on your reference.
// For example, ServiceReferences for admission registration: https://github.com/kubernetes/api/blob/release-1.17/admissionregistration/v1/types.go#L533 .

We use LocalObjectReference to reference secrets in a few places, for example here

@gabemontero also points out that ObjectReference is discouraged
// ObjectReference contains enough information to let you inspect or modify the referred object.
// ---
// New uses of this type are discouraged because of difficulty describing its usage when embedded in APIs.
//  1. Ignored fields.  It includes many fields which are not generally honored.  For instance, ResourceVersion and FieldPath are both very rarely valid in actual usage.
//  2. Invalid usage help.  It is impossible to add specific help for individual usage.  In most embedded usages, there are particular
//     restrictions like, "must refer only to types A and B" or "UID not honored" or "name must be restricted".
//     Those cannot be well described when embedded.
//  3. Inconsistent validation.  Because the usages are different, the validation rules are different by usage, which makes it hard for users to predict what will happen.
//  4. The fields are both imprecise and overly precise.  Kind is not a precise mapping to a URL. This can produce ambiguity
//     during interpretation and require a REST mapping.  In most cases, the dependency is on the group,resource tuple
//     and the version of the actual struct is irrelevant.
//  5. We cannot easily change it.  Because this type is embedded in many locations, updates to this type
//     will affect numerous schemas.  Don't make new APIs embed an underspecified API type they do not control.
// Instead of using this type, create a locally provided and used type that is well-focused on your reference.
// For example, ServiceReferences for admission registration: https://github.com/kubernetes/api/blob/release-1.17/admissionregistration/v1/types.go#L533 .

We use LocalObjectReference to reference secrets in a few places, for example here

Small clarification ... I believeLocalObjectReference is OK, given it is vary narrowly scoped, and that you have to explicitly opt into things like api version, kind in the name for it to resolve, like /api/v1/pods/some-name:
// LocalObjectReference contains enough information to let you locate the
// referenced object inside the same namespace.
type LocalObjectReference struct {
	// Name of the referent.
	// More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
	// TODO: Add other useful fields. apiVersion, kind, uid?
	// +optional
	Name string `json:"name,omitempty" protobuf:"bytes,1,opt,name=name"`
}

It is only ObjectReference with its explicit fields for each element (api, kind, etc.) where I think the issue arises.

I think the guidance is still reasonable, especially:

// Instead of using this type, create a locally provided and used type that is well-focused on your reference.

paired with

// TODO: Add other useful fields. apiVersion, kind, uid?

That TODO makes me worried that LocalObjectReference might grow to have all the problematic fields of ObjectReference.
This is basically just another instance of the problem outlined in https://github.com/shipwright-io/build/issues/516#issuecomment-802204190 -- we shouldn't use k8s built-in types we don't control. It's easier to make this switch sooner rather than later.

@ImJasonH from your comment, what does script support in Tekton means? Regarding the usage of corev1.Container, we can certainly move to a slimmer struct, however I dont see this as a critical todo item. What we can do is to layout first which fields under corev1.Container we need and which ones not, and then add this to our list of changes before GA.

@ImJasonH from your comment, what does script support in Tekton means? Regarding the usage of corev1.Container, we can certainly move to a slimmer struct, however I dont see this as a critical todo item. What we can do is to layout first which fields under corev1.Container we need and which ones not, and then add this to our list of changes before GA.

Tekton supports a script field in the Step type, that is a bit nicer to use than command/args provided by v1.Container by default.
https://tekton.dev/docs/pipelines/tasks/#running-scripts-within-steps
I agree about moving off v1.Container not being high priority, but I do think it should be relatively non-distruptive to users, so I don't think we need to hold it for GA/v1 necessarily.

From grooming:

We need to define the whole API for spec.sources
Consider removing the service account support . We still have a blocker here, @imjasonh to provide more context.
On spec.dockerfile, consider removing it in favor of params or should it remain there?
Status Results for BuildRuns proposal https://github.com/shipwright-io/community/pull/13

Consider removing the service account support . We still have a blocker here, @imjasonh to provide more context.

This started in https://github.com/shipwright-io/build/issues/662 and resulted in https://github.com/shipwright-io/build/issues/679
Generating service accounts is an unusual feature, which requires users grant Shipwright massive permissions inside the cluster, and should be deprecated before we consider the v1alpha1 API to be stable and close this issue.

Done with https://hackmd.io/BsPjvGFwQgmVeJRe6FJfMA


Python3 valid syntax

I was trying to run this script on Python, but it does not work with Python 3.
Added the minimal changes to get it running.

LGTM


Translate "Policies: Support" into Kor

link: https://azure.github.io/azure-sdk-korean/policies_support.html

I would like to suggest to re-work with relevant commit messages rather than just writing as "second" or "third"


Update PARTICIPANTS

#1 referenced!

Are there any updates or should we close this PR as spam?

Updated to correct directory and add a note. Thank you.

PR can be closed.

spam


Adding remote_storage example for KairosDB

Adding an example for KairosDB as remote storage. Will be useful for people using KairosDB as remote storage with Prometheus.
Kindly let me know if more work is needed for this request to be approved and merged.

Thanks for writing this. This code is intended largely as an example of how to write such a thing, we don't wish to expand it beyond the 3 systems we have. I'd suggest putting this in a new repository, and it can then be linked from the Integration page on the docs.


Switch from WCF OData to Web API OData

Second part of NuGet/NuGetGallery#3061
NuGet.Server has been rewritten to use Web Api OData controller instead of WCF Dataservice,
New projects added:

src\NuGet.Server.V2. Class library for creating NuGet feed(s) as Web Api OData controllers. Mostly based on code from NuGetGallery and existing NuGet.Server.
samples\NuGet.Server.V2.Samples.OwinHost. Console application that exposes controller from NuGet.Server.V2 as three NuGet feeds.
tests\NuGet.Server.V2.Tests. Tests ported from NuGet gallery

Existing projects (not modified in this PR):

NuGet.Server.Core - Class library used by NuGet.Server and NuGet.Server.V2.

Todo:

[x] Add tests for ApiKeyPackageAuthenticationService.cs
[x] Create samples folder. Move and rename OwinSampleHost project.
[x] Update method signatures in NuGetODataController to match the ones in NuGetGalleryODataController / ODataV2FeedController (Return QueryResult as IHttpActionResult instead of IQueryable/Enablequery, etc.)
[x] Port relevant tests from NuGetGallery
[x] Update NuGet.Server (IIS project) to expose ODataController from NuGet.Server.V2 instead of WCF dataservice.

Hi @andulv, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Nice one! Added a few nits + a few remarks on reusing code / method return types from NuGetGallery which will allow us to replicate unit tests later on.
Really good stuff so far!

Just added some new commits. I have created NuGet.Server.V2.Tests and started porting tests from NuGetGallery. Most of the ported tests passes, but some fail.
@maartenba please have a look and see if this is what you had in mind.

Thanks @andulv! Will clone your fork tomorrow and give it a good run through.

I have copied the tests over and mostly done the mimum modifications needed to get them to compile. (Keeping logic, replacing mocking).
Only mocking done so far is IServerPackageRepository, primariliy the GetPackages method. This is more or less an exact port of the code in NuGetGallery which mocks their IEntityRepository.GetAll method.
Problem is that IEntityRepository is a minimal repository implementation where all access is done through GetAll. It is more similar to IServerPackageStore in NuGet.Server than IServerPackageRepository.
So the tests cover logic both in IServerPackageRepository and the controller. And are therefore inaccurate as long as I just mock IServerPackageRepository.

The /DataServices/Packages.svc URL errors out. Perhaps delete the file entirely and add a route for it that uses Web API as well?

Regarding tests, feel free to update them as needed, just want to make sure te OData interfaces return the correct data/filtering/... (mainly there to prevent V2 protocol breaks)

Can you add me as a committer on your fork? Made a few changes myself but can't commit them back :-)

Irrelevant tests removed (Deleted makes nu sense in NuGet.Server, it's a galery-specific thing)
Added file headers everywhere and did some code cleanup e.g. remove using that were not required

If easier to work with a patch file, here's one: https://www.dropbox.com/s/z8xd1ogo1qhhs49/patch.diff?dl=0

@maartenba Just added you to my fork.

Just pushed changes

All tests passes. Removed tests for search method, since this method is basically just a forward to IServiceBasedRepository.Search in NuGet.Core.

@maartenba I did not quite understand your comment about  '/DataServices/Packages.svc' above. This file is part of the original NuGet.Server which is untouched in this PR.
And the URL should still be working if you run that project. But it is not present in the sample app or the V2. library.

I updated the top comment to reflect current status of this PR.

Thanks! I think the "Update NuGet.Server (IIS project) to expose ODataController from NuGet.Server.V2 instead of WCF dataservice." task can go in this PR as well?

Just committed an (automated) cleanup. Starting to shape up as a great PR :-)

Should we remove the JSON output in the API? If you now navigate to /nuget in the browser, you get a JSON document instead of the Atom feed. I know people expect that to be there so disabling JSON (or not having it as the default) would be good.

I added code to reorder the mediaformatters collection so that json formatters comes after xml formatters. That seems to result in xml/atom being prioritised over json.
The solution feels a little bit hackish so feel free to modify (for example just remove json formatters).

Looks okay to me. Just FYI here's how we do it in Gallery: https://github.com/NuGet/NuGetGallery/blob/master/src/NuGetGallery/App_Start/NuGetODataConfig.cs

@yishaigalatzer can you have a pass o nthis one as well? Switch to Web API OData is nearing completion here

@maartenba  @yishaigalatzer Is there any progress in reviewing / accepting this PR?
I am prepared to do more testing and modifications, but I have put this on hold until more feedback.

/cc @yishaigalatzer can you also have a pass on this PR? LGTM and gets rid of WCF, always nice :-)

Are we ever going to get this merged?

It's in! Thanks all for this great great contribution!
An official release is pending a few other changes, but a pre-release package is available:
Install-Package NuGet.Server -Version 2.14.0-dev-0003 -Source https://dotnet.myget.org/F/nuget-build/api/v2

Thanks all. Now we've got this, any chance we could make this work with dotnet kestrel so that I could build it into a Linux container image without the need of IIS?

That's a bit more work. We have a tracking issue for it but no immediate plans - https://github.com/NuGet/NuGetGallery/issues/3094

Like @maartenba says, that's a different effort, webapi doesn't run on kestrel at the moment. This step will enable it running on owin.
I'm sure there are several issues that aren't covered to make this server run on Linux, and again no plans to invest in this area by the team, though we would consider a good thought out PR

@maartenba Sorry to disturb the Christmas atmosphere, but can the 2.14.0 graduate from being a pre-release now?

@xied75, the Web API implementation of NuGet.Server will actually not ship as 2.14.0. 2.14.0 will be a minor release to the WCF implementation fixing a packaging bug. The Web API implementation will ship later after some additional internal testing and improvements.


Tabs cant unmute.

Even when i press ctrl+m or fn it visually unmutes but doesnt give any sound.this problem happens only with edge browser.i have used in different browsers and play youtube videos through my earbuds flawlessly .i have uninstalled and installed again at no change.can anybody help me?i use an hp all in one 2020 27 inch.
Many thanks in advance!

I'm sorry you're having this problem. Unfortunately, here isn't the right place to report it. Would you please be so kind and report your issue using Edge's feedback tool? Here's how:

Click the ... icon in the top right corner of Edge.
Select Help and feedback.
Click Send feedback.

A window will appear where you can report your issue and provide more details, including screenshots and system details.


Responsive Card Design Added

Responsive card design updated for screen width >900

Kindly go through contributing.md that show how to properly setup you devlopment enviornment.

You are using npm. we are using yarn. You have upgraded some packages. This was unnecessary.(follow the dev env setup steps)
There are unnecessary/irrelevant files committed in this PR. Only ReImagineCommite tsx file was needed.
Always Link PR to its respective (Kindly please read contributing.md before creating PRs/ Issue. Everything is mentioned there.)

Sorry for the inconveniences. You can merge the RelmagineCommite.tsx only or should I make another pull request?

You can push more commits to your card-design to update this PR. create commits that does all the mentioned corrections

I've made the changes please go through it and let me know it it's fine

Always Link PR to its respective (Kindly please read contributing.md before creating PRs/ Issue. Everything is mentioned there.)

Please read contributing.md.

Each row now has two items at width > 900px.
This resolves issue: #107

Responsive design for ReImagine commute card is updated specially for width > 900px.
Fixes : #102

I have updated your PR description. see there


Can't just use "all available" hardware resources

Describe the bug
According to the Docker documentation: https://docs.docker.com/config/containers/resource_constraints/ there should be by default no resource constraints. However, if I do not specify how much RAM and how many CPUs to use, it always just uses 1 core and 2 logical processors and 5GB of RAM. Even if I specifically say --cpus 0 when creating the container, which should use all available cores, it still restricts it to the default.
Right now I have no idea how to tell the container to use all available resources without specifying all resources. If this is a bug in Docker for Windows and I need to report it there, please tell me.
To Reproduce
Steps to reproduce the behavior:

Make a docker image from mcr.microsoft.com/windows/servercore:ltsc2022
docker build -t myimage -m 4GB .
docker run --name Windows -it myimage
In the container execute wmic cpu get NumberOfCores,NumberOfLogicalProcessors
If you have more than one core, it will still only show one

Expected behavior
The container should use all available resources
Configuration:

Edition: Windows 11
Base Image being used: Windows Server Core
Container engine: docker
Container Engine version: 24

Additional context
Add any other context about the problem here.

🔖 ADO #47827961

Hi @Outtay,
There are two kind of Windows Containers:

Process Isolated Containers
Hyper-V Isolated Containers.

For Hyper-V isolated containers, we can have WCOW and LCOW.  WCOW means Windows Container on Windows, LCOW means Linux Container on Windows, docker client installation called WSL.

For process isolated containers, we can't assign the CPU and memory to a container like we can do for a Hyper-V isolated container, but we can limit how much CPU and memory a container can consume. For example,

docker run -it -m 4096M ---cpu-percent=20  --name mytest windows cmd.exe
This command will create a container that can only consume up to 4GB physical memories and 20 percent of the total available CPU. As the CPU core concerns, it still can see all the cores inside the container, but it can only consume up to 20% of the CPU resources.

For Hyper-V isolated containers, it will assigned the CPU and memory resources at the container startup time, just like a Hyper-V VM scenario.  For example:

docker run -it -m 4096M --cpu-count=8  --name mytest --isolation=hyperv windows cmd.exe
With this command, the docker will create a container with 4GB and 8 cores assigned to the container, event the container host has 12 cores.  BTW, the default Hyper-V container CPU core is 2 and memory is 1GB.
Please let me know if you have any questions.

Hi @Howard-Haiyang-Hao,
thanks for the response.
Under Linux and according to the general Docker documentation there shouldn't be any resource constraints by default. I also couldn't find any documentation stating that Windows works differently in that regard, as in the case of using Hyper-V Isolated Containers and specifying no resources, not all resources can be used by the container. However, I was under the impression that I had the same problem when using Process Isolated containers. That seemed to have been an error on my part. When I tested it right now all resources were available when specifying none.
My specific use case is setting up different physical hardware for running pipelines and building and testing an application in a docker container. Since they should not be doing anything else I want them to use all available resources. However, they're all different machines and therefore have different parameters, which means that specifying the correct parameters is a minor source of error. An unnecessary one, as I should not need to specify it.
Since using process isolation works as I would expect it, I can try using that and hoping that it works. However, with Hyper-V isolation mode this should in my opinion be changed to work consistent with other modes or would need to be documented as an exception (if it isn't already. I couldn't find that though).
As a workaround it would have also been nice, if there was an option that just results in everything being used (like entering 0 or INT_MAX for cpu-count or 100 for cpu-percent would then result in the maximum amount of cores being assigned and used)

I've created a PR (https://github.com/moby/moby/pull/43269) to allow CPUs to be configured for docker build teo years ago to solve this issue, but it is being ignored.

docker run -it -m 4096M --cpu-count=8 --name mytest --isolation=hyperv windows cmd.exe

This works for docher run, but its very annoying that its not supported for docker build

This issue is going stale. Closing for now. Please re-open if you have additional questions.

How does it make sense to close it, if this is not resolved or a solution provided. It should be kept open until resolved?!

@Howard-Haiyang-Hao should we keep this open? Do we have any updates to share?


DPI Doesn't Change When Modifying X11 Config Files

Please paste the output of the following command here: sudo edit-chroot -all
name: trusty
encrypted: yes, unlocked
Entering /mnt/stateful_partition/crouton/chroots/trusty...
crouton: version 1-20160330180425~master:43e2fca0
release: trusty
architecture: amd64
xmethod: xorg
targets: xorg,touch,xfce,extension,xiwi,core,cli-extra
host: version 7834.70.0 (Official Build) stable-channel samus
kernel: Linux localhost 3.14.0 #1 SMP Sat Apr 9 16:02:43 PDT 2016 x86_64 x86_64 x86_64 GNU/Linux
freon: yes

Please describe your issue:
-dpi flag doesn't work in X11/xiwi config files (in /etc/crouton/)
If known, describe the steps to reproduce the issue:
I'm using the instructions from this page specifically trying to fix high DPI display on my Chromebook Pixel 2015.
I've tried using the X11 -dpi flag in the /etc/crouton/xserverrc-local file and starting via xorg. Any DPI setting I put in the XARG line (XARGS="$XARGS -dpi 135x135") doesn't have any effect when starting up.
Also tried doing the dpi setting for xiwi via

To support HiDPI in your application window, you need to:
Check HiDPI in your "Crouton Integration" extension. (By doing this alone, the font will be super small).
Edit your chroot: sudo enter-chroot sudo vi /etc/crouton/xserverrc-xiwi add "-dpi 135x135" at the end of XARGS line.

Starting up via startxfce4 and HiDPI checked in the extension again doesn't produce any difference with any dpi setting there.
Any idea if this settings still works or if X11 is just ignoring it? Or am I just clueless and doing something incorrectly? Would love to have some support for the display on my new Pixel :-P

Did you find any solutions?

Yeah I switched to startxfce4 -x xorg. Then I switched to chrx with a complete Xubuntu install)

I have the exact same problem. Any ideas why -dpi parameter is being ignored?


Validation: preserveView

User story 1907185
Guidance: https://review.docs.microsoft.com/en-us/help/contribute/versioning-for-contributors?branch=master

Docs Build status updates of commit 54c3e38:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-services-the-azure-cli-can-manage.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@ttorble
Go ahead and take this out of draft so Delora can merge it. :)


Bug: SQLite Identity field cannot identified

Bug Description
Repodb cant determine the IdentityField in the sqlite table when create statement is using " around column names. If using the sql statement below, the code is returning ""Id"" (see picture). This is resulting in issue in BaseStatementBuilder.CreateInsert(), the insertableFields is not excluding the id field.
If you tell me how a potential fix would look like I can prepare a PR.

Exception Message:
None
Schema and Model:
Please share to us the schema of the table (not actual) that could help us replicate the issue if necessary.
Not working:
CREATE TABLE "User"(
"Id" INTEGER PRIMARY KEY AUTOINCREMENT,
"Username" text,
"Password" text,
"Email" text,
"CreationDate" DATETIME,
"ModificationDate" DATETIME,
"Disabled" integer NOT NULL DEFAULT '0',
"DisabledDate" DATETIME
);

Working
CREATE TABLE User(
Id INTEGER PRIMARY KEY AUTOINCREMENT,
Username text,
Password text,
Email text,
CreationDate DATETIME,
ModificationDate DATETIME,
Disabled integer NOT NULL DEFAULT '0',
DisabledDate DATETIME
);

And also the model that corresponds the schema.

public class User
{
    [Identity]
    public long Id { get; set; }
    public string Username { get; set; }
    public string Password { get; set; }
    public string Email { get; set; }
    public DateTime CreationDate { get; set; }
    public DateTime ModificationDate { get; set; }
    public bool Disabled { get; set; }
    public DateTime? DisabledDate { get; set; }
}

var connectionString = $"Data Source=\"MemoryDb\"; Mode=Memory; Cache=Shared";
var sut = new UserRepository(connectionString);

var item = sut.Insert(new User { Username = "UnitTest" + new Random().Next(0,100000) });

Library Version:
Example: RepoDb v1.12.7 and RepoDb.SqLite v1.1.3

What a catch. Yeah, it sounds to me that the fix can be found here. Most likely, within the ParseTableFieldsFromSql method, or just simply follow the code.

What a findings! Thanks for this. 😄
Yeah, it sounds to me that the fix can be found here. Most likely, within the ParseTableFieldsFromSql method, or just simply follow the code.


Set a maximum length for serialization of strings

Refs GH-284

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Unknown Error when bot joins a voice channel

Please tick all applicable boxes.

[X] I am using Python 3.5.3 or higher (run python --version on the command line)
[X] I have followed the official guides to install the bot for my system
[X] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[ ] The latest master version (release-260419)
[ ] The latest review version

What type of issue are you creating?

[X] Bug
[ ] Feature request
[ ] Question

Description of issue
The bot is having trouble connecting to the voice channel I am in. It would join the channel and after a few seconds leave and come back. The error message I got is below:
musicbot.log
[ERROR:bot] Unknown error attempting to connect to voice
Traceback (most recent call last):
File "C:\Users\micro\MusicBot\musicbot\bot.py", line 431, in get_voice_client
vc = await self.join_voice_channel(channel)
File "C:\Users\micro\MusicBot\musicbot\bot.py", line 395, in join_voice_channel
await voice.connect()
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\voice_client.py", line 258, in connect
self.ws = yield from DiscordVoiceWebSocket.from_client(self)
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\gateway.py", line 568, in from_client
timeout=60, loop=client.loop)
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\asyncio\tasks.py", line 358, in wait_for
return fut.result()
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\site-packages\discord\gateway.py", line 65, in _ensure_coroutine_connect
ws = yield from websockets.connect(gateway, loop=loop, klass=klass)
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\site-packages\websockets\py35\client.py", line 19, in await
return (yield from self.client)
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\site-packages\websockets\client.py", line 215, in connect
extra_headers=extra_headers)
File "C:\Users\micro\AppData\Local\Programs\Python\Python36\lib\site-packages\websockets\client.py", line 125, in handshake
raise InvalidStatusCode(status_code)
websockets.exceptions.InvalidStatusCode: Status code not 101: 403
WARNING: Failed to connect, retrying (2/5)
WARNING: Failed to connect, retrying (3/5)
WARNING: Failed to connect, retrying (4/5)
WARNING: Failed to connect, retrying (5/5)
[CRITICAL:bot] Voice client is unable to connect, restarting...
Any help would be appreciated. Thank you.
Steps to reproduce

Running "runbot.bat"
Summoning the bot to the selected voice channel

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.

Could you do `python -m pip install -U discord.py[voice] and report back?

Could you do `python -m pip install -U discord.py[voice] and report back?


[question] Why node16 is required

Can you clarify on why we need to use node16+ ? Because I just tested it with node v14.17.3 and it worked as expected so far:

is it because of the usage of node: protocol? because it is available in nodejs v14.13.1 for ESM modules

I'm aware that it got backported to v14, but it's gonna reach EOL soon and I was too busy to quickly search how to allow v14 and >v16 but not v15 (which didn't get the backport) in the engine package field. Feel free to make a PR, otherwise i'll make it at some point

Since this lib generates both CJS and ESM code I guess the minimum should be set to v14.18.0 and above (without taking v15 into account)

got it
I'll open a PR then, thanks


fix Remove arrow_flight_sql group from regression test

What problem does this PR solve?
Problem Summary:
Add ./run-regression-test.sh --run ... -g arrow_flight_sql to the pipeline. then add the group arrow_flight_sql again, which is safer.
Check List (For Author)

Test

[x] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Dedicated Module.containsUUID method with a cache

Pull Request Description
Fixes #5781 by caching all UUIDs in each module in a Map.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] All code follows the
Java,
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[ ] Unit tests have been written where possible.

I repeated the #5781 scenario with this fix and the UpsertVisualizationJob takes less than 300ms now and the findModuleByExpressionId function wasn't even visible in the sample:


corrId is accessed from within inner class

java: local variable corrId is accessed from within inner class; needs to be declared final

@gevorg Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@gevorg Thank you for signing the Contributor License Agreement!

Thank you!. May I ask you to submit the same change to the runnable version? :)

@michaelklishin done already ;)

Doh, I missed the notification somehow. Thanks again!


Rank and unrank methods in v1.0 only work for 2-ary trees

The algorithms used by the rank and unrank methods in v1.0 are inherently designed around binary trees, and cannot be used for k-ary trees. This should be generalized.
In order to do so, most likely the algorithm will have to be adjusted from its current
(a % b, a // b) formulation to something along the lines of
(a % b % c, a // b % c, a // b // c)?

Closing with wont_fix.
k-ary trees can be represented by 2-ary trees.
I do not believe there is practical value in this enhancement request, at least not in the next two years.


getline: Improve Unicode support

Okay, as mentioned in Gitter the other day, I have some improvements for getline that I want to share. This PR comprises enhanced support for Unicode and wide characters.
Some ideas about how to do this come from Bestline (which I was in progress of attempting to port when getline was dropped into spork; and evolving getline is quite a bit easier than minifying bestline.) The triple license notice in getline.c is due to the table being borrowed from the output of Cosmopolitan Libc, essentially copying its inner database -- please see 5defd38 for some context. That said, I'd like to rework the table generation tooling to depend directly on Unicode data, in which case that notice will no longer be necessary. (This has been resolved.)
This is currently a draft because it still needs unit tests at least for utf8 and _getline, and possibly getline itself; I hope to get around to them in the coming couple of days. (Tests for getline itself will come in a later PR.)
~~(Also the commit history is kind of noisy, it might be better to squash it.)  ~~
(Also I haven't tested all the intricacies yet with things like history and autocompletion with Unicode contents. Again, hence why it's a draft.)

Short note: The idea I had on how to test getline was essentially to:

Mock out rawterm via the module loader;
Probably have rawterm/{begin,end} be noops;
Have rawterm/getch return a predefined character instead (or maybe read from a channel or something, idk);
Have rawterm/size return a predefined size;
Set err to be a buffer;
Assert that for a given sequence of inputs and size, a sensible output is produced.

It's the best I could think of without introducing needless layers of abstraction in getline whose only real purpose would be to enable testing.  If there are simpler ways of doing the same, please let me know.
The point is that it feels like getline should be tested holistically (or end-to-end, as the youths say) from what the user would see at the terminal, as well as the individual components where it makes sense.

Looks good! Definitely some questions though.
At this point, what code is from Bestline? I literally don’t see any. The character tables seem to be auto generated.
Also I don't see why the print wrapper code with protect-term is really needed.

At this point, what code is from Bestline?

Fair cop—there's no code from Bestline (or Cosmopolitan, for that matter); the notice was targeted at an earlier version (pre 9ea225755f02f72841060349888362894105df7f) and by this point can probably be removed. (Given that IANAL, I'm not entirely sure what the status of the data itself is, regarding database rights, especially for Unicode data, so I'd leave a notice in there still, but the final call is yours.)

I don't see why the print wrapper code with protect-term is really needed.

It's part of supporting what I called "async print", that is, allowing other fibers to print output while getline is still in progress without messing up the getline state or making it look weird. Doing this requires either calling these getline-prefixed functions or setting *out*/*err* in the fiber env though.
Now that I think about it, it would probably be better served as a separate PR (if it even has a place in getline at all), the fact that it made its way into this one is essentially an accident on my part, so I'll remove it from this PR.

(Something appears to have broken with CI and native modules. Same error can be observed on master of this repo, and I can't reproduce locally.)

Okay, sorry, but I'm postponing tests for getline proper to a separate PR as well. @bakpakin Please take a look again, thank you.

Issue was a broken monkey patch in janet-lang/jpm, which has been reverted.

LGTM! Thanks for all of the work on this, especially the testing code! Looks like the code is ready to me merged and developed on the main branch.


feat(playground): highlight the ast when navigating the code

No idea on how to do this, any pointers are appreciated.

Got help from twitter https://twitter.com/bluwyoo/status/1667554444404457472
https://github.com/sveltejs/sites/blob/34a83937f260132dcea8a9e2fd3619631ac5012a/packages/repl/src/lib/Output/AstView.svelte#L14-L43

Done in https://github.com/oxc-project/oxc/pull/1619


=>no source available

Delve Debugger
Version: 0.11.0-alpha
Build: d756eba13a4fbde34cea847276b3f5ce044ce916
OS X 10.11.3
Debugging any *.go program (dlv debug hello.go) and using "ls" to list source, displays:
(dlv) ls
Stopped at: 0x7fff68e39000
=>no source available
Other errors:
(dlv) break 13
Command failed: could not determine current location (scope is nil)
(dlv) ls 13
Command failed: could not determine current location (scope is nil)
(dlv)
What is required to display source code?

set a breakpoint using the filename break hello.go:13 or a function name break main.main then continue. Once the breakpoint is hit the other commands will work, it's just that you aren't stopped at a meaningful address.
Duplicate of #374.

Brilliant, that wasn't clear to me in the write up. Thanks for the rapid follow up!

No problem.


feat: [FC-0047] Account Settings and Profile split

Split account settings and the user profile
Design: https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&node-id=0-1&mode=design
Quick demo:
Setting button on Discover, Dashboard and Profile screens.

Light and Dark themes:

Settings screen:

Manage account:

Landscape:

Ipad:

Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@IvanStepanok, please check this, the profile data in ProfileView does not change if I change it on the manage account screen.
https://github.com/openedx/openedx-app-ios/assets/127732735/d33b2499-5664-4dc9-a07c-d9e78829efb2

Please add navigation titles for each controller and fix long tap back navigation:
https://github.com/openedx/openedx-app-ios/assets/480059/7c057280-dd18-4c0d-9450-e7185ff40261

Is that design decision to hide info on profile overview? In develop build i can see "year of birth" and "bio", in that branch only bio:

develop
profile
Manage account

Hi @forgotvas and thanks for the review!
The year of birth was removed by design, it's true, I double-checked it:
https://www.figma.com/file/iZ56YMjbRMShCCDxqrqRrR/Open-edX-Mobile-App-All-Screens-v2.1?type=design&node-id=0-1&mode=design
I fixed the back buttons and titles in the video settings too. Thanks!🙏
https://github.com/openedx/openedx-app-ios/assets/128456094/1c58c108-68f7-4c21-9385-b3846fa159fc

Started reviewing PR

The location of the back button varies across screens in landscape mode.

Screens

Thank you, @shafqat-muneer, for the review! All requests have been satisfied. Ready for another pass 🙌

@IvanStepanok Thank you for considering the feedback. 🎉
Overall, I have a few additional minor observations that might require attention.

Observed overlapping on manage account and settings screens

Settings
Manage Account

Safe area is visible in Video download quality screen and it's covered in Video settings screen.

Video download quality
Video settings

The position of the back arrow appears to be incorrect in comparison to the other screens.

Finally, although it may not be directly related to the changes made in this pull request, I noticed it while reviewing the PR. We might want to address it in a separate PR. In the pre-login user experience, the course details aren't opening; it consistently shows an error.

https://github.com/openedx/openedx-app-ios/assets/11990137/c138dbdd-5c6a-4f7a-8f8c-4909858a058f

Hi, @shafqat-muneer, and thanks for the review! All problems are fixed. 🙌

@IvanStepanok Thanks for addressing the feedback. 🎉
All changes LGTM 👍. PR is approved.
It seems minor indentation / formatting related comments are missed. Please also address them before merge.

Point#1
Point#2
Point#3

Separate issue is create here for this observed problem.

Finally, although it may not be directly related to the changes made in this pull request, I noticed it while reviewing the PR. We might want to address it in a separate PR. In the pre-login user experience, the course details aren't opening; it consistently shows an error.

Hi, @shafqat-muneer, please take a look 🙌

Hi @IvanStepanok
Thanks
LGTM 👍

@IvanStepanok 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


[Blog] Use long options in examples

Thanks for this write up, I am enjoying going through it!
Since this is a post that is intended to teach may I suggest you use long options instead of short options. This would also save some explaining on what the short options are. It is self documenting to use long options (most of the time).
e.g.
docker run --name db -e MYSQL_ROOT_PASSWORD=123 -p 3306:3306 mysql:latest

docker run --name db --env=[MYSQL_ROOT_PASSWORD=123] --publish=3306:3306 mysql:latest

Also, step #3 for the command above discusses the --detach command but it isn't in the example.

I've fixed step #3, for now I've left the short examples but documented the long form below them. This is because it's much more common to see the short values, WDYT?

That is a happy balance, thanks.

I know it would be a lot of work but adding clarification throughout what the long options are would make it a better teaching tool, not just the one example above.
e.g. docker run -it ubuntu, if it were docker run --interactive --tty it would make more sense.

I am not suggesting to replace that just do what you did after the first usage of it and clarify what those options do and/or state the long options.

Good idea, will change this when I get a little time!


Fix/supress deprecation warnings

Types of PR

[ ] New Features
[ ] Upgrade of existing features
[x] Bugfix

Link to the issue
Description
Suppress deprecation warnings from setup.py
How to review this PR.
Others

This pull request was created by @kyabe2718 in response to @yamacir-kit's request to "suppress warnings in colcon build".
After @kyabe2718's investigation, he found that the warnings are not caused by the code in this repository.
@kyabe2718 presented a tentative workaround in this pull request, but we have decided that it is not worthwhile to suppress the warnings by including this workaround, so we are closing this pull request.


Added Python script to generate Google Pickle String

Fixes #
Proposed Changes

Generate Google Pickle String

@sreedharande Please include sample data for GitHub_CL and  GitHubRepoLogs_CL in the json format in PR.
Thanks,
Aditi Maheshwari

@sreedharande , as this is community contribution, as per the policy, we will not have community contributions under solutions. They has to be under individual folders (Connectors in Sentine\Data Connectors, Analytic rules in Sentinel\Detections etc). Please move them out of solutions.


Grammar incorrect

Some of the grammar for the new pin dialog boxes does not read correct.

Grammar corrected.


Can you provide a compilation of alpine

I hope to run lua lsp in the docker alpine environment. But there is no official binary executable file of alpine

I can find pre-compiled binary files here, but I don't guarantee that it can be run in docker.
https://github.com/sumneko/vscode-lua/tree/master/bin

The binary program here cannot be run directly under alpine. Need to recompile. I found the available images from the docker hub and extracted the binary files.
https://registry.hub.docker.com/r/lspcontainers/lua-language-server

@sbfkcel  old issue, i have the same problem, could you guide me through your solution please ? Thanks!

@weppami I found a fix that does not require recompiling. It's questionable (see disclaimer), but it works for running the VS Code extension in an alpine linux development container. You could probably adapt it for use elsewhere, too.
Here's my devcontainer.json:
{
    "name": "Alpine",
    "image": "mcr.microsoft.com/devcontainers/base:alpine-3.17",
    "postCreateCommand": "apk add --update --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ lua-language-server && rm -vf /root/.vscode-server/extensions/sumneko.lua-2.5.3/server/bin/Linux/lua-language-server && ln -s /usr/bin/lua-language-server /root/.vscode-server/extensions/sumneko.lua-2.5.3/server/bin/Linux/lua-language-server",
    "remoteUser": "root",
    "customizations": {
        "vscode": {
            "extensions": [
                "sumneko.lua"
            ]
        }
    }
}

NOTE: As time goes on, you will need to change the paths depending on the version of the VS Code extension you are using. In my case, it was 2.5.3.
The apk package install command came from the docker image that @sbfkcel linked. I found it while exploring the image layers, roughly here.
The commands after that essentially nuke the lua-language-server Linux binary that comes with the extension, and replace it with a symlink to the alpine-compatible one we just installed.

DISCLAIMER: My fix is jank. I am not responsible for the total annihilation of your development environment. There is probably a way better and easier way of doing this, but I've already spent way more time than I wanted to trying to get this working in a VS Code development container.
This issue was also a google search result, so by leaving this here, I can hopefully help others that encounter the same issues that I did.


Try to externalize css override inclusion

The goal is to keep only code and functionality on the repo, using external css to override default theme


Duplicate results.

It's possible in some situations to get the plugin to reinject the results on a page which is already displaying the web vital metrics, resulting in duplicate results.

Fixed in 1.1.1


More CI Fixes

Fix NanoVDB CI: NanoVDB lite and on Windows: upgrade to CUDA 12.4 for Visual Studio 2022, allow use of unsecure node version, use node 16 in ax, build, docs, houdini, and weekly workflow.

Thank you for approving this, @danrbailey!


[WIP] buildInfo to manipulate and update output of --out when .d.ts of reference doesnt change

Closing in favor of #29813


[FEATURE] Allow for training on a multiple GPU system using DDP

Currently it is not possible to train models on a multiple GPU system where learning rate could be handled very quickly.

Lightning supports DDP; should be possible to flip it on.
Personally, I'm skeptical that it will improve performance--these are tiny models, and operation out of the GPU-saturated regime seems to give the best results in terms of wall time.
If you find otherwise, I'd be interested if you shared your findings. But, without that, my suspicion is that this isn't a good idea for this particular use case, so I'm going to close this for now.


DnsServerDsc: Consider renaming the module

Suggest we consider renaming the module from xDnsServer to DnsServerDsc since 'x' no longer have any meaning. This is inline with the other modules that have been renamed. This should also remove the 'x' from all the resource names.

At the same time we should change the resource prefixes from MSFT to DSC to indicate that it is the DSC Community that maintains the resources.

I think it'd be great to do that when the current PRs are merged and released to PSGallery.
We could release 2.0.0 (after all pre-releases are out), and then upgrade the repo (rename, and make the code change, and the Pipeline change).
Then we could release DnsServerDsc as v2.1.0 and unlist the old xDnsServer from the gallery (invisible but still accessible if you install specific/pinned version.
I'd be happy to give a hand, @Sudman1, @indented-automation, @johlju we'd just need to sync our efforts.

I was going to ask about that. It would be a really nice to tie it in with
all the changes @Sudman1 is making.
On Wed, 17 Feb 2021 at 09:55, Gael<EMAIL_ADDRESS>wrote:

I think it'd be great to do that when the current PRs are merged and
released to PSGallery.
We could release 2.0.0 (after all pre-releases are out), and then upgrade
the repo (rename, and make the code change, and the Pipeline change).
Then we could release DnsServerDsc as v2.1.0 and unlist the old xDnsServer
from the gallery (invisible but still accessible if you install
specific/pinned version.
I'd be happy to give a hand, @Sudman1 https://github.com/Sudman1,
@indented-automation https://github.com/indented-automation, @johlju
https://github.com/johlju we'd just need to sync our efforts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dsccommunity/xDnsServer/issues/179#issuecomment-780439758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADB3UDQB53XMFNIRMX5BNJDS7OHCNANCNFSM4XUUXUOA
.

DnsServerDsc will be release as 3.0.0 as it will be breaking change with new module name and also there will be breaking changes that we don't add to the 2.0.0 release.


Wrong balance after sending funds from a bech32 address

Ledger Live Version and Operating System
Ledger Live Mobile 1.3.0 (3145749)
Android 8.1.0 OPM1.171019.019 Kernel 3.18.71-perf-gbb71efc (Xiaomi Redmi 5 plus)
To double check I used the destop app: Ledger Live 1.12.0
Expected behavior
After sending 0.00208276 BTC  from a bech32 address containing 0.1 btc it is expected that the new balance on Ledger Live Mobile displays  proper amount (minus the fee); in my case it should have displayed 0.09791236 BTC.
Actual behavior
I got the new balance to 0 BTC.
It seems that the mobile app doesn't consider the change address as mine. Fortunately on the desktop application the balance is properly displayed.
Steps to reproduce the behavior

open ledger live on mobile
open a bech32 account with 0.1 btc
connect the Ledger Nano S with an OTG usb cable.
send 0.00208276 btc to a destination address
confirm the destination address on the ledger nano s.
check the account balance (now it displays 0 btc)

You can verify the transaction on explorer. Hash of the transaction:
< removed >
I can send you the screenshot (mobile and desktop), if that helps.
I also waited several confirmations, still zero btc on my mobile app.
I tried to re-import the bech32 account from desktop app to the mobile app, still it displays 0 btc on the mobile app.
It seems to me, that the mobile app doesn't consider the change address as its own.
Question: when I send funds to a destination address, the ledger nano s asks for confirmation of the destination address to avoid malwares... but no confirmation is asked for the change address: a malware could forge the change address or does the ledger nano s verify that the change address is valid and not forged by some malware?
This time, it looks like the funds have not be lost. What happens if funds get lost for a bug? Does ledger refund the user or there is no liability in case of lost funds due to a bug? (just to know, I got a bit scared)
Thanks, and best regards.
Luigi.

I can send you the screenshot, if that helps.

Can confirm the same issue with native segwit addresses on the Ledger Nano X.

Is this still an issue?

I stopped using the bech32 accounts, I'll leave other user's risk loosing their btc if this problem hasn't been addressed...

here is what's exactly happening from what we know:
our explorers API does not "see" the transactions to bech32 addresses if they are too old, exactly before the time we supported bech32 on Ledger API side, therefore you don't see your entire balance, it's just a UI problem, your keys are still in your control, no risk to lose BTC it's just that Ledger Live don't "see" it all yet, until the API gets fixed.
I believe @luchenyuxx is on it.

Sounds good. Thanks for the update.

I checked on desktop and compared to mobile. Same balance. Account had first transaction three weeks ago.
Slightly of topic, any way to see, list, export utxos?

This evening I'll try to re-import the bech32 account on mobile and check if the transaction shows up, then I can confirm the problem is solved.

@dslutej I don't know about the utxo, but you can export the xpub from the desktop app, right-clicking on the account and choosing 'export xpub' or something like that (I cannot check at the moment). Once you have the xpub you can check the derived addresses using key utility 'ku' ( from http://github.com/richardkiss/pycoin ) at the command line:
$ ku -j -s1/0-50 extendedxpub

From the addresses you can scan an explorer to check associated utxo.
I don't know if you can export them from the wallet.

Thanks! Ku worked nice for deriving public addresses.

Hi everyone.
Today I made some tests moving BTC from a p2sh address (segwit 3) to a bc1 address, then from a bc1 address to another bc1 address in another account using the mobile app on android, an OTC cable (original Ledger cable with a cheap OTG adapter). All seems ok. Checking the transaction history on the account that previously was giving problems I can see that the bitcoin asset chart is consistent with the desktop ledger app.
So, for my understanding, the problem looks solved.

@dslutej latest version of ledger live desktop allows to export a csv of all transactions. check it out!

@lviggiano, ooh. insert Nice Meme


by.css not watching css that starts with "." and "#"

![screen shot 2015-10-16 at 8 10 26 am](https://cloud.githubusercontent.com/assets/5438128/10530781/7ae54a4a-73dd-11e5-8486-a6baf00258e4.png)
also I think in regex we need to add by.id and by.className. What do you think guys @ramonvictor @stramel ?

Definitely, should be able to handle any of the protractor selector apis. Although, the Regex seems a bit off for by.css.  I can try to come up with a solid regex for it but it will take a couple days since I'm away from my computer

I'll take a look at it this weekend.

Thanks for checking this out guys! You helped me and my team a lot!

Hi @cor03rock, quick heads up, I couldn't fix this issue yet, however I've had a good progress in the big refactoring I'm working on, see design-refactoring branch - still WIP. This new version will address a lot of small issues, including these regex problems. I'm expecting to finish it within this week. I'll let you on whenever the next release is published.

Hey @ramonvictor, it's ok I can wait. thanks for the really big effort for helping me. I really appreciate it! :+1: :+1: :+1: :+1:

Should probably support all the Webdriver APIs since Protractor is built off of it. http://selenium.googlecode.com/git/docs/api/javascript/namespace_webdriver_By.html

Added #15 which will allow these to work.

@cor03rock This should be closed with the updated refactor that @ramonvictor merged to master.

Thanks guys! Now waiting for the next release! :+1:


make sure sort order of usernames does not affect evaluation if we need to post another comment

@googlebot I signed it!

@jridgewell added tests. thanks!


fix: 修复docker image地址存在端口时，组装的地址不正确的Bug

Which changes (Bug/Feature):

Fixes #
Special notes for reviewers:
none

Codecov Report

Merging #175 (a395b61) into master (362ff35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   41.71%   41.71%
=======================================
  Files           4        4
  Lines         163      163
=======================================
  Hits           68       68
  Misses         93       93
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


chore(ci): enforce msrv in parts of our CI.

closes #4874

#4879  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite

Clever!


Make enum for IO formats

This looks mostly good, although I'm really not sure about having format as just some string literal... it makes it really unclear as to which values it can take (e.g 'Xml, xml, XML, .xml, .offxml, ..., json, Json, JSON... etc) and doesn't lend itself well to static linting. My personal preference would be to have an Enum which contains all of the available formats, and to pass this instead.
e.g: ff_string = ff.to_string(ForceField.Format.OFFXML, True) or ff_string = ff.to_string(ForceField.Format.JSON, True) if we extend support to other formats in the future.
Originally posted by @SimonBoothroyd in https://github.com/openforcefield/openforcefield/pull/291

One note, pointed out by @andrrizzi, is that extending an enum after it's been defined might be difficult. That is, if we try to register addition ParameterIOHandlers after initialization, the enum may not like it.

Would a simple class with class-level attributes be enough?

@jaimergp : That's a great suggestion.
In fact, if we want to request a particular parameter handler, why not just specify the ParameterIOHandler class?
ff_string = ff.to_string(format=ForceField.XMLParameterIOHandler)

You could make ForceField.Formats.XML equal to ForceField.XMLParameterIOHandler.
Also, let's be sure to avoid specifying keyword arguments by position, as in
ff_string = ff.to_string(ForceField.Format.OFFXML, True)

it leads to confusing code for new readers.

Would a simple class with class-level attributes be enough?

Possibly!

in fact, if we want to request a particular parameter handler, why not just specify the ParameterIOHandler class?

I think that's exactly our design right now. You can pass either the key to a registered parameter IO handler or your own handler as well.


Does it need  element in AndroidManifest for API30?

For url_launcher, a  element must be present in AndroidManifest for API30. Does this package require a  element like url_launcher for API30?

No, you do not need to add the queries element explicitly to your project's AndroidManifest.
It is automatically provided by the CustomTabsLauncher library that this package depends on.


Support v-class attr of svg in IE

in IE11, el.classList is not defined when el is SVGElement (such as , , etc...)
So <svg v-class="">, <svg v-transition> causes error in IE11.
example: http://jsfiddle.net/tyage/dpt6L1o1/
I fixed this problem.

424

Thanks @tyage ! Note 0.10.6 will no longer be updated, but I will incorporate your change into 0.11 branch.

424


javascript parse errors get eaten

First off, thank you for putting this together. My game uses racer to run all of its game code, and the memory leaks made it impossible to ship / scale. It's got a chance now.
therubyracer has callstacks for where in the execution errors happened, but with mini_racer I don't get them:
var f = function(a, ) {};
"Unknown JavaScript Error during parse"

Is this because rubyracer does extra work on the other side of v8, or are these turned off on purpose by mini_racer-
any help is very much appreciated!

I should be able to fix that
On Wednesday, 25 May 2016, seanmakesgames<EMAIL_ADDRESS>wrote:

First off, thank you for putting this together. My game uses racer to run
all of its game code, and the memory leaks made it impossible to ship /
scale. It's got a chance now.
therubyracer has callstacks for where in the execution errors happened,
but with mini_racer I don't get them:
var f = function(a, ) {};
"Unknown JavaScript Error during parse"
Is this because rubyracer does extra work on the other side of v8, or are
these turned off on purpose by mini_racer-
any help is very much appreciated!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/discourse/mini_racer/issues/10

! was not expecting that! :D
Thank you :)
Also, I noticed Ruby exceptions that happen inside of marshalled Procs throw the same exception. <- that's much more managable, and preferred, as I don't want players seeing ruby exceptions they've caused through their code ;P

Can you try latest out? can be improved a bit but we now provide locations

Pulling across and taking a look :D Thanks!

I  want us to add support for
context.eval("a=1", name: 'bob.js')

cause that will allow us to untangle backtraces in a much cleaner way!
On Thu, May 26, 2016 at 11:33 AM, seanmakesgames<EMAIL_ADDRESS>wrote:

Pulling across and taking a look :D Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/discourse/mini_racer/issues/10#issuecomment-221755036

yeah-- would be cool. I've still yet to take advantage of the file feature for the game-- perf improvements not as important as stability atm! :D
Having the error message in there is good at least! Thanks for getting that in. :D


[v4.1.0] Blended the notification system with helper functions

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#12  👈
#11
#10
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GoodM4ven and the rest of your teammates on  Graphite


[Snyk] Security upgrade alpine from 3.17 to 3

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to alpine:3, as this image has only 2 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

371
Improper Authentication SNYK-ALPINE317-OPENSSL-5776809
No Known Exploit

371
Improper Authentication SNYK-ALPINE317-OPENSSL-5776809
No Known Exploit

221
CVE-2023-3446 SNYK-ALPINE317-OPENSSL-5788365
No Known Exploit

221
CVE-2023-3446 SNYK-ALPINE317-OPENSSL-5788365
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Outdated


cann't try it out after 5002 authorized

https://localhost:5002/ has already authorized by Authorization URL: https://localhost:5000/connect/authorize. When I try it out API
the log info :  AuthenticationScheme: Bearer was not authenticated.  Authorization failed.

the Http:/localhost:5002/swagger/index.html authorized by httsp://localhost:5000/,but when I refresh the web  Http:/localhost:5002/swagger/index.html ,the web need authorize. Why?

How to fix the  bug?Environment is development. Thanks.

solute!
all SSL URL need safe.unSafe  URL doesn't pass.


[BUG] Option to indicate to delta that files read can be modified by other transactions

Bug
Describe the problem
I had 2 concurrent jobs on same table: one is batch that runs on a certain schedule and reads the table and updates it. the other is structured streaming and appends data to the table. the table uses WriteSerializable isolation level. these 2 operations should not conflict. but in reality they both threw ConcurrentAppendException errors.
turns out my streaming job was doing a join (streaming-batch join) with the same table as it was writing to. the join simply added some data to the streaming dataframe and it was perfectly fine if that data was somewhat stale. but this is not how delta saw it: it considered this join as files read that should not have been changed or added to by any other transaction while this transaction was in progress (or else there would be a conflict). this was also the reason my streaming job was no longer considered a blind append.
the behavior described is perfect default behavior (and its impressive that delta captures this join as a read dependency for the transaction), but i want an option to turn this off, and basically tell delta it is OK if the table is modified between reading from it and writing to it for my transaction.
Steps to reproduce
the current behavior is captured in a unit test already:
https://github.com/delta-io/delta/blob/master/core/src/test/scala/org/apache/spark/sql/delta/DeltaSinkSuite.scala#L489
Observed results
My transaction was no longer blind append and had read dependencies that could lead to conflicts.
Expected results
Since i did not care about the table being modified between reading from it and writing to it i want an option to indicate so, and the result should be that:

my transaction is OK with the files read being modified or added to
my transaction is considered blind append again

Further details
Environment information

Delta Lake version: master branch

Willingness to contribute
I have pullrequest ready

mhhh is this a feature request and not a bug? i might have used wrong template...

i recreated this one correctly as a new issue... deleting this one


docs: ignore generated md files in specs dir

The repo is being polluted by this when generating docs.

this is being fixed in #36 instead.


Migrate autoincrementing integer primary keys to UUID

Autoincrementing integer primary keys are somewhat fragile due to this behavior:
https://dba.stackexchange.com/a/243455
They also have relatively low max values:
moonstreamdb=> \d ethereum_smart_contracts_id_seq
          Sequence "public.ethereum_smart_contracts_id_seq"
  Type   | Start | Minimum |  Maximum   | Increment | Cycles? | Cache
---------+-------+---------+------------+-----------+---------+-------
 integer |     1 |       1 |<PHONE_NUMBER> |         1 | no      |     1
Owned by: public.ethereum_addresses.id

Let us migrate all autoincrementing integer primary keys to UUIDs.

This applies not just to ethereum_addresses, but to all tables with integer primary keys.


Use logistic regression scorer to partition your patch of sky into physical objects

Each object will have some number of TGSS and NVSS components.

Look at some of these. Are you missing components? Are you adding extras? etc

Comparison below at 5 degree fov around J101436.8-270532.
I reckon that, as expected, we're adding lots more components, especially in the central large multi-object. I will find an example where we might be missing something (like some aged triple with the two "jet-like" blobs further apart and elongated).
torch_lr_partition.pdf

Oh that's a super good plot. Great work!
(You're more likely to pick up too many components than too few. I suggest finding an example of a partitioning that is OK, and one that is not.)

Thanks! Will search for two blobs close together with nothing else nearby as an OK example.
See #32

This looks like a candidate for two aligned ellipses:
J121923+054926
Sometimes a blob is large enough to count as multiple sources, this is a not very interesting form of multi-component:
TGSS J153418.0+101644, etc.
NVSS J153418+101544, J153414+101647, J153417+101708, J153417+101821
Also, looked up the most distant radio galaxy (looks very boring):
TGSS J153049.9+104933, NVSS J153050+104931

Here's one such case of single match partition which seems alright.
TGSS J104025.2-162920, NVSS J104025-162920
Why it hasn't jumped to the nearby blobs, I don't know, but I would agree with the label.

Move to close this and issue #32


Invisible command parameters

I want to create a command with an invisible sender parameter.
@Command({"is home", "is tp"})
public void home(@Sender Player player, @Sender Island playerIsland) {
  player.teleport(playerIsland.getSpawnLocation());
  player.sendMessage("Teleported to the island home!");
}

Then i would create a binding for playerIsland which checks if player has an island etc
And I want to make playerIsland parameter not visible in commands usage
Is it possible with current blade API?

Currently, the usage generator is a mess. I am planning on rewriting it however I do not have much time right now. With the current API, you can't hide parameters, you can only append a custom message to the end. If you want to, you can make a pull request and I will merge it, if not I will get to this sooner or later.

The new release 2.1.5 adds Command#usage, which can be used to set your own usage message, you can use this to hide the parameter.


[Feature] Detect Media Type for binary documents

From @hkkenneth on October 10, 2016 8:29
Copied from original issue: KHP-Informatics/cogstack#5

From @hkkenneth on November 14, 2016 13:54
Implemented in fa3a4b7


Saving sessions

With iTerm I can save sessions of the current tab layout and locations. When I start iTerm I simply choose which session I want to restore and those sessions can have any name they want, so it's very handy when working with various clients for example.
Does Hyper support this type of thing?

consider to ask this question in actual hyper repo https://github.com/zeit/hyper


Update custom_domains.py

Description
Please provide a clear and concise description of your pull request, including:

The changes made
The reason for the changes
Any relevant background information

Related Issues
Please link any related issues that your pull request addresses or closes.
Checklist

[ ] I have read and followed the contributing guidelines.
[ ] I have tested my changes.
[ ] I have updated the documentation, if necessary.

Additional Information
Any additional information you would like to provide.

Added freebies.faradas.org since streaming free course videos on faradas.org was not possible. By adding the video host domain to the direct rule list, the issue was resolved.


Added EQAI Summer School (and type: Quantum AI )

Thanks for the contribution @beatrice-portelli !!
I've merged your PR. The build failure had nothing to do with your commits, it was a cascading issue from a previous commit.


Add thread_pools.percent_used to metadata.csv

What does this PR do?
It turns out we already collect a metric from IBM WAS but it's not in metadata.csv. This PR adds it.
I noticed there are a couple more such metrics, I could add them in a follow-up PR if we decide that's a good idea.
Motivation
https://datadoghq.atlassian.net/browse/AI-2672
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

Yes, please add any missing metric to the metadata csv, there is an automated way to check this which is adding aggregator.assert_metrics_using_metadata(get_metadata_metrics()) to the integration and/or e2e tests

@hithwen
When I try to assert based on metadata as you suggest, I get the following test failure:
______________________________________________________________________ test_check ______________________________________________________________________
tests/test_integration.py:24: in test_check
    aggregator.assert_metrics_using_metadata(get_metadata_metrics())
../datadog_checks_base/datadog_checks/base/stubs/aggregator.py:477: in assert_metrics_using_metadata
    assert not errors, "Metadata assertion errors using metadata.csv:" + "\n\t- ".join([''] + sorted(errors))
E   AssertionError: Metadata assertion errors using metadata.csv:
E     	- Expect `ibm_was.jdbc.close_count` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jdbc.create_count` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jvm.process_cpu_usage` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jvm.up_time` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jvm.used_memory` to have type `gauge` but got `monotonic_count`.
E   assert not {'Expect `ibm_was.jdbc.close_count` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jdbc.create_count` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jvm.process_cpu_usage` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jvm.up_time` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jvm.used_memory` to have type `gauge` but got `monotonic_count`.'}

Note that these are not the missing metrics that I found. Those metrics are listed below:
'ibm_was.object_pool.objects_allocated_count',
'ibm_was.object_pool.objects_returned_count',
'ibm_was.object_pool.idle_objects_size',
'ibm_was.thread_pools.declared_thread_hung_count',
'ibm_was.object_pool.objects_created_count'
}

@hithwen
When I try to assert based on metadata as you suggest, I get the following test failure:
______________________________________________________________________ test_check ______________________________________________________________________
tests/test_integration.py:24: in test_check
    aggregator.assert_metrics_using_metadata(get_metadata_metrics())
../datadog_checks_base/datadog_checks/base/stubs/aggregator.py:477: in assert_metrics_using_metadata
    assert not errors, "Metadata assertion errors using metadata.csv:" + "\n\t- ".join([''] + sorted(errors))
E   AssertionError: Metadata assertion errors using metadata.csv:
E     	- Expect `ibm_was.jdbc.close_count` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jdbc.create_count` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jvm.process_cpu_usage` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jvm.up_time` to have type `gauge` but got `monotonic_count`.
E     	- Expect `ibm_was.jvm.used_memory` to have type `gauge` but got `monotonic_count`.
E   assert not {'Expect `ibm_was.jdbc.close_count` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jdbc.create_count` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jvm.process_cpu_usage` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jvm.up_time` to have type `gauge` but got `monotonic_count`.', 'Expect `ibm_was.jvm.used_memory` to have type `gauge` but got `monotonic_count`.'}

Note that these are not the missing metrics that I found. Those metrics are listed below:
{
'ibm_was.object_pool.objects_allocated_count',
'ibm_was.object_pool.objects_returned_count',
'ibm_was.object_pool.idle_objects_size',
'ibm_was.thread_pools.declared_thread_hung_count',
'ibm_was.object_pool.objects_created_count'
}

You should use aggregator.assert_metrics_using_metadata(get_metadata_metrics(), check_submission_type=True)

Checking type: By default we are asserting the in-app metric type (check_submission_type=False),
asserting this type make sense for e2e (metrics collected from agent).
For integrations tests, we can check the submission type with check_submission_type=True, or
use check_metric_type=False not to check types.


Cannot install rosdep2 and bloom

I am trying to run this locally on Ubuntu 22.04 as described in https://github.com/jspricke/ros-deb-builder-action#run-manually.
I am somehow in a state, where sudo apt install python3-rosdep2 will remove python3-bloom
The following packages will be REMOVED
  python3-bloom python3-rosdep python3-rosdep-modules
The following NEW packages will be installed
  python3-rosdep2

resulting in
ros-deb-builder-action/build: 106: bloom-generate: not found

when I run ./build -r humble -d jammy locally on Ubuntu 22.04.
Trying to install python3-bloom will remove python3-rosdep2.
Isn't it possible to run this with package python3-rosdep instead? I.e. sudo apt install python3-bloom python3-rosdep would work but sudo apt install python3-bloom python3-rosdep2 results in:
The following packages have unmet dependencies.
 python3-rosdep : Conflicts: python3-rosdep2 but 0.21.0-2 is to be installed
 python3-rosdep-modules : Conflicts: python3-rosdep2 but 0.21.0-2 is to be installed
E: Unable to correct problems, you have held broken packages.

I noticed that ./prepare -d jammy already shows an error:
The following packages have unmet dependencies.
 python3-catkin-pkg : Conflicts: catkin but 0.8.10-7 is to be installed
 python3-catkin-pkg-modules : Conflicts: catkin but 0.8.10-7 is to be installed
 python3-rosdep : Conflicts: python3-rosdep2 but 0.21.0-2 is to be installed
 python3-rosdep-modules : Conflicts: python3-rosdep2 but 0.21.0-2 is to be installed
E: Unable to correct problems, you have held broken packages.

I am also seeing:
+ sudo DEBIAN_FRONTEND=noninteractive apt install -y --no-install-recommends sbuild mmdebstrap distro-info debian-archive-keyring ccache uidmap vcstool python3-rosdep2 colcon python3-colcon-package-information python3-colcon-ros python3-bloom curl git-lfs
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
E: Unable to locate package colcon

There is no package colcon. One has to install the python3-colcon-* packages instead.

I guess you have the OSRF packages installed. This should work for you:
https://github.com/jspricke/ros-deb-builder-action/blob/main/prepare#L37

I guess you have the OSRF packages installed.

Yes, I already have ROS 2 humble installed.

This should work for you: https://github.com/jspricke/ros-deb-builder-action/blob/main/prepare#L37

I can run this command but it does not resolve the dependency issue. sudo apt install python3-bloom python3-rosdep2 still reports the same issue.
Given the dependencies and conflicts
$ apt-cache depends python3-bloom
python3-bloom
  Depends: <python3:any>
    python3
  Depends: python3-yaml
  Depends: python3-empy
  Depends: python3-rosdep
  Depends: python3-rosdistro
  Depends: python3-vcstools
  Depends: python3-setuptools
  Depends: python3-catkin-pkg
  Conflicts: <python-bloom>
$ apt-cache depends python3-rosdep
python3-rosdep
  Depends: <python3:any>
    python3
  Depends: python3-rosdep-modules
  Conflicts: <python-rosdep>
  Conflicts: <python-rosdep2>
  Conflicts: python3-rosdep2
$ apt-cache depends python3-rosdep2
python3-rosdep2
  Depends: python3-catkin-pkg
  Depends: python3-rosdistro
  Depends: python3-rospkg
  Depends: python3-yaml
  Depends: <python3:any>
    python3
  Depends: ca-certificates

I don't see how this can be resolved (python3-bloom requires python3-rosdep and python3-rosdep conflicts with python3-rosdep2).

The python3-bloom in the OSRF repo depends on python3-rosdep? not python3-rosdep2`.

it is not the od package, just a different name.

So does it work for you now so we can close this?

No. I still have these dependency conflicts.
The suggested command (https://github.com/jspricke/ros-deb-builder-action/blob/a773469b7aa118a1f183a3369d4e3fdbf348f588/prepare#L37) runs through, but because of the rosdep <-> rosdep2 conflict, I cannot install python3-bloom and python3-rosdep2 simultaneously.

Why would you want to install python3-rosdep2? It is not needed

Why would you want to install python3-rosdep2? It is not needed

Without it, I get the error:
ERROR: Not all sources were able to be updated.
[[[
ERROR: unable to process source [file:///usr/share/python3-rosdep2/debian.yaml]:
	<urlopen error [Errno 2] No such file or directory: '/usr/share/python3-rosdep2/debian.yaml'> (file:///usr/share/python3-rosdep2/debian.yaml)
]]]

As a workaround, you can force a downgrade via sudo apt install python3-bloom=0.10.7-2 python3-rosdep2. Then it seems to work. But this is not robust and will probably break again after an update.
It would be great if the scripts could work with either of the rosdep packages.

Does apt purge python3-rosdep2 help?

Does apt purge python3-rosdep2 help?

No. It does not help with the dependency resolution afterwards as, at least in my case, I always have to reinstall it afterwards to provide /usr/share/python3-rosdep2/debian.yaml.
The only thing that helped was forcing a downgrade of python3-bloom to the version provided by the Ubuntu repos.

That sounds odd. After apt purge python3-rosdep2 there should no longer be a /etc/ros/rosdep/sources.list.d/10-debian.list and thus nothing including file:///usr/share/python3-rosdep2/debian.yaml. What is the content of your /etc/ros/rosdep/sources.list.d/ after the purge?

That sounds odd. After apt purge python3-rosdep2 there should no longer be a /etc/ros/rosdep/sources.list.d/10-debian.list and thus nothing including file:///usr/share/python3-rosdep2/debian.yaml. What is the content of your /etc/ros/rosdep/sources.list.d/ after the purge?

Sure, after the purge these files are gone. But the script, somehow, requires /usr/share/python3-rosdep2/debian.yaml so I have to reinstall it anyway. Sorry, if this was not clear from my previous post.

Why do you think it depends on that file? Can you post a command invocation and the error?

It turns out I have to manually run rosdep update after removing rosdep2 and installing rosdep. I guess it would be more robust if the build script would run this in any case to avoid this issue on local setups.

rosdep update is run here: https://github.com/jspricke/ros-deb-builder-action/blob/main/build#L82

Sorry. Then I am not really sure what happened and why the index was out of date.


Porting the portals

For portal discussion with @Zidane

So I think we're almost there with this. I haven't yet added a phase state for portal teleport (not sure what type of phase this will be) and the associated rollback of any created portals for the modded side.
Other than that, what this has done is deduplicated the code in both Entity and ServerPlayer changeDimension methods, added the reposition even around getExitPortal for vanilla mechanics, and after portal placement for non-vanilla (which is what the phase state rollback would be needed for, unless we decide we're not running the event for mod controlled teleports).


TOC links broken when there are special characters in headings fix

When there are special characters in headings (. / $ + ( ) [ ] # @ & % =) the anchor in toc links are different from the headings ids, where they are deleted.
As a result, links to headings such as "1. Introduction" or "3.2. Male / Female connectors" don't work.
This fix removes these characters from the TOC link anchor.

@sambrista I'm not sure what you mean. The TOC does not generate ids for headings. It only generates ids for anchor links and does this with the same code as markdwn-it-anchor, see: https://github.com/valeriangalliat/markdown-it-anchor/blob/957d7129a6a84bfa3e22283b99ee94c2dbdc16de/index.js#L3
Your code strips special characters, but that doesn't help anything, because you also need to control how headings get their ids. The goal of markdown-it-table-of-contents is compatibility with markdown-it-anchors. Markdown-it-anchors generates ids that include special characters.
Maybe you're using a different plugin for generating heading ids?
Two solutions:

Provide a custom slugify function, if you heading ids differ from markdown-it-anchor.
Use markdown-it-attrs and provide each heading with your own custom id.