SuppressDetectArrayMove does not work as expected

Steps to reproduce:
JsonDiffPatcher.DefaultOptions =
	() => new JsonDiffOptions { SuppressDetectArrayMove = true };

var x = JsonDocument.Parse(@"{""a"":[{""b"":1},{""b"":2}]}");
var y = JsonDocument.Parse(@"{""a"":[{""b"":1},{""b"":2}]}");
var z = JsonDocument.Parse(@"{""a"":[{""b"":2},{""b"":1}]}");

var test1 = x.DeepEquals(y);  //test1 is true
var test2 = x.DeepEquals(z);  //test2 is false, expected true

x.Deserialize<JsonNode>().ShouldEqual(y.Deserialize<JsonNode>());  //no exception
x.Deserialize<JsonNode>().ShouldEqual(z.Deserialize<JsonNode>());  //throws JsonEqualException, expected no exception

Either SuppressDetectArrayMove does not work, or I misunderstood what it does? I this case how can I configure JsonDiffPatcher to ignore array element order?

I don' think the DeepEquals methods supports SuppressDetectArrayMove. Can you switch to use Diff?

Thanks @weichch. I tried this:
var d1 = x.RootElement.Deserialize<JsonNode>().Diff(y.Deserialize<JsonNode>());
var d2 = x.RootElement.Deserialize<JsonNode>().Diff(z.Deserialize<JsonNode>());

d1 is null as expected, but d2 is not.

Array diff is a bit complex.
The generated diff (in your case d1 and d2) reflects the operations required to make x become y, or x become z.
In your case you have two complex objects in the array: {"b": 1} and {"b": 2}. By default, the two objects are compared with DeepEquals (which compares whether they contain the same properties and whether each property has the same value etc), and the two objects aren't deeply equal to each other, so a diff is then generated to make {"b": 1} become {"b": 2}. In this process, you can't ignore ordering of the two elements because their ordering matters (in both DeepEquals and Diff).
You could try sort the array before calling Diff or DeepEquals.
If this isn't an option, you might need to override the array item diffing behavior by implementing your own ArrayItemMatch and force the two non-identical elements to be identical.
For example, below code would make two objects identical when they both contain a property b:
JsonDiffPatcher.DefaultOptions = () => new JsonDiffOptions
{
	ArrayItemMatcher = MatchArrayItem,
};

static bool MatchArrayItem(ref ArrayItemMatchContext context)
{
	if (context.Left.AsObject().ContainsKey("b") && context.Right.AsObject().ContainsKey("b"))
	{
		// Suppress diff of the two non-identical objects
		context.DeepEqual();
		return true;
	}

	if (context.Left.DeepEquals(context.Right))
	{
		context.DeepEqual();
		return true;
	}

	return false;
}

Thank you for the detailed explanation. It makes sense, but would be nice to have an option that "properly" ignores array order. Two arrays are equal if:

They have same length.
For each element in left, there's an equal element in right.
Elements in the left and right arrays can, in turn, can contain arrays too. Obviously when comparing those arrays we use rules 1 and 2 above.

Is such option possible but has not been implemented, or does it have some logical problem I'm not seeing?

would be nice to have an option that "properly" ignores array order.

From JSON definition's perspective, the order of elements in an array shouldn't be ignored.
In RFC 7159:

An array is an ordered sequence of zero or more values.

From a functional perspective, sure, it can be done but need more thinking.

Two arrays are equal if:
They have same length.
For each element in left, there's an equal element in right.

We will have to consider duplicates here. For example, the arrays below meet the rules 1 & 2, but the two aren't necessarily equal. It is likely we need to sort the arrays before comparing them or verify that they both contain the same elements.
left = [2, 2]
right = [2, 1]

Yes I can see the problem with my logic of comparing arrays based on your above example. Sorting is probably not an option if we do not want to require passing in a hash/comparer function. When we do "For each element in left, there's an equal element in right, we need to know whether a given right element has already been matched to some left element or not. An immediate solution that comes to mind is maintaining a List<int> with positions of right elements that have already been matched to some left element.

If the approach is checking whether left contains right and then right contains left, then tracking the comparison result is going to improve the performance by avoiding comparing same set of elements twice.
There are also other approaches such as hashing:
Dictionary<JsonNode, int> appearanceOfEachElement;

In this approach, left can be appended to the dictionary with the Value of each entry being the number of appearances of the Key. Then go scan right and decrement the value by 1 for the same element found and remove the Key when its Value becomes 0. If the two arrays are equal, the dictionary should be empty by the end. This should avoid (in best case scenario) comparing each element twice so there isn't necessarily the need to track the comparison results. This is probably the most optimal solution as it has a complexity of O(n) in both time and space, compared to tracking the results where it has a complexity of O(n2) in both time and space.
However, this approach requires a hash function to work as we can't rely on the default GetHashCode function on JsonNode. Two JsonNodes would always have different hash values because one JsonNode can also be added into one parent, so they are always different objects.
Another thing we'd also need to consider is if we do provide an option to disable checking for order of elements, then it is likely we need to implement this in Diff rather than DeepEquals (because it won't be semantically correct there):
if(options.IgnoreArrayOrder && left.Length == right.Length)
{
    // do the comparison and suppress diff generation if equal
}

We might have to keep the materialized JsonNode used in this routine and try to reuse them in the the following array diff. JsonNode isn't well designed to be used in a comparison scenario especially when its inner value is represented in JsonElement, and materializing JsonElement isn't very efficient. You will see what I mean in JsonString and JsonNumber and how they are cached in LCS.

Do you mind (me) changing the title of this issue to something like "Compare two arrays ignoring order" because I thought it is what we're discussing here and the topic is useful.

Do you mind (me) changing the title of this issue

Yes definitely. I thought SuppressDetectArrayMove was not working as expected but that's not the case.
Regarding the exact left and right comparison logic, I'll leave it up to you. Though I do not understand why we need a hash function - we already have a way to compare two JsonNodes and decide if they are equal or not. That's pretty much what I'm using this nuget package for :).


Cant broadcast transaction to premix and send funds

Hi I have just run into an issue during whirlpool testing. When I select UTXOs and click mix, then I get into send interface, where I can't change any labels and fees etc. (Guess that is right). However the broadcast transaction button does not work at all. It is blue as it should be, but no matter how many times I click, nothing happens.
I thought it might be passphrase bug? Since I by mistake typed wrong passphrase into wallet ,,log in" and it let me open wallet anyway. So I thought I mind have a wrong signature or something. However by importing the right one, bug still remains. Cant send funds away and can't mix as well

Does anything appear in the log file? Help menu > Show Log File.

Does anything appear in the log file? Help menu > Show Log File.

not sure, will check tomorrow. However exporting wallet and sending away through electrum worked well. So not sure what did not work

Is this an Electrum seeded wallet?

Is this an Electrum seeded wallet?

Damn I closed something, kinda new to GitHub so sorry for mistakes.
It is generated via sparrow, however uses passphrase, might be an issue?

Reopened. Unlikely to be a passphrase issue, that functionality is working on my side.
Some of the notes above seem strange to me - you should only be able to open the wallet with the password, not the passphrase (unless they are the same).
The sparrow.log is probably the best way to diagnose the problem generally.

I don't have logs now, fixed issue by reinstalling whole app. Sorry, guess I am not very helpful... However it was pretty weird.
It went like this:
1)
Open wallet -> Password -> Asked Passphrase for keystore -> Import correct one –> unlocked
I had access to my 100k+ sats, however 40k sats which I received when imported incorrect passphrase could not be seen.

Open wallet -> Password -> Asked Passphrase for keystore -> Import incorrect one –> unlocked
Additional 40k sats were visible, I could send away all funds including first one away...
Was very weird, however app let me input many incorrect passphrases and nothing happened. However importing wrong password didn't let me in. Not sure why app asked for passphrase

I had access to my 100k+ sats, however 40k sats which I received when imported incorrect passphrase could not be seen.

Actually, this makes sense to me now. By inputting the wrong passphrase you changed all the addresses in the wallet (all passphrases are technically valid) - but the wallet still stores and shows your old transactions from the original passphrase. If you had tried View > Refresh Wallet, they would have disappeared.
Sparrow asks for a passphrase if you enter one when you first create a BIP39 wallet. It's the textfield below the words textfields. Sparrow doesn't save this value - you need to re-enter it whenever you load the wallet, as you have experienced.
I'll close this off. Glad it's fixed!


Markdown summary has strange output for * stack

When summarizing a buildpack in markdown format, the result can be something like the following, when a * stack is included:

A couple of options:

Wrap entries in a ` so that they are rendered literally (looks better for stack IDs anyway), OR
Replace the entire list with - Any stack

Or even both, as the first option is a nice improvement anyway
Version: This behavior exists on the current version of jam as of this writing (v1.1.1).

Put up a PR. I nixed the second bullet to keep it simple, and to keep it consistent with the JSON formatter.


[Nomination] GianSalex - Cosmverse

Who are you nominating?
Giansalex @giansalex
What are you nominating them for?
Several months of work on Cosmverse the first NFT marketplace on Juno in collaboration with Highlander
Please provide links to their work.
https://cosmverse.com

https://github.com/CosmosContracts/hack-juno/issues/13
Who are you nominating?
@giansalex (Giancarlos Salas)
What are you nominating them for?
Being an OUTSTANDING contributor. Also for running, RPC nodes for lucina. 🙏
Please provide links to their work.
Updgrading the CosmWasm code explorer CosmJS verision, adding Keplr support, and showing transaction time in the execution info.

Upgrade cosmjs/stargate  CosmWasm/code-explorer#62
Gitpod Workspace https://github.com/giansalex/cosmwasm-workspace
Keplr CW20 tokens: Fix Add Token (cw20)
Fix Add Token (cw20) chainapsis/keplr-extension#134
cosmwasm dApps upgrade: Stargate v0.25 upgrade
Stargate v0.25 upgrade CosmWasm/dApps#81
dApps works on Juno
https://dapps.juno.giansalex.dev/names/
https://dapps.juno.giansalex.dev/cw20-wallet/
https://dapps.juno.giansalex.dev/staking/
https://github.com/disperze/wrapped-dapp
Add custom mint module juno#36
Split contract: https://github.com/disperze/cw-contracts/tree/master/contracts/split
Lockbox contract: https://github.com/disperze/cw-contracts/tree/master/contracts/lockbox
Wrap contract https://github.com/disperze/cw-contracts/tree/master/contracts/wrap
NFT-Marketplace - Cosmverse - https://github.com/CosmosContracts/Cosmverse
Contracts - cw721, nft-market

closed #13

Append:
Dark theme
Upload wasm binary
Instantiate new contracts

Live: https://blueprints.juno.giansalex.dev/
Repo: https://github.com/giansalex/juno-codes

refer to https://github.com/CosmosContracts/hack-juno/issues/65


Don't abort CI checks on first error

What problem does this solve or what need does it fill?
When working on complex PRs like #12163, it's frustrating to fix all of the errors reported by CI, only to be met with another round of failures in a follow-up crate.
What solution would you like?
Pass the --keep-going flag to CI. See https://github.com/rust-lang/cargo/issues/10496 for the tracking issue. Apparently this is now stable as of Rust 1.74: https://doc.rust-lang.org/cargo/commands/cargo-build.html#option-cargo-build---keep-going
It looks like for cargo test, we also need to pass in --no-fail-fast: https://doc.rust-lang.org/cargo/commands/cargo-test.html#options
What alternative(s) have you considered?

The goal of CI is to fail fast in a case of errors, and to not do extra works when possible.
Changing that would need more changes than just passing --keep-going everywhere: reducing dependency between jobs, not cancelling everything on the first job failed

That makes a lot of sense: I didn't think about dependent workflows. As a reviewer, I would still prefer it if all errors were caught, but enabling this option locally will be tremendously useful as an author.


[OSD-10315] setup metrics for alertmanager webhook receiver

What type of PR is this?
feature/refactor
What this PR does / why we need it?
count the total service log sent based on the template
update the gauge values once we got the request to ocm agent or response from service logs failed
reset the gauge values once we got the succeeded request to ocm agent or response from service logs
Which Jira/Github issue(s) this PR fixes?
Fixes #OSD-10315
Special notes for your reviewer:
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Ran make generate command locally to validate code changes
[ ] Included documentation changes with PR

Left a couple of minor questions/comments, but I tested this on a cluster and it worked well.

There are few lint errors as seen in make lint
pkg/cli/serve/serve.go:198:6: `fakeCallServiceLog` is unused (deadcode)
func fakeCallServiceLog(w http.ResponseWriter, r *http.Request) {
     ^
pkg/cli/serve/serve.go:204:6: `fakeReqFailure` is unused (deadcode)
func fakeReqFailure(w http.ResponseWriter, r *http.Request) {
     ^
pkg/metrics/metrics.go:59:22: Error return value of `prometheus.Register` is not checked (errcheck)
		prometheus.Register(m)
		                   ^
pkg/handlers/webhookreceiver.go:314:20: Error return value of `status.SetStatus` is not checked (errcheck)
			status.SetStatus(oav1alpha1.ConditionAlertFiring, "Alert starts firing", corev1.ConditionTrue, timeNow)
			                ^
pkg/handlers/webhookreceiver.go:315:20: Error return value of `status.SetStatus` is not checked (errcheck)
			status.SetStatus(oav1alpha1.ConditionAlertResolved, "Alert has not resolved", corev1.ConditionFalse, timeNow)
			                ^
pkg/handlers/webhookreceiver.go:316:20: Error return value of `status.SetStatus` is not checked (errcheck)
			status.SetStatus(oav1alpha1.ConditionServiceLogSent, "Service log sent for firing alert", corev1.ConditionTrue, timeNow)
			                ^
pkg/k8s/client.go:25:15: Error return value is not checked (errcheck)
	addKnownTypes(scheme)
	             ^
pkg/cli/serve/serve.go:103:18: Error return value of `viper.BindPFlags` is not checked (errcheck)
	viper.BindPFlags(cmd.Flags())
	                ^
pkg/cli/serve/serve.go:142:24: Error return value of `http.ListenAndServe` is not checked (errcheck)
	go http.ListenAndServe(":"+strconv.Itoa(metricsPort), rMetrics)
	                      ^
make: *** [Makefile:123: lint] Error 1

Not all errors are related to the metrics (namely viper.BindPFlags)

thanks @T0MASD, that's interesting, I am wondering why the IDE cannot detect the problems, like the error return was not checked

/hold

/unhold

Putting a hold back on until CI is healthy..
/hold

Tested it, working well. From my perspective this is good.
Feel free to unhold when you've got enough reviews and CI is healthy again.
/lgtm

Since ocm_agent_requests_by_service metric is to collect all the requests received by the  ~~web service  ~~ ocm agent api endpoints, expecting path as a param. And to avoid the confusion with MetricResponseFailure which expects  service as a param, would this metric be better renamed as ocm_agent_requests_total which will make it in line with ocm_agent_failed_requests_total?

/unhold


Using letsencrypt keys ?

Hi,
Any idea on how to make this work with LE keys ?
If i manually change the nginx config for mysite.com to :
server_name monit.mysite.com;
   ssl_certificate         /etc/nginx/ssl/letsencrypt/mysite.com-bundled.cert;
   ssl_certificate_key     /etc/nginx/ssl/letsencrypt/mysite.com.key;

I can use the same keys that trellis created for mysite.com. But there no way I can do the same by using trellis-monit onfigs only.

You will need to generate a certificate for monit.mysite.com. I'm not doing WordPress development anymore but I believe Trellis only generates a certificate for the specific domain mysite.com and not a wildcard one for *.mysite.com.
You can try to force Letsencrypt to generate a certificate for your domain by adding the monit.mysite.com domain as a redirects domain. Then you can create a custom NGINX config to avoid the WordPress Nginx config to catch the request.
I didn't try it but it should work. You can also contribute to this package if you want, maybe we can offer Letsencrypt as a build-in functionality in this project 🤷♂ I just don't have a lot of time currently to work on that.
Let me know if you try the solution above.
Cheers ✌


Feature/collection validation

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrade to vscode-languageclient 8.y.z

This will help us to use the latest LSP specification with VS Code.

Fixed by #145


Questions about continue training  from the last checkpoint

First of all, thank you for sharing your brilliant work.
When setting "overwrite_checkpoints: False" in the config, it means if you stop at any checkpoint and later you want to train with more iterations it will start from the last checkpoint you saved.
Here are my questions,

How do you perform deciding the order of input data?
When continue training from last checkpoint, will the input data order be initialized?

Samples are shuffled randomly at the start of each epoch for training. Samples are inferenced in their original order for validation and testing. This is handled by create_feed_dict in rpn_model.py
When continuing training from a previous checkpoint, the training data is shuffled in the same way as 1.


onTouchMove not firing

Hello,
I'm trying to use this in a project but it's not working. I started to troubleshoot within the files and doing some logging and I see that onTouchStart and onTouchEnd are firing but onTouchMove is not and thus nothing is happening in my UI.  I'm using the latest version on npm.  Any ideas what could be going on here?

Quick follow up, this is my test code:

    <Swipeable onSwiping={() => {console.log('swiping!');}}>

Hello 1!

Hello 2!

Hello 3!

Hello 4!

Hello 5!

    </Swipeable>

Wow, disregard. There was code in my app to prevent touchMove for some other reason. All set now.


Feature request / face completion

Is your feature request related to a problem? Please describe.
I will try to build a model for face completion using GANs algorithm.
Describe the solution you'd like
this is a novel approach for image completion that results in images that are both locally and globally consistent.
so it will be good to complete a face image.
Describe alternatives you've considered
trying another CNN models.
Additional context

please add your implementation in awesome-face-operations

are you still working on this issue?

yes, but I was having a problem in training, so sorry for being late. just needed two days


warning _FORTIFY_SOURCE requires compiling with optimization (-O)

                                    D | gcc -DHAVE_CONFIG_H -I../ncurses -I. -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DNDEBUG -I. -I../include -I/opt/chef/embedded/include -I/opt/chef/embedded/include  --param max-inline-insns-single=1200 -fPIC -c ../ncurses/./base/lib_scrollok.c -o ../obj_s/lib_scrollok.o
                                    D | In file included from /usr/include/stdlib.h:24:0,
                                    D |                  from ../ncurses/curses.priv.h:65,
                                    D |                  from ../ncurses/./tinfo/init_keytry.c:29:
                                    D | /usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
                                    D |  #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
                                    D |     ^
                                    D | In file included from /usr/include/stdlib.h:24:0,
                                    D |                  from ../ncurses/curses.priv.h:65,
                                    D |                  from ../ncurses/./base/lib_redrawln.c:40:
                                    D | /usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
                                    D |  #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
                                    D |     ^
                                    D | In file included from /usr/include/stdlib.h:24:0,
                                    D |                  from ../ncurses/curses.priv.h:65,
                                    D |                  from ../ncurses/./base/lib_scroll.c:44:
                                    D | /usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
                                    D |  #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
                                    D |     ^
                                    D | gcc -DHAVE_CONFIG_H -I../ncurses -I. -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -DNDEBUG -I. -I../include -I/opt/chef/embedded/include -I/opt/chef/embedded/include  --param In file included from /usr/include/stdlib.h:24:0,
                 from ../ncurses/curses.priv.h:65,
                 from ../ncurses/lib_gen.c:19:
/usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^
make: *** [all] Error 2

Looks to be running into https://lists.gnu.org/archive/html/autoconf/2013-05/msg00003.html
This is on Arch Linux. Need some help on what the right fix is here please (this is with tag, 12.4.1).

@lamont-granquist Arch Linux users still get no Chef?

latest omnibus on master should have -O2 turned on
this repo is deprecated, if its still an issue then likely someone needs to cut a PR against chef/omnibus to fix arch to add -O2


Access to  IOwinContext in RPC

Background: we are using OpenId Connect OWIN middleware, specifically Microsoft.Owin.Security.OpenIdConnect
The middleware takes care of all authentication concerns , including cookie lifetime (such as sliding expiration, etc.). Additionally, the middleware sets the IOwinContext.Authentication.User - allowing the retrieval of claim-based information about the current user identity. The information represented by these claims can be extensive and, quite often, application-specific.
Currently, the WebSharper.Owin middleware is tied to Forms authentication and the OWIN context is not made available to the RPC functions. More so, it alters the value of IOwinContext.Authentication.User based on assumptions about the authentication mechanism being used (Forms authentication).
Would you be open to changing the RemotingMiddleware implementation (or adding an alternate implementation) so that it allows the (unaltered) OWIN Context /environment to be retrieved within the RPC functions?
I would be happy to attempt a PR.
Let me know what constraints I should work within - note that I am only interested in the RPC functionality and have not used Sitelets at all (the whole UI is based on UI.Next). I don't want to break anything, but I really need the information in that OWIN context.

What we have been considering for such purposes is adding a member of type IDictionary<string, obj> to Web.IContext to allow the various host implementations to pass host-specific data. The ASP.NET module would use it to pass the HttpContext, and the OWIN middleware would pass the IOwinContext.

Thanks @Tarmil !
That would work just fine :-) I am currently under a wee bit of good old time pressure, but I can add the required functionality next weekend.
Also, I guess the RemotingMiddleware  should not be performing authentication-related tasks (or modify the OWIN context's user). This being said, I have not looked in detail at how authentication/authorization is handled in WebSharper, so I'm not comfortable making those changes.

Yes, if we provide access to the host-specific machinery then IContext.UserSession should not do anything until one of its methods is called. For the OwinCookieUserSession this means moving the do try refresh ... block out of the constructor and make it be called at most once by GetLoggedInUser(). Authentication is strictly confined to IContext.UserSession, so there should be nothing else to worry about.

Sounds good  :+1: - I'll give it a look during the weekend


[Codegen] Map coin test folder name to coin-id

Description
Map coin test folder name to coin-id so cointest will not generate unnecessary files. Fixes #2491.
How to test
CI build succeeds + run ./codegen/bin/cointest
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[X] Create pull request as draft initially, unless its complete.
[X] Add tests to cover changes as needed.
[X] Update documentation as needed.
[X] If there is a related Issue, mention it in the description.

Let's not change existing test folder names.
For newly generated tests, make sure source and test files use consistent name; see:

https://github.com/trustwallet/wallet-core/blob/master/codegen/bin/newcoin#L123

I changed just a few existing names in this revision, also split Terra/TerraV2 and Evmos/NativeEvmos. For others, added exclusion list in the script.


Styling on Inputs Poorly Affects Checkboxes

From @andrewvaughan on October 2, 2016 19:40
Issue Summary
The style parameters are too broad for "input" types, negatively affecting check boxes (makes them unreadable).  Specifically this block, once compiled, in screen.css:
textarea, select, input {
    width: 260px;
    padding: 6px 9px;
    margin: 0 0 5px 0;
    outline: 0;
    font-family: 'Open Sans', sans-serif;
    font-size: 1.6rem;
    font-weight: 100;
    line-height: 1.4em;
    background: #fff;
    border: #e7eef2 1px solid;
    border-radius: 4px;
    box-shadow: none;
    -webkit-appearance: none;
}

Being more specific (e.g., input[type=text], input[type=password]) on the CSS should prevent overlap of other types of inputs.
Steps to Reproduce
Put this in any post:
<input type="checkbox" />

Technical details:

Ghost Version: 0.11.1
Node Version: 0.12.3
Browser/OS: Chrome/PC

Copied from original issue: TryGhost/Ghost#7471

From @acburdine on October 2, 2016 23:47
@andrewvaughan is this issue with how the posts are rendered to readers of the blog? If so, then this likely belongs as an issue in the https://github.com/TryGhost/Casper repository 😄


[Settings] Plugin additional options: Allow settings description

Summary of the Pull Request
What is this about:
Currently we can't add descriptions for the additional plugin settings, We only can add the in brackets after the title. This doesn't looks good.
This PR adds the option to add descriptions for the settings.

Before
After

What is included in the PR:

[x] Update the settings ui code.
[x] Update the PluginAdditionalOptions code.
[x] Update the settings of WindowWalker plugin.
[x] Update the settings of TimeDate plugin. => Requires merge of #16662

How does someone test / validate:
Quality Checklist

[x] Linked issue: #15853
[x] Communication: I've discussed this with core contributors in the issue.
[x] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[x] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[x] Binaries: Any new files are added to WXS / YML

[x] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

I see the text itself can be improved too

@htcfreek Ah, I see what you mean.. this seems to be a (visual) bug in the CheckBoxWithDescriptionControl. Could you create a issue for that so we can fix that separately??

Yes. I can do this. But we have to wait with merging until the settings of TimeDate plugin are updated.
cx: @jaimecbernardo

@niels9001
If you are okay with the code changes, you can merge tomorrow without asking me. ;-)

I added only a description to note that the property is optional.

@jaimecbernardo
Do you think we can go with the margin bug? Then this can be merged after an approval of @niels9001 . 🚀

LGTM! Let's tackle the margin bug in a seperate PR!

See the issue you assigned on

Should we merge and update the new setting in system plugin later or do we wait. I can do the change this evening


First shot at f32.abs

I add an extra file to cover unary operators. What do you think about that?

Sorry for the conflict. The code is now in https://github.com/xtuc/js-webassembly-interpreter/blob/master/src/interpreter/kernel/exec/numeric-instructions.js.

Is replaced with #20


fix: qcloud fail to set object acl

这个 PR 实现什么功能/修复什么问题:
修正：qcloud设置对象ACL报nil pointer错误
是否需要 backport 到之前的 release 分支:

release/2.11
release/2.12

/area region

Codecov Report

Merging #2662 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #2662      +/-   ##
=========================================
- Coverage     7.1%    7.1%   -0.01%
=========================================
  Files         466     466
  Lines       73513   73513
=========================================
- Hits         5222    5220       -2
- Misses      67861   67862       +1
- Partials      430     431       +1

Flag
Coverage Δ

#aFlag
7.1% <ø> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d884992...2e95b29. Read the comment docs.

/approve
/lgtm


th:include is on its way out, so layout:include should be too

Given https://github.com/thymeleaf/thymeleaf/issues/405, and that I keep the fragment insertion names the same as what's in Thymeleaf, I should eventually retire layout:include in favour of layout:insert.

layout:insert already added, and layout:include already marked as deprecated.


provide artifact filenames as output for later usage

as i learned, github actions have no consistent globbing between platforms, so passing a artifact by glob is a error prone chore
if the artifact filenames where provided as output, that would ease things

Given Python's glob module is cross-platform, I'm guessing this could be solved with a python -Ic?


allow clientViaUserConsent to specify which account to use

I'm not sure I got everything right but in my browser application I use the following code on start:
flow.clientViaUserConsent(immediate: true)
and it seems to always load the first user that was logged in the browser "session". I created a simple webapp here:
https://github.com/alextekartik/dart-test/tree/master/googleapi_auths_test
that can be tested here:
http://gstest.tekartik.com/googleapis_auth_test
even if I switch to a different user (using flow.runHybridFlow(force: true)), the last authenticated user is not the one silently authenticated when the page reload which makes it impossible to always use the same account if the first one used was not the correct account the user wants to use.
I would to have a way to specify the "credentials" to try during flow.clientViaUserConsent(immediate: true), as I'm able to capture and save the last credentials used.
Otherwise is there a way to "save" the next automatically authenticated user in the same window
Or maybe I'm missing something and in that case I could ask in stack overflow but that is a question rather specific to this package.

It would be great if there was an optional parameter to force the account selection again, as mentioned in this comment. https://github.com/dart-lang/googleapis_auth/issues/4#issuecomment-55610469


[TypeError: Cannot call method 'filter' of null]

How fix this

@johnfelipe please read (and comply with) our contribution guidelines before opening an issue. Especially and empty and unclear issue like this one. Moreso, you'd probably find an answer by searching our google group.

@gvilarino please support me for install democracyos im stock..

we will, this just is not the channel for support, either ask/search in our google group or our gitter


l7 policy: introduce flag proxy-xff-num-trusted-hops

Currently, when L7 policies (egress or ingress) are enforced for traffic between Pods, Envoy might change x-forwarded-for related headers because the corresponding Envoy listeners don't trust the downstream headers because XffNumTrustedHops is set to 0.
e.g. x-forwarded-proto header:

Downstream x-forwarded-proto headers will only be trusted if xff_num_trusted_hops is non-zero. If xff_num_trusted_hops is zero, downstream x-forwarded-proto headers and :scheme headers will be set to http or https based on if the downstream connection is TLS or not.

https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/headers#x-forwarded-proto
This is especially problematic when L7 policies are used for egress traffic for Pods from a non-Cilium ingress controller (e.g. nginx). If the Ingress Controller is terminating TLS traffic and forwards the protocol via x-forwarded-proto=https, Cilium Envoy Proxy changes this header to x-forwarded-proto=http (if no tls termination itself is used in the policy configuration).
This breaks applications that depend on the forwarded protocol.
Therefore, this commit introduces a new config flag proxy-xff-num-trusted-hops that configures the property XffNumTrustedHops on the L7 policy Envoy listeners (egress & ingress). It defaults to 1.

/test

/test


fix a few typo's in README.md file

Looked through the README file and found a few typos.  Just cleaned a few things up.

Can you remove the additional files which got included?

Alright, I've just removed the additional files... Please let me know if there are any other changes needed.


Server should match FQDN with trailing dot

A query for /domain/example. should match the domain object "example" if following the robustness principle.
IANA receives approx. one hundred queries an hour to whois for domains ending in a trailing dot - that we currently match.

This will be fixed by commit 07c10cecf0483b68effeb21e0019937345fc41bd when it is merged.

Merged in #20


MyPy linting output not being shown in Problems tab

Environment data

VS Code version:

Version: 1.25.1
Commit: 1dfc5e557209371715f655691b1235b6b26a06be
Date: 2018-07-11T15:40:20.190Z
Electron: 1.7.12
Chrome: 58.0.3029.110
Node.js: 7.9.0
V8: 5.8.283.38
Architecture: x64

Extension version:

Python (ms-python.python) 2018.7.1
MagicPython 1.0.12

OS and version: Fedora 28 (Linux 4.16.14-300.fc28.x86_64 #1 SMP)
Python version: python3.7 (from fedora package python37)
Type of virtual environment used: N/A
Relevant/affected Python packages and their versions: mypy 0.620

Actual behavior
mypy and pylint are executed and show errors on the output/python tab, but just the pylint errors are shown on the problems tab.
Expected  behavior
problems tab shows both pylint and mypy errors
Steps to reproduce:

Install Python 3.7 (dnf install python37 on Fedora)
Install pip on python3.7
sudo python3.7 -m pip install --pre -U mypy pylint

Logs
Code for test
#!/usr/bin/env python3.7
from __future__ import annotations

a:int = "a"
not_declared_var

##########Linting Output - mypy##########
mypy /home/rea/code/rfs/provider.pyi
provider.pyi:10: error: Incompatible types in assignment (expression has type "str", variable has type "int")
provider.pyi:11: error: Name 'not_declared_var' is not defined
##########Linting Output - pylint##########
************* Module provider
11,0,error,E0602:Undefined variable 'not_declared_var'

------------------------------------------------------------------
Your code has been rated at 0.00/10 (previous run: 0.00/10, +0.00)

Show on problem tab:
E0602:Undefined variable 'not_declared_var'

Output from Console under the Developer Tools panel
workbench.main.js:sourcemap:4103 Overwriting grammar scope name to file mapping for scope source.python.
Old grammar file: file:///usr/share/code/resources/app/extensions/python/syntaxes/MagicPython.tmLanguage.json.
New grammar file: file:///home/rea/.vscode/extensions/magicstack.magicpython-1.0.12/grammars/MagicPython.tmLanguage

My config (relevant parts):
User
{
    "python.globalModuleInstallation": true,
    "python.pythonPath": "/usr/bin/python3",
    "files.exclude": {
        "**/__pycache__": true,
        "**/db.sqlite3": true,
    },
    "terminal.integrated.shell.linux": "/bin/shell",
    "files.autoSave": "off",
    "python.linting.pylintPath": "/usr/local/bin/pylint",
    "python.analysis.typeshedPaths": [ "/usr/share/typeshed/"],
    "python.autoComplete.typeshedPaths": [
        "/usr/share/typeshed/"
    ],
}

Workspace
{
	"folders": [
		{
			"path": ".."
		}
	],
	"settings": {  "files.exclude": {
		"**/.git": true,
		"**/.svn": true,
		"**/.hg": true,
		"**/CVS": true,
		"**/.DS_Store": true,
		".gitignore": true,
	},
	"python.pythonPath": "/usr/bin/python3.7",
	"python.linting.pylintPath": "/usr/local/bin/pylint3.7",
	"python.linting.mypyEnabled": true,
	"python.linting.mypyPath": "/usr/bin/mypy3.7",
	"python.linting.mypyArgs": [],
}
}

content of /usr/bin/mypy3.7:
#!/bin/sh
exec python3.7 -m mypy --python-version 3.7 $@

I've looked in #343 and #1440 also, but no luck.

I can't replicate:
def spam(x: int) -> str:
    return 3.14

x =

Leads to both mypy and pylint reporting a syntax error:

Removing the syntax error shows mypy results:

It also works with your sample:

My suspicion is that you might have a mis-configuration with mypy or you need to update your version.

I found the issue: The MyPy linter module expects the file always to have a .py extension and I am editing an .pyi file.


10-K parser missing text from links

Issue with load_file_content, will fix tomorrow.

Also: structure of output dict is unintuitive, will improve soon.

Considering implementing this file structure
{
   "id": "000000695524000046_epac-20240831",
   "document": {
       "parti": {
           "item1": "Item  1. Business\n\nGeneral\n\nEnerpac Tool Group Corp...",
           "item1a": "Item 1A. Risk Factors\n\nThe following risks...",
           "item1b": "Item 1B. Unresolved Staff Comments\n\nNone.",
           "item1c": "Item 1C. Cybersecurity\n\nOur cybersecurity program..."
       },
       "partii": {
           "item7": "Item 7. Management's Discussion and Analysis...",
           "item7a": "Item 7A. Quantitative and Qualitative Disclosures..."
       }
   }
}


Promo code generation

This used to be possible: https://github.com/fastlane-old/codes but that repository now has the message "This tool is no longer maintained and does not work."
Is it now no longer possible to automate? Or is it still technically doable if someone writes the code?
Thanks for your time :)

Thanks for submitting this issue. The tool was hardly used, and it wasn't worth the time updating it to work with the new iTunes Connect.


Loading an mp3 into an AudioStreamPlayer crashes Godot

Godot version:
3.1 Stable
OS/device including version:
Windows 7 Home
Issue description:
Loading an mp3 file into an AudioStreamPlayer causes the program to crash, an error message is expected instead.
Steps to reproduce:
Create an AudioStreamPlayer on a Node.  On the AudioStreamPlayer Inspector->Stream select Load.  Select file type "All Files (*)" and select a .mp3 file.

Please open a new issue with a reproduction project.

Probably a Windows10 related issue with long file names?

Unless the absolute path was longer than 260 characters, it's not related. If it's actually longer than 260 characters, see https://github.com/godotengine/godot/issues/52799.

Hello, I have a similar problem.  Format not supported for WAVE file (not PCM). Save WAVE files as uncompressed PCM or IEEE float instead.
editor/editor_file_system.cpp:1764 - Error importing 'res://Treasure Hunters/Treasure Hunters/Music/mixkit-game-level-music.wav' I don't know how to solve it, any help would be very helpful.

Please open a new issue, this has been closed for two years


feat: CustomerJourneysApp (READ)

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1094  👈
#1078 : 1 other dependent PR (#1067 )
#1077
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite


Show restaurant opening times

Description

Especially useful for holidays when opening times change

Blocked by calendar service - read calendar entries for current week and display them.


Cloud Storage not using HTTP Agent set in AppOptions

Describe your environment

Operating System version: Mac OSX
Firebase SDK version: 8.0.0
Firebase Product: storage
Node.js version: 12.0.0
NPM version: yarn 1.0.0

Describe the problem
Firebase Storage does not use the httpAgent set in AppOptions
Steps to reproduce:

Initialize firebase using initializeApp with a custom httpAgent in the AppOptions object
Run any firebaseApp().storage() function that results in an HTTP request (e.g. getSignedUrl())
The HTTP request is not handled by the httpAgent

There's no way to pass an http.Agent into the @google-cloud/storage APIs. So this is working as intended. Unfortunately it's not mentioned in the documentation today. Only the limitations with RTDB and Firestore are indicated in the current docs:
Realtime Database and Firestore use other means of communicating with
the backend servers, so they do not use this HTTP Agent.

We can get this information updated. If your intention is to use the Storage APIs behind a proxy you can do so by setting the https_proxy environment variable.
export https_proxy=http://localhost:3128

Thanks @hiranya911 .
I need to provide an SSL certificate to my proxy, which is why I was trying to set the http.Agent.  Is there a way to do this with ENV variables?

@seanemmer not quite sure how to achieve that. If it was just username+password auth, I suppose you could include that in the proxy URL. Cloud Storage uses Gaxios to make HTTP calls, which in turns uses HttpsProxyAgent to provide proxy support. Perhaps look into the docs of these libraries or try filing a bug in their repos.

Gaxios has the option to set your own agent.  In fact, so does https://github.com/googleapis/google-api-nodejs-client.
Unfortunately, firebase-admin does not expose this ability from Gaxios.  Is this something I should try to have addressed on the firebase-admin repo, or on @google-cloud/storage?

It should be fixed in @google-cloud/storage. If they expose this ability then we can plumb the http.Agent specified in admin.initializeApp() through to their API.

I'm going to close this as we don't have an immediate recourse in this repo. We can revisit this if the GCS server SDK provides a way to set http agent in the future.


Add pre-commit step for for code formatting

Add a pre-commit step to re-format code.
A tool to reformat could be black

From review:

black provides odd results in some cases (ATM_STASHLIST)
We might want to use a configurable linter as some longer lines can't really be avoided


feat(core): support enter data on blur event in the InputChip element

@serslon can you please resolve the conflicts

@serslon can you please resolve the conflicts


Some thoughts on estimator explainers (WIP)

Don't mind me.  Just scribbling down some suggestions as I familiarize myself with the package.
On the "exposure-based models"

One way to explain: Models that adjust for many confounders at once using propensity scores.  Propensity scores are estimates being assigned to the exposed group.  These models calculate propensity scores for each individual, even when they weren't in the exposed group.
On the "outcome-based models"

Perhaps linear regression should be presented as the default choice so as not to encourage people to use the more heavy duty models when a simpler model will work fine and is more defensible?
Relatedly, in the text below...

it says it uses bootstrap CI for "Linear Regression models".  Perhaps it should be "Outcome-based models", since that would allow for nonlinear double ML models in the future?
Also the linear regression estimator in DoWhy does not use bootstrap.  It uses the statsmodels library, which uses t-distribution-based CI.

@robertness

ShowWhy enables emulation of randomized controlled trials that produce a high standard of real-world evidence.

I could not find any references.
An animated screenshot in a gif showing how the package works would be great!

Found it!
Community Workshop on Microsoft's Causal Tools


15.11.2017 release doesn't show notes from dropbox

15.11.2017 release doesn't show notes from dropbox. App reinstalling and relinking Dropbox doesn't help iOS 10.3.3
Dropbox folder boostnote-mobile exists and contains old notes

HI @enriro, sorry for the inconvenience.
This is bug,so we already fixed it and sent for Apple’s examination.
Wait a moment.

Hi @enriro , thank you for waiting. This problem was fixed at iOS v1.1.0 and Android V1.0.9.
If bug still occurring, feel free to tell me.


[gmp] Build error

error: building gmp:arm64-osx failed with: BUILD_FAILED
Host Environment

OS: Mac OS 12.6 on ARM M2
Compiler: Apple clang version 14.0.0 (clang-14<IP_ADDRESS>)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

To Reproduce
Steps to reproduce the behavior:
./vcpkg install amp
Failure logs
Include '[gmp] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-07-21-a0e87e227afb536c62188c11ad029954f28fdb22
vcpkg-scripts version: 79fa9d85c 2022-10-17 (7 days ago)

Cut and paste the appropriate build messages from the console output.
Attach every failure log file mentioned in the console output.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.
autoconf-arm64-osx-err.log

I've attached the log.

Do you have automake installed on your machine?

No I don't have it. I will try to install it and recheck if it fix the issue.

I've installed automate but it does NOT fix the issue.

automate
Is this typo?

Yeah it was typo.

This issue hasn’t been updated in 3 month, if it is still an issue, please reopen this issue.

Do you have automake installed on your machine?

brew install automake   fixed

Note that this issue is related to 30334


self-bond field of validator table is missing

self-bond info should be added in validator table according to explorer design

fixed in https://github.com/QOSGroup/qmoon/pull/169


Using the install command doesn't seem to log at the correct level.

Description
Currently using the install command with a trace log doesn't show the debug like I'm expecting.
newrelic config set -k logLevel -v trace
Current behavior
No Debug logs are produced.
Expected behavior
Debug logs are available.

This is only an issue on initialization it seems.  https://github.com/newrelic/newrelic-cli/pull/446 has a test that reproduces the issue.


Download FTP script: wrong URL for old versions

Hi,
The URL generated to download cache is wrong for older versions (for example 75) : Genome version is not specified in the filename.
ftp://ftp.ensembl.org/pub/release-${ENSEMBL_RELEASE}/variation/VEP/${CACHE_TYPE}_${ENSEMBL_RELEASE}_GRCh${GENOME_BUILD}.tar.gz
should be
ftp://ftp.ensembl.org/pub/release-${ENSEMBL_RELEASE}/variation/VEP/${CACHE_TYPE}_${ENSEMBL_RELEASE}.tar.gz

Thank you very much for pointing this out! This should be fixed in #5525bff (https://github.com/TMiguelT/vep-cache-extractor/blob/master/download.sh#L62)


Enable I/O tests to benchmark hostPath volumes

Doing I/O benchmarks directly on top of containers implies making those I/O operations on the container filesystem, usually OverlayFS. This PR enables some ripsaw benchmarks to perform those tests on hostPaths  devices in order to avoid the OverlayFS layer.
   Instead of defining hostVolume, which impacts the entire thing, just redefine cephVolume.   Then you do not need all those extra CI scripts.  If you are running CI, the storageclass will not be defined anyway, so it's ok to override it.  In hindsight I shouldn't have called it "cephVolume" because it really isn't anything to do with Ceph, it's just a filesystem somewhere that the benchmark can use.   Perhaps the error was to use that name, but please, please let's not do it this way.

 I don't know why ycsb tests failed, it hasn't any relationship with this changes though.

we shouldn't let unrelated CI problems block it!   I'm having that problem as well with my own PRs, see ripsaw PR 269.   Looking at this PR code now that you've updated it...

Results for minikube_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_backpack
Pass
1
00:01:39

test_ycsb
Pass
0
00:02:02

test_fiod
Pass
0
00:07:47

test_fs_drift
Pass
0
00:05:16

test_smallfile
Pass
0
00:06:54

test_pgbench
Pass
0
00:02:52

test_iperf3
Pass
0
00:03:13

test_sysbench
Pass
0
00:02:04

test_uperf
Pass
0
00:05:12

test_byowl
Pass
0
00:01:50

test_hammerdb
Pass
0
00:02:20

Results for kni_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_backpack
Pass
1
00:06:11

test_ycsb
Pass
0
00:05:09

test_fiod
Pass
0
00:13:39

test_fs_drift
Pass
0
00:08:06

test_smallfile
Pass
0
00:08:52

test_pgbench
Pass
0
00:04:18

test_iperf3
Pass
0
00:04:04

test_sysbench
Pass
0
00:03:06

test_uperf
Pass
0
00:08:13

test_byowl
Pass
0
00:04:17

test_hammerdb
Pass
0
00:04:39

Do we need anything else to get this one merged? :)


Graphs extend too high

Not only are they covered by the corner tooltips when I hover over a building button, it also goes past the top of the screen for me.

Two things here:

The first issue is something we're going to have to live with for the time being, I made a executive call that the tooltip window in that particular UI skin is more important to see than to have the graphs overlayed on top. I still think that's the right decision.
The aforementioned problem, as well as it going past the top of the screen, will get resolved with a future update of KTNS which will change the way the userscript's viewport is laid out on the page.


Replace jQuery with vanilla JS

With Ember moving towards a jQuery-less world, it would be awesome to have this addon continue to work without $.

Tests pass
all the example apps function as expected

Note: I changed the MouseEvent property that's being read (previously pageX/Y to clientX/Y) because ember-test-helpers/ember-native-dom-helpers don't allow that property to be set when creating events in tests. However, there is no change in functionality.

Thanks so much for the PR, it looks really solid. A member of the team will review it in detail as soon as possible.

@nlfurniss thanks for the PR! it looks great, my initial question is can we use @ember/test-helpers as well? It looks like they support jquery-less mode also.

@nlfurniss thanks for the PR! it looks great, my initial question is can we use @ember/test-helpers as well? It looks like they support jquery-less mode also.

I could, but that requires updating the test syntax to the new QUnit syntax, adding babel async/await support, etc and would make this PR very large and difficult to review

Let’s think about this from the point of view of consuming apps that use the drag test helper.
Questions on my mind:

Do the helpers from @ember/test-helpers not work at all in old-school tests?
Are we OK introducing ember-native-dom-helpers as a transitive dependency for consuming apps?

Given that the extra dependency will only affect the dev/test build for consuming apps, I think this is a reasonable tradeoff. Nonetheless we should consider its impact and be sure it’s not possible to use @ember/test-helpers for the same purpose.

Good news - I was very wrong about `test-helpers! I had tried to use them over native-dom-helpers in another project and ran into an issue that must have been specific to that project. Everything works perfectly using test-helpers here.
Please note, I set Babel to not transpile async/await since it's only being used in tests running in headless Chrome

Spoke too soon 😞
Even though the tests pass locally in headless chrome and in real chrome using test-helpers, for some reason in CI the element's getBoundingClientRect values seem to be undefined which is causing tests to fail.

@nlfurniss great detective work!
The thing that jumps out at me from the screenshot is:

Where’s the dx gone? 😅
This should come from the calling reorder helper:
let dx = targetElement.offset().left - OVERSHOOT - element.offset().left;
let dy = targetElement.offset().top - OVERSHOOT - element.offset().top;

drag(mode, element, () => { return { dx: dx, dy: dy }; });

Any idea what happened to dx?

@nlfurniss that looks pretty good to me.

@jgwhite I added the missing property, as well as upgraded from ember-cli-qunit to ember-qunit because cli-qunit is deprecated and ember-qunit helped me debug this issue locally

Thanks for your rigour and fantastic work @nlfurniss!

@nlfurniss your fine work has been released as part of 1.12.2. Thanks again 🎩


Certify Forecast Visual

Currently, my organization will not permit the use of uncertified visuals with Power BI. The FlowViz Forecast visualization offers tremendous potential value to my teams, however, I am unable to use it do to the lack of certification.
Do you plan to certify the Forecast visual with the AppSource?

It's not my visual so unfortunately it's down to the creator of it to get it certified :(

Oh, who is the creator?


Create notification banner component

What
Create the notification banner component in GOV.UK Frontend.
Why
Having reviewed the feedback from the working group, we now need to build the component in Frontend ready for release.
Depends on

#1933
#1934

Further detail
Some specific bits of feedback worth considering from the working group and accessibility clinic findings:

it’s recommended we remove aria-labelledby from the markup for the red and the green banners as they’re not landmarks (https://www.w3.org/TR/wai-aria-1.1/#landmark_roles) and therefore the label will never be read out (the same actually applies to our current error summary)
we should explain the accessibility considerations – for example what the role= does – in comments in the code and/or tests.

Done when…

[x] Nunjucks template / macro created based on the API agreed in #1933
[ ] Tests for Nunjucks template
[ ] Add styling for notification banner
[ ] Component auto focuses when using role="alert"
[ ] Tests for component auto focus JS
[ ] Cross-browser tested
[ ] Take finalised version to accessibility clinic for testing

I'm thinking that one thing we should highlight at the accessibility clinic is the approach of making the <p> tags look like headings when we have just a single line of content in the banner. We do this as we want to draw attention to the message in the banner and semantically you should haven't a heading tag that doesn't act as a heading for some content below it. However it'd be good to confirm that this isn't a concern as we're making an element look like another element.


Jodd Mail:  Chinese Charset (e.g. gb2312) txt file attachment garbled

Current behavior

Recieve a mail with chinese charset txt file attachement, and all Chinese Charactors ard garbled
接受一封带有中文编码格式txt附件的邮件,附件中的中文乱码.
Expected behavior

Steps to Reproduce the Problem

Would you be so kind to save the email content? Usually this is a  problem of sending and not having set the correct encoding. You can use EMLComposer for saving received emails.

@igr   Hey, man. It had the same mistake as issue 725. You can have a look!
@jawar-cn 老外很懒，😄

This should work:)

Please see #723 - I added sending of Cyrilic string. Just please check the encodings.


Add CKUT outstanding issues

Based on a request here, I have added CKUT podcast feeds to the site. Some outstanding issues that arose in the process:

[ ] Search behaves in unexpected ways when certain search terms are used. EX. searching for 'am' produces multiple results for a single show, and these results are not fully cleared when the search text is deleted.

[x] The date of the added show doesn't include a time. Unexpected difficulty getting the modified date from the mp3 header.

[x] In the apple podcast app, episodes do not always successfully play on the first attempt.

Solved the date issue, by parsing it out of the mp3 file name.
Not playing on first attempt was due to multiple redirects on the mp3 download link.

Search issues fixed by re-scraping episodes for two shows where duplicate newest ep_date were present.

Add an index to the episodes table in the DB to enforce show_id and ep_date as unique value pairs. This will eliminate the possibility of a show with multiple episodes sharing the same date and time.


MPI LrtsAbort doesn't kill all replicas

Original author: Jim Phillips (@jcphill)
Original issue: https://charm.cs.illinois.edu/redmine/issues/1706

User reports that when one replica on Stampede2 dies the others keep running.  It looks like the machine_exit code doesn't kill other replicas.  It appears to try to shut things down cleanly, which is not consistent with an abort call, particularly when that is what MPI_Abort is supposed to do.  The other machine layers should also be inspected for this behavior.
void LrtsAbort(const char *message) {
    char *m;

    m = CmiAlloc(CmiMsgHeaderSizeBytes);
    CmiSetHandler(m, machine_exit_idx);
    CmiSyncBroadcastAndFree(CmiMsgHeaderSizeBytes, m);
    machine_exit(m);
    /* Program never reaches here */
    MPI_Abort(charmComm, 1);
}

static void machine_exit(char *m) {
    EmergencyExit();
    /*printf("--> %d: machine_exit\n",CmiMyPe());*/
    fflush(stdout);
    CmiNodeBarrier();
    if (CmiMyRank() == 0) {
        MPI_Barrier(charmComm);
        /*printf("==> %d: passed barrier\n",CmiMyPe());*/
        MPI_Abort(charmComm, 1);
    } else {
        while (1) CmiYield();
    }
}

Original author: Jim Phillips (@jcphill)
Original date: 2017-10-06 14:48:25

Also, we have rank 0 (rather than the communication thread) making MPI calls, which is not kosher for MPI_THREAD_FUNNELED.

Original date: 2017-10-06 15:29:21

Assign to Sam as MPI machine layer owner.
I'm thinking LrtsAbort should just call MPI_Abort and not try to do anything more.

Original author: Jim Phillips (@jcphill)
Original date: 2017-10-06 15:46:15

Or have the comm thread call MPI_Abort.

Original date: 2017-10-06 17:17:15

I'm not sure how we should go about making this safe for thread level FUNNELED in SMP mode.

Add a flag to the objects that get posted to the comm thread's PCQueue for sending, have the comm thread check that flag before every send.
Add some kind of separate atomic flag that the comm thread checks every once in a while, workers set it when they want to abort.
Use MPI's thread level SERIALIZED, do a node-all barrier (including the comm thread) then call MPI_Abort.

#1 and #2 will add some small overhead to the common cases of not aborting. It looks like the existing implementation of LrtsAbort in the MPI layer basically does #3, except it still sets the thread level to FUNNELED. I don't think there is any extra overhead of setting SERIALIZED over FUNNELED in any common MPI implementation...
Here's a patch without any fix for the thread safety issue: ~~https://charm.cs.illinois.edu/gerrit/#/c/3111/~~ https://github.com/UIUC-PPL/charm/commit/fc3fdb096c0a2cfa41808798f9d67813109fed23

Original author: Jim Phillips (@jcphill)
Original date: 2017-10-06 21:41:33

Regarding 3, if you could get the comm thread to participate in a node-all barrier you could just have it call MPI_Abort.
Why not hijack commThdExit in machine-common-core.c, since it is already being checked on a regular basis?  If the comm thread is going to be checking a flag on a regular basis there is no reason for it not to be a nested flag, that if set enables a check for both clean exit and abort.
static void CommunicationServer(int sleepTime) {
#if CMK_SMP
    AdvanceCommunication(1);

    if (commThdExit == CmiMyNodeSize()) {
        MACHSTATE(2, "CommunicationServer exiting {");
        LrtsDrainResources();
        MACHSTATE(2, "} CommunicationServer EXIT");

        ConverseCommonExit();

#if CMK_USE_XPMEM
        CmiExitXpmem();
#endif
        CmiNodeAllBarrier();
        LrtsExit();
    }
#endif
}

Original date: 2017-10-08 13:54:10

I'm kind of inclined to question the assumption that (presumably) an application-level call to CmiAbort should bring down all partitions. In as much as running with partitions means having essentially separate instances of the entire job and runtime, that just happen to have been scheduled together, working instances should be able to continue just fine. Calls to an API at the partitioned level (i.e. Cmi*) should logically stay within a partition.
That logic breaks down as soon as one wants to actually have any interaction among the partitions, as in replica-exchange methods, because then those communication operations have to report failure, callers have to check for it, etc.

Original author: Jim Phillips (@jcphill)
Original date: 2017-10-08 14:48:26

How would you detect that the partition you are sending an asynchronous message to has aborted?
Also, there are many ways to run multiple independent jobs. The partition feature exists to allow those jobs to communicate.


ja: Make docs/concepts/scheduling-eviction/assign-pod-node.md follow v1.19 of the original text

This is a Feature Request

What would you like to be added
Update docs/concepts/scheduling-eviction/assign-pod-node.md to follow v1.19 of the original (English) text.
Why is this needed
content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/tree/dev-1.19-ja.1/content/ja/docs/concepts/scheduling-eviction/assign-pod-node.md
Original
https://github.com/kubernetes/website/tree/release-1.19/content/en/docs/concepts/scheduling-eviction/assign-pod-node.md
diff between translated and v1.19
https://gist.github.com/e755e6f71da41da0c8a78ee65d20f72c
Note
Currently, we use dev-1.19-ja.1 branch. Please open a PR targeting the branch.
ref
https://kubernetes.io/ja/docs/contribute/localization/
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel.

/triage accepted

/assign

/close


[SCB-482] Http2 support for java-chassis

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

and please provide UT and integration test case

Coverage decreased (-0.02%) to 87.425% when pulling caa539fd5a16e0bcf6236920eefa13e14a620e19 on Rajadeepan:master into 41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master.

UT and IT is in progress will raise the commit soon.

commit added for UT and IT

there are conflicting files, please resolve it.

Please submit commits to this PR with the following messages:
[SCB-482]xxx xxx
in order we can rebase and merge or we just can squash and merge.


test [nfc]: Ensure user IDs, message IDs, etc. are positive

Zulip user IDs, message IDs, and stream/channel IDs (and anything else that's an ID of a row in the server database) are positive integers. So are our account IDs. To help keep test data realistic, enforce those in the example-data functions.
This follows up on 739fa8491 (in #828; /cc @sm-sayedi), which made a similar fix for one test case.

LGTM, thank you!


Page layout

Hello, the page seems a little mess,so i change the page layout
New page:

source
I'm not sure my layout is appropriate, so I use React to write this page(i new in Jquery,so
,I didn't modify the source code directly)

@pjshu great!!! just see the existing codebase and try to implement it!

Thanks @pjshu.
I like the design. It's neat and smooth. But since it's for Flaskcon, it made more sense to use Flask (: So i will just wait for some other organizing members to check first.
I'd like to point out one thing on the countdown, based on the screenshot you shared, is it 10 days 109 hours 227 minutes 445 seconds?

@pjshu great!!! just see the existing codebase and try to implement it!

thanks, i have add some note in my code,
source code:
https://github.com/pjshu/website/tree/master/src/components
https://github.com/pjshu/website/blob/master/src/App.js

Thanks @pjshu.
I like the design. It's neat and smooth. But since it's for Flaskcon, it made more sense to use Flask (: So i will just wait for some other organizing members to check first.
I'd like to point out one thing on the countdown, based on the screenshot you shared, is it 10 days 109 hours 227 minutes 445 seconds?

thanks,The problem has been fixed

@pjshu see the current design if ok!
great


How to do an "OnTimer" pattern

OMG, I love this project - amazing, and it just works!
What's the right way to do an OnTimer pattern? E.g. I'd like to do a countdown like component.

Sheesh just found it :) http://localhost:8988/guide/tasks#launching-one-time-tasks
Thanks!

Ah, there we go!
onesecondtask = hd.task()
onesecondtask.run(one_second_tick, state, onesecondtask)
if not onesecondtask.running:
    onesecondtask.rerun(one_second_tick, state, onesecondtask)


rename pop to try_pop with deprecation warning

I'd love to just mark pop as deprecated, but that's not stable until 1.9, so I added some documentation and feature flagging so that we'd provide a warning where possible.

Thanks much!


Include creation date on saved data

This way you could sort bookmarks by date, and find a bookmark you created last week (if you don't remember the name or the tags).

It's an interesting idea, definitely.  But I'm not sure how it would work in practice.
Editing the .data file to add new bookmarks is pretty straight-forward at the moment - my real installation has ~600 bookmarks at the moment.  Adding a timestamp, as something Date.parse could understand would make things a little more complex, even if it was just a new attribute of the li or a tag.
Probably the best way would be a pre-commit hook to add it on changed-lines, but that gets hard to distribute (as hooks aren't cloned).
I'd be curious to see how you'd solve this problem?
(Obviously using the on-page editor makes it easier, but I suspect most users ignore that.  I know I do.)

Awesome! :) I was planning to use the web interface anyway. If I was editing the file manually, I think json would be much more comfortable than pure html. Also we could add a command to our text editor to insert the current timestamp.


Add doc about POSIX implementation in Zephyr

This adds initial documentation of the POSIX subsystem in zephyr and the status of the APIs.
We also move all OS abstraction layers into one section in the documentation under abstractions.

@nashif: Thanks for updates, but I don't see any responses to the concern regarding how word/path component "abstraction" relate to OS compatibilities API. In more detail above, https://github.com/zephyrproject-rtos/zephyr/pull/17796#pullrequestreview-272566726

And let me say that such a path is confusing, who would guess that guides/abstraction/ actually describes OS abstraction?

This is just the directory in the tree and nobody really should care what the name of the path is beside someone adding content. For someone looking at the documentation this still says "OS Abstraction".
I personally dislike joining strings, so osabstraction just look worse than abstraction alone. Comprise: Maybe just call this "osal".

@nashif :

This is just the directory in the tree and nobody really should care what the name of the path

I disagree. Maintainers of the project should care about everything, plus dedicated developers of the project should care about various things, and the point above certainly worth caring about, otherwise we as well can use mismatching and confusing names all around.

Comprise: Maybe just call this "osal".

Perhaps, if nothing better comes to mind. There's another compromise: leave it at "porting", like it was before (re: doc/guides/porting/cmsis_rtos_v1.rst → doc/guides/abstractio/cmsis_rtos_v1.rst). And another compromise: rename porting -> portability.

@nashif I am moving this to next release, since it was not reviewed in time for 2.0


2541 order typechecks

Fixes #2541

There are still two filter tests I haven't been able to fix:

plan filter with both index and field projections
plan filter on date

For these two tests, the typeSelector impl in this PR is unable to extract inputs and I'm not really sure why.

@rintcius ready for another look.

Merging on account of @rintcius's approval.  This never got an assignee, so I'll take it and just trust his review.  :-D


Make MultiOptimizer serializable

Description
The current implementation of MultiOptimizer puts grads and vars inside the optimizer_specs variable. Since the grads and vars are not serializable, any model that uses MultiOptimizer class cannot be saved or checkpointed. This PR will only extract the necessary optimizer_specs components that are useful for re-instantiating the MultiOptimizer instance inside get_config() method, leading to a serializable MultiOptimizer implementation.
Fixes # (issue)
Type of change

[x] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[ ] By running Black + Flake8
[x] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*
I have tested model.save() method after this change. Prior to this change, a trained model (has run training iteration for at least 1 step) with MultiOptimizer cannot be saved because of the un-serializable grads and vars. With the fix, I can verify that model.save() method works.

Can you add a serialization test?

Can you add a serialization test?

The serialization test has already been there (code ref). The problem is that the grads and vars are not there until the model has been trained for at least one iteration.
Therefore, the existing test doesn't catch the failure case. However, if we were to train the model for one iteration in the test, it's a bit far-fetched for a unit test.
Any suggestion on how to deal with this?

You could extend the test.
We have some other test cases where we train the model few steps. So you could use something similar.

Yes you are right. Sorry I didn't read enough code to realize we can fit the model during testing.
I have added a test that check the serializability. And I have verified that without this PR the test won't pass.

@bhack Is there any more thing I can do to help facilitate merging of this PR?

Thanks


not enough

wanted to lower the 1.9gb MB without losing quality...
checked SVT-AV1 in Hybrid and your mod in StaxRip
In Hybrid - the native one is used - processed with deterioration of the image and FPS
In StaxRip v.2440 your mod has been processed Beautifully! but there is not enough Bit Switching. Please add.

Thanks for reporting this Issue, bit it's related to StaxRip. @Dendraspis need the Info.

@Andrasolin
Great, you have found somebody who can ping/spam me for you.   😁
But nothing is needed as SvtAv1EncApp does not change the bit depth regardless your settings. You have to use AviSynth/VapourSynth to change the bit depth before passing it to the encoder.


No module found during bootstrap, unable to init ocLazyLoad

I am always getting the following exception.  How to resolve this?
Note: I am using requirejs.
No module found during bootstrap, unable to init ocLazyLoad.
You should always use the ng-app directive or angular.boostrap when you use ocLazyLoad.

I always get it as well. As far as I can tell, everything works just fine.
I'm going to do a PR to make it configurable to turn this message off in the config stage, perhaps as
$ocLazyLoadProvider.config({
  suppressBootstrapWarning: true
});

The offending code says:
            if (modulesToLoad.length === 0 && !((window.jasmine || window.mocha) && angular.isDefined(angular.mock))) {
                console.error('No module found during bootstrap, unable to init ocLazyLoad. You should always use the ng-app directive or angular.boostrap when you use ocLazyLoad.');
            }

Oddly enough, my bootstrap code looks like:
angular.element(document).ready(function() {
  angular.bootstrap(document, [app['name'], function() {
    angular.element(document).find('html').addClass('ng-app');
  }]);
});

I think the test is in there as a guide for people who may have misconfigured something, but there are valid reasons to fail the test even when you've got things working just as you need. It seems in our case not to like that (a) we put ng-app on after bootstrapping (this pleases mocha, when we're in unit test mode), and (b) we inject the $ocLazyLoad provider very early.
It seems a workaround until it's fixed would be to set angular.mock = true or something and hope some other library isn't also using truthy for that property as a proxy for "is in test mode", or that $ocLazyLoad doesn't change its behavior otherwise in "test mode". :)

Yes, you'll get this error if oclazyload cannot find ng-app. It's not recommended because the lib might want to reload angular native modules if one of your lazy loaded dependencies requires it (angular-animate, angular-cookies, ...), since it won't know that it has been loaded.
It may not be a problem if you call angular.bootstrap yourself, not sure about that though, I'd have to make some tests :)

When is the "right" time to inject the provider or service to allow it to recognize ng-app, then?  My project is private, so I can't just point right to it, unfortunately...
You can see I pushed a commit to my fork.... you're welcome to it if you want it. I won't both with an actual pull request because I'm still not convinced the error is spurious. :)
Having noted that the entire "find the ng-app" section has a comment that says, "this might not be necessary" or something to that effect, I was doubly confused about what's going on... my plan had been to use ocLazyLoad only via regular injection, not as a directive or any other fancier parts of the system, which is a reason why I suspected that in my use case, the error message wasn't applicable.

Any updates?

Ya, I am bootstrapping my angular bu above way, But Exactly, I am not getting the solution for. What I will change in my code, so I will get a solution.


Responsive viewer

Hello, excuse is there any method to make responsive the viewer? Many thanks in advance.

Take a look at "Parent Size" session of the Demo App


Add MIT-0 license, prepare for v1.13.0 release

See:

https://github.com/artichoke/artichoke/pull/2694
https://github.com/artichoke/artichoke/pull/2694/commits/4d17eddd7d3549ec31263729c833d2d3f94b5c55

tzdb_data is MIT-0 licensed.


Support for TG16/PCE cue files

Thank you for adding TG16/PCE support. One last thing we would need is support for cue files to play CD games. As far as I know, as long as the cue file is correctly formatted and points to the right bin file, it will load the game. I haven't tried messing with the code to see if adding cue file support was enough though.

Hi, thanks for the suggestion. This is now available in the 3.4 release.


how do i download video example for lua api

Describe your problem here.
i clicked it and got this:
https://cdn.discordapp.com/attachments/840678333602857040/888568130283139082/bopeeboTestVideo.zip
:(
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no?

yep it just broke find a yt tutorial and copy from video or they may have put in desc


intel_adsp_cavs15: run msgq testcases failed on ADSP

Describe the bug
run tests/kernel/msgq/msgq_usage/ failed on ADSP
To Reproduce
Steps to reproduce the behavior:

twister -p intel_adsp_cavs15 --device-testing -T tests/kernel/msgq/msgq_usage/ --west-flash="/home/ztest/work/zephyrproject/zephyr/boards/xtensa/intel_adsp_cavs15/tools/flash.sh,/home/ztest/work/zephyrproject/modules/audio/sof/keys/otc_private_key.pem,/home/ztest/work/rimage/config,/home/ztest/work/rimage/build/rimage" --device-serial-pty="/home/ztest/work/zephyrproject/zephyr/boards/xtensa/intel_adsp_cavs15/tools/adsplog.py,--no-history"

Logs and console output

Running test suite msgq_usage
===================================================================
START - test_msgq_usage
Unknown message 0

Environment (please complete the following information):

OS: Fedora28
Toolchain: Zephyr-sdk-0.12.4
Commit ID: c5e50ef0e219

Please remove Stale label.

Works for me on both cavs15 and cavs25 as of current main.  Retest?

Blocked by #38446 . I will retest this one when #38446 is fixed.


Group of avatars

### Tasks
- [ ] https://github.com/digdir/designsystemet/issues/2305
- [ ] https://github.com/digdir/designsystemet/issues/2306

We discussed this variant and decided to postpone this to after v.1. Hopefully most teams will be able to create what they need grouping our Avatar component
If you need a group of avatars or stack of avatars. Please let us know 😃

Moving this to backlog for now


Catalogue item propeties bug #476

Description
#476
Testing instructions
Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage
[ ] {more steps here}

Agile board tracking
closes #476

Codecov Report
Attention: Patch coverage is 91.90476% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 93.52%. Comparing base (f321a30) to head (286378a).
Report is 11 commits behind head on develop.

:exclamation: Current head 286378a differs from pull request most recent head 70450b5. Consider uploading reports for the commit 70450b5 to get more accurate results

Files
Patch %
Lines

...gue/category/catalogueCategoryDialog.component.tsx
88.27%
17 Missing :warning:

...gue/category/cataloguePropertiesForm.component.tsx
93.25%
17 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #478      +/-   ##
===========================================
- Coverage    93.64%   93.52%   -0.12%
===========================================
  Files           61       61
  Lines        16139    16371     +232
  Branches      2104     2137      +33
===========================================
+ Hits         15113    15311     +198
- Misses        1020     1058      +38
+ Partials         6        2       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Fix the aria-label and improve testings


fix(workflows): add limit to pulling workflows

Fixes RVT-3753
Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1020  👈
#1016
#1015
#1011
#1010
#1009
#1008
#1000
#1007
#1001
#999
#998
#996
#995
#988
#986
#974
#987
#977
#965
#964
#963
#962
#957
#956
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


andThen()

Introduce new andThen method: https://doc.rust-lang.org/rust-by-example/error/option_unwrap/and_then.html
This method can be used to e.g. map an Option into another option:
some(1)->andThen(fn(int $value) => $value > 1 ? some($value) : none())  == none();

They apply to:

[ ] Result
[x] Option
[ ] maybe:  Promise?

❗ Currently Result::then() allows returning a promise which automatically gets unwrapped. That logic should be deprecated and removed in v3 since it's rather magically. The new andThen function should be used for this purpose. We'll have to add a note for that in the code and release notes.
(to investigate: if it makes sense to keep on supporting it during runtime, but make psalm fail)

< (to investigate: if it makes sense to keep on supporting it during runtime, but make psalm fail)
I think that's the right way of deprecating it, as it won't break peoples code, only SA builds.


Missing necessary header for atomic_inc_64_nv() used in logger.c

logger.c uses atomic_inc_64_nv() function, but doesn't include atomic.h. This breaks compilation on OpenIndiana.

released in 1.4.34


Delete worker

What? :boat:

This is a review/rework of https://github.com/RocketChat/filestore-migrator/pull/8 , https://github.com/RocketChat/filestore-migrator/commit/8c81bc071fabe2a128f1cd2786e35311a62af5fd, https://github.com/RocketChat/filestore-migrator/commit/f91e3a2d530a49df70b19c97d4b8e6df9738483e, https://github.com/RocketChat/filestore-migrator/pull/10

Links :earth_americas:

https://app.clickup.com/t/1mu78rr

PS :eyes:
That's all, folks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


DRAFT: Enable remote debugging (DO NOT MERGE)

DO NOT MERGE
This enables remote debugging in the prod containers. We've noticed a recurring issue where the server becomes unresponsive after migrating from our EKS deployment to ECS after a period of time. We originally assumed this was related to a memory leak or file descriptor leak. After monitoring both it doesn't seem to be related. Let's get some container built that we can deploy and attach delve.
DO NOT DEPLOY THESE UNLESS YOU KNOW WHAT YOU ARE DOING
We might want to end up producing an image that is debugable and setup either dev or a separate docker compose file to use it.

We might want to end up producing an image that is debugable and setup either dev or a separate docker compose file to use it.

I added conditional debug builds for the web container, and tags for all containers in CI.  If you're fine with the new build config we can merge this.


Request: Support for Forestry saplings in the farming station

Nothing additional

Has this been implemented yet? I could really use it.

Has this been implemented yet? I could really use it.

Hello? You wrote in a youtube comment that "adding new crops is super easy", could you please add forestry saplings?


Add ability to filter the whole batch of icons.

Searching though the icons with the browser itself is frustrating because the list doesn't scroll, so I implemented a filter. Maybe you find it useful? It's somewhat limited and doesn't show a "Sorry, no matches." screen jet.
Here's a preview:

Hmm. The list and code view scroll for me. How do I repo?
On Mon, Mar 14, 2016, 3:46 AM Peter Kaske<EMAIL_ADDRESS>wrote:

Searching though the icons with the browser itself is frustrating because
the list doesn't scroll, so I implemented a filter. Maybe you find it
useful? It's somewhat limited and doesn't show a "Sorry, no matches."
screen jet.
You can view, comment on, or merge this pull request online at:
https://github.com/PolymerLabs/polyicon/pull/1
Commit Summary

Add ability to filter the whole batch of icons.

File Changes

M bower.json
https://github.com/PolymerLabs/polyicon/pull/1/files#diff-0 (3)
M elements/elements.html
https://github.com/PolymerLabs/polyicon/pull/1/files#diff-1 (2)
M index.html
https://github.com/PolymerLabs/polyicon/pull/1/files#diff-2 (30)

Patch Links:

https://github.com/PolymerLabs/polyicon/pull/1.patch
https://github.com/PolymerLabs/polyicon/pull/1.diff

—
Reply to this email directly or view it on GitHub
https://github.com/PolymerLabs/polyicon/pull/1.

Sorry, I wasn't very precise with my explanation.
The browser of course scrolls the list, but as the icon list is partly hidden by the bottom panel it won't scroll them into view. The scroll offset is high enough but the bottom panels lay above the part of the list.
One example: Search for spa and go through results:

Also IMHO, I also find searching with the browser cumbersome because it's needs so much eye moment to find the marked icons.

Ah I see what you mean! The filtering is nice, but can we do it in vanilla js. I'm not sure we need the dependency for string matching :)

Yep, can do that if you prefer. I will update the pr shortly.

I'm unsure how to include the license of the 3th party project. I would greatly appreciate if you could explain to me how to do this? Or is it correct this way?

I'd prefer if we remove the 3rd party dep altogether and just use vanilla js to do the filtering.

You mean even remove the fuzzysearch function I striped out of the 3th party project? The whole thing is literally only 20 lines of code. The function is now inside index.html and no additional externals scripts are loaded :)

Ah cool. Didn't notice that. I'll give this a look in a bit.

Hmm... I removed the 3th party code already... You'll have to go one commit
back. Sorry
Von meinem Smartphone gesendet
Am 14.03.2016 10:25 nachm. schrieb "Eric Bidelman"<EMAIL_ADDRESS>
:

Ah cool. Didn't notice that. I'll give this a look in a bit.
—
Reply to this email directly or view it on GitHub
https://github.com/PolymerLabs/polyicon/pull/1#issuecomment-196527395.

LGTM


Urdf loader humble

Overview
Author: @Serafadam
Issue
Issue link (if present): N/A
Issue description: Publish accurate sensor transforms based on calibration data.
Related PRs
Changes
ROS distro: Humble
List of changes:

Add TFPublisher class (will move it later to depthai_bridge) to publish static transforms
URDF in depthai_descriptions publishes only the initial frames & mesh
Still need to figure out options and parameters for the TF publisher

Testing
Hardware used: OAK-D PRO
Depthai library version: 2.22
Visuals from testing
Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

Hi @Serafadam ,
Could you add imu frame for other camera models to urdf? This is what we really need.
For dm9098 (OAK-D S2 & OAK-D Pro), since the imu extrinsics does not exist in calibration data, I measured the following parameters from the pcb file.
<joint name="$(arg camera_name)_imu_joint" type="fixed">
    <parent link="$(arg base_frame)"/>
    <child  link="$(arg camera_name)_imu_frame"/>
    <origin xyz="-0.008 -0.037945 -0.00079" rpy="${pi} ${pi/2} 0" />
</joint>


Simplify HIP compatibility

Since #22 didn't seem to fix using exllamav2 on ROCm < 5.6 as reported on #46. I think it's better to use HIPBLAS_USE_HIP_HALF which require ROCm 5.5.0; that will make less code used only for HIP compatibility.

This makes sense, though I have no way to test it. Is there a performance impact?

Is there a performance impact?

Not that I could notice, benchmark results are identical on this PR or master.

Is it backwards-compatible? I.e. do I just change the build environment to ROCM_VERSION=5.5  and it should work for people still running 5.6?

Huh, I think you should have let it to 5.6, that what most distro use and what PyTorch use. 5.5 is just when HIPBLAS_USE_HIP_HALF was introduced.

Ooh..  I thought it was about something being deprecated in 5.6. I'll just revert then.

No, originally that code came from exllama v1 where latest was 5.4 at the time, I believe. Then came exllama v2 and I copied hipblas compatibility code without knowing that HIPBLAS_USE_HIP_HALF was introduced.

Also, I wanted to modify README, to maybe add some ROCm instruction (adding --extra-index-url https://download.pytorch.org/whl/rocm5.6 to pip command), but I don't think the instruction even work if you don't already have pytorch installed. python setup.py install --user just fail since it try to import stuff from torch.

I guess PyTorch ran into the same issue I did, being that the main PyPi index doesn't support multiple variants of one package. I'm not sure what the best approach is, though. Should there be one requirements.txt for every CUDA or ROCm version, split into Windows and Linux..? I guess that only works out to six files at the moment.
But as long as you have a version of PyTorch >=2.1.0, the requirement is satisfied, at least.


[RC2] PressableButton planes are in wrong location after restarting Unity

Overview
Some pressable buttons that have a movingVisuals with a non-zero z local position will have their planes moved way off the button when you enter play mode, even though in edit mode the buttons look fine.
Repro steps:

Create empty unity project
Import RC2 release
Unzip the following folder "Scenes" into the Assets folder
Examine Buttons/Deep/MyButton and see planes show up correctly over button

Hit play and observe the planes are now completely off the button:

Scenes.zip
Note that the root cause seems to be that the moving button visuals object has a non-zero local space z:

See #4527 for changes that probably triggered this regression.


getEventsAtBlockHeightRange does not indicate if some blocks were past the latest block height

Problem
When calling getEventsAtBlockHeightRange, if the latest block height is 1000 and you request 999 - 1010, the call returns successfully and you have no indication that blocks 1001 - 1010 were not actually available. This is an issue when you are continuously querying the latest block(s) for events. On certain requests, the latest blocks may not be available (I'm assuming this depends on which access node you happen to to hit). You can't be sure if the blocks were not available yet, or if there were no events in those blocks.
The Go SDK handles this by returning an array of every block that was queried along with a nested array of the events for that block. If you request something past the latest block height, the blocks that are not available will not be included in the results. So in the example above, you would only receive results for blocks 999 - 1000, and 1001-1010 would be missing from the results (which is what I would expect).
I'm not sure what the solution for this is with the current JS getEventsAtBlockHeightRange if you want to maintain backward compatibility, since it is just an array of all events (they are not grouped in the same way that the Go SDK results are).
Steps to Reproduce
const latestBlock = await sdk.send(
      await sdk.build([
        sdk.getBlock(true),
      ]), {
        node: this.accessNode,
      }).then(sdk.decode)

const events = sdk.getEventsAtBlockHeightRange('testEvent', latestBlock.height, latestBlock.height + 10),

// at this point, events will contain any events of 'testEvent' type for the latest block
// there is no indication that the other 9 blocks that were queried were not available.

I think this may be related to issue #583

@chriswayoub why would you go 10 blocks above latest block if it's the upper limit?
More logical would be to call sdk.getEventsAtBlockHeightRange('testEvent', latestBlock.height-10, latestBlock.height)

I don't know the internals of how the access nodes operate, but I have received a different latestBlock across multiple requests. It seems like some access nodes could potentially be behind others (I'm assuming there is a cluster of access nodes that are being load balanced). So even when you're only reading events up to the latest block height, if you happen to hit an access node that is lagging behind the one that you queried for the latest block height, then you will get no results for getEventsAtBlockHeightRange. You have no way to know if this is because the access node did not have the requested blocks yet, or if there were really no events for the requested blocks.


feature request: direct modification of spatial locations

It would be amazing if there was something akin to source.setPosition that allowed you more direct control of the speaker outputs. i.e. the ability to assign a source to come only out of the center channel or sub channel, or hard panning of left and right.

OpenAL Soft and Rapture3D have the AL_EXT_DEDICATED extension, which would allow sources to play directly on the front-center or LFE channels when they exist. It shouldn't be too hard to add support for that. Hard panning for left and right can be done by putting the source directly left or directly right of the listener (with source.setRelative(true) so it automatically stays relative to the listener).
More directly controlling the speaker outputs would be a problem since there's no saying what speakers exist, if any. Some people may only have stereo speakers, some may have quad, others 5.1 or 7.1 (in the future there could also be 8-channel cube, or <IP_ADDRESS>). With B-Format or HRTF output, there aren't even speakers to really think about, as sounds can be panned and mixed in arbitrary 3D space using speaker-agnostic or filtered output. This can also change over the course of the app lifetime.

Ahhh. That makes sense, though even just the ability to route to the center or sub would be a huge boon to the project I'm developing. I suppose this is a feature/notabug situation since that speaker configuration portability is what drew me to use Alure over other libraries in the first place. In that case, how difficult would it be to create a Device function that queries the number of available outputs for a given Device?

On further tinkering, I can't get sound to come out of Center or Sub at all regardless of where I position it. (It took longer than I'd like to admit to realize the Z-axis in setPosition = front / back). Is there a combination of positions / orientations that place sound in the Center of a 5.1 system? Or is presently the only way to access those channels through dealing directly with OpenAL Soft?

If it needs to be on the front-center speaker specifically, it needs to be done through the ALC_EXT_DEDICATED extension, which unfortunately Alure doesn't currently deal with, but I can look at adding when I get time to. As a workaround, you can simply set source.setRelative(true); and source.setPosition(0.0f, 0.0f, -1.0f); to pan it to the front-center position. This panning is what that extension would do anyway if a front-center speaker isn't available.


error

I tried to run python ’bts_test.py arguments_test_nyu.txt‘, but returned 'No module named 'bts_nyu_v2_pytorch_att''

Sorry for reply late. I think you need to carefully check  model name in training set and test set.

This is the path of my training set: "TransDepth-main/pytorch/dataset/nyu_depth_v2/official_splits/test/" ,I tried "nyu_depth_v2",but failed.Return "No module named 'nyu_depth_v2'"

check model name in these kind of setting files.