ITV Hub .ttml subs fail to convert to .srt

[x] I've verified and I assure that I'm running youtube-dl 2017.09.11
[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

Standalone youtube-dl.exe v2017.09.11 on Windows Vista SP2 32bit, fully patched.
Command issued:
youtube-dl -f worst "https://www.itv.com/hub/royal-stories/2a4353a0004" -o "The People's Princess[2a4353a0004].mp4" --write-sub --convert-subs=srt --add-metadata -v > ITVHub_VLog.txt 2>&1

Verbose log is quite lengthy, instead of being inserted in the body of this issue, it's been attached:
ITVHub_VLog.txt
FWIW, the failure part reads:
[ffmpeg] Converting subtitles
WARNING: You have requested to convert dfxp (TTML) subtitles into another format, which results in style information loss
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\__init__.py", line 465, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\__init__.py", line 455, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\YoutubeDL.py", line 1966, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\YoutubeDL.py", line 787, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\YoutubeDL.py", line 841, in process_ie_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\YoutubeDL.py", line 1601, in process_video_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\YoutubeDL.py", line 1947, in process_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\YoutubeDL.py", line 2012, in post_process
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\postprocessor\ffmpeg.py", line 589, in run
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\utils.py", line 2677, in dfxp2srt
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp24lzs8ny\build\youtube_dl\compat.py", line 2510, in compat_etree_fromstring
  File "C:\Python\Python34\lib\xml\etree\ElementTree.py", line 1335, in XML
xml.etree.ElementTree.ParseError: encoding specified in XML declaration is incorrect: line 1, column 30

Hopefully this is something that can be fixed...
Many thanks for your ongoing efforts :+1:

#12909 should fix this problem.

@yan12125 & @remitamine
Unfortunately, latest release 2017.09.15 has not fixed this original issue :cry: , though now a different error is printed; youtube-dl command used:
youtube-dl -f worst "https://www.itv.com/hub/royal-stories/2a4353a0004" -o "The People's Princess[2a4353a0004].mp4" --write-sub --convert-subs=srt --add-metadata

Command prompt window excerpt:
[ffmpeg] Converting subtitles
WARNING: You have requested to convert dfxp (TTML) subtitles into another format
, which results in style information loss
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\__init__.py", line 465, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\__init__.py", line 455, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\YoutubeDL.py", line 1967, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\YoutubeDL.py", line 787, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\YoutubeDL.py", line 841, in process_ie_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\YoutubeDL.py", line 1601, in process_video_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\YoutubeDL.py", line 1948, in process_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\YoutubeDL.py", line 2013, in post_process
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpl1klaw4y\bu
ild\youtube_dl\postprocessor\ffmpeg.py", line 589, in run
  File "C:\Python\Python34\lib\codecs.py", line 319, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid
start byte

Please re-open this
Many thanks in anticipation...

Sorry I didn't check carefully. It should really be fixed in the next version: (3869028ffb6be6ab719e5cf1004276dfdfd1216d)
$ youtube-dl -f worst "https://www.itv.com/hub/royal-stories/2a4353a0004" -o "The People's Princess[2a4353a0004].mp4" --write-sub --convert-subs=srt
[ITV] 2a4353a0004: Downloading webpage
[ITV] 2a4353a0004: Downloading XML
[info] Writing video subtitles to: The People's Princess[2a4353a0004].en.ttml
[download] Destination: The People's Princess[2a4353a0004].mp4
[download]  99.9% of ~84.89MiB at  1.17MiB/s ETA 00:00
[rtmpdump] 88923610 bytes
[download] 100% of 84.80MiB
[ffmpeg] Converting subtitles
WARNING: You have requested to convert dfxp (TTML) subtitles into another format, which results in style information loss
Deleting original file The People's Princess[2a4353a0004].en.ttml (pass -k to keep)

@yan12125 wrote:

Sorry I didn't check carefully. It should really be fixed in the next version

Hi :smile: I hope you're well !
No need to apologise; as ever, your constant efforts and user support is greatly appreciated (this goes to the whole team BTW :+1: )
So, after a wait of several days, next (latest) version 2017.09.24 was released and I was eager to try it out:
youtube-dl -f worst "https://www.itv.com/hub/the-jonathan-ross-show/2a1166a0135" --write-sub --convert-subs=srt -k

As expected, now the subs conversion from .ttml to .srt completes successfully; for the record, out of the major software players on the Windows platform, only VLC appears to have native support for the .ttml (dfxp) subs format; but I usually use MPC-BE / MPC-HC / PotPlayer, which all require the conversion to .srt, hence the original issue that was filed...
Trying the generated .srt file with MPC-BE, I almost immediately saw there must be a flaw somewhere in the conversion from .ttml -> .srt, which is demonstrated as the following issue:

When a sub contains two (or more) lines and the font colour is white, everything looks OK:

However, in every two-line subtitle where font colour !=white (even with different colours between lines), the font size in the second line is noticeably bigger that the first one:

Unfortunately, I know nothing about Python, this is not something I can fix myself and submit a PR, so again it should be investigated and hopefully remedied by a dev...
A personal comment/suggestion:
I see that the .ttml subs is the first item to be downloaded by youtube-dl, folowed by the video itself,
the subs conversion is the last step; maybe consider putting the subs conversion right after fetching the .ttml file (this would avoid waiting for the video download to complete before grabbing the .srt file)?
In a related matter, ITV Hub usually first publish a fresh video without the accompanying subs, these may (or in rare cases may not) be added at a later stage; AFAICS, there's not a --subs-only switch in youtube-dl so as to fetch only the subs once they become available; reading the docs it would appear
 --skip-download --write-sub --convert-subs=srt -k
should be able to achieve the same thing, but, sadly, I am left with only the .ttml subs (because subs conversion follows after video fetch... :disappointed: ).
For your convenience and further testing, I am attaching here both .ttml+.srt subs produced by latest youtube-dl: ITV_Subs_bug.zip
And I'm not sure if it's at all helpful, but here's a link how get-flash-videos handles the subs conversion in Perl...
A million thanks for this excellent tool, along with your consideration for disabled people (my sister is hard of hearing, so relies on .srt subs...).

I am left with only the .ttml subs (because subs conversion follows after video fetch... 😞 ).

Yep that's another bug (caused by me!). Please follow #9073 for updates.
For the issue of larger texts, could you try the SRT on more players? At the first glance, the transformed srt for this video seems correct.

Neither VLC nor mpv have such problem. Most likely MPC does not support nested tags properly.

... Thank you both for your input/suggestions.
yan12125 wrote:

For the issue of larger texts, could you try the SRT on more players?

Well, being on a Sunday I had some more free time to check, and:
MPC-HC (stable release and latest beta) exhibits the same behaviour as described in https://github.com/rg3/youtube-dl/issues/14191#issuecomment-331720612; in default video dimensions/maximised window/full screen, second line of coloured subtitle has larger fonts.
MPC-BE (my preferred video player), being a fork of MPC-HC, as expected has the same "issue"; let me just say for the record that I've been using MPC-HC for almost a decade (WinXP/Vista/7), for the last year or so switched to MPC-BE (on Vista/7), and it's the first time a flavour of .srt subtitles isn't rendered properly... 😕
PotPlayer is a mixed bag case; the .srt file produced by yt-dl has the "issue" I reported when viewing the video in default dimensions, but the "issue" goes away in maximised window/full screen modes; even more bizarrely, this "issue" goes completely away, in all possible window modes, if I make the subtitle fonts bold (???). So, using PotPlayer with bold fonts is one solution I could change to...
dstftw wrote:

Neither VLC nor mpv have such problem.

I do have a portable installation of VLC 2.2.6 on this Vista laptop and can confirm; however, I mostly use VLC as an audio stream recorder rather than a video viewer; be that as it may, when I full-screen VLC with this certain type of .srt file produced by youtube-dl, the subtitles remain extremely small:

Again, to overcome this flaw in VLC and read subs in full-screen I have to go into its advanced options and unselect subtitle formatting (resulting in monochrome subs 👎) ...
To conclude, I do insist the ITV .srt subs produced by yt-dl have a (small) flaw; you, OTOH, state:

At first glance, the transformed srt for this video seems correct.

and

Most likely MPC does not support nested tags properly.

(blaming in essence the player...).
I'm not a coder so can't challenge your claims, in fact I'm overly grateful for this app; your coding time is probably better spent fixing other crucial yt-dl issues than this small subtitles handicap... If others are also OK with current status, I personally will further process those .srt subs with SubtitleEdit (or similar) to strip formatting and create a look of them I'm more comfortable with...
Again, many thanks!


ui: First skeleton version of new ORT run details page

This PR adds a temporary route .../runs2/ that will be used for pages and (upcoming) subpages for viewing ORT run details results. The PR touches existing implementation very minimally:

root layout has one added Tailwind class
header has an additional (temporary) breadcrumb item, to make the breadcrumb show identical information as for the current run details page

As there already are ongoing discussions about the philosophy for showing the ORT run results, the purpose of this PR is to be more of a basis for discussion, rather than a polished and finalized way to show the results. (Think of it more like a Figma skeleton of a part of the UI.)
No links in the current UI lead directly to the new page, so should the users want to see it, it can be done by replacing .../runs/... in the URL with .../runs2/....

Could the sidebar component maybe go to the -components folder instead for now? I'm currently making a generic sidebar component, although of course I could just refactor that too

Could the sidebar component maybe go to the -components folder instead for now? I'm currently making a generic sidebar component, although of course I could just refactor that too

If at all possible, could be best to reuse your component later on, so sure, I'll move mine, as it is for now specific to this route.


Some doubt about calculating R1 loss/ PL loss in styleGAN2

Hello, thank you for sharing your great work.
Do you have any idea on this part (about calculating corresponding regulation losses in styleGAN), where you left "TODO" mark in the past? I am also confused about this.
Thanks.

I have no further updates.
I conjecture it is because the real_pred is used in r1_penalty, but is not involved in the loss function.  So we need to use it in the loss.

Thank you for your reply.
Maybe you are right. When this kind of error arising, it suggested all outputs from "forward" phase should be involved in calculating loss.

If there is no other update, I will close this issue. If you have any questions, please re-open it. Thanks 😄


Fixed typo and missing link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Typo Fix and correct the missing reference link
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@yalibian Hi, Please sign CLA

Hi @yalibian ！We are grateful for your efforts in helping improve mmdetection open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have a WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤


Follower Call Page, frontend

After entering street address, follower needs to know which congressperson they are going to call, and see the script and 'more info' link
This is the core CTA page for the follower, where they see who they need to call and about what
Page that shows:

Name of congressperson
Picture
Script
More Info Link
"Call" button, which has the right number for the congressperson

This is pretty much done except for the "more info" button.


Kitchen create: Failed to complete #create action: [undefined method `[]' for nil:NilClass]

First off, my apologies if the syntax or formatting here is absolutely backwards. I am new to Github. Basically I am working with a certified Chef consultant in attempts to get our infrastructure connected to Azure. I have connected my information to Azure successfully but fail out when attempting to Kitchen Create. Workstation is Windows 7, any assistance is appreciated. The main error is:
Failed to complete #create action: [undefined method `[]' for nil:NilClass]
And the kitchen.log files point to azurerm.rb. I've copied the information here for you to review.
PS C:\chef-starter\chef-repo\cookbooks\na-iis> kitchen create
-----> Starting Kitchen (v1.4.2)
-----> Creating ...
Creating Resource Group: kitchen-default-windows2012-r2-20151006T194753
------Exception-------
Class: Kitchen::ActionFailed
Message: Failed to complete #create action: [undefined method `[]' for nil:NilClass]
Please see .kitchen/logs/kitchen.log for more details
Also try running kitchen diagnose --all for configuration
Kitchen.log file:
I, [2015-10-06T15:47:48.681628 #5996]  INFO -- Kitchen: -----> Starting Kitchen (v1.4.2)
I, [2015-10-06T15:47:53.481107 #5996]  INFO -- Kitchen: -----> Creating ...
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: ------Exception-------
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: Class: Kitchen::ActionFailed
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: Message: Failed to complete #create action: [undefined method `[]' for nil:NilClass]
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: ---Nested Exception---
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: Class: NoMethodError
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: Message: undefined method `[]' for nil:NilClass
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: ------Backtrace-------
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/kitchen-azurerm-0.2.1/lib/kitchen/driver/azurerm.rb:65:in `rescue in create'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/kitchen-azurerm-0.2.1/lib/kitchen/driver/azurerm.rb:61:in `create'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:424:in `public_send'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:424:in `block in perform_action'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:488:in `call'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:488:in `synchronize_or_call'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:453:in `block in action'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/opscode/chefdk/embedded/lib/ruby/2.1.0/benchmark.rb:279:in `measure'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:452:in `action'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:424:in `perform_action'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:352:in `create_action'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:341:in `block in transition_to'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:340:in `each'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:340:in `transition_to'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/instance.rb:127:in `create'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/command.rb:176:in `public_send'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/Users/gmate/AppData/Local/chefdk/gem/ruby/2.1.0/gems/test-kitchen-1.4.2/lib/kitchen/command.rb:176:in `block (2 levels) in run_action'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `call'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: C:/opscode/chefdk/embedded/lib/ruby/gems/2.1.0/gems/logging-1.8.2/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'
E, [2015-10-06T15:47:53.995894 #5996] ERROR -- Kitchen: ----------------------
Contents of my kitchen YML for the cookbook:

driver:
name: azurerm
driver_config:
subscription_id: "a7c8aa2c-8e9d-410a-8b84-0464b4d7e8eb"
location: "East US"
machine_size: "Standard_A3"
provisioner:
name: chef_zero
platforms:

name: windows2012-r2
driver_config:
image_urn: MicrosoftWindowsServer:WindowsServer:2012-R2-Datacenter:latest
transport:
name: winrm

suites:

name: default
run_list:

recipe[na-iis::default]
attributes:

Gems:
PS C:\chef-starter\chef-repo\cookbooks\na-iis> gem list | grep kitchen
kitchen-azure (0.1.0)
kitchen-azurerm (0.2.1)
kitchen-nodes (0.4.1)
kitchen-vagrant (0.19.0)
test-kitchen (1.4.2
Output of Chef -v:
Chef Development Kit Version: 0.8.1
chef-client version: 12.4.4
berks version: 3.3.0
kitchen version: 1.4.2
EDIT: I just rebuilt my system in a VM and got the same error on a server 2012 R2 machine. Others going through this task have an earlier version of Chef DK and were able to complete without issue it seems.

Failing at that point generally points to an issue with your credentials file. I'm updating my Windows system to check 0.8.1 of ChefDK doesn't exhibit the same behaviour.
Can you triple check your ~/.azure/credentials file - make sure it is UTF-8 encoded and the first line starts [a7c8aa2c-8e9d-410a-8b84-0464b4d7e8eb]
Which is your Subscription ID.  There should be 3 lines after that:
client_id = "<service principal object id>"
client_secret = "<service principal secret>"
tenant_id = "<azure tenant id>"

I'm going to install ChefDK 0.8.1 to make sure everything is working on my system.

It was the UTF-8 encoding. I recreated the credentials file word-for-word in another text editor and the problem did not present itself. You can close this issue. Thanks for the point in the right direction.

@glennmate Glad to hear it is working!


DRY MetricsCollector Describe and Collect

When updating the list of Collectors in MetricsCollector, it is
necessary to make sure that MetricsCollector's Describe and Collect
methods invoke the respective method for each wrapped Collector. This is
slightly tedious and error-prone.
This commit uses some reflection to abstract that part away, so that
adding a new field to MetricsCollector only requires you to do the
things specific to that field.

@yeya24 Please review

@yeya24 Please review

I actually got feedback from Ben in slack:

But for using reflect to auto-register the metrics, I am not sure if it is good for readability. It is too hacky :joy:

I'm not stuck on doing this, and it would need some more work anyway as noted inline. So if others agree with Ben, or are even ambivalent, I'll just close it out. @fahlmant @iamkirkbater thoughts?

+1 to what Ben said. I see the reflect as a bit of a hack, even though it does simplify things a bit. But it would be preferable to match best practices, which I believe @yeya24 followed during initial implementation here.

Roger that. Thanks for looking!


NullReferenceException in WindowsMixedRealityXRSDKArticulatedHand.UpdateHandData

Describe the bug
There's a NRE happening on every frame where hands are visible, leading to severely degraded performance and visual glitches when hand mesh visualization is enabled.
To reproduce
Steps to reproduce the behavior:

Create new Unity project with 3D template
Import MRTK 2.8 examples via feature tool
In MRTK config window, select "builtin unity plugins (non-openxr)"
In XR plugin management enable WMR provider for UWP build target
In WMR settings check "shared depth buffer"
Skip next step in settings, then import TMP Essentials
Open package manager, select MRTK examples package and import "Demos - HandTracking"
Open HandInteractionExamples scene
Switch build target to UWP, target SDK 19041, VS 2022, add open scenes, then build the generated C++ project
Deploy to HoloLens 2 with ARM64/Release config and run the app
Observe jankiness when using hands
Look into UnityPlayer.log, which will contain lots of:

NullReferenceException: Object reference not set to an instance of an object.
  at Microsoft.MixedReality.Toolkit.XRSDK.WindowsMixedReality.WindowsMixedRealityXRSDKArticulatedHand.UpdateHandData (UnityEngine.XR.InputDevice inputDevice) [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.XRSDK.WindowsMixedReality.WindowsMixedRealityXRSDKArticulatedHand.UpdateController (UnityEngine.XR.InputDevice inputDevice) [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.XRSDK.Input.XRSDKDeviceManager.Update () [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.XRSDK.WindowsMixedReality.WindowsMixedRealityDeviceManager.Update () [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.BaseDataProviderAccessCoreSystem.Update () [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.MixedRealityToolkit+<>c.<UpdateAllServices>b__72_0 (Microsoft.MixedReality.Toolkit.IMixedRealityService service) [0x00000] in <00000000000000000000000000000000>:0
  at System.Action`1[T].Invoke (T obj) [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.ExecuteOnAllServicesInOrder (System.Action`1[T] execute) [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.UpdateAllServices () [0x00000] in <00000000000000000000000000000000>:0
  at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.Update () [0x00000] in <00000000000000000000000000000000>:0

The line at fault is here. The unityJointPoses array in WindowsMixedRealityXRSDKArticulatedHand is initialized to null and stays like that forever since it's private readonly and I assume nobody else writes to it via unusual means (i.e. reflection). In 2.7 this used to be a dictionary that was properly initialized.
Expected behavior
Hands work properly and without performance problems and exceptions being thrown.
Your setup

Unity 2020.3.31f1
MRTK 2.8
WMR Plugin 4.6.3

Target platform

HoloLens 2

Thanks for the report! A fix for this has been merged via #10622 and we'll be releasing it soon in a 2.8.1 release.

Thanks for the response; I'll be waiting for the next release then.

@keveleigh I updated my project to MRTK 2.8.1 using the MRTK Feature tool but the file from Packages\MixedReality\com.microsoft.mixedreality.toolkit.foundation-2.8.1.tgz isn't at the state from the 2.8.1 branch. This is what the file should be like, note the added nullcheck in the marked lines: https://github.com/microsoft/MixedRealityToolkit-Unity/blob/main/Assets/MRTK/Providers/WindowsMixedReality/XRSDK/Controllers/WindowsMixedRealityXRSDKArticulatedHand.cs#L139-L142
Inside Packages\MixedReality\com.microsoft.mixedreality.toolkit.foundation-2.8.1.tgz there's this file instead:
WindowsMixedRealityXRSDKArticulatedHand.cs.txt
It's missing the added nullcheck (which causes an NRE spam in my project). Was this PR  ultimately not included in the 2.8.1 release?

Can confirm; looks like a publishing issue, maybe whoever pushed this to MR Feature Tool used the wrong branch?

Thanks for the reports! I'll investigate

@Holo-Krzysztof @Schroedingers-Cat Apologies for the noise here, but I've just published 2.8.2 which contains the fixes intended for 2.8.1. Please let me know if those still don't work for you!


Not supported 10.0.22598.1

Not supported 10.0.22598.1
pls help

https://github.com/sebaxakerhtc/rdpwrap.ini/commit/ba99647a97cf57f819b56a421a459e7efaaa3673


jwt.sign(...) doesn't rename audience, issuer to aud, iss, as jwt.verify expects.

Is explained in the readme, you can either do:
jwt.sign({aud: 'axyz'}, secret);

or
jwt.sign({}, secret, { audience: 'xyz' });

both will generate a JWT with an aud claim.


Fix clippy warnings

also error on warnings in CI

Thanks for this! I didn't know about the --all-targets flag, so didn't realise that the tests weren't being linted this whole time.


Remove info and checkmark buttons from suggestion displayed at top of AI camera

The AI camera suggestion should not be tappable or have visible buttons, helping users avoid confusion about how to capture their observation and get a more robust set of identification suggestions.

@kvangork Are you referring to the above section in AI Camera

@israr002 thanks for clarifying! That is the section I was referring to, which I believe is an instance of TaxonResult. The goal is to remove the chance for users to interact with the component and then be confused about why they don't have a photo recorded.
There's probably a minimal and sufficient change to achieve that goal using the existing showCheckmark and hideInfoButton properties on TaxonResult and not pursuing the larger modification of removing or disabling the Pressable that wraps the entire component. I'll edit the issue accordingly.

The checkmark button should take a photo when pressed and accept the currently shown taxon as ID.
If it does not do that it is a bug.


Sysbox unable to build in GCP's ubuntu VMs due to missing libseccomp.h

I'm able to consistently reproduce this one in GCP's Ubuntu-Bionic and Ubuntu-Focal VMs:
$ make sysbox
...
** Building sysbox **

docker run --privileged --rm --hostname sysbox-build --name sysbox-build -v /home/rodny/wsp/11-17-2020/sysbox:/root/nestybox/sysbox -v /pkg/mod:/go/pkg/mod -v /lib/modules/5.4.0-1021-gcp:/lib/modules/5.4.0-1021-gcp:ro -v /usr/include/linux/seccomp.h:/usr/include/linux/seccomp.h:ro -v /usr/src/linux-headers-5.4.0-1021-gcp:/usr/src/linux-headers-5.4.0-1021-gcp:ro -v /usr/src/linux-gcp-5.4-headers-5.4.0-1021:/usr/src/linux-gcp-5.4-headers-5.4.0-1021:ro sysbox-test /bin/bash -c "buildContainerInit sysbox-local"
docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:58: mounting \\\"/usr/include/linux/seccomp.h\\\" to rootfs \\\"/var/lib/docker/overlay2/2f75d4b5e4395f0b4d3c4ad7b48867464892568de36c30112abf4287976ae8d6/merged\\\" at \\\"/var/lib/docker/overlay2/2f75d4b5e4395f0b4d3c4ad7b48867464892568de36c30112abf4287976ae8d6/merged/usr/include/linux/seccomp.h\\\" caused \\\"not a directory\\\"\"": unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type.
Makefile:127: recipe for target 'sysbox' failed
make: *** [sysbox] Error 125

There seems to be two separated issues to fix here:

Installer should add libseccomp-dev as a package dependency as only then we can guarantee that /usr/include/libseccom.h will be present. This may not be the proper header to utilize as we may need the seccomp.h that comes with the current kernel-headers.

There seems to be a misalignment in regards to the Sysbox's expected libseccomp.h path (i.e. /usr/include/linux/libseccomp.h) and the one where Ubuntu install this header (i.e. /usr/include/libseccomp.h).

See this for more context.

Installer should add libseccomp-dev as a package dependency as only then we can guarantee that /usr/include/libseccom.h will be present. This may not be the proper header to utilize as we may need the seccomp.h that comes with the current kernel-headers.

We are looking for the libc linux headers, so the package we want is linux-libc-dev on ubuntu.

There seems to be a misalignment in regards to the Sysbox's expected libseccomp.h path (i.e. /usr/include/linux/libseccomp.h) and the one where Ubuntu install this header (i.e. /usr/include/libseccomp.h).

The libc linux headers are installed at /usr/include/linux.

Problem was fixed via PR #137. Refer to the description of that PR for the problem cause and fix.
Closing!


Improved documentation for CONTRIBUTING.md

Adds some details to give people an idea what's involved in adding new features/services

Coverage decreased (-0.0009%) to 94.263% when pulling 7db51a3bcf1a8cc6b7e39499a3e32eeed4460fc3 on bblommers-patch-contributing into 73813460b66119dd2491f286a01bf07e0b18d193 on master.

Changes already incorporated in another PR - closing


Set timezone for cal entry

Fixes #61 by setting atc_timezone, which is required for the calendar widget.

Merging since this is currently broken on the site.


Homework 1 and 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Creating a logical for Homework 1 and SQL queries for Homework 2
What did you learn from the changes you have made?
to create logical models and to code queries
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
not for the moment but with more practice I think will be able
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
with some syntax on the queries but looking on google and trial error I managed to fix them
How were these changes tested?
for the queries, checking that they work and that the generated results where in fact those that the homework required
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

Hi Amanda; is the Homework 1.drawio  file, sorry I saved it directly from the website since it had an option here is a screenshot


Add CTRL+Z/Y on POI move

Is it possible to add the ability to undo or redo a move of a POI ?

Thank you for your suggestion, I have re-implemented the website from scratch and added that to the future version.
You can check it out here: https://gpx.studio/gpx.studio/ and provide feedback on this new repository: https://github.com/gpxstudio/gpx.studio.


unable to run Superset 3.0.0rc1 on Debian

Hi, I'm trying to run Superset 3.0.0rc1 on debian, but it's impossibile because of an error of missing method in sqlparse.Lexer.
It seems requiring sqlparse 0.4.5, that is still not available.
root@covezio:~# pip index versions sqlparse
WARNING: pip index is currently an experimental command. It may be removed/changed in a future release without prior warning.
sqlparse (0.4.4)
Available versions: 0.4.4, 0.4.3, 0.4.2, 0.4.1, 0.4.0, 0.3.1, 0.3.0, 0.2.4, 0.2.3, 0.2.2, 0.2.1, 0.2.0, 0.1.19, 0.1.18, 0.1.17, 0.1.16, 0.1.15, 0.1.14, 0.1.13, 0.1.12, 0.1.11, 0.1.10, 0.1.9, 0.1.8, 0.1.7, 0.1.6, 0.1.5, 0.1.4, 0.1.3, 0.1.2, 0.1.1, 0.1.0

You gotta downgrade to sqlparse 0.4.3.
pip uninstall sqlparse
pip install sqlparse==0.4.3

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
apache-superset 3.0.0 requires sqlparse<0.5,>=0.4.4, but you have sqlparse 0.4.3 which is incompatible.

Hi @sebastianliebscher! Can we fix the problem?

I registered this issue in the 3.0.0rc1 discussion for tracking.

I'm also facing a similar issue on centos linux 7. after resolving all the dependency conflicts, i'm not able to build the docker image with a custom docker file, getting the error that ascii codec failed to decode byte at 0xef in position 0. This comes right after it was attempting to install pyhton-geohash.

@amulya-mishra Could you open an issue about this and provide more details about the error?

when i build the image using the dockerfile provided int the repo itself, it completed successfully but when i try to login from UI, it keeps redirecting me to the login page and no error is getting logged at the backend. After inspection from chrome, i saw that some scripts are getting blocked.

This was reported here and it's related to CSP.

for the CSP  issue, setting TALISMAN_ENABLED=False resolved the issue for me and i  was able to login.
for the custom docker image issue i'm facing, will create an issue with appropriate details.
thanks

@zufolo441 Do you have the problem on current master branch?
Can you try to run git clone and pip install -e . ?

I tried.
I had to upgrade nodejs to v19 and add row
"source-map": "^0.8.0-beta.0",
to superset-frontend/package.json in order to be able to compile it.
...but it still doesn't work:
Traceback (most recent call last):
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker
worker.init_process()
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/workers/ggevent.py", line 146, in init_process
super().init_process()
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/workers/base.py", line 134, in init_process
self.load_wsgi()
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
self.wsgi = self.app.wsgi()
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/app/base.py", line 67, in wsgi
self.callable = self.load()
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
return self.load_wsgiapp()
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
return util.import_app(self.app_uri)
File "/home/superset/python3.9/lib/python3.9/site-packages/gunicorn/util.py", line 359, in import_app
mod = importlib.import_module(module)
File "/home/superset/python3.9/lib/python3.9/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 972, in _find_and_load_unlocked
File "", line 228, in _call_with_frames_removed
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 850, in exec_module
File "", line 228, in _call_with_frames_removed
File "/home/superset/sstest/superset/init.py", line 21, in
from superset.app import create_app
File "/home/superset/sstest/superset/app.py", line 23, in
from superset.initialization import SupersetAppInitializer
File "/home/superset/sstest/superset/initialization/init.py", line 33, in
from superset.extensions import (
File "/home/superset/sstest/superset/extensions/init.py", line 32, in
from superset.utils.async_query_manager import AsyncQueryManager
File "/home/superset/sstest/superset/utils/async_query_manager.py", line 26, in
from superset.utils.core import get_user_id
File "/home/superset/sstest/superset/utils/core.py", line 90, in
from superset.sql_parse import sanitize_clause
File "/home/superset/sstest/superset/sql_parse.py", line 68, in
lex = Lexer.get_default_instance()
AttributeError: type object 'Lexer' has no attribute 'get_default_instance'

@zufolo441 I see you use AsyncQueryManager in your Traceback.
Have you enabled GLOBAL_ASYNC_QUERIES?
Can you reproduce the issue without the Async Queries?

@zufolo441 @michael-s-molina Anyway if you see our docker image we use python:3.9-slim-bookworm. It's Debian distribution. We use the image in our CI and there's no such issue.
@zufolo441 Can you reproduce the issue using our docker image?

Hi, thanks for support.
here it is my config regarding async queries:
Global async query config options.
Requires GLOBAL_ASYNC_QUERIES feature flag to be enabled.
GLOBAL_ASYNC_QUERIES_REDIS_CONFIG = {
"port": 6379,
"host": "<IP_ADDRESS>",
"password": "",
"db": 0,
"ssl": False,
}
GLOBAL_ASYNC_QUERIES_REDIS_STREAM_PREFIX = "async-events-"
GLOBAL_ASYNC_QUERIES_REDIS_STREAM_LIMIT = 1000
GLOBAL_ASYNC_QUERIES_REDIS_STREAM_LIMIT_FIREHOSE = 1000000
GLOBAL_ASYNC_QUERIES_JWT_COOKIE_NAME = "async-token"
GLOBAL_ASYNC_QUERIES_JWT_COOKIE_SECURE = False
GLOBAL_ASYNC_QUERIES_JWT_COOKIE_DOMAIN = None
GLOBAL_ASYNC_QUERIES_JWT_SECRET = "test-secret-change-me"
GLOBAL_ASYNC_QUERIES_TRANSPORT = "polling"
GLOBAL_ASYNC_QUERIES_POLLING_DELAY = int(
timedelta(milliseconds=500).total_seconds() * 1000
)
GLOBAL_ASYNC_QUERIES_WEBSOCKET_URL = "ws://<IP_ADDRESS>:8080/"
DEFAULT_FEATURE_FLAGS: Dict[str, bool] = {
...
"GLOBAL_ASYNC_QUERIES": False,
...
}

@EugeneTorap , I'm sorry, I don't have Docker on that server....

Hi @zufolo441,

It seems requiring sqlparse 0.4.5, that is still not available.

Superset requires minimum sqlparse 0.4.4 which should be installed by pip install -e .. Is this true for you?

if I run superset with sqlparse 0.4.4 I obtain:
AttributeError: type object 'Lexer' has no attribute 'get_default_instance'

This error is only valid for sqlparse versions prior to 0.4.4 as get_default_instance was introduced with 0.4.4. Are you sure you have sqlparse 0.4.4 installed? Please check with pip list | grep sqlparse and make sure you have the correct virtualenvironment activated. I assume you installed Superset from scratch?
Can you provide your exact steps to reproduce this issue?

@sebastianliebscher ,thanks for the answer.
I keep updated Superset periodically with
git clone https://github.com/apache/incubator-superset/
etc.
the result is:
root@covezio:/home/superset/sstest# source venv/bin/activate
(venv) root@covezio:/home/superset/sstest# pip list | grep sqlparse
sqlparse                      0.4.4

As your error message only applies to sqlparse 0.4.3 and below, I think your installation is causing this issue. Do you have an account in Superset Slack community?

As your error message only applies to sqlparse 0.4.3 and below, I think your installation is causing this issue. Do you have an account in Superset Slack community?

you were right. after update sqlparse it's working. thanks!!

Thank you all for the help!


fix clobbering of op CLI config

closes #12

Does the env=ANY, call need to come out now that you removed it?
(sorry, approved because I thought only coverage was failing)

@joshuadavidthomas looks like that fixed it.


fontawesome icons in slide list titles?

Would it be possible to include fontawesome and other icons in slide list titles? Currently, they are being ignored. I believe this is because they are introduced as  tags without any text. So, they get rendered on the slide, but not in the menu.

        <link href="libs/revealjs/dist/reveal.css" rel="stylesheet" >
        <link href="libs/fontawesome6-0.1.0/all.css" rel="stylesheet">
        <link href="libs/revealjs/plugin/reveal-menu/menu.css" rel="stylesheet">

Slide 1

Slide 2

Output:

I'm coming from Quarto and R, so I'm not that familiar with JS (sorry). Here's an issue I raised on the Quarto side: #3950

doesn't look like this is supported anymore...


Build only Netbird CLI path

As a new Netbird UI client was introduced we shouldn't build the whole directory recursively.
The UI client has some unnecessary dependencies that makes the build fail
fixes #1

You can see the workflow execution here:
https://github.com/netbirdio/openwrt-netbird/actions

Thanks!


igate not reconnecting to Wi-Fi after wake from sleep

My remote iGate running main branch build 20th November, does not reconnect to WiFi after waking from sleep but wakes into Digipeater backup mode.
I had the same problem a couple of weeks ago, I thought the problem may have been that my 4G router had timed out with no connection. However when I visited the site I noticed my phone automaticly connected to the 4G router so no issue there.
I updated to the latest build in the main branch as of 20th November hoping this may fix the issue but the problem still exists.
I have the igate set to reboot every 24 hours, but it reboots different some how after waking, it does not transmit the the Beacon comment with GitHub link that you normally get on a restart. It as though it inst actually restarting.
Also the 30 minute beacon becomes 31 or 32 minutes, see attached image
Thanks
Paul
MW0PDV

hi, I got confused:
there a lot of things going on here.
how far from Wifi is the igate board?
is it now rebooting at the exact time ? (how big is the error in seconds)?
sending each 30 min , how big is the tx offset?

Hi Ricardo,
The igate (Heltec v3) is about 2m from the 4G router, this a remote iGate.
I should have mentioned that I have Backup Digipeater enabled.
Due to the very short daylight hours in the UK currently, the board enters sleep not long after sunset and so it isn’t currently reaching 24hours for a timed reboot. The wake time is obviously variable depending on sunlight for solar.
The beacon time is set to 30 minutes but the beacon in Digipeater backup is actually  31 minutes and  1 second or 1,861 seconds.
When it was doing this a couple of weeks ago I visited the remote site and a power cycle of the igate seemed to fix it, until the next time it entered sleep.
hope that helps
Paul.

so the backup digimode sends all packets with 31:01 min:sec delay from last packet or just the first one?

so the backup digimode sends all packets with 31:01 min:sec delay from last packet or just the first one?
Once in backup mode every beacon is 31:01

so this is working at as a Digi, but when it receives much packets to repeat it adds the self beacon at the list of packets to Tx.
so maybe this delay is a good amount of packets being repeated before the Station GPS beacon Tx ?

It is a very remote igate, the only traffic it normally will see is someone on a nearby SOTA summit. I added the 4G router as it cannot reliably reach my home, or another local igate.
Should the igate reboot when waking from sleep? It’s as though when it wakes from sleep it doesn’t  exit backup mode.

when it exit SleepMode is only when voltage is high enough. So maybe the delay added is because it needs to re-connect to the 4G Router?
im trying to see/think how to test a similar process here

Hi Ricardo, just be to clear the main problem is that it will not reconnect to Wi-Fi on waking, an so remains in backup mode.
I mention the beacon time in the hope this will help to diagnose the problem.

now I get the scenario more:
as it cant connect to wifi it will get into backup mode. (the delay is the time it tries to connect to the 4G router and fails)
so the problem is WHY IT FAILS? right?
does it reconnect to Wifi at anytime after entering into digiBackUpMode?

Hi Ricardo
No once it’s entered backup mode it does not connect to Wi-Fi
I initially assumed the 4G router had shutdown the first time this happened, but when I visited the remote site my phone immediately connected to the 4G router with good internet.

so we should check about the Wifi connection there. how many Wifi ssid are on the igate/digi station registered?
is the router for 2.4GHz wifi only?

will check for info about this problem as it should work without any issues

Thanks Ricardo
Just to maybe help diagnose the problem. When the igate wakes, there is no beacon txt with your Githhub link and build date, like you see on a restart.

Hi Ricardo, I have emulated the remote igate setup except using my home LAN and everything works fine.
It is pointing to something to do with waking up the 4G router. It fails to connect to the router  on  wake from sleep, but will connect on a power cycle of the board. Maybe I can add a delay or increase the Wi-Fi reconnect attempts?
Thanks
Paul

Once I added a delay to start again after boot but this must be flashed from vscode to test

Hi Ricardo, thanks, I am using OTA updates so will create a new bin file in VS code and give it a try.
It will be few days before I can get to the site to try it.
Thanks
Paul.

Hi Ricardo I will close this issue. The issue seems to be the router. Looking at the code I can see the 1:01 delay is 2 attempts at of 30 seconds trying to reconnect Wi-Fi before dropping back to Digi backup. I also realised that it worked when I cycled the power as my phone had already woke the router. Still not sure why my phone wakes the router but esp32 doesn’t. I will try a different router.
Thanks
Paul.

Hi Ricardo I will close this issue. The issue seems to be the router. Looking at the code I can see the 1:01 delay is 2 attempts at of 30 seconds trying to reconnect Wi-Fi before dropping back to Digi backup. I also realised that it worked when I cycled the power as my phone had already woke the router. Still not sure why my phone wakes the router but esp32 doesn’t. I will try a different router. Thanks Paul.

would love to see a way to validate that esp32 wakes up router too
lets hope we find a way.


Build scripts incorrectly assume all repos have a 'build.sh'

In following the build steps described in dev/README.md, I ran into a problem where build-all.sh was trying to run build.sh scripts that didn't exist. Here's what I think is going on:

build-all.sh is sourcing env-var-repos.sh, and this sets the CYBER_DOJO_REPOS to a list of repos.
For every repo in CYBER_DOJO_REPOS, build-all.sh cd's to that directory and tries to run build.sh..
However, some of those directories (e.g. starter) don't contain a build.sh, and this causes the script to terminate prematurely.

I see at least two possible approaches to fixing this. First, we could modify env-var-repos.sh to only include repos containing build.sh in CYBER_DOJO_REPOS. Or, we could update build-all.sh so that it checks for each potential build.sh before running it.
This second change is very straightforward, and it seems a bit more future-proof insofar as it will automatically pick up new build scripts as they become available.

Ach yes. This is exactly what happens when you don't have a daily Travis build build to check things.
I think that all repos needs to have a build.sh script.
After all, build-all is supposed to build all of them!

I've fixed this and added a .travis.yml script to check the git-clone-all.sh and build-all.sh script run to completion without error.


nDVP Volume creation delay handling

Hi,
As discussed with the team on slack today, the following issue:
tl;dr: Create a post-creation check to verify if a volume exists before starting the container who uses it.
We have a single test filer for running PoCs. We run NetApp ONTAP 9, Docker 1.13 & The latest nDVP plugin.  When we perform a "Docker volume create" towards the netapp storage driver, the volume is not directly available on the filer, possibly because of a configured advertisement delay on our configuration.
[root@vm~]# docker volume create -d netapp --name=netappslack2
netappslack2
netapp:latest       netappslack2
showmount gives /netappdvp_netappslack2              (everyone)
[root@vm~]# mount .99:/netappdvp_netappslack2 test
mount.nfs: mounting .99:/netappdvp_netappslack2 failed, reason given by server: No such file or directory
Yet, containers expect the volume to be there for writing data. Now, the container starts and exits directly using status 32, saying the "file or directory is not available".
Waiting a few minutes, around 4, we perform the docker run again using the created volume. Then, it works fine and mounts the volume.
[root@VM~]# docker run --rm -it -v netappslack2:/take2 alpine ash
/ #

I would be curious to see the entries made to the nDVP log and the internal mgt log of the cluster to check and compare timings.
For the nDVP logs check here how to get them.
For the cluster logs check here  on how to get them.  The specific logfile to look at is /mroot/etc/log/mlog/mgwd.log on the node that owns the aggregate.
Once you have access to both logs then (1) create a volume and then (2) check both logs and reply to this issue with the details.
In my lab I did the above steps and from the cluster logs the vol create took only 1 second from entries with Calling doCreate to doCreate complete so I am curious what is reported on your cluster.  I have seen connect failures when using iSCSI storage on the 1st connect.  In my research I learned that on the 1st connect the device will be formatted, and for a very large device, or with a low max QoS IOP throttle, the formatting takes longer than Docker is willing to wait.  With NFS however you don't have this format phase so your connect issue must be different.
I hope with the logs we can see what is going on.  Thanks!

At the moment of mounting, this was the logging @ nDVP.log:
INFO[2017-06-12T13:27:01Z] Starting NetApp Docker Volume Plugin.         port= storageDriverName=ontap-nas volumeDriver=netapp volumePath="/var/lib/docker-volumes/netapp"
INFO[2017-06-12T13:35:40Z] Initialized logging.                          logFileLocation="/var/log/netappdvp/netapp.log" logLevel=info
INFO[2017-06-12T13:35:41Z] Initialized Ontap NAS storage driver.         driverVersion=17.04.0 extendedDriverVersion=native
INFO[2017-06-12T13:35:41Z] Starting NetApp Docker Volume Plugin.         port= storageDriverName=ontap-nas volumeDriver=netapp volumePath="/var/lib/docker-volumes/netapp"
ERRO[2017-06-12T13:36:50Z] Problem mounting volume: netappdvp_netapptest mountpoint: /var/lib/docker-volumes/netapp/netappdvp_netapptest error: exit status 32'

Ill come back to you with the storage logging.

@dutchiechris uploaded to NetApp FTP, Scott Stanton will move it if i am correct.

As we discussed on Slack, this appears to be caused by the use of load-sharing mirrors, which means that new volumes appear in the namespace based on a snapshot schedule. This will only be an issue with the 'ontap-nas' driver.
There are multiple potential solutions that would get us closer to the desired behavior: the volume is ready to be mounted as soon as the create operation returns. We'll investigate.
Thanks for the report!


External installation of sources

Describe your suggested feature
There must be an external installation feature similar to the apply (Mihon , Tachiyomi , Aniyomi ) feature to install, add, and update sources
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I have updated the app to version 1.1.12.
[X] I will fill out all of the requested information in this form.

This is already supported in v2.0.0 which is in beta right now.

This is already supported in v2.0.0 which is in beta right now.

I mean installing the source application such as Tachiyomi and others as an external installation

Yes all sources in v2.0.0 are external sources (plugins), you can install/uninstall/update them.
Not like Tachiyomi, LNReader doenst require Android system to install plugin as an application.

Yes all sources in v2.0.0 are external sources (plugins), you can install/uninstall/update them. Not like Tachiyomi, LNReader doenst require Android system to install plugin as an application.

Additional verification will be great, like Tachiyomi hiomi. You have the choice of external or internal verification انا


add benchmark and graph commands

Codecov Report
Attention: 721 lines in your changes are missing coverage. Please review.

Comparison is base (7ff5fc4) 63.39% compared to head (a554e2a) 36.00%.
 Consider uploading reports for the commit 194c1a4 to get more accurate results

Files
Patch %
Lines

pkg/advent/grapher.go
0.00%
337 Missing :warning:

pkg/advent/benchmarker.go
1.13%
174 Missing :warning:

pkg/advent/downloader.go
24.21%
90 Missing and 7 partials :warning:

pkg/advent/solver.go
65.24%
54 Missing and 3 partials :warning:

pkg/krampus/krampus.go
69.84%
15 Missing and 4 partials :warning:

pkg/advent/styles.go
38.46%
16 Missing :warning:

pkg/advent/advent.go
79.41%
7 Missing :warning:

pkg/advent/tester.go
77.41%
7 Missing :warning:

pkg/advent/taskstatus_string.go
0.00%
5 Missing :warning:

pkg/advent/exercise.go
0.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #44       +/-   ##
===========================================
- Coverage   63.39%   36.00%   -27.40%
===========================================
  Files          20       22        +2
  Lines        1112     1800      +688
===========================================
- Hits          705      648       -57
- Misses        379     1124      +745
  Partials       28       28

Flag
Coverage Δ

Linux
36.00% <25.36%> (-27.40%)
:arrow_down:

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Outline item selection opens in incorrect split window

From<EMAIL_ADDRESS>on 2012-05-22T11:32:52Z
Spyder Version:  2.2.0dev
Python Version:  2.7.2
Qt Version:      4.7.4, PyQt4 (API v1) 4.8.6 on Windows
What steps will reproduce the problem?

Create a vertical split
Make sure the outline widget is open
Open file1 on left and file2 on right
Select code in the right pane (file2)
Pick a class or function from the outline (from file2) What is the expected output? What do you see instead? Jump to the selected item in the active (right) pane.   Instead, the editor opens the selection in the left pane.  It switches to the file2 tab in the left pane and jumps to the item there.

Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1039

From pierre.raybaut on 2012-05-25T12:40:06Z
This issue was closed by revision 22d3dd96d85d .
Status: Fixed

From<EMAIL_ADDRESS>on 2012-07-05T20:25:03Z
issue #1099 has been merged into this issue.
Cc<EMAIL_ADDRESS>


error: Multiple commands produce

大哥请教一下
`xcodebuild: error: You cannot specify both a scheme and -alltargets.
2018-10-29 14:06:38.593 xcodebuild[6695:113309] [MT] PluginLoading: Required plug-in compatibility UUID 8B9F56A7-4D8B-41AA-A65D-D4906CDF1539 for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ClangFormat.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2018-10-29 14:06:38.594 xcodebuild[6695:113309] [MT] PluginLoading: Required plug-in compatibility UUID 8B9F56A7-4D8B-41AA-A65D-D4906CDF1539 for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/Alcatraz.xcplugin' not present in DVTPlugInCompatibilityUUIDs
User defaults from command line:
    IDEArchivePathOverride = /Users/oswin/Downloads/auto_code/zzios_test/build/ios.xcarchive

Build settings from command line:
    CFBundleVersion = 1
    CODE_SIGN_IDENTITY = iPhone Distribution:xxxxx(已经配置)

note: Using new build system
note: Planning build
note: Constructing build description
Build system information
warning: The Copy Bundle Resources build phase contains this target's Info.plist file '/Users/oswin/Downloads/auto_code/zzios_test/ios/Info.plist'. (in target 'ios')

Build system information
warning: duplicate output file '/Users/oswin/Library/Developer/Xcode/DerivedData/ios-afezxkudgwcbseamdzpppfeesusv/Build/Intermediates.noindex/ArchiveIntermediates/ios/InstallationBuildProductsLocation/Applications/ios.app/Info.plist' on task: ProcessInfoPlistFile /Users/oswin/Library/Developer/Xcode/DerivedData/ios-afezxkudgwcbseamdzpppfeesusv/Build/Intermediates.noindex/ArchiveIntermediates/ios/InstallationBuildProductsLocation/Applications/ios.app/Info.plist /Users/oswin/Downloads/auto_code/zzios_test/ios/Info.plist (in target 'ios')

Build system information
error: Multiple commands produce '/Users/oswin/Library/Developer/Xcode/DerivedData/ios-afezxkudgwcbseamdzpppfeesusv/Build/Intermediates.noindex/ArchiveIntermediates/ios/InstallationBuildProductsLocation/Applications/ios.app/Info.plist':
1) Target 'ios' (project 'ios') has copy command from '/Users/oswin/Downloads/auto_code/zzios_test/ios/Info.plist' to '/Users/oswin/Library/Developer/Xcode/DerivedData/ios-afezxkudgwcbseamdzpppfeesusv/Build/Intermediates.noindex/ArchiveIntermediates/ios/InstallationBuildProductsLocation/Applications/ios.app/Info.plist'
2) Target 'ios' (project 'ios') has process command with output '/Users/oswin/Library/Developer/Xcode/DerivedData/ios-afezxkudgwcbseamdzpppfeesusv/Build/Intermediates.noindex/ArchiveIntermediates/ios/InstallationBuildProductsLocation/Applications/ios.app/Info.plist'

** ARCHIVE FAILED **`

xcode10的问题修改参考
https://www.jianshu.com/p/40ed7f20f476


Entering Debug Mode

https://github.com/riscv/riscv-trace-spec/blob/9896e28a5b35d86178c08e77e0ae6daaafeba072/ingressPort.tex#L1
What should the hart to encoder interface output when a hart enters debug mode?
There are 6 causes that a hart enters debug mode: ebreak, trigger, haltreq, step, resethaltreq, halt group.

There is a 'halted' sideband signal which should help in this


123 ssl missing functionality

[725] - https://transfer.sh/d3hZ4/jdi-dark-tests.tar.gz

[725] - Allure report on Netlify: https://5e679f40623110aa19205aa2--jdi-dark.netlify.com

[727] - https://transfer.sh/jOxV5/jdi-dark-tests.tar.gz

[727] - Allure report on Netlify: https://5e67a070781a15b780827c64--jdi-dark.netlify.com

[750] - https://transfer.sh/1fhU2/jdi-dark-tests.tar.gz

[750] - Allure report on Netlify: https://5e68baf147b2049968f5eba3--jdi-dark.netlify.com

[752] - https://transfer.sh/i9pZv/jdi-dark-tests.tar.gz

[752] - Allure report on Netlify: https://5e68bd2247b204d097f5eb4e--jdi-dark.netlify.com

[754] - https://transfer.sh/VXqvj/jdi-dark-tests.tar.gz

[754] - Allure report on Netlify: https://5e68bfc6b962abb14f8dcb3b--jdi-dark.netlify.com

[756] - https://transfer.sh/CfdgU/jdi-dark-tests.tar.gz

[758] - https://transfer.sh/49hES/jdi-dark-tests.tar.gz

[756] - Allure report on Netlify: https://5e68c9821575605297ede865--jdi-dark.netlify.com

[758] - Allure report on Netlify: https://5e68c9ebccf81bea1a4e3542--jdi-dark.netlify.com


The the d3 interpolate warm color scale.

That particular scale didn't work (bug in d3)? but plasma is somewhat lighter. Fixed in #128


remove dup (Surveycaster was renamed to Ponder)

Surveycaster channel was renamed to Ponder channel:

name change
parent_url did not change, causing a duplicate entry
image change
channel_id change

Thanks @artlu99!


[Bug]: Experiment time span

thevenin Version
0.1.0
Python Version
3.12.6
Describe the bug
When using the add_step functionality of the Experiment object, there can occur an issue with the tspan argument when the second value of the tuple is provided as a float (that is, as the delta_t between steps): the tspan calculated can exceed the maximum time allowed. I believe this comes from lines 172-174 in the thevenin/_experiment.py script.
Steps to Reproduce
The following block yields a tspan: array([0., 2., 4., 6.]), but it should not go past 5.
exp = Experiment()
exp.add_step('current_A', 0.0, tspan=(5., 2.))
exp.print_steps()

In my mind (and maybe I am interpreting this incorrectly), the ideal tspan in this case would be tspan: array([0., 2., 4., 5.]), so, sampling every 2 seconds up to 5 seconds, but including the last possible timestamp.
Relevant log output
No response

Talking to @c-randall, it seems like this is the intended behavior, and it's the user's responsibility to make sure dt divides the t_max value or to use a tstop argument, so I think this can be closed.

I decided to move forward with your original suggestion since it is likely more straight forward for users. The new behavior now forces the final time array value to always be t_max, whether you use the (t_max, Nt) or (t_max, dt) constructor. This removes the need to ever provide the optional tstop argument.
I added to the docstring for Experiment.add_step() to inform users that the final time step may not be the same as the supplied dt if t_max isn't evenly divisible by the given value.
New tests ensure this fix works consistently for all tspan constructors.


Download get's stuck again with 3.9.4

It works for a while then (many files are downloaded completely) then it freezes with many temp files and download would run forever if you not stop it. With 3.8.6 it had been working fine. If I uninstall 3.9.4 and re-install 3.8.6 script doesen't download anything it just runs through to the end (but shows no error).

Please provide a log file


Overly aggressive string munging when writing to parameters table

See _infinity_flag_write_cell

Be sure to test this with PanDatFactory as well, to make sure basic json writing doesn't pointlessly stringify the parameters.


Segmentation Fault

Required Info

Camera Model
{ D400 }

Firmware Version
(Open RealSense Viewer -->  2.20)

Operating System & Version
{Ubuntu Mate 18.04.2}

Kernel Version (Linux Only)
(4.15.0-1033-raspi2)

Platform
Raspberry Pi

SDK Version
{ 2.20 }

Language
{python}

Segment
{others }

Issue Description
I am  trying to use my Raspberry Pi 3 to work with the realsense cameras. However I am experienced several Segmentation faults using both the realsense-viewer as well as scripts in python. Sometimes I can get two cameras work at the same time without problems some other time I get segmentation fault after a while or just at start streaming. I have seen that there are other people with the same issue but no solution has been found

@filipematosinov , kernel log, as well as Librealsense's log  would definitely help here.
Note that if the issue is most often occurs some time after the streaming starts, then I would first check the USB connection, specifically tried to switch to a powered USB3 hub to negate power-related/CPU throttling issues.

Closing this issue due to lack of activity for 30+ days.


feat: integrate substrate context

interBtcApi.setAccount
changeAddressAction
setInstalledExtensionAction
const {
bridgeLoaded,
address,
extensions
} = useSelector((state: StoreType) => state.general);

Tidying up the PRs and going to close this—we might do some related work so I won't delete the branch, but this PR won't be merged as it is.


Ensure Elastic.Extensions.Logging can set auth through config

Previously this was only applied to Cloud connections

Is this currently working on current release?, documentation still says that pass and user is for Cloud only and I haven't been able to get it to work


Relabel MONDO:0008135

Mondo term (ID and Label): MONDO:0008135; optic atrophy with negative Electroretinograms
Suggested new label: OPTIC ATROPHY 13 WITH RETINAL AND FOVEAL ABNORMALITIES
Your nano-attribution (ORCID) ClinGen Glaucoma/Neuro-ocular Gene Curation Expert Panel
If you don't have an ORCID, you can sign up for one here
Optional: Any additional information (like supporting evidence, PubMed ID, etc.) This term has been updated in OMIM: https://omim.org/entry/165510

Thanks @Mohan-Shruthi! We'll fix this

Hello @Mohan-Shruthi
I'm Sabrina, a new curator who recently joined the Mondo team.
We will address your issue as soon as possible. Thank you for your patience.
If this is a high priority, please let me know and we can prioritize it. Thank you!


Time for a new release?

The latest release was over two months ago, and there's been a fair number of bug fixes and performance improvements since then. (In general, slightly shorter release cycles shouldn't hurt.)
Some potential highlights since the last release:

PR #14536, which improved rendering of thin lines.
PR #14720, which implemented printing/saving of additional form elements.
PR #14754, #14766, and #14777, which improved performance when rendering ImageMasks.
PR #14797, and #14799, which prevented certain documents from rendering with completely blank pages.
PR #14853, which removed "white lines" between image-chunks.
PR #14858, which improved performance of (most) Type3 fonts.
PR #14874, which allows the user to specify custom background/foreground colours for rendering.

Good idea; I'll hopefully have time for this in the weekend.

Closing since version 2.14.305 is now released; please see https://github.com/mozilla/pdf.js/releases/tag/v2.14.305 for more details.


[python/ci] Trigger CI on clean main

Issue and/or context: #2323
Changes:
Notes for Reviewer:

Appears to have been caused by https://github.com/scikit-build/cmake-python-distributions/issues/472#issuecomment-2020852519


feat(registry): inspect repository images

Closes #2808

Size column is missing
API doesn't return sizes so we can't display them.

Will fix the other bugs tho.

@itsconquest

I presume the below findings are due to not having the performance improvements from the other registry PR.

Exactly.


Lpc4322/rt1170 gcc

Hi @groleo, I am thinking about creating a PR to DAPLink:experimental_compilers with only some of the LPC4322 changes. It already works on GCC on this branch.
In order, I am interested:

Configuration and clock changes (though [c034a9b] seems wrong because we are running on the Cortex-M4 core).
GPIO cleanups
Updates from NXP
SWO support

The MIMXRT1170 could be a later PR.
I will probably have a several questions.

Hi,
I've left the mimxrt1170 bits out : https://github.com/ARMmbed/DAPLink/pull/813


x/telemetry/config: add gopls/*/latency histograms

Counter names
gopls/completion/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
gopls/definition/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
gopls/hover/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
gopls/implementations/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
gopls/references/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
gopls/symbol/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
Description
These counters measure server-side observed latency for various latency sensitive LSP operations. For pragmatic reasons, as well as to reduce variability, timing starts when gopls actually begins handling the request, and does not include jsonrpc2 queue time.
Bucketing is approximately exponential, though adjusted to capture meaningful boundaries. For example, the default completion budget is 100ms, and we typically think of anything faster than 200ms as OK. 500ms, 1s, and 5s are various landmarks of slowness.
More precisely, the <10ms bucket captures latency in the range [0, 10ms), and subsequent buckets save the last capture [P, V), where P is the previous bucket endpoint and V is the current bucket endpoint. The >=5 bucket captures everything else. Is there a different convention I should be following for bucket naming?.
The set of operations for this initial batch of instrumentation is chosen based on our experience, as the most critical latency-sensitive operations we support. (CC @adonovan for his opinion on this)
Rationale
The latency of these operations greatly affects the experience of using gopls. With the large variety of editing environments that gopls supports, it is impossible to adequately benchmark these operations in every scenario. Furthermore, users tend not to file issues for incremental performance regressions ("boiling the frog"), and we've seen cases where a significant regression went unnoticed by the team and largely unreported for months (for example #62665).
By capturing these latency distributions, we can form a picture of the typical user experience, identify the frequency of outliers / atypical experiences, catch performance regressions following releases, and better prioritize our performance work.
Do the counters carry sensitive user information?
No.
How?
We'll instrument timing around these operations in the relevant gopls request handlers.
Proposed Graph Config
counter: gopls/completion/latency:{<10ms,<50ms, <100ms, <200ms, <500ms, <1s, <5s, >=5s}
title: Latency of gopls completion requests
description: Server-side latency observed while handling the LSP textDocument/completion request.
type: histogram
program: golang.org/x/tools/gopls
version: v0.14.0  # the first binary version containing this counter.

New or Update
New

We're going to wait for proper histogram support before proceeding with this proposal (#68207).


Fix path traversal issue in createTemporaryNodeServer

The test-only createTemporaryNodeServer helper featured a path traversal vulnerability. This enables attackers with network access to the device to read arbitrary files while unit tests are running that activate this test server.
This patch fixes the issue by validation of paths.
To test this vulnerability before the patch:

Run the test-only server:

node -e 'console.log(require("./test/unit/test_utils.js").createTemporaryNodeServer().port)

From another terminal, send the following request (modify the port to the port reported in the previous step):

curl --path-as-is http://localhost:45755/../../package.json

Before the patch, the second step would traverse the directory, and return results from the root of the PDF.js repository, instead of files within test/pdfs/.
With the patch, the server refuses the request with HTTP status 400.

/botio unittest

Thank you for spotting and fixing this!


Powerline setup for WSL not 100% working

Powerline setup for wsl with untuntu 20.04 LTS not properly working because of non-working emoji support

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d3cbeb9a-9e7c-f8f4-5c03-5d6262d2b440
Version Independent ID: eb575c79-5b2a-45f6-646f-9d41d5d223e8
Content: Windows Terminal Powerline Setup
Content Source: TerminalDocs/tutorials/powerline-setup.md
Product: dev-environment
Technology: windows-terminal
GitHub Login: @cinnamon-msft
Microsoft Alias: cinnamon

as a workaround people can install these fonts
https://stackoverflow.com/a/68236169
and activate "DejaVu Sans Mono for Powerline"

Same, but for me it did not help actrivating the DejaVu font, here I am using Cascadia Mono PL

Closing this as we did some major updates to the command prompt customizing tutorial (replacing the powerline tutorial with Oh My Posh). You should be able to follow the steps for WSL prompt customization now without issue, but please let me know / reopen if this isn't the case: https://docs.microsoft.com/windows/terminal/tutorials/custom-prompt-setup#customize-your-wsl-prompt-with-oh-my-posh
Thanks for the contribution!


Document assetUrl variable in page template

Variable is currently used on <meta property="og:image" tag where the URL to the assets needs to be absolute.
Fixes: #424
Should go after #458

You can preview this change here:
Built with commit 5ebb3540bb0f07c08765e41184ab3e721d8303c7
https://deploy-preview-460--govuk-design-system-preview.netlify.com


[JS] Create a JS pipeline

Fix #6656. which enabled JS test
Fix #6749. It's used to catch bugs like #6746.
Because lerna workspace, webpack and npm pack, the actual package we released is a little different what we see in source/nodejs/adaptivecards*/. So even the build passed on our dev environment, we still don't have 100% confidence on our package.
This PR used npm pack to build the package we npm publish to npmjs website, and then the two apps consumes these packages.
Here is the logic.

make a copy for the two test project: adaptivecards-react-testapp and adaptivecards-ui-testapp
build the js projects as usual
run npm pack to make packages for adaptivecards, adaptivecards-controls, adaptivecards-designer, adaptivecards-templating and adaptivecards-react
install the .tgz package on the copied testapp, and rebuilt them.

Example of carousel failure(#6746) detected by this pipeline:

https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=42543322&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=35f53584-79fc-539f-463c-6471d0663a3a
Microsoft Reviewers: Open in CodeFlow

/azp run


Updates to Shovel's Utilities

ShovelUtils should have the ability to delete sprites and costumes.

Gonna add functionality for that in the next update.

Gonna add functionality for that in the next update.

do it for sounds, too

That would be interesting for cutting down on memory usage if it could also create costumes and sounds. These features might be better fit in an extension of their own, though. Maybe call it "Asset Management"?

I am already working on another extension at the moment. So unless someone else does it, this will have to wait.

Git and GitHub repositories have a branching feature, which would let you do both of these simultaneously if you feel like learning how to manage branches. (If learning branching in Git is too much right now, making changes on the website might make this easier.)

For some reason vm.deleteSound("NAME") just deletes the first sound in the list. Same with vm.deleteCostume(NAME).

For some reason vm.deleteSound("NAME") just deletes the first sound in the list. Same with vm.deleteCostume(NAME).

http://llk.github.io/scratch-vm/docs/VirtualMachine.html#deleteSound
The argument is the sound index.

How do I get the sound index. vm.runtime.ext_scratch3_sound.getSoundIndexByName has 2 values

How do I get the sound index. vm.runtime.ext_scratch3_sound.getSoundIndexByName has 2 values

The first argument is the sound's name, the second argument is a BlockUtility object (though it only needs to access util.target.sprite.sounds)

http://llk.github.io/scratch-vm/docs/VirtualMachine.html#deleteSound The argument is the sound index.

It says 404. It seems the page got deleted or something..

it was moved from LLK to scratchfoundation.
https://scratchfoundation.github.io/scratch-vm/docs/VirtualMachine.html#deleteSound

Delete costumes: #796


Fixed #27430 -- Added -b/--buffer option to DiscoverRunner.

I couldn't figure out how to make it work with parallel test execution
ticket-27430

Thanks for the review!
I've made the changes you requested (in separate commits, I'm not if you prefer that or a whole squahsed commit).
I've also rebased on the latest master to resolve the conflicts with the test you added for --pdb + --parallel.

@bmispelon Thanks :+1: I pushed minor edits and simplified tests.

Thanks! :sparkles:


Unknown Plugins Scope 'schema'

Just installed proto and trying to install Moon Repo using it.
[plugins]
moon = "schema:https://raw.githubusercontent.com/moonrepo/moon/master/proto-plugin.toml"

When then running proto install moon we see:
Error: proto::misc

  × Unknown plugin scope `schema`.

@codewith-luke schema: was renamed to source: in a recent version, try that.
Also where did you see schema: referenced? I'll update the docs.

Ah epic https://moonrepo.dev/docs/install
That is where I found it. Sorry double posted on the discord as well.


with a limited number of months, "year" view does not fill available area

For example, in the following example I've made the last 14 months available. This consists of 4 rows of months (2 for each year) that should easily fit in the available area. That being said, the first row is hidden and there is a good deal of gray space around the scrolling section.

Not sure which combination of props you used to get that result, I'm unable to replicate it myself. Happy to look into it if you can share the steps to reproduce.
You can also use the displayOptions={{showMonthsForYears: false}} in this scenario.


feat(AAE-896): Cloud Native Bpmn Messages Service with Stateful Backend

Part of https://github.com/Activiti/Activiti/issues/3028

Fixes https://issues.alfresco.com/jira/browse/AAE-896

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@bb34921). Click here to learn what that means.
The diff coverage is 69.06%.

@@            Coverage Diff             @@
##             develop       #1   +/-   ##
==========================================
  Coverage           ?   69.06%
==========================================
  Files              ?       28
  Lines              ?      514
  Branches           ?       42
==========================================
  Hits               ?      355
  Misses             ?      125
  Partials           ?       34

Impacted Files
Coverage Δ

...egator/transformer/MessagePayloadTransformers.java
0% <0%> (ø)

...es/aggregator/integration/MessageEventHeaders.java
0% <0%> (ø)

...ggregator/advice/MessageReceivedHandlerAdvice.java
100% <100%> (ø)

...ator/release/MessageGroupReleaseStrategyChain.java
100% <100%> (ø)

...ator/config/MessageConnectorAutoConfiguration.java
100% <100%> (ø)

...ices/messages/aggregator/support/ChainBuilder.java
100% <100%> (ø)

...r/processor/MessageGroupProcessorHandlerChain.java
100% <100%> (ø)

...r/config/MessageStoreEnvironmentPostProcessor.java
100% <100%> (ø)

...rocessor/AbstractMessageGroupProcessorHandler.java
100% <100%> (ø)

...nfig/MessageConnectorIntegrationConfiguration.java
100% <100%> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb34921...9365e59. Read the comment docs.

@erdemedeiros I have resolved all the comments in 78705ff36aa6ad3a2f9119edc4bb13e42f18c0a1. We can merge it if you are OK.

@igdianov, ok for merge.


Are git tags being mutated?

Hi 👋
My cargo dependencies occasionally break in various ways.  While investigating, I noticed the v1.1.3 tag got repointed to a newer commit:

Previous one: https://github.com/apache/incubator-teaclave-sgx-sdk/commit/254368badb9eb2d4cdab631a34e234bf6e54e585

Current one: https://github.com/apache/incubator-teaclave-sgx-sdk/commit/a6a172e652b4db4eaa17e4faa078fda8922abdd0

Is this intentional?  In my understanding, it's generally assumed that tags, once created, do not change.

hey @adaszko , unfortunately this is intentional for some bug fixes... the root problem is the bad "dependency resolver" built-in with cargo, which mess up many things when using git repo as dependency. cargo is now testing on the v2 resolver:
https://github.com/rust-lang/cargo/issues/8088
once it got stabilized, we'll follow up and improve our sdk versioning. sorry for the inconvenient.

Thank you for clarifying @dingelish

Thank you for clarifying @dingelish

This happened to us as well on multiple occasions. With v1.1.1, then with v1.1.2 and then with v1.1.3.
@dingelish in the future can you please release a new version rather than breaking the existing ones for everyone?

This happened to us as well on multiple occasions. With v1.1.1, then with v1.1.2 and then with v1.1.3.
@dingelish in the future can you please release a new version rather than breaking the existing ones for everyone?

The new resolver has landed in 1.51.0!


docs(installation): doc about enable Google Maps on iOS

I updated Update installation docs about Enabling Google Maps on iOS.
<MapView provider={PROVIDER_GOOGLE} ... />

It took me a few hours of debugging to discover that ios needed additional configuration.
https://github.com/react-native-maps/react-native-maps/blob/master/src/MapView.tsx#L1114
So maybe could add this

Does any other open PR do the same thing?

No
What issue is this PR fixing?
No
How did you test this PR?

Yes

This instruction is already in the README doc

This instruction is already in the README doc

Yes, But this is for Customizing the map style, I ignored it, cuz I don`t need map style.

Hi @hanzhangyu 👋
If you fix the formatting error I'll be happy merge this 👍


trigger auto-layout when auto-layout setting is toggled on

Toggling on the auto-layout setting in the sidebar should now trigger auto-layout for any overlapping pods or scopes.

Thanks, Timmy.
BTW, when your PR resolves an issue, you can link it so that the issue will be closed upon PR merging.

Got it, I'll do that in the future.


[Refactoring] Re-implement "collapse nested if" action

Narrowed isApplicable() condition to ensure that we don't emit this action when it's not safe to apply this action.
Also, Renamed CollapsedNestedExpr to CollapseNestedIfStmt because if is not expression.
rdar://problem/39516354

@swift-ci Please smoke test

@swift-ci Please smoke test


Error with floating point exception

Hi,
I am getting this error while running.
PileOMeth extract --CHG --CHH  ~/whole_genome_TAIR10/TAIR10_all.fa 32338_CTTGTA_C89J6ANXX_3_20160105B_20160105_2.modified.bam
writing to prefix:'32338_CTTGTA_C89J6ANXX_3_20160105B_20160105_2.modified'
Floating point exception
How can I fix this?

Can you try the most recent version (0.1.12)? I suspect this is related to #23, which is fixed in that release.

If that doesn't fix it, can you provide me with the BAM file? I can debug this and release a fixed version then.

Hi,
I am using the recent version
./PileOMeth --version
0.1.12-dirty (using HTSlib version 1.2.1)
Yes sure! Here is the bam file
https://drive.google.com/file/d/0B9AIw0gsTy_zNkxuUWk4aVlndW8/view?usp=sharing
Thanks!

I can't seem to reproduce this locally with 0.1.12. Can you recompile with make install OPTS="-g -O0" ... and then rerun it in gdb (gdb --args PileOMeth extract --CHG --CHH ~/whole_genome_TAIR10/TAIR10_all.fa 32338_CTTGTA_C89J6ANXX_3_20160105B_20160105_2.modified.bam)? Presumably that'll produce the same exception and you can then type bt to get a backtrace.

Recompiling didnt solve the issue!
Here is the error with gdb
gdb -args ~/Softwares/PileOMeth/newCompile/PileOMeth extract --CHG --CHH ~/whole_genome_TAIR10/TAIR10_all.fa 36841_GCCAAT_C92VAANXX_1_20160229B_20160229.modified.bam
GNU gdb (GDB) 7.5.1
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-unknown-linux-gnu".
For bug reporting instructions, please see:
http://www.gnu.org/software/gdb/bugs/...
Reading symbols from /home/GMI/rahul.pisupati/Softwares/PileOMeth/newCompile/PileOMeth...done.
(gdb) run
Starting program: ~/Softwares/PileOMeth/newCompile/PileOMeth extract --CHG --CHH /home/GMI/rahul.pisupati/whole_genome_TAIR10/TAIR10_all.fa 36841_GCCAAT_C92VAANXX_1_20160229B_20160229.modified.bam
warning: no loadable sections found in added symbol-file system-supplied DSO at 0x2aaaaaacb000
warning: Could not load shared library symbols for linux-vdso.so.1.
Do you need "set solib-search-path" or "set sysroot"?
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
writing to prefix:'36841_GCCAAT_C92VAANXX_1_20160229B_20160229.modified'
Program received signal SIGFPE, Arithmetic exception.
0x000000000040fc0a in faidx_fetch_seq (fai=0x4702a0, c_name=0x4f2390 "Chr1", p_beg_i=-1, p_end_i=-1, len=0x7fffffff2b5c) at faidx.c:455
455	    int ret = bgzf_useek(fai->bgzf, val.offset + p_beg_i / val.line_blen * val.line_len + p_beg_i % val.line_blen, SEEK_SET);
(gdb) next
Program terminated with signal SIGFPE, Arithmetic exception.
The program no longer exists.

This appears to be an issue with the fasta file. Can you post that somewhere?

This is the TAIR10 arabidopsis genome file. Anyway I have uploaded it in here
https://drive.google.com/file/d/0B9AIw0gsTy_zTW9oVS1SZjg4S0U/view?usp=sharing

I think I figured this out. I chop the header to just the chromosome name (removing the rest) and indexing it again. It gave me no error. I dont know why that is the case.
Thank you!!
Rahul

Weird stuff, don't know why that caused an issue either but glad it's working now :)


Move Phylogram(s) to separate page(s)

This seems cleaner than leaving it on the Job page, also it would allow multiple simultaneous phylograms for different gene families (see issue #11).

Added separate Phylogram page in commit fbd6556, along with fixing issue #6.


New version: AtticGreek v0.5.5

Registering package: AtticGreek
Repository: https://github.com/neelsmith/AtticGreek.jl
Created by: @neelsmith
Version: v0.5.5
Commit: 83044811c9483c5a86fb5ef67a52c81d8161984b
Git reference: main
Release notes:

Fixes a bug in accenting perispomenon.

I don't see any indication of why these builds are failing.  What am I missing?

You're missing that github actions is not working today: https://www.githubstatus.com/incidents/m16jzl31gnqt
[noblock]

Ah.  Haven't had first cup of coffee yet!
On Tue, May 18, 2021 at 7:52 AM Mosè Giordano @.***>
wrote:

You're missing that github actions is not working today:
https://www.githubstatus.com/incidents/m16jzl31gnqt
[noblock]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JuliaRegistries/General/pull/36963#issuecomment-843103536,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQ2FBRLBA5EHTY24ENSH53TOJIF7ANCNFSM45B75T6A
.


Cassandra 15861 lock trunk

@jasonstack FWIW, both of the dtests that failed here passed locally for me.

@jasonstack btw, there's a random unnecessary semicolon in SSTableReader#saveSummary()

unrelated to patch nit: GlobalTidy.NULL should be final

a slow write to SUMMARY (aka IndexSummaryRedistribution) will block updates to STATS (aka compaction) even though they do not logically conflict;

index summary redistribution and stats-mutation shouldn't happen together because both are running as part of compactions.

index summary redistribution and stats-mutation shouldn't happen together because both are running as part of compactions.

You are right, I keep forgetting org.apache.cassandra.db.lifecycle.Tracker#tryModify(java.lang.Iterable<org.apache.cassandra.io.sstable.format.SSTableReader>, org.apache.cassandra.db.compaction.OperationType) marks sstables as compacting, so compactions will avoid compacting those files
if (null == apply(permitCompacting(sstables), updateCompacting(emptySet(), sstables)))
            return null;
        return new LifecycleTransaction(this, operationType, sstables);


[feat] Add code coverage to sw-emulator

This  change implements a simple code coverage metric using a bitmap.

@mhatrevi , @ajisaxena , @korran


Broken link in supported-platforms.md

Problem description

Install Docker link is broken in supported-platforms.md and engine/index.md
Problem location

I saw a problem on the following URL:
https://github.com/docker/docker.github.io/blob/master/ee/supported-platforms.md#where-to-go-next
https://github.com/docker/docker.github.io/blob/master/engine/index.md#installation-guides

Project version(s) affected
In master branch
Suggestions for a fix
Installation directory here https://github.com/docker/docker.github.io/tree/master/engine is missing in  master, due to  which the url is redirecting to 404 page
I checked on other branches and found the installation directory is available on this branch.
Can someone confirm on this? Whether it should go to that branch or the folder is needed in master branch?

Hey, @arshadkazmi42 - can you please try accessing the site pages directly through docs.docker.com?
First link should be: https://docs.docker.com/ee/supported-platforms/#where-to-go-next
Second should be: https://docs.docker.com/engine/#installation-guides
In the case of the Markdown links you've mentioned, those point to pages which have been redirected. So they redirect properly through the site but not through Github. Please feel free to open another issue if you still see a problem.


Lagginess while scrolling through liked tracks

Describe the bug
Scrolling with arrows is laggy on liked tracks list. This doesn't happen on shorter track lists. Wondering what would be causing lagginess though?
Environment

OS: macOS 13
Application version: Latest
Application features: default

What is the size of your liked track list?

Around 8000 tracks I would say? But I don't think the size should matter in scrolling through the view? I would expect that behavior to be decoupled from the size of the playlist.

Around 8000 tracks I would say? But I don't think the size should matter in scrolling through the view? I would expect that behavior to be decoupled from the size of the playlist.

yeah, it should not. I can try to reproduce by duplicating my local data.

Super cool thanks!


Clean-up digging operation when client is disconnected

this really needs to move to the physics tick loop


Trimmed whitespace on decoding String

I had another issue with the library when decoding strings. For example if I have a string with a whitespace at the end in my XML, it will get trimmed when decoding but I don't want this behavior.
Moreover, when an element contains an empty string, it is automatically interpreted as nil.

Hi @TheFlow95, thanks for reporting this. The conversion of empty strings to nil is now fixed in #92. As for trimming the whitespaces, I think the best way forward would be to add a property on XMLDecoder like trimValueWhitespaces to turn the trimming off, while the default value would be true for backward compatibility.

This is now fixed in master and will be included in 0.5 release, which I'm going to tag soon.

trimValueWhitespaces has also been added in #92 and is now available in master.


Sequencer - Remove specific note at beat and all of a specific note

All is working fine in 4.9.4 but I haven't tested in anything later.

I think the function to remove all should be named "removeAllInstancersOf(noteNumber:) - a little longer but much more evocative of what its going to do.

Yeah good point, I've renamed those functions.


⚠ Auth has degraded performance

In 40f1a13, Auth (https://auth.k2lin.com) experienced degraded performance:

HTTP code: 200
Response time: 3282 ms

Resolved: Auth performance has improved in 1a12b5a after 16 minutes.


few fixes

Improvements:

fixes display of bool
underscore now works again
removes None printing

Nice, thanks!


create: copy container's annotations to pod

fixes #133
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

depends on https://github.com/containers/virtcontainers/pull/256 and https://github.com/containers/virtcontainers/pull/260

I think this should be done in the oci package provided by virtcontainers/pkg/oci. @sameo what do you think ?

This needs explanations, "how does it fix #133", in the commit message.

I think this should be done in the oci package provided by virtcontainers/pkg/oci

Yes, this should be part of the oci package, because this is something all runtime implementations will want.

@sameo  @sboeuf  something like this https://github.com/containers/virtcontainers/pull/261 ?

move PR to virtcontainers https://github.com/containers/virtcontainers/pull/261


bitwise op problem

ls 1.5.0
(1 - 1) .&. 1
is compiled to
1 - 1 & 1

grouping () has the highest precedence 19.


First version of the gem

Adding the first version of the gem that I spoke about.
The first version of the gem will filter the slow requests on our platform and send to a service (potential Mixpanel).
Filestore results
I added an example on filestore here: https://github.com/ministryofjustice/fb-user-filestore/compare/request-between-pages?expand=1#diff-2609f8204d87ced2918ad7d373575809R1
Mixpanel service
Tested on Mixpanel and it works gracefully:

Keen service
I added the keen.io service only to test different adapters to see if the library agnostic could work and it work beautifully:

Prometheus service
Unfortunately the current cloud platform Prometheus doesn't support the PushGateway service to push metrics to. You can see more details here
Next steps
This is the next steps:

[ ] Publish the gem (and document it!)
[ ] Use the gem on filestore
[ ] Use the gem  on pdf generator
[ ] Use the gem  on submitter
[ ] Use the gem on datastore
[ ] Use the gem on service token cache

Looks great dude.
Can we call the gem fb-metrics-adapter or just metrics-adapter if you don't want it to be FB specific?

Yes, good idea/name. I will rename it :)

@brenetic done! ♻


Spam filtering

High volumes of repeat messages must not be allowed from the same twitter account or unique device (techniques for uniquely identifying devices is still up for debate). The actual timeout period is planned to be externally configurable.

It's anticipated that the submission form will do some rate limiting, and so this SHOULD just apply to tweets.

This will now be handled by the API


Get rid of unnecessary styles on service pages

https://trello.com/c/lu1zDbsy/267-2-are-we-ready-to-migrate-buyer-frontend-to-govuk-frontend-v3
Trying to split out as much work as can be split out from the v3 migration branch (https://github.com/alphagov/digitalmarketplace-buyer-frontend/pull/1106).
We can replace all the classes in _service_page.scss with Design System classes, and this does that.

My review checklist
I've:

[ ] looked at the code
[ ] tested locally
[ ] run functional tests locally


Handle para-augur deployment through factories

In order to ensure that Para-Augur deploys are legitimate the deploys should be handled directly from a set of factories and a manager contract that can do all the necessary steps of deployment. This also allows us to tackle a few other issues in this area.

[ ] Compute initial price using the Storage Proof method outlined https://medium.com/@epheph/using-uniswap-v2-oracle-with-storage-proofs-3530e699e1d3 so that initial price doesn't need to be trusted.
[ ] For on-chain trading interval, use the Core REP Trading interval (10 DAI) and automatically set the Para Augur trading interval to be as close that as possible while being a multiple of 10. So e.g. Choose whichever of 1/1000, 1/100, 1/10, 1, 10, 100, 1000 makes the most sense as the adjustment to the trading interval.
[ ] Create a deployer contract + set of factories that can deploy the para augur contract in stages.

Where can I read about how this solves the problem of governance over the para-augurs?

Where can I read about how this solves the problem of governance over the para-augurs?

What this means is that no governance is needed to deploy the para augur because we get verifiable deploys, and don't need to trust any information from the deployer for the price of the tokens or the trading interval.

What prevents me from creating a scam token that only I have any of (mint 1 trillion of them to myself), fixing the price on Uniswap (to say $1 per token), and then depositing 1 trillion of them in a para-augur I deployed through the factory?


Fade property messes up onClick actions on slides

I'm using react-slick as the main slideshow and carousels on my site. Whenever fade property is off, everything works fine but when set to true, onClick functions get mixed up.
To recreate on fiddle, open js console, navigate slides and click on them. The behavior I get on my site is similar, instead of executing always the last slides's action it executes the previous slide's action.
Regardless, the key factor here is that if fade is set to false everything magically works just fine.

Issue -> jsfiddle

Same issue here. It seems like in "fade" mode, the hidden slides are actually on top of the current one which is causing pointer issues. I hacked my css to add .slick-active { z-index: 999; } as a workaround to fix input bugs