[DOC]: added pipenv installation instructions

PR Description

Added instructions for pipenv installation of pyjanitor.
Fixed my contribution link.

This PR resolves https://github.com/ericmjl/pyjanitor/issues/763.

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.rst.
My evan-anderson account is already on the author page.

[x] Add a line to CHANGELOG.rst under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[x] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
flake8 checking
running the test suite
docs build

** I encountered the following errors: **

However, I didn't make any changes to code, only documentation in the readme. @ericmjl please let me know if I need to address any problems here!
Documentation Changes

If you are adding documentation changes, please ensure the following:

[x] Build the docs locally.
[x] View the docs to check that it renders correctly.

My changes render correctly, but I encountered a number of errors that seem unrelated to my doc changes:
Building documentation...
cd docs && make html
make[1]: Entering directory '/workspaces/pyjanitor/docs'
Running Sphinx v3.1.1
Making symlink to ../examples/notebooks
notebooks directory already exists. Not creating..
loading pickled environment... done
[autosummary] generating autosummary for: CONTRIBUTION_TYPES.rst, PYCHARM_USERS.rst, authors.rst, contributing.rst, index.rst, installation.rst, notebooks.rst, notebooks/Pivoting Data from Wide to Long.ipynb, notebooks/README.rst, notebooks/Row_to_Names.ipynb, ..., reference/janitor.functions/janitor.unionize_dataframe_categories.md, reference/janitor.functions/janitor.update_where.md, reference/janitor.spark.functions/janitor.spark.clean_names.md, reference/janitor.spark.functions/janitor.spark.update_where.md, reference/janitor.xarray.functions/janitor.xarray.clone_using.md, reference/janitor.xarray.functions/janitor.xarray.convert_datetime_to_number.md, reference/ml.rst, reference/pyspark.rst, reference/timeseries.rst, reference/xarray.rst
[autosummary] generating autosummary for: /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.add_column.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.add_columns.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.bin_numeric.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.change_type.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.clean_names.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.coalesce.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.collapse_levels.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.concatenate_columns.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.convert_excel_date.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.convert_matlab_date.md, ..., /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.take_first.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.then.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.to_datetime.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.transform_column.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.transform_columns.md, /workspaces/pyjanitor/docs/reference/janitor.functions/janitor.update_where.md, /workspaces/pyjanitor/docs/reference/janitor.spark.functions/janitor.spark.clean_names.md, /workspaces/pyjanitor/docs/reference/janitor.spark.functions/janitor.spark.update_where.md, /workspaces/pyjanitor/docs/reference/janitor.xarray.functions/janitor.xarray.clone_using.md, /workspaces/pyjanitor/docs/reference/janitor.xarray.functions/janitor.xarray.convert_datetime_to_number.md
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 54 source files that are out of date
updating environment: 0 added, 58 changed, 0 removed
reading sources... [100%] reference/janitor.xarray.functions/janitor.xarray.convert_datetime_to_number
/workspaces/pyjanitor/docs/notebooks/board_games.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_board_games_24_0.png
/workspaces/pyjanitor/docs/notebooks/french_trains.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_french_trains_20_1.png
/workspaces/pyjanitor/docs/notebooks/inflating_converting_currency.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_inflating_converting_currency_9_1.svg
/workspaces/pyjanitor/docs/notebooks/inflating_converting_currency.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_inflating_converting_currency_9_1.png
/workspaces/pyjanitor/docs/notebooks/inflating_converting_currency.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_inflating_converting_currency_13_1.svg
/workspaces/pyjanitor/docs/notebooks/inflating_converting_currency.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_inflating_converting_currency_13_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:15: WARNING: File not found: 'reference/functions.html#janitor.functions.min_max_scale'
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:17: WARNING: File not found: 'reference/functions.html#janitor.functions.transform_column'
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:452: WARNING: File not found: 'reference/functions.html#janitor.functions.min_max_scale'
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:1329: WARNING: File not found: 'reference/functions.html#janitor.functions.transform_columns'
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_10_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_12_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_14_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_19_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_21_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_23_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_27_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_29_1.png
/workspaces/pyjanitor/docs/notebooks/normalize.ipynb:: WARNING: image file not readable: notebooks/../_build/doctrees/nbsphinx/notebooks_normalize_31_1.png
/workspaces/pyjanitor/janitor/functions.py:docstring of janitor.currency_column_to_numeric:16: WARNING: Bullet list ends without a blank line; unexpected unindent.
looking for now-outdated files... none found
pickling environment... done
checking consistency... /workspaces/pyjanitor/docs/CONTRIBUTION_TYPES.rst: WARNING: document isn't included in any toctree
/workspaces/pyjanitor/docs/PYCHARM_USERS.rst: WARNING: document isn't included in any toctree
done
preparing documents... done
writing output... [100%] reference/xarray
generating indices...  genindex py-modindexdone
copying notebooks ... [100%] notebooks/normalize.ipynb
highlighting module code... [100%] janitor.xarray.functions
writing additional pages...  searchdone
copying static files... ... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded, 22 warnings.

The HTML pages are in _build/html.
make[1]: Leaving directory '/workspaces/pyjanitor/docs'

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

One other quick question / comment: running make docs made a bunch of changes to the files in docs/reference. It looks like it deleted the last blank line of each of these markdown files. I decided not to commit these changes, but let me know if I should!

Thanks @evan-anderson-ts! Everything looks great here.

@evan-anderson-ts , if you can, kindly update the branch on your end, to fix the conflicting files, so I can approve and merge. Thanks!

@samukweku Hi Sam -- I resolved the conflicts! Let me know if you need anything else 😁

Merging, thanks @evan-anderson-ts!


data-protocols: add guard to avoid NPE when tokenResult is failed

@ndr-brt is this ready to merge? If you are OK with it, I'll do that.

@jimmarino ok


[WIP]  feat: SWA-267 photo row placeholder

The type of this PR is: feat

This PR resolves: replaces placeholder and put PhotoRow into palette
Description

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

replace placeholder and put PhotoRow into palette

im not sure about the validation file and check being in palette. feel app-specific, not component specific. what do you think?


Build in windows

Anyone know, how to build in windows

https://github.com/0x7ff/gaster/issues/4#issuecomment-1146617492


x/build: perf fails to upload some benchmark data from c3h88 builders

We're currently missing data for some commits due to failures like
numerator/denominator mismatch, expected 7c72dc77a934cf5957e5667e204506a61457e66a/69234ded30614a471c35cef5d87b0e0d3c136cd9 got 7c72dc77a934cf5957e5667e204506a61457e66a/

when uploading to Influx. This is a failure in the comparison code.

Fixed with the switch to using benchstat's internals for comparison.


App Sample

https://github.com/Microsoft/vsts-auth-samples/blob/master/OAuthWebSample/appstart.png

@Neo-wise I'm sorry, I don't understand the issue you are having. Can you provide us some more details?


Consider changing default value for precision from 0 to 2

Is your feature request related to a problem? Please describe.
I was always wondering why all my coverage reports shows coverage percentage as float but without fraction part. E.g. ``92.00%`.
After diving into source code, I found that reported coverage is almost always rounded, and default value for precision is 0:
https://github.com/nedbat/coveragepy/blob/962429ce7c160e8b476cc610288f58206c629138/coverage/results.py#L191
Describe the solution you'd like
Change default value for precision to 2.
Describe alternatives you've considered
Additional context

Help me understand: what coverage reports are you using? With the default precision of 0, you should see 92%, not 92.00%.

Sorry, my bad, report shows just 92%, not 92.00%:
-------------------------------------------
TOTAL      1860    117    354     44    92%

OK, thanks.  I don't think most people want more precision in their numbers.  The setting is there so that you can get the precision you want.  I think the default of 0 is still appropriate.


Add per-revision validating webhook configuration

[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

integ-multicluster-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

integ-multicluster-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

integ-multicluster-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

integ-multicluster-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

lint_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test lint_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

integ-multicluster-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-distroless-k8s-tests_istio

integ-security-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test unit-tests_istio

release-test_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test release-test_istio

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-k8s-tests_istio

gencheck_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test gencheck_istio

analyze-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test analyze-tests_istio

integ-ipv6-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-operator-controller-tests_istio

integ-helm-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-helm-tests_istio

integ-multicluster-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-multicluster-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-multicluster-tests_istio

integ-distroless-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-distroless-k8s-tests_istio

integ-security-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-multicluster-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-multicluster-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-multicluster-tests_istio

integ-security-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-multicluster-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
c75ca50e063477c3da117b0cf3aa8e186393e83f
link
/test integ-security-multicluster-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test lint_istio

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator thanks for this PR. Can you explain at a high level how multiple validating webhooks work? Will all revisions be called when a a resource is created/updated?
What's the behavior when one validating webhook service tied to old version accepts the resource but the new validating service rejects it?

Sam Naser thanks for this PR. Can you explain at a high level how multiple validating webhooks work? Will all revisions be called when a a resource is created/updated?

Yeah so for context this implements part of this design. By default these validating webhooks only target resources with istio.io/rev label so multiple injection won't be an issue.
To make it so that a revision validates all resources like today you have to make it the default revision (to be implemented in follow-up). IMO revisions should be default by default since we can't suddenly make validation opt-in. If multiple revisions are marked as default then you will see repeat validation.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
395b5ce78a37083fd0d547473cd4c637b95c5d83
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-multicluster-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
395b5ce78a37083fd0d547473cd4c637b95c5d83
link
/test lint_istio

gencheck_istio
395b5ce78a37083fd0d547473cd4c637b95c5d83
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
395b5ce78a37083fd0d547473cd4c637b95c5d83
link
/test gencheck_istio

lint_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

gencheck_istio
395b5ce78a37083fd0d547473cd4c637b95c5d83
link
/test gencheck_istio

lint_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test lint_istio

unit-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test lint_istio

unit-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test unit-tests_istio

gencheck_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test lint_istio

unit-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test unit-tests_istio

gencheck_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test gencheck_istio

integ-security-multicluster-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test unit-tests_istio

gencheck_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test gencheck_istio

integ-security-multicluster-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test integ-security-multicluster-tests_istio

lint_istio
1c9fd570ad7c945d03927a6fb77f45e9efdbfe86
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

integ-security-multicluster-tests_istio
786d7f7445cb6fce03ee8c4d17036a850d0e106d
link
/test integ-security-multicluster-tests_istio

lint_istio
1c9fd570ad7c945d03927a6fb77f45e9efdbfe86
link
/test lint_istio

unit-tests_istio
1c9fd570ad7c945d03927a6fb77f45e9efdbfe86
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
1c9fd570ad7c945d03927a6fb77f45e9efdbfe86
link
/test unit-tests_istio

lint_istio
247de5a74612034b3c80e6afd56162c7e158b450
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
dbbb6157d4b0cfedfce305a95af599fce3de4ea2
link
/test integ-pilot-k8s-tests_istio

lint_istio
247de5a74612034b3c80e6afd56162c7e158b450
link
/test lint_istio

unit-tests_istio
247de5a74612034b3c80e6afd56162c7e158b450
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
247de5a74612034b3c80e6afd56162c7e158b450
link
/test unit-tests_istio

lint_istio
d323ba761f7a95fe1f09d708742e10080c85b042
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
247de5a74612034b3c80e6afd56162c7e158b450
link
/test unit-tests_istio

lint_istio
d323ba761f7a95fe1f09d708742e10080c85b042
link
/test lint_istio

gencheck_istio
d323ba761f7a95fe1f09d708742e10080c85b042
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d323ba761f7a95fe1f09d708742e10080c85b042
link
/test lint_istio

gencheck_istio
f30ed5ca76c9619635e75a86446951495005e07a
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f30ed5ca76c9619635e75a86446951495005e07a
link
/test gencheck_istio

lint_istio
f30ed5ca76c9619635e75a86446951495005e07a
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
9f946aedda8b605e5e2b4166bdb7c52ce02c7078
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
9f946aedda8b605e5e2b4166bdb7c52ce02c7078
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
9f946aedda8b605e5e2b4166bdb7c52ce02c7078
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
9f946aedda8b605e5e2b4166bdb7c52ce02c7078
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
9f946aedda8b605e5e2b4166bdb7c52ce02c7078
link
/test integ-pilot-k8s-tests_istio

integ-helm-tests_istio
316ee7e0e659889d47e24574eaca3d1679353aa7
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
316ee7e0e659889d47e24574eaca3d1679353aa7
link
/test integ-helm-tests_istio

integ-pilot-k8s-tests_istio
316ee7e0e659889d47e24574eaca3d1679353aa7
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
0323efac24f020481fde2720633df6b3d7ed2e31
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
0323efac24f020481fde2720633df6b3d7ed2e31
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
9d34271a45cde836715ae2e077ca51745bdefaed
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
db300f25e6ebda9b448c323dc6b40eec2d80d334
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-telemetry-mc-k8s-tests_istio

integ-helm-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-pilot-multicluster-tests_istio

integ-operator-controller-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-operator-controller-tests_istio

integ-telemetry-mc-k8s-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-telemetry-mc-k8s-tests_istio

integ-security-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-security-multicluster-tests_istio

integ-helm-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-helm-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-helm-tests_istio

integ-security-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
9c9a10652d350b4305bfdff63413d1beca2dbf20
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Sam Naser thanks for this PR. Can you explain at a high level how multiple validating webhooks work? Will all revisions be called when a a resource is created/updated?

Yeah so for context this implements part of this design. By default these validating webhooks only target resources with istio.io/rev label so multiple injection won't be an issue.
To make it so that a revision validates all resources like today you have to make it the default revision (to be implemented in follow-up). IMO revisions should be default by default since we can't suddenly make validation opt-in. If multiple revisions are marked as default then you will see repeat validation.

No custom resources contain the "istio.io/rev" label and almost all Istio resources impact all versions of control plane. Are we expecting users to start adding this label for custom Istio objects?

Are we expecting users to start adding this label for custom Istio objects?

@nrjpoddar using istio.io/rev object selector here is an implementation detail that lets us mark a webhook FailClosed when its specific webhook is ready and rejecting invalid configs. It would be hidden and undocumented

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
adb3d1c32f66eb5fc6ccf8ebafbb4b7ff2e3cc2c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
adb3d1c32f66eb5fc6ccf8ebafbb4b7ff2e3cc2c
link
/test release-notes_istio

lint_istio
adb3d1c32f66eb5fc6ccf8ebafbb4b7ff2e3cc2c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
adb3d1c32f66eb5fc6ccf8ebafbb4b7ff2e3cc2c
link
/test lint_istio

release-notes_istio
73140522f2cc66272216c8347a9c5fb96b6903f7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
73140522f2cc66272216c8347a9c5fb96b6903f7
link
/test release-notes_istio

lint_istio
73140522f2cc66272216c8347a9c5fb96b6903f7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
73140522f2cc66272216c8347a9c5fb96b6903f7
link
/test lint_istio

release-notes_istio
5944075c8338f596f10ca15118516e56d1e74c97
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
5944075c8338f596f10ca15118516e56d1e74c97
link
/test release-notes_istio

unit-tests_istio
5944075c8338f596f10ca15118516e56d1e74c97
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
f83d3da6b8ae83070e825be61e1af2941ca1c59e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
f83d3da6b8ae83070e825be61e1af2941ca1c59e
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
2bcd909df3a8e3f81f86d10e79ba6822cc28072e
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-ipv6-k8s-tests_istio
2bcd909df3a8e3f81f86d10e79ba6822cc28072e
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
2bcd909df3a8e3f81f86d10e79ba6822cc28072e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
2bcd909df3a8e3f81f86d10e79ba6822cc28072e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0879e2762429eb66521db2b4a44c68272ff20f4c
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Monkeyanator: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
0879e2762429eb66521db2b4a44c68272ff20f4c
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
0879e2762429eb66521db2b4a44c68272ff20f4c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
cc10624419fbf011ff702a769aa2c8a9d6a1e5b1
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Docs: change latest release link in README.md to point to tui.chart (fix #172)

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description
Change link in README.md that currently points to latest release of tui.grid to point to latest release of tui.chart

Can one of the admins verify this patch?

ok to test

#175 merged


Report about react rules in eslint-config-prettier-check

Well, there’s a test for that.
Perhaps you’ve run into a bug? Could you share what you tried, what your expectation was and what really happened?

@lydell my bug, sorry


Restore NOTIFICATION_CHANGE

This restores NOTIFICATION_CHANGE events for updating alarms and timers, which Amazon appears to support via HTTP2 notifications. This restores alarm and timer updates via changes in the Alexa app. I've kept PUSH_ACTIVITY as well as there does not seem to be any downside in responding to both event types and Amazon may be inconsistent in their implementation across different regions.
Partial revert of 8f0dfa2 to restore NOTIFICATION_CHANGE functionality for timers and alarms.

Thanks!


Three more bytesize talks

The following titles will be added:

gitpod (Marcel Ribeiro-Dantas)
git concepts (Edmund Miller)
beginners guide (Franziska Bonath)

You can ignore the failing playwright tests for now


cancelled target halts report generation

The model target does not build if the skip model condition is met however, model is a dependency of report. Therefore, the report target does not build and the html report is not generated. Conditional logic is tricky with this tool.
Possible solutions:

Create an "exploratory" plan and figure out how to share targets between plans; the rnaseq_plan containing all the same targets of the "exploratory" plan or, said another way, the "exploratory" plan containing a sub-set of targets.
Do away with conditional logic and cancelled targets entirely, force the plan to run start to finish.

Can drake_plan be wrapped in conditional logic at this point in the code?
If targets are named the same, will they load between plans?


Update Google API client dependency

@jnbt still WIP. Accidentally pressed the "ready for review" button and sadly can't bring the PR back into draft status.

Coverage decreased (-44.8%) to 53.884% when pulling c39042ad7bd80821bda496f95597758080619466 on play_store_refactor into 28872f98ba5c26cd2dd7f395d5c03090ecf13bea on master.

This PR fixes #31 #11 #17

In order to update the underlaying Google API client, we needed to introduce some breaking changes to the PlayStore functionality. If you're upgrading from a CandyCheck version < 0.2.0 see the migration guide for more information.


[Spark-6793][MLlib] OnlineLDAOptimizer LDA perplexity

Implements logPerplexity in OnlineLDAOptimizer. Also refactors inference code into companion object to enable future reuse (e.g. predict method).

Merged build triggered.

Merged build started.

Test build #38603 has started for   PR 7705 at commit 11e7c33.

Test build #38603 has finished for   PR 7705 at commit 11e7c33.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

CC @hhbyyh Do you have time to take a look at this PR?  Thanks!

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #38625 has started for   PR 7705 at commit 4f171f7.

Test build #38625 has finished for   PR 7705 at commit 4f171f7.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class RequestExecutors(

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #38626 has started for   PR 7705 at commit 4362daa.

Test build #38626 has finished for   PR 7705 at commit 4362daa.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build triggered.

Merged build started.

Test build #38637 has started for   PR 7705 at commit 998c03e.

Merged build finished. Test FAILed.

Test build #38637 has finished for   PR 7705 at commit 998c03e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thank @feynmanliang for picking this up. I hesitated for a long time about how these functions should be implemented. I know Gensim is using the similar way, yet from my understanding, log-perplexity has been used as a measurement for topic modeling long before the birth of online LDA algorithm. I'm not sure if we can find a more native way to compute it without invoking the inference in OnlineLDAOptimizer.  For LocalLDAModel, it'll be more self-contained and impartial (for other LDAOptimizers) if we can implement the perplexity and prediction just from the two distributions and the input documents parameter.
This is just a layman's opinion and may be overcautious, and sorry for raising a question without providing solutions. I'll ask around to see the options.

@hhbyyh I believe that log-perplexity is still used for generative NLP models (e.g. Wallach 09 Table 2 evaluates with log P(Wtest | W, Z, Ω) / Ntest). Is your concern about more efficient ways to compute it?
Since perplexity is a measure of loss between the empirical and variational distributions, computing it will require inference of the variational parameters. One option could be to save the document-topic Dirichlet parameters gammad during training (gensim provides this as an optional arg to bound) but if we are concerned with scaling this may not be the best idea (I've left this as a tentative TODO, note that gensim itself does not utilize it).
On the test set, however, we will have to perform inference before we can calculate perplexity. This is because the LDA model is only learning document-topic (alpha) and topic-word (lambda) Dirichlet parameters while computation of log perplexity requires the variational distribution (parameterized by gamma, which is obtained by inference).

I believe the issue @hhbyyh is raising is as follows:

To compute log-perplexity, we need to compute the probability of each word in the test document(s).
To compute that probability, we need to do inference.
Should inference be done (a) the same way as during learning (e.g., use variational inference if the model was produced by Online VB LDA), or (b) the same way for a given type of model (e.g., use inference type X for a LocalLDAModel, regardless of whether it was produced by online or EM), or (c) the same way for all models?

My vote would be for (b) or (c) simply because those both mean implementing only 1 type of inference for now.  In the future, we could add the option to use different inference methods.
One caveat: (a) seems like the "right" way to do things statistically: using the same procedure during testing and training.  But I don't think we have time to do it that way.  We could mark the method as DeveloperApi if we want to switch to (a) in the future.

@jkbradley I don't think (a) is possible right now since DistributedLDAModel has a hard dependency on EMLDAOptimizer (see here).
Also, (c) cannot be supported until asymmetric priors are added to EM and DistributedLDAModel.

I agree that (a) would require too much extra work.
(c) could be supported currently.  It's (reasonably) straightforward to implement it for LocalLDAModel, and DistributedLDAModel can use that same method (since there is already a method for converting a DistributedLDAModel to a local one).
Let's just support it for LocalLDAModel via variational inference for now.  We can postpone a hard decision about these options until later.

SGTM; (b) is what's included in this PR. Do you mind reviewing soon since this is blocking LDA predictions and hyperparameter optimization?

I'll make a pass now

It's looking good, mostly small comments.
Note: If you remove the private constructors, MIMA may complain, in which case it's OK to leave them.  Otherwise, I'd remove them.

I'll make a pass through this, and afterwards look into that flaky test issue.  But in the meantime, can you please run that test a bunch of times locally?  I'll do the same.

Merged build triggered.

Merged build started.

Test build #38884 has started for   PR 7705 at commit 2f452a4.

To reproduce, add BDM.zeros[Double](nonEmptyDocs.length, k) anywhere inside the computation of val stats inside OnlineLDAOptimizer#submitMiniBatch

Merged build triggered.

Merged build started.

Test build #38884 has finished for   PR 7705 at commit 2f452a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

That's it for now

Test build #38892 has started for   PR 7705 at commit 17f7000.

Merged build triggered.

Merged build started.

Test build #38897 has started for   PR 7705 at commit 8381da6.

Merged build triggered.

Merged build started.

Test build #38898 has started for   PR 7705 at commit 6da2c99.

Test build #38892 has finished for   PR 7705 at commit 17f7000.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

LGTM, but I'll wait for the last 2 sets of tests to pass (given the flakiness we're worried about).  Thanks!

Test build #38897 has finished for   PR 7705 at commit 8381da6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #38898 has finished for   PR 7705 at commit 6da2c99.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merging with master


Server 2008 R2 couldn't get accessed to Azure File Share, with the given PowerShell script in Portal

Hi Team,
We‘ve encountered issues in getting getting Azure FileShare mounted in Windows Server 2008 R2 system, screenshot as belows:

As for the document suggested, it's supported for this system to mount.

Would you please help check validate if the document is still workable, or at least add minimum script running requirement in the Azure File Share connect portal?
If it really not supported, is it possible to show some other method to tell customers how to mount?
Thanks for your help in checking this!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c12f1ea9-6446-be01-22fe-885fb945d22c
Version Independent ID: 634f8ace-1a8c-6811-627b-fdfbdd1942a3
Content: Use an Azure file share with Windows
Content Source: articles/storage/files/storage-how-to-use-files-windows.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@xps233 Thank you for your feedback . We will investigate and update the thread.

@shashishailaj Thanks for checking on that, please update here once there's the latest)

@xps233 I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
Troubleshoot Azure Files problems in Windows (SMB)
Additional information : If the client only supports SMB 2.1 (and not 3.0) then you can mount a file share on an Azure Virtual Machine only if it is in the same region.
SMB version supported on Windows Server 2008 R2 is 2.1 so it is not possible to mount Azure File share if they happen to be in different regions. With SMB 2.1, Azure File Storage was restricted to connect from the same region because of lack of encryption in the underlying SMB 2.1 protocol.

@SumanthMarigowda Thanks for your reply. Obviously you might not noticed that the error message here, is that the GIVEN SCRIPT in Azure Portal, could not get work, since the VERY LINE 1 !

So could you give feedback to the internal team in at least share some confirmation about this? Many thanks.

@

@xps233 Test-NetConnection is apparently not in the default 2008 R2, so if they install either Management Framework 5.1 or PowerShell 7, then it should work Installing PowerShell on Windows - PowerShell | Microsoft Docs

Hi @SumanthMarigowda , thanks for taking notice on this.
Previous then I've got tried on this, obviously this gonna not work:

Could you get suggested on this? Thanks for checking.
Also please re-open this issue...

Hi @SumanthMarigowda , Would you like get issue reopened, so discuss might able to keep on...

Hello guys @SumanthMarigowda @shashishailaj , is there would get any update from this, many thanks for your check on this!

Hi team @SumanthMarigowda @shashishailaj, kindly ask could you leave this issue re-opened status? This issue is actually not being resolved yet.  Thanks for your help!


Add deep.serial to sync handlers

Description
Imagine that we insert some link, then after some operations insert another link. If the second insertion will not be succesffuly executed and throw an error - the first insertion will not rollback. The most  consistent solution for sync handlers to not handle manual rollback is to use serial which can be done as rarely is possible

@FreePhoenix888 it is impossible to use more than one transaction in sync handlers. All insert/update/delete operation in sync handlers will be executed in single transaction. So this issue cannot be implemented. deep.serial will be never needed in sync handlers.


Add notes in Extra 2.2 section

Hey, I was running into the confusion of integrating Extra 2.2 steps in my tutorial in implementing custom interfaces, I added a note saying that this was just an extra note and not something officially implemented in the tutorial. I hope this helps for future readers.

Looking at this again, I think that the "Extra" section actually should be removed completely from this tutorial. This is a beginner tutorial, so we should just show one recommended way to do things. @fujitatomoya What do you think about just removing this?

I am okay to remove it 👍

or just remove the sub-section header so that it doesn't confuse users into thinking it's part of the tutorial, and make it more obvious in the .. note:: that this is just a tip for the future.
But yeah, I also agree with removing it.

@ahnfikd7 friendly ping, maintainers have requested additional changes to this PR.

I'm going to close this in favor of #4650


color picker positioning off

Color picker should appear horizontally centered with the color picker button and just below.  It is currently being offset to the right .

Also, if the window is maximized, the offsetting forces the color picker off the screen.

fixed


Using Offset instead of address from disassembly

Refactor to use offset and a constant memoryReference from stackFrame. #129655
Fix an issue when scrolling too fast by using a "lock".
RemoveAllBreakPoint will also remove InstructionBP. #129572
This PR fixes #129572 #129655
@isidorn @weinand

This looks good, however changing offsets are imho always a bit risky, so I would prefer to merge this in start of next week.
Thus assigning to August.
If you would really like this to ship as part of the July release please let me know.

@isidorn Sounds reasonable.  I will like to fix the BP and scrolling issue.

I think you need to update currentAddress on stack frame changes? I would suggest not to update current address in the reset function, and instead, change the ResetInstructionAddress function to only reset the offsets (function name starts with lower case, btw). This would make #129721 easier.

Abandon for now.


QPN4XM9Z

I have set up automatic export of a bib file by File - Export Library - Format: Better BibTex/Better BibLaTex and checking the Keep Updated box. Updating works for a while (shows in the list in preferences and makes real updates) but after a while (usually by the next day) it is gone and I have to set up a new automatic export.
Please tell me if I'm simply doing something wrong.

Can you upgrade to the latest version and try again?

(it sounds like #490, which was just fixed)

Made the update, seems to work. My bad for not doing it before. To be fair, I tried but I couldn't remember how I installed the add-on in the first place :)

That's OK. It will update automatically at some point (I don't know when FF decides to check), but you can force an update of your extensions by going into the hamburger menu at the top right, selecting Add-ons, then the gear dropdown, and select "check for updates".


viewer treeshaking

@sebavan I am at 1.3 currently. Let me know if it looks ok so far. Also how do you configure babylonjs/core and babylonjs/loaders? I havn't yet figured out how to do this with the loader.

I am wondering if  FreeCamera, Physics, VirtualJoystick, TGA, MeshBuilder, ActionManager and StandardMaterial are all usefull ?

I guess MeshBuilder could be replaced by the smaller one and we are done :-)

Still todo is figuring out how to automate the build of it. I removed the absolute reference aliases to babylonjs and babylonjs-loaders so right now to build you need to run gulp npmPackages-es6 in tools/gulp and then npm link @babylonjs/core and npm link @babylonjs/loaders and getting the automated building working.


Bugged language support?

Describe the bug
context and bug
The language support seems not working (or partially working) now when used together with Jupyter Book. No matter what language is set in _config.yml, for example:
sphinx:
  config:
    language: fr

There will still be many words remaining untranslated (i.e. in English). Based on the following example, it seems that it used to work but not anymore.
Reproduce the bug
I forked a Jupyter Book written in French (associated Github repo) and pushed the book to my Github pages (associated Github repo) using exactly the same Github Action.
Screenshot from the original Book pages (last push was on Dec 8, 2021)

Screenshot from the forked Book pages (last push was on Jul 10, 2022)

You can see while some of the words are translated (e.g. Suivant and juil.), many others are not (Last updated, By, ...).
@pnavaro I would like to ping you here since I used your book as a test case. Maybe you also have some ideas about this?
List your environment
Latest version on conda in Dec 8, 2021 vs Jul 10, 2022.

Linked to #538 perharps ?

Further digging this today made me realize that it is because of the missing .mo files in ${sphinx_book_theme_root}/theme/sphinx_book_theme/static/locales/*/LC_MESSAGES, as required by sphinx.locale.get_translation.
A quick workaround is

go to ${sphinx_book_theme_root}
delete all existing .po files by rm -rf theme/sphinx_book_theme/static/locales/*
run python _compile_translations.py and regenerate both the .po and .mo files. Now it should be no problem to generate a fully translated Jupyter Book.

But here I wonder if we could address this in the next few releases since it is so important for all international JB users. It seems to me that _compile_translations.py was executed at build time (so we see .po files), but failed to generate .mo files for an unknown reason.

Thank a lot for this workaround!
I tried it on Windows (10) and it worked after some additional steps.
Here all the steps I did to get it working.

Locate your Sphinx installation. It should be located where you global libraries are located. In case you use a venv:
C:\{path to your venv}\Lib\site-packages\sphinx_book_theme\
From there navigate to
sphinx_book_theme\theme\sphinx_book_theme\static\locales
and delete everything inside the folder.
Install GetText from https://gnuwin32.sourceforge.net/packages/gettext.htm. This is the Windows version of a unixtool for native language support. The executable msgfrm.exe is needed from this installation to generate the .mo files. Add the bin folder of the installation to the %path% system variable. In my case the path is C:\GnuWin32\bin.
Navigate to sphinx_book_theme\ and locate the file _compile_translations.py. Edit the file:
Change line 57 from
with out_path.open("a") as f:
to
with out_path.open("a", encoding="utf-8") as f:
and safe it.
Open a new terminal window (cmd). Acvtivate your venv if you have one. Now run the python script: python .\_compile_translations.py. All the translations should be fine now. Rebuild your Jupyter-Book book.

The sphinx_book_theme-0.3.3-py3-none-any.whl file does not contain *.mo files, this can be also resolved by installing sphinx-book-theme from source:
pip install sphinx-book-theme --no-binary 'sphinx-book-theme'

@iasbusi your 5. doesn't work on my end.
C:\Windows\system32>cd C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme

C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme>py ./_compile_translations.py
[SBT]: Compiling translations
C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme\assets\translations\..\..\theme\sphinx_book_theme\static\locales\ar\LC_MESSAGES\booktheme.po
Traceback (most recent call last):
  File "C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme\_compile_translations.py", line 78, in <module>
    convert_json()
  File "C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme\_compile_translations.py", line 66, in convert_json
    subprocess.check_call(
  File "C:\Program Files\Python39\lib\subprocess.py", line 368, in check_call
    retcode = call(*popenargs, **kwargs)
  File "C:\Program Files\Python39\lib\subprocess.py", line 349, in call
    with Popen(*popenargs, **kwargs) as p:
  File "C:\Program Files\Python39\lib\subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Program Files\Python39\lib\subprocess.py", line 1420, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] Le fichier spécifié est introuvable

C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme>

The last line means "the specified file is not found".
NB : I'm not using sphinx in the context of a notebook, so apologies if it's the reason, but I doubt it.

I’m not sure why it is not working on your side.
I had no time to reproduce this error.
My first guess is, you did not start the script from the right directory.
Please navigate (with cd on the command prompt) to the directory sphinx_book_theme\ and afterwards try to execute the script again (._compile_translations.py).
Regards
Adrian
Von: Gouvernathor @.>
Gesendet: Donnerstag, 24. November 2022 22:05
An: executablebooks/sphinx-book-theme @.>
Cc: Busin Adrian (busi) @.>; Mention @.>
Betreff: Re: [executablebooks/sphinx-book-theme] Bugged language support? (Issue #584)
@iasbusihttps://github.com/iasbusi your 5. doesn't work on my end.
C:\Windows\system32>cd C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme
C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme>py ./_compile_translations.py
[SBT]: Compiling translations
C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme\assets\translations....\theme\sphinx_book_theme\static\locales\ar\LC_MESSAGES\booktheme.po
Traceback (most recent call last):
File "C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme_compile_translations.py", line 78, in
convert_json()

File "C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme_compile_translations.py", line 66, in convert_json
subprocess.check_call(

File "C:\Program Files\Python39\lib\subprocess.py", line 368, in check_call
retcode = call(*popenargs, **kwargs)

File "C:\Program Files\Python39\lib\subprocess.py", line 349, in call
with Popen(*popenargs, **kwargs) as p:

File "C:\Program Files\Python39\lib\subprocess.py", line 951, in init
self._execute_child(args, executable, preexec_fn, close_fds,

File "C:\Program Files\Python39\lib\subprocess.py", line 1420, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,

FileNotFoundError: [WinError 2] Le fichier spécifié est introuvable
C:\Program Files\Python39\Lib\site-packages\sphinx_book_theme>
The last line means "the specified file is not found".
NB : I'm not using sphinx in the context of a notebook, so apologies if it's the reason, but I doubt it.
—
Reply to this email directly, view it on GitHubhttps://github.com/executablebooks/sphinx-book-theme/issues/584#issuecomment-1326833407, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAR4UETNP6SX4N6YX2BHFU3WJ7J7PANCNFSM53EWBZNQ.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

I updated the top comment from @whyjz to describe what I think are two potential problems that we need to resolve. Would love help from anybody that knows how to fix this! cc @AakashGfude in case he has cycles to look into this, I'd appreciate it!