MySQL - Error reading TABLE_MAP event - possibly jsonb columns

https://issues.redhat.com/browse/DBZ-7919
[Sink connector Debezium Event Thread] INFO io.debezium.embedded.EmbeddedEngine - Retriable exception thrown, connector will be restarted; errors.max.retries=-1
org.apache.kafka.connect.errors.RetriableException: An exception occurred in the change event producer. This connector will be restarted.
	at io.debezium.pipeline.ErrorHandler.setProducerThrowable(ErrorHandler.java:63)
	at io.debezium.connector.mysql.MySqlStreamingChangeEventSource$ReaderThreadLifecycleListener.onEventDeserializationFailure(MySqlStreamingChangeEventSource.java:1141)
	at com.github.shyiko.mysql.binlog.BinaryLogClient.listenForEventPackets(BinaryLogClient.java:1081)
	at com.github.shyiko.mysql.binlog.BinaryLogClient.connect(BinaryLogClient.java:648)
	at com.github.shyiko.mysql.binlog.BinaryLogClient$7.run(BinaryLogClient.java:949)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: io.debezium.DebeziumException: Failed to deserialize data of EventHeaderV4{timestamp=975332709000, eventType=EXT_DELETE_ROWS, serverId=808333357, headerLength=19, dataLength=808464413, nextPosition=741553458, flags=8736}
	at io.debezium.connector.mysql.MySqlStreamingChangeEventSource.wrap(MySqlStreamingChangeEventSource.java:1088)
	... 5 more
Caused by: com.github.shyiko.mysql.binlog.event.deserialization.EventDataDeserializationException: Failed to deserialize data of EventHeaderV4{timestamp=975332709000, eventType=EXT_DELETE_ROWS, serverId=808333357, headerLength=19, dataLength=808464413, nextPosition=741553458, flags=8736}
	at com.github.shyiko.mysql.binlog.event.deserialization.EventDeserializer.deserializeEventData(EventDeserializer.java:343)
	at com.github.shyiko.mysql.binlog.event.deserialization.EventDeserializer.nextEvent(EventDeserializer.java:246)
	at io.debezium.connector.mysql.strategy.AbstractBinaryLogClientConfigurator$1.nextEvent(AbstractBinaryLogClientConfigurator.java:110)
	at com.github.shyiko.mysql.binlog.BinaryLogClient.listenForEventPackets(BinaryLogClient.java:1068)
	... 3 more
Caused by: com.github.shyiko.mysql.binlog.event.deserialization.MissingTableMapEventException: No TableMapEventData has been found for table id:128017496827756. Usually that means that you have started reading binary log 'within the logical event group' (e.g. from WRITE_ROWS and not proceeding TABLE_MAP
	at com.github.shyiko.mysql.binlog.event.deserialization.AbstractRowsEventDataDeserializer.deserializeRow(AbstractRowsEventDataDeserializer.java:109)
	at com.github.shyiko.mysql.binlog.event.deserialization.DeleteRowsEventDataDeserializer.deserializeRows(DeleteRowsEventDataDeserializer.java:64)
	at com.github.shyiko.mysql.binlog.event.deserialization.DeleteRowsEventDataDeserializer.deserialize(DeleteRowsEventDataDeserializer.java:56)
	at com.github.shyiko.mysql.binlog.event.deserialization.DeleteRowsEventDataDeserializer.deserialize(DeleteRowsEventDataDeserializer.java:32)
	at com.github.shyiko.mysql.binlog.event.deserialization.EventDeserializer.deserializeEventData(EventDeserializer.java:337)
	... 6 more
[Sink connector Debezium Event Thread] INFO io.debezium.embedded.EmbeddedEngine - Starting connector, attempt 1

I have same problem but likely due to database is updated with large transaction data. here is my log. the tool is complaining failed to deserialize EventHeaderV4{timestamp=1724185177000, eventType=TABLE_MAP
2024-08-20T20:20:40.832715274Z 2024-08-20 20:20:40.832 ERROR - Error during binlog processing. Last offset stored = {ts_sec=1724185169, file=mysql_bin.002677,7a814ecbf:1-198200204, server_id=46, event=37}, binlog reader near position = mysql_bin.002677/81376772
2024-08-20T20:20:40.835679607Z 2024-08-20 20:20:40.832 ERROR - Producer failure
2024-08-20T20:20:40.835743925Z io.debezium.DebeziumException: Failed to deserialize data of EventHeaderV4{timestamp=1724185177000, eventType=TABLE_MAP, servertion=81376978, flags=0}
2024-08-20T20:20:40.835764323Z  at io.debezium.connector.binlog.BinlogStreamingChangeEventSource.wrap(BinlogStreamingChangeEventSource.java:1190) ~[app.jar:?]
2024-08-20T20:20:40.835782145Z  at io.debezium.connector.binlog.BinlogStreamingChangeEventSource$ReaderThreadLifecycleListener.onEventDeserializationFailure(Bjar:?]

here is binlog causes error. I digged more log around the period where problem happen, I indeed find very long record update operation.  -- exactly as the warning is indicating
WARNING: The range of printed events ends with a row event or a table map event that does not have the STMT_END_F flag set. This might be because the last stause you are using a --stop-position or --stop-datetime that refers to an event in the middle of a statement. The event(s) from the partial statement have not
ROLLBACK /* added by mysqlbinlog */ /*!*/;
SET @@SESSION.GTID_NEXT= 'AUTOMATIC' /* added by mysqlbinlog */ /*!*/;
DELIMITER ;

The problem troubles me for a long time, it will be really appreciated if some one can help me out. I can offer more logs if needed.  I believe a large data operation that exceed one CDC cycle is the cause of failure.


mechanism to auto-detect and install algorithm requirements.

In GitLab by @Schumann on May 1, 2020, 13:18
The current tools have no way of automatically checking for and installing any dependencies that the algorithms may have. Some way of handling this should be created.

In GitLab by @eswears on May 21, 2020, 13:47
assigned to @aashish-chaudhary

In GitLab by @eswears on May 21, 2020, 13:47
assigned to @Schumann and unassigned @aashish-chaudhary

In GitLab by @eswears on May 21, 2020, 13:47
make sure they are compatiable with the system that wants to use them, autodetect them and only list if they are compatible

In GitLab by @Schumann on May 21, 2020, 13:50
moved from learn#3

In GitLab by @Schumann on May 21, 2020, 13:57
unassigned @Schumann

In GitLab by @waxlamp on Jul 10, 2020, 11:05
We will need to discuss this in order to determine feasibility. It is a deceptively difficult thing to do when operating outside the normal Python tooling.

In GitLab by @waxlamp on Nov 24, 2020, 14:25
This is no longer relevant--algorithm requirements will either be installed by hand, or be listed as standard package dependencies for, e.g., a published algorithm package.


Multilayered LSTM

Hello @erickrf ,
Thanks for the great reference implementation. I noticed that the paper mentioned that they have 4 layers of LSTMs. Is this adopted in your code? I am not sure which are the 4 layers. Is it 3 for encoder and 1 for decoder? Sorry if I understood it incorrectly. Thanks!

Hi, the implementation only has one layer. It was not supposed to implement the exact architecture in the Sutskever paper.


NDRS-755: add initial implementation and tests

After a discussion with @EdHastingsCasperLabs I need to do some refactoring work to change the approach somewhat.  New PR to follow soon.

After a discussion with @EdHastingsCasperLabs I need to do some refactoring work to change the approach somewhat.  New PR to follow soon.


Move some debug level messages to info level

Just found one change was missing in the last commit

@mergify backport v1.5.x


how to uninstall properly??

Hi, i would like to know which the process for a clear uninstall? I delete the accessibility permission i give to app and then using appcleaner i delete the app and related files. Is that enough?

I'm not sure what exactly appcleaner uninstalls, but there's usually also a preferences file. You should be able to find it when you enter the following in terminal:
ls ~/Library/Preferences | grep "MonitorControl"

If you see anything (MonitorControl related) there as a result, run:
rm ~/Library/Preferences/me.guillaumeb.MonitorControl.plist


Question: How to change display name on the desktop app from 'WinUI Desktop' to the actual display name or something else?

I am using Win UI 3 Desktop template and I always see display name as 'WinUI Desktop' irrespective of what I have in manifest file.
Can any one suggest a way or workaround?

You need to set the Title property of your Window class. The title doesn't depend on any part of the app package under Win32

I think @WamWooWam is correct, however this is not exposed to markup and needs to be set from codebehind.

@StephenLPeters should this be exposed in XAML? If packaged apps have a manifest and the original title from folks coming from UWP was there should it look there? Or will UWP folks have to change their code to adapt here, is that expected?

uhm, I'm not sure, @MikeHillberg @Austin-Lamb and @marb2000 thoughts?

@WamWooWam : Thank you, it worked and will work as a work around. But I feel it should be set for packaged apps based on manifest file.

Great point @abhi-msft, the manifest for a packaged app should be the source of truth for icons and stuff too. It'd be good to know how this is supposed to work in both environments.

Another good point. @Austin-Lamb @marb2000

@abhi-msft I found that for many reasons it was easier for me to just completely remove the Win32 titlebar and border and add my own custom implementation in XAML.  It's much easier to control all of the content, but turned out to be most important when it came to handling DPI changed events.  There is a potential issue that I have not reported yet, but it has been on my TODO to consider reporting it.
Let's say that you want to provide a Window implementation that emulates WPF's SizeToContent feature.  With this feature, it provides the client area with the exact space it needs to render and no more.  This is a critically important feature when you want to show Window's that are borderless and have a transparent background.  If however, you leave the win32 non-client area intact (TitleBar) and a DPI change occurs, a DPI aware application will automatically scale the titlebar area.  When that area is scaled it either takes away from, or adds more space to, the client's area.  If you SizeToContent its obvious because the content will either not have enough space to render or there will be slightly too much because the Win32 TitleBar either steals space from it or adds back to it.
That's not the problem though.  The problem occurs when I reacted to the DPI changed event by scaling down or up the size of the Window to assure the space was just right.  Now, if you try to drag a Window from one DPI to another (let's say one monitor is scaled at 150% and the other normal), if done "just right" this will cause an infinite recursion of DPI Changed events.  I think the resizing of the Window during the DPI Changed event can cause it to resize such that the majority of the Window ends up back on the DPI that it was on before the event fired.  Then the event fires again, the code reacts by resizing the Window and forever and so on.  It will actually lock the entire application along with Visual Studio.  The only way to regain control of your computer is to kill the process.
So, I removed the Titlebar all-together and that problem no longer occurs.  Plus I can add my own icon, text, colors and etc.  I think the Window should be completely look-less so I designed some classes https://github.com/jtbrower/WinUI that can help others until WinUI has these features built-in someday.
I have been pretty busy trying to keep up and have yet to report the infinite DPI issue because I am not really sure whos problem that is anyway?  I tried my best to blame myself but I just couldn't find a way to change the Window size and guarantee that this infinite recursion wouldn't be hit.
One of the features I still need to code is how to have slightly rounded corners where the rounded off region is completely transparent.  I look forward to figuring that one out so I can try porting over more of my application.  It seems that many people are looking for this, but nobody has publicly shared how to do it yet.  If I figure it out you will be able to find it at the link I mentioned above.

I'm revisiting old issues and cleaning up a little the Windowing area in WinUI 3.
@abhi-msft and @michael-hawker, I got your request. Today, in Preview 4, it's possible to change the title of a Window setting up the Title property in the code-behind, and the icon can be changed using Win32 APIs (I wrote a sample in #4056). However, it doesn't honor the app package properties. This is a new feature to me, given it's a new behavior for a Win32 app. IMO, if the Window doesn't have a Title and Icon set, it should use the app package one. There is a workstream in Project Reunion that is creating a library for setting these properties properly, so let's send this feedback to them. I already did it internally.
I'm closing this question. Feel free to open a feature request if you want to or open again if you have more questions.

Thanks @marb2000 is there a corresponding Reunion issue open tracking the workstream you mentioned we can link to on GitHub?

@marb2000  for the icon it this works for me latest WinUi AppSdk          var hWnd = WinRT.Interop.WindowNative.GetWindowHandle(this);         WindowId windowId = Win32Interop.GetWindowIdFromWindow(hWnd);         appWindow = AppWindow.GetFromWindowId(windowId);         appWindow.SetIcon("Logo.ico");

logo.ico has the be in the root


Improve page index

fix bug and add account collapse
just one commit
make better index
add more stats and fix bugs
format code with black

Changes / 修改内容

如上。
Screenshots / 效果图

You See.
Necessity / 必要性

You know.
Checklist

[ ] Run sh scripts/test.sh, no tests failed.

If you changed the html templates or css/js, you must:

[ ] Paste screenshots.

If you changed the Python code, you must:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Run flask db upgrade, no error code is returned.

Codecov Report

Merging #20 (4d7ec5a) into master (2ac639e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   91.62%   91.64%   +0.02%
==========================================
  Files          39       39
  Lines        2711     2718       +7
  Branches      311      312       +1
==========================================
+ Hits         2484     2491       +7
  Misses        135      135
  Partials       92       92

Impacted Files
Coverage Δ

flog/main/views.py
86.36% <100.00%> (+0.08%)
:arrow_up:

flog/models.py
92.47% <100.00%> (+0.03%)
:arrow_up:

flog/user/views.py
88.59% <100.00%> (+0.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac639e...4d7ec5a. Read the comment docs.


Allow configuration to be passed to 'fluo oracle' & 'fluo worker' commands

The fluo oracle and fluo worker should be able to support the following syntax to override the configuration read from fluo-conn.properties:
fluo oracle <app> -p key1=value1,key2=value2
fluo oracle myapp -p fluo.connection.zookepers=localhost/fluo,fluo.connection.zookeeper.secret=mysecret

Instead of comma separate could do multiple options like maven and java.  With maven and java can specify -D multiple times.


Buttons (and maybe other components) are still colored when hovered but disabled

Hi,
It looks like the styling for hovered/active buttons takes precedence over that of disabled buttons. Normally that shouldn't be a problem since disabled buttons have pointer-events: none; but I found that on mobile at least, when tapping on a button, that button retains its color even if it is now disabled (until unfocused).
There's a pretty simple fix (just add :not(&-disabled):not([disabled]) for variants styling) and I would submit a pull request myself, but I don't know if you have a build file somewhere that generates this behaviour for all interactive elements.

I can't reproduce this issue.
Can you give me a code example of that disabled button (which has colors on mobile)?
Also, please mention your mobile OS and browser.

I'm closing this.
Please re-open after providing a code example.

You can try it out in the official documentation: https://daisyui.com/components/button/
If you open your inspector and manually toggle the "hover" state for the disabled buttons, you'll see that the button color changes. It's even more visible if the button has a variant class like btn-primary etc.
This isn't technically a mobile-only issue, it's just that tapping a button on mobile gives it the hover state, and it keeps it until you tap elsewhere, even if the button becomes disabled. I'm on Android 12, using Vivaldi 5.1 or Chrome 99.

(I can't re-open the issue myself.)


QUIC support?

What is your question?
Now that a whole 3 days have passed since merging QUIC support into Caddy (https://github.com/caddyserver/caddy/pull/2727), any plans to bring QUIC to certmagic? Would that even make sense or do the hooks already exist to use both?
Bonus: What do you use this package for, and does it help you?
Simple and free TLS, it's amazing! Thanks for your generous work.

I don't think it really makes sense to do so until HTTP/3 becomes standardized. No browsers even use it yet.
Will revisit this in a year or so. We'll see how things go.

Google Chrome, and Firefox added support since this closed. Still experimental, but I think we’re a lot closer than a year.
https://www.zdnet.com/article/cloudflare-google-chrome-and-firefox-add-http3-support/

@mholt Is there any documentation that shows how to accomplish using CertMagic with our own HTTP/3 listener?


HDFS-17071. Erasure coding: delete duplicated ec block with same block group id on one datanode.

Description of PR
please see HDFS-17071.
How was this patch tested?
Add an unit test.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 50s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
41m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 12 new + 85 unchanged - 0 fixed = 97 total (was 85)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 28s

the patch passed

+1 :green_heart:
shadedclient
40m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
232m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

390m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5814/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5814

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 00d565ae9659 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e12d70d357ff41fa3ec9b5f337af98493b02139a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5814/2/testReport/

Max. process+thread count
2326 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5814/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 39s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
36m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 12 new + 85 unchanged - 0 fixed = 97 total (was 85)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m  7s

the patch passed

+1 :green_heart:
shadedclient
36m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
260m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

404m 42s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5814/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5814

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 187502c12448 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e12d70d357ff41fa3ec9b5f337af98493b02139a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5814/3/testReport/

Max. process+thread count
2982 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5814/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Extended syntax for macro_block and a few other improvements

Hello,
First of all, thanks for a good library!
I wanted to use macros for common page components, and to my tastes block_macro syntax felt overly verbose for some use cases. So I've did a patch that allowed me to put short arguments in the tag declaration, while still fully enjoying all the macro_arg/macro_kwarg goodness for more arguments.
As an example, before this patch I had to write something like this:
{% macro_block modal  %}
    {% macro_arg %}mymodal{% endmacro_arg %}
    {% macro_arg %}

Here be dragons

    {% endmacro_arg %}
    {% macro_kwarg title %}Modal dialog{% endmacro_kwarg %}
{% endmacro_block %}

The syntax extension allowed me to have this instead:
{% macro_block modal "mymodal" title="Modal dialog" %}
    {% macro_arg %}

Here be dragons.

    {% endmacro_arg %}
{% endmacro_block %}

I've also did some refactoring, trying to eliminate nearly-duplicate code, reformatted macros.py to be more PEP8-compliant and implemented a check for extra content in macro_block, so there can't be anything besides argument tags and whitespace-only text nodes. Haven't touched any tests, though - sorry about this.
So... Here are my changes. Don't know if you'd like them or not, but offering those in hope they (or at least some of those commints) could be useful.
Thanks!

Thanks so much for all the work! I've merged your fork back into the master with the changes I've mentioned.


[Event Request] Codeunit 5407 Prod. Order Status Management

Please add a new Event in function CheckBeforeFinishProdOrder:

Event:
LOCAL [IntegrationEvent] OnCheckMissingConsumption(VAR ProductionOrder : Record "Production Order";VAR ProdOrderLine : Record "Prod. Order Line";VAR ProdOrderComp : Record "Prod. Order Component";VAR ShowWarning : Boolean)
Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Experimental Decorators error present with option set in config

Version 1.13.0-insider
Commit 3bb9b5314ef50bd8225aba0565cadc6ca19bc821
Date 2017-05-18T06:26:49.576Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0
Linux

This error appears even after adding the experimentalDecorators flag in .eslintrc
"parserOptions": {
    "ecmaVersion": 7,
    "ecmaFeatures": {
        "experimentalObjectRestSpread": true,
        "experimentalDecorators": true,
        "jsx": true
    },
    "sourceType": "module"
},

The error message comes from the JS support in VS Code (see [js] in the error message). ESlint errors are prefixed with [eslint].

This issue was moved to Microsoft/vscode#28097


Security Review suggests sanitizing input field

See https://docs.google.com/document/d/1PA8y9sLddKbyYgabK2l0Fjx3dGaf3l-HlTHR_vX3MRo
It suggests: sanitize input to health check text input to avoid XSS. The String '%22), ' will cause javascript to be executed

Wrong repo, but fixed by https://github.com/snowdrop/spring-boot-http-booster/pull/46


Option to invite users via Email

It would be great to have the ability for admins to invite other users to the repo to signup over mail.
Currently, we are doing this by sharing the repository URL and asking them to sign up but would be good to have an email invite option.

We can add an option to invitation signup mode. Enable invitation number in app.ini and default to zero.
We need a table to save the invitation emails and inviters. And when the signup mode is invitation, only the user whose email on that table could be registered successfully.

also interested in this! Thanks!

+1

Also interested

Interested in this, to avoid the stalebot from reaping it.

Hi, I'm trying to get a registered user to join the organization, but I can't find the way, can you tell me?

"Add team member invite by email #20307" got merged ... next things will be in v1.19.0 if somebody do take it - groundwork is done now

Does anyone object if I close this issue and open a new one with the new request (to enumerate number of invites)? The new request seems a bit different from the original issue.

@kdumontnu go on ... ps: link it to this issue :)


fix: Check for roundness undefined in restore.ts

null is a valid value for roundness. The current code treats null as "to-be restored".

null is a valid value for roundness. The current code treats null as "to-be restored".

It doesn't. null is a a fallback:

What issue are you facing?

the issue is restoring old drawings in Obsidian. I think the root cause is probably that in Obsidian when I added an image from the Vault it created the Image element with the strokeSharpness property set. In the past this had no effect, but now, when I open old drawings pictures load with round corners.
I am just going to keep this change in my fork and close this PR.


Bug: hyperlink markup doesn't work in game comments

https://gokibitz.com/kifu/rJLInRslZ

Yeah, I decided not to treat game comments as markdown since game comments are fundamentally a part of the SGF, and markdown isn't part of the SGF spec. I'd want someone to be able to load SGFs in any editor or site and still have them make sense.
So I do parse them and turn labels and certain keywords (like move 13) into interactive elements, but regular markdown won't work.

Yeah, my suggestion is a bit niche use case :)   I just wanted the "introduction" that I wrote to be at "the top" :)


Returns null where it should return .99

Hi,
I opened an issue about this in the npms main repo, but I have tracked it down to being an issue between this module as well as node-detect-repo-test-files (I'll be opening an issue there as well).
I've pulled both repos and tried locally and I can consistently reproduce the failure.
The repo in question is here: https://github.com/aliemteam/wp-graphql
Happy to help if needed. I'd like to be scored fairly.

Your module is using codecov which we do support. Need to investigate.

@satazor Looks like codecov isn't listed here: https://github.com/IndigoUnited/node-fetch-coverage/blob/master/index.js#L59
Could that be the issue?

Aha it seems so, we totally forgot to add codecov there.


Committed changes created by dbt fail to update with Fabric workspace git.

Description
When an existing dbt project is run against a Fabric warehouse in a git enabled workspace. Any models using the ref() macro will fail to update in a separate Warehouse when attempting to update via git. This appears to be due to the three part naming for models that exist in the Warehouse being unable to be found by the Fabric workspace git merge system.  I am unsure if this issue is a problem with the Fabric git merge system or with this library issuing the 3 part names for intra Warehouse references (I expect this depends on intended functionality in Fabric).
We have found a workaround by overriding the ref macro with:
{# macros/ref.sql #}

{% macro ref(model_name) %}

    {% do return(builtins.ref(model_name).include(database=false)) %}

{% endmacro %}

This works by removing the database name (The name of the Warehouse) which appears to confuse the Warehouse project git merge.
Steps to recreate:

Create a new empty warehouse (A) artifact in a Fabric workspace connected to git.
Target and run a dbt project with views that reference other entities within the warehouse.
Commit the new Warehouse changes to your branch in Workspace A
In a separate Workspace (B), link the same branch and attempt to update from the branch based on Workspace A
An error will appear saying the view with the references cannot find the source objects as they don't exist.

yo @timdenouden -- what's good!
I haven't looked too much into the issue here, just wanted to call out that there's still a gap in suport within SQL for three-part names for some commands. In those cases it's required to execute a USE {DATABSE}; statement first. Maybe something like that is going on?
@prdpsvs can share more here, but check out #161 and #166 for examples.

Hey @timdenouden , a question and suggestion.

Why do you maintain and link same branch with two different workspaces? This is not widely used pattern and have un-intended consequences when you try to apply git changes to workspace using "Update All" button.
Do workspace B DW item has references within the warehouse? If not, you need to run the dbt project targeting DW in Workspace B and then try to link the branch.

@dataders , if three-part naming is a problem, then the same problem must occur in Workspace A considering the name of the warehouse is same.

@timdenouden , do let me know if you still want to connect. I am closing this for now as this is not related to adapter. We can start a new conversation about this though


Enable Robot and Fleet Custom Resource Definitions for Federation

What would you like to be added?
After deployment and connection phases, operator should enable

robots.robot.roboscale.io CRD
fleets.fleet.roboscale.io CRD

for usage with Federation.
Other optional resources to enable

buildmanagers.robot.roboscale.io CRD
launchmanagers.robot.roboscale.io CRD
robotdevsuites.robot.roboscale.io CRD
robottemplates.robot.roboscale.io CRD
metricscollectors.robot.roboscale.io CRD

Why is this needed?
It's needed to operate cloud powered robot from one host, which is federation host.

Source repositories:

robolaunch Robot Operator
robolaunch Fleet Operator


'exportloopref' is deprecated

Problem
On v2.x
$ make lint
--> Running golangci-lint
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

Proposal
Resolve the warning

Hi team,
I'm interested in working on this issue. Could you please assign it to me?

I've done this issue.

Looks resolved to me on v2.x:
$ make lint
--> Running golangci-lint
--> Running markdownlint
--> Running hadolint
--> Running yamllint


Modal doesn't open without popper.min.js

Modal component doesn't  work without including popper.min.js before bootstrap.js, console shows the error "Bootstrap dropdown require Popper.js"
Bootstrap v4

Indeed Bootstrap depends on Popper.js for our Tooltips/Dropdown and Popovers plugins.
@XhmikosR what do you think about moving this test : https://github.com/twbs/bootstrap/blob/v4-dev/js/src/tooltip.js#L15-L21 in our plugins constructor ?
Because folks who don't need to use those components, should be able to do that without this error

@Johann-S: wouldn't then throw for people who don't want to use those components?
How about we have an extra global var like needsPopper and act accordingly in our constructor?

Nope people we'll only see this error if they are trying to use our Dropdowns/Tooltips or Popovers
seems a bit redundant because we can simply check if Popper is available or not

@Johann-S: please make a PR and CC me.

Finally it seems we have no solution here (see : https://github.com/twbs/bootstrap/pull/24306)
so @m01key you have to add Popper.js because 3 of our plugins use it or you can wait for our next release which will add a new dist file with Popper.js inside

Either we do what I suggested and throw in the constructor if a component which requires popper is used, or we leave it as it. Otherwise it will throw an error even though one might not use a popper descendant component.

Maybe I don't see how you'll do that but for me it wont change anything because our plugins are wrapped into IIFE ended with : })($, Popper)

True that. Not sure if there's another way to do things, but with our current implementation I don't think we can do a lot.

true, it's hard to add optional dep :worried:

Maybe instead of throwing an error we should just use console.warn ? @XhmikosR


Refactor Actions

With yet another feature addition to actions (ids of complex-options steps, ids of simple options is not necessary as those can be directly serializable), it's about time to make a significant refactoring of the actions system (yet again).

Include in type object if action is serialized or deserialized (or maybe use one type that contains both as much as possible?)

Avoid copy-pasted code here and there (DslGameSystem, various different DSL-classes)

Refactor RulesActionTypeComplexNext and RulesActionTypeComplexNextOnly

Cleanup ActionTypeImplEntry, ActionInfo, FrontendActionInfo, ActionOptionsResult, and more...

This has been partially done now.

DslGameSystem is still a bit messy.
Might occur duplicates in various DSL-classes.


Allow translations reload during serve

Hello,
I wrote this little bit of code to allow a function to be passed in the translations property. With the help of the events triggered by 11ty, I can reload the translations before every build in serve or watch mode.

Thanks for the suggestion, @izanagi1995. Certainly getting translations to update without the need to restart the serve would be ideal.
There's an open issue related to this, which would ensure that the file (required in project's .eleventy.js config) reloads as one would expect: https://github.com/11ty/eleventy/issues/1312. Would love for that to be fixed at the library level, without having to bake workarounds into the plugin, so keeping a keen eye on the upcoming v1 release.
In terms of the PR, perhaps making the translations object dual-purpose (i.e. function or object) is a little ambiguous, API-wise? Do you have an example of what you'd call in your project's translations() plugin option to get the desired result?
I wonder if perhaps an explicit onBeforeWatch option for the plugin might be a promising approach.

Hi @adamduncan,
Thanks for the feedback. Having the issue fixed in Eleventy is a great news.
About the usage, I have several JSON files containing the translations for a lot of pages. I load them in a function using fs and combine the JSONs into a single objects as eleventy-plugin-i18n expects it. But it can be used in any other way (like pulling from an API).
I also understand the ambiguity of making the translations dual-purpose. However, this is a simple addition, so it doesn't break the current usage while keeping the API simple. if this is not a great idea for you, what about adding a new property called translationsFn which clearly indicates a function. But it would require an assertion to make sure one and only one translation property is used.
Exposing onBeforeWatch is not a great idea imho. It would add complexity to configure the plugin for not a lot of use cases.

Thanks for more info. I see where you're coming from. Would like to put a bit more thought into this one. Not sure workarounds in the API are the right approach just yet, in lieu of https://github.com/11ty/eleventy/issues/1312. I'll give it some more thought, if you're happy using your forked version for now 👍

Exposing onBeforeWatch is not a great idea imho.

Yep, fair point.

Alright, I hope that https://github.com/11ty/eleventy/issues/1312 will be solved soon (open for almost a year now). During that time, I will try to use my fork.

I deleted the repo by mistake. I asked GitHub to restore the repo


One param less in ClientSession subscribe method

subscribe method of ClientSession class has a param named topicFilter. topicFilter has no other use than for logging. Because when I was trying to work on #186 and tried to figure out why the test was failing, I looked into the subscribe method of the client in the broker to see if it was really overriding and all. Then I stumbled upon the unit test and tried to break the test by changing the value of topicFilter. Clearly it was giving me no different result.
So that's why I basically removed it as I thought it'd be better and less confusing (not to mention it serves no real purpose in my opinion because you can get the topicFilter from the Subscription object).
Also moved the unit test as was asked for in the TODO comment.

It's a thing I was thinking to fix sometimes ago, well done


Andriibrunch PR

Checklists
General Checks

[x] the branch is up to date with main/master
[x] the code works when pulled and run locally
[x] All CI checks pass
[x] all conflicts are resolved (if any)
[x] PR has a descriptive title
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] It is in the appropriate column in the project board (if necessary)
[x] has short and clear description
[ ] is linked to an issue (if it is related)
[ ] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[x] the markdown source is formatted
[x] spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] all links and images work
[x] any embedded code snippets are formatted

Sorry i just had stuck but when i find solution dont have time to add my info)))As i did before my introduce file so add info about me))Now its should looks better))


Add precompiles to reduce startup latency

hmm did you test this? It didn't seem to reduce latency for first print for me


.FORWARDHELPTARGETNAME: cannot forward to ABOUT

Steps to reproduce
FUNCTION NEW-EVIDENCE {
# .FORWARDHELPTARGETNAME ABOUT_COMMENT_BASED_HELP
HELP ABOUT_COMMENT_BASED_HELP -S
}
HELP NEW-EVIDENCE -S

Expected behavior
ABOUT COMMENT BASED HELP

Actual behavior
Synopsis

Syntax

Environment data

Name                           Value
----                           -----
PSVersion                      7.0.3
PSEdition                      Core
GitCommitId                    7.0.3
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

It seems that HelpFileHelpProvider should implement ProcessForwardedHelp.

What's the use case for making a command's help redirect to an about_? Usually it's used for proxy commands (and remoting I think).

It is not my use case but everyone seems to want just that.  See the referenced PR.

What PR? I don't see any references.

@vexx32 it's right above my comment, #13176.  They want it for prompt which I understand on one hand but... it really only makes sense for prompt and even then only kinda.

Github must be having issues, I don't see it at all. 😄
But yeah, prompt is a bit of a special case in that it's designed for users to override it in the first place. Doesn't make a lot of sense for anything else IMO.

In other words, PROMPT is a callback.  If we ever have another callback, we are going to bump into the same problem.

In other words, PROMPT is a callback. If we ever have another callback, we are going to bump into the same problem.

It's a callback that is intended to be able to be called by anyone who needs to display (or otherwise retrieve) the user's prompt string.  That's why it should be documented as any other command imo, with just a "also see" link to about_Prompts.  Same for TabExpansion2 which is a similar callback (with an even stronger case since it has parameters).

OTOH, maybe we never get another one, as PROMPT itself should an event handler for Idle rather than a callback.

All the prompt function does is return a string, the caller is responsible for how it's displayed.  It can't be an event handler because it doesn't make sense for multiple handlers to be registered, and it wouldn't be able to be raised outside of the event handler class.
Also not important but it doesn't get invoked on Idle.  When and how it's invoked is determined by the current PSHost typically.  Fun fact, the OnIdle event will actually fire even in the middle of PSConsoleReadLine.ReadLine.

That's why it should be documented as any other command imo, with just a "also see" link to about_Prompts.

Sure, I almost said it myself.  I failed to convince anyone though.  I find myself lacking your clarity of expression 🙁

.FORWARDHELPTARGETNAME cannot forward to content that does not have a HelpUri. About topics don't have HelpUris because they are text files and not compiled into MAML.

I fail to get the connexion, given that HelpUri is for remote help.  Moreover, I boldly claim to have identified the part that is missing, and it does not have anything to do with HelpUri either.  But if you are right, fixing it would require #8230.

@yecril71pl You are probably right about the HelpUri. The real issue is that About files are text files and not compiled into MAML.

I am sorry, this one is also real, as long as the people in power insist on having this particular redirect in place,


Installation problems

Hello Dominik,
when I tried to install the cnsr package under Windows11, the installation froze ... even after an hour of waiting nothing happened. Can you help with this? Maybe I've just made a mistake. You know we use the Anaconda distribution ...

Was the installation triggered by clicking on the app symbol (Kachel) or manually? If the former, yoj are running into the exact same problem I had with the app...

YES. Does this mean that the Anaconda distribution under Windows is not well suited for the cnsr package and that we should always install and run it via a terminal?

By "manual", I do mean either terminal or by selecting it from the package list in the Anaconda UI and install it (like we also did when I visited). Basically, anything but the app symbol. For now, you should advertise these two ways to your users and I would expect both of them to work. Concerning the app, I will try to find help from Anaconda/conda-forge people.


Secure Send address input should auto-focus on next input form when typing

Frequency: 100%
** Repro App version:** Celo integration build v1.8.2 (37)
**Repro on device:**iPhone XS max (13.1)
Pre-condition: Recipients should have two verified accounts with the same phone number  to initiate the send security fow.
Repro Steps:

Launch app and sign up in the app
Tap on send button
select contact
Tap on Confirm account number
Make sure user should on “Please confirm contact account page
Enter text on box and observe cursor should not move automatically

Suggestion: Cursor should move automatically to next box once enter text is first box
Attachment: Cursorshouldmove.mp4 (Bug observed at 04 sec)

[ ] Should also replace the word "digits" with "characters"

The behavior is different in Android, it's necessary a full account instead of the last digits.

Hi @Pedro-vk we have verified this issue on latest Android internal build V1.15.0 & Testflight build V1.15.0(63) and observe the followings
iOS:

As per the new changes user is able to see Full account number filed on iOS so, issue got fixed.

Android:

Input cursor not auto focusing on next input when user typing. Attachment
Thanks!

@Celoqa please, give me access to the attachment. Thanks 😊

Sorry for the inconvenience @Pedro-vk can you please check now i have given access.

There was an issue pushing the code, I'll open a PR soon

Thanks @Pedro-vk for quick looking into it.
Please let us know when you open a PR>

This is the PR: https://github.com/celo-org/wallet/pull/449


Atomic storage API

Please make sure these boxes are checked, before submitting a new PR.

[x] You ran the local CI checker with ./check.sh with no errors
[x] You reference which issue is being closed in the PR text (if applicable)
[x] You updated the OmniPaxos book (if applicable)

Issues
Fix #97, Fix #49
Breaking Changes

TheStorage trait has been reworked to facilitate atomic writes and allow for arbitrary crash-recovery. The indices passed to these functions now refer to the indices of the entry log as if no trimming or snapshotting has happened.
PersistentStorage and its config structs have been reworked to use RocksDB and implement the new Storage trait. The dependence on commitlog is therefore gone, addressing issue #49.
All indices are now of type usize instead of u64. This includes the indices used in the Storage trait, Message structs, and Omnipaxos public functions.
Both Storage::get_promise implementations in the omnipaxos_storage module now return None instead of the default Ballot when there is no promise ballot saved in storage.
The batch_accept feature flag has been removed and is now the default behavior.
The Promise, AcceptSync, and AcceptDecide message struct fields have been changed.

Other Changes

MemoryStorage now implements the new Storage trait but its implementation of write_atomically does not guarantee atomicity (acceptable since memory can't persist state through crash-recovery).
Batched entries are now correctly flushed when reconfiguring and when deciding entries.
The syncing behavior in the the prepare phase in now consistent between both leaders and followers.

After our discussion yesterday, I looked at the current code to see how we can keep as much as possible of the current batching and at the same time introduce transaction for atomic storage. I think what we need is a struct InternalStorageTxn for InternalStorage. This is to enable the clean transaction object API in the Sequence Paxos code. When we handle the InternalStorageTxn in InternalStorage, we will know which entries to actually flush. And based on that we will create the real transaction for storage. So something like this:
// transaction object for InternalStorage
struct InternalStorageTxn {
    state_ops: Vec<StateOp>, // StateOp is an enum for modifying accepted_round, decided_idx, etc.
    append_op: AppendOp,       // AppendOp is an enum for append, append_on_prefix, etc.
    snapshot: Option<(usize, S)>  // snapshot index and snapshot
}

// handle_acceptsync() in SequencePaxos
let state_ops = vec![StorageOp::AcceptedRound(4), StorageOp::DecidedIdx(10)];
let append_op = AppendOp::AppendOnPrefix(accsync.sync_idx, accsync.suffix);
let internal_txn = InternalStorageTxn {state_ops, append_ops, ..};
self.internal_storage.do_txn(internal_txn);

// do_txn(it: InternalStorageTxn) in InternalStorage
let append_res = match it.append_op {
    Append(entries, do_batching) if do_batching => self.state_cache.append_entries(entries),
    Append(entries, do_batching) if !do_batching => self.state_cache.append_entries_without_batching(entries),
    // ... AppendOnPrefix etc.
};
let mut txn = StorageTxn::new();  // transaction object for Storage
txn.insert(it.state_ops);
if let Some(entries_to_be_flushed) = append_res {
    txn.insert(StorageOp::Append(entries_to_be_flushed));
}
if let Some((idx, snapshot)) = it.snapshot {
    txn.insert(StorageOp::Snapshot(idx, snapshot));
}
self.state_cache.real_log_len = self.storage.flush(txn)?;
Ok(self.get_accepted_idx())

All indices are now of type usize instead of u64. This includes the indices used in the Storage trait, Message structs, and Omnipaxos public functions.

I couldn't find the reason for this anywhere. It seems unfortunate to effectively constrain omnipaxos to 64-bit systems.
Using 32-bit ids and assuming 150_000 ops/s (taken from the EuroSys'23 paper quoted in the readme). Would give approximately 8 hours until the 32-bit id is exhausted...
Am I missing something obvious / what is the reason for this change?

The change is not performance-related but rather for API reasons, we wanted reading from the omnipaxos log to be similar to the Rust Vec API.
Since it is now usize, the user should be able to use it with any compatible system.

That makes sense ergonomics wise, my concern would be that a system with a 32bit architecture and one with a 64bit architecture could not be part of the same cluster. Or, for that matter any 32 bit system could exhause the 32bit log index in reasonable time.


Add functionality to restrict number of parallel runs for a workflow

Need to add new capability to restrict number of parallel running orchestration instances based on some configurable variable say 'max_active_runs'
E.g:
We have an orchestrator function called workflowOrchestrator.
WorkflowId1-1234567 is one orchestration instance.
WorkflowId2-7346382 is another orchestration instance.
Then If max_active_runs set for WorkflowId1 is 1 then no more than 1 instance should be able to spin up for that. That essentially means that there should not be another running instance of WorkflowOrchestrator with instanceId
WorkflowId1-< random number >. New instance for WorkflowId1 should eventually spin up only when WorkflowId1-1234567 is completed i.e once current active instances for a workflow is less than max_active_runs then only new instance should spin up.
However, if there is no such limitation on WorkflowId2, then any number of workflow orchestrators should be able to spin up with instanceIds Workflow2-< random number >

We don't have any such controls at the host level. However, It is possible to implement this manually using singleton orchestrations.
For example, you could write a "WorkflowId1-manager" singleton orchestration which is responsible for scheduling all "WorkflowId1-XXX" workflows as sub-orchestrations. You could use that max_active_runs variable from inside "WorkflowId1-manager" to configure how many sub-orchestrations can run concurrently, and write the logic necessary to schedule new instances when old instances complete, etc.


Inability to set printer attribute job-password

Hi,
I'm working on a printer service and i'm trying to access a printers' (Canon) SECURE PRINT function by setting these attributes
 attributeMap["job-attributes"] = "job-password:octetString:123#job-password-encryption:keyword:none";
I get this error at CUPS admin (ver 2.2.12) when i try to print
"src = job.c, line = 1385, log = none of secured print password and username"
When i check /var/spool/cups i can see all the attributes set except from job-password attribute hence the error.
Please help.
Error at CUPS

/var/spool/cups

@gitneo How are you specifying the job-password value on the CUPS client?
What version of CUPS are you using?
What operating system is the client using?

Hi,
I'm using
CUPS 2.2.12.
The client operating system
NAME="Oracle Linux Server"
VERSION="7.5"
job-password specification on client,
job-password:octetString:12345
The complete line of code includes the job-password-encryption and requesting-user-name.
printAttributes["job-attributes"] =
      "job-password:octetString:12345#job-password-encryption:keyword:none#requesting-user-name:name:GITNEO";

@gitneo I'm not sure how you are submitting jobs, as the code you are including is NOT the CUPS API.
But I can guess from the context that you are passing job-password and job-password-encryption in the job-attributes group, but they MUST be provided in the operation attributes group. They are security attributes and not part of the job ticket...


[BUG] Fetcher Exceptions Not Being Caught

Source: https://kotlinlang.slack.com/archives/C06007Z01HU/p1713182804285859

Figured out that this was due to an exception when calling store.fresh(Key) since fresh filters out Loading and NoNewData, grabs the first element, then calls requireData Since the data was an error it threw an exception


Add readme to the master branch

I'm from Russia and my English ain't so perfect so @crutchcorn please do that after the source will be cleaned.

I did it! ;P Hehe. Will improve when the source is cleaned

Ah, okay! I didn't see that :smiley:

The source is cleaned. Improve the readme if you want :+1:

Will do


Apply MCA to another Dataset to Predict the values

Hello,
I was wondering if you could help me with my problem.
How can I apply my fitted MCA to another dataset and predict the values on the axes?
Thanks in advance

Hello there 👋
I apologise for not answering earlier. I was not maintaining Prince anymore. However, I have just refactored the entire codebase. This refactoring should have fixed many bugs.
I don’t have time and energy to check if this fixes your issue, but there is a good chance it does. Feel free to reopen this issue if the problem persists after installing the new version — that is, version 0.8.0 and onwards.


wav2vec fairseq dependency

solution:
pip install fairseq

Updated the fairseq dependency, can't find any other solution as the .pt requires fairseq to load it.


WIP - Special Coverage Redesign

Coverage decreased (-0.3%) to 85.582% when pulling a97ff6e4cd1b972b35911649350db56da7ebf0ff on avc-sc into 0ab7cf7adaa2dbe8bd4692f26d5fefc45a68e259 on master.

Coverage decreased (-0.2%) to 85.622% when pulling dcb65a68fa3ad6472df14dc9e69670eb5f7fbf35 on avc-sc into 0ab7cf7adaa2dbe8bd4692f26d5fefc45a68e259 on master.

Coverage decreased (-0.2%) to 85.614% when pulling 08112a4a3122b3b023d5f783b5172440eacb822d on avc-sc into ae78d9fca5781d5446672e7f9e44500c4c1fd869 on master.

Coverage decreased (-0.03%) to 85.815% when pulling b58021e10877d2b41086d4224df7223b42158650 on avc-sc into ae78d9fca5781d5446672e7f9e44500c4c1fd869 on master.

Coverage decreased (-0.3%) to 85.583% when pulling 72edbc4c7dc81e4f2bf3b21abf6eac3ffc1464c2 on avc-sc into 1ba8f0c95502f952d01617188e947346959a7e30 on master.

Coverage decreased (-0.2%) to 85.7% when pulling 72edbc4c7dc81e4f2bf3b21abf6eac3ffc1464c2 on avc-sc into 1ba8f0c95502f952d01617188e947346959a7e30 on master.

Coverage decreased (-0.2%) to 85.7% when pulling 72edbc4c7dc81e4f2bf3b21abf6eac3ffc1464c2 on avc-sc into 1ba8f0c95502f952d01617188e947346959a7e30 on master.

Coverage decreased (-0.3%) to 85.583% when pulling 230015c7a4e959e96c77dcdefd2e18ddaa137875 on avc-sc into 1ba8f0c95502f952d01617188e947346959a7e30 on master.

LGTM


WIP : passes E0 and rin0cuts correctly

This PR is to pass E0s and rin0cuts to the new ace model argument correctly. Two questions:

What format do we want to support for passing E0s to ace_model? I would imaging sticking to the old format would be the best for compatibility.
Are there use cases where the pair basis can have different cut off from the many body basis?

What format do we want to support for passing E0s to ace_model? I would imaging sticking to the old format would be the best for compatibility.

Yes, I agree. The more we can keep the interface compatible with the old one the better.

Are there use cases where the pair basis can have different cut off from the many body basis?

Yes. But I don't think this is urgent. One of the next steps in the near future will be to rewrite the new ACE models as a stack of calculators, (1) a reference model, e.g. OneBody but maybe more - could include ZBL; (2) an arbitrary pair potentia; (3) a many-body potential. But could also be several many-body potentials ... I suggest to postpone changes to the pair potential cutoff until then.


Failed to build wit-abi executable

When converting the wasi-nn proposal over to the new WASI proposal template (https://github.com/WebAssembly/wasi-nn/pull/17), I added this GitHub action because it was a part of wasi-filesystem, which I used as an example. The action fails to install the wit-abi executable, though: https://github.com/WebAssembly/wasi-nn/runs/7010889446?check_suite_focus=true#step:3:211. I suspect this may be due to updates to wit-abi (maybe https://github.com/WebAssembly/wasi-tools/pull/3?) but no new Git tag.
I can attempt to fix this but wanted to record this here for @sunfishcode and @alexcrichton. How do we expect this action to work? Do we need to publish a new Git tag in wit-abi and then a similar tag in this action to keep things in sync?

I think this was fixed in https://github.com/WebAssembly/wit-abi-up-to-date/pull/3 which should be under the v3 tag, which I believe can be done by updating this line

This is fixed by https://github.com/WebAssembly/wasi-tools/issues/4.


[#15043][Docs] Updated the copyright year from 2020 to 2023

Hi @yzh119 @Hzfengsy
This is a minor PR and it aims to update the copyright year from 2020 to 2023. I would appreciate that if you can help to review/manage it, thanks.
#15043

Seems the footer of https://tvm.apache.org/ is not changed in this PR.

Hi @yzh119
I thought the footer is here. Please correct me if I am wrong.
https://github.com/apache/tvm/pull/15071/files#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3R595

Hi @cchung100m , the text in the footer is "2020 Apache Software Foundation" and "Copyright © 2020 The Apache Software Foundation", and I think this PR fixes year 2022 to 2023 which do not involve 2020.

Hi @cchung100m , the text in the footer is "2020 Apache Software Foundation" and "Copyright © 2020 The Apache Software Foundation", and I think this PR fixes year 2022 to 2023 which do not involve 2020.

Hi @yzh119
Thanks for the prompt reply. I search the whole project and did not see the 2020. Is it possible that the website page with copyright year 2020 is cached somewhere?

Seems the website is hosted in another project, and you can create another PR to https://github.com/apache/tvm-site and change these two lines:
https://github.com/apache/tvm-site/blob/c0c11309c181a0e86a896d2d9b0508c92480980a/_layouts/default.html#L41
https://github.com/apache/tvm-site/blob/c0c11309c181a0e86a896d2d9b0508c92480980a/_layouts/default.html#L49

Seems the website is hosted in another project, and you can create another PR to https://github.com/apache/tvm-site and change these two lines: https://github.com/apache/tvm-site/blob/c0c11309c181a0e86a896d2d9b0508c92480980a/_layouts/default.html#L41 https://github.com/apache/tvm-site/blob/c0c11309c181a0e86a896d2d9b0508c92480980a/_layouts/default.html#L49

Hi @yzh119
Thanks for your friendly reminder and I will submit another PR for it.

Hi @yzh119
The failed built jobs seem that irrelevant to this PR. If convenient, may I ask how to solve it?

It appears that the VTA CI is not functioning properly. @cchung100m, would you kindly refrain from making changes in the "3rdparty/vta-hw" directory? Ideally, we should avoid altering the contents of any submodules.

Hi @yzh119
Thanks for the kindly reminder and I updated the part you mentioned.


[ Add ] Editorconfig

Separated from #77 on request
Adds basic formatting hints for most editors

Hi @PhoneDroid thank you for splitting your work in two separate PRs! Given this file is more of a personal configuration file rather than something everyone should use I'm going to close this PR. You can add it to a global gitignore file to keep it in the repo for personal use.


add mmcv.jit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Task linked: CU-5brfzp MMDet support JIT decorator


Add Firebase JavaScripts to the execution iframe if Firebase is used.

The primary change here is that we sometimes add <script> tags pointing to Firebase, if it looks like Firebase is being used. But it comes with other changes.

Firebase cannot be loaded via require.js because of an issue with DDC. See this comment forward: https://github.com/dart-lang/sdk/issues/33979#issuecomment-557721076
Firebase also needs to be loaded before require.js or the app will complain that firebase is not loaded.
require.js was previously always loaded via a static <script> tag in the execution iframe's <head>.
In order to avoid always loading the Firebase SDKs into the execution iframe, we must also stop loading require.js by default.
This change creates a new workflow for building up the execution frame for a Flutter Web app:

Replace HTML and CSS.
If the Firebase SDKs are needed, load them.
If the app being loaded is Flutter Web, load require.js.
After require.js is loaded, replace the user JavaScript tag with the new compiled JavaScript app.

This is ready for review, but I will not merge until I do a few things:

[ ] integration testing?
[ ] manual testing:

[ ] run a Firebase app, then an HTML app, then a Firebase app
[ ] run a Firebase app, then a Flutter app, then a Firebase app
[ ] run an HTML app, then a Flutter app, then an HTML app
[ ] run a Flutter app, then a Firebase app, then a Flutter app
[ ] run a Firebase app, then the same Firebase app
[ ] run a Flutter app, then the same Flutter app

Sorry for the merge conflicts... we renamed "codelabs" to "workshops" everywhere

Conflicts handled! I think this is ready to merge. I've manually tested it and I think its good.


Security: Configure monitoring to fire alert if mandatory Kyma resource is failing to install

Description
Kyma CR in the KCP gives an overview of the SKR's state, we would need to monitor whether the Kyma changes from the KCP can be propagated into the SKR and if not - fire an appropriate alert.
Since SKRs are under the total control of the Customers, we need to rely on the resource in the KCP. There may be cases in which the Kyma CR in the SKR was removed, those should not invoke alerts. For the second case - if the Lifecycle Manager fails to push the Kyma changes into the SKR, an alert should be raised.
Monitoring and alerting rules for specific Kyma Modules should be shipped as a part of their charts.
Steps to exploit
Block a synchronization process between the KCP's Kyma CR and the one in the SKR.
Proposed mitigation

[ ] Monitoring for the KCP cluster has to be configured which is firing an alert if a critical/mandatory Kyma resource errored out and could not be recovered within a certain time span.

@ebensom : could imagine that it's better to address this task by SREs monitoring solution. What is your opinion?

Since removing the Kyma CR from the SKR cluster is a use-case we should rather set up the monitoring in the KCP cluster to fire an alert only when the Kyma CR is in the error status and cannot be recreated in the SKR.

Depends on: https://github.com/kyma-project/lifecycle-manager/issues/380

Tracked under https://github.tools.sap/kyma/backlog/issues/3911

@janmedrek Feel free to close in favor of the above issue.


fix(behavior_path): remove refineGoal which is never executed from the node and fix the function

Description

refineGoal in behavior path planner node do nothing

this function return orinal input goal, if goal is in goal_lanelet
goal can not be set out of lane

In this PR, I fixed this function which never executed, and skip it from behavior path planner node.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I will approve this PR if the test is passed.

this PR is reverted in https://github.com/autowarefoundation/autoware.universe/pull/2485
refineGoal is for the parking scenario.


Interface exp

Further interface expansion. Adds:

load_file
get_adjacencies
type_from_handle
get_child_meshsets
add_child_meshset
get_root_set --> @vijaysm I'd like you to take a look at the implementation for that one
get_coords
get_entities_by_type
get_entities_by_type_and_tag --> this one required some changes to the current pymoab Tag class and the addition of a TagArray class

These are all being added in the anticipation of replacing iMesh in PyNE

Hey @Pshriwise what version of MOAB are you using? I seem to be on v4.8.1 and I can't even get master to compile locally.

MOAB's latest release is 4.9.0 and in couple of days, that should become
4.9.1. So if possible, we should keep this synced with MOAB builds.
I can look at adding one or two nightly buildbot tests for PyMOAB.
@Pshriwise would this help ?
On Mon, Jan 18, 2016 at 3:44 PM, Anthony Scopatz<EMAIL_ADDRESS>wrote:

Hey @Pshriwise https://github.com/Pshriwise what version of MOAB are
you using? I seem to be on v4.8.1 and I can't even get master to compile
locally.
—
Reply to this email directly or view it on GitHub
https://github.com/scopatz/pymoab/pull/15#issuecomment-172662236.

@scopatz what error are you getting? I just built with 4.8.1. No problems. Did you link the TagInfo header into the include/moab/ directory? This is still an issue (#1) we have not settled yet.
@vijaysm that would be extremely helpful!

Wait, so where does the TagInfo header actually live?

here I believe

Patrick, the problem with installing TagInfo is that it forward
declares private objects such as SequenceManager (which
doesn't/shouldn't need to be installed), and also exposes library-wise
internal calls (that access SequenceManager directly). These routines
can really destroy performance if available as a public API for users
and I think Tim made the design choice to not install TagInfo and
SequenceManager. I'm unsure how this was handled previously in PyTAPS
to see if that can help.
On Tue, Jan 19, 2016 at 10:45 PM, Patrick Shriwise
<EMAIL_ADDRESS>wrote:

here I believe
—
Reply to this email directly or view it on GitHub.

I see. That's a very good reason not to install the TagInfo header. The current solution is one that @scopatz and I came up with on the fly. I should be open to other options as well. One suggestion from @gonuke was to incorporate pymoab into moab itself to give it access to these headers. This would make testing straight forward as well. Thoughts?
I'll take a look in pytaps today to see how this issue is handled there.

Hi all, I think we need to come up with a way to solve this because otherwise we can't have CI, we can't test, etc.  Not actually having to do any of the work @gonuke's suggestion is attractive.

I do not have a problem with integrating PyMOAB directly into MOAB sources
as long as there is a nice separation of concerns. I just don't want to
make the moab repo polluted for those users who do not need python
interfaces. If there are ideas on how to do this, will be very interested.
@pshriwise @scopatz we could create a fork of MOAB and use subtree
semantics to bring the repo along with all commit messages. But let's
discuss layout and design first.
On Jan 25, 2016 6:27 PM, "Anthony Scopatz"<EMAIL_ADDRESS>wrote:

Hi all, I think we need to come up with a way to solve this because
otherwise we can't have CI, we can't test, etc. Not actually having to do
any of the work @gonuke https://github.com/gonuke's suggestion is
attractive.
—
Reply to this email directly or view it on GitHub
https://github.com/scopatz/pymoab/pull/15#issuecomment-174782829.

I don't think I am qualified to make a judgement yet.  I would think it would be relatively easy to add an --enable-python flag or some such to the build system, such that the binding were built if Python were detected and/or if it was requested explicitly.

I have some code to help out with this with CMake scattered throughout PyNE et al.

Hey all! This one's been open for a while now.
Vijay and I have talked offline and we agreed that moving pymoab into MOAB is a good plan for the build process so long as MOAB is okay with taking on the necessary dependencies that come with the python interface which became a part of the discussion here.
But as far as the additions to this PR, how are we looking?

Patrick, the PR looks good to me. I think the tests are a good start and we can certainly add more later.
Regarding the merge to MOAB, let me play with some sample use cases. For PyMOAB, other than MOAB, numpy and Cython, are there any other dependencies ? I'm thinking of just adding a target to autoconf configure to say --with-python and it will configure PyMOAB with the shared MOAB installation. Perhaps that may not be optimal and I'm open to suggestions here.

ping @scopatz

Vijay, there are some other equally common python packages needed to actually build and install pymoab such as setuptools, libcpp, sys, and os. When adding this to MOAB we should make sure that ensuring these packages are available and installing them if they aren't as part of the build.

Sure we can do a configuration check if these packages are available in the standard python path. But installing them ?! I don't want to do that. There are many modes for this and I'd rather not do something here automatically, without knowing how the user has things setup. For example, with sudo, or virtualenv or brew/port or something else ..
Unless you are talking about installing something in a sandbox folder, within the build directory ? Not sure how to go about that either..

That is so true. I misspoke. A configuration check would be best. Outside of that we'll just need to make it clear that the python interface will require a few additional dependencies and report missing ones if they aren't found during the configuration step.

Any further comments on this @scopatz @vijaysm?
Going to merge in the interest of progress if not...

closing now that this project has become part of MOAB proper http://sigma.mcs.anl.gov/moab-library/

Sounds good! Should we add something to this repo's readme about how development has moved?


"Cannot find module 'eslint-plugin-react'" when trying to run standard

What version of standard?
Not sure, I assume latest. Below error appears event when trying to run what I pressume should be a version command (standard -v or standard -V)
What operating system, Node.js, and npm version?
macOS Sierra 10.12.6, v11.1.0, 6.9.0 respectively
What did you expect to happen?
I assume a list of things that didn't meet standard's standard
What actually happened?
standard: Unexpected linter output:

Error: Failed to load plugin 'react' declared in '--config » eslint-config-standard-jsx': Cannot find module 'eslint-plugin-react'
Require stack:
{ ... }
If you think this is a bug in `standard`, open an issue: https://github.com/standard/standard/issues

Let me know if you need the full output within { ... }
I have already tried installing eslint and eslint-plugin-react globally but that did nothing.

Thanks for the issue. There is a bug right now where standard doesn't work when installed globally. Looking into it now.

This should be fixed in standard 13.0.2.

Just bumped into this issue here:
"eslint": "^6.7.2",
"eslint-config-prettier": "^4.3.0",
"eslint-config-standard": "^14.1.0",
"eslint-plugin-import": "^2.19.1",
"eslint-plugin-node": "^10.0.0",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-react": "^7.17.0",
"eslint-plugin-standard": "^4.0.1"


[Blog] Image link is not clickable

Title
[Blog] Image link is not clickable
Platform / OS
Windows 10
Browser
Microsoft Edge / IE
Description
The large portion of the image link is not clickable. There is only a small spot at the bottom that can be click that will direct user towards the article page.
Steps to Reproduce

Launch website using Microsoft Edge / IE as the browser
Go to Blog page and try clicking on the image

Expected Behavior
User will be directed towards the article page if image is clicked
Additional Info
Only the marked section is clickable

@mop13 have fixed the other little blog issue (https://github.com/sleepbusorg/sleepbus.org/issues/83) as I'm doing this related task  (https://github.com/sleepbusorg/sleepbus.org/issues/94)
Regarding this issue with Edge/Win10, could you please do some debugging and see if you can fashion a fix by inspecting/editing HTML within Edge? I unfamiliar with dev tools available on Edge and I won't have access to a convenient Win10/Edge VM for at least a few days.
My guess is malformed HTML...

@thekaruna - do you have an Edge instance handy to test? We do have a Browserstack account free for a year for non-profits/open source, which I'll share with you guys, too...

won't fix. low traffic to these pages, other link generally clickable. redesign imminent


Reload the grid manually when you clear a filter

Is there a possibility to manually load the grid data (refresh/reload without filters) when we clear a filter off?

Thanks

It refreshes / reloads when filters are cleared. Your issue is about cascading, which is not actually supported for quick filters. Attach to change event and clear the city filter when it is cleared.


Use TensorRT 20.03 as base container for builds

Description

Change replaces pytorch 20.03 with tensorrt 20.03
as base container for trtorch builds.

Adds locale setting as no locale was set by default leading to build failure.

Signed-off-by: Shashank Verma<EMAIL_ADDRESS>Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation and have regenerated the documentation (make html in docsrc)
[ ] I have added tests to verify my fix or my feature
[ ] New and existing unit tests pass locally with my changes

Reassign to @mengdih to review. Thanks!

Reviewed, LGTM.


Split up collections router

Will allow adding data products endpoints before the collections admin endpoints
Also simplifies method metadata declarations slightly

Codecov upload failing again


Send segment in worker threads

To avoid blocking main thread and failling with system call errors in main thread.

https://github.com/taiki45/aws-xray/pull/60


Associations

Support associations between collections.
Lotus::Model::Mapper.new do
  collection :articles do
    # ...
    association :comments, [Comment]
  end

  collection :comments do
    # ...
    association :article, Article, foreign_key: :article_id
  end
end

The first association is 1-n, where an article has many comments. The [] syntax specifies this.
The second association is n-1, where a comment belongs to an article (lack of []). The foreign_key should be optional and only specified when the following convention isn't respected: association name + _id. In the example above: article + _id.
Associations MUST NOT be loaded by default, but they require an explicit intervention via the preload method (which should be implemented as part of this feature).
class ArticleRepository
  include Lotus::Repository

  def self.by_author(author)
    query do
      where(author_id: author.id)
    end.preload(:comments)
  end
end

IMPORTANT: Let the preload mechanisms to not work with SQL joins, but with repositories instead. This isn't efficient, but we have a gain in terms of flexibility. Imagine the the scenario where the comments above aren't stored in the local database, but fetched from a remote JSON API. Thanks to the mapper we can easily know where to fetch those comments.

Is it official part of lotus model?
If yes, why its not mentioned in Readme?

No, it isn't
El 30/03/2015 18:16, "Extazystas"<EMAIL_ADDRESS>escribió:

Is it official part of lotus model?
If yes, why its not mentioned in Readme?
--
Reply to this email directly or view it on GitHub
https://github.com/lotus/model/issues/35#issuecomment-87739198.

How would associations work for the insert/remove workflow (adding a comment to/removing a comment from an article)? I guess there'd be no support from lotus/model as it's only a "stupid" ruby object?
About the syntax for declaring assocations:
Defining associations with/without []to indicate has many/ belongs to seems a bit limited (as @coenert already pointed out with the has one case (foreign key on the other end)). I'd prefer something more speaking, like the inline version from @coenert.
Sidenote:
I'm new to lotus and doing a lot of Rails currently

@pascalbetz Thank you for your opinion. The workflow for add/remove associated records is something under discussion. We're trying to apply a simple design her. :smile:

@jodosha
If i understand correctly:
associations are just "stupid" getters/setters. So there is no syncing between the foreign key attribute and the association?
(pseudocode)
article = Article(id: 1, ....)
p article.user_id => nil

user = User(id: 10, ...)

article.user = user
p article.user_id => 10

I guess you don't want to autogenerate methods like
def user=(user)
  self.user_id= user.try(:id)
  @user = user
end

on the entity?

@coenert
Wouldn't the collection/fk/... options be arguments to belongs_to? (assuming belongs_to is a method which returns a type which represents the association)
attribute :author, belongs_to(User, collection: :users, foreign_key: :author_id)

@pascalbetz Probably, but now after some time i think my suggested api isn't in any way simpeler to understand then the one @jodosha initially suggested. I think i missed the point of creating less magic DSL's to reduce complexity(still learning :smile:)

@coenert
The proposed API by @jodosha might hit some limits though (has and belongs to many, has many through).
How about
attribute :user_id, Integer...
belongs_to :user, User, foreign_key: :user_id, ...
has_many :comments, Comment

Pretty much like Rails does it. Just keep the associated class as the second argument.

Sir, Any updates on this issue ?

@kirantpatil we are in the cycle of improving model so please stay tuned.

Are you still in the cycle of improving Model? I'm missing any sort of relations between tables.

@Defman21 Yup. @jodosha is working on changing the backend of hanami-model to use Ruby Object Mapper (rom). He's started it on the new-engine branch, so you can check it out there, but it's in progress and the docs don't reflect the changes.

I'm happy to see that there's some work going on for solving this issue :)

In lieu of hanami-model, what would be the downsides of just straight-up using rom? What will hanami-model provide that rom doesn't right now?

hanami-model will provide more conventional usage than "plain rom" which comes with various conveniences like model inference, auto-timestamps, auto-field renaming etc. Pretty much what you would expect from a full-stack framework.

attribute :author, belongs_to(User, collection: :users, foreign_key: :author_id)
returns error uninitialized constant Book::User (NameError) -- why
in db it is working correctly

@senei Please open a separate issue.

@senei Where did you found that syntax? And where it is used?

I'm closing this in favor of future, smaller, focused, and actionable proposals.


[5.3] Fix column overlaping on withCount

Fixes #16645
Current wrong result for this function:
{
    "id": 4,
    "name": "Administrator",
    "description": "Some description here",
    "created_at": "2016-12-20 22:53:47",
    "updated_at": "2016-12-20 22:53:47",
    "role_id": "2",
    "user_id": "9",
    "permissions_count": "4",
    "pivot": {
        "user_id": "9",
        "role_id": "2"
    }
}

New result:
{
    "id": 2,
    "name": "Administrator",
    "description": "Some description here",
    "created_at": "2016-12-20 22:53:47",
    "updated_at": "2016-12-20 22:53:47",
    "permissions_count": "4",
    "pivot": {
        "user_id": "9",
        "role_id": "2"
    }
}

Notice the ID changed and it removed the inner join columns from the query, they are inside the pivot only now...
Repo for testing purposes:
https://github.com/cabalopolis/with-count-bug.
Not sure maybe we should target 5.4...
This probably isn't the best fix but at least this should be a place for eventual discussion 😄
IMO we should maybe fix these namespace issues globally, there's more issues open about these things, check #16704 for example, maybe we should handle this when compiling the joins? Not sure what's the best approach here, if there is actually, we could just warn people about it...

Ping @cabalopolis, @KKSzymanowski

@fernandobandeira I'll take a look tomorrow morning.


Re-run does not work correctly for parameterized suites

If parameterized suite goes to re-run then all rerun entries for all data sets are reported into one data set

Fixed in f8fc39258951


Initialize output of soss::json::to_json with empty object

This returns {} instead of null for empty (no fields) messages, e.g. std_srvs/Trigger requests.

Thanks for helping out with this edge case :bow:


Use Clang for more reliable sysroot-handling

I think we'll end up diverging in the aspect of build configuration for the time being, because we need support for cross-compiling based on sysroots best supported by Clang, while the original project uses standalone GCC cross-compilers (more on the topic here).

Once we get this right we could definitely look at contributing it to the community along with sysroots that determine a compatibility baseline. However, this will likely spur non-trivial discussions.


scroll to position

How can I scroll to position parentPosition and childPosisiton smoothly?

Good question, it seems that we don't currently support the ability to do this because any scrollTo method will take the flat position list (the position if you were to think of the expanded items to be in one continuous list).
In order to support this we will need to change getFlatParentPosition to public and provide a getFlatChildPosition(int, int). I'll mark this as an enhancement.


51 add eslint rule for spaces within object brackets 2

This PR fixes #51 (adds eslint rule for spaces within object brackets) and applies the new rule to files which are violating it. Also the indentation is fixed in some files.

Retry DeepCode


Navigator animations based on iPhones initial width and not updated on device rotation

When using a Navigator on iPad the animations correctly take into consideration the app width changes when the device rotates or split screen is started. On iPhone this isn't the case. The Navigator animations are always be based on the width at app launch. If you launch the app in Portrait and then rotate the phone to Landscape the animations stop early. If you launch the app in Landscape and then rotate the phone to Portrait the animations continue off the edge of the screen.

Sorry this is a duplicate of #2111


error when requesting quartz/index

I use
    compile 'org.grails.plugins:quartz:2.0.4'
    compile 'org.grails.plugins:quartz-monitor:1.3'

on my Grails 3.1.1 (also tested with 3.0.17) build and get following Exception when requesting the monitor-pages:
Cannot get property 'jobGroupNames' on null object. Stacktrace follows:
java.lang.NullPointerException: Cannot get property 'jobGroupNames' on null object
	at grails.plugins.quartz.QuartzController$_closure2.doCall(QuartzController.groovy:22) ~[quartz-monitor-1.3.jar:na]
	at grails.plugin.springsecurity.web.filter.GrailsAnonymousAuthenticationFilter.doFilter(GrailsAnonymousAuthenticationFilter.groovy:53) ~[spring-security-core-3.0.4.jar:na]
	at grails.plugin.springsecurity.web.authentication.logout.MutableLogoutFilter.doFilter(MutableLogoutFilter.groovy:62) ~[spring-security-core-3.0.4.jar:na]
	at grails.plugin.springsecurity.web.SecurityRequestHolderFilter.doFilter(SecurityRequestHolderFilter.groovy:58) ~[spring-security-core-3.0.4.jar:na]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[na:1.8.0_73]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) ~[na:1.8.0_73]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_73]```

You're right, something was broken in 2.0.3 (fine in 2.0.2) and got fixed again by 2.0.8. Are you able to use a different quartz version?

There is another problem with the Quartz plugin that forced me to use this Version:
https://github.com/grails-plugins/grails-quartz/issues/64
I will try to downgrade to Version 2.0.2


/zq prints out all Zaishen quests

Pointed out the features of /zb /zm etc. to some people in a dungeon and one of them suggested /zq to print out all of them in fell swoop.
Small but sounded like a good idea so I'm submitting.

so
/zq 5
to print the next 5?

Negative.
I mean current days Zaishen quests
Typing /zq would print out
/zb
/zc
/zm
/zv
In one single fell swoop, so just 4 lines of text.

/today

Ah okay, y that sounds cool

/today

Oh my, didn't know this one existed. Yeah that covers it :P


chore(ci): re-enable husky commit linting

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fixes for 3.1 and without admin styles

This pull request fixes the following issues:

BEFORE
AFTER

:+1:


make plugin compatible with CM6 / obsidian 0.15.4+

closes #11

I'm sorry, I completely forgot about this PR. The plugin is fixed now, though.


Expanding the documentation of the Taxonomy Development Tools

Description
This epic ticket contains all the issues related to the improvement of the documentation of the Taxonomy Development Tools.
Currently the issues are divided in the following themes below.
New issues and themes will be added as needed. Open to discussion.
Updating pre-exiting documentations

Updating the user interface guide
#120
#104
#44

Expanding new documentation

Add a general document of the overview of the Taxonomies
#115
Add How-to-guides
#109
#111
#121

Implementing the feedback of the BICAN team

See user stories
#98
#99
#100
#101
#102
#103

@dosumis @hkir-dev


Right Click Menu: Foreground Media Menu

Context
Right Click Menu work. Designs
Summary
Adding the foreground image menu. Right clicking on any media that is not a background image will open this menu.
Relevant Technical Choices

To-do

[x] Finish actions
[x] Add tests
[x] Fix old failing tests 😭

User-facing changes

Forward and Back Actions
Setting Page Background
Scale and Crop

Reading the menu using voiceover:

Testing Instructions

Turn on the context menu experiment
Create a new story
Add several pieces of media to the canvas (images, videos, gifs, etc)
Right click on an image.
Should be able to move media layers forward and back. Should not be able to move it below the background layer. Should not be able to move above the top layer.
Should be able to set an image as a page background. Doing this again will remove the previous background from the canvas.
Should be able to open the scale & crop UI

QA

[x] This is a non-user-facing change and requires no QA

Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
no
Does this PR have a legal-related impact?
no
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6136

Curious, I can't remember, were the copy and paste working in the context menu before this? or nah? they're currently not working on my local, but not sure if it's a regression, or they just have'n't been implemented yet. It doesn't look like any of your changes would of effected it tho so probably a different ticket if it is a regression

Copy/Paste/Clear are separate - these are actions on all menus and seemed like a good thing to descope some of the other issues 😅  : https://github.com/google/web-stories-wp/issues/7871


InfiniteScroll is broken

InfiniteScroll start to fetch data in begining and continue even if no data is returned.

Was this introduced in main page updates, or has it always been a problem?

Not exactly, in main page branch everything worked fine. But after merge with the latest master it broke.

@gregsheremeta Also it can freeze whole application. Thus I think it is not medium task.


ActionController::RoutingError (No route matches [GET] "/verify"):

Hello,
I often add rollbar to my projects without problems but this time it is not working:
Rails 5.2.0.rc1 (I have already been able to make Rollbar work in another rails 5.2.0.rc1 project).
When I run rake rollbar:test, I have an error (bellow).
Running via Spring preloader in process 85529
Testing manual report...
Setting up the controller.
Processing...
Started GET "/verify" for  at 2018-03-06 18:19:26 +0700
Cannot render console from ! Allowed networks: <IP_ADDRESS>, ::1, <IP_ADDRESS>/<IP_ADDRESS>

ActionController::RoutingError (No route matches [GET] "/verify"):

actionpack (5.2.0.rc1) lib/action_dispatch/middleware/debug_exceptions.rb:65:in `call'
rollbar (2.15.5) lib/rollbar/middleware/rails/show_exceptions.rb:22:in `call_with_rollbar'
web-console (3.5.1) lib/web_console/middleware.rb:135:in `call_app'
web-console (3.5.1) lib/web_console/middleware.rb:20:in `block in call'
web-console (3.5.1) lib/web_console/middleware.rb:18:in `catch'
web-console (3.5.1) lib/web_console/middleware.rb:18:in `call'
actionpack (5.2.0.rc1) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
railties (5.2.0.rc1) lib/rails/rack/logger.rb:38:in `call_app'
railties (5.2.0.rc1) lib/rails/rack/logger.rb:26:in `block in call'
activesupport (5.2.0.rc1) lib/active_support/tagged_logging.rb:71:in `block in tagged'
activesupport (5.2.0.rc1) lib/active_support/tagged_logging.rb:28:in `tagged'
activesupport (5.2.0.rc1) lib/active_support/tagged_logging.rb:71:in `tagged'
railties (5.2.0.rc1) lib/rails/rack/logger.rb:26:in `call'
sprockets-rails (3.2.1) lib/sprockets/rails/quiet_assets.rb:13:in `call'
actionpack (5.2.0.rc1) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
actionpack (5.2.0.rc1) lib/action_dispatch/middleware/request_id.rb:27:in `call'
rack (2.0.4) lib/rack/method_override.rb:22:in `call'
rack (2.0.4) lib/rack/runtime.rb:22:in `call'
activesupport (5.2.0.rc1) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
actionpack (5.2.0.rc1) lib/action_dispatch/middleware/executor.rb:14:in `call'
rack-livereload (0.3.16) lib/rack/livereload.rb:23:in `_call'
rack-livereload (0.3.16) lib/rack/livereload.rb:14:in `call'
actionpack (5.2.0.rc1) lib/action_dispatch/middleware/static.rb:127:in `call'
rack (2.0.4) lib/rack/sendfile.rb:111:in `call'
webpacker (3.3.0) lib/webpacker/dev_server_proxy.rb:18:in `perform_request'
rack-proxy (0.6.4) lib/rack/proxy.rb:57:in `call'
railties (5.2.0.rc1) lib/rails/engine.rb:524:in `call'
rollbar (2.15.5) lib/rollbar/rake_tasks.rb:86:in `block (2 levels) in <top (required)>'
rake (12.3.0) lib/rake/task.rb:251:in `block in execute'
rake (12.3.0) lib/rake/task.rb:251:in `each'
rake (12.3.0) lib/rake/task.rb:251:in `execute'
rake (12.3.0) lib/rake/task.rb:195:in `block in invoke_with_call_chain'
/usr/local/Cellar/rbenv/1.1.1/versions/2.5.0/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
rake (12.3.0) lib/rake/task.rb:188:in `invoke_with_call_chain'
rake (12.3.0) lib/rake/task.rb:181:in `invoke'
rake (12.3.0) lib/rake/application.rb:160:in `invoke_task'
rake (12.3.0) lib/rake/application.rb:116:in `block (2 levels) in top_level'
rake (12.3.0) lib/rake/application.rb:116:in `each'
rake (12.3.0) lib/rake/application.rb:116:in `block in top_level'
rake (12.3.0) lib/rake/application.rb:125:in `run_with_threads'
rake (12.3.0) lib/rake/application.rb:110:in `top_level'
rake (12.3.0) lib/rake/application.rb:83:in `block in run'
rake (12.3.0) lib/rake/application.rb:186:in `standard_exception_handling'
rake (12.3.0) lib/rake/application.rb:80:in `run'
bin/rake:9:in `<top (required)>'
activesupport (5.2.0.rc1) lib/active_support/dependencies.rb:277:in `load'
activesupport (5.2.0.rc1) lib/active_support/dependencies.rb:277:in `block in load'
activesupport (5.2.0.rc1) lib/active_support/dependencies.rb:249:in `load_dependency'
activesupport (5.2.0.rc1) lib/active_support/dependencies.rb:277:in `load'
/usr/local/Cellar/rbenv/1.1.1/versions/2.5.0/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
/usr/local/Cellar/rbenv/1.1.1/versions/2.5.0/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
-e:1:in `<main>'
Test failed! You may have a configuration issue, or you could be using a gem that's blocking the test. Contact<EMAIL_ADDRESS>if you need help troubleshooting.

When I generate an error in the app, nothing shows up in Rollbar dashboard.

Anybody know what is the problem?
Thank you

@ArturMoczulski Could you take a look into this?

Same problem here.
Rails 5.2
Ruby 2.5.1
Any hints?
(Not a very good start... )

Hi there, I couldn't reproduce the problem with a fresh installation of rails5.2 and ruby 2.5.1. Can you try that in your environments?
We'd need more information to try to resolve this issue. Running bundle exec rake middleware and pasting the output might help to identify if a middleware can be causing a problem. Also, if there is some special configuration related to the routes, hosts, etc...it'd be nice to know.

I'm going to close this issue pending feedback from one of the participants.

I am facing the same issue using Rails API.

@damienlethiec @filipemenezes @thermistor
Thank you for these reports. I have not been able to reproduce, even when using exactly Rails 5.2.0.rc1, and ensuring that spring is running and routes are loaded before running the rake task. I have considered it might be related to an earlier version of spring, but spring has been at 2.0.2 since well before Rails 5.2.0 and the initial issue report.
If you are using a different spring version, or if there is anything notable about your config that hasn't been discussed yet, let me know.

@damienlethiec @filipemenezes @thermistor
We have a fix now. See https://github.com/rollbar/rollbar-gem/pull/816, or try setting config.cache_classes == true in your Rails config.
I discovered that my problems reproducing were caused by using bundle exec rake rather than bin/rake, so that is a workaround as well.

Nice work

@thermistor thank you for mentioning spring.