Reuse code for parsing integer slices from string

There are several places in the codebase (CLI folders) where we ad-hoc write parsing of a comma-delimited string into []uint64 ro []sdk.Int. We should have a single method we call for this, not ad-hoc implemented in line.
The function for []uint64 is written here: https://github.com/osmosis-labs/osmosis/blob/834238839bee9126a85aed1f63e3fa36887fbd00/cmd/osmosisd/cmd/balances_from_state_export.go#L343-L358
We should move that function and write one for SDK.Int in
https://github.com/osmosis-labs/osmosis/blob/main/osmotestutils/cli_helpers.go
We should then switch balances_from_state_export, and pool incentives CLI's to use this.
This is implemented in-line in the pool-incentives CLI code here: https://github.com/osmosis-labs/osmosis/blob/main/x/pool-incentives/client/cli/tx.go#L49-L69 & https://github.com/osmosis-labs/osmosis/blob/main/x/pool-incentives/client/cli/tx.go#L143-L163

Looking into this...

Oups sorry, I forgot to say I was on this as well.

Ok, no worries @iButcat

@ValarDragon, Hi, I think that's good, can you review my PR please ?


added code for mapping thru project data into single component, creat…

…ed css for styling all content within portfolio, coded pop out screenshots, need to work on overflow issues/icon for deployment.

pop out screenshots are commented out for now until overflow is fixed


OpenComposite build failure

Problematic commit: https://gitlab.com/znixian/OpenOVR/-/commit/80b4a24c3f2391977156c98ab8974297a9a71774
Report: https://gitlab.com/znixian/OpenOVR/-/issues/426#note_2134793358

Potential fix: https://gitlab.com/znixian/OpenOVR/-/merge_requests/140

Fox was merged. Waiting to see if it successfully builds

Fixed.


Metadata Aware retrieval

Does Cognita Support advanced RAG techniques like Vectorindex Auto -retrievers, where the LLM extracts metadata features from the query to make Vector Search more enriched with query filters

You can add these in the query controller section logic similar to contextual compression retrievers or multi-query retriever logic. These questions are better suited as discussions, rather than issues.


Syntax highlighting for selectors with variables in multiline text does not work

See the image below for an example:

Fix published at the version 1.0.0 🚀


Some of the first tests written depend on the in-memory count of 14 w…

…ork items - these tests should be removed and should eventually be replaced with query tests for numbers of work items that match queries.

Can one of the admins verify this patch?

[test]

Current coverage is 68.00% (diff: 100%)

Merging #511 into master will not change coverage

@@             master       #511   diff @@
==========================================
  Files            27         27
  Lines          1266       1266
  Methods         269        269
  Messages          0          0
  Branches        250        250
==========================================
  Hits            861        861
  Misses          405        405
  Partials          0          0

Powered by Codecov. Last update a0f3fa0...c03b7d8


Cannot load latest (v1.1) nsfw_model from local file

I currently have the latest nsfw_model found at https://github.com/GantMan/nsfw_model/releases/tag/1.1.0 and am trying to load it as a local file like so:
const model = await nsfw.load('file://' + __dirname + '/mobilenet_v2_140_224/web_model_quantized/');

However this results in the following error:
(node:28129) UnhandledPromiseRejectionWarning: Error: layer: Improper config format: (LARGE JSON OBJECT HERE).
'className' and 'config' must set.

I tried the solution found in #397, specifically this comment, however when running npm install<EMAIL_ADDRESS>I get:
npm ERR!
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@tensorflow/tfjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/nsfwjs
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/jon/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jon/.npm/_logs/2021-05-07T15_30_17_117Z-debug.logcode ERESOLVE

Running npm install<EMAIL_ADDRESS>--force works to install that version but then the load function fails to load a local file, saying only absolute URLs are supported
@tensorflow/tfjs-node: ^3.6.1
nsfwjs: ^2.4.0

I seem to have found the issue while making the demo repo (which honestly was only going to be like 3 lines of code)
I was following the "NodeJS App" example here https://github.com/infinitered/nsfwjs#node-js-app which only says to pass in the path to the model folder
However with the latest nsfw_model it seems to need you to pass in { type: 'graph' } into the options? This seems to have loaded the model correctly and it does seem to classify correctly still
Maybe this should be better explained in the README and examples? It wasn't immediately obvious that I needed to pass in this option to get the local files to work, especially since when looking at the source of this module it doesn't pass that option...?

Hi RedDuck, I tried the following:
_model = await nsfw.load('.\models\2020-03-04 - nsfw_mobilenet_v2_140_224\mobilenet_v2_140_224\web_model', "{ type: 'graph' }")
But I get this error:
Cannot create property 'size' on string '{ type: 'graph' }'
How did you pass in the { type: 'graph' } option?
Thanks,
Fidel

Oh, never mind :)
This worked:
_model = await nsfw.load('file://' + __dirname + '/models/2020-03-04 - nsfw_mobilenet_v2_140_224/mobilenet_v2_140_224/web_model/', { type: 'graph', })

Please feel free to contribute back to the docs. It's easy to forget to update them, and your experience from the outside is valuable to others who come in and use the docs.

Sure, I can do that. How would the best way to do that be? Just make a PR for the readme to add { type: 'graph' }?

Yup!  And any additional context.

Just checking in on this ticket.


[WIP] openMP

Submission Checklist

[X] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[X] Declare copyright holder and open-source license: see below

Summary:
Not ready yet, but this allows multi-threading in reverse mode for probability-based functions.
Intended Effect:
Go faster
How to Verify:
Needs speed tests for a variety of operating systems and compilers
Side Effects:
Larger executables
Documentation:
None, but you just put
CXXFLAGS += -fopenmp
OMP_NUM_THREADS = 8

into make/local and use any modern compiler except the one that comes with Xcode.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Trustees of Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

This is awesome! Is there any way to abstract these +#pragma omp parallel for if (N > 3 * omp_get_max_threads()) default(none) shared (signs, n_vec) out so we're not typing all of that all over the place?

I am in the process of converting 3 * omp_get_max_threads() to OMP_TRIGGER

omp_get_max_threads() where OMP_TRIGGER is 3 (for now) unless otherwise
defined (at compile time), but no, I don't see how we avoid the typing. I
guess you could have a macro that generates

#pragma omp parallel for if (N > 3 * omp_get_max_threads()) default(none)
but the rest of the syntax is specific to that particular loop.
On Thu, Mar 15, 2018 at 3:06 PM, seantalts<EMAIL_ADDRESS>wrote:

This is awesome! Is there any way to abstract these +#pragma omp parallel
for if (N > 3 * omp_get_max_threads()) default(none) shared (signs, n_vec)
out so we're not typing all of that all over the place?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/800#issuecomment-373489408, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqlW65NjAGODtaiyXM54f4VwuhQ0Sks5tervGgaJpZM4SsS9r
.

@bob-carpenter Is this pattern safe to implement in apply_scalar_unary.hpp?

I'm not sure what all this OpenMP stuff does.
If it's all working on double values, I don't see a problem assuming everything does what it looks like it does (parallelizes the computation, then reduces using +=).
If you look in stan/math/prim/mat/vectorize/apply_scalar_unary.hpp, you'll see that it's just a single templated implementation.  If you specialized that for double and int arguments, then it could be parallelized in the same way as the other functions.

With apply_scalar_unary.hpp there is no += at the end, but a function like
exp(vector_v) is calling exp() on each element of vector_v, which is
pulling out value_of() and composing a new var. So, I guess it comes down
to whether there can be a race or an ordering problem if the new vars get
composed at virtually the same time in an unpredictable sequence?
On Thu, Mar 15, 2018 at 11:21 PM, Bob Carpenter<EMAIL_ADDRESS>wrote:

I'm not sure what all this OpenMP stuff does.
If it's all working on double values, I don't see a problem assuming
everything does what it looks like it does (parallelizes the computation,
then reduces using +=).
If you look in stan/math/prim/mat/vectorize/apply_scalar_unary.hpp,
you'll see that it's just a single templated implementation. If you
specialized that for double and int arguments, then it could be
parallelized in the same way as the other functions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/800#issuecomment-373591886, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqiw0U1n1zHp-eHoZJvsygVdcj6gMks5tey-4gaJpZM4SsS9r
.

None of the autodiff primitives are atomic, so I think there are potential race conditions pretty much everywhere.  The worst is in the memory manager allocating new memory, where we could potentially leave dangling memory structures.

Do we have an idea how openMP interacts with the recently introduced thread_local AD stack? Do openMP threads now trigger new AD tree copies if STAN_THREADS is defined?

I suspect there is no interaction with the thread_local AD stack because
the openMP stuff is currently only applied in _lpdf, _lpmf, _cdf, _lcdf,
and _lccdf functions where the internal calculations are in doubles and
combined with operands_and_partials.
On Sun, Apr 29, 2018 at 11:06 AM, wds15<EMAIL_ADDRESS>wrote:

Do we have an idea how openMP interacts with the recently introduced
thread_local AD stack? Do openMP threads now trigger new AD tree copies if
STAN_THREADS is defined?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/800#issuecomment-385257891, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqs8MU1V8s7okYeelf6lxxERS9Bl6ks5ttdcAgaJpZM4SsS9r
.

Hi!
I looking into alternatives for this type of parallelization using C++11. I got rather, but I am running into a problem which I think you have as well in this branch. Take for example this code block. There we are adding to one edge of the ops_partials in the loop over the terms. Now, all is fine whenever we have one lambda for every data item. In that case the edge is represented by a vector of size equal to the data and each partial is term-wise. All good. However, whenever lambda is a scalar then the edge points to a scalar and then we have a problem. In this case we are concurrently adding terms to the same scalar. I do not think that this is ok to do. For one, concurrent updating of the same double from different threads sounds like a bad idea and in addition we loose exact reproducibility. We would need to form the sums in a chunked way or make the partial atomic (which is probably not ideal for performance).
I still think this type of approach is very attractive to give users with many cores some speedups for large models (since one would just switch it on and there would be no need for any recoding), but we need to solve this issue.
Best,
Sebastian

... one solution could be to build up one ops_partial per thread. These would then be summed together at the end of the function. This should scale ok as we endup having just a handful of ops_partials. Just and idea.

Right that we can't concurrently update a single value.  If we don't, we lose a lot of the advantages of vectorization.
We could certainly go into custom implementations and parallelize things differently.  There are many independent calculations we could find in the code.

for reference, here are some very related benchmark results on discourse.
In short, I think that this PR would need some more work which I do not even think is really worthwhile doing given that we have map_rect MPI parallelism (from the cases I looked at). Certainly, there is a convenience for users to just switch on this type of parallelization.
A problem which this PR probably also would need to address is how accumulation is done in a fully reproducible manner in cases when we add all partials into a single term.
Maybe we close this one?

I think that this PR would need some more work which I do not even think is really worthwhile doing given that we have map_rect MPI parallelism

That's not how I'd look at it. This already has tons of *_lpdfs, *_lcdfs, etc. It might have everything I just haven't looked through it. The bulk of the work is done here, I think.

If you think different and want to work on this, please do! It looked dead to me here. However, what would be important to me is to ensure exact reproducibility (in some form) and what I think we need to address is the possibility that we do concurrent addition operations to the same double value from different threads.
For example, here, if lambda is a scalar, then we will add up in the for loop to the same element from different threads concurrently. This pattern is all over in our codebase and we should make that thread safe by making the accumulation per thread and then accumulate the result from each thread together. I am not sure how this is handled in the openMP case here.

want to work on this

I do not, haha.

ensure exact reproducibility

I disagree with this in passing.

(in some form)

I agree with this in passing.

I am not sure how this is handled in the openMP case here.

This is what the reduction stuff handles in the openmp pragmas: https://github.com/stan-dev/math/pull/800/files#diff-177540cb83d43e41ef133da0b4cf6b18R113
I'm not a huge fan of openmp. It looks kinda crude, but it gets the job done and it's exactly suited for the types of computation we're talking about here. Also I think @bgoodri did all the work already haha.
I dunno how this performs vs the C++11 stuff. Maybe better? Maybe worse? You should run your benchmarks on this and see what the numbers look like, cause I think @bgoodri implemented the necessary stuff.

We talked about this at a meeting recently and it seemed like there wasn’t
a great reason to continue with openMP given the compilation process and
what we get for free from C++11. Can someone outline the use case for this
against map rect with threads for me? Without knowing that I’ll just say
that I suspect we will 1) prefer user controlled parallelism (for a couple
of reasons I can go into if needed) 2) with less compilation hassle when
possible.
I also thought we wanted reproducibility...?
On Wed, Aug 8, 2018 at 10:16 Ben Bales<EMAIL_ADDRESS>wrote:

want to work on this
I do not, haha.
ensure exact reproducibility
I disagree with this in passing.
(in some form)
I agree with this in passing.
I am not sure how this is handled in the openMP case here.
This is what the reduction stuff handles in the openmp pragmas:
https://github.com/stan-dev/math/pull/800/files#diff-177540cb83d43e41ef133da0b4cf6b18R113
I'm not a huge fan of openmp. It looks kinda crude, but it gets the job
done and it's exactly suited for the types of computation we're talking
about here. Also I think @bgoodri https://github.com/bgoodri did all
the work already haha.
I dunno how this performs vs the C++11 stuff. Maybe better? Maybe worse?
You should run your benchmarks on this and see what the numbers look like,
cause I think @bgoodri https://github.com/bgoodri implemented the
necessary stuff.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/800#issuecomment-411325778, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7Fp_oE2clHnheVkt0v7vWYFR_9x_ks5uOp5YgaJpZM4SsS9r
.

--
Laboriously extracted via diminutive keyboard

We talked about this at a meeting recently and it seemed like there wasn’t a great reason to continue.

I musta skipped that meeting. I just didn't want this pull to get trashed. If @bgoodri is okay with it going away, I am too. I just felt like it deserved a 3rd party counter-argument given the state of the pull req.

with openMP given the compilation process and what we get for free from C++11

OpenMP is a flag and C++11 is a flag, at least in gcc. OpenMP has a link component as well, but I've never had to install external libraries to get it to work before? It seems pretty free to me. Maybe this has changed. It looks like it's a little different with clang.
OpenMP is coded in comments (for good and bad). The good part is that it can be freely ignored by compilers that don't support it and the code works.

Can someone outline the use case for this against map rect with threads for me?

This looks complete and OpenMP is built to solve exactly these sorts of parallelization problems (you have a for loop that does a bunch of lightweight stuff in parallel, and you want to accumulate it all in one output variable).
I guess the OpenMP version doesn't include poisson_log_lpmf, so so much for my completeness argument, but just compare the code in the two versions:
OpenMP: https://github.com/stan-dev/math/blob/eaf5e67aaa5229f04480b5a12bc1e7a4df4572c9/stan/math/prim/scal/prob/poisson_lpmf.hpp
C++11: https://github.com/stan-dev/math/blob/904bbe572e4c21103714588cca60b97341e4734b/stan/math/prim/scal/prob/poisson_log_lpmf.hpp
If parallelizing lpdfs/lpmfs was the goal, then I think the first thing does it.

Maybe it makes sense to discuss this once more then in the meeting. I have performed a few benchmarks which do show (to me + for the cases tested) that map_rect will give you similar performance gains at the price of a bigger burden on the user to code it.
My conclusion from that is that we should concentrate on tools to make calling map_rect easier. This would mean to provide utilities for packing and unpacking data. This will give us a better ROI in terms of what our user base can do with Stan - at least this would be my judgement, but we should discuss this in a meeting probably.
That would mean to provide packing+unpacking tools for regular and ragged arrays into the formats as needed by map_rect. The alternative is to wait for tuples...
...and yes, two meetings ago we discussed openMP vs C++11 and I think we agreed on preferring C++11 since it is a language standard.

If OpenMP is supported by all of our supported compilers (I thought it wasn't) then I have much less of an objection. But also,

If parallelizing lpdfs/lpmfs was the goal, then I think the first thing does it.

I think the goal is to help users run models more quickly, here by leveraging their hardware. OpenMP could help with that, but I have some doubts about something that users can't control being the mechanism we ultimately want. Having written a language that tried to automatically parallelize user queries, it turned out to be a really difficult task partially because it's difficult to figure out which pieces of the program will turn out to take the most time, even though users typically have a good guess. I suspect half decent user-driven parallelization to beat default lpdf parallelization. Plus that default lpdf parallelization will likely not nest kindly with any user-driven stuff (applies to both OpenMP and threads as far as I know).

On Aug 8, 2018, at 9:55 AM, wds15<EMAIL_ADDRESS>wrote:
If you think different and want to work on this, please do! It looked dead to me here. However, what would be important to me is to ensure exact reproducibility (in some form) and what I think we need to address is the possibility that we do concurrent addition operations to the same double value from different threads.

What's the goal of exact reproducibility here?  Is it just that you
need some reference run at the end of the day produced by a script
that if it's rerun produces the same result?
If so, why not just turn off various features when reproduciblity of
this order is needed?

For example, here, if lambda is a scalar, then we will add up in the for loop to the same element from different threads concurrently. This pattern is all over in our codebase and we should make that thread safe by making the accumulation per thread and then accumulate the result from each thread together. I am not sure how this is handled in the openMP case here.

That would be ideal, but it requires custom accumulation code.  Or generically
adding something like map_rect.

My conclusion from that is that we should concentrate on tools to make calling map_rect easier.

For reverse mode with our current distribution code, we'd only need the mapping to work on double values.  That is, we could implement the lpdfs with maps.  But again, I don't know how this would stack with user-written maps up in the larger code blocks.
It still seems to me like the big win is mapping big likelihoods.

My conclusion from that is that we should concentrate on tools to make calling map_rect easier

I suspect half decent user-driven parallelization to beat default lpdf parallelization. Plus that default lpdf parallelization will likely not nest kindly with any user-driven stuff

Oooh, okay, I can see why parallelization solutions for the .stan level would look different than this and they might interfere with each other and that's not great.
Might as well run over this in the meeting anyway and determine the future of this specific pull at least.

We could talk about it but I think the pull is dead without a sponsor
anyway, right? Can always reopen.
On Wed, Aug 8, 2018 at 18:26 Ben Bales<EMAIL_ADDRESS>wrote:

My conclusion from that is that we should concentrate on tools to make
calling map_rect easier
I suspect half decent user-driven parallelization to beat default lpdf
parallelization. Plus that default lpdf parallelization will likely not
nest kindly with any user-driven stuff
Oooh, okay, I can see why parallelization solutions for the .stan level
would look different than this and they might interfere with each other and
that's not great.
Might as well run over this in the meeting anyway and determine the future
of this specific pull at least.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/800#issuecomment-411467926, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7E8GLNVOPCHL3F5DQn5-PRo34Vkxks5uOxFEgaJpZM4SsS9r
.

--
Laboriously extracted via diminutive keyboard

We could talk about it but I think the pull is dead without a sponsor anyway, right?

Well not to spoil anything too badly, but my Great Big Plan for the meeting was, @bgoodri, is this alive? I think it has merit as a solution to parallelizing the lpdfs/lpmfs, but if that isn't anyone's goal, then yeah, seems like that'd be a good reason to go ahead and close it.

It was passing the tests with and without openMP months ago. What hasn't
been done is optimizing the thresholds for when it actually utilizes
parallelization or stays serial when compiled with openMP.
On Wed, Aug 8, 2018 at 2:03 PM Ben Bales<EMAIL_ADDRESS>wrote:

We could talk about it but I think the pull is dead without a sponsor
anyway, right?
Well not to spoil anything too badly, but my Great Big Plan for the
meeting was, @bgoodri https://github.com/bgoodri, is this alive? I
think it has merit as a solution to parallelizing the lpdfs/lpmfs, but if
that isn't anyone's goal, then yeah, seems like that'd be a good reason to
go ahead and close it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/800#issuecomment-411498199, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADOrqqCV_lvK50QmZcXpDCU_QOpGJuy1ks5uOyfcgaJpZM4SsS9r
.


{{link-to}} positional param is dropped

{{link-to
   'Segments'
   'apps.segments'
   class='tabs__discrete-tab'
   activeClass='o__selected'
   current-when='apps.segments'
   data-test-segment-link='segments'
 }}

currently transforms to:
<LinkTo
   class="tabs__discrete-tab"
   @activeClass="o__selected"
   @current-when="apps.app.account.visibility.user-segments"
   data-test-segment-link="user-segments"
/>

it should transform to:
<LinkTo
   @route="apps.segments"
   class="tabs__discrete-tab"
   @activeClass="o__selected"
   @current-when="apps.app.account.visibility.user-segments"
   data-test-segment-link="user-segments"
>
  Segments
</LinkTo>

Here's another issue:
{{conversation/stream-and-controls
    tagName=''
    actionReceiver=streamAndControls
    conversation=conversation
    background=background
    readOnly=true
    isInbox=false
  }}

is currently transformed into:
 <Conversation::StreamAndControls
    @tagName
    @actionReceiver={{streamAndControls}}
    @conversation={{conversation}}
    @background={{background}}
    @readOnly={{true}}
    @isInbox={{false}}
   />

I fix or try to fix!  I’m guessing @tagName=‘’ is missing?
On Thu, Apr 25, 2019 at 7:52 AM Gavin Joyce<EMAIL_ADDRESS>wrote:

Here's another issue:
{{conversation/stream-and-controls
tagName=''
actionReceiver=streamAndControls
conversation=conversation
background=background
readOnly=true
isInbox=false
}}
is currently transformed into:
<Conversation::StreamAndControls
@tagName
@actionReceiver={{streamAndControls}}
@conversation={{conversation}}
@background={{background}}
@readOnly={{true}}
@isInbox={{false}}
/>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rajasegar/ember-angle-brackets-codemod/issues/31#issuecomment-486706450,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEK3PR4Z6YWQSZWMHWTEIBTPSHARPANCNFSM4HIMUUWQ
.

Oh, sorry - I meant to paste that into an internal github issue, not this one 😆. Please do fix it if you like, otherwise I'm happy to do so later


bug(Tree): Nested Tree Node left padding not working on MSFT Edge, Win 10

Reproduction
Use StackBlitz to reproduce your issue: https://stackblitz.com/fork/components-issue
Steps to reproduce:

Open your own documentation: https://material.angular.io/components/tree/examples
Look at the 'Tree with nested nodes' example on the bottom on Edge and Chrome

Expected Behavior
What behavior were you expecting to see?
Tree nodes should be nested with increasing left padding on each level
Actual Behavior
What behavior did you actually see?
Nodes are not nested in Edge (they are in Chrome)
Environment
Your own doc site for Angular 10.2.6
Edge:  86.0.622.51
Chrome: 86.0.4240.111
OS: Windows 10 Pro 20H2

I'm running an identical version of Edge (86.0.622.56) and it works fine. I also tried it with IE11 and it worked there too. Maybe you have an old version of the site in your cache?

OK, dug into this further. Turns out the extension 'EPUB READER' messed this up. Missed this one initially since it shouldn't alter any website and just help opening epub files.... Anyway, this was a false alert. Sorry for the noise.


feat: GlobalTags Partner, Sponsor, Staff Tag (like HDSkins)

Tell us about your concept

Example for GlobalTags
§9§lGlobalTags §2Staff
§9§lGlobalTags §cPartner
§9§lGlobalTags §6Sponsor
The tag should always be displayed under the player's name and under the GlobalTag.

Hey, first of all I want to thank you for your idea. This won't be implemented as we already have a unique way of displaying roles. I just don't think it would look good to copy the staff tags from LabyMod and HDSkins especially if a player has more than of those tags.


[Remote rendering problem] No hit results from RayCastQueryResult.Hits is inconsistent between platforms (Quest and Windows)

SDK Version 1.2.6
We've recently updated the RemoteFocusProviderNoCollider to properly support the teleport pointer. This worked fine in Editor, but didn't return any hits when running on Quest. After some debugging, we tracked it down to some extra processing hits we added.
The cause was that RayCastQueryResult.Hits returns null for no hits on Quest and an empty array on Windows. The comment on the property implies that it should be a at least and empty array and not null.
"A (potentially empty) array of intersections that the raycast encountered."
It would great if this could be made consistent between platforms.
(Apologies if it's already been fixed in a newer version of the SDK, upgrading to the latest is on our backlog)

Hi @WikkidEdd,
Yes, this has already been fixed with version 1.2.12.
Starting with that versions all Unity APIs should return an empty Array/List instead of null. The only two exceptions are RenderingSessionPropertiesArrayResult.SessionProperties and ConversionPropertiesArrayResult.Conversions, which may still be returning null.
I highly recommend updating to version 1.2.12 or newer, and use the new preallocation APIs for retrieving the results. They greatly reduce the pressure on the GC compared to the regular APIs.

Ok, great. Will do!


Allow themes to be inherited (or imported)

Hi!
Is this possible? I would like to use the default theme (https://github.com/asciidoctor/asciidoctor-pdf/blob/master/data/themes/default-theme.yml) and just change a few things (and put those changes in a new YAML file instead of editing the default theme)?
Thanks,
Bela

Not yet. This is a duplicate (though more specific) of https://github.com/asciidoctor/asciidoctor-pdf/issues/131#issuecomment-104757104. Since the goal is stated more clearly in this issue, we'll keep it as a discrete request.

I updated the title to make it more clear what we are requesting. I think we should consider the idea of a theme import as an alternative approach, similar to @import in CSS.

Yeah! And maybe also the possibility to list multiple themes in the pdf-style attributes?

@and3k exactly, that would be the other approach. So to clarify, it would be nice to have two ways to composite themes:

@import statement in a master theme file
Comma-separated themes in pdf-style attribute

Just to be clear, there's still no way for themes to be inherited, right?
Where do I find the default theme, so I can copy it and modify just the parts that I need to change?

That's correct, the theme cannot currently be inherited.
Here's the default theme: https://github.com/asciidoctor/asciidoctor-pdf/blob/master/data/themes/default-theme.yml
I recommend following this guide: https://github.com/asciidoctor/asciidoctor-pdf/blob/master/docs/theming-guide.adoc

I've submitted an initial prototype. It works using the extends key in the theme file. The values are either "default" (to import the default theme), or a file path resolved relative to the pdf-stylesdir.
Here's an example of how to extend the default theme:
extends:
- default
base:
  font_color: ff0000

Here's an example of how to extend a custom theme (which itself could use the extends key):
extends:
- ./base-theme.yml
base:
  font_color: 222222

There are still some limitations / quirks when it comes to paths. For example, it's still only possible to load fonts from a single directory.


Oracle: Slow query on "Loading package cache"

System information:

Operating system (distribution) and version Windows 10
DBeaver version <IP_ADDRESS>105300349
Additional extensions n/a

Connection specification:

Database name and version Oracle 11
Driver name ojbc19
Do you use tunnels or proxies (SSH, SOCKS, etc)? n/a

Describe the problem you're observing:
While "Loading package cache" or "Searching proposals" for autocompletion in sql editor is running on Oracle, the following query is issued:
SELECT  * FROM ALL_OBJECTS WHERE OBJECT_TYPE='PACKAGE' AND OWNER='MY_OWNER'  ORDER BY OBJECT_NAME

On my database that query is insanely slow. But the really absurd thing is that the following query performs much better:
SELECT  OWNER, OBJECT_NAME, SUBOBJECT_NAME, OBJECT_ID, DATA_OBJECT_ID, 'PACKAGE' OBJECT_TYPE, CREATED, LAST_DDL_TIME, TIMESTAMP, STATUS, TEMPORARY, GENERATED, SECONDARY, NAMESPACE, EDITION_NAME
FROM ALL_OBJECTS WHERE OBJECT_TYPE='PACKAGE' AND OWNER='MY_OWNER'  ORDER BY OBJECT_NAME

The listed fields are exactly the same (I just expanded * to the full list of fields returned by that query), except for OBJECT_TYPE which is forced to 'PACKAGE' (which is bound to be true because of the WHERE clause).
Execution times of the 2 queries on my system: 30 seconds for the first one, some hundred milliseconds for the second.
Steps to reproduce, if exist:
Open a new connection, new sql editor, then ask for autocompletion proposals.

Hello @p91paul,
That's interesting, thanks for the suggestion!

Verified


web UI: directory view can't navigate to new tab

The directory view (in filetree.js) uses the form "./?b=sha1-blabla" to set the href to navigate to the view for an item of the directory.
However, this form only works from within the cam.CacheBusterIframe navigation context, so opening such a link in a new tab won't work, because the rest of the UI does not use the cam.CacheBusterIframe navigation.
Conversely, (all?) the rest of the UI supports the "/ui/sha1-blabla" form to navigate directly to the default view for the sha1-blabla blob, whereas the directory view does not. So we can't just change "./?b=sha1-blabla" to "./sha1-blabla" in filetree.js

https://camlistore-review.googlesource.com/6116

4e4f045c298f5c8fcd442d1fe35766e3b4133fac


Invisible cursor

How to change cursor visibility? i wrote a small python websocket proxy to forward xen's "xm console" standard input and output to term.js. Everything seems to working fine (including midnight commander, vi, etc) except the cursor. It's always invisible. tput civis/cnorm and any escape sequence found on the net does not help.

I had the same problem. After reading through the source I found the following solution: term = new Terminal({ cols: 80, rows: 24, useStyle: true }). Specifically the useStyle: true part.

You need to set the .terminal-cursor css class, but useStyle will do it automatically.


fix: #36 and dynamic import

fix: #36
fix: dynamic import

@gioboa

Now npm package release seems to be missing build? Not the latest code

Now npm package release seems to be missing build? Not the latest code

You are right, sorry.
1.0.0-alpha-80b7215


Update wfs tutorial

Another update of the WFS tutorial

@florisvdh @ThierryO don't know if you want to have another look at this. I've added a fifth example showing how pagination works.

@florisvdh @ThierryO don't know if you want to have another look at this. I've added a fifth example showing how pagination works.

@hansvancalster I'll have a look

@hansvancalster I'll have a look

@peterdesmet I merged this PR yesterday but https://inbo.github.io/tutorials/tutorials/spatial_wfs_services/ did not update. Do you know what's going on?

@peterdesmet I merged this PR yesterday but https://inbo.github.io/tutorials/tutorials/spatial_wfs_services/ did not update. Do you know what's going on?

On https://travis-ci.com/github/inbo/tutorials/builds/215110402 (the latest Travis build on this branch):

On https://travis-ci.com/github/inbo/tutorials/builds/215110402 (the latest Travis build on this branch):

Does anyone (including @niconoe @damianooldoni @ElsLommelen) have experience using GitHub actions to build the site?

Does anyone (including @niconoe @damianooldoni @ElsLommelen) have experience using GitHub actions to build the site?

I've set up GitHub actions on https://github.com/inbo/indicatoren. See https://github.com/inbo/actions

I've set up GitHub actions on https://github.com/inbo/indicatoren. See https://github.com/inbo/actions

I have a basic understanding of GitHub actions, and used them so far for testing Python code (also in replacement of Travis). If I understand correctly, here it would be a matter of running Hugo and deploying the result on GitHub actions.
I'd be very happy to have a look (and I have to prepare an info session about GitHub actions anyway, that would be a good exercise) but my agenda is pretty full until around February 10th. I don't know how urgent this is?

I have a basic understanding of GitHub actions, and used them so far for testing Python code (also in replacement of Travis). If I understand correctly, here it would be a matter of running Hugo and deploying the result on GitHub actions.
I'd be very happy to have a look (and I have to prepare an info session about GitHub actions anyway, that would be a good exercise) but my agenda is pretty full until around February 10th. I don't know how urgent this is?

In this case it is probably just a matter of copying the appropriate yaml file(s) from the example of @ThierryO, adapt it a bit if needed and put it in a .github folder in the tutorials repo.  ;-)

In this case it is probably just a matter of copying the appropriate yaml file(s) from the example of @ThierryO, adapt it a bit if needed and put it in a .github folder in the tutorials repo.  ;-)

I'm affraid it's not that simple. indicatoren starts from a set of Rmd files that a rendered in a dedicated Docker image. Here we need a Hugo engine.

I'm affraid it's not that simple. indicatoren starts from a set of Rmd files that a rendered in a dedicated Docker image. Here we need a Hugo engine.

I have a basic understanding of GitHub actions, and used them so far for testing Python code (also in replacement of Travis). If I understand correctly, here it would be a matter of running Hugo and deploying the result on GitHub actions.
I'd be very happy to have a look (and I have to prepare an info session about GitHub actions anyway, that would be a good exercise) but my agenda is pretty full until around February 10th. I don't know how urgent this is?

@niconoe great! I think the timing you suggest is OK.

I have a basic understanding of GitHub actions, and used them so far for testing Python code (also in replacement of Travis). If I understand correctly, here it would be a matter of running Hugo and deploying the result on GitHub actions.
I'd be very happy to have a look (and I have to prepare an info session about GitHub actions anyway, that would be a good exercise) but my agenda is pretty full until around February 10th. I don't know how urgent this is?

@niconoe great! I think the timing you suggest is OK.

Some further background is provided in a quite recent post at rOpenSci: Moving away from Travis CI


Add User node type

[ ] general user abstractions
[ ] priority handling
[ ] confirm that higher priorities downstream are met before lower priorities upstream are met

I believe this can be closed in favor of #14.

H'mm I do not if this one can be closed. even if we do not run in 'allocation' mode with priorities, we should allow users to abstract water on a first come first serve basis. We need a User node type

Ok, re-opened and renamed the issue to "add User node type".
I think this node type would be like the FlowBoundary, except that it has a priority, and a possible return flow.

As mentioned in https://github.com/Deltares/Ribasim/issues/293, the abstraction flow rate of a user should be a DiscreteControl condition (listen) variable

When a user returns water, do they do so over the same edge as the abstraction?

a user should have an incoming edge and an outgoing edge. The outgoing edge can go to the same or a different basin.
if a modeller wants to return water that did not come from the basin (or a coupled model like Modflow), a FlowBoundary node needs to be used
best to make it mandatory
the Demand should be in the static and the timetable. Priority can be in static only

let's define this with the user, in the static table only untill we realize it should be dynamic
yes, immediate. In practice some delay may occur, but generally there will be no information available to parameterize such a delay. Eg, for Industry, you are likely to know an annual or monthly abstraction rate (mostly from the permit or a report) and if you are lucky a daily series of abstractions and return flows.


Show Y value on the pie sector

Hey guys.
Is it possible to show Y value on the pie chart secotr?
For example, on this chart we can see how much space some sector(in percentage) takes.

You can see that I hovered mouse over USA and it shows value - 122. So instead of percentages on the sector I want to show number 122.
Thanks!

Hi I have added a sample, https://apexcharts.github.io/Blazor-ApexCharts/pie-charts#label formatter


latest release 0.11.1 but in debian it is 0.12.x??

https://github.com/posativ/isso/releases lists 0.11.1 as latest release
but
root@server:/etc/isso.d/enabled# dpkg -l | grep isso
ii  isso                            0.12.2-2                     all          lightweight web-based commenting system
???
when i go to the latest releases page and click on "newer releases" i see 12.2 - whats the difference to the other releases? why are they not listed "normal" like all other releases?

See the tags page; I don't know why github insists on having a separate page for releases, but I've created a separate item on the releases page now using the UI.


catalog_request SSLError

catalog.request does not seem to inherit verify_ssl settings in Client.new.  There also doesn't seem to be a way to pass verify_ssl setting in catalog.request.  Is this something that can be changed?

it's been fixed in this fork
https://github.com/nwops/vra-restapi
don't know why hasn't be merged tho

@cbalducci , @wareagl - since that fork was last committed to, rest-client was removed for HTTP communication in favor of a custom solution. merging vra-restapi at this point looks problematic.

@bvandgrift i see you've already submitted a PR which fixes this issue. Let's hope it gets merged soon

This is now fixed.  You can ignore certificate verification via the following.
Vra::Client.new(
  username: username,
  password: password,
  tenant: 'vsphere.local',
  base_url: server
  verify_ssl: false
)

@jjasghar please close this since it is resolved.


Acquire original text range when searching for references

Fixes #6976

Can we have a unit test for this?
bors d+

bors r+


Objects as maps does not throw error when it IMO should

I have defined following types types
type Meta = {| id: string, val: string |};

type State = {|
	[key: string]: Meta,
|};

I would expect that any of the following examples will throw error, that any key in State will be forced to be Meta, but that does not look to be the case
Ex1: Does not give error
const test1 = (state: State, meta: Meta): State => ({
	[meta.id]: { ...meta, bu: 'fu' },
});

Ex2: Does not give error
const test2 = (state: State, meta: Meta): State => ({
	...state,
	[meta.id]: { ...meta, bu: 'fu' },
});

Ex3: Horaaay error, that bu is missing in Meta. Also that other is missing in state, I would argue it is still just a key, but I guess that has reasons.
const test3 = (state: State, meta: Meta): State => ({
	other: { ...meta, bu: 'fu' },
});

/*
Cannot return object literal because:
 • property other is missing in State [1] but exists in object literal [2].
 • property bu is missing in Meta [3] but exists in object literal [4] in
   property other.

    [3] 24│ 	[key: string]: Meta,
          :
        36│ });
        37│
 [1][2] 39│ const test3 = (state: State, meta: Meta): State => ({
    [4] 40│ 	other: { ...meta, bu: 'fu' },
        41│ });
        42│
        44│ const test4 = (state: State, meta: Meta): State => ({
*/

Ex4: Same as before, only ...state is spread and error disappears
const test4 = (state: State, meta: Meta): State => ({
	...state,
	other: { ...meta, bu: 'fu' },
});

Is this expected behavior? Am I doing something wrong?

I think this is the same bug as https://github.com/facebook/flow/issues/6871.

Duplicate of #6871


Decide how to display presentation mode settings when there are no settings

If a partner has no works with prices, published work, or confidential notes, what should be shown in the Edit Presentation Mode view? Should the presentation mode setting buttons be visible/disabled in the master settings menu at all in this case?
@lucaderosso @garrengotthardt

@sarah assuming its easier on your end and also avoids having a blank panel we could just update the copy at the bottom to say: "When Presentation Mode is enabled, all information related to features toggled ON will be hidden. Information that has been entered related to features toggled OFF will be visible."

I support this solution.

So this answer assumes that we show all of the options every time, which currently we don't.
For example institutions don't want to feel like this app is super commercial, which is why we hide the "Price"-y options. We're totally cool to show all of them, however it's worth taking into account that not all partners ( or collectors ) would want to know all of Folio's features.

@garrengotthardt @lucaderosso yeah, i agree with orta that partners who can't publish works shouldn't see the 'Hide Unpublished Works' album for example, especially going forward with folio-only subscriptions.
an institutional partner or collector wouldn't be able to use any of the above options.

Collector Folio: Remove entire concept of Presentation Mode
Galleries/Institutions: use @garrengotthardt 's new copy, always show the "Hide Confidential Notes" and "Hide Artwork Edit Button" toggles, and hide publishing/pricing-related toggles as needed.

thanks for the feedback @lucaderosso, @garrengotthardt, and @orta!

Fixed; ended up with presentation mode settings that exist for all Folio users


Destroy current jwt when user logout

How can I destroy current jwt on server when user logout?

There's no way to delete it on the server unless you're storing it on the
server. I think the typical way to 'destory' a jwt so that it may not be
reused is to blacklist it in your db.
On Jun 22, 2016 4:42 AM, "haidnvnn18"<EMAIL_ADDRESS>wrote:

How can I destroy current jwt on server when user logout?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/themikenicholson/passport-jwt/issues/64, or mute the
thread
https://github.com/notifications/unsubscribe/ADEBQ9eKuWxr8Gk6Dyyx--FKp8ZVTioaks5qOPV5gaJpZM4I7iUK
.

Ah ok, I see. And only one more small question. I think jwt token will not be generate a same value, is it true?
Eg:

day A: gen token has value is X
day D: gen token has value is X, too.

Any case of this problem occur?

Regarding different values of JWT: The value of the JWT is determined by its contents and the keys used to sign the JWT.  If the contents and signing keys are identical each time the JWT is created then the JWT value should not change.  If the JWT includes different any unique content (i.e. a timestamp) than it will have a different value each time the JWT is issued.
With regard to destroying a JWT - jwt's often expire or you can include some unique data, i.e. a session ID that can be verified in the database.

Closing, feel free to reopen if you have further questions.


[Bug]: Cross referencing - Not able to navigate to desired widgets/pages using app navigation

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When we click on widget names in the app navigation menu, we are not redirected to the said widget.
Note: We are able to however navigate to queries, datasources, JS Objects.
Steps To Reproduce

Go to https://ee-4056.dp.appsmith.com/ and edit an app.
Using the app navigation flow, try to navigate to a widget inside a different page.

Expected: User should be redirected to the widget/page.
Actual: User is not redirected to the desired widget/page.
Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
https://jam.dev/c/5836f66c-d82d-4b32-aecb-479b5aefdcbd
Version
Cloud

@brayn003 the issue is partially fixed in the DP. When navigating to a widget on a page where the widget is positioned out of the initial view, requiring scrolling to be seen, auto-scrolling does not occur. Please refer to the below video for more details:
https://jam.dev/c/0ec5682f-ca33-456f-9b5e-b1c2f8385363

The scroll issue in particular is not related to default resources. This issue only occurs for ee instances and can be replicated in release-ee.appsmith.com
I suggest we raise a different ticket for the scroll issue and assign it to the relevant team


🚸 show return of each position in portfolio

Generated summary (powered by Graphite)

TL;DR
This pull request adds a new feature to the portfolio table in the CLI. It now includes a "Return (%)" column that displays the return rate for each position in the portfolio.
What changed
Three files were modified to implement this feature:

pyrb/controller/cli/main.py: The portfolio table in the CLI was updated to include a new column "Return (%)".

pyrb/model/position.py: A new attribute rtn was added to the Position class to store the return rate.

pyrb/repository/brokerage/ebest/portfolio.py: The positions method was updated to include the return rate when creating a Position object.

The test file tests/conftest.py was also updated to include the return rate when creating test Position objects.
How to test
To test this feature, you can run the CLI and check the portfolio table. It should now include a "Return (%)" column. You can also run the test suite to ensure that all tests pass with the new changes.
Why make this change
This change was made to provide more information to the user about their portfolio. The return rate is a crucial piece of information when evaluating the performance of a position. By including it in the portfolio table, users can easily see how well each position is doing.

Current dependencies on/for this PR:

main

PR #49

PR #50   👈

This stack of pull requests is managed by Graphite.

Merge activity

Dec 12, 9:29 AM: @@mingi3314 started a stack merge that includes this pull request via Graphite.


Posibility to have second activity bar

Currently secondary sidebar has tabs when I add multiple items to it, I would love to have secondary activity bar instead.
Usually, I put stuff to the secondary sidebar that I don't use that often, like copilot labs and gitlens, so I don't have side bar opened that often, but I would love to have access directly not by opening the second sidebar and selecting tab after.

+1

👍👍👍


Add support for Github Actions Job Summaries

We're using this action in pull_request workflows and due to the GHA security model cannot use the comment on alert feature of this action.
In case of an alert, we have to inspect the workflow run which is cumbersome to parse. It would be great if you could adopt the Job Summaries feature so we get a nicely rendered markdown table in the job summary page.

Nice idea
I'll investigate into that

That'd be awesome (and shouldn't be too hard to implement IMHO)

Hi guys! Thanks for the great work you put in this action, I'm very interested in this feature as I'm using this action in a project already.
I think we could reuse some of the abstraction we have for the commit message and use the same inputs to build the summary table?

Hi guys! I started this PR https://github.com/benchmark-action/github-action-benchmark/pull/138 to address this issue. Any early feedback would be awesome! Thanks!

When can we expect this feature to be available ?

Released in v1.16.0


Sign executables in frameworks

This will sign the executables in frameworks and prevent crashes on stock due to invalid signature.
This also fixes logic and prevents asking for ipa source if '-p' or '-u' args have been passed.
I tested it with YouTube on stock.

Thanks for the pr!


repo don't exist

Repo in https://apiumbrella.io/install/ for Centos 7 dont work
The link for installation https://bintray.com/nrel/api-umbrella-el7/rpm has a 404 error.

There are another repositories?

Same here. bintray.com has obviously been closed down and replaced by jfrog.com. Several applications have followed (CouchDB), others moved elsewhere (RabbitMQ, -Erlang moved to packagecloud.io and cloudsmith.io). What's the plan for api-umbrella packages?

Any updates on this, will this be moved or has anyone found any alternatives?


Build error

Although the app seems to work fine, I do get this build error:
ERROR in ./src/main.ts
Module build failed: TypeError: Cannot read property 'exclude' of undefined
    at applyDefaults (/Users/macliems/Desktop/ng2-firebase/node_modules/awesome-typescript-loader/src/instance.ts:266:72)
    at Object.ensureInstance (/Users/macliems/Desktop/ng2-firebase/node_modules/awesome-typescript-loader/src/instance.ts:145:5)
    at compiler (/Users/macliems/Desktop/ng2-firebase/node_modules/awesome-typescript-loader/src/index.ts:37:20)
    at Object.loader (/Users/macliems/Desktop/ng2-firebase/node_modules/awesome-typescript-loader/src/index.ts:18:18)
 @ multi main

Its now fixed, thanks for reporting. Please update the repo, and by running npm install and ng serve it all should work again. KR Vasco


Go to definition does not work for Pandas and other libraries

Issue Type: Bug
Go To Definition does not work for Pandas and any other source type. For example, in this very simple code snippet, i try to CMD+click on a DataFrame symbol and as a seasoned engineer, i expect to go directly to sources of DataFrame class definition, because i have no time to google for documentation nor i generally trust it, because it's either not that extensive or out of date. And sources have more things to show.
import pandas as pd
pd.DataFrame([{'foo': 1, 'bar': 2}])

navigation does not work also for any module in the sys.path:
import os,sys
# (i have all my exploratory notebooks in `notebooks` folder and my other code in packages up the level)
sys.path.append(os.path.abspath('..'))

this does not work for symbols defined in the same notebook as well:
e.g. def foo(): print(1) in one cell, and foo() in the other cell doesn't get me jumping the way i'd expect from an IDE.
Extension version: 2021.3.600686576
VS Code version: Code - Insiders 1.54.0-insider (Universal) (e590188f17162393f50feec19263398e6fe02d13, 2021-02-26T20:39:12.763Z)
OS version: Darwin x64 19.6.0

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvspyt639:30264824
pythontb:30258533

Must be part of https://github.com/microsoft/vscode/issues/91987

Thanks, I do repro this behavior. Same behavior in the December release, so we didn't regress this.
Some observations:

We do implement provideDefinitions in the notebookConcatMiddleware in the Python extension

However ctrl+click does nothing in a notebook

Invoking the Go to Definition command from the command palette with a symbol selected results in the following error message:

Additionally, when invoking the Go to Definition command, the Jupyter extension's log shows this message:
Info 2021-02-27 12:43:03: provideCodeActions not currently supported for notebooks

@joyceerhl my other bug about this was closed with statement it’s working in daily build, but it’s not working, as we see here 😜 I have “all” AB experiments enabled so feel free to add experimental code for more feedback :)
also, it would be great if you can tell me how to get relevant logs for my countless bug reports to make your work easier 😊

Appreciate you taking the time to help us improve our product 😊 To get full logs, add the following setting to your user settings.json:

"jupyter.logging.level": "debug"

Then reload VSCode for the new setting to take effect, and you'll be able to find debug logs in the Jupyter output tab:

@joyceerhl where settings.json is located on macOS? Is it project level or user level?

@nfx that would be user level. You can find it by running Cmd+Shift+P to bring up the command palette, then typing in 'Open Settings (JSON)' and selecting the top option.

I poked at this a bit on current VS Code - Insiders. I do see an initial failure the first time that I do Go To Definition or use F12. But then after that initial failure it seem to work correctly for me, but only for a basic intra file example (def foo in one call, foo() in another). Not getting any success on the example of pandas dataframe while it works just fine in .py. Looking more now.

@IanMatthewHuff i think pandas example doesn't work because symbols, it's not defined in the workspace, but it is a dependency. And indexing/debugging non-workspace symbols is disabled by default, as far as i understood. i think we really need a popup window asking to enable this. Anyway, my expectation from IDE is to look for symbol in every submodule defined in sys.path.

@nfx. While digging in on this I found a straight up bug here. Basically outgoing links (goto def and whatnot) from inside a notebook file to anything outside a notebook file were not working. I have a fix in progress and should hit the insiders build of the Python extension soonish. Just follow this issue and you should see when it gets closed.

Note for team validation. This was resolved in the Python extension.

Validated against latest main for Python + Jupyter extension.

yes! it works! thanks!

@nfx Awesome. Thanks for the confirmation.


What kind of runtime backend this Plugin use?

Description
Hi, first Thank you for creating Mediapipe Plugin.
I want to know which runtime backend this Plugin use..
https://storage.googleapis.com/tfjs-models/demos/pose-detection/index.html?model=blazepose
There is 3type of runtime backend model (mediapipe-gpu, tfjs-webgl, tfjs-webgpu)
Thank you.

There is 3type of runtime backend model (mediapipe-gpu, tfjs-webgl, tfjs-webgpu)

This project doesn't run on the web. Therefore, the 3 options for the runtime-backend are not relevant to this project.
I believe the choice of runtime is determined by CalculatorGraphConfig rather than this plugin.

Could you please let me know the intention behind this question?

I want to increase fps speed, mediapipe latency.
so I got the fastest fps speed when I use mediapipe-gpu runtime backend model in that site.
I'm just curious, thanks for answering

I still dont know how.....

Sorry, what would you like to know?

Sorry for the late reply.
The purpose of my question is to increase the mediapipe latency.
I am conducting a test by device.
The mediapipe latency is over 50 on the desktop and 30 on the iOS, but about 10 on the Galaxy series. (The application fps are all equal to 30.)
The difference is that graphic api is different from opengles and metal.
So, I modified my Holistic_opengles (OpenGlesConfig file in Holistic Tracking graph), but it doesnt make to improve latency.

I believe the choice of runtime is determined by CalculatorGraphConfig rather than this plugin.

and.. Is this the correct code for the CalculatorGraphConfig you mentioned?
Packages/com.github.homuler.mediapipe/Runtime/Scripts/Framework/CalculatorGraph.cs
Thank you.

Generally, the unit of latency is understood to be milliseconds (ms), but are you referring to FPS here? (would you like to improve the performance on the Android devices?)
If so, can you check if it is the same issue as https://github.com/homuler/MediaPipeUnityPlugin/issues/768#issuecomment-1285330371 ?

Is this the correct code for the CalculatorGraphConfig you mentioned?

See https://developers.google.com/mediapipe/framework/framework_concepts/graphs


Update docblock

Thanks Jason. I really hope to have the 1.0 release out SOON. Sorry for delay on this.

No worries, we're using the dev branch with no issues. No big deal.


giving input in different roles

is there anyway to use this to give input and output as json format? user and assistant and system prompt separately?

Could you elaborate with some example of what you are trying to do?

I meant to say that:
as in the example the model is generating text along with "Bob: and "\nUser:" to take next input I want that the model should only be responsible for generating text against user input instead of generating any extra characters for next input.
like giving input prompt and getting output text:
authorrole.user's text can be accessed anytime and authorrole.assistant text also can be extracted.
inshort, as in example of text-with-bob.json instead of using text-with-bob.txt.
i hope this clarifies

You should check the LLamaSharp examples or create an issue on their github as I am not the creator of the project and I am unsure how to do it. My gues is that it's something to do with input/output/history transforms.


Year End batch jobs

Please ignore code smell on .toList(). I need mutable list for sorting.

Please ignore Collections.toList() code smells. I need mutable lists for sorting


Remove incorrect placeholder Publications

This PR is a migration to remove two Publication content items that are causing their HtmlAttachment
republishing sync checks to fail as their content ids don't match with the HtmlAttachment.
There is a corresponding PR on Whitehall

Closing in favour of creating a Command to perform this


Add gitignore support for fzf

https://github.com/junegunn/fzf#respecting-gitignore
Aparently its not bad at all

done!


Adjust name for =/=K hook

The name used in the Haskell backend was KEQUAL.neq but the K domains.md file uses KEQUAL.ne.

good spot. tho I suppose this points to the hook never being used, because we would have surely seen a hook unimplemented error.

True, we would have seen this as a missing hook error before otherwise. Maybe the simplifications have historically been evolving to avoid this operation (transforming _ =/=K _ to #Not (#Equals _ _), or maybe they were there from the beginning and ne was added without need. From my quick git blame investigation, this hook goes back at least 9 years.


Proposals for savings

As a user, I want so select from some saving proposals, which will be taken into account for 2023

Proposal: Simple calculator-icon next to the reduction.
This could bring of an overlay with proposals from which the user can select. This total would then be copied to the targeted reductions

Proposals should be as specific as possible, but could include links to further information for those who want to learn.

halb so viel duschen
den Herd für das Nudelwasser nach 2min kochen ausschalten https://www.barilla.com/de-at/passives-kochen
Raumtemperatur um 1°C reduzieren

A first informational dialog exists now (#58), but we should add functionality to let user choose some of the recommendations and add data to automatically increase the amount of savings.

@jschirrmacher the dialog looks like a good start 👍
WDYT about adding a slider to the bottom "based on the above, I plan to reduce my consumption by x%"
On close, this could be copied to the reductions

Sounds great!

At least like a very feasible one :)
Maybe we could also just link https://www.energiewechsel.de/KAENEF/Navigation/DE/Thema/energiespartipps.html as "Noch mehr Ideen zum Sparen"

I've added the slider and the additional recommendation now (see #63 and #64).
We could convert the modal to an own menu item.
We might then ask users to enter some information about housing, how old the house is, if they use gas for cooking etc., or some preferences (e.g. "how often do you take showers currently?"). With that, recommendations could be filtered and savings calculations could be a little more accurate.

The issue gets more and more like an epic...

Agreed.


Fix changelog version numbers #trivial

External Gitlab CI was actually released in 8.0.3, the actual version bump happened here: https://github.com/danger/danger/commit/db9b9ba2e1c69d70e141c3cada822d0050e81ea1

👍🏻  thanks


this.mode(...) => this.pinMode(...)

Originally reported in http://gitter.im/rwaldron/johnny-five

Bah, this is garbage. Closing.


MacOS Version

Hello there, friends. I come to you humbly asking what the chances are of making a version of this browser for MacOS (possibly M1?) if possible. If not, it's all good. Unfortunately, I am not experienced in such matters, so I am not sure how much of a help I could be. In any case, great browser, and I use it on my Windows machine.

Thank you for using Dichromate.
Unfortunately, I do not own a Mac, ARM or Intel, so I am unable to provide MacOS builds of Dichromate.
You can compile Dichromate yourself on MacOS. Just apply the patches from this repository before starting the compile. However, build process takes a very long time, and it would be a hassle keeping it up to date. Another issue is the fact that we don't have an automatic update system for MacOS, which is a security risk. I wouldn't recommend using your own builds unless you are sure you can keep it up to date.
I will leave this issue open, in case we are able to get MacOS builds going sometime in the future.


Remove redefinition

The macros have been defined in server_message.h

Addressed in https://github.com/triton-inference-server/core/pull/44


Improved footer in login and sign up page

Hey @QAZIMAAZARSHAD
This PR fixes Issue #379
Kindly review it and suggest if any changes further required.

Resolve conflicts.

hey @QAZIMAAZARSHAD
conflicts resolved!


log/syslog: variables and documentation for facility misleading

syslog.Dial and syslog.New take a syslog.Priority as an argument and stores it in a field named priority. This field is used exactly twice:

as a syslog facility  in writeAndRetry
as the syslog priority in Writer.Write

For examples of someone confused by this in the wild, check out  logrus_syslog or golang-samples, which thinks that creating a syslog writer with a severity instead of a facility will do something meaningful:
package main

import (
	"fmt"
	"log/syslog"
)

func test(p syslog.Priority, msg string) {
	w, e := syslog.New(p, msg)
	if e != nil {
		fmt.Println("Error opening syslog", e)
	} else {
		w.Debug("hello, world")
	}
}

func main() {
	test(syslog.LOG_ERR, "ALEX")
	test(syslog.LOG_INFO, "BEN")
	test(syslog.LOG_DAEMON, "CAROLE")
	test(syslog.LOG_USER, "DOUG")
}

<7>1 2016-05-18T10:50:43.326575-07:00 ubuntu-16 ALEX 2517 - -  hello, world
<7>1 2016-05-18T10:50:43.327090-07:00 ubuntu-16 BEN 2517 - -  hello, world
<31>1 2016-05-18T10:50:43.327409-07:00 ubuntu-16 CAROLE 2517 - -  hello, world
<15>1 2016-05-18T10:50:43.327707-07:00 ubuntu-16 DOUG 2517 - -  hello, world

It would be great if facility was a different type from priority, but barring that it would be wonderful to update the documentation here. In particular, I would love to see syslog.New and syslog.Dial take a variable named facility and explain the difference, with an example usage.
I'm happy to do it if such a change could be merged. I see that the package is "frozen" -- will it still accept doc fixes?

Documentation changes are fine.

The value given to syslog.New is a:

priority for syslog.Writer.Write
facility for all other consumers of the syslog interface (e.g. syslog.Write.Info)

What is the best way to describe the behavior here? I'd prefer to deprecate that syslog.Writer.Write will use the priority and to indicate that syslog.New prefers a facility; however we obviously can't break backwards compatibility.


Why is the pop-up not closing after successfully logging in?

The pop-up does not close after a successful log-in. The pop-up stays open and you can browse your facebook content in the pop-up.

I'm developing in localhost:3000 with HTTPS=true set in package.json
import React, { useEffect } from 'react';
import { ButtonProps } from '@mantine/core';
import FacebookLogin from '@greatsumini/react-facebook-login';

export function FacebookButton(props: ButtonProps<'button'>) {
  return (
    <FacebookLogin
      appId=''
      onSuccess={(response) => {
        console.log('Login Success!', response);
      }}
      onFail={(error) => {
        console.log('Login Failed!', error);
      }}
      onProfileSuccess={(response) => {
        console.log('Get Profile Success!', response);
      }}
    />
  );
}

@dalegacusan
Could you provide a minimal repository which reproduces this issue?


Add initial changelog

Also adds SECURITY.md, some edits to contributor workflow, and a badge from badgeapp.

We've met the passing criteria with this change! We're also well on our way to the silver tier.


How to compile src folder in vs_library.nut

I want to change this library a bit under portal 2 so that save/load doesn't update all existing objects, but I can't figure out how I can compile (compress) the src folder into a vs_library.nut file. How can this be done?

Minification is not completely automated, there is some manual copy-pasting involved. You can search the minified file to find and replace the functions you wish to replace, do the regex replacement below twice (once with 2 params and once with 1) and just leave them there.
https://github.com/samisalreadytaken/vs_library/blob/4fd7aa703b5598f846385c2c61ab578a405a3e37/src/common.nut#L72-L73

so that save/load doesn't update all existing objects

I'm curious what you mean by this. I just tested and found that ToExtendedPlayer() crashes the game on restore (and found the fix for it), but nothing else. Was this your issue?

You update the entities in each round via __KeyValueFromString("classname",..), but the entities are also updated after save/load, which is why logic_measure_movement disappears after save/load

That code path is already disabled for Portal 2. I will push the fix for extended player either today or tomorrow.

I pushed the fix as 2.43.26, tested getting player eye angles and FOV. I'd like to hear if this resolves your issue.
There is one thing to pay attention to is if you're using CExtendedPlayer to get player eye angles, do not change the player's targetname, as that name is used on game restore.
I found something peculiar about the way things work in Portal 2; it seems like sometimes player eye angles start drifting about 0.0001 degrees every second. This is not really an issue though as no player would be expected to not move the mouse for minutes for this to make any difference.

Ignore what I said about changing player targetname before, I just hadn't thought about it then. I just pushed a hotfix for that; you can name player whenever to whatever you like.


Error using KafkaMetricsReporter

I am receiving an error when attempting to use the KafkaMetricsReporter service.
This is the exception on startup:
Exception in thread "main" java.lang.NoSuchMethodException: com.linkedin.kmf.services.KafkaMetricsReporterService.<init>(java.util.Map, java.lang.String)
	at java.base/java.lang.Class.getConstructor0(Class.java:3349)
	at java.base/java.lang.Class.getConstructor(Class.java:2151)
	at com.linkedin.kmf.KafkaMonitor.<init>(KafkaMonitor.java:84)
	at com.linkedin.kmf.KafkaMonitor.main(KafkaMonitor.java:188)

Attached is my properties file:
{
    "produce-service": {
        "class.name": "com.linkedin.kmf.services.ProduceService",
        "topic": "kafka-monitor-topic",
        "zookeeper.connect": "localhost:2181",
        "bootstrap.servers": "localhost:9092",
        "consume.latency.sla.ms": "20000",
        "consume.consumer.props": {}
    },

    "consume-service": {
        "class.name": "com.linkedin.kmf.services.ConsumeService",
        "topic": "kafka-monitor-topic",
        "zookeeper.connect": "localhost:2181",
        "bootstrap.servers": "localhost:9092",
        "consume.latency.sla.ms": "20000",
        "consume.consumer.props": {}
    },

    "reporter-kafka-service": {
        "class.name": "com.linkedin.kmf.services.KafkaMetricsReporterService",
        "report.interval.sec": 3,
        "zookeeper.connect": "localhost:2181",
        "bootstrap.servers": "localhost:9092",
        "topic": "kafka-monitor-topic-metrics",
        "report.kafka.topic.replication.factor": 1,
        "report.metrics.list": [
          "kmf.services:type=produce-service,name=*:produce-availability-avg",
          "kmf.services:type=consume-service,name=*:consume-availability-avg",
          "kmf.services:type=produce-service,name=*:records-produced-total",
          "kmf.services:type=consume-service,name=*:records-consumed-total",
          "kmf.services:type=consume-service,name=*:records-lost-total",
          "kmf.services:type=consume-service,name=*:records-duplicated-total",
          "kmf.services:type=consume-service,name=*:records-delay-ms-avg",
          "kmf.services:type=produce-service,name=*:records-produced-rate",
          "kmf.services:type=produce-service,name=*:produce-error-rate",
          "kmf.services:type=consume-service,name=*:consume-error-rate"
        ]
    }
}

It appears this commit modified the method signature of the KafkaMetricReporter service, thus causing it to fail.

Hello Joshua, please refer to the excerpt from my log. Also, your PR's CI travis build is currently failing. please check.
The HEAD of the master branch seems to be working fine on my end. Have you tried running
./gradlew clean build && ./gradlew jar && ./bin/kafka-monitor-start.sh config/kafka-monitor.properties
with (of course) at least on kafka server and zookeeper server running?
kmf:type=kafka-monitor:offline-runnable-count=0.0
kmf.services:name=single-cluster-monitor,type=produce-service:produce-availability-avg=1.0
kmf.services:name=single-cluster-monitor,type=consume-service:consume-availability-avg=1.0
kmf.services:name=single-cluster-monitor,type=commit-availability-service:offsets-committed-avg=1.0
kmf.services:name=single-cluster-monitor,type=commit-availability-service:failed-commit-offsets-avg=0.0
kmf.services:name=single-cluster-monitor,type=produce-service:records-produced-total=776.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-consumed-total=754.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-lost-total=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-lost-rate=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-duplicated-total=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-delay-ms-avg=3.282493368700265
kmf.services:name=single-cluster-monitor,type=produce-service:records-produced-rate=12.970949085681811
kmf.services:name=single-cluster-monitor,type=produce-service:produce-error-rate=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:consume-error-rate=0.0
kmf.services:name=single-cluster-monitor,type=commit-availability-service:offsets-committed-total=10.0
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-avg=2.7
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-max=11.0
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-99th=10.995601759296282
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-999th=10.995601759296282
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-9999th=10.995601759296282
kmf.services:name=single-cluster-monitor,type=commit-availability-service:failed-commit-offsets-total=0.0
 (com.linkedin.kmf.services.DefaultMetricsReporterService)
[2020-04-09 15:44:18,184] INFO ==============================================================
kmf:type=kafka-monitor:offline-runnable-count=0.0
kmf.services:name=single-cluster-monitor,type=produce-service:produce-availability-avg=1.0
kmf.services:name=single-cluster-monitor,type=consume-service:consume-availability-avg=1.0
kmf.services:name=single-cluster-monitor,type=commit-availability-service:offsets-committed-avg=1.0
kmf.services:name=single-cluster-monitor,type=commit-availability-service:failed-commit-offsets-avg=0.0
kmf.services:name=single-cluster-monitor,type=produce-service:records-produced-total=794.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-consumed-total=772.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-lost-total=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-lost-rate=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-duplicated-total=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:records-delay-ms-avg=3.2629533678756477
kmf.services:name=single-cluster-monitor,type=produce-service:records-produced-rate=13.272265311580638
kmf.services:name=single-cluster-monitor,type=produce-service:produce-error-rate=0.0
kmf.services:name=single-cluster-monitor,type=consume-service:consume-error-rate=0.0
kmf.services:name=single-cluster-monitor,type=commit-availability-service:offsets-committed-total=11.0
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-avg=2.6363636363636362
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-max=11.0
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-99th=10.995601759296282
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-999th=10.995601759296282
kmf.services:name=single-cluster-monitor,type=commit-latency-service:commit-offset-latency-ms-9999th=10.995601759296282
kmf.services:name=single-cluster-monitor,type=commit-availability-service:failed-commit-offsets-total=0.0
 (com.linkedin.kmf.services.DefaultMetricsReporterService)```

Your log appears to be the DefaultMetricsReporterService which does work as expected.  My issue is with the KafkaMetricsReporterService; class.name: com.linkedin.kmf.services.KafkaMetricsReporterService.  I'll check the CI travis build.


Dynamic tokens not working?

Hi there, thanks for your work on this plugin. I just started playing with Agora earlier today, and this has made it really easy to get up and running with WebGL builds.
I was able to run the multi-channel-example scene in-browser using a test token generated via the Agora web UI. However, I'm having some issues using tokens I generate myself. In my test, I'm creating the token using the AgoraDynamicKey tool. It works as expected in the editor and a standalone Mac build, but WebGL builds error with AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: invalid token, authorized failed (Chrome, Safari).
I'm not sure if this is an actual bug with this plugin, or if I'm just missing some sort of setup/configuration step. I've been banging my head against this issue for several hours now with no luck, so hopefully you can get me pointed in the right direction.
Here's some pseudo-code showing what I'm doing. I can put together a full reproduction if needed, let me know.
public class VideoChatTest : MonoBehaviour {
  AgoraChannel channel;

  [SerializeField]
  string channelName;

  void Start() {
    channel = IRtcEngine.QueryEngine().CreateChannel(channelName);

    // … callback config
  }

  public void Join() {
    uint uid = GetMyUid();
    string token = GetToken(uid);

    channel.JoinChannel(token, null, uid, new ChannelMediaOptions(true, true));
    channel.Publish();
  }

  // Pretend this is happening on a server, it is in my actual implementation :)
  void GetToken(uint uid) {
    AccessToken token = new AccessToken(appId, appCertificate, channelName, uid.ToString());

    // Editor works fine without explicitly adding these, seems to make no difference for web
    token.addPrivilege(Privileges.kJoinChannel, 0);
    token.addPrivilege(Privileges.kPublishAudioStream, 0);
    token.addPrivilege(Privileges.kPublishVideoStream, 0);
    token.addPrivilege(Privileges.kPublishDataStream, 0);

    return token.build();
  }

}

An update after running a test suggested by Ekaansh in the Agora Slack. I'm also opening a support ticket as requested, as this does appear to be a bug.
I used tokens generated from my app in the Unity editor and a WebGL build on https://webdemo.agora.io/basicVideoCall/, as well as a no token control. Details and results below:
App ID: f9a2e80c9d124fdc9a69ded13ab9c726
Channel Name: test-channel

No token result: AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: flag: 4096, message: AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: dynamic use static key
Token from editor: 006f9a2e80c9d124fdc9a69ded13ab9c726IAB5TAT0Y7+o+IN23b0L2gsXFqpmku3+K5XUjDmF1C5KxmLMzZANvtUaIgBxgKpCk13XYQQAAQAAAAAAAgAAAAAAAwAAAAAABAAAAAAA
Editor UID: 2
Editor token result: Success!
Token from WebGL: 006f9a2e80c9d124fdc9a69ded13ab9c726IAAHReq3yF4Bdi+lYjF7SpFtz11x+XLMLHmvzqVDO6H+lWLMzZDhJV2hIgCkMdspsmfXYQQAAQAAAAAAAgAAAAAAAwAAAAAABAAAAAAA
WebGL UID: 10
WebGL token result: AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: flag: 4096, message: AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: invalid token, authorized failed

Sorry, just realized I forgot to include the most important part of this test! I used the token that I confirmed works in the Unity Editor and in the https://webdemo.agora.io/basicVideoCall/ demo in a WebGL build, and it gave the same error. AgoraRTCError CAN_NOT_GET_GATEWAY_SERVER: invalid token, authorized failed

Hi @icywind can you take a look at this issue?

I will continue the thread on Slack for easier discussion

This is resolved with https://github.com/AgoraIO-Community/Agora_Unity_WebGL/pull/13


Examples using Modules syntax of CF worker scripts

Would love to see an example of itty router being used in Modules syntax.
Thanks

Hey there!
I have a simple example on the README already:

I'll add it (with link) to the features or description though.
So in modules, nothing really changes except the worker export/fetch signature... and because itty naturally passes any additional arguments that handle is called with into the request handlers themselves, it works perfectly with the "new" signature. :)

Awesome @toinbis - glad to here it!  I was happy to see (purely by luck) the (request, ...anything) interface we picked for itty's handlers, although slightly different from the familiar (request, response, next) pattern of express, worked flawlessly with CF's decision to pass the env as an additional params, where other libraries adhering more strictly to express patterns don't seem immediately compatible with the new module syntax.
Happy little accident! #bobross

Interesting insight, thanks for sharing @kwhitley ! I think this issue can be considered as worth closing by now - but am kindly leaving this decision for you! :)
Thanks again for creating itty router!

I'll just add a note here that I succesfully managed to use itty-router in cf worker script written using ES6 Module Syntax.
src/index.ts:
import { worker } from './worker'
export default worker

src/worker.ts:
import { router } from './router'

// type from https://github.com/cloudflare/workers-types/blob/b1126ca31d2dc6e69d27dae740a7ffbcc0c8acd7/index.d.ts#L734
const worker: ModuleWorker = {
  fetch: router.handle
}

export { worker }

Thanks a lot @kwhitley !

For me, it says: "TS2304: Cannot find name 'ModuleWorker'". What else did you do?


［ALLUXIO-2661］Make ResourcePoolTest final

https://alluxio.atlassian.net/browse/ALLUXIO-2661

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15406/
Test PASSed.

Merged build finished. Test PASSed.


Core: Enforce semicolons after various macros

Implementation of semicolons after most macros has been inconsistent across the repo, but appears to be generally preferred stylistically. This PR aims to make the process uniform by taking several common macros & appending a new macro to the end of them: _FORCE_SEMICOLON_. This is a simple wrapper around static_assert(true) which has the benefit of mandating a semicolon after a macro WITHOUT compiling any extra code in the process. No associated .git-blame-ignore-revs commit, as there's different functionality despite the surface-level visual change.

I don't think it makes sense to enforce this for GDCLASS, sure it might look better but it's technically wrong, so I's say it's just adding a lot of noise for a minor visual detail
For the cases where the macro actually contains a statement that needs termination I'd say it's good to ensure it's correct, i.e. if the macro contains a semicolon already, to remove it, and when there's a disabled version of it to add enforcement there to make sure it's caught
But otherwise I think this just adds a ton of noise for entirely stylistic reasons, as there's no actual need to enforce it in those cases

Ohh, I'm not certain if there's a non-zero effect on compile time. Changing it to instead be a codestyle change would wholly eliminate potential ambiguity, which is indeed very different but that's not necessarily a bad thing. Perhaps it could take the form of a pre-commit hook check?
Gonna opt to make this a template to cut down on noise while I look into potential alternatives.

I'm compiling now to check impact there

It seems my initial direction was misguided. Closing.

@Repiteo
Apologies for my wording. I wasn't expecting this issue to be closed without any debate. As many reviewers and interested parties, I am merely adding in a dissenting opinion to form the basis for debate: in many code style issues there is not one right answer, but there are arguments in each direction and sometimes a pushback to change.
When you replied suddenly that you "direction was misguided" in response to me merely expressing my personal opinions and preferences (I don't work for godot or anything), it makes me believe that I may have presented my argument in an inappropriate way.
I always like to consider both sides in a debate and your idea was not without merit of its own so I find this change of mind very rapid
I do hope my comment did not come off wrong, and I apologize.
Either way I wish you best and hope this won't discourage your future contributions. Even holding this debate here is a contribution: someone had to suggest the idea of semicolons after macros.

I appreciate you reaching out to clarify, but I promise that I took no offense to you words nor believed they came off in any coarse/rude manner. It arguably was rash to close this as quickly as I did, but I more attribute that to simply not considering other avenues and possibilities when making the PR in the first place. With that realization in mind, I wasn't interested in dying on this hill nor keeping up with rebasing until a concrete direction was formed.
With that all said, I'm not discouraged at all; on the contrary, I'm already brainstorming other PRs as we speak! This wasn't my first time jumping the gun with an idea and it won't be the last 😎


Support Realm 1.0

Support Realm 1.0 to fix #89

Closed? Is there a new release we can use? Right now 0.2.14 isn't compatible.


Added the Slot class header + cpp files.

Added a class (Slot), plus tweaked MainForm.h to not include definition for a button click function.

This works great but the files are excluded from the project. Can you add them to the project?


chore: sync lock file

Summary
Syncs the lock file
Test plan
Existing tests
Checklist
Please add a x inside each checkbox:

[x] I have read the contribution guidelines.
[x] Code is formatted via running yarn format.
[x] Tests are passing via running yarn test.
[x] The status checks are successful (continuous integration). Those can be seen below.

A picture of a cute animal (not mandatory but encouraged)
🐟

No longer required


Added Custom 404 Error Page

Description

Added custom 404 page.
Motivation and Context

Replace the default Docusaurus 404 component.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[x] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@sweeneyskirt-sl and / or @kimsauce could you take a look at this and let me know what you think? I did some basic styling but if you have suggestions let me know. BTW you have to test via npm run build + npm run serve, it won't work on the client side with yarn start || npm run start

Hi @spider-sauce , it worked perfectly and love the gif!
The only thing I might change is maybe shrinking the image a little bit so that you can see the text below it. I had to zoom out in my browser to 75% in order to see everything.

@kimsauce, I shrunk the image proportionally (50%), if you want to check again. Let me know if it still looks funky.

righteous. :shipit:

@sweeneyskirt-sl , do you think we'll get pushback on accessibility because it's a .gif and not a static image? On one hand it's an error page, so maybe it's not as crucial? 🤷


Request to call pdf-view-plus

Hi! I'd like to use pdf-view-plus instead of pdf-view, but the "Open PDF in Atom Workspace" preference toggles only ON/OFF; any chance this could be made to work with pdf-view-plus (and perhaps fall back to pdf-view in the absence of the newer package)?

Hello, sorry, but I will no longer maintain the project.
This project is archived because the owner no longer uses the Atom Editor.
It would be very good to find a new owner for this project, who will take care of updating and expanding the Atom package. A new version based on Chrome Headless has already been prepared in a feature branch.


Several improvements to deploy subnet script

Fix relayer not starting due to missing argument
Fix bug when default-key was first in the json array
Streamline local deployment by introducing a prepare_local.sh script
Improve documentation for local deployment and document more known issues
Fix Mac support

Closes ENG-849
Closes ENG-857

@raulk I updated the PR so it renames the ipc folder (to include a timestamp) when the script runs so nothing gets deleted


ete3 install needs changing

I think in the install from source , you may need to update the initial step to
conda install -c etetoolkit ete3
condaforge seems to not have ete3 anymore , though might have been a problem specific to my set up

Hi
Thanks for using read2tree.
It should be possible to install from both channels : etetoolkit and conda-forge.
https://anaconda.org/conda-forge/ete3
Best regards,
Sina

You are right , Its now working . I think initial issue was due to my set up . Thanks for the prompt response


Development Environment for dapp developers: Devchain

Expected Behavior
Please describe the behavior you are expecting
Current Behavior
What is the current behavior?

Closing as other issues exist around this topic.


feat:add common api for etcd v2

@M1serry

@M1serry Next, complete Github Actions to run unit tests and automate releases.


Deal with Bad Migration When Extending Persisted Entity

Added a test to demonstrate the behavior, have to jump through some hoops to get there but that might be useful in the future.
Fix uses the IsOfType as the type if the type is not specified and there is not a prior metch using the old logic. That is not enough as the matching is more eager than before so also keep trck of matches made and don't reuse a target fragment that has already been matched.

Hi @montanehamilton, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@montanehamilton, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Added IDisposable's recommended refactor as it passed all tests as well.

@anpete , I am not seeing any nightly builds yet, is it me or are they not working yet?

@montanehamilton your changes should be in this nightly build:  http://myget.org/feed/aspnetwebstacknightly/package/nuget/EntityFramework/6.2.0-alpha1-50813

Thank you, I think there was some user error on my part since the build was there on the 15th!


Setup file not deleted after update, which prevents autoupdating next time

Brief description of your issue
When SystemInformer is autoupdating, a systeminformer-setup.exe file is created inside the program directory. This file is not deleted after the autoupdate, which prevents further autoupdates (they fail with an error) until I manually remove this leftover file.
This issue was nonexistant when the project was still named Process Hacker.
Steps to reproduce (optional)

Autoupdate SystemInformer
Observe the systeminformer-setup.exe file in the program directory
Wait for another autoupdate
Try to update - the update will fail
Remove systeminformer-setup.exe from the program directory
Try to update again - it will be successful
Observe the systeminformer-setup.exe in the program directory again

Expected behavior (optional)
The systeminformer-setup.exe should be automatically deleted either after an update or before starting a new one.
Actual behavior (optional)
The leftover systeminformer-setup.exe is preventing the autoupdate, errorring out.
Environment (optional)
System Informer
Version: 3.0.6303 (8f3d619)

Windows 11 Enterprise

The systeminformer-setup.exe should be automatically deleted

The setup file doesn't get deleted because it's also the uninstaller and repair install option, If you delete the file then you won't be able to repair or uninstall.

prevents further autoupdates (they fail with an error) until I manually remove this leftover file

The updater moves the current setup.exe into the trash and renames update.exe to setup.exe before each update. The setup.exe version should always have the same version as all the other binaries in the folder. Moving the current file into the trash should always succeed (even when something else is using the file) unless the you have a custom directory permission preventing access?

Try to update - the update will fail

What error are you seeing when trying to update?

Seems like the error is gone now. Maybe got fixed along some partly related changes. Maybe I got some weird misconfiguration. All is well right now though.


Using string getters / setters with custom junction table values

I'm running into some confusion with using custom getters / setters and a custom junction table value in the same behavior. I need to set a field called 'order_num' with the array index of the corresponding 'team_members' value that is being set from the string setter function:

public function getEmployees() {
    $query = $this->hasMany(Employees::className(), ['employee_id' => 'employee_id'])
                           ->viaTable('departments_teams_assign', ['team_id' => 'team_id']);
    $query->andWhere('status = 1');
    return $query;
}

...

'class' => ManyToManyBehavior::className(),
'relations' => [
    'team_members' => [
        'employees',
            'fields' => [
                'string' => [
                    'get' => function($value) {
                        return implode(',', $value);
                    },
                    'set' => function($value) {
                        return explode(',', $value);
                    },
                ],
            ],
            'viaTableValues' => [
                'order_num' => function() {
                    //need to set as the array index of the above value
                },
        ],
    ],
]

For example - if my input data is a string consisting of the values "56, 25, 14, 108" the corresponding db table values should look like:

team_id
employee_id
order_num

88
56
1

88
25
2

88
14
3

88
108
4

If feel like there is a fairly simple solution, but I can't seem to figure it out. Please let me know if you can help.
Thank you.

                'class' => \voskobovich\behaviors\ManyToManyBehavior::className(),
                'relations' => [
                    'tag_ids' =>
                        [
                            'tags',
                            'viaTableValues' => [
                                'sortOrder' => function($model, $relationName, $attributeName, $relatedPk) {
                                    return array_search($relatedPk, $model->tag_ids);
                                },
                            ],
                        ]
                ],
            ],`

Thank you. I came to a similar solution shortly after I posted this.


Error: Cannot find module 'angular'

We keep getting the error:
gulp-notify: [Compile Error] Error: Cannot find module 'angular' from '/........./assets/bower_components/angucomplete-alt'
Even if angular is required like this on the main file:
require '../bower_components/angular/angular'
Is there any documentation about how angucomplete-alt wants angular to be required?
Thanks!

same error using Angular AMD. @raulsann  any luck ?

I'm facing the same error using angular 1.5.0 with electron.