Decimals() is not functioning properly

Godot version: 3.0.6.stable.official.8314054
OS/device including version: Windows 10
Issue description:
The function Decimals returns 0 even when I have a decimal number.
information in Godot's API reference:
    float decimals ( float step )
    Returns the position of the first non-zero digit, after the decimal point.
    # n is 2
    n = decimals(0.035)

Steps to reproduce:
code used:
func _ready():
        var temp_wind = 0
        randomize()
        wind_speed = round(rand_range(50, 100)) #get a rounded number between 50 and 100
	temp_wind = wind_speed / 2 #divide by 2, so all odd numbers should have 1 decimal now
	if decimals(temp_wind) == 0:
	wind_speed = -wind_speed  #is always called even if temp_wind is an x.5 value

Minimal reproduction project:
Debug Project.zip
In order to easily reproduce just relaunch project over and over untill you get an odd value, or just assign wind_speed directly with a non random odd number.  In the debug project I've made sure to print the result in the debug window yielding:
running cmdline: "C:\Program Files (x86)\Steam\steamapps\common\Godot Engine\godot.windows.opt.tools.64.exe" "--path" "C:/games/Projects/Debug%20Project" "--remote-debug" "<IP_ADDRESS>:6007" "--allow_focus_steal_pid" "396" "--position" "448,240" "res://scene.tscn"
** Debug Process Started **
OpenGL ES 3.0 Renderer: GeForce GTX 960/PCIe/SSE2
**25.5 contains no decimals**
** Debug Process Stopped **

I hope this information suffices to look into the issue.
Thanks in advance!

temp_wind = wind_speed / 2 is this an integer division?

temp_wind = wind_speed / 2 is this an integer division?

Thanks for your response but issue is with decimals() function not with the division.  To prove it: just try my debug project but simply state 'temp_wind = 22.5' instead of 'temp_wind = wind_speed /2'.  The result will still be: '22.5 contains no decimals'

I'm seeing the problem in the master too, a more direct example is print(decimals(22.5)), which I'm guessing should return 1, but returns 0.

I've been playing around with some different values:
print ("result of decimals(1.0) is " + str(decimals(1.0)))
print ("result of decimals(1.1) is " + str(decimals(1.1)))
print ("result of decimals(1.01) is " + str(decimals(1.01)))
print ("result of decimals(1.001) is " + str(decimals(1.001)))
print ("result of decimals(0.0) is " + str(decimals(0.0)))
print ("result of decimals(0.1) is " + str(decimals(0.1)))
print ("result of decimals(0.01) is " + str(decimals(0.01)))
print ("result of decimals(0.001) is " + str(decimals(0.001)))
print ("result of decimals(0.05) is " + str(decimals(0.05)))
print ("result of decimals(0.005) is " + str(decimals(0.005)))
print ("result of decimals(0.055) is " + str(decimals(0.055)))
print ("result of decimals(1.05) is " + str(decimals(1.05)))
print ("result of decimals(1.005) is " + str(decimals(1.005)))
print ("result of decimals(1.055) is " + str(decimals(1.055)))
Which yielded:
result of decimals(1.0) is 0
result of decimals(1.1) is 0
result of decimals(1.01) is 0
result of decimals(1.001) is 0
result of decimals(0.0) is 9
result of decimals(0.1) is 1
result of decimals(0.01) is 2
result of decimals(0.001) is 3
result of decimals(0.05) is 2
result of decimals(0.005) is 3
result of decimals(0.055) is 2
result of decimals(1.05) is 0
result of decimals(1.005) is 0
result of decimals(1.055) is 0
From my tests it seems that decimals() is returning 0 for any value greater than 1.0 and has an issue with the number 0 as that returns a result of 9.

The function seems to work fine, it's just that it's kind of pointless. The docs are slightly unclear when they say "Returns the position of the first non-zero digit, after the decimal point.", as they should say "Returns the position of the first non-zero digit, taking into account the integral part."
So decimals(0.025) returns 2 (first non-zero digit is the second decimal), but decimals(1.025) returns 0 (first non-zero digit is "1", the integral part, so the 0-th decimal).

See also #1955 which was fixed by 7a931b4d.

Thanks for you reply!
May I ask why decimals(0) returns a value of 9 then though?  Shouldn't it return 0?

May I ask why decimals(0) returns a value of 9 then though? Shouldn't it return 0?

Probably because some casting happens internally from int to float and 0 becomes something like 0.0000000034 so it finds the first non-zero digit in position 9.
In any scenario this method is bogus as heck and I suggest that we drop it as soon as we can :P

Deal!
I'll just use another way to randomly decide if my clouds go left or right ;-)

See also https://github.com/godotengine/godot/pull/21425 which renames this function to step_decimals, which is the name used internally.

With all due respect, but I disagree. I'm wondering why you would call a function 'decimals' if it includes checking the integral part? If I were to look at that kind of function without prior knowledge, I'm quite certain I'd assume it to focus solely on the part after the comma, i.e. decimals.
After checking the docs, it does state so quite clearly, too: 'Returns the position of the first non-zero digit, after the decimal point.'
I've played around with the function a bit, and I'm wondering, is it acceptable to cast to String within the math-class? Also, it seems to work fine without referencing 'ustring.h' at the top, but is it the standard to do so, anyway?
Sorry, I'm relatively new to C++ and am trying to cover all my bases, as well as the best coding practices for Godot, before creating a Pull Request.
Thanks in advance!

@DeuxAlpha I would say that it underflows relative to the string representation.

Agreed, I was able to ramp the precision up to 14 decimal places within the string-method, but I don't want to rely on it in this instance. I'll try to approach it from another angle. Thanks for the input @aaronfranke!

If someone can fix the implementation so that it behaves like described in the docs (i.e. strip the integral part and the count number of leading zero digits / place of the first non-zero digit), that would be welcome. I don't think a String approach would be good though, that's likely to be very slow.

Looks great! How does it handle print(decimals(0.0)) with potential internal floating point errors?

print(decimals(0.0)) returns 9 right now (and before) but I think I should change it to 0.
The way it handles floating precision errors (the same as it did before) is by comparing the numbers to 0.09999, etc, instead of 0.1.

I initially misunderstood that a decimal counter.
I haven't yet run into a situation where I need to know the decimal position of the first none zero decimal place.  Now I'm very curious what this gets used for generally?


Copy previous revision on remote before rsync for faster deploys.

@timkelty yes I had this idea, you want to make a remote "cp" and then do the rsync? It's a very nice feature!

Yep!

Done in shipit-deploy


ERROR: Signature extraction failed: Traceback (most recent call last):

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.04.28. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.04.28

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl SHip2-g_8Gk --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'SHip2-g_8Gk', u'--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.04.11
[debug] Python version 2.7.13 - Darwin-16.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] SHip2-g_8Gk: Downloading webpage
[youtube] SHip2-g_8Gk: Downloading video info webpage
[youtube] SHip2-g_8Gk: Extracting video information
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {22} signature length 40.40, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1081, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 969, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://www.youtube.com/yts/jsbin/player-vflppxuSE/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError(u"Cannot identify player u'https://www.youtube.com/yts/jsbin/player-vflppxuSE/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1081, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 969, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://www.youtube.com/yts/jsbin/player-vflppxuSE/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 761, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 429, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1670, in _real_extract
    encrypted_sig, video_id, player_url, age_gate)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1091, in _decrypt_signature
    'Signature extraction failed: ' + tb, cause=e)
ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1081, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 969, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://www.youtube.com/yts/jsbin/player-vflppxuSE/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError(u"Cannot identify player u'https://www.youtube.com/yts/jsbin/player-vflppxuSE/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

This is already fixed in version 2017.04.28

I'm sorry for the late response. I can confirm that everything is ok. My app was using an embeded executable of youtube-dl which wasn't updated automaticaly. Many thanks for your fast response


Two builds started in the same minute interfere

Description
Design hardening is a process that takes a lot of time and is a very linear process. Developers who want to run experiments need to wait for the design to finish in order to read the results of an experiment.
It is possible to run multiple experiments at once by simply opening up multiple terminals. This allows the developer to start a build, make a change, then start a second build. An example of this might be to build a design for both SKY130 and GF180 at the same time.
However, builds started within one minute of one another run the risk of using the same output directory, resulting in confusing error messages.
Expected Behavior
Builds should never be able to share the same output directory.
Environment report
Kernel: Linux v<IP_ADDRESS>-microsoft-standard-WSL2
Distribution: ubuntu 22.04
Python: v3.10.6 (OK)
Container Engine: docker v20.10.21 (OK)
OpenLane Git Version: cb59d1f84deb5cedbb5b0a3e3f3b4129a967c988
pip: INSTALLED
python-venv: INSTALLED
---
PDK Version Verification Status: OK
---
Git Log (Last 3 Commits)

cb59d1f 2022-11-18T18:42:38+02:00 fix return values in `equally_spaced_sequence` (#1503) - Kareem Farid -  (grafted, HEAD, tag: 2022.11.19)
---
Git Remotes

origin  git@github.com:The-OpenROAD-Project/OpenLane (fetch)
origin  git@github.com:The-OpenROAD-Project/OpenLane (push)

Reproduction material
This should occur with any design where synthesis takes enough time to be able to go into another window and run a second build.
Relevant log output
[ERROR]: during executing openroad script /openlane/scripts/openroad/floorplan.tcl
[ERROR]: Log: ../si/work/caravel-gf180-pio/openlane/wb_pio/runs/22_12_23_15_56/logs/floorplan/3-initial_fp.log
[ERROR]: Last 10 lines:
[WARNING ORD-1013] instance _17949_ LEF master sky130_fd_sc_hd__conb_1 not found.
[INFO]: Setting output delay to: 2.4000000000000004
[INFO]: Setting input delay to: 2.4000000000000004
[INFO]: Setting load to: 0.033442
[INFO]: Setting clock uncertainty to: 0.25
[INFO]: Setting clock transition to: 0.15
[INFO]: Setting timing derate to: 0.5 %
[WARNING IFP-0009] SITE unithd not found.
Error: floorplan.tcl, 70 TypeError in method 'insert_tiecells_cmd', argument 1 of type 'odb::dbMTerm *'
child process exited abnormally

This is apparently not an openlane issue, it's an issue with https://github.com/efabless/caravel_user_project/

Opened the issue on caravel_user_project: https://github.com/efabless/caravel_user_project/issues/236


feat(quote): add sig/pubkey crypto and some quote header types

Part of #74

Just fixing some tests. I'll make those changes

Got this working with no_std :)

reopening to run ci

@npmccallum This can be merged in and I can create another PR with the rest of the quote structs


Add social preview to GitHub repository

https://socialify.git.ci/gomzyakov/secretic?description=1&font=Raleway&pattern=Solid&theme=Dark

Finally looks like:


Clarification on ECR Policy Permissions

https://github.com/awsdocs/aws-lambda-developer-guide/blob/main/doc_source/configuration-images.md#update-the-user-permissions

Are these permissions needed for the principal that will be creating the function if the ECR repo already has a policy statement that will allow the Lambda service principal to retrieve the image?
Is the ecr:InitiateLayerUpload permission needed because a new, Lambda optimized image is pushed to the customer ECR repo after a function is created with it? If not, why is that permission needed?

Thank you for posting these questions. This section of the document was not correct. You do not add permissions to the
principal that will be creating the function, and ecr:InitiateLayerUpload permission is not required.
I have updated the web documentation, and will refresh the Github version soon. There are currently 2 scenarios:
a. You can add ecr:BatchGetImage and ecr:GetDownloadUrlForLayer for principal lambda.amazonaws.com in the repository’s resource policy.
b. If the calling Principal has ecr:getRepositoryPolicy and ecr:setRepositoryPolicy,  Lambda will automatically create a Repo policy or update the Repo policy to include ecr:BatchGetImage and ecr:GetDownloadUrlForLayer.
Details are here:
https://docs.aws.amazon.com/lambda/latest/dg/configuration-images.html#configuration-images-permissions


doc.rs build is failing

It looks like the build is failing because a C++ file is missing, probably not included in the Cargo.toml file to be uploaded or something?
https://docs.rs/crate/imgui/0.8.2/builds/482652

Yep the freetype.cpp was unintentionally excluded from the .crate, which caused builds to fail when a) using the crate and b) using freetype feature (whereas if you built from git it worked fine)
This should all be fixed in the patch-0.8 branch (#629 and specifically 155e7584db6108dcc57e2822aeb346613c5b4bbb) - we just need to make a new 0.8.3 release to fix this - @sanbox-irl ?

Currently the repo displays the latest main, wherein none of the examples match the API that you get from pulling 0.8.2, which that documentation you can't even see (in the accustomed format) because the doc.rs build is failing. So, to learn how to use the current available imgui-rs, you have to swap the github repo (or pull) to 0.8.2 and browse it by hand.
Rather confusing.

It looks like I still have publish privileges, so if @sanbox-irl is too busy I can cut a 0.8.3.

Okay. I'll do it tomorrow, when I have a little more time. I'll also try to update the bundled imgui, do we have documentation for the process there? (I believe the docs I wrote a while ago on it have fallen out of date(

It looks like updating imgui to 1.87 will be a breaking change, so I'll hold off on that til after.

Fixed a while ago with 0.9 release


Input : controlled, uncontrolled, free?

Should we force input to be controlled?
If not, in case of controlled input, should we simplify the onchange, by sending back directly the new value?

Yep, I'm for controlled input


Guard running specs in :development regardless of gemfile

See this link for a description of the problem that I'm having.
It seems that guard is running development mode regardless of which group it is in in the Gemfile.  This causes FactoryGirl to use the development database instead of the test database.
However, if I start guard this way: RAILS_ENV=test bundle exec guard it runs everything in test mode like it should.  This continues even if I change my gemfile to read:
# Testing Gems
gem "factory_girl_rails", :group => :test
gem "guard", :group => :test
gem "guard-rspec", :group => :test

group :development do
    gem "capybara"
    gem "rspec-rails"
    gem "ruby_gntp", :require => false
    gem "addressable"
    gem "launchy"
end

This seems to be a guard bug; shouldn't it recognize that it is in the test group and run in test mode?  I would expect that if I run bundle exec guard, not having to specify environment every time I start it.

and when you launch RSpec via rake or the rspec command line the good environment is set? Can you also share your spec_helper.rb please?

try to replace:
ENV["RAILS_ENV"] == 'test'

by
ENV["RAILS_ENV"] = 'test'

It should work better :)

Daniel Berkompas
Web Application Developer
ClearSight Studio http://www.clearsightstudio.com |<PHONE_NUMBER>
Thanks much!  That was a lot easier than I was making it.
On Mon, Feb 13, 2012 at 12:22 PM, Thibaud Guillaume-Gentil <
<EMAIL_ADDRESS>
wrote:

try to replace:
ENV["RAILS_ENV"] == 'test'

by
ENV["RAILS_ENV"] = 'test'

It should work better :)

Reply to this email directly or view it on GitHub:
https://github.com/guard/guard-rspec/issues/93#issuecomment-3948499


how to initialize the student model's weights?

Hi, I'm impressed by your work.
I have a question about the train_flux_distill.py.
For training from scratch, without using flux-mini weights, I couldn't find where the pick_up_weights function is called for the student model initialization.
I wonder how to set the initial weights for the student model.
Thanks in advance.

Thank you for your attention.
The double blocks of the student are initialized with the [0, 1, 2, 10, 18]-th double block of the teacher, and single blocks are initialized with [3, 7, 11, 15, 19, 23, 27, 31, 35, 37]-th single block of the teacher.
The pick_up_weights function should be called when loading the student model... We will fix the code soon.

@daoyuan98 thank you for your quick reply.
I have another question.
Is it possible to train the flux-mini using using train_flux_distill.py with 1024px in an 8xA100(80GB) GPU machine?
I wonder about the exact GPU environment when you trained the flux-mini model.
Thanks in advance.

Is it possible to train the flux-mini using using train_flux_distill.py with 1024px in an 8xA100(80GB) GPU machine?
Yes, I think that should be ok for you to train flux-mini under our setting.

I wonder about the exact GPU environment when you trained the flux-mini model.
Our training was mainly conducted on ASCEND 910B NPUs, each node has 16 NPUs. When setting batch-size=1 and 1024px on each NPU, (with deepspeed stage=2) each node takes about 60GB NPU memory. I think the memory cost should be similar on GPUs.

@daoyuan98 Thanks for your quick reply.
I wonder why you set different indice to match between slim and target in double-stream transformer blocks, unlike the single-stream blocks.

distill_slim_double: [0, 1, 2, 10, 18]
distill_target_double: [3, 7, 11, 15, 18]
distill_slim_single: [3, 7, 11, 15, 19, 23, 27, 31, 35, 37]
distill_target_single: [3, 7, 11, 15, 19, 23, 27, 31, 35, 37]

Because we empirically found some double blocks are especially important (i,e,m 0,1,2,10,18), removing them leads to corrupted generation results. While in single blocks, the blocks are not that important, so we use an interval of 4 to initialize the student models.

@daoyuan98 I also found that the initial blocks in double stream blocks are more important than others, but I'm curious about the intention that you set the different indices target against the slim_double,e.g., 0 <-> 3, 1 <-> 7, 2 <-> 11, etc.


Test langs

noticed that every collection update was doubling the language setting if set. [en] -> [en, en].

fixes another ui inconsistency with not deleting second language if first is set to that language

https://github.com/lbryio/lbry-redux/pull/430 dependency


Typescript support broken

Description

Class function refactor broke typescript support. Issue identified here:
https://github.com/adobe/leonardo/issues/113#issuecomment-926028897
Steps to reproduce

Expected behavior

Screenshots

Leonardo package and version

alpha.9+
Environment

Browser(s) and OS(s):

Additional context

Is this lib still maintained? Seems not usable in TS for the time being.

Yes it's still maintained. We accept contributions (including proposals) for solutions like this. I personally am not that familiar with Typescript and the best method to support it in Leonardo. Any recommendations, proposals, or PRs on this topic are welcome!


raidboss: update ShB timelines

More work on #5440 - added InCombat lines, removed unnecessary Resets, removed initial autos and added sync windows to first abilities as needed.  This PR includes everything in 05-shb.

eslint
The hosted runner: GitHub Actions 5 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

👀

Ugh.  Wonky merge again.  Will close this out and open a new PR.


Remove modules: transformation, data_ingestion, mapping_recommendation

None of these modules are needed after the API refactoring.

Works here, go ahead with the merge, thanks!


Resync from Rook master to downstream release-4.12

Description of your changes:
Resync from Rook master to downstream release-4.12. Fixes the CI issue with cephfs RWO volumes attaching on different nodes.
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
[ ] Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

@agarwal-mudit @Madhu-1 This picked up the fix for cephfs RWO volumes in 4.12


keplerExporter-serviceMonitor.yaml contains clusterrole?

Describe the bug
A clear and concise description of what the bug is.
keplerExporter-serviceMonitor.yaml has a clusterrole
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: prometheus-k8s
  labels:
    app.kubernetes.io/component: prometheus
    app.kubernetes.io/instance: k8s
    app.kubernetes.io/name: prometheus
rules:
  - verbs:
      - get
    apiGroups:
      - ''
    resources:
      - nodes/metrics
  - verbs:
      - get
    nonResourceURLs:
      - /metrics

but kube-prometheus/manifests/prometheus-clusterRole.yaml has such
so we will be reported such clusterrole exist
should we either remove this role defintion in our repo / sync the contents?
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    app.kubernetes.io/component: prometheus
    app.kubernetes.io/instance: k8s
    app.kubernetes.io/name: prometheus
    app.kubernetes.io/part-of: kube-prometheus
    app.kubernetes.io/version: 2.38.0
  name: prometheus-k8s
rules:
- apiGroups:
  - ""
  resources:
  - nodes/metrics
  verbs:
  - get
- nonResourceURLs:
  - /metrics
  verbs:
  - get

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Right, we should remove this ClusterRole from the kepler repository.
At the moment the ClusterRole is the same, but kepler should not create it, but rather update it if necessary.


pull request to merge branch hello-microverse to main

@Hadi111jafari it is always a good practice to name the branch name descriptive, i would suggest you create a new branch with all the changes required and please also look at the changes i requested. provide description to your pull request and also use the readme file, You can use the template i mentioned in the review

@Hadi111jafari Yes you should creat new PR and in the description please link this PR as well so the next code Reviewer can see what changes i requested

Ok thank you I'll do that but how do link this pull request in description ?
On 10 Feb 2022 21:00, "Ranjeet Singh" @.***> wrote:

@Hadi111jafari https://github.com/Hadi111jafari Yes you should creat
new PR and in the description please link this PR as well so the next code
Reviewer can see what changes i requested
—
Reply to this email directly, view it on GitHub
https://github.com/Hadi111jafari/Hello-world/pull/1#issuecomment-1035130539,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWIN4JDV5VH6D4LLVDDELIDU2PR35ANCNFSM5N7VBYZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Ok thanks in advance
On 10 Feb 2022 21:06, "Ranjeet Singh" @.***> wrote:

@Hadi111jafari https://github.com/Hadi111jafari just paste the link of
this PR and add text please read this PR before review.. Good luck
—
Reply to this email directly, view it on GitHub
https://github.com/Hadi111jafari/Hello-world/pull/1#issuecomment-1035136601,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWIN4JGQAEHKS5PAOPAXZ6LU2PSQLANCNFSM5N7VBYZQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>


Chapter 3.14.2 R Session Aborted when running locally

I have the following code, which matches the course solution:
library(tidymodels)
library(themis)

vote_train <- readRDS("data/c3_train_10_percent.rds")

vote_folds <- vfold_cv(vote_train, v = 10)

vote_recipe <- recipe(turnout16_2016 ~ ., data = vote_train) %>%
    step_upsample(turnout16_2016)

rf_spec <- rand_forest() %>%
    set_engine("ranger") %>%
    set_mode("classification")

vote_wf <- workflow() %>%
    add_recipe(vote_recipe) %>%
    add_model(rf_spec)

set.seed(234)
rf_res <- vote_wf %>%
    fit_resamples(
        vote_folds,
        metrics = metric_set(roc_auc, sens, spec),
        control = control_resamples(save_pred = TRUE)
    )

glimpse(rf_res)

When I run the following code chunk locally, it results in R Session Aborted.
rf_res <- vote_wf %>%
    fit_resamples(
        vote_folds,
        metrics = metric_set(roc_auc, sens, spec),
        control = control_resamples(save_pred = TRUE)
    )

I'm not sure if it is related to the ranger library, but I did not get any errors when running 3.14.1 (i.e. logistic regression) and when I updated set_engine("ranger") to set_engine("randomForest") for 3.14.2.
I can also confirm that package versions in my local align with what is present in the course.

Hmmmm, I can't reproduce this, unfortunately. When I run this locally I do see one warning related to using such a small dataset and not having any true events, but the tuning does finish:
library(tidymodels)
#> Registered S3 method overwritten by 'tune':
#>   method                   from
#>   required_pkgs.model_spec parsnip
library(themis)
#> Registered S3 methods overwritten by 'themis':
#>   method                  from
#>   bake.step_downsample    recipes
#>   bake.step_upsample      recipes
#>   prep.step_downsample    recipes
#>   prep.step_upsample      recipes
#>   tidy.step_downsample    recipes
#>   tidy.step_upsample      recipes
#>   tunable.step_downsample recipes
#>   tunable.step_upsample   recipes
#>
#> Attaching package: 'themis'
#> The following objects are masked from 'package:recipes':
#>
#>     step_downsample, step_upsample

vote_train <- readRDS("data/c3_train_10_percent.rds")

vote_folds <- vfold_cv(vote_train, v = 10)

vote_recipe <- recipe(turnout16_2016 ~ ., data = vote_train) %>%
    step_upsample(turnout16_2016)

rf_spec <- rand_forest() %>%
    set_engine("ranger") %>%
    set_mode("classification")

vote_wf <- workflow() %>%
    add_recipe(vote_recipe) %>%
    add_model(rf_spec)

set.seed(234)
rf_res <- vote_wf %>%
    fit_resamples(
        vote_folds,
        metrics = metric_set(roc_auc, sens, spec),
        control = control_resamples(save_pred = TRUE)
    )

glimpse(rf_res)
#> Rows: 10
#> Columns: 5
#> $ splits       <list> [<vfold_split[481 x 54 x 535 x 42]>], [<vfold_split[481 …
#> $ id           <chr> "Fold01", "Fold02", "Fold03", "Fold04", "Fold05", "Fold06…
#> $ .metrics     <list> [<tbl_df[3 x 4]>], [<tbl_df[3 x 4]>], [<tbl_df[3 x 4]>],…
#> $ .notes       <list> [<tbl_df[0 x 1]>], [<tbl_df[0 x 1]>], [<tbl_df[0 x 1]>],…
#> $ .predictions <list> [<tbl_df[54 x 6]>], [<tbl_df[54 x 6]>], [<tbl_df[54 x 6]…

Created on 2021-08-02 by the reprex package (v2.0.0)
Could you try running this via reprex perhaps to see if something in your environment is causing the problem?

Let me know if you are able to reproduce this problem using a reprex!


indent not following setup

VSCode Version:  1.7.2
OS Version: RHEL 7.3

Steps to Reproduce:

edit and save js file
despite the fact Indent is setup to 2 spaces, indent takes 4 spaces in file, see pic:

OK, found out, there was a plugin installed, that did the formatting regardless on vscode settings, namely: lonefy.vscode-JS-CSS-HTML-formatter


chore(deps): update dependency com.sun.xml.bind:jaxb-xjc to 2.4.0-b180830.0438

This PR contains the following updates:

Package
Change

com.sun.xml.bind:jaxb-xjc
2.2.7-b41 -> 2.4.0-b180830.0438

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (2.4.0-b180830.0438). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Getting started without node etc.

I have a designer colleague who wants to try out Polymer but the "Getting Started" section dives in pretty deep for him: installing node, bower, gulp and the getting the Polymer Starter Kit etc.
He wants to just download the .zip file and paste some .html to get him started. I imagine this would be common among designers. Should a small tutorial such as this be added to the "Getting Started" section? I can submit a PR if so.
In the meantime, I have created a .jsbin for him, but the roboto font isn't being applied. What am I missing? http://jsbin.com/pofatasoji/1/edit?html,output

Maybe he can check out the PSK light version here: https://github.com/polymerelements/polymer-starter-kit/releases/tag/v1.2.1

@grokys Even if there was a simple zip download of Polymer and all the elements you want to use, your friend would still have to run a web server to use them.  HTML Imports don't work on file:// pages.  He'd could run a node server, or a LAMP stack, or the Chrome Dev Editor which has its own built-in server.

Moving this to the docs repo for better visibility.
At least for downloading elements without bower, the Polymer Element Catalog lets you add individual elements to a collection (by clicking the star on each element, either from the list view or on the element documentation page), and then download the entire collection as a zip file. The feature isn't terribly discoverable so we're working on a refresh of the catalog.

This issue was moved to Polymer/docs#1470

@grokys the chrome dev editor makes it really easy to assemble some elements with some out of the box templates.
https://chrome.google.com/webstore/detail/chrome-dev-editor-develop/pnoffddplpippgcfjdhbmhkofpnaalpg
Thanks
Jon

Thanks @jongeho1 that's got him started! Might be worth linking to that tool somewhere...


Memory leak and segfaults in 1.7.0

Describe the bug
It seems there is a memory leak and occasional use-after-free segfaults in 1.7.0. I'm not sure whether they are related or not.
The memory leak seems to be related to freeing output buffers for child processes, while the segfaults seem to have to do with the order resources are freed in libuv callback functions.
To Reproduce
Steps to reproduce the behavior:

Run ttyd bash -c 'base64 /dev/urandom | head -n 10000' (the exact command is not important, but something that exercises buffers and automatically reconnects helps to reproduce the issue)
Open a browser tab to http://localhost:7681 and let it keep reconnecting
Run top and observe ttyd memory usage grow (until it crashes)

Expected behavior
Memory for each client's buffers are freed on disconnect, doesn't crash
Environment:

OS: Ubuntu 22.04 (x86)
Browser: Chrome 104.0.5112.79

Additional context
If ttyd is built with AddressSanitizer enabled, like by adding
add_compile_options(-fsanitize=address)
add_link_options(-fsanitize=address)

to CMakeLists.txt and running cmake . && make clean && make, then:

By stopping the process manually (ctrl-c) before it crashes, ASan prints something like this, which appears to be the source of the leak. There are also 3 other reported leaks, but those are of constant size and don't vary with the number of closed connections, so I don't think they're related.

Indirect leak of 23496 byte(s) in 6 object(s) allocated from:
    #0 0x7fbfe7dfc867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x55802b585c42 in xmalloc /workspaces/ttyd/src/utils.c:28
    #2 0x55802b58629b in pty_buf_init /workspaces/ttyd/src/pty.c:47
    #3 0x55802b5864da in read_cb /workspaces/ttyd/src/pty.c:67
    #4 0x7fbfe7ca0e87  (/lib/x86_64-linux-gnu/libuv.so.1+0x1fe87)

If we let the process run until it crashes with a segfault, a use-after-free is detected at:

==18887==ERROR: AddressSanitizer: heap-use-after-free on address 0x612000000ec8 at pc 0x55950357b11c bp 0x7ffffea6d760 sp 0x7ffffea6d750
WRITE of size 8 at 0x612000000ec8 thread T0
    #0 0x55950357b11b in process_exit_cb /workspaces/ttyd/src/protocol.c:86
    #1 0x559503579a13 in async_cb /workspaces/ttyd/src/pty.c:437
    #2 0x7f2b6a79c1ec  (/lib/x86_64-linux-gnu/libuv.so.1+0x91ec)
    #3 0x7f2b6a7b811d  (/lib/x86_64-linux-gnu/libuv.so.1+0x2511d)
    #4 0x7f2b6a7a1c87 in uv_run (/lib/x86_64-linux-gnu/libuv.so.1+0xec87)
    #5 0x55950358f217 in lws_service (/workspaces/ttyd/ttyd+0x2b217)
    #6 0x559503584aa8 in main /workspaces/ttyd/src/server.c:590
    #7 0x7f2b69fa8d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #8 0x7f2b69fa8e3f in __libc_start_main_impl ../csu/libc-start.c:392
    #9 0x559503577b54 in _start (/workspaces/ttyd/ttyd+0x13b54)

There is also another, different use-after-free segfault that can happen if a tab is closed instead of the process exiting normally. To demonstrate this, run something that will not automatically reconnect:
ttyd bash -c 'base64 /dev/urandom | head -n 10000 | less'

then connect and close the tab without quitting less. For this one, AddressSanitizer reports an issue in a different callback:
==25940==ERROR: AddressSanitizer: heap-use-after-free on address 0x6120000008c8 at pc 0x563d99e99f89 bp 0x7fff3420f850 sp 0x7fff3420f840
READ of size 8 at 0x6120000008c8 thread T0
    #0 0x563d99e99f88 in process_read_cb /workspaces/ttyd/src/protocol.c:76
    #1 0x563d99e97471 in read_cb /workspaces/ttyd/src/pty.c:64
    #2 0x7f632f6e92f2  (/lib/x86_64-linux-gnu/libuv.so.1+0x202f2)
    #3 0x7f632f6e94d7  (/lib/x86_64-linux-gnu/libuv.so.1+0x204d7)
    #4 0x7f632f6ee11d  (/lib/x86_64-linux-gnu/libuv.so.1+0x2511d)
    #5 0x7f632f6d7c87 in uv_run (/lib/x86_64-linux-gnu/libuv.so.1+0xec87)
    #6 0x563d99eae217 in lws_service (/workspaces/ttyd/ttyd+0x2b217)
    #7 0x563d99ea3aa8 in main /workspaces/ttyd/src/server.c:590
    #8 0x7f632eeded8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #9 0x7f632eedee3f in __libc_start_main_impl ../csu/libc-start.c:392
    #10 0x563d99e96b54 in _start (/workspaces/ttyd/ttyd+0x13b54)

+1. I'm also experiencing something similar, and based on description by @dmartin, it might be the same thing?
I'm using -a for permitting arguments passed in from query string.
command:
/opt/ttyd/ttyd.x86_64 -p 42071 -a watch ps
with request to:
http://:42071/?arg=aux
After a couple of minutes being connected, i start getting disconnected... The error is: `== uv_read failed with error -5: i/o error`

[2022/08/12 15:18:52:3214] N: __lws_lc_tag:  ++ [wsisrv|4|adopted] (3)
[2022/08/12 15:18:52:3216] N: HTTP / - <IP_ADDRESS>
[2022/08/12 15:18:52:4783] N: HTTP / - <IP_ADDRESS>
[2022/08/12 15:18:52:6344] N: __lws_lc_tag:  ++ [wsisrv|5|adopted] (4)
[2022/08/12 15:18:52:6347] N: WS   / - <IP_ADDRESS>, clients: 3
[2022/08/12 15:18:52:6748] N: started process, pid: 3346201
[2022/08/12 15:18:57:4809] N: __lws_lc_untag:  -- [wsisrv|4|adopted] (3) 5.159s
[2022/08/12 15:19:43:5628] N: WS closed from <IP_ADDRESS>, clients: 2
[2022/08/12 15:19:43:5629] N: killing process, pid: 3327516
[2022/08/12 15:19:43:5629] N: __lws_lc_untag:  -- [wsisrv|1|adopted] (2) 3.000min
== uv_read failed with error -5: i/o error
[2022/08/12 15:19:43:5641] N: process killed with signal 1, pid: 3327516
[2022/08/12 15:19:43:5944] N: __lws_lc_tag:  ++ [wsisrv|6|adopted] (3)
[2022/08/12 15:19:43:5947] N: HTTP / - <IP_ADDRESS>
[2022/08/12 15:19:43:6889] N: __lws_lc_tag:  ++ [wsisrv|7|adopted] (4)
[2022/08/12 15:19:43:6892] N: WS   / - <IP_ADDRESS>, clients: 3
[2022/08/12 15:19:43:7086] N: started process, pid: 3353538
[2022/08/12 15:19:48:6206] N: __lws_lc_untag:  -- [wsisrv|6|adopted] (3) 5.026s
[2022/08/12 15:20:18:0122] N: WS closed from <IP_ADDRESS>, clients: 2
[2022/08/12 15:20:18:0123] N: killing process, pid: 3346201
[2022/08/12 15:20:18:0123] N: __lws_lc_untag:  -- [wsisrv|5|adopted] (2) 1.422min
== uv_read failed with error -5: i/o error
[2022/08/12 15:20:18:0129] N: process killed with signal 1, pid: 3346201
[2022/08/12 15:20:18:0572] N: __lws_lc_tag:  ++ [wsisrv|8|adopted] (3)
[2022/08/12 15:20:18:0575] N: HTTP / - <IP_ADDRESS>
[2022/08/12 15:20:18:4676] N: __lws_lc_tag:  ++ [wsisrv|9|adopted] (4)
[2022/08/12 15:20:18:4678] N: WS   / - <IP_ADDRESS>, clients: 3
[2022/08/12 15:20:18:5078] N: started process, pid: 3358521
[2022/08/12 15:20:23:0852] N: __lws_lc_untag:  -- [wsisrv|8|adopted] (3) 5.027s

This just repeats, connections die until ttyd crashes with a segmentation fault.

Try the latest master branch, I've fixed a known issue may related to this.

@tsl0922 Thanks! In my testing I was no longer able to replicate either segfault after the changes in https://github.com/tsl0922/ttyd/commit/d7db63726c5a9cb05d25062d8b135380dfb3322d.
I was still seeing the memory leak, but seemed to be able to fix it with a tiny change in https://github.com/tsl0922/ttyd/pull/963 - let me know what you think.

Sorry, I made some comments earlier before I had done enough testing to be sure about my findings. Let me clarify now that I've done some more research:

After the changes in https://github.com/tsl0922/ttyd/commit/d7db63726c5a9cb05d25062d8b135380dfb3322d, the use-after-free segfault in process_read_cb does not seem to happen at all anymore.
The segfault in on the pss->process = NULL; line in process_exit_cb does still rarely occur, but it is more difficult to replicate. I can still cause it after about 1-2 minutes by running ttyd bash -c 'base64 /dev/urandom | head -n 10000 | less'  and holding down q in the browser to repeatedly exit the less process and reconnect.
The memory leak still seems present, but I have a small patch that appears to resolve it here: https://github.com/tsl0922/ttyd/pull/963

Thanks for taking a look at this, I really appreciate all of your work with ttyd. After https://github.com/tsl0922/ttyd/commit/6cfd9b29ae7d47aeb5e7af1ff0e951e7588d30eb I haven't been able to replicate either of the segmentation faults from the original issue anymore.
I am still seeing the pty_buf leak when the child process exits by itself (e.g. running ttyd ls and repeatedly reconnecting). From a little testing (I'm not a C or libuv expert so I might be wrong about this) it doesn't seem like process_read_cb runs again to potentially free the buffer when process exits, and also that process_free will have already run via async_cb before this code in protocol.c runs, so process will always be null and ws_closed will never get set to true in any case.
But honestly the memory leak is small and a less important issue to me - thanks again for looking into the segfault issues.

You're right, it seems lws may not invoke writable callback if the client closes the ws connection. I've made a fix on main again.

Yup, with that newest commit I no longer see the leak either. Awesome! Thanks again for investigating so quickly.

1.7.1


Unable to connect to the interface

Hardware
ESP32
Firmware version
v2.4.3
Application version
?
What happened? What did you expect to happen?
For around 10 days I have no longer been able to access espsomfy, when I try to connect to the address I have infinite loading.
I tried on 3 different esp32s (Aliexpress wroom32, Azdelivery wroom32), with version 2.4.3 and 2.4.2

How to reproduce it (step by step)
1. Go to...
2. Click on...
...

Logs
No response

Clear your browser cache.  Since you are using Chrome, hold down the ctrl key and press F5.

Thanks for your response,
i have already tried Ctrl+F5 and Ctrl+R, same result

I have tried in a different place (other wifi network), it's works well.
At home it seems that the get networksettings return null
any idea ?
On the other wifi network :
{     "get": "/networksettings",     "obj": {         "ssdpBroadcast": true,         "hostname": "ESPSomfyRTS",         "connType": 1,         "chipModel": "",         "checkForUpdate": true,         "fwVersion": "v2.4.3",         "ethernet": {             "boardType": 0,             "phyAddress": 0,             "CLKMode": 0,             "phyType": 0,             "PWRPin": -1,             "MDCPin": 23,             "MDIOPin": 18         },         "wifi": {             "ssid": "Livebox-2A90",             "passphrase": "XXXX",             "roaming": true         },         "ip": {             "dhcp": true,             "ip": "<IP_ADDRESS>",             "gateway": "<IP_ADDRESS>",             "subnet": "<IP_ADDRESS>",             "dns1": "<IP_ADDRESS>",             "dns2": "<IP_ADDRESS>"         }     } }
At home :
{"get": "/networksettings","obj": null }

Out of curiosity are you using a hidden SSID?
Open up a browser and type http://<ip address>/networksettings and lets see if if returns something other than json.

ok i got it, i've a " on my wifi password :

I am going to close this one out.  I will look at some ways to scrub the json but escaping all of the json output is probably too expensive in terms of memory since the buffer will need to forward look through all the strings.  For now don't include quotes in your passphrase.


zerver/context_processors.py uses settings.VOYAGER

In #1284 Tim mentioned we want to clean out places where we check for settings.VOYAGER. zerver/context_processors.py has:
        # We use the not_voyager variable name so that templates
        # will render even if the appropriate context is not provided
        # to the template
        'not_voyager':               not settings.VOYAGER,

The apps.html and register.html templates depend on this variable.

Currently, it's only used for a few remaining things:

Hiding the mobile apps in non-zulip.com installs (probably should just undo that for iOS now and for Android as soon as we have the updated beta app in the Play store).
Terms of service, which has an open PR to move it to its own setting.

Terms of service PR was merged, so this is now just used for hiding the mobile apps from /apps in voyager installs.  We can probably just remove those at this point.

This was resolved a couple weeks ago; we're now no longer using that setting at all.


Fix README links

What was changed

Fixed the links to the GHA; I had not realized that relative links wouldn't work.
Why?

Checklist

Closes

How was this tested:

Any docs updates needed?

Oh, I'm not trying to link to the file - I'm trying to link to the Actions GitHub UI for each workflow.


Added the ability to specify a .json file to skip the wifi prompts

Hi,
Taken the liberty of adding the ability to specify a .json file with the wifi settings you want to push. This skips the need to either write an expect script or do it manually for x hundred particle devices.
As the serial command currently expects any 'extra' arguments to be the serial com device, you need to append the .json argument to the end, ie:
particle serial wifi /dev/cu.usbmodem1411 variables.json
variables.json looking like:
{
"network":"mynetworkssid",
"security":"WPA_AES",
"password":"mySecret!"
}

Coverage decreased (-0.4%) to 18.815% when pulling 7c55d3c051bad4992c85313881231c83100149ac on markterrill:master into b64252a42eae7b89b222011554a58777d29e8b08 on spark:master.

PS, used an external file in preference to more arguments as then the file can be secured outside of direct application code in a startup/setup script

@markterrill Would you mind signing the CLA as described here? Thanks.

Done!
--
Mark Terrill | 0412 704 411
On 22 Apr 2016, at 03:03, Bryce Kahle <notifications<EMAIL_ADDRESS>wrote:
@markterrillhttps://github.com/markterrill Would you mind signing the CLA as described herehttps://github.com/spark/particle-cli/blob/master/CONTRIBUTING.md? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/spark/particle-cli/pull/225#issuecomment-213017452

Done

This is great! You can put something like this into your .bash_profile to target specific port of a USB hub with labeled cables, e.g. #1 - #6.  Here’s the function for cable #2. Done this way so credentials are not stored in a random file and place on my computer.
alias listen2='stty -f /dev/cu.usbmodem141431 28800'

function wifi2()
{
  echo '{"network":"MY_SSID","security":"WPA2_AES","password":"MY_SUPERPASSWORD"}' > whatchamacallit.json
  particle serial wifi /dev/cu.usbmodem141431 whatchamacallit.json
  rm whatchamacallit.json
}

With these two aliases you can automatically put your device in Listening Mode and update it's WiFi Credentials.  Feel free to create aliases for other labeled ports :)
$ listen2 && wifi2

That's neat, glad you like it!
I have a node script that uses async.series to step through dfu, new firmware, changing wifi suffix, configuring wifi, claiming and flashing app firmware. The json file was to make it easy to a) to do wifi cress without human error and effort, manual input is crazy b) use a file so it was clear where multiple credential sets were stored and easy to switch between my test network credentials and my manufacturers based on detecting the local network.
Mark
Sent from my iPhone
On 9 Feb 2017, at 6:20 am, Brett Walach <notifications<EMAIL_ADDRESS>wrote:
This is great! You can put something like this into your .bash_profile to target specific port of a USB hub with labeled cables, e.g. #1https://github.com/spark/particle-cli/issues/1 - #6https://github.com/spark/particle-cli/issues/6. Here’s the function for cable #2https://github.com/spark/particle-cli/issues/2. Done this way so credentials are not stored in a random file and place on my computer.
alias listen2='stty -f /dev/cu.usbmodem141431 28800'
function wifi2()
{
echo '{"network":"MY_SSID","security":"WPA2_AES","password":"MY_SUPERPASSWORD"}' > whatchamacallit.json
particle serial wifi /dev/cu.usbmodem141431 whatchamacallit.json
rm whatchamacallit.json
}
With these two aliases you can automatically put your device in Listening Mode and update it's WiFi Credentials. Feel free to create aliases for other labeled ports :)
$ listen2 && wifi2
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/spark/particle-cli/pull/225#issuecomment-278432611, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACfaUcVkP1cNR7WmqBp9_CMP2kbmTcDmks5rahVGgaJpZM4H0ZVF.


pip install doesn't work with Python3.7

Hi all,
pip install sepa xml doesn't work with python 3.7 and pip 18.1.
There is a syntax error in validation.py
Following, the error found

Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-RIMfI7/sepaxml/setup.py", line 6, in
from sepaxml import version
File "sepaxml/init.py", line 1, in
from .debit import SepaDD  # noqa
File "sepaxml/debit.py", line 4, in
from .shared import SepaPaymentInitn
File "sepaxml/shared.py", line 5, in
from .validation import try_valid_xml
File "sepaxml/validation.py", line 18
) from e
^
SyntaxError: invalid syntax
----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-RIMfI7/sepaxml/

Are you stuck with pip 18.1? That's a three year-old version (October 2018). You are bound to encounter error with this old pip.
I'd suggest first updating pip in your virtual environment with pip install --upgrade pip before installing sepaxml.
I have no problem with python 3.7.10 and the latest pip (21.2.4, published in August 2021).


Poll: Minimum Node Support

With beta,  I bumped up minimum Node support to 4.6 because it was an LTS release. However, now active 4.6  LTS is ending in April. And since beta development took a bit longer than expected (IRL, sorry), April isn't very far away.
Poll: Should we continue to stick to 4.6 or bump the minimum version to 6.9 before April?
In addition to LTS coverage, with 6.9 we also get:

default function parameters
rest parameters
spread operator
destructuring declarations
destructuring assignments
destructuring parameters

Reaction response:

👍 for 6.9
👎 for 4.6

Please only comment if you've cast a "reaction" vote.

cc/ @jbucaran @hzlmn @devmondo @Akkuma @tjbenton @watilde @frantic1048 @aweary @pine

Everyone seems to be onboard with the change. Should we just upgrade to 6.9 now? 🤔

I think yes, but we need to check depedencies for proper support of 6.9.

@hzlmn Cool. They all do. I've been running on 6.9 & Fly for a while now.

As of 2.0.10-beta, Fly now requires Node 6.x.

Version 2.0.2 continues support for Node 4. This will be revisited in April once LTS has officially expired.

Do all plugins, need to follow this Node4 support ?
And what about plugins that uses dependencies that not meet this support ?
Should I use transpiling at runtime to ensure the support ?
Or may I use the engines field (and doc warning) to locked the support ?
To the 6 LTS version or the minimal supported one ?
I know I am a lit bit annoying, but I fallen in love about Fly, and want to do my best.

Lol not annoying at all!
It's entirely up to you since you're the plugin author. However, it would be better for the user to assume that everything will work within the ecosystem.
Obviously, you can't control that in some cases (third-parties). But most existing tools out there are still supporting Node 4 because it is officially still supported. That is why we've reverted to 4.x support.

We are in version 8 now of Node.js. The implementation of the ES2017 spec is almost done. Looking at the support table, I think the amount of extra work needed to make things work with taskr the previous specs is not worth it.
I wholeheartedly agree with the 6+ minimum. I mean come on, that's already 2 major versions ago. If you as a developer are using something less than 6, you can hack together something yourself or use an old version, since you seem to not mind using old software anyways.

I neither agree nor disagree, but appreciate your input!
There are cases where some (lazy) cloud solutions only offer a Node 4 solution. Regrettably, they can rightfully do so since Node4 is an official LTS until Apr 2018. That doesn't mean we have to like it haha, but Node.js intentionally allowed this.
On a more important note: There actually isn't anything in 6+ that Taskr would like to use but can't because of its Node4 support. I'm not sure if you saw this PR, but here are all the changes between Node 4 and Node 6 support. It's purely topical niceties -- 99% is to do with require() statements, haha 😆
Similarly, while some 6+ items are more compact, most ES5 code still runs much, much faster than ES6. Because performance is the No.1 priority, that matters. We're only now starting to see meaningful performance improvements (in Taskr's field of view) with nightly 8 builds.

I'd completely agree with you, if this were true! 🎉 As mentioned above, there's really no difference in code between 4 and 6. Related, there's no pain & suffering in trying to maintain that commitment.
Hope that helps explains things! I'm more than happy to raise it to 6+ once officially deemed appropriate. Until then, it's really not a bother~

Hello. Time has passed since the last comment.
Node.js 4 is now end of life. We can drop it.
Moreover, new versions of Node.js has been released. We can run tests on Node.js 8 and 10 on CI to support them.

@otariidae For sure! Next version (v3.0) will require Node 8.x
We've been using (new) Taskr at work & it's shaping up nicely. It's about time to extract it & ship it 📦


Improved behavior when networks are too big

Provide better ways of handling too big networks for both UI and API calls.

Auto filtering or large networks added in release 5.0


Read User Mail orientation

Is it possible to make Read User Mail vertically sorted, instead of horizontally?

Hi,
What do you mean by "vertically sorted" there?

 Could you provide a screenshot to which page you're referring to?

Yes, user list

We have various display options for user list:

I think the best for you would be is to use User display mode set to Full details.

This looks to be fine

Yes, good point - added it! Pull the latest development theme version, force reload browser's cache and you got it.

Working, thanks)


[UBS courier. User's personal cabinet] The client can`t fill the fields with address making order

Environment: macOS Mojave 10.14.6, Chrome Version 105.0.5195.102
Reproducible: sometimes
Build found: 23.09.2022
Preconditions

Log in to the GreenCity as User https://ita-social-projects.github.io/GreenCityClient/#/

Steps to reproduce

Open 'UBS-user'
Click on 'New order'
You should not choose location in popup-window (close it)
Add services and move next (personal data)
Scroll down page and click on add another address

Actual result

The client can`t fill the fields

Expected result

The client can  fill the fields

This task was added to the task #4551 as scenario 2


Add 'deduplicate' option to pyArango.collection.ensurePersistentIndex

I noticed that collection.ensurePersistentIndex doesn't have a 'deduplicate' argument, unlike ensureHashIndex:
def ensureHashIndex(self, fields, unique = False, sparse = True, deduplicate = False, name = None):
    """Creates a hash index if it does not already exist, and returns it"""
    data = {
        "type" : "hash",
        "fields" : fields,
        "unique" : unique,
        "sparse" : sparse,
        "deduplicate": deduplicate
    }
    if name:
        data["name"] = name
    ind = Index(self, creationData = data)
    self.indexes["hash"][ind.infos["id"]] = ind
    if name:
        self.indexes_by_name[name] = ind
    return ind

def ensurePersistentIndex(self, fields, unique = False, sparse = True, name = None):
    """Creates a persistent index if it does not already exist, and returns it"""
    data = {
        "type" : "persistent",
        "fields" : fields,
        "unique" : unique,
        "sparse" : sparse,
    }
    if name:
        data["name"] = name
    ind = Index(self, creationData = data)
    self.indexes["skiplist"][ind.infos["id"]] = ind
    if name:
        self.indexes_by_name[name] = ind
    return ind

This causes all the persistent indexes to be created with a default 'true' value for 'deduplicate'.
Since the persistent indexes are supposed to replace the hash ones with RocksDB, I think it would make sense to add this argument here.

I created a pull request for this issue: #173

Hi,
I made the same observation today and look forward to the merge.
In the meantime I'm using the depreciated hash index.

Since the changes have been merged, I’ll close the issue.
https://github.com/ArangoDB-Community/pyArango/pull/173


Future event button

Description
I want to add a button on the event page. Whenever a user clicks on that, A film will open up and ask for the email and name of the user so that he gets notified for the next upcoming event.
I also like to add a CSS effect on the event card. Whenever a user hovers over, the card gets flipped, and a short description of the event is available, which will become more attractive.
Screenshots
No response
Additional information
No response

It's great having you contribute to Milan ! This is an auto-generated textThe maintainers/owner will look into the issue soon, add relevant tags and proceed further, please have paitence. Meanwhile feel free to support star the repo and share it with your friends. :nerd_face: :rocket:

If u find it relevant, please add it to hacktober fest

Hello @AbhishekTiwari23 , the feature you talked about is useful - but i want it to be more customized.
Here's something that you can do :

We already have Attend Event button on each card
Whenever a user clicks on it, Open a new page

How to build a new page ?

Make a new folder in the pages folder
Name the folder as events
Make a new file called AttendEvent.jsx which opens as display/events/attendevent

What to show in the page ?

You can use react-context api / props / Links to pass the club's data to the page.
Inside the page to the left side display the picture we have used in those cards.
On the right side, we can have all the details of the event.
Below that we can have an input field for the emailID of the user and an attend button.
After filling the input and clicking on the button, the page should be closed !

Note

It will awesome if you could do it.
If not i will be assiging this to someone else

Regards,
Tamal

Hello @AbhishekTiwari23 , the feature you talked about is useful - but i want it to be more customized. Here's something that you can do :

We already have Attend Event button on each card
Whenever a user clicks on it, Open a new page

How to build a new page ?

Make a new folder in the pages folder
Name the folder as events
Make a new file called AttendEvent.jsx which opens as display/events/attendevent

What to show in the page ?

You can use react-context api / props / Links to pass the club's data to the page.
Inside the page to the left side display the picture we have used in those cards.
On the right side, we can have all the details of the event.
Below that we can have an input field for the emailID of the user and an attend button.
After filling the input and clicking on the button, the page should be closed !

Note

It will awesome if you could do it.
If not i will be assiging this to someone else

Regards, Tamal

I am eager to contribute and will give my best definitely. But I just want to know whether you have any time bonding issues or not because it will take a little time, But I can make sure that I will do my best for this. Hope u don't mind @IAmTamal. What about hacktoberfest tag (just kidding)

Please assign me. I am ready with my tools

Please assign me. I am ready with my tools

There's no time-bonding as such but try and do it within 3-4 days !

Make sure the fonts are similar to what we have used
Make sure the styles are minimal
Make separate .css files and use proper names.

This is more than enough. Thanks alot

Hello @IAmTamal, I started working on the issue, but I found that Hacktoberfesttag is missing in this issue. I request you to please put it there.

Hello @IAmTamal, I started working on the issue, but I found that Hacktoberfesttag is missing in this issue. I request you to please put it there.

Hello @AbhishekTiwari23 , you donot need Hacktoberfest tag in issues. You need it only in PR / Repo topics.
Anyways just for the sake of putting it, i'll add it.

@AbhishekTiwari23 Any updates ?
It's been a long time.

@AbhishekTiwari23 Any updates? It's been a long time.

Hello @IAmTamal, Actually, before jumping over your project, I started learning to react, I am thankful for this project which makes my understanding of react.js clear.
Current status - made the "attend event" button responsive (means now whenever a user clicks on it , he will be landed to a new page).
- Added Attendevent page in the page folder,
- Added header of this page as same as the other pages.
Currently working on the page.
I apologise for being late and not full filling my words, actually I was working on Layer5.io PR, and thankfully it got merged. As I am a new bee in open source, I wasted my lot of time in searching good reo and learning the new things that are required for that particular project, similarly like in your project I am making my rect understanding clear.
I f you want a confirmation screen recording or a pr then please let me know. Thanks for you support.

Yeah just wanted a head's up - since this is a feature we wouldn't wait too long !
Take your time but please try and do the mentioned stuffs within the next 2-3 days 🚀


🐛 [BUG - React] - FormControl.Required not indicated with Checkbox

Describe the bug
The following snippet (see "required" attribute):
<FormControl required>
  <FormControl.Label>Checkbox 1</FormControl.Label>
  <Checkbox name="day" value="" />
</FormControl>
<FormControl>
  <FormControl.Label>Checkbox 2</FormControl.Label>
  <Checkbox name="night" value="" />
</FormControl>

Doesn't indicate if the checkbox is required:

Reproduction steps
^ Above ^

Expected behavior
* is added to the checkbox title when it's required. Similar to the other fields here: https://primer.style/brand/storybook/?path=/story/components-forms-examples--git-hub-enterprise

Screenshots
^ Above ^

Browsers
Chrome
OS
Mac

@philernst @rezrah - this is intentional. A single checkbox cannot be required because both checked (true) and unchecked (false) are valid values.

If you want indicate that a selection must be made in a group of checkboxes, it should be indicated for that whole group of checkboxes. Here's an example from @primer/react: https://primer.style/react/storybook/?path=/story/components-checkboxgroup--playground&args=required:!true

@mperrotti Got it. The use case I was thinking about is where the submitter is required to check the checkbox to submit the form. For example:

I suppose in that situation a CheckboxGroup would need to be added to indicate that the field is required to be true to submit the form.

@philernst - I'm not sure we even need a required indicator on that one. I think it would be ok to just return a validation error if it isn't checked.


Discrete normal

Fixes #214
I am subclassing the continuous distributions. This makes the code very small but it might not be the most "clean" way of creating these discrete distributions.

Very nice and clean! I added the tests as well, feel free to merge!

Our CI is failing on macos-latest in the nbval. Is this something we can fix easily or should I just merge?

You can ignore the nbval problem and merge. For some reason tests (for various previous PRs too) keep failing on df.describe() in the notebook in the mac tests. But they work when running on my m1 mac, and have worked on @qubixes mac as well. Just a weird bug, but not related to our codebase.


[WIP] 3D Rendering API

Description
This PR adds a simple 3D rendering API that can be used to draw arbitrary models, loaded as assets from .obj files.
Tasks Remaining

[x] Fix king donut being shaded slightly wrong on hardware (lots of white triangles for some reason)
[x] Figure out why the bunny rotates with the swadge and king donut rotates opposing the swadge -- it was an illusion!
[ ] Add translation/scaling parameters to drawModel()
[x] Add parameters for drawing to a specific spot on-screen
[ ] Finish docs and cleanup

Test Instructions

Ticket Links

Readiness Checklist

[ ] I have run make format to format the changes
[ ] I have compiled the firmware and the changes have no warnings
[ ] I have compiled the emulator and the changes have no warnings
[ ] I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
[ ] I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
[ ] I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

LMK when this is actually ready for review and not WIP. I think github has a way to draft PRs. Maybe for next time.

LMK when this is actually ready for review and not WIP. I think github has a way to draft PRs. Maybe for next time.

Ah, so you can. I could have sworn it automatically did that if you included WIP at some point.


Allowing user to select one of the many connected agents

I have a Livekit server deployed to which there are 3 different LiveKit agents connected.
I want a way to allow user to specify which one of those 3 to be connected to.
I tried following:

The agent can have request_fnc defined in which it can decide if the agent wants to handle the request or not. I tried this, but the method is not getting called. Then found that it's a known issue mentioned at https://docs.livekit.io/agents/build/anatomy/ so this approach does not work.
The agent can provide an agent name while registering itself with the livekit server as part of WorkerOptions. I did that but then the agent is not called at all even if the user joins a room. Also for this approach, I could not find any way to send the agent name from the client side. Without providing agent name the agent gets called fine.

I would appreciate any suggestions or ideas to achieve the desired result.
Thank you.

@meetakshay99 we just made our own API that connects the agents instead of using the livekit job scheduling to accomplish this. You can manually connect to the room and manually create an agent in a python function.

I have multiple agents manually created and being used. But how do I "connect" to an agent? Can you pls share more details on what and how was it exactly done?

I have multiple agents manually created and being used. But how do I "connect" to an agent? Can you pls share more details on what and how was it exactly done?

https://docs.livekit.io/home/get-started/api-primitives/
https://docs.livekit.io/home/client/connect/
You'll probably want to learn how livekit works to accomplish that.

https://docs.livekit.io/home/get-started/api-primitives/
https://docs.livekit.io/home/client/connect/

That connects with the room. I am already doing that. However, it does not allow me to specify which agent to connect to, which is what I am looking for.

I have multiple agents manually created and being used. But how do I "connect" to an agent? Can you pls share more details on what and how was it exactly done?

Let's say you have a http service somewhere:
At a high level:
will connect it to a room that you've created:

  utils.http_context._new_session_ctx()
  try:

        room_options = rtc.RoomOptions()

        room = rtc.Room()

        url = os.getenv('LIVEKIT_URL')
        api_key = os.getenv('LIVEKIT_API_KEY')
        api_secret = os.getenv('LIVEKIT_API_SECRET')

        token = api.AccessToken(api_key=api_key, api_secret=api_secret) \
            .with_identity(os.getenv('AGENT_IDENTITY')) \
            .with_name("Your agent name") \
            .with_kind("agent") \
            .with_grants(api.VideoGrants(
                can_update_own_metadata=True,
                room_join=True,
                room=room_name,
                agent=True
            ))

        jwt = token.to_jwt()

        await room.connect(url=url, token=jwt, options=room_options)

        assistant =    // initialize your agent
        assistant.start(room)

        await some_close_condition_you_decide

        await assistant.aclose()
        await room.disconnect()

    finally:
        await utils.http_context._close_http_ctx()

That's the basic idea. That will work with a simple aiohttp server to spawn the agent to get started.


.thumbnail method and input options

It would be fantastic if the thumbnail method would accept :dpi and :page options in order to fully support rendering of thumbnails from PDF files.

Hi, you can put page into the filename, eg.:
vips thumbnail nip2guide.pdf[page=12] -o x.jpg

I agree having a proper page parameter would be simpler.
You're right, you can't use dpi to size thumbnails, you can only give a size in pixels. You can calculate a pixel size from the image xres and your desired DPI, of course.
I'm not certain that sizing by DPI is very useful. Many PDFs have strange values set for DPI and you could get almost any size thumbnail as a result.

Hi John, thanks for reply.
I think it would be great if the api would be same as for .new_from_file here eventually.
As for dpi – I assumed that when supplied as input option the PDF is internally rasterised to that DPI and then scaled down with for example the .resize. It would be great if .thumbnail works the same so that we do not need to run it twice – once to generate large version from PDF, second time to scale it down to actual thumbnail.
(For now, I went back to the .resize method in dragonfly_libvips because using the .thumbnail breaks all PDF rasterisation.)

thumbnail just rasterises the PDF at the exact size you ask for. It gives nice results for me, for example the ISO res chart:
vipsthumbnail ISO_12233-reschart.pdf

Gives:

Do you have an example of a PDF that fails to rasterise well?


(Bug) cant decrypt profile fields

because of previous data loss the decryption key is missing
need to add a generic fix to reset profile fields that cant be decrypted

@sirpy The issue has been checked in ticket # 2906

@sirpy The issue has been checked in ticket # 2906


jscsrc: disable directory

I have a project which uses jscs. However I want to exclude a directory.
This is possible when using the CLI or a task runner—I simply blacklist the directory.
When I use jscs as a plugin for my IDE, however, it runs for all files. There is no way to ignore a directory.
Would it make sense to add a disableAll rule that can be specified in jscs? This would provide a common way to exclude directories for all ways you can run jscs (CLI, IDE plugin, etc.)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/22282849-jscsrc-disable-directory?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Looks like I was after excludeFiles.


Fix remapping VLP-32C topic name

Status
DEVELOPMENT
Description
#1965

Thanks @aohsato I was able to confirm.


Using Bulma

Can I use my current Bulma variables (colors, font-family, etc) to work on vue-blu? How?

Yes you can, refer to https://chenz24.github.io/vue-blu/#/en/customize

Thanks! Probably going to use it on the project I'm working in. Hope you have some time to finish the translations ;)

@chenz24 could you explain more on step 1 "Set the sass variables and import the entry file of the library"?

@chenz24 I noticed vue-blue font is smaller. I prefer bigger text from bulma. How can I go about sticking with default bulma font?


Support UUID as arrow type

Support specify UUID as arrow schema
Stored as fixed size data type (128 bits)
Have Python and Javascript definition in both LanceDB SDKs

Is this meant as extension type (e.g. https://github.com/apache/arrow/pull/37298) or as part of lance format?

It'd be great that we can natively support UUID type from pyarrow. ALso we wanted to support the interoperability in javascript as well.

I have an upstream PR in arrow that may get merged for 15.0.0 https://github.com/apache/arrow/pull/37298.
Should we wait for one quarter to get it or implement a temporary equivalent in pylance (e.g. https://github.com/lancedb/lance/pull/1471)?
I'll start working on the js one.

@eddyxu I was planning to continue work on this after the upstream extension type was merged (https://github.com/apache/arrow/pull/37298). If you'd want UUID type in Python before that https://github.com/lancedb/lance/pull/1471 can be merged. If not https://github.com/lancedb/lance/pull/1471 can be closed out.

Once we have upstream PR merged, do we need anything change from lance to support it?
I can take it over from there.

It'll be available in pyarrow as e.g. FixedShapeTensorArray is, see test here. I'm not sure if you'll need changes on rust side of things.


[Breadcrumb] Add Inverted Variation

I would really like to see an inverted version of breadcrumbs. Is this something you are planning to add?
At the moment the dividers are not visible since they are a transparent black.

Can you provide an example?

Here is an example with breadcrumbs inside an inverted menu: http://plnkr.co/edit/3HPWjOMRpQGwxZtgeeMr?p=preview

Prepared for Fomantic-UI by https://github.com/fomantic/Fomantic-UI/pull/720
See https://jsfiddle.net/1s9xgcvh/


Minor C# code formatting update

@kendaleiv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

thanks, @kendaleiv!
#sign-off


Retrieve should allow specifying the result to retrieve

Right now you have to say: self.bed.retrieve(digest)[column]
instead it should be possible to do: self.bed.retrieve(digest, columns)

Implementation:

allow retrieve to accept a list of record_identifiers and result_identifiers.
pipestat retrieve will then either call (on the backend):

retrieve (which retains its current functionality)

retrieve_multiple -> new function which allows for retrieving multiple records and multiple results.


Add gas price factor.

Fixes #342
Adds a new consensus constant, GAS_PRICE_FACTOR (suggested to be set to 1 billion), that allows gas price to be provided with a precision of 1/GAS_PRICE_FACTOR of the base asset's unit.
Gas used is rounded up to the nearest unit, and gas refunded in rounded down. Note gas and byte costs are accounted for separately. Therefore, the minimum non-zero used balance is 2 coins: one for gas and one for bytes.
E.g. if the base asset is ETH at 9 decimals, then its units are gwei. This change allows gas prices to be specified in wei. If a tx costs less than 1 gwei of gas price * gas limit / GAS_PRICE_FACTOR, then it rounds up to costing 1 gwei.
Some considerations around parameter choice: a script that uses 10M gas can have a gas price of ~100B before you have to start worrying about overflow. Assuming ETH as the base asset:

With a factor of 1B, the maximum gas price is ~100 gwei. In the long run, this doesn't leave much room for a robust fee market.
With a factor of 1M, the maximum gas price is ~10,000 gwei. Lots of breathing room.
With a factor of 1,000, the gas price is 0.001 gwei. This might not be cheap enough. Transactions may still cost on the order of cents even at the lowest gas price.

I'm inclined towards a factor of 1M from the above, but would like to hear what @Voxelot @vlopes11 and @rakita think.
Implementation:

I think its a good call to use the same ratio as gwei since also the community is very familiar with that. Since this won't impact the gas calculation itself but only the assets manipulation, I see this as an improvement without potential problems/concerns.
Recommended steps to implement:
[ ] Implement the constant as consensus parameter in fuel-tx
[ ] Perform the conversion  in transaction initialization/post-execution in fuel-vm


Support for pandoc versions <2.0 on Julia 1.0?

The latest version of pandoc on Ubuntu 18.04 LTS is pandoc <IP_ADDRESS> and PDF generation fails on Julia 1.0 with Weave 0.6.2 because pandoc 1.19 still has --latex-engine as the option instead of --pdf-engine. Any chance that this can be supported as a backup?
julia> using Weave

julia> weave("analysis.jmd", doctype="pandoc2pdf")
[ Info: Weaving chunk 1 from line 5
[ Info: Done executing code. Running xelatex
pandoc: unrecognized option `--pdf-engine=xelatex'
Try pandoc --help for more information.
┌ Warning: Error converting document to pdf
└ @ Weave ~/.julia/packages/Weave/1O5IK/src/pandoc.jl:102
ERROR: IOError: write: broken pipe (EPIPE)
Stacktrace:
 [1] macro expansion at ./logging.jl:318 [inlined]
 [2] pandoc2pdf(::String, ::Weave.WeaveDoc, ::String, ::Array{String,1}) at /home/tamas/.julia/packages/Weave/1O5IK/src/pandoc.jl:89

Interestingly, this code runs on Julia 0.6.x with Weave 0.5.2
julia> weave("analysis.jmd", doctype="pandoc2pdf")
INFO: Weaving chunk 1 from line 5
INFO: Done executing code. Running xelatex
INFO: Report weaved to analysis.pdf

It looks like this was changed in https://github.com/mpastell/Weave.jl/commit/4cd0b92792e219cb77a42d1a74000234f00b5880. I think a workable solution would be to attempt to use --pdf-engine first and if that fails use --latex-engine as an option. There are lots of systems that are still using pandoc <2.0 out there so it would be shame to drop support for all of them due to a small flag change.


blank screen when playing video

I have an issue / a question (pick one) about Vlc.DotNet.
Generic information

Vlc.DotNet version : (Please fill)
Vlc.DotNet project used : (WinForms/WPF/Core)
libvlc version : (Please fill) (x86/x64) + how did you get it?
.net version : (Please fill)
Project language : (C#/VB.net)
Project build architecture : (x86/x64/AnyCPU/AnyCPU (prefer 32bits))
Operating system : (Windows ...) (x86/x64)

Summary
(What happens, when, how? Steps to reproduce (with sample codes))

[ ] I confirm that my issue doesn't happen in VLC itself.

Don't post duplicates, you can edit your issue. closing in favor of #555


fix profile page not greyed out

Details
Fixed Issues
$ https://github.com/Expensify/App/issues/46053
PROPOSAL: https://github.com/Expensify/App/issues/46053#issuecomment-2246992981
Tests
Same QA step

[x] Verify that no errors appear in the JS console

Offline tests
QA Steps

Log in with any account.
Go offline.
Create a new workspace.
Navigate to Profile.
Verify that the workspace name is grayed out.
Change the name of the workspace while offline.
Verify that the workspace name is still grayed out.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/de7e1590-9c2c-417d-b4eb-d9d59019a17a

Android: mWeb Chrome
https://github.com/user-attachments/assets/02812e8f-dbd8-495c-ae57-3cbb8f4eba73

iOS: Native
https://github.com/user-attachments/assets/6795d331-10ac-409d-a6e4-f3ee4e91c089

iOS: mWeb Safari
https://github.com/user-attachments/assets/2f9e0b30-c041-4d09-b333-f98fa4aead24

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/1b544bfe-fcd0-4271-85b8-128e9568fa47

MacOS: Desktop
https://github.com/user-attachments/assets/5827000a-1623-4d38-acea-dd0938d6f813

@Expensify/design Could you please review my change? I'd like to confirm that the grayed-out section in the profile is correct. Thank you!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


move live migration into separate file

Looks fine presuming you fix the release build :)

Looks fine presuming you fix the release build :)

Are you referring to the Travis build failure?

yes

yes

I don't get this error with GCC 8.3.0. I believe that this is a false positive: negotiate calls recv_version with msg_id uninitialized, recv_version in turns calls recv_vfio_user_msg_alloc with is_reply=false, which then calls recv_vfio_user_msg. Since is_reply == false, msg_id is only written to.
I can trivially silence this with:
@@ -467,7 +467,7 @@ static int
 negotiate(lm_ctx_t *lm_ctx, int sock)
 {
     struct vfio_user_version *client_version = NULL;
-    uint16_t msg_id;
+    uint16_t msg_id = 0;
     int ret;

But is this the right thing to do? Can we update GCC in the CI?

The -Wmaybe-uninitialized implementation in older GCC's is very buggy. However, it does catch real bugs sometimes. So we don't want to disable the option if we can avoid it, but we also want to be able to compile everywhere we can.
So, let's do the workaround of initing to zero even though a smarter compiler can figure it out.

Fixed, waiting for Travis build.


Update height-and-width.md

Without the <Text /> component, the FlexDimensionsBasics and PercentageDimensionsBasics seem to not be displayed for me.

Closing due to lack of author response.


Bug - Creating an empty project throws a 400 error

If you create a project via the UI with no assets, the application throws a 400 error

Unfortunally i can confirm that. What information are needed to debug that issue?

At this point, the but is to allow project creation without assets.
Is that a thing that makes sense for you guys? Creating the project without uploading files?


Docker Hub does not contain latest release

The current latest release is 8.7.2, which got published 3 days ago, but it got not pushed to Docker Hub.  The latest image on Docker Hub got pushed 2 months ago from IOHK. Can you please push an image of the latest release to Docker Hub?

In fact, the 8.7.2 release does not include the binary assets.

What you mean, can you please explain in more detail? Thanks.

On https://github.com/input-output-hk/cardano-node/releases/tag/8.7.2 you have only source code

On https://github.com/input-output-hk/cardano-node/releases/tag/8.7.1-pre

And what is the reason for that, why do you not include binary assets?
The last image was published 3 months ago, since then where were many feature releases, bug fixes and even breaking changes. You say there is no reason to publish a new docker image since 3 months? What is the factor for you that determines when you publish a new docker image? I understand if you do not publish an image when you make changes that do not affect the image, but this is not the case here.

Clarification: I am not in charge of any of this. I've just noticed the absence of binary files and added a comment on this issue to avoid duplicate.

see https://github.com/IntersectMBO/cardano-node/issues/5578

Maybe there is no binary because there is an error during build when following the instructions that work for previous versions.


24 pull-reqs: Install.sh TLC and enhancements

I stumbled on your project @ http://24pullrequests.com/ but this is not the first time I stumbled across bash-it and have been meaning to give it a try.
On installation I caught a couple of hiccups and since its xmas and all if we need an excuse. I confined myself to install.sh only, I have a habit of getting carried away once I start. Have a look see if you like my work, maybe we do some soon.
The commit comments should be elaborate enough to explain the gists, a quick overview or roadmap of the the journey you're about to take might be in order.
The first commit encompasses code style conformance changes. When I start working on a new project I instinctively absorb the chosen code style so as to adopt its practice and ensure that my additions blend seamlessly. With this project and I mean no disrespect you didn't seem to have a code style. So I attempted to conform to what appears as tho majority used practices.
@ab4d9fb explains an overview of the strategy I adopted. The commit only changes style so as to enable you to cherry pick at it should you disagree with the normalisation.
Your journey will continue through the sites I've secured and or enhanced to make the installation more robust to users like me who don'n read instructions while at the same time not changing a thing. It still does exactly the same things you originally expected from it.

Package home folder remains ~/.bash_it
Back up is made of .bash_profile
Option to create jekyll config.
3 times extensions/plugins installation.

If nothing changed how did it take 14 commits you might ask:

Script location detection allowing the possibility that someone might run install.sh from somewhere other than ~/.bash_it and deals with it
Dealing with the possibility that there is no .bash_profile as well as the chance that a backup already exists called .bash_profile.bak and deal with it
Ensure that we do end up having a package home  ~/.bash_it
Several usability enhancements like one char select at the y/n prompt
The grand finale - addition of direct install functionality using bash and curl to fetch the install script from github and proceed with the installation as before.
Code comments added
Documentation updated to reflect the new changes, even though none of us reads it anyway =)

nJoy

What's the news on this 9-year-old PR? Some of these fixes are still needed and I have reimplemented a few already on my branch...

I like the easy install part, and the cleanup- but this needs a rebase.
I am also unsure about the whole backup thing as I want to ship bash-it profile instead.
If this will get rebased with the cleanup and the option to run the install as an easy-setup that would be pretty cool

Some of these fixes are still needed

Looks like there's only a few that are still needed, mainly unbound parameters, string quoting, and reduced subshells and external binaries. I guess I've already submitted new PRs with most of these anyway.

I have absolutely no idea what happened to stay and what got dumped, this was ridiculously long ago. Here in is rebased for what it's worth.
nJoy!