Request for asdf-vm plugin

asdf provides a convenient way to manage versioned development runtimes. asdf plugin list-all reveals existing support (plugins) for many tools, including python, elm, nodejs, gleam, nim, rust, zig, haskell, ruby, erlang, elixir, etc.
It would be a super convenience when getting started with roc to be able to manage it the same way.

https://github.com/asdf-community
https://asdf-vm.com/plugins/create.html
https://github.com/asdf-vm/asdf-plugin-template

Hi @AndydeCleyre, thanks for taking the time to suggest this :)
I do believe we have this desired behavior already covered by nix with our flake.nix file.
Do you think asdf would provide additional benefits in addition to (or instead of) nix?

Surely for existing asdf users there's a benefit, enabling them to use the tool they like for this task, and store the roc version requirements alongside any other runtime requirements in a project's .tool-versions file, and use the asdf github actions to provision, and get the nice asdf shell completions to browse versions interactively, and activate the project or folder's assigned version when changing directory, etc.
Maybe the nix method is great, but as someone who doesn't use nix for anything at all right now, I'm unlikely to either:

start using it solely to manage a roc installation, while using a single other tool to manage all other project runtimes
stop using the tool that manages every other project runtime and migrate, just to be consistent with how roc can be managed

To clarify, the nix setup is targeted toward roc contributors and has been working really well for that. For roc users we currently have the nightly releases and once we release 0.1 we plan on supporting switching versions using the roc command. Once we have a 0.1 release, setting up asdf for users will probably be pretty easy so I suggest we plan it for then.
With the limited resources that we have, I don't think we can justify the investment before our 0.1 release.


Remove recursive definition

Wrapped react component this.props was unable to infer types for properties defined in SP

Is there a reason this was not removed in v5.x.x?


Files are not resampled to 48 kHz before calculating NISQA

Correct me if I am wrong but it seems the files are not resampled to 48 kHz when calculating NISQA. This is because when initializing the NL.SpeechQualityDataset, the sampling rate is set to model.args["ms_sr"], which is None in nisqa.tar.
https://github.com/urgent-challenge/urgent2024_challenge/blob/478465e37ecd27d1fbca4810aaf4bab7fd6353fe/evaluation_metrics/nisqa_utils.py#L124-L128
As a consequence, the files are not resampled when calling librosa.load here, despite the NISQA metric being described as running at 48 kHz and the comment below.
https://github.com/urgent-challenge/urgent2024_challenge/blob/478465e37ecd27d1fbca4810aaf4bab7fd6353fe/evaluation_metrics/nisqa_utils.py#L106-L110

@philgzl Thanks for your report! Indeed the default value of ms_sr (48000) in NISQA_lib.SpeechQualityDataset will be overwritten by model.args["ms_sr"], which turns out to be None for all the pretrained model weights in https://github.com/gabrielmittag/NISQA/tree/master/weights.
However, this behavior inherently exists in the original repository gabrielmittag/NISQA. Since we are strictly following the original repository's implementation in run_predict.py → nisqa/NISQA_model.py,
        self.ds_val = NL.SpeechQualityDataset(
            df_val,
            df_con=None,
            data_dir = self.args['data_dir'],
            filename_column = 'deg',
            mos_column = 'predict_only',
            seg_length = self.args['ms_seg_length'],
            max_length = self.args['ms_max_segments'],
            to_memory = None,
            to_memory_workers = None,
            seg_hop_length = self.args['ms_seg_hop_length'],
            transform = None,
            ms_n_fft = self.args['ms_n_fft'],
            ms_hop_length = self.args['ms_hop_length'],
            ms_win_length = self.args['ms_win_length'],
            ms_n_mels = self.args['ms_n_mels'],
            ms_sr = self.args['ms_sr'],
            ms_fmax = self.args['ms_fmax'],
            ms_channel = self.args['ms_channel'],
            double_ended = self.args['double_ended'],
            dim = self.args['dim'],
            filename_column_ref = None,
            )

it should yield consistent results if you run the evaluation script provided in the original repository.
Anyway, this is an important finding, and we encourage you to post an issue in the gabrielmittag/NISQA repository.

Thanks!
Actually upon further investigation it seems this is the normal behavior. As Gabriel explained here, the window and hop lengths are adjusted depending on the sampling rate, such that they are always 20 ms and 10 ms. The FFT length is then always 4096, and the maximum mel frequency is always 20 kHz. So signals with low sampling rates end up with empty mel bins at high frequencies, which should result in a lower score compared to fullband signals.
So the only real issue, if anything, is to believe the metric runs at 48 kHz. When reading the paper, it does not seem like the metric was advertised as such (although the metric does "expect" a fullband signal, in the sense that narrowband signals are penalized).

I see. Thanks for the investigation. Indeed, the resampled window and hop lengths can be an alternative way to handle different sample rates, as also indicated by the baseline framework in the URGENT Challenge.
We might not say that it always runs at 48 kHz, but that it somewhat generalizes to other sample rates because of the above operation. Meanwhile, it is mentioned in the NISQA paper that

The presented model is focused on distortions that occur in modern speech communication networks. However, the model weights can also be used to fine-tune the model for related tasks, such as the prediction of enhanced or synthesised speech.

Therefore,  we still need to find better metrics that fit well the speech enhancement task and generalize well. This is also one of the goals of the URGENT Challenge.


Suggest the robust test scripts

Thank you for developing the contract.
I tested the functionality of your contract using the test script you provided.
:zap: However, if the following content is added to the test code, the code will likely become more robust.
(1) Considering the use of 'Initializable' in the contract, using a proxy is in mind. Please test using a proxy.
(2) There is no test for error situations in the test case. Please add all of the error cases you consider.
Thank you!!

I confirmed that an error case was added.


Deadlock during concurrent tenant creation requests in mysql

This will resolve by https://github.com/wso2/carbon-kernel/pull/1367

This will resolve by #1367

This fix is available since 4.4.17
https://github.com/wso2/carbon-kernel/commit/00bafcb9f05eae20cf85c0c5301e89a1159f7b0a


Issue/437

As discussed.

Ping @jdorleans we integrated your code and added further test. I'd love to have some feedback from you.
Also @frant-hartm did have some good remarks, especially

Also querying Employee by e.g. set of ids should return both Worker and Manager instances and use index on Employee.

The solution now uses

Indexes from parent classes preferable if they can contribute to the index, that is: When they have label (either as direct annotation or indirect by not being abstract)
Uses indexes from parent classes for children if the parent class has no label. In that case: Use the label of the concrete class.

Looking forward to your feedback!

Closed with bbacf6aca839cbdd85e1c05b9413f29c64d6477b.


Maximum number of plotly plots in Rmarkdown

It seems that we cannot include more than 15 plotly 3D plots in a Rmarkdown file.  Here is the test code :

title: "test"
output: html_document
knitr::opts_chunk$set(echo = TRUE)

plot<-list()
data<-list()

x <- 1:5/10
y <- 1:5

library(plotly)
for (i in 1:20){
      z <- x %o% y
      z <- z + .2*z*runif(25) - .1*z
      data[[i]]= z
      plot[[i]]<-plot_ly(x=x,y=y,z=data[[i]], type="surface")
}

htmltools::tagList(plot)

Thanks!!!!!
Best,
Caroline

Yes, that's true. It's a browser limitation in fact, that generally you cannot create more than 16 WebGL contexts in one tab. And some of our trace types use 2 or 3 separate contexts for a single graph, so the limit would be dropped down to 8 or 5 charts. See https://github.com/plotly/plotly.js/issues/2333 for more info, one potential work-around (removing off-screen graphs) and one potential long-term solution (multi-regl). This solution isn't part of our existing roadmap unless someone is interested in sponsoring it.
I believe multiple graphs within one plot do share contexts, so you could try using subplots.

Thanks very much.
Unfortunately, I have more than 16 contexts. Using subplots didn't really help.  I guess this will become more and more of an issue when people started to embed more complicated plotly plots in their Rmarkdown files. Will be looking forward to future resolutions.
Best,
Caroline

Any follow up on this?


The change from DI to Di doesn't show it, when I download the latest version (1.1.8)

Hi, I cloned the boilerplate application and I installed dependencies using composer install, but I don't know why the folder name inside Phalcon REST Library (version 1.1.8)  is still DI, isn't Di.

Hi Wilcar, That change is now part of version 1.1.9 I just released. Thanks for letting us know.


Allocate minimum number of pages to each student .

Problem statement
Allocate number of books such that maximum number of pages each student should read is minimized.
Example:
Given : N number of books, array A[N] where A[i] gives number of pages in ith book.  S number of students among those  books are to allocated.
N=4 A[]={20,34,12,27}
S=2
Output= 59
Hey @Ayush7614 I would like to solve this issue using Binary search.
Language : I am interested to work in C++.
please assign this issue to me under LGM-SOC 21.

Can I implement in Java? I'm a participant of LGM-SOC 21.


Add support for CMEK keys in Data Foundation end to end example

Add support for CMEK keys in Data Foundation end to end example.

Lore, did not have time for a review, but are keys completely optional? What happens if the user does not set the corresponding variable?

project-datamart in 01-environment is missing service_encryption_key_ids for bigtable

/gcbrun


Create doctypes for Prints

SHUTDOWN RETURN.pdf
SHUTDOWN.pdf
INSPECTION INSULATOR.pdf
Inspection Insulator
Fields:
Date: Date
Subject:Data
Ispection Date: Date
Table: Options - Inspection Insulator Table
Place of Inspection: Data
No. of days for inspection: Number
Contact Person: Data
Weekly Off Day: Select (Sunday, Monday, .......)
Child Table Doctype
Name: Inspection Insulator Table
is Child Table: True
Fields: Add the columns of table as fields

Create a general Letter Template which can be used to make various reports
Make everything configurable
Body of the letter must be accepted through text-editor


[feature] SLSA 3 Go Builder add provenance name to the workflow outputs

Is your feature request related to a problem? Please describe.
This is a feature.
Describe the solution you'd like
At the time of writing this, SLSA 3 Go Builder does not have the provenance name generated during the workflow within its outputs^1. So, it'd be better to provide an output that specifies the provenance name.
Additional context
I'm willing to do this, please assign it to me. cc @laurentsimon

Let's add e2e tests before closing this issue

Added e2e tests in https://github.com/slsa-framework/example-package/commit/7f8f39e9163246e25aecde40ba23e7cecbfacd65. It's using go-provenance-name for consistency with the existing go-binary-name


Add nonempty option to ceph-fuse to support ReadWriteMany

fuse mount does not allow to mount directory if it contains some
files. Due to this, currently scaled pod with cephfs failed to mount
by ceph-fuse.
This patch adds nonempty option to ceph-fuse command to support
ReadWriteMany with ceph-fuse.
Fixes https://github.com/ceph/ceph-csi/issues/54

I'm able to reproduce this with csi-cephfs 0.2.0
I'm also working on CSI Ceph 0.3.0 where I can't reproduce. AFAIK now such situation should not even happen anyway. When using Kubernetes and mounting with ceph-fuse, the volume gets mounted into /var/lib/kubelet/plugins/kubernetes.io/csi/pv/<PVC-ID>/globalmount on the plugin node, and each workload that requests this PV only bind-mounts into /var/lib/kubelet/pods/<POD-ID>/volumes/kubernetes.io~csi/<PVC ID>/mount. globalmount should be empty - unless something else is happening, which should be investigated further. Setting nonempty could hide this problem. I think we should wait till 0.3.0 gets in and if the problem persists we can have a closer look.


Listen on external port

This patch adds default IP adresses to the list of ports RabbitMQ
is listening to, so that the instance can be used together with
TripleO out of the box.

Tested and works like a charm with Sensu role.


[CAPPL-42] SDK logger

Description
This pr introduces a logger to the SDK that can be used from the wasm guest.
It basically json encodes, sends to the host, json decodes in the host, and logs using the our custom logger.Logger.
In order to do this I've introduced a new constructor NewWithZapLogger that returns a new Logger based on a zap.Logger. With this we can build our own core and pass it down to the logger.Logger

The core logger package is very unusual, and only still exists to support historical quirks that don't appear to be used here. Can the common logger package be used instead?

@jmank88 Re. your comment about a new constructor, it's because we want to control the core that we're using. The existing constructors don't allow us to do that so easily so this seemed the simplest option.


[nodejs parity] Allow LUIS endpoint to be null or empty

Fixes https://github.com/Microsoft/botbuilder-dotnet/issues/1387
Enable empty endpoint (just like nodejs)!

Pull Request Test Coverage Report for Build 53309

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 76.126%

Totals

Change from base Build 53133:
0.004%

Covered Lines:
4362

Relevant Lines:
5730

💛  - Coveralls

No issues found in Microsoft.Bot.Builder.dll
No issues found in Microsoft.Bot.Builder.AI.Luis.dll
No issues found in Microsoft.Bot.Builder.AI.QnA.dll
No issues found in Microsoft.Bot.Builder.ApplicationInsights.dll
No issues found in Microsoft.Bot.Builder.Azure.dll
No issues found in Microsoft.Bot.Builder.Dialogs.dll
No issues found in Microsoft.Bot.Builder.TemplateManager.dll
No issues found in Microsoft.Bot.Configuration.dll
No issues found in Microsoft.Bot.Connector.dll
No issues found in Microsoft.Bot.Schema.dll


feature request: make date format configurable

Make the simple date format in WhereSpecification configurable by checking the spring properties file for a property which defines the format.
Something like
com.jontian.specification.dateformat="yyyy-MM-dd"
which will override the default if present.

That's a good idea! Actually, I was going to make it configurable. Thanks for you advice!

Hi.
Read spring properties require Spring Context or making this tool managed by Spring. But I am not going to coupling with Spring at this point. As kind of trade off,  I added 2 setters for this dataFormat, once static format, once instance specific value.
please check WhereSpecification.java


Question about loading the pretrained salsanext model

Hi!
Thanks so much for the codes! I've a question about loading the pretrained salsanext model. When I followed the steps outlined in the "How to use" section and tested on the toy example, I came across the issue when trying to run infer.py on the toy dataset (python3 infer.py -d ../../../../data -m ../../../../data/model_salsanext_residual_1 -l ../../../../data/predictions_salsanext_residual_1_new -s valid) and got this error:
RuntimeError: ../../../../data/model_salsanext_residual_1/SalsaNext_valid_best is a zip archive (did you mean to use torch.jit.load()?)
I tried to switch from torch.load() to torch.jit.load() in the user.py as it suggested but it leads to other errors. What did I do wrong, or did I miss something along the way? I set up the environment according to the instruction linked on the github (using Pytorch 1.1).
Thank you in advance for your help!

Hey @maneekwant, thanks for using our code!
You need to unzip the pre-trained model before using it.
If there are still any problems, please feel free to let me know.

Thanks for the quick reply! I tried unzipping the SalsaNext_valid_best and now the error is that it’s a folder instead of a file. Did I miss something else too? Thanks so much!

Thanks for the quick reply! I tried unzipping the SalsaNext_valid_best and now the error is that it’s a folder instead of a file. Did I miss something else too? Thanks so much!

Sorry, I misunderstood your question. You need to only unzip model_salsanext_residual_1 but not SalsaNext_valid_best.
It seems your torch cannot load it and could be a version conflict. Mine is Version: 1.5.1+cu101. You may upgrade the pytorch and give it another try.

That works thanks so much!

Thank you for using our code! If you find the code and my answer helpful, I will appreciate it if you could star our repo :-)

That works thanks so much!

@maneekwant ，I meet the same problem, "FileNotFoundError: [Errno 2] No such file or directory: '../../../../data/model_salsanext_residual_1/SalsaNext_valid_best'",,,,,,,
could you tell me how to solve?


[Feature Request] Add new display option of thumbnails

Describe your suggested feature
An option to change the thumbnails in the grid view.
Like have the ability to have 4 manga in a row.
Other details
Like what you can do in tachij2k.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

I'm not sure I understand. You can already change how many manga are displayed per row.


Disable Bors on this repo

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          43     34    -9
=====================================
- Hits           43     34    -9

Impacted Files
Coverage Δ

src/util.jl
100% <0%> (ø)
:arrow_up:

src/env_mapping.jl
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee355d...273ffb3. Read the comment docs.


docs: add link to Guppy since it has been released some time ago now

Awesome, thanks!

with pleasure :)


Add storage table to portal workflow

@JasonGerend
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

*** THIS IS NOT READY FOR PR REVIEW***

@dansisson  can you please close this? I scrubbed and added this content in a separate PR.

You've got the wrong "Dsisson".
--derek
On Mon, Feb 12, 2024 at 12:45 PM Alpa Kohli @.***>
wrote:

@dansisson https://github.com/dansisson can you please close this? I
scrubbed and added this content in a separate PR.
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-stack-docs/pull/2801#issuecomment-1939227365,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVMTOFF5MWLOFYQM6MNODYTJIK5AVCNFSM6AAAAABBVB3XD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGIZDOMZWGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
thanks,
--derek


fix (replicator): Backfill Reactions and Storage Tables

Motivation
In its current implementation the replicator does not backfill the storage_allocations or reactions table. This PR adds logic to do that
Change Summary

Add BackfillFidStorageAllocations job
Remove the storage event type from BackfillFidOtherOnChainEvents as it's now getting added to the chain_events table through processOnChainEvents
Add BackfillFidReactions to the BackfillFidData job

Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] PR title adheres to the conventional commits standard
[ ] PR has a changeset
[ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
[ ] PR includes documentation if necessary.
[x] All commits have been signed

Additional Context
Adding these two backfill jobs increases the backfill time significantly. We should add the ability to bootstrap the replicator from a snapshot like hubble

PR-Codex overview
This PR focuses on backfilling various data for a given fid.
Detailed summary

backfillFidOtherOnChainEvents.ts:

Removed OnChainEventType.EVENT_TYPE_STORAGE_RENT from eventTypes array.
Added idRegisterEventTypes array.

backfillFidStorageAllocations.ts:

Added imports for OnChainEventType, getOnChainEventsByFidInBatchesOf, registerJob, and processOnChainEvents.
Exported BackfillFidStorageAllocations as a registered job.
Added a run method that backfills storage allocations for a given fid.

backfillFidData.ts:

Imported BackfillFidReactions and BackfillFidStorageAllocations.
Added backfilling for reactions and storage allocations for a given fid.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Thank you!

Merged your change with an additional modification in #1592.


Fix sink implementation

bug in shutdown of p2p sink, dropping without calling inner sink's poll_close method. fix docs.

Great work! Sry, may I ask a non-business related question, what is the special purpose of removing semicolon here? This seems legit, just wondering if this serves some specific purpose or is for syntactical consistency across the repo.

Great work! Sry, may I ask a non-business related question, what is the special purpose of removing semicolon here? This seems legit, just wondering if this serves some specific purpose or is for syntactical consistency across the repo.

that was the lint


chore: nodejs-hello-world-1 to 0.0.4

chore: Promote nodejs-hello-world-1 to version 0.0.4

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Configure user ssh-agent

Refs:

https://stackoverflow.com/questions/18880024/start-ssh-agent-on-login
https://chromium.googlesource.com/apps/libapps/+/HEAD/nassh/doc/hardware-keys.md
https://gist.github.com/atdt/bac712b0a45ebe06b614
https://access.redhat.com/articles/1523343

Considering that with smartcards only a pin is required, not a full password, this is being moved to the 2.0 release plan


Fixed icons for "Functions" entry in treeview

Added icons for under "Functions" entry in treeview.
Fixed so that the namespace is used as a label so that the top entry in functions does not have {...} as label.
This should fix the rest of issue #421

Thanks again!  I probably won't have time to review until January - I'm out starting Thursday.  We just released 0.8.3 with your previous icon fixes.

Obviously I meant 2021.  You should have known that if you'd had 2020 vision.  :-)  Been very busy, but will get to it...

FYI, the fix for this bug has just been released in v0.8.4


Need nodeid in lookup record of passive-discovered switches for POAP

In order to be able to run the POAP workflows on passively discovered switches, we need to have the nodeid in the lookup record.  This needs to be created at the time the switch is discovered so it doesn't try to active-discover when it sends the DHCP request.
Discussed with @benbp last night.

This is an urgent issue for a customer engagement.

I tried this on the latest build of the 1.2 branch and found that it is adding the lookup records for the switch but it is setting the nodeID to "".

Keep in mind this is doing passive (not active) discovery on the switches.

@VulpesArtificem FYI

Tried again with a new build of on-http and it seems to be working now.  Add this one to the list of issues related to our bad build.  Closing.

😈


type incompatible

classifier.setClassifierDataset(dataset);

The code above will cause the type incompatible as follow: (Typescript)
const dataset: {
    [label: string]: Tensor2D;
}
Argument of type '{ [label: string]: import("/ml-project/node_modules/tensorset/node_modules/@tensorflow/tfjs-core/dist/tensor").Tensor2D; }' is not assignable to parameter of type '{ [label: string]: import("/ml-project/node_modules/@tensorflow/tfjs-core/dist/tensor").Tensor2D; }'.
  Index signatures are incompatible.
    Type 'import("/ml-project/node_modules/tensorset/node_modules/@tensorflow/tfjs-core/dist/tensor").Tensor2D' is not assignable to type
'import("/ml-project/node_modules/@tensorflow/tfjs-core/dist/tensor").Tensor2D'.
      Property 'isDisposedInternal' is protected but type 'Tensor<R>' is not a class derived from 'Tensor<R>'.ts(2345)

With as any can ignore this, but it make uncomfortable.
classifier.setClassifierDataset(dataset as any);

Maybe it caused by import Tensorset from 'tensorset/lib/Tensorset';
Replace the import statement with const Tensorset = require('tensorset'); is ok!

Hi @qtisan, thanks for the first issue!
I believe the most recent update to 1.2.9 should help resolve your issue there, but you may want to delete node_modules before installing 👍
I am going to close the issue, but if you have any more problems related to this please ask.
Happy Coding! 👨💻


Generated XLSX files aren't valid XML when data includes escape sequences

If a value such as ^D is written as XLSX, invalid XML is generated and Excel complains. Excel's error: Removed Part: /xl/sharedStrings.xml with XML error.  (Strings) Illegal xml character. Line 1, column 115.
To reproduce:
import tablib
data = tablib.Dataset(headers=['test'])
data.append(['^D'])
with open('out.xlsx', 'wb') as f:
    f.write(data.xlsx)

Then try to open the file in Excel.

Cannot reproduce.
This is now working with Python 3.7.4, Tablib 0.14.0, openpyxl 3.0.0, Excel for Mac 16.30:

Closing as the original issue is quite old. Please comment if this is still a problem and we can re-open 👍


Review if all warnings still need to be surpressed in Pytest.ini

Nothing to change for now as still using the older versions of Django


iOS GameCenter fixes

There are few issues with GameCenter singleton:

Methods connect and is_connected are overlapped with corresponding methods of Object class (the ones that connect signals), therefore they are unreachable from GDScript.
Normally, connect is called automatically at the game start (from os_iphone.cpp) and sends "authentication" event with result. However if GameCenter API is not available, it returns immediately with error (which is ignored) and never sends "authentication" event. And that makes impossible to determine if authentication is already failed or still in progress.
Also, subsequent calls of connect do nothing (and that's fine according to Apple Guidelines), so it's pretty much useless to call it manually.
There is no method for secure authentication with third-party server, though iOS SDK has a method for this.

So, I made these changes:

Changed connect method so it sends "authentication" event with error instead of returning error. That way, "authentication" event is guaranteed to be sent.
Removed GDScript binding for connect method as it's useless anyway.
Renamed is_connected to is_authenticated to avoid confilct with Object::is_connected method.
For authentication with third-party server I added request_identity_verification_signature method which sends "identity_verification_signature" event containing all necessary information for secure authentication (tested it with my own server, works fine).

are these changes good also for 2.1 branch ?

@plucian AFAIK the signature of bind_method was changed since 2.1 branch, so there are some minor modifications need to be made to make this PR compatible with 2.1. But overall it should work on 2.1 too.


Options to customize the search bar, perhaps make it translucent blurry.

Provide a description of the new feature / enhancement
Options to customize the search bar, perhaps make it translucent blurry.
Bit like this.

good idea, Tracked in #4794


Unable to obtain post information from database.

Free Stone .... now because there will be damaged is a good question.
mysqldump: Got error: 144: Table './redmatrix/item' is marked as crashed and last (automatic?) repair failed when using LOCK TABLES

grrr solved
mama@zeuza:/var/lib$ sudo -u mysql myisamchk -r -v mysql/redmatrix/item
[sudo] password for mama:

recovering (with sort) MyISAM-table 'mysql/redmatrix/item'
Data records: 0
Fixing index 1

Searching for keys, allocating buffer for 149745 keys
Dumping 17701 keys

Fixing index 2

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 3

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 4

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 5

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 6

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 7

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 8

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 9

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 10

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 11

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 12

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 13

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 14

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 15

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 16

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 17

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 18

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 19

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 20

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 21

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 22

Searching for keys, allocating buffer for 7824 keys
Last merge and dumping keys

Fixing index 23

Searching for keys, allocating buffer for 7824 keys
Last merge and dumping keys

Fixing index 24

Searching for keys, allocating buffer for 7709 keys
Last merge and dumping keys

Fixing index 25

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 26

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 27

Searching for keys, allocating buffer for 2695 keys
Last merge and dumping keys

Fixing index 28

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 29

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 30

Searching for keys, allocating buffer for 17702 keys
Dumping 17701 keys

Fixing index 31

Searching for keys, allocating buffer for 18708 keys
Last merge and dumping keys

Fixing index 32

Searching for keys, allocating buffer for 18708 keys
Merging 620878 keys
Last merge and dumping keys

Fixing index 33

Searching for keys, allocating buffer for 18708 keys
Dumping 0 keys

Fixing index 34

Searching for keys, allocating buffer for 18708 keys
Dumping 54 keys

Fixing index 35

Searching for keys, allocating buffer for 18708 keys
Dumping 0 keys

Fixing index 36

Searching for keys, allocating buffer for 18708 keys
Dumping 0 keys
Data records: 17701

http://stackoverflow.com/questions/8843776/mysql-table-is-marked-as-crashed-and-last-automatic-repair-failed

@mama21mama This issue is closed because Redmatrix evolved into Hubzilla. When this is still an issue in the most recent version of Hubzilla, please recreate this issue over there. We're sorry for any inconvenience this will maybe give you.


[ALLUXIO-2217] Split up the responsibilities of alluxio.home

https://alluxio.atlassian.net/browse/ALLUXIO-2217

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11294/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11295/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11296/
Test PASSed.

LGTM

This change causes the following error in web interface:
HTTP ERROR: 500

Problem accessing /home. Reason:

    javax.servlet.http.HttpServletRequest.isAsyncStarted()Z

@osidorkin What version of java are you using, and how did you produce the error? The UI seems to be working fine for me in java 1.7.0_79 and 1.8.0_72. Are you sure this PR is the source of the problem?

Still investigating this issue. It was fixed when I reverted this change but now I'm not sure that this change is the root cause as it's failing again. Tried Oracle Java 7 and Java 8 under ubuntu 14.04 and Java  8 under Mac 10.11.4.

@osidorkin Thanks for investigating. There were recently some known issues with java versions later than 1.8.0_91, but those should have been fixed by https://github.com/Alluxio/alluxio/pull/3888. It sounds like you might be seeing something different though since you hit the issue in Java 7. I just upgraded to 1.8.0_102 and all of the pages in the UI seem to be loading fine. I'm testing on Mac 10.10.5. If you're able to reproduce the issue, please file a JIRA ticket so we can get this fixed.

I isolated this issue. If -Dhadoop.version=2.7.1 parameter is set, Alluxio server will be compiled with wrong servlet-api library which causes missing method error posted above. If this flag is omitted (defaulted to 2.2.0) web ui works fine.
I think the following compilation warning is related to this issue:
[WARNING] javax.servlet-api-3.0.1.jar, javax.servlet-3.1.jar define 74 overlappping classes:
[WARNING]   - javax.servlet.http.Cookie
[WARNING]   - javax.servlet.ServletContext
[WARNING]   - javax.servlet.Registration
[WARNING]   - javax.servlet.http.HttpSessionListener
[WARNING]   - javax.servlet.http.HttpSessionContext
[WARNING]   - javax.servlet.FilterChain
[WARNING]   - javax.servlet.http.HttpServletRequestWrapper
[WARNING]   - javax.servlet.http.HttpSessionAttributeListener
[WARNING]   - javax.servlet.http.HttpSessionBindingListener
[WARNING]   - javax.servlet.annotation.HandlesTypes
[WARNING]   - 64 more...


Correcting offsets of row, column menus

Appropriate offsets of row, column header tables added to the offset of
the row/column menu. Done to accommodate for the negative offsets
introduced due to scrolling which in turn resulted in the row/column
menus of the rows/column outside the initial view being out of view
bounds.

This is great! Very helpful, thank you!


isFloat returns false for "-.01"

validator.isFloat("-.01") = false. I'm using version 6.2.0 currently, didn't know if this is expected or has been reported already.

Thanks for the report.
Given that -.01 is allowed as a literal and is accepted by parseFloat I think it's ok:
> -.01
-0.01
> parseFloat('-.01')
-0.01

Also it looks like isFloat('.01') is true so this is inconsistent behavior.


Migrate to openJ9 0.29 and remove openj9 0.27

OpenJ9 0.27 has stopped receiving updates and has been superseded by OpenJ9 0.29. We should consider dropping it from the build. This is valid for both JDK8 and JDK11.
@durban I will leave the two versions co-existing for a while. Let me know when the old one can be dropped.

Closed with #36.

@vasilmkd Sorry for not getting back to you. Yes, I'm fine with dropping the old one.


⚠ SceneTime has degraded performance

In c29ce63, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 4893 ms

Resolved: SceneTime performance has improved in 6ffcfc4.


fix missing datasource error message

When a datasource is deleted, slices show a cryptic error message in image 1.
This PR fixes it so it shows a more intelligible error message as in image 2.
@john-bodley @michellethomas

Codecov Report

Merging #5019 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5019      +/-   ##
==========================================
+ Coverage   77.34%   77.34%   +<.01%
==========================================
  Files          44       44
  Lines        8664     8665       +1
==========================================
+ Hits         6701     6702       +1
  Misses       1963     1963

Impacted Files
Coverage Δ

superset/views/core.py
74.68% <100%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72c9cd...cf374ef. Read the comment docs.

Should we cascade deleted datasource and delete the corresponding slice(s)?

@john-bodley In the case where I found the issue, the user wasn't aware the underlying datasource was missing.

@mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns

datasource_info is the first place the datasource is checked from the form data. And it's the first place

The method intentionally does not fail because the error is handled downstream (https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L60), where the intelligible error message (Viz is missing a datasource) is displayed.

Can we change the error message to something like "The data source associated with this chart no longer exists"?
Also, should we raise right then (asap) instead of waiting for raising in viz.py

About cascading, I think that would be the desired behavior as long as there's clarity on what is happening. There should be a confirmation screen with all the associated objects that are going to be deleted, and the person performing the operation should have write/delete access to all these objects.

Agree with raising early. Done that.
I agree with the cascading idea of forcing users to delete all other dependent slices before deleting the slice but I'll push it to a future PR.


rowlimit doesn't seem to work with "_x" subdomains

As the documentation says, the x_ variants are used to rotate the reading order.
When doing that columns become rows and viceversa - the colLimit attribute controls the number of rows to split the domain into.
rowlimit should then control the number of columns, but doesn't seem to work, the column number resolves to the default value.
I am using only rowlimit in the options, in a month domain with x_day subdomain.

Nevermind, I had some mistakes in my code, it works correctly!


Span is not tagged with error if exception is handled by spring boot controller advice

I have a spring boot service with @ControllerAdvice and @ExceptionHandler. These mechanism swallow the exception and it never reaches the TracerFilter and span is not tagged as error.
Can we also check the status code and decide if the Span should be tagged as error in OnResponse of the default decorator.

These mechanism swallow the exception and it never reaches the TracerFilter and span is not tagged as error.

Isn't that expected? The exception hanler catches business exceptions and returns "ok" response. In this case  it's more appropriate to instrument exception handler to tag spans with an exception.

@pavolloffay yes, you are right. I agree that this should be handled in Spring library instead of this generic servlet library.
I will create respective issue and will close this issue here.
Thanks.


Plugin error on load: "attempt to call field 'list_contains' (a nil value)"

I recently upgraded and upon opening a luau file I am getting the error in the title. Based on a quick search from the neovim codebase the 'list_contains' function does not appear to be present on 'v0.9.5'
function in master: https://github.com/neovim/neovim/blob/master/runtime/lua/vim/shared.lua#L308
same file in v0.9.5: https://github.com/neovim/neovim/blob/v0.9.5/runtime/lua/vim/shared.lua#L449
I am not sure how this should be resolved perhaps it should be clarified with the neovim team as to why this function is not in stable and whether it is planned to be.

Hmm thats weird, It seems like it was introduced 9 months ago. So it should definitely be shipped with v0.9.5?

I've pushed a fix recently. Feel free to reopen if you still have a related issue. Thanks for reporting.


Bp update

What:
make bp update
e2e harness update
Why:
operators are required to subscribe to osde2e bp convention in order to use harness consistently
https://issues.redhat.com/browse/SDCICD-1021

Codecov Report

Merging #117 (309b402) into main (d40a2d4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   50.00%   50.00%
=======================================
  Files          10       10
  Lines         446      446
=======================================
  Hits          223      223
  Misses        213      213
  Partials       10       10

/lgtm
/approve


 Any Loom videos or screenshots usually help a lot!
I'm trying to set default values for nested items, but they won't apply when set at the same level with the nested item's definition.
This is not a big deal as, generally, blocks decide context and context decides defaults, but this behaviour could be mentioned in the docs.
Reproduction
https://github.com/oxentree/tinacms-block-defaultitem
Steps to reproduce

Clone the reproduction repo and run it
Edit or create a new post
Add a new "Hero" block
Notice that main block defaults (size) was applied, but inner block defaults (color, text) did not.

System Info
-

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

@Raven0us  this is the expected behaviour. It is a the top level on purpose to help convey that the default item only applies when the template is created.
I agree that the docs should explain this better.

Notice that main block defaults (size) was applied, but inner block defaults (color, text) did not.

To elaborate more on this to close the loop, I see that you're using defaultItem on a non-list string field.
defaultItem is only a valid prop on:

Collections/Templates:

This can contain nested values. It's applied when a Document is created.

List Fields

These defaults are applied when a new list-item is created.

I just added an extra note to a doc here: https://github.com/tinacms/tina.io/pull/1707, but I think we'd be open to other docs suggestions for smoothing out this DX! Hope that gets you sorted for now!


[Feature Extraction] Group 3-5 Feature

Added group 3-5 feature for block-level feature extraction.

I'm merging this PR given there is no actual problem - you may address those nitpicks in the next PR


x/tools/gopls: unimported completions only returned on second call to Completion

What version of Go are you using (go version)?

$ go version
go version devel +2b50ab2aee Tue Mar 2 06:38:07 2021 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.1.1-0.20210227203037-f5a4005dda57
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20210227203037-f5a4005dda57

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/myitcv/gostuff/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel +2b50ab2aee Tue Mar 2 06:38:07 2021 +0000"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/.vim/plugged/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1538164450=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Start by adding github.com/kr/pretty to your module cache:
cd $(mktemp -d)
go mod init blah.com
go get github.com/kr/pretty

Then separately create the following setup:
-- go.mod --
module blah.com

go 1.16
-- main.go --
package main

func main() {

}

Edit main.go as follows:
package main

func main() {
        pretty.Spr_
}

and trigger completion with the cursor in the position shown by _.
What did you expect to see?
Unimported completion results that include github.com/kr/pretty.
What did you see instead?
No results. I only see results if I trigger a second completion request.
Logs:

gopls.log
govim.log

cc @stamblerre
FYI @leitzler

Pulling out the relevant pieces of the log:
[Trace - 16:21:38.391 PM] Sending notification 'textDocument/didChange'.
Params: {"textDocument":{"version":12,"uri":"file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go"},"contentChanges":[{"range":{"start":{"line":3,"character":0},"end":{"line":4,"character":0}},"text":"\tpretty.Spr\n"}]}

[Trace - 16:21:38.852 PM] Sending request 'textDocument/completion - (2)'.
Params: {"context":{"triggerKind":0},"textDocument":{"uri":"file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go"},"position":{"line":3,"character":11}}

[Trace - 16:21:38.953 PM] Received response 'textDocument/completion - (2)' in 101ms.
Result: {"isIncomplete":true,"items":[]}

[Trace - 16:21:39.778 PM] Sending notification 'textDocument/didChange'.
Params: {"textDocument":{"version":13,"uri":"file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go"},"contentChanges":[{"range":{"start":{"line":3,"character":0},"end":{"line":4,"character":0}},"text":"\tpretty.Spr\n"}]}

[Trace - 16:21:40.562 PM] Sending request 'textDocument/completion - (3)'.
Params: {"context":{"triggerKind":0},"textDocument":{"uri":"file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go"},"position":{"line":3,"character":11}}

[Trace - 16:21:40.665 PM] Received response 'textDocument/completion - (3)' in 102ms.
Result: {"isIncomplete":true,"items":[{"label":"Sprint","kind":6,"detail":"(from \"github.com/kylelemons/godebug/pretty\")","preselect":true,"sortText":"00000","filterText":"Sprint","insertTextFormat":1,"textEdit":{"range":{"start":{"line":3,"character":8},"end":{"line":3,"character":11}},"newText":"Sprint"},"additionalTextEdits":[{"range":{"start":{"line":1,"character":0},"end":{"line":1,"character":0}},"newText":"\nimport \"github.com/kylelemons/godebug/pretty\"\n"}]},{"label":"Sprint","kind":6,"detail":"(from \"github.com/kr/pretty\")","sortText":"00001","filterText":"Sprint","insertTextFormat":1,"textEdit":{"range":{"start":{"line":3,"character":8},"end":{"line":3,"character":11}},"newText":"Sprint"},"additionalTextEdits":[{"range":{"start":{"line":1,"character":0},"end":{"line":1,"character":0}},"newText":"\nimport \"github.com/kr/pretty\"\n"}]},{"label":"Sprint","kind":6,"detail":"(from \"github.com/niemeyer/pretty\")","sortText":"00002","filterText":"Sprint","insertTextFormat":1,"textEdit":{"range":{"start":{"line":3,"character":8},"end":{"line":3,"character":11}},"newText":"Sprint"},"additionalTextEdits":[{"range":{"start":{"line":1,"character":0},"end":{"line":1,"character":0}},"newText":"\nimport \"github.com/niemeyer/pretty\"\n"}]},{"label":"Sprintf","kind":6,"detail":"(from \"github.com/kr/pretty\")","sortText":"00003","filterText":"Sprintf","insertTextFormat":1,"textEdit":{"range":{"start":{"line":3,"character":8},"end":{"line":3,"character":11}},"newText":"Sprintf"},"additionalTextEdits":[{"range":{"start":{"line":1,"character":0},"end":{"line":1,"character":0}},"newText":"\nimport \"github.com/kr/pretty\"\n"}]},{"label":"Sprintf","kind":6,"detail":"(from \"github.com/niemeyer/pretty\")","sortText":"00004","filterText":"Sprintf","insertTextFormat":1,"textEdit":{"range":{"start":{"line":3,"character":8},"end":{"line":3,"character":11}},"newText":"Sprintf"},"additionalTextEdits":[{"range":{"start":{"line":1,"character":0},"end":{"line":1,"character":0}},"newText":"\nimport \"github.com/niemeyer/pretty\"\n"}]}]}

I'm seeing what looks like 2 of the same didChange notification. Is it possible that's related here? Maybe it's possible that the incoming didChange notification caused the first request to be canceled?
/cc @heschik

The completion request took 101ms which almost certainly means it timed out while scanning the filesystem. I don't see a reason to think there's a bug offhand.

I'm not sure I follow that logic, because the second call took 102ms.
That said I'm fairly sure there is some sort of issue here, not least because I'm using -remote with the following flags:
-remote=auto;$ID -remote.listen.timeout=0

(for some $ID)
The first completion request fairly consistently (90%+) fails every time I open a new Vim+govim instance, despite the fact that instance should be connecting to the same remote daemon. So I would expect the "unimported cache" (or whatever it is called) to be warm.

Calls to completion will be prone to slowness while the disk is being scanned, but that doesn't mean they can't return results. The second one happened to find some packages that matched before the scan was done.
There is not, and has never been, an attempt to share the goimports cache across workspaces. Rob has filed #44863 for that. I don't see anything else to do here, so closing.

There is not, and has never been, an attempt to share the goimports cache across workspaces.

Thanks, in the context of #44863 and the discussion we had around that I now understand the current behaviour.


Add a note about Agent 6/7 support on macOS

What does this PR do?
Backport of #13384.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

I'm going to merge without docs team approval, as it's a 1:1 backport of a PR approved by them: https://github.com/DataDog/datadog-agent/pull/13384


Allows cleanup.sh to run non-interactively in terminal

This change allows cleanup.sh to run non-interactively in standard terminals.
For example: NAMESPACE="test123" ./cleanup.sh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ruzickap
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu
If they are not already assigned, you can assign the PR to them by writing /assign @frankbu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ruzickap. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I signed it!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ruzickap, venilnoronha
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [venilnoronha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruzickap: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ruzickap: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@ruzickap: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ruzickap: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ruzickap: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Any chance to get this merge without failing tests?
I believe such small change doesn't cause the issues found by the tests...?
Looks like CI test are probably "broken"...

@rshriram

/retest

/test e2e-simpleTests-cni

@ruzickap: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
6bce44aca3e388d3aab37a43f5c3173c29f82f78
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


const used in a for loop when targeting ES6 sails through redeclaration check and fails at runtime.

TypeScript Version:  2.4.1
Code
function testThing(parameter: number) {
  for (const parameter of [1, 2, 3]) {
  }
}
testThing(5)

Expected behavior:
Should flag this up as a redeclaration as if a line like const parameter = 1 had been duplicated.
Actual behavior:
In Safari at least this will blow up at runtime with Cannot declare a const variable twice: parameter.

Looks like a bug in JSC. Looking at the evaluation semantics for for in the ES6 spec, the spec is clear about how const vs. let are evaluated.  When evaluating  ForBodyEvaluation it only uses the perIterationLets which does not include the consts.

https://trac.webkit.org/changeset/217200/webkit/trunk/Source


[fix] issues-235 Kubernetes storage causing MySQL startup delay

fix issues-235
https://github.com/alibaba/SREWorks/issues/235
Increase the duration of MySQL survival probe detection.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add state saving.

The program must save its position on the screen and current layout between launches. Maybe add a simple config file with all that data. Avoid putting anything in the registry.

Maybe with a .Net *.config file next to the exe.
Or in some user AppData location?
Maybe depends on the long-term goal how the exe, layouts, config should be deployed/installed.
I mean it could be a "PortableApp" where everything is contained in a root folder.
Or should it be installed to Program Files where the *.config and layouts would have to be stored in User AppData or so.


[MT] Student Group Page Updates & Flow

Designed by Fiona, please review with her!
Make the following changes to the Student Group page:

The graphs should display the actual student groups data.
The year/cycle dropdowns should be grayed out (set disabled=true) and only display the student group’s actual year/cycle (this should already come from the backend request).
Connect “return to site” button back to the dashboard, “view profile” buttons to the student's page, and “edit group” to the edit student group modal.

/cib student-group-page-updates-flow

Branch 137-student-group-page-updates-flow created!


working with svg image received from server as data

My react app is receiving svg as response from an API call and it is currently rendered using below syntax
<span dangerouslySetInnerHTML={{__html: this.state.data.image}} />
I want to add pan-zoom features but not sure how to do it with this library. Could you please allow passing image data as props to this component or suggest any workarounds.
-thnx

React SVG Pan Zoom requires SVG size to work properly. You should at least parse the  definition and create an <svg> tag with that data.
<ReactSVGPanZoom ... >
    <svg width={parsedWidth} height={parsedHeight}  dangerouslySetInnerHTML={{__html: this.state.data.image}}
</ReactSVGPanZoom ... >

I haven't tested it, but it should work. Let me know.

forked your jsfiddle with this change but it is not working. Please have a look at
https://jsfiddle.net/dy10/dnatL9bd/

Solved! We can't set the inner html of the <svg> element, but we need a <g> element inside it.
https://jsfiddle.net/dnatL9bd/4/
 var img = '<g><circle cx="108" cy="108.5" r="100" fill="#0ff" stroke="#0ff"/></g>'

class Example extends React.Component {
    render() {
        return (
            <ReactSVGPanZoom
        width={500} height={500}
        onClick={event => console.log(event.x, event.y, event.originalEvent)}>

        <svg width={500} height={500}>
          <g dangerouslySetInnerHTML={{__html: img}}/>
        </svg>
      </ReactSVGPanZoom>
        );
    }
}

This works. Thanks a lot !

You're welcome

Hello @chrvadala , first of all, thanks for this great repo!
I am trying out the technique described here and I got it to work as advertised. However, the miniature feature looks has the SVG content translated to the top left corner and miniaturized to take up only a small fraction of the miniature view.
Would appreciate some help and pointers! thanks.
Here is a link to my repo:
https://github.com/lionkeng/test-react-svg-pan-zoom
Here is a screen shot of the problem.

Hi @lionkeng,
Did you find a fix for the miniature feature not being correct ?

Hi @lionkeng,
Did you find a fix for the miniature feature not being correct ?

hi @KristianLonergan - I think we ended up not using the miniature feature at that point. That said, we were testing then with an older version of v2. Seems to be working now in another project where we are using this feature with v3.


Improving sign out, fix rotation crash, doc update

@amandle please review
Fixes #187
Fixes #155
Fixes #227

LGTM


Polyglot notebook stuck on Installing .NET Interactive version 1.0.425803...

Describe the bug
Please provide as much information as you can.
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):
1.0.425803+1db2979099d0272660e1497cae9b9af1238db42f
dotnet sdk 7.0.203 arm64

OS

[ ] Windows 11
[ ] Windows 10
[x] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[x] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[x] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Visual Studio
[ ] Other (please specify)

Screenshots
If applicable, add screenshots to help explain your problem.
I've installed, re-installed and tried everything possible on my end to ensure the right version of .NET SDK and dotnet-interactive is installed. Whenever I attempt to open a '.dib' file, it gives me the following error

And it remains in some sort of infinite download in the progress bar below like that never finishes.

Both dotnet and dotnet interactive are in the path
I tried changing the version, modifying the required version to match the exact string provided by dotnet interactive --version to no avail.
My VSCode version is 1.78.2
Any help/suggestions in how to proceed to get this open/working would be great.
Thank you in advance!

I'm not sure if its related -- but it finally worked after I installed Visual Studio Community and tried opening the .dib file, not sure if it was the remedy.

What help  me identify my issue was in the output window in vscode, select polyglot Notebook diagnosis from the drop down on the right. Mine ended up being because of authentication issues with a github source I added to my nuget package list. (Once I resolve that Ill update this thread with my out come


docs: Additionnal information on how to do some things (systemd|ansible|fetch file from web)

Ok, I got my ublue to build and running. The ISO builds and installation works.
I am finding it hard to find information on how to configure the system after. I am thinking like Nix or Ansible fine tuning.
Use case:
I will run ublue on my PCs as well as my relatives that I am slowly moving away from Windows. Ublue will allow me to not manage those computers personally. While they can install their own flatpak, it's going to be easier to manage them from my recipe.yml.
So now, the information missing in the documentation is mainly :
systemd : enable/disable a service by default
Example : sshd seems to be enabled by default (on first installation). How could I disable it ?
From the recipe.yml or with a script/sshd.sh ?
From what I know, a link like this should do the work, but how to bundle it ?
ln -s /etc/systemd/system/post_deploy.service etc/systemd/system/multi-user.target.wants/
ansible : run playbook to configure the system
Changes to /etc on the ublue ghcr.io will not overwrite local /etc, so ansible would be needed for that, right ?
How to get recipe.yml to fetch latest ansible playbook from git and save it to /usr/var/local/ansible_playbook ?
Example : run a playbook on first boot to configure system specific configs. Fetching from github and running the playbook_firstboot.yml on new installation.
Example2 : run a playbook_rebased.yml after rpm-ostree rebased to a new version, update github copy and run playbook.
This is so I can propagate changes to all computers without having to punch a hole in firewall or knowing where the laptop is at.
Things like preventing sleep of laptop when on power.
appimage : fetch latest appimage
While flatpak are great, there are a few app that ships a .appimage file. How could I have it fetched a fresh version and saved in /usr/local/bin for updates with every rpm-ostree upgrade ?
Example: dvdisater
multiple images from single codebase
While there is some information, a complete example would be better with individual file view like this.
Great work !
Thanks !

systemd : enable/disable a service by default
there is a specific systemd modue that handles this:
https://blue-build.org/reference/modules/systemd/

ansible : run playbook to configure the system
while we don't have specific support for this, you can use a script module, or make your own
https://blue-build.org/reference/modules/script/
https://blue-build.org/reference/module/

appimage : fetch latest appimage
same here, just using the script module would probably be sufficient

multiple images from single codebase
not sure if the docs explained it, but you can define modules in different files and use  from-file: path/to/yaml.yml to source them.

I'm gonna answer in the same way as gerblesh did, repeating some points and adding some of my own.
systemd
Looking at the list of modules on the website is a great way to figure out what things are supported easily OOTB. The search on the website also works pretty well. There's a systemd module for doing exactly what you describe: https://blue-build.org/reference/modules/systemd/
ansible
While first-class support for ansible isn't planned, the idea of having a module for running scripts at first boot has floated around.
That being said, changes to the /usr/etc/ in the image do progagate to image users' /etc/ if they haven't edited that specific file locally themselves. I can't of course be certain about it, but I find it unlike that your relative will go and edit a file in /etc/.
You can't save an ansible playbook to /usr/var/local/ (first because that doesn't exist, you probably meant /var/ or /usr/local/), but also because that is the system administrators territory to be changed locally. You could make a script to do a git clone for the playbook into /usr/share/ansible-playbook/ or some other custom folder like that.
I'm unsure what you ask to be done, documentation-wise, about this.
Appimage
I'm unfamiliar with what the runtime requirements are to run Appimages, or how Appimages can be used of atomic Fedora.
They can be fetched into /usr/bin/ (not /usr/local/bin/, again, because that is local sysadmin territory and not included in custom images) using a script. The exact mechanics of how to fetch them vary wildly depending on the platform used to distribute them. GitHub releases unfortunately makes it kind of hard to always fetch the latest version, so if you don't want to figure that out you can just download a specific numbered version, or request that a module be made for the usecase and hope that gets implemented soon.
I'm unsure what you ask to be done, documentation-wise, about this. This page already covers some of the directory-related things I talk about: https://blue-build.org/learn/mindset/
Multiple images
I believe the docs already include the necessary amount of information to get started with this, but more can be added of course
I believe you're asking for examples of contents of specific files to be added here? That wouldn't be a problem, should be a pretty quick addition.

Well, I did miss the systemd module on the website !
Thanks for the quick replies.
I've split this in a few post for redability.
yafti
Could yafti have it's name written in long in the doc ? "Yet Another First Time Installer".
From what a quick read got me, it looks like a program (gui?) to suggest installing other things on first boot.
More could be added in the documentation in regards to what it does and what it can do. Doesn't seem to be what I am looking for.
Missing modules scripts_firstboot and scripts_postdeploy ?
+1 for module scripts_firstboot: and scripts_postdeploy: !
It could be used to run ansible playbooks or any other scripts only when a) new install b) ostree deployment.
This should be added if ansible can't be a first class citizen any time soon.
Also, It seems firstboot: module exist and is used with yafti ??? It's undocumented ?
Can this work ?
firstboot:
   modules:
      - type: scripts
        script:
          - firstboot.sh

Thanks

Also, It seems firstboot: module exist and is used with yafti ??? It's undocumented ?

The yafti module has a firstboot script to launch yafti, yes, but a firstboot module would use it's own. So no, your solution below wouldn't work.
Also, the yafti module currently links to the GitHub page, which has more information, but I do agree that the module page could give a brief explanation of what yafti is.

Here's a checklist of the actionable things in this issue:

[ ] Add example recipes to https://blue-build.org/how-to/multiple-images/
[ ] Explain what yafti is better on https://blue-build.org/reference/modules/yafti/

After those are completed, the issue could be closed, correct?
There's already an issue tracking the implementation of a potential boot-script module: https://github.com/ublue-os/bling/issues/119

That's 2, missing about running something on first run after rebase.
I am working on a systemd .service and .timer to add as example.
The specific is for a service that will run only on a reboot after a rebase but I can't get it enabled in the recipe.yml, build gives this :
Failed to enable unit, unit rpm-ostreed-deployed.timer does not exist.

The recipe.yml part :
 - type: systemd
    system:
      enabled:
        - sshd.service
        - rpm-ostreed-deployed.timer
      disabled:
        - rpm-ostree-countme.timer # RedHat telemetry disabling
        - rpm-ostree-countme.service
      masked:
        - rpm-ostree-countme.service
        - rpm-ostree-countme.timer

Files :
config/files/usr/etc/systemd/system/rpm-ostreed-deployed.service
[Unit]
Description=Run once on reboot to check if a rpm-ostree was deployed
Wants=rpm-ostreed-deployed.timer

[Service]
Type=simple
ExecStartPre=/usr/bin/env bash -c 'journalctl --boot=-1 | grep ostree | grep "Finalizing staged deployment"'
#return 0 if there was a deployment and 1 if there was no deployment
ExecStart=/usr/bin/env bash -c 'echo "There was a deployment and this is the firstboot!" > /tmp/firstboot_post_deployment.txt'

config/files/usr/etc/systemd/system/rpm-ostreed-deployed.timer
[Unit]
Description=Run on boot

[Timer]
OnBootSec=10
Unit=rpm-ostreed-deployed.service

[Install]
# To have it run only at boot
WantedBy=multi-user.target

It seems that files copied with :
modules:
  - type: files
    files:
      - usr: /usr

can't be enabled for a new service ?

missing about running something on first run after rebase.

That would be a part of the boot-script module I mentioned, I think. I'm not sure if that hack to check if this is the first deployment is the best way, but thanks for doing some hacking on it anyway. Yafti uses a file it places in a local directory to check if it has been run previously. Something like that would work better for multi-user systems, where the first-time script should run for everyone. Ideally, everyone should write boot scripts that can run on every boot, which would accommodate both not being run only once and updates to the script itself being run again on a system.

It seems that files copied with : [...] can't be enabled for a new service ?

Hmm, they should be. The files should be in /usr/lib/systemd/, though. Maybe that should be documented on the systemd module page... And the files module notice should be expanded to note that no program reads from /usr/etc/ so if a configuration file is needed at build time it should be placed in another directory like /usr/lib/ or /etc/

Hmm, they should be. The files should be in /usr/lib/systemd/, though. Maybe that should be documented on the systemd module page... And the files module notice should be expanded to note that no program reads from /usr/etc/ so if a configuration file is needed at build time it should be placed in another directory like /usr/lib/ or /etc/

Ah ! that may be why, as they appear in /etc on the deployed vm but not available during build.
Will try to usr/lib/systemd/system ... waiting for build and deploy...
Ok, builds and I'm able to enable the .timer and it does work.
Thanks
Well, my hack could allow a service to run on every rebase. Like run git pull and ansible.
Could be an example that might be useful until a boot-script module is added. You are free to add it to the documentation as an interesting example :)
Bonus :
Firstboot check
Also, to check if it's a first boot after a fresh installation and not a rebase, it's possible to validate it with :
journalctl --list-boots | wc -l | awk '$1>2{exit 1}'
Could use only one systemd file and use a script to identify if it's a rebase, fresh install, or just a reboot.
Using journalctl is the best way I can think of to check for rebase and first boot.
Also note on how to disable RedHat telemetry with countme, can be nice to let people know they have that enabled by default.
Thanks again.
Also, there was somewhere the info on how to build locally, but on the the howto it's empty ?

For the file module, it's not described how to set a file permission.
For example, I added a /usr/bin/rpm-ostree-check file, but it doesn't have execute flag.
I made a little script set_files_permission.sh to just chmod a+x /usr/bin/rpm-ostree-check
Is this how it's supposed to be ? Seems tedious to do scripts for every command needed to be executed.
I would have tried instinctively to do :
modules:
  - type: commands
    command:
      - chmod a+x /usr/bin/rpm-ostree-check
      - cd /usr/opt ; git clone some repository

Also, there was somewhere the info on how to build locally, but on the the howto it's empty ?

Yess, the documentation is still unfinished.

how to set a file permission.

Not sure, I think git supports setting file perms and those propagate to the built image.

I would have tried instinctively to do...

This will be possible soon.

Also note on how to disable RedHat telemetry with countme, can be nice to let people know they have that enabled by default.

I think a lot of small things people might want to do to customize their image are ones I expect people to ask about and and answer on the forums: https://github.com/orgs/blue-build/discussions
Adding a lot of marginally useful content in the docs isn't the goal. This specific example could probably be tucked on the bottom of the Fedora/Ublue pages, but that would feel like an official endorsement for turning off telemetry.

The docs part of this issue is now done, so closing.


Wait until spinning wheel on chrome stops ?

Is there an event to detect when the tab's loading spinning wheel on chrome stops ? I tried:
networkidle0, networkidle2, domcontentloaded
with no success
ex of page when I need to wait until it is loaded: https://www.translatetheweb.com/?from=&to=fr&ref=SERP&refd=www.bing.com&dl=fr&rr=UC&a=https%3A%2F%2Fwww.247freepoker.com%2F
For now I use a 30 seconds waitFor
Regards

I think #1361 might help.


QT: timer should stop at end of the advertised endDate

Is your feature request related to a problem? Please describe.
The timer should adjust to the end of the test time. If a user starts a test 5 minutes before the end of the test, the timer should be adjusted to 5 min. That way the timer will stop at exactly the time that the test should end.
Describe the solution you'd like
Pseudo-code
testDurationAdjusted = 45;  // from database duration.testDurationAdjusted
amountOfTimeUntilTestEnds = 15; // dateNow minus endDate ;
if testDurationAdjusted < amountOfTimeUntilTestEnds then testDurationAdjusted = testDurationAdjusted
if testDurationAdjusted > amountOfTimeUntilTestEnds then testDurationAdjusted = amountOfTimeUntilTestEnds

Agreed. Good spot guys.


Vulnerability roundup 102: gradle-4.10.3: 2 advisories [7.8]

search, files

[ ] CVE-2021-29428 CVSSv3=7.8 (nixos-20.09, nixos-unstable)
[ ] CVE-2021-29429 CVSSv3=5.5 (nixos-20.09, nixos-unstable)

Scanned versions: nixos-20.09: 76ed24ceab9; nixos-unstable: ea7d4aa9b82.

See also: #116878, #90801

Gradle 4 was removed in eb290d87d3bc06f763b4455341606509b7b845eb.


Build fails with strangeninja error

All of a sudden, the build on my notebook fails with
ninja: error: opening build log: Permission denied

Any ideas? Permissions on /usr/local/bin/ninja seem fine.

What do you have when you run ls -l .ninja_log on your build directory?

It's possible that you don't have enough space on your laptop. Could you check that by running df -h?

Hm, I got a fresh copy and deleted the old repo before I read your comments, checking .ninja_log would have been obvious. Well, I'll reopen this, should I encounter it again.


[_62] rename ssl module (main)

Because of the way Python scripts and modules get imported preferentially
the same directory in which the importing script or module resides, the
two files named ssl.py were conflicting with access to the system ssl module.
This involved:

urllib's access to the system ssl module when imported from within
the irods_testing_environment (modules) subdirectory. This prevented
the mysql odbc driver from downloading to the docker host.

similar problems cropped up when performing a pip install of the
prerequisite docker-compose and GitPython modules.

As a consequence, both ssl.py files have been renamed so as not to pollute
the module namespace.  Also, we've corrected a couple of errors that were
preventing the top-level ssl.py script (now called configure_ssl.py) from
working properly.

looks good to me, awaiting an alan to agree.

tested manually here and in 4-2-stable. #'ing done for both PR's as well https://github.com/irods/irods_testing_environment/pull/69 https://github.com/irods/irods_testing_environment/pull/63


Missing some Pin 1 silkscreen triangles

Tested versions:
KiCad 8.0.4
InteractiveHtmlBom 2.9.0
Some of the pin 1 triangles from silkscreen layer are not rendered.
This means that a clear orientation using ibom.html is not possible.
Example packages where pin 1 triangle does not show up in ibom.html:

Package_TO_SOT_SMD:SOT-23-6
Package_QFP:TQFP-100_14x14mm_P0.5mm

Can you check with ibom from git latest? I think this was fixed in 002d62760ae2c91a267d8c8d2a3b5eccf81439a2

I downloaded hole repo and installed the plugin manually and it is working now.
Problem solved. 🍓
Thank you. 😃

Great.
I really should cut a release soonish...


Command for sending an arbitrary tx to a contract

Command should present the user with a list of the proxies they own, and after they pick one, show a list with the public/external non-constant functions of that contract, and then ask for the arguments.
zos send-tx --to $CONTRACTADDR --method "foobar"
zos send-tx --to $CONTRACTADDR --args "1,2,3,4" --method "foobar(uint256)" --value 10 --gas 30000

Resolved in https://github.com/zeppelinos/zos/pull/848.


Cant install via cocoapods

Added pod into podfile as were shown.
pod 'QRCodeReader.swift', '~> 6.1.0'
when run: pod install get this error:
None of your spec sources contain a spec satisfying the dependency: QRCodeReader.swift (~> 6.1.0).

It may be a cache problem of Cocoapods. Have you tried to clean it?
$ pod cache clean QRCodeReader.swift
$ pod install

I got this message: [!] No cache for pod named QRCodeReader.swift found

BTW I will post full error message:
[!] Unable to satisfy the following requirements:

QRCodeReader.swift (~> 6.1.0) required by Podfile

None of your spec sources contain a spec satisfying the dependency: QRCodeReader.swift (~> 6.1.0).
You have either:

out-of-date source repos which you can update with pod repo update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, pod repo update does not happen on pod install by default.

Is the pod repo update worked?

Yep, it helped, thanks.


chore: ci workflow for release

auto publish ci for release tag when merge master

Codecov Report

Merging #437 (a57bd27) into release-next (3d4c5e3) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-next     #437   +/-   ##
=============================================
  Coverage         82.23%   82.23%
=============================================
  Files                87       87
  Lines              7448     7448
  Branches            941      941
=============================================
  Hits               6125     6125
  Misses             1317     1317
  Partials              6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


OFW

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[ ] Filename in the lowercase format
[ ] Image format: png
[ ] Image size: 256 by 256 px

Added here https://github.com/TrustWallet/tokens/commit/c096cdb56205a2995709c3974db12a8d3697f044
Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwallet.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


Minor makefile cleanup, gofmt

Just noticed these default-args being passed while running it myself, and I believe
the CLI flag overrides the default + env var, so it's less flexible with explicit args
and behaves the same.

Pull Request Test Coverage Report for Build b9acd33d-7357-403e-ac49-c801409d785c

0 of 0   changed or added relevant lines in 0 files are covered.
66 unchanged lines in 11 files lost coverage.
Overall coverage increased (+0.01%) to 56.983%

Files with Coverage Reduction
New Missed Lines
%

common/task/weightedRoundRobinTaskScheduler.go
1
88.6%

common/task/fifoTaskScheduler.go
2
82.47%

service/history/execution/mutable_state_builder.go
2
69.69%

service/matching/taskListManager.go
2
74.19%

service/history/task/task.go
3
78.65%

service/history/task/transfer_standby_task_executor.go
3
89.94%

service/history/execution/cache.go
6
75.0%

common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go
8
76.97%

common/persistence/nosql/nosqlExecutionStore.go
9
60.03%

common/persistence/nosql/nosqlplugin/cassandra/tasks.go
14
72.8%

Totals

Change from base Build 2bd305c9-7831-4ac2-ad96-07972afec7dd:
0.01%

Covered Lines:
83940

Relevant Lines:
147307

💛  - Coveralls


zfsUnstable: 2.1.13-unstable-2023-08-02 → 2.1.13-unstable-2023-08-25

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 252922 run on x86_64-linux 1

6 packages marked as broken and skipped:

linuxKernel.packages.hardkernel_4_14.zfsUnstable
linuxKernel.packages.linux_6_5.zfsUnstable
linuxKernel.packages.linux_latest_libre.zfsUnstable
linuxPackages_hardkernel_latest.zfsUnstable
linuxPackages_latest-libre.zfsUnstable
linuxPackages_latest.zfsUnstable

22 packages built:

linuxKernel.packages.linux_4_14.zfsUnstable
linuxPackages_4_14_hardened.zfsUnstable (linuxKernel.packages.linux_4_14_hardened.zfsUnstable)
linuxKernel.packages.linux_4_19.zfsUnstable
linuxPackages_4_19_hardened.zfsUnstable (linuxKernel.packages.linux_4_19_hardened.zfsUnstable)
linuxKernel.packages.linux_5_10.zfsUnstable
linuxPackages_5_10_hardened.zfsUnstable (linuxKernel.packages.linux_5_10_hardened.zfsUnstable)
linuxKernel.packages.linux_5_15.zfsUnstable
linuxPackages_5_15_hardened.zfsUnstable (linuxKernel.packages.linux_5_15_hardened.zfsUnstable)
linuxKernel.packages.linux_5_4.zfsUnstable
linuxPackages_5_4_hardened.zfsUnstable (linuxKernel.packages.linux_5_4_hardened.zfsUnstable)
linuxPackages.zfsUnstable (linuxKernel.packages.linux_6_1.zfsUnstable)
linuxPackages_hardened.zfsUnstable (linuxPackages_6_1_hardened.zfsUnstable)
linuxKernel.packages.linux_6_4.zfsUnstable
linuxPackages_6_4_hardened.zfsUnstable (linuxKernel.packages.linux_6_4_hardened.zfsUnstable)
linuxPackages-libre.zfsUnstable (linuxKernel.packages.linux_libre.zfsUnstable)
linuxPackages_lqx.zfsUnstable (linuxKernel.packages.linux_lqx.zfsUnstable)
linuxPackages_testing_bcachefs.zfsUnstable (linuxKernel.packages.linux_testing_bcachefs.zfsUnstable)
linuxPackages_xanmod.zfsUnstable (linuxKernel.packages.linux_xanmod.zfsUnstable)
linuxPackages_xanmod_latest.zfsUnstable (linuxKernel.packages.linux_xanmod_latest.zfsUnstable ,linuxPackages_xanmod_stable.zfsUnstable)
linuxPackages_zen.zfsUnstable (linuxKernel.packages.linux_zen.zfsUnstable)
zfsUnstable
zfsUnstable.dev

@gepbird @RaitoBezarius This should be failing with 6.5 according to the versioning for 2.1.13. There has been nothing floating into the current staging branch for 6.5.

There are more updates to this now. Built again on my machine.

I think this was superseeded?

Correct, we are on 2.2.0rc4 now. Closing.


Get rid of force pod deletion

DRA e2e test used force pod deletion for test and plugin pods.
This should not be a default way of deleting pods, but rather an exception.

The commit message is a bit misleading: "used force pod deletion for test and plugin pods."
The delete itself was not using force-deletion. That would have been a DeleteOption with explicit zero as grace period.
It was a bit more indirect: because of the termination grace period being zero, Kubernetes concluded that deletion should also be immediate. It's worth calling that out in the code comment and commit message. A link to https://github.com/kubernetes/kubernetes/blob/0f582f7c3f504e807550310d00f130cb5c18c0c3/pkg/registry/core/pod/strategy.go#L151-L171 would also be useful, for future reference.

FWI, comments in the code are more important than commit message at the moment. Eventually all "e2e dra" commits will be squashed into one, with a commit message that won't capture all details on how the test came into existence.

The delete itself with a grace period 0 is a force deletion in my understanding.
k8s users are also aware of that I think as kubectl doesn't allow to set grace period 0 without using --force.

Referirng to https://github.com/kubernetes/kubernetes/blob/0f582f7c3f504e807550310d00f130cb5c18c0c3/pkg/registry/core/pod/strategy.go#L151-L171 would make it harder to understand in my opinion. At least it did it for me until I read this user-friendly explanation: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination-forced.

The delete itself with a grace period 0 is a force deletion in my understanding.

DeleteOptions.GracePeriodSeconds is a pointer, therefore DeleteOptions{} is not setting GracePeriodSeconds to zero. A client has to explicitly choose force deletion, and that was not done here.

Referirng to https://github.com/kubernetes/kubernetes/blob/0f582f7c3f504e807550310d00f130cb5c18c0c3/pkg/registry/core/pod/strategy.go#L151-L171 would make it harder to understand in my opinion. At least it did it for me until I read this user-friendly explanation: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination-forced.

It's okay to refer to both, but the user-facing documentation does not cover the handling of Spec.TerminationGracePeriodSeconds, does it? That is only in the code.

My point was that we shouldn't give too many details on that. Everybody knows that grace period 0 for pod means its force deletion. The change is self-explanatory in my opinion - we don't want force deletion as a default way of deleting pods in our tests. I can change it to whatever you want if you insist, though.

Everybody knows that grace period 0 for pod means its force deletion.

But that's the point: the cleanup code as written at the moment doesn't set grace period 0. It's completely unexpected that it force-deleted pods. It only became a force-delete because of some setting elsewhere, and that needs to be explained. Otherwise it remains unclear why DeleteOptions.GracePeriodSeconds gets set.

A better solution might be to create pods with a 1 second deletion period and not do anything special in the cleanup code.

ok, closing then


Set \Shopware\Models\Order\Status::$description initially to empty string

1. Why is this change necessary?
This is pure developer experience. The annotations hints that one is discouraged to use \Shopware\Models\Order\Status::setDescription but one is forced to do so as the default value is not compatible with database constraints. Making the database column nullable is considered as a break change as everyone currently expects it to be non-nullable.
One can write a test for this, but the ORM is not usable for this model, yet. See #1355. This PR is not part of #1355 as this is not part of the core problem in #1355 but a nice-to-have.
2. What does this change do, exactly?
It sets the default value of description to empty string. Therefore you do not have to use the setter to use this model properly.
3. Describe each step to reproduce the issue or behaviour.
Do not use \Shopware\Models\Order\Status::setDescription on a new model instance and then insert it.
4. Please link to the relevant issues (if any).
#1355 as this ships the fix to use the ORM to work with this model on insertion.
5. Which documentation changes (if any) need to be made because of this PR?
None
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfill them.

EVEN WORSE.
It is not even deprecated:
https://github.com/shopware/shopware/blob/5.3/themes/Backend/ExtJs/backend/order/view/list/position.js#L269
https://github.com/shopware/shopware/blob/5.3/engine/Shopware/Models/Order/Repository.php#L137
Which one is the right file to add accessing the snippet manager?

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20383
Please use this issue to track the state of your pull request.

Hi @JoshuaBehrens! I just merged your PR (https://github.com/shopware/shopware/commit/9e3453d908834340d79cc74be2062d08452ec864), thank you so much for helping us to make Shopware better! 💙

@soebbing I am happy to help, but what about my additional comment? https://github.com/shopware/shopware/pull/1356#issuecomment-340577152

@JoshuaBehrens Just because something was deprecated does not mean Shopware cannot or should not use the functionality anymore. Shopware still has to support the values that were set for this field!
Deprecations simply means that at one point in the future this function will be removed and gives you time to plan ahead and change your functionality accordingly. For \Shopware\Models\Order\Status::setDescription we currently are are in this transition period: We plan to remove it in the future but currently still support it.

Is there already an alternative I can switch to?

The deprecation message is "Use getName() + snippets instead". You can find an example of how it is supposed to work in the Backend/Mail-controller: https://github.com/shopware/shopware/blob/5.3/engine/Shopware/Controllers/Backend/Mail.php#L100: The name of the status get's translated, using the (deprecated) description as a fallback.

I tried it, but I was not successful. After I set the description it worked out. I will work out some details to my issue but it is related to the referenced files from the comment.


Feature request: Add run support to docker images.

Currently, there seems to be no way to start a new container from an image. The feature requested will add functionality equivalent to:
docker run -(it/d) <image name>:<tag>

Sounds good, I will give it a try.

@arush-sal latest release has basic support to run an image , although still very basic, I will appreciate some feedback.
Cheers

Sorry for the late reply, but couldn't find a way to run an image. Would you mind helping me out with the same or maybe adding the instructions to the README.md?
thanks for your effort :)

Ah, my bad, I have to add instructions somewhere in the docs.
There was a mention in the release notes:
Pressing r on the image list will run a new container from the selected image. The user can provide the command to be run, but for now, additional options are not supported. #45.
Support is fairly limited, passing parameters to Docker run is still not supported, just a command to run can be passed.
I would appreciate any feedback :)


Full details update

On the Routing, we're passing in params to the full details page rather than a specific page type. So what happens I include two params for conflicting types? full-details?restrictionID=1 will land me on the Area Restrictions page now, but when we have other types, how do we handle other params? Duplicate Params? Error checks on "not found" and load failures?


ImageViewerComponent Error

Dears,
I'm working on a project using your plugin but i get error:
no component factory found for ImageViewerComponent. Did you add it to @NgModule.entryComponents?

I checked the module and the ImageViewerComponent already exists in entryComponents
any help with this ?

Importing the module in a Lazy Page didn't work for me. I imported in the App Module and it worked.