iOS Build Always fails

What App Center service does this affect?
React Native SDK, and Build.
Describe the bug
Locally Xcode is building normally but is failing on appcenter.
Expected behavior
Build successful.
Additional context
** ARCHIVE FAILED **
The following build commands failed:
CompileC /Users/vsts/Library/Developer/Xcode/DerivedData/FinFO-fsqyecelonplshafcobztdahtvlt/Build/Intermediates.noindex/ArchiveIntermediates/FinFO/IntermediateBuildFilesPath/FinFO.build/Release-iphoneos/FinFO.build/Objects-normal/arm64/AppDelegate.o FinFO/AppDelegate.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65
##[section]Finishing: Xcode build (signed)
##[section]Starting: Xcode build (signed)

@Faisal-Manzer Did you figure this issue out yourself?

Yes, actually it was an error with code push integration.

Hey, I am reopening this because problem prevails.
iOS Builds are Always failing.
The app was working properly on Local.
I added Archive to App Store also, without any problem it is building.
But on MSAC it is facing an issue.
I tried both signed and unsigned builds, no build succeeds.

ld: library not found for -lRCTSettings
clang: error: linker command failed with exit code 1 (use -v to see invocation)
** ARCHIVE FAILED **
The following build commands failed:
Ld /Users/vsts/Library/Developer/Xcode/DerivedData/FinFO-dsmsfgaczemucsfpiuvbuekjbbmd/Build/Intermediates.noindex/ArchiveIntermediates/FinFO/IntermediateBuildFilesPath/FinFO.build/Release-iphoneos/FinFO.build/Objects-normal/armv7/FinFO normal armv7
Ld /Users/vsts/Library/Developer/Xcode/DerivedData/FinFO-dsmsfgaczemucsfpiuvbuekjbbmd/Build/Intermediates.noindex/ArchiveIntermediates/FinFO/IntermediateBuildFilesPath/FinFO.build/Release-iphoneos/FinFO.build/Objects-normal/arm64/FinFO normal arm64
(2 failures)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65
##[section]Finishing: Xcode build (signed)
##[section]Starting: Xcode build (signed)

The same problem, when we try to build our ios project.

@patniko @lumaxis help, please.

I don't know if this is the same problem or not, but it sounds the same.  iOS (React Native) builds for us have also started failing.  We haven't made changes to our branch configuration, and have been trying to build the same commit that previously worked just a couple of days ago.  Android builds are working as expected... not really sure where to go with it.
The following build commands failed:
	PrecompileSwiftBridgingHeader normal arm64
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(2 failures)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65
##[section]Finishing: Xcode build (signed)
##[section]Starting: Xcode build (signed)
==============================================================================
Task         : Xcode
Description  : Build, test, or archive an Xcode workspace on macOS. Optionally package an app.
Version      : 4.130.0
Author       : Microsoft Corporation
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkID=613730)
==============================================================================
##[section]Finishing: Xcode build (signed)
##[section]Starting: Install Apple provisioning profile

@Faisal-Manzer @gpetrosyan Are you still stuck on this too, or did you find something you could fix on your end?

I should add, our developers were able to build the same branch locally as well.
@patniko Any thoughts on what we should try if they can build locally but it's stopped working in App Center?

@evillemez @Faisal-Manzer @gpetrosyan Do you mind going to App Center portal and use the Intercom bubble at bottom right to start a conversation with support? That will allow us to collect additional information as needed, which could be hard to do here. Also, looking at the pasted logs here, the failure are different, so they likely need to be resolved separately.

Our problem ended up being the version of Cocoapods App Center was using, which must have been updated internally.  We were able to provide a build script to uninstall Cocoapods, and install the version we need, and that got our iOS builds working again.

@evillemez , how did you identify that its a different version ? and how did you fix it?

I ran into a similar problem and I fixed it by updating CocoaPods and dependencies (the second part was probably not needed to solve this problem)

sudo gem install cocoapods
pod update

After that, I have checked-in the Podfile.lock, which updated by CocoaPods version to 1.6.1.

I am also facing same issue . Native IOS(swift) builds of us are also started failing.previously it was working fine but after new commit it got failed. Locally i am able to build using xcode but in appcenter we are facing problem. Don't know how to solve this issue.
** ARCHIVE FAILED **
The following build commands failed:
SwiftCodeGeneration normal armv7
Ld /Users/vsts/Library/Developer/Xcode/DerivedData/Salesgenie_Phase_1-eemuwyhecewcnygojxxsdtijuclm/Build/Intermediates.noindex/ArchiveIntermediates/Salesgenie\ Beta\ Internal\ Prod/IntermediateBuildFilesPath/Salesgenie\ Phase\ 1.build/Adhoc-Prod-iphoneos/Salesgenie\ Phase\ 1.build/Objects-normal/arm64/Salesgenie\ β\	 normal arm64
(2 failures)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65
##[section]Finishing: Xcode build (signed)
##[section]Starting: Xcode build (signed)

I am also facing same issue . Native IOS(swift) builds of us are also started failing.previously it was working fine but after new commit it got failed. Locally i am able to build using xcode but in appcenter we are facing problem. Don't know how to solve this issue.
** ARCHIVE FAILED **
The following build commands failed:
SwiftCodeGeneration normal armv7Ld /Users/vsts/Library/Developer/Xcode/DerivedData/ProjectName-eemuwyhecewcnygojxxsdtijuclm/Build/Intermediates.noindex/ArchiveIntermediates/ProjectName/IntermediateBuildFilesPath/ProjectName.build/Adhoc-Prod-iphoneos/ProjectName.build/Objects-normal/arm64/ProjectName\	 normal arm64
(2 failures)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65
##[section]Finishing: Xcode build (signed)
##[section]Starting: Xcode build (signed)

I am also facing same issue . Native IOS(swift) builds of us are also started failing.previously it was working fine but after new commit it got failed. Locally i am able to build using xcode but in appcenter we are facing problem. Don't know how to solve this issue.
** ARCHIVE FAILED **
The following build commands failed:
SwiftCodeGeneration normal armv7Ld /Users/vsts/Library/Developer/Xcode/DerivedData/ProjectName-eemuwyhecewcnygojxxsdtijuclm/Build/Intermediates.noindex/ArchiveIntermediates/ProjectName/IntermediateBuildFilesPath/ProjectName.build/Adhoc-Prod-iphoneos/ProjectName.build/Objects-normal/arm64/ProjectName\	 normal arm64
(2 failures)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65
##[section]Finishing: Xcode build (signed)
##[section]Starting: Xcode build (signed)

@puju96 From a quick glance, the error you are running into is different from the other few reported in the Issue. It usually requires deeper investigation into each case. If you don’t mind, please reach out to our support via the Intercom bubble at bottom right of the portal. That will allow us to collect more details.

Closing this because what I have seen is that this Issue becomes a place where different cases of build failures are reported. For any new build failure, I’d suggest either reach out to support, or creat a new Issue that’s more specifically targeted.

That helped me: https://intercom.help/appcenter/build/ios/my-ios-builds-fail-with-clang-error-linker-command-failed-with-exit-code-1

@CSharped, I ran into a similar problem and I fixed it by updating CocoaPods and dependencies (the second part was probably not needed to solve this problem)

sudo gem install cocoapods
pod update

After that, I have checked-in the Podfile.lock, which updated by CocoaPods version to 1.6.1.
One more note, there is a page that lists the current versions of the libraries used by the MSAC agents: https://docs.microsoft.com/en-us/appcenter/build/software

Question: Did you update cocoapods locally, or with a custom build script?

@Faisal-Manzer I have just ran into the same problem (but for -lDoubleConversion) instead. Have you found a fix for this issue? My local pod is 1.8.4 and it is the same as AppCenter's pod version. XCode builds successfully locally.

@Faisal-Manzer I have just ran into the same problem (but for -lDoubleConversion) instead. Have you found a fix for this issue? My local pod is 1.8.4 and it is the same as AppCenter's pod version. XCode builds successfully locally.

I'm have a equal problem.

I don't remember how I solved that. It has been a long time.

Same problem with me
** ARCHIVE FAILED **

The following build commands failed:
	Ld /Users/runner/Library/Developer/Xcode/DerivedData/CONNECT2DTELEDENTAL-ermrhfotmwvxkccjppkrjravmuvl/Build/Intermediates.noindex/ArchiveIntermediates/CONNECT2DTELEDENTAL/InstallationBuildProductsLocation/Applications/CONNECT2D\ TELEDENTAL.app/CONNECT2D\ TELEDENTAL normal arm64
(1 failure)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65

Hello Guys,
Has anyone managed to fix it ?

In Appcenter Build from Swift/Xcode, I had a similar issue (archive failing, error code 65) but mine looked like it was failing to access files in a particular directory.
error: /Users/runner/runners/2.168.2/work/1/s/Pods/Target Support Files/...
I made two changes and the build succeeded afterward, and I think the success was related to the second change but for completeness I am listing both.
(1) Duplicate the shared schema for the workspace to create a project level version of the scheme that is also marked as shared
(2) Add Pods to source control and push those files to the Github repository I use for the appcenter build. (Before, I excluded pods from source control because they were not part of the workspace, so I believe the error was caused by appcenter looking for files that didn't exist in github)

Can you all verify the POD version and XCode versions are the same? (on local machine and app center)

+1 ,I am also facing the same issue

Hey guys, I found the solution.

Don"t commit  node_modules, Pods, PodFile.lock,package.json on git.
Again try to build it on Appcenter, It works

@Faisal-Manzer How did you resolve this issue ?
AppDelegate.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler
My Appcenter build getting failed

Mine is also failing too with the same problem.

I'm also getting the same issue
** ARCHIVE FAILED **

The following build commands failed:
	Ld /Users/runner/Library/Developer/Xcode/DerivedData/aLifeLived-hjrawomvzxvvvdeuplegfjyupvhr/Build/Intermediates.noindex/ArchiveIntermediates/aLifeLived/IntermediateBuildFilesPath/aLifeLived.build/Release-iphoneos/aLifeLived.build/Objects-normal/armv7/A\ Life\ Lived normal armv7
	Ld /Users/runner/Library/Developer/Xcode/DerivedData/aLifeLived-hjrawomvzxvvvdeuplegfjyupvhr/Build/Intermediates.noindex/ArchiveIntermediates/aLifeLived/IntermediateBuildFilesPath/aLifeLived.build/Release-iphoneos/aLifeLived.build/Objects-normal/arm64/A\ Life\ Lived normal arm64
(2 failures)
##[error]Error: /usr/bin/xcodebuild failed with return code: 65

Working with cordova Im having the same issue, when i run cordova build ios
** BUILD FAILED **

The following build commands failed:
        Ld /Users/mdiaz00147/Library/Developer/Xcode/DerivedData/Casey_Research-dtrhdvfxohusmcdsdwqwdixdxhpr/Build/Intermediates.noindex/Casey\ Research.build/Release-iphonesimulator/Casey\ Research.build/Objects-normal/arm64/Binary/Casey\ Research normal arm64
(1 failure)
xcodebuild: Command failed with exit code 65

Solution: Open the platform/ios folder with xcode and build it from there and i get it to work

For iOS simulator add this to params -arch x86_64

had .detoxrc.json like this:
"ios.sim.debug": {
      "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/Project.app",
      "build": "xcodebuild -project ios/Project.xcodeproj -scheme Project -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build",
      "type": "ios.simulator",
      "name": "iPhone 11"
    },

make it to:
"ios.sim.debug": {
      "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/Project.app",
      "build": "xcodebuild -workspace ios/Project.xcworkspace -scheme Project -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build -arch x86_64",
      "type": "ios.simulator",
      "name": "iPhone 11"
    },

then run:
detox build -c ios.sim.debug

this gives me bundle. then we can test:
detox test -c ios.sim.debug

I got this working on my m1 mac by setting up a rosetta terminal to run my react-native run-ios command
https://www.courier.com/blog/tips-and-tricks-to-setup-your-apple-m1-for-development/

I can't generate the build in app center I have this erro
==============================================================================
[command]/usr/local/lib/ruby/gems/2.7.0/bin/pod --version
1.11.3
[command]/usr/local/lib/ruby/gems/2.7.0/bin/pod install --repo-update
[!] Invalid Podfile file: cannot load such file -- /Users/runner/work/1/s/node_modules/react-native/scripts/react_native_pods.
from /Users/runner/work/1/s/ios/Podfile:1
-------------------------------------------

require_relative '../node_modules/react-native/scripts/react_native_pods'

require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
-------------------------------------------
##[error]The process '/usr/local/lib/ruby/gems/2.7.0/bin/pod' failed with exit code 1
##[error]The 'pod' command failed with error: The process '/usr/local/lib/ruby/gems/2.7.0/bin/pod' failed with exit code 1
##[section]Finishing: Pod install
##[section]Starting: Xcode build (not signed)


[Fedora] docker-compose up throws numerous errors

Log right here, I am a bit confused on what is going on
acrarium-error-2022-09-06.txt

Looks like your docker and/or system install is broken. Nothing related to acrarium in there

Solution was to ensure docker was enabled and running via systemctl


add PLGNFreeCString(str *C.char) to free the memory allocated by Golang using C.CString()

close #72

Hi @olomix,
Thanks for you response.
 Since this PR involves two repositories, I have provided a more detailed response in the PR for polygonid-flutter-sdk here: <https://github.com/0xPolygonID/polygonid-flutter-sdk/pull/390#issuecomment-2039790978>.

A concise description is: `PLGNFreeCString()` does not only provide a `C.free()` function for Flutter, but it should be understood as "Flutter/Dart informs Golang through this function that the memory block Golang allocated will not be used anymore, and Golang can handle this memory block subsequently".


Maven build missing

Issue
The documentation refers to a maven package link that does not exist.
Github has a page on publishing Java packages with Maven that may be useful.
There is also a configuration that can be done through Github Actions:

Checklist

[ ] Documentation updated with steps
[ ] Maven build published/available

Hey team! Please add your planning poker estimate with ZenHub @EvanParish @ianperera @jessecanderson @k-macmillan @kalbfled @maham360 @jakehova

Keeping to investigate.

We presently have to build a jar file and upload it to GitHub to make it available to our partners, so this would be helpful.


Bug in signature verification

I'm playing with binary data in text memo, and found a transaction whose signatures are valid but laboratory XDR viewer pretends the opposite:
See in XDR viewer
The transaction is actually published on the network:
See in explorer

Thanks, this has been fixed in<EMAIL_ADDRESS>but Laboratory's package.json was not updated. Will be deployed later today.
Fix in https://github.com/stellar/laboratory/commit/22c49944075b0bec9d6c6f64f035934d25e7506b.


CI: update release command

This one worked for me, and the previous one didn't.

I never understood how git figures out what's a branch name, and what's a remote, but I am quite ok with reflog, reset --hard and push --force-with-lease :D


Decrese second jump when picking video thumbnail

As of now, when choosing a thumbnail, it seems like the jumps are quite drastic about 2-3seconds.
I think it would be beneficial if the thumbnail range was decreased to 1 second or a sub-second time. This would allow for more precise thumbnail curation.
Thoughts?

Hm, which jump do you refer?

As of now, when choosing a thumbnail, it seems like the jumps are quite drastic about 2-3seconds.

Could you share a bit more context so I can get better understanding what should be improved? If you attach a video that illustrates the problem that would be perfect.

Could you share a bit more context so I can get better understanding what should be improved? If you attach a video that illustrates the problem that would be perfect.

https://youtu.be/yNWTS1VuHYU

If I understand well this is the time for the preview to update. This looks way too long indeed.

@s4cha @heitara any suggestions?


Upload last version to luarocks?

Hi there!
It seems that the last published version (v2.1-1) is outdated, as it uses struct dependency instead of the new bitops.
Is there a way to install the latest lua-websockets version using luarocks?
Thanks!

@endel i'll do a new release soon.

:+1:

sorry for being late. i'll try to do it today...

@endel @ntd done (v2.2) : https://luarocks.org/modules/lipp/lua-websockets

Thanks @lipp

@ntd you are welcome!


Underwater Combat effect definition

Needs MidiQOL 11.0.11 or higher and a bit more testing.

It seems that this needs to be available only if MidiQOL is active 🤔

Will reopen when this works... This will error out and I am on the way now 🤦

This should do it 🤔 🤞

Added a new foundry-helper to check for a module being active and its version against provided one
/**
   * Checks if the module provided is active and if yes and a version is provided, compares against its currect version
   *
   * @param {string} key - the module id
   * @param {string} version - the module version
   * @returns {Boolean} true if module.active+version > version OR true if module.active+!version
   */
  moduleActiveVersionCheck(key, version) {
    const module = game.modules.get(key);
    if (module && !version) return module.active;
    else if (!module) return false;
    else if (module.active && version)
      return foundry.utils.isNewerVersion(module.version, version);
  }

I hope this makes sense.

Maybe that would need to offer a bit more granularity to the MidiQOL specific effects it adds depending on the version of MidiQOL the user currently is.
So something like (pseudo)
if (midi.active) {/*initial check to add the MidiQOL folder*/}
if (midi.version >= target.version) {/*add a specific list of MidiQOL specific CEs*/}
if (!midiFolder.length) {/*do not display folder*/}

Might be better for the future, but only relevant if more and more such effects keep popping up. So for now it should be fine 🤔

I'm a bit confused. What happens when you don't do all these midi checks and midi is inactive? Does it actually error or just doesn't work as intended? Because if it just doesn't work, that seems reasonable enough. Maybe a new icon could and boolean flag could be added for midi specific rather than doing all this extra checking stuff.

I thought of just adding the MidiQOL ones (ones not having also a WIRE counterpart). only when the module is actually active, so as not to bloat the list of the in game available one.
If MidiQOL is inactive and someone adds the "available" Underwater Combat CE, it will just do nothing, but won't error AFAIK.
However, the use of evaluation conditions in AE values for Midi flags is somewhat new, so checking MidiQOL version for compatibility reasons might be needed.
If MidiQOL is active and underwater combat is available no matter what Midi version one is currently on, the results can be unpredictable, from erroring out to actually always evaluating to true, which in not ideal.


Right way to use pool worker option in sidekiq job

I am trying to invoke a sidekiq job from rails, I have tried passing "pool" worker option for sidekiq job, but somehow perform_async ignores this option and passes the job to default config sidekiq has been initialised with..
REDIS = ConnectionPool.new { Redis.new(url: '', namespace: '') }
Sidekiq::MyWorker.set("pool" => REDIS).perform_async()
Am I doing this right way?

Unfortunately ActiveJob doesn't support a couple of sidekiq options. pool is one of those options.
This is the second issue raised for this library regarding ActiveJob not passing sidekiq options. I'm planning on seeing if I can add a feature flag on the library to pass additional options through to sidekiq, though feel free to look into it yourself in the meantime 👍


Add type parameters

If you accept this PR please add hacktoberfest-accepted label on this PR.
Signed-off-by: Suraneti Rodsuwan<EMAIL_ADDRESS>

Hi,
Can you please explain what the point of that change is? (other than trying to land a PR for the Hacktoberfest ;-)
The way the code is currently written is perfectly legal Go code and doesn't even trigger any warning or similar from golint.

Hello,
I agree with you that the code is working perfectly but I think it would be good to make all function look the same code style,
some function parameters have a type but some haven't.
Ex.1 this func assetID parameter has type.
func (t *SimpleChaincode) AssetExists(ctx contractapi.TransactionContextInterface, assetID string) (bool, error) {
...
}

Ex.2 this func assetID parameter doesn't have type.
func (t *SimpleChaincode) TransferAsset(ctx contractapi.TransactionContextInterface, assetID, newOwner string) error {
...
}

P.S. I'm starting studying HyperLedger Fabric tutorial with Golang.

Thank you for the contribution, but all parameters have a type already - in Go it is idiomatic to not repeat the parameter type for multiple parameters in a row that have the same type.
Therefore let's Close this PR.

I just checked asset-transfer-basic and I forgot that it actually does enumerate the type for each of the parameters, so this PR would make the samples consistent. My apologies @suraneti ... I do agree it would be good to be consistent and I'm open to discussion on which approach is best.

@denyeart Thank you for the explanation and rechecking, Have a great day.


Do not update the picture

Here you can see the inconsistency. It is necessary to force the system to redraw these areas.
http://a.tile.openstreetmap.org/13/4935/2783.png
http://b.tile.openstreetmap.org/13/4936/2783.png
Road "T-21-11"
http://www.openstreetmap.org/#map=13/49.8647/36.9166

Hey @illiapoint - this isn't something that iD has any control over.  The tile server will just re-render those tiles after some short delay.  You can also force the tiles to re-render by appending /dirty to the end of the url.  (more info)


Handle empty testcases for AtCoder (e.g. AGC036 B)

I changed the behavior that oj download ignores empty testcases.
Such a testcase is found at AGC036 B.
This fix is only for AtCoder. It might be better to change implementations for other contests.

@yoshrc @kmyk
Ah sorry, due to remove develop branch, this PR is closed.
Could you create branch from master and create annother PR?

@kmyk @fukatani
OK. I opened #554.


Move Serialization to Json

I am thinking of moving all serialization to json. Any thoughts?

Due to the numeric nature of the data being stored in the model, does it make sense to use something like Protobuf-net designed for compact serialization and efficient loading to be used for serialization?  Looks like @mgravell has outdone himself on this project.  It appears to support a host of configurations including mono and various phone platforms and the .NET Compact Framework back to 2.0!

My goal is to have the serialized output be readable. Loading the models should be really fast (as they are not verbose) and happen only one time.

Then it sounds like json is the better tool. :-)


[FR] direction=reverse opcode

This feature request is for Sfizz to support:
direction=reverse opcode.
Specifically Sfizz should be able to work with the below SFZ example from René Ceballos:
<group> sample=wave_name_here.wav xf_cccurve=gain
<region> xfin_locc1=0 xfin_hicc1=127 direction=reverse
<region> xfout_locc1=0 xfout_hicc1=127

Then it's needed to add reverse_loccN to make this feature support complete.

The PR #185 does not handle offset correctly when the direction is reversed. (checked against CW)
A diagram below of how it should be.

Addendum/Correction:
The above depicts current Sfizz (orange color) vs Dropzone (green)

ARIA does it also like Sfizz current
Dimension, RXP do it like Sfizz current too!

Cakewalk products don't agree to each other, so it can be the case that this implementation is good.
It can be also argued that it's more useful.


Adding b256 bitwise operators (&, |, ^)

Adds the 3 basic bitwise operations (&, | and ^) for the b256 type. A follow-up PR (almost done) will add left & right shifting for b256s.

Poking @mohammadfawaz for review


Added discourse_marker_substitution

First commit fir discourse marker substitution transformer

Thanks for your changes @sileod. This is a very useful and promising PR. I'll provide my comments on the code.

The set of discourse markers is used from the PDTB (2008). Have you explored any recent work like the DimLex Lexicon (2018) to check the possibility of increasing the coverage ?
So, here is my overall review:
Correctness: Valid python code and passes tests.
Interface: The correct interface is chosen.
Specificity: This is a specific transformation and would be useful for testing robustness against discourse markers.
Novelty: This has not been implemented by earlier pull requests. The words might overlap with other transformations which use lexical substitution.
Description: The README is precise and well written.
Test Cases: They have been added.

The set of discourse markers is used from the PDTB (2008). Have you explored any recent work like the DimLex Lexicon (2018) to check the possibility of increasing the coverage ?
So, here is my overall review:
Correctness: Valid python code and passes tests.
Interface: The correct interface is chosen.
Specificity: This is a specific transformation and would be useful for testing robustness against discourse markers.
Novelty: This has not been implemented by earlier pull requests. The words might overlap with other transformations which use lexical substitution.
Description: The README is precise and well written.
Test Cases: They have been added.

Thank you for your remarks.
This task is indeed a lexical substitution, but wordnet is not a very good resource for discourse markers.
I considered using the Dimlex Lexicon, but unlike PDTB, it provides very few examples of markers usages. Dimlex can be used to know the possible senses of discourse markers, but it cannot directly be used to find markers with low ambiguity that can be substituted while keeping the meaning intact. Here, I prioritize precision over recall.

AssertionError: Mis-match in expected and predicted output for DiscourseMarkerSubstitution transformation:
E              Expected Output: She was untrained additionally, in one botched job killed a client. Her remorse was shallow and brief
E              Predicted Output: She was untrained in fact,, in one botched job killed a client. Her remorse was shallow and brief
E           assert 'She was untr...low and brief' == 'She was untr...low and brief'
E             - She was untrained additionally, in one botched job killed a client. Her remorse was shallow and brief
E             ?                   --------------
E             + She was untrained in fact,, in one botched job killed a client. Her remorse was shallow and brief

Sorry, just realized the tests are failing.

@samsontmr Hi, the commas were not removed. It is now working

Thank you very much for your changes. Your changes are merged. As NLP has largely focussed on high-resource languages and domains, if possible, we also encourage you to add a transformation in your mother tongue and/or a low-resource language which might need more attention from the NLP community. This is not mandatory.


Story: Lab 4 Redux conversion

Lab 1 Redux conversion
As a developer, I want to use native react context and reducers, so that they are consistent for all labs.
Associated Epic: #496
Definition of Done

[ ] Acceptance criteria defined
[ ] Solution tasks specified
[ ] Feature branch created
[ ] Unit tests written (on API code only for now)
[ ] Solution passes full suite of unit tests
[ ] Design documents updated if needed
[ ] Pull request created
[ ] Code is reviewed
[ ] Code is merged to develop branch
[ ] Tests pass on CI
[ ] Deployed to staging environment
[ ] Acceptance criteria is met

Acceptance Criteria

[ ] Given I am in the exercise, when I try to exit the activity, then then I am forced to stay in the exercise
[ ] Given when I am in the, when I change sections, then I am given the correct playing state information

Solution Tasks

[ ] [Task 1]
[ ] [Task 2]
[ ] [Task 3]

Lab 4 Completed


O.Path improvements (distribution, arrays)

🍩 Feature Request
Is your feature request related to a problem?
See @leebenson's comment on #57.
Describe the solution you'd like
Something which can do something like this:
type Nested = {
    a?: NestedA | NestedA[] | null | number;
    z: 'z';
};
type NestedA = {
    b?: NestedB | NestedB[] | null | number;
    y: 'y';
};
type NestedB = {
    c: 'c';
};
// resolves to 'c'
type C = O.P.At<Nested, ['a', 'b', 'c']>;

This follows on from the discussion on #57. From the previous discussion:

This is surprisingly non-trivial when it comes to nested arrays in the path... To do this with infinite nesting, we need a utility type to get the (nested) inner type of an array. However, this is impossible - see this TS Playground for an example of why it's impossible to implement.
However, if we restrict nesting to something absurd like four dimensional nested arrays, it could work, like in this TS Playground.

As an update to that, I believe this feature is impossible to get "perfect", for similar reasons to why getting the nested inner type of an array is impossible. In a type definition, you can't directly refer to the type definition without some sort of indirection - see the TS 3.7 blog post for more details on that.
Here's the code I tried:
type _At<O, Path extends Tuple<Index>, I extends Iteration = IterationOf<'0'>> =
  Pos<I> extends Length<Path>
  ? O // target
  : O extends object
    ? O extends (infer A)[]
      ? _At<A, Path, I>
      : Path[Pos<I>] extends infer K
        ? K extends keyof O
          ? _At<O[K], Path, Next<I>>
          : never // not key
        : never // impossible
    : never; // dive into not object

TypeScript 3.7 complains that it's a circularly referenced type. Adding a type Lazy<T> = T doesn't help either - I think the type system eagerly evaluates all branches of a conditional type at runtime (without expanding nested types like objects and arrays). That means we need to add some level of indirection at every level we traverse.
The other way of doing it is manually "unrolling" the recursion many times, like the ArrayType example above:
// from
type ArrayType<T> = T extends (infer A)[] ? ArrayType<A> : T;
// to
type ArrayType4<T> = T extends (infer A)[] ? ArrayType3<A> : T;
type ArrayType3<T> = T extends (infer A)[] ? ArrayType2<A> : T;
type ArrayType2<T> = T extends (infer A)[] ? ArrayType1<A> : T;
type ArrayType1<T> = T extends (infer A)[] ? A : T;

If we were to do this in O.P.At, it would result in pretty unreadable code. Instead, we could "wrap" the return value of the unlimited depth O.P.At with something { __wrap: T } (we want this wrapping to be unique so we don't accidentally unwrap a user's type) and "unwrap" it at the end with something like ArrayType above.
In fact, I found a way of getting 2n levels of recursion with n "unrolls" (Playground link) - so we can pretty easily get lots of unrolling with little code:
// unrolls (2*3)+1 = 7
type ArrayType7<T> = T extends (infer A)[] ? ArrayType3<ArrayType3<A>> : T;
// unrolls (2*1)+1 = 3
type ArrayType3<T> = T extends (infer A)[] ? ArrayType1<ArrayType1<A>> : T;
// unrolls 1
type ArrayType1<T> = T extends (infer A)[] ? A : T;

// resolves to number[]
type EightDimensions = ArrayType7<number[][][][][][][][]>;

We nest the double-types inside a conditional to prevent TypeScript from expanding the types to the user... and filling their screen with ArrayType1s 😛.
Using this, we can write some code that works on TypeScript 3.6:
// unwraps 15 { __wrap: T } levels
type Unwrap<T>  = T extends { __wrap: infer U } ? Unwrap7<Unwrap7<U>> : T;
type Unwrap7<T> = T extends { __wrap: infer U } ? Unwrap3<Unwrap3<U>> : T;
type Unwrap3<T> = T extends { __wrap: infer U } ? Unwrap1<Unwrap1<U>> : T;
type Unwrap1<T> = T extends { __wrap: infer U } ? U : T;

type _At<O, Path extends Tuple<Index>, I extends Iteration = IterationOf<'0'>> =
  Pos<I> extends Length<Path>
  ? O // target
  : O extends object
    ? O extends (infer A)[]
      ? { __wrap: _At<A, Path, I> }
      : Path[Pos<I>] extends infer K
        ? K extends keyof O
          ? { __wrap: _At<O[K], Path, Next<I>> }
          : never // not key
        : never // impossible
    : never; // dive into not object

type At<O extends object, Path extends Tuple<Index>> = Unwrap<_At<O, Path>>

type Nested = {
  a?: NestedA | NestedA[] | null | number;
  z: 'z';
};
type NestedA = {
  b?: NestedB | NestedB[] | null | number;
  y: 'y';
};
type NestedB = {
  c: 'c';
};
// successfully evaluates to 'c'
type C = At<Nested, ['a', 'b', 'c']>;

@pirix-gh What do you think? The ArrayType utility type could also come in handy as well, so we may want to add that to ts-toolbox too.

Silly me - I didn't realise Object.Path was in this library! Your Query implementation seems to be equivalent to an improved version of Object.Path.
I think improving Object.Path to fit this use case is probably better - in particular:

distributing over O
supporting arrays (should be gated behind a boolean flag in the library)

These two, in combination, should make Object.Path equivalent to your Query implementation.
This is relatively simple to implement, but writing tests / formatting / implementing the boolean flag is a bit tedious. Here's a modification of Object.Path which works as expected, without tests / the boolean flag:
import {Object, Iteration, Tuple, Any, Union} from 'ts-toolbelt'

type _Query<O, Path extends Tuple.Tuple<Any.Index>, I extends Iteration.Iteration = Iteration.IterationOf<'0'>> = {
  0:
    O extends object // distribution over O
    ? O extends (infer A)[] // supporting arrays
      ? _Query<A, Path, I>
      : _Query<Union.NonNullable<Object.At<O, Path[Iteration.Pos<I>]>>, Path, Iteration.Next<I>>
    : never
  1: O
}[
  Iteration.Pos<I> extends Tuple.Length<Path>
  ? 1
  : 0
]

export type Query<O extends object, Path extends Tuple.Tuple<Any.Index>> = _Query<O, Path>

type Maybe<T> = T | null;
type Organization = {id: 1}
type Workspace = {id: 2, name: string}
type OrganizationWorkspacesQuery = (
    { __typename?: 'Query' }
    & { organization: Maybe<(
      { __typename?: 'Organization' }
      & Pick<Organization, 'id'>
      & { workspaces: (
        { __typename?: 'WorkspaceConnection' }
        & { edges: Maybe<Array<(
          { __typename?: 'WorkspaceEdge' }
          & { node: (
            { __typename?: 'Workspace' }
            & Pick<Workspace, 'id' | 'name'>
          ) }
        )>> }
      ) }
    )> }
  );
// evaluates to { __typename?: "Workspace" | undefined } & Pick<Workspace, "id" | "name">
type Result = Query<OrganizationWorkspacesQuery, ['organization', 'workspaces', 'edges', 'node']>

Interestingly, in your given example Workspace is both the type of the result (Result in the code above) and a part of OrganizationWorkspacesQuery. Not sure how that works!
P.S. Object.Path is amazing - I'm impressed that something like it is possible in TypeScript's type system!

Hi all, I'm not into GraphQL, but I believe this should work:
import {IterationOf} from '../Iteration/IterationOf'
import {Iteration} from '../Iteration/Iteration'
import {Next} from '../Iteration/Next'
import {Pos} from '../Iteration/Pos'
import {Length} from '../Tuple/Length'
import {At} from './At'
import {Cast} from '../Any/Cast'
import {NonNullable as UNonNullable} from '../Union/NonNullable'
import {Index} from '../Any/Index'
import {Tuple} from '../Tuple/Tuple'

type _PathUp<O, Path extends Tuple<Index>, I extends Iteration = IterationOf<'0'>> = {
    0: At<O & {}, Path[Pos<I>]> extends infer OK
       ? OK extends unknown
         ? _PathUp<UNonNullable<OK>, Path, Next<I>>
         : never
       : never
    1: O // Use of `NonNullable` otherwise path cannot be followed #`undefined`
}[
    Pos<I> extends Length<Path>
    ? 1 // Stops before going too deep (last key) & check if it has it
    : 0 // Continue iterating and go deeper within the object with `At`
]

/** Get in **`O`** the type of nested properties
 * @param O to be inspected
 * @param Path to be followed
 * @returns **`any`**
 * @example
 * ```ts
 * ```
 */
export type PathUp<O extends object, Path extends Tuple<Index>> =
    _PathUp<O, Path> extends infer X
    ? Cast<X, any>
    : never

type Nested = {
    a?: NestedA | NestedA[] | null | number
    z: 'z';
};

type NestedA = {
    b?: NestedB | NestedB[] | null | number
    y: 'y';
};

type NestedB = {
    c: 'c';
    z: 'z';
};

// resolves to 'c' | 'z'
type CObject = PathUp<Nested, ['a', 'b', 'c' | 'z']>;
type CArray  = PathUp<Nested, ['a', 'b', number, 'c' | 'z']>;

@leebenson PathValid is a bit off topic, I think. The docs were mistakingly copied with the ones of Path. Here's what it does https://pirix-gh.github.io/ts-toolbelt/modules/object_pathvalid.html#pathvalid

PS @mcpower the PathUp implementation is able to go through unions while Path isn't able to do this. And I used number to go through the Array like you suggested.
What do you think?

@pirix-gh - looks great!
I made a slight modification to drop the number requirement, which I think makes it a bit more readable in the case of a GraphQL 'lens':
type _PathUp<
  O,
  Path extends Tuple.Tuple<Any.Index>,
  I extends Iteration.Iteration = Iteration.IterationOf<"0">
> = {
  0: Object.At<O & {}, Path[Iteration.Pos<I>]> extends infer OK
    ? OK extends (infer U)[]
      ? _PathUp<NonNullable<U>, Path, Iteration.Next<I>>
      : OK extends unknown
      ? _PathUp<NonNullable<OK>, Path, Iteration.Next<I>>
      : never
    : never;
  1: O; // Use of `NonNullable` otherwise path cannot be followed #`undefined`
}[Iteration.Pos<I> extends Tuple.Length<Path>
  ? 1 // Stops before going too deep (last key) & check if it has it
  : 0]; // Continue iterating and go deeper within the object with `At`

/** Get in **`O`** the type of nested properties
 * @param O to be inspected
 * @param Path to be followed
 * @returns **`any`**
 * @example
 * ```ts
 * ```
 */
export type PathUp<
  O extends object,
  Path extends Tuple.Tuple<Any.Index>
> = _PathUp<O, Path> extends infer X ? Any.Cast<X, any> : never;

Thanks so much to you and @mcpower for indulging my specific use-case! Really appreciate your time.

@leebenson I can't add your modified type to this lib, unfortunately. I need to follow some rules about consitency. And since we are talking about Path, number here means that we're going to access an index number on an Array. If your array was a Tuple you would be able to use 0 | 1 | 2....
So by acessing number, we mean to access anything within that Array/Tuple.
The second reason is that I don't see why we should treat Arrays/Tuples differently than Objects. I understand, that it makes your specific use-case more simple, but I don't see how consistent it is (for this lib). It is a pre-requisite for me to stay standard.
But if the number is the problem, you can probably use Index instead:
type CArray  = PathUp<Nested, ['a', 'b', Index, 'c' | 'z']>;
// we now know that we're accessing all indexes of an array/tuple

Maybe you could start a lib of your own for graphQL-related type helpers?
I'm glad we could help you. I'll probably proceed with publishing the PathUp in the next few days.
Let me know if there's anything else, before I close the issue :)

type Tuple = [
    [[[1]]],
    2,
    3
]

type test0 = PathUp<Tuple, [0, 0, 0, 0]>; // 1
type test1 = PathUp<Tuple, [Index]>;      // 3 | [[[1]]] | 2

👍 totally cool, my version only really applies to this limited use-case. Having the more flexible/general purpose as part of the lib is great.
Thanks again!


Inquiry about Determination of 'max' and 'norm' Values for Each Patient

Hi,
I'm seeking clarification on the process of determining the 'max' and 'norm' values for NYU patients. These values are crucial for intensity scaling during data analysis. Understanding their origins is pivotal to ensure accurate results.
We've attempted to calculate these values independently, but they don't match the values present in the h5 attributes.
While our code reads the 'max' and 'norm' values from the h5 file, it currently doesn't use them. However, an RIM reconstruction model relies on these values for intensity scaling.
This code reads in the max and norm value, but is not used further. However, an RIM reconstruction model uses these values for intensity scaling.
with h5py.File(fname, "r") as hf:
kspace = hf["kspace"][:]
calibration_data = hf["calibration_data"][:]
hdr = hf["ismrmrd_header"][()]
im_recon = hf["reconstruction_rss"][:]
atts = dict()
atts['max'] = hf.attrs['max']
atts['norm'] = hf.attrs['norm']
atts['patient_id'] = hf.attrs['patient_id']
atts['acquisition'] = hf.attrs['acquisition']
Your insights into this matter are greatly appreciated. Looking forward to your response.

Hello,
The norm and maximum values are calculated using:
norm = np.linalg.norm(im_recon[:])
max = np.max(im_recon[:])
In the code above, im_recon refers to the cropped reconstructed T2 image, i.e. im_recon = hf["reconstruction_rss"][:].

Hi,
Thank you so much!
That is very helpful.
So, if I understand correctly. You transform the k-space into image space by using the GRAPPA from the library. After this the max and norm are calculated. That is how I get the same values as logged in the h5 attributes 'max' and 'norm'.
This function assumes the calibration data to be in a specific format.
I am building my own dataset from two different institutes and have all the k-space in the correct format. However, I can't seem to get the calibration data in the right format. Would you be willing to share the code that transforms the .mrd calibration data into the array with shape (30, 20, 640, 32).
Thanks in advance!
Kind regards,
Quintin van Lohuizen
PhD Radiology
Email<EMAIL_ADDRESS>University Medical Center Groningen
University of Groningen

Van: radhikatibrewala @.>
Verzonden: donderdag 24 augustus 2023 18:41
Aan: cai2r/fastMRI_prostate @.>
CC: Quintin van Lohuizen @.>; Author @.>
Onderwerp: Re: [cai2r/fastMRI_prostate] Inquiry about Determination of 'max' and 'norm' Values for Each Patient (Issue #3)
Hello,
The norm and maximum values are calculated using:
norm = np.linalg.norm(im_recon[:])
max = np.max(im_recon[:])
In the code above, im_recon refers to the cropped reconstructed T2 image, i.e. im_recon = hf["reconstruction_rss"][:].
—
Reply to this email directly, view it on GitHubhttps://github.com/cai2r/fastMRI_prostate/issues/3#issuecomment-1692047588, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMQLNAYR6OVEFKUMJPGMKDXW574RANCNFSM6AAAAAA344U2LA.
You are receiving this because you authored the thread.Message ID: @.***>

Hello,
Sorry for the late response! We use the Python library Twixtools to read the calibration data from the raw data file.
Thanks
Radhika


Revert "Revert "Moving to OSGi-annotations.""

Reverting this since it seems like the ship has sailed, and new PR's not resolving these merge conflicts will be difficult and error prone.
We should evaluate if #1631  is possible before cutting v4.0.0

Honestly I think we just need to take the plunge.  We can't resolve the differences between SCR and OSGi ourselves.

Also, if we revert back to SCR annotations, Coveralls will likely stop working again.

yup .. see "the ship has sailed" .. now we just have to try to mitigate the effects the best we can..


Mini js

@isuftin, thanks for pointing me at the coastal hazards code for how to do the minification.

:+1: :+1:


Pos1 and End key behavior unexpected

Is your feature request related to a problem? Please describe.
When I use the Pos1 Key or End Key while writing notes in the Nextcloud Notes app the behavior is different from other editors I use.
It always jumps to the beginning after the last line break instead of the first position of the current visible line (or last positon for End)
Coming from https://github.com/nextcloud/notes/issues/508 the suggestion was to add the new functionality in upstream.
Describe the solution you'd like
Just like VSCode or Notepad++ is doing it (with enabled word wrap/automatic line break):
Pressing once jumps to beginning/end of visible line
Pressing twice jumps to beginning/end of current paragraph.
Describe alternatives you've considered
I understand that the current behavior is due to how Markdown works and maybe it is done intentionally like this. I hope that I am not the only one who would like this change and that there isn't somebody who formed a workflow around the current behavior.
If needed the functionality can be added configurable so that other projects can stay at the current behavior if they prefer.

This sounds like a useful feature but I expect it's really tricky to implement. Because of the responsiveness of the editor, it's not easy to determine where the cursor should go.

I was able to fix this by using the following keyMap:
easymde.codemirror.addKeyMap({
	'Home': 'goLineLeft',
	'End': 'goLineRight',
})

@Ionaru I'd really like this feature as well. The behaviour of the Home/End keys on a wrapped line is different with EasyMDE compared to anything else I've used, so I keep getting caught out by it. Would @korelstar's suggestion work here?


Add type definitions

Type definitions are here! I would consider these types "confidently beta." I tested it against the API manually from the server-side.
I have this project (branch: test/zabo-types) setup with TS and zabo-sdk-js types if you'd like to poke around. Just run npm run dev in ./zabo-backend-demo.
Note: To run the demo you must follow step #1 from the readme. You may also need to switch the hardcoded userId & accountId.
Potential Improvements

[ ] Type out errors
[ ] Type out Teams
[ ] Ensure all platform-specific functions are marked
[ ] zabo.teams & zabo.trading are undefined on Node (expected?)

Just did a rebase, I'm pretty sure everything went smoothly.


Backport "HBASE-28562 Correct backup ancestor calculation (#5868)" to branch-3

The ancestor calculation was wrong for incremental backups: when requesting the ancestors for an incremental backup X, the ancestors could include both full and incremental backups that predate the full backup on which X is built.
This caused a crash in incremental backup creation when data of old incremental backups was deleted through other means than the HBase API (i.e. without the HBase backup system table being updated).
Reviewed-by: Ray Mattingly<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m  6s
branch-3 passed

+1 :green_heart:
compile
0m 25s
branch-3 passed

+1 :green_heart:
checkstyle
0m 10s
branch-3 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 28s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
0m 29s
the patch passed

+1 :green_heart:
javac
0m 29s
hbase-backup generated 0 new + 100 unchanged - 4 fixed = 100 total (was 104)

+1 :green_heart:
checkstyle
0m  9s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 47s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 56s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

24m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5964

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 521d76bac457 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / e3aa767e95

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 11s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
2m 59s
branch-3 passed

+1 :green_heart:
compile
0m 19s
branch-3 passed

+1 :green_heart:
shadedjars
5m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
11m 46s
hbase-backup in the patch passed.

33m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5964

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e43abd4630c2 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / e3aa767e95

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/testReport/

Max. process+thread count
3152 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 24s
branch-3 passed

+1 :green_heart:
compile
0m 20s
branch-3 passed

+1 :green_heart:
shadedjars
6m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 59s
the patch passed

+1 :green_heart:
compile
0m 20s
the patch passed

+1 :green_heart:
javac
0m 20s
the patch passed

+1 :green_heart:
shadedjars
6m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
12m 59s
hbase-backup in the patch passed.

35m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5964

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 41fabc10fc1c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / e3aa767e95

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/testReport/

Max. process+thread count
3325 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
branch-3 passed

+1 :green_heart:
compile
0m 20s
branch-3 passed

+1 :green_heart:
shadedjars
6m 26s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
branch-3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
7m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
12m 41s
hbase-backup in the patch passed.

37m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5964

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6d7ddd0adf01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / e3aa767e95

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/testReport/

Max. process+thread count
3829 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5964/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Cookbook won't connect to the rundeck server due to outdated web.xml

Cookbook version
3.2.1
Chef-client version
12.17.44
Rundeck version
rundeck-2.8.4-1.33.GA
Platform Details
macOS Sierra 10.12.5 /w Vagrant Driver
Scenario:
Installing rundeck cookbook.
Steps to Reproduce:
Just run the cookbook OOTB /w the Rundeck version above.
Expected Result:
The cookbook should proceed to the next steps after having successful connection to the Rundeck server.
Actual Result:
The cookbook gets stuck on connecting to Rundeck stage. It reaches timeout after a certain time.
How I solved the issue:
Had to make a few changes in web.xml. These changes were takes from the Official Rundeck RPM (while preserving all the cookbook-template related sections).

I believe https://github.com/sous-chefs/rundeck/pull/164 will address this issue.

@voodoodror can you test this with cookbook 4.1.0?

I'm suspecting the same, will test soon.

nah, #164 didn't fix it.
Replaced web.xml with stock file from bpkg and rundeck starts up

Maintaining the web.xml as a Chef template is a real pain since they keep changing the packaged web.xml.

Have installed and am running 2.9.x using master with the version attribute changes in #178 in production, plus local tests/local CI and Travis for that PR, not come across Rundeck failing to start? Might be something else at play here?
Is it only 2.9.x you are seeing the issue with as you seem to suggest in #164?

I was going to try master but I thought 4.1.1 had the fix we needed....brb...

Well 4.1.1 == master just now, so it should 😄

@gsreynolds Huh?  Version 4.1.1 was done 28 days ago do someone just merge and push something???
Should I point metadata at master or leave it at 4.1.1 ( latest ) and try again?

Sorry, I meant, the current version 4.1.1 and the master branch are equivalent currently so either should work.
My experience in my is that #164 did fix it and I'm running 4.1.1/master with the version attributes overridden in a role to the values in #178 to install 2.9.3 and everything works as expected - I've not come across rundeck failing to start because of the web.xml template.

Using the debian package the rundeck_version ends up getting passed to the web.xml template as 1 and not 2.9.3

log[2.9.3, 1, GA.deb] action write[2017-08-30T18:46:16+00:00] INFO: Processing log[2.9.3, 1, GA.deb] action write (cb-rundeck::default line 22)
[2017-08-30T18:46:16+00:00] INFO: ["2.9.3", "1", "GA.deb"]
   * log[1] action write[2017-08-30T18:46:16+00:00] INFO: Processing log[1] action write (cb-rundeck::default line 23)
 [2017-08-30T18:46:16+00:00] INFO: 1

ahhh, our bad, someone set didn't use the full name 'rundeck-2.x.z-GA'
I'm on my way to getting this to work! Thanks.

So close, now after login I get an extra hostname in the redirect

ruby_block[connect rundeck api client] action run[2017-08-31T19:40:32+00:00] WARN: 404       POST    http://alphac-bvlt-r1nrdeck/alphac-bvlt-r1nrdeck/menu/home BODY:

Not sure if it's rundeck server config, or cookbook setting... any ideas anyone?

https://github.com/sous-chefs/rundeck/blob/01b5e6dba759baaf8e519ff746b05984c8b63608/recipes/_connect_rundeck_api_client.rb#L15
Check your values of node['rundeck']['grails_server_url'] and node['rundeck']['webcontext']. At a guess I'd suggest webcontext has been changed from the default of /


#42 Enhance the custom map pins

Only the bugfixed version this time around.

Forgot the xml.. Had to merge and now there's that annoying commit again, sorry for that.

@jacks0nX That's alright, squashing isn't nearly as bad when there's only one feature in each given PR. Let me test this out and see about getting it added

Looks good, merging now


Multiple bugfixes and updates, use requests for downloading etc.

I decide to make a pull request of my whole master branch since the changes are quite substantial.
Basic overview:

Fixes bugs in Semver and SemverRange: Comparing 2.0 < 0.5 now returns the correct result, ranges such as ">= 0.5, < 2.0" now parse as well

Replace httplib with requests. httplib was very slow for me and prone to timing out. Requests is more reliable and the code is simpler (and requests is a very common python module so any distribution should have it)

Use py.test for unit tests rather than just having a --test-semver flag and printing comparisons. This way there'll be actual failures reported if the results change unexpectedly.

Hook up to Travis CI to run the tests there.

Integrate patches for defaulting to crate name as library name and adding --no-download flag

Code cleanups, try to follow PEP-8 a bit more closely

Don't require the cargo directory to be a proper git repository, all we need is the Cargo.toml file anyway and this way it's possible to use the official release tarball as the base source.

Add --urls-file command line argument to write all the downloaded URLs to a file. This is useful for distribution packaging.

@krig this is awesome! Thank you!

@krig i agree. good work.

Shucks, thank you both. :)
On Wed, Aug 10, 2016 at 5:32 AM, Dave Huseby<EMAIL_ADDRESS>wrote:

@krig https://github.com/krig i agree. good work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dhuseby/cargo-bootstrap/pull/17#issuecomment-238756965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABjt-rLWEm1-gy2cKjKww8jqC_DhVw2ks5qeUZCgaJpZM4Id-zN
.


[dashboard]CSS Templates not working

A clear and concise description of what the bug is.
Expected results
Black background is preserved after refresh
Actual results
Black background missing after refresh
Screenshots

How to reproduce the bug

Go to 'Any dashboard'
Click on 'Edit dashboard > Edit CSS'
Save CSS template
Refresh browser
See error

Environment
(please complete the following information):

superset version: 0.38.0
python version: based on superset version 0.38.0
node.js version: based on superset version 0.38.0

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

could it cause by our native filter feature flag? @rusackas

could it cause by our native filter feature flag? @rusackas


build: add workflow_dispatch for publish autodoc and openapi ui

What this PR changes/adds
Add the possibility to trigger publish "autodoc" and "openapi ui" manually
Why it does that
looks like that didn't work during the release
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.09%. Comparing base (7f20ba5) to head (e6d0a12).
Report is 175 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4059      +/-   ##
==========================================
+ Coverage   71.74%   74.09%   +2.35%
==========================================
  Files         919      989      +70
  Lines       18457    20081    +1624
  Branches     1037     1120      +83
==========================================
+ Hits        13242    14880    +1638
+ Misses       4756     4722      -34
- Partials      459      479      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Warning from characteristic "active"

Describe The Bug
The plugin works, but the log is flooded with the following error:
[2.5.2024, 07:34:28] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 07:48:57] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 07:52:22] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 08:51:56] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 09:01:32] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 09:14:41] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
Expected behavior
A log without errors :)
Logs
[2.5.2024, 07:34:28] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 07:48:57] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 07:52:22] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 08:51:56] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 09:01:32] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[2.5.2024, 09:14:41] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
Plugin Config
{
"name": "Levoit Air Luftreiniger",
"email": "xxx",
"password": "xxx",
"platform": "LevoitAirPurifiers"
}
Plugin Version
v3.0.1
Homebridge Version
v1.8.1
Node.js Version
v18.19.0
NPM Version
n/a
Operating System
Raspberry

Getting the same error with a Core200
[05/05/2024, 12:14:23] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[05/05/2024, 12:14:36] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[05/05/2024, 12:16:40] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.
[05/05/2024, 12:16:49] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'Active': characteristic value expected valid finite number and received "undefined" (undefined). See https://homebridge.io/w/JtMGR for more info.

Same issue with 200S

Ditto on my core600s running as a child bridge. There are quite a few of these messages polluting the logs which makes debugging   other issues a bit harder. Doesn't seem to affect functionality though.

I'm also seeing this on the core600s.

Same for me, child bridge and all.

When will the error be fixed?

core 300s is producing the same log messages

Same! Core 200s is also producing this log message:
[10/24/2024, 6:56:04 PM] [homebridge-levoit-air-purifier] This plugin generated a warning from the characteristic 'On': characteristic value expected boolean and received undefined. See https://homebridge.io/w/JtMGR for more info.
[10/24/2024, 6:56:04 PM] [homebridge-levoit-air-purifier] Error:
at On.Characteristic.characteristicWarning (/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:3016:105)
at On.Characteristic.validateUserInput (/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2892:12)
at On. (/homebridge/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Characteristic.ts:2410:24)
at step (/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:195:27)
at Object.next (/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:176:57)
at fulfilled (/homebridge/node_modules/homebridge/node_modules/tslib/tslib.js:166:62)

When will the error be fixed?

I am getting these errors every few minutes as well. Do you happen to have any updates on this?


1.21.21 not working

currently 1.21.21 isn't working woundering if this addon is still being updated or not

Same for me. In the latest version, the enchantment table can be placed. However, the floating book is missing and you cannot interact with the table.


no anything？

what？

Hey there !
I have a really simple version up and running which we're using at my company.
I always planned to extend it with the ability to actually be able to configure the settings as well, but never got around to have the time to actually do that. I always thought someone would probably created a better version of this by now?
Would this even be useful to you in its current state ?

Ok i've uploaded the addon and added a small readme which does provide the most important information about the addon


Fix NPE if timestamp is optional in DB

Correct the typo Timesamp...

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@elakito please help review and merge if necessary


Link to university page down...

Hi,
the link to the university page of the project (start page) is outdated..
https://escience.uni-tuebingen.de/spacialist
:)
Best,
Martin

Hi,
I have updated the link to point to https://uni-tuebingen.de/de/211099.
@v1r0x Do we have a better URL for the project like dh-center.uni-tuebingen.de/spacialist (which right now leads only to the apache default site)

Where did you find these links?

think its project settings or something... the link that shows up in the upper right corner of the projects main page...

I've updated the link in the About section. Is this what you mean?
@DavidKi which link is updated?

tiptop ...


Getting 412 (Pre Condition Fail) & unsupported version Error

I am using this with TUS server, with following configurations. on file upload I get an error the error is attached in screenshot.

    settings: UppyConfig = {         uploadAPI: {             endpoint: 'http://localhost:1080/files',         },         plugins: {},         restrictions: {             maxFileSize: 1000000,             maxNumberOfFiles: 10,             minNumberOfFiles: 1,         },         statusBarOptions: {             showProgressDetails: true,             hideAfterFinish: false,             hideCancelButton: false,             hidePauseResumeButton: false,             hideProgressAfterFinish: false,             hideRetryButton: false,             hideUploadButton: false,         },         uploaderLook: {             theme: 'Dark',         },         options: {             autoProceed: false,             allowMultipleUploads: true,             browserBackButtonClose: false,             debug: true,         },     };

Hello @atungeker, did you find a solution for this issue?
I am getting the exact same error with the angular wrapper.
I tried previously with uppy v1.29.1 in a plain html site and it worked fine.
I tried with different versions of tusd and always get the same error.
tusd log looks like this:
[tusd] 2021/07/07 19:29:22 event="ResponseOutgoing" status="412" method="POST" path="" error="unsupported version" requestId=""

@adritasharma I believe you can close this issue.

Not yet, I have to update the package. It seems I have to upgrade the
project to latest Angular version. I will close it once I am done. It might
take some time.
On Fri, 16 Jul 2021 at 9:18 PM, Frédéric Morin @.***>
wrote:

@adritasharma https://github.com/adritasharma I believe you can close
this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adritasharma/uppy-angular-library/issues/19#issuecomment-881545277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7KMU5WZXQGOKVJAFPVNDDTYBIF5ANCNFSM43KTXKAA
.

The package is upgraded to v0.1.6

Thank you so much @adritasharma. I will try this when I am back from vacations!


Fix PLV8_VERSION build directory suffix

This is for turning v2.0.0 to 2.0.0?

This only fixes the cd /tmp/build/plv8-v2.0.0 when it should have been cd /tmp/build/plv8-2.0.0 when building. If you enable Travis we can get the build status tested instead of having a failure on Docker Cloud.

ok travis enabled.

Awesome, thank you. Watching the master build.

Since the 1.5 and 2.0 builds require building v8 from source, it might worth considering creating v8 images and use travis to build with volume-mount, and then push to docker hub from travis' after_success rather than relying on docker hub/cloud's build infrastructure.

That sounds like a good idea, even though I don't expect many releases from PLV8.


Add EternalTask as bundled plugin

Close #61

Coverage increased (+0.04%) to 95.284% when pulling 200793cb0b91b4b8c04d08caf0dc1ef166ff6466 on feature/external-task-plugin into f5b0c3536f3b6f16884d36e03b9f54786f28b644 on master.


Driver Plugin Architecture

fixes #22

Merging to driver_plugins branch for additional testing and review. Final merge to main will not be done until all is confirmed working


Add option to integrate with vite-plugin-relay-lite

vite-plugin-relay-lite has some advantages like providing smooth integration with the Relay compiler, and transforming the code really fast. While I think it shouldn't be recommended in general (since it doesn't actually parse AST, which makes it break on some cases), I believe it's worth adding an option for it.

I don't think I'll add support for it. I'm already having trouble with vite-plugin-relay, since it does not support Vite 3.
Adding another library that might break in the future, increases the maintainance cost on this project, which I don't want to happen. The Vite + Relay community also seems to be rather small (not even 70 combined stars for both libraries), so introducing this dependency doesn't seem worth it to me. The only real selling point over vite-plugin-relay is being faster, while being higher risk in all other areas, e.g. custom config resolution, no AST traversal as you mentioned and possibly slight differences to how the official babel-plugin-relay and the relay-compiler works now (and possibly in the future). I like the adapter approach of vite-plugin-relay more, since even though it might not be as fast, it's consistent to the official implementation. I also submitted a PR to it where I added Vite 3 support and moved all of the configuration of babel-plugin-relay out of the code and made the dependency a peerDependency, so it's truly just an adapter and everything around configuration and updating is the responsibility of the user.
Sorry for the bad news. I hope my stance is reasonable. Forking the project and introducing support yourself is of course always an option :)


Analyse State of California as the AOI

Ideally we would use the state of California as AOI for the first iteration. If this is too big, we could subset the state further.
For this we need to think about two aspects:

Availability of OSM tags
Generation of image tiles and embeddings for training

Looking good, we are working on California.


[range-v3] updates REF to range-v3:HEAD

Closes #21391.
Describe the pull request

What does your PR fix?
Fixes #21391

Which triplets are supported/not supported? Have you updated the CI baseline?
Unchanged

Does your PR follow the maintainer guide?

Yes.

if you need head version and not a release one, why not installing it using --head tag?

if you need head version and not a release one, why not installing it using --head tag?

Two reasons:

vcpkg manifests don't seem to support a --head option.
The latest release of range-v3 is 0.11.0, which is pretty stale now. range-v3 doesn't issue releases all that often.

agree for manifest but that's not a valid point for this PR.
Also, this HEAD is valid only for today, because it's fixed by the commit you put into the vcpkg_from_github command.
A valid solution would be to move to version-date in vcpkg.json and put commit's date, then remove any "head" reference you put in the port file, and hope that vcpkg maintainer move range-v3 from a release-based port to a date-commit based port

agree for manifest but that's not a valid point for this PR. Also, this HEAD is valid only for today, because it's fixed by the commit you put into the vcpkg_from_github command.
A valid solution would be to move to version-date in vcpkg.json and put commit's date, then remove any "head" reference you put in the port file, and hope that vcpkg maintainer move range-v3 from a release-based port to a date-commit based port

Ah, gotcha. To paraphrase: you're in favour of the PR, but want to see "head" changed to the commit-date?

When following the advice by GitHub Actions, I get this:
$ ./vcpkg x-add-version --all
Error: Local changes detected for range-v3 but no changes to version or port version.
-- Version: 2021-11-02#2
-- Old SHA: e7735ee7049d2de2753aa92649599bba68681f5c
-- New SHA: c61fd3747fcd7908eec6f482af77edb6b3064c3b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

now it's ok, apart from that port-version should have not been bumped, on the contrary it should have been removed, because version(-date) now is different from before - it's an update!
(it should be bumped only when keeping commit identical in the vcpkg_from_github call and you are fixing other things in the port - in that case version(-date) stays the same, you bump port-version, i hope it's clear...)

Thanks for the update!


Is it necessary to add attribute ‘target’ to Link class?

eg. Link('Google', 'http://www.google.com/', target='_blank')

I had create a pull request: Link object can set attributes


Dockerize rust

I added a Dockerfile for Rust which builds and runs in different containers.
Usage
To build the image execute:
docker build -t bench-rust .
Then you need to create a container:
docker create --name bench-rust -p 8080:8080 bench-rust
Then you can start the container like this:
docker start bench-rust
For stopping and removing the container execute the following line of code:
docker stop bench-rust && docker rm bench-rust

You got the commit from your other PR in this one :)

oh, damn, ill try to fix it

Also, please use alpine for the runner and statically-link the executable

Ok, then ill just do it again with a different branch and delete this one

Just pushed out the new changes, now the Dockerbuild checks whether its on aarch64 or on x86 and then builds the static binary for the system.
The binary then runs in a scratch system, so not even something like /bin/sh there and it proves that it is definitely statically linked. Any other improvements?

Looks good, but I would still prefer an alpine runner for the sake of comparability.

Ok, sure I'll do that soon in DDCA

@vypxl I now switched to alpine, im now gonna try to resolve the merge conflicts


fix: e2e tests, tsconfigs, @deprecated directive for codegen:

Description of changes:

Fix tsconfig for e2e projects, introduce build-tests script
Udpate some e2e test dependencies and code to make sure its compiled and can be run successfully by ts-jest
Update @deprecated directive for codegen to include field_definition and enum_value as allowed nodes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3338 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #3338    +/-   ##
========================================
  Coverage   60.13%   60.13%
========================================
  Files         254      254
  Lines       12439    12439
  Branches     2437     2576   +139
========================================
  Hits         7480     7480
+ Misses       4637     4621    -16
- Partials      322      338    +16

Impacted Files
Coverage Δ

...ges/graphql-transformer-core/src/util/fileUtils.ts
11.76% <0%> (ø)
:arrow_up:

...psync-simulator/src/resolvers/pipeline-resolver.ts
9.37% <0%> (ø)
:arrow_up:

...es/graphql-dynamodb-transformer/src/definitions.ts
84.84% <0%> (ø)
:arrow_up:

packages/amplify-appsync-simulator/src/index.ts
73.68% <0%> (ø)
:arrow_up:

...c-simulator/src/schema/directives/aws-subscribe.ts
26.66% <0%> (ø)
:arrow_up:

...amplify-appsync-simulator/src/server/operations.ts
28.45% <0%> (ø)
:arrow_up:

...mplify-appsync-simulator/src/resolvers/function.ts
9.67% <0%> (ø)
:arrow_up:

...lify-graphql-types-generator/src/compiler/index.ts
90.32% <0%> (ø)
:arrow_up:

packages/graphql-mapping-template/src/print.ts
37.77% <0%> (ø)
:arrow_up:

...es/graphql-transformer-core/src/stripDirectives.ts
35.29% <0%> (ø)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7348b...4ba1837. Read the comment docs.


Global Search

Hello,
Is it possible to have general search? if yes, please how can I do it?
Thank you!

There is a standalone search box example here...   https://akveo.github.io/ng2-smart-table/#/examples/using-filters

Thanks a lot :)


19.6.2 release

attached 19.6.1 tag without bumping up the version, redo release as 19.6.2

It's bad you didn't fix this bug in 19.6.2 :(


Identifiers validation failed for dataset Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila

Identifier validation failed for the dataset Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila:

Crawler attempt: 323
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 99
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 99 total records; 99 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3740112/step

New IDs sample:

Old IDs sample:

00da192641c1ddc85e3dd36ad89cde15
0710a6e3a393f45df46e57b80c82d2ba
085f156886e0be5911552fbe2b3f5c17
08d2d6f4f0ecb860687e9210e484089b
09be0c5037913d3894d1441650c04824
0c0b525bbe4789bfee0c92b97729861f
10211214a0f6c717adf6dd167fa58729
164607a095e351ede2475bc633ddc73c
20c6d9c76d8e395a0bbd86a4bd6f85d6
254cdce810e3631bf4870396e4f71a42

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila : https://doi.org/10.15468/cmfwpr.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila:

Crawler attempt: 324
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 99
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 99 total records; 99 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741045/step

New IDs sample:

Old IDs sample:

00da192641c1ddc85e3dd36ad89cde15
0710a6e3a393f45df46e57b80c82d2ba
085f156886e0be5911552fbe2b3f5c17
08d2d6f4f0ecb860687e9210e484089b
09be0c5037913d3894d1441650c04824
0c0b525bbe4789bfee0c92b97729861f
10211214a0f6c717adf6dd167fa58729
164607a095e351ede2475bc633ddc73c
20c6d9c76d8e395a0bbd86a4bd6f85d6
254cdce810e3631bf4870396e4f71a42

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila : https://doi.org/10.15468/cmfwpr.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila:

Crawler attempt: 326
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 99
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 99 total records; 99 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741683/step

New IDs sample:

Old IDs sample:

00da192641c1ddc85e3dd36ad89cde15
0710a6e3a393f45df46e57b80c82d2ba
085f156886e0be5911552fbe2b3f5c17
08d2d6f4f0ecb860687e9210e484089b
09be0c5037913d3894d1441650c04824
0c0b525bbe4789bfee0c92b97729861f
10211214a0f6c717adf6dd167fa58729
164607a095e351ede2475bc633ddc73c
20c6d9c76d8e395a0bbd86a4bd6f85d6
254cdce810e3631bf4870396e4f71a42

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Ecología de comunidades microbianas en las aguas subterráneas de Cuatrociénegas, Coahuila : https://doi.org/10.15468/cmfwpr.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Exclude entire file?

Is there something I can put at the top of a file to have the file be excluded entirely from autoflake? I don't want to use command-line options, since I have my editor set up to auto-run autoflake on my whole project, and I don't wanna mess with those settings. I just want to quickly be able to disable autoflake for a whole file that I'm working on.

+1 to this, it would be a great feature to have!


Threads aren't released

The threads for each feature are not released after execution. This results in a Exception in the following exception:
thread "Exec Default Executor" java.lang.OutOfMemoryError: unable to create new native thread
This happens when the approximately 2040 threads are allocated to the java proces on my MacBook with 16 Gb of memory. This problem would be solved by releasing threads after each feature is completed.

The problem is not related to this project. The same problems arise when running the cucumber tests from a unit test.


[Feature request] Allow per actor or creature type variations for health states

I'd like a different variation for zombies or ghosts as they don't really get injured like other things do. Same goes for other creatures liek gelatinous cubes or constructs. would be nice to have

Making it specific to a creature type is really challenging, considering each system has its own place to store their "creature type" list. Even for 5e alone that would be tough due to how to set the data for that.
I've made a Keybinding that pops a Dialog Window that lets you input your own Stages, it'll save the flag for the Actor. As in, you can drop 1 zombie, give it Custom Stages, then drop more zombies. They'll share the same stages as the first, but you'll have to do it again for another actor. Hope this at least makes it easier for you.

oh that's actually super useful. If that could be set as a permanent setting per actor (as in i can set it and then it's like that when i pull it out) then i'd gladly manually set them all, but just this will really help with having some creatures show damage instead of injury or similar


Adding a low-pass filter before downsample reduces aliasing quite dramatically when using non-linear processing at higher rate (96k or 192k)

This pull request fixes the aliasing by adding a simple low pass filter in the resample container just before downsampling.
This commit implements https://github.com/sdatkinson/AudioDSPTools/issues/10
The original resampling code did not have a lowpass filter before downsampling. This creates a lot of alias because the NAM block creates a lot of harmonic distortion, thus content above nyquist limit of the target signal.
For example, see here from up to down. 1) reaper 4x effects oversampling 2) original NAM 0.7.8 oversampling
3) This PULL request: input signal 48k -> upsample 192k -> NAM 192k -> lowpass 0.9*24k -> downsample 48k.

Could you include this in the main version of the plugin, it would greatly improve the alias behaviour when using NAM captures of higher sampling rates and input / output at lower sampling rates.
Let me know if further work / study is needed.

I'm sorry, but this is not the right way to go about doing this.
The purpose of the Lanczos-filtering resampler is to low-pass when resampling. Have a look at Lanczos resampling to learn more.
The problems with your solution are:

It only works when the sample rate of the container is higher than the surrounding context. If the external context is running at 96k and the encapsulated context is at 48k, then this doesn't work.
using a biquad low-pass filter has phasing effects that leak into the high frequencies. (sinc-type resampling filters have "pre-ringing", so they're not perfect either. All of these sorts of solutions have compromises...)

If you want to improve aliasing around the resampler, I'd suggest getting more familiar with the Lanczos algo that's happening. It's possible there's a bug in it (or how it's getting used here)--in which case I'd be happy for a fix. But if you really wanted a first-order LPF for anti-aliasing, then I'd recommend (1) implementing an extension to the Lanczos resampler to apply the LPF in addition then (2) refactoring the resampling container here to use different resampler modules (i.e. your Lanczos+LPF).
Related question: how are you generating your spectrogram plots? Knowing how to make those would help me dig into this myself as well 🙂

Thank you for your comments! It would be great if someone in addition to me could look at this! Currently this LP filter is the only way I can get rid of the huge amount of aliasing when using 96kHz NAM captures.
To debug it, I just render a sine sweep through NAM in Reaper and visualize it by turning on the Reaper’s waveform+spectrogram view.  In my tests the spectrogram visuals match very well with listening tests when one listens to a sweep at higher frequencies e.g., ~6-12kHz.
Here is one Lanczos resampler where they explicitly state “If used for downsampling, make sure to apply an appropriate anti-aliasing lowpass filter first.”. https://docs.obspy.org/master/packages/autogen/obspy.signal.interpolation.lanczos_interpolation.html
Do we have an example of good-quality Lanczos (or any other method) audio downsampling implementation that works well without a low-pass filter in case where there is a lot of energy above Nyquist of the target samplerate? I had always assumed most downsampling methods need a LP.
Based on  Oli's comments, I first tried changing this line: https://github.com/sdatkinson/NeuralAmpModelerPlugin/blob/51e151f1bf908d5709e082feacf603c607f241b4/NeuralAmpModeler/NeuralAmpModeler.h#L192, but there was no change in the aliasing - could it be that the value is not passed down to the actual resampler? Or as you said, maybe the resampling algorithm has a bug, who could debug it?
Answers:

I am taking a min of the sample rates of the container and external context, so in that case the low-pass would still be ok (0.9*24kHz). https://github.com/sdatkinson/AudioDSPTools/blob/58e495e6e6ea30f61010868ed888e10bd3cb36e1/dsp/ResamplingContainer/ResamplingContainer.h#L140. But actually, I think in that case the filter should be run before the first resampling, since that is the one doing the downsampling.
I am planning to experiment with steeper filters, but for my tests this is already quite good for my purposes.

Regarding your suggestion on refactoring to Lanczos resamples, I am happy to do that if it would allow this method to be merged!

It seems that changing the 2nd order filter to 4rd order filter (24dB/oct) reduces the aliasing even further and now it seems to be very close to Reaper plugin quality. From top: 1. reaper, 2. 12dB/oct, 3. 24 db/oct

The code is in this branch: https://github.com/sdatkinson/AudioDSPTools/compare/main...honkkis:AudioDSPTools:WIP_steeper


npm ERR! ERESOLVE unable to resolve dependency tree when doing npm install under examples/svelte-hydration

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

Fastify version
3.29.1
Plugin version
3.0.0-beta.24
Node.js version
18.6.0
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
12.4
Description
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vite
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@sveltejs/vite-plugin-svelte
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
Steps to Reproduce
Go to examples//svelte-hydration then npm i.
Expected Behavior
npm i should succeed installing dependencies.

I'm having the same issue did you find a solution?